Small tweaks for autoconf mode
[bpt/emacs.git] / src / ChangeLog
CommitLineData
3193acd2
DA
12012-08-01 Dmitry Antipov <dmantipov@yandex.ru>
2
3 Use INTERNAL_FIELD for processes.
4 * process.h (PVAR): New macro. Adjust style.
5 (struct Lisp_Process): Change Lisp_Object members to INTERNAL_FIELD.
6 * print.c, process.c, sysdep.c, w32.c, xdisp.c: Users changed.
7
3a45383a
DA
82012-08-01 Dmitry Antipov <dmantipov@yandex.ru>
9
10 Use INTERNAL_FIELD for windows.
11 * window.h (WVAR): New macro.
12 (struct window): Change Lisp_Object members to INTERNAL_FIELD.
13 * alloc.c, buffer.c, composite.c, dispextern.h, dispnew.c, editfns.c:
14 * fileio.c, font.c, fontset.c, frame.c, frame.h, fringe.c, indent.c:
15 * insdel.c, keyboard.c, keymap.c, lisp.h, minibuf.c, nsterm.m, print.c:
16 * textprop.c, w32fns.c, w32menu.c, w32term.c, window.c, xdisp.c:
17 * xfaces.c, xfns.c, xmenu.c, xterm.c: Users changed.
18
c1dbc63c
PE
192012-08-01 Paul Eggert <eggert@cs.ucla.edu>
20
21 * coding.h (CODING_ATTR_FLUSHING): Remove; unused and wouldn't work.
22
5c0c0e8a
GM
232012-08-01 Glenn Morris <rgm@gnu.org>
24
25 * lisp.h (IS_DIRECTORY_SEP, IS_DEVICE_SEP, IS_ANY_SEP):
26 Move to configure.ac.
27
552a99b4
JB
282012-08-01 Juanma Barranquero <lekktu@gmail.com>
29
30 * makefile.w32-in (CONFIG_H): Update dependencies.
31 (CONF_POST_H): New macro.
32
33 * s/ms-w32.h (SEPCHAR, NULL_DEVICE): Remove; moved to nt/config.nt.
34
8d8e2dfe
GM
352012-07-31 Glenn Morris <rgm@gnu.org>
36
bc96620a
GM
37 * Makefile.in (S_FILE): No longer set by configure.
38
476b1b2d
GM
39 * conf_post.h (config_opsysfile): Move earlier, so that WINDOWSNT
40 is available.
41 (alloca.h) [WINDOWSNT]: Don't include it on MS Windows.
42
b2c7a106
GM
43 * process.h (NULL_DEVICE):
44 * emacs.c (SEPCHAR):
45 * editfns.c (USER_FULL_NAME): Let configure set them.
46
d53d062a
GM
47 * s/README, s/template.h: Remove files.
48
4515017f
GM
49 * conf_post.h [HPUX]: Undefine HAVE_RANDOM and HAVE_RINT.
50
8d8e2dfe
GM
51 * conf_post.h (AMPERSAND_FULL_NAME, subprocesses):
52 Move to configure.ac.
53
5b20b3cc
EZ
542012-07-31 Eli Zaretskii <eliz@gnu.org>
55
1e0afd9a
EZ
56 * .gdbinit (xframe): Adapt to introduction of FVAR and the
57 resulting renaming of 'struct frame' members.
58
5b20b3cc
EZ
59 * w32menu.c (w32_menu_show): Revert bogus introduction of FVAR.
60
61 * fontset.c (dump_fontset): Fix compilation with ENABLE_CHECKING
62 after introduction of FVAR.
63
f1310128
JD
642012-07-31 Jan Djärv <jan.h.d@swipnet.se>
65
79e721e0
JD
66 * nsmenu.m (update_frame_tool_bar): Change key from NSObject* to id.
67
68 * nsterm.m (ns_draw_fringe_bitmap, ns_dumpglyphs_image): Use drawInRect
69 instead of compositeToPoint.
70 (applicationShouldTerminate): Pass NS String literal to NSRunAlertPanel.
71
8d7c7eed 72 * nsfns.m, nsmenu.m, nsterm.m: Adopt to struct frame/FVAR changes.
f1310128 73
e34f7f79
DA
742012-07-31 Dmitry Antipov <dmantipov@yandex.ru>
75
76 Generalize INTERNAL_FIELD between buffers, keyboards and frames.
77 * lisp.h (INTERNAL_FIELD): New macro.
78 * buffer.h (BUFFER_INTERNAL_FIELD): Removed.
79 (BVAR): Change to use INTERNAL_FIELD.
80 * keyboard.h (KBOARD_INTERNAL_FIELD): Likewise.
81 (KVAR): Change to use INTERNAL_FIELD.
82 * frame.h (FVAR): New macro.
83 (struct frame): Use INTERNAL_FIELD for all Lisp_Object fields.
3a45383a
DA
84 * alloc.c, buffer.c, data.c, dispnew.c, dosfns.c, eval.c, frame.c:
85 * fringe.c, gtkutil.c, minibuf.c, nsfns.m, nsterm.m, print.c:
86 * term.c, w32fns.c, w32menu.c, w32term.c, window.c, window.h:
e34f7f79
DA
87 * xdisp.c, xfaces.c, xfns.c, xmenu.c, xterm.c: Users changed.
88
c09bfb2f
DA
892012-07-31 Dmitry Antipov <dmantipov@yandex.ru>
90
91 Miscellaneous fixes for non-default X toolkits.
92 * xfns.c (Fx_file_dialog): Change to SSDATA to avoid warnings.
93 * xterm.c (x_frame_of_widget): Remove redundant prototype.
94 Move under #ifdef USE_LUCID.
95 (x_create_toolkit_scroll_bar): Adjust scroll_bar_name
96 definition and usage to avoid warnings.
97
14c114ae
JD
982012-07-31 Jan Djärv <jan.h.d@swipnet.se>
99
100 * nsterm.m (openFiles): Fix previous checkin.
101
3bd21e82
PE
1022012-07-31 Paul Eggert <eggert@cs.ucla.edu>
103
104 * indent.c (compute_motion): Remove unused local.
105
c1529ded
GM
1062012-07-31 Glenn Morris <rgm@gnu.org>
107
400d5621
GM
108 * s/usg5-4-common.h (wait3, WRETCODE): Let configure set them.
109
268e2432
GM
110 * conf_post.h [USG5_4]:
111 Move remaining contents of s/usg5-4-common.h here.
112 * s/usg5-4-common.h: Remove file.
113
7552f3ee
GM
114 * conf_post.h [IRIX6_5]: Move remaining contents of s/irix6-5.h here.
115 * s/irix6-5.h: Remove file.
116
6a381852
GM
117 * conf_post.h [DARWIN_OS]: Move remaining contents of s/darwin.h here.
118 * s/darwin.h: Remove file.
119
c1529ded
GM
120 * conf_post.h [HPUX]: Move random, srandom here from s/hpux10-20.h.
121 * s/hpux10-20.h: Remove file, which is now empty.
122
b429a4ee
GM
1232012-07-30 Glenn Morris <rgm@gnu.org>
124
125 * conf_post.h: New, split from configure.ac's AH_BOTTOM.
126 * Makefile.in (config_h): Add conf_post.h.
127 * makefile.w32-in (CONFIG_H): Add conf_post.h.
128
adff3182
JD
1292012-07-30 Jan Djärv <jan.h.d@swipnet.se>
130
131 * nsterm.m (ns_do_open_file): New variable.
b9031d69 132 (ns_term_init): Set ns_do_open_file to YES after run returns.
adff3182
JD
133 (openFile, openTempFile, openFileWithoutUI, openFiles): Open
134 files only if ns_do_open_file.
135
c32af1e4
PE
1362012-07-30 Paul Eggert <eggert@cs.ucla.edu>
137
7393bcbb
PE
138 * lisp.h (SWITCH_ENUM_CAST): Remove. All uses removed.
139 This no-op macro hasn't been needed for many years.
140 * src/regex.c (SWITCH_ENUM_CAST) [!emacs]: Likewise.
141
c32af1e4
PE
142 Export DIRECTORY_SEP, TYPEMASK, VALMASK to GDB.
143 * alloc.c (gdb_make_enums_visible) [USE_LSB_TAG]: Add lsb_bits.
144 * lisp.h (enum lsb_bits) [USE_LSB_TAG]: New enum, for
145 gdb_make_enums_visible.
146 (TYPEMASK, VALMASK) [USE_LSB_TAGS]: Now enum constants, not macros.
147 (DIRECTORY_SEP): Now a constant, not a macro.
148
302fc036
EZ
1492012-07-30 Eli Zaretskii <eliz@gnu.org>
150
151 * w32fns.c (w32_wnd_proc): Pass w32_keyboard_codepage to
152 w32_kbd_patch_key as the 2nd arg. (Bug#12082)
153
154 * w32term.c <w32_keyboard_codepage>: Renamed from
155 keyboard_codepage and now external. All users changed.
156
157 * w32term.h: Add declaration of w32_keyboard_codepage.
158
159 * w32inevt.c (w32_kbd_patch_key): Accept an additional argument --
160 the codepage to translate keys to Unicode. If this argument is
161 -1, use the value returned by GetConsoleCP. All callers changed.
162
88fb40b4
PE
1632012-07-30 Paul Eggert <eggert@cs.ucla.edu>
164
0aee6912
PE
165 Update .PHONY listings in makefiles.
166 * Makefile.in (.PHONY): Add all, mostlyclean, clean,
167 bootstrap-clean, distclean, maintainer-clean, versioclean,
168 extraclean, frc.
169
88fb40b4
PE
170 * lisp.h (STRING_BYTES_BOUND): Cast entire result to ptrdiff_t.
171 This is a bit clearer. Fix some commentary typos.
172
0a763bd1
GM
1732012-07-30 Glenn Morris <rgm@gnu.org>
174
32bac6d6
GM
175 * s/netbsd.h: Let configure include signal.h if needed.
176 Remove file, which is now empty.
177
b65e7c46
GM
178 * s/usg5-4-common.h (_longjmp, _setjmp, TIOCSIGSEND):
179 Let configure set them.
180 * s/irix6-5.h (_longjmp, _setjmp, TIOCSIGSEND):
181 No more need to undefine.
0a763bd1 182
169304bd
AS
1832012-07-30 Andreas Schwab <schwab@linux-m68k.org>
184
185 * keymap.c (Fkey_description): Don't remove 0x80 bit from
186 non-single-byte char when adding meta modifier. (Bug#12090)
187
6cd7a139
DA
1882012-07-30 Dmitry Antipov <dmantipov@yandex.ru>
189
190 Convert safe_call to use variable number of arguments.
191 * xdisp.c (safe_call): Convert to use varargs. Adjust users.
192 (safe_call2): Fix comment.
193 * lisp.h (safe_call): Adjust prototype.
194 * coding.c (encode_coding_object): Change to use safe_call2.
195 * xfaces.c (merge_face_heights): Change to use safe_call1.
196
d34d6ffc
GM
1972012-07-30 Glenn Morris <rgm@gnu.org>
198
7b8a48e4 199 * s/aix4-2.h (sigmask): No need to undefine it, since syssignal.h
227f5bd0 200 does that unconditionally. Remove file, which is now empty.
7b8a48e4 201
d34d6ffc
GM
202 * s/freebsd.h, s/gnu-linux.h, s/sol2-6.h, s/unixware.h:
203 Remove empty files.
204
03a660a6
PE
2052012-07-30 Paul Eggert <eggert@cs.ucla.edu>
206
207 Export to GDB most of lisp.h's remaining object-like macros.
208 * lisp.h (min, max): Move earlier, because they're used earlier now.
209 (INTMASK, ARRAY_MARK_FLAG, PSEUDOVECTOR_FLAG, VALMASK)
210 (CHAR_TABLE_STANDARD_SLOTS, CHARTAB_SIZE_BITS_0)
211 (CHARTAB_SIZE_BITS_1, CHARTAB_SIZE_BITS_2, CHARTAB_SIZE_BITS_3)
212 (DEFAULT_HASH_SIZE, COMPILED_ARGLIST, COMPILED_BYTECODE)
213 (COMPILED_CONSTANTS, COMPILED_STACK_DEPTH, COMPILED_DOC_STRING)
214 (COMPILED_INTERACTIVE, CHAR_ALT, CHAR_SUPER, CHAR_HYPER, CHAR_SHIFT)
215 (CHAR_CTL, CHAR_META, CHAR_MODIFIER_MASK, CHARACTERBITS)
216 (MANY, UNEVALLED, FLOAT_TO_STRING_BUFSIZE, MAX_ALLOCA):
217 Now constants, for GDB. They need not be macros.
218 (MOST_POSITIVE_FIXNUM, MOST_NEGATIVE_FIXNUM, STRING_BYTES_BOUND):
219 Now constants, for GDB, as well as macros, for static initializers.
220 (CHAR_TABLE_STANDARD_SLOTS, CHAR_TABLE_EXTRA_SLOTS):
221 Move to after the definition of struct Lisp_Char_Table,
222 since the former now needs that type defined.
223 (enum CHARTAB_SIZE_BITS, enum CHAR_TABLE_STANDARD_SLOTS)
224 (enum DEFAULT_HASH_SIZE, enum Lisp_Compiled, enum char_bits)
225 (enum maxargs, enum FLOAT_TO_STRING_BUFSIZE, enum MAX_ALLOCA):
226 New enums, for gdb_make_enums_visible.
227 (GLYPH_MODE_LINE_FACE): Remove; unused.
88fb40b4 228 * alloc.c (STRING_BYTES_MAX): Now a constant, not a macro.
03a660a6
PE
229 (gdb_make_enums_visible): Add enum CHARTAB_SIZE_BITS, enum
230 CHAR_TABLE_STANDARD_SLOTS, enum char_bits, enum DEFAULT_HASH_SIZE,
231 enum FLOAT_TO_STRING_BUFSIZE, enum Lisp_Bits, enum Lisp_Compiled,
232 enum maxargs, enum MAX_ALLOCA.
233 (ARRAY_MARK_FLAG_VAL, PSEUDOVECTOR_FLAG_VAL, VALMASK_VAL): Remove.
234 (ARRAY_MARK_FLAG, PSEUDOVECTOR_FLAG, VALMASK): Remove;
235 no longer needed, now that they are done in lisp.h.
236
e499d0ee
DA
2372012-07-30 Dmitry Antipov <dmantipov@yandex.ru>
238
239 Cleanup string bytes checking.
240 * alloc.c (GC_STRING_BYTES, CHECK_STRING_BYTES): Remove. Convert
241 all users to STRING_BYTES or string_bytes if GC_CHECK_STRING_BYTES.
242 (check_string_bytes): Define to empty if not GC_CHECK_STRING_BYTES.
243 (check_sblock, compact_small_strings): Simplify.
244
d5040d2d
PE
2452012-07-29 Paul Eggert <eggert@cs.ucla.edu>
246
247 * lisp.h (LISP_INT_TAG, LISP_INT1_TAG, LISP_STRING_TAG): Remove.
248 These macros are confusing and no longer need to be defined, as
249 the enum values now suffice. All uses replaced with definiens.
250 (Lisp_Int1, Lisp_String): Define directly; this is clearer.
251
7f259ae6
JB
2522012-07-29 Juanma Barranquero <lekktu@gmail.com>
253
254 * makefile.w32-in (LISP_H, $(BLD)/emacs.$(O), $(BLD)/w32inevt.$(O))
255 ($(BLD)/w32console.$(O)): Update dependencies.
256
7e63e0c3
DA
2572012-07-29 Dmitry Antipov <dmantipov@yandex.ru>
258
259 Remove HIDE_LISP_IMPLEMENTATION and cleanup cons free list check.
260 * lisp.h (HIDE_LISP_IMPLEMENTATION): Remove as useless for a long
261 time. Adjust users.
262 (CHECK_CONS_LIST): Remove. Convert all users to check_cons_list.
263
ffd817eb
JD
2642012-07-29 Jan Djärv <jan.h.d@swipnet.se>
265
266 * lread.c (init_lread): Remove if-statement in ifdef HAVE_NS before
267 setting sitelisp (Bug#12010).
268
417a7a0e
EZ
2692012-07-29 Eli Zaretskii <eliz@gnu.org>
270
271 * w32heap.h (OS_9X): Renamed from OS_WINDOWS_95.
272
273 * w32heap.c (cache_system_info):
274 * w32.c (sys_rename):
275 * w32proc.c (find_child_console, sys_kill): All users changed.
276
387d4d92
PE
2772012-07-29 Paul Eggert <eggert@cs.ucla.edu>
278
279 * alloc.c (Fgarbage_collect): Indent as per usual Emacs style.
280
55a6cca6
EZ
2812012-07-29 Eli Zaretskii <eliz@gnu.org>
282
283 * makefile.w32-in (LISP_H): Add $(NT_INC)/stdalign.h.
284
dbcf001c
DA
2852012-07-29 Dmitry Antipov <dmantipov@yandex.ru>
286
287 Cleanup statistics calculation in Fgarbage_collect.
288 * alloc.c (Fgarbage_collect): Rename t1 to meaningful start. Fix
289 zombies percentage calculation. Simplify elapsed time calculation.
290
e2688e4a
DA
2912012-07-29 Dmitry Antipov <dmantipov@yandex.ru>
292
293 Generalize marker debugging code under MARKER_DEBUG and use eassert.
294 * insdel.c (CHECK_MARKERS, check_markers_debug_flag): Remove.
295 (gap_left, gap_right, adjust_markers_for_delete, insert_1_both)
296 (insert_from_string_1, insert_from_gap, insert_from_buffer_1)
297 (replace_range, replace_range_2, del_range_2): Change to eassert.
298 * marker.c (byte_char_debug_check): Adjust style.
299
b46a6a83
PE
3002012-07-29 Paul Eggert <eggert@cs.ucla.edu>
301
302 Don't use the abbreviation "win" to refer to Windows (Bug#10421).
303 * regex.c (MAX_BUF_SIZE): Remove some incorrect and
304 long-ago-commented-out code that talks about "WIN32".
305 * w32heap.h (OS_WINDOWS_95): Rename from OS_WIN95.
306 All uses changed.
307
e32a5799
PE
3082012-07-28 Paul Eggert <eggert@cs.ucla.edu>
309
310 Use Gnulib stdalign module (Bug#9772, Bug#9960).
311 * alloc.c (XMALLOC_BASE_ALIGNMENT, GC_POINTER_ALIGNMENT, pure_alloc):
312 Simplify by using alignof.
313 (pure_alloc) [! USE_LSB_TAG]: Don't over-align EMACS_INT values.
314 * lisp.h: Include <stdalign.h>.
315 (GCALIGNMENT): New macro and constant.
316 (DECL_ALIGN): Remove. All uses replaced by alignas (GCALIGNMENT).
317 (USE_LSB_TAG): ifdef on alignas, not on DECL_ALIGN.
318 (stdalign): New macro, if not already defined.
319
df81cd29
EZ
3202012-07-28 Eli Zaretskii <eliz@gnu.org>
321
01bd1b0d
EZ
322 Fix non-ASCII input in non-GUI frames on MS-Windows. (Bug#12055)
323 * w32inevt.c: Include w32inevt.h.
324 (w32_read_console_input): New inline function, calls either
325 ReadConsoleInputA or ReadConsoleInputW, depending on the value of
326 w32_console_unicode_input.
327 (fill_queue): Call w32_read_console_input instead of ReadConsoleInput.
328 (w32_kbd_patch_key, key_event): Use the codepage returned by
329 GetConsoleCP, rather than the ANSI codepage returned by GetLocaleInfo.
330 (key_event): use uChar.UnicodeChar only if
331 w32_console_unicode_input is non-zero.
332
333 * w32console.c: Include w32heap.h.
334 <w32_console_unicode_input>: New global variable.
335 (initialize_w32_display): Set w32_console_unicode_input to 1 on NT
336 family of Windows, zero otherwise.
337
338 * w32inevt.h: Declare w32_console_unicode_input.
339
df81cd29
EZ
340 * xdisp.c (init_iterator): Don't reference tip_frame in a build
341 --without-x. (Bug#11742)
342
c20fdd9e
PE
3432012-07-27 Paul Eggert <eggert@cs.ucla.edu>
344
345 Adjust GDB to reflect pvec_type changes (Bug#12036).
346 * .gdbinit (xvectype, xpr, xbacktrace): Adjust to reflect the
347 2012-07-04 changes to pseudovector representation. Problem
348 reported by Eli Zaretskii in <http://bugs.gnu.org/12036#30>.
349
32770973 3502012-07-27 Michael Albinus <michael.albinus@gmx.de>
e518bc71
MA
351
352 * dbusbind.c (XD_DBUS_VALIDATE_BUS_ADDRESS): Canonicalize session
353 bus address.
354 (xd_close_bus, Fdbus_init_bus): Handle reference counter properly.
355
3438fe21
EZ
3562012-07-27 Eli Zaretskii <eliz@gnu.org>
357
bcfbc9de
EZ
358 * alloc.c (listn): Fix the order the arguments are consed onto the
359 list.
360
3438fe21
EZ
361 * lisp.h (enum constype): Use CONSTYPE_HEAP and CONSTYPE_PURE for
362 enumeration constants, as PURE and HEAP are too general, and clash
363 with other headers and sources, such as gmalloc.c and the
364 MS-Windows system headers. All users changed.
365
eeaea515
DA
3662012-07-27 Dmitry Antipov <dmantipov@yandex.ru>
367
368 Revert last save_excursion_save and save_excursion_restore changes.
369 * alloc.c, editfns.c, marker.c, lisp.h: Revert.
370 Lots of crashes reported by Chong Yidong <cyd@gnu.org>.
371
073c88c2
DA
3722012-07-27 Dmitry Antipov <dmantipov@yandex.ru>
373
374 Fix recently-introduced typos in Windows port.
375 Reported by Martin Rudalics <rudalics@gmx.at>.
376 * w32.c (init_environment): Replace comma with semicolon.
eeaea515 377 * w32fns.c (syms_of_w32fns): Add missing parenthesis.
073c88c2 378
4706125e
PE
3792012-07-27 Paul Eggert <eggert@cs.ucla.edu>
380
381 Improve GDB symbol export (Bug#12036).
382 * .gdbinit (xgetptr, xgetint, xgettype): Set $bugfix in different
383 arms of an 'if', not using conditional expressions; otherwise GDB
384 complains about the types in the unevaluated arm when the argument
385 is an integer literal.
386 (xgetint): Simplify expression.
387 * alloc.c (gdb_make_enums_visible): New constant. This ports to
388 GCC 3.4.2 the export of symbols to GDB. Problem reported by Eli
389 Zaretskii in <http://bugs.gnu.org/12036#13>.
390 * lisp.h (PUBLISH_TO_GDB): Remove. All uses removed. No longer
391 needed now that we have gdb_make_enums_visible.
392 (enum CHECK_LISP_OBJECT_TYPE, enum Lisp_Bits, enum More_Lisp_Bits)
393 (enum enum_USE_LSB_TAG):
394 New enum types, packaging up enums that need to be exported to GDB.
395
694b6c97
DA
3962012-07-27 Dmitry Antipov <dmantipov@yandex.ru>
397
398 Utility function to make a list from specified amount of objects.
399 * lisp.h (enum constype): New datatype.
400 (listn): New prototype.
401 * alloc.c (listn): New function.
402 (Fmemory_use_count, syms_of_alloc): Use it.
403 * buffer.c (syms_of_buffer): Likewise.
404 * callint.c (syms_of_callint): Likewise.
405 * charset.c (define_charset_internal): Likewise.
406 * coding.c (syms_of_coding): Likewise.
407 * keymap.c (syms_of_keymap): Likewise.
408 * search.c (syms_of_search): Likewise.
409 * syntax.c (syms_of_syntax): Likewise.
410 * w32.c (init_environment): Likewise.
411 * w32fns.c (Fw32_battery_status, syms_of_w32fns): Likewise.
412 * xdisp.c (syms_of_xdisp): Likewise.
413 * xfns.c (syms_of_xfns): Likewise.
414
6195f384
DA
4152012-07-27 Dmitry Antipov <dmantipov@yandex.ru>
416
417 Fast save_excursion_save and save_excursion_restore.
418 * lisp.h (struct Lisp_Excursion): New data type.
419 (PVEC_EXCURSION): New pseudovector type.
420 (XEXCURSION, XSETEXCURSION, EXCURSIONP): Convenient macros
421 to deal with it. Adjust comments.
422 (init_marker, attach_marker): New prototype.
423 (unchain_marker): Adjust prototype.
424 * marker.c (attach_marker): Change to global.
425 (init_marker): New function.
426 * alloc.c (Fmake_marker, build_marker): Use it.
427 (build_marker): More easserts.
428 (mark_object): Handle struct Lisp_Excursion.
429 * editfns.c (save_excursion_save, save_excursion_restore):
430 Reimplement to use struct Lisp_Excursion. Add comments.
431
5eceb8fb
PE
4322012-07-26 Paul Eggert <eggert@cs.ucla.edu>
433
434 Fix export of symbols to GDB (Bug#12036).
435 * alloc.c (ARRAY_MARK_FLAG_VAL, PSEUDOVECTOR_FLAG_VAL, VALMASK_VAL)
436 (ARRAY_MARK_FLAG, PSEUDOVECTOR_FLAG, VALMASK): Move these here from
437 emacs.c, as this is a more-suitable home. Had this been done earlier
438 the fix for 12036 would have avoided some of the problems noted in
439 <http://bugs.gnu.org/12036#13> by Eli Zaretskii, as the scope problems
440 would have been more obvious.
562157c8
PE
441 * emacs.c: Do not include <verify.h>; no longer needed.
442 (gdb_CHECK_LISP_OBJECT_TYPE, gdb_DATA_SEG_BITS)
5eceb8fb
PE
443 (gdb_GCTYPEBITS, gdb_USE_LSB_TAG)
444 (CHECK_LISP_OBJECT_TYPE, DATA_SEG_BITS, GCTYPEBITS, USE_LSB_TAG):
445 Remove; now done in lisp.h.
446 * lisp.h (PUBLISH_TO_GDB): New macro.
447 (GCTYPEBITS, USE_LSB_TAG, CHECK_LISP_OBJECT_TYPE, enum pvec_type)
448 (DATA_SEG_BITS): Use it.
449 (GCTYPEBITS, USE_LSB_TAG): Now also an enum, for GDB.
450 (CHECK_LISP_OBJECT_TYPE, DATA_SEG_BITS): Now just an enum, for GDB.
451 * mem-limits.h (EXCEEDS_LISP_PTR): Redo so that DATA_SEG_BITS need
452 not be usable in #if. This simplifies things.
453
d6749401
JB
4542012-07-26 Juanma Barranquero <lekktu@gmail.com>
455
456 * makefile.w32-in ($(BLD)/emacs.$(O)): Update dependencies.
457
1781b9e9
PE
4582012-07-26 Paul Eggert <eggert@cs.ucla.edu>
459
d89518db 460 Simplify export of symbols to GDB (Bug#12036).
1781b9e9
PE
461 * .gdbinit (xgetptr, xgetint, xgettype): Don't use "set $bugfix =
462 $bugfix.i", as this doesn't work (with GDB 7.4.1, anyway).
463 (xgetptr, xgetint, xgettype, xcoding, xcharset, xprintbytestr):
464 Adjust to changes in lisp.h and emacs.c, by using
465 CHECK_LISP_OBJECT_TYPE rather than gdb_use_struct, VALMASK instead
466 of $valmask, DATA_SEG_BITS instead of gdb_data_seg_bits,
467 INTTYPEBITS instead of gdb_gctypebits - 1, USE_LSB_TAG instead of
468 gdb_use_lsb, (1 << GCTYPEBITS) - 1 instead of $tagmask, VALBITS
469 instead of gdb_valbits.
470 (xvectype, xvector, xpr, xprintstr, xbacktrace): Similarly, use
471 PSEUDOVECTOR_FLAG instead of PVEC_FLAG, and ARRAY_MARK_FLAG
472 instead of gdb_array_mark_flag.
473 (xboolvector): Get size from $->size, not $->header.size.
474 Use BOOL_VECTOR_BITS_PER_CHAR rather than mystery constants.
475 (xreload, hook-run, hookpost-run): Remove.
476 * emacs.c: Include <verify.h>.
477 (gdb_use_lsb, gdb_use_struct, gdb_valbits, gdb_gctypebits)
478 (gdb_data_seg_bits, PVEC_FLAG, gdb_array_mark_flag, gdb_pvec_type):
479 Remove.
480 (gdb_CHECK_LISP_OBJECT_TYPE, gdb_DATA_SEG_BITS, gdb_GCTYPEBITS)
481 (gdb_USE_LSB_TAG): New enum constants.
482 (CHECK_LISP_OBJECT_TYPE, DATA_SEG_BITS, GCTYPEBITS, USE_LSB_TAG):
483 Also define these as enum constants, so they're visible to GDB.
484 (ARRAY_MARK_FLAG_VAL, PSEUDOVECTOR_FLAG_VAL, VALMASK_VAL): New macros.
485 (ARRAY_MARK_FLAG, PSEUDOVECTOR_FLAG, VALMASK): Also define these
486 as constants, so they're visible to GDB.
487 * lisp.h (VALBITS, INTTYPEBITS, FIXNUM_BITS, PSEUDOVECTOR_SIZE_BITS)
488 (PSEUDOVECTOR_SIZE_MASK, PVEC_TYPE_MASK, BOOL_VECTOR_BITS_PER_CHAR):
489 Now enum constants, not macros, so they're visible to GDB.
490 (CHECK_LISP_OBJECT_TYPE, DATA_SEG_BITS): Default to 0, as this is
491 more convenient now. All uses changed.
492 (VALMASK) [USE_LSB_TAG]: Also define in this case.
493 * mem-limits.h (EXCEEDS_LISP_PTR): Adjust to DATA_SEG_BITS change.
494
3628596a
DA
4952012-07-26 Dmitry Antipov <dmantipov@yandex.ru>
496
497 Explicitly free restriction data that are not needed anymore.
498 * editfns.c (save_restriction_restore): Free restriction data.
499
7abaf5cc
SM
5002012-07-26 Stefan Monnier <monnier@iro.umontreal.ca>
501
502 * eval.c (Fautoload_do_load): Rename from do_autoload, export to Lisp,
503 add argument, tune behavior, and adjust all callers.
504
71f88e00
PE
5052012-07-25 Paul Eggert <eggert@cs.ucla.edu>
506
507 Use typedef for EMACS_INT, EMACS_UINT.
508 * lisp.h, s/ms-w32.h (EMACS_INT, EMACS_UINT): Use typedefs rather
509 than macros. This simplifies debugging in the usual case, since
510 it lets GDB show addresses as 'EMACS_INT *' rather than 'long int *'
511 and it allows expressions involving EMACS_INT casts.
512 * .gdbinit (xreload): Simplify by using EMACS_INT cast.
513
57ec3034
JD
5142012-07-25 Jan Djärv <jan.h.d@swipnet.se>
515
516 * nsterm.m (ns_read_socket): Return early if there is a modal
517 window (Bug#12043).
518
8137e7b3
MR
5192012-07-25 Martin Rudalics <rudalics@gmx.at>
520
521 * frame.c (Fredirect_frame_focus): In doc-string don't mention
522 that FOCUS-FRAME can be omitted.
523
04e9897c
DA
5242012-07-25 Dmitry Antipov <dmantipov@yandex.ru>
525
526 Adjust buffer text indirection counters at the end of Fkill_buffer.
527 * buffer.c (Fkill_buffer): Adjust indirection counters when the
528 buffer is definitely dead. This should really fix an issue reported
529 by Christoph Scholtes again. (Bug#12007).
530 (init_buffer_once): Initialize indirection counters of
531 buffer_defaults and buffer_local_symbols (for sanity and safety).
532
8a0484e1
EZ
5332012-07-24 Eli Zaretskii <eliz@gnu.org>
534
535 * xdisp.c (init_iterator): Don't compute dimensions of truncation
536 and continuation glyphs on tooltip frames, leave them at zero.
537 Avoids continued lines in tooltips. (Bug#11832)
538
fa691a83
DA
5392012-07-24 Dmitry Antipov <dmantipov@yandex.ru>
540
541 Simplify copy_overlay.
04e9897c 542 * buffer.c (copy_overlay): Simplify. Use build_marker.
fa691a83
DA
543 * lisp.h (struct Lisp_Overlay): Restore comment with minor tweaks.
544
436bc8e0
EZ
5452012-07-23 Eli Zaretskii <eliz@gnu.org>
546
547 * print.c (print_object): Don't crash when a frame's name is nil
548 or invalid. (Bug#12025)
549
550 * window.c (decode_any_window): Disable CHECK_LIVE_FRAME test, as
551 it signals an error when a tooltip frame is being created.
552
d7a7fda3
DA
5532012-07-23 Dmitry Antipov <dmantipov@yandex.ru>
554
555 Cleanup miscellaneous objects allocation and initialization.
556 * alloc.c (allocate_misc): Change to static. Add argument to
557 specify the subtype. Adjust comment and users.
558 (build_overlay): New function.
559 * buffer.c (copy_overlays, Fmake_overlay): Use it.
560 * lisp.h (struct Lisp_Overlay): Remove obsolete comment.
561 (allocate_misc): Remove prototype.
562 (build_overlay): Add prototype.
563
5642012-07-23 Dmitry Antipov <dmantipov@yandex.ru>
372f8ffc
DA
565
566 Swap buffer text indirection counters in Fbuffer_swap_text.
567 * buffer.c (Fbuffer_swap_text): Swap indirections too.
568 This avoids crash reported by Christoph Scholtes at
569 http://lists.gnu.org/archive/html/bug-gnu-emacs/2012-07/msg00785.html.
570
9d7fa573
JD
5712012-07-22 Jan Djärv <jan.h.d@swipnet.se>
572
573 * nsmenu.m (Popdown_data): New struct.
574 (pop_down_menu): p->pointer is Popdown_data. Release the pool and
575 free Popdown_data.
576 (ns_popup_dialog): Use NSAutoreleasePool and pass it to pop_down_menu.
577 (initWithContentRect): Make imgView and contentView non-static
578 and autorelease them. Also autorelease img and matrix (Bug#12005).
579 (dealloc): Remove (Bug#12005).
580
0dd6d66d
DA
5812012-07-22 Dmitry Antipov <dmantipov@yandex.ru>
582
583 Adjust consing_since_gc when objects are explicitly freed.
584 * alloc.c (GC_DEFAULT_THRESHOLD): New macro.
585 (Fgarbage_collect): Use it. Change minimum to 1/10 of default.
586 (free_cons, free_misc): Subtract object size from consing_since_gc.
587
d36d71df
DA
5882012-07-22 Dmitry Antipov <dmantipov@yandex.ru>
589
590 Simplify and cleanup markers positioning code.
591 * marker.c (attach_marker): More useful eassert.
592 (live_buffer, set_marker_internal): New function.
593 (Fset_marker, set_marker_restricted): Use set_marker_internal.
594 (set_marker_both, set_marker_restricted_both): Use live_buffer.
595
fb9ea40f
PE
5962012-07-22 Paul Eggert <eggert@cs.ucla.edu>
597
598 * buffer.h (struct buffer.indirections): Now ptrdiff_t, not int,
599 as it's limited by the amount of memory, not by INT_MAX.
600
2d5c5f7d
EZ
6012012-07-21 Eli Zaretskii <eliz@gnu.org>
602
07fb592e
EZ
603 * keyboard.c (keys_of_keyboard): Bind language-change to 'ignore'
604 in special-event-map. See the discussion at
605 http://lists.gnu.org/archive/html/emacs-devel/2012-06/msg00417.html
606 for the reasons.
607
37a9eac8 608 * w32menu.c (add_menu_item): Cast to ULONG_PTR when assigning
2d5c5f7d
EZ
609 info.dwItemData. Fixes crashes on 64-bit Windows. Suggested by
610 Fabrice Popineau <fabrice.popineau@supelec.fr>.
611
c4328746
JD
6122012-07-21 Jan Djärv <jan.h.d@swipnet.se>
613
614 * nsterm.m (accessibilityAttributeValue): New function. (Bug#11134).
4b17afa7 615 (conversationIdentifier): Return value is NSInteger.
784051c4 616 * nsterm.m (accessibilityAttributeValue): Surround with NS_IMPL_COCOA.
c4328746 617
6e5d1c12
CY
6182012-07-21 Chong Yidong <cyd@gnu.org>
619
620 * window.c (decode_any_window): Signal an error if the window is
621 on a dead frame (Bug#11984).
622
9928463d
DA
6232012-07-20 Dmitry Antipov <dmantipov@yandex.ru>
624
625 Add indirection counting to speed up Fkill_buffer.
626 * buffer.h (struct buffer): New member.
627 * buffer.c (Fget_buffer_create): Set indirection counter to 0.
628 (Fmake_indirect_buffer): Set indirection counter to -1, increment
629 base buffer indirection counter.
630 (compact_buffer): If ENABLE_CHECKING, verify indirection counters.
631 (Fkill_buffer): Adjust indirection counters as needed, don't walk
632 through buffer list if indirection counter is 0.
633
f8643a6b
DA
6342012-07-20 Dmitry Antipov <dmantipov@yandex.ru>
635
636 Extend the value returned by Fgarbage_collect with heap statistics.
637 * alloc.c (Qheap): New symbol.
638 (syms_of_alloc): DEFSYM it.
639 (Fgarbage_collect): If DOUG_LEA_MALLOC, add mallinfo data.
640 (Fmemory_free): Remove.
641 (syms_of_alloc): Don't defsubr it.
642 * buffer.c (Fcompact_buffer): Remove.
643 (syms_of_buffer): Don't defsubr it.
644
dac616ff
DA
6452012-07-20 Dmitry Antipov <dmantipov@yandex.ru>
646
647 Make maybe_gc inline.
648 Verify that inlining is always possible (GCC 4.7.1, -O3 -Winline).
649 * lisp.h (consing_since_gc, gc_relative_threshold)
650 (memory_full_cons_threshold): Revert declaration.
651 (maybe_gc): Remove prototype, define as inline.
652 * alloc.c: Remove old commented-out code.
653 (consing_since_gc, gc_relative_threshold)
654 (memory_full_cons_threshold): Revert to global.
655 (maybe_gc): Remove.
656
d7ea76b4
DA
6572012-07-20 Dmitry Antipov <dmantipov@yandex.ru>
658
659 Simple wrapper for make_unibyte_string, adjust font_open_by_name.
660 * lisp.h (build_unibyte_string): New function.
661 * dosfns.c, fileio.c, fns.c, ftfont.c, process.c:
662 * sysdep.c, w32fns.c, xfns.c: Use it.
663 * font.c (font_open_by_name): Change 2nd and 3rd args to the only arg
664 of type Lisp_Object to avoid redundant calls to make_unibyte_string.
665 Adjust users accordingly.
666 * font.h (font_open_by_name): Adjust prototype.
667
765e61e3
DA
6682012-07-20 Dmitry Antipov <dmantipov@yandex.ru>
669
670 Cleanup calls to Fgarbage_collect.
671 * lisp.h (maybe_gc): New prototype.
672 (consing_since_gc, gc_relative_threshold, memory_full_cons_threshold):
673 Remove declarations.
674 * alloc.c (maybe_gc): New function.
675 (consing_since_gc, gc_relative_threshold, memory_full_cons_threshold):
676 Make them static.
677 * bytecode.c (MAYBE_GC): Use maybe_gc.
678 * eval.c (eval_sub, Ffuncall): Likewise.
679 * keyboard.c (read_char): Likewise. Adjust call to maybe_gc
680 to avoid dependency from auto-save feature.
681
52b852c7
PE
6822012-07-19 Paul Eggert <eggert@cs.ucla.edu>
683
684 * buffer.h (FOR_EACH_BUFFER): Rename from 'for_each_buffer'.
685 (FOR_EACH_PER_BUFFER_OBJECT_AT): Rename from
686 'for_each_per_buffer_object_at'.
687 All uses changed. It's better to use upper-case for macros that
688 cannot be implemented as functions, to give the reader a clue
689 that they're special.
690
5db81e33
SM
6912012-07-19 Stefan Monnier <monnier@iro.umontreal.ca>
692
693 * alloc.c (Fgarbage_collect): Tweak docstring.
694
5b835e1d
DA
6952012-07-19 Dmitry Antipov <dmantipov@yandex.ru>
696
697 Tweak the value returned from Fgarbage_collect again.
698 * alloc.c (Fgarbage_collect): New return value, as confirmed in
699 http://lists.gnu.org/archive/html/emacs-devel/2012-07/msg00418.html.
700 Adjust documentation.
701 (total_vector_bytes): Rename to total_vector_slots, adjust
702 accounting.
703 (total_free_vector_bytes): Rename to total_free_vector_slots,
704 adjust accounting.
705 (Qstring_bytes, Qvector_slots): New symbols.
706 (syms_of_alloc): DEFSYM them.
707
9cd47b72
DA
7082012-07-19 Dmitry Antipov <dmantipov@yandex.ru>
709
710 Buffer compaction primitive which may be used from Lisp.
711 * buffer.c (compact_buffer, Fcompact_buffer): New function.
712 (syms_of_buffer): Register Fcompact_buffer.
713 * alloc.c (Fgarbage_collect): Use compact_buffer.
714 * buffer.h (compact_buffer): New prototype.
715 (struct buffer_text): New member.
716
d17337e5
DA
7172012-07-19 Dmitry Antipov <dmantipov@yandex.ru>
718
719 New macro to iterate over all buffers, miscellaneous cleanups.
720 * lisp.h (all_buffers): Remove declaration.
721 * buffer.h (all_buffers): Add declaration, with comment.
722 (for_each_buffer): New macro.
723 * alloc.c (Fgarbage_collect, mark_object): Use it.
724 * buffer.c (Fkill_buffer, Fbuffer_swap_text, Fset_buffer_multibyte)
725 (init_buffer): Likewise.
726 * data.c (Fset_default): Likewise.
727 * coding.c (code_conversion_restore): Remove redundant check
728 for dead buffer.
729 * buffer.c (Fkill_buffer): Likewise. Remove obsolete comment.
730
60cfd278
AS
7312012-07-18 Andreas Schwab <schwab@linux-m68k.org>
732
733 Fix bug that created negative-length intervals.
734 * intervals.c (merge_interval_right, merge_interval_left):
735 Do not zero out this interval if it is absorbed by its children,
736 as this interval's total length doesn't change in that case. See
737 <http://lists.gnu.org/archive/html/emacs-devel/2012-07/msg00403.html>.
738
d06714cb
PE
7392012-07-18 Paul Eggert <eggert@cs.ucla.edu>
740
83713154
PE
741 * alloc.c (Fmake_bool_vector): Fix off-by-8 bug
742 when invoking (make-bool-vector N t) and N is a positive
743 multiple of 8 -- the last 8 bits were mistakenly cleared.
744
d06714cb
PE
745 Remove some struct layout assumptions in bool vectors.
746 * alloc.c (bool_header_size): New constant.
747 (header_size, word_size): Move earlier, as they're now used earlier.
748 Use 'word_size' in a few more places, where it's appropriate.
749 (Fmake_bool_vector, sweep_vectors): Don't assume that there is no
750 padding before the data member of a bool vector.
751 (sweep_vectors): Use PSEUDOVECTOR_TYPEP, in an eassert, rather
752 than doing the check by hand with an abort ().
753
464d5a5e
SM
7542012-07-18 Stefan Monnier <monnier@iro.umontreal.ca>
755
5fbc0409
SM
756 * eval.c (Fdefvar): Don't check constants since we only set the var if
757 it's not yet defined anyway (bug#11904).
758
464d5a5e
SM
759 * lisp.h (last_undo_boundary): Declare new var.
760 * keyboard.c (command_loop_1): Set it.
761 * cmds.c (Fself_insert_command): Use it to only remove boundaries that
762 were auto-added by the command loop (bug#11774).
763
8dc2e44a
AS
7642012-07-18 Andreas Schwab <schwab@linux-m68k.org>
765
766 * w32font.c (Qsymbol): Remove local definition.
767 (syms_of_w32font): Don't DEFSYM it.
768
169925ec
DA
7692012-07-18 Dmitry Antipov <dmantipov@yandex.ru>
770
771 Fix sweep_vectors to handle large bool vectors correctly.
772 * alloc.c (sweep_vectors): Account total_vector_bytes for
773 bool vectors larger than VBLOCK_BYTES_MAX.
774
5fbfb018
CY
7752012-07-18 Chong Yidong <cyd@gnu.org>
776
777 * frame.c (x_set_frame_parameters): Revert bogus change introduced
778 in 2012-05-25 commit by Paul Eggert (Bug#11738).
779
3ab6e069
DA
7802012-07-18 Dmitry Antipov <dmantipov@yandex.ru>
781
782 Return more descriptive data from Fgarbage_collect.
783 Suggested by Stefan Monnier in
784 http://lists.gnu.org/archive/html/emacs-devel/2012-07/msg00369.html.
785 * alloc.c (bounded_number): New function.
786 (total_buffers, total_vectors): New variable.
787 (total_string_size): Rename to total_string_bytes, adjust users.
788 (total_vector_size): Rename to total_vector_bytes, adjust users.
789 (sweep_vectors): Account total_vectors and total_vector_bytes.
790 (Fgarbage_collect): New return value. Adjust documentation.
791 (gc_sweep): Account total_buffers.
792 (Fmemory_free, Fmemory_use_counts): Use bounded_number.
793 (VECTOR_SIZE): Remove.
794 * data.c (Qfloat, Qvector, Qsymbol, Qstring, Qcons): Make global.
795 (Qinterval, Qmisc): New symbols.
796 (syms_of_data): Initialize them.
797 * lisp.h (Qinterval, Qsymbol, Qstring, Qmisc, Qvector, Qfloat)
798 (Qcons, Qbuffer): New declarations.
799
6d02fe5b
PE
8002012-07-17 Paul Eggert <eggert@cs.ucla.edu>
801
802 * alloc.c (Fmemory_free): Account for memory-free's own storage.
803 Round up, not down. Improve doc.
804
b7ffe040
DA
8052012-07-17 Dmitry Antipov <dmantipov@yandex.ru>
806
807 Restore old code in allocate_string_data to avoid Faset breakage.
808 Reported by Julien Danjou <julien@danjou.info> in
809 http://lists.gnu.org/archive/html/emacs-devel/2012-07/msg00371.html.
810 * alloc.c (allocate_string_data): Restore old code with minor
811 adjustments, fix comment to explain this subtle issue.
812
4dc7c8d5
SM
8132012-07-17 Eli Zaretskii <eliz@gnu.org>
814
815 Remove FILE_SYSTEM_CASE.
816 * s/msdos.h (FILE_SYSTEM_CASE): Don't define.
817
818 * fileio.c (FILE_SYSTEM_CASE): Don't define.
819 (Ffile_name_directory, Fexpand_file_name): Don't use FILE_SYSTEM_CASE.
820 Fixes problems on MS-DOS with Vtemp_file_name_pattern when
821 call-process-region passes it through expand-file-name.
822
823 * dired.c (file_name_completion): Don't use FILE_SYSTEM_CASE.
824
8252012-07-17 Andreas Schwab <schwab@linux-m68k.org>
826
827 Fix crash when creating indirect buffer (Bug#11917)
828 * buffer.c (buffer_lisp_local_variables): Add argument CLONE.
829 Don't handle unbound variables specially if non-zero.
830 (Fbuffer_local_variables): Pass zero.
831 (clone_per_buffer_values): Pass non-zero.
832
8332012-07-17 Andreas Schwab <schwab@linux-m68k.org>
834
835 * gnutls.c (emacs_gnutls_handshake): Revert last change. Add QUIT
836 to make the loop interruptible.
837
8382012-07-17 Andreas Schwab <schwab@linux-m68k.org>
839
840 * gnutls.c (emacs_gnutls_handshake): Only retry if
841 GNUTLS_E_INTERRUPTED.
842
cce7fefc
DA
8432012-07-17 Dmitry Antipov <dmantipov@yandex.ru>
844
845 Cleanup and convert miscellaneous checks to eassert.
846 * alloc.c (mark_interval): Fix comment, partially rephrase
847 old comment from intervals.h (see below).
848 * intervals.c (find_interval, adjust_intervals_for_insertion)
849 (delete_interval, adjust_intervals_for_deletion)
850 (graft_intervals_into_buffer, temp_set_point_both, copy_intervals):
851 Convert to eassert.
852 (adjust_intervals_for_insertion, make_new_interval):
853 Remove obsolete and unused code.
854 * intervals.h (struct interval): Remove obsolete comment.
855 * textprotp.c (erase_properties): Remove unused code.
856 (Fadd_text_properties, set_text_properties_1, Fremove_text_properties)
857 (Fremove_list_of_text_properties): Convert to eassert.
858
9ea10cc3
CY
8592012-07-17 Chong Yidong <cyd@gnu.org>
860
861 * editfns.c (Finsert_char): Doc fix.
862
3900d5de
DA
8632012-07-17 Dmitry Antipov <dmantipov@yandex.ru>
864
865 Fix previous change to make Fmemory_free always accurate.
866 * alloc.c (make_interval): Update total_free_intervals.
867 (make_float): Likewise for total_free_floats.
868 (free_cons, Fcons): Likewise for total_free_conses.
869 (SETUP_ON_FREE_LIST, allocate_vector_from_block):
870 Likewise for total_free_vector_bytes.
871 (Fmake_symbol): Likewise for total_free_symbols.
872 (bytes_free): Remove.
873
7098646f
DA
8742012-07-17 Dmitry Antipov <dmantipov@yandex.ru>
875
876 Simple free memory accounting feature.
877 * alloc.c (bytes_free, total_free_vector_bytes): New variable.
878 (sweep_vectors): Accumulate size of free vectors.
879 (Fgarbage_collect): Setup bytes_free.
880 (Fmemory_free): New function.
881 (syms_of_alloc): Register it.
882
22657b40
DA
8832012-07-17 Dmitry Antipov <dmantipov@yandex.ru>
884
885 Cleanup overlays checking.
886 * buffer.h (OVERLAY_VALID): Remove as useless synonym of OVERLAYP.
887 * buffer.c (overlay_touches_p, recenter_overlay_lists): Change to
888 eassert and OVERLAYP.
889 (sort_overlays): Change to use OVERLAYP.
890
ddfc8813
RK
8912012-07-16 René Kyllingstad <Rene@Kyllingstad.com> (tiny change)
892
893 * editfns.c (Finsert_char): Make it interactive, and make the
894 second arg optional. Copy interactive spec and docstring from
895 ucs-insert.
896
7c26cf3c
PE
8972012-07-17 Paul Eggert <eggert@cs.ucla.edu>
898
899 * floatfns.c (Fabs): Do not wrap fabs inside IN_FLOAT (Bug#11913).
900 Unlike the other wrapped functions, fabs has an unspecified
901 effect on errno.
902
5d127af9
JD
9032012-07-16 Jan Djärv <jan.h.d@swipnet.se>
904
905 * nsterm.m (keyDown): Interpret flags without left/right bits
906 as the left key (Bug#11670).
907
6a0dd1d7
DA
9082012-07-16 Dmitry Antipov <dmantipov@yandex.ru>
909
910 Remove empty and useless init functions.
911 * lisp.h (init_character_once, init_fns, init_image)
912 (init_filelock, init_sound): Remove prototype.
913 * character.c (init_character_once): Remove.
914 * filelock.c (init_filelock): Likewise.
915 * fns.c (init_fns): Likewise.
916 * image.c (init_image): Likewise.
917 * sound.c (init_sound): Likewise.
918 * emacs.c (main): Adjust accordingly.
919
7a6136fd
DA
9202012-07-16 Dmitry Antipov <dmantipov@yandex.ru>
921
922 * gtkutil.h: Tiny cleanups.
923 (use_old_gtk_file_dialog): Remove useless declaration.
924 (xg_uses_old_file_dialog): Add suggested const attribute.
925
ce811ad9
EZ
9262012-07-15 Eli Zaretskii <eliz@gnu.org>
927
928 * bidi.c (MAX_STRONG_CHAR_SEARCH): New macro.
929 (bidi_paragraph_init): Use it to limit search forward for a strong
930 directional character in abnormally large paragraphs full of
931 neutral or weak characters. (Bug#11943)
932
c9adfeaa
SF
9332012-07-15 Stefano Facchini <stefano.facchini@gmail.com> (tiny change)
934
935 * gtkutil.c (xg_create_tool_bar): Apply "primary-toolbar" style to
936 the toolbar (Bug#9451).
937 (xg_make_tool_item): Give the widget event box a transparent
938 background.
939
fff62aa9
DA
9402012-07-15 Dmitry Antipov <dmantipov@yandex.ru>
941
942 Cleanup basic allocation variables and functions.
943 * alloc.c (ignore_warnings, init_intervals, init_float)
944 (init_cons, init_symbol, init_marker): Remove.
945 (interval_block_index): Initialize to INTERVAL_BLOCK_SIZE.
946 (float_block_index): Initialize to FLOAT_BLOCK_SIZE.
947 (cons_block_index): Initialize to CONS_BLOCK_SIZE.
948 (symbol_block_size): Initialize to SYMBOL_BLOCK_SIZE.
949 (marker_block_index): Initialize to MARKER_BLOCK_SIZE.
950 (staticidx, init_alloc_once, init_strings, free_ablock):
951 Remove redundant initialization.
952 * fns.c (init_weak_hash_tables): Remove.
953 * lisp.h (init_weak_hash_tables): Remove prototype.
954
9730daca
DA
9552012-07-15 Dmitry Antipov <dmantipov@yandex.ru>
956
957 Use zero_vector where appropriate.
958 * alloc.c (zero_vector): Define as Lisp_Object. Adjust users
959 accordingly.
960 * lisp.h (zero_vector): New declaration.
961 * font.c (null_vector): Remove.
962 (syms_of_font): Remove initialization and staticpro.
963 (font_list_entities, font_find_for_lface): Change to use zero_vector.
964 * keymap.c (Faccessible_keymaps): Likewise.
965
2e2d2a13
LL
9662012-07-15 Leo Liu <sdl.web@gmail.com>
967
968 * fringe.c: Fix typo in comments.
969
cd276f6e
LL
9702012-07-14 Leo Liu <sdl.web@gmail.com>
971
972 * fringe.c: Add a new bitmap exclamation-mark.
973
5a1131d9
EZ
9742012-07-14 Eli Zaretskii <eliz@gnu.org>
975
976 * gmalloc.c (GMALLOC_INHIBIT_VALLOC): Don't reference.
977
978 * s/msdos.h (BSD_SYSTEM, DATA_START, GC_SETJMP_WORKS, HAVE_MOUSE)
979 (HAVE_MENUS): Don't define, defined by editing config.in with
980 msdos/sed2v2.inp.
981 (GMALLOC_INHIBIT_VALLOC): Don't define.
982 (MODE_LINE_BINARY_TEXT): Remove, not used anymore.
983
22e983b7
JB
9842012-07-14 Juanma Barranquero <lekktu@gmail.com>
985
986 * s/ms-w32.h (GC_SETJMP_WORKS, GC_MARK_STACK): Set in nt/config.nt.
987
5b3f250f
GM
9882012-07-14 Glenn Morris <rgm@gnu.org>
989
990 * s/aix4-2.h, s/freebsd.h, s/gnu-linux.h, s/hpux10-20.h:
991 * s/irix6-5.h, s/netbsd.h, s/sol2-6.h, s/unixware.h:
992 Let configure set GC_SETJMP_WORKS, GC_MARK_STACK.
993
33d63ff4
GM
9942012-07-13 Glenn Morris <rgm@gnu.org>
995
5b633342
GM
996 * s/gnu-linux.h (GC_MARK_SECONDARY_STACK): Let configure set it.
997
33d63ff4
GM
998 * s/usg5-4-common.h (SETUP_SLAVE_PTY): Let configure set it.
999 * s/irix6-5.h (SETUP_SLAVE_PTY): No more need to unset it.
1000
b55b9f85
JD
10012012-07-13 Jan Djärv <jan.h.d@swipnet.se>
1002
0dc8cf50
JD
1003 * nsterm.m (uRect): Only define if NS_IMPL_GNUSTEP.
1004 (x_free_frame_resources): Pass x_free_frame_resources to NSTRACE.
1005 (ns_lisp_to_color, ns_string_to_lispmod, ns_term_init)
1006 (ns_term_shutdown, requestService, initFrameFromEmacs): Use SSDATA
1007 where appropriate.
1008 (ns_exec_path, ns_load_path, changeFont): Put () around assignment used
1009 as boolean expression.
1010 (x_set_window_size): Remove unused variable toolbar.
1011 (ns_get_color_default, ns_mod_to_lisp): Remove.
1012 (ns_mouse_position): Remove unused variables xchar and ychar.
1013 (ns_compute_glyph_string_overhangs): Remove unused variable face.
1014 (ns_set_vertical_scroll_bar): Remove unused variable count.
1015 (ns_delete_terminal): Remove unused variable i.
1016 (ns_term_init): Remove unused variables r, g and b.
1017 (mouseDown): Remove unused variable window.
1018 (windowDidResize): Move definition of theWindow inside NS_IMPL_GNUSTEP.
1019 (initFrameFromEmacs): Remove unused variable vbextra.
1020 (mouseEntered): Remove unused variables p and dpyinfo.
1021 (mouseExited): Remove unused variables p and r.
1022 (ns_define_frame_cursor, ns_clear_frame_area)
1023 (ns_draw_window_cursor, ns_initialize_display_info): Make static.
1024 (menuDown): Assign [sender tag] to variable and cast the variable.
1025
1026 * nsterm.h (menuDown): Add id as type to argument sender.
1027 (ns_display_info_for_name): Add Lisp_Object argument.
1028 (ns_term_init): Add Lisp_Object argument.
1029 (ns_map_event_to_object): Add void argument.
1030 (ns_string_from_pasteboard, ns_string_to_pasteboard): Add correct
1031 prototype with arguments and only declare if __OBJC__.
1032 (nxatoms_of_nsselect): Add void argument.
1033 (ns_lisp_to_cursor_type): Add Lisp_Object argument.
1034 (ns_alloc_autorelease_pool): Add void argument.
1035 (ns_release_autorelease_pool): Add void* argument.
1036 (ns_get_defaults_value): Add const char* argument.
1037
1038 * nsmenu.m (ns_update_menubar, ns_menu_show, process_dialog)
1039 (initFromContents): Use SSDATA where appropriate.
1040 (ns_update_menubar): Add braces to ambigous if-else.
1041 (initWithTitle): Put () around assignment in if statement.
1042 (ns_menu_show): Remove unused variables window and keymap.
1043 (update_frame_tool_bar): Remove unused variable selected_p.
1044 (initWithContentRect): Remove unused variable this_cmd_name.
1045
1046 * nsimage.m (ns_load_image, allocInitFromFile): Use SSDATA where
1047 appropriate.
1048 (setXBMColor): Remove unused variable len.
1049 (setPixmapData): Put () around assignment in loop statement.
1050
1051 * nsfont.m (ns_get_family, ns_lang_to_script, ns_otf_to_script)
1052 (ns_registry_to_script, ns_get_req_script, nsfont_open): Use SSDATA
1053 where appropriate.
1054 (ns_get_covering_families, ns_findfonts, nsfont_list_family): Put ()
1055 around assignment in loop statement.
1056 (nsfont_open): Remove unused variable i.
1057 (nsfont_open): Remove unused variable len.
1058 (nsfont_draw): Remove unused variable cs.
1059
1060 * nsfns.m (x_set_icon_name, ns_set_name_internal)
1061 (ns_set_name_as_filename, ns_implicitly_set_icon_type)
1062 (x_set_icon_type, ns_lisp_to_cursor_type, Fns_read_file_name)
1063 (Fns_get_resource, Fns_set_resource, Fx_open_connection)
1064 (Fns_font_name, Fns_perform_service)
1065 (Fns_convert_utf8_nfd_to_nfc, ns_do_applescript)
1066 (Fns_do_applescript, Fx_show_tip): Use SSDATA where appropriate.
1067 (ns_set_name): Remove unused variable view.
1068 (x_set_menu_bar_lines): Remove unused variable olines.
1069 (x_set_tool_bar_lines): Remove unused variable root_window.
1070 (Fns_list_colors): Put () around assignment in while statement.
1071 (Fns_perform_service): Remove unused variable len.
1072 (Fns_display_usable_bounds): Remove unused variable top.
1073 (syms_of_nsfns): Remove unused variable i.
1074
b55b9f85
JD
1075 * nsmenu.m (ns_update_menubar): Exchange place of argument 2 and 3 to
1076 memcpy (Bug#11907).
1077
ed9265fc 10782012-07-13 Kalle Kankare <kalle.kankare@iki.fi> (tiny change)
2277de02
JD
1079
1080 * image.c (Fimagemagick_types): Initialize ex with GetExceptionInfo
1081 and free it with DestroyExceptionInfo (Bug#11558).
1082
ef099b57
JB
10832012-07-13 Juanma Barranquero <lekktu@gmail.com>
1084
1085 * s/ms-w32.h (FIRST_PTY_LETTER, HAVE_SOCKETS): Move to nt/config.nt.
1086 (HAVE_ATTRIBUTE_ALIGNED, HAVE_C99_STRTOLD, HAVE___BUILTIN_UNWIND_INIT):
1087 Set here, not in nt/config.nt.
1088
ea814a5d
EZ
10892012-07-13 Eli Zaretskii <eliz@gnu.org>
1090
1091 * xdisp.c (move_it_in_display_line_to): On GUI terminals, allow
1092 cursor overflow into the last glyph on display line when the right
1093 fringe is off. (Bug#11832)
1094
1a952767
PE
10952012-07-13 Paul Eggert <eggert@cs.ucla.edu>
1096
1097 * xdisp.c (produce_special_glyphs): Now static.
1098 * dispextern.h (produce_special_glyphs): Remove decl.
1099
983188fd
GM
11002012-07-13 Glenn Morris <rgm@gnu.org>
1101
8d7c7eed 1102 * s/bsd-common.h, s/cygwin.h: Remove empty files.
32fb4bb6
GM
1103 * s/freebsd.h, s/netbsd.h: Do not include bsd-common.h.
1104
983188fd
GM
1105 * s/usg5-4-common.h (USG, USG5):
1106 * s/template.h (USG5, USG, HPUX, BSD4_2, BSD_SYSTEM):
1107 * s/sol2-6.h (SOLARIS2):
1108 * s/irix6-5.h (IRIX6_5):
1109 * s/hpux10-20.h (USG, USG5, HPUX):
1110 * s/gnu-linux.h (USG, GNU_LINUX):
1111 * s/freebsd.h (BSD_SYSTEM):
1112 * s/darwin.h (BSD4_2, BSD_SYSTEM, DARWIN_OS):
1113 * s/cygwin.h (CYGWIN):
1114 * s/bsd-common.h (BSD_SYSTEM, BSD4_2):
1115 * s/aix4-2.h (USG, USG5, _AIX): Move "system type" macros to configure.
1116
d1e68667 11172012-07-13 BT Templeton <bpt@hcoop.net> (tiny change)
24ef80ae
PE
1118
1119 * nsfont.m (ns_charset_covers): Don't abort if no bitmap (Bug#11853).
24ef80ae 1120
6de0e799
GM
11212012-07-13 Glenn Morris <rgm@gnu.org>
1122
739ae010
GM
1123 * s/usg5-4-common.h (NSIG_MINIMUM): Let configure set it.
1124
dbee5793
GM
1125 * s/gnu-linux.h, s/irix6-5.h: Let configure set ULIMIT_BREAK_VALUE.
1126
6de0e799
GM
1127 * process.c (init_process_emacs): Replace MIN_PTY_KERNEL_VERSION.
1128 * s/darwin.h (MIN_PTY_KERNEL_VERSION): Remove single-use macro.
1129
b82da769
GM
11302012-07-12 Glenn Morris <rgm@gnu.org>
1131
4fae5a7a 1132 * s/darwin.h (SYSTEM_PURESIZE_EXTRA): Move to configure.
b82da769
GM
1133
1134 * process.c (init_process_emacs): Rename from init_process.
1135 The old name is also the name of a Mach system call.
1136 * lisp.h, emacs.c: Update for this name change.
1137 * nsgui.h, sysselect.h, s/darwin.h: Remove workaround that is no
1138 longer needed.
1139
5a979817
EZ
11402012-07-12 Eli Zaretskii <eliz@gnu.org>
1141
1142 * xdisp.c (insert_left_trunc_glyphs): Fix incorrect size in
1143 memmove call that removes glyphs covered by the left truncation
1144 glyph. Improve commentary.
1145 (display_line): Fix display of continuation glyphs on GUI frames
1146 when the right fringe is turned off and variable-size fonts are
1147 used in the window. Move the code that appends a stretch glyph to
1148 produce_special_glyphs, so that it could be used for truncation
1149 and continuation glyphs alike.
1150 (produce_special_glyphs) [HAVE_WINDOW_SYSTEM]: Produce a stretch
1151 glyph of a suitably computed width, to align the special glyphs at
1152 the window margin. Code moved from display_line. (Bug#11832)
1153
3e91a053
GM
11542012-07-12 Glenn Morris <rgm@gnu.org>
1155
ba9e4b84
GM
1156 * s/aix4-2.h, s/hpux10-20.h: Let configure set NO_EDITRES.
1157
1158 * s/gnu-linux.h, s/hpux10-20.h:
1159 Do not unconditionally define HAVE_XRMSETDATABASE.
1160
3e91a053
GM
1161 * s/gnu-linux.h (UNIX98_PTYS): Let configure set it.
1162
b300b1f4
PE
11632012-07-12 Paul Eggert <eggert@cs.ucla.edu>
1164
1165 Fix typos that broke OS X build.
1166 Reported by Randal L. Schwartz in
1167 <http://lists.gnu.org/archive/html/emacs-devel/2012-07/msg00225.html>.
1168 * nsterm.m (ns_timeout): Add missing local decl.
1169 (ns_get_color): snprintf -> sprintf, to fix typo.
1170
6e777848
GM
11712012-07-12 Glenn Morris <rgm@gnu.org>
1172
3f922c37
GM
1173 * src/s/aix4-2.h, src/s/cygwin.h, src/s/darwin.h:
1174 * src/s/gnu-linux.h, src/s/hpux10-20.h, src/s/irix6-5.h:
1175 * src/s/sol2-6.h, src/s/unixware.h, src/s/usg5-4-common.h:
1176 Move PTY_NAME_SPRINTF, PTY_TTY_NAME_SPRINTF to configure.
1177
0ab7b23a
GM
1178 * s/cygwin.h, s/darwin.h, s/gnu-linux.h, s/irix6-5.h:
1179 Move PTY_OPEN to configure.
1180
6e777848
GM
1181 * s/aix4-2.h, s/bsd-common.h, s/cygwin.h, s/darwin.h:
1182 * s/gnu-linux.h, s/hpux10-20.h, s/irix6-5.h, s/template.h:
1183 * s/usg5-4-common.h: Move FIRST_PTY_LETTER, PTY_ITERATION to configure.
1184
4a7edc24
DA
11852012-07-12 Dmitry Antipov <dmantipov@yandex.ru>
1186
1187 Use empty_unibyte_string where applicable.
1188 * keyboard.c (parse_tool_bar_item): Use empty_unibyte_string.
1189 * lread.c (read1): Likewise.
1190 * xsettings.c (syms_of_xsettings): Likewise.
1191
308aab79
GM
11922012-07-12 Glenn Morris <rgm@gnu.org>
1193
42bd1719
GM
1194 * s/cygwin.h (G_SLICE_ALWAYS_MALLOC):
1195 * s/freebsd.h (BROKEN_PTY_READ_AFTER_EAGAIN):
7ccad002
GM
1196 * s/irix6-5.h (SETPGRP_RELEASES_CTTY, PREFER_VSUSP):
1197 * s/hpux10-20.h (RUN_TIME_REMAP):
1198 * s/bsd-common.h (TABDLY): Move to configure.
1199
1200 * s/hpux10-20.h, s/sol2-6.h: Move XOS_NEEDS_TIME_H to configure.
1201
1202 * s/bsd-common.h, s/darwin.h: Move TAB3 to configure.
1203
ea0bbd17 1204 * s/aix4-2.h (BROKEN_FIONREAD, BROKEN_SIGAIO, BROKEN_SIGPTY)
42bd1719 1205 (BROKEN_SIGPOLL, BROKEN_GET_CURRENT_DIR_NAME): Let configure set them.
ea0bbd17
GM
1206
1207 * s/darwin.h (NO_ABORT, NO_MATHERR): Let configure set them.
51c3b9b4 1208
308aab79
GM
1209 * s/bsd-common.h, s/cygwin.h, s/gnu-linux.h, s/irix6-5.h:
1210 * s/template.h: Move NARROWPROTO to configure.
1211
ee1cf5cf
GM
12122012-07-11 Glenn Morris <rgm@gnu.org>
1213
30fe9bf4
GM
1214 * s/gnu-linux.h, s/sol2-6.h: No longer define POSIX,
1215 unused since 2011-01-17 change to systty.h.
1216
ee1cf5cf
GM
1217 * s/aix4-2.h, s/bsd-common.h, s/cygwin.h, s/darwin.h, s/gnu-linux.h:
1218 * s/hpux10-20.h, s/template.h, s/usg5-4-common.h:
1219 Move HAVE_PTYS and HAVE_SOCKETS to configure.
1220
63e47e07
PE
12212012-07-11 Paul Eggert <eggert@cs.ucla.edu>
1222
1223 * s/sol2-6.h (HAVE_LIBKSTAT): Remove. (Bug#11914)
1224
c43fb4c3
GM
12252012-07-11 Glenn Morris <rgm@gnu.org>
1226
1227 * s/darwin.h, s/gnu-linux.h, s/template.h:
1228 Move INTERRUPT_INPUT to configure.
1229
e8df9267
DA
12302012-07-11 Dmitry Antipov <dmantipov@yandex.ru>
1231
1232 Minor adjustments to interning code.
1233 * lisp.h (intern, intern_c_string): Redefine as static inline
1234 wrappers for intern_1 and intern_c_string_1, respectively.
1235 (intern_1, intern_c_string_1): Rename prototypes.
2bce5643
DA
1236 * lread.c (intern_1, intern_c_string_1, oblookup): Simplify
1237 Vobarray checking.
e8df9267
DA
1238 * font.c (font_intern_prop): Likewise. Adjust comment.
1239 * w32font.c (intern_font_name): Likewise.
1240
34348bd4
AS
12412012-07-11 Andreas Schwab <schwab@linux-m68k.org>
1242
d96a1e0c
AS
1243 * gnutls.c (Fgnutls_boot): Properly parse :keylist argument.
1244
34348bd4
AS
1245 * coding.c (Fdefine_coding_system_internal): Use XCAR/XCDR instead
1246 of Fcar/Fcdr if possible.
1247 * font.c (check_otf_features): Likewise.
1248 * fontset.c (Fnew_fontset): Likewise.
1249 * gnutls.c (Fgnutls_boot): Likewise.
1250 * minibuf.c (read_minibuf): Likewise.
1251 * msdos.c (IT_set_frame_parameters): Likewise.
1252 * xmenu.c (Fx_popup_dialog): Likewise.
1253 * w32menu.c (Fx_popup_dialog): Likewise.
1254
c8add24e
GM
12552012-07-11 Glenn Morris <rgm@gnu.org>
1256
4b575b3c
GM
1257 * s/bsd-common.h, s/cygwin.h: No need to undefine INTERRUPT_INPUT,
1258 since nothing has defined it on these platforms.
1259
09f4e3b0
GM
1260 * s/aix4-2.h, s/bsd-common.h, s/cygwin.h, s/gnu-linux.h:
1261 * s/irix6-5.h: Move SIGNALS_VIA_CHARACTERS to configure.
1262
172bedef
GM
1263 * s/aix4-2.h, s/bsd-common.h, s/cygwin.h, s/darwin.h:
1264 * s/gnu-linux.h, s/hpux10-20.h, s/template.h, s/usg5-4-common.h:
1265 Move CLASH_DETECTION to configure.
1266
249685df
GM
1267 * s/gnu.h: Remove file, which is now empty.
1268
c8add24e
GM
1269 * s/gnu.h, s/gnu-linux.h:
1270 Move GNU_LIBRARY_PENDING_OUTPUT_COUNT to configure.
1271
b41253a3
JW
12722012-07-11 John Wiegley <johnw@newartisans.com>
1273
1274 * alloc.c (mark_memory): Guard the "no_address_safety_analysis"
1275 function attribute, so we only use it if it exists in the
1276 compiler.
1277
d923b542
DA
12782012-07-11 Dmitry Antipov <dmantipov@yandex.ru>
1279
1280 Avoid call to strlen in fast_c_string_match_ignore_case.
1281 * search.c (fast_c_string_match_ignore_case): Change to use
1282 length argument. Adjust users accordingly.
1283 * lisp.h (fast_c_string_match_ignore_case): Adjust prototype.
1284
5ebbef1d
PE
12852012-07-11 Paul Eggert <eggert@cs.ucla.edu>
1286
bb352260
PE
1287 Assume mkdir, rmdir.
1288 * sysdep.c (mkdir) [!HAVE_MKDIR]: Remove.
1289 * sysdep.c (rmdir) [!HAVE_RMDIR]: Remove.
1290
57054ddd
PE
1291 Assume rename.
1292 * sysdep.c (rename) [!HAVE_RENAME]: Remove.
1293
b747d3f7
PE
1294 Assume perror.
1295 * s/hpux10-20.h (HAVE_PERROR): Remove.
1296 * sysdep.c (perror) [HPUX && !HAVE_PERROR]:
1297 Remove dummy definition, as this problem was obsolete long ago.
1298
5ebbef1d
PE
1299 Assume strerror.
1300 * sysdep.c (strerror) [!HAVE_STRERROR && !WINDOWSNT]: Remove.
1301
984e7f30
DA
13022012-07-11 Dmitry Antipov <dmantipov@yandex.ru>
1303
1304 Avoid calls to strlen in font processing functions.
1305 * font.c (font_parse_name, font_parse_xlfd, font_parse_fcname)
d923b542 1306 (font_open_by_name): Change to use length argument. Adjust
984e7f30 1307 users accordingly.
d923b542
DA
1308 * font.h (font_open_by_name, font_parse_xlfd, font_unparse_xlfd):
1309 Adjust prototypes.
1310 * xfont.c (xfont_decode_coding_xlfd, font_unparse_xlfd):
1311 Change to return ptrdiff_t.
984e7f30
DA
1312 (xfont_list_pattern, xfont_match): Use length returned by
1313 xfont_decode_coding_xlfd.
1314 * xfns.c (x_default_font_parameter): Omit useless xstrdup.
1315
20e94fdd
GM
13162012-07-11 Glenn Morris <rgm@gnu.org>
1317
9d596af3
GM
1318 * s/darwin.h, s/freebsd.h, s/netbsd.h:
1319 Move DONT_REOPEN_PTY to configure.
1320
20e94fdd
GM
1321 * sound.c (DEFAULT_SOUND_DEVICE) [!WINDOWSNT]:
1322 * s/netbsd.h (DEFAULT_SOUND_DEVICE): Let configure set it.
1323
e99a530f
PE
13242012-07-10 Paul Eggert <eggert@cs.ucla.edu>
1325
22ffb973
PE
1326 Remove "#define unix" that is no longer needed (Bug#11905).
1327 * s/aix4-2.h (unix): Remove; no longer needed.
1328
e9a9ae03
PE
1329 EMACS_TIME simplification (Bug#11875).
1330 This replaces macros (which typically do not work in GDB)
1331 with functions, typedefs and enums, making the code easier to debug.
1332 The functional style also makes code easier to read and maintain.
1333 * systime.h: Include <sys/time.h> on all hosts, not just if
1334 WINDOWSNT, since 'struct timeval' is needed in general.
1335 (EMACS_TIME): Now a typedef, not a macro.
1336 (EMACS_TIME_RESOLUTION, LOG10_EMACS_TIME_RESOLUTION): Now constants,
1337 not macros.
1338 (EMACS_SECS, EMACS_NSECS, EMACS_TIME_SIGN, EMACS_TIME_VALID_P)
1339 (EMACS_TIME_FROM_DOUBLE, EMACS_TIME_TO_DOUBLE, EMACS_TIME_EQ)
1340 (EMACS_TIME_NE, EMACS_TIME_GT, EMACS_TIME_GE, EMACS_TIME_LT)
1341 (EMACS_TIME_LE): Now functions, not macros.
1342 (EMACS_SET_SECS, EMACS_SET_NSECS, EMACS_SET_SECS_NSECS)
1343 (EMACS_SET_USECS, EMACS_SET_SECS_USECS): Remove these macros,
1344 which are not functions. All uses rewritten to use:
1345 (make_emacs_time): New function.
1346 (EMACS_SECS_ADDR, EMACS_SET_INVALID_TIME, EMACS_GET_TIME)
1347 (EMACS_ADD_TIME, EMACS_SUB_TIME): Remove these macros, which are
1348 not functions. All uses rewritten to use the following, respectively:
1349 (emacs_secs_addr, invalid_emacs_time, get_emacs_time)
1350 (add_emacs_time, sub_emacs_time): New functions.
ed9265fc 1351 * atimer.c: Don't include <sys/time.h>, as "systime.h" does this.
e9a9ae03
PE
1352 * fileio.c (Fcopy_file):
1353 * xterm.c (XTflash): Get the current time closer to when it's used.
1354 * makefile.w32-in ($(BLD)/atimer.$(O)): Update dependencies.
1355
ffacb126
PE
1356 * bytecode.c (targets): Suppress -Woverride-init warnings.
1357
e99a530f
PE
1358 Simplify by avoiding confusing use of strncpy etc.
1359 * doc.c (Fsnarf_documentation):
1360 * fileio.c (Ffile_name_directory, Fsubstitute_in_file_name):
1361 * frame.c (Fmake_terminal_frame):
1362 * gtkutil.c (get_utf8_string):
1363 * lread.c (openp):
1364 * nsmenu.m (ns_update_menubar):
1365 * regex.c (regerror):
1366 Prefer memcpy to strncpy and strncat when either will do.
1367 * fileio.c (Fsubstitute_in_file_name):
1368 * keyboard.c (MULTI_LETTER_MOD, parse_modifiers_uncached)
1369 (menu_separator_name_p):
1370 * nsmenu.m (ns_update_menubar):
1371 Prefer memcmp to strncmp when either will do.
1372 * nsterm.m: Include <ftoastr.h>.
1373 (ns_get_color):
1374 * s/gnu-linux.h, s/sol2-6.h, s/unixware.h (PTY_TTY_NAME_SPRINTF):
1375 Prefer snprintf to strncpy.
1376 * nsterm.m (ns_term_init):
1377 * widget.c (set_frame_size) [0]: Prefer xstrdup to xmalloc + strncpy.
1378 * nsterm.m (ns_term_init):
1379 Avoid the need for strncpy, by using build_string or
1380 make_unibyte_string directly. Use dtoastr, not snprintf.
1381 * process.c (Fmake_network_process): Diagnose service names that
1382 are too long, rather than silently truncating them or creating
1383 non-null-terminated names.
1384 (Fnetwork_interface_info): Likewise, for interface names.
1385 * sysdep.c (system_process_attributes) [GNU_LINUX]:
1386 Prefer sprintf to strncat.
1387 * xdisp.c (debug_method_add) [GLYPH_DEBUG]:
1388 Prefer vsnprintf to vsprintf + strncpy.
1389
c59592b3
GM
13902012-07-10 Glenn Morris <rgm@gnu.org>
1391
1392 * dispnew.c (PENDING_OUTPUT_COUNT) [!__GNU_LIBRARY__]:
1393 Clarify fallback case.
1394
7d7bbefd
DA
13952012-07-10 Dmitry Antipov <dmantipov@yandex.ru>
1396
1397 Use XCAR and XCDR instead of Fcar and Fcdr where possible.
1398 * callint.c, coding.c, doc.c, editfns.c, eval.c, font.c, fontset.c,
1399 * frame.c, gnutls.c, minibuf.c, msdos.c, textprop.c, w32fns.c,
d923b542 1400 * w32menu.c, window.c, xmenu.c: Change to use XCAR and XCDR
7d7bbefd
DA
1401 where argument type is known to be a Lisp_Cons.
1402
3a4c8000
TT
14032012-07-10 Tom Tromey <tromey@redhat.com>
1404
1405 * bytecode.c (BYTE_CODE_THREADED): New macro.
1406 (BYTE_CODES): New macro. Replaces all old byte-code defines.
1407 (enum byte_code_op): New type.
1408 (CASE, NEXT, FIRST, CASE_DEFAULT, CASE_ABORT): New macros.
1409 (exec_byte_code): Use them. Use token threading when applicable.
1410
2a0213a6
DA
14112012-07-10 Dmitry Antipov <dmantipov@yandex.ru>
1412
1413 Optimize pure C strings initialization.
1414 * lisp.h (make_pure_string): Fix prototype.
1415 (build_pure_c_string): New function, defined as static inline. This
1416 provides a better opportunity to optimize away calls to strlen when
1417 the function is called with compile-time constant argument.
1418 * alloc.c (make_pure_c_string): Fix comment. Change to add nchars
1419 argument, adjust users accordingly. Use build_pure_c_string where
1420 appropriate.
1421 * buffer.c, coding.c, data.c, dbusbind.c, fileio.c, fontset.c, frame.c,
1422 * keyboard.c, keymap.c, lread.c, search.c, syntax.c, w32fns.c, xdisp.c,
1423 * xfaces.c, xfns.c, xterm.c: Use build_pure_c_string where appropriate.
1424
cb1caeaf
DA
14252012-07-10 Dmitry Antipov <dmantipov@yandex.ru>
1426
1427 Avoid calls to strlen in miscellaneous functions.
1428 * buffer.c (init_buffer): Use precalculated len, adjust if needed.
1429 * font.c (Ffont_xlfd_name): Likewise. Change to call make_string.
1430 * lread.c (openp): Likewise.
1431
c293e30c
DA
14322012-07-10 Dmitry Antipov <dmantipov@yandex.ru>
1433
1434 Avoid calls to strlen in path processing functions.
1435 * fileio.c (file_name_as_directory): Add comment. Change to add
1436 srclen argument and return the length of result. Adjust users
1437 accordingly.
1438 (directory_file_name): Fix comment. Change to add srclen argument,
cb1caeaf 1439 swap 1st and 2nd arguments to obey the common convention. Adjust
c293e30c
DA
1440 users accordingly.
1441 * filelock.c (fill_in_lock_file_name): Avoid calls to strlen.
1442
9e059e3f
GM
14432012-07-10 Glenn Morris <rgm@gnu.org>
1444
d02eb359
GM
1445 * s/cygwin.h, s/darwin.h, s/freebsd.h, s/netbsd.h, s/unixware.h:
1446 Move PENDING_OUTPUT_COUNT definition to configure.
1447
882cf227
GM
1448 * s/irix6-5.h (DATA_START, DATA_SEG_BITS):
1449 * s/hpux10-20.h (DATA_SEG_BITS, DATA_START):
1450 * s/gnu.h (DATA_START): Move definitions to configure.
1451
af6e839f
GM
1452 * s/irix6-5.h (SETUP_SLAVE_PTY, PTY_NAME_SPRINTF): Drop ifdef guards.
1453 We include usg5-4-common.h, which defines them both.
1454
40289a12
GM
1455 * s/gnu.h: Don't include fcntl.h (every file in Emacs that uses
1456 O_RDONLY already includes it).
1457
9e059e3f
GM
1458 Stop ns builds setting the EMACSLOADPATH environment variable.
1459 * nsterm.m (ns_load_path): Rename from ns_init_paths.
1460 Now it does not set EMACSLOADPATH, just returns the load-path string.
1461 * nsterm.h: Update accordingly.
1462 * lread.c [HAVE_NS]: Include nsterm.h.
1463 (init_lread) [HAVE_NS]: Use ns_load_path.
1464 * emacs.c (main) [HAVE_NS]: No longer call ns_init_paths.
1465
7c4e8ec0
GM
14662012-07-09 Glenn Morris <rgm@gnu.org>
1467
d4f600ff
GM
1468 * s/gnu.h (SIGNALS_VIA_CHARACTERS): No need to define it here,
1469 since the included bsd-common.h does so.
1470
cbb31951
GM
1471 Stop ns builds setting the EMACSPATH environment variable.
1472 * nsterm.m (ns_exec_path): New function, split from ns_init_paths.
1473 (ns_init_paths): Do not set EMACSPATH.
1474 * nsterm.h (ns_exec_path): Add it.
1475 * callproc.c (init_callproc_1, init_callproc) [HAVE_NS]:
1476 Use ns_exec_path.
1477
7c4e8ec0
GM
1478 * nsterm.m, nsterm.h (ns_etc_directory): Fix type, empty return.
1479
26bccfae
PE
14802012-07-09 Paul Eggert <eggert@cs.ucla.edu>
1481
a0bee46f
PE
1482 * process.c (wait_reading_process_output): 'waitchannels' was unset
1483 when read_kbd || !NILP (wait_for_cell); fix this.
1484
5994c183
PE
1485 Add GCC-style 'const' attribute to functions that can use it.
1486 * character.h (char_resolve_modifier_mask):
1487 * keyboard.h (make_ctrl_char):
1488 * lisp.h (multibyte_char_to_unibyte, multibyte_char_to_unibyte_safe)
1489 (init_character_once, next_almost_prime, init_fns, init_image)
1490 (flush_pending_output, init_sound):
1491 * mem-limits.h (start_of_data):
1492 * menu.h (finish_menu_items):
1493 Add ATTRIBUTE_CONST.
1494 * emacs.c (DEFINE_DUMMY_FUNCTION):
1495 Declare the dummy function with ATTRIBUTE_CONST.
1496 * lisp.h (Fbyteorder, Fmax_char, Fidentity):
1497 Add decls with ATTRIBUTE_CONST.
1498
26bccfae
PE
1499 Minor improvements to make_formatted_string.
1500 * alloc.c (make_formatted_string): Prefer int to ptrdiff_t
1501 where int is good enough, as vsprintf returns an int.
1502 * lisp.h (make_formatted_string): Add ATTRIBUTE_FORMAT_PRINTF.
1503
a8290ec3
DA
15042012-07-09 Dmitry Antipov <dmantipov@yandex.ru>
1505
1506 Use make_formatted_string to avoid double length calculation.
1507 * lisp.h (make_formatted_string): New prototype.
1508 * alloc.c (make_formatted_string): New function.
1509 * buffer.c (Fgenerate_new_buffer_name): Use it.
1510 * dbus.c (syms_of_dbusbind): Likewise.
1511 * editfns.c (Fcurrent_time_zone): Likewise.
1512 * filelock.c (get_boot_time): Likewise.
1513 * frame.c (make_terminal_frame, set_term_frame_name)
1514 (x_report_frame_params): Likewise.
1515 * image.c (gs_load): Likewise.
1516 * minibuf.c (get_minibuffer): Likewise.
1517 * msdos.c (dos_set_window_size): Likewise.
1518 * process.c (make_process): Likewise.
1519 * xdisp.c (ensure_echo_area_buffers): Likewise.
1520 * xsettings.c (apply_xft_settings): Likewise.
1521
d01ba2f1
GM
15222012-07-09 Glenn Morris <rgm@gnu.org>
1523
1524 Stop ns builds polluting the environment with EMACSDATA, EMACSDOC.
1525 * nsterm.m (ns_etc_directory): New function, split from ns_init_paths.
1526 (ns_init_paths): Do not set EMACSDATA, EMACSDOC.
1527 * nsterm.h (ns_etc_directory): Add it.
1528 * callproc.c [HAVE_NS]: Include nsterm.h.
1529 (init_callproc_1, init_callproc) [HAVE_NS]: Use ns_etc_directory.
1530
f1f924b6
DA
15312012-07-09 Dmitry Antipov <dmantipov@yandex.ru>
1532
1533 Move marker debugging code under MARKER_DEBUG.
1534 * marker.c (MARKER_DEBUG): Move marker debugging code under
1535 #ifdef MARKER_DEBUG because byte_char_debug_check is too slow
1536 for bootstrap with --enable-checking (~3x slowdown reported
1537 by Juanma Barranquero <lekktu@gmail.com>).
1538 (verify_bytepos): Move under #ifdef MARKER_DEBUG.
1539
ab531b66
PE
15402012-07-08 Paul Eggert <eggert@cs.ucla.edu>
1541
1542 * systime.h (EMACS_SUB_TIME): Clarify behavior with unsigned time_t.
1543 See <http://bugs.gnu.org/11825#29>.
1544
c4b3bc8a
EZ
15452012-07-08 Eli Zaretskii <eliz@gnu.org>
1546
1547 * xdisp.c (fill_glyphless_glyph_string): If the face of the glyph
1548 has no font, use the frame's font. (Bug#11813)
3434fe8a
EZ
1549 (display_line): Add commentary about displaying truncation glyphs
1550 on GUI frames.
1551 (produce_special_glyphs): Move here from term.c.
1552
1553 * term.c (produce_special_glyphs): Move to xdisp.c.
1554
1555 * dispextern.h (produce_special_glyphs): Move prototype to xdisp.c
1556 section.
c4b3bc8a 1557
b676b881
AS
15582012-07-07 Andreas Schwab <schwab@linux-m68k.org>
1559
f17c5273
AS
1560 * xdisp.c (display_line): Avoid warning about implicit declaration
1561 of FRAME_FONT.
1562
298819b9
AS
1563 * frame.c (get_frame_param): Define only if HAVE_WINDOW_SYSTEM.
1564
b676b881
AS
1565 * lisp.h: Remove empty conditional.
1566
6045c4fd
PE
15672012-07-07 Paul Eggert <eggert@cs.ucla.edu>
1568
b3350bf9
PE
1569 * lread.c (load_path_check): Now static.
1570
6045c4fd
PE
1571 Fix some minor --with-ns problems found by static checking.
1572 * frame.c (Ftool_bar_pixel_width) [!FRAME_TOOLBAR_WIDTH]:
1573 (x_set_font) [!HAVE_X_WINDOWS]:
1574 * image.c (xpm_load_image) [HAVE_NS]:
1575 (x_to_xcolors) [!HAVE_X_WINDOWS && !HAVE_NTGUI]:
1576 (x_disable_image) [!HAVE_NS && !HAVE_NTGUI]:
1577 Remove unused local.
1578 (Fx_parse_geometry) [HAVE_NS]: Don't return garbage.
1579 (xpm_load_image) [HAVE_NS && !HAVE_XPM]: Remove unused label.
1580 * image.c (x_create_bitmap_from_file) [HAVE_NS]:
1581 (xpm_load_image, xpm_load) [HAVE_NS && !HAVE_XPM]:
1582 * nsselect.m (symbol_to_nsstring, ns_string_to_pasteboard_internal):
1583 * xfaces.c (Fx_load_color_file) [!HAVE_X_WINDOWS]:
1584 Fix pointer signedness problem.
1585 * xfaces.c (FRAME_X_FONT_TABLE):
1586 * xterm.h (FRAME_X_FONT_TABLE): Remove unused, incompatible macros.
1587
929e7845
GM
15882012-07-07 Glenn Morris <rgm@gnu.org>
1589
1590 * lread.c (load_path_check): New function, split from init_lread.
1591 (init_lread): Reorganize. Motivation:
1592 If EMACSLOADPATH is set, check/warn about that rather than the
1593 defaults, which we are not going to use. Hence we can remove
1594 the turn_off_warning and WINDOWSNT || HAVE_NS tests.
1595 Don't warn if site-lisp directories are missing.
1596 If not installed, start from a blank load-path, since
1597 PATH_LOADSEARCH refers to the eventual installation directories.
1598
58dd0aa4
EZ
15992012-07-07 Eli Zaretskii <eliz@gnu.org>
1600
1601 Support truncation and continuation glyphs on GUI frames, when
1602 fringes are disabled. (Bug#11832)
1603 * xdisp.c (init_iterator): Get dimensions of truncation and
1604 continuation glyphs even if on GUI frames. Adjust
1605 it->last_visible_x on GUI frames when the left or right fringes,
1606 or both, are absent.
1607 (start_display, move_it_in_display_line_to): Handle the case of a
1608 GUI frame without a fringe to display continuation or truncation
1609 glyphs.
1610 (insert_left_trunc_glyphs): Support GUI frames: make sure
1611 truncation glyphs overwrite enough glyphs from the current line to
1612 have sufficient space in pixels.
1613 (display_line): Support truncation and continuation glyphs on GUI
1614 frames. If some spare pixels are left on the line after inserting
1615 the truncation glyphs, fill that space with a stretch glyph of a
1616 suitably computed width.
1617
1618 * term.c (produce_special_glyphs): Call PRODUCE_GLYPHS, not
1619 produce_glyphs, to support GUI sessions.
1620
31571fd7
PE
16212012-07-07 Paul Eggert <eggert@cs.ucla.edu>
1622
5a16b9bc
PE
1623 * sysdep.c (ULLONG_MAX): Define if not already defined (Bug#11781).
1624
f3047c75
PE
1625 * sysdep.c (list_system_processes): Port to NetBSD-current (Bug#11797).
1626
31571fd7
PE
1627 Do not require float-time's arg to fit in time_t (Bug#11825).
1628 This works better on hosts where time_t is unsigned, and where
1629 float-time is applied to the (negative) difference between two times.
1630 * editfns.c (decode_time_components): Last arg is now double *,
1631 not int *, and means to store all the result as a double, without
1632 worrying about whether the seconds part fits in time_t.
1633 All callers changed.
1634 (lisp_time_argument): Remove last int * arg, as it's no longer needed.
1635 All callers changed.
1636 (Ffloat_time): Do not fail merely because the specified time falls
1637 outside of time_t range.
1638
4516fbef
GM
16392012-07-07 Glenn Morris <rgm@gnu.org>
1640
1641 * s/darwin.h (HAVE_RES_INIT, HAVE_LIBRESOLV):
1642 * s/hpux10-20.h (HAVE_RINT, HAVE_RANDOM):
1643 * s/unixware.h (HAVE_GETWD): Move undefs to configure (effectively).
1644
07adc2c6
JB
16452012-07-07 Juanma Barranquero <lekktu@gmail.com>
1646
1647 * makefile.w32-in (DISPEXTERN_H, $(BLD)/regex.$(O)):
1648 Update dependencies.
1649
1650 * s/ms-w32.h [_MSC_VER]: Remove strcasecmp, strncasecmp.
1651
fd573f31
PE
16522012-07-06 Paul Eggert <eggert@cs.ucla.edu>
1653
fee5959d
PE
1654 Use c_strcasecmp for ASCII case-insensitive comparison (Bug#11786).
1655 * dispextern.h, nsfns.m, nsterm.m: Include <c-strcase.h>.
1656 * dispextern.h (xstrcasecmp): Rewrite using c_strcasecmp.
1657 * nsfns.m (x_get_string_resource): Use c_strncasecmp, not strncasecmp.
1658 * nsterm.m (ns_default): Use c_strcasecmp, not strcasecmp.
1659 * xfaces.c (xstrcasecmp) [!HAVE_STRCASECMP]: Remove.
1660
fd573f31
PE
1661 * xfont.c (compare_font_names): Redo to omit the need for casts.
1662
ddadbc0e
AS
16632012-07-06 Andreas Schwab <schwab@linux-m68k.org>
1664
fca8d6b6
AS
1665 * xfns.c (Fx_change_window_property): Doc fix.
1666 * w32fns.c (Fx_change_window_property): Doc fix.
1667
ddadbc0e
AS
1668 * w32fns.c (Fx_window_property): Accept the same arguments as the
1669 X Windows version. Doc fix.
1670 * xfns.c (Fx_window_property): Doc fix. (Bug#11870)
1671
ed9265fc 16722012-07-06 Juanma Barranquero <lekktu@gmail.com>
f247498e
JB
1673 Eli Zaretskii <eliz@gnu.org>
1674
1675 * s/ms-w32.h: Settings not specific to Windows moved to nt/config.nt.
1676 Windows-specific code from nt/config.nt moved here.
1677 Obsolete settings removed.
1678
216ee680
PE
16792012-07-06 Paul Eggert <eggert@cs.ucla.edu>
1680
1681 * process.c: Avoid unnecessary calls to gettime.
1682 (wait_reading_process_output): Don't get the time of day
1683 when gobbling data immediately and not waiting, as there's no need
1684 for it in that case. This removes a FIXME.
1685
bdd091e4
JD
16862012-07-06 Jan Djärv <jan.h.d@swipnet.se>
1687
1688 * gtkutil.c (xg_event_is_for_scrollbar): Assign gwin when HAVE_GTK3
1689 is defined (Bug#11768).
1690
9d44f8ce
DA
16912012-07-06 Dmitry Antipov <dmantipov@yandex.ru>
1692
1693 Fix marker debugging code.
1694 * marker.c (byte_char_debug_check): Do not perform the check
1695 if buffer is not multibyte.
090bd7cb
JB
1696 (buf_charpos_to_bytepos, buf_bytepos_to_charpos):
1697 Call byte_char_debug_check with correct arguments.
9d44f8ce 1698
90fc4786
DA
16992012-07-06 Dmitry Antipov <dmantipov@yandex.ru>
1700
1701 Compile marker debugging code only if ENABLE_CHECKING is defined.
090bd7cb
JB
1702 * marker.c (byte_char_debug_check, count_markers):
1703 Use only if ENABLE_CHECKING is defined.
90fc4786
DA
1704 (byte_debug_flag): Remove.
1705 (CONSIDER, buf_charpos_to_bytepos, buf_bytepos_to_charpos):
1706 Always call byte_char_debug_check if ENABLE_CHECKING is defined.
1707
7b7ae965
DA
17082012-07-06 Dmitry Antipov <dmantipov@yandex.ru>
1709
4e57b342
DA
1710 Avoid code repetition in marker-related functions.
1711 * marker.c (attach_marker): New function.
1712 (Fset_marker, set_marker_restricted, set_marker_both)
1713 (set_marker_restricted_both): Use it.
1714 (Fset_marker, set_marker_restricted, Fbuffer_has_markers_at):
1715 Consistently rename charno to charpos.
1716 (marker_position): Add eassert.
1717 (marker_byte_position): Convert to eassert.
1718
17192012-07-06 Dmitry Antipov <dmantipov@yandex.ru>
1720
1721 Simplify list operations in unchain_overlay and unchain_marker.
7b7ae965 1722 * buffer.c (unchain_overlay): Simplify. Add comment.
4e57b342 1723 * marker.c (unchain_marker): Simplify. Fix comments.
7b7ae965 1724
657924ff
DA
17252012-07-06 Dmitry Antipov <dmantipov@yandex.ru>
1726
1727 Introduce fast path for the widely used marker operation.
1728 * alloc.c (build_marker): New function.
1729 * lisp.h (build_marker): New prototype.
1730 * buffer.c (clone_per_buffer_values, Fmake_indirect_buffer): Use it.
1731 * composite.c (autocmp_chars): Likewise.
1732 * editfns.c (buildmark): Remove.
1733 (Fpoint_marker, Fpoint_min_marker, Fpoint_max_marker)
1734 (save_restriction_save): Use build_marker.
1735 * marker.c (buf_charpos_to_bytepos, buf_bytepos_to_charpos): Likewise.
1736 * window.c (save_window_save): Likewise.
1737
041a49a6
DA
17382012-07-06 Dmitry Antipov <dmantipov@yandex.ru>
1739
1740 Do not use Fdelete_overlay in delete_all_overlays
1741 to avoid redundant calls to unchain_overlay.
1742 * buffer.c (drop_overlay): New function.
1743 (delete_all_overlays, Fdelete_overlay): Use it.
1744 * minibuf.c (get_minibuffer): Fix comment.
1745
7dca65a4
PE
17462012-07-06 Paul Eggert <eggert@cs.ucla.edu>
1747
1748 Port to OpenBSD 5.1 amd64.
1749 * sysdep.c [BSD_SYSTEM]: Include <sys/param.h> before <sys/sysctl.h>.
1750 This is needed for OpenBSD, and should be harmless on all BSD systems.
1751 Also, include <sys/sysctl.h>, as it should be available on all
1752 BSD_SYSTEM hosts given that we're already calling sysctl in that case.
1753 (list_system_processes) [__OpenBSD__]: Use DARWIN_OS style mib, but
1754 use p_pid member, not kp_proc.pid.
1755
8eb876e2
GM
17562012-07-06 Glenn Morris <rgm@gnu.org>
1757
1758 * Makefile.in (emacs$(EXEEXT)): Don't check for load-path shadows.
1759
38182d90
PE
17602012-07-05 Paul Eggert <eggert@cs.ucla.edu>
1761
1762 More xmalloc and related cleanup.
1763 * alloc.c, bidi.c, buffer.c, buffer.h, bytecode.c, callint.c:
1764 * callproc.c, charset.c, coding.c, composite.c, data.c, dispnew.c:
1765 * doc.c, editfns.c, emacs.c, eval.c, fileio.c, filelock.c, fns.c:
1766 * font.c, fontset.c, frame.c, fringe.c, ftfont.c, ftxfont.c, gmalloc.c:
1767 * gtkutil.c, image.c, keyboard.c, keymap.c, lread.c, macros.c, menu.c:
1768 * nsfns.m, nsfont.m, nsmenu.m, nsterm.m, print.c, process.c, ralloc.c:
1769 * regex.c, region-cache.c, scroll.c, search.c, sound.c, syntax.c:
1770 * sysdep.c, term.c, termcap.c, unexmacosx.c, window.c, xdisp.c:
1771 * xfaces.c, xfns.c, xftfont.c, xgselect.c, xmenu.c, xrdb.c, xselect.c:
1772 * xterm.c:
1773 Omit needless casts involving void * pointers and allocation.
1774 Prefer "P = xmalloc (sizeof *P)" to "P = xmalloc (sizeof (TYPE_OF_P))",
1775 as the former is more robust if P's type is changed.
1776 Prefer xzalloc to xmalloc + memset 0.
1777 Simplify malloc-or-realloc to realloc.
1778 Don't worry about xmalloc returning a null pointer.
1779 Prefer xstrdup to xmalloc + strcpy.
1780 * editfns.c (Fmessage_box): Grow message_text by at least 80 when
1781 growing it.
1782 * keyboard.c (apply_modifiers_uncached): Prefer local array to
1783 alloca of a constant.
1784
6dd5a677
EZ
17852012-07-05 Eli Zaretskii <eliz@gnu.org>
1786
1787 * xdisp.c (display_line): Fix horizontal pixel coordinates when
1788 hscroll is larger than the line width. Fixes long and futile
1789 looping inside extend_face_to_end_of_line (on a TTY) producing
1790 glyphs that are not needed and thrown away.
1791
6b312f0f
DA
17922012-07-05 Dmitry Antipov <dmantipov@yandex.ru>
1793
1794 * marker.c (set_marker_restricted_both): Simplify by using
1795 clip_to_bounds.
1796
f520ef9b
PE
17972012-07-05 Paul Eggert <eggert@cs.ucla.edu>
1798
1799 * editfns.c (region_limit): Simplify by using clip_to_bounds.
1800
383b7c95
JD
18012012-07-05 Jan Djärv <jan.h.d@swipnet.se>
1802
1803 * gtkutil.c (gtk_scrollbar_new, gtk_box_new): Define when HAVE_GTK3 is
1804 not defined (Bug#11768).
1805 (xg_create_frame_widgets): Use gtk_plug_new_for_display (Bug#11768).
1806 (xg_create_frame_widgets, create_dialog, xg_get_file_with_chooser)
1807 (make_widget_for_menu_item, xg_make_tool_item): Use gtk_box_new
1808 followed by gtk_box_set_homogeneous (Bug#11768).
1809 (xg_update_menu_item): Use GTK_IS_BOX (Bug#11768).
090bd7cb
JB
1810 (update_theme_scrollbar_width, xg_create_scroll_bar):
1811 Use gtk_scrollbar_new (Bug#11768).
383b7c95
JD
1812 (xg_event_is_for_scrollbar): Use Gdk Device functions for HAVE_GTK3.
1813 (is_box_type): New function (Bug#11768).
1814 (xg_tool_item_stale_p): Call is_box_type.
5293d758 1815 (xg_initialize): Get settings by calling gtk_settings_get_for_screen
383b7c95
JD
1816 with default display (Bug#11768).
1817
d6e7bf45
EZ
18182012-07-05 Eli Zaretskii <eliz@gnu.org>
1819
1820 * xdisp.c (window_hscroll_limited): New function.
1821 (pos_visible_p, init_iterator): Use it to avoid overflow of pixel
1822 coordinates when window's hscroll is set to insanely large
1823 values. (Bug#11857)
1824
431391ec
JB
18252012-07-05 Juanma Barranquero <lekktu@gmail.com>
1826
1827 * makefile.w32-in ($(BLD)/dired.$(O), $(BLD)/fileio.$(O)): Fix typo.
1828 ($(BLD)/terminal.$(O), $(BLD)/syntax.$(O)): Update dependencies.
1829
23f86fce
DA
18302012-07-05 Dmitry Antipov <dmantipov@yandex.ru>
1831
1832 Cleanup xmalloc.
1833 * lisp.h (xzalloc): New prototype. Omit needless casts.
1834 * alloc.c (xzalloc): New function. Omit needless casts.
1835 * charset.c: Omit needless casts. Convert all calls to
1836 xmalloc with following memset to xzalloc.
1837 * dispnew.c: Likewise.
1838 * fringe.c: Likewise.
1839 * image.c: Likewise.
1840 * sound.c: Likewise.
1841 * term.c: Likewise.
1842 * w32fns.c: Likewise.
1843 * w32font.c: Likewise.
1844 * w32term.c: Likewise.
1845 * xfaces.c: Likewise.
1846 * xfns.c: Likewise.
1847 * xterm.c: Likewise.
1848 * atimer.c: Omit needless casts.
1849 * buffer.c: Likewise.
1850 * callproc.c: Likewise.
1851 * ccl.c: Likewise.
1852 * coding.c: Likewise.
1853 * composite.c: Likewise.
1854 * doc.c: Likewise.
1855 * doprnt.c: Likewise.
1856 * editfns.c: Likewise.
1857 * emacs.c: Likewise.
1858 * eval.c: Likewise.
1859 * filelock.c: Likewise.
1860 * fns.c: Likewise.
1861 * gtkutil.c: Likewise.
1862 * keyboard.c: Likewise.
1863 * lisp.h: Likewise.
1864 * lread.c: Likewise.
1865 * minibuf.c: Likewise.
1866 * msdos.c: Likewise.
1867 * print.c: Likewise.
1868 * process.c: Likewise.
1869 * region-cache.c: Likewise.
1870 * search.c: Likewise.
1871 * sysdep.c: Likewise.
1872 * termcap.c: Likewise.
1873 * terminal.c: Likewise.
1874 * tparam.c: Likewise.
1875 * w16select.c: Likewise.
1876 * w32.c: Likewise.
1877 * w32reg.c: Likewise.
1878 * w32select.c: Likewise.
1879 * w32uniscribe.c: Likewise.
1880 * widget.c: Likewise.
1881 * xdisp.c: Likewise.
1882 * xmenu.c: Likewise.
1883 * xrdb.c: Likewise.
1884 * xselect.c: Likewise.
1885
0497dc44
PE
18862012-07-05 Paul Eggert <eggert@cs.ucla.edu>
1887
1888 * fileio.c (time_error_value): Check the right error number.
1889 Problem reported by Troels Nielsen in
1890 <http://lists.gnu.org/archive/html/emacs-devel/2012-07/msg00095.html>.
1891
356e7178
PE
18922012-07-04 Paul Eggert <eggert@cs.ucla.edu>
1893
4e71fd89
PE
1894 * window.c (set_window_hscroll): Revert the 100000 hscroll limit.
1895 This should be fixed in a better way; see Eli Zaretskii in
1896 <http://lists.gnu.org/archive/html/emacs-devel/2012-07/msg00088.html>.
1897 (HSCROLL_MAX): Remove; this is now internal to set_window_hscroll.
1898
f0941253
PE
1899 * fileio.c (time_error_value): Rename from special_mtime.
1900 The old name's problems were noted by Eli Zaretskii in
1901 <http://lists.gnu.org/archive/html/emacs-devel/2012-07/msg00087.html>.
1902
065c9eb4
PE
1903 * emacs.c (gdb_pvec_type): Change it back to enum pvec_type.
1904 This variable's comment says Emacs needs at least one GDB-visible
1905 symbol of type enum pvec_type, to work around GDB problems.
1906 The symbol's value doesn't matter.
1907
356e7178
PE
1908 * alloc.c (PSEUDOVECTOR_NBYTES): Remove stray ';'
1909 that causes compilation to fail on pre-C99 compilers.
1910
ed9265fc 19112012-07-04 Juanma Barranquero <lekktu@gmail.com>
95f61aa2
JB
1912
1913 * s/ms-w32.h (LISP_FLOAT_TYPE, HAVE_MEMCMP, HAVE_MEMCPY)
1914 (HAVE_MEMMOVE, HAVE_MEMSET): Don't set, obsolete.
1915
3884d954
DA
19162012-07-04 Dmitry Antipov <dmantipov@yandex.ru>
1917
d209e2fb 1918 * buffer.c (init_buffer_once): Fix initialization of
3884d954
DA
1919 headers for buffer_defaults and buffer_local_symbols.
1920 Reported by Juanma Barranquero <lekktu@gmail.com>.
1921
ee28be33
SM
19222012-07-04 Stefan Monnier <monnier@iro.umontreal.ca>
1923
1924 Turn VECTOR_FREE_LIST_FLAG into PVEC_FREE.
1925 * lisp.h (enum pvec_type): Use fewer bits.
1926 (PSEUDOVECTOR_SIZE_BITS): New constant.
1927 (PSEUDOVECTOR_SIZE_MASK, PVEC_TYPE_MASK): Use it.
1928 (XSETPVECTYPESIZE, XSETTYPED_PSEUDOVECTOR, DEFUN): Adapt code to
1929 change in pvec_type.
1930 (PSEUDOVECTOR_TYPEP): New macro.
1931 (TYPED_PSEUDOVECTORP): Use it.
1932 * fns.c (internal_equal): Adapt code to extract pvectype.
1933 * emacs.c (gdb_pvec_type): Update type.
1934 * alloc.c (PSEUDOVECTOR_NBYTES): New macro.
1935 (VECTOR_FREE_LIST_SIZE_MASK): Remove (=> PSEUDOVECTOR_SIZE_MASK).
1936 (VECTOR_FREE_LIST_FLAG): Remove (=> PVEC_FREE).
1937 (SETUP_ON_FREE_LIST): Use XSETPVECTYPESIZE.
1938 (sweep_vectors): Use it. Use local var `total_bytes' instead of
1939 abusing vector->header.next.nbytes.
1940 (live_vector_p): Use PVEC_TYPE.
1941 (mark_object): Adapt code to extract pvectype. Use switch.
1942
c7f2cd7f
PE
19432012-07-04 Paul Eggert <eggert@cs.ucla.edu>
1944
1945 * doprnt.c (doprnt): Don't assume string length fits in 'int'.
1946 Tighten new eassert a bit.
1947
8ce70ed2
DA
19482012-07-04 Dmitry Antipov <dmantipov@yandex.ru>
1949
1950 Fix compilation with --enable-gcc-warnings and -O1
1951 optimization level.
1952 * doprnt.c (doprnt): Change type of tem to int, initialize
1953 to avoid compiler warning. Add eassert.
1954 * search.c (simple_search): Initialize match_byte to avoid
1955 compiler warning. Add eassert.
1956
dea7f1e5
PE
19572012-07-04 Paul Eggert <eggert@cs.ucla.edu>
1958
24a212eb
PE
1959 Avoid weird behavior with large horizontal scrolls.
1960 Without this change, for example, large hscroll values would
1961 mess up Emacs's display on Fedora 15 x86, presumably due to
1962 overflows in int calculations in the display code.
1963 Also, if buffers had long lines, Emacs would freeze.
1964 * window.c (HSCROLL_MAX): Reduce to 100000, and make it visible to GDB.
1965 (set_window_hscroll): New function, containing the old guts of
1966 Fset_window_hscroll. Return the clipped value.
1967 (Fset_window_hscroll, Fscroll_left, Fscroll_right): Use it.
1968 This avoids the need to check against PTRDIFF_MAX.
1969
dea7f1e5
PE
1970 * buffer.c (Fgenerate_new_buffer_name): Fix sprintf format mismatch.
1971
76046526
DA
19722012-07-04 Dmitry Antipov <dmantipov@yandex.ru>
1973
1974 * buffer.c (Fgenerate_new_buffer_name): Fix type mismatch.
1975
39adff0d
PE
19762012-07-04 Paul Eggert <eggert@cs.ucla.edu>
1977
63807d47
PE
1978 * regex.c: Suppress GCC warning on RHEL 6. (Bug#11207)
1979 Conditionalize the pragmas on GCC 4.5 or later, not GCC 4.3 or later,
1980 since GCC 4.4.6 issues a bogus warning for them.
1981
39adff0d
PE
1982 Fix bugs in file timestamp newness comparisons.
1983 * fileio.c (Ffile_newer_than_file_p):
1984 * lread.c (Fload): Use full timestamp resolution of files,
1985 not just the 1-second resolution, so that files that are only
1986 slightly newer still count as newer.
1987 * fileio.c (Ffile_newer_than_file_p): Don't assume file
1988 timestamps fit in 'int'; this fixes a Y2038 bug on most hosts.
1989
dbeed9a6
PE
19902012-07-03 Paul Eggert <eggert@cs.ucla.edu>
1991
1992 * fileio.c: Improve handling of file time marker. (Bug#11852)
1993 (special_mtime): New function.
1994 (Finsert_file_contents, Fverify_visited_file_modtime):
1995 Use it to set special mtime values consistently.
1996
636334d6
AS
19972012-07-03 Andreas Schwab <schwab@linux-m68k.org>
1998
1999 * fileio.c (Finsert_file_contents): Properly handle st_mtime
2000 marker for non-existing file. (Bug#11852)
2001
e2017fe2
GM
20022012-07-03 Glenn Morris <rgm@gnu.org>
2003
2004 * lisp.h (Fread_file_name): Restore EXFUN (it's not a normal DEFUN
2005 and did not make it into globals.h).
2006
404dbd37
TT
20072012-07-03 Tom Tromey <tromey@redhat.com>
2008
2009 * window.c (Fset_window_margins, Fset_window_fringes)
2010 (Fset_window_scroll_bars, Fset_window_vscroll): No longer static.
2011 * textprop.c (Fprevious_property_change): No longer static.
2012 * syntax.c (Fsyntax_table_p): No longer static.
2013 * process.c (Fget_process, Fprocess_datagram_address): No longer
2014 static.
2015 * keymap.c (Flookup_key, Fcopy_keymap): No longer static.
2016 * keyboard.c (Fcommand_execute): No longer static.
2017 Remove EXFUN.
2018 * insdel.c (Fcombine_after_change_execute): No longer static.
2019 * image.c (Finit_image_library): No longer static.
2020 * fileio.c (Fmake_symbolic_link): No longer static.
2021 * eval.c (Ffetch_bytecode): No longer static.
2022 * editfns.c (Fuser_full_name): No longer static.
d209e2fb
JB
2023 * doc.c (Fdocumentation_property, Fsnarf_documentation):
2024 No longer static.
404dbd37
TT
2025 * buffer.c (Fset_buffer_major_mode, Fdelete_overlay): No longer
2026 static.
2027 * dired.c (Ffile_attributes): No longer static.
2028 * composite.c (Fcomposition_get_gstring): No longer static.
2029 * callproc.c (Fgetenv_internal): No longer static.
2030
2031 * ccl.h: Remove EXFUNs.
2032 * buffer.h: Remove EXFUNs.
2033 * dispextern.h: Remove EXFUNs.
2034 * intervals.h: Remove EXFUNs.
2035 * fontset.h: Remove EXFUN.
2036 * font.h: Remove EXFUNs.
2037 * dosfns.c (system_process_attributes): Remove EXFUN.
2038 * keymap.h: Remove EXFUNs.
2039 * lisp.h: Remove EXFUNs.
2040 * w32term.h: Remove EXFUNs.
2041 * window.h: Remove EXFUNs.
2042 * xsettings.h: Remove EXFUN.
2043 * xterm.h: Remove EXFUN.
2044
8e4fd1e1
GM
20452012-07-03 Glenn Morris <rgm@gnu.org>
2046
2047 * lisp.h (Frandom): Make it visible to C.
2048 * buffer.c (Fgenerate_new_buffer_name): Speed up finding a new
2049 buffer for invisible buffers. (Bug#1229)
2050
ca95b3eb
DA
20512012-07-03 Dmitry Antipov <dmantipov@yandex.ru>
2052
2053 Fix block vector allocation code to allow VECTOR_BLOCK_SIZE
2054 values which aren't power of 2.
2055 * alloc.c (VECTOR_FREE_LIST_SIZE_MASK): New macro. Verify
2056 it's value and the value of VECTOR_BLOCK_SIZE. Adjust users
2057 accordingly.
2058
7555c33f
SM
20592012-07-03 Stefan Monnier <monnier@iro.umontreal.ca>
2060
2061 * lisp.h (Lisp_Misc, Lisp_Fwd): Move around to group better.
2062
2063 * alloc.c (mark_object): Revert part of last patch to use `switch'.
2064
d12e8f5a
DA
20652012-07-03 Dmitry Antipov <dmantipov@yandex.ru>
2066
2067 * alloc.c (allocate_vector_block): Remove redundant
2068 calls to mallopt if DOUG_LEA_MALLOC is defined.
2069 (allocate_vectorlike): If DOUG_LEA_MALLOC is defined,
2070 avoid calls to mallopt if zero_vector is returned.
2071
296094c3
DA
20722012-07-03 Dmitry Antipov <dmantipov@yandex.ru>
2073
2074 * alloc.c (check_string_bytes): If GC_CHECK_STRING_BYTES
2075 is enabled, avoid dereferencing NULL current_sblock if
2076 running undumped.
2077
36429c89
DA
20782012-07-03 Dmitry Antipov <dmantipov@yandex.ru>
2079
2080 Cleanup basic buffer management.
2081 * buffer.h (struct buffer): Change layout to use generic vector
2082 marking code. Fix some comments. Change type of 'clip_changed'
2083 to bitfield. Remove unused #ifndef old.
2084 (FIRST_FIELD_PER_BUFFER, LAST_FIELD_PER_BUFFER): Remove.
2085 (GET_OVERLAYS_AT): Fix indentation.
2086 (for_each_per_buffer_object_at): New macro.
2087 * buffer.c (clone_per_buffer_values, reset_buffer_local_variables)
2088 (Fbuffer_local_variables): Use it.
2089 (init_buffer_once, syms_of_buffer): Remove unused #ifndef old.
2090 * alloc.c (allocate_buffer): Adjust to match new layout of
2091 struct buffer. Fix comment.
2092 (mark_overlay): New function.
2093 (mark_buffer): Use it. Use mark_vectorlike to mark normal
2094 Lisp area of struct buffer.
2095 (mark_object): Use it. Adjust marking of misc objects
2096 and related comments.
2097
3b3e4cac
PE
20982012-07-02 Paul Eggert <eggert@cs.ucla.edu>
2099
2100 * alloc.c (mark_object): Remove "#ifdef GC_CHECK_MARKED_OBJECTS"
2101 wrapper that is not needed because the wrapped code is a no-op (zero
2102 machine instructions) when GC_CHECK_MARKED_OBJECTS is not defined.
2103 This avoids a -Wunused-macros diagnostic with GCC 4.7.1 x86-64.
2104
cf5c0175
DA
21052012-07-02 Dmitry Antipov <dmantipov@yandex.ru>
2106
2107 * alloc.c (mark_buffer): Simplify. Remove prototype.
2108 (mark_object): Add comment. Reorganize marking of vector-like
faf611c7 2109 objects. Use CHECK_LIVE for all vector-like objects except buffers
cf5c0175
DA
2110 and subroutines when GC_CHECK_MARKED_OBJECTS is defined. Avoid
2111 redundant calls to mark_vectorlike for bool vectors.
2112
ca26824c
GM
21132012-06-30 Glenn Morris <rgm@gnu.org>
2114
2e4c5312
GM
2115 * nsterm.m (ns_init_paths): Ignore site-lisp if --no-site-lisp.
2116
ca26824c
GM
2117 * epaths.in (PATH_SITELOADSEARCH): New.
2118 * lread.c (init_lread): Use PATH_SITELOADSEARCH.
2119 This is rather than relying on --enable-locallisppath elements
2120 having "site-lisp" in their names. (Bug#10208#25, 11658)
2121
0d23c240
EZ
21222012-06-30 Eli Zaretskii <eliz@gnu.org>
2123
c9240d7a
EZ
2124 * w32proc.c (sys_select): Accept and ignore one more argument.
2125
2126 * w32.c (emacs_gnutls_pull): Call select with one more argument.
2127
0d23c240 2128 * sysselect.h [DOS_NT]: Don't include sys/select.h.
9ff8f76b 2129 (pselect) [!MS_DOS]: Redirect to sys_select.
0d23c240
EZ
2130
2131 * sysdep.c: Don't include dos.h and dosfns.h.
2132
2133 * process.c (sys_select):
2134 * msdos.c (sys_select): Accept one more argument and ignore it.
2135
2136 * msdos.c (event_timestamp, sys_select): Use gnulib's gettime;
2137 adapt data types and code to that.
2138
2139 * dosfns.c:
2140 * msdos.c (gettime, settime): Define away the prototypes in dos.h,
2141 which clashes with the gnulib function of the same name.
2142
af5a5a98
AS
21432012-06-30 Andreas Schwab <schwab@linux-m68k.org>
2144
c5e4379c
AS
2145 * font.c (font_style_to_value, font_style_symbolic)
2146 (font_prop_validate_style): Add type checks for values in
2147 font_style_table.
2148
af5a5a98
AS
2149 * lisp.h (CHECK_RANGED_INTEGER): Make value to check the first
2150 argument.
2151 * character.c, charset.c, menu.c, process.c, window.c: Adjust all
2152 uses.
2153
8d38f461
EZ
21542012-06-29 Eli Zaretskii <eliz@gnu.org>
2155
2e5a6631
EZ
2156 * xdisp.c (try_window_id): Undo last change.
2157
8d38f461
EZ
2158 * w32.c (getwd): Adjust commentary about startup_dir.
2159 (init_environment): Always call sys_access, even in non-MSVC
2160 builds. Don't chdir to the directory of the Emacs executable.
2161 This undoes code from 1997 which was justified by the need to
2162 "avoid conflicts when removing and renaming directories". But its
2163 downside was that every relative file name was being interpreted
2164 relative to the directory of the Emacs executable, which can never
2165 be TRT. In particular, it broke sys_access when called with
2166 relative file names.
2167 (sys_access): Map GetLastError to errno.
2168
2af3565e
DA
21692012-06-29 Dmitry Antipov <dmantipov@yandex.ru>
2170
2171 * window.h (struct window): Change type of 'fringes_outside_margins'
2172 to bitfield. Fix comment. Adjust users accordingly.
cf5c0175 2173 (struct window): Change type of 'window_end_bytepos' to ptrdiff_t.
2af3565e
DA
2174 Adjust comment.
2175 * xdisp.c (try_window_id): Change type of 'first_vpos' and 'vpos'
2176 to ptrdiff_t.
2177
c8d3a25c 21782012-06-29 Andreas Schwab <schwab@linux-m68k.org>
57570cd3 2179
c8d3a25c
GM
2180 * gnutls.c (emacs_gnutls_handshake):
2181 Add QUIT to make the loop interruptible.
57570cd3 2182
c8d3a25c 21832012-06-29 Glenn Morris <rgm@gnu.org>
d01fd55f 2184
c8d3a25c
GM
2185 * charset.c (init_charset): Make lack of etc/charsets fatal.
2186
3e984ee8
DA
21872012-06-29 Dmitry Antipov <dmantipov@yandex.ru>
2188
2189 * editfns.c (region_limit): Fix type mismatch.
2190
ef884f23
DA
21912012-06-29 Dmitry Antipov <dmantipov@yandex.ru>
2192
2193 * nsfns.m: Fix GLYPH_DEBUG usage assuming that it may be
2194 undefined. Convert from xassert to eassert.
2195 * nsmenu.m: Convert from xassert to eassert.
2196 * nsterm.m: Likewise.
2197
7d7e0027
SM
21982012-06-28 Stefan Monnier <monnier@iro.umontreal.ca>
2199
2200 * editfns.c (region_limit): Clip to narrowing (bug#11770).
2201
aa754e6a
PE
22022012-06-28 Paul Eggert <eggert@cs.ucla.edu>
2203
2204 Avoid integer overflow on scroll-left and scroll-right.
2205 * window.c (HSCROLL_MAX): New macro.
2206 (Fscroll_left, Fscroll_right): Avoid undefined behavior on integer
2207 overflow when requested scroll falls outside ptrdiff_t range.
2208
80b00b08
DA
22092012-06-28 Dmitry Antipov <dmantipov@yandex.ru>
2210
2211 * window.h (struct window): Change type of 'hscroll',
2212 'min_hscroll' and 'last_point' from Lisp_Object to ptrdiff_t,
2213 'last_modified' and 'last_overlay_modified' to EMACS_INT.
2214 Adjust users accordingly.
2215 * xdisp.c (try_cursor_movement): Replace type check with eassert.
2216 * window.c (Fscroll_left, Fscroll_right): Change type of 'hscroll'
2217 from EMACS_INT to ptrdiff_t.
2218 (make_window): Omit redundant initialization.
2219
62b2bcf6
JB
22202012-06-28 Juanma Barranquero <lekktu@gmail.com>
2221
2222 * makefile.w32-in ($(BLD)/regex.$(O)): Update dependencies.
2223
45942c7d
DA
22242012-06-28 Dmitry Antipov <dmantipov@yandex.ru>
2225
2226 * window.h (struct window): Change type of 'use_time' and
2227 'sequence_number' from Lisp_Object to int.
2228 * frame.c (make_frame): Adjust users accordingly.
2229 * print.c (print_object): Likewise.
2230 * window.c (select_window, Fwindow_use_time, make_parent_window)
2231 (make_window): Likewise.
2232
e509cfa6
DA
22332012-06-28 Dmitry Antipov <dmantipov@yandex.ru>
2234
2235 * dispextern.h (GLYPH_DEBUG): Now defined in config.h if
2236 enabled with --enable-checking=[all,glyphs] configure option.
2237 Fix GLYPH_DEBUG usage assuming that it may be undefined,
2238 adjust comments accordingly.
2239 * dispnew.c: Fix GLYPH_DEBUG usage assuming that it may be
2240 undefined, adjust comments accordingly.
2241 * image.c: Likewise.
2242 * scroll.c: Likewise.
2243 * w32fns.c: Likewise.
2244 * w32term.c: Likewise.
2245 * xdisp.c: Likewise.
2246 * xfaces.c: Likewise.
2247 * xfns.c: Likewise.
2248 * xterm.c: Likewise.
2249
a54e2c05
DA
22502012-06-28 Dmitry Antipov <dmantipov@yandex.ru>
2251
2252 Generalize run-time debugging checks.
2253 * dispextern.h (XASSERTS): Remove.
2254 * fontset.c (xassert): Remove.
2255 Convert from xassert to eassert.
2256 * alloc.c: Convert from xassert to eassert.
2257 * bidi.c: Likewise.
2258 * dispnew.c: Likewise.
2259 * fns.c: Likewise.
2260 * fringe.c: Likewise.
2261 * ftfont.c: Likewise.
2262 * gtkutil.c: Likewise.
2263 * image.c: Likewise.
2264 * keyboard.c: Likewise.
2265 * menu.c: Likewise.
2266 * process.c: Likewise.
2267 * scroll.c: Likewise.
2268 * sound.c: Likewise.
2269 * term.c: Likewise.
2270 * w32console.c: Likewise.
2271 * w32fns.c: Likewise.
2272 * w32term.c: Likewise.
2273 * window.c: Likewise.
2274 * xdisp.c: Likewise.
2275 * xfaces.c: Likewise.
2276 * xfns.c: Likewise.
2277 * xselect.c: Likewise.
2278 * xterm.c: Likewise.
2279
1ec4b7b2
SM
22802012-06-27 Stefan Monnier <monnier@iro.umontreal.ca>
2281
2282 * fns.c (maybe_resize_hash_table): Output message when growing the
2283 purify-hashtable.
2284
2014308a
DA
22852012-06-27 Dmitry Antipov <dmantipov@yandex.ru>
2286
2287 * alloc.c (allocate_string_data): Remove dead code.
2288 * xsettings.c (XSETTINGS_FONT_NAME): Move under HAVE_XFT to
2289 avoid GCC warning about unused macro.
2290
246155eb
DA
22912012-06-27 Dmitry Antipov <dmantipov@yandex.ru>
2292
2293 * alloc.c (allocate_string): Omit intervals initialization.
2294 * alloc.c (make_uninit_multibyte_string): Initialize intervals
2295 as in make_pure_string and make_pure_c_string.
2296
43184b7b
DA
22972012-06-27 Dmitry Antipov <dmantipov@yandex.ru>
2298
d209e2fb 2299 * alloc.c (allocate_string): Fix last change.
43184b7b 2300
3fe6dd74
DA
23012012-06-27 Dmitry Antipov <dmantipov@yandex.ru>
2302
d209e2fb 2303 * alloc.c (allocate_string): Remove two redundant calls
3fe6dd74
DA
2304 to memset, add explicit initialization where appropriate.
2305
1ba6038a
GM
23062012-06-27 Glenn Morris <rgm@gnu.org>
2307
2308 * lisp.mk (lisp): Remove paths.elc.
2309
c89926a5
CY
23102012-06-27 Chong Yidong <cyd@gnu.org>
2311
2312 * doc.c (Fsubstitute_command_keys): Fix punctuation.
2313
ed6b3510
JW
23142012-06-26 John Wiegley <johnw@newartisans.com>
2315
1ec4b7b2 2316 * unexmacosx.c (copy_data_segment): Add two section names used
157e99e4
JW
2317 on Mac OS X Lion: __mod_init_func and __mod_term_func.
2318
ed6b3510
JW
2319 * alloc.c (mark_memory): Do not check with -faddress-sanitizer
2320 when building with Clang.
2321
8edd4a2b
SM
23222012-06-26 Stefan Monnier <monnier@iro.umontreal.ca>
2323
2324 * eval.c (Fapply): Allow calling it with a single argument.
2325
f6f62d1b
EZ
23262012-06-26 Eli Zaretskii <eliz@gnu.org>
2327
2328 * s/ms-w32.h (strcasecmp, strncasecmp) [_MSC_VER]: Redirect to
2329 _stricmp and _strnicmp.
2330 (HAVE_STRCASECMP, HAVE_STRNCASECMP): Define to 1.
2331
62efea5e
DA
23322012-06-26 Dmitry Antipov <dmantipov@yandex.ru>
2333
2334 * alloc.c (allocate_window): Zero out non-Lisp part of newly
2335 allocated window.
2336 (allocate_process): Likewise for new process.
8edd4a2b 2337 (allocate_terminal): Change to use offsetof.
62efea5e
DA
2338 (allocate_frame): Likewise.
2339 * frame.c (make_frame): Omit redundant initialization.
2340 * window.c (make_parent_window): Use memset.
2341 (make_window): Omit redundant initialization.
2342 * process.c (make_process): Omit redundant initialization.
2343 * terminal.c (create_terminal): Likewise.
2344
42997f4d
DA
23452012-06-26 Dmitry Antipov <dmantipov@yandex.ru>
2346
2347 * term.c (delete_tty): Remove redundant call to memset.
2348
1130ecfc
DA
23492012-06-26 Dmitry Antipov <dmantipov@yandex.ru>
2350
2351 * alloc.c: Remove build_string.
2352 * lisp.h: Define build_string as static inline. This provides
2353 a better opportunity to optimize away calls to strlen when the
2354 function is called with compile-time constant argument.
2355 * image.c (imagemagick_error): Convert to build_string.
2356 * w32proc.c (sys_spawnve): Likewise.
2357 * xterm.c (x_term_init): Likewise.
2358
cf38a720
PE
23592012-06-26 Paul Eggert <eggert@cs.ucla.edu>
2360
99027bdd
PE
2361 Use sprintf return value instead of invoking strlen on result.
2362 In the old days this wasn't portable, since some sprintf
2363 implementations returned char *. But they died out years ago and
2364 Emacs already assumes sprintf returns int.
2365 Similarly for float_to_string.
2366 This patch speeds up (number-to-string 1000) by 3% on Fedora 15 x86-64.
2367 * ccl.c (ccl_driver):
2368 * character.c (string_escape_byte8):
2369 * data.c (Fnumber_to_string):
2370 * doprnt.c (doprnt):
2371 * print.c (print_object):
2372 * xdisp.c (message_dolog):
2373 * xfns.c (syms_of_xfns):
2374 Use sprintf or float_to_string result to avoid need to call strlen.
2375 * data.c (Fnumber_to_string):
2376 Use make_unibyte_string, since the string must be ASCII.
2377 * lisp.h, print.c (float_to_string): Now returns int length.
2378 * term.c (produce_glyphless_glyph):
2379 Use sprintf result rather than recomputing it.
2380
cf38a720
PE
2381 Clean out last vestiges of the old HAVE_CONFIG_H stuff.
2382 * Makefile.in (ALL_CFLAGS):
2383 * makefile.w32-in (LOCAL_FLAGS): Remove -DHAVE_CONFIG_H.
2384 * gmalloc.c, regex.c: Include <config.h> unconditionally.
2385
3511c784
DA
23862012-06-25 Dmitry Antipov <dmantipov@yandex.ru>
2387
0a08eb21 2388 * dispextern.h (xstrcasecmp): Define to library function
3511c784
DA
2389 strcasecmp if available.
2390 * xfaces.c: Do not use xstrcasecmp if strcasecmp is available.
2391
fb7da12e
AS
23922012-06-25 Andreas Schwab <schwab@linux-m68k.org>
2393
2394 * keyboard.c (menu_bar_items, menu_bar_item, read_key_sequence):
2395 Avoid comma operator.
2396 * menu.c (push_submenu_start, push_submenu_end)
2397 (push_left_right_boundary, push_menu_pane): Likewise.
2398 * msdos.c (dos_rawgetc): Likewise.
2399
afa2ffd8
DA
24002012-06-25 Dmitry Antipov <dmantipov@yandex.ru>
2401
2402 * xfns.c (xic_create_fontsetname): Remove redundant calls
2403 to memset.
2404
b3b4476b
PE
24052012-06-25 Paul Eggert <eggert@cs.ucla.edu>
2406
4495ff38
PE
2407 * gtkutil.c (get_utf8_string): Remove redundant assignment.
2408 sprintf already null-terminates its output.
2409
b3b4476b
PE
2410 * xfns.c (x_window): Remove redundant cast.
2411
b00876c9
DA
24122012-06-25 Dmitry Antipov <dmantipov@yandex.ru>
2413
2414 * xmenu.c (xmenu_show, xdialog_show): Explicit cast from
2415 `const char *' to `char *' to avoid compiler warning.
2416
d188e26b
PE
24172012-06-24 Paul Eggert <eggert@cs.ucla.edu>
2418
885d1d74
PE
2419 * xterm.c (x_term_init): Build proper-sized _XSETTINGS_Snnn string
2420 instead of truncating it to 63 (admittedly a generous limit).
2421
d188e26b
PE
2422 * process.c: Fix spelling and caps in comments.
2423
e2f560b1
DN
24242012-06-24 Dan Nicolaescu <dann@ics.uci.edu>
2425
e86db54b 2426 * emacs.c (setpgrp): Remove definition, unused.
e2f560b1
DN
2427 * sysdep.c (setpgrp): Remove definition, not used in this file.
2428
7583a3a1
JB
24292012-06-24 Juanma Barranquero <lekktu@gmail.com>
2430
2431 * makefile.w32-in: Update dependencies.
2432
696056c2
EZ
24332012-06-24 Eli Zaretskii <eliz@gnu.org>
2434
2435 * makefile.w32-in (TIMESPEC_H): Remove nt/inc/sys/time.h.
2436 (SYSTIME_H): Add nt/inc/sys/time.h.
2437
2438 * systime.h [WINDOWSNT]: Include sys/time.h.
2439
2440 * s/ms-w32.h (struct timespec): Definition moved from
2441 nt/inc/sys/time.h. Suggested by Paul Eggert <eggert@cs.ucla.edu>.
2442
845ca893
PE
24432012-06-24 Paul Eggert <eggert@cs.ucla.edu>
2444
2445 Switch from NO_RETURN to C11's _Noreturn (Bug#11750).
2446 * buffer.h (buffer_slot_type_mismatch):
2447 * data.c (arith_error) [!FORWARD_SIGNAL_TO_MAIN_THREAD]:
2448 * eval.c (unwind_to_catch):
2449 * image.c (my_png_error, my_error_exit):
2450 * keyboard.c (quit_throw_to_read_char, user_error)
2451 (Fexit_recursive_edit, Fabort_recursive_edit):
2452 * lisp.h (die, args_out_of_range, args_out_of_range_3)
2453 (wrong_type_argument, buffer_overflow, __executable_start)
2454 (memory_full, buffer_memory_full, string_overflow, Fthrow)
2455 (xsignal, xsignal0, xsignal1, xsignal2, xsignal3, signal_error)
2456 (error, verror, nsberror, report_file_error, Ftop_level, Fkill_emacs)
2457 (fatal):
2458 (child_setup) [!DOS_NT]:
2459 * lread.c (end_of_file_error, invalid_syntax):
2460 * process.c (send_process_trap) [!FORWARD_SIGNAL_TO_MAIN_THREAD]:
2461 * puresize.h (pure_write_error):
2462 * search.c (matcher_overflow):
2463 * sound.c (sound_perror, alsa_sound_perror):
2464 * sysdep.c, syssignal.h (croak):
2465 * term.c (maybe_fatal, vfatal):
2466 * textprop.c (text_read_only):
2467 * undo.c (user_error):
2468 * unexmacosx.c (unexec_error):
2469 * xterm.c (x_ins_del_lines, x_delete_glyphs):
2470 Use _Noreturn rather than NO_RETURN.
2471 No need for separate decl merely because of _Noreturn.
2472 * sound.c (sound_warning, parse_sound):
2473 Remove unnecessary forward decls.
2474
f1dd8073
PE
24752012-06-24 Paul Eggert <eggert@cs.ucla.edu>
2476
2477 Fix bug when time_t is unsigned and as wide as intmax_t (Bug#9000).
2478 * lisp.h (WAIT_READING_MAX): New macro.
2479 * dispnew.c (Fsleep_for, sit_for):
2480 * keyboard.c (kbd_buffer_get_event):
2481 * process.c (Faccept_process_output):
2482 Use it to avoid bogus compiler warnings with obsolescent GCC versions.
2483 This improves on the previous patch, which introduced a bug
2484 when time_t is unsigned and as wide as intmax_t.
2485 See <http://bugs.gnu.org/9000#51>.
2486
b82c1755
EZ
24872012-06-23 Eli Zaretskii <eliz@gnu.org>
2488
2489 * dispnew.c (sit_for, Fsleep_for):
2490 * keyboard.c (kbd_buffer_get_event):
2491 * process.c (Faccept_process_output): Avoid compiler warnings when
2492 comparing a 32-bit time_t with a 64-bit INTMAX_MAX.
2493
ca300656
JB
24942012-06-23 Juanma Barranquero <lekktu@gmail.com>
2495
049ec95b
JB
2496 * makefile.w32-in: Update dependencies.
2497
ca300656
JB
2498 * w32.c (ltime): Add return type and declare static.
2499 (w32_get_internal_run_time): Remove usused variable `time_100ns'.
2500
db7b8d06
PE
25012012-06-23 Paul Eggert <eggert@cs.ucla.edu>
2502
2503 * sysdep.c [__FreeBSD__]: Fix more recently-introduced typos.
2504 Privately reported by Herbert J. Skuhra.
2505 (make_lisp_timeval) [__FreeBSD__]: Rename from TIMELIST.
2506 All uses changed.
2507 (system_process_attributes) [__FreeBSD__]: Invoke make_lisp_time,
2508 not make_lisp_timeval, when the argument is of type EMACS_TIME.
2509
0bd8297f
EZ
25102012-06-23 Eli Zaretskii <eliz@gnu.org>
2511
96512555
EZ
2512 * w32proc.c (Fw32_get_locale_info): Fix an off-by-one error in
2513 last argument of make_unibyte_string.
2514
0bd8297f
EZ
2515 * keyboard.c (kbd_buffer_get_event): Include the codepage and the
2516 language ID in the event parameters.
2517
2518 * w32term.c (w32_read_socket): Put the new keyboard codepage into
2519 event.code, not the obscure "character set ID".
2520
63def6b6
CY
25212012-06-23 Chong Yidong <cyd@gnu.org>
2522
2523 * xmenu.c (x_menu_wait_for_event): Adapt GTK3 to new xg_select.
2524
e8a02204
EZ
25252012-06-23 Eli Zaretskii <eliz@gnu.org>
2526
388cdec0
EZ
2527 Fix the MS-Windows build broken by 2012-06-22T21:17:42Z!eggert@cs.ucla.edu.
2528 * w32.c (fdutimens): New function.
2529
2530 * w32proc.c (sys_select): Adapt to change in the EMACS_TIME type.
2531
2532 * s/ms-w32.h (pselect): Redirect to sys_select.
2533
2534 * sysselect.h [WINDOWSNT]: Don't include sys/select.h.
2535
e8a02204
EZ
2536 * ralloc.c (r_alloc_inhibit_buffer_relocation): Fix stupid thinko
2537 in the logic of incrementing and decrementing the value of
2538 use_relocatable_buffers.
2539
d054f3fb
PE
25402012-06-23 Paul Eggert <eggert@cs.ucla.edu>
2541
2542 * sysdep.c [__FreeBSD__]: Fix recently-introduced typos.
2543 Privately reported by Herbert J. Skuhra.
2544 [__FreeBSD__]: Remove "*/" typo after "#include".
2545 (timeval_to_EMACS_TIME) [__FreeBSD__]: New static function.
2546 (TIMEVAL) [__FreeBSD__]: Now a static function rather than a macro.
2547 (TIMEVAL, system_process_attributes) [__FreeBSD__]:
2548 Don't assume EMACS_TIME and struct timeval are the same type.
2549
d35af63c
PE
25502012-06-22 Paul Eggert <eggert@cs.ucla.edu>
2551
2552 Support higher-resolution time stamps (Bug#9000).
2553 The time stamps are only nanosecond-resolution at the C level,
2554 since that's the best that any real-world system supports now.
2555 But they are picosecond-resolution at the Lisp level, as that's
2556 easy, and leaves room for future OS improvements.
2557
2558 * Makefile.in (LIB_CLOCK_GETTIME): New macro.
2559 (LIBES): Use it.
2560
2561 * alloc.c (Fgarbage_collect): Port to higher-res time stamps.
2562 Don't get current time unless it's needed.
2563
2564 * atimer.c: Include <sys/time.h> unconditionally, since gnulib
2565 now provides it if it's absent.
2566 (start_atimer): Port to higher-res time stamps.
2567 Check for time stamp overflow. Don't get current time more
2568 often than is needed.
2569
2570 * buffer.h (struct buffer): Buffer modtime now has high resolution.
2571 Include systime.h, not time.h.
2572 (NONEXISTENT_MODTIME_NSECS, UNKNOWN_MODTIME_NSECS): New macros.
2573
2574 * dired.c: Include stat-time.h.
2575 (Ffile-attributes): File times now have higher resolution.
2576
2577 * dispextern.h [HAVE_WINDOW_SYSTEM]: Include systime.h.
2578 (struct image): Timestamp now has higher resolution.
2579
2580 * dispnew.c (PERIODIC_PREEMPTION_CHECKING): Remove, as Emacs always
2581 has at least microseconds now. All uses removed.
2582 (update_frame, update_single_window, update_window, update_frame_1)
2583 (Fsleep_for, sit_for): Port to higher-resolution time stamps.
2584
2585 * editfns.c (time_overflow): Now extern.
2586 (Fcurrent_time, Fget_internal_run_time, make_time, lisp_time_argument)
2587 (float-time, Fformat_time_string, Fcurrent_time_string)
2588 (Fcurrent_time_zone): Accept and generate higher-resolution
2589 time stamps.
2590 (make_time_tail, make_lisp_time, dissassemble_lisp_time)
2591 (decode_time_components, lisp_seconds_argument): New functions.
2592 (make_time): Now static.
2593 (lisp_time_argument): Now returns EMACS_TIME. New arg ppsec.
2594 Report an error if the time is invalid, rather than having the caller
2595 do that.
2596
2597 * fileio.c: Include <stat-time.h>
2598 (Fcopy_file): Copy higher-resolution time stamps.
2599 Prefer to set the time stamp via a file descriptor if that works.
2600 (Fset_file_times, Finsert_file_contents, Fwrite_region)
2601 (Fverify_visited_file_modtime, Fclear_visited_file_modtime)
2602 (Fvisited_file_modtime, Fset_visited_file_modtime):
2603 Support higher-resolution time stamps.
2604
2605 * fns.c (Frandom): Use nanoseconds, not microseconds, for seed.
2606
2607 * gtkutil.c (xg_maybe_add_timer): Port to higher-res time stamps.
2608
2609 * image.c (prepare_image_for_display, clear_image_cache)
2610 (lookup_image): Port to higer-resolution time stamps.
2611
2612 * keyboard.c (start_polling, bind_polling_period):
2613 Check for time stamp overflow.
2614 (read_char, kbd_buffer_get_event, timer_start_idle)
2615 (timer_stop_idle, timer_resume_idle, timer_check_2, timer_check)
2616 (Fcurrent_idle_time, init_keyboard, set_waiting_for_input):
2617 Port to higher-resolution time stamps. Do not assume time_t is signed.
2618 (decode_timer): New function. Timers are now vectors of length 9,
2619 not 8, to accommodate the picosecond component.
2620 (timer_check_2): Use it.
2621
2622 * nsterm.m (select_timeout, timeval_subtract): Remove.
2623 (ns_timeout): Use Emacs's facilities for time stamp arithmetic,
2624 as they're a bit more accurate and handle overflow better.
2625 (ns_select): Change prototype to be compatible with pselect.
2626 (ns_select, ns_term_shutdown): Port to ns-resolution time stamps.
2627 * nsterm.h (ns_select): Adjust prototype.
2628
2629 * msdos.c (EMACS_TIME_ZERO_OR_NEG_P): Remove, as it assumes
2630 us-resolution time stamps.
2631 (sys_select): Use the new EMACS_TIME_SIGN macro instead.
2632
2633 * lread.c (read_filtered_event): Port to ns-resolution time stamps.
2634
2635 * lisp.h (time_overflow): New decl.
2636 (wait_reading_process_output): First arg is now intmax_t, not int,
2637 to accommodate larger waits.
2638
2639 * process.h (struct Lisp_Process.read_output_delay):
2640 Now counts nanoseconds, not microseconds.
2641 * process.c (ADAPTIVE_READ_BUFFERING): Don't worry about
2642 EMACS_HAS_USECS.
2643 (READ_OUTPUT_DELAY_INCREMENT, Faccept_process_output)
2644 (wait_reading_process_output):
2645 Port to ns-resolution time stamps.
2646 (Faccept_process_output, wait_reading_process_output):
2647 Check for time stamp overflow. Do not assume time_t is signed.
2648 (select_wrapper): Remove; we now use pselect.
2649 (Fprocess_attributes): Now generates ns-resolution time stamps.
2650
2651 * sysdep.c: Include utimens.h. Don't include utime.h
2652 or worry about struct utimbuf; gnulib does that for us now.
2653 (gettimeofday): Remove; gnulib provides a substitute.
2654 (make_timeval): New function.
2655 (set_file_times): Now sets ns-resolution time stamps.
2656 New arg FD; all uses changed.
2657 (time_from_jiffies, ltime_from_jiffies, get_up_time)
2658 (system_process_attributes):
2659 Now returns ns-resolution time stamp. All uses changed.
2660 Check for time stamp overflow.
2661
2662 * sysselect.h: Don't depend on HAVE_SYS_SELECT_H; gnulib
2663 provides a substitute now.
2664
2665 * systime.h: Include timespec.h rather than sys/time.h and time.h,
2666 since it guarantees struct timespec.
2667 (EMACS_TIME): Now struct timespec, so that we can support
2668 ns-resolution time stamps.
2669 (EMACS_TIME_RESOLUTION, LOG10_EMACS_TIME_RESOLUTION): New macros.
2670 (EMACS_HAS_USECS): Remove; Emacs always has sub-second time stamps now.
2671 (EMACS_USECS): Remove.
2672 (EMACS_SET_USECS): The underlying time stamp now has ns resolution,
2673 so multiply the arg by 1000 before storing it.
2674 (EMACS_NSECS, EMACS_SECS_ADDR, EMACS_SET_NSECS, EMACS_SET_SECS_NSECS):
2675 New macros.
2676 (EMACS_GET_TIME, EMACS_ADD_TIME, EMACS_SUB_TIME):
2677 Port to ns-resolution time stamps.
2678 (EMACS_TIME_NEG_P): Remove; replaced by....
2679 (EMACS_TIME_SIGN): New macro.
2680 (EMACS_SET_INVALID_TIME, EMACS_TIME_VALID_P)
2681 (EMACS_TIME_FROM_DOUBLE, EMACS_TIME_TO_DOUBLE): New macros.
2682 (set_file_times, make_time, lisp_time_argument): Adjust signature.
2683 (make_timeval, make_lisp_time, decode_time_components): New decls.
2684 (EMACS_TIME_CMP): Remove; no longer used. Plus, it was buggy, in
2685 that it mishandled time_t overflow. You can't compare by subtracting!
2686 (EMACS_TIME_EQ, EMACS_TIME_NE, EMACS_TIME_GT, EMACS_TIME_GE)
2687 (EMACS_TIME_LT, EMACS_TIME_LE): Rewrite in terms of timespec_cmp.
2688
2689 * term.c: Include <sys/time.h>.
2690 (timeval_to_Time): New function, for proper overflow wraparound.
2691 (term_mouse_position, term_mouse_click): Use it.
2692
2693 * undo.c (record_first_change): Support higher-resolution time stamps
2694 in the undo buffer.
2695 (Fprimitive_undo): Use them when restoring time stamps.
2696
2697 * w32.c (ltime, U64_TO_LISP_TIME, process_times, emacs_gnutls_pull)
2698 (w32_get_internal_run_time):
2699 Port to higher-resolution Emacs time stamps.
2700 (ltime): Now accepts single 64-bit integer, as that's more convenient
2701 for callers.
2702
2703 * xdisp.c (start_hourglass): Port to ns-resolution time stamps.
2704
2705 * xgselect.c, xgselect.h (xg_select): Add sigmask argument,
2706 for compatibility with pselect. Support ns-resolution time stamps.
2707
2708 * xmenu.c (x_menu_wait_for_event): Support ns-resolution time stamps.
2709
2710 * xselect.c (wait_for_property_change, x_get_foreign_selection):
2711 Check for time stamp overflow, and support ns-resolution time stamps.
2712
2713 * xterm.c: Don't include sys/time.h; gnulib does that for us now.
2714 Don't worry about whether HAVE_TIMEVAL and HAVE_SELECT are set.
2715 (timeval_subtract): Remove; no longer needed.
2716 (XTflash, XTring_bell, x_wait_for_event):
2717 Port to ns-resolution time stamps. Don't assume time_t is signed.
2718
b6a92dfe
CY
27192012-06-22 Chong Yidong <cyd@gnu.org>
2720
2721 * xdisp.c (x_consider_frame_title): Revert last change.
2722
d251c37c
EZ
27232012-06-22 Eli Zaretskii <eliz@gnu.org>
2724
2725 * alloc.c (NSTATICS): Enlarge to 0x650. Otherwise, Emacs compiled
2726 with -DENABLE_CHECKING -DXASSERTS -DGLYPH_DEBUG=1 -DBYTE_CODE_METER
2727 aborts in staticpro during startup. (Without -DBYTE_CODE_METER,
2728 staticidx goes up to 1597 out of 1600 = 0x640.)
2729
f10deafb
PE
27302012-06-20 Paul Eggert <eggert@cs.ucla.edu>
2731
2732 * fileio.c (Fdefault_file_modes): Block input while fiddling with umask.
2733 Otherwise, the umask might be mistakenly 0 while handling input signals.
2734
ec6de1e2
SM
27352012-06-19 Stefan Monnier <monnier@iro.umontreal.ca>
2736
2737 * minibuf.c (Fread_string): Bind minibuffer-completion-table.
2738
28be1ada
DA
27392012-06-19 Dmitry Antipov <dmantipov@yandex.ru>
2740
2741 * alloc.c, bytecode.c, ccl.c, coding.c, composite.c, data.c, dosfns.c:
2742 * font.c, image.c, keyboard.c, lread.c, menu.c, minibuf.c, msdos.c:
2743 * print.c, syntax.c, window.c, xmenu.c, xselect.c: Replace direct
2744 access to `contents' member of Lisp_Vector objects with AREF and ASET
2745 where appropriate.
2746
c6bf3022
CY
27472012-06-19 Chong Yidong <cyd@gnu.org>
2748
2749 * frame.c (delete_frame): When selecting a frame on a different
2750 text terminal, do not alter the terminal's top-frame.
2751
2752 * xdisp.c (format_mode_line_unwind_data): Record the target
2753 frame's selected window and its terminal's top-frame.
2754 (unwind_format_mode_line): Restore them.
2755 (x_consider_frame_title, display_mode_line, Fformat_mode_line):
2756 Callers changed.
2757 (x_consider_frame_title): Do not condition on HAVE_WINDOW_SYSTEM,
2758 since tty frames can be explicitly named.
2759 (prepare_menu_bars): Likewise.
2760
2761 * term.c (Ftty_top_frame): New function.
2762
defd4196
PE
27632012-06-18 Paul Eggert <eggert@cs.ucla.edu>
2764
2765 Port byte-code-meter to modern targets.
2766 * bytecode.c (METER_CODE) [BYTE_CODE_METER]: Don't assume
2767 !CHECK_LISP_OBJECT_TYPE && !USE_LSB_TAG. Problem with
8b5257e1 2768 CHECK_LISP_OBJECT_TYPE reported by Dmitry Antipov in
defd4196
PE
2769 <http://lists.gnu.org/archive/html/emacs-devel/2012-06/msg00282.html>.
2770 (METER_1, METER_2): Simplify.
2771
1053a871
SM
27722012-06-18 Stefan Monnier <monnier@iro.umontreal.ca>
2773
2774 * data.c (Fdefalias): Return `symbol' (bug#11686).
2775
b7e8d081
MR
27762012-06-18 Martin Rudalics <rudalics@gmx.at>
2777
2778 * buffer.c (Fkill_buffer): Don't throw an error when the buffer
1053a871
SM
2779 gets killed during executing of this function (Bug#11665).
2780 Try to always return Qt when the buffer has been actually killed.
b7e8d081
MR
2781 (Vkill_buffer_query_functions): In doc-string say that functions
2782 run by this hook should not change the current buffer.
2783
7ea2b339
PE
27842012-06-18 Paul Eggert <eggert@cs.ucla.edu>
2785
2786 Fix recently-introduced process.c problems found by static checking.
2787 * process.c (write_queue_push, write_queue_pop, send_process):
2788 Use ptrdiff_t, not int or EMACS_INT, for buffer lengths and offsets.
2789 (write_queue_pop): Fix pointer signedness problem.
2790 (send_process): Remove unused local.
2791
96a313a1
CY
27922012-06-17 Chong Yidong <cyd@gnu.org>
2793
2794 * xdisp.c (redisplay_internal): No need to redisplay terminal
2795 frames that are not on top.
2796
20ca2e94
TN
27972012-06-17 Troels Nielsen <bn.troels@gmail.com>
2798
2799 * process.c (make_process): Initialize write_queue.
2800 (write_queue_push, write_queue_pop): New functions.
2801 (send_process): Use them to maintain correct ordering of process
2802 writes (Bug#10815).
2803
9a900ca9
PE
28042012-06-17 Paul Eggert <eggert@cs.ucla.edu>
2805
310fbfa8
PE
2806 * lisp.h (eassert): Assume C89 or later.
2807 This removes the need for CHECK.
2808 (CHECK): Remove. Its comments about always evaluating its
2809 argument were confusing, as 'eassert' typically does not evaluate
2810 its argument.
2811
27bb1ca4
PE
2812 * coding.c (produce_chars): Use ptrdiff_t, not int.
2813
9a900ca9
PE
2814 * xterm.c (x_draw_underwave): Check for integer overflow.
2815 This pacifies gcc 4.7.0 -Wunsafe-loop-optimizations on x86-64.
2816
41b7f8bc 28172012-06-17 Jan Djärv <jan.h.d@swipnet.se>
50a93863
JD
2818
2819 * nsterm.m (x_free_frame_resources): Move xfree so freed memory isn't
2820 referenced (Bug#11583).
2821
9b0e3eba
AA
28222012-06-16 Aurelien Aptel <aurelien.aptel@gmail.com>
2823
2824 Implement wave-style variant of underlining.
2825 * dispextern.h (face_underline_type): New enum.
2826 (face): Add field for underline type.
2827 * nsterm.m (ns_draw_underwave): New function.
2828 (ns_draw_text_decoration): Use it.
2829 * w32term.c (w32_restore_glyph_string_clip, w32_draw_underwave):
2830 New functions.
2831 (x_draw_glyph_string): Use them.
2832 * xfaces.c (Qline, Qwave): New Lisp objects.
2833 (check_lface_attrs, merge_face_ref)
1053a871
SM
2834 (Finternal_set_lisp_face_attribute, realize_x_face):
2835 Handle wave-style underline face attributes.
9b0e3eba
AA
2836 * xterm.c (x_draw_underwave): New function.
2837 (x_draw_glyph_string): Use it.
2838
0fb52f11
JB
28392012-06-16 Juanma Barranquero <lekktu@gmail.com>
2840
2841 * makefile.w32-in ($(BLD)/emacs.$(O), $(BLD)/fringe.$(O))
2842 ($(BLD)/xml.$(O), $(BLD)/intervals.$(O), $(BLD)/macros.$(O))
2843 ($(BLD)/minibuf.$(O), $(BLD)/regex.$(O), $(BLD)/region-cache.$(O))
2844 ($(BLD)/textprop.$(O), $(BLD)/undo.$(O), $(BLD)/window.$(O))
2845 ($(BLD)/w32select.$(O)): Update dependencies.
2846
e5560ff7
AS
28472012-06-16 Andreas Schwab <schwab@linux-m68k.org>
2848
2849 * buffer.h (FETCH_MULTIBYTE_CHAR): Define as inline.
2850 (BUF_FETCH_MULTIBYTE_CHAR): Likewise.
2851 * character.c (_fetch_multibyte_char_p): Remove.
2852 * alloc.c: Include "character.h" before "buffer.h".
2853 * bidi.c: Likewise.
2854 * buffer.c: Likewise.
2855 * bytecode.c: Likewise.
2856 * callint.c: Likewise.
2857 * callproc.c: Likewise.
2858 * casefiddle.c: Likewise.
2859 * casetab.c: Likewise.
2860 * category.c: Likewise.
2861 * cmds.c: Likewise.
2862 * coding.c: Likewise.
2863 * composite.c: Likewise.
2864 * dired.c: Likewise.
2865 * dispnew.c: Likewise.
2866 * doc.c: Likewise.
2867 * dosfns.c: Likewise.
2868 * editfns.c: Likewise.
2869 * emacs.c: Likewise.
2870 * fileio.c: Likewise.
2871 * filelock.c: Likewise.
2872 * font.c: Likewise.
2873 * fontset.c: Likewise.
2874 * fringe.c: Likewise.
2875 * indent.c: Likewise.
2876 * insdel.c: Likewise.
2877 * intervals.c: Likewise.
2878 * keyboard.c: Likewise.
2879 * keymap.c: Likewise.
2880 * lread.c: Likewise.
2881 * macros.c: Likewise.
2882 * marker.c: Likewise.
2883 * minibuf.c: Likewise.
2884 * nsfns.m: Likewise.
2885 * nsmenu.m: Likewise.
2886 * print.c: Likewise.
2887 * process.c: Likewise.
2888 * regex.c: Likewise.
2889 * region-cache.c: Likewise.
2890 * search.c: Likewise.
2891 * syntax.c: Likewise.
2892 * term.c: Likewise.
2893 * textprop.c: Likewise.
2894 * undo.c: Likewise.
2895 * unexsol.c: Likewise.
2896 * w16select.c: Likewise.
2897 * w32fns.c: Likewise.
2898 * w32menu.c: Likewise.
2899 * window.c: Likewise.
2900 * xdisp.c: Likewise.
2901 * xfns.c: Likewise.
2902 * xmenu.c: Likewise.
2903 * xml.c: Likewise.
2904 * xselect.c: Likewise.
2905
2f07e6af
EZ
29062012-06-16 Eli Zaretskii <eliz@gnu.org>
2907
1053a871
SM
2908 * xdisp.c (set_cursor_from_row): Don't dereference glyphs_end.
2909 If all the glyphs of the glyph row came from strings, and we have no
2f07e6af 2910 cursor positioning clues, put the cursor on the first glyph of the
1097afe4
EZ
2911 row.
2912 (handle_face_prop): Use chunk-relative overlay string index when
2913 indexing into it->string_overlays array. (Bug#11653)
946fdb73
EZ
2914 (set_cursor_from_row): Use the leftmost glyph as GLYPH_BEFORE, not
2915 the rightmost. (Bug#11720)
2f07e6af 2916
29b83cec
AS
29172012-06-16 Andreas Schwab <schwab@linux-m68k.org>
2918
2919 * category.h (CHAR_HAS_CATEGORY): Define as inline.
2920 (CATEGORY_MEMBER): Enforce 1/0 value.
2921 * category.c (_temp_category_set): Remove.
2922
4c5501e9
EZ
29232012-06-16 Eli Zaretskii <eliz@gnu.org>
2924
2925 * window.c (Fdelete_other_windows_internal)
2926 (Fdelete_window_internal): Don't access frame's mouse highlight
2927 info of the initial frame. (Bug#11677)
2928
2b570124
PE
29292012-06-14 Paul Eggert <eggert@cs.ucla.edu>
2930
e93864f9
PE
2931 * .gdbinit (xgetint): Fix recently-introduced paren typo.
2932 Assume USE_2_TAGS_FOR_INTS.
2933 (xreload): Adjust $tagmask width to match recent lisp.h change.
2934
2b570124
PE
2935 Simplify lisp.h in minor ways that should not affect code.
2936 * lisp.h (USE_2_TAGS_FOR_INTS): Remove, as it was always defined.
2937 (LISP_INT_TAG, case_Lisp_Int, LISP_STRING_TAG, LISP_INT_TAG_P)
2938 (LISP_INT1_TAG, enum Lisp_Type, XINT, XUINT, make_number):
2939 Simplify under the assumption that USE_2_TAGS_FOR_INTS is defined.
2940 (INTTYPEBITS): New macro, for clarity.
2941 (INTMASK, MOST_POSITIVE_FIXNUM): Use it.
1053a871
SM
2942 (LISP_INT1_TAG, LISP_STRING_TAG, LISP_INT_TAG_P):
2943 Simplify now that USE_LSB_TAG is always defined.
2b570124
PE
2944 (TYPEMASK, XINT) [USE_LSB_TAG]: Remove unnecessary cast.
2945 (make_number) [!USE_LSB_TAG]: Use INTMASK; that's simpler.
2946
81755f69
JB
29472012-06-13 Juanma Barranquero <lekktu@gmail.com>
2948
2949 * makefile.w32-in ($(BLD)/data.$(O)): Update dependencies.
2950
16192a57
GM
29512012-06-13 Glenn Morris <rgm@gnu.org>
2952
2953 * s/bsd-common.h (BSD4_3):
2954 * s/usg5-4-common.h (USG5_4): No longer define; unused.
2955
646b5f55
AS
29562012-06-13 Andreas Schwab <schwab@linux-m68k.org>
2957
2958 * lisp.h (Lisp_Object) [CHECK_LISP_OBJECT_TYPE]: Define as struct
2959 instead of union.
2960 (XLI, XIL): Define.
1053a871
SM
2961 (XHASH, XTYPE, XINT, XUINT, make_number, XSET, XPNTR, XUNTAG):
2962 Use them.
2963 * emacs.c (gdb_use_struct): Rename from gdb_use_union.
646b5f55 2964 * .gdbinit: Check gdb_use_struct instead of gdb_use_union.
1053a871 2965 * alloc.c (widen_to_Lisp_Object): Remove.
646b5f55
AS
2966 (mark_memory): Use XIL instead of widen_to_Lisp_Object.
2967 * frame.c (delete_frame): Remove outdated comment.
2968 * w32fns.c (Fw32_register_hot_key): Use XLI instead of checking
2969 USE_LISP_UNION_TYPE.
2970 (Fw32_unregister_hot_key): Likewise.
2971 (Fw32_toggle_lock_key): Likewise.
2972 * w32menu.c (add_menu_item): Likewise.
2973 (w32_menu_display_help): Use XIL instead of checking
2974 USE_LISP_UNION_TYPE.
2975 * w32heap.c (allocate_heap): Don't check USE_LISP_UNION_TYPE.
2976 (init_heap): Likewise.
2977 * w32term.c (w32_read_socket): Update comment.
2978
1d3823c9
GM
29792012-06-13 Glenn Morris <rgm@gnu.org>
2980
c62ff706
GM
2981 * s/usg5-4-common.h, src/s/unixware.h:
2982 Remove define/undef of HAVE_SYSV_SIGPAUSE (not used since 2010-05-04).
2983
1d3823c9
GM
2984 * s/gnu.h (POSIX_SIGNALS): Remove (not used since 2010-05-04).
2985
bfe3e0a2
PE
29862012-06-13 Paul Eggert <eggert@cs.ucla.edu>
2987
2988 USE_LISP_UNION_TYPE + USE_LSB_TAG cleanup (Bug#11604)
2989 * alloc.c (make_number) [!defined make_number]:
2990 Remove, as lisp.h always defines this now.
2991 (mark_maybe_pointer): Simplify since USE_LSB_TAG is always defined now.
2992 (roundup_size): Verify that it is a power of 2.
2993 * data.c (Fmake_variable_buffer_local, Fmake_local_variable):
2994 * ftfont.c (ftfont_driver): Use LISP_INITIALLY_ZERO.
2995 * lisp.h (USE_LSB_TAG): Allow the builder to compile with
2996 -DUSE_LSB_TAG=0, to override the automatically-selected default.
2997 USE_LSB_TAG now is always defined to be either 0 or 1.
2998 All uses changed.
2999 (union Lisp_Object): Don't worry about WORDS_BIGENDIAN; the
3000 code works fine either way, and efficiency is not a concern here,
3001 as the union type is for debugging, not for production.
3002 (LISP_MAKE_RVALUE, make_number) [USE_LISP_UNION_TYPE]:
3003 Use an inline function on all platforms when using the union type,
3004 since this is simpler and 'static inline' can be used portably
3005 within Emacs now.
3006 (LISP_INITIALLY_ZERO): New macro.
3007 (XFASTINT, XSETFASTINT) [USE_LISP_UNION_TYPE]: Remove.
3008 (XSET) [USE_LISP_UNION_TYPE]: Don't overparenthesize.
3009
45fa9c0f
GM
30102012-06-12 Glenn Morris <rgm@gnu.org>
3011
b4492cba
GM
3012 * s/gnu-kfreebsd.h, s/hpux11.h, s/openbsd.h, s/sol2-10.h: Remove files.
3013
3014 * s/gnu-linux.h (HAVE_PROCFS): Move to configure.
0d369729 3015
45fa9c0f
GM
3016 * s/hpux10-20.h, s/openbsd.h, s/usg5-4-common.h:
3017 Move BROKEN_SIGIO to configure.
3018
3019 * s/bsd-common.h, s/darwin.h, s/gnu-kfreebsd.h, s/hpux10-20.h:
3020 Move NO_TERMIO to configure.
3021
0e25d334
CY
30222012-06-12 Chong Yidong <cyd@gnu.org>
3023
3024 * image.c (imagemagick_load_image): Use MagickFlattenImage if
3025 MagickMergeImageLayers is undefined. Use pixel pusher loop if
3026 MagickExportImagePixels is undefined.
3027
43682bb6
PE
30282012-06-12 Paul Eggert <eggert@cs.ucla.edu>
3029
3030 * image.c (imagemagick_load_image): Remove unused label.
3031
a9be7d2b
GM
30322012-06-11 Glenn Morris <rgm@gnu.org>
3033
3034 * s/aix4-2.h, s/bsd-common.h, s/cygwin.h, s/darwin.h:
3035 * s/gnu-kfreebsd.h, s/gnu-linux.h, s/gnu.h, s/hpux10-20.h:
3036 * s/irix6-5.h, s/ms-w32.h, s/msdos.h, s/template.h:
3037 * s/usg5-4-common.h: Move SYSTEM_TYPE to configure.
3038
3017f87f
SM
30392012-06-11 Stefan Monnier <monnier@iro.umontreal.ca>
3040
3041 * alloc.c (make_byte_code): New function.
3042 (Fmake_byte_code): Use it. Don't purify here.
3043 * lread.c (read1): Use it as well to avoid extra allocation.
3044
1b9b4cf4
CY
30452012-06-11 Chong Yidong <cyd@gnu.org>
3046
3047 * image.c (imagemagick_load_image): Implement transparency.
3048
95988fcf
AS
30492012-06-10 Andreas Schwab <schwab@linux-m68k.org>
3050
3051 * regex.c (at_begline_loc_p): Also recognize `(?N:' and correctly
3052 account for preceding backslashes. (Bug#11663)
3053
cd4eb164
CY
30542012-06-09 Chong Yidong <cyd@gnu.org>
3055
3056 * term.c: Support italics in capable terminals (Bug#9652).
3057 (no_color_bit): Replace unused NC_BLINK with NC_ITALIC.
3058 (turn_on_face): Output using TS_enter_italic_mode if available.
3059 Don't handle unused blinking and alt-charset cases.
3060 (turn_off_face): Handle italic case; discard unused tty_blinking_p
3061 and tty_alt_charset_p cases.
3062 (tty_capable_p, init_tty): Support italics.
3063
3064 * termchar.h (struct tty_display_info): Add field for italics.
3065 Remove unused blink field.
3066
3067 * xfaces.c (tty_supports_face_attributes_p, realize_tty_face):
3068 Handle slant.
3069
3070 * dispextern.h: Replace unused TTY_CAP_BLINK with TTY_CAP_ITALIC.
3071 (struct face): Remove unused fields tty_dim_p, tty_blinking_p, and
3072 tty_alt_charset_p. Add tty_italic_p.
3073
ff88beb8
MA
30742012-06-09 Michael Albinus <michael.albinus@gmx.de>
3075
3076 * dbusbind.c (XD_BASIC_DBUS_TYPE): Use dbus_type_is_valid and
3077 dbus_type_is_basic if available.
3078 (xd_extract_signed, xd_extract_unsigned): Rename from
3079 extract_signed and extract_unsigned, respectively. Adapt callers.
3080
44286096
CY
30812012-06-09 Chong Yidong <cyd@gnu.org>
3082
1682701f
CY
3083 * xfaces.c (face_for_overlay_string): Handle face remapping (Bug#2066).
3084
44286096
CY
3085 * fringe.c (Fset_fringe_bitmap_face): Handle the noninteractive
3086 case (Bug#9752).
3087
d86feb17
PE
30882012-06-08 Paul Eggert <eggert@cs.ucla.edu>
3089
3090 * xdisp.c (vmessage): Treat frame message as multibyte.
3091 Without this change, (let ((§ 1)) (make-variable-buffer-local '§))
3092 would generate the diagnostic "Making \302\247 buffer-local while
3093 let-bound!".
3094
d5c20fe8
EZ
30952012-06-08 Eli Zaretskii <eliz@gnu.org>
3096
3097 * dispnew.c (showing_window_margins_p): Undo last change, which
3098 was done due to an inadvertent commit.
3099 (adjust_frame_glyphs_for_frame_redisplay): Do call
3100 showing_window_margins_p.
3101
513749ee
SM
31022012-06-08 Stefan Monnier <monnier@iro.umontreal.ca>
3103
3104 * eval.c (Fmake_var_non_special): New primitive.
3105 (syms_of_eval): Defsubr it.
3106 * lread.c (syms_of_lread): Mark `values' as lexically scoped.
3107
d4a8f5c1
JB
31082012-06-08 Juanma Barranquero <lekktu@gmail.com>
3109
3110 * dispnew.c (showing_window_margins_p): Wrap in #if 0 to prevent unused
3111 function warning (the only call is inside #if 0 since 2012-06-08T08:44:45Z!eliz@gnu.org).
3112
8bbbc977
EZ
31132012-06-08 Eli Zaretskii <eliz@gnu.org>
3114
3115 * alloc.c (allocate_vectorlike): Fix last change.
3116
f3372c87
DA
31172012-06-08 Dmitry Antipov <dmantipov@yandex.ru>
3118
3119 Block-based vector allocation of small vectors.
3120 * lisp.h (struct vectorlike_header): New field `nbytes',
3121 adjust comment accordingly.
3122 * alloc.c (enum mem_type): New type `MEM_TYPE_VECTOR_BLOCK'
3123 to denote vector blocks. Adjust users (live_vector_p,
3124 mark_maybe_pointer, valid_lisp_object_p) accordingly.
3125 (COMMON_MULTIPLE): Move outside #if USE_LSB_TAG.
3126 (VECTOR_BLOCK_SIZE, vroundup, VECTOR_BLOCK_BYTES),
3127 (VBLOCK_BYTES_MIN, VBLOCK_BYTES_MAX, VECTOR_MAX_FREE_LIST_INDEX),
3128 (VECTOR_FREE_LIST_FLAG, ADVANCE, VINDEX, SETUP_ON_FREE_LIST),
3129 (VECTOR_SIZE, VECTOR_IN_BLOCK): New macros.
3130 (roundup_size): New constant.
3131 (struct vector_block): New data type.
3132 (vector_blocks, vector_free_lists, zero_vector): New variables.
513749ee 3133 (all_vectors): Rename to `large_vectors'.
f3372c87
DA
3134 (allocate_vector_from_block, init_vectors, allocate_vector_from_block)
3135 (sweep_vectors): New functions.
3136 (allocate_vectorlike): Return `zero_vector' as the only vector of
3137 0 items. Allocate new vector from block if vector size is less than
3138 or equal to VBLOCK_BYTES_MAX.
3139 (Fgarbage_collect): Move all vector sweeping code to sweep_vectors.
3140 (init_alloc_once): Add call to init_vectors.
3141
4f18a4ed
SM
31422012-06-08 Stefan Monnier <monnier@iro.umontreal.ca>
3143
3144 * eval.c (Fmacroexpand): Stop if the macro returns the same form.
3145
86f158bc
PE
31462012-06-07 Paul Eggert <eggert@cs.ucla.edu>
3147
3148 * doprnt.c (doprnt): Truncate multibyte char correctly.
3149 Without this change, doprnt (buf, 2, "%s", FORMAT_END, AP)
3150 would mishandle a string argument "Xc" if X was a multibyte
3151 character of length 2: it would truncate after X's first byte
3152 rather than including all of X.
3153
c5cfcbe0
CY
31542012-06-06 Chong Yidong <cyd@gnu.org>
3155
3156 * buffer.c (word_wrap): Doc fix.
3157
c05cf390
PE
31582012-06-04 Paul Eggert <eggert@cs.ucla.edu>
3159
3160 * xdisp.c (note_mode_line_or_margin_highlight): Pacify gcc -Wall.
3161
0c3461de
GM
31622012-06-03 Glenn Morris <rgm@gnu.org>
3163
3164 * xdisp.c (tool-bar-style): Doc fix.
3165
c71232db
UM
31662012-06-03 Ulrich Müller <ulm@gentoo.org>
3167
3168 * Makefile.in (PAXCTL): Define.
3169 (temacs$(EXEEXT)): Disable memory randomization for the temacs
3170 binary via PaX flags if the paxctl utility is available.
3171 (emacs$(EXEEXT), bootstrap-emacs$(EXEEXT)):
3172 Restore PaX flags to their default. (Bug#11398)
3173
383f7350
CY
31742012-06-03 Chong Yidong <cyd@gnu.org>
3175
3176 * xdisp.c (decode_mode_spec_coding): Display a space for a unibyte
3177 buffer (Bug#11226).
3178
5f2c76c6
CY
31792012-06-03 Chong Yidong <cyd@gnu.org>
3180
3181 * xdisp.c (calc_pixel_width_or_height): Use Fbuffer_local_value.
3182 (note_mode_line_or_margin_highlight): If there is no help echo,
3183 use mode-line-default-help-echo. Handle the case where the mouse
3184 position is past the end of the mode line string.
3185
3186 * buffer.c (buffer_local_value_1): New function, split from
3187 Fbuffer_local_value; can return Qunbound.
3188 (Fbuffer_local_value): Use it.
3189 (Vmode_line_format): Docstring tweaks.
3190
773d47f6
PE
31912012-06-02 Paul Eggert <eggert@cs.ucla.edu>
3192
3193 * sysdep.c (system_process_attributes): Improve comment.
3194
f2d6a3df
SM
31952012-06-02 Stefan Monnier <monnier@iro.umontreal.ca>
3196
3197 * keyboard.c: Export real-this-command to Elisp.
3198 (syms_of_keyboard): Rename real_this_command to Vreal_this_command
3199 and DEFVAR it. Update all users.
3200
63810350
PE
32012012-06-02 Paul Eggert <eggert@cs.ucla.edu>
3202
7bd5c1f4
PE
3203 * minibuf.c (Fassoc_string): Remove duplicate declaration.
3204
63810350
PE
3205 * sysdep.c (system_process_attributes) [SOLARIS2 && HAVE_PROCFS]:
3206 Convert pctcpu and pctmem to Lisp float properly.
3207 Let the compiler fold better, as 100.0/0x8000 is exact.
3208
a2821611
AS
32092012-06-02 Andreas Schwab <schwab@linux-m68k.org>
3210
3211 * alloc.c (CONS_BLOCK_SIZE): Account for padding at the end of
3212 cons_block.
3213
5fceba1d
PE
32142012-06-01 Paul Eggert <eggert@cs.ucla.edu>
3215
3216 * xfns.c (x_set_tool_bar_lines) [USE_GTK]: Adjust to bitfield change.
3217
c98ff5dd
DA
32182012-06-01 Dmitry Antipov <dmantipov@yandex.ru>
3219
3220 For a 'struct window', replace some Lisp_Object fields to
3221 bitfields where appropriate, remove unused fields.
3222 * window.h (struct window): Remove unused 'last_mark_x' and
3223 'last_mark_y' fields. Rename 'mini_p' field to 'mini',
3224 change it's type from Lisp_Object to bitfield.
3225 Change type of 'force_start', 'optional_new_start',
3226 'last_had_star', 'update_mode_line' and 'start_at_line_beg'
3227 fields from Lisp_Object to bitfield. Adjust users accordingly.
3228
ca34e0be
PE
32292012-05-31 Paul Eggert <eggert@cs.ucla.edu>
3230
3231 Pacify gcc -Wdouble-precision when using Xaw.
3232 * xterm.c (xaw_jump_callback, x_set_toolkit_scroll_bar_thumb)
3233 [HAVE_X_WINDOWS && USE_TOOLKIT_SCROLL_BARS && !USE_MOTIF && !USE_GTK]:
3234 Use 'float' consistently, rather than 'float' in most places
3235 and 'double' in a couple of places.
3236
efc00ab1 32372012-05-31 Eli Zaretskii <eliz@gnu.org>
d5fd2c54
EZ
3238
3239 * xdisp.c (handle_stop): Detect whether we have overlay strings
3240 loaded by testing it->current.overlay_string_index to be
3241 non-negative, instead of checking whether n_overlay_strings is
3242 positive. (Bug#11587)
3243
efc00ab1 32442012-05-31 Chong Yidong <cyd@gnu.org>
353c87f6
CY
3245
3246 * keymap.c (describe_map_tree): Revert 2011-07-07 change (Bug#1169).
3247
3248 * doc.c (Fsubstitute_command_keys): Doc fix.
3249
efc00ab1 32502012-05-31 Eli Zaretskii <eliz@gnu.org>
a02ae4e5
EZ
3251
3252 * search.c (search_buffer): Remove calls to
3253 r_alloc_inhibit_buffer_relocation, as it is now called by
3254 maybe_unify_char, which was the cause of relocation of buffer text
3255 in bug#11519.
3256
efc00ab1 32572012-05-31 Eli Zaretskii <eliz@gnu.org>
291d430f
EZ
3258
3259 * charset.c (maybe_unify_char): Inhibit relocation of buffer text
3260 for the duration of call to load_charset, to avoid problems with
3261 callers of maybe_unify_char that access buffer text through C
3262 pointers.
3263
3264 * ralloc.c (r_alloc_inhibit_buffer_relocation): Increment and
3265 decrement the inhibition flag, instead of just setting or
3266 resetting it.
3267
ba93a187
PE
32682012-05-31 Paul Eggert <eggert@cs.ucla.edu>
3269
3270 Remove obsolete '#define static' cruft.
3271 * s/hpux10-20.h (_FILE_OFFSET_BITS): Don't #undef.
3272 This #undef was "temporary" in 2000; it is no longer needed
3273 now that '#define static' has gone away.
3274 * xfns.c, xterm.h (gray_bitmap_width, gray_bitmap_height)
3275 (gray_bitmap_bits): Remove; no longer needed.
3276 All uses replaced with definiens.
3277 * xterm.c: Include "bitmaps/gray.xbm".
3278
9e4bf381
PE
32792012-05-30 Paul Eggert <eggert@cs.ucla.edu>
3280
3281 Clean up __executable_start, monstartup when --enable-profiling.
3282 The following changes affect the code only when profiling.
3283 * dispnew.c (__executable_start): Rename from safe_bcopy.
3284 Define only on platforms that need it.
3285 * emacs.c: Include <sys/gmon.h> when profiling.
3286 (_mcleanup): Remove decl, since <sys/gmon.h> does it now.
3287 (__executable_start): Remove decl, since lisp.h does it now.
3288 (safe_bcopy): Remove decl; no longer has that name.
3289 (main): Coalesce #if into single bit of code, for simplicity.
3290 Cast pointers to uintptr_t, since standard libraries want integers
3291 and not pointers.
3292 * lisp.h (__executable_start): New decl.
3293
32d72c2f
GM
32942012-05-31 Glenn Morris <rgm@gnu.org>
3295
3296 * image.c (Fimagemagick_types): Doc fix.
3297
baac5bc7
JM
32982012-05-30 Jim Meyering <meyering@redhat.com>
3299
3300 * callproc.c (Fcall_process_region): Include directory component
3301 in mkstemp error message (Bug#11586).
3302
72cb32cf
PE
33032012-05-30 Paul Eggert <eggert@cs.ucla.edu>
3304
3305 * alloc.c, lisp.h (make_pure_vector): Now static.
3306
61b108cc
SM
33072012-05-30 Stefan Monnier <monnier@iro.umontreal.ca>
3308
3309 * eval.c (Fdefun, Fdefmacro, Vmacro_declaration_function):
3310 Move to byte-run.el.
3311 (Fautoload): Do the hash-doc more carefully.
3312 * data.c (Fdefalias): Purify definition, except for keymaps.
3313 (Qdefun): Move from eval.c.
3314 * lisp.h (Qdefun): Remove.
3315 * lread.c (read1): Tiny simplification.
3316
471fe23d
TN
33172012-05-29 Troels Nielsen <bn.troels@gmail.com>
3318
934f3f58 3319 Do not create empty overlays with the evaporate property (Bug#9642).
471fe23d
TN
3320 * buffer.c (Fmove_overlay): Reinstate the earlier fix for
3321 Bug#9642, but explicitly check that the buffer the overlay would
3322 be moved to is live and rearrange lines to make sure that errors
3323 will not put the overlay in an inconsistent state.
3324 (Fdelete_overlay): Cosmetics.
3325
85d0efd1
EZ
33262012-05-28 Eli Zaretskii <eliz@gnu.org>
3327
3328 * w32term.c (my_bring_window_to_top): New function.
3329 (x_raise_frame): Use handle returned by DeferWindowPos, which
61b108cc
SM
3330 could be different from the original one.
3331 Call my_bring_window_to_top instead of my_set_foreground_window.
85d0efd1
EZ
3332 (Bug#11513)
3333
3334 * w32fns.c (w32_wnd_proc): Accept and process WM_EMACS_BRINGTOTOP
3335 by calling BringWindowToTop.
3336
3337 * w32term.h (WM_EMACS_BRINGTOTOP): New message.
3338 (WM_EMACS_END): Increase by one.
3339
da92a98c
PE
33402012-05-28 Paul Eggert <eggert@cs.ucla.edu>
3341
3342 * bidi.c (bidi_mirror_char): Put eassert before conversion to int.
3343 This avoids undefined behavior that might cause the eassert
3344 to not catch an out-of-range value.
3345
74d1f848
JB
33462012-05-28 Juanma Barranquero <lekktu@gmail.com>
3347
3348 * makefile.w32-in ($(BLD)/w32inevt.$(O), $(BLD)/w32console.$(O)):
3349 Update dependencies.
3350
9e1a06fc
EZ
33512012-05-27 Eli Zaretskii <eliz@gnu.org>
3352
3353 * bidi.c (bidi_mirror_char): Fix last change.
3354
f3dd7312
AS
33552012-05-27 Andreas Schwab <schwab@linux-m68k.org>
3356
3357 * unexmacosx.c (copy_data_segment): Truncate after 16 characters
3358 when referring to sectname field in printf format.
3359
81899c91
PE
33602012-05-27 Paul Eggert <eggert@cs.ucla.edu>
3361
57b81a9f
PE
3362 * lisp.h [REL_ALLOC]: Omit duplicate prototypes.
3363 Only r_alloc_inhibit_buffer_relocation needed to be added;
3364 the others were already declared.
3365
81899c91
PE
3366 * bidi.c (bidi_mirror_char): Don't possibly truncate the integer
3367 before checking whether it's out of range. Put the check inside
3368 eassert. See
3369 <http://lists.gnu.org/archive/html/emacs-devel/2012-05/msg00485.html>.
3370
33017faf 33712012-05-27 Ken Brown <kbrown@cornell.edu>
2f9b9adb
KB
3372
3373 * callproc.c (Fcall_process): Restore a line that was accidentally
3374 commented out in the 2011-02-13 change (bug#11547).
3375
33017faf 33762012-05-27 Eli Zaretskii <eliz@gnu.org>
52c55cc7
EZ
3377
3378 * lisp.h [REL_ALLOC]: Add prototypes for external functions
3379 defined on ralloc.c.
3380
3381 * buffer.c [REL_ALLOC]: Remove prototypes of
3382 r_alloc_reset_variable, r_alloc, r_re_alloc, and r_alloc_free,
3383 they are now on lisp.h.
3384
3385 * ralloc.c (r_alloc_inhibit_buffer_relocation): New function.
3386
3387 * search.c (search_buffer): Use it to inhibit relocation of buffer
3388 text while re_search_2 is doing its job, because re_search_2 is
3389 passed C pointers to buffer text. (Bug#11519)
3390
23415acf
EZ
3391 * msdos.c (internal_terminal_init) <Vwindow_system_version>:
3392 Update value to 24.
3393
44e27368
EZ
3394 * xdisp.c (move_it_to): Under MOVE_TO_Y, when restoring iterator
3395 state after an additional call to move_it_in_display_line_to, keep
3396 the values of it->max_ascent and it->max_descent found for the
3397 entire line.
3398 (pos_visible_p): Revert the comparison against bottom_y to what it
3399 was in revid eliz@gnu.org-20120513182235-4p6386j761ld0nwb.
3400 (Bug#11464)
3401
c1892f11
PE
34022012-05-26 Paul Eggert <eggert@cs.ucla.edu>
3403
3404 Fix coding-related core dumps with gcc -ftrapv.
3405 The code was computing A - B, where A and B are pointers, and B is
3406 random garbage. This can lead to core dumps on platforms that
3407 have special pointer registers, and it also leads to core dumps on
3408 x86-64 when compiled with gcc -ftrapv. The fix is to compute
3409 A - B only when B is initialized properly.
3410 * coding.c (coding_set_source, coding_set_destination): Return void.
3411 (coding_change_source, coding_change_destinations): New functions,
3412 with the old behaviors of coding_set_source and coding_set_destination.
3413 All callers that need an offset changed to use these new functions.
3414
eb7afdad
GM
34152012-05-26 Glenn Morris <rgm@gnu.org>
3416
3417 * nsterm.m (ns_init_paths): Don't mess with INFOPATH. (Bug#2791)
3418
f12fdf02
EZ
34192012-05-26 Eli Zaretskii <eliz@gnu.org>
3420
53a63be6 3421 Extend mouse support on W32 text-mode console.
61b108cc
SM
3422 * xdisp.c (draw_row_with_mouse_face):
3423 Call tty_draw_row_with_mouse_face for WINDOWSNT as well.
eb3f6f01 3424
eb3f6f01 3425 * w32console.c: Include window.h.
61b108cc
SM
3426 (w32con_write_glyphs_with_face, tty_draw_row_with_mouse_face):
3427 New functions.
eb3f6f01
EZ
3428 (initialize_w32_display): Initialize mouse-highlight data.
3429
53a63be6
EZ
3430 * w32inevt.c: Include termchar.h and window.h.
3431 (do_mouse_event): Support mouse-autoselect-window. When the mouse
3432 moves, call note_mouse_highlight. If help_echo changed, call
3433 gen_help_event to produce help-echo message in the echo area.
3434 Call clear_mouse_face if mouse_face_hidden is set in the mouse
3435 highlight info.
3436
4cfd81f6
PE
34372012-05-26 Paul Eggert <eggert@cs.ucla.edu>
3438
3439 * lread.c (read1): Simplify slightly to avoid an overflow warning
3440 with GCC 4.7.0 on x86-64.
3441
4446092a
EZ
34422012-05-26 Eli Zaretskii <eliz@gnu.org>
3443
3444 * bidi.c (bidi_mirror_char): Revert last change: an int is
3445 definitely wide enough here.
3446
42b2a986 34472012-05-25 Paul Eggert <eggert@cs.ucla.edu>
3164aeac 3448
42b2a986 3449 Fix integer width and related bugs (Bug#9874).
eb106a49 3450 * alloc.c (pure_bytes_used_lisp, pure_bytes_used_non_lisp):
d311d28c
PE
3451 (allocate_vectorlike, buffer_memory_full, struct sdata, SDATA_SIZE)
3452 (string_bytes, check_sblock, allocate_string_data):
3453 (compact_small_strings, Fmake_bool_vector, make_string)
3454 (make_unibyte_string, make_multibyte_string)
3455 (make_string_from_bytes, make_specified_string)
3456 (allocate_vectorlike, Fmake_vector, find_string_data_in_pure)
3457 (make_pure_string, make_pure_c_string, make_pure_vector, Fpurecopy)
3458 (mark_vectorlike):
3459 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3460 (allocate_pseudovector):
3461 Use int, not EMACS_INT, where int is wide enough.
3462 (inhibit_garbage_collection, Fgarbage_collect):
3463 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3464 * bidi.c (bidi_mirror_char): Use EMACS_INT, not int, where
3465 int might not be wide enough.
3466 (bidi_cache_search, bidi_cache_find, bidi_init_it)
3467 (bidi_count_bytes, bidi_char_at_pos, bidi_fetch_char)
3468 (bidi_at_paragraph_end, bidi_find_paragraph_start)
3469 (bidi_paragraph_init, bidi_resolve_explicit, bidi_resolve_weak)
3470 (bidi_level_of_next_char, bidi_move_to_visually_next):
3471 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3472 * buffer.c (copy_overlays, Fgenerate_new_buffer_name)
3473 (Fkill_buffer, Fset_buffer_major_mode)
3474 (advance_to_char_boundary, Fbuffer_swap_text)
3475 (Fset_buffer_multibyte, overlays_at, overlays_in)
3476 (overlay_touches_p, struct sortvec, record_overlay_string)
3477 (overlay_strings, recenter_overlay_lists)
3478 (adjust_overlays_for_insert, adjust_overlays_for_delete)
3479 (fix_start_end_in_overlays, fix_overlays_before, modify_overlay)
3480 (Fmove_overlay, Fnext_overlay_change, Fprevious_overlay_change)
3481 (Foverlay_recenter, last_overlay_modification_hooks_used)
3482 (report_overlay_modification, evaporate_overlays, enlarge_buffer_text):
3483 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
977b0e45
PE
3484 (validate_region): Omit unnecessary test for b <= e,
3485 since that's guaranteed by the previous test.
d311d28c
PE
3486 (adjust_overlays_for_delete): Avoid pos + length overflow.
3487 (Fmove_overlay, Fdelete_overlay, add_overlay_mod_hooklist)
3488 (report_overlay_modification):
3489 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3490 (Foverlays_at, Fnext_overlay_change, Fprevious_overlay_change):
3491 Omit pointer cast, which isn't needed anyway, and doesn't work
3492 after the EMACS_INT -> ptrdiff_t change.
02481186 3493 (Fmove_overlay): Clip BEG and END to ptrdiff_t to avoid overflow.
d311d28c
PE
3494 * buffer.h: Adjust decls to match defn changes elsewhere.
3495 (struct buffer_text, struct buffer):
3496 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3497 Use EMACS_INT, not int, where int might not be wide enough.
39b5db3b
PE
3498 * bytecode.c (unmark_byte_stack, exec_byte_code): Use ptrdiff_t,
3499 not int, to avoid needless 32-bit limit on 64-bit hosts.
3500 (exec_byte_code): Use tighter memory-full test, one that checks
3501 for alloca overflow. Don't compute the address of the object just
3502 before an array, as that's not portable. Use EMACS_INT, not
3503 ptrdiff_t or int, where ptrdiff_t or int might not be wide enough.
d311d28c
PE
3504 * callint.c (Fcall_interactively):
3505 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3506 * callproc.c (call_process_kill, Fcall_process):
3507 Don't assume pid_t fits into an Emacs fixnum.
3508 (call_process_cleanup, Fcall_process, child_setup):
3509 Don't assume pid_t fits into int.
3510 (call_process_cleanup, Fcall_process, delete_temp_file)
3511 (Fcall_process_region):
3512 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3513 (Fcall_process): Simplify handling of volatile integers.
3514 Use int, not EMACS_INT, where int will do.
3515 * casefiddle.c (casify_object, casify_region, operate_on_word)
3516 (Fupcase_word, Fdowncase_word, Fcapitalize_word):
3517 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3518 (casify_object): Avoid integer overflow when overallocating buffer.
3519 * casetab.c (set_identity, shuffle): Prefer int to unsigned when
45c2afd6 3520 either works. Use lint_assume to convince GCC 4.6.1 that it's OK.
d311d28c
PE
3521 * category.c (Fchar_category_set): Don't assume fixnum fits in int.
3522 * category.h (CATEGORYP): Don't assume arg is nonnegative.
3523 * ccl.c (GET_CCL_INT): Remove; no longer needed, since the
3524 integers are now checked earlier. All uses replaced with XINT.
3525 (ccl_driver):
3526 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3527 For CCL_MapSingle, check that content and value are in int range.
c801946a
PE
3528 (ccl_driver, Fregister_code_conversion_map):
3529 Check that Vcode_version_map_vector is a vector.
d311d28c
PE
3530 (resolve_symbol_ccl_program): Check that vector header is in range.
3531 Always copy the vector, so that we can check its contents reliably
3532 now rather than having to recheck each instruction as it's being
3533 executed. Check that vector words fit in 'int'.
3534 (ccl_get_compiled_code, Fregister_ccl_program)
3535 (Fregister_code_conversion_map): Use ptrdiff_t, not int, for
3536 program indexes, to avoid needless 32-bit limit on 64-bit hosts.
3537 (Fccl_execute, Fccl_execute_on_string): Check that initial reg
3538 contents are in range.
3539 (Fccl_execute_on_string): Check that status is in range.
3540 * ccl.h (struct ccl_program.idx): Now ptrdiff_t, not int.
3541 * character.c (char_resolve_modifier_mask, Fchar_resolve_modifiers):
3542 Accept and return EMACS_INT, not int, because callers can pass values
3543 out of 'int' range.
3544 (c_string_width, strwidth, lisp_string_width, chars_in_text)
3545 (multibyte_chars_in_text, parse_str_as_multibyte)
3546 (str_as_multibyte, count_size_as_multibyte, str_to_multibyte)
3547 (str_as_unibyte, str_to_unibyte, string_count_byte8)
3548 (string_escape_byte8, Fget_byte):
3549 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
a14e1568 3550 (Funibyte_string): Use CHECK_RANGED_INTEGER, not CHECK_NATNUM, to
d311d28c
PE
3551 avoid mishandling large integers.
3552 * character.h: Adjust decls to match defn changes elsewhere.
3553 * charset.c (load_charset_map_from_file, find_charsets_in_text)
3554 (Ffind_charset_region):
3555 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3556 (load_charset_map_from_file): Redo idx calculation to avoid overflow.
3557 (load_charset_map_from_vector, Fdefine_charset_internal):
3c7649c1 3558 Don't assume fixnum fits in int.
d311d28c
PE
3559 (load_charset_map_from_vector, Fmap_charset_chars):
3560 Remove now-unnecessary CHECK_NATNUMs.
3561 (Fdefine_charset_internal): Check ranges here, more carefully.
3c7649c1
PE
3562 Don't rely on undefined behavior with signed left shift overflow.
3563 Don't assume unsigned int fits into fixnum, or that fixnum fits
3564 into unsigned int. Don't require max_code to be a valid fixnum;
3565 that's not true for gb10830 4-byte on a 32-bit host. Allow
3566 invalid_code to be a cons, for the same reason. Require code_offset
3567 to be a character. Avoid int overflow if max_char is close
3568 to INT_MAX.
3569 (CODE_POINT_TO_INDEX): On 32-bit hosts, return int, not unsigned;
3570 this is intended anyway and avoids some undefined behavior.
3571 (load_charset_map): Pass unsigned, not int, as 2nd arg of
3572 INDEX_TO_CODE_POINT, as that's what it expects.
3573 (Funify_charset, encode_char): Don't stuff unsigned vals into int vars.
60ad3eab
PE
3574 * charset.h (DECODE_CHAR): Return int, not unsigned;
3575 this is what was intended anyway, and it avoids undefined behavior.
3576 (CHARSET_OFFSET): Remove unused macro, instead of fixing its
3577 integer-overflow issues.
3578 (ENCODE_CHAR): Return unsigned on all hosts, not just on 32-bit hosts.
3579 Formerly, it returned EMACS_INT on 64-bit hosts in the common case
3580 where the argument is EMACS_INT, and this behavior is not intended.
d311d28c
PE
3581 * chartab.c (Fmake_char_table, Fset_char_table_range)
3582 (uniprop_get_decoder, uniprop_get_encoder):
3583 Don't assume fixnum fits in int.
3584 * cmds.c (move_point): New function, that does the gist of
3585 Fforward_char and Fbackward_char, but does so while checking
3586 for integer overflow more accurately.
c96e5d6a 3587 (Fforward_char, Fbackward_char): Use it.
d311d28c
PE
3588 (Fforward_line, Fend_of_line, internal_self_insert)
3589 (internal_self_insert):
3590 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3591 Fix a FIXME, by checking for integer overflow when calculating
3592 target_clm and actual_clm.
3593 * coding.c (detect_coding_XXX, encode_coding_XXX, CODING_DECODE_CHAR)
8f50130c 3594 (CODING_ENCODE_CHAR, CODING_CHAR_CHARSET, CODING_CHAR_CHARSET_P)
d311d28c
PE
3595 (ASSURE_DESTINATION, coding_alloc_by_realloc)
3596 (coding_alloc_by_making_gap, alloc_destination)
3597 (detect_coding_utf_8, encode_coding_utf_8, decode_coding_utf_16)
3598 (encode_coding_utf_16, detect_coding_emacs_mule)
3599 (decode_coding_emacs_mule, encode_coding_emacs_mule)
3600 (detect_coding_iso_2022, decode_coding_iso_2022)
3601 (encode_invocation_designation, encode_designation_at_bol)
3602 (encode_coding_iso_2022, detect_coding_sjis, detect_coding_big5)
3603 (decode_coding_sjis, decode_coding_big5, encode_coding_sjis)
3604 (encode_coding_big5, detect_coding_ccl, decode_coding_ccl)
3605 (encode_coding_ccl, encode_coding_raw_text)
3606 (detect_coding_charset, decode_coding_charset)
3607 (encode_coding_charset, detect_eol, decode_eol, produce_chars)
3608 (produce_composition, produce_charset, produce_annotation)
3609 (decode_coding, handle_composition_annotation)
3610 (handle_charset_annotation, consume_chars, decode_coding_gap)
3611 (decode_coding_object, encode_coding_object, detect_coding_system)
3612 (Ffind_coding_systems_region_internal, Fcheck_coding_systems_region)
3613 (code_convert_region, code_convert_string)
8f50130c
PE
3614 (Fdefine_coding_system_internal)
3615 (coding_set_source, coding_set_destination):
d311d28c
PE
3616 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3617 (setup_iso_safe_charsets, consume_chars, Funencodable_char_position)
3618 (Fdefine_coding_system_internal):
3619 Don't assume fixnums fit in int.
3620 (decode_coding_gap, decode_coding_object, encode_coding_object)
5895d7b9 3621 (Fread_coding_system, Fdetect_coding_region)
2c6a9faa
PE
3622 (Funencodable_char_position, Fcheck_coding_systems_region)
3623 (get_translation, handle_composition_annotation, consume_chars):
d311d28c 3624 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
977b0e45 3625 (consume_chars): Rewrite to not calculate an address outside buffer.
d311d28c 3626 (Ffind_operation_coding_system): NATNUMP can eval its arg twice.
7b09a37a 3627 Don't access memory outside of the args array.
d311d28c 3628 (Fdefine_coding_system_internal): Check for charset-id overflow.
47664caa
PE
3629 (ENCODE_ISO_CHARACTER): Use unsigned, not int, to store the unsigned
3630 result of ENCODE_CHAR.
d311d28c
PE
3631 * coding.h: Adjust decls to match defn changes elsewhere.
3632 (struct coding_system):
3633 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3634 * composite.c (get_composition_id, find_composition)
3635 (run_composition_function, update_compositions)
3636 (compose_text, composition_gstring_put_cache)
3637 (composition_gstring_p, composition_gstring_width)
3638 (fill_gstring_header, fill_gstring_body, autocmp_chars)
3639 (composition_compute_stop_pos, composition_reseat_it)
3640 (composition_update_it, struct position_record)
3641 (find_automatic_composition, composition_adjust_point)
3642 (Fcomposition_get_gstring, Ffind_composition_internal):
3643 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3644 (update_compositions):
3645 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3646 * composite.h: Adjust decls to match defn changes elsewhere.
3647 (struct composition):
3648 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3649 * data.c (let_shadows_buffer_binding_p, let_shadows_global_binding_p):
3650 Do not attempt to compute the address of the object just before a
3651 buffer; this is not portable.
3652 (Faref, Faset):
3653 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3654 (Faset): Use int, not EMACS_INT, where int is wide enough.
3655 (Fstring_to_number): Don't assume fixnums fit in int.
3656 (Frem): Don't assume arg is nonnegative.
3657 * dbusbind.c (xd_append_arg): Check for integers out of range.
3658 (Fdbus_call_method): Don't overflow the timeout int.
42b2a986 3659 (extract_signed, extract_unsigned): New functions.
243e0530
PE
3660 (XD_CHECK_DBUS_SERIAL): Remove; superseded by extract_unsigned.
3661 (xd_get_connection_references): Return ptrdiff_t, not int.
3662 All uses changed.
3663 (xd_signature, xd_append_arg, xd_retrieve_arg, Fdbus_message_internal)
3664 (xd_read_message_1):
3665 Use int, not unsigned, where the dbus API uses int.
3666 (Fdbus_message_internal): Don't overflow mtype.
3667 (syms_of_dbusbind): Allocate right-sized buffer for integers.
d311d28c
PE
3668 * dired.c (directory_files_internal, file_name_completion, scmp)
3669 (file_name_completion_stat):
3670 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3671 (file_name_completion): Don't overflow matchcount.
3672 (file_name_completion_stat): Use SAFE_ALLOCA, not alloca.
3673 * dispextern.h: Adjust decls to match defn changes elsewhere.
3674 (struct text_pos, struct glyph, struct bidi_saved_info)
3675 (struct bidi_string_data, struct bidi_it, struct composition_it)
3676 (struct it):
3677 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3678 (struct display_pos, struct composition_it, struct it):
3679 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3680 * dispnew.c (increment_matrix_positions)
3681 (increment_row_positions, mode_line_string)
3682 (marginal_area_string):
3683 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
54e1617f 3684 (change_frame_size_1, Fredisplay, Fframe_or_buffer_changed_p):
d311d28c
PE
3685 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3686 (duration_to_sec_usec): New function, to check for overflow better.
3687 (Fsleep_for, sit_for): Use it.
3688 * doc.c (get_doc_string, store_function_docstring):
3689 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3690 (get_doc_string, Fsnarf_documentation):
3691 Use int, not EMACS_INT, where int is wide enough.
3692 (get_doc_string):
3693 Use SAFE_ALLOCA, not alloca.
3694 Check for overflow when converting EMACS_INT to off_t.
3695 * doprnt.c (doprnt):
3696 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3697 * editfns.c (init_editfns, Fuser_uid, Fuser_real_uid):
3698 Don't assume uid_t fits into fixnum.
3699 (buildmark, Fgoto_char, overlays_around, find_field, Fdelete_field)
3700 (Ffield_string, Ffield_string_no_properties, Ffield_beginning)
3701 (Ffield_end, Fconstrain_to_field, Fline_beginning_position)
3702 (Fline_end_position, Fprevious_char, Fchar_after, Fchar_before)
3703 (general_insert_function)
3704 (Finsert_char, make_buffer_string, make_buffer_string_both)
3705 (update_buffer_properties, Fbuffer_substring)
3706 (Fbuffer_substring_no_properties, Fcompare_buffer_substrings)
3707 (Fsubst_char_in_region, check_translation)
3708 (Ftranslate_region_internal, save_restriction_restore, Fformat)
3709 (transpose_markers, Ftranspose_regions):
3710 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3711 (clip_to_bounds): Move to lisp.h as an inline function).
3712 (Fconstrain_to_field): Don't assume integers are nonnegative.
3713 (Fline_beginning_position, Fsave_excursion, Fsave_current_buffer):
3714 (Fsubst_char_in_region, Fsave_restriction):
3715 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3716 (Femacs_pid): Don't assume pid_t fits into fixnum.
3717 (lo_time): Use int, not EMACS_INT, when int suffices.
3718 (lisp_time_argument): Check for usec out of range.
3719 (Fencode_time): Don't assume fixnum fits in int.
3f4eabd1
PE
3720 (Fuser_login_name, Fuser_full_name): Signal an error
3721 if a uid argument is out of range, rather than relying on
3722 undefined behavior.
c8d5c857
PE
3723 (Fformat_time_string): Remove now-unnecessary check.
3724 lisp_time_argument checks for out-of-range usec now.
243e0530 3725 Use ptrdiff_t, not size_t, where ptrdiff_t will do.
d311d28c
PE
3726 * emacs.c (gdb_valbits, gdb_gctypebits): Now int, not EMACS_INT.
3727 (gdb_data_seg_bits): Now uintptr_t, not EMACS_INT.
3728 (PVEC_FLAG, gdb_array_mark_flag): Now ptrdiff_t, not EMACS_INT.
3729 (init_cmdargs, Fdump_emacs):
3730 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3731 (Fkill_emacs): Don't assume fixnum fits in int; instead, take just
3732 the bottom (typically) 32 bits of the fixnum.
3733 * eval.c (specpdl_size, call_debugger):
3734 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3735 (when_entered_debugger, Fbacktrace_debug):
3736 Don't assume fixnum can fit in int.
3737 (Fdefvaralias, Fdefvar): Do not attempt to compute the address of
3738 the object just before a buffer; this is not portable.
3739 (FletX, Flet, Funwind_protect, do_autoload, Feval, funcall_lambda)
3740 (grow_specpdl, unbind_to):
3741 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3742 (Fapply, apply_lambda): Don't assume ptrdiff_t can hold fixnum.
3743 (grow_specpdl): Simplify allocation by using xpalloc.
856bbc81 3744 (Fprog1, Fprog2): Don't assume list length fits in int. Simplify.
d311d28c
PE
3745 * fileio.c (Ffind_file_name_handler, Fcopy_file, Frename_file)
3746 (Finsert_file_contents, Fwrite_region, Fdo_auto_save):
3747 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3748 (Ffind_file_name_handler, non_regular_inserted, Finsert_file_contents)
3749 (a_write, e_write):
3750 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3751 (Fcopy_file, non_regular_nbytes, read_non_regular)
3752 (Finsert_file_contents):
3753 Use int, not EMACS_INT, where int is wide enough.
3754 (READ_BUF_SIZE): Verify that it fits in int.
3755 (Finsert_file_contents): Check that counts are in proper range,
3756 rather than assuming fixnums fit into ptrdiff_t etc.
3757 Don't assume fixnums fit into int.
125b3835 3758 * floatfns.c (Fexpt): Avoid undefined signed * signed overflow.
5895d7b9
PE
3759 * fns.c (Fcompare_strings, Fstring_lessp, struct textprop_rec, concat)
3760 (string_char_byte_cache_charpos, string_char_byte_cache_bytepos)
d311d28c
PE
3761 (string_char_to_byte, string_byte_to_char)
3762 (string_make_multibyte, string_to_multibyte)
3763 (string_make_unibyte, Fstring_as_unibyte, Fstring_as_multibyte)
3764 (Fstring_to_unibyte, Fsubstring, Fsubstring_no_properties)
3765 (substring_both, Fdelete, internal_equal, Ffillarray)
3766 (Fclear_string, mapcar1)
3767 (Fbase64_encode_region, Fbase64_encode_string, base64_encode_1)
3768 (Fbase64_decode_region, Fbase64_decode_string, base64_decode_1)
3769 (larger_vector, make_hash_table, maybe_resize_hash_table)
3770 (hash_lookup, hash_remove_from_table, hash_clear, sweep_weak_table)
3771 (Fmaphash, secure_hash):
3772 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3773 (concat): Check for string index and length overflow.
3774 (Fmapconcat): Don't assume fixnums fit into ptrdiff_t.
3775 (Frequire):
3776 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3777 (larger_vector): New API (vec, incr_min, size_max) replaces old
3778 one (vec, new_size, init). This catches size overflow.
3779 INIT was removed because it was always Qnil.
3780 All callers changed.
3781 (INDEX_SIZE_BOUND): New macro, which calculates more precisely
3782 the upper bound on a hash table index size.
3783 (make_hash_table, maybe_resize_hash_table): Use it.
3784 (secure_hash): Computer start_byte and end_byte only after
3785 they're known to be in ptrdiff_t range.
3786 * font.c (font_intern_prop, font_at, font_range, Ffont_shape_gstring)
3787 (Ffont_get_glyphs, Ffont_at):
3788 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3789 (font_style_to_value, font_prop_validate_style, font_expand_wildcards)
3790 (Flist_fonts, Fopen_font):
3791 Don't assume fixnum can fit in int.
3792 (check_gstring): Don't assume index can fit in int.
3793 (font_match_p): Check that fixnum is a character, not a nonnegative
3794 fixnum, since the later code needs to stuff it into an int.
3795 (font_find_for_lface): Use SAFE_ALLOCA_LISP, not alloca.
3796 (font_fill_lglyph_metrics): Use unsigned, not EMACS_INT, to avoid
3797 conversion overflow issues.
3798 (Fopen_font): Check for integer out of range.
3799 (Ffont_get_glyphs): Don't assume index can fit in int.
3800 * font.h: Adjust decls to match defn changes elsewhere.
3801 * fontset.c (reorder_font_vector): Redo score calculation to avoid
3802 integer overflow.
3803 (num_auto_fontsets, fontset_from_font): Use ptrdiff_t, not
3804 printmax_t, where ptrdiff_t is wide enough.
3805 (Finternal_char_font):
3806 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3807 * frame.c (Fset_mouse_position, Fset_mouse_pixel_position)
3808 (Fset_frame_height, Fset_frame_width, Fset_frame_size)
3809 (Fset_frame_position, x_set_frame_parameters)
3810 (x_set_line_spacing, x_set_border_width)
3811 (x_set_internal_border_width, x_set_alpha, x_figure_window_size):
3812 Check that fixnums are in proper range for system types.
3813 (frame_name_fnn_p, Fframe_parameter, Fmodify_frame_parameters):
3814 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3815 (Fmodify_frame_parameters): Don't assume fixnum fits in int.
3816 Use SAFE_ALLOCA_LISP, not alloca.
3817 * frame.h (struct frame): Use intptr_t, not EMACS_INT, where
3818 intptr_t is wide enough.
3819 * fringe.c (lookup_fringe_bitmap, get_logical_fringe_bitmap)
3820 (Fdefine_fringe_bitmap): Don't assume fixnum fits in int.
3821 (Ffringe_bitmaps_at_pos): Don't assume index fits in int.
3822 Check for fixnum out of range.
3823 * ftfont.c (ftfont_list): Don't assume index fits in int.
3824 Check that fixnums are in proper range for system types.
3825 (ftfont_shape_by_flt):
3826 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
d311d28c
PE
3827 * gnutls.c (emacs_gnutls_write, emacs_gnutls_read):
3828 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3829 (Fgnutls_error_fatalp, Fgnutls_error_string, Fgnutls_boot):
3830 Check that fixnums are in proper range for system types.
3831 * gnutls.h: Adjust decls to match defn changes elsewhere.
3832 * gtkutil.c (xg_dialog_run):
3833 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3834 (update_frame_tool_bar):
3835 Check that fixnums are in proper range for system types.
3836 * image.c (parse_image_spec): Redo count calculation to avoid overflow.
5895d7b9 3837 (lookup_image): Check that fixnums are in range for system types.
d311d28c
PE
3838 * indent.c (last_known_column, last_known_column_point):
3839 (current_column_bol_cache):
3840 (skip_invisible, current_column, check_display_width):
3841 (check_display_width, scan_for_column, current_column_1)
3842 (Findent_to, Fcurrent_indentation, position_indentation)
3843 (indented_beyond_p, Fmove_to_column, compute_motion):
3844 (Fcompute_motion, Fvertical_motion):
3845 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3846 (last_known_column_modified): Use EMACS_INT, not int.
3847 (check_display_width):
3848 (Fcompute_motion):
3849 Check that fixnums and floats are in proper range for system types.
3850 (compute_motion): Don't assume index or fixnum fits in int.
3851 (compute_motion, Fcompute_motion):
3852 Use int, not EMACS_INT, when it is wide enough.
3853 (vmotion): Omit local var start_hpos that is always 0; that way
3854 we don't need to worry about overflow in expressions involving it.
3855 * indent.h: Adjust decls to match defn changes elsewhere.
3856 (struct position):
3857 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3858 Use int, not EMACS_INT, where int is wide enough.
3859 Remove unused members ovstring_chars_done and tab_offset;
3860 all uses removed.
3861 * insdel.c (move_gap, move_gap_both, gap_left, gap_right)
3862 (adjust_markers_for_delete, adjust_markers_for_insert, adjust_point)
3863 (adjust_markers_for_replace, make_gap_larger, make_gap_smaller)
3864 (make_gap, copy_text, insert, insert_and_inherit)
3865 (insert_before_markers, insert_before_markers_and_inherit)
3866 (insert_1, count_combining_before, count_combining_after)
3867 (insert_1_both, insert_from_string)
3868 (insert_from_string_before_markers, insert_from_string_1)
3869 (insert_from_gap, insert_from_buffer, insert_from_buffer_1)
3870 (adjust_after_replace, adjust_after_insert, replace_range)
3871 (replace_range_2, del_range, del_range_1, del_range_byte)
3872 (del_range_both, del_range_2, modify_region)
3873 (prepare_to_modify_buffer, signal_before_change)
3874 (signal_after_change, Fcombine_after_change_execute):
3875 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3876 * intervals.c (traverse_intervals, rotate_right, rotate_left)
3877 (balance_an_interval, split_interval_right, split_interval_left)
3878 (find_interval, next_interval, update_interval)
3879 (adjust_intervals_for_insertion, delete_node, delete_interval)
3880 (interval_deletion_adjustment, adjust_intervals_for_deletion)
3881 (static_offset_intervals, offset_intervals)
3882 (merge_interval_right, merge_interval_left, make_new_interval)
3883 (graft_intervals_into_buffer, temp_set_point_both)
3884 (temp_set_point, set_point, adjust_for_invis_intang)
3885 (set_point_both, move_if_not_intangible, get_property_and_range)
3886 (get_local_map, copy_intervals, copy_intervals_to_string)
3887 (compare_string_intervals, set_intervals_multibyte_1):
3888 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3889 * intervals.h: Adjust decls to match defn changes elsewhere.
3890 (struct interval):
3891 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3892 * keyboard.c (this_command_key_count, this_single_command_key_start)
3893 (before_command_key_count, before_command_echo_length, echo_now)
3894 (echo_length, recursive_edit_1, Frecursive_edit, Ftrack_mouse)
3895 (command_loop_1, safe_run_hooks, read_char, timer_check_2)
3896 (menu_item_eval_property, read_key_sequence, Fread_key_sequence)
3897 (Fread_key_sequence_vector, Fexecute_extended_command, Fsuspend_emacs):
3898 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3899 (last_non_minibuf_size, last_point_position, echo_truncate)
3900 (command_loop_1, adjust_point_for_property, read_char, gen_help_event)
3901 (make_lispy_position, make_lispy_event, parse_modifiers_uncached)
3902 (parse_modifiers, modify_event_symbol, Fexecute_extended_command)
3903 (stuff_buffered_input):
3904 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3905 (last_auto_save, command_loop_1, read_char):
3906 Use EMACS_INT, not int, to avoid integer overflow.
3907 (record_char): Avoid overflow in total_keys computation.
3908 (parse_modifiers_uncached): Redo index calculation to avoid overflow.
3909 * keyboard.h: Adjust decls to match defn changes elsewhere.
3910 * keymap.c (Fdefine_key, Fcurrent_active_maps, accessible_keymaps_1)
3911 (Fkey_description, Fdescribe_vector, Flookup_key):
3912 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3913 (click_position): New function, to check that positions are in range.
3914 (Fcurrent_active_maps):
3915 (describe_command):
3916 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3917 (Faccessible_keymaps, Fkey_description):
3918 (preferred_sequence_p):
3919 Don't assume fixnum can fit into int.
3920 (Fkey_description): Use SAFE_ALLOCA_LISP, not alloca.
3921 Check for integer overflow in size calculations.
3922 (Ftext_char_description): Use CHECK_CHARACTER, not CHECK_NUMBER, to
3923 avoid mishandling large integers.
3924 * lisp.h: Adjust decls to match defn changes elsewhere.
3925 (ARRAY_MARK_FLAG, PSEUDOVECTOR_FLAG, struct Lisp_String)
3926 (struct vectorlike_header, struct Lisp_Subr, struct Lisp_Hash_Table)
3927 (struct Lisp_Marker):
3928 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3929 (clip_to_bounds): Now an inline function, moved here from editfns.c.
d311d28c
PE
3930 (GLYPH_CODE_P): Check for overflow in system types, subsuming the
3931 need for GLYPH_CODE_CHAR_VALID_P and doing proper checking ourselves.
3932 All callers changed.
3933 (GLYPH_CODE_CHAR, GLYPH_CODE_FACE):
3934 Assume the arg has valid form, since it always does.
3935 (TYPE_RANGED_INTEGERP): Avoid bug when checking against a wide
3936 unsigned integer system type.
3937 (CHECK_RANGED_INTEGER, CHECK_TYPE_RANGED_INTEGER): New macros.
3938 (struct catchtag, specpdl_size, SPECPDL_INDEX, USE_SAFE_ALLOCA):
3939 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3940 (struct catchtag): Use EMACS_INT, not int, since it may be a fixnum.
3941 (duration_to_sec_usec): New decl.
3942 * lread.c (read_from_string_index, read_from_string_index_byte)
3943 (read_from_string_limit, readchar, unreadchar, openp)
3944 (read_internal_start, read1, oblookup):
3945 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3946 (Fload, readevalloop, Feval_buffer, Feval_region):
3947 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3948 (openp): Check for out-of-range argument to 'access'.
3949 (read1): Use int, not EMACS_INT, where int is wide enough.
3950 Don't assume fixnum fits into int.
6efdadfd 3951 Fix off-by-one error that can read outside a buffer.
1ab7b8ac
PE
3952 (read_filtered_event): Use duration_to_sec_usec
3953 to do proper overflow checking on durations.
d311d28c
PE
3954 * macros.c (Fstart_kbd_macro): Use xpalloc to check for overflow
3955 in size calculation.
3956 (Fexecute_kbd_macro):
3957 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3958 * marker.c (cached_charpos, cached_bytepos, CONSIDER)
3959 (byte_char_debug_check, buf_charpos_to_bytepos, verify_bytepos)
3960 (buf_bytepos_to_charpos, Fset_marker, set_marker_restricted)
3961 (set_marker_both, set_marker_restricted_both, marker_position)
3962 (marker_byte_position, Fbuffer_has_markers_at):
3963 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3964 (Fset_marker, set_marker_restricted): Don't assume fixnum fits in int.
61b108cc 3965 * menu.c (ensure_menu_items): Rename from grow_menu_items.
d311d28c
PE
3966 It now merely ensures that the menu is large enough, without
3967 necessarily growing it, as this avoids some integer overflow issues.
3968 All callers changed.
3969 (keymap_panes, parse_single_submenu, Fx_popup_menu):
3970 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3971 (parse_single_submenu, Fx_popup_menu): Don't assume fixnum fits in int.
3972 Use SAFE_ALLOCA_LISP, not alloca.
3973 (find_and_return_menu_selection): Avoid unnecessary casts of pointers
3974 to EMACS_INT. Check that fixnums are in proper range for system types.
3975 * minibuf.c (minibuf_prompt_width, string_to_object)
3976 (Fminibuffer_contents, Fminibuffer_contents_no_properties)
3977 (Fminibuffer_completion_contents, Ftry_completion, Fall_completions):
3978 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3979 (get_minibuffer, read_minibuf_unwind):
3980 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3981 (read_minibuf): Omit unnecessary arg BACKUP_N, which is always nil;
3982 this simplifies overflow checking. All callers changed.
3983 (read_minibuf, Fread_buffer, Ftry_completion, Fall_completions)
3984 (Ftest_completion):
3985 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3986 * nsfns.m (check_ns_display_info): Don't assume fixnum fits in long.
3987 (x_set_menu_bar_lines, x_set_tool_bar_lines, Fx_create_frame):
3988 Check that fixnums are in proper range for system types.
3989 (Fx_create_frame, Fx_show_tip):
3990 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3991 * nsfont.m (ns_findfonts, nsfont_list_family):
3992 Don't assume fixnum fits in long.
3993 * nsmenu.m (ns_update_menubar, ns_menu_show, ns_popup_dialog):
3994 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3995 (ns_update_menubar): Use intptr_t, not EMACS_INT, when intptr_t is
3996 wide enough.
17fdb222 3997 * nsselect.m (ns_get_local_selection, clean_local_selection_data):
d311d28c
PE
3998 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3999 * print.c (print_buffer_size, print_buffer_pos, print_buffer_pos_byte)
4000 (PRINTDECLARE, PRINTPREPARE):
4001 (strout, print_string):
4002 (print, print_preprocess, print_check_string_charset_prop)
4003 (print_object):
4004 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
4005 (PRINTDECLARE):
4006 (temp_output_buffer_setup, Fprin1_to_string, print_object):
4007 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
4008 (PRINTPREPARE): Use int, not ptrdiff_t, where int is wide enough.
d311d28c 4009 (printchar, strout): Use xpalloc to catch size calculation overflow.
0fd11aa5 4010 (Fexternal_debugging_output): Don't overflow EMACS_INT->int conversion.
d311d28c
PE
4011 (print_error_message): Use SAFE_ALLOCA, not alloca.
4012 (print_object): Use int, not EMACS_INT, where int is wide enough.
a8b7caa3
PE
4013 (print_depth, new_backquote_output, print_number_index):
4014 Use ptrdiff_t, not int, where int might not be wide enough.
d311d28c
PE
4015 * process.c (Fdelete_process): Don't assume pid fits into EMACS_INT.
4016 (Fset_process_window_size, Fformat_network_address)
4017 (get_lisp_to_sockaddr_size, set_socket_option, Fmake_network_process)
d44287d4 4018 (sigchld_handler):
d311d28c 4019 Check that fixnums are in proper range for system types.
d44287d4 4020 (Fsignal_process): Simplify by avoiding a goto.
d83cf4cc
PE
4021 Check for process-ids out of pid_t range rather than relying on
4022 undefined behavior.
e4d81efc 4023 (process_tick, update_tick): Use EMACS_INT, not int.
d311d28c
PE
4024 (Fformat_network_address, read_process_output, send_process)
4025 (Fprocess_send_region, status_notify):
4026 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
4027 (Fformat_network_address, Fmake_serial_process, Fmake_network_process)
4028 (wait_reading_process_output, read_process_output, exec_sentinel):
4029 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
4030 (conv_lisp_to_sockaddr): Don't assume fixnums fit into int.
4031 (Faccept_process_output): Use duration_to_sec_usec to do proper
4032 overflow checking on durations.
dde14581
PE
4033 (emacs_get_tty_pgrp, Fprocess_running_child_p, process_send_signal):
4034 Don't assume pid_t fits in int.
02481186
PE
4035 * process.h (struct Lisp_Process): Members tick and update_tick
4036 are now of type EMACS_INT, not int.
b62b53e8
PE
4037 * puresize.h (PURESIZE_RATIO): Shrink this to 8/6 on 32-bit hosts
4038 configured --with-wide-int.
d311d28c
PE
4039 * scroll.c (calculate_scrolling, calculate_direct_scrolling)
4040 (line_ins_del): Use int, not EMACS_INT, where int is wide enough.
4041 * search.c (looking_at_1, string_match_1):
4042 (fast_string_match, fast_c_string_match_ignore_case)
4043 (fast_string_match_ignore_case, fast_looking_at, scan_buffer)
4044 (scan_newline, find_before_next_newline, search_command)
4045 (trivial_regexp_p, search_buffer, simple_search, boyer_moore)
4046 (set_search_regs, wordify):
4047 (Freplace_match):
4048 (Fmatch_data):
4049 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
4050 (string_match_1, search_buffer, set_search_regs):
4051 (Fmatch_data):
4052 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
4053 (wordify): Check for overflow in size calculation.
4054 (Freplace_match): Avoid potential buffer overflow in search_regs.start.
4055 (Fset_match_data): Don't assume fixnum fits in ptrdiff_t.
4056 Check that fixnums are in proper range for system types.
4057 * sound.c (struct sound_device)
4058 (wav_play, au_play, vox_write, alsa_period_size, alsa_write):
4059 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
4060 (Fplay_sound_internal):
4061 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
eacd378d 4062 * syntax.c (struct lisp_parse_state, find_start_modiff)
d311d28c
PE
4063 (Finternal_describe_syntax_value, scan_lists, scan_sexps_forward):
4064 (Fparse_partial_sexp):
4065 Don't assume fixnums can fit in int.
4066 (struct lisp_parse_state, find_start_pos, find_start_value)
4067 (find_start_value_byte, find_start_begv)
4068 (update_syntax_table, char_quoted, dec_bytepos)
4069 (find_defun_start, prev_char_comend_first, back_comment):
4070 (scan_words, skip_chars, skip_syntaxes, forw_comment, Fforward_comment)
4071 (scan_lists, Fbackward_prefix_chars, scan_sexps_forward):
4072 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
4073 (Finternal_describe_syntax_value): Check that match_lisp is a
4074 character, not an integer, since the code stuffs it into int.
4075 (scan_words, scan_sexps_forward):
4076 Check that fixnums are in proper range for system types.
4077 (Fforward_word):
4078 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
4079 (scan_sexps_forward):
4080 Use CHARACTERP, not INTEGERP, since the value must fit into int.
4081 (Fparse_partial_sexp): Fix doc; element 8 is not ignored.
4082 * syntax.h: Adjust decls to match defn changes elsewhere.
4083 (struct gl_state_s):
4084 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
e4ecdc9c
PE
4085 (SETUP_SYNTAX_TABLE_FOR_OBJECT): Use PTRDIFF_MAX, not
4086 MOST_POSITIVE_FIXNUM.
d311d28c
PE
4087 * sysdep.c (wait_for_termination_1, wait_for_termination)
4088 (interruptible_wait_for_termination, mkdir):
4089 Don't assume pid_t fits in int; on 64-bit AIX pid_t is 64-bit.
4090 (emacs_read, emacs_write):
4091 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
225a2cff
PE
4092 (system_process_attributes): Don't assume uid_t, gid_t, EMACS_INT,
4093 and double all fit in int.
d311d28c
PE
4094 * term.c (set_tty_color_mode):
4095 Check that fixnums are in proper range for system types.
4096 * termhooks.h (struct input_event):
4097 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
4098 * textprop.c (validate_interval_range, interval_of)
4099 (Fadd_text_properties, set_text_properties_1)
4100 (Fremove_text_properties, Fremove_list_of_text_properties)
4101 (Ftext_property_any, Ftext_property_not_all)
4102 (copy_text_properties, text_property_list, extend_property_ranges)
4103 (verify_interval_modification):
4104 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
4105 (Fnext_single_char_property_change)
4106 (Fprevious_single_char_property_change):
4107 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
5895d7b9
PE
4108 (copy_text_properties):
4109 Check for integer overflow in index calculation.
d311d28c
PE
4110 * undo.c (last_boundary_position, record_point, record_insert)
4111 (record_delete, record_marker_adjustment, record_change)
4112 (record_property_change):
4113 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
4114 (truncate_undo_list, Fprimitive_undo): Don't assume fixnum fits in int.
4115 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
4116 * w32fns.c (Fx_create_frame, x_create_tip_frame, Fx_show_tip)
4117 (Fx_hide_tip, Fx_file_dialog):
4118 * w32menu.c (set_frame_menubar):
4119 Use ptrdiff_t, not int, for consistency with rest of code.
4120 * window.c (window_scroll_preserve_hpos, window_scroll_preserve_vpos)
4121 (select_window, Fdelete_other_windows_internal)
4122 (window_scroll_pixel_based, window_scroll_line_based)
4123 (Frecenter, Fset_window_configuration):
4124 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
4125 (Fset_window_hscroll, run_window_configuration_change_hook)
4126 (set_window_buffer, temp_output_buffer_show, scroll_command)
5895d7b9 4127 (Fscroll_other_window, Frecenter):
d311d28c
PE
4128 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
4129 (Fwindow_line_height, window_scroll, Fscroll_left, Fscroll_right):
4130 Don't assume fixnum fits in int.
4131 (Fset_window_scroll_bars):
4132 Check that fixnums are in proper range for system types.
4133 * xdisp.c (help_echo_pos, pos_visible_p, string_pos_nchars_ahead)
4134 (string_pos, c_string_pos, number_of_chars, init_iterator)
4135 (in_ellipses_for_invisible_text_p, init_from_display_pos)
4136 (compute_stop_pos, next_overlay_change, compute_display_string_pos)
4137 (compute_display_string_end, handle_face_prop)
5895d7b9
PE
4138 (face_before_or_after_it_pos, handle_invisible_prop)
4139 (handle_display_prop, handle_display_spec, handle_single_display_spec)
d311d28c
PE
4140 (display_prop_intangible_p, string_buffer_position_lim)
4141 (string_buffer_position, handle_composition_prop, load_overlay_strings)
4142 (get_overlay_strings_1, get_overlay_strings)
4143 (iterate_out_of_display_property, forward_to_next_line_start)
4144 (back_to_previous_visible_line_start, reseat, reseat_to_string)
4145 (get_next_display_element, set_iterator_to_next)
4146 (get_visually_first_element, compute_stop_pos_backwards)
4147 (handle_stop_backwards, next_element_from_buffer)
4148 (move_it_in_display_line_to, move_it_in_display_line)
4149 (move_it_to, move_it_vertically_backward, move_it_by_lines)
4150 (add_to_log, message_dolog, message_log_check_duplicate)
4151 (message2, message2_nolog, message3, message3_nolog
4152 (with_echo_area_buffer, display_echo_area_1, resize_mini_window_1)
4153 (current_message_1, truncate_echo_area, truncate_message_1)
4154 (set_message, set_message_1, store_mode_line_noprop)
4155 (hscroll_window_tree, debug_delta, debug_delta_bytes, debug_end_vpos)
4156 (text_outside_line_unchanged_p, check_point_in_composition)
4157 (reconsider_clip_changes)
4158 (redisplay_internal, set_cursor_from_row, try_scrolling)
4159 (try_cursor_movement, set_vertical_scroll_bar, redisplay_window)
4160 (redisplay_window, find_last_unchanged_at_beg_row)
4161 (find_first_unchanged_at_end_row, row_containing_pos, try_window_id)
4162 (trailing_whitespace_p, find_row_edges, display_line)
4163 (RECORD_MAX_MIN_POS, Fcurrent_bidi_paragraph_direction)
4164 (display_mode_element, store_mode_line_string)
4165 (pint2str, pint2hrstr, decode_mode_spec)
4166 (display_count_lines, display_string, draw_glyphs)
4167 (x_produce_glyphs, x_insert_glyphs)
4168 (rows_from_pos_range, mouse_face_from_buffer_pos)
4169 (fast_find_string_pos, mouse_face_from_string_pos)
4170 (note_mode_line_or_margin_highlight, note_mouse_highlight):
4171 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
4172 (safe_call, init_from_display_pos, handle_fontified_prop)
4173 (handle_single_display_spec, load_overlay_strings)
4174 (with_echo_area_buffer, setup_echo_area_for_printing)
4175 (display_echo_area, echo_area_display)
4176 (x_consider_frame_title, prepare_menu_bars, update_menu_bar)
4177 (update_tool_bar, hscroll_window_tree, redisplay_internal)
5895d7b9
PE
4178 (redisplay_window, dump_glyph_row, display_mode_line)
4179 (Fformat_mode_line, decode_mode_spec, on_hot_spot_p):
43ad2e9a 4180 (handle_display_spec, display_prop_string_p):
d311d28c
PE
4181 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
4182 (handle_single_display_spec, build_desired_tool_bar_string)
4183 (redisplay_tool_bar, scroll_window_tree, Fdump_glyph_matrix)
4184 (get_specified_cursor_type):
4185 Check that fixnums are in proper range for system types.
4186 (struct overlay_entry, resize_mini_window, Fdump_glyph_row)
4187 (Flookup_image_map):
4188 Don't assume fixnums fit in int.
4189 (compare_overlay_entries):
4190 Avoid mishandling comparisons due to subtraction overflow.
4191 (load_overlay_strings): Use SAFE_NALLOCA, not alloca.
4192 (last_escape_glyph_face_id, last_glyphless_glyph_face_id):
4193 (handle_tool_bar_click):
4194 Use int, not unsigned, since we prefer signed and the signedness
4195 doesn't matter here.
4196 (get_next_display_element, next_element_from_display_vector):
4197 Use int, not EMACS_INT, when int is wide enough.
4198 (start_hourglass): Use duration_to_sec_usec to do proper
4199 overflow checking on durations.
4200 * xfaces.c (Fbitmap_spec_p):
4201 Check that fixnums are in proper range for system types.
4202 (compare_fonts_by_sort_order):
4203 Avoid mishandling comparisons due to subtraction overflow.
4204 (Fx_family_fonts, realize_basic_faces):
4205 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
4206 (Fx_family_fonts):
4207 Don't assume fixnum fits in int.
4208 Use SAFE_ALLOCA_LISP, not alloca.
4209 (merge_face_heights): Remove unnecessary cast to EMACS_INT.
4210 (Finternal_make_lisp_face): Don't allocate more than MAX_FACE_ID.
4211 (face_at_buffer_position, face_for_overlay_string)
4212 (face_at_string_position):
4213 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
4214 (merge_faces): Use int, not EMACS_INT, where int is wide enough.
4215 * xfns.c (x_set_menu_bar_lines, x_set_tool_bar_lines, x_icon_verify)
4216 (Fx_show_tip):
4217 Check that fixnums are in proper range for system types.
4218 (Fx_create_frame, x_create_tip_frame, Fx_show_tip)
4219 (Fx_hide_tip, Fx_file_dialog, Fx_select_font):
4220 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
4221 (Fx_change_window_property): Don't assume fixnums fit in int.
4222 * xfont.c (xfont_chars_supported):
4223 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
4224 * xmenu.c (Fx_popup_dialog, set_frame_menubar)
4225 (create_and_show_popup_menu, create_and_show_dialog, xmenu_show):
4226 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
4227 * xml.c (parse_region):
4228 * xrdb.c (magic_file_p):
4229 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
4230 * xselect.c (TRACE1): Don't assume pid_t promotes to int.
4231 (x_get_local_selection, x_reply_selection_request)
4232 (x_handle_selection_request, wait_for_property_change):
4233 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
4234 (selection_data_to_lisp_data): Use short, not EMACS_INT, where
4235 short is wide enough.
4236 (x_send_client_event): Don't assume fixnum fits in int.
4237 * xterm.c (x_x_to_emacs_modifiers):
4238 Don't assume EMACS_INT overflows nicely into int.
4239 (x_emacs_to_x_modifiers): Use EMACS_INT, not int, because values
4240 may come from Lisp.
4241 (handle_one_xevent): NATNUMP can eval its arg twice.
4242 (x_connection_closed):
4243 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
4244 * xterm.h: Adjust decls to match defn changes elsewhere.
4245 (struct scroll_bar): Use struct vectorlike_header
4246 rather than rolling our own approximation.
4247 (SCROLL_BAR_VEC_SIZE): Remove; not used.
4248
c6574eb5
GM
42492012-05-25 Glenn Morris <rgm@gnu.org>
4250
4251 * lisp.mk (lisp): Update for more files being compiled now.
4252
e8d32c7e
SM
42532012-05-25 Stefan Monnier <monnier@iro.umontreal.ca>
4254
48def666
SM
4255 * lread.c: Remove `read_pure' which makes no difference.
4256 (read_pure): Remove var.
4257 (unreadpure): Remove function.
4258 (readevalloop): Don't call read_list with -1 flag.
4259 (read1, read_vector): Don't test read_pure any more.
4260 (read_list): Simplify.
4261
e8d32c7e
SM
4262 * fileio.c, character.h: Minor style tweaks.
4263
4b2addb7
DA
42642012-05-24 Dmitry Antipov <dmantipov@yandex.ru>
4265
4266 * window.h (clip_changed): Remove useless declaration.
4267
584461b2
JB
42682012-05-22 Juanma Barranquero <lekktu@gmail.com>
4269
4270 * makefile.w32-in: Follow-up to 2012-05-22T16:20:27Z!eggert@cs.ucla.edu.
4271 (TAGS, TAGS-gmake, CONFIG_H): Remove further references to m/intel386.h.
4272
34374650
PE
42732012-05-22 Paul Eggert <eggert@cs.ucla.edu>
4274
4275 Remove src/m/*.
4276 This directory predates autoconf and is no longer needed nowadays.
4277 Move its few remaining bits of functionality to where they're needed.
4278 * m/README, m/alpha.h, m/amdx86-64.h, m/ia64.h, m/ibmrs6000.h:
4279 * m/ibms390x.h, m/intel386.h, m/m68k.h, m/macppc.h, m/sparc.h:
4280 * m/template.h: Remove.
4281 * Makefile.in (M_FILE): Remove. All uses removed.
4282 * alloc.c (POINTERS_MIGHT_HIDE_IN_OBJECTS):
4283 * lisp.h (USE_LSB_TAG):
4284 * mem-limits.h (EXCEEDS_LISP_PTR):
4285 Use VAL_MAX, not VALBITS, in #if.
4286 * lisp.h (EMACS_INT_MAX): New macro, useful in #if.
4287 (EMACS_UINT): Define unconditionally now.
4288 (BITS_PER_CHAR, BITS_PER_SHORT, BITS_PER_INT, BITS_PER_LONG)
4289 (BITS_PER_EMACS_INT): New constants, replacing
4290 what used to be in config.h, but not useful in #if.
4291 (GCTYPEBITS, VALBITS): Define unconditionally, since m/* files don't
4292 define them any more.
4293 (VAL_MAX): New macro.
4294 (VALMASK): Use it.
4295 * puresize.h (PURESIZE_RATIO): Use EMACS_INT_MAX, not
4296 BITS_PER_EMACS_INT, in #if.
4297 * s/aix4-2.h (BROKEN_FIONREAD, BROKEN_SIGAIO, BROKEN_SIGPTY)
4298 (BROKEN_SIGPOLL): Move here from m/ibmrs6000.h, which was removed.
4299 * s/gnu-linux.h (ULIMIT_BREAK_VALUE) [__i386__]:
4300 * s/ms-w32.h (DATA_START):
4301 Move here from removed file m/intel386.h.
4302 * s/gnu.h (NLIST_STRUCT): Remove undef; 'configure' does this.
4303 * s/irix6-5.h (_LP64): Remove; lisp.h no longer needs this.
4304
261cb4bb
PE
43052012-05-21 Paul Eggert <eggert@cs.ucla.edu>
4306
4307 Assume C89 or later.
4308 * alloc.c, buffer.c, lisp.h: Replace POINTER_TYPE with void.
4309 * alloc.c (overrun_check_malloc, overrun_check_realloc, xmalloc)
4310 (xrealloc):
4311 * buffer.c (mmap_free_1, mmap_enlarge): Omit needless casts.
4312 * editfns.c, fns.c, gmalloc.c, insdel.c, sysdep.c, termcap.c (NULL):
4313 * textprop.c, tparam.c (NULL): Remove.
4314 * ralloc.c, vm-limit.c (POINTER): Assume void * works.
4315 * regex.c (SIGN_EXTEND_CHAR): Assume signed char works.
4316 * regex.h (_RE_ARGS): Remove. All uses rewritten to use prototypes.
4317 * unexelf.c (ElfBitsW): Assume c89 preprocessor or better.
4318 * xterm.c (input_signal_count): Assume volatile works.
4319
ff23cd9f
KB
43202012-05-21 Ken Brown <kbrown@cornell.edu>
4321
4322 * xgselect.c (xg_select): Fix first argument in call to 'select'
4323 (bug#11508).
4324
1b170bc6
KB
43252012-05-20 Ken Brown <kbrown@cornell.edu>
4326
4327 * gmalloc.c (_free_internal_nolock, _realloc_internal_nolock)
bd7239f5 4328 [CYGWIN]: Cast ptr to (char *) before comparing to _heapbase.
1b170bc6 4329
b2f4d39f
KB
43302012-05-19 Ken Brown <kbrown@cornell.edu>
4331
4332 * xfns.c (x_in_use): Remove `static' qualifier.
4333 * xterm.h (x_in_use): Declare.
4334 * xgselect.c: Include xterm.h.
4335 (xg_select): Test `x_in_use' instead of `inhibit_window_system'
4336 and `display_arg' (bug#9754).
4337
003fdae2
PE
43382012-05-19 Paul Eggert <eggert@cs.ucla.edu>
4339
9232a6d9
PE
4340 * s/ms-w32.h (HAVE_GETDOMAINNAME): Remove; not needed.
4341
003fdae2
PE
4342 * m/vax.h: Remove; no longer needed since HAVE_FTIME is being removed.
4343 * s/ms-w32.h (HAVE_FTIME): Remove; not needed.
4344
784b56e2
EZ
43452012-05-18 Eli Zaretskii <eliz@gnu.org>
4346
4347 Fix compilation with -DGLYPH_DEBUG=1 on MS-Windows.
4348
4349 * w32term.c [GLYPH_DEBUG]: Add prototype for x_check_font.
090bd7cb 4350 (x_check_font) [GLYPH_DEBUG]: New function, copied from xterm.c.
784b56e2
EZ
4351
4352 * w32fns.c (unwind_create_frame) [GLYPH_DEBUG]: Fix broken
4353 reference to image_cache->refcount.
4354 (x_create_tip_frame): Fix broken use of FRAME_IMAGE_CACHE.
4355
a0a79cde
JL
43562012-05-17 Juri Linkov <juri@jurta.org>
4357
4358 * search.c (Fword_search_regexp, Fword_search_backward)
4359 (Fword_search_forward, Fword_search_backward_lax)
4360 (Fword_search_forward_lax): Move functions to isearch.el
4361 (bug#10145, bug#11381).
4362
b0572523
PE
43632012-05-16 Paul Eggert <eggert@cs.ucla.edu>
4364
4365 * xgselect.c (xg_select): Just invoke 'select' if -nw (Bug#9754).
4366
9660f5fc
SM
43672012-05-15 Stefan Monnier <monnier@iro.umontreal.ca>
4368
4369 * lread.c (init_obarray): Declare Qt and Qnil as special.
4370
4374de83
GM
43712012-05-14 Glenn Morris <rgm@gnu.org>
4372
4373 * nsterm.m (ns_init_paths): Fix typo ("libexec" not "lib-exec").
985584ae 4374 Put "libexec" before "bin", for the sake of init_callproc_1.
4374de83 4375
dc44c39a
PE
43762012-05-14 Paul Eggert <eggert@cs.ucla.edu>
4377
078c97cb
PE
4378 * keyboard.c (kbd_buffer_get_event) [!HAVE_DBUS]: Omit unused local.
4379
dc44c39a
PE
4380 * unexaix.c: Port to more-recent AIX compilers.
4381 (report_error, report_error_1, make_hdr, copy_sym)
4382 (mark_x, adjust_lnnoptrs, unrelocate_symbols):
4383 Make arguments const char *, not char *, to avoid violations of C
4384 standard and to fix some AIX warnings reported by Gilles Pion.
4385
e18afed7 43862012-05-14 Eli Zaretskii <eliz@gnu.org>
ac268e67
EZ
4387
4388 * xdisp.c (handle_stop): Don't call get_overlay_strings_1 if we
4389 already have overlays loaded.
4390 (handle_single_display_spec): Before returning without displaying
4391 fringe bitmap, synchronize the bidi iterator with the main display
4392 iterator, by calling iterate_out_of_display_property.
4393 (iterate_out_of_display_property): Detect buffer iteration by
4394 testing that it->string is a Lisp string.
4395 (get_next_display_element): When the current object is exhausted,
4396 and there's something on it->stack, call set_iterator_to_next to
4397 proceed with what's on the stack, instead of returning zero.
4398 (set_iterator_to_next): If called at the end of a Lisp string,
4399 proceed to consider_string_end without incrementing string
4400 position. Don't increment display vector index past the end of
4401 the display vector. (Bug#11417)
c8fb9dc6
EZ
4402 (pos_visible_p): Don't report a position visible when move_it_to
4403 stopped at the last line of window, which happens to be scanned
4404 backwards by the bidi iteration. (Bug#11464)
ac268e67 4405
e18afed7 44062012-05-14 Eli Zaretskii <eliz@gnu.org>
82f9b393
EZ
4407
4408 * xdisp.c (handle_single_display_spec): Return 1 for left-margin
4409 and right-margin display specs even if the spec is invalid or we
61b108cc
SM
4410 are on a TTY, and thus unable to display on the fringes.
4411 That's because the text with the property will not be displayed anyway,
82f9b393
EZ
4412 so we need to signal to the caller that this is a "replacing"
4413 display spec. This fixes display when the spec is invalid or we
4414 are on a TTY.
4415
e18afed7 44162012-05-14 Paul Eggert <eggert@cs.ucla.edu>
297834cd
PE
4417
4418 * unexaix.c (make_hdr): Fix typo in prototype.
4419 This bug broke the build on AIX. Problem reported by Gilles Pion.
4420
9d0a235a
MA
44212012-05-14 Michael Albinus <michael.albinus@gmx.de>
4422
4423 * keyboard.c (kbd_buffer_get_event): Read special events also in
4424 batch mode. (Bug#11415)
4425
9e6b06ed
GM
44262012-05-12 Glenn Morris <rgm@gnu.org>
4427
4428 * ns.mk: Update for ns_appbindir no longer having trailing "/".
4429
c1a1d7a3
EZ
44302012-05-12 Eli Zaretskii <eliz@gnu.org>
4431
4432 * lisp.mk (lisp): Add newcomment.elc.
4433
3fe7cdc8
GM
44342012-05-12 Glenn Morris <rgm@gnu.org>
4435
4436 * Makefile.in (MKDIR_P): New, set by configure.
4437 * ns.mk (${ns_appdir}, ${ns_appbindir}Emacs): Use $MKDIR_P.
4438
53f7d2c0
PE
44392012-05-11 Paul Eggert <eggert@cs.ucla.edu>
4440
4441 Remove unused function hourglass_started.
4442 * dispextern.h (hourglass_started):
4443 * w32fns.c (hourglass_started):
4444 * xdisp.c (hourglass_started): Remove.
4445
75aafb17
JB
44462012-05-10 Juanma Barranquero <lekktu@gmail.com>
4447
4448 * makefile.w32-in ($(BLD)/gmalloc.$(O), $(BLD)/w32menu.$(O)):
4449 Update dependencies.
4450
12959e8e
PE
44512012-05-10 Paul Eggert <eggert@cs.ucla.edu>
4452
97107e2e
PE
4453 * xgselect.c (xg_select): Put maxfds+1 into a var.
4454 This is slightly clearer, and pacifies Ubuntu 12.04 gcc.
4455
12959e8e
PE
4456 * sound.c (DEFAULT_ALSA_SOUND_DEVICE): Define only if HAVE_ALSA.
4457
836d29b3
DA
44582012-05-10 Dave Abrahams <dave@boostpro.com>
4459
4460 * filelock.c (syms_of_filelock): New boolean create-lockfiles.
4461 (lock_file): If create_lockfiles is 0, do nothing. (Bug#11227)
4462
5cb67954
MA
44632012-05-09 Michael Albinus <michael.albinus@gmx.de>
4464
4465 * dbusbind.c (xd_registered_buses): New internal Lisp object.
4466 Rename all occurences of Vdbus_registered_buses to xd_registered_buses.
4467 (syms_of_dbusbind): Remove declaration of Vdbus_registered_buses.
4468 Initialize xd_registered_buses.
4469
3478ec45
PE
44702012-05-09 Paul Eggert <eggert@cs.ucla.edu>
4471
b263a6b0
PE
4472 Untag more efficiently if USE_LSB_TAG.
4473 This is based on a proposal by YAMAMOTO Mitsuharu in
4474 <http://lists.gnu.org/archive/html/emacs-devel/2008-01/msg01876.html>.
4475 For an admittedly artificial (nth 8000 longlist) benchmark on
4476 Fedora 15 x86-64, this yields a 25% CPU speedup. Also, it shrinks
4477 Emacs's overall text size by 1%.
4478 * lisp.h (XUNTAG): New macro.
4479 (XCONS, XVECTOR, XSTRING, XSYMBOL, XFLOAT, XMISC, XPROCESS, XWINDOW)
4480 (XTERMINAL, XSUBR, XBUFFER, XCHAR_TABLE, XSUB_CHAR_TABLE, XBOOL_VECTOR)
4481 (XSETTYPED_PSEUDOVECTOR, XHASH_TABLE, TYPED_PSEUDOVECTORP): Use it.
4482 * eval.c (Fautoload):
4483 * font.h (XFONT_SPEC, XFONT_ENTITY, XFONT_OBJECT):
4484 * frame.h (XFRAME): Use XUNTAG.
4485
3478ec45
PE
4486 Port recent dbusbind.c changes to 32-bit --with-wide-int.
4487 * dbusbind.c (xd_append_arg, xd_retrieve_arg, Fdbus_message_internal):
4488 Remove unportable assumptions about print widths of types like
4489 dbus_uint32_t.
4490 (xd_get_connection_address, Fdbus_init_bus): Cast Emacs integer to
4491 intptr_t when converting between pointer and integer, to avoid GCC
4492 warnings about wrong width.
4493
666b903b 44942012-05-09 Eli Zaretskii <eliz@gnu.org>
0d887c7d
EZ
4495
4496 * w32proc.c (new_child): Force Windows to reserve only 64KB of
4497 stack for each reader_thread, instead of defaulting to 8MB
4498 determined by the linker. This avoids failures in creating
4499 subprocesses on Windows 7, see the discussion in this thread:
4500 http://lists.gnu.org/archive/html/emacs-devel/2012-03/msg00119.html.
4501
b120cc17
JC
45022012-05-07 Jérémy Compostella <jeremy.compostella@gmail.com>
4503
4504 Fix up display of the *Minibuf-0* buffer in the mini window.
4505 * keyboard.c (read_char): Don't clear the echo area if there's no
4506 message to clear.
4507 * xdisp.c (redisplay_internal): Redisplay the mini window (with the
2fed2689 4508 contents of *Minibuf-0*) if there's no message displayed in its stead.
b120cc17 4509
9a4b36f8
MA
45102012-05-07 Michael Albinus <michael.albinus@gmx.de>
4511
4512 * dbusbind.c (XD_DEBUG_MESSAGE): Don't print message twice in
4513 batch mode.
4514
e5f9458f
CY
45152012-05-06 Chong Yidong <cyd@gnu.org>
4516
4517 * lisp.mk (lisp): Update.
4518
eceeb5fc 45192012-05-05 Jim Meyering <meyering@redhat.com>
bf98199c
JM
4520
4521 * w32font.c (fill_in_logfont): NUL-terminate a string (Bug#11372).
4522
71873e2b
SM
45232012-05-04 Stefan Monnier <monnier@iro.umontreal.ca>
4524
4525 * data.c (PUT_ERROR): New macro.
4526 (syms_of_data): Use it. Add new error type `user-error'.
4527 * undo.c (user_error): New function.
4528 (Fprimitive_undo): Use it.
4529 * print.c (print_error_message): Adjust print style for `user-error'.
4530 * keyboard.c (user_error): New function.
4531 (Fexit_recursive_edit, Fabort_recursive_edit): Use it.
4532
ab0fa4e4
PE
45332012-05-03 Paul Eggert <eggert@cs.ucla.edu>
4534
4535 Do not limit current-time-string to years 1000..9999.
4536 * editfns.c (TM_YEAR_IN_ASCTIME_RANGE): Remove.
4537 (Fcurrent_time_string): Support any year that is supported by the
4538 underlying localtime representation. Don't use asctime, as it
4539 has undefined behavior for years outside the range -999..9999.
4540
7ed806a7
PE
45412012-05-02 Paul Eggert <eggert@cs.ucla.edu>
4542
4543 Fix race conditions involving setenv, gmtime, localtime, asctime.
4544 Without this fix, interrupts could mess up code that uses these
4545 nonreentrant functions, since setting TZ invalidates existing
4546 tm_zone or tzname values, and since most of these functions return
4547 pointers to static storage.
4548 * editfns.c (format_time_string, Fdecode_time, Fencode_time)
4549 (Fcurrent_time_string, Fcurrent_time_zone, Fset_time_zone_rule):
4550 Grow the critical sections to include not just invoking
4551 localtime/gmtime, but also accessing these functions' results
4552 including their tm_zone values if any, and any related TZ setting.
4553 (format_time_string): Last arg is now struct tm *, not struct tm **,
71873e2b
SM
4554 so that the struct tm is saved in the critical section.
4555 All callers changed. Simplify allocation of initial buffer, partly
7ed806a7
PE
4556 motivated by the fact that memory allocation needs to be outside
4557 the critical section.
4558
0c16dfed
DA
45592012-05-02 Dmitry Antipov <dmantipov@yandex.ru>
4560
4561 * intervals.c (adjust_intervals_for_insertion): Initialize `newi'
4562 with RESET_INTERVAL.
4563
4564 * buffer.c (Fget_buffer_create, Fmake_indirect_buffer):
4565 Remove duplicated buffer name initialization.
4566
3f83ace8
JM
45672012-05-02 Jim Meyering <jim@meyering.net>
4568
4569 * xterm.c (x_term_init): Use memcpy instead of strncpy (Bug#11373).
4570
c7b8541e
JM
4571 * xfns.c (x_window): Use xstrdup (Bug#11375).
4572
90207a15 45732012-05-02 Eli Zaretskii <eliz@gnu.org>
2fa85638
EZ
4574
4575 * xdisp.c (pos_visible_p): If already at a newline from the
4576 display string before the 'while' loop, don't walk back the glyphs
4577 from it3.glyph_row. Solves assertion violation when the display
4578 string begins with a newline (egg.el). (Bug#11367)
4579
b593d6a9
AH
45802012-05-01 Stefan Monnier <monnier@iro.umontreal.ca>
4581
4582 * keyboard.c (Fexecute_extended_command, Vsuggest_key_bindings):
4583 Move to simple.el.
4584
4737362e
GM
45852012-05-01 Glenn Morris <rgm@gnu.org>
4586
99cf43f9
GM
4587 * syssignal.h: Remove reference to BROKEN_SIGINFO (last used in
4588 s/ptx4.h), BROKEN_SIGTSTP (last used in m/ustation.h, m/dpx2.h),
4589 and BROKEN_SIGURG (was in s/gnu-linux.h prior to 2008-02-10).
4590 All were removed before 23.1.
4591
9311dcff
GM
4592 * dispnew.c: Remove HAVE_LIBNCURSES test;
4593 it is always true on relevant platforms.
4594
4d5c6349
GM
4595 * Makefile.in (LD_SWITCH_X_SITE_RPATH):
4596 Rename from LD_SWITCH_X_SITE_AUX_RPATH.
4597
4737362e
GM
4598 * Makefile.in (LD_SWITCH_X_SITE_AUX): Remove; no longer used.
4599
74dd3a6b
AS
46002012-04-30 Andreas Schwab <schwab@linux-m68k.org>
4601
4602 * .gdbinit (xpr): Remove checks for no longer existing misc types.
4603 (xintfwd, xboolfwd, xobjfwd, xbufobjfwd, xkbobjfwd, xbuflocal):
4604 Remove.
4605
13c379ee
PE
46062012-04-28 Paul Eggert <eggert@cs.ucla.edu>
4607
4608 Do not avoid creating empty evaporating overlays (Bug#9642).
4609 * buffer.c (Fmove_overlay): Revert the change of 2012-04-23.
4610 That is, do not delete an evaporating overlay if it becomes
4611 empty after its bounds are adjusted to fit within its buffer.
4612 This fix caused other problems, and I'm reverting it until we get
4613 to the bottom of them.
4614
a8e7d6d7 46152012-04-27 Chong Yidong <cyd@gnu.org>
9be2fd9b
CY
4616
4617 * xselect.c (x_convert_selection): Initialize a pointer (Bug#11315).
4618
a8e7d6d7 46192012-04-27 Eli Zaretskii <eliz@gnu.org>
f0ee99a0
EZ
4620
4621 * xdisp.c (pos_visible_p): If the window start position is beyond
4622 ZV, start the display from buffer beginning. Prevents assertion
4623 violation in init_iterator when the minibuffer window is scrolled
4624 via the scroll bar.
4625
4626 * window.c (window_scroll_pixel_based): Likewise.
4627
a8e7d6d7 46282012-04-27 Chong Yidong <cyd@gnu.org>
9ec7751f
CY
4629
4630 * keymap.c (where_is_internal): Doc fix (Bug#10872).
4631
a8e7d6d7 46322012-04-27 Glenn Morris <rgm@gnu.org>
24c51a09
GM
4633
4634 * fileio.c (Fcopy_file, Fset_file_selinux_context):
4635 Ignore ENOTSUP failures from setfilecon functions. (Bug#11245)
4636
a8e7d6d7 46372012-04-27 Eli Zaretskii <eliz@gnu.org>
73055685 4638
b593d6a9
AH
4639 * dispnew.c (swap_glyph_pointers, copy_row_except_pointers):
4640 Don't overrun array limits of glyph row's used[] array. (Bug#11288)
73055685 4641
1c6900d9
EZ
46422012-04-26 Eli Zaretskii <eliz@gnu.org>
4643
4c3fa1d9
EZ
4644 * xdisp.c (IT_DISPLAYING_WHITESPACE): In addition to the loaded
4645 display element, check also the underlying string or buffer
4646 character. (Bug#11341)
4647
1c6900d9
EZ
4648 * w32menu.c: Include w32heap.h.
4649 (add_menu_item): If the call to AppendMenuW (via
4650 unicode_append_menu) fails, disable Unicode menus only if we are
4651 running on Windows 9X/Me.
4652
42bf8205
AS
46532012-04-24 Andreas Schwab <schwab@linux-m68k.org>
4654
4655 * .gdbinit (xpr): Handle USE_2_TAGS_FOR_INTS.
4656 (xgetint): Add missing shift for LSB tags.
4657
b1bac16e
MR
46582012-04-24 Martin Rudalics <rudalics@gmx.at>
4659
4660 * keyboard.c (read_char): Don't wipe echo area for select window
4661 events: These might get delayed via `mouse-autoselect-window'
4662 (Bug#11304).
4663
d69621cc
JB
46642012-04-24 Juanma Barranquero <lekktu@gmail.com>
4665
4666 * gnutls.c (init_gnutls_functions): Protect against (unlikely)
4667 manipulation of :loaded-from data.
4668
02fd101b
JB
46692012-04-23 Juanma Barranquero <lekktu@gmail.com>
4670
4671 * gnutls.c (init_gnutls_functions): The value of :loaded-from is
4672 now a cons (bug#11311).
4673
888bec30
PE
46742012-04-23 Paul Eggert <eggert@cs.ucla.edu>
4675
89a438bd
PE
4676 Do not create empty overlays with the evaporate property (Bug#9642).
4677 * buffer.c (Fmove_overlay): Delete an evaporating overlay
4678 if it becomes empty after its bounds are adjusted to fit within
4679 its buffer. Without this fix, in a nonempty buffer (let ((o
4680 (make-overlay 1 2))) (overlay-put o 'evaporate t) (move-overlay o 0 1))
4681 yields an empty overlay that has the evaporate property, which is
4682 not supposed to happen.
4683
1068fe4d
PE
4684 Fix minor GTK3 problems found by static checking.
4685 * emacsgtkfixed.c (EMACS_TYPE_FIXED, EMACS_FIXED, EmacsFixed)
4686 (EmacsFixedPrivate, EmacsFixedClass, struct _EmacsFixed)
4687 (struct _EmacsFixedClass, emacs_fixed_get_type):
4688 Move decls here from emacsgtkfixed.h, since they needn't be public.
4689 (emacs_fixed_get_type): Now static.
4690 (emacs_fixed_class_init): Omit unused local.
4691 (emacs_fixed_child_type): Remove; unused.
4692 * emacsgtkfixed.h (EMACS_TYPE_FIXED, EMACS_FIXED, EmacsFixed)
4693 (EmacsFixedPrivate, EmacsFixedClass, struct _EmacsFixed)
4694 (struct _EmacsFixedClass): Move to emacsgtkfixed.c.
4695 (EMACS_FIXED_CLASS, EMACS_IS_FIXED, EMACS_IS_FIXED_CLASS)
4696 (EMACS_FIXED_GET_CLASS): Remove; unused.
4697 * gtkutil.c (xg_create_frame_widgets) [!HAVE_GTK3]: Omit unused local.
4698
888bec30
PE
4699 * keyboard.c (handle_async_input): Define only if SYNC_INPUT || SIGIO.
4700 Problem reported by Juanma Barranquero for Windows -Wunused-function.
4701
de85e130
PE
47022012-04-22 Paul Eggert <eggert@cs.ucla.edu>
4703
d0baac98 4704 Modernize and clean up gmalloc.c to assume C89 (Bug#9119).
bd7239f5 4705 * gmalloc.c (_MALLOC_INTERNAL, _MALLOC_H, _PP, __ptr_t)
d0baac98
PE
4706 (__malloc_size_t, __malloc_ptrdiff_t):
4707 Remove. All uses removed, replaced by the definiens if needed,
4708 since we can assume C89 or better now.
4709 Include <stdint.h>, for PTRDIFF_MAX, uintptr_t.
4710 (protect_malloc_state, align, get_contiguous_space)
4711 (malloc_atfork_handler_prepare, malloc_atfork_handler_parent)
4712 (malloc_atfork_handler_child, malloc_enable_thread)
4713 (malloc_initialize_1, __malloc_initialize, morecore_nolock)
4714 (_malloc_internal_nolock, _malloc_internal, malloc, _malloc)
4715 (_free, _realloc, _free_internal_nolock, _free_internal, free, cfree)
4716 (special_realloc, _realloc_internal_nolock, _realloc_internal)
4717 (realloc, calloc, __default_morecore, memalign, valloc, checkhdr)
4718 (freehook, mallochook, reallochook, mabort, mcheck, mprobe):
4719 Define using prototypes, not old style.
4720 (align, _malloc_internal_nolock, _free_internal_nolock, memalign):
4721 Don't assume ptrdiff_t and uintptr_t are no wider than unsigned long.
4722 (align): Don't assume that signed integer overflow wraps around.
4723 Omit unused local var.
4724 (malloc_initialize_1, morecore_nolock, _malloc_internal_nolock)
4725 (_free_internal_nolock, memalign, mallochook, reallochook):
4726 Omit no-longer-needed casts.
4727 (valloc): Use getpagesize, not __getpagesize.
4728 (MAGICWORD, MAGICFREE): Now randomish size_t values, not 32-bit.
4729 (struct hdr): The 'magic' member is now size_t, not unsigned long.
4730
de85e130
PE
4731 * dbusbind.c (XD_DBUS_VALIDATE_OBJECT): Define only if needed.
4732
dcbf5805
MA
47332012-04-22 Michael Albinus <michael.albinus@gmx.de>
4734
4735 Move functions from C to Lisp. Make non-blocking method calls
4736 the default. Implement further D-Bus standard interfaces.
4737
4738 * dbusbind.c (DBUS_NUM_MESSAGE_TYPES): Declare.
4739 (QCdbus_request_name_allow_replacement)
4740 (QCdbus_request_name_replace_existing)
4741 (QCdbus_request_name_do_not_queue)
4742 (QCdbus_request_name_reply_primary_owner)
4743 (QCdbus_request_name_reply_in_queue)
4744 (QCdbus_request_name_reply_exists)
4745 (QCdbus_request_name_reply_already_owner): Move to dbus.el.
4746 (QCdbus_registered_serial, QCdbus_registered_method)
4747 (QCdbus_registered_signal): New Lisp objects.
4748 (XD_DEBUG_MESSAGE): Use sizeof.
4749 (XD_MESSAGE_TYPE_TO_STRING, XD_OBJECT_TO_STRING)
4750 (XD_DBUS_VALIDATE_BUS_ADDRESS, XD_DBUS_VALIDATE_OBJECT)
4751 (XD_DBUS_VALIDATE_BUS_NAME, XD_DBUS_VALIDATE_PATH)
4752 (XD_DBUS_VALIDATE_INTERFACE, XD_DBUS_VALIDATE_MEMBER): New macros.
4753 (XD_CHECK_DBUS_SERIAL): Rename from CHECK_DBUS_SERIAL_GET_SERIAL.
4754 (xd_signature, xd_append_arg): Allow float for integer types.
4755 (xd_get_connection_references): New function.
b593d6a9
AH
4756 (xd_get_connection_address): Rename from xd_initialize.
4757 Return cached address.
dcbf5805
MA
4758 (xd_remove_watch): Do not unset $DBUS_SESSION_BUS_ADDRESS.
4759 (xd_close_bus): Rename from Fdbus_close_bus. Not needed on Lisp
4760 level.
4761 (Fdbus_init_bus): New optional arg PRIVATE. Cache address.
9a4b36f8 4762 Return number of refcounts.
dcbf5805
MA
4763 (Fdbus_get_unique_name): Make stronger parameter check.
4764 (Fdbus_message_internal): New defun.
4765 (Fdbus_call_method, Fdbus_call_method_asynchronously)
4766 (Fdbus_method_return_internal, Fdbus_method_error_internal)
4767 (Fdbus_send_signal, Fdbus_register_service)
4768 (Fdbus_register_signal, Fdbus_register_method): Move to dbus.el.
4769 (xd_read_message_1): Obey new structure of Vdbus_registered_objects.
4770 (xd_read_queued_messages): Obey new structure of Vdbus_registered_buses.
4771 (Vdbus_compiled_version, Vdbus_runtime_version)
4772 (Vdbus_message_type_invalid, Vdbus_message_type_method_call)
4773 (Vdbus_message_type_method_return, Vdbus_message_type_error)
4774 (Vdbus_message_type_signal): New defvars.
b593d6a9
AH
4775 (Vdbus_registered_buses, Vdbus_registered_objects_table):
4776 Adapt docstring.
dcbf5805 4777
52828e02
PE
47782012-04-22 Paul Eggert <eggert@cs.ucla.edu>
4779
da05bc4c
PE
4780 Fix GC_MALLOC_CHECK debugging output on 64-bit hosts.
4781 * alloc.c (emacs_blocked_malloc) [GC_MALLOC_CHECK]:
4782 Do not assume ptrdiff_t is the same width as 'int'.
4783
52828e02
PE
4784 * alloc.c: Handle unusual debugging option combinations.
4785 (GC_CHECK_MARKED_OBJECTS): Undef if ! GC_MARK_STACK,
4786 since the two debugging options are incompatible.
4787 (GC_MALLOC_CHECK): Similarly, undef if GC_CHECK_MARKED_OBJECTS
4788 is defined.
4789 (mem_init, mem_insert, mem_insert_fixup):
4790 Define if GC_MARK_STACK || GC_MALLOC_CHECK.
4791 (NEED_MEM_INSERT): Remove; no longer needed.
4792
f01769f9
LL
47932012-04-22 Leo Liu <sdl.web@gmail.com>
4794
4795 * sysdep.c (list_system_processes): Support Darwin (Bug#5725).
4796
5790543d
PE
47972012-04-22 Paul Eggert <eggert@cs.ucla.edu>
4798
4799 * sysdep.c [__FreeBSD__]: Minor cleanups.
4800 (list_system_processes, system_process_attributes) [__FreeBSD__]:
4801 Use Emacs indenting style more consistently. Avoid some casts.
4802 Use 'double' consistently rather than mixing 'float' and 'double'.
4803
b91b7e4d
EW
48042012-04-21 Eduard Wiebe <usenet@pusto.de>
4805
b593d6a9
AH
4806 * sysdep.c (list_system_processes, system_process_attributes):
4807 Add implementation for FreeBSD (Bug#5243).
b91b7e4d 4808
6114eb15
AS
48092012-04-21 Andreas Schwab <schwab@linux-m68k.org>
4810
4811 * lisp.mk (lisp): Update.
4812
2f38dff7
PE
48132012-04-20 Paul Eggert <eggert@cs.ucla.edu>
4814
4815 * keyboard.c (process_pending_signals): Define only if SYNC_INPUT.
4816 It is never used otherwise.
4817
4ae29f89
SM
48182012-04-20 Stefan Monnier <monnier@iro.umontreal.ca>
4819
4820 * print.c (print_preprocess): Only check print_depth if print-circle
4821 is nil.
4822 (print_object): Check for cycles even when print-circle is nil and
4823 print-gensym is t, but only check print_depth if print-circle is nil.
4824
f30d612a
CY
48252012-04-20 Chong Yidong <cyd@gnu.org>
4826
4827 * process.c (wait_reading_process_output): If EIO occurs on a pty,
4828 set the status to "failed" and ensure that sentinel is run.
4829
c07a4c0b 48302012-04-20 Glenn Morris <rgm@gnu.org>
016a35df
GM
4831
4832 * process.c (Fset_process_inherit_coding_system_flag)
4833 (Fset_process_query_on_exit_flag): Doc fix (mention return value).
4373fd43 4834 (Fmake_network_process, Fmake_serial_process): Doc fix.
016a35df 4835
c07a4c0b 48362012-04-20 Eli Zaretskii <eliz@gnu.org>
20a68157
EZ
4837
4838 * xdisp.c (string_buffer_position_lim): Limit starting position to
4839 BEGV.
4840 (set_cursor_from_row): If called for a mode-line or header-line
4841 row, return zero immediately.
4842 (try_cursor_movement): If inside continuation line, don't back up
4ae29f89
SM
4843 farther than the first row after the header line, if any.
4844 Don't consider the header-line row as "partially visible", even if
20a68157
EZ
4845 MATRIX_ROW_PARTIALLY_VISIBLE_P returns non-zero. (Bug#11261)
4846
c07a4c0b 48472012-04-20 Atsuo Ohki <ohki@gssm.otsuka.tsukuba.ac.jp> (tiny change)
ad3a2b41 4848
4ae29f89
SM
4849 * lread.c (lisp_file_lexically_bound_p): Fix hang at ";-*-\n"
4850 (bug#11238).
ad3a2b41 4851
c07a4c0b 48522012-04-20 Teodor Zlatanov <tzz@lifelogs.com>
6c94c34f 48532012-04-18 Paul Eggert <eggert@cs.ucla.edu>
ae6e112d
PE
4854
4855 configure: new option --enable-gcc-warnings (Bug#11207)
4856 * Makefile.in (C_WARNINGS_SWITCH): Remove.
4857 (WARN_CFLAGS, WERROR_CFLAGS): New macros.
4858 (ALL_CFLAGS): Use new macros rather than old.
4859 * process.c: Ignore -Wstrict-overflow to work around GCC bug 52904.
4860 * regex.c: Ignore -Wstrict-overflow. If !emacs, also ignore
4861 -Wunused-but-set-variable, -Wunused-function, -Wunused-macros,
4862 -Wunused-result, -Wunused-variable. This should go away once
4863 the Emacs and Gnulib regex code is merged.
4864 (xmalloc, xrealloc): Now static.
4865
aba027e8
PE
48662012-04-17 Paul Eggert <eggert@cs.ucla.edu>
4867
4868 * dired.c (Fsystem_groups): Remove unused local.
4869
e5a36063
GM
48702012-04-17 Glenn Morris <rgm@gnu.org>
4871
4872 * dired.c (Fsystem_users): Doc fix.
4873
316411f0
DA
48742012-04-17 Dmitry Antipov <dmantipov@yandex.ru>
4875
4876 * dired.c (Fsystem_users, Fsystem_groups): New functions. (Bug#7900)
4877 (syms_of_dired): Add them.
4878
9426aba4
PE
48792012-04-16 Paul Eggert <eggert@cs.ucla.edu>
4880
b62a57be
PE
4881 Fix minor alloc.c problems found by static checking.
4882 * alloc.c (_malloc_internal, _free_internal) [!DOUG_LEA_MALLOC]:
4883 New extern decls, to avoid calling undeclared functions.
4884 (dont_register_blocks): Define if ((!SYSTEM_MALLOC && !SYNC_INPUT)
4885 && GC_MALLOC_CHECK), not if ((GC_MARK_STACK || defined
4886 GC_MALLOC_CHECK) && GC_MALLOC_CHECK), to match when it's used.
4887 (NEED_MEM_INSERT): New macro.
4888 (mem_insert, mem_insert_fixup) [!NEED_MEM_INSERT]: Remove; unused.
4b5afbb0 4889 Remove one incorrect comment and fix another.
b62a57be 4890
3539f31f
PE
4891 Fix minor ralloc.c problems found by static checking.
4892 See http://lists.gnu.org/archive/html/emacs-devel/2011-12/msg00720.html
4893 * ralloc.c (ALIGNED, ROUND_TO_PAGE, HEAP_PTR_SIZE)
4894 (r_alloc_size_in_use, r_alloc_freeze, r_alloc_thaw): Remove; unused.
4895 (r_alloc_sbrk): Now static.
4896
a041960a
PE
4897 Improve ralloc.c interface checking.
4898 See http://lists.gnu.org/archive/html/emacs-devel/2011-12/msg00720.html
4899 * buffer.c (ralloc_reset_variable, r_alloc, r_re_alloc)
4900 (r_alloc_free) [REL_ALLOC]: Move decls from here ...
4901 * lisp.h (r_alloc, r_alloc_free, r_re_alloc, r_alloc_reset_variable)
4902 [REL_ALLOC]: ... to here, to check interface.
4903 * m/ia64.h (r_alloc, r_alloc_free) [REL_ALLOC && !_MALLOC_INTERNAL]:
4904 Remove decls. This fixes an "It stinks!".
4905
9426aba4
PE
4906 * alloc.c (which_symbols): Fix alignment issue / type clash.
4907
d55c12ed
AS
49082012-04-15 Andreas Schwab <schwab@linux-m68k.org>
4909
4910 * lisp.h (struct Lisp_Symbol): Remove explicit padding.
4911 (struct Lisp_Misc_Any): Likewise.
4912 (struct Lisp_Free): Likewise.
4913 * alloc.c (union aligned_Lisp_Symbol): Define.
4914 (SYMBOL_BLOCK_SIZE, struct symbol_block): Use union
4915 aligned_Lisp_Symbol instead of struct Lisp_Symbol.
4916 (union aligned_Lisp_Misc): Define.
4917 (MARKER_BLOCK_SIZE, struct marker_block): Use union
4918 aligned_Lisp_Misc instead of union Lisp_Misc.
4ae29f89 4919 (Fmake_symbol, allocate_misc, gc_sweep): Adjust.
d55c12ed 4920
b948ce8b
PE
49212012-04-14 Paul Eggert <eggert@cs.ucla.edu>
4922
4923 Make GC_MAKE_GCPROS_NOOPS the default (Bug#9926).
4924 * lisp.h (GC_MARK_STACK): Default to GC_MAKE_GCPROS_NOOPS.
4925 * s/cygwin.h, s/darwin.h, s/freebsd.h, s/gnu.h, s/irix6-5.h, s/msdos.h:
4926 * s/netbsd.h, s/sol2-6.h:
4927 Remove definition of GC_MARK_STACK, since the default now works.
4928 * s/aix4-2.h, s/hpux10-20.h, s/unixware.h:
4929 Define GC_MARK_STACK to GC_USE_GCPROS_AS_BEFORE, since that's
4930 no longer the default.
4931 * s/gnu-linux.h (GC_MARK_STACK): Adjust to change in default.
4932
35dc09a1 49332012-04-14 Atsuo Ohki <ohki@gssm.otsuka.tsukuba.ac.jp> (tiny change)
ad3a2b41 4934
35dc09a1
GM
4935 * lread.c (lisp_file_lexically_bound_p):
4936 Fix hang at ";-*-\n" (bug#11238).
ad3a2b41 4937
35dc09a1
GM
49382012-04-14 Eli Zaretskii <eliz@gnu.org>
4939
4940 * xdisp.c (find_last_unchanged_at_beg_row): Don't consider a row
4941 "unchanged" if its end.pos is beyond ZV. (Bug#11199)
4942
49432012-04-14 Jan Djärv <jan.h.d@swipnet.se>
4944
4945 * nsterm.m (constrainFrameRect): Always constrain when there is only
4946 one screen (Bug#10962).
4947
bcd86815
KB
49482012-04-13 Ken Brown <kbrown@cornell.edu>
4949
4950 * s/cygwin.h (PTY_OPEN): Don't try to close a bogus file descriptor.
4951
c25df26e
RT
49522012-04-13 Reuben Thomas <rrt@sc3d.org>
4953
4954 * indent.c (Fmove_to_column): Change interactive spec (Bug#739).
4955
0fc59f1e
DC
49562012-04-11 Daniel Colascione <dancol@dancol.org>
4957
4958 * s/cygwin.h: The vfork the #define in cygwin.h was protecting
4959 against is gone. It's better to use vfork now so that when Cygwin
4960 gains a new, working vfork, we use it automatically (bug#10398).
4961
de8c03dc
SM
49622012-04-11 Stefan Monnier <monnier@iro.umontreal.ca>
4963
4964 * window.c (save_window_save): Obey window-point-insertion-type.
4965
2f097256
GM
49662012-04-11 Glenn Morris <rgm@gnu.org>
4967
4968 * Makefile.in (GNUSTEP_CFLAGS): Rename from C_SWITCH_X_SYSTEM.
4969
453b951e
SM
49702012-04-11 Stefan Monnier <monnier@iro.umontreal.ca>
4971
4972 * alloc.c (lisp_align_malloc): Remove unneeded prototype.
4973
75f1671a 49742012-04-10 Jason S. Cornez <jcornez@ravenpack.com> (tiny change)
6bbef4e5
JC
4975
4976 * keyboard.c: Override inhibit-quit after the third C-g (bug#6585).
4977 (force_quit_count): New var.
4978 (handle_interrupt): Use it.
4979
2a8ce227
JB
49802012-04-10 Juanma Barranquero <lekktu@gmail.com>
4981
4982 * w32.c (w32_delayed_load): Record the full path of the library
4983 being loaded (bug#10424).
4984
935396c0
GM
49852012-04-09 Glenn Morris <rgm@gnu.org>
4986
05920a43
GM
4987 * doc.c (Fsnarf_documentation): Check variables, functions are bound,
4988 not just in the obarray, before snarfing them. (Bug#11036)
4989
935396c0
GM
4990 * Makefile.in ($(leimdir)/leim-list.el):
4991 Pass EMACS rather than BUILT_EMACS.
4992
a18ecafa
TZ
49932012-04-09 Teodor Zlatanov <tzz@lifelogs.com>
4994
4995 * process.c (make_process):
4996 * process.h: Add integer `gnutls_handshakes_tried' member to
4997 process struct.
4998
6bbef4e5
JC
4999 * gnutls.h: Add `GNUTLS_EMACS_HANDSHAKES_LIMIT' upper limit.
5000 Add convenience `GNUTLS_LOG2i' macro.
a18ecafa
TZ
5001
5002 * gnutls.c (gnutls_log_function2i): Convenience log function.
5003 (emacs_gnutls_read): Use new log functions,
5004 `gnutls_handshakes_tried' process member, and
5005 `GNUTLS_EMACS_HANDSHAKES_LIMIT' to limit the number of handshake
5006 attempts per process (connection).
5007
b4d3bc10
CY
50082012-04-09 Chong Yidong <cyd@gnu.org>
5009
5010 * eval.c (Fuser_variable_p, user_variable_p_eh)
5011 (lisp_indirect_variable): Functions deleted.
5012 (Fdefvar): Caller changed.
5013
5014 * callint.c (Finteractive, Fcall_interactively):
5015 * minibuf.c (Fread_variable): Callers changed.
5016
70f4d973
EZ
50172012-04-09 Eli Zaretskii <eliz@gnu.org>
5018
5019 * xdisp.c (set_cursor_from_row): If the display string appears in
5020 the buffer at position that is closer to point than the position
5021 after the display string, display the cursor on the first glyph of
5022 the display string. Fixes cursor display when a 'display' text
5023 property immediately follows invisible text. (Bug#11094)
5024
cb3c2e3e
PE
50252012-04-09 Paul Eggert <eggert@cs.ucla.edu>
5026
5027 composite.c: use 'double' consistently
5028 * composite.c (get_composition_id): Use 'double' consistently
5029 instead of converting 'float' to 'double' and vice versa; this is
5030 easier to understand and avoids a GCC warning.
5031
fd06db5d
GM
50322012-04-09 Glenn Morris <rgm@gnu.org>
5033
50fe702a
GM
5034 * Makefile.in: Generate leim-list with bootstrap-emacs, in
5035 preparation for dumping it with emacs. (Bug#4789)
5036 (leimdir): New variable.
5037 ($(leimdir)/leim-list.el): New rule.
5038 (emacs$(EXEEXT)): Depend on leim-list.el.
5039
fd06db5d
GM
5040 * buffer.c (Qucs_set_table_for_input): Remove. (Bug#9821)
5041 (Fget_buffer_create): Don't call Qucs_set_table_for_input.
5042 (init_buffer_once, syms_of_buffer): Remove Qucs_set_table_for_input.
5043
55c131ee
AS
50442012-04-08 Andreas Schwab <schwab@linux-m68k.org>
5045
5046 * lisp.h (struct Lisp_Symbol): Add explicit padding to ensure
5047 proper alignment.
5048
9209588f
JB
50492012-04-07 Juanma Barranquero <lekktu@gmail.com>
5050
5051 * xml.c (init_libxml2_functions) [WINDOWSNT]:
5052 Remove unused local variable.
5053
e3fb2efb
PE
50542012-04-07 Paul Eggert <eggert@cs.ucla.edu>
5055
5056 Avoid unnecessary pointer scanning in garbage collection (Bug#10780).
5057 * alloc.c (POINTERS_MIGHT_HIDE_IN_OBJECTS): New macro.
5058 (mark_memory): Mark Lisp_Objects only if pointers might hide in
5059 objects, as mark_maybe_pointer will catch them otherwise.
5060 (GC_LISP_OBJECT_ALIGNMENT): Remove; no longer needed.
5061 * s/gnu-linux.h (GC_LISP_OBJECT_ALIGNMENT) [__mc68000__]: Likewise.
5062
b5385551
PE
50632012-04-07 Paul Eggert <eggert@cs.ucla.edu>
5064
5065 Fix typo that broke non-Windows builds.
5066 * xml.c (libxml2_loaded_p) [!!WINDOWSNT]: 'inine' -> 'inline'.
5067
9078ead6
EZ
50682012-04-07 Eli Zaretskii <eliz@gnu.org>
5069
5070 Support building on MS-Windows with libxml2.
5071
5072 * makefile.w32-in (OBJ2): Add xml.$(O).
5073 (GLOBAL_SOURCES): Add xml.c.
5074 ($(BLD)/xml.$(O)): New dependency list.
5075
5076 * xml.c (DEF_XML2_FN, LOAD_XML2_FN) [WINDOWSNT]: New macros.
5077 (fn_htmlReadMemory, fn_xmlReadMemory, fn_xmlDocGetRootElement)
5078 (fn_xmlFreeDoc, fn_xmlCleanupParser, fn_xmlCheckVersion)
5079 [!WINDOWSNT]: New macros.
5080 (init_libxml2_functions, libxml2_loaded_p): New functions.
5081 (parse_region): Call fn_xmlCheckVersion instead of using the macro
5082 LIBXML_TEST_VERSION. Call libxml2 functions via the fn_* macros.
5083 (xml_cleanup_parser): New function, export for fn_xmlCleanupParser.
5084 Calls xmlCleanupParser only if libxml2 was loaded (or statically
5085 linked in).
6bbef4e5
JC
5086 (Flibxml_parse_html_region, Flibxml_parse_xml_region):
5087 Call init_libxml2_functions before calling libxml2 functions.
9078ead6
EZ
5088 (syms_of_xml) <Qlibxml2_dll>: DEFSYM it.
5089
5090 * emacs.c: Don't include libxml/parser.h.
5091 (shut_down_emacs): Call xml_cleanup_parser, instead of calling
5092 xmlCleanupParser directly.
5093
5094 * lisp.h [HAVE_LIBXML2]: Add prototype for xml_cleanup_parser.
5095
3811fdf3
EZ
50962012-04-07 Eli Zaretskii <eliz@gnu.org>
5097
5098 * indent.c (Fvertical_motion): If there is a display string at
5099 point, use it.vpos to compute how many lines to backtrack after
5100 move_it_to point. (Bug#11133)
5101
2f8e16b2
EZ
51022012-04-06 Eli Zaretskii <eliz@gnu.org>
5103
5104 * buffer.h (FETCH_CHAR, FETCH_MULTIBYTE_CHAR):
5105 * character.h (STRING_CHAR, STRING_CHAR_AND_LENGTH): Add comments
5106 about subtle differences between FETCH_CHAR* and STRING_CHAR*
5107 macros related to unification of CJK characters. For the details,
5108 see the discussion following the message here:
5109 http://debbugs.gnu.org/cgi/bugreport.cgi?bug=11073#14.
5110
3d439cd1
CY
51112012-04-04 Chong Yidong <cyd@gnu.org>
5112
5113 * keyboard.c (Vdelayed_warnings_list): Doc fix.
5114
8bc53d00
EZ
51152012-04-01 Eli Zaretskii <eliz@gnu.org>
5116
5117 * w32menu.c (simple_dialog_show, add_menu_item): Use SAFE_ALLOCA
5118 instead of alloca. (Bug#11138)
5119
3b0512a3
AS
51202012-04-01 Andreas Schwab <schwab@linux-m68k.org>
5121
5122 * w32menu.c (is_simple_dialog): Properly check lisp types.
5123 (Bug#11141)
5124
8427ddd2
EZ
51252012-03-31 Eli Zaretskii <eliz@gnu.org>
5126
979022ef
EZ
5127 * xdisp.c (move_it_by_lines): When DVPOS is positive, and the
5128 position we get to after a call to move_it_to fails the
5129 IS_POS_VALID_AFTER_MOVE_P test, move to the next buffer position
5130 only if we wind up in a string from display property. (Bug#11063)
5131
a6b1c7cc
EZ
5132 * window.c (Fdelete_other_windows_internal): Invalidate the row
5133 and column information about mouse highlight, so that redisplay
5134 restores it after reallocating the glyph matrices. (Bug#7464)
5135
8427ddd2
EZ
5136 * xdisp.c (set_cursor_from_row): If `cursor' property on a display
5137 string comes from a `display' text property, use the buffer
5138 position of that property as if we actually saw that position in
5139 the row's glyphs.
697ba24b
EZ
5140 (move_it_by_lines): Remove the assertion that
5141 "it->current_x == 0 && it->hpos == 0" which can be legitimately
5142 violated when there's a before-string at the beginning of a line.
5143 (Bug#11063)
8427ddd2 5144
65a0a738
EZ
51452012-03-30 Eli Zaretskii <eliz@gnu.org>
5146
5147 * xdisp.c (append_space_for_newline): If the default face was
5148 remapped, use the remapped face for the appended newline.
5149 (extend_face_to_end_of_line): Use the remapped default face for
5150 extending the face to the end of the line.
5151 (display_line): Call extend_face_to_end_of_line when the default
5152 face was remapped. (Bug#11068)
5153
581355cc
EZ
51542012-03-29 Eli Zaretskii <eliz@gnu.org>
5155
5156 * s/ms-w32.h: Discourage from defining HAVE_GETCWD.
5157
e8fc049f
SM
51582012-03-28 Stefan Monnier <monnier@iro.umontreal.ca>
5159
5160 * keyboard.c (safe_run_hooks_error): Don't unquote strings.
5161
4fb9a543
GM
51622012-03-27 Glenn Morris <rgm@gnu.org>
5163
5164 * search.c (Fword_search_backward_lax, Fword_search_forward_lax):
5165 Doc fixes.
5166
679910f1
KH
51672012-03-26 Kenichi Handa <handa@m17n.org>
5168
5169 * dispextern.h (struct glyph): Fix previous change. Change the
5170 bit length of glyphless.ch to 25 (Bug#11082).
5171
90d49b7f
CY
51722012-03-26 Chong Yidong <cyd@gnu.org>
5173
5174 * keyboard.c (Vselection_inhibit_update_commands): New variable.
5175 (command_loop_1): Use it; inhibit selection update for
5176 handle-select-window too (Bug#8996).
5177
f514f6f0
FP
51782012-03-25 Fabrice Popineau <fabrice.popineau@supelec.fr>
5179
e8fc049f 5180 * w32heap.c (_heap_init, _heap_term): Remove dead MSVC-specific code.
f514f6f0 5181
bf43fa51
KH
51822012-03-25 Kenichi Handa <handa@m17n.org>
5183
5184 * dispextern.h (struct glyph): Change the bit length of
5185 glyphless.ch to 22 to make the member glyphless fit in 32 bits.
5186
8a0c01dd
EZ
51872012-03-24 Eli Zaretskii <eliz@gnu.org>
5188
5189 * s/ms-w32.h (tzname): Include time.h before redirecting to
5190 _tzname. Fixes the MSVC build. (Bug#9960)
5191
7d1c3a76
AS
51922012-03-24 Andreas Schwab <schwab@linux-m68k.org>
5193
8ed79523
AS
5194 * xdisp.c (produce_glyphless_glyph): Limit length of acronym to 6
5195 characters.
5196
7d1c3a76
AS
5197 * xterm.c (XTread_socket): Only modify handling_signal if
5198 !SYNC_INPUT. (Bug#11080)
5199
e99a9b8b
EZ
52002012-03-23 Eli Zaretskii <eliz@gnu.org>
5201
5202 * bidi.c (bidi_fetch_char): Use STRING_CHAR_AND_LENGTH instead of
5203 FETCH_MULTIBYTE_CHAR followed by CHAR_BYTES. Prevents crashes
5204 when fetching a multibyte character consumes more bytes than
5205 CHAR_BYTES returns, due to unification of CJK characters in
5206 string_char. (Bug#11073)
5207
5063c0e1
TN
52082012-03-23 Troels Nielsen <bn.troels@gmail.com> (tiny change)
5209
5210 * process.c (wait_reading_process_output): Handle pty disconnect
5211 by refraining from sending oneself a SIGCHLD (bug#10933).
5212
9f851fbd
CY
52132012-03-22 Chong Yidong <cyd@gnu.org>
5214
5215 * dispextern.h (struct it): New member string_from_prefix_prop_p.
5216
5063c0e1 5217 * xdisp.c (push_prefix_prop): Rename from push_display_prop.
9f851fbd
CY
5218 Mark string as coming from a prefix property.
5219 (handle_face_prop): Use default face for prefix strings (Bug#4281).
5220 (pop_it, reseat_1): Save and restore string_from_prefix_prop_p.
5221
fb5b8aca
CY
52222012-03-21 Chong Yidong <cyd@gnu.org>
5223
5224 * xfaces.c (Vface_remapping_alist): Doc fix.
5225
62356a1b
EZ
52262012-03-20 Eli Zaretskii <eliz@gnu.org>
5227
5228 * w32proc.c (Fw32_set_console_codepage)
5063c0e1
TN
5229 (Fw32_set_console_output_codepage, Fw32_get_codepage_charset):
5230 Doc fixes.
62356a1b 5231
025de85b
CY
52322012-03-20 Chong Yidong <cyd@gnu.org>
5233
5234 * dispnew.c (Fredisplay, Vredisplay_preemption_period): Update doc
5235 to reflect default non-nil value of redisplay-dont-pause.
5236
4827f94e
KH
52372012-03-19 Kenichi Handa <handa@m17n.org>
5238
5239 * ftfont.c (ftfont_drive_otf): Mask bits of character code to make
5240 it fit in a valid range (Bug#11003).
5241
e50a24a2
EZ
52422012-03-18 Eli Zaretskii <eliz@gnu.org>
5243
5244 * xdisp.c (cursor_row_p): Even if the glyph row ends in a string
5245 that is not from display property, accept the row as a "cursor
5246 row" if one of the string's character has a non-nil `cursor'
5247 property. Fixes cursor positioning when there are newlines in
5248 overlay strings, e.g. in icomplete.el. (Bug#11035)
5249
9af5ed87
PE
52502012-03-12 Paul Eggert <eggert@cs.ucla.edu>
5251
5252 * buffer.c (compare_overlays): Don't assume args differ (Bug#6830).
5253
d1f55f16
CY
52542012-03-12 Chong Yidong <cyd@gnu.org>
5255
5256 * eval.c (inhibit_lisp_code): Rename from
5257 inhibit_window_configuration_change_hook; move from window.c.
5258
5259 * xfns.c (unwind_create_frame_1, Fx_create_frame):
5260 * window.c (run_window_configuration_change_hook)
5261 (syms_of_window): Callers changed.
5262
66c5eebd
CY
52632012-03-11 Chong Yidong <cyd@gnu.org>
5264
413df973
CY
5265 * keymap.c (Fkey_description): Doc fix (Bug#9700).
5266
66c5eebd
CY
5267 * editfns.c (Fconstrain_to_field): Doc fix (Bug#9452).
5268
1de11f56
CY
52692012-03-10 Chong Yidong <cyd@gnu.org>
5270
5271 * frame.c (other_visible_frames): Don't assume the selected frame
5272 is visible (Bug#10955).
5273
cae07000
SM
52742012-03-09 Stefan Monnier <monnier@iro.umontreal.ca>
5275
5276 * buffer.c (compare_overlays): Avoid qsort's instability (bug#6830).
5277
89c94350
JD
52782012-03-08 Jan Djärv <jan.h.d@swipnet.se>
5279
5280 * gtkutil.c (x_wm_set_size_hint): Use one row in call to
5281 FRAME_TEXT_LINES_TO_PIXEL_HEIGHT so base_height is greater than
5282 zero (Bug#10954).
5283
999dd333
GM
52842012-03-03 Glenn Morris <rgm@gnu.org>
5285
01a6dcc8 5286 * alloc.c (Fgarbage_collect, misc-objects-consed): Doc fixes.
999dd333 5287
de0100f2
EZ
52882012-03-02 Eli Zaretskii <eliz@gnu.org>
5289
5290 * xdisp.c (try_window_reusing_current_matrix): Don't move cursor
5291 position past the first glyph_row that ends at ZV. (Bug#10902)
b8456c5c
EZ
5292 (redisplay_window, next_element_from_string): Fix typos in
5293 comments.
3e441275
EZ
5294 (redisplay_window): Pass to move_it_vertically the margin in
5295 pixels, not in screen lines.
de0100f2 5296
96a72ee9
GM
52972012-03-02 Glenn Morris <rgm@gnu.org>
5298
5299 * buffer.c (buffer-list-update-hook): Doc fix.
5300
312508d7
EZ
53012012-02-29 Eli Zaretskii <eliz@gnu.org>
5302
5303 * xdisp.c (get_overlay_strings_1): Under bidi redisplay, call
5304 push_it before setting up the iterator for the first overlay
5305 string, even if we have an empty string loaded.
5306 (next_overlay_string): If there's an empty string on the iterator
5307 stack, pop the stack. (Bug#10903)
5308
27f3c637
PE
53092012-02-25 Paul Eggert <eggert@cs.ucla.edu>
5310
5311 Generalize fix for crash due to non-contiguous EMACS_INT (Bug#10780).
5312 Suggested by Stefan Monnier in
5313 <http://lists.gnu.org/archive/html/emacs-devel/2012-02/msg00692.html>.
5314 * alloc.c (widen_to_Lisp_Object): New static function.
5315 (mark_memory): Also mark Lisp_Objects by fetching pointer words
5316 and widening them to Lisp_Objects. This would work even if
5317 USE_LSB_TAG is defined and wide integers are used, which might
5318 happen in a future version of Emacs.
5319
3c9dfce6
CY
53202012-02-25 Chong Yidong <cyd@gnu.org>
5321
fa74b241
CY
5322 * fileio.c (Ffile_selinux_context, Fset_file_selinux_context):
5323 Doc fix.
5324
3c9dfce6
CY
5325 * xselect.c (Fx_selection_exists_p): Doc fix.
5326 (x_clipboard_manager_save_all): Print an informative message
5327 before saving to clipboard manager.
5328
9486df08
CY
53292012-02-24 Chong Yidong <cyd@gnu.org>
5330
5331 * keyboard.c (process_special_events): Handle all X selection
5332 requests in kbd_buffer, not just the next one (Bug#8869).
5333
f01d3321
CY
53342012-02-23 Chong Yidong <cyd@gnu.org>
5335
5336 * xfns.c (Fx_create_frame): Avoid window-configuration-change-hook
5337 call when setting menu-bar-lines and tool-bar-lines parameters.
5338 (unwind_create_frame_1): New helper function.
5339
5340 * window.c (inhibit_window_configuration_change_hook): New var.
5341 (run_window_configuration_change_hook): Obey it.
b2e4ca7d 5342 (syms_of_window): Initialize it.
f01d3321 5343
86b847b6
CY
53442012-02-22 Chong Yidong <cyd@gnu.org>
5345
5346 * xterm.c (x_draw_image_relief): Add missing type check for
5347 Vtool_bar_button_margin (Bug#10743).
5348
a59225b1
CY
53492012-02-21 Chong Yidong <cyd@gnu.org>
5350
5351 * fileio.c (Vfile_name_handler_alist): Doc fix.
5352
5353 * buffer.c (Fget_file_buffer): Protect against invalid file
5354 handler return value.
5355
310f5bd4
PE
53562012-02-20 Paul Eggert <eggert@cs.ucla.edu>
5357
cb3a28cc
PE
5358 * .gdbinit (xreload): Don't assume EMACS_INT fits in 'long'
5359 when computing $valmask.
5360
310f5bd4
PE
5361 Fix crash due to non-contiguous EMACS_INT (Bug#10780).
5362 * lisp.h (VALBITS): Move definition up, so that USE_LSB_TAG can use it.
5363 (USE_LSB_TAG): Do not define if UINTPTR_MAX >> VALBITS == 0.
5364 It's useless in that case, and it can cause problems on hosts
5365 that allocate halves of EMACS_INT values separately.
5366 Reported by Dan Horák. Diagnosed by Andreas Schwab in
5367 <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=10780#30>.
5368 * mem-limits.h (EXCEEDS_LISP_PTR): Define to 0 on hosts where
5369 UINTPTR_MAX >> VALBITS == 0. This is required by the above change;
5370 it avoids undefined behavior on hosts where shifting right by more
5371 than the word width has undefined behavior.
5372
2375c96a
CY
53732012-02-19 Chong Yidong <cyd@gnu.org>
5374
5375 * fileio.c (Ffile_name_directory, Ffile_name_nondirectory)
5376 (Funhandled_file_name_directory, Ffile_name_as_directory)
5377 (Fdirectory_file_name, Fexpand_file_name)
5378 (Fsubstitute_in_file_name): Protect against invalid file handler
5379 return values (Bug#10845).
5380
3eb49e71
EZ
53812012-02-18 Eli Zaretskii <eliz@gnu.org>
5382
5383 * .gdbinit (pitx): Fix incorrect references to fields of the
5384 iterator stack.
5385
7b926f3f
CY
53862012-02-17 Chong Yidong <cyd@gnu.org>
5387
5388 * syntax.c (Fscan_lists): Doc fix (Bug#10833).
5389
11273115
PE
53902012-02-15 Paul Eggert <eggert@cs.ucla.edu>
5391
5392 * image.c (MAX_IMAGE_SIZE): Increase from 6.0 to 10.0; see
5393 <http://lists.gnu.org/archive/html/emacs-devel/2012-02/msg00540.html>.
5394
c3a70e2b
CY
53952012-02-15 Chong Yidong <cyd@gnu.org>
5396
5397 * eval.c (Fdefvar, Fdefconst): Doc fix; note that the variable is
5398 marked as special. Also, starting docstrings with * is obsolete.
5399
0ca43699
AS
54002012-02-13 Andreas Schwab <schwab@linux-m68k.org>
5401
5402 * gnutls.c (emacs_gnutls_write): Fix last change.
5403
2e8f3c56
LI
54042012-02-13 Lars Ingebrigtsen <larsi@gnus.org>
5405
5406 * gnutls.c (emacs_gnutls_write): Set errno appropriately for
5407 send_process.
5408
af70074f
SM
54092012-02-13 Stefan Monnier <monnier@iro.umontreal.ca>
5410
5411 * keymap.c (Fsingle_key_description): Handle char ranges.
5412
95986d52
CY
54132012-02-12 Chong Yidong <cyd@gnu.org>
5414
afd83bd1
CY
5415 * xdisp.c (handle_stop): Avoid assigning -1 to it->face_id here,
5416 as that creates a dangerous corner case.
5417
95986d52
CY
5418 * window.c (Fdelete_window_internal): Invalidate the mouse
5419 highlight (Bug#9904).
5420
bd7da63e
GM
54212012-02-12 Glenn Morris <rgm@gnu.org>
5422
5423 * xselect.c (Fx_own_selection_internal)
5424 (Fx_get_selection_internal, Fx_disown_selection_internal)
5425 (Fx_selection_owner_p, Fx_selection_exists_p): Doc fixes.
5426 * nsselect.m (Fx_own_selection_internal)
5427 (Fx_disown_selection_internal, Fx_selection_exists_p)
5428 (Fx_selection_owner_p, Fx_get_selection_internal):
5429 Sync docs and argument specs with the xselect.c versions.
5430
77abcbc2
LI
54312012-02-11 Lars Ingebrigtsen <larsi@gnus.org>
5432
5433 * gnutls.c (emacs_gnutls_write): Don't infloop if sendto fails.
5434
90b671e2
EZ
54352012-02-11 Eli Zaretskii <eliz@gnu.org>
5436
1c0ca0b7
EZ
5437 * w32select.c (Fx_selection_exists_p): Sync doc string and
5438 argument list with xselect.c. (Bug#10783)
5439
5440 * w16select.c (Fx_selection_exists_p): Sync doc string and
5441 argument list with xselect.c. (Bug#10783)
90b671e2 5442
49241268
GM
54432012-02-10 Glenn Morris <rgm@gnu.org>
5444
5445 * fns.c (Fsecure_hash): Doc fix.
5446
f998bbe7 54472012-02-09 Kenichi Handa <handa@m17n.org>
5c1ca13d
KH
5448
5449 * coding.c (produce_chars): Fix updating of src_end (Bug#10701).
5450
0992bd9c
CY
54512012-02-07 Chong Yidong <cyd@gnu.org>
5452
5453 * buffer.c (Fbuffer_local_variables)
5454 (buffer_lisp_local_variables): Handle unbound vars correctly;
5455 don't let Qunbound leak into Lisp.
5456
af008560
GM
54572012-02-07 Glenn Morris <rgm@gnu.org>
5458
dd605cc4
GM
5459 * image.c (Fimagemagick_types): Doc fix.
5460
af008560
GM
5461 * image.c (imagemagick-render-type): Change it from a lisp object
5462 to an integer. Move the doc here from the lisp manual.
5463 Treat all values not equal to 0 the same.
5464
1449fa1d
CY
54652012-02-06 Chong Yidong <cyd@gnu.org>
5466
5467 * doc.c (store_function_docstring): Avoid applying docstring of
5468 alias to base function (Bug#2603).
5469
3723ec07
AS
54702012-02-04 Andreas Schwab <schwab@linux-m68k.org>
5471
5472 * .gdbinit (pp1, pv1): Remove redundant defines.
5473 (pr): Use pp.
5474
79c1cc1e
CY
54752012-02-04 Chong Yidong <cyd@gnu.org>
5476
5477 * nsterm.m: Declare a global (Bug#10694).
5478
d7f29f8e
EZ
54792012-02-04 Eli Zaretskii <eliz@gnu.org>
5480
cae07000
SM
5481 * w32.c (get_emacs_configuration_options):
5482 Include --enable-checking, if specified, in the return value.
d7f29f8e 5483
3b95a6f9
MR
54842012-02-04 Martin Rudalics <rudalics@gmx.at>
5485
5486 * dispnew.c (change_frame_size_1): Calculate new_frame_total_cols
5487 after rounding frame sizes. (Bug#9723)
5488
d6fa96a6
EZ
54892012-02-04 Eli Zaretskii <eliz@gnu.org>
5490
5491 * keyboard.c (adjust_point_for_property): Don't position point
5492 before BEGV. (Bug#10696)
5493
df0b2940
PE
54942012-02-03 Paul Eggert <eggert@cs.ucla.edu>
5495
5496 Handle overflow when computing char display width (Bug#9496).
5497 * character.c (char_width): Return EMACS_INT, not int.
5498 (char_width, c_string_width): Check for overflow when
5499 computing the width; this is possible now that individual
5500 characters can have unbounded width. Problem introduced
5501 by merge from Emacs 23 on 2012-01-19.
5502
6bee44d6
MA
55032012-02-02 Michael Albinus <michael.albinus@gmx.de>
5504
5505 * dbusbind.c (Fdbus_register_method): Mention the return value
5506 :ignore in the docstring.
5507
44f92739
GM
55082012-02-02 Glenn Morris <rgm@gnu.org>
5509
1b9f60cc
GM
5510 * callproc.c (Fcall_process, Fcall_process_region): Doc fix.
5511
44f92739
GM
5512 * nsterm.m (syms_of_nsterm) <x-toolkit-scroll-bars>:
5513 Unconditionally set to t. (Bug#10673)
5514 * nsterm.m (syms_of_nsterm) <x-toolkit-scroll-bars>:
5515 * w32term.c (syms_of_w32term) <x-toolkit-scroll-bars>:
5516 * xterm.c (syms_of_xterm) <x-toolkit-scroll-bars>: Doc fix.
5517
c5d3843c
KH
55182012-02-02 Kenichi Handa <handa@m17n.org>
5519
5520 (x_produce_glyphs): Cancel previous change. If cmp->glyph_len is
5521 0, do not call append_composite_glyph.
5522
159462d4 55232012-02-02 Kenichi Handa <handa@m17n.org>
d2a51fd7
KH
5524
5525 * xdisp.c (BUILD_COMPOSITE_GLYPH_STRING): Initialize first_s to
5526 NULL (Bug#6988).
5527 (x_produce_glyphs): If the component of a composition is a null
5528 string, set it->pixel_width to 1 to avoid zero-width glyph.
5529
78cef877
EZ
55302012-02-01 Eli Zaretskii <eliz@gnu.org>
5531
5532 * ralloc.c (resize_bloc, r_alloc_sbrk): Don't call memmove if its
5533 first 2 arguments are identical. This makes inserting large
5534 output from a subprocess an order of magnitude faster on
5535 MS-Windows, where all sbrk'ed memory is always contiguous.
5536
97897668
GM
55372012-01-31 Glenn Morris <rgm@gnu.org>
5538
5539 * nsterm.m (syms_of_nsterm) <x-toolkit-scroll-bars>:
c78c6e0b 5540 * w32term.c (syms_of_w32term) <x-toolkit-scroll-bars>:
97897668
GM
5541 * xterm.c (syms_of_xterm) <x-toolkit-scroll-bars>: Sync docs.
5542
31fd3586
GM
55432012-01-29 Glenn Morris <rgm@gnu.org>
5544
5545 * gnutls.c (syms_of_gnutls): More doc (from etc/NEWS).
5546
0e24a8b2
CY
55472012-01-28 Samuel Thibault <sthibault@debian.org> (tiny change)
5548
5549 * s/gnu.h: Define POSIX_SIGNALS (Bug#10552).
5550
cc0adcb0
CY
55512012-01-28 Chong Yidong <cyd@gnu.org>
5552
5553 * minibuf.c (syms_of_minibuf): Doc fix (Bug#10550).
5554
acc28cb9
CY
55552012-01-26 Chong Yidong <cyd@gnu.org>
5556
9c69cfb7
CY
5557 * keyboard.c (Vecho_keystrokes): Document zero value (Bug#10503).
5558
acc28cb9
CY
5559 * search.c (Fsearch_forward, Fsearch_backward): Document negative
5560 repeat counts (Bug#10507).
5561
48da7392
GM
55622012-01-26 Glenn Morris <rgm@gnu.org>
5563
5564 * lread.c (syms_of_lread): Doc fix.
5565
14af5f7f
CY
55662012-01-25 HIROSHI OOTA <nil@mad.dog.cx> (tiny change)
5567
5568 * coding.c (encode_designation_at_bol): Change return value to
5569 EMACS_INT.
5570
0b21c100
CY
55712012-01-25 Chong Yidong <cyd@gnu.org>
5572
5573 * eval.c (Fuser_variable_p): Doc fix; mention custom-variable-p.
5574
3c2907f7
CY
55752012-01-21 Chong Yidong <cyd@gnu.org>
5576
5577 * floatfns.c (Fcopysign): Make the second argument non-optional,
5578 since nil is not allowed anyway.
5579
959ad23f
AS
55802012-01-21 Andreas Schwab <schwab@linux-m68k.org>
5581
5582 * process.c (read_process_output): Use p instead of XPROCESS (proc).
5583 (send_process): Likewise.
5584
34a02f46
MR
55852012-01-19 Martin Rudalics <rudalics@gmx.at>
5586
5587 * window.c (save_window_save, Fcurrent_window_configuration)
cae07000
SM
5588 (Vwindow_persistent_parameters): Do not use Qstate.
5589 Rewrite doc-strings.
34a02f46 5590
1259009a 55912012-01-19 Kenichi Handa <handa@m17n.org>
25ed9e61
KH
5592
5593 * character.c (char_width): New function.
70d4fdf6
GM
5594 (Fchar_width, c_string_width, lisp_string_width):
5595 Use char_width (Bug#9496).
25ed9e61 5596
6a6ee00d
MR
55972012-01-16 Martin Rudalics <rudalics@gmx.at>
5598
5599 * window.c (Vwindow_persistent_parameters): New variable.
5600 (Fset_window_configuration, save_window_save): Handle persistent
5601 window parameters.
5602
c85efaf7
EZ
56032012-01-14 Eli Zaretskii <eliz@gnu.org>
5604
5605 * w32fns.c (signal_user_input): Don't do a QUIT, to avoid
5606 thrashing the stack of the thread. (Bug#9087)
5607
5944709e
PE
56082012-01-12 Paul Eggert <eggert@cs.ucla.edu>
5609
5610 * xdisp.c (rows_from_pos_range): Add parens as per gcc -Wparentheses.
5611
e71f5d99
EZ
56122012-01-11 Eli Zaretskii <eliz@gnu.org>
5613
5614 * xdisp.c (rows_from_pos_range): Handle the case where the
5615 highlight ends on a newline. (Bug#10464)
5616 (mouse_face_from_buffer_pos): Fix off-by-one error in calculating
5617 he end column for display of highlight that ends on a newline
5618 before a R2L line.
5619
ce316182
GM
56202012-01-11 Glenn Morris <rgm@gnu.org>
5621
5622 * lread.c (init_lread): If no-site-lisp, remove site-lisp dirs
5623 from load-path also when installation-directory is nil. (Bug#10208)
5624
5b43da69
GM
56252012-01-10 Glenn Morris <rgm@gnu.org>
5626
74cc8ff9
GM
5627 * emacs.c (syms_of_emacs) <installation-directory>: Doc fix.
5628
7d8d6e4e
GM
5629 * epaths.in (PATH_LOADSEARCH, PATH_EXEC, PATH_DATA, PATH_DOC):
5630 Update template values to be closer to their typical values these days.
5b43da69 5631
a0db8d43
EZ
56322012-01-09 Eli Zaretskii <eliz@gnu.org>
5633
5634 * xdisp.c (rows_from_pos_range): Accept additional argument
5635 DISP_STRING, and accept any glyph in a row whose object is that
5636 string as eligible for mouse highlight. Fixes mouse highlight of
5637 display strings from overlays. (Bug#10464)
5638
9a0115ab 56392012-01-07 Paul Eggert <eggert@cs.ucla.edu>
09450bae 5640
b9110d6a 5641 emacs: fix an auto-save permissions race condition (Bug#10400)
09450bae
PE
5642 * fileio.c (auto_saving_dir_umask): New static var.
5643 (Fmake_directory_internal): Use it.
5644 (do_auto_save_make_dir): Set it, instead of invoking chmod after
5645 creating the directory. The old code temporarily assigns
5646 too-generous permissions to the directory.
5647 (do_auto_save_eh): Clear it.
b9110d6a 5648 (Fdo_auto_save): Catch all errors, not just file errors, so
09450bae
PE
5649 that the var is always cleared.
5650
6c1bd3f3
EZ
56512012-01-07 Eli Zaretskii <eliz@gnu.org>
5652
5653 * search.c (scan_buffer): Pass character positions to
5654 know_region_cache, not byte positions. (Bug#6540)
5655
069d2b50
L
56562012-01-07 LynX <_LynX@bk.ru> (tiny change)
5657
5658 * w32.c (sys_rename): Report EXDEV when rename of a directory
5659 fails because the target is on another logical disk. (Bug#10284)
5660
75bf0d33
DB
56612012-01-07 David Benjamin <davidben@mit.edu> (tiny change)
5662
5663 * xterm.c (x_embed_request_focus): New function.
5664
5665 * xterm.h: Add prototype.
5666
5667 * xfns.c (Fx_focus_frame): Use it for embedded frames (Bug#9977).
5668
1c6e5a32
GM
56692012-01-05 Glenn Morris <rgm@gnu.org>
5670
5671 * emacs.c (emacs_copyright): Update short copyright year to 2012.
5672
651e947e
EZ
56732012-01-01 Eli Zaretskii <eliz@gnu.org>
5674
5675 * gnutls.c (init_gnutls_functions): Load gnutls_check_version.
5676 Load gnutls_transport_set_lowat only if GnuTLS version is below
5677 2.11.1.
5678 (emacs_gnutls_handshake): Call gnutls_transport_set_lowat only for
5679 GnuTLS versions below 2.11.1.
5680
3778cdd8
AL
56812011-12-31 Antoine Levitt <antoine.levitt@gmail.com>
5682
5683 * xdisp.c (syms_of_xdisp) <window-scroll-functions>: Add warning
5684 to the doc string advising against its use for altering the way
5685 windows are scrolled.
5686
0e5317f7
KH
56872011-12-28 Kenichi Handa <handa@m17n.org>
5688
5689 * coding.c (Fdefine_coding_system_internal): Make an utf-8 base
5690 coding-system ASCII compatible only when it does not produce BOM
5691 on encoding (Bug#10383).
5692
93d5ca1f
JD
56932011-12-26 Jan Djärv <jan.h.d@swipnet.se>
5694
5695 * xmenu.c (x_menu_wait_for_event): Use xg_select for Gtk3 so menus
5696 can scroll.
5697 (create_and_show_popup_menu): Always use menu_position_func for
5698 Gtk3 (Bug#10361).
5699
ca22b785
AS
57002011-12-24 Andreas Schwab <schwab@linux-m68k.org>
5701
5702 * callint.c (Fcall_interactively): Don't truncate prompt string.
5703
d048e1e6
EZ
57042011-12-23 Eli Zaretskii <eliz@gnu.org>
5705
5706 * xdisp.c (handle_invisible_prop): Handle correctly an invisible
5707 property that ends at ZV, so that the bidi iteration could be
3ba1a2ad 5708 resumed from there (after widening). (Bug#10360)
d048e1e6 5709
5ccaba1f
JD
57102011-12-22 Jan Djärv <jan.h.d@swipnet.se>
5711
5712 * nsfont.m (ns_spec_to_descriptor): Do not autorelease fdesc.
5713
204ee57f
JD
57142011-12-21 Jan Djärv <jan.h.d@swipnet.se>
5715
b81d40f0
JB
5716 * nsterm.m (x_free_frame_resources):
5717 Release f->output_data.ns->miniimage.
204ee57f
JD
5718 (ns_index_color): Fix indentation. Do not retain
5719 color_table->colors[i].
5720
5721 * nsmenu.m (ns_update_menubar): Call free_menubar_widget_value_tree
5722 before returning.
5723
5724 * nsfns.m (x_set_background_color): Assign return value from
5725 ns_index_color to face-background instead of NSColor*.
5726 (ns_implicitly_set_icon_type): Fix indentation.
5727 Change assignment in for loop to comparison.
5728
5729 * emacs.c (ns_pool): New variable.
5730 (main): Assign ns_pool.
5731 (Fkill_emacs): Call ns_release_autorelease_pool.
5732
5733 * nsfont.m (ns_spec_to_descriptor): Fix indentation,
5734 autorelease fdesc, release fdAttrs and tdict.
5735 (ns_get_covering_families): Release charset.
5736 (ns_findfonts): Release NSFontDescriptor created with new.
5737 (ns_uni_to_glyphs): Fix indentation.
5738 (setString): Release attrStr before assigning new value.
5739
c803b2b7
JD
57402011-12-18 Jan Djärv <jan.h.d@swipnet.se>
5741
678f4426
JD
5742 * nsmenu.m (NSMenuDidBeginTrackingNotification): Declare if OSX < 10.5
5743 and NS_IMPL_COCOA.
5744 (trackingNotification): Surround with ifdef NS_IMPL_COCOA.
5745 (syms_of_nsmenu): Set trackingMenu to 1 if not NS_IMPL_COCOA.
5746
cd394be1 57472011-12-18 David Reitter <reitter@cmu.edu>
678f4426 5748
5fecd5fc
JD
5749 * nsterm.m (ns_term_init): Subscribe for notifications
5750 NSMenuDidBeginTrackingNotification and NSMenuDidEndTrackingNotification
5751 to method trackingNotification in EmacsMenu.
5752
5753 * nsmenu.m (trackingMenu): New variable.
3771cb17 5754 (trackingNotification): New method (from Aquamacs).
5fecd5fc 5755 (menuNeedsUpdate): Expand comment and return if trackingMenu is 0,
3771cb17 5756 from Aquamacs (Bug#7030).
678f4426
JD
5757
57582011-12-18 Jan Djärv <jan.h.d@swipnet.se>
5fecd5fc 5759
c803b2b7
JD
5760 * nsselect.m (CUT_BUFFER_SUPPORT): Remove define.
5761 (symbol_to_nsstring): Fix indentation.
5762 (ns_symbol_to_pb): New function.
cae07000
SM
5763 (Fns_get_selection_internal): Rename from Fns_get_cut_buffer_internal.
5764 (Fns_rotate_cut_buffers_internal): Remove.
5765 (Fns_store_selection_internal): Rename from
c803b2b7
JD
5766 Fns_store_cut_buffer_internal.
5767 (ns_get_foreign_selection, Fx_own_selection_internal)
5768 (Fx_disown_selection_internal, Fx_selection_exists_p)
b81d40f0
JB
5769 (Fns_get_selection_internal, Fns_store_selection_internal):
5770 Use ns_symbol_to_pb and check if return value is nil.
5771 (syms_of_nsselect): Remove ifdef CUT_BUFFER_SUPPORT. Remove defsubr
5772 Sns_rotate_cut_buffers_internal. Sns_get_cut_buffer_internal
c803b2b7
JD
5773 renamed to Sns_get_selection_internal, Sns_store_cut_buffer_internal
5774 renamed to Sns_store_selection_internal.
5775 (ns_handle_selection_request): Move code to Fx_own_selection_internal
5776 and remove this function.
5777 (ns_handle_selection_clear): Remove, never used.
5778 (Fx_own_selection_internal): Move code from ns_handle_selection_request
5779 here.
5780
e1b01a3a
KB
57812011-12-17 Ken Brown <kbrown@cornell.edu>
5782
5783 * fileio.c (check_writable) [CYGWIN]: Return non-zero if UID or
5784 GID is unknown (Bug#10257).
5785
2adb6e85
PE
57862011-12-17 Paul Eggert <eggert@cs.ucla.edu>
5787
5788 * s/gnu-linux.h: Fix mark_memory typo (Bug#10286).
5789 (GC_MARK_SECONDARY_STACK): Omit removed 3rd arg to mark_memory,
5790 which caused a build failure on GNU/Linux IA-64. This problem was
5791 introduced by my 2011-10-07 patch.
5792
d1d7b339
JL
57932011-12-15 Juri Linkov <juri@jurta.org>
5794
5795 * image.c (imagemagick_error): New function. (Bug#10112)
5796 (imagemagick_load_image): Comment out `MagickSetResolution' call.
5797 Use `imagemagick_error' where ImageMagick functions return
5798 `MagickFalse'.
5799 (Fimagemagick_types): Add `Fnreverse' to return the list in the
5800 proper order.
5801
100d5755
KH
58022011-12-15 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
5803
5804 * xftfont.c (xftfont_draw): Use the font metrics of s->font to
5805 fill background (Bug#8992).
5806
454592a6
MR
58072011-12-13 Martin Rudalics <rudalics@gmx.at>
5808
5809 * window.c (Vwindow_combination_resize)
5810 (Vwindow_combination_limit): Use t instead of non-nil in
5811 doc-strings.
61d4b438
MR
5812 (Vrecenter_redisplay): Add first sentence of doc-string on
5813 separate line.
53524d93 5814 (Frecenter): Fix doc-string typo.
454592a6 5815
3633e3aa
KH
58162011-12-11 Kenichi Handa <handa@m17n.org>
5817
5818 * coding.c (Funencodable_char_position): Pay attention to the
5819 buffer text relocation (Bug#9389).
5820
7b9d523a 58212011-12-10 Jan Djärv <jan.h.d@swipnet.se>
61ccba97 5822
7b9d523a
JD
5823 * xterm.c (x_term_init): Move call to gdk_window_add_filter before
5824 gtk_init (Bug#10100).
5825
b73189c6
EZ
58262011-12-10 Eli Zaretskii <eliz@gnu.org>
5827
5828 * xdisp.c (RECORD_MAX_MIN_POS): Use IT->cmp_it.charpos only if
5829 IT->string is nil. (Bug#10263)
5830
f7dfe5d6
JD
58312011-12-10 Jan Djärv <jan.h.d@swipnet.se>
5832
83faebb4
JD
5833 * nsterm.h (x_free_frame_resources): Declare.
5834
f7dfe5d6
JD
5835 * nsfns.m (ns_get_defaults_value): New function (Bug#10103).
5836 (Fns_get_resource, x_get_string_resource): Call ns_get_defaults_value.
5837
5838 * nsterm.h (ns_get_defaults_value): Declare.
5839
5840 * nsterm.m (ns_default): Call ns_get_defaults_value.
5841
7cd4e72c
EZ
58422011-12-09 Eli Zaretskii <eliz@gnu.org>
5843
5844 * xdisp.c (try_scrolling): Don't set scroll_down_p if dy is zero.
5845 (Bug#10170)
5846
b34d7317
YM
58472011-12-09 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
5848
5849 * unexelf.c (unexec) [NS_IMPL_GNUSTEP]: Take account of the case
5850 that where the value of an _OBJC_* symbol points to is in the .bss
5851 section (Bug#10240).
5852
76470ad1
KH
58532011-12-08 Kazuhiro Ito <kzhr@d1.dion.ne.jp> (tiny change)
5854
5855 * coding.c (encode_coding_ccl): Check (charbuf < charbuf_end)
2fac8180 5856 after the loop to call ccl_driver at least once (Bug#8619).
76470ad1 5857
745fff94
KH
58582011-12-08 Kenichi Handa <handa@m17n.org>
5859
5860 * ftfont.c (get_adstyle_property): Fix previous change
5861 (Bug#10233).
5862
6e44397c
JB
58632011-12-07 Juanma Barranquero <lekktu@gmail.com>
5864
5865 * w32.c (init_environment): If no_site_lisp, remove site-lisp
5866 dirs from the default value of EMACSLOADPATH (bug#10208).
5867
7efa6272
GM
58682011-12-07 Glenn Morris <rgm@gnu.org>
5869
5870 * lread.c (init_lread): If no_site_lisp, exclude site-lisp/ in
5871 installation and source directories as well. (Bug#10208)
5872
f6fc4d87
CY
58732011-12-06 Chong Yidong <cyd@gnu.org>
5874
5875 * minibuf.c (Fread_from_minibuffer): Doc fix (Bug#10228).
5876
2bf26180
GM
58772011-12-06 Glenn Morris <rgm@gnu.org>
5878
5879 * process.c (start_process_unwind): Treat any pid <= 0, except -2,
5880 as an error, not just -1. (Bug#10217)
5881
3a6ad4f0
CY
58822011-12-05 Chong Yidong <cyd@gnu.org>
5883
5884 * keyboard.c (process_special_events): New function.
5885 (swallow_events, Finput_pending_p): Use it (Bug#10195).
5886
75a3b399
PE
58872011-12-05 Paul Eggert <eggert@cs.ucla.edu>
5888
5889 * coding.c (encode_designation_at_bol): Don't use uninitialized
5890 local variable (Bug#9318).
5891
c3c9e25e
KH
58922011-12-05 Kenichi Handa <handa@m17n.org>
5893
5894 * ftfont.c (get_adstyle_property): If the font is not BDF nor PCF,
5895 return Qnil (Bug#8046, Bug#10193).
5896
5eb05ea3
KH
58972011-12-05 Kenichi Handa <handa@m17n.org>
5898
5899 * coding.c (encode_designation_at_bol): New args charbuf_end and
5900 dst. Return the number of produced bytes. Callers changed.
a79703f5
KH
5901 (coding_set_source): Return how many bytes coding->source was
5902 relocated.
5903 (coding_set_destination): Return how many bytes
5904 coding->destination was relocated.
5905 (CODING_DECODE_CHAR, CODING_ENCODE_CHAR, CODING_CHAR_CHARSET)
cae07000 5906 (CODING_CHAR_CHARSET_P): Adjust for the avove changes.
5eb05ea3
KH
5907
59082011-12-05 Kazuhiro Ito <kzhr@d1.dion.ne.jp> (tiny change)
5909
5910 * coding.c (CODING_CHAR_CHARSET_P): New macro.
5911 (encode_coding_emacs_mule, encode_coding_iso_2022): Use the above
5912 macro (Bug#9318).
5913
59142011-12-05 Andreas Schwab <schwab@linux-m68k.org>
5915
5916 The following changes are to fix Bug#9318.
5917
a79703f5 5918 * coding.c (CODING_ENCODE_CHAR, CODING_CHAR_CHARSET): New macros.
5eb05ea3
KH
5919 (encode_coding_emacs_mule, ENCODE_ISO_CHARACTER)
5920 (encode_coding_iso_2022, encode_coding_sjis)
a79703f5 5921 (encode_coding_big5, encode_coding_charset): Use the above macros.
5eb05ea3 5922
7dbda6df
JB
59232011-12-05 Juanma Barranquero <lekktu@gmail.com>
5924
5925 * lisp.h (process_quit_flag): Fix external declaration.
5926
6d5eb5b0
SM
59272011-12-04 Stefan Monnier <monnier@iro.umontreal.ca>
5928
5929 Don't macro-inline non-performance-critical code.
5930 * eval.c (process_quit_flag): New function.
5931 * lisp.h (QUIT): Use it.
5932
a0c3fad0
JD
59332011-12-04 Jan Djärv <jan.h.d@swipnet.se>
5934
5935 * nsfns.m (get_geometry_from_preferences): New function.
5936 (Fx_create_frame): Call get_geometry_from_preferences (Bug#10103).
5937
6c07aac2
AS
59382011-12-04 Andreas Schwab <schwab@linux-m68k.org>
5939
5940 * emacs.c (Qkill_emacs): Define.
5941 (syms_of_emacs): Initialize it.
5942 * keyboard.c (interrupt_signal): Don't call Fkill_emacs here, set
5943 Qquit_flag to `kill-emacs' instead.
6d5eb5b0
SM
5944 (quit_throw_to_read_char): Add parameter `from_signal'.
5945 All callers changed. Call Fkill_emacs if requested and safe.
6c07aac2
AS
5946 * lisp.h (QUIT): Call Fkill_emacs if requested.
5947
c052ead4
JD
59482011-12-03 Jan Djärv <jan.h.d@swipnet.se>
5949
5950 * widget.c (update_wm_hints): Return if wmshell is null.
5951 (widget_update_wm_size_hints): New function.
5952
5953 * widget.h (widget_update_wm_size_hints): Declare.
5954
5955 * xterm.c (x_wm_set_size_hint): If USE_X_TOOLKIT, call
5956 widget_update_wm_size_hints (Bug#10104).
5957
9e49252b
EZ
59582011-12-03 Eli Zaretskii <eliz@gnu.org>
5959
5960 * xdisp.c (handle_invisible_prop): If the invisible text ends just
5961 before a newline, prepare the bidi iterator for consuming the
5962 newline, and keep the current paragraph direction. (Bug#10183)
e9a49426 5963 (redisplay_window): Don't let `margin' become negative. (Bug#10192)
9e49252b 5964
02b16839
JL
59652011-12-02 Juri Linkov <juri@jurta.org>
5966
5967 * search.c (Fword_search_regexp): New Lisp function created from
5968 `wordify'. Change type of arg `lax' from `int' to `Lisp_Object'.
5969 (Fword_search_backward, Fword_search_forward)
5970 (Fword_search_backward_lax, Fword_search_forward_lax):
5971 Use `Fword_search_regexp' instead of `wordify'. Doc fix.
5972 (syms_of_search): Define `Sword_search_regexp'. (Bug#10145)
5973
0068070e
SM
59742011-12-01 Stefan Monnier <monnier@iro.umontreal.ca>
5975
5976 * fileio.c (Finsert_file_contents): Move after-change-function call
5977 to before the "handled:" label, since all "goto handled" appear in
5978 cases where the *-change-functions have already been properly called
5979 (bug#10117).
5980
3360a3fc
AS
59812011-12-01 Andreas Schwab <schwab@linux-m68k.org>
5982
5983 * keyboard.c (interrupt_signal): Don't call kill-emacs when
5984 waiting for input. (Bug#10169)
5985
73d6c093
EZ
59862011-11-30 Eli Zaretskii <eliz@gnu.org>
5987
5988 * dispnew.c (adjust_glyph_matrix): Remove the assertion that
5989 verifies glyph row's hash code--we have just reallocated the
5990 glyphs, so their contents can be complete garbage. (Bug#10164)
5991
febe6bea
JB
59922011-11-30 Juanma Barranquero <lekktu@gmail.com>
5993
5994 * dispnew.c (adjust_glyph_matrix) [XASSERTS]: Add missing check.
5995
801a4313
EZ
59962011-11-30 Eli Zaretskii <eliz@gnu.org>
5997
5998 * dispnew.c (adjust_glyph_matrix) [XASSERTS]: Ensure ROW's
5999 attributes are tested _before_ calling verify_row_hash, to protect
6000 against GCC re-ordering of the tests. (Bug#10164)
6001
2b56b87e
JD
60022011-11-29 Jan Djärv <jan.h.d@swipnet.se>
6003
6004 * xterm.h (struct x_output): net_wm_state_hidden_seen is new.
6005
6006 * xterm.c (handle_one_xevent): Only set async_visible and friends
6007 if net_wm_state_hidden_seen is non-zero (Bug#10002)
7dbda6df 6008 (get_current_wm_state): Set net_wm_state_hidden_seen to 1 if
2b56b87e
JD
6009 _NET_WM_STATE_HIDDEN is in NET_WM_STATE.
6010
dbf31225
PE
60112011-11-28 Paul Eggert <eggert@cs.ucla.edu>
6012
6013 Remove GCPRO-related macros that exist only to avoid shadowing locals.
6014 * lisp.h (GCPRO1_VAR, GCPRO2_VAR, GCPRO3_VAR, GCPRO4_VAR, GCPRO5_VAR)
6015 (GCPRO6_VAR, UNGCPRO_VAR): Remove. See
6016 <http://lists.gnu.org/archive/html/emacs-diffs/2011-11/msg00265.html>.
6017 All uses changed to use GCPRO1 etc.
6018 (GCPRO1, GCPRO2, GCPRO3, GCPRO4, GCPRO5, GCPRO6, UNGCPRO):
6019 Revert to old implementation (i.e., before 2011-03-11).
6020
1305621b
YM
60212011-11-28 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
6022
6023 * dispnew.c (scrolling_window): Truncate overlaps in copy destination
6024 of scroll runs so as to avoid assigning disabled bogus rows and
6025 unnecessary graphics copy operations.
6026
8c9afb46
EZ
60272011-11-27 Eli Zaretskii <eliz@gnu.org>
6028
6029 * s/ms-w32.h (utimbuf) [_MSC_VER]: Don't define.
6030 (snprintf) [_MSC_VER]: Redirect to _snprintf.
6031 (strtoll) [_MSC_VER]: Redirect to _strtoi64.
6032 (malloc, free, realloc, calloc): Redirect to e_* only when
6033 compiling Emacs.
6034
6035 * lisp.h (GCTYPEBITS): Move before first use.
6036 (ALIGN_GCTYPEBITS) [_MSC_VER]: Define.
6037 (DECL_ALIGN) [_MSC_VER]: Use it, as MSVC doesn't like bit ops in
6038 this macro definition.
6039
6040 * s/ms-w32.h (tzname): Redirect to _tzname for all values of
6041 _MSC_VER.
6042
54e9e3bf
JD
60432011-11-27 Jan Djärv <jan.h.d@swipnet.se>
6044
6d5eb5b0
SM
6045 * gtkutil.c (xg_create_frame_widgets):
6046 Call gtk_window_set_has_resize_grip (FALSE) if that function is
54e9e3bf
JD
6047 present with Gtk+ 2.0.
6048
83aca1cb
PE
60492011-11-26 Paul Eggert <eggert@cs.ucla.edu>
6050
6051 * fileio.c (Finsert_file_contents): Undo previous change; see
6052 <http://lists.gnu.org/archive/html/emacs-diffs/2011-11/msg00265.html>.
6053
5b76caa4
PE
60542011-11-26 Paul Eggert <eggert@cs.ucla.edu>
6055
6056 Rename locals to avoid shadowing.
6057 * fileio.c (Finsert_file_contents):
6058 Rename inner 'gcpro1' to 'inner_gcpro1' to avoid shadowing.
6059 * process.c (wait_reading_process_output):
6060 Rename inner 'proc' to 'p' to avoid shadowing.
6061 Indent for consistency with usual Emacs style.
6062
8c535114
EZ
60632011-11-25 Eli Zaretskii <eliz@gnu.org>
6064
6065 * xdisp.c (redisplay_window): If cursor row is not fully visible
6066 after recentering, and scroll-conservatively is set to a large
6067 number, scroll window by a few more lines to make the cursor fully
6068 visible and out of scroll-margin. (Bug#10105)
91b4a718
EZ
6069 (start_display): Don't move to the next line if the display should
6070 start at a newline that is part of a display vector or an overlay
6071 string. (Bug#10119)
8c535114 6072
fa4fdb5c
JL
60732011-11-24 Juri Linkov <juri@jurta.org>
6074
6075 * image.c (imagemagick_load_image): Move `MagickSetResolution' down
6076 after the `MagickPingImage' call. (Bug#10112)
6077
90ec88df
CY
60782011-11-23 Chong Yidong <cyd@gnu.org>
6079
6080 * window.c (Fcoordinates_in_window_p): Accept only live windows.
6081
56e2e794
MR
60822011-11-23 Martin Rudalics <rudalics@gmx.at>
6083
6084 * buffer.c (Fkill_buffer): Run replace_buffer_in_windows before
6085 making another buffer current. (Bug#10114)
6086
b6e64c41
GM
60872011-11-23 Glenn Morris <rgm@gnu.org>
6088
6089 * font.c (font_find_for_lface) [HAVE_NS]: Ignore case. (Bug#2526)
6090
6b21de18
CY
60912011-11-23 Chong Yidong <cyd@gnu.org>
6092
6093 * xdisp.c (compute_stop_pos): Check validity of end_charpos before
6094 using it (Bug#5984).
6095
b12cd789
EZ
60962011-11-22 Eli Zaretskii <eliz@gnu.org>
6097
6098 * dispnew.c (adjust_glyph_matrix): Don't verify hash code of mode-
6099 and header-lines, as they don't have one computed for them.
6100 (Bug#10098)
6101
6102 * .gdbinit (prow): Make displayed values more self-explaining.
6103 Add row's hash code.
6104
261b6fd4
LMI
61052011-11-21 Lars Magne Ingebrigtsen <larsi@gnus.org>
6106
6107 * process.c (wait_reading_process_output): Fix asynchrounous
6108 GnuTLS socket handling on some versions of the GnuTLS library.
16c1ad08 6109 (wait_reading_process_output): Add comment and URL.
261b6fd4 6110
e7cfd277
JD
61112011-11-21 Jan Djärv <jan.h.d@swipnet.se>
6112
6113 * xterm.c (x_clear_frame): Reinstate the XClearWindow call.
6114
a9b9b7f5
CY
61152011-11-21 Chong Yidong <cyd@gnu.org>
6116
6117 * window.c (Fnext_window, Fprevious_window): Doc fix.
6118
b0d15b4f
SM
61192011-11-20 Stefan Monnier <monnier@iro.umontreal.ca>
6120
6121 * window.c (get_phys_cursor_glyph): Fix Lisp_Object/int mixup.
6122
fe7a3057
JB
61232011-11-20 Juanma Barranquero <lekktu@gmail.com>
6124
6125 * nsfont.m (syms_of_nsfont) <ns-reg-to-script>: Fix typo.
6126
d2999b1a
MR
61272011-11-20 Martin Rudalics <rudalics@gmx.at>
6128
6129 * window.c (Fset_window_combination_limit): Rename argument
6130 STATUS to LIMIT.
6131 (Vwindow_combination_limit): Remove "status" from doc-string.
6132
d5ff9cd0
AS
61332011-11-20 Andreas Schwab <schwab@linux-m68k.org>
6134
6135 * m/ibms390.h: Remove.
6136 * m/ibms390x.h: Don't include "ibms390.h".
6137
a5bb9bd3
SM
61382011-11-20 Stefan Monnier <monnier@iro.umontreal.ca>
6139
6140 * fileio.c (Finsert_file_contents): Add missing gcpro1 variable.
6141 Suggested by Dmitry Antipov <dmantipov@yandex.ru>.
6142
cd1181db
JB
61432011-11-20 Juanma Barranquero <lekktu@gmail.com>
6144
6145 * casetab.c (Fset_case_table):
6146 * charset.c (Fcharset_after): Fix typos.
6147
615a3b8d 61482011-11-20 Paul Eggert <eggert@cs.ucla.edu>
6a0bf43d 6149
17e845af
PE
6150 Standardize on VIRT_ADDR_VARIES behavior (Bug#10042).
6151 Otherwise, valgrind does not work on some platforms.
6152 Problem reported by Andreas Schwab in
6a0bf43d
PE
6153 <http://lists.gnu.org/archive/html/emacs-devel/2011-11/msg00081.html>.
6154 * puresize.h (pure, PURE_P): Always behave as if VIRT_ADDR_VARIES
6155 is set, removing the need for VIRT_ADDRESS_VARIES.
6156 (PURE_P): Use a more-efficient implementation that needs just one
6157 comparison, not two: on x86-64 with GCC 4.6.2, this cut down the
6158 number of instructions from 6 (xorl, cmpq, jge, xorl, cmpq, setge)
6159 to 4 (xorl, subq, cmpq, setbe).
6160 * alloc.c (pure): Always extern now, since that's the
6161 VIRT_ADDR_VARIES behavior.
6162 (PURE_POINTER_P): Use a single comparison, not two, for
6163 consistency with the new puresize.h.
6164 * lisp.h (PNTR_COMPARISON_TYPE): Remove; no longer needed.
6165 * m/ibms390.h, m/intel386.h, m/template.h, s/cygwin.h, s/hpux10-20.h:
6166 Remove VIRT_ADDR_VARIES no longer needed.
6167
f8fe6f96
EZ
61682011-11-19 Eli Zaretskii <eliz@gnu.org>
6169
6170 * xdisp.c (x_write_glyphs, draw_phys_cursor_glyph)
6171 (erase_phys_cursor, update_window_cursor, show_mouse_face)
6172 (cursor_in_mouse_face_p): If the cursor position is out of bounds,
6173 behave as if the cursor position were at the window margin.
6174
6175 * window.c (get_phys_cursor_glyph): If the window is hscrolled,
6176 and the cursor position is out of bounds, behave as if the cursor
6177 position were at the window margin. (Bug#10075)
6178
df05a53c
CY
61792011-11-18 Chong Yidong <cyd@gnu.org>
6180
6181 * window.c (Fwindow_combination_limit): Make first argument
6182 non-optional, since it is meaningless for live windows like the
6183 selected window.
61ccba97 6184
2071918e
DA
61852011-11-18 Dmitry Antipov <dmantipov@yandex.ru>
6186
6187 * keymap.c (Fwhere_is_internal): Add missing RETURN_UNGCPROs.
6188
b50a28de
SM
61892011-11-18 Stefan Monnier <monnier@iro.umontreal.ca>
6190
6191 * intervals.c: Fix grafting over the whole buffer (bug#10071).
6192 (graft_intervals_into_buffer): Simplify.
6193
015137db
EZ
61942011-11-18 Eli Zaretskii <eliz@gnu.org>
6195
6196 * dispnew.c (swap_glyph_pointers): Swap the used[] arrays and the
6197 hash values of the two rows.
6198 (copy_row_except_pointers): Preserve the used[] arrays and the
6199 hash values of the two rows. (Bug#10035)
68c95424 6200 (add_row_entry): Add xassert to verify that ROW's hash code is valid.
015137db
EZ
6201
6202 * xdisp.c (row_hash): New function, body extracted from
6203 compute_line_metrics.
6204 (compute_line_metrics): Call row_hash, instead of computing the
6205 hash code inline.
6206
6207 * dispnew.c (verify_row_hash): Call row_hash for computing the
6208 hash code of a row, instead of duplicating code from xdisp.c.
6209
6210 * dispextern.h (row_hash): Add prototype.
6211
a2addb04
TH
62122011-11-18 Tassilo Horn <tassilo@member.fsf.org>
6213
6214 * frame.c (delete_frame): Don't delete the terminal when the last
6215 X frame is closed if emacs is built with GTK toolkit.
6216
df85d315
JB
62172011-11-17 Juanma Barranquero <lekktu@gmail.com>
6218
6219 * window.c (syms_of_window) <window-combination-resize>: Fix typo.
6220
a0c2d0ae
MR
62212011-11-17 Martin Rudalics <rudalics@gmx.at>
6222
6223 * window.c (Vwindow_splits): Rename to
6224 Vwindow_combination_resize. Suggested by Juri Linkov.
6225 (Fsplit_window_internal): Use Vwindow_combination_resize instead
6226 of Vwindow_splits.
6227
58179cce
JB
62282011-11-16 Juanma Barranquero <lekktu@gmail.com>
6229
7877f373
JB
6230 * nsfns.m (Fns_font_name):
6231 * window.c (syms_of_window) <window-combination-limit>: Fix typos.
58179cce 6232
b6f67890
MR
62332011-11-16 Martin Rudalics <rudalics@gmx.at>
6234
6235 * window.h (window): Rename slot "nest" to "combination_limit".
6236 * window.c (Fwindow_nest): Rename to Fwindow_combination_limit.
6237 (Fset_window_nest): Rename to Fset_window_combination_limit.
6238 (Vwindow_nest): Rename to Vwindow_combination_limit.
6239 (recombine_windows, make_parent_window, make_window)
6240 (Fsplit_window_internal, saved_window)
6241 (Fset_window_configuration, save_window_save): Rename all
6242 occurrences of window_nest to window_combination_limit.
6243
c7015153
JB
62442011-11-15 Juanma Barranquero <lekktu@gmail.com>
6245
6246 * image.c (imagemagick_load_image): Fix typo.
6247
322ad6ec
EZ
62482011-11-14 Eli Zaretskii <eliz@gnu.org>
6249
6250 * xdisp.c (display_line): Move the call to
6251 highlight_trailing_whitespace before the call to
6252 compute_line_metrics, since the latter needs to see the final
6d5eb5b0
SM
6253 faces of all the glyphs to compute ROW's hash value.
6254 Fixes assertion violations in row_equal_p. (Bug#10035)
322ad6ec 6255
f067b8ec
JB
62562011-11-14 Juanma Barranquero <lekktu@gmail.com>
6257
6258 * w32proc.c (reader_thread): Don't check pending input if cp->fd < 0,
6259 just return (bug#10044).
6260
1e5b2111
EZ
62612011-11-12 Eli Zaretskii <eliz@gnu.org>
6262
7ef3cbd5
EZ
6263 * makefile.w32-in (HEAPSIZE): New variable, allows to build temacs
6264 with user-defined heap size. Bump the default size of the temacs
6265 heap to 27MB, to avoid memory warning when running temacs.
6266 ($(TEMACS)): Use HEAPSIZE instead of a hardcoded value.
6267
1e5b2111
EZ
6268 * dispnew.c (scrolling_window): Fix incorrect indices in accessing
6269 current_matrix and desired_matrix. (Bug#9990)
7a7270dd
EZ
6270 (verify_row_hash) [XASSERTS]: New function.
6271 (adjust_glyph_matrix, row_equal_p): Use it in xassert to verify
6272 that the hash value of glyph rows is correct.
1e5b2111 6273
89d61221
MR
62742011-11-12 Martin Rudalics <rudalics@gmx.at>
6275
6276 * window.h (window): Remove splits slot.
6277 * window.c (Fwindow_splits, Fset_window_splits): Remove.
6278 (Fdelete_other_windows_internal, make_parent_window)
6279 (make_window, Fsplit_window_internal, Fdelete_window_internal)
6280 (Fset_window_configuration, save_window_save): Don't deal with
6281 split status of windows.
6282 (saved_window): Remove splits slot.
6283 (Vwindow_splits): Rewrite doc-string.
6284
97f18cc8
JD
62852011-11-11 Jan Djärv <jan.h.d@swipnet.se>
6286
6287 * xfns.c (unwind_create_frame):
6288 * nsfns.m (unwind_create_frame):
6289 * w32fns.c (unwind_create_frame): Use Fmemq to check if frame is in
6290 Vframe_list (Bug#9999).
6291
22a648b4
DA
62922011-11-11 Dmitry Antipov <dmantipov@yandex.ru>
6293
0b381c7e 6294 * xdisp.c (syms_of_xdisp): Remove duplicated definition of Qtext.
22a648b4 6295
659afede
KH
62962011-11-11 Kenichi Handa <handa@m17n.org>
6297
6298 * callproc.c (Fcall_process): Set the member dst_multibyte of
6299 process_coding.
6300
9ac0394b
KH
63012011-11-11 Johan Bockgård <bojohan@gnu.org>
6302
6303 * xdisp.c (fill_composite_glyph_string): Always set s->face, to
6304 avoid a crash (bug#9496).
6305
2fbdc249
CY
63062011-11-09 Chong Yidong <cyd@gnu.org>
6307
6308 * window.c (Fwindow_inside_edges, Fwindow_inside_pixel_edges)
6309 (Fwindow_inside_absolute_pixel_edges): Only allow live windows.
6310
ac6b1f81
PE
63112011-11-08 Paul Eggert <eggert@cs.ucla.edu>
6312
6313 * s/gnu.h (GC_MARK_STACK): Define to GC_MAKE_GCPROS_NOOPS (Bug#9926).
6314
09db192c
PE
63152011-11-08 Paul Eggert <eggert@cs.ucla.edu>
6316
6317 Avoid some portability problems by eschewing 'extern inline' functions.
6318 The trivial performance wins aren't worth the portability hassles; see
6319 <http://lists.gnu.org/archive/html/emacs-devel/2011-11/msg00084.html>
6320 et seq.
6321 * dispextern.h (window_box, window_box_height, window_text_bottom_y)
6322 (window_box_width, window_box_left, window_box_left_offset)
6323 (window_box_right, window_box_right_offset): Undo previous change,
6324 by removing the "extern"s.
6325 * intervals.c (adjust_intervals_for_insertion)
6326 (adjust_intervals_for_deletion): Undo previous change,
6327 making these static again.
6328 (offset_intervals, temp_set_point_both, temp_set_point)
6329 (copy_intervals_to_string): No longer inline.
6330 * xdisp.c (window_text_bottom_y, window_box_width)
6331 (window_box_height, window_box_left_offset)
6332 (window_box_right_offset, window_box_left, window_box_right)
6333 (window_box): No longer inline.
6334
105216ed
CY
63352011-11-08 Chong Yidong <cyd@gnu.org>
6336
6337 * window.c (Fwindow_left_column, Fwindow_top_line): Doc fix.
6d5eb5b0
SM
6338 (Fwindow_body_height, Fwindow_body_width): Move from Lisp.
6339 Signal an error if not a live window.
105216ed
CY
6340 (Fwindow_total_width, Fwindow_total_height): Move from Lisp.
6341 (Fwindow_total_size, Fwindow_body_size): Move to Lisp.
6342
ae9e237f
JB
63432011-11-07 Juanma Barranquero <lekktu@gmail.com>
6344
6345 * lisp.h (syms_of_abbrev): Remove declaration.
6346 Reported by CHENG Gao <chenggao@royau.me>.
6347
c7aa8333
EZ
63482011-11-07 Eli Zaretskii <eliz@gnu.org>
6349
6350 * w32.c (check_windows_init_file): Don't look for term/w32-win.el
6351 if Vpurify_flag is non-nil. Fixes a crash when running w32 build
6352 of temacs in GUI mode.
6353
be7f5545
MR
63542011-11-07 Martin Rudalics <rudalics@gmx.at>
6355
6356 * window.h: Declare delete_all_child_windows instead of
6357 delete_all_subwindows.
6358 * window.c (Fwindow_nest, Fset_window_nest)
6359 (Fset_window_new_total, Fset_window_new_normal)
6360 (Fwindow_resize_apply): Don't use term subwindow in doc-strings.
6361 (delete_all_subwindows): Rename to delete_all_child_windows.
6362 (Fdelete_other_windows_internal, Fset_window_configuration):
6363 Call delete_all_child_windows instead of delete_all_subwindows.
6364 * frame.c (delete_frame): Call delete_all_child_windows instead
6365 of delete_all_subwindows.
6366
ca78dc43
PE
63672011-11-07 Paul Eggert <eggert@cs.ucla.edu>
6368
6369 * alloc.c (DEADP): New macro, for porting to GNU/Hurd (Bug#9926).
6370 This is also needed for porting to any host where GC_MARK_STACK is
6371 not GC_MAKE_GCPROS_NOOPS.
6372 (which_symbols): Use it.
6373
a0241d01
KH
63742011-11-07 Kenichi Handa <handa@m17n.org>
6375
6376 * coding.c (coding_set_destination): Check coding->src_pos only
6377 when coding->src_object is a buffer (bug#9910).
6378
6379 * process.c (send_process): Set the member src_multibyte of coding
6380 to 0 (bug#9911) when sending a unibyte text.
6381
6382 * callproc.c (Fcall_process): Set the member src_multibyte of
6383 process_coding to 0 (bug#9912).
6384
a64bfdfa 63852011-11-06 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
ba24cea2
YM
6386
6387 * xmenu.c (cleanup_widget_value_tree): New function.
6388 (xmenu_show, xdialog_show): Use it in record_unwind_protect instead of
6389 calling free_menubar_widget_value_tree directly (Bug#9830).
6390
cb41b32a
PE
63912011-11-06 Paul Eggert <eggert@cs.ucla.edu>
6392
6393 Fix some portability problems with 'inline'.
6394 * dispextern.h (window_box, window_box_height, window_text_bottom_y)
6395 (window_box_width, window_box_left, window_box_left_offset)
6396 (window_box_right, window_box_right_offset): Declare extern.
6397 Otherwise, these inline functions do not conform to C99 and
6398 are miscompiled by Microsoft compilers. Reported by Eli Zaretskii in
6399 <http://lists.gnu.org/archive/html/emacs-devel/2011-11/msg00084.html>.
6400 * intervals.c (adjust_intervals_for_insertion)
6401 (adjust_intervals_for_deletion): Now extern, because otherwise the
6402 extern inline functions 'offset_intervals' couldn't refer to it.
6403 (static_offset_intervals): Remove.
6404 (offset_intervals): Rewrite using the old contents of
6405 static_offset_intervals. The old version didn't conform to C99
6406 because an extern inline function contained a reference to an
6407 identifier with static linkage.
6408
b7041366
AS
64092011-11-06 Andreas Schwab <schwab@linux-m68k.org>
6410
6411 * keyboard.c (interrupt_signal): Don't call kill-emacs while in
6412 GC.
6413
88a37c4d
EZ
64142011-11-06 Eli Zaretskii <eliz@gnu.org>
6415
6416 * xdisp.c (init_iterator, reseat_to_string): Don't set the
6417 iterator's bidi_p flag if Vpurify_flag is non-nil. (Bug#9963)
6418 (Fcurrent_bidi_paragraph_direction): If Vpurify_flag is non-nil,
6419 return Qleft_to_right.
6420
49745b39
CY
64212011-11-06 Chong Yidong <cyd@gnu.org>
6422
6423 * window.c (Fwindow_live_p, Fwindow_frame, Fframe_root_window)
6424 (Fminibuffer_window, Fwindow_buffer, Fwindow_splits)
6425 (Fset_window_splits, Fwindow_nest, Fset_window_nest)
6426 (Fwindow_use_time, Fwindow_total_size, Fwindow_normal_size)
6427 (Fwindow_new_normal, Fwindow_left_column, Fwindow_top_line)
6428 (Fwindow_margins, Fwindow_fringes, Fwindow_scroll_bars)
6429 (Fwindow_vscroll): Doc fix.
6430 (Fwindow_top_child, Fwindow_left_child): Eliminate a nil default
6431 argument, since it makes no sense to pass a live window and for
6432 consistency with window-child.
6433
1f05cd82
CS
64342011-11-05 Christoph Scholtes <cschol2112@googlemail.com>
6435
6436 * makefile.w32-in ($(TEMACS), (gl-stamp)): Use $(THISDIR) to
6437 support MSVC.
6438
22610910
JR
64392011-11-05 Jason Rumney <jasonr@gnu.org>
6440
6441 * w32font.c (font_matches_spec): Filter out non-Japanese kana fonts.
6442 (add_font_entity_to_list): Filter out non-Japanese Shift-JIS
6443 fonts (Bug#6029).
6444 (add_font_entity_to_list): Fix logic errors in mixed boolean and
6445 bitwise arithmetic preventing use of unicode-sip and non-truetype
6446 opentype fonts.
6447
a06776b2
EZ
64482011-11-05 Eli Zaretskii <eliz@gnu.org>
6449
3ad924ba
EZ
6450 * s/ms-w32.h (fstat, stat, utime): Move redirections to
6451 "emacs"-only part.
6452
a06776b2
EZ
6453 * w32fns.c (x_create_tip_frame, Fx_create_frame): Rearrange
6454 initialization code to keep similarity to xfns.c after changes
6455 from 2011-11-05.
6456
c9e7db78
JD
64572011-11-05 Jan Djärv <jan.h.d@swipnet.se>
6458
a97f8f3f
JD
6459 * nsfns.m: Declare image_cache_refcount if GLYPH_DEBUG.
6460 (unwind_create_frame): New function (Bug#9943).
6461 (Fx_create_frame): Restructure code to be more similar to the one in
6462 xfns.c. Call record_unwind_protect with unwind_create_frame (Bug#9943).
6463 Initialize image_cache_refcount if GLYPH_DEBUG (Bug#9943).
6464 Move terminal->reference_count++ just before making the frame official
6465 (Bug#9943).
6466
6467 * nsterm.m (x_free_frame_resources): New function.
6468 (x_destroy_window): Move code to x_free_frame_resources.
6469
c9e7db78 6470 * xfns.c (unwind_create_frame): Fix comment.
6d5eb5b0
SM
6471 (Fx_create_frame, x_create_tip_frame):
6472 Move terminal->reference_count++ just before making the frame
75f1671a 6473 official. Move initialization of image_cache_refcount and
c9e7db78
JD
6474 dpyinfo_refcount before calling init_frame_faces (Bug#9943).
6475
a6fc3b5c
EZ
64762011-11-05 Eli Zaretskii <eliz@gnu.org>
6477
6478 Support MSVC build with newer versions of Visual Studio.
6479 * makefile.w32-in (TAGS-gmake): Don't use $(patsubst ...), as
6480 Nmake barfs on that. Use $(OBJ*_c) variables instead, defined on
6481 nt/gmake.defs.
6482
6483 * lisp.h (ENUM_BF): New macro, for enumerated types in bitfields,
6484 which are not supported by MSVC.
6485 (Lisp_Symbol, Lisp_Misc_Any, Lisp_Marker, Lisp_Misc_Overlay)
6486 (Lisp_Save_Value, Lisp_Free): Use ENUM_BF for enumerated types in
6487 bitfields.
6488 (Lisp_Object) [USE_LISP_UNION_TYPE]: Use ENUM_BF for enumerated
6489 types in bitfields.
6490 (DEFUN) [_MSC_VER]: Define in a different way for MSVC.
6491
6492 * w32fns.c [_MSC_VER]: DECLARE_HANDLE for any MSVC version.
6493
58179cce 64942011-11-05 Fabrice Popineau <fabrice.popineau@supelec.fr> (tiny change)
a6fc3b5c
EZ
6495
6496 Support MSVC build with newer versions of Visual Studio.
6497 * w32.c: Don't include w32api.h for MSVC.
6498 (init_environment) [_MSC_VER]: Call sys_access, not _access.
6499
6500 * s/ms-w32.h <sigset_t, ssize_t> [_MSC_VER]: Typedefs for MSVC.
6501 [_MSC_VER]: Include sys/timeb.h, sys/stat.h, and signal.h.
6502 (fstat, stat, utime) [_MSC_VER]: Redirect to their sys_* cousins.
6503 (malloc, free, realloc, calloc) [_MSC_VER]: Always redirect to the
6504 e_* cousins.
6505 (alloca) [_MSC_VER]: Define to _alloca.
6506
6507 * lisp.h (DECL_ALIGN) [_MSC_VER]: Define for MSVC.
6508
6509 * regex.c <re_char> [_MSC_VER]: A separate definition for MSVC.
6510
a58c13ed
EZ
65112011-11-04 Eli Zaretskii <eliz@gnu.org>
6512
6513 * xdisp.c (note_mouse_highlight): If either of
6514 previous/next-single-property-change returns nil, treat that as
6515 the beginning or the end of the buffer. (Bug#9955)
6516
fe0b6370
JD
65172011-11-04 Jan Djärv <jan.h.d@swipnet.se>
6518
a58c13ed 6519 * gtkutil.c (xg_make_tool_item): Add callbacks if one of wimage or
fe0b6370
JD
6520 label is not null (Bug#9951).
6521 (xg_tool_item_stale_p): Handle the fact that wimage and/or wlbl
6522 may be NULL.
6523
89bd5ee1
EZ
65242011-11-04 Eli Zaretskii <eliz@gnu.org>
6525
6526 * window.c (Fwindow_body_size): Mention in the doc string that the
6527 return value is in frame's canonical units. (Bug#9949)
6528
84c3edb9
EZ
65292011-11-03 Eli Zaretskii <eliz@gnu.org>
6530
4e2fb5c7
EZ
6531 * xdisp.c (note_mouse_highlight): Initialize `area'. (Bug#9947)
6532
84c3edb9 6533 * w32fns.c (unwind_create_frame): If needed, free the glyph
3ab15fd6 6534 matrices of the partially constructed frame. (Bug#9943)
2a58bbc1 6535 * xfns.c (unwind_create_frame): Likewise.
84c3edb9 6536
bc17a887
EZ
65372011-11-01 Eli Zaretskii <eliz@gnu.org>
6538
6539 * xdisp.c (mouse_face_from_buffer_pos): Fix a typo in a comment.
6540 Don't stop backward scan on the continuation glyph, even though
6541 its CHARPOS is positive.
6d5eb5b0
SM
6542 (mouse_face_from_buffer_pos, note_mouse_highlight):
6543 Rename cover_string to disp_string.
bc17a887 6544
4ee88440
MR
65452011-11-01 Martin Rudalics <rudalics@gmx.at>
6546
6547 * window.c (temp_output_buffer_show): Don't use
6548 Vtemp_buffer_show_specifiers.
6549 (Vtemp_buffer_show_specifiers): Remove unused variable.
6550
c2ff3c02
EZ
65512011-10-30 Eli Zaretskii <eliz@gnu.org>
6552
6553 * xdisp.c (try_cursor_movement): Make sure ROW isn't decremented
6554 past the beginning of the current glyph matrix.
6555
58179cce 65562011-10-30 Adam Sjøgren <asjo@koldfront.dk> (tiny change)
6e56383b
JD
6557
6558 * xterm.c: Include X11/Xproto.h if HAVE_GTK3.
6559 (x_error_handler): Ignore BadMatch for X_SetInputFocus for
6560 HAVE_GTK3 (Bug#9869).
b77a6a7f 6561
3b574623
JD
6562 * gtkutil.c (xg_win_to_widget, xg_event_is_for_menubar): Initialize
6563 type to GDK_NOTHING so valgrind does not complain (Bug#9901).
6564
b77a6a7f
JD
6565 * xterm.h (x_display_info): Add Xatom_net_wm_state_hidden (Bug#9893).
6566
6567 * xterm.c: Declare x_handle_net_wm_state to return int.
6568 (handle_one_xevent): Check if we are iconified but don't have
6569 _NET_WM_STATE_HIDDEN. If do, treat as deiconify (Bug#9893).
6570 (get_current_wm_state): Return non-zero if not hidden,
6571 check for _NET_WM_STATE_HIDDEN (Bug#9893).
6572 (do_ewmh_fullscreen): Ignore return value from get_current_wm_state.
6573 (x_handle_net_wm_state): Return what get_current_wm_state returns.
6574 (x_term_init): Initialize dpyinfo->Xatom_net_wm_state_hidden.
6575
196e41e4
PE
65762011-10-29 Paul Eggert <eggert@cs.ucla.edu>
6577
6578 * alloc.c (which_symbols): Declare EXTERNALLY_VISIBLE,
6579 so that this new function doesn't get optimized away by a
6580 whole-program optimizer. Make the 2nd arg EMACS_INT, not int.
6581
021f2e1a
AS
65822011-10-29 Andreas Schwab <schwab@linux-m68k.org>
6583
6584 * frame.h (MOUSE_HL_INFO): Remove excess parens.
6585
8b058d44
EZ
65862011-10-29 Eli Zaretskii <eliz@gnu.org>
6587
6588 Fix the `xbytecode' command.
6589 * .gdbinit (xprintbytestr): New command.
b50a28de 6590 (xwhichsymbols): Rename from `which'; all callers changed.
8b058d44
EZ
6591 (xbytecode): Print the byte-code string as well.
6592
4452fb80
EZ
65932011-10-29 Kim Storm <storm@cua.dk>
6594
8b058d44
EZ
6595 * alloc.c (which_symbols): New function.
6596
21b72067
AS
65972011-10-29 Andreas Schwab <schwab@linux-m68k.org>
6598
6599 * minibuf.c (read_minibuf_noninteractive): Allow reading empty
6600 line. (Bug#9903)
6601
83ed7b5c
GM
66022011-10-29 Glenn Morris <rgm@gnu.org>
6603
6604 * process.c (wait_reading_process_output): Revert 2009-08-30 change.
6605 Not clear what it was for, and it causes various bugs. (Bug#9839)
6606
5a7a728b
EZ
66072011-10-28 Eli Zaretskii <eliz@gnu.org>
6608
6609 * xdisp.c (note_mouse_highlight): Initialize `part', to avoid a
6610 possible random value that matches one of those tested as
6611 condition to clear the mouse face.
6612
d3d0842f
CY
66132011-10-28 Chong Yidong <cyd@gnu.org>
6614
6615 * xdisp.c (note_mouse_highlight): Fix use of uninitialized var.
6616
31b39d13
DN
66172011-10-28 Dan Nicolaescu <dann@ics.uci.edu>
6618
6619 * window.c (make_window): Initialize phys_cursor_on_p.
6620
9aba6043
SM
66212011-10-28 Stefan Monnier <monnier@iro.umontreal.ca>
6622
6623 * lisp.h (struct Lisp_Symbol): Update comments.
6624
c20992f4
JB
66252011-10-28 Juanma Barranquero <lekktu@gmail.com>
6626
6627 * w32font.c (w32_load_unicows_or_gdi32): Add missing return.
6628
db4f02f2
EZ
66292011-10-28 Eli Zaretskii <eliz@gnu.org>
6630
6631 Fix Emacs on Windows 9X (bug#8562). Thanks to oslsachem
6632 <oslsachem@gmail.com> for helping to debug this.
6633
6634 * w32font.c (g_b_init_is_w9x, g_b_init_get_outline_metrics_w)
6635 (g_b_init_get_text_metrics_w, g_b_init_get_glyph_outline_w)
6636 (g_b_init_get_glyph_outline_w): New static variables.
6637 (GetOutlineTextMetricsW_Proc, GetTextMetricsW_Proc)
6638 (GetGlyphOutlineW_Proc): New typedefs.
6639 (w32_load_unicows_or_gdi32, get_outline_metrics_w)
9aba6043
SM
6640 (get_text_metrics_w, get_glyph_outline_w, globals_of_w32font):
6641 New functions.
6642 (w32font_open_internal, compute_metrics):
6643 Call get_outline_metrics_w, get_text_metrics_w, and get_glyph_outline_w
db4f02f2
EZ
6644 instead of calling the "wide" APIs directly.
6645
6646 * emacs.c (main) [HAVE_NTGUI]: Call globals_of_w32font.
6647
6648 * w32.h (syms_of_w32font): Add prototype.
6649
87e68db4
JB
66502011-10-27 Juanma Barranquero <lekktu@gmail.com>
6651
6652 * window.c (Fframe_root_window, Fframe_first_window, Fwindow_end)
6653 (Fframe_selected_window, Ftemp_output_buffer_show, Fnext_window)
6654 (Fdelete_window_internal, Fwindow_parameters): Fix typos in docstrings.
6655 (Fmove_to_window_line): Doc fix.
6656
435c1d67
CY
66572011-10-27 Chong Yidong <cyd@gnu.org>
6658
6659 * process.c (make_process): Set gnutls_state to NULL.
6660
6661 * gnutls.c (emacs_gnutls_deinit): Deinit the gnutls_state if it is
6662 non-NULL, regardless of GNUTLS_INITSTAGE.
6663 (Fgnutls_boot): Cleanups. Call emacs_gnutls_deinit if we signal
6664 an error. Set process slots as soon as we allocate them.
6665
6666 * gnutls.h (GNUTLS_LOG, GNUTLS_LOG2): Fix macros.
6667
9c6c6f49
CY
66682011-10-27 Chong Yidong <cyd@gnu.org>
6669
9aba6043
SM
6670 * gnutls.c (emacs_gnutls_deinit): New function.
6671 Deallocate credentials structures as well as calling gnutls_deinit.
9c6c6f49
CY
6672 (Fgnutls_deinit, Fgnutls_boot): Use it.
6673
6674 * process.c (make_process): Initialize GnuTLS credentials to NULL.
6675 (deactivate_process): Call emacs_gnutls_deinit.
6676
657d08d3
JB
66772011-10-27 Juanma Barranquero <lekktu@gmail.com>
6678
6679 * image.c (x_create_x_image_and_pixmap):
6680 * w32.c (sys_rename, w32_delayed_load):
6681 * w32font.c (fill_in_logfont):
6682 * w32reg.c (x_get_string_resource): Silence compiler warnings.
6683
5430d399
JB
66842011-10-26 Juanma Barranquero <lekktu@gmail.com>
6685
6686 * w32fns.c (w32_default_color_map): New function,
6687 extracted from Fw32_default_color_map.
a7ef684b 6688 (Fw32_default_color_map, Fx_open_connection): Use it. (Bug#9785)
5430d399 6689
fe0055fa
PE
66902011-10-25 Paul Eggert <eggert@cs.ucla.edu>
6691
6692 * dispextern.h (Fcontrolling_tty_p): New decl (Bug#6649 part 2).
6693
e6346438
SM
66942011-10-25 Stefan Monnier <monnier@iro.umontreal.ca>
6695
6696 * keyboard.c (test_undefined): New function (bug#9751).
6697 (read_key_sequence): Use it to detect when a key is bound to `undefined'.
6698
e112cc37
ET
66992011-10-25 Enami Tsugutomo <tsugutomo.enami@jp.sony.com>
6700
6701 * sysdep.c (init_sys_modes): Fix the check for the controlling
6702 terminal (Bug#6649).
6703
7b5d6677
EZ
67042011-10-20 Eli Zaretskii <eliz@gnu.org>
6705
6706 * dispextern.h (struct bidi_it): New member next_en_type.
6707
6708 * bidi.c (bidi_line_init): Initialize the next_en_type member.
6709 (bidi_resolve_explicit_1): When next_en_pos is valid for the
6710 current character, check also for next_en_type being WEAK_EN.
6711 (bidi_resolve_weak): Don't enter the expensive loop if the current
6712 position is before next_en_pos. Record the bidi type of the first
6713 non-ET, non-BN character we find, in addition to its position.
6714 (bidi_level_of_next_char): Invalidate next_en_type when
6715 next_en_pos is over-stepped.
6716
7da0b018
PE
67172011-10-20 Paul Eggert <eggert@cs.ucla.edu>
6718
6719 Time zone name fixes for non-ASCII locales (Bug#641, Bug#9794)
6720 * editfns.c: Rewrite current-time-zone so that it invokes
6721 the equivalent of (format-time-string "%Z") to get the time zone name.
6722 This fixes a bug when the time zone name contains characters that
6723 need converting from the system time locale to Emacs internal format.
6724 This fixes a shortcoming that I introduced in my 1999-10-19 patch:
6725 that patch fixed format-time-string to do the conversion, but
6726 I forgot to fix current-time-zone.
6727 (format_time_string): New function, containing most of
6728 what Fformat_time_string used to contain.
6729 (Fformat_time_string): Rewrite in terms of format_time_string.
6730 This doesn't change this function's behavior.
6731 (current-time-zone): Rewrite to use format_time_string.
6732 This fixes the bug reported by Michael Schierl in
6733 <http://lists.gnu.org/archive/html/emacs-devel/2007-06/msg00334.html>.
6734 Jason Rumney's 2007-06-07 change worked around this bug, but
6735 didn't fix it.
6736 * systime.h (tzname, timezone): Remove no-longer-used declarations.
6737
8547b010
EZ
67382011-10-19 Eli Zaretskii <eliz@gnu.org>
6739
6740 * xdisp.c (start_display): If the character at POS is displayed
6741 via a display vector, reset IT->current.dpvec_index to zero.
12b32963
EZ
6742 (try_window_reusing_current_matrix): If a line ends in a display
6743 vector or the next line starts in a display vector, continue
6744 redrawing the window even though the character position of
6745 start_row was reached.
8547b010
EZ
6746 (Bug#9771, part 2)
6747
4e948d15
CY
67482011-10-18 Chong Yidong <cyd@gnu.org>
6749
6750 * xdisp.c (get_next_display_element): Handle U+2010 and U+2011
6751 with nobreak-char-display too.
6752
4787455f
EZ
67532011-10-18 Eli Zaretskii <eliz@gnu.org>
6754
6755 Fix part 3 of bug#9771.
6756 * bidi.c (bidi_line_init): Initialize next_en_pos to zero, not -1.
6757 (bidi_resolve_neutral): Don't enter the expensive loop looking for
6758 non-neutral characters if the current character is a paragraph
6759 separator (a.k.a. Newline). This avoids running the same
6760 expensive loop twice, once when we consume the preceding newline
6761 and the other time when the line actually needs to be displayed.
6762 Avoid the loop when we see neutrals on the base embedding level
6763 following a character whose directionality is the same as the
6764 paragraph's. This avoids running the expensive loop when a line
6765 ends in a long sequence of neutrals, like control characters.
6766 Add assertion against STRONG_AL type. Slightly rearrange code
6767 that determines the type of a neutral given the first non-neutral
6768 that follows it.
6769 (bidi_level_of_next_char): Set next_en_pos to zero when
6770 invalidating its info.
6771
2c91f553
EZ
67722011-10-17 Eli Zaretskii <eliz@gnu.org>
6773
6774 * xdisp.c (push_display_prop): Determine whether to record string
6775 or buffer position by IT->string, not by IT->method. Allow
6776 GET_FROM_DISPLAY_VECTOR as IT->method on entry. (Bug#9771, part 4)
f2ff9e88
EZ
6777 (move_it_vertically_backward): Don't look for character position
6778 immediately after the newline when in a continuation line.
6779 (Bug#9771, part 1)
2c91f553 6780
c7b08b0d
MR
67812011-10-15 Martin Rudalics <rudalics@gmx.at>
6782
6783 * window.c (coordinates_in_window): Rewrite and delabelize
6784 vertical border check. (Bug#5357) (Bug#9618)
6785
6b02f655
SM
67862011-10-14 Stefan Monnier <monnier@iro.umontreal.ca>
6787
6788 * xterm.c (frame_highlight, frame_unhighlight): Ignore unexplained
6789 errors in XSetWindowBorder (bug#9310).
6790
81d40c92
DA
67912011-10-13 Dmitry Antipov <dmantipov@yandex.ru>
6792
6793 * editfns.c (Fset_time_zone_rule): Replace free with xfree to
6794 avoid crash when xmalloc overrun checking is enabled.
6795
d4172c3b
EZ
67962011-10-13 Eli Zaretskii <eliz@gnu.org>
6797
6798 * xdisp.c (Fcurrent_bidi_paragraph_direction): Initialize
6799 itb.paragraph_dir to NEUTRAL_DIR. Fixes an occasional incorrect
6800 cursor motion with <left> and <right> arrow keys.
6801
6802 * bidi.c (bidi_init_it): Don't initialize paragraph_dir here, as
6803 some callers set that themselves.
6804
b00eea75
EZ
68052011-10-12 Eli Zaretskii <eliz@gnu.org>
6806
6807 * xdisp.c (find_row_edges): Handle the case where ROW comes from a
6808 display string and the previous row comes from the same string and
6809 is empty. (Bug#9739) (Bug#9738)
6810
8fe012c4
SM
68112011-10-12 Stefan Monnier <monnier@iro.umontreal.ca>
6812
6813 * doc.c (get_doc_string): Encode file name (bug#9735).
6814
0074aef2
EZ
68152011-10-12 Eli Zaretskii <eliz@gnu.org>
6816
79beb178
EZ
6817 * bidi.c (bidi_level_of_next_char):
6818 * xdisp.c (get_visually_first_element): Remove old incorrect
6819 comments regarding the Unicode Line Separator character.
6820
0074aef2
EZ
6821 * bidi.c (bidi_init_it): Initialize paragraph_dir to NEUTRAL_DIR.
6822
6e4b3fbe
DA
68232011-10-12 Dmitry Antipov <dmantipov@yandex.ru>
6824
6825 * alloc.c (Fgc_status): Do not access beyond zombies array
6826 boundary if nzombies > MAX_ZOMBIES.
6827 * alloc.c (dump_zombies): Add missing format specifier.
6828
0324f3af
PE
68292011-10-12 Paul Eggert <eggert@cs.ucla.edu>
6830
b5525cac
PE
6831 * xdisp.c (set_cursor_from_row): Simplify conditionals,
6832 to pacify GCC 4.6.1 x86-64 with -O2 -Wstrict-overflow.
6833
0324f3af
PE
6834 * lread.c (read_escape): Allow hex escapes as large as ?\xfffffff.
6835 Some packages use them to denote characters with modifiers.
6836
e9b5f888
AS
68372011-10-11 Andreas Schwab <schwab@linux-m68k.org>
6838
6839 * lisp.h (GCPRO1_VAR, GCPRO2_VAR, GCPRO3_VAR, GCPRO4_VAR)
6840 (GCPRO5_VAR, GCPRO6_VAR, UNGCPRO_VAR): Add whitespace to avoid
6841 matching a pp-number. Rename parameter var to var1.
6842
127827c0
SM
68432011-10-11 Stefan Monnier <monnier@iro.umontreal.ca>
6844
6845 * minibuf.c (Finternal_complete_buffer): Fix last change (bug#9709).
6846
c8fd3bd0
GM
68472011-10-08 Glenn Morris <rgm@gnu.org>
6848
6849 * callint.c (Fcall_interactively): Give a more explicit error for the
6850 'c' case with a non-character input. (Bug#8479)
6851
352ec8ff
EZ
68522011-10-08 Eli Zaretskii <eliz@gnu.org>
6853
03669ccb
EZ
6854 * xdisp.c (hscroll_window_tree): Support hscroll in right-to-left
6855 lines.
7061c986
EZ
6856 (set_cursor_from_row): Fix cursor positioning in mixed L2R+R2L
6857 lines that are hscrolled on the left.
03669ccb 6858
352ec8ff
EZ
6859 * dispnew.c (buffer_posn_from_coords): Account for a possible
6860 presence of header-line. (Bug#4426)
6861
a66cfb1c
SM
68622011-10-07 Stefan Monnier <monnier@iro.umontreal.ca>
6863
6b02f655
SM
6864 * buffer.c (syms_of_buffer) <enable-multibyte-characters>:
6865 Don't advertise functionality which we discourage or doesn't work.
a66cfb1c 6866
7c5ee88e
PE
68672011-10-07 Paul Eggert <eggert@cs.ucla.edu>
6868
6869 * alloc.c (GC_LISP_OBJECT_ALIGNMENT): Use offsetof, not __alignof__
6870 or sizeof. __alignof__ gives the wrong answer on Fedora x86-64
6871 with GCC 4.6.1 when configured with CC='gcc -m32' --with-wide-int;
6872 this makes Emacs dump core during garbage collection on rare
6873 occasions. sizeof is obviously inferior to offsetof here, so
6874 stick with offsetof.
6875 (GC_POINTER_ALIGNMENT): New macro.
6876 (mark_memory): Omit 3rd (offset) arg; caller changed.
6877 Don't assume EMACS_INT alignment is the same as pointer alignment.
6878
df1bbe5b
SM
68792011-10-03 Stefan Monnier <monnier@iro.umontreal.ca>
6880
6881 * keyboard.c (read_key_sequence_remapped): New var.
6882 (read_key_sequence): Compute remapping in the right buffer.
6883 (command_loop_1): Use read_key_sequence's remapping directly.
6884
51553db6
SM
68852011-10-02 Stefan Monnier <monnier@iro.umontreal.ca>
6886
32c1fffd
SM
6887 * dired.c (file_name_completion): Don't expand file name.
6888 (Ffile_name_completion, Ffile_name_all_completions): Expand file name
6889 before checking file name handler.
6890
51553db6
SM
6891 * minibuf.c (Finternal_complete_buffer): Only show internal buffers if
6892 they've been requested explicitly (bug#9591).
6893
b6bd1599 68942011-10-01 Andreas Schwab <schwab@linux-m68k.org>
fa2ec41f
AS
6895
6896 * keymap.c (Fsingle_key_description): Use make_specified_string
6897 instead of build_string to build string from push_key_description.
6898 (Bug#5193)
6899
f701dc2a
PE
69002011-09-30 Paul Eggert <eggert@cs.ucla.edu>
6901
4222c55d
PE
6902 * buffer.h (struct buffer): Use time_t, not int, for a time stamp.
6903 This fixes a Y2038 bug on 64-bit hosts.
6904 * buffer.c (reset_buffer):
6905 * fileio.c (Fdo_auto_save, Fset_buffer_auto_saved)
6906 (Fclear_buffer_auto_save_failure):
6907 Use 0, not -1, to represent an unset failure time, since time_t
6908 might not be signed.
6909
f701dc2a
PE
6910 Remove dependency on glibc malloc internals.
6911 * alloc.c (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
6912 Move back here from lisp.h, but with their new implementations.
6913 (XMALLOC_BASE_ALIGNMENT, COMMON_MULTIPLE, XMALLOC_HEADER_ALIGNMENT)
6914 (XMALLOC_OVERRUN_SIZE_SIZE): Move these new lisp.h macros here.
6915 * charset.c (charset_table_init): New static var.
6916 (syms_of_charset): Use it instead of xmalloc. This removes a
6917 dependency on glibc malloc internals. See Eli Zaretskii's comment in
6918 <http://lists.gnu.org/archive/html/emacs-devel/2011-09/msg00815.html>.
6919 * lisp.h (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
6920 Move back to alloc.c.
6921 (XMALLOC_BASE_ALIGNMENT, COMMON_MULTIPLE, XMALLOC_HEADER_ALIGNMENT)
6922 (XMALLOC_OVERRUN_SIZE_SIZE): Move to alloc.c.
6923
9ceebf39
JD
69242011-09-30 Jan Djärv <jan.h.d@swipnet.se>
6925
6926 * nsterm.m (windowDidResize): Call x_set_window_size only when
6927 ns_in_resize is true. Otherwise set pixelwidth/height and
6928 call change_frame_size (Bug#9628).
6929
cb993c58
PE
69302011-09-30 Paul Eggert <eggert@cs.ucla.edu>
6931
3930c88b
PE
6932 Port --enable-checking=all to Fedora 14 x86-64.
6933 * charset.c (syms_of_charset): Also account for glibc malloc's
6934 internal overhead when calculating the initial malloc maximum.
6935
cb993c58
PE
6936 Port --enable-checking=all to Fedora 14 x86.
6937 * alloc.c (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
6938 Move to lisp.h.
6939 (xmalloc_put_size, xmalloc_get_size, overrun_check_malloc)
6940 (overrun_check_realloc, overrun_check_free):
6941 Use XMALLOC_OVERRUN_SIZE_SIZE, not sizeof (size_t).
6942 That way, xmalloc returns a properly-aligned pointer even if
6943 XMALLOC_OVERRUN_CHECK is defined. The old debugging code happened
6944 to align OK on typical 64-bit hosts, but not on Fedora 14 x86.
6945 * charset.c (syms_of_charset): Take XMALLOC_OVERRUN_CHECK_OVERHEAD
6946 into account when calculating the initial malloc maximum.
6947 * lisp.h (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
6948 Move here from alloc.c, so that charset.c can use it too.
6949 Properly align; the old code wasn't right for common 32-bit hosts
6950 when configured with --enable-checking=all.
6951 (XMALLOC_BASE_ALIGNMENT, COMMON_MULTIPLE, XMALLOC_HEADER_ALIGNMENT)
6952 (XMALLOC_OVERRUN_SIZE_SIZE): New macros.
6953
31bed486
EZ
69542011-09-29 Eli Zaretskii <eliz@gnu.org>
6955
04c70788 6956 * sysdep.c (snprintf) [!EOVERFLOW]: If EOVERFLOW is not defined,
31bed486
EZ
6957 use EDOM.
6958
fbcaa2f3
EZ
69592011-09-28 Eli Zaretskii <eliz@gnu.org>
6960
6961 * xdisp.c (compute_display_string_end): If there's no display
6962 string at CHARPOS, return -1.
6963
6964 * bidi.c (bidi_fetch_char): When compute_display_string_end
6965 returns a negative value, treat the character as a normal
6966 character not covered by a display string. (Bug#9624)
6967
a239d4e9
JB
69682011-09-28 Juanma Barranquero <lekktu@gmail.com>
6969
6970 * lread.c (Fread_from_string): Fix typo in docstring.
6971
88652fd5
EZ
69722011-09-27 Eli Zaretskii <eliz@gnu.org>
6973
6974 * xdisp.c (handle_invisible_prop): If invisible text ends on a
6975 newline, reseat the iterator instead of bidi-iterating there one
6976 character at a time. (Bug#9610)
32c1fffd
SM
6977 (BUFFER_POS_REACHED_P, move_it_in_display_line_to): Bail when past
6978 TO_CHARPOS if the bidi iterator is at base embedding level.
88652fd5 6979
ed497dd4
AS
69802011-09-27 Andreas Schwab <schwab@linux-m68k.org>
6981
6982 * lread.c (readevalloop): Use correct code for NBSP.
6983 (read1): Likewise. (Bug#9608)
6984
b2bf61aa
MA
69852011-09-25 Michael Albinus <michael.albinus@gmx.de>
6986
6987 * dbusbind.c (Fdbus_register_signal): When service is not
6988 registered, use nil in Vdbus_registered_objects_table. (Bug#9581)
6989
32bbb17c
GM
69902011-09-25 Glenn Morris <rgm@gnu.org>
6991
6992 * buffer.c (truncate-lines): Doc fix.
6993
94e0933e
CY
69942011-09-24 Chong Yidong <cyd@stupidchicken.com>
6995
6996 * window.c (Fwindow_prev_buffers, Fset_window_prev_buffers)
6997 (Fset_window_next_buffers): Doc fix.
6998
cddde921
GM
69992011-09-24 Glenn Morris <rgm@gnu.org>
7000
7001 * minibuf.c (read_minibuf): Disable line truncation. (Bug#5715)
7002
1260aef1
PE
70032011-09-24 Paul Eggert <eggert@cs.ucla.edu>
7004
25b4bfa0
PE
7005 Fix minor problems found by static checking.
7006 * xdisp.c (string_from_display_spec): Don't assume vecsize fits in int.
1260aef1
PE
7007 * indent.c (Fvertical_motion): Fix == vs = typo.
7008
e3cbd34b
EZ
70092011-09-24 Eli Zaretskii <eliz@gnu.org>
7010
a66cfb1c
SM
7011 * dispnew.c (syms_of_display) <redisplay-dont-pause>:
7012 Default value is now t. Doc fix.
6bf7006f 7013
e3cbd34b 7014 * indent.c (Fvertical_motion): Compute and apply the overshoot
32c1fffd 7015 logic when moving up, not only when moving down. Fix the
e3cbd34b 7016 confusing name and values of the it_overshoot_expected variable;
32c1fffd 7017 logic changes accordingly. (Bug#9254) (Bug#9549)
e3cbd34b
EZ
7018
7019 * xdisp.c (pos_visible_p): Produce correct pixel coordinates when
7020 CHARPOS is covered by a display string which includes newlines.
7021 (move_it_vertically_backward): Avoid inflooping when START_CHARPOS
7022 is covered by a display string with embedded newlines.
7023
a3de0cbd
MA
70242011-09-24 Michael Albinus <michael.albinus@gmx.de>
7025
7026 * dbusbind.c (Fdbus_register_signal): Add match rule to
7027 Vdbus_registered_objects_table. (Bug#9581)
a66cfb1c
SM
7028 (Fdbus_register_method, Vdbus_registered_objects_table):
7029 Fix docstring.
a3de0cbd 7030
b260039d
JM
70312011-09-24 Jim Meyering <meyering@redhat.com>
7032
32c1fffd 7033 do not ignore write error for any output size
b260039d
JM
7034 The previous change was incomplete.
7035 While it makes emacs --batch detect the vast majority of stdout
7036 write failures, errors were still ignored whenever the output size is
7037 k * (BUFSIZ+1) - 4. E.g., on a system with BUFSIZ of 4096,
7038 $ emacs --batch --eval '(print (format "%4093d" 0))' > /dev/full \
7039 && echo FAIL: ignored write error
7040 FAIL: ignored write error
7041 $ emacs --batch --eval '(print (format "%20481d" 0))' > /dev/full \
7042 && echo FAIL: ignored write error
7043 FAIL: ignored write error
7044 * emacs.c (Fkill_emacs): Also test ferror. (Bug#9574)
7045
8eca8a7c
AS
70462011-09-23 Andreas Schwab <schwab@linux-m68k.org>
7047
7048 * emacs.c (Fkill_emacs): In noninteractive mode exit
7049 non-successfully if a write error occurred on stdout. (Bug#9574)
7050
3341db62
EZ
70512011-09-21 Eli Zaretskii <eliz@gnu.org>
7052
7053 * xdisp.c (pop_it): Allow it->object that is a cons cell to pass
7054 the xassert test.
7055
7056 * dispextern.h (struct it): Update the comment documenting what
7057 can it->OBJECT be.
7058
8c203dbf
EZ
70592011-09-20 Eli Zaretskii <eliz@gnu.org>
7060
7061 * xdisp.c (set_cursor_from_row): If the row ends in a newline from
7062 a display string, extend search for cursor position to end of row.
7063 (find_row_edges): If the row ends in a newline from a display
7064 string, increment its MATRIX_ROW_END_CHARPOS by one. (Bug#9549)
7065 Handle the case of a display string with multiple newlines.
fd317ddf
EZ
7066 (Fcurrent_bidi_paragraph_direction): Fix search for previous
7067 non-empty line. Fixes confusing cursor motion with arrow keys at
7068 the beginning of a line that starts with whitespace.
8c203dbf 7069
a4824228
LMI
70702011-09-19 Lars Magne Ingebrigtsen <larsi@gnus.org>
7071
7072 * lread.c (Fread_from_string): Document what FINAL-STRING-INDEX is
7073 (bug#9493).
7074
33ed493b
CY
70752011-09-18 Chong Yidong <cyd@stupidchicken.com>
7076
7077 * xfns.c (Fx_create_frame): Handle the bitmapIcon resource as
7078 boolean (Bug#9154).
7079
56cd55c8
EZ
70802011-09-18 Eli Zaretskii <eliz@gnu.org>
7081
7082 * xdisp.c (display_line): Record maximum and minimum buffer
7083 positions even if no glyphs were produced (e.g., by a zero-width
7084 stretch). Fixes bug#9530 on a TTY. Under word-wrap, don't record
7085 buffer positions that will be removed from the glyph row because
7086 they don't fit.
c02dcedf
EZ
7087 (produce_stretch_glyph): Fix a bug in :align-to on a TTY when the
7088 column is beyond frame width: don't subtract 1 "pixel" when
7089 computing width of the stretch.
3e62b7e0
EZ
7090 (reseat_at_next_visible_line_start): Undo the change made on
7091 2011-09-17 that saved paragraph information and restored it after
7092 the call to `reseat'. (Bug#9545)
56cd55c8 7093
5ed99d36 70942011-09-18 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
3390454c
YM
7095
7096 * xdisp.c (expose_window): Save original value of phys_cursor_on_p
7097 and turn window cursor on if cleared (Bug#9415).
7098
5ed99d36 70992011-09-18 Andreas Schwab <schwab@linux-m68k.org>
edb7b4dc
AS
7100
7101 * search.c (boyer_moore): Take unibyte characters from pattern
7102 literally. (Bug#9458)
7103
9bade7b2
EZ
71042011-09-18 Eli Zaretskii <eliz@gnu.org>
7105
7106 * xdisp.c (reseat_at_next_visible_line_start): Fix last change.
7107
e5e9d610
PE
71082011-09-18 Paul Eggert <eggert@cs.ucla.edu>
7109
87e4427a
PE
7110 Fix minor problem found by static checking.
7111 * xdisp.c (reseat_at_next_visible_line_start): Mark locals as
7112 initialized, to pacify gcc -Wuninitialized.
7113
e5e9d610
PE
7114 * fileio.c: Report proper errno when syscall falls.
7115 (Finsert_file_contents): Save and restore errno,
7116 so that report_file_error outputs the correct diagnostic.
7117 (Fwrite_region) [CLASH_DETECTION]: Likewise.
7118
a1674f0b
EZ
71192011-09-18 Eli Zaretskii <eliz@gnu.org>
7120
7121 * .gdbinit (pgx): Fix references to fields of `struct glyph'.
7122
fbfb6dd4
EZ
71232011-09-17 Eli Zaretskii <eliz@gnu.org>
7124
7125 * xdisp.c (produce_stretch_glyph): Another fix for changes made on
7126 2011-08-30T17:32:44Z!eliz@gnu.org. (Bug#9530)
7127
bb187662
EZ
71282011-09-17 Eli Zaretskii <eliz@gnu.org>
7129
1137e8b8 7130 * xdisp.c (reseat_at_next_visible_line_start): Keep information
6b02f655 7131 about the current paragraph and restore it after the call to reseat.
1137e8b8
EZ
7132
7133 * bidi.c (MAX_PARAGRAPH_SEARCH): New macro.
7134 (bidi_find_paragraph_start): Search back for paragraph beginning
7135 at most MAX_PARAGRAPH_SEARCH lines; if not found, return BEGV_BYTE.
7136 (bidi_move_to_visually_next): Only trigger paragraph-related
7137 computations when the last character is a newline or at EOB, not
7138 just any NEUTRAL_B. (Bug#9470)
7139
bb187662
EZ
7140 * xdisp.c (set_cursor_from_row): Don't invoke special treatment of
7141 truncated lines if point is covered by a display string. (Bug#9524)
7142
2e621251
PE
71432011-09-16 Paul Eggert <eggert@cs.ucla.edu>
7144
7145 * xselect.c: Relax test for outgoing X longs (Bug#9498).
7146 (cons_to_x_long): New function.
7147 (lisp_data_to_selection_data): Use it. Correct the test for
7148 short-versus-long data; it was negated. Break out of vector
7149 loop, for efficiency, when a long datum is discovered.
7150
91a15bc6
SM
71512011-09-16 Stefan Monnier <monnier@iro.umontreal.ca>
7152
7153 * eval.c (Fquote): Document its non-consing behavior (bug#9482).
7154
b41c3a35
EZ
71552011-09-16 Eli Zaretskii <eliz@gnu.org>
7156
7157 * image.c (tiff_handler): Work around a bug in MinGW GCC 3.x (see
7158 GCC PR/17406) by declaring this function with external scope.
7159
7812ba2d
PE
71602011-09-15 Paul Eggert <eggert@cs.ucla.edu>
7161
7162 * editfns.c (Fformat): Fix bug in text-property fix (Bug#9514).
7163 Don't mishandle (length (format "%%")) and (format "%4000s%%" "").
7164
cf7edc2a
AS
71652011-09-15 Andreas Schwab <schwab@linux-m68k.org>
7166
7167 * editfns.c (Fformat): Correctly handle text properties on "%%".
7168
bd01620e
EZ
71692011-09-15 Eli Zaretskii <eliz@gnu.org>
7170
7171 * xterm.c (x_draw_composite_glyph_string_foreground):
7172 * w32term.c (x_draw_composite_glyph_string_foreground):
7173 * term.c (encode_terminal_code):
7174 * composite.c (composition_update_it, get_composition_id):
7175 * xdisp.c (get_next_display_element)
7176 (fill_composite_glyph_string): Add comments about special meaning
7177 of TAB characters in a composition.
7178
a02719a3
PE
71792011-09-15 Paul Eggert <eggert@cs.ucla.edu>
7180
7181 * editfns.c (Fformat): Fix off-by-1 bug for "%%b" (Bug#9514).
4c122725
PE
7182 This occurs when processing a multibyte format.
7183 Problem reported by Wolfgang Jenker.
a02719a3 7184
72589a3c
JB
71852011-09-15 Johan Bockgård <bojohan@gnu.org>
7186
7187 * xdisp.c (try_cursor_movement): Only check for exact match if
7188 cursor hpos found by set_cursor_from_row is valid. (Bug#9495)
7189
1c14176c
PE
71902011-09-14 Paul Eggert <eggert@cs.ucla.edu>
7191
7192 Remove unused external symbols.
7193 * dispextern.h (calc_pixel_width_or_height): Remove decl.
7194 * xdisp.c (calc_pixel_width_or_height): Now static.
7195 * doprnt.c (exprintf) [! (HAVE_X_WINDOWS && USE_X_TOOLKIT)]: Remove.
7196 * indent.c (check_display_width):
7197 * w32term.c: Fix comment to match code.
7198 * xterm.c, xterm.h (x_catching_errors): Remove.
7199
d2eea5b5
PE
72002011-09-14 Paul Eggert <eggert@cs.ucla.edu>
7201
7202 * xselect.c: Use signed conversions more consistently (Bug#9498).
7203 (selection_data_to_lisp_data): Assume incoming selection data are
7204 signed integers, not unsigned. This is to be consistent with
7205 outgoing selection data, which was modified to use signed integers
7206 in as part of the fix to Bug#9196 in response to Jan D.'s comment
7207 in <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=9196#32> that X11
7208 expects long, not unsigned long.
7209
46888499
EZ
72102011-09-14 Eli Zaretskii <eliz@gnu.org>
7211
7212 * xdisp.c (try_window_reusing_current_matrix): Fix incorrect
7213 computation of loop end. Reported by Johan Bockgård
7214 <bojohan@gnu.org>.
7215
ef8ef9fb
CY
72162011-09-13 Chong Yidong <cyd@stupidchicken.com>
7217
7218 * frame.c (Fother_visible_frames_p): Function deleted.
7219
fa819fed
EZ
72202011-09-12 Eli Zaretskii <eliz@gnu.org>
7221
7222 * indent.c (compute_motion): Process display vector front to back
7223 rather than the other way around. (Bug#2496)
7224
2ba8e008
SM
72252011-09-12 Stefan Monnier <monnier@iro.umontreal.ca>
7226
7227 * fileio.c (Finsert_file_contents): Don't assume beg_offset is 0.
7228
20f53c69
CY
72292011-09-11 Chong Yidong <cyd@stupidchicken.com>
7230
7231 * minibuf.c (Fread_from_minibuffer): Doc fix.
7232
d562d7a4
EZ
72332011-09-11 Eli Zaretskii <eliz@gnu.org>
7234
7235 * xdisp.c (produce_stretch_glyph): Fix a typo made in changes from
7236 2011-08-30T17:32:44Z!eliz@gnu.org. (Bug#9475)
7237
1c4d7f3d
LMI
72382011-09-11 Lars Magne Ingebrigtsen <larsi@gnus.org>
7239
7240 * fileio.c (Fvisited_file_modtime): Document `(-1 65535)' as a
7241 value for non-existent files.
7242
b885bf36
EZ
72432011-09-11 Eli Zaretskii <eliz@gnu.org>
7244
7245 * fileio.c (Finsert_file_contents): If the file cannot be opened,
7246 set its "size" to -1. This will set the modtime_size field of
7247 the corresponding buffer to -1, which is what
7248 verify-visited-file-modtime expects for files that do not exist.
7249 (Bug#9139)
7250
6612f0bf
PE
72512011-09-11 Paul Eggert <eggert@cs.ucla.edu>
7252
7253 * keymap.h (KEY_DESCRIPTION_SIZE, push_key_description): Move decls
7254 here ...
7255 * lisp.h: ... from here. push_key_description is no longer
7256 defined in keyboard.c, so its declaration should not be in
7257 lisp.h's "Defined in keyboard.c" section, and KEY_DESCRIPTION_SIZE
7258 logically belongs with push_key_description.
7259
dfb3f755
PE
72602011-09-10 Paul Eggert <eggert@cs.ucla.edu>
7261
7262 * buffer.h: Include <sys/types.h> instead of <time.h>.
7263 Otherwise, off_t wasn't defined on FreeBSD 9.0-BETA2 i386.
7264 Problem reported by Herbert J. Skuhra.
7265
3134906c
LMI
72662011-09-10 Lars Magne Ingebrigtsen <larsi@gnus.org>
7267
7268 * xml.c (parse_region): Make the parsing work for
7269 non-comment-starting XML files again (bug#9144).
7270
8d903f4e
AS
72712011-09-10 Andreas Schwab <schwab@linux-m68k.org>
7272
7273 * image.c (gif_load): Fix calculation of bottom and right corner.
7274 (Bug#9468)
7275
80ad64f4
EZ
72762011-09-10 Eli Zaretskii <eliz@gnu.org>
7277
7278 * xdisp.c (MAX_DISP_SCAN): Decrease to 250. Prevents sluggish
7279 redisplay in small windows.
7280
208a048d
EZ
72812011-09-09 Eli Zaretskii <eliz@gnu.org>
7282
7283 * frame.c (x_report_frame_params): Cast to avoid compiler warnings.
7284
9b1c252e
MR
72852011-09-08 Martin Rudalics <rudalics@gmx.at>
7286
7287 * window.c (Fset_window_prev_buffers, Fset_window_next_buffers):
7288 Operate on live windows only.
7289
2949f33b
JB
72902011-09-08 Juanma Barranquero <lekktu@gmail.com>
7291
7292 * emacs.c (my_heap_start): #ifdef to avoid warnings when unused.
7293
e08dcafd
EZ
72942011-09-07 Eli Zaretskii <eliz@gnu.org>
7295
7296 * xdisp.c (move_it_in_display_line_to): Call RESTORE_IT on ppos_it
7297 only under bidi iteration.
7298
115b96bd
JD
72992011-09-07 Jan Djärv <jan.h.d@swipnet.se>
7300
7301 * gtkutil.c (xg_make_tool_item): Insert comment about eventbox.
7302
c8199d0f
PE
73032011-09-06 Paul Eggert <eggert@cs.ucla.edu>
7304
7305 isnan: Fix porting problem to Solaris 10 with bundled gcc.
7306 Without this fix, the command to link temacs failed due to an
7307 undefined symbol __builtin_isnan. This is because
7308 /usr/include/iso/math_c99.h #defines isnan(x) to
7309 __builtin_isnan(x), but the bundled gcc, which identifies itself
7310 as gcc 3.4.3 (csl-sol210-3_4-branch+sol_rpath), does not have
7311 a __builtin_isnan.
7312 * floatfns.c (isnan): #undef, and then #define to a clone of
7313 what's in data.c.
7314 (Fisnan): Always define, since it's always available now.
7315 (syms_of_floatfns): Always define isnan at the Lisp level.
7316
e39b275c 73172011-09-06 Paul Eggert <eggert@cs.ucla.edu>
1c262cae
PE
7318
7319 * Makefile.in (gl-stamp): move-if-change now in build-aux (Bug#9169).
7320
b2db44d9 73212011-09-06 Paul Eggert <eggert@cs.ucla.edu>
728f8f0a 7322
f4af5137 7323 * fileio.c: Fix bugs with large file offsets (Bug#9428).
728f8f0a
PE
7324 The previous code assumed that file offsets (off_t values) fit in
7325 EMACS_INT variables, which is not true on typical 32-bit hosts.
7326 The code messed up by falsely reporting buffer overflow in cases
7327 such as (insert-file-contents "big" nil 1 2) into an empty buffer
7328 when "big" contains more than 2**29 bytes, even though this
7329 inserts just one byte and does not overflow the buffer.
7330 (Finsert_file_contents): Store file offsets as off_t
7331 values, not as EMACS_INT values. Check for overflow when
7332 converting between EMACS_INT and off_t. When checking for
7333 buffer overflow or for overlap, take the offsets into account.
7334 Don't use EMACS_INT for small values where int suffices.
7335 When checking for overlap, fix a typo: ZV was used where
7336 ZV_BYTE was intended.
7337 (Fwrite_region): Don't assume off_t fits into 'long'.
7338 * buffer.h (struct buffer.modtime_size): Now off_t, not EMACS_INT.
7339
ecfc0a49
MA
73402011-09-05 Michael Albinus <michael.albinus@gmx.de>
7341
7342 * dbusbind.c (xd_signature_cat): Rename from signature_cat.
7343
6511acf2 73442011-09-04 Paul Eggert <eggert@cs.ucla.edu>
61bfeeb7 7345
0999621a 7346 sprintf-related integer and memory overflow issues (Bug#9412).
62f19c19
PE
7347
7348 * doprnt.c (doprnt): Support printing ptrdiff_t and intmax_t values.
8666506e 7349 (esprintf, exprintf, evxprintf): New functions.
62f19c19 7350 * keyboard.c (command_loop_level): Now EMACS_INT, not int.
6b02f655 7351 (cmd_error): Kbd macro iterations count is now EMACS_INT, not int.
62f19c19
PE
7352 (modify_event_symbol): Do not assume that the length of
7353 name_alist_or_stem is safe to alloca and fits in int.
7354 (Fexecute_extended_command): Likewise for function name and binding.
7355 (Frecursion_depth): Wrap around reliably on integer overflow.
7356 * keymap.c (push_key_description): First arg is now EMACS_INT, not int,
7357 since some callers pass EMACS_INT values.
7358 (Fsingle_key_description): Don't crash if symbol name contains more
7359 than MAX_ALLOCA bytes.
7360 * minibuf.c (minibuf_level): Now EMACS_INT, not int.
7361 (get_minibuffer): Arg is now EMACS_INT, not int.
7362 * lisp.h (get_minibuffer, push_key_description): Reflect API changes.
8666506e 7363 (esprintf, exprintf, evxprintf): New decls.
62f19c19
PE
7364 * window.h (command_loop_level, minibuf_level): Reflect API changes.
7365
2be7d702
PE
7366 * dbusbind.c (signature_cat): New function.
7367 (xd_signature, Fdbus_register_signal):
2ea16b89
PE
7368 Do not overrun buffer; instead, report string overflow.
7369
9d1df220
PE
7370 * dispnew.c (add_window_display_history): Don't overrun buffer.
7371 Truncate instead; this is OK since it's just a log.
7372
33ef5c64
PE
7373 * editfns.c (Fcurrent_time_zone): Don't overrun buffer
7374 even if the time zone offset is outlandishly large.
7375 Don't mishandle offset == INT_MIN.
7376
66c6fdd5
PE
7377 * emacs.c (main) [NS_IMPL_COCOA]: Don't overrun buffer
7378 when creating daemon; the previous buffer-overflow check was incorrect.
7379
d749b01b
PE
7380 * eval.c (verror): Simplify by rewriting in terms of evxprintf,
7381 which has the guts of the old verror function.
7382
b5cd1905
PE
7383 * filelock.c (lock_file_1, lock_file): Don't blindly alloca long name;
7384 use SAFE_ALLOCA instead. Use esprintf to avoid int-overflow issues.
7385
6e1a67fb
PE
7386 * font.c: Include <float.h>, for DBL_MAX_10_EXP.
7387 (font_unparse_xlfd): Don't blindly alloca long strings.
c21721cc 7388 Don't assume XINT result fits in int, or that XFLOAT_DATA * 10
8666506e 7389 fits in int, when using sprintf. Use single snprintf to count
c21721cc
PE
7390 length of string rather than counting it via multiple sprintfs;
7391 that's simpler and more reliable.
c21721cc
PE
7392 (font_unparse_fcname): Use it to avoid sprintf buffer overrun.
7393 (generate_otf_features) [0 && HAVE_LIBOTF]: Use esprintf, not
7394 sprintf, in case result does not fit in int.
7395
c57b67fc
PE
7396 * fontset.c (num_auto_fontsets): Now printmax_t, not int.
7397 (fontset_from_font): Print it.
7398
8a401434
PE
7399 * frame.c (tty_frame_count): Now printmax_t, not int.
7400 (make_terminal_frame, set_term_frame_name): Print it.
7401 (x_report_frame_params): In X, window IDs are unsigned long,
7402 not signed long, so print them as unsigned.
7403 (validate_x_resource_name): Check for implausibly long names,
7404 and don't assume name length fits in 'int'.
7405 (x_get_resource_string): Don't blindly alloca invocation name;
7406 use SAFE_ALLOCA. Use esprintf, not sprintf, in case result does
7407 not fit in int.
7408
6e1a67fb
PE
7409 * gtkutil.c: Include <float.h>, for DBL_MAX_10_EXP.
7410 (xg_check_special_colors, xg_set_geometry):
84722b3d
PE
7411 Make sprintf buffers a bit bigger, to avoid potential buffer overrun.
7412
0df02bf3
PE
7413 * lread.c (dir_warning): Don't blindly alloca buffer; use SAFE_ALLOCA.
7414 Use esprintf, not sprintf, in case result does not fit in int.
7415
48e30793
PE
7416 * macros.c (executing_kbd_macro_iterations): Now EMACS_INT, not int.
7417 (Fend_kbd_macro): Don't mishandle MOST_NEGATIVE_FIXNUM by treating
7418 it as a large positive number.
7419 (Fexecute_kbd_macro): Don't assume repeat count fits in int.
7420 * macros.h (executing_kbd_macro_iterations): Now EMACS_INT, not int.
7421
a66ff6d8
PE
7422 * nsterm.m ((NSSize)windowWillResize): Use esprintf, not sprintf,
7423 in case result does not fit in int.
7424
aca216ff
PE
7425 * print.c (float_to_string): Detect width overflow more reliably.
7426 (print_object): Make sprintf buffer a bit bigger, to avoid potential
7427 buffer overrun. Don't assume list length fits in 'int'. Treat
7428 print length of 0 as 0, not as infinity; to be consistent with other
7429 uses of print length in this function. Don't overflow print length
7430 index. Don't assume hash table size fits in 'long', or that
7431 vectorlike size fits in 'unsigned long'.
7432
31c286f7
PE
7433 * process.c (make_process): Use printmax_t, not int, to format
7434 process-name gensyms.
7435
55e5faa1
PE
7436 * sysdep.c (snprintf) [! HAVE_SNPRINTF]: New function.
7437
80f2e268
PE
7438 * term.c (produce_glyphless_glyph): Make sprintf buffer a bit bigger
7439 to avoid potential buffer overrun.
7440
670741ab
PE
7441 * xfaces.c (x_update_menu_appearance): Don't overrun buffer
7442 if X resource line is longer than 512 bytes.
7443
b7163a50
PE
7444 * xfns.c (x_window): Make sprintf buffer a bit bigger
7445 to avoid potential buffer overrun.
7446
ae58ff1f
PE
7447 * xterm.c (x_io_error_quitter): Don't overrun sprintf buffer.
7448
c43c8a6a
PE
7449 * xterm.h (x_check_errors): Add ATTRIBUTE_FORMAT_PRINTF.
7450
3f8236f4
PE
74512011-09-04 Paul Eggert <eggert@cs.ucla.edu>
7452
53e9fe90 7453 Integer overflow fixes for scrolling, etc.
6511acf2
PE
7454 Without these, Emacs silently mishandles large integers sometimes.
7455 For example, "C-u 4294967297 M-x recenter" was treated as if
53e9fe90
PE
7456 it were "C-u 1 M-x recenter" on a typical 64-bit host.
7457
6511acf2
PE
7458 * xdisp.c (try_window_id): Check Emacs fixnum range before
7459 converting to 'int'.
806add1d 7460
6511acf2 7461 * window.c (window_scroll_line_based, Frecenter):
71f02bc5
PE
7462 Check that an Emacs fixnum is in range before assigning it to 'int'.
7463 (Frecenter, Fmove_to_window_line): Use EMACS_INT, not int, for
7464 values converted from Emacs fixnums.
7465 (Frecenter): Don't wrap around a line count if it is out of 'int'
7466 range; instead, treat it as an extreme value.
7467 (Fset_window_configuration, compare_window_configurations):
7468 Use ptrdiff_t, not int, for index that might exceed 2 GiB.
7469
6511acf2
PE
7470 * search.c (Freplace_match): Use ptrdiff_t, not int, for indexes
7471 that can exceed INT_MAX. Check that EMACS_INT value is in range
7472 before assigning it to the (possibly-narrower) index.
a0efffc8
PE
7473 (match_limit): Don't assume that a fixnum can fit in 'int'.
7474
6511acf2 7475 * print.c (print_object): Use ptrdiff_t, not int, for index that can
29ebea3b
PE
7476 exceed INT_MAX.
7477
6511acf2 7478 * indent.c (position_indentation): Now takes ptrdiff_t, not int.
3f8236f4
PE
7479 (Fvertical_motion): Don't wrap around LINES values that don't fit
7480 in 'int'. Instead, treat them as extreme values. This is good
7481 enough for windows, which can't have more than INT_MAX lines anyway.
7482
fcb901a7
LMI
74832011-09-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
7484
0f2f6b6d
LMI
7485 * Require libxml/parser.h to avoid compilation warning.
7486
fcb901a7
LMI
7487 * emacs.c (shut_down_emacs): Call xmlCleanupParser on shutdown.
7488
7489 * xml.c (parse_region): Don't call xmlCleanupParser after parsing,
7490 since this reportedly can destroy thread storage.
7491
6e20a0d4
CY
74922011-08-30 Chong Yidong <cyd@stupidchicken.com>
7493
7494 * syntax.c (find_defun_start): Update all cache variables if
7495 exiting early (Bug#9401).
7496
148ae00e
EZ
74972011-08-30 Eli Zaretskii <eliz@gnu.org>
7498
f6cfbd8f
EZ
7499 * image.c (x_bitmap_pixmap): Cast to int to avoid compiler warnings.
7500
148ae00e
EZ
7501 * xdisp.c (produce_stretch_glyph): No longer static, compiled also
7502 when HAVE_WINDOW_SYSTEM is not defined. Support both GUI and TTY
7503 frames. Call tty_append_glyph in the TTY case. (Bug#9402)
7504
7505 * term.c (tty_append_glyph): New function.
7506 (produce_stretch_glyph): Static function and its prototype deleted.
7507
a66cfb1c
SM
7508 * dispextern.h (produce_stretch_glyph, tty_append_glyph):
7509 Add prototypes.
148ae00e 7510
c4a07a4c
PE
75112011-08-29 Paul Eggert <eggert@cs.ucla.edu>
7512
7513 * image.c (parse_image_spec): Check for nonnegative, not for positive,
7514 when checking :margin (Bug#9390).
7515 (IMAGE_NON_NEGATIVE_INTEGER_VALUE_OR_PAIR):
a66cfb1c 7516 Rename from IMAGE_POSITIVE_INTEGER_VALUE_OR_PAIR,
c4a07a4c
PE
7517 so that the name doesn't mislead. All uses changed.
7518
6bc8cd65
JB
75192011-08-28 Johan Bockgård <bojohan@gnu.org>
7520
7521 * term.c (init_tty) [HAVE_GPM]: Move mouse settings after
7522 set_tty_hooks.
7523
dca4927e
EZ
75242011-08-27 Eli Zaretskii <eliz@gnu.org>
7525
7526 * xdisp.c (move_it_to): Don't bail out early when reaching
7527 position beyond to_charpos, if we are scanning backwards.
7528 (move_it_vertically_backward): When DY == 0, make sure we get to
7529 the first character in the line after the newline.
7530
f2cad773
PE
75312011-08-27 Paul Eggert <eggert@cs.ucla.edu>
7532
7533 * ccl.c: Improve and simplify overflow checking (Bug#9196).
7534 (ccl_driver): Do not generate an out-of-range pointer.
7535 (Fccl_execute_on_string): Remove unnecessary check for
7536 integer overflow, noted by Stefan Monnier in
7537 <http://lists.gnu.org/archive/html/emacs-devel/2011-08/msg00979.html>.
7538 Remove a FIXME that didn't need fixing.
7539 Simplify the newly-introduced buffer reallocation code.
7540
0cae2cdb
JB
75412011-08-27 Juanma Barranquero <lekktu@gmail.com>
7542
7543 * makefile.w32-in ($(BLD)/alloc.$(O)): Depend on lib/verify.h.
7544
5fc295a4 75452011-08-26 Paul Eggert <eggert@cs.ucla.edu>
ddff3151 7546
70c60eb2 7547 Integer and memory overflow issues (Bug#9196).
726e0ab1 7548
d31850da
PE
7549 * doc.c (get_doc_string): Rework so that
7550 get_doc_string_buffer_size is the actual buffer size, rather than
7551 being 1 less than the actual buffer size; this makes xpalloc more
7552 convenient.
7553
a69fbedb
PE
7554 * image.c (x_allocate_bitmap_record, cache_image):
7555 * xselect.c (Fx_register_dnd_atom):
7556 Simplify previous changes by using xpalloc.
7557
fe5c5d37
PE
7558 * buffer.c (overlay_str_len): Now ptrdiff_t, not EMACS_INT,
7559 since either will do and ptrdiff_t is convenient with xpalloc.
7560
0065d054
PE
7561 * charset.c (charset_table_size)
7562 (struct charset_sort_data.priority): Now ptrdiff_t.
7563 (charset_compare): Don't overflow if priorities differ greatly.
7564 (Fsort_charsets): Don't assume list length fits in int.
7565 Check for size-calculation overflow when allocating sort data.
7566 (syms_of_charset): Allocate an initial charset table that is
7567 just under 64 KiB, to avoid problems with glibc malloc and mmap.
7568
7569 * cmds.c (internal_self_insert): Check for size-calculation overflow.
7570
7571 * composite.h (struct composition.glyph_len): Now int, not unsigned.
7572 The actual value is always <= INT_MAX, and leaving it unsigned made
7573 overflow checking harder.
7574
7575 * dispextern.h (struct glyph_matrix.rows_allocated)
7576 (struct face_cache.size): Now ptrdiff_t, for convenience in use
7577 with xpalloc. The values are still always <= INT_MAX.
7578
7579 * indent.c (compute_motion): Adjust to region_cache_forward sig change.
7580
7581 * lisp.h (xnmalloc, xnrealloc, xpalloc): New decls.
7582 (SAFE_NALLOCA): New macro.
7583
7584 * region-cache.c (struct boundary.pos, find_cache_boundary)
7585 (move_cache_gap, insert_cache_boundary, delete_cache_boundaries)
7586 (set_cache_region, invalidate_region_cache)
7587 (revalidate_region_cache, know_region_cache, region_cache_forward)
7588 (region_cache_backward, pp_cache):
7589 Use ptrdiff_t, not EMACS_INT, since either will do. This is needed
7590 so that ptrdiff_t * can be passed to xpalloc.
7591 (struct region_cache): Similarly, for gap_start, gap_len, cache_len,
7592 beg_unchanged, end_unchanged, buffer_beg, buffer_end members.
7593 (pp_cache): Don't assume cache_len fits in int.
7594 * region-cache.h: Adjust extern decls to match.
7595
7596 * search.c (scan_buffer, Freplace_match): Use ptrdiff_t, not
7597 EMACS_INT, since either will do, for xpalloc.
7598
7599 * alloc.c: Include verify.h, and check that int fits in ptrdiff_t.
7600 (xnmalloc, xnrealloc, xpalloc): New functions.
7601
726e0ab1
PE
7602 * bidi.c (bidi_shelve_header_size): New constant.
7603 (bidi_cache_ensure_space, bidi_shelve_cache): Use it.
7604 (bidi_cache_ensure_space): Avoid integer overflow when allocating.
7605
51f30bc5 7606 * bidi.c (bidi_cache_shrink):
726e0ab1
PE
7607 * buffer.c (overlays_at, overlays_in, record_overlay_string)
7608 (overlay_strings):
7609 Don't update size of array until after memory allocation succeeds,
7610 because xmalloc/xrealloc may not return.
0065d054
PE
7611 (struct sortstrlist.bytes): Now ptrdiff_t, as EMACS_INT doesn't help
7612 now that we have proper integer overflow checking.
7613 (record_overlay_string, overlay_strings): Catch overflows when
7614 calculating size of overlay_str_buf.
726e0ab1 7615
0065d054
PE
7616 * callproc.c (Fcall_process): Check for size overflow when
7617 calculating size of args2.
7618 (child_setup): Avoid overflow by using size_t rather than ptrdiff_t.
7619 Normally we prefer signed values, but sticking with ptrdiff_t would
7620 require adding more-complicated checks.
726e0ab1
PE
7621
7622 * ccl.c (Fccl_execute_on_string): Check for memory overflow.
7623 Use ptrdiff_t rather than EMACS_INT where ptrdiff_t will do.
7624 Redo buffer-overflow calculations to avoid integer overflow.
0065d054 7625 Add a FIXME comment where memory seems to be over-allocated.
726e0ab1
PE
7626
7627 * character.c (Fstring): Check for size-calculation overflow.
7628
7629 * coding.c (produce_chars): Redo buffer-overflow calculations to avoid
7630 unnecessary integer overflow. Check for size overflow.
7631 (encode_coding_object): Don't update size until xmalloc succeeds.
7632
7633 * composite.c (get_composition_id): Check for overflow in glyph
7634 length calculations.
7635
7636 Integer and memory overflow fixes for display code.
7637 * dispextern.h (struct glyph_pool.nglyphs): Now ptrdiff_t, not int.
7638 * dispnew.c (adjust_glyph_matrix, realloc_glyph_pool)
7639 (scrolling_window): Check for overflow in size calculations.
7640 (line_draw_cost, realloc_glyph_pool, add_row_entry):
7641 Don't assume glyph table len fits in int.
7642 (struct row_entry.bucket, row_entry_pool_size, row_entry_idx)
7643 (row_table_size): Now ptrdiff_t, not int.
7644 (scrolling_window): Avoid overflow in size calculations.
7645 Don't update size until allocation succeeds.
7646 * fns.c (concat): Check for overflow in size calculations.
7647 (next_almost_prime): Verify NEXT_ALMOST_PRIME_LIMIT.
7648 * lisp.h (RANGED_INTEGERP, TYPE_RANGED_INTEGERP): New macros.
7649 (NEXT_ALMOST_PRIME_LIMIT): New constant.
7650
7651 * doc.c (get_doc_string_buffer_size): Now ptrdiff_t, not int.
7652 (get_doc_string): Check for size calculation overflow.
7653 Don't update size until allocation succeeds.
7654 (get_doc_string, Fsubstitute_command_keys): Use ptrdiff_t, not
7655 EMACS_INT, where ptrdiff_t will do.
7656 (Fsubstitute_command_keys): Check for string overflow.
7657
7658 * editfns.c (set_time_zone_rule): Don't assume environment length
7659 fits in int.
7660 (message_length): Now ptrdiff_t, not int.
7661 (Fmessage_box): Don't update size until allocation succeeds.
7662 Don't assume message length fits in int.
7663 (Fformat): Use ptrdiff_t, not EMACS_INT, where ptrdiff_t will do.
7664
0065d054
PE
7665 * emacs.c (main): Do not reallocate argv, since there is a null at
7666 the end that can be overwritten, and this way there's no need to
7667 worry about size-calculation overflow.
7668 (sort_args): Check for size-calculation overflow.
726e0ab1
PE
7669
7670 * eval.c (init_eval_once, grow_specpdl): Don't update size until
7671 alloc succeeds.
7672 (call_debugger, grow_specpdl): Redo calculations to avoid overflow.
7673
7674 * frame.c (set_menu_bar_lines, x_set_frame_parameters)
7675 (x_set_scroll_bar_width, x_figure_window_size):
7676 Check for integer overflow.
7677 (x_set_alpha): Do not assume XINT fits in int.
7678
7679 * frame.h (struct frame): Use int, not EMACS_INT, where int works.
7680 This is for the members text_lines, text_cols, total_lines, total_cols,
7681 where the system imposes an 'int' limit.
7682
7683 * fringe.c (Fdefine_fringe_bitmap):
7684 Don't update size until alloc works.
7685
7686 * ftfont.c (ftfont_get_open_type_spec, setup_otf_gstring)
7687 (ftfont_shape_by_flt): Check for integer overflow in size calculations.
7688
7689 * gtkutil.c (get_utf8_string, xg_store_widget_in_map):
7690 Check for size-calculation overflow.
7691 (get_utf8_string): Use ptrdiff_t, not size_t, where either will
7692 do, as we prefer signed integers.
7693 (id_to_widget.max_size, id_to_widget.used)
7694 (xg_store_widget_in_map, xg_remove_widget_from_map)
7695 (xg_get_widget_from_map, xg_get_scroll_id_for_window)
7696 (xg_remove_scroll_bar, xg_update_scrollbar_pos):
7697 Use and return ptrdiff_t, not int.
7698 (xg_gtk_scroll_destroy): Don't assume ptrdiff_t fits in int.
7699 * gtkutil.h: Change prototypes to match the above.
7700
7701 * image.c (RANGED_INTEGERP, TYPE_RANGED_INTEGERP): Remove; these
7702 are duplicate now that they've been promoted to lisp.h.
7703 (x_allocate_bitmap_record, x_alloc_image_color)
7704 (make_image_cache, cache_image, xpm_load):
7705 Don't update size until alloc is done.
7706 (xpm_load, lookup_rgb_color, lookup_pixel_color, x_to_xcolors)
7707 (x_detect_edges):
3256efce 7708 Check for size calculation overflow.
726e0ab1
PE
7709 (ct_colors_allocated_max): New constant.
7710 (x_to_xcolors, x_detect_edges): Reorder multiplicands to avoid
7711 overflow.
3256efce 7712
726e0ab1
PE
7713 * keyboard.c (read_char, menu_bar_items, tool_bar_items)
7714 (read_char_x_menu_prompt, read_char_minibuf_menu_width)
7715 (read_char_minibuf_menu_prompt, follow_key, read_key_sequence):
7716 Use ptrdiff_t, not int, to count maps.
7717 (read_char_minibuf_menu_prompt): Check for overflow in size
a66cfb1c
SM
7718 calculations. Don't update size until allocation succeeds.
7719 Redo calculations to avoid overflow.
726e0ab1
PE
7720 * keyboard.h: Change prototypes to match the above.
7721
7722 * keymap.c (cmm_size, current_minor_maps): Use ptrdiff_t, not int,
7723 to count maps.
7724 (current_minor_maps): Check for size calculation overflow.
7725 * keymap.h: Change prototypes to match the above.
7726
7727 * lread.c (read1, init_obarray): Don't update size until alloc done.
7728
7729 * macros.c (Fstart_kbd_macro): Don't update size until alloc done.
7730 (store_kbd_macro_char): Reorder multiplicands to avoid overflow.
7731
726e0ab1
PE
7732 * nsterm.h (struct ns_color_table.size, struct ns_color_table.avail):
7733 Now ptrdiff_t, not int.
7734 * nsterm.m (ns_index_color): Use ptrdiff_t, not int, for table indexes.
7735 (ns_draw_fringe_bitmap): Rewrite to avoid overflow.
7736
7737 * process.c (Fnetwork_interface_list): Check for overflow
7738 in size calculation.
7739
7740 * region-cache.c (move_cache_gap): Check for size calculation overflow.
7741
7742 * scroll.c (do_line_insertion_deletion_costs): Check for size calc
7743 overflow. Don't bother calling xmalloc when xrealloc will do.
7744
7745 * search.c (Freplace_match): Check for size calculation overflow.
7746 (Fset_match_data): Don't assume list lengths fit in 'int'.
7747
7748 * sysdep.c (system_process_attributes): Use ptrdiff_t, not int,
7749 for command line length. Do not attempt to address one before the
7750 beginning of an array, as that's not portable.
7751
7752 * term.c (max_frame_lines): Remove; unused.
7753 (encode_terminal_src_size, encode_terminal_dst_size): Now ptrdiff_t,
7754 not int.
7755 (encode_terminal_code, calculate_costs): Check for size
7756 calculation overflow.
7757 (encode_terminal_code): Use ptrdiff_t, not int, to record glyph
7758 table lengths and related sizes. Don't update size until alloc
7759 done. Redo calculations to avoid overflow.
7760 (calculate_costs): Don't bother calling xmalloc when xrealloc will do.
7761
7762 * termcap.c (tgetent): Use ptrdiff_t, not int, to record results of
7763 subtracting pointers.
7764 (gobble_line): Check for overflow more carefully. Don't update size
7765 until alloc done.
7766
7767 * tparam.c (tparam1): Use ptrdiff_t, not int, for sizes.
7768 Don't update size until alloc done.
7769 Redo size calculations to avoid overflow.
7770 Check for size calculation overflow.
0065d054 7771 (main) [DEBUG]: Fix typo in invoking tparam1.
726e0ab1
PE
7772
7773 * xdisp.c (store_mode_line_noprop_char, x_consider_frame_title):
7774 Use ptrdiff_t, not int, for sizes.
7775 (store_mode_line_noprop_char): Don't update size until alloc done.
7776
0065d054
PE
7777 * xfaces.c (lface_id_to_name_size, Finternal_make_lisp_face):
7778 Use ptrdiff_t, not int, for sizes.
7779 (Finternal_make_lisp_face, cache_face):
7780 Check for size calculation overflow.
7781 (cache_face): Treat size calculation overflows as if they were
7782 memory exhaustion (the usual treatment), rather than aborting.
726e0ab1
PE
7783
7784 * xfns.c (x_encode_text, x_set_name_internal)
7785 (Fx_change_window_property): Use ptrdiff_t, not int, to count
7786 sizes, since they can exceed INT_MAX in size. Check for size
7787 calculation overflow.
7788
0065d054
PE
7789 * xgselect.c (gfds_size): Now ptrdiff_t, for convenience with xpalloc.
7790 (xg_select): Check for size calculation overflow.
726e0ab1
PE
7791 Don't update size until alloc done.
7792
0065d054 7793 * xrdb.c (get_environ_db): Don't assume path length fits in int,
726e0ab1 7794 as sprintf is limited to int lengths.
1d526e2f 7795
252c5ee1
PE
7796 * xselect.c (X_LONG_SIZE, X_SHRT_MAX, X_SHRT_MIN, X_LONG_MAX)
7797 (X_LONG_MIN): New macros.
864d7ce7
PE
7798 Use them to make the following changes clearer.
7799 (MAX_SELECTION_QUANTUM): Make the other bounds on this value clearer.
7800 This change doesn't affect the value now, but it may help remind
7801 future maintainers not to raise the value too much later.
7802 (SELECTION_QUANTUM): Remove, replacing with ...
7803 (selection_quantum): ... new function, which avoids overflow.
7804 All uses changed.
7805 (struct selection_data.size): Now ptrdiff_t, not int, to avoid
7806 assumption that selection length fits in 'int'.
7807 (x_reply_selection_request, x_handle_selection_request)
7808 (x_get_window_property, receive_incremental_selection)
7809 (x_get_window_property_as_lisp_data, selection_data_to_lisp_data)
7810 (lisp_data_to_selection_data, clean_local_selection_data):
7811 Use ptrdiff_t, not int, to record length of selection.
7812 (x_reply_selection_request, x_get_window_property)
7813 (receive_incremental_selection, x_property_data_to_lisp):
7814 Redo calculations to avoid overflow.
7815 (x_reply_selection_request): When sending hint, ceiling it at
252c5ee1 7816 X_LONG_MAX rather than relying on wraparound overflow to send
864d7ce7
PE
7817 something.
7818 (x_get_window_property, receive_incremental_selection)
7819 (lisp_data_to_selection_data, x_property_data_to_lisp):
7820 Check for size-calculation overflow.
7821 (x_get_window_property, receive_incremental_selection)
7822 (lisp_data_to_selection_data, Fx_register_dnd_atom):
7823 Don't store size until memory allocation succeeds.
7824 (x_get_window_property): Plug memory leak on memory exhaustion.
7825 Don't double-block input; malloc is safe here. Don't assume 2**34
7826 - 4 fits in unsigned long. Add an xassert to check
7827 XGetWindowProperty overflow. Be more careful about overflow
7828 calculations, and distinguish size from memory overflow better.
7829 (receive_incremental_selection): When tracing, don't assume
7830 unsigned int is less than INT_MAX.
7831 (x_selection_data_to_lisp_data): Remove unnecessary (and in theory
7832 harmful) conversions of unsigned short to int.
7833 (lisp_data_to_selection_data): Don't assume that integers
7834 in the range -65535 through -1 fit in an X unsigned short.
7835 Don't assume that ULONG_MAX == X_ULONG_MAX. Don't store into
7836 result parameters unless successful. Rely on cons_to_unsigned
7837 to report problems with elements; the old code wasn't right anyway.
7838 (x_check_property_data): Check for int overflow; we cannot use
7839 a wider type due to X limits.
7840 (x_handle_dnd_message): Use unsigned int, to avoid int overflow.
7841
726e0ab1 7842 * xsmfns.c (smc_save_yourself_CB): Check for size calc overflow.
34db673b 7843
0065d054
PE
7844 * xterm.c (x_color_cells, x_send_scrollbar_event, handle_one_xevent)
7845 (x_term_init): Check for size calculation overflow.
726e0ab1
PE
7846 (x_color_cells): Don't store size until memory allocation succeeds.
7847 (handle_one_xevent): Use ptrdiff_t, not int, for byte counts.
0065d054 7848 Don't assume alloca size is less than MAX_ALLOCA.
726e0ab1
PE
7849 (x_term_init): Don't assume length fits in int (sprintf is limited
7850 to int size).
bc18e09d 7851
ebfa62c0
PE
7852 Use ptrdiff_t for composition IDs.
7853 * character.c (lisp_string_width):
7854 * composite.c (composition_table_size, n_compositions)
7855 (get_composition_id, composition_gstring_from_id):
7856 * dispextern.h (struct glyph_string.cmp_id, struct composition_it.id):
7857 * xdisp.c (BUILD_COMPOSITE_GLYPH_STRING):
7858 * window.c (Frecenter):
7859 Use ptrdiff_t, not int, for composition IDs.
7860 * composite.c (get_composition_id): Check for integer overflow.
7861 * composite.h: Adjust prototypes to match the above changes.
7862
d3411f89
PE
7863 Use ptrdiff_t for hash table indexes.
7864 * category.c (hash_get_category_set):
7865 * ccl.c (ccl_driver):
7866 * charset.h (struct charset.hash_index, CHECK_CHARSET_GET_ID):
7867 * coding.c (coding_system_charset_list, detect_coding_system):
7868 * coding.h (struct coding_system.id):
7869 * composite.c (get_composition_id, gstring_lookup_cache):
7870 * fns.c (hash_lookup, hash_put, Fgethash, Fputhash):
7871 * image.c (xpm_get_color_table_h):
7872 * lisp.h (hash_lookup, hash_put):
7873 * minibuf.c (Ftest_completion):
7874 Use ptrdiff_t for hash table indexes, not int (which is too
7875 narrow, on 64-bit hosts) or EMACS_INT (which is too wide, on
7876 32-bit --with-wide-int hosts).
7877
e097a6fa
PE
7878 * charset.c (Fdefine_charset_internal): Check for integer overflow.
7879 Add a FIXME comment about memory leaks.
7880 (syms_of_charset): Don't assume xmalloc returns.
7881
5637687f
PE
7882 Don't assume that stated character widths fit in int.
7883 * character.c (Fchar_width, c_string_width, lisp_string_width):
7884 * character.h (CHAR_WIDTH):
7885 * indent.c (MULTIBYTE_BYTES_WIDTH):
7886 Use sanitize_char_width to avoid undefined and/or bad behavior
7887 with outlandish widths.
a66cfb1c 7888 * character.h (sanitize_tab_width): Rename from sanitize_width,
5637687f
PE
7889 now that we have two such functions. All uses changed.
7890 (sanitize_char_width): New inline function.
7891
a2271ba2
PE
7892 Don't assume that tab-width fits in int.
7893 * character.h (sanitize_width): New inline function.
7894 (SANE_TAB_WIDTH): New macro.
7895 (ASCII_CHAR_WIDTH): Use it.
7896 * indent.c (sane_tab_width): Remove. All uses replaced by
7897 SANE_TAB_WIDTH (current_buffer).
7898 * xdisp.c (init_iterator): Use SANE_TAB_WIDTH.
7899
18c52557
PE
7900 * fileio.c: Integer overflow issues with file modes.
7901 (Fset_file_modes, auto_save_1): Don't assume EMACS_INT fits in int.
7902
caeeedc1
PE
7903 * charset.c (read_hex): New arg OVERFLOW. All uses changed.
7904 Remove unreachable code.
7905 (read_hex, load_charset_map_from_file): Check for integer overflow.
7906
6df6ae42 7907 * xterm.c: Don't go over XClientMessageEvent limit.
50849c52
PE
7908 (scroll_bar_windows_size): Now ptrdiff_t, as we prefer signed.
7909 (x_send_scroll_bar_event): Likewise. Check that the size does not
7910 exceed limits imposed by XClientMessageEvent, as well as the usual
7911 ptrdiff_t and size_t limits.
7912
b13995db
PE
7913 * keyboard.c: Overflow, signedness and related fixes.
7914 (make_lispy_movement): Use same integer type in forward decl
7915 that is used in the definition.
7916 (read_key_sequence, keyremap_step):
7917 Change bufsize argument back to int, undoing my 2011-03-30 change.
7918 We prefer signed types, and int is wide enough here.
7919 (parse_tool_bar_item): Don't assume tool_bar_max_label_size is less
7920 than TYPE_MAXIMUM (EMACS_INT) / 2. Don't let the label size grow
7921 larger than STRING_BYTES_BOUND. Use ptrdiff_t for Emacs string
7922 length, not size_t. Use ptrdiff_t for index, not int.
7923 (keyremap_step, read_key_sequence): Redo bufsize check to avoid
7924 possibility of integer overflow.
7925
13464394
PE
7926 Overflow, signedness and related fixes for images.
7927
7928 * dispextern.h (struct it.stack[0].u.image.image_id)
7929 (struct_it.image_id, struct image.id, struct image_cache.size)
7930 (struct image_cache.used, struct image_cache.ref_count):
7931 * gtkutil.c (update_frame_tool_bar):
7932 * image.c (x_reference_bitmap, Fimage_size, Fimage_mask_p)
7933 (Fimage_metadata, free_image_cache, clear_image_cache, lookup_image)
7934 (cache_image, mark_image_cache, x_kill_gs_process, Flookup_image):
7935 * nsmenu.m (update_frame_tool_bar):
7936 * xdisp.c (calc_pixel_width_or_height):
7937 * xfns.c (image_cache_refcount):
7938 Image IDs are now ptrdiff_t, not int, to avoid arbitrary limits
7939 on typical 64-bit hosts.
7940
7941 * image.c (RANGED_INTEGERP, TYPE_RANGED_INTEGERP): New macros.
7942 (x_bitmap_pixmap, x_create_x_image_and_pixmap):
7943 Omit unnecessary casts to int.
7944 (parse_image_spec): Check that integers fall into 'int' range
7945 when the callers expect that.
7946 (image_ascent): Redo ascent calculation to avoid int overflow.
7947 (clear_image_cache): Avoid overflow when sqrt (INT_MAX) < nimages.
7948 (lookup_image): Remove unnecessary tests.
7949 (xbm_image_p): Locals are now of int, not EMACS_INT,
7950 since parse_image_check makes sure they fit into int.
7951 (png_load, gif_load, svg_load_image):
7952 Prefer int to unsigned where either will do.
7953 (tiff_handler): New function, combining the cores of the
a66cfb1c
SM
7954 old tiff_error_handler and tiff_warning_handler.
7955 This function is rewritten to use vsnprintf and thereby avoid
13464394
PE
7956 stack buffer overflows. It uses only the features of vsnprintf
7957 that are common to both POSIX and native Microsoft.
7958 (tiff_error_handler, tiff_warning_handler): Use it.
7959 (tiff_load, gif_load, imagemagick_load_image):
7960 Don't assume :index value fits in 'int'.
7961 (gif_load): Omit unnecessary cast to double, and avoid double-rounding.
7962 (imagemagick_load_image): Check that crop parameters fit into
7963 the integer types that MagickCropImage accepts. Don't assume
7964 Vimagemagick_render_type has a nonnegative value. Don't assume
7965 size_t fits in 'long'.
7966 (gs_load): Use printmax_t to print the widest integers possible.
7967 Check for integer overflow when computing image height and width.
7968
c11821d4
EZ
79692011-08-26 Eli Zaretskii <eliz@gnu.org>
7970
7971 * xdisp.c (redisplay_window): Don't force window start if point
7972 will be invisible in the resulting window. (Bug#9324)
7973
0c95fcf7
EZ
79742011-08-25 Eli Zaretskii <eliz@gnu.org>
7975
7976 * xdisp.c (compute_display_string_pos): Return 2 in DISP_PROP when
7977 the display spec is of the form `(space ...)'.
7978 (handle_display_spec): Return the value returned by
7979 handle_single_display_spec, not just 1 or zero.
7980 (handle_single_display_spec): If the display spec is of the form
7981 `(space ...)', and specifies display in the text area, return 2
7982 rather than 1.
fee65a97 7983 (try_cursor_movement): Check for the need to scroll more
a66cfb1c
SM
7984 accurately, and prefer exact match for point under bidi.
7985 Don't advance `row' beyond the last row of the window.
0c95fcf7
EZ
7986
7987 * dispextern.h (struct bidi_it): Rename the disp_prop_p member
7988 into disp_prop; all users changed.
7989
7990 * bidi.c (bidi_fetch_char): If compute_display_string_pos returns
7991 DISP_PROP = 2, substitute the u+2029 PARAGRAPH SEPARATOR character
7992 for the text covered by the display property.
7993
e4ed06f1
CY
79942011-08-25 Chong Yidong <cyd@stupidchicken.com>
7995
7996 * buffer.c (Fbury_buffer_internal): Rename from Funrecord_buffer.
7997 Change return value to nil.
7998 (Frecord_buffer): Delete unused function.
7999
f67cdd7f
EZ
80002011-08-24 Eli Zaretskii <eliz@gnu.org>
8001
5980d4c6
EZ
8002 * xdisp.c (Fcurrent_bidi_paragraph_direction): For unibyte
8003 buffers, return left-to-right.
8610fe8b
EZ
8004 (set_cursor_from_row): Consider candidate row a win if its glyph
8005 represents a newline and point is on that newline. Fixes cursor
8006 positioning on the newline at EOL of R2L text within L2R
8007 paragraph, and vice versa.
8008 (try_cursor_movement): Check continued rows, in addition to
8009 continuation rows. Fixes unwarranted scroll when point enters a
8010 continued line of R2L text within an L2R paragraph, or vice versa.
8011 (cursor_row_p): Consider the case of point being equal to
8012 MATRIX_ROW_END_CHARPOS. Prevents cursor being stuck when moving
8013 from the end of a short line to the beginning of a continued line
8014 of R2L text within L2R paragraph.
8015 (RECORD_MAX_MIN_POS): For max_pos, use IT_CHARPOS even for
8016 composed characters.
5980d4c6 8017
f67cdd7f
EZ
8018 * bidi.c (bidi_check_type): Use xassert.
8019 (bidi_cache_iterator_state): Update the disp_pos and disp_prop_p
8020 members.
8021
bca633fb
EZ
80222011-08-23 Eli Zaretskii <eliz@gnu.org>
8023
8024 * bidi.c (bidi_get_type): Abort if we get zero as the bidi type of
8025 a character.
8026
4a5885a7
CY
80272011-08-23 Chong Yidong <cyd@stupidchicken.com>
8028
8029 * nsfont.m (ns_otf_to_script): Fix typo.
8030
0902a04e
KH
80312011-08-22 Kenichi Handa <handa@m17n.org>
8032
8033 * chartab.c (Fset_char_table_extra_slot): Do not inhibit setting a
8034 extra slot even if the purpose is char-code-property-table.
8035
1a2e6670
EZ
80362011-08-23 Eli Zaretskii <eliz@gnu.org>
8037
8ddde651
EZ
8038 * xdisp.c (redisplay_window): When computing centering_position,
8039 account for the height of the header line. (Bug#8874)
8040
425cc014
EZ
8041 * dispnew.c (buffer_posn_from_coords): Use buf_charpos_to_bytepos
8042 instead of CHAR_TO_BYTE. Fixes a crash when a completion
8043 candidate is selected by the mouse, and that candidate has a
8044 composed character under the mouse.
8045
1a2e6670
EZ
8046 * xdisp.c (x_produce_glyphs): Set it->nglyphs to 1. Fixes pixel
8047 coordinates reported by pos-visible-in-window-p for a composed
8048 character in column zero.
8049
8b76d6f8
SM
80502011-08-23 Stefan Monnier <monnier@iro.umontreal.ca>
8051
8052 * cmds.c (Fself_insert_command): Mention post-self-insert-hook.
8053
dac347dd
EZ
80542011-08-22 Eli Zaretskii <eliz@gnu.org>
8055
8056 * xdisp.c (BUFFER_POS_REACHED_P): If this is a composition,
8057 consider it a hit if to_charpos is anywhere in the range of the
8058 composed buffer positions.
8059
e013fb34
CY
80602011-08-22 Chong Yidong <cyd@stupidchicken.com>
8061
8062 * image.c (gif_load): Don't assume that each subimage has the same
8063 dimensions as the base image. Handle disposal method that is
8064 "undefined" by the gif spec (Bug#9335).
8065
bd1ba3e8
CY
80662011-08-20 Chong Yidong <cyd@stupidchicken.com>
8067
8068 * eval.c (Fsignal): Handle `debug' symbol in error handler (Bug#9329).
024a2d76 8069 (Fcondition_case): Document `debug' symbol in error handler.
bd1ba3e8 8070
54a1215b
EZ
80712011-08-19 Eli Zaretskii <eliz@gnu.org>
8072
823564e5
EZ
8073 * xfaces.c (face_at_buffer_position): Avoid repeated evaluation of
8074 face ID by FACE_FROM_ID, and avoid a crash when mouse is moved
8075 from an Org mode buffer to a Speedbar frame.
8076
54a1215b
EZ
8077 * xdisp.c (RECORD_MAX_MIN_POS): If the display element comes from
8078 a composition, take its buffer position from IT->cmp_it.charpos.
8079 Fixes cursor positioning at the beginning of a line that begins
8080 with a composed character.
8081
9778ebcc
EZ
80822011-08-18 Eli Zaretskii <eliz@gnu.org>
8083
0be6ee06
EZ
8084 * bidi.c (bidi_get_type): If bidi_type_table reports zero as the
8085 character bidirectional type, use STRONG_L instead. Fixes crashes
8086 in a buffer produced by `describe-categories'.
8087
9778ebcc
EZ
8088 * dispextern.h (struct bidi_it): Move disp_pos and disp_prop_p
8089 members before the level stack, so they would be saved and
8090 restored when copying iterator state. Fixes incorrect reordering
8091 around TABs covered by display properties.
8092
156bffbe
AS
80932011-08-18 Andreas Schwab <schwab@linux-m68k.org>
8094
6b02f655 8095 * process.c (Fnetwork_interface_list): Correctly determine buffer size.
156bffbe 8096
72ad093b
CY
80972011-08-17 Chong Yidong <cyd@stupidchicken.com>
8098
8099 * eval.c (internal_condition_case, internal_condition_case_1)
8b76d6f8
SM
8100 (internal_condition_case_2, internal_condition_case_n):
8101 Remove unnecessary aborts (Bug#9081).
72ad093b 8102
35774242
EZ
81032011-08-17 Eli Zaretskii <eliz@gnu.org>
8104
8105 * lread.c (Fload) [DOS_NT]: If `openp' returns -2, but the file
8106 has no `load' handler, try opening the file locally. (Bug#9311)
8107
db76dd85
KB
81082011-08-16 Ken Brown <kbrown@cornell.edu>
8109
8110 * gmalloc.c: Expand comment.
8111
b215eee5
EZ
81122011-08-16 Eli Zaretskii <eliz@gnu.org>
8113
8114 * xdisp.c (set_cursor_from_row): Don't accept a previous candidate
8115 if it fails the cursor_row_p test. Fixes cursor positioning at ZV.
8116
a4579d33
KB
81172011-08-16 Ken Brown <kbrown@cornell.edu>
8118
8119 Fix memory allocation problems in Cygwin build (Bug#9273).
8120
8121 * unexcw.c ( __malloc_initialized): Declare external variable.
8122 (fixup_executable): Force the dumped emacs to reinitialize malloc.
8123
8b76d6f8
SM
8124 * gmalloc.c [CYGWIN] (bss_sbrk_heapbase, bss_sbrk_heapinfo):
8125 New variables.
a4579d33
KB
8126 (malloc_initialize_1) [CYGWIN]: Prepare for reinitializing the
8127 dumped emacs.
8128 (_free_internal_nolock) [CYGWIN]: Ignore requests to free storage
8129 in the static heap.
8130 [CYGWIN] (special_realloc): New function.
8131 (_realloc_internal_nolock) [CYGWIN]: Use the new function on
8132 requests to realloc storage in the static heap.
8133
3ebec551
PE
81342011-08-15 Paul Eggert <eggert@cs.ucla.edu>
8135
8136 * bidi.c (bidi_initialize): Remove unused local.
8137
9fd8be00
EZ
81382011-08-15 Eli Zaretskii <eliz@gnu.org>
8139
6b02f655
SM
8140 * bidimirror.h:
8141 * biditype.h: Remove file.
8142 * makefile.w32-in ($(BLD)/bidi.$(O)):
8143 * deps.mk (bidi.o): Remove biditype.h and bidimirror.h.
474a8465
EZ
8144
8145 * dispextern.h: Fix a typo in the comment to bidi_type_t.
8146
8147 * chartab.c: Improve commentary for the uniprop_table API.
8148
32413314
EZ
8149 * bidi.c (bidi_paragraph_init): Support zero value of
8150 bidi_ignore_explicit_marks_for_paragraph_level.
474a8465
EZ
8151 (bidi_initialize): Use uniprop_table instead of including
8152 biditype.h and bidimirror.h.
32413314 8153
9fd8be00
EZ
8154 * xdisp.c (move_it_in_display_line_to): Don't reset pixel
8155 coordinates of the iterator when restoring from ppos_it.
8156 (Bug#9296)
8157
5cf2b69b
KH
81582011-08-14 Kenichi Handa <handa@m17n.org>
8159
8160 * process.c (create_process): Call setup_process_coding_systems
72ad093b 8161 after the pid of the process is set to -1 (Bug#8162).
5cf2b69b 8162
daf17d00
EZ
81632011-08-14 Eli Zaretskii <eliz@gnu.org>
8164
8165 * xdisp.c (move_it_in_display_line_to): Don't invoke
8166 IT_RESET_X_ASCENT_DESCENT when iterator position was restored from
8167 ppos_it. Fixes vertical cursor motion when line beginning is
8168 covered by an image. (Bug#9296)
8169
08e3161a
JD
81702011-08-14 Jan Djärv <jan.h.d@swipnet.se>
8171
8172 * nsterm.h (ns_run_ascript): Declare.
8173 (NSAPP_DATA2_RUNASSCRIPT): Define.
8174
8175 * nsfns.m (as_script, as_result, as_status): New static variables.
8176 (ns_run_ascript): New function.
5e617bc2 8177 (Fns_do_applescript): Set variables as_*. Make an NSApplicationDefined
08e3161a
JD
8178 event with data2 set to NSAPP_DATA2_RUNASSCRIPT, post it and then start
8179 the event loop. Get status from as_status (Bug#7276).
8180
8181 * nsterm.m (sendEvent): If event is NSApplicationDefined and
8182 data2 is NSAPP_DATA2_RUNASSCRIPT, call ns_run_ascript and then exit
8183 the event loop (Bug#7276).
8184
a3720aa2
AS
81852011-08-14 Andreas Schwab <schwab@linux-m68k.org>
8186
8187 * gnutls.c (QCgnutls_bootprop_priority)
8188 (QCgnutls_bootprop_trustfiles, QCgnutls_bootprop_keylist)
8189 (QCgnutls_bootprop_crlfiles, QCgnutls_bootprop_callbacks)
8190 (QCgnutls_bootprop_loglevel, QCgnutls_bootprop_hostname)
8191 (QCgnutls_bootprop_min_prime_bits, QCgnutls_bootprop_verify_flags)
8192 (QCgnutls_bootprop_verify_hostname_error)
8193 (QCgnutls_bootprop_callbacks_verify): Rename from
8194 Qgnutls_bootprop_..., all uses changed.
8195
8196 * xfaces.c (QCignore_defface): Rename from Qignore_defface, all
8197 uses changed.
8198
0a0d27fb
PE
81992011-08-14 Paul Eggert <eggert@cs.ucla.edu>
8200
19d5c50c
PE
8201 * xfaces.c (Qframe_set_background_mode): Now static.
8202 * dispextern.h (Qframe_set_background_mode): Remove decl.
8203
0a0d27fb
PE
8204 * process.c (Fnetwork_interface_info): Declare local only if needed.
8205
377538cb
JD
82062011-08-13 Jan Djärv <jan.h.d@swipnet.se>
8207
8208 * process.c: Include ifaddrs.h and net/if_dl.h if available (Bug#8477).
8209 (Fnetwork_interface_list): Allocate in increments of bytes instead
8210 of sizeof (struct ifreq). Iterate over ifconf.ifc_req by counting
8211 bytes (Bug#8477). Count bytes correctly when ifr_addr is a struct
8212 sockaddr.
8213 (struct ifflag_def): notrailers is smart on OSX.
8214 (Fnetwork_interface_info): Handle case when ifr_flags is negative.
8215 Get hardware address with getifaddrs if available.
8216
08fff70c
EZ
82172011-08-12 Eli Zaretskii <eliz@gnu.org>
8218
8219 * xdisp.c (iterate_out_of_display_property): xassert that
8220 IT->position is set to within IT->object's boundaries. Break from
8221 the loop as soon as EOB is reached; avoids infloops in redisplay
8b76d6f8
SM
8222 when IT->position is set up wrongly due to some bug.
8223 Set IT->current to match the bidi iterator unconditionally.
08fff70c
EZ
8224 (push_display_prop): Allow GET_FROM_STRING as IT->method on
8225 entry. Force push_it to save on the stack the current
8226 buffer/string position, to be restored by pop_it. Fix flags in
8227 the iterator structure wrt the object coming from a display
8228 property, as `line-prefix' and `wrap-prefix' are not ``replacing''
8229 properties. (Bug#9284)
8230
7be1c708 82312011-08-09 Andreas Schwab <schwab@linux-m68k.org>
aac0c6e3 8232
7be1c708
CY
8233 * fontset.c (fontset_get_font_group): Add proper type checks.
8234 (Bug#9172)
aac0c6e3 8235
7be1c708 82362011-08-09 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
aac0c6e3 8237
7be1c708
CY
8238 * unexmacosx.c (print_load_command_name): Add cases LC_FUNCTION_STARTS
8239 and LC_VERSION_MIN_MACOSX.
8240 (copy_linkedit_data) [LC_FUNCTION_STARTS]: New function.
8241 (dump_it) [LC_FUNCTION_STARTS]: Use it.
aac0c6e3 8242
97bb72a6
EZ
82432011-08-08 Eli Zaretskii <eliz@gnu.org>
8244
8245 * xdisp.c (forward_to_next_line_start): Allow to use the
8b76d6f8
SM
8246 no-display-properties-and-no-overlays under bidi display.
8247 Set disp_pos in the bidi iterator to avoid searches for display
757664a4 8248 properties and overlays.
97bb72a6 8249
d5617611
CY
82502011-08-08 Chong Yidong <cyd@stupidchicken.com>
8251
37e11a63
CY
8252 * editfns.c (Fset_time_zone_rule): Document relationship with the
8253 setenv function.
8254
d5617611
CY
8255 * ftfont.c (ftfont_pattern_entity): Copy the extras argument to
8256 the font entity extracted from the cache (Bug#8109).
8257
58872834
CY
82582011-08-07 Chong Yidong <cyd@stupidchicken.com>
8259
8260 * composite.c (autocmp_chars): Don't reset point. That is done by
8261 restore_point_unwind (Bug#5984).
8262
75bfc667
JL
82632011-08-07 Juri Linkov <juri@jurta.org>
8264
8265 * editfns.c (Fformat_time_string): Doc fix, add tag `usage:'
8266 to show the arg `TIME' instead of `TIMEVAL'.
8267
d1410150
EZ
82682011-08-06 Eli Zaretskii <eliz@gnu.org>
8269
8270 * xdisp.c (set_cursor_from_row): Fix cursor positioning when a
8271 display property strides EOL and includes a newline, as in
8272 longlines-mode. (Bug#9254)
75b771e4
EZ
8273 (move_it_in_display_line_to): Fix vertical-motion in a buffer with
8274 word-wrap under bidirectional display. (Bug#9224)
d1410150
EZ
8275
8276 * bidi.c (bidi_unshelve_cache): Don't reset the cache if JUST_FREE
8277 is non-zero, even if the data buffer is NULL. Fixes a crash in
8278 vertical-motion with longlines-mode. (Bug#9254)
8279
35928349
EZ
82802011-08-05 Eli Zaretskii <eliz@gnu.org>
8281
ec7cc85b
EZ
8282 * bidi.c <bidi_cache_total_alloc>: Now static.
8283 (bidi_initialize): Initialize bidi_cache_total_alloc.
8284
8b76d6f8 8285 * xdisp.c (display_line): Release buffer allocated for shelved bidi
35928349
EZ
8286 cache. (Bug#9221)
8287
8288 * bidi.c (bidi_shelve_cache, bidi_unshelve_cache): Track total
8289 amount allocated this far in `bidi_cache_total_alloc'.
8290 (bidi_unshelve_cache): Accept an additional argument JUST_FREE; if
8291 non-zero, only free the data buffer without restoring the cache
8292 contents. All callers changed.
8293
8294 * dispextern.h (bidi_unshelve_cache): Update prototype.
8295
8296 * xdisp.c (SAVE_IT, pos_visible_p, move_it_in_display_line_to)
8297 (move_it_in_display_line, move_it_to)
8298 (move_it_vertically_backward, move_it_by_lines): Replace the call
8299 to xfree to an equivalent call to bidi_unshelve_cache.
8300 (move_it_in_display_line_to): Fix logic of returning
412b6358 8301 MOVE_POS_MATCH_OR_ZV in the bidi case. (Bug#9224)
35928349 8302
e2e2423b
EZ
83032011-08-05 Eli Zaretskii <eliz@gnu.org>
8304
8305 * xdisp.c (set_cursor_from_row): Prefer the candidate glyph that
8306 came from a string character with a `cursor' property. (Bug#9229)
8307
ae9e757a
JD
83082011-08-04 Jan Djärv <jan.h.d@swipnet.se>
8309
8310 * Makefile.in (LIB_PTHREAD): New variable.
8311 (LIBES): Add LIB_PTHREAD (Bug#9216).
8312
8313 * alloc.c, emacs.c, gmalloc.c, gtkutil.c, keyboard.c, syssignal.h:
8314 Rename HAVE_GTK_AND_PTHREAD to HAVE_PTHREAD (Bug#9216).
8315
213bd7f2
AS
83162011-08-04 Andreas Schwab <schwab@linux-m68k.org>
8317
6b02f655 8318 * regex.c (re_iswctype): Remove some redundant boolean conversions.
213bd7f2 8319
99aaf75f
JD
83202011-08-04 Jan Djärv <jan.h.d@swipnet.se>
8321
8322 * xterm.c (x_find_topmost_parent): New function.
8323 (x_set_frame_alpha): Find topmost parent window with
8324 x_find_topmost_parent and set the property there also (bug#9181).
8325 (handle_one_xevent): Call x_set_frame_alpha on ReparentNotify.
8326
c74e9d86
PE
83272011-08-04 Paul Eggert <eggert@cs.ucla.edu>
8328
8329 * callproc.c (Fcall_process): Avoid vfork clobbering
8330 the local vars buffer, coding_systems, current_dir.
8331
640c8776
SM
83322011-08-03 Stefan Monnier <monnier@iro.umontreal.ca>
8333
8334 * keymap.c (Fmake_composed_keymap): Move to subr.el.
8335
f26d0e4c
PE
83362011-08-03 Paul Eggert <eggert@cs.ucla.edu>
8337
8a10d76c
PE
8338 * fontset.c (dump_fontset) [FONTSET_DEBUG]: Declare EXTERNALLY_VISIBLE
8339 so that it is not optimized away.
8340
f26d0e4c
PE
8341 * xdisp.c (compute_display_string_pos): Remove unused local.
8342
55439c61
EZ
83432011-08-02 Eli Zaretskii <eliz@gnu.org>
8344
8345 Fix slow cursor motion and scrolling in large buffers with
8346 selective display, like Org Mode buffers. (Bug#9218)
8347
8348 * dispextern.h (struct bidi_it): New member disp_prop_p.
8349
8350 * xdisp.c: Remove one-slot cache of display string positions.
8351 (compute_display_string_pos): Accept an additional argument
5e617bc2 8352 DISP_PROP_P; callers changed. Scan at most 5K characters forward
55439c61
EZ
8353 for a display string or property. If found, set DISP_PROP_P
8354 non-zero.
8355
8356 * bidi.c (bidi_fetch_char): Accept an additional argument
640c8776
SM
8357 DISP_PROP_P, and pass it to compute_display_string_pos.
8358 Only handle text covered by a display string if DISP_PROP_P is returned
55439c61
EZ
8359 non-zero. All callers of bidi_fetch_char changed.
8360
fb33fa43
SM
83612011-08-02 Stefan Monnier <monnier@iro.umontreal.ca>
8362
8363 * keymap.c (Fdefine_key): Fix Lisp_Object/int mixup; apply some CSE.
8364
b099e063
DM
83652010-12-03 Don March <don@ohspite.net>
8366
8367 * keymap.c (Fdefine_key): Fix non-prefix key error message when
8368 last character M-[char] is translated to ESC [char] (bug#7541).
8369
5cc7f7af
KH
83702011-08-02 Kenichi Handa <handa@m17n.org>
8371
d0fffa3f 8372 * lisp.h (uniprop_table): Extern it.
5cc7f7af
KH
8373
8374 * chartab.c (uniprop_table): Make it non-static.
8375
525d5e6e
EZ
83762011-08-01 Eli Zaretskii <eliz@gnu.org>
8377
8378 * xdisp.c (forward_to_next_line_start): Accept additional argument
8379 BIDI_IT_PREV, and store into it the state of the bidi iterator had
8380 on the newline.
8381 (reseat_at_next_visible_line_start): Use the bidi iterator state
8382 returned by forward_to_next_line_start to restore the state of
8383 it->bidi_it after backing up to previous newline. (Bug#9212)
8384
31011111
AS
83852011-07-30 Andreas Schwab <schwab@linux-m68k.org>
8386
8387 * regex.c (re_comp): Protoize.
8388 (re_exec): Fix return type.
8389 (regexec): Fix type of `ret'. (Bug#9203)
8390
476371c4
PE
83912011-07-28 Paul Eggert <eggert@cs.ucla.edu>
8392
e5d76069
PE
8393 * image.c (check_image_size): Use 1024x1024 if unknown frame (Bug#9189).
8394 This is needed if max-image-size is a floating-point number.
8395
9a79b20c
AS
83962011-07-28 Andreas Schwab <schwab@linux-m68k.org>
8397
8398 * print.c (print_object): Print empty symbol as ##.
8399
8400 * lread.c (read1): Read ## as empty symbol.
8401
d8c2fa78
AA
84022011-07-28 Alp Aker <alp.tekin.aker@gmail.com>
8403
8404 * nsfns.m (x_set_foreground_color): Set f->foreground_pixel when
8405 setting frame foreground color (Bug#9175).
8406 (x_set_background_color): Likewise.
8407
ffe57a7a
AA
8408 * nsmenu.m (-setText): Size tooltip dimensions precisely to
8409 contents (Bug#9176).
8410 (EmacsTooltip -init): Remove bezels and add shadows to
8411 tooltip windows.
8412
bf3492a5
AA
8413 * nsterm.m (ns_dumpglyphs_stretch): Avoid overwriting left fringe
8414 or scroll bar (Bug#8470).
8415
d55e9c53
AA
8416 * nsfont.m (nsfont_open): Remove assignment to voffset and
8417 unnecessary vars hshink, expand, hd, full_height, min_height.
8418 (nsfont_draw): Use s->ybase as baseline for glyph drawing (Bug#8913).
8419
8420 * nsterm.h (nsfont_info): Remove voffset field.
8421
d8c2fa78 84222011-07-28 Alp Aker <alp.tekin.aker@gmail.com>
4843aac3
AA
8423
8424 Implement strike-through and overline on NextStep (Bug#8863).
8425
8426 * nsfont.m (nsfont_open): Use underline position provided by font,
8427 instead of hard-coded value of 2.
8428 (nsfont_draw): Call ns_draw_text_decoration instead.
8429
8430 * nsterm.h: Add declaration for ns_draw_text_decoration.
8431
8432 * nsterm.m (ns_draw_text_decoration): New function for drawing
8433 underline, overline, and strike-through.
8434 (ns_dumpglyphs_image, ns_dumpglyphs_stretch): Add call to
8435 ns_draw_text_decoration. Change treatment of cursor drawing to
8d5ed899 8436 accommodate underlining, etc.
4843aac3 8437
4cc60b9b
EZ
84382011-07-28 Eli Zaretskii <eliz@gnu.org>
8439
bc7ece87
EZ
8440 * buffer.c (init_buffer_once): Set bidi-display-reordering to t by
8441 default.
4cc60b9b 8442
476371c4
PE
84432011-07-28 Paul Eggert <eggert@cs.ucla.edu>
8444
66606eea
PE
8445 * alloc.c (memory_full) [!SYNC_INPUT]: Fix signal-related race.
8446 Without this fix, if a signal arrives just after memory fills up,
8447 'malloc' might be invoked reentrantly.
8448
476371c4
PE
8449 * image.c (x_check_image_size) [!HAVE_X_WINDOWS]: Return 1.
8450 In other words, assume that every image size is allowed, on non-X
8451 hosts. This assumption is probably wrong, but it lets Emacs compile.
8452
f3fcc40d
AS
84532011-07-28 Andreas Schwab <schwab@linux-m68k.org>
8454
8455 * regex.c (re_iswctype): Convert return values to boolean.
8456
350c992f
EZ
84572011-07-28 Eli Zaretskii <eliz@fencepost.gnu.org>
8458
8459 * xdisp.c (compute_display_string_pos): Don't use cached display
8460 string position if the buffer had its restriction changed.
8461 (Bug#9184)
8462
5266b4bb
PE
84632011-07-28 Paul Eggert <eggert@cs.ucla.edu>
8464
8465 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork clobbering.
8466
2573a837 84672011-07-28 Paul Eggert <eggert@cs.ucla.edu>
ca4aa935 8468
41f55ccd 8469 Integer signedness and overflow and related fixes. (Bug#9079)
cf950e6b 8470
39e378da
PE
8471 * bidi.c: Integer size and overflow fixes.
8472 (bidi_cache_size, bidi_cache_idx, bidi_cache_last_idx)
8473 (bidi_cache_start, bidi_cache_fetch_state, bidi_cache_search)
8474 (bidi_cache_find_level_change, bidi_cache_ensure_space)
8475 (bidi_cache_iterator_state, bidi_cache_find, bidi_cache_start_stack)
8476 (bidi_find_other_level_edge):
8477 Use ptrdiff_t instead of EMACS_INT where either will do.
8478 This works better on 32-bit hosts configured --with-wide-int.
8479 (bidi_cache_ensure_space): Check for size-calculation overflow.
8480 Use % rather than repeated addition, for better worst-case speed.
8481 Don't set bidi_cache_size until after xrealloc returns, because it
8482 might not return.
8483 (bidi_dump_cached_states): Use ptrdiff_t, not int, to avoid overflow.
f0eb61e9
PE
8484 (bidi_cache_ensure_space): Also check that the bidi cache size
8485 does not exceed that of the largest Lisp string or buffer. See Eli
8486 Zaretskii in <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=9079#29>.
39e378da 8487
5e927815
PE
8488 * alloc.c (__malloc_size_t): Remove.
8489 All uses replaced by size_t. See Andreas Schwab's note
8490 <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=9079#8>.
8491
ca4aa935
PE
8492 * image.c: Improve checking for integer overflow.
8493 (check_image_size): Assume that f is nonnull, since
8494 it is always nonnull in practice. This is one less thing to
8495 worry about when checking for integer overflow later.
8496 (x_check_image_size): New function, which checks for integer
8497 overflow issues inside X.
8498 (x_create_x_image_and_pixmap, xbm_read_bitmap_data): Use it.
8499 This removes the need for a memory_full check.
8500 (xbm_image_p): Rewrite to avoid integer multiplication overflow.
8501 (Create_Pixmap_From_Bitmap_Data, xbm_load): Use x_check_image_size.
8502 (xbm_read_bitmap_data): Change locals back to 'int', since
8503 their values must fit in 'int'.
8504 (xpm_load_image, png_load, tiff_load):
8505 Invoke x_create_x_image_and_pixmap earlier,
8506 to avoid much needless work if the image is too large.
8507 (tiff_load): Treat overly large images as if
8508 x_create_x_image_and_pixmap failed, not as malloc failures.
8509 (gs_load): Use x_check_image_size.
8510
5f8f9cc2
PE
8511 * gtkutil.c: Omit integer casts.
8512 (xg_get_pixbuf_from_pixmap): Remove unnecessary cast.
8513 (xg_set_toolkit_scroll_bar_thumb): Rewrite to avoid need for cast.
8514
5adf60bc
PE
8515 * image.c (png_load): Don't assume height * row_bytes fits in 'int'.
8516
c8907a93
PE
8517 * xfaces.c (Fbitmap_spec_p): Fix integer overflow bug.
8518 Without this fix, (bitmap-spec-p '(34359738368 1 "x"))
8519 would wrongly return t on a 64-bit host.
8520
e3c25c68
PE
8521 * dispnew.c (init_display): Use *_RANGE_OVERFLOW macros.
8522 The plain *_OVERFLOW macros run afoul of GCC bug 49705
8523 <http://gcc.gnu.org/bugzilla/show_bug.cgi?id=49705>
8524 and therefore cause GCC to emit a bogus diagnostic in some cases.
8525
3f791afe
PE
8526 * image.c: Integer signedness and overflow and related fixes.
8527 This is not an exhaustive set of fixes, but it's time to
8528 record what I've got.
8529 (lookup_pixel_color, check_image_size): Remove redundant decls.
8530 (check_image_size): Don't assume that arbitrary EMACS_INT values
8531 fit in 'int', or that arbitrary 'double' values fit in 'int'.
8532 (x_alloc_image_color, x_create_x_image_and_pixmap, png_load)
8533 (tiff_load, imagemagick_load_image):
8534 Check for overflow in size calculations.
8535 (x_create_x_image_and_pixmap): Remove unnecessary test for
8536 xmalloc returning NULL; that can't happen.
8537 (xbm_read_bitmap_data): Don't assume sizes fit into 'int'.
8538 (xpm_color_bucket): Use better integer hashing function.
8539 (xpm_cache_color): Don't possibly over-allocate memory.
8540 (struct png_memory_storage, tiff_memory_source, tiff_seek_in_memory)
8541 (gif_memory_source):
8542 Use ptrdiff_t, not int or size_t, to record sizes.
8543 (png_load): Don't assume values greater than 2**31 fit in 'int'.
8544 (our_stdio_fill_input_buffer): Prefer ptrdiff_t to size_t when
8545 either works, as we prefer signed integers.
8546 (tiff_read_from_memory, tiff_write_from_memory):
8547 Return tsize_t, not size_t, since that's what the TIFF API wants.
8548 (tiff_read_from_memory): Don't fail simply because the read would
8549 go past EOF; instead, return a short read.
8550 (tiff_load): Omit no-longer-needed casts.
8551 (Fimagemagick_types): Don't assume size fits into 'int'.
8552
3cc5a532
PE
8553 Improve hashing quality when configured --with-wide-int.
8554 * fns.c (hash_string): New function, taken from sxhash_string.
8555 Do not discard information about ASCII character case; this
8556 discarding is no longer needed.
8557 (sxhash-string): Use it. Change sig to match it. Caller changed.
8558 * lisp.h: Declare it.
8559 * lread.c (hash_string): Remove, since we now use fns.c's version.
8560 The fns.c version returns a wider integer if --with-wide-int is
8561 specified, so this should help the quality of the hashing a bit.
8562
b312a492
PE
8563 * emacs.c: Integer overflow minor fix.
8564 (heap_bss_diff): Now uprintmax_t, not unsigned long. All used changed.
8565 Define only if GNU_LINUX.
8566 (main, Fdump_emacs): Set and use heap_bss_diff only if GNU_LINUX.
8567
dfd153ae
PE
8568 * dispnew.c: Integer signedness and overflow fixes.
8569 Remove unnecessary forward decls, that were a maintenance hassle.
8570 (history_tick): Now uprintmax_t, so it's more likely to avoid overflow.
8571 All uses changed.
8572 (adjust_glyph_matrix, realloc_glyph_pool, adjust_frame_message_buffer)
8573 (scrolling_window): Use ptrdiff_t, not int, for byte count.
8574 (prepare_desired_row, line_draw_cost):
8575 Use int, not unsigned, where either works.
8576 (save_current_matrix, restore_current_matrix):
8577 Use ptrdiff_t, not size_t, where either works.
8578 (init_display): Check for overflow more accurately, and without
8579 relying on undefined behavior.
8580
a81d11a3
PE
8581 * editfns.c (pWIDE, pWIDElen, signed_wide, unsigned_wide):
8582 Remove, replacing with the new symbols in lisp.h. All uses changed.
8583 * fileio.c (make_temp_name):
8584 * filelock.c (lock_file_1, lock_file):
8585 * xdisp.c (message_dolog):
8586 Don't assume PRIdMAX etc. works; this isn't portable to pre-C99 hosts.
8587 Use pMd etc. instead.
8588 * lisp.h (printmax_t, uprintmax_t, pMd, pMu): New types and macros,
8589 replacing the pWIDE etc. symbols removed from editfns.c.
8590
3300e6fd
PE
8591 * keyboard.h (num_input_events): Now uintmax_t.
8592 This is (very slightly) less likely to mess up due to wraparound.
8593 All uses changed.
8594
fd05c7e9
PE
8595 * buffer.c: Integer signedness fixes.
8596 (alloc_buffer_text, enlarge_buffer_text):
8597 Use ptrdiff_t rather than size_t when either will do, as we prefer
8598 signed integers.
8599
903fe15d
PE
8600 * alloc.c: Integer signedness and overflow fixes.
8601 Do not impose an arbitrary 32-bit limit on malloc sizes when debugging.
8602 (__malloc_size_t): Default to size_t, not to int.
8603 (pure_size, pure_bytes_used_before_overflow, stack_copy_size)
8604 (Fgarbage_collect, mark_object_loop_halt, mark_object):
8605 Prefer ptrdiff_t to size_t when either would do, as we prefer
8606 signed integers.
8607 (XMALLOC_OVERRUN_CHECK_OVERHEAD): New macro.
8608 (xmalloc_overrun_check_header, xmalloc_overrun_check_trailer):
8609 Now const. Initialize with values that are in range even if char
8610 is signed.
8611 (XMALLOC_PUT_SIZE, XMALLOC_GET_SIZE): Remove, replacing with ...
8612 (xmalloc_put_size, xmalloc_get_size): New functions. All uses changed.
8613 These functions do the right thing with sizes > 2**32.
8614 (check_depth): Now ptrdiff_t, not int.
8615 (overrun_check_malloc, overrun_check_realloc, overrun_check_free):
8616 Adjust to new way of storing sizes. Check for size overflow bugs
8617 in rest of code.
8618 (STRING_BYTES_MAX): Adjust to new overheads. The old code was
8619 slightly wrong anyway, as it missed one instance of
8620 XMALLOC_OVERRUN_CHECK_OVERHEAD.
8621 (refill_memory_reserve): Omit needless cast to size_t.
8622 (mark_object_loop_halt): Mark as externally visible.
8623
ac82cc6a
PE
8624 * xselect.c: Integer signedness and overflow fixes.
8625 (Fx_register_dnd_atom, x_handle_dnd_message):
8626 Use ptrdiff_t, not size_t, since we prefer signed.
8627 (Fx_register_dnd_atom): Check for ptrdiff_t (and size_t) overflow.
8628 * xterm.h (struct x_display_info): Use ptrdiff_t, not size_t, for
8629 x_dnd_atoms_size and x_dnd_atoms_length.
8630
c2d1e36d
PE
8631 * doprnt.c: Prefer signed to unsigned when either works.
8632 * eval.c (verror):
8633 * doprnt.c (doprnt):
8634 * lisp.h (doprnt):
8635 * xdisp.c (vmessage):
8636 Use ptrdiff_t, not size_t, when using or implementing doprnt,
8637 since the sizes cannot exceed ptrdiff_t bounds anyway, and we
8638 prefer signed arithmetic to avoid comparison confusion.
8639 * doprnt.c (doprnt): Avoid a "+ 1" that can't overflow,
8640 but is a bit tricky.
8641
0e926e56
PE
8642 Assume freestanding C89 headers, string.h, stdlib.h.
8643 * data.c, doprnt.c, floatfns.c, print.c:
8644 Include float.h unconditionally.
8645 * gmalloc.c: Assume C89-at-least behavior for preprocessor,
8646 limits.h, stddef.h, string.h. Use memset instead of 'flood'.
8647 * regex.c: Likewise for stddef.h, string.h.
8648 (ISASCII): Remove; can assume it returns 1 now. All uses removed.
8649 * s/aix4-2.h (HAVE_STRING_H): Remove obsolete undef.
8650 * s/ms-w32.h (HAVE_LIMITS_H, HAVE_STRING_H, HAVE_STDLIB_H)
8651 (STDC_HEADERS): Remove obsolete defines.
8652 * sysdep.c: Include limits.h unconditionally.
8653
9cfdb3ec
PE
8654 Assume support for memcmp, memcpy, memmove, memset.
8655 * lisp.h, sysdep.c (memcmp, memcpy, memmove, memset):
8656 * regex.c (memcmp, memcpy):
8657 Remove; we assume C89 now.
8658
8659 * gmalloc.c (memcpy, memset, memmove): Remove; we assume C89 now.
8660 (__malloc_safe_bcopy): Remove; no longer needed.
8661
cf950e6b 8662 * lisp.h (struct vectorlike_header, struct Lisp_Subr): Signed sizes.
6089c567
PE
8663 Use EMACS_INT, not EMACS_UINT, for sizes. The code works equally
8664 well either way, and we prefer signed to unsigned.
8665
dbf38e02
LMI
86662011-07-27 Lars Magne Ingebrigtsen <larsi@gnus.org>
8667
8668 * gnutls.c (emacs_gnutls_read): Don't message anything if the peer
8669 closes the connection while we're reading (bug#9182).
8670
d6f0886c 86712011-07-25 Jan Djärv <jan.h.d@swipnet.se>
24e0f6b1 8672
d6f0886c
JD
8673 * nsmenu.m (ns_popup_dialog): Add an "ok" button if no buttons
8674 are specified (Bug#9168).
24e0f6b1 8675
2eb1f9e6
PE
86762011-07-25 Paul Eggert <eggert@cs.ucla.edu>
8677
8678 * bidi.c (bidi_dump_cached_states): Fix printf format mismatch.
8679 Found by GCC static checking and --with-wide-int on a 32-bit host.
8680
22381272 86812011-07-25 Eli Zaretskii <eliz@gnu.org>
7daee910
EZ
8682
8683 * xdisp.c (compute_display_string_pos): Fix logic of caching
8684 previous display string position. Initialize cached_prev_pos to
8685 -1. Fixes slow-down at the beginning of a buffer.
8686
f25e39b4
EZ
86872011-07-24 Eli Zaretskii <eliz@gnu.org>
8688
8689 * xfaces.c (check_lface_attrs) [HAVE_WINDOW_SYSTEM]: Allow `nil'
8690 for attrs[LFACE_FONTSET_INDEX].
8691
04c4b52e
PE
86922011-07-23 Paul Eggert <eggert@cs.ucla.edu>
8693
8694 * xml.c (parse_region): Remove unused local
8695 that was recently introduced.
8696
c1734fbd
EZ
86972011-07-23 Eli Zaretskii <eliz@gnu.org>
8698
be18c5a5
EZ
8699 * xfns.c (unwind_create_frame) [GLYPH_DEBUG]: Adapt to changes in
8700 2008-02-22T17:42:09Z!monnier@iro.umontreal.ca.
8701
c1734fbd
EZ
8702 * xdisp.c (move_it_in_display_line_to): Record the best matching
8703 position for TO_CHARPOS while scanning the line, and restore it on
640c8776
SM
8704 exit if none of the characters scanned was an exact match.
8705 Fixes vertical-motion and pos-visible-in-window-p under bidi redisplay
a9269c18
EZ
8706 when exact match is impossible due to invisible text, and the
8707 lines are truncated.
8708
a258d627
JD
87092011-07-23 Jan Djärv <jan.h.d@swipnet.se>
8710
8711 * nsterm.m (initFrameFromEmacs): Set NSTitledWindowMask in styleMask
8712 for OSX >= 10.7.
8713
b6d5a689
EZ
87142011-07-22 Eli Zaretskii <eliz@gnu.org>
8715
0f74f785
EZ
8716 Fix a significant slow-down of cursor motion with C-n, C-p,
8717 C-f/C-b, and C-v/M-v that couldn't keep up with keyboard
8718 auto-repeat under bidi redisplay in fontified buffers.
b6d5a689 8719 * xdisp.c (compute_stop_pos_backwards): New function.
b6d5a689
EZ
8720 (next_element_from_buffer): Call compute_stop_pos_backwards to
8721 find a suitable prev_stop when we find ourselves before
0f74f785
EZ
8722 base_level_stop.
8723 (reseat): Don't look for prev_stop, as that could mean a very long
8724 run.
8725 <cached_disp_pos, cached_disp_buffer, cached_disp_modiff>
8726 <cached_disp_overlay_modiff>: Cache for last found display string
8727 position.
551918c1 8728 (compute_display_string_pos): Return the cached position if asked
0f74f785
EZ
8729 about the same buffer in the same area of character positions, and
8730 the buffer wasn't changed since the time the display string
8731 position was cached.
551918c1 8732
b2d0c91a
EZ
87332011-07-22 Eli Zaretskii <eliz@gnu.org>
8734
8735 * xdisp.c (rows_from_pos_range): Don't ignore glyphs whose object
8736 is an integer, which is important for empty lines. (Bug#9149)
8737
043604ee
CY
87382011-07-22 Chong Yidong <cyd@stupidchicken.com>
8739
8740 * frame.c (Fmodify_frame_parameters): In tty case, update the
8741 default face if necessary (Bug#4238).
8742
da4adb04
CY
87432011-07-21 Chong Yidong <cyd@stupidchicken.com>
8744
8745 * editfns.c (Fstring_to_char): No need to explain what a character
8746 is in the docstring (Bug#6576).
8747
9abd0532
LMI
87482011-07-20 Lars Magne Ingebrigtsen <larsi@gnus.org>
8749
8750 * xml.c (parse_region): Make sure we always return a tree.
8751
36881d16
HK
87522011-07-20 HAMANO Kiyoto <khiker.mail@gmail.com>
8753
8754 * xml.c (parse_region): If a document contains only comments,
8755 return that, too.
8756
1e98674d
LMI
87572011-07-20 Lars Magne Ingebrigtsen <larsi@gnus.org>
8758
8759 * xml.c (make_dom): Return comments, too.
8760
590bd467
PE
87612011-07-19 Paul Eggert <eggert@cs.ucla.edu>
8762
8763 Port to OpenBSD.
8764 See http://lists.gnu.org/archive/html/emacs-devel/2011-07/msg00688.html
8765 and the surrounding thread.
8766 * minibuf.c (read_minibuf_noninteractive): Rewrite to use getchar
8767 rather than fgets, and retry after EINTR. Otherwise, 'emacs
8768 --batch -f byte-compile-file' fails on OpenBSD if an inactivity
8769 timer goes off.
8770 * s/openbsd.h (BROKEN_SIGIO): Define.
8771 * unexelf.c (unexec) [__OpenBSD__]:
8772 Don't update the .mdebug section of the Alpha COFF symbol table.
8773
f41628b2
LMI
87742011-07-19 Lars Magne Ingebrigtsen <larsi@gnus.org>
8775
8776 * lread.c (syms_of_lread): Clarify when `lexical-binding' is used
8777 (bug#8460).
8778
b59b67c5
PE
87792011-07-18 Paul Eggert <eggert@cs.ucla.edu>
8780
15e3a074
PE
8781 * fileio.c (Fcopy_file) [!MSDOS]: Tighten created file's mask.
8782 This fixes some race conditions on the permissions of any newly
8783 created file.
8784
41bed37d
PE
8785 * alloc.c (valid_pointer_p): Use pipe, not open.
8786 This fixes some permissions issues when debugging.
8787
b59b67c5
PE
8788 * fileio.c (Fcopy_file): Adjust mode if fchown fails. (Bug#9002)
8789 If fchown fails to set both uid and gid, try to set just gid,
8790 as that is sometimes allowed. Adjust the file's mode to eliminate
8791 setuid or setgid bits that are inappropriate if fchown fails.
8792
925a6be7
SM
87932011-07-18 Stefan Monnier <monnier@iro.umontreal.ca>
8794
8795 * xdisp.c (next_element_from_string, next_element_from_buffer): Use EQ
8796 to compare Lisp_Objects.
8797 * gnutls.c (syms_of_gnutls): Rename Vgnutls_log_level to
8798 global_gnutls_log_level, don't mistake it for a Lisp_Object.
8799 (init_gnutls_functions, emacs_gnutls_handle_error): Fix up uses.
8800
52968808
AS
88012011-07-17 Andreas Schwab <schwab@linux-m68k.org>
8802
0a6a104b
AS
8803 * lread.c (read_integer): Unread even EOF character.
8804 (read1): Likewise. Properly record start position of symbol.
8805
52968808
AS
8806 * lread.c (read1): Read `#:' as empty uninterned symbol if no
8807 symbol character follows.
8808
9e381cdd
PE
88092011-07-17 Paul Eggert <eggert@cs.ucla.edu>
8810
8811 * fileio.c (Fcopy_file): Pacify gcc re fchown. (Bug#9002)
8812 This works around a problem with the previous change to Fcopy_file.
8813 Recent glibc declares fchown with __attribute__((warn_unused_result)),
8814 and without this change, GCC might complain about discarding
8815 fchown's return value.
8816
b5641435
JB
88172011-07-16 Juanma Barranquero <lekktu@gmail.com>
8818
8819 * makefile.w32-in (GLOBAL_SOURCES): Add gnutls.c (followup to bug#9059).
8820
a8031457
PE
88212011-07-16 Paul Eggert <eggert@cs.ucla.edu>
8822
8823 * fileio.c (Fcopy_file): Don't diagnose fchown failures. (Bug#9002)
8824
dd889327
LMI
88252011-07-16 Lars Magne Ingebrigtsen <larsi@gnus.org>
8826
750c33f7
LMI
8827 * gnutls.c (syms_of_gnutls): Define `gnutls-log-level' here, since
8828 it's used from the C level.
8829
dd889327
LMI
8830 * process.c: Use the same condition for POLL_FOR_INPUT in both
8831 keyboard.c and process.c (bug#1858).
8832
87e86684
LM
88332011-07-09 Lawrence Mitchell <wence@gmx.li>
8834
8835 * gnutls.c (Qgnutls_bootprop_min_prime_bits): New variable.
8836 (Fgnutls_boot): Use it.
8837
64348f40
AS
88382011-07-15 Andreas Schwab <schwab@linux-m68k.org>
8839
8840 * doc.c (Fsubstitute_command_keys): Revert last change.
8841
1d698799
LMI
88422011-07-15 Lars Magne Ingebrigtsen <larsi@gnus.org>
8843
f863868c
LMI
8844 * doc.c (Fsubstitute_command_keys): Clarify that \= really only
8845 quotes the next character, and doesn't affect other longer
8846 sequences (bug#8935).
8847
1d698799
LMI
8848 * lread.c (syms_of_lread): Clarify that is isn't only
8849 `eval-buffer' and `eval-defun' that's affected by
8850 `lexical-binding' (bug#8460).
8851
aa4b6df6
EZ
88522011-07-15 Eli Zaretskii <eliz@gnu.org>
8853
8854 * xdisp.c (move_it_in_display_line_to): Fix vertical motion with
6b02f655 8855 bidi redisplay when a line includes both an image and is truncated.
aa4b6df6 8856
5d856da6
PE
88572011-07-14 Paul Eggert <eggert@cs.ucla.edu>
8858
ad6042bb
PE
8859 Fix minor problems found by static checking.
8860 * bidi.c (bidi_cache_size): Now EMACS_INT, not size_t.
8861 (elsz): Now a signed constant, not a size_t var. We prefer signed
8862 types to unsigned, to avoid integer comparison confusion. Without
8863 this change, GCC 4.6.1 with -Wunsafe-loop-optimizations complains
8864 "cannot optimize loop, the loop counter may overflow", a symptom
8865 of the confusion.
f00bbb22 8866 * indent.c (Fvertical_motion): Mark locals as initialized.
5d856da6
PE
8867 * xdisp.c (reseat_to_string): Fix pointer signedness issue.
8868
6468f31c
LMI
88692011-07-14 Lars Magne Ingebrigtsen <larsi@gnus.org>
8870
49080b10
LMI
8871 * search.c (Fre_search_backward): Mention `case-fold-search' in
8872 all the re_search_* functions (bug#8138).
8873
6468f31c
LMI
8874 * keyboard.c (Fopen_dribble_file): Document when the file is
8875 closed (bug#8056).
8876
c965adc5
EZ
88772011-07-14 Eli Zaretskii <eliz@gnu.org>
8878
df9733bf
EZ
8879 * bidi.c (bidi_dump_cached_states): Fix format of displaying
8880 bidi_cache_idx.
8881
0bb23927
EZ
8882 Support bidi reordering of display and overlay strings.
8883 * xdisp.c (compute_display_string_pos)
8884 (compute_display_string_end): Accept additional argument STRING.
8885 (init_iterator, reseat_1): Initialize bidi_it->string.s to NULL.
8886 (reseat_to_string): Initialize bidi_it->string.s and
8887 bidi_it->string.schars.
8888 (Fcurrent_bidi_paragraph_direction): Initialize itb.string.s to
640c8776
SM
8889 NULL (avoids a crash in bidi_paragraph_init).
8890 Initialize itb.string.lstring.
0bb23927
EZ
8891 (init_iterator): Call bidi_init_it only of a valid
8892 buffer position was specified. Initialize paragraph_embedding to
8893 L2R.
8894 (reseat_to_string): Initialize the bidi iterator.
8895 (display_string): If we need to ignore text properties of
8896 LISP_STRING, set IT->stop_charpos to IT->end_charpos. (The
8897 original value of -1 will not work with bidi.)
8898 (compute_display_string_pos): First arg is now struct
8899 `text_pos *'; all callers changed. Support display properties on
8900 Lisp strings.
8901 (compute_display_string_end): Support display properties on Lisp
8902 strings.
8903 (init_iterator, reseat_1, reseat_to_string): Initialize the
8904 string.bufpos member to 0 (zero, for compatibility with IT_CHARPOS
8905 when iterating on a string not from display properties).
640c8776
SM
8906 (compute_display_string_pos, compute_display_string_end):
8907 Fix calculation of the object to scan. Fixes an error when using
0bb23927
EZ
8908 arrow keys.
8909 (next_element_from_buffer): Don't abort when IT_CHARPOS is before
640c8776
SM
8910 base_level_stop; instead, set base_level_stop to BEGV.
8911 Fixes crashes in vertical-motion.
0bb23927
EZ
8912 (next_element_from_buffer): Improve commentary for when
8913 the iterator is before prev_stop.
8914 (init_iterator): Initialize bidi_p from the default value of
8915 bidi-display-reordering, not from buffer-local value. Use the
8916 buffer-local value only if initializing for buffer iteration.
8917 (handle_invisible_prop): Support invisible properties on strings
8918 that are being bidi-reordered.
8919 (set_iterator_to_next): Support bidi reordering of C strings and
8920 Lisp strings.
8921 (next_element_from_string): Support bidi reordering of Lisp
8922 strings.
8923 (handle_stop_backwards): Support Lisp strings as well.
640c8776
SM
8924 (display_string): Support display of R2L glyph rows.
8925 Use IT_STRING_CHARPOS when displaying from a Lisp string.
0bb23927
EZ
8926 (init_iterator): Don't initialize it->bidi_p for strings
8927 here.
8928 (reseat_to_string): Initialize it->bidi_p for strings here.
8929 (next_element_from_string, next_element_from_c_string)
8930 (next_element_from_buffer): Add xassert's for correspondence
8931 between IT's object being iterated and it->bidi_it.string
8932 structure.
8933 (face_before_or_after_it_pos): Support bidi iteration.
8934 (next_element_from_c_string): Handle the case of the first string
8935 character that is not the first one in the visual order.
8936 (get_visually_first_element): New function, refactored from common
8937 parts of next_element_from_buffer, next_element_from_string, and
8938 next_element_from_c_string.
8939 (tool_bar_lines_needed, redisplay_tool_bar)
8940 (display_menu_bar): Force left-to-right direction. Add a FIXME
8941 comment for making that be controlled by a user option.
8942 (push_it, pop_it): Save and restore the state of the
8943 bidi iterator. Save and restore the bidi_p flag.
8944 (pop_it): Iterate out of display property for string iteration as
8945 well.
8946 (iterate_out_of_display_property): Support iteration over strings.
8947 (handle_single_display_spec): Set up it->bidi_it for iteration
8948 over a display string, and call bidi_init_it.
8949 (handle_single_display_spec, next_overlay_string)
8950 (get_overlay_strings_1, push_display_prop): Set up the bidi
8951 iterator for displaying display or overlay strings.
8952 (forward_to_next_line_start): Don't use the shortcut if
8953 bidi-iterating.
8954 (back_to_previous_visible_line_start): If handle_display_prop
8955 pushed the iterator stack, restore the internal state of the bidi
8956 iterator by calling bidi_pop_it same number of times.
8957 (reseat_at_next_visible_line_start): If ON_NEWLINE_P is non-zero,
8958 and we are bidi-iterating, don't decrement the iterator position;
8959 instead, set the first_elt flag in the bidi iterator, to produce
8960 the same effect.
8961 (reseat_1): Remove redundant setting of string_from_display_prop_p.
8962 (push_display_prop): xassert that we are iterating a buffer.
8963 (push_it, pop_it): Save and restore paragraph_embedding member.
8964 (handle_single_display_spec, next_overlay_string)
8965 (get_overlay_strings_1, reseat_1, reseat_to_string)
8966 (push_display_prop): Set up the `unibyte' member of bidi_it.string
8967 correctly. Don't assume unibyte strings are not bidi-reordered.
8968 (compute_display_string_pos)
8969 (compute_display_string_end): Fix handling the case of C string.
8970 (push_it, pop_it): Save and restore from_disp_prop_p.
8971 (handle_single_display_spec, push_display_prop): Set the
8972 from_disp_prop_p flag.
8973 (get_overlay_strings_1): Reset the from_disp_prop_p flag.
8974 (pop_it): Call iterate_out_of_display_property only if we are
8975 popping after iteration over a string that came from a display
8976 property. Fix a typo in popping stretch info. Add an assertion
8977 for verifying that the iterator position is in sync with the bidi
8978 iterator.
8979 (handle_single_display_spec, get_overlay_strings_1)
8980 (push_display_prop): Fix initialization of paragraph direction for
8981 string when that of the parent object is not yet determined.
8982 (reseat_1): Call bidi_init_it to resync the bidi
8983 iterator with IT's position. (Bug#7616)
8984 (find_row_edges): If ROW->start.pos gives position
8985 smaller than min_pos, use it as ROW->minpos. (Bug#7616)
8986 (handle_stop, back_to_previous_visible_line_start, reseat_1):
8987 Reset the from_disp_prop_p flag.
8988 (SAVE_IT, RESTORE_IT): New macros.
8989 (pos_visible_p, face_before_or_after_it_pos)
8990 (back_to_previous_visible_line_start)
8991 (move_it_in_display_line_to, move_it_in_display_line)
8992 (move_it_to, move_it_vertically_backward, move_it_by_lines)
8993 (try_scrolling, redisplay_window, display_line): Use them when
8994 saving a temporary copy of the iterator and restoring it back.
8995 (back_to_previous_visible_line_start, reseat_1)
8996 (init_iterator): Empty the bidi cache "stack".
8997 (move_it_in_display_line_to): If iterator ended up at
8998 EOL, but we never saw any buffer positions smaller than
8999 to_charpos, return MOVE_POS_MATCH_OR_ZV. Fixes vertical cursor
9000 motion in bidi-reordered lines.
9001 (move_it_in_display_line_to): Record prev_method and prev_pos
9002 immediately before the call to set_iterator_to_next. Fixes cursor
9003 motion in bidi-reordered lines with stretch glyphs and strings
9004 displayed in margins. (Bug#8133) (Bug#8867)
9005 Return MOVE_POS_MATCH_OR_ZV only if iterator position is past
9006 TO_CHARPOS.
640c8776
SM
9007 (pos_visible_p): Support positions in bidi-reordered lines.
9008 Save and restore bidi cache.
0bb23927
EZ
9009
9010 * bidi.c (bidi_level_of_next_char): clen should be EMACS_NT, not int.
9011 (bidi_paragraph_info): Delete unused struct.
9012 (bidi_cache_idx, bidi_cache_last_idx): Declare EMACS_INT.
9013 (bidi_cache_start): New variable.
9014 (bidi_cache_reset): Reset bidi_cache_idx to bidi_cache_start, not
9015 to zero.
9016 (bidi_cache_fetch_state, bidi_cache_search)
9017 (bidi_cache_find_level_change, bidi_cache_iterator_state)
9018 (bidi_cache_find, bidi_peek_at_next_level)
9019 (bidi_level_of_next_char, bidi_find_other_level_edge)
9020 (bidi_move_to_visually_next): Compare cache index with
9021 bidi_cache_start rather than with zero.
9022 (bidi_fetch_char): Accept new argument STRING; all callers
9023 changed. Support iteration over a string. Support strings with
9024 display properties. Support unibyte strings. Fix the type of
9025 `len' according to what STRING_CHAR_AND_LENGTH expects.
9026 (bidi_paragraph_init, bidi_resolve_explicit_1)
9027 (bidi_resolve_explicit, bidi_resolve_weak)
640c8776
SM
9028 (bidi_level_of_next_char, bidi_move_to_visually_next):
9029 Support iteration over a string.
0bb23927
EZ
9030 (bidi_set_sor_type, bidi_resolve_explicit_1)
9031 (bidi_resolve_explicit, bidi_type_of_next_char): ignore_bn_limit
9032 can now be zero (for strings); special values 0 and -1 were
9033 changed to -1 and -2, respectively.
9034 (bidi_char_at_pos): New function.
9035 (bidi_paragraph_init, bidi_resolve_explicit, bidi_resolve_weak):
9036 Call it instead of FETCH_MULTIBYTE_CHAR.
9037 (bidi_move_to_visually_next): Abort if charpos or bytepos were not
9038 initialized to valid values.
9039 (bidi_init_it): Don't initialize charpos and bytepos with invalid
9040 values.
9041 (bidi_level_of_next_char): Allow the sentinel "position" to pass
9042 the test for valid cached positions. Fix the logic for looking up
9043 the sentinel state in the cache. GCPRO the Lisp string we are
9044 iterating.
9045 (bidi_push_it, bidi_pop_it): New functions.
9046 (bidi_initialize): Initialize the bidi cache start stack pointer.
9047 (bidi_cache_ensure_space): New function, refactored from part of
9048 bidi_cache_iterator_state. Don't assume the required size is just
9049 one BIDI_CACHE_CHUNK away.
9050 (bidi_cache_start_stack, bidi_push_it): Use IT_STACK_SIZE.
9051 (bidi_count_bytes, bidi_char_at_pos): New functions.
9052 (bidi_cache_search): Don't assume bidi_cache_last_idx is
9053 always valid if bidi_cache_idx is valid.
9054 (bidi_cache_find_level_change): xassert that bidi_cache_last_idx
9055 is valid if it's going to be used.
9056 (bidi_shelve_cache, bidi_unshelve_cache): New functions.
9057 (bidi_cache_fetch_state, bidi_cache_search)
c965adc5
EZ
9058 (bidi_cache_find_level_change, bidi_cache_ensure_space)
9059 (bidi_cache_iterator_state, bidi_cache_find)
640c8776
SM
9060 (bidi_find_other_level_edge, bidi_cache_start_stack):
9061 All variables related to cache indices are now EMACS_INT.
c965adc5 9062
0bb23927
EZ
9063 * dispextern.h (struct bidi_string_data): New structure.
9064 (struct bidi_it): New member `string'. Make flag members be 1-bit
9065 fields, and put them last in the struct.
640c8776
SM
9066 (compute_display_string_pos, compute_display_string_end):
9067 Update prototypes.
0bb23927
EZ
9068 (bidi_push_it, bidi_pop_it): Add prototypes.
9069 (struct iterator_stack_entry): New members bidi_p,
9070 paragraph_embedding, and from_disp_prop_p.
9071 (struct it): Member bidi_p is now a bit field 1 bit wide.
640c8776
SM
9072 (bidi_shelve_cache, bidi_unshelve_cache):
9073 Declare prototypes.
0bb23927
EZ
9074
9075 * .gdbinit (xvectype, xvector, xcompiled, xchartable, xboolvector)
9076 (xpr, xfont, xbacktrace): Use "header.size" when accessing vectors
9077 and vector-like objects.
9078
9079 * dispnew.c (buffer_posn_from_coords): Save and restore the bidi
9080 cache around display iteration.
9081
9082 * window.c (Fwindow_end, window_scroll_pixel_based)
9083 (displayed_window_lines, Frecenter): Save and restore the bidi
9084 cache around display iteration.
9085
3bbd2265
LMI
90862011-07-14 Lars Magne Ingebrigtsen <larsi@gnus.org>
9087
9088 * editfns.c (Fdelete_region): Clarify the use of the named
9089 parameters (bug#6788).
9090
adc47434
MR
90912011-07-14 Martin Rudalics <rudalics@gmx.at>
9092
9093 * indent.c (Fvertical_motion): Set and restore w->pointm when
9094 saving and restoring the window's buffer (Bug#9006).
9095
837c31f8
LMI
90962011-07-13 Lars Magne Ingebrigtsen <larsi@gnus.org>
9097
9098 * editfns.c (Fstring_to_char): Clarify just what is returned
9099 (bug#6576). Text by Eli Zaretskii.
9100
ac389d0c
JB
91012011-07-13 Juanma Barranquero <lekktu@gmail.com>
9102
9103 * gnutls.c (init_gnutls_functions): Honor gnutls_log_level (bug#9059).
9104
0be0ce47
EZ
91052011-07-13 Eli Zaretskii <eliz@gnu.org>
9106
9107 * buffer.c (mmap_find): Fix a typo.
9108
cd18e7e3
JB
91092011-07-13 Johan Bockgård <bojohan@gnu.org>
9110
9111 Fix execution of x selection hooks.
9112 * xselect.c (Qx_lost_selection_functions)
9113 (Qx_sent_selection_functions): New vars.
9114 (syms_of_xselect): DEFSYM them.
9115 (x_handle_selection_request): Pass Qx_sent_selection_functions
9116 rather than Vx_sent_selection_functions to Frun_hook_with_args.
9117 (x_handle_selection_clear,x_clear_frame_selections):
9118 Pass Qx_lost_selection_functions rather than
9119 Vx_lost_selection_functions to Frun_hook_with_args.
9120
47ea7f44
PE
91212011-07-13 Paul Eggert <eggert@cs.ucla.edu>
9122
ac389d0c 9123 * buffer.c (Fget_buffer_create): Initialize inhibit_shrinking.
2941c447
PE
9124 The old code sometimes used this field without initializing it.
9125
47ea7f44
PE
9126 * alloc.c (gc_sweep): Don't read past end of array.
9127 In theory, the old code could also have corrupted Emacs internals,
9128 though it'd be very unlikely.
9129
bc985c87
AS
91302011-07-12 Andreas Schwab <schwab@linux-m68k.org>
9131
9132 * character.c (Fcharacterp): Don't advertise optional ignored
ac389d0c 9133 argument. (Bug#4026)
bc985c87 9134
0cf34688
LMI
91352011-07-12 Lars Magne Ingebrigtsen <larsi@gnus.org>
9136
b3dadd76
LMI
9137 * keymap.c (syms_of_keymap): Clarify that "modifier" is "modifier
9138 key" (bug#4257).
9139
0cf34688
LMI
9140 * window.c (Fset_window_start): Doc fix (bug#4199).
9141 (Fset_window_hscroll): Ditto.
9142
270768cd
PE
91432011-07-12 Paul Eggert <eggert@cs.ucla.edu>
9144
077e3dda 9145 Fix minor new problems caught by GCC 4.6.1.
270768cd 9146 * term.c (init_tty): Remove unused local.
490011a6 9147 * xsettings.c (store_monospaced_changed): Define this function only
077e3dda 9148 if (defined HAVE_GSETTINGS || defined HAVE_GCONF), as it's
490011a6 9149 not used otherwise.
270768cd 9150
b1f58454
CY
91512011-07-12 Chong Yidong <cyd@stupidchicken.com>
9152
9153 * xdisp.c (Vresize_mini_windows): Minor doc fix (Bug#3300).
9154
22b9578d
LMI
91552011-07-11 Lars Magne Ingebrigtsen <larsi@gnus.org>
9156
6e70ab07
LMI
9157 * xdisp.c (syms_of_xdisp): Make it explicit that the mini-windows
9158 are the mini-buffer and the echo area (bug#3320).
9159
22b9578d
LMI
9160 * term.c (init_tty): Remove support for supdup, c10 and perq
9161 terminals, which are no longer supported (bug#1482).
9162
8974cc9f
JB
91632011-07-10 Johan Bockgård <bojohan@gnu.org>
9164
9165 * xdisp.c (Ftool_bar_lines_needed): Fix WINDOWP check.
9166
a560d974
JD
91672011-07-10 Jan Djärv <jan.h.d@swipnet.se>
9168
9169 * xmenu.c (menu_highlight_callback): Only pass frame to show_help_event
9170 for non-popups (Bug#3642).
9171
1dae0f0a
AS
91722011-07-10 Andreas Schwab <schwab@linux-m68k.org>
9173
268c2c36 9174 * alloc.c (reset_malloc_hooks): Protoize.
1dae0f0a 9175 * buffer.c (mmap_init, mmap_find, mmap_free_1, mmap_enlarge)
268c2c36
AS
9176 (mmap_set_vars, mmap_alloc, mmap_free, mmap_realloc): Likewise.
9177 * cm.c (losecursor): Likewise.
1dae0f0a
AS
9178 * data.c (fmod): Likewise.
9179 * dispnew.c (swap_glyphs_in_rows): Likewise.
9180 * emacs.c (memory_warning_signal): Likewise.
9181 * floatfns.c (float_error): Likewise.
9182 * font.c (check_gstring, check_otf_features, otf_tag_symbol)
9183 (otf_open, font_otf_capability, generate_otf_features)
9184 (font_otf_DeviceTable, font_otf_ValueRecord, font_otf_Anchor):
9185 Likewise.
9186 * image.c (pbm_read_file): Likewise.
9187 * indent.c (string_display_width): Likewise.
9188 * intervals.c (check_for_interval, search_for_interval)
9189 (inc_interval_count, count_intervals, root_interval)
9190 (adjust_intervals_for_insertion, make_new_interval): Likewise.
9191 * lread.c (defalias): Likewise.
268c2c36 9192 * ralloc.c (r_alloc_check): Likewise.
1dae0f0a
AS
9193 * regex.c (set_image_of_range_1, set_image_of_range)
9194 (regex_grow_registers): Likewise.
9195 * sysdep.c (strerror): Likewise.
9196 * termcap.c (valid_filename_p, tprint, main): Likewise.
9197 * tparam.c (main): Likewise.
9198 * unexhp9k800.c (run_time_remap, save_data_space)
9199 (update_file_ptrs, read_header, write_header, calculate_checksum)
9200 (copy_file, copy_rest, display_header): Likewise.
9201 * widget.c (mark_shell_size_user_specified, create_frame_gcs):
9202 Likewise.
9203 * xdisp.c (check_it): Likewise.
9204 * xfaces.c (register_color, unregister_color, unregister_colors):
9205 Likewise.
9206 * xfns.c (print_fontset_result): Likewise.
9207 * xrdb.c (member, fatal, main): Likewise.
9208
99033785
PE
92092011-07-10 Paul Eggert <eggert@cs.ucla.edu>
9210
9211 Fix minor problems found by static checking (Bug#9031).
9212 * chartab.c (char_table_set_range, map_sub_char_table):
9213 Remove unused locals.
9214 (uniprop_table): Now static.
9215 * composite.c (_work_char): Remove unused static var.
9216
9cb2ac56
JB
92172011-07-09 Juanma Barranquero <lekktu@gmail.com>
9218
9219 * chartab.c (uniprop_table_uncompress): Remove unused local variable.
9220
f25661f0
JD
92212011-07-09 Jan Djärv <jan.h.d@swipnet.se>
9222
9223 * gtkutil.c (qttip_cb): Remove code without function.
9224
8278c4fe
EZ
92252011-07-09 Eli Zaretskii <eliz@gnu.org>
9226
9227 * w32.c (pthread_sigmask): New stub.
9228
1692ae2d 92292011-07-08 Paul Eggert <eggert@cs.ucla.edu>
123403e4 9230
8a6ebd58 9231 Use pthread_sigmask, not sigprocmask (Bug#9010).
123403e4
PE
9232 sigprocmask is portable only for single-threaded applications, and
9233 Emacs can be multi-threaded when it uses GTK.
1301ac26
PE
9234 * Makefile.in (LIB_PTHREAD_SIGMASK): New macro.
9235 (LIBES): Use it.
9236 * callproc.c (Fcall_process):
9237 * process.c (create_process):
9238 * sysdep.c (sys_sigblock, sys_sigunblock, sys_sigsetmask):
9239 Use pthread_sigmask, not sigprocmask.
123403e4 9240
1b854618
JD
92412011-07-08 Jan Djärv <jan.h.d@swipnet.se>
9242
9243 * gtkutil.c (qttip_cb): Set line wrap to FALSE for tooltip widget.
9244 (xg_prepare_tooltip): Revert text in x->ttip_lbl, margins was
9245 wrong (Bug#8591).
9246
3fe4b549
JD
92472011-07-08 Jan Djärv <jan.h.d@swipnet.se>
9248
0ce7e563
JD
9249 * gtkutil.c (xg_prepare_tooltip): Fix indentation and comment.
9250 Put text in x->ttip_lbl instead of gtk_tooltip_set_text (Bug#8591).
9251 (xg_hide_tooltip): Fix comment.
9252
3fe4b549
JD
9253 * nsterm.m (initFrameFromEmacs): Don't use ns_return_types
9254 in registerServicesMenuSendTypes.
9255 (validRequestorForSendType): Don't check ns_return_types.
9256
9257 * nsfns.m (Fx_open_connection): Put NSStringPboardType into
9258 ns_return_type.
9259
5df75e47
JR
92602011-07-08 Jason Rumney <jasonr@gnu.org>
9261
22610910
JR
9262 * w32term.c (x_make_frame_visible): Use SH_SHOWNORMAL rather than
9263 SH_SHOW for hidden windows (Bug#5482).
9264
5df75e47
JR
9265 * w32fns.c (w32_wnd_proc) [WM_TIMER, WM_SET_CURSOR]: Avoid using
9266 frame struct members of non-existent frames (Bug#6284).
9267
699c10bd
JD
92682011-07-08 Jan Djärv <jan.h.d@swipnet.se>
9269
4393663b
JD
9270 * nsterm.m (keyDown): Call to wantsToDelayTextChangeNotifications and
9271 variable firstTime not needed on OSX >= 10.6.
9272 (setPosition): setFloatValue:knobProportion: is deprecated on OSX
9273 >= 10.5. Use setKnobProportion, setDoubleValue.
9274
9275 * nsterm.h (MAC_OS_X_VERSION_10_3, MAC_OS_X_VERSION_10_4)
9276 (MAC_OS_X_VERSION_10_5): Define if not defined.
9277 (EmacsView, EmacsTooltip): Implements NSWindowDelegate on OSX >= 10.6.
9278 (EmacsMenu): Implements NSMenuDelegate on OSX >= 10.6.
9279 (EmacsToolbar): Implements NSToolbarDelegate on OSX >= 10.6.
9280
9281 * nsselect.m (ns_string_from_pasteboard): Don't use deprecated methods
090bd7cb 9282 cString and lossyCString on OSX >= 10.4.
4393663b 9283
58179cce 9284 * nsmenu.m (fillWithWidgetValue): Don't use deprecated method
4393663b
JD
9285 sizeToFit on OSX >= 10.2.
9286
9287 * nsimage.m (allocInitFromFile): Don't use deprecated method
9288 bestRepresentationForDevice on OSX >= 10.6.
9289
9290 * nsfns.m (check_ns_display_info): Cast to long and use %ld in error
9291 to avoid warning.
9292
9293 * emacs.c: Declare unexec_init_emacs_zone.
9294
a63e0781
JD
9295 * nsgui.h: Fix compiler warning about gnulib redefining verify.
9296
699c10bd
JD
9297 * nsselect.m (ns_get_local_selection): Change to extern (Bug#8842).
9298
9299 * nsmenu.m (ns_update_menubar): Remove useless setDelegate call
9300 on svcsMenu (Bug#8842).
9301
9302 * nsfns.m (Fx_open_connection): Remove NSStringPboardType from
9303 ns_return_types.
9304 (Fns_list_services): Just return Qnil on 10.6, code not working there.
9305
9306 * nsterm.m (QUTF8_STRING): Declare.
9307 (initFrameFromEmacs): Call registerServicesMenuSendTypes.
9308 (validRequestorForSendType): Return type is (id).
9309 Change indexOfObjectIdenticalTo to indexOfObject.
9310 Check if we have local selection before returning self (Bug#8842).
9311 (writeSelectionToPasteboard): Put local selection into paste board
9312 if we have a local selection (Bug#8842).
9313 (syms_of_nsterm): DEFSYM QUTF8_STRING.
9314
9315 * nsterm.h (MAC_OS_X_VERSION_10_6): Define here instead of nsterm.m.
9316 (ns_get_local_selection): Declare.
9317
54e10184
LMI
93182011-07-07 Lars Magne Ingebrigtsen <larsi@gnus.org>
9319
9888ff71
LMI
9320 * keymap.c (describe_map_tree): Don't insert a double newline at
9321 the end of the buffer (bug#1169) and return whether we inserted
9322 something.
9323
54e10184
LMI
9324 * callint.c (Fcall_interactively): Change "reading args" to
9325 "providing args" to try to clarify what it does (bug#1010).
9326
15fa4783
KH
93272011-07-07 Kenichi Handa <handa@m17n.org>
9328
9329 * composite.c (composition_compute_stop_pos): Ignore a static
9330 composition starting before CHARPOS (Bug#8915).
9331
9332 * xdisp.c (handle_composition_prop): Likewise.
9333
a8815b00
EZ
93342011-07-07 Eli Zaretskii <eliz@gnu.org>
9335
9336 * term.c (produce_glyphs) <xassert>: Allow IT_GLYPHLESS in it->what.
9337 (Bug#9015)
9338
ef7b981d 93392011-07-07 Kenichi Handa <handa@m17n.org>
c805dec0
KH
9340
9341 * character.h (unicode_category_t): New enum type.
9342
9343 * chartab.c (uniprop_decoder_t, uniprop_encoder_t): New types.
9344 (Qchar_code_property_table): New variable.
9345 (UNIPROP_TABLE_P, UNIPROP_GET_DECODER)
9346 (UNIPROP_COMPRESSED_FORM_P): New macros.
9347 (char_table_ascii): Uncompress the compressed values.
9348 (sub_char_table_ref): New arg is_uniprop. Callers changed.
9349 Uncompress the compressed values.
ac389d0c 9350 (sub_char_table_ref_and_range): Likewise.
c805dec0
KH
9351 (char_table_ref_and_range): Uncompress the compressed values.
9352 (sub_char_table_set): New arg is_uniprop. Callers changed.
9353 Uncompress the compressed values.
9354 (sub_char_table_set_range): Args changed. Callers changed.
9355 (char_table_set_range): Adjuted for the above change.
9356 (map_sub_char_table): Delete args default_val and parent. Add arg
9357 top. Give decoded values to a Lisp function.
640c8776 9358 (map_char_table): Adjust for the above change. Give decoded
c805dec0
KH
9359 values to a Lisp function. Gcpro more variables.
9360 (uniprop_table_uncompress)
9361 (uniprop_decode_value_run_length): New functions.
9362 (uniprop_decoder, uniprop_decoder_count): New variables.
9363 (uniprop_get_decoder, uniprop_encode_value_character)
9364 (uniprop_encode_value_run_length, uniprop_encode_value_numeric):
9365 New functions.
9366 (uniprop_encoder, uniprop_encoder_count): New variables.
9367 (uniprop_get_encoder, uniprop_table)
9368 (Funicode_property_table_internal, Fget_unicode_property_internal)
9369 (Fput_unicode_property_internal): New functions.
9370 (syms_of_chartab): DEFSYM Qchar_code_property_table, defsubr
9371 Sunicode_property_table_internal, Sget_unicode_property_internal,
5e617bc2 9372 and Sput_unicode_property_internal. Defvar_lisp
c805dec0
KH
9373 char-code-property-alist.
9374
640c8776 9375 * composite.c (CHAR_COMPOSABLE_P): Adjust for the change of
c805dec0
KH
9376 Vunicode_category_table.
9377
640c8776 9378 * font.c (font_range): Adjust for the change of
c805dec0
KH
9379 Vunicode_category_table.
9380
76b397fb
DN
93812011-07-07 Dan Nicolaescu <dann@ics.uci.edu>
9382
9383 * m/iris4d.h: Remove file, move contents ...
9384 * s/irix6-5.h: ... here.
9385
22b4128e
PE
93862011-07-06 Paul Eggert <eggert@cs.ucla.edu>
9387
9388 Remove unportable assumption about struct layout (Bug#8884).
8a5c77bb
PE
9389 * alloc.c (mark_buffer):
9390 * buffer.c (reset_buffer_local_variables, Fbuffer_local_variables)
9391 (clone_per_buffer_values): Don't assume that
22b4128e
PE
9392 sizeof (struct buffer) is a multiple of sizeof (Lisp_Object).
9393 This isn't true in general, and it's particularly not true
9394 if Emacs is configured with --with-wide-int.
9395 * buffer.h (FIRST_FIELD_PER_BUFFER, LAST_FIELD_PER_BUFFER):
9396 New macros, used in the buffer.c change.
9397
869795d6
JD
93982011-07-05 Jan Djärv <jan.h.d@swipnet.se>
9399
9400 * xsettings.c: Use both GConf and GSettings if both are available.
9401 (store_config_changed_event): Add comment.
9402 (dpyinfo_valid, store_font_name_changed, map_tool_bar_style)
9403 (store_tool_bar_style_changed): New functions.
5e617bc2 9404 (store_monospaced_changed): Add comment. Call dpyinfo_valid.
869795d6
JD
9405 (struct xsettings): Move font inside HAVE_XFT.
9406 (GSETTINGS_TOOL_BAR_STYLE, GSETTINGS_FONT_NAME): New defines.
640c8776 9407 (GSETTINGS_MONO_FONT): Rename from SYSTEM_MONO_FONT.
869795d6 9408 Move inside HAVE_XFT.
640c8776 9409 (something_changed_gsettingsCB): Rename from something_changedCB.
869795d6
JD
9410 Check for changes in GSETTINGS_TOOL_BAR_STYLE and GSETTINGS_FONT_NAME
9411 also.
9412 (GCONF_TOOL_BAR_STYLE, GCONF_FONT_NAME): New defines.
5e617bc2 9413 (GCONF_MONO_FONT): Rename from SYSTEM_MONO_FONT. Move inside HAVE_XFT.
640c8776 9414 (something_changed_gconfCB): Rename from something_changedCB.
869795d6
JD
9415 Check for changes in GCONF_TOOL_BAR_STYLE and GCONF_FONT_NAME also.
9416 (parse_settings): Move check for font inside HAVE_XFT.
9417 (read_settings, apply_xft_settings): Add comment.
9418 (read_and_apply_settings): Add comment. Call map_tool_bar_style and
9419 store_tool_bar_style_changed. Move check for font inside HAVE_XFT and
9420 call store_font_name_changed.
9421 (xft_settings_event): Add comment.
9422 (init_gsettings): Add comment. Get values for GSETTINGS_TOOL_BAR_STYLE
9423 and GSETTINGS_FONT_NAME. Move check for fonts within HAVE_XFT.
9424 (init_gconf): Add comment. Get values for GCONF_TOOL_BAR_STYLE
9425 and GCONF_FONT_NAME. Move check for fonts within HAVE_XFT.
9426 (xsettings_initialize): Call init_gsettings last.
640c8776
SM
9427 (xsettings_get_system_font, xsettings_get_system_normal_font):
9428 Add comment.
869795d6 9429
d8ed26bd
PE
94302011-07-05 Paul Eggert <eggert@cs.ucla.edu>
9431
9432 Random fixes. E.g., (random) never returned negative values.
9433 * fns.c (Frandom): Use GET_EMACS_TIME for random seed, and add the
9434 subseconds part to the entropy, as that's a bit more random.
9435 Prefer signed to unsigned, since the signedness doesn't matter and
9436 in general we prefer signed. When given a limit, use a
9437 denominator equal to INTMASK + 1, not to VALMASK + 1, because the
9438 latter isn't right if USE_2_TAGS_FOR_INTS.
9439 * sysdep.c (get_random): Return a value in the range 0..INTMASK,
9440 not 0..VALMASK. Don't discard "excess" bits that random () returns.
9441
cabf1cac
SM
94422011-07-04 Stefan Monnier <monnier@iro.umontreal.ca>
9443
9444 * textprop.c (text_property_stickiness):
9445 Obey Vtext_property_default_nonsticky.
9446 (syms_of_textprop): Add `display' to Vtext_property_default_nonsticky.
9447 * w32fns.c (syms_of_w32fns):
9448 * xfns.c (syms_of_xfns): Don't Add `display' since it's there by default.
9449
6e9b2be9
PE
94502011-07-04 Paul Eggert <eggert@cs.ucla.edu>
9451
9452 * fileio.c (barf_or_query_if_file_exists): Use S_ISDIR.
9453 This is more efficient than Ffile_directory_p and avoids a minor race.
9454
90186c68
LMI
94552011-07-04 Lars Magne Ingebrigtsen <larsi@gnus.org>
9456
7c301272
LMI
9457 * buffer.c (Foverlay_put): Say what the return value is
9458 (bug#7835).
9459
c4f2d8d4
LMI
9460 * fileio.c (barf_or_query_if_file_exists): Check first if the file
9461 is a directory before asking whether to use the file name
9462 (bug#7564).
ad637907
LMI
9463 (barf_or_query_if_file_exists): Make the "File is a directory"
9464 error be more correct.
c4f2d8d4 9465
90186c68
LMI
9466 * fns.c (Frequire): Remove the mention of the .gz files, since
9467 that's installation-specific, but keep the mention of
9468 `get-load-suffixes'.
9469
da64016e
PE
94702011-07-04 Paul Eggert <eggert@cs.ucla.edu>
9471
9472 * editfns.c (Fformat_time_string): Don't assume strlen fits in int.
9473 Report string overflow if the output is too long.
9474
7d47b580
JB
94752011-07-04 Juanma Barranquero <lekktu@gmail.com>
9476
a555cb87
JB
9477 * gnutls.c (Fgnutls_boot): Don't mention :verify-error.
9478 (syms_of_gnutls): Remove duplicate DEFSYM for
9479 Qgnutls_bootprop_verify_hostname_error, an error for
9480 Qgnutls_bootprop_verify_error (which is no longer used).
9481
7d47b580
JB
9482 * eval.c (find_handler_clause): Remove parameters `sig' and `data',
9483 unused since 2011-01-26T20:02:07Z!monnier@iro.umontreal.ca. All callers changed.
9484 Also (re)move comments that are misplaced or no longer relevant.
9485
1e49bfab
LMI
94862011-07-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
9487
9488 * callint.c (Finteractive): Clarify the meaning of "@" (bug#8813).
9489
1485f4c0
CY
94902011-07-03 Chong Yidong <cyd@stupidchicken.com>
9491
9492 * xfaces.c (Finternal_merge_in_global_face): Modify the foreground
9493 and background color parameters if they have been changed.
9494
a9ab721e
LMI
94952011-07-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
9496
9497 * editfns.c (Fformat): Clarify the - and 0 flags (bug#6659).
9498
cf7cff57
PE
94992011-07-03 Paul Eggert <eggert@cs.ucla.edu>
9500
2e13213d
PE
9501 * xsettings.c (SYSTEM_FONT): Define only when used.
9502 No need to define when HAVE_GSETTINGS || !HAVE_XFT.
9503
cf7cff57
PE
9504 * keymap.c (access_keymap_1): Now static.
9505
7a8e04f7
CY
95062011-07-02 Chong Yidong <cyd@stupidchicken.com>
9507
9508 * keyboard.c (command_loop_1): If a down-mouse event is unbound,
9509 leave any prefix arg for the up event (Bug#1586).
9510
61352f62
LMI
95112011-07-02 Lars Magne Ingebrigtsen <larsi@gnus.org>
9512
69bb1ef7
LMI
9513 * lread.c (syms_of_lread): Mention single symbols defined by
9514 `defvar' or `defconst' (bug#7154).
9515
61352f62 9516 * fns.c (Frequire): Mention .el.gz files (bug#7314).
7b3747f9 9517 (Frequire): Mention get-load-suffixes.
61352f62 9518
28545e04
MR
95192011-07-02 Martin Rudalics <rudalics@gmx.at>
9520
9521 * window.h (window): Remove clone_number slot.
9522 * window.c (Fwindow_clone_number, Fset_window_clone_number):
9523 Remove.
9524 (make_parent_window, make_window, saved_window)
9525 (Fset_window_configuration, save_window_save): Don't deal with
9526 clone numbers.
9527 * buffer.c (Qclone_number): Remove declaration.
9528 (sort_overlays, overlay_strings): Don't deal with clone numbers.
9529
3349e122
SM
95302011-07-02 Stefan Monnier <monnier@iro.umontreal.ca>
9531
9532 Add multiple inheritance to keymaps.
9533 * keymap.c (Fmake_composed_keymap): New function.
9534 (Fset_keymap_parent): Simplify.
9535 (fix_submap_inheritance): Remove.
9536 (access_keymap_1): New function extracted from access_keymap to handle
9537 embedded parents and handle lists of maps.
9538 (access_keymap): Use it.
9539 (Fkeymap_prompt, map_keymap_internal, map_keymap, store_in_keymap)
9540 (Fcopy_keymap): Handle embedded parents.
9541 (Fcommand_remapping, define_as_prefix): Simplify.
9542 (Fkey_binding): Simplify.
9543 (syms_of_keymap): Move minibuffer-local-completion-map,
9544 minibuffer-local-filename-completion-map,
9545 minibuffer-local-must-match-map, and
9546 minibuffer-local-filename-must-match-map to Elisp.
9547 (syms_of_keymap): Defsubr make-composed-keymap.
9548 * keyboard.c (menu_bar_items): Use map_keymap_canonical.
9549 (parse_menu_item): Trivial simplification.
9550
3279eb87
GM
95512011-07-01 Glenn Morris <rgm@gnu.org>
9552
9553 * Makefile.in (SETTINGS_LIBS): Fix typo.
9554
4550efdf
KI
95552011-07-01 Kazuhiro Ito <kzhr@d1.dion.ne.jp> (tiny patch)
9556
9557 * coding.c (Fencode_coding_string): Record the last coding system
9558 used, as the function doc string says (bug#8738).
9559
0949d2b6
JD
95602011-07-01 Jan Djärv <jan.h.d@swipnet.se>
9561
9562 * xsettings.c (store_monospaced_changed): Take new font as arg and
9563 check for change against current_mono_font.
9564 (EMACS_TYPE_SETTINGS): Remove this and related defines.
9565 (emacs_settings_constructor, emacs_settings_get_property)
9566 (emacs_settings_set_property, emacs_settings_class_init)
9567 (emacs_settings_init, gsettings_obj): Remove.
9568 (something_changedCB): New function for HAVE_GSETTINGS.
9569 (something_changedCB): HAVE_GCONF: Call store_monospaced_changed
9570 with value as argument.
9571 (init_gsettings): Check that GSETTINGS_SCHEMA exists before calling
9572 g_settings_new (Bug#8967). Do not create gsettings_obj.
9173deec 9573 Remove calls to g_settings_bind. Connect something_changedCB to
0949d2b6
JD
9574 "changed".
9575
9576 * xgselect.c: Add defined (HAVE_GSETTINGS).
9577 (xgselect_initialize): Ditto.
9578
9579 * process.c: Add defined (HAVE_GSETTINGS) for xgselect.h
9580 (wait_reading_process_output): Add defined (HAVE_GSETTINGS) for
9581 xg_select.
9582
bbc6b304
PE
95832011-07-01 Paul Eggert <eggert@cs.ucla.edu>
9584
9585 * eval.c (struct backtrace): Simplify and port the data structure.
9586 Do not assume that "int nargs : BITS_PER_INT - 2;" produces a
9587 signed bit field, as this assumption is not portable and it makes
9588 Emacs crash when compiled with Sun C 5.8 on sparc. Do not use
9589 "char debug_on_exit : 1" as this is not portable either; instead,
9590 use the portable "unsigned int debug_on_exit : 1". Remove unused
9591 member evalargs. Remove obsolete comments about cc bombing out.
9592
9851bfc5
JD
95932011-06-30 Jan Djärv <jan.h.d@swipnet.se>
9594
51bb811f 9595 * xsettings.c: Include glib-object.h, gio/gio.h if HAVE_GSETTINGS.
9851bfc5
JD
9596 Let HAVE_GSETTINGS override HAVE_GCONF.
9597 (store_monospaced_changed): New function.
9598 (EMACS_SETTINGS): A new type derived from GObject to handle
9599 GSettings notifications.
9600 (emacs_settings_constructor, emacs_settings_get_property)
9601 (emacs_settings_set_property, emacs_settings_class_init):
9602 New functions.
9603 (gsettings_client, gsettings_obj): New variables.
9604 (GSETTINGS_SCHEMA): New define.
9605 (something_changedCB): Call store_monospaced_changed.
9606 (init_gsettings): New function.
9607 (xsettings_initialize): Call init_gsettings.
9608 (syms_of_xsettings): Initialize gsettings_client, gsettings_obj
9609 to NULL.
9610
640c8776 9611 * Makefile.in (SETTINGS_CFLAGS, SETTINGS_LIBS): Rename from
9851bfc5
JD
9612 GCONF_CFLAGS/LIBS.
9613
5386012d
MR
96142011-06-29 Martin Rudalics <rudalics@gmx.at>
9615
9616 * window.c (resize_root_window, grow_mini_window)
9617 (shrink_mini_window): Rename Qresize_root_window to
9618 Qwindow_resize_root_window and Qresize_root_window_vertically to
9619 Qwindow_resize_root_window_vertically.
9620
f13e0b08
PE
96212011-06-28 Paul Eggert <eggert@cs.ucla.edu>
9622
9623 * gnutls.c (Qgnutls_bootprop_verify_error): Remove unused var.
9624
94515237
JB
96252011-06-27 Juanma Barranquero <lekktu@gmail.com>
9626
9627 * makefile.w32-in: Redesign dependencies so they reflect more
9628 clearly which files are directly included by each source file,
9629 and not through other includes.
9630
e43b6e43
MR
96312011-06-27 Martin Rudalics <rudalics@gmx.at>
9632
9633 * buffer.c (Qclone_number): Declare static and DEFSYM it.
9634 (sort_overlays, overlay_strings): When an overlay's clone number
9635 matches the window's clone number process the overlay even if
9636 the overlay's window property doesn't match the current window.
9637
d68443dc
MR
9638 * window.c (Fwindow_vchild): Rename to Fwindow_top_child.
9639 (Fwindow_hchild): Rename to Fwindow_left_child.
9640 (Fwindow_next): Rename to Fwindow_next_sibling.
9641 (Fwindow_prev): Rename to Fwindow_prev_sibling.
d615d6d2
MR
9642 (resize_window_check): Rename to window_resize_check.
9643 (resize_window_apply): Rename to window_resize_apply.
9644 (Fresize_window_apply): Rename to Fwindow_resize_apply.
9645 (Fdelete_other_windows_internal, resize_frame_windows)
9646 (Fsplit_window_internal, Fdelete_window_internal)
9647 (grow_mini_window, shrink_mini_window)
9648 (Fresize_mini_window_internal): Fix callers accordingly.
d68443dc 9649
c7e73be5
JD
96502011-06-26 Jan Djärv <jan.h.d@swipnet.se>
9651
9652 * emacsgtkfixed.h: State that this is only used with Gtk+3.
9653 (emacs_fixed_set_min_size): Remove.
9654 (emacs_fixed_new): Take frame as argument.
9655
9656 * emacsgtkfixed.c: State that this is only used with Gtk+3.
9657 (_EmacsFixedPrivate): Remove minwidth/height.
9658 Add struct frame *f.
9659 (emacs_fixed_init): Initialize priv->f.
9660 (get_parent_class, emacs_fixed_set_min_size): Remove.
9661 (emacs_fixed_new): Set priv->f to argument.
9662 (emacs_fixed_get_preferred_width)
9663 (emacs_fixed_get_preferred_height): Use min_width/height from
9664 frames size_hint to set minimum and natural (Bug#8919).
9665 (XSetWMSizeHints, XSetWMNormalHints): Override these functions
9666 and use min_width/height from frames size_hint to set
9667 min_width/height (Bug#8919).
9668
9669 * gtkutil.c (xg_create_frame_widgets): Pass f to emacs_fixed_new.
9173deec
JB
9670 (x_wm_set_size_hint): Remove call to emacs_fixed_set_min_size.
9671 Fix indentation.
c7e73be5 9672
cf99dcf8
EZ
96732011-06-26 Eli Zaretskii <eliz@gnu.org>
9674
9675 * bidi.c (bidi_paragraph_init): Test for ZV_BYTE before calling
9676 bidi_at_paragraph_end, since fast_looking_at doesn't like to be
9677 called at ZV.
9678
029529ac
CY
96792011-06-26 Chong Yidong <cyd@stupidchicken.com>
9680
9681 * process.c (wait_reading_process_output): Bypass select if
9682 waiting for a cell while ignoring keyboard input, and input is
9683 pending. Suggested by Jan Djärv (Bug#8869).
9684
7a7ef429
PE
96852011-06-25 Paul Eggert <eggert@cs.ucla.edu>
9686
9687 Use gnulib's dup2 module instead of rolling our own.
9688 * sysdep.c (dup2) [!HAVE_DUP2]: Remove; gnulib now does this.
9689
11fdef7d 96902011-06-25 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
989b42d2
YM
9691
9692 * dispnew.c (scrolling_window): Before scrolling, turn off a
9693 mouse-highlight in the window being scrolled.
9694
cd3520a4
JB
96952011-06-24 Juanma Barranquero <lekktu@gmail.com>
9696
9697 Move DEFSYM to lisp.h and use everywhere.
9698
9699 * character.h (DEFSYM): Move declaration...
9700 * lisp.h (DEFSYM): ...here.
9701
9702 * gnutls.c:
9703 * minibuf.c:
9704 * w32menu.c:
9705 * w32proc.c:
9706 * w32select.c: Don't include character.h.
9707
9708 * alloc.c (syms_of_alloc):
9709 * buffer.c (syms_of_buffer):
9710 * bytecode.c (syms_of_bytecode):
9711 * callint.c (syms_of_callint):
9712 * casefiddle.c (syms_of_casefiddle):
9713 * casetab.c (init_casetab_once):
9714 * category.c (init_category_once, syms_of_category):
9715 * ccl.c (syms_of_ccl):
9716 * cmds.c (syms_of_cmds):
9717 * composite.c (syms_of_composite):
9718 * dbusbind.c (syms_of_dbusbind):
9719 * dired.c (syms_of_dired):
9720 * dispnew.c (syms_of_display):
9721 * doc.c (syms_of_doc):
9722 * editfns.c (syms_of_editfns):
9723 * emacs.c (syms_of_emacs):
9724 * eval.c (syms_of_eval):
9725 * fileio.c (syms_of_fileio):
9726 * fns.c (syms_of_fns):
9727 * frame.c (syms_of_frame):
9728 * fringe.c (syms_of_fringe):
9729 * insdel.c (syms_of_insdel):
9730 * keymap.c (syms_of_keymap):
9731 * lread.c (init_obarray, syms_of_lread):
9732 * macros.c (syms_of_macros):
9733 * msdos.c (syms_of_msdos):
9734 * print.c (syms_of_print):
9735 * process.c (syms_of_process):
9736 * search.c (syms_of_search):
9737 * sound.c (syms_of_sound):
9738 * syntax.c (init_syntax_once, syms_of_syntax):
9739 * terminal.c (syms_of_terminal):
9740 * textprop.c (syms_of_textprop):
9741 * undo.c (syms_of_undo):
9742 * w32.c (globals_of_w32):
9743 * window.c (syms_of_window):
9744 * xdisp.c (syms_of_xdisp):
9745 * xfaces.c (syms_of_xfaces):
9746 * xfns.c (syms_of_xfns):
9747 * xmenu.c (syms_of_xmenu):
9748 * xsettings.c (syms_of_xsettings):
9749 * xterm.c (syms_of_xterm): Use DEFSYM.
9750
4228cf16
TZ
97512011-06-24 Teodor Zlatanov <tzz@lifelogs.com>
9752
cd3520a4 9753 * gnutls.c (syms_of_gnutls): Use the DEFSYM macro from character.h.
4228cf16 9754
7fcccf1e
PE
97552011-06-23 Paul Eggert <eggert@cs.ucla.edu>
9756
7efb4e0e
PE
9757 Integer and buffer overflow fixes (Bug#8873).
9758
ff5844ad
PE
9759 * print.c (printchar, strout): Check for string overflow.
9760 (PRINTPREPARE, printchar, strout):
9761 Don't set size unless allocation succeeds.
9762
90532f02
PE
9763 * minibuf.c (read_minibuf_noninteractive): Use ptrdiff_t, not int,
9764 for sizes. Check for string overflow more accurately.
9765 Simplify newline removal at end; this suppresses a GCC 4.6.0 warning.
9766
6d84508d
PE
9767 * macros.c: Integer and buffer overflow fixes.
9768 * keyboard.h (struct keyboard.kbd_macro_bufsize):
9769 * macros.c (Fstart_kbd_macro, store_kbd_macro_char):
9770 Use ptrdiff_t, not int, for sizes.
9771 Don't increment bufsize until after realloc succeeds.
9772 Check for size-calculation overflow.
9773 (Fstart_kbd_macro): Use EMACS_INT, not int, for XINT result.
9774
437b2cb4
PE
9775 * lisp.h (DEFVAR_KBOARD): Use offsetof instead of char * finagling.
9776
8b9ac8b4
PE
9777 * lread.c: Integer overflow fixes.
9778 (read_integer): Radix is now EMACS_INT, not int,
9779 to improve quality of diagnostics for out-of-range radices.
9780 Calculate buffer size correctly for out-of-range radices.
9781 (read1): Check for integer overflow in radices, and in
9782 read-circle numbers.
82cb60d3
PE
9783 (read_escape): Avoid int overflow.
9784 (Fload, openp, read_buffer_size, read1)
9785 (substitute_object_recurse, read_vector, read_list, map_obarray):
9786 Use ptrdiff_t, not int, for sizes.
9787 (read1): Use EMACS_INT, not int, for sizes.
20270765 9788 Check for size overflow.
8b9ac8b4 9789
7fcccf1e
PE
9790 * image.c (cache_image): Check for size arithmetic overflow.
9791
bfbbd7e7
PE
9792 * lread.c: Integer overflow issues.
9793 (saved_doc_string_size, saved_doc_string_length)
9794 (prev_saved_doc_string_size, prev_saved_doc_string_length):
9795 Now ptrdiff_t, not int.
9796 (read1): Don't assume doc string length fits in int. Check for
9797 out-of-range doc string lengths.
9798 (read_list): Don't assume file position fits in int.
39019e54 9799 (read_escape): Check for hex character overflow.
bfbbd7e7 9800
4e323265
LL
98012011-06-22 Leo Liu <sdl.web@gmail.com>
9802
9803 * minibuf.c (Fcompleting_read_default, Vcompleting_read_function):
9804 Move to minibuffer.el.
9805
85fece3e
PE
98062011-06-22 Paul Eggert <eggert@cs.ucla.edu>
9807
20b84ce9 9808 Fixes for GLYPH_DEBUG found by GCC 4.6.0 static checking.
85fece3e
PE
9809 The following patches are for when GLYPH_DEBUG && !XASSERT.
9810 * dispextern.h (trace_redisplay_p, dump_glyph_string):
9811 * dispnew.c (flush_stdout):
9812 * xdisp.c (dump_glyph_row, dump_glyph_matrix, dump_glyph):
9813 Mark as externally visible.
9814 * dispnew.c (check_window_matrix_pointers): Now static.
9815 * dispnew.c (window_to_frame_vpos):
9816 * xfns.c (unwind_create_frame):
9817 * xterm.c (x_check_font): Remove unused local.
9818 * scroll.c (CHECK_BOUNDS):
9819 * xfaces.c (cache_fache): Rename local to avoid shadowing.
9820 * xfns.c, w32fns.c (image_cache_refcount, dpyinfo_refcount): Now static.
9821 * xdisp.c (check_window_end): Now a no-op if !XASSERTS.
9822 (debug_first_unchanged_at_end_vpos, debug_last_unchanged_at_beg_vpos)
9823 (debug_dvpos, debug_dy, debug_delta, debug_delta_bytes, debug_end_vpos):
9824 Now static.
9825 (debug_method_add): Use va_list and vsprintf rather than relying
9826 on undefined behavior with wrong number of arguments.
9827 (dump_glyph, dump_glyph_row, Fdump_glyph_matrix):
9828 Don't assume ptrdiff_t and EMACS_INT are the same width as int.
9829 In this code, it's OK to assume C99 behavior for ptrdiff_t formats
9830 since we're not interested in debugging glyphs with old libraries.
9831 * xfaces.c (cache_face): Move debugging code earlier; this pacifies
9832 GCC 4.6.0's static checking.
9833
0766b489
PE
98342011-06-22 Paul Eggert <eggert@cs.ucla.edu>
9835
31fd4b32
PE
9836 Integer overflow and signedness fixes (Bug#8873).
9837 A few related buffer overrun fixes, too.
9838
b79e8648
PE
9839 * font.c (font_score): Use EMACS_INT, not int, to store XINT value.
9840
0766b489
PE
9841 * dispextern.h (struct face.stipple):
9842 * image.c (x_bitmap_height, x_bitmap_width, x_bitmap_pixmap)
9843 (x_bitmap_mask, x_allocate_bitmap_record)
9844 (x_create_bitmap_from_data, x_create_bitmap_from_file)
9845 (x_destroy_bitmap, x_destroy_all_bitmaps, x_create_bitmap_mask)
9846 (x_create_bitmap_from_xpm_data):
9847 * nsterm.h (struct ns_display_info.bitmaps_size, .bitmaps_last):
9848 * w32term.h (struct w32_display_info.icon_bitmap_id, .bitmaps_size)
9849 (.bitmaps_last):
9850 * xfaces.c (load_pixmap):
9851 * xterm.c (x_bitmap_icon, x_wm_set_icon_pixmap):
9852 * xterm.h (struct x_display_info.icon_bitmap_id, .bitmaps_size)
9853 (.bitmaps_last, struct x_output.icon_bitmap):
9854 Use ptrdiff_t, not int, for bitmap indexes.
9855 (x_allocate_bitmap_record): Check for size overflow.
9856 * dispextern.h, lisp.h: Adjust to API changes elsewhere.
9857
b081724f
PE
9858 Use ptrdiff_t, not int, for overlay counts.
9859 * buffer.h (overlays_at, sort_overlays, GET_OVERLAYS_AT):
9860 * editfns.c (overlays_around, get_pos_property):
9861 * textprop.c (get_char_property_and_overlay):
9862 * xdisp.c (next_overlay_change, note_mouse_highlight):
9863 * xfaces.c (face_at_buffer_position):
21514da7
PE
9864 * buffer.c (OVERLAY_COUNT_MAX): New macro.
9865 (overlays_at, overlays_in, sort_overlays, Foverlays_at)
9866 (Fnext_overlay_change, Fprevious_overlay_change)
9867 (mouse_face_overlay_overlaps, Foverlays_in):
b081724f 9868 Use ptrdiff_t, not int, for sizes.
21514da7 9869 (overlays_at, overlays_in): Check for size-calculation overflow.
b081724f 9870
3de73e5e
PE
9871 * xterm.c (xim_initialize, same_x_server): Strlen may not fit in int.
9872
2606c57b
PE
9873 * xsmfns.c (smc_save_yourself_CB, x_session_initialize): Avoid strlen.
9874 (x_session_initialize): Do not assume string length fits in int.
9875
aaafe47a
PE
9876 * xsettings.c (apply_xft_settings): Fix potential buffer overrun.
9877 This is unlikely, but can occur if DPI is outlandish.
9878
2674ddc8 9879 * xsettings.c (Ffont_get_system_normal_font, Ffont_get_system_font):
3a5077c5
PE
9880 * xselect.c (Fx_get_atom_name): Avoid need for strlen.
9881
28154962
PE
9882 * xrdb.c: Don't assume strlen fits in int; avoid some strlens.
9883 * xrdb.c (magic_file_p, search_magic_path):
9884 Omit last arg SUFFIX; it was always 0. All callers changed.
9885 (magic_file_p): Use ptrdiff_t, not int. Check for size overflow.
9886
7de51af5
PE
9887 * xfont.c (xfont_match): Avoid need for strlen.
9888
25ed6cc3
PE
9889 * xfns.c: Don't assume strlen fits in int.
9890 (xic_create_fontsetname, x_window): Use ptrdiff_t, not int.
9891
4eab31dd
PE
9892 * xdisp.c (message_log_check_duplicate): Return intmax_t,
9893 not unsigned long, as we prefer signed integers. All callers changed.
9894 Detect integer overflow in repeat count.
9895 (message_dolog): Don't assume print length fits in 39 bytes.
df1f27af 9896 (display_mode_element): Don't assume strlen fits in int.
4eab31dd 9897
171e2a58
PE
9898 * termcap.c: Don't assume sizes fit in int and never overflow.
9899 (struct termcap_buffer, tgetent): Use ptrdiff_t, not int, for sizes.
9900 (gobble_line): Check for size-calculation overflow.
9901
ad39faca 9902 * minibuf.c (Fread_buffer):
6e5bb2dc 9903 * lread.c (intern, intern_c_string):
74ca2eb3
PE
9904 * image.c (xpm_scan) [HAVE_NS && !HAVE_XPM]:
9905 Don't assume string length fits in int.
9906
52c61c22 9907 * keyboard.c (parse_tool_bar_item):
9bda3520
PE
9908 * gtkutil.c (style_changed_cb): Avoid need for strlen.
9909
b5b8c9e5
PE
9910 * font.c: Don't assume string length fits in int.
9911 (font_parse_xlfd, font_parse_fcname, font_unparse_fcname):
9912 Use ptrdiff_t, not int.
ccd6111c
PE
9913 (font_intern_prop): Don't assume string length fits in int.
9914 Don't assume integer property fits in fixnum.
9915 * font.h (font_intern_prop): 2nd arg is now ptrdiff_t, not int.
b5b8c9e5 9916
882f0d81 9917 * filelock.c: Fix some buffer overrun and integer overflow issues.
51cab52b 9918 (get_boot_time): Don't assume gzip command string fits in 100 bytes.
882f0d81
PE
9919 Reformulate so as not to need the command string.
9920 Invoke gzip -cd rather than gunzip, as it's more portable.
9921 (lock_info_type, lock_file_1, lock_file):
9922 Don't assume pid_t and time_t fit in unsigned long.
9923 (LOCK_PID_MAX): Remove; we now use more-reliable bounds.
9924 (current_lock_owner): Prefer signed type for sizes.
9925 Use memcpy, not strncpy, where memcpy is what is really wanted.
9926 Don't assume (via atoi) that time_t and pid_t fit in int.
9927 Check for time_t and/or pid_t out of range, e.g., via a network share.
9928 Don't alloca where an auto var works fine.
9929
93f4cf88
PE
9930 * fileio.c: Fix some integer overflow issues.
9931 (file_name_as_directory, Fexpand_file_name, Fsubstitute_in_file_name):
9932 Don't assume string length fits in int.
9933 (directory_file_name): Don't assume string length fits in long.
9934 (make_temp_name): Don't assume pid fits in int, or that its print
9935 length is less than 20.
9936
f3e92b69
PE
9937 * data.c (Fsubr_name): Rewrite to avoid a strlen call.
9938
1bfdaf10
PE
9939 * coding.c (make_subsidiaries): Don't assume string length fits in int.
9940
35016e9a
PE
9941 * callproc.c (child_setup): Rewrite to avoid two strlen calls.
9942
3d1e65a1
PE
9943 * process.c (Fformat_network_address): Use EMACS_INT, not EMACS_UINT.
9944 We prefer signed integers, even for size calculations.
9945
0b963a93
PE
9946 * emacs.c: Don't assume string length fits in 'int'.
9947 (DEFINE_DUMMY_FUNCTION, sort_args): Use ptrdiff_t, not int.
9948 (main): Don't invoke strlen when not needed.
9949
573f4b54
PE
9950 * dbusbind.c (XD_ERROR): Don't arbitrarily truncate string.
9951 (XD_DEBUG_MESSAGE): Don't waste a byte.
9952
989f33ba
PE
9953 * callproc.c (getenv_internal_1, getenv_internal)
9954 (Fgetenv_internal):
965d34eb
PE
9955 * buffer.c (init_buffer): Don't assume string length fits in 'int'.
9956
e4d29b33
PE
9957 * lread.c (invalid_syntax): Omit length argument.
9958 All uses changed. This doesn't fix a bug, but it simplifies the
9959 code away from its former Hollerith-constant appearance, and it's
9960 one less 'int' to worry about when looking at integer-overflow issues.
51cab52b 9961 (string_to_number): Simplify 2011-04-26 change by invoking xsignal1.
e4d29b33 9962
eb49b136
PE
9963 * lisp.h (DEFUN): Remove bogus use of sizeof (struct Lisp_Subr).
9964 This didn't break anything, but it didn't help either.
9965 It's confusing to put a bogus integer in a place where the actual
9966 value does not matter.
9f62aeb1 9967 (LIST_END_P): Remove unused macro and its bogus comment.
cbeff735 9968 (make_fixnum_or_float): Remove unnecessary cast to EMACS_INT.
eb49b136 9969
15375a22
PE
9970 * lisp.h (union Lisp_Object.i): EMACS_INT, not EMACS_UINT.
9971 This is for consistency with the ordinary, non-USE_LISP_UNION_TYPE,
9972 implementation.
b61cc01c
PE
9973 (struct Lisp_Bool_Vector.size): EMACS_INT, not EMACS_UINT.
9974 We prefer signed types, and the value cannot exceed the EMACS_INT
9975 range anyway (because otherwise the length would not be representable).
9a8e8d9b
PE
9976 (XSET) [USE_LISP_UNION_TYPE]: Use uintptr_t and intptr_t,
9977 not EMACS_UINT and EMACS_INT, when converting pointer to integer.
9978 This avoids a GCC warning when WIDE_EMACS_INT.
15375a22 9979
53b2623d
PE
9980 * indent.c (sane_tab_width): New function.
9981 (current_column, scan_for_column, Findent_to, position_indentation)
9982 (compute_motion): Use it. This is just for clarity.
8fcaf9cc 9983 (Fcompute_motion): Don't assume hscroll and tab offset fit in int.
53b2623d 9984
51cab52b 9985 * image.c (xbm_image_p): Don't assume stated width, height fit in int.
45aebb64 9986
f2ed8a70
PE
9987 * lisp.h (lint_assume): New macro.
9988 * composite.c (composition_gstring_put_cache):
9989 * ftfont.c (ftfont_shape_by_flt): Use it to pacify GCC 4.6.0.
9990
abe80cc6
PE
9991 * editfns.c, insdel.c:
9992 Omit unnecessary forward decls, to simplify future changes.
a9e860e1 9993
b02c740e
PE
9994 * ftfont.c (ftfont_shape_by_flt): Use signed integers for lengths.
9995
ebc96716
PE
9996 * font.c (Ffont_shape_gstring): Don't assume glyph len fits in 'int'.
9997
b4e50fa0 9998 * fns.c (Ffillarray): Don't assume bool vector size fits in 'int'.
f03dc6ef 9999 Use much-faster test for byte-length change.
311d5d7c 10000 Don't assume string byte-length fits in 'int'.
a4cf38e4 10001 Check that character arg fits in 'int'.
85461888 10002 (mapcar1): Declare byte as byte, for clarity.
b4e50fa0 10003
c0c1ee9f
PE
10004 * alloc.c (Fmake_bool_vector): Avoid unnecessary multiplication.
10005
a498d7f4
PE
10006 * fns.c (concat): Catch string overflow earlier.
10007 Do not rely on integer wraparound.
10008
51cab52b
PE
10009 * dispextern.h (struct it.overlay_strings_charpos)
10010 (struct it.selective): Now EMACS_INT, not int.
87830974
PE
10011 * xdisp.c (forward_to_next_line_start)
10012 (back_to_previous_visible_line_start)
10013 (reseat_at_next_visible_line_start, next_element_from_buffer):
10014 Don't arbitrarily truncate the value of 'selective' to int.
10015
76031fad
PE
10016 * xdisp.c (init_iterator): Use XINT, not XFASTINT; it might be < 0.
10017
5eb55db9
PE
10018 * composite.c: Don't truncate sizes to 'int'.
10019 (composition_gstring_p, composition_reseat_it)
10020 (composition_adjust_point): Use EMACS_INT, not int.
7d100a81
PE
10021 (get_composition_id, composition_gstring_put_cache): Use EMACS_INT,
10022 not EMACS_UINT, for indexes.
5eb55db9 10023
0703a717
PE
10024 * category.h (CATEGORY_SET_P): Remove unnecessary cast to EMACS_INT.
10025
d6202519
PE
10026 * buffer.c: Include <verify.h>.
10027 (struct sortvec.priority, struct sortstr.priority):
8961a454 10028 Now EMACS_INT, not int.
c20998a7 10029 (compare_overlays, cmp_for_strings): Avoid subtraction overflow.
67c36fce
PE
10030 (struct sortstr.size, record_overlay_string)
10031 (struct sortstrlist.size, struct sortlist.used):
10032 Don't truncate size to int.
10033 (record_overlay_string): Check for size-calculation overflow.
d6202519 10034 (init_buffer_once): Check at compile-time, not run-time.
fadf4e30 10035
d5a19415
JM
100362011-06-22 Jim Meyering <meyering@redhat.com>
10037
029529ac 10038 Don't leak an XBM-image-sized buffer
d5a19415
JM
10039 * image.c (xbm_load): Free the image buffer after using it.
10040
a9041e6c
PE
100412011-06-21 Paul Eggert <eggert@cs.ucla.edu>
10042
10043 Port to Sun C.
10044 * composite.c (find_automatic_composition): Omit needless 'return 0;'
10045 that Sun C diagnosed.
10046 * fns.c (secure_hash): Fix pointer signedness issue.
10047 * intervals.c (static_offset_intervals): New function.
10048 (offset_intervals): Use it.
10049
7f3f739f
LL
100502011-06-21 Leo Liu <sdl.web@gmail.com>
10051
10052 * deps.mk (fns.o):
10053 * makefile.w32-in ($(BLD)/fns.$(O)): Include sha256.h and
10054 sha512.h.
10055
10056 * fns.c (secure_hash): Rename from crypto_hash_function and change
10057 the first arg to accept symbols.
5b66d427 10058 (Fsecure_hash): New primitive.
7f3f739f
LL
10059 (syms_of_fns): New symbols.
10060
76147d94
DD
100612011-06-20 Deniz Dogan <deniz@dogan.se>
10062
10063 * process.c (Fset_process_buffer): Clarify return value in
10064 docstring.
10065
7d7d0045
CY
100662011-06-18 Chong Yidong <cyd@stupidchicken.com>
10067
10068 * dispnew.c (add_window_display_history): Use BVAR.
10069
10070 * xdisp.c (debug_method_add): Use BVAR.
10071 (check_window_end, dump_glyph_matrix, dump_glyph)
10072 (dump_glyph_row, dump_glyph_string): Convert arglist to ANSI C.
10073
10074 * xfaces.c (check_lface_attrs, check_lface, dump_realized_face):
10075 Likewise.
10076
10077 * xfns.c (Fx_create_frame, x_create_tip_frame): Delay image cache
10078 check till after the cache is created in init_frame_faces.
10079
ff2bc410
SM
100802011-06-17 Stefan Monnier <monnier@iro.umontreal.ca>
10081
10082 * fns.c (Fsafe_length): Yet another int/Lisp_Object mixup.
10083
28177add
PE
100842011-06-16 Paul Eggert <eggert@cs.ucla.edu>
10085
dd3482fe
PE
10086 * lisp.h: Include <limits.h>, for INT_MAX, LONG_MAX, LLONG_MAX.
10087 Without this, prin1 mishandles Lisp_Misc_Save_Value printing on
10088 hosts with pre-C99 libraries, because pD is wrongly defined to "t".
10089
393d71f3 10090 Improve buffer-overflow checking (Bug#8873).
1c8e352f
PE
10091 * fileio.c (Finsert_file_contents):
10092 * insdel.c (insert_from_buffer_1, replace_range, replace_range_2):
10093 Remove the old (too-loose) buffer overflow checks.
10094 They weren't needed, since make_gap checks for buffer overflow.
10095 * insdel.c (make_gap_larger): Catch buffer overflows that were missed.
10096 The old code merely checked for Emacs fixnum overflow, and relied
10097 on undefined (wraparound) behavior. The new code avoids undefined
10098 behavior, and also checks for ptrdiff_t and/or size_t overflow.
10099
2e6813b0 10100 * editfns.c (Finsert_char): Don't dump core with very negative counts.
21d890a4
PE
10101 Tune. Don't use wider integers than needed. Don't use alloca.
10102 Use a bigger 'string' buffer. Rewrite to avoid 'n > 0' test.
2e6813b0 10103
599a9e4f
PE
10104 * insdel.c (replace_range): Fix buf overflow when insbytes < outgoing.
10105
99561444
PE
10106 * insdel.c, lisp.h (buffer_overflow): New function.
10107 (insert_from_buffer_1, replace_range, replace_range_2):
10108 * insdel.c (make_gap_larger):
10109 * editfns.c (Finsert_char):
10110 * fileio.c (Finsert_file_contents): Use it, to normalize wording.
10111
28177add
PE
10112 * buffer.h (BUF_BYTES_MAX): Cast to ptrdiff_t so that it's signed.
10113
e69dafad
PE
101142011-06-15 Paul Eggert <eggert@cs.ucla.edu>
10115
4baa020d 10116 Integer overflow and signedness fixes (Bug#8873, Bug#8828).
ff672d2c 10117
b1c46f02
PE
10118 * ccl.c (ASCENDING_ORDER): New macro, to work around GCC bug 43772.
10119 (GET_CCL_RANGE, IN_INT_RANGE): Use it.
10120
e69dafad
PE
10121 * fileio.c: Don't assume EMACS_INT fits in off_t.
10122 (emacs_lseek): New static function.
10123 (Finsert_file_contents, Fwrite_region): Use it.
10124 Use SEEK_SET, SEEK_CUR, SEEK_END as appropriate.
10125
566684ea
PE
10126 * fns.c (Fload_average): Don't assume 100 * load average fits in int.
10127
e6966cd6
PE
10128 * fns.c: Don't overflow int when computing a list length.
10129 * fns.c (QUIT_COUNT_HEURISTIC): New constant.
10130 (Flength, Fsafe_length): Use EMACS_INT, not int, to avoid unwanted
10131 truncation on 64-bit hosts. Check for QUIT every
10132 QUIT_COUNT_HEURISTIC entries rather than every other entry; that's
10133 faster and is responsive enough.
10134 (Flength): Report an error instead of overflowing an integer.
10135 (Fsafe_length): Return a float if the value is not representable
10136 as a fixnum. This shouldn't happen except in contrived situations.
6346d301 10137 (Fnthcdr, Fsort): Don't assume list length fits in int.
de41a810 10138 (Fcopy_sequence): Don't assume vector length fits in int.
00c604f2 10139
dd0b0efb
PE
10140 * alloc.c: Check that resized vectors' lengths fit in fixnums.
10141 (header_size, word_size): New constants.
10142 (allocate_vectorlike): Don't check size overflow here.
10143 (allocate_vector): Check it here instead, since this is the only
10144 caller of allocate_vectorlike that could cause overflow.
10145 Check that the new vector's length is representable as a fixnum.
10146
86fe5cfe
PE
10147 * fns.c (next_almost_prime): Don't return a multiple of 3 or 5.
10148 The previous code was bogus. For example, next_almost_prime (32)
10149 returned 39, which is undesirable as it is a multiple of 3; and
10150 next_almost_prime (24) returned 25, which is a multiple of 5 so
10151 why was the code bothering to check for multiples of 7?
10152
80e88859
PE
10153 * bytecode.c (exec_byte_code): Use ptrdiff_t, not int, for vector length.
10154
4a2f0ad6
PE
10155 * eval.c, doprnt.c (SIZE_MAX): Remove; inttypes.h defines this now.
10156
f66c7cf8
PE
10157 Variadic C functions now count arguments with ptrdiff_t.
10158 This partly undoes my 2011-03-30 change, which replaced int with size_t.
10159 Back then I didn't know that the Emacs coding style prefers signed int.
10160 Also, in the meantime I found a few more instances where arguments
4a2f0ad6
PE
10161 were being counted with int, which may truncate counts on 64-bit
10162 machines, or EMACS_INT, which may be unnecessarily wide.
f66c7cf8
PE
10163 * lisp.h (struct Lisp_Subr.function.aMANY)
10164 (DEFUN_ARGS_MANY, internal_condition_case_n, safe_call):
10165 Arg counts are now ptrdiff_t, not size_t.
10166 All variadic functions and their callers changed accordingly.
10167 (struct gcpro.nvars): Now size_t, not size_t. All uses changed.
10168 * bytecode.c (exec_byte_code): Check maxdepth for overflow,
10169 to avoid potential buffer overrun. Don't assume arg counts fit in 'int'.
10170 * callint.c (Fcall_interactively): Check arg count for overflow,
10171 to avoid potential buffer overrun. Use signed char, not 'int',
10172 for 'varies' array, so that we needn't bother to check its size
10173 calculation for overflow.
10174 * editfns.c (Fformat): Use ptrdiff_t, not EMACS_INT, to count args.
10175 * eval.c (apply_lambda):
10176 * fns.c (Fmapconcat): Use XFASTINT, not XINT, to get args length.
10177 (struct textprop_rec.argnum): Now ptrdiff_t, not int. All uses changed.
10178 (mapconcat): Use ptrdiff_t, not int and EMACS_INT, to count args.
10179
a1759b76
PE
10180 * callint.c (Fcall_interactively): Don't use index var as event count.
10181
d96be9fc
PE
10182 * vm-limit.c (check_memory_limits): Fix incorrect extern function decls.
10183 * mem-limits.h (SIZE): Remove; no longer used.
10184
a690a978 10185 * xterm.c (x_alloc_nearest_color_1): Prefer int to long when int works.
5efd304b 10186
578c21e6
PE
10187 Remove unnecessary casts.
10188 * xterm.c (x_term_init):
10189 * xfns.c (x_set_border_pixel):
10190 * widget.c (create_frame_gcs): Remove casts to unsigned long etc.
10191 These aren't needed now that we assume ANSI C.
10192
96f53c6c
PE
10193 * sound.c (Fplay_sound_internal): Remove cast to unsigned long.
10194 It's more likely to cause problems (due to unsigned overflow)
10195 than to cure them.
10196
83c77d31
PE
10197 * dired.c (Ffile_attributes): Don't use 32-bit hack on 64-bit hosts.
10198
ee2079f1
PE
10199 * unexelf.c (unexec): Don't assume BSS addr fits in unsigned.
10200
6da65536
PE
10201 * xterm.c (handle_one_xevent): Omit unnecessary casts to unsigned.
10202
7147c4a4
PE
10203 * keyboard.c (modify_event_symbol): Don't limit alist len to UINT_MAX.
10204
193e32d9
PE
10205 * lisp.h (CHAR_TABLE_SET): Omit now-redundant test.
10206
e5533da6
PE
10207 * lread.c (Fload): Don't compare a possibly-garbage time_t value.
10208
9910e595
PE
10209 GLYPH_CODE_FACE returns EMACS_INT, not int.
10210 * dispextern.h (merge_faces):
10211 * xfaces.c (merge_faces):
01103c44
PE
10212 * xdisp.c (get_next_display_element, next_element_from_display_vector):
10213 Don't assume EMACS_INT fits in int.
9910e595 10214
2638320e
PE
10215 * character.h (CHAR_VALID_P): Remove unused parameter.
10216 * fontset.c, lisp.h, xdisp.c: All uses changed.
10217
045eb8d9
PE
10218 * editfns.c (Ftranslate_region_internal): Omit redundant test.
10219
c1f134b5
PE
10220 * fns.c (concat): Minor tuning based on overflow analysis.
10221 This doesn't fix any bugs. Use int to hold character, instead
10222 of constantly refetching from Emacs object. Use XFASTINT, not
10223 XINT, for value known to be a character. Don't bother comparing
10224 a single byte to 0400, as it's always less.
10225
395fcb93 10226 * floatfns.c (Fexpt):
327eeec8
PE
10227 * fileio.c (make_temp_name): Omit unnecessary cast to unsigned.
10228
abbd3d23
PE
10229 * editfns.c (Ftranslate_region_internal): Use int, not EMACS_INT
10230 for characters.
10231
684a03ef
PE
10232 * doc.c (get_doc_string): Omit (unsigned)c that mishandled negatives.
10233
0fed43f3
PE
10234 * data.c (Faset): If ARRAY is a string, check that NEWELT is a char.
10235 Without this fix, on a 64-bit host (aset S 0 4294967386) would
10236 incorrectly succeed when S was a string, because 4294967386 was
10237 truncated before it was used.
10238
8fd02eb7
PE
10239 * chartab.c (Fchar_table_range): Use CHARACTERP to check range.
10240 Otherwise, an out-of-range integer could cause undefined behavior
10241 on a 64-bit host.
10242
f8c86b69
PE
10243 * composite.c: Use int, not EMACS_INT, for characters.
10244 (fill_gstring_body, composition_compute_stop_pos): Use int, not
10245 EMACS_INT, for values that are known to be in character range.
10246 This doesn't fix any bugs but is the usual style inside Emacs and
10247 may generate better code on 32-bit machines.
10248
34206dd2
PE
10249 Make sure a 64-bit char is never passed to ENCODE_CHAR.
10250 This is for reasons similar to the recent CHAR_STRING fix.
10251 * charset.c (Fencode_char): Check that character arg is actually
10252 a character. Pass an int to ENCODE_CHAR.
10253 * charset.h (ENCODE_CHAR): Verify that the character argument is no
10254 wider than 'int', as a compile-time check to prevent future regressions
10255 in this area.
10256
c5958d4c 10257 * character.c (char_string): Remove unnecessary casts.
13bdea59
PE
10258
10259 Make sure a 64-bit char is never passed to CHAR_STRING.
10260 Otherwise, CHAR_STRING would do the wrong thing on a 64-bit platform,
10261 by silently ignoring the top 32 bits, allowing some values
10262 that were far too large to be valid characters.
10263 * character.h: Include <verify.h>.
10264 (CHAR_STRING, CHAR_STRING_ADVANCE): Verify that the character
10265 arguments are no wider than unsigned, as a compile-time check
10266 to prevent future regressions in this area.
10267 * data.c (Faset):
01103c44 10268 * editfns.c (Fchar_to_string, general_insert_function, Finsert_char)
13bdea59
PE
10269 (Fsubst_char_in_region):
10270 * fns.c (concat):
10271 * xdisp.c (decode_mode_spec_coding):
10272 Adjust to CHAR_STRING's new requirement.
10273 * editfns.c (Finsert_char, Fsubst_char_in_region):
10274 * fns.c (concat): Check that character args are actually
10275 characters. Without this test, these functions did the wrong
10276 thing with wildly out-of-range values on 64-bit hosts.
10277
d37ca623
PE
10278 Remove incorrect casts to 'unsigned' that lose info on 64-bit hosts.
10279 These casts should not be needed on 32-bit hosts, either.
10280 * keyboard.c (read_char):
10281 * lread.c (Fload): Remove casts to unsigned.
10282
ea204efb
PE
10283 * lisp.h (UNSIGNED_CMP): New macro.
10284 This fixes comparison bugs on 64-bit hosts.
10285 (ASCII_CHAR_P): Use it.
10286 * casefiddle.c (casify_object):
01103c44 10287 * character.h (ASCII_BYTE_P, CHAR_VALID_P)
ea204efb
PE
10288 (SINGLE_BYTE_CHAR_P, CHAR_STRING):
10289 * composite.h (COMPOSITION_ENCODE_RULE_VALID):
10290 * dispextern.h (FACE_FROM_ID):
10291 * keyboard.c (read_char): Use UNSIGNED_CMP.
10292
41cb286c
PE
10293 * xmenu.c (dialog_selection_callback) [!USE_GTK]: Cast to intptr_t,
10294 not to EMACS_INT, to avoid GCC warning.
10295
4a1b9832
PE
10296 * xfns.c (x_set_scroll_bar_default_width): Remove unused 'int' locals.
10297
55daad71
PE
10298 * buffer.h (PTR_BYTE_POS, BUF_PTR_BYTE_POS): Remove harmful cast.
10299 The cast incorrectly truncated 64-bit byte offsets to 32 bits, and
10300 isn't needed on 32-bit machines.
8f95c75c 10301
01103c44
PE
10302 * buffer.c (Fgenerate_new_buffer_name):
10303 Use EMACS_INT for count, not int.
0ceccced 10304 (advance_to_char_boundary): Return EMACS_INT, not int.
e762cafe
PE
10305
10306 * data.c (Qcompiled_function): Now static.
10307
c6f072e7
PE
10308 * window.c (window_body_lines): Now static.
10309
20ce5912
PE
10310 * image.c (gif_load): Rename local to avoid shadowing.
10311
9c4c5f81
PE
10312 * lisp.h (SAFE_ALLOCA_LISP): Check for integer overflow.
10313 (struct Lisp_Save_Value): Use ptrdiff_t, not int, for 'integer' member.
10314 * alloc.c (make_save_value): Integer argument is now of type
10315 ptrdiff_t, not int.
10316 (mark_object): Use ptrdiff_t, not int.
10317 * lisp.h (pD): New macro.
10318 * print.c (print_object): Use it.
10319
c0c5c8ae
PE
10320 * alloc.c: Use EMACS_INT, not int, to count objects.
10321 (total_conses, total_markers, total_symbols, total_vector_size)
10322 (total_free_conses, total_free_markers, total_free_symbols)
01103c44
PE
10323 (total_free_floats, total_floats, total_free_intervals)
10324 (total_intervals, total_strings, total_free_strings):
c0c5c8ae
PE
10325 Now EMACS_INT, not int. All uses changed.
10326 (Fgarbage_collect): Compute overall total using a double, so that
10327 integer overflow is less likely to be a problem. Check for overflow
10328 when converting back to an integer.
5a25e253
PE
10329 (n_interval_blocks, n_string_blocks, n_float_blocks, n_cons_blocks)
10330 (n_vectors, n_symbol_blocks, n_marker_blocks): Remove.
10331 These were 'int' variables that could overflow on 64-bit hosts;
10332 they were never used, so remove them instead of repairing them.
211a0b2a 10333 (nzombies, ngcs, max_live, max_zombies): Now EMACS_INT, not 'int'.
6349ae4d
PE
10334 (inhibit_garbage_collection): Set gc_cons_threshold to max value.
10335 Previously, this ceilinged at INT_MAX, but that doesn't work on
10336 64-bit machines.
e46bb31a 10337 (allocate_pseudovector): Don't use EMACS_INT when int would do.
c0c5c8ae 10338
c78baabf 10339 * alloc.c (Fmake_bool_vector): Don't assume vector size fits in int.
86f61a15 10340 (allocate_vectorlike): Check for ptrdiff_t overflow.
b6439961
PE
10341 (mark_vectorlike, mark_char_table, mark_object): Avoid EMACS_UINT
10342 when a (possibly-narrower) signed value would do just as well.
10343 We prefer using signed arithmetic, to avoid comparison confusion.
c78baabf 10344
c9d624c6
PE
10345 * alloc.c: Catch some string size overflows that we were missing.
10346 (XMALLOC_OVERRUN_CHECK_SIZE) [!XMALLOC_OVERRUN_CHECK]: Define to 0,
10347 for convenience in STRING_BYTES_MAX.
10348 (STRING_BYTES_MAX): New macro, superseding the old one in lisp.h.
10349 The definition here is exact; the one in lisp.h was approximate.
10350 (allocate_string_data): Check for string overflow. This catches
10351 some instances we weren't catching before. Also, it catches
10352 size_t overflow on (unusual) hosts where SIZE_MAX <= min
10353 (PTRDIFF_MAX, MOST_POSITIVE_FIXNUM), e.g., when size_t is 32 bits
10354 and ptrdiff_t and EMACS_INT are both 64 bits.
c78baabf 10355
c9d624c6
PE
10356 * character.c, coding.c, doprnt.c, editfns.c, eval.c:
10357 All uses of STRING_BYTES_MAX replaced by STRING_BYTES_BOUND.
640c8776 10358 * lisp.h (STRING_BYTES_BOUND): Rename from STRING_BYTES_MAX.
c9d624c6 10359
353032ce
PE
10360 * character.c (string_escape_byte8): Fix nbytes/nchars typo.
10361
2bccce07
PE
10362 * alloc.c (Fmake_string): Check for out-of-range init.
10363
0ac30604
SM
103642011-06-15 Stefan Monnier <monnier@iro.umontreal.ca>
10365
10366 * eval.c (Fdefvaralias): Also mark the target as variable-special-p.
10367
c195f2de
JD
103682011-06-14 Jan Djärv <jan.h.d@swipnet.se>
10369
10370 * xfns.c (x_set_scroll_bar_default_width): Remove argument to
10371 xg_get_default_scrollbar_width.
10372
10373 * gtkutil.c: Include emacsgtkfixed.h if HAVE_GTK3.
10374 (int_gtk_range_get_value): Move to the scroll bar part of the file.
10375 (style_changed_cb): Call update_theme_scrollbar_width and call
10376 x_set_scroll_bar_default_width and xg_frame_set_char_size for
10377 all frames (Bug#8505).
10378 (xg_create_frame_widgets): Call emacs_fixed_new if HAVE_GTK3 (Bug#8505).
10379 Call gtk_window_set_resizable if HAVE_GTK3.
10380 (x_wm_set_size_hint): Call emacs_fixed_set_min_size with min width
10381 and height if HAVE_GTK3 (Bug#8505).
10382 (scroll_bar_width_for_theme): New variable.
10383 (update_theme_scrollbar_width): New function.
10384 (xg_get_default_scrollbar_width): Move code to
10385 update_theme_scrollbar_width, just return scroll_bar_width_for_theme.
10386 (xg_initialize): Call update_theme_scrollbar_width.
10387
10388 * gtkutil.h (xg_get_default_scrollbar_width): Remove argument.
10389
10390 * emacsgtkfixed.c, emacsgtkfixed.h: New files.
10391
e10ac9f1
MR
103922011-06-12 Martin Rudalics <rudalics@gmx.at>
10393
10394 * frame.c (make_frame): Call other_buffer_safely instead of
10395 other_buffer.
10396
10397 * window.c (temp_output_buffer_show): Call display_buffer with
10398 second argument Vtemp_buffer_show_specifiers and reset latter
10399 immediately after the call.
10400 (Vtemp_buffer_show_specifiers): New variable.
10401 (auto_window_vscroll_p, next_screen_context_lines)
10402 (Vscroll_preserve_screen_position): Remove leading asterisks from
10403 doc-strings.
10404
2d3c217e 104052011-06-12 Paul Eggert <eggert@cs.ucla.edu>
4475bec4 10406
7b7f97e8 10407 Fix minor problems found by GCC 4.6.0 static checking.
4475bec4
PE
10408 * buffer.c (Qclone_number): Remove for now, as it's unused.
10409 (record_buffer, Funrecord_buffer): Rename local to avoid shadowing.
10410 (record_buffer): Remove unused local.
10411 * frame.c (other_visible_frames, frame_buffer_list): Now static.
10412 (set_frame_buffer_list): Remove; unused.
10413 * frame.h (other_visible_frames): Remove decl.
10414 * keyboard.h (menu_items_inuse): Declare only if USE_GTK || USE_MOTIF.
10415 * lisp.h (frame_buffer_list, set_frame_buffer_list): Remove decls.
10416 (add_gpm_wait_descriptor, delete_gpm_wait_descriptor): Declare only
10417 if HAVE_GPM.
10418 * menu.c (menu_items_inuse): Now static unless USE_GTK || USE_MOTIF.
10419 * process.c (add_gpm_wait_descriptor, delete_gpm_wait_descriptor):
10420 Define only if HAVE_GPM.
10421 * widget.c (EmacsFrameResize, emacsFrameClassRec): Now static.
10422 (update_hints_inhibit): Remove; never set. All uses removed.
10423 * widgetprv.h (emacsFrameClassRec): Remove decl.
10424 * window.c (delete_deletable_window): Now returns void, since it
10425 wasn't returning anything.
10426 (compare_window_configurations): Remove unused locals.
10427 * xfns.c (x_set_scroll_bar_default_width): Remove unused locals.
10428 * xmenu.c (x_menu_set_in_use): Define only if USE_GTK || USE_MOTIF.
4475bec4
PE
10429 (dialog_selection_callback) [!USE_GTK]: Prefer intptr_t for integers
10430 the same widths as pointers. This follows up on the 2011-05-06 patch.
10431 * xterm.c (x_alloc_lighter_color_for_widget): Define only if USE_LUCID.
10432 * xterm.h: Likewise.
10433 (x_menu_set_in_use): Declare only if USE_GTK || USE_MOTIF.
10434
1384b89e
JB
104352011-06-12 Juanma Barranquero <lekktu@gmail.com>
10436
10437 * makefile.w32-in: Update dependencies.
10438 (LISP_H): Add lib/intprops.h.
10439
1100a63c
CY
104402011-06-11 Chong Yidong <cyd@stupidchicken.com>
10441
10442 * image.c (gif_load): Add animation frame delay to the metadata.
10443 (syms_of_image): Use DEFSYM. New symbol `delay'.
10444
6198ccd0
MR
104452011-06-11 Martin Rudalics <rudalics@gmx.at>
10446
10447 * window.c (delete_deletable_window): Re-add.
10448 (Fset_window_configuration): Rewrite to handle dead buffers and
10449 consequently deletable windows.
10450 (window_tree, Fwindow_tree): Remove. Supply functionality in
10451 window.el.
10452 (compare_window_configurations): Simplify code.
10453
b6e3633c
AS
104542011-06-11 Andreas Schwab <schwab@linux-m68k.org>
10455
1ab0dee5
AS
10456 * image.c (imagemagick_load_image): Fix type mismatch.
10457 (Fimagemagick_types): Likewise.
10458
b6e3633c
AS
10459 * window.h (replace_buffer_in_windows): Declare.
10460
9397e56f
MR
104612011-06-11 Martin Rudalics <rudalics@gmx.at>
10462
10463 * buffer.c: New Lisp objects Qbuffer_list_update_hook and
10464 Qclone_number. Remove external declaration of Qdelete_window.
10465 (Fbuffer_list): Rewrite doc-string. Minor restructuring of
10466 code.
640c8776
SM
10467 (Fget_buffer_create, Fmake_indirect_buffer, Frename_buffer):
10468 Run Qbuffer_list_update_hook if allowed.
9397e56f
MR
10469 (Fother_buffer): Rewrite doc-string. Major rewrite for new
10470 buffer list implementation.
10471 (other_buffer_safely): New function.
10472 (Fkill_buffer): Replace call to replace_buffer_in_all_windows by
10473 calls to replace_buffer_in_windows and
10474 replace_buffer_in_windows_safely. Run Qbuffer_list_update_hook
10475 if allowed.
10476 (record_buffer): Inhibit quitting and rewrite using quittable
10477 functions. Run Qbuffer_list_update_hook if allowed.
10478 (Frecord_buffer, Funrecord_buffer): New functions.
640c8776
SM
10479 (switch_to_buffer_1, Fswitch_to_buffer): Remove.
10480 Move switch-to-buffer to window.el.
9397e56f
MR
10481 (bury-buffer): Move to window.el.
10482 (Vbuffer_list_update_hook): New variable.
10483
10484 * lisp.h (other_buffer_safely): Add prototype in buffer.c
10485 section.
10486
10487 * window.h (resize_frame_windows): Move up in code.
10488 (Fwindow_frame): Remove EXFUN.
10489 (replace_buffer_in_all_windows): Remove prototype.
10490 (replace_buffer_in_windows_safely): Add prototype.
10491
10492 * window.c: Declare Qdelete_window static again. Move down
10493 declaration of select_count.
10494 (Fnext_window, Fprevious_window): Rewrite doc-strings.
10495 (Fother_window): Move to window.el.
10496 (window_loop): Remove DELETE_BUFFER_WINDOWS and UNSHOW_BUFFER
10497 cases. Add REPLACE_BUFFER_IN_WINDOWS_SAFELY case.
10498 (Fdelete_windows_on, Freplace_buffer_in_windows): Move to
10499 window.el.
10500 (replace_buffer_in_windows): Implement by calling
10501 Qreplace_buffer_in_windows.
10502 (replace_buffer_in_all_windows): Remove with some functionality
10503 moved into replace_buffer_in_windows_safely.
10504 (replace_buffer_in_windows_safely): New function.
10505 (select_window_norecord, select_frame_norecord): Move in front
10506 of run_window_configuration_change_hook. Remove now obsolete
10507 declarations.
640c8776
SM
10508 (Fset_window_buffer): Rewrite doc-string.
10509 Call Qrecord_window_buffer.
9397e56f
MR
10510 (keys_of_window): Move binding for other-window to window.el.
10511
b50691aa
CY
105122011-06-11 Chong Yidong <cyd@stupidchicken.com>
10513
10514 * dispextern.h (struct image): Replace data member, whose int_val
10515 and ptr_val fields were not used by anything, with a single
10516 lisp_val object.
10517
10518 * image.c (Fimage_metadata, make_image, mark_image, tiff_load)
10519 (gif_clear_image, gif_load, imagemagick_load_image)
10520 (gs_clear_image, gs_load): Callers changed.
10521
3f754b86
PE
105222011-06-10 Paul Eggert <eggert@cs.ucla.edu>
10523
cca69397
PE
10524 * buffer.h: Include <time.h>, for time_t.
10525 Needed to build on FreeBSD 8.2. Problem reported by Herbert J. Skuhra.
10526
109e28d0
PE
10527 Fix minor problems found by static checking.
10528
60737f02
PE
10529 * image.c (PixelGetMagickColor): Declare if ImageMagick headers don't.
10530
4b66faf3
PE
10531 Make identifiers static if they are not used in other modules.
10532 * data.c (Qcompiled_function, Qframe, Qvector):
10533 * image.c (QimageMagick, Qsvg):
10534 * minibuf.c (Qmetadata):
10535 * window.c (resize_window_check, resize_root_window): Now static.
10536 * window.h (resize_window_check, resize_root_window): Remove decls.
10537
109e28d0
PE
10538 * window.c (window_deletion_count, delete_deletable_window):
10539 Remove; unused.
46a4ce9e
PE
10540 (window_body_lines): Now static.
10541 (Fdelete_other_windows_internal): Mark vars as initialized.
10542 Make sure 'resize_failed' is initialized.
10543 (run_window_configuration_change_hook): Rename local to avoid shadowing.
10544 (resize_window_apply): Remove unused local.
10545 * window.h (delete_deletable_window): Remove decl.
10546
109e28d0 10547 * image.c (gif_load, svg_load_image): Rename locals to avoid shadowing.
33290528
PE
10548 (imagemagick_load_image): Fix pointer signedness problem by changing
10549 last arg from unsigned char * to char *. All uses changed.
10550 Also, fix a local for similar reasons.
10551 Remove unused locals. Remove locals to avoid shadowing.
10552 (fn_rsvg_handle_free): Remove; unused.
10553 (svg_load, svg_load_image): Fix pointer signedness problem.
f7e13da3 10554 (imagemagick_load_image): Don't use garbage pointer image_wand.
33290528 10555
3f754b86
PE
10556 * ftfont.c (ftfont_get_metrics, ftfont_drive_otf): Remove unused locals.
10557
2547adb1
CY
105582011-06-10 Chong Yidong <cyd@stupidchicken.com>
10559
10560 * image.c (gif_load): Fix omitted cast error introduced by
10561 2011-06-06 change.
10562
2c8e37d4
MR
105632011-06-10 Martin Rudalics <rudalics@gmx.at>
10564
10565 * window.h (resize_proportionally, orig_total_lines)
10566 (orig_top_line): Remove from window structure.
10567 (set_window_height, set_window_width, change_window_heights)
10568 (Fdelete_window): Remove prototypes.
10569 (resize_frame_windows): Remove duplicate declaration.
10570
440a42e3
EZ
105712011-06-10 Eli Zaretskii <eliz@gnu.org>
10572
10573 * window.h (resize_frame_windows, resize_window_check)
10574 (delete_deletable_window, resize_root_window)
10575 (resize_frame_windows): Declare prototypes.
10576
10577 * window.c (resize_window_apply): Make definition be "static" to
10578 match the prototype.
10579
562dd5e9
MR
105802011-06-10 Martin Rudalics <rudalics@gmx.at>
10581
10582 * window.c: Remove declarations of Qwindow_size_fixed,
10583 window_min_size_1, window_min_size_2, window_min_size,
10584 size_window, window_fixed_size_p, enlarge_window, delete_window.
10585 Remove static from declaration of Qdelete_window, it's
10586 temporarily needed by Fbury_buffer.
10587 (replace_window): Don't assign orig_top_line and
10588 orig_total_lines.
10589 (Fdelete_window, delete_window): Remove. Window deletion is
10590 handled by window.el.
640c8776
SM
10591 (window_loop): Remove DELETE_OTHER_WINDOWS case.
10592 Replace Fdelete_window calls with calls to Qdelete_window.
562dd5e9
MR
10593 (Fdelete_other_windows): Remove. Deleting other windows is
10594 handled by window.el.
10595 (window_fixed_size_p): Remove. Fixed-sizeness of windows is
10596 handled in window.el.
10597 (window_min_size_2, window_min_size_1, window_min_size): Remove.
10598 Window minimum sizes are handled in window.el.
10599 (shrink_windows, size_window, set_window_height)
10600 (set_window_width, change_window_heights, window_height)
10601 (window_width, CURBEG, CURSIZE, enlarge_window)
10602 (adjust_window_trailing_edge, Fadjust_window_trailing_edge)
10603 (Fenlarge_window, Fshrink_window): Remove. Window resizing is
10604 handled in window.el.
10605 (make_dummy_parent): Rename to make_parent_window and give it a
10606 second argument horflag.
10607 (make_window): Don't set resize_proportionally any more.
10608 (Fsplit_window): Remove. Windows are split in window.el.
10609 (save_restore_action, save_restore_orig_size)
10610 (shrink_window_lowest_first, save_restore_orig_size): Remove.
10611 Resize mini windows in window.el.
10612 (grow_mini_window, shrink_mini_window): Implement by calling
10613 Qresize_root_window_vertically, resize_window_check and
10614 resize_window_apply.
640c8776
SM
10615 (saved_window, Fset_window_configuration, save_window_save):
10616 Do not handle orig_top_line, orig_total_lines, and
562dd5e9
MR
10617 resize_proportionally.
10618 (window_min_height, window_min_width): Move to window.el.
10619 (keys_of_window): Move bindings for delete-other-windows,
10620 split-window, delete-window and enlarge-window to window.el.
10621
10622 * buffer.c: Temporarily extern Qdelete_window.
10623 (Fbury_buffer): Temporarily call Qdelete_window instead of
10624 Fdelete_window (Fbury_buffer will move to window.el soon).
10625
10626 * frame.c (set_menu_bar_lines_1): Remove code handling
10627 orig_top_line and orig_total_lines.
10628
10629 * dispnew.c (adjust_frame_glyphs_initially): Don't use
10630 set_window_height but set heights directly.
10631 (change_frame_size_1): Use resize_frame_windows.
10632
10633 * xdisp.c (init_xdisp): Don't use set_window_height but set
10634 heights directly.
10635
640c8776
SM
10636 * xfns.c (x_set_menu_bar_lines, x_set_tool_bar_lines):
10637 Use resize_frame_windows instead of change_window_heights and run
562dd5e9
MR
10638 run_window_configuration_change_hook.
10639
10640 * w32fns.c (x_set_tool_bar_lines): Use resize_frame_windows
10641 instead of change_window_heights and run
10642 run_window_configuration_change_hook.
10643
1a13852e
MR
106442011-06-09 Martin Rudalics <rudalics@gmx.at>
10645
10646 * window.c (replace_window): Rename second argument REPLACEMENT to
10647 NEW. New third argument SETFLAG. Rewrite.
10648 (delete_window, make_dummy_parent): Call replace_window with
10649 third argument 1.
10650 (window_list_1): Move down in code.
10651 (run_window_configuration_change_hook): Move set_buffer part
10652 before select_frame_norecord part in order to unwind correctly.
10653 Rename count1 to count.
10654 (recombine_windows, delete_deletable_window, resize_root_window)
10655 (Fdelete_other_windows_internal)
10656 (Frun_window_configuration_change_hook, make_parent_window)
10657 (resize_window_check, resize_window_apply, Fresize_window_apply)
10658 (resize_frame_windows, Fsplit_window_internal)
640c8776
SM
10659 (Fdelete_window_internal, Fresize_mini_window_internal):
10660 New functions.
1a13852e
MR
10661 (syms_of_window): New variables Vwindow_splits and Vwindow_nest.
10662
f3d1777e
MR
106632011-06-08 Martin Rudalics <rudalics@gmx.at>
10664
496e208e
MR
10665 * window.h (window): Add some new members to window structure -
10666 normal_lines, normal_cols, new_total, new_normal, clone_number,
10667 splits, nest, prev_buffers, next_buffers.
10668 (WINDOW_TOTAL_SIZE): Move here from window.c.
b9e809c2 10669 (MIN_SAFE_WINDOW_WIDTH, MIN_SAFE_WINDOW_HEIGHT): Define here.
496e208e 10670
f3d1777e
MR
10671 * window.c (Fwindow_height, Fwindow_width, Fwindow_full_width_p):
10672 Remove.
496e208e
MR
10673 (make_dummy_parent): Set new members of windows structure.
10674 (make_window): Move down in code. Handle new members of window
10675 structure.
10676 (Fwindow_clone_number, Fwindow_splits, Fset_window_splits)
10677 (Fwindow_nest, Fset_window_nest, Fwindow_new_total)
10678 (Fwindow_normal_size, Fwindow_new_normal, Fwindow_prev_buffers)
10679 (Fset_window_prev_buffers, Fwindow_next_buffers)
640c8776
SM
10680 (Fset_window_next_buffers, Fset_window_clone_number):
10681 New functions.
496e208e
MR
10682 (Fwindow_hscroll, Fwindow_at, Fwindow_point, Fwindow_start)
10683 (Fwindow_end, Fwindow_line_height, Fset_window_dedicated_p):
10684 Doc-string fixes.
10685 (Fwindow_parameters, Fwindow_parameter, Fset_window_parameter):
10686 Argument WINDOW can be now internal window too.
10687 (Fwindow_use_time): Move up in code.
10688 (Fget_buffer_window): Rename argument FRAME to ALL-FRAMES.
10689 Rewrite doc-string.
10690 (Fset_window_configuration, saved_window)
10691 (Fcurrent_window_configuration, save_window_save): Handle new
10692 members of window structure.
b9e809c2
MR
10693 (WINDOW_TOTAL_SIZE, MIN_SAFE_WINDOW_WIDTH)
10694 (MIN_SAFE_WINDOW_HEIGHT): Move to window.h.
10695 (syms_of_window): New Lisp objects Qrecord_window_buffer,
10696 Qwindow_deletable_p, Qdelete_window, Qreplace_buffer_in_windows,
10697 Qget_mru_window, Qresize_root_window,
10698 Qresize_root_window_vertically, Qsafe, Qabove, Qbelow,
10699 Qauto_buffer_name; staticpro them.
f3d1777e 10700
abde8f8c
MR
107012011-06-07 Martin Rudalics <rudalics@gmx.at>
10702
10703 * window.c (Fwindow_total_size, Fwindow_left_column)
10704 (Fwindow_top_line, window_body_lines, Fwindow_body_size)
10705 (Fwindow_list_1): New functions.
10706 (window_box_text_cols): Replace with window_body_cols.
640c8776
SM
10707 (Fwindow_width, Fscroll_left, Fscroll_right):
10708 Use window_body_cols instead of window_box_text_cols.
10709 (delete_window, Fset_window_configuration):
10710 Call delete_all_subwindows with window as argument.
fa8a67e6
MR
10711 (delete_all_subwindows): Take a window as argument and not a
10712 structure. Rewrite.
190b47e6
MR
10713 (window_loop): Remove handling of GET_LRU_WINDOW and
10714 GET_LARGEST_WINDOW.
10715 (Fget_lru_window, Fget_largest_window): Move to window.el.
abde8f8c
MR
10716
10717 * window.h: Extern window_body_cols instead of
fa8a67e6
MR
10718 window_box_text_cols. delete_all_subwindows now takes a
10719 Lisp_Object as argument.
abde8f8c 10720
640c8776
SM
10721 * indent.c (compute_motion, Fcompute_motion):
10722 Use window_body_cols instead of window_box_text_cols.
abde8f8c 10723
fa8a67e6
MR
10724 * frame.c (delete_frame): Call delete_all_subwindows with root
10725 window as argument.
10726
a54e3482
DC
107272011-06-07 Daniel Colascione <dan.colascione@gmail.com>
10728
10729 * fns.c (Fputhash): Document return value.
10730
60002bf5
CY
107312011-06-06 Chong Yidong <cyd@stupidchicken.com>
10732
10733 * image.c (gif_load): Implement gif89a spec "no disposal" method.
10734
0c671da6 107352011-06-06 Paul Eggert <eggert@cs.ucla.edu>
ccd9a01a 10736
b862a52a 10737 Cons<->int and similar integer overflow fixes (Bug#8794).
77984278 10738
be44ca6c
PE
10739 Check for overflow when converting integer to cons and back.
10740 * charset.c (Fdefine_charset_internal, Fdecode_char):
10741 Use cons_to_unsigned to catch overflow.
10742 (Fencode_char): Use INTEGER_TO_CONS.
10743 * composite.h (LGLYPH_CODE): Use cons_to_unsigned.
10744 (LGLYPH_SET_CODE): Use INTEGER_TO_CONS.
10745 * data.c (long_to_cons, cons_to_long): Remove.
10746 (cons_to_unsigned, cons_to_signed): New functions.
10747 These signal an error for invalid or out-of-range values.
10748 * dired.c (Ffile_attributes): Use INTEGER_TO_CONS.
10749 * fileio.c (Fset_visited_file_modtime): Use CONS_TO_INTEGER.
10750 * font.c (Ffont_variation_glyphs):
10751 * fontset.c (Finternal_char_font): Use INTEGER_TO_CONS.
10752 * lisp.h: Include <intprops.h>.
10753 (INTEGER_TO_CONS, CONS_TO_INTEGER): New macros.
10754 (cons_to_signed, cons_to_unsigned): New decls.
10755 (long_to_cons, cons_to_long): Remove decls.
10756 * undo.c (record_first_change): Use INTEGER_TO_CONS.
10757 (Fprimitive_undo): Use CONS_TO_INTEGER.
10758 * xfns.c (Fx_window_property): Likewise.
10759 * xselect.c: Include <limits.h>.
10760 (x_own_selection, selection_data_to_lisp_data):
10761 Use INTEGER_TO_CONS.
10762 (x_handle_selection_request, x_handle_selection_clear)
10763 (x_get_foreign_selection, Fx_disown_selection_internal)
10764 (Fx_get_atom_name, x_send_client_event): Use CONS_TO_INTEGER.
10765 (lisp_data_to_selection_data): Use cons_to_unsigned.
10766 (x_fill_property_data): Use cons_to_signed.
10767 Report values out of range.
10768
d1f3d2af
PE
10769 Check for buffer and string overflow more precisely.
10770 * buffer.h (BUF_BYTES_MAX): New macro.
10771 * lisp.h (STRING_BYTES_MAX): New macro.
10772 * alloc.c (Fmake_string):
10773 * character.c (string_escape_byte8):
10774 * coding.c (coding_alloc_by_realloc):
10775 * doprnt.c (doprnt):
10776 * editfns.c (Fformat):
10777 * eval.c (verror):
10778 Use STRING_BYTES_MAX, not MOST_POSITIVE_FIXNUM,
10779 since they may not be the same number.
10780 * editfns.c (Finsert_char):
10781 * fileio.c (Finsert_file_contents):
10782 Likewise for BUF_BYTES_MAX.
10783
dd52fcea
PE
10784 * image.c: Use ptrdiff_t, not int, for sizes.
10785 (slurp_file): Switch from int to ptrdiff_t.
10786 All uses changed.
10787 (slurp_file): Check that file size fits in both size_t (for
10788 malloc) and ptrdiff_t (for sanity and safety).
10789
7f9bbdbb
PE
10790 * fileio.c (Fverify_visited_file_modtime): Avoid time overflow
10791 if b->modtime has its maximal value.
10792
dfe18f82
PE
10793 * dired.c (Ffile_attributes): Don't assume EMACS_INT has >32 bits.
10794
84acfcf0
PE
10795 Don't assume time_t can fit into int.
10796 * buffer.h (struct buffer.modtime): Now time_t, not int.
10797 * fileio.c (Fvisited_file_modtime): No need for time_t cast now.
10798 * undo.c (Fprimitive_undo): Use time_t, not int, for time_t value.
10799
ccd9a01a
PE
10800 Minor fixes for signed vs unsigned integers.
10801 * character.h (MAYBE_UNIFY_CHAR):
10802 * charset.c (maybe_unify_char):
10803 * keyboard.c (read_char, reorder_modifiers):
10804 XINT -> XFASTINT, since the integer must be nonnegative.
10805 * ftfont.c (ftfont_spec_pattern):
10806 * keymap.c (access_keymap, silly_event_symbol_error):
10807 XUINT -> XFASTINT, since the integer must be nonnegative.
10808 (Fsingle_key_description, preferred_sequence_p): XUINT -> XINT,
10809 since it makes no difference and we prefer signed.
10810 * keyboard.c (record_char): Use XUINT when all the neighbors do.
10811 (access_keymap): NATNUMP -> INTEGERP, since the integer must be
10812 nonnegative.
10813
d6d100dd
SM
108142011-06-06 Stefan Monnier <monnier@iro.umontreal.ca>
10815
10816 * window.h (Fwindow_frame): Declare.
10817
2b6148e4
PE
108182011-06-06 Paul Eggert <eggert@cs.ucla.edu>
10819
10820 * alloc.c: Simplify handling of large-request failures (Bug#8800).
10821 (SPARE_MEMORY): Always define.
10822 (LARGE_REQUEST): Remove.
10823 (memory_full): Use SPARE_MEMORY rather than LARGE_REQUEST.
10824
f230ecc9
MR
108252011-06-06 Martin Rudalics <rudalics@gmx.at>
10826
727e958e
MR
10827 * lisp.h: Move EXFUNS for Fframe_root_window,
10828 Fframe_first_window and Fset_frame_selected_window to window.h.
10829
10830 * window.h: Move EXFUNS for Fframe_root_window,
10831 Fframe_first_window and Fset_frame_selected_window here from
10832 lisp.h.
10833
10834 * frame.c (Fwindow_frame, Fframe_first_window)
10835 (Fframe_root_window, Fframe_selected_window)
10836 (Fset_frame_selected_window): Move to window.c.
10837 (Factive_minibuffer_window): Move to minibuf.c.
10838 (Fother_visible_frames_p): New function.
10839
10840 * minibuf.c (Factive_minibuffer_window): Move here from frame.c.
10841
f230ecc9
MR
10842 * window.c (decode_window, decode_any_window): Move up in code.
10843 (Fwindowp, Fwindow_live_p): Rewrite doc-strings.
10844 (inhibit_frame_unsplittable): Remove unused variable.
bf60a96b
MR
10845 (Fwindow_buffer): Move up and rewrite doc-string.
10846 (Fwindow_parent, Fwindow_vchild, Fwindow_hchild, Fwindow_next)
10847 (Fwindow_prev): New functions.
727e958e
MR
10848 (Fwindow_frame): Move here from frame.c. Accept any window as
10849 argument.
10850 (Fframe_root_window, Fframe_first_window)
10851 (Fframe_selected_window): Move here from frame.c. Accept frame
10852 or arbitrary window as argument. Update doc-strings.
10853 (Fminibuffer_window): Move up in code.
10854 (Fwindow_minibuffer_p): Move up in code and simplify.
d6d100dd
SM
10855 (Fset_frame_selected_window): Move here from frame.c.
10856 Marginal rewrite.
727e958e
MR
10857 (Fselected_window, select_window, Fselect_window): Move up in
10858 code. Minor doc-string fixes.
f230ecc9 10859
4d09bcf6
PE
108602011-06-06 Paul Eggert <eggert@cs.ucla.edu>
10861
10862 * alloc.c (memory_full) [SYSTEM_MALLOC]: Port to MacOS (Bug#8800).
10863 Do not assume that spare memory exists; that assumption is valid
10864 only if SYSTEM_MALLOC.
10865 (LARGE_REQUEST): New macro, so that the issue of large requests
10866 is separated from the issue of spare memory.
10867
810928a2
AS
108682011-06-05 Andreas Schwab <schwab@linux-m68k.org>
10869
172418ad
AS
10870 * editfns.c (Fformat): Correctly handle zero flag with hexadecimal
10871 format. (Bug#8806)
10872
43f862f7
AS
10873 * gtkutil.c (xg_get_default_scrollbar_width): Avoid warning.
10874
810928a2
AS
10875 * xfns.c (x_set_scroll_bar_default_width): Move declarations
10876 before statements.
10877
a059fe24
JD
108782011-06-05 Jan Djärv <jan.h.d@swipnet.se>
10879
10880 * gtkutil.c (xg_get_default_scrollbar_width): New function.
10881
10882 * gtkutil.h: Declare xg_get_default_scrollbar_width.
10883
10884 * xfns.c (x_set_scroll_bar_default_width): If USE_GTK, get
10885 min width by calling x_set_scroll_bar_default_width (Bug#8505).
10886
989bf368
JB
108872011-06-05 Juanma Barranquero <lekktu@gmail.com>
10888
10889 * xdisp.c (single_display_spec_intangible_p): Remove declaration.
10890
4b80f674
CY
108912011-06-04 Chong Yidong <cyd@stupidchicken.com>
10892
10893 * xselect.c (x_clipboard_manager_save): Remove redundant arg.
10894 (x_clipboard_manager_save): Add return value.
d6d100dd
SM
10895 (x_clipboard_manager_error_1, x_clipboard_manager_error_2):
10896 New error handlers.
4b80f674
CY
10897 (x_clipboard_manager_save_frame, x_clipboard_manager_save_all):
10898 Obey Vx_select_enable_clipboard_manager. Catch errors in
10899 x_clipboard_manager_save (Bug#8779).
10900 (Vx_select_enable_clipboard_manager): New variable.
de65b42c 10901 (x_get_foreign_selection): Reduce scope of x_catch_errors (Bug#8790).
4b80f674 10902
99a33b77 109032011-06-04 Dan Nicolaescu <dann@ics.uci.edu>
8b3115e7
DN
10904
10905 * emacs.c (main): Warn when starting a GTK emacs in daemon mode.
10906
99a33b77 109072011-06-04 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
14eca62f
YM
10908
10909 * fringe.c (update_window_fringes): Don't update overlay arrow bitmap
10910 in the current matrix if keep_current_p is non-zero.
10911
8264569d
EZ
109122011-06-04 Eli Zaretskii <eliz@gnu.org>
10913
10914 * bidi.c (bidi_level_of_next_char): Fix last change.
10915
57f97249
EZ
109162011-06-03 Eli Zaretskii <eliz@gnu.org>
10917
fec2107c 10918 Support bidi reordering of text covered by display properties.
57f97249 10919
fec2107c
EZ
10920 * bidi.c (bidi_copy_it): Use offsetof instead of emulating it.
10921 (bidi_fetch_char, bidi_fetch_char_advance): New functions.
10922 (bidi_cache_search, bidi_cache_iterator_state)
10923 (bidi_paragraph_init, bidi_resolve_explicit, bidi_resolve_weak)
d6d100dd
SM
10924 (bidi_level_of_next_char, bidi_move_to_visually_next):
10925 Support character positions inside a run of characters covered by a
fec2107c
EZ
10926 display string.
10927 (bidi_paragraph_init, bidi_resolve_explicit_1)
10928 (bidi_level_of_next_char): Call bidi_fetch_char and
10929 bidi_fetch_char_advance instead of FETCH_CHAR and
10930 FETCH_CHAR_ADVANCE.
10931 (bidi_init_it): Initialize new members.
10932 (LRE_CHAR, RLE_CHAR, PDF_CHAR, LRO_CHAR, RLO_CHAR): Remove macro
10933 definitions.
10934 (bidi_explicit_dir_char): Lookup character type in bidi_type_table,
10935 instead of using explicit *_CHAR codes.
d6d100dd
SM
10936 (bidi_resolve_explicit, bidi_resolve_weak):
10937 Use FETCH_MULTIBYTE_CHAR instead of FETCH_CHAR, as reordering of
fec2107c
EZ
10938 bidirectional text is supported only in multibyte buffers.
10939 (bidi_init_it): Accept additional argument FRAME_WINDOW_P and use
10940 it to initialize the frame_window_p member of struct bidi_it.
10941 (bidi_cache_iterator_state, bidi_resolve_explicit_1)
10942 (bidi_resolve_explicit, bidi_resolve_weak)
10943 (bidi_level_of_next_char, bidi_move_to_visually_next): Abort if
10944 bidi_it->nchars is non-positive.
10945 (bidi_level_of_next_char): Don't try to lookup the cache for the
10946 next/previous character if nothing is cached there yet, or if we
10947 were just reseat()'ed to a new position.
c40e2fb2 10948
0e14fe90
EZ
10949 * xdisp.c (set_cursor_from_row): Set start and stop points
10950 according to the row's direction when priming the loop that looks
10951 for the glyph on which to display cursor.
10952 (single_display_spec_intangible_p): Function deleted.
10953 (display_prop_intangible_p): Reimplement to call
10954 handle_display_spec instead of single_display_spec_intangible_p.
d6d100dd
SM
10955 Accept 3 additional arguments needed by handle_display_spec.
10956 This fixes incorrect cursor motion across display property with complex
0e14fe90
EZ
10957 values: lists, `(when COND...)' forms, etc.
10958 (single_display_spec_string_p): Support property values that are
10959 lists with the argument STRING its top-level element.
10960 (display_prop_string_p): Fix the condition for processing a
10961 property that is a list to be consistent with handle_display_spec.
fec2107c 10962 (handle_display_spec): New function, refactored from the
fc6f18ce
EZ
10963 last portion of handle_display_prop.
10964 (compute_display_string_pos): Accept additional argument
10965 FRAME_WINDOW_P. Call handle_display_spec to determine whether the
10966 value of a `display' property is a "replacing spec".
10967 (handle_single_display_spec): Accept 2 additional arguments BUFPOS
10968 and FRAME_WINDOW_P. If IT is NULL, don't set up the iterator from
10969 the display property, but just return a value indicating whether
10970 the display property will replace the characters it covers.
10971 (Fcurrent_bidi_paragraph_direction): Initialize the nchars and
10972 frame_window_p members of struct bidi_it.
d6d100dd
SM
10973 (compute_display_string_pos, compute_display_string_end):
10974 New functions.
fec2107c
EZ
10975 (push_it): Accept second argument POSITION, where pop_it should
10976 jump to continue iteration.
10977 (reseat_1): Initialize bidi_it.disp_pos.
fc6f18ce 10978
fec2107c
EZ
10979 * keyboard.c (adjust_point_for_property): Adjust the call to
10980 display_prop_intangible_p to its new signature.
fc6f18ce
EZ
10981
10982 * dispextern.h (struct bidi_it): New member frame_window_p.
fec2107c
EZ
10983 (bidi_init_it): Update prototypes.
10984 (display_prop_intangible_p): Update prototype.
d6d100dd
SM
10985 (compute_display_string_pos, compute_display_string_end):
10986 Declare prototypes.
fec2107c
EZ
10987 (struct bidi_it): New members nchars and disp_pos. ch_len is now
10988 EMACS_INT.
fc6f18ce 10989
40087514 109902011-06-02 Paul Eggert <eggert@cs.ucla.edu>
0de4bb68 10991
57f53182
PE
10992 Malloc failure behavior now depends on size of allocation.
10993 * alloc.c (buffer_memory_full, memory_full): New arg NBYTES.
10994 * lisp.h: Change signatures accordingly.
10995 * alloc.c, buffer.c, editfns.c, menu.c, minibuf.c, xterm.c:
10996 All callers changed. (Bug#8762)
10997
10998 * gnutls.c: Use Emacs's memory allocators.
10999 Without this change, the gnutls library would invoke malloc etc.
11000 directly, which causes problems on non-SYNC_INPUT hosts, and which
11001 runs afoul of improving memory_full behavior. (Bug#8761)
11002 (fn_gnutls_global_set_mem_functions): New macro or function pointer.
11003 (emacs_gnutls_global_init): Use it to specify xmalloc, xrealloc,
11004 xfree instead of the default malloc, realloc, free.
11005 (Fgnutls_boot): No need to check for memory allocation failure,
11006 since xmalloc does that for us.
11007
ac32cd99 11008 Remove arbitrary limit of 2**31 entries in hash tables. (Bug#8771)
3870d916
PE
11009 * category.c (hash_get_category_set):
11010 * ccl.c (ccl_driver):
11011 * charset.c (Fdefine_charset_internal):
11012 * charset.h (struct charset.hash_index):
11013 * composite.c (get_composition_id, gstring_lookup_cache)
11014 (composition_gstring_put_cache):
11015 * composite.h (struct composition.hash_index):
11016 * dispextern.h (struct image.hash):
11017 * fns.c (next_almost_prime, larger_vector, cmpfn_eql)
11018 (cmpfn_equal, cmpfn_user_defined, hashfn_eq, hashfn_eql)
11019 (hashfn_equal, hashfn_user_defined, make_hash_table)
11020 (maybe_resize_hash_table, hash_lookup, hash_put)
11021 (hash_remove_from_table, hash_clear, sweep_weak_table, SXHASH_COMBINE)
11022 (sxhash_string, sxhash_list, sxhash_vector, sxhash_bool_vector)
11023 (Fsxhash, Fgethash, Fputhash, Fmaphash):
11024 * image.c (make_image, search_image_cache, lookup_image)
11025 (xpm_put_color_table_h):
11026 * lisp.h (struct Lisp_Hash_Table):
0de4bb68 11027 * minibuf.c (Ftry_completion, Fall_completions, Ftest_completion):
ac389d0c 11028 * print.c (print): Use 'EMACS_UINT' and 'EMACS_INT'
3870d916 11029 for hashes and hash indexes, instead of 'unsigned' and 'int'.
40087514
PE
11030 * alloc.c (allocate_vectorlike):
11031 Check for overflow in vector size calculations.
11032 * ccl.c (ccl_driver):
11033 Check for overflow when converting EMACS_INT to int.
0de4bb68
PE
11034 * fns.c, image.c: Remove unnecessary static decls that would otherwise
11035 need to be updated by these changes.
40087514
PE
11036 * fns.c (make_hash_table, maybe_resize_hash_table):
11037 Check for integer overflow with large hash tables.
0de4bb68
PE
11038 (make_hash_table, maybe_resize_hash_table, Fmake_hash_table):
11039 Prefer the faster XFLOAT_DATA to XFLOATINT where either will do.
11040 (SXHASH_REDUCE): New macro.
11041 (sxhash_string, sxhash_list, sxhash_vector, sxhash_bool_vector):
11042 Use it instead of discarding useful hash info with large hash values.
11043 (sxhash_float): New function.
11044 (sxhash): Use it. No more need for "& INTMASK" due to above changes.
11045 * lisp.h (FIXNUM_BITS): New macro, useful for SXHASH_REDUCE etc.
40087514
PE
11046 (MOST_NEGATIVE_FIXNUM, MOST_POSITIVE_FIXNUM, INTMASK):
11047 Rewrite to use FIXNUM_BITS, as this simplifies things.
0de4bb68
PE
11048 (next_almost_prime, larger_vector, sxhash, hash_lookup, hash_put):
11049 Adjust signatures to match updated version of code.
11050 (consing_since_gc): Now EMACS_INT, since a single hash table can
11051 use more than INT_MAX bytes.
11052
698d32e2
DN
110532011-06-01 Dan Nicolaescu <dann@ics.uci.edu>
11054
11055 Make it possible to build with GCC-4.6+ -O2 -flto.
11056
11057 * emacs.c (__malloc_initialize_hook): Mark as EXTERNALLY_VISIBLE.
11058
fd6fa53f
SM
110592011-06-01 Stefan Monnier <monnier@iro.umontreal.ca>
11060
11061 * minibuf.c (get_minibuffer, read_minibuf_unwind):
11062 Call minibuffer-inactive-mode.
11063
864db017
JB
110642011-05-31 Juanma Barranquero <lekktu@gmail.com>
11065
11066 * makefile.w32-in ($(BLD)/data.$(O), $(BLD)/editfns.$(O)):
11067 Update dependencies.
11068
2ad0baf4
DN
110692011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
11070
11071 * data.c (init_data): Remove code for UTS, this system is not
11072 supported anymore.
11073
4fcc2638
DN
110742011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
11075
11076 Don't force ./temacs to start in terminal mode.
11077
11078 * frame.c (make_initial_frame): Initialize faces in all cases, not
11079 only when CANNOT_DUMP is defined.
11080 * dispnew.c (init_display): Remove CANNOT_DUMP condition.
11081
c56e0fd5
DN
110822011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
11083
11084 * dispnew.c (add_window_display_history): Use const for the string
11085 pointer. Remove declaration, not needed.
11086
333d54da 110872011-05-31 Paul Eggert <eggert@cs.ucla.edu>
9cf9f756 11088
55d4c1b2 11089 Use 'inline', not 'INLINE'.
333d54da 11090 <http://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00914.html>
55d4c1b2
PE
11091 * alloc.c, fontset.c (INLINE): Remove.
11092 * alloc.c, bidi.c, charset.c, coding.c, dispnew.c, fns.c, image.c:
11093 * intervals.c, keyboard.c, process.c, syntax.c, textprop.c, w32term.c:
11094 * xdisp.c, xfaces.c, xterm.c: Replace all uses of INLINE with inline.
11095 * gmalloc.c (register_heapinfo): Use inline unconditionally.
11096 * lisp.h (LISP_MAKE_RVALUE): Use inline, not __inline__.
11097
738db178
DN
110982011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
11099
11100 Make it possible to run ./temacs.
11101
11102 * callproc.c (set_initial_environment): Remove CANNOT_DUMP code,
11103 syms_of_callproc does the same thing. Remove test for
11104 "initialized", do it in the caller.
11105 * emacs.c (main): Avoid calling set_initial_environment when dumping.
11106
620c53a6
SM
111072011-05-31 Stefan Monnier <monnier@iro.umontreal.ca>
11108
11109 * minibuf.c (Finternal_complete_buffer): Return `category' metadata.
11110 (read_minibuf): Use get_minibuffer.
11111 (syms_of_minibuf): Use DEFSYM.
11112 (Qmetadata): New var.
11113 * data.c (Qbuffer): Don't make it static.
11114 (syms_of_data): Use DEFSYM.
11115
e003a292
PE
111162011-05-31 Paul Eggert <eggert@cs.ucla.edu>
11117
11118 * ccl.c (CCL_CODE_RANGE): Allow negative numbers. (Bug#8751)
11119 (CCL_CODE_MIN): New macro.
11120
ed008a6d
PE
111212011-05-30 Paul Eggert <eggert@cs.ucla.edu>
11122
3687c2ef
PE
11123 * alloc.c (lisp_align_malloc): Omit unnecessary val==NULL tests.
11124
ed008a6d
PE
11125 * eval.c (Qdebug): Now static.
11126 * lisp.h (Qdebug): Remove decl. This reverts a part of the
11127 2011-04-26T11:26:05Z!dan.colascione@gmail.com that inadvertently undid part of
11128 2011-04-14T06:48:41Z!eggert@cs.ucla.edu.
11129
d66c4c7c
CY
111302011-05-29 Chong Yidong <cyd@stupidchicken.com>
11131
11132 * image.c: Various fixes to ImageMagick code comments.
11133 (Fimagemagick_types): Doc fix.
11134
5fbc2025
PE
111352011-05-29 Paul Eggert <eggert@cs.ucla.edu>
11136
0196f88a
PE
11137 Minor fixes prompted by GCC 4.6.0 warnings.
11138
11139 * xselect.c (converted_selections, conversion_fail_tag): Now static.
11140
5fbc2025
PE
11141 * emacs.c [HAVE_X_WINDOWS]: Include "xterm.h".
11142 (x_clipboard_manager_save_all): Move extern decl to ...
11143 * xterm.h: ... here, so that it can be checked for consistency.
11144
1dd3c2d9
CY
111452011-05-29 Chong Yidong <cyd@stupidchicken.com>
11146
11147 * xselect.c (x_clipboard_manager_save_frame)
11148 (x_clipboard_manager_save_all): New functions.
11149 (Fx_clipboard_manager_save): Lisp function deleted.
11150
11151 * emacs.c (Fkill_emacs): Call x_clipboard_manager_save_all.
11152 * frame.c (delete_frame): Call x_clipboard_manager_save_frame.
11153
11154 * xterm.h: Update prototype.
11155
5ba6571d
WX
111562011-05-28 William Xu <william.xwl@gmail.com>
11157
11158 * nsterm.m (ns_term_shutdown): Synchronize user defaults before
11159 exiting (Bug#8239).
11160
3eaff834
JM
111612011-05-28 Jim Meyering <meyering@redhat.com>
11162
e1900994 11163 Avoid a sign-extension bug in crypto_hash_function.
3eaff834
JM
11164 * fns.c (to_uchar): Define.
11165 (crypto_hash_function): Use it to convert some newly-signed
11166 variables to unsigned, to avoid sign-extension bugs. For example,
11167 without this change, (md5 "truc") would evaluate to
11168 45723a2aff78ff4fff7fff1114760e62 rather than the expected
11169 45723a2af3788c4ff17f8d1114760e62. Reported by Antoine Levitt in
e1900994 11170 https://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00883.html.
3eaff834 11171
0f6990a7
PE
111722011-05-27 Paul Eggert <eggert@cs.ucla.edu>
11173
11174 Integer overflow fixes.
c8a9ca5a 11175
08686060
PE
11176 * dbusbind.c: Serial number integer overflow fixes.
11177 (CHECK_DBUS_SERIAL_GET_SERIAL): New macro.
08686060
PE
11178 (Fdbus_call_method_asynchronously, xd_read_message_1): Use a float
11179 to hold a serial number that is too large for a fixnum.
11180 (Fdbus_method_return_internal, Fdbus_method_error_internal):
11181 Check for serial numbers out of range. Decode any serial number
59568bf0 11182 that was so large that it became a float. (Bug#8722)
08686060 11183
2d1fc3c7
PE
11184 * dbusbind.c: Use XFASTINT rather than XUINT, and check for nonneg.
11185 (Fdbus_call_method, Fdbus_call_method_asynchronously):
11186 Use XFASTINT rather than XUINT when numbers are nonnegative.
11187 (xd_append_arg, Fdbus_method_return_internal):
11188 (Fdbus_method_error_internal): Likewise. Also, for unsigned
11189 arguments, check that Lisp number is nonnegative, rather than
59568bf0 11190 silently wrapping negative numbers around. (Bug#8722)
30217ff0 11191 (xd_read_message_1): Don't assume dbus_uint32_t can fit in int.
59568bf0 11192 (Bug#8722)
2d1fc3c7 11193
c8a9ca5a
PE
11194 * data.c (arith_driver, Flsh): Avoid unnecessary casts to EMACS_UINT.
11195
519e1d69
PE
11196 * ccl.c (ccl_driver): Redo slightly to avoid the need for 'unsigned'.
11197
6df6ae42 11198 ccl: Add integer overflow checks.
30569699
PE
11199 * ccl.c (CCL_CODE_MAX, GET_CCL_RANGE, GET_CCL_CODE, GET_CCL_INT):
11200 (IN_INT_RANGE): New macros.
11201 (ccl_driver): Use them to check for integer overflow when
11202 decoding a CCL program. Many of the new checks are whether XINT (x)
11203 fits in int; it doesn't always, on 64-bit hosts. The new version
11204 doesn't catch all possible integer overflows, but it's an
847044ea 11205 improvement. (Bug#8719)
30569699 11206
c11285dc
PE
11207 * alloc.c (make_event_array): Use XINT, not XUINT.
11208 There's no need for unsigned here.
11209
fdccd48e
PE
11210 * mem-limits.h (EXCEEDS_LISP_PTR) [!USE_LSB_TAG]: EMACS_UINT -> uintptr_t
11211 This follows up to the 2011-05-06 change that substituted uintptr_t
11212 for EMACS_INT. This case wasn't caught back then.
11213
37910ab2
PE
11214 Rework Fformat to avoid integer overflow issues.
11215 * editfns.c: Include <float.h> unconditionally, as it's everywhere
11216 now (part of C89). Include <verify.h>.
11217 (MAX_10_EXP, CONVERTED_BYTE_SIZE): Remove; no longer needed.
11218 (pWIDE, pWIDElen, signed_wide, unsigned_wide): New defns.
11219 (Fformat): Avoid the prepass trying to compute sizes; it was only
11220 approximate and thus did not catch overflow reliably. Instead, walk
11221 through the format just once, formatting and computing sizes as we go,
11222 checking for integer overflow at every step, and allocating a larger
11223 buffer as needed. Keep track separately whether the format is
11224 multibyte. Keep only the most-recently calculated precision, rather
11225 than them all. Record whether each argument has been converted to
11226 string. Use EMACS_INT, not int, for byte and char and arg counts.
11227 Support field widths and precisions larger than INT_MAX. Avoid
11228 sprintf's undefined behavior with conversion specifications such as %#d
11229 and %.0c. Fix bug with strchr succeeding on '\0' when looking for
11230 flags. Fix bug with (format "%c" 256.0). Avoid integer overflow when
11231 formatting out-of-range floating point numbers with int
9173deec 11232 formats. (Bug#8668)
37910ab2 11233
2e6578fb
PE
11234 * lisp.h (FIXNUM_OVERFLOW_P): Work even if arg is a NaN.
11235
0ae6bdee
PE
11236 * data.c: Avoid integer truncation in expressions involving floats.
11237 * data.c: Include <intprops.h>.
11238 (arith_driver): When there's an integer overflow in an expression
11239 involving floating point, convert the integers to floating point
11240 so that the resulting value does not suffer from catastrophic
11241 integer truncation. For example, on a 64-bit host (* 4
11242 most-negative-fixnum 0.5) should yield about -4.6e+18, not zero.
11243 Do not rely on undefined behavior after integer overflow.
11244
de883a70
PE
11245 merge count_size_as_multibyte, parse_str_to_multibyte
11246 * character.c, character.h (count_size_as_multibyte):
fd6fa53f 11247 Rename from parse_str_to_multibyte; all uses changed.
de883a70
PE
11248 Check for integer overflow.
11249 * insdel.c, lisp.h (count_size_as_multibyte): Remove,
11250 since it's now a duplicate of the other. This is more of
11251 a character than a buffer op, so better that it's in character.c.
11252 * fns.c, print.c: Adjust to above changes.
11253
2ff916cb
PE
112542011-05-27 Stefan Monnier <monnier@iro.umontreal.ca>
11255
11256 * xselect.c (x_convert_selection): Yet another int/Lisp_Object mixup.
11257
f1b54466
PE
112582011-05-27 Paul Eggert <eggert@cs.ucla.edu>
11259
fb1ac845
PE
11260 * xselect.c: Fix minor problems prompted by GCC 4.6.0 warnings.
11261 (x_handle_selection_request, frame_for_x_selection): Remove unused vars.
11262 (x_clipboard_manager_save): Now static.
11263 (Fx_clipboard_manager_save): Rename local to avoid shadowing.
11264
f1b54466
PE
11265 * fns.c: Fix minor problems prompted by GCC 4.6.0 warnings.
11266 (crypto_hash_function): Now static.
11267 Fix pointer signedness problems. Avoid unnecessary initializations.
11268
a9f737ee
CY
112692011-05-27 Chong Yidong <cyd@stupidchicken.com>
11270
11271 * termhooks.h (Vselection_alist): Make it terminal-local.
11272
11273 * terminal.c (create_terminal): Initialize it.
11274
11275 * xselect.c: Support for clipboard managers.
11276 (Vselection_alist): Move to termhooks.h as terminal-local var.
11277 (LOCAL_SELECTION): New macro.
11278 (x_atom_to_symbol): Handle x_display_info_for_display fail case.
11279 (symbol_to_x_atom): Remove gratuitous arg.
11280 (x_handle_selection_request, lisp_data_to_selection_data)
11281 (x_get_foreign_selection, Fx_register_dnd_atom): Callers changed.
620c53a6
SM
11282 (x_own_selection, x_get_local_selection, x_convert_selection):
11283 New arg, specifying work frame. Use terminal-local Vselection_alist.
a9f737ee
CY
11284 (some_frame_on_display): Delete unused function.
11285 (Fx_own_selection_internal, Fx_get_selection_internal)
11286 (Fx_disown_selection_internal, Fx_selection_owner_p)
11287 (Fx_selection_exists_p): New optional frame arg.
11288 (frame_for_x_selection, Fx_clipboard_manager_save): New functions.
11289 (x_handle_selection_clear): Don't treat other terminals with the
11290 same keyboard specially. Use the terminal-local Vselection_alist.
11291 (x_clear_frame_selections): Use Frun_hook_with_args.
11292
11293 * xterm.c (x_term_init): Intern ATOM and CLIPBOARD_MANAGER atoms.
11294
11295 * xterm.h: Add support for those atoms.
11296
e067f0c1
CY
112972011-05-26 Chong Yidong <cyd@stupidchicken.com>
11298
11299 * xselect.c: ICCCM-compliant handling of MULTIPLE targets.
11300 (converted_selections, conversion_fail_tag): New global variables.
11301 (x_selection_request_lisp_error): Free the above.
11302 (x_get_local_selection): Remove unnecessary code.
11303 (x_reply_selection_request): Args changed; handle arbitrary array
620c53a6
SM
11304 of converted selections stored in converted_selections.
11305 Separate the XChangeProperty and SelectionNotify steps.
e067f0c1
CY
11306 (x_handle_selection_request): Rewrite to handle MULTIPLE target.
11307 (x_convert_selection): New function.
11308 (x_handle_selection_event): Simplify.
11309 (x_get_foreign_selection): Don't ignore incoming requests while
11310 waiting for an answer; this will fail when we implement
11311 SAVE_TARGETS, and seems unnecessary anyway.
11312 (selection_data_to_lisp_data): Recognize ATOM_PAIR type.
11313 (Vx_sent_selection_functions): Doc fix.
11314
0f4aebc0
LL
113152011-05-26 Leo Liu <sdl.web@gmail.com>
11316
11317 * editfns.c (Ftranspose_regions): Allow empty regions. (Bug#8699)
11318
e61124cd
YM
113192011-05-25 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
11320
11321 * dispextern.h (struct glyph_row): New member fringe_bitmap_periodic_p.
11322
11323 * dispnew.c (shift_glyph_matrix, scrolling_window): Mark scrolled row
11324 for fringe update if it has periodic bitmap.
ac389d0c 11325 (row_equal_p): Also compare left_fringe_offset, right_fringe_offset,
e61124cd
YM
11326 and fringe_bitmap_periodic_p.
11327
11328 * fringe.c (get_fringe_bitmap_data): New function.
11329 (draw_fringe_bitmap_1, update_window_fringes): Use it.
11330 (update_window_fringes): Record periodicity of fringe bitmap in glyph
11331 row. Mark glyph row for fringe update if periodicity changed.
11332
11333 * xdisp.c (try_window_reusing_current_matrix): Don't mark scrolled row
11334 for fringe update unless it has periodic bitmap.
11335
f16d9837
KH
113362011-05-25 Kenichi Handa <handa@m17n.org>
11337
11338 * xdisp.c (get_next_display_element): Set correct it->face_id for
11339 a static composition.
11340
e1b90ef6
LL
113412011-05-24 Leo Liu <sdl.web@gmail.com>
11342
11343 * deps.mk (fns.o):
11344 * makefile.w32-in ($(BLD)/fns.$(O)): Include sha1.h.
11345
11346 * fns.c (crypto_hash_function, Fsha1): New function.
11347 (Fmd5): Use crypto_hash_function.
11348 (syms_of_fns): Add Ssha1.
11349
7400048f
PE
113502011-05-22 Paul Eggert <eggert@cs.ucla.edu>
11351
11352 * gnutls.c: Remove unused macros.
11353 (fn_gnutls_transport_set_lowat, fn_gnutls_transport_set_pull_function):
11354 (fn_gnutls_transport_set_push_function) [!WINDOWSNT]:
11355 Remove macros that are defined and never used.
11356 Caught by gcc -Wunused-macros (GCC 4.6.0, Fedora 14).
11357
abb71cf4
CY
113582011-05-22 Chong Yidong <cyd@stupidchicken.com>
11359
11360 * xselect.c (syms_of_xselect): Remove unused symbol SAVE_TARGETS.
11361 (Fx_get_selection_internal): Minor cleanup.
11362 (Fx_own_selection_internal): Rename arguments for consistency with
11363 select.el.
11364
6307db39
PE
113652011-05-22 Paul Eggert <eggert@cs.ucla.edu>
11366
11367 * xselect.c (QSAVE_TARGETS): New static var, to fix build failure.
11368
f3d4e0a4
CY
113692011-05-22 Chong Yidong <cyd@stupidchicken.com>
11370
11371 * xselect.c (syms_of_xselect): Include character.h; use DEFSYM.
11372
4d8ade89
YM
113732011-05-21 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
11374
11375 * dispnew.c (scrolling_window): Don't exclude the case that the
11376 last enabled row in the desired matrix touches the bottom boundary.
11377
32078c8d
GM
113782011-05-21 Glenn Morris <rgm@gnu.org>
11379
11380 * Makefile.in ($(etc)/DOC): Make second command line even shorter.
33cf345f
GM
11381 (SOME_MACHINE_OBJECTS): Replace FONT_OBJ by its maximal expansion,
11382 and add some more files.
32078c8d 11383
7285dc67
EZ
113842011-05-20 Eli Zaretskii <eliz@gnu.org>
11385
11386 * callproc.c (Fcall_process) [MSDOS]: Fix arguments to
11387 report_file_error introduced by the change from 2011-05-07.
11388
89d1bd22
PE
113892011-05-20 Paul Eggert <eggert@cs.ucla.edu>
11390
11391 * systime.h (Time): Define only if emacs is defined.
11392 This is to allow ../lib-src/profile.c to be compiled on FreeBSD,
11393 where the include path doesn't have X11/X.h by default. See
11394 <http://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00561.html>.
11395
cd394be1 113962011-05-20 Kenichi Handa <handa@m17n.org>
31bfc35c
KH
11397
11398 * composite.c (find_automatic_composition): Fix previous change.
11399
b9704ad9
GM
114002011-05-20 Glenn Morris <rgm@gnu.org>
11401
11402 * lisp.mk: New file, split from Makefile.in.
11403 * Makefile.in (lisp): Move to separate file, inserted by @lisp_frag@.
11404 (shortlisp): Remove.
11405 ($(etc)/DOC): Edit lisp.mk rather than using $shortlisp.
11406
4a720484
GM
114072011-05-19 Glenn Morris <rgm@gnu.org>
11408
11409 * Makefile.in (MSDOS_SUPPORT_REAL, MSDOS_SUPPORT, NS_SUPPORT)
11410 (REAL_MOUSE_SUPPORT, GPM_MOUSE_SUPPORT, MOUSE_SUPPORT, TOOLTIP_SUPPORT)
11411 (BASE_WINDOW_SUPPORT, X_WINDOW_SUPPORT, WINDOW_SUPPORT): Remove.
11412 (lisp): Set the order to that of loadup.el.
11413 (shortlisp): Make it a copy of $lisp.
11414 (SOME_MACHINE_LISP): Remove.
11415 ($(etc)/DOC): Depend just on $lisp, not $SOME_MACHINE_LISP too.
11416 Use just $shortlisp, not $SOME_MACHINE_LISP too.
11417
a28d4396
KH
114182011-05-18 Kenichi Handa <handa@m17n.org>
11419
11420 * composite.c (CHAR_COMPOSABLE_P): Add more check for efficiency.
11421 (BACKWARD_CHAR): Wrap the arg STOP by parenthesis.
11422 (find_automatic_composition): Mostly rewrite for efficiency.
11423
a2b1fa8e
JB
114242011-05-18 Juanma Barranquero <lekktu@gmail.com>
11425
11426 * makefile.w32-in: Update dependencies.
11427
8e1f5610
CS
114282011-05-18 Christoph Scholtes <cschol2112@googlemail.com>
11429
11430 * menu.c: Include limits.h (fixes the MS-Windows build broken by
7d7d0045 11431 2011-06-18T18:49:19Z!cyd@stupidchicken.com).
8e1f5610 11432
7025ee00 114332011-05-18 Paul Eggert <eggert@cs.ucla.edu>
cb93f9be 11434
cdfa6eab
PE
11435 Fix some integer overflow issues, such as string length overflow.
11436
06d6db33
PE
11437 * insdel.c (count_size_as_multibyte): Check for string overflow.
11438
2b4560a8
PE
11439 * character.c (lisp_string_width): Check for string overflow.
11440 Use EMACS_INT, not int, for string indexes and lengths; in
11441 particular, 2nd arg is now EMACS_INT, not int. Do not crash if
11442 the resulting string length overflows an EMACS_INT; instead,
11443 report a string overflow if no precision given. When checking for
11444 precision exhaustion, use a check that cannot possibly have
11445 integer overflow. (Bug#8675)
11446 * character.h (lisp_string_width): Adjust to new signature.
11447
cb93f9be
PE
11448 * alloc.c (string_overflow): New function.
11449 (Fmake_string): Use it. This doesn't change behavior, but saves
11450 a few bytes and will simplify future changes.
11451 * character.c (string_escape_byte8): Likewise.
11452 * lisp.h (string_overflow): New decl.
11453
1a1f3366
PE
11454 Fixups, following up to the user-interface timestamp change.
11455 * nsterm.m (last_mouse_movement_time, ns_mouse_position): Use Time
11456 for UI timestamps, instead of unsigned long.
9fbd6841
PE
11457 * msdos.c (mouse_get_pos): Likewise.
11458 * w32inevt.c (movement_time, w32_console_mouse_position): Likewise.
1a1f3366
PE
11459 * w32gui.h (Time): Define by including "systime.h" rather than by
11460 declaring it ourselves. (Bug#8664)
11461
d4e3e4d3
PE
11462 * dispextern.h (struct image): Don't assume time_t <= unsigned long.
11463 * image.c (clear_image_cache): Likewise.
11464
f6a24d19
PE
11465 * term.c (term_mouse_position): Don't assume time_t wraparound.
11466
08dc5ae6
PE
11467 Be more systematic about user-interface timestamps.
11468 Before, the code sometimes used 'Time', sometimes 'unsigned long',
620c53a6
SM
11469 and sometimes 'EMACS_UINT', to represent these timestamps.
11470 This change causes it to use 'Time' uniformly, as that's what X uses.
08dc5ae6
PE
11471 This makes the code easier to follow, and makes it easier to catch
11472 integer overflow bugs such as Bug#8664.
11473 * frame.c (Fmouse_position, Fmouse_pixel_position):
11474 Use Time, not unsigned long, for user-interface timestamps.
11475 * keyboard.c (last_event_timestamp, kbd_buffer_get_event): Likewise.
11476 (button_down_time, make_lispy_position, make_lispy_movement): Likewise.
11477 * keyboard.h (last_event_timestamp): Likewise.
11478 * menu.c (Fx_popup_menu) [!HAVE_X_WINDOWS]: Likewise.
11479 * menu.h (xmenu_show): Likewise.
11480 * term.c (term_mouse_position): Likewise.
11481 * termhooks.h (struct input_event.timestamp): Likewise.
11482 (struct terminal.mouse_position_hook): Likewise.
11483 * xmenu.c (create_and_show_popup_menu, xmenu_show): Likewise.
11484 * xterm.c (XTmouse_position, x_scroll_bar_report_motion): Likewise.
11485 * systime.h (Time): New decl. Pull it in from <X11/X.h> if
11486 HAVE_X_WINDOWS, otherwise define it as unsigned long, which is
11487 what it was before.
11488 * menu.h, termhooks.h: Include "systime.h", for Time.
11489
8e55734a
PE
11490 * keyboard.c (make_lispy_event): Fix problem in integer overflow.
11491 Don't assume that the difference between two unsigned long values
11492 can fit into an integer. At this point, we know button_down_time
11493 <= event->timestamp, so the difference must be nonnegative, so
11494 there's no need to cast the result if double-click-time is
11495 nonnegative, as it should be; check that it's nonnegative, just in
11496 case. This bug is triggered when events are more than 2**31 ms
86db42d2 11497 apart (about 25 days). (Bug#8664)
8e55734a 11498
841f1b75 11499 * xselect.c (last_event_timestamp): Remove duplicate decl.
6434756c 11500 (x_own_selection): Remove needless cast to unsigned long.
841f1b75 11501
3e26f69c
PE
11502 * xmenu.c (set_frame_menubar): Use int, not EMACS_UINT, for indexes
11503 that always fit in int. Use a sentinel instead of a counter, to
11504 avoid a temp and to allay GCC's concerns about possible int overflow.
d230cb74
PE
11505 * frame.h (struct frame): Use int for menu_bar_items_used
11506 instead of EMACS_INT, since it always fits in int.
3e26f69c 11507
5cc152c0
PE
11508 * menu.c (grow_menu_items): Check for int overflow.
11509
d89eb65e
PE
11510 * xmenu.c (set_frame_menubar): Don't mishandle vectors with no nils.
11511
5235bd3e
PE
11512 * xterm.c: Use EMACS_INT for Emacs modifiers, and int for X modifiers.
11513 Before, the code was not consistent. These values cannot exceed
11514 2**31 - 1 so there's no need to make them unsigned.
11515 (x_x_to_emacs_modifiers): Accept int and return EMACS_INT.
11516 (x_emacs_to_x_modifiers): Accept EMACS_INT and return int.
11517 (x_x_to_emacs_modifiers, x_emacs_to_x_modifiers): Reject non-integers
11518 as modifiers.
11519 * xterm.h (x_x_to_emacs_modifiers): Adjust to signature change.
11520
bc827e23
PE
11521 * lisp.h (XINT) [USE_LISP_UNION_TYPE]: Cast to EMACS_INT.
11522 (XUINT) [USE_LISP_UNION_TYPE]: Cast to EMACS_UINT.
11523 Otherwise, GCC 4.6.0 warns about printf (pI, XINT (...)),
11524 presumably because the widths might not match.
11525
78eb494e
PE
11526 * window.c (size_window): Avoid needless test at loop start.
11527
04f2d78b
CB
115282011-05-18 Courtney Bane <emacs-bugs-7626@cbane.org> (tiny change)
11529
11530 * term.c (Fresume_tty): Restore hooks before reinitializing (bug#8687).
11531
d2fc7e3d 115322011-05-12 Drew Adams <drew.adams@oracle.com>
e531bdff
DA
11533
11534 * textprop.c (Fprevious_single_char_property_change): Doc fix (bug#8655).
11535
d2fc7e3d 115362011-05-12 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
7db47798
YM
11537
11538 * w32term.c (w32_draw_fringe_bitmap): Rename local vars `left' and
11539 `width' to `bar_area_x' and `bar_area_width', respectively.
11540 (x_scroll_run): Take account of fringe background extension.
11541
04f2d78b
CB
11542 * xterm.c (x_draw_fringe_bitmap) [USE_TOOLKIT_SCROLL_BARS]:
11543 Rename local vars `left' and `width' to `bar_area_x' and
7db47798
YM
11544 `bar_area_width', respectively.
11545 (x_scroll_run) [USE_TOOLKIT_SCROLL_BARS]: Take account of fringe
11546 background extension.
11547
79b70037
GM
115482011-05-10 Jim Meyering <meyering@redhat.com>
11549
11550 * xdisp.c (x_intersect_rectangles): Fix typo "the the -> the".
11551
2f142cc5
JB
115522011-05-10 Juanma Barranquero <lekktu@gmail.com>
11553
11554 * image.c (Finit_image_library): Return t for built-in image types,
11555 like pbm and xbm. (Bug#8640)
11556
57679c86
AS
115572011-05-09 Andreas Schwab <schwab@linux-m68k.org>
11558
11559 * w32menu.c (set_frame_menubar): Fix submenu allocation.
11560
888c9e86
EZ
115612011-05-07 Eli Zaretskii <eliz@gnu.org>
11562
b0512a1d
EZ
11563 * w32console.c (Fset_screen_color): Doc fix.
11564 (Fget_screen_color): New function.
11565 (syms_of_ntterm): Defsubr it.
11566
7285dc67
EZ
11567 * callproc.c (call_process_cleanup) [MSDOS]: Don't close and
11568 unlink the temporary file if Fcall_process didn't create it in the
11569 first place.
11570 (Fcall_process) [MSDOS]: Don't create tempfile if stdout of the
11571 child process will be redirected to a file specified with `:file'.
888c9e86
EZ
11572 Don't try to re-open tempfile in that case, and set fd[0] to -1 as
11573 cue to call_process_cleanup not to close that handle.
11574
4d3fcc8e
BK
115752011-05-07 Ben Key <bkey76@gmail.com>
11576
11577 * makefile.w32-in: The bootstrap-temacs rule now makes use of
11578 one of two shell specific rules, either bootstrap-temacs-CMD or
11579 bootstrap-temacs-SH. The bootstrap-temacs-SH rule is identical
11580 to the previous implementation of the bootstrap-temacs rule.
11581 The bootstrap-temacs-CMD rule is similar to the previous
11582 implementation of the bootstrap-temacs rule except that it
11583 makes use of the ESC_CFLAGS variable instead of the CFLAGS
11584 variable.
11585
11586 These changes, along with some changes to nt/configure.bat,
11587 nt/gmake.defs, and nt/nmake.defs, are required to extend my
11588 earlier fix to add support for --cflags and --ldflags options
11589 that include quotes so that it works whether make uses cmd or
11590 sh as the shell.
11591
b4289b64
MA
115922011-05-06 Michael Albinus <michael.albinus@gmx.de>
11593
11594 * dbusbind.c (QCdbus_type_unix_fd): Declare static.
11595 (xd_remove_watch): Don't check QCdbus_type_unix_fd for SYMBOLP, it
11596 is a constant.
11597 (Fdbus_init_bus, xd_read_queued_messages): Bus can be a symbol or
11598 a string. Handle both cases.
11599 (Fdbus_call_method_asynchronously, Fdbus_register_signal)
11600 (Fdbus_register_method): Use Qinvalid_function.
11601
af4c0e28
JB
116022011-05-06 Juanma Barranquero <lekktu@gmail.com>
11603
11604 * makefile.w32-in: Update dependencies.
11605 (LISP_H): Add inttypes.h and stdin.h.
11606 (PROCESS_H): Add unistd.h.
11607
c51453d9
EZ
116082011-05-06 Eli Zaretskii <eliz@gnu.org>
11609
11610 * lread.c: Include limits.h (fixes the MS-Windows build broken by
11611 2011-05-06T07:13:19Z!eggert@cs.ucla.edu).
11612
8ff0ac3c 116132011-05-06 Paul Eggert <eggert@cs.ucla.edu>
c032b5f8 11614
4c4b566b
PE
11615 * image.c (Finit_image_library) [!HAVE_NTGUI]: Omit unused local.
11616
aab2b9b5
PE
11617 * term.c (vfatal): Remove stray call to va_end.
11618 It's not needed and the C Standard doesn't allow it here anyway.
11619
c378da0b
PE
11620 Use C99's va_copy to avoid undefined behavior on x86-64 GNU/Linux.
11621 * eval.c (verror): doprnt a copy of ap, not the original. (Bug#8545)
11622
288b08c7
PE
11623 * eval.c (verror): OK to create a string of up to MOST_POSITIVE_FIXNUM
11624 bytes.
11625
e3601888
PE
11626 * term.c: Don't include <stdarg.h>, as <lisp.h> does that.
11627
db6c0e74
PE
11628 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork clobbering.
11629
dd5963ea
PE
11630 * process.c (Fformat_network_address): Fix typo: args2 -> *args2.
11631
88c9450f
PE
11632 * xmenu.c (set_frame_menubar): Fix typo: int * -> int (3 times).
11633
2f9442b8
PE
11634 * coding.c (detect_coding_charset): Fix typo: * 2 -> *4 (Bug#8601).
11635
c032b5f8
PE
11636 * charset.h (struct charset.code_space): Now has 15 elements, not 16.
11637 * charset.c (Fdefine_charset_internal): Don't initialize
11638 charset.code_space[15]. The value was garbage, on hosts with
2d38271b 11639 32-bit int (Bug#8600).
a108c10b
PE
11640
11641 * lread.c (read_integer): Be more consistent with string-to-number.
11642 Use string_to_number to do the actual conversion; this avoids
11643 rounding errors and fixes some other screwups. Without this fix,
11644 for example, #x1fffffffffffffff was misread as -2305843009213693952.
11645 (digit_to_number): Move earlier, for benefit of read_integer.
11646 Return -1 if the digit is out of range for the base, -2 if it is
48e400f0 11647 not a digit in any supported base. (Bug#8602)
a108c10b 11648
ad5f9eea
PE
11649 * doprnt.c (doprnt): Support arbitrary pI values, such as "I64".
11650
aec1708a
PE
11651 * dispnew.c (scrolling_window): Return 1 if we scrolled,
11652 to match comment at start of function. This also removes a
11653 GCC warning about overflow in a 32+64-bit port.
11654
47be4ab5
PE
11655 * lisp.h (EMACS_INT, EMACS_UINT, BITS_PER_EMACS_INT, pI): Simplify.
11656
371cac43
PE
11657 * dbusbind.c: Do not use XPNTR on a value that may be an integer.
11658 Reported by Stefan Monnier in
11659 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00919.html>.
04f2d78b
CB
11660 (xd_remove_watch, Fdbus_init_bus, xd_read_queued_messages):
11661 Use SYMBOLP-guarded XSYMBOL, not XPNTR.
371cac43 11662
d01a7826
PE
11663 * lisp.h (EMACS_INTPTR): Remove. All uses changed to intptr_t.
11664 (EMACS_UINTPTR): Likewise, with uintptr_t.
11665
7fd47d5c
PE
11666 * lisp.h: Prefer 64-bit EMACS_INT if available.
11667 (EMACS_INT, EMACS_UINT, BITS_PER_EMACS_INT, pI): Define to 64-bit
11668 on 32-bit hosts that have 64-bit int, so that they can access
11669 large files.
122b0c86
PE
11670 However, temporarily disable this change unless the temporary
11671 symbol WIDE_EMACS_INT is defined.
7fd47d5c 11672
8727937b
PE
11673 * lread.c, process.c: Do not include <inttypes.h>; lisp.h does it now.
11674
8ac068ac
PE
11675 Prefer intptr_t/uintptr_t for integers the same widths as pointers.
11676 This removes an assumption that EMACS_INT and long are the same
11677 width as pointers. The assumption is true for Emacs porting targets
11678 now, but we want to make other targets possible.
11679 * lisp.h: Include <inttypes.h>, for INTPTR_MAX, UINTPTR_MAX.
11680 (EMACS_INTPTR, EMACS_UINTPTR): New macros.
11681 In the rest of the code, change types of integers that hold casted
11682 pointers to EMACS_INTPTR and EMACS_UINTPTR, systematically
11683 replacing EMACS_INT, long, EMACS_UINT, and unsigned long.
11684 (XTYPE): Don't cast arg to EMACS_UINT; normally is not needed.
11685 (XSET): Cast type of XTYPE arg to EMACS_INTPTR; it is needed here.
11686 No need to cast type when ORing.
11687 (XPNTR): Return a value of type EMACS_INTPTR or EMACS_UINTPTR.
11688 * alloc.c (lisp_align_malloc): Remove a no-longer-needed cast.
11689 * doc.c (store_function_docstring): Use EMACS_INTPTR, so as not to
11690 assume EMACS_INT is the same width as char *.
11691 * gtkutil.c (xg_gtk_scroll_destroy, xg_tool_bar_button_cb):
11692 (xg_tool_bar_callback, xg_tool_bar_help_callback, xg_make_tool_item):
11693 Remove no-longer-needed casts.
11694 (xg_create_scroll_bar, xg_tool_bar_button_cb, xg_tool_bar_callback):
11695 (xg_tool_bar_help_callback, xg_make_tool_item):
11696 Use EMACS_INTPTR to hold an integer
11697 that will be cast to void *; this can avoid a GCC warning
11698 if EMACS_INT is not the same width as void *.
11699 * menu.c (find_and_call_menu_selection): Remove no-longer-needed cast.
11700 * xdisp.c (display_echo_area_1, resize_mini_window_1):
11701 (current_message_1, set_message_1):
11702 Use a local to convert to proper width without a cast.
11703 * xmenu.c (dialog_selection_callback): Likewise.
11704
ede49d71
PE
11705 * sysdep.c (get_random): Don't assume EMACS_INT is no wider than long.
11706 Also, don't assume VALBITS / RAND_BITS is less than 5,
11707 and don't rely on undefined behavior when shifting a 1 left into
11708 the sign bit.
11709 * lisp.h (get_random): Change signature to match.
11710
2f30ecd0
PE
11711 * lread.c (hash_string): Use size_t, not int, for hash computation.
11712 Normally we prefer signed values; but hashing is special, because
11713 it's better to use unsigned division on hash table sizes so that
11714 the remainder is nonnegative. Also, size_t is the natural width
11715 for hashing into memory. The previous code used 'int', which doesn't
11716 retain enough info to hash well into very large tables.
11717 (oblookup, oblookup_last_bucket_number, Funintern): Likewise.
11718
2a866e7b
PE
11719 * dbusbind.c: Don't possibly lose pointer info when converting.
11720 (xd_remove_watch, Fdbus_init_bus, xd_read_queued_messages):
11721 Use XPNTR rather than XHASH, so that the high-order bits of
11722 the pointer aren't lost when converting through void *.
11723
51639eac
PE
11724 * eval.c (Fautoload): Don't double-shift a pointer.
11725
92394119
PE
11726 * fns.c (Frandom): Let EMACS_UINT be wider than unsigned long.
11727
dbdb9a7c
JB
117282011-05-06 Juanma Barranquero <lekktu@gmail.com>
11729
11730 * gnutls.c (DEF_GNUTLS_FN):
11731 * image.c (DEF_IMGLIB_FN): Make function pointers static.
11732
db7a0b4f
AS
117332011-05-05 Andreas Schwab <schwab@linux-m68k.org>
11734
11735 * lread.c (lisp_file_lexically_bound_p): Stop scanning at end
11736 marker. (Bug#8610)
11737
cd394be1 117382011-05-05 Eli Zaretskii <eliz@gnu.org>
fab624aa
EZ
11739
11740 * w32heap.c (allocate_heap) [USE_LISP_UNION_TYPE || USE_LSB_TAG]:
11741 New version that can reserve upto 2GB of heap space.
11742
f7ff1b0f 117432011-05-05 Chong Yidong <cyd@stupidchicken.com>
45cb8994
CY
11744
11745 * nsfns.m (Fns_read_file_name): Doc fix (Bug#8534).
11746
639c109b
TZ
117472011-05-05 Teodor Zlatanov <tzz@lifelogs.com>
11748
11749 * gnutls.c (fn_gnutls_certificate_set_x509_key_file): Add alias to
11750 `gnutls_certificate_set_x509_key_file'.
11751
d2127135
JB
117522011-05-05 Juanma Barranquero <lekktu@gmail.com>
11753
11754 * makefile.w32-in ($(BLD)/image.$(O), $(BLD)/process.$(O)):
11755 Update dependencies.
11756
e968f4f3
JB
117572011-05-04 Juanma Barranquero <lekktu@gmail.com>
11758
11759 * gnutls.h (emacs_gnutls_write, emacs_gnutls_read):
11760 * gnutls.c (emacs_gnutls_write, emacs_gnutls_read):
11761 Remove unused parameter `fildes'.
11762 * process.c (read_process_output, send_process): Don't pass it.
11763
84d358f0
JB
117642011-05-04 Juanma Barranquero <lekktu@gmail.com>
11765
11766 Fix previous change: the library cache is defined in w32.c.
11767 * image.c (CACHE_IMAGE_TYPE) [!HAVE_NTGUI]: Define to noop.
11768 (Finit_image_library): Wrap Vlibrary_cache on "#ifdef HAVE_NTGUI".
11769
0898ca10
JB
117702011-05-04 Juanma Barranquero <lekktu@gmail.com>
11771
11772 Implement dynamic loading of GnuTLS on Windows.
11773
11774 * gnutls.h (GNUTLS_EMACS_ERROR_NOT_LOADED): New macro.
11775 (emacs_gnutls_write, emacs_gnutls_read): Mark as extern.
11776 (emacs_gnutls_record_check_pending, emacs_gnutls_transport_set_errno):
11777 Declare.
11778
11779 * gnutls.c (Qgnutls_dll): Define.
11780 (DEF_GNUTLS_FN, LOAD_GNUTLS_FN): New macros.
11781 (gnutls_*): Declare function pointers.
11782 (init_gnutls_functions): New function to initialize function pointers.
11783 (emacs_gnutls_handshake, Fgnutls_error_string, Fgnutls_deinit)
11784 (emacs_gnutls_global_init, Fgnutls_bye): Use function pointers.
11785 (emacs_gnutls_record_check_pending, emacs_gnutls_transport_set_errno):
11786 Wrappers for gnutls_record_check_pending and gnutls_transport_set_errno.
11787 (emacs_gnutls_write, emacs_gnutls_read)
11788 (emacs_gnutls_handle_error, Fgnutls_error_fatalp)
11789 (Fgnutls_available_p): New function.
11790 (Fgnutls_boot): Call Fgnutls_available_p. Use function pointers.
11791 (syms_of_gnutls) <Qgnutls_dll>: Initialize and staticpro it.
11792 (syms_of_gnutls) <Sgnutls_available_p>: defsubr it.
11793
11794 * image.c: Include w32.h.
11795 (Vimage_type_cache): Delete.
11796 (syms_of_image) <Vimage_type_cache>: Don't initialize and staticpro it.
11797 (CACHE_IMAGE_TYPE, Finit_image_library): Use Vlibrary_cache instead.
11798 (w32_delayed_load): Move to w32.c.
11799
11800 * w32.h (VlibraryCache, QCloaded_from, w32_delayed_load): Declare.
11801
11802 * w32.c (QCloaded_from, Vlibrary_cache): Define.
11803 (w32_delayed_load): Move from image.c. When loading a library, record
11804 its filename in the :loaded-from property of the library id.
11805 (globals_of_w32) <QCloaded_from, Vlibrary_cache>:
11806 Initialize and staticpro them.
11807 (emacs_gnutls_pull, emacs_gnutls_push): Call emacs_gnutls_* functions.
11808
11809 * process.c: Include lisp.h before w32.h, not after.
11810 (wait_reading_process_output): Call emacs_gnutls_record_check_pending
11811 instead of gnutls_record_check_pending.
11812
11813 * callproc.c, emacs.c: Include lisp.h before w32.h, not after.
11814
ff4de4aa
TZ
118152011-05-04 Teodor Zlatanov <tzz@lifelogs.com>
11816
11817 * gnutls.c (Fgnutls_boot): Support :keylist and :crlfiles options
11818 instead of :keyfiles. Give GnuTLS the keylist and the CRL lists
11819 as passed in.
11820
abe95abb
JD
118212011-05-03 Jan Djärv <jan.h.d@swipnet.se>
11822
11823 * xterm.c (x_set_frame_alpha): Do not set property on anything
11824 else than FRAME_X_OUTER_WINDOW (Bug#8608).
11825
e16e55d4
JB
118262011-05-02 Juanma Barranquero <lekktu@gmail.com>
11827
11828 * sysdep.c (get_tty_size) [WINDOWSNT]: Implement. (Bug#8596)
11829
bafcf6a5
JB
118302011-05-02 Juanma Barranquero <lekktu@gmail.com>
11831
11832 * gnutls.c (Qgnutls_log_level, Qgnutls_code, Qgnutls_anon)
11833 (Qgnutls_x509pki, Qgnutls_e_interrupted, Qgnutls_e_again)
11834 (Qgnutls_e_invalid_session, Qgnutls_e_not_ready_for_handshake)
11835 (gnutls_global_initialized, Qgnutls_bootprop_priority)
11836 (Qgnutls_bootprop_trustfiles, Qgnutls_bootprop_keyfiles)
11837 (Qgnutls_bootprop_callbacks, Qgnutls_bootprop_loglevel)
11838 (Qgnutls_bootprop_hostname, Qgnutls_bootprop_verify_flags)
11839 (Qgnutls_bootprop_verify_error, Qgnutls_bootprop_verify_hostname_error)
11840 (Qgnutls_bootprop_callbacks_verify): Make static.
11841
e7a6747f
AS
118422011-05-01 Andreas Schwab <schwab@linux-m68k.org>
11843
19ed11ba
AS
11844 * callproc.c: Indentation fixup.
11845
e7a6747f 11846 * sysdep.c (wait_for_termination_1): Make static.
04f2d78b
CB
11847 (wait_for_termination, interruptible_wait_for_termination):
11848 Move after wait_for_termination_1.
e7a6747f 11849
1ef14cb4
LMI
118502011-05-01 Lars Magne Ingebrigtsen <larsi@gnus.org>
11851
11852 * sysdep.c (interruptible_wait_for_termination): New function
11853 which is like wait_for_termination, but allows keyboard
11854 interruptions.
11855
11856 * callproc.c (Fcall_process): Add (:file "file") as an option for
11857 the STDOUT buffer.
11858 (Fcall_process_region): Ditto.
11859
330d880c
EZ
118602011-04-30 Eli Zaretskii <eliz@gnu.org>
11861
8db90b73
EZ
11862 * dosfns.c (Fint86, Fdos_memget, Fdos_memput): Use `ASIZE (FOO)'
11863 rather than `XVECTOR (FOO)->size'.
11864
330d880c
EZ
11865 * process.c: Remove HAVE_INTTYPES_H condition from inclusion of
11866 inttypes.h, as a gnulib replacement is used if it not available in
11867 system headers.
11868
15cbd324
EZ
118692011-04-21 Eli Zaretskii <eliz@gnu.org>
11870
11871 Lift the MOST_POSITIVE_FIXNUM/4 limitation on visited files.
11872 * fileio.c (Finsert_file_contents): Don't limit file size to 1/4
11873 of MOST_POSITIVE_FIXNUM. (Bug#8528)
11874
11875 * coding.c (coding_alloc_by_realloc): Error out if destination
11876 will grow beyond MOST_POSITIVE_FIXNUM.
11877 (decode_coding_emacs_mule): Abort if there isn't enough place in
11878 charbuf for the composition carryover bytes. Reserve an extra
11879 space for up to 2 characters produced in a loop.
11880 (decode_coding_iso_2022): Abort if there isn't enough place in
11881 charbuf for the composition carryover bytes.
11882
118832011-04-21 Eli Zaretskii <eliz@gnu.org>
afda1437 11884
ae940cca
EZ
11885 * doprnt.c (doprnt) [!HAVE_LONG_LONG_INT]: Error out instead of
11886 aborting when %lld or %lll format is passed.
11887 [!HAVE_UNSIGNED_LONG_LONG_INT]: Error out instead of aborting when
11888 %llo or %llx format is passed. (Bug#8545)
11889
03ab8921
EZ
11890 * window.c (window_scroll_line_based): Use a marker instead of
11891 simple variables to record original value of point. (Bug#7952)
11892
afda1437
EZ
11893 * doprnt.c (doprnt): Fix the case where a multibyte sequence
11894 produced by %s or %c overflows available buffer space. (Bug#8545)
11895
f76dee0c
PE
118962011-04-28 Paul Eggert <eggert@cs.ucla.edu>
11897
11898 * doprnt.c (doprnt): Omit useless test; int overflow check (Bug#8545).
283cdbef 11899 (SIZE_MAX): Move defn after all includes, as they might #define it.
f76dee0c 11900
fdc5744d
JB
119012011-04-28 Juanma Barranquero <lekktu@gmail.com>
11902
11903 * w32.c (init_environment): Warn about defaulting HOME to C:\.
11904
638f053a
JB
119052011-04-28 Juanma Barranquero <lekktu@gmail.com>
11906
11907 * keyboard.c (Qdelayed_warnings_hook): Define.
11908 (command_loop_1): Run `delayed-warnings-hook'
11909 if Vdelayed_warnings_list is non-nil.
11910 (syms_of_keyboard) <delayed-warnings-hook>: DEFSYM it.
11911 (syms_of_keyboard) <delayed-warnings-list>: DEFVAR_LISP it.
11912
d178f871
EZ
119132011-04-28 Eli Zaretskii <eliz@gnu.org>
11914
11915 * doprnt.c (doprnt): Don't return value smaller than the buffer
11916 size if the message was truncated. (Bug#8545).
11917
b124fd93
JB
119182011-04-28 Juanma Barranquero <lekktu@gmail.com>
11919
11920 * w32fns.c (Fx_change_window_property, Fx_delete_window_property)
11921 (Fx_window_property): #if-0 the whole functions, not just the bodies.
11922
e810457d
PE
119232011-04-27 Paul Eggert <eggert@cs.ucla.edu>
11924
11925 * doprnt.c (doprnt): Support "ll" length modifier, for long long.
11926
ea51cceb
JB
119272011-04-27 Juanma Barranquero <lekktu@gmail.com>
11928
11929 * makefile.w32-in: Update dependencies.
11930
94dcfacf
EZ
119312011-04-27 Eli Zaretskii <eliz@gnu.org>
11932
11933 Improve `doprnt' and its usage. (Bug#8545)
11934 * doprnt.c (doprnt): Make sure `format' is never accessed beyond
11935 `format_end'. Remove support for %l as a conversion specifier.
11936 Don't use xrealloc. Improve diagnostics when the %l size modifier
11937 is used. Update the commentary.
11938
11939 * eval.c (verror): Simplify calculation of size_t.
11940
11941 * coding.c (Ffind_operation_coding_system): Fix diagnostic error
11942 messages.
11943
f61f41d7
PE
119442011-04-27 Yoshiaki Kasahara <kasahara@nc.kyushu-u.ac.jp> (tiny change)
11945
11946 * buffer.c (init_buffer) [USE_MMAP_FOR_BUFFERS]: Adjust to aliasing
11947 change.
11948
96fb4434
PE
119492011-04-27 Paul Eggert <eggert@cs.ucla.edu>
11950
11951 * nsmenu.m: Replace all uses of XVECTOR with ASIZE and AREF.
11952 This makes this file independent of the recent pseudovector change.
11953
671875da 119542011-04-26 Paul Eggert <eggert@cs.ucla.edu>
eab3844f 11955
69e9b5a3
PE
11956 * keyboard.c (handle_user_signal): Fix pointer signedness problem.
11957
b5f869a7 11958 * gnutls.c (emacs_gnutls_handle_error): Remove unused local.
7754e151 11959 (Fgnutls_boot): gnutls_certificate_verify_peers2 wants unsigned *.
8d4c3955 11960 Remove unused local.
c8926152 11961 (emacs_gnutls_write): Don't use uninitialized rtnval if nbyte <= 0.
080e5a8d 11962
841a1577 11963 * lisp.h: Fix a problem with aliasing and vector headers. (Bug#8546)
04f2d78b
CB
11964 GCC 4.6.0 optimizes based on type-based alias analysis.
11965 For example, if b is of type struct buffer * and v of type struct
eab3844f
PE
11966 Lisp_Vector *, then gcc -O2 was incorrectly assuming that &b->size
11967 != &v->size, and therefore "v->size = 1; b->size = 2; return
11968 v->size;" must therefore return 1. This assumption is incorrect
11969 for Emacs, since it type-puns struct Lisp_Vector * with many other
11970 types. To fix this problem, this patch adds a new type struct
f904488f 11971 vectorlike_header that documents the constraints on layout of vectors
eab3844f
PE
11972 and pseudovectors, and helps optimizing compilers not get fooled
11973 by Emacs's type punning. It also adds the macros XSETTYPED_PVECTYPE
11974 XSETTYPED_PSEUDOVECTOR, TYPED_PSEUDOVECTORP, for similar reasons.
f904488f
PE
11975 * lisp.h (XSETTYPED_PVECTYPE): New macro, specifying the name of
11976 the size member.
eab3844f
PE
11977 (XSETPVECTYPE): Rewrite in terms of new macro.
11978 (XSETPVECTYPESIZE): New macro, specifying both type and size.
11979 This is a bit clearer, and further avoids the possibility of
11980 undesirable aliasing.
11981 (XSETTYPED_PSEUDOVECTOR): New macro, specifying the size.
f904488f 11982 (XSETPSEUDOVECTOR): Rewrite in terms of XSETTYPED_PSEUDOVECTOR.
eab3844f
PE
11983 (XSETSUBR): Rewrite in terms of XSETTYPED_PSEUDOVECTOR and XSIZE,
11984 since Lisp_Subr is a special case (no "next" field).
04f2d78b
CB
11985 (ASIZE): Now uses header.size rather than size.
11986 All previous uses of XVECTOR (foo)->size replaced to use this macro,
f904488f
PE
11987 to avoid the hassle of writing XVECTOR (foo)->header.size.
11988 (struct vectorlike_header): New type.
eab3844f
PE
11989 (TYPED_PSEUDOVECTORP): New macro, also specifying the C type of the
11990 object, to help avoid aliasing.
11991 (PSEUDOVECTORP): Rewrite in terms of TYPED_PSEUDOVECTORP.
11992 (SUBRP): Likewise, since Lisp_Subr is a special case.
11993 * lisp.h (struct Lisp_Vector, struct Lisp_Char_Table):
11994 (struct Lisp_Sub_Char_Table, struct Lisp_Bool_Vector):
11995 (struct Lisp_Hash_Table): Combine first two members into a single
f904488f 11996 struct vectorlike_header member. All uses of "size" and "next" members
eab3844f
PE
11997 changed to be "header.size" and "header.next".
11998 * buffer.h (struct buffer): Likewise.
11999 * font.h (struct font_spec, struct font_entity, struct font): Likewise.
12000 * frame.h (struct frame): Likewise.
12001 * process.h (struct Lisp_Process): Likewise.
12002 * termhooks.h (struct terminal): Likewise.
12003 * window.c (struct save_window_data, struct saved_window): Likewise.
12004 * window.h (struct window): Likewise.
12005 * alloc.c (allocate_buffer, Fmake_bool_vector, allocate_pseudovector):
12006 Use XSETPVECTYPESIZE, not XSETPVECTYPE, to avoid aliasing problems.
12007 * buffer.c (init_buffer_once): Likewise.
12008 * lread.c (defsubr): Use XSETTYPED_PVECTYPE, since Lisp_Subr is a
12009 special case.
12010 * process.c (Fformat_network_address): Use local var for size,
12011 for brevity.
12012
0df1eac5
PE
12013 * bytecode.c (exec_byte_code): Don't use XVECTOR before CHECK_VECTOR.
12014
847ab9d1 12015 Make the Lisp reader and string-to-float more consistent (Bug#8525)
452f4150
PE
12016 * data.c (atof): Remove decl; no longer used or needed.
12017 (digit_to_number): Move to lread.c.
12018 (Fstring_to_number): Use new string_to_number function, to be
12019 consistent with how the Lisp reader treats infinities and NaNs.
12020 Do not assume that floating-point numbers represent EMACS_INT
12021 without losing information; this is not true on most 64-bit hosts.
12022 Avoid double-rounding errors, by insisting on integers when
12023 parsing non-base-10 numbers, as the documentation specifies.
12024 * lisp.h (string_to_number): New decl, replacing ...
12025 (isfloat_string): Remove.
bc0a5c13 12026 * lread.c: Include <inttypes.h>, for uintmax_t and strtoumax.
d78050d6 12027 (read1): Do not accept +. and -. as integers; this
452f4150
PE
12028 appears to have been a coding error. Similarly, do not accept
12029 strings like +-1e0 as floating point numbers. Do not report
12030 overflow for integer overflows unless the base is not 10 which
12031 means we have no simple and reliable way to continue.
12032 Break out the floating-point parsing into a new
12033 function string_to_number, so that Fstring_to_number parses
12034 floating point numbers consistently with the Lisp reader.
04f2d78b 12035 (digit_to_number): Move here from data.c. Make it static inline.
452f4150
PE
12036 (E_CHAR, EXP_INT): Remove, replacing with ...
12037 (E_EXP): New macro, to solve the "1.0e+" problem mentioned below.
12038 (string_to_number): New function, replacing isfloat_string.
12039 This function checks for valid syntax and produces the resulting
12040 Lisp float number too. Rework it so that string-to-number
bc0a5c13 12041 no longer mishandles examples like "1.0e+". Use strtoumax,
d78050d6
PE
12042 so that overflow for non-base-10 numbers is reported only when
12043 there's no portable and simple way to convert to floating point.
452f4150 12044
67769ffc
PE
12045 * textprop.c (set_text_properties_1): Rewrite for clarity,
12046 and to avoid GCC warning about integer overflow.
12047
c20db43f
PE
12048 * intervals.h (struct interval): Use EMACS_INT for members
12049 where EMACS_UINT might cause problems. See
12050 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00514.html>.
12051 (CHECK_TOTAL_LENGTH): Remove cast to EMACS_INT; no longer needed.
12052 * intervals.c (interval_deletion_adjustment): Now returns EMACS_INT.
12053 All uses changed.
37aa2f85
PE
12054 (offset_intervals): Tell GCC not to worry about length overflow
12055 when negating a negative length.
c20db43f 12056
2538aa2f
PE
12057 * alloc.c (overrun_check_malloc, overrun_check_realloc): Now static.
12058 (overrun_check_free): Likewise.
12059
f2d3008d
PE
12060 * alloc.c (SDATA_SIZE) [!GC_CHECK_STRING_BYTES]: Avoid runtime check
12061 in the common case where SDATA_DATA_OFFSET is a multiple of Emacs
12062 word size.
12063
ec8df744
PE
12064 * gnutls.c: Fix problems found by GCC 4.6.0 on Ubuntu 10.10.
12065 (gnutls_make_error): Rename local to avoid shadowing.
12066 (gnutls_emacs_global_deinit): ifdef out; not used.
12067 (Fgnutls_boot): Use const for pointer to readonly storage.
12068 Comment out unused local. Fix pointer signedness problems.
12069
640ee02d
PE
12070 * lread.c (openp): Don't stuff size_t into an 'int'.
12071 Use <= on length, not < on length + 1, to avoid GCC 4.6.0 warning
12072 about possible signed overflow.
12073
6048fb2a
PE
12074 * gtkutil.c: Fix problems found by GCC 4.6.0 on Ubuntu 10.10.
12075 (GDK_KEY_g): Don't define if already defined.
12076 (xg_prepare_tooltip): Avoid pointer signedness problem.
12077 (xg_set_toolkit_scroll_bar_thumb): Redo to avoid two casts.
12078
fa3c87e1
PE
12079 * process.c (Fnetwork_interface_info): Avoid left-shift undefined
12080 behavior with 1 << 31. GCC 4.6.0 warns about this on 32-bit hosts.
12081
2172544b
PE
12082 * xfns.c (Fx_window_property): Simplify a bit,
12083 to make a bit faster and to avoid GCC 4.6.0 warning.
12084 * xselect.c (x_get_window_property, x_handle_dnd_message): Likewise.
12085
9b821a21
PE
12086 * fns.c (internal_equal): Don't assume size_t fits in int.
12087
3c616cfa
PE
12088 * alloc.c (compact_small_strings): Tighten assertion a little.
12089
c2982e87
PE
12090 Replace pEd with more-general pI, and fix some printf arg casts.
12091 * lisp.h (pI): New macro, generalizing old pEd macro to other
12092 conversion specifiers. For example, use "...%"pI"d..." rather
12093 than "...%"pEd"...".
12094 (pEd): Remove. All uses replaced with similar uses of pI.
61bdb816 12095 * m/amdx86-64.h, m/ia64.h, m/ibms390x.h: Likewise.
c2982e87
PE
12096 * alloc.c (check_pure_size): Don't overflow by converting size to int.
12097 * bidi.c (bidi_dump_cached_states): Use pI to avoid cast.
12098 * data.c (Fnumber_to_string): Use pI instead of if-then-else-abort.
12099 * dbusbind.c (xd_append_arg): Use pI to avoid cast.
12100 (Fdbus_method_return_internal, Fdbus_method_error_internal): Likewise.
12101 * font.c (font_unparse_xlfd): Avoid potential buffer overrun on
12102 64-bit hosts.
12103 (font_unparse_xlfd, font_unparse_fcname): Use pI to avoid casts.
12104 * keyboard.c (record_char, modify_event_symbol): Use pI to avoid casts.
12105 * print.c (safe_debug_print, print_object): Likewise.
12106 (print_object): Don't overflow by converting EMACS_INT or EMACS_UINT
12107 to int.
6f04d126
PE
12108 Use pI instead of if-then-else-abort. Use %p to avoid casts,
12109 avoiding the 0 flag, which is not portable.
c2982e87
PE
12110 * process.c (Fmake_network_process): Use pI to avoid cast.
12111 * region-cache.c (pp_cache): Likewise.
12112 * xdisp.c (decode_mode_spec): Likewise.
12113 * xrdb.c (x_load_resources) [USE_MOTIF]: Use pI to avoid undefined
12114 behavior on 64-bit hosts with printf arg.
6f04d126 12115 * xselect.c (x_queue_event): Use %p to avoid casts, avoiding 0 flag.
c2982e87
PE
12116 (x_stop_queuing_selection_requests): Likewise.
12117 (x_get_window_property): Don't truncate byte count to an 'int'
12118 when tracing.
0b432f21 12119
5e073ec7
PE
12120 * frame.c (frame_name_fnn_p): Get rid of strtol, which isn't right
12121 here, since it parses constructs like leading '-' and spaces,
12122 which are not wanted; and it overflows with large numbers.
12123 Instead, simply match F[0-9]+, which is what is wanted anyway.
12124
36372bf9
PE
12125 * alloc.c: Remove unportable assumptions about struct layout.
12126 (SDATA_SELECTOR, SDATA_DATA_OFFSET): New macros.
12127 (SDATA_OF_STRING, SDATA_SIZE, allocate_string_data):
12128 (allocate_vectorlike, make_pure_vector): Use the new macros,
12129 plus offsetof, to remove unportable assumptions about struct layout.
12130 These assumptions hold on all porting targets that I know of, but
12131 they are not guaranteed, they're easy to remove, and removing them
12132 makes further changes easier.
12133
0b432f21
PE
12134 * alloc.c (BLOCK BYTES): Fix typo by changing "ablock" to "ablocks".
12135 This doesn't fix a bug but makes the code clearer.
bfd1c781
PE
12136 (string_overrun_cookie): Now const. Use initializers that
12137 don't formally overflow signed char, to avoid warnings.
000098c1
PE
12138 (allocate_string_data) [GC_CHECK_STRING_OVERRUN]: Fix typo that
12139 can cause Emacs to crash when string overrun checking is enabled.
c7bda33c
PE
12140 (allocate_buffer): Don't assume sizeof (struct buffer) is a
12141 multiple of sizeof (EMACS_INT); it need not be, if
12142 alignof(EMACS_INT) < sizeof (EMACS_INT).
d0f4e1f5 12143 (check_sblock, check_string_bytes, check_string_free_list): Protoize.
0b432f21 12144
895009e1
JB
121452011-04-26 Juanma Barranquero <lekktu@gmail.com>
12146
12147 * keyboard.c (QCrtl): Rename from Qrtl. All uses changed.
12148
6a7a1b0b
TZ
121492011-04-26 Teodor Zlatanov <tzz@lifelogs.com>
12150
12151 * gnutls.c (emacs_gnutls_handshake): Return an error if we're not
b5f869a7 12152 supposed to be handshaking. (Bug#8556)
6a7a1b0b
TZ
12153 Reported by Paul Eggert <eggert@cs.ucla.edu>.
12154
841a1577 121552011-04-26 Daniel Colascione <dan.colascione@gmail.com>
0438ce91
DC
12156
12157 * lisp.h (Qdebug): List symbol.
895009e1 12158 * eval.c (Qdebug): Restore global linkage.
0438ce91
DC
12159 * keyboard.c (debug-on-event): New variable.
12160 (handle_user_signal): Break into debugger when debug-on-event
12161 matches the current signal symbol.
12162
f2d3ba6f
DN
121632011-04-25 Dan Nicolaescu <dann@ics.uci.edu>
12164
12165 * alloc.c (check_sblock, check_string_bytes)
12166 (check_string_free_list): Convert to standard C.
12167
42ce4c63
TZ
121682011-04-25 Teodor Zlatanov <tzz@lifelogs.com>
12169
12170 * w32.c (emacs_gnutls_push): Fix typo.
12171
825cd63c
EZ
121722011-04-25 Eli Zaretskii <eliz@gnu.org>
12173
fb11d64d
EZ
12174 * gnutls.c (emacs_gnutls_handshake): Avoid compiler warnings about
12175 "cast to pointer from integer of different size".
12176
825cd63c
EZ
12177 Improve doprnt and its use in verror. (Bug#8545)
12178 * doprnt.c (doprnt): Document the set of format control sequences
12179 supported by the function. Use SAFE_ALLOCA instead of always
12180 using `alloca'.
12181
12182 * eval.c (verror): Don't limit the buffer size at size_max-1, that
12183 is one byte too soon. Don't use xrealloc; instead xfree and
12184 xmalloc anew.
12185
e061a11b
TZ
121862011-04-24 Teodor Zlatanov <tzz@lifelogs.com>
12187
12188 * gnutls.h: Add GNUTLS_STAGE_CALLBACKS enum to denote we're in the
12189 callbacks stage.
12190
12191 * gnutls.c: Renamed global_initialized to
12192 gnutls_global_initialized. Added internals for the
12193 :verify-hostname-error, :verify-error, and :verify-flags
12194 parameters of `gnutls-boot' and documented those parameters in the
12195 docstring. Start callback support.
9173deec
JB
12196 (emacs_gnutls_handshake): Add Woe32 support. Retry handshake
12197 unless a fatal error occurred. Call gnutls_alert_send_appropriate
12198 on error. Return error code.
e061a11b
TZ
12199 (emacs_gnutls_write): Call emacs_gnutls_handle_error.
12200 (emacs_gnutls_read): Likewise.
12201 (Fgnutls_boot): Return handshake error code.
12202 (emacs_gnutls_handle_error): New function.
12203 (wsaerror_to_errno): Likewise.
12204
12205 * w32.h (emacs_gnutls_pull): Add prototype.
12206 (emacs_gnutls_push): Likewise.
12207
12208 * w32.c (emacs_gnutls_pull): New function for GnuTLS on Woe32.
12209 (emacs_gnutls_push): Likewise.
12210
122112011-04-24 Claudio Bley <claudio.bley@gmail.com> (tiny change)
12212
12213 * process.c (wait_reading_process_output): Check if GnuTLS
12214 buffered some data internally if no FDs are set for TLS
12215 connections.
12216
12217 * makefile.w32-in (OBJ2): Add gnutls.$(O).
12218 (LIBS): Link to USER_LIBS.
12219 ($(BLD)/gnutls.$(0)): New target.
12220
fa6996bc
EZ
122212011-04-24 Eli Zaretskii <eliz@gnu.org>
12222
eb35682e
EZ
12223 * xdisp.c (handle_single_display_spec): Rename the
12224 display_replaced_before_p argument into display_replaced_p, to
12225 make it consistent with the commentary. Fix typos in the
12226 commentary.
12227
e2ad650c
EZ
12228 * textprop.c (syms_of_textprop): Remove dead code.
12229 (copy_text_properties): Delete obsolete commentary about an
12230 interface that was deleted long ago. Fix typos in the description
12231 of arguments.
12232
1b2de274
EZ
12233 * msdos.c (XMenuActivate, XMenuAddSelection): Adjust argument list
12234 to changes in oldXMenu/XMenu.h from 2011-04-16.
12235 <menu_help_message, prev_menu_help_message>: Constify.
12236 (IT_menu_make_room): menu->help_text is now `const char **';
12237 adjust.
12238
12239 * msdos.h (XMenuActivate, XMenuAddSelection): Adjust prototypes
12240 to changes in oldXMenu/XMenu.h from 2011-04-16.
12241 (struct XMenu): Declare `help_text' `const char **'.
12242
12243 * xfaces.c <Qunspecified>: Make extern again.
12244
12245 * syntax.c: Include sys/types.h before including regex.h, as
75f1671a 12246 required by POSIX.
1b2de274 12247
762b15be
EZ
12248 * doc.c (get_doc_string): Improve the format passed to `error'.
12249
12250 * doprnt.c (doprnt): Improve commentary.
12251
12252 * term.c (init_tty) [MSDOS]: Fix 1st argument to maybe_fatal.
12253
12254 * Makefile.in (TAGS): Depend on $(M_FILE) and $(S_FILE), and scan
12255 them with etags.
12256
f1052e5d
EZ
12257 * makefile.w32-in (globals.h): Add a dummy recipe, to make any
12258 changes in globals.h immediately force recompilation.
762b15be
EZ
12259 (TAGS): Depend on $(CURDIR)/m/intel386.h and
12260 $(CURDIR)/s/ms-w32.h.
12261 (TAGS-gmake): Scan $(CURDIR)/m/intel386.h and $(CURDIR)/s/ms-w32.h.
f1052e5d 12262
fa6996bc
EZ
12263 * character.c (Fchar_direction): Function deleted.
12264 (syms_of_character): Don't defsubr it.
12265 <char-direction-table>: Deleted.
12266
e6c3da20
EZ
122672011-04-23 Eli Zaretskii <eliz@gnu.org>
12268
12269 Fix doprnt so it could be used again safely in `verror'. (Bug#8435)
12270 * doprnt.c: Include limits.h.
12271 (SIZE_MAX): New macro.
04f2d78b
CB
12272 (doprnt): Return a size_t value. 2nd arg is now size_t.
12273 Many local variables are now size_t instead of int or unsigned.
e6c3da20
EZ
12274 Improve overflow protection. Support `l' modifier for integer
12275 conversions. Support %l conversion. Don't assume an EMACS_INT
12276 argument for integer conversions and for %c.
12277
12278 * lisp.h (doprnt): Restore prototype.
12279
12280 * makefile.w32-in ($(BLD)/callint.$(O)): Depend on
12281 $(SRC)/character.h.
12282
12283 * Makefile.in (base_obj): Add back doprnt.o.
12284
12285 * deps.mk (doprnt.o): Add back prerequisites.
12286 (callint.o): Depend on character.h.
12287
12288 * eval.c (internal_lisp_condition_case): Include the handler
12289 representation in the error message.
12290 (verror): Call doprnt instead of vsnprintf. Fix an off-by-one bug
12291 when breaking from the loop.
12292
12293 * xdisp.c (vmessage): Call doprnt instead of vsnprintf.
12294
12295 * callint.c (Fcall_interactively): When displaying error message
12296 about invalid control letter, pass the character's codepoint, not
12297 a pointer to its multibyte form. Improve display of the character
12298 in octal and display also its hex code.
12299
12300 * character.c (char_string): Use %x to display the (unsigned)
12301 codepoint of an invalid character, to avoid displaying a bogus
12302 negative value.
12303
12304 * font.c (check_otf_features): Pass SDATA of SYMBOL_NAME to
12305 `error', not SYMBOL_NAME itself.
12306
12307 * coding.c (Fencode_sjis_char, Fencode_big5_char): Use %c for
12308 character arguments to `error'.
12309
12310 * charset.c (check_iso_charset_parameter): Fix incorrect argument
12311 to `error' in error message about FINAL_CHAR argument. Make sure
12312 FINAL_CHAR is a character, and use %c when it is passed as
12313 argument to `error'.
12314
4ffd0d6b 123152011-04-23 Eli Zaretskii <eliz@gnu.org>
97a93095
EZ
12316
12317 * s/ms-w32.h (localtime): Redirect to sys_localtime.
12318
12319 * w32.c: Include <time.h>.
12320 (sys_localtime): New function.
12321
4ffd0d6b 123222011-04-23 Chong Yidong <cyd@stupidchicken.com>
c17819f4
CY
12323
12324 * xdisp.c (init_xdisp): Initialize echo_area_window (Bug#6451).
12325
4ffd0d6b 12326 * buffer.c (syms_of_buffer): Doc fix (Bug#6902).
aac0c6e3 12327
4ffd0d6b 123282011-04-23 Samuel Thibault <sthibault@debian.org> (tiny change)
aac0c6e3 12329
4ffd0d6b
GM
12330 * sysdep.c (wait_for_termination): On GNU Hurd, kill returns -1 on
12331 zombies (Bug#8467).
aac0c6e3 12332
04c56954
EZ
123332011-04-19 Eli Zaretskii <eliz@gnu.org>
12334
12335 * syntax.h (SETUP_SYNTAX_TABLE_FOR_OBJECT): Fix setting of
12336 gl_state.e_property when gl_state.object is Qt.
12337
12338 * insdel.c (make_gap_larger): Remove limitation of buffer size
12339 to <= INT_MAX.
12340
16a43933
CY
123412011-04-18 Chong Yidong <cyd@stupidchicken.com>
12342
12343 * xdisp.c (lookup_glyphless_char_display)
12344 (produce_glyphless_glyph): Handle cons cell entry in
12345 glyphless-char-display.
12346 (Vglyphless_char_display): Document it.
12347
12348 * term.c (produce_glyphless_glyph): Handle cons cell entry in
12349 glyphless-char-display.
12350
4581706e
CY
123512011-04-17 Chong Yidong <cyd@stupidchicken.com>
12352
12353 * xdisp.c (get_next_display_element): Remove unnecessary ifdefs.
12354
12355 * termhooks.h (FRAME_WINDOW_P): Remove duplicated definitions.
12356
12357 * dispextern.h (FACE_SUITABLE_FOR_ASCII_CHAR_P): Add missing
12358 definition for no-X builds.
12359
4887c6e2 123602011-04-16 Paul Eggert <eggert@cs.ucla.edu>
764430a3 12361
fd35b6f9
PE
12362 Static checks with GCC 4.6.0 and non-default toolkits.
12363
5c1ccb01
PE
12364 * s/sol2-6.h, s/unixware.h (PTY_TTY_NAME_SPRINTF): Protoize decl.
12365
006c5daa
PE
12366 * process.c (keyboard_bit_set): Define only if SIGIO.
12367 (send_process_trap): Mark it with NO_RETURN if it doesn't return.
12368 (send_process): Repair possible setjmp clobbering.
12369
efc736d3
PE
12370 * s/usg5-4-common.h (SETUP_SLAVE_PTY): Don't pass extra arg to 'fatal'.
12371
4e2fe2e6
PE
12372 * eval.c: Include <stdio.h>, for vsnprintf on non-GNU/Linux hosts.
12373
f97334a2
PE
12374 * data.c (arith_error): Mark with NO_RETURN if it doesn't return.
12375
4e75f29d
PE
12376 * alloc.c (bytes_used_when_full, SPARE_MEMORY, BYTES_USED):
12377 Define only if needed.
12378
90efadd1
PE
12379 * sysdep.c (_FILE_OFFSET_BITS): Make this hack even uglier
12380 by pacifying GCC about it. Maybe it's time to retire it?
875975e9 12381 * xfaces.c (USG, __TIMEVAL__): Likewise.
90efadd1 12382
3c647824
PE
12383 * dispextern.h (struct redisplay_interface): Rename param
12384 to avoid shadowing.
e264f262 12385 * termhooks.h (struct terminal): Likewise.
761383f4 12386 * xterm.c (xembed_send_message): Likewise.
3c647824 12387
b58c5c4a
PE
12388 * insdel.c (make_gap_smaller): Define only if
12389 USE_MMAP_FOR_BUFFERS || REL_ALLOC || DOUG_LEA_MALLOC.
12390
cad59032
PE
12391 * keyboard.c (read_char): Make a var volatile so longjmp won't clobber
12392 it.
12393
c339dc2e
PE
12394 * emacs.c (MAX_HEAP_BSS_DIFF, my_edata): Move to where they're used,
12395 so that we aren't warned about unused symbols.
12396
91a3e27b
PE
12397 * xfns.c (Fx_file_dialog): Rename local to avoid shadowing.
12398
399c71d3 12399 * xdisp.c (x_produce_glyphs): Mark var as initialized (Bug#8512).
7a3fb125 12400
8ffc96f5
PE
12401 * xfns.c (x_real_positions): Mark locals as initialized.
12402
eef9bc79
PE
12403 * xmenu.c (xmenu_show): Don't use uninitialized vars.
12404
098db9dd
PE
12405 * xterm.c: Fix problems found by static analysis with other toolkits.
12406 (toolkit_scroll_bar_interaction): Define and use only if USE_X_TOOLKIT.
dda3aedd
PE
12407 (x_dispatch_event): Declare static if USE_GTK, and
12408 define if USE_GTK || USE_X_TOOLKIT.
098db9dd 12409 (SET_SAVED_BUTTON_EVENT): Define only if USE_X_TOOLKIT || USE_GTK.
dda3aedd 12410 * xterm.h (x_dispatch_event): Extern only if USE_X_TOOLKIT.
841a1577
JB
12411 * xterm.c, xterm.h (x_mouse_leave): Bring this function back, but only
12412 if defined HAVE_MENUS && !defined USE_X_TOOLKIT && !defined USE_GTK.
098db9dd 12413
eb18f6cc
PE
12414 * xmenu.c (menu_help_callback): Pointer type fixes.
12415 Use const pointers when pointing at readonly data. Avoid pointer
12416 signedness clashes.
12417 (FALSE): Remove unused macro.
12418 (update_frame_menubar): Remove unused decl.
12419
1fe72bf8
PE
12420 * xfns.c (Fx_hide_tip): Move locals to avoid shadowing.
12421
60d9e1db
PE
12422 * menu.c (push_submenu_start, push_submenu_end): Do not define unless
12423 USE_X_TOOLKIT || USE_GTK || HAVE_NS || defined HAVE_NTGUI.
12424 (single_menu_item): Rename local to avoid shadowing.
12425
39261c26
PE
12426 * keyboard.c (make_lispy_event): Remove unused local var.
12427
018c5e19
PE
12428 * frame.c, frame.h (x_get_resource_string): Bring this back, but
12429 only if HAVE_X_WINDOWS && !USE_X_TOOLKIT.
12430
63d2b86e
PE
12431 * bitmaps: Change bitmaps from unsigned char back to the X11
12432 compatible char. Avoid the old compiler warnings about
12433 out-of-range initializers by using, for example, '\xab' rather
12434 than 0xab.
12435
aefd87e1
PE
12436 * xgselect.c (xgselect_initialize): Check vs interface
12437 even if ! (defined (USE_GTK) || defined (HAVE_GCONF)).
12438
bf501fb9
PE
12439 * xmenu.c (xmenu_show): Rename parm to avoid shadowing.
12440
e9829fdf
PE
12441 * xterm.c (x_create_toolkit_scroll_bar): Use const * for pointers
12442 to read-only memory.
12443
1086c095
PE
12444 * fns.c (vector): Remove; this old hack is no longer needed.
12445
2baccd04 12446 * xsmfns.c (create_client_leader_window): Rename shadowing arg.
401f10cb 12447 Remove unused var.
dde42981 12448 (gdk_x11_set_sm_client_id) [!USE_GTK]: Don't define.
2baccd04 12449
72391843 12450 * xrdb.c (x_load_resources): Omit unused local.
3565b346 12451
436c16df 12452 * xfns.c (free_frame_menubar, atof): Remove duplicate decls.
8a94ea33 12453 (x_window): Rename locals to avoid shadowing.
dc5ddd85 12454 (USG): Use the kludged USG macro, to pacify gcc.
436c16df 12455
92bb796d 12456 * xterm.c (x_alloc_nearest_color_for_widget): Remove; unused.
bbbef9e1 12457 (x_term_init): Remove local to avoid shadowing.
92bb796d 12458
764430a3 12459 * xfns.c, xterm.c (_XEditResCheckMessages): Protoize decl.
4887c6e2
PE
12460
12461 * xdisp.c, dispextern.h (set_vertical_scroll_bar): Now extern if
12462 USE_TOOLKIT_SCROLL_BARS && !USE_GTK, as xterm.c needs it then.
12463
d1dfb56c
EZ
124642011-04-16 Eli Zaretskii <eliz@gnu.org>
12465
c4354cb4
EZ
12466 * gnutls.c (Fgnutls_boot): Don't pass Lisp_Object to `error'.
12467
d1dfb56c
EZ
12468 Fix regex.c, syntax.c and friends for buffers > 2GB.
12469 * syntax.h (struct gl_state_s): Declare character position members
12470 EMACS_INT.
12471
12472 * syntax.c (update_syntax_table): Declare 2nd argument EMACS_INT.
12473
04f2d78b
CB
12474 * textprop.c (verify_interval_modification, interval_of):
12475 Declare arguments EMACS_INT.
d1dfb56c
EZ
12476
12477 * intervals.c (adjust_intervals_for_insertion): Declare arguments
12478 EMACS_INT.
12479
12480 * intervals.h (CHECK_TOTAL_LENGTH): Cast to EMACS_INT, not `int'.
12481
12482 * indent.c (Fvertical_motion): Local variable it_start is now
12483 EMACS_INT.
12484
12485 * regex.c (re_match, re_match_2, re_match_2_internal)
12486 (bcmp_translate, regcomp, regexec, print_double_string)
12487 (group_in_compile_stack, re_search, re_search_2, regex_compile)
12488 (re_compile_pattern, re_exec): Declare arguments and local
12489 variables `size_t' and `ssize_t' and return values `regoff_t', as
12490 appropriate.
12491 (POP_FAILURE_REG_OR_COUNT) <pfreg>: Declare `long'.
12492 (CHECK_INFINITE_LOOP) <failure>: Declare `ssize_t'.
12493 <compile_stack_type>: `size' and `avail' are now `size_t'.
12494
12495 * regex.h <regoff_t>: Use ssize_t, not int.
12496 (re_search, re_search_2, re_match, re_match_2): Arguments that
12497 specify buffer/string position and length are now ssize_t and
12498 size_t. Return type is regoff_t.
12499
613052cd
BK
125002011-04-16 Ben Key <bkey76@gmail.com>
12501
12502 * nsfont.m: Fixed bugs in ns_get_family and
12503 ns_descriptor_to_entity that were caused by using free to
12504 deallocate memory blocks that were allocated by xmalloc (via
12505 xstrdup). This caused Emacs to crash when compiled with
12506 XMALLOC_OVERRUN_CHECK defined (when Emacs was configured with
12507 --enable-checking=xmallocoverrun). xfree is now used to
12508 deallocate these memory blocks.
12509
4170f62f 125102011-04-15 Paul Eggert <eggert@cs.ucla.edu>
3e047f51 12511
71b41406
PE
12512 * sysdep.c (emacs_read): Remove unnecessary check vs MAX_RW_COUNT.
12513
9587a89d
PE
12514 emacs_write: Accept and return EMACS_INT for sizes.
12515 See http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00514.html
12516 et seq.
12517 * gnutls.c, gnutls.h (emacs_gnutls_read, emacs_gnutls_write):
12518 Accept and return EMACS_INT.
12519 (emacs_gnutls_write): Return the number of bytes written on
12520 partial writes.
12521 * sysdep.c, lisp.h (emacs_read, emacs_write): Likewise.
273a5f82
PE
12522 (emacs_read, emacs_write): Remove check for negative size, as the
12523 Emacs source code has been audited now.
9587a89d
PE
12524 * sysdep.c (MAX_RW_COUNT): New macro, to work around kernel bugs.
12525 (emacs_read, emacs_write): Use it.
273a5f82
PE
12526 * process.c (send_process): Adjust to the new signatures of
12527 emacs_write and emacs_gnutls_write. Do not attempt to store
12528 a byte offset into an 'int'; it might overflow.
9587a89d 12529 See http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00483.html
273a5f82 12530
3e047f51
PE
12531 * sound.c: Don't assume sizes fit in 'int'.
12532 (struct sound_device.period_size, alsa_period_size):
9c3c56a7 12533 Return EMACS_INT, not int.
3e047f51 12534 (struct sound_device.write, vox_write, alsa_write):
9c3c56a7
PE
12535 Accept EMACS_INT, not int.
12536 (wav_play, au_play): Use EMACS_INT to store sizes and to
3e047f51
PE
12537 record read return values.
12538
cc39a9db
BK
125392011-04-15 Ben Key <bkey76@gmail.com>
12540
c9d0ec6d
JB
12541 * keyboard.c (Qundefined): Don't declare static since it is used
12542 in nsfns.m.
12543 * xfaces.c (Qbold, Qexpanded, Qitalic, Qcondensed): Don't declare
12544 static since they are used in nsfont.m.
cc39a9db 12545
6c60eb9f
SM
125462011-04-15 Stefan Monnier <monnier@iro.umontreal.ca>
12547
12548 * process.c (Qprocessp): Don't declare static.
12549 * lisp.h (Qprocessp): Declare again.
12550
7990b61a
JB
125512011-04-15 Juanma Barranquero <lekktu@gmail.com>
12552
12553 * font.c (Qopentype): Don't make static (used from w32uniscribe.c).
12554
5d4cb038
PE
125552011-04-14 Paul Eggert <eggert@cs.ucla.edu>
12556
8bd7b830 12557 Improve C-level modularity by making more things 'static'.
cd64ea1d 12558
e3b27b31
PE
12559 Don't publish debugger-only interfaces to other modules.
12560 * lisp.h (safe_debug_print, debug_output_compilation_hack):
12561 (verify_bytepos, count_markers): Move decls to the only modules
12562 that need them.
12563 * region-cache.h (pp_cache): Likewise.
12564 * window.h (check_all_windows): Likewise.
12565 * marker.c, print.c, region-cache.c, window.c: Decls moved here.
12566
5d4cb038
PE
12567 * sysdep.c (croak): Now static, if
12568 defined TIOCNOTTY || defined USG5 || defined CYGWIN.
12569 * syssignal.h (croak): Declare only if not static.
69003fd8
PE
12570
12571 * alloc.c (refill_memory_reserve): Now static if
12572 !defined REL_ALLOC || defined SYSTEM_MALLOC.
12573 * lisp.h (refill_memory_reserve): Declare only if not static.
93ea6e8f 12574
e87b6180
PE
12575 * xsettings.c, xsettings.h (xsettings_get_system_normal_font):
12576 Define only if USE_LUCID.
12577
ac64929e
PE
12578 * xrdb.c (x_customization_string, x_rm_string): Now static.
12579
6f37259d
PE
12580 * xmenu.c (x_menu_wait_for_event): Export only if USE_MOTIF.
12581 * xterm.h (x_menu_wait_for_event): Declare only if USE_MOTIF.
12582
1683e3ab
PE
12583 * xdisp.c (draw_row_with_mouse_face): Now static.
12584 * dispextern.h (draw_row_with_mouse_fave): Remove decl.
12585
de9c2632
PE
12586 * window.h (check_all_windows): Mark externally visible.
12587
2b96acb7
PE
12588 * window.c (window_deletion_count): Now static.
12589
12590 * undo.c: Make symbols static if they're not exported.
12591 (last_undo_buffer, last_boundary_position, pending_boundary):
12592 Now static.
12593
50436f33
PE
12594 * textprop.c (interval_insert_behind_hooks): Now static.
12595 (interval_insert_in_front_hooks): Likewise.
12596
64520e5c
PE
12597 * term.c: Make symbols static if they're not exported.
12598 (tty_turn_off_highlight, get_tty_terminal, max_frame_cols):
12599 (max_frame_lines, tty_set_terminal_modes):
12600 (tty_reset_terminal_modes, tty_turn_off_highlight):
12601 (get_tty_terminal): Now static.
12602 (term_mouse_moveto): Do not define if HAVE_WINDOW_SYSTEM.
12603 * termhooks.h (term_mouse_moveto): Do not declare if
8bd7b830 12604 HAVE_WINDOW_SYSTEM.
64520e5c
PE
12605 * dispextern.h (tty_set_terminal_modes, tty_reset_terminal_modes):
12606 (tty_turn_off_highlight, get_tty_terminal): Remove decls.
12607
1fa53021
PE
12608 * sysdep.c: Make symbols static if they're not exported.
12609 (emacs_get_tty, emacs_set_tty, old_fcntl_flags, old_fcntl_owner):
12610 Now static.
12611 (sigprocmask_set, full_mask): Remove; unused.
12612 (wait_debugging): Mark as visible.
12613 * syssignal.h (SIGFULLMASK, full_mask): Remove decls.
12614 * systty.h (emacs_get_tty, emacs_set_tty): Remove decls.
12615
d4b43b22
PE
12616 * syntax.c (syntax_temp): Define only if !__GNUC__.
12617
b7c513d0
PE
12618 * sound.c (current_sound_device, current_sound): Now static.
12619
989b29ad
PE
12620 * search.c (searchbufs, searchbuf_head): Now static.
12621
13a55a78
PE
12622 * scroll.c (scroll_cost): Remove; unused.
12623 * dispextern.h (scroll_cost): Remove decl.
12624
de68a1fc
PE
12625 * region-cache.h (pp_cache): Mark as externally visible.
12626
40ccffa6
PE
12627 * process.c: Make symbols static if they're not exported.
12628 (process_tick, update_tick, create_process, chan_process):
12629 (Vprocess_alist, proc_buffered_char, datagram_access):
12630 (fd_callback_data, send_process_frame, process_sent_to): Now static.
12631 (deactivate_process): Mark defn as static, as well as decl.
12632 * lisp.h (create_process): Remove decl.
12633 * process.h (chan_process, Vprocess_alist): Remove decls.
12634
ad64fc97
PE
12635 * print.c: Make symbols static if they're not exported.
12636 (print_depth, new_backquote_output, being_printed, print_buffer):
12637 (print_buffer_size, print_buffer_pos, print_buffer_pos_byte):
12638 (print_interval, print_number_index, initial_stderr_stream):
12639 Now static.
12640 * lisp.h (Fprinc): Remove decl.
12641 (debug_output_compilation_hack): Mark as externally visible.
12642
adddb265
PE
12643 * sysdep.c (croak): Move decl from here to syssignal.h.
12644 * syssignal.h (croak): Put it here, so the API can be checked when
12645 'croak' is called from dissociate_if_controlling_tty.
12646
1717ede2
PE
12647 * minibuf.c: Make symbols static if they're not exported.
12648 (minibuf_save_list, choose_minibuf_frame): Now static.
12649 * lisp.h (choose_minibuf_frame): Remove decl.
12650
fa5fb2bc
PE
12651 * lisp.h (verify_bytepos, count_markers): Mark as externally visible.
12652
1e3890d1
PE
12653 * lread.c: Make symbols static if they're not exported.
12654 (read_objects, initial_obarray, oblookup_last_bucket_number):
12655 Now static.
12656 (make_symbol): Remove; unused.
12657 * lisp.h (initial_obarray, make_symbol): Remove decls.
12658
8a1414fa
PE
12659 * keyboard.c: Make symbols static if they're not exported.
12660 (single_kboard, recent_keys_index, total_keys, recent_keys):
12661 (this_command_key_count_reset, raw_keybuf, raw_keybuf_count):
12662 (this_single_command_key_start, echoing, last_auto_save):
12663 (read_key_sequence_cmd, dribble, recursive_edit_unwind):
12664 (command_loop, echo_now, keyboard_init_hook, help_char_p):
12665 (quit_throw_to_read_char, command_loop_2, top_level_1, poll_timer):
12666 (Vlispy_mouse_stem, double_click_count):
12667 Now static.
12668 (force_auto_save_soon): Define only if SIGDANGER.
12669 (ignore_mouse_drag_p): Now static if
12670 !defined HAVE_WINDOW_SYSTEM || defined USE_GTK || defined HAVE_NS.
12671 (print_help): Remove; unused.
12672 (stop_character, last_timer_event): Mark as externally visible.
12673 * keyboard.h (ignore_mouse_drag_p): Declare only if
12674 defined HAVE_WINDOW_SYSTEM && !defined USE_GTK && !defined HAVE_NS.
12675 (echo_now, help_char_p, quit_throw_to_read_char): Remove decls.
12676 * lisp.h (echoing): Remove decl.
12677 (force_auto_save_soon): Declare only if SIGDANGER.
12678 * xdisp.c (redisplay_window): Simplify code, to make it more
12679 obvious that ignore_mouse_drag_p is not accessed if !defined
12680 USE_GTK && !defined HAVE_NS.
12681
93ea6e8f
PE
12682 * intervals.c: Make symbols static if they're not exported.
12683 (merge_properties_sticky, merge_interval_right, delete_interval):
12684 Now static.
12685 * intervals.h (merge_interval_right, delete_interval): Remove decls.
12686
77382fcc
PE
12687 * insdel.c: Make symbols static if they're not exported.
12688 However, leave prepare_to_modify_buffer alone. It's never
12689 called from outside this function, but that appears to be a bug.
12690 (combine_after_change_list, combine_after_change_buffer):
4889fc82 12691 (adjust_after_replace, signal_before_change): Now static.
77382fcc
PE
12692 (adjust_after_replace_noundo): Remove; unused.
12693 * lisp.h (adjust_after_replace, adjust_after_replace_noundo):
4889fc82 12694 (signal_before_change): Remove decls.
77382fcc 12695
9306c32e
PE
12696 * indent.c (val_compute_motion, val_vmotion): Now static.
12697
cd44d2eb
PE
12698 * image.c: Make symbols static if they're not exported.
12699 * dispextern.h (x_create_bitmap_from_xpm_data): Do not declare
12700 if USE_GTK.
12701 * image.c (x_create_bitmap_from_xpm_data): Do not define if USE_GTK.
12702 (xpm_color_cache, ct_table, ct_colors_allocated): Now static.
12703
ad9a7a06
PE
12704 * fringe.c (standard_bitmaps): Now static.
12705 (max_used_fringe_bitmap): Now static, unless HAVE_NS.
12706
81626931
PE
12707 * frame.c: Make symbols static if they're not exported.
12708 (x_report_frame_params, make_terminal_frame): Now static.
12709 (get_frame_param): Now static, unless HAVE_NS.
12710 (x_fullscreen_adjust): Define if WINDOWSNT, not if HAVE_WINDOW_SYSTEM.
12711 (x_get_resource_string): Remove; not used.
12712 * frame.h (make_terminal_frame, x_report_frame_params):
12713 (x_get_resource_string); Remove decls.
12714 (x_fullscreen_adjust): Declare only if WINDOWSNT.
12715 * lisp.h (get_frame_param): Declare only if HAVE_NS.
12716
239f9db9
PE
12717 * font.c, fontset.c: Make symbols static if they're not exported.
12718 * dispextern.h (FACE_SUITABLE_FOR_ASCII_CHAR_P): New macro.
12719 (FACE_SUITABLE_FOR_CHAR_P): Use it.
12720 * font.c (font_close_object): Now static.
12721 * font.h (font_close_object): Remove.
12722 * fontset.c (FONTSET_OBJLIST): Remove.
12723 (free_realized_fontset) #if-0 the body, which does nothing.
12724 (face_suitable_for_char_p): #if-0, as it's never called.
12725 * fontset.h (face_suitable_for_char_p): Remove decl.
04f2d78b
CB
12726 * xfaces.c (face_at_string_position):
12727 Use FACE_SUITABLE_FOR_ASCII_CHAR_P, not FACE_SUITABLE_FOR_CHAR_P,
239f9db9
PE
12728 since 0 is always ASCII.
12729
dfcf3579
PE
12730 * fns.c (weak_hash_tables): Now static.
12731
5045092b
PE
12732 * fileio.c: Make symbols static if they're not exported.
12733 (auto_saving, auto_save_mode_bits, auto_save_error_occurred):
12734 (Vwrite_region_annotation_buffers): Now static.
12735
57a96f5c
PE
12736 * eval.c: Make symbols static if they're not exported.
12737 (backtrace_list, lisp_eval_depth, when_entered_debugger): Now static.
12738 * lisp.h (backtrace_list): Remove decl.
12739
35f08c38
PE
12740 * emacs.c: Make symbols static if they're not exported.
12741 (malloc_state_ptr, malloc_using_checking, syms_of_emacs):
12742 (fatal_error_code, fatal_error_signal_hook, standard_args):
12743 Now static.
12744 (fatal_error_signal): Now static, unless FLOAT_CATCH_SIGKILL.
12745 (DEFINE_DUMMY_FUNCTION): Mark function as externally visible.
12746 (__CTOR_LIST__, __DTOR_LIST__): Now externally visible.
12747 * lisp.h (fatal_error_signal_hook): Remove decl.
12748 (fatal_error_signal): Declare only if FLOAT_CATCH_SIGKILL.
12749
f44bd759
PE
12750 * editfns.c: Move a (normally-unused) function to its only use.
12751 * editfns.c, lisp.h (get_operating_system_release): Remove.
12752 * process.c (init_process) [DARWIN_OS]: Do it inline, as it is not
12753 worth the hassle of breaking this out.
12754
b532497d
PE
12755 * xterm.c: Make symbols static if they're not exported.
12756 (x_raise_frame, x_lower_frame, x_wm_set_window_state):
12757 (x_wm_set_icon_pixmap, x_initialize, XTread_socket_fake_io_error):
12758 (x_destroy_window, x_delete_display):
12759 Now static.
12760 (x_dispatch_event): Now static if ! (USE_MOTIF || USE_X_TOOLKIT).
12761 (x_mouse_leave): Remove; unused.
12762 * xterm.h (x_display_info_for_name, x_raise_frame, x_lower_frame):
12763 (x_destroy_window, x_wm_set_window_state, x_wm_set_icon_pixmap):
12764 (x_delete_display, x_initialize, x_set_border_pixel, x_screen_planes):
12765 Remove decls.
12766 (x_mouse_leave): Declare only if WINDOWSNT.
12767 (x_dispatch_event): Declare only if USE_MOTIF or USE_X_TOOLKIT.
12768 (xic_create_fontsetname): Declare only if HAVE_X_WINDOWS &&
12769 USE_X_TOOLKIT.
12770
1675728f
PE
12771 * ftxfont.c: Make symbols static if they're not exported.
12772 (ftxfont_driver): Export only if !defined HAVE_XFT && def8ined
12773 HAVE_FREETYPE.
12774 * font.h (ftxfont_driver): Likewise.
12775
e4cebfca
PE
12776 * xfns.c: Make symbols static if they're not exported.
12777 (x_last_font_name, x_display_info_for_name):
12778 (x_set_foreground_color, x_set_background_color, x_set_mouse_color):
12779 (x_set_cursor_color, x_set_border_pixel, x_set_border_color):
12780 (x_set_cursor_type, x_set_icon_type, x_set_icon_name):
12781 (x_set_scroll_bar_foreground, x_set_scroll_bar_background):
12782 (x_explicitly_set_name, x_set_title, xic_defaut_fontset, tip_timer):
12783 (last_show_tip_args): Now static.
12784 (xic_defaut_fontset, xic_create_fontsetname): Define only if
12785 defined HAVE_X_WINDOWS && defined USE_X_TOOLKIT
12786 (x_screen_planes): Remove; unused.
12787 * dispextern.h (x_screen_planes): Remove decl.
12788
5bf46f05
PE
12789 * dispnew.c: Make symbols static if they're not exported.
12790 * dispextern.h (redraw_garbaged_frames, scrolling):
12791 (increment_row_positions): Remove.
12792 * dispnew.c (new_glyph_matrix, increment_row_positions, scrolling):
12793 (delayed_size_change, glyph_matrix_count, glyph_pool_count):
12794 Now static.
12795 (redraw_garbaged_frames): Remove; unused.
12796
435f4c28
PE
12797 * xfaces.c: Make symbols static if they're not exported.
12798 * dispextern.h (ascii_face_of_lisp_face, free_realized_face):
12799 Remove decls.
12800 * xterm.h (defined_color): Remove decls.
12801 (x_free_dpy_colors): Declare only if USE_X_TOOLKIT.
12802 * xfaces.c (tty_suppress_bold_inverse_default_colors_p):
12803 (menu_face_changed_default, defined_color, free_realized_face):
12804 (x_free_dpy_colors): Define only if USE_X_TOOLKIT.
12805 (ascii_face_of_lisp_face): Remove; unused.
12806
8524aef3
PE
12807 * xdisp.c: Make symbols static if they're not exported.
12808 * dispextern.h (scratch_glyph_row, window_box_edges):
12809 (glyph_to_pixel_coords, set_cursor_from_row):
12810 (get_next_display_element, set_iterator_to_next):
12811 (highlight_trailing_whitespace, frame_to_window_pixel_xy):
12812 (show_mouse_face): Remove decls
12813 * frame.h (message_buf_print): Likewise.
12814 * lisp.h (pop_message, set_message, check_point_in_composition):
12815 Likewise.
12816 * xterm.h (set_vertical_scroll_bar): Likewise.
12817 * xdisp.c (list_of_error, Vmessage_stack, line_number_displayed):
12818 (message_buf_print, scratch_glyph_row, displayed_buffer):
12819 (set_iterator_to_next, pop_message, set_message, set_cursor_from_row):
12820 (get_next_display_element, show_mouse_face, window_box_edges):
12821 (frame_to_window_pixel_xy, check_point_in_composition):
12822 (set_vertical_scroll_bar, highlight_trailing_whitespace): Now static.
12823 (glyph_to_pixel_coords): Remove; unused.
12824
16390cd2
PE
12825 * dired.c (file_name_completion): Now static.
12826
12827 * dbusbind.c (xd_in_read_queued_messages): Now static.
12828
a25f4dfa
PE
12829 * lisp.h (circular_list_error, FOREACH): Remove; unused.
12830 * data.c (circular_list_error): Remove.
12831
14a9c8df
PE
12832 * commands.h (last_point_position, last_point_position_buffer):
12833 (last_point_position_window): Remove decls.
12834 * keyboard.c: Make these variables static.
12835
04f2d78b
CB
12836 * coding.h (coding, code_convert_region, encode_coding_gap):
12837 Remove decls.
74ab6df5
PE
12838 * coding.c (Vsjis_coding_system, Vbig5_coding_system):
12839 (iso_code_class, detect_coding, code_convert_region): Now static.
12840 (encode_coding_gap): Remove; unused.
12841
38dfbee1
PE
12842 * chartab.c (chartab_chars, chartab_bits): Now static.
12843
a2cb4e63
PE
12844 * charset.h (charset_iso_8859_1): Remove decl.
12845 * charset.c (charset_iso_8859_1, charset_emacs, map_charset_for_dump):
12846 Now static.
12847
127198fd
PE
12848 * ccl.h (check_ccl_update, Vccl_program_table): Remove decls.
12849 * ccl.c (Vccl_program_table): Now static.
12850 (check_ccl_update): Remove; unused.
12851
d85b608f
PE
12852 * category.c (SET_CATEGORY_SET, set_category_set): Move here.
12853 * category.h: ... from here.
12854 * category.c (check_category_table, set_category_set): Now static.
12855
31cd66f3
PE
12856 * casetab.c (Vascii_upcase_table, Vascii_eqv_table): Now static.
12857 * lisp.h: Remove these decls.
12858
c358e587
PE
12859 * buffer.c (buffer_count): Remove unused var.
12860
e78aecca
PE
12861 * bidi.c (bidi_dump_cached_states): Mark as externally visible,
12862 so that it's not optimized away.
12863 (bidi_ignore_explicit_marks_for_paragraph_level): Likewise.
12864 * dispextern.h (bidi_dump_cached_states): Remove, since it's
12865 exported only to the debugger.
12866
e192d7d3 12867 * atimer.c (alarm_signal_handler, run_all_atimers): Now static.
04f2d78b 12868 * atimer.h (run_all_atimers): Remove; not exported.
e192d7d3 12869
92470028
PE
12870 font.c: Make copy_font_spec and merge_font_spec ordinary C functions.
12871 * font.c (copy_font_spec): Rename from Fcopy_font_spec, since it
12872 was inaccessible from Lisp.
12873 (merge_font_spec): Likewise, renaming from Fmerge_font_spec.
12874 * font.c, font.h, fontset.c, xfaces.c, xfont.c: Change all uses.
12875
244ed907
PE
12876 alloc.c: Import and export fewer symbols, and remove unused items.
12877 * lisp.h (suppress_checking, die): Declare only if ENABLE_CHECKING
12878 is defined.
12879 (suppress_checking): Add EXTERNALLY_VISIBLE attribute, so that
12880 it's not optimized away by whole-program optimization.
12881 (message_enable_multibyte, free_misc): Remove.
12882 (catchlist, handlerlist, mark_backtrace):
12883 Declare only if BYTE_MARK_STACK.
12884 (mark_byte_stack): Likewise, fixing a ifdef-vs-if typo.
12885 * alloc.c (pure): Export only if VIRT_ADDR_VARIES is defined.
12886 (message_enable_multibyte): Remove decl.
12887 (free_misc, interval_free_list, float_block, float_block_index):
12888 (n_float_blocks, float_free_list, cons_block, cons_block_index):
12889 (cons_free_list, last_marked_index):
12890 Now static.
12891 (suppress_checking, die): Define only if ENABLE_CHECKING is defined.
12892 * eval.c (catchlist, handlerlist): Export only if BYTE_MARK_STACK.
12893 (mark_backtrace): Define only if BYTE_MARK_STACK.
12894 * xdisp.c (message_enable_multibyte): Now static.
12895
61c2b50e 12896 Declare Lisp_Object Q* variables to be 'static' if not exported.
955cbe7b
PE
12897 This makes it easier for human readers (and static analyzers)
12898 to see whether these variables are used from other modules.
12899 * alloc.c, buffer.c, bytecode.c, callint.c, casetab.c, category.c:
12900 * ccl.c, character.c, charset.c, cmds.c, coding.c, composite.c:
12901 * data.c, dbusbind.c, dired.c, editfns.c, eval.c, fileio.c, fns.c:
12902 * font.c, frame.c, fringe.c, ftfont.c, image.c, keyboard.c, keymap.c:
12903 * lread.c, macros.c, minibuf.c, print.c, process.c, search.c:
12904 * sound.c, syntax.c, textprop.c, window.c, xdisp.c, xfaces.c, xfns.c:
12905 * xmenu.c, xselect.c:
12906 Declare Q* vars static if they are not used in other modules.
12907 * ccl.h, character.h, charset.h, coding.h, composite.h, font.h:
12908 * frame.h, intervals.h, keyboard.h, lisp.h, process.h, syntax.h:
12909 Remove decls of unexported vars.
12910 * keyboard.h (EVENT_HEAD_UNMODIFIED): Remove now-unused macro.
12911
95c82688
PE
12912 * lisp.h (DEFINE_FUNC): Make sname 'static'.
12913
16a97296
PE
12914 Make Emacs functions such as Fatom 'static' by default.
12915 This makes it easier for human readers (and static analyzers)
12916 to see whether these functions can be called from other modules.
12917 DEFUN now defines a static function. To make the function external
12918 so that it can be used in other C modules, use the new macro DEFUE.
8bd7b830
PE
12919 * lisp.h (Funibyte_char_to_multibyte, Fsyntax_table_p):
12920 (Finit_image_library):
16a97296
PE
12921 (Feval_region, Fbacktrace, Ffetch_bytecode, Fswitch_to_buffer):
12922 (Ffile_executable_p, Fmake_symbolic_link, Fcommand_execute):
12923 (Fget_process, Fdocumentation_property, Fbyte_code, Ffile_attributes):
12924 Remove decls, since these functions are now static.
12925 (Funintern, Fget_internal_run_time): New decls, since these functions
12926 were already external.
95c82688 12927
16a97296
PE
12928 * alloc.c, buffer.c, callint.c, callproc.c, casefiddle.c, casetab.c:
12929 * ccl.c, character.c, chartab.c, cmds.c, coding.c, data.c, dispnew.c:
12930 * doc.c, editfns.c, emacs.c, eval.c, fileio.c, filelock.c, floatfns.c:
12931 * fns.c, font.c, fontset.c, frame.c, image.c, indent.c:
12932 * keyboard.c, keymap.c, lread.c:
12933 * macros.c, marker.c, menu.c, minibuf.c, print.c, process.c, search.c:
12934 * syntax.c, term.c, terminal.c, textprop.c, undo.c:
12935 * window.c, xdisp.c, xfaces.c, xfns.c, xmenu.c, xsettings.c:
12936 Mark functions with DEFUE instead of DEFUN,
12937 if they are used in other modules.
12938 * buffer.c (Fset_buffer_major_mode, Fdelete_overlay): New forward
12939 decls for now-static functions.
12940 * buffer.h (Fdelete_overlay): Remove decl.
12941 * callproc.c (Fgetenv_internal): Mark as internal.
12942 * composite.c (Fremove_list_of_text_properties): Remove decl.
12943 (Fcomposition_get_gstring): New forward static decl.
12944 * composite.h (Fcomposite_get_gstring): Remove decl.
12945 * dired.c (Ffile_attributes): New forward static decl.
12946 * doc.c (Fdocumntation_property): New forward static decl.
12947 * eval.c (Ffetch_bytecode): New forward static decl.
12948 (Funintern): Remove extern decl; now in .h file where it belongs.
12949 * fileio.c (Fmake_symbolic_link): New forward static decl.
12950 * image.c (Finit_image_library): New forward static decl.
12951 * insdel.c (Fcombine_after_change_execute): Make forward decl static.
12952 * intervals.h (Fprevious_property_change):
12953 (Fremove_list_of_text_properties): Remove decls.
12954 * keyboard.c (Fthis_command_keys): Remove decl.
12955 (Fcommand_execute): New forward static decl.
12956 * keymap.c (Flookup_key): New forward static decl.
12957 (Fcopy_keymap): Now static.
12958 * keymap.h (Flookup_key): Remove decl.
12959 * process.c (Fget_process): New forward static decl.
12960 (Fprocess_datagram_address): Mark as internal.
12961 * syntax.c (Fsyntax_table_p): New forward static decl.
12962 (skip_chars): Remove duplicate decl.
12963 * textprop.c (Fprevious_property_change): New forward static decl.
12964 * window.c (Fset_window_fringes, Fset_window_scroll_bars):
12965 Now internal.
12966 (Fset_window_margins, Fset_window_vscroll): New forward static decls.
12967 * window.h (Fset_window_vscroll, Fset_window_margins): Remove decls.
12968
785bbd42
PE
12969 * editfns.c (Fformat): Remove unreachable code.
12970
8b913b57
AS
129712011-04-14 Andreas Schwab <schwab@linux-m68k.org>
12972
12973 * fileio.c (Finsert_file_contents): Fix typo in 2005-05-13
12974 change. (Bug#8496)
12975
a6744a35
EZ
129762011-04-13 Eli Zaretskii <eliz@gnu.org>
12977
12978 * xdisp.c (handle_invisible_prop): Don't call bidi_paragraph_init
12979 when at ZV. (Bug#8487)
12980
e7974947
AS
129812011-04-12 Andreas Schwab <schwab@linux-m68k.org>
12982
baad03f0
AS
12983 * charset.c (Fclear_charset_maps): Use xfree instead of free.
12984 (Bug#8437)
12985 * keyboard.c (parse_tool_bar_item): Likewise.
12986 * sound.c (sound_cleanup, alsa_close): Likewise.
12987 * termcap.c (tgetent): Likewise.
12988 * xfns.c (x_default_font_parameter): Likewise.
12989 * xsettings.c (read_and_apply_settings): Likewise.
12990
e7974947
AS
12991 * alloc.c (overrun_check_malloc, overrun_check_realloc)
12992 (overrun_check_free): Protoize.
12993
28272684
PE
129942011-04-12 Paul Eggert <eggert@cs.ucla.edu>
12995
12996 * sysdep.c (emacs_read, emacs_write): Check for negative sizes
12997 since callers should never pass a negative size.
12998 Change the signature to match that of plain 'read' and 'write'; see
12999 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00397.html>.
13000 * lisp.h: Update prototypes of emacs_write and emacs_read.
13001
11997c76
EZ
130022011-04-11 Eli Zaretskii <eliz@gnu.org>
13003
13004 * xdisp.c (redisplay_window): Don't try to determine the character
13005 position of the scroll margin if the window start point w->startp
e896f03c 13006 is outside the buffer's accessible region. (Bug#8468)
11997c76 13007
8a2cbd72
EZ
130082011-04-10 Eli Zaretskii <eliz@gnu.org>
13009
13010 Fix write-region and its subroutines for buffers > 2GB.
13011 * fileio.c (a_write, e_write): Modify declaration of arguments and
13012 local variables to support buffers larger than 2GB.
13013 (Fcopy_file): Use EMACS_INT for return value of emacs_read.
13014
13015 * sysdep.c (emacs_write, emacs_read): Use ssize_t for last
13016 argument, local variables, and return value.
13017
13018 * lisp.h: Update prototypes of emacs_write and emacs_read.
13019
13020 * sound.c (vox_write): Use ssize_t for return value of emacs_write.
13021
4073e537 130222011-04-10 Paul Eggert <eggert@cs.ucla.edu>
eb3f1cc8 13023
1ebfdcb6
PE
13024 * xdisp.c (vmessage): Use memchr, not strnlen, which some hosts lack.
13025
b2ded58d
PE
13026 Fix more problems found by GCC 4.6.0's static checks.
13027
7d66342c
PE
13028 * xdisp.c (vmessage): Use a better test for character truncation.
13029
bbf47d44
PE
13030 * charset.c (load_charset_map): <, not <=, for optimization,
13031 and to avoid potential problems with integer overflow.
9248994d 13032 * chartab.c (sub_char_table_set_range, char_table_set_range): Likewise.
f9a68bc5 13033 * casetab.c (set_identity, shuffle): Likewise.
3ab1c7ce 13034 * editfns.c (Fformat): Likewise.
1e69125e 13035 * syntax.c (skip_chars): Likewise.
3befa583 13036
e3019616
PE
13037 * xmenu.c (set_frame_menubar): Allocate smaller local vectors.
13038 This also lets GCC 4.6.0 generate slightly better loop code.
13039
becfa255
PE
13040 * callint.c (Fcall_interactively): <, not <=, for optimization.
13041 (Fcall_interactively): Count the number of arguments produced,
13042 not the number of arguments given. This is simpler and lets GCC
13043 4.6.0 generate slightly better code.
13044
dae0cd48
PE
13045 * ftfont.c: Distingish more carefully between FcChar8 and char.
13046 The previous code passed unsigned char * to a functions like
13047 strlen and xstrcasecmp that expect char *, which does not
13048 conform to the C standard.
13049 (get_adstyle_property, ftfont_pattern_entity): Use FcChar8 for
13050 arguments to FcPatternGetString, and explicitly cast FcChar8 * to
13051 char * when the C standard requires it.
13052
76032d70
PE
13053 * keyboard.c (read_char): Remove unused var.
13054
eb3f1cc8
PE
13055 * eval.c: Port to Windows vsnprintf (Bug#8435).
13056 Include <limits.h>.
13057 (SIZE_MAX): Define if the headers do not.
13058 (verror): Do not give up if vsnprintf returns a negative count.
13059 Instead, grow the buffer. This ports to Windows vsnprintf, which
13060 does not conform to C99. Problem reported by Eli Zaretskii.
13061 Also, simplify the allocation scheme, by avoiding the need for
13062 calling realloc, and removing the ALLOCATED variable.
13063
70476b54
PE
13064 * eval.c (verror): Initial buffer size is 4000 (not 200) bytes.
13065
12020a9e
PE
13066 Remove invocations of doprnt, as Emacs now uses vsnprintf.
13067 But keep the doprint source code for now, as we might revamp it
13068 and use it again (Bug#8435).
ea6c7ae6
PE
13069 * lisp.h (doprnt): Remove.
13070 * Makefile.in (base_obj): Remove doprnt.o.
13071 * deps.mk (doprnt.o): Remove.
13072
5fdb398c
PE
13073 error: Print 32- and 64-bit integers portably (Bug#8435).
13074 Without this change, on typical 64-bit hosts error ("...%d...", N)
13075 was used to print both 32- and 64-bit integers N, which relied on
13076 undefined behavior.
61bdb816 13077 * lisp.h, m/amdx86-64.h, m/ia64.h, m/ibms390x.h (pEd): New macro.
5fdb398c
PE
13078 * lisp.h (error, verror): Mark as printf-like functions.
13079 * eval.c (verror): Use vsnprintf, not doprnt, to do the real work.
13080 Report overflow in size calculations when allocating printf buffer.
13081 Do not truncate output string at its first null byte.
13082 * xdisp.c (vmessage): Use vsnprintf, not doprnt, to do the real work.
13083 Truncate the output at a character boundary, since vsnprintf does not
13084 do that.
13085 * charset.c (check_iso_charset_parameter): Convert internal
13086 character to string before calling 'error', since %c now has the
13087 printf meaning.
13088 * coding.c (Fdecode_sjis_char, Fdecode_big5_char): Avoid int
13089 overflow when computing char to be passed to 'error'. Do not
13090 pass Lisp_Object to 'error'; pass the integer instead.
13091 * nsfns.m (Fns_do_applescript): Use int, not long, since it's
13092 formatted with plain %d.
13093
b189fa66
PE
13094 * eval.c (internal_lisp_condition_case): Don't pass spurious arg.
13095
bff87ef0
PE
13096 * keyboard.c (access_keymap_keyremap): Print func name, not garbage.
13097
7e2cac20
PE
13098 * coding.c (Fdecode_sjis_char): Don't assume CODE fits in int.
13099
ce4d90b5
PE
13100 * xterm.c (x_catch_errors): Remove duplicate declaration.
13101
266c9547
PE
13102 * term.c (maybe_fatal): Mark its 3rd arg as a printf format, too.
13103
79c49ad2
PE
13104 * xdisp.c, lisp.h (message_nolog): Remove; unused.
13105
368f4090
JM
131062011-04-10 Jim Meyering <meyering@redhat.com>
13107
13108 use ssize_t and size_t for read- and write-like emacs_gnutls_* functions
13109 * gnutls.c (emacs_gnutls_read): Adjust signature to be more read-like:
13110 return ssize_t not "int", and use size_t as the buffer length.
13111 (emacs_gnutls_write): Likewise, and make the buffer pointer "const".
13112 * gnutls.h: Update declarations.
13113 * process.c (read_process_output): Use ssize_t, to match.
13114 (send_process): Likewise.
13115
a32d4040
CY
131162011-04-09 Chong Yidong <cyd@stupidchicken.com>
13117
13118 * image.c (Fimagemagick_types): Doc fix, and comment cleanup.
13119
8546720e 131202011-04-09 Chong Yidong <cyd@stupidchicken.com>
aac0c6e3 13121
04f2d78b
CB
13122 * ftfont.c (get_adstyle_property, ftfont_pattern_entity):
13123 Use unsigned char, to match FcChar8 type definition.
aac0c6e3 13124
8546720e
GM
13125 * xterm.c (handle_one_xevent):
13126 * xmenu.c (create_and_show_popup_menu):
13127 * xselect.c (x_decline_selection_request)
13128 (x_reply_selection_request): Avoid type-punned deref of X events.
aac0c6e3 13129
0a2f5c1a 131302011-04-09 Eli Zaretskii <eliz@gnu.org>
a53e2e89
EZ
13131
13132 Fix some uses of `int' instead of EMACS_INT.
13133 * search.c (string_match_1, fast_string_match)
13134 (fast_c_string_match_ignore_case, fast_string_match_ignore_case)
13135 (scan_buffer, find_next_newline_no_quit)
13136 (find_before_next_newline, search_command, Freplace_match)
13137 (Fmatch_data): Make some `int' variables be EMACS_INT.
13138
13139 * xdisp.c (display_count_lines): 3rd argument and return value now
13140 EMACS_INT. All callers changed.
13141 (pint2hrstr): Last argument is now EMACS_INT.
13142
13143 * coding.c (detect_coding_utf_8, detect_coding_emacs_mule)
13144 (detect_coding_iso_2022, detect_coding_sjis, detect_coding_big5)
13145 (detect_coding_ccl, detect_coding_charset, decode_coding_utf_8)
13146 (decode_coding_utf_16, decode_coding_emacs_mule)
13147 (decode_coding_iso_2022, decode_coding_sjis, decode_coding_big5)
13148 (decode_coding_ccl, decode_coding_charset)
13149 <consumed_chars, consumed_chars_base>: Declare EMACS_INT.
13150 (decode_coding_iso_2022, decode_coding_emacs_mule)
13151 (decode_coding_sjis, decode_coding_big5, decode_coding_charset)
13152 <char_offset, last_offset>: Declare EMACS_INT.
13153 (encode_coding_utf_8, encode_coding_utf_16)
13154 (encode_coding_emacs_mule, encode_invocation_designation)
13155 (encode_designation_at_bol, encode_coding_iso_2022)
13156 (encode_coding_sjis, encode_coding_big5, encode_coding_ccl)
13157 (encode_coding_raw_text, encode_coding_charset) <produced_chars>:
13158 Declare EMACS_INT.
13159 (ASSURE_DESTINATION): Declare more_bytes EMACS_INT.
13160 (encode_invocation_designation): Last argument P_NCHARS is now
13161 EMACS_INT.
13162 (decode_eol): Declare pos_byte, pos, and pos_end EMACS_INT.
13163 (produce_chars): from_nchars and to_nchars are now EMACS_INT.
13164
13165 * coding.h (struct coding_system) <head_ascii>: Declare EMACS_INT.
13166 All users changed.
13167
13168 * ccl.c (Fccl_execute_on_string): Declare some variables
13169 EMACS_INT.
13170
8546720e 131712011-04-08 Samuel Thibault <sthibault@debian.org> (tiny change)
0080dc6b
SS
13172
13173 * term.c (init_tty): Fix incorrect ifdef placement (Bug#8450).
13174
4e19a977
CS
131752011-03-19 Christoph Scholtes <cschol2112@googlemail.com>
13176
13177 * process.c (Fformat_network_address): Doc fix.
13178
87302331
R
131792011-04-08 T.V. Raman <tv.raman.tv@gmail.com> (tiny change)
13180
ee7683eb 13181 * xml.c (parse_region): Avoid creating spurious whitespace nodes.
87302331 13182
cbb59342
CY
131832011-04-08 Chong Yidong <cyd@stupidchicken.com>
13184
13185 * keyboard.c (read_char): Call Lisp function help-form-show,
13186 instead of using internal_with_output_to_temp_buffer.
13187 (Qhelp_form_show): New var.
e0d38eeb 13188 (syms_of_keyboard): Use DEFSYM macro.
cbb59342
CY
13189
13190 * print.c (internal_with_output_to_temp_buffer): Function deleted.
13191
13192 * lisp.h (internal_with_output_to_temp_buffer): Remove prototype.
13193
e67a13ab
CY
131942011-04-06 Chong Yidong <cyd@stupidchicken.com>
13195
04f2d78b
CB
13196 * process.c (Flist_processes): Remove to Lisp.
13197 (list_processes_1): Delete.
e67a13ab 13198
973f782d
EZ
131992011-04-06 Eli Zaretskii <eliz@gnu.org>
13200
7c106b1e
EZ
13201 * msdos.c (careadlinkat, careadlinkatcwd): MS-DOS replacements.
13202
973f782d
EZ
13203 * w32.c (careadlinkat, careadlinkatcwd): New always-fail stubs.
13204
41cf7d1a 132052011-04-06 Paul Eggert <eggert@cs.ucla.edu>
27ccc379 13206
ca23cc88
PE
13207 Fix more problems found by GCC 4.6.0's static checks.
13208
f390e2d5
PE
13209 * xmenu.c (Fx_popup_dialog): Don't assume string is free of formats.
13210
42eea0d0
PE
13211 * menu.c (Fx_popup_menu): Don't assume error_name lacks printf formats.
13212
b69769da 13213 * lisp.h (message, message_nolog, fatal): Mark as printf-like.
1e973bc7 13214
f9541e84
PE
13215 * xdisp.c (vmessage): Mark as a printf-like function.
13216
13841b55
PE
13217 * term.c (vfatal, maybe_fatal): Mark as printf-like functions.
13218
c136c10f
PE
13219 * sound.c (sound_warning): Don't crash if arg contains a printf format.
13220
5e2d4a30
PE
13221 * image.c (tiff_error_handler, tiff_warning_handler): Mark as
13222 printf-like functions.
13223 (tiff_load): Add casts to remove these marks before passing them
13224 to system-supplied API.
13225
583f48b9
PE
13226 * eval.c (Fsignal): Remove excess argument to 'fatal'.
13227
b25d760e
PE
13228 * coding.c (EMIT_ONE_BYTE, EMIT_TWO_BYTES): Use unsigned, not int.
13229 This avoids several warnings with gcc -Wstrict-overflow.
d5efd1d1
PE
13230 (DECODE_COMPOSITION_RULE): If the rule is invalid, goto invalid_code
13231 directly, rather than having caller test rule sign. This avoids
13232 some unnecessary tests.
13233 * composite.h (COMPOSITION_ENCODE_RULE_VALID): New macro.
13234 (COMPOSITION_ENCODE_RULE): Arguments now must be valid. This
13235 affects only one use, in DECODE_COMPOSITION_RULE, which is changed.
b25d760e 13236
bc7b6697 13237 * xfont.c (xfont_text_extents): Remove var that was set but not used.
625a3eb1 13238 (xfont_open): Avoid unnecessary tests.
bc7b6697 13239
27ccc379
PE
13240 * composite.c (composition_gstring_put_cache): Use unsigned integer.
13241
dcd5c89a
PE
13242 * composite.h, composite.c (composition_gstring_put_cache):
13243 Use EMACS_INT, not int, for length.
13244
b13a45c6
PE
13245 * composite.h (COMPOSITION_DECODE_REFS): New macro,
13246 breaking out part of COMPOSITION_DECODE_RULE.
13247 (COMPOSITION_DECODE_RULE): Use it.
13248 * composite.c (get_composition_id): Remove unused local vars,
13249 by using the new macro.
13250
1e792e4d
PE
13251 * textprop.c (set_text_properties_1): Change while to do-while,
13252 since the condition is always true at first.
13253
dc6c6455 13254 * intervals.c (graft_intervals_into_buffer): Mark var as used.
aa86731f
PE
13255 (interval_deletion_adjustment): Return unsigned value.
13256 All uses changed.
dc6c6455 13257
aba7731a
PE
13258 * process.c (list_processes_1, create_pty, read_process_output):
13259 (exec_sentinel): Remove vars that were set but not used.
afd4052b 13260 (create_pty): Remove unnecessary "volatile"s.
bc57d757 13261 (Fnetwork_interface_info): Avoid possibility of int overflow.
82eaa333 13262 (read_process_output): Do adaptive read buffering even if carryover.
fe07cdfa 13263 (read_process_output): Simplify nbytes computation if buffered.
aba7731a 13264
fdfc4bf3
PE
13265 * bytecode.c (exec_byte_code): Rename local to avoid shadowing.
13266
fca8fe46 13267 * syntax.c (scan_words): Remove var that was set but not used.
12cbf13f 13268 (update_syntax_table): Use unsigned instead of int.
fca8fe46 13269
06a0259a 13270 * lread.c (lisp_file_lexically_bound_p): Use ints rather than endptrs.
3c346cc3 13271 (lisp_file_lexically_bound_p, read1): Use unsigned instead of int.
e6eb4e9e 13272 (safe_to_load_p): Make the end-of-loop test the inverse of the in-loop.
06a0259a 13273
e7b9e80f
PE
13274 * print.c (print_error_message): Avoid int overflow.
13275
56201685
PE
13276 * font.c (font_list_entities): Redo for clarity,
13277 so that reader need not know FONT_DPI_INDEX + 1 == FONT_SPACING_INDEX.
13278
78834453 13279 * font.c (font_find_for_lface, Ffont_get_glyphs): Remove unused vars.
790771b1 13280 (font_score): Avoid potential overflow in diff calculation.
78834453 13281
0bc0b309 13282 * fns.c (substring_both): Remove var that is set but not used.
8cd55cb4 13283 (sxhash): Redo loop for clarity and to avoid wraparound warning.
0bc0b309 13284
e610eaca
PE
13285 * eval.c (funcall_lambda): Rename local to avoid shadowing.
13286
b895abce
PE
13287 * alloc.c (mark_object_loop_halt, mark_object): Use size_t, not int.
13288 Otherwise, GCC 4.6.0 optimizes the loop check away since the check
13289 can always succeed if overflow has undefined behavior.
13290
1f1d9321 13291 * search.c (boyer_moore, wordify): Remove vars set but not used.
6f076cc7 13292 (wordify): Omit three unnecessary tests.
1f1d9321 13293
c59478bc
PE
13294 * indent.c (MULTIBYTE_BYTES_WIDTH): Don't compute wide_column.
13295 All callers changed. This avoids the need for an unused var.
13296
79b73827
PE
13297 * casefiddle.c (casify_region): Remove var that is set but not used.
13298
a4db5dfe
PE
13299 * dired.c (file_name_completion): Remove var that is set but not used.
13300
43aae36e
PE
13301 * fileio.c (Finsert_file_contents): Make EOF condition clearer.
13302
2a47c44d 13303 * fileio.c (Finsert_file_contents): Avoid signed integer overflow.
163c5f32 13304 (Finsert_file_contents): Remove unnecessary code checking fd.
2a47c44d 13305
a37c69bf
PE
13306 * minibuf.c (read_minibuf_noninteractive): Use size_t for sizes.
13307 Check for integer overflow on size calculations.
13308
328ab8e7
PE
13309 * buffer.c (Fprevious_overlay_change): Remove var that is set
13310 but not used.
13311
e5a2a5cb
PE
13312 * keyboard.c (menu_bar_items, read_char_minibuf_menu_prompt):
13313 Remove vars that are set but not used.
8d84a6eb 13314 (timer_check_2): Don't assume timer-list and idle-timer-list are lists.
6b043475 13315 (timer_check_2): Mark vars as initialized.
e5a2a5cb 13316
a60e5f68
PE
13317 * gtkutil.c (xg_get_file_with_chooser): Mark var as initialized.
13318
f661cb61 13319 * image.c (lookup_image): Remove var that is set but not used.
35fa624f 13320 (xbm_load): Use parse_p, for gcc -Werror=unused-but-set-variable.
f661cb61 13321
f0397f5a
PE
13322 * fontset.c (Finternal_char_font, Ffontset_info): Remove vars
13323 that are set but not used.
13324
8664db06 13325 * xfns.c (make_invisible_cursor): Don't return garbage
03733ee7 13326 if XCreateBitmapFromData fails (Bug#8410).
8664db06 13327
6abdaa4a
PE
13328 * xselect.c (x_get_local_selection, x_handle_property_notify):
13329 Remove vars that are set but not used.
13330
0ce7538d 13331 * xfns.c (x_create_tip_frame): Remove var that is set but not used.
6abdaa4a 13332 (make_invisible_cursor): Initialize a possibly-uninitialized variable.
0ce7538d 13333
9ae848fc
PE
13334 * xterm.c (x_scroll_bar_to_input_event) [!USE_GTK]:
13335 Remove var that is set but not used.
0b918413
PE
13336 (scroll_bar_windows_size): Now size_t, not int.
13337 (x_send_scroll_bar_event): Use size_t, not int, for sizes.
13338 Check for overflow.
9ae848fc 13339
a5a62657
PE
13340 * xfaces.c (realize_named_face): Remove vars that are set but not used.
13341 (map_tty_color) [!defined MSDOS]: Likewise.
13342
5c5cdd39
PE
13343 * term.c (tty_write_glyphs): Use size_t; this avoids overflow warning.
13344
66ebf983
PE
13345 * coding.c: Remove vars that are set but not used.
13346 (DECODE_COMPOSITION_RULE): Remove 2nd arg, which is unused.
13347 All callers changed.
13348 (decode_coding_utf_8, decode_coding_utf_16 decode_coding_emacs_mule):
13349 (decode_coding_iso_2022, encode_coding_sjis, encode_coding_big5):
13350 (decode_coding_charset): Remove vars that are set but not used.
13351
1be4d761
PE
13352 * bytecode.c (Fbyte_code) [!defined BYTE_CODE_SAFE]: Remove var
13353 that is set but not used.
13354
47553fa8
PE
13355 * print.c (print_object): Remove var that is set but not used.
13356
1f7196bf 13357 Replace 2 copies of readlink code with 1 gnulib version (Bug#8401).
d1fdcab7
PE
13358 The gnulib version avoids calling malloc in the usual case,
13359 and on 64-bit hosts doesn't have some arbitrary 32-bit limits.
13360 * fileio.c (Ffile_symlink_p): Use emacs_readlink.
13361 * filelock.c (current_lock_owner): Likewise.
13362 * lisp.h (READLINK_BUFSIZE, emacs_readlink): New function.
13363 * sysdep.c: Include allocator.h, careadlinkat.h.
13364 (emacs_no_realloc_allocator): New static constant.
13365 (emacs_readlink): New function.
fdb61804
PE
13366 * deps.mk (sysdep.o): Depend on ../lib/allocator.h and on
13367 ../lib/careadlinkat.h.
d1fdcab7 13368
f84c17c7
SM
133692011-04-04 Stefan Monnier <monnier@iro.umontreal.ca>
13370
13371 * keyboard.c (safe_run_hook_funcall): Fix last change (don't stop at the
13372 first non-nil return value).
13373
ef3862ad
JD
133742011-04-03 Jan Djärv <jan.h.d@swipnet.se>
13375
13376 * nsterm.m (ns_update_auto_hide_menu_bar): Define MAC_OS_X_VERSION_10_6
13377 if not defined (Bug#8403).
13378
376a7006
JB
133792011-04-02 Juanma Barranquero <lekktu@gmail.com>
13380
13381 * xdisp.c (display_count_lines): Remove parameter `start',
13382 unused since 1998-01-01T02:27:27Z!rms@gnu.org. All callers changed.
13383 (get_char_face_and_encoding): Remove parameter `multibyte_p',
13384 unused since 2008-05-14T01:40:23Z!handa@m17n.org. All callers changed.
13385 (fill_stretch_glyph_string): Remove parameters `row' and `area',
13386 unused at least since Kim's GUI unification at 2003-03-16T20:45:46Z!storm@cua.dk
13387 and thereabouts. All callers changed.
13388 (get_per_char_metric): Remove parameter `f', unused since
13389 2008-05-14T01:40:23Z!handa@m17n.org. All callers changed.
13390
6ca3801d
JM
133912011-04-02 Jim Meyering <meyering@redhat.com>
13392
13393 do not dereference NULL upon failed strdup
13394 * nsfont.m (ns_descriptor_to_entity): Use xstrdup, not strdup.
13395 (ns_get_family): Likewise.
13396
d8e2b5ba
JB
133972011-04-02 Juanma Barranquero <lekktu@gmail.com>
13398
13399 * eval.c (unwind_to_catch) [DEBUG_GCPRO]: Remove redundant assignment.
13400
8c74fcbd
JD
134012011-04-02 Jan Djärv <jan.h.d@swipnet.se>
13402
13403 * nsterm.m (ns_update_auto_hide_menu_bar): Only for OSX 10.6 or
13404 later (Bug#8403).
13405
7200d79c
SM
134062011-04-01 Stefan Monnier <monnier@iro.umontreal.ca>
13407
03408648 13408 Add lexical binding.
7200d79c 13409
03408648
SM
13410 * window.c (Ftemp_output_buffer_show): New fun.
13411 (Fsave_window_excursion):
13412 * print.c (Fwith_output_to_temp_buffer): Move to subr.el.
13413
13414 * lread.c (lisp_file_lexically_bound_p): New function.
13415 (Fload): Bind Qlexical_binding.
13416 (readevalloop): Remove `evalfun' arg.
13417 Bind Qinternal_interpreter_environment.
13418 (Feval_buffer): Bind Qlexical_binding.
13419 (defvar_int, defvar_bool, defvar_lisp_nopro, defvar_kboard):
13420 Mark as dynamic.
13421 (syms_of_lread): Declare `lexical-binding'.
13422
13423 * lisp.h (struct Lisp_Symbol): New field `declared_special'.
13424
13425 * keyboard.c (eval_dyn): New fun.
13426 (menu_item_eval_property): Use it.
ca105506
SM
13427
13428 * image.c (parse_image_spec): Use Ffunctionp.
ca105506 13429
03408648
SM
13430 * fns.c (concat, mapcar1): Accept byte-code-functions.
13431
13432 * eval.c (Fsetq): Handle lexical vars.
13433 (Fdefun, Fdefmacro, Ffunction): Make closures when needed.
13434 (Fdefconst, Fdefvaralias, Fdefvar): Mark as dynamic.
13435 (FletX, Flet): Obey lexical binding.
13436 (Fcommandp): Handle closures.
13437 (Feval): New `lexical' arg.
13438 (eval_sub): New function extracted from Feval. Use it almost
13439 everywhere where Feval was used. Look up vars in lexical env.
13440 Handle closures.
13441 (Ffunctionp): Move from subr.el.
13442 (Ffuncall): Handle closures.
13443 (apply_lambda): Remove `eval_flags'.
13444 (funcall_lambda): Handle closures and new byte-code-functions.
13445 (Fspecial_variable_p): New function.
13446 (syms_of_eval): Initialize the Vinternal_interpreter_environment var,
13447 but without exporting it to Lisp.
23aba0ea 13448
23aba0ea 13449 * doc.c (Fdocumentation, store_function_docstring):
03408648 13450 * data.c (Finteractive_form): Handle closures.
23aba0ea 13451
03408648
SM
13452 * callint.c (Fcall_interactively): Preserve lexical-binding mode for
13453 interactive spec.
ba83908c 13454
04f2d78b
CB
13455 * bytecode.c (Bstack_ref, Bstack_set, Bstack_set2, BdiscardN):
13456 New byte-codes.
03408648
SM
13457 (exec_byte_code): New function extracted from Fbyte_code to handle new
13458 calling convention for byte-code-functions. Add new byte-codes.
ba83908c 13459
03408648 13460 * buffer.c (defvar_per_buffer): Set new `declared_special' field.
e2abe5a1 13461
03408648 13462 * alloc.c (Fmake_symbol): Init new `declared_special' field.
e2abe5a1 13463
e2abce01
JB
134642011-03-31 Juanma Barranquero <lekktu@gmail.com>
13465
13466 * xdisp.c (redisplay_internal): Fix prototype.
13467
63696a73 134682011-03-31 Eli Zaretskii <eliz@gnu.org>
09725d26 13469
63696a73 13470 * xdisp.c (SCROLL_LIMIT): New macro.
04f2d78b
CB
13471 (try_scrolling): Use it when setting scroll_limit.
13472 Limit scrolling to 100 screen lines.
63696a73
EZ
13473 (redisplay_window): Even when falling back on "recentering",
13474 position point in the window according to scroll-conservatively,
13475 scroll-margin, and scroll-*-aggressively variables. (Bug#6671)
13476
13477 (try_scrolling): When point is above the window, allow searching
13478 as far as scroll_max, or one screenful, to compute vertical
13479 distance from PT to the scroll margin position. This prevents
13480 try_scrolling from unnecessarily failing when
13481 scroll-conservatively is set to a value slightly larger than the
13482 window height. Clean up the case of PT below the margin at bottom
13483 of window: scroll_max can no longer be INT_MAX. When aggressive
13484 scrolling is in use, don't let point enter the opposite scroll
13485 margin as result of the scroll.
13486 (syms_of_xdisp) <scroll-conservatively>: Document the
09725d26
EZ
13487 threshold of 100 lines for never-recentering scrolling.
13488
e4cc2dfc
JB
134892011-03-31 Juanma Barranquero <lekktu@gmail.com>
13490
13491 * dispextern.h (move_it_by_lines):
13492 * xdisp.c (move_it_by_lines): Remove parameter `need_y_p', unused
13493 since 2000-12-29T14:24:09Z!gerd@gnu.org. All callers changed.
13494 (message_log_check_duplicate): Remove parameters `prev_bol' and
13495 `this_bol', unused since 1998-01-01T02:27:27Z!rms@gnu.org. All callers changed.
13496 (redisplay_internal): Remove parameter `preserve_echo_area',
13497 unused since 1999-07-21T21:43:52Z!gerd@gnu.org. All callers changed.
13498
13499 * indent.c (Fvertical_motion):
13500 * window.c (window_scroll_pixel_based, Frecenter):
13501 Don't pass `need_y_p' to `move_it_by_lines'.
13502
1c470562
SM
135032011-03-30 Stefan Monnier <monnier@iro.umontreal.ca>
13504
44f230aa
SM
13505 * eval.c (struct backtrace): Don't cheat with negative numbers, but do
13506 steal a few bits to be more compact.
13507 (interactive_p, Fbacktrace, Fbacktrace_frame, mark_backtrace):
13508 Remove unneeded casts.
13509
1c470562
SM
13510 * bytecode.c (Fbyte_code): CAR and CDR can GC.
13511
888adce9
ZK
135122011-03-30 Zachary Kanfer <zkanfer@gmail.com> (tiny change)
13513
13514 * keyboard.c (Fexecute_extended_command): Do log the "suggest key
13515 binding" message (bug#7967).
13516
f838ed7b
PE
135172011-03-30 Paul Eggert <eggert@cs.ucla.edu>
13518
77861b95
PE
13519 Fix more problems found by GCC 4.6.0's static checks.
13520
de6dbc14
PE
13521 * unexelf.c (unexec) [! (defined _SYSTYPE_SYSV || defined __sgi)]:
13522 Remove unused local var.
13523
f838ed7b
PE
13524 * editfns.c (Fmessage_box): Remove unused local var.
13525
792c7b2b
PE
13526 * xdisp.c (try_window_reusing_current_matrix, x_produce_glyphs):
13527 (note_mode_line_or_margin_highlight, note_mouse_highlight):
13528 Omit unused local vars.
c499e557 13529 * window.c (shrink_windows): Omit unused local var.
b01a1c29 13530 * menu.c (digest_single_submenu): Omit unused local var.
0bc32927
PE
13531 * dispnew.c (update_window) [PERIODIC_PREEMPTION_CHECKING]:
13532 Omit unused local var.
13533
ba0165e1
PE
13534 * keyboard.c (parse_modifiers_uncached, parse_modifiers):
13535 Don't assume string length fits in int.
32ad8845 13536 (keyremap_step, read_key_sequence): Use size_t for sizes.
48011560 13537 (read_key_sequence): Don't check last_real_key_start redundantly.
ba0165e1 13538
3c59b4c9
PE
13539 * callproc.c (Fcall_process, Fcall_process_region): Use SAFE_ALLOCA
13540 instead of alloca (Bug#8344).
13541
a3eed478 13542 * eval.c (Fbacktrace): Don't assume nargs fits in int.
5d5d959d 13543 (Fbacktrace_frame): Don't assume nframes fits in int.
a3eed478 13544
eb4d412d
PE
13545 * syntax.c (scan_sexps_forward): Avoid pointer wraparound.
13546
1658b401
PE
13547 * xterm.c (x_make_frame_visible, same_x_server): Redo to avoid overflow
13548 concerns.
13549
13550 * term.c (produce_glyphless_glyph): Remove unnecessary test.
13551
13552 * cm.c (calccost): Turn while-do into do-while, for clarity.
44f730c8 13553
9a2c6e05
PE
13554 * keyboard.c (syms_of_keyboard): Use the same style as later
13555 in this function when indexing through an array. This also
13556 works around GCC bug 48267.
13557
03d0a109
PE
13558 * image.c (tiff_load): Fix off-by-one image count (Bug#8336).
13559
44f730c8
PE
13560 * xselect.c (x_check_property_data): Return correct size (Bug#8335).
13561
fe75f926
PE
13562 * chartab.c (sub_char_table_ref_and_range): Redo for slight
13563 efficiency gain, and to bypass a gcc -Wstrict-overflow warning.
13564
ffa8c828
PE
13565 * keyboard.c, keyboard.h (num_input_events): Now size_t.
13566 This avoids undefined behavior on integer overflow, and is a bit
13567 more convenient anyway since it is compared to a size_t variable.
13568
c5101a77
PE
13569 Variadic C functions now count arguments with size_t, not int.
13570 This avoids an unnecessary limitation on 64-bit machines, which
13571 caused (substring ...) to crash on large vectors (Bug#8344).
13572 * lisp.h (struct Lisp_Subr.function.aMANY): Now takes size_t, not int.
13573 (DEFUN_ARGS_MANY, internal_condition_case_n, safe_call): Likewise.
77861b95 13574 All variadic functions and their callers changed accordingly.
c5101a77
PE
13575 (struct gcpro.nvars): Now size_t, not int. All uses changed.
13576 * data.c (arith_driver, float_arith_driver): Likewise.
13577 * editfns.c (general_insert_function): Likewise.
13578 * eval.c (struct backtrace.nargs, interactive_p)
13579 (internal_condition_case_n, run_hook_with_args, apply_lambda)
13580 (funcall_lambda, mark_backtrace): Likewise.
13581 * fns.c (concat): Likewise.
13582 * frame.c (x_set_frame_parameters): Likewise.
13583 * fns.c (get_key_arg): Now accepts and returns size_t, and returns
13584 0 if not found, not -1. All callers changed.
13585
dd3f25f7
PE
13586 * alloc.c (garbage_collect): Don't assume stack size fits in int.
13587 (stack_copy_size): Now size_t, not int.
13588 (stack_copy, stack_copy_size): Define only if MAX_SAVE_STACK > 0.
13589
461c2ab9
JB
135902011-03-28 Juanma Barranquero <lekktu@gmail.com>
13591
13592 * coding.c (encode_designation_at_bol): Remove parameter `charbuf_end',
13593 unused since 2002-03-01T01:17:24Z!handa@m17n.org and 2008-02-01T16:01:31Z!miles@gnu.org.
13594 All callers changed.
13595
13596 * lisp.h (multibyte_char_to_unibyte):
13597 * character.c (multibyte_char_to_unibyte): Remove parameter `rev_tbl',
13598 unused since 2002-03-01T01:16:34Z!handa@m17n.org and 2008-02-01T16:01:31Z!miles@gnu.org.
13599 * character.h (CHAR_TO_BYTE8):
13600 * cmds.c (internal_self_insert):
13601 * editfns.c (general_insert_function):
13602 * keymap.c (push_key_description):
13603 * search.c (Freplace_match):
13604 * xdisp.c (message_dolog, set_message_1): All callers changed.
13605
f6d62986
SM
136062011-03-28 Stefan Monnier <monnier@iro.umontreal.ca>
13607
13608 * keyboard.c (safe_run_hook_funcall): New function.
13609 (safe_run_hooks_1, safe_run_hooks_error, safe_run_hooks): On error,
13610 don't set the hook to nil, but remove the offending function instead.
13611 (Qcommand_hook_internal): Remove, unused.
13612 (syms_of_keyboard): Don't initialize Qcommand_hook_internal nor define
13613 Vcommand_hook_internal.
13614
13615 * eval.c (enum run_hooks_condition): Remove.
13616 (funcall_nil, funcall_not): New functions.
13617 (run_hook_with_args): Call each function through a `funcall' argument.
13618 Remove `cond' argument, now redundant.
13619 (Frun_hooks, Frun_hook_with_args, Frun_hook_with_args_until_success)
13620 (Frun_hook_with_args_until_failure): Adjust accordingly.
13621 (run_hook_wrapped_funcall, Frun_hook_wrapped): New functions.
13622
1db5b1ad
JB
136232011-03-28 Juanma Barranquero <lekktu@gmail.com>
13624
13625 * dispextern.h (string_buffer_position): Remove declaration.
13626
13627 * print.c (strout): Remove parameter `multibyte', unused since
13628 1999-08-21T19:30:21Z!gerd@gnu.org. All callers changed.
13629
13630 * search.c (boyer_moore): Remove parameters `len', `pos' and `lim',
13631 never used since function introduction in 1998-02-08T21:33:56Z!rms@gnu.org.
13632 All callers changed.
13633
13634 * w32.c (_wsa_errlist): Use braces for struct initializers.
13635
13636 * xdisp.c (string_buffer_position_lim): Remove parameter `w',
13637 never used since function introduction in 2001-03-09T18:41:50Z!gerd@gnu.org.
13638 All callers changed.
13639 (string_buffer_position): Likewise. Also, make static (it's never
13640 used outside xdisp.c).
13641 (cursor_row_p): Remove parameter `w', unused since
13642 2000-10-17T16:08:57Z!gerd@gnu.org. All callers changed.
13643 (decode_mode_spec): Remove parameter `precision', introduced during
13644 Gerd Moellmann's rewrite at 1999-07-21T21:43:52Z!gerd@gnu.org, but never used.
13645 All callers changed.
13646
5ffb62aa
JD
136472011-03-27 Jan Djärv <jan.h.d@swipnet.se>
13648
13649 * nsterm.m (syms_of_nsterm): Use doc: for ns-auto-hide-menu-bar.
13650
461c2ab9 136512011-03-27 Anders Lindgren <andlind@gmail.com>
f0a1382a
JD
13652
13653 * nsterm.m (ns_menu_bar_is_hidden): New variable.
13654 (ns_constrain_all_frames, ns_menu_bar_should_be_hidden)
13655 (ns_update_auto_hide_menu_bar): New functions.
13656 (ns_update_begin): Call ns_update_auto_hide_menu_bar.
13657 (applicationDidBecomeActive): Call ns_update_auto_hide_menu_bar and
13658 ns_constrain_all_frames.
13659 (constrainFrameRect): Return at once if ns_menu_bar_should_be_hidden.
13660 (syms_of_nsterm): DEFVAR ns-auto-hide-menu-bar, init to Qnil.
13661
5c380ffb
JD
136622011-03-27 Jan Djärv <jan.h.d@swipnet.se>
13663
13664 * nsmenu.m (runDialogAt): Remove argument to timer_check.
13665
9af30bdf
GM
136662011-03-27 Glenn Morris <rgm@gnu.org>
13667
13668 * syssignal.h: Replace RETSIGTYPE with void.
13669 * atimer.c, data.c, dispnew.c, emacs.c, floatfns.c, keyboard.c:
13670 * keyboard.h, lisp.h, process.c, sysdep.c, xterm.c:
13671 Replace SIGTYPE with void everywhere.
13672 * s/usg5-4-common.h (SIGTYPE): Remove definition.
13673 * s/template.h (SIGTYPE): Remove commented out definition.
13674
e2abce01
JB
136752011-03-26 Eli Zaretskii <eliz@gnu.org>
13676
13677 * xdisp.c (redisplay_window): Don't check buffer's clip_changed
13678 flag as a prerequisite for invoking try_scrolling. (Bug#6671)
13679
f868cd8a
JB
136802011-03-26 Juanma Barranquero <lekktu@gmail.com>
13681
59eb0929
JB
13682 * w32.c (read_unc_volume): Use parameter `henum', instead of
13683 global variable `wget_enum_handle'.
13684
13685 * keymap.c (describe_vector): Remove parameters `indices' and
13686 `char_table_depth', unused since 2002-03-01T01:43:26Z!handa@m17n.org.
13687 (describe_map, Fdescribe_vector): Adjust calls to `describe_vector'.
13688
f868cd8a
JB
13689 * keyboard.h (timer_check, show_help_echo): Remove unused parameters.
13690
13691 * keyboard.c (timer_check): Remove parameter `do_it_now',
13692 unused since 1996-04-12T06:01:29Z!rms@gnu.org.
13693 (show_help_echo): Remove parameter `ok_to_overwrite_keystroke_echo',
13694 unused since 2008-04-19T19:30:53Z!monnier@iro.umontreal.ca.
13695
13696 * keyboard.c (read_char):
13697 * w32menu.c (w32_menu_display_help):
13698 * xmenu.c (show_help_event, menu_help_callback):
13699 Adjust calls to `show_help_echo'.
13700
13701 * gtkutil.c (xg_maybe_add_timer):
13702 * keyboard.c (readable_events):
13703 * process.c (wait_reading_process_output):
13704 * xmenu.c (x_menu_wait_for_event): Adjust calls to `timer_check'.
13705
13706 * insdel.c (adjust_markers_gap_motion):
13707 Remove; no-op since 1998-01-02T21:29:48Z!rms@gnu.org.
13708 (gap_left, gap_right): Don't call it.
13709
2ecf6fdb
CY
137102011-03-25 Chong Yidong <cyd@stupidchicken.com>
13711
13712 * xdisp.c (handle_fontified_prop): Discard changes to clip_changed
13713 incurred during fontification.
13714
6b1f9ba4
JB
137152011-03-25 Juanma Barranquero <lekktu@gmail.com>
13716
13717 * buffer.c (defvar_per_buffer): Remove unused parameter `doc'.
13718 (DEFVAR_PER_BUFFER): Don't pass it.
13719
13720 * dispnew.c (row_equal_p, add_row_entry): Remove unused parameter `w'.
13721 (scrolling_window): Don't pass it.
13722
0f4a96b5
JB
137232011-03-25 Juanma Barranquero <lekktu@gmail.com>
13724
13725 * dispextern.h (glyph_matric): Use #if GLYPH_DEBUG, not #ifdef.
13726
13727 * fileio.c (check_executable) [DOS_NT]: Remove unused variables `len'
13728 and `suffix'.
13729 (Fset_file_selinux_context) [HAVE_LIBSELINUX]: Move here declaration
13730 of variables specific to SELinux and computation of `encoded_absname'.
13731
13732 * image.c (XPutPixel): Remove unused variable `height'.
13733
13734 * keyboard.c (make_lispy_event): Remove unused variable `hpos'.
13735
13736 * unexw32.c (get_section_info): Remove unused variable `section'.
13737
13738 * w32.c (stat): Remove unused variables `drive_root' and `devtype'.
13739 (system_process_attributes): Remove unused variable `sess'.
13740 (sys_read): Remove unused variable `err'.
13741
13742 * w32fns.c (top): Wrap variables with #if GLYPH_DEBUG, not #ifdef.
13743 (w32_wnd_proc): Remove unused variable `isdead'.
13744 (unwind_create_frame): Use #if GLYPH_DEBUG, not #ifdef.
13745 (Fx_server_max_request_size): Remove unused variable `dpyinfo'.
13746 (x_create_tip_frame): Remove unused variable `tem'.
13747
13748 * w32inevt.c (w32_console_read_socket):
13749 Remove unused variable `no_events'.
13750
13751 * w32term.c (x_draw_composite_glyph_string_foreground):
13752 Remove unused variable `width'.
13753
1149507c
JB
137542011-03-24 Juanma Barranquero <lekktu@gmail.com>
13755
13756 * w32term.c (x_set_glyph_string_clipping):
13757 Don't pass uninitialized region to CombineRgn.
13758
9c88f339
JB
137592011-03-23 Juanma Barranquero <lekktu@gmail.com>
13760
13761 * w32fns.c (x_set_menu_bar_lines): Remove unused variable `olines'.
13762 (w32_wnd_proc): Pass NULL to Windows API, not uninitialized buffer.
13763 (Fx_close_connection): Remove unused variable `i'.
13764
13765 * w32font.c (w32font_draw): Return number of glyphs.
13766 (w32font_open_internal): Remove unused variable `i'.
13767 (w32font_driver): Add missing initializer.
13768
13769 * w32menu.c (utf8to16): Remove unused variable `utf16'.
13770 (fill_in_menu): Remove unused variable `items_added'.
13771
13772 * w32term.c (last_mouse_press_frame): Remove static global variable.
13773 (w32_clip_to_row): Remove unused variable `f'.
13774 (x_delete_terminal): Remove unused variable `i'.
13775
13776 * w32uniscribe.c (uniscribe_shape): Remove unused variable `nclusters'.
13777 (NOTHING): Remove unused static global variable.
13778 (uniscribe_check_otf): Remove unused variable `table'.
13779 (uniscribe_font_driver): Add missing initializers.
13780
dee091a3
JD
137812011-03-23 Julien Danjou <julien@danjou.info>
13782
13783 * term.c (Fsuspend_tty, Fresume_tty):
13784 * minibuf.c (read_minibuf, run_exit_minibuf_hook):
13785 * window.c (temp_output_buffer_show):
13786 * insdel.c (signal_before_change):
13787 * frame.c (Fhandle_switch_frame):
13788 * fileio.c (Fdo_auto_save):
13789 * emacs.c (Fkill_emacs):
13790 * editfns.c (save_excursion_restore):
13791 * cmds.c (internal_self_insert):
13792 * callint.c (Fcall_interactively):
13793 * buffer.c (Fkill_all_local_variables):
13794 * keyboard.c (Fcommand_execute, Fsuspend_emacs, safe_run_hooks_1):
13795 Use Frun_hooks.
0f4a96b5 13796 (command_loop_1): Use Frun_hooks. Call safe_run_hooks
e9fce1ac 13797 unconditionally since it does the check itself.
dee091a3 13798
2c520ab5 137992011-03-23 Paul Eggert <eggert@cs.ucla.edu>
f0641eff 13800
c9c49752
PE
13801 Fix more problems found by GCC 4.5.2's static checks.
13802
8abc3f12
PE
13803 * coding.c (encode_coding_raw_text): Avoid unnecessary test
13804 the first time through the loop, since we know p0 < p1 then.
13805 This also avoids a gcc -Wstrict-overflow warning.
13806
a2d26660
PE
13807 * lisp.h (SAFE_ALLOCA, SAFE_ALLOCA_LISP): Avoid 'int' overflow
13808 leading to a memory leak, possible in functions like
13809 load_charset_map_from_file that can allocate an unbounded number
b12ef411 13810 of objects (Bug#8318).
a2d26660 13811
916c72e9
PE
13812 * xmenu.c (set_frame_menubar): Use EMACS_UINT, not int, for indexes
13813 that could (at least in theory) be that large.
13814
19ab8a18
PE
13815 * xdisp.c (message_log_check_duplicate): Return unsigned long, not int.
13816 This is less likely to overflow, and avoids undefined behavior if
13817 overflow does occur. All callers changed. Use strtoul to scan
13818 for the unsigned long integer.
b7cbbd6f
PE
13819 (pint2hrstr): Simplify and tune code slightly.
13820 This also avoids a (bogus) GCC warning with gcc -Wstrict-overflow.
19ab8a18 13821
f0641eff
PE
13822 * scroll.c (do_scrolling): Work around GCC bug 48228.
13823 See <http://gcc.gnu.org/bugzilla/show_bug.cgi?id=48228>.
13824
7f650bb9
PE
13825 * frame.c (Fmodify_frame_parameters): Simplify loop counter.
13826 This also avoids a warning with gcc -Wstrict-overflow.
39f5e519
PE
13827 (validate_x_resource_name): Simplify count usage.
13828 This also avoids a warning with gcc -Wstrict-overflow.
7f650bb9 13829
37dd57d1
PE
13830 * fileio.c (Fcopy_file): Report error if fchown or fchmod
13831 fail (Bug#8306).
81e56e61 13832
699979fc 13833 * emacs.c (Fdaemon_initialized): Do not ignore I/O errors (Bug#8303).
dc1ca6a8 13834
401bf9b4
PE
13835 * process.c (Fmake_network_process): Use socklen_t, not int,
13836 where POSIX says socklen_t is required in portable programs.
13837 This fixes a porting bug on hosts like 64-bit HP-UX, where
591b2973 13838 socklen_t is wider than int (Bug#8277).
401bf9b4
PE
13839 (Fmake_network_process, server_accept_connection):
13840 (wait_reading_process_output, read_process_output):
13841 Likewise.
13842
b93aacde
PE
13843 * process.c: Rename or move locals to avoid shadowing.
13844 (list_processes_1, Fmake_network_process):
13845 (read_process_output_error_handler, exec_sentinel_error_handler):
13846 Rename or move locals.
4dc343ee 13847 (Fmake_network_process): Define label "retry_connect" only if needed.
0da49335 13848 (Fnetwork_interface_info): Fix pointer signedness.
f990b4e5 13849 (process_send_signal): Add cast to avoid pointer signedness problem.
7b808126 13850 (FIRST_PROC_DESC, IF_NON_BLOCKING_CONNECT): Remove unused macros.
c939f91b 13851 (create_process): Use 'volatile' to avoid vfork clobbering (Bug#8298).
b93aacde 13852
af8a867c 13853 Make tparam.h and terminfo.c consistent.
44f230aa
SM
13854 * cm.c (tputs, tgoto, BC, UP): Remove extern decls.
13855 Include tparam.h instead, since it declares them.
af8a867c
PE
13856 * cm.h (PC): Remove extern decl; tparam.h now does this.
13857 * deps.mk (cm.o, terminfo.o): Depend on tparam.h.
13858 * terminfo.c: Include tparam.h, to check interfaces.
13859 (tparm): Make 1st arg a const pointer in decl. Put it at top level.
13860 (tparam): Adjust signature to match interface in tparam.h;
13861 this removes some undefined behavior. Check that outstring and len
13862 are zero, which they always are with Emacs.
13863 * tparam.h (PC, BC, UP): New extern decls.
13864
0248044d 13865 * xftfont.c (xftfont_shape): Now static, and defined only if needed.
001a7ab4 13866 (xftfont_open): Rename locals to avoid shadowing.
0248044d 13867
8ff096c1 13868 * ftfont.c (ftfont_resolve_generic_family): Fix pointer signedness.
a00924bb
PE
13869 (ftfont_otf_capability, ftfont_shape): Omit decls if not needed.
13870 (OTF_TAG_SYM): Omit macro if not needed.
e932860f 13871 (ftfont_list): Remove unused local.
49eaafba
PE
13872 (get_adstyle_property, ftfont_pattern_entity):
13873 (ftfont_lookup_cache, ftfont_open, ftfont_anchor_point):
13874 Rename locals to avoid shadowing.
8ff096c1 13875
e2be39f6
PE
13876 * xfont.c (xfont_list_family): Mark var as initialized.
13877
c9735e30
PE
13878 * xml.c (make_dom): Now static.
13879
8f5201ae
PE
13880 * composite.c (composition_compute_stop_pos): Rename local to
13881 avoid shadowing.
b246f932
PE
13882 (composition_reseat_it): Remove unused locals.
13883 (find_automatic_composition, composition_adjust_point): Likewise.
80e079b2 13884 (composition_update_it): Mark var as initialized.
11b61122
PE
13885 (find_automatic_composition): Mark vars as initialized,
13886 with a FIXME (Bug#8290).
8f5201ae 13887
760fbc2c
PE
13888 character.h: Rename locals to avoid shadowing.
13889 * character.h (PREV_CHAR_BOUNDARY, FETCH_STRING_CHAR_ADVANCE):
13890 (FETCH_STRING_CHAR_AS_MULTIBYTE_ADVANCE, FETCH_CHAR_ADVANCE):
13891 (FETCH_CHAR_ADVANCE_NO_CHECK, INC_POS, DEC_POS, BUF_INC_POS):
13892 (BUF_DEC_POS): Be more systematic about renaming local temporaries
13893 to avoid shadowing.
13894
ff08eb85
PE
13895 * textprop.c (property_change_between_p): Remove; unused.
13896
fc7bf025
PE
13897 * intervals.c (interval_start_pos): Now static.
13898
235d7abc
PE
13899 * intervals.h (CHECK_TOTAL_LENGTH): Avoid empty "else".
13900
44f230aa
SM
13901 * atimer.c (start_atimer, append_atimer_lists, set_alarm):
13902 Rename locals to avoid shadowing.
3e7d6594 13903
50060332
PE
13904 * sound.c (wav_play, au_play, Fplay_sound_internal):
13905 Fix pointer signedness.
d01f234b 13906 (alsa_choose_format): Remove unused local var.
c83b8872
PE
13907 (wav_play): Initialize a variable to 0, to prevent undefined
13908 behavior (Bug#8278).
50060332 13909
c4fc4e30
PE
13910 * region-cache.c (insert_cache_boundary): Redo var to avoid shadowing.
13911
918436ed
PE
13912 * region-cache.h (pp_cache): New decl, for gcc -Wmissing-prototypes.
13913
c939f91b
PE
13914 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork
13915 clobbering (Bug#8298).
b9c7f648
PE
13916 * sysdep.c (sys_subshell): Likewise.
13917 Previously, the sys_subshell 'volatile' was incorrectly IF_LINTted out.
7e9123a2 13918
6bd8c144
PE
13919 * lisp.h (child_setup): Now NO_RETURN unless DOS_NT.
13920 This should get cleaned up, so that child_setup has the
13921 same signature on all platforms.
13922
7710357c 13923 * callproc.c (call_process_cleanup): Now static.
cb1d0ef7 13924 (relocate_fd): Rename locals to avoid shadowing.
7710357c 13925
c59da222
CY
139262011-03-22 Chong Yidong <cyd@stupidchicken.com>
13927
13928 * xterm.c (x_clear_frame): Remove XClearWindow call. This appears
13929 not to be necessary, and produces flickering.
13930
66b87493
GM
139312011-03-20 Glenn Morris <rgm@gnu.org>
13932
13933 * config.in: Remove file.
13934
45b6f6d5
JB
139352011-03-20 Juanma Barranquero <lekktu@gmail.com>
13936
13937 * minibuf.c (Vcompleting_read_function): Don't declare, global variables
13938 are now in src/globals.h.
13939 (syms_of_minibuf): Remove spurious & from previous change.
13940
cd394be1 139412011-03-20 Leo Liu <sdl.web@gmail.com>
3ec03f7e
LL
13942
13943 * minibuf.c (completing-read-function): New variable.
13944 (completing-read-default): Rename from completing-read.
13945 (completing-read): Call completing-read-function.
13946
b14e3e21
CY
139472011-03-19 Juanma Barranquero <lekktu@gmail.com>
13948
13949 * xfaces.c (Fx_load_color_file):
13950 Read color file from absolute filename (bug#8250).
13951
f2b726e6
JB
139522011-03-19 Juanma Barranquero <lekktu@gmail.com>
13953
13954 * makefile.w32-in: Update dependencies.
13955
09f6ff02
EZ
139562011-03-17 Eli Zaretskii <eliz@gnu.org>
13957
13958 * makefile.w32-in ($(BLD)/unexw32.$(O)): Depend on $(SRC)/unexec.h.
13959
29a6015a
PE
139602011-03-17 Paul Eggert <eggert@cs.ucla.edu>
13961
a3a6c54e
PE
13962 Fix more problems found by GCC 4.5.2's static checks.
13963
b766f867
PE
13964 * process.c (make_serial_process_unwind, send_process_trap):
13965 (sigchld_handler): Now static.
13966
be02381c
PE
13967 * process.c (allocate_pty): Let PTY_ITERATION declare iteration vars.
13968 That way, the code declares only the vars that it needs.
13969 * s/aix4-2.h (PTY_ITERATION): Declare iteration vars.
13970 * s/cygwin.h (PTY_ITERATION): Likewise.
13971 * s/darwin.h (PTY_ITERATION): Likewise.
13972 * s/gnu-linux.h (PTY_ITERATION): Likewise.
13973
57048744
PE
13974 * s/irix6-5.h (PTY_OPEN): Declare stb, to loosen coupling.
13975 * process.c (allocate_pty): Don't declare stb unless it's needed.
13976
7914961c 13977 * bytecode.c (MAYBE_GC): Rewrite so as not to use empty "else".
615f2d59
PE
13978 (CONSTANTLIM): Remove; unused.
13979 (METER_CODE, Bscan_buffer, Bread_char, Bset_mark):
13980 Define only if needed.
7914961c 13981
b3967b18
PE
13982 * unexelf.c (unexec): Name an expression,
13983 to avoid gcc -Wbad-function-cast warning.
9ae71512
PE
13984 Use a different way to cause a compilation error if anyone uses
13985 n rather than nn, a way that does not involve shadowing.
73366a00 13986 (ELF_BSS_SECTION_NAME, OLD_PROGRAM_H): Remove; unused.
b3967b18 13987
29a6015a
PE
13988 * deps.mk (unexalpha.o): Remove; unused.
13989
43cfc33e 13990 New file unexec.h, the (simple) interface for unexec (Bug#8267).
7feda0d2 13991 * unexec.h: New file.
ce701a33
PE
13992 * deps.mk (emacs.o, unexaix.o, unexcw.o, unexcoff.o, unexelf.o):
13993 (unexhp9k800.o, unexmacosx.o, unexsol.o, unexw32.o):
13994 Depend on unexec.h.
13995 * emacs.c [!defined CANNOT_DUMP]: Include unexec.h.
13996 * unexaix.c, unexcoff.c, unexcw.c, unexelf.c, unexhp9k800.c:
13997 * unexmacosx.c, unexsol.c, unexw32.c: Include unexec.h.
381259ef 13998 Change as necessary to match prototype in unexec.h.
ce701a33 13999
01f44d5a
PE
14000 * syntax.c (Fforward_comment, scan_lists): Rename locals to avoid
14001 shadowing.
4f63c6bb 14002 (back_comment, skip_chars): Mark vars as initialized.
01f44d5a 14003
a6670b0b
PE
14004 * character.h (FETCH_STRING_CHAR_ADVANCE_NO_CHECK, BUF_INC_POS):
14005 Rename locals to avoid shadowing.
14006
cef2010d 14007 * lread.c (read1): Rewrite so as not to use empty "else".
0902fe45 14008 (Fload, readevalloop, read1): Rename locals to avoid shadowing.
cef2010d 14009
d4d7173a
PE
14010 * print.c (Fredirect_debugging_output): Fix pointer signedess.
14011
f08b802a
PE
14012 * lisp.h (debug_output_compilation_hack): Add decl here, to avoid
14013 warning when compiling print.c.
14014
3ddb0639
PE
14015 * font.c (font_unparse_fcname): Abort in an "impossible" situation
14016 instead of using an uninitialized var.
5ad03b97 14017 (font_sort_entities): Mark var as initialized.
3ddb0639 14018
170a2692
PE
14019 * character.h (FETCH_CHAR_ADVANCE): Rename locals to avoid shadowing.
14020
e663c700
PE
14021 * font.c (font_unparse_xlfd): Don't mix pointers to variables with
14022 pointers to constants.
89bc529a 14023 (font_parse_fcname): Remove unused vars.
7b81e2d0 14024 (font_delete_unmatched): Now static.
ea838e10 14025 (font_get_spec): Remove; unused.
13a547c6
PE
14026 (font_style_to_value, font_prop_validate_style, font_unparse_fcname):
14027 (font_update_drivers, Ffont_get_glyphs, font_add_log):
14028 Rename or move locals to avoid shadowing.
e663c700 14029
2a80c887 14030 * fns.c (require_nesting_list, require_unwind): Now static.
612f56df 14031 (Ffillarray): Rename locals to avoid shadowing.
2a80c887 14032
1384fa33 14033 * floatfns.c (domain_error2): Define only if needed.
a885e2ed 14034 (Ffrexp, Fldexp): Rename locals to avoid shadowing.
1384fa33 14035
8b2c52e9
PE
14036 * alloc.c (mark_backtrace): Move decl from here ...
14037 * lisp.h: ... to here, so that it can be checked.
14038
475545b5 14039 * eval.c (call_debugger, do_debug_on_call, grow_specpdl): Now static.
d28a2170 14040 (Fdefvar): Rewrite so as not to use empty "else".
cfcbfb1a
PE
14041 (lisp_indirect_variable): Name an expression,
14042 to avoid gcc -Wbad-function-cast warning.
1faed8ae 14043 (Fdefvar): Rename locals to avoid shadowing.
475545b5 14044
b1349114 14045 * callint.c (quotify_arg, quotify_args): Now static.
a3e8cbda 14046 (Fcall_interactively): Rename locals to avoid shadowing.
b0e80955 14047 Use const pointer when appropriate.
b1349114 14048
a2928364
PE
14049 * lisp.h (get_system_name, get_operating_system_release):
14050 Move decls here, to check interfaces.
14051 * process.c (get_operating_system_release): Move decl to lisp.h.
14052 * xrdb.c (get_system_name): Likewise.
63c5d10b
PE
14053 * editfns.c (init_editfns, Fuser_login_name, Fuser_uid):
14054 (Fuser_real_uid, Fuser_full_name): Remove unnecessary casts,
14055 some of which prompt warnings from gcc -Wbad-function-cast.
545b49b4
PE
14056 (Fformat_time_string, Fencode_time, Finsert_char):
14057 (Ftranslate_region_internal, Fformat):
14058 Rename or remove local vars to avoid shadowing.
9710023e 14059 (Ftranslate_region_internal): Mark var as initialized.
63c5d10b 14060
a415e694
PE
14061 * doc.c (Fdocumentation, Fsnarf_documentation): Move locals to
14062 avoid shadowing.
14063
8ef4622d
PE
14064 * lisp.h (eassert): Check that the argument compiles, even if
14065 ENABLE_CHECKING is not defined.
14066
946f9a5b
PE
14067 * data.c (Findirect_variable): Name an expression, to avoid
14068 gcc -Wbad-function-cast warning.
112396d6 14069 (default_value, arithcompare, arith_driver, arith_error): Now static.
b9b84fa9 14070 (store_symval_forwarding): Rename local to avoid shadowing.
44f230aa
SM
14071 (Fmake_variable_buffer_local, Fmake_local_variable):
14072 Mark variables as initialized.
52746918 14073 (do_blv_forwarding, do_symval_forwarding): Remove; unused.
946f9a5b 14074
e5aab7e7 14075 * alloc.c (check_cons_list): Do not define unless GC_CHECK_CONS_LIST.
ae35e756
PE
14076 (Fmake_vector, Fvector, Fmake_byte_code, Fgarbage_collect):
14077 Rename locals to avoid shadowing.
dff45157
PE
14078 (mark_stack): Move local variables into the #ifdef region where
14079 they're used.
7bc26fdb
PE
14080 (BLOCK_INPUT_ALLOC, UNBLOCK_INPUT_ALLOC): Define only if
14081 ! defined SYSTEM_MALLOC && ! defined SYNC_INPUT, as they are not
14082 needed otherwise.
14083 (CHECK_ALLOCATED): Define only if GC_CHECK_MARKED_OBJECTS.
14084 (GC_STRING_CHARS): Remove; not used.
d40d4be1 14085 (Fmemory_limit): Cast sbrk's returned value to char *.
ae35e756 14086
e5aab7e7
PE
14087 * lisp.h (check_cons_list): Declare if GC_CHECK_CONS_LIST; this
14088 avoids undefined behavior in theory.
14089
4da60324
PE
14090 * regex.c (IF_LINT): Add defn, for benefit of ../lib-src.
14091
88043301
PE
14092 Use functions, not macros, for up- and down-casing (Bug#8254).
14093 * buffer.h (DOWNCASE_TABLE, UPCASE_TABLE, DOWNCASE, UPPERCASEP):
14094 (NOCASEP, LOWERCASEP, UPCASE, UPCASE1): Remove. All callers changed
14095 to use the following functions instead of these macros.
14096 (downcase): Adjust to lack of DOWNCASE_TABLE. Return int, not
14097 EMACS_INT, since callers assume the returned value fits in int.
14098 (upcase1): Likewise, for UPCASE_TABLE.
14099 (uppercasep, lowercasep, upcase): New static inline functions.
0da09c43 14100 * editfns.c (Fchar_equal): Remove no-longer-needed workaround for
db69b0cd 14101 the race-condition problem in the old DOWNCASE.
88043301 14102
19ed5445
PE
14103 * regex.c (CHARSET_LOOKUP_RANGE_TABLE_RAW, POP_FAILURE_REG_OR_COUNT):
14104 Rename locals to avoid shadowing.
14105 (regex_compile, re_match_2_internal): Move locals to avoid shadowing.
abbd1bcf
PE
14106 (regex_compile, re_search_2, re_match_2_internal):
14107 Remove unused local vars.
952db0d7
PE
14108 (FREE_VAR): Rewrite so as not to use empty "else",
14109 which gcc can warn about.
da053e48 14110 (regex_compile, re_match_2_internal): Mark locals as initialized.
b313f9d8
PE
14111 (RETALLOC_IF): Define only if needed.
14112 (WORDCHAR_P): Likewise. This one is never needed, but is used
14113 only in a comment talking about a compiler bug, so put inside
14114 the #if 0 of that comment.
14115 (CHARSET_LOOKUP_BITMAP, FAIL_STACK_FULL, RESET_FAIL_STACK):
14116 (PUSH_FAILURE_ELT, BUF_PUSH_3, STOP_ADDR_VSTRING):
14117 Remove; unused.
19ed5445 14118
1f3561e4 14119 * search.c (boyer_moore): Rename locals to avoid shadowing.
76ef09b7
PE
14120 * character.h (FETCH_STRING_CHAR_AS_MULTIBYTE_ADVANCE):
14121 (PREV_CHAR_BOUNDARY): Likewise.
1f3561e4 14122
ded6f8f7
PE
14123 * search.c (simple_search): Remove unused var.
14124
dbd37a95
PE
14125 * dired.c (compile_pattern): Move decl from here ...
14126 * lisp.h: ... to here, so that it can be checked.
14127 (struct re_registers): New forward decl.
14128
7e47afad
PE
14129 * character.h (INC_POS, DEC_POS): Rename locals to avoid shadowing.
14130
85f24f61
PE
14131 * indent.c (MULTIBYTE_BYTES_WIDTH): New args bytes, width.
14132 All uses changed.
14133 (MULTIBYTE_BYTES_WIDTH, scan_for_column, compute_motion):
14134 Rename locals to avoid shadowing.
5671df8f 14135 (Fvertical_motion): Mark locals as initialized.
85f24f61 14136
181aa2be 14137 * casefiddle.c (casify_object, casify_region): Now static.
e45a141a 14138 (casify_region): Mark local as initialized.
181aa2be 14139
930d429c
PE
14140 * cmds.c (internal_self_insert): Rename local to avoid shadowing.
14141
7082eac6
PE
14142 * lisp.h (GCPRO2_VAR, GCPRO3_VAR, GCPRO4_VAR, GCPRO5_VAR, GCPRO6_VAR):
14143 New macros, so that the caller can use some names other than
14144 gcpro1, gcpro2, etc.
14145 (GCPRO2, GCPRO3, GCPRO4, GCPRO5, GCPRO6): Reimplement in terms
14146 of the new macros.
14147 (GCPRO1_VAR, UNGCPRO_VAR): Change the meaning of the second
14148 argument, for consistency with GCPRO2_VAR, etc: it is now the
14149 prefix of the variable, not the variable itself. All uses
14150 changed.
38b2c076
PE
14151 * dired.c (directory_files_internal, file_name_completion):
14152 Rename locals to avoid shadowing.
14153
15206ed9
PE
14154 Fix a race condition diagnosed by gcc -Wsequence-point (Bug#8254).
14155 An expression of the form (DOWNCASE (x) == DOWNCASE (y)), found in
14156 dired.c's scmp function, had undefined behavior.
14157 * lisp.h (DOWNCASE_TABLE, UPCASE_TABLE, DOWNCASE, UPPERCASEP):
14158 (NOCASEP, LOWERCASEP, UPCASE, UPCASE1): Move from here ...
14159 * buffer.h: ... to here, because these macros use current_buffer,
14160 and the new implementation with inline functions needs to have
14161 current_buffer in scope now, rather than later when the macros
14162 are used.
14163 (downcase, upcase1): New static inline functions.
14164 (DOWNCASE, UPCASE1): Reimplement using these functions.
14165 This avoids undefined behavior in expressions like
14166 DOWNCASE (x) == DOWNCASE (y), which previously suffered
14167 from race conditions in accessing the global variables
14168 case_temp1 and case_temp2.
14169 * casetab.c (case_temp1, case_temp2): Remove; no longer needed.
14170 * lisp.h (case_temp1, case_temp2): Remove their decls.
14171 * character.h (ASCII_CHAR_P): Move from here ...
14172 * lisp.h: ... to here, so that the inline functions mentioned
14173 above can use them.
14174
4a6bea26
PE
14175 * dired.c (directory_files_internal_unwind): Now static.
14176
f14b7e14
PE
14177 * fileio.c (file_name_as_directory, directory_file_name):
14178 (barf_or_query_if_file_exists, auto_save_error, auto_save_1):
14179 Now static.
2893f146
PE
14180 (file_name_as_directory): Use const pointers when appropriate.
14181 (Fexpand_file_name): Likewise. In particular, newdir might
14182 point at constant storage, so make it a const pointer.
fd4ead52 14183 (Fmake_directory_internal, Fread_file_name): Remove unused vars.
b14aac08
PE
14184 (Ffile_selinux_context, Fset_file_selinux_context): Fix pointer
14185 signedness issues.
f839df0c
PE
14186 (Fset_file_times, Finsert_file_contents, auto_save_error):
14187 Rename locals to avoid shadowing.
f14b7e14 14188
5716756e 14189 * minibuf.c (choose_minibuf_frame_1): Now static.
62137a95
PE
14190 (Ftry_completion, Fall_completions): Rename or remove locals
14191 to avoid shadowing.
5716756e 14192
b4c3046a
PE
14193 * marker.c (bytepos_to_charpos): Remove; unused.
14194
b45db522
PE
14195 * lisp.h (verify_bytepos, count_markers): New decls,
14196 so that gcc does not warn that these functions aren't declared.
14197
85876d07
PE
14198 * insdel.c (check_markers, make_gap_larger, make_gap_smaller):
14199 (reset_var_on_error, Fcombine_after_change_execute_1): Now static.
f0cb4a60 14200 (CHECK_MARKERS): Redo to avoid gcc -Wempty-body diagnostic.
40ef059e 14201 (copy_text): Remove unused local var.
85876d07 14202
03d78a21 14203 * filelock.c (within_one_second): Now static.
b3dd38ab 14204 (lock_file_1): Rename local to avoid shadowing.
03d78a21 14205
5df8f01b
PE
14206 * buffer.c (fix_overlays_before): Mark locals as initialized.
14207 (fix_start_end_in_overlays): Likewise. This function should be
14208 simplified by using pointers-to-pointers, but that's a different
14209 matter.
b1d876f1 14210 (switch_to_buffer_1): Now static.
8f54f30a
PE
14211 (Fkill_buffer, record_buffer, Fbury_buffer, Fset_buffer_multibyte):
14212 (report_overlay_modification): Rename locals to avoid shadowing.
c3bd59b5 14213
a70072c9 14214 * sysdep.c (system_process_attributes): Rename vars to avoid shadowing.
fbd02d7b 14215 Fix pointer signedness issue.
edced198
PE
14216 (sys_subshell): Mark local as volatile if checking for lint,
14217 to suppress a gcc -Wclobbered warning that does not seem to be right.
15dfd3d9 14218 (MAXPATHLEN): Define only if needed.
a70072c9 14219
a0977c44
PE
14220 * process.c (serial_open, serial_configure): Move decls from here ...
14221 * systty.h: ... to here, so that they can be checked.
14222
a884fdcc
PE
14223 * fns.c (get_random, seed_random): Move extern decls from here ...
14224 * lisp.h: ... to here, so that they can be checked.
14225
604efe86 14226 * sysdep.c (reset_io): Now static.
b8950c94 14227 (wait_for_termination_signal): Remove; unused.
604efe86 14228
38fc62d9
PE
14229 * keymap.c (keymap_parent, keymap_memberp, map_keymap_internal):
14230 (copy_keymap_item, append_key, push_text_char_description):
14231 Now static.
1004a21a 14232 (Fwhere_is_internal): Don't test CONSP (sequences) unnecessarily.
dbbb8427 14233 (DENSE_TABLE_SIZE): Remove; unused.
c1141155
PE
14234 (get_keymap, access_keymap, Fdefine_key, Fwhere_is_internal):
14235 (describe_map_tree):
14236 Rename locals to avoid shadowing.
38fc62d9 14237
2f2650da
PE
14238 * keyboard.c: Declare functions static if they are not used elsewhere.
14239 (echo_char, echo_dash, cmd_error, top_level_2):
14240 (poll_for_input, handle_async_input): Now static.
69a058fa
PE
14241 (read_char, kbd_buffer_get_event, make_lispy_position):
14242 (make_lispy_event, make_lispy_movement, apply_modifiers):
14243 (decode_keyboard_code, tty_read_avail_input, menu_bar_items):
14244 (parse_tool_bar_item, read_key_sequence, Fread_key_sequence):
14245 (Fread_key_sequence_vector): Rename locals to avoid shadowing.
c8a06054 14246 (read_key_sequence, read_char): Mark locals as initialized.
3ac94672 14247 (Fexit_recursive_edit, Fabort_recursive_edit): Mark with NO_RETURN.
2f2650da 14248
a053e86c 14249 * keyboard.h (make_ctrl_char): New decl.
da2f2dd9
PE
14250 (mark_kboards): Move decl here ...
14251 * alloc.c (mark_kboards): ... from here.
a053e86c 14252
4752793e
PE
14253 * lisp.h (force_auto_save_soon): New decl.
14254
74f10ca7 14255 * emacs.c (init_cmdargs): Rename local to avoid shadowing.
244fc23d
PE
14256 (DEFINE_DUMMY_FUNCTION): New macro.
14257 (__do_global_ctors, __do_global_ctors_aux, __do_global_dtors, __main):
14258 Use it.
c03cd23f
PE
14259 (main): Add casts to avoid warnings
14260 if GCC considers string literals to be constants.
74f10ca7 14261
022e70d4
PE
14262 * lisp.h (fatal_error_signal): Add decl, since it's exported.
14263
59d6fe83
PE
14264 * dbusbind.c: Pointer signedness fixes.
14265 (xd_signature, xd_append_arg, xd_initialize):
14266 (Fdbus_call_method, Fdbus_call_method_asynchronously):
14267 (Fdbus_method_return_internal, Fdbus_method_error_internal):
14268 (Fdbus_send_signal, xd_read_message_1, Fdbus_register_service):
14269 (Fdbus_register_signal): Use SSDATA when the context wants char *.
14270
78320123
PE
14271 * dbusbind.c (Fdbus_init_bus): Add cast to avoid warning
14272 if GCC considers string literals to be constants.
49cebcca 14273 (Fdbus_register_service, Fdbus_register_method): Remove unused vars.
78320123 14274
35ac2a97
SM
142752011-03-16 Stefan Monnier <monnier@iro.umontreal.ca>
14276
fb103ca9
SM
14277 * print.c (PRINT_CIRCLE_CANDIDATE_P): New macro.
14278 (print_preprocess, print_object): New macro to fix last change.
14279
35ac2a97
SM
14280 * print.c (print_preprocess): Don't forget font objects.
14281
62973b41
JB
142822011-03-16 Juanma Barranquero <lekktu@gmail.com>
14283
14284 * emacs.c (USAGE3): Doc fixes.
14285
0e48bb22
AS
142862011-03-15 Andreas Schwab <schwab@linux-m68k.org>
14287
14288 * coding.c (detect_coding_iso_2022): Reorganize code to clarify
14289 structure.
14290
7684e57b
JB
142912011-03-14 Juanma Barranquero <lekktu@gmail.com>
14292
14293 * lisp.h (VWindow_system, Qfile_name_history):
14294 * keyboard.h (lispy_function_keys) [WINDOWSNT]:
14295 * w32term.h (w32_system_caret_hwnd, w32_system_caret_height)
14296 (w32_system_caret_x, w32_system_caret_y): Declare extern.
14297
14298 * w32select.c: Don't #include "keyboard.h".
c96bbc66 14299 (run_protected): Add extern declaration for waiting_for_input.
7684e57b
JB
14300
14301 * w32.c (Qlocal, noninteractive1, inhibit_window_system):
14302 * w32console.c (detect_input_pending, read_input_pending)
14303 (encode_terminal_code):
14304 * w32fns.c (quit_char, lispy_function_keys, Qtooltip)
14305 (w32_system_caret_hwnd, w32_system_caret_height, w32_system_caret_x)
14306 (w32_system_caret_y, Qfile_name_history):
14307 * w32font.c (w32font_driver, QCantialias, QCotf, QClang):
14308 * w32inevt.c (reinvoke_input_signal, lispy_function_keys):
14309 * w32menu.c (Qmenu_bar, QCtoggle, QCradio, Qoverriding_local_map)
14310 (Qoverriding_terminal_local_map, Qmenu_bar_update_hook):
14311 * w32proc.c (Qlocal, report_file_error):
14312 * w32term.c (Vwindow_system, updating_frame):
14313 * w32uniscribe.c (initialized, uniscribe_font_driver):
14314 Remove unneeded extern declarations.
14315
2aa46d6c
CY
143162011-03-14 Chong Yidong <cyd@stupidchicken.com>
14317
c96bbc66 14318 * buffer.c (Fmake_indirect_buffer): Fix incorrect assertions.
2aa46d6c 14319
cffc6f3b
CY
143202011-03-13 Chong Yidong <cyd@stupidchicken.com>
14321
14322 * buffer.h (BUF_BEGV, BUF_BEGV_BYTE, BUF_ZV, BUF_ZV_BYTE, BUF_PT)
14323 (BUF_PT_BYTE): Rewrite to handle indirect buffers (Bug#8219).
14324 These macros can no longer be used for assignment.
14325
44f230aa
SM
14326 * buffer.c (Fget_buffer_create, Fmake_indirect_buffer):
14327 Assign struct members directly, instead of using BUF_BEGV etc.
cffc6f3b
CY
14328 (record_buffer_markers, fetch_buffer_markers): New functions for
14329 recording and fetching special buffer markers.
14330 (set_buffer_internal_1, set_buffer_temp): Use them.
14331
14332 * lread.c (unreadchar): Use SET_BUF_PT_BOTH.
14333
14334 * insdel.c (adjust_point): Use SET_BUF_PT_BOTH.
14335
14336 * intervals.c (temp_set_point_both): Use SET_BUF_PT_BOTH.
14337 (get_local_map): Use SET_BUF_BEGV_BOTH and SET_BUF_ZV_BOTH.
14338
14339 * xdisp.c (hscroll_window_tree):
14340 (reconsider_clip_changes): Use PT instead of BUF_PT.
14341
d251f04b
EZ
143422011-03-13 Eli Zaretskii <eliz@gnu.org>
14343
14344 * makefile.w32-in ($(BLD)/editfns.$(O)): Depend on
14345 $(EMACS_ROOT)/lib/intprops.h.
14346
f0c77cd1
PE
143472011-03-13 Paul Eggert <eggert@cs.ucla.edu>
14348
3eca4629
PE
14349 Fix more problems found by GCC 4.5.2's static checks.
14350
7c86ee98
PE
14351 * gtkutil.c (xg_get_pixbuf_from_pixmap): Add cast from char *
14352 to unsigned char * to avoid compiler diagnostic.
b0afc268
PE
14353 (xg_free_frame_widgets): Make it clear that a local variable is
14354 needed only if USE_GTK_TOOLTIP.
01e0b5ad
PE
14355 (gdk_window_get_screen): Make it clear that this macro is needed
14356 only if USE_GTK_TOOLTIP.
1e5524e7
PE
14357 (int_gtk_range_get_value): New function, which avoids a diagnostic
14358 from gcc -Wbad-function-cast.
14359 (xg_set_toolkit_scroll_bar_thumb): Use it.
14360 (xg_tool_bar_callback, xg_tool_item_stale_p): Rewrite to avoid
14361 diagnostic from gcc -Wbad-function-cast.
65dc836c
PE
14362 (get_utf8_string, xg_get_file_with_chooser):
14363 Rename locals to avoid shadowing.
14364 (create_dialog): Move locals to avoid shadowing.
7c86ee98 14365
41729b81
PE
14366 * xgselect.c (xg_select): Remove unused var.
14367
f0c77cd1
PE
14368 * image.c (four_corners_best): Mark locals as initialized.
14369 (gif_load): Initialize transparent_p to zero (Bug#8238).
14370 Mark another local as initialized.
ec6cf4c6 14371 (my_png_error, my_error_exit): Mark with NO_RETURN.
f0c77cd1 14372
ce0ad53d 14373 * image.c (clear_image_cache): Now static.
d5d5a617 14374 (DIM, HAVE_STDLIB_H_1): Remove unused macros.
e22cffbc 14375 (xpm_load): Redo to avoid "discards qualifiers" gcc warning.
77a765fd
PE
14376 (x_edge_detection): Remove unnecessary cast that
14377 gcc -Wbad-function-cast diagnoses.
2037898d 14378 (gif_load): Fix pointer signedness.
6ae141d6
PE
14379 (clear_image_cache, xbm_read_bitmap_data, x_detect_edges):
14380 (jpeg_load, gif_load): Rename locals to avoid shadowing.
ce0ad53d 14381
33383987 143822011-03-12 Paul Eggert <eggert@cs.ucla.edu>
3eca4629 14383
d32df629
PE
14384 Improve quality of tests for time stamp overflow.
14385 For example, without this patch (encode-time 0 0 0 1 1
14386 1152921504606846976) returns the obviously-bogus value (-948597
14387 62170) on my RHEL 5.5 x86-64 host. With the patch, it correctly
14388 reports time overflow. See
14389 <http://lists.gnu.org/archive/html/emacs-devel/2011-03/msg00470.html>.
b8d9bd41
PE
14390 * deps.mk (editfns.o): Depend on ../lib/intprops.h.
14391 * editfns.c: Include limits.h and intprops.h.
14392 (TIME_T_MIN, TIME_T_MAX): New macros.
14393 (time_overflow): Move earlier, to before first use.
14394 (hi_time, lo_time): New functions, for an accurate test for
14395 out-of-range times.
14396 (Fcurrent_time, Fget_internal_run_time, make_time): Use them.
14397 (Fget_internal_run_time): Don't assume time_t fits in int.
14398 (make_time): Use list2 instead of Fcons twice.
14399 (Fdecode_time): More accurate test for out-of-range times.
14400 (check_tm_member): New function.
14401 (Fencode_time): Use it, to test for out-of-range times.
d32df629
PE
14402 (lisp_time_argument): Don't rely on undefined left-shift and
14403 right-shift behavior when checking for time stamp overflow.
8be6f318 14404
fe31d94c
PE
14405 * editfns.c (time_overflow): New function, refactoring common code.
14406 (Fformat_time_string, Fdecode_time, Fencode_time):
14407 (Fcurrent_time_string): Use it.
14408
8be6f318
PE
14409 Move 'make_time' to be next to its inverse 'lisp_time_argument'.
14410 * dired.c (make_time): Move to ...
14411 * editfns.c (make_time): ... here.
14412 * systime.h: Note the move.
14413
09d9db2c 144142011-03-12 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
c47cbdfd 14415
126bc0dc
YM
14416 * fringe.c (update_window_fringes): Remove unused variables.
14417
c47cbdfd
YM
14418 * unexmacosx.c (copy_data_segment): Also copy __got section.
14419 (Bug#8223)
14420
7ac80be9
EZ
144212011-03-12 Eli Zaretskii <eliz@gnu.org>
14422
c96bbc66 14423 * termcap.c [MSDOS]: Include "msdos.h".
058e5dad
EZ
14424 (find_capability, tgetnum, tgetflag, tgetstr, tputs, tgetent):
14425 Constify `char *' arguments and their references according to
14426 prototypes in tparam.h.
14427
ecb0f94d 14428 * deps.mk (termcap.o): Depend on tparam.h and msdos.h.
058e5dad 14429
7ac80be9
EZ
14430 * msdos.c (XMenuAddPane): 3rd argument is `const char *' now.
14431 Adapt all references accordingly.
14432
14433 * msdos.h (XMenuAddPane): 3rd argument is `const char *' now.
14434
ef1fd07e
TT
144352011-03-11 Tom Tromey <tromey@redhat.com>
14436
14437 * buffer.c (syms_of_buffer): Remove obsolete comment.
14438
7ef4b50c
EZ
144392011-03-11 Eli Zaretskii <eliz@gnu.org>
14440
14441 * termhooks.h (encode_terminal_code): Declare prototype.
14442
14443 * msdos.c (encode_terminal_code): Don't declare prototype.
14444
14445 * term.c (encode_terminal_code): Now external again, used by
14446 w32console.c and msdos.c.
14447
44f230aa
SM
14448 * makefile.w32-in ($(BLD)/term.$(O), ($(BLD)/tparam.$(O)):
14449 Depend on $(SRC)/tparam.h, see 2011-03-11T07:24:21Z!eggert@cs.ucla.edu.
7ef4b50c 14450
4b1ec863 144512011-03-11 Paul Eggert <eggert@cs.ucla.edu>
f78faa98 14452
1714f52b 14453 Fix some minor problems found by GCC 4.5.2's static checks.
83316bf4 14454
4b1ec863
PE
14455 * fringe.c (update_window_fringes): Mark locals as initialized
14456 (Bug#8227).
14457 (destroy_fringe_bitmap, init_fringe_bitmap): Now static.
bf60f616 14458
524c7aa6
PE
14459 * alloc.c (mark_fringe_data): Move decl from here ...
14460 * lisp.h (mark_fringe_data) [HAVE_WINDOW_SYSTEM]: ... to here,
14461 to check its interface.
14462 (init_fringe_once): Do not declare unless HAVE_WINDOW_SYSTEM.
14463
a5c0af81 14464 * fontset.c (free_realized_fontset): Now static.
7519b8cd 14465 (Fset_fontset_font): Rename local to avoid shadowing.
cc6e5db1 14466 (fontset_font): Mark local as initialized.
a9a06e0b 14467 (FONTSET_SPEC, FONTSET_REPERTORY, RFONT_DEF_REPERTORY): Remove; unused.
a5c0af81 14468
b4716021
PE
14469 * xrdb.c: Include "xterm.h", to check x_load_resources's interface.
14470
811e9bac 14471 * xselect.c (x_disown_buffer_selections): Remove; not used.
7b83e2f1 14472 (TRACE3) [!defined TRACE_SELECTION]: Remove; not used.
aa0daa9f
PE
14473 (x_own_selection, Fx_disown_selection_internal): Rename locals
14474 to avoid shadowing.
14475 (x_handle_dnd_message): Remove local to avoid shadowing.
811e9bac 14476
7e3ab302
PE
14477 * lisp.h (GCPRO1_VAR, UNGCPRO_VAR): New macros,
14478 so that the caller can use some name other than gcpro1.
14479 (GCPRO1, UNGCPRO): Reimplement in terms of the new macros.
58d2d479
PE
14480 * xfns.c (Fx_create_frame, x_create_tip_frame, Fx_show_tip):
14481 (Fx_backspace_delete_keys_p):
14482 Use them to avoid shadowing, and rename vars to avoid shadowing.
14483 (x_decode_color, x_set_name, x_window): Now static.
6b437900 14484 (Fx_create_frame): Add braces to silence GCC warning.
c0951e53 14485 (Fx_file_dialog, Fx_select_font): Fix pointer signedness.
06b0c8a0
PE
14486 (x_real_positions, xg_set_icon_from_xpm_data, x_create_tip_frame):
14487 Remove unused locals.
7e3ab302
PE
14488 (Fx_create_frame, x_create_tip_frame, Fx_show_tip):
14489 (Fx_backspace_delete_keys_p): Rename locals to avoid shadowing.
14490 Some of these renamings use the new GCPRO1_VAR and UNGCPRO_VAR
14491 macros.
f78faa98 14492
e2b13473
PE
14493 * xterm.h (x_mouse_leave): New decl.
14494
77f23912
PE
14495 * xterm.c (x_copy_dpy_color, x_focus_on_frame, x_unfocus_frame):
14496 Remove unused functions.
cdf4ba58
PE
14497 (x_shift_glyphs_for_insert, XTflash, XTring_bell):
14498 (x_calc_absolute_position): Now static.
7411c686 14499 (XTread_socket): Don't define label "out" unless it's used.
2b07bcff 14500 Don't declare local "event" unless it's used.
ed7bf3a5
PE
14501 (x_iconify_frame, x_free_frame_resources): Don't declare locals
14502 unless they are used.
38d0b34a
PE
14503 (XEMBED_VERSION, xembed_set_info): Don't define unless needed.
14504 (x_fatal_error_signal): Remove; not used.
a6067996
PE
14505 (x_draw_image_foreground, redo_mouse_highlight, XTmouse_position):
14506 (x_scroll_bar_report_motion, handle_one_xevent, x_draw_bar_cursor):
14507 (x_error_catcher, x_connection_closed, x_error_handler):
14508 (x_error_quitter, xembed_send_message, x_iconify_frame):
14509 (my_log_handler): Rename locals to avoid shadowing.
28f1c698 14510 (x_delete_glyphs, x_ins_del_lines): Mark with NO_RETURN.
2a8fade0 14511 (x_connection_closed): Tell GCC not to suggest NO_RETURN.
77f23912 14512
44f230aa
SM
14513 * xfaces.c (clear_face_cache, Fx_list_fonts, Fface_font):
14514 Rename or move locals to avoid shadowing.
6b463e58 14515 (tty_defined_color, merge_face_heights): Now static.
5967d051 14516 (free_realized_faces_for_fontset): Remove; not used.
1e9966ea
PE
14517 (Fx_list_fonts): Mark variable that gcc -Wuninitialized
14518 does not deduce is never used uninitialized.
73719eba
PE
14519 (STRDUPA, LSTRDUPA, FONT_POINT_SIZE_QUANTUM): Remove; not used.
14520 (LFACEP): Define only if XASSERTS, as it's not needed otherwise.
071048a3 14521
426994c3 14522 * terminal.c (store_terminal_param): Now static.
5489860b 14523
032f1620 14524 * xmenu.c (menu_highlight_callback): Now static.
9d66f88e 14525 (set_frame_menubar): Remove unused local.
d4323972 14526 (xmenu_show): Rename parameter to avoid shadowing.
6d1f7fee
PE
14527 (xmenu_show, xdialog_show, xmenu_show): Make local pointers "const"
14528 since they might point to immutable storage.
281585b0
PE
14529 (next_menubar_widget_id): Declare only if USE_X_TOOLKIT,
14530 since it's unused otherwise.
032f1620 14531
367c19e5 14532 * xdisp.c (produce_glyphless_glyph): Initialize lower_xoff.
53df7c11 14533 Add a FIXME, since the code still doesn't look right. (Bug#8215)
9f36b9fd
PE
14534 (Fcurrent_bidi_paragraph_direction): Simplify slightly; this
14535 avoids a gcc -Wuninitialized diagnostic.
0e086e8f 14536 (display_line, BUILD_COMPOSITE_GLYPH_STRING, draw_glyphs):
44a3a108
PE
14537 (note_mouse_highlight): Mark variables that gcc -Wuninitialized
14538 does not deduce are never used uninitialized.
70739cbe 14539
07b48fa9
PE
14540 * lisp.h (IF_LINT): New macro, copied from ../lib-src/emacsclient.c.
14541
8868a238 14542 * xdisp.c (redisplay_window): Rename local to avoid shadowing.
4554d213
PE
14543 * window.c (window_loop, size_window):
14544 (run_window_configuration_change_hook, enlarge_window): Likewise.
8868a238 14545
7e5cf297 14546 * window.c (display_buffer): Now static.
d6550a9f
PE
14547 (size_window): Mark variables that gcc -Wuninitialized
14548 does not deduce are never used uninitialized.
a586633d
PE
14549 * window.h (check_all_windows): New decl, to forestall
14550 gcc -Wmissing-prototypes diagnostic.
5b555da1 14551 * dispextern.h (bidi_dump_cached_states): Likewise.
7e5cf297 14552
f6095868
PE
14553 * charset.h (CHECK_CHARSET_GET_CHARSET): Rename locals to avoid
14554 shadowing.
14555 * charset.c (map_charset_for_dump, Fchar_charset): Likewise.
726929c4
PE
14556 Include <limits.h>.
14557 (Fsort_charsets): Redo min/max calculation to shorten the code a bit
14558 and to avoid gcc -Wuninitialized warning.
89ef49df
PE
14559 (load_charset_map): Mark variables that gcc -Wuninitialized
14560 does not deduce are never used uninitialized.
53df7c11 14561 (load_charset): Abort instead of using uninitialized var (Bug#8229).
f6095868 14562
f38b440c
PE
14563 * coding.c (coding_set_source, coding_set_destination):
14564 Use "else { /* comment */ }" rather than "else /* comment */;"
14565 for clarity, and to avoid gcc -Wempty-body warning.
2735d060
PE
14566 (Fdefine_coding_system_internal): Don't redeclare 'i' inside
14567 a block, when the outer 'i' will do.
14568 (decode_coding_utf_8, decode_coding_utf_16, detect_coding_emacs_mule):
14569 (emacs_mule_char, decode_coding_emacs_mule, detect_coding_iso_2022):
14570 (decode_coding_iso_2022, decode_coding_sjis, decode_coding_big5):
14571 (decode_coding_raw_text, decode_coding_charset, get_translation_table):
14572 (Fdecode_sjis_char, Fdefine_coding_system_internal):
14573 Rename locals to avoid shadowing.
14574 * character.h (FETCH_STRING_CHAR_ADVANCE): Likewise.
e2f1bab9
PE
14575 * coding.c (emacs_mule_char, encode_invocation_designation):
14576 Now static, since they're not used elsewhere.
413bb2db 14577 (decode_coding_iso_2022): Add "default: abort ();" as a safety check.
c4a63b12 14578 (decode_coding_object, encode_coding_object, detect_coding_system):
ee05f961
PE
14579 (decode_coding_emacs_mule): Mark variables that gcc
14580 -Wuninitialized does not deduce are never used uninitialized.
160b01f6
PE
14581 (detect_coding_iso_2022): Initialize a local variable that might
14582 be used uninitialized. Leave a FIXME because it's not clear that
53df7c11 14583 this initialization is needed. (Bug#8211)
5f58e762
PE
14584 (ISO_CODE_LF, ISO_CODE_CR, CODING_ISO_FLAG_EUC_TW_SHIFT):
14585 (ONE_MORE_BYTE_NO_CHECK, UTF_BOM, UTF_16_INVALID_P):
14586 (SHIFT_OUT_OK, ENCODE_CONTROL_SEQUENCE_INTRODUCER):
14587 (ENCODE_DIRECTION_R2L, ENCODE_DIRECTION_L2R):
14588 Remove unused macros.
f38b440c 14589
232b38b9 14590 * category.c (hash_get_category_set): Remove unused local var.
9f3b5e69 14591 (copy_category_table): Now static, since it's not used elsewhere.
d0891610 14592 * character.c (string_count_byte8): Likewise.
232b38b9 14593
fb90da1b
PE
14594 * ccl.c (CCL_WRITE_STRING, CCL_ENCODE_CHAR, Fccl_execute_on_string):
14595 (Fregister_code_conversion_map): Rename locals to avoid shadowing.
14596
fb93dbc2
PE
14597 * chartab.c (copy_sub_char_table): Now static, since it's not used
14598 elsewhere.
5c156ace
PE
14599 (sub_char_table_ref_and_range, char_table_ref_and_range):
14600 Rename locals to avoid shadowing.
bbcd0949 14601 (ASET_RANGE, GET_SUB_CHAR_TABLE): Remove unused macros.
fb93dbc2 14602
7d3b3862 14603 * bidi.c (bidi_check_type): Now static, since it's not used elsewhere.
630d6892 14604 (BIDI_BOB): Remove unused macro.
7d3b3862 14605
6be7d3da
PE
14606 * cm.c (cmgoto): Mark variables that gcc -Wuninitialized does not
14607 deduce are never used uninitialized.
c2ed9c8b 14608 * term.c (encode_terminal_code): Likewise.
6be7d3da 14609
75f8807f 14610 * term.c (encode_terminal_code): Now static. Remove unused local.
72abad34 14611
50938595
PE
14612 * tparam.h: New file.
14613 * term.c, tparam.h: Include it.
14614 * deps.mk (term.o, tparam.o): Depend on tparam.h.
14615 * term.c (tputs, tgetent, tgetflag, tgetnum, tparam, tgetstr):
14616 Move these decls to tparam.h, and make them agree with what
14617 is actually in tparam.c. The previous trick of using incompatible
14618 decls in different modules does not conform to the C standard.
14619 All callers of tparam changed to use tparam's actual API.
14620 * tparam.c (tparam1, tparam, tgoto):
14621 Use const pointers where appropriate.
14622
fbceeba2
PE
14623 * cm.c (calccost, cmgoto): Use const pointers where appropriate.
14624 * cm.h (struct cm): Likewise.
14625 * dispextern.h (do_line_insertion_deletion_costs): Likewise.
14626 * scroll.c (ins_del_costs, do_line_insertion_deletion_costs): Likewise.
14627 * term.c (tty_ins_del_lines, calculate_costs, struct fkey_table):
14628 (term_get_fkeys_1, append_glyphless_glyph, produce_glyphless_glyph):
14629 (turn_on_face, init_tty): Likewise.
14630 * termchar.h (struct tty_display_info): Likewise.
fbceeba2 14631
7f3f1250
PE
14632 * term.c (term_mouse_position): Rename local to avoid shadowing.
14633
e6ca6543
PE
14634 * alloc.c (mark_ttys): Move decl from here ...
14635 * lisp.h (mark_ttys): ... to here, so that it's checked against defn.
14636
c40f8d15
AS
146372011-03-11 Andreas Schwab <schwab@linux-m68k.org>
14638
14639 * .gdbinit (pwinx, xbuffer): Fix access to buffer name.
14640
cfe0661d
JB
146412011-03-09 Juanma Barranquero <lekktu@gmail.com>
14642
14643 * search.c (compile_pattern_1): Remove argument regp, unused since
14644 revid:rms@gnu.org-19941211082627-3x1g1wyqkjmwloig.
14645 (compile_pattern): Don't pass it.
14646
0afb4571
J
146472011-03-08 Jan Djärv <jan.h.d@swipnet.se>
14648
14649 * xterm.h (DEFAULT_GDK_DISPLAY): New define.
14650 (GDK_WINDOW_XID, gtk_widget_get_preferred_size): New defines
14651 for ! HAVE_GTK3.
14652 (GTK_WIDGET_TO_X_WIN): Use GDK_WINDOW_XID.
14653
14654 * xmenu.c (menu_position_func): Call gtk_widget_get_preferred_size.
14655
14656 * gtkutil.c: Include gtkx.h if HAVE_GTK3. If ! HAVE_GTK3, define
14657 gdk_window_get_screen, gdk_window_get_geometry,
14658 gdk_x11_window_lookup_for_display and GDK_KEY_g.
14659 (xg_set_screen): Use DEFAULT_GDK_DISPLAY.
14660 (xg_get_pixbuf_from_pixmap): New function.
14661 (xg_get_pixbuf_from_pix_and_mask): Change parameters from GdkPixmap
14662 to Pixmap, take frame as parameter, remove GdkColormap parameter.
14663 Call xg_get_pixbuf_from_pixmap instead of
14664 gdk_pixbuf_get_from_drawable.
14665 (xg_get_image_for_pixmap): Do not make GdkPixmaps, call
14666 xg_get_pixbuf_from_pix_and_mask with Pixmap parameters instead.
14667 (xg_check_special_colors): Use GtkStyleContext and its functions
14668 for HAVE_GTK3.
14669 (xg_prepare_tooltip, xg_hide_tooltip): Call gdk_window_get_screen.
14670 (xg_prepare_tooltip, create_dialog, menubar_map_cb)
14671 (xg_update_frame_menubar, xg_tool_bar_detach_callback)
44f230aa
SM
14672 (xg_tool_bar_attach_callback, xg_update_tool_bar_sizes):
14673 Call gtk_widget_get_preferred_size.
0afb4571
J
14674 (xg_frame_resized): gdk_window_get_geometry only takes 5
14675 parameters.
44f230aa
SM
14676 (xg_win_to_widget, xg_event_is_for_menubar):
14677 Call gdk_x11_window_lookup_for_display.
0afb4571
J
14678 (xg_set_widget_bg): New function.
14679 (delete_cb): New function.
895009e1 14680 (xg_create_frame_widgets): Connect delete-event to delete_cb.
5c32d3f2 14681 Call xg_set_widget_bg. Only set background pixmap for ! HAVE_GTK3
0afb4571
J
14682 (xg_set_background_color): Call xg_set_widget_bg.
14683 (xg_set_frame_icon): Call xg_get_pixbuf_from_pix_and_mask.
14684 (xg_create_scroll_bar): vadj is a GtkAdjustment for HAVE_GTK3.
14685 Only call gtk_range_set_update_policy if ! HAVE_GTK3.
14686 (xg_make_tool_item): Only connect xg_tool_bar_item_expose_callback
14687 if ! HAVE_GTK3.
14688 (update_frame_tool_bar): Call gtk_widget_hide.
14689 (xg_initialize): Use GDK_KEY_g.
14690
14691 * xsmfns.c (gdk_set_sm_client_id): Define to gdk_set_sm_client_id
14692 if ! HAVE_GTK3
14693 (x_session_initialize): Call gdk_x11_set_sm_client_id.
14694
14695 * xterm.c (XFillRectangle): Use cairo routines for HAVE_GTK3.
14696 (x_term_init): Disable Xinput(2) with GDK_CORE_DEVICE_EVENTS.
14697 Load ~/emacs.d/gtkrc only for ! HAVE_GTK3.
14698
1c2cc4ef
JB
146992011-03-08 Juanma Barranquero <lekktu@gmail.com>
14700
14701 * w32xfns.c (select_palette): Check success of RealizePalette against
14702 GDI_ERROR, not zero.
14703
33383987 14704See ChangeLog.11 for earlier changes.
aac0c6e3
MR
14705
14706;; Local Variables:
14707;; coding: utf-8
aac0c6e3
MR
14708;; End:
14709
2f097256 14710 Copyright (C) 2011-2012 Free Software Foundation, Inc.
aac0c6e3
MR
14711
14712 This file is part of GNU Emacs.
14713
14714 GNU Emacs is free software: you can redistribute it and/or modify
14715 it under the terms of the GNU General Public License as published by
14716 the Free Software Foundation, either version 3 of the License, or
14717 (at your option) any later version.
14718
14719 GNU Emacs is distributed in the hope that it will be useful,
14720 but WITHOUT ANY WARRANTY; without even the implied warranty of
14721 MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
14722 GNU General Public License for more details.
14723
14724 You should have received a copy of the GNU General Public License
14725 along with GNU Emacs. If not, see <http://www.gnu.org/licenses/>.