* lisp/ido.el (ido-find-file): Mention C-d binding in docstring.
[bpt/emacs.git] / src / ChangeLog
CommitLineData
ec6de1e2
SM
12012-06-19 Stefan Monnier <monnier@iro.umontreal.ca>
2
3 * minibuf.c (Fread_string): Bind minibuffer-completion-table.
4
28be1ada
DA
52012-06-19 Dmitry Antipov <dmantipov@yandex.ru>
6
7 * alloc.c, bytecode.c, ccl.c, coding.c, composite.c, data.c, dosfns.c:
8 * font.c, image.c, keyboard.c, lread.c, menu.c, minibuf.c, msdos.c:
9 * print.c, syntax.c, window.c, xmenu.c, xselect.c: Replace direct
10 access to `contents' member of Lisp_Vector objects with AREF and ASET
11 where appropriate.
12
c6bf3022
CY
132012-06-19 Chong Yidong <cyd@gnu.org>
14
15 * frame.c (delete_frame): When selecting a frame on a different
16 text terminal, do not alter the terminal's top-frame.
17
18 * xdisp.c (format_mode_line_unwind_data): Record the target
19 frame's selected window and its terminal's top-frame.
20 (unwind_format_mode_line): Restore them.
21 (x_consider_frame_title, display_mode_line, Fformat_mode_line):
22 Callers changed.
23 (x_consider_frame_title): Do not condition on HAVE_WINDOW_SYSTEM,
24 since tty frames can be explicitly named.
25 (prepare_menu_bars): Likewise.
26
27 * term.c (Ftty_top_frame): New function.
28
defd4196
PE
292012-06-18 Paul Eggert <eggert@cs.ucla.edu>
30
31 Port byte-code-meter to modern targets.
32 * bytecode.c (METER_CODE) [BYTE_CODE_METER]: Don't assume
33 !CHECK_LISP_OBJECT_TYPE && !USE_LSB_TAG. Problem with
34 CHECK_LISP_OBJECT_TYPE reported by Dmitry Andropov in
35 <http://lists.gnu.org/archive/html/emacs-devel/2012-06/msg00282.html>.
36 (METER_1, METER_2): Simplify.
37
1053a871
SM
382012-06-18 Stefan Monnier <monnier@iro.umontreal.ca>
39
40 * data.c (Fdefalias): Return `symbol' (bug#11686).
41
b7e8d081
MR
422012-06-18 Martin Rudalics <rudalics@gmx.at>
43
44 * buffer.c (Fkill_buffer): Don't throw an error when the buffer
1053a871
SM
45 gets killed during executing of this function (Bug#11665).
46 Try to always return Qt when the buffer has been actually killed.
b7e8d081
MR
47 (Vkill_buffer_query_functions): In doc-string say that functions
48 run by this hook should not change the current buffer.
49
7ea2b339
PE
502012-06-18 Paul Eggert <eggert@cs.ucla.edu>
51
52 Fix recently-introduced process.c problems found by static checking.
53 * process.c (write_queue_push, write_queue_pop, send_process):
54 Use ptrdiff_t, not int or EMACS_INT, for buffer lengths and offsets.
55 (write_queue_pop): Fix pointer signedness problem.
56 (send_process): Remove unused local.
57
96a313a1
CY
582012-06-17 Chong Yidong <cyd@gnu.org>
59
60 * xdisp.c (redisplay_internal): No need to redisplay terminal
61 frames that are not on top.
62
20ca2e94
TN
632012-06-17 Troels Nielsen <bn.troels@gmail.com>
64
65 * process.c (make_process): Initialize write_queue.
66 (write_queue_push, write_queue_pop): New functions.
67 (send_process): Use them to maintain correct ordering of process
68 writes (Bug#10815).
69
9a900ca9
PE
702012-06-17 Paul Eggert <eggert@cs.ucla.edu>
71
310fbfa8
PE
72 * lisp.h (eassert): Assume C89 or later.
73 This removes the need for CHECK.
74 (CHECK): Remove. Its comments about always evaluating its
75 argument were confusing, as 'eassert' typically does not evaluate
76 its argument.
77
27bb1ca4
PE
78 * coding.c (produce_chars): Use ptrdiff_t, not int.
79
9a900ca9
PE
80 * xterm.c (x_draw_underwave): Check for integer overflow.
81 This pacifies gcc 4.7.0 -Wunsafe-loop-optimizations on x86-64.
82
41b7f8bc 832012-06-17 Jan Djärv <jan.h.d@swipnet.se>
50a93863
JD
84
85 * nsterm.m (x_free_frame_resources): Move xfree so freed memory isn't
86 referenced (Bug#11583).
87
9b0e3eba
AA
882012-06-16 Aurelien Aptel <aurelien.aptel@gmail.com>
89
90 Implement wave-style variant of underlining.
91 * dispextern.h (face_underline_type): New enum.
92 (face): Add field for underline type.
93 * nsterm.m (ns_draw_underwave): New function.
94 (ns_draw_text_decoration): Use it.
95 * w32term.c (w32_restore_glyph_string_clip, w32_draw_underwave):
96 New functions.
97 (x_draw_glyph_string): Use them.
98 * xfaces.c (Qline, Qwave): New Lisp objects.
99 (check_lface_attrs, merge_face_ref)
1053a871
SM
100 (Finternal_set_lisp_face_attribute, realize_x_face):
101 Handle wave-style underline face attributes.
9b0e3eba
AA
102 * xterm.c (x_draw_underwave): New function.
103 (x_draw_glyph_string): Use it.
104
0fb52f11
JB
1052012-06-16 Juanma Barranquero <lekktu@gmail.com>
106
107 * makefile.w32-in ($(BLD)/emacs.$(O), $(BLD)/fringe.$(O))
108 ($(BLD)/xml.$(O), $(BLD)/intervals.$(O), $(BLD)/macros.$(O))
109 ($(BLD)/minibuf.$(O), $(BLD)/regex.$(O), $(BLD)/region-cache.$(O))
110 ($(BLD)/textprop.$(O), $(BLD)/undo.$(O), $(BLD)/window.$(O))
111 ($(BLD)/w32select.$(O)): Update dependencies.
112
e5560ff7
AS
1132012-06-16 Andreas Schwab <schwab@linux-m68k.org>
114
115 * buffer.h (FETCH_MULTIBYTE_CHAR): Define as inline.
116 (BUF_FETCH_MULTIBYTE_CHAR): Likewise.
117 * character.c (_fetch_multibyte_char_p): Remove.
118 * alloc.c: Include "character.h" before "buffer.h".
119 * bidi.c: Likewise.
120 * buffer.c: Likewise.
121 * bytecode.c: Likewise.
122 * callint.c: Likewise.
123 * callproc.c: Likewise.
124 * casefiddle.c: Likewise.
125 * casetab.c: Likewise.
126 * category.c: Likewise.
127 * cmds.c: Likewise.
128 * coding.c: Likewise.
129 * composite.c: Likewise.
130 * dired.c: Likewise.
131 * dispnew.c: Likewise.
132 * doc.c: Likewise.
133 * dosfns.c: Likewise.
134 * editfns.c: Likewise.
135 * emacs.c: Likewise.
136 * fileio.c: Likewise.
137 * filelock.c: Likewise.
138 * font.c: Likewise.
139 * fontset.c: Likewise.
140 * fringe.c: Likewise.
141 * indent.c: Likewise.
142 * insdel.c: Likewise.
143 * intervals.c: Likewise.
144 * keyboard.c: Likewise.
145 * keymap.c: Likewise.
146 * lread.c: Likewise.
147 * macros.c: Likewise.
148 * marker.c: Likewise.
149 * minibuf.c: Likewise.
150 * nsfns.m: Likewise.
151 * nsmenu.m: Likewise.
152 * print.c: Likewise.
153 * process.c: Likewise.
154 * regex.c: Likewise.
155 * region-cache.c: Likewise.
156 * search.c: Likewise.
157 * syntax.c: Likewise.
158 * term.c: Likewise.
159 * textprop.c: Likewise.
160 * undo.c: Likewise.
161 * unexsol.c: Likewise.
162 * w16select.c: Likewise.
163 * w32fns.c: Likewise.
164 * w32menu.c: Likewise.
165 * window.c: Likewise.
166 * xdisp.c: Likewise.
167 * xfns.c: Likewise.
168 * xmenu.c: Likewise.
169 * xml.c: Likewise.
170 * xselect.c: Likewise.
171
2f07e6af
EZ
1722012-06-16 Eli Zaretskii <eliz@gnu.org>
173
1053a871
SM
174 * xdisp.c (set_cursor_from_row): Don't dereference glyphs_end.
175 If all the glyphs of the glyph row came from strings, and we have no
2f07e6af 176 cursor positioning clues, put the cursor on the first glyph of the
1097afe4
EZ
177 row.
178 (handle_face_prop): Use chunk-relative overlay string index when
179 indexing into it->string_overlays array. (Bug#11653)
946fdb73
EZ
180 (set_cursor_from_row): Use the leftmost glyph as GLYPH_BEFORE, not
181 the rightmost. (Bug#11720)
2f07e6af 182
29b83cec
AS
1832012-06-16 Andreas Schwab <schwab@linux-m68k.org>
184
185 * category.h (CHAR_HAS_CATEGORY): Define as inline.
186 (CATEGORY_MEMBER): Enforce 1/0 value.
187 * category.c (_temp_category_set): Remove.
188
4c5501e9
EZ
1892012-06-16 Eli Zaretskii <eliz@gnu.org>
190
191 * window.c (Fdelete_other_windows_internal)
192 (Fdelete_window_internal): Don't access frame's mouse highlight
193 info of the initial frame. (Bug#11677)
194
2b570124
PE
1952012-06-14 Paul Eggert <eggert@cs.ucla.edu>
196
e93864f9
PE
197 * .gdbinit (xgetint): Fix recently-introduced paren typo.
198 Assume USE_2_TAGS_FOR_INTS.
199 (xreload): Adjust $tagmask width to match recent lisp.h change.
200
2b570124
PE
201 Simplify lisp.h in minor ways that should not affect code.
202 * lisp.h (USE_2_TAGS_FOR_INTS): Remove, as it was always defined.
203 (LISP_INT_TAG, case_Lisp_Int, LISP_STRING_TAG, LISP_INT_TAG_P)
204 (LISP_INT1_TAG, enum Lisp_Type, XINT, XUINT, make_number):
205 Simplify under the assumption that USE_2_TAGS_FOR_INTS is defined.
206 (INTTYPEBITS): New macro, for clarity.
207 (INTMASK, MOST_POSITIVE_FIXNUM): Use it.
1053a871
SM
208 (LISP_INT1_TAG, LISP_STRING_TAG, LISP_INT_TAG_P):
209 Simplify now that USE_LSB_TAG is always defined.
2b570124
PE
210 (TYPEMASK, XINT) [USE_LSB_TAG]: Remove unnecessary cast.
211 (make_number) [!USE_LSB_TAG]: Use INTMASK; that's simpler.
212
81755f69
JB
2132012-06-13 Juanma Barranquero <lekktu@gmail.com>
214
215 * makefile.w32-in ($(BLD)/data.$(O)): Update dependencies.
216
16192a57
GM
2172012-06-13 Glenn Morris <rgm@gnu.org>
218
219 * s/bsd-common.h (BSD4_3):
220 * s/usg5-4-common.h (USG5_4): No longer define; unused.
221
646b5f55
AS
2222012-06-13 Andreas Schwab <schwab@linux-m68k.org>
223
224 * lisp.h (Lisp_Object) [CHECK_LISP_OBJECT_TYPE]: Define as struct
225 instead of union.
226 (XLI, XIL): Define.
1053a871
SM
227 (XHASH, XTYPE, XINT, XUINT, make_number, XSET, XPNTR, XUNTAG):
228 Use them.
229 * emacs.c (gdb_use_struct): Rename from gdb_use_union.
646b5f55 230 * .gdbinit: Check gdb_use_struct instead of gdb_use_union.
1053a871 231 * alloc.c (widen_to_Lisp_Object): Remove.
646b5f55
AS
232 (mark_memory): Use XIL instead of widen_to_Lisp_Object.
233 * frame.c (delete_frame): Remove outdated comment.
234 * w32fns.c (Fw32_register_hot_key): Use XLI instead of checking
235 USE_LISP_UNION_TYPE.
236 (Fw32_unregister_hot_key): Likewise.
237 (Fw32_toggle_lock_key): Likewise.
238 * w32menu.c (add_menu_item): Likewise.
239 (w32_menu_display_help): Use XIL instead of checking
240 USE_LISP_UNION_TYPE.
241 * w32heap.c (allocate_heap): Don't check USE_LISP_UNION_TYPE.
242 (init_heap): Likewise.
243 * w32term.c (w32_read_socket): Update comment.
244
1d3823c9
GM
2452012-06-13 Glenn Morris <rgm@gnu.org>
246
c62ff706
GM
247 * s/usg5-4-common.h, src/s/unixware.h:
248 Remove define/undef of HAVE_SYSV_SIGPAUSE (not used since 2010-05-04).
249
1d3823c9
GM
250 * s/gnu.h (POSIX_SIGNALS): Remove (not used since 2010-05-04).
251
bfe3e0a2
PE
2522012-06-13 Paul Eggert <eggert@cs.ucla.edu>
253
254 USE_LISP_UNION_TYPE + USE_LSB_TAG cleanup (Bug#11604)
255 * alloc.c (make_number) [!defined make_number]:
256 Remove, as lisp.h always defines this now.
257 (mark_maybe_pointer): Simplify since USE_LSB_TAG is always defined now.
258 (roundup_size): Verify that it is a power of 2.
259 * data.c (Fmake_variable_buffer_local, Fmake_local_variable):
260 * ftfont.c (ftfont_driver): Use LISP_INITIALLY_ZERO.
261 * lisp.h (USE_LSB_TAG): Allow the builder to compile with
262 -DUSE_LSB_TAG=0, to override the automatically-selected default.
263 USE_LSB_TAG now is always defined to be either 0 or 1.
264 All uses changed.
265 (union Lisp_Object): Don't worry about WORDS_BIGENDIAN; the
266 code works fine either way, and efficiency is not a concern here,
267 as the union type is for debugging, not for production.
268 (LISP_MAKE_RVALUE, make_number) [USE_LISP_UNION_TYPE]:
269 Use an inline function on all platforms when using the union type,
270 since this is simpler and 'static inline' can be used portably
271 within Emacs now.
272 (LISP_INITIALLY_ZERO): New macro.
273 (XFASTINT, XSETFASTINT) [USE_LISP_UNION_TYPE]: Remove.
274 (XSET) [USE_LISP_UNION_TYPE]: Don't overparenthesize.
275
45fa9c0f
GM
2762012-06-12 Glenn Morris <rgm@gnu.org>
277
b4492cba
GM
278 * s/gnu-kfreebsd.h, s/hpux11.h, s/openbsd.h, s/sol2-10.h: Remove files.
279
280 * s/gnu-linux.h (HAVE_PROCFS): Move to configure.
0d369729 281
45fa9c0f
GM
282 * s/hpux10-20.h, s/openbsd.h, s/usg5-4-common.h:
283 Move BROKEN_SIGIO to configure.
284
285 * s/bsd-common.h, s/darwin.h, s/gnu-kfreebsd.h, s/hpux10-20.h:
286 Move NO_TERMIO to configure.
287
0e25d334
CY
2882012-06-12 Chong Yidong <cyd@gnu.org>
289
290 * image.c (imagemagick_load_image): Use MagickFlattenImage if
291 MagickMergeImageLayers is undefined. Use pixel pusher loop if
292 MagickExportImagePixels is undefined.
293
43682bb6
PE
2942012-06-12 Paul Eggert <eggert@cs.ucla.edu>
295
296 * image.c (imagemagick_load_image): Remove unused label.
297
a9be7d2b
GM
2982012-06-11 Glenn Morris <rgm@gnu.org>
299
300 * s/aix4-2.h, s/bsd-common.h, s/cygwin.h, s/darwin.h:
301 * s/gnu-kfreebsd.h, s/gnu-linux.h, s/gnu.h, s/hpux10-20.h:
302 * s/irix6-5.h, s/ms-w32.h, s/msdos.h, s/template.h:
303 * s/usg5-4-common.h: Move SYSTEM_TYPE to configure.
304
3017f87f
SM
3052012-06-11 Stefan Monnier <monnier@iro.umontreal.ca>
306
307 * alloc.c (make_byte_code): New function.
308 (Fmake_byte_code): Use it. Don't purify here.
309 * lread.c (read1): Use it as well to avoid extra allocation.
310
1b9b4cf4
CY
3112012-06-11 Chong Yidong <cyd@gnu.org>
312
313 * image.c (imagemagick_load_image): Implement transparency.
314
95988fcf
AS
3152012-06-10 Andreas Schwab <schwab@linux-m68k.org>
316
317 * regex.c (at_begline_loc_p): Also recognize `(?N:' and correctly
318 account for preceding backslashes. (Bug#11663)
319
cd4eb164
CY
3202012-06-09 Chong Yidong <cyd@gnu.org>
321
322 * term.c: Support italics in capable terminals (Bug#9652).
323 (no_color_bit): Replace unused NC_BLINK with NC_ITALIC.
324 (turn_on_face): Output using TS_enter_italic_mode if available.
325 Don't handle unused blinking and alt-charset cases.
326 (turn_off_face): Handle italic case; discard unused tty_blinking_p
327 and tty_alt_charset_p cases.
328 (tty_capable_p, init_tty): Support italics.
329
330 * termchar.h (struct tty_display_info): Add field for italics.
331 Remove unused blink field.
332
333 * xfaces.c (tty_supports_face_attributes_p, realize_tty_face):
334 Handle slant.
335
336 * dispextern.h: Replace unused TTY_CAP_BLINK with TTY_CAP_ITALIC.
337 (struct face): Remove unused fields tty_dim_p, tty_blinking_p, and
338 tty_alt_charset_p. Add tty_italic_p.
339
ff88beb8
MA
3402012-06-09 Michael Albinus <michael.albinus@gmx.de>
341
342 * dbusbind.c (XD_BASIC_DBUS_TYPE): Use dbus_type_is_valid and
343 dbus_type_is_basic if available.
344 (xd_extract_signed, xd_extract_unsigned): Rename from
345 extract_signed and extract_unsigned, respectively. Adapt callers.
346
44286096
CY
3472012-06-09 Chong Yidong <cyd@gnu.org>
348
1682701f
CY
349 * xfaces.c (face_for_overlay_string): Handle face remapping (Bug#2066).
350
44286096
CY
351 * fringe.c (Fset_fringe_bitmap_face): Handle the noninteractive
352 case (Bug#9752).
353
d86feb17
PE
3542012-06-08 Paul Eggert <eggert@cs.ucla.edu>
355
356 * xdisp.c (vmessage): Treat frame message as multibyte.
357 Without this change, (let ((§ 1)) (make-variable-buffer-local '§))
358 would generate the diagnostic "Making \302\247 buffer-local while
359 let-bound!".
360
d5c20fe8
EZ
3612012-06-08 Eli Zaretskii <eliz@gnu.org>
362
363 * dispnew.c (showing_window_margins_p): Undo last change, which
364 was done due to an inadvertent commit.
365 (adjust_frame_glyphs_for_frame_redisplay): Do call
366 showing_window_margins_p.
367
513749ee
SM
3682012-06-08 Stefan Monnier <monnier@iro.umontreal.ca>
369
370 * eval.c (Fmake_var_non_special): New primitive.
371 (syms_of_eval): Defsubr it.
372 * lread.c (syms_of_lread): Mark `values' as lexically scoped.
373
d4a8f5c1
JB
3742012-06-08 Juanma Barranquero <lekktu@gmail.com>
375
376 * dispnew.c (showing_window_margins_p): Wrap in #if 0 to prevent unused
377 function warning (the only call is inside #if 0 since 2012-06-08T08:44:45Z!eliz@gnu.org).
378
8bbbc977
EZ
3792012-06-08 Eli Zaretskii <eliz@gnu.org>
380
381 * alloc.c (allocate_vectorlike): Fix last change.
382
f3372c87
DA
3832012-06-08 Dmitry Antipov <dmantipov@yandex.ru>
384
385 Block-based vector allocation of small vectors.
386 * lisp.h (struct vectorlike_header): New field `nbytes',
387 adjust comment accordingly.
388 * alloc.c (enum mem_type): New type `MEM_TYPE_VECTOR_BLOCK'
389 to denote vector blocks. Adjust users (live_vector_p,
390 mark_maybe_pointer, valid_lisp_object_p) accordingly.
391 (COMMON_MULTIPLE): Move outside #if USE_LSB_TAG.
392 (VECTOR_BLOCK_SIZE, vroundup, VECTOR_BLOCK_BYTES),
393 (VBLOCK_BYTES_MIN, VBLOCK_BYTES_MAX, VECTOR_MAX_FREE_LIST_INDEX),
394 (VECTOR_FREE_LIST_FLAG, ADVANCE, VINDEX, SETUP_ON_FREE_LIST),
395 (VECTOR_SIZE, VECTOR_IN_BLOCK): New macros.
396 (roundup_size): New constant.
397 (struct vector_block): New data type.
398 (vector_blocks, vector_free_lists, zero_vector): New variables.
513749ee 399 (all_vectors): Rename to `large_vectors'.
f3372c87
DA
400 (allocate_vector_from_block, init_vectors, allocate_vector_from_block)
401 (sweep_vectors): New functions.
402 (allocate_vectorlike): Return `zero_vector' as the only vector of
403 0 items. Allocate new vector from block if vector size is less than
404 or equal to VBLOCK_BYTES_MAX.
405 (Fgarbage_collect): Move all vector sweeping code to sweep_vectors.
406 (init_alloc_once): Add call to init_vectors.
407
4f18a4ed
SM
4082012-06-08 Stefan Monnier <monnier@iro.umontreal.ca>
409
410 * eval.c (Fmacroexpand): Stop if the macro returns the same form.
411
86f158bc
PE
4122012-06-07 Paul Eggert <eggert@cs.ucla.edu>
413
414 * doprnt.c (doprnt): Truncate multibyte char correctly.
415 Without this change, doprnt (buf, 2, "%s", FORMAT_END, AP)
416 would mishandle a string argument "Xc" if X was a multibyte
417 character of length 2: it would truncate after X's first byte
418 rather than including all of X.
419
c5cfcbe0
CY
4202012-06-06 Chong Yidong <cyd@gnu.org>
421
422 * buffer.c (word_wrap): Doc fix.
423
c05cf390
PE
4242012-06-04 Paul Eggert <eggert@cs.ucla.edu>
425
426 * xdisp.c (note_mode_line_or_margin_highlight): Pacify gcc -Wall.
427
0c3461de
GM
4282012-06-03 Glenn Morris <rgm@gnu.org>
429
430 * xdisp.c (tool-bar-style): Doc fix.
431
c71232db
UM
4322012-06-03 Ulrich Müller <ulm@gentoo.org>
433
434 * Makefile.in (PAXCTL): Define.
435 (temacs$(EXEEXT)): Disable memory randomization for the temacs
436 binary via PaX flags if the paxctl utility is available.
437 (emacs$(EXEEXT), bootstrap-emacs$(EXEEXT)):
438 Restore PaX flags to their default. (Bug#11398)
439
383f7350
CY
4402012-06-03 Chong Yidong <cyd@gnu.org>
441
442 * xdisp.c (decode_mode_spec_coding): Display a space for a unibyte
443 buffer (Bug#11226).
444
5f2c76c6
CY
4452012-06-03 Chong Yidong <cyd@gnu.org>
446
447 * xdisp.c (calc_pixel_width_or_height): Use Fbuffer_local_value.
448 (note_mode_line_or_margin_highlight): If there is no help echo,
449 use mode-line-default-help-echo. Handle the case where the mouse
450 position is past the end of the mode line string.
451
452 * buffer.c (buffer_local_value_1): New function, split from
453 Fbuffer_local_value; can return Qunbound.
454 (Fbuffer_local_value): Use it.
455 (Vmode_line_format): Docstring tweaks.
456
773d47f6
PE
4572012-06-02 Paul Eggert <eggert@cs.ucla.edu>
458
459 * sysdep.c (system_process_attributes): Improve comment.
460
f2d6a3df
SM
4612012-06-02 Stefan Monnier <monnier@iro.umontreal.ca>
462
463 * keyboard.c: Export real-this-command to Elisp.
464 (syms_of_keyboard): Rename real_this_command to Vreal_this_command
465 and DEFVAR it. Update all users.
466
63810350
PE
4672012-06-02 Paul Eggert <eggert@cs.ucla.edu>
468
7bd5c1f4
PE
469 * minibuf.c (Fassoc_string): Remove duplicate declaration.
470
63810350
PE
471 * sysdep.c (system_process_attributes) [SOLARIS2 && HAVE_PROCFS]:
472 Convert pctcpu and pctmem to Lisp float properly.
473 Let the compiler fold better, as 100.0/0x8000 is exact.
474
a2821611
AS
4752012-06-02 Andreas Schwab <schwab@linux-m68k.org>
476
477 * alloc.c (CONS_BLOCK_SIZE): Account for padding at the end of
478 cons_block.
479
5fceba1d
PE
4802012-06-01 Paul Eggert <eggert@cs.ucla.edu>
481
482 * xfns.c (x_set_tool_bar_lines) [USE_GTK]: Adjust to bitfield change.
483
c98ff5dd
DA
4842012-06-01 Dmitry Antipov <dmantipov@yandex.ru>
485
486 For a 'struct window', replace some Lisp_Object fields to
487 bitfields where appropriate, remove unused fields.
488 * window.h (struct window): Remove unused 'last_mark_x' and
489 'last_mark_y' fields. Rename 'mini_p' field to 'mini',
490 change it's type from Lisp_Object to bitfield.
491 Change type of 'force_start', 'optional_new_start',
492 'last_had_star', 'update_mode_line' and 'start_at_line_beg'
493 fields from Lisp_Object to bitfield. Adjust users accordingly.
494
ca34e0be
PE
4952012-05-31 Paul Eggert <eggert@cs.ucla.edu>
496
497 Pacify gcc -Wdouble-precision when using Xaw.
498 * xterm.c (xaw_jump_callback, x_set_toolkit_scroll_bar_thumb)
499 [HAVE_X_WINDOWS && USE_TOOLKIT_SCROLL_BARS && !USE_MOTIF && !USE_GTK]:
500 Use 'float' consistently, rather than 'float' in most places
501 and 'double' in a couple of places.
502
efc00ab1 5032012-05-31 Eli Zaretskii <eliz@gnu.org>
d5fd2c54
EZ
504
505 * xdisp.c (handle_stop): Detect whether we have overlay strings
506 loaded by testing it->current.overlay_string_index to be
507 non-negative, instead of checking whether n_overlay_strings is
508 positive. (Bug#11587)
509
efc00ab1 5102012-05-31 Chong Yidong <cyd@gnu.org>
353c87f6
CY
511
512 * keymap.c (describe_map_tree): Revert 2011-07-07 change (Bug#1169).
513
514 * doc.c (Fsubstitute_command_keys): Doc fix.
515
efc00ab1 5162012-05-31 Eli Zaretskii <eliz@gnu.org>
a02ae4e5
EZ
517
518 * search.c (search_buffer): Remove calls to
519 r_alloc_inhibit_buffer_relocation, as it is now called by
520 maybe_unify_char, which was the cause of relocation of buffer text
521 in bug#11519.
522
efc00ab1 5232012-05-31 Eli Zaretskii <eliz@gnu.org>
291d430f
EZ
524
525 * charset.c (maybe_unify_char): Inhibit relocation of buffer text
526 for the duration of call to load_charset, to avoid problems with
527 callers of maybe_unify_char that access buffer text through C
528 pointers.
529
530 * ralloc.c (r_alloc_inhibit_buffer_relocation): Increment and
531 decrement the inhibition flag, instead of just setting or
532 resetting it.
533
ba93a187
PE
5342012-05-31 Paul Eggert <eggert@cs.ucla.edu>
535
536 Remove obsolete '#define static' cruft.
537 * s/hpux10-20.h (_FILE_OFFSET_BITS): Don't #undef.
538 This #undef was "temporary" in 2000; it is no longer needed
539 now that '#define static' has gone away.
540 * xfns.c, xterm.h (gray_bitmap_width, gray_bitmap_height)
541 (gray_bitmap_bits): Remove; no longer needed.
542 All uses replaced with definiens.
543 * xterm.c: Include "bitmaps/gray.xbm".
544
9e4bf381
PE
5452012-05-30 Paul Eggert <eggert@cs.ucla.edu>
546
547 Clean up __executable_start, monstartup when --enable-profiling.
548 The following changes affect the code only when profiling.
549 * dispnew.c (__executable_start): Rename from safe_bcopy.
550 Define only on platforms that need it.
551 * emacs.c: Include <sys/gmon.h> when profiling.
552 (_mcleanup): Remove decl, since <sys/gmon.h> does it now.
553 (__executable_start): Remove decl, since lisp.h does it now.
554 (safe_bcopy): Remove decl; no longer has that name.
555 (main): Coalesce #if into single bit of code, for simplicity.
556 Cast pointers to uintptr_t, since standard libraries want integers
557 and not pointers.
558 * lisp.h (__executable_start): New decl.
559
32d72c2f
GM
5602012-05-31 Glenn Morris <rgm@gnu.org>
561
562 * image.c (Fimagemagick_types): Doc fix.
563
baac5bc7
JM
5642012-05-30 Jim Meyering <meyering@redhat.com>
565
566 * callproc.c (Fcall_process_region): Include directory component
567 in mkstemp error message (Bug#11586).
568
72cb32cf
PE
5692012-05-30 Paul Eggert <eggert@cs.ucla.edu>
570
571 * alloc.c, lisp.h (make_pure_vector): Now static.
572
61b108cc
SM
5732012-05-30 Stefan Monnier <monnier@iro.umontreal.ca>
574
575 * eval.c (Fdefun, Fdefmacro, Vmacro_declaration_function):
576 Move to byte-run.el.
577 (Fautoload): Do the hash-doc more carefully.
578 * data.c (Fdefalias): Purify definition, except for keymaps.
579 (Qdefun): Move from eval.c.
580 * lisp.h (Qdefun): Remove.
581 * lread.c (read1): Tiny simplification.
582
471fe23d
TN
5832012-05-29 Troels Nielsen <bn.troels@gmail.com>
584
934f3f58 585 Do not create empty overlays with the evaporate property (Bug#9642).
471fe23d
TN
586 * buffer.c (Fmove_overlay): Reinstate the earlier fix for
587 Bug#9642, but explicitly check that the buffer the overlay would
588 be moved to is live and rearrange lines to make sure that errors
589 will not put the overlay in an inconsistent state.
590 (Fdelete_overlay): Cosmetics.
591
85d0efd1
EZ
5922012-05-28 Eli Zaretskii <eliz@gnu.org>
593
594 * w32term.c (my_bring_window_to_top): New function.
595 (x_raise_frame): Use handle returned by DeferWindowPos, which
61b108cc
SM
596 could be different from the original one.
597 Call my_bring_window_to_top instead of my_set_foreground_window.
85d0efd1
EZ
598 (Bug#11513)
599
600 * w32fns.c (w32_wnd_proc): Accept and process WM_EMACS_BRINGTOTOP
601 by calling BringWindowToTop.
602
603 * w32term.h (WM_EMACS_BRINGTOTOP): New message.
604 (WM_EMACS_END): Increase by one.
605
da92a98c
PE
6062012-05-28 Paul Eggert <eggert@cs.ucla.edu>
607
608 * bidi.c (bidi_mirror_char): Put eassert before conversion to int.
609 This avoids undefined behavior that might cause the eassert
610 to not catch an out-of-range value.
611
74d1f848
JB
6122012-05-28 Juanma Barranquero <lekktu@gmail.com>
613
614 * makefile.w32-in ($(BLD)/w32inevt.$(O), $(BLD)/w32console.$(O)):
615 Update dependencies.
616
9e1a06fc
EZ
6172012-05-27 Eli Zaretskii <eliz@gnu.org>
618
619 * bidi.c (bidi_mirror_char): Fix last change.
620
f3dd7312
AS
6212012-05-27 Andreas Schwab <schwab@linux-m68k.org>
622
623 * unexmacosx.c (copy_data_segment): Truncate after 16 characters
624 when referring to sectname field in printf format.
625
81899c91
PE
6262012-05-27 Paul Eggert <eggert@cs.ucla.edu>
627
57b81a9f
PE
628 * lisp.h [REL_ALLOC]: Omit duplicate prototypes.
629 Only r_alloc_inhibit_buffer_relocation needed to be added;
630 the others were already declared.
631
81899c91
PE
632 * bidi.c (bidi_mirror_char): Don't possibly truncate the integer
633 before checking whether it's out of range. Put the check inside
634 eassert. See
635 <http://lists.gnu.org/archive/html/emacs-devel/2012-05/msg00485.html>.
636
33017faf 6372012-05-27 Ken Brown <kbrown@cornell.edu>
2f9b9adb
KB
638
639 * callproc.c (Fcall_process): Restore a line that was accidentally
640 commented out in the 2011-02-13 change (bug#11547).
641
33017faf 6422012-05-27 Eli Zaretskii <eliz@gnu.org>
52c55cc7
EZ
643
644 * lisp.h [REL_ALLOC]: Add prototypes for external functions
645 defined on ralloc.c.
646
647 * buffer.c [REL_ALLOC]: Remove prototypes of
648 r_alloc_reset_variable, r_alloc, r_re_alloc, and r_alloc_free,
649 they are now on lisp.h.
650
651 * ralloc.c (r_alloc_inhibit_buffer_relocation): New function.
652
653 * search.c (search_buffer): Use it to inhibit relocation of buffer
654 text while re_search_2 is doing its job, because re_search_2 is
655 passed C pointers to buffer text. (Bug#11519)
656
23415acf
EZ
657 * msdos.c (internal_terminal_init) <Vwindow_system_version>:
658 Update value to 24.
659
44e27368
EZ
660 * xdisp.c (move_it_to): Under MOVE_TO_Y, when restoring iterator
661 state after an additional call to move_it_in_display_line_to, keep
662 the values of it->max_ascent and it->max_descent found for the
663 entire line.
664 (pos_visible_p): Revert the comparison against bottom_y to what it
665 was in revid eliz@gnu.org-20120513182235-4p6386j761ld0nwb.
666 (Bug#11464)
667
c1892f11
PE
6682012-05-26 Paul Eggert <eggert@cs.ucla.edu>
669
670 Fix coding-related core dumps with gcc -ftrapv.
671 The code was computing A - B, where A and B are pointers, and B is
672 random garbage. This can lead to core dumps on platforms that
673 have special pointer registers, and it also leads to core dumps on
674 x86-64 when compiled with gcc -ftrapv. The fix is to compute
675 A - B only when B is initialized properly.
676 * coding.c (coding_set_source, coding_set_destination): Return void.
677 (coding_change_source, coding_change_destinations): New functions,
678 with the old behaviors of coding_set_source and coding_set_destination.
679 All callers that need an offset changed to use these new functions.
680
eb7afdad
GM
6812012-05-26 Glenn Morris <rgm@gnu.org>
682
683 * nsterm.m (ns_init_paths): Don't mess with INFOPATH. (Bug#2791)
684
f12fdf02
EZ
6852012-05-26 Eli Zaretskii <eliz@gnu.org>
686
53a63be6 687 Extend mouse support on W32 text-mode console.
61b108cc
SM
688 * xdisp.c (draw_row_with_mouse_face):
689 Call tty_draw_row_with_mouse_face for WINDOWSNT as well.
eb3f6f01 690
eb3f6f01 691 * w32console.c: Include window.h.
61b108cc
SM
692 (w32con_write_glyphs_with_face, tty_draw_row_with_mouse_face):
693 New functions.
eb3f6f01
EZ
694 (initialize_w32_display): Initialize mouse-highlight data.
695
53a63be6
EZ
696 * w32inevt.c: Include termchar.h and window.h.
697 (do_mouse_event): Support mouse-autoselect-window. When the mouse
698 moves, call note_mouse_highlight. If help_echo changed, call
699 gen_help_event to produce help-echo message in the echo area.
700 Call clear_mouse_face if mouse_face_hidden is set in the mouse
701 highlight info.
702
4cfd81f6
PE
7032012-05-26 Paul Eggert <eggert@cs.ucla.edu>
704
705 * lread.c (read1): Simplify slightly to avoid an overflow warning
706 with GCC 4.7.0 on x86-64.
707
4446092a
EZ
7082012-05-26 Eli Zaretskii <eliz@gnu.org>
709
710 * bidi.c (bidi_mirror_char): Revert last change: an int is
711 definitely wide enough here.
712
42b2a986 7132012-05-25 Paul Eggert <eggert@cs.ucla.edu>
3164aeac 714
42b2a986 715 Fix integer width and related bugs (Bug#9874).
eb106a49 716 * alloc.c (pure_bytes_used_lisp, pure_bytes_used_non_lisp):
d311d28c
PE
717 (allocate_vectorlike, buffer_memory_full, struct sdata, SDATA_SIZE)
718 (string_bytes, check_sblock, allocate_string_data):
719 (compact_small_strings, Fmake_bool_vector, make_string)
720 (make_unibyte_string, make_multibyte_string)
721 (make_string_from_bytes, make_specified_string)
722 (allocate_vectorlike, Fmake_vector, find_string_data_in_pure)
723 (make_pure_string, make_pure_c_string, make_pure_vector, Fpurecopy)
724 (mark_vectorlike):
725 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
726 (allocate_pseudovector):
727 Use int, not EMACS_INT, where int is wide enough.
728 (inhibit_garbage_collection, Fgarbage_collect):
729 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
730 * bidi.c (bidi_mirror_char): Use EMACS_INT, not int, where
731 int might not be wide enough.
732 (bidi_cache_search, bidi_cache_find, bidi_init_it)
733 (bidi_count_bytes, bidi_char_at_pos, bidi_fetch_char)
734 (bidi_at_paragraph_end, bidi_find_paragraph_start)
735 (bidi_paragraph_init, bidi_resolve_explicit, bidi_resolve_weak)
736 (bidi_level_of_next_char, bidi_move_to_visually_next):
737 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
738 * buffer.c (copy_overlays, Fgenerate_new_buffer_name)
739 (Fkill_buffer, Fset_buffer_major_mode)
740 (advance_to_char_boundary, Fbuffer_swap_text)
741 (Fset_buffer_multibyte, overlays_at, overlays_in)
742 (overlay_touches_p, struct sortvec, record_overlay_string)
743 (overlay_strings, recenter_overlay_lists)
744 (adjust_overlays_for_insert, adjust_overlays_for_delete)
745 (fix_start_end_in_overlays, fix_overlays_before, modify_overlay)
746 (Fmove_overlay, Fnext_overlay_change, Fprevious_overlay_change)
747 (Foverlay_recenter, last_overlay_modification_hooks_used)
748 (report_overlay_modification, evaporate_overlays, enlarge_buffer_text):
749 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
977b0e45
PE
750 (validate_region): Omit unnecessary test for b <= e,
751 since that's guaranteed by the previous test.
d311d28c
PE
752 (adjust_overlays_for_delete): Avoid pos + length overflow.
753 (Fmove_overlay, Fdelete_overlay, add_overlay_mod_hooklist)
754 (report_overlay_modification):
755 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
756 (Foverlays_at, Fnext_overlay_change, Fprevious_overlay_change):
757 Omit pointer cast, which isn't needed anyway, and doesn't work
758 after the EMACS_INT -> ptrdiff_t change.
02481186 759 (Fmove_overlay): Clip BEG and END to ptrdiff_t to avoid overflow.
d311d28c
PE
760 * buffer.h: Adjust decls to match defn changes elsewhere.
761 (struct buffer_text, struct buffer):
762 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
763 Use EMACS_INT, not int, where int might not be wide enough.
39b5db3b
PE
764 * bytecode.c (unmark_byte_stack, exec_byte_code): Use ptrdiff_t,
765 not int, to avoid needless 32-bit limit on 64-bit hosts.
766 (exec_byte_code): Use tighter memory-full test, one that checks
767 for alloca overflow. Don't compute the address of the object just
768 before an array, as that's not portable. Use EMACS_INT, not
769 ptrdiff_t or int, where ptrdiff_t or int might not be wide enough.
d311d28c
PE
770 * callint.c (Fcall_interactively):
771 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
772 * callproc.c (call_process_kill, Fcall_process):
773 Don't assume pid_t fits into an Emacs fixnum.
774 (call_process_cleanup, Fcall_process, child_setup):
775 Don't assume pid_t fits into int.
776 (call_process_cleanup, Fcall_process, delete_temp_file)
777 (Fcall_process_region):
778 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
779 (Fcall_process): Simplify handling of volatile integers.
780 Use int, not EMACS_INT, where int will do.
781 * casefiddle.c (casify_object, casify_region, operate_on_word)
782 (Fupcase_word, Fdowncase_word, Fcapitalize_word):
783 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
784 (casify_object): Avoid integer overflow when overallocating buffer.
785 * casetab.c (set_identity, shuffle): Prefer int to unsigned when
45c2afd6 786 either works. Use lint_assume to convince GCC 4.6.1 that it's OK.
d311d28c
PE
787 * category.c (Fchar_category_set): Don't assume fixnum fits in int.
788 * category.h (CATEGORYP): Don't assume arg is nonnegative.
789 * ccl.c (GET_CCL_INT): Remove; no longer needed, since the
790 integers are now checked earlier. All uses replaced with XINT.
791 (ccl_driver):
792 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
793 For CCL_MapSingle, check that content and value are in int range.
c801946a
PE
794 (ccl_driver, Fregister_code_conversion_map):
795 Check that Vcode_version_map_vector is a vector.
d311d28c
PE
796 (resolve_symbol_ccl_program): Check that vector header is in range.
797 Always copy the vector, so that we can check its contents reliably
798 now rather than having to recheck each instruction as it's being
799 executed. Check that vector words fit in 'int'.
800 (ccl_get_compiled_code, Fregister_ccl_program)
801 (Fregister_code_conversion_map): Use ptrdiff_t, not int, for
802 program indexes, to avoid needless 32-bit limit on 64-bit hosts.
803 (Fccl_execute, Fccl_execute_on_string): Check that initial reg
804 contents are in range.
805 (Fccl_execute_on_string): Check that status is in range.
806 * ccl.h (struct ccl_program.idx): Now ptrdiff_t, not int.
807 * character.c (char_resolve_modifier_mask, Fchar_resolve_modifiers):
808 Accept and return EMACS_INT, not int, because callers can pass values
809 out of 'int' range.
810 (c_string_width, strwidth, lisp_string_width, chars_in_text)
811 (multibyte_chars_in_text, parse_str_as_multibyte)
812 (str_as_multibyte, count_size_as_multibyte, str_to_multibyte)
813 (str_as_unibyte, str_to_unibyte, string_count_byte8)
814 (string_escape_byte8, Fget_byte):
815 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
a14e1568 816 (Funibyte_string): Use CHECK_RANGED_INTEGER, not CHECK_NATNUM, to
d311d28c
PE
817 avoid mishandling large integers.
818 * character.h: Adjust decls to match defn changes elsewhere.
819 * charset.c (load_charset_map_from_file, find_charsets_in_text)
820 (Ffind_charset_region):
821 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
822 (load_charset_map_from_file): Redo idx calculation to avoid overflow.
823 (load_charset_map_from_vector, Fdefine_charset_internal):
3c7649c1 824 Don't assume fixnum fits in int.
d311d28c
PE
825 (load_charset_map_from_vector, Fmap_charset_chars):
826 Remove now-unnecessary CHECK_NATNUMs.
827 (Fdefine_charset_internal): Check ranges here, more carefully.
3c7649c1
PE
828 Don't rely on undefined behavior with signed left shift overflow.
829 Don't assume unsigned int fits into fixnum, or that fixnum fits
830 into unsigned int. Don't require max_code to be a valid fixnum;
831 that's not true for gb10830 4-byte on a 32-bit host. Allow
832 invalid_code to be a cons, for the same reason. Require code_offset
833 to be a character. Avoid int overflow if max_char is close
834 to INT_MAX.
835 (CODE_POINT_TO_INDEX): On 32-bit hosts, return int, not unsigned;
836 this is intended anyway and avoids some undefined behavior.
837 (load_charset_map): Pass unsigned, not int, as 2nd arg of
838 INDEX_TO_CODE_POINT, as that's what it expects.
839 (Funify_charset, encode_char): Don't stuff unsigned vals into int vars.
60ad3eab
PE
840 * charset.h (DECODE_CHAR): Return int, not unsigned;
841 this is what was intended anyway, and it avoids undefined behavior.
842 (CHARSET_OFFSET): Remove unused macro, instead of fixing its
843 integer-overflow issues.
844 (ENCODE_CHAR): Return unsigned on all hosts, not just on 32-bit hosts.
845 Formerly, it returned EMACS_INT on 64-bit hosts in the common case
846 where the argument is EMACS_INT, and this behavior is not intended.
d311d28c
PE
847 * chartab.c (Fmake_char_table, Fset_char_table_range)
848 (uniprop_get_decoder, uniprop_get_encoder):
849 Don't assume fixnum fits in int.
850 * cmds.c (move_point): New function, that does the gist of
851 Fforward_char and Fbackward_char, but does so while checking
852 for integer overflow more accurately.
c96e5d6a 853 (Fforward_char, Fbackward_char): Use it.
d311d28c
PE
854 (Fforward_line, Fend_of_line, internal_self_insert)
855 (internal_self_insert):
856 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
857 Fix a FIXME, by checking for integer overflow when calculating
858 target_clm and actual_clm.
859 * coding.c (detect_coding_XXX, encode_coding_XXX, CODING_DECODE_CHAR)
8f50130c 860 (CODING_ENCODE_CHAR, CODING_CHAR_CHARSET, CODING_CHAR_CHARSET_P)
d311d28c
PE
861 (ASSURE_DESTINATION, coding_alloc_by_realloc)
862 (coding_alloc_by_making_gap, alloc_destination)
863 (detect_coding_utf_8, encode_coding_utf_8, decode_coding_utf_16)
864 (encode_coding_utf_16, detect_coding_emacs_mule)
865 (decode_coding_emacs_mule, encode_coding_emacs_mule)
866 (detect_coding_iso_2022, decode_coding_iso_2022)
867 (encode_invocation_designation, encode_designation_at_bol)
868 (encode_coding_iso_2022, detect_coding_sjis, detect_coding_big5)
869 (decode_coding_sjis, decode_coding_big5, encode_coding_sjis)
870 (encode_coding_big5, detect_coding_ccl, decode_coding_ccl)
871 (encode_coding_ccl, encode_coding_raw_text)
872 (detect_coding_charset, decode_coding_charset)
873 (encode_coding_charset, detect_eol, decode_eol, produce_chars)
874 (produce_composition, produce_charset, produce_annotation)
875 (decode_coding, handle_composition_annotation)
876 (handle_charset_annotation, consume_chars, decode_coding_gap)
877 (decode_coding_object, encode_coding_object, detect_coding_system)
878 (Ffind_coding_systems_region_internal, Fcheck_coding_systems_region)
879 (code_convert_region, code_convert_string)
8f50130c
PE
880 (Fdefine_coding_system_internal)
881 (coding_set_source, coding_set_destination):
d311d28c
PE
882 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
883 (setup_iso_safe_charsets, consume_chars, Funencodable_char_position)
884 (Fdefine_coding_system_internal):
885 Don't assume fixnums fit in int.
886 (decode_coding_gap, decode_coding_object, encode_coding_object)
5895d7b9 887 (Fread_coding_system, Fdetect_coding_region)
2c6a9faa
PE
888 (Funencodable_char_position, Fcheck_coding_systems_region)
889 (get_translation, handle_composition_annotation, consume_chars):
d311d28c 890 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
977b0e45 891 (consume_chars): Rewrite to not calculate an address outside buffer.
d311d28c 892 (Ffind_operation_coding_system): NATNUMP can eval its arg twice.
7b09a37a 893 Don't access memory outside of the args array.
d311d28c 894 (Fdefine_coding_system_internal): Check for charset-id overflow.
47664caa
PE
895 (ENCODE_ISO_CHARACTER): Use unsigned, not int, to store the unsigned
896 result of ENCODE_CHAR.
d311d28c
PE
897 * coding.h: Adjust decls to match defn changes elsewhere.
898 (struct coding_system):
899 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
900 * composite.c (get_composition_id, find_composition)
901 (run_composition_function, update_compositions)
902 (compose_text, composition_gstring_put_cache)
903 (composition_gstring_p, composition_gstring_width)
904 (fill_gstring_header, fill_gstring_body, autocmp_chars)
905 (composition_compute_stop_pos, composition_reseat_it)
906 (composition_update_it, struct position_record)
907 (find_automatic_composition, composition_adjust_point)
908 (Fcomposition_get_gstring, Ffind_composition_internal):
909 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
910 (update_compositions):
911 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
912 * composite.h: Adjust decls to match defn changes elsewhere.
913 (struct composition):
914 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
915 * data.c (let_shadows_buffer_binding_p, let_shadows_global_binding_p):
916 Do not attempt to compute the address of the object just before a
917 buffer; this is not portable.
918 (Faref, Faset):
919 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
920 (Faset): Use int, not EMACS_INT, where int is wide enough.
921 (Fstring_to_number): Don't assume fixnums fit in int.
922 (Frem): Don't assume arg is nonnegative.
923 * dbusbind.c (xd_append_arg): Check for integers out of range.
924 (Fdbus_call_method): Don't overflow the timeout int.
42b2a986 925 (extract_signed, extract_unsigned): New functions.
243e0530
PE
926 (XD_CHECK_DBUS_SERIAL): Remove; superseded by extract_unsigned.
927 (xd_get_connection_references): Return ptrdiff_t, not int.
928 All uses changed.
929 (xd_signature, xd_append_arg, xd_retrieve_arg, Fdbus_message_internal)
930 (xd_read_message_1):
931 Use int, not unsigned, where the dbus API uses int.
932 (Fdbus_message_internal): Don't overflow mtype.
933 (syms_of_dbusbind): Allocate right-sized buffer for integers.
d311d28c
PE
934 * dired.c (directory_files_internal, file_name_completion, scmp)
935 (file_name_completion_stat):
936 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
937 (file_name_completion): Don't overflow matchcount.
938 (file_name_completion_stat): Use SAFE_ALLOCA, not alloca.
939 * dispextern.h: Adjust decls to match defn changes elsewhere.
940 (struct text_pos, struct glyph, struct bidi_saved_info)
941 (struct bidi_string_data, struct bidi_it, struct composition_it)
942 (struct it):
943 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
944 (struct display_pos, struct composition_it, struct it):
945 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
946 * dispnew.c (increment_matrix_positions)
947 (increment_row_positions, mode_line_string)
948 (marginal_area_string):
949 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
54e1617f 950 (change_frame_size_1, Fredisplay, Fframe_or_buffer_changed_p):
d311d28c
PE
951 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
952 (duration_to_sec_usec): New function, to check for overflow better.
953 (Fsleep_for, sit_for): Use it.
954 * doc.c (get_doc_string, store_function_docstring):
955 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
956 (get_doc_string, Fsnarf_documentation):
957 Use int, not EMACS_INT, where int is wide enough.
958 (get_doc_string):
959 Use SAFE_ALLOCA, not alloca.
960 Check for overflow when converting EMACS_INT to off_t.
961 * doprnt.c (doprnt):
962 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
963 * editfns.c (init_editfns, Fuser_uid, Fuser_real_uid):
964 Don't assume uid_t fits into fixnum.
965 (buildmark, Fgoto_char, overlays_around, find_field, Fdelete_field)
966 (Ffield_string, Ffield_string_no_properties, Ffield_beginning)
967 (Ffield_end, Fconstrain_to_field, Fline_beginning_position)
968 (Fline_end_position, Fprevious_char, Fchar_after, Fchar_before)
969 (general_insert_function)
970 (Finsert_char, make_buffer_string, make_buffer_string_both)
971 (update_buffer_properties, Fbuffer_substring)
972 (Fbuffer_substring_no_properties, Fcompare_buffer_substrings)
973 (Fsubst_char_in_region, check_translation)
974 (Ftranslate_region_internal, save_restriction_restore, Fformat)
975 (transpose_markers, Ftranspose_regions):
976 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
977 (clip_to_bounds): Move to lisp.h as an inline function).
978 (Fconstrain_to_field): Don't assume integers are nonnegative.
979 (Fline_beginning_position, Fsave_excursion, Fsave_current_buffer):
980 (Fsubst_char_in_region, Fsave_restriction):
981 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
982 (Femacs_pid): Don't assume pid_t fits into fixnum.
983 (lo_time): Use int, not EMACS_INT, when int suffices.
984 (lisp_time_argument): Check for usec out of range.
985 (Fencode_time): Don't assume fixnum fits in int.
3f4eabd1
PE
986 (Fuser_login_name, Fuser_full_name): Signal an error
987 if a uid argument is out of range, rather than relying on
988 undefined behavior.
c8d5c857
PE
989 (Fformat_time_string): Remove now-unnecessary check.
990 lisp_time_argument checks for out-of-range usec now.
243e0530 991 Use ptrdiff_t, not size_t, where ptrdiff_t will do.
d311d28c
PE
992 * emacs.c (gdb_valbits, gdb_gctypebits): Now int, not EMACS_INT.
993 (gdb_data_seg_bits): Now uintptr_t, not EMACS_INT.
994 (PVEC_FLAG, gdb_array_mark_flag): Now ptrdiff_t, not EMACS_INT.
995 (init_cmdargs, Fdump_emacs):
996 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
997 (Fkill_emacs): Don't assume fixnum fits in int; instead, take just
998 the bottom (typically) 32 bits of the fixnum.
999 * eval.c (specpdl_size, call_debugger):
1000 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1001 (when_entered_debugger, Fbacktrace_debug):
1002 Don't assume fixnum can fit in int.
1003 (Fdefvaralias, Fdefvar): Do not attempt to compute the address of
1004 the object just before a buffer; this is not portable.
1005 (FletX, Flet, Funwind_protect, do_autoload, Feval, funcall_lambda)
1006 (grow_specpdl, unbind_to):
1007 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1008 (Fapply, apply_lambda): Don't assume ptrdiff_t can hold fixnum.
1009 (grow_specpdl): Simplify allocation by using xpalloc.
856bbc81 1010 (Fprog1, Fprog2): Don't assume list length fits in int. Simplify.
d311d28c
PE
1011 * fileio.c (Ffind_file_name_handler, Fcopy_file, Frename_file)
1012 (Finsert_file_contents, Fwrite_region, Fdo_auto_save):
1013 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1014 (Ffind_file_name_handler, non_regular_inserted, Finsert_file_contents)
1015 (a_write, e_write):
1016 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1017 (Fcopy_file, non_regular_nbytes, read_non_regular)
1018 (Finsert_file_contents):
1019 Use int, not EMACS_INT, where int is wide enough.
1020 (READ_BUF_SIZE): Verify that it fits in int.
1021 (Finsert_file_contents): Check that counts are in proper range,
1022 rather than assuming fixnums fit into ptrdiff_t etc.
1023 Don't assume fixnums fit into int.
125b3835 1024 * floatfns.c (Fexpt): Avoid undefined signed * signed overflow.
5895d7b9
PE
1025 * fns.c (Fcompare_strings, Fstring_lessp, struct textprop_rec, concat)
1026 (string_char_byte_cache_charpos, string_char_byte_cache_bytepos)
d311d28c
PE
1027 (string_char_to_byte, string_byte_to_char)
1028 (string_make_multibyte, string_to_multibyte)
1029 (string_make_unibyte, Fstring_as_unibyte, Fstring_as_multibyte)
1030 (Fstring_to_unibyte, Fsubstring, Fsubstring_no_properties)
1031 (substring_both, Fdelete, internal_equal, Ffillarray)
1032 (Fclear_string, mapcar1)
1033 (Fbase64_encode_region, Fbase64_encode_string, base64_encode_1)
1034 (Fbase64_decode_region, Fbase64_decode_string, base64_decode_1)
1035 (larger_vector, make_hash_table, maybe_resize_hash_table)
1036 (hash_lookup, hash_remove_from_table, hash_clear, sweep_weak_table)
1037 (Fmaphash, secure_hash):
1038 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1039 (concat): Check for string index and length overflow.
1040 (Fmapconcat): Don't assume fixnums fit into ptrdiff_t.
1041 (Frequire):
1042 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1043 (larger_vector): New API (vec, incr_min, size_max) replaces old
1044 one (vec, new_size, init). This catches size overflow.
1045 INIT was removed because it was always Qnil.
1046 All callers changed.
1047 (INDEX_SIZE_BOUND): New macro, which calculates more precisely
1048 the upper bound on a hash table index size.
1049 (make_hash_table, maybe_resize_hash_table): Use it.
1050 (secure_hash): Computer start_byte and end_byte only after
1051 they're known to be in ptrdiff_t range.
1052 * font.c (font_intern_prop, font_at, font_range, Ffont_shape_gstring)
1053 (Ffont_get_glyphs, Ffont_at):
1054 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1055 (font_style_to_value, font_prop_validate_style, font_expand_wildcards)
1056 (Flist_fonts, Fopen_font):
1057 Don't assume fixnum can fit in int.
1058 (check_gstring): Don't assume index can fit in int.
1059 (font_match_p): Check that fixnum is a character, not a nonnegative
1060 fixnum, since the later code needs to stuff it into an int.
1061 (font_find_for_lface): Use SAFE_ALLOCA_LISP, not alloca.
1062 (font_fill_lglyph_metrics): Use unsigned, not EMACS_INT, to avoid
1063 conversion overflow issues.
1064 (Fopen_font): Check for integer out of range.
1065 (Ffont_get_glyphs): Don't assume index can fit in int.
1066 * font.h: Adjust decls to match defn changes elsewhere.
1067 * fontset.c (reorder_font_vector): Redo score calculation to avoid
1068 integer overflow.
1069 (num_auto_fontsets, fontset_from_font): Use ptrdiff_t, not
1070 printmax_t, where ptrdiff_t is wide enough.
1071 (Finternal_char_font):
1072 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1073 * frame.c (Fset_mouse_position, Fset_mouse_pixel_position)
1074 (Fset_frame_height, Fset_frame_width, Fset_frame_size)
1075 (Fset_frame_position, x_set_frame_parameters)
1076 (x_set_line_spacing, x_set_border_width)
1077 (x_set_internal_border_width, x_set_alpha, x_figure_window_size):
1078 Check that fixnums are in proper range for system types.
1079 (frame_name_fnn_p, Fframe_parameter, Fmodify_frame_parameters):
1080 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1081 (Fmodify_frame_parameters): Don't assume fixnum fits in int.
1082 Use SAFE_ALLOCA_LISP, not alloca.
1083 * frame.h (struct frame): Use intptr_t, not EMACS_INT, where
1084 intptr_t is wide enough.
1085 * fringe.c (lookup_fringe_bitmap, get_logical_fringe_bitmap)
1086 (Fdefine_fringe_bitmap): Don't assume fixnum fits in int.
1087 (Ffringe_bitmaps_at_pos): Don't assume index fits in int.
1088 Check for fixnum out of range.
1089 * ftfont.c (ftfont_list): Don't assume index fits in int.
1090 Check that fixnums are in proper range for system types.
1091 (ftfont_shape_by_flt):
1092 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
d311d28c
PE
1093 * gnutls.c (emacs_gnutls_write, emacs_gnutls_read):
1094 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1095 (Fgnutls_error_fatalp, Fgnutls_error_string, Fgnutls_boot):
1096 Check that fixnums are in proper range for system types.
1097 * gnutls.h: Adjust decls to match defn changes elsewhere.
1098 * gtkutil.c (xg_dialog_run):
1099 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1100 (update_frame_tool_bar):
1101 Check that fixnums are in proper range for system types.
1102 * image.c (parse_image_spec): Redo count calculation to avoid overflow.
5895d7b9 1103 (lookup_image): Check that fixnums are in range for system types.
d311d28c
PE
1104 * indent.c (last_known_column, last_known_column_point):
1105 (current_column_bol_cache):
1106 (skip_invisible, current_column, check_display_width):
1107 (check_display_width, scan_for_column, current_column_1)
1108 (Findent_to, Fcurrent_indentation, position_indentation)
1109 (indented_beyond_p, Fmove_to_column, compute_motion):
1110 (Fcompute_motion, Fvertical_motion):
1111 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1112 (last_known_column_modified): Use EMACS_INT, not int.
1113 (check_display_width):
1114 (Fcompute_motion):
1115 Check that fixnums and floats are in proper range for system types.
1116 (compute_motion): Don't assume index or fixnum fits in int.
1117 (compute_motion, Fcompute_motion):
1118 Use int, not EMACS_INT, when it is wide enough.
1119 (vmotion): Omit local var start_hpos that is always 0; that way
1120 we don't need to worry about overflow in expressions involving it.
1121 * indent.h: Adjust decls to match defn changes elsewhere.
1122 (struct position):
1123 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1124 Use int, not EMACS_INT, where int is wide enough.
1125 Remove unused members ovstring_chars_done and tab_offset;
1126 all uses removed.
1127 * insdel.c (move_gap, move_gap_both, gap_left, gap_right)
1128 (adjust_markers_for_delete, adjust_markers_for_insert, adjust_point)
1129 (adjust_markers_for_replace, make_gap_larger, make_gap_smaller)
1130 (make_gap, copy_text, insert, insert_and_inherit)
1131 (insert_before_markers, insert_before_markers_and_inherit)
1132 (insert_1, count_combining_before, count_combining_after)
1133 (insert_1_both, insert_from_string)
1134 (insert_from_string_before_markers, insert_from_string_1)
1135 (insert_from_gap, insert_from_buffer, insert_from_buffer_1)
1136 (adjust_after_replace, adjust_after_insert, replace_range)
1137 (replace_range_2, del_range, del_range_1, del_range_byte)
1138 (del_range_both, del_range_2, modify_region)
1139 (prepare_to_modify_buffer, signal_before_change)
1140 (signal_after_change, Fcombine_after_change_execute):
1141 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1142 * intervals.c (traverse_intervals, rotate_right, rotate_left)
1143 (balance_an_interval, split_interval_right, split_interval_left)
1144 (find_interval, next_interval, update_interval)
1145 (adjust_intervals_for_insertion, delete_node, delete_interval)
1146 (interval_deletion_adjustment, adjust_intervals_for_deletion)
1147 (static_offset_intervals, offset_intervals)
1148 (merge_interval_right, merge_interval_left, make_new_interval)
1149 (graft_intervals_into_buffer, temp_set_point_both)
1150 (temp_set_point, set_point, adjust_for_invis_intang)
1151 (set_point_both, move_if_not_intangible, get_property_and_range)
1152 (get_local_map, copy_intervals, copy_intervals_to_string)
1153 (compare_string_intervals, set_intervals_multibyte_1):
1154 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1155 * intervals.h: Adjust decls to match defn changes elsewhere.
1156 (struct interval):
1157 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1158 * keyboard.c (this_command_key_count, this_single_command_key_start)
1159 (before_command_key_count, before_command_echo_length, echo_now)
1160 (echo_length, recursive_edit_1, Frecursive_edit, Ftrack_mouse)
1161 (command_loop_1, safe_run_hooks, read_char, timer_check_2)
1162 (menu_item_eval_property, read_key_sequence, Fread_key_sequence)
1163 (Fread_key_sequence_vector, Fexecute_extended_command, Fsuspend_emacs):
1164 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1165 (last_non_minibuf_size, last_point_position, echo_truncate)
1166 (command_loop_1, adjust_point_for_property, read_char, gen_help_event)
1167 (make_lispy_position, make_lispy_event, parse_modifiers_uncached)
1168 (parse_modifiers, modify_event_symbol, Fexecute_extended_command)
1169 (stuff_buffered_input):
1170 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1171 (last_auto_save, command_loop_1, read_char):
1172 Use EMACS_INT, not int, to avoid integer overflow.
1173 (record_char): Avoid overflow in total_keys computation.
1174 (parse_modifiers_uncached): Redo index calculation to avoid overflow.
1175 * keyboard.h: Adjust decls to match defn changes elsewhere.
1176 * keymap.c (Fdefine_key, Fcurrent_active_maps, accessible_keymaps_1)
1177 (Fkey_description, Fdescribe_vector, Flookup_key):
1178 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1179 (click_position): New function, to check that positions are in range.
1180 (Fcurrent_active_maps):
1181 (describe_command):
1182 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1183 (Faccessible_keymaps, Fkey_description):
1184 (preferred_sequence_p):
1185 Don't assume fixnum can fit into int.
1186 (Fkey_description): Use SAFE_ALLOCA_LISP, not alloca.
1187 Check for integer overflow in size calculations.
1188 (Ftext_char_description): Use CHECK_CHARACTER, not CHECK_NUMBER, to
1189 avoid mishandling large integers.
1190 * lisp.h: Adjust decls to match defn changes elsewhere.
1191 (ARRAY_MARK_FLAG, PSEUDOVECTOR_FLAG, struct Lisp_String)
1192 (struct vectorlike_header, struct Lisp_Subr, struct Lisp_Hash_Table)
1193 (struct Lisp_Marker):
1194 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1195 (clip_to_bounds): Now an inline function, moved here from editfns.c.
d311d28c
PE
1196 (GLYPH_CODE_P): Check for overflow in system types, subsuming the
1197 need for GLYPH_CODE_CHAR_VALID_P and doing proper checking ourselves.
1198 All callers changed.
1199 (GLYPH_CODE_CHAR, GLYPH_CODE_FACE):
1200 Assume the arg has valid form, since it always does.
1201 (TYPE_RANGED_INTEGERP): Avoid bug when checking against a wide
1202 unsigned integer system type.
1203 (CHECK_RANGED_INTEGER, CHECK_TYPE_RANGED_INTEGER): New macros.
1204 (struct catchtag, specpdl_size, SPECPDL_INDEX, USE_SAFE_ALLOCA):
1205 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1206 (struct catchtag): Use EMACS_INT, not int, since it may be a fixnum.
1207 (duration_to_sec_usec): New decl.
1208 * lread.c (read_from_string_index, read_from_string_index_byte)
1209 (read_from_string_limit, readchar, unreadchar, openp)
1210 (read_internal_start, read1, oblookup):
1211 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1212 (Fload, readevalloop, Feval_buffer, Feval_region):
1213 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1214 (openp): Check for out-of-range argument to 'access'.
1215 (read1): Use int, not EMACS_INT, where int is wide enough.
1216 Don't assume fixnum fits into int.
6efdadfd 1217 Fix off-by-one error that can read outside a buffer.
1ab7b8ac
PE
1218 (read_filtered_event): Use duration_to_sec_usec
1219 to do proper overflow checking on durations.
d311d28c
PE
1220 * macros.c (Fstart_kbd_macro): Use xpalloc to check for overflow
1221 in size calculation.
1222 (Fexecute_kbd_macro):
1223 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1224 * marker.c (cached_charpos, cached_bytepos, CONSIDER)
1225 (byte_char_debug_check, buf_charpos_to_bytepos, verify_bytepos)
1226 (buf_bytepos_to_charpos, Fset_marker, set_marker_restricted)
1227 (set_marker_both, set_marker_restricted_both, marker_position)
1228 (marker_byte_position, Fbuffer_has_markers_at):
1229 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1230 (Fset_marker, set_marker_restricted): Don't assume fixnum fits in int.
61b108cc 1231 * menu.c (ensure_menu_items): Rename from grow_menu_items.
d311d28c
PE
1232 It now merely ensures that the menu is large enough, without
1233 necessarily growing it, as this avoids some integer overflow issues.
1234 All callers changed.
1235 (keymap_panes, parse_single_submenu, Fx_popup_menu):
1236 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1237 (parse_single_submenu, Fx_popup_menu): Don't assume fixnum fits in int.
1238 Use SAFE_ALLOCA_LISP, not alloca.
1239 (find_and_return_menu_selection): Avoid unnecessary casts of pointers
1240 to EMACS_INT. Check that fixnums are in proper range for system types.
1241 * minibuf.c (minibuf_prompt_width, string_to_object)
1242 (Fminibuffer_contents, Fminibuffer_contents_no_properties)
1243 (Fminibuffer_completion_contents, Ftry_completion, Fall_completions):
1244 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1245 (get_minibuffer, read_minibuf_unwind):
1246 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1247 (read_minibuf): Omit unnecessary arg BACKUP_N, which is always nil;
1248 this simplifies overflow checking. All callers changed.
1249 (read_minibuf, Fread_buffer, Ftry_completion, Fall_completions)
1250 (Ftest_completion):
1251 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1252 * nsfns.m (check_ns_display_info): Don't assume fixnum fits in long.
1253 (x_set_menu_bar_lines, x_set_tool_bar_lines, Fx_create_frame):
1254 Check that fixnums are in proper range for system types.
1255 (Fx_create_frame, Fx_show_tip):
1256 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1257 * nsfont.m (ns_findfonts, nsfont_list_family):
1258 Don't assume fixnum fits in long.
1259 * nsmenu.m (ns_update_menubar, ns_menu_show, ns_popup_dialog):
1260 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1261 (ns_update_menubar): Use intptr_t, not EMACS_INT, when intptr_t is
1262 wide enough.
17fdb222 1263 * nsselect.m (ns_get_local_selection, clean_local_selection_data):
d311d28c
PE
1264 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1265 * print.c (print_buffer_size, print_buffer_pos, print_buffer_pos_byte)
1266 (PRINTDECLARE, PRINTPREPARE):
1267 (strout, print_string):
1268 (print, print_preprocess, print_check_string_charset_prop)
1269 (print_object):
1270 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1271 (PRINTDECLARE):
1272 (temp_output_buffer_setup, Fprin1_to_string, print_object):
1273 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1274 (PRINTPREPARE): Use int, not ptrdiff_t, where int is wide enough.
d311d28c 1275 (printchar, strout): Use xpalloc to catch size calculation overflow.
0fd11aa5 1276 (Fexternal_debugging_output): Don't overflow EMACS_INT->int conversion.
d311d28c
PE
1277 (print_error_message): Use SAFE_ALLOCA, not alloca.
1278 (print_object): Use int, not EMACS_INT, where int is wide enough.
a8b7caa3
PE
1279 (print_depth, new_backquote_output, print_number_index):
1280 Use ptrdiff_t, not int, where int might not be wide enough.
d311d28c
PE
1281 * process.c (Fdelete_process): Don't assume pid fits into EMACS_INT.
1282 (Fset_process_window_size, Fformat_network_address)
1283 (get_lisp_to_sockaddr_size, set_socket_option, Fmake_network_process)
d44287d4 1284 (sigchld_handler):
d311d28c 1285 Check that fixnums are in proper range for system types.
d44287d4 1286 (Fsignal_process): Simplify by avoiding a goto.
d83cf4cc
PE
1287 Check for process-ids out of pid_t range rather than relying on
1288 undefined behavior.
e4d81efc 1289 (process_tick, update_tick): Use EMACS_INT, not int.
d311d28c
PE
1290 (Fformat_network_address, read_process_output, send_process)
1291 (Fprocess_send_region, status_notify):
1292 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1293 (Fformat_network_address, Fmake_serial_process, Fmake_network_process)
1294 (wait_reading_process_output, read_process_output, exec_sentinel):
1295 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1296 (conv_lisp_to_sockaddr): Don't assume fixnums fit into int.
1297 (Faccept_process_output): Use duration_to_sec_usec to do proper
1298 overflow checking on durations.
dde14581
PE
1299 (emacs_get_tty_pgrp, Fprocess_running_child_p, process_send_signal):
1300 Don't assume pid_t fits in int.
02481186
PE
1301 * process.h (struct Lisp_Process): Members tick and update_tick
1302 are now of type EMACS_INT, not int.
b62b53e8
PE
1303 * puresize.h (PURESIZE_RATIO): Shrink this to 8/6 on 32-bit hosts
1304 configured --with-wide-int.
d311d28c
PE
1305 * scroll.c (calculate_scrolling, calculate_direct_scrolling)
1306 (line_ins_del): Use int, not EMACS_INT, where int is wide enough.
1307 * search.c (looking_at_1, string_match_1):
1308 (fast_string_match, fast_c_string_match_ignore_case)
1309 (fast_string_match_ignore_case, fast_looking_at, scan_buffer)
1310 (scan_newline, find_before_next_newline, search_command)
1311 (trivial_regexp_p, search_buffer, simple_search, boyer_moore)
1312 (set_search_regs, wordify):
1313 (Freplace_match):
1314 (Fmatch_data):
1315 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1316 (string_match_1, search_buffer, set_search_regs):
1317 (Fmatch_data):
1318 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1319 (wordify): Check for overflow in size calculation.
1320 (Freplace_match): Avoid potential buffer overflow in search_regs.start.
1321 (Fset_match_data): Don't assume fixnum fits in ptrdiff_t.
1322 Check that fixnums are in proper range for system types.
1323 * sound.c (struct sound_device)
1324 (wav_play, au_play, vox_write, alsa_period_size, alsa_write):
1325 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1326 (Fplay_sound_internal):
1327 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
eacd378d 1328 * syntax.c (struct lisp_parse_state, find_start_modiff)
d311d28c
PE
1329 (Finternal_describe_syntax_value, scan_lists, scan_sexps_forward):
1330 (Fparse_partial_sexp):
1331 Don't assume fixnums can fit in int.
1332 (struct lisp_parse_state, find_start_pos, find_start_value)
1333 (find_start_value_byte, find_start_begv)
1334 (update_syntax_table, char_quoted, dec_bytepos)
1335 (find_defun_start, prev_char_comend_first, back_comment):
1336 (scan_words, skip_chars, skip_syntaxes, forw_comment, Fforward_comment)
1337 (scan_lists, Fbackward_prefix_chars, scan_sexps_forward):
1338 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1339 (Finternal_describe_syntax_value): Check that match_lisp is a
1340 character, not an integer, since the code stuffs it into int.
1341 (scan_words, scan_sexps_forward):
1342 Check that fixnums are in proper range for system types.
1343 (Fforward_word):
1344 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1345 (scan_sexps_forward):
1346 Use CHARACTERP, not INTEGERP, since the value must fit into int.
1347 (Fparse_partial_sexp): Fix doc; element 8 is not ignored.
1348 * syntax.h: Adjust decls to match defn changes elsewhere.
1349 (struct gl_state_s):
1350 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
e4ecdc9c
PE
1351 (SETUP_SYNTAX_TABLE_FOR_OBJECT): Use PTRDIFF_MAX, not
1352 MOST_POSITIVE_FIXNUM.
d311d28c
PE
1353 * sysdep.c (wait_for_termination_1, wait_for_termination)
1354 (interruptible_wait_for_termination, mkdir):
1355 Don't assume pid_t fits in int; on 64-bit AIX pid_t is 64-bit.
1356 (emacs_read, emacs_write):
1357 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
225a2cff
PE
1358 (system_process_attributes): Don't assume uid_t, gid_t, EMACS_INT,
1359 and double all fit in int.
d311d28c
PE
1360 * term.c (set_tty_color_mode):
1361 Check that fixnums are in proper range for system types.
1362 * termhooks.h (struct input_event):
1363 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1364 * textprop.c (validate_interval_range, interval_of)
1365 (Fadd_text_properties, set_text_properties_1)
1366 (Fremove_text_properties, Fremove_list_of_text_properties)
1367 (Ftext_property_any, Ftext_property_not_all)
1368 (copy_text_properties, text_property_list, extend_property_ranges)
1369 (verify_interval_modification):
1370 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1371 (Fnext_single_char_property_change)
1372 (Fprevious_single_char_property_change):
1373 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
5895d7b9
PE
1374 (copy_text_properties):
1375 Check for integer overflow in index calculation.
d311d28c
PE
1376 * undo.c (last_boundary_position, record_point, record_insert)
1377 (record_delete, record_marker_adjustment, record_change)
1378 (record_property_change):
1379 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1380 (truncate_undo_list, Fprimitive_undo): Don't assume fixnum fits in int.
1381 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1382 * w32fns.c (Fx_create_frame, x_create_tip_frame, Fx_show_tip)
1383 (Fx_hide_tip, Fx_file_dialog):
1384 * w32menu.c (set_frame_menubar):
1385 Use ptrdiff_t, not int, for consistency with rest of code.
1386 * window.c (window_scroll_preserve_hpos, window_scroll_preserve_vpos)
1387 (select_window, Fdelete_other_windows_internal)
1388 (window_scroll_pixel_based, window_scroll_line_based)
1389 (Frecenter, Fset_window_configuration):
1390 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1391 (Fset_window_hscroll, run_window_configuration_change_hook)
1392 (set_window_buffer, temp_output_buffer_show, scroll_command)
5895d7b9 1393 (Fscroll_other_window, Frecenter):
d311d28c
PE
1394 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1395 (Fwindow_line_height, window_scroll, Fscroll_left, Fscroll_right):
1396 Don't assume fixnum fits in int.
1397 (Fset_window_scroll_bars):
1398 Check that fixnums are in proper range for system types.
1399 * xdisp.c (help_echo_pos, pos_visible_p, string_pos_nchars_ahead)
1400 (string_pos, c_string_pos, number_of_chars, init_iterator)
1401 (in_ellipses_for_invisible_text_p, init_from_display_pos)
1402 (compute_stop_pos, next_overlay_change, compute_display_string_pos)
1403 (compute_display_string_end, handle_face_prop)
5895d7b9
PE
1404 (face_before_or_after_it_pos, handle_invisible_prop)
1405 (handle_display_prop, handle_display_spec, handle_single_display_spec)
d311d28c
PE
1406 (display_prop_intangible_p, string_buffer_position_lim)
1407 (string_buffer_position, handle_composition_prop, load_overlay_strings)
1408 (get_overlay_strings_1, get_overlay_strings)
1409 (iterate_out_of_display_property, forward_to_next_line_start)
1410 (back_to_previous_visible_line_start, reseat, reseat_to_string)
1411 (get_next_display_element, set_iterator_to_next)
1412 (get_visually_first_element, compute_stop_pos_backwards)
1413 (handle_stop_backwards, next_element_from_buffer)
1414 (move_it_in_display_line_to, move_it_in_display_line)
1415 (move_it_to, move_it_vertically_backward, move_it_by_lines)
1416 (add_to_log, message_dolog, message_log_check_duplicate)
1417 (message2, message2_nolog, message3, message3_nolog
1418 (with_echo_area_buffer, display_echo_area_1, resize_mini_window_1)
1419 (current_message_1, truncate_echo_area, truncate_message_1)
1420 (set_message, set_message_1, store_mode_line_noprop)
1421 (hscroll_window_tree, debug_delta, debug_delta_bytes, debug_end_vpos)
1422 (text_outside_line_unchanged_p, check_point_in_composition)
1423 (reconsider_clip_changes)
1424 (redisplay_internal, set_cursor_from_row, try_scrolling)
1425 (try_cursor_movement, set_vertical_scroll_bar, redisplay_window)
1426 (redisplay_window, find_last_unchanged_at_beg_row)
1427 (find_first_unchanged_at_end_row, row_containing_pos, try_window_id)
1428 (trailing_whitespace_p, find_row_edges, display_line)
1429 (RECORD_MAX_MIN_POS, Fcurrent_bidi_paragraph_direction)
1430 (display_mode_element, store_mode_line_string)
1431 (pint2str, pint2hrstr, decode_mode_spec)
1432 (display_count_lines, display_string, draw_glyphs)
1433 (x_produce_glyphs, x_insert_glyphs)
1434 (rows_from_pos_range, mouse_face_from_buffer_pos)
1435 (fast_find_string_pos, mouse_face_from_string_pos)
1436 (note_mode_line_or_margin_highlight, note_mouse_highlight):
1437 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1438 (safe_call, init_from_display_pos, handle_fontified_prop)
1439 (handle_single_display_spec, load_overlay_strings)
1440 (with_echo_area_buffer, setup_echo_area_for_printing)
1441 (display_echo_area, echo_area_display)
1442 (x_consider_frame_title, prepare_menu_bars, update_menu_bar)
1443 (update_tool_bar, hscroll_window_tree, redisplay_internal)
5895d7b9
PE
1444 (redisplay_window, dump_glyph_row, display_mode_line)
1445 (Fformat_mode_line, decode_mode_spec, on_hot_spot_p):
43ad2e9a 1446 (handle_display_spec, display_prop_string_p):
d311d28c
PE
1447 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1448 (handle_single_display_spec, build_desired_tool_bar_string)
1449 (redisplay_tool_bar, scroll_window_tree, Fdump_glyph_matrix)
1450 (get_specified_cursor_type):
1451 Check that fixnums are in proper range for system types.
1452 (struct overlay_entry, resize_mini_window, Fdump_glyph_row)
1453 (Flookup_image_map):
1454 Don't assume fixnums fit in int.
1455 (compare_overlay_entries):
1456 Avoid mishandling comparisons due to subtraction overflow.
1457 (load_overlay_strings): Use SAFE_NALLOCA, not alloca.
1458 (last_escape_glyph_face_id, last_glyphless_glyph_face_id):
1459 (handle_tool_bar_click):
1460 Use int, not unsigned, since we prefer signed and the signedness
1461 doesn't matter here.
1462 (get_next_display_element, next_element_from_display_vector):
1463 Use int, not EMACS_INT, when int is wide enough.
1464 (start_hourglass): Use duration_to_sec_usec to do proper
1465 overflow checking on durations.
1466 * xfaces.c (Fbitmap_spec_p):
1467 Check that fixnums are in proper range for system types.
1468 (compare_fonts_by_sort_order):
1469 Avoid mishandling comparisons due to subtraction overflow.
1470 (Fx_family_fonts, realize_basic_faces):
1471 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1472 (Fx_family_fonts):
1473 Don't assume fixnum fits in int.
1474 Use SAFE_ALLOCA_LISP, not alloca.
1475 (merge_face_heights): Remove unnecessary cast to EMACS_INT.
1476 (Finternal_make_lisp_face): Don't allocate more than MAX_FACE_ID.
1477 (face_at_buffer_position, face_for_overlay_string)
1478 (face_at_string_position):
1479 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1480 (merge_faces): Use int, not EMACS_INT, where int is wide enough.
1481 * xfns.c (x_set_menu_bar_lines, x_set_tool_bar_lines, x_icon_verify)
1482 (Fx_show_tip):
1483 Check that fixnums are in proper range for system types.
1484 (Fx_create_frame, x_create_tip_frame, Fx_show_tip)
1485 (Fx_hide_tip, Fx_file_dialog, Fx_select_font):
1486 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1487 (Fx_change_window_property): Don't assume fixnums fit in int.
1488 * xfont.c (xfont_chars_supported):
1489 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1490 * xmenu.c (Fx_popup_dialog, set_frame_menubar)
1491 (create_and_show_popup_menu, create_and_show_dialog, xmenu_show):
1492 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1493 * xml.c (parse_region):
1494 * xrdb.c (magic_file_p):
1495 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1496 * xselect.c (TRACE1): Don't assume pid_t promotes to int.
1497 (x_get_local_selection, x_reply_selection_request)
1498 (x_handle_selection_request, wait_for_property_change):
1499 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1500 (selection_data_to_lisp_data): Use short, not EMACS_INT, where
1501 short is wide enough.
1502 (x_send_client_event): Don't assume fixnum fits in int.
1503 * xterm.c (x_x_to_emacs_modifiers):
1504 Don't assume EMACS_INT overflows nicely into int.
1505 (x_emacs_to_x_modifiers): Use EMACS_INT, not int, because values
1506 may come from Lisp.
1507 (handle_one_xevent): NATNUMP can eval its arg twice.
1508 (x_connection_closed):
1509 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1510 * xterm.h: Adjust decls to match defn changes elsewhere.
1511 (struct scroll_bar): Use struct vectorlike_header
1512 rather than rolling our own approximation.
1513 (SCROLL_BAR_VEC_SIZE): Remove; not used.
1514
c6574eb5
GM
15152012-05-25 Glenn Morris <rgm@gnu.org>
1516
1517 * lisp.mk (lisp): Update for more files being compiled now.
1518
e8d32c7e
SM
15192012-05-25 Stefan Monnier <monnier@iro.umontreal.ca>
1520
48def666
SM
1521 * lread.c: Remove `read_pure' which makes no difference.
1522 (read_pure): Remove var.
1523 (unreadpure): Remove function.
1524 (readevalloop): Don't call read_list with -1 flag.
1525 (read1, read_vector): Don't test read_pure any more.
1526 (read_list): Simplify.
1527
e8d32c7e
SM
1528 * fileio.c, character.h: Minor style tweaks.
1529
4b2addb7
DA
15302012-05-24 Dmitry Antipov <dmantipov@yandex.ru>
1531
1532 * window.h (clip_changed): Remove useless declaration.
1533
584461b2
JB
15342012-05-22 Juanma Barranquero <lekktu@gmail.com>
1535
1536 * makefile.w32-in: Follow-up to 2012-05-22T16:20:27Z!eggert@cs.ucla.edu.
1537 (TAGS, TAGS-gmake, CONFIG_H): Remove further references to m/intel386.h.
1538
34374650
PE
15392012-05-22 Paul Eggert <eggert@cs.ucla.edu>
1540
1541 Remove src/m/*.
1542 This directory predates autoconf and is no longer needed nowadays.
1543 Move its few remaining bits of functionality to where they're needed.
1544 * m/README, m/alpha.h, m/amdx86-64.h, m/ia64.h, m/ibmrs6000.h:
1545 * m/ibms390x.h, m/intel386.h, m/m68k.h, m/macppc.h, m/sparc.h:
1546 * m/template.h: Remove.
1547 * Makefile.in (M_FILE): Remove. All uses removed.
1548 * alloc.c (POINTERS_MIGHT_HIDE_IN_OBJECTS):
1549 * lisp.h (USE_LSB_TAG):
1550 * mem-limits.h (EXCEEDS_LISP_PTR):
1551 Use VAL_MAX, not VALBITS, in #if.
1552 * lisp.h (EMACS_INT_MAX): New macro, useful in #if.
1553 (EMACS_UINT): Define unconditionally now.
1554 (BITS_PER_CHAR, BITS_PER_SHORT, BITS_PER_INT, BITS_PER_LONG)
1555 (BITS_PER_EMACS_INT): New constants, replacing
1556 what used to be in config.h, but not useful in #if.
1557 (GCTYPEBITS, VALBITS): Define unconditionally, since m/* files don't
1558 define them any more.
1559 (VAL_MAX): New macro.
1560 (VALMASK): Use it.
1561 * puresize.h (PURESIZE_RATIO): Use EMACS_INT_MAX, not
1562 BITS_PER_EMACS_INT, in #if.
1563 * s/aix4-2.h (BROKEN_FIONREAD, BROKEN_SIGAIO, BROKEN_SIGPTY)
1564 (BROKEN_SIGPOLL): Move here from m/ibmrs6000.h, which was removed.
1565 * s/gnu-linux.h (ULIMIT_BREAK_VALUE) [__i386__]:
1566 * s/ms-w32.h (DATA_START):
1567 Move here from removed file m/intel386.h.
1568 * s/gnu.h (NLIST_STRUCT): Remove undef; 'configure' does this.
1569 * s/irix6-5.h (_LP64): Remove; lisp.h no longer needs this.
1570
261cb4bb
PE
15712012-05-21 Paul Eggert <eggert@cs.ucla.edu>
1572
1573 Assume C89 or later.
1574 * alloc.c, buffer.c, lisp.h: Replace POINTER_TYPE with void.
1575 * alloc.c (overrun_check_malloc, overrun_check_realloc, xmalloc)
1576 (xrealloc):
1577 * buffer.c (mmap_free_1, mmap_enlarge): Omit needless casts.
1578 * editfns.c, fns.c, gmalloc.c, insdel.c, sysdep.c, termcap.c (NULL):
1579 * textprop.c, tparam.c (NULL): Remove.
1580 * ralloc.c, vm-limit.c (POINTER): Assume void * works.
1581 * regex.c (SIGN_EXTEND_CHAR): Assume signed char works.
1582 * regex.h (_RE_ARGS): Remove. All uses rewritten to use prototypes.
1583 * unexelf.c (ElfBitsW): Assume c89 preprocessor or better.
1584 * xterm.c (input_signal_count): Assume volatile works.
1585
ff23cd9f
KB
15862012-05-21 Ken Brown <kbrown@cornell.edu>
1587
1588 * xgselect.c (xg_select): Fix first argument in call to 'select'
1589 (bug#11508).
1590
1b170bc6
KB
15912012-05-20 Ken Brown <kbrown@cornell.edu>
1592
1593 * gmalloc.c (_free_internal_nolock, _realloc_internal_nolock)
bd7239f5 1594 [CYGWIN]: Cast ptr to (char *) before comparing to _heapbase.
1b170bc6 1595
b2f4d39f
KB
15962012-05-19 Ken Brown <kbrown@cornell.edu>
1597
1598 * xfns.c (x_in_use): Remove `static' qualifier.
1599 * xterm.h (x_in_use): Declare.
1600 * xgselect.c: Include xterm.h.
1601 (xg_select): Test `x_in_use' instead of `inhibit_window_system'
1602 and `display_arg' (bug#9754).
1603
003fdae2
PE
16042012-05-19 Paul Eggert <eggert@cs.ucla.edu>
1605
9232a6d9
PE
1606 * s/ms-w32.h (HAVE_GETDOMAINNAME): Remove; not needed.
1607
003fdae2
PE
1608 * m/vax.h: Remove; no longer needed since HAVE_FTIME is being removed.
1609 * s/ms-w32.h (HAVE_FTIME): Remove; not needed.
1610
784b56e2
EZ
16112012-05-18 Eli Zaretskii <eliz@gnu.org>
1612
1613 Fix compilation with -DGLYPH_DEBUG=1 on MS-Windows.
1614
1615 * w32term.c [GLYPH_DEBUG]: Add prototype for x_check_font.
1616 (x_check_font) [GLYPH_DEBUG]: New function, copied from xterm.c
1617
1618 * w32fns.c (unwind_create_frame) [GLYPH_DEBUG]: Fix broken
1619 reference to image_cache->refcount.
1620 (x_create_tip_frame): Fix broken use of FRAME_IMAGE_CACHE.
1621
a0a79cde
JL
16222012-05-17 Juri Linkov <juri@jurta.org>
1623
1624 * search.c (Fword_search_regexp, Fword_search_backward)
1625 (Fword_search_forward, Fword_search_backward_lax)
1626 (Fword_search_forward_lax): Move functions to isearch.el
1627 (bug#10145, bug#11381).
1628
b0572523
PE
16292012-05-16 Paul Eggert <eggert@cs.ucla.edu>
1630
1631 * xgselect.c (xg_select): Just invoke 'select' if -nw (Bug#9754).
1632
9660f5fc
SM
16332012-05-15 Stefan Monnier <monnier@iro.umontreal.ca>
1634
1635 * lread.c (init_obarray): Declare Qt and Qnil as special.
1636
4374de83
GM
16372012-05-14 Glenn Morris <rgm@gnu.org>
1638
1639 * nsterm.m (ns_init_paths): Fix typo ("libexec" not "lib-exec").
985584ae 1640 Put "libexec" before "bin", for the sake of init_callproc_1.
4374de83 1641
dc44c39a
PE
16422012-05-14 Paul Eggert <eggert@cs.ucla.edu>
1643
078c97cb
PE
1644 * keyboard.c (kbd_buffer_get_event) [!HAVE_DBUS]: Omit unused local.
1645
dc44c39a
PE
1646 * unexaix.c: Port to more-recent AIX compilers.
1647 (report_error, report_error_1, make_hdr, copy_sym)
1648 (mark_x, adjust_lnnoptrs, unrelocate_symbols):
1649 Make arguments const char *, not char *, to avoid violations of C
1650 standard and to fix some AIX warnings reported by Gilles Pion.
1651
e18afed7 16522012-05-14 Eli Zaretskii <eliz@gnu.org>
ac268e67
EZ
1653
1654 * xdisp.c (handle_stop): Don't call get_overlay_strings_1 if we
1655 already have overlays loaded.
1656 (handle_single_display_spec): Before returning without displaying
1657 fringe bitmap, synchronize the bidi iterator with the main display
1658 iterator, by calling iterate_out_of_display_property.
1659 (iterate_out_of_display_property): Detect buffer iteration by
1660 testing that it->string is a Lisp string.
1661 (get_next_display_element): When the current object is exhausted,
1662 and there's something on it->stack, call set_iterator_to_next to
1663 proceed with what's on the stack, instead of returning zero.
1664 (set_iterator_to_next): If called at the end of a Lisp string,
1665 proceed to consider_string_end without incrementing string
1666 position. Don't increment display vector index past the end of
1667 the display vector. (Bug#11417)
c8fb9dc6
EZ
1668 (pos_visible_p): Don't report a position visible when move_it_to
1669 stopped at the last line of window, which happens to be scanned
1670 backwards by the bidi iteration. (Bug#11464)
ac268e67 1671
e18afed7 16722012-05-14 Eli Zaretskii <eliz@gnu.org>
82f9b393
EZ
1673
1674 * xdisp.c (handle_single_display_spec): Return 1 for left-margin
1675 and right-margin display specs even if the spec is invalid or we
61b108cc
SM
1676 are on a TTY, and thus unable to display on the fringes.
1677 That's because the text with the property will not be displayed anyway,
82f9b393
EZ
1678 so we need to signal to the caller that this is a "replacing"
1679 display spec. This fixes display when the spec is invalid or we
1680 are on a TTY.
1681
e18afed7 16822012-05-14 Paul Eggert <eggert@cs.ucla.edu>
297834cd
PE
1683
1684 * unexaix.c (make_hdr): Fix typo in prototype.
1685 This bug broke the build on AIX. Problem reported by Gilles Pion.
1686
9d0a235a
MA
16872012-05-14 Michael Albinus <michael.albinus@gmx.de>
1688
1689 * keyboard.c (kbd_buffer_get_event): Read special events also in
1690 batch mode. (Bug#11415)
1691
9e6b06ed
GM
16922012-05-12 Glenn Morris <rgm@gnu.org>
1693
1694 * ns.mk: Update for ns_appbindir no longer having trailing "/".
1695
c1a1d7a3
EZ
16962012-05-12 Eli Zaretskii <eliz@gnu.org>
1697
1698 * lisp.mk (lisp): Add newcomment.elc.
1699
3fe7cdc8
GM
17002012-05-12 Glenn Morris <rgm@gnu.org>
1701
1702 * Makefile.in (MKDIR_P): New, set by configure.
1703 * ns.mk (${ns_appdir}, ${ns_appbindir}Emacs): Use $MKDIR_P.
1704
53f7d2c0
PE
17052012-05-11 Paul Eggert <eggert@cs.ucla.edu>
1706
1707 Remove unused function hourglass_started.
1708 * dispextern.h (hourglass_started):
1709 * w32fns.c (hourglass_started):
1710 * xdisp.c (hourglass_started): Remove.
1711
75aafb17
JB
17122012-05-10 Juanma Barranquero <lekktu@gmail.com>
1713
1714 * makefile.w32-in ($(BLD)/gmalloc.$(O), $(BLD)/w32menu.$(O)):
1715 Update dependencies.
1716
12959e8e
PE
17172012-05-10 Paul Eggert <eggert@cs.ucla.edu>
1718
97107e2e
PE
1719 * xgselect.c (xg_select): Put maxfds+1 into a var.
1720 This is slightly clearer, and pacifies Ubuntu 12.04 gcc.
1721
12959e8e
PE
1722 * sound.c (DEFAULT_ALSA_SOUND_DEVICE): Define only if HAVE_ALSA.
1723
836d29b3
DA
17242012-05-10 Dave Abrahams <dave@boostpro.com>
1725
1726 * filelock.c (syms_of_filelock): New boolean create-lockfiles.
1727 (lock_file): If create_lockfiles is 0, do nothing. (Bug#11227)
1728
5cb67954
MA
17292012-05-09 Michael Albinus <michael.albinus@gmx.de>
1730
1731 * dbusbind.c (xd_registered_buses): New internal Lisp object.
1732 Rename all occurences of Vdbus_registered_buses to xd_registered_buses.
1733 (syms_of_dbusbind): Remove declaration of Vdbus_registered_buses.
1734 Initialize xd_registered_buses.
1735
3478ec45
PE
17362012-05-09 Paul Eggert <eggert@cs.ucla.edu>
1737
b263a6b0
PE
1738 Untag more efficiently if USE_LSB_TAG.
1739 This is based on a proposal by YAMAMOTO Mitsuharu in
1740 <http://lists.gnu.org/archive/html/emacs-devel/2008-01/msg01876.html>.
1741 For an admittedly artificial (nth 8000 longlist) benchmark on
1742 Fedora 15 x86-64, this yields a 25% CPU speedup. Also, it shrinks
1743 Emacs's overall text size by 1%.
1744 * lisp.h (XUNTAG): New macro.
1745 (XCONS, XVECTOR, XSTRING, XSYMBOL, XFLOAT, XMISC, XPROCESS, XWINDOW)
1746 (XTERMINAL, XSUBR, XBUFFER, XCHAR_TABLE, XSUB_CHAR_TABLE, XBOOL_VECTOR)
1747 (XSETTYPED_PSEUDOVECTOR, XHASH_TABLE, TYPED_PSEUDOVECTORP): Use it.
1748 * eval.c (Fautoload):
1749 * font.h (XFONT_SPEC, XFONT_ENTITY, XFONT_OBJECT):
1750 * frame.h (XFRAME): Use XUNTAG.
1751
3478ec45
PE
1752 Port recent dbusbind.c changes to 32-bit --with-wide-int.
1753 * dbusbind.c (xd_append_arg, xd_retrieve_arg, Fdbus_message_internal):
1754 Remove unportable assumptions about print widths of types like
1755 dbus_uint32_t.
1756 (xd_get_connection_address, Fdbus_init_bus): Cast Emacs integer to
1757 intptr_t when converting between pointer and integer, to avoid GCC
1758 warnings about wrong width.
1759
666b903b 17602012-05-09 Eli Zaretskii <eliz@gnu.org>
0d887c7d
EZ
1761
1762 * w32proc.c (new_child): Force Windows to reserve only 64KB of
1763 stack for each reader_thread, instead of defaulting to 8MB
1764 determined by the linker. This avoids failures in creating
1765 subprocesses on Windows 7, see the discussion in this thread:
1766 http://lists.gnu.org/archive/html/emacs-devel/2012-03/msg00119.html.
1767
b120cc17
JC
17682012-05-07 Jérémy Compostella <jeremy.compostella@gmail.com>
1769
1770 Fix up display of the *Minibuf-0* buffer in the mini window.
1771 * keyboard.c (read_char): Don't clear the echo area if there's no
1772 message to clear.
1773 * xdisp.c (redisplay_internal): Redisplay the mini window (with the
2fed2689 1774 contents of *Minibuf-0*) if there's no message displayed in its stead.
b120cc17 1775
9a4b36f8
MA
17762012-05-07 Michael Albinus <michael.albinus@gmx.de>
1777
1778 * dbusbind.c (XD_DEBUG_MESSAGE): Don't print message twice in
1779 batch mode.
1780
e5f9458f
CY
17812012-05-06 Chong Yidong <cyd@gnu.org>
1782
1783 * lisp.mk (lisp): Update.
1784
eceeb5fc 17852012-05-05 Jim Meyering <meyering@redhat.com>
bf98199c
JM
1786
1787 * w32font.c (fill_in_logfont): NUL-terminate a string (Bug#11372).
1788
71873e2b
SM
17892012-05-04 Stefan Monnier <monnier@iro.umontreal.ca>
1790
1791 * data.c (PUT_ERROR): New macro.
1792 (syms_of_data): Use it. Add new error type `user-error'.
1793 * undo.c (user_error): New function.
1794 (Fprimitive_undo): Use it.
1795 * print.c (print_error_message): Adjust print style for `user-error'.
1796 * keyboard.c (user_error): New function.
1797 (Fexit_recursive_edit, Fabort_recursive_edit): Use it.
1798
ab0fa4e4
PE
17992012-05-03 Paul Eggert <eggert@cs.ucla.edu>
1800
1801 Do not limit current-time-string to years 1000..9999.
1802 * editfns.c (TM_YEAR_IN_ASCTIME_RANGE): Remove.
1803 (Fcurrent_time_string): Support any year that is supported by the
1804 underlying localtime representation. Don't use asctime, as it
1805 has undefined behavior for years outside the range -999..9999.
1806
7ed806a7
PE
18072012-05-02 Paul Eggert <eggert@cs.ucla.edu>
1808
1809 Fix race conditions involving setenv, gmtime, localtime, asctime.
1810 Without this fix, interrupts could mess up code that uses these
1811 nonreentrant functions, since setting TZ invalidates existing
1812 tm_zone or tzname values, and since most of these functions return
1813 pointers to static storage.
1814 * editfns.c (format_time_string, Fdecode_time, Fencode_time)
1815 (Fcurrent_time_string, Fcurrent_time_zone, Fset_time_zone_rule):
1816 Grow the critical sections to include not just invoking
1817 localtime/gmtime, but also accessing these functions' results
1818 including their tm_zone values if any, and any related TZ setting.
1819 (format_time_string): Last arg is now struct tm *, not struct tm **,
71873e2b
SM
1820 so that the struct tm is saved in the critical section.
1821 All callers changed. Simplify allocation of initial buffer, partly
7ed806a7
PE
1822 motivated by the fact that memory allocation needs to be outside
1823 the critical section.
1824
0c16dfed
DA
18252012-05-02 Dmitry Antipov <dmantipov@yandex.ru>
1826
1827 * intervals.c (adjust_intervals_for_insertion): Initialize `newi'
1828 with RESET_INTERVAL.
1829
1830 * buffer.c (Fget_buffer_create, Fmake_indirect_buffer):
1831 Remove duplicated buffer name initialization.
1832
3f83ace8
JM
18332012-05-02 Jim Meyering <jim@meyering.net>
1834
1835 * xterm.c (x_term_init): Use memcpy instead of strncpy (Bug#11373).
1836
c7b8541e
JM
1837 * xfns.c (x_window): Use xstrdup (Bug#11375).
1838
90207a15 18392012-05-02 Eli Zaretskii <eliz@gnu.org>
2fa85638
EZ
1840
1841 * xdisp.c (pos_visible_p): If already at a newline from the
1842 display string before the 'while' loop, don't walk back the glyphs
1843 from it3.glyph_row. Solves assertion violation when the display
1844 string begins with a newline (egg.el). (Bug#11367)
1845
b593d6a9
AH
18462012-05-01 Stefan Monnier <monnier@iro.umontreal.ca>
1847
1848 * keyboard.c (Fexecute_extended_command, Vsuggest_key_bindings):
1849 Move to simple.el.
1850
4737362e
GM
18512012-05-01 Glenn Morris <rgm@gnu.org>
1852
99cf43f9
GM
1853 * syssignal.h: Remove reference to BROKEN_SIGINFO (last used in
1854 s/ptx4.h), BROKEN_SIGTSTP (last used in m/ustation.h, m/dpx2.h),
1855 and BROKEN_SIGURG (was in s/gnu-linux.h prior to 2008-02-10).
1856 All were removed before 23.1.
1857
9311dcff
GM
1858 * dispnew.c: Remove HAVE_LIBNCURSES test;
1859 it is always true on relevant platforms.
1860
4d5c6349
GM
1861 * Makefile.in (LD_SWITCH_X_SITE_RPATH):
1862 Rename from LD_SWITCH_X_SITE_AUX_RPATH.
1863
4737362e
GM
1864 * Makefile.in (LD_SWITCH_X_SITE_AUX): Remove; no longer used.
1865
74dd3a6b
AS
18662012-04-30 Andreas Schwab <schwab@linux-m68k.org>
1867
1868 * .gdbinit (xpr): Remove checks for no longer existing misc types.
1869 (xintfwd, xboolfwd, xobjfwd, xbufobjfwd, xkbobjfwd, xbuflocal):
1870 Remove.
1871
13c379ee
PE
18722012-04-28 Paul Eggert <eggert@cs.ucla.edu>
1873
1874 Do not avoid creating empty evaporating overlays (Bug#9642).
1875 * buffer.c (Fmove_overlay): Revert the change of 2012-04-23.
1876 That is, do not delete an evaporating overlay if it becomes
1877 empty after its bounds are adjusted to fit within its buffer.
1878 This fix caused other problems, and I'm reverting it until we get
1879 to the bottom of them.
1880
a8e7d6d7 18812012-04-27 Chong Yidong <cyd@gnu.org>
9be2fd9b
CY
1882
1883 * xselect.c (x_convert_selection): Initialize a pointer (Bug#11315).
1884
a8e7d6d7 18852012-04-27 Eli Zaretskii <eliz@gnu.org>
f0ee99a0
EZ
1886
1887 * xdisp.c (pos_visible_p): If the window start position is beyond
1888 ZV, start the display from buffer beginning. Prevents assertion
1889 violation in init_iterator when the minibuffer window is scrolled
1890 via the scroll bar.
1891
1892 * window.c (window_scroll_pixel_based): Likewise.
1893
a8e7d6d7 18942012-04-27 Chong Yidong <cyd@gnu.org>
9ec7751f
CY
1895
1896 * keymap.c (where_is_internal): Doc fix (Bug#10872).
1897
a8e7d6d7 18982012-04-27 Glenn Morris <rgm@gnu.org>
24c51a09
GM
1899
1900 * fileio.c (Fcopy_file, Fset_file_selinux_context):
1901 Ignore ENOTSUP failures from setfilecon functions. (Bug#11245)
1902
a8e7d6d7 19032012-04-27 Eli Zaretskii <eliz@gnu.org>
73055685 1904
b593d6a9
AH
1905 * dispnew.c (swap_glyph_pointers, copy_row_except_pointers):
1906 Don't overrun array limits of glyph row's used[] array. (Bug#11288)
73055685 1907
1c6900d9
EZ
19082012-04-26 Eli Zaretskii <eliz@gnu.org>
1909
4c3fa1d9
EZ
1910 * xdisp.c (IT_DISPLAYING_WHITESPACE): In addition to the loaded
1911 display element, check also the underlying string or buffer
1912 character. (Bug#11341)
1913
1c6900d9
EZ
1914 * w32menu.c: Include w32heap.h.
1915 (add_menu_item): If the call to AppendMenuW (via
1916 unicode_append_menu) fails, disable Unicode menus only if we are
1917 running on Windows 9X/Me.
1918
42bf8205
AS
19192012-04-24 Andreas Schwab <schwab@linux-m68k.org>
1920
1921 * .gdbinit (xpr): Handle USE_2_TAGS_FOR_INTS.
1922 (xgetint): Add missing shift for LSB tags.
1923
b1bac16e
MR
19242012-04-24 Martin Rudalics <rudalics@gmx.at>
1925
1926 * keyboard.c (read_char): Don't wipe echo area for select window
1927 events: These might get delayed via `mouse-autoselect-window'
1928 (Bug#11304).
1929
d69621cc
JB
19302012-04-24 Juanma Barranquero <lekktu@gmail.com>
1931
1932 * gnutls.c (init_gnutls_functions): Protect against (unlikely)
1933 manipulation of :loaded-from data.
1934
02fd101b
JB
19352012-04-23 Juanma Barranquero <lekktu@gmail.com>
1936
1937 * gnutls.c (init_gnutls_functions): The value of :loaded-from is
1938 now a cons (bug#11311).
1939
888bec30
PE
19402012-04-23 Paul Eggert <eggert@cs.ucla.edu>
1941
89a438bd
PE
1942 Do not create empty overlays with the evaporate property (Bug#9642).
1943 * buffer.c (Fmove_overlay): Delete an evaporating overlay
1944 if it becomes empty after its bounds are adjusted to fit within
1945 its buffer. Without this fix, in a nonempty buffer (let ((o
1946 (make-overlay 1 2))) (overlay-put o 'evaporate t) (move-overlay o 0 1))
1947 yields an empty overlay that has the evaporate property, which is
1948 not supposed to happen.
1949
1068fe4d
PE
1950 Fix minor GTK3 problems found by static checking.
1951 * emacsgtkfixed.c (EMACS_TYPE_FIXED, EMACS_FIXED, EmacsFixed)
1952 (EmacsFixedPrivate, EmacsFixedClass, struct _EmacsFixed)
1953 (struct _EmacsFixedClass, emacs_fixed_get_type):
1954 Move decls here from emacsgtkfixed.h, since they needn't be public.
1955 (emacs_fixed_get_type): Now static.
1956 (emacs_fixed_class_init): Omit unused local.
1957 (emacs_fixed_child_type): Remove; unused.
1958 * emacsgtkfixed.h (EMACS_TYPE_FIXED, EMACS_FIXED, EmacsFixed)
1959 (EmacsFixedPrivate, EmacsFixedClass, struct _EmacsFixed)
1960 (struct _EmacsFixedClass): Move to emacsgtkfixed.c.
1961 (EMACS_FIXED_CLASS, EMACS_IS_FIXED, EMACS_IS_FIXED_CLASS)
1962 (EMACS_FIXED_GET_CLASS): Remove; unused.
1963 * gtkutil.c (xg_create_frame_widgets) [!HAVE_GTK3]: Omit unused local.
1964
888bec30
PE
1965 * keyboard.c (handle_async_input): Define only if SYNC_INPUT || SIGIO.
1966 Problem reported by Juanma Barranquero for Windows -Wunused-function.
1967
de85e130
PE
19682012-04-22 Paul Eggert <eggert@cs.ucla.edu>
1969
d0baac98 1970 Modernize and clean up gmalloc.c to assume C89 (Bug#9119).
bd7239f5 1971 * gmalloc.c (_MALLOC_INTERNAL, _MALLOC_H, _PP, __ptr_t)
d0baac98
PE
1972 (__malloc_size_t, __malloc_ptrdiff_t):
1973 Remove. All uses removed, replaced by the definiens if needed,
1974 since we can assume C89 or better now.
1975 Include <stdint.h>, for PTRDIFF_MAX, uintptr_t.
1976 (protect_malloc_state, align, get_contiguous_space)
1977 (malloc_atfork_handler_prepare, malloc_atfork_handler_parent)
1978 (malloc_atfork_handler_child, malloc_enable_thread)
1979 (malloc_initialize_1, __malloc_initialize, morecore_nolock)
1980 (_malloc_internal_nolock, _malloc_internal, malloc, _malloc)
1981 (_free, _realloc, _free_internal_nolock, _free_internal, free, cfree)
1982 (special_realloc, _realloc_internal_nolock, _realloc_internal)
1983 (realloc, calloc, __default_morecore, memalign, valloc, checkhdr)
1984 (freehook, mallochook, reallochook, mabort, mcheck, mprobe):
1985 Define using prototypes, not old style.
1986 (align, _malloc_internal_nolock, _free_internal_nolock, memalign):
1987 Don't assume ptrdiff_t and uintptr_t are no wider than unsigned long.
1988 (align): Don't assume that signed integer overflow wraps around.
1989 Omit unused local var.
1990 (malloc_initialize_1, morecore_nolock, _malloc_internal_nolock)
1991 (_free_internal_nolock, memalign, mallochook, reallochook):
1992 Omit no-longer-needed casts.
1993 (valloc): Use getpagesize, not __getpagesize.
1994 (MAGICWORD, MAGICFREE): Now randomish size_t values, not 32-bit.
1995 (struct hdr): The 'magic' member is now size_t, not unsigned long.
1996
de85e130
PE
1997 * dbusbind.c (XD_DBUS_VALIDATE_OBJECT): Define only if needed.
1998
dcbf5805
MA
19992012-04-22 Michael Albinus <michael.albinus@gmx.de>
2000
2001 Move functions from C to Lisp. Make non-blocking method calls
2002 the default. Implement further D-Bus standard interfaces.
2003
2004 * dbusbind.c (DBUS_NUM_MESSAGE_TYPES): Declare.
2005 (QCdbus_request_name_allow_replacement)
2006 (QCdbus_request_name_replace_existing)
2007 (QCdbus_request_name_do_not_queue)
2008 (QCdbus_request_name_reply_primary_owner)
2009 (QCdbus_request_name_reply_in_queue)
2010 (QCdbus_request_name_reply_exists)
2011 (QCdbus_request_name_reply_already_owner): Move to dbus.el.
2012 (QCdbus_registered_serial, QCdbus_registered_method)
2013 (QCdbus_registered_signal): New Lisp objects.
2014 (XD_DEBUG_MESSAGE): Use sizeof.
2015 (XD_MESSAGE_TYPE_TO_STRING, XD_OBJECT_TO_STRING)
2016 (XD_DBUS_VALIDATE_BUS_ADDRESS, XD_DBUS_VALIDATE_OBJECT)
2017 (XD_DBUS_VALIDATE_BUS_NAME, XD_DBUS_VALIDATE_PATH)
2018 (XD_DBUS_VALIDATE_INTERFACE, XD_DBUS_VALIDATE_MEMBER): New macros.
2019 (XD_CHECK_DBUS_SERIAL): Rename from CHECK_DBUS_SERIAL_GET_SERIAL.
2020 (xd_signature, xd_append_arg): Allow float for integer types.
2021 (xd_get_connection_references): New function.
b593d6a9
AH
2022 (xd_get_connection_address): Rename from xd_initialize.
2023 Return cached address.
dcbf5805
MA
2024 (xd_remove_watch): Do not unset $DBUS_SESSION_BUS_ADDRESS.
2025 (xd_close_bus): Rename from Fdbus_close_bus. Not needed on Lisp
2026 level.
2027 (Fdbus_init_bus): New optional arg PRIVATE. Cache address.
9a4b36f8 2028 Return number of refcounts.
dcbf5805
MA
2029 (Fdbus_get_unique_name): Make stronger parameter check.
2030 (Fdbus_message_internal): New defun.
2031 (Fdbus_call_method, Fdbus_call_method_asynchronously)
2032 (Fdbus_method_return_internal, Fdbus_method_error_internal)
2033 (Fdbus_send_signal, Fdbus_register_service)
2034 (Fdbus_register_signal, Fdbus_register_method): Move to dbus.el.
2035 (xd_read_message_1): Obey new structure of Vdbus_registered_objects.
2036 (xd_read_queued_messages): Obey new structure of Vdbus_registered_buses.
2037 (Vdbus_compiled_version, Vdbus_runtime_version)
2038 (Vdbus_message_type_invalid, Vdbus_message_type_method_call)
2039 (Vdbus_message_type_method_return, Vdbus_message_type_error)
2040 (Vdbus_message_type_signal): New defvars.
b593d6a9
AH
2041 (Vdbus_registered_buses, Vdbus_registered_objects_table):
2042 Adapt docstring.
dcbf5805 2043
52828e02
PE
20442012-04-22 Paul Eggert <eggert@cs.ucla.edu>
2045
da05bc4c
PE
2046 Fix GC_MALLOC_CHECK debugging output on 64-bit hosts.
2047 * alloc.c (emacs_blocked_malloc) [GC_MALLOC_CHECK]:
2048 Do not assume ptrdiff_t is the same width as 'int'.
2049
52828e02
PE
2050 * alloc.c: Handle unusual debugging option combinations.
2051 (GC_CHECK_MARKED_OBJECTS): Undef if ! GC_MARK_STACK,
2052 since the two debugging options are incompatible.
2053 (GC_MALLOC_CHECK): Similarly, undef if GC_CHECK_MARKED_OBJECTS
2054 is defined.
2055 (mem_init, mem_insert, mem_insert_fixup):
2056 Define if GC_MARK_STACK || GC_MALLOC_CHECK.
2057 (NEED_MEM_INSERT): Remove; no longer needed.
2058
f01769f9
LL
20592012-04-22 Leo Liu <sdl.web@gmail.com>
2060
2061 * sysdep.c (list_system_processes): Support Darwin (Bug#5725).
2062
5790543d
PE
20632012-04-22 Paul Eggert <eggert@cs.ucla.edu>
2064
2065 * sysdep.c [__FreeBSD__]: Minor cleanups.
2066 (list_system_processes, system_process_attributes) [__FreeBSD__]:
2067 Use Emacs indenting style more consistently. Avoid some casts.
2068 Use 'double' consistently rather than mixing 'float' and 'double'.
2069
b91b7e4d
EW
20702012-04-21 Eduard Wiebe <usenet@pusto.de>
2071
b593d6a9
AH
2072 * sysdep.c (list_system_processes, system_process_attributes):
2073 Add implementation for FreeBSD (Bug#5243).
b91b7e4d 2074
6114eb15
AS
20752012-04-21 Andreas Schwab <schwab@linux-m68k.org>
2076
2077 * lisp.mk (lisp): Update.
2078
2f38dff7
PE
20792012-04-20 Paul Eggert <eggert@cs.ucla.edu>
2080
2081 * keyboard.c (process_pending_signals): Define only if SYNC_INPUT.
2082 It is never used otherwise.
2083
4ae29f89
SM
20842012-04-20 Stefan Monnier <monnier@iro.umontreal.ca>
2085
2086 * print.c (print_preprocess): Only check print_depth if print-circle
2087 is nil.
2088 (print_object): Check for cycles even when print-circle is nil and
2089 print-gensym is t, but only check print_depth if print-circle is nil.
2090
f30d612a
CY
20912012-04-20 Chong Yidong <cyd@gnu.org>
2092
2093 * process.c (wait_reading_process_output): If EIO occurs on a pty,
2094 set the status to "failed" and ensure that sentinel is run.
2095
c07a4c0b 20962012-04-20 Glenn Morris <rgm@gnu.org>
016a35df
GM
2097
2098 * process.c (Fset_process_inherit_coding_system_flag)
2099 (Fset_process_query_on_exit_flag): Doc fix (mention return value).
4373fd43 2100 (Fmake_network_process, Fmake_serial_process): Doc fix.
016a35df 2101
c07a4c0b 21022012-04-20 Eli Zaretskii <eliz@gnu.org>
20a68157
EZ
2103
2104 * xdisp.c (string_buffer_position_lim): Limit starting position to
2105 BEGV.
2106 (set_cursor_from_row): If called for a mode-line or header-line
2107 row, return zero immediately.
2108 (try_cursor_movement): If inside continuation line, don't back up
4ae29f89
SM
2109 farther than the first row after the header line, if any.
2110 Don't consider the header-line row as "partially visible", even if
20a68157
EZ
2111 MATRIX_ROW_PARTIALLY_VISIBLE_P returns non-zero. (Bug#11261)
2112
c07a4c0b 21132012-04-20 Atsuo Ohki <ohki@gssm.otsuka.tsukuba.ac.jp> (tiny change)
ad3a2b41 2114
4ae29f89
SM
2115 * lread.c (lisp_file_lexically_bound_p): Fix hang at ";-*-\n"
2116 (bug#11238).
ad3a2b41 2117
c07a4c0b 21182012-04-20 Teodor Zlatanov <tzz@lifelogs.com>
6c94c34f 21192012-04-18 Paul Eggert <eggert@cs.ucla.edu>
ae6e112d
PE
2120
2121 configure: new option --enable-gcc-warnings (Bug#11207)
2122 * Makefile.in (C_WARNINGS_SWITCH): Remove.
2123 (WARN_CFLAGS, WERROR_CFLAGS): New macros.
2124 (ALL_CFLAGS): Use new macros rather than old.
2125 * process.c: Ignore -Wstrict-overflow to work around GCC bug 52904.
2126 * regex.c: Ignore -Wstrict-overflow. If !emacs, also ignore
2127 -Wunused-but-set-variable, -Wunused-function, -Wunused-macros,
2128 -Wunused-result, -Wunused-variable. This should go away once
2129 the Emacs and Gnulib regex code is merged.
2130 (xmalloc, xrealloc): Now static.
2131
aba027e8
PE
21322012-04-17 Paul Eggert <eggert@cs.ucla.edu>
2133
2134 * dired.c (Fsystem_groups): Remove unused local.
2135
e5a36063
GM
21362012-04-17 Glenn Morris <rgm@gnu.org>
2137
2138 * dired.c (Fsystem_users): Doc fix.
2139
316411f0
DA
21402012-04-17 Dmitry Antipov <dmantipov@yandex.ru>
2141
2142 * dired.c (Fsystem_users, Fsystem_groups): New functions. (Bug#7900)
2143 (syms_of_dired): Add them.
2144
9426aba4
PE
21452012-04-16 Paul Eggert <eggert@cs.ucla.edu>
2146
b62a57be
PE
2147 Fix minor alloc.c problems found by static checking.
2148 * alloc.c (_malloc_internal, _free_internal) [!DOUG_LEA_MALLOC]:
2149 New extern decls, to avoid calling undeclared functions.
2150 (dont_register_blocks): Define if ((!SYSTEM_MALLOC && !SYNC_INPUT)
2151 && GC_MALLOC_CHECK), not if ((GC_MARK_STACK || defined
2152 GC_MALLOC_CHECK) && GC_MALLOC_CHECK), to match when it's used.
2153 (NEED_MEM_INSERT): New macro.
2154 (mem_insert, mem_insert_fixup) [!NEED_MEM_INSERT]: Remove; unused.
4b5afbb0 2155 Remove one incorrect comment and fix another.
b62a57be 2156
3539f31f
PE
2157 Fix minor ralloc.c problems found by static checking.
2158 See http://lists.gnu.org/archive/html/emacs-devel/2011-12/msg00720.html
2159 * ralloc.c (ALIGNED, ROUND_TO_PAGE, HEAP_PTR_SIZE)
2160 (r_alloc_size_in_use, r_alloc_freeze, r_alloc_thaw): Remove; unused.
2161 (r_alloc_sbrk): Now static.
2162
a041960a
PE
2163 Improve ralloc.c interface checking.
2164 See http://lists.gnu.org/archive/html/emacs-devel/2011-12/msg00720.html
2165 * buffer.c (ralloc_reset_variable, r_alloc, r_re_alloc)
2166 (r_alloc_free) [REL_ALLOC]: Move decls from here ...
2167 * lisp.h (r_alloc, r_alloc_free, r_re_alloc, r_alloc_reset_variable)
2168 [REL_ALLOC]: ... to here, to check interface.
2169 * m/ia64.h (r_alloc, r_alloc_free) [REL_ALLOC && !_MALLOC_INTERNAL]:
2170 Remove decls. This fixes an "It stinks!".
2171
9426aba4
PE
2172 * alloc.c (which_symbols): Fix alignment issue / type clash.
2173
d55c12ed
AS
21742012-04-15 Andreas Schwab <schwab@linux-m68k.org>
2175
2176 * lisp.h (struct Lisp_Symbol): Remove explicit padding.
2177 (struct Lisp_Misc_Any): Likewise.
2178 (struct Lisp_Free): Likewise.
2179 * alloc.c (union aligned_Lisp_Symbol): Define.
2180 (SYMBOL_BLOCK_SIZE, struct symbol_block): Use union
2181 aligned_Lisp_Symbol instead of struct Lisp_Symbol.
2182 (union aligned_Lisp_Misc): Define.
2183 (MARKER_BLOCK_SIZE, struct marker_block): Use union
2184 aligned_Lisp_Misc instead of union Lisp_Misc.
4ae29f89 2185 (Fmake_symbol, allocate_misc, gc_sweep): Adjust.
d55c12ed 2186
b948ce8b
PE
21872012-04-14 Paul Eggert <eggert@cs.ucla.edu>
2188
2189 Make GC_MAKE_GCPROS_NOOPS the default (Bug#9926).
2190 * lisp.h (GC_MARK_STACK): Default to GC_MAKE_GCPROS_NOOPS.
2191 * s/cygwin.h, s/darwin.h, s/freebsd.h, s/gnu.h, s/irix6-5.h, s/msdos.h:
2192 * s/netbsd.h, s/sol2-6.h:
2193 Remove definition of GC_MARK_STACK, since the default now works.
2194 * s/aix4-2.h, s/hpux10-20.h, s/unixware.h:
2195 Define GC_MARK_STACK to GC_USE_GCPROS_AS_BEFORE, since that's
2196 no longer the default.
2197 * s/gnu-linux.h (GC_MARK_STACK): Adjust to change in default.
2198
35dc09a1 21992012-04-14 Atsuo Ohki <ohki@gssm.otsuka.tsukuba.ac.jp> (tiny change)
ad3a2b41 2200
35dc09a1
GM
2201 * lread.c (lisp_file_lexically_bound_p):
2202 Fix hang at ";-*-\n" (bug#11238).
ad3a2b41 2203
35dc09a1
GM
22042012-04-14 Eli Zaretskii <eliz@gnu.org>
2205
2206 * xdisp.c (find_last_unchanged_at_beg_row): Don't consider a row
2207 "unchanged" if its end.pos is beyond ZV. (Bug#11199)
2208
22092012-04-14 Jan Djärv <jan.h.d@swipnet.se>
2210
2211 * nsterm.m (constrainFrameRect): Always constrain when there is only
2212 one screen (Bug#10962).
2213
bcd86815
KB
22142012-04-13 Ken Brown <kbrown@cornell.edu>
2215
2216 * s/cygwin.h (PTY_OPEN): Don't try to close a bogus file descriptor.
2217
c25df26e
RT
22182012-04-13 Reuben Thomas <rrt@sc3d.org>
2219
2220 * indent.c (Fmove_to_column): Change interactive spec (Bug#739).
2221
0fc59f1e
DC
22222012-04-11 Daniel Colascione <dancol@dancol.org>
2223
2224 * s/cygwin.h: The vfork the #define in cygwin.h was protecting
2225 against is gone. It's better to use vfork now so that when Cygwin
2226 gains a new, working vfork, we use it automatically (bug#10398).
2227
de8c03dc
SM
22282012-04-11 Stefan Monnier <monnier@iro.umontreal.ca>
2229
2230 * window.c (save_window_save): Obey window-point-insertion-type.
2231
2f097256
GM
22322012-04-11 Glenn Morris <rgm@gnu.org>
2233
2234 * Makefile.in (GNUSTEP_CFLAGS): Rename from C_SWITCH_X_SYSTEM.
2235
453b951e
SM
22362012-04-11 Stefan Monnier <monnier@iro.umontreal.ca>
2237
2238 * alloc.c (lisp_align_malloc): Remove unneeded prototype.
2239
75f1671a 22402012-04-10 Jason S. Cornez <jcornez@ravenpack.com> (tiny change)
6bbef4e5
JC
2241
2242 * keyboard.c: Override inhibit-quit after the third C-g (bug#6585).
2243 (force_quit_count): New var.
2244 (handle_interrupt): Use it.
2245
2a8ce227
JB
22462012-04-10 Juanma Barranquero <lekktu@gmail.com>
2247
2248 * w32.c (w32_delayed_load): Record the full path of the library
2249 being loaded (bug#10424).
2250
935396c0
GM
22512012-04-09 Glenn Morris <rgm@gnu.org>
2252
05920a43
GM
2253 * doc.c (Fsnarf_documentation): Check variables, functions are bound,
2254 not just in the obarray, before snarfing them. (Bug#11036)
2255
935396c0
GM
2256 * Makefile.in ($(leimdir)/leim-list.el):
2257 Pass EMACS rather than BUILT_EMACS.
2258
a18ecafa
TZ
22592012-04-09 Teodor Zlatanov <tzz@lifelogs.com>
2260
2261 * process.c (make_process):
2262 * process.h: Add integer `gnutls_handshakes_tried' member to
2263 process struct.
2264
6bbef4e5
JC
2265 * gnutls.h: Add `GNUTLS_EMACS_HANDSHAKES_LIMIT' upper limit.
2266 Add convenience `GNUTLS_LOG2i' macro.
a18ecafa
TZ
2267
2268 * gnutls.c (gnutls_log_function2i): Convenience log function.
2269 (emacs_gnutls_read): Use new log functions,
2270 `gnutls_handshakes_tried' process member, and
2271 `GNUTLS_EMACS_HANDSHAKES_LIMIT' to limit the number of handshake
2272 attempts per process (connection).
2273
b4d3bc10
CY
22742012-04-09 Chong Yidong <cyd@gnu.org>
2275
2276 * eval.c (Fuser_variable_p, user_variable_p_eh)
2277 (lisp_indirect_variable): Functions deleted.
2278 (Fdefvar): Caller changed.
2279
2280 * callint.c (Finteractive, Fcall_interactively):
2281 * minibuf.c (Fread_variable): Callers changed.
2282
70f4d973
EZ
22832012-04-09 Eli Zaretskii <eliz@gnu.org>
2284
2285 * xdisp.c (set_cursor_from_row): If the display string appears in
2286 the buffer at position that is closer to point than the position
2287 after the display string, display the cursor on the first glyph of
2288 the display string. Fixes cursor display when a 'display' text
2289 property immediately follows invisible text. (Bug#11094)
2290
cb3c2e3e
PE
22912012-04-09 Paul Eggert <eggert@cs.ucla.edu>
2292
2293 composite.c: use 'double' consistently
2294 * composite.c (get_composition_id): Use 'double' consistently
2295 instead of converting 'float' to 'double' and vice versa; this is
2296 easier to understand and avoids a GCC warning.
2297
fd06db5d
GM
22982012-04-09 Glenn Morris <rgm@gnu.org>
2299
50fe702a
GM
2300 * Makefile.in: Generate leim-list with bootstrap-emacs, in
2301 preparation for dumping it with emacs. (Bug#4789)
2302 (leimdir): New variable.
2303 ($(leimdir)/leim-list.el): New rule.
2304 (emacs$(EXEEXT)): Depend on leim-list.el.
2305
fd06db5d
GM
2306 * buffer.c (Qucs_set_table_for_input): Remove. (Bug#9821)
2307 (Fget_buffer_create): Don't call Qucs_set_table_for_input.
2308 (init_buffer_once, syms_of_buffer): Remove Qucs_set_table_for_input.
2309
55c131ee
AS
23102012-04-08 Andreas Schwab <schwab@linux-m68k.org>
2311
2312 * lisp.h (struct Lisp_Symbol): Add explicit padding to ensure
2313 proper alignment.
2314
9209588f
JB
23152012-04-07 Juanma Barranquero <lekktu@gmail.com>
2316
2317 * xml.c (init_libxml2_functions) [WINDOWSNT]:
2318 Remove unused local variable.
2319
e3fb2efb
PE
23202012-04-07 Paul Eggert <eggert@cs.ucla.edu>
2321
2322 Avoid unnecessary pointer scanning in garbage collection (Bug#10780).
2323 * alloc.c (POINTERS_MIGHT_HIDE_IN_OBJECTS): New macro.
2324 (mark_memory): Mark Lisp_Objects only if pointers might hide in
2325 objects, as mark_maybe_pointer will catch them otherwise.
2326 (GC_LISP_OBJECT_ALIGNMENT): Remove; no longer needed.
2327 * s/gnu-linux.h (GC_LISP_OBJECT_ALIGNMENT) [__mc68000__]: Likewise.
2328
b5385551
PE
23292012-04-07 Paul Eggert <eggert@cs.ucla.edu>
2330
2331 Fix typo that broke non-Windows builds.
2332 * xml.c (libxml2_loaded_p) [!!WINDOWSNT]: 'inine' -> 'inline'.
2333
9078ead6
EZ
23342012-04-07 Eli Zaretskii <eliz@gnu.org>
2335
2336 Support building on MS-Windows with libxml2.
2337
2338 * makefile.w32-in (OBJ2): Add xml.$(O).
2339 (GLOBAL_SOURCES): Add xml.c.
2340 ($(BLD)/xml.$(O)): New dependency list.
2341
2342 * xml.c (DEF_XML2_FN, LOAD_XML2_FN) [WINDOWSNT]: New macros.
2343 (fn_htmlReadMemory, fn_xmlReadMemory, fn_xmlDocGetRootElement)
2344 (fn_xmlFreeDoc, fn_xmlCleanupParser, fn_xmlCheckVersion)
2345 [!WINDOWSNT]: New macros.
2346 (init_libxml2_functions, libxml2_loaded_p): New functions.
2347 (parse_region): Call fn_xmlCheckVersion instead of using the macro
2348 LIBXML_TEST_VERSION. Call libxml2 functions via the fn_* macros.
2349 (xml_cleanup_parser): New function, export for fn_xmlCleanupParser.
2350 Calls xmlCleanupParser only if libxml2 was loaded (or statically
2351 linked in).
6bbef4e5
JC
2352 (Flibxml_parse_html_region, Flibxml_parse_xml_region):
2353 Call init_libxml2_functions before calling libxml2 functions.
9078ead6
EZ
2354 (syms_of_xml) <Qlibxml2_dll>: DEFSYM it.
2355
2356 * emacs.c: Don't include libxml/parser.h.
2357 (shut_down_emacs): Call xml_cleanup_parser, instead of calling
2358 xmlCleanupParser directly.
2359
2360 * lisp.h [HAVE_LIBXML2]: Add prototype for xml_cleanup_parser.
2361
3811fdf3
EZ
23622012-04-07 Eli Zaretskii <eliz@gnu.org>
2363
2364 * indent.c (Fvertical_motion): If there is a display string at
2365 point, use it.vpos to compute how many lines to backtrack after
2366 move_it_to point. (Bug#11133)
2367
2f8e16b2
EZ
23682012-04-06 Eli Zaretskii <eliz@gnu.org>
2369
2370 * buffer.h (FETCH_CHAR, FETCH_MULTIBYTE_CHAR):
2371 * character.h (STRING_CHAR, STRING_CHAR_AND_LENGTH): Add comments
2372 about subtle differences between FETCH_CHAR* and STRING_CHAR*
2373 macros related to unification of CJK characters. For the details,
2374 see the discussion following the message here:
2375 http://debbugs.gnu.org/cgi/bugreport.cgi?bug=11073#14.
2376
3d439cd1
CY
23772012-04-04 Chong Yidong <cyd@gnu.org>
2378
2379 * keyboard.c (Vdelayed_warnings_list): Doc fix.
2380
8bc53d00
EZ
23812012-04-01 Eli Zaretskii <eliz@gnu.org>
2382
2383 * w32menu.c (simple_dialog_show, add_menu_item): Use SAFE_ALLOCA
2384 instead of alloca. (Bug#11138)
2385
3b0512a3
AS
23862012-04-01 Andreas Schwab <schwab@linux-m68k.org>
2387
2388 * w32menu.c (is_simple_dialog): Properly check lisp types.
2389 (Bug#11141)
2390
8427ddd2
EZ
23912012-03-31 Eli Zaretskii <eliz@gnu.org>
2392
979022ef
EZ
2393 * xdisp.c (move_it_by_lines): When DVPOS is positive, and the
2394 position we get to after a call to move_it_to fails the
2395 IS_POS_VALID_AFTER_MOVE_P test, move to the next buffer position
2396 only if we wind up in a string from display property. (Bug#11063)
2397
a6b1c7cc
EZ
2398 * window.c (Fdelete_other_windows_internal): Invalidate the row
2399 and column information about mouse highlight, so that redisplay
2400 restores it after reallocating the glyph matrices. (Bug#7464)
2401
8427ddd2
EZ
2402 * xdisp.c (set_cursor_from_row): If `cursor' property on a display
2403 string comes from a `display' text property, use the buffer
2404 position of that property as if we actually saw that position in
2405 the row's glyphs.
697ba24b
EZ
2406 (move_it_by_lines): Remove the assertion that
2407 "it->current_x == 0 && it->hpos == 0" which can be legitimately
2408 violated when there's a before-string at the beginning of a line.
2409 (Bug#11063)
8427ddd2 2410
65a0a738
EZ
24112012-03-30 Eli Zaretskii <eliz@gnu.org>
2412
2413 * xdisp.c (append_space_for_newline): If the default face was
2414 remapped, use the remapped face for the appended newline.
2415 (extend_face_to_end_of_line): Use the remapped default face for
2416 extending the face to the end of the line.
2417 (display_line): Call extend_face_to_end_of_line when the default
2418 face was remapped. (Bug#11068)
2419
581355cc
EZ
24202012-03-29 Eli Zaretskii <eliz@gnu.org>
2421
2422 * s/ms-w32.h: Discourage from defining HAVE_GETCWD.
2423
e8fc049f
SM
24242012-03-28 Stefan Monnier <monnier@iro.umontreal.ca>
2425
2426 * keyboard.c (safe_run_hooks_error): Don't unquote strings.
2427
4fb9a543
GM
24282012-03-27 Glenn Morris <rgm@gnu.org>
2429
2430 * search.c (Fword_search_backward_lax, Fword_search_forward_lax):
2431 Doc fixes.
2432
679910f1
KH
24332012-03-26 Kenichi Handa <handa@m17n.org>
2434
2435 * dispextern.h (struct glyph): Fix previous change. Change the
2436 bit length of glyphless.ch to 25 (Bug#11082).
2437
90d49b7f
CY
24382012-03-26 Chong Yidong <cyd@gnu.org>
2439
2440 * keyboard.c (Vselection_inhibit_update_commands): New variable.
2441 (command_loop_1): Use it; inhibit selection update for
2442 handle-select-window too (Bug#8996).
2443
f514f6f0
FP
24442012-03-25 Fabrice Popineau <fabrice.popineau@supelec.fr>
2445
e8fc049f 2446 * w32heap.c (_heap_init, _heap_term): Remove dead MSVC-specific code.
f514f6f0 2447
bf43fa51
KH
24482012-03-25 Kenichi Handa <handa@m17n.org>
2449
2450 * dispextern.h (struct glyph): Change the bit length of
2451 glyphless.ch to 22 to make the member glyphless fit in 32 bits.
2452
8a0c01dd
EZ
24532012-03-24 Eli Zaretskii <eliz@gnu.org>
2454
2455 * s/ms-w32.h (tzname): Include time.h before redirecting to
2456 _tzname. Fixes the MSVC build. (Bug#9960)
2457
7d1c3a76
AS
24582012-03-24 Andreas Schwab <schwab@linux-m68k.org>
2459
8ed79523
AS
2460 * xdisp.c (produce_glyphless_glyph): Limit length of acronym to 6
2461 characters.
2462
7d1c3a76
AS
2463 * xterm.c (XTread_socket): Only modify handling_signal if
2464 !SYNC_INPUT. (Bug#11080)
2465
e99a9b8b
EZ
24662012-03-23 Eli Zaretskii <eliz@gnu.org>
2467
2468 * bidi.c (bidi_fetch_char): Use STRING_CHAR_AND_LENGTH instead of
2469 FETCH_MULTIBYTE_CHAR followed by CHAR_BYTES. Prevents crashes
2470 when fetching a multibyte character consumes more bytes than
2471 CHAR_BYTES returns, due to unification of CJK characters in
2472 string_char. (Bug#11073)
2473
5063c0e1
TN
24742012-03-23 Troels Nielsen <bn.troels@gmail.com> (tiny change)
2475
2476 * process.c (wait_reading_process_output): Handle pty disconnect
2477 by refraining from sending oneself a SIGCHLD (bug#10933).
2478
9f851fbd
CY
24792012-03-22 Chong Yidong <cyd@gnu.org>
2480
2481 * dispextern.h (struct it): New member string_from_prefix_prop_p.
2482
5063c0e1 2483 * xdisp.c (push_prefix_prop): Rename from push_display_prop.
9f851fbd
CY
2484 Mark string as coming from a prefix property.
2485 (handle_face_prop): Use default face for prefix strings (Bug#4281).
2486 (pop_it, reseat_1): Save and restore string_from_prefix_prop_p.
2487
fb5b8aca
CY
24882012-03-21 Chong Yidong <cyd@gnu.org>
2489
2490 * xfaces.c (Vface_remapping_alist): Doc fix.
2491
62356a1b
EZ
24922012-03-20 Eli Zaretskii <eliz@gnu.org>
2493
2494 * w32proc.c (Fw32_set_console_codepage)
5063c0e1
TN
2495 (Fw32_set_console_output_codepage, Fw32_get_codepage_charset):
2496 Doc fixes.
62356a1b 2497
025de85b
CY
24982012-03-20 Chong Yidong <cyd@gnu.org>
2499
2500 * dispnew.c (Fredisplay, Vredisplay_preemption_period): Update doc
2501 to reflect default non-nil value of redisplay-dont-pause.
2502
4827f94e
KH
25032012-03-19 Kenichi Handa <handa@m17n.org>
2504
2505 * ftfont.c (ftfont_drive_otf): Mask bits of character code to make
2506 it fit in a valid range (Bug#11003).
2507
e50a24a2
EZ
25082012-03-18 Eli Zaretskii <eliz@gnu.org>
2509
2510 * xdisp.c (cursor_row_p): Even if the glyph row ends in a string
2511 that is not from display property, accept the row as a "cursor
2512 row" if one of the string's character has a non-nil `cursor'
2513 property. Fixes cursor positioning when there are newlines in
2514 overlay strings, e.g. in icomplete.el. (Bug#11035)
2515
9af5ed87
PE
25162012-03-12 Paul Eggert <eggert@cs.ucla.edu>
2517
2518 * buffer.c (compare_overlays): Don't assume args differ (Bug#6830).
2519
d1f55f16
CY
25202012-03-12 Chong Yidong <cyd@gnu.org>
2521
2522 * eval.c (inhibit_lisp_code): Rename from
2523 inhibit_window_configuration_change_hook; move from window.c.
2524
2525 * xfns.c (unwind_create_frame_1, Fx_create_frame):
2526 * window.c (run_window_configuration_change_hook)
2527 (syms_of_window): Callers changed.
2528
66c5eebd
CY
25292012-03-11 Chong Yidong <cyd@gnu.org>
2530
413df973
CY
2531 * keymap.c (Fkey_description): Doc fix (Bug#9700).
2532
66c5eebd
CY
2533 * editfns.c (Fconstrain_to_field): Doc fix (Bug#9452).
2534
1de11f56
CY
25352012-03-10 Chong Yidong <cyd@gnu.org>
2536
2537 * frame.c (other_visible_frames): Don't assume the selected frame
2538 is visible (Bug#10955).
2539
cae07000
SM
25402012-03-09 Stefan Monnier <monnier@iro.umontreal.ca>
2541
2542 * buffer.c (compare_overlays): Avoid qsort's instability (bug#6830).
2543
89c94350
JD
25442012-03-08 Jan Djärv <jan.h.d@swipnet.se>
2545
2546 * gtkutil.c (x_wm_set_size_hint): Use one row in call to
2547 FRAME_TEXT_LINES_TO_PIXEL_HEIGHT so base_height is greater than
2548 zero (Bug#10954).
2549
999dd333
GM
25502012-03-03 Glenn Morris <rgm@gnu.org>
2551
01a6dcc8 2552 * alloc.c (Fgarbage_collect, misc-objects-consed): Doc fixes.
999dd333 2553
de0100f2
EZ
25542012-03-02 Eli Zaretskii <eliz@gnu.org>
2555
2556 * xdisp.c (try_window_reusing_current_matrix): Don't move cursor
2557 position past the first glyph_row that ends at ZV. (Bug#10902)
b8456c5c
EZ
2558 (redisplay_window, next_element_from_string): Fix typos in
2559 comments.
3e441275
EZ
2560 (redisplay_window): Pass to move_it_vertically the margin in
2561 pixels, not in screen lines.
de0100f2 2562
96a72ee9
GM
25632012-03-02 Glenn Morris <rgm@gnu.org>
2564
2565 * buffer.c (buffer-list-update-hook): Doc fix.
2566
312508d7
EZ
25672012-02-29 Eli Zaretskii <eliz@gnu.org>
2568
2569 * xdisp.c (get_overlay_strings_1): Under bidi redisplay, call
2570 push_it before setting up the iterator for the first overlay
2571 string, even if we have an empty string loaded.
2572 (next_overlay_string): If there's an empty string on the iterator
2573 stack, pop the stack. (Bug#10903)
2574
27f3c637
PE
25752012-02-25 Paul Eggert <eggert@cs.ucla.edu>
2576
2577 Generalize fix for crash due to non-contiguous EMACS_INT (Bug#10780).
2578 Suggested by Stefan Monnier in
2579 <http://lists.gnu.org/archive/html/emacs-devel/2012-02/msg00692.html>.
2580 * alloc.c (widen_to_Lisp_Object): New static function.
2581 (mark_memory): Also mark Lisp_Objects by fetching pointer words
2582 and widening them to Lisp_Objects. This would work even if
2583 USE_LSB_TAG is defined and wide integers are used, which might
2584 happen in a future version of Emacs.
2585
3c9dfce6
CY
25862012-02-25 Chong Yidong <cyd@gnu.org>
2587
fa74b241
CY
2588 * fileio.c (Ffile_selinux_context, Fset_file_selinux_context):
2589 Doc fix.
2590
3c9dfce6
CY
2591 * xselect.c (Fx_selection_exists_p): Doc fix.
2592 (x_clipboard_manager_save_all): Print an informative message
2593 before saving to clipboard manager.
2594
9486df08
CY
25952012-02-24 Chong Yidong <cyd@gnu.org>
2596
2597 * keyboard.c (process_special_events): Handle all X selection
2598 requests in kbd_buffer, not just the next one (Bug#8869).
2599
f01d3321
CY
26002012-02-23 Chong Yidong <cyd@gnu.org>
2601
2602 * xfns.c (Fx_create_frame): Avoid window-configuration-change-hook
2603 call when setting menu-bar-lines and tool-bar-lines parameters.
2604 (unwind_create_frame_1): New helper function.
2605
2606 * window.c (inhibit_window_configuration_change_hook): New var.
2607 (run_window_configuration_change_hook): Obey it.
b2e4ca7d 2608 (syms_of_window): Initialize it.
f01d3321 2609
86b847b6
CY
26102012-02-22 Chong Yidong <cyd@gnu.org>
2611
2612 * xterm.c (x_draw_image_relief): Add missing type check for
2613 Vtool_bar_button_margin (Bug#10743).
2614
a59225b1
CY
26152012-02-21 Chong Yidong <cyd@gnu.org>
2616
2617 * fileio.c (Vfile_name_handler_alist): Doc fix.
2618
2619 * buffer.c (Fget_file_buffer): Protect against invalid file
2620 handler return value.
2621
310f5bd4
PE
26222012-02-20 Paul Eggert <eggert@cs.ucla.edu>
2623
cb3a28cc
PE
2624 * .gdbinit (xreload): Don't assume EMACS_INT fits in 'long'
2625 when computing $valmask.
2626
310f5bd4
PE
2627 Fix crash due to non-contiguous EMACS_INT (Bug#10780).
2628 * lisp.h (VALBITS): Move definition up, so that USE_LSB_TAG can use it.
2629 (USE_LSB_TAG): Do not define if UINTPTR_MAX >> VALBITS == 0.
2630 It's useless in that case, and it can cause problems on hosts
2631 that allocate halves of EMACS_INT values separately.
2632 Reported by Dan Horák. Diagnosed by Andreas Schwab in
2633 <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=10780#30>.
2634 * mem-limits.h (EXCEEDS_LISP_PTR): Define to 0 on hosts where
2635 UINTPTR_MAX >> VALBITS == 0. This is required by the above change;
2636 it avoids undefined behavior on hosts where shifting right by more
2637 than the word width has undefined behavior.
2638
2375c96a
CY
26392012-02-19 Chong Yidong <cyd@gnu.org>
2640
2641 * fileio.c (Ffile_name_directory, Ffile_name_nondirectory)
2642 (Funhandled_file_name_directory, Ffile_name_as_directory)
2643 (Fdirectory_file_name, Fexpand_file_name)
2644 (Fsubstitute_in_file_name): Protect against invalid file handler
2645 return values (Bug#10845).
2646
3eb49e71
EZ
26472012-02-18 Eli Zaretskii <eliz@gnu.org>
2648
2649 * .gdbinit (pitx): Fix incorrect references to fields of the
2650 iterator stack.
2651
7b926f3f
CY
26522012-02-17 Chong Yidong <cyd@gnu.org>
2653
2654 * syntax.c (Fscan_lists): Doc fix (Bug#10833).
2655
11273115
PE
26562012-02-15 Paul Eggert <eggert@cs.ucla.edu>
2657
2658 * image.c (MAX_IMAGE_SIZE): Increase from 6.0 to 10.0; see
2659 <http://lists.gnu.org/archive/html/emacs-devel/2012-02/msg00540.html>.
2660
c3a70e2b
CY
26612012-02-15 Chong Yidong <cyd@gnu.org>
2662
2663 * eval.c (Fdefvar, Fdefconst): Doc fix; note that the variable is
2664 marked as special. Also, starting docstrings with * is obsolete.
2665
0ca43699
AS
26662012-02-13 Andreas Schwab <schwab@linux-m68k.org>
2667
2668 * gnutls.c (emacs_gnutls_write): Fix last change.
2669
2e8f3c56
LI
26702012-02-13 Lars Ingebrigtsen <larsi@gnus.org>
2671
2672 * gnutls.c (emacs_gnutls_write): Set errno appropriately for
2673 send_process.
2674
af70074f
SM
26752012-02-13 Stefan Monnier <monnier@iro.umontreal.ca>
2676
2677 * keymap.c (Fsingle_key_description): Handle char ranges.
2678
95986d52
CY
26792012-02-12 Chong Yidong <cyd@gnu.org>
2680
afd83bd1
CY
2681 * xdisp.c (handle_stop): Avoid assigning -1 to it->face_id here,
2682 as that creates a dangerous corner case.
2683
95986d52
CY
2684 * window.c (Fdelete_window_internal): Invalidate the mouse
2685 highlight (Bug#9904).
2686
bd7da63e
GM
26872012-02-12 Glenn Morris <rgm@gnu.org>
2688
2689 * xselect.c (Fx_own_selection_internal)
2690 (Fx_get_selection_internal, Fx_disown_selection_internal)
2691 (Fx_selection_owner_p, Fx_selection_exists_p): Doc fixes.
2692 * nsselect.m (Fx_own_selection_internal)
2693 (Fx_disown_selection_internal, Fx_selection_exists_p)
2694 (Fx_selection_owner_p, Fx_get_selection_internal):
2695 Sync docs and argument specs with the xselect.c versions.
2696
77abcbc2
LI
26972012-02-11 Lars Ingebrigtsen <larsi@gnus.org>
2698
2699 * gnutls.c (emacs_gnutls_write): Don't infloop if sendto fails.
2700
90b671e2
EZ
27012012-02-11 Eli Zaretskii <eliz@gnu.org>
2702
1c0ca0b7
EZ
2703 * w32select.c (Fx_selection_exists_p): Sync doc string and
2704 argument list with xselect.c. (Bug#10783)
2705
2706 * w16select.c (Fx_selection_exists_p): Sync doc string and
2707 argument list with xselect.c. (Bug#10783)
90b671e2 2708
49241268
GM
27092012-02-10 Glenn Morris <rgm@gnu.org>
2710
2711 * fns.c (Fsecure_hash): Doc fix.
2712
f998bbe7 27132012-02-09 Kenichi Handa <handa@m17n.org>
5c1ca13d
KH
2714
2715 * coding.c (produce_chars): Fix updating of src_end (Bug#10701).
2716
0992bd9c
CY
27172012-02-07 Chong Yidong <cyd@gnu.org>
2718
2719 * buffer.c (Fbuffer_local_variables)
2720 (buffer_lisp_local_variables): Handle unbound vars correctly;
2721 don't let Qunbound leak into Lisp.
2722
af008560
GM
27232012-02-07 Glenn Morris <rgm@gnu.org>
2724
dd605cc4
GM
2725 * image.c (Fimagemagick_types): Doc fix.
2726
af008560
GM
2727 * image.c (imagemagick-render-type): Change it from a lisp object
2728 to an integer. Move the doc here from the lisp manual.
2729 Treat all values not equal to 0 the same.
2730
1449fa1d
CY
27312012-02-06 Chong Yidong <cyd@gnu.org>
2732
2733 * doc.c (store_function_docstring): Avoid applying docstring of
2734 alias to base function (Bug#2603).
2735
3723ec07
AS
27362012-02-04 Andreas Schwab <schwab@linux-m68k.org>
2737
2738 * .gdbinit (pp1, pv1): Remove redundant defines.
2739 (pr): Use pp.
2740
79c1cc1e
CY
27412012-02-04 Chong Yidong <cyd@gnu.org>
2742
2743 * nsterm.m: Declare a global (Bug#10694).
2744
d7f29f8e
EZ
27452012-02-04 Eli Zaretskii <eliz@gnu.org>
2746
cae07000
SM
2747 * w32.c (get_emacs_configuration_options):
2748 Include --enable-checking, if specified, in the return value.
d7f29f8e 2749
3b95a6f9
MR
27502012-02-04 Martin Rudalics <rudalics@gmx.at>
2751
2752 * dispnew.c (change_frame_size_1): Calculate new_frame_total_cols
2753 after rounding frame sizes. (Bug#9723)
2754
d6fa96a6
EZ
27552012-02-04 Eli Zaretskii <eliz@gnu.org>
2756
2757 * keyboard.c (adjust_point_for_property): Don't position point
2758 before BEGV. (Bug#10696)
2759
df0b2940
PE
27602012-02-03 Paul Eggert <eggert@cs.ucla.edu>
2761
2762 Handle overflow when computing char display width (Bug#9496).
2763 * character.c (char_width): Return EMACS_INT, not int.
2764 (char_width, c_string_width): Check for overflow when
2765 computing the width; this is possible now that individual
2766 characters can have unbounded width. Problem introduced
2767 by merge from Emacs 23 on 2012-01-19.
2768
6bee44d6
MA
27692012-02-02 Michael Albinus <michael.albinus@gmx.de>
2770
2771 * dbusbind.c (Fdbus_register_method): Mention the return value
2772 :ignore in the docstring.
2773
44f92739
GM
27742012-02-02 Glenn Morris <rgm@gnu.org>
2775
1b9f60cc
GM
2776 * callproc.c (Fcall_process, Fcall_process_region): Doc fix.
2777
44f92739
GM
2778 * nsterm.m (syms_of_nsterm) <x-toolkit-scroll-bars>:
2779 Unconditionally set to t. (Bug#10673)
2780 * nsterm.m (syms_of_nsterm) <x-toolkit-scroll-bars>:
2781 * w32term.c (syms_of_w32term) <x-toolkit-scroll-bars>:
2782 * xterm.c (syms_of_xterm) <x-toolkit-scroll-bars>: Doc fix.
2783
c5d3843c
KH
27842012-02-02 Kenichi Handa <handa@m17n.org>
2785
2786 (x_produce_glyphs): Cancel previous change. If cmp->glyph_len is
2787 0, do not call append_composite_glyph.
2788
159462d4 27892012-02-02 Kenichi Handa <handa@m17n.org>
d2a51fd7
KH
2790
2791 * xdisp.c (BUILD_COMPOSITE_GLYPH_STRING): Initialize first_s to
2792 NULL (Bug#6988).
2793 (x_produce_glyphs): If the component of a composition is a null
2794 string, set it->pixel_width to 1 to avoid zero-width glyph.
2795
78cef877
EZ
27962012-02-01 Eli Zaretskii <eliz@gnu.org>
2797
2798 * ralloc.c (resize_bloc, r_alloc_sbrk): Don't call memmove if its
2799 first 2 arguments are identical. This makes inserting large
2800 output from a subprocess an order of magnitude faster on
2801 MS-Windows, where all sbrk'ed memory is always contiguous.
2802
97897668
GM
28032012-01-31 Glenn Morris <rgm@gnu.org>
2804
2805 * nsterm.m (syms_of_nsterm) <x-toolkit-scroll-bars>:
c78c6e0b 2806 * w32term.c (syms_of_w32term) <x-toolkit-scroll-bars>:
97897668
GM
2807 * xterm.c (syms_of_xterm) <x-toolkit-scroll-bars>: Sync docs.
2808
31fd3586
GM
28092012-01-29 Glenn Morris <rgm@gnu.org>
2810
2811 * gnutls.c (syms_of_gnutls): More doc (from etc/NEWS).
2812
0e24a8b2
CY
28132012-01-28 Samuel Thibault <sthibault@debian.org> (tiny change)
2814
2815 * s/gnu.h: Define POSIX_SIGNALS (Bug#10552).
2816
cc0adcb0
CY
28172012-01-28 Chong Yidong <cyd@gnu.org>
2818
2819 * minibuf.c (syms_of_minibuf): Doc fix (Bug#10550).
2820
acc28cb9
CY
28212012-01-26 Chong Yidong <cyd@gnu.org>
2822
9c69cfb7
CY
2823 * keyboard.c (Vecho_keystrokes): Document zero value (Bug#10503).
2824
acc28cb9
CY
2825 * search.c (Fsearch_forward, Fsearch_backward): Document negative
2826 repeat counts (Bug#10507).
2827
48da7392
GM
28282012-01-26 Glenn Morris <rgm@gnu.org>
2829
2830 * lread.c (syms_of_lread): Doc fix.
2831
14af5f7f
CY
28322012-01-25 HIROSHI OOTA <nil@mad.dog.cx> (tiny change)
2833
2834 * coding.c (encode_designation_at_bol): Change return value to
2835 EMACS_INT.
2836
0b21c100
CY
28372012-01-25 Chong Yidong <cyd@gnu.org>
2838
2839 * eval.c (Fuser_variable_p): Doc fix; mention custom-variable-p.
2840
3c2907f7
CY
28412012-01-21 Chong Yidong <cyd@gnu.org>
2842
2843 * floatfns.c (Fcopysign): Make the second argument non-optional,
2844 since nil is not allowed anyway.
2845
959ad23f
AS
28462012-01-21 Andreas Schwab <schwab@linux-m68k.org>
2847
2848 * process.c (read_process_output): Use p instead of XPROCESS (proc).
2849 (send_process): Likewise.
2850
34a02f46
MR
28512012-01-19 Martin Rudalics <rudalics@gmx.at>
2852
2853 * window.c (save_window_save, Fcurrent_window_configuration)
cae07000
SM
2854 (Vwindow_persistent_parameters): Do not use Qstate.
2855 Rewrite doc-strings.
34a02f46 2856
1259009a 28572012-01-19 Kenichi Handa <handa@m17n.org>
25ed9e61
KH
2858
2859 * character.c (char_width): New function.
70d4fdf6
GM
2860 (Fchar_width, c_string_width, lisp_string_width):
2861 Use char_width (Bug#9496).
25ed9e61 2862
6a6ee00d
MR
28632012-01-16 Martin Rudalics <rudalics@gmx.at>
2864
2865 * window.c (Vwindow_persistent_parameters): New variable.
2866 (Fset_window_configuration, save_window_save): Handle persistent
2867 window parameters.
2868
c85efaf7
EZ
28692012-01-14 Eli Zaretskii <eliz@gnu.org>
2870
2871 * w32fns.c (signal_user_input): Don't do a QUIT, to avoid
2872 thrashing the stack of the thread. (Bug#9087)
2873
5944709e
PE
28742012-01-12 Paul Eggert <eggert@cs.ucla.edu>
2875
2876 * xdisp.c (rows_from_pos_range): Add parens as per gcc -Wparentheses.
2877
e71f5d99
EZ
28782012-01-11 Eli Zaretskii <eliz@gnu.org>
2879
2880 * xdisp.c (rows_from_pos_range): Handle the case where the
2881 highlight ends on a newline. (Bug#10464)
2882 (mouse_face_from_buffer_pos): Fix off-by-one error in calculating
2883 he end column for display of highlight that ends on a newline
2884 before a R2L line.
2885
ce316182
GM
28862012-01-11 Glenn Morris <rgm@gnu.org>
2887
2888 * lread.c (init_lread): If no-site-lisp, remove site-lisp dirs
2889 from load-path also when installation-directory is nil. (Bug#10208)
2890
5b43da69
GM
28912012-01-10 Glenn Morris <rgm@gnu.org>
2892
74cc8ff9
GM
2893 * emacs.c (syms_of_emacs) <installation-directory>: Doc fix.
2894
7d8d6e4e
GM
2895 * epaths.in (PATH_LOADSEARCH, PATH_EXEC, PATH_DATA, PATH_DOC):
2896 Update template values to be closer to their typical values these days.
5b43da69 2897
a0db8d43
EZ
28982012-01-09 Eli Zaretskii <eliz@gnu.org>
2899
2900 * xdisp.c (rows_from_pos_range): Accept additional argument
2901 DISP_STRING, and accept any glyph in a row whose object is that
2902 string as eligible for mouse highlight. Fixes mouse highlight of
2903 display strings from overlays. (Bug#10464)
2904
9a0115ab 29052012-01-07 Paul Eggert <eggert@cs.ucla.edu>
09450bae 2906
b9110d6a 2907 emacs: fix an auto-save permissions race condition (Bug#10400)
09450bae
PE
2908 * fileio.c (auto_saving_dir_umask): New static var.
2909 (Fmake_directory_internal): Use it.
2910 (do_auto_save_make_dir): Set it, instead of invoking chmod after
2911 creating the directory. The old code temporarily assigns
2912 too-generous permissions to the directory.
2913 (do_auto_save_eh): Clear it.
b9110d6a 2914 (Fdo_auto_save): Catch all errors, not just file errors, so
09450bae
PE
2915 that the var is always cleared.
2916
6c1bd3f3
EZ
29172012-01-07 Eli Zaretskii <eliz@gnu.org>
2918
2919 * search.c (scan_buffer): Pass character positions to
2920 know_region_cache, not byte positions. (Bug#6540)
2921
069d2b50
L
29222012-01-07 LynX <_LynX@bk.ru> (tiny change)
2923
2924 * w32.c (sys_rename): Report EXDEV when rename of a directory
2925 fails because the target is on another logical disk. (Bug#10284)
2926
75bf0d33
DB
29272012-01-07 David Benjamin <davidben@mit.edu> (tiny change)
2928
2929 * xterm.c (x_embed_request_focus): New function.
2930
2931 * xterm.h: Add prototype.
2932
2933 * xfns.c (Fx_focus_frame): Use it for embedded frames (Bug#9977).
2934
1c6e5a32
GM
29352012-01-05 Glenn Morris <rgm@gnu.org>
2936
2937 * emacs.c (emacs_copyright): Update short copyright year to 2012.
2938
651e947e
EZ
29392012-01-01 Eli Zaretskii <eliz@gnu.org>
2940
2941 * gnutls.c (init_gnutls_functions): Load gnutls_check_version.
2942 Load gnutls_transport_set_lowat only if GnuTLS version is below
2943 2.11.1.
2944 (emacs_gnutls_handshake): Call gnutls_transport_set_lowat only for
2945 GnuTLS versions below 2.11.1.
2946
3778cdd8
AL
29472011-12-31 Antoine Levitt <antoine.levitt@gmail.com>
2948
2949 * xdisp.c (syms_of_xdisp) <window-scroll-functions>: Add warning
2950 to the doc string advising against its use for altering the way
2951 windows are scrolled.
2952
0e5317f7
KH
29532011-12-28 Kenichi Handa <handa@m17n.org>
2954
2955 * coding.c (Fdefine_coding_system_internal): Make an utf-8 base
2956 coding-system ASCII compatible only when it does not produce BOM
2957 on encoding (Bug#10383).
2958
93d5ca1f
JD
29592011-12-26 Jan Djärv <jan.h.d@swipnet.se>
2960
2961 * xmenu.c (x_menu_wait_for_event): Use xg_select for Gtk3 so menus
2962 can scroll.
2963 (create_and_show_popup_menu): Always use menu_position_func for
2964 Gtk3 (Bug#10361).
2965
ca22b785
AS
29662011-12-24 Andreas Schwab <schwab@linux-m68k.org>
2967
2968 * callint.c (Fcall_interactively): Don't truncate prompt string.
2969
d048e1e6
EZ
29702011-12-23 Eli Zaretskii <eliz@gnu.org>
2971
2972 * xdisp.c (handle_invisible_prop): Handle correctly an invisible
2973 property that ends at ZV, so that the bidi iteration could be
3ba1a2ad 2974 resumed from there (after widening). (Bug#10360)
d048e1e6 2975
5ccaba1f
JD
29762011-12-22 Jan Djärv <jan.h.d@swipnet.se>
2977
2978 * nsfont.m (ns_spec_to_descriptor): Do not autorelease fdesc.
2979
204ee57f
JD
29802011-12-21 Jan Djärv <jan.h.d@swipnet.se>
2981
b81d40f0
JB
2982 * nsterm.m (x_free_frame_resources):
2983 Release f->output_data.ns->miniimage.
204ee57f
JD
2984 (ns_index_color): Fix indentation. Do not retain
2985 color_table->colors[i].
2986
2987 * nsmenu.m (ns_update_menubar): Call free_menubar_widget_value_tree
2988 before returning.
2989
2990 * nsfns.m (x_set_background_color): Assign return value from
2991 ns_index_color to face-background instead of NSColor*.
2992 (ns_implicitly_set_icon_type): Fix indentation.
2993 Change assignment in for loop to comparison.
2994
2995 * emacs.c (ns_pool): New variable.
2996 (main): Assign ns_pool.
2997 (Fkill_emacs): Call ns_release_autorelease_pool.
2998
2999 * nsfont.m (ns_spec_to_descriptor): Fix indentation,
3000 autorelease fdesc, release fdAttrs and tdict.
3001 (ns_get_covering_families): Release charset.
3002 (ns_findfonts): Release NSFontDescriptor created with new.
3003 (ns_uni_to_glyphs): Fix indentation.
3004 (setString): Release attrStr before assigning new value.
3005
c803b2b7
JD
30062011-12-18 Jan Djärv <jan.h.d@swipnet.se>
3007
678f4426
JD
3008 * nsmenu.m (NSMenuDidBeginTrackingNotification): Declare if OSX < 10.5
3009 and NS_IMPL_COCOA.
3010 (trackingNotification): Surround with ifdef NS_IMPL_COCOA.
3011 (syms_of_nsmenu): Set trackingMenu to 1 if not NS_IMPL_COCOA.
3012
cd394be1 30132011-12-18 David Reitter <reitter@cmu.edu>
678f4426 3014
5fecd5fc
JD
3015 * nsterm.m (ns_term_init): Subscribe for notifications
3016 NSMenuDidBeginTrackingNotification and NSMenuDidEndTrackingNotification
3017 to method trackingNotification in EmacsMenu.
3018
3019 * nsmenu.m (trackingMenu): New variable.
3771cb17 3020 (trackingNotification): New method (from Aquamacs).
5fecd5fc 3021 (menuNeedsUpdate): Expand comment and return if trackingMenu is 0,
3771cb17 3022 from Aquamacs (Bug#7030).
678f4426
JD
3023
30242011-12-18 Jan Djärv <jan.h.d@swipnet.se>
5fecd5fc 3025
c803b2b7
JD
3026 * nsselect.m (CUT_BUFFER_SUPPORT): Remove define.
3027 (symbol_to_nsstring): Fix indentation.
3028 (ns_symbol_to_pb): New function.
cae07000
SM
3029 (Fns_get_selection_internal): Rename from Fns_get_cut_buffer_internal.
3030 (Fns_rotate_cut_buffers_internal): Remove.
3031 (Fns_store_selection_internal): Rename from
c803b2b7
JD
3032 Fns_store_cut_buffer_internal.
3033 (ns_get_foreign_selection, Fx_own_selection_internal)
3034 (Fx_disown_selection_internal, Fx_selection_exists_p)
b81d40f0
JB
3035 (Fns_get_selection_internal, Fns_store_selection_internal):
3036 Use ns_symbol_to_pb and check if return value is nil.
3037 (syms_of_nsselect): Remove ifdef CUT_BUFFER_SUPPORT. Remove defsubr
3038 Sns_rotate_cut_buffers_internal. Sns_get_cut_buffer_internal
c803b2b7
JD
3039 renamed to Sns_get_selection_internal, Sns_store_cut_buffer_internal
3040 renamed to Sns_store_selection_internal.
3041 (ns_handle_selection_request): Move code to Fx_own_selection_internal
3042 and remove this function.
3043 (ns_handle_selection_clear): Remove, never used.
3044 (Fx_own_selection_internal): Move code from ns_handle_selection_request
3045 here.
3046
e1b01a3a
KB
30472011-12-17 Ken Brown <kbrown@cornell.edu>
3048
3049 * fileio.c (check_writable) [CYGWIN]: Return non-zero if UID or
3050 GID is unknown (Bug#10257).
3051
2adb6e85
PE
30522011-12-17 Paul Eggert <eggert@cs.ucla.edu>
3053
3054 * s/gnu-linux.h: Fix mark_memory typo (Bug#10286).
3055 (GC_MARK_SECONDARY_STACK): Omit removed 3rd arg to mark_memory,
3056 which caused a build failure on GNU/Linux IA-64. This problem was
3057 introduced by my 2011-10-07 patch.
3058
d1d7b339
JL
30592011-12-15 Juri Linkov <juri@jurta.org>
3060
3061 * image.c (imagemagick_error): New function. (Bug#10112)
3062 (imagemagick_load_image): Comment out `MagickSetResolution' call.
3063 Use `imagemagick_error' where ImageMagick functions return
3064 `MagickFalse'.
3065 (Fimagemagick_types): Add `Fnreverse' to return the list in the
3066 proper order.
3067
100d5755
KH
30682011-12-15 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
3069
3070 * xftfont.c (xftfont_draw): Use the font metrics of s->font to
3071 fill background (Bug#8992).
3072
454592a6
MR
30732011-12-13 Martin Rudalics <rudalics@gmx.at>
3074
3075 * window.c (Vwindow_combination_resize)
3076 (Vwindow_combination_limit): Use t instead of non-nil in
3077 doc-strings.
61d4b438
MR
3078 (Vrecenter_redisplay): Add first sentence of doc-string on
3079 separate line.
53524d93 3080 (Frecenter): Fix doc-string typo.
454592a6 3081
3633e3aa
KH
30822011-12-11 Kenichi Handa <handa@m17n.org>
3083
3084 * coding.c (Funencodable_char_position): Pay attention to the
3085 buffer text relocation (Bug#9389).
3086
7b9d523a 30872011-12-10 Jan Djärv <jan.h.d@swipnet.se>
61ccba97 3088
7b9d523a
JD
3089 * xterm.c (x_term_init): Move call to gdk_window_add_filter before
3090 gtk_init (Bug#10100).
3091
b73189c6
EZ
30922011-12-10 Eli Zaretskii <eliz@gnu.org>
3093
3094 * xdisp.c (RECORD_MAX_MIN_POS): Use IT->cmp_it.charpos only if
3095 IT->string is nil. (Bug#10263)
3096
f7dfe5d6
JD
30972011-12-10 Jan Djärv <jan.h.d@swipnet.se>
3098
83faebb4
JD
3099 * nsterm.h (x_free_frame_resources): Declare.
3100
f7dfe5d6
JD
3101 * nsfns.m (ns_get_defaults_value): New function (Bug#10103).
3102 (Fns_get_resource, x_get_string_resource): Call ns_get_defaults_value.
3103
3104 * nsterm.h (ns_get_defaults_value): Declare.
3105
3106 * nsterm.m (ns_default): Call ns_get_defaults_value.
3107
7cd4e72c
EZ
31082011-12-09 Eli Zaretskii <eliz@gnu.org>
3109
3110 * xdisp.c (try_scrolling): Don't set scroll_down_p if dy is zero.
3111 (Bug#10170)
3112
b34d7317
YM
31132011-12-09 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
3114
3115 * unexelf.c (unexec) [NS_IMPL_GNUSTEP]: Take account of the case
3116 that where the value of an _OBJC_* symbol points to is in the .bss
3117 section (Bug#10240).
3118
76470ad1
KH
31192011-12-08 Kazuhiro Ito <kzhr@d1.dion.ne.jp> (tiny change)
3120
3121 * coding.c (encode_coding_ccl): Check (charbuf < charbuf_end)
2fac8180 3122 after the loop to call ccl_driver at least once (Bug#8619).
76470ad1 3123
745fff94
KH
31242011-12-08 Kenichi Handa <handa@m17n.org>
3125
3126 * ftfont.c (get_adstyle_property): Fix previous change
3127 (Bug#10233).
3128
6e44397c
JB
31292011-12-07 Juanma Barranquero <lekktu@gmail.com>
3130
3131 * w32.c (init_environment): If no_site_lisp, remove site-lisp
3132 dirs from the default value of EMACSLOADPATH (bug#10208).
3133
7efa6272
GM
31342011-12-07 Glenn Morris <rgm@gnu.org>
3135
3136 * lread.c (init_lread): If no_site_lisp, exclude site-lisp/ in
3137 installation and source directories as well. (Bug#10208)
3138
f6fc4d87
CY
31392011-12-06 Chong Yidong <cyd@gnu.org>
3140
3141 * minibuf.c (Fread_from_minibuffer): Doc fix (Bug#10228).
3142
2bf26180
GM
31432011-12-06 Glenn Morris <rgm@gnu.org>
3144
3145 * process.c (start_process_unwind): Treat any pid <= 0, except -2,
3146 as an error, not just -1. (Bug#10217)
3147
3a6ad4f0
CY
31482011-12-05 Chong Yidong <cyd@gnu.org>
3149
3150 * keyboard.c (process_special_events): New function.
3151 (swallow_events, Finput_pending_p): Use it (Bug#10195).
3152
75a3b399
PE
31532011-12-05 Paul Eggert <eggert@cs.ucla.edu>
3154
3155 * coding.c (encode_designation_at_bol): Don't use uninitialized
3156 local variable (Bug#9318).
3157
c3c9e25e
KH
31582011-12-05 Kenichi Handa <handa@m17n.org>
3159
3160 * ftfont.c (get_adstyle_property): If the font is not BDF nor PCF,
3161 return Qnil (Bug#8046, Bug#10193).
3162
5eb05ea3
KH
31632011-12-05 Kenichi Handa <handa@m17n.org>
3164
3165 * coding.c (encode_designation_at_bol): New args charbuf_end and
3166 dst. Return the number of produced bytes. Callers changed.
a79703f5
KH
3167 (coding_set_source): Return how many bytes coding->source was
3168 relocated.
3169 (coding_set_destination): Return how many bytes
3170 coding->destination was relocated.
3171 (CODING_DECODE_CHAR, CODING_ENCODE_CHAR, CODING_CHAR_CHARSET)
cae07000 3172 (CODING_CHAR_CHARSET_P): Adjust for the avove changes.
5eb05ea3
KH
3173
31742011-12-05 Kazuhiro Ito <kzhr@d1.dion.ne.jp> (tiny change)
3175
3176 * coding.c (CODING_CHAR_CHARSET_P): New macro.
3177 (encode_coding_emacs_mule, encode_coding_iso_2022): Use the above
3178 macro (Bug#9318).
3179
31802011-12-05 Andreas Schwab <schwab@linux-m68k.org>
3181
3182 The following changes are to fix Bug#9318.
3183
a79703f5 3184 * coding.c (CODING_ENCODE_CHAR, CODING_CHAR_CHARSET): New macros.
5eb05ea3
KH
3185 (encode_coding_emacs_mule, ENCODE_ISO_CHARACTER)
3186 (encode_coding_iso_2022, encode_coding_sjis)
a79703f5 3187 (encode_coding_big5, encode_coding_charset): Use the above macros.
5eb05ea3 3188
7dbda6df
JB
31892011-12-05 Juanma Barranquero <lekktu@gmail.com>
3190
3191 * lisp.h (process_quit_flag): Fix external declaration.
3192
6d5eb5b0
SM
31932011-12-04 Stefan Monnier <monnier@iro.umontreal.ca>
3194
3195 Don't macro-inline non-performance-critical code.
3196 * eval.c (process_quit_flag): New function.
3197 * lisp.h (QUIT): Use it.
3198
a0c3fad0
JD
31992011-12-04 Jan Djärv <jan.h.d@swipnet.se>
3200
3201 * nsfns.m (get_geometry_from_preferences): New function.
3202 (Fx_create_frame): Call get_geometry_from_preferences (Bug#10103).
3203
6c07aac2
AS
32042011-12-04 Andreas Schwab <schwab@linux-m68k.org>
3205
3206 * emacs.c (Qkill_emacs): Define.
3207 (syms_of_emacs): Initialize it.
3208 * keyboard.c (interrupt_signal): Don't call Fkill_emacs here, set
3209 Qquit_flag to `kill-emacs' instead.
6d5eb5b0
SM
3210 (quit_throw_to_read_char): Add parameter `from_signal'.
3211 All callers changed. Call Fkill_emacs if requested and safe.
6c07aac2
AS
3212 * lisp.h (QUIT): Call Fkill_emacs if requested.
3213
c052ead4
JD
32142011-12-03 Jan Djärv <jan.h.d@swipnet.se>
3215
3216 * widget.c (update_wm_hints): Return if wmshell is null.
3217 (widget_update_wm_size_hints): New function.
3218
3219 * widget.h (widget_update_wm_size_hints): Declare.
3220
3221 * xterm.c (x_wm_set_size_hint): If USE_X_TOOLKIT, call
3222 widget_update_wm_size_hints (Bug#10104).
3223
9e49252b
EZ
32242011-12-03 Eli Zaretskii <eliz@gnu.org>
3225
3226 * xdisp.c (handle_invisible_prop): If the invisible text ends just
3227 before a newline, prepare the bidi iterator for consuming the
3228 newline, and keep the current paragraph direction. (Bug#10183)
e9a49426 3229 (redisplay_window): Don't let `margin' become negative. (Bug#10192)
9e49252b 3230
02b16839
JL
32312011-12-02 Juri Linkov <juri@jurta.org>
3232
3233 * search.c (Fword_search_regexp): New Lisp function created from
3234 `wordify'. Change type of arg `lax' from `int' to `Lisp_Object'.
3235 (Fword_search_backward, Fword_search_forward)
3236 (Fword_search_backward_lax, Fword_search_forward_lax):
3237 Use `Fword_search_regexp' instead of `wordify'. Doc fix.
3238 (syms_of_search): Define `Sword_search_regexp'. (Bug#10145)
3239
0068070e
SM
32402011-12-01 Stefan Monnier <monnier@iro.umontreal.ca>
3241
3242 * fileio.c (Finsert_file_contents): Move after-change-function call
3243 to before the "handled:" label, since all "goto handled" appear in
3244 cases where the *-change-functions have already been properly called
3245 (bug#10117).
3246
3360a3fc
AS
32472011-12-01 Andreas Schwab <schwab@linux-m68k.org>
3248
3249 * keyboard.c (interrupt_signal): Don't call kill-emacs when
3250 waiting for input. (Bug#10169)
3251
73d6c093
EZ
32522011-11-30 Eli Zaretskii <eliz@gnu.org>
3253
3254 * dispnew.c (adjust_glyph_matrix): Remove the assertion that
3255 verifies glyph row's hash code--we have just reallocated the
3256 glyphs, so their contents can be complete garbage. (Bug#10164)
3257
febe6bea
JB
32582011-11-30 Juanma Barranquero <lekktu@gmail.com>
3259
3260 * dispnew.c (adjust_glyph_matrix) [XASSERTS]: Add missing check.
3261
801a4313
EZ
32622011-11-30 Eli Zaretskii <eliz@gnu.org>
3263
3264 * dispnew.c (adjust_glyph_matrix) [XASSERTS]: Ensure ROW's
3265 attributes are tested _before_ calling verify_row_hash, to protect
3266 against GCC re-ordering of the tests. (Bug#10164)
3267
2b56b87e
JD
32682011-11-29 Jan Djärv <jan.h.d@swipnet.se>
3269
3270 * xterm.h (struct x_output): net_wm_state_hidden_seen is new.
3271
3272 * xterm.c (handle_one_xevent): Only set async_visible and friends
3273 if net_wm_state_hidden_seen is non-zero (Bug#10002)
7dbda6df 3274 (get_current_wm_state): Set net_wm_state_hidden_seen to 1 if
2b56b87e
JD
3275 _NET_WM_STATE_HIDDEN is in NET_WM_STATE.
3276
dbf31225
PE
32772011-11-28 Paul Eggert <eggert@cs.ucla.edu>
3278
3279 Remove GCPRO-related macros that exist only to avoid shadowing locals.
3280 * lisp.h (GCPRO1_VAR, GCPRO2_VAR, GCPRO3_VAR, GCPRO4_VAR, GCPRO5_VAR)
3281 (GCPRO6_VAR, UNGCPRO_VAR): Remove. See
3282 <http://lists.gnu.org/archive/html/emacs-diffs/2011-11/msg00265.html>.
3283 All uses changed to use GCPRO1 etc.
3284 (GCPRO1, GCPRO2, GCPRO3, GCPRO4, GCPRO5, GCPRO6, UNGCPRO):
3285 Revert to old implementation (i.e., before 2011-03-11).
3286
1305621b
YM
32872011-11-28 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
3288
3289 * dispnew.c (scrolling_window): Truncate overlaps in copy destination
3290 of scroll runs so as to avoid assigning disabled bogus rows and
3291 unnecessary graphics copy operations.
3292
8c9afb46
EZ
32932011-11-27 Eli Zaretskii <eliz@gnu.org>
3294
3295 * s/ms-w32.h (utimbuf) [_MSC_VER]: Don't define.
3296 (snprintf) [_MSC_VER]: Redirect to _snprintf.
3297 (strtoll) [_MSC_VER]: Redirect to _strtoi64.
3298 (malloc, free, realloc, calloc): Redirect to e_* only when
3299 compiling Emacs.
3300
3301 * lisp.h (GCTYPEBITS): Move before first use.
3302 (ALIGN_GCTYPEBITS) [_MSC_VER]: Define.
3303 (DECL_ALIGN) [_MSC_VER]: Use it, as MSVC doesn't like bit ops in
3304 this macro definition.
3305
3306 * s/ms-w32.h (tzname): Redirect to _tzname for all values of
3307 _MSC_VER.
3308
54e9e3bf
JD
33092011-11-27 Jan Djärv <jan.h.d@swipnet.se>
3310
6d5eb5b0
SM
3311 * gtkutil.c (xg_create_frame_widgets):
3312 Call gtk_window_set_has_resize_grip (FALSE) if that function is
54e9e3bf
JD
3313 present with Gtk+ 2.0.
3314
83aca1cb
PE
33152011-11-26 Paul Eggert <eggert@cs.ucla.edu>
3316
3317 * fileio.c (Finsert_file_contents): Undo previous change; see
3318 <http://lists.gnu.org/archive/html/emacs-diffs/2011-11/msg00265.html>.
3319
5b76caa4
PE
33202011-11-26 Paul Eggert <eggert@cs.ucla.edu>
3321
3322 Rename locals to avoid shadowing.
3323 * fileio.c (Finsert_file_contents):
3324 Rename inner 'gcpro1' to 'inner_gcpro1' to avoid shadowing.
3325 * process.c (wait_reading_process_output):
3326 Rename inner 'proc' to 'p' to avoid shadowing.
3327 Indent for consistency with usual Emacs style.
3328
8c535114
EZ
33292011-11-25 Eli Zaretskii <eliz@gnu.org>
3330
3331 * xdisp.c (redisplay_window): If cursor row is not fully visible
3332 after recentering, and scroll-conservatively is set to a large
3333 number, scroll window by a few more lines to make the cursor fully
3334 visible and out of scroll-margin. (Bug#10105)
91b4a718
EZ
3335 (start_display): Don't move to the next line if the display should
3336 start at a newline that is part of a display vector or an overlay
3337 string. (Bug#10119)
8c535114 3338
fa4fdb5c
JL
33392011-11-24 Juri Linkov <juri@jurta.org>
3340
3341 * image.c (imagemagick_load_image): Move `MagickSetResolution' down
3342 after the `MagickPingImage' call. (Bug#10112)
3343
90ec88df
CY
33442011-11-23 Chong Yidong <cyd@gnu.org>
3345
3346 * window.c (Fcoordinates_in_window_p): Accept only live windows.
3347
56e2e794
MR
33482011-11-23 Martin Rudalics <rudalics@gmx.at>
3349
3350 * buffer.c (Fkill_buffer): Run replace_buffer_in_windows before
3351 making another buffer current. (Bug#10114)
3352
b6e64c41
GM
33532011-11-23 Glenn Morris <rgm@gnu.org>
3354
3355 * font.c (font_find_for_lface) [HAVE_NS]: Ignore case. (Bug#2526)
3356
6b21de18
CY
33572011-11-23 Chong Yidong <cyd@gnu.org>
3358
3359 * xdisp.c (compute_stop_pos): Check validity of end_charpos before
3360 using it (Bug#5984).
3361
b12cd789
EZ
33622011-11-22 Eli Zaretskii <eliz@gnu.org>
3363
3364 * dispnew.c (adjust_glyph_matrix): Don't verify hash code of mode-
3365 and header-lines, as they don't have one computed for them.
3366 (Bug#10098)
3367
3368 * .gdbinit (prow): Make displayed values more self-explaining.
3369 Add row's hash code.
3370
261b6fd4
LMI
33712011-11-21 Lars Magne Ingebrigtsen <larsi@gnus.org>
3372
3373 * process.c (wait_reading_process_output): Fix asynchrounous
3374 GnuTLS socket handling on some versions of the GnuTLS library.
16c1ad08 3375 (wait_reading_process_output): Add comment and URL.
261b6fd4 3376
e7cfd277
JD
33772011-11-21 Jan Djärv <jan.h.d@swipnet.se>
3378
3379 * xterm.c (x_clear_frame): Reinstate the XClearWindow call.
3380
a9b9b7f5
CY
33812011-11-21 Chong Yidong <cyd@gnu.org>
3382
3383 * window.c (Fnext_window, Fprevious_window): Doc fix.
3384
b0d15b4f
SM
33852011-11-20 Stefan Monnier <monnier@iro.umontreal.ca>
3386
3387 * window.c (get_phys_cursor_glyph): Fix Lisp_Object/int mixup.
3388
fe7a3057
JB
33892011-11-20 Juanma Barranquero <lekktu@gmail.com>
3390
3391 * nsfont.m (syms_of_nsfont) <ns-reg-to-script>: Fix typo.
3392
d2999b1a
MR
33932011-11-20 Martin Rudalics <rudalics@gmx.at>
3394
3395 * window.c (Fset_window_combination_limit): Rename argument
3396 STATUS to LIMIT.
3397 (Vwindow_combination_limit): Remove "status" from doc-string.
3398
d5ff9cd0
AS
33992011-11-20 Andreas Schwab <schwab@linux-m68k.org>
3400
3401 * m/ibms390.h: Remove.
3402 * m/ibms390x.h: Don't include "ibms390.h".
3403
a5bb9bd3
SM
34042011-11-20 Stefan Monnier <monnier@iro.umontreal.ca>
3405
3406 * fileio.c (Finsert_file_contents): Add missing gcpro1 variable.
3407 Suggested by Dmitry Antipov <dmantipov@yandex.ru>.
3408
cd1181db
JB
34092011-11-20 Juanma Barranquero <lekktu@gmail.com>
3410
3411 * casetab.c (Fset_case_table):
3412 * charset.c (Fcharset_after): Fix typos.
3413
615a3b8d 34142011-11-20 Paul Eggert <eggert@cs.ucla.edu>
6a0bf43d 3415
17e845af
PE
3416 Standardize on VIRT_ADDR_VARIES behavior (Bug#10042).
3417 Otherwise, valgrind does not work on some platforms.
3418 Problem reported by Andreas Schwab in
6a0bf43d
PE
3419 <http://lists.gnu.org/archive/html/emacs-devel/2011-11/msg00081.html>.
3420 * puresize.h (pure, PURE_P): Always behave as if VIRT_ADDR_VARIES
3421 is set, removing the need for VIRT_ADDRESS_VARIES.
3422 (PURE_P): Use a more-efficient implementation that needs just one
3423 comparison, not two: on x86-64 with GCC 4.6.2, this cut down the
3424 number of instructions from 6 (xorl, cmpq, jge, xorl, cmpq, setge)
3425 to 4 (xorl, subq, cmpq, setbe).
3426 * alloc.c (pure): Always extern now, since that's the
3427 VIRT_ADDR_VARIES behavior.
3428 (PURE_POINTER_P): Use a single comparison, not two, for
3429 consistency with the new puresize.h.
3430 * lisp.h (PNTR_COMPARISON_TYPE): Remove; no longer needed.
3431 * m/ibms390.h, m/intel386.h, m/template.h, s/cygwin.h, s/hpux10-20.h:
3432 Remove VIRT_ADDR_VARIES no longer needed.
3433
f8fe6f96
EZ
34342011-11-19 Eli Zaretskii <eliz@gnu.org>
3435
3436 * xdisp.c (x_write_glyphs, draw_phys_cursor_glyph)
3437 (erase_phys_cursor, update_window_cursor, show_mouse_face)
3438 (cursor_in_mouse_face_p): If the cursor position is out of bounds,
3439 behave as if the cursor position were at the window margin.
3440
3441 * window.c (get_phys_cursor_glyph): If the window is hscrolled,
3442 and the cursor position is out of bounds, behave as if the cursor
3443 position were at the window margin. (Bug#10075)
3444
df05a53c
CY
34452011-11-18 Chong Yidong <cyd@gnu.org>
3446
3447 * window.c (Fwindow_combination_limit): Make first argument
3448 non-optional, since it is meaningless for live windows like the
3449 selected window.
61ccba97 3450
2071918e
DA
34512011-11-18 Dmitry Antipov <dmantipov@yandex.ru>
3452
3453 * keymap.c (Fwhere_is_internal): Add missing RETURN_UNGCPROs.
3454
b50a28de
SM
34552011-11-18 Stefan Monnier <monnier@iro.umontreal.ca>
3456
3457 * intervals.c: Fix grafting over the whole buffer (bug#10071).
3458 (graft_intervals_into_buffer): Simplify.
3459
015137db
EZ
34602011-11-18 Eli Zaretskii <eliz@gnu.org>
3461
3462 * dispnew.c (swap_glyph_pointers): Swap the used[] arrays and the
3463 hash values of the two rows.
3464 (copy_row_except_pointers): Preserve the used[] arrays and the
3465 hash values of the two rows. (Bug#10035)
68c95424 3466 (add_row_entry): Add xassert to verify that ROW's hash code is valid.
015137db
EZ
3467
3468 * xdisp.c (row_hash): New function, body extracted from
3469 compute_line_metrics.
3470 (compute_line_metrics): Call row_hash, instead of computing the
3471 hash code inline.
3472
3473 * dispnew.c (verify_row_hash): Call row_hash for computing the
3474 hash code of a row, instead of duplicating code from xdisp.c.
3475
3476 * dispextern.h (row_hash): Add prototype.
3477
a2addb04
TH
34782011-11-18 Tassilo Horn <tassilo@member.fsf.org>
3479
3480 * frame.c (delete_frame): Don't delete the terminal when the last
3481 X frame is closed if emacs is built with GTK toolkit.
3482
df85d315
JB
34832011-11-17 Juanma Barranquero <lekktu@gmail.com>
3484
3485 * window.c (syms_of_window) <window-combination-resize>: Fix typo.
3486
a0c2d0ae
MR
34872011-11-17 Martin Rudalics <rudalics@gmx.at>
3488
3489 * window.c (Vwindow_splits): Rename to
3490 Vwindow_combination_resize. Suggested by Juri Linkov.
3491 (Fsplit_window_internal): Use Vwindow_combination_resize instead
3492 of Vwindow_splits.
3493
58179cce
JB
34942011-11-16 Juanma Barranquero <lekktu@gmail.com>
3495
7877f373
JB
3496 * nsfns.m (Fns_font_name):
3497 * window.c (syms_of_window) <window-combination-limit>: Fix typos.
58179cce 3498
b6f67890
MR
34992011-11-16 Martin Rudalics <rudalics@gmx.at>
3500
3501 * window.h (window): Rename slot "nest" to "combination_limit".
3502 * window.c (Fwindow_nest): Rename to Fwindow_combination_limit.
3503 (Fset_window_nest): Rename to Fset_window_combination_limit.
3504 (Vwindow_nest): Rename to Vwindow_combination_limit.
3505 (recombine_windows, make_parent_window, make_window)
3506 (Fsplit_window_internal, saved_window)
3507 (Fset_window_configuration, save_window_save): Rename all
3508 occurrences of window_nest to window_combination_limit.
3509
c7015153
JB
35102011-11-15 Juanma Barranquero <lekktu@gmail.com>
3511
3512 * image.c (imagemagick_load_image): Fix typo.
3513
322ad6ec
EZ
35142011-11-14 Eli Zaretskii <eliz@gnu.org>
3515
3516 * xdisp.c (display_line): Move the call to
3517 highlight_trailing_whitespace before the call to
3518 compute_line_metrics, since the latter needs to see the final
6d5eb5b0
SM
3519 faces of all the glyphs to compute ROW's hash value.
3520 Fixes assertion violations in row_equal_p. (Bug#10035)
322ad6ec 3521
f067b8ec
JB
35222011-11-14 Juanma Barranquero <lekktu@gmail.com>
3523
3524 * w32proc.c (reader_thread): Don't check pending input if cp->fd < 0,
3525 just return (bug#10044).
3526
1e5b2111
EZ
35272011-11-12 Eli Zaretskii <eliz@gnu.org>
3528
7ef3cbd5
EZ
3529 * makefile.w32-in (HEAPSIZE): New variable, allows to build temacs
3530 with user-defined heap size. Bump the default size of the temacs
3531 heap to 27MB, to avoid memory warning when running temacs.
3532 ($(TEMACS)): Use HEAPSIZE instead of a hardcoded value.
3533
1e5b2111
EZ
3534 * dispnew.c (scrolling_window): Fix incorrect indices in accessing
3535 current_matrix and desired_matrix. (Bug#9990)
7a7270dd
EZ
3536 (verify_row_hash) [XASSERTS]: New function.
3537 (adjust_glyph_matrix, row_equal_p): Use it in xassert to verify
3538 that the hash value of glyph rows is correct.
1e5b2111 3539
89d61221
MR
35402011-11-12 Martin Rudalics <rudalics@gmx.at>
3541
3542 * window.h (window): Remove splits slot.
3543 * window.c (Fwindow_splits, Fset_window_splits): Remove.
3544 (Fdelete_other_windows_internal, make_parent_window)
3545 (make_window, Fsplit_window_internal, Fdelete_window_internal)
3546 (Fset_window_configuration, save_window_save): Don't deal with
3547 split status of windows.
3548 (saved_window): Remove splits slot.
3549 (Vwindow_splits): Rewrite doc-string.
3550
97f18cc8
JD
35512011-11-11 Jan Djärv <jan.h.d@swipnet.se>
3552
3553 * xfns.c (unwind_create_frame):
3554 * nsfns.m (unwind_create_frame):
3555 * w32fns.c (unwind_create_frame): Use Fmemq to check if frame is in
3556 Vframe_list (Bug#9999).
3557
22a648b4
DA
35582011-11-11 Dmitry Antipov <dmantipov@yandex.ru>
3559
0b381c7e 3560 * xdisp.c (syms_of_xdisp): Remove duplicated definition of Qtext.
22a648b4 3561
659afede
KH
35622011-11-11 Kenichi Handa <handa@m17n.org>
3563
3564 * callproc.c (Fcall_process): Set the member dst_multibyte of
3565 process_coding.
3566
9ac0394b
KH
35672011-11-11 Johan Bockgård <bojohan@gnu.org>
3568
3569 * xdisp.c (fill_composite_glyph_string): Always set s->face, to
3570 avoid a crash (bug#9496).
3571
2fbdc249
CY
35722011-11-09 Chong Yidong <cyd@gnu.org>
3573
3574 * window.c (Fwindow_inside_edges, Fwindow_inside_pixel_edges)
3575 (Fwindow_inside_absolute_pixel_edges): Only allow live windows.
3576
ac6b1f81
PE
35772011-11-08 Paul Eggert <eggert@cs.ucla.edu>
3578
3579 * s/gnu.h (GC_MARK_STACK): Define to GC_MAKE_GCPROS_NOOPS (Bug#9926).
3580
09db192c
PE
35812011-11-08 Paul Eggert <eggert@cs.ucla.edu>
3582
3583 Avoid some portability problems by eschewing 'extern inline' functions.
3584 The trivial performance wins aren't worth the portability hassles; see
3585 <http://lists.gnu.org/archive/html/emacs-devel/2011-11/msg00084.html>
3586 et seq.
3587 * dispextern.h (window_box, window_box_height, window_text_bottom_y)
3588 (window_box_width, window_box_left, window_box_left_offset)
3589 (window_box_right, window_box_right_offset): Undo previous change,
3590 by removing the "extern"s.
3591 * intervals.c (adjust_intervals_for_insertion)
3592 (adjust_intervals_for_deletion): Undo previous change,
3593 making these static again.
3594 (offset_intervals, temp_set_point_both, temp_set_point)
3595 (copy_intervals_to_string): No longer inline.
3596 * xdisp.c (window_text_bottom_y, window_box_width)
3597 (window_box_height, window_box_left_offset)
3598 (window_box_right_offset, window_box_left, window_box_right)
3599 (window_box): No longer inline.
3600
105216ed
CY
36012011-11-08 Chong Yidong <cyd@gnu.org>
3602
3603 * window.c (Fwindow_left_column, Fwindow_top_line): Doc fix.
6d5eb5b0
SM
3604 (Fwindow_body_height, Fwindow_body_width): Move from Lisp.
3605 Signal an error if not a live window.
105216ed
CY
3606 (Fwindow_total_width, Fwindow_total_height): Move from Lisp.
3607 (Fwindow_total_size, Fwindow_body_size): Move to Lisp.
3608
ae9e237f
JB
36092011-11-07 Juanma Barranquero <lekktu@gmail.com>
3610
3611 * lisp.h (syms_of_abbrev): Remove declaration.
3612 Reported by CHENG Gao <chenggao@royau.me>.
3613
c7aa8333
EZ
36142011-11-07 Eli Zaretskii <eliz@gnu.org>
3615
3616 * w32.c (check_windows_init_file): Don't look for term/w32-win.el
3617 if Vpurify_flag is non-nil. Fixes a crash when running w32 build
3618 of temacs in GUI mode.
3619
be7f5545
MR
36202011-11-07 Martin Rudalics <rudalics@gmx.at>
3621
3622 * window.h: Declare delete_all_child_windows instead of
3623 delete_all_subwindows.
3624 * window.c (Fwindow_nest, Fset_window_nest)
3625 (Fset_window_new_total, Fset_window_new_normal)
3626 (Fwindow_resize_apply): Don't use term subwindow in doc-strings.
3627 (delete_all_subwindows): Rename to delete_all_child_windows.
3628 (Fdelete_other_windows_internal, Fset_window_configuration):
3629 Call delete_all_child_windows instead of delete_all_subwindows.
3630 * frame.c (delete_frame): Call delete_all_child_windows instead
3631 of delete_all_subwindows.
3632
ca78dc43
PE
36332011-11-07 Paul Eggert <eggert@cs.ucla.edu>
3634
3635 * alloc.c (DEADP): New macro, for porting to GNU/Hurd (Bug#9926).
3636 This is also needed for porting to any host where GC_MARK_STACK is
3637 not GC_MAKE_GCPROS_NOOPS.
3638 (which_symbols): Use it.
3639
a0241d01
KH
36402011-11-07 Kenichi Handa <handa@m17n.org>
3641
3642 * coding.c (coding_set_destination): Check coding->src_pos only
3643 when coding->src_object is a buffer (bug#9910).
3644
3645 * process.c (send_process): Set the member src_multibyte of coding
3646 to 0 (bug#9911) when sending a unibyte text.
3647
3648 * callproc.c (Fcall_process): Set the member src_multibyte of
3649 process_coding to 0 (bug#9912).
3650
a64bfdfa 36512011-11-06 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
ba24cea2
YM
3652
3653 * xmenu.c (cleanup_widget_value_tree): New function.
3654 (xmenu_show, xdialog_show): Use it in record_unwind_protect instead of
3655 calling free_menubar_widget_value_tree directly (Bug#9830).
3656
cb41b32a
PE
36572011-11-06 Paul Eggert <eggert@cs.ucla.edu>
3658
3659 Fix some portability problems with 'inline'.
3660 * dispextern.h (window_box, window_box_height, window_text_bottom_y)
3661 (window_box_width, window_box_left, window_box_left_offset)
3662 (window_box_right, window_box_right_offset): Declare extern.
3663 Otherwise, these inline functions do not conform to C99 and
3664 are miscompiled by Microsoft compilers. Reported by Eli Zaretskii in
3665 <http://lists.gnu.org/archive/html/emacs-devel/2011-11/msg00084.html>.
3666 * intervals.c (adjust_intervals_for_insertion)
3667 (adjust_intervals_for_deletion): Now extern, because otherwise the
3668 extern inline functions 'offset_intervals' couldn't refer to it.
3669 (static_offset_intervals): Remove.
3670 (offset_intervals): Rewrite using the old contents of
3671 static_offset_intervals. The old version didn't conform to C99
3672 because an extern inline function contained a reference to an
3673 identifier with static linkage.
3674
b7041366
AS
36752011-11-06 Andreas Schwab <schwab@linux-m68k.org>
3676
3677 * keyboard.c (interrupt_signal): Don't call kill-emacs while in
3678 GC.
3679
88a37c4d
EZ
36802011-11-06 Eli Zaretskii <eliz@gnu.org>
3681
3682 * xdisp.c (init_iterator, reseat_to_string): Don't set the
3683 iterator's bidi_p flag if Vpurify_flag is non-nil. (Bug#9963)
3684 (Fcurrent_bidi_paragraph_direction): If Vpurify_flag is non-nil,
3685 return Qleft_to_right.
3686
49745b39
CY
36872011-11-06 Chong Yidong <cyd@gnu.org>
3688
3689 * window.c (Fwindow_live_p, Fwindow_frame, Fframe_root_window)
3690 (Fminibuffer_window, Fwindow_buffer, Fwindow_splits)
3691 (Fset_window_splits, Fwindow_nest, Fset_window_nest)
3692 (Fwindow_use_time, Fwindow_total_size, Fwindow_normal_size)
3693 (Fwindow_new_normal, Fwindow_left_column, Fwindow_top_line)
3694 (Fwindow_margins, Fwindow_fringes, Fwindow_scroll_bars)
3695 (Fwindow_vscroll): Doc fix.
3696 (Fwindow_top_child, Fwindow_left_child): Eliminate a nil default
3697 argument, since it makes no sense to pass a live window and for
3698 consistency with window-child.
3699
1f05cd82
CS
37002011-11-05 Christoph Scholtes <cschol2112@googlemail.com>
3701
3702 * makefile.w32-in ($(TEMACS), (gl-stamp)): Use $(THISDIR) to
3703 support MSVC.
3704
22610910
JR
37052011-11-05 Jason Rumney <jasonr@gnu.org>
3706
3707 * w32font.c (font_matches_spec): Filter out non-Japanese kana fonts.
3708 (add_font_entity_to_list): Filter out non-Japanese Shift-JIS
3709 fonts (Bug#6029).
3710 (add_font_entity_to_list): Fix logic errors in mixed boolean and
3711 bitwise arithmetic preventing use of unicode-sip and non-truetype
3712 opentype fonts.
3713
a06776b2
EZ
37142011-11-05 Eli Zaretskii <eliz@gnu.org>
3715
3ad924ba
EZ
3716 * s/ms-w32.h (fstat, stat, utime): Move redirections to
3717 "emacs"-only part.
3718
a06776b2
EZ
3719 * w32fns.c (x_create_tip_frame, Fx_create_frame): Rearrange
3720 initialization code to keep similarity to xfns.c after changes
3721 from 2011-11-05.
3722
c9e7db78
JD
37232011-11-05 Jan Djärv <jan.h.d@swipnet.se>
3724
a97f8f3f
JD
3725 * nsfns.m: Declare image_cache_refcount if GLYPH_DEBUG.
3726 (unwind_create_frame): New function (Bug#9943).
3727 (Fx_create_frame): Restructure code to be more similar to the one in
3728 xfns.c. Call record_unwind_protect with unwind_create_frame (Bug#9943).
3729 Initialize image_cache_refcount if GLYPH_DEBUG (Bug#9943).
3730 Move terminal->reference_count++ just before making the frame official
3731 (Bug#9943).
3732
3733 * nsterm.m (x_free_frame_resources): New function.
3734 (x_destroy_window): Move code to x_free_frame_resources.
3735
c9e7db78 3736 * xfns.c (unwind_create_frame): Fix comment.
6d5eb5b0
SM
3737 (Fx_create_frame, x_create_tip_frame):
3738 Move terminal->reference_count++ just before making the frame
75f1671a 3739 official. Move initialization of image_cache_refcount and
c9e7db78
JD
3740 dpyinfo_refcount before calling init_frame_faces (Bug#9943).
3741
a6fc3b5c
EZ
37422011-11-05 Eli Zaretskii <eliz@gnu.org>
3743
3744 Support MSVC build with newer versions of Visual Studio.
3745 * makefile.w32-in (TAGS-gmake): Don't use $(patsubst ...), as
3746 Nmake barfs on that. Use $(OBJ*_c) variables instead, defined on
3747 nt/gmake.defs.
3748
3749 * lisp.h (ENUM_BF): New macro, for enumerated types in bitfields,
3750 which are not supported by MSVC.
3751 (Lisp_Symbol, Lisp_Misc_Any, Lisp_Marker, Lisp_Misc_Overlay)
3752 (Lisp_Save_Value, Lisp_Free): Use ENUM_BF for enumerated types in
3753 bitfields.
3754 (Lisp_Object) [USE_LISP_UNION_TYPE]: Use ENUM_BF for enumerated
3755 types in bitfields.
3756 (DEFUN) [_MSC_VER]: Define in a different way for MSVC.
3757
3758 * w32fns.c [_MSC_VER]: DECLARE_HANDLE for any MSVC version.
3759
58179cce 37602011-11-05 Fabrice Popineau <fabrice.popineau@supelec.fr> (tiny change)
a6fc3b5c
EZ
3761
3762 Support MSVC build with newer versions of Visual Studio.
3763 * w32.c: Don't include w32api.h for MSVC.
3764 (init_environment) [_MSC_VER]: Call sys_access, not _access.
3765
3766 * s/ms-w32.h <sigset_t, ssize_t> [_MSC_VER]: Typedefs for MSVC.
3767 [_MSC_VER]: Include sys/timeb.h, sys/stat.h, and signal.h.
3768 (fstat, stat, utime) [_MSC_VER]: Redirect to their sys_* cousins.
3769 (malloc, free, realloc, calloc) [_MSC_VER]: Always redirect to the
3770 e_* cousins.
3771 (alloca) [_MSC_VER]: Define to _alloca.
3772
3773 * lisp.h (DECL_ALIGN) [_MSC_VER]: Define for MSVC.
3774
3775 * regex.c <re_char> [_MSC_VER]: A separate definition for MSVC.
3776
a58c13ed
EZ
37772011-11-04 Eli Zaretskii <eliz@gnu.org>
3778
3779 * xdisp.c (note_mouse_highlight): If either of
3780 previous/next-single-property-change returns nil, treat that as
3781 the beginning or the end of the buffer. (Bug#9955)
3782
fe0b6370
JD
37832011-11-04 Jan Djärv <jan.h.d@swipnet.se>
3784
a58c13ed 3785 * gtkutil.c (xg_make_tool_item): Add callbacks if one of wimage or
fe0b6370
JD
3786 label is not null (Bug#9951).
3787 (xg_tool_item_stale_p): Handle the fact that wimage and/or wlbl
3788 may be NULL.
3789
89bd5ee1
EZ
37902011-11-04 Eli Zaretskii <eliz@gnu.org>
3791
3792 * window.c (Fwindow_body_size): Mention in the doc string that the
3793 return value is in frame's canonical units. (Bug#9949)
3794
84c3edb9
EZ
37952011-11-03 Eli Zaretskii <eliz@gnu.org>
3796
4e2fb5c7
EZ
3797 * xdisp.c (note_mouse_highlight): Initialize `area'. (Bug#9947)
3798
84c3edb9 3799 * w32fns.c (unwind_create_frame): If needed, free the glyph
3ab15fd6 3800 matrices of the partially constructed frame. (Bug#9943)
2a58bbc1 3801 * xfns.c (unwind_create_frame): Likewise.
84c3edb9 3802
bc17a887
EZ
38032011-11-01 Eli Zaretskii <eliz@gnu.org>
3804
3805 * xdisp.c (mouse_face_from_buffer_pos): Fix a typo in a comment.
3806 Don't stop backward scan on the continuation glyph, even though
3807 its CHARPOS is positive.
6d5eb5b0
SM
3808 (mouse_face_from_buffer_pos, note_mouse_highlight):
3809 Rename cover_string to disp_string.
bc17a887 3810
4ee88440
MR
38112011-11-01 Martin Rudalics <rudalics@gmx.at>
3812
3813 * window.c (temp_output_buffer_show): Don't use
3814 Vtemp_buffer_show_specifiers.
3815 (Vtemp_buffer_show_specifiers): Remove unused variable.
3816
c2ff3c02
EZ
38172011-10-30 Eli Zaretskii <eliz@gnu.org>
3818
3819 * xdisp.c (try_cursor_movement): Make sure ROW isn't decremented
3820 past the beginning of the current glyph matrix.
3821
58179cce 38222011-10-30 Adam Sjøgren <asjo@koldfront.dk> (tiny change)
6e56383b
JD
3823
3824 * xterm.c: Include X11/Xproto.h if HAVE_GTK3.
3825 (x_error_handler): Ignore BadMatch for X_SetInputFocus for
3826 HAVE_GTK3 (Bug#9869).
b77a6a7f 3827
3b574623
JD
3828 * gtkutil.c (xg_win_to_widget, xg_event_is_for_menubar): Initialize
3829 type to GDK_NOTHING so valgrind does not complain (Bug#9901).
3830
b77a6a7f
JD
3831 * xterm.h (x_display_info): Add Xatom_net_wm_state_hidden (Bug#9893).
3832
3833 * xterm.c: Declare x_handle_net_wm_state to return int.
3834 (handle_one_xevent): Check if we are iconified but don't have
3835 _NET_WM_STATE_HIDDEN. If do, treat as deiconify (Bug#9893).
3836 (get_current_wm_state): Return non-zero if not hidden,
3837 check for _NET_WM_STATE_HIDDEN (Bug#9893).
3838 (do_ewmh_fullscreen): Ignore return value from get_current_wm_state.
3839 (x_handle_net_wm_state): Return what get_current_wm_state returns.
3840 (x_term_init): Initialize dpyinfo->Xatom_net_wm_state_hidden.
3841
196e41e4
PE
38422011-10-29 Paul Eggert <eggert@cs.ucla.edu>
3843
3844 * alloc.c (which_symbols): Declare EXTERNALLY_VISIBLE,
3845 so that this new function doesn't get optimized away by a
3846 whole-program optimizer. Make the 2nd arg EMACS_INT, not int.
3847
021f2e1a
AS
38482011-10-29 Andreas Schwab <schwab@linux-m68k.org>
3849
3850 * frame.h (MOUSE_HL_INFO): Remove excess parens.
3851
8b058d44
EZ
38522011-10-29 Eli Zaretskii <eliz@gnu.org>
3853
3854 Fix the `xbytecode' command.
3855 * .gdbinit (xprintbytestr): New command.
b50a28de 3856 (xwhichsymbols): Rename from `which'; all callers changed.
8b058d44
EZ
3857 (xbytecode): Print the byte-code string as well.
3858
4452fb80
EZ
38592011-10-29 Kim Storm <storm@cua.dk>
3860
8b058d44
EZ
3861 * alloc.c (which_symbols): New function.
3862
21b72067
AS
38632011-10-29 Andreas Schwab <schwab@linux-m68k.org>
3864
3865 * minibuf.c (read_minibuf_noninteractive): Allow reading empty
3866 line. (Bug#9903)
3867
83ed7b5c
GM
38682011-10-29 Glenn Morris <rgm@gnu.org>
3869
3870 * process.c (wait_reading_process_output): Revert 2009-08-30 change.
3871 Not clear what it was for, and it causes various bugs. (Bug#9839)
3872
5a7a728b
EZ
38732011-10-28 Eli Zaretskii <eliz@gnu.org>
3874
3875 * xdisp.c (note_mouse_highlight): Initialize `part', to avoid a
3876 possible random value that matches one of those tested as
3877 condition to clear the mouse face.
3878
d3d0842f
CY
38792011-10-28 Chong Yidong <cyd@gnu.org>
3880
3881 * xdisp.c (note_mouse_highlight): Fix use of uninitialized var.
3882
31b39d13
DN
38832011-10-28 Dan Nicolaescu <dann@ics.uci.edu>
3884
3885 * window.c (make_window): Initialize phys_cursor_on_p.
3886
9aba6043
SM
38872011-10-28 Stefan Monnier <monnier@iro.umontreal.ca>
3888
3889 * lisp.h (struct Lisp_Symbol): Update comments.
3890
c20992f4
JB
38912011-10-28 Juanma Barranquero <lekktu@gmail.com>
3892
3893 * w32font.c (w32_load_unicows_or_gdi32): Add missing return.
3894
db4f02f2
EZ
38952011-10-28 Eli Zaretskii <eliz@gnu.org>
3896
3897 Fix Emacs on Windows 9X (bug#8562). Thanks to oslsachem
3898 <oslsachem@gmail.com> for helping to debug this.
3899
3900 * w32font.c (g_b_init_is_w9x, g_b_init_get_outline_metrics_w)
3901 (g_b_init_get_text_metrics_w, g_b_init_get_glyph_outline_w)
3902 (g_b_init_get_glyph_outline_w): New static variables.
3903 (GetOutlineTextMetricsW_Proc, GetTextMetricsW_Proc)
3904 (GetGlyphOutlineW_Proc): New typedefs.
3905 (w32_load_unicows_or_gdi32, get_outline_metrics_w)
9aba6043
SM
3906 (get_text_metrics_w, get_glyph_outline_w, globals_of_w32font):
3907 New functions.
3908 (w32font_open_internal, compute_metrics):
3909 Call get_outline_metrics_w, get_text_metrics_w, and get_glyph_outline_w
db4f02f2
EZ
3910 instead of calling the "wide" APIs directly.
3911
3912 * emacs.c (main) [HAVE_NTGUI]: Call globals_of_w32font.
3913
3914 * w32.h (syms_of_w32font): Add prototype.
3915
87e68db4
JB
39162011-10-27 Juanma Barranquero <lekktu@gmail.com>
3917
3918 * window.c (Fframe_root_window, Fframe_first_window, Fwindow_end)
3919 (Fframe_selected_window, Ftemp_output_buffer_show, Fnext_window)
3920 (Fdelete_window_internal, Fwindow_parameters): Fix typos in docstrings.
3921 (Fmove_to_window_line): Doc fix.
3922
435c1d67
CY
39232011-10-27 Chong Yidong <cyd@gnu.org>
3924
3925 * process.c (make_process): Set gnutls_state to NULL.
3926
3927 * gnutls.c (emacs_gnutls_deinit): Deinit the gnutls_state if it is
3928 non-NULL, regardless of GNUTLS_INITSTAGE.
3929 (Fgnutls_boot): Cleanups. Call emacs_gnutls_deinit if we signal
3930 an error. Set process slots as soon as we allocate them.
3931
3932 * gnutls.h (GNUTLS_LOG, GNUTLS_LOG2): Fix macros.
3933
9c6c6f49
CY
39342011-10-27 Chong Yidong <cyd@gnu.org>
3935
9aba6043
SM
3936 * gnutls.c (emacs_gnutls_deinit): New function.
3937 Deallocate credentials structures as well as calling gnutls_deinit.
9c6c6f49
CY
3938 (Fgnutls_deinit, Fgnutls_boot): Use it.
3939
3940 * process.c (make_process): Initialize GnuTLS credentials to NULL.
3941 (deactivate_process): Call emacs_gnutls_deinit.
3942
657d08d3
JB
39432011-10-27 Juanma Barranquero <lekktu@gmail.com>
3944
3945 * image.c (x_create_x_image_and_pixmap):
3946 * w32.c (sys_rename, w32_delayed_load):
3947 * w32font.c (fill_in_logfont):
3948 * w32reg.c (x_get_string_resource): Silence compiler warnings.
3949
5430d399
JB
39502011-10-26 Juanma Barranquero <lekktu@gmail.com>
3951
3952 * w32fns.c (w32_default_color_map): New function,
3953 extracted from Fw32_default_color_map.
a7ef684b 3954 (Fw32_default_color_map, Fx_open_connection): Use it. (Bug#9785)
5430d399 3955
fe0055fa
PE
39562011-10-25 Paul Eggert <eggert@cs.ucla.edu>
3957
3958 * dispextern.h (Fcontrolling_tty_p): New decl (Bug#6649 part 2).
3959
e6346438
SM
39602011-10-25 Stefan Monnier <monnier@iro.umontreal.ca>
3961
3962 * keyboard.c (test_undefined): New function (bug#9751).
3963 (read_key_sequence): Use it to detect when a key is bound to `undefined'.
3964
e112cc37
ET
39652011-10-25 Enami Tsugutomo <tsugutomo.enami@jp.sony.com>
3966
3967 * sysdep.c (init_sys_modes): Fix the check for the controlling
3968 terminal (Bug#6649).
3969
7b5d6677
EZ
39702011-10-20 Eli Zaretskii <eliz@gnu.org>
3971
3972 * dispextern.h (struct bidi_it): New member next_en_type.
3973
3974 * bidi.c (bidi_line_init): Initialize the next_en_type member.
3975 (bidi_resolve_explicit_1): When next_en_pos is valid for the
3976 current character, check also for next_en_type being WEAK_EN.
3977 (bidi_resolve_weak): Don't enter the expensive loop if the current
3978 position is before next_en_pos. Record the bidi type of the first
3979 non-ET, non-BN character we find, in addition to its position.
3980 (bidi_level_of_next_char): Invalidate next_en_type when
3981 next_en_pos is over-stepped.
3982
7da0b018
PE
39832011-10-20 Paul Eggert <eggert@cs.ucla.edu>
3984
3985 Time zone name fixes for non-ASCII locales (Bug#641, Bug#9794)
3986 * editfns.c: Rewrite current-time-zone so that it invokes
3987 the equivalent of (format-time-string "%Z") to get the time zone name.
3988 This fixes a bug when the time zone name contains characters that
3989 need converting from the system time locale to Emacs internal format.
3990 This fixes a shortcoming that I introduced in my 1999-10-19 patch:
3991 that patch fixed format-time-string to do the conversion, but
3992 I forgot to fix current-time-zone.
3993 (format_time_string): New function, containing most of
3994 what Fformat_time_string used to contain.
3995 (Fformat_time_string): Rewrite in terms of format_time_string.
3996 This doesn't change this function's behavior.
3997 (current-time-zone): Rewrite to use format_time_string.
3998 This fixes the bug reported by Michael Schierl in
3999 <http://lists.gnu.org/archive/html/emacs-devel/2007-06/msg00334.html>.
4000 Jason Rumney's 2007-06-07 change worked around this bug, but
4001 didn't fix it.
4002 * systime.h (tzname, timezone): Remove no-longer-used declarations.
4003
8547b010
EZ
40042011-10-19 Eli Zaretskii <eliz@gnu.org>
4005
4006 * xdisp.c (start_display): If the character at POS is displayed
4007 via a display vector, reset IT->current.dpvec_index to zero.
12b32963
EZ
4008 (try_window_reusing_current_matrix): If a line ends in a display
4009 vector or the next line starts in a display vector, continue
4010 redrawing the window even though the character position of
4011 start_row was reached.
8547b010
EZ
4012 (Bug#9771, part 2)
4013
4e948d15
CY
40142011-10-18 Chong Yidong <cyd@gnu.org>
4015
4016 * xdisp.c (get_next_display_element): Handle U+2010 and U+2011
4017 with nobreak-char-display too.
4018
4787455f
EZ
40192011-10-18 Eli Zaretskii <eliz@gnu.org>
4020
4021 Fix part 3 of bug#9771.
4022 * bidi.c (bidi_line_init): Initialize next_en_pos to zero, not -1.
4023 (bidi_resolve_neutral): Don't enter the expensive loop looking for
4024 non-neutral characters if the current character is a paragraph
4025 separator (a.k.a. Newline). This avoids running the same
4026 expensive loop twice, once when we consume the preceding newline
4027 and the other time when the line actually needs to be displayed.
4028 Avoid the loop when we see neutrals on the base embedding level
4029 following a character whose directionality is the same as the
4030 paragraph's. This avoids running the expensive loop when a line
4031 ends in a long sequence of neutrals, like control characters.
4032 Add assertion against STRONG_AL type. Slightly rearrange code
4033 that determines the type of a neutral given the first non-neutral
4034 that follows it.
4035 (bidi_level_of_next_char): Set next_en_pos to zero when
4036 invalidating its info.
4037
2c91f553
EZ
40382011-10-17 Eli Zaretskii <eliz@gnu.org>
4039
4040 * xdisp.c (push_display_prop): Determine whether to record string
4041 or buffer position by IT->string, not by IT->method. Allow
4042 GET_FROM_DISPLAY_VECTOR as IT->method on entry. (Bug#9771, part 4)
f2ff9e88
EZ
4043 (move_it_vertically_backward): Don't look for character position
4044 immediately after the newline when in a continuation line.
4045 (Bug#9771, part 1)
2c91f553 4046
c7b08b0d
MR
40472011-10-15 Martin Rudalics <rudalics@gmx.at>
4048
4049 * window.c (coordinates_in_window): Rewrite and delabelize
4050 vertical border check. (Bug#5357) (Bug#9618)
4051
6b02f655
SM
40522011-10-14 Stefan Monnier <monnier@iro.umontreal.ca>
4053
4054 * xterm.c (frame_highlight, frame_unhighlight): Ignore unexplained
4055 errors in XSetWindowBorder (bug#9310).
4056
81d40c92
DA
40572011-10-13 Dmitry Antipov <dmantipov@yandex.ru>
4058
4059 * editfns.c (Fset_time_zone_rule): Replace free with xfree to
4060 avoid crash when xmalloc overrun checking is enabled.
4061
d4172c3b
EZ
40622011-10-13 Eli Zaretskii <eliz@gnu.org>
4063
4064 * xdisp.c (Fcurrent_bidi_paragraph_direction): Initialize
4065 itb.paragraph_dir to NEUTRAL_DIR. Fixes an occasional incorrect
4066 cursor motion with <left> and <right> arrow keys.
4067
4068 * bidi.c (bidi_init_it): Don't initialize paragraph_dir here, as
4069 some callers set that themselves.
4070
b00eea75
EZ
40712011-10-12 Eli Zaretskii <eliz@gnu.org>
4072
4073 * xdisp.c (find_row_edges): Handle the case where ROW comes from a
4074 display string and the previous row comes from the same string and
4075 is empty. (Bug#9739) (Bug#9738)
4076
8fe012c4
SM
40772011-10-12 Stefan Monnier <monnier@iro.umontreal.ca>
4078
4079 * doc.c (get_doc_string): Encode file name (bug#9735).
4080
0074aef2
EZ
40812011-10-12 Eli Zaretskii <eliz@gnu.org>
4082
79beb178
EZ
4083 * bidi.c (bidi_level_of_next_char):
4084 * xdisp.c (get_visually_first_element): Remove old incorrect
4085 comments regarding the Unicode Line Separator character.
4086
0074aef2
EZ
4087 * bidi.c (bidi_init_it): Initialize paragraph_dir to NEUTRAL_DIR.
4088
6e4b3fbe
DA
40892011-10-12 Dmitry Antipov <dmantipov@yandex.ru>
4090
4091 * alloc.c (Fgc_status): Do not access beyond zombies array
4092 boundary if nzombies > MAX_ZOMBIES.
4093 * alloc.c (dump_zombies): Add missing format specifier.
4094
0324f3af
PE
40952011-10-12 Paul Eggert <eggert@cs.ucla.edu>
4096
b5525cac
PE
4097 * xdisp.c (set_cursor_from_row): Simplify conditionals,
4098 to pacify GCC 4.6.1 x86-64 with -O2 -Wstrict-overflow.
4099
0324f3af
PE
4100 * lread.c (read_escape): Allow hex escapes as large as ?\xfffffff.
4101 Some packages use them to denote characters with modifiers.
4102
e9b5f888
AS
41032011-10-11 Andreas Schwab <schwab@linux-m68k.org>
4104
4105 * lisp.h (GCPRO1_VAR, GCPRO2_VAR, GCPRO3_VAR, GCPRO4_VAR)
4106 (GCPRO5_VAR, GCPRO6_VAR, UNGCPRO_VAR): Add whitespace to avoid
4107 matching a pp-number. Rename parameter var to var1.
4108
127827c0
SM
41092011-10-11 Stefan Monnier <monnier@iro.umontreal.ca>
4110
4111 * minibuf.c (Finternal_complete_buffer): Fix last change (bug#9709).
4112
c8fd3bd0
GM
41132011-10-08 Glenn Morris <rgm@gnu.org>
4114
4115 * callint.c (Fcall_interactively): Give a more explicit error for the
4116 'c' case with a non-character input. (Bug#8479)
4117
352ec8ff
EZ
41182011-10-08 Eli Zaretskii <eliz@gnu.org>
4119
03669ccb
EZ
4120 * xdisp.c (hscroll_window_tree): Support hscroll in right-to-left
4121 lines.
7061c986
EZ
4122 (set_cursor_from_row): Fix cursor positioning in mixed L2R+R2L
4123 lines that are hscrolled on the left.
03669ccb 4124
352ec8ff
EZ
4125 * dispnew.c (buffer_posn_from_coords): Account for a possible
4126 presence of header-line. (Bug#4426)
4127
a66cfb1c
SM
41282011-10-07 Stefan Monnier <monnier@iro.umontreal.ca>
4129
6b02f655
SM
4130 * buffer.c (syms_of_buffer) <enable-multibyte-characters>:
4131 Don't advertise functionality which we discourage or doesn't work.
a66cfb1c 4132
7c5ee88e
PE
41332011-10-07 Paul Eggert <eggert@cs.ucla.edu>
4134
4135 * alloc.c (GC_LISP_OBJECT_ALIGNMENT): Use offsetof, not __alignof__
4136 or sizeof. __alignof__ gives the wrong answer on Fedora x86-64
4137 with GCC 4.6.1 when configured with CC='gcc -m32' --with-wide-int;
4138 this makes Emacs dump core during garbage collection on rare
4139 occasions. sizeof is obviously inferior to offsetof here, so
4140 stick with offsetof.
4141 (GC_POINTER_ALIGNMENT): New macro.
4142 (mark_memory): Omit 3rd (offset) arg; caller changed.
4143 Don't assume EMACS_INT alignment is the same as pointer alignment.
4144
df1bbe5b
SM
41452011-10-03 Stefan Monnier <monnier@iro.umontreal.ca>
4146
4147 * keyboard.c (read_key_sequence_remapped): New var.
4148 (read_key_sequence): Compute remapping in the right buffer.
4149 (command_loop_1): Use read_key_sequence's remapping directly.
4150
51553db6
SM
41512011-10-02 Stefan Monnier <monnier@iro.umontreal.ca>
4152
32c1fffd
SM
4153 * dired.c (file_name_completion): Don't expand file name.
4154 (Ffile_name_completion, Ffile_name_all_completions): Expand file name
4155 before checking file name handler.
4156
51553db6
SM
4157 * minibuf.c (Finternal_complete_buffer): Only show internal buffers if
4158 they've been requested explicitly (bug#9591).
4159
b6bd1599 41602011-10-01 Andreas Schwab <schwab@linux-m68k.org>
fa2ec41f
AS
4161
4162 * keymap.c (Fsingle_key_description): Use make_specified_string
4163 instead of build_string to build string from push_key_description.
4164 (Bug#5193)
4165
f701dc2a
PE
41662011-09-30 Paul Eggert <eggert@cs.ucla.edu>
4167
4222c55d
PE
4168 * buffer.h (struct buffer): Use time_t, not int, for a time stamp.
4169 This fixes a Y2038 bug on 64-bit hosts.
4170 * buffer.c (reset_buffer):
4171 * fileio.c (Fdo_auto_save, Fset_buffer_auto_saved)
4172 (Fclear_buffer_auto_save_failure):
4173 Use 0, not -1, to represent an unset failure time, since time_t
4174 might not be signed.
4175
f701dc2a
PE
4176 Remove dependency on glibc malloc internals.
4177 * alloc.c (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
4178 Move back here from lisp.h, but with their new implementations.
4179 (XMALLOC_BASE_ALIGNMENT, COMMON_MULTIPLE, XMALLOC_HEADER_ALIGNMENT)
4180 (XMALLOC_OVERRUN_SIZE_SIZE): Move these new lisp.h macros here.
4181 * charset.c (charset_table_init): New static var.
4182 (syms_of_charset): Use it instead of xmalloc. This removes a
4183 dependency on glibc malloc internals. See Eli Zaretskii's comment in
4184 <http://lists.gnu.org/archive/html/emacs-devel/2011-09/msg00815.html>.
4185 * lisp.h (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
4186 Move back to alloc.c.
4187 (XMALLOC_BASE_ALIGNMENT, COMMON_MULTIPLE, XMALLOC_HEADER_ALIGNMENT)
4188 (XMALLOC_OVERRUN_SIZE_SIZE): Move to alloc.c.
4189
9ceebf39
JD
41902011-09-30 Jan Djärv <jan.h.d@swipnet.se>
4191
4192 * nsterm.m (windowDidResize): Call x_set_window_size only when
4193 ns_in_resize is true. Otherwise set pixelwidth/height and
4194 call change_frame_size (Bug#9628).
4195
cb993c58
PE
41962011-09-30 Paul Eggert <eggert@cs.ucla.edu>
4197
3930c88b
PE
4198 Port --enable-checking=all to Fedora 14 x86-64.
4199 * charset.c (syms_of_charset): Also account for glibc malloc's
4200 internal overhead when calculating the initial malloc maximum.
4201
cb993c58
PE
4202 Port --enable-checking=all to Fedora 14 x86.
4203 * alloc.c (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
4204 Move to lisp.h.
4205 (xmalloc_put_size, xmalloc_get_size, overrun_check_malloc)
4206 (overrun_check_realloc, overrun_check_free):
4207 Use XMALLOC_OVERRUN_SIZE_SIZE, not sizeof (size_t).
4208 That way, xmalloc returns a properly-aligned pointer even if
4209 XMALLOC_OVERRUN_CHECK is defined. The old debugging code happened
4210 to align OK on typical 64-bit hosts, but not on Fedora 14 x86.
4211 * charset.c (syms_of_charset): Take XMALLOC_OVERRUN_CHECK_OVERHEAD
4212 into account when calculating the initial malloc maximum.
4213 * lisp.h (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
4214 Move here from alloc.c, so that charset.c can use it too.
4215 Properly align; the old code wasn't right for common 32-bit hosts
4216 when configured with --enable-checking=all.
4217 (XMALLOC_BASE_ALIGNMENT, COMMON_MULTIPLE, XMALLOC_HEADER_ALIGNMENT)
4218 (XMALLOC_OVERRUN_SIZE_SIZE): New macros.
4219
31bed486
EZ
42202011-09-29 Eli Zaretskii <eliz@gnu.org>
4221
04c70788 4222 * sysdep.c (snprintf) [!EOVERFLOW]: If EOVERFLOW is not defined,
31bed486
EZ
4223 use EDOM.
4224
fbcaa2f3
EZ
42252011-09-28 Eli Zaretskii <eliz@gnu.org>
4226
4227 * xdisp.c (compute_display_string_end): If there's no display
4228 string at CHARPOS, return -1.
4229
4230 * bidi.c (bidi_fetch_char): When compute_display_string_end
4231 returns a negative value, treat the character as a normal
4232 character not covered by a display string. (Bug#9624)
4233
a239d4e9
JB
42342011-09-28 Juanma Barranquero <lekktu@gmail.com>
4235
4236 * lread.c (Fread_from_string): Fix typo in docstring.
4237
88652fd5
EZ
42382011-09-27 Eli Zaretskii <eliz@gnu.org>
4239
4240 * xdisp.c (handle_invisible_prop): If invisible text ends on a
4241 newline, reseat the iterator instead of bidi-iterating there one
4242 character at a time. (Bug#9610)
32c1fffd
SM
4243 (BUFFER_POS_REACHED_P, move_it_in_display_line_to): Bail when past
4244 TO_CHARPOS if the bidi iterator is at base embedding level.
88652fd5 4245
ed497dd4
AS
42462011-09-27 Andreas Schwab <schwab@linux-m68k.org>
4247
4248 * lread.c (readevalloop): Use correct code for NBSP.
4249 (read1): Likewise. (Bug#9608)
4250
b2bf61aa
MA
42512011-09-25 Michael Albinus <michael.albinus@gmx.de>
4252
4253 * dbusbind.c (Fdbus_register_signal): When service is not
4254 registered, use nil in Vdbus_registered_objects_table. (Bug#9581)
4255
32bbb17c
GM
42562011-09-25 Glenn Morris <rgm@gnu.org>
4257
4258 * buffer.c (truncate-lines): Doc fix.
4259
94e0933e
CY
42602011-09-24 Chong Yidong <cyd@stupidchicken.com>
4261
4262 * window.c (Fwindow_prev_buffers, Fset_window_prev_buffers)
4263 (Fset_window_next_buffers): Doc fix.
4264
cddde921
GM
42652011-09-24 Glenn Morris <rgm@gnu.org>
4266
4267 * minibuf.c (read_minibuf): Disable line truncation. (Bug#5715)
4268
1260aef1
PE
42692011-09-24 Paul Eggert <eggert@cs.ucla.edu>
4270
25b4bfa0
PE
4271 Fix minor problems found by static checking.
4272 * xdisp.c (string_from_display_spec): Don't assume vecsize fits in int.
1260aef1
PE
4273 * indent.c (Fvertical_motion): Fix == vs = typo.
4274
e3cbd34b
EZ
42752011-09-24 Eli Zaretskii <eliz@gnu.org>
4276
a66cfb1c
SM
4277 * dispnew.c (syms_of_display) <redisplay-dont-pause>:
4278 Default value is now t. Doc fix.
6bf7006f 4279
e3cbd34b 4280 * indent.c (Fvertical_motion): Compute and apply the overshoot
32c1fffd 4281 logic when moving up, not only when moving down. Fix the
e3cbd34b 4282 confusing name and values of the it_overshoot_expected variable;
32c1fffd 4283 logic changes accordingly. (Bug#9254) (Bug#9549)
e3cbd34b
EZ
4284
4285 * xdisp.c (pos_visible_p): Produce correct pixel coordinates when
4286 CHARPOS is covered by a display string which includes newlines.
4287 (move_it_vertically_backward): Avoid inflooping when START_CHARPOS
4288 is covered by a display string with embedded newlines.
4289
a3de0cbd
MA
42902011-09-24 Michael Albinus <michael.albinus@gmx.de>
4291
4292 * dbusbind.c (Fdbus_register_signal): Add match rule to
4293 Vdbus_registered_objects_table. (Bug#9581)
a66cfb1c
SM
4294 (Fdbus_register_method, Vdbus_registered_objects_table):
4295 Fix docstring.
a3de0cbd 4296
b260039d
JM
42972011-09-24 Jim Meyering <meyering@redhat.com>
4298
32c1fffd 4299 do not ignore write error for any output size
b260039d
JM
4300 The previous change was incomplete.
4301 While it makes emacs --batch detect the vast majority of stdout
4302 write failures, errors were still ignored whenever the output size is
4303 k * (BUFSIZ+1) - 4. E.g., on a system with BUFSIZ of 4096,
4304 $ emacs --batch --eval '(print (format "%4093d" 0))' > /dev/full \
4305 && echo FAIL: ignored write error
4306 FAIL: ignored write error
4307 $ emacs --batch --eval '(print (format "%20481d" 0))' > /dev/full \
4308 && echo FAIL: ignored write error
4309 FAIL: ignored write error
4310 * emacs.c (Fkill_emacs): Also test ferror. (Bug#9574)
4311
8eca8a7c
AS
43122011-09-23 Andreas Schwab <schwab@linux-m68k.org>
4313
4314 * emacs.c (Fkill_emacs): In noninteractive mode exit
4315 non-successfully if a write error occurred on stdout. (Bug#9574)
4316
3341db62
EZ
43172011-09-21 Eli Zaretskii <eliz@gnu.org>
4318
4319 * xdisp.c (pop_it): Allow it->object that is a cons cell to pass
4320 the xassert test.
4321
4322 * dispextern.h (struct it): Update the comment documenting what
4323 can it->OBJECT be.
4324
8c203dbf
EZ
43252011-09-20 Eli Zaretskii <eliz@gnu.org>
4326
4327 * xdisp.c (set_cursor_from_row): If the row ends in a newline from
4328 a display string, extend search for cursor position to end of row.
4329 (find_row_edges): If the row ends in a newline from a display
4330 string, increment its MATRIX_ROW_END_CHARPOS by one. (Bug#9549)
4331 Handle the case of a display string with multiple newlines.
fd317ddf
EZ
4332 (Fcurrent_bidi_paragraph_direction): Fix search for previous
4333 non-empty line. Fixes confusing cursor motion with arrow keys at
4334 the beginning of a line that starts with whitespace.
8c203dbf 4335
a4824228
LMI
43362011-09-19 Lars Magne Ingebrigtsen <larsi@gnus.org>
4337
4338 * lread.c (Fread_from_string): Document what FINAL-STRING-INDEX is
4339 (bug#9493).
4340
33ed493b
CY
43412011-09-18 Chong Yidong <cyd@stupidchicken.com>
4342
4343 * xfns.c (Fx_create_frame): Handle the bitmapIcon resource as
4344 boolean (Bug#9154).
4345
56cd55c8
EZ
43462011-09-18 Eli Zaretskii <eliz@gnu.org>
4347
4348 * xdisp.c (display_line): Record maximum and minimum buffer
4349 positions even if no glyphs were produced (e.g., by a zero-width
4350 stretch). Fixes bug#9530 on a TTY. Under word-wrap, don't record
4351 buffer positions that will be removed from the glyph row because
4352 they don't fit.
c02dcedf
EZ
4353 (produce_stretch_glyph): Fix a bug in :align-to on a TTY when the
4354 column is beyond frame width: don't subtract 1 "pixel" when
4355 computing width of the stretch.
3e62b7e0
EZ
4356 (reseat_at_next_visible_line_start): Undo the change made on
4357 2011-09-17 that saved paragraph information and restored it after
4358 the call to `reseat'. (Bug#9545)
56cd55c8 4359
5ed99d36 43602011-09-18 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
3390454c
YM
4361
4362 * xdisp.c (expose_window): Save original value of phys_cursor_on_p
4363 and turn window cursor on if cleared (Bug#9415).
4364
5ed99d36 43652011-09-18 Andreas Schwab <schwab@linux-m68k.org>
edb7b4dc
AS
4366
4367 * search.c (boyer_moore): Take unibyte characters from pattern
4368 literally. (Bug#9458)
4369
9bade7b2
EZ
43702011-09-18 Eli Zaretskii <eliz@gnu.org>
4371
4372 * xdisp.c (reseat_at_next_visible_line_start): Fix last change.
4373
e5e9d610
PE
43742011-09-18 Paul Eggert <eggert@cs.ucla.edu>
4375
87e4427a
PE
4376 Fix minor problem found by static checking.
4377 * xdisp.c (reseat_at_next_visible_line_start): Mark locals as
4378 initialized, to pacify gcc -Wuninitialized.
4379
e5e9d610
PE
4380 * fileio.c: Report proper errno when syscall falls.
4381 (Finsert_file_contents): Save and restore errno,
4382 so that report_file_error outputs the correct diagnostic.
4383 (Fwrite_region) [CLASH_DETECTION]: Likewise.
4384
a1674f0b
EZ
43852011-09-18 Eli Zaretskii <eliz@gnu.org>
4386
4387 * .gdbinit (pgx): Fix references to fields of `struct glyph'.
4388
fbfb6dd4
EZ
43892011-09-17 Eli Zaretskii <eliz@gnu.org>
4390
4391 * xdisp.c (produce_stretch_glyph): Another fix for changes made on
4392 2011-08-30T17:32:44Z!eliz@gnu.org. (Bug#9530)
4393
bb187662
EZ
43942011-09-17 Eli Zaretskii <eliz@gnu.org>
4395
1137e8b8 4396 * xdisp.c (reseat_at_next_visible_line_start): Keep information
6b02f655 4397 about the current paragraph and restore it after the call to reseat.
1137e8b8
EZ
4398
4399 * bidi.c (MAX_PARAGRAPH_SEARCH): New macro.
4400 (bidi_find_paragraph_start): Search back for paragraph beginning
4401 at most MAX_PARAGRAPH_SEARCH lines; if not found, return BEGV_BYTE.
4402 (bidi_move_to_visually_next): Only trigger paragraph-related
4403 computations when the last character is a newline or at EOB, not
4404 just any NEUTRAL_B. (Bug#9470)
4405
bb187662
EZ
4406 * xdisp.c (set_cursor_from_row): Don't invoke special treatment of
4407 truncated lines if point is covered by a display string. (Bug#9524)
4408
2e621251
PE
44092011-09-16 Paul Eggert <eggert@cs.ucla.edu>
4410
4411 * xselect.c: Relax test for outgoing X longs (Bug#9498).
4412 (cons_to_x_long): New function.
4413 (lisp_data_to_selection_data): Use it. Correct the test for
4414 short-versus-long data; it was negated. Break out of vector
4415 loop, for efficiency, when a long datum is discovered.
4416
91a15bc6
SM
44172011-09-16 Stefan Monnier <monnier@iro.umontreal.ca>
4418
4419 * eval.c (Fquote): Document its non-consing behavior (bug#9482).
4420
b41c3a35
EZ
44212011-09-16 Eli Zaretskii <eliz@gnu.org>
4422
4423 * image.c (tiff_handler): Work around a bug in MinGW GCC 3.x (see
4424 GCC PR/17406) by declaring this function with external scope.
4425
7812ba2d
PE
44262011-09-15 Paul Eggert <eggert@cs.ucla.edu>
4427
4428 * editfns.c (Fformat): Fix bug in text-property fix (Bug#9514).
4429 Don't mishandle (length (format "%%")) and (format "%4000s%%" "").
4430
cf7edc2a
AS
44312011-09-15 Andreas Schwab <schwab@linux-m68k.org>
4432
4433 * editfns.c (Fformat): Correctly handle text properties on "%%".
4434
bd01620e
EZ
44352011-09-15 Eli Zaretskii <eliz@gnu.org>
4436
4437 * xterm.c (x_draw_composite_glyph_string_foreground):
4438 * w32term.c (x_draw_composite_glyph_string_foreground):
4439 * term.c (encode_terminal_code):
4440 * composite.c (composition_update_it, get_composition_id):
4441 * xdisp.c (get_next_display_element)
4442 (fill_composite_glyph_string): Add comments about special meaning
4443 of TAB characters in a composition.
4444
a02719a3
PE
44452011-09-15 Paul Eggert <eggert@cs.ucla.edu>
4446
4447 * editfns.c (Fformat): Fix off-by-1 bug for "%%b" (Bug#9514).
4c122725
PE
4448 This occurs when processing a multibyte format.
4449 Problem reported by Wolfgang Jenker.
a02719a3 4450
72589a3c
JB
44512011-09-15 Johan Bockgård <bojohan@gnu.org>
4452
4453 * xdisp.c (try_cursor_movement): Only check for exact match if
4454 cursor hpos found by set_cursor_from_row is valid. (Bug#9495)
4455
1c14176c
PE
44562011-09-14 Paul Eggert <eggert@cs.ucla.edu>
4457
4458 Remove unused external symbols.
4459 * dispextern.h (calc_pixel_width_or_height): Remove decl.
4460 * xdisp.c (calc_pixel_width_or_height): Now static.
4461 * doprnt.c (exprintf) [! (HAVE_X_WINDOWS && USE_X_TOOLKIT)]: Remove.
4462 * indent.c (check_display_width):
4463 * w32term.c: Fix comment to match code.
4464 * xterm.c, xterm.h (x_catching_errors): Remove.
4465
d2eea5b5
PE
44662011-09-14 Paul Eggert <eggert@cs.ucla.edu>
4467
4468 * xselect.c: Use signed conversions more consistently (Bug#9498).
4469 (selection_data_to_lisp_data): Assume incoming selection data are
4470 signed integers, not unsigned. This is to be consistent with
4471 outgoing selection data, which was modified to use signed integers
4472 in as part of the fix to Bug#9196 in response to Jan D.'s comment
4473 in <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=9196#32> that X11
4474 expects long, not unsigned long.
4475
46888499
EZ
44762011-09-14 Eli Zaretskii <eliz@gnu.org>
4477
4478 * xdisp.c (try_window_reusing_current_matrix): Fix incorrect
4479 computation of loop end. Reported by Johan Bockgård
4480 <bojohan@gnu.org>.
4481
ef8ef9fb
CY
44822011-09-13 Chong Yidong <cyd@stupidchicken.com>
4483
4484 * frame.c (Fother_visible_frames_p): Function deleted.
4485
fa819fed
EZ
44862011-09-12 Eli Zaretskii <eliz@gnu.org>
4487
4488 * indent.c (compute_motion): Process display vector front to back
4489 rather than the other way around. (Bug#2496)
4490
2ba8e008
SM
44912011-09-12 Stefan Monnier <monnier@iro.umontreal.ca>
4492
4493 * fileio.c (Finsert_file_contents): Don't assume beg_offset is 0.
4494
20f53c69
CY
44952011-09-11 Chong Yidong <cyd@stupidchicken.com>
4496
4497 * minibuf.c (Fread_from_minibuffer): Doc fix.
4498
d562d7a4
EZ
44992011-09-11 Eli Zaretskii <eliz@gnu.org>
4500
4501 * xdisp.c (produce_stretch_glyph): Fix a typo made in changes from
4502 2011-08-30T17:32:44Z!eliz@gnu.org. (Bug#9475)
4503
1c4d7f3d
LMI
45042011-09-11 Lars Magne Ingebrigtsen <larsi@gnus.org>
4505
4506 * fileio.c (Fvisited_file_modtime): Document `(-1 65535)' as a
4507 value for non-existent files.
4508
b885bf36
EZ
45092011-09-11 Eli Zaretskii <eliz@gnu.org>
4510
4511 * fileio.c (Finsert_file_contents): If the file cannot be opened,
4512 set its "size" to -1. This will set the modtime_size field of
4513 the corresponding buffer to -1, which is what
4514 verify-visited-file-modtime expects for files that do not exist.
4515 (Bug#9139)
4516
6612f0bf
PE
45172011-09-11 Paul Eggert <eggert@cs.ucla.edu>
4518
4519 * keymap.h (KEY_DESCRIPTION_SIZE, push_key_description): Move decls
4520 here ...
4521 * lisp.h: ... from here. push_key_description is no longer
4522 defined in keyboard.c, so its declaration should not be in
4523 lisp.h's "Defined in keyboard.c" section, and KEY_DESCRIPTION_SIZE
4524 logically belongs with push_key_description.
4525
dfb3f755
PE
45262011-09-10 Paul Eggert <eggert@cs.ucla.edu>
4527
4528 * buffer.h: Include <sys/types.h> instead of <time.h>.
4529 Otherwise, off_t wasn't defined on FreeBSD 9.0-BETA2 i386.
4530 Problem reported by Herbert J. Skuhra.
4531
3134906c
LMI
45322011-09-10 Lars Magne Ingebrigtsen <larsi@gnus.org>
4533
4534 * xml.c (parse_region): Make the parsing work for
4535 non-comment-starting XML files again (bug#9144).
4536
8d903f4e
AS
45372011-09-10 Andreas Schwab <schwab@linux-m68k.org>
4538
4539 * image.c (gif_load): Fix calculation of bottom and right corner.
4540 (Bug#9468)
4541
80ad64f4
EZ
45422011-09-10 Eli Zaretskii <eliz@gnu.org>
4543
4544 * xdisp.c (MAX_DISP_SCAN): Decrease to 250. Prevents sluggish
4545 redisplay in small windows.
4546
208a048d
EZ
45472011-09-09 Eli Zaretskii <eliz@gnu.org>
4548
4549 * frame.c (x_report_frame_params): Cast to avoid compiler warnings.
4550
9b1c252e
MR
45512011-09-08 Martin Rudalics <rudalics@gmx.at>
4552
4553 * window.c (Fset_window_prev_buffers, Fset_window_next_buffers):
4554 Operate on live windows only.
4555
2949f33b
JB
45562011-09-08 Juanma Barranquero <lekktu@gmail.com>
4557
4558 * emacs.c (my_heap_start): #ifdef to avoid warnings when unused.
4559
e08dcafd
EZ
45602011-09-07 Eli Zaretskii <eliz@gnu.org>
4561
4562 * xdisp.c (move_it_in_display_line_to): Call RESTORE_IT on ppos_it
4563 only under bidi iteration.
4564
115b96bd
JD
45652011-09-07 Jan Djärv <jan.h.d@swipnet.se>
4566
4567 * gtkutil.c (xg_make_tool_item): Insert comment about eventbox.
4568
c8199d0f
PE
45692011-09-06 Paul Eggert <eggert@cs.ucla.edu>
4570
4571 isnan: Fix porting problem to Solaris 10 with bundled gcc.
4572 Without this fix, the command to link temacs failed due to an
4573 undefined symbol __builtin_isnan. This is because
4574 /usr/include/iso/math_c99.h #defines isnan(x) to
4575 __builtin_isnan(x), but the bundled gcc, which identifies itself
4576 as gcc 3.4.3 (csl-sol210-3_4-branch+sol_rpath), does not have
4577 a __builtin_isnan.
4578 * floatfns.c (isnan): #undef, and then #define to a clone of
4579 what's in data.c.
4580 (Fisnan): Always define, since it's always available now.
4581 (syms_of_floatfns): Always define isnan at the Lisp level.
4582
e39b275c 45832011-09-06 Paul Eggert <eggert@cs.ucla.edu>
1c262cae
PE
4584
4585 * Makefile.in (gl-stamp): move-if-change now in build-aux (Bug#9169).
4586
b2db44d9 45872011-09-06 Paul Eggert <eggert@cs.ucla.edu>
728f8f0a 4588
f4af5137 4589 * fileio.c: Fix bugs with large file offsets (Bug#9428).
728f8f0a
PE
4590 The previous code assumed that file offsets (off_t values) fit in
4591 EMACS_INT variables, which is not true on typical 32-bit hosts.
4592 The code messed up by falsely reporting buffer overflow in cases
4593 such as (insert-file-contents "big" nil 1 2) into an empty buffer
4594 when "big" contains more than 2**29 bytes, even though this
4595 inserts just one byte and does not overflow the buffer.
4596 (Finsert_file_contents): Store file offsets as off_t
4597 values, not as EMACS_INT values. Check for overflow when
4598 converting between EMACS_INT and off_t. When checking for
4599 buffer overflow or for overlap, take the offsets into account.
4600 Don't use EMACS_INT for small values where int suffices.
4601 When checking for overlap, fix a typo: ZV was used where
4602 ZV_BYTE was intended.
4603 (Fwrite_region): Don't assume off_t fits into 'long'.
4604 * buffer.h (struct buffer.modtime_size): Now off_t, not EMACS_INT.
4605
ecfc0a49
MA
46062011-09-05 Michael Albinus <michael.albinus@gmx.de>
4607
4608 * dbusbind.c (xd_signature_cat): Rename from signature_cat.
4609
6511acf2 46102011-09-04 Paul Eggert <eggert@cs.ucla.edu>
61bfeeb7 4611
0999621a 4612 sprintf-related integer and memory overflow issues (Bug#9412).
62f19c19
PE
4613
4614 * doprnt.c (doprnt): Support printing ptrdiff_t and intmax_t values.
8666506e 4615 (esprintf, exprintf, evxprintf): New functions.
62f19c19 4616 * keyboard.c (command_loop_level): Now EMACS_INT, not int.
6b02f655 4617 (cmd_error): Kbd macro iterations count is now EMACS_INT, not int.
62f19c19
PE
4618 (modify_event_symbol): Do not assume that the length of
4619 name_alist_or_stem is safe to alloca and fits in int.
4620 (Fexecute_extended_command): Likewise for function name and binding.
4621 (Frecursion_depth): Wrap around reliably on integer overflow.
4622 * keymap.c (push_key_description): First arg is now EMACS_INT, not int,
4623 since some callers pass EMACS_INT values.
4624 (Fsingle_key_description): Don't crash if symbol name contains more
4625 than MAX_ALLOCA bytes.
4626 * minibuf.c (minibuf_level): Now EMACS_INT, not int.
4627 (get_minibuffer): Arg is now EMACS_INT, not int.
4628 * lisp.h (get_minibuffer, push_key_description): Reflect API changes.
8666506e 4629 (esprintf, exprintf, evxprintf): New decls.
62f19c19
PE
4630 * window.h (command_loop_level, minibuf_level): Reflect API changes.
4631
2be7d702
PE
4632 * dbusbind.c (signature_cat): New function.
4633 (xd_signature, Fdbus_register_signal):
2ea16b89
PE
4634 Do not overrun buffer; instead, report string overflow.
4635
9d1df220
PE
4636 * dispnew.c (add_window_display_history): Don't overrun buffer.
4637 Truncate instead; this is OK since it's just a log.
4638
33ef5c64
PE
4639 * editfns.c (Fcurrent_time_zone): Don't overrun buffer
4640 even if the time zone offset is outlandishly large.
4641 Don't mishandle offset == INT_MIN.
4642
66c6fdd5
PE
4643 * emacs.c (main) [NS_IMPL_COCOA]: Don't overrun buffer
4644 when creating daemon; the previous buffer-overflow check was incorrect.
4645
d749b01b
PE
4646 * eval.c (verror): Simplify by rewriting in terms of evxprintf,
4647 which has the guts of the old verror function.
4648
b5cd1905
PE
4649 * filelock.c (lock_file_1, lock_file): Don't blindly alloca long name;
4650 use SAFE_ALLOCA instead. Use esprintf to avoid int-overflow issues.
4651
6e1a67fb
PE
4652 * font.c: Include <float.h>, for DBL_MAX_10_EXP.
4653 (font_unparse_xlfd): Don't blindly alloca long strings.
c21721cc 4654 Don't assume XINT result fits in int, or that XFLOAT_DATA * 10
8666506e 4655 fits in int, when using sprintf. Use single snprintf to count
c21721cc
PE
4656 length of string rather than counting it via multiple sprintfs;
4657 that's simpler and more reliable.
c21721cc
PE
4658 (font_unparse_fcname): Use it to avoid sprintf buffer overrun.
4659 (generate_otf_features) [0 && HAVE_LIBOTF]: Use esprintf, not
4660 sprintf, in case result does not fit in int.
4661
c57b67fc
PE
4662 * fontset.c (num_auto_fontsets): Now printmax_t, not int.
4663 (fontset_from_font): Print it.
4664
8a401434
PE
4665 * frame.c (tty_frame_count): Now printmax_t, not int.
4666 (make_terminal_frame, set_term_frame_name): Print it.
4667 (x_report_frame_params): In X, window IDs are unsigned long,
4668 not signed long, so print them as unsigned.
4669 (validate_x_resource_name): Check for implausibly long names,
4670 and don't assume name length fits in 'int'.
4671 (x_get_resource_string): Don't blindly alloca invocation name;
4672 use SAFE_ALLOCA. Use esprintf, not sprintf, in case result does
4673 not fit in int.
4674
6e1a67fb
PE
4675 * gtkutil.c: Include <float.h>, for DBL_MAX_10_EXP.
4676 (xg_check_special_colors, xg_set_geometry):
84722b3d
PE
4677 Make sprintf buffers a bit bigger, to avoid potential buffer overrun.
4678
0df02bf3
PE
4679 * lread.c (dir_warning): Don't blindly alloca buffer; use SAFE_ALLOCA.
4680 Use esprintf, not sprintf, in case result does not fit in int.
4681
48e30793
PE
4682 * macros.c (executing_kbd_macro_iterations): Now EMACS_INT, not int.
4683 (Fend_kbd_macro): Don't mishandle MOST_NEGATIVE_FIXNUM by treating
4684 it as a large positive number.
4685 (Fexecute_kbd_macro): Don't assume repeat count fits in int.
4686 * macros.h (executing_kbd_macro_iterations): Now EMACS_INT, not int.
4687
a66ff6d8
PE
4688 * nsterm.m ((NSSize)windowWillResize): Use esprintf, not sprintf,
4689 in case result does not fit in int.
4690
aca216ff
PE
4691 * print.c (float_to_string): Detect width overflow more reliably.
4692 (print_object): Make sprintf buffer a bit bigger, to avoid potential
4693 buffer overrun. Don't assume list length fits in 'int'. Treat
4694 print length of 0 as 0, not as infinity; to be consistent with other
4695 uses of print length in this function. Don't overflow print length
4696 index. Don't assume hash table size fits in 'long', or that
4697 vectorlike size fits in 'unsigned long'.
4698
31c286f7
PE
4699 * process.c (make_process): Use printmax_t, not int, to format
4700 process-name gensyms.
4701
55e5faa1
PE
4702 * sysdep.c (snprintf) [! HAVE_SNPRINTF]: New function.
4703
80f2e268
PE
4704 * term.c (produce_glyphless_glyph): Make sprintf buffer a bit bigger
4705 to avoid potential buffer overrun.
4706
670741ab
PE
4707 * xfaces.c (x_update_menu_appearance): Don't overrun buffer
4708 if X resource line is longer than 512 bytes.
4709
b7163a50
PE
4710 * xfns.c (x_window): Make sprintf buffer a bit bigger
4711 to avoid potential buffer overrun.
4712
ae58ff1f
PE
4713 * xterm.c (x_io_error_quitter): Don't overrun sprintf buffer.
4714
c43c8a6a
PE
4715 * xterm.h (x_check_errors): Add ATTRIBUTE_FORMAT_PRINTF.
4716
3f8236f4
PE
47172011-09-04 Paul Eggert <eggert@cs.ucla.edu>
4718
53e9fe90 4719 Integer overflow fixes for scrolling, etc.
6511acf2
PE
4720 Without these, Emacs silently mishandles large integers sometimes.
4721 For example, "C-u 4294967297 M-x recenter" was treated as if
53e9fe90
PE
4722 it were "C-u 1 M-x recenter" on a typical 64-bit host.
4723
6511acf2
PE
4724 * xdisp.c (try_window_id): Check Emacs fixnum range before
4725 converting to 'int'.
806add1d 4726
6511acf2 4727 * window.c (window_scroll_line_based, Frecenter):
71f02bc5
PE
4728 Check that an Emacs fixnum is in range before assigning it to 'int'.
4729 (Frecenter, Fmove_to_window_line): Use EMACS_INT, not int, for
4730 values converted from Emacs fixnums.
4731 (Frecenter): Don't wrap around a line count if it is out of 'int'
4732 range; instead, treat it as an extreme value.
4733 (Fset_window_configuration, compare_window_configurations):
4734 Use ptrdiff_t, not int, for index that might exceed 2 GiB.
4735
6511acf2
PE
4736 * search.c (Freplace_match): Use ptrdiff_t, not int, for indexes
4737 that can exceed INT_MAX. Check that EMACS_INT value is in range
4738 before assigning it to the (possibly-narrower) index.
a0efffc8
PE
4739 (match_limit): Don't assume that a fixnum can fit in 'int'.
4740
6511acf2 4741 * print.c (print_object): Use ptrdiff_t, not int, for index that can
29ebea3b
PE
4742 exceed INT_MAX.
4743
6511acf2 4744 * indent.c (position_indentation): Now takes ptrdiff_t, not int.
3f8236f4
PE
4745 (Fvertical_motion): Don't wrap around LINES values that don't fit
4746 in 'int'. Instead, treat them as extreme values. This is good
4747 enough for windows, which can't have more than INT_MAX lines anyway.
4748
fcb901a7
LMI
47492011-09-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
4750
0f2f6b6d
LMI
4751 * Require libxml/parser.h to avoid compilation warning.
4752
fcb901a7
LMI
4753 * emacs.c (shut_down_emacs): Call xmlCleanupParser on shutdown.
4754
4755 * xml.c (parse_region): Don't call xmlCleanupParser after parsing,
4756 since this reportedly can destroy thread storage.
4757
6e20a0d4
CY
47582011-08-30 Chong Yidong <cyd@stupidchicken.com>
4759
4760 * syntax.c (find_defun_start): Update all cache variables if
4761 exiting early (Bug#9401).
4762
148ae00e
EZ
47632011-08-30 Eli Zaretskii <eliz@gnu.org>
4764
f6cfbd8f
EZ
4765 * image.c (x_bitmap_pixmap): Cast to int to avoid compiler warnings.
4766
148ae00e
EZ
4767 * xdisp.c (produce_stretch_glyph): No longer static, compiled also
4768 when HAVE_WINDOW_SYSTEM is not defined. Support both GUI and TTY
4769 frames. Call tty_append_glyph in the TTY case. (Bug#9402)
4770
4771 * term.c (tty_append_glyph): New function.
4772 (produce_stretch_glyph): Static function and its prototype deleted.
4773
a66cfb1c
SM
4774 * dispextern.h (produce_stretch_glyph, tty_append_glyph):
4775 Add prototypes.
148ae00e 4776
c4a07a4c
PE
47772011-08-29 Paul Eggert <eggert@cs.ucla.edu>
4778
4779 * image.c (parse_image_spec): Check for nonnegative, not for positive,
4780 when checking :margin (Bug#9390).
4781 (IMAGE_NON_NEGATIVE_INTEGER_VALUE_OR_PAIR):
a66cfb1c 4782 Rename from IMAGE_POSITIVE_INTEGER_VALUE_OR_PAIR,
c4a07a4c
PE
4783 so that the name doesn't mislead. All uses changed.
4784
6bc8cd65
JB
47852011-08-28 Johan Bockgård <bojohan@gnu.org>
4786
4787 * term.c (init_tty) [HAVE_GPM]: Move mouse settings after
4788 set_tty_hooks.
4789
dca4927e
EZ
47902011-08-27 Eli Zaretskii <eliz@gnu.org>
4791
4792 * xdisp.c (move_it_to): Don't bail out early when reaching
4793 position beyond to_charpos, if we are scanning backwards.
4794 (move_it_vertically_backward): When DY == 0, make sure we get to
4795 the first character in the line after the newline.
4796
f2cad773
PE
47972011-08-27 Paul Eggert <eggert@cs.ucla.edu>
4798
4799 * ccl.c: Improve and simplify overflow checking (Bug#9196).
4800 (ccl_driver): Do not generate an out-of-range pointer.
4801 (Fccl_execute_on_string): Remove unnecessary check for
4802 integer overflow, noted by Stefan Monnier in
4803 <http://lists.gnu.org/archive/html/emacs-devel/2011-08/msg00979.html>.
4804 Remove a FIXME that didn't need fixing.
4805 Simplify the newly-introduced buffer reallocation code.
4806
0cae2cdb
JB
48072011-08-27 Juanma Barranquero <lekktu@gmail.com>
4808
4809 * makefile.w32-in ($(BLD)/alloc.$(O)): Depend on lib/verify.h.
4810
5fc295a4 48112011-08-26 Paul Eggert <eggert@cs.ucla.edu>
ddff3151 4812
70c60eb2 4813 Integer and memory overflow issues (Bug#9196).
726e0ab1 4814
d31850da
PE
4815 * doc.c (get_doc_string): Rework so that
4816 get_doc_string_buffer_size is the actual buffer size, rather than
4817 being 1 less than the actual buffer size; this makes xpalloc more
4818 convenient.
4819
a69fbedb
PE
4820 * image.c (x_allocate_bitmap_record, cache_image):
4821 * xselect.c (Fx_register_dnd_atom):
4822 Simplify previous changes by using xpalloc.
4823
fe5c5d37
PE
4824 * buffer.c (overlay_str_len): Now ptrdiff_t, not EMACS_INT,
4825 since either will do and ptrdiff_t is convenient with xpalloc.
4826
0065d054
PE
4827 * charset.c (charset_table_size)
4828 (struct charset_sort_data.priority): Now ptrdiff_t.
4829 (charset_compare): Don't overflow if priorities differ greatly.
4830 (Fsort_charsets): Don't assume list length fits in int.
4831 Check for size-calculation overflow when allocating sort data.
4832 (syms_of_charset): Allocate an initial charset table that is
4833 just under 64 KiB, to avoid problems with glibc malloc and mmap.
4834
4835 * cmds.c (internal_self_insert): Check for size-calculation overflow.
4836
4837 * composite.h (struct composition.glyph_len): Now int, not unsigned.
4838 The actual value is always <= INT_MAX, and leaving it unsigned made
4839 overflow checking harder.
4840
4841 * dispextern.h (struct glyph_matrix.rows_allocated)
4842 (struct face_cache.size): Now ptrdiff_t, for convenience in use
4843 with xpalloc. The values are still always <= INT_MAX.
4844
4845 * indent.c (compute_motion): Adjust to region_cache_forward sig change.
4846
4847 * lisp.h (xnmalloc, xnrealloc, xpalloc): New decls.
4848 (SAFE_NALLOCA): New macro.
4849
4850 * region-cache.c (struct boundary.pos, find_cache_boundary)
4851 (move_cache_gap, insert_cache_boundary, delete_cache_boundaries)
4852 (set_cache_region, invalidate_region_cache)
4853 (revalidate_region_cache, know_region_cache, region_cache_forward)
4854 (region_cache_backward, pp_cache):
4855 Use ptrdiff_t, not EMACS_INT, since either will do. This is needed
4856 so that ptrdiff_t * can be passed to xpalloc.
4857 (struct region_cache): Similarly, for gap_start, gap_len, cache_len,
4858 beg_unchanged, end_unchanged, buffer_beg, buffer_end members.
4859 (pp_cache): Don't assume cache_len fits in int.
4860 * region-cache.h: Adjust extern decls to match.
4861
4862 * search.c (scan_buffer, Freplace_match): Use ptrdiff_t, not
4863 EMACS_INT, since either will do, for xpalloc.
4864
4865 * alloc.c: Include verify.h, and check that int fits in ptrdiff_t.
4866 (xnmalloc, xnrealloc, xpalloc): New functions.
4867
726e0ab1
PE
4868 * bidi.c (bidi_shelve_header_size): New constant.
4869 (bidi_cache_ensure_space, bidi_shelve_cache): Use it.
4870 (bidi_cache_ensure_space): Avoid integer overflow when allocating.
4871
51f30bc5 4872 * bidi.c (bidi_cache_shrink):
726e0ab1
PE
4873 * buffer.c (overlays_at, overlays_in, record_overlay_string)
4874 (overlay_strings):
4875 Don't update size of array until after memory allocation succeeds,
4876 because xmalloc/xrealloc may not return.
0065d054
PE
4877 (struct sortstrlist.bytes): Now ptrdiff_t, as EMACS_INT doesn't help
4878 now that we have proper integer overflow checking.
4879 (record_overlay_string, overlay_strings): Catch overflows when
4880 calculating size of overlay_str_buf.
726e0ab1 4881
0065d054
PE
4882 * callproc.c (Fcall_process): Check for size overflow when
4883 calculating size of args2.
4884 (child_setup): Avoid overflow by using size_t rather than ptrdiff_t.
4885 Normally we prefer signed values, but sticking with ptrdiff_t would
4886 require adding more-complicated checks.
726e0ab1
PE
4887
4888 * ccl.c (Fccl_execute_on_string): Check for memory overflow.
4889 Use ptrdiff_t rather than EMACS_INT where ptrdiff_t will do.
4890 Redo buffer-overflow calculations to avoid integer overflow.
0065d054 4891 Add a FIXME comment where memory seems to be over-allocated.
726e0ab1
PE
4892
4893 * character.c (Fstring): Check for size-calculation overflow.
4894
4895 * coding.c (produce_chars): Redo buffer-overflow calculations to avoid
4896 unnecessary integer overflow. Check for size overflow.
4897 (encode_coding_object): Don't update size until xmalloc succeeds.
4898
4899 * composite.c (get_composition_id): Check for overflow in glyph
4900 length calculations.
4901
4902 Integer and memory overflow fixes for display code.
4903 * dispextern.h (struct glyph_pool.nglyphs): Now ptrdiff_t, not int.
4904 * dispnew.c (adjust_glyph_matrix, realloc_glyph_pool)
4905 (scrolling_window): Check for overflow in size calculations.
4906 (line_draw_cost, realloc_glyph_pool, add_row_entry):
4907 Don't assume glyph table len fits in int.
4908 (struct row_entry.bucket, row_entry_pool_size, row_entry_idx)
4909 (row_table_size): Now ptrdiff_t, not int.
4910 (scrolling_window): Avoid overflow in size calculations.
4911 Don't update size until allocation succeeds.
4912 * fns.c (concat): Check for overflow in size calculations.
4913 (next_almost_prime): Verify NEXT_ALMOST_PRIME_LIMIT.
4914 * lisp.h (RANGED_INTEGERP, TYPE_RANGED_INTEGERP): New macros.
4915 (NEXT_ALMOST_PRIME_LIMIT): New constant.
4916
4917 * doc.c (get_doc_string_buffer_size): Now ptrdiff_t, not int.
4918 (get_doc_string): Check for size calculation overflow.
4919 Don't update size until allocation succeeds.
4920 (get_doc_string, Fsubstitute_command_keys): Use ptrdiff_t, not
4921 EMACS_INT, where ptrdiff_t will do.
4922 (Fsubstitute_command_keys): Check for string overflow.
4923
4924 * editfns.c (set_time_zone_rule): Don't assume environment length
4925 fits in int.
4926 (message_length): Now ptrdiff_t, not int.
4927 (Fmessage_box): Don't update size until allocation succeeds.
4928 Don't assume message length fits in int.
4929 (Fformat): Use ptrdiff_t, not EMACS_INT, where ptrdiff_t will do.
4930
0065d054
PE
4931 * emacs.c (main): Do not reallocate argv, since there is a null at
4932 the end that can be overwritten, and this way there's no need to
4933 worry about size-calculation overflow.
4934 (sort_args): Check for size-calculation overflow.
726e0ab1
PE
4935
4936 * eval.c (init_eval_once, grow_specpdl): Don't update size until
4937 alloc succeeds.
4938 (call_debugger, grow_specpdl): Redo calculations to avoid overflow.
4939
4940 * frame.c (set_menu_bar_lines, x_set_frame_parameters)
4941 (x_set_scroll_bar_width, x_figure_window_size):
4942 Check for integer overflow.
4943 (x_set_alpha): Do not assume XINT fits in int.
4944
4945 * frame.h (struct frame): Use int, not EMACS_INT, where int works.
4946 This is for the members text_lines, text_cols, total_lines, total_cols,
4947 where the system imposes an 'int' limit.
4948
4949 * fringe.c (Fdefine_fringe_bitmap):
4950 Don't update size until alloc works.
4951
4952 * ftfont.c (ftfont_get_open_type_spec, setup_otf_gstring)
4953 (ftfont_shape_by_flt): Check for integer overflow in size calculations.
4954
4955 * gtkutil.c (get_utf8_string, xg_store_widget_in_map):
4956 Check for size-calculation overflow.
4957 (get_utf8_string): Use ptrdiff_t, not size_t, where either will
4958 do, as we prefer signed integers.
4959 (id_to_widget.max_size, id_to_widget.used)
4960 (xg_store_widget_in_map, xg_remove_widget_from_map)
4961 (xg_get_widget_from_map, xg_get_scroll_id_for_window)
4962 (xg_remove_scroll_bar, xg_update_scrollbar_pos):
4963 Use and return ptrdiff_t, not int.
4964 (xg_gtk_scroll_destroy): Don't assume ptrdiff_t fits in int.
4965 * gtkutil.h: Change prototypes to match the above.
4966
4967 * image.c (RANGED_INTEGERP, TYPE_RANGED_INTEGERP): Remove; these
4968 are duplicate now that they've been promoted to lisp.h.
4969 (x_allocate_bitmap_record, x_alloc_image_color)
4970 (make_image_cache, cache_image, xpm_load):
4971 Don't update size until alloc is done.
4972 (xpm_load, lookup_rgb_color, lookup_pixel_color, x_to_xcolors)
4973 (x_detect_edges):
3256efce 4974 Check for size calculation overflow.
726e0ab1
PE
4975 (ct_colors_allocated_max): New constant.
4976 (x_to_xcolors, x_detect_edges): Reorder multiplicands to avoid
4977 overflow.
3256efce 4978
726e0ab1
PE
4979 * keyboard.c (read_char, menu_bar_items, tool_bar_items)
4980 (read_char_x_menu_prompt, read_char_minibuf_menu_width)
4981 (read_char_minibuf_menu_prompt, follow_key, read_key_sequence):
4982 Use ptrdiff_t, not int, to count maps.
4983 (read_char_minibuf_menu_prompt): Check for overflow in size
a66cfb1c
SM
4984 calculations. Don't update size until allocation succeeds.
4985 Redo calculations to avoid overflow.
726e0ab1
PE
4986 * keyboard.h: Change prototypes to match the above.
4987
4988 * keymap.c (cmm_size, current_minor_maps): Use ptrdiff_t, not int,
4989 to count maps.
4990 (current_minor_maps): Check for size calculation overflow.
4991 * keymap.h: Change prototypes to match the above.
4992
4993 * lread.c (read1, init_obarray): Don't update size until alloc done.
4994
4995 * macros.c (Fstart_kbd_macro): Don't update size until alloc done.
4996 (store_kbd_macro_char): Reorder multiplicands to avoid overflow.
4997
726e0ab1
PE
4998 * nsterm.h (struct ns_color_table.size, struct ns_color_table.avail):
4999 Now ptrdiff_t, not int.
5000 * nsterm.m (ns_index_color): Use ptrdiff_t, not int, for table indexes.
5001 (ns_draw_fringe_bitmap): Rewrite to avoid overflow.
5002
5003 * process.c (Fnetwork_interface_list): Check for overflow
5004 in size calculation.
5005
5006 * region-cache.c (move_cache_gap): Check for size calculation overflow.
5007
5008 * scroll.c (do_line_insertion_deletion_costs): Check for size calc
5009 overflow. Don't bother calling xmalloc when xrealloc will do.
5010
5011 * search.c (Freplace_match): Check for size calculation overflow.
5012 (Fset_match_data): Don't assume list lengths fit in 'int'.
5013
5014 * sysdep.c (system_process_attributes): Use ptrdiff_t, not int,
5015 for command line length. Do not attempt to address one before the
5016 beginning of an array, as that's not portable.
5017
5018 * term.c (max_frame_lines): Remove; unused.
5019 (encode_terminal_src_size, encode_terminal_dst_size): Now ptrdiff_t,
5020 not int.
5021 (encode_terminal_code, calculate_costs): Check for size
5022 calculation overflow.
5023 (encode_terminal_code): Use ptrdiff_t, not int, to record glyph
5024 table lengths and related sizes. Don't update size until alloc
5025 done. Redo calculations to avoid overflow.
5026 (calculate_costs): Don't bother calling xmalloc when xrealloc will do.
5027
5028 * termcap.c (tgetent): Use ptrdiff_t, not int, to record results of
5029 subtracting pointers.
5030 (gobble_line): Check for overflow more carefully. Don't update size
5031 until alloc done.
5032
5033 * tparam.c (tparam1): Use ptrdiff_t, not int, for sizes.
5034 Don't update size until alloc done.
5035 Redo size calculations to avoid overflow.
5036 Check for size calculation overflow.
0065d054 5037 (main) [DEBUG]: Fix typo in invoking tparam1.
726e0ab1
PE
5038
5039 * xdisp.c (store_mode_line_noprop_char, x_consider_frame_title):
5040 Use ptrdiff_t, not int, for sizes.
5041 (store_mode_line_noprop_char): Don't update size until alloc done.
5042
0065d054
PE
5043 * xfaces.c (lface_id_to_name_size, Finternal_make_lisp_face):
5044 Use ptrdiff_t, not int, for sizes.
5045 (Finternal_make_lisp_face, cache_face):
5046 Check for size calculation overflow.
5047 (cache_face): Treat size calculation overflows as if they were
5048 memory exhaustion (the usual treatment), rather than aborting.
726e0ab1
PE
5049
5050 * xfns.c (x_encode_text, x_set_name_internal)
5051 (Fx_change_window_property): Use ptrdiff_t, not int, to count
5052 sizes, since they can exceed INT_MAX in size. Check for size
5053 calculation overflow.
5054
0065d054
PE
5055 * xgselect.c (gfds_size): Now ptrdiff_t, for convenience with xpalloc.
5056 (xg_select): Check for size calculation overflow.
726e0ab1
PE
5057 Don't update size until alloc done.
5058
0065d054 5059 * xrdb.c (get_environ_db): Don't assume path length fits in int,
726e0ab1 5060 as sprintf is limited to int lengths.
1d526e2f 5061
252c5ee1
PE
5062 * xselect.c (X_LONG_SIZE, X_SHRT_MAX, X_SHRT_MIN, X_LONG_MAX)
5063 (X_LONG_MIN): New macros.
864d7ce7
PE
5064 Use them to make the following changes clearer.
5065 (MAX_SELECTION_QUANTUM): Make the other bounds on this value clearer.
5066 This change doesn't affect the value now, but it may help remind
5067 future maintainers not to raise the value too much later.
5068 (SELECTION_QUANTUM): Remove, replacing with ...
5069 (selection_quantum): ... new function, which avoids overflow.
5070 All uses changed.
5071 (struct selection_data.size): Now ptrdiff_t, not int, to avoid
5072 assumption that selection length fits in 'int'.
5073 (x_reply_selection_request, x_handle_selection_request)
5074 (x_get_window_property, receive_incremental_selection)
5075 (x_get_window_property_as_lisp_data, selection_data_to_lisp_data)
5076 (lisp_data_to_selection_data, clean_local_selection_data):
5077 Use ptrdiff_t, not int, to record length of selection.
5078 (x_reply_selection_request, x_get_window_property)
5079 (receive_incremental_selection, x_property_data_to_lisp):
5080 Redo calculations to avoid overflow.
5081 (x_reply_selection_request): When sending hint, ceiling it at
252c5ee1 5082 X_LONG_MAX rather than relying on wraparound overflow to send
864d7ce7
PE
5083 something.
5084 (x_get_window_property, receive_incremental_selection)
5085 (lisp_data_to_selection_data, x_property_data_to_lisp):
5086 Check for size-calculation overflow.
5087 (x_get_window_property, receive_incremental_selection)
5088 (lisp_data_to_selection_data, Fx_register_dnd_atom):
5089 Don't store size until memory allocation succeeds.
5090 (x_get_window_property): Plug memory leak on memory exhaustion.
5091 Don't double-block input; malloc is safe here. Don't assume 2**34
5092 - 4 fits in unsigned long. Add an xassert to check
5093 XGetWindowProperty overflow. Be more careful about overflow
5094 calculations, and distinguish size from memory overflow better.
5095 (receive_incremental_selection): When tracing, don't assume
5096 unsigned int is less than INT_MAX.
5097 (x_selection_data_to_lisp_data): Remove unnecessary (and in theory
5098 harmful) conversions of unsigned short to int.
5099 (lisp_data_to_selection_data): Don't assume that integers
5100 in the range -65535 through -1 fit in an X unsigned short.
5101 Don't assume that ULONG_MAX == X_ULONG_MAX. Don't store into
5102 result parameters unless successful. Rely on cons_to_unsigned
5103 to report problems with elements; the old code wasn't right anyway.
5104 (x_check_property_data): Check for int overflow; we cannot use
5105 a wider type due to X limits.
5106 (x_handle_dnd_message): Use unsigned int, to avoid int overflow.
5107
726e0ab1 5108 * xsmfns.c (smc_save_yourself_CB): Check for size calc overflow.
34db673b 5109
0065d054
PE
5110 * xterm.c (x_color_cells, x_send_scrollbar_event, handle_one_xevent)
5111 (x_term_init): Check for size calculation overflow.
726e0ab1
PE
5112 (x_color_cells): Don't store size until memory allocation succeeds.
5113 (handle_one_xevent): Use ptrdiff_t, not int, for byte counts.
0065d054 5114 Don't assume alloca size is less than MAX_ALLOCA.
726e0ab1
PE
5115 (x_term_init): Don't assume length fits in int (sprintf is limited
5116 to int size).
bc18e09d 5117
ebfa62c0
PE
5118 Use ptrdiff_t for composition IDs.
5119 * character.c (lisp_string_width):
5120 * composite.c (composition_table_size, n_compositions)
5121 (get_composition_id, composition_gstring_from_id):
5122 * dispextern.h (struct glyph_string.cmp_id, struct composition_it.id):
5123 * xdisp.c (BUILD_COMPOSITE_GLYPH_STRING):
5124 * window.c (Frecenter):
5125 Use ptrdiff_t, not int, for composition IDs.
5126 * composite.c (get_composition_id): Check for integer overflow.
5127 * composite.h: Adjust prototypes to match the above changes.
5128
d3411f89
PE
5129 Use ptrdiff_t for hash table indexes.
5130 * category.c (hash_get_category_set):
5131 * ccl.c (ccl_driver):
5132 * charset.h (struct charset.hash_index, CHECK_CHARSET_GET_ID):
5133 * coding.c (coding_system_charset_list, detect_coding_system):
5134 * coding.h (struct coding_system.id):
5135 * composite.c (get_composition_id, gstring_lookup_cache):
5136 * fns.c (hash_lookup, hash_put, Fgethash, Fputhash):
5137 * image.c (xpm_get_color_table_h):
5138 * lisp.h (hash_lookup, hash_put):
5139 * minibuf.c (Ftest_completion):
5140 Use ptrdiff_t for hash table indexes, not int (which is too
5141 narrow, on 64-bit hosts) or EMACS_INT (which is too wide, on
5142 32-bit --with-wide-int hosts).
5143
e097a6fa
PE
5144 * charset.c (Fdefine_charset_internal): Check for integer overflow.
5145 Add a FIXME comment about memory leaks.
5146 (syms_of_charset): Don't assume xmalloc returns.
5147
5637687f
PE
5148 Don't assume that stated character widths fit in int.
5149 * character.c (Fchar_width, c_string_width, lisp_string_width):
5150 * character.h (CHAR_WIDTH):
5151 * indent.c (MULTIBYTE_BYTES_WIDTH):
5152 Use sanitize_char_width to avoid undefined and/or bad behavior
5153 with outlandish widths.
a66cfb1c 5154 * character.h (sanitize_tab_width): Rename from sanitize_width,
5637687f
PE
5155 now that we have two such functions. All uses changed.
5156 (sanitize_char_width): New inline function.
5157
a2271ba2
PE
5158 Don't assume that tab-width fits in int.
5159 * character.h (sanitize_width): New inline function.
5160 (SANE_TAB_WIDTH): New macro.
5161 (ASCII_CHAR_WIDTH): Use it.
5162 * indent.c (sane_tab_width): Remove. All uses replaced by
5163 SANE_TAB_WIDTH (current_buffer).
5164 * xdisp.c (init_iterator): Use SANE_TAB_WIDTH.
5165
18c52557
PE
5166 * fileio.c: Integer overflow issues with file modes.
5167 (Fset_file_modes, auto_save_1): Don't assume EMACS_INT fits in int.
5168
caeeedc1
PE
5169 * charset.c (read_hex): New arg OVERFLOW. All uses changed.
5170 Remove unreachable code.
5171 (read_hex, load_charset_map_from_file): Check for integer overflow.
5172
6df6ae42 5173 * xterm.c: Don't go over XClientMessageEvent limit.
50849c52
PE
5174 (scroll_bar_windows_size): Now ptrdiff_t, as we prefer signed.
5175 (x_send_scroll_bar_event): Likewise. Check that the size does not
5176 exceed limits imposed by XClientMessageEvent, as well as the usual
5177 ptrdiff_t and size_t limits.
5178
b13995db
PE
5179 * keyboard.c: Overflow, signedness and related fixes.
5180 (make_lispy_movement): Use same integer type in forward decl
5181 that is used in the definition.
5182 (read_key_sequence, keyremap_step):
5183 Change bufsize argument back to int, undoing my 2011-03-30 change.
5184 We prefer signed types, and int is wide enough here.
5185 (parse_tool_bar_item): Don't assume tool_bar_max_label_size is less
5186 than TYPE_MAXIMUM (EMACS_INT) / 2. Don't let the label size grow
5187 larger than STRING_BYTES_BOUND. Use ptrdiff_t for Emacs string
5188 length, not size_t. Use ptrdiff_t for index, not int.
5189 (keyremap_step, read_key_sequence): Redo bufsize check to avoid
5190 possibility of integer overflow.
5191
13464394
PE
5192 Overflow, signedness and related fixes for images.
5193
5194 * dispextern.h (struct it.stack[0].u.image.image_id)
5195 (struct_it.image_id, struct image.id, struct image_cache.size)
5196 (struct image_cache.used, struct image_cache.ref_count):
5197 * gtkutil.c (update_frame_tool_bar):
5198 * image.c (x_reference_bitmap, Fimage_size, Fimage_mask_p)
5199 (Fimage_metadata, free_image_cache, clear_image_cache, lookup_image)
5200 (cache_image, mark_image_cache, x_kill_gs_process, Flookup_image):
5201 * nsmenu.m (update_frame_tool_bar):
5202 * xdisp.c (calc_pixel_width_or_height):
5203 * xfns.c (image_cache_refcount):
5204 Image IDs are now ptrdiff_t, not int, to avoid arbitrary limits
5205 on typical 64-bit hosts.
5206
5207 * image.c (RANGED_INTEGERP, TYPE_RANGED_INTEGERP): New macros.
5208 (x_bitmap_pixmap, x_create_x_image_and_pixmap):
5209 Omit unnecessary casts to int.
5210 (parse_image_spec): Check that integers fall into 'int' range
5211 when the callers expect that.
5212 (image_ascent): Redo ascent calculation to avoid int overflow.
5213 (clear_image_cache): Avoid overflow when sqrt (INT_MAX) < nimages.
5214 (lookup_image): Remove unnecessary tests.
5215 (xbm_image_p): Locals are now of int, not EMACS_INT,
5216 since parse_image_check makes sure they fit into int.
5217 (png_load, gif_load, svg_load_image):
5218 Prefer int to unsigned where either will do.
5219 (tiff_handler): New function, combining the cores of the
a66cfb1c
SM
5220 old tiff_error_handler and tiff_warning_handler.
5221 This function is rewritten to use vsnprintf and thereby avoid
13464394
PE
5222 stack buffer overflows. It uses only the features of vsnprintf
5223 that are common to both POSIX and native Microsoft.
5224 (tiff_error_handler, tiff_warning_handler): Use it.
5225 (tiff_load, gif_load, imagemagick_load_image):
5226 Don't assume :index value fits in 'int'.
5227 (gif_load): Omit unnecessary cast to double, and avoid double-rounding.
5228 (imagemagick_load_image): Check that crop parameters fit into
5229 the integer types that MagickCropImage accepts. Don't assume
5230 Vimagemagick_render_type has a nonnegative value. Don't assume
5231 size_t fits in 'long'.
5232 (gs_load): Use printmax_t to print the widest integers possible.
5233 Check for integer overflow when computing image height and width.
5234
c11821d4
EZ
52352011-08-26 Eli Zaretskii <eliz@gnu.org>
5236
5237 * xdisp.c (redisplay_window): Don't force window start if point
5238 will be invisible in the resulting window. (Bug#9324)
5239
0c95fcf7
EZ
52402011-08-25 Eli Zaretskii <eliz@gnu.org>
5241
5242 * xdisp.c (compute_display_string_pos): Return 2 in DISP_PROP when
5243 the display spec is of the form `(space ...)'.
5244 (handle_display_spec): Return the value returned by
5245 handle_single_display_spec, not just 1 or zero.
5246 (handle_single_display_spec): If the display spec is of the form
5247 `(space ...)', and specifies display in the text area, return 2
5248 rather than 1.
fee65a97 5249 (try_cursor_movement): Check for the need to scroll more
a66cfb1c
SM
5250 accurately, and prefer exact match for point under bidi.
5251 Don't advance `row' beyond the last row of the window.
0c95fcf7
EZ
5252
5253 * dispextern.h (struct bidi_it): Rename the disp_prop_p member
5254 into disp_prop; all users changed.
5255
5256 * bidi.c (bidi_fetch_char): If compute_display_string_pos returns
5257 DISP_PROP = 2, substitute the u+2029 PARAGRAPH SEPARATOR character
5258 for the text covered by the display property.
5259
e4ed06f1
CY
52602011-08-25 Chong Yidong <cyd@stupidchicken.com>
5261
5262 * buffer.c (Fbury_buffer_internal): Rename from Funrecord_buffer.
5263 Change return value to nil.
5264 (Frecord_buffer): Delete unused function.
5265
f67cdd7f
EZ
52662011-08-24 Eli Zaretskii <eliz@gnu.org>
5267
5980d4c6
EZ
5268 * xdisp.c (Fcurrent_bidi_paragraph_direction): For unibyte
5269 buffers, return left-to-right.
8610fe8b
EZ
5270 (set_cursor_from_row): Consider candidate row a win if its glyph
5271 represents a newline and point is on that newline. Fixes cursor
5272 positioning on the newline at EOL of R2L text within L2R
5273 paragraph, and vice versa.
5274 (try_cursor_movement): Check continued rows, in addition to
5275 continuation rows. Fixes unwarranted scroll when point enters a
5276 continued line of R2L text within an L2R paragraph, or vice versa.
5277 (cursor_row_p): Consider the case of point being equal to
5278 MATRIX_ROW_END_CHARPOS. Prevents cursor being stuck when moving
5279 from the end of a short line to the beginning of a continued line
5280 of R2L text within L2R paragraph.
5281 (RECORD_MAX_MIN_POS): For max_pos, use IT_CHARPOS even for
5282 composed characters.
5980d4c6 5283
f67cdd7f
EZ
5284 * bidi.c (bidi_check_type): Use xassert.
5285 (bidi_cache_iterator_state): Update the disp_pos and disp_prop_p
5286 members.
5287
bca633fb
EZ
52882011-08-23 Eli Zaretskii <eliz@gnu.org>
5289
5290 * bidi.c (bidi_get_type): Abort if we get zero as the bidi type of
5291 a character.
5292
4a5885a7
CY
52932011-08-23 Chong Yidong <cyd@stupidchicken.com>
5294
5295 * nsfont.m (ns_otf_to_script): Fix typo.
5296
0902a04e
KH
52972011-08-22 Kenichi Handa <handa@m17n.org>
5298
5299 * chartab.c (Fset_char_table_extra_slot): Do not inhibit setting a
5300 extra slot even if the purpose is char-code-property-table.
5301
1a2e6670
EZ
53022011-08-23 Eli Zaretskii <eliz@gnu.org>
5303
8ddde651
EZ
5304 * xdisp.c (redisplay_window): When computing centering_position,
5305 account for the height of the header line. (Bug#8874)
5306
425cc014
EZ
5307 * dispnew.c (buffer_posn_from_coords): Use buf_charpos_to_bytepos
5308 instead of CHAR_TO_BYTE. Fixes a crash when a completion
5309 candidate is selected by the mouse, and that candidate has a
5310 composed character under the mouse.
5311
1a2e6670
EZ
5312 * xdisp.c (x_produce_glyphs): Set it->nglyphs to 1. Fixes pixel
5313 coordinates reported by pos-visible-in-window-p for a composed
5314 character in column zero.
5315
8b76d6f8
SM
53162011-08-23 Stefan Monnier <monnier@iro.umontreal.ca>
5317
5318 * cmds.c (Fself_insert_command): Mention post-self-insert-hook.
5319
dac347dd
EZ
53202011-08-22 Eli Zaretskii <eliz@gnu.org>
5321
5322 * xdisp.c (BUFFER_POS_REACHED_P): If this is a composition,
5323 consider it a hit if to_charpos is anywhere in the range of the
5324 composed buffer positions.
5325
e013fb34
CY
53262011-08-22 Chong Yidong <cyd@stupidchicken.com>
5327
5328 * image.c (gif_load): Don't assume that each subimage has the same
5329 dimensions as the base image. Handle disposal method that is
5330 "undefined" by the gif spec (Bug#9335).
5331
bd1ba3e8
CY
53322011-08-20 Chong Yidong <cyd@stupidchicken.com>
5333
5334 * eval.c (Fsignal): Handle `debug' symbol in error handler (Bug#9329).
024a2d76 5335 (Fcondition_case): Document `debug' symbol in error handler.
bd1ba3e8 5336
54a1215b
EZ
53372011-08-19 Eli Zaretskii <eliz@gnu.org>
5338
823564e5
EZ
5339 * xfaces.c (face_at_buffer_position): Avoid repeated evaluation of
5340 face ID by FACE_FROM_ID, and avoid a crash when mouse is moved
5341 from an Org mode buffer to a Speedbar frame.
5342
54a1215b
EZ
5343 * xdisp.c (RECORD_MAX_MIN_POS): If the display element comes from
5344 a composition, take its buffer position from IT->cmp_it.charpos.
5345 Fixes cursor positioning at the beginning of a line that begins
5346 with a composed character.
5347
9778ebcc
EZ
53482011-08-18 Eli Zaretskii <eliz@gnu.org>
5349
0be6ee06
EZ
5350 * bidi.c (bidi_get_type): If bidi_type_table reports zero as the
5351 character bidirectional type, use STRONG_L instead. Fixes crashes
5352 in a buffer produced by `describe-categories'.
5353
9778ebcc
EZ
5354 * dispextern.h (struct bidi_it): Move disp_pos and disp_prop_p
5355 members before the level stack, so they would be saved and
5356 restored when copying iterator state. Fixes incorrect reordering
5357 around TABs covered by display properties.
5358
156bffbe
AS
53592011-08-18 Andreas Schwab <schwab@linux-m68k.org>
5360
6b02f655 5361 * process.c (Fnetwork_interface_list): Correctly determine buffer size.
156bffbe 5362
72ad093b
CY
53632011-08-17 Chong Yidong <cyd@stupidchicken.com>
5364
5365 * eval.c (internal_condition_case, internal_condition_case_1)
8b76d6f8
SM
5366 (internal_condition_case_2, internal_condition_case_n):
5367 Remove unnecessary aborts (Bug#9081).
72ad093b 5368
35774242
EZ
53692011-08-17 Eli Zaretskii <eliz@gnu.org>
5370
5371 * lread.c (Fload) [DOS_NT]: If `openp' returns -2, but the file
5372 has no `load' handler, try opening the file locally. (Bug#9311)
5373
db76dd85
KB
53742011-08-16 Ken Brown <kbrown@cornell.edu>
5375
5376 * gmalloc.c: Expand comment.
5377
b215eee5
EZ
53782011-08-16 Eli Zaretskii <eliz@gnu.org>
5379
5380 * xdisp.c (set_cursor_from_row): Don't accept a previous candidate
5381 if it fails the cursor_row_p test. Fixes cursor positioning at ZV.
5382
a4579d33
KB
53832011-08-16 Ken Brown <kbrown@cornell.edu>
5384
5385 Fix memory allocation problems in Cygwin build (Bug#9273).
5386
5387 * unexcw.c ( __malloc_initialized): Declare external variable.
5388 (fixup_executable): Force the dumped emacs to reinitialize malloc.
5389
8b76d6f8
SM
5390 * gmalloc.c [CYGWIN] (bss_sbrk_heapbase, bss_sbrk_heapinfo):
5391 New variables.
a4579d33
KB
5392 (malloc_initialize_1) [CYGWIN]: Prepare for reinitializing the
5393 dumped emacs.
5394 (_free_internal_nolock) [CYGWIN]: Ignore requests to free storage
5395 in the static heap.
5396 [CYGWIN] (special_realloc): New function.
5397 (_realloc_internal_nolock) [CYGWIN]: Use the new function on
5398 requests to realloc storage in the static heap.
5399
3ebec551
PE
54002011-08-15 Paul Eggert <eggert@cs.ucla.edu>
5401
5402 * bidi.c (bidi_initialize): Remove unused local.
5403
9fd8be00
EZ
54042011-08-15 Eli Zaretskii <eliz@gnu.org>
5405
6b02f655
SM
5406 * bidimirror.h:
5407 * biditype.h: Remove file.
5408 * makefile.w32-in ($(BLD)/bidi.$(O)):
5409 * deps.mk (bidi.o): Remove biditype.h and bidimirror.h.
474a8465
EZ
5410
5411 * dispextern.h: Fix a typo in the comment to bidi_type_t.
5412
5413 * chartab.c: Improve commentary for the uniprop_table API.
5414
32413314
EZ
5415 * bidi.c (bidi_paragraph_init): Support zero value of
5416 bidi_ignore_explicit_marks_for_paragraph_level.
474a8465
EZ
5417 (bidi_initialize): Use uniprop_table instead of including
5418 biditype.h and bidimirror.h.
32413314 5419
9fd8be00
EZ
5420 * xdisp.c (move_it_in_display_line_to): Don't reset pixel
5421 coordinates of the iterator when restoring from ppos_it.
5422 (Bug#9296)
5423
5cf2b69b
KH
54242011-08-14 Kenichi Handa <handa@m17n.org>
5425
5426 * process.c (create_process): Call setup_process_coding_systems
72ad093b 5427 after the pid of the process is set to -1 (Bug#8162).
5cf2b69b 5428
daf17d00
EZ
54292011-08-14 Eli Zaretskii <eliz@gnu.org>
5430
5431 * xdisp.c (move_it_in_display_line_to): Don't invoke
5432 IT_RESET_X_ASCENT_DESCENT when iterator position was restored from
5433 ppos_it. Fixes vertical cursor motion when line beginning is
5434 covered by an image. (Bug#9296)
5435
08e3161a
JD
54362011-08-14 Jan Djärv <jan.h.d@swipnet.se>
5437
5438 * nsterm.h (ns_run_ascript): Declare.
5439 (NSAPP_DATA2_RUNASSCRIPT): Define.
5440
5441 * nsfns.m (as_script, as_result, as_status): New static variables.
5442 (ns_run_ascript): New function.
5e617bc2 5443 (Fns_do_applescript): Set variables as_*. Make an NSApplicationDefined
08e3161a
JD
5444 event with data2 set to NSAPP_DATA2_RUNASSCRIPT, post it and then start
5445 the event loop. Get status from as_status (Bug#7276).
5446
5447 * nsterm.m (sendEvent): If event is NSApplicationDefined and
5448 data2 is NSAPP_DATA2_RUNASSCRIPT, call ns_run_ascript and then exit
5449 the event loop (Bug#7276).
5450
a3720aa2
AS
54512011-08-14 Andreas Schwab <schwab@linux-m68k.org>
5452
5453 * gnutls.c (QCgnutls_bootprop_priority)
5454 (QCgnutls_bootprop_trustfiles, QCgnutls_bootprop_keylist)
5455 (QCgnutls_bootprop_crlfiles, QCgnutls_bootprop_callbacks)
5456 (QCgnutls_bootprop_loglevel, QCgnutls_bootprop_hostname)
5457 (QCgnutls_bootprop_min_prime_bits, QCgnutls_bootprop_verify_flags)
5458 (QCgnutls_bootprop_verify_hostname_error)
5459 (QCgnutls_bootprop_callbacks_verify): Rename from
5460 Qgnutls_bootprop_..., all uses changed.
5461
5462 * xfaces.c (QCignore_defface): Rename from Qignore_defface, all
5463 uses changed.
5464
0a0d27fb
PE
54652011-08-14 Paul Eggert <eggert@cs.ucla.edu>
5466
19d5c50c
PE
5467 * xfaces.c (Qframe_set_background_mode): Now static.
5468 * dispextern.h (Qframe_set_background_mode): Remove decl.
5469
0a0d27fb
PE
5470 * process.c (Fnetwork_interface_info): Declare local only if needed.
5471
377538cb
JD
54722011-08-13 Jan Djärv <jan.h.d@swipnet.se>
5473
5474 * process.c: Include ifaddrs.h and net/if_dl.h if available (Bug#8477).
5475 (Fnetwork_interface_list): Allocate in increments of bytes instead
5476 of sizeof (struct ifreq). Iterate over ifconf.ifc_req by counting
5477 bytes (Bug#8477). Count bytes correctly when ifr_addr is a struct
5478 sockaddr.
5479 (struct ifflag_def): notrailers is smart on OSX.
5480 (Fnetwork_interface_info): Handle case when ifr_flags is negative.
5481 Get hardware address with getifaddrs if available.
5482
08fff70c
EZ
54832011-08-12 Eli Zaretskii <eliz@gnu.org>
5484
5485 * xdisp.c (iterate_out_of_display_property): xassert that
5486 IT->position is set to within IT->object's boundaries. Break from
5487 the loop as soon as EOB is reached; avoids infloops in redisplay
8b76d6f8
SM
5488 when IT->position is set up wrongly due to some bug.
5489 Set IT->current to match the bidi iterator unconditionally.
08fff70c
EZ
5490 (push_display_prop): Allow GET_FROM_STRING as IT->method on
5491 entry. Force push_it to save on the stack the current
5492 buffer/string position, to be restored by pop_it. Fix flags in
5493 the iterator structure wrt the object coming from a display
5494 property, as `line-prefix' and `wrap-prefix' are not ``replacing''
5495 properties. (Bug#9284)
5496
7be1c708 54972011-08-09 Andreas Schwab <schwab@linux-m68k.org>
aac0c6e3 5498
7be1c708
CY
5499 * fontset.c (fontset_get_font_group): Add proper type checks.
5500 (Bug#9172)
aac0c6e3 5501
7be1c708 55022011-08-09 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
aac0c6e3 5503
7be1c708
CY
5504 * unexmacosx.c (print_load_command_name): Add cases LC_FUNCTION_STARTS
5505 and LC_VERSION_MIN_MACOSX.
5506 (copy_linkedit_data) [LC_FUNCTION_STARTS]: New function.
5507 (dump_it) [LC_FUNCTION_STARTS]: Use it.
aac0c6e3 5508
97bb72a6
EZ
55092011-08-08 Eli Zaretskii <eliz@gnu.org>
5510
5511 * xdisp.c (forward_to_next_line_start): Allow to use the
8b76d6f8
SM
5512 no-display-properties-and-no-overlays under bidi display.
5513 Set disp_pos in the bidi iterator to avoid searches for display
757664a4 5514 properties and overlays.
97bb72a6 5515
d5617611
CY
55162011-08-08 Chong Yidong <cyd@stupidchicken.com>
5517
37e11a63
CY
5518 * editfns.c (Fset_time_zone_rule): Document relationship with the
5519 setenv function.
5520
d5617611
CY
5521 * ftfont.c (ftfont_pattern_entity): Copy the extras argument to
5522 the font entity extracted from the cache (Bug#8109).
5523
58872834
CY
55242011-08-07 Chong Yidong <cyd@stupidchicken.com>
5525
5526 * composite.c (autocmp_chars): Don't reset point. That is done by
5527 restore_point_unwind (Bug#5984).
5528
75bfc667
JL
55292011-08-07 Juri Linkov <juri@jurta.org>
5530
5531 * editfns.c (Fformat_time_string): Doc fix, add tag `usage:'
5532 to show the arg `TIME' instead of `TIMEVAL'.
5533
d1410150
EZ
55342011-08-06 Eli Zaretskii <eliz@gnu.org>
5535
5536 * xdisp.c (set_cursor_from_row): Fix cursor positioning when a
5537 display property strides EOL and includes a newline, as in
5538 longlines-mode. (Bug#9254)
75b771e4
EZ
5539 (move_it_in_display_line_to): Fix vertical-motion in a buffer with
5540 word-wrap under bidirectional display. (Bug#9224)
d1410150
EZ
5541
5542 * bidi.c (bidi_unshelve_cache): Don't reset the cache if JUST_FREE
5543 is non-zero, even if the data buffer is NULL. Fixes a crash in
5544 vertical-motion with longlines-mode. (Bug#9254)
5545
35928349
EZ
55462011-08-05 Eli Zaretskii <eliz@gnu.org>
5547
ec7cc85b
EZ
5548 * bidi.c <bidi_cache_total_alloc>: Now static.
5549 (bidi_initialize): Initialize bidi_cache_total_alloc.
5550
8b76d6f8 5551 * xdisp.c (display_line): Release buffer allocated for shelved bidi
35928349
EZ
5552 cache. (Bug#9221)
5553
5554 * bidi.c (bidi_shelve_cache, bidi_unshelve_cache): Track total
5555 amount allocated this far in `bidi_cache_total_alloc'.
5556 (bidi_unshelve_cache): Accept an additional argument JUST_FREE; if
5557 non-zero, only free the data buffer without restoring the cache
5558 contents. All callers changed.
5559
5560 * dispextern.h (bidi_unshelve_cache): Update prototype.
5561
5562 * xdisp.c (SAVE_IT, pos_visible_p, move_it_in_display_line_to)
5563 (move_it_in_display_line, move_it_to)
5564 (move_it_vertically_backward, move_it_by_lines): Replace the call
5565 to xfree to an equivalent call to bidi_unshelve_cache.
5566 (move_it_in_display_line_to): Fix logic of returning
412b6358 5567 MOVE_POS_MATCH_OR_ZV in the bidi case. (Bug#9224)
35928349 5568
e2e2423b
EZ
55692011-08-05 Eli Zaretskii <eliz@gnu.org>
5570
5571 * xdisp.c (set_cursor_from_row): Prefer the candidate glyph that
5572 came from a string character with a `cursor' property. (Bug#9229)
5573
ae9e757a
JD
55742011-08-04 Jan Djärv <jan.h.d@swipnet.se>
5575
5576 * Makefile.in (LIB_PTHREAD): New variable.
5577 (LIBES): Add LIB_PTHREAD (Bug#9216).
5578
5579 * alloc.c, emacs.c, gmalloc.c, gtkutil.c, keyboard.c, syssignal.h:
5580 Rename HAVE_GTK_AND_PTHREAD to HAVE_PTHREAD (Bug#9216).
5581
213bd7f2
AS
55822011-08-04 Andreas Schwab <schwab@linux-m68k.org>
5583
6b02f655 5584 * regex.c (re_iswctype): Remove some redundant boolean conversions.
213bd7f2 5585
99aaf75f
JD
55862011-08-04 Jan Djärv <jan.h.d@swipnet.se>
5587
5588 * xterm.c (x_find_topmost_parent): New function.
5589 (x_set_frame_alpha): Find topmost parent window with
5590 x_find_topmost_parent and set the property there also (bug#9181).
5591 (handle_one_xevent): Call x_set_frame_alpha on ReparentNotify.
5592
c74e9d86
PE
55932011-08-04 Paul Eggert <eggert@cs.ucla.edu>
5594
5595 * callproc.c (Fcall_process): Avoid vfork clobbering
5596 the local vars buffer, coding_systems, current_dir.
5597
640c8776
SM
55982011-08-03 Stefan Monnier <monnier@iro.umontreal.ca>
5599
5600 * keymap.c (Fmake_composed_keymap): Move to subr.el.
5601
f26d0e4c
PE
56022011-08-03 Paul Eggert <eggert@cs.ucla.edu>
5603
8a10d76c
PE
5604 * fontset.c (dump_fontset) [FONTSET_DEBUG]: Declare EXTERNALLY_VISIBLE
5605 so that it is not optimized away.
5606
f26d0e4c
PE
5607 * xdisp.c (compute_display_string_pos): Remove unused local.
5608
55439c61
EZ
56092011-08-02 Eli Zaretskii <eliz@gnu.org>
5610
5611 Fix slow cursor motion and scrolling in large buffers with
5612 selective display, like Org Mode buffers. (Bug#9218)
5613
5614 * dispextern.h (struct bidi_it): New member disp_prop_p.
5615
5616 * xdisp.c: Remove one-slot cache of display string positions.
5617 (compute_display_string_pos): Accept an additional argument
5e617bc2 5618 DISP_PROP_P; callers changed. Scan at most 5K characters forward
55439c61
EZ
5619 for a display string or property. If found, set DISP_PROP_P
5620 non-zero.
5621
5622 * bidi.c (bidi_fetch_char): Accept an additional argument
640c8776
SM
5623 DISP_PROP_P, and pass it to compute_display_string_pos.
5624 Only handle text covered by a display string if DISP_PROP_P is returned
55439c61
EZ
5625 non-zero. All callers of bidi_fetch_char changed.
5626
fb33fa43
SM
56272011-08-02 Stefan Monnier <monnier@iro.umontreal.ca>
5628
5629 * keymap.c (Fdefine_key): Fix Lisp_Object/int mixup; apply some CSE.
5630
b099e063
DM
56312010-12-03 Don March <don@ohspite.net>
5632
5633 * keymap.c (Fdefine_key): Fix non-prefix key error message when
5634 last character M-[char] is translated to ESC [char] (bug#7541).
5635
5cc7f7af
KH
56362011-08-02 Kenichi Handa <handa@m17n.org>
5637
d0fffa3f 5638 * lisp.h (uniprop_table): Extern it.
5cc7f7af
KH
5639
5640 * chartab.c (uniprop_table): Make it non-static.
5641
525d5e6e
EZ
56422011-08-01 Eli Zaretskii <eliz@gnu.org>
5643
5644 * xdisp.c (forward_to_next_line_start): Accept additional argument
5645 BIDI_IT_PREV, and store into it the state of the bidi iterator had
5646 on the newline.
5647 (reseat_at_next_visible_line_start): Use the bidi iterator state
5648 returned by forward_to_next_line_start to restore the state of
5649 it->bidi_it after backing up to previous newline. (Bug#9212)
5650
31011111
AS
56512011-07-30 Andreas Schwab <schwab@linux-m68k.org>
5652
5653 * regex.c (re_comp): Protoize.
5654 (re_exec): Fix return type.
5655 (regexec): Fix type of `ret'. (Bug#9203)
5656
476371c4
PE
56572011-07-28 Paul Eggert <eggert@cs.ucla.edu>
5658
e5d76069
PE
5659 * image.c (check_image_size): Use 1024x1024 if unknown frame (Bug#9189).
5660 This is needed if max-image-size is a floating-point number.
5661
9a79b20c
AS
56622011-07-28 Andreas Schwab <schwab@linux-m68k.org>
5663
5664 * print.c (print_object): Print empty symbol as ##.
5665
5666 * lread.c (read1): Read ## as empty symbol.
5667
d8c2fa78
AA
56682011-07-28 Alp Aker <alp.tekin.aker@gmail.com>
5669
5670 * nsfns.m (x_set_foreground_color): Set f->foreground_pixel when
5671 setting frame foreground color (Bug#9175).
5672 (x_set_background_color): Likewise.
5673
ffe57a7a
AA
5674 * nsmenu.m (-setText): Size tooltip dimensions precisely to
5675 contents (Bug#9176).
5676 (EmacsTooltip -init): Remove bezels and add shadows to
5677 tooltip windows.
5678
bf3492a5
AA
5679 * nsterm.m (ns_dumpglyphs_stretch): Avoid overwriting left fringe
5680 or scroll bar (Bug#8470).
5681
d55e9c53
AA
5682 * nsfont.m (nsfont_open): Remove assignment to voffset and
5683 unnecessary vars hshink, expand, hd, full_height, min_height.
5684 (nsfont_draw): Use s->ybase as baseline for glyph drawing (Bug#8913).
5685
5686 * nsterm.h (nsfont_info): Remove voffset field.
5687
d8c2fa78 56882011-07-28 Alp Aker <alp.tekin.aker@gmail.com>
4843aac3
AA
5689
5690 Implement strike-through and overline on NextStep (Bug#8863).
5691
5692 * nsfont.m (nsfont_open): Use underline position provided by font,
5693 instead of hard-coded value of 2.
5694 (nsfont_draw): Call ns_draw_text_decoration instead.
5695
5696 * nsterm.h: Add declaration for ns_draw_text_decoration.
5697
5698 * nsterm.m (ns_draw_text_decoration): New function for drawing
5699 underline, overline, and strike-through.
5700 (ns_dumpglyphs_image, ns_dumpglyphs_stretch): Add call to
5701 ns_draw_text_decoration. Change treatment of cursor drawing to
8d5ed899 5702 accommodate underlining, etc.
4843aac3 5703
4cc60b9b
EZ
57042011-07-28 Eli Zaretskii <eliz@gnu.org>
5705
bc7ece87
EZ
5706 * buffer.c (init_buffer_once): Set bidi-display-reordering to t by
5707 default.
4cc60b9b 5708
476371c4
PE
57092011-07-28 Paul Eggert <eggert@cs.ucla.edu>
5710
66606eea
PE
5711 * alloc.c (memory_full) [!SYNC_INPUT]: Fix signal-related race.
5712 Without this fix, if a signal arrives just after memory fills up,
5713 'malloc' might be invoked reentrantly.
5714
476371c4
PE
5715 * image.c (x_check_image_size) [!HAVE_X_WINDOWS]: Return 1.
5716 In other words, assume that every image size is allowed, on non-X
5717 hosts. This assumption is probably wrong, but it lets Emacs compile.
5718
f3fcc40d
AS
57192011-07-28 Andreas Schwab <schwab@linux-m68k.org>
5720
5721 * regex.c (re_iswctype): Convert return values to boolean.
5722
350c992f
EZ
57232011-07-28 Eli Zaretskii <eliz@fencepost.gnu.org>
5724
5725 * xdisp.c (compute_display_string_pos): Don't use cached display
5726 string position if the buffer had its restriction changed.
5727 (Bug#9184)
5728
5266b4bb
PE
57292011-07-28 Paul Eggert <eggert@cs.ucla.edu>
5730
5731 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork clobbering.
5732
2573a837 57332011-07-28 Paul Eggert <eggert@cs.ucla.edu>
ca4aa935 5734
41f55ccd 5735 Integer signedness and overflow and related fixes. (Bug#9079)
cf950e6b 5736
39e378da
PE
5737 * bidi.c: Integer size and overflow fixes.
5738 (bidi_cache_size, bidi_cache_idx, bidi_cache_last_idx)
5739 (bidi_cache_start, bidi_cache_fetch_state, bidi_cache_search)
5740 (bidi_cache_find_level_change, bidi_cache_ensure_space)
5741 (bidi_cache_iterator_state, bidi_cache_find, bidi_cache_start_stack)
5742 (bidi_find_other_level_edge):
5743 Use ptrdiff_t instead of EMACS_INT where either will do.
5744 This works better on 32-bit hosts configured --with-wide-int.
5745 (bidi_cache_ensure_space): Check for size-calculation overflow.
5746 Use % rather than repeated addition, for better worst-case speed.
5747 Don't set bidi_cache_size until after xrealloc returns, because it
5748 might not return.
5749 (bidi_dump_cached_states): Use ptrdiff_t, not int, to avoid overflow.
f0eb61e9
PE
5750 (bidi_cache_ensure_space): Also check that the bidi cache size
5751 does not exceed that of the largest Lisp string or buffer. See Eli
5752 Zaretskii in <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=9079#29>.
39e378da 5753
5e927815
PE
5754 * alloc.c (__malloc_size_t): Remove.
5755 All uses replaced by size_t. See Andreas Schwab's note
5756 <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=9079#8>.
5757
ca4aa935
PE
5758 * image.c: Improve checking for integer overflow.
5759 (check_image_size): Assume that f is nonnull, since
5760 it is always nonnull in practice. This is one less thing to
5761 worry about when checking for integer overflow later.
5762 (x_check_image_size): New function, which checks for integer
5763 overflow issues inside X.
5764 (x_create_x_image_and_pixmap, xbm_read_bitmap_data): Use it.
5765 This removes the need for a memory_full check.
5766 (xbm_image_p): Rewrite to avoid integer multiplication overflow.
5767 (Create_Pixmap_From_Bitmap_Data, xbm_load): Use x_check_image_size.
5768 (xbm_read_bitmap_data): Change locals back to 'int', since
5769 their values must fit in 'int'.
5770 (xpm_load_image, png_load, tiff_load):
5771 Invoke x_create_x_image_and_pixmap earlier,
5772 to avoid much needless work if the image is too large.
5773 (tiff_load): Treat overly large images as if
5774 x_create_x_image_and_pixmap failed, not as malloc failures.
5775 (gs_load): Use x_check_image_size.
5776
5f8f9cc2
PE
5777 * gtkutil.c: Omit integer casts.
5778 (xg_get_pixbuf_from_pixmap): Remove unnecessary cast.
5779 (xg_set_toolkit_scroll_bar_thumb): Rewrite to avoid need for cast.
5780
5adf60bc
PE
5781 * image.c (png_load): Don't assume height * row_bytes fits in 'int'.
5782
c8907a93
PE
5783 * xfaces.c (Fbitmap_spec_p): Fix integer overflow bug.
5784 Without this fix, (bitmap-spec-p '(34359738368 1 "x"))
5785 would wrongly return t on a 64-bit host.
5786
e3c25c68
PE
5787 * dispnew.c (init_display): Use *_RANGE_OVERFLOW macros.
5788 The plain *_OVERFLOW macros run afoul of GCC bug 49705
5789 <http://gcc.gnu.org/bugzilla/show_bug.cgi?id=49705>
5790 and therefore cause GCC to emit a bogus diagnostic in some cases.
5791
3f791afe
PE
5792 * image.c: Integer signedness and overflow and related fixes.
5793 This is not an exhaustive set of fixes, but it's time to
5794 record what I've got.
5795 (lookup_pixel_color, check_image_size): Remove redundant decls.
5796 (check_image_size): Don't assume that arbitrary EMACS_INT values
5797 fit in 'int', or that arbitrary 'double' values fit in 'int'.
5798 (x_alloc_image_color, x_create_x_image_and_pixmap, png_load)
5799 (tiff_load, imagemagick_load_image):
5800 Check for overflow in size calculations.
5801 (x_create_x_image_and_pixmap): Remove unnecessary test for
5802 xmalloc returning NULL; that can't happen.
5803 (xbm_read_bitmap_data): Don't assume sizes fit into 'int'.
5804 (xpm_color_bucket): Use better integer hashing function.
5805 (xpm_cache_color): Don't possibly over-allocate memory.
5806 (struct png_memory_storage, tiff_memory_source, tiff_seek_in_memory)
5807 (gif_memory_source):
5808 Use ptrdiff_t, not int or size_t, to record sizes.
5809 (png_load): Don't assume values greater than 2**31 fit in 'int'.
5810 (our_stdio_fill_input_buffer): Prefer ptrdiff_t to size_t when
5811 either works, as we prefer signed integers.
5812 (tiff_read_from_memory, tiff_write_from_memory):
5813 Return tsize_t, not size_t, since that's what the TIFF API wants.
5814 (tiff_read_from_memory): Don't fail simply because the read would
5815 go past EOF; instead, return a short read.
5816 (tiff_load): Omit no-longer-needed casts.
5817 (Fimagemagick_types): Don't assume size fits into 'int'.
5818
3cc5a532
PE
5819 Improve hashing quality when configured --with-wide-int.
5820 * fns.c (hash_string): New function, taken from sxhash_string.
5821 Do not discard information about ASCII character case; this
5822 discarding is no longer needed.
5823 (sxhash-string): Use it. Change sig to match it. Caller changed.
5824 * lisp.h: Declare it.
5825 * lread.c (hash_string): Remove, since we now use fns.c's version.
5826 The fns.c version returns a wider integer if --with-wide-int is
5827 specified, so this should help the quality of the hashing a bit.
5828
b312a492
PE
5829 * emacs.c: Integer overflow minor fix.
5830 (heap_bss_diff): Now uprintmax_t, not unsigned long. All used changed.
5831 Define only if GNU_LINUX.
5832 (main, Fdump_emacs): Set and use heap_bss_diff only if GNU_LINUX.
5833
dfd153ae
PE
5834 * dispnew.c: Integer signedness and overflow fixes.
5835 Remove unnecessary forward decls, that were a maintenance hassle.
5836 (history_tick): Now uprintmax_t, so it's more likely to avoid overflow.
5837 All uses changed.
5838 (adjust_glyph_matrix, realloc_glyph_pool, adjust_frame_message_buffer)
5839 (scrolling_window): Use ptrdiff_t, not int, for byte count.
5840 (prepare_desired_row, line_draw_cost):
5841 Use int, not unsigned, where either works.
5842 (save_current_matrix, restore_current_matrix):
5843 Use ptrdiff_t, not size_t, where either works.
5844 (init_display): Check for overflow more accurately, and without
5845 relying on undefined behavior.
5846
a81d11a3
PE
5847 * editfns.c (pWIDE, pWIDElen, signed_wide, unsigned_wide):
5848 Remove, replacing with the new symbols in lisp.h. All uses changed.
5849 * fileio.c (make_temp_name):
5850 * filelock.c (lock_file_1, lock_file):
5851 * xdisp.c (message_dolog):
5852 Don't assume PRIdMAX etc. works; this isn't portable to pre-C99 hosts.
5853 Use pMd etc. instead.
5854 * lisp.h (printmax_t, uprintmax_t, pMd, pMu): New types and macros,
5855 replacing the pWIDE etc. symbols removed from editfns.c.
5856
3300e6fd
PE
5857 * keyboard.h (num_input_events): Now uintmax_t.
5858 This is (very slightly) less likely to mess up due to wraparound.
5859 All uses changed.
5860
fd05c7e9
PE
5861 * buffer.c: Integer signedness fixes.
5862 (alloc_buffer_text, enlarge_buffer_text):
5863 Use ptrdiff_t rather than size_t when either will do, as we prefer
5864 signed integers.
5865
903fe15d
PE
5866 * alloc.c: Integer signedness and overflow fixes.
5867 Do not impose an arbitrary 32-bit limit on malloc sizes when debugging.
5868 (__malloc_size_t): Default to size_t, not to int.
5869 (pure_size, pure_bytes_used_before_overflow, stack_copy_size)
5870 (Fgarbage_collect, mark_object_loop_halt, mark_object):
5871 Prefer ptrdiff_t to size_t when either would do, as we prefer
5872 signed integers.
5873 (XMALLOC_OVERRUN_CHECK_OVERHEAD): New macro.
5874 (xmalloc_overrun_check_header, xmalloc_overrun_check_trailer):
5875 Now const. Initialize with values that are in range even if char
5876 is signed.
5877 (XMALLOC_PUT_SIZE, XMALLOC_GET_SIZE): Remove, replacing with ...
5878 (xmalloc_put_size, xmalloc_get_size): New functions. All uses changed.
5879 These functions do the right thing with sizes > 2**32.
5880 (check_depth): Now ptrdiff_t, not int.
5881 (overrun_check_malloc, overrun_check_realloc, overrun_check_free):
5882 Adjust to new way of storing sizes. Check for size overflow bugs
5883 in rest of code.
5884 (STRING_BYTES_MAX): Adjust to new overheads. The old code was
5885 slightly wrong anyway, as it missed one instance of
5886 XMALLOC_OVERRUN_CHECK_OVERHEAD.
5887 (refill_memory_reserve): Omit needless cast to size_t.
5888 (mark_object_loop_halt): Mark as externally visible.
5889
ac82cc6a
PE
5890 * xselect.c: Integer signedness and overflow fixes.
5891 (Fx_register_dnd_atom, x_handle_dnd_message):
5892 Use ptrdiff_t, not size_t, since we prefer signed.
5893 (Fx_register_dnd_atom): Check for ptrdiff_t (and size_t) overflow.
5894 * xterm.h (struct x_display_info): Use ptrdiff_t, not size_t, for
5895 x_dnd_atoms_size and x_dnd_atoms_length.
5896
c2d1e36d
PE
5897 * doprnt.c: Prefer signed to unsigned when either works.
5898 * eval.c (verror):
5899 * doprnt.c (doprnt):
5900 * lisp.h (doprnt):
5901 * xdisp.c (vmessage):
5902 Use ptrdiff_t, not size_t, when using or implementing doprnt,
5903 since the sizes cannot exceed ptrdiff_t bounds anyway, and we
5904 prefer signed arithmetic to avoid comparison confusion.
5905 * doprnt.c (doprnt): Avoid a "+ 1" that can't overflow,
5906 but is a bit tricky.
5907
0e926e56
PE
5908 Assume freestanding C89 headers, string.h, stdlib.h.
5909 * data.c, doprnt.c, floatfns.c, print.c:
5910 Include float.h unconditionally.
5911 * gmalloc.c: Assume C89-at-least behavior for preprocessor,
5912 limits.h, stddef.h, string.h. Use memset instead of 'flood'.
5913 * regex.c: Likewise for stddef.h, string.h.
5914 (ISASCII): Remove; can assume it returns 1 now. All uses removed.
5915 * s/aix4-2.h (HAVE_STRING_H): Remove obsolete undef.
5916 * s/ms-w32.h (HAVE_LIMITS_H, HAVE_STRING_H, HAVE_STDLIB_H)
5917 (STDC_HEADERS): Remove obsolete defines.
5918 * sysdep.c: Include limits.h unconditionally.
5919
9cfdb3ec
PE
5920 Assume support for memcmp, memcpy, memmove, memset.
5921 * lisp.h, sysdep.c (memcmp, memcpy, memmove, memset):
5922 * regex.c (memcmp, memcpy):
5923 Remove; we assume C89 now.
5924
5925 * gmalloc.c (memcpy, memset, memmove): Remove; we assume C89 now.
5926 (__malloc_safe_bcopy): Remove; no longer needed.
5927
cf950e6b 5928 * lisp.h (struct vectorlike_header, struct Lisp_Subr): Signed sizes.
6089c567
PE
5929 Use EMACS_INT, not EMACS_UINT, for sizes. The code works equally
5930 well either way, and we prefer signed to unsigned.
5931
dbf38e02
LMI
59322011-07-27 Lars Magne Ingebrigtsen <larsi@gnus.org>
5933
5934 * gnutls.c (emacs_gnutls_read): Don't message anything if the peer
5935 closes the connection while we're reading (bug#9182).
5936
d6f0886c 59372011-07-25 Jan Djärv <jan.h.d@swipnet.se>
24e0f6b1 5938
d6f0886c
JD
5939 * nsmenu.m (ns_popup_dialog): Add an "ok" button if no buttons
5940 are specified (Bug#9168).
24e0f6b1 5941
2eb1f9e6
PE
59422011-07-25 Paul Eggert <eggert@cs.ucla.edu>
5943
5944 * bidi.c (bidi_dump_cached_states): Fix printf format mismatch.
5945 Found by GCC static checking and --with-wide-int on a 32-bit host.
5946
22381272 59472011-07-25 Eli Zaretskii <eliz@gnu.org>
7daee910
EZ
5948
5949 * xdisp.c (compute_display_string_pos): Fix logic of caching
5950 previous display string position. Initialize cached_prev_pos to
5951 -1. Fixes slow-down at the beginning of a buffer.
5952
f25e39b4
EZ
59532011-07-24 Eli Zaretskii <eliz@gnu.org>
5954
5955 * xfaces.c (check_lface_attrs) [HAVE_WINDOW_SYSTEM]: Allow `nil'
5956 for attrs[LFACE_FONTSET_INDEX].
5957
04c4b52e
PE
59582011-07-23 Paul Eggert <eggert@cs.ucla.edu>
5959
5960 * xml.c (parse_region): Remove unused local
5961 that was recently introduced.
5962
c1734fbd
EZ
59632011-07-23 Eli Zaretskii <eliz@gnu.org>
5964
be18c5a5
EZ
5965 * xfns.c (unwind_create_frame) [GLYPH_DEBUG]: Adapt to changes in
5966 2008-02-22T17:42:09Z!monnier@iro.umontreal.ca.
5967
c1734fbd
EZ
5968 * xdisp.c (move_it_in_display_line_to): Record the best matching
5969 position for TO_CHARPOS while scanning the line, and restore it on
640c8776
SM
5970 exit if none of the characters scanned was an exact match.
5971 Fixes vertical-motion and pos-visible-in-window-p under bidi redisplay
a9269c18
EZ
5972 when exact match is impossible due to invisible text, and the
5973 lines are truncated.
5974
a258d627
JD
59752011-07-23 Jan Djärv <jan.h.d@swipnet.se>
5976
5977 * nsterm.m (initFrameFromEmacs): Set NSTitledWindowMask in styleMask
5978 for OSX >= 10.7.
5979
b6d5a689
EZ
59802011-07-22 Eli Zaretskii <eliz@gnu.org>
5981
0f74f785
EZ
5982 Fix a significant slow-down of cursor motion with C-n, C-p,
5983 C-f/C-b, and C-v/M-v that couldn't keep up with keyboard
5984 auto-repeat under bidi redisplay in fontified buffers.
b6d5a689 5985 * xdisp.c (compute_stop_pos_backwards): New function.
b6d5a689
EZ
5986 (next_element_from_buffer): Call compute_stop_pos_backwards to
5987 find a suitable prev_stop when we find ourselves before
0f74f785
EZ
5988 base_level_stop.
5989 (reseat): Don't look for prev_stop, as that could mean a very long
5990 run.
5991 <cached_disp_pos, cached_disp_buffer, cached_disp_modiff>
5992 <cached_disp_overlay_modiff>: Cache for last found display string
5993 position.
551918c1 5994 (compute_display_string_pos): Return the cached position if asked
0f74f785
EZ
5995 about the same buffer in the same area of character positions, and
5996 the buffer wasn't changed since the time the display string
5997 position was cached.
551918c1 5998
b2d0c91a
EZ
59992011-07-22 Eli Zaretskii <eliz@gnu.org>
6000
6001 * xdisp.c (rows_from_pos_range): Don't ignore glyphs whose object
6002 is an integer, which is important for empty lines. (Bug#9149)
6003
043604ee
CY
60042011-07-22 Chong Yidong <cyd@stupidchicken.com>
6005
6006 * frame.c (Fmodify_frame_parameters): In tty case, update the
6007 default face if necessary (Bug#4238).
6008
da4adb04
CY
60092011-07-21 Chong Yidong <cyd@stupidchicken.com>
6010
6011 * editfns.c (Fstring_to_char): No need to explain what a character
6012 is in the docstring (Bug#6576).
6013
9abd0532
LMI
60142011-07-20 Lars Magne Ingebrigtsen <larsi@gnus.org>
6015
6016 * xml.c (parse_region): Make sure we always return a tree.
6017
36881d16
HK
60182011-07-20 HAMANO Kiyoto <khiker.mail@gmail.com>
6019
6020 * xml.c (parse_region): If a document contains only comments,
6021 return that, too.
6022
1e98674d
LMI
60232011-07-20 Lars Magne Ingebrigtsen <larsi@gnus.org>
6024
6025 * xml.c (make_dom): Return comments, too.
6026
590bd467
PE
60272011-07-19 Paul Eggert <eggert@cs.ucla.edu>
6028
6029 Port to OpenBSD.
6030 See http://lists.gnu.org/archive/html/emacs-devel/2011-07/msg00688.html
6031 and the surrounding thread.
6032 * minibuf.c (read_minibuf_noninteractive): Rewrite to use getchar
6033 rather than fgets, and retry after EINTR. Otherwise, 'emacs
6034 --batch -f byte-compile-file' fails on OpenBSD if an inactivity
6035 timer goes off.
6036 * s/openbsd.h (BROKEN_SIGIO): Define.
6037 * unexelf.c (unexec) [__OpenBSD__]:
6038 Don't update the .mdebug section of the Alpha COFF symbol table.
6039
f41628b2
LMI
60402011-07-19 Lars Magne Ingebrigtsen <larsi@gnus.org>
6041
6042 * lread.c (syms_of_lread): Clarify when `lexical-binding' is used
6043 (bug#8460).
6044
b59b67c5
PE
60452011-07-18 Paul Eggert <eggert@cs.ucla.edu>
6046
15e3a074
PE
6047 * fileio.c (Fcopy_file) [!MSDOS]: Tighten created file's mask.
6048 This fixes some race conditions on the permissions of any newly
6049 created file.
6050
41bed37d
PE
6051 * alloc.c (valid_pointer_p): Use pipe, not open.
6052 This fixes some permissions issues when debugging.
6053
b59b67c5
PE
6054 * fileio.c (Fcopy_file): Adjust mode if fchown fails. (Bug#9002)
6055 If fchown fails to set both uid and gid, try to set just gid,
6056 as that is sometimes allowed. Adjust the file's mode to eliminate
6057 setuid or setgid bits that are inappropriate if fchown fails.
6058
925a6be7
SM
60592011-07-18 Stefan Monnier <monnier@iro.umontreal.ca>
6060
6061 * xdisp.c (next_element_from_string, next_element_from_buffer): Use EQ
6062 to compare Lisp_Objects.
6063 * gnutls.c (syms_of_gnutls): Rename Vgnutls_log_level to
6064 global_gnutls_log_level, don't mistake it for a Lisp_Object.
6065 (init_gnutls_functions, emacs_gnutls_handle_error): Fix up uses.
6066
52968808
AS
60672011-07-17 Andreas Schwab <schwab@linux-m68k.org>
6068
0a6a104b
AS
6069 * lread.c (read_integer): Unread even EOF character.
6070 (read1): Likewise. Properly record start position of symbol.
6071
52968808
AS
6072 * lread.c (read1): Read `#:' as empty uninterned symbol if no
6073 symbol character follows.
6074
9e381cdd
PE
60752011-07-17 Paul Eggert <eggert@cs.ucla.edu>
6076
6077 * fileio.c (Fcopy_file): Pacify gcc re fchown. (Bug#9002)
6078 This works around a problem with the previous change to Fcopy_file.
6079 Recent glibc declares fchown with __attribute__((warn_unused_result)),
6080 and without this change, GCC might complain about discarding
6081 fchown's return value.
6082
b5641435
JB
60832011-07-16 Juanma Barranquero <lekktu@gmail.com>
6084
6085 * makefile.w32-in (GLOBAL_SOURCES): Add gnutls.c (followup to bug#9059).
6086
a8031457
PE
60872011-07-16 Paul Eggert <eggert@cs.ucla.edu>
6088
6089 * fileio.c (Fcopy_file): Don't diagnose fchown failures. (Bug#9002)
6090
dd889327
LMI
60912011-07-16 Lars Magne Ingebrigtsen <larsi@gnus.org>
6092
750c33f7
LMI
6093 * gnutls.c (syms_of_gnutls): Define `gnutls-log-level' here, since
6094 it's used from the C level.
6095
dd889327
LMI
6096 * process.c: Use the same condition for POLL_FOR_INPUT in both
6097 keyboard.c and process.c (bug#1858).
6098
87e86684
LM
60992011-07-09 Lawrence Mitchell <wence@gmx.li>
6100
6101 * gnutls.c (Qgnutls_bootprop_min_prime_bits): New variable.
6102 (Fgnutls_boot): Use it.
6103
64348f40
AS
61042011-07-15 Andreas Schwab <schwab@linux-m68k.org>
6105
6106 * doc.c (Fsubstitute_command_keys): Revert last change.
6107
1d698799
LMI
61082011-07-15 Lars Magne Ingebrigtsen <larsi@gnus.org>
6109
f863868c
LMI
6110 * doc.c (Fsubstitute_command_keys): Clarify that \= really only
6111 quotes the next character, and doesn't affect other longer
6112 sequences (bug#8935).
6113
1d698799
LMI
6114 * lread.c (syms_of_lread): Clarify that is isn't only
6115 `eval-buffer' and `eval-defun' that's affected by
6116 `lexical-binding' (bug#8460).
6117
aa4b6df6
EZ
61182011-07-15 Eli Zaretskii <eliz@gnu.org>
6119
6120 * xdisp.c (move_it_in_display_line_to): Fix vertical motion with
6b02f655 6121 bidi redisplay when a line includes both an image and is truncated.
aa4b6df6 6122
5d856da6
PE
61232011-07-14 Paul Eggert <eggert@cs.ucla.edu>
6124
ad6042bb
PE
6125 Fix minor problems found by static checking.
6126 * bidi.c (bidi_cache_size): Now EMACS_INT, not size_t.
6127 (elsz): Now a signed constant, not a size_t var. We prefer signed
6128 types to unsigned, to avoid integer comparison confusion. Without
6129 this change, GCC 4.6.1 with -Wunsafe-loop-optimizations complains
6130 "cannot optimize loop, the loop counter may overflow", a symptom
6131 of the confusion.
f00bbb22 6132 * indent.c (Fvertical_motion): Mark locals as initialized.
5d856da6
PE
6133 * xdisp.c (reseat_to_string): Fix pointer signedness issue.
6134
6468f31c
LMI
61352011-07-14 Lars Magne Ingebrigtsen <larsi@gnus.org>
6136
49080b10
LMI
6137 * search.c (Fre_search_backward): Mention `case-fold-search' in
6138 all the re_search_* functions (bug#8138).
6139
6468f31c
LMI
6140 * keyboard.c (Fopen_dribble_file): Document when the file is
6141 closed (bug#8056).
6142
c965adc5
EZ
61432011-07-14 Eli Zaretskii <eliz@gnu.org>
6144
df9733bf
EZ
6145 * bidi.c (bidi_dump_cached_states): Fix format of displaying
6146 bidi_cache_idx.
6147
0bb23927
EZ
6148 Support bidi reordering of display and overlay strings.
6149 * xdisp.c (compute_display_string_pos)
6150 (compute_display_string_end): Accept additional argument STRING.
6151 (init_iterator, reseat_1): Initialize bidi_it->string.s to NULL.
6152 (reseat_to_string): Initialize bidi_it->string.s and
6153 bidi_it->string.schars.
6154 (Fcurrent_bidi_paragraph_direction): Initialize itb.string.s to
640c8776
SM
6155 NULL (avoids a crash in bidi_paragraph_init).
6156 Initialize itb.string.lstring.
0bb23927
EZ
6157 (init_iterator): Call bidi_init_it only of a valid
6158 buffer position was specified. Initialize paragraph_embedding to
6159 L2R.
6160 (reseat_to_string): Initialize the bidi iterator.
6161 (display_string): If we need to ignore text properties of
6162 LISP_STRING, set IT->stop_charpos to IT->end_charpos. (The
6163 original value of -1 will not work with bidi.)
6164 (compute_display_string_pos): First arg is now struct
6165 `text_pos *'; all callers changed. Support display properties on
6166 Lisp strings.
6167 (compute_display_string_end): Support display properties on Lisp
6168 strings.
6169 (init_iterator, reseat_1, reseat_to_string): Initialize the
6170 string.bufpos member to 0 (zero, for compatibility with IT_CHARPOS
6171 when iterating on a string not from display properties).
640c8776
SM
6172 (compute_display_string_pos, compute_display_string_end):
6173 Fix calculation of the object to scan. Fixes an error when using
0bb23927
EZ
6174 arrow keys.
6175 (next_element_from_buffer): Don't abort when IT_CHARPOS is before
640c8776
SM
6176 base_level_stop; instead, set base_level_stop to BEGV.
6177 Fixes crashes in vertical-motion.
0bb23927
EZ
6178 (next_element_from_buffer): Improve commentary for when
6179 the iterator is before prev_stop.
6180 (init_iterator): Initialize bidi_p from the default value of
6181 bidi-display-reordering, not from buffer-local value. Use the
6182 buffer-local value only if initializing for buffer iteration.
6183 (handle_invisible_prop): Support invisible properties on strings
6184 that are being bidi-reordered.
6185 (set_iterator_to_next): Support bidi reordering of C strings and
6186 Lisp strings.
6187 (next_element_from_string): Support bidi reordering of Lisp
6188 strings.
6189 (handle_stop_backwards): Support Lisp strings as well.
640c8776
SM
6190 (display_string): Support display of R2L glyph rows.
6191 Use IT_STRING_CHARPOS when displaying from a Lisp string.
0bb23927
EZ
6192 (init_iterator): Don't initialize it->bidi_p for strings
6193 here.
6194 (reseat_to_string): Initialize it->bidi_p for strings here.
6195 (next_element_from_string, next_element_from_c_string)
6196 (next_element_from_buffer): Add xassert's for correspondence
6197 between IT's object being iterated and it->bidi_it.string
6198 structure.
6199 (face_before_or_after_it_pos): Support bidi iteration.
6200 (next_element_from_c_string): Handle the case of the first string
6201 character that is not the first one in the visual order.
6202 (get_visually_first_element): New function, refactored from common
6203 parts of next_element_from_buffer, next_element_from_string, and
6204 next_element_from_c_string.
6205 (tool_bar_lines_needed, redisplay_tool_bar)
6206 (display_menu_bar): Force left-to-right direction. Add a FIXME
6207 comment for making that be controlled by a user option.
6208 (push_it, pop_it): Save and restore the state of the
6209 bidi iterator. Save and restore the bidi_p flag.
6210 (pop_it): Iterate out of display property for string iteration as
6211 well.
6212 (iterate_out_of_display_property): Support iteration over strings.
6213 (handle_single_display_spec): Set up it->bidi_it for iteration
6214 over a display string, and call bidi_init_it.
6215 (handle_single_display_spec, next_overlay_string)
6216 (get_overlay_strings_1, push_display_prop): Set up the bidi
6217 iterator for displaying display or overlay strings.
6218 (forward_to_next_line_start): Don't use the shortcut if
6219 bidi-iterating.
6220 (back_to_previous_visible_line_start): If handle_display_prop
6221 pushed the iterator stack, restore the internal state of the bidi
6222 iterator by calling bidi_pop_it same number of times.
6223 (reseat_at_next_visible_line_start): If ON_NEWLINE_P is non-zero,
6224 and we are bidi-iterating, don't decrement the iterator position;
6225 instead, set the first_elt flag in the bidi iterator, to produce
6226 the same effect.
6227 (reseat_1): Remove redundant setting of string_from_display_prop_p.
6228 (push_display_prop): xassert that we are iterating a buffer.
6229 (push_it, pop_it): Save and restore paragraph_embedding member.
6230 (handle_single_display_spec, next_overlay_string)
6231 (get_overlay_strings_1, reseat_1, reseat_to_string)
6232 (push_display_prop): Set up the `unibyte' member of bidi_it.string
6233 correctly. Don't assume unibyte strings are not bidi-reordered.
6234 (compute_display_string_pos)
6235 (compute_display_string_end): Fix handling the case of C string.
6236 (push_it, pop_it): Save and restore from_disp_prop_p.
6237 (handle_single_display_spec, push_display_prop): Set the
6238 from_disp_prop_p flag.
6239 (get_overlay_strings_1): Reset the from_disp_prop_p flag.
6240 (pop_it): Call iterate_out_of_display_property only if we are
6241 popping after iteration over a string that came from a display
6242 property. Fix a typo in popping stretch info. Add an assertion
6243 for verifying that the iterator position is in sync with the bidi
6244 iterator.
6245 (handle_single_display_spec, get_overlay_strings_1)
6246 (push_display_prop): Fix initialization of paragraph direction for
6247 string when that of the parent object is not yet determined.
6248 (reseat_1): Call bidi_init_it to resync the bidi
6249 iterator with IT's position. (Bug#7616)
6250 (find_row_edges): If ROW->start.pos gives position
6251 smaller than min_pos, use it as ROW->minpos. (Bug#7616)
6252 (handle_stop, back_to_previous_visible_line_start, reseat_1):
6253 Reset the from_disp_prop_p flag.
6254 (SAVE_IT, RESTORE_IT): New macros.
6255 (pos_visible_p, face_before_or_after_it_pos)
6256 (back_to_previous_visible_line_start)
6257 (move_it_in_display_line_to, move_it_in_display_line)
6258 (move_it_to, move_it_vertically_backward, move_it_by_lines)
6259 (try_scrolling, redisplay_window, display_line): Use them when
6260 saving a temporary copy of the iterator and restoring it back.
6261 (back_to_previous_visible_line_start, reseat_1)
6262 (init_iterator): Empty the bidi cache "stack".
6263 (move_it_in_display_line_to): If iterator ended up at
6264 EOL, but we never saw any buffer positions smaller than
6265 to_charpos, return MOVE_POS_MATCH_OR_ZV. Fixes vertical cursor
6266 motion in bidi-reordered lines.
6267 (move_it_in_display_line_to): Record prev_method and prev_pos
6268 immediately before the call to set_iterator_to_next. Fixes cursor
6269 motion in bidi-reordered lines with stretch glyphs and strings
6270 displayed in margins. (Bug#8133) (Bug#8867)
6271 Return MOVE_POS_MATCH_OR_ZV only if iterator position is past
6272 TO_CHARPOS.
640c8776
SM
6273 (pos_visible_p): Support positions in bidi-reordered lines.
6274 Save and restore bidi cache.
0bb23927
EZ
6275
6276 * bidi.c (bidi_level_of_next_char): clen should be EMACS_NT, not int.
6277 (bidi_paragraph_info): Delete unused struct.
6278 (bidi_cache_idx, bidi_cache_last_idx): Declare EMACS_INT.
6279 (bidi_cache_start): New variable.
6280 (bidi_cache_reset): Reset bidi_cache_idx to bidi_cache_start, not
6281 to zero.
6282 (bidi_cache_fetch_state, bidi_cache_search)
6283 (bidi_cache_find_level_change, bidi_cache_iterator_state)
6284 (bidi_cache_find, bidi_peek_at_next_level)
6285 (bidi_level_of_next_char, bidi_find_other_level_edge)
6286 (bidi_move_to_visually_next): Compare cache index with
6287 bidi_cache_start rather than with zero.
6288 (bidi_fetch_char): Accept new argument STRING; all callers
6289 changed. Support iteration over a string. Support strings with
6290 display properties. Support unibyte strings. Fix the type of
6291 `len' according to what STRING_CHAR_AND_LENGTH expects.
6292 (bidi_paragraph_init, bidi_resolve_explicit_1)
6293 (bidi_resolve_explicit, bidi_resolve_weak)
640c8776
SM
6294 (bidi_level_of_next_char, bidi_move_to_visually_next):
6295 Support iteration over a string.
0bb23927
EZ
6296 (bidi_set_sor_type, bidi_resolve_explicit_1)
6297 (bidi_resolve_explicit, bidi_type_of_next_char): ignore_bn_limit
6298 can now be zero (for strings); special values 0 and -1 were
6299 changed to -1 and -2, respectively.
6300 (bidi_char_at_pos): New function.
6301 (bidi_paragraph_init, bidi_resolve_explicit, bidi_resolve_weak):
6302 Call it instead of FETCH_MULTIBYTE_CHAR.
6303 (bidi_move_to_visually_next): Abort if charpos or bytepos were not
6304 initialized to valid values.
6305 (bidi_init_it): Don't initialize charpos and bytepos with invalid
6306 values.
6307 (bidi_level_of_next_char): Allow the sentinel "position" to pass
6308 the test for valid cached positions. Fix the logic for looking up
6309 the sentinel state in the cache. GCPRO the Lisp string we are
6310 iterating.
6311 (bidi_push_it, bidi_pop_it): New functions.
6312 (bidi_initialize): Initialize the bidi cache start stack pointer.
6313 (bidi_cache_ensure_space): New function, refactored from part of
6314 bidi_cache_iterator_state. Don't assume the required size is just
6315 one BIDI_CACHE_CHUNK away.
6316 (bidi_cache_start_stack, bidi_push_it): Use IT_STACK_SIZE.
6317 (bidi_count_bytes, bidi_char_at_pos): New functions.
6318 (bidi_cache_search): Don't assume bidi_cache_last_idx is
6319 always valid if bidi_cache_idx is valid.
6320 (bidi_cache_find_level_change): xassert that bidi_cache_last_idx
6321 is valid if it's going to be used.
6322 (bidi_shelve_cache, bidi_unshelve_cache): New functions.
6323 (bidi_cache_fetch_state, bidi_cache_search)
c965adc5
EZ
6324 (bidi_cache_find_level_change, bidi_cache_ensure_space)
6325 (bidi_cache_iterator_state, bidi_cache_find)
640c8776
SM
6326 (bidi_find_other_level_edge, bidi_cache_start_stack):
6327 All variables related to cache indices are now EMACS_INT.
c965adc5 6328
0bb23927
EZ
6329 * dispextern.h (struct bidi_string_data): New structure.
6330 (struct bidi_it): New member `string'. Make flag members be 1-bit
6331 fields, and put them last in the struct.
640c8776
SM
6332 (compute_display_string_pos, compute_display_string_end):
6333 Update prototypes.
0bb23927
EZ
6334 (bidi_push_it, bidi_pop_it): Add prototypes.
6335 (struct iterator_stack_entry): New members bidi_p,
6336 paragraph_embedding, and from_disp_prop_p.
6337 (struct it): Member bidi_p is now a bit field 1 bit wide.
640c8776
SM
6338 (bidi_shelve_cache, bidi_unshelve_cache):
6339 Declare prototypes.
0bb23927
EZ
6340
6341 * .gdbinit (xvectype, xvector, xcompiled, xchartable, xboolvector)
6342 (xpr, xfont, xbacktrace): Use "header.size" when accessing vectors
6343 and vector-like objects.
6344
6345 * dispnew.c (buffer_posn_from_coords): Save and restore the bidi
6346 cache around display iteration.
6347
6348 * window.c (Fwindow_end, window_scroll_pixel_based)
6349 (displayed_window_lines, Frecenter): Save and restore the bidi
6350 cache around display iteration.
6351
3bbd2265
LMI
63522011-07-14 Lars Magne Ingebrigtsen <larsi@gnus.org>
6353
6354 * editfns.c (Fdelete_region): Clarify the use of the named
6355 parameters (bug#6788).
6356
adc47434
MR
63572011-07-14 Martin Rudalics <rudalics@gmx.at>
6358
6359 * indent.c (Fvertical_motion): Set and restore w->pointm when
6360 saving and restoring the window's buffer (Bug#9006).
6361
837c31f8
LMI
63622011-07-13 Lars Magne Ingebrigtsen <larsi@gnus.org>
6363
6364 * editfns.c (Fstring_to_char): Clarify just what is returned
6365 (bug#6576). Text by Eli Zaretskii.
6366
ac389d0c
JB
63672011-07-13 Juanma Barranquero <lekktu@gmail.com>
6368
6369 * gnutls.c (init_gnutls_functions): Honor gnutls_log_level (bug#9059).
6370
0be0ce47
EZ
63712011-07-13 Eli Zaretskii <eliz@gnu.org>
6372
6373 * buffer.c (mmap_find): Fix a typo.
6374
cd18e7e3
JB
63752011-07-13 Johan Bockgård <bojohan@gnu.org>
6376
6377 Fix execution of x selection hooks.
6378 * xselect.c (Qx_lost_selection_functions)
6379 (Qx_sent_selection_functions): New vars.
6380 (syms_of_xselect): DEFSYM them.
6381 (x_handle_selection_request): Pass Qx_sent_selection_functions
6382 rather than Vx_sent_selection_functions to Frun_hook_with_args.
6383 (x_handle_selection_clear,x_clear_frame_selections):
6384 Pass Qx_lost_selection_functions rather than
6385 Vx_lost_selection_functions to Frun_hook_with_args.
6386
47ea7f44
PE
63872011-07-13 Paul Eggert <eggert@cs.ucla.edu>
6388
ac389d0c 6389 * buffer.c (Fget_buffer_create): Initialize inhibit_shrinking.
2941c447
PE
6390 The old code sometimes used this field without initializing it.
6391
47ea7f44
PE
6392 * alloc.c (gc_sweep): Don't read past end of array.
6393 In theory, the old code could also have corrupted Emacs internals,
6394 though it'd be very unlikely.
6395
bc985c87
AS
63962011-07-12 Andreas Schwab <schwab@linux-m68k.org>
6397
6398 * character.c (Fcharacterp): Don't advertise optional ignored
ac389d0c 6399 argument. (Bug#4026)
bc985c87 6400
0cf34688
LMI
64012011-07-12 Lars Magne Ingebrigtsen <larsi@gnus.org>
6402
b3dadd76
LMI
6403 * keymap.c (syms_of_keymap): Clarify that "modifier" is "modifier
6404 key" (bug#4257).
6405
0cf34688
LMI
6406 * window.c (Fset_window_start): Doc fix (bug#4199).
6407 (Fset_window_hscroll): Ditto.
6408
270768cd
PE
64092011-07-12 Paul Eggert <eggert@cs.ucla.edu>
6410
077e3dda 6411 Fix minor new problems caught by GCC 4.6.1.
270768cd 6412 * term.c (init_tty): Remove unused local.
490011a6 6413 * xsettings.c (store_monospaced_changed): Define this function only
077e3dda 6414 if (defined HAVE_GSETTINGS || defined HAVE_GCONF), as it's
490011a6 6415 not used otherwise.
270768cd 6416
b1f58454
CY
64172011-07-12 Chong Yidong <cyd@stupidchicken.com>
6418
6419 * xdisp.c (Vresize_mini_windows): Minor doc fix (Bug#3300).
6420
22b9578d
LMI
64212011-07-11 Lars Magne Ingebrigtsen <larsi@gnus.org>
6422
6e70ab07
LMI
6423 * xdisp.c (syms_of_xdisp): Make it explicit that the mini-windows
6424 are the mini-buffer and the echo area (bug#3320).
6425
22b9578d
LMI
6426 * term.c (init_tty): Remove support for supdup, c10 and perq
6427 terminals, which are no longer supported (bug#1482).
6428
8974cc9f
JB
64292011-07-10 Johan Bockgård <bojohan@gnu.org>
6430
6431 * xdisp.c (Ftool_bar_lines_needed): Fix WINDOWP check.
6432
a560d974
JD
64332011-07-10 Jan Djärv <jan.h.d@swipnet.se>
6434
6435 * xmenu.c (menu_highlight_callback): Only pass frame to show_help_event
6436 for non-popups (Bug#3642).
6437
1dae0f0a
AS
64382011-07-10 Andreas Schwab <schwab@linux-m68k.org>
6439
268c2c36 6440 * alloc.c (reset_malloc_hooks): Protoize.
1dae0f0a 6441 * buffer.c (mmap_init, mmap_find, mmap_free_1, mmap_enlarge)
268c2c36
AS
6442 (mmap_set_vars, mmap_alloc, mmap_free, mmap_realloc): Likewise.
6443 * cm.c (losecursor): Likewise.
1dae0f0a
AS
6444 * data.c (fmod): Likewise.
6445 * dispnew.c (swap_glyphs_in_rows): Likewise.
6446 * emacs.c (memory_warning_signal): Likewise.
6447 * floatfns.c (float_error): Likewise.
6448 * font.c (check_gstring, check_otf_features, otf_tag_symbol)
6449 (otf_open, font_otf_capability, generate_otf_features)
6450 (font_otf_DeviceTable, font_otf_ValueRecord, font_otf_Anchor):
6451 Likewise.
6452 * image.c (pbm_read_file): Likewise.
6453 * indent.c (string_display_width): Likewise.
6454 * intervals.c (check_for_interval, search_for_interval)
6455 (inc_interval_count, count_intervals, root_interval)
6456 (adjust_intervals_for_insertion, make_new_interval): Likewise.
6457 * lread.c (defalias): Likewise.
268c2c36 6458 * ralloc.c (r_alloc_check): Likewise.
1dae0f0a
AS
6459 * regex.c (set_image_of_range_1, set_image_of_range)
6460 (regex_grow_registers): Likewise.
6461 * sysdep.c (strerror): Likewise.
6462 * termcap.c (valid_filename_p, tprint, main): Likewise.
6463 * tparam.c (main): Likewise.
6464 * unexhp9k800.c (run_time_remap, save_data_space)
6465 (update_file_ptrs, read_header, write_header, calculate_checksum)
6466 (copy_file, copy_rest, display_header): Likewise.
6467 * widget.c (mark_shell_size_user_specified, create_frame_gcs):
6468 Likewise.
6469 * xdisp.c (check_it): Likewise.
6470 * xfaces.c (register_color, unregister_color, unregister_colors):
6471 Likewise.
6472 * xfns.c (print_fontset_result): Likewise.
6473 * xrdb.c (member, fatal, main): Likewise.
6474
99033785
PE
64752011-07-10 Paul Eggert <eggert@cs.ucla.edu>
6476
6477 Fix minor problems found by static checking (Bug#9031).
6478 * chartab.c (char_table_set_range, map_sub_char_table):
6479 Remove unused locals.
6480 (uniprop_table): Now static.
6481 * composite.c (_work_char): Remove unused static var.
6482
9cb2ac56
JB
64832011-07-09 Juanma Barranquero <lekktu@gmail.com>
6484
6485 * chartab.c (uniprop_table_uncompress): Remove unused local variable.
6486
f25661f0
JD
64872011-07-09 Jan Djärv <jan.h.d@swipnet.se>
6488
6489 * gtkutil.c (qttip_cb): Remove code without function.
6490
8278c4fe
EZ
64912011-07-09 Eli Zaretskii <eliz@gnu.org>
6492
6493 * w32.c (pthread_sigmask): New stub.
6494
1692ae2d 64952011-07-08 Paul Eggert <eggert@cs.ucla.edu>
123403e4 6496
8a6ebd58 6497 Use pthread_sigmask, not sigprocmask (Bug#9010).
123403e4
PE
6498 sigprocmask is portable only for single-threaded applications, and
6499 Emacs can be multi-threaded when it uses GTK.
1301ac26
PE
6500 * Makefile.in (LIB_PTHREAD_SIGMASK): New macro.
6501 (LIBES): Use it.
6502 * callproc.c (Fcall_process):
6503 * process.c (create_process):
6504 * sysdep.c (sys_sigblock, sys_sigunblock, sys_sigsetmask):
6505 Use pthread_sigmask, not sigprocmask.
123403e4 6506
1b854618
JD
65072011-07-08 Jan Djärv <jan.h.d@swipnet.se>
6508
6509 * gtkutil.c (qttip_cb): Set line wrap to FALSE for tooltip widget.
6510 (xg_prepare_tooltip): Revert text in x->ttip_lbl, margins was
6511 wrong (Bug#8591).
6512
3fe4b549
JD
65132011-07-08 Jan Djärv <jan.h.d@swipnet.se>
6514
0ce7e563
JD
6515 * gtkutil.c (xg_prepare_tooltip): Fix indentation and comment.
6516 Put text in x->ttip_lbl instead of gtk_tooltip_set_text (Bug#8591).
6517 (xg_hide_tooltip): Fix comment.
6518
3fe4b549
JD
6519 * nsterm.m (initFrameFromEmacs): Don't use ns_return_types
6520 in registerServicesMenuSendTypes.
6521 (validRequestorForSendType): Don't check ns_return_types.
6522
6523 * nsfns.m (Fx_open_connection): Put NSStringPboardType into
6524 ns_return_type.
6525
5df75e47
JR
65262011-07-08 Jason Rumney <jasonr@gnu.org>
6527
22610910
JR
6528 * w32term.c (x_make_frame_visible): Use SH_SHOWNORMAL rather than
6529 SH_SHOW for hidden windows (Bug#5482).
6530
5df75e47
JR
6531 * w32fns.c (w32_wnd_proc) [WM_TIMER, WM_SET_CURSOR]: Avoid using
6532 frame struct members of non-existent frames (Bug#6284).
6533
699c10bd
JD
65342011-07-08 Jan Djärv <jan.h.d@swipnet.se>
6535
4393663b
JD
6536 * nsterm.m (keyDown): Call to wantsToDelayTextChangeNotifications and
6537 variable firstTime not needed on OSX >= 10.6.
6538 (setPosition): setFloatValue:knobProportion: is deprecated on OSX
6539 >= 10.5. Use setKnobProportion, setDoubleValue.
6540
6541 * nsterm.h (MAC_OS_X_VERSION_10_3, MAC_OS_X_VERSION_10_4)
6542 (MAC_OS_X_VERSION_10_5): Define if not defined.
6543 (EmacsView, EmacsTooltip): Implements NSWindowDelegate on OSX >= 10.6.
6544 (EmacsMenu): Implements NSMenuDelegate on OSX >= 10.6.
6545 (EmacsToolbar): Implements NSToolbarDelegate on OSX >= 10.6.
6546
6547 * nsselect.m (ns_string_from_pasteboard): Don't use deprecated methods
6548 cString and lossyCString on OSX >= 10.4
6549
58179cce 6550 * nsmenu.m (fillWithWidgetValue): Don't use deprecated method
4393663b
JD
6551 sizeToFit on OSX >= 10.2.
6552
6553 * nsimage.m (allocInitFromFile): Don't use deprecated method
6554 bestRepresentationForDevice on OSX >= 10.6.
6555
6556 * nsfns.m (check_ns_display_info): Cast to long and use %ld in error
6557 to avoid warning.
6558
6559 * emacs.c: Declare unexec_init_emacs_zone.
6560
a63e0781
JD
6561 * nsgui.h: Fix compiler warning about gnulib redefining verify.
6562
699c10bd
JD
6563 * nsselect.m (ns_get_local_selection): Change to extern (Bug#8842).
6564
6565 * nsmenu.m (ns_update_menubar): Remove useless setDelegate call
6566 on svcsMenu (Bug#8842).
6567
6568 * nsfns.m (Fx_open_connection): Remove NSStringPboardType from
6569 ns_return_types.
6570 (Fns_list_services): Just return Qnil on 10.6, code not working there.
6571
6572 * nsterm.m (QUTF8_STRING): Declare.
6573 (initFrameFromEmacs): Call registerServicesMenuSendTypes.
6574 (validRequestorForSendType): Return type is (id).
6575 Change indexOfObjectIdenticalTo to indexOfObject.
6576 Check if we have local selection before returning self (Bug#8842).
6577 (writeSelectionToPasteboard): Put local selection into paste board
6578 if we have a local selection (Bug#8842).
6579 (syms_of_nsterm): DEFSYM QUTF8_STRING.
6580
6581 * nsterm.h (MAC_OS_X_VERSION_10_6): Define here instead of nsterm.m.
6582 (ns_get_local_selection): Declare.
6583
54e10184
LMI
65842011-07-07 Lars Magne Ingebrigtsen <larsi@gnus.org>
6585
9888ff71
LMI
6586 * keymap.c (describe_map_tree): Don't insert a double newline at
6587 the end of the buffer (bug#1169) and return whether we inserted
6588 something.
6589
54e10184
LMI
6590 * callint.c (Fcall_interactively): Change "reading args" to
6591 "providing args" to try to clarify what it does (bug#1010).
6592
15fa4783
KH
65932011-07-07 Kenichi Handa <handa@m17n.org>
6594
6595 * composite.c (composition_compute_stop_pos): Ignore a static
6596 composition starting before CHARPOS (Bug#8915).
6597
6598 * xdisp.c (handle_composition_prop): Likewise.
6599
a8815b00
EZ
66002011-07-07 Eli Zaretskii <eliz@gnu.org>
6601
6602 * term.c (produce_glyphs) <xassert>: Allow IT_GLYPHLESS in it->what.
6603 (Bug#9015)
6604
ef7b981d 66052011-07-07 Kenichi Handa <handa@m17n.org>
c805dec0
KH
6606
6607 * character.h (unicode_category_t): New enum type.
6608
6609 * chartab.c (uniprop_decoder_t, uniprop_encoder_t): New types.
6610 (Qchar_code_property_table): New variable.
6611 (UNIPROP_TABLE_P, UNIPROP_GET_DECODER)
6612 (UNIPROP_COMPRESSED_FORM_P): New macros.
6613 (char_table_ascii): Uncompress the compressed values.
6614 (sub_char_table_ref): New arg is_uniprop. Callers changed.
6615 Uncompress the compressed values.
ac389d0c 6616 (sub_char_table_ref_and_range): Likewise.
c805dec0
KH
6617 (char_table_ref_and_range): Uncompress the compressed values.
6618 (sub_char_table_set): New arg is_uniprop. Callers changed.
6619 Uncompress the compressed values.
6620 (sub_char_table_set_range): Args changed. Callers changed.
6621 (char_table_set_range): Adjuted for the above change.
6622 (map_sub_char_table): Delete args default_val and parent. Add arg
6623 top. Give decoded values to a Lisp function.
640c8776 6624 (map_char_table): Adjust for the above change. Give decoded
c805dec0
KH
6625 values to a Lisp function. Gcpro more variables.
6626 (uniprop_table_uncompress)
6627 (uniprop_decode_value_run_length): New functions.
6628 (uniprop_decoder, uniprop_decoder_count): New variables.
6629 (uniprop_get_decoder, uniprop_encode_value_character)
6630 (uniprop_encode_value_run_length, uniprop_encode_value_numeric):
6631 New functions.
6632 (uniprop_encoder, uniprop_encoder_count): New variables.
6633 (uniprop_get_encoder, uniprop_table)
6634 (Funicode_property_table_internal, Fget_unicode_property_internal)
6635 (Fput_unicode_property_internal): New functions.
6636 (syms_of_chartab): DEFSYM Qchar_code_property_table, defsubr
6637 Sunicode_property_table_internal, Sget_unicode_property_internal,
5e617bc2 6638 and Sput_unicode_property_internal. Defvar_lisp
c805dec0
KH
6639 char-code-property-alist.
6640
640c8776 6641 * composite.c (CHAR_COMPOSABLE_P): Adjust for the change of
c805dec0
KH
6642 Vunicode_category_table.
6643
640c8776 6644 * font.c (font_range): Adjust for the change of
c805dec0
KH
6645 Vunicode_category_table.
6646
76b397fb
DN
66472011-07-07 Dan Nicolaescu <dann@ics.uci.edu>
6648
6649 * m/iris4d.h: Remove file, move contents ...
6650 * s/irix6-5.h: ... here.
6651
22b4128e
PE
66522011-07-06 Paul Eggert <eggert@cs.ucla.edu>
6653
6654 Remove unportable assumption about struct layout (Bug#8884).
8a5c77bb
PE
6655 * alloc.c (mark_buffer):
6656 * buffer.c (reset_buffer_local_variables, Fbuffer_local_variables)
6657 (clone_per_buffer_values): Don't assume that
22b4128e
PE
6658 sizeof (struct buffer) is a multiple of sizeof (Lisp_Object).
6659 This isn't true in general, and it's particularly not true
6660 if Emacs is configured with --with-wide-int.
6661 * buffer.h (FIRST_FIELD_PER_BUFFER, LAST_FIELD_PER_BUFFER):
6662 New macros, used in the buffer.c change.
6663
869795d6
JD
66642011-07-05 Jan Djärv <jan.h.d@swipnet.se>
6665
6666 * xsettings.c: Use both GConf and GSettings if both are available.
6667 (store_config_changed_event): Add comment.
6668 (dpyinfo_valid, store_font_name_changed, map_tool_bar_style)
6669 (store_tool_bar_style_changed): New functions.
5e617bc2 6670 (store_monospaced_changed): Add comment. Call dpyinfo_valid.
869795d6
JD
6671 (struct xsettings): Move font inside HAVE_XFT.
6672 (GSETTINGS_TOOL_BAR_STYLE, GSETTINGS_FONT_NAME): New defines.
640c8776 6673 (GSETTINGS_MONO_FONT): Rename from SYSTEM_MONO_FONT.
869795d6 6674 Move inside HAVE_XFT.
640c8776 6675 (something_changed_gsettingsCB): Rename from something_changedCB.
869795d6
JD
6676 Check for changes in GSETTINGS_TOOL_BAR_STYLE and GSETTINGS_FONT_NAME
6677 also.
6678 (GCONF_TOOL_BAR_STYLE, GCONF_FONT_NAME): New defines.
5e617bc2 6679 (GCONF_MONO_FONT): Rename from SYSTEM_MONO_FONT. Move inside HAVE_XFT.
640c8776 6680 (something_changed_gconfCB): Rename from something_changedCB.
869795d6
JD
6681 Check for changes in GCONF_TOOL_BAR_STYLE and GCONF_FONT_NAME also.
6682 (parse_settings): Move check for font inside HAVE_XFT.
6683 (read_settings, apply_xft_settings): Add comment.
6684 (read_and_apply_settings): Add comment. Call map_tool_bar_style and
6685 store_tool_bar_style_changed. Move check for font inside HAVE_XFT and
6686 call store_font_name_changed.
6687 (xft_settings_event): Add comment.
6688 (init_gsettings): Add comment. Get values for GSETTINGS_TOOL_BAR_STYLE
6689 and GSETTINGS_FONT_NAME. Move check for fonts within HAVE_XFT.
6690 (init_gconf): Add comment. Get values for GCONF_TOOL_BAR_STYLE
6691 and GCONF_FONT_NAME. Move check for fonts within HAVE_XFT.
6692 (xsettings_initialize): Call init_gsettings last.
640c8776
SM
6693 (xsettings_get_system_font, xsettings_get_system_normal_font):
6694 Add comment.
869795d6 6695
d8ed26bd
PE
66962011-07-05 Paul Eggert <eggert@cs.ucla.edu>
6697
6698 Random fixes. E.g., (random) never returned negative values.
6699 * fns.c (Frandom): Use GET_EMACS_TIME for random seed, and add the
6700 subseconds part to the entropy, as that's a bit more random.
6701 Prefer signed to unsigned, since the signedness doesn't matter and
6702 in general we prefer signed. When given a limit, use a
6703 denominator equal to INTMASK + 1, not to VALMASK + 1, because the
6704 latter isn't right if USE_2_TAGS_FOR_INTS.
6705 * sysdep.c (get_random): Return a value in the range 0..INTMASK,
6706 not 0..VALMASK. Don't discard "excess" bits that random () returns.
6707
cabf1cac
SM
67082011-07-04 Stefan Monnier <monnier@iro.umontreal.ca>
6709
6710 * textprop.c (text_property_stickiness):
6711 Obey Vtext_property_default_nonsticky.
6712 (syms_of_textprop): Add `display' to Vtext_property_default_nonsticky.
6713 * w32fns.c (syms_of_w32fns):
6714 * xfns.c (syms_of_xfns): Don't Add `display' since it's there by default.
6715
6e9b2be9
PE
67162011-07-04 Paul Eggert <eggert@cs.ucla.edu>
6717
6718 * fileio.c (barf_or_query_if_file_exists): Use S_ISDIR.
6719 This is more efficient than Ffile_directory_p and avoids a minor race.
6720
90186c68
LMI
67212011-07-04 Lars Magne Ingebrigtsen <larsi@gnus.org>
6722
7c301272
LMI
6723 * buffer.c (Foverlay_put): Say what the return value is
6724 (bug#7835).
6725
c4f2d8d4
LMI
6726 * fileio.c (barf_or_query_if_file_exists): Check first if the file
6727 is a directory before asking whether to use the file name
6728 (bug#7564).
ad637907
LMI
6729 (barf_or_query_if_file_exists): Make the "File is a directory"
6730 error be more correct.
c4f2d8d4 6731
90186c68
LMI
6732 * fns.c (Frequire): Remove the mention of the .gz files, since
6733 that's installation-specific, but keep the mention of
6734 `get-load-suffixes'.
6735
da64016e
PE
67362011-07-04 Paul Eggert <eggert@cs.ucla.edu>
6737
6738 * editfns.c (Fformat_time_string): Don't assume strlen fits in int.
6739 Report string overflow if the output is too long.
6740
7d47b580
JB
67412011-07-04 Juanma Barranquero <lekktu@gmail.com>
6742
a555cb87
JB
6743 * gnutls.c (Fgnutls_boot): Don't mention :verify-error.
6744 (syms_of_gnutls): Remove duplicate DEFSYM for
6745 Qgnutls_bootprop_verify_hostname_error, an error for
6746 Qgnutls_bootprop_verify_error (which is no longer used).
6747
7d47b580
JB
6748 * eval.c (find_handler_clause): Remove parameters `sig' and `data',
6749 unused since 2011-01-26T20:02:07Z!monnier@iro.umontreal.ca. All callers changed.
6750 Also (re)move comments that are misplaced or no longer relevant.
6751
1e49bfab
LMI
67522011-07-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
6753
6754 * callint.c (Finteractive): Clarify the meaning of "@" (bug#8813).
6755
1485f4c0
CY
67562011-07-03 Chong Yidong <cyd@stupidchicken.com>
6757
6758 * xfaces.c (Finternal_merge_in_global_face): Modify the foreground
6759 and background color parameters if they have been changed.
6760
a9ab721e
LMI
67612011-07-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
6762
6763 * editfns.c (Fformat): Clarify the - and 0 flags (bug#6659).
6764
cf7cff57
PE
67652011-07-03 Paul Eggert <eggert@cs.ucla.edu>
6766
2e13213d
PE
6767 * xsettings.c (SYSTEM_FONT): Define only when used.
6768 No need to define when HAVE_GSETTINGS || !HAVE_XFT.
6769
cf7cff57
PE
6770 * keymap.c (access_keymap_1): Now static.
6771
7a8e04f7
CY
67722011-07-02 Chong Yidong <cyd@stupidchicken.com>
6773
6774 * keyboard.c (command_loop_1): If a down-mouse event is unbound,
6775 leave any prefix arg for the up event (Bug#1586).
6776
61352f62
LMI
67772011-07-02 Lars Magne Ingebrigtsen <larsi@gnus.org>
6778
69bb1ef7
LMI
6779 * lread.c (syms_of_lread): Mention single symbols defined by
6780 `defvar' or `defconst' (bug#7154).
6781
61352f62 6782 * fns.c (Frequire): Mention .el.gz files (bug#7314).
7b3747f9 6783 (Frequire): Mention get-load-suffixes.
61352f62 6784
28545e04
MR
67852011-07-02 Martin Rudalics <rudalics@gmx.at>
6786
6787 * window.h (window): Remove clone_number slot.
6788 * window.c (Fwindow_clone_number, Fset_window_clone_number):
6789 Remove.
6790 (make_parent_window, make_window, saved_window)
6791 (Fset_window_configuration, save_window_save): Don't deal with
6792 clone numbers.
6793 * buffer.c (Qclone_number): Remove declaration.
6794 (sort_overlays, overlay_strings): Don't deal with clone numbers.
6795
3349e122
SM
67962011-07-02 Stefan Monnier <monnier@iro.umontreal.ca>
6797
6798 Add multiple inheritance to keymaps.
6799 * keymap.c (Fmake_composed_keymap): New function.
6800 (Fset_keymap_parent): Simplify.
6801 (fix_submap_inheritance): Remove.
6802 (access_keymap_1): New function extracted from access_keymap to handle
6803 embedded parents and handle lists of maps.
6804 (access_keymap): Use it.
6805 (Fkeymap_prompt, map_keymap_internal, map_keymap, store_in_keymap)
6806 (Fcopy_keymap): Handle embedded parents.
6807 (Fcommand_remapping, define_as_prefix): Simplify.
6808 (Fkey_binding): Simplify.
6809 (syms_of_keymap): Move minibuffer-local-completion-map,
6810 minibuffer-local-filename-completion-map,
6811 minibuffer-local-must-match-map, and
6812 minibuffer-local-filename-must-match-map to Elisp.
6813 (syms_of_keymap): Defsubr make-composed-keymap.
6814 * keyboard.c (menu_bar_items): Use map_keymap_canonical.
6815 (parse_menu_item): Trivial simplification.
6816
3279eb87
GM
68172011-07-01 Glenn Morris <rgm@gnu.org>
6818
6819 * Makefile.in (SETTINGS_LIBS): Fix typo.
6820
4550efdf
KI
68212011-07-01 Kazuhiro Ito <kzhr@d1.dion.ne.jp> (tiny patch)
6822
6823 * coding.c (Fencode_coding_string): Record the last coding system
6824 used, as the function doc string says (bug#8738).
6825
0949d2b6
JD
68262011-07-01 Jan Djärv <jan.h.d@swipnet.se>
6827
6828 * xsettings.c (store_monospaced_changed): Take new font as arg and
6829 check for change against current_mono_font.
6830 (EMACS_TYPE_SETTINGS): Remove this and related defines.
6831 (emacs_settings_constructor, emacs_settings_get_property)
6832 (emacs_settings_set_property, emacs_settings_class_init)
6833 (emacs_settings_init, gsettings_obj): Remove.
6834 (something_changedCB): New function for HAVE_GSETTINGS.
6835 (something_changedCB): HAVE_GCONF: Call store_monospaced_changed
6836 with value as argument.
6837 (init_gsettings): Check that GSETTINGS_SCHEMA exists before calling
6838 g_settings_new (Bug#8967). Do not create gsettings_obj.
9173deec 6839 Remove calls to g_settings_bind. Connect something_changedCB to
0949d2b6
JD
6840 "changed".
6841
6842 * xgselect.c: Add defined (HAVE_GSETTINGS).
6843 (xgselect_initialize): Ditto.
6844
6845 * process.c: Add defined (HAVE_GSETTINGS) for xgselect.h
6846 (wait_reading_process_output): Add defined (HAVE_GSETTINGS) for
6847 xg_select.
6848
bbc6b304
PE
68492011-07-01 Paul Eggert <eggert@cs.ucla.edu>
6850
6851 * eval.c (struct backtrace): Simplify and port the data structure.
6852 Do not assume that "int nargs : BITS_PER_INT - 2;" produces a
6853 signed bit field, as this assumption is not portable and it makes
6854 Emacs crash when compiled with Sun C 5.8 on sparc. Do not use
6855 "char debug_on_exit : 1" as this is not portable either; instead,
6856 use the portable "unsigned int debug_on_exit : 1". Remove unused
6857 member evalargs. Remove obsolete comments about cc bombing out.
6858
9851bfc5
JD
68592011-06-30 Jan Djärv <jan.h.d@swipnet.se>
6860
51bb811f 6861 * xsettings.c: Include glib-object.h, gio/gio.h if HAVE_GSETTINGS.
9851bfc5
JD
6862 Let HAVE_GSETTINGS override HAVE_GCONF.
6863 (store_monospaced_changed): New function.
6864 (EMACS_SETTINGS): A new type derived from GObject to handle
6865 GSettings notifications.
6866 (emacs_settings_constructor, emacs_settings_get_property)
6867 (emacs_settings_set_property, emacs_settings_class_init):
6868 New functions.
6869 (gsettings_client, gsettings_obj): New variables.
6870 (GSETTINGS_SCHEMA): New define.
6871 (something_changedCB): Call store_monospaced_changed.
6872 (init_gsettings): New function.
6873 (xsettings_initialize): Call init_gsettings.
6874 (syms_of_xsettings): Initialize gsettings_client, gsettings_obj
6875 to NULL.
6876
640c8776 6877 * Makefile.in (SETTINGS_CFLAGS, SETTINGS_LIBS): Rename from
9851bfc5
JD
6878 GCONF_CFLAGS/LIBS.
6879
5386012d
MR
68802011-06-29 Martin Rudalics <rudalics@gmx.at>
6881
6882 * window.c (resize_root_window, grow_mini_window)
6883 (shrink_mini_window): Rename Qresize_root_window to
6884 Qwindow_resize_root_window and Qresize_root_window_vertically to
6885 Qwindow_resize_root_window_vertically.
6886
f13e0b08
PE
68872011-06-28 Paul Eggert <eggert@cs.ucla.edu>
6888
6889 * gnutls.c (Qgnutls_bootprop_verify_error): Remove unused var.
6890
94515237
JB
68912011-06-27 Juanma Barranquero <lekktu@gmail.com>
6892
6893 * makefile.w32-in: Redesign dependencies so they reflect more
6894 clearly which files are directly included by each source file,
6895 and not through other includes.
6896
e43b6e43
MR
68972011-06-27 Martin Rudalics <rudalics@gmx.at>
6898
6899 * buffer.c (Qclone_number): Declare static and DEFSYM it.
6900 (sort_overlays, overlay_strings): When an overlay's clone number
6901 matches the window's clone number process the overlay even if
6902 the overlay's window property doesn't match the current window.
6903
d68443dc
MR
6904 * window.c (Fwindow_vchild): Rename to Fwindow_top_child.
6905 (Fwindow_hchild): Rename to Fwindow_left_child.
6906 (Fwindow_next): Rename to Fwindow_next_sibling.
6907 (Fwindow_prev): Rename to Fwindow_prev_sibling.
d615d6d2
MR
6908 (resize_window_check): Rename to window_resize_check.
6909 (resize_window_apply): Rename to window_resize_apply.
6910 (Fresize_window_apply): Rename to Fwindow_resize_apply.
6911 (Fdelete_other_windows_internal, resize_frame_windows)
6912 (Fsplit_window_internal, Fdelete_window_internal)
6913 (grow_mini_window, shrink_mini_window)
6914 (Fresize_mini_window_internal): Fix callers accordingly.
d68443dc 6915
c7e73be5
JD
69162011-06-26 Jan Djärv <jan.h.d@swipnet.se>
6917
6918 * emacsgtkfixed.h: State that this is only used with Gtk+3.
6919 (emacs_fixed_set_min_size): Remove.
6920 (emacs_fixed_new): Take frame as argument.
6921
6922 * emacsgtkfixed.c: State that this is only used with Gtk+3.
6923 (_EmacsFixedPrivate): Remove minwidth/height.
6924 Add struct frame *f.
6925 (emacs_fixed_init): Initialize priv->f.
6926 (get_parent_class, emacs_fixed_set_min_size): Remove.
6927 (emacs_fixed_new): Set priv->f to argument.
6928 (emacs_fixed_get_preferred_width)
6929 (emacs_fixed_get_preferred_height): Use min_width/height from
6930 frames size_hint to set minimum and natural (Bug#8919).
6931 (XSetWMSizeHints, XSetWMNormalHints): Override these functions
6932 and use min_width/height from frames size_hint to set
6933 min_width/height (Bug#8919).
6934
6935 * gtkutil.c (xg_create_frame_widgets): Pass f to emacs_fixed_new.
9173deec
JB
6936 (x_wm_set_size_hint): Remove call to emacs_fixed_set_min_size.
6937 Fix indentation.
c7e73be5 6938
cf99dcf8
EZ
69392011-06-26 Eli Zaretskii <eliz@gnu.org>
6940
6941 * bidi.c (bidi_paragraph_init): Test for ZV_BYTE before calling
6942 bidi_at_paragraph_end, since fast_looking_at doesn't like to be
6943 called at ZV.
6944
029529ac
CY
69452011-06-26 Chong Yidong <cyd@stupidchicken.com>
6946
6947 * process.c (wait_reading_process_output): Bypass select if
6948 waiting for a cell while ignoring keyboard input, and input is
6949 pending. Suggested by Jan Djärv (Bug#8869).
6950
7a7ef429
PE
69512011-06-25 Paul Eggert <eggert@cs.ucla.edu>
6952
6953 Use gnulib's dup2 module instead of rolling our own.
6954 * sysdep.c (dup2) [!HAVE_DUP2]: Remove; gnulib now does this.
6955
11fdef7d 69562011-06-25 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
989b42d2
YM
6957
6958 * dispnew.c (scrolling_window): Before scrolling, turn off a
6959 mouse-highlight in the window being scrolled.
6960
cd3520a4
JB
69612011-06-24 Juanma Barranquero <lekktu@gmail.com>
6962
6963 Move DEFSYM to lisp.h and use everywhere.
6964
6965 * character.h (DEFSYM): Move declaration...
6966 * lisp.h (DEFSYM): ...here.
6967
6968 * gnutls.c:
6969 * minibuf.c:
6970 * w32menu.c:
6971 * w32proc.c:
6972 * w32select.c: Don't include character.h.
6973
6974 * alloc.c (syms_of_alloc):
6975 * buffer.c (syms_of_buffer):
6976 * bytecode.c (syms_of_bytecode):
6977 * callint.c (syms_of_callint):
6978 * casefiddle.c (syms_of_casefiddle):
6979 * casetab.c (init_casetab_once):
6980 * category.c (init_category_once, syms_of_category):
6981 * ccl.c (syms_of_ccl):
6982 * cmds.c (syms_of_cmds):
6983 * composite.c (syms_of_composite):
6984 * dbusbind.c (syms_of_dbusbind):
6985 * dired.c (syms_of_dired):
6986 * dispnew.c (syms_of_display):
6987 * doc.c (syms_of_doc):
6988 * editfns.c (syms_of_editfns):
6989 * emacs.c (syms_of_emacs):
6990 * eval.c (syms_of_eval):
6991 * fileio.c (syms_of_fileio):
6992 * fns.c (syms_of_fns):
6993 * frame.c (syms_of_frame):
6994 * fringe.c (syms_of_fringe):
6995 * insdel.c (syms_of_insdel):
6996 * keymap.c (syms_of_keymap):
6997 * lread.c (init_obarray, syms_of_lread):
6998 * macros.c (syms_of_macros):
6999 * msdos.c (syms_of_msdos):
7000 * print.c (syms_of_print):
7001 * process.c (syms_of_process):
7002 * search.c (syms_of_search):
7003 * sound.c (syms_of_sound):
7004 * syntax.c (init_syntax_once, syms_of_syntax):
7005 * terminal.c (syms_of_terminal):
7006 * textprop.c (syms_of_textprop):
7007 * undo.c (syms_of_undo):
7008 * w32.c (globals_of_w32):
7009 * window.c (syms_of_window):
7010 * xdisp.c (syms_of_xdisp):
7011 * xfaces.c (syms_of_xfaces):
7012 * xfns.c (syms_of_xfns):
7013 * xmenu.c (syms_of_xmenu):
7014 * xsettings.c (syms_of_xsettings):
7015 * xterm.c (syms_of_xterm): Use DEFSYM.
7016
4228cf16
TZ
70172011-06-24 Teodor Zlatanov <tzz@lifelogs.com>
7018
cd3520a4 7019 * gnutls.c (syms_of_gnutls): Use the DEFSYM macro from character.h.
4228cf16 7020
7fcccf1e
PE
70212011-06-23 Paul Eggert <eggert@cs.ucla.edu>
7022
7efb4e0e
PE
7023 Integer and buffer overflow fixes (Bug#8873).
7024
ff5844ad
PE
7025 * print.c (printchar, strout): Check for string overflow.
7026 (PRINTPREPARE, printchar, strout):
7027 Don't set size unless allocation succeeds.
7028
90532f02
PE
7029 * minibuf.c (read_minibuf_noninteractive): Use ptrdiff_t, not int,
7030 for sizes. Check for string overflow more accurately.
7031 Simplify newline removal at end; this suppresses a GCC 4.6.0 warning.
7032
6d84508d
PE
7033 * macros.c: Integer and buffer overflow fixes.
7034 * keyboard.h (struct keyboard.kbd_macro_bufsize):
7035 * macros.c (Fstart_kbd_macro, store_kbd_macro_char):
7036 Use ptrdiff_t, not int, for sizes.
7037 Don't increment bufsize until after realloc succeeds.
7038 Check for size-calculation overflow.
7039 (Fstart_kbd_macro): Use EMACS_INT, not int, for XINT result.
7040
437b2cb4
PE
7041 * lisp.h (DEFVAR_KBOARD): Use offsetof instead of char * finagling.
7042
8b9ac8b4
PE
7043 * lread.c: Integer overflow fixes.
7044 (read_integer): Radix is now EMACS_INT, not int,
7045 to improve quality of diagnostics for out-of-range radices.
7046 Calculate buffer size correctly for out-of-range radices.
7047 (read1): Check for integer overflow in radices, and in
7048 read-circle numbers.
82cb60d3
PE
7049 (read_escape): Avoid int overflow.
7050 (Fload, openp, read_buffer_size, read1)
7051 (substitute_object_recurse, read_vector, read_list, map_obarray):
7052 Use ptrdiff_t, not int, for sizes.
7053 (read1): Use EMACS_INT, not int, for sizes.
20270765 7054 Check for size overflow.
8b9ac8b4 7055
7fcccf1e
PE
7056 * image.c (cache_image): Check for size arithmetic overflow.
7057
bfbbd7e7
PE
7058 * lread.c: Integer overflow issues.
7059 (saved_doc_string_size, saved_doc_string_length)
7060 (prev_saved_doc_string_size, prev_saved_doc_string_length):
7061 Now ptrdiff_t, not int.
7062 (read1): Don't assume doc string length fits in int. Check for
7063 out-of-range doc string lengths.
7064 (read_list): Don't assume file position fits in int.
39019e54 7065 (read_escape): Check for hex character overflow.
bfbbd7e7 7066
4e323265
LL
70672011-06-22 Leo Liu <sdl.web@gmail.com>
7068
7069 * minibuf.c (Fcompleting_read_default, Vcompleting_read_function):
7070 Move to minibuffer.el.
7071
85fece3e
PE
70722011-06-22 Paul Eggert <eggert@cs.ucla.edu>
7073
20b84ce9 7074 Fixes for GLYPH_DEBUG found by GCC 4.6.0 static checking.
85fece3e
PE
7075 The following patches are for when GLYPH_DEBUG && !XASSERT.
7076 * dispextern.h (trace_redisplay_p, dump_glyph_string):
7077 * dispnew.c (flush_stdout):
7078 * xdisp.c (dump_glyph_row, dump_glyph_matrix, dump_glyph):
7079 Mark as externally visible.
7080 * dispnew.c (check_window_matrix_pointers): Now static.
7081 * dispnew.c (window_to_frame_vpos):
7082 * xfns.c (unwind_create_frame):
7083 * xterm.c (x_check_font): Remove unused local.
7084 * scroll.c (CHECK_BOUNDS):
7085 * xfaces.c (cache_fache): Rename local to avoid shadowing.
7086 * xfns.c, w32fns.c (image_cache_refcount, dpyinfo_refcount): Now static.
7087 * xdisp.c (check_window_end): Now a no-op if !XASSERTS.
7088 (debug_first_unchanged_at_end_vpos, debug_last_unchanged_at_beg_vpos)
7089 (debug_dvpos, debug_dy, debug_delta, debug_delta_bytes, debug_end_vpos):
7090 Now static.
7091 (debug_method_add): Use va_list and vsprintf rather than relying
7092 on undefined behavior with wrong number of arguments.
7093 (dump_glyph, dump_glyph_row, Fdump_glyph_matrix):
7094 Don't assume ptrdiff_t and EMACS_INT are the same width as int.
7095 In this code, it's OK to assume C99 behavior for ptrdiff_t formats
7096 since we're not interested in debugging glyphs with old libraries.
7097 * xfaces.c (cache_face): Move debugging code earlier; this pacifies
7098 GCC 4.6.0's static checking.
7099
0766b489
PE
71002011-06-22 Paul Eggert <eggert@cs.ucla.edu>
7101
31fd4b32
PE
7102 Integer overflow and signedness fixes (Bug#8873).
7103 A few related buffer overrun fixes, too.
7104
b79e8648
PE
7105 * font.c (font_score): Use EMACS_INT, not int, to store XINT value.
7106
0766b489
PE
7107 * dispextern.h (struct face.stipple):
7108 * image.c (x_bitmap_height, x_bitmap_width, x_bitmap_pixmap)
7109 (x_bitmap_mask, x_allocate_bitmap_record)
7110 (x_create_bitmap_from_data, x_create_bitmap_from_file)
7111 (x_destroy_bitmap, x_destroy_all_bitmaps, x_create_bitmap_mask)
7112 (x_create_bitmap_from_xpm_data):
7113 * nsterm.h (struct ns_display_info.bitmaps_size, .bitmaps_last):
7114 * w32term.h (struct w32_display_info.icon_bitmap_id, .bitmaps_size)
7115 (.bitmaps_last):
7116 * xfaces.c (load_pixmap):
7117 * xterm.c (x_bitmap_icon, x_wm_set_icon_pixmap):
7118 * xterm.h (struct x_display_info.icon_bitmap_id, .bitmaps_size)
7119 (.bitmaps_last, struct x_output.icon_bitmap):
7120 Use ptrdiff_t, not int, for bitmap indexes.
7121 (x_allocate_bitmap_record): Check for size overflow.
7122 * dispextern.h, lisp.h: Adjust to API changes elsewhere.
7123
b081724f
PE
7124 Use ptrdiff_t, not int, for overlay counts.
7125 * buffer.h (overlays_at, sort_overlays, GET_OVERLAYS_AT):
7126 * editfns.c (overlays_around, get_pos_property):
7127 * textprop.c (get_char_property_and_overlay):
7128 * xdisp.c (next_overlay_change, note_mouse_highlight):
7129 * xfaces.c (face_at_buffer_position):
21514da7
PE
7130 * buffer.c (OVERLAY_COUNT_MAX): New macro.
7131 (overlays_at, overlays_in, sort_overlays, Foverlays_at)
7132 (Fnext_overlay_change, Fprevious_overlay_change)
7133 (mouse_face_overlay_overlaps, Foverlays_in):
b081724f 7134 Use ptrdiff_t, not int, for sizes.
21514da7 7135 (overlays_at, overlays_in): Check for size-calculation overflow.
b081724f 7136
3de73e5e
PE
7137 * xterm.c (xim_initialize, same_x_server): Strlen may not fit in int.
7138
2606c57b
PE
7139 * xsmfns.c (smc_save_yourself_CB, x_session_initialize): Avoid strlen.
7140 (x_session_initialize): Do not assume string length fits in int.
7141
aaafe47a
PE
7142 * xsettings.c (apply_xft_settings): Fix potential buffer overrun.
7143 This is unlikely, but can occur if DPI is outlandish.
7144
2674ddc8 7145 * xsettings.c (Ffont_get_system_normal_font, Ffont_get_system_font):
3a5077c5
PE
7146 * xselect.c (Fx_get_atom_name): Avoid need for strlen.
7147
28154962
PE
7148 * xrdb.c: Don't assume strlen fits in int; avoid some strlens.
7149 * xrdb.c (magic_file_p, search_magic_path):
7150 Omit last arg SUFFIX; it was always 0. All callers changed.
7151 (magic_file_p): Use ptrdiff_t, not int. Check for size overflow.
7152
7de51af5
PE
7153 * xfont.c (xfont_match): Avoid need for strlen.
7154
25ed6cc3
PE
7155 * xfns.c: Don't assume strlen fits in int.
7156 (xic_create_fontsetname, x_window): Use ptrdiff_t, not int.
7157
4eab31dd
PE
7158 * xdisp.c (message_log_check_duplicate): Return intmax_t,
7159 not unsigned long, as we prefer signed integers. All callers changed.
7160 Detect integer overflow in repeat count.
7161 (message_dolog): Don't assume print length fits in 39 bytes.
df1f27af 7162 (display_mode_element): Don't assume strlen fits in int.
4eab31dd 7163
171e2a58
PE
7164 * termcap.c: Don't assume sizes fit in int and never overflow.
7165 (struct termcap_buffer, tgetent): Use ptrdiff_t, not int, for sizes.
7166 (gobble_line): Check for size-calculation overflow.
7167
ad39faca 7168 * minibuf.c (Fread_buffer):
6e5bb2dc 7169 * lread.c (intern, intern_c_string):
74ca2eb3
PE
7170 * image.c (xpm_scan) [HAVE_NS && !HAVE_XPM]:
7171 Don't assume string length fits in int.
7172
52c61c22 7173 * keyboard.c (parse_tool_bar_item):
9bda3520
PE
7174 * gtkutil.c (style_changed_cb): Avoid need for strlen.
7175
b5b8c9e5
PE
7176 * font.c: Don't assume string length fits in int.
7177 (font_parse_xlfd, font_parse_fcname, font_unparse_fcname):
7178 Use ptrdiff_t, not int.
ccd6111c
PE
7179 (font_intern_prop): Don't assume string length fits in int.
7180 Don't assume integer property fits in fixnum.
7181 * font.h (font_intern_prop): 2nd arg is now ptrdiff_t, not int.
b5b8c9e5 7182
882f0d81 7183 * filelock.c: Fix some buffer overrun and integer overflow issues.
51cab52b 7184 (get_boot_time): Don't assume gzip command string fits in 100 bytes.
882f0d81
PE
7185 Reformulate so as not to need the command string.
7186 Invoke gzip -cd rather than gunzip, as it's more portable.
7187 (lock_info_type, lock_file_1, lock_file):
7188 Don't assume pid_t and time_t fit in unsigned long.
7189 (LOCK_PID_MAX): Remove; we now use more-reliable bounds.
7190 (current_lock_owner): Prefer signed type for sizes.
7191 Use memcpy, not strncpy, where memcpy is what is really wanted.
7192 Don't assume (via atoi) that time_t and pid_t fit in int.
7193 Check for time_t and/or pid_t out of range, e.g., via a network share.
7194 Don't alloca where an auto var works fine.
7195
93f4cf88
PE
7196 * fileio.c: Fix some integer overflow issues.
7197 (file_name_as_directory, Fexpand_file_name, Fsubstitute_in_file_name):
7198 Don't assume string length fits in int.
7199 (directory_file_name): Don't assume string length fits in long.
7200 (make_temp_name): Don't assume pid fits in int, or that its print
7201 length is less than 20.
7202
f3e92b69
PE
7203 * data.c (Fsubr_name): Rewrite to avoid a strlen call.
7204
1bfdaf10
PE
7205 * coding.c (make_subsidiaries): Don't assume string length fits in int.
7206
35016e9a
PE
7207 * callproc.c (child_setup): Rewrite to avoid two strlen calls.
7208
3d1e65a1
PE
7209 * process.c (Fformat_network_address): Use EMACS_INT, not EMACS_UINT.
7210 We prefer signed integers, even for size calculations.
7211
0b963a93
PE
7212 * emacs.c: Don't assume string length fits in 'int'.
7213 (DEFINE_DUMMY_FUNCTION, sort_args): Use ptrdiff_t, not int.
7214 (main): Don't invoke strlen when not needed.
7215
573f4b54
PE
7216 * dbusbind.c (XD_ERROR): Don't arbitrarily truncate string.
7217 (XD_DEBUG_MESSAGE): Don't waste a byte.
7218
989f33ba
PE
7219 * callproc.c (getenv_internal_1, getenv_internal)
7220 (Fgetenv_internal):
965d34eb
PE
7221 * buffer.c (init_buffer): Don't assume string length fits in 'int'.
7222
e4d29b33
PE
7223 * lread.c (invalid_syntax): Omit length argument.
7224 All uses changed. This doesn't fix a bug, but it simplifies the
7225 code away from its former Hollerith-constant appearance, and it's
7226 one less 'int' to worry about when looking at integer-overflow issues.
51cab52b 7227 (string_to_number): Simplify 2011-04-26 change by invoking xsignal1.
e4d29b33 7228
eb49b136
PE
7229 * lisp.h (DEFUN): Remove bogus use of sizeof (struct Lisp_Subr).
7230 This didn't break anything, but it didn't help either.
7231 It's confusing to put a bogus integer in a place where the actual
7232 value does not matter.
9f62aeb1 7233 (LIST_END_P): Remove unused macro and its bogus comment.
cbeff735 7234 (make_fixnum_or_float): Remove unnecessary cast to EMACS_INT.
eb49b136 7235
15375a22
PE
7236 * lisp.h (union Lisp_Object.i): EMACS_INT, not EMACS_UINT.
7237 This is for consistency with the ordinary, non-USE_LISP_UNION_TYPE,
7238 implementation.
b61cc01c
PE
7239 (struct Lisp_Bool_Vector.size): EMACS_INT, not EMACS_UINT.
7240 We prefer signed types, and the value cannot exceed the EMACS_INT
7241 range anyway (because otherwise the length would not be representable).
9a8e8d9b
PE
7242 (XSET) [USE_LISP_UNION_TYPE]: Use uintptr_t and intptr_t,
7243 not EMACS_UINT and EMACS_INT, when converting pointer to integer.
7244 This avoids a GCC warning when WIDE_EMACS_INT.
15375a22 7245
53b2623d
PE
7246 * indent.c (sane_tab_width): New function.
7247 (current_column, scan_for_column, Findent_to, position_indentation)
7248 (compute_motion): Use it. This is just for clarity.
8fcaf9cc 7249 (Fcompute_motion): Don't assume hscroll and tab offset fit in int.
53b2623d 7250
51cab52b 7251 * image.c (xbm_image_p): Don't assume stated width, height fit in int.
45aebb64 7252
f2ed8a70
PE
7253 * lisp.h (lint_assume): New macro.
7254 * composite.c (composition_gstring_put_cache):
7255 * ftfont.c (ftfont_shape_by_flt): Use it to pacify GCC 4.6.0.
7256
abe80cc6
PE
7257 * editfns.c, insdel.c:
7258 Omit unnecessary forward decls, to simplify future changes.
a9e860e1 7259
b02c740e
PE
7260 * ftfont.c (ftfont_shape_by_flt): Use signed integers for lengths.
7261
ebc96716
PE
7262 * font.c (Ffont_shape_gstring): Don't assume glyph len fits in 'int'.
7263
b4e50fa0 7264 * fns.c (Ffillarray): Don't assume bool vector size fits in 'int'.
f03dc6ef 7265 Use much-faster test for byte-length change.
311d5d7c 7266 Don't assume string byte-length fits in 'int'.
a4cf38e4 7267 Check that character arg fits in 'int'.
85461888 7268 (mapcar1): Declare byte as byte, for clarity.
b4e50fa0 7269
c0c1ee9f
PE
7270 * alloc.c (Fmake_bool_vector): Avoid unnecessary multiplication.
7271
a498d7f4
PE
7272 * fns.c (concat): Catch string overflow earlier.
7273 Do not rely on integer wraparound.
7274
51cab52b
PE
7275 * dispextern.h (struct it.overlay_strings_charpos)
7276 (struct it.selective): Now EMACS_INT, not int.
87830974
PE
7277 * xdisp.c (forward_to_next_line_start)
7278 (back_to_previous_visible_line_start)
7279 (reseat_at_next_visible_line_start, next_element_from_buffer):
7280 Don't arbitrarily truncate the value of 'selective' to int.
7281
76031fad
PE
7282 * xdisp.c (init_iterator): Use XINT, not XFASTINT; it might be < 0.
7283
5eb55db9
PE
7284 * composite.c: Don't truncate sizes to 'int'.
7285 (composition_gstring_p, composition_reseat_it)
7286 (composition_adjust_point): Use EMACS_INT, not int.
7d100a81
PE
7287 (get_composition_id, composition_gstring_put_cache): Use EMACS_INT,
7288 not EMACS_UINT, for indexes.
5eb55db9 7289
0703a717
PE
7290 * category.h (CATEGORY_SET_P): Remove unnecessary cast to EMACS_INT.
7291
d6202519
PE
7292 * buffer.c: Include <verify.h>.
7293 (struct sortvec.priority, struct sortstr.priority):
8961a454 7294 Now EMACS_INT, not int.
c20998a7 7295 (compare_overlays, cmp_for_strings): Avoid subtraction overflow.
67c36fce
PE
7296 (struct sortstr.size, record_overlay_string)
7297 (struct sortstrlist.size, struct sortlist.used):
7298 Don't truncate size to int.
7299 (record_overlay_string): Check for size-calculation overflow.
d6202519 7300 (init_buffer_once): Check at compile-time, not run-time.
fadf4e30 7301
d5a19415
JM
73022011-06-22 Jim Meyering <meyering@redhat.com>
7303
029529ac 7304 Don't leak an XBM-image-sized buffer
d5a19415
JM
7305 * image.c (xbm_load): Free the image buffer after using it.
7306
a9041e6c
PE
73072011-06-21 Paul Eggert <eggert@cs.ucla.edu>
7308
7309 Port to Sun C.
7310 * composite.c (find_automatic_composition): Omit needless 'return 0;'
7311 that Sun C diagnosed.
7312 * fns.c (secure_hash): Fix pointer signedness issue.
7313 * intervals.c (static_offset_intervals): New function.
7314 (offset_intervals): Use it.
7315
7f3f739f
LL
73162011-06-21 Leo Liu <sdl.web@gmail.com>
7317
7318 * deps.mk (fns.o):
7319 * makefile.w32-in ($(BLD)/fns.$(O)): Include sha256.h and
7320 sha512.h.
7321
7322 * fns.c (secure_hash): Rename from crypto_hash_function and change
7323 the first arg to accept symbols.
5b66d427 7324 (Fsecure_hash): New primitive.
7f3f739f
LL
7325 (syms_of_fns): New symbols.
7326
76147d94
DD
73272011-06-20 Deniz Dogan <deniz@dogan.se>
7328
7329 * process.c (Fset_process_buffer): Clarify return value in
7330 docstring.
7331
7d7d0045
CY
73322011-06-18 Chong Yidong <cyd@stupidchicken.com>
7333
7334 * dispnew.c (add_window_display_history): Use BVAR.
7335
7336 * xdisp.c (debug_method_add): Use BVAR.
7337 (check_window_end, dump_glyph_matrix, dump_glyph)
7338 (dump_glyph_row, dump_glyph_string): Convert arglist to ANSI C.
7339
7340 * xfaces.c (check_lface_attrs, check_lface, dump_realized_face):
7341 Likewise.
7342
7343 * xfns.c (Fx_create_frame, x_create_tip_frame): Delay image cache
7344 check till after the cache is created in init_frame_faces.
7345
ff2bc410
SM
73462011-06-17 Stefan Monnier <monnier@iro.umontreal.ca>
7347
7348 * fns.c (Fsafe_length): Yet another int/Lisp_Object mixup.
7349
28177add
PE
73502011-06-16 Paul Eggert <eggert@cs.ucla.edu>
7351
dd3482fe
PE
7352 * lisp.h: Include <limits.h>, for INT_MAX, LONG_MAX, LLONG_MAX.
7353 Without this, prin1 mishandles Lisp_Misc_Save_Value printing on
7354 hosts with pre-C99 libraries, because pD is wrongly defined to "t".
7355
393d71f3 7356 Improve buffer-overflow checking (Bug#8873).
1c8e352f
PE
7357 * fileio.c (Finsert_file_contents):
7358 * insdel.c (insert_from_buffer_1, replace_range, replace_range_2):
7359 Remove the old (too-loose) buffer overflow checks.
7360 They weren't needed, since make_gap checks for buffer overflow.
7361 * insdel.c (make_gap_larger): Catch buffer overflows that were missed.
7362 The old code merely checked for Emacs fixnum overflow, and relied
7363 on undefined (wraparound) behavior. The new code avoids undefined
7364 behavior, and also checks for ptrdiff_t and/or size_t overflow.
7365
2e6813b0 7366 * editfns.c (Finsert_char): Don't dump core with very negative counts.
21d890a4
PE
7367 Tune. Don't use wider integers than needed. Don't use alloca.
7368 Use a bigger 'string' buffer. Rewrite to avoid 'n > 0' test.
2e6813b0 7369
599a9e4f
PE
7370 * insdel.c (replace_range): Fix buf overflow when insbytes < outgoing.
7371
99561444
PE
7372 * insdel.c, lisp.h (buffer_overflow): New function.
7373 (insert_from_buffer_1, replace_range, replace_range_2):
7374 * insdel.c (make_gap_larger):
7375 * editfns.c (Finsert_char):
7376 * fileio.c (Finsert_file_contents): Use it, to normalize wording.
7377
28177add
PE
7378 * buffer.h (BUF_BYTES_MAX): Cast to ptrdiff_t so that it's signed.
7379
e69dafad
PE
73802011-06-15 Paul Eggert <eggert@cs.ucla.edu>
7381
4baa020d 7382 Integer overflow and signedness fixes (Bug#8873, Bug#8828).
ff672d2c 7383
b1c46f02
PE
7384 * ccl.c (ASCENDING_ORDER): New macro, to work around GCC bug 43772.
7385 (GET_CCL_RANGE, IN_INT_RANGE): Use it.
7386
e69dafad
PE
7387 * fileio.c: Don't assume EMACS_INT fits in off_t.
7388 (emacs_lseek): New static function.
7389 (Finsert_file_contents, Fwrite_region): Use it.
7390 Use SEEK_SET, SEEK_CUR, SEEK_END as appropriate.
7391
566684ea
PE
7392 * fns.c (Fload_average): Don't assume 100 * load average fits in int.
7393
e6966cd6
PE
7394 * fns.c: Don't overflow int when computing a list length.
7395 * fns.c (QUIT_COUNT_HEURISTIC): New constant.
7396 (Flength, Fsafe_length): Use EMACS_INT, not int, to avoid unwanted
7397 truncation on 64-bit hosts. Check for QUIT every
7398 QUIT_COUNT_HEURISTIC entries rather than every other entry; that's
7399 faster and is responsive enough.
7400 (Flength): Report an error instead of overflowing an integer.
7401 (Fsafe_length): Return a float if the value is not representable
7402 as a fixnum. This shouldn't happen except in contrived situations.
6346d301 7403 (Fnthcdr, Fsort): Don't assume list length fits in int.
de41a810 7404 (Fcopy_sequence): Don't assume vector length fits in int.
00c604f2 7405
dd0b0efb
PE
7406 * alloc.c: Check that resized vectors' lengths fit in fixnums.
7407 (header_size, word_size): New constants.
7408 (allocate_vectorlike): Don't check size overflow here.
7409 (allocate_vector): Check it here instead, since this is the only
7410 caller of allocate_vectorlike that could cause overflow.
7411 Check that the new vector's length is representable as a fixnum.
7412
86fe5cfe
PE
7413 * fns.c (next_almost_prime): Don't return a multiple of 3 or 5.
7414 The previous code was bogus. For example, next_almost_prime (32)
7415 returned 39, which is undesirable as it is a multiple of 3; and
7416 next_almost_prime (24) returned 25, which is a multiple of 5 so
7417 why was the code bothering to check for multiples of 7?
7418
80e88859
PE
7419 * bytecode.c (exec_byte_code): Use ptrdiff_t, not int, for vector length.
7420
4a2f0ad6
PE
7421 * eval.c, doprnt.c (SIZE_MAX): Remove; inttypes.h defines this now.
7422
f66c7cf8
PE
7423 Variadic C functions now count arguments with ptrdiff_t.
7424 This partly undoes my 2011-03-30 change, which replaced int with size_t.
7425 Back then I didn't know that the Emacs coding style prefers signed int.
7426 Also, in the meantime I found a few more instances where arguments
4a2f0ad6
PE
7427 were being counted with int, which may truncate counts on 64-bit
7428 machines, or EMACS_INT, which may be unnecessarily wide.
f66c7cf8
PE
7429 * lisp.h (struct Lisp_Subr.function.aMANY)
7430 (DEFUN_ARGS_MANY, internal_condition_case_n, safe_call):
7431 Arg counts are now ptrdiff_t, not size_t.
7432 All variadic functions and their callers changed accordingly.
7433 (struct gcpro.nvars): Now size_t, not size_t. All uses changed.
7434 * bytecode.c (exec_byte_code): Check maxdepth for overflow,
7435 to avoid potential buffer overrun. Don't assume arg counts fit in 'int'.
7436 * callint.c (Fcall_interactively): Check arg count for overflow,
7437 to avoid potential buffer overrun. Use signed char, not 'int',
7438 for 'varies' array, so that we needn't bother to check its size
7439 calculation for overflow.
7440 * editfns.c (Fformat): Use ptrdiff_t, not EMACS_INT, to count args.
7441 * eval.c (apply_lambda):
7442 * fns.c (Fmapconcat): Use XFASTINT, not XINT, to get args length.
7443 (struct textprop_rec.argnum): Now ptrdiff_t, not int. All uses changed.
7444 (mapconcat): Use ptrdiff_t, not int and EMACS_INT, to count args.
7445
a1759b76
PE
7446 * callint.c (Fcall_interactively): Don't use index var as event count.
7447
d96be9fc
PE
7448 * vm-limit.c (check_memory_limits): Fix incorrect extern function decls.
7449 * mem-limits.h (SIZE): Remove; no longer used.
7450
a690a978 7451 * xterm.c (x_alloc_nearest_color_1): Prefer int to long when int works.
5efd304b 7452
578c21e6
PE
7453 Remove unnecessary casts.
7454 * xterm.c (x_term_init):
7455 * xfns.c (x_set_border_pixel):
7456 * widget.c (create_frame_gcs): Remove casts to unsigned long etc.
7457 These aren't needed now that we assume ANSI C.
7458
96f53c6c
PE
7459 * sound.c (Fplay_sound_internal): Remove cast to unsigned long.
7460 It's more likely to cause problems (due to unsigned overflow)
7461 than to cure them.
7462
83c77d31
PE
7463 * dired.c (Ffile_attributes): Don't use 32-bit hack on 64-bit hosts.
7464
ee2079f1
PE
7465 * unexelf.c (unexec): Don't assume BSS addr fits in unsigned.
7466
6da65536
PE
7467 * xterm.c (handle_one_xevent): Omit unnecessary casts to unsigned.
7468
7147c4a4
PE
7469 * keyboard.c (modify_event_symbol): Don't limit alist len to UINT_MAX.
7470
193e32d9
PE
7471 * lisp.h (CHAR_TABLE_SET): Omit now-redundant test.
7472
e5533da6
PE
7473 * lread.c (Fload): Don't compare a possibly-garbage time_t value.
7474
9910e595
PE
7475 GLYPH_CODE_FACE returns EMACS_INT, not int.
7476 * dispextern.h (merge_faces):
7477 * xfaces.c (merge_faces):
01103c44
PE
7478 * xdisp.c (get_next_display_element, next_element_from_display_vector):
7479 Don't assume EMACS_INT fits in int.
9910e595 7480
2638320e
PE
7481 * character.h (CHAR_VALID_P): Remove unused parameter.
7482 * fontset.c, lisp.h, xdisp.c: All uses changed.
7483
045eb8d9
PE
7484 * editfns.c (Ftranslate_region_internal): Omit redundant test.
7485
c1f134b5
PE
7486 * fns.c (concat): Minor tuning based on overflow analysis.
7487 This doesn't fix any bugs. Use int to hold character, instead
7488 of constantly refetching from Emacs object. Use XFASTINT, not
7489 XINT, for value known to be a character. Don't bother comparing
7490 a single byte to 0400, as it's always less.
7491
395fcb93 7492 * floatfns.c (Fexpt):
327eeec8
PE
7493 * fileio.c (make_temp_name): Omit unnecessary cast to unsigned.
7494
abbd3d23
PE
7495 * editfns.c (Ftranslate_region_internal): Use int, not EMACS_INT
7496 for characters.
7497
684a03ef
PE
7498 * doc.c (get_doc_string): Omit (unsigned)c that mishandled negatives.
7499
0fed43f3
PE
7500 * data.c (Faset): If ARRAY is a string, check that NEWELT is a char.
7501 Without this fix, on a 64-bit host (aset S 0 4294967386) would
7502 incorrectly succeed when S was a string, because 4294967386 was
7503 truncated before it was used.
7504
8fd02eb7
PE
7505 * chartab.c (Fchar_table_range): Use CHARACTERP to check range.
7506 Otherwise, an out-of-range integer could cause undefined behavior
7507 on a 64-bit host.
7508
f8c86b69
PE
7509 * composite.c: Use int, not EMACS_INT, for characters.
7510 (fill_gstring_body, composition_compute_stop_pos): Use int, not
7511 EMACS_INT, for values that are known to be in character range.
7512 This doesn't fix any bugs but is the usual style inside Emacs and
7513 may generate better code on 32-bit machines.
7514
34206dd2
PE
7515 Make sure a 64-bit char is never passed to ENCODE_CHAR.
7516 This is for reasons similar to the recent CHAR_STRING fix.
7517 * charset.c (Fencode_char): Check that character arg is actually
7518 a character. Pass an int to ENCODE_CHAR.
7519 * charset.h (ENCODE_CHAR): Verify that the character argument is no
7520 wider than 'int', as a compile-time check to prevent future regressions
7521 in this area.
7522
c5958d4c 7523 * character.c (char_string): Remove unnecessary casts.
13bdea59
PE
7524
7525 Make sure a 64-bit char is never passed to CHAR_STRING.
7526 Otherwise, CHAR_STRING would do the wrong thing on a 64-bit platform,
7527 by silently ignoring the top 32 bits, allowing some values
7528 that were far too large to be valid characters.
7529 * character.h: Include <verify.h>.
7530 (CHAR_STRING, CHAR_STRING_ADVANCE): Verify that the character
7531 arguments are no wider than unsigned, as a compile-time check
7532 to prevent future regressions in this area.
7533 * data.c (Faset):
01103c44 7534 * editfns.c (Fchar_to_string, general_insert_function, Finsert_char)
13bdea59
PE
7535 (Fsubst_char_in_region):
7536 * fns.c (concat):
7537 * xdisp.c (decode_mode_spec_coding):
7538 Adjust to CHAR_STRING's new requirement.
7539 * editfns.c (Finsert_char, Fsubst_char_in_region):
7540 * fns.c (concat): Check that character args are actually
7541 characters. Without this test, these functions did the wrong
7542 thing with wildly out-of-range values on 64-bit hosts.
7543
d37ca623
PE
7544 Remove incorrect casts to 'unsigned' that lose info on 64-bit hosts.
7545 These casts should not be needed on 32-bit hosts, either.
7546 * keyboard.c (read_char):
7547 * lread.c (Fload): Remove casts to unsigned.
7548
ea204efb
PE
7549 * lisp.h (UNSIGNED_CMP): New macro.
7550 This fixes comparison bugs on 64-bit hosts.
7551 (ASCII_CHAR_P): Use it.
7552 * casefiddle.c (casify_object):
01103c44 7553 * character.h (ASCII_BYTE_P, CHAR_VALID_P)
ea204efb
PE
7554 (SINGLE_BYTE_CHAR_P, CHAR_STRING):
7555 * composite.h (COMPOSITION_ENCODE_RULE_VALID):
7556 * dispextern.h (FACE_FROM_ID):
7557 * keyboard.c (read_char): Use UNSIGNED_CMP.
7558
41cb286c
PE
7559 * xmenu.c (dialog_selection_callback) [!USE_GTK]: Cast to intptr_t,
7560 not to EMACS_INT, to avoid GCC warning.
7561
4a1b9832
PE
7562 * xfns.c (x_set_scroll_bar_default_width): Remove unused 'int' locals.
7563
55daad71
PE
7564 * buffer.h (PTR_BYTE_POS, BUF_PTR_BYTE_POS): Remove harmful cast.
7565 The cast incorrectly truncated 64-bit byte offsets to 32 bits, and
7566 isn't needed on 32-bit machines.
8f95c75c 7567
01103c44
PE
7568 * buffer.c (Fgenerate_new_buffer_name):
7569 Use EMACS_INT for count, not int.
0ceccced 7570 (advance_to_char_boundary): Return EMACS_INT, not int.
e762cafe
PE
7571
7572 * data.c (Qcompiled_function): Now static.
7573
c6f072e7
PE
7574 * window.c (window_body_lines): Now static.
7575
20ce5912
PE
7576 * image.c (gif_load): Rename local to avoid shadowing.
7577
9c4c5f81
PE
7578 * lisp.h (SAFE_ALLOCA_LISP): Check for integer overflow.
7579 (struct Lisp_Save_Value): Use ptrdiff_t, not int, for 'integer' member.
7580 * alloc.c (make_save_value): Integer argument is now of type
7581 ptrdiff_t, not int.
7582 (mark_object): Use ptrdiff_t, not int.
7583 * lisp.h (pD): New macro.
7584 * print.c (print_object): Use it.
7585
c0c5c8ae
PE
7586 * alloc.c: Use EMACS_INT, not int, to count objects.
7587 (total_conses, total_markers, total_symbols, total_vector_size)
7588 (total_free_conses, total_free_markers, total_free_symbols)
01103c44
PE
7589 (total_free_floats, total_floats, total_free_intervals)
7590 (total_intervals, total_strings, total_free_strings):
c0c5c8ae
PE
7591 Now EMACS_INT, not int. All uses changed.
7592 (Fgarbage_collect): Compute overall total using a double, so that
7593 integer overflow is less likely to be a problem. Check for overflow
7594 when converting back to an integer.
5a25e253
PE
7595 (n_interval_blocks, n_string_blocks, n_float_blocks, n_cons_blocks)
7596 (n_vectors, n_symbol_blocks, n_marker_blocks): Remove.
7597 These were 'int' variables that could overflow on 64-bit hosts;
7598 they were never used, so remove them instead of repairing them.
211a0b2a 7599 (nzombies, ngcs, max_live, max_zombies): Now EMACS_INT, not 'int'.
6349ae4d
PE
7600 (inhibit_garbage_collection): Set gc_cons_threshold to max value.
7601 Previously, this ceilinged at INT_MAX, but that doesn't work on
7602 64-bit machines.
e46bb31a 7603 (allocate_pseudovector): Don't use EMACS_INT when int would do.
c0c5c8ae 7604
c78baabf 7605 * alloc.c (Fmake_bool_vector): Don't assume vector size fits in int.
86f61a15 7606 (allocate_vectorlike): Check for ptrdiff_t overflow.
b6439961
PE
7607 (mark_vectorlike, mark_char_table, mark_object): Avoid EMACS_UINT
7608 when a (possibly-narrower) signed value would do just as well.
7609 We prefer using signed arithmetic, to avoid comparison confusion.
c78baabf 7610
c9d624c6
PE
7611 * alloc.c: Catch some string size overflows that we were missing.
7612 (XMALLOC_OVERRUN_CHECK_SIZE) [!XMALLOC_OVERRUN_CHECK]: Define to 0,
7613 for convenience in STRING_BYTES_MAX.
7614 (STRING_BYTES_MAX): New macro, superseding the old one in lisp.h.
7615 The definition here is exact; the one in lisp.h was approximate.
7616 (allocate_string_data): Check for string overflow. This catches
7617 some instances we weren't catching before. Also, it catches
7618 size_t overflow on (unusual) hosts where SIZE_MAX <= min
7619 (PTRDIFF_MAX, MOST_POSITIVE_FIXNUM), e.g., when size_t is 32 bits
7620 and ptrdiff_t and EMACS_INT are both 64 bits.
c78baabf 7621
c9d624c6
PE
7622 * character.c, coding.c, doprnt.c, editfns.c, eval.c:
7623 All uses of STRING_BYTES_MAX replaced by STRING_BYTES_BOUND.
640c8776 7624 * lisp.h (STRING_BYTES_BOUND): Rename from STRING_BYTES_MAX.
c9d624c6 7625
353032ce
PE
7626 * character.c (string_escape_byte8): Fix nbytes/nchars typo.
7627
2bccce07
PE
7628 * alloc.c (Fmake_string): Check for out-of-range init.
7629
0ac30604
SM
76302011-06-15 Stefan Monnier <monnier@iro.umontreal.ca>
7631
7632 * eval.c (Fdefvaralias): Also mark the target as variable-special-p.
7633
c195f2de
JD
76342011-06-14 Jan Djärv <jan.h.d@swipnet.se>
7635
7636 * xfns.c (x_set_scroll_bar_default_width): Remove argument to
7637 xg_get_default_scrollbar_width.
7638
7639 * gtkutil.c: Include emacsgtkfixed.h if HAVE_GTK3.
7640 (int_gtk_range_get_value): Move to the scroll bar part of the file.
7641 (style_changed_cb): Call update_theme_scrollbar_width and call
7642 x_set_scroll_bar_default_width and xg_frame_set_char_size for
7643 all frames (Bug#8505).
7644 (xg_create_frame_widgets): Call emacs_fixed_new if HAVE_GTK3 (Bug#8505).
7645 Call gtk_window_set_resizable if HAVE_GTK3.
7646 (x_wm_set_size_hint): Call emacs_fixed_set_min_size with min width
7647 and height if HAVE_GTK3 (Bug#8505).
7648 (scroll_bar_width_for_theme): New variable.
7649 (update_theme_scrollbar_width): New function.
7650 (xg_get_default_scrollbar_width): Move code to
7651 update_theme_scrollbar_width, just return scroll_bar_width_for_theme.
7652 (xg_initialize): Call update_theme_scrollbar_width.
7653
7654 * gtkutil.h (xg_get_default_scrollbar_width): Remove argument.
7655
7656 * emacsgtkfixed.c, emacsgtkfixed.h: New files.
7657
e10ac9f1
MR
76582011-06-12 Martin Rudalics <rudalics@gmx.at>
7659
7660 * frame.c (make_frame): Call other_buffer_safely instead of
7661 other_buffer.
7662
7663 * window.c (temp_output_buffer_show): Call display_buffer with
7664 second argument Vtemp_buffer_show_specifiers and reset latter
7665 immediately after the call.
7666 (Vtemp_buffer_show_specifiers): New variable.
7667 (auto_window_vscroll_p, next_screen_context_lines)
7668 (Vscroll_preserve_screen_position): Remove leading asterisks from
7669 doc-strings.
7670
2d3c217e 76712011-06-12 Paul Eggert <eggert@cs.ucla.edu>
4475bec4 7672
7b7f97e8 7673 Fix minor problems found by GCC 4.6.0 static checking.
4475bec4
PE
7674 * buffer.c (Qclone_number): Remove for now, as it's unused.
7675 (record_buffer, Funrecord_buffer): Rename local to avoid shadowing.
7676 (record_buffer): Remove unused local.
7677 * frame.c (other_visible_frames, frame_buffer_list): Now static.
7678 (set_frame_buffer_list): Remove; unused.
7679 * frame.h (other_visible_frames): Remove decl.
7680 * keyboard.h (menu_items_inuse): Declare only if USE_GTK || USE_MOTIF.
7681 * lisp.h (frame_buffer_list, set_frame_buffer_list): Remove decls.
7682 (add_gpm_wait_descriptor, delete_gpm_wait_descriptor): Declare only
7683 if HAVE_GPM.
7684 * menu.c (menu_items_inuse): Now static unless USE_GTK || USE_MOTIF.
7685 * process.c (add_gpm_wait_descriptor, delete_gpm_wait_descriptor):
7686 Define only if HAVE_GPM.
7687 * widget.c (EmacsFrameResize, emacsFrameClassRec): Now static.
7688 (update_hints_inhibit): Remove; never set. All uses removed.
7689 * widgetprv.h (emacsFrameClassRec): Remove decl.
7690 * window.c (delete_deletable_window): Now returns void, since it
7691 wasn't returning anything.
7692 (compare_window_configurations): Remove unused locals.
7693 * xfns.c (x_set_scroll_bar_default_width): Remove unused locals.
7694 * xmenu.c (x_menu_set_in_use): Define only if USE_GTK || USE_MOTIF.
4475bec4
PE
7695 (dialog_selection_callback) [!USE_GTK]: Prefer intptr_t for integers
7696 the same widths as pointers. This follows up on the 2011-05-06 patch.
7697 * xterm.c (x_alloc_lighter_color_for_widget): Define only if USE_LUCID.
7698 * xterm.h: Likewise.
7699 (x_menu_set_in_use): Declare only if USE_GTK || USE_MOTIF.
7700
1384b89e
JB
77012011-06-12 Juanma Barranquero <lekktu@gmail.com>
7702
7703 * makefile.w32-in: Update dependencies.
7704 (LISP_H): Add lib/intprops.h.
7705
1100a63c
CY
77062011-06-11 Chong Yidong <cyd@stupidchicken.com>
7707
7708 * image.c (gif_load): Add animation frame delay to the metadata.
7709 (syms_of_image): Use DEFSYM. New symbol `delay'.
7710
6198ccd0
MR
77112011-06-11 Martin Rudalics <rudalics@gmx.at>
7712
7713 * window.c (delete_deletable_window): Re-add.
7714 (Fset_window_configuration): Rewrite to handle dead buffers and
7715 consequently deletable windows.
7716 (window_tree, Fwindow_tree): Remove. Supply functionality in
7717 window.el.
7718 (compare_window_configurations): Simplify code.
7719
b6e3633c
AS
77202011-06-11 Andreas Schwab <schwab@linux-m68k.org>
7721
1ab0dee5
AS
7722 * image.c (imagemagick_load_image): Fix type mismatch.
7723 (Fimagemagick_types): Likewise.
7724
b6e3633c
AS
7725 * window.h (replace_buffer_in_windows): Declare.
7726
9397e56f
MR
77272011-06-11 Martin Rudalics <rudalics@gmx.at>
7728
7729 * buffer.c: New Lisp objects Qbuffer_list_update_hook and
7730 Qclone_number. Remove external declaration of Qdelete_window.
7731 (Fbuffer_list): Rewrite doc-string. Minor restructuring of
7732 code.
640c8776
SM
7733 (Fget_buffer_create, Fmake_indirect_buffer, Frename_buffer):
7734 Run Qbuffer_list_update_hook if allowed.
9397e56f
MR
7735 (Fother_buffer): Rewrite doc-string. Major rewrite for new
7736 buffer list implementation.
7737 (other_buffer_safely): New function.
7738 (Fkill_buffer): Replace call to replace_buffer_in_all_windows by
7739 calls to replace_buffer_in_windows and
7740 replace_buffer_in_windows_safely. Run Qbuffer_list_update_hook
7741 if allowed.
7742 (record_buffer): Inhibit quitting and rewrite using quittable
7743 functions. Run Qbuffer_list_update_hook if allowed.
7744 (Frecord_buffer, Funrecord_buffer): New functions.
640c8776
SM
7745 (switch_to_buffer_1, Fswitch_to_buffer): Remove.
7746 Move switch-to-buffer to window.el.
9397e56f
MR
7747 (bury-buffer): Move to window.el.
7748 (Vbuffer_list_update_hook): New variable.
7749
7750 * lisp.h (other_buffer_safely): Add prototype in buffer.c
7751 section.
7752
7753 * window.h (resize_frame_windows): Move up in code.
7754 (Fwindow_frame): Remove EXFUN.
7755 (replace_buffer_in_all_windows): Remove prototype.
7756 (replace_buffer_in_windows_safely): Add prototype.
7757
7758 * window.c: Declare Qdelete_window static again. Move down
7759 declaration of select_count.
7760 (Fnext_window, Fprevious_window): Rewrite doc-strings.
7761 (Fother_window): Move to window.el.
7762 (window_loop): Remove DELETE_BUFFER_WINDOWS and UNSHOW_BUFFER
7763 cases. Add REPLACE_BUFFER_IN_WINDOWS_SAFELY case.
7764 (Fdelete_windows_on, Freplace_buffer_in_windows): Move to
7765 window.el.
7766 (replace_buffer_in_windows): Implement by calling
7767 Qreplace_buffer_in_windows.
7768 (replace_buffer_in_all_windows): Remove with some functionality
7769 moved into replace_buffer_in_windows_safely.
7770 (replace_buffer_in_windows_safely): New function.
7771 (select_window_norecord, select_frame_norecord): Move in front
7772 of run_window_configuration_change_hook. Remove now obsolete
7773 declarations.
640c8776
SM
7774 (Fset_window_buffer): Rewrite doc-string.
7775 Call Qrecord_window_buffer.
9397e56f
MR
7776 (keys_of_window): Move binding for other-window to window.el.
7777
b50691aa
CY
77782011-06-11 Chong Yidong <cyd@stupidchicken.com>
7779
7780 * dispextern.h (struct image): Replace data member, whose int_val
7781 and ptr_val fields were not used by anything, with a single
7782 lisp_val object.
7783
7784 * image.c (Fimage_metadata, make_image, mark_image, tiff_load)
7785 (gif_clear_image, gif_load, imagemagick_load_image)
7786 (gs_clear_image, gs_load): Callers changed.
7787
3f754b86
PE
77882011-06-10 Paul Eggert <eggert@cs.ucla.edu>
7789
cca69397
PE
7790 * buffer.h: Include <time.h>, for time_t.
7791 Needed to build on FreeBSD 8.2. Problem reported by Herbert J. Skuhra.
7792
109e28d0
PE
7793 Fix minor problems found by static checking.
7794
60737f02
PE
7795 * image.c (PixelGetMagickColor): Declare if ImageMagick headers don't.
7796
4b66faf3
PE
7797 Make identifiers static if they are not used in other modules.
7798 * data.c (Qcompiled_function, Qframe, Qvector):
7799 * image.c (QimageMagick, Qsvg):
7800 * minibuf.c (Qmetadata):
7801 * window.c (resize_window_check, resize_root_window): Now static.
7802 * window.h (resize_window_check, resize_root_window): Remove decls.
7803
109e28d0
PE
7804 * window.c (window_deletion_count, delete_deletable_window):
7805 Remove; unused.
46a4ce9e
PE
7806 (window_body_lines): Now static.
7807 (Fdelete_other_windows_internal): Mark vars as initialized.
7808 Make sure 'resize_failed' is initialized.
7809 (run_window_configuration_change_hook): Rename local to avoid shadowing.
7810 (resize_window_apply): Remove unused local.
7811 * window.h (delete_deletable_window): Remove decl.
7812
109e28d0 7813 * image.c (gif_load, svg_load_image): Rename locals to avoid shadowing.
33290528
PE
7814 (imagemagick_load_image): Fix pointer signedness problem by changing
7815 last arg from unsigned char * to char *. All uses changed.
7816 Also, fix a local for similar reasons.
7817 Remove unused locals. Remove locals to avoid shadowing.
7818 (fn_rsvg_handle_free): Remove; unused.
7819 (svg_load, svg_load_image): Fix pointer signedness problem.
f7e13da3 7820 (imagemagick_load_image): Don't use garbage pointer image_wand.
33290528 7821
3f754b86
PE
7822 * ftfont.c (ftfont_get_metrics, ftfont_drive_otf): Remove unused locals.
7823
2547adb1
CY
78242011-06-10 Chong Yidong <cyd@stupidchicken.com>
7825
7826 * image.c (gif_load): Fix omitted cast error introduced by
7827 2011-06-06 change.
7828
2c8e37d4
MR
78292011-06-10 Martin Rudalics <rudalics@gmx.at>
7830
7831 * window.h (resize_proportionally, orig_total_lines)
7832 (orig_top_line): Remove from window structure.
7833 (set_window_height, set_window_width, change_window_heights)
7834 (Fdelete_window): Remove prototypes.
7835 (resize_frame_windows): Remove duplicate declaration.
7836
440a42e3
EZ
78372011-06-10 Eli Zaretskii <eliz@gnu.org>
7838
7839 * window.h (resize_frame_windows, resize_window_check)
7840 (delete_deletable_window, resize_root_window)
7841 (resize_frame_windows): Declare prototypes.
7842
7843 * window.c (resize_window_apply): Make definition be "static" to
7844 match the prototype.
7845
562dd5e9
MR
78462011-06-10 Martin Rudalics <rudalics@gmx.at>
7847
7848 * window.c: Remove declarations of Qwindow_size_fixed,
7849 window_min_size_1, window_min_size_2, window_min_size,
7850 size_window, window_fixed_size_p, enlarge_window, delete_window.
7851 Remove static from declaration of Qdelete_window, it's
7852 temporarily needed by Fbury_buffer.
7853 (replace_window): Don't assign orig_top_line and
7854 orig_total_lines.
7855 (Fdelete_window, delete_window): Remove. Window deletion is
7856 handled by window.el.
640c8776
SM
7857 (window_loop): Remove DELETE_OTHER_WINDOWS case.
7858 Replace Fdelete_window calls with calls to Qdelete_window.
562dd5e9
MR
7859 (Fdelete_other_windows): Remove. Deleting other windows is
7860 handled by window.el.
7861 (window_fixed_size_p): Remove. Fixed-sizeness of windows is
7862 handled in window.el.
7863 (window_min_size_2, window_min_size_1, window_min_size): Remove.
7864 Window minimum sizes are handled in window.el.
7865 (shrink_windows, size_window, set_window_height)
7866 (set_window_width, change_window_heights, window_height)
7867 (window_width, CURBEG, CURSIZE, enlarge_window)
7868 (adjust_window_trailing_edge, Fadjust_window_trailing_edge)
7869 (Fenlarge_window, Fshrink_window): Remove. Window resizing is
7870 handled in window.el.
7871 (make_dummy_parent): Rename to make_parent_window and give it a
7872 second argument horflag.
7873 (make_window): Don't set resize_proportionally any more.
7874 (Fsplit_window): Remove. Windows are split in window.el.
7875 (save_restore_action, save_restore_orig_size)
7876 (shrink_window_lowest_first, save_restore_orig_size): Remove.
7877 Resize mini windows in window.el.
7878 (grow_mini_window, shrink_mini_window): Implement by calling
7879 Qresize_root_window_vertically, resize_window_check and
7880 resize_window_apply.
640c8776
SM
7881 (saved_window, Fset_window_configuration, save_window_save):
7882 Do not handle orig_top_line, orig_total_lines, and
562dd5e9
MR
7883 resize_proportionally.
7884 (window_min_height, window_min_width): Move to window.el.
7885 (keys_of_window): Move bindings for delete-other-windows,
7886 split-window, delete-window and enlarge-window to window.el.
7887
7888 * buffer.c: Temporarily extern Qdelete_window.
7889 (Fbury_buffer): Temporarily call Qdelete_window instead of
7890 Fdelete_window (Fbury_buffer will move to window.el soon).
7891
7892 * frame.c (set_menu_bar_lines_1): Remove code handling
7893 orig_top_line and orig_total_lines.
7894
7895 * dispnew.c (adjust_frame_glyphs_initially): Don't use
7896 set_window_height but set heights directly.
7897 (change_frame_size_1): Use resize_frame_windows.
7898
7899 * xdisp.c (init_xdisp): Don't use set_window_height but set
7900 heights directly.
7901
640c8776
SM
7902 * xfns.c (x_set_menu_bar_lines, x_set_tool_bar_lines):
7903 Use resize_frame_windows instead of change_window_heights and run
562dd5e9
MR
7904 run_window_configuration_change_hook.
7905
7906 * w32fns.c (x_set_tool_bar_lines): Use resize_frame_windows
7907 instead of change_window_heights and run
7908 run_window_configuration_change_hook.
7909
1a13852e
MR
79102011-06-09 Martin Rudalics <rudalics@gmx.at>
7911
7912 * window.c (replace_window): Rename second argument REPLACEMENT to
7913 NEW. New third argument SETFLAG. Rewrite.
7914 (delete_window, make_dummy_parent): Call replace_window with
7915 third argument 1.
7916 (window_list_1): Move down in code.
7917 (run_window_configuration_change_hook): Move set_buffer part
7918 before select_frame_norecord part in order to unwind correctly.
7919 Rename count1 to count.
7920 (recombine_windows, delete_deletable_window, resize_root_window)
7921 (Fdelete_other_windows_internal)
7922 (Frun_window_configuration_change_hook, make_parent_window)
7923 (resize_window_check, resize_window_apply, Fresize_window_apply)
7924 (resize_frame_windows, Fsplit_window_internal)
640c8776
SM
7925 (Fdelete_window_internal, Fresize_mini_window_internal):
7926 New functions.
1a13852e
MR
7927 (syms_of_window): New variables Vwindow_splits and Vwindow_nest.
7928
f3d1777e
MR
79292011-06-08 Martin Rudalics <rudalics@gmx.at>
7930
496e208e
MR
7931 * window.h (window): Add some new members to window structure -
7932 normal_lines, normal_cols, new_total, new_normal, clone_number,
7933 splits, nest, prev_buffers, next_buffers.
7934 (WINDOW_TOTAL_SIZE): Move here from window.c.
b9e809c2 7935 (MIN_SAFE_WINDOW_WIDTH, MIN_SAFE_WINDOW_HEIGHT): Define here.
496e208e 7936
f3d1777e
MR
7937 * window.c (Fwindow_height, Fwindow_width, Fwindow_full_width_p):
7938 Remove.
496e208e
MR
7939 (make_dummy_parent): Set new members of windows structure.
7940 (make_window): Move down in code. Handle new members of window
7941 structure.
7942 (Fwindow_clone_number, Fwindow_splits, Fset_window_splits)
7943 (Fwindow_nest, Fset_window_nest, Fwindow_new_total)
7944 (Fwindow_normal_size, Fwindow_new_normal, Fwindow_prev_buffers)
7945 (Fset_window_prev_buffers, Fwindow_next_buffers)
640c8776
SM
7946 (Fset_window_next_buffers, Fset_window_clone_number):
7947 New functions.
496e208e
MR
7948 (Fwindow_hscroll, Fwindow_at, Fwindow_point, Fwindow_start)
7949 (Fwindow_end, Fwindow_line_height, Fset_window_dedicated_p):
7950 Doc-string fixes.
7951 (Fwindow_parameters, Fwindow_parameter, Fset_window_parameter):
7952 Argument WINDOW can be now internal window too.
7953 (Fwindow_use_time): Move up in code.
7954 (Fget_buffer_window): Rename argument FRAME to ALL-FRAMES.
7955 Rewrite doc-string.
7956 (Fset_window_configuration, saved_window)
7957 (Fcurrent_window_configuration, save_window_save): Handle new
7958 members of window structure.
b9e809c2
MR
7959 (WINDOW_TOTAL_SIZE, MIN_SAFE_WINDOW_WIDTH)
7960 (MIN_SAFE_WINDOW_HEIGHT): Move to window.h.
7961 (syms_of_window): New Lisp objects Qrecord_window_buffer,
7962 Qwindow_deletable_p, Qdelete_window, Qreplace_buffer_in_windows,
7963 Qget_mru_window, Qresize_root_window,
7964 Qresize_root_window_vertically, Qsafe, Qabove, Qbelow,
7965 Qauto_buffer_name; staticpro them.
f3d1777e 7966
abde8f8c
MR
79672011-06-07 Martin Rudalics <rudalics@gmx.at>
7968
7969 * window.c (Fwindow_total_size, Fwindow_left_column)
7970 (Fwindow_top_line, window_body_lines, Fwindow_body_size)
7971 (Fwindow_list_1): New functions.
7972 (window_box_text_cols): Replace with window_body_cols.
640c8776
SM
7973 (Fwindow_width, Fscroll_left, Fscroll_right):
7974 Use window_body_cols instead of window_box_text_cols.
7975 (delete_window, Fset_window_configuration):
7976 Call delete_all_subwindows with window as argument.
fa8a67e6
MR
7977 (delete_all_subwindows): Take a window as argument and not a
7978 structure. Rewrite.
190b47e6
MR
7979 (window_loop): Remove handling of GET_LRU_WINDOW and
7980 GET_LARGEST_WINDOW.
7981 (Fget_lru_window, Fget_largest_window): Move to window.el.
abde8f8c
MR
7982
7983 * window.h: Extern window_body_cols instead of
fa8a67e6
MR
7984 window_box_text_cols. delete_all_subwindows now takes a
7985 Lisp_Object as argument.
abde8f8c 7986
640c8776
SM
7987 * indent.c (compute_motion, Fcompute_motion):
7988 Use window_body_cols instead of window_box_text_cols.
abde8f8c 7989
fa8a67e6
MR
7990 * frame.c (delete_frame): Call delete_all_subwindows with root
7991 window as argument.
7992
a54e3482
DC
79932011-06-07 Daniel Colascione <dan.colascione@gmail.com>
7994
7995 * fns.c (Fputhash): Document return value.
7996
60002bf5
CY
79972011-06-06 Chong Yidong <cyd@stupidchicken.com>
7998
7999 * image.c (gif_load): Implement gif89a spec "no disposal" method.
8000
0c671da6 80012011-06-06 Paul Eggert <eggert@cs.ucla.edu>
ccd9a01a 8002
b862a52a 8003 Cons<->int and similar integer overflow fixes (Bug#8794).
77984278 8004
be44ca6c
PE
8005 Check for overflow when converting integer to cons and back.
8006 * charset.c (Fdefine_charset_internal, Fdecode_char):
8007 Use cons_to_unsigned to catch overflow.
8008 (Fencode_char): Use INTEGER_TO_CONS.
8009 * composite.h (LGLYPH_CODE): Use cons_to_unsigned.
8010 (LGLYPH_SET_CODE): Use INTEGER_TO_CONS.
8011 * data.c (long_to_cons, cons_to_long): Remove.
8012 (cons_to_unsigned, cons_to_signed): New functions.
8013 These signal an error for invalid or out-of-range values.
8014 * dired.c (Ffile_attributes): Use INTEGER_TO_CONS.
8015 * fileio.c (Fset_visited_file_modtime): Use CONS_TO_INTEGER.
8016 * font.c (Ffont_variation_glyphs):
8017 * fontset.c (Finternal_char_font): Use INTEGER_TO_CONS.
8018 * lisp.h: Include <intprops.h>.
8019 (INTEGER_TO_CONS, CONS_TO_INTEGER): New macros.
8020 (cons_to_signed, cons_to_unsigned): New decls.
8021 (long_to_cons, cons_to_long): Remove decls.
8022 * undo.c (record_first_change): Use INTEGER_TO_CONS.
8023 (Fprimitive_undo): Use CONS_TO_INTEGER.
8024 * xfns.c (Fx_window_property): Likewise.
8025 * xselect.c: Include <limits.h>.
8026 (x_own_selection, selection_data_to_lisp_data):
8027 Use INTEGER_TO_CONS.
8028 (x_handle_selection_request, x_handle_selection_clear)
8029 (x_get_foreign_selection, Fx_disown_selection_internal)
8030 (Fx_get_atom_name, x_send_client_event): Use CONS_TO_INTEGER.
8031 (lisp_data_to_selection_data): Use cons_to_unsigned.
8032 (x_fill_property_data): Use cons_to_signed.
8033 Report values out of range.
8034
d1f3d2af
PE
8035 Check for buffer and string overflow more precisely.
8036 * buffer.h (BUF_BYTES_MAX): New macro.
8037 * lisp.h (STRING_BYTES_MAX): New macro.
8038 * alloc.c (Fmake_string):
8039 * character.c (string_escape_byte8):
8040 * coding.c (coding_alloc_by_realloc):
8041 * doprnt.c (doprnt):
8042 * editfns.c (Fformat):
8043 * eval.c (verror):
8044 Use STRING_BYTES_MAX, not MOST_POSITIVE_FIXNUM,
8045 since they may not be the same number.
8046 * editfns.c (Finsert_char):
8047 * fileio.c (Finsert_file_contents):
8048 Likewise for BUF_BYTES_MAX.
8049
dd52fcea
PE
8050 * image.c: Use ptrdiff_t, not int, for sizes.
8051 (slurp_file): Switch from int to ptrdiff_t.
8052 All uses changed.
8053 (slurp_file): Check that file size fits in both size_t (for
8054 malloc) and ptrdiff_t (for sanity and safety).
8055
7f9bbdbb
PE
8056 * fileio.c (Fverify_visited_file_modtime): Avoid time overflow
8057 if b->modtime has its maximal value.
8058
dfe18f82
PE
8059 * dired.c (Ffile_attributes): Don't assume EMACS_INT has >32 bits.
8060
84acfcf0
PE
8061 Don't assume time_t can fit into int.
8062 * buffer.h (struct buffer.modtime): Now time_t, not int.
8063 * fileio.c (Fvisited_file_modtime): No need for time_t cast now.
8064 * undo.c (Fprimitive_undo): Use time_t, not int, for time_t value.
8065
ccd9a01a
PE
8066 Minor fixes for signed vs unsigned integers.
8067 * character.h (MAYBE_UNIFY_CHAR):
8068 * charset.c (maybe_unify_char):
8069 * keyboard.c (read_char, reorder_modifiers):
8070 XINT -> XFASTINT, since the integer must be nonnegative.
8071 * ftfont.c (ftfont_spec_pattern):
8072 * keymap.c (access_keymap, silly_event_symbol_error):
8073 XUINT -> XFASTINT, since the integer must be nonnegative.
8074 (Fsingle_key_description, preferred_sequence_p): XUINT -> XINT,
8075 since it makes no difference and we prefer signed.
8076 * keyboard.c (record_char): Use XUINT when all the neighbors do.
8077 (access_keymap): NATNUMP -> INTEGERP, since the integer must be
8078 nonnegative.
8079
d6d100dd
SM
80802011-06-06 Stefan Monnier <monnier@iro.umontreal.ca>
8081
8082 * window.h (Fwindow_frame): Declare.
8083
2b6148e4
PE
80842011-06-06 Paul Eggert <eggert@cs.ucla.edu>
8085
8086 * alloc.c: Simplify handling of large-request failures (Bug#8800).
8087 (SPARE_MEMORY): Always define.
8088 (LARGE_REQUEST): Remove.
8089 (memory_full): Use SPARE_MEMORY rather than LARGE_REQUEST.
8090
f230ecc9
MR
80912011-06-06 Martin Rudalics <rudalics@gmx.at>
8092
727e958e
MR
8093 * lisp.h: Move EXFUNS for Fframe_root_window,
8094 Fframe_first_window and Fset_frame_selected_window to window.h.
8095
8096 * window.h: Move EXFUNS for Fframe_root_window,
8097 Fframe_first_window and Fset_frame_selected_window here from
8098 lisp.h.
8099
8100 * frame.c (Fwindow_frame, Fframe_first_window)
8101 (Fframe_root_window, Fframe_selected_window)
8102 (Fset_frame_selected_window): Move to window.c.
8103 (Factive_minibuffer_window): Move to minibuf.c.
8104 (Fother_visible_frames_p): New function.
8105
8106 * minibuf.c (Factive_minibuffer_window): Move here from frame.c.
8107
f230ecc9
MR
8108 * window.c (decode_window, decode_any_window): Move up in code.
8109 (Fwindowp, Fwindow_live_p): Rewrite doc-strings.
8110 (inhibit_frame_unsplittable): Remove unused variable.
bf60a96b
MR
8111 (Fwindow_buffer): Move up and rewrite doc-string.
8112 (Fwindow_parent, Fwindow_vchild, Fwindow_hchild, Fwindow_next)
8113 (Fwindow_prev): New functions.
727e958e
MR
8114 (Fwindow_frame): Move here from frame.c. Accept any window as
8115 argument.
8116 (Fframe_root_window, Fframe_first_window)
8117 (Fframe_selected_window): Move here from frame.c. Accept frame
8118 or arbitrary window as argument. Update doc-strings.
8119 (Fminibuffer_window): Move up in code.
8120 (Fwindow_minibuffer_p): Move up in code and simplify.
d6d100dd
SM
8121 (Fset_frame_selected_window): Move here from frame.c.
8122 Marginal rewrite.
727e958e
MR
8123 (Fselected_window, select_window, Fselect_window): Move up in
8124 code. Minor doc-string fixes.
f230ecc9 8125
4d09bcf6
PE
81262011-06-06 Paul Eggert <eggert@cs.ucla.edu>
8127
8128 * alloc.c (memory_full) [SYSTEM_MALLOC]: Port to MacOS (Bug#8800).
8129 Do not assume that spare memory exists; that assumption is valid
8130 only if SYSTEM_MALLOC.
8131 (LARGE_REQUEST): New macro, so that the issue of large requests
8132 is separated from the issue of spare memory.
8133
810928a2
AS
81342011-06-05 Andreas Schwab <schwab@linux-m68k.org>
8135
172418ad
AS
8136 * editfns.c (Fformat): Correctly handle zero flag with hexadecimal
8137 format. (Bug#8806)
8138
43f862f7
AS
8139 * gtkutil.c (xg_get_default_scrollbar_width): Avoid warning.
8140
810928a2
AS
8141 * xfns.c (x_set_scroll_bar_default_width): Move declarations
8142 before statements.
8143
a059fe24
JD
81442011-06-05 Jan Djärv <jan.h.d@swipnet.se>
8145
8146 * gtkutil.c (xg_get_default_scrollbar_width): New function.
8147
8148 * gtkutil.h: Declare xg_get_default_scrollbar_width.
8149
8150 * xfns.c (x_set_scroll_bar_default_width): If USE_GTK, get
8151 min width by calling x_set_scroll_bar_default_width (Bug#8505).
8152
989bf368
JB
81532011-06-05 Juanma Barranquero <lekktu@gmail.com>
8154
8155 * xdisp.c (single_display_spec_intangible_p): Remove declaration.
8156
4b80f674
CY
81572011-06-04 Chong Yidong <cyd@stupidchicken.com>
8158
8159 * xselect.c (x_clipboard_manager_save): Remove redundant arg.
8160 (x_clipboard_manager_save): Add return value.
d6d100dd
SM
8161 (x_clipboard_manager_error_1, x_clipboard_manager_error_2):
8162 New error handlers.
4b80f674
CY
8163 (x_clipboard_manager_save_frame, x_clipboard_manager_save_all):
8164 Obey Vx_select_enable_clipboard_manager. Catch errors in
8165 x_clipboard_manager_save (Bug#8779).
8166 (Vx_select_enable_clipboard_manager): New variable.
de65b42c 8167 (x_get_foreign_selection): Reduce scope of x_catch_errors (Bug#8790).
4b80f674 8168
99a33b77 81692011-06-04 Dan Nicolaescu <dann@ics.uci.edu>
8b3115e7
DN
8170
8171 * emacs.c (main): Warn when starting a GTK emacs in daemon mode.
8172
99a33b77 81732011-06-04 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
14eca62f
YM
8174
8175 * fringe.c (update_window_fringes): Don't update overlay arrow bitmap
8176 in the current matrix if keep_current_p is non-zero.
8177
8264569d
EZ
81782011-06-04 Eli Zaretskii <eliz@gnu.org>
8179
8180 * bidi.c (bidi_level_of_next_char): Fix last change.
8181
57f97249
EZ
81822011-06-03 Eli Zaretskii <eliz@gnu.org>
8183
fec2107c 8184 Support bidi reordering of text covered by display properties.
57f97249 8185
fec2107c
EZ
8186 * bidi.c (bidi_copy_it): Use offsetof instead of emulating it.
8187 (bidi_fetch_char, bidi_fetch_char_advance): New functions.
8188 (bidi_cache_search, bidi_cache_iterator_state)
8189 (bidi_paragraph_init, bidi_resolve_explicit, bidi_resolve_weak)
d6d100dd
SM
8190 (bidi_level_of_next_char, bidi_move_to_visually_next):
8191 Support character positions inside a run of characters covered by a
fec2107c
EZ
8192 display string.
8193 (bidi_paragraph_init, bidi_resolve_explicit_1)
8194 (bidi_level_of_next_char): Call bidi_fetch_char and
8195 bidi_fetch_char_advance instead of FETCH_CHAR and
8196 FETCH_CHAR_ADVANCE.
8197 (bidi_init_it): Initialize new members.
8198 (LRE_CHAR, RLE_CHAR, PDF_CHAR, LRO_CHAR, RLO_CHAR): Remove macro
8199 definitions.
8200 (bidi_explicit_dir_char): Lookup character type in bidi_type_table,
8201 instead of using explicit *_CHAR codes.
d6d100dd
SM
8202 (bidi_resolve_explicit, bidi_resolve_weak):
8203 Use FETCH_MULTIBYTE_CHAR instead of FETCH_CHAR, as reordering of
fec2107c
EZ
8204 bidirectional text is supported only in multibyte buffers.
8205 (bidi_init_it): Accept additional argument FRAME_WINDOW_P and use
8206 it to initialize the frame_window_p member of struct bidi_it.
8207 (bidi_cache_iterator_state, bidi_resolve_explicit_1)
8208 (bidi_resolve_explicit, bidi_resolve_weak)
8209 (bidi_level_of_next_char, bidi_move_to_visually_next): Abort if
8210 bidi_it->nchars is non-positive.
8211 (bidi_level_of_next_char): Don't try to lookup the cache for the
8212 next/previous character if nothing is cached there yet, or if we
8213 were just reseat()'ed to a new position.
c40e2fb2 8214
0e14fe90
EZ
8215 * xdisp.c (set_cursor_from_row): Set start and stop points
8216 according to the row's direction when priming the loop that looks
8217 for the glyph on which to display cursor.
8218 (single_display_spec_intangible_p): Function deleted.
8219 (display_prop_intangible_p): Reimplement to call
8220 handle_display_spec instead of single_display_spec_intangible_p.
d6d100dd
SM
8221 Accept 3 additional arguments needed by handle_display_spec.
8222 This fixes incorrect cursor motion across display property with complex
0e14fe90
EZ
8223 values: lists, `(when COND...)' forms, etc.
8224 (single_display_spec_string_p): Support property values that are
8225 lists with the argument STRING its top-level element.
8226 (display_prop_string_p): Fix the condition for processing a
8227 property that is a list to be consistent with handle_display_spec.
fec2107c 8228 (handle_display_spec): New function, refactored from the
fc6f18ce
EZ
8229 last portion of handle_display_prop.
8230 (compute_display_string_pos): Accept additional argument
8231 FRAME_WINDOW_P. Call handle_display_spec to determine whether the
8232 value of a `display' property is a "replacing spec".
8233 (handle_single_display_spec): Accept 2 additional arguments BUFPOS
8234 and FRAME_WINDOW_P. If IT is NULL, don't set up the iterator from
8235 the display property, but just return a value indicating whether
8236 the display property will replace the characters it covers.
8237 (Fcurrent_bidi_paragraph_direction): Initialize the nchars and
8238 frame_window_p members of struct bidi_it.
d6d100dd
SM
8239 (compute_display_string_pos, compute_display_string_end):
8240 New functions.
fec2107c
EZ
8241 (push_it): Accept second argument POSITION, where pop_it should
8242 jump to continue iteration.
8243 (reseat_1): Initialize bidi_it.disp_pos.
fc6f18ce 8244
fec2107c
EZ
8245 * keyboard.c (adjust_point_for_property): Adjust the call to
8246 display_prop_intangible_p to its new signature.
fc6f18ce
EZ
8247
8248 * dispextern.h (struct bidi_it): New member frame_window_p.
fec2107c
EZ
8249 (bidi_init_it): Update prototypes.
8250 (display_prop_intangible_p): Update prototype.
d6d100dd
SM
8251 (compute_display_string_pos, compute_display_string_end):
8252 Declare prototypes.
fec2107c
EZ
8253 (struct bidi_it): New members nchars and disp_pos. ch_len is now
8254 EMACS_INT.
fc6f18ce 8255
40087514 82562011-06-02 Paul Eggert <eggert@cs.ucla.edu>
0de4bb68 8257
57f53182
PE
8258 Malloc failure behavior now depends on size of allocation.
8259 * alloc.c (buffer_memory_full, memory_full): New arg NBYTES.
8260 * lisp.h: Change signatures accordingly.
8261 * alloc.c, buffer.c, editfns.c, menu.c, minibuf.c, xterm.c:
8262 All callers changed. (Bug#8762)
8263
8264 * gnutls.c: Use Emacs's memory allocators.
8265 Without this change, the gnutls library would invoke malloc etc.
8266 directly, which causes problems on non-SYNC_INPUT hosts, and which
8267 runs afoul of improving memory_full behavior. (Bug#8761)
8268 (fn_gnutls_global_set_mem_functions): New macro or function pointer.
8269 (emacs_gnutls_global_init): Use it to specify xmalloc, xrealloc,
8270 xfree instead of the default malloc, realloc, free.
8271 (Fgnutls_boot): No need to check for memory allocation failure,
8272 since xmalloc does that for us.
8273
ac32cd99 8274 Remove arbitrary limit of 2**31 entries in hash tables. (Bug#8771)
3870d916
PE
8275 * category.c (hash_get_category_set):
8276 * ccl.c (ccl_driver):
8277 * charset.c (Fdefine_charset_internal):
8278 * charset.h (struct charset.hash_index):
8279 * composite.c (get_composition_id, gstring_lookup_cache)
8280 (composition_gstring_put_cache):
8281 * composite.h (struct composition.hash_index):
8282 * dispextern.h (struct image.hash):
8283 * fns.c (next_almost_prime, larger_vector, cmpfn_eql)
8284 (cmpfn_equal, cmpfn_user_defined, hashfn_eq, hashfn_eql)
8285 (hashfn_equal, hashfn_user_defined, make_hash_table)
8286 (maybe_resize_hash_table, hash_lookup, hash_put)
8287 (hash_remove_from_table, hash_clear, sweep_weak_table, SXHASH_COMBINE)
8288 (sxhash_string, sxhash_list, sxhash_vector, sxhash_bool_vector)
8289 (Fsxhash, Fgethash, Fputhash, Fmaphash):
8290 * image.c (make_image, search_image_cache, lookup_image)
8291 (xpm_put_color_table_h):
8292 * lisp.h (struct Lisp_Hash_Table):
0de4bb68 8293 * minibuf.c (Ftry_completion, Fall_completions, Ftest_completion):
ac389d0c 8294 * print.c (print): Use 'EMACS_UINT' and 'EMACS_INT'
3870d916 8295 for hashes and hash indexes, instead of 'unsigned' and 'int'.
40087514
PE
8296 * alloc.c (allocate_vectorlike):
8297 Check for overflow in vector size calculations.
8298 * ccl.c (ccl_driver):
8299 Check for overflow when converting EMACS_INT to int.
0de4bb68
PE
8300 * fns.c, image.c: Remove unnecessary static decls that would otherwise
8301 need to be updated by these changes.
40087514
PE
8302 * fns.c (make_hash_table, maybe_resize_hash_table):
8303 Check for integer overflow with large hash tables.
0de4bb68
PE
8304 (make_hash_table, maybe_resize_hash_table, Fmake_hash_table):
8305 Prefer the faster XFLOAT_DATA to XFLOATINT where either will do.
8306 (SXHASH_REDUCE): New macro.
8307 (sxhash_string, sxhash_list, sxhash_vector, sxhash_bool_vector):
8308 Use it instead of discarding useful hash info with large hash values.
8309 (sxhash_float): New function.
8310 (sxhash): Use it. No more need for "& INTMASK" due to above changes.
8311 * lisp.h (FIXNUM_BITS): New macro, useful for SXHASH_REDUCE etc.
40087514
PE
8312 (MOST_NEGATIVE_FIXNUM, MOST_POSITIVE_FIXNUM, INTMASK):
8313 Rewrite to use FIXNUM_BITS, as this simplifies things.
0de4bb68
PE
8314 (next_almost_prime, larger_vector, sxhash, hash_lookup, hash_put):
8315 Adjust signatures to match updated version of code.
8316 (consing_since_gc): Now EMACS_INT, since a single hash table can
8317 use more than INT_MAX bytes.
8318
698d32e2
DN
83192011-06-01 Dan Nicolaescu <dann@ics.uci.edu>
8320
8321 Make it possible to build with GCC-4.6+ -O2 -flto.
8322
8323 * emacs.c (__malloc_initialize_hook): Mark as EXTERNALLY_VISIBLE.
8324
fd6fa53f
SM
83252011-06-01 Stefan Monnier <monnier@iro.umontreal.ca>
8326
8327 * minibuf.c (get_minibuffer, read_minibuf_unwind):
8328 Call minibuffer-inactive-mode.
8329
864db017
JB
83302011-05-31 Juanma Barranquero <lekktu@gmail.com>
8331
8332 * makefile.w32-in ($(BLD)/data.$(O), $(BLD)/editfns.$(O)):
8333 Update dependencies.
8334
2ad0baf4
DN
83352011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
8336
8337 * data.c (init_data): Remove code for UTS, this system is not
8338 supported anymore.
8339
4fcc2638
DN
83402011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
8341
8342 Don't force ./temacs to start in terminal mode.
8343
8344 * frame.c (make_initial_frame): Initialize faces in all cases, not
8345 only when CANNOT_DUMP is defined.
8346 * dispnew.c (init_display): Remove CANNOT_DUMP condition.
8347
c56e0fd5
DN
83482011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
8349
8350 * dispnew.c (add_window_display_history): Use const for the string
8351 pointer. Remove declaration, not needed.
8352
333d54da 83532011-05-31 Paul Eggert <eggert@cs.ucla.edu>
9cf9f756 8354
55d4c1b2 8355 Use 'inline', not 'INLINE'.
333d54da 8356 <http://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00914.html>
55d4c1b2
PE
8357 * alloc.c, fontset.c (INLINE): Remove.
8358 * alloc.c, bidi.c, charset.c, coding.c, dispnew.c, fns.c, image.c:
8359 * intervals.c, keyboard.c, process.c, syntax.c, textprop.c, w32term.c:
8360 * xdisp.c, xfaces.c, xterm.c: Replace all uses of INLINE with inline.
8361 * gmalloc.c (register_heapinfo): Use inline unconditionally.
8362 * lisp.h (LISP_MAKE_RVALUE): Use inline, not __inline__.
8363
738db178
DN
83642011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
8365
8366 Make it possible to run ./temacs.
8367
8368 * callproc.c (set_initial_environment): Remove CANNOT_DUMP code,
8369 syms_of_callproc does the same thing. Remove test for
8370 "initialized", do it in the caller.
8371 * emacs.c (main): Avoid calling set_initial_environment when dumping.
8372
620c53a6
SM
83732011-05-31 Stefan Monnier <monnier@iro.umontreal.ca>
8374
8375 * minibuf.c (Finternal_complete_buffer): Return `category' metadata.
8376 (read_minibuf): Use get_minibuffer.
8377 (syms_of_minibuf): Use DEFSYM.
8378 (Qmetadata): New var.
8379 * data.c (Qbuffer): Don't make it static.
8380 (syms_of_data): Use DEFSYM.
8381
e003a292
PE
83822011-05-31 Paul Eggert <eggert@cs.ucla.edu>
8383
8384 * ccl.c (CCL_CODE_RANGE): Allow negative numbers. (Bug#8751)
8385 (CCL_CODE_MIN): New macro.
8386
ed008a6d
PE
83872011-05-30 Paul Eggert <eggert@cs.ucla.edu>
8388
3687c2ef
PE
8389 * alloc.c (lisp_align_malloc): Omit unnecessary val==NULL tests.
8390
ed008a6d
PE
8391 * eval.c (Qdebug): Now static.
8392 * lisp.h (Qdebug): Remove decl. This reverts a part of the
8393 2011-04-26T11:26:05Z!dan.colascione@gmail.com that inadvertently undid part of
8394 2011-04-14T06:48:41Z!eggert@cs.ucla.edu.
8395
d66c4c7c
CY
83962011-05-29 Chong Yidong <cyd@stupidchicken.com>
8397
8398 * image.c: Various fixes to ImageMagick code comments.
8399 (Fimagemagick_types): Doc fix.
8400
5fbc2025
PE
84012011-05-29 Paul Eggert <eggert@cs.ucla.edu>
8402
0196f88a
PE
8403 Minor fixes prompted by GCC 4.6.0 warnings.
8404
8405 * xselect.c (converted_selections, conversion_fail_tag): Now static.
8406
5fbc2025
PE
8407 * emacs.c [HAVE_X_WINDOWS]: Include "xterm.h".
8408 (x_clipboard_manager_save_all): Move extern decl to ...
8409 * xterm.h: ... here, so that it can be checked for consistency.
8410
1dd3c2d9
CY
84112011-05-29 Chong Yidong <cyd@stupidchicken.com>
8412
8413 * xselect.c (x_clipboard_manager_save_frame)
8414 (x_clipboard_manager_save_all): New functions.
8415 (Fx_clipboard_manager_save): Lisp function deleted.
8416
8417 * emacs.c (Fkill_emacs): Call x_clipboard_manager_save_all.
8418 * frame.c (delete_frame): Call x_clipboard_manager_save_frame.
8419
8420 * xterm.h: Update prototype.
8421
5ba6571d
WX
84222011-05-28 William Xu <william.xwl@gmail.com>
8423
8424 * nsterm.m (ns_term_shutdown): Synchronize user defaults before
8425 exiting (Bug#8239).
8426
3eaff834
JM
84272011-05-28 Jim Meyering <meyering@redhat.com>
8428
e1900994 8429 Avoid a sign-extension bug in crypto_hash_function.
3eaff834
JM
8430 * fns.c (to_uchar): Define.
8431 (crypto_hash_function): Use it to convert some newly-signed
8432 variables to unsigned, to avoid sign-extension bugs. For example,
8433 without this change, (md5 "truc") would evaluate to
8434 45723a2aff78ff4fff7fff1114760e62 rather than the expected
8435 45723a2af3788c4ff17f8d1114760e62. Reported by Antoine Levitt in
e1900994 8436 https://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00883.html.
3eaff834 8437
0f6990a7
PE
84382011-05-27 Paul Eggert <eggert@cs.ucla.edu>
8439
8440 Integer overflow fixes.
c8a9ca5a 8441
08686060
PE
8442 * dbusbind.c: Serial number integer overflow fixes.
8443 (CHECK_DBUS_SERIAL_GET_SERIAL): New macro.
08686060
PE
8444 (Fdbus_call_method_asynchronously, xd_read_message_1): Use a float
8445 to hold a serial number that is too large for a fixnum.
8446 (Fdbus_method_return_internal, Fdbus_method_error_internal):
8447 Check for serial numbers out of range. Decode any serial number
59568bf0 8448 that was so large that it became a float. (Bug#8722)
08686060 8449
2d1fc3c7
PE
8450 * dbusbind.c: Use XFASTINT rather than XUINT, and check for nonneg.
8451 (Fdbus_call_method, Fdbus_call_method_asynchronously):
8452 Use XFASTINT rather than XUINT when numbers are nonnegative.
8453 (xd_append_arg, Fdbus_method_return_internal):
8454 (Fdbus_method_error_internal): Likewise. Also, for unsigned
8455 arguments, check that Lisp number is nonnegative, rather than
59568bf0 8456 silently wrapping negative numbers around. (Bug#8722)
30217ff0 8457 (xd_read_message_1): Don't assume dbus_uint32_t can fit in int.
59568bf0 8458 (Bug#8722)
2d1fc3c7 8459
c8a9ca5a
PE
8460 * data.c (arith_driver, Flsh): Avoid unnecessary casts to EMACS_UINT.
8461
519e1d69
PE
8462 * ccl.c (ccl_driver): Redo slightly to avoid the need for 'unsigned'.
8463
6df6ae42 8464 ccl: Add integer overflow checks.
30569699
PE
8465 * ccl.c (CCL_CODE_MAX, GET_CCL_RANGE, GET_CCL_CODE, GET_CCL_INT):
8466 (IN_INT_RANGE): New macros.
8467 (ccl_driver): Use them to check for integer overflow when
8468 decoding a CCL program. Many of the new checks are whether XINT (x)
8469 fits in int; it doesn't always, on 64-bit hosts. The new version
8470 doesn't catch all possible integer overflows, but it's an
847044ea 8471 improvement. (Bug#8719)
30569699 8472
c11285dc
PE
8473 * alloc.c (make_event_array): Use XINT, not XUINT.
8474 There's no need for unsigned here.
8475
fdccd48e
PE
8476 * mem-limits.h (EXCEEDS_LISP_PTR) [!USE_LSB_TAG]: EMACS_UINT -> uintptr_t
8477 This follows up to the 2011-05-06 change that substituted uintptr_t
8478 for EMACS_INT. This case wasn't caught back then.
8479
37910ab2
PE
8480 Rework Fformat to avoid integer overflow issues.
8481 * editfns.c: Include <float.h> unconditionally, as it's everywhere
8482 now (part of C89). Include <verify.h>.
8483 (MAX_10_EXP, CONVERTED_BYTE_SIZE): Remove; no longer needed.
8484 (pWIDE, pWIDElen, signed_wide, unsigned_wide): New defns.
8485 (Fformat): Avoid the prepass trying to compute sizes; it was only
8486 approximate and thus did not catch overflow reliably. Instead, walk
8487 through the format just once, formatting and computing sizes as we go,
8488 checking for integer overflow at every step, and allocating a larger
8489 buffer as needed. Keep track separately whether the format is
8490 multibyte. Keep only the most-recently calculated precision, rather
8491 than them all. Record whether each argument has been converted to
8492 string. Use EMACS_INT, not int, for byte and char and arg counts.
8493 Support field widths and precisions larger than INT_MAX. Avoid
8494 sprintf's undefined behavior with conversion specifications such as %#d
8495 and %.0c. Fix bug with strchr succeeding on '\0' when looking for
8496 flags. Fix bug with (format "%c" 256.0). Avoid integer overflow when
8497 formatting out-of-range floating point numbers with int
9173deec 8498 formats. (Bug#8668)
37910ab2 8499
2e6578fb
PE
8500 * lisp.h (FIXNUM_OVERFLOW_P): Work even if arg is a NaN.
8501
0ae6bdee
PE
8502 * data.c: Avoid integer truncation in expressions involving floats.
8503 * data.c: Include <intprops.h>.
8504 (arith_driver): When there's an integer overflow in an expression
8505 involving floating point, convert the integers to floating point
8506 so that the resulting value does not suffer from catastrophic
8507 integer truncation. For example, on a 64-bit host (* 4
8508 most-negative-fixnum 0.5) should yield about -4.6e+18, not zero.
8509 Do not rely on undefined behavior after integer overflow.
8510
de883a70
PE
8511 merge count_size_as_multibyte, parse_str_to_multibyte
8512 * character.c, character.h (count_size_as_multibyte):
fd6fa53f 8513 Rename from parse_str_to_multibyte; all uses changed.
de883a70
PE
8514 Check for integer overflow.
8515 * insdel.c, lisp.h (count_size_as_multibyte): Remove,
8516 since it's now a duplicate of the other. This is more of
8517 a character than a buffer op, so better that it's in character.c.
8518 * fns.c, print.c: Adjust to above changes.
8519
2ff916cb
PE
85202011-05-27 Stefan Monnier <monnier@iro.umontreal.ca>
8521
8522 * xselect.c (x_convert_selection): Yet another int/Lisp_Object mixup.
8523
f1b54466
PE
85242011-05-27 Paul Eggert <eggert@cs.ucla.edu>
8525
fb1ac845
PE
8526 * xselect.c: Fix minor problems prompted by GCC 4.6.0 warnings.
8527 (x_handle_selection_request, frame_for_x_selection): Remove unused vars.
8528 (x_clipboard_manager_save): Now static.
8529 (Fx_clipboard_manager_save): Rename local to avoid shadowing.
8530
f1b54466
PE
8531 * fns.c: Fix minor problems prompted by GCC 4.6.0 warnings.
8532 (crypto_hash_function): Now static.
8533 Fix pointer signedness problems. Avoid unnecessary initializations.
8534
a9f737ee
CY
85352011-05-27 Chong Yidong <cyd@stupidchicken.com>
8536
8537 * termhooks.h (Vselection_alist): Make it terminal-local.
8538
8539 * terminal.c (create_terminal): Initialize it.
8540
8541 * xselect.c: Support for clipboard managers.
8542 (Vselection_alist): Move to termhooks.h as terminal-local var.
8543 (LOCAL_SELECTION): New macro.
8544 (x_atom_to_symbol): Handle x_display_info_for_display fail case.
8545 (symbol_to_x_atom): Remove gratuitous arg.
8546 (x_handle_selection_request, lisp_data_to_selection_data)
8547 (x_get_foreign_selection, Fx_register_dnd_atom): Callers changed.
620c53a6
SM
8548 (x_own_selection, x_get_local_selection, x_convert_selection):
8549 New arg, specifying work frame. Use terminal-local Vselection_alist.
a9f737ee
CY
8550 (some_frame_on_display): Delete unused function.
8551 (Fx_own_selection_internal, Fx_get_selection_internal)
8552 (Fx_disown_selection_internal, Fx_selection_owner_p)
8553 (Fx_selection_exists_p): New optional frame arg.
8554 (frame_for_x_selection, Fx_clipboard_manager_save): New functions.
8555 (x_handle_selection_clear): Don't treat other terminals with the
8556 same keyboard specially. Use the terminal-local Vselection_alist.
8557 (x_clear_frame_selections): Use Frun_hook_with_args.
8558
8559 * xterm.c (x_term_init): Intern ATOM and CLIPBOARD_MANAGER atoms.
8560
8561 * xterm.h: Add support for those atoms.
8562
e067f0c1
CY
85632011-05-26 Chong Yidong <cyd@stupidchicken.com>
8564
8565 * xselect.c: ICCCM-compliant handling of MULTIPLE targets.
8566 (converted_selections, conversion_fail_tag): New global variables.
8567 (x_selection_request_lisp_error): Free the above.
8568 (x_get_local_selection): Remove unnecessary code.
8569 (x_reply_selection_request): Args changed; handle arbitrary array
620c53a6
SM
8570 of converted selections stored in converted_selections.
8571 Separate the XChangeProperty and SelectionNotify steps.
e067f0c1
CY
8572 (x_handle_selection_request): Rewrite to handle MULTIPLE target.
8573 (x_convert_selection): New function.
8574 (x_handle_selection_event): Simplify.
8575 (x_get_foreign_selection): Don't ignore incoming requests while
8576 waiting for an answer; this will fail when we implement
8577 SAVE_TARGETS, and seems unnecessary anyway.
8578 (selection_data_to_lisp_data): Recognize ATOM_PAIR type.
8579 (Vx_sent_selection_functions): Doc fix.
8580
0f4aebc0
LL
85812011-05-26 Leo Liu <sdl.web@gmail.com>
8582
8583 * editfns.c (Ftranspose_regions): Allow empty regions. (Bug#8699)
8584
e61124cd
YM
85852011-05-25 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
8586
8587 * dispextern.h (struct glyph_row): New member fringe_bitmap_periodic_p.
8588
8589 * dispnew.c (shift_glyph_matrix, scrolling_window): Mark scrolled row
8590 for fringe update if it has periodic bitmap.
ac389d0c 8591 (row_equal_p): Also compare left_fringe_offset, right_fringe_offset,
e61124cd
YM
8592 and fringe_bitmap_periodic_p.
8593
8594 * fringe.c (get_fringe_bitmap_data): New function.
8595 (draw_fringe_bitmap_1, update_window_fringes): Use it.
8596 (update_window_fringes): Record periodicity of fringe bitmap in glyph
8597 row. Mark glyph row for fringe update if periodicity changed.
8598
8599 * xdisp.c (try_window_reusing_current_matrix): Don't mark scrolled row
8600 for fringe update unless it has periodic bitmap.
8601
f16d9837
KH
86022011-05-25 Kenichi Handa <handa@m17n.org>
8603
8604 * xdisp.c (get_next_display_element): Set correct it->face_id for
8605 a static composition.
8606
e1b90ef6
LL
86072011-05-24 Leo Liu <sdl.web@gmail.com>
8608
8609 * deps.mk (fns.o):
8610 * makefile.w32-in ($(BLD)/fns.$(O)): Include sha1.h.
8611
8612 * fns.c (crypto_hash_function, Fsha1): New function.
8613 (Fmd5): Use crypto_hash_function.
8614 (syms_of_fns): Add Ssha1.
8615
7400048f
PE
86162011-05-22 Paul Eggert <eggert@cs.ucla.edu>
8617
8618 * gnutls.c: Remove unused macros.
8619 (fn_gnutls_transport_set_lowat, fn_gnutls_transport_set_pull_function):
8620 (fn_gnutls_transport_set_push_function) [!WINDOWSNT]:
8621 Remove macros that are defined and never used.
8622 Caught by gcc -Wunused-macros (GCC 4.6.0, Fedora 14).
8623
abb71cf4
CY
86242011-05-22 Chong Yidong <cyd@stupidchicken.com>
8625
8626 * xselect.c (syms_of_xselect): Remove unused symbol SAVE_TARGETS.
8627 (Fx_get_selection_internal): Minor cleanup.
8628 (Fx_own_selection_internal): Rename arguments for consistency with
8629 select.el.
8630
6307db39
PE
86312011-05-22 Paul Eggert <eggert@cs.ucla.edu>
8632
8633 * xselect.c (QSAVE_TARGETS): New static var, to fix build failure.
8634
f3d4e0a4
CY
86352011-05-22 Chong Yidong <cyd@stupidchicken.com>
8636
8637 * xselect.c (syms_of_xselect): Include character.h; use DEFSYM.
8638
4d8ade89
YM
86392011-05-21 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
8640
8641 * dispnew.c (scrolling_window): Don't exclude the case that the
8642 last enabled row in the desired matrix touches the bottom boundary.
8643
32078c8d
GM
86442011-05-21 Glenn Morris <rgm@gnu.org>
8645
8646 * Makefile.in ($(etc)/DOC): Make second command line even shorter.
33cf345f
GM
8647 (SOME_MACHINE_OBJECTS): Replace FONT_OBJ by its maximal expansion,
8648 and add some more files.
32078c8d 8649
7285dc67
EZ
86502011-05-20 Eli Zaretskii <eliz@gnu.org>
8651
8652 * callproc.c (Fcall_process) [MSDOS]: Fix arguments to
8653 report_file_error introduced by the change from 2011-05-07.
8654
89d1bd22
PE
86552011-05-20 Paul Eggert <eggert@cs.ucla.edu>
8656
8657 * systime.h (Time): Define only if emacs is defined.
8658 This is to allow ../lib-src/profile.c to be compiled on FreeBSD,
8659 where the include path doesn't have X11/X.h by default. See
8660 <http://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00561.html>.
8661
cd394be1 86622011-05-20 Kenichi Handa <handa@m17n.org>
31bfc35c
KH
8663
8664 * composite.c (find_automatic_composition): Fix previous change.
8665
b9704ad9
GM
86662011-05-20 Glenn Morris <rgm@gnu.org>
8667
8668 * lisp.mk: New file, split from Makefile.in.
8669 * Makefile.in (lisp): Move to separate file, inserted by @lisp_frag@.
8670 (shortlisp): Remove.
8671 ($(etc)/DOC): Edit lisp.mk rather than using $shortlisp.
8672
4a720484
GM
86732011-05-19 Glenn Morris <rgm@gnu.org>
8674
8675 * Makefile.in (MSDOS_SUPPORT_REAL, MSDOS_SUPPORT, NS_SUPPORT)
8676 (REAL_MOUSE_SUPPORT, GPM_MOUSE_SUPPORT, MOUSE_SUPPORT, TOOLTIP_SUPPORT)
8677 (BASE_WINDOW_SUPPORT, X_WINDOW_SUPPORT, WINDOW_SUPPORT): Remove.
8678 (lisp): Set the order to that of loadup.el.
8679 (shortlisp): Make it a copy of $lisp.
8680 (SOME_MACHINE_LISP): Remove.
8681 ($(etc)/DOC): Depend just on $lisp, not $SOME_MACHINE_LISP too.
8682 Use just $shortlisp, not $SOME_MACHINE_LISP too.
8683
a28d4396
KH
86842011-05-18 Kenichi Handa <handa@m17n.org>
8685
8686 * composite.c (CHAR_COMPOSABLE_P): Add more check for efficiency.
8687 (BACKWARD_CHAR): Wrap the arg STOP by parenthesis.
8688 (find_automatic_composition): Mostly rewrite for efficiency.
8689
a2b1fa8e
JB
86902011-05-18 Juanma Barranquero <lekktu@gmail.com>
8691
8692 * makefile.w32-in: Update dependencies.
8693
8e1f5610
CS
86942011-05-18 Christoph Scholtes <cschol2112@googlemail.com>
8695
8696 * menu.c: Include limits.h (fixes the MS-Windows build broken by
7d7d0045 8697 2011-06-18T18:49:19Z!cyd@stupidchicken.com).
8e1f5610 8698
7025ee00 86992011-05-18 Paul Eggert <eggert@cs.ucla.edu>
cb93f9be 8700
cdfa6eab
PE
8701 Fix some integer overflow issues, such as string length overflow.
8702
06d6db33
PE
8703 * insdel.c (count_size_as_multibyte): Check for string overflow.
8704
2b4560a8
PE
8705 * character.c (lisp_string_width): Check for string overflow.
8706 Use EMACS_INT, not int, for string indexes and lengths; in
8707 particular, 2nd arg is now EMACS_INT, not int. Do not crash if
8708 the resulting string length overflows an EMACS_INT; instead,
8709 report a string overflow if no precision given. When checking for
8710 precision exhaustion, use a check that cannot possibly have
8711 integer overflow. (Bug#8675)
8712 * character.h (lisp_string_width): Adjust to new signature.
8713
cb93f9be
PE
8714 * alloc.c (string_overflow): New function.
8715 (Fmake_string): Use it. This doesn't change behavior, but saves
8716 a few bytes and will simplify future changes.
8717 * character.c (string_escape_byte8): Likewise.
8718 * lisp.h (string_overflow): New decl.
8719
1a1f3366
PE
8720 Fixups, following up to the user-interface timestamp change.
8721 * nsterm.m (last_mouse_movement_time, ns_mouse_position): Use Time
8722 for UI timestamps, instead of unsigned long.
9fbd6841
PE
8723 * msdos.c (mouse_get_pos): Likewise.
8724 * w32inevt.c (movement_time, w32_console_mouse_position): Likewise.
1a1f3366
PE
8725 * w32gui.h (Time): Define by including "systime.h" rather than by
8726 declaring it ourselves. (Bug#8664)
8727
d4e3e4d3
PE
8728 * dispextern.h (struct image): Don't assume time_t <= unsigned long.
8729 * image.c (clear_image_cache): Likewise.
8730
f6a24d19
PE
8731 * term.c (term_mouse_position): Don't assume time_t wraparound.
8732
08dc5ae6
PE
8733 Be more systematic about user-interface timestamps.
8734 Before, the code sometimes used 'Time', sometimes 'unsigned long',
620c53a6
SM
8735 and sometimes 'EMACS_UINT', to represent these timestamps.
8736 This change causes it to use 'Time' uniformly, as that's what X uses.
08dc5ae6
PE
8737 This makes the code easier to follow, and makes it easier to catch
8738 integer overflow bugs such as Bug#8664.
8739 * frame.c (Fmouse_position, Fmouse_pixel_position):
8740 Use Time, not unsigned long, for user-interface timestamps.
8741 * keyboard.c (last_event_timestamp, kbd_buffer_get_event): Likewise.
8742 (button_down_time, make_lispy_position, make_lispy_movement): Likewise.
8743 * keyboard.h (last_event_timestamp): Likewise.
8744 * menu.c (Fx_popup_menu) [!HAVE_X_WINDOWS]: Likewise.
8745 * menu.h (xmenu_show): Likewise.
8746 * term.c (term_mouse_position): Likewise.
8747 * termhooks.h (struct input_event.timestamp): Likewise.
8748 (struct terminal.mouse_position_hook): Likewise.
8749 * xmenu.c (create_and_show_popup_menu, xmenu_show): Likewise.
8750 * xterm.c (XTmouse_position, x_scroll_bar_report_motion): Likewise.
8751 * systime.h (Time): New decl. Pull it in from <X11/X.h> if
8752 HAVE_X_WINDOWS, otherwise define it as unsigned long, which is
8753 what it was before.
8754 * menu.h, termhooks.h: Include "systime.h", for Time.
8755
8e55734a
PE
8756 * keyboard.c (make_lispy_event): Fix problem in integer overflow.
8757 Don't assume that the difference between two unsigned long values
8758 can fit into an integer. At this point, we know button_down_time
8759 <= event->timestamp, so the difference must be nonnegative, so
8760 there's no need to cast the result if double-click-time is
8761 nonnegative, as it should be; check that it's nonnegative, just in
8762 case. This bug is triggered when events are more than 2**31 ms
86db42d2 8763 apart (about 25 days). (Bug#8664)
8e55734a 8764
841f1b75 8765 * xselect.c (last_event_timestamp): Remove duplicate decl.
6434756c 8766 (x_own_selection): Remove needless cast to unsigned long.
841f1b75 8767
3e26f69c
PE
8768 * xmenu.c (set_frame_menubar): Use int, not EMACS_UINT, for indexes
8769 that always fit in int. Use a sentinel instead of a counter, to
8770 avoid a temp and to allay GCC's concerns about possible int overflow.
d230cb74
PE
8771 * frame.h (struct frame): Use int for menu_bar_items_used
8772 instead of EMACS_INT, since it always fits in int.
3e26f69c 8773
5cc152c0
PE
8774 * menu.c (grow_menu_items): Check for int overflow.
8775
d89eb65e
PE
8776 * xmenu.c (set_frame_menubar): Don't mishandle vectors with no nils.
8777
5235bd3e
PE
8778 * xterm.c: Use EMACS_INT for Emacs modifiers, and int for X modifiers.
8779 Before, the code was not consistent. These values cannot exceed
8780 2**31 - 1 so there's no need to make them unsigned.
8781 (x_x_to_emacs_modifiers): Accept int and return EMACS_INT.
8782 (x_emacs_to_x_modifiers): Accept EMACS_INT and return int.
8783 (x_x_to_emacs_modifiers, x_emacs_to_x_modifiers): Reject non-integers
8784 as modifiers.
8785 * xterm.h (x_x_to_emacs_modifiers): Adjust to signature change.
8786
bc827e23
PE
8787 * lisp.h (XINT) [USE_LISP_UNION_TYPE]: Cast to EMACS_INT.
8788 (XUINT) [USE_LISP_UNION_TYPE]: Cast to EMACS_UINT.
8789 Otherwise, GCC 4.6.0 warns about printf (pI, XINT (...)),
8790 presumably because the widths might not match.
8791
78eb494e
PE
8792 * window.c (size_window): Avoid needless test at loop start.
8793
04f2d78b
CB
87942011-05-18 Courtney Bane <emacs-bugs-7626@cbane.org> (tiny change)
8795
8796 * term.c (Fresume_tty): Restore hooks before reinitializing (bug#8687).
8797
d2fc7e3d 87982011-05-12 Drew Adams <drew.adams@oracle.com>
e531bdff
DA
8799
8800 * textprop.c (Fprevious_single_char_property_change): Doc fix (bug#8655).
8801
d2fc7e3d 88022011-05-12 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
7db47798
YM
8803
8804 * w32term.c (w32_draw_fringe_bitmap): Rename local vars `left' and
8805 `width' to `bar_area_x' and `bar_area_width', respectively.
8806 (x_scroll_run): Take account of fringe background extension.
8807
04f2d78b
CB
8808 * xterm.c (x_draw_fringe_bitmap) [USE_TOOLKIT_SCROLL_BARS]:
8809 Rename local vars `left' and `width' to `bar_area_x' and
7db47798
YM
8810 `bar_area_width', respectively.
8811 (x_scroll_run) [USE_TOOLKIT_SCROLL_BARS]: Take account of fringe
8812 background extension.
8813
79b70037
GM
88142011-05-10 Jim Meyering <meyering@redhat.com>
8815
8816 * xdisp.c (x_intersect_rectangles): Fix typo "the the -> the".
8817
2f142cc5
JB
88182011-05-10 Juanma Barranquero <lekktu@gmail.com>
8819
8820 * image.c (Finit_image_library): Return t for built-in image types,
8821 like pbm and xbm. (Bug#8640)
8822
57679c86
AS
88232011-05-09 Andreas Schwab <schwab@linux-m68k.org>
8824
8825 * w32menu.c (set_frame_menubar): Fix submenu allocation.
8826
888c9e86
EZ
88272011-05-07 Eli Zaretskii <eliz@gnu.org>
8828
b0512a1d
EZ
8829 * w32console.c (Fset_screen_color): Doc fix.
8830 (Fget_screen_color): New function.
8831 (syms_of_ntterm): Defsubr it.
8832
7285dc67
EZ
8833 * callproc.c (call_process_cleanup) [MSDOS]: Don't close and
8834 unlink the temporary file if Fcall_process didn't create it in the
8835 first place.
8836 (Fcall_process) [MSDOS]: Don't create tempfile if stdout of the
8837 child process will be redirected to a file specified with `:file'.
888c9e86
EZ
8838 Don't try to re-open tempfile in that case, and set fd[0] to -1 as
8839 cue to call_process_cleanup not to close that handle.
8840
4d3fcc8e
BK
88412011-05-07 Ben Key <bkey76@gmail.com>
8842
8843 * makefile.w32-in: The bootstrap-temacs rule now makes use of
8844 one of two shell specific rules, either bootstrap-temacs-CMD or
8845 bootstrap-temacs-SH. The bootstrap-temacs-SH rule is identical
8846 to the previous implementation of the bootstrap-temacs rule.
8847 The bootstrap-temacs-CMD rule is similar to the previous
8848 implementation of the bootstrap-temacs rule except that it
8849 makes use of the ESC_CFLAGS variable instead of the CFLAGS
8850 variable.
8851
8852 These changes, along with some changes to nt/configure.bat,
8853 nt/gmake.defs, and nt/nmake.defs, are required to extend my
8854 earlier fix to add support for --cflags and --ldflags options
8855 that include quotes so that it works whether make uses cmd or
8856 sh as the shell.
8857
b4289b64
MA
88582011-05-06 Michael Albinus <michael.albinus@gmx.de>
8859
8860 * dbusbind.c (QCdbus_type_unix_fd): Declare static.
8861 (xd_remove_watch): Don't check QCdbus_type_unix_fd for SYMBOLP, it
8862 is a constant.
8863 (Fdbus_init_bus, xd_read_queued_messages): Bus can be a symbol or
8864 a string. Handle both cases.
8865 (Fdbus_call_method_asynchronously, Fdbus_register_signal)
8866 (Fdbus_register_method): Use Qinvalid_function.
8867
af4c0e28
JB
88682011-05-06 Juanma Barranquero <lekktu@gmail.com>
8869
8870 * makefile.w32-in: Update dependencies.
8871 (LISP_H): Add inttypes.h and stdin.h.
8872 (PROCESS_H): Add unistd.h.
8873
c51453d9
EZ
88742011-05-06 Eli Zaretskii <eliz@gnu.org>
8875
8876 * lread.c: Include limits.h (fixes the MS-Windows build broken by
8877 2011-05-06T07:13:19Z!eggert@cs.ucla.edu).
8878
8ff0ac3c 88792011-05-06 Paul Eggert <eggert@cs.ucla.edu>
c032b5f8 8880
4c4b566b
PE
8881 * image.c (Finit_image_library) [!HAVE_NTGUI]: Omit unused local.
8882
aab2b9b5
PE
8883 * term.c (vfatal): Remove stray call to va_end.
8884 It's not needed and the C Standard doesn't allow it here anyway.
8885
c378da0b
PE
8886 Use C99's va_copy to avoid undefined behavior on x86-64 GNU/Linux.
8887 * eval.c (verror): doprnt a copy of ap, not the original. (Bug#8545)
8888
288b08c7
PE
8889 * eval.c (verror): OK to create a string of up to MOST_POSITIVE_FIXNUM
8890 bytes.
8891
e3601888
PE
8892 * term.c: Don't include <stdarg.h>, as <lisp.h> does that.
8893
db6c0e74
PE
8894 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork clobbering.
8895
dd5963ea
PE
8896 * process.c (Fformat_network_address): Fix typo: args2 -> *args2.
8897
88c9450f
PE
8898 * xmenu.c (set_frame_menubar): Fix typo: int * -> int (3 times).
8899
2f9442b8
PE
8900 * coding.c (detect_coding_charset): Fix typo: * 2 -> *4 (Bug#8601).
8901
c032b5f8
PE
8902 * charset.h (struct charset.code_space): Now has 15 elements, not 16.
8903 * charset.c (Fdefine_charset_internal): Don't initialize
8904 charset.code_space[15]. The value was garbage, on hosts with
2d38271b 8905 32-bit int (Bug#8600).
a108c10b
PE
8906
8907 * lread.c (read_integer): Be more consistent with string-to-number.
8908 Use string_to_number to do the actual conversion; this avoids
8909 rounding errors and fixes some other screwups. Without this fix,
8910 for example, #x1fffffffffffffff was misread as -2305843009213693952.
8911 (digit_to_number): Move earlier, for benefit of read_integer.
8912 Return -1 if the digit is out of range for the base, -2 if it is
48e400f0 8913 not a digit in any supported base. (Bug#8602)
a108c10b 8914
ad5f9eea
PE
8915 * doprnt.c (doprnt): Support arbitrary pI values, such as "I64".
8916
aec1708a
PE
8917 * dispnew.c (scrolling_window): Return 1 if we scrolled,
8918 to match comment at start of function. This also removes a
8919 GCC warning about overflow in a 32+64-bit port.
8920
47be4ab5
PE
8921 * lisp.h (EMACS_INT, EMACS_UINT, BITS_PER_EMACS_INT, pI): Simplify.
8922
371cac43
PE
8923 * dbusbind.c: Do not use XPNTR on a value that may be an integer.
8924 Reported by Stefan Monnier in
8925 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00919.html>.
04f2d78b
CB
8926 (xd_remove_watch, Fdbus_init_bus, xd_read_queued_messages):
8927 Use SYMBOLP-guarded XSYMBOL, not XPNTR.
371cac43 8928
d01a7826
PE
8929 * lisp.h (EMACS_INTPTR): Remove. All uses changed to intptr_t.
8930 (EMACS_UINTPTR): Likewise, with uintptr_t.
8931
7fd47d5c
PE
8932 * lisp.h: Prefer 64-bit EMACS_INT if available.
8933 (EMACS_INT, EMACS_UINT, BITS_PER_EMACS_INT, pI): Define to 64-bit
8934 on 32-bit hosts that have 64-bit int, so that they can access
8935 large files.
122b0c86
PE
8936 However, temporarily disable this change unless the temporary
8937 symbol WIDE_EMACS_INT is defined.
7fd47d5c 8938
8727937b
PE
8939 * lread.c, process.c: Do not include <inttypes.h>; lisp.h does it now.
8940
8ac068ac
PE
8941 Prefer intptr_t/uintptr_t for integers the same widths as pointers.
8942 This removes an assumption that EMACS_INT and long are the same
8943 width as pointers. The assumption is true for Emacs porting targets
8944 now, but we want to make other targets possible.
8945 * lisp.h: Include <inttypes.h>, for INTPTR_MAX, UINTPTR_MAX.
8946 (EMACS_INTPTR, EMACS_UINTPTR): New macros.
8947 In the rest of the code, change types of integers that hold casted
8948 pointers to EMACS_INTPTR and EMACS_UINTPTR, systematically
8949 replacing EMACS_INT, long, EMACS_UINT, and unsigned long.
8950 (XTYPE): Don't cast arg to EMACS_UINT; normally is not needed.
8951 (XSET): Cast type of XTYPE arg to EMACS_INTPTR; it is needed here.
8952 No need to cast type when ORing.
8953 (XPNTR): Return a value of type EMACS_INTPTR or EMACS_UINTPTR.
8954 * alloc.c (lisp_align_malloc): Remove a no-longer-needed cast.
8955 * doc.c (store_function_docstring): Use EMACS_INTPTR, so as not to
8956 assume EMACS_INT is the same width as char *.
8957 * gtkutil.c (xg_gtk_scroll_destroy, xg_tool_bar_button_cb):
8958 (xg_tool_bar_callback, xg_tool_bar_help_callback, xg_make_tool_item):
8959 Remove no-longer-needed casts.
8960 (xg_create_scroll_bar, xg_tool_bar_button_cb, xg_tool_bar_callback):
8961 (xg_tool_bar_help_callback, xg_make_tool_item):
8962 Use EMACS_INTPTR to hold an integer
8963 that will be cast to void *; this can avoid a GCC warning
8964 if EMACS_INT is not the same width as void *.
8965 * menu.c (find_and_call_menu_selection): Remove no-longer-needed cast.
8966 * xdisp.c (display_echo_area_1, resize_mini_window_1):
8967 (current_message_1, set_message_1):
8968 Use a local to convert to proper width without a cast.
8969 * xmenu.c (dialog_selection_callback): Likewise.
8970
ede49d71
PE
8971 * sysdep.c (get_random): Don't assume EMACS_INT is no wider than long.
8972 Also, don't assume VALBITS / RAND_BITS is less than 5,
8973 and don't rely on undefined behavior when shifting a 1 left into
8974 the sign bit.
8975 * lisp.h (get_random): Change signature to match.
8976
2f30ecd0
PE
8977 * lread.c (hash_string): Use size_t, not int, for hash computation.
8978 Normally we prefer signed values; but hashing is special, because
8979 it's better to use unsigned division on hash table sizes so that
8980 the remainder is nonnegative. Also, size_t is the natural width
8981 for hashing into memory. The previous code used 'int', which doesn't
8982 retain enough info to hash well into very large tables.
8983 (oblookup, oblookup_last_bucket_number, Funintern): Likewise.
8984
2a866e7b
PE
8985 * dbusbind.c: Don't possibly lose pointer info when converting.
8986 (xd_remove_watch, Fdbus_init_bus, xd_read_queued_messages):
8987 Use XPNTR rather than XHASH, so that the high-order bits of
8988 the pointer aren't lost when converting through void *.
8989
51639eac
PE
8990 * eval.c (Fautoload): Don't double-shift a pointer.
8991
92394119
PE
8992 * fns.c (Frandom): Let EMACS_UINT be wider than unsigned long.
8993
dbdb9a7c
JB
89942011-05-06 Juanma Barranquero <lekktu@gmail.com>
8995
8996 * gnutls.c (DEF_GNUTLS_FN):
8997 * image.c (DEF_IMGLIB_FN): Make function pointers static.
8998
db7a0b4f
AS
89992011-05-05 Andreas Schwab <schwab@linux-m68k.org>
9000
9001 * lread.c (lisp_file_lexically_bound_p): Stop scanning at end
9002 marker. (Bug#8610)
9003
cd394be1 90042011-05-05 Eli Zaretskii <eliz@gnu.org>
fab624aa
EZ
9005
9006 * w32heap.c (allocate_heap) [USE_LISP_UNION_TYPE || USE_LSB_TAG]:
9007 New version that can reserve upto 2GB of heap space.
9008
f7ff1b0f 90092011-05-05 Chong Yidong <cyd@stupidchicken.com>
45cb8994
CY
9010
9011 * nsfns.m (Fns_read_file_name): Doc fix (Bug#8534).
9012
639c109b
TZ
90132011-05-05 Teodor Zlatanov <tzz@lifelogs.com>
9014
9015 * gnutls.c (fn_gnutls_certificate_set_x509_key_file): Add alias to
9016 `gnutls_certificate_set_x509_key_file'.
9017
d2127135
JB
90182011-05-05 Juanma Barranquero <lekktu@gmail.com>
9019
9020 * makefile.w32-in ($(BLD)/image.$(O), $(BLD)/process.$(O)):
9021 Update dependencies.
9022
e968f4f3
JB
90232011-05-04 Juanma Barranquero <lekktu@gmail.com>
9024
9025 * gnutls.h (emacs_gnutls_write, emacs_gnutls_read):
9026 * gnutls.c (emacs_gnutls_write, emacs_gnutls_read):
9027 Remove unused parameter `fildes'.
9028 * process.c (read_process_output, send_process): Don't pass it.
9029
84d358f0
JB
90302011-05-04 Juanma Barranquero <lekktu@gmail.com>
9031
9032 Fix previous change: the library cache is defined in w32.c.
9033 * image.c (CACHE_IMAGE_TYPE) [!HAVE_NTGUI]: Define to noop.
9034 (Finit_image_library): Wrap Vlibrary_cache on "#ifdef HAVE_NTGUI".
9035
0898ca10
JB
90362011-05-04 Juanma Barranquero <lekktu@gmail.com>
9037
9038 Implement dynamic loading of GnuTLS on Windows.
9039
9040 * gnutls.h (GNUTLS_EMACS_ERROR_NOT_LOADED): New macro.
9041 (emacs_gnutls_write, emacs_gnutls_read): Mark as extern.
9042 (emacs_gnutls_record_check_pending, emacs_gnutls_transport_set_errno):
9043 Declare.
9044
9045 * gnutls.c (Qgnutls_dll): Define.
9046 (DEF_GNUTLS_FN, LOAD_GNUTLS_FN): New macros.
9047 (gnutls_*): Declare function pointers.
9048 (init_gnutls_functions): New function to initialize function pointers.
9049 (emacs_gnutls_handshake, Fgnutls_error_string, Fgnutls_deinit)
9050 (emacs_gnutls_global_init, Fgnutls_bye): Use function pointers.
9051 (emacs_gnutls_record_check_pending, emacs_gnutls_transport_set_errno):
9052 Wrappers for gnutls_record_check_pending and gnutls_transport_set_errno.
9053 (emacs_gnutls_write, emacs_gnutls_read)
9054 (emacs_gnutls_handle_error, Fgnutls_error_fatalp)
9055 (Fgnutls_available_p): New function.
9056 (Fgnutls_boot): Call Fgnutls_available_p. Use function pointers.
9057 (syms_of_gnutls) <Qgnutls_dll>: Initialize and staticpro it.
9058 (syms_of_gnutls) <Sgnutls_available_p>: defsubr it.
9059
9060 * image.c: Include w32.h.
9061 (Vimage_type_cache): Delete.
9062 (syms_of_image) <Vimage_type_cache>: Don't initialize and staticpro it.
9063 (CACHE_IMAGE_TYPE, Finit_image_library): Use Vlibrary_cache instead.
9064 (w32_delayed_load): Move to w32.c.
9065
9066 * w32.h (VlibraryCache, QCloaded_from, w32_delayed_load): Declare.
9067
9068 * w32.c (QCloaded_from, Vlibrary_cache): Define.
9069 (w32_delayed_load): Move from image.c. When loading a library, record
9070 its filename in the :loaded-from property of the library id.
9071 (globals_of_w32) <QCloaded_from, Vlibrary_cache>:
9072 Initialize and staticpro them.
9073 (emacs_gnutls_pull, emacs_gnutls_push): Call emacs_gnutls_* functions.
9074
9075 * process.c: Include lisp.h before w32.h, not after.
9076 (wait_reading_process_output): Call emacs_gnutls_record_check_pending
9077 instead of gnutls_record_check_pending.
9078
9079 * callproc.c, emacs.c: Include lisp.h before w32.h, not after.
9080
ff4de4aa
TZ
90812011-05-04 Teodor Zlatanov <tzz@lifelogs.com>
9082
9083 * gnutls.c (Fgnutls_boot): Support :keylist and :crlfiles options
9084 instead of :keyfiles. Give GnuTLS the keylist and the CRL lists
9085 as passed in.
9086
abe95abb
JD
90872011-05-03 Jan Djärv <jan.h.d@swipnet.se>
9088
9089 * xterm.c (x_set_frame_alpha): Do not set property on anything
9090 else than FRAME_X_OUTER_WINDOW (Bug#8608).
9091
e16e55d4
JB
90922011-05-02 Juanma Barranquero <lekktu@gmail.com>
9093
9094 * sysdep.c (get_tty_size) [WINDOWSNT]: Implement. (Bug#8596)
9095
bafcf6a5
JB
90962011-05-02 Juanma Barranquero <lekktu@gmail.com>
9097
9098 * gnutls.c (Qgnutls_log_level, Qgnutls_code, Qgnutls_anon)
9099 (Qgnutls_x509pki, Qgnutls_e_interrupted, Qgnutls_e_again)
9100 (Qgnutls_e_invalid_session, Qgnutls_e_not_ready_for_handshake)
9101 (gnutls_global_initialized, Qgnutls_bootprop_priority)
9102 (Qgnutls_bootprop_trustfiles, Qgnutls_bootprop_keyfiles)
9103 (Qgnutls_bootprop_callbacks, Qgnutls_bootprop_loglevel)
9104 (Qgnutls_bootprop_hostname, Qgnutls_bootprop_verify_flags)
9105 (Qgnutls_bootprop_verify_error, Qgnutls_bootprop_verify_hostname_error)
9106 (Qgnutls_bootprop_callbacks_verify): Make static.
9107
e7a6747f
AS
91082011-05-01 Andreas Schwab <schwab@linux-m68k.org>
9109
19ed11ba
AS
9110 * callproc.c: Indentation fixup.
9111
e7a6747f 9112 * sysdep.c (wait_for_termination_1): Make static.
04f2d78b
CB
9113 (wait_for_termination, interruptible_wait_for_termination):
9114 Move after wait_for_termination_1.
e7a6747f 9115
1ef14cb4
LMI
91162011-05-01 Lars Magne Ingebrigtsen <larsi@gnus.org>
9117
9118 * sysdep.c (interruptible_wait_for_termination): New function
9119 which is like wait_for_termination, but allows keyboard
9120 interruptions.
9121
9122 * callproc.c (Fcall_process): Add (:file "file") as an option for
9123 the STDOUT buffer.
9124 (Fcall_process_region): Ditto.
9125
330d880c
EZ
91262011-04-30 Eli Zaretskii <eliz@gnu.org>
9127
8db90b73
EZ
9128 * dosfns.c (Fint86, Fdos_memget, Fdos_memput): Use `ASIZE (FOO)'
9129 rather than `XVECTOR (FOO)->size'.
9130
330d880c
EZ
9131 * process.c: Remove HAVE_INTTYPES_H condition from inclusion of
9132 inttypes.h, as a gnulib replacement is used if it not available in
9133 system headers.
9134
15cbd324
EZ
91352011-04-21 Eli Zaretskii <eliz@gnu.org>
9136
9137 Lift the MOST_POSITIVE_FIXNUM/4 limitation on visited files.
9138 * fileio.c (Finsert_file_contents): Don't limit file size to 1/4
9139 of MOST_POSITIVE_FIXNUM. (Bug#8528)
9140
9141 * coding.c (coding_alloc_by_realloc): Error out if destination
9142 will grow beyond MOST_POSITIVE_FIXNUM.
9143 (decode_coding_emacs_mule): Abort if there isn't enough place in
9144 charbuf for the composition carryover bytes. Reserve an extra
9145 space for up to 2 characters produced in a loop.
9146 (decode_coding_iso_2022): Abort if there isn't enough place in
9147 charbuf for the composition carryover bytes.
9148
91492011-04-21 Eli Zaretskii <eliz@gnu.org>
afda1437 9150
ae940cca
EZ
9151 * doprnt.c (doprnt) [!HAVE_LONG_LONG_INT]: Error out instead of
9152 aborting when %lld or %lll format is passed.
9153 [!HAVE_UNSIGNED_LONG_LONG_INT]: Error out instead of aborting when
9154 %llo or %llx format is passed. (Bug#8545)
9155
03ab8921
EZ
9156 * window.c (window_scroll_line_based): Use a marker instead of
9157 simple variables to record original value of point. (Bug#7952)
9158
afda1437
EZ
9159 * doprnt.c (doprnt): Fix the case where a multibyte sequence
9160 produced by %s or %c overflows available buffer space. (Bug#8545)
9161
f76dee0c
PE
91622011-04-28 Paul Eggert <eggert@cs.ucla.edu>
9163
9164 * doprnt.c (doprnt): Omit useless test; int overflow check (Bug#8545).
283cdbef 9165 (SIZE_MAX): Move defn after all includes, as they might #define it.
f76dee0c 9166
fdc5744d
JB
91672011-04-28 Juanma Barranquero <lekktu@gmail.com>
9168
9169 * w32.c (init_environment): Warn about defaulting HOME to C:\.
9170
638f053a
JB
91712011-04-28 Juanma Barranquero <lekktu@gmail.com>
9172
9173 * keyboard.c (Qdelayed_warnings_hook): Define.
9174 (command_loop_1): Run `delayed-warnings-hook'
9175 if Vdelayed_warnings_list is non-nil.
9176 (syms_of_keyboard) <delayed-warnings-hook>: DEFSYM it.
9177 (syms_of_keyboard) <delayed-warnings-list>: DEFVAR_LISP it.
9178
d178f871
EZ
91792011-04-28 Eli Zaretskii <eliz@gnu.org>
9180
9181 * doprnt.c (doprnt): Don't return value smaller than the buffer
9182 size if the message was truncated. (Bug#8545).
9183
b124fd93
JB
91842011-04-28 Juanma Barranquero <lekktu@gmail.com>
9185
9186 * w32fns.c (Fx_change_window_property, Fx_delete_window_property)
9187 (Fx_window_property): #if-0 the whole functions, not just the bodies.
9188
e810457d
PE
91892011-04-27 Paul Eggert <eggert@cs.ucla.edu>
9190
9191 * doprnt.c (doprnt): Support "ll" length modifier, for long long.
9192
ea51cceb
JB
91932011-04-27 Juanma Barranquero <lekktu@gmail.com>
9194
9195 * makefile.w32-in: Update dependencies.
9196
94dcfacf
EZ
91972011-04-27 Eli Zaretskii <eliz@gnu.org>
9198
9199 Improve `doprnt' and its usage. (Bug#8545)
9200 * doprnt.c (doprnt): Make sure `format' is never accessed beyond
9201 `format_end'. Remove support for %l as a conversion specifier.
9202 Don't use xrealloc. Improve diagnostics when the %l size modifier
9203 is used. Update the commentary.
9204
9205 * eval.c (verror): Simplify calculation of size_t.
9206
9207 * coding.c (Ffind_operation_coding_system): Fix diagnostic error
9208 messages.
9209
f61f41d7
PE
92102011-04-27 Yoshiaki Kasahara <kasahara@nc.kyushu-u.ac.jp> (tiny change)
9211
9212 * buffer.c (init_buffer) [USE_MMAP_FOR_BUFFERS]: Adjust to aliasing
9213 change.
9214
96fb4434
PE
92152011-04-27 Paul Eggert <eggert@cs.ucla.edu>
9216
9217 * nsmenu.m: Replace all uses of XVECTOR with ASIZE and AREF.
9218 This makes this file independent of the recent pseudovector change.
9219
671875da 92202011-04-26 Paul Eggert <eggert@cs.ucla.edu>
eab3844f 9221
69e9b5a3
PE
9222 * keyboard.c (handle_user_signal): Fix pointer signedness problem.
9223
b5f869a7 9224 * gnutls.c (emacs_gnutls_handle_error): Remove unused local.
7754e151 9225 (Fgnutls_boot): gnutls_certificate_verify_peers2 wants unsigned *.
8d4c3955 9226 Remove unused local.
c8926152 9227 (emacs_gnutls_write): Don't use uninitialized rtnval if nbyte <= 0.
080e5a8d 9228
841a1577 9229 * lisp.h: Fix a problem with aliasing and vector headers. (Bug#8546)
04f2d78b
CB
9230 GCC 4.6.0 optimizes based on type-based alias analysis.
9231 For example, if b is of type struct buffer * and v of type struct
eab3844f
PE
9232 Lisp_Vector *, then gcc -O2 was incorrectly assuming that &b->size
9233 != &v->size, and therefore "v->size = 1; b->size = 2; return
9234 v->size;" must therefore return 1. This assumption is incorrect
9235 for Emacs, since it type-puns struct Lisp_Vector * with many other
9236 types. To fix this problem, this patch adds a new type struct
f904488f 9237 vectorlike_header that documents the constraints on layout of vectors
eab3844f
PE
9238 and pseudovectors, and helps optimizing compilers not get fooled
9239 by Emacs's type punning. It also adds the macros XSETTYPED_PVECTYPE
9240 XSETTYPED_PSEUDOVECTOR, TYPED_PSEUDOVECTORP, for similar reasons.
f904488f
PE
9241 * lisp.h (XSETTYPED_PVECTYPE): New macro, specifying the name of
9242 the size member.
eab3844f
PE
9243 (XSETPVECTYPE): Rewrite in terms of new macro.
9244 (XSETPVECTYPESIZE): New macro, specifying both type and size.
9245 This is a bit clearer, and further avoids the possibility of
9246 undesirable aliasing.
9247 (XSETTYPED_PSEUDOVECTOR): New macro, specifying the size.
f904488f 9248 (XSETPSEUDOVECTOR): Rewrite in terms of XSETTYPED_PSEUDOVECTOR.
eab3844f
PE
9249 (XSETSUBR): Rewrite in terms of XSETTYPED_PSEUDOVECTOR and XSIZE,
9250 since Lisp_Subr is a special case (no "next" field).
04f2d78b
CB
9251 (ASIZE): Now uses header.size rather than size.
9252 All previous uses of XVECTOR (foo)->size replaced to use this macro,
f904488f
PE
9253 to avoid the hassle of writing XVECTOR (foo)->header.size.
9254 (struct vectorlike_header): New type.
eab3844f
PE
9255 (TYPED_PSEUDOVECTORP): New macro, also specifying the C type of the
9256 object, to help avoid aliasing.
9257 (PSEUDOVECTORP): Rewrite in terms of TYPED_PSEUDOVECTORP.
9258 (SUBRP): Likewise, since Lisp_Subr is a special case.
9259 * lisp.h (struct Lisp_Vector, struct Lisp_Char_Table):
9260 (struct Lisp_Sub_Char_Table, struct Lisp_Bool_Vector):
9261 (struct Lisp_Hash_Table): Combine first two members into a single
f904488f 9262 struct vectorlike_header member. All uses of "size" and "next" members
eab3844f
PE
9263 changed to be "header.size" and "header.next".
9264 * buffer.h (struct buffer): Likewise.
9265 * font.h (struct font_spec, struct font_entity, struct font): Likewise.
9266 * frame.h (struct frame): Likewise.
9267 * process.h (struct Lisp_Process): Likewise.
9268 * termhooks.h (struct terminal): Likewise.
9269 * window.c (struct save_window_data, struct saved_window): Likewise.
9270 * window.h (struct window): Likewise.
9271 * alloc.c (allocate_buffer, Fmake_bool_vector, allocate_pseudovector):
9272 Use XSETPVECTYPESIZE, not XSETPVECTYPE, to avoid aliasing problems.
9273 * buffer.c (init_buffer_once): Likewise.
9274 * lread.c (defsubr): Use XSETTYPED_PVECTYPE, since Lisp_Subr is a
9275 special case.
9276 * process.c (Fformat_network_address): Use local var for size,
9277 for brevity.
9278
0df1eac5
PE
9279 * bytecode.c (exec_byte_code): Don't use XVECTOR before CHECK_VECTOR.
9280
847ab9d1 9281 Make the Lisp reader and string-to-float more consistent (Bug#8525)
452f4150
PE
9282 * data.c (atof): Remove decl; no longer used or needed.
9283 (digit_to_number): Move to lread.c.
9284 (Fstring_to_number): Use new string_to_number function, to be
9285 consistent with how the Lisp reader treats infinities and NaNs.
9286 Do not assume that floating-point numbers represent EMACS_INT
9287 without losing information; this is not true on most 64-bit hosts.
9288 Avoid double-rounding errors, by insisting on integers when
9289 parsing non-base-10 numbers, as the documentation specifies.
9290 * lisp.h (string_to_number): New decl, replacing ...
9291 (isfloat_string): Remove.
bc0a5c13 9292 * lread.c: Include <inttypes.h>, for uintmax_t and strtoumax.
d78050d6 9293 (read1): Do not accept +. and -. as integers; this
452f4150
PE
9294 appears to have been a coding error. Similarly, do not accept
9295 strings like +-1e0 as floating point numbers. Do not report
9296 overflow for integer overflows unless the base is not 10 which
9297 means we have no simple and reliable way to continue.
9298 Break out the floating-point parsing into a new
9299 function string_to_number, so that Fstring_to_number parses
9300 floating point numbers consistently with the Lisp reader.
04f2d78b 9301 (digit_to_number): Move here from data.c. Make it static inline.
452f4150
PE
9302 (E_CHAR, EXP_INT): Remove, replacing with ...
9303 (E_EXP): New macro, to solve the "1.0e+" problem mentioned below.
9304 (string_to_number): New function, replacing isfloat_string.
9305 This function checks for valid syntax and produces the resulting
9306 Lisp float number too. Rework it so that string-to-number
bc0a5c13 9307 no longer mishandles examples like "1.0e+". Use strtoumax,
d78050d6
PE
9308 so that overflow for non-base-10 numbers is reported only when
9309 there's no portable and simple way to convert to floating point.
452f4150 9310
67769ffc
PE
9311 * textprop.c (set_text_properties_1): Rewrite for clarity,
9312 and to avoid GCC warning about integer overflow.
9313
c20db43f
PE
9314 * intervals.h (struct interval): Use EMACS_INT for members
9315 where EMACS_UINT might cause problems. See
9316 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00514.html>.
9317 (CHECK_TOTAL_LENGTH): Remove cast to EMACS_INT; no longer needed.
9318 * intervals.c (interval_deletion_adjustment): Now returns EMACS_INT.
9319 All uses changed.
37aa2f85
PE
9320 (offset_intervals): Tell GCC not to worry about length overflow
9321 when negating a negative length.
c20db43f 9322
2538aa2f
PE
9323 * alloc.c (overrun_check_malloc, overrun_check_realloc): Now static.
9324 (overrun_check_free): Likewise.
9325
f2d3008d
PE
9326 * alloc.c (SDATA_SIZE) [!GC_CHECK_STRING_BYTES]: Avoid runtime check
9327 in the common case where SDATA_DATA_OFFSET is a multiple of Emacs
9328 word size.
9329
ec8df744
PE
9330 * gnutls.c: Fix problems found by GCC 4.6.0 on Ubuntu 10.10.
9331 (gnutls_make_error): Rename local to avoid shadowing.
9332 (gnutls_emacs_global_deinit): ifdef out; not used.
9333 (Fgnutls_boot): Use const for pointer to readonly storage.
9334 Comment out unused local. Fix pointer signedness problems.
9335
640ee02d
PE
9336 * lread.c (openp): Don't stuff size_t into an 'int'.
9337 Use <= on length, not < on length + 1, to avoid GCC 4.6.0 warning
9338 about possible signed overflow.
9339
6048fb2a
PE
9340 * gtkutil.c: Fix problems found by GCC 4.6.0 on Ubuntu 10.10.
9341 (GDK_KEY_g): Don't define if already defined.
9342 (xg_prepare_tooltip): Avoid pointer signedness problem.
9343 (xg_set_toolkit_scroll_bar_thumb): Redo to avoid two casts.
9344
fa3c87e1
PE
9345 * process.c (Fnetwork_interface_info): Avoid left-shift undefined
9346 behavior with 1 << 31. GCC 4.6.0 warns about this on 32-bit hosts.
9347
2172544b
PE
9348 * xfns.c (Fx_window_property): Simplify a bit,
9349 to make a bit faster and to avoid GCC 4.6.0 warning.
9350 * xselect.c (x_get_window_property, x_handle_dnd_message): Likewise.
9351
9b821a21
PE
9352 * fns.c (internal_equal): Don't assume size_t fits in int.
9353
3c616cfa
PE
9354 * alloc.c (compact_small_strings): Tighten assertion a little.
9355
c2982e87
PE
9356 Replace pEd with more-general pI, and fix some printf arg casts.
9357 * lisp.h (pI): New macro, generalizing old pEd macro to other
9358 conversion specifiers. For example, use "...%"pI"d..." rather
9359 than "...%"pEd"...".
9360 (pEd): Remove. All uses replaced with similar uses of pI.
61bdb816 9361 * m/amdx86-64.h, m/ia64.h, m/ibms390x.h: Likewise.
c2982e87
PE
9362 * alloc.c (check_pure_size): Don't overflow by converting size to int.
9363 * bidi.c (bidi_dump_cached_states): Use pI to avoid cast.
9364 * data.c (Fnumber_to_string): Use pI instead of if-then-else-abort.
9365 * dbusbind.c (xd_append_arg): Use pI to avoid cast.
9366 (Fdbus_method_return_internal, Fdbus_method_error_internal): Likewise.
9367 * font.c (font_unparse_xlfd): Avoid potential buffer overrun on
9368 64-bit hosts.
9369 (font_unparse_xlfd, font_unparse_fcname): Use pI to avoid casts.
9370 * keyboard.c (record_char, modify_event_symbol): Use pI to avoid casts.
9371 * print.c (safe_debug_print, print_object): Likewise.
9372 (print_object): Don't overflow by converting EMACS_INT or EMACS_UINT
9373 to int.
6f04d126
PE
9374 Use pI instead of if-then-else-abort. Use %p to avoid casts,
9375 avoiding the 0 flag, which is not portable.
c2982e87
PE
9376 * process.c (Fmake_network_process): Use pI to avoid cast.
9377 * region-cache.c (pp_cache): Likewise.
9378 * xdisp.c (decode_mode_spec): Likewise.
9379 * xrdb.c (x_load_resources) [USE_MOTIF]: Use pI to avoid undefined
9380 behavior on 64-bit hosts with printf arg.
6f04d126 9381 * xselect.c (x_queue_event): Use %p to avoid casts, avoiding 0 flag.
c2982e87
PE
9382 (x_stop_queuing_selection_requests): Likewise.
9383 (x_get_window_property): Don't truncate byte count to an 'int'
9384 when tracing.
0b432f21 9385
5e073ec7
PE
9386 * frame.c (frame_name_fnn_p): Get rid of strtol, which isn't right
9387 here, since it parses constructs like leading '-' and spaces,
9388 which are not wanted; and it overflows with large numbers.
9389 Instead, simply match F[0-9]+, which is what is wanted anyway.
9390
36372bf9
PE
9391 * alloc.c: Remove unportable assumptions about struct layout.
9392 (SDATA_SELECTOR, SDATA_DATA_OFFSET): New macros.
9393 (SDATA_OF_STRING, SDATA_SIZE, allocate_string_data):
9394 (allocate_vectorlike, make_pure_vector): Use the new macros,
9395 plus offsetof, to remove unportable assumptions about struct layout.
9396 These assumptions hold on all porting targets that I know of, but
9397 they are not guaranteed, they're easy to remove, and removing them
9398 makes further changes easier.
9399
0b432f21
PE
9400 * alloc.c (BLOCK BYTES): Fix typo by changing "ablock" to "ablocks".
9401 This doesn't fix a bug but makes the code clearer.
bfd1c781
PE
9402 (string_overrun_cookie): Now const. Use initializers that
9403 don't formally overflow signed char, to avoid warnings.
000098c1
PE
9404 (allocate_string_data) [GC_CHECK_STRING_OVERRUN]: Fix typo that
9405 can cause Emacs to crash when string overrun checking is enabled.
c7bda33c
PE
9406 (allocate_buffer): Don't assume sizeof (struct buffer) is a
9407 multiple of sizeof (EMACS_INT); it need not be, if
9408 alignof(EMACS_INT) < sizeof (EMACS_INT).
d0f4e1f5 9409 (check_sblock, check_string_bytes, check_string_free_list): Protoize.
0b432f21 9410
895009e1
JB
94112011-04-26 Juanma Barranquero <lekktu@gmail.com>
9412
9413 * keyboard.c (QCrtl): Rename from Qrtl. All uses changed.
9414
6a7a1b0b
TZ
94152011-04-26 Teodor Zlatanov <tzz@lifelogs.com>
9416
9417 * gnutls.c (emacs_gnutls_handshake): Return an error if we're not
b5f869a7 9418 supposed to be handshaking. (Bug#8556)
6a7a1b0b
TZ
9419 Reported by Paul Eggert <eggert@cs.ucla.edu>.
9420
841a1577 94212011-04-26 Daniel Colascione <dan.colascione@gmail.com>
0438ce91
DC
9422
9423 * lisp.h (Qdebug): List symbol.
895009e1 9424 * eval.c (Qdebug): Restore global linkage.
0438ce91
DC
9425 * keyboard.c (debug-on-event): New variable.
9426 (handle_user_signal): Break into debugger when debug-on-event
9427 matches the current signal symbol.
9428
f2d3ba6f
DN
94292011-04-25 Dan Nicolaescu <dann@ics.uci.edu>
9430
9431 * alloc.c (check_sblock, check_string_bytes)
9432 (check_string_free_list): Convert to standard C.
9433
42ce4c63
TZ
94342011-04-25 Teodor Zlatanov <tzz@lifelogs.com>
9435
9436 * w32.c (emacs_gnutls_push): Fix typo.
9437
825cd63c
EZ
94382011-04-25 Eli Zaretskii <eliz@gnu.org>
9439
fb11d64d
EZ
9440 * gnutls.c (emacs_gnutls_handshake): Avoid compiler warnings about
9441 "cast to pointer from integer of different size".
9442
825cd63c
EZ
9443 Improve doprnt and its use in verror. (Bug#8545)
9444 * doprnt.c (doprnt): Document the set of format control sequences
9445 supported by the function. Use SAFE_ALLOCA instead of always
9446 using `alloca'.
9447
9448 * eval.c (verror): Don't limit the buffer size at size_max-1, that
9449 is one byte too soon. Don't use xrealloc; instead xfree and
9450 xmalloc anew.
9451
e061a11b
TZ
94522011-04-24 Teodor Zlatanov <tzz@lifelogs.com>
9453
9454 * gnutls.h: Add GNUTLS_STAGE_CALLBACKS enum to denote we're in the
9455 callbacks stage.
9456
9457 * gnutls.c: Renamed global_initialized to
9458 gnutls_global_initialized. Added internals for the
9459 :verify-hostname-error, :verify-error, and :verify-flags
9460 parameters of `gnutls-boot' and documented those parameters in the
9461 docstring. Start callback support.
9173deec
JB
9462 (emacs_gnutls_handshake): Add Woe32 support. Retry handshake
9463 unless a fatal error occurred. Call gnutls_alert_send_appropriate
9464 on error. Return error code.
e061a11b
TZ
9465 (emacs_gnutls_write): Call emacs_gnutls_handle_error.
9466 (emacs_gnutls_read): Likewise.
9467 (Fgnutls_boot): Return handshake error code.
9468 (emacs_gnutls_handle_error): New function.
9469 (wsaerror_to_errno): Likewise.
9470
9471 * w32.h (emacs_gnutls_pull): Add prototype.
9472 (emacs_gnutls_push): Likewise.
9473
9474 * w32.c (emacs_gnutls_pull): New function for GnuTLS on Woe32.
9475 (emacs_gnutls_push): Likewise.
9476
94772011-04-24 Claudio Bley <claudio.bley@gmail.com> (tiny change)
9478
9479 * process.c (wait_reading_process_output): Check if GnuTLS
9480 buffered some data internally if no FDs are set for TLS
9481 connections.
9482
9483 * makefile.w32-in (OBJ2): Add gnutls.$(O).
9484 (LIBS): Link to USER_LIBS.
9485 ($(BLD)/gnutls.$(0)): New target.
9486
fa6996bc
EZ
94872011-04-24 Eli Zaretskii <eliz@gnu.org>
9488
eb35682e
EZ
9489 * xdisp.c (handle_single_display_spec): Rename the
9490 display_replaced_before_p argument into display_replaced_p, to
9491 make it consistent with the commentary. Fix typos in the
9492 commentary.
9493
e2ad650c
EZ
9494 * textprop.c (syms_of_textprop): Remove dead code.
9495 (copy_text_properties): Delete obsolete commentary about an
9496 interface that was deleted long ago. Fix typos in the description
9497 of arguments.
9498
1b2de274
EZ
9499 * msdos.c (XMenuActivate, XMenuAddSelection): Adjust argument list
9500 to changes in oldXMenu/XMenu.h from 2011-04-16.
9501 <menu_help_message, prev_menu_help_message>: Constify.
9502 (IT_menu_make_room): menu->help_text is now `const char **';
9503 adjust.
9504
9505 * msdos.h (XMenuActivate, XMenuAddSelection): Adjust prototypes
9506 to changes in oldXMenu/XMenu.h from 2011-04-16.
9507 (struct XMenu): Declare `help_text' `const char **'.
9508
9509 * xfaces.c <Qunspecified>: Make extern again.
9510
9511 * syntax.c: Include sys/types.h before including regex.h, as
75f1671a 9512 required by POSIX.
1b2de274 9513
762b15be
EZ
9514 * doc.c (get_doc_string): Improve the format passed to `error'.
9515
9516 * doprnt.c (doprnt): Improve commentary.
9517
9518 * term.c (init_tty) [MSDOS]: Fix 1st argument to maybe_fatal.
9519
9520 * Makefile.in (TAGS): Depend on $(M_FILE) and $(S_FILE), and scan
9521 them with etags.
9522
f1052e5d
EZ
9523 * makefile.w32-in (globals.h): Add a dummy recipe, to make any
9524 changes in globals.h immediately force recompilation.
762b15be
EZ
9525 (TAGS): Depend on $(CURDIR)/m/intel386.h and
9526 $(CURDIR)/s/ms-w32.h.
9527 (TAGS-gmake): Scan $(CURDIR)/m/intel386.h and $(CURDIR)/s/ms-w32.h.
f1052e5d 9528
fa6996bc
EZ
9529 * character.c (Fchar_direction): Function deleted.
9530 (syms_of_character): Don't defsubr it.
9531 <char-direction-table>: Deleted.
9532
e6c3da20
EZ
95332011-04-23 Eli Zaretskii <eliz@gnu.org>
9534
9535 Fix doprnt so it could be used again safely in `verror'. (Bug#8435)
9536 * doprnt.c: Include limits.h.
9537 (SIZE_MAX): New macro.
04f2d78b
CB
9538 (doprnt): Return a size_t value. 2nd arg is now size_t.
9539 Many local variables are now size_t instead of int or unsigned.
e6c3da20
EZ
9540 Improve overflow protection. Support `l' modifier for integer
9541 conversions. Support %l conversion. Don't assume an EMACS_INT
9542 argument for integer conversions and for %c.
9543
9544 * lisp.h (doprnt): Restore prototype.
9545
9546 * makefile.w32-in ($(BLD)/callint.$(O)): Depend on
9547 $(SRC)/character.h.
9548
9549 * Makefile.in (base_obj): Add back doprnt.o.
9550
9551 * deps.mk (doprnt.o): Add back prerequisites.
9552 (callint.o): Depend on character.h.
9553
9554 * eval.c (internal_lisp_condition_case): Include the handler
9555 representation in the error message.
9556 (verror): Call doprnt instead of vsnprintf. Fix an off-by-one bug
9557 when breaking from the loop.
9558
9559 * xdisp.c (vmessage): Call doprnt instead of vsnprintf.
9560
9561 * callint.c (Fcall_interactively): When displaying error message
9562 about invalid control letter, pass the character's codepoint, not
9563 a pointer to its multibyte form. Improve display of the character
9564 in octal and display also its hex code.
9565
9566 * character.c (char_string): Use %x to display the (unsigned)
9567 codepoint of an invalid character, to avoid displaying a bogus
9568 negative value.
9569
9570 * font.c (check_otf_features): Pass SDATA of SYMBOL_NAME to
9571 `error', not SYMBOL_NAME itself.
9572
9573 * coding.c (Fencode_sjis_char, Fencode_big5_char): Use %c for
9574 character arguments to `error'.
9575
9576 * charset.c (check_iso_charset_parameter): Fix incorrect argument
9577 to `error' in error message about FINAL_CHAR argument. Make sure
9578 FINAL_CHAR is a character, and use %c when it is passed as
9579 argument to `error'.
9580
4ffd0d6b 95812011-04-23 Eli Zaretskii <eliz@gnu.org>
97a93095
EZ
9582
9583 * s/ms-w32.h (localtime): Redirect to sys_localtime.
9584
9585 * w32.c: Include <time.h>.
9586 (sys_localtime): New function.
9587
4ffd0d6b 95882011-04-23 Chong Yidong <cyd@stupidchicken.com>
c17819f4
CY
9589
9590 * xdisp.c (init_xdisp): Initialize echo_area_window (Bug#6451).
9591
4ffd0d6b 9592 * buffer.c (syms_of_buffer): Doc fix (Bug#6902).
aac0c6e3 9593
4ffd0d6b 95942011-04-23 Samuel Thibault <sthibault@debian.org> (tiny change)
aac0c6e3 9595
4ffd0d6b
GM
9596 * sysdep.c (wait_for_termination): On GNU Hurd, kill returns -1 on
9597 zombies (Bug#8467).
aac0c6e3 9598
04c56954
EZ
95992011-04-19 Eli Zaretskii <eliz@gnu.org>
9600
9601 * syntax.h (SETUP_SYNTAX_TABLE_FOR_OBJECT): Fix setting of
9602 gl_state.e_property when gl_state.object is Qt.
9603
9604 * insdel.c (make_gap_larger): Remove limitation of buffer size
9605 to <= INT_MAX.
9606
16a43933
CY
96072011-04-18 Chong Yidong <cyd@stupidchicken.com>
9608
9609 * xdisp.c (lookup_glyphless_char_display)
9610 (produce_glyphless_glyph): Handle cons cell entry in
9611 glyphless-char-display.
9612 (Vglyphless_char_display): Document it.
9613
9614 * term.c (produce_glyphless_glyph): Handle cons cell entry in
9615 glyphless-char-display.
9616
4581706e
CY
96172011-04-17 Chong Yidong <cyd@stupidchicken.com>
9618
9619 * xdisp.c (get_next_display_element): Remove unnecessary ifdefs.
9620
9621 * termhooks.h (FRAME_WINDOW_P): Remove duplicated definitions.
9622
9623 * dispextern.h (FACE_SUITABLE_FOR_ASCII_CHAR_P): Add missing
9624 definition for no-X builds.
9625
4887c6e2 96262011-04-16 Paul Eggert <eggert@cs.ucla.edu>
764430a3 9627
fd35b6f9
PE
9628 Static checks with GCC 4.6.0 and non-default toolkits.
9629
5c1ccb01
PE
9630 * s/sol2-6.h, s/unixware.h (PTY_TTY_NAME_SPRINTF): Protoize decl.
9631
006c5daa
PE
9632 * process.c (keyboard_bit_set): Define only if SIGIO.
9633 (send_process_trap): Mark it with NO_RETURN if it doesn't return.
9634 (send_process): Repair possible setjmp clobbering.
9635
efc736d3
PE
9636 * s/usg5-4-common.h (SETUP_SLAVE_PTY): Don't pass extra arg to 'fatal'.
9637
4e2fe2e6
PE
9638 * eval.c: Include <stdio.h>, for vsnprintf on non-GNU/Linux hosts.
9639
f97334a2
PE
9640 * data.c (arith_error): Mark with NO_RETURN if it doesn't return.
9641
4e75f29d
PE
9642 * alloc.c (bytes_used_when_full, SPARE_MEMORY, BYTES_USED):
9643 Define only if needed.
9644
90efadd1
PE
9645 * sysdep.c (_FILE_OFFSET_BITS): Make this hack even uglier
9646 by pacifying GCC about it. Maybe it's time to retire it?
875975e9 9647 * xfaces.c (USG, __TIMEVAL__): Likewise.
90efadd1 9648
3c647824
PE
9649 * dispextern.h (struct redisplay_interface): Rename param
9650 to avoid shadowing.
e264f262 9651 * termhooks.h (struct terminal): Likewise.
761383f4 9652 * xterm.c (xembed_send_message): Likewise.
3c647824 9653
b58c5c4a
PE
9654 * insdel.c (make_gap_smaller): Define only if
9655 USE_MMAP_FOR_BUFFERS || REL_ALLOC || DOUG_LEA_MALLOC.
9656
cad59032
PE
9657 * keyboard.c (read_char): Make a var volatile so longjmp won't clobber
9658 it.
9659
c339dc2e
PE
9660 * emacs.c (MAX_HEAP_BSS_DIFF, my_edata): Move to where they're used,
9661 so that we aren't warned about unused symbols.
9662
91a3e27b
PE
9663 * xfns.c (Fx_file_dialog): Rename local to avoid shadowing.
9664
399c71d3 9665 * xdisp.c (x_produce_glyphs): Mark var as initialized (Bug#8512).
7a3fb125 9666
8ffc96f5
PE
9667 * xfns.c (x_real_positions): Mark locals as initialized.
9668
eef9bc79
PE
9669 * xmenu.c (xmenu_show): Don't use uninitialized vars.
9670
098db9dd
PE
9671 * xterm.c: Fix problems found by static analysis with other toolkits.
9672 (toolkit_scroll_bar_interaction): Define and use only if USE_X_TOOLKIT.
dda3aedd
PE
9673 (x_dispatch_event): Declare static if USE_GTK, and
9674 define if USE_GTK || USE_X_TOOLKIT.
098db9dd 9675 (SET_SAVED_BUTTON_EVENT): Define only if USE_X_TOOLKIT || USE_GTK.
dda3aedd 9676 * xterm.h (x_dispatch_event): Extern only if USE_X_TOOLKIT.
841a1577
JB
9677 * xterm.c, xterm.h (x_mouse_leave): Bring this function back, but only
9678 if defined HAVE_MENUS && !defined USE_X_TOOLKIT && !defined USE_GTK.
098db9dd 9679
eb18f6cc
PE
9680 * xmenu.c (menu_help_callback): Pointer type fixes.
9681 Use const pointers when pointing at readonly data. Avoid pointer
9682 signedness clashes.
9683 (FALSE): Remove unused macro.
9684 (update_frame_menubar): Remove unused decl.
9685
1fe72bf8
PE
9686 * xfns.c (Fx_hide_tip): Move locals to avoid shadowing.
9687
60d9e1db
PE
9688 * menu.c (push_submenu_start, push_submenu_end): Do not define unless
9689 USE_X_TOOLKIT || USE_GTK || HAVE_NS || defined HAVE_NTGUI.
9690 (single_menu_item): Rename local to avoid shadowing.
9691
39261c26
PE
9692 * keyboard.c (make_lispy_event): Remove unused local var.
9693
018c5e19
PE
9694 * frame.c, frame.h (x_get_resource_string): Bring this back, but
9695 only if HAVE_X_WINDOWS && !USE_X_TOOLKIT.
9696
63d2b86e
PE
9697 * bitmaps: Change bitmaps from unsigned char back to the X11
9698 compatible char. Avoid the old compiler warnings about
9699 out-of-range initializers by using, for example, '\xab' rather
9700 than 0xab.
9701
aefd87e1
PE
9702 * xgselect.c (xgselect_initialize): Check vs interface
9703 even if ! (defined (USE_GTK) || defined (HAVE_GCONF)).
9704
bf501fb9
PE
9705 * xmenu.c (xmenu_show): Rename parm to avoid shadowing.
9706
e9829fdf
PE
9707 * xterm.c (x_create_toolkit_scroll_bar): Use const * for pointers
9708 to read-only memory.
9709
1086c095
PE
9710 * fns.c (vector): Remove; this old hack is no longer needed.
9711
2baccd04 9712 * xsmfns.c (create_client_leader_window): Rename shadowing arg.
401f10cb 9713 Remove unused var.
dde42981 9714 (gdk_x11_set_sm_client_id) [!USE_GTK]: Don't define.
2baccd04 9715
72391843 9716 * xrdb.c (x_load_resources): Omit unused local.
3565b346 9717
436c16df 9718 * xfns.c (free_frame_menubar, atof): Remove duplicate decls.
8a94ea33 9719 (x_window): Rename locals to avoid shadowing.
dc5ddd85 9720 (USG): Use the kludged USG macro, to pacify gcc.
436c16df 9721
92bb796d 9722 * xterm.c (x_alloc_nearest_color_for_widget): Remove; unused.
bbbef9e1 9723 (x_term_init): Remove local to avoid shadowing.
92bb796d 9724
764430a3 9725 * xfns.c, xterm.c (_XEditResCheckMessages): Protoize decl.
4887c6e2
PE
9726
9727 * xdisp.c, dispextern.h (set_vertical_scroll_bar): Now extern if
9728 USE_TOOLKIT_SCROLL_BARS && !USE_GTK, as xterm.c needs it then.
9729
d1dfb56c
EZ
97302011-04-16 Eli Zaretskii <eliz@gnu.org>
9731
c4354cb4
EZ
9732 * gnutls.c (Fgnutls_boot): Don't pass Lisp_Object to `error'.
9733
d1dfb56c
EZ
9734 Fix regex.c, syntax.c and friends for buffers > 2GB.
9735 * syntax.h (struct gl_state_s): Declare character position members
9736 EMACS_INT.
9737
9738 * syntax.c (update_syntax_table): Declare 2nd argument EMACS_INT.
9739
04f2d78b
CB
9740 * textprop.c (verify_interval_modification, interval_of):
9741 Declare arguments EMACS_INT.
d1dfb56c
EZ
9742
9743 * intervals.c (adjust_intervals_for_insertion): Declare arguments
9744 EMACS_INT.
9745
9746 * intervals.h (CHECK_TOTAL_LENGTH): Cast to EMACS_INT, not `int'.
9747
9748 * indent.c (Fvertical_motion): Local variable it_start is now
9749 EMACS_INT.
9750
9751 * regex.c (re_match, re_match_2, re_match_2_internal)
9752 (bcmp_translate, regcomp, regexec, print_double_string)
9753 (group_in_compile_stack, re_search, re_search_2, regex_compile)
9754 (re_compile_pattern, re_exec): Declare arguments and local
9755 variables `size_t' and `ssize_t' and return values `regoff_t', as
9756 appropriate.
9757 (POP_FAILURE_REG_OR_COUNT) <pfreg>: Declare `long'.
9758 (CHECK_INFINITE_LOOP) <failure>: Declare `ssize_t'.
9759 <compile_stack_type>: `size' and `avail' are now `size_t'.
9760
9761 * regex.h <regoff_t>: Use ssize_t, not int.
9762 (re_search, re_search_2, re_match, re_match_2): Arguments that
9763 specify buffer/string position and length are now ssize_t and
9764 size_t. Return type is regoff_t.
9765
613052cd
BK
97662011-04-16 Ben Key <bkey76@gmail.com>
9767
9768 * nsfont.m: Fixed bugs in ns_get_family and
9769 ns_descriptor_to_entity that were caused by using free to
9770 deallocate memory blocks that were allocated by xmalloc (via
9771 xstrdup). This caused Emacs to crash when compiled with
9772 XMALLOC_OVERRUN_CHECK defined (when Emacs was configured with
9773 --enable-checking=xmallocoverrun). xfree is now used to
9774 deallocate these memory blocks.
9775
4170f62f 97762011-04-15 Paul Eggert <eggert@cs.ucla.edu>
3e047f51 9777
71b41406
PE
9778 * sysdep.c (emacs_read): Remove unnecessary check vs MAX_RW_COUNT.
9779
9587a89d
PE
9780 emacs_write: Accept and return EMACS_INT for sizes.
9781 See http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00514.html
9782 et seq.
9783 * gnutls.c, gnutls.h (emacs_gnutls_read, emacs_gnutls_write):
9784 Accept and return EMACS_INT.
9785 (emacs_gnutls_write): Return the number of bytes written on
9786 partial writes.
9787 * sysdep.c, lisp.h (emacs_read, emacs_write): Likewise.
273a5f82
PE
9788 (emacs_read, emacs_write): Remove check for negative size, as the
9789 Emacs source code has been audited now.
9587a89d
PE
9790 * sysdep.c (MAX_RW_COUNT): New macro, to work around kernel bugs.
9791 (emacs_read, emacs_write): Use it.
273a5f82
PE
9792 * process.c (send_process): Adjust to the new signatures of
9793 emacs_write and emacs_gnutls_write. Do not attempt to store
9794 a byte offset into an 'int'; it might overflow.
9587a89d 9795 See http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00483.html
273a5f82 9796
3e047f51
PE
9797 * sound.c: Don't assume sizes fit in 'int'.
9798 (struct sound_device.period_size, alsa_period_size):
9c3c56a7 9799 Return EMACS_INT, not int.
3e047f51 9800 (struct sound_device.write, vox_write, alsa_write):
9c3c56a7
PE
9801 Accept EMACS_INT, not int.
9802 (wav_play, au_play): Use EMACS_INT to store sizes and to
3e047f51
PE
9803 record read return values.
9804
cc39a9db
BK
98052011-04-15 Ben Key <bkey76@gmail.com>
9806
c9d0ec6d
JB
9807 * keyboard.c (Qundefined): Don't declare static since it is used
9808 in nsfns.m.
9809 * xfaces.c (Qbold, Qexpanded, Qitalic, Qcondensed): Don't declare
9810 static since they are used in nsfont.m.
cc39a9db 9811
6c60eb9f
SM
98122011-04-15 Stefan Monnier <monnier@iro.umontreal.ca>
9813
9814 * process.c (Qprocessp): Don't declare static.
9815 * lisp.h (Qprocessp): Declare again.
9816
7990b61a
JB
98172011-04-15 Juanma Barranquero <lekktu@gmail.com>
9818
9819 * font.c (Qopentype): Don't make static (used from w32uniscribe.c).
9820
5d4cb038
PE
98212011-04-14 Paul Eggert <eggert@cs.ucla.edu>
9822
8bd7b830 9823 Improve C-level modularity by making more things 'static'.
cd64ea1d 9824
e3b27b31
PE
9825 Don't publish debugger-only interfaces to other modules.
9826 * lisp.h (safe_debug_print, debug_output_compilation_hack):
9827 (verify_bytepos, count_markers): Move decls to the only modules
9828 that need them.
9829 * region-cache.h (pp_cache): Likewise.
9830 * window.h (check_all_windows): Likewise.
9831 * marker.c, print.c, region-cache.c, window.c: Decls moved here.
9832
5d4cb038
PE
9833 * sysdep.c (croak): Now static, if
9834 defined TIOCNOTTY || defined USG5 || defined CYGWIN.
9835 * syssignal.h (croak): Declare only if not static.
69003fd8
PE
9836
9837 * alloc.c (refill_memory_reserve): Now static if
9838 !defined REL_ALLOC || defined SYSTEM_MALLOC.
9839 * lisp.h (refill_memory_reserve): Declare only if not static.
93ea6e8f 9840
e87b6180
PE
9841 * xsettings.c, xsettings.h (xsettings_get_system_normal_font):
9842 Define only if USE_LUCID.
9843
ac64929e
PE
9844 * xrdb.c (x_customization_string, x_rm_string): Now static.
9845
6f37259d
PE
9846 * xmenu.c (x_menu_wait_for_event): Export only if USE_MOTIF.
9847 * xterm.h (x_menu_wait_for_event): Declare only if USE_MOTIF.
9848
1683e3ab
PE
9849 * xdisp.c (draw_row_with_mouse_face): Now static.
9850 * dispextern.h (draw_row_with_mouse_fave): Remove decl.
9851
de9c2632
PE
9852 * window.h (check_all_windows): Mark externally visible.
9853
2b96acb7
PE
9854 * window.c (window_deletion_count): Now static.
9855
9856 * undo.c: Make symbols static if they're not exported.
9857 (last_undo_buffer, last_boundary_position, pending_boundary):
9858 Now static.
9859
50436f33
PE
9860 * textprop.c (interval_insert_behind_hooks): Now static.
9861 (interval_insert_in_front_hooks): Likewise.
9862
64520e5c
PE
9863 * term.c: Make symbols static if they're not exported.
9864 (tty_turn_off_highlight, get_tty_terminal, max_frame_cols):
9865 (max_frame_lines, tty_set_terminal_modes):
9866 (tty_reset_terminal_modes, tty_turn_off_highlight):
9867 (get_tty_terminal): Now static.
9868 (term_mouse_moveto): Do not define if HAVE_WINDOW_SYSTEM.
9869 * termhooks.h (term_mouse_moveto): Do not declare if
8bd7b830 9870 HAVE_WINDOW_SYSTEM.
64520e5c
PE
9871 * dispextern.h (tty_set_terminal_modes, tty_reset_terminal_modes):
9872 (tty_turn_off_highlight, get_tty_terminal): Remove decls.
9873
1fa53021
PE
9874 * sysdep.c: Make symbols static if they're not exported.
9875 (emacs_get_tty, emacs_set_tty, old_fcntl_flags, old_fcntl_owner):
9876 Now static.
9877 (sigprocmask_set, full_mask): Remove; unused.
9878 (wait_debugging): Mark as visible.
9879 * syssignal.h (SIGFULLMASK, full_mask): Remove decls.
9880 * systty.h (emacs_get_tty, emacs_set_tty): Remove decls.
9881
d4b43b22
PE
9882 * syntax.c (syntax_temp): Define only if !__GNUC__.
9883
b7c513d0
PE
9884 * sound.c (current_sound_device, current_sound): Now static.
9885
989b29ad
PE
9886 * search.c (searchbufs, searchbuf_head): Now static.
9887
13a55a78
PE
9888 * scroll.c (scroll_cost): Remove; unused.
9889 * dispextern.h (scroll_cost): Remove decl.
9890
de68a1fc
PE
9891 * region-cache.h (pp_cache): Mark as externally visible.
9892
40ccffa6
PE
9893 * process.c: Make symbols static if they're not exported.
9894 (process_tick, update_tick, create_process, chan_process):
9895 (Vprocess_alist, proc_buffered_char, datagram_access):
9896 (fd_callback_data, send_process_frame, process_sent_to): Now static.
9897 (deactivate_process): Mark defn as static, as well as decl.
9898 * lisp.h (create_process): Remove decl.
9899 * process.h (chan_process, Vprocess_alist): Remove decls.
9900
ad64fc97
PE
9901 * print.c: Make symbols static if they're not exported.
9902 (print_depth, new_backquote_output, being_printed, print_buffer):
9903 (print_buffer_size, print_buffer_pos, print_buffer_pos_byte):
9904 (print_interval, print_number_index, initial_stderr_stream):
9905 Now static.
9906 * lisp.h (Fprinc): Remove decl.
9907 (debug_output_compilation_hack): Mark as externally visible.
9908
adddb265
PE
9909 * sysdep.c (croak): Move decl from here to syssignal.h.
9910 * syssignal.h (croak): Put it here, so the API can be checked when
9911 'croak' is called from dissociate_if_controlling_tty.
9912
1717ede2
PE
9913 * minibuf.c: Make symbols static if they're not exported.
9914 (minibuf_save_list, choose_minibuf_frame): Now static.
9915 * lisp.h (choose_minibuf_frame): Remove decl.
9916
fa5fb2bc
PE
9917 * lisp.h (verify_bytepos, count_markers): Mark as externally visible.
9918
1e3890d1
PE
9919 * lread.c: Make symbols static if they're not exported.
9920 (read_objects, initial_obarray, oblookup_last_bucket_number):
9921 Now static.
9922 (make_symbol): Remove; unused.
9923 * lisp.h (initial_obarray, make_symbol): Remove decls.
9924
8a1414fa
PE
9925 * keyboard.c: Make symbols static if they're not exported.
9926 (single_kboard, recent_keys_index, total_keys, recent_keys):
9927 (this_command_key_count_reset, raw_keybuf, raw_keybuf_count):
9928 (this_single_command_key_start, echoing, last_auto_save):
9929 (read_key_sequence_cmd, dribble, recursive_edit_unwind):
9930 (command_loop, echo_now, keyboard_init_hook, help_char_p):
9931 (quit_throw_to_read_char, command_loop_2, top_level_1, poll_timer):
9932 (Vlispy_mouse_stem, double_click_count):
9933 Now static.
9934 (force_auto_save_soon): Define only if SIGDANGER.
9935 (ignore_mouse_drag_p): Now static if
9936 !defined HAVE_WINDOW_SYSTEM || defined USE_GTK || defined HAVE_NS.
9937 (print_help): Remove; unused.
9938 (stop_character, last_timer_event): Mark as externally visible.
9939 * keyboard.h (ignore_mouse_drag_p): Declare only if
9940 defined HAVE_WINDOW_SYSTEM && !defined USE_GTK && !defined HAVE_NS.
9941 (echo_now, help_char_p, quit_throw_to_read_char): Remove decls.
9942 * lisp.h (echoing): Remove decl.
9943 (force_auto_save_soon): Declare only if SIGDANGER.
9944 * xdisp.c (redisplay_window): Simplify code, to make it more
9945 obvious that ignore_mouse_drag_p is not accessed if !defined
9946 USE_GTK && !defined HAVE_NS.
9947
93ea6e8f
PE
9948 * intervals.c: Make symbols static if they're not exported.
9949 (merge_properties_sticky, merge_interval_right, delete_interval):
9950 Now static.
9951 * intervals.h (merge_interval_right, delete_interval): Remove decls.
9952
77382fcc
PE
9953 * insdel.c: Make symbols static if they're not exported.
9954 However, leave prepare_to_modify_buffer alone. It's never
9955 called from outside this function, but that appears to be a bug.
9956 (combine_after_change_list, combine_after_change_buffer):
4889fc82 9957 (adjust_after_replace, signal_before_change): Now static.
77382fcc
PE
9958 (adjust_after_replace_noundo): Remove; unused.
9959 * lisp.h (adjust_after_replace, adjust_after_replace_noundo):
4889fc82 9960 (signal_before_change): Remove decls.
77382fcc 9961
9306c32e
PE
9962 * indent.c (val_compute_motion, val_vmotion): Now static.
9963
cd44d2eb
PE
9964 * image.c: Make symbols static if they're not exported.
9965 * dispextern.h (x_create_bitmap_from_xpm_data): Do not declare
9966 if USE_GTK.
9967 * image.c (x_create_bitmap_from_xpm_data): Do not define if USE_GTK.
9968 (xpm_color_cache, ct_table, ct_colors_allocated): Now static.
9969
ad9a7a06
PE
9970 * fringe.c (standard_bitmaps): Now static.
9971 (max_used_fringe_bitmap): Now static, unless HAVE_NS.
9972
81626931
PE
9973 * frame.c: Make symbols static if they're not exported.
9974 (x_report_frame_params, make_terminal_frame): Now static.
9975 (get_frame_param): Now static, unless HAVE_NS.
9976 (x_fullscreen_adjust): Define if WINDOWSNT, not if HAVE_WINDOW_SYSTEM.
9977 (x_get_resource_string): Remove; not used.
9978 * frame.h (make_terminal_frame, x_report_frame_params):
9979 (x_get_resource_string); Remove decls.
9980 (x_fullscreen_adjust): Declare only if WINDOWSNT.
9981 * lisp.h (get_frame_param): Declare only if HAVE_NS.
9982
239f9db9
PE
9983 * font.c, fontset.c: Make symbols static if they're not exported.
9984 * dispextern.h (FACE_SUITABLE_FOR_ASCII_CHAR_P): New macro.
9985 (FACE_SUITABLE_FOR_CHAR_P): Use it.
9986 * font.c (font_close_object): Now static.
9987 * font.h (font_close_object): Remove.
9988 * fontset.c (FONTSET_OBJLIST): Remove.
9989 (free_realized_fontset) #if-0 the body, which does nothing.
9990 (face_suitable_for_char_p): #if-0, as it's never called.
9991 * fontset.h (face_suitable_for_char_p): Remove decl.
04f2d78b
CB
9992 * xfaces.c (face_at_string_position):
9993 Use FACE_SUITABLE_FOR_ASCII_CHAR_P, not FACE_SUITABLE_FOR_CHAR_P,
239f9db9
PE
9994 since 0 is always ASCII.
9995
dfcf3579
PE
9996 * fns.c (weak_hash_tables): Now static.
9997
5045092b
PE
9998 * fileio.c: Make symbols static if they're not exported.
9999 (auto_saving, auto_save_mode_bits, auto_save_error_occurred):
10000 (Vwrite_region_annotation_buffers): Now static.
10001
57a96f5c
PE
10002 * eval.c: Make symbols static if they're not exported.
10003 (backtrace_list, lisp_eval_depth, when_entered_debugger): Now static.
10004 * lisp.h (backtrace_list): Remove decl.
10005
35f08c38
PE
10006 * emacs.c: Make symbols static if they're not exported.
10007 (malloc_state_ptr, malloc_using_checking, syms_of_emacs):
10008 (fatal_error_code, fatal_error_signal_hook, standard_args):
10009 Now static.
10010 (fatal_error_signal): Now static, unless FLOAT_CATCH_SIGKILL.
10011 (DEFINE_DUMMY_FUNCTION): Mark function as externally visible.
10012 (__CTOR_LIST__, __DTOR_LIST__): Now externally visible.
10013 * lisp.h (fatal_error_signal_hook): Remove decl.
10014 (fatal_error_signal): Declare only if FLOAT_CATCH_SIGKILL.
10015
f44bd759
PE
10016 * editfns.c: Move a (normally-unused) function to its only use.
10017 * editfns.c, lisp.h (get_operating_system_release): Remove.
10018 * process.c (init_process) [DARWIN_OS]: Do it inline, as it is not
10019 worth the hassle of breaking this out.
10020
b532497d
PE
10021 * xterm.c: Make symbols static if they're not exported.
10022 (x_raise_frame, x_lower_frame, x_wm_set_window_state):
10023 (x_wm_set_icon_pixmap, x_initialize, XTread_socket_fake_io_error):
10024 (x_destroy_window, x_delete_display):
10025 Now static.
10026 (x_dispatch_event): Now static if ! (USE_MOTIF || USE_X_TOOLKIT).
10027 (x_mouse_leave): Remove; unused.
10028 * xterm.h (x_display_info_for_name, x_raise_frame, x_lower_frame):
10029 (x_destroy_window, x_wm_set_window_state, x_wm_set_icon_pixmap):
10030 (x_delete_display, x_initialize, x_set_border_pixel, x_screen_planes):
10031 Remove decls.
10032 (x_mouse_leave): Declare only if WINDOWSNT.
10033 (x_dispatch_event): Declare only if USE_MOTIF or USE_X_TOOLKIT.
10034 (xic_create_fontsetname): Declare only if HAVE_X_WINDOWS &&
10035 USE_X_TOOLKIT.
10036
1675728f
PE
10037 * ftxfont.c: Make symbols static if they're not exported.
10038 (ftxfont_driver): Export only if !defined HAVE_XFT && def8ined
10039 HAVE_FREETYPE.
10040 * font.h (ftxfont_driver): Likewise.
10041
e4cebfca
PE
10042 * xfns.c: Make symbols static if they're not exported.
10043 (x_last_font_name, x_display_info_for_name):
10044 (x_set_foreground_color, x_set_background_color, x_set_mouse_color):
10045 (x_set_cursor_color, x_set_border_pixel, x_set_border_color):
10046 (x_set_cursor_type, x_set_icon_type, x_set_icon_name):
10047 (x_set_scroll_bar_foreground, x_set_scroll_bar_background):
10048 (x_explicitly_set_name, x_set_title, xic_defaut_fontset, tip_timer):
10049 (last_show_tip_args): Now static.
10050 (xic_defaut_fontset, xic_create_fontsetname): Define only if
10051 defined HAVE_X_WINDOWS && defined USE_X_TOOLKIT
10052 (x_screen_planes): Remove; unused.
10053 * dispextern.h (x_screen_planes): Remove decl.
10054
5bf46f05
PE
10055 * dispnew.c: Make symbols static if they're not exported.
10056 * dispextern.h (redraw_garbaged_frames, scrolling):
10057 (increment_row_positions): Remove.
10058 * dispnew.c (new_glyph_matrix, increment_row_positions, scrolling):
10059 (delayed_size_change, glyph_matrix_count, glyph_pool_count):
10060 Now static.
10061 (redraw_garbaged_frames): Remove; unused.
10062
435f4c28
PE
10063 * xfaces.c: Make symbols static if they're not exported.
10064 * dispextern.h (ascii_face_of_lisp_face, free_realized_face):
10065 Remove decls.
10066 * xterm.h (defined_color): Remove decls.
10067 (x_free_dpy_colors): Declare only if USE_X_TOOLKIT.
10068 * xfaces.c (tty_suppress_bold_inverse_default_colors_p):
10069 (menu_face_changed_default, defined_color, free_realized_face):
10070 (x_free_dpy_colors): Define only if USE_X_TOOLKIT.
10071 (ascii_face_of_lisp_face): Remove; unused.
10072
8524aef3
PE
10073 * xdisp.c: Make symbols static if they're not exported.
10074 * dispextern.h (scratch_glyph_row, window_box_edges):
10075 (glyph_to_pixel_coords, set_cursor_from_row):
10076 (get_next_display_element, set_iterator_to_next):
10077 (highlight_trailing_whitespace, frame_to_window_pixel_xy):
10078 (show_mouse_face): Remove decls
10079 * frame.h (message_buf_print): Likewise.
10080 * lisp.h (pop_message, set_message, check_point_in_composition):
10081 Likewise.
10082 * xterm.h (set_vertical_scroll_bar): Likewise.
10083 * xdisp.c (list_of_error, Vmessage_stack, line_number_displayed):
10084 (message_buf_print, scratch_glyph_row, displayed_buffer):
10085 (set_iterator_to_next, pop_message, set_message, set_cursor_from_row):
10086 (get_next_display_element, show_mouse_face, window_box_edges):
10087 (frame_to_window_pixel_xy, check_point_in_composition):
10088 (set_vertical_scroll_bar, highlight_trailing_whitespace): Now static.
10089 (glyph_to_pixel_coords): Remove; unused.
10090
16390cd2
PE
10091 * dired.c (file_name_completion): Now static.
10092
10093 * dbusbind.c (xd_in_read_queued_messages): Now static.
10094
a25f4dfa
PE
10095 * lisp.h (circular_list_error, FOREACH): Remove; unused.
10096 * data.c (circular_list_error): Remove.
10097
14a9c8df
PE
10098 * commands.h (last_point_position, last_point_position_buffer):
10099 (last_point_position_window): Remove decls.
10100 * keyboard.c: Make these variables static.
10101
04f2d78b
CB
10102 * coding.h (coding, code_convert_region, encode_coding_gap):
10103 Remove decls.
74ab6df5
PE
10104 * coding.c (Vsjis_coding_system, Vbig5_coding_system):
10105 (iso_code_class, detect_coding, code_convert_region): Now static.
10106 (encode_coding_gap): Remove; unused.
10107
38dfbee1
PE
10108 * chartab.c (chartab_chars, chartab_bits): Now static.
10109
a2cb4e63
PE
10110 * charset.h (charset_iso_8859_1): Remove decl.
10111 * charset.c (charset_iso_8859_1, charset_emacs, map_charset_for_dump):
10112 Now static.
10113
127198fd
PE
10114 * ccl.h (check_ccl_update, Vccl_program_table): Remove decls.
10115 * ccl.c (Vccl_program_table): Now static.
10116 (check_ccl_update): Remove; unused.
10117
d85b608f
PE
10118 * category.c (SET_CATEGORY_SET, set_category_set): Move here.
10119 * category.h: ... from here.
10120 * category.c (check_category_table, set_category_set): Now static.
10121
31cd66f3
PE
10122 * casetab.c (Vascii_upcase_table, Vascii_eqv_table): Now static.
10123 * lisp.h: Remove these decls.
10124
c358e587
PE
10125 * buffer.c (buffer_count): Remove unused var.
10126
e78aecca
PE
10127 * bidi.c (bidi_dump_cached_states): Mark as externally visible,
10128 so that it's not optimized away.
10129 (bidi_ignore_explicit_marks_for_paragraph_level): Likewise.
10130 * dispextern.h (bidi_dump_cached_states): Remove, since it's
10131 exported only to the debugger.
10132
e192d7d3 10133 * atimer.c (alarm_signal_handler, run_all_atimers): Now static.
04f2d78b 10134 * atimer.h (run_all_atimers): Remove; not exported.
e192d7d3 10135
92470028
PE
10136 font.c: Make copy_font_spec and merge_font_spec ordinary C functions.
10137 * font.c (copy_font_spec): Rename from Fcopy_font_spec, since it
10138 was inaccessible from Lisp.
10139 (merge_font_spec): Likewise, renaming from Fmerge_font_spec.
10140 * font.c, font.h, fontset.c, xfaces.c, xfont.c: Change all uses.
10141
244ed907
PE
10142 alloc.c: Import and export fewer symbols, and remove unused items.
10143 * lisp.h (suppress_checking, die): Declare only if ENABLE_CHECKING
10144 is defined.
10145 (suppress_checking): Add EXTERNALLY_VISIBLE attribute, so that
10146 it's not optimized away by whole-program optimization.
10147 (message_enable_multibyte, free_misc): Remove.
10148 (catchlist, handlerlist, mark_backtrace):
10149 Declare only if BYTE_MARK_STACK.
10150 (mark_byte_stack): Likewise, fixing a ifdef-vs-if typo.
10151 * alloc.c (pure): Export only if VIRT_ADDR_VARIES is defined.
10152 (message_enable_multibyte): Remove decl.
10153 (free_misc, interval_free_list, float_block, float_block_index):
10154 (n_float_blocks, float_free_list, cons_block, cons_block_index):
10155 (cons_free_list, last_marked_index):
10156 Now static.
10157 (suppress_checking, die): Define only if ENABLE_CHECKING is defined.
10158 * eval.c (catchlist, handlerlist): Export only if BYTE_MARK_STACK.
10159 (mark_backtrace): Define only if BYTE_MARK_STACK.
10160 * xdisp.c (message_enable_multibyte): Now static.
10161
61c2b50e 10162 Declare Lisp_Object Q* variables to be 'static' if not exported.
955cbe7b
PE
10163 This makes it easier for human readers (and static analyzers)
10164 to see whether these variables are used from other modules.
10165 * alloc.c, buffer.c, bytecode.c, callint.c, casetab.c, category.c:
10166 * ccl.c, character.c, charset.c, cmds.c, coding.c, composite.c:
10167 * data.c, dbusbind.c, dired.c, editfns.c, eval.c, fileio.c, fns.c:
10168 * font.c, frame.c, fringe.c, ftfont.c, image.c, keyboard.c, keymap.c:
10169 * lread.c, macros.c, minibuf.c, print.c, process.c, search.c:
10170 * sound.c, syntax.c, textprop.c, window.c, xdisp.c, xfaces.c, xfns.c:
10171 * xmenu.c, xselect.c:
10172 Declare Q* vars static if they are not used in other modules.
10173 * ccl.h, character.h, charset.h, coding.h, composite.h, font.h:
10174 * frame.h, intervals.h, keyboard.h, lisp.h, process.h, syntax.h:
10175 Remove decls of unexported vars.
10176 * keyboard.h (EVENT_HEAD_UNMODIFIED): Remove now-unused macro.
10177
95c82688
PE
10178 * lisp.h (DEFINE_FUNC): Make sname 'static'.
10179
16a97296
PE
10180 Make Emacs functions such as Fatom 'static' by default.
10181 This makes it easier for human readers (and static analyzers)
10182 to see whether these functions can be called from other modules.
10183 DEFUN now defines a static function. To make the function external
10184 so that it can be used in other C modules, use the new macro DEFUE.
8bd7b830
PE
10185 * lisp.h (Funibyte_char_to_multibyte, Fsyntax_table_p):
10186 (Finit_image_library):
16a97296
PE
10187 (Feval_region, Fbacktrace, Ffetch_bytecode, Fswitch_to_buffer):
10188 (Ffile_executable_p, Fmake_symbolic_link, Fcommand_execute):
10189 (Fget_process, Fdocumentation_property, Fbyte_code, Ffile_attributes):
10190 Remove decls, since these functions are now static.
10191 (Funintern, Fget_internal_run_time): New decls, since these functions
10192 were already external.
95c82688 10193
16a97296
PE
10194 * alloc.c, buffer.c, callint.c, callproc.c, casefiddle.c, casetab.c:
10195 * ccl.c, character.c, chartab.c, cmds.c, coding.c, data.c, dispnew.c:
10196 * doc.c, editfns.c, emacs.c, eval.c, fileio.c, filelock.c, floatfns.c:
10197 * fns.c, font.c, fontset.c, frame.c, image.c, indent.c:
10198 * keyboard.c, keymap.c, lread.c:
10199 * macros.c, marker.c, menu.c, minibuf.c, print.c, process.c, search.c:
10200 * syntax.c, term.c, terminal.c, textprop.c, undo.c:
10201 * window.c, xdisp.c, xfaces.c, xfns.c, xmenu.c, xsettings.c:
10202 Mark functions with DEFUE instead of DEFUN,
10203 if they are used in other modules.
10204 * buffer.c (Fset_buffer_major_mode, Fdelete_overlay): New forward
10205 decls for now-static functions.
10206 * buffer.h (Fdelete_overlay): Remove decl.
10207 * callproc.c (Fgetenv_internal): Mark as internal.
10208 * composite.c (Fremove_list_of_text_properties): Remove decl.
10209 (Fcomposition_get_gstring): New forward static decl.
10210 * composite.h (Fcomposite_get_gstring): Remove decl.
10211 * dired.c (Ffile_attributes): New forward static decl.
10212 * doc.c (Fdocumntation_property): New forward static decl.
10213 * eval.c (Ffetch_bytecode): New forward static decl.
10214 (Funintern): Remove extern decl; now in .h file where it belongs.
10215 * fileio.c (Fmake_symbolic_link): New forward static decl.
10216 * image.c (Finit_image_library): New forward static decl.
10217 * insdel.c (Fcombine_after_change_execute): Make forward decl static.
10218 * intervals.h (Fprevious_property_change):
10219 (Fremove_list_of_text_properties): Remove decls.
10220 * keyboard.c (Fthis_command_keys): Remove decl.
10221 (Fcommand_execute): New forward static decl.
10222 * keymap.c (Flookup_key): New forward static decl.
10223 (Fcopy_keymap): Now static.
10224 * keymap.h (Flookup_key): Remove decl.
10225 * process.c (Fget_process): New forward static decl.
10226 (Fprocess_datagram_address): Mark as internal.
10227 * syntax.c (Fsyntax_table_p): New forward static decl.
10228 (skip_chars): Remove duplicate decl.
10229 * textprop.c (Fprevious_property_change): New forward static decl.
10230 * window.c (Fset_window_fringes, Fset_window_scroll_bars):
10231 Now internal.
10232 (Fset_window_margins, Fset_window_vscroll): New forward static decls.
10233 * window.h (Fset_window_vscroll, Fset_window_margins): Remove decls.
10234
785bbd42
PE
10235 * editfns.c (Fformat): Remove unreachable code.
10236
8b913b57
AS
102372011-04-14 Andreas Schwab <schwab@linux-m68k.org>
10238
10239 * fileio.c (Finsert_file_contents): Fix typo in 2005-05-13
10240 change. (Bug#8496)
10241
a6744a35
EZ
102422011-04-13 Eli Zaretskii <eliz@gnu.org>
10243
10244 * xdisp.c (handle_invisible_prop): Don't call bidi_paragraph_init
10245 when at ZV. (Bug#8487)
10246
e7974947
AS
102472011-04-12 Andreas Schwab <schwab@linux-m68k.org>
10248
baad03f0
AS
10249 * charset.c (Fclear_charset_maps): Use xfree instead of free.
10250 (Bug#8437)
10251 * keyboard.c (parse_tool_bar_item): Likewise.
10252 * sound.c (sound_cleanup, alsa_close): Likewise.
10253 * termcap.c (tgetent): Likewise.
10254 * xfns.c (x_default_font_parameter): Likewise.
10255 * xsettings.c (read_and_apply_settings): Likewise.
10256
e7974947
AS
10257 * alloc.c (overrun_check_malloc, overrun_check_realloc)
10258 (overrun_check_free): Protoize.
10259
28272684
PE
102602011-04-12 Paul Eggert <eggert@cs.ucla.edu>
10261
10262 * sysdep.c (emacs_read, emacs_write): Check for negative sizes
10263 since callers should never pass a negative size.
10264 Change the signature to match that of plain 'read' and 'write'; see
10265 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00397.html>.
10266 * lisp.h: Update prototypes of emacs_write and emacs_read.
10267
11997c76
EZ
102682011-04-11 Eli Zaretskii <eliz@gnu.org>
10269
10270 * xdisp.c (redisplay_window): Don't try to determine the character
10271 position of the scroll margin if the window start point w->startp
e896f03c 10272 is outside the buffer's accessible region. (Bug#8468)
11997c76 10273
8a2cbd72
EZ
102742011-04-10 Eli Zaretskii <eliz@gnu.org>
10275
10276 Fix write-region and its subroutines for buffers > 2GB.
10277 * fileio.c (a_write, e_write): Modify declaration of arguments and
10278 local variables to support buffers larger than 2GB.
10279 (Fcopy_file): Use EMACS_INT for return value of emacs_read.
10280
10281 * sysdep.c (emacs_write, emacs_read): Use ssize_t for last
10282 argument, local variables, and return value.
10283
10284 * lisp.h: Update prototypes of emacs_write and emacs_read.
10285
10286 * sound.c (vox_write): Use ssize_t for return value of emacs_write.
10287
4073e537 102882011-04-10 Paul Eggert <eggert@cs.ucla.edu>
eb3f1cc8 10289
1ebfdcb6
PE
10290 * xdisp.c (vmessage): Use memchr, not strnlen, which some hosts lack.
10291
b2ded58d
PE
10292 Fix more problems found by GCC 4.6.0's static checks.
10293
7d66342c
PE
10294 * xdisp.c (vmessage): Use a better test for character truncation.
10295
bbf47d44
PE
10296 * charset.c (load_charset_map): <, not <=, for optimization,
10297 and to avoid potential problems with integer overflow.
9248994d 10298 * chartab.c (sub_char_table_set_range, char_table_set_range): Likewise.
f9a68bc5 10299 * casetab.c (set_identity, shuffle): Likewise.
3ab1c7ce 10300 * editfns.c (Fformat): Likewise.
1e69125e 10301 * syntax.c (skip_chars): Likewise.
3befa583 10302
e3019616
PE
10303 * xmenu.c (set_frame_menubar): Allocate smaller local vectors.
10304 This also lets GCC 4.6.0 generate slightly better loop code.
10305
becfa255
PE
10306 * callint.c (Fcall_interactively): <, not <=, for optimization.
10307 (Fcall_interactively): Count the number of arguments produced,
10308 not the number of arguments given. This is simpler and lets GCC
10309 4.6.0 generate slightly better code.
10310
dae0cd48
PE
10311 * ftfont.c: Distingish more carefully between FcChar8 and char.
10312 The previous code passed unsigned char * to a functions like
10313 strlen and xstrcasecmp that expect char *, which does not
10314 conform to the C standard.
10315 (get_adstyle_property, ftfont_pattern_entity): Use FcChar8 for
10316 arguments to FcPatternGetString, and explicitly cast FcChar8 * to
10317 char * when the C standard requires it.
10318
76032d70
PE
10319 * keyboard.c (read_char): Remove unused var.
10320
eb3f1cc8
PE
10321 * eval.c: Port to Windows vsnprintf (Bug#8435).
10322 Include <limits.h>.
10323 (SIZE_MAX): Define if the headers do not.
10324 (verror): Do not give up if vsnprintf returns a negative count.
10325 Instead, grow the buffer. This ports to Windows vsnprintf, which
10326 does not conform to C99. Problem reported by Eli Zaretskii.
10327 Also, simplify the allocation scheme, by avoiding the need for
10328 calling realloc, and removing the ALLOCATED variable.
10329
70476b54
PE
10330 * eval.c (verror): Initial buffer size is 4000 (not 200) bytes.
10331
12020a9e
PE
10332 Remove invocations of doprnt, as Emacs now uses vsnprintf.
10333 But keep the doprint source code for now, as we might revamp it
10334 and use it again (Bug#8435).
ea6c7ae6
PE
10335 * lisp.h (doprnt): Remove.
10336 * Makefile.in (base_obj): Remove doprnt.o.
10337 * deps.mk (doprnt.o): Remove.
10338
5fdb398c
PE
10339 error: Print 32- and 64-bit integers portably (Bug#8435).
10340 Without this change, on typical 64-bit hosts error ("...%d...", N)
10341 was used to print both 32- and 64-bit integers N, which relied on
10342 undefined behavior.
61bdb816 10343 * lisp.h, m/amdx86-64.h, m/ia64.h, m/ibms390x.h (pEd): New macro.
5fdb398c
PE
10344 * lisp.h (error, verror): Mark as printf-like functions.
10345 * eval.c (verror): Use vsnprintf, not doprnt, to do the real work.
10346 Report overflow in size calculations when allocating printf buffer.
10347 Do not truncate output string at its first null byte.
10348 * xdisp.c (vmessage): Use vsnprintf, not doprnt, to do the real work.
10349 Truncate the output at a character boundary, since vsnprintf does not
10350 do that.
10351 * charset.c (check_iso_charset_parameter): Convert internal
10352 character to string before calling 'error', since %c now has the
10353 printf meaning.
10354 * coding.c (Fdecode_sjis_char, Fdecode_big5_char): Avoid int
10355 overflow when computing char to be passed to 'error'. Do not
10356 pass Lisp_Object to 'error'; pass the integer instead.
10357 * nsfns.m (Fns_do_applescript): Use int, not long, since it's
10358 formatted with plain %d.
10359
b189fa66
PE
10360 * eval.c (internal_lisp_condition_case): Don't pass spurious arg.
10361
bff87ef0
PE
10362 * keyboard.c (access_keymap_keyremap): Print func name, not garbage.
10363
7e2cac20
PE
10364 * coding.c (Fdecode_sjis_char): Don't assume CODE fits in int.
10365
ce4d90b5
PE
10366 * xterm.c (x_catch_errors): Remove duplicate declaration.
10367
266c9547
PE
10368 * term.c (maybe_fatal): Mark its 3rd arg as a printf format, too.
10369
79c49ad2
PE
10370 * xdisp.c, lisp.h (message_nolog): Remove; unused.
10371
368f4090
JM
103722011-04-10 Jim Meyering <meyering@redhat.com>
10373
10374 use ssize_t and size_t for read- and write-like emacs_gnutls_* functions
10375 * gnutls.c (emacs_gnutls_read): Adjust signature to be more read-like:
10376 return ssize_t not "int", and use size_t as the buffer length.
10377 (emacs_gnutls_write): Likewise, and make the buffer pointer "const".
10378 * gnutls.h: Update declarations.
10379 * process.c (read_process_output): Use ssize_t, to match.
10380 (send_process): Likewise.
10381
a32d4040
CY
103822011-04-09 Chong Yidong <cyd@stupidchicken.com>
10383
10384 * image.c (Fimagemagick_types): Doc fix, and comment cleanup.
10385
8546720e 103862011-04-09 Chong Yidong <cyd@stupidchicken.com>
aac0c6e3 10387
04f2d78b
CB
10388 * ftfont.c (get_adstyle_property, ftfont_pattern_entity):
10389 Use unsigned char, to match FcChar8 type definition.
aac0c6e3 10390
8546720e
GM
10391 * xterm.c (handle_one_xevent):
10392 * xmenu.c (create_and_show_popup_menu):
10393 * xselect.c (x_decline_selection_request)
10394 (x_reply_selection_request): Avoid type-punned deref of X events.
aac0c6e3 10395
0a2f5c1a 103962011-04-09 Eli Zaretskii <eliz@gnu.org>
a53e2e89
EZ
10397
10398 Fix some uses of `int' instead of EMACS_INT.
10399 * search.c (string_match_1, fast_string_match)
10400 (fast_c_string_match_ignore_case, fast_string_match_ignore_case)
10401 (scan_buffer, find_next_newline_no_quit)
10402 (find_before_next_newline, search_command, Freplace_match)
10403 (Fmatch_data): Make some `int' variables be EMACS_INT.
10404
10405 * xdisp.c (display_count_lines): 3rd argument and return value now
10406 EMACS_INT. All callers changed.
10407 (pint2hrstr): Last argument is now EMACS_INT.
10408
10409 * coding.c (detect_coding_utf_8, detect_coding_emacs_mule)
10410 (detect_coding_iso_2022, detect_coding_sjis, detect_coding_big5)
10411 (detect_coding_ccl, detect_coding_charset, decode_coding_utf_8)
10412 (decode_coding_utf_16, decode_coding_emacs_mule)
10413 (decode_coding_iso_2022, decode_coding_sjis, decode_coding_big5)
10414 (decode_coding_ccl, decode_coding_charset)
10415 <consumed_chars, consumed_chars_base>: Declare EMACS_INT.
10416 (decode_coding_iso_2022, decode_coding_emacs_mule)
10417 (decode_coding_sjis, decode_coding_big5, decode_coding_charset)
10418 <char_offset, last_offset>: Declare EMACS_INT.
10419 (encode_coding_utf_8, encode_coding_utf_16)
10420 (encode_coding_emacs_mule, encode_invocation_designation)
10421 (encode_designation_at_bol, encode_coding_iso_2022)
10422 (encode_coding_sjis, encode_coding_big5, encode_coding_ccl)
10423 (encode_coding_raw_text, encode_coding_charset) <produced_chars>:
10424 Declare EMACS_INT.
10425 (ASSURE_DESTINATION): Declare more_bytes EMACS_INT.
10426 (encode_invocation_designation): Last argument P_NCHARS is now
10427 EMACS_INT.
10428 (decode_eol): Declare pos_byte, pos, and pos_end EMACS_INT.
10429 (produce_chars): from_nchars and to_nchars are now EMACS_INT.
10430
10431 * coding.h (struct coding_system) <head_ascii>: Declare EMACS_INT.
10432 All users changed.
10433
10434 * ccl.c (Fccl_execute_on_string): Declare some variables
10435 EMACS_INT.
10436
8546720e 104372011-04-08 Samuel Thibault <sthibault@debian.org> (tiny change)
0080dc6b
SS
10438
10439 * term.c (init_tty): Fix incorrect ifdef placement (Bug#8450).
10440
4e19a977
CS
104412011-03-19 Christoph Scholtes <cschol2112@googlemail.com>
10442
10443 * process.c (Fformat_network_address): Doc fix.
10444
87302331
R
104452011-04-08 T.V. Raman <tv.raman.tv@gmail.com> (tiny change)
10446
ee7683eb 10447 * xml.c (parse_region): Avoid creating spurious whitespace nodes.
87302331 10448
cbb59342
CY
104492011-04-08 Chong Yidong <cyd@stupidchicken.com>
10450
10451 * keyboard.c (read_char): Call Lisp function help-form-show,
10452 instead of using internal_with_output_to_temp_buffer.
10453 (Qhelp_form_show): New var.
e0d38eeb 10454 (syms_of_keyboard): Use DEFSYM macro.
cbb59342
CY
10455
10456 * print.c (internal_with_output_to_temp_buffer): Function deleted.
10457
10458 * lisp.h (internal_with_output_to_temp_buffer): Remove prototype.
10459
e67a13ab
CY
104602011-04-06 Chong Yidong <cyd@stupidchicken.com>
10461
04f2d78b
CB
10462 * process.c (Flist_processes): Remove to Lisp.
10463 (list_processes_1): Delete.
e67a13ab 10464
973f782d
EZ
104652011-04-06 Eli Zaretskii <eliz@gnu.org>
10466
7c106b1e
EZ
10467 * msdos.c (careadlinkat, careadlinkatcwd): MS-DOS replacements.
10468
973f782d
EZ
10469 * w32.c (careadlinkat, careadlinkatcwd): New always-fail stubs.
10470
41cf7d1a 104712011-04-06 Paul Eggert <eggert@cs.ucla.edu>
27ccc379 10472
ca23cc88
PE
10473 Fix more problems found by GCC 4.6.0's static checks.
10474
f390e2d5
PE
10475 * xmenu.c (Fx_popup_dialog): Don't assume string is free of formats.
10476
42eea0d0
PE
10477 * menu.c (Fx_popup_menu): Don't assume error_name lacks printf formats.
10478
b69769da 10479 * lisp.h (message, message_nolog, fatal): Mark as printf-like.
1e973bc7 10480
f9541e84
PE
10481 * xdisp.c (vmessage): Mark as a printf-like function.
10482
13841b55
PE
10483 * term.c (vfatal, maybe_fatal): Mark as printf-like functions.
10484
c136c10f
PE
10485 * sound.c (sound_warning): Don't crash if arg contains a printf format.
10486
5e2d4a30
PE
10487 * image.c (tiff_error_handler, tiff_warning_handler): Mark as
10488 printf-like functions.
10489 (tiff_load): Add casts to remove these marks before passing them
10490 to system-supplied API.
10491
583f48b9
PE
10492 * eval.c (Fsignal): Remove excess argument to 'fatal'.
10493
b25d760e
PE
10494 * coding.c (EMIT_ONE_BYTE, EMIT_TWO_BYTES): Use unsigned, not int.
10495 This avoids several warnings with gcc -Wstrict-overflow.
d5efd1d1
PE
10496 (DECODE_COMPOSITION_RULE): If the rule is invalid, goto invalid_code
10497 directly, rather than having caller test rule sign. This avoids
10498 some unnecessary tests.
10499 * composite.h (COMPOSITION_ENCODE_RULE_VALID): New macro.
10500 (COMPOSITION_ENCODE_RULE): Arguments now must be valid. This
10501 affects only one use, in DECODE_COMPOSITION_RULE, which is changed.
b25d760e 10502
bc7b6697 10503 * xfont.c (xfont_text_extents): Remove var that was set but not used.
625a3eb1 10504 (xfont_open): Avoid unnecessary tests.
bc7b6697 10505
27ccc379
PE
10506 * composite.c (composition_gstring_put_cache): Use unsigned integer.
10507
dcd5c89a
PE
10508 * composite.h, composite.c (composition_gstring_put_cache):
10509 Use EMACS_INT, not int, for length.
10510
b13a45c6
PE
10511 * composite.h (COMPOSITION_DECODE_REFS): New macro,
10512 breaking out part of COMPOSITION_DECODE_RULE.
10513 (COMPOSITION_DECODE_RULE): Use it.
10514 * composite.c (get_composition_id): Remove unused local vars,
10515 by using the new macro.
10516
1e792e4d
PE
10517 * textprop.c (set_text_properties_1): Change while to do-while,
10518 since the condition is always true at first.
10519
dc6c6455 10520 * intervals.c (graft_intervals_into_buffer): Mark var as used.
aa86731f
PE
10521 (interval_deletion_adjustment): Return unsigned value.
10522 All uses changed.
dc6c6455 10523
aba7731a
PE
10524 * process.c (list_processes_1, create_pty, read_process_output):
10525 (exec_sentinel): Remove vars that were set but not used.
afd4052b 10526 (create_pty): Remove unnecessary "volatile"s.
bc57d757 10527 (Fnetwork_interface_info): Avoid possibility of int overflow.
82eaa333 10528 (read_process_output): Do adaptive read buffering even if carryover.
fe07cdfa 10529 (read_process_output): Simplify nbytes computation if buffered.
aba7731a 10530
fdfc4bf3
PE
10531 * bytecode.c (exec_byte_code): Rename local to avoid shadowing.
10532
fca8fe46 10533 * syntax.c (scan_words): Remove var that was set but not used.
12cbf13f 10534 (update_syntax_table): Use unsigned instead of int.
fca8fe46 10535
06a0259a 10536 * lread.c (lisp_file_lexically_bound_p): Use ints rather than endptrs.
3c346cc3 10537 (lisp_file_lexically_bound_p, read1): Use unsigned instead of int.
e6eb4e9e 10538 (safe_to_load_p): Make the end-of-loop test the inverse of the in-loop.
06a0259a 10539
e7b9e80f
PE
10540 * print.c (print_error_message): Avoid int overflow.
10541
56201685
PE
10542 * font.c (font_list_entities): Redo for clarity,
10543 so that reader need not know FONT_DPI_INDEX + 1 == FONT_SPACING_INDEX.
10544
78834453 10545 * font.c (font_find_for_lface, Ffont_get_glyphs): Remove unused vars.
790771b1 10546 (font_score): Avoid potential overflow in diff calculation.
78834453 10547
0bc0b309 10548 * fns.c (substring_both): Remove var that is set but not used.
8cd55cb4 10549 (sxhash): Redo loop for clarity and to avoid wraparound warning.
0bc0b309 10550
e610eaca
PE
10551 * eval.c (funcall_lambda): Rename local to avoid shadowing.
10552
b895abce
PE
10553 * alloc.c (mark_object_loop_halt, mark_object): Use size_t, not int.
10554 Otherwise, GCC 4.6.0 optimizes the loop check away since the check
10555 can always succeed if overflow has undefined behavior.
10556
1f1d9321 10557 * search.c (boyer_moore, wordify): Remove vars set but not used.
6f076cc7 10558 (wordify): Omit three unnecessary tests.
1f1d9321 10559
c59478bc
PE
10560 * indent.c (MULTIBYTE_BYTES_WIDTH): Don't compute wide_column.
10561 All callers changed. This avoids the need for an unused var.
10562
79b73827
PE
10563 * casefiddle.c (casify_region): Remove var that is set but not used.
10564
a4db5dfe
PE
10565 * dired.c (file_name_completion): Remove var that is set but not used.
10566
43aae36e
PE
10567 * fileio.c (Finsert_file_contents): Make EOF condition clearer.
10568
2a47c44d 10569 * fileio.c (Finsert_file_contents): Avoid signed integer overflow.
163c5f32 10570 (Finsert_file_contents): Remove unnecessary code checking fd.
2a47c44d 10571
a37c69bf
PE
10572 * minibuf.c (read_minibuf_noninteractive): Use size_t for sizes.
10573 Check for integer overflow on size calculations.
10574
328ab8e7
PE
10575 * buffer.c (Fprevious_overlay_change): Remove var that is set
10576 but not used.
10577
e5a2a5cb
PE
10578 * keyboard.c (menu_bar_items, read_char_minibuf_menu_prompt):
10579 Remove vars that are set but not used.
8d84a6eb 10580 (timer_check_2): Don't assume timer-list and idle-timer-list are lists.
6b043475 10581 (timer_check_2): Mark vars as initialized.
e5a2a5cb 10582
a60e5f68
PE
10583 * gtkutil.c (xg_get_file_with_chooser): Mark var as initialized.
10584
f661cb61 10585 * image.c (lookup_image): Remove var that is set but not used.
35fa624f 10586 (xbm_load): Use parse_p, for gcc -Werror=unused-but-set-variable.
f661cb61 10587
f0397f5a
PE
10588 * fontset.c (Finternal_char_font, Ffontset_info): Remove vars
10589 that are set but not used.
10590
8664db06 10591 * xfns.c (make_invisible_cursor): Don't return garbage
03733ee7 10592 if XCreateBitmapFromData fails (Bug#8410).
8664db06 10593
6abdaa4a
PE
10594 * xselect.c (x_get_local_selection, x_handle_property_notify):
10595 Remove vars that are set but not used.
10596
0ce7538d 10597 * xfns.c (x_create_tip_frame): Remove var that is set but not used.
6abdaa4a 10598 (make_invisible_cursor): Initialize a possibly-uninitialized variable.
0ce7538d 10599
9ae848fc
PE
10600 * xterm.c (x_scroll_bar_to_input_event) [!USE_GTK]:
10601 Remove var that is set but not used.
0b918413
PE
10602 (scroll_bar_windows_size): Now size_t, not int.
10603 (x_send_scroll_bar_event): Use size_t, not int, for sizes.
10604 Check for overflow.
9ae848fc 10605
a5a62657
PE
10606 * xfaces.c (realize_named_face): Remove vars that are set but not used.
10607 (map_tty_color) [!defined MSDOS]: Likewise.
10608
5c5cdd39
PE
10609 * term.c (tty_write_glyphs): Use size_t; this avoids overflow warning.
10610
66ebf983
PE
10611 * coding.c: Remove vars that are set but not used.
10612 (DECODE_COMPOSITION_RULE): Remove 2nd arg, which is unused.
10613 All callers changed.
10614 (decode_coding_utf_8, decode_coding_utf_16 decode_coding_emacs_mule):
10615 (decode_coding_iso_2022, encode_coding_sjis, encode_coding_big5):
10616 (decode_coding_charset): Remove vars that are set but not used.
10617
1be4d761
PE
10618 * bytecode.c (Fbyte_code) [!defined BYTE_CODE_SAFE]: Remove var
10619 that is set but not used.
10620
47553fa8
PE
10621 * print.c (print_object): Remove var that is set but not used.
10622
1f7196bf 10623 Replace 2 copies of readlink code with 1 gnulib version (Bug#8401).
d1fdcab7
PE
10624 The gnulib version avoids calling malloc in the usual case,
10625 and on 64-bit hosts doesn't have some arbitrary 32-bit limits.
10626 * fileio.c (Ffile_symlink_p): Use emacs_readlink.
10627 * filelock.c (current_lock_owner): Likewise.
10628 * lisp.h (READLINK_BUFSIZE, emacs_readlink): New function.
10629 * sysdep.c: Include allocator.h, careadlinkat.h.
10630 (emacs_no_realloc_allocator): New static constant.
10631 (emacs_readlink): New function.
fdb61804
PE
10632 * deps.mk (sysdep.o): Depend on ../lib/allocator.h and on
10633 ../lib/careadlinkat.h.
d1fdcab7 10634
f84c17c7
SM
106352011-04-04 Stefan Monnier <monnier@iro.umontreal.ca>
10636
10637 * keyboard.c (safe_run_hook_funcall): Fix last change (don't stop at the
10638 first non-nil return value).
10639
ef3862ad
JD
106402011-04-03 Jan Djärv <jan.h.d@swipnet.se>
10641
10642 * nsterm.m (ns_update_auto_hide_menu_bar): Define MAC_OS_X_VERSION_10_6
10643 if not defined (Bug#8403).
10644
376a7006
JB
106452011-04-02 Juanma Barranquero <lekktu@gmail.com>
10646
10647 * xdisp.c (display_count_lines): Remove parameter `start',
10648 unused since 1998-01-01T02:27:27Z!rms@gnu.org. All callers changed.
10649 (get_char_face_and_encoding): Remove parameter `multibyte_p',
10650 unused since 2008-05-14T01:40:23Z!handa@m17n.org. All callers changed.
10651 (fill_stretch_glyph_string): Remove parameters `row' and `area',
10652 unused at least since Kim's GUI unification at 2003-03-16T20:45:46Z!storm@cua.dk
10653 and thereabouts. All callers changed.
10654 (get_per_char_metric): Remove parameter `f', unused since
10655 2008-05-14T01:40:23Z!handa@m17n.org. All callers changed.
10656
6ca3801d
JM
106572011-04-02 Jim Meyering <meyering@redhat.com>
10658
10659 do not dereference NULL upon failed strdup
10660 * nsfont.m (ns_descriptor_to_entity): Use xstrdup, not strdup.
10661 (ns_get_family): Likewise.
10662
d8e2b5ba
JB
106632011-04-02 Juanma Barranquero <lekktu@gmail.com>
10664
10665 * eval.c (unwind_to_catch) [DEBUG_GCPRO]: Remove redundant assignment.
10666
8c74fcbd
JD
106672011-04-02 Jan Djärv <jan.h.d@swipnet.se>
10668
10669 * nsterm.m (ns_update_auto_hide_menu_bar): Only for OSX 10.6 or
10670 later (Bug#8403).
10671
7200d79c
SM
106722011-04-01 Stefan Monnier <monnier@iro.umontreal.ca>
10673
03408648 10674 Add lexical binding.
7200d79c 10675
03408648
SM
10676 * window.c (Ftemp_output_buffer_show): New fun.
10677 (Fsave_window_excursion):
10678 * print.c (Fwith_output_to_temp_buffer): Move to subr.el.
10679
10680 * lread.c (lisp_file_lexically_bound_p): New function.
10681 (Fload): Bind Qlexical_binding.
10682 (readevalloop): Remove `evalfun' arg.
10683 Bind Qinternal_interpreter_environment.
10684 (Feval_buffer): Bind Qlexical_binding.
10685 (defvar_int, defvar_bool, defvar_lisp_nopro, defvar_kboard):
10686 Mark as dynamic.
10687 (syms_of_lread): Declare `lexical-binding'.
10688
10689 * lisp.h (struct Lisp_Symbol): New field `declared_special'.
10690
10691 * keyboard.c (eval_dyn): New fun.
10692 (menu_item_eval_property): Use it.
ca105506
SM
10693
10694 * image.c (parse_image_spec): Use Ffunctionp.
ca105506 10695
03408648
SM
10696 * fns.c (concat, mapcar1): Accept byte-code-functions.
10697
10698 * eval.c (Fsetq): Handle lexical vars.
10699 (Fdefun, Fdefmacro, Ffunction): Make closures when needed.
10700 (Fdefconst, Fdefvaralias, Fdefvar): Mark as dynamic.
10701 (FletX, Flet): Obey lexical binding.
10702 (Fcommandp): Handle closures.
10703 (Feval): New `lexical' arg.
10704 (eval_sub): New function extracted from Feval. Use it almost
10705 everywhere where Feval was used. Look up vars in lexical env.
10706 Handle closures.
10707 (Ffunctionp): Move from subr.el.
10708 (Ffuncall): Handle closures.
10709 (apply_lambda): Remove `eval_flags'.
10710 (funcall_lambda): Handle closures and new byte-code-functions.
10711 (Fspecial_variable_p): New function.
10712 (syms_of_eval): Initialize the Vinternal_interpreter_environment var,
10713 but without exporting it to Lisp.
23aba0ea 10714
23aba0ea 10715 * doc.c (Fdocumentation, store_function_docstring):
03408648 10716 * data.c (Finteractive_form): Handle closures.
23aba0ea 10717
03408648
SM
10718 * callint.c (Fcall_interactively): Preserve lexical-binding mode for
10719 interactive spec.
ba83908c 10720
04f2d78b
CB
10721 * bytecode.c (Bstack_ref, Bstack_set, Bstack_set2, BdiscardN):
10722 New byte-codes.
03408648
SM
10723 (exec_byte_code): New function extracted from Fbyte_code to handle new
10724 calling convention for byte-code-functions. Add new byte-codes.
ba83908c 10725
03408648 10726 * buffer.c (defvar_per_buffer): Set new `declared_special' field.
e2abe5a1 10727
03408648 10728 * alloc.c (Fmake_symbol): Init new `declared_special' field.
e2abe5a1 10729
e2abce01
JB
107302011-03-31 Juanma Barranquero <lekktu@gmail.com>
10731
10732 * xdisp.c (redisplay_internal): Fix prototype.
10733
63696a73 107342011-03-31 Eli Zaretskii <eliz@gnu.org>
09725d26 10735
63696a73 10736 * xdisp.c (SCROLL_LIMIT): New macro.
04f2d78b
CB
10737 (try_scrolling): Use it when setting scroll_limit.
10738 Limit scrolling to 100 screen lines.
63696a73
EZ
10739 (redisplay_window): Even when falling back on "recentering",
10740 position point in the window according to scroll-conservatively,
10741 scroll-margin, and scroll-*-aggressively variables. (Bug#6671)
10742
10743 (try_scrolling): When point is above the window, allow searching
10744 as far as scroll_max, or one screenful, to compute vertical
10745 distance from PT to the scroll margin position. This prevents
10746 try_scrolling from unnecessarily failing when
10747 scroll-conservatively is set to a value slightly larger than the
10748 window height. Clean up the case of PT below the margin at bottom
10749 of window: scroll_max can no longer be INT_MAX. When aggressive
10750 scrolling is in use, don't let point enter the opposite scroll
10751 margin as result of the scroll.
10752 (syms_of_xdisp) <scroll-conservatively>: Document the
09725d26
EZ
10753 threshold of 100 lines for never-recentering scrolling.
10754
e4cc2dfc
JB
107552011-03-31 Juanma Barranquero <lekktu@gmail.com>
10756
10757 * dispextern.h (move_it_by_lines):
10758 * xdisp.c (move_it_by_lines): Remove parameter `need_y_p', unused
10759 since 2000-12-29T14:24:09Z!gerd@gnu.org. All callers changed.
10760 (message_log_check_duplicate): Remove parameters `prev_bol' and
10761 `this_bol', unused since 1998-01-01T02:27:27Z!rms@gnu.org. All callers changed.
10762 (redisplay_internal): Remove parameter `preserve_echo_area',
10763 unused since 1999-07-21T21:43:52Z!gerd@gnu.org. All callers changed.
10764
10765 * indent.c (Fvertical_motion):
10766 * window.c (window_scroll_pixel_based, Frecenter):
10767 Don't pass `need_y_p' to `move_it_by_lines'.
10768
1c470562
SM
107692011-03-30 Stefan Monnier <monnier@iro.umontreal.ca>
10770
44f230aa
SM
10771 * eval.c (struct backtrace): Don't cheat with negative numbers, but do
10772 steal a few bits to be more compact.
10773 (interactive_p, Fbacktrace, Fbacktrace_frame, mark_backtrace):
10774 Remove unneeded casts.
10775
1c470562
SM
10776 * bytecode.c (Fbyte_code): CAR and CDR can GC.
10777
888adce9
ZK
107782011-03-30 Zachary Kanfer <zkanfer@gmail.com> (tiny change)
10779
10780 * keyboard.c (Fexecute_extended_command): Do log the "suggest key
10781 binding" message (bug#7967).
10782
f838ed7b
PE
107832011-03-30 Paul Eggert <eggert@cs.ucla.edu>
10784
77861b95
PE
10785 Fix more problems found by GCC 4.6.0's static checks.
10786
de6dbc14
PE
10787 * unexelf.c (unexec) [! (defined _SYSTYPE_SYSV || defined __sgi)]:
10788 Remove unused local var.
10789
f838ed7b
PE
10790 * editfns.c (Fmessage_box): Remove unused local var.
10791
792c7b2b
PE
10792 * xdisp.c (try_window_reusing_current_matrix, x_produce_glyphs):
10793 (note_mode_line_or_margin_highlight, note_mouse_highlight):
10794 Omit unused local vars.
c499e557 10795 * window.c (shrink_windows): Omit unused local var.
b01a1c29 10796 * menu.c (digest_single_submenu): Omit unused local var.
0bc32927
PE
10797 * dispnew.c (update_window) [PERIODIC_PREEMPTION_CHECKING]:
10798 Omit unused local var.
10799
ba0165e1
PE
10800 * keyboard.c (parse_modifiers_uncached, parse_modifiers):
10801 Don't assume string length fits in int.
32ad8845 10802 (keyremap_step, read_key_sequence): Use size_t for sizes.
48011560 10803 (read_key_sequence): Don't check last_real_key_start redundantly.
ba0165e1 10804
3c59b4c9
PE
10805 * callproc.c (Fcall_process, Fcall_process_region): Use SAFE_ALLOCA
10806 instead of alloca (Bug#8344).
10807
a3eed478 10808 * eval.c (Fbacktrace): Don't assume nargs fits in int.
5d5d959d 10809 (Fbacktrace_frame): Don't assume nframes fits in int.
a3eed478 10810
eb4d412d
PE
10811 * syntax.c (scan_sexps_forward): Avoid pointer wraparound.
10812
1658b401
PE
10813 * xterm.c (x_make_frame_visible, same_x_server): Redo to avoid overflow
10814 concerns.
10815
10816 * term.c (produce_glyphless_glyph): Remove unnecessary test.
10817
10818 * cm.c (calccost): Turn while-do into do-while, for clarity.
44f730c8 10819
9a2c6e05
PE
10820 * keyboard.c (syms_of_keyboard): Use the same style as later
10821 in this function when indexing through an array. This also
10822 works around GCC bug 48267.
10823
03d0a109
PE
10824 * image.c (tiff_load): Fix off-by-one image count (Bug#8336).
10825
44f730c8
PE
10826 * xselect.c (x_check_property_data): Return correct size (Bug#8335).
10827
fe75f926
PE
10828 * chartab.c (sub_char_table_ref_and_range): Redo for slight
10829 efficiency gain, and to bypass a gcc -Wstrict-overflow warning.
10830
ffa8c828
PE
10831 * keyboard.c, keyboard.h (num_input_events): Now size_t.
10832 This avoids undefined behavior on integer overflow, and is a bit
10833 more convenient anyway since it is compared to a size_t variable.
10834
c5101a77
PE
10835 Variadic C functions now count arguments with size_t, not int.
10836 This avoids an unnecessary limitation on 64-bit machines, which
10837 caused (substring ...) to crash on large vectors (Bug#8344).
10838 * lisp.h (struct Lisp_Subr.function.aMANY): Now takes size_t, not int.
10839 (DEFUN_ARGS_MANY, internal_condition_case_n, safe_call): Likewise.
77861b95 10840 All variadic functions and their callers changed accordingly.
c5101a77
PE
10841 (struct gcpro.nvars): Now size_t, not int. All uses changed.
10842 * data.c (arith_driver, float_arith_driver): Likewise.
10843 * editfns.c (general_insert_function): Likewise.
10844 * eval.c (struct backtrace.nargs, interactive_p)
10845 (internal_condition_case_n, run_hook_with_args, apply_lambda)
10846 (funcall_lambda, mark_backtrace): Likewise.
10847 * fns.c (concat): Likewise.
10848 * frame.c (x_set_frame_parameters): Likewise.
10849 * fns.c (get_key_arg): Now accepts and returns size_t, and returns
10850 0 if not found, not -1. All callers changed.
10851
dd3f25f7
PE
10852 * alloc.c (garbage_collect): Don't assume stack size fits in int.
10853 (stack_copy_size): Now size_t, not int.
10854 (stack_copy, stack_copy_size): Define only if MAX_SAVE_STACK > 0.
10855
461c2ab9
JB
108562011-03-28 Juanma Barranquero <lekktu@gmail.com>
10857
10858 * coding.c (encode_designation_at_bol): Remove parameter `charbuf_end',
10859 unused since 2002-03-01T01:17:24Z!handa@m17n.org and 2008-02-01T16:01:31Z!miles@gnu.org.
10860 All callers changed.
10861
10862 * lisp.h (multibyte_char_to_unibyte):
10863 * character.c (multibyte_char_to_unibyte): Remove parameter `rev_tbl',
10864 unused since 2002-03-01T01:16:34Z!handa@m17n.org and 2008-02-01T16:01:31Z!miles@gnu.org.
10865 * character.h (CHAR_TO_BYTE8):
10866 * cmds.c (internal_self_insert):
10867 * editfns.c (general_insert_function):
10868 * keymap.c (push_key_description):
10869 * search.c (Freplace_match):
10870 * xdisp.c (message_dolog, set_message_1): All callers changed.
10871
f6d62986
SM
108722011-03-28 Stefan Monnier <monnier@iro.umontreal.ca>
10873
10874 * keyboard.c (safe_run_hook_funcall): New function.
10875 (safe_run_hooks_1, safe_run_hooks_error, safe_run_hooks): On error,
10876 don't set the hook to nil, but remove the offending function instead.
10877 (Qcommand_hook_internal): Remove, unused.
10878 (syms_of_keyboard): Don't initialize Qcommand_hook_internal nor define
10879 Vcommand_hook_internal.
10880
10881 * eval.c (enum run_hooks_condition): Remove.
10882 (funcall_nil, funcall_not): New functions.
10883 (run_hook_with_args): Call each function through a `funcall' argument.
10884 Remove `cond' argument, now redundant.
10885 (Frun_hooks, Frun_hook_with_args, Frun_hook_with_args_until_success)
10886 (Frun_hook_with_args_until_failure): Adjust accordingly.
10887 (run_hook_wrapped_funcall, Frun_hook_wrapped): New functions.
10888
1db5b1ad
JB
108892011-03-28 Juanma Barranquero <lekktu@gmail.com>
10890
10891 * dispextern.h (string_buffer_position): Remove declaration.
10892
10893 * print.c (strout): Remove parameter `multibyte', unused since
10894 1999-08-21T19:30:21Z!gerd@gnu.org. All callers changed.
10895
10896 * search.c (boyer_moore): Remove parameters `len', `pos' and `lim',
10897 never used since function introduction in 1998-02-08T21:33:56Z!rms@gnu.org.
10898 All callers changed.
10899
10900 * w32.c (_wsa_errlist): Use braces for struct initializers.
10901
10902 * xdisp.c (string_buffer_position_lim): Remove parameter `w',
10903 never used since function introduction in 2001-03-09T18:41:50Z!gerd@gnu.org.
10904 All callers changed.
10905 (string_buffer_position): Likewise. Also, make static (it's never
10906 used outside xdisp.c).
10907 (cursor_row_p): Remove parameter `w', unused since
10908 2000-10-17T16:08:57Z!gerd@gnu.org. All callers changed.
10909 (decode_mode_spec): Remove parameter `precision', introduced during
10910 Gerd Moellmann's rewrite at 1999-07-21T21:43:52Z!gerd@gnu.org, but never used.
10911 All callers changed.
10912
5ffb62aa
JD
109132011-03-27 Jan Djärv <jan.h.d@swipnet.se>
10914
10915 * nsterm.m (syms_of_nsterm): Use doc: for ns-auto-hide-menu-bar.
10916
461c2ab9 109172011-03-27 Anders Lindgren <andlind@gmail.com>
f0a1382a
JD
10918
10919 * nsterm.m (ns_menu_bar_is_hidden): New variable.
10920 (ns_constrain_all_frames, ns_menu_bar_should_be_hidden)
10921 (ns_update_auto_hide_menu_bar): New functions.
10922 (ns_update_begin): Call ns_update_auto_hide_menu_bar.
10923 (applicationDidBecomeActive): Call ns_update_auto_hide_menu_bar and
10924 ns_constrain_all_frames.
10925 (constrainFrameRect): Return at once if ns_menu_bar_should_be_hidden.
10926 (syms_of_nsterm): DEFVAR ns-auto-hide-menu-bar, init to Qnil.
10927
5c380ffb
JD
109282011-03-27 Jan Djärv <jan.h.d@swipnet.se>
10929
10930 * nsmenu.m (runDialogAt): Remove argument to timer_check.
10931
9af30bdf
GM
109322011-03-27 Glenn Morris <rgm@gnu.org>
10933
10934 * syssignal.h: Replace RETSIGTYPE with void.
10935 * atimer.c, data.c, dispnew.c, emacs.c, floatfns.c, keyboard.c:
10936 * keyboard.h, lisp.h, process.c, sysdep.c, xterm.c:
10937 Replace SIGTYPE with void everywhere.
10938 * s/usg5-4-common.h (SIGTYPE): Remove definition.
10939 * s/template.h (SIGTYPE): Remove commented out definition.
10940
e2abce01
JB
109412011-03-26 Eli Zaretskii <eliz@gnu.org>
10942
10943 * xdisp.c (redisplay_window): Don't check buffer's clip_changed
10944 flag as a prerequisite for invoking try_scrolling. (Bug#6671)
10945
f868cd8a
JB
109462011-03-26 Juanma Barranquero <lekktu@gmail.com>
10947
59eb0929
JB
10948 * w32.c (read_unc_volume): Use parameter `henum', instead of
10949 global variable `wget_enum_handle'.
10950
10951 * keymap.c (describe_vector): Remove parameters `indices' and
10952 `char_table_depth', unused since 2002-03-01T01:43:26Z!handa@m17n.org.
10953 (describe_map, Fdescribe_vector): Adjust calls to `describe_vector'.
10954
f868cd8a
JB
10955 * keyboard.h (timer_check, show_help_echo): Remove unused parameters.
10956
10957 * keyboard.c (timer_check): Remove parameter `do_it_now',
10958 unused since 1996-04-12T06:01:29Z!rms@gnu.org.
10959 (show_help_echo): Remove parameter `ok_to_overwrite_keystroke_echo',
10960 unused since 2008-04-19T19:30:53Z!monnier@iro.umontreal.ca.
10961
10962 * keyboard.c (read_char):
10963 * w32menu.c (w32_menu_display_help):
10964 * xmenu.c (show_help_event, menu_help_callback):
10965 Adjust calls to `show_help_echo'.
10966
10967 * gtkutil.c (xg_maybe_add_timer):
10968 * keyboard.c (readable_events):
10969 * process.c (wait_reading_process_output):
10970 * xmenu.c (x_menu_wait_for_event): Adjust calls to `timer_check'.
10971
10972 * insdel.c (adjust_markers_gap_motion):
10973 Remove; no-op since 1998-01-02T21:29:48Z!rms@gnu.org.
10974 (gap_left, gap_right): Don't call it.
10975
2ecf6fdb
CY
109762011-03-25 Chong Yidong <cyd@stupidchicken.com>
10977
10978 * xdisp.c (handle_fontified_prop): Discard changes to clip_changed
10979 incurred during fontification.
10980
6b1f9ba4
JB
109812011-03-25 Juanma Barranquero <lekktu@gmail.com>
10982
10983 * buffer.c (defvar_per_buffer): Remove unused parameter `doc'.
10984 (DEFVAR_PER_BUFFER): Don't pass it.
10985
10986 * dispnew.c (row_equal_p, add_row_entry): Remove unused parameter `w'.
10987 (scrolling_window): Don't pass it.
10988
0f4a96b5
JB
109892011-03-25 Juanma Barranquero <lekktu@gmail.com>
10990
10991 * dispextern.h (glyph_matric): Use #if GLYPH_DEBUG, not #ifdef.
10992
10993 * fileio.c (check_executable) [DOS_NT]: Remove unused variables `len'
10994 and `suffix'.
10995 (Fset_file_selinux_context) [HAVE_LIBSELINUX]: Move here declaration
10996 of variables specific to SELinux and computation of `encoded_absname'.
10997
10998 * image.c (XPutPixel): Remove unused variable `height'.
10999
11000 * keyboard.c (make_lispy_event): Remove unused variable `hpos'.
11001
11002 * unexw32.c (get_section_info): Remove unused variable `section'.
11003
11004 * w32.c (stat): Remove unused variables `drive_root' and `devtype'.
11005 (system_process_attributes): Remove unused variable `sess'.
11006 (sys_read): Remove unused variable `err'.
11007
11008 * w32fns.c (top): Wrap variables with #if GLYPH_DEBUG, not #ifdef.
11009 (w32_wnd_proc): Remove unused variable `isdead'.
11010 (unwind_create_frame): Use #if GLYPH_DEBUG, not #ifdef.
11011 (Fx_server_max_request_size): Remove unused variable `dpyinfo'.
11012 (x_create_tip_frame): Remove unused variable `tem'.
11013
11014 * w32inevt.c (w32_console_read_socket):
11015 Remove unused variable `no_events'.
11016
11017 * w32term.c (x_draw_composite_glyph_string_foreground):
11018 Remove unused variable `width'.
11019
1149507c
JB
110202011-03-24 Juanma Barranquero <lekktu@gmail.com>
11021
11022 * w32term.c (x_set_glyph_string_clipping):
11023 Don't pass uninitialized region to CombineRgn.
11024
9c88f339
JB
110252011-03-23 Juanma Barranquero <lekktu@gmail.com>
11026
11027 * w32fns.c (x_set_menu_bar_lines): Remove unused variable `olines'.
11028 (w32_wnd_proc): Pass NULL to Windows API, not uninitialized buffer.
11029 (Fx_close_connection): Remove unused variable `i'.
11030
11031 * w32font.c (w32font_draw): Return number of glyphs.
11032 (w32font_open_internal): Remove unused variable `i'.
11033 (w32font_driver): Add missing initializer.
11034
11035 * w32menu.c (utf8to16): Remove unused variable `utf16'.
11036 (fill_in_menu): Remove unused variable `items_added'.
11037
11038 * w32term.c (last_mouse_press_frame): Remove static global variable.
11039 (w32_clip_to_row): Remove unused variable `f'.
11040 (x_delete_terminal): Remove unused variable `i'.
11041
11042 * w32uniscribe.c (uniscribe_shape): Remove unused variable `nclusters'.
11043 (NOTHING): Remove unused static global variable.
11044 (uniscribe_check_otf): Remove unused variable `table'.
11045 (uniscribe_font_driver): Add missing initializers.
11046
dee091a3
JD
110472011-03-23 Julien Danjou <julien@danjou.info>
11048
11049 * term.c (Fsuspend_tty, Fresume_tty):
11050 * minibuf.c (read_minibuf, run_exit_minibuf_hook):
11051 * window.c (temp_output_buffer_show):
11052 * insdel.c (signal_before_change):
11053 * frame.c (Fhandle_switch_frame):
11054 * fileio.c (Fdo_auto_save):
11055 * emacs.c (Fkill_emacs):
11056 * editfns.c (save_excursion_restore):
11057 * cmds.c (internal_self_insert):
11058 * callint.c (Fcall_interactively):
11059 * buffer.c (Fkill_all_local_variables):
11060 * keyboard.c (Fcommand_execute, Fsuspend_emacs, safe_run_hooks_1):
11061 Use Frun_hooks.
0f4a96b5 11062 (command_loop_1): Use Frun_hooks. Call safe_run_hooks
e9fce1ac 11063 unconditionally since it does the check itself.
dee091a3 11064
2c520ab5 110652011-03-23 Paul Eggert <eggert@cs.ucla.edu>
f0641eff 11066
c9c49752
PE
11067 Fix more problems found by GCC 4.5.2's static checks.
11068
8abc3f12
PE
11069 * coding.c (encode_coding_raw_text): Avoid unnecessary test
11070 the first time through the loop, since we know p0 < p1 then.
11071 This also avoids a gcc -Wstrict-overflow warning.
11072
a2d26660
PE
11073 * lisp.h (SAFE_ALLOCA, SAFE_ALLOCA_LISP): Avoid 'int' overflow
11074 leading to a memory leak, possible in functions like
11075 load_charset_map_from_file that can allocate an unbounded number
b12ef411 11076 of objects (Bug#8318).
a2d26660 11077
916c72e9
PE
11078 * xmenu.c (set_frame_menubar): Use EMACS_UINT, not int, for indexes
11079 that could (at least in theory) be that large.
11080
19ab8a18
PE
11081 * xdisp.c (message_log_check_duplicate): Return unsigned long, not int.
11082 This is less likely to overflow, and avoids undefined behavior if
11083 overflow does occur. All callers changed. Use strtoul to scan
11084 for the unsigned long integer.
b7cbbd6f
PE
11085 (pint2hrstr): Simplify and tune code slightly.
11086 This also avoids a (bogus) GCC warning with gcc -Wstrict-overflow.
19ab8a18 11087
f0641eff
PE
11088 * scroll.c (do_scrolling): Work around GCC bug 48228.
11089 See <http://gcc.gnu.org/bugzilla/show_bug.cgi?id=48228>.
11090
7f650bb9
PE
11091 * frame.c (Fmodify_frame_parameters): Simplify loop counter.
11092 This also avoids a warning with gcc -Wstrict-overflow.
39f5e519
PE
11093 (validate_x_resource_name): Simplify count usage.
11094 This also avoids a warning with gcc -Wstrict-overflow.
7f650bb9 11095
37dd57d1
PE
11096 * fileio.c (Fcopy_file): Report error if fchown or fchmod
11097 fail (Bug#8306).
81e56e61 11098
699979fc 11099 * emacs.c (Fdaemon_initialized): Do not ignore I/O errors (Bug#8303).
dc1ca6a8 11100
401bf9b4
PE
11101 * process.c (Fmake_network_process): Use socklen_t, not int,
11102 where POSIX says socklen_t is required in portable programs.
11103 This fixes a porting bug on hosts like 64-bit HP-UX, where
591b2973 11104 socklen_t is wider than int (Bug#8277).
401bf9b4
PE
11105 (Fmake_network_process, server_accept_connection):
11106 (wait_reading_process_output, read_process_output):
11107 Likewise.
11108
b93aacde
PE
11109 * process.c: Rename or move locals to avoid shadowing.
11110 (list_processes_1, Fmake_network_process):
11111 (read_process_output_error_handler, exec_sentinel_error_handler):
11112 Rename or move locals.
4dc343ee 11113 (Fmake_network_process): Define label "retry_connect" only if needed.
0da49335 11114 (Fnetwork_interface_info): Fix pointer signedness.
f990b4e5 11115 (process_send_signal): Add cast to avoid pointer signedness problem.
7b808126 11116 (FIRST_PROC_DESC, IF_NON_BLOCKING_CONNECT): Remove unused macros.
c939f91b 11117 (create_process): Use 'volatile' to avoid vfork clobbering (Bug#8298).
b93aacde 11118
af8a867c 11119 Make tparam.h and terminfo.c consistent.
44f230aa
SM
11120 * cm.c (tputs, tgoto, BC, UP): Remove extern decls.
11121 Include tparam.h instead, since it declares them.
af8a867c
PE
11122 * cm.h (PC): Remove extern decl; tparam.h now does this.
11123 * deps.mk (cm.o, terminfo.o): Depend on tparam.h.
11124 * terminfo.c: Include tparam.h, to check interfaces.
11125 (tparm): Make 1st arg a const pointer in decl. Put it at top level.
11126 (tparam): Adjust signature to match interface in tparam.h;
11127 this removes some undefined behavior. Check that outstring and len
11128 are zero, which they always are with Emacs.
11129 * tparam.h (PC, BC, UP): New extern decls.
11130
0248044d 11131 * xftfont.c (xftfont_shape): Now static, and defined only if needed.
001a7ab4 11132 (xftfont_open): Rename locals to avoid shadowing.
0248044d 11133
8ff096c1 11134 * ftfont.c (ftfont_resolve_generic_family): Fix pointer signedness.
a00924bb
PE
11135 (ftfont_otf_capability, ftfont_shape): Omit decls if not needed.
11136 (OTF_TAG_SYM): Omit macro if not needed.
e932860f 11137 (ftfont_list): Remove unused local.
49eaafba
PE
11138 (get_adstyle_property, ftfont_pattern_entity):
11139 (ftfont_lookup_cache, ftfont_open, ftfont_anchor_point):
11140 Rename locals to avoid shadowing.
8ff096c1 11141
e2be39f6
PE
11142 * xfont.c (xfont_list_family): Mark var as initialized.
11143
c9735e30
PE
11144 * xml.c (make_dom): Now static.
11145
8f5201ae
PE
11146 * composite.c (composition_compute_stop_pos): Rename local to
11147 avoid shadowing.
b246f932
PE
11148 (composition_reseat_it): Remove unused locals.
11149 (find_automatic_composition, composition_adjust_point): Likewise.
80e079b2 11150 (composition_update_it): Mark var as initialized.
11b61122
PE
11151 (find_automatic_composition): Mark vars as initialized,
11152 with a FIXME (Bug#8290).
8f5201ae 11153
760fbc2c
PE
11154 character.h: Rename locals to avoid shadowing.
11155 * character.h (PREV_CHAR_BOUNDARY, FETCH_STRING_CHAR_ADVANCE):
11156 (FETCH_STRING_CHAR_AS_MULTIBYTE_ADVANCE, FETCH_CHAR_ADVANCE):
11157 (FETCH_CHAR_ADVANCE_NO_CHECK, INC_POS, DEC_POS, BUF_INC_POS):
11158 (BUF_DEC_POS): Be more systematic about renaming local temporaries
11159 to avoid shadowing.
11160
ff08eb85
PE
11161 * textprop.c (property_change_between_p): Remove; unused.
11162
fc7bf025
PE
11163 * intervals.c (interval_start_pos): Now static.
11164
235d7abc
PE
11165 * intervals.h (CHECK_TOTAL_LENGTH): Avoid empty "else".
11166
44f230aa
SM
11167 * atimer.c (start_atimer, append_atimer_lists, set_alarm):
11168 Rename locals to avoid shadowing.
3e7d6594 11169
50060332
PE
11170 * sound.c (wav_play, au_play, Fplay_sound_internal):
11171 Fix pointer signedness.
d01f234b 11172 (alsa_choose_format): Remove unused local var.
c83b8872
PE
11173 (wav_play): Initialize a variable to 0, to prevent undefined
11174 behavior (Bug#8278).
50060332 11175
c4fc4e30
PE
11176 * region-cache.c (insert_cache_boundary): Redo var to avoid shadowing.
11177
918436ed
PE
11178 * region-cache.h (pp_cache): New decl, for gcc -Wmissing-prototypes.
11179
c939f91b
PE
11180 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork
11181 clobbering (Bug#8298).
b9c7f648
PE
11182 * sysdep.c (sys_subshell): Likewise.
11183 Previously, the sys_subshell 'volatile' was incorrectly IF_LINTted out.
7e9123a2 11184
6bd8c144
PE
11185 * lisp.h (child_setup): Now NO_RETURN unless DOS_NT.
11186 This should get cleaned up, so that child_setup has the
11187 same signature on all platforms.
11188
7710357c 11189 * callproc.c (call_process_cleanup): Now static.
cb1d0ef7 11190 (relocate_fd): Rename locals to avoid shadowing.
7710357c 11191
c59da222
CY
111922011-03-22 Chong Yidong <cyd@stupidchicken.com>
11193
11194 * xterm.c (x_clear_frame): Remove XClearWindow call. This appears
11195 not to be necessary, and produces flickering.
11196
66b87493
GM
111972011-03-20 Glenn Morris <rgm@gnu.org>
11198
11199 * config.in: Remove file.
11200
45b6f6d5
JB
112012011-03-20 Juanma Barranquero <lekktu@gmail.com>
11202
11203 * minibuf.c (Vcompleting_read_function): Don't declare, global variables
11204 are now in src/globals.h.
11205 (syms_of_minibuf): Remove spurious & from previous change.
11206
cd394be1 112072011-03-20 Leo Liu <sdl.web@gmail.com>
3ec03f7e
LL
11208
11209 * minibuf.c (completing-read-function): New variable.
11210 (completing-read-default): Rename from completing-read.
11211 (completing-read): Call completing-read-function.
11212
b14e3e21
CY
112132011-03-19 Juanma Barranquero <lekktu@gmail.com>
11214
11215 * xfaces.c (Fx_load_color_file):
11216 Read color file from absolute filename (bug#8250).
11217
f2b726e6
JB
112182011-03-19 Juanma Barranquero <lekktu@gmail.com>
11219
11220 * makefile.w32-in: Update dependencies.
11221
09f6ff02
EZ
112222011-03-17 Eli Zaretskii <eliz@gnu.org>
11223
11224 * makefile.w32-in ($(BLD)/unexw32.$(O)): Depend on $(SRC)/unexec.h.
11225
29a6015a
PE
112262011-03-17 Paul Eggert <eggert@cs.ucla.edu>
11227
a3a6c54e
PE
11228 Fix more problems found by GCC 4.5.2's static checks.
11229
b766f867
PE
11230 * process.c (make_serial_process_unwind, send_process_trap):
11231 (sigchld_handler): Now static.
11232
be02381c
PE
11233 * process.c (allocate_pty): Let PTY_ITERATION declare iteration vars.
11234 That way, the code declares only the vars that it needs.
11235 * s/aix4-2.h (PTY_ITERATION): Declare iteration vars.
11236 * s/cygwin.h (PTY_ITERATION): Likewise.
11237 * s/darwin.h (PTY_ITERATION): Likewise.
11238 * s/gnu-linux.h (PTY_ITERATION): Likewise.
11239
57048744
PE
11240 * s/irix6-5.h (PTY_OPEN): Declare stb, to loosen coupling.
11241 * process.c (allocate_pty): Don't declare stb unless it's needed.
11242
7914961c 11243 * bytecode.c (MAYBE_GC): Rewrite so as not to use empty "else".
615f2d59
PE
11244 (CONSTANTLIM): Remove; unused.
11245 (METER_CODE, Bscan_buffer, Bread_char, Bset_mark):
11246 Define only if needed.
7914961c 11247
b3967b18
PE
11248 * unexelf.c (unexec): Name an expression,
11249 to avoid gcc -Wbad-function-cast warning.
9ae71512
PE
11250 Use a different way to cause a compilation error if anyone uses
11251 n rather than nn, a way that does not involve shadowing.
73366a00 11252 (ELF_BSS_SECTION_NAME, OLD_PROGRAM_H): Remove; unused.
b3967b18 11253
29a6015a
PE
11254 * deps.mk (unexalpha.o): Remove; unused.
11255
43cfc33e 11256 New file unexec.h, the (simple) interface for unexec (Bug#8267).
7feda0d2 11257 * unexec.h: New file.
ce701a33
PE
11258 * deps.mk (emacs.o, unexaix.o, unexcw.o, unexcoff.o, unexelf.o):
11259 (unexhp9k800.o, unexmacosx.o, unexsol.o, unexw32.o):
11260 Depend on unexec.h.
11261 * emacs.c [!defined CANNOT_DUMP]: Include unexec.h.
11262 * unexaix.c, unexcoff.c, unexcw.c, unexelf.c, unexhp9k800.c:
11263 * unexmacosx.c, unexsol.c, unexw32.c: Include unexec.h.
381259ef 11264 Change as necessary to match prototype in unexec.h.
ce701a33 11265
01f44d5a
PE
11266 * syntax.c (Fforward_comment, scan_lists): Rename locals to avoid
11267 shadowing.
4f63c6bb 11268 (back_comment, skip_chars): Mark vars as initialized.
01f44d5a 11269
a6670b0b
PE
11270 * character.h (FETCH_STRING_CHAR_ADVANCE_NO_CHECK, BUF_INC_POS):
11271 Rename locals to avoid shadowing.
11272
cef2010d 11273 * lread.c (read1): Rewrite so as not to use empty "else".
0902fe45 11274 (Fload, readevalloop, read1): Rename locals to avoid shadowing.
cef2010d 11275
d4d7173a
PE
11276 * print.c (Fredirect_debugging_output): Fix pointer signedess.
11277
f08b802a
PE
11278 * lisp.h (debug_output_compilation_hack): Add decl here, to avoid
11279 warning when compiling print.c.
11280
3ddb0639
PE
11281 * font.c (font_unparse_fcname): Abort in an "impossible" situation
11282 instead of using an uninitialized var.
5ad03b97 11283 (font_sort_entities): Mark var as initialized.
3ddb0639 11284
170a2692
PE
11285 * character.h (FETCH_CHAR_ADVANCE): Rename locals to avoid shadowing.
11286
e663c700
PE
11287 * font.c (font_unparse_xlfd): Don't mix pointers to variables with
11288 pointers to constants.
89bc529a 11289 (font_parse_fcname): Remove unused vars.
7b81e2d0 11290 (font_delete_unmatched): Now static.
ea838e10 11291 (font_get_spec): Remove; unused.
13a547c6
PE
11292 (font_style_to_value, font_prop_validate_style, font_unparse_fcname):
11293 (font_update_drivers, Ffont_get_glyphs, font_add_log):
11294 Rename or move locals to avoid shadowing.
e663c700 11295
2a80c887 11296 * fns.c (require_nesting_list, require_unwind): Now static.
612f56df 11297 (Ffillarray): Rename locals to avoid shadowing.
2a80c887 11298
1384fa33 11299 * floatfns.c (domain_error2): Define only if needed.
a885e2ed 11300 (Ffrexp, Fldexp): Rename locals to avoid shadowing.
1384fa33 11301
8b2c52e9
PE
11302 * alloc.c (mark_backtrace): Move decl from here ...
11303 * lisp.h: ... to here, so that it can be checked.
11304
475545b5 11305 * eval.c (call_debugger, do_debug_on_call, grow_specpdl): Now static.
d28a2170 11306 (Fdefvar): Rewrite so as not to use empty "else".
cfcbfb1a
PE
11307 (lisp_indirect_variable): Name an expression,
11308 to avoid gcc -Wbad-function-cast warning.
1faed8ae 11309 (Fdefvar): Rename locals to avoid shadowing.
475545b5 11310
b1349114 11311 * callint.c (quotify_arg, quotify_args): Now static.
a3e8cbda 11312 (Fcall_interactively): Rename locals to avoid shadowing.
b0e80955 11313 Use const pointer when appropriate.
b1349114 11314
a2928364
PE
11315 * lisp.h (get_system_name, get_operating_system_release):
11316 Move decls here, to check interfaces.
11317 * process.c (get_operating_system_release): Move decl to lisp.h.
11318 * xrdb.c (get_system_name): Likewise.
63c5d10b
PE
11319 * editfns.c (init_editfns, Fuser_login_name, Fuser_uid):
11320 (Fuser_real_uid, Fuser_full_name): Remove unnecessary casts,
11321 some of which prompt warnings from gcc -Wbad-function-cast.
545b49b4
PE
11322 (Fformat_time_string, Fencode_time, Finsert_char):
11323 (Ftranslate_region_internal, Fformat):
11324 Rename or remove local vars to avoid shadowing.
9710023e 11325 (Ftranslate_region_internal): Mark var as initialized.
63c5d10b 11326
a415e694
PE
11327 * doc.c (Fdocumentation, Fsnarf_documentation): Move locals to
11328 avoid shadowing.
11329
8ef4622d
PE
11330 * lisp.h (eassert): Check that the argument compiles, even if
11331 ENABLE_CHECKING is not defined.
11332
946f9a5b
PE
11333 * data.c (Findirect_variable): Name an expression, to avoid
11334 gcc -Wbad-function-cast warning.
112396d6 11335 (default_value, arithcompare, arith_driver, arith_error): Now static.
b9b84fa9 11336 (store_symval_forwarding): Rename local to avoid shadowing.
44f230aa
SM
11337 (Fmake_variable_buffer_local, Fmake_local_variable):
11338 Mark variables as initialized.
52746918 11339 (do_blv_forwarding, do_symval_forwarding): Remove; unused.
946f9a5b 11340
e5aab7e7 11341 * alloc.c (check_cons_list): Do not define unless GC_CHECK_CONS_LIST.
ae35e756
PE
11342 (Fmake_vector, Fvector, Fmake_byte_code, Fgarbage_collect):
11343 Rename locals to avoid shadowing.
dff45157
PE
11344 (mark_stack): Move local variables into the #ifdef region where
11345 they're used.
7bc26fdb
PE
11346 (BLOCK_INPUT_ALLOC, UNBLOCK_INPUT_ALLOC): Define only if
11347 ! defined SYSTEM_MALLOC && ! defined SYNC_INPUT, as they are not
11348 needed otherwise.
11349 (CHECK_ALLOCATED): Define only if GC_CHECK_MARKED_OBJECTS.
11350 (GC_STRING_CHARS): Remove; not used.
d40d4be1 11351 (Fmemory_limit): Cast sbrk's returned value to char *.
ae35e756 11352
e5aab7e7
PE
11353 * lisp.h (check_cons_list): Declare if GC_CHECK_CONS_LIST; this
11354 avoids undefined behavior in theory.
11355
4da60324
PE
11356 * regex.c (IF_LINT): Add defn, for benefit of ../lib-src.
11357
88043301
PE
11358 Use functions, not macros, for up- and down-casing (Bug#8254).
11359 * buffer.h (DOWNCASE_TABLE, UPCASE_TABLE, DOWNCASE, UPPERCASEP):
11360 (NOCASEP, LOWERCASEP, UPCASE, UPCASE1): Remove. All callers changed
11361 to use the following functions instead of these macros.
11362 (downcase): Adjust to lack of DOWNCASE_TABLE. Return int, not
11363 EMACS_INT, since callers assume the returned value fits in int.
11364 (upcase1): Likewise, for UPCASE_TABLE.
11365 (uppercasep, lowercasep, upcase): New static inline functions.
0da09c43 11366 * editfns.c (Fchar_equal): Remove no-longer-needed workaround for
db69b0cd 11367 the race-condition problem in the old DOWNCASE.
88043301 11368
19ed5445
PE
11369 * regex.c (CHARSET_LOOKUP_RANGE_TABLE_RAW, POP_FAILURE_REG_OR_COUNT):
11370 Rename locals to avoid shadowing.
11371 (regex_compile, re_match_2_internal): Move locals to avoid shadowing.
abbd1bcf
PE
11372 (regex_compile, re_search_2, re_match_2_internal):
11373 Remove unused local vars.
952db0d7
PE
11374 (FREE_VAR): Rewrite so as not to use empty "else",
11375 which gcc can warn about.
da053e48 11376 (regex_compile, re_match_2_internal): Mark locals as initialized.
b313f9d8
PE
11377 (RETALLOC_IF): Define only if needed.
11378 (WORDCHAR_P): Likewise. This one is never needed, but is used
11379 only in a comment talking about a compiler bug, so put inside
11380 the #if 0 of that comment.
11381 (CHARSET_LOOKUP_BITMAP, FAIL_STACK_FULL, RESET_FAIL_STACK):
11382 (PUSH_FAILURE_ELT, BUF_PUSH_3, STOP_ADDR_VSTRING):
11383 Remove; unused.
19ed5445 11384
1f3561e4 11385 * search.c (boyer_moore): Rename locals to avoid shadowing.
76ef09b7
PE
11386 * character.h (FETCH_STRING_CHAR_AS_MULTIBYTE_ADVANCE):
11387 (PREV_CHAR_BOUNDARY): Likewise.
1f3561e4 11388
ded6f8f7
PE
11389 * search.c (simple_search): Remove unused var.
11390
dbd37a95
PE
11391 * dired.c (compile_pattern): Move decl from here ...
11392 * lisp.h: ... to here, so that it can be checked.
11393 (struct re_registers): New forward decl.
11394
7e47afad
PE
11395 * character.h (INC_POS, DEC_POS): Rename locals to avoid shadowing.
11396
85f24f61
PE
11397 * indent.c (MULTIBYTE_BYTES_WIDTH): New args bytes, width.
11398 All uses changed.
11399 (MULTIBYTE_BYTES_WIDTH, scan_for_column, compute_motion):
11400 Rename locals to avoid shadowing.
5671df8f 11401 (Fvertical_motion): Mark locals as initialized.
85f24f61 11402
181aa2be 11403 * casefiddle.c (casify_object, casify_region): Now static.
e45a141a 11404 (casify_region): Mark local as initialized.
181aa2be 11405
930d429c
PE
11406 * cmds.c (internal_self_insert): Rename local to avoid shadowing.
11407
7082eac6
PE
11408 * lisp.h (GCPRO2_VAR, GCPRO3_VAR, GCPRO4_VAR, GCPRO5_VAR, GCPRO6_VAR):
11409 New macros, so that the caller can use some names other than
11410 gcpro1, gcpro2, etc.
11411 (GCPRO2, GCPRO3, GCPRO4, GCPRO5, GCPRO6): Reimplement in terms
11412 of the new macros.
11413 (GCPRO1_VAR, UNGCPRO_VAR): Change the meaning of the second
11414 argument, for consistency with GCPRO2_VAR, etc: it is now the
11415 prefix of the variable, not the variable itself. All uses
11416 changed.
38b2c076
PE
11417 * dired.c (directory_files_internal, file_name_completion):
11418 Rename locals to avoid shadowing.
11419
15206ed9
PE
11420 Fix a race condition diagnosed by gcc -Wsequence-point (Bug#8254).
11421 An expression of the form (DOWNCASE (x) == DOWNCASE (y)), found in
11422 dired.c's scmp function, had undefined behavior.
11423 * lisp.h (DOWNCASE_TABLE, UPCASE_TABLE, DOWNCASE, UPPERCASEP):
11424 (NOCASEP, LOWERCASEP, UPCASE, UPCASE1): Move from here ...
11425 * buffer.h: ... to here, because these macros use current_buffer,
11426 and the new implementation with inline functions needs to have
11427 current_buffer in scope now, rather than later when the macros
11428 are used.
11429 (downcase, upcase1): New static inline functions.
11430 (DOWNCASE, UPCASE1): Reimplement using these functions.
11431 This avoids undefined behavior in expressions like
11432 DOWNCASE (x) == DOWNCASE (y), which previously suffered
11433 from race conditions in accessing the global variables
11434 case_temp1 and case_temp2.
11435 * casetab.c (case_temp1, case_temp2): Remove; no longer needed.
11436 * lisp.h (case_temp1, case_temp2): Remove their decls.
11437 * character.h (ASCII_CHAR_P): Move from here ...
11438 * lisp.h: ... to here, so that the inline functions mentioned
11439 above can use them.
11440
4a6bea26
PE
11441 * dired.c (directory_files_internal_unwind): Now static.
11442
f14b7e14
PE
11443 * fileio.c (file_name_as_directory, directory_file_name):
11444 (barf_or_query_if_file_exists, auto_save_error, auto_save_1):
11445 Now static.
2893f146
PE
11446 (file_name_as_directory): Use const pointers when appropriate.
11447 (Fexpand_file_name): Likewise. In particular, newdir might
11448 point at constant storage, so make it a const pointer.
fd4ead52 11449 (Fmake_directory_internal, Fread_file_name): Remove unused vars.
b14aac08
PE
11450 (Ffile_selinux_context, Fset_file_selinux_context): Fix pointer
11451 signedness issues.
f839df0c
PE
11452 (Fset_file_times, Finsert_file_contents, auto_save_error):
11453 Rename locals to avoid shadowing.
f14b7e14 11454
5716756e 11455 * minibuf.c (choose_minibuf_frame_1): Now static.
62137a95
PE
11456 (Ftry_completion, Fall_completions): Rename or remove locals
11457 to avoid shadowing.
5716756e 11458
b4c3046a
PE
11459 * marker.c (bytepos_to_charpos): Remove; unused.
11460
b45db522
PE
11461 * lisp.h (verify_bytepos, count_markers): New decls,
11462 so that gcc does not warn that these functions aren't declared.
11463
85876d07
PE
11464 * insdel.c (check_markers, make_gap_larger, make_gap_smaller):
11465 (reset_var_on_error, Fcombine_after_change_execute_1): Now static.
f0cb4a60 11466 (CHECK_MARKERS): Redo to avoid gcc -Wempty-body diagnostic.
40ef059e 11467 (copy_text): Remove unused local var.
85876d07 11468
03d78a21 11469 * filelock.c (within_one_second): Now static.
b3dd38ab 11470 (lock_file_1): Rename local to avoid shadowing.
03d78a21 11471
5df8f01b
PE
11472 * buffer.c (fix_overlays_before): Mark locals as initialized.
11473 (fix_start_end_in_overlays): Likewise. This function should be
11474 simplified by using pointers-to-pointers, but that's a different
11475 matter.
b1d876f1 11476 (switch_to_buffer_1): Now static.
8f54f30a
PE
11477 (Fkill_buffer, record_buffer, Fbury_buffer, Fset_buffer_multibyte):
11478 (report_overlay_modification): Rename locals to avoid shadowing.
c3bd59b5 11479
a70072c9 11480 * sysdep.c (system_process_attributes): Rename vars to avoid shadowing.
fbd02d7b 11481 Fix pointer signedness issue.
edced198
PE
11482 (sys_subshell): Mark local as volatile if checking for lint,
11483 to suppress a gcc -Wclobbered warning that does not seem to be right.
15dfd3d9 11484 (MAXPATHLEN): Define only if needed.
a70072c9 11485
a0977c44
PE
11486 * process.c (serial_open, serial_configure): Move decls from here ...
11487 * systty.h: ... to here, so that they can be checked.
11488
a884fdcc
PE
11489 * fns.c (get_random, seed_random): Move extern decls from here ...
11490 * lisp.h: ... to here, so that they can be checked.
11491
604efe86 11492 * sysdep.c (reset_io): Now static.
b8950c94 11493 (wait_for_termination_signal): Remove; unused.
604efe86 11494
38fc62d9
PE
11495 * keymap.c (keymap_parent, keymap_memberp, map_keymap_internal):
11496 (copy_keymap_item, append_key, push_text_char_description):
11497 Now static.
1004a21a 11498 (Fwhere_is_internal): Don't test CONSP (sequences) unnecessarily.
dbbb8427 11499 (DENSE_TABLE_SIZE): Remove; unused.
c1141155
PE
11500 (get_keymap, access_keymap, Fdefine_key, Fwhere_is_internal):
11501 (describe_map_tree):
11502 Rename locals to avoid shadowing.
38fc62d9 11503
2f2650da
PE
11504 * keyboard.c: Declare functions static if they are not used elsewhere.
11505 (echo_char, echo_dash, cmd_error, top_level_2):
11506 (poll_for_input, handle_async_input): Now static.
69a058fa
PE
11507 (read_char, kbd_buffer_get_event, make_lispy_position):
11508 (make_lispy_event, make_lispy_movement, apply_modifiers):
11509 (decode_keyboard_code, tty_read_avail_input, menu_bar_items):
11510 (parse_tool_bar_item, read_key_sequence, Fread_key_sequence):
11511 (Fread_key_sequence_vector): Rename locals to avoid shadowing.
c8a06054 11512 (read_key_sequence, read_char): Mark locals as initialized.
3ac94672 11513 (Fexit_recursive_edit, Fabort_recursive_edit): Mark with NO_RETURN.
2f2650da 11514
a053e86c 11515 * keyboard.h (make_ctrl_char): New decl.
da2f2dd9
PE
11516 (mark_kboards): Move decl here ...
11517 * alloc.c (mark_kboards): ... from here.
a053e86c 11518
4752793e
PE
11519 * lisp.h (force_auto_save_soon): New decl.
11520
74f10ca7 11521 * emacs.c (init_cmdargs): Rename local to avoid shadowing.
244fc23d
PE
11522 (DEFINE_DUMMY_FUNCTION): New macro.
11523 (__do_global_ctors, __do_global_ctors_aux, __do_global_dtors, __main):
11524 Use it.
c03cd23f
PE
11525 (main): Add casts to avoid warnings
11526 if GCC considers string literals to be constants.
74f10ca7 11527
022e70d4
PE
11528 * lisp.h (fatal_error_signal): Add decl, since it's exported.
11529
59d6fe83
PE
11530 * dbusbind.c: Pointer signedness fixes.
11531 (xd_signature, xd_append_arg, xd_initialize):
11532 (Fdbus_call_method, Fdbus_call_method_asynchronously):
11533 (Fdbus_method_return_internal, Fdbus_method_error_internal):
11534 (Fdbus_send_signal, xd_read_message_1, Fdbus_register_service):
11535 (Fdbus_register_signal): Use SSDATA when the context wants char *.
11536
78320123
PE
11537 * dbusbind.c (Fdbus_init_bus): Add cast to avoid warning
11538 if GCC considers string literals to be constants.
49cebcca 11539 (Fdbus_register_service, Fdbus_register_method): Remove unused vars.
78320123 11540
35ac2a97
SM
115412011-03-16 Stefan Monnier <monnier@iro.umontreal.ca>
11542
fb103ca9
SM
11543 * print.c (PRINT_CIRCLE_CANDIDATE_P): New macro.
11544 (print_preprocess, print_object): New macro to fix last change.
11545
35ac2a97
SM
11546 * print.c (print_preprocess): Don't forget font objects.
11547
62973b41
JB
115482011-03-16 Juanma Barranquero <lekktu@gmail.com>
11549
11550 * emacs.c (USAGE3): Doc fixes.
11551
0e48bb22
AS
115522011-03-15 Andreas Schwab <schwab@linux-m68k.org>
11553
11554 * coding.c (detect_coding_iso_2022): Reorganize code to clarify
11555 structure.
11556
7684e57b
JB
115572011-03-14 Juanma Barranquero <lekktu@gmail.com>
11558
11559 * lisp.h (VWindow_system, Qfile_name_history):
11560 * keyboard.h (lispy_function_keys) [WINDOWSNT]:
11561 * w32term.h (w32_system_caret_hwnd, w32_system_caret_height)
11562 (w32_system_caret_x, w32_system_caret_y): Declare extern.
11563
11564 * w32select.c: Don't #include "keyboard.h".
c96bbc66 11565 (run_protected): Add extern declaration for waiting_for_input.
7684e57b
JB
11566
11567 * w32.c (Qlocal, noninteractive1, inhibit_window_system):
11568 * w32console.c (detect_input_pending, read_input_pending)
11569 (encode_terminal_code):
11570 * w32fns.c (quit_char, lispy_function_keys, Qtooltip)
11571 (w32_system_caret_hwnd, w32_system_caret_height, w32_system_caret_x)
11572 (w32_system_caret_y, Qfile_name_history):
11573 * w32font.c (w32font_driver, QCantialias, QCotf, QClang):
11574 * w32inevt.c (reinvoke_input_signal, lispy_function_keys):
11575 * w32menu.c (Qmenu_bar, QCtoggle, QCradio, Qoverriding_local_map)
11576 (Qoverriding_terminal_local_map, Qmenu_bar_update_hook):
11577 * w32proc.c (Qlocal, report_file_error):
11578 * w32term.c (Vwindow_system, updating_frame):
11579 * w32uniscribe.c (initialized, uniscribe_font_driver):
11580 Remove unneeded extern declarations.
11581
2aa46d6c
CY
115822011-03-14 Chong Yidong <cyd@stupidchicken.com>
11583
c96bbc66 11584 * buffer.c (Fmake_indirect_buffer): Fix incorrect assertions.
2aa46d6c 11585
cffc6f3b
CY
115862011-03-13 Chong Yidong <cyd@stupidchicken.com>
11587
11588 * buffer.h (BUF_BEGV, BUF_BEGV_BYTE, BUF_ZV, BUF_ZV_BYTE, BUF_PT)
11589 (BUF_PT_BYTE): Rewrite to handle indirect buffers (Bug#8219).
11590 These macros can no longer be used for assignment.
11591
44f230aa
SM
11592 * buffer.c (Fget_buffer_create, Fmake_indirect_buffer):
11593 Assign struct members directly, instead of using BUF_BEGV etc.
cffc6f3b
CY
11594 (record_buffer_markers, fetch_buffer_markers): New functions for
11595 recording and fetching special buffer markers.
11596 (set_buffer_internal_1, set_buffer_temp): Use them.
11597
11598 * lread.c (unreadchar): Use SET_BUF_PT_BOTH.
11599
11600 * insdel.c (adjust_point): Use SET_BUF_PT_BOTH.
11601
11602 * intervals.c (temp_set_point_both): Use SET_BUF_PT_BOTH.
11603 (get_local_map): Use SET_BUF_BEGV_BOTH and SET_BUF_ZV_BOTH.
11604
11605 * xdisp.c (hscroll_window_tree):
11606 (reconsider_clip_changes): Use PT instead of BUF_PT.
11607
d251f04b
EZ
116082011-03-13 Eli Zaretskii <eliz@gnu.org>
11609
11610 * makefile.w32-in ($(BLD)/editfns.$(O)): Depend on
11611 $(EMACS_ROOT)/lib/intprops.h.
11612
f0c77cd1
PE
116132011-03-13 Paul Eggert <eggert@cs.ucla.edu>
11614
3eca4629
PE
11615 Fix more problems found by GCC 4.5.2's static checks.
11616
7c86ee98
PE
11617 * gtkutil.c (xg_get_pixbuf_from_pixmap): Add cast from char *
11618 to unsigned char * to avoid compiler diagnostic.
b0afc268
PE
11619 (xg_free_frame_widgets): Make it clear that a local variable is
11620 needed only if USE_GTK_TOOLTIP.
01e0b5ad
PE
11621 (gdk_window_get_screen): Make it clear that this macro is needed
11622 only if USE_GTK_TOOLTIP.
1e5524e7
PE
11623 (int_gtk_range_get_value): New function, which avoids a diagnostic
11624 from gcc -Wbad-function-cast.
11625 (xg_set_toolkit_scroll_bar_thumb): Use it.
11626 (xg_tool_bar_callback, xg_tool_item_stale_p): Rewrite to avoid
11627 diagnostic from gcc -Wbad-function-cast.
65dc836c
PE
11628 (get_utf8_string, xg_get_file_with_chooser):
11629 Rename locals to avoid shadowing.
11630 (create_dialog): Move locals to avoid shadowing.
7c86ee98 11631
41729b81
PE
11632 * xgselect.c (xg_select): Remove unused var.
11633
f0c77cd1
PE
11634 * image.c (four_corners_best): Mark locals as initialized.
11635 (gif_load): Initialize transparent_p to zero (Bug#8238).
11636 Mark another local as initialized.
ec6cf4c6 11637 (my_png_error, my_error_exit): Mark with NO_RETURN.
f0c77cd1 11638
ce0ad53d 11639 * image.c (clear_image_cache): Now static.
d5d5a617 11640 (DIM, HAVE_STDLIB_H_1): Remove unused macros.
e22cffbc 11641 (xpm_load): Redo to avoid "discards qualifiers" gcc warning.
77a765fd
PE
11642 (x_edge_detection): Remove unnecessary cast that
11643 gcc -Wbad-function-cast diagnoses.
2037898d 11644 (gif_load): Fix pointer signedness.
6ae141d6
PE
11645 (clear_image_cache, xbm_read_bitmap_data, x_detect_edges):
11646 (jpeg_load, gif_load): Rename locals to avoid shadowing.
ce0ad53d 11647
33383987 116482011-03-12 Paul Eggert <eggert@cs.ucla.edu>
3eca4629 11649
d32df629
PE
11650 Improve quality of tests for time stamp overflow.
11651 For example, without this patch (encode-time 0 0 0 1 1
11652 1152921504606846976) returns the obviously-bogus value (-948597
11653 62170) on my RHEL 5.5 x86-64 host. With the patch, it correctly
11654 reports time overflow. See
11655 <http://lists.gnu.org/archive/html/emacs-devel/2011-03/msg00470.html>.
b8d9bd41
PE
11656 * deps.mk (editfns.o): Depend on ../lib/intprops.h.
11657 * editfns.c: Include limits.h and intprops.h.
11658 (TIME_T_MIN, TIME_T_MAX): New macros.
11659 (time_overflow): Move earlier, to before first use.
11660 (hi_time, lo_time): New functions, for an accurate test for
11661 out-of-range times.
11662 (Fcurrent_time, Fget_internal_run_time, make_time): Use them.
11663 (Fget_internal_run_time): Don't assume time_t fits in int.
11664 (make_time): Use list2 instead of Fcons twice.
11665 (Fdecode_time): More accurate test for out-of-range times.
11666 (check_tm_member): New function.
11667 (Fencode_time): Use it, to test for out-of-range times.
d32df629
PE
11668 (lisp_time_argument): Don't rely on undefined left-shift and
11669 right-shift behavior when checking for time stamp overflow.
8be6f318 11670
fe31d94c
PE
11671 * editfns.c (time_overflow): New function, refactoring common code.
11672 (Fformat_time_string, Fdecode_time, Fencode_time):
11673 (Fcurrent_time_string): Use it.
11674
8be6f318
PE
11675 Move 'make_time' to be next to its inverse 'lisp_time_argument'.
11676 * dired.c (make_time): Move to ...
11677 * editfns.c (make_time): ... here.
11678 * systime.h: Note the move.
11679
09d9db2c 116802011-03-12 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
c47cbdfd 11681
126bc0dc
YM
11682 * fringe.c (update_window_fringes): Remove unused variables.
11683
c47cbdfd
YM
11684 * unexmacosx.c (copy_data_segment): Also copy __got section.
11685 (Bug#8223)
11686
7ac80be9
EZ
116872011-03-12 Eli Zaretskii <eliz@gnu.org>
11688
c96bbc66 11689 * termcap.c [MSDOS]: Include "msdos.h".
058e5dad
EZ
11690 (find_capability, tgetnum, tgetflag, tgetstr, tputs, tgetent):
11691 Constify `char *' arguments and their references according to
11692 prototypes in tparam.h.
11693
ecb0f94d 11694 * deps.mk (termcap.o): Depend on tparam.h and msdos.h.
058e5dad 11695
7ac80be9
EZ
11696 * msdos.c (XMenuAddPane): 3rd argument is `const char *' now.
11697 Adapt all references accordingly.
11698
11699 * msdos.h (XMenuAddPane): 3rd argument is `const char *' now.
11700
ef1fd07e
TT
117012011-03-11 Tom Tromey <tromey@redhat.com>
11702
11703 * buffer.c (syms_of_buffer): Remove obsolete comment.
11704
7ef4b50c
EZ
117052011-03-11 Eli Zaretskii <eliz@gnu.org>
11706
11707 * termhooks.h (encode_terminal_code): Declare prototype.
11708
11709 * msdos.c (encode_terminal_code): Don't declare prototype.
11710
11711 * term.c (encode_terminal_code): Now external again, used by
11712 w32console.c and msdos.c.
11713
44f230aa
SM
11714 * makefile.w32-in ($(BLD)/term.$(O), ($(BLD)/tparam.$(O)):
11715 Depend on $(SRC)/tparam.h, see 2011-03-11T07:24:21Z!eggert@cs.ucla.edu.
7ef4b50c 11716
4b1ec863 117172011-03-11 Paul Eggert <eggert@cs.ucla.edu>
f78faa98 11718
1714f52b 11719 Fix some minor problems found by GCC 4.5.2's static checks.
83316bf4 11720
4b1ec863
PE
11721 * fringe.c (update_window_fringes): Mark locals as initialized
11722 (Bug#8227).
11723 (destroy_fringe_bitmap, init_fringe_bitmap): Now static.
bf60f616 11724
524c7aa6
PE
11725 * alloc.c (mark_fringe_data): Move decl from here ...
11726 * lisp.h (mark_fringe_data) [HAVE_WINDOW_SYSTEM]: ... to here,
11727 to check its interface.
11728 (init_fringe_once): Do not declare unless HAVE_WINDOW_SYSTEM.
11729
a5c0af81 11730 * fontset.c (free_realized_fontset): Now static.
7519b8cd 11731 (Fset_fontset_font): Rename local to avoid shadowing.
cc6e5db1 11732 (fontset_font): Mark local as initialized.
a9a06e0b 11733 (FONTSET_SPEC, FONTSET_REPERTORY, RFONT_DEF_REPERTORY): Remove; unused.
a5c0af81 11734
b4716021
PE
11735 * xrdb.c: Include "xterm.h", to check x_load_resources's interface.
11736
811e9bac 11737 * xselect.c (x_disown_buffer_selections): Remove; not used.
7b83e2f1 11738 (TRACE3) [!defined TRACE_SELECTION]: Remove; not used.
aa0daa9f
PE
11739 (x_own_selection, Fx_disown_selection_internal): Rename locals
11740 to avoid shadowing.
11741 (x_handle_dnd_message): Remove local to avoid shadowing.
811e9bac 11742
7e3ab302
PE
11743 * lisp.h (GCPRO1_VAR, UNGCPRO_VAR): New macros,
11744 so that the caller can use some name other than gcpro1.
11745 (GCPRO1, UNGCPRO): Reimplement in terms of the new macros.
58d2d479
PE
11746 * xfns.c (Fx_create_frame, x_create_tip_frame, Fx_show_tip):
11747 (Fx_backspace_delete_keys_p):
11748 Use them to avoid shadowing, and rename vars to avoid shadowing.
11749 (x_decode_color, x_set_name, x_window): Now static.
6b437900 11750 (Fx_create_frame): Add braces to silence GCC warning.
c0951e53 11751 (Fx_file_dialog, Fx_select_font): Fix pointer signedness.
06b0c8a0
PE
11752 (x_real_positions, xg_set_icon_from_xpm_data, x_create_tip_frame):
11753 Remove unused locals.
7e3ab302
PE
11754 (Fx_create_frame, x_create_tip_frame, Fx_show_tip):
11755 (Fx_backspace_delete_keys_p): Rename locals to avoid shadowing.
11756 Some of these renamings use the new GCPRO1_VAR and UNGCPRO_VAR
11757 macros.
f78faa98 11758
e2b13473
PE
11759 * xterm.h (x_mouse_leave): New decl.
11760
77f23912
PE
11761 * xterm.c (x_copy_dpy_color, x_focus_on_frame, x_unfocus_frame):
11762 Remove unused functions.
cdf4ba58
PE
11763 (x_shift_glyphs_for_insert, XTflash, XTring_bell):
11764 (x_calc_absolute_position): Now static.
7411c686 11765 (XTread_socket): Don't define label "out" unless it's used.
2b07bcff 11766 Don't declare local "event" unless it's used.
ed7bf3a5
PE
11767 (x_iconify_frame, x_free_frame_resources): Don't declare locals
11768 unless they are used.
38d0b34a
PE
11769 (XEMBED_VERSION, xembed_set_info): Don't define unless needed.
11770 (x_fatal_error_signal): Remove; not used.
a6067996
PE
11771 (x_draw_image_foreground, redo_mouse_highlight, XTmouse_position):
11772 (x_scroll_bar_report_motion, handle_one_xevent, x_draw_bar_cursor):
11773 (x_error_catcher, x_connection_closed, x_error_handler):
11774 (x_error_quitter, xembed_send_message, x_iconify_frame):
11775 (my_log_handler): Rename locals to avoid shadowing.
28f1c698 11776 (x_delete_glyphs, x_ins_del_lines): Mark with NO_RETURN.
2a8fade0 11777 (x_connection_closed): Tell GCC not to suggest NO_RETURN.
77f23912 11778
44f230aa
SM
11779 * xfaces.c (clear_face_cache, Fx_list_fonts, Fface_font):
11780 Rename or move locals to avoid shadowing.
6b463e58 11781 (tty_defined_color, merge_face_heights): Now static.
5967d051 11782 (free_realized_faces_for_fontset): Remove; not used.
1e9966ea
PE
11783 (Fx_list_fonts): Mark variable that gcc -Wuninitialized
11784 does not deduce is never used uninitialized.
73719eba
PE
11785 (STRDUPA, LSTRDUPA, FONT_POINT_SIZE_QUANTUM): Remove; not used.
11786 (LFACEP): Define only if XASSERTS, as it's not needed otherwise.
071048a3 11787
426994c3 11788 * terminal.c (store_terminal_param): Now static.
5489860b 11789
032f1620 11790 * xmenu.c (menu_highlight_callback): Now static.
9d66f88e 11791 (set_frame_menubar): Remove unused local.
d4323972 11792 (xmenu_show): Rename parameter to avoid shadowing.
6d1f7fee
PE
11793 (xmenu_show, xdialog_show, xmenu_show): Make local pointers "const"
11794 since they might point to immutable storage.
281585b0
PE
11795 (next_menubar_widget_id): Declare only if USE_X_TOOLKIT,
11796 since it's unused otherwise.
032f1620 11797
367c19e5 11798 * xdisp.c (produce_glyphless_glyph): Initialize lower_xoff.
53df7c11 11799 Add a FIXME, since the code still doesn't look right. (Bug#8215)
9f36b9fd
PE
11800 (Fcurrent_bidi_paragraph_direction): Simplify slightly; this
11801 avoids a gcc -Wuninitialized diagnostic.
0e086e8f 11802 (display_line, BUILD_COMPOSITE_GLYPH_STRING, draw_glyphs):
44a3a108
PE
11803 (note_mouse_highlight): Mark variables that gcc -Wuninitialized
11804 does not deduce are never used uninitialized.
70739cbe 11805
07b48fa9
PE
11806 * lisp.h (IF_LINT): New macro, copied from ../lib-src/emacsclient.c.
11807
8868a238 11808 * xdisp.c (redisplay_window): Rename local to avoid shadowing.
4554d213
PE
11809 * window.c (window_loop, size_window):
11810 (run_window_configuration_change_hook, enlarge_window): Likewise.
8868a238 11811
7e5cf297 11812 * window.c (display_buffer): Now static.
d6550a9f
PE
11813 (size_window): Mark variables that gcc -Wuninitialized
11814 does not deduce are never used uninitialized.
a586633d
PE
11815 * window.h (check_all_windows): New decl, to forestall
11816 gcc -Wmissing-prototypes diagnostic.
5b555da1 11817 * dispextern.h (bidi_dump_cached_states): Likewise.
7e5cf297 11818
f6095868
PE
11819 * charset.h (CHECK_CHARSET_GET_CHARSET): Rename locals to avoid
11820 shadowing.
11821 * charset.c (map_charset_for_dump, Fchar_charset): Likewise.
726929c4
PE
11822 Include <limits.h>.
11823 (Fsort_charsets): Redo min/max calculation to shorten the code a bit
11824 and to avoid gcc -Wuninitialized warning.
89ef49df
PE
11825 (load_charset_map): Mark variables that gcc -Wuninitialized
11826 does not deduce are never used uninitialized.
53df7c11 11827 (load_charset): Abort instead of using uninitialized var (Bug#8229).
f6095868 11828
f38b440c
PE
11829 * coding.c (coding_set_source, coding_set_destination):
11830 Use "else { /* comment */ }" rather than "else /* comment */;"
11831 for clarity, and to avoid gcc -Wempty-body warning.
2735d060
PE
11832 (Fdefine_coding_system_internal): Don't redeclare 'i' inside
11833 a block, when the outer 'i' will do.
11834 (decode_coding_utf_8, decode_coding_utf_16, detect_coding_emacs_mule):
11835 (emacs_mule_char, decode_coding_emacs_mule, detect_coding_iso_2022):
11836 (decode_coding_iso_2022, decode_coding_sjis, decode_coding_big5):
11837 (decode_coding_raw_text, decode_coding_charset, get_translation_table):
11838 (Fdecode_sjis_char, Fdefine_coding_system_internal):
11839 Rename locals to avoid shadowing.
11840 * character.h (FETCH_STRING_CHAR_ADVANCE): Likewise.
e2f1bab9
PE
11841 * coding.c (emacs_mule_char, encode_invocation_designation):
11842 Now static, since they're not used elsewhere.
413bb2db 11843 (decode_coding_iso_2022): Add "default: abort ();" as a safety check.
c4a63b12 11844 (decode_coding_object, encode_coding_object, detect_coding_system):
ee05f961
PE
11845 (decode_coding_emacs_mule): Mark variables that gcc
11846 -Wuninitialized does not deduce are never used uninitialized.
160b01f6
PE
11847 (detect_coding_iso_2022): Initialize a local variable that might
11848 be used uninitialized. Leave a FIXME because it's not clear that
53df7c11 11849 this initialization is needed. (Bug#8211)
5f58e762
PE
11850 (ISO_CODE_LF, ISO_CODE_CR, CODING_ISO_FLAG_EUC_TW_SHIFT):
11851 (ONE_MORE_BYTE_NO_CHECK, UTF_BOM, UTF_16_INVALID_P):
11852 (SHIFT_OUT_OK, ENCODE_CONTROL_SEQUENCE_INTRODUCER):
11853 (ENCODE_DIRECTION_R2L, ENCODE_DIRECTION_L2R):
11854 Remove unused macros.
f38b440c 11855
232b38b9 11856 * category.c (hash_get_category_set): Remove unused local var.
9f3b5e69 11857 (copy_category_table): Now static, since it's not used elsewhere.
d0891610 11858 * character.c (string_count_byte8): Likewise.
232b38b9 11859
fb90da1b
PE
11860 * ccl.c (CCL_WRITE_STRING, CCL_ENCODE_CHAR, Fccl_execute_on_string):
11861 (Fregister_code_conversion_map): Rename locals to avoid shadowing.
11862
fb93dbc2
PE
11863 * chartab.c (copy_sub_char_table): Now static, since it's not used
11864 elsewhere.
5c156ace
PE
11865 (sub_char_table_ref_and_range, char_table_ref_and_range):
11866 Rename locals to avoid shadowing.
bbcd0949 11867 (ASET_RANGE, GET_SUB_CHAR_TABLE): Remove unused macros.
fb93dbc2 11868
7d3b3862 11869 * bidi.c (bidi_check_type): Now static, since it's not used elsewhere.
630d6892 11870 (BIDI_BOB): Remove unused macro.
7d3b3862 11871
6be7d3da
PE
11872 * cm.c (cmgoto): Mark variables that gcc -Wuninitialized does not
11873 deduce are never used uninitialized.
c2ed9c8b 11874 * term.c (encode_terminal_code): Likewise.
6be7d3da 11875
75f8807f 11876 * term.c (encode_terminal_code): Now static. Remove unused local.
72abad34 11877
50938595
PE
11878 * tparam.h: New file.
11879 * term.c, tparam.h: Include it.
11880 * deps.mk (term.o, tparam.o): Depend on tparam.h.
11881 * term.c (tputs, tgetent, tgetflag, tgetnum, tparam, tgetstr):
11882 Move these decls to tparam.h, and make them agree with what
11883 is actually in tparam.c. The previous trick of using incompatible
11884 decls in different modules does not conform to the C standard.
11885 All callers of tparam changed to use tparam's actual API.
11886 * tparam.c (tparam1, tparam, tgoto):
11887 Use const pointers where appropriate.
11888
fbceeba2
PE
11889 * cm.c (calccost, cmgoto): Use const pointers where appropriate.
11890 * cm.h (struct cm): Likewise.
11891 * dispextern.h (do_line_insertion_deletion_costs): Likewise.
11892 * scroll.c (ins_del_costs, do_line_insertion_deletion_costs): Likewise.
11893 * term.c (tty_ins_del_lines, calculate_costs, struct fkey_table):
11894 (term_get_fkeys_1, append_glyphless_glyph, produce_glyphless_glyph):
11895 (turn_on_face, init_tty): Likewise.
11896 * termchar.h (struct tty_display_info): Likewise.
fbceeba2 11897
7f3f1250
PE
11898 * term.c (term_mouse_position): Rename local to avoid shadowing.
11899
e6ca6543
PE
11900 * alloc.c (mark_ttys): Move decl from here ...
11901 * lisp.h (mark_ttys): ... to here, so that it's checked against defn.
11902
c40f8d15
AS
119032011-03-11 Andreas Schwab <schwab@linux-m68k.org>
11904
11905 * .gdbinit (pwinx, xbuffer): Fix access to buffer name.
11906
cfe0661d
JB
119072011-03-09 Juanma Barranquero <lekktu@gmail.com>
11908
11909 * search.c (compile_pattern_1): Remove argument regp, unused since
11910 revid:rms@gnu.org-19941211082627-3x1g1wyqkjmwloig.
11911 (compile_pattern): Don't pass it.
11912
0afb4571
J
119132011-03-08 Jan Djärv <jan.h.d@swipnet.se>
11914
11915 * xterm.h (DEFAULT_GDK_DISPLAY): New define.
11916 (GDK_WINDOW_XID, gtk_widget_get_preferred_size): New defines
11917 for ! HAVE_GTK3.
11918 (GTK_WIDGET_TO_X_WIN): Use GDK_WINDOW_XID.
11919
11920 * xmenu.c (menu_position_func): Call gtk_widget_get_preferred_size.
11921
11922 * gtkutil.c: Include gtkx.h if HAVE_GTK3. If ! HAVE_GTK3, define
11923 gdk_window_get_screen, gdk_window_get_geometry,
11924 gdk_x11_window_lookup_for_display and GDK_KEY_g.
11925 (xg_set_screen): Use DEFAULT_GDK_DISPLAY.
11926 (xg_get_pixbuf_from_pixmap): New function.
11927 (xg_get_pixbuf_from_pix_and_mask): Change parameters from GdkPixmap
11928 to Pixmap, take frame as parameter, remove GdkColormap parameter.
11929 Call xg_get_pixbuf_from_pixmap instead of
11930 gdk_pixbuf_get_from_drawable.
11931 (xg_get_image_for_pixmap): Do not make GdkPixmaps, call
11932 xg_get_pixbuf_from_pix_and_mask with Pixmap parameters instead.
11933 (xg_check_special_colors): Use GtkStyleContext and its functions
11934 for HAVE_GTK3.
11935 (xg_prepare_tooltip, xg_hide_tooltip): Call gdk_window_get_screen.
11936 (xg_prepare_tooltip, create_dialog, menubar_map_cb)
11937 (xg_update_frame_menubar, xg_tool_bar_detach_callback)
44f230aa
SM
11938 (xg_tool_bar_attach_callback, xg_update_tool_bar_sizes):
11939 Call gtk_widget_get_preferred_size.
0afb4571
J
11940 (xg_frame_resized): gdk_window_get_geometry only takes 5
11941 parameters.
44f230aa
SM
11942 (xg_win_to_widget, xg_event_is_for_menubar):
11943 Call gdk_x11_window_lookup_for_display.
0afb4571
J
11944 (xg_set_widget_bg): New function.
11945 (delete_cb): New function.
895009e1 11946 (xg_create_frame_widgets): Connect delete-event to delete_cb.
5c32d3f2 11947 Call xg_set_widget_bg. Only set background pixmap for ! HAVE_GTK3
0afb4571
J
11948 (xg_set_background_color): Call xg_set_widget_bg.
11949 (xg_set_frame_icon): Call xg_get_pixbuf_from_pix_and_mask.
11950 (xg_create_scroll_bar): vadj is a GtkAdjustment for HAVE_GTK3.
11951 Only call gtk_range_set_update_policy if ! HAVE_GTK3.
11952 (xg_make_tool_item): Only connect xg_tool_bar_item_expose_callback
11953 if ! HAVE_GTK3.
11954 (update_frame_tool_bar): Call gtk_widget_hide.
11955 (xg_initialize): Use GDK_KEY_g.
11956
11957 * xsmfns.c (gdk_set_sm_client_id): Define to gdk_set_sm_client_id
11958 if ! HAVE_GTK3
11959 (x_session_initialize): Call gdk_x11_set_sm_client_id.
11960
11961 * xterm.c (XFillRectangle): Use cairo routines for HAVE_GTK3.
11962 (x_term_init): Disable Xinput(2) with GDK_CORE_DEVICE_EVENTS.
11963 Load ~/emacs.d/gtkrc only for ! HAVE_GTK3.
11964
1c2cc4ef
JB
119652011-03-08 Juanma Barranquero <lekktu@gmail.com>
11966
11967 * w32xfns.c (select_palette): Check success of RealizePalette against
11968 GDI_ERROR, not zero.
11969
33383987 11970See ChangeLog.11 for earlier changes.
aac0c6e3
MR
11971
11972;; Local Variables:
11973;; coding: utf-8
aac0c6e3
MR
11974;; End:
11975
2f097256 11976 Copyright (C) 2011-2012 Free Software Foundation, Inc.
aac0c6e3
MR
11977
11978 This file is part of GNU Emacs.
11979
11980 GNU Emacs is free software: you can redistribute it and/or modify
11981 it under the terms of the GNU General Public License as published by
11982 the Free Software Foundation, either version 3 of the License, or
11983 (at your option) any later version.
11984
11985 GNU Emacs is distributed in the hope that it will be useful,
11986 but WITHOUT ANY WARRANTY; without even the implied warranty of
11987 MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
11988 GNU General Public License for more details.
11989
11990 You should have received a copy of the GNU General Public License
11991 along with GNU Emacs. If not, see <http://www.gnu.org/licenses/>.