* lisp/mail/sendmail.el (send-mail-function): No longer delay custom
[bpt/emacs.git] / src / ChangeLog
CommitLineData
3fe4b549
JD
12011-07-08 Jan Djärv <jan.h.d@swipnet.se>
2
3 * nsterm.m (initFrameFromEmacs): Don't use ns_return_types
4 in registerServicesMenuSendTypes.
5 (validRequestorForSendType): Don't check ns_return_types.
6
7 * nsfns.m (Fx_open_connection): Put NSStringPboardType into
8 ns_return_type.
9
5df75e47
JR
102011-07-08 Jason Rumney <jasonr@gnu.org>
11
12 * w32fns.c (w32_wnd_proc) [WM_TIMER, WM_SET_CURSOR]: Avoid using
13 frame struct members of non-existent frames (Bug#6284).
14
699c10bd
JD
152011-07-08 Jan Djärv <jan.h.d@swipnet.se>
16
4393663b
JD
17 * nsterm.m (keyDown): Call to wantsToDelayTextChangeNotifications and
18 variable firstTime not needed on OSX >= 10.6.
19 (setPosition): setFloatValue:knobProportion: is deprecated on OSX
20 >= 10.5. Use setKnobProportion, setDoubleValue.
21
22 * nsterm.h (MAC_OS_X_VERSION_10_3, MAC_OS_X_VERSION_10_4)
23 (MAC_OS_X_VERSION_10_5): Define if not defined.
24 (EmacsView, EmacsTooltip): Implements NSWindowDelegate on OSX >= 10.6.
25 (EmacsMenu): Implements NSMenuDelegate on OSX >= 10.6.
26 (EmacsToolbar): Implements NSToolbarDelegate on OSX >= 10.6.
27
28 * nsselect.m (ns_string_from_pasteboard): Don't use deprecated methods
29 cString and lossyCString on OSX >= 10.4
30
31 * nsmenu.m (fillWithWidgetValue): Don't use depercated method
32 sizeToFit on OSX >= 10.2.
33
34 * nsimage.m (allocInitFromFile): Don't use deprecated method
35 bestRepresentationForDevice on OSX >= 10.6.
36
37 * nsfns.m (check_ns_display_info): Cast to long and use %ld in error
38 to avoid warning.
39
40 * emacs.c: Declare unexec_init_emacs_zone.
41
a63e0781
JD
42 * nsgui.h: Fix compiler warning about gnulib redefining verify.
43
699c10bd
JD
44 * nsselect.m (ns_get_local_selection): Change to extern (Bug#8842).
45
46 * nsmenu.m (ns_update_menubar): Remove useless setDelegate call
47 on svcsMenu (Bug#8842).
48
49 * nsfns.m (Fx_open_connection): Remove NSStringPboardType from
50 ns_return_types.
51 (Fns_list_services): Just return Qnil on 10.6, code not working there.
52
53 * nsterm.m (QUTF8_STRING): Declare.
54 (initFrameFromEmacs): Call registerServicesMenuSendTypes.
55 (validRequestorForSendType): Return type is (id).
56 Change indexOfObjectIdenticalTo to indexOfObject.
57 Check if we have local selection before returning self (Bug#8842).
58 (writeSelectionToPasteboard): Put local selection into paste board
59 if we have a local selection (Bug#8842).
60 (syms_of_nsterm): DEFSYM QUTF8_STRING.
61
62 * nsterm.h (MAC_OS_X_VERSION_10_6): Define here instead of nsterm.m.
63 (ns_get_local_selection): Declare.
64
54e10184
LMI
652011-07-07 Lars Magne Ingebrigtsen <larsi@gnus.org>
66
9888ff71
LMI
67 * keymap.c (describe_map_tree): Don't insert a double newline at
68 the end of the buffer (bug#1169) and return whether we inserted
69 something.
70
54e10184
LMI
71 * callint.c (Fcall_interactively): Change "reading args" to
72 "providing args" to try to clarify what it does (bug#1010).
73
15fa4783
KH
742011-07-07 Kenichi Handa <handa@m17n.org>
75
76 * composite.c (composition_compute_stop_pos): Ignore a static
77 composition starting before CHARPOS (Bug#8915).
78
79 * xdisp.c (handle_composition_prop): Likewise.
80
a8815b00
EZ
812011-07-07 Eli Zaretskii <eliz@gnu.org>
82
83 * term.c (produce_glyphs) <xassert>: Allow IT_GLYPHLESS in it->what.
84 (Bug#9015)
85
ef7b981d 862011-07-07 Kenichi Handa <handa@m17n.org>
c805dec0
KH
87
88 * character.h (unicode_category_t): New enum type.
89
90 * chartab.c (uniprop_decoder_t, uniprop_encoder_t): New types.
91 (Qchar_code_property_table): New variable.
92 (UNIPROP_TABLE_P, UNIPROP_GET_DECODER)
93 (UNIPROP_COMPRESSED_FORM_P): New macros.
94 (char_table_ascii): Uncompress the compressed values.
95 (sub_char_table_ref): New arg is_uniprop. Callers changed.
96 Uncompress the compressed values.
97 (sub_char_table_ref_and_range): Likewise.
98 (char_table_ref_and_range): Uncompress the compressed values.
99 (sub_char_table_set): New arg is_uniprop. Callers changed.
100 Uncompress the compressed values.
101 (sub_char_table_set_range): Args changed. Callers changed.
102 (char_table_set_range): Adjuted for the above change.
103 (map_sub_char_table): Delete args default_val and parent. Add arg
104 top. Give decoded values to a Lisp function.
105 (map_char_table): Adjusted for the above change. Give decoded
106 values to a Lisp function. Gcpro more variables.
107 (uniprop_table_uncompress)
108 (uniprop_decode_value_run_length): New functions.
109 (uniprop_decoder, uniprop_decoder_count): New variables.
110 (uniprop_get_decoder, uniprop_encode_value_character)
111 (uniprop_encode_value_run_length, uniprop_encode_value_numeric):
112 New functions.
113 (uniprop_encoder, uniprop_encoder_count): New variables.
114 (uniprop_get_encoder, uniprop_table)
115 (Funicode_property_table_internal, Fget_unicode_property_internal)
116 (Fput_unicode_property_internal): New functions.
117 (syms_of_chartab): DEFSYM Qchar_code_property_table, defsubr
118 Sunicode_property_table_internal, Sget_unicode_property_internal,
119 and Sput_unicode_property_internal. Defvar_lisp
120 char-code-property-alist.
121
122 * composite.c (CHAR_COMPOSABLE_P): Adjusted for the change of
123 Vunicode_category_table.
124
125 * font.c (font_range): Adjusted for the change of
126 Vunicode_category_table.
127
76b397fb
DN
1282011-07-07 Dan Nicolaescu <dann@ics.uci.edu>
129
130 * m/iris4d.h: Remove file, move contents ...
131 * s/irix6-5.h: ... here.
132
22b4128e
PE
1332011-07-06 Paul Eggert <eggert@cs.ucla.edu>
134
135 Remove unportable assumption about struct layout (Bug#8884).
8a5c77bb
PE
136 * alloc.c (mark_buffer):
137 * buffer.c (reset_buffer_local_variables, Fbuffer_local_variables)
138 (clone_per_buffer_values): Don't assume that
22b4128e
PE
139 sizeof (struct buffer) is a multiple of sizeof (Lisp_Object).
140 This isn't true in general, and it's particularly not true
141 if Emacs is configured with --with-wide-int.
142 * buffer.h (FIRST_FIELD_PER_BUFFER, LAST_FIELD_PER_BUFFER):
143 New macros, used in the buffer.c change.
144
869795d6
JD
1452011-07-05 Jan Djärv <jan.h.d@swipnet.se>
146
147 * xsettings.c: Use both GConf and GSettings if both are available.
148 (store_config_changed_event): Add comment.
149 (dpyinfo_valid, store_font_name_changed, map_tool_bar_style)
150 (store_tool_bar_style_changed): New functions.
151 (store_monospaced_changed): Add comment. Call dpyinfo_valid.
152 (struct xsettings): Move font inside HAVE_XFT.
153 (GSETTINGS_TOOL_BAR_STYLE, GSETTINGS_FONT_NAME): New defines.
154 (GSETTINGS_MONO_FONT): Renamed from SYSTEM_MONO_FONT.
155 Move inside HAVE_XFT.
156 (something_changed_gsettingsCB): Renamed from something_changedCB.
157 Check for changes in GSETTINGS_TOOL_BAR_STYLE and GSETTINGS_FONT_NAME
158 also.
159 (GCONF_TOOL_BAR_STYLE, GCONF_FONT_NAME): New defines.
160 (GCONF_MONO_FONT): Renamed from SYSTEM_MONO_FONT. Move inside HAVE_XFT.
161 (something_changed_gconfCB): Renamed from something_changedCB.
162 Check for changes in GCONF_TOOL_BAR_STYLE and GCONF_FONT_NAME also.
163 (parse_settings): Move check for font inside HAVE_XFT.
164 (read_settings, apply_xft_settings): Add comment.
165 (read_and_apply_settings): Add comment. Call map_tool_bar_style and
166 store_tool_bar_style_changed. Move check for font inside HAVE_XFT and
167 call store_font_name_changed.
168 (xft_settings_event): Add comment.
169 (init_gsettings): Add comment. Get values for GSETTINGS_TOOL_BAR_STYLE
170 and GSETTINGS_FONT_NAME. Move check for fonts within HAVE_XFT.
171 (init_gconf): Add comment. Get values for GCONF_TOOL_BAR_STYLE
172 and GCONF_FONT_NAME. Move check for fonts within HAVE_XFT.
173 (xsettings_initialize): Call init_gsettings last.
174 (xsettings_get_system_font, xsettings_get_system_normal_font): Add
175 comment.
176
d8ed26bd
PE
1772011-07-05 Paul Eggert <eggert@cs.ucla.edu>
178
179 Random fixes. E.g., (random) never returned negative values.
180 * fns.c (Frandom): Use GET_EMACS_TIME for random seed, and add the
181 subseconds part to the entropy, as that's a bit more random.
182 Prefer signed to unsigned, since the signedness doesn't matter and
183 in general we prefer signed. When given a limit, use a
184 denominator equal to INTMASK + 1, not to VALMASK + 1, because the
185 latter isn't right if USE_2_TAGS_FOR_INTS.
186 * sysdep.c (get_random): Return a value in the range 0..INTMASK,
187 not 0..VALMASK. Don't discard "excess" bits that random () returns.
188
cabf1cac
SM
1892011-07-04 Stefan Monnier <monnier@iro.umontreal.ca>
190
191 * textprop.c (text_property_stickiness):
192 Obey Vtext_property_default_nonsticky.
193 (syms_of_textprop): Add `display' to Vtext_property_default_nonsticky.
194 * w32fns.c (syms_of_w32fns):
195 * xfns.c (syms_of_xfns): Don't Add `display' since it's there by default.
196
6e9b2be9
PE
1972011-07-04 Paul Eggert <eggert@cs.ucla.edu>
198
199 * fileio.c (barf_or_query_if_file_exists): Use S_ISDIR.
200 This is more efficient than Ffile_directory_p and avoids a minor race.
201
90186c68
LMI
2022011-07-04 Lars Magne Ingebrigtsen <larsi@gnus.org>
203
7c301272
LMI
204 * buffer.c (Foverlay_put): Say what the return value is
205 (bug#7835).
206
c4f2d8d4
LMI
207 * fileio.c (barf_or_query_if_file_exists): Check first if the file
208 is a directory before asking whether to use the file name
209 (bug#7564).
ad637907
LMI
210 (barf_or_query_if_file_exists): Make the "File is a directory"
211 error be more correct.
c4f2d8d4 212
90186c68
LMI
213 * fns.c (Frequire): Remove the mention of the .gz files, since
214 that's installation-specific, but keep the mention of
215 `get-load-suffixes'.
216
da64016e
PE
2172011-07-04 Paul Eggert <eggert@cs.ucla.edu>
218
219 * editfns.c (Fformat_time_string): Don't assume strlen fits in int.
220 Report string overflow if the output is too long.
221
7d47b580
JB
2222011-07-04 Juanma Barranquero <lekktu@gmail.com>
223
a555cb87
JB
224 * gnutls.c (Fgnutls_boot): Don't mention :verify-error.
225 (syms_of_gnutls): Remove duplicate DEFSYM for
226 Qgnutls_bootprop_verify_hostname_error, an error for
227 Qgnutls_bootprop_verify_error (which is no longer used).
228
7d47b580
JB
229 * eval.c (find_handler_clause): Remove parameters `sig' and `data',
230 unused since 2011-01-26T20:02:07Z!monnier@iro.umontreal.ca. All callers changed.
231 Also (re)move comments that are misplaced or no longer relevant.
232
1e49bfab
LMI
2332011-07-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
234
235 * callint.c (Finteractive): Clarify the meaning of "@" (bug#8813).
236
1485f4c0
CY
2372011-07-03 Chong Yidong <cyd@stupidchicken.com>
238
239 * xfaces.c (Finternal_merge_in_global_face): Modify the foreground
240 and background color parameters if they have been changed.
241
a9ab721e
LMI
2422011-07-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
243
244 * editfns.c (Fformat): Clarify the - and 0 flags (bug#6659).
245
cf7cff57
PE
2462011-07-03 Paul Eggert <eggert@cs.ucla.edu>
247
2e13213d
PE
248 * xsettings.c (SYSTEM_FONT): Define only when used.
249 No need to define when HAVE_GSETTINGS || !HAVE_XFT.
250
cf7cff57
PE
251 * keymap.c (access_keymap_1): Now static.
252
7a8e04f7
CY
2532011-07-02 Chong Yidong <cyd@stupidchicken.com>
254
255 * keyboard.c (command_loop_1): If a down-mouse event is unbound,
256 leave any prefix arg for the up event (Bug#1586).
257
61352f62
LMI
2582011-07-02 Lars Magne Ingebrigtsen <larsi@gnus.org>
259
69bb1ef7
LMI
260 * lread.c (syms_of_lread): Mention single symbols defined by
261 `defvar' or `defconst' (bug#7154).
262
61352f62 263 * fns.c (Frequire): Mention .el.gz files (bug#7314).
7b3747f9 264 (Frequire): Mention get-load-suffixes.
61352f62 265
28545e04
MR
2662011-07-02 Martin Rudalics <rudalics@gmx.at>
267
268 * window.h (window): Remove clone_number slot.
269 * window.c (Fwindow_clone_number, Fset_window_clone_number):
270 Remove.
271 (make_parent_window, make_window, saved_window)
272 (Fset_window_configuration, save_window_save): Don't deal with
273 clone numbers.
274 * buffer.c (Qclone_number): Remove declaration.
275 (sort_overlays, overlay_strings): Don't deal with clone numbers.
276
3349e122
SM
2772011-07-02 Stefan Monnier <monnier@iro.umontreal.ca>
278
279 Add multiple inheritance to keymaps.
280 * keymap.c (Fmake_composed_keymap): New function.
281 (Fset_keymap_parent): Simplify.
282 (fix_submap_inheritance): Remove.
283 (access_keymap_1): New function extracted from access_keymap to handle
284 embedded parents and handle lists of maps.
285 (access_keymap): Use it.
286 (Fkeymap_prompt, map_keymap_internal, map_keymap, store_in_keymap)
287 (Fcopy_keymap): Handle embedded parents.
288 (Fcommand_remapping, define_as_prefix): Simplify.
289 (Fkey_binding): Simplify.
290 (syms_of_keymap): Move minibuffer-local-completion-map,
291 minibuffer-local-filename-completion-map,
292 minibuffer-local-must-match-map, and
293 minibuffer-local-filename-must-match-map to Elisp.
294 (syms_of_keymap): Defsubr make-composed-keymap.
295 * keyboard.c (menu_bar_items): Use map_keymap_canonical.
296 (parse_menu_item): Trivial simplification.
297
3279eb87
GM
2982011-07-01 Glenn Morris <rgm@gnu.org>
299
300 * Makefile.in (SETTINGS_LIBS): Fix typo.
301
4550efdf
KI
3022011-07-01 Kazuhiro Ito <kzhr@d1.dion.ne.jp> (tiny patch)
303
304 * coding.c (Fencode_coding_string): Record the last coding system
305 used, as the function doc string says (bug#8738).
306
0949d2b6
JD
3072011-07-01 Jan Djärv <jan.h.d@swipnet.se>
308
309 * xsettings.c (store_monospaced_changed): Take new font as arg and
310 check for change against current_mono_font.
311 (EMACS_TYPE_SETTINGS): Remove this and related defines.
312 (emacs_settings_constructor, emacs_settings_get_property)
313 (emacs_settings_set_property, emacs_settings_class_init)
314 (emacs_settings_init, gsettings_obj): Remove.
315 (something_changedCB): New function for HAVE_GSETTINGS.
316 (something_changedCB): HAVE_GCONF: Call store_monospaced_changed
317 with value as argument.
318 (init_gsettings): Check that GSETTINGS_SCHEMA exists before calling
319 g_settings_new (Bug#8967). Do not create gsettings_obj.
9173deec 320 Remove calls to g_settings_bind. Connect something_changedCB to
0949d2b6
JD
321 "changed".
322
323 * xgselect.c: Add defined (HAVE_GSETTINGS).
324 (xgselect_initialize): Ditto.
325
326 * process.c: Add defined (HAVE_GSETTINGS) for xgselect.h
327 (wait_reading_process_output): Add defined (HAVE_GSETTINGS) for
328 xg_select.
329
bbc6b304
PE
3302011-07-01 Paul Eggert <eggert@cs.ucla.edu>
331
332 * eval.c (struct backtrace): Simplify and port the data structure.
333 Do not assume that "int nargs : BITS_PER_INT - 2;" produces a
334 signed bit field, as this assumption is not portable and it makes
335 Emacs crash when compiled with Sun C 5.8 on sparc. Do not use
336 "char debug_on_exit : 1" as this is not portable either; instead,
337 use the portable "unsigned int debug_on_exit : 1". Remove unused
338 member evalargs. Remove obsolete comments about cc bombing out.
339
9851bfc5
JD
3402011-06-30 Jan Djärv <jan.h.d@swipnet.se>
341
51bb811f 342 * xsettings.c: Include glib-object.h, gio/gio.h if HAVE_GSETTINGS.
9851bfc5
JD
343 Let HAVE_GSETTINGS override HAVE_GCONF.
344 (store_monospaced_changed): New function.
345 (EMACS_SETTINGS): A new type derived from GObject to handle
346 GSettings notifications.
347 (emacs_settings_constructor, emacs_settings_get_property)
348 (emacs_settings_set_property, emacs_settings_class_init):
349 New functions.
350 (gsettings_client, gsettings_obj): New variables.
351 (GSETTINGS_SCHEMA): New define.
352 (something_changedCB): Call store_monospaced_changed.
353 (init_gsettings): New function.
354 (xsettings_initialize): Call init_gsettings.
355 (syms_of_xsettings): Initialize gsettings_client, gsettings_obj
356 to NULL.
357
358 * Makefile.in (SETTINGS_CFLAGS, SETTINGS_LIBS): Renamed from
359 GCONF_CFLAGS/LIBS.
360
5386012d
MR
3612011-06-29 Martin Rudalics <rudalics@gmx.at>
362
363 * window.c (resize_root_window, grow_mini_window)
364 (shrink_mini_window): Rename Qresize_root_window to
365 Qwindow_resize_root_window and Qresize_root_window_vertically to
366 Qwindow_resize_root_window_vertically.
367
f13e0b08
PE
3682011-06-28 Paul Eggert <eggert@cs.ucla.edu>
369
370 * gnutls.c (Qgnutls_bootprop_verify_error): Remove unused var.
371
94515237
JB
3722011-06-27 Juanma Barranquero <lekktu@gmail.com>
373
374 * makefile.w32-in: Redesign dependencies so they reflect more
375 clearly which files are directly included by each source file,
376 and not through other includes.
377
e43b6e43
MR
3782011-06-27 Martin Rudalics <rudalics@gmx.at>
379
380 * buffer.c (Qclone_number): Declare static and DEFSYM it.
381 (sort_overlays, overlay_strings): When an overlay's clone number
382 matches the window's clone number process the overlay even if
383 the overlay's window property doesn't match the current window.
384
d68443dc
MR
385 * window.c (Fwindow_vchild): Rename to Fwindow_top_child.
386 (Fwindow_hchild): Rename to Fwindow_left_child.
387 (Fwindow_next): Rename to Fwindow_next_sibling.
388 (Fwindow_prev): Rename to Fwindow_prev_sibling.
d615d6d2
MR
389 (resize_window_check): Rename to window_resize_check.
390 (resize_window_apply): Rename to window_resize_apply.
391 (Fresize_window_apply): Rename to Fwindow_resize_apply.
392 (Fdelete_other_windows_internal, resize_frame_windows)
393 (Fsplit_window_internal, Fdelete_window_internal)
394 (grow_mini_window, shrink_mini_window)
395 (Fresize_mini_window_internal): Fix callers accordingly.
d68443dc 396
c7e73be5
JD
3972011-06-26 Jan Djärv <jan.h.d@swipnet.se>
398
399 * emacsgtkfixed.h: State that this is only used with Gtk+3.
400 (emacs_fixed_set_min_size): Remove.
401 (emacs_fixed_new): Take frame as argument.
402
403 * emacsgtkfixed.c: State that this is only used with Gtk+3.
404 (_EmacsFixedPrivate): Remove minwidth/height.
405 Add struct frame *f.
406 (emacs_fixed_init): Initialize priv->f.
407 (get_parent_class, emacs_fixed_set_min_size): Remove.
408 (emacs_fixed_new): Set priv->f to argument.
409 (emacs_fixed_get_preferred_width)
410 (emacs_fixed_get_preferred_height): Use min_width/height from
411 frames size_hint to set minimum and natural (Bug#8919).
412 (XSetWMSizeHints, XSetWMNormalHints): Override these functions
413 and use min_width/height from frames size_hint to set
414 min_width/height (Bug#8919).
415
416 * gtkutil.c (xg_create_frame_widgets): Pass f to emacs_fixed_new.
9173deec
JB
417 (x_wm_set_size_hint): Remove call to emacs_fixed_set_min_size.
418 Fix indentation.
c7e73be5 419
cf99dcf8
EZ
4202011-06-26 Eli Zaretskii <eliz@gnu.org>
421
422 * bidi.c (bidi_paragraph_init): Test for ZV_BYTE before calling
423 bidi_at_paragraph_end, since fast_looking_at doesn't like to be
424 called at ZV.
425
029529ac
CY
4262011-06-26 Chong Yidong <cyd@stupidchicken.com>
427
428 * process.c (wait_reading_process_output): Bypass select if
429 waiting for a cell while ignoring keyboard input, and input is
430 pending. Suggested by Jan Djärv (Bug#8869).
431
7a7ef429
PE
4322011-06-25 Paul Eggert <eggert@cs.ucla.edu>
433
434 Use gnulib's dup2 module instead of rolling our own.
435 * sysdep.c (dup2) [!HAVE_DUP2]: Remove; gnulib now does this.
436
11fdef7d 4372011-06-25 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
989b42d2
YM
438
439 * dispnew.c (scrolling_window): Before scrolling, turn off a
440 mouse-highlight in the window being scrolled.
441
cd3520a4
JB
4422011-06-24 Juanma Barranquero <lekktu@gmail.com>
443
444 Move DEFSYM to lisp.h and use everywhere.
445
446 * character.h (DEFSYM): Move declaration...
447 * lisp.h (DEFSYM): ...here.
448
449 * gnutls.c:
450 * minibuf.c:
451 * w32menu.c:
452 * w32proc.c:
453 * w32select.c: Don't include character.h.
454
455 * alloc.c (syms_of_alloc):
456 * buffer.c (syms_of_buffer):
457 * bytecode.c (syms_of_bytecode):
458 * callint.c (syms_of_callint):
459 * casefiddle.c (syms_of_casefiddle):
460 * casetab.c (init_casetab_once):
461 * category.c (init_category_once, syms_of_category):
462 * ccl.c (syms_of_ccl):
463 * cmds.c (syms_of_cmds):
464 * composite.c (syms_of_composite):
465 * dbusbind.c (syms_of_dbusbind):
466 * dired.c (syms_of_dired):
467 * dispnew.c (syms_of_display):
468 * doc.c (syms_of_doc):
469 * editfns.c (syms_of_editfns):
470 * emacs.c (syms_of_emacs):
471 * eval.c (syms_of_eval):
472 * fileio.c (syms_of_fileio):
473 * fns.c (syms_of_fns):
474 * frame.c (syms_of_frame):
475 * fringe.c (syms_of_fringe):
476 * insdel.c (syms_of_insdel):
477 * keymap.c (syms_of_keymap):
478 * lread.c (init_obarray, syms_of_lread):
479 * macros.c (syms_of_macros):
480 * msdos.c (syms_of_msdos):
481 * print.c (syms_of_print):
482 * process.c (syms_of_process):
483 * search.c (syms_of_search):
484 * sound.c (syms_of_sound):
485 * syntax.c (init_syntax_once, syms_of_syntax):
486 * terminal.c (syms_of_terminal):
487 * textprop.c (syms_of_textprop):
488 * undo.c (syms_of_undo):
489 * w32.c (globals_of_w32):
490 * window.c (syms_of_window):
491 * xdisp.c (syms_of_xdisp):
492 * xfaces.c (syms_of_xfaces):
493 * xfns.c (syms_of_xfns):
494 * xmenu.c (syms_of_xmenu):
495 * xsettings.c (syms_of_xsettings):
496 * xterm.c (syms_of_xterm): Use DEFSYM.
497
4228cf16
TZ
4982011-06-24 Teodor Zlatanov <tzz@lifelogs.com>
499
cd3520a4 500 * gnutls.c (syms_of_gnutls): Use the DEFSYM macro from character.h.
4228cf16 501
7fcccf1e
PE
5022011-06-23 Paul Eggert <eggert@cs.ucla.edu>
503
7efb4e0e
PE
504 Integer and buffer overflow fixes (Bug#8873).
505
ff5844ad
PE
506 * print.c (printchar, strout): Check for string overflow.
507 (PRINTPREPARE, printchar, strout):
508 Don't set size unless allocation succeeds.
509
90532f02
PE
510 * minibuf.c (read_minibuf_noninteractive): Use ptrdiff_t, not int,
511 for sizes. Check for string overflow more accurately.
512 Simplify newline removal at end; this suppresses a GCC 4.6.0 warning.
513
6d84508d
PE
514 * macros.c: Integer and buffer overflow fixes.
515 * keyboard.h (struct keyboard.kbd_macro_bufsize):
516 * macros.c (Fstart_kbd_macro, store_kbd_macro_char):
517 Use ptrdiff_t, not int, for sizes.
518 Don't increment bufsize until after realloc succeeds.
519 Check for size-calculation overflow.
520 (Fstart_kbd_macro): Use EMACS_INT, not int, for XINT result.
521
437b2cb4
PE
522 * lisp.h (DEFVAR_KBOARD): Use offsetof instead of char * finagling.
523
8b9ac8b4
PE
524 * lread.c: Integer overflow fixes.
525 (read_integer): Radix is now EMACS_INT, not int,
526 to improve quality of diagnostics for out-of-range radices.
527 Calculate buffer size correctly for out-of-range radices.
528 (read1): Check for integer overflow in radices, and in
529 read-circle numbers.
82cb60d3
PE
530 (read_escape): Avoid int overflow.
531 (Fload, openp, read_buffer_size, read1)
532 (substitute_object_recurse, read_vector, read_list, map_obarray):
533 Use ptrdiff_t, not int, for sizes.
534 (read1): Use EMACS_INT, not int, for sizes.
20270765 535 Check for size overflow.
8b9ac8b4 536
7fcccf1e
PE
537 * image.c (cache_image): Check for size arithmetic overflow.
538
bfbbd7e7
PE
539 * lread.c: Integer overflow issues.
540 (saved_doc_string_size, saved_doc_string_length)
541 (prev_saved_doc_string_size, prev_saved_doc_string_length):
542 Now ptrdiff_t, not int.
543 (read1): Don't assume doc string length fits in int. Check for
544 out-of-range doc string lengths.
545 (read_list): Don't assume file position fits in int.
39019e54 546 (read_escape): Check for hex character overflow.
bfbbd7e7 547
4e323265
LL
5482011-06-22 Leo Liu <sdl.web@gmail.com>
549
550 * minibuf.c (Fcompleting_read_default, Vcompleting_read_function):
551 Move to minibuffer.el.
552
85fece3e
PE
5532011-06-22 Paul Eggert <eggert@cs.ucla.edu>
554
20b84ce9 555 Fixes for GLYPH_DEBUG found by GCC 4.6.0 static checking.
85fece3e
PE
556 The following patches are for when GLYPH_DEBUG && !XASSERT.
557 * dispextern.h (trace_redisplay_p, dump_glyph_string):
558 * dispnew.c (flush_stdout):
559 * xdisp.c (dump_glyph_row, dump_glyph_matrix, dump_glyph):
560 Mark as externally visible.
561 * dispnew.c (check_window_matrix_pointers): Now static.
562 * dispnew.c (window_to_frame_vpos):
563 * xfns.c (unwind_create_frame):
564 * xterm.c (x_check_font): Remove unused local.
565 * scroll.c (CHECK_BOUNDS):
566 * xfaces.c (cache_fache): Rename local to avoid shadowing.
567 * xfns.c, w32fns.c (image_cache_refcount, dpyinfo_refcount): Now static.
568 * xdisp.c (check_window_end): Now a no-op if !XASSERTS.
569 (debug_first_unchanged_at_end_vpos, debug_last_unchanged_at_beg_vpos)
570 (debug_dvpos, debug_dy, debug_delta, debug_delta_bytes, debug_end_vpos):
571 Now static.
572 (debug_method_add): Use va_list and vsprintf rather than relying
573 on undefined behavior with wrong number of arguments.
574 (dump_glyph, dump_glyph_row, Fdump_glyph_matrix):
575 Don't assume ptrdiff_t and EMACS_INT are the same width as int.
576 In this code, it's OK to assume C99 behavior for ptrdiff_t formats
577 since we're not interested in debugging glyphs with old libraries.
578 * xfaces.c (cache_face): Move debugging code earlier; this pacifies
579 GCC 4.6.0's static checking.
580
0766b489
PE
5812011-06-22 Paul Eggert <eggert@cs.ucla.edu>
582
31fd4b32
PE
583 Integer overflow and signedness fixes (Bug#8873).
584 A few related buffer overrun fixes, too.
585
b79e8648
PE
586 * font.c (font_score): Use EMACS_INT, not int, to store XINT value.
587
0766b489
PE
588 * dispextern.h (struct face.stipple):
589 * image.c (x_bitmap_height, x_bitmap_width, x_bitmap_pixmap)
590 (x_bitmap_mask, x_allocate_bitmap_record)
591 (x_create_bitmap_from_data, x_create_bitmap_from_file)
592 (x_destroy_bitmap, x_destroy_all_bitmaps, x_create_bitmap_mask)
593 (x_create_bitmap_from_xpm_data):
594 * nsterm.h (struct ns_display_info.bitmaps_size, .bitmaps_last):
595 * w32term.h (struct w32_display_info.icon_bitmap_id, .bitmaps_size)
596 (.bitmaps_last):
597 * xfaces.c (load_pixmap):
598 * xterm.c (x_bitmap_icon, x_wm_set_icon_pixmap):
599 * xterm.h (struct x_display_info.icon_bitmap_id, .bitmaps_size)
600 (.bitmaps_last, struct x_output.icon_bitmap):
601 Use ptrdiff_t, not int, for bitmap indexes.
602 (x_allocate_bitmap_record): Check for size overflow.
603 * dispextern.h, lisp.h: Adjust to API changes elsewhere.
604
b081724f
PE
605 Use ptrdiff_t, not int, for overlay counts.
606 * buffer.h (overlays_at, sort_overlays, GET_OVERLAYS_AT):
607 * editfns.c (overlays_around, get_pos_property):
608 * textprop.c (get_char_property_and_overlay):
609 * xdisp.c (next_overlay_change, note_mouse_highlight):
610 * xfaces.c (face_at_buffer_position):
21514da7
PE
611 * buffer.c (OVERLAY_COUNT_MAX): New macro.
612 (overlays_at, overlays_in, sort_overlays, Foverlays_at)
613 (Fnext_overlay_change, Fprevious_overlay_change)
614 (mouse_face_overlay_overlaps, Foverlays_in):
b081724f 615 Use ptrdiff_t, not int, for sizes.
21514da7 616 (overlays_at, overlays_in): Check for size-calculation overflow.
b081724f 617
3de73e5e
PE
618 * xterm.c (xim_initialize, same_x_server): Strlen may not fit in int.
619
2606c57b
PE
620 * xsmfns.c (smc_save_yourself_CB, x_session_initialize): Avoid strlen.
621 (x_session_initialize): Do not assume string length fits in int.
622
aaafe47a
PE
623 * xsettings.c (apply_xft_settings): Fix potential buffer overrun.
624 This is unlikely, but can occur if DPI is outlandish.
625
2674ddc8 626 * xsettings.c (Ffont_get_system_normal_font, Ffont_get_system_font):
3a5077c5
PE
627 * xselect.c (Fx_get_atom_name): Avoid need for strlen.
628
28154962
PE
629 * xrdb.c: Don't assume strlen fits in int; avoid some strlens.
630 * xrdb.c (magic_file_p, search_magic_path):
631 Omit last arg SUFFIX; it was always 0. All callers changed.
632 (magic_file_p): Use ptrdiff_t, not int. Check for size overflow.
633
7de51af5
PE
634 * xfont.c (xfont_match): Avoid need for strlen.
635
25ed6cc3
PE
636 * xfns.c: Don't assume strlen fits in int.
637 (xic_create_fontsetname, x_window): Use ptrdiff_t, not int.
638
4eab31dd
PE
639 * xdisp.c (message_log_check_duplicate): Return intmax_t,
640 not unsigned long, as we prefer signed integers. All callers changed.
641 Detect integer overflow in repeat count.
642 (message_dolog): Don't assume print length fits in 39 bytes.
df1f27af 643 (display_mode_element): Don't assume strlen fits in int.
4eab31dd 644
171e2a58
PE
645 * termcap.c: Don't assume sizes fit in int and never overflow.
646 (struct termcap_buffer, tgetent): Use ptrdiff_t, not int, for sizes.
647 (gobble_line): Check for size-calculation overflow.
648
ad39faca 649 * minibuf.c (Fread_buffer):
6e5bb2dc 650 * lread.c (intern, intern_c_string):
74ca2eb3
PE
651 * image.c (xpm_scan) [HAVE_NS && !HAVE_XPM]:
652 Don't assume string length fits in int.
653
52c61c22 654 * keyboard.c (parse_tool_bar_item):
9bda3520
PE
655 * gtkutil.c (style_changed_cb): Avoid need for strlen.
656
b5b8c9e5
PE
657 * font.c: Don't assume string length fits in int.
658 (font_parse_xlfd, font_parse_fcname, font_unparse_fcname):
659 Use ptrdiff_t, not int.
ccd6111c
PE
660 (font_intern_prop): Don't assume string length fits in int.
661 Don't assume integer property fits in fixnum.
662 * font.h (font_intern_prop): 2nd arg is now ptrdiff_t, not int.
b5b8c9e5 663
882f0d81 664 * filelock.c: Fix some buffer overrun and integer overflow issues.
51cab52b 665 (get_boot_time): Don't assume gzip command string fits in 100 bytes.
882f0d81
PE
666 Reformulate so as not to need the command string.
667 Invoke gzip -cd rather than gunzip, as it's more portable.
668 (lock_info_type, lock_file_1, lock_file):
669 Don't assume pid_t and time_t fit in unsigned long.
670 (LOCK_PID_MAX): Remove; we now use more-reliable bounds.
671 (current_lock_owner): Prefer signed type for sizes.
672 Use memcpy, not strncpy, where memcpy is what is really wanted.
673 Don't assume (via atoi) that time_t and pid_t fit in int.
674 Check for time_t and/or pid_t out of range, e.g., via a network share.
675 Don't alloca where an auto var works fine.
676
93f4cf88
PE
677 * fileio.c: Fix some integer overflow issues.
678 (file_name_as_directory, Fexpand_file_name, Fsubstitute_in_file_name):
679 Don't assume string length fits in int.
680 (directory_file_name): Don't assume string length fits in long.
681 (make_temp_name): Don't assume pid fits in int, or that its print
682 length is less than 20.
683
f3e92b69
PE
684 * data.c (Fsubr_name): Rewrite to avoid a strlen call.
685
1bfdaf10
PE
686 * coding.c (make_subsidiaries): Don't assume string length fits in int.
687
35016e9a
PE
688 * callproc.c (child_setup): Rewrite to avoid two strlen calls.
689
3d1e65a1
PE
690 * process.c (Fformat_network_address): Use EMACS_INT, not EMACS_UINT.
691 We prefer signed integers, even for size calculations.
692
0b963a93
PE
693 * emacs.c: Don't assume string length fits in 'int'.
694 (DEFINE_DUMMY_FUNCTION, sort_args): Use ptrdiff_t, not int.
695 (main): Don't invoke strlen when not needed.
696
573f4b54
PE
697 * dbusbind.c (XD_ERROR): Don't arbitrarily truncate string.
698 (XD_DEBUG_MESSAGE): Don't waste a byte.
699
989f33ba
PE
700 * callproc.c (getenv_internal_1, getenv_internal)
701 (Fgetenv_internal):
965d34eb
PE
702 * buffer.c (init_buffer): Don't assume string length fits in 'int'.
703
e4d29b33
PE
704 * lread.c (invalid_syntax): Omit length argument.
705 All uses changed. This doesn't fix a bug, but it simplifies the
706 code away from its former Hollerith-constant appearance, and it's
707 one less 'int' to worry about when looking at integer-overflow issues.
51cab52b 708 (string_to_number): Simplify 2011-04-26 change by invoking xsignal1.
e4d29b33 709
eb49b136
PE
710 * lisp.h (DEFUN): Remove bogus use of sizeof (struct Lisp_Subr).
711 This didn't break anything, but it didn't help either.
712 It's confusing to put a bogus integer in a place where the actual
713 value does not matter.
9f62aeb1 714 (LIST_END_P): Remove unused macro and its bogus comment.
cbeff735 715 (make_fixnum_or_float): Remove unnecessary cast to EMACS_INT.
eb49b136 716
15375a22
PE
717 * lisp.h (union Lisp_Object.i): EMACS_INT, not EMACS_UINT.
718 This is for consistency with the ordinary, non-USE_LISP_UNION_TYPE,
719 implementation.
b61cc01c
PE
720 (struct Lisp_Bool_Vector.size): EMACS_INT, not EMACS_UINT.
721 We prefer signed types, and the value cannot exceed the EMACS_INT
722 range anyway (because otherwise the length would not be representable).
9a8e8d9b
PE
723 (XSET) [USE_LISP_UNION_TYPE]: Use uintptr_t and intptr_t,
724 not EMACS_UINT and EMACS_INT, when converting pointer to integer.
725 This avoids a GCC warning when WIDE_EMACS_INT.
15375a22 726
53b2623d
PE
727 * indent.c (sane_tab_width): New function.
728 (current_column, scan_for_column, Findent_to, position_indentation)
729 (compute_motion): Use it. This is just for clarity.
8fcaf9cc 730 (Fcompute_motion): Don't assume hscroll and tab offset fit in int.
53b2623d 731
51cab52b 732 * image.c (xbm_image_p): Don't assume stated width, height fit in int.
45aebb64 733
f2ed8a70
PE
734 * lisp.h (lint_assume): New macro.
735 * composite.c (composition_gstring_put_cache):
736 * ftfont.c (ftfont_shape_by_flt): Use it to pacify GCC 4.6.0.
737
abe80cc6
PE
738 * editfns.c, insdel.c:
739 Omit unnecessary forward decls, to simplify future changes.
a9e860e1 740
b02c740e
PE
741 * ftfont.c (ftfont_shape_by_flt): Use signed integers for lengths.
742
ebc96716
PE
743 * font.c (Ffont_shape_gstring): Don't assume glyph len fits in 'int'.
744
b4e50fa0 745 * fns.c (Ffillarray): Don't assume bool vector size fits in 'int'.
f03dc6ef 746 Use much-faster test for byte-length change.
311d5d7c 747 Don't assume string byte-length fits in 'int'.
a4cf38e4 748 Check that character arg fits in 'int'.
85461888 749 (mapcar1): Declare byte as byte, for clarity.
b4e50fa0 750
c0c1ee9f
PE
751 * alloc.c (Fmake_bool_vector): Avoid unnecessary multiplication.
752
a498d7f4
PE
753 * fns.c (concat): Catch string overflow earlier.
754 Do not rely on integer wraparound.
755
51cab52b
PE
756 * dispextern.h (struct it.overlay_strings_charpos)
757 (struct it.selective): Now EMACS_INT, not int.
87830974
PE
758 * xdisp.c (forward_to_next_line_start)
759 (back_to_previous_visible_line_start)
760 (reseat_at_next_visible_line_start, next_element_from_buffer):
761 Don't arbitrarily truncate the value of 'selective' to int.
762
76031fad
PE
763 * xdisp.c (init_iterator): Use XINT, not XFASTINT; it might be < 0.
764
5eb55db9
PE
765 * composite.c: Don't truncate sizes to 'int'.
766 (composition_gstring_p, composition_reseat_it)
767 (composition_adjust_point): Use EMACS_INT, not int.
7d100a81
PE
768 (get_composition_id, composition_gstring_put_cache): Use EMACS_INT,
769 not EMACS_UINT, for indexes.
5eb55db9 770
0703a717
PE
771 * category.h (CATEGORY_SET_P): Remove unnecessary cast to EMACS_INT.
772
d6202519
PE
773 * buffer.c: Include <verify.h>.
774 (struct sortvec.priority, struct sortstr.priority):
8961a454 775 Now EMACS_INT, not int.
c20998a7 776 (compare_overlays, cmp_for_strings): Avoid subtraction overflow.
67c36fce
PE
777 (struct sortstr.size, record_overlay_string)
778 (struct sortstrlist.size, struct sortlist.used):
779 Don't truncate size to int.
780 (record_overlay_string): Check for size-calculation overflow.
d6202519 781 (init_buffer_once): Check at compile-time, not run-time.
fadf4e30 782
d5a19415
JM
7832011-06-22 Jim Meyering <meyering@redhat.com>
784
029529ac 785 Don't leak an XBM-image-sized buffer
d5a19415
JM
786 * image.c (xbm_load): Free the image buffer after using it.
787
a9041e6c
PE
7882011-06-21 Paul Eggert <eggert@cs.ucla.edu>
789
790 Port to Sun C.
791 * composite.c (find_automatic_composition): Omit needless 'return 0;'
792 that Sun C diagnosed.
793 * fns.c (secure_hash): Fix pointer signedness issue.
794 * intervals.c (static_offset_intervals): New function.
795 (offset_intervals): Use it.
796
7f3f739f
LL
7972011-06-21 Leo Liu <sdl.web@gmail.com>
798
799 * deps.mk (fns.o):
800 * makefile.w32-in ($(BLD)/fns.$(O)): Include sha256.h and
801 sha512.h.
802
803 * fns.c (secure_hash): Rename from crypto_hash_function and change
804 the first arg to accept symbols.
5b66d427 805 (Fsecure_hash): New primitive.
7f3f739f
LL
806 (syms_of_fns): New symbols.
807
76147d94
DD
8082011-06-20 Deniz Dogan <deniz@dogan.se>
809
810 * process.c (Fset_process_buffer): Clarify return value in
811 docstring.
812
7d7d0045
CY
8132011-06-18 Chong Yidong <cyd@stupidchicken.com>
814
815 * dispnew.c (add_window_display_history): Use BVAR.
816
817 * xdisp.c (debug_method_add): Use BVAR.
818 (check_window_end, dump_glyph_matrix, dump_glyph)
819 (dump_glyph_row, dump_glyph_string): Convert arglist to ANSI C.
820
821 * xfaces.c (check_lface_attrs, check_lface, dump_realized_face):
822 Likewise.
823
824 * xfns.c (Fx_create_frame, x_create_tip_frame): Delay image cache
825 check till after the cache is created in init_frame_faces.
826
ff2bc410
SM
8272011-06-17 Stefan Monnier <monnier@iro.umontreal.ca>
828
829 * fns.c (Fsafe_length): Yet another int/Lisp_Object mixup.
830
28177add
PE
8312011-06-16 Paul Eggert <eggert@cs.ucla.edu>
832
dd3482fe
PE
833 * lisp.h: Include <limits.h>, for INT_MAX, LONG_MAX, LLONG_MAX.
834 Without this, prin1 mishandles Lisp_Misc_Save_Value printing on
835 hosts with pre-C99 libraries, because pD is wrongly defined to "t".
836
393d71f3 837 Improve buffer-overflow checking (Bug#8873).
1c8e352f
PE
838 * fileio.c (Finsert_file_contents):
839 * insdel.c (insert_from_buffer_1, replace_range, replace_range_2):
840 Remove the old (too-loose) buffer overflow checks.
841 They weren't needed, since make_gap checks for buffer overflow.
842 * insdel.c (make_gap_larger): Catch buffer overflows that were missed.
843 The old code merely checked for Emacs fixnum overflow, and relied
844 on undefined (wraparound) behavior. The new code avoids undefined
845 behavior, and also checks for ptrdiff_t and/or size_t overflow.
846
2e6813b0 847 * editfns.c (Finsert_char): Don't dump core with very negative counts.
21d890a4
PE
848 Tune. Don't use wider integers than needed. Don't use alloca.
849 Use a bigger 'string' buffer. Rewrite to avoid 'n > 0' test.
2e6813b0 850
599a9e4f
PE
851 * insdel.c (replace_range): Fix buf overflow when insbytes < outgoing.
852
99561444
PE
853 * insdel.c, lisp.h (buffer_overflow): New function.
854 (insert_from_buffer_1, replace_range, replace_range_2):
855 * insdel.c (make_gap_larger):
856 * editfns.c (Finsert_char):
857 * fileio.c (Finsert_file_contents): Use it, to normalize wording.
858
28177add
PE
859 * buffer.h (BUF_BYTES_MAX): Cast to ptrdiff_t so that it's signed.
860
e69dafad
PE
8612011-06-15 Paul Eggert <eggert@cs.ucla.edu>
862
a7af7fde 863 Integer overflow and signedness fixes (Bug#8873).
ff672d2c 864
b1c46f02
PE
865 * ccl.c (ASCENDING_ORDER): New macro, to work around GCC bug 43772.
866 (GET_CCL_RANGE, IN_INT_RANGE): Use it.
867
e69dafad
PE
868 * fileio.c: Don't assume EMACS_INT fits in off_t.
869 (emacs_lseek): New static function.
870 (Finsert_file_contents, Fwrite_region): Use it.
871 Use SEEK_SET, SEEK_CUR, SEEK_END as appropriate.
872
566684ea
PE
873 * fns.c (Fload_average): Don't assume 100 * load average fits in int.
874
e6966cd6
PE
875 * fns.c: Don't overflow int when computing a list length.
876 * fns.c (QUIT_COUNT_HEURISTIC): New constant.
877 (Flength, Fsafe_length): Use EMACS_INT, not int, to avoid unwanted
878 truncation on 64-bit hosts. Check for QUIT every
879 QUIT_COUNT_HEURISTIC entries rather than every other entry; that's
880 faster and is responsive enough.
881 (Flength): Report an error instead of overflowing an integer.
882 (Fsafe_length): Return a float if the value is not representable
883 as a fixnum. This shouldn't happen except in contrived situations.
6346d301 884 (Fnthcdr, Fsort): Don't assume list length fits in int.
de41a810 885 (Fcopy_sequence): Don't assume vector length fits in int.
00c604f2 886
dd0b0efb
PE
887 * alloc.c: Check that resized vectors' lengths fit in fixnums.
888 (header_size, word_size): New constants.
889 (allocate_vectorlike): Don't check size overflow here.
890 (allocate_vector): Check it here instead, since this is the only
891 caller of allocate_vectorlike that could cause overflow.
892 Check that the new vector's length is representable as a fixnum.
893
86fe5cfe
PE
894 * fns.c (next_almost_prime): Don't return a multiple of 3 or 5.
895 The previous code was bogus. For example, next_almost_prime (32)
896 returned 39, which is undesirable as it is a multiple of 3; and
897 next_almost_prime (24) returned 25, which is a multiple of 5 so
898 why was the code bothering to check for multiples of 7?
899
80e88859
PE
900 * bytecode.c (exec_byte_code): Use ptrdiff_t, not int, for vector length.
901
4a2f0ad6
PE
902 * eval.c, doprnt.c (SIZE_MAX): Remove; inttypes.h defines this now.
903
f66c7cf8
PE
904 Variadic C functions now count arguments with ptrdiff_t.
905 This partly undoes my 2011-03-30 change, which replaced int with size_t.
906 Back then I didn't know that the Emacs coding style prefers signed int.
907 Also, in the meantime I found a few more instances where arguments
4a2f0ad6
PE
908 were being counted with int, which may truncate counts on 64-bit
909 machines, or EMACS_INT, which may be unnecessarily wide.
f66c7cf8
PE
910 * lisp.h (struct Lisp_Subr.function.aMANY)
911 (DEFUN_ARGS_MANY, internal_condition_case_n, safe_call):
912 Arg counts are now ptrdiff_t, not size_t.
913 All variadic functions and their callers changed accordingly.
914 (struct gcpro.nvars): Now size_t, not size_t. All uses changed.
915 * bytecode.c (exec_byte_code): Check maxdepth for overflow,
916 to avoid potential buffer overrun. Don't assume arg counts fit in 'int'.
917 * callint.c (Fcall_interactively): Check arg count for overflow,
918 to avoid potential buffer overrun. Use signed char, not 'int',
919 for 'varies' array, so that we needn't bother to check its size
920 calculation for overflow.
921 * editfns.c (Fformat): Use ptrdiff_t, not EMACS_INT, to count args.
922 * eval.c (apply_lambda):
923 * fns.c (Fmapconcat): Use XFASTINT, not XINT, to get args length.
924 (struct textprop_rec.argnum): Now ptrdiff_t, not int. All uses changed.
925 (mapconcat): Use ptrdiff_t, not int and EMACS_INT, to count args.
926
a1759b76
PE
927 * callint.c (Fcall_interactively): Don't use index var as event count.
928
d96be9fc
PE
929 * vm-limit.c (check_memory_limits): Fix incorrect extern function decls.
930 * mem-limits.h (SIZE): Remove; no longer used.
931
a690a978 932 * xterm.c (x_alloc_nearest_color_1): Prefer int to long when int works.
5efd304b 933
578c21e6
PE
934 Remove unnecessary casts.
935 * xterm.c (x_term_init):
936 * xfns.c (x_set_border_pixel):
937 * widget.c (create_frame_gcs): Remove casts to unsigned long etc.
938 These aren't needed now that we assume ANSI C.
939
96f53c6c
PE
940 * sound.c (Fplay_sound_internal): Remove cast to unsigned long.
941 It's more likely to cause problems (due to unsigned overflow)
942 than to cure them.
943
83c77d31
PE
944 * dired.c (Ffile_attributes): Don't use 32-bit hack on 64-bit hosts.
945
ee2079f1
PE
946 * unexelf.c (unexec): Don't assume BSS addr fits in unsigned.
947
6da65536
PE
948 * xterm.c (handle_one_xevent): Omit unnecessary casts to unsigned.
949
7147c4a4
PE
950 * keyboard.c (modify_event_symbol): Don't limit alist len to UINT_MAX.
951
193e32d9
PE
952 * lisp.h (CHAR_TABLE_SET): Omit now-redundant test.
953
e5533da6
PE
954 * lread.c (Fload): Don't compare a possibly-garbage time_t value.
955
9910e595
PE
956 GLYPH_CODE_FACE returns EMACS_INT, not int.
957 * dispextern.h (merge_faces):
958 * xfaces.c (merge_faces):
01103c44
PE
959 * xdisp.c (get_next_display_element, next_element_from_display_vector):
960 Don't assume EMACS_INT fits in int.
9910e595 961
2638320e
PE
962 * character.h (CHAR_VALID_P): Remove unused parameter.
963 * fontset.c, lisp.h, xdisp.c: All uses changed.
964
045eb8d9
PE
965 * editfns.c (Ftranslate_region_internal): Omit redundant test.
966
c1f134b5
PE
967 * fns.c (concat): Minor tuning based on overflow analysis.
968 This doesn't fix any bugs. Use int to hold character, instead
969 of constantly refetching from Emacs object. Use XFASTINT, not
970 XINT, for value known to be a character. Don't bother comparing
971 a single byte to 0400, as it's always less.
972
395fcb93 973 * floatfns.c (Fexpt):
327eeec8
PE
974 * fileio.c (make_temp_name): Omit unnecessary cast to unsigned.
975
abbd3d23
PE
976 * editfns.c (Ftranslate_region_internal): Use int, not EMACS_INT
977 for characters.
978
684a03ef
PE
979 * doc.c (get_doc_string): Omit (unsigned)c that mishandled negatives.
980
0fed43f3
PE
981 * data.c (Faset): If ARRAY is a string, check that NEWELT is a char.
982 Without this fix, on a 64-bit host (aset S 0 4294967386) would
983 incorrectly succeed when S was a string, because 4294967386 was
984 truncated before it was used.
985
8fd02eb7
PE
986 * chartab.c (Fchar_table_range): Use CHARACTERP to check range.
987 Otherwise, an out-of-range integer could cause undefined behavior
988 on a 64-bit host.
989
f8c86b69
PE
990 * composite.c: Use int, not EMACS_INT, for characters.
991 (fill_gstring_body, composition_compute_stop_pos): Use int, not
992 EMACS_INT, for values that are known to be in character range.
993 This doesn't fix any bugs but is the usual style inside Emacs and
994 may generate better code on 32-bit machines.
995
34206dd2
PE
996 Make sure a 64-bit char is never passed to ENCODE_CHAR.
997 This is for reasons similar to the recent CHAR_STRING fix.
998 * charset.c (Fencode_char): Check that character arg is actually
999 a character. Pass an int to ENCODE_CHAR.
1000 * charset.h (ENCODE_CHAR): Verify that the character argument is no
1001 wider than 'int', as a compile-time check to prevent future regressions
1002 in this area.
1003
c5958d4c 1004 * character.c (char_string): Remove unnecessary casts.
13bdea59
PE
1005
1006 Make sure a 64-bit char is never passed to CHAR_STRING.
1007 Otherwise, CHAR_STRING would do the wrong thing on a 64-bit platform,
1008 by silently ignoring the top 32 bits, allowing some values
1009 that were far too large to be valid characters.
1010 * character.h: Include <verify.h>.
1011 (CHAR_STRING, CHAR_STRING_ADVANCE): Verify that the character
1012 arguments are no wider than unsigned, as a compile-time check
1013 to prevent future regressions in this area.
1014 * data.c (Faset):
01103c44 1015 * editfns.c (Fchar_to_string, general_insert_function, Finsert_char)
13bdea59
PE
1016 (Fsubst_char_in_region):
1017 * fns.c (concat):
1018 * xdisp.c (decode_mode_spec_coding):
1019 Adjust to CHAR_STRING's new requirement.
1020 * editfns.c (Finsert_char, Fsubst_char_in_region):
1021 * fns.c (concat): Check that character args are actually
1022 characters. Without this test, these functions did the wrong
1023 thing with wildly out-of-range values on 64-bit hosts.
1024
d37ca623
PE
1025 Remove incorrect casts to 'unsigned' that lose info on 64-bit hosts.
1026 These casts should not be needed on 32-bit hosts, either.
1027 * keyboard.c (read_char):
1028 * lread.c (Fload): Remove casts to unsigned.
1029
ea204efb
PE
1030 * lisp.h (UNSIGNED_CMP): New macro.
1031 This fixes comparison bugs on 64-bit hosts.
1032 (ASCII_CHAR_P): Use it.
1033 * casefiddle.c (casify_object):
01103c44 1034 * character.h (ASCII_BYTE_P, CHAR_VALID_P)
ea204efb
PE
1035 (SINGLE_BYTE_CHAR_P, CHAR_STRING):
1036 * composite.h (COMPOSITION_ENCODE_RULE_VALID):
1037 * dispextern.h (FACE_FROM_ID):
1038 * keyboard.c (read_char): Use UNSIGNED_CMP.
1039
41cb286c
PE
1040 * xmenu.c (dialog_selection_callback) [!USE_GTK]: Cast to intptr_t,
1041 not to EMACS_INT, to avoid GCC warning.
1042
4a1b9832
PE
1043 * xfns.c (x_set_scroll_bar_default_width): Remove unused 'int' locals.
1044
55daad71
PE
1045 * buffer.h (PTR_BYTE_POS, BUF_PTR_BYTE_POS): Remove harmful cast.
1046 The cast incorrectly truncated 64-bit byte offsets to 32 bits, and
1047 isn't needed on 32-bit machines.
8f95c75c 1048
01103c44
PE
1049 * buffer.c (Fgenerate_new_buffer_name):
1050 Use EMACS_INT for count, not int.
0ceccced 1051 (advance_to_char_boundary): Return EMACS_INT, not int.
e762cafe
PE
1052
1053 * data.c (Qcompiled_function): Now static.
1054
c6f072e7
PE
1055 * window.c (window_body_lines): Now static.
1056
20ce5912
PE
1057 * image.c (gif_load): Rename local to avoid shadowing.
1058
9c4c5f81
PE
1059 * lisp.h (SAFE_ALLOCA_LISP): Check for integer overflow.
1060 (struct Lisp_Save_Value): Use ptrdiff_t, not int, for 'integer' member.
1061 * alloc.c (make_save_value): Integer argument is now of type
1062 ptrdiff_t, not int.
1063 (mark_object): Use ptrdiff_t, not int.
1064 * lisp.h (pD): New macro.
1065 * print.c (print_object): Use it.
1066
c0c5c8ae
PE
1067 * alloc.c: Use EMACS_INT, not int, to count objects.
1068 (total_conses, total_markers, total_symbols, total_vector_size)
1069 (total_free_conses, total_free_markers, total_free_symbols)
01103c44
PE
1070 (total_free_floats, total_floats, total_free_intervals)
1071 (total_intervals, total_strings, total_free_strings):
c0c5c8ae
PE
1072 Now EMACS_INT, not int. All uses changed.
1073 (Fgarbage_collect): Compute overall total using a double, so that
1074 integer overflow is less likely to be a problem. Check for overflow
1075 when converting back to an integer.
5a25e253
PE
1076 (n_interval_blocks, n_string_blocks, n_float_blocks, n_cons_blocks)
1077 (n_vectors, n_symbol_blocks, n_marker_blocks): Remove.
1078 These were 'int' variables that could overflow on 64-bit hosts;
1079 they were never used, so remove them instead of repairing them.
211a0b2a 1080 (nzombies, ngcs, max_live, max_zombies): Now EMACS_INT, not 'int'.
6349ae4d
PE
1081 (inhibit_garbage_collection): Set gc_cons_threshold to max value.
1082 Previously, this ceilinged at INT_MAX, but that doesn't work on
1083 64-bit machines.
e46bb31a 1084 (allocate_pseudovector): Don't use EMACS_INT when int would do.
c0c5c8ae 1085
c78baabf 1086 * alloc.c (Fmake_bool_vector): Don't assume vector size fits in int.
86f61a15 1087 (allocate_vectorlike): Check for ptrdiff_t overflow.
b6439961
PE
1088 (mark_vectorlike, mark_char_table, mark_object): Avoid EMACS_UINT
1089 when a (possibly-narrower) signed value would do just as well.
1090 We prefer using signed arithmetic, to avoid comparison confusion.
c78baabf 1091
c9d624c6
PE
1092 * alloc.c: Catch some string size overflows that we were missing.
1093 (XMALLOC_OVERRUN_CHECK_SIZE) [!XMALLOC_OVERRUN_CHECK]: Define to 0,
1094 for convenience in STRING_BYTES_MAX.
1095 (STRING_BYTES_MAX): New macro, superseding the old one in lisp.h.
1096 The definition here is exact; the one in lisp.h was approximate.
1097 (allocate_string_data): Check for string overflow. This catches
1098 some instances we weren't catching before. Also, it catches
1099 size_t overflow on (unusual) hosts where SIZE_MAX <= min
1100 (PTRDIFF_MAX, MOST_POSITIVE_FIXNUM), e.g., when size_t is 32 bits
1101 and ptrdiff_t and EMACS_INT are both 64 bits.
c78baabf 1102
c9d624c6
PE
1103 * character.c, coding.c, doprnt.c, editfns.c, eval.c:
1104 All uses of STRING_BYTES_MAX replaced by STRING_BYTES_BOUND.
1105 * lisp.h (STRING_BYTES_BOUND): Renamed from STRING_BYTES_MAX.
1106
353032ce
PE
1107 * character.c (string_escape_byte8): Fix nbytes/nchars typo.
1108
2bccce07
PE
1109 * alloc.c (Fmake_string): Check for out-of-range init.
1110
0ac30604
SM
11112011-06-15 Stefan Monnier <monnier@iro.umontreal.ca>
1112
1113 * eval.c (Fdefvaralias): Also mark the target as variable-special-p.
1114
c195f2de
JD
11152011-06-14 Jan Djärv <jan.h.d@swipnet.se>
1116
1117 * xfns.c (x_set_scroll_bar_default_width): Remove argument to
1118 xg_get_default_scrollbar_width.
1119
1120 * gtkutil.c: Include emacsgtkfixed.h if HAVE_GTK3.
1121 (int_gtk_range_get_value): Move to the scroll bar part of the file.
1122 (style_changed_cb): Call update_theme_scrollbar_width and call
1123 x_set_scroll_bar_default_width and xg_frame_set_char_size for
1124 all frames (Bug#8505).
1125 (xg_create_frame_widgets): Call emacs_fixed_new if HAVE_GTK3 (Bug#8505).
1126 Call gtk_window_set_resizable if HAVE_GTK3.
1127 (x_wm_set_size_hint): Call emacs_fixed_set_min_size with min width
1128 and height if HAVE_GTK3 (Bug#8505).
1129 (scroll_bar_width_for_theme): New variable.
1130 (update_theme_scrollbar_width): New function.
1131 (xg_get_default_scrollbar_width): Move code to
1132 update_theme_scrollbar_width, just return scroll_bar_width_for_theme.
1133 (xg_initialize): Call update_theme_scrollbar_width.
1134
1135 * gtkutil.h (xg_get_default_scrollbar_width): Remove argument.
1136
1137 * emacsgtkfixed.c, emacsgtkfixed.h: New files.
1138
e10ac9f1
MR
11392011-06-12 Martin Rudalics <rudalics@gmx.at>
1140
1141 * frame.c (make_frame): Call other_buffer_safely instead of
1142 other_buffer.
1143
1144 * window.c (temp_output_buffer_show): Call display_buffer with
1145 second argument Vtemp_buffer_show_specifiers and reset latter
1146 immediately after the call.
1147 (Vtemp_buffer_show_specifiers): New variable.
1148 (auto_window_vscroll_p, next_screen_context_lines)
1149 (Vscroll_preserve_screen_position): Remove leading asterisks from
1150 doc-strings.
1151
2d3c217e 11522011-06-12 Paul Eggert <eggert@cs.ucla.edu>
4475bec4 1153
7b7f97e8 1154 Fix minor problems found by GCC 4.6.0 static checking.
4475bec4
PE
1155 * buffer.c (Qclone_number): Remove for now, as it's unused.
1156 (record_buffer, Funrecord_buffer): Rename local to avoid shadowing.
1157 (record_buffer): Remove unused local.
1158 * frame.c (other_visible_frames, frame_buffer_list): Now static.
1159 (set_frame_buffer_list): Remove; unused.
1160 * frame.h (other_visible_frames): Remove decl.
1161 * keyboard.h (menu_items_inuse): Declare only if USE_GTK || USE_MOTIF.
1162 * lisp.h (frame_buffer_list, set_frame_buffer_list): Remove decls.
1163 (add_gpm_wait_descriptor, delete_gpm_wait_descriptor): Declare only
1164 if HAVE_GPM.
1165 * menu.c (menu_items_inuse): Now static unless USE_GTK || USE_MOTIF.
1166 * process.c (add_gpm_wait_descriptor, delete_gpm_wait_descriptor):
1167 Define only if HAVE_GPM.
1168 * widget.c (EmacsFrameResize, emacsFrameClassRec): Now static.
1169 (update_hints_inhibit): Remove; never set. All uses removed.
1170 * widgetprv.h (emacsFrameClassRec): Remove decl.
1171 * window.c (delete_deletable_window): Now returns void, since it
1172 wasn't returning anything.
1173 (compare_window_configurations): Remove unused locals.
1174 * xfns.c (x_set_scroll_bar_default_width): Remove unused locals.
1175 * xmenu.c (x_menu_set_in_use): Define only if USE_GTK || USE_MOTIF.
4475bec4
PE
1176 (dialog_selection_callback) [!USE_GTK]: Prefer intptr_t for integers
1177 the same widths as pointers. This follows up on the 2011-05-06 patch.
1178 * xterm.c (x_alloc_lighter_color_for_widget): Define only if USE_LUCID.
1179 * xterm.h: Likewise.
1180 (x_menu_set_in_use): Declare only if USE_GTK || USE_MOTIF.
1181
1384b89e
JB
11822011-06-12 Juanma Barranquero <lekktu@gmail.com>
1183
1184 * makefile.w32-in: Update dependencies.
1185 (LISP_H): Add lib/intprops.h.
1186
1100a63c
CY
11872011-06-11 Chong Yidong <cyd@stupidchicken.com>
1188
1189 * image.c (gif_load): Add animation frame delay to the metadata.
1190 (syms_of_image): Use DEFSYM. New symbol `delay'.
1191
6198ccd0
MR
11922011-06-11 Martin Rudalics <rudalics@gmx.at>
1193
1194 * window.c (delete_deletable_window): Re-add.
1195 (Fset_window_configuration): Rewrite to handle dead buffers and
1196 consequently deletable windows.
1197 (window_tree, Fwindow_tree): Remove. Supply functionality in
1198 window.el.
1199 (compare_window_configurations): Simplify code.
1200
b6e3633c
AS
12012011-06-11 Andreas Schwab <schwab@linux-m68k.org>
1202
1ab0dee5
AS
1203 * image.c (imagemagick_load_image): Fix type mismatch.
1204 (Fimagemagick_types): Likewise.
1205
b6e3633c
AS
1206 * window.h (replace_buffer_in_windows): Declare.
1207
9397e56f
MR
12082011-06-11 Martin Rudalics <rudalics@gmx.at>
1209
1210 * buffer.c: New Lisp objects Qbuffer_list_update_hook and
1211 Qclone_number. Remove external declaration of Qdelete_window.
1212 (Fbuffer_list): Rewrite doc-string. Minor restructuring of
1213 code.
1214 (Fget_buffer_create, Fmake_indirect_buffer, Frename_buffer): Run
1215 Qbuffer_list_update_hook if allowed.
1216 (Fother_buffer): Rewrite doc-string. Major rewrite for new
1217 buffer list implementation.
1218 (other_buffer_safely): New function.
1219 (Fkill_buffer): Replace call to replace_buffer_in_all_windows by
1220 calls to replace_buffer_in_windows and
1221 replace_buffer_in_windows_safely. Run Qbuffer_list_update_hook
1222 if allowed.
1223 (record_buffer): Inhibit quitting and rewrite using quittable
1224 functions. Run Qbuffer_list_update_hook if allowed.
1225 (Frecord_buffer, Funrecord_buffer): New functions.
1226 (switch_to_buffer_1, Fswitch_to_buffer): Remove. Move
1227 switch-to-buffer to window.el.
1228 (bury-buffer): Move to window.el.
1229 (Vbuffer_list_update_hook): New variable.
1230
1231 * lisp.h (other_buffer_safely): Add prototype in buffer.c
1232 section.
1233
1234 * window.h (resize_frame_windows): Move up in code.
1235 (Fwindow_frame): Remove EXFUN.
1236 (replace_buffer_in_all_windows): Remove prototype.
1237 (replace_buffer_in_windows_safely): Add prototype.
1238
1239 * window.c: Declare Qdelete_window static again. Move down
1240 declaration of select_count.
1241 (Fnext_window, Fprevious_window): Rewrite doc-strings.
1242 (Fother_window): Move to window.el.
1243 (window_loop): Remove DELETE_BUFFER_WINDOWS and UNSHOW_BUFFER
1244 cases. Add REPLACE_BUFFER_IN_WINDOWS_SAFELY case.
1245 (Fdelete_windows_on, Freplace_buffer_in_windows): Move to
1246 window.el.
1247 (replace_buffer_in_windows): Implement by calling
1248 Qreplace_buffer_in_windows.
1249 (replace_buffer_in_all_windows): Remove with some functionality
1250 moved into replace_buffer_in_windows_safely.
1251 (replace_buffer_in_windows_safely): New function.
1252 (select_window_norecord, select_frame_norecord): Move in front
1253 of run_window_configuration_change_hook. Remove now obsolete
1254 declarations.
1255 (Fset_window_buffer): Rewrite doc-string. Call
1256 Qrecord_window_buffer.
1257 (keys_of_window): Move binding for other-window to window.el.
1258
b50691aa
CY
12592011-06-11 Chong Yidong <cyd@stupidchicken.com>
1260
1261 * dispextern.h (struct image): Replace data member, whose int_val
1262 and ptr_val fields were not used by anything, with a single
1263 lisp_val object.
1264
1265 * image.c (Fimage_metadata, make_image, mark_image, tiff_load)
1266 (gif_clear_image, gif_load, imagemagick_load_image)
1267 (gs_clear_image, gs_load): Callers changed.
1268
3f754b86
PE
12692011-06-10 Paul Eggert <eggert@cs.ucla.edu>
1270
cca69397
PE
1271 * buffer.h: Include <time.h>, for time_t.
1272 Needed to build on FreeBSD 8.2. Problem reported by Herbert J. Skuhra.
1273
109e28d0
PE
1274 Fix minor problems found by static checking.
1275
60737f02
PE
1276 * image.c (PixelGetMagickColor): Declare if ImageMagick headers don't.
1277
4b66faf3
PE
1278 Make identifiers static if they are not used in other modules.
1279 * data.c (Qcompiled_function, Qframe, Qvector):
1280 * image.c (QimageMagick, Qsvg):
1281 * minibuf.c (Qmetadata):
1282 * window.c (resize_window_check, resize_root_window): Now static.
1283 * window.h (resize_window_check, resize_root_window): Remove decls.
1284
109e28d0
PE
1285 * window.c (window_deletion_count, delete_deletable_window):
1286 Remove; unused.
46a4ce9e
PE
1287 (window_body_lines): Now static.
1288 (Fdelete_other_windows_internal): Mark vars as initialized.
1289 Make sure 'resize_failed' is initialized.
1290 (run_window_configuration_change_hook): Rename local to avoid shadowing.
1291 (resize_window_apply): Remove unused local.
1292 * window.h (delete_deletable_window): Remove decl.
1293
109e28d0 1294 * image.c (gif_load, svg_load_image): Rename locals to avoid shadowing.
33290528
PE
1295 (imagemagick_load_image): Fix pointer signedness problem by changing
1296 last arg from unsigned char * to char *. All uses changed.
1297 Also, fix a local for similar reasons.
1298 Remove unused locals. Remove locals to avoid shadowing.
1299 (fn_rsvg_handle_free): Remove; unused.
1300 (svg_load, svg_load_image): Fix pointer signedness problem.
f7e13da3 1301 (imagemagick_load_image): Don't use garbage pointer image_wand.
33290528 1302
3f754b86
PE
1303 * ftfont.c (ftfont_get_metrics, ftfont_drive_otf): Remove unused locals.
1304
2547adb1
CY
13052011-06-10 Chong Yidong <cyd@stupidchicken.com>
1306
1307 * image.c (gif_load): Fix omitted cast error introduced by
1308 2011-06-06 change.
1309
2c8e37d4
MR
13102011-06-10 Martin Rudalics <rudalics@gmx.at>
1311
1312 * window.h (resize_proportionally, orig_total_lines)
1313 (orig_top_line): Remove from window structure.
1314 (set_window_height, set_window_width, change_window_heights)
1315 (Fdelete_window): Remove prototypes.
1316 (resize_frame_windows): Remove duplicate declaration.
1317
440a42e3
EZ
13182011-06-10 Eli Zaretskii <eliz@gnu.org>
1319
1320 * window.h (resize_frame_windows, resize_window_check)
1321 (delete_deletable_window, resize_root_window)
1322 (resize_frame_windows): Declare prototypes.
1323
1324 * window.c (resize_window_apply): Make definition be "static" to
1325 match the prototype.
1326
562dd5e9
MR
13272011-06-10 Martin Rudalics <rudalics@gmx.at>
1328
1329 * window.c: Remove declarations of Qwindow_size_fixed,
1330 window_min_size_1, window_min_size_2, window_min_size,
1331 size_window, window_fixed_size_p, enlarge_window, delete_window.
1332 Remove static from declaration of Qdelete_window, it's
1333 temporarily needed by Fbury_buffer.
1334 (replace_window): Don't assign orig_top_line and
1335 orig_total_lines.
1336 (Fdelete_window, delete_window): Remove. Window deletion is
1337 handled by window.el.
1338 (window_loop): Remove DELETE_OTHER_WINDOWS case. Replace
1339 Fdelete_window calls with calls to Qdelete_window.
1340 (Fdelete_other_windows): Remove. Deleting other windows is
1341 handled by window.el.
1342 (window_fixed_size_p): Remove. Fixed-sizeness of windows is
1343 handled in window.el.
1344 (window_min_size_2, window_min_size_1, window_min_size): Remove.
1345 Window minimum sizes are handled in window.el.
1346 (shrink_windows, size_window, set_window_height)
1347 (set_window_width, change_window_heights, window_height)
1348 (window_width, CURBEG, CURSIZE, enlarge_window)
1349 (adjust_window_trailing_edge, Fadjust_window_trailing_edge)
1350 (Fenlarge_window, Fshrink_window): Remove. Window resizing is
1351 handled in window.el.
1352 (make_dummy_parent): Rename to make_parent_window and give it a
1353 second argument horflag.
1354 (make_window): Don't set resize_proportionally any more.
1355 (Fsplit_window): Remove. Windows are split in window.el.
1356 (save_restore_action, save_restore_orig_size)
1357 (shrink_window_lowest_first, save_restore_orig_size): Remove.
1358 Resize mini windows in window.el.
1359 (grow_mini_window, shrink_mini_window): Implement by calling
1360 Qresize_root_window_vertically, resize_window_check and
1361 resize_window_apply.
1362 (saved_window, Fset_window_configuration, save_window_save): Do
1363 not handle orig_top_line, orig_total_lines, and
1364 resize_proportionally.
1365 (window_min_height, window_min_width): Move to window.el.
1366 (keys_of_window): Move bindings for delete-other-windows,
1367 split-window, delete-window and enlarge-window to window.el.
1368
1369 * buffer.c: Temporarily extern Qdelete_window.
1370 (Fbury_buffer): Temporarily call Qdelete_window instead of
1371 Fdelete_window (Fbury_buffer will move to window.el soon).
1372
1373 * frame.c (set_menu_bar_lines_1): Remove code handling
1374 orig_top_line and orig_total_lines.
1375
1376 * dispnew.c (adjust_frame_glyphs_initially): Don't use
1377 set_window_height but set heights directly.
1378 (change_frame_size_1): Use resize_frame_windows.
1379
1380 * xdisp.c (init_xdisp): Don't use set_window_height but set
1381 heights directly.
1382
1383 * xfns.c (x_set_menu_bar_lines, x_set_tool_bar_lines): Use
1384 resize_frame_windows instead of change_window_heights and run
1385 run_window_configuration_change_hook.
1386
1387 * w32fns.c (x_set_tool_bar_lines): Use resize_frame_windows
1388 instead of change_window_heights and run
1389 run_window_configuration_change_hook.
1390
1a13852e
MR
13912011-06-09 Martin Rudalics <rudalics@gmx.at>
1392
1393 * window.c (replace_window): Rename second argument REPLACEMENT to
1394 NEW. New third argument SETFLAG. Rewrite.
1395 (delete_window, make_dummy_parent): Call replace_window with
1396 third argument 1.
1397 (window_list_1): Move down in code.
1398 (run_window_configuration_change_hook): Move set_buffer part
1399 before select_frame_norecord part in order to unwind correctly.
1400 Rename count1 to count.
1401 (recombine_windows, delete_deletable_window, resize_root_window)
1402 (Fdelete_other_windows_internal)
1403 (Frun_window_configuration_change_hook, make_parent_window)
1404 (resize_window_check, resize_window_apply, Fresize_window_apply)
1405 (resize_frame_windows, Fsplit_window_internal)
1406 (Fdelete_window_internal, Fresize_mini_window_internal): New
1407 functions.
1408 (syms_of_window): New variables Vwindow_splits and Vwindow_nest.
1409
f3d1777e
MR
14102011-06-08 Martin Rudalics <rudalics@gmx.at>
1411
496e208e
MR
1412 * window.h (window): Add some new members to window structure -
1413 normal_lines, normal_cols, new_total, new_normal, clone_number,
1414 splits, nest, prev_buffers, next_buffers.
1415 (WINDOW_TOTAL_SIZE): Move here from window.c.
b9e809c2 1416 (MIN_SAFE_WINDOW_WIDTH, MIN_SAFE_WINDOW_HEIGHT): Define here.
496e208e 1417
f3d1777e
MR
1418 * window.c (Fwindow_height, Fwindow_width, Fwindow_full_width_p):
1419 Remove.
496e208e
MR
1420 (make_dummy_parent): Set new members of windows structure.
1421 (make_window): Move down in code. Handle new members of window
1422 structure.
1423 (Fwindow_clone_number, Fwindow_splits, Fset_window_splits)
1424 (Fwindow_nest, Fset_window_nest, Fwindow_new_total)
1425 (Fwindow_normal_size, Fwindow_new_normal, Fwindow_prev_buffers)
1426 (Fset_window_prev_buffers, Fwindow_next_buffers)
1427 (Fset_window_next_buffers, Fset_window_clone_number): New
1428 functions.
1429 (Fwindow_hscroll, Fwindow_at, Fwindow_point, Fwindow_start)
1430 (Fwindow_end, Fwindow_line_height, Fset_window_dedicated_p):
1431 Doc-string fixes.
1432 (Fwindow_parameters, Fwindow_parameter, Fset_window_parameter):
1433 Argument WINDOW can be now internal window too.
1434 (Fwindow_use_time): Move up in code.
1435 (Fget_buffer_window): Rename argument FRAME to ALL-FRAMES.
1436 Rewrite doc-string.
1437 (Fset_window_configuration, saved_window)
1438 (Fcurrent_window_configuration, save_window_save): Handle new
1439 members of window structure.
b9e809c2
MR
1440 (WINDOW_TOTAL_SIZE, MIN_SAFE_WINDOW_WIDTH)
1441 (MIN_SAFE_WINDOW_HEIGHT): Move to window.h.
1442 (syms_of_window): New Lisp objects Qrecord_window_buffer,
1443 Qwindow_deletable_p, Qdelete_window, Qreplace_buffer_in_windows,
1444 Qget_mru_window, Qresize_root_window,
1445 Qresize_root_window_vertically, Qsafe, Qabove, Qbelow,
1446 Qauto_buffer_name; staticpro them.
f3d1777e 1447
abde8f8c
MR
14482011-06-07 Martin Rudalics <rudalics@gmx.at>
1449
1450 * window.c (Fwindow_total_size, Fwindow_left_column)
1451 (Fwindow_top_line, window_body_lines, Fwindow_body_size)
1452 (Fwindow_list_1): New functions.
1453 (window_box_text_cols): Replace with window_body_cols.
1454 (Fwindow_width, Fscroll_left, Fscroll_right): Use
1455 window_body_cols instead of window_box_text_cols.
fa8a67e6
MR
1456 (delete_window, Fset_window_configuration): Call
1457 delete_all_subwindows with window as argument.
1458 (delete_all_subwindows): Take a window as argument and not a
1459 structure. Rewrite.
190b47e6
MR
1460 (window_loop): Remove handling of GET_LRU_WINDOW and
1461 GET_LARGEST_WINDOW.
1462 (Fget_lru_window, Fget_largest_window): Move to window.el.
abde8f8c
MR
1463
1464 * window.h: Extern window_body_cols instead of
fa8a67e6
MR
1465 window_box_text_cols. delete_all_subwindows now takes a
1466 Lisp_Object as argument.
abde8f8c
MR
1467
1468 * indent.c (compute_motion, Fcompute_motion): Use
1469 window_body_cols instead of window_box_text_cols.
1470
fa8a67e6
MR
1471 * frame.c (delete_frame): Call delete_all_subwindows with root
1472 window as argument.
1473
a54e3482
DC
14742011-06-07 Daniel Colascione <dan.colascione@gmail.com>
1475
1476 * fns.c (Fputhash): Document return value.
1477
60002bf5
CY
14782011-06-06 Chong Yidong <cyd@stupidchicken.com>
1479
1480 * image.c (gif_load): Implement gif89a spec "no disposal" method.
1481
0c671da6 14822011-06-06 Paul Eggert <eggert@cs.ucla.edu>
ccd9a01a 1483
b862a52a 1484 Cons<->int and similar integer overflow fixes (Bug#8794).
77984278 1485
be44ca6c
PE
1486 Check for overflow when converting integer to cons and back.
1487 * charset.c (Fdefine_charset_internal, Fdecode_char):
1488 Use cons_to_unsigned to catch overflow.
1489 (Fencode_char): Use INTEGER_TO_CONS.
1490 * composite.h (LGLYPH_CODE): Use cons_to_unsigned.
1491 (LGLYPH_SET_CODE): Use INTEGER_TO_CONS.
1492 * data.c (long_to_cons, cons_to_long): Remove.
1493 (cons_to_unsigned, cons_to_signed): New functions.
1494 These signal an error for invalid or out-of-range values.
1495 * dired.c (Ffile_attributes): Use INTEGER_TO_CONS.
1496 * fileio.c (Fset_visited_file_modtime): Use CONS_TO_INTEGER.
1497 * font.c (Ffont_variation_glyphs):
1498 * fontset.c (Finternal_char_font): Use INTEGER_TO_CONS.
1499 * lisp.h: Include <intprops.h>.
1500 (INTEGER_TO_CONS, CONS_TO_INTEGER): New macros.
1501 (cons_to_signed, cons_to_unsigned): New decls.
1502 (long_to_cons, cons_to_long): Remove decls.
1503 * undo.c (record_first_change): Use INTEGER_TO_CONS.
1504 (Fprimitive_undo): Use CONS_TO_INTEGER.
1505 * xfns.c (Fx_window_property): Likewise.
1506 * xselect.c: Include <limits.h>.
1507 (x_own_selection, selection_data_to_lisp_data):
1508 Use INTEGER_TO_CONS.
1509 (x_handle_selection_request, x_handle_selection_clear)
1510 (x_get_foreign_selection, Fx_disown_selection_internal)
1511 (Fx_get_atom_name, x_send_client_event): Use CONS_TO_INTEGER.
1512 (lisp_data_to_selection_data): Use cons_to_unsigned.
1513 (x_fill_property_data): Use cons_to_signed.
1514 Report values out of range.
1515
d1f3d2af
PE
1516 Check for buffer and string overflow more precisely.
1517 * buffer.h (BUF_BYTES_MAX): New macro.
1518 * lisp.h (STRING_BYTES_MAX): New macro.
1519 * alloc.c (Fmake_string):
1520 * character.c (string_escape_byte8):
1521 * coding.c (coding_alloc_by_realloc):
1522 * doprnt.c (doprnt):
1523 * editfns.c (Fformat):
1524 * eval.c (verror):
1525 Use STRING_BYTES_MAX, not MOST_POSITIVE_FIXNUM,
1526 since they may not be the same number.
1527 * editfns.c (Finsert_char):
1528 * fileio.c (Finsert_file_contents):
1529 Likewise for BUF_BYTES_MAX.
1530
dd52fcea
PE
1531 * image.c: Use ptrdiff_t, not int, for sizes.
1532 (slurp_file): Switch from int to ptrdiff_t.
1533 All uses changed.
1534 (slurp_file): Check that file size fits in both size_t (for
1535 malloc) and ptrdiff_t (for sanity and safety).
1536
7f9bbdbb
PE
1537 * fileio.c (Fverify_visited_file_modtime): Avoid time overflow
1538 if b->modtime has its maximal value.
1539
dfe18f82
PE
1540 * dired.c (Ffile_attributes): Don't assume EMACS_INT has >32 bits.
1541
84acfcf0
PE
1542 Don't assume time_t can fit into int.
1543 * buffer.h (struct buffer.modtime): Now time_t, not int.
1544 * fileio.c (Fvisited_file_modtime): No need for time_t cast now.
1545 * undo.c (Fprimitive_undo): Use time_t, not int, for time_t value.
1546
ccd9a01a
PE
1547 Minor fixes for signed vs unsigned integers.
1548 * character.h (MAYBE_UNIFY_CHAR):
1549 * charset.c (maybe_unify_char):
1550 * keyboard.c (read_char, reorder_modifiers):
1551 XINT -> XFASTINT, since the integer must be nonnegative.
1552 * ftfont.c (ftfont_spec_pattern):
1553 * keymap.c (access_keymap, silly_event_symbol_error):
1554 XUINT -> XFASTINT, since the integer must be nonnegative.
1555 (Fsingle_key_description, preferred_sequence_p): XUINT -> XINT,
1556 since it makes no difference and we prefer signed.
1557 * keyboard.c (record_char): Use XUINT when all the neighbors do.
1558 (access_keymap): NATNUMP -> INTEGERP, since the integer must be
1559 nonnegative.
1560
d6d100dd
SM
15612011-06-06 Stefan Monnier <monnier@iro.umontreal.ca>
1562
1563 * window.h (Fwindow_frame): Declare.
1564
2b6148e4
PE
15652011-06-06 Paul Eggert <eggert@cs.ucla.edu>
1566
1567 * alloc.c: Simplify handling of large-request failures (Bug#8800).
1568 (SPARE_MEMORY): Always define.
1569 (LARGE_REQUEST): Remove.
1570 (memory_full): Use SPARE_MEMORY rather than LARGE_REQUEST.
1571
f230ecc9
MR
15722011-06-06 Martin Rudalics <rudalics@gmx.at>
1573
727e958e
MR
1574 * lisp.h: Move EXFUNS for Fframe_root_window,
1575 Fframe_first_window and Fset_frame_selected_window to window.h.
1576
1577 * window.h: Move EXFUNS for Fframe_root_window,
1578 Fframe_first_window and Fset_frame_selected_window here from
1579 lisp.h.
1580
1581 * frame.c (Fwindow_frame, Fframe_first_window)
1582 (Fframe_root_window, Fframe_selected_window)
1583 (Fset_frame_selected_window): Move to window.c.
1584 (Factive_minibuffer_window): Move to minibuf.c.
1585 (Fother_visible_frames_p): New function.
1586
1587 * minibuf.c (Factive_minibuffer_window): Move here from frame.c.
1588
f230ecc9
MR
1589 * window.c (decode_window, decode_any_window): Move up in code.
1590 (Fwindowp, Fwindow_live_p): Rewrite doc-strings.
1591 (inhibit_frame_unsplittable): Remove unused variable.
bf60a96b
MR
1592 (Fwindow_buffer): Move up and rewrite doc-string.
1593 (Fwindow_parent, Fwindow_vchild, Fwindow_hchild, Fwindow_next)
1594 (Fwindow_prev): New functions.
727e958e
MR
1595 (Fwindow_frame): Move here from frame.c. Accept any window as
1596 argument.
1597 (Fframe_root_window, Fframe_first_window)
1598 (Fframe_selected_window): Move here from frame.c. Accept frame
1599 or arbitrary window as argument. Update doc-strings.
1600 (Fminibuffer_window): Move up in code.
1601 (Fwindow_minibuffer_p): Move up in code and simplify.
d6d100dd
SM
1602 (Fset_frame_selected_window): Move here from frame.c.
1603 Marginal rewrite.
727e958e
MR
1604 (Fselected_window, select_window, Fselect_window): Move up in
1605 code. Minor doc-string fixes.
f230ecc9 1606
4d09bcf6
PE
16072011-06-06 Paul Eggert <eggert@cs.ucla.edu>
1608
1609 * alloc.c (memory_full) [SYSTEM_MALLOC]: Port to MacOS (Bug#8800).
1610 Do not assume that spare memory exists; that assumption is valid
1611 only if SYSTEM_MALLOC.
1612 (LARGE_REQUEST): New macro, so that the issue of large requests
1613 is separated from the issue of spare memory.
1614
810928a2
AS
16152011-06-05 Andreas Schwab <schwab@linux-m68k.org>
1616
172418ad
AS
1617 * editfns.c (Fformat): Correctly handle zero flag with hexadecimal
1618 format. (Bug#8806)
1619
43f862f7
AS
1620 * gtkutil.c (xg_get_default_scrollbar_width): Avoid warning.
1621
810928a2
AS
1622 * xfns.c (x_set_scroll_bar_default_width): Move declarations
1623 before statements.
1624
a059fe24
JD
16252011-06-05 Jan Djärv <jan.h.d@swipnet.se>
1626
1627 * gtkutil.c (xg_get_default_scrollbar_width): New function.
1628
1629 * gtkutil.h: Declare xg_get_default_scrollbar_width.
1630
1631 * xfns.c (x_set_scroll_bar_default_width): If USE_GTK, get
1632 min width by calling x_set_scroll_bar_default_width (Bug#8505).
1633
989bf368
JB
16342011-06-05 Juanma Barranquero <lekktu@gmail.com>
1635
1636 * xdisp.c (single_display_spec_intangible_p): Remove declaration.
1637
4b80f674
CY
16382011-06-04 Chong Yidong <cyd@stupidchicken.com>
1639
1640 * xselect.c (x_clipboard_manager_save): Remove redundant arg.
1641 (x_clipboard_manager_save): Add return value.
d6d100dd
SM
1642 (x_clipboard_manager_error_1, x_clipboard_manager_error_2):
1643 New error handlers.
4b80f674
CY
1644 (x_clipboard_manager_save_frame, x_clipboard_manager_save_all):
1645 Obey Vx_select_enable_clipboard_manager. Catch errors in
1646 x_clipboard_manager_save (Bug#8779).
1647 (Vx_select_enable_clipboard_manager): New variable.
de65b42c 1648 (x_get_foreign_selection): Reduce scope of x_catch_errors (Bug#8790).
4b80f674 1649
99a33b77 16502011-06-04 Dan Nicolaescu <dann@ics.uci.edu>
8b3115e7
DN
1651
1652 * emacs.c (main): Warn when starting a GTK emacs in daemon mode.
1653
99a33b77 16542011-06-04 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
14eca62f
YM
1655
1656 * fringe.c (update_window_fringes): Don't update overlay arrow bitmap
1657 in the current matrix if keep_current_p is non-zero.
1658
8264569d
EZ
16592011-06-04 Eli Zaretskii <eliz@gnu.org>
1660
1661 * bidi.c (bidi_level_of_next_char): Fix last change.
1662
57f97249
EZ
16632011-06-03 Eli Zaretskii <eliz@gnu.org>
1664
fec2107c 1665 Support bidi reordering of text covered by display properties.
57f97249 1666
fec2107c
EZ
1667 * bidi.c (bidi_copy_it): Use offsetof instead of emulating it.
1668 (bidi_fetch_char, bidi_fetch_char_advance): New functions.
1669 (bidi_cache_search, bidi_cache_iterator_state)
1670 (bidi_paragraph_init, bidi_resolve_explicit, bidi_resolve_weak)
d6d100dd
SM
1671 (bidi_level_of_next_char, bidi_move_to_visually_next):
1672 Support character positions inside a run of characters covered by a
fec2107c
EZ
1673 display string.
1674 (bidi_paragraph_init, bidi_resolve_explicit_1)
1675 (bidi_level_of_next_char): Call bidi_fetch_char and
1676 bidi_fetch_char_advance instead of FETCH_CHAR and
1677 FETCH_CHAR_ADVANCE.
1678 (bidi_init_it): Initialize new members.
1679 (LRE_CHAR, RLE_CHAR, PDF_CHAR, LRO_CHAR, RLO_CHAR): Remove macro
1680 definitions.
1681 (bidi_explicit_dir_char): Lookup character type in bidi_type_table,
1682 instead of using explicit *_CHAR codes.
d6d100dd
SM
1683 (bidi_resolve_explicit, bidi_resolve_weak):
1684 Use FETCH_MULTIBYTE_CHAR instead of FETCH_CHAR, as reordering of
fec2107c
EZ
1685 bidirectional text is supported only in multibyte buffers.
1686 (bidi_init_it): Accept additional argument FRAME_WINDOW_P and use
1687 it to initialize the frame_window_p member of struct bidi_it.
1688 (bidi_cache_iterator_state, bidi_resolve_explicit_1)
1689 (bidi_resolve_explicit, bidi_resolve_weak)
1690 (bidi_level_of_next_char, bidi_move_to_visually_next): Abort if
1691 bidi_it->nchars is non-positive.
1692 (bidi_level_of_next_char): Don't try to lookup the cache for the
1693 next/previous character if nothing is cached there yet, or if we
1694 were just reseat()'ed to a new position.
c40e2fb2 1695
0e14fe90
EZ
1696 * xdisp.c (set_cursor_from_row): Set start and stop points
1697 according to the row's direction when priming the loop that looks
1698 for the glyph on which to display cursor.
1699 (single_display_spec_intangible_p): Function deleted.
1700 (display_prop_intangible_p): Reimplement to call
1701 handle_display_spec instead of single_display_spec_intangible_p.
d6d100dd
SM
1702 Accept 3 additional arguments needed by handle_display_spec.
1703 This fixes incorrect cursor motion across display property with complex
0e14fe90
EZ
1704 values: lists, `(when COND...)' forms, etc.
1705 (single_display_spec_string_p): Support property values that are
1706 lists with the argument STRING its top-level element.
1707 (display_prop_string_p): Fix the condition for processing a
1708 property that is a list to be consistent with handle_display_spec.
fec2107c 1709 (handle_display_spec): New function, refactored from the
fc6f18ce
EZ
1710 last portion of handle_display_prop.
1711 (compute_display_string_pos): Accept additional argument
1712 FRAME_WINDOW_P. Call handle_display_spec to determine whether the
1713 value of a `display' property is a "replacing spec".
1714 (handle_single_display_spec): Accept 2 additional arguments BUFPOS
1715 and FRAME_WINDOW_P. If IT is NULL, don't set up the iterator from
1716 the display property, but just return a value indicating whether
1717 the display property will replace the characters it covers.
1718 (Fcurrent_bidi_paragraph_direction): Initialize the nchars and
1719 frame_window_p members of struct bidi_it.
d6d100dd
SM
1720 (compute_display_string_pos, compute_display_string_end):
1721 New functions.
fec2107c
EZ
1722 (push_it): Accept second argument POSITION, where pop_it should
1723 jump to continue iteration.
1724 (reseat_1): Initialize bidi_it.disp_pos.
fc6f18ce 1725
fec2107c
EZ
1726 * keyboard.c (adjust_point_for_property): Adjust the call to
1727 display_prop_intangible_p to its new signature.
fc6f18ce
EZ
1728
1729 * dispextern.h (struct bidi_it): New member frame_window_p.
fec2107c
EZ
1730 (bidi_init_it): Update prototypes.
1731 (display_prop_intangible_p): Update prototype.
d6d100dd
SM
1732 (compute_display_string_pos, compute_display_string_end):
1733 Declare prototypes.
fec2107c
EZ
1734 (struct bidi_it): New members nchars and disp_pos. ch_len is now
1735 EMACS_INT.
fc6f18ce 1736
40087514 17372011-06-02 Paul Eggert <eggert@cs.ucla.edu>
0de4bb68 1738
57f53182
PE
1739 Malloc failure behavior now depends on size of allocation.
1740 * alloc.c (buffer_memory_full, memory_full): New arg NBYTES.
1741 * lisp.h: Change signatures accordingly.
1742 * alloc.c, buffer.c, editfns.c, menu.c, minibuf.c, xterm.c:
1743 All callers changed. (Bug#8762)
1744
1745 * gnutls.c: Use Emacs's memory allocators.
1746 Without this change, the gnutls library would invoke malloc etc.
1747 directly, which causes problems on non-SYNC_INPUT hosts, and which
1748 runs afoul of improving memory_full behavior. (Bug#8761)
1749 (fn_gnutls_global_set_mem_functions): New macro or function pointer.
1750 (emacs_gnutls_global_init): Use it to specify xmalloc, xrealloc,
1751 xfree instead of the default malloc, realloc, free.
1752 (Fgnutls_boot): No need to check for memory allocation failure,
1753 since xmalloc does that for us.
1754
ac32cd99 1755 Remove arbitrary limit of 2**31 entries in hash tables. (Bug#8771)
3870d916
PE
1756 * category.c (hash_get_category_set):
1757 * ccl.c (ccl_driver):
1758 * charset.c (Fdefine_charset_internal):
1759 * charset.h (struct charset.hash_index):
1760 * composite.c (get_composition_id, gstring_lookup_cache)
1761 (composition_gstring_put_cache):
1762 * composite.h (struct composition.hash_index):
1763 * dispextern.h (struct image.hash):
1764 * fns.c (next_almost_prime, larger_vector, cmpfn_eql)
1765 (cmpfn_equal, cmpfn_user_defined, hashfn_eq, hashfn_eql)
1766 (hashfn_equal, hashfn_user_defined, make_hash_table)
1767 (maybe_resize_hash_table, hash_lookup, hash_put)
1768 (hash_remove_from_table, hash_clear, sweep_weak_table, SXHASH_COMBINE)
1769 (sxhash_string, sxhash_list, sxhash_vector, sxhash_bool_vector)
1770 (Fsxhash, Fgethash, Fputhash, Fmaphash):
1771 * image.c (make_image, search_image_cache, lookup_image)
1772 (xpm_put_color_table_h):
1773 * lisp.h (struct Lisp_Hash_Table):
0de4bb68 1774 * minibuf.c (Ftry_completion, Fall_completions, Ftest_completion):
3870d916
PE
1775 * print.c (print): Use 'EMACS_UINT' and 'EMACS_INT'
1776 for hashes and hash indexes, instead of 'unsigned' and 'int'.
40087514
PE
1777 * alloc.c (allocate_vectorlike):
1778 Check for overflow in vector size calculations.
1779 * ccl.c (ccl_driver):
1780 Check for overflow when converting EMACS_INT to int.
0de4bb68
PE
1781 * fns.c, image.c: Remove unnecessary static decls that would otherwise
1782 need to be updated by these changes.
40087514
PE
1783 * fns.c (make_hash_table, maybe_resize_hash_table):
1784 Check for integer overflow with large hash tables.
0de4bb68
PE
1785 (make_hash_table, maybe_resize_hash_table, Fmake_hash_table):
1786 Prefer the faster XFLOAT_DATA to XFLOATINT where either will do.
1787 (SXHASH_REDUCE): New macro.
1788 (sxhash_string, sxhash_list, sxhash_vector, sxhash_bool_vector):
1789 Use it instead of discarding useful hash info with large hash values.
1790 (sxhash_float): New function.
1791 (sxhash): Use it. No more need for "& INTMASK" due to above changes.
1792 * lisp.h (FIXNUM_BITS): New macro, useful for SXHASH_REDUCE etc.
40087514
PE
1793 (MOST_NEGATIVE_FIXNUM, MOST_POSITIVE_FIXNUM, INTMASK):
1794 Rewrite to use FIXNUM_BITS, as this simplifies things.
0de4bb68
PE
1795 (next_almost_prime, larger_vector, sxhash, hash_lookup, hash_put):
1796 Adjust signatures to match updated version of code.
1797 (consing_since_gc): Now EMACS_INT, since a single hash table can
1798 use more than INT_MAX bytes.
1799
698d32e2
DN
18002011-06-01 Dan Nicolaescu <dann@ics.uci.edu>
1801
1802 Make it possible to build with GCC-4.6+ -O2 -flto.
1803
1804 * emacs.c (__malloc_initialize_hook): Mark as EXTERNALLY_VISIBLE.
1805
fd6fa53f
SM
18062011-06-01 Stefan Monnier <monnier@iro.umontreal.ca>
1807
1808 * minibuf.c (get_minibuffer, read_minibuf_unwind):
1809 Call minibuffer-inactive-mode.
1810
864db017
JB
18112011-05-31 Juanma Barranquero <lekktu@gmail.com>
1812
1813 * makefile.w32-in ($(BLD)/data.$(O), $(BLD)/editfns.$(O)):
1814 Update dependencies.
1815
2ad0baf4
DN
18162011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
1817
1818 * data.c (init_data): Remove code for UTS, this system is not
1819 supported anymore.
1820
4fcc2638
DN
18212011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
1822
1823 Don't force ./temacs to start in terminal mode.
1824
1825 * frame.c (make_initial_frame): Initialize faces in all cases, not
1826 only when CANNOT_DUMP is defined.
1827 * dispnew.c (init_display): Remove CANNOT_DUMP condition.
1828
c56e0fd5
DN
18292011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
1830
1831 * dispnew.c (add_window_display_history): Use const for the string
1832 pointer. Remove declaration, not needed.
1833
333d54da 18342011-05-31 Paul Eggert <eggert@cs.ucla.edu>
9cf9f756 1835
55d4c1b2 1836 Use 'inline', not 'INLINE'.
333d54da 1837 <http://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00914.html>
55d4c1b2
PE
1838 * alloc.c, fontset.c (INLINE): Remove.
1839 * alloc.c, bidi.c, charset.c, coding.c, dispnew.c, fns.c, image.c:
1840 * intervals.c, keyboard.c, process.c, syntax.c, textprop.c, w32term.c:
1841 * xdisp.c, xfaces.c, xterm.c: Replace all uses of INLINE with inline.
1842 * gmalloc.c (register_heapinfo): Use inline unconditionally.
1843 * lisp.h (LISP_MAKE_RVALUE): Use inline, not __inline__.
1844
738db178
DN
18452011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
1846
1847 Make it possible to run ./temacs.
1848
1849 * callproc.c (set_initial_environment): Remove CANNOT_DUMP code,
1850 syms_of_callproc does the same thing. Remove test for
1851 "initialized", do it in the caller.
1852 * emacs.c (main): Avoid calling set_initial_environment when dumping.
1853
620c53a6
SM
18542011-05-31 Stefan Monnier <monnier@iro.umontreal.ca>
1855
1856 * minibuf.c (Finternal_complete_buffer): Return `category' metadata.
1857 (read_minibuf): Use get_minibuffer.
1858 (syms_of_minibuf): Use DEFSYM.
1859 (Qmetadata): New var.
1860 * data.c (Qbuffer): Don't make it static.
1861 (syms_of_data): Use DEFSYM.
1862
e003a292
PE
18632011-05-31 Paul Eggert <eggert@cs.ucla.edu>
1864
1865 * ccl.c (CCL_CODE_RANGE): Allow negative numbers. (Bug#8751)
1866 (CCL_CODE_MIN): New macro.
1867
ed008a6d
PE
18682011-05-30 Paul Eggert <eggert@cs.ucla.edu>
1869
3687c2ef
PE
1870 * alloc.c (lisp_align_malloc): Omit unnecessary val==NULL tests.
1871
ed008a6d
PE
1872 * eval.c (Qdebug): Now static.
1873 * lisp.h (Qdebug): Remove decl. This reverts a part of the
1874 2011-04-26T11:26:05Z!dan.colascione@gmail.com that inadvertently undid part of
1875 2011-04-14T06:48:41Z!eggert@cs.ucla.edu.
1876
d66c4c7c
CY
18772011-05-29 Chong Yidong <cyd@stupidchicken.com>
1878
1879 * image.c: Various fixes to ImageMagick code comments.
1880 (Fimagemagick_types): Doc fix.
1881
5fbc2025
PE
18822011-05-29 Paul Eggert <eggert@cs.ucla.edu>
1883
0196f88a
PE
1884 Minor fixes prompted by GCC 4.6.0 warnings.
1885
1886 * xselect.c (converted_selections, conversion_fail_tag): Now static.
1887
5fbc2025
PE
1888 * emacs.c [HAVE_X_WINDOWS]: Include "xterm.h".
1889 (x_clipboard_manager_save_all): Move extern decl to ...
1890 * xterm.h: ... here, so that it can be checked for consistency.
1891
1dd3c2d9
CY
18922011-05-29 Chong Yidong <cyd@stupidchicken.com>
1893
1894 * xselect.c (x_clipboard_manager_save_frame)
1895 (x_clipboard_manager_save_all): New functions.
1896 (Fx_clipboard_manager_save): Lisp function deleted.
1897
1898 * emacs.c (Fkill_emacs): Call x_clipboard_manager_save_all.
1899 * frame.c (delete_frame): Call x_clipboard_manager_save_frame.
1900
1901 * xterm.h: Update prototype.
1902
5ba6571d
WX
19032011-05-28 William Xu <william.xwl@gmail.com>
1904
1905 * nsterm.m (ns_term_shutdown): Synchronize user defaults before
1906 exiting (Bug#8239).
1907
3eaff834
JM
19082011-05-28 Jim Meyering <meyering@redhat.com>
1909
e1900994 1910 Avoid a sign-extension bug in crypto_hash_function.
3eaff834
JM
1911 * fns.c (to_uchar): Define.
1912 (crypto_hash_function): Use it to convert some newly-signed
1913 variables to unsigned, to avoid sign-extension bugs. For example,
1914 without this change, (md5 "truc") would evaluate to
1915 45723a2aff78ff4fff7fff1114760e62 rather than the expected
1916 45723a2af3788c4ff17f8d1114760e62. Reported by Antoine Levitt in
e1900994 1917 https://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00883.html.
3eaff834 1918
0f6990a7
PE
19192011-05-27 Paul Eggert <eggert@cs.ucla.edu>
1920
1921 Integer overflow fixes.
c8a9ca5a 1922
08686060
PE
1923 * dbusbind.c: Serial number integer overflow fixes.
1924 (CHECK_DBUS_SERIAL_GET_SERIAL): New macro.
08686060
PE
1925 (Fdbus_call_method_asynchronously, xd_read_message_1): Use a float
1926 to hold a serial number that is too large for a fixnum.
1927 (Fdbus_method_return_internal, Fdbus_method_error_internal):
1928 Check for serial numbers out of range. Decode any serial number
59568bf0 1929 that was so large that it became a float. (Bug#8722)
08686060 1930
2d1fc3c7
PE
1931 * dbusbind.c: Use XFASTINT rather than XUINT, and check for nonneg.
1932 (Fdbus_call_method, Fdbus_call_method_asynchronously):
1933 Use XFASTINT rather than XUINT when numbers are nonnegative.
1934 (xd_append_arg, Fdbus_method_return_internal):
1935 (Fdbus_method_error_internal): Likewise. Also, for unsigned
1936 arguments, check that Lisp number is nonnegative, rather than
59568bf0 1937 silently wrapping negative numbers around. (Bug#8722)
30217ff0 1938 (xd_read_message_1): Don't assume dbus_uint32_t can fit in int.
59568bf0 1939 (Bug#8722)
2d1fc3c7 1940
c8a9ca5a
PE
1941 * data.c (arith_driver, Flsh): Avoid unnecessary casts to EMACS_UINT.
1942
519e1d69
PE
1943 * ccl.c (ccl_driver): Redo slightly to avoid the need for 'unsigned'.
1944
30569699
PE
1945 ccl: add integer overflow checks
1946 * ccl.c (CCL_CODE_MAX, GET_CCL_RANGE, GET_CCL_CODE, GET_CCL_INT):
1947 (IN_INT_RANGE): New macros.
1948 (ccl_driver): Use them to check for integer overflow when
1949 decoding a CCL program. Many of the new checks are whether XINT (x)
1950 fits in int; it doesn't always, on 64-bit hosts. The new version
1951 doesn't catch all possible integer overflows, but it's an
847044ea 1952 improvement. (Bug#8719)
30569699 1953
c11285dc
PE
1954 * alloc.c (make_event_array): Use XINT, not XUINT.
1955 There's no need for unsigned here.
1956
fdccd48e
PE
1957 * mem-limits.h (EXCEEDS_LISP_PTR) [!USE_LSB_TAG]: EMACS_UINT -> uintptr_t
1958 This follows up to the 2011-05-06 change that substituted uintptr_t
1959 for EMACS_INT. This case wasn't caught back then.
1960
37910ab2
PE
1961 Rework Fformat to avoid integer overflow issues.
1962 * editfns.c: Include <float.h> unconditionally, as it's everywhere
1963 now (part of C89). Include <verify.h>.
1964 (MAX_10_EXP, CONVERTED_BYTE_SIZE): Remove; no longer needed.
1965 (pWIDE, pWIDElen, signed_wide, unsigned_wide): New defns.
1966 (Fformat): Avoid the prepass trying to compute sizes; it was only
1967 approximate and thus did not catch overflow reliably. Instead, walk
1968 through the format just once, formatting and computing sizes as we go,
1969 checking for integer overflow at every step, and allocating a larger
1970 buffer as needed. Keep track separately whether the format is
1971 multibyte. Keep only the most-recently calculated precision, rather
1972 than them all. Record whether each argument has been converted to
1973 string. Use EMACS_INT, not int, for byte and char and arg counts.
1974 Support field widths and precisions larger than INT_MAX. Avoid
1975 sprintf's undefined behavior with conversion specifications such as %#d
1976 and %.0c. Fix bug with strchr succeeding on '\0' when looking for
1977 flags. Fix bug with (format "%c" 256.0). Avoid integer overflow when
1978 formatting out-of-range floating point numbers with int
9173deec 1979 formats. (Bug#8668)
37910ab2 1980
2e6578fb
PE
1981 * lisp.h (FIXNUM_OVERFLOW_P): Work even if arg is a NaN.
1982
0ae6bdee
PE
1983 * data.c: Avoid integer truncation in expressions involving floats.
1984 * data.c: Include <intprops.h>.
1985 (arith_driver): When there's an integer overflow in an expression
1986 involving floating point, convert the integers to floating point
1987 so that the resulting value does not suffer from catastrophic
1988 integer truncation. For example, on a 64-bit host (* 4
1989 most-negative-fixnum 0.5) should yield about -4.6e+18, not zero.
1990 Do not rely on undefined behavior after integer overflow.
1991
de883a70
PE
1992 merge count_size_as_multibyte, parse_str_to_multibyte
1993 * character.c, character.h (count_size_as_multibyte):
fd6fa53f 1994 Rename from parse_str_to_multibyte; all uses changed.
de883a70
PE
1995 Check for integer overflow.
1996 * insdel.c, lisp.h (count_size_as_multibyte): Remove,
1997 since it's now a duplicate of the other. This is more of
1998 a character than a buffer op, so better that it's in character.c.
1999 * fns.c, print.c: Adjust to above changes.
2000
2ff916cb
PE
20012011-05-27 Stefan Monnier <monnier@iro.umontreal.ca>
2002
2003 * xselect.c (x_convert_selection): Yet another int/Lisp_Object mixup.
2004
f1b54466
PE
20052011-05-27 Paul Eggert <eggert@cs.ucla.edu>
2006
fb1ac845
PE
2007 * xselect.c: Fix minor problems prompted by GCC 4.6.0 warnings.
2008 (x_handle_selection_request, frame_for_x_selection): Remove unused vars.
2009 (x_clipboard_manager_save): Now static.
2010 (Fx_clipboard_manager_save): Rename local to avoid shadowing.
2011
f1b54466
PE
2012 * fns.c: Fix minor problems prompted by GCC 4.6.0 warnings.
2013 (crypto_hash_function): Now static.
2014 Fix pointer signedness problems. Avoid unnecessary initializations.
2015
a9f737ee
CY
20162011-05-27 Chong Yidong <cyd@stupidchicken.com>
2017
2018 * termhooks.h (Vselection_alist): Make it terminal-local.
2019
2020 * terminal.c (create_terminal): Initialize it.
2021
2022 * xselect.c: Support for clipboard managers.
2023 (Vselection_alist): Move to termhooks.h as terminal-local var.
2024 (LOCAL_SELECTION): New macro.
2025 (x_atom_to_symbol): Handle x_display_info_for_display fail case.
2026 (symbol_to_x_atom): Remove gratuitous arg.
2027 (x_handle_selection_request, lisp_data_to_selection_data)
2028 (x_get_foreign_selection, Fx_register_dnd_atom): Callers changed.
620c53a6
SM
2029 (x_own_selection, x_get_local_selection, x_convert_selection):
2030 New arg, specifying work frame. Use terminal-local Vselection_alist.
a9f737ee
CY
2031 (some_frame_on_display): Delete unused function.
2032 (Fx_own_selection_internal, Fx_get_selection_internal)
2033 (Fx_disown_selection_internal, Fx_selection_owner_p)
2034 (Fx_selection_exists_p): New optional frame arg.
2035 (frame_for_x_selection, Fx_clipboard_manager_save): New functions.
2036 (x_handle_selection_clear): Don't treat other terminals with the
2037 same keyboard specially. Use the terminal-local Vselection_alist.
2038 (x_clear_frame_selections): Use Frun_hook_with_args.
2039
2040 * xterm.c (x_term_init): Intern ATOM and CLIPBOARD_MANAGER atoms.
2041
2042 * xterm.h: Add support for those atoms.
2043
e067f0c1
CY
20442011-05-26 Chong Yidong <cyd@stupidchicken.com>
2045
2046 * xselect.c: ICCCM-compliant handling of MULTIPLE targets.
2047 (converted_selections, conversion_fail_tag): New global variables.
2048 (x_selection_request_lisp_error): Free the above.
2049 (x_get_local_selection): Remove unnecessary code.
2050 (x_reply_selection_request): Args changed; handle arbitrary array
620c53a6
SM
2051 of converted selections stored in converted_selections.
2052 Separate the XChangeProperty and SelectionNotify steps.
e067f0c1
CY
2053 (x_handle_selection_request): Rewrite to handle MULTIPLE target.
2054 (x_convert_selection): New function.
2055 (x_handle_selection_event): Simplify.
2056 (x_get_foreign_selection): Don't ignore incoming requests while
2057 waiting for an answer; this will fail when we implement
2058 SAVE_TARGETS, and seems unnecessary anyway.
2059 (selection_data_to_lisp_data): Recognize ATOM_PAIR type.
2060 (Vx_sent_selection_functions): Doc fix.
2061
0f4aebc0
LL
20622011-05-26 Leo Liu <sdl.web@gmail.com>
2063
2064 * editfns.c (Ftranspose_regions): Allow empty regions. (Bug#8699)
2065
e61124cd
YM
20662011-05-25 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
2067
2068 * dispextern.h (struct glyph_row): New member fringe_bitmap_periodic_p.
2069
2070 * dispnew.c (shift_glyph_matrix, scrolling_window): Mark scrolled row
2071 for fringe update if it has periodic bitmap.
2072 (row_equal_p): Also compare left_fringe_offset, right_fringe_offset,
2073 and fringe_bitmap_periodic_p.
2074
2075 * fringe.c (get_fringe_bitmap_data): New function.
2076 (draw_fringe_bitmap_1, update_window_fringes): Use it.
2077 (update_window_fringes): Record periodicity of fringe bitmap in glyph
2078 row. Mark glyph row for fringe update if periodicity changed.
2079
2080 * xdisp.c (try_window_reusing_current_matrix): Don't mark scrolled row
2081 for fringe update unless it has periodic bitmap.
2082
f16d9837
KH
20832011-05-25 Kenichi Handa <handa@m17n.org>
2084
2085 * xdisp.c (get_next_display_element): Set correct it->face_id for
2086 a static composition.
2087
e1b90ef6
LL
20882011-05-24 Leo Liu <sdl.web@gmail.com>
2089
2090 * deps.mk (fns.o):
2091 * makefile.w32-in ($(BLD)/fns.$(O)): Include sha1.h.
2092
2093 * fns.c (crypto_hash_function, Fsha1): New function.
2094 (Fmd5): Use crypto_hash_function.
2095 (syms_of_fns): Add Ssha1.
2096
7400048f
PE
20972011-05-22 Paul Eggert <eggert@cs.ucla.edu>
2098
2099 * gnutls.c: Remove unused macros.
2100 (fn_gnutls_transport_set_lowat, fn_gnutls_transport_set_pull_function):
2101 (fn_gnutls_transport_set_push_function) [!WINDOWSNT]:
2102 Remove macros that are defined and never used.
2103 Caught by gcc -Wunused-macros (GCC 4.6.0, Fedora 14).
2104
abb71cf4
CY
21052011-05-22 Chong Yidong <cyd@stupidchicken.com>
2106
2107 * xselect.c (syms_of_xselect): Remove unused symbol SAVE_TARGETS.
2108 (Fx_get_selection_internal): Minor cleanup.
2109 (Fx_own_selection_internal): Rename arguments for consistency with
2110 select.el.
2111
6307db39
PE
21122011-05-22 Paul Eggert <eggert@cs.ucla.edu>
2113
2114 * xselect.c (QSAVE_TARGETS): New static var, to fix build failure.
2115
f3d4e0a4
CY
21162011-05-22 Chong Yidong <cyd@stupidchicken.com>
2117
2118 * xselect.c (syms_of_xselect): Include character.h; use DEFSYM.
2119
4d8ade89
YM
21202011-05-21 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
2121
2122 * dispnew.c (scrolling_window): Don't exclude the case that the
2123 last enabled row in the desired matrix touches the bottom boundary.
2124
32078c8d
GM
21252011-05-21 Glenn Morris <rgm@gnu.org>
2126
2127 * Makefile.in ($(etc)/DOC): Make second command line even shorter.
33cf345f
GM
2128 (SOME_MACHINE_OBJECTS): Replace FONT_OBJ by its maximal expansion,
2129 and add some more files.
32078c8d 2130
7285dc67
EZ
21312011-05-20 Eli Zaretskii <eliz@gnu.org>
2132
2133 * callproc.c (Fcall_process) [MSDOS]: Fix arguments to
2134 report_file_error introduced by the change from 2011-05-07.
2135
89d1bd22
PE
21362011-05-20 Paul Eggert <eggert@cs.ucla.edu>
2137
2138 * systime.h (Time): Define only if emacs is defined.
2139 This is to allow ../lib-src/profile.c to be compiled on FreeBSD,
2140 where the include path doesn't have X11/X.h by default. See
2141 <http://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00561.html>.
2142
e23640bb 21432011-05-20 Kenichi Handa <handa@m17n.org>
31bfc35c
KH
2144
2145 * composite.c (find_automatic_composition): Fix previous change.
2146
b9704ad9
GM
21472011-05-20 Glenn Morris <rgm@gnu.org>
2148
2149 * lisp.mk: New file, split from Makefile.in.
2150 * Makefile.in (lisp): Move to separate file, inserted by @lisp_frag@.
2151 (shortlisp): Remove.
2152 ($(etc)/DOC): Edit lisp.mk rather than using $shortlisp.
2153
4a720484
GM
21542011-05-19 Glenn Morris <rgm@gnu.org>
2155
2156 * Makefile.in (MSDOS_SUPPORT_REAL, MSDOS_SUPPORT, NS_SUPPORT)
2157 (REAL_MOUSE_SUPPORT, GPM_MOUSE_SUPPORT, MOUSE_SUPPORT, TOOLTIP_SUPPORT)
2158 (BASE_WINDOW_SUPPORT, X_WINDOW_SUPPORT, WINDOW_SUPPORT): Remove.
2159 (lisp): Set the order to that of loadup.el.
2160 (shortlisp): Make it a copy of $lisp.
2161 (SOME_MACHINE_LISP): Remove.
2162 ($(etc)/DOC): Depend just on $lisp, not $SOME_MACHINE_LISP too.
2163 Use just $shortlisp, not $SOME_MACHINE_LISP too.
2164
a28d4396
KH
21652011-05-18 Kenichi Handa <handa@m17n.org>
2166
2167 * composite.c (CHAR_COMPOSABLE_P): Add more check for efficiency.
2168 (BACKWARD_CHAR): Wrap the arg STOP by parenthesis.
2169 (find_automatic_composition): Mostly rewrite for efficiency.
2170
a2b1fa8e
JB
21712011-05-18 Juanma Barranquero <lekktu@gmail.com>
2172
2173 * makefile.w32-in: Update dependencies.
2174
8e1f5610
CS
21752011-05-18 Christoph Scholtes <cschol2112@googlemail.com>
2176
2177 * menu.c: Include limits.h (fixes the MS-Windows build broken by
7d7d0045 2178 2011-06-18T18:49:19Z!cyd@stupidchicken.com).
8e1f5610 2179
7025ee00 21802011-05-18 Paul Eggert <eggert@cs.ucla.edu>
cb93f9be 2181
cdfa6eab
PE
2182 Fix some integer overflow issues, such as string length overflow.
2183
06d6db33
PE
2184 * insdel.c (count_size_as_multibyte): Check for string overflow.
2185
2b4560a8
PE
2186 * character.c (lisp_string_width): Check for string overflow.
2187 Use EMACS_INT, not int, for string indexes and lengths; in
2188 particular, 2nd arg is now EMACS_INT, not int. Do not crash if
2189 the resulting string length overflows an EMACS_INT; instead,
2190 report a string overflow if no precision given. When checking for
2191 precision exhaustion, use a check that cannot possibly have
2192 integer overflow. (Bug#8675)
2193 * character.h (lisp_string_width): Adjust to new signature.
2194
cb93f9be
PE
2195 * alloc.c (string_overflow): New function.
2196 (Fmake_string): Use it. This doesn't change behavior, but saves
2197 a few bytes and will simplify future changes.
2198 * character.c (string_escape_byte8): Likewise.
2199 * lisp.h (string_overflow): New decl.
2200
1a1f3366
PE
2201 Fixups, following up to the user-interface timestamp change.
2202 * nsterm.m (last_mouse_movement_time, ns_mouse_position): Use Time
2203 for UI timestamps, instead of unsigned long.
9fbd6841
PE
2204 * msdos.c (mouse_get_pos): Likewise.
2205 * w32inevt.c (movement_time, w32_console_mouse_position): Likewise.
1a1f3366
PE
2206 * w32gui.h (Time): Define by including "systime.h" rather than by
2207 declaring it ourselves. (Bug#8664)
2208
d4e3e4d3
PE
2209 * dispextern.h (struct image): Don't assume time_t <= unsigned long.
2210 * image.c (clear_image_cache): Likewise.
2211
f6a24d19
PE
2212 * term.c (term_mouse_position): Don't assume time_t wraparound.
2213
08dc5ae6
PE
2214 Be more systematic about user-interface timestamps.
2215 Before, the code sometimes used 'Time', sometimes 'unsigned long',
620c53a6
SM
2216 and sometimes 'EMACS_UINT', to represent these timestamps.
2217 This change causes it to use 'Time' uniformly, as that's what X uses.
08dc5ae6
PE
2218 This makes the code easier to follow, and makes it easier to catch
2219 integer overflow bugs such as Bug#8664.
2220 * frame.c (Fmouse_position, Fmouse_pixel_position):
2221 Use Time, not unsigned long, for user-interface timestamps.
2222 * keyboard.c (last_event_timestamp, kbd_buffer_get_event): Likewise.
2223 (button_down_time, make_lispy_position, make_lispy_movement): Likewise.
2224 * keyboard.h (last_event_timestamp): Likewise.
2225 * menu.c (Fx_popup_menu) [!HAVE_X_WINDOWS]: Likewise.
2226 * menu.h (xmenu_show): Likewise.
2227 * term.c (term_mouse_position): Likewise.
2228 * termhooks.h (struct input_event.timestamp): Likewise.
2229 (struct terminal.mouse_position_hook): Likewise.
2230 * xmenu.c (create_and_show_popup_menu, xmenu_show): Likewise.
2231 * xterm.c (XTmouse_position, x_scroll_bar_report_motion): Likewise.
2232 * systime.h (Time): New decl. Pull it in from <X11/X.h> if
2233 HAVE_X_WINDOWS, otherwise define it as unsigned long, which is
2234 what it was before.
2235 * menu.h, termhooks.h: Include "systime.h", for Time.
2236
8e55734a
PE
2237 * keyboard.c (make_lispy_event): Fix problem in integer overflow.
2238 Don't assume that the difference between two unsigned long values
2239 can fit into an integer. At this point, we know button_down_time
2240 <= event->timestamp, so the difference must be nonnegative, so
2241 there's no need to cast the result if double-click-time is
2242 nonnegative, as it should be; check that it's nonnegative, just in
2243 case. This bug is triggered when events are more than 2**31 ms
86db42d2 2244 apart (about 25 days). (Bug#8664)
8e55734a 2245
841f1b75 2246 * xselect.c (last_event_timestamp): Remove duplicate decl.
6434756c 2247 (x_own_selection): Remove needless cast to unsigned long.
841f1b75 2248
3e26f69c
PE
2249 * xmenu.c (set_frame_menubar): Use int, not EMACS_UINT, for indexes
2250 that always fit in int. Use a sentinel instead of a counter, to
2251 avoid a temp and to allay GCC's concerns about possible int overflow.
d230cb74
PE
2252 * frame.h (struct frame): Use int for menu_bar_items_used
2253 instead of EMACS_INT, since it always fits in int.
3e26f69c 2254
5cc152c0
PE
2255 * menu.c (grow_menu_items): Check for int overflow.
2256
d89eb65e
PE
2257 * xmenu.c (set_frame_menubar): Don't mishandle vectors with no nils.
2258
5235bd3e
PE
2259 * xterm.c: Use EMACS_INT for Emacs modifiers, and int for X modifiers.
2260 Before, the code was not consistent. These values cannot exceed
2261 2**31 - 1 so there's no need to make them unsigned.
2262 (x_x_to_emacs_modifiers): Accept int and return EMACS_INT.
2263 (x_emacs_to_x_modifiers): Accept EMACS_INT and return int.
2264 (x_x_to_emacs_modifiers, x_emacs_to_x_modifiers): Reject non-integers
2265 as modifiers.
2266 * xterm.h (x_x_to_emacs_modifiers): Adjust to signature change.
2267
bc827e23
PE
2268 * lisp.h (XINT) [USE_LISP_UNION_TYPE]: Cast to EMACS_INT.
2269 (XUINT) [USE_LISP_UNION_TYPE]: Cast to EMACS_UINT.
2270 Otherwise, GCC 4.6.0 warns about printf (pI, XINT (...)),
2271 presumably because the widths might not match.
2272
78eb494e
PE
2273 * window.c (size_window): Avoid needless test at loop start.
2274
04f2d78b
CB
22752011-05-18 Courtney Bane <emacs-bugs-7626@cbane.org> (tiny change)
2276
2277 * term.c (Fresume_tty): Restore hooks before reinitializing (bug#8687).
2278
d2fc7e3d 22792011-05-12 Drew Adams <drew.adams@oracle.com>
e531bdff
DA
2280
2281 * textprop.c (Fprevious_single_char_property_change): Doc fix (bug#8655).
2282
d2fc7e3d 22832011-05-12 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
7db47798
YM
2284
2285 * w32term.c (w32_draw_fringe_bitmap): Rename local vars `left' and
2286 `width' to `bar_area_x' and `bar_area_width', respectively.
2287 (x_scroll_run): Take account of fringe background extension.
2288
04f2d78b
CB
2289 * xterm.c (x_draw_fringe_bitmap) [USE_TOOLKIT_SCROLL_BARS]:
2290 Rename local vars `left' and `width' to `bar_area_x' and
7db47798
YM
2291 `bar_area_width', respectively.
2292 (x_scroll_run) [USE_TOOLKIT_SCROLL_BARS]: Take account of fringe
2293 background extension.
2294
79b70037
GM
22952011-05-10 Jim Meyering <meyering@redhat.com>
2296
2297 * xdisp.c (x_intersect_rectangles): Fix typo "the the -> the".
2298
2f142cc5
JB
22992011-05-10 Juanma Barranquero <lekktu@gmail.com>
2300
2301 * image.c (Finit_image_library): Return t for built-in image types,
2302 like pbm and xbm. (Bug#8640)
2303
57679c86
AS
23042011-05-09 Andreas Schwab <schwab@linux-m68k.org>
2305
2306 * w32menu.c (set_frame_menubar): Fix submenu allocation.
2307
888c9e86
EZ
23082011-05-07 Eli Zaretskii <eliz@gnu.org>
2309
b0512a1d
EZ
2310 * w32console.c (Fset_screen_color): Doc fix.
2311 (Fget_screen_color): New function.
2312 (syms_of_ntterm): Defsubr it.
2313
7285dc67
EZ
2314 * callproc.c (call_process_cleanup) [MSDOS]: Don't close and
2315 unlink the temporary file if Fcall_process didn't create it in the
2316 first place.
2317 (Fcall_process) [MSDOS]: Don't create tempfile if stdout of the
2318 child process will be redirected to a file specified with `:file'.
888c9e86
EZ
2319 Don't try to re-open tempfile in that case, and set fd[0] to -1 as
2320 cue to call_process_cleanup not to close that handle.
2321
4d3fcc8e
BK
23222011-05-07 Ben Key <bkey76@gmail.com>
2323
2324 * makefile.w32-in: The bootstrap-temacs rule now makes use of
2325 one of two shell specific rules, either bootstrap-temacs-CMD or
2326 bootstrap-temacs-SH. The bootstrap-temacs-SH rule is identical
2327 to the previous implementation of the bootstrap-temacs rule.
2328 The bootstrap-temacs-CMD rule is similar to the previous
2329 implementation of the bootstrap-temacs rule except that it
2330 makes use of the ESC_CFLAGS variable instead of the CFLAGS
2331 variable.
2332
2333 These changes, along with some changes to nt/configure.bat,
2334 nt/gmake.defs, and nt/nmake.defs, are required to extend my
2335 earlier fix to add support for --cflags and --ldflags options
2336 that include quotes so that it works whether make uses cmd or
2337 sh as the shell.
2338
b4289b64
MA
23392011-05-06 Michael Albinus <michael.albinus@gmx.de>
2340
2341 * dbusbind.c (QCdbus_type_unix_fd): Declare static.
2342 (xd_remove_watch): Don't check QCdbus_type_unix_fd for SYMBOLP, it
2343 is a constant.
2344 (Fdbus_init_bus, xd_read_queued_messages): Bus can be a symbol or
2345 a string. Handle both cases.
2346 (Fdbus_call_method_asynchronously, Fdbus_register_signal)
2347 (Fdbus_register_method): Use Qinvalid_function.
2348
af4c0e28
JB
23492011-05-06 Juanma Barranquero <lekktu@gmail.com>
2350
2351 * makefile.w32-in: Update dependencies.
2352 (LISP_H): Add inttypes.h and stdin.h.
2353 (PROCESS_H): Add unistd.h.
2354
c51453d9
EZ
23552011-05-06 Eli Zaretskii <eliz@gnu.org>
2356
2357 * lread.c: Include limits.h (fixes the MS-Windows build broken by
2358 2011-05-06T07:13:19Z!eggert@cs.ucla.edu).
2359
8ff0ac3c 23602011-05-06 Paul Eggert <eggert@cs.ucla.edu>
c032b5f8 2361
4c4b566b
PE
2362 * image.c (Finit_image_library) [!HAVE_NTGUI]: Omit unused local.
2363
aab2b9b5
PE
2364 * term.c (vfatal): Remove stray call to va_end.
2365 It's not needed and the C Standard doesn't allow it here anyway.
2366
c378da0b
PE
2367 Use C99's va_copy to avoid undefined behavior on x86-64 GNU/Linux.
2368 * eval.c (verror): doprnt a copy of ap, not the original. (Bug#8545)
2369
288b08c7
PE
2370 * eval.c (verror): OK to create a string of up to MOST_POSITIVE_FIXNUM
2371 bytes.
2372
e3601888
PE
2373 * term.c: Don't include <stdarg.h>, as <lisp.h> does that.
2374
db6c0e74
PE
2375 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork clobbering.
2376
dd5963ea
PE
2377 * process.c (Fformat_network_address): Fix typo: args2 -> *args2.
2378
88c9450f
PE
2379 * xmenu.c (set_frame_menubar): Fix typo: int * -> int (3 times).
2380
2f9442b8
PE
2381 * coding.c (detect_coding_charset): Fix typo: * 2 -> *4 (Bug#8601).
2382
c032b5f8
PE
2383 * charset.h (struct charset.code_space): Now has 15 elements, not 16.
2384 * charset.c (Fdefine_charset_internal): Don't initialize
2385 charset.code_space[15]. The value was garbage, on hosts with
2d38271b 2386 32-bit int (Bug#8600).
a108c10b
PE
2387
2388 * lread.c (read_integer): Be more consistent with string-to-number.
2389 Use string_to_number to do the actual conversion; this avoids
2390 rounding errors and fixes some other screwups. Without this fix,
2391 for example, #x1fffffffffffffff was misread as -2305843009213693952.
2392 (digit_to_number): Move earlier, for benefit of read_integer.
2393 Return -1 if the digit is out of range for the base, -2 if it is
48e400f0 2394 not a digit in any supported base. (Bug#8602)
a108c10b 2395
ad5f9eea
PE
2396 * doprnt.c (doprnt): Support arbitrary pI values, such as "I64".
2397
aec1708a
PE
2398 * dispnew.c (scrolling_window): Return 1 if we scrolled,
2399 to match comment at start of function. This also removes a
2400 GCC warning about overflow in a 32+64-bit port.
2401
47be4ab5
PE
2402 * lisp.h (EMACS_INT, EMACS_UINT, BITS_PER_EMACS_INT, pI): Simplify.
2403
371cac43
PE
2404 * dbusbind.c: Do not use XPNTR on a value that may be an integer.
2405 Reported by Stefan Monnier in
2406 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00919.html>.
04f2d78b
CB
2407 (xd_remove_watch, Fdbus_init_bus, xd_read_queued_messages):
2408 Use SYMBOLP-guarded XSYMBOL, not XPNTR.
371cac43 2409
d01a7826
PE
2410 * lisp.h (EMACS_INTPTR): Remove. All uses changed to intptr_t.
2411 (EMACS_UINTPTR): Likewise, with uintptr_t.
2412
7fd47d5c
PE
2413 * lisp.h: Prefer 64-bit EMACS_INT if available.
2414 (EMACS_INT, EMACS_UINT, BITS_PER_EMACS_INT, pI): Define to 64-bit
2415 on 32-bit hosts that have 64-bit int, so that they can access
2416 large files.
122b0c86
PE
2417 However, temporarily disable this change unless the temporary
2418 symbol WIDE_EMACS_INT is defined.
7fd47d5c 2419
8727937b
PE
2420 * lread.c, process.c: Do not include <inttypes.h>; lisp.h does it now.
2421
8ac068ac
PE
2422 Prefer intptr_t/uintptr_t for integers the same widths as pointers.
2423 This removes an assumption that EMACS_INT and long are the same
2424 width as pointers. The assumption is true for Emacs porting targets
2425 now, but we want to make other targets possible.
2426 * lisp.h: Include <inttypes.h>, for INTPTR_MAX, UINTPTR_MAX.
2427 (EMACS_INTPTR, EMACS_UINTPTR): New macros.
2428 In the rest of the code, change types of integers that hold casted
2429 pointers to EMACS_INTPTR and EMACS_UINTPTR, systematically
2430 replacing EMACS_INT, long, EMACS_UINT, and unsigned long.
2431 (XTYPE): Don't cast arg to EMACS_UINT; normally is not needed.
2432 (XSET): Cast type of XTYPE arg to EMACS_INTPTR; it is needed here.
2433 No need to cast type when ORing.
2434 (XPNTR): Return a value of type EMACS_INTPTR or EMACS_UINTPTR.
2435 * alloc.c (lisp_align_malloc): Remove a no-longer-needed cast.
2436 * doc.c (store_function_docstring): Use EMACS_INTPTR, so as not to
2437 assume EMACS_INT is the same width as char *.
2438 * gtkutil.c (xg_gtk_scroll_destroy, xg_tool_bar_button_cb):
2439 (xg_tool_bar_callback, xg_tool_bar_help_callback, xg_make_tool_item):
2440 Remove no-longer-needed casts.
2441 (xg_create_scroll_bar, xg_tool_bar_button_cb, xg_tool_bar_callback):
2442 (xg_tool_bar_help_callback, xg_make_tool_item):
2443 Use EMACS_INTPTR to hold an integer
2444 that will be cast to void *; this can avoid a GCC warning
2445 if EMACS_INT is not the same width as void *.
2446 * menu.c (find_and_call_menu_selection): Remove no-longer-needed cast.
2447 * xdisp.c (display_echo_area_1, resize_mini_window_1):
2448 (current_message_1, set_message_1):
2449 Use a local to convert to proper width without a cast.
2450 * xmenu.c (dialog_selection_callback): Likewise.
2451
ede49d71
PE
2452 * sysdep.c (get_random): Don't assume EMACS_INT is no wider than long.
2453 Also, don't assume VALBITS / RAND_BITS is less than 5,
2454 and don't rely on undefined behavior when shifting a 1 left into
2455 the sign bit.
2456 * lisp.h (get_random): Change signature to match.
2457
2f30ecd0
PE
2458 * lread.c (hash_string): Use size_t, not int, for hash computation.
2459 Normally we prefer signed values; but hashing is special, because
2460 it's better to use unsigned division on hash table sizes so that
2461 the remainder is nonnegative. Also, size_t is the natural width
2462 for hashing into memory. The previous code used 'int', which doesn't
2463 retain enough info to hash well into very large tables.
2464 (oblookup, oblookup_last_bucket_number, Funintern): Likewise.
2465
2a866e7b
PE
2466 * dbusbind.c: Don't possibly lose pointer info when converting.
2467 (xd_remove_watch, Fdbus_init_bus, xd_read_queued_messages):
2468 Use XPNTR rather than XHASH, so that the high-order bits of
2469 the pointer aren't lost when converting through void *.
2470
51639eac
PE
2471 * eval.c (Fautoload): Don't double-shift a pointer.
2472
92394119
PE
2473 * fns.c (Frandom): Let EMACS_UINT be wider than unsigned long.
2474
dbdb9a7c
JB
24752011-05-06 Juanma Barranquero <lekktu@gmail.com>
2476
2477 * gnutls.c (DEF_GNUTLS_FN):
2478 * image.c (DEF_IMGLIB_FN): Make function pointers static.
2479
db7a0b4f
AS
24802011-05-05 Andreas Schwab <schwab@linux-m68k.org>
2481
2482 * lread.c (lisp_file_lexically_bound_p): Stop scanning at end
2483 marker. (Bug#8610)
2484
f7ff1b0f 24852011-05-05 Eli Zaretskii <eliz@gnu.org>
fab624aa
EZ
2486
2487 * w32heap.c (allocate_heap) [USE_LISP_UNION_TYPE || USE_LSB_TAG]:
2488 New version that can reserve upto 2GB of heap space.
2489
f7ff1b0f 24902011-05-05 Chong Yidong <cyd@stupidchicken.com>
45cb8994
CY
2491
2492 * nsfns.m (Fns_read_file_name): Doc fix (Bug#8534).
2493
639c109b
TZ
24942011-05-05 Teodor Zlatanov <tzz@lifelogs.com>
2495
2496 * gnutls.c (fn_gnutls_certificate_set_x509_key_file): Add alias to
2497 `gnutls_certificate_set_x509_key_file'.
2498
d2127135
JB
24992011-05-05 Juanma Barranquero <lekktu@gmail.com>
2500
2501 * makefile.w32-in ($(BLD)/image.$(O), $(BLD)/process.$(O)):
2502 Update dependencies.
2503
e968f4f3
JB
25042011-05-04 Juanma Barranquero <lekktu@gmail.com>
2505
2506 * gnutls.h (emacs_gnutls_write, emacs_gnutls_read):
2507 * gnutls.c (emacs_gnutls_write, emacs_gnutls_read):
2508 Remove unused parameter `fildes'.
2509 * process.c (read_process_output, send_process): Don't pass it.
2510
84d358f0
JB
25112011-05-04 Juanma Barranquero <lekktu@gmail.com>
2512
2513 Fix previous change: the library cache is defined in w32.c.
2514 * image.c (CACHE_IMAGE_TYPE) [!HAVE_NTGUI]: Define to noop.
2515 (Finit_image_library): Wrap Vlibrary_cache on "#ifdef HAVE_NTGUI".
2516
0898ca10
JB
25172011-05-04 Juanma Barranquero <lekktu@gmail.com>
2518
2519 Implement dynamic loading of GnuTLS on Windows.
2520
2521 * gnutls.h (GNUTLS_EMACS_ERROR_NOT_LOADED): New macro.
2522 (emacs_gnutls_write, emacs_gnutls_read): Mark as extern.
2523 (emacs_gnutls_record_check_pending, emacs_gnutls_transport_set_errno):
2524 Declare.
2525
2526 * gnutls.c (Qgnutls_dll): Define.
2527 (DEF_GNUTLS_FN, LOAD_GNUTLS_FN): New macros.
2528 (gnutls_*): Declare function pointers.
2529 (init_gnutls_functions): New function to initialize function pointers.
2530 (emacs_gnutls_handshake, Fgnutls_error_string, Fgnutls_deinit)
2531 (emacs_gnutls_global_init, Fgnutls_bye): Use function pointers.
2532 (emacs_gnutls_record_check_pending, emacs_gnutls_transport_set_errno):
2533 Wrappers for gnutls_record_check_pending and gnutls_transport_set_errno.
2534 (emacs_gnutls_write, emacs_gnutls_read)
2535 (emacs_gnutls_handle_error, Fgnutls_error_fatalp)
2536 (Fgnutls_available_p): New function.
2537 (Fgnutls_boot): Call Fgnutls_available_p. Use function pointers.
2538 (syms_of_gnutls) <Qgnutls_dll>: Initialize and staticpro it.
2539 (syms_of_gnutls) <Sgnutls_available_p>: defsubr it.
2540
2541 * image.c: Include w32.h.
2542 (Vimage_type_cache): Delete.
2543 (syms_of_image) <Vimage_type_cache>: Don't initialize and staticpro it.
2544 (CACHE_IMAGE_TYPE, Finit_image_library): Use Vlibrary_cache instead.
2545 (w32_delayed_load): Move to w32.c.
2546
2547 * w32.h (VlibraryCache, QCloaded_from, w32_delayed_load): Declare.
2548
2549 * w32.c (QCloaded_from, Vlibrary_cache): Define.
2550 (w32_delayed_load): Move from image.c. When loading a library, record
2551 its filename in the :loaded-from property of the library id.
2552 (globals_of_w32) <QCloaded_from, Vlibrary_cache>:
2553 Initialize and staticpro them.
2554 (emacs_gnutls_pull, emacs_gnutls_push): Call emacs_gnutls_* functions.
2555
2556 * process.c: Include lisp.h before w32.h, not after.
2557 (wait_reading_process_output): Call emacs_gnutls_record_check_pending
2558 instead of gnutls_record_check_pending.
2559
2560 * callproc.c, emacs.c: Include lisp.h before w32.h, not after.
2561
ff4de4aa
TZ
25622011-05-04 Teodor Zlatanov <tzz@lifelogs.com>
2563
2564 * gnutls.c (Fgnutls_boot): Support :keylist and :crlfiles options
2565 instead of :keyfiles. Give GnuTLS the keylist and the CRL lists
2566 as passed in.
2567
abe95abb
JD
25682011-05-03 Jan Djärv <jan.h.d@swipnet.se>
2569
2570 * xterm.c (x_set_frame_alpha): Do not set property on anything
2571 else than FRAME_X_OUTER_WINDOW (Bug#8608).
2572
e16e55d4
JB
25732011-05-02 Juanma Barranquero <lekktu@gmail.com>
2574
2575 * sysdep.c (get_tty_size) [WINDOWSNT]: Implement. (Bug#8596)
2576
bafcf6a5
JB
25772011-05-02 Juanma Barranquero <lekktu@gmail.com>
2578
2579 * gnutls.c (Qgnutls_log_level, Qgnutls_code, Qgnutls_anon)
2580 (Qgnutls_x509pki, Qgnutls_e_interrupted, Qgnutls_e_again)
2581 (Qgnutls_e_invalid_session, Qgnutls_e_not_ready_for_handshake)
2582 (gnutls_global_initialized, Qgnutls_bootprop_priority)
2583 (Qgnutls_bootprop_trustfiles, Qgnutls_bootprop_keyfiles)
2584 (Qgnutls_bootprop_callbacks, Qgnutls_bootprop_loglevel)
2585 (Qgnutls_bootprop_hostname, Qgnutls_bootprop_verify_flags)
2586 (Qgnutls_bootprop_verify_error, Qgnutls_bootprop_verify_hostname_error)
2587 (Qgnutls_bootprop_callbacks_verify): Make static.
2588
e7a6747f
AS
25892011-05-01 Andreas Schwab <schwab@linux-m68k.org>
2590
19ed11ba
AS
2591 * callproc.c: Indentation fixup.
2592
e7a6747f 2593 * sysdep.c (wait_for_termination_1): Make static.
04f2d78b
CB
2594 (wait_for_termination, interruptible_wait_for_termination):
2595 Move after wait_for_termination_1.
e7a6747f 2596
1ef14cb4
LMI
25972011-05-01 Lars Magne Ingebrigtsen <larsi@gnus.org>
2598
2599 * sysdep.c (interruptible_wait_for_termination): New function
2600 which is like wait_for_termination, but allows keyboard
2601 interruptions.
2602
2603 * callproc.c (Fcall_process): Add (:file "file") as an option for
2604 the STDOUT buffer.
2605 (Fcall_process_region): Ditto.
2606
330d880c
EZ
26072011-04-30 Eli Zaretskii <eliz@gnu.org>
2608
8db90b73
EZ
2609 * dosfns.c (Fint86, Fdos_memget, Fdos_memput): Use `ASIZE (FOO)'
2610 rather than `XVECTOR (FOO)->size'.
2611
330d880c
EZ
2612 * process.c: Remove HAVE_INTTYPES_H condition from inclusion of
2613 inttypes.h, as a gnulib replacement is used if it not available in
2614 system headers.
2615
15cbd324
EZ
26162011-04-21 Eli Zaretskii <eliz@gnu.org>
2617
2618 Lift the MOST_POSITIVE_FIXNUM/4 limitation on visited files.
2619 * fileio.c (Finsert_file_contents): Don't limit file size to 1/4
2620 of MOST_POSITIVE_FIXNUM. (Bug#8528)
2621
2622 * coding.c (coding_alloc_by_realloc): Error out if destination
2623 will grow beyond MOST_POSITIVE_FIXNUM.
2624 (decode_coding_emacs_mule): Abort if there isn't enough place in
2625 charbuf for the composition carryover bytes. Reserve an extra
2626 space for up to 2 characters produced in a loop.
2627 (decode_coding_iso_2022): Abort if there isn't enough place in
2628 charbuf for the composition carryover bytes.
2629
26302011-04-21 Eli Zaretskii <eliz@gnu.org>
afda1437 2631
ae940cca
EZ
2632 * doprnt.c (doprnt) [!HAVE_LONG_LONG_INT]: Error out instead of
2633 aborting when %lld or %lll format is passed.
2634 [!HAVE_UNSIGNED_LONG_LONG_INT]: Error out instead of aborting when
2635 %llo or %llx format is passed. (Bug#8545)
2636
03ab8921
EZ
2637 * window.c (window_scroll_line_based): Use a marker instead of
2638 simple variables to record original value of point. (Bug#7952)
2639
afda1437
EZ
2640 * doprnt.c (doprnt): Fix the case where a multibyte sequence
2641 produced by %s or %c overflows available buffer space. (Bug#8545)
2642
f76dee0c
PE
26432011-04-28 Paul Eggert <eggert@cs.ucla.edu>
2644
2645 * doprnt.c (doprnt): Omit useless test; int overflow check (Bug#8545).
283cdbef 2646 (SIZE_MAX): Move defn after all includes, as they might #define it.
f76dee0c 2647
fdc5744d
JB
26482011-04-28 Juanma Barranquero <lekktu@gmail.com>
2649
2650 * w32.c (init_environment): Warn about defaulting HOME to C:\.
2651
638f053a
JB
26522011-04-28 Juanma Barranquero <lekktu@gmail.com>
2653
2654 * keyboard.c (Qdelayed_warnings_hook): Define.
2655 (command_loop_1): Run `delayed-warnings-hook'
2656 if Vdelayed_warnings_list is non-nil.
2657 (syms_of_keyboard) <delayed-warnings-hook>: DEFSYM it.
2658 (syms_of_keyboard) <delayed-warnings-list>: DEFVAR_LISP it.
2659
d178f871
EZ
26602011-04-28 Eli Zaretskii <eliz@gnu.org>
2661
2662 * doprnt.c (doprnt): Don't return value smaller than the buffer
2663 size if the message was truncated. (Bug#8545).
2664
b124fd93
JB
26652011-04-28 Juanma Barranquero <lekktu@gmail.com>
2666
2667 * w32fns.c (Fx_change_window_property, Fx_delete_window_property)
2668 (Fx_window_property): #if-0 the whole functions, not just the bodies.
2669
e810457d
PE
26702011-04-27 Paul Eggert <eggert@cs.ucla.edu>
2671
2672 * doprnt.c (doprnt): Support "ll" length modifier, for long long.
2673
ea51cceb
JB
26742011-04-27 Juanma Barranquero <lekktu@gmail.com>
2675
2676 * makefile.w32-in: Update dependencies.
2677
94dcfacf
EZ
26782011-04-27 Eli Zaretskii <eliz@gnu.org>
2679
2680 Improve `doprnt' and its usage. (Bug#8545)
2681 * doprnt.c (doprnt): Make sure `format' is never accessed beyond
2682 `format_end'. Remove support for %l as a conversion specifier.
2683 Don't use xrealloc. Improve diagnostics when the %l size modifier
2684 is used. Update the commentary.
2685
2686 * eval.c (verror): Simplify calculation of size_t.
2687
2688 * coding.c (Ffind_operation_coding_system): Fix diagnostic error
2689 messages.
2690
f61f41d7
PE
26912011-04-27 Yoshiaki Kasahara <kasahara@nc.kyushu-u.ac.jp> (tiny change)
2692
2693 * buffer.c (init_buffer) [USE_MMAP_FOR_BUFFERS]: Adjust to aliasing
2694 change.
2695
96fb4434
PE
26962011-04-27 Paul Eggert <eggert@cs.ucla.edu>
2697
2698 * nsmenu.m: Replace all uses of XVECTOR with ASIZE and AREF.
2699 This makes this file independent of the recent pseudovector change.
2700
671875da 27012011-04-26 Paul Eggert <eggert@cs.ucla.edu>
eab3844f 2702
69e9b5a3
PE
2703 * keyboard.c (handle_user_signal): Fix pointer signedness problem.
2704
b5f869a7 2705 * gnutls.c (emacs_gnutls_handle_error): Remove unused local.
7754e151 2706 (Fgnutls_boot): gnutls_certificate_verify_peers2 wants unsigned *.
8d4c3955 2707 Remove unused local.
c8926152 2708 (emacs_gnutls_write): Don't use uninitialized rtnval if nbyte <= 0.
080e5a8d 2709
841a1577 2710 * lisp.h: Fix a problem with aliasing and vector headers. (Bug#8546)
04f2d78b
CB
2711 GCC 4.6.0 optimizes based on type-based alias analysis.
2712 For example, if b is of type struct buffer * and v of type struct
eab3844f
PE
2713 Lisp_Vector *, then gcc -O2 was incorrectly assuming that &b->size
2714 != &v->size, and therefore "v->size = 1; b->size = 2; return
2715 v->size;" must therefore return 1. This assumption is incorrect
2716 for Emacs, since it type-puns struct Lisp_Vector * with many other
2717 types. To fix this problem, this patch adds a new type struct
f904488f 2718 vectorlike_header that documents the constraints on layout of vectors
eab3844f
PE
2719 and pseudovectors, and helps optimizing compilers not get fooled
2720 by Emacs's type punning. It also adds the macros XSETTYPED_PVECTYPE
2721 XSETTYPED_PSEUDOVECTOR, TYPED_PSEUDOVECTORP, for similar reasons.
f904488f
PE
2722 * lisp.h (XSETTYPED_PVECTYPE): New macro, specifying the name of
2723 the size member.
eab3844f
PE
2724 (XSETPVECTYPE): Rewrite in terms of new macro.
2725 (XSETPVECTYPESIZE): New macro, specifying both type and size.
2726 This is a bit clearer, and further avoids the possibility of
2727 undesirable aliasing.
2728 (XSETTYPED_PSEUDOVECTOR): New macro, specifying the size.
f904488f 2729 (XSETPSEUDOVECTOR): Rewrite in terms of XSETTYPED_PSEUDOVECTOR.
eab3844f
PE
2730 (XSETSUBR): Rewrite in terms of XSETTYPED_PSEUDOVECTOR and XSIZE,
2731 since Lisp_Subr is a special case (no "next" field).
04f2d78b
CB
2732 (ASIZE): Now uses header.size rather than size.
2733 All previous uses of XVECTOR (foo)->size replaced to use this macro,
f904488f
PE
2734 to avoid the hassle of writing XVECTOR (foo)->header.size.
2735 (struct vectorlike_header): New type.
eab3844f
PE
2736 (TYPED_PSEUDOVECTORP): New macro, also specifying the C type of the
2737 object, to help avoid aliasing.
2738 (PSEUDOVECTORP): Rewrite in terms of TYPED_PSEUDOVECTORP.
2739 (SUBRP): Likewise, since Lisp_Subr is a special case.
2740 * lisp.h (struct Lisp_Vector, struct Lisp_Char_Table):
2741 (struct Lisp_Sub_Char_Table, struct Lisp_Bool_Vector):
2742 (struct Lisp_Hash_Table): Combine first two members into a single
f904488f 2743 struct vectorlike_header member. All uses of "size" and "next" members
eab3844f
PE
2744 changed to be "header.size" and "header.next".
2745 * buffer.h (struct buffer): Likewise.
2746 * font.h (struct font_spec, struct font_entity, struct font): Likewise.
2747 * frame.h (struct frame): Likewise.
2748 * process.h (struct Lisp_Process): Likewise.
2749 * termhooks.h (struct terminal): Likewise.
2750 * window.c (struct save_window_data, struct saved_window): Likewise.
2751 * window.h (struct window): Likewise.
2752 * alloc.c (allocate_buffer, Fmake_bool_vector, allocate_pseudovector):
2753 Use XSETPVECTYPESIZE, not XSETPVECTYPE, to avoid aliasing problems.
2754 * buffer.c (init_buffer_once): Likewise.
2755 * lread.c (defsubr): Use XSETTYPED_PVECTYPE, since Lisp_Subr is a
2756 special case.
2757 * process.c (Fformat_network_address): Use local var for size,
2758 for brevity.
2759
0df1eac5
PE
2760 * bytecode.c (exec_byte_code): Don't use XVECTOR before CHECK_VECTOR.
2761
847ab9d1 2762 Make the Lisp reader and string-to-float more consistent (Bug#8525)
452f4150
PE
2763 * data.c (atof): Remove decl; no longer used or needed.
2764 (digit_to_number): Move to lread.c.
2765 (Fstring_to_number): Use new string_to_number function, to be
2766 consistent with how the Lisp reader treats infinities and NaNs.
2767 Do not assume that floating-point numbers represent EMACS_INT
2768 without losing information; this is not true on most 64-bit hosts.
2769 Avoid double-rounding errors, by insisting on integers when
2770 parsing non-base-10 numbers, as the documentation specifies.
2771 * lisp.h (string_to_number): New decl, replacing ...
2772 (isfloat_string): Remove.
bc0a5c13 2773 * lread.c: Include <inttypes.h>, for uintmax_t and strtoumax.
d78050d6 2774 (read1): Do not accept +. and -. as integers; this
452f4150
PE
2775 appears to have been a coding error. Similarly, do not accept
2776 strings like +-1e0 as floating point numbers. Do not report
2777 overflow for integer overflows unless the base is not 10 which
2778 means we have no simple and reliable way to continue.
2779 Break out the floating-point parsing into a new
2780 function string_to_number, so that Fstring_to_number parses
2781 floating point numbers consistently with the Lisp reader.
04f2d78b 2782 (digit_to_number): Move here from data.c. Make it static inline.
452f4150
PE
2783 (E_CHAR, EXP_INT): Remove, replacing with ...
2784 (E_EXP): New macro, to solve the "1.0e+" problem mentioned below.
2785 (string_to_number): New function, replacing isfloat_string.
2786 This function checks for valid syntax and produces the resulting
2787 Lisp float number too. Rework it so that string-to-number
bc0a5c13 2788 no longer mishandles examples like "1.0e+". Use strtoumax,
d78050d6
PE
2789 so that overflow for non-base-10 numbers is reported only when
2790 there's no portable and simple way to convert to floating point.
452f4150 2791
67769ffc
PE
2792 * textprop.c (set_text_properties_1): Rewrite for clarity,
2793 and to avoid GCC warning about integer overflow.
2794
c20db43f
PE
2795 * intervals.h (struct interval): Use EMACS_INT for members
2796 where EMACS_UINT might cause problems. See
2797 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00514.html>.
2798 (CHECK_TOTAL_LENGTH): Remove cast to EMACS_INT; no longer needed.
2799 * intervals.c (interval_deletion_adjustment): Now returns EMACS_INT.
2800 All uses changed.
37aa2f85
PE
2801 (offset_intervals): Tell GCC not to worry about length overflow
2802 when negating a negative length.
c20db43f 2803
2538aa2f
PE
2804 * alloc.c (overrun_check_malloc, overrun_check_realloc): Now static.
2805 (overrun_check_free): Likewise.
2806
f2d3008d
PE
2807 * alloc.c (SDATA_SIZE) [!GC_CHECK_STRING_BYTES]: Avoid runtime check
2808 in the common case where SDATA_DATA_OFFSET is a multiple of Emacs
2809 word size.
2810
ec8df744
PE
2811 * gnutls.c: Fix problems found by GCC 4.6.0 on Ubuntu 10.10.
2812 (gnutls_make_error): Rename local to avoid shadowing.
2813 (gnutls_emacs_global_deinit): ifdef out; not used.
2814 (Fgnutls_boot): Use const for pointer to readonly storage.
2815 Comment out unused local. Fix pointer signedness problems.
2816
640ee02d
PE
2817 * lread.c (openp): Don't stuff size_t into an 'int'.
2818 Use <= on length, not < on length + 1, to avoid GCC 4.6.0 warning
2819 about possible signed overflow.
2820
6048fb2a
PE
2821 * gtkutil.c: Fix problems found by GCC 4.6.0 on Ubuntu 10.10.
2822 (GDK_KEY_g): Don't define if already defined.
2823 (xg_prepare_tooltip): Avoid pointer signedness problem.
2824 (xg_set_toolkit_scroll_bar_thumb): Redo to avoid two casts.
2825
fa3c87e1
PE
2826 * process.c (Fnetwork_interface_info): Avoid left-shift undefined
2827 behavior with 1 << 31. GCC 4.6.0 warns about this on 32-bit hosts.
2828
2172544b
PE
2829 * xfns.c (Fx_window_property): Simplify a bit,
2830 to make a bit faster and to avoid GCC 4.6.0 warning.
2831 * xselect.c (x_get_window_property, x_handle_dnd_message): Likewise.
2832
9b821a21
PE
2833 * fns.c (internal_equal): Don't assume size_t fits in int.
2834
3c616cfa
PE
2835 * alloc.c (compact_small_strings): Tighten assertion a little.
2836
c2982e87
PE
2837 Replace pEd with more-general pI, and fix some printf arg casts.
2838 * lisp.h (pI): New macro, generalizing old pEd macro to other
2839 conversion specifiers. For example, use "...%"pI"d..." rather
2840 than "...%"pEd"...".
2841 (pEd): Remove. All uses replaced with similar uses of pI.
2842 * src/m/amdx86-64.h, src/m/ia64.h, src/m/ibms390x.h: Likewise.
2843 * alloc.c (check_pure_size): Don't overflow by converting size to int.
2844 * bidi.c (bidi_dump_cached_states): Use pI to avoid cast.
2845 * data.c (Fnumber_to_string): Use pI instead of if-then-else-abort.
2846 * dbusbind.c (xd_append_arg): Use pI to avoid cast.
2847 (Fdbus_method_return_internal, Fdbus_method_error_internal): Likewise.
2848 * font.c (font_unparse_xlfd): Avoid potential buffer overrun on
2849 64-bit hosts.
2850 (font_unparse_xlfd, font_unparse_fcname): Use pI to avoid casts.
2851 * keyboard.c (record_char, modify_event_symbol): Use pI to avoid casts.
2852 * print.c (safe_debug_print, print_object): Likewise.
2853 (print_object): Don't overflow by converting EMACS_INT or EMACS_UINT
2854 to int.
6f04d126
PE
2855 Use pI instead of if-then-else-abort. Use %p to avoid casts,
2856 avoiding the 0 flag, which is not portable.
c2982e87
PE
2857 * process.c (Fmake_network_process): Use pI to avoid cast.
2858 * region-cache.c (pp_cache): Likewise.
2859 * xdisp.c (decode_mode_spec): Likewise.
2860 * xrdb.c (x_load_resources) [USE_MOTIF]: Use pI to avoid undefined
2861 behavior on 64-bit hosts with printf arg.
6f04d126 2862 * xselect.c (x_queue_event): Use %p to avoid casts, avoiding 0 flag.
c2982e87
PE
2863 (x_stop_queuing_selection_requests): Likewise.
2864 (x_get_window_property): Don't truncate byte count to an 'int'
2865 when tracing.
0b432f21 2866
5e073ec7
PE
2867 * frame.c (frame_name_fnn_p): Get rid of strtol, which isn't right
2868 here, since it parses constructs like leading '-' and spaces,
2869 which are not wanted; and it overflows with large numbers.
2870 Instead, simply match F[0-9]+, which is what is wanted anyway.
2871
36372bf9
PE
2872 * alloc.c: Remove unportable assumptions about struct layout.
2873 (SDATA_SELECTOR, SDATA_DATA_OFFSET): New macros.
2874 (SDATA_OF_STRING, SDATA_SIZE, allocate_string_data):
2875 (allocate_vectorlike, make_pure_vector): Use the new macros,
2876 plus offsetof, to remove unportable assumptions about struct layout.
2877 These assumptions hold on all porting targets that I know of, but
2878 they are not guaranteed, they're easy to remove, and removing them
2879 makes further changes easier.
2880
0b432f21
PE
2881 * alloc.c (BLOCK BYTES): Fix typo by changing "ablock" to "ablocks".
2882 This doesn't fix a bug but makes the code clearer.
bfd1c781
PE
2883 (string_overrun_cookie): Now const. Use initializers that
2884 don't formally overflow signed char, to avoid warnings.
000098c1
PE
2885 (allocate_string_data) [GC_CHECK_STRING_OVERRUN]: Fix typo that
2886 can cause Emacs to crash when string overrun checking is enabled.
c7bda33c
PE
2887 (allocate_buffer): Don't assume sizeof (struct buffer) is a
2888 multiple of sizeof (EMACS_INT); it need not be, if
2889 alignof(EMACS_INT) < sizeof (EMACS_INT).
d0f4e1f5 2890 (check_sblock, check_string_bytes, check_string_free_list): Protoize.
0b432f21 2891
895009e1
JB
28922011-04-26 Juanma Barranquero <lekktu@gmail.com>
2893
2894 * keyboard.c (QCrtl): Rename from Qrtl. All uses changed.
2895
6a7a1b0b
TZ
28962011-04-26 Teodor Zlatanov <tzz@lifelogs.com>
2897
2898 * gnutls.c (emacs_gnutls_handshake): Return an error if we're not
b5f869a7 2899 supposed to be handshaking. (Bug#8556)
6a7a1b0b
TZ
2900 Reported by Paul Eggert <eggert@cs.ucla.edu>.
2901
841a1577 29022011-04-26 Daniel Colascione <dan.colascione@gmail.com>
0438ce91
DC
2903
2904 * lisp.h (Qdebug): List symbol.
895009e1 2905 * eval.c (Qdebug): Restore global linkage.
0438ce91
DC
2906 * keyboard.c (debug-on-event): New variable.
2907 (handle_user_signal): Break into debugger when debug-on-event
2908 matches the current signal symbol.
2909
f2d3ba6f
DN
29102011-04-25 Dan Nicolaescu <dann@ics.uci.edu>
2911
2912 * alloc.c (check_sblock, check_string_bytes)
2913 (check_string_free_list): Convert to standard C.
2914
42ce4c63
TZ
29152011-04-25 Teodor Zlatanov <tzz@lifelogs.com>
2916
2917 * w32.c (emacs_gnutls_push): Fix typo.
2918
825cd63c
EZ
29192011-04-25 Eli Zaretskii <eliz@gnu.org>
2920
fb11d64d
EZ
2921 * gnutls.c (emacs_gnutls_handshake): Avoid compiler warnings about
2922 "cast to pointer from integer of different size".
2923
825cd63c
EZ
2924 Improve doprnt and its use in verror. (Bug#8545)
2925 * doprnt.c (doprnt): Document the set of format control sequences
2926 supported by the function. Use SAFE_ALLOCA instead of always
2927 using `alloca'.
2928
2929 * eval.c (verror): Don't limit the buffer size at size_max-1, that
2930 is one byte too soon. Don't use xrealloc; instead xfree and
2931 xmalloc anew.
2932
e061a11b
TZ
29332011-04-24 Teodor Zlatanov <tzz@lifelogs.com>
2934
2935 * gnutls.h: Add GNUTLS_STAGE_CALLBACKS enum to denote we're in the
2936 callbacks stage.
2937
2938 * gnutls.c: Renamed global_initialized to
2939 gnutls_global_initialized. Added internals for the
2940 :verify-hostname-error, :verify-error, and :verify-flags
2941 parameters of `gnutls-boot' and documented those parameters in the
2942 docstring. Start callback support.
9173deec
JB
2943 (emacs_gnutls_handshake): Add Woe32 support. Retry handshake
2944 unless a fatal error occurred. Call gnutls_alert_send_appropriate
2945 on error. Return error code.
e061a11b
TZ
2946 (emacs_gnutls_write): Call emacs_gnutls_handle_error.
2947 (emacs_gnutls_read): Likewise.
2948 (Fgnutls_boot): Return handshake error code.
2949 (emacs_gnutls_handle_error): New function.
2950 (wsaerror_to_errno): Likewise.
2951
2952 * w32.h (emacs_gnutls_pull): Add prototype.
2953 (emacs_gnutls_push): Likewise.
2954
2955 * w32.c (emacs_gnutls_pull): New function for GnuTLS on Woe32.
2956 (emacs_gnutls_push): Likewise.
2957
29582011-04-24 Claudio Bley <claudio.bley@gmail.com> (tiny change)
2959
2960 * process.c (wait_reading_process_output): Check if GnuTLS
2961 buffered some data internally if no FDs are set for TLS
2962 connections.
2963
2964 * makefile.w32-in (OBJ2): Add gnutls.$(O).
2965 (LIBS): Link to USER_LIBS.
2966 ($(BLD)/gnutls.$(0)): New target.
2967
fa6996bc
EZ
29682011-04-24 Eli Zaretskii <eliz@gnu.org>
2969
eb35682e
EZ
2970 * xdisp.c (handle_single_display_spec): Rename the
2971 display_replaced_before_p argument into display_replaced_p, to
2972 make it consistent with the commentary. Fix typos in the
2973 commentary.
2974
e2ad650c
EZ
2975 * textprop.c (syms_of_textprop): Remove dead code.
2976 (copy_text_properties): Delete obsolete commentary about an
2977 interface that was deleted long ago. Fix typos in the description
2978 of arguments.
2979
1b2de274
EZ
2980 * msdos.c (XMenuActivate, XMenuAddSelection): Adjust argument list
2981 to changes in oldXMenu/XMenu.h from 2011-04-16.
2982 <menu_help_message, prev_menu_help_message>: Constify.
2983 (IT_menu_make_room): menu->help_text is now `const char **';
2984 adjust.
2985
2986 * msdos.h (XMenuActivate, XMenuAddSelection): Adjust prototypes
2987 to changes in oldXMenu/XMenu.h from 2011-04-16.
2988 (struct XMenu): Declare `help_text' `const char **'.
2989
2990 * xfaces.c <Qunspecified>: Make extern again.
2991
2992 * syntax.c: Include sys/types.h before including regex.h, as
2993 required by Posix.
2994
762b15be
EZ
2995 * doc.c (get_doc_string): Improve the format passed to `error'.
2996
2997 * doprnt.c (doprnt): Improve commentary.
2998
2999 * term.c (init_tty) [MSDOS]: Fix 1st argument to maybe_fatal.
3000
3001 * Makefile.in (TAGS): Depend on $(M_FILE) and $(S_FILE), and scan
3002 them with etags.
3003
f1052e5d
EZ
3004 * makefile.w32-in (globals.h): Add a dummy recipe, to make any
3005 changes in globals.h immediately force recompilation.
762b15be
EZ
3006 (TAGS): Depend on $(CURDIR)/m/intel386.h and
3007 $(CURDIR)/s/ms-w32.h.
3008 (TAGS-gmake): Scan $(CURDIR)/m/intel386.h and $(CURDIR)/s/ms-w32.h.
f1052e5d 3009
fa6996bc
EZ
3010 * character.c (Fchar_direction): Function deleted.
3011 (syms_of_character): Don't defsubr it.
3012 <char-direction-table>: Deleted.
3013
e6c3da20
EZ
30142011-04-23 Eli Zaretskii <eliz@gnu.org>
3015
3016 Fix doprnt so it could be used again safely in `verror'. (Bug#8435)
3017 * doprnt.c: Include limits.h.
3018 (SIZE_MAX): New macro.
04f2d78b
CB
3019 (doprnt): Return a size_t value. 2nd arg is now size_t.
3020 Many local variables are now size_t instead of int or unsigned.
e6c3da20
EZ
3021 Improve overflow protection. Support `l' modifier for integer
3022 conversions. Support %l conversion. Don't assume an EMACS_INT
3023 argument for integer conversions and for %c.
3024
3025 * lisp.h (doprnt): Restore prototype.
3026
3027 * makefile.w32-in ($(BLD)/callint.$(O)): Depend on
3028 $(SRC)/character.h.
3029
3030 * Makefile.in (base_obj): Add back doprnt.o.
3031
3032 * deps.mk (doprnt.o): Add back prerequisites.
3033 (callint.o): Depend on character.h.
3034
3035 * eval.c (internal_lisp_condition_case): Include the handler
3036 representation in the error message.
3037 (verror): Call doprnt instead of vsnprintf. Fix an off-by-one bug
3038 when breaking from the loop.
3039
3040 * xdisp.c (vmessage): Call doprnt instead of vsnprintf.
3041
3042 * callint.c (Fcall_interactively): When displaying error message
3043 about invalid control letter, pass the character's codepoint, not
3044 a pointer to its multibyte form. Improve display of the character
3045 in octal and display also its hex code.
3046
3047 * character.c (char_string): Use %x to display the (unsigned)
3048 codepoint of an invalid character, to avoid displaying a bogus
3049 negative value.
3050
3051 * font.c (check_otf_features): Pass SDATA of SYMBOL_NAME to
3052 `error', not SYMBOL_NAME itself.
3053
3054 * coding.c (Fencode_sjis_char, Fencode_big5_char): Use %c for
3055 character arguments to `error'.
3056
3057 * charset.c (check_iso_charset_parameter): Fix incorrect argument
3058 to `error' in error message about FINAL_CHAR argument. Make sure
3059 FINAL_CHAR is a character, and use %c when it is passed as
3060 argument to `error'.
3061
4ffd0d6b 30622011-04-23 Eli Zaretskii <eliz@gnu.org>
97a93095
EZ
3063
3064 * s/ms-w32.h (localtime): Redirect to sys_localtime.
3065
3066 * w32.c: Include <time.h>.
3067 (sys_localtime): New function.
3068
4ffd0d6b 30692011-04-23 Chong Yidong <cyd@stupidchicken.com>
c17819f4
CY
3070
3071 * xdisp.c (init_xdisp): Initialize echo_area_window (Bug#6451).
3072
4ffd0d6b 3073 * buffer.c (syms_of_buffer): Doc fix (Bug#6902).
aac0c6e3 3074
4ffd0d6b 30752011-04-23 Samuel Thibault <sthibault@debian.org> (tiny change)
aac0c6e3 3076
4ffd0d6b
GM
3077 * sysdep.c (wait_for_termination): On GNU Hurd, kill returns -1 on
3078 zombies (Bug#8467).
aac0c6e3 3079
04c56954
EZ
30802011-04-19 Eli Zaretskii <eliz@gnu.org>
3081
3082 * syntax.h (SETUP_SYNTAX_TABLE_FOR_OBJECT): Fix setting of
3083 gl_state.e_property when gl_state.object is Qt.
3084
3085 * insdel.c (make_gap_larger): Remove limitation of buffer size
3086 to <= INT_MAX.
3087
16a43933
CY
30882011-04-18 Chong Yidong <cyd@stupidchicken.com>
3089
3090 * xdisp.c (lookup_glyphless_char_display)
3091 (produce_glyphless_glyph): Handle cons cell entry in
3092 glyphless-char-display.
3093 (Vglyphless_char_display): Document it.
3094
3095 * term.c (produce_glyphless_glyph): Handle cons cell entry in
3096 glyphless-char-display.
3097
4581706e
CY
30982011-04-17 Chong Yidong <cyd@stupidchicken.com>
3099
3100 * xdisp.c (get_next_display_element): Remove unnecessary ifdefs.
3101
3102 * termhooks.h (FRAME_WINDOW_P): Remove duplicated definitions.
3103
3104 * dispextern.h (FACE_SUITABLE_FOR_ASCII_CHAR_P): Add missing
3105 definition for no-X builds.
3106
4887c6e2 31072011-04-16 Paul Eggert <eggert@cs.ucla.edu>
764430a3 3108
fd35b6f9
PE
3109 Static checks with GCC 4.6.0 and non-default toolkits.
3110
5c1ccb01
PE
3111 * s/sol2-6.h, s/unixware.h (PTY_TTY_NAME_SPRINTF): Protoize decl.
3112
006c5daa
PE
3113 * process.c (keyboard_bit_set): Define only if SIGIO.
3114 (send_process_trap): Mark it with NO_RETURN if it doesn't return.
3115 (send_process): Repair possible setjmp clobbering.
3116
efc736d3
PE
3117 * s/usg5-4-common.h (SETUP_SLAVE_PTY): Don't pass extra arg to 'fatal'.
3118
4e2fe2e6
PE
3119 * eval.c: Include <stdio.h>, for vsnprintf on non-GNU/Linux hosts.
3120
f97334a2
PE
3121 * data.c (arith_error): Mark with NO_RETURN if it doesn't return.
3122
4e75f29d
PE
3123 * alloc.c (bytes_used_when_full, SPARE_MEMORY, BYTES_USED):
3124 Define only if needed.
3125
90efadd1
PE
3126 * sysdep.c (_FILE_OFFSET_BITS): Make this hack even uglier
3127 by pacifying GCC about it. Maybe it's time to retire it?
875975e9 3128 * xfaces.c (USG, __TIMEVAL__): Likewise.
90efadd1 3129
3c647824
PE
3130 * dispextern.h (struct redisplay_interface): Rename param
3131 to avoid shadowing.
e264f262 3132 * termhooks.h (struct terminal): Likewise.
761383f4 3133 * xterm.c (xembed_send_message): Likewise.
3c647824 3134
b58c5c4a
PE
3135 * insdel.c (make_gap_smaller): Define only if
3136 USE_MMAP_FOR_BUFFERS || REL_ALLOC || DOUG_LEA_MALLOC.
3137
cad59032
PE
3138 * keyboard.c (read_char): Make a var volatile so longjmp won't clobber
3139 it.
3140
c339dc2e
PE
3141 * emacs.c (MAX_HEAP_BSS_DIFF, my_edata): Move to where they're used,
3142 so that we aren't warned about unused symbols.
3143
91a3e27b
PE
3144 * xfns.c (Fx_file_dialog): Rename local to avoid shadowing.
3145
399c71d3 3146 * xdisp.c (x_produce_glyphs): Mark var as initialized (Bug#8512).
7a3fb125 3147
8ffc96f5
PE
3148 * xfns.c (x_real_positions): Mark locals as initialized.
3149
eef9bc79
PE
3150 * xmenu.c (xmenu_show): Don't use uninitialized vars.
3151
098db9dd
PE
3152 * xterm.c: Fix problems found by static analysis with other toolkits.
3153 (toolkit_scroll_bar_interaction): Define and use only if USE_X_TOOLKIT.
dda3aedd
PE
3154 (x_dispatch_event): Declare static if USE_GTK, and
3155 define if USE_GTK || USE_X_TOOLKIT.
098db9dd 3156 (SET_SAVED_BUTTON_EVENT): Define only if USE_X_TOOLKIT || USE_GTK.
dda3aedd 3157 * xterm.h (x_dispatch_event): Extern only if USE_X_TOOLKIT.
841a1577
JB
3158 * xterm.c, xterm.h (x_mouse_leave): Bring this function back, but only
3159 if defined HAVE_MENUS && !defined USE_X_TOOLKIT && !defined USE_GTK.
098db9dd 3160
eb18f6cc
PE
3161 * xmenu.c (menu_help_callback): Pointer type fixes.
3162 Use const pointers when pointing at readonly data. Avoid pointer
3163 signedness clashes.
3164 (FALSE): Remove unused macro.
3165 (update_frame_menubar): Remove unused decl.
3166
1fe72bf8
PE
3167 * xfns.c (Fx_hide_tip): Move locals to avoid shadowing.
3168
60d9e1db
PE
3169 * menu.c (push_submenu_start, push_submenu_end): Do not define unless
3170 USE_X_TOOLKIT || USE_GTK || HAVE_NS || defined HAVE_NTGUI.
3171 (single_menu_item): Rename local to avoid shadowing.
3172
39261c26
PE
3173 * keyboard.c (make_lispy_event): Remove unused local var.
3174
018c5e19
PE
3175 * frame.c, frame.h (x_get_resource_string): Bring this back, but
3176 only if HAVE_X_WINDOWS && !USE_X_TOOLKIT.
3177
63d2b86e
PE
3178 * bitmaps: Change bitmaps from unsigned char back to the X11
3179 compatible char. Avoid the old compiler warnings about
3180 out-of-range initializers by using, for example, '\xab' rather
3181 than 0xab.
3182
aefd87e1
PE
3183 * xgselect.c (xgselect_initialize): Check vs interface
3184 even if ! (defined (USE_GTK) || defined (HAVE_GCONF)).
3185
bf501fb9
PE
3186 * xmenu.c (xmenu_show): Rename parm to avoid shadowing.
3187
e9829fdf
PE
3188 * xterm.c (x_create_toolkit_scroll_bar): Use const * for pointers
3189 to read-only memory.
3190
1086c095
PE
3191 * fns.c (vector): Remove; this old hack is no longer needed.
3192
2baccd04 3193 * xsmfns.c (create_client_leader_window): Rename shadowing arg.
401f10cb 3194 Remove unused var.
dde42981 3195 (gdk_x11_set_sm_client_id) [!USE_GTK]: Don't define.
2baccd04 3196
72391843 3197 * xrdb.c (x_load_resources): Omit unused local.
3565b346 3198
436c16df 3199 * xfns.c (free_frame_menubar, atof): Remove duplicate decls.
8a94ea33 3200 (x_window): Rename locals to avoid shadowing.
dc5ddd85 3201 (USG): Use the kludged USG macro, to pacify gcc.
436c16df 3202
92bb796d 3203 * xterm.c (x_alloc_nearest_color_for_widget): Remove; unused.
bbbef9e1 3204 (x_term_init): Remove local to avoid shadowing.
92bb796d 3205
764430a3 3206 * xfns.c, xterm.c (_XEditResCheckMessages): Protoize decl.
4887c6e2
PE
3207
3208 * xdisp.c, dispextern.h (set_vertical_scroll_bar): Now extern if
3209 USE_TOOLKIT_SCROLL_BARS && !USE_GTK, as xterm.c needs it then.
3210
d1dfb56c
EZ
32112011-04-16 Eli Zaretskii <eliz@gnu.org>
3212
c4354cb4
EZ
3213 * gnutls.c (Fgnutls_boot): Don't pass Lisp_Object to `error'.
3214
d1dfb56c
EZ
3215 Fix regex.c, syntax.c and friends for buffers > 2GB.
3216 * syntax.h (struct gl_state_s): Declare character position members
3217 EMACS_INT.
3218
3219 * syntax.c (update_syntax_table): Declare 2nd argument EMACS_INT.
3220
04f2d78b
CB
3221 * textprop.c (verify_interval_modification, interval_of):
3222 Declare arguments EMACS_INT.
d1dfb56c
EZ
3223
3224 * intervals.c (adjust_intervals_for_insertion): Declare arguments
3225 EMACS_INT.
3226
3227 * intervals.h (CHECK_TOTAL_LENGTH): Cast to EMACS_INT, not `int'.
3228
3229 * indent.c (Fvertical_motion): Local variable it_start is now
3230 EMACS_INT.
3231
3232 * regex.c (re_match, re_match_2, re_match_2_internal)
3233 (bcmp_translate, regcomp, regexec, print_double_string)
3234 (group_in_compile_stack, re_search, re_search_2, regex_compile)
3235 (re_compile_pattern, re_exec): Declare arguments and local
3236 variables `size_t' and `ssize_t' and return values `regoff_t', as
3237 appropriate.
3238 (POP_FAILURE_REG_OR_COUNT) <pfreg>: Declare `long'.
3239 (CHECK_INFINITE_LOOP) <failure>: Declare `ssize_t'.
3240 <compile_stack_type>: `size' and `avail' are now `size_t'.
3241
3242 * regex.h <regoff_t>: Use ssize_t, not int.
3243 (re_search, re_search_2, re_match, re_match_2): Arguments that
3244 specify buffer/string position and length are now ssize_t and
3245 size_t. Return type is regoff_t.
3246
613052cd
BK
32472011-04-16 Ben Key <bkey76@gmail.com>
3248
3249 * nsfont.m: Fixed bugs in ns_get_family and
3250 ns_descriptor_to_entity that were caused by using free to
3251 deallocate memory blocks that were allocated by xmalloc (via
3252 xstrdup). This caused Emacs to crash when compiled with
3253 XMALLOC_OVERRUN_CHECK defined (when Emacs was configured with
3254 --enable-checking=xmallocoverrun). xfree is now used to
3255 deallocate these memory blocks.
3256
4170f62f 32572011-04-15 Paul Eggert <eggert@cs.ucla.edu>
3e047f51 3258
71b41406
PE
3259 * sysdep.c (emacs_read): Remove unnecessary check vs MAX_RW_COUNT.
3260
9587a89d
PE
3261 emacs_write: Accept and return EMACS_INT for sizes.
3262 See http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00514.html
3263 et seq.
3264 * gnutls.c, gnutls.h (emacs_gnutls_read, emacs_gnutls_write):
3265 Accept and return EMACS_INT.
3266 (emacs_gnutls_write): Return the number of bytes written on
3267 partial writes.
3268 * sysdep.c, lisp.h (emacs_read, emacs_write): Likewise.
273a5f82
PE
3269 (emacs_read, emacs_write): Remove check for negative size, as the
3270 Emacs source code has been audited now.
9587a89d
PE
3271 * sysdep.c (MAX_RW_COUNT): New macro, to work around kernel bugs.
3272 (emacs_read, emacs_write): Use it.
273a5f82
PE
3273 * process.c (send_process): Adjust to the new signatures of
3274 emacs_write and emacs_gnutls_write. Do not attempt to store
3275 a byte offset into an 'int'; it might overflow.
9587a89d 3276 See http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00483.html
273a5f82 3277
3e047f51
PE
3278 * sound.c: Don't assume sizes fit in 'int'.
3279 (struct sound_device.period_size, alsa_period_size):
9c3c56a7 3280 Return EMACS_INT, not int.
3e047f51 3281 (struct sound_device.write, vox_write, alsa_write):
9c3c56a7
PE
3282 Accept EMACS_INT, not int.
3283 (wav_play, au_play): Use EMACS_INT to store sizes and to
3e047f51
PE
3284 record read return values.
3285
cc39a9db
BK
32862011-04-15 Ben Key <bkey76@gmail.com>
3287
c9d0ec6d
JB
3288 * keyboard.c (Qundefined): Don't declare static since it is used
3289 in nsfns.m.
3290 * xfaces.c (Qbold, Qexpanded, Qitalic, Qcondensed): Don't declare
3291 static since they are used in nsfont.m.
cc39a9db 3292
6c60eb9f
SM
32932011-04-15 Stefan Monnier <monnier@iro.umontreal.ca>
3294
3295 * process.c (Qprocessp): Don't declare static.
3296 * lisp.h (Qprocessp): Declare again.
3297
7990b61a
JB
32982011-04-15 Juanma Barranquero <lekktu@gmail.com>
3299
3300 * font.c (Qopentype): Don't make static (used from w32uniscribe.c).
3301
5d4cb038
PE
33022011-04-14 Paul Eggert <eggert@cs.ucla.edu>
3303
8bd7b830 3304 Improve C-level modularity by making more things 'static'.
cd64ea1d 3305
e3b27b31
PE
3306 Don't publish debugger-only interfaces to other modules.
3307 * lisp.h (safe_debug_print, debug_output_compilation_hack):
3308 (verify_bytepos, count_markers): Move decls to the only modules
3309 that need them.
3310 * region-cache.h (pp_cache): Likewise.
3311 * window.h (check_all_windows): Likewise.
3312 * marker.c, print.c, region-cache.c, window.c: Decls moved here.
3313
5d4cb038
PE
3314 * sysdep.c (croak): Now static, if
3315 defined TIOCNOTTY || defined USG5 || defined CYGWIN.
3316 * syssignal.h (croak): Declare only if not static.
69003fd8
PE
3317
3318 * alloc.c (refill_memory_reserve): Now static if
3319 !defined REL_ALLOC || defined SYSTEM_MALLOC.
3320 * lisp.h (refill_memory_reserve): Declare only if not static.
93ea6e8f 3321
e87b6180
PE
3322 * xsettings.c, xsettings.h (xsettings_get_system_normal_font):
3323 Define only if USE_LUCID.
3324
ac64929e
PE
3325 * xrdb.c (x_customization_string, x_rm_string): Now static.
3326
6f37259d
PE
3327 * xmenu.c (x_menu_wait_for_event): Export only if USE_MOTIF.
3328 * xterm.h (x_menu_wait_for_event): Declare only if USE_MOTIF.
3329
1683e3ab
PE
3330 * xdisp.c (draw_row_with_mouse_face): Now static.
3331 * dispextern.h (draw_row_with_mouse_fave): Remove decl.
3332
de9c2632
PE
3333 * window.h (check_all_windows): Mark externally visible.
3334
2b96acb7
PE
3335 * window.c (window_deletion_count): Now static.
3336
3337 * undo.c: Make symbols static if they're not exported.
3338 (last_undo_buffer, last_boundary_position, pending_boundary):
3339 Now static.
3340
50436f33
PE
3341 * textprop.c (interval_insert_behind_hooks): Now static.
3342 (interval_insert_in_front_hooks): Likewise.
3343
64520e5c
PE
3344 * term.c: Make symbols static if they're not exported.
3345 (tty_turn_off_highlight, get_tty_terminal, max_frame_cols):
3346 (max_frame_lines, tty_set_terminal_modes):
3347 (tty_reset_terminal_modes, tty_turn_off_highlight):
3348 (get_tty_terminal): Now static.
3349 (term_mouse_moveto): Do not define if HAVE_WINDOW_SYSTEM.
3350 * termhooks.h (term_mouse_moveto): Do not declare if
8bd7b830 3351 HAVE_WINDOW_SYSTEM.
64520e5c
PE
3352 * dispextern.h (tty_set_terminal_modes, tty_reset_terminal_modes):
3353 (tty_turn_off_highlight, get_tty_terminal): Remove decls.
3354
1fa53021
PE
3355 * sysdep.c: Make symbols static if they're not exported.
3356 (emacs_get_tty, emacs_set_tty, old_fcntl_flags, old_fcntl_owner):
3357 Now static.
3358 (sigprocmask_set, full_mask): Remove; unused.
3359 (wait_debugging): Mark as visible.
3360 * syssignal.h (SIGFULLMASK, full_mask): Remove decls.
3361 * systty.h (emacs_get_tty, emacs_set_tty): Remove decls.
3362
d4b43b22
PE
3363 * syntax.c (syntax_temp): Define only if !__GNUC__.
3364
b7c513d0
PE
3365 * sound.c (current_sound_device, current_sound): Now static.
3366
989b29ad
PE
3367 * search.c (searchbufs, searchbuf_head): Now static.
3368
13a55a78
PE
3369 * scroll.c (scroll_cost): Remove; unused.
3370 * dispextern.h (scroll_cost): Remove decl.
3371
de68a1fc
PE
3372 * region-cache.h (pp_cache): Mark as externally visible.
3373
40ccffa6
PE
3374 * process.c: Make symbols static if they're not exported.
3375 (process_tick, update_tick, create_process, chan_process):
3376 (Vprocess_alist, proc_buffered_char, datagram_access):
3377 (fd_callback_data, send_process_frame, process_sent_to): Now static.
3378 (deactivate_process): Mark defn as static, as well as decl.
3379 * lisp.h (create_process): Remove decl.
3380 * process.h (chan_process, Vprocess_alist): Remove decls.
3381
ad64fc97
PE
3382 * print.c: Make symbols static if they're not exported.
3383 (print_depth, new_backquote_output, being_printed, print_buffer):
3384 (print_buffer_size, print_buffer_pos, print_buffer_pos_byte):
3385 (print_interval, print_number_index, initial_stderr_stream):
3386 Now static.
3387 * lisp.h (Fprinc): Remove decl.
3388 (debug_output_compilation_hack): Mark as externally visible.
3389
adddb265
PE
3390 * sysdep.c (croak): Move decl from here to syssignal.h.
3391 * syssignal.h (croak): Put it here, so the API can be checked when
3392 'croak' is called from dissociate_if_controlling_tty.
3393
1717ede2
PE
3394 * minibuf.c: Make symbols static if they're not exported.
3395 (minibuf_save_list, choose_minibuf_frame): Now static.
3396 * lisp.h (choose_minibuf_frame): Remove decl.
3397
fa5fb2bc
PE
3398 * lisp.h (verify_bytepos, count_markers): Mark as externally visible.
3399
1e3890d1
PE
3400 * lread.c: Make symbols static if they're not exported.
3401 (read_objects, initial_obarray, oblookup_last_bucket_number):
3402 Now static.
3403 (make_symbol): Remove; unused.
3404 * lisp.h (initial_obarray, make_symbol): Remove decls.
3405
8a1414fa
PE
3406 * keyboard.c: Make symbols static if they're not exported.
3407 (single_kboard, recent_keys_index, total_keys, recent_keys):
3408 (this_command_key_count_reset, raw_keybuf, raw_keybuf_count):
3409 (this_single_command_key_start, echoing, last_auto_save):
3410 (read_key_sequence_cmd, dribble, recursive_edit_unwind):
3411 (command_loop, echo_now, keyboard_init_hook, help_char_p):
3412 (quit_throw_to_read_char, command_loop_2, top_level_1, poll_timer):
3413 (Vlispy_mouse_stem, double_click_count):
3414 Now static.
3415 (force_auto_save_soon): Define only if SIGDANGER.
3416 (ignore_mouse_drag_p): Now static if
3417 !defined HAVE_WINDOW_SYSTEM || defined USE_GTK || defined HAVE_NS.
3418 (print_help): Remove; unused.
3419 (stop_character, last_timer_event): Mark as externally visible.
3420 * keyboard.h (ignore_mouse_drag_p): Declare only if
3421 defined HAVE_WINDOW_SYSTEM && !defined USE_GTK && !defined HAVE_NS.
3422 (echo_now, help_char_p, quit_throw_to_read_char): Remove decls.
3423 * lisp.h (echoing): Remove decl.
3424 (force_auto_save_soon): Declare only if SIGDANGER.
3425 * xdisp.c (redisplay_window): Simplify code, to make it more
3426 obvious that ignore_mouse_drag_p is not accessed if !defined
3427 USE_GTK && !defined HAVE_NS.
3428
93ea6e8f
PE
3429 * intervals.c: Make symbols static if they're not exported.
3430 (merge_properties_sticky, merge_interval_right, delete_interval):
3431 Now static.
3432 * intervals.h (merge_interval_right, delete_interval): Remove decls.
3433
77382fcc
PE
3434 * insdel.c: Make symbols static if they're not exported.
3435 However, leave prepare_to_modify_buffer alone. It's never
3436 called from outside this function, but that appears to be a bug.
3437 (combine_after_change_list, combine_after_change_buffer):
4889fc82 3438 (adjust_after_replace, signal_before_change): Now static.
77382fcc
PE
3439 (adjust_after_replace_noundo): Remove; unused.
3440 * lisp.h (adjust_after_replace, adjust_after_replace_noundo):
4889fc82 3441 (signal_before_change): Remove decls.
77382fcc 3442
9306c32e
PE
3443 * indent.c (val_compute_motion, val_vmotion): Now static.
3444
cd44d2eb
PE
3445 * image.c: Make symbols static if they're not exported.
3446 * dispextern.h (x_create_bitmap_from_xpm_data): Do not declare
3447 if USE_GTK.
3448 * image.c (x_create_bitmap_from_xpm_data): Do not define if USE_GTK.
3449 (xpm_color_cache, ct_table, ct_colors_allocated): Now static.
3450
ad9a7a06
PE
3451 * fringe.c (standard_bitmaps): Now static.
3452 (max_used_fringe_bitmap): Now static, unless HAVE_NS.
3453
81626931
PE
3454 * frame.c: Make symbols static if they're not exported.
3455 (x_report_frame_params, make_terminal_frame): Now static.
3456 (get_frame_param): Now static, unless HAVE_NS.
3457 (x_fullscreen_adjust): Define if WINDOWSNT, not if HAVE_WINDOW_SYSTEM.
3458 (x_get_resource_string): Remove; not used.
3459 * frame.h (make_terminal_frame, x_report_frame_params):
3460 (x_get_resource_string); Remove decls.
3461 (x_fullscreen_adjust): Declare only if WINDOWSNT.
3462 * lisp.h (get_frame_param): Declare only if HAVE_NS.
3463
239f9db9
PE
3464 * font.c, fontset.c: Make symbols static if they're not exported.
3465 * dispextern.h (FACE_SUITABLE_FOR_ASCII_CHAR_P): New macro.
3466 (FACE_SUITABLE_FOR_CHAR_P): Use it.
3467 * font.c (font_close_object): Now static.
3468 * font.h (font_close_object): Remove.
3469 * fontset.c (FONTSET_OBJLIST): Remove.
3470 (free_realized_fontset) #if-0 the body, which does nothing.
3471 (face_suitable_for_char_p): #if-0, as it's never called.
3472 * fontset.h (face_suitable_for_char_p): Remove decl.
04f2d78b
CB
3473 * xfaces.c (face_at_string_position):
3474 Use FACE_SUITABLE_FOR_ASCII_CHAR_P, not FACE_SUITABLE_FOR_CHAR_P,
239f9db9
PE
3475 since 0 is always ASCII.
3476
dfcf3579
PE
3477 * fns.c (weak_hash_tables): Now static.
3478
5045092b
PE
3479 * fileio.c: Make symbols static if they're not exported.
3480 (auto_saving, auto_save_mode_bits, auto_save_error_occurred):
3481 (Vwrite_region_annotation_buffers): Now static.
3482
57a96f5c
PE
3483 * eval.c: Make symbols static if they're not exported.
3484 (backtrace_list, lisp_eval_depth, when_entered_debugger): Now static.
3485 * lisp.h (backtrace_list): Remove decl.
3486
35f08c38
PE
3487 * emacs.c: Make symbols static if they're not exported.
3488 (malloc_state_ptr, malloc_using_checking, syms_of_emacs):
3489 (fatal_error_code, fatal_error_signal_hook, standard_args):
3490 Now static.
3491 (fatal_error_signal): Now static, unless FLOAT_CATCH_SIGKILL.
3492 (DEFINE_DUMMY_FUNCTION): Mark function as externally visible.
3493 (__CTOR_LIST__, __DTOR_LIST__): Now externally visible.
3494 * lisp.h (fatal_error_signal_hook): Remove decl.
3495 (fatal_error_signal): Declare only if FLOAT_CATCH_SIGKILL.
3496
f44bd759
PE
3497 * editfns.c: Move a (normally-unused) function to its only use.
3498 * editfns.c, lisp.h (get_operating_system_release): Remove.
3499 * process.c (init_process) [DARWIN_OS]: Do it inline, as it is not
3500 worth the hassle of breaking this out.
3501
b532497d
PE
3502 * xterm.c: Make symbols static if they're not exported.
3503 (x_raise_frame, x_lower_frame, x_wm_set_window_state):
3504 (x_wm_set_icon_pixmap, x_initialize, XTread_socket_fake_io_error):
3505 (x_destroy_window, x_delete_display):
3506 Now static.
3507 (x_dispatch_event): Now static if ! (USE_MOTIF || USE_X_TOOLKIT).
3508 (x_mouse_leave): Remove; unused.
3509 * xterm.h (x_display_info_for_name, x_raise_frame, x_lower_frame):
3510 (x_destroy_window, x_wm_set_window_state, x_wm_set_icon_pixmap):
3511 (x_delete_display, x_initialize, x_set_border_pixel, x_screen_planes):
3512 Remove decls.
3513 (x_mouse_leave): Declare only if WINDOWSNT.
3514 (x_dispatch_event): Declare only if USE_MOTIF or USE_X_TOOLKIT.
3515 (xic_create_fontsetname): Declare only if HAVE_X_WINDOWS &&
3516 USE_X_TOOLKIT.
3517
1675728f
PE
3518 * ftxfont.c: Make symbols static if they're not exported.
3519 (ftxfont_driver): Export only if !defined HAVE_XFT && def8ined
3520 HAVE_FREETYPE.
3521 * font.h (ftxfont_driver): Likewise.
3522
e4cebfca
PE
3523 * xfns.c: Make symbols static if they're not exported.
3524 (x_last_font_name, x_display_info_for_name):
3525 (x_set_foreground_color, x_set_background_color, x_set_mouse_color):
3526 (x_set_cursor_color, x_set_border_pixel, x_set_border_color):
3527 (x_set_cursor_type, x_set_icon_type, x_set_icon_name):
3528 (x_set_scroll_bar_foreground, x_set_scroll_bar_background):
3529 (x_explicitly_set_name, x_set_title, xic_defaut_fontset, tip_timer):
3530 (last_show_tip_args): Now static.
3531 (xic_defaut_fontset, xic_create_fontsetname): Define only if
3532 defined HAVE_X_WINDOWS && defined USE_X_TOOLKIT
3533 (x_screen_planes): Remove; unused.
3534 * dispextern.h (x_screen_planes): Remove decl.
3535
5bf46f05
PE
3536 * dispnew.c: Make symbols static if they're not exported.
3537 * dispextern.h (redraw_garbaged_frames, scrolling):
3538 (increment_row_positions): Remove.
3539 * dispnew.c (new_glyph_matrix, increment_row_positions, scrolling):
3540 (delayed_size_change, glyph_matrix_count, glyph_pool_count):
3541 Now static.
3542 (redraw_garbaged_frames): Remove; unused.
3543
435f4c28
PE
3544 * xfaces.c: Make symbols static if they're not exported.
3545 * dispextern.h (ascii_face_of_lisp_face, free_realized_face):
3546 Remove decls.
3547 * xterm.h (defined_color): Remove decls.
3548 (x_free_dpy_colors): Declare only if USE_X_TOOLKIT.
3549 * xfaces.c (tty_suppress_bold_inverse_default_colors_p):
3550 (menu_face_changed_default, defined_color, free_realized_face):
3551 (x_free_dpy_colors): Define only if USE_X_TOOLKIT.
3552 (ascii_face_of_lisp_face): Remove; unused.
3553
8524aef3
PE
3554 * xdisp.c: Make symbols static if they're not exported.
3555 * dispextern.h (scratch_glyph_row, window_box_edges):
3556 (glyph_to_pixel_coords, set_cursor_from_row):
3557 (get_next_display_element, set_iterator_to_next):
3558 (highlight_trailing_whitespace, frame_to_window_pixel_xy):
3559 (show_mouse_face): Remove decls
3560 * frame.h (message_buf_print): Likewise.
3561 * lisp.h (pop_message, set_message, check_point_in_composition):
3562 Likewise.
3563 * xterm.h (set_vertical_scroll_bar): Likewise.
3564 * xdisp.c (list_of_error, Vmessage_stack, line_number_displayed):
3565 (message_buf_print, scratch_glyph_row, displayed_buffer):
3566 (set_iterator_to_next, pop_message, set_message, set_cursor_from_row):
3567 (get_next_display_element, show_mouse_face, window_box_edges):
3568 (frame_to_window_pixel_xy, check_point_in_composition):
3569 (set_vertical_scroll_bar, highlight_trailing_whitespace): Now static.
3570 (glyph_to_pixel_coords): Remove; unused.
3571
16390cd2
PE
3572 * dired.c (file_name_completion): Now static.
3573
3574 * dbusbind.c (xd_in_read_queued_messages): Now static.
3575
a25f4dfa
PE
3576 * lisp.h (circular_list_error, FOREACH): Remove; unused.
3577 * data.c (circular_list_error): Remove.
3578
14a9c8df
PE
3579 * commands.h (last_point_position, last_point_position_buffer):
3580 (last_point_position_window): Remove decls.
3581 * keyboard.c: Make these variables static.
3582
04f2d78b
CB
3583 * coding.h (coding, code_convert_region, encode_coding_gap):
3584 Remove decls.
74ab6df5
PE
3585 * coding.c (Vsjis_coding_system, Vbig5_coding_system):
3586 (iso_code_class, detect_coding, code_convert_region): Now static.
3587 (encode_coding_gap): Remove; unused.
3588
38dfbee1
PE
3589 * chartab.c (chartab_chars, chartab_bits): Now static.
3590
a2cb4e63
PE
3591 * charset.h (charset_iso_8859_1): Remove decl.
3592 * charset.c (charset_iso_8859_1, charset_emacs, map_charset_for_dump):
3593 Now static.
3594
127198fd
PE
3595 * ccl.h (check_ccl_update, Vccl_program_table): Remove decls.
3596 * ccl.c (Vccl_program_table): Now static.
3597 (check_ccl_update): Remove; unused.
3598
d85b608f
PE
3599 * category.c (SET_CATEGORY_SET, set_category_set): Move here.
3600 * category.h: ... from here.
3601 * category.c (check_category_table, set_category_set): Now static.
3602
31cd66f3
PE
3603 * casetab.c (Vascii_upcase_table, Vascii_eqv_table): Now static.
3604 * lisp.h: Remove these decls.
3605
c358e587
PE
3606 * buffer.c (buffer_count): Remove unused var.
3607
e78aecca
PE
3608 * bidi.c (bidi_dump_cached_states): Mark as externally visible,
3609 so that it's not optimized away.
3610 (bidi_ignore_explicit_marks_for_paragraph_level): Likewise.
3611 * dispextern.h (bidi_dump_cached_states): Remove, since it's
3612 exported only to the debugger.
3613
e192d7d3 3614 * atimer.c (alarm_signal_handler, run_all_atimers): Now static.
04f2d78b 3615 * atimer.h (run_all_atimers): Remove; not exported.
e192d7d3 3616
92470028
PE
3617 font.c: Make copy_font_spec and merge_font_spec ordinary C functions.
3618 * font.c (copy_font_spec): Rename from Fcopy_font_spec, since it
3619 was inaccessible from Lisp.
3620 (merge_font_spec): Likewise, renaming from Fmerge_font_spec.
3621 * font.c, font.h, fontset.c, xfaces.c, xfont.c: Change all uses.
3622
244ed907
PE
3623 alloc.c: Import and export fewer symbols, and remove unused items.
3624 * lisp.h (suppress_checking, die): Declare only if ENABLE_CHECKING
3625 is defined.
3626 (suppress_checking): Add EXTERNALLY_VISIBLE attribute, so that
3627 it's not optimized away by whole-program optimization.
3628 (message_enable_multibyte, free_misc): Remove.
3629 (catchlist, handlerlist, mark_backtrace):
3630 Declare only if BYTE_MARK_STACK.
3631 (mark_byte_stack): Likewise, fixing a ifdef-vs-if typo.
3632 * alloc.c (pure): Export only if VIRT_ADDR_VARIES is defined.
3633 (message_enable_multibyte): Remove decl.
3634 (free_misc, interval_free_list, float_block, float_block_index):
3635 (n_float_blocks, float_free_list, cons_block, cons_block_index):
3636 (cons_free_list, last_marked_index):
3637 Now static.
3638 (suppress_checking, die): Define only if ENABLE_CHECKING is defined.
3639 * eval.c (catchlist, handlerlist): Export only if BYTE_MARK_STACK.
3640 (mark_backtrace): Define only if BYTE_MARK_STACK.
3641 * xdisp.c (message_enable_multibyte): Now static.
3642
61c2b50e 3643 Declare Lisp_Object Q* variables to be 'static' if not exported.
955cbe7b
PE
3644 This makes it easier for human readers (and static analyzers)
3645 to see whether these variables are used from other modules.
3646 * alloc.c, buffer.c, bytecode.c, callint.c, casetab.c, category.c:
3647 * ccl.c, character.c, charset.c, cmds.c, coding.c, composite.c:
3648 * data.c, dbusbind.c, dired.c, editfns.c, eval.c, fileio.c, fns.c:
3649 * font.c, frame.c, fringe.c, ftfont.c, image.c, keyboard.c, keymap.c:
3650 * lread.c, macros.c, minibuf.c, print.c, process.c, search.c:
3651 * sound.c, syntax.c, textprop.c, window.c, xdisp.c, xfaces.c, xfns.c:
3652 * xmenu.c, xselect.c:
3653 Declare Q* vars static if they are not used in other modules.
3654 * ccl.h, character.h, charset.h, coding.h, composite.h, font.h:
3655 * frame.h, intervals.h, keyboard.h, lisp.h, process.h, syntax.h:
3656 Remove decls of unexported vars.
3657 * keyboard.h (EVENT_HEAD_UNMODIFIED): Remove now-unused macro.
3658
95c82688
PE
3659 * lisp.h (DEFINE_FUNC): Make sname 'static'.
3660
16a97296
PE
3661 Make Emacs functions such as Fatom 'static' by default.
3662 This makes it easier for human readers (and static analyzers)
3663 to see whether these functions can be called from other modules.
3664 DEFUN now defines a static function. To make the function external
3665 so that it can be used in other C modules, use the new macro DEFUE.
8bd7b830
PE
3666 * lisp.h (Funibyte_char_to_multibyte, Fsyntax_table_p):
3667 (Finit_image_library):
16a97296
PE
3668 (Feval_region, Fbacktrace, Ffetch_bytecode, Fswitch_to_buffer):
3669 (Ffile_executable_p, Fmake_symbolic_link, Fcommand_execute):
3670 (Fget_process, Fdocumentation_property, Fbyte_code, Ffile_attributes):
3671 Remove decls, since these functions are now static.
3672 (Funintern, Fget_internal_run_time): New decls, since these functions
3673 were already external.
95c82688 3674
16a97296
PE
3675 * alloc.c, buffer.c, callint.c, callproc.c, casefiddle.c, casetab.c:
3676 * ccl.c, character.c, chartab.c, cmds.c, coding.c, data.c, dispnew.c:
3677 * doc.c, editfns.c, emacs.c, eval.c, fileio.c, filelock.c, floatfns.c:
3678 * fns.c, font.c, fontset.c, frame.c, image.c, indent.c:
3679 * keyboard.c, keymap.c, lread.c:
3680 * macros.c, marker.c, menu.c, minibuf.c, print.c, process.c, search.c:
3681 * syntax.c, term.c, terminal.c, textprop.c, undo.c:
3682 * window.c, xdisp.c, xfaces.c, xfns.c, xmenu.c, xsettings.c:
3683 Mark functions with DEFUE instead of DEFUN,
3684 if they are used in other modules.
3685 * buffer.c (Fset_buffer_major_mode, Fdelete_overlay): New forward
3686 decls for now-static functions.
3687 * buffer.h (Fdelete_overlay): Remove decl.
3688 * callproc.c (Fgetenv_internal): Mark as internal.
3689 * composite.c (Fremove_list_of_text_properties): Remove decl.
3690 (Fcomposition_get_gstring): New forward static decl.
3691 * composite.h (Fcomposite_get_gstring): Remove decl.
3692 * dired.c (Ffile_attributes): New forward static decl.
3693 * doc.c (Fdocumntation_property): New forward static decl.
3694 * eval.c (Ffetch_bytecode): New forward static decl.
3695 (Funintern): Remove extern decl; now in .h file where it belongs.
3696 * fileio.c (Fmake_symbolic_link): New forward static decl.
3697 * image.c (Finit_image_library): New forward static decl.
3698 * insdel.c (Fcombine_after_change_execute): Make forward decl static.
3699 * intervals.h (Fprevious_property_change):
3700 (Fremove_list_of_text_properties): Remove decls.
3701 * keyboard.c (Fthis_command_keys): Remove decl.
3702 (Fcommand_execute): New forward static decl.
3703 * keymap.c (Flookup_key): New forward static decl.
3704 (Fcopy_keymap): Now static.
3705 * keymap.h (Flookup_key): Remove decl.
3706 * process.c (Fget_process): New forward static decl.
3707 (Fprocess_datagram_address): Mark as internal.
3708 * syntax.c (Fsyntax_table_p): New forward static decl.
3709 (skip_chars): Remove duplicate decl.
3710 * textprop.c (Fprevious_property_change): New forward static decl.
3711 * window.c (Fset_window_fringes, Fset_window_scroll_bars):
3712 Now internal.
3713 (Fset_window_margins, Fset_window_vscroll): New forward static decls.
3714 * window.h (Fset_window_vscroll, Fset_window_margins): Remove decls.
3715
785bbd42
PE
3716 * editfns.c (Fformat): Remove unreachable code.
3717
8b913b57
AS
37182011-04-14 Andreas Schwab <schwab@linux-m68k.org>
3719
3720 * fileio.c (Finsert_file_contents): Fix typo in 2005-05-13
3721 change. (Bug#8496)
3722
a6744a35
EZ
37232011-04-13 Eli Zaretskii <eliz@gnu.org>
3724
3725 * xdisp.c (handle_invisible_prop): Don't call bidi_paragraph_init
3726 when at ZV. (Bug#8487)
3727
e7974947
AS
37282011-04-12 Andreas Schwab <schwab@linux-m68k.org>
3729
baad03f0
AS
3730 * charset.c (Fclear_charset_maps): Use xfree instead of free.
3731 (Bug#8437)
3732 * keyboard.c (parse_tool_bar_item): Likewise.
3733 * sound.c (sound_cleanup, alsa_close): Likewise.
3734 * termcap.c (tgetent): Likewise.
3735 * xfns.c (x_default_font_parameter): Likewise.
3736 * xsettings.c (read_and_apply_settings): Likewise.
3737
e7974947
AS
3738 * alloc.c (overrun_check_malloc, overrun_check_realloc)
3739 (overrun_check_free): Protoize.
3740
28272684
PE
37412011-04-12 Paul Eggert <eggert@cs.ucla.edu>
3742
3743 * sysdep.c (emacs_read, emacs_write): Check for negative sizes
3744 since callers should never pass a negative size.
3745 Change the signature to match that of plain 'read' and 'write'; see
3746 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00397.html>.
3747 * lisp.h: Update prototypes of emacs_write and emacs_read.
3748
11997c76
EZ
37492011-04-11 Eli Zaretskii <eliz@gnu.org>
3750
3751 * xdisp.c (redisplay_window): Don't try to determine the character
3752 position of the scroll margin if the window start point w->startp
e896f03c 3753 is outside the buffer's accessible region. (Bug#8468)
11997c76 3754
8a2cbd72
EZ
37552011-04-10 Eli Zaretskii <eliz@gnu.org>
3756
3757 Fix write-region and its subroutines for buffers > 2GB.
3758 * fileio.c (a_write, e_write): Modify declaration of arguments and
3759 local variables to support buffers larger than 2GB.
3760 (Fcopy_file): Use EMACS_INT for return value of emacs_read.
3761
3762 * sysdep.c (emacs_write, emacs_read): Use ssize_t for last
3763 argument, local variables, and return value.
3764
3765 * lisp.h: Update prototypes of emacs_write and emacs_read.
3766
3767 * sound.c (vox_write): Use ssize_t for return value of emacs_write.
3768
4073e537 37692011-04-10 Paul Eggert <eggert@cs.ucla.edu>
eb3f1cc8 3770
1ebfdcb6
PE
3771 * xdisp.c (vmessage): Use memchr, not strnlen, which some hosts lack.
3772
b2ded58d
PE
3773 Fix more problems found by GCC 4.6.0's static checks.
3774
7d66342c
PE
3775 * xdisp.c (vmessage): Use a better test for character truncation.
3776
bbf47d44
PE
3777 * charset.c (load_charset_map): <, not <=, for optimization,
3778 and to avoid potential problems with integer overflow.
9248994d 3779 * chartab.c (sub_char_table_set_range, char_table_set_range): Likewise.
f9a68bc5 3780 * casetab.c (set_identity, shuffle): Likewise.
3ab1c7ce 3781 * editfns.c (Fformat): Likewise.
1e69125e 3782 * syntax.c (skip_chars): Likewise.
3befa583 3783
e3019616
PE
3784 * xmenu.c (set_frame_menubar): Allocate smaller local vectors.
3785 This also lets GCC 4.6.0 generate slightly better loop code.
3786
becfa255
PE
3787 * callint.c (Fcall_interactively): <, not <=, for optimization.
3788 (Fcall_interactively): Count the number of arguments produced,
3789 not the number of arguments given. This is simpler and lets GCC
3790 4.6.0 generate slightly better code.
3791
dae0cd48
PE
3792 * ftfont.c: Distingish more carefully between FcChar8 and char.
3793 The previous code passed unsigned char * to a functions like
3794 strlen and xstrcasecmp that expect char *, which does not
3795 conform to the C standard.
3796 (get_adstyle_property, ftfont_pattern_entity): Use FcChar8 for
3797 arguments to FcPatternGetString, and explicitly cast FcChar8 * to
3798 char * when the C standard requires it.
3799
76032d70
PE
3800 * keyboard.c (read_char): Remove unused var.
3801
eb3f1cc8
PE
3802 * eval.c: Port to Windows vsnprintf (Bug#8435).
3803 Include <limits.h>.
3804 (SIZE_MAX): Define if the headers do not.
3805 (verror): Do not give up if vsnprintf returns a negative count.
3806 Instead, grow the buffer. This ports to Windows vsnprintf, which
3807 does not conform to C99. Problem reported by Eli Zaretskii.
3808 Also, simplify the allocation scheme, by avoiding the need for
3809 calling realloc, and removing the ALLOCATED variable.
3810
70476b54
PE
3811 * eval.c (verror): Initial buffer size is 4000 (not 200) bytes.
3812
12020a9e
PE
3813 Remove invocations of doprnt, as Emacs now uses vsnprintf.
3814 But keep the doprint source code for now, as we might revamp it
3815 and use it again (Bug#8435).
ea6c7ae6
PE
3816 * lisp.h (doprnt): Remove.
3817 * Makefile.in (base_obj): Remove doprnt.o.
3818 * deps.mk (doprnt.o): Remove.
3819
5fdb398c
PE
3820 error: Print 32- and 64-bit integers portably (Bug#8435).
3821 Without this change, on typical 64-bit hosts error ("...%d...", N)
3822 was used to print both 32- and 64-bit integers N, which relied on
3823 undefined behavior.
3824 * lisp.h, src/m/amdx86-64.h, src/m/ia64.h, src/m/ibms390x.h (pEd):
3825 New macro.
3826 * lisp.h (error, verror): Mark as printf-like functions.
3827 * eval.c (verror): Use vsnprintf, not doprnt, to do the real work.
3828 Report overflow in size calculations when allocating printf buffer.
3829 Do not truncate output string at its first null byte.
3830 * xdisp.c (vmessage): Use vsnprintf, not doprnt, to do the real work.
3831 Truncate the output at a character boundary, since vsnprintf does not
3832 do that.
3833 * charset.c (check_iso_charset_parameter): Convert internal
3834 character to string before calling 'error', since %c now has the
3835 printf meaning.
3836 * coding.c (Fdecode_sjis_char, Fdecode_big5_char): Avoid int
3837 overflow when computing char to be passed to 'error'. Do not
3838 pass Lisp_Object to 'error'; pass the integer instead.
3839 * nsfns.m (Fns_do_applescript): Use int, not long, since it's
3840 formatted with plain %d.
3841
b189fa66
PE
3842 * eval.c (internal_lisp_condition_case): Don't pass spurious arg.
3843
bff87ef0
PE
3844 * keyboard.c (access_keymap_keyremap): Print func name, not garbage.
3845
7e2cac20
PE
3846 * coding.c (Fdecode_sjis_char): Don't assume CODE fits in int.
3847
ce4d90b5
PE
3848 * xterm.c (x_catch_errors): Remove duplicate declaration.
3849
266c9547
PE
3850 * term.c (maybe_fatal): Mark its 3rd arg as a printf format, too.
3851
79c49ad2
PE
3852 * xdisp.c, lisp.h (message_nolog): Remove; unused.
3853
368f4090
JM
38542011-04-10 Jim Meyering <meyering@redhat.com>
3855
3856 use ssize_t and size_t for read- and write-like emacs_gnutls_* functions
3857 * gnutls.c (emacs_gnutls_read): Adjust signature to be more read-like:
3858 return ssize_t not "int", and use size_t as the buffer length.
3859 (emacs_gnutls_write): Likewise, and make the buffer pointer "const".
3860 * gnutls.h: Update declarations.
3861 * process.c (read_process_output): Use ssize_t, to match.
3862 (send_process): Likewise.
3863
a32d4040
CY
38642011-04-09 Chong Yidong <cyd@stupidchicken.com>
3865
3866 * image.c (Fimagemagick_types): Doc fix, and comment cleanup.
3867
8546720e 38682011-04-09 Chong Yidong <cyd@stupidchicken.com>
aac0c6e3 3869
04f2d78b
CB
3870 * ftfont.c (get_adstyle_property, ftfont_pattern_entity):
3871 Use unsigned char, to match FcChar8 type definition.
aac0c6e3 3872
8546720e
GM
3873 * xterm.c (handle_one_xevent):
3874 * xmenu.c (create_and_show_popup_menu):
3875 * xselect.c (x_decline_selection_request)
3876 (x_reply_selection_request): Avoid type-punned deref of X events.
aac0c6e3 3877
0a2f5c1a 38782011-04-09 Eli Zaretskii <eliz@gnu.org>
a53e2e89
EZ
3879
3880 Fix some uses of `int' instead of EMACS_INT.
3881 * search.c (string_match_1, fast_string_match)
3882 (fast_c_string_match_ignore_case, fast_string_match_ignore_case)
3883 (scan_buffer, find_next_newline_no_quit)
3884 (find_before_next_newline, search_command, Freplace_match)
3885 (Fmatch_data): Make some `int' variables be EMACS_INT.
3886
3887 * xdisp.c (display_count_lines): 3rd argument and return value now
3888 EMACS_INT. All callers changed.
3889 (pint2hrstr): Last argument is now EMACS_INT.
3890
3891 * coding.c (detect_coding_utf_8, detect_coding_emacs_mule)
3892 (detect_coding_iso_2022, detect_coding_sjis, detect_coding_big5)
3893 (detect_coding_ccl, detect_coding_charset, decode_coding_utf_8)
3894 (decode_coding_utf_16, decode_coding_emacs_mule)
3895 (decode_coding_iso_2022, decode_coding_sjis, decode_coding_big5)
3896 (decode_coding_ccl, decode_coding_charset)
3897 <consumed_chars, consumed_chars_base>: Declare EMACS_INT.
3898 (decode_coding_iso_2022, decode_coding_emacs_mule)
3899 (decode_coding_sjis, decode_coding_big5, decode_coding_charset)
3900 <char_offset, last_offset>: Declare EMACS_INT.
3901 (encode_coding_utf_8, encode_coding_utf_16)
3902 (encode_coding_emacs_mule, encode_invocation_designation)
3903 (encode_designation_at_bol, encode_coding_iso_2022)
3904 (encode_coding_sjis, encode_coding_big5, encode_coding_ccl)
3905 (encode_coding_raw_text, encode_coding_charset) <produced_chars>:
3906 Declare EMACS_INT.
3907 (ASSURE_DESTINATION): Declare more_bytes EMACS_INT.
3908 (encode_invocation_designation): Last argument P_NCHARS is now
3909 EMACS_INT.
3910 (decode_eol): Declare pos_byte, pos, and pos_end EMACS_INT.
3911 (produce_chars): from_nchars and to_nchars are now EMACS_INT.
3912
3913 * coding.h (struct coding_system) <head_ascii>: Declare EMACS_INT.
3914 All users changed.
3915
3916 * ccl.c (Fccl_execute_on_string): Declare some variables
3917 EMACS_INT.
3918
8546720e 39192011-04-08 Samuel Thibault <sthibault@debian.org> (tiny change)
0080dc6b
SS
3920
3921 * term.c (init_tty): Fix incorrect ifdef placement (Bug#8450).
3922
4e19a977
CS
39232011-03-19 Christoph Scholtes <cschol2112@googlemail.com>
3924
3925 * process.c (Fformat_network_address): Doc fix.
3926
87302331
R
39272011-04-08 T.V. Raman <tv.raman.tv@gmail.com> (tiny change)
3928
3929 * xml.c (parse_region): Avoid creating spurious whiespace nodes.
3930
cbb59342
CY
39312011-04-08 Chong Yidong <cyd@stupidchicken.com>
3932
3933 * keyboard.c (read_char): Call Lisp function help-form-show,
3934 instead of using internal_with_output_to_temp_buffer.
3935 (Qhelp_form_show): New var.
e0d38eeb 3936 (syms_of_keyboard): Use DEFSYM macro.
cbb59342
CY
3937
3938 * print.c (internal_with_output_to_temp_buffer): Function deleted.
3939
3940 * lisp.h (internal_with_output_to_temp_buffer): Remove prototype.
3941
e67a13ab
CY
39422011-04-06 Chong Yidong <cyd@stupidchicken.com>
3943
04f2d78b
CB
3944 * process.c (Flist_processes): Remove to Lisp.
3945 (list_processes_1): Delete.
e67a13ab 3946
973f782d
EZ
39472011-04-06 Eli Zaretskii <eliz@gnu.org>
3948
7c106b1e
EZ
3949 * msdos.c (careadlinkat, careadlinkatcwd): MS-DOS replacements.
3950
973f782d
EZ
3951 * w32.c (careadlinkat, careadlinkatcwd): New always-fail stubs.
3952
41cf7d1a 39532011-04-06 Paul Eggert <eggert@cs.ucla.edu>
27ccc379 3954
ca23cc88
PE
3955 Fix more problems found by GCC 4.6.0's static checks.
3956
f390e2d5
PE
3957 * xmenu.c (Fx_popup_dialog): Don't assume string is free of formats.
3958
42eea0d0
PE
3959 * menu.c (Fx_popup_menu): Don't assume error_name lacks printf formats.
3960
b69769da 3961 * lisp.h (message, message_nolog, fatal): Mark as printf-like.
1e973bc7 3962
f9541e84
PE
3963 * xdisp.c (vmessage): Mark as a printf-like function.
3964
13841b55
PE
3965 * term.c (vfatal, maybe_fatal): Mark as printf-like functions.
3966
c136c10f
PE
3967 * sound.c (sound_warning): Don't crash if arg contains a printf format.
3968
5e2d4a30
PE
3969 * image.c (tiff_error_handler, tiff_warning_handler): Mark as
3970 printf-like functions.
3971 (tiff_load): Add casts to remove these marks before passing them
3972 to system-supplied API.
3973
583f48b9
PE
3974 * eval.c (Fsignal): Remove excess argument to 'fatal'.
3975
b25d760e
PE
3976 * coding.c (EMIT_ONE_BYTE, EMIT_TWO_BYTES): Use unsigned, not int.
3977 This avoids several warnings with gcc -Wstrict-overflow.
d5efd1d1
PE
3978 (DECODE_COMPOSITION_RULE): If the rule is invalid, goto invalid_code
3979 directly, rather than having caller test rule sign. This avoids
3980 some unnecessary tests.
3981 * composite.h (COMPOSITION_ENCODE_RULE_VALID): New macro.
3982 (COMPOSITION_ENCODE_RULE): Arguments now must be valid. This
3983 affects only one use, in DECODE_COMPOSITION_RULE, which is changed.
b25d760e 3984
bc7b6697 3985 * xfont.c (xfont_text_extents): Remove var that was set but not used.
625a3eb1 3986 (xfont_open): Avoid unnecessary tests.
bc7b6697 3987
27ccc379
PE
3988 * composite.c (composition_gstring_put_cache): Use unsigned integer.
3989
dcd5c89a
PE
3990 * composite.h, composite.c (composition_gstring_put_cache):
3991 Use EMACS_INT, not int, for length.
3992
b13a45c6
PE
3993 * composite.h (COMPOSITION_DECODE_REFS): New macro,
3994 breaking out part of COMPOSITION_DECODE_RULE.
3995 (COMPOSITION_DECODE_RULE): Use it.
3996 * composite.c (get_composition_id): Remove unused local vars,
3997 by using the new macro.
3998
1e792e4d
PE
3999 * textprop.c (set_text_properties_1): Change while to do-while,
4000 since the condition is always true at first.
4001
dc6c6455 4002 * intervals.c (graft_intervals_into_buffer): Mark var as used.
aa86731f
PE
4003 (interval_deletion_adjustment): Return unsigned value.
4004 All uses changed.
dc6c6455 4005
aba7731a
PE
4006 * process.c (list_processes_1, create_pty, read_process_output):
4007 (exec_sentinel): Remove vars that were set but not used.
afd4052b 4008 (create_pty): Remove unnecessary "volatile"s.
bc57d757 4009 (Fnetwork_interface_info): Avoid possibility of int overflow.
82eaa333 4010 (read_process_output): Do adaptive read buffering even if carryover.
fe07cdfa 4011 (read_process_output): Simplify nbytes computation if buffered.
aba7731a 4012
fdfc4bf3
PE
4013 * bytecode.c (exec_byte_code): Rename local to avoid shadowing.
4014
fca8fe46 4015 * syntax.c (scan_words): Remove var that was set but not used.
12cbf13f 4016 (update_syntax_table): Use unsigned instead of int.
fca8fe46 4017
06a0259a 4018 * lread.c (lisp_file_lexically_bound_p): Use ints rather than endptrs.
3c346cc3 4019 (lisp_file_lexically_bound_p, read1): Use unsigned instead of int.
e6eb4e9e 4020 (safe_to_load_p): Make the end-of-loop test the inverse of the in-loop.
06a0259a 4021
e7b9e80f
PE
4022 * print.c (print_error_message): Avoid int overflow.
4023
56201685
PE
4024 * font.c (font_list_entities): Redo for clarity,
4025 so that reader need not know FONT_DPI_INDEX + 1 == FONT_SPACING_INDEX.
4026
78834453 4027 * font.c (font_find_for_lface, Ffont_get_glyphs): Remove unused vars.
790771b1 4028 (font_score): Avoid potential overflow in diff calculation.
78834453 4029
0bc0b309 4030 * fns.c (substring_both): Remove var that is set but not used.
8cd55cb4 4031 (sxhash): Redo loop for clarity and to avoid wraparound warning.
0bc0b309 4032
e610eaca
PE
4033 * eval.c (funcall_lambda): Rename local to avoid shadowing.
4034
b895abce
PE
4035 * alloc.c (mark_object_loop_halt, mark_object): Use size_t, not int.
4036 Otherwise, GCC 4.6.0 optimizes the loop check away since the check
4037 can always succeed if overflow has undefined behavior.
4038
1f1d9321 4039 * search.c (boyer_moore, wordify): Remove vars set but not used.
6f076cc7 4040 (wordify): Omit three unnecessary tests.
1f1d9321 4041
c59478bc
PE
4042 * indent.c (MULTIBYTE_BYTES_WIDTH): Don't compute wide_column.
4043 All callers changed. This avoids the need for an unused var.
4044
79b73827
PE
4045 * casefiddle.c (casify_region): Remove var that is set but not used.
4046
a4db5dfe
PE
4047 * dired.c (file_name_completion): Remove var that is set but not used.
4048
43aae36e
PE
4049 * fileio.c (Finsert_file_contents): Make EOF condition clearer.
4050
2a47c44d 4051 * fileio.c (Finsert_file_contents): Avoid signed integer overflow.
163c5f32 4052 (Finsert_file_contents): Remove unnecessary code checking fd.
2a47c44d 4053
a37c69bf
PE
4054 * minibuf.c (read_minibuf_noninteractive): Use size_t for sizes.
4055 Check for integer overflow on size calculations.
4056
328ab8e7
PE
4057 * buffer.c (Fprevious_overlay_change): Remove var that is set
4058 but not used.
4059
e5a2a5cb
PE
4060 * keyboard.c (menu_bar_items, read_char_minibuf_menu_prompt):
4061 Remove vars that are set but not used.
8d84a6eb 4062 (timer_check_2): Don't assume timer-list and idle-timer-list are lists.
6b043475 4063 (timer_check_2): Mark vars as initialized.
e5a2a5cb 4064
a60e5f68
PE
4065 * gtkutil.c (xg_get_file_with_chooser): Mark var as initialized.
4066
f661cb61 4067 * image.c (lookup_image): Remove var that is set but not used.
35fa624f 4068 (xbm_load): Use parse_p, for gcc -Werror=unused-but-set-variable.
f661cb61 4069
f0397f5a
PE
4070 * fontset.c (Finternal_char_font, Ffontset_info): Remove vars
4071 that are set but not used.
4072
8664db06 4073 * xfns.c (make_invisible_cursor): Don't return garbage
03733ee7 4074 if XCreateBitmapFromData fails (Bug#8410).
8664db06 4075
6abdaa4a
PE
4076 * xselect.c (x_get_local_selection, x_handle_property_notify):
4077 Remove vars that are set but not used.
4078
0ce7538d 4079 * xfns.c (x_create_tip_frame): Remove var that is set but not used.
6abdaa4a 4080 (make_invisible_cursor): Initialize a possibly-uninitialized variable.
0ce7538d 4081
9ae848fc
PE
4082 * xterm.c (x_scroll_bar_to_input_event) [!USE_GTK]:
4083 Remove var that is set but not used.
0b918413
PE
4084 (scroll_bar_windows_size): Now size_t, not int.
4085 (x_send_scroll_bar_event): Use size_t, not int, for sizes.
4086 Check for overflow.
9ae848fc 4087
a5a62657
PE
4088 * xfaces.c (realize_named_face): Remove vars that are set but not used.
4089 (map_tty_color) [!defined MSDOS]: Likewise.
4090
5c5cdd39
PE
4091 * term.c (tty_write_glyphs): Use size_t; this avoids overflow warning.
4092
66ebf983
PE
4093 * coding.c: Remove vars that are set but not used.
4094 (DECODE_COMPOSITION_RULE): Remove 2nd arg, which is unused.
4095 All callers changed.
4096 (decode_coding_utf_8, decode_coding_utf_16 decode_coding_emacs_mule):
4097 (decode_coding_iso_2022, encode_coding_sjis, encode_coding_big5):
4098 (decode_coding_charset): Remove vars that are set but not used.
4099
1be4d761
PE
4100 * bytecode.c (Fbyte_code) [!defined BYTE_CODE_SAFE]: Remove var
4101 that is set but not used.
4102
47553fa8
PE
4103 * print.c (print_object): Remove var that is set but not used.
4104
1f7196bf 4105 Replace 2 copies of readlink code with 1 gnulib version (Bug#8401).
d1fdcab7
PE
4106 The gnulib version avoids calling malloc in the usual case,
4107 and on 64-bit hosts doesn't have some arbitrary 32-bit limits.
4108 * fileio.c (Ffile_symlink_p): Use emacs_readlink.
4109 * filelock.c (current_lock_owner): Likewise.
4110 * lisp.h (READLINK_BUFSIZE, emacs_readlink): New function.
4111 * sysdep.c: Include allocator.h, careadlinkat.h.
4112 (emacs_no_realloc_allocator): New static constant.
4113 (emacs_readlink): New function.
fdb61804
PE
4114 * deps.mk (sysdep.o): Depend on ../lib/allocator.h and on
4115 ../lib/careadlinkat.h.
d1fdcab7 4116
f84c17c7
SM
41172011-04-04 Stefan Monnier <monnier@iro.umontreal.ca>
4118
4119 * keyboard.c (safe_run_hook_funcall): Fix last change (don't stop at the
4120 first non-nil return value).
4121
ef3862ad
JD
41222011-04-03 Jan Djärv <jan.h.d@swipnet.se>
4123
4124 * nsterm.m (ns_update_auto_hide_menu_bar): Define MAC_OS_X_VERSION_10_6
4125 if not defined (Bug#8403).
4126
376a7006
JB
41272011-04-02 Juanma Barranquero <lekktu@gmail.com>
4128
4129 * xdisp.c (display_count_lines): Remove parameter `start',
4130 unused since 1998-01-01T02:27:27Z!rms@gnu.org. All callers changed.
4131 (get_char_face_and_encoding): Remove parameter `multibyte_p',
4132 unused since 2008-05-14T01:40:23Z!handa@m17n.org. All callers changed.
4133 (fill_stretch_glyph_string): Remove parameters `row' and `area',
4134 unused at least since Kim's GUI unification at 2003-03-16T20:45:46Z!storm@cua.dk
4135 and thereabouts. All callers changed.
4136 (get_per_char_metric): Remove parameter `f', unused since
4137 2008-05-14T01:40:23Z!handa@m17n.org. All callers changed.
4138
6ca3801d
JM
41392011-04-02 Jim Meyering <meyering@redhat.com>
4140
4141 do not dereference NULL upon failed strdup
4142 * nsfont.m (ns_descriptor_to_entity): Use xstrdup, not strdup.
4143 (ns_get_family): Likewise.
4144
d8e2b5ba
JB
41452011-04-02 Juanma Barranquero <lekktu@gmail.com>
4146
4147 * eval.c (unwind_to_catch) [DEBUG_GCPRO]: Remove redundant assignment.
4148
8c74fcbd
JD
41492011-04-02 Jan Djärv <jan.h.d@swipnet.se>
4150
4151 * nsterm.m (ns_update_auto_hide_menu_bar): Only for OSX 10.6 or
4152 later (Bug#8403).
4153
7200d79c
SM
41542011-04-01 Stefan Monnier <monnier@iro.umontreal.ca>
4155
03408648 4156 Add lexical binding.
7200d79c 4157
03408648
SM
4158 * window.c (Ftemp_output_buffer_show): New fun.
4159 (Fsave_window_excursion):
4160 * print.c (Fwith_output_to_temp_buffer): Move to subr.el.
4161
4162 * lread.c (lisp_file_lexically_bound_p): New function.
4163 (Fload): Bind Qlexical_binding.
4164 (readevalloop): Remove `evalfun' arg.
4165 Bind Qinternal_interpreter_environment.
4166 (Feval_buffer): Bind Qlexical_binding.
4167 (defvar_int, defvar_bool, defvar_lisp_nopro, defvar_kboard):
4168 Mark as dynamic.
4169 (syms_of_lread): Declare `lexical-binding'.
4170
4171 * lisp.h (struct Lisp_Symbol): New field `declared_special'.
4172
4173 * keyboard.c (eval_dyn): New fun.
4174 (menu_item_eval_property): Use it.
ca105506
SM
4175
4176 * image.c (parse_image_spec): Use Ffunctionp.
ca105506 4177
03408648
SM
4178 * fns.c (concat, mapcar1): Accept byte-code-functions.
4179
4180 * eval.c (Fsetq): Handle lexical vars.
4181 (Fdefun, Fdefmacro, Ffunction): Make closures when needed.
4182 (Fdefconst, Fdefvaralias, Fdefvar): Mark as dynamic.
4183 (FletX, Flet): Obey lexical binding.
4184 (Fcommandp): Handle closures.
4185 (Feval): New `lexical' arg.
4186 (eval_sub): New function extracted from Feval. Use it almost
4187 everywhere where Feval was used. Look up vars in lexical env.
4188 Handle closures.
4189 (Ffunctionp): Move from subr.el.
4190 (Ffuncall): Handle closures.
4191 (apply_lambda): Remove `eval_flags'.
4192 (funcall_lambda): Handle closures and new byte-code-functions.
4193 (Fspecial_variable_p): New function.
4194 (syms_of_eval): Initialize the Vinternal_interpreter_environment var,
4195 but without exporting it to Lisp.
23aba0ea 4196
23aba0ea 4197 * doc.c (Fdocumentation, store_function_docstring):
03408648 4198 * data.c (Finteractive_form): Handle closures.
23aba0ea 4199
03408648
SM
4200 * callint.c (Fcall_interactively): Preserve lexical-binding mode for
4201 interactive spec.
ba83908c 4202
04f2d78b
CB
4203 * bytecode.c (Bstack_ref, Bstack_set, Bstack_set2, BdiscardN):
4204 New byte-codes.
03408648
SM
4205 (exec_byte_code): New function extracted from Fbyte_code to handle new
4206 calling convention for byte-code-functions. Add new byte-codes.
ba83908c 4207
03408648 4208 * buffer.c (defvar_per_buffer): Set new `declared_special' field.
e2abe5a1 4209
03408648 4210 * alloc.c (Fmake_symbol): Init new `declared_special' field.
e2abe5a1 4211
e2abce01
JB
42122011-03-31 Juanma Barranquero <lekktu@gmail.com>
4213
4214 * xdisp.c (redisplay_internal): Fix prototype.
4215
63696a73 42162011-03-31 Eli Zaretskii <eliz@gnu.org>
09725d26 4217
63696a73 4218 * xdisp.c (SCROLL_LIMIT): New macro.
04f2d78b
CB
4219 (try_scrolling): Use it when setting scroll_limit.
4220 Limit scrolling to 100 screen lines.
63696a73
EZ
4221 (redisplay_window): Even when falling back on "recentering",
4222 position point in the window according to scroll-conservatively,
4223 scroll-margin, and scroll-*-aggressively variables. (Bug#6671)
4224
4225 (try_scrolling): When point is above the window, allow searching
4226 as far as scroll_max, or one screenful, to compute vertical
4227 distance from PT to the scroll margin position. This prevents
4228 try_scrolling from unnecessarily failing when
4229 scroll-conservatively is set to a value slightly larger than the
4230 window height. Clean up the case of PT below the margin at bottom
4231 of window: scroll_max can no longer be INT_MAX. When aggressive
4232 scrolling is in use, don't let point enter the opposite scroll
4233 margin as result of the scroll.
4234 (syms_of_xdisp) <scroll-conservatively>: Document the
09725d26
EZ
4235 threshold of 100 lines for never-recentering scrolling.
4236
e4cc2dfc
JB
42372011-03-31 Juanma Barranquero <lekktu@gmail.com>
4238
4239 * dispextern.h (move_it_by_lines):
4240 * xdisp.c (move_it_by_lines): Remove parameter `need_y_p', unused
4241 since 2000-12-29T14:24:09Z!gerd@gnu.org. All callers changed.
4242 (message_log_check_duplicate): Remove parameters `prev_bol' and
4243 `this_bol', unused since 1998-01-01T02:27:27Z!rms@gnu.org. All callers changed.
4244 (redisplay_internal): Remove parameter `preserve_echo_area',
4245 unused since 1999-07-21T21:43:52Z!gerd@gnu.org. All callers changed.
4246
4247 * indent.c (Fvertical_motion):
4248 * window.c (window_scroll_pixel_based, Frecenter):
4249 Don't pass `need_y_p' to `move_it_by_lines'.
4250
1c470562
SM
42512011-03-30 Stefan Monnier <monnier@iro.umontreal.ca>
4252
44f230aa
SM
4253 * eval.c (struct backtrace): Don't cheat with negative numbers, but do
4254 steal a few bits to be more compact.
4255 (interactive_p, Fbacktrace, Fbacktrace_frame, mark_backtrace):
4256 Remove unneeded casts.
4257
1c470562
SM
4258 * bytecode.c (Fbyte_code): CAR and CDR can GC.
4259
888adce9
ZK
42602011-03-30 Zachary Kanfer <zkanfer@gmail.com> (tiny change)
4261
4262 * keyboard.c (Fexecute_extended_command): Do log the "suggest key
4263 binding" message (bug#7967).
4264
f838ed7b
PE
42652011-03-30 Paul Eggert <eggert@cs.ucla.edu>
4266
77861b95
PE
4267 Fix more problems found by GCC 4.6.0's static checks.
4268
de6dbc14
PE
4269 * unexelf.c (unexec) [! (defined _SYSTYPE_SYSV || defined __sgi)]:
4270 Remove unused local var.
4271
f838ed7b
PE
4272 * editfns.c (Fmessage_box): Remove unused local var.
4273
792c7b2b
PE
4274 * xdisp.c (try_window_reusing_current_matrix, x_produce_glyphs):
4275 (note_mode_line_or_margin_highlight, note_mouse_highlight):
4276 Omit unused local vars.
c499e557 4277 * window.c (shrink_windows): Omit unused local var.
b01a1c29 4278 * menu.c (digest_single_submenu): Omit unused local var.
0bc32927
PE
4279 * dispnew.c (update_window) [PERIODIC_PREEMPTION_CHECKING]:
4280 Omit unused local var.
4281
ba0165e1
PE
4282 * keyboard.c (parse_modifiers_uncached, parse_modifiers):
4283 Don't assume string length fits in int.
32ad8845 4284 (keyremap_step, read_key_sequence): Use size_t for sizes.
48011560 4285 (read_key_sequence): Don't check last_real_key_start redundantly.
ba0165e1 4286
3c59b4c9
PE
4287 * callproc.c (Fcall_process, Fcall_process_region): Use SAFE_ALLOCA
4288 instead of alloca (Bug#8344).
4289
a3eed478 4290 * eval.c (Fbacktrace): Don't assume nargs fits in int.
5d5d959d 4291 (Fbacktrace_frame): Don't assume nframes fits in int.
a3eed478 4292
eb4d412d
PE
4293 * syntax.c (scan_sexps_forward): Avoid pointer wraparound.
4294
1658b401
PE
4295 * xterm.c (x_make_frame_visible, same_x_server): Redo to avoid overflow
4296 concerns.
4297
4298 * term.c (produce_glyphless_glyph): Remove unnecessary test.
4299
4300 * cm.c (calccost): Turn while-do into do-while, for clarity.
44f730c8 4301
9a2c6e05
PE
4302 * keyboard.c (syms_of_keyboard): Use the same style as later
4303 in this function when indexing through an array. This also
4304 works around GCC bug 48267.
4305
03d0a109
PE
4306 * image.c (tiff_load): Fix off-by-one image count (Bug#8336).
4307
44f730c8
PE
4308 * xselect.c (x_check_property_data): Return correct size (Bug#8335).
4309
fe75f926
PE
4310 * chartab.c (sub_char_table_ref_and_range): Redo for slight
4311 efficiency gain, and to bypass a gcc -Wstrict-overflow warning.
4312
ffa8c828
PE
4313 * keyboard.c, keyboard.h (num_input_events): Now size_t.
4314 This avoids undefined behavior on integer overflow, and is a bit
4315 more convenient anyway since it is compared to a size_t variable.
4316
c5101a77
PE
4317 Variadic C functions now count arguments with size_t, not int.
4318 This avoids an unnecessary limitation on 64-bit machines, which
4319 caused (substring ...) to crash on large vectors (Bug#8344).
4320 * lisp.h (struct Lisp_Subr.function.aMANY): Now takes size_t, not int.
4321 (DEFUN_ARGS_MANY, internal_condition_case_n, safe_call): Likewise.
77861b95 4322 All variadic functions and their callers changed accordingly.
c5101a77
PE
4323 (struct gcpro.nvars): Now size_t, not int. All uses changed.
4324 * data.c (arith_driver, float_arith_driver): Likewise.
4325 * editfns.c (general_insert_function): Likewise.
4326 * eval.c (struct backtrace.nargs, interactive_p)
4327 (internal_condition_case_n, run_hook_with_args, apply_lambda)
4328 (funcall_lambda, mark_backtrace): Likewise.
4329 * fns.c (concat): Likewise.
4330 * frame.c (x_set_frame_parameters): Likewise.
4331 * fns.c (get_key_arg): Now accepts and returns size_t, and returns
4332 0 if not found, not -1. All callers changed.
4333
dd3f25f7
PE
4334 * alloc.c (garbage_collect): Don't assume stack size fits in int.
4335 (stack_copy_size): Now size_t, not int.
4336 (stack_copy, stack_copy_size): Define only if MAX_SAVE_STACK > 0.
4337
461c2ab9
JB
43382011-03-28 Juanma Barranquero <lekktu@gmail.com>
4339
4340 * coding.c (encode_designation_at_bol): Remove parameter `charbuf_end',
4341 unused since 2002-03-01T01:17:24Z!handa@m17n.org and 2008-02-01T16:01:31Z!miles@gnu.org.
4342 All callers changed.
4343
4344 * lisp.h (multibyte_char_to_unibyte):
4345 * character.c (multibyte_char_to_unibyte): Remove parameter `rev_tbl',
4346 unused since 2002-03-01T01:16:34Z!handa@m17n.org and 2008-02-01T16:01:31Z!miles@gnu.org.
4347 * character.h (CHAR_TO_BYTE8):
4348 * cmds.c (internal_self_insert):
4349 * editfns.c (general_insert_function):
4350 * keymap.c (push_key_description):
4351 * search.c (Freplace_match):
4352 * xdisp.c (message_dolog, set_message_1): All callers changed.
4353
f6d62986
SM
43542011-03-28 Stefan Monnier <monnier@iro.umontreal.ca>
4355
4356 * keyboard.c (safe_run_hook_funcall): New function.
4357 (safe_run_hooks_1, safe_run_hooks_error, safe_run_hooks): On error,
4358 don't set the hook to nil, but remove the offending function instead.
4359 (Qcommand_hook_internal): Remove, unused.
4360 (syms_of_keyboard): Don't initialize Qcommand_hook_internal nor define
4361 Vcommand_hook_internal.
4362
4363 * eval.c (enum run_hooks_condition): Remove.
4364 (funcall_nil, funcall_not): New functions.
4365 (run_hook_with_args): Call each function through a `funcall' argument.
4366 Remove `cond' argument, now redundant.
4367 (Frun_hooks, Frun_hook_with_args, Frun_hook_with_args_until_success)
4368 (Frun_hook_with_args_until_failure): Adjust accordingly.
4369 (run_hook_wrapped_funcall, Frun_hook_wrapped): New functions.
4370
1db5b1ad
JB
43712011-03-28 Juanma Barranquero <lekktu@gmail.com>
4372
4373 * dispextern.h (string_buffer_position): Remove declaration.
4374
4375 * print.c (strout): Remove parameter `multibyte', unused since
4376 1999-08-21T19:30:21Z!gerd@gnu.org. All callers changed.
4377
4378 * search.c (boyer_moore): Remove parameters `len', `pos' and `lim',
4379 never used since function introduction in 1998-02-08T21:33:56Z!rms@gnu.org.
4380 All callers changed.
4381
4382 * w32.c (_wsa_errlist): Use braces for struct initializers.
4383
4384 * xdisp.c (string_buffer_position_lim): Remove parameter `w',
4385 never used since function introduction in 2001-03-09T18:41:50Z!gerd@gnu.org.
4386 All callers changed.
4387 (string_buffer_position): Likewise. Also, make static (it's never
4388 used outside xdisp.c).
4389 (cursor_row_p): Remove parameter `w', unused since
4390 2000-10-17T16:08:57Z!gerd@gnu.org. All callers changed.
4391 (decode_mode_spec): Remove parameter `precision', introduced during
4392 Gerd Moellmann's rewrite at 1999-07-21T21:43:52Z!gerd@gnu.org, but never used.
4393 All callers changed.
4394
5ffb62aa
JD
43952011-03-27 Jan Djärv <jan.h.d@swipnet.se>
4396
4397 * nsterm.m (syms_of_nsterm): Use doc: for ns-auto-hide-menu-bar.
4398
461c2ab9 43992011-03-27 Anders Lindgren <andlind@gmail.com>
f0a1382a
JD
4400
4401 * nsterm.m (ns_menu_bar_is_hidden): New variable.
4402 (ns_constrain_all_frames, ns_menu_bar_should_be_hidden)
4403 (ns_update_auto_hide_menu_bar): New functions.
4404 (ns_update_begin): Call ns_update_auto_hide_menu_bar.
4405 (applicationDidBecomeActive): Call ns_update_auto_hide_menu_bar and
4406 ns_constrain_all_frames.
4407 (constrainFrameRect): Return at once if ns_menu_bar_should_be_hidden.
4408 (syms_of_nsterm): DEFVAR ns-auto-hide-menu-bar, init to Qnil.
4409
5c380ffb
JD
44102011-03-27 Jan Djärv <jan.h.d@swipnet.se>
4411
4412 * nsmenu.m (runDialogAt): Remove argument to timer_check.
4413
9af30bdf
GM
44142011-03-27 Glenn Morris <rgm@gnu.org>
4415
4416 * syssignal.h: Replace RETSIGTYPE with void.
4417 * atimer.c, data.c, dispnew.c, emacs.c, floatfns.c, keyboard.c:
4418 * keyboard.h, lisp.h, process.c, sysdep.c, xterm.c:
4419 Replace SIGTYPE with void everywhere.
4420 * s/usg5-4-common.h (SIGTYPE): Remove definition.
4421 * s/template.h (SIGTYPE): Remove commented out definition.
4422
e2abce01
JB
44232011-03-26 Eli Zaretskii <eliz@gnu.org>
4424
4425 * xdisp.c (redisplay_window): Don't check buffer's clip_changed
4426 flag as a prerequisite for invoking try_scrolling. (Bug#6671)
4427
f868cd8a
JB
44282011-03-26 Juanma Barranquero <lekktu@gmail.com>
4429
59eb0929
JB
4430 * w32.c (read_unc_volume): Use parameter `henum', instead of
4431 global variable `wget_enum_handle'.
4432
4433 * keymap.c (describe_vector): Remove parameters `indices' and
4434 `char_table_depth', unused since 2002-03-01T01:43:26Z!handa@m17n.org.
4435 (describe_map, Fdescribe_vector): Adjust calls to `describe_vector'.
4436
f868cd8a
JB
4437 * keyboard.h (timer_check, show_help_echo): Remove unused parameters.
4438
4439 * keyboard.c (timer_check): Remove parameter `do_it_now',
4440 unused since 1996-04-12T06:01:29Z!rms@gnu.org.
4441 (show_help_echo): Remove parameter `ok_to_overwrite_keystroke_echo',
4442 unused since 2008-04-19T19:30:53Z!monnier@iro.umontreal.ca.
4443
4444 * keyboard.c (read_char):
4445 * w32menu.c (w32_menu_display_help):
4446 * xmenu.c (show_help_event, menu_help_callback):
4447 Adjust calls to `show_help_echo'.
4448
4449 * gtkutil.c (xg_maybe_add_timer):
4450 * keyboard.c (readable_events):
4451 * process.c (wait_reading_process_output):
4452 * xmenu.c (x_menu_wait_for_event): Adjust calls to `timer_check'.
4453
4454 * insdel.c (adjust_markers_gap_motion):
4455 Remove; no-op since 1998-01-02T21:29:48Z!rms@gnu.org.
4456 (gap_left, gap_right): Don't call it.
4457
2ecf6fdb
CY
44582011-03-25 Chong Yidong <cyd@stupidchicken.com>
4459
4460 * xdisp.c (handle_fontified_prop): Discard changes to clip_changed
4461 incurred during fontification.
4462
6b1f9ba4
JB
44632011-03-25 Juanma Barranquero <lekktu@gmail.com>
4464
4465 * buffer.c (defvar_per_buffer): Remove unused parameter `doc'.
4466 (DEFVAR_PER_BUFFER): Don't pass it.
4467
4468 * dispnew.c (row_equal_p, add_row_entry): Remove unused parameter `w'.
4469 (scrolling_window): Don't pass it.
4470
0f4a96b5
JB
44712011-03-25 Juanma Barranquero <lekktu@gmail.com>
4472
4473 * dispextern.h (glyph_matric): Use #if GLYPH_DEBUG, not #ifdef.
4474
4475 * fileio.c (check_executable) [DOS_NT]: Remove unused variables `len'
4476 and `suffix'.
4477 (Fset_file_selinux_context) [HAVE_LIBSELINUX]: Move here declaration
4478 of variables specific to SELinux and computation of `encoded_absname'.
4479
4480 * image.c (XPutPixel): Remove unused variable `height'.
4481
4482 * keyboard.c (make_lispy_event): Remove unused variable `hpos'.
4483
4484 * unexw32.c (get_section_info): Remove unused variable `section'.
4485
4486 * w32.c (stat): Remove unused variables `drive_root' and `devtype'.
4487 (system_process_attributes): Remove unused variable `sess'.
4488 (sys_read): Remove unused variable `err'.
4489
4490 * w32fns.c (top): Wrap variables with #if GLYPH_DEBUG, not #ifdef.
4491 (w32_wnd_proc): Remove unused variable `isdead'.
4492 (unwind_create_frame): Use #if GLYPH_DEBUG, not #ifdef.
4493 (Fx_server_max_request_size): Remove unused variable `dpyinfo'.
4494 (x_create_tip_frame): Remove unused variable `tem'.
4495
4496 * w32inevt.c (w32_console_read_socket):
4497 Remove unused variable `no_events'.
4498
4499 * w32term.c (x_draw_composite_glyph_string_foreground):
4500 Remove unused variable `width'.
4501
1149507c
JB
45022011-03-24 Juanma Barranquero <lekktu@gmail.com>
4503
4504 * w32term.c (x_set_glyph_string_clipping):
4505 Don't pass uninitialized region to CombineRgn.
4506
9c88f339
JB
45072011-03-23 Juanma Barranquero <lekktu@gmail.com>
4508
4509 * w32fns.c (x_set_menu_bar_lines): Remove unused variable `olines'.
4510 (w32_wnd_proc): Pass NULL to Windows API, not uninitialized buffer.
4511 (Fx_close_connection): Remove unused variable `i'.
4512
4513 * w32font.c (w32font_draw): Return number of glyphs.
4514 (w32font_open_internal): Remove unused variable `i'.
4515 (w32font_driver): Add missing initializer.
4516
4517 * w32menu.c (utf8to16): Remove unused variable `utf16'.
4518 (fill_in_menu): Remove unused variable `items_added'.
4519
4520 * w32term.c (last_mouse_press_frame): Remove static global variable.
4521 (w32_clip_to_row): Remove unused variable `f'.
4522 (x_delete_terminal): Remove unused variable `i'.
4523
4524 * w32uniscribe.c (uniscribe_shape): Remove unused variable `nclusters'.
4525 (NOTHING): Remove unused static global variable.
4526 (uniscribe_check_otf): Remove unused variable `table'.
4527 (uniscribe_font_driver): Add missing initializers.
4528
dee091a3
JD
45292011-03-23 Julien Danjou <julien@danjou.info>
4530
4531 * term.c (Fsuspend_tty, Fresume_tty):
4532 * minibuf.c (read_minibuf, run_exit_minibuf_hook):
4533 * window.c (temp_output_buffer_show):
4534 * insdel.c (signal_before_change):
4535 * frame.c (Fhandle_switch_frame):
4536 * fileio.c (Fdo_auto_save):
4537 * emacs.c (Fkill_emacs):
4538 * editfns.c (save_excursion_restore):
4539 * cmds.c (internal_self_insert):
4540 * callint.c (Fcall_interactively):
4541 * buffer.c (Fkill_all_local_variables):
4542 * keyboard.c (Fcommand_execute, Fsuspend_emacs, safe_run_hooks_1):
4543 Use Frun_hooks.
0f4a96b5 4544 (command_loop_1): Use Frun_hooks. Call safe_run_hooks
dee091a3
JD
4545 unconditionnaly since it does the check itself.
4546
2c520ab5 45472011-03-23 Paul Eggert <eggert@cs.ucla.edu>
f0641eff 4548
c9c49752
PE
4549 Fix more problems found by GCC 4.5.2's static checks.
4550
8abc3f12
PE
4551 * coding.c (encode_coding_raw_text): Avoid unnecessary test
4552 the first time through the loop, since we know p0 < p1 then.
4553 This also avoids a gcc -Wstrict-overflow warning.
4554
a2d26660
PE
4555 * lisp.h (SAFE_ALLOCA, SAFE_ALLOCA_LISP): Avoid 'int' overflow
4556 leading to a memory leak, possible in functions like
4557 load_charset_map_from_file that can allocate an unbounded number
b12ef411 4558 of objects (Bug#8318).
a2d26660 4559
916c72e9
PE
4560 * xmenu.c (set_frame_menubar): Use EMACS_UINT, not int, for indexes
4561 that could (at least in theory) be that large.
4562
19ab8a18
PE
4563 * xdisp.c (message_log_check_duplicate): Return unsigned long, not int.
4564 This is less likely to overflow, and avoids undefined behavior if
4565 overflow does occur. All callers changed. Use strtoul to scan
4566 for the unsigned long integer.
b7cbbd6f
PE
4567 (pint2hrstr): Simplify and tune code slightly.
4568 This also avoids a (bogus) GCC warning with gcc -Wstrict-overflow.
19ab8a18 4569
f0641eff
PE
4570 * scroll.c (do_scrolling): Work around GCC bug 48228.
4571 See <http://gcc.gnu.org/bugzilla/show_bug.cgi?id=48228>.
4572
7f650bb9
PE
4573 * frame.c (Fmodify_frame_parameters): Simplify loop counter.
4574 This also avoids a warning with gcc -Wstrict-overflow.
39f5e519
PE
4575 (validate_x_resource_name): Simplify count usage.
4576 This also avoids a warning with gcc -Wstrict-overflow.
7f650bb9 4577
37dd57d1
PE
4578 * fileio.c (Fcopy_file): Report error if fchown or fchmod
4579 fail (Bug#8306).
81e56e61 4580
699979fc 4581 * emacs.c (Fdaemon_initialized): Do not ignore I/O errors (Bug#8303).
dc1ca6a8 4582
401bf9b4
PE
4583 * process.c (Fmake_network_process): Use socklen_t, not int,
4584 where POSIX says socklen_t is required in portable programs.
4585 This fixes a porting bug on hosts like 64-bit HP-UX, where
591b2973 4586 socklen_t is wider than int (Bug#8277).
401bf9b4
PE
4587 (Fmake_network_process, server_accept_connection):
4588 (wait_reading_process_output, read_process_output):
4589 Likewise.
4590
b93aacde
PE
4591 * process.c: Rename or move locals to avoid shadowing.
4592 (list_processes_1, Fmake_network_process):
4593 (read_process_output_error_handler, exec_sentinel_error_handler):
4594 Rename or move locals.
4dc343ee 4595 (Fmake_network_process): Define label "retry_connect" only if needed.
0da49335 4596 (Fnetwork_interface_info): Fix pointer signedness.
f990b4e5 4597 (process_send_signal): Add cast to avoid pointer signedness problem.
7b808126 4598 (FIRST_PROC_DESC, IF_NON_BLOCKING_CONNECT): Remove unused macros.
c939f91b 4599 (create_process): Use 'volatile' to avoid vfork clobbering (Bug#8298).
b93aacde 4600
af8a867c 4601 Make tparam.h and terminfo.c consistent.
44f230aa
SM
4602 * cm.c (tputs, tgoto, BC, UP): Remove extern decls.
4603 Include tparam.h instead, since it declares them.
af8a867c
PE
4604 * cm.h (PC): Remove extern decl; tparam.h now does this.
4605 * deps.mk (cm.o, terminfo.o): Depend on tparam.h.
4606 * terminfo.c: Include tparam.h, to check interfaces.
4607 (tparm): Make 1st arg a const pointer in decl. Put it at top level.
4608 (tparam): Adjust signature to match interface in tparam.h;
4609 this removes some undefined behavior. Check that outstring and len
4610 are zero, which they always are with Emacs.
4611 * tparam.h (PC, BC, UP): New extern decls.
4612
0248044d 4613 * xftfont.c (xftfont_shape): Now static, and defined only if needed.
001a7ab4 4614 (xftfont_open): Rename locals to avoid shadowing.
0248044d 4615
8ff096c1 4616 * ftfont.c (ftfont_resolve_generic_family): Fix pointer signedness.
a00924bb
PE
4617 (ftfont_otf_capability, ftfont_shape): Omit decls if not needed.
4618 (OTF_TAG_SYM): Omit macro if not needed.
e932860f 4619 (ftfont_list): Remove unused local.
49eaafba
PE
4620 (get_adstyle_property, ftfont_pattern_entity):
4621 (ftfont_lookup_cache, ftfont_open, ftfont_anchor_point):
4622 Rename locals to avoid shadowing.
8ff096c1 4623
e2be39f6
PE
4624 * xfont.c (xfont_list_family): Mark var as initialized.
4625
c9735e30
PE
4626 * xml.c (make_dom): Now static.
4627
8f5201ae
PE
4628 * composite.c (composition_compute_stop_pos): Rename local to
4629 avoid shadowing.
b246f932
PE
4630 (composition_reseat_it): Remove unused locals.
4631 (find_automatic_composition, composition_adjust_point): Likewise.
80e079b2 4632 (composition_update_it): Mark var as initialized.
11b61122
PE
4633 (find_automatic_composition): Mark vars as initialized,
4634 with a FIXME (Bug#8290).
8f5201ae 4635
760fbc2c
PE
4636 character.h: Rename locals to avoid shadowing.
4637 * character.h (PREV_CHAR_BOUNDARY, FETCH_STRING_CHAR_ADVANCE):
4638 (FETCH_STRING_CHAR_AS_MULTIBYTE_ADVANCE, FETCH_CHAR_ADVANCE):
4639 (FETCH_CHAR_ADVANCE_NO_CHECK, INC_POS, DEC_POS, BUF_INC_POS):
4640 (BUF_DEC_POS): Be more systematic about renaming local temporaries
4641 to avoid shadowing.
4642
ff08eb85
PE
4643 * textprop.c (property_change_between_p): Remove; unused.
4644
fc7bf025
PE
4645 * intervals.c (interval_start_pos): Now static.
4646
235d7abc
PE
4647 * intervals.h (CHECK_TOTAL_LENGTH): Avoid empty "else".
4648
44f230aa
SM
4649 * atimer.c (start_atimer, append_atimer_lists, set_alarm):
4650 Rename locals to avoid shadowing.
3e7d6594 4651
50060332
PE
4652 * sound.c (wav_play, au_play, Fplay_sound_internal):
4653 Fix pointer signedness.
d01f234b 4654 (alsa_choose_format): Remove unused local var.
c83b8872
PE
4655 (wav_play): Initialize a variable to 0, to prevent undefined
4656 behavior (Bug#8278).
50060332 4657
c4fc4e30
PE
4658 * region-cache.c (insert_cache_boundary): Redo var to avoid shadowing.
4659
918436ed
PE
4660 * region-cache.h (pp_cache): New decl, for gcc -Wmissing-prototypes.
4661
c939f91b
PE
4662 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork
4663 clobbering (Bug#8298).
b9c7f648
PE
4664 * sysdep.c (sys_subshell): Likewise.
4665 Previously, the sys_subshell 'volatile' was incorrectly IF_LINTted out.
7e9123a2 4666
6bd8c144
PE
4667 * lisp.h (child_setup): Now NO_RETURN unless DOS_NT.
4668 This should get cleaned up, so that child_setup has the
4669 same signature on all platforms.
4670
7710357c 4671 * callproc.c (call_process_cleanup): Now static.
cb1d0ef7 4672 (relocate_fd): Rename locals to avoid shadowing.
7710357c 4673
c59da222
CY
46742011-03-22 Chong Yidong <cyd@stupidchicken.com>
4675
4676 * xterm.c (x_clear_frame): Remove XClearWindow call. This appears
4677 not to be necessary, and produces flickering.
4678
66b87493
GM
46792011-03-20 Glenn Morris <rgm@gnu.org>
4680
4681 * config.in: Remove file.
4682
45b6f6d5
JB
46832011-03-20 Juanma Barranquero <lekktu@gmail.com>
4684
4685 * minibuf.c (Vcompleting_read_function): Don't declare, global variables
4686 are now in src/globals.h.
4687 (syms_of_minibuf): Remove spurious & from previous change.
4688
3ec03f7e
LL
46892011-03-20 Leo <sdl.web@gmail.com>
4690
4691 * minibuf.c (completing-read-function): New variable.
4692 (completing-read-default): Rename from completing-read.
4693 (completing-read): Call completing-read-function.
4694
b14e3e21
CY
46952011-03-19 Juanma Barranquero <lekktu@gmail.com>
4696
4697 * xfaces.c (Fx_load_color_file):
4698 Read color file from absolute filename (bug#8250).
4699
f2b726e6
JB
47002011-03-19 Juanma Barranquero <lekktu@gmail.com>
4701
4702 * makefile.w32-in: Update dependencies.
4703
09f6ff02
EZ
47042011-03-17 Eli Zaretskii <eliz@gnu.org>
4705
4706 * makefile.w32-in ($(BLD)/unexw32.$(O)): Depend on $(SRC)/unexec.h.
4707
29a6015a
PE
47082011-03-17 Paul Eggert <eggert@cs.ucla.edu>
4709
a3a6c54e
PE
4710 Fix more problems found by GCC 4.5.2's static checks.
4711
b766f867
PE
4712 * process.c (make_serial_process_unwind, send_process_trap):
4713 (sigchld_handler): Now static.
4714
be02381c
PE
4715 * process.c (allocate_pty): Let PTY_ITERATION declare iteration vars.
4716 That way, the code declares only the vars that it needs.
4717 * s/aix4-2.h (PTY_ITERATION): Declare iteration vars.
4718 * s/cygwin.h (PTY_ITERATION): Likewise.
4719 * s/darwin.h (PTY_ITERATION): Likewise.
4720 * s/gnu-linux.h (PTY_ITERATION): Likewise.
4721
57048744
PE
4722 * s/irix6-5.h (PTY_OPEN): Declare stb, to loosen coupling.
4723 * process.c (allocate_pty): Don't declare stb unless it's needed.
4724
7914961c 4725 * bytecode.c (MAYBE_GC): Rewrite so as not to use empty "else".
615f2d59
PE
4726 (CONSTANTLIM): Remove; unused.
4727 (METER_CODE, Bscan_buffer, Bread_char, Bset_mark):
4728 Define only if needed.
7914961c 4729
b3967b18
PE
4730 * unexelf.c (unexec): Name an expression,
4731 to avoid gcc -Wbad-function-cast warning.
9ae71512
PE
4732 Use a different way to cause a compilation error if anyone uses
4733 n rather than nn, a way that does not involve shadowing.
73366a00 4734 (ELF_BSS_SECTION_NAME, OLD_PROGRAM_H): Remove; unused.
b3967b18 4735
29a6015a
PE
4736 * deps.mk (unexalpha.o): Remove; unused.
4737
43cfc33e 4738 New file unexec.h, the (simple) interface for unexec (Bug#8267).
7feda0d2 4739 * unexec.h: New file.
ce701a33
PE
4740 * deps.mk (emacs.o, unexaix.o, unexcw.o, unexcoff.o, unexelf.o):
4741 (unexhp9k800.o, unexmacosx.o, unexsol.o, unexw32.o):
4742 Depend on unexec.h.
4743 * emacs.c [!defined CANNOT_DUMP]: Include unexec.h.
4744 * unexaix.c, unexcoff.c, unexcw.c, unexelf.c, unexhp9k800.c:
4745 * unexmacosx.c, unexsol.c, unexw32.c: Include unexec.h.
381259ef 4746 Change as necessary to match prototype in unexec.h.
ce701a33 4747
01f44d5a
PE
4748 * syntax.c (Fforward_comment, scan_lists): Rename locals to avoid
4749 shadowing.
4f63c6bb 4750 (back_comment, skip_chars): Mark vars as initialized.
01f44d5a 4751
a6670b0b
PE
4752 * character.h (FETCH_STRING_CHAR_ADVANCE_NO_CHECK, BUF_INC_POS):
4753 Rename locals to avoid shadowing.
4754
cef2010d 4755 * lread.c (read1): Rewrite so as not to use empty "else".
0902fe45 4756 (Fload, readevalloop, read1): Rename locals to avoid shadowing.
cef2010d 4757
d4d7173a
PE
4758 * print.c (Fredirect_debugging_output): Fix pointer signedess.
4759
f08b802a
PE
4760 * lisp.h (debug_output_compilation_hack): Add decl here, to avoid
4761 warning when compiling print.c.
4762
3ddb0639
PE
4763 * font.c (font_unparse_fcname): Abort in an "impossible" situation
4764 instead of using an uninitialized var.
5ad03b97 4765 (font_sort_entities): Mark var as initialized.
3ddb0639 4766
170a2692
PE
4767 * character.h (FETCH_CHAR_ADVANCE): Rename locals to avoid shadowing.
4768
e663c700
PE
4769 * font.c (font_unparse_xlfd): Don't mix pointers to variables with
4770 pointers to constants.
89bc529a 4771 (font_parse_fcname): Remove unused vars.
7b81e2d0 4772 (font_delete_unmatched): Now static.
ea838e10 4773 (font_get_spec): Remove; unused.
13a547c6
PE
4774 (font_style_to_value, font_prop_validate_style, font_unparse_fcname):
4775 (font_update_drivers, Ffont_get_glyphs, font_add_log):
4776 Rename or move locals to avoid shadowing.
e663c700 4777
2a80c887 4778 * fns.c (require_nesting_list, require_unwind): Now static.
612f56df 4779 (Ffillarray): Rename locals to avoid shadowing.
2a80c887 4780
1384fa33 4781 * floatfns.c (domain_error2): Define only if needed.
a885e2ed 4782 (Ffrexp, Fldexp): Rename locals to avoid shadowing.
1384fa33 4783
8b2c52e9
PE
4784 * alloc.c (mark_backtrace): Move decl from here ...
4785 * lisp.h: ... to here, so that it can be checked.
4786
475545b5 4787 * eval.c (call_debugger, do_debug_on_call, grow_specpdl): Now static.
d28a2170 4788 (Fdefvar): Rewrite so as not to use empty "else".
cfcbfb1a
PE
4789 (lisp_indirect_variable): Name an expression,
4790 to avoid gcc -Wbad-function-cast warning.
1faed8ae 4791 (Fdefvar): Rename locals to avoid shadowing.
475545b5 4792
b1349114 4793 * callint.c (quotify_arg, quotify_args): Now static.
a3e8cbda 4794 (Fcall_interactively): Rename locals to avoid shadowing.
b0e80955 4795 Use const pointer when appropriate.
b1349114 4796
a2928364
PE
4797 * lisp.h (get_system_name, get_operating_system_release):
4798 Move decls here, to check interfaces.
4799 * process.c (get_operating_system_release): Move decl to lisp.h.
4800 * xrdb.c (get_system_name): Likewise.
63c5d10b
PE
4801 * editfns.c (init_editfns, Fuser_login_name, Fuser_uid):
4802 (Fuser_real_uid, Fuser_full_name): Remove unnecessary casts,
4803 some of which prompt warnings from gcc -Wbad-function-cast.
545b49b4
PE
4804 (Fformat_time_string, Fencode_time, Finsert_char):
4805 (Ftranslate_region_internal, Fformat):
4806 Rename or remove local vars to avoid shadowing.
9710023e 4807 (Ftranslate_region_internal): Mark var as initialized.
63c5d10b 4808
a415e694
PE
4809 * doc.c (Fdocumentation, Fsnarf_documentation): Move locals to
4810 avoid shadowing.
4811
8ef4622d
PE
4812 * lisp.h (eassert): Check that the argument compiles, even if
4813 ENABLE_CHECKING is not defined.
4814
946f9a5b
PE
4815 * data.c (Findirect_variable): Name an expression, to avoid
4816 gcc -Wbad-function-cast warning.
112396d6 4817 (default_value, arithcompare, arith_driver, arith_error): Now static.
b9b84fa9 4818 (store_symval_forwarding): Rename local to avoid shadowing.
44f230aa
SM
4819 (Fmake_variable_buffer_local, Fmake_local_variable):
4820 Mark variables as initialized.
52746918 4821 (do_blv_forwarding, do_symval_forwarding): Remove; unused.
946f9a5b 4822
e5aab7e7 4823 * alloc.c (check_cons_list): Do not define unless GC_CHECK_CONS_LIST.
ae35e756
PE
4824 (Fmake_vector, Fvector, Fmake_byte_code, Fgarbage_collect):
4825 Rename locals to avoid shadowing.
dff45157
PE
4826 (mark_stack): Move local variables into the #ifdef region where
4827 they're used.
7bc26fdb
PE
4828 (BLOCK_INPUT_ALLOC, UNBLOCK_INPUT_ALLOC): Define only if
4829 ! defined SYSTEM_MALLOC && ! defined SYNC_INPUT, as they are not
4830 needed otherwise.
4831 (CHECK_ALLOCATED): Define only if GC_CHECK_MARKED_OBJECTS.
4832 (GC_STRING_CHARS): Remove; not used.
d40d4be1 4833 (Fmemory_limit): Cast sbrk's returned value to char *.
ae35e756 4834
e5aab7e7
PE
4835 * lisp.h (check_cons_list): Declare if GC_CHECK_CONS_LIST; this
4836 avoids undefined behavior in theory.
4837
4da60324
PE
4838 * regex.c (IF_LINT): Add defn, for benefit of ../lib-src.
4839
88043301
PE
4840 Use functions, not macros, for up- and down-casing (Bug#8254).
4841 * buffer.h (DOWNCASE_TABLE, UPCASE_TABLE, DOWNCASE, UPPERCASEP):
4842 (NOCASEP, LOWERCASEP, UPCASE, UPCASE1): Remove. All callers changed
4843 to use the following functions instead of these macros.
4844 (downcase): Adjust to lack of DOWNCASE_TABLE. Return int, not
4845 EMACS_INT, since callers assume the returned value fits in int.
4846 (upcase1): Likewise, for UPCASE_TABLE.
4847 (uppercasep, lowercasep, upcase): New static inline functions.
0da09c43 4848 * editfns.c (Fchar_equal): Remove no-longer-needed workaround for
db69b0cd 4849 the race-condition problem in the old DOWNCASE.
88043301 4850
19ed5445
PE
4851 * regex.c (CHARSET_LOOKUP_RANGE_TABLE_RAW, POP_FAILURE_REG_OR_COUNT):
4852 Rename locals to avoid shadowing.
4853 (regex_compile, re_match_2_internal): Move locals to avoid shadowing.
abbd1bcf
PE
4854 (regex_compile, re_search_2, re_match_2_internal):
4855 Remove unused local vars.
952db0d7
PE
4856 (FREE_VAR): Rewrite so as not to use empty "else",
4857 which gcc can warn about.
da053e48 4858 (regex_compile, re_match_2_internal): Mark locals as initialized.
b313f9d8
PE
4859 (RETALLOC_IF): Define only if needed.
4860 (WORDCHAR_P): Likewise. This one is never needed, but is used
4861 only in a comment talking about a compiler bug, so put inside
4862 the #if 0 of that comment.
4863 (CHARSET_LOOKUP_BITMAP, FAIL_STACK_FULL, RESET_FAIL_STACK):
4864 (PUSH_FAILURE_ELT, BUF_PUSH_3, STOP_ADDR_VSTRING):
4865 Remove; unused.
19ed5445 4866
1f3561e4 4867 * search.c (boyer_moore): Rename locals to avoid shadowing.
76ef09b7
PE
4868 * character.h (FETCH_STRING_CHAR_AS_MULTIBYTE_ADVANCE):
4869 (PREV_CHAR_BOUNDARY): Likewise.
1f3561e4 4870
ded6f8f7
PE
4871 * search.c (simple_search): Remove unused var.
4872
dbd37a95
PE
4873 * dired.c (compile_pattern): Move decl from here ...
4874 * lisp.h: ... to here, so that it can be checked.
4875 (struct re_registers): New forward decl.
4876
7e47afad
PE
4877 * character.h (INC_POS, DEC_POS): Rename locals to avoid shadowing.
4878
85f24f61
PE
4879 * indent.c (MULTIBYTE_BYTES_WIDTH): New args bytes, width.
4880 All uses changed.
4881 (MULTIBYTE_BYTES_WIDTH, scan_for_column, compute_motion):
4882 Rename locals to avoid shadowing.
5671df8f 4883 (Fvertical_motion): Mark locals as initialized.
85f24f61 4884
181aa2be 4885 * casefiddle.c (casify_object, casify_region): Now static.
e45a141a 4886 (casify_region): Mark local as initialized.
181aa2be 4887
930d429c
PE
4888 * cmds.c (internal_self_insert): Rename local to avoid shadowing.
4889
7082eac6
PE
4890 * lisp.h (GCPRO2_VAR, GCPRO3_VAR, GCPRO4_VAR, GCPRO5_VAR, GCPRO6_VAR):
4891 New macros, so that the caller can use some names other than
4892 gcpro1, gcpro2, etc.
4893 (GCPRO2, GCPRO3, GCPRO4, GCPRO5, GCPRO6): Reimplement in terms
4894 of the new macros.
4895 (GCPRO1_VAR, UNGCPRO_VAR): Change the meaning of the second
4896 argument, for consistency with GCPRO2_VAR, etc: it is now the
4897 prefix of the variable, not the variable itself. All uses
4898 changed.
38b2c076
PE
4899 * dired.c (directory_files_internal, file_name_completion):
4900 Rename locals to avoid shadowing.
4901
15206ed9
PE
4902 Fix a race condition diagnosed by gcc -Wsequence-point (Bug#8254).
4903 An expression of the form (DOWNCASE (x) == DOWNCASE (y)), found in
4904 dired.c's scmp function, had undefined behavior.
4905 * lisp.h (DOWNCASE_TABLE, UPCASE_TABLE, DOWNCASE, UPPERCASEP):
4906 (NOCASEP, LOWERCASEP, UPCASE, UPCASE1): Move from here ...
4907 * buffer.h: ... to here, because these macros use current_buffer,
4908 and the new implementation with inline functions needs to have
4909 current_buffer in scope now, rather than later when the macros
4910 are used.
4911 (downcase, upcase1): New static inline functions.
4912 (DOWNCASE, UPCASE1): Reimplement using these functions.
4913 This avoids undefined behavior in expressions like
4914 DOWNCASE (x) == DOWNCASE (y), which previously suffered
4915 from race conditions in accessing the global variables
4916 case_temp1 and case_temp2.
4917 * casetab.c (case_temp1, case_temp2): Remove; no longer needed.
4918 * lisp.h (case_temp1, case_temp2): Remove their decls.
4919 * character.h (ASCII_CHAR_P): Move from here ...
4920 * lisp.h: ... to here, so that the inline functions mentioned
4921 above can use them.
4922
4a6bea26
PE
4923 * dired.c (directory_files_internal_unwind): Now static.
4924
f14b7e14
PE
4925 * fileio.c (file_name_as_directory, directory_file_name):
4926 (barf_or_query_if_file_exists, auto_save_error, auto_save_1):
4927 Now static.
2893f146
PE
4928 (file_name_as_directory): Use const pointers when appropriate.
4929 (Fexpand_file_name): Likewise. In particular, newdir might
4930 point at constant storage, so make it a const pointer.
fd4ead52 4931 (Fmake_directory_internal, Fread_file_name): Remove unused vars.
b14aac08
PE
4932 (Ffile_selinux_context, Fset_file_selinux_context): Fix pointer
4933 signedness issues.
f839df0c
PE
4934 (Fset_file_times, Finsert_file_contents, auto_save_error):
4935 Rename locals to avoid shadowing.
f14b7e14 4936
5716756e 4937 * minibuf.c (choose_minibuf_frame_1): Now static.
62137a95
PE
4938 (Ftry_completion, Fall_completions): Rename or remove locals
4939 to avoid shadowing.
5716756e 4940
b4c3046a
PE
4941 * marker.c (bytepos_to_charpos): Remove; unused.
4942
b45db522
PE
4943 * lisp.h (verify_bytepos, count_markers): New decls,
4944 so that gcc does not warn that these functions aren't declared.
4945
85876d07
PE
4946 * insdel.c (check_markers, make_gap_larger, make_gap_smaller):
4947 (reset_var_on_error, Fcombine_after_change_execute_1): Now static.
f0cb4a60 4948 (CHECK_MARKERS): Redo to avoid gcc -Wempty-body diagnostic.
40ef059e 4949 (copy_text): Remove unused local var.
85876d07 4950
03d78a21 4951 * filelock.c (within_one_second): Now static.
b3dd38ab 4952 (lock_file_1): Rename local to avoid shadowing.
03d78a21 4953
5df8f01b
PE
4954 * buffer.c (fix_overlays_before): Mark locals as initialized.
4955 (fix_start_end_in_overlays): Likewise. This function should be
4956 simplified by using pointers-to-pointers, but that's a different
4957 matter.
b1d876f1 4958 (switch_to_buffer_1): Now static.
8f54f30a
PE
4959 (Fkill_buffer, record_buffer, Fbury_buffer, Fset_buffer_multibyte):
4960 (report_overlay_modification): Rename locals to avoid shadowing.
c3bd59b5 4961
a70072c9 4962 * sysdep.c (system_process_attributes): Rename vars to avoid shadowing.
fbd02d7b 4963 Fix pointer signedness issue.
edced198
PE
4964 (sys_subshell): Mark local as volatile if checking for lint,
4965 to suppress a gcc -Wclobbered warning that does not seem to be right.
15dfd3d9 4966 (MAXPATHLEN): Define only if needed.
a70072c9 4967
a0977c44
PE
4968 * process.c (serial_open, serial_configure): Move decls from here ...
4969 * systty.h: ... to here, so that they can be checked.
4970
a884fdcc
PE
4971 * fns.c (get_random, seed_random): Move extern decls from here ...
4972 * lisp.h: ... to here, so that they can be checked.
4973
604efe86 4974 * sysdep.c (reset_io): Now static.
b8950c94 4975 (wait_for_termination_signal): Remove; unused.
604efe86 4976
38fc62d9
PE
4977 * keymap.c (keymap_parent, keymap_memberp, map_keymap_internal):
4978 (copy_keymap_item, append_key, push_text_char_description):
4979 Now static.
1004a21a 4980 (Fwhere_is_internal): Don't test CONSP (sequences) unnecessarily.
dbbb8427 4981 (DENSE_TABLE_SIZE): Remove; unused.
c1141155
PE
4982 (get_keymap, access_keymap, Fdefine_key, Fwhere_is_internal):
4983 (describe_map_tree):
4984 Rename locals to avoid shadowing.
38fc62d9 4985
2f2650da
PE
4986 * keyboard.c: Declare functions static if they are not used elsewhere.
4987 (echo_char, echo_dash, cmd_error, top_level_2):
4988 (poll_for_input, handle_async_input): Now static.
69a058fa
PE
4989 (read_char, kbd_buffer_get_event, make_lispy_position):
4990 (make_lispy_event, make_lispy_movement, apply_modifiers):
4991 (decode_keyboard_code, tty_read_avail_input, menu_bar_items):
4992 (parse_tool_bar_item, read_key_sequence, Fread_key_sequence):
4993 (Fread_key_sequence_vector): Rename locals to avoid shadowing.
c8a06054 4994 (read_key_sequence, read_char): Mark locals as initialized.
3ac94672 4995 (Fexit_recursive_edit, Fabort_recursive_edit): Mark with NO_RETURN.
2f2650da 4996
a053e86c 4997 * keyboard.h (make_ctrl_char): New decl.
da2f2dd9
PE
4998 (mark_kboards): Move decl here ...
4999 * alloc.c (mark_kboards): ... from here.
a053e86c 5000
4752793e
PE
5001 * lisp.h (force_auto_save_soon): New decl.
5002
74f10ca7 5003 * emacs.c (init_cmdargs): Rename local to avoid shadowing.
244fc23d
PE
5004 (DEFINE_DUMMY_FUNCTION): New macro.
5005 (__do_global_ctors, __do_global_ctors_aux, __do_global_dtors, __main):
5006 Use it.
c03cd23f
PE
5007 (main): Add casts to avoid warnings
5008 if GCC considers string literals to be constants.
74f10ca7 5009
022e70d4
PE
5010 * lisp.h (fatal_error_signal): Add decl, since it's exported.
5011
59d6fe83
PE
5012 * dbusbind.c: Pointer signedness fixes.
5013 (xd_signature, xd_append_arg, xd_initialize):
5014 (Fdbus_call_method, Fdbus_call_method_asynchronously):
5015 (Fdbus_method_return_internal, Fdbus_method_error_internal):
5016 (Fdbus_send_signal, xd_read_message_1, Fdbus_register_service):
5017 (Fdbus_register_signal): Use SSDATA when the context wants char *.
5018
78320123
PE
5019 * dbusbind.c (Fdbus_init_bus): Add cast to avoid warning
5020 if GCC considers string literals to be constants.
49cebcca 5021 (Fdbus_register_service, Fdbus_register_method): Remove unused vars.
78320123 5022
35ac2a97
SM
50232011-03-16 Stefan Monnier <monnier@iro.umontreal.ca>
5024
fb103ca9
SM
5025 * print.c (PRINT_CIRCLE_CANDIDATE_P): New macro.
5026 (print_preprocess, print_object): New macro to fix last change.
5027
35ac2a97
SM
5028 * print.c (print_preprocess): Don't forget font objects.
5029
62973b41
JB
50302011-03-16 Juanma Barranquero <lekktu@gmail.com>
5031
5032 * emacs.c (USAGE3): Doc fixes.
5033
0e48bb22
AS
50342011-03-15 Andreas Schwab <schwab@linux-m68k.org>
5035
5036 * coding.c (detect_coding_iso_2022): Reorganize code to clarify
5037 structure.
5038
7684e57b
JB
50392011-03-14 Juanma Barranquero <lekktu@gmail.com>
5040
5041 * lisp.h (VWindow_system, Qfile_name_history):
5042 * keyboard.h (lispy_function_keys) [WINDOWSNT]:
5043 * w32term.h (w32_system_caret_hwnd, w32_system_caret_height)
5044 (w32_system_caret_x, w32_system_caret_y): Declare extern.
5045
5046 * w32select.c: Don't #include "keyboard.h".
c96bbc66 5047 (run_protected): Add extern declaration for waiting_for_input.
7684e57b
JB
5048
5049 * w32.c (Qlocal, noninteractive1, inhibit_window_system):
5050 * w32console.c (detect_input_pending, read_input_pending)
5051 (encode_terminal_code):
5052 * w32fns.c (quit_char, lispy_function_keys, Qtooltip)
5053 (w32_system_caret_hwnd, w32_system_caret_height, w32_system_caret_x)
5054 (w32_system_caret_y, Qfile_name_history):
5055 * w32font.c (w32font_driver, QCantialias, QCotf, QClang):
5056 * w32inevt.c (reinvoke_input_signal, lispy_function_keys):
5057 * w32menu.c (Qmenu_bar, QCtoggle, QCradio, Qoverriding_local_map)
5058 (Qoverriding_terminal_local_map, Qmenu_bar_update_hook):
5059 * w32proc.c (Qlocal, report_file_error):
5060 * w32term.c (Vwindow_system, updating_frame):
5061 * w32uniscribe.c (initialized, uniscribe_font_driver):
5062 Remove unneeded extern declarations.
5063
2aa46d6c
CY
50642011-03-14 Chong Yidong <cyd@stupidchicken.com>
5065
c96bbc66 5066 * buffer.c (Fmake_indirect_buffer): Fix incorrect assertions.
2aa46d6c 5067
cffc6f3b
CY
50682011-03-13 Chong Yidong <cyd@stupidchicken.com>
5069
5070 * buffer.h (BUF_BEGV, BUF_BEGV_BYTE, BUF_ZV, BUF_ZV_BYTE, BUF_PT)
5071 (BUF_PT_BYTE): Rewrite to handle indirect buffers (Bug#8219).
5072 These macros can no longer be used for assignment.
5073
44f230aa
SM
5074 * buffer.c (Fget_buffer_create, Fmake_indirect_buffer):
5075 Assign struct members directly, instead of using BUF_BEGV etc.
cffc6f3b
CY
5076 (record_buffer_markers, fetch_buffer_markers): New functions for
5077 recording and fetching special buffer markers.
5078 (set_buffer_internal_1, set_buffer_temp): Use them.
5079
5080 * lread.c (unreadchar): Use SET_BUF_PT_BOTH.
5081
5082 * insdel.c (adjust_point): Use SET_BUF_PT_BOTH.
5083
5084 * intervals.c (temp_set_point_both): Use SET_BUF_PT_BOTH.
5085 (get_local_map): Use SET_BUF_BEGV_BOTH and SET_BUF_ZV_BOTH.
5086
5087 * xdisp.c (hscroll_window_tree):
5088 (reconsider_clip_changes): Use PT instead of BUF_PT.
5089
d251f04b
EZ
50902011-03-13 Eli Zaretskii <eliz@gnu.org>
5091
5092 * makefile.w32-in ($(BLD)/editfns.$(O)): Depend on
5093 $(EMACS_ROOT)/lib/intprops.h.
5094
f0c77cd1
PE
50952011-03-13 Paul Eggert <eggert@cs.ucla.edu>
5096
3eca4629
PE
5097 Fix more problems found by GCC 4.5.2's static checks.
5098
7c86ee98
PE
5099 * gtkutil.c (xg_get_pixbuf_from_pixmap): Add cast from char *
5100 to unsigned char * to avoid compiler diagnostic.
b0afc268
PE
5101 (xg_free_frame_widgets): Make it clear that a local variable is
5102 needed only if USE_GTK_TOOLTIP.
01e0b5ad
PE
5103 (gdk_window_get_screen): Make it clear that this macro is needed
5104 only if USE_GTK_TOOLTIP.
1e5524e7
PE
5105 (int_gtk_range_get_value): New function, which avoids a diagnostic
5106 from gcc -Wbad-function-cast.
5107 (xg_set_toolkit_scroll_bar_thumb): Use it.
5108 (xg_tool_bar_callback, xg_tool_item_stale_p): Rewrite to avoid
5109 diagnostic from gcc -Wbad-function-cast.
65dc836c
PE
5110 (get_utf8_string, xg_get_file_with_chooser):
5111 Rename locals to avoid shadowing.
5112 (create_dialog): Move locals to avoid shadowing.
7c86ee98 5113
41729b81
PE
5114 * xgselect.c (xg_select): Remove unused var.
5115
f0c77cd1
PE
5116 * image.c (four_corners_best): Mark locals as initialized.
5117 (gif_load): Initialize transparent_p to zero (Bug#8238).
5118 Mark another local as initialized.
ec6cf4c6 5119 (my_png_error, my_error_exit): Mark with NO_RETURN.
f0c77cd1 5120
ce0ad53d 5121 * image.c (clear_image_cache): Now static.
d5d5a617 5122 (DIM, HAVE_STDLIB_H_1): Remove unused macros.
e22cffbc 5123 (xpm_load): Redo to avoid "discards qualifiers" gcc warning.
77a765fd
PE
5124 (x_edge_detection): Remove unnecessary cast that
5125 gcc -Wbad-function-cast diagnoses.
2037898d 5126 (gif_load): Fix pointer signedness.
6ae141d6
PE
5127 (clear_image_cache, xbm_read_bitmap_data, x_detect_edges):
5128 (jpeg_load, gif_load): Rename locals to avoid shadowing.
ce0ad53d 5129
33383987 51302011-03-12 Paul Eggert <eggert@cs.ucla.edu>
3eca4629 5131
d32df629
PE
5132 Improve quality of tests for time stamp overflow.
5133 For example, without this patch (encode-time 0 0 0 1 1
5134 1152921504606846976) returns the obviously-bogus value (-948597
5135 62170) on my RHEL 5.5 x86-64 host. With the patch, it correctly
5136 reports time overflow. See
5137 <http://lists.gnu.org/archive/html/emacs-devel/2011-03/msg00470.html>.
b8d9bd41
PE
5138 * deps.mk (editfns.o): Depend on ../lib/intprops.h.
5139 * editfns.c: Include limits.h and intprops.h.
5140 (TIME_T_MIN, TIME_T_MAX): New macros.
5141 (time_overflow): Move earlier, to before first use.
5142 (hi_time, lo_time): New functions, for an accurate test for
5143 out-of-range times.
5144 (Fcurrent_time, Fget_internal_run_time, make_time): Use them.
5145 (Fget_internal_run_time): Don't assume time_t fits in int.
5146 (make_time): Use list2 instead of Fcons twice.
5147 (Fdecode_time): More accurate test for out-of-range times.
5148 (check_tm_member): New function.
5149 (Fencode_time): Use it, to test for out-of-range times.
d32df629
PE
5150 (lisp_time_argument): Don't rely on undefined left-shift and
5151 right-shift behavior when checking for time stamp overflow.
8be6f318 5152
fe31d94c
PE
5153 * editfns.c (time_overflow): New function, refactoring common code.
5154 (Fformat_time_string, Fdecode_time, Fencode_time):
5155 (Fcurrent_time_string): Use it.
5156
8be6f318
PE
5157 Move 'make_time' to be next to its inverse 'lisp_time_argument'.
5158 * dired.c (make_time): Move to ...
5159 * editfns.c (make_time): ... here.
5160 * systime.h: Note the move.
5161
09d9db2c 51622011-03-12 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
c47cbdfd 5163
126bc0dc
YM
5164 * fringe.c (update_window_fringes): Remove unused variables.
5165
c47cbdfd
YM
5166 * unexmacosx.c (copy_data_segment): Also copy __got section.
5167 (Bug#8223)
5168
7ac80be9
EZ
51692011-03-12 Eli Zaretskii <eliz@gnu.org>
5170
c96bbc66 5171 * termcap.c [MSDOS]: Include "msdos.h".
058e5dad
EZ
5172 (find_capability, tgetnum, tgetflag, tgetstr, tputs, tgetent):
5173 Constify `char *' arguments and their references according to
5174 prototypes in tparam.h.
5175
ecb0f94d 5176 * deps.mk (termcap.o): Depend on tparam.h and msdos.h.
058e5dad 5177
7ac80be9
EZ
5178 * msdos.c (XMenuAddPane): 3rd argument is `const char *' now.
5179 Adapt all references accordingly.
5180
5181 * msdos.h (XMenuAddPane): 3rd argument is `const char *' now.
5182
ef1fd07e
TT
51832011-03-11 Tom Tromey <tromey@redhat.com>
5184
5185 * buffer.c (syms_of_buffer): Remove obsolete comment.
5186
7ef4b50c
EZ
51872011-03-11 Eli Zaretskii <eliz@gnu.org>
5188
5189 * termhooks.h (encode_terminal_code): Declare prototype.
5190
5191 * msdos.c (encode_terminal_code): Don't declare prototype.
5192
5193 * term.c (encode_terminal_code): Now external again, used by
5194 w32console.c and msdos.c.
5195
44f230aa
SM
5196 * makefile.w32-in ($(BLD)/term.$(O), ($(BLD)/tparam.$(O)):
5197 Depend on $(SRC)/tparam.h, see 2011-03-11T07:24:21Z!eggert@cs.ucla.edu.
7ef4b50c 5198
4b1ec863 51992011-03-11 Paul Eggert <eggert@cs.ucla.edu>
f78faa98 5200
1714f52b 5201 Fix some minor problems found by GCC 4.5.2's static checks.
83316bf4 5202
4b1ec863
PE
5203 * fringe.c (update_window_fringes): Mark locals as initialized
5204 (Bug#8227).
5205 (destroy_fringe_bitmap, init_fringe_bitmap): Now static.
bf60f616 5206
524c7aa6
PE
5207 * alloc.c (mark_fringe_data): Move decl from here ...
5208 * lisp.h (mark_fringe_data) [HAVE_WINDOW_SYSTEM]: ... to here,
5209 to check its interface.
5210 (init_fringe_once): Do not declare unless HAVE_WINDOW_SYSTEM.
5211
a5c0af81 5212 * fontset.c (free_realized_fontset): Now static.
7519b8cd 5213 (Fset_fontset_font): Rename local to avoid shadowing.
cc6e5db1 5214 (fontset_font): Mark local as initialized.
a9a06e0b 5215 (FONTSET_SPEC, FONTSET_REPERTORY, RFONT_DEF_REPERTORY): Remove; unused.
a5c0af81 5216
b4716021
PE
5217 * xrdb.c: Include "xterm.h", to check x_load_resources's interface.
5218
811e9bac 5219 * xselect.c (x_disown_buffer_selections): Remove; not used.
7b83e2f1 5220 (TRACE3) [!defined TRACE_SELECTION]: Remove; not used.
aa0daa9f
PE
5221 (x_own_selection, Fx_disown_selection_internal): Rename locals
5222 to avoid shadowing.
5223 (x_handle_dnd_message): Remove local to avoid shadowing.
811e9bac 5224
7e3ab302
PE
5225 * lisp.h (GCPRO1_VAR, UNGCPRO_VAR): New macros,
5226 so that the caller can use some name other than gcpro1.
5227 (GCPRO1, UNGCPRO): Reimplement in terms of the new macros.
58d2d479
PE
5228 * xfns.c (Fx_create_frame, x_create_tip_frame, Fx_show_tip):
5229 (Fx_backspace_delete_keys_p):
5230 Use them to avoid shadowing, and rename vars to avoid shadowing.
5231 (x_decode_color, x_set_name, x_window): Now static.
6b437900 5232 (Fx_create_frame): Add braces to silence GCC warning.
c0951e53 5233 (Fx_file_dialog, Fx_select_font): Fix pointer signedness.
06b0c8a0
PE
5234 (x_real_positions, xg_set_icon_from_xpm_data, x_create_tip_frame):
5235 Remove unused locals.
7e3ab302
PE
5236 (Fx_create_frame, x_create_tip_frame, Fx_show_tip):
5237 (Fx_backspace_delete_keys_p): Rename locals to avoid shadowing.
5238 Some of these renamings use the new GCPRO1_VAR and UNGCPRO_VAR
5239 macros.
f78faa98 5240
e2b13473
PE
5241 * xterm.h (x_mouse_leave): New decl.
5242
77f23912
PE
5243 * xterm.c (x_copy_dpy_color, x_focus_on_frame, x_unfocus_frame):
5244 Remove unused functions.
cdf4ba58
PE
5245 (x_shift_glyphs_for_insert, XTflash, XTring_bell):
5246 (x_calc_absolute_position): Now static.
7411c686 5247 (XTread_socket): Don't define label "out" unless it's used.
2b07bcff 5248 Don't declare local "event" unless it's used.
ed7bf3a5
PE
5249 (x_iconify_frame, x_free_frame_resources): Don't declare locals
5250 unless they are used.
38d0b34a
PE
5251 (XEMBED_VERSION, xembed_set_info): Don't define unless needed.
5252 (x_fatal_error_signal): Remove; not used.
a6067996
PE
5253 (x_draw_image_foreground, redo_mouse_highlight, XTmouse_position):
5254 (x_scroll_bar_report_motion, handle_one_xevent, x_draw_bar_cursor):
5255 (x_error_catcher, x_connection_closed, x_error_handler):
5256 (x_error_quitter, xembed_send_message, x_iconify_frame):
5257 (my_log_handler): Rename locals to avoid shadowing.
28f1c698 5258 (x_delete_glyphs, x_ins_del_lines): Mark with NO_RETURN.
2a8fade0 5259 (x_connection_closed): Tell GCC not to suggest NO_RETURN.
77f23912 5260
44f230aa
SM
5261 * xfaces.c (clear_face_cache, Fx_list_fonts, Fface_font):
5262 Rename or move locals to avoid shadowing.
6b463e58 5263 (tty_defined_color, merge_face_heights): Now static.
5967d051 5264 (free_realized_faces_for_fontset): Remove; not used.
1e9966ea
PE
5265 (Fx_list_fonts): Mark variable that gcc -Wuninitialized
5266 does not deduce is never used uninitialized.
73719eba
PE
5267 (STRDUPA, LSTRDUPA, FONT_POINT_SIZE_QUANTUM): Remove; not used.
5268 (LFACEP): Define only if XASSERTS, as it's not needed otherwise.
071048a3 5269
426994c3 5270 * terminal.c (store_terminal_param): Now static.
5489860b 5271
032f1620 5272 * xmenu.c (menu_highlight_callback): Now static.
9d66f88e 5273 (set_frame_menubar): Remove unused local.
d4323972 5274 (xmenu_show): Rename parameter to avoid shadowing.
6d1f7fee
PE
5275 (xmenu_show, xdialog_show, xmenu_show): Make local pointers "const"
5276 since they might point to immutable storage.
281585b0
PE
5277 (next_menubar_widget_id): Declare only if USE_X_TOOLKIT,
5278 since it's unused otherwise.
032f1620 5279
367c19e5 5280 * xdisp.c (produce_glyphless_glyph): Initialize lower_xoff.
53df7c11 5281 Add a FIXME, since the code still doesn't look right. (Bug#8215)
9f36b9fd
PE
5282 (Fcurrent_bidi_paragraph_direction): Simplify slightly; this
5283 avoids a gcc -Wuninitialized diagnostic.
0e086e8f 5284 (display_line, BUILD_COMPOSITE_GLYPH_STRING, draw_glyphs):
44a3a108
PE
5285 (note_mouse_highlight): Mark variables that gcc -Wuninitialized
5286 does not deduce are never used uninitialized.
70739cbe 5287
07b48fa9
PE
5288 * lisp.h (IF_LINT): New macro, copied from ../lib-src/emacsclient.c.
5289
8868a238 5290 * xdisp.c (redisplay_window): Rename local to avoid shadowing.
4554d213
PE
5291 * window.c (window_loop, size_window):
5292 (run_window_configuration_change_hook, enlarge_window): Likewise.
8868a238 5293
7e5cf297 5294 * window.c (display_buffer): Now static.
d6550a9f
PE
5295 (size_window): Mark variables that gcc -Wuninitialized
5296 does not deduce are never used uninitialized.
a586633d
PE
5297 * window.h (check_all_windows): New decl, to forestall
5298 gcc -Wmissing-prototypes diagnostic.
5b555da1 5299 * dispextern.h (bidi_dump_cached_states): Likewise.
7e5cf297 5300
f6095868
PE
5301 * charset.h (CHECK_CHARSET_GET_CHARSET): Rename locals to avoid
5302 shadowing.
5303 * charset.c (map_charset_for_dump, Fchar_charset): Likewise.
726929c4
PE
5304 Include <limits.h>.
5305 (Fsort_charsets): Redo min/max calculation to shorten the code a bit
5306 and to avoid gcc -Wuninitialized warning.
89ef49df
PE
5307 (load_charset_map): Mark variables that gcc -Wuninitialized
5308 does not deduce are never used uninitialized.
53df7c11 5309 (load_charset): Abort instead of using uninitialized var (Bug#8229).
f6095868 5310
f38b440c
PE
5311 * coding.c (coding_set_source, coding_set_destination):
5312 Use "else { /* comment */ }" rather than "else /* comment */;"
5313 for clarity, and to avoid gcc -Wempty-body warning.
2735d060
PE
5314 (Fdefine_coding_system_internal): Don't redeclare 'i' inside
5315 a block, when the outer 'i' will do.
5316 (decode_coding_utf_8, decode_coding_utf_16, detect_coding_emacs_mule):
5317 (emacs_mule_char, decode_coding_emacs_mule, detect_coding_iso_2022):
5318 (decode_coding_iso_2022, decode_coding_sjis, decode_coding_big5):
5319 (decode_coding_raw_text, decode_coding_charset, get_translation_table):
5320 (Fdecode_sjis_char, Fdefine_coding_system_internal):
5321 Rename locals to avoid shadowing.
5322 * character.h (FETCH_STRING_CHAR_ADVANCE): Likewise.
e2f1bab9
PE
5323 * coding.c (emacs_mule_char, encode_invocation_designation):
5324 Now static, since they're not used elsewhere.
413bb2db 5325 (decode_coding_iso_2022): Add "default: abort ();" as a safety check.
c4a63b12 5326 (decode_coding_object, encode_coding_object, detect_coding_system):
ee05f961
PE
5327 (decode_coding_emacs_mule): Mark variables that gcc
5328 -Wuninitialized does not deduce are never used uninitialized.
160b01f6
PE
5329 (detect_coding_iso_2022): Initialize a local variable that might
5330 be used uninitialized. Leave a FIXME because it's not clear that
53df7c11 5331 this initialization is needed. (Bug#8211)
5f58e762
PE
5332 (ISO_CODE_LF, ISO_CODE_CR, CODING_ISO_FLAG_EUC_TW_SHIFT):
5333 (ONE_MORE_BYTE_NO_CHECK, UTF_BOM, UTF_16_INVALID_P):
5334 (SHIFT_OUT_OK, ENCODE_CONTROL_SEQUENCE_INTRODUCER):
5335 (ENCODE_DIRECTION_R2L, ENCODE_DIRECTION_L2R):
5336 Remove unused macros.
f38b440c 5337
232b38b9 5338 * category.c (hash_get_category_set): Remove unused local var.
9f3b5e69 5339 (copy_category_table): Now static, since it's not used elsewhere.
d0891610 5340 * character.c (string_count_byte8): Likewise.
232b38b9 5341
fb90da1b
PE
5342 * ccl.c (CCL_WRITE_STRING, CCL_ENCODE_CHAR, Fccl_execute_on_string):
5343 (Fregister_code_conversion_map): Rename locals to avoid shadowing.
5344
fb93dbc2
PE
5345 * chartab.c (copy_sub_char_table): Now static, since it's not used
5346 elsewhere.
5c156ace
PE
5347 (sub_char_table_ref_and_range, char_table_ref_and_range):
5348 Rename locals to avoid shadowing.
bbcd0949 5349 (ASET_RANGE, GET_SUB_CHAR_TABLE): Remove unused macros.
fb93dbc2 5350
7d3b3862 5351 * bidi.c (bidi_check_type): Now static, since it's not used elsewhere.
630d6892 5352 (BIDI_BOB): Remove unused macro.
7d3b3862 5353
6be7d3da
PE
5354 * cm.c (cmgoto): Mark variables that gcc -Wuninitialized does not
5355 deduce are never used uninitialized.
c2ed9c8b 5356 * term.c (encode_terminal_code): Likewise.
6be7d3da 5357
75f8807f 5358 * term.c (encode_terminal_code): Now static. Remove unused local.
72abad34 5359
50938595
PE
5360 * tparam.h: New file.
5361 * term.c, tparam.h: Include it.
5362 * deps.mk (term.o, tparam.o): Depend on tparam.h.
5363 * term.c (tputs, tgetent, tgetflag, tgetnum, tparam, tgetstr):
5364 Move these decls to tparam.h, and make them agree with what
5365 is actually in tparam.c. The previous trick of using incompatible
5366 decls in different modules does not conform to the C standard.
5367 All callers of tparam changed to use tparam's actual API.
5368 * tparam.c (tparam1, tparam, tgoto):
5369 Use const pointers where appropriate.
5370
fbceeba2
PE
5371 * cm.c (calccost, cmgoto): Use const pointers where appropriate.
5372 * cm.h (struct cm): Likewise.
5373 * dispextern.h (do_line_insertion_deletion_costs): Likewise.
5374 * scroll.c (ins_del_costs, do_line_insertion_deletion_costs): Likewise.
5375 * term.c (tty_ins_del_lines, calculate_costs, struct fkey_table):
5376 (term_get_fkeys_1, append_glyphless_glyph, produce_glyphless_glyph):
5377 (turn_on_face, init_tty): Likewise.
5378 * termchar.h (struct tty_display_info): Likewise.
fbceeba2 5379
7f3f1250
PE
5380 * term.c (term_mouse_position): Rename local to avoid shadowing.
5381
e6ca6543
PE
5382 * alloc.c (mark_ttys): Move decl from here ...
5383 * lisp.h (mark_ttys): ... to here, so that it's checked against defn.
5384
c40f8d15
AS
53852011-03-11 Andreas Schwab <schwab@linux-m68k.org>
5386
5387 * .gdbinit (pwinx, xbuffer): Fix access to buffer name.
5388
cfe0661d
JB
53892011-03-09 Juanma Barranquero <lekktu@gmail.com>
5390
5391 * search.c (compile_pattern_1): Remove argument regp, unused since
5392 revid:rms@gnu.org-19941211082627-3x1g1wyqkjmwloig.
5393 (compile_pattern): Don't pass it.
5394
0afb4571
J
53952011-03-08 Jan Djärv <jan.h.d@swipnet.se>
5396
5397 * xterm.h (DEFAULT_GDK_DISPLAY): New define.
5398 (GDK_WINDOW_XID, gtk_widget_get_preferred_size): New defines
5399 for ! HAVE_GTK3.
5400 (GTK_WIDGET_TO_X_WIN): Use GDK_WINDOW_XID.
5401
5402 * xmenu.c (menu_position_func): Call gtk_widget_get_preferred_size.
5403
5404 * gtkutil.c: Include gtkx.h if HAVE_GTK3. If ! HAVE_GTK3, define
5405 gdk_window_get_screen, gdk_window_get_geometry,
5406 gdk_x11_window_lookup_for_display and GDK_KEY_g.
5407 (xg_set_screen): Use DEFAULT_GDK_DISPLAY.
5408 (xg_get_pixbuf_from_pixmap): New function.
5409 (xg_get_pixbuf_from_pix_and_mask): Change parameters from GdkPixmap
5410 to Pixmap, take frame as parameter, remove GdkColormap parameter.
5411 Call xg_get_pixbuf_from_pixmap instead of
5412 gdk_pixbuf_get_from_drawable.
5413 (xg_get_image_for_pixmap): Do not make GdkPixmaps, call
5414 xg_get_pixbuf_from_pix_and_mask with Pixmap parameters instead.
5415 (xg_check_special_colors): Use GtkStyleContext and its functions
5416 for HAVE_GTK3.
5417 (xg_prepare_tooltip, xg_hide_tooltip): Call gdk_window_get_screen.
5418 (xg_prepare_tooltip, create_dialog, menubar_map_cb)
5419 (xg_update_frame_menubar, xg_tool_bar_detach_callback)
44f230aa
SM
5420 (xg_tool_bar_attach_callback, xg_update_tool_bar_sizes):
5421 Call gtk_widget_get_preferred_size.
0afb4571
J
5422 (xg_frame_resized): gdk_window_get_geometry only takes 5
5423 parameters.
44f230aa
SM
5424 (xg_win_to_widget, xg_event_is_for_menubar):
5425 Call gdk_x11_window_lookup_for_display.
0afb4571
J
5426 (xg_set_widget_bg): New function.
5427 (delete_cb): New function.
895009e1 5428 (xg_create_frame_widgets): Connect delete-event to delete_cb.
0afb4571
J
5429 Call xg_set_widget_bg. Only set backgrund pixmap for ! HAVE_GTK3
5430 (xg_set_background_color): Call xg_set_widget_bg.
5431 (xg_set_frame_icon): Call xg_get_pixbuf_from_pix_and_mask.
5432 (xg_create_scroll_bar): vadj is a GtkAdjustment for HAVE_GTK3.
5433 Only call gtk_range_set_update_policy if ! HAVE_GTK3.
5434 (xg_make_tool_item): Only connect xg_tool_bar_item_expose_callback
5435 if ! HAVE_GTK3.
5436 (update_frame_tool_bar): Call gtk_widget_hide.
5437 (xg_initialize): Use GDK_KEY_g.
5438
5439 * xsmfns.c (gdk_set_sm_client_id): Define to gdk_set_sm_client_id
5440 if ! HAVE_GTK3
5441 (x_session_initialize): Call gdk_x11_set_sm_client_id.
5442
5443 * xterm.c (XFillRectangle): Use cairo routines for HAVE_GTK3.
5444 (x_term_init): Disable Xinput(2) with GDK_CORE_DEVICE_EVENTS.
5445 Load ~/emacs.d/gtkrc only for ! HAVE_GTK3.
5446
1c2cc4ef
JB
54472011-03-08 Juanma Barranquero <lekktu@gmail.com>
5448
5449 * w32xfns.c (select_palette): Check success of RealizePalette against
5450 GDI_ERROR, not zero.
5451
33383987 5452See ChangeLog.11 for earlier changes.
aac0c6e3
MR
5453
5454;; Local Variables:
5455;; coding: utf-8
aac0c6e3
MR
5456;; End:
5457
33383987 5458 Copyright (C) 2011 Free Software Foundation, Inc.
aac0c6e3
MR
5459
5460 This file is part of GNU Emacs.
5461
5462 GNU Emacs is free software: you can redistribute it and/or modify
5463 it under the terms of the GNU General Public License as published by
5464 the Free Software Foundation, either version 3 of the License, or
5465 (at your option) any later version.
5466
5467 GNU Emacs is distributed in the hope that it will be useful,
5468 but WITHOUT ANY WARRANTY; without even the implied warranty of
5469 MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
5470 GNU General Public License for more details.
5471
5472 You should have received a copy of the GNU General Public License
5473 along with GNU Emacs. If not, see <http://www.gnu.org/licenses/>.