2 GiB, not 4 GiB, for buffer sizes.
[bpt/emacs.git] / src / ChangeLog
CommitLineData
2c91f553
EZ
12011-10-17 Eli Zaretskii <eliz@gnu.org>
2
3 * xdisp.c (push_display_prop): Determine whether to record string
4 or buffer position by IT->string, not by IT->method. Allow
5 GET_FROM_DISPLAY_VECTOR as IT->method on entry. (Bug#9771, part 4)
f2ff9e88
EZ
6 (move_it_vertically_backward): Don't look for character position
7 immediately after the newline when in a continuation line.
8 (Bug#9771, part 1)
2c91f553 9
c7b08b0d
MR
102011-10-15 Martin Rudalics <rudalics@gmx.at>
11
12 * window.c (coordinates_in_window): Rewrite and delabelize
13 vertical border check. (Bug#5357) (Bug#9618)
14
6b02f655
SM
152011-10-14 Stefan Monnier <monnier@iro.umontreal.ca>
16
17 * xterm.c (frame_highlight, frame_unhighlight): Ignore unexplained
18 errors in XSetWindowBorder (bug#9310).
19
81d40c92
DA
202011-10-13 Dmitry Antipov <dmantipov@yandex.ru>
21
22 * editfns.c (Fset_time_zone_rule): Replace free with xfree to
23 avoid crash when xmalloc overrun checking is enabled.
24
d4172c3b
EZ
252011-10-13 Eli Zaretskii <eliz@gnu.org>
26
27 * xdisp.c (Fcurrent_bidi_paragraph_direction): Initialize
28 itb.paragraph_dir to NEUTRAL_DIR. Fixes an occasional incorrect
29 cursor motion with <left> and <right> arrow keys.
30
31 * bidi.c (bidi_init_it): Don't initialize paragraph_dir here, as
32 some callers set that themselves.
33
b00eea75
EZ
342011-10-12 Eli Zaretskii <eliz@gnu.org>
35
36 * xdisp.c (find_row_edges): Handle the case where ROW comes from a
37 display string and the previous row comes from the same string and
38 is empty. (Bug#9739) (Bug#9738)
39
8fe012c4
SM
402011-10-12 Stefan Monnier <monnier@iro.umontreal.ca>
41
42 * doc.c (get_doc_string): Encode file name (bug#9735).
43
0074aef2
EZ
442011-10-12 Eli Zaretskii <eliz@gnu.org>
45
79beb178
EZ
46 * bidi.c (bidi_level_of_next_char):
47 * xdisp.c (get_visually_first_element): Remove old incorrect
48 comments regarding the Unicode Line Separator character.
49
0074aef2
EZ
50 * bidi.c (bidi_init_it): Initialize paragraph_dir to NEUTRAL_DIR.
51
6e4b3fbe
DA
522011-10-12 Dmitry Antipov <dmantipov@yandex.ru>
53
54 * alloc.c (Fgc_status): Do not access beyond zombies array
55 boundary if nzombies > MAX_ZOMBIES.
56 * alloc.c (dump_zombies): Add missing format specifier.
57
0324f3af
PE
582011-10-12 Paul Eggert <eggert@cs.ucla.edu>
59
b5525cac
PE
60 * xdisp.c (set_cursor_from_row): Simplify conditionals,
61 to pacify GCC 4.6.1 x86-64 with -O2 -Wstrict-overflow.
62
0324f3af
PE
63 * lread.c (read_escape): Allow hex escapes as large as ?\xfffffff.
64 Some packages use them to denote characters with modifiers.
65
e9b5f888
AS
662011-10-11 Andreas Schwab <schwab@linux-m68k.org>
67
68 * lisp.h (GCPRO1_VAR, GCPRO2_VAR, GCPRO3_VAR, GCPRO4_VAR)
69 (GCPRO5_VAR, GCPRO6_VAR, UNGCPRO_VAR): Add whitespace to avoid
70 matching a pp-number. Rename parameter var to var1.
71
127827c0
SM
722011-10-11 Stefan Monnier <monnier@iro.umontreal.ca>
73
74 * minibuf.c (Finternal_complete_buffer): Fix last change (bug#9709).
75
c8fd3bd0
GM
762011-10-08 Glenn Morris <rgm@gnu.org>
77
78 * callint.c (Fcall_interactively): Give a more explicit error for the
79 'c' case with a non-character input. (Bug#8479)
80
352ec8ff
EZ
812011-10-08 Eli Zaretskii <eliz@gnu.org>
82
03669ccb
EZ
83 * xdisp.c (hscroll_window_tree): Support hscroll in right-to-left
84 lines.
7061c986
EZ
85 (set_cursor_from_row): Fix cursor positioning in mixed L2R+R2L
86 lines that are hscrolled on the left.
03669ccb 87
352ec8ff
EZ
88 * dispnew.c (buffer_posn_from_coords): Account for a possible
89 presence of header-line. (Bug#4426)
90
a66cfb1c
SM
912011-10-07 Stefan Monnier <monnier@iro.umontreal.ca>
92
6b02f655
SM
93 * buffer.c (syms_of_buffer) <enable-multibyte-characters>:
94 Don't advertise functionality which we discourage or doesn't work.
a66cfb1c 95
7c5ee88e
PE
962011-10-07 Paul Eggert <eggert@cs.ucla.edu>
97
98 * alloc.c (GC_LISP_OBJECT_ALIGNMENT): Use offsetof, not __alignof__
99 or sizeof. __alignof__ gives the wrong answer on Fedora x86-64
100 with GCC 4.6.1 when configured with CC='gcc -m32' --with-wide-int;
101 this makes Emacs dump core during garbage collection on rare
102 occasions. sizeof is obviously inferior to offsetof here, so
103 stick with offsetof.
104 (GC_POINTER_ALIGNMENT): New macro.
105 (mark_memory): Omit 3rd (offset) arg; caller changed.
106 Don't assume EMACS_INT alignment is the same as pointer alignment.
107
df1bbe5b
SM
1082011-10-03 Stefan Monnier <monnier@iro.umontreal.ca>
109
110 * keyboard.c (read_key_sequence_remapped): New var.
111 (read_key_sequence): Compute remapping in the right buffer.
112 (command_loop_1): Use read_key_sequence's remapping directly.
113
51553db6
SM
1142011-10-02 Stefan Monnier <monnier@iro.umontreal.ca>
115
32c1fffd
SM
116 * dired.c (file_name_completion): Don't expand file name.
117 (Ffile_name_completion, Ffile_name_all_completions): Expand file name
118 before checking file name handler.
119
51553db6
SM
120 * minibuf.c (Finternal_complete_buffer): Only show internal buffers if
121 they've been requested explicitly (bug#9591).
122
b6bd1599 1232011-10-01 Andreas Schwab <schwab@linux-m68k.org>
fa2ec41f
AS
124
125 * keymap.c (Fsingle_key_description): Use make_specified_string
126 instead of build_string to build string from push_key_description.
127 (Bug#5193)
128
f701dc2a
PE
1292011-09-30 Paul Eggert <eggert@cs.ucla.edu>
130
4222c55d
PE
131 * buffer.h (struct buffer): Use time_t, not int, for a time stamp.
132 This fixes a Y2038 bug on 64-bit hosts.
133 * buffer.c (reset_buffer):
134 * fileio.c (Fdo_auto_save, Fset_buffer_auto_saved)
135 (Fclear_buffer_auto_save_failure):
136 Use 0, not -1, to represent an unset failure time, since time_t
137 might not be signed.
138
f701dc2a
PE
139 Remove dependency on glibc malloc internals.
140 * alloc.c (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
141 Move back here from lisp.h, but with their new implementations.
142 (XMALLOC_BASE_ALIGNMENT, COMMON_MULTIPLE, XMALLOC_HEADER_ALIGNMENT)
143 (XMALLOC_OVERRUN_SIZE_SIZE): Move these new lisp.h macros here.
144 * charset.c (charset_table_init): New static var.
145 (syms_of_charset): Use it instead of xmalloc. This removes a
146 dependency on glibc malloc internals. See Eli Zaretskii's comment in
147 <http://lists.gnu.org/archive/html/emacs-devel/2011-09/msg00815.html>.
148 * lisp.h (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
149 Move back to alloc.c.
150 (XMALLOC_BASE_ALIGNMENT, COMMON_MULTIPLE, XMALLOC_HEADER_ALIGNMENT)
151 (XMALLOC_OVERRUN_SIZE_SIZE): Move to alloc.c.
152
9ceebf39
JD
1532011-09-30 Jan Djärv <jan.h.d@swipnet.se>
154
155 * nsterm.m (windowDidResize): Call x_set_window_size only when
156 ns_in_resize is true. Otherwise set pixelwidth/height and
157 call change_frame_size (Bug#9628).
158
cb993c58
PE
1592011-09-30 Paul Eggert <eggert@cs.ucla.edu>
160
3930c88b
PE
161 Port --enable-checking=all to Fedora 14 x86-64.
162 * charset.c (syms_of_charset): Also account for glibc malloc's
163 internal overhead when calculating the initial malloc maximum.
164
cb993c58
PE
165 Port --enable-checking=all to Fedora 14 x86.
166 * alloc.c (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
167 Move to lisp.h.
168 (xmalloc_put_size, xmalloc_get_size, overrun_check_malloc)
169 (overrun_check_realloc, overrun_check_free):
170 Use XMALLOC_OVERRUN_SIZE_SIZE, not sizeof (size_t).
171 That way, xmalloc returns a properly-aligned pointer even if
172 XMALLOC_OVERRUN_CHECK is defined. The old debugging code happened
173 to align OK on typical 64-bit hosts, but not on Fedora 14 x86.
174 * charset.c (syms_of_charset): Take XMALLOC_OVERRUN_CHECK_OVERHEAD
175 into account when calculating the initial malloc maximum.
176 * lisp.h (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
177 Move here from alloc.c, so that charset.c can use it too.
178 Properly align; the old code wasn't right for common 32-bit hosts
179 when configured with --enable-checking=all.
180 (XMALLOC_BASE_ALIGNMENT, COMMON_MULTIPLE, XMALLOC_HEADER_ALIGNMENT)
181 (XMALLOC_OVERRUN_SIZE_SIZE): New macros.
182
31bed486
EZ
1832011-09-29 Eli Zaretskii <eliz@gnu.org>
184
04c70788 185 * sysdep.c (snprintf) [!EOVERFLOW]: If EOVERFLOW is not defined,
31bed486
EZ
186 use EDOM.
187
fbcaa2f3
EZ
1882011-09-28 Eli Zaretskii <eliz@gnu.org>
189
190 * xdisp.c (compute_display_string_end): If there's no display
191 string at CHARPOS, return -1.
192
193 * bidi.c (bidi_fetch_char): When compute_display_string_end
194 returns a negative value, treat the character as a normal
195 character not covered by a display string. (Bug#9624)
196
a239d4e9
JB
1972011-09-28 Juanma Barranquero <lekktu@gmail.com>
198
199 * lread.c (Fread_from_string): Fix typo in docstring.
200
88652fd5
EZ
2012011-09-27 Eli Zaretskii <eliz@gnu.org>
202
203 * xdisp.c (handle_invisible_prop): If invisible text ends on a
204 newline, reseat the iterator instead of bidi-iterating there one
205 character at a time. (Bug#9610)
32c1fffd
SM
206 (BUFFER_POS_REACHED_P, move_it_in_display_line_to): Bail when past
207 TO_CHARPOS if the bidi iterator is at base embedding level.
88652fd5 208
ed497dd4
AS
2092011-09-27 Andreas Schwab <schwab@linux-m68k.org>
210
211 * lread.c (readevalloop): Use correct code for NBSP.
212 (read1): Likewise. (Bug#9608)
213
b2bf61aa
MA
2142011-09-25 Michael Albinus <michael.albinus@gmx.de>
215
216 * dbusbind.c (Fdbus_register_signal): When service is not
217 registered, use nil in Vdbus_registered_objects_table. (Bug#9581)
218
32bbb17c
GM
2192011-09-25 Glenn Morris <rgm@gnu.org>
220
221 * buffer.c (truncate-lines): Doc fix.
222
94e0933e
CY
2232011-09-24 Chong Yidong <cyd@stupidchicken.com>
224
225 * window.c (Fwindow_prev_buffers, Fset_window_prev_buffers)
226 (Fset_window_next_buffers): Doc fix.
227
cddde921
GM
2282011-09-24 Glenn Morris <rgm@gnu.org>
229
230 * minibuf.c (read_minibuf): Disable line truncation. (Bug#5715)
231
1260aef1
PE
2322011-09-24 Paul Eggert <eggert@cs.ucla.edu>
233
25b4bfa0
PE
234 Fix minor problems found by static checking.
235 * xdisp.c (string_from_display_spec): Don't assume vecsize fits in int.
1260aef1
PE
236 * indent.c (Fvertical_motion): Fix == vs = typo.
237
e3cbd34b
EZ
2382011-09-24 Eli Zaretskii <eliz@gnu.org>
239
a66cfb1c
SM
240 * dispnew.c (syms_of_display) <redisplay-dont-pause>:
241 Default value is now t. Doc fix.
6bf7006f 242
e3cbd34b 243 * indent.c (Fvertical_motion): Compute and apply the overshoot
32c1fffd 244 logic when moving up, not only when moving down. Fix the
e3cbd34b 245 confusing name and values of the it_overshoot_expected variable;
32c1fffd 246 logic changes accordingly. (Bug#9254) (Bug#9549)
e3cbd34b
EZ
247
248 * xdisp.c (pos_visible_p): Produce correct pixel coordinates when
249 CHARPOS is covered by a display string which includes newlines.
250 (move_it_vertically_backward): Avoid inflooping when START_CHARPOS
251 is covered by a display string with embedded newlines.
252
a3de0cbd
MA
2532011-09-24 Michael Albinus <michael.albinus@gmx.de>
254
255 * dbusbind.c (Fdbus_register_signal): Add match rule to
256 Vdbus_registered_objects_table. (Bug#9581)
a66cfb1c
SM
257 (Fdbus_register_method, Vdbus_registered_objects_table):
258 Fix docstring.
a3de0cbd 259
b260039d
JM
2602011-09-24 Jim Meyering <meyering@redhat.com>
261
32c1fffd 262 do not ignore write error for any output size
b260039d
JM
263 The previous change was incomplete.
264 While it makes emacs --batch detect the vast majority of stdout
265 write failures, errors were still ignored whenever the output size is
266 k * (BUFSIZ+1) - 4. E.g., on a system with BUFSIZ of 4096,
267 $ emacs --batch --eval '(print (format "%4093d" 0))' > /dev/full \
268 && echo FAIL: ignored write error
269 FAIL: ignored write error
270 $ emacs --batch --eval '(print (format "%20481d" 0))' > /dev/full \
271 && echo FAIL: ignored write error
272 FAIL: ignored write error
273 * emacs.c (Fkill_emacs): Also test ferror. (Bug#9574)
274
8eca8a7c
AS
2752011-09-23 Andreas Schwab <schwab@linux-m68k.org>
276
277 * emacs.c (Fkill_emacs): In noninteractive mode exit
278 non-successfully if a write error occurred on stdout. (Bug#9574)
279
3341db62
EZ
2802011-09-21 Eli Zaretskii <eliz@gnu.org>
281
282 * xdisp.c (pop_it): Allow it->object that is a cons cell to pass
283 the xassert test.
284
285 * dispextern.h (struct it): Update the comment documenting what
286 can it->OBJECT be.
287
8c203dbf
EZ
2882011-09-20 Eli Zaretskii <eliz@gnu.org>
289
290 * xdisp.c (set_cursor_from_row): If the row ends in a newline from
291 a display string, extend search for cursor position to end of row.
292 (find_row_edges): If the row ends in a newline from a display
293 string, increment its MATRIX_ROW_END_CHARPOS by one. (Bug#9549)
294 Handle the case of a display string with multiple newlines.
fd317ddf
EZ
295 (Fcurrent_bidi_paragraph_direction): Fix search for previous
296 non-empty line. Fixes confusing cursor motion with arrow keys at
297 the beginning of a line that starts with whitespace.
8c203dbf 298
a4824228
LMI
2992011-09-19 Lars Magne Ingebrigtsen <larsi@gnus.org>
300
301 * lread.c (Fread_from_string): Document what FINAL-STRING-INDEX is
302 (bug#9493).
303
33ed493b
CY
3042011-09-18 Chong Yidong <cyd@stupidchicken.com>
305
306 * xfns.c (Fx_create_frame): Handle the bitmapIcon resource as
307 boolean (Bug#9154).
308
56cd55c8
EZ
3092011-09-18 Eli Zaretskii <eliz@gnu.org>
310
311 * xdisp.c (display_line): Record maximum and minimum buffer
312 positions even if no glyphs were produced (e.g., by a zero-width
313 stretch). Fixes bug#9530 on a TTY. Under word-wrap, don't record
314 buffer positions that will be removed from the glyph row because
315 they don't fit.
c02dcedf
EZ
316 (produce_stretch_glyph): Fix a bug in :align-to on a TTY when the
317 column is beyond frame width: don't subtract 1 "pixel" when
318 computing width of the stretch.
3e62b7e0
EZ
319 (reseat_at_next_visible_line_start): Undo the change made on
320 2011-09-17 that saved paragraph information and restored it after
321 the call to `reseat'. (Bug#9545)
56cd55c8 322
5ed99d36 3232011-09-18 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
3390454c
YM
324
325 * xdisp.c (expose_window): Save original value of phys_cursor_on_p
326 and turn window cursor on if cleared (Bug#9415).
327
5ed99d36 3282011-09-18 Andreas Schwab <schwab@linux-m68k.org>
edb7b4dc
AS
329
330 * search.c (boyer_moore): Take unibyte characters from pattern
331 literally. (Bug#9458)
332
9bade7b2
EZ
3332011-09-18 Eli Zaretskii <eliz@gnu.org>
334
335 * xdisp.c (reseat_at_next_visible_line_start): Fix last change.
336
e5e9d610
PE
3372011-09-18 Paul Eggert <eggert@cs.ucla.edu>
338
87e4427a
PE
339 Fix minor problem found by static checking.
340 * xdisp.c (reseat_at_next_visible_line_start): Mark locals as
341 initialized, to pacify gcc -Wuninitialized.
342
e5e9d610
PE
343 * fileio.c: Report proper errno when syscall falls.
344 (Finsert_file_contents): Save and restore errno,
345 so that report_file_error outputs the correct diagnostic.
346 (Fwrite_region) [CLASH_DETECTION]: Likewise.
347
a1674f0b
EZ
3482011-09-18 Eli Zaretskii <eliz@gnu.org>
349
350 * .gdbinit (pgx): Fix references to fields of `struct glyph'.
351
fbfb6dd4
EZ
3522011-09-17 Eli Zaretskii <eliz@gnu.org>
353
354 * xdisp.c (produce_stretch_glyph): Another fix for changes made on
355 2011-08-30T17:32:44Z!eliz@gnu.org. (Bug#9530)
356
bb187662
EZ
3572011-09-17 Eli Zaretskii <eliz@gnu.org>
358
1137e8b8 359 * xdisp.c (reseat_at_next_visible_line_start): Keep information
6b02f655 360 about the current paragraph and restore it after the call to reseat.
1137e8b8
EZ
361
362 * bidi.c (MAX_PARAGRAPH_SEARCH): New macro.
363 (bidi_find_paragraph_start): Search back for paragraph beginning
364 at most MAX_PARAGRAPH_SEARCH lines; if not found, return BEGV_BYTE.
365 (bidi_move_to_visually_next): Only trigger paragraph-related
366 computations when the last character is a newline or at EOB, not
367 just any NEUTRAL_B. (Bug#9470)
368
bb187662
EZ
369 * xdisp.c (set_cursor_from_row): Don't invoke special treatment of
370 truncated lines if point is covered by a display string. (Bug#9524)
371
2e621251
PE
3722011-09-16 Paul Eggert <eggert@cs.ucla.edu>
373
374 * xselect.c: Relax test for outgoing X longs (Bug#9498).
375 (cons_to_x_long): New function.
376 (lisp_data_to_selection_data): Use it. Correct the test for
377 short-versus-long data; it was negated. Break out of vector
378 loop, for efficiency, when a long datum is discovered.
379
91a15bc6
SM
3802011-09-16 Stefan Monnier <monnier@iro.umontreal.ca>
381
382 * eval.c (Fquote): Document its non-consing behavior (bug#9482).
383
b41c3a35
EZ
3842011-09-16 Eli Zaretskii <eliz@gnu.org>
385
386 * image.c (tiff_handler): Work around a bug in MinGW GCC 3.x (see
387 GCC PR/17406) by declaring this function with external scope.
388
7812ba2d
PE
3892011-09-15 Paul Eggert <eggert@cs.ucla.edu>
390
391 * editfns.c (Fformat): Fix bug in text-property fix (Bug#9514).
392 Don't mishandle (length (format "%%")) and (format "%4000s%%" "").
393
cf7edc2a
AS
3942011-09-15 Andreas Schwab <schwab@linux-m68k.org>
395
396 * editfns.c (Fformat): Correctly handle text properties on "%%".
397
bd01620e
EZ
3982011-09-15 Eli Zaretskii <eliz@gnu.org>
399
400 * xterm.c (x_draw_composite_glyph_string_foreground):
401 * w32term.c (x_draw_composite_glyph_string_foreground):
402 * term.c (encode_terminal_code):
403 * composite.c (composition_update_it, get_composition_id):
404 * xdisp.c (get_next_display_element)
405 (fill_composite_glyph_string): Add comments about special meaning
406 of TAB characters in a composition.
407
a02719a3
PE
4082011-09-15 Paul Eggert <eggert@cs.ucla.edu>
409
410 * editfns.c (Fformat): Fix off-by-1 bug for "%%b" (Bug#9514).
4c122725
PE
411 This occurs when processing a multibyte format.
412 Problem reported by Wolfgang Jenker.
a02719a3 413
72589a3c
JB
4142011-09-15 Johan Bockgård <bojohan@gnu.org>
415
416 * xdisp.c (try_cursor_movement): Only check for exact match if
417 cursor hpos found by set_cursor_from_row is valid. (Bug#9495)
418
1c14176c
PE
4192011-09-14 Paul Eggert <eggert@cs.ucla.edu>
420
421 Remove unused external symbols.
422 * dispextern.h (calc_pixel_width_or_height): Remove decl.
423 * xdisp.c (calc_pixel_width_or_height): Now static.
424 * doprnt.c (exprintf) [! (HAVE_X_WINDOWS && USE_X_TOOLKIT)]: Remove.
425 * indent.c (check_display_width):
426 * w32term.c: Fix comment to match code.
427 * xterm.c, xterm.h (x_catching_errors): Remove.
428
d2eea5b5
PE
4292011-09-14 Paul Eggert <eggert@cs.ucla.edu>
430
431 * xselect.c: Use signed conversions more consistently (Bug#9498).
432 (selection_data_to_lisp_data): Assume incoming selection data are
433 signed integers, not unsigned. This is to be consistent with
434 outgoing selection data, which was modified to use signed integers
435 in as part of the fix to Bug#9196 in response to Jan D.'s comment
436 in <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=9196#32> that X11
437 expects long, not unsigned long.
438
46888499
EZ
4392011-09-14 Eli Zaretskii <eliz@gnu.org>
440
441 * xdisp.c (try_window_reusing_current_matrix): Fix incorrect
442 computation of loop end. Reported by Johan Bockgård
443 <bojohan@gnu.org>.
444
ef8ef9fb
CY
4452011-09-13 Chong Yidong <cyd@stupidchicken.com>
446
447 * frame.c (Fother_visible_frames_p): Function deleted.
448
fa819fed
EZ
4492011-09-12 Eli Zaretskii <eliz@gnu.org>
450
451 * indent.c (compute_motion): Process display vector front to back
452 rather than the other way around. (Bug#2496)
453
2ba8e008
SM
4542011-09-12 Stefan Monnier <monnier@iro.umontreal.ca>
455
456 * fileio.c (Finsert_file_contents): Don't assume beg_offset is 0.
457
20f53c69
CY
4582011-09-11 Chong Yidong <cyd@stupidchicken.com>
459
460 * minibuf.c (Fread_from_minibuffer): Doc fix.
461
d562d7a4
EZ
4622011-09-11 Eli Zaretskii <eliz@gnu.org>
463
464 * xdisp.c (produce_stretch_glyph): Fix a typo made in changes from
465 2011-08-30T17:32:44Z!eliz@gnu.org. (Bug#9475)
466
1c4d7f3d
LMI
4672011-09-11 Lars Magne Ingebrigtsen <larsi@gnus.org>
468
469 * fileio.c (Fvisited_file_modtime): Document `(-1 65535)' as a
470 value for non-existent files.
471
b885bf36
EZ
4722011-09-11 Eli Zaretskii <eliz@gnu.org>
473
474 * fileio.c (Finsert_file_contents): If the file cannot be opened,
475 set its "size" to -1. This will set the modtime_size field of
476 the corresponding buffer to -1, which is what
477 verify-visited-file-modtime expects for files that do not exist.
478 (Bug#9139)
479
6612f0bf
PE
4802011-09-11 Paul Eggert <eggert@cs.ucla.edu>
481
482 * keymap.h (KEY_DESCRIPTION_SIZE, push_key_description): Move decls
483 here ...
484 * lisp.h: ... from here. push_key_description is no longer
485 defined in keyboard.c, so its declaration should not be in
486 lisp.h's "Defined in keyboard.c" section, and KEY_DESCRIPTION_SIZE
487 logically belongs with push_key_description.
488
dfb3f755
PE
4892011-09-10 Paul Eggert <eggert@cs.ucla.edu>
490
491 * buffer.h: Include <sys/types.h> instead of <time.h>.
492 Otherwise, off_t wasn't defined on FreeBSD 9.0-BETA2 i386.
493 Problem reported by Herbert J. Skuhra.
494
3134906c
LMI
4952011-09-10 Lars Magne Ingebrigtsen <larsi@gnus.org>
496
497 * xml.c (parse_region): Make the parsing work for
498 non-comment-starting XML files again (bug#9144).
499
8d903f4e
AS
5002011-09-10 Andreas Schwab <schwab@linux-m68k.org>
501
502 * image.c (gif_load): Fix calculation of bottom and right corner.
503 (Bug#9468)
504
80ad64f4
EZ
5052011-09-10 Eli Zaretskii <eliz@gnu.org>
506
507 * xdisp.c (MAX_DISP_SCAN): Decrease to 250. Prevents sluggish
508 redisplay in small windows.
509
208a048d
EZ
5102011-09-09 Eli Zaretskii <eliz@gnu.org>
511
512 * frame.c (x_report_frame_params): Cast to avoid compiler warnings.
513
9b1c252e
MR
5142011-09-08 Martin Rudalics <rudalics@gmx.at>
515
516 * window.c (Fset_window_prev_buffers, Fset_window_next_buffers):
517 Operate on live windows only.
518
2949f33b
JB
5192011-09-08 Juanma Barranquero <lekktu@gmail.com>
520
521 * emacs.c (my_heap_start): #ifdef to avoid warnings when unused.
522
e08dcafd
EZ
5232011-09-07 Eli Zaretskii <eliz@gnu.org>
524
525 * xdisp.c (move_it_in_display_line_to): Call RESTORE_IT on ppos_it
526 only under bidi iteration.
527
115b96bd
JD
5282011-09-07 Jan Djärv <jan.h.d@swipnet.se>
529
530 * gtkutil.c (xg_make_tool_item): Insert comment about eventbox.
531
c8199d0f
PE
5322011-09-06 Paul Eggert <eggert@cs.ucla.edu>
533
534 isnan: Fix porting problem to Solaris 10 with bundled gcc.
535 Without this fix, the command to link temacs failed due to an
536 undefined symbol __builtin_isnan. This is because
537 /usr/include/iso/math_c99.h #defines isnan(x) to
538 __builtin_isnan(x), but the bundled gcc, which identifies itself
539 as gcc 3.4.3 (csl-sol210-3_4-branch+sol_rpath), does not have
540 a __builtin_isnan.
541 * floatfns.c (isnan): #undef, and then #define to a clone of
542 what's in data.c.
543 (Fisnan): Always define, since it's always available now.
544 (syms_of_floatfns): Always define isnan at the Lisp level.
545
e39b275c 5462011-09-06 Paul Eggert <eggert@cs.ucla.edu>
1c262cae
PE
547
548 * Makefile.in (gl-stamp): move-if-change now in build-aux (Bug#9169).
549
b2db44d9 5502011-09-06 Paul Eggert <eggert@cs.ucla.edu>
728f8f0a 551
f4af5137 552 * fileio.c: Fix bugs with large file offsets (Bug#9428).
728f8f0a
PE
553 The previous code assumed that file offsets (off_t values) fit in
554 EMACS_INT variables, which is not true on typical 32-bit hosts.
555 The code messed up by falsely reporting buffer overflow in cases
556 such as (insert-file-contents "big" nil 1 2) into an empty buffer
557 when "big" contains more than 2**29 bytes, even though this
558 inserts just one byte and does not overflow the buffer.
559 (Finsert_file_contents): Store file offsets as off_t
560 values, not as EMACS_INT values. Check for overflow when
561 converting between EMACS_INT and off_t. When checking for
562 buffer overflow or for overlap, take the offsets into account.
563 Don't use EMACS_INT for small values where int suffices.
564 When checking for overlap, fix a typo: ZV was used where
565 ZV_BYTE was intended.
566 (Fwrite_region): Don't assume off_t fits into 'long'.
567 * buffer.h (struct buffer.modtime_size): Now off_t, not EMACS_INT.
568
ecfc0a49
MA
5692011-09-05 Michael Albinus <michael.albinus@gmx.de>
570
571 * dbusbind.c (xd_signature_cat): Rename from signature_cat.
572
6511acf2 5732011-09-04 Paul Eggert <eggert@cs.ucla.edu>
61bfeeb7 574
0999621a 575 sprintf-related integer and memory overflow issues (Bug#9412).
62f19c19
PE
576
577 * doprnt.c (doprnt): Support printing ptrdiff_t and intmax_t values.
8666506e 578 (esprintf, exprintf, evxprintf): New functions.
62f19c19 579 * keyboard.c (command_loop_level): Now EMACS_INT, not int.
6b02f655 580 (cmd_error): Kbd macro iterations count is now EMACS_INT, not int.
62f19c19
PE
581 (modify_event_symbol): Do not assume that the length of
582 name_alist_or_stem is safe to alloca and fits in int.
583 (Fexecute_extended_command): Likewise for function name and binding.
584 (Frecursion_depth): Wrap around reliably on integer overflow.
585 * keymap.c (push_key_description): First arg is now EMACS_INT, not int,
586 since some callers pass EMACS_INT values.
587 (Fsingle_key_description): Don't crash if symbol name contains more
588 than MAX_ALLOCA bytes.
589 * minibuf.c (minibuf_level): Now EMACS_INT, not int.
590 (get_minibuffer): Arg is now EMACS_INT, not int.
591 * lisp.h (get_minibuffer, push_key_description): Reflect API changes.
8666506e 592 (esprintf, exprintf, evxprintf): New decls.
62f19c19
PE
593 * window.h (command_loop_level, minibuf_level): Reflect API changes.
594
2be7d702
PE
595 * dbusbind.c (signature_cat): New function.
596 (xd_signature, Fdbus_register_signal):
2ea16b89
PE
597 Do not overrun buffer; instead, report string overflow.
598
9d1df220
PE
599 * dispnew.c (add_window_display_history): Don't overrun buffer.
600 Truncate instead; this is OK since it's just a log.
601
33ef5c64
PE
602 * editfns.c (Fcurrent_time_zone): Don't overrun buffer
603 even if the time zone offset is outlandishly large.
604 Don't mishandle offset == INT_MIN.
605
66c6fdd5
PE
606 * emacs.c (main) [NS_IMPL_COCOA]: Don't overrun buffer
607 when creating daemon; the previous buffer-overflow check was incorrect.
608
d749b01b
PE
609 * eval.c (verror): Simplify by rewriting in terms of evxprintf,
610 which has the guts of the old verror function.
611
b5cd1905
PE
612 * filelock.c (lock_file_1, lock_file): Don't blindly alloca long name;
613 use SAFE_ALLOCA instead. Use esprintf to avoid int-overflow issues.
614
6e1a67fb
PE
615 * font.c: Include <float.h>, for DBL_MAX_10_EXP.
616 (font_unparse_xlfd): Don't blindly alloca long strings.
c21721cc 617 Don't assume XINT result fits in int, or that XFLOAT_DATA * 10
8666506e 618 fits in int, when using sprintf. Use single snprintf to count
c21721cc
PE
619 length of string rather than counting it via multiple sprintfs;
620 that's simpler and more reliable.
c21721cc
PE
621 (font_unparse_fcname): Use it to avoid sprintf buffer overrun.
622 (generate_otf_features) [0 && HAVE_LIBOTF]: Use esprintf, not
623 sprintf, in case result does not fit in int.
624
c57b67fc
PE
625 * fontset.c (num_auto_fontsets): Now printmax_t, not int.
626 (fontset_from_font): Print it.
627
8a401434
PE
628 * frame.c (tty_frame_count): Now printmax_t, not int.
629 (make_terminal_frame, set_term_frame_name): Print it.
630 (x_report_frame_params): In X, window IDs are unsigned long,
631 not signed long, so print them as unsigned.
632 (validate_x_resource_name): Check for implausibly long names,
633 and don't assume name length fits in 'int'.
634 (x_get_resource_string): Don't blindly alloca invocation name;
635 use SAFE_ALLOCA. Use esprintf, not sprintf, in case result does
636 not fit in int.
637
6e1a67fb
PE
638 * gtkutil.c: Include <float.h>, for DBL_MAX_10_EXP.
639 (xg_check_special_colors, xg_set_geometry):
84722b3d
PE
640 Make sprintf buffers a bit bigger, to avoid potential buffer overrun.
641
0df02bf3
PE
642 * lread.c (dir_warning): Don't blindly alloca buffer; use SAFE_ALLOCA.
643 Use esprintf, not sprintf, in case result does not fit in int.
644
48e30793
PE
645 * macros.c (executing_kbd_macro_iterations): Now EMACS_INT, not int.
646 (Fend_kbd_macro): Don't mishandle MOST_NEGATIVE_FIXNUM by treating
647 it as a large positive number.
648 (Fexecute_kbd_macro): Don't assume repeat count fits in int.
649 * macros.h (executing_kbd_macro_iterations): Now EMACS_INT, not int.
650
a66ff6d8
PE
651 * nsterm.m ((NSSize)windowWillResize): Use esprintf, not sprintf,
652 in case result does not fit in int.
653
aca216ff
PE
654 * print.c (float_to_string): Detect width overflow more reliably.
655 (print_object): Make sprintf buffer a bit bigger, to avoid potential
656 buffer overrun. Don't assume list length fits in 'int'. Treat
657 print length of 0 as 0, not as infinity; to be consistent with other
658 uses of print length in this function. Don't overflow print length
659 index. Don't assume hash table size fits in 'long', or that
660 vectorlike size fits in 'unsigned long'.
661
31c286f7
PE
662 * process.c (make_process): Use printmax_t, not int, to format
663 process-name gensyms.
664
55e5faa1
PE
665 * sysdep.c (snprintf) [! HAVE_SNPRINTF]: New function.
666
80f2e268
PE
667 * term.c (produce_glyphless_glyph): Make sprintf buffer a bit bigger
668 to avoid potential buffer overrun.
669
670741ab
PE
670 * xfaces.c (x_update_menu_appearance): Don't overrun buffer
671 if X resource line is longer than 512 bytes.
672
b7163a50
PE
673 * xfns.c (x_window): Make sprintf buffer a bit bigger
674 to avoid potential buffer overrun.
675
ae58ff1f
PE
676 * xterm.c (x_io_error_quitter): Don't overrun sprintf buffer.
677
c43c8a6a
PE
678 * xterm.h (x_check_errors): Add ATTRIBUTE_FORMAT_PRINTF.
679
3f8236f4
PE
6802011-09-04 Paul Eggert <eggert@cs.ucla.edu>
681
53e9fe90 682 Integer overflow fixes for scrolling, etc.
6511acf2
PE
683 Without these, Emacs silently mishandles large integers sometimes.
684 For example, "C-u 4294967297 M-x recenter" was treated as if
53e9fe90
PE
685 it were "C-u 1 M-x recenter" on a typical 64-bit host.
686
6511acf2
PE
687 * xdisp.c (try_window_id): Check Emacs fixnum range before
688 converting to 'int'.
806add1d 689
6511acf2 690 * window.c (window_scroll_line_based, Frecenter):
71f02bc5
PE
691 Check that an Emacs fixnum is in range before assigning it to 'int'.
692 (Frecenter, Fmove_to_window_line): Use EMACS_INT, not int, for
693 values converted from Emacs fixnums.
694 (Frecenter): Don't wrap around a line count if it is out of 'int'
695 range; instead, treat it as an extreme value.
696 (Fset_window_configuration, compare_window_configurations):
697 Use ptrdiff_t, not int, for index that might exceed 2 GiB.
698
6511acf2
PE
699 * search.c (Freplace_match): Use ptrdiff_t, not int, for indexes
700 that can exceed INT_MAX. Check that EMACS_INT value is in range
701 before assigning it to the (possibly-narrower) index.
a0efffc8
PE
702 (match_limit): Don't assume that a fixnum can fit in 'int'.
703
6511acf2 704 * print.c (print_object): Use ptrdiff_t, not int, for index that can
29ebea3b
PE
705 exceed INT_MAX.
706
6511acf2 707 * indent.c (position_indentation): Now takes ptrdiff_t, not int.
3f8236f4
PE
708 (Fvertical_motion): Don't wrap around LINES values that don't fit
709 in 'int'. Instead, treat them as extreme values. This is good
710 enough for windows, which can't have more than INT_MAX lines anyway.
711
fcb901a7
LMI
7122011-09-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
713
0f2f6b6d
LMI
714 * Require libxml/parser.h to avoid compilation warning.
715
fcb901a7
LMI
716 * emacs.c (shut_down_emacs): Call xmlCleanupParser on shutdown.
717
718 * xml.c (parse_region): Don't call xmlCleanupParser after parsing,
719 since this reportedly can destroy thread storage.
720
6e20a0d4
CY
7212011-08-30 Chong Yidong <cyd@stupidchicken.com>
722
723 * syntax.c (find_defun_start): Update all cache variables if
724 exiting early (Bug#9401).
725
148ae00e
EZ
7262011-08-30 Eli Zaretskii <eliz@gnu.org>
727
f6cfbd8f
EZ
728 * image.c (x_bitmap_pixmap): Cast to int to avoid compiler warnings.
729
148ae00e
EZ
730 * xdisp.c (produce_stretch_glyph): No longer static, compiled also
731 when HAVE_WINDOW_SYSTEM is not defined. Support both GUI and TTY
732 frames. Call tty_append_glyph in the TTY case. (Bug#9402)
733
734 * term.c (tty_append_glyph): New function.
735 (produce_stretch_glyph): Static function and its prototype deleted.
736
a66cfb1c
SM
737 * dispextern.h (produce_stretch_glyph, tty_append_glyph):
738 Add prototypes.
148ae00e 739
c4a07a4c
PE
7402011-08-29 Paul Eggert <eggert@cs.ucla.edu>
741
742 * image.c (parse_image_spec): Check for nonnegative, not for positive,
743 when checking :margin (Bug#9390).
744 (IMAGE_NON_NEGATIVE_INTEGER_VALUE_OR_PAIR):
a66cfb1c 745 Rename from IMAGE_POSITIVE_INTEGER_VALUE_OR_PAIR,
c4a07a4c
PE
746 so that the name doesn't mislead. All uses changed.
747
6bc8cd65
JB
7482011-08-28 Johan Bockgård <bojohan@gnu.org>
749
750 * term.c (init_tty) [HAVE_GPM]: Move mouse settings after
751 set_tty_hooks.
752
dca4927e
EZ
7532011-08-27 Eli Zaretskii <eliz@gnu.org>
754
755 * xdisp.c (move_it_to): Don't bail out early when reaching
756 position beyond to_charpos, if we are scanning backwards.
757 (move_it_vertically_backward): When DY == 0, make sure we get to
758 the first character in the line after the newline.
759
f2cad773
PE
7602011-08-27 Paul Eggert <eggert@cs.ucla.edu>
761
762 * ccl.c: Improve and simplify overflow checking (Bug#9196).
763 (ccl_driver): Do not generate an out-of-range pointer.
764 (Fccl_execute_on_string): Remove unnecessary check for
765 integer overflow, noted by Stefan Monnier in
766 <http://lists.gnu.org/archive/html/emacs-devel/2011-08/msg00979.html>.
767 Remove a FIXME that didn't need fixing.
768 Simplify the newly-introduced buffer reallocation code.
769
0cae2cdb
JB
7702011-08-27 Juanma Barranquero <lekktu@gmail.com>
771
772 * makefile.w32-in ($(BLD)/alloc.$(O)): Depend on lib/verify.h.
773
5fc295a4 7742011-08-26 Paul Eggert <eggert@cs.ucla.edu>
ddff3151 775
70c60eb2 776 Integer and memory overflow issues (Bug#9196).
726e0ab1 777
d31850da
PE
778 * doc.c (get_doc_string): Rework so that
779 get_doc_string_buffer_size is the actual buffer size, rather than
780 being 1 less than the actual buffer size; this makes xpalloc more
781 convenient.
782
a69fbedb
PE
783 * image.c (x_allocate_bitmap_record, cache_image):
784 * xselect.c (Fx_register_dnd_atom):
785 Simplify previous changes by using xpalloc.
786
fe5c5d37
PE
787 * buffer.c (overlay_str_len): Now ptrdiff_t, not EMACS_INT,
788 since either will do and ptrdiff_t is convenient with xpalloc.
789
0065d054
PE
790 * charset.c (charset_table_size)
791 (struct charset_sort_data.priority): Now ptrdiff_t.
792 (charset_compare): Don't overflow if priorities differ greatly.
793 (Fsort_charsets): Don't assume list length fits in int.
794 Check for size-calculation overflow when allocating sort data.
795 (syms_of_charset): Allocate an initial charset table that is
796 just under 64 KiB, to avoid problems with glibc malloc and mmap.
797
798 * cmds.c (internal_self_insert): Check for size-calculation overflow.
799
800 * composite.h (struct composition.glyph_len): Now int, not unsigned.
801 The actual value is always <= INT_MAX, and leaving it unsigned made
802 overflow checking harder.
803
804 * dispextern.h (struct glyph_matrix.rows_allocated)
805 (struct face_cache.size): Now ptrdiff_t, for convenience in use
806 with xpalloc. The values are still always <= INT_MAX.
807
808 * indent.c (compute_motion): Adjust to region_cache_forward sig change.
809
810 * lisp.h (xnmalloc, xnrealloc, xpalloc): New decls.
811 (SAFE_NALLOCA): New macro.
812
813 * region-cache.c (struct boundary.pos, find_cache_boundary)
814 (move_cache_gap, insert_cache_boundary, delete_cache_boundaries)
815 (set_cache_region, invalidate_region_cache)
816 (revalidate_region_cache, know_region_cache, region_cache_forward)
817 (region_cache_backward, pp_cache):
818 Use ptrdiff_t, not EMACS_INT, since either will do. This is needed
819 so that ptrdiff_t * can be passed to xpalloc.
820 (struct region_cache): Similarly, for gap_start, gap_len, cache_len,
821 beg_unchanged, end_unchanged, buffer_beg, buffer_end members.
822 (pp_cache): Don't assume cache_len fits in int.
823 * region-cache.h: Adjust extern decls to match.
824
825 * search.c (scan_buffer, Freplace_match): Use ptrdiff_t, not
826 EMACS_INT, since either will do, for xpalloc.
827
828 * alloc.c: Include verify.h, and check that int fits in ptrdiff_t.
829 (xnmalloc, xnrealloc, xpalloc): New functions.
830
726e0ab1
PE
831 * bidi.c (bidi_shelve_header_size): New constant.
832 (bidi_cache_ensure_space, bidi_shelve_cache): Use it.
833 (bidi_cache_ensure_space): Avoid integer overflow when allocating.
834
51f30bc5 835 * bidi.c (bidi_cache_shrink):
726e0ab1
PE
836 * buffer.c (overlays_at, overlays_in, record_overlay_string)
837 (overlay_strings):
838 Don't update size of array until after memory allocation succeeds,
839 because xmalloc/xrealloc may not return.
0065d054
PE
840 (struct sortstrlist.bytes): Now ptrdiff_t, as EMACS_INT doesn't help
841 now that we have proper integer overflow checking.
842 (record_overlay_string, overlay_strings): Catch overflows when
843 calculating size of overlay_str_buf.
726e0ab1 844
0065d054
PE
845 * callproc.c (Fcall_process): Check for size overflow when
846 calculating size of args2.
847 (child_setup): Avoid overflow by using size_t rather than ptrdiff_t.
848 Normally we prefer signed values, but sticking with ptrdiff_t would
849 require adding more-complicated checks.
726e0ab1
PE
850
851 * ccl.c (Fccl_execute_on_string): Check for memory overflow.
852 Use ptrdiff_t rather than EMACS_INT where ptrdiff_t will do.
853 Redo buffer-overflow calculations to avoid integer overflow.
0065d054 854 Add a FIXME comment where memory seems to be over-allocated.
726e0ab1
PE
855
856 * character.c (Fstring): Check for size-calculation overflow.
857
858 * coding.c (produce_chars): Redo buffer-overflow calculations to avoid
859 unnecessary integer overflow. Check for size overflow.
860 (encode_coding_object): Don't update size until xmalloc succeeds.
861
862 * composite.c (get_composition_id): Check for overflow in glyph
863 length calculations.
864
865 Integer and memory overflow fixes for display code.
866 * dispextern.h (struct glyph_pool.nglyphs): Now ptrdiff_t, not int.
867 * dispnew.c (adjust_glyph_matrix, realloc_glyph_pool)
868 (scrolling_window): Check for overflow in size calculations.
869 (line_draw_cost, realloc_glyph_pool, add_row_entry):
870 Don't assume glyph table len fits in int.
871 (struct row_entry.bucket, row_entry_pool_size, row_entry_idx)
872 (row_table_size): Now ptrdiff_t, not int.
873 (scrolling_window): Avoid overflow in size calculations.
874 Don't update size until allocation succeeds.
875 * fns.c (concat): Check for overflow in size calculations.
876 (next_almost_prime): Verify NEXT_ALMOST_PRIME_LIMIT.
877 * lisp.h (RANGED_INTEGERP, TYPE_RANGED_INTEGERP): New macros.
878 (NEXT_ALMOST_PRIME_LIMIT): New constant.
879
880 * doc.c (get_doc_string_buffer_size): Now ptrdiff_t, not int.
881 (get_doc_string): Check for size calculation overflow.
882 Don't update size until allocation succeeds.
883 (get_doc_string, Fsubstitute_command_keys): Use ptrdiff_t, not
884 EMACS_INT, where ptrdiff_t will do.
885 (Fsubstitute_command_keys): Check for string overflow.
886
887 * editfns.c (set_time_zone_rule): Don't assume environment length
888 fits in int.
889 (message_length): Now ptrdiff_t, not int.
890 (Fmessage_box): Don't update size until allocation succeeds.
891 Don't assume message length fits in int.
892 (Fformat): Use ptrdiff_t, not EMACS_INT, where ptrdiff_t will do.
893
0065d054
PE
894 * emacs.c (main): Do not reallocate argv, since there is a null at
895 the end that can be overwritten, and this way there's no need to
896 worry about size-calculation overflow.
897 (sort_args): Check for size-calculation overflow.
726e0ab1
PE
898
899 * eval.c (init_eval_once, grow_specpdl): Don't update size until
900 alloc succeeds.
901 (call_debugger, grow_specpdl): Redo calculations to avoid overflow.
902
903 * frame.c (set_menu_bar_lines, x_set_frame_parameters)
904 (x_set_scroll_bar_width, x_figure_window_size):
905 Check for integer overflow.
906 (x_set_alpha): Do not assume XINT fits in int.
907
908 * frame.h (struct frame): Use int, not EMACS_INT, where int works.
909 This is for the members text_lines, text_cols, total_lines, total_cols,
910 where the system imposes an 'int' limit.
911
912 * fringe.c (Fdefine_fringe_bitmap):
913 Don't update size until alloc works.
914
915 * ftfont.c (ftfont_get_open_type_spec, setup_otf_gstring)
916 (ftfont_shape_by_flt): Check for integer overflow in size calculations.
917
918 * gtkutil.c (get_utf8_string, xg_store_widget_in_map):
919 Check for size-calculation overflow.
920 (get_utf8_string): Use ptrdiff_t, not size_t, where either will
921 do, as we prefer signed integers.
922 (id_to_widget.max_size, id_to_widget.used)
923 (xg_store_widget_in_map, xg_remove_widget_from_map)
924 (xg_get_widget_from_map, xg_get_scroll_id_for_window)
925 (xg_remove_scroll_bar, xg_update_scrollbar_pos):
926 Use and return ptrdiff_t, not int.
927 (xg_gtk_scroll_destroy): Don't assume ptrdiff_t fits in int.
928 * gtkutil.h: Change prototypes to match the above.
929
930 * image.c (RANGED_INTEGERP, TYPE_RANGED_INTEGERP): Remove; these
931 are duplicate now that they've been promoted to lisp.h.
932 (x_allocate_bitmap_record, x_alloc_image_color)
933 (make_image_cache, cache_image, xpm_load):
934 Don't update size until alloc is done.
935 (xpm_load, lookup_rgb_color, lookup_pixel_color, x_to_xcolors)
936 (x_detect_edges):
3256efce 937 Check for size calculation overflow.
726e0ab1
PE
938 (ct_colors_allocated_max): New constant.
939 (x_to_xcolors, x_detect_edges): Reorder multiplicands to avoid
940 overflow.
3256efce 941
726e0ab1
PE
942 * keyboard.c (read_char, menu_bar_items, tool_bar_items)
943 (read_char_x_menu_prompt, read_char_minibuf_menu_width)
944 (read_char_minibuf_menu_prompt, follow_key, read_key_sequence):
945 Use ptrdiff_t, not int, to count maps.
946 (read_char_minibuf_menu_prompt): Check for overflow in size
a66cfb1c
SM
947 calculations. Don't update size until allocation succeeds.
948 Redo calculations to avoid overflow.
726e0ab1
PE
949 * keyboard.h: Change prototypes to match the above.
950
951 * keymap.c (cmm_size, current_minor_maps): Use ptrdiff_t, not int,
952 to count maps.
953 (current_minor_maps): Check for size calculation overflow.
954 * keymap.h: Change prototypes to match the above.
955
956 * lread.c (read1, init_obarray): Don't update size until alloc done.
957
958 * macros.c (Fstart_kbd_macro): Don't update size until alloc done.
959 (store_kbd_macro_char): Reorder multiplicands to avoid overflow.
960
726e0ab1
PE
961 * nsterm.h (struct ns_color_table.size, struct ns_color_table.avail):
962 Now ptrdiff_t, not int.
963 * nsterm.m (ns_index_color): Use ptrdiff_t, not int, for table indexes.
964 (ns_draw_fringe_bitmap): Rewrite to avoid overflow.
965
966 * process.c (Fnetwork_interface_list): Check for overflow
967 in size calculation.
968
969 * region-cache.c (move_cache_gap): Check for size calculation overflow.
970
971 * scroll.c (do_line_insertion_deletion_costs): Check for size calc
972 overflow. Don't bother calling xmalloc when xrealloc will do.
973
974 * search.c (Freplace_match): Check for size calculation overflow.
975 (Fset_match_data): Don't assume list lengths fit in 'int'.
976
977 * sysdep.c (system_process_attributes): Use ptrdiff_t, not int,
978 for command line length. Do not attempt to address one before the
979 beginning of an array, as that's not portable.
980
981 * term.c (max_frame_lines): Remove; unused.
982 (encode_terminal_src_size, encode_terminal_dst_size): Now ptrdiff_t,
983 not int.
984 (encode_terminal_code, calculate_costs): Check for size
985 calculation overflow.
986 (encode_terminal_code): Use ptrdiff_t, not int, to record glyph
987 table lengths and related sizes. Don't update size until alloc
988 done. Redo calculations to avoid overflow.
989 (calculate_costs): Don't bother calling xmalloc when xrealloc will do.
990
991 * termcap.c (tgetent): Use ptrdiff_t, not int, to record results of
992 subtracting pointers.
993 (gobble_line): Check for overflow more carefully. Don't update size
994 until alloc done.
995
996 * tparam.c (tparam1): Use ptrdiff_t, not int, for sizes.
997 Don't update size until alloc done.
998 Redo size calculations to avoid overflow.
999 Check for size calculation overflow.
0065d054 1000 (main) [DEBUG]: Fix typo in invoking tparam1.
726e0ab1
PE
1001
1002 * xdisp.c (store_mode_line_noprop_char, x_consider_frame_title):
1003 Use ptrdiff_t, not int, for sizes.
1004 (store_mode_line_noprop_char): Don't update size until alloc done.
1005
0065d054
PE
1006 * xfaces.c (lface_id_to_name_size, Finternal_make_lisp_face):
1007 Use ptrdiff_t, not int, for sizes.
1008 (Finternal_make_lisp_face, cache_face):
1009 Check for size calculation overflow.
1010 (cache_face): Treat size calculation overflows as if they were
1011 memory exhaustion (the usual treatment), rather than aborting.
726e0ab1
PE
1012
1013 * xfns.c (x_encode_text, x_set_name_internal)
1014 (Fx_change_window_property): Use ptrdiff_t, not int, to count
1015 sizes, since they can exceed INT_MAX in size. Check for size
1016 calculation overflow.
1017
0065d054
PE
1018 * xgselect.c (gfds_size): Now ptrdiff_t, for convenience with xpalloc.
1019 (xg_select): Check for size calculation overflow.
726e0ab1
PE
1020 Don't update size until alloc done.
1021
0065d054 1022 * xrdb.c (get_environ_db): Don't assume path length fits in int,
726e0ab1 1023 as sprintf is limited to int lengths.
1d526e2f 1024
252c5ee1
PE
1025 * xselect.c (X_LONG_SIZE, X_SHRT_MAX, X_SHRT_MIN, X_LONG_MAX)
1026 (X_LONG_MIN): New macros.
864d7ce7
PE
1027 Use them to make the following changes clearer.
1028 (MAX_SELECTION_QUANTUM): Make the other bounds on this value clearer.
1029 This change doesn't affect the value now, but it may help remind
1030 future maintainers not to raise the value too much later.
1031 (SELECTION_QUANTUM): Remove, replacing with ...
1032 (selection_quantum): ... new function, which avoids overflow.
1033 All uses changed.
1034 (struct selection_data.size): Now ptrdiff_t, not int, to avoid
1035 assumption that selection length fits in 'int'.
1036 (x_reply_selection_request, x_handle_selection_request)
1037 (x_get_window_property, receive_incremental_selection)
1038 (x_get_window_property_as_lisp_data, selection_data_to_lisp_data)
1039 (lisp_data_to_selection_data, clean_local_selection_data):
1040 Use ptrdiff_t, not int, to record length of selection.
1041 (x_reply_selection_request, x_get_window_property)
1042 (receive_incremental_selection, x_property_data_to_lisp):
1043 Redo calculations to avoid overflow.
1044 (x_reply_selection_request): When sending hint, ceiling it at
252c5ee1 1045 X_LONG_MAX rather than relying on wraparound overflow to send
864d7ce7
PE
1046 something.
1047 (x_get_window_property, receive_incremental_selection)
1048 (lisp_data_to_selection_data, x_property_data_to_lisp):
1049 Check for size-calculation overflow.
1050 (x_get_window_property, receive_incremental_selection)
1051 (lisp_data_to_selection_data, Fx_register_dnd_atom):
1052 Don't store size until memory allocation succeeds.
1053 (x_get_window_property): Plug memory leak on memory exhaustion.
1054 Don't double-block input; malloc is safe here. Don't assume 2**34
1055 - 4 fits in unsigned long. Add an xassert to check
1056 XGetWindowProperty overflow. Be more careful about overflow
1057 calculations, and distinguish size from memory overflow better.
1058 (receive_incremental_selection): When tracing, don't assume
1059 unsigned int is less than INT_MAX.
1060 (x_selection_data_to_lisp_data): Remove unnecessary (and in theory
1061 harmful) conversions of unsigned short to int.
1062 (lisp_data_to_selection_data): Don't assume that integers
1063 in the range -65535 through -1 fit in an X unsigned short.
1064 Don't assume that ULONG_MAX == X_ULONG_MAX. Don't store into
1065 result parameters unless successful. Rely on cons_to_unsigned
1066 to report problems with elements; the old code wasn't right anyway.
1067 (x_check_property_data): Check for int overflow; we cannot use
1068 a wider type due to X limits.
1069 (x_handle_dnd_message): Use unsigned int, to avoid int overflow.
1070
726e0ab1 1071 * xsmfns.c (smc_save_yourself_CB): Check for size calc overflow.
34db673b 1072
0065d054
PE
1073 * xterm.c (x_color_cells, x_send_scrollbar_event, handle_one_xevent)
1074 (x_term_init): Check for size calculation overflow.
726e0ab1
PE
1075 (x_color_cells): Don't store size until memory allocation succeeds.
1076 (handle_one_xevent): Use ptrdiff_t, not int, for byte counts.
0065d054 1077 Don't assume alloca size is less than MAX_ALLOCA.
726e0ab1
PE
1078 (x_term_init): Don't assume length fits in int (sprintf is limited
1079 to int size).
bc18e09d 1080
ebfa62c0
PE
1081 Use ptrdiff_t for composition IDs.
1082 * character.c (lisp_string_width):
1083 * composite.c (composition_table_size, n_compositions)
1084 (get_composition_id, composition_gstring_from_id):
1085 * dispextern.h (struct glyph_string.cmp_id, struct composition_it.id):
1086 * xdisp.c (BUILD_COMPOSITE_GLYPH_STRING):
1087 * window.c (Frecenter):
1088 Use ptrdiff_t, not int, for composition IDs.
1089 * composite.c (get_composition_id): Check for integer overflow.
1090 * composite.h: Adjust prototypes to match the above changes.
1091
d3411f89
PE
1092 Use ptrdiff_t for hash table indexes.
1093 * category.c (hash_get_category_set):
1094 * ccl.c (ccl_driver):
1095 * charset.h (struct charset.hash_index, CHECK_CHARSET_GET_ID):
1096 * coding.c (coding_system_charset_list, detect_coding_system):
1097 * coding.h (struct coding_system.id):
1098 * composite.c (get_composition_id, gstring_lookup_cache):
1099 * fns.c (hash_lookup, hash_put, Fgethash, Fputhash):
1100 * image.c (xpm_get_color_table_h):
1101 * lisp.h (hash_lookup, hash_put):
1102 * minibuf.c (Ftest_completion):
1103 Use ptrdiff_t for hash table indexes, not int (which is too
1104 narrow, on 64-bit hosts) or EMACS_INT (which is too wide, on
1105 32-bit --with-wide-int hosts).
1106
e097a6fa
PE
1107 * charset.c (Fdefine_charset_internal): Check for integer overflow.
1108 Add a FIXME comment about memory leaks.
1109 (syms_of_charset): Don't assume xmalloc returns.
1110
5637687f
PE
1111 Don't assume that stated character widths fit in int.
1112 * character.c (Fchar_width, c_string_width, lisp_string_width):
1113 * character.h (CHAR_WIDTH):
1114 * indent.c (MULTIBYTE_BYTES_WIDTH):
1115 Use sanitize_char_width to avoid undefined and/or bad behavior
1116 with outlandish widths.
a66cfb1c 1117 * character.h (sanitize_tab_width): Rename from sanitize_width,
5637687f
PE
1118 now that we have two such functions. All uses changed.
1119 (sanitize_char_width): New inline function.
1120
a2271ba2
PE
1121 Don't assume that tab-width fits in int.
1122 * character.h (sanitize_width): New inline function.
1123 (SANE_TAB_WIDTH): New macro.
1124 (ASCII_CHAR_WIDTH): Use it.
1125 * indent.c (sane_tab_width): Remove. All uses replaced by
1126 SANE_TAB_WIDTH (current_buffer).
1127 * xdisp.c (init_iterator): Use SANE_TAB_WIDTH.
1128
18c52557
PE
1129 * fileio.c: Integer overflow issues with file modes.
1130 (Fset_file_modes, auto_save_1): Don't assume EMACS_INT fits in int.
1131
caeeedc1
PE
1132 * charset.c (read_hex): New arg OVERFLOW. All uses changed.
1133 Remove unreachable code.
1134 (read_hex, load_charset_map_from_file): Check for integer overflow.
1135
50849c52
PE
1136 * xterm.c: don't go over XClientMessageEvent limit
1137 (scroll_bar_windows_size): Now ptrdiff_t, as we prefer signed.
1138 (x_send_scroll_bar_event): Likewise. Check that the size does not
1139 exceed limits imposed by XClientMessageEvent, as well as the usual
1140 ptrdiff_t and size_t limits.
1141
b13995db
PE
1142 * keyboard.c: Overflow, signedness and related fixes.
1143 (make_lispy_movement): Use same integer type in forward decl
1144 that is used in the definition.
1145 (read_key_sequence, keyremap_step):
1146 Change bufsize argument back to int, undoing my 2011-03-30 change.
1147 We prefer signed types, and int is wide enough here.
1148 (parse_tool_bar_item): Don't assume tool_bar_max_label_size is less
1149 than TYPE_MAXIMUM (EMACS_INT) / 2. Don't let the label size grow
1150 larger than STRING_BYTES_BOUND. Use ptrdiff_t for Emacs string
1151 length, not size_t. Use ptrdiff_t for index, not int.
1152 (keyremap_step, read_key_sequence): Redo bufsize check to avoid
1153 possibility of integer overflow.
1154
13464394
PE
1155 Overflow, signedness and related fixes for images.
1156
1157 * dispextern.h (struct it.stack[0].u.image.image_id)
1158 (struct_it.image_id, struct image.id, struct image_cache.size)
1159 (struct image_cache.used, struct image_cache.ref_count):
1160 * gtkutil.c (update_frame_tool_bar):
1161 * image.c (x_reference_bitmap, Fimage_size, Fimage_mask_p)
1162 (Fimage_metadata, free_image_cache, clear_image_cache, lookup_image)
1163 (cache_image, mark_image_cache, x_kill_gs_process, Flookup_image):
1164 * nsmenu.m (update_frame_tool_bar):
1165 * xdisp.c (calc_pixel_width_or_height):
1166 * xfns.c (image_cache_refcount):
1167 Image IDs are now ptrdiff_t, not int, to avoid arbitrary limits
1168 on typical 64-bit hosts.
1169
1170 * image.c (RANGED_INTEGERP, TYPE_RANGED_INTEGERP): New macros.
1171 (x_bitmap_pixmap, x_create_x_image_and_pixmap):
1172 Omit unnecessary casts to int.
1173 (parse_image_spec): Check that integers fall into 'int' range
1174 when the callers expect that.
1175 (image_ascent): Redo ascent calculation to avoid int overflow.
1176 (clear_image_cache): Avoid overflow when sqrt (INT_MAX) < nimages.
1177 (lookup_image): Remove unnecessary tests.
1178 (xbm_image_p): Locals are now of int, not EMACS_INT,
1179 since parse_image_check makes sure they fit into int.
1180 (png_load, gif_load, svg_load_image):
1181 Prefer int to unsigned where either will do.
1182 (tiff_handler): New function, combining the cores of the
a66cfb1c
SM
1183 old tiff_error_handler and tiff_warning_handler.
1184 This function is rewritten to use vsnprintf and thereby avoid
13464394
PE
1185 stack buffer overflows. It uses only the features of vsnprintf
1186 that are common to both POSIX and native Microsoft.
1187 (tiff_error_handler, tiff_warning_handler): Use it.
1188 (tiff_load, gif_load, imagemagick_load_image):
1189 Don't assume :index value fits in 'int'.
1190 (gif_load): Omit unnecessary cast to double, and avoid double-rounding.
1191 (imagemagick_load_image): Check that crop parameters fit into
1192 the integer types that MagickCropImage accepts. Don't assume
1193 Vimagemagick_render_type has a nonnegative value. Don't assume
1194 size_t fits in 'long'.
1195 (gs_load): Use printmax_t to print the widest integers possible.
1196 Check for integer overflow when computing image height and width.
1197
c11821d4
EZ
11982011-08-26 Eli Zaretskii <eliz@gnu.org>
1199
1200 * xdisp.c (redisplay_window): Don't force window start if point
1201 will be invisible in the resulting window. (Bug#9324)
1202
0c95fcf7
EZ
12032011-08-25 Eli Zaretskii <eliz@gnu.org>
1204
1205 * xdisp.c (compute_display_string_pos): Return 2 in DISP_PROP when
1206 the display spec is of the form `(space ...)'.
1207 (handle_display_spec): Return the value returned by
1208 handle_single_display_spec, not just 1 or zero.
1209 (handle_single_display_spec): If the display spec is of the form
1210 `(space ...)', and specifies display in the text area, return 2
1211 rather than 1.
fee65a97 1212 (try_cursor_movement): Check for the need to scroll more
a66cfb1c
SM
1213 accurately, and prefer exact match for point under bidi.
1214 Don't advance `row' beyond the last row of the window.
0c95fcf7
EZ
1215
1216 * dispextern.h (struct bidi_it): Rename the disp_prop_p member
1217 into disp_prop; all users changed.
1218
1219 * bidi.c (bidi_fetch_char): If compute_display_string_pos returns
1220 DISP_PROP = 2, substitute the u+2029 PARAGRAPH SEPARATOR character
1221 for the text covered by the display property.
1222
e4ed06f1
CY
12232011-08-25 Chong Yidong <cyd@stupidchicken.com>
1224
1225 * buffer.c (Fbury_buffer_internal): Rename from Funrecord_buffer.
1226 Change return value to nil.
1227 (Frecord_buffer): Delete unused function.
1228
f67cdd7f
EZ
12292011-08-24 Eli Zaretskii <eliz@gnu.org>
1230
5980d4c6
EZ
1231 * xdisp.c (Fcurrent_bidi_paragraph_direction): For unibyte
1232 buffers, return left-to-right.
8610fe8b
EZ
1233 (set_cursor_from_row): Consider candidate row a win if its glyph
1234 represents a newline and point is on that newline. Fixes cursor
1235 positioning on the newline at EOL of R2L text within L2R
1236 paragraph, and vice versa.
1237 (try_cursor_movement): Check continued rows, in addition to
1238 continuation rows. Fixes unwarranted scroll when point enters a
1239 continued line of R2L text within an L2R paragraph, or vice versa.
1240 (cursor_row_p): Consider the case of point being equal to
1241 MATRIX_ROW_END_CHARPOS. Prevents cursor being stuck when moving
1242 from the end of a short line to the beginning of a continued line
1243 of R2L text within L2R paragraph.
1244 (RECORD_MAX_MIN_POS): For max_pos, use IT_CHARPOS even for
1245 composed characters.
5980d4c6 1246
f67cdd7f
EZ
1247 * bidi.c (bidi_check_type): Use xassert.
1248 (bidi_cache_iterator_state): Update the disp_pos and disp_prop_p
1249 members.
1250
bca633fb
EZ
12512011-08-23 Eli Zaretskii <eliz@gnu.org>
1252
1253 * bidi.c (bidi_get_type): Abort if we get zero as the bidi type of
1254 a character.
1255
4a5885a7
CY
12562011-08-23 Chong Yidong <cyd@stupidchicken.com>
1257
1258 * nsfont.m (ns_otf_to_script): Fix typo.
1259
0902a04e
KH
12602011-08-22 Kenichi Handa <handa@m17n.org>
1261
1262 * chartab.c (Fset_char_table_extra_slot): Do not inhibit setting a
1263 extra slot even if the purpose is char-code-property-table.
1264
1a2e6670
EZ
12652011-08-23 Eli Zaretskii <eliz@gnu.org>
1266
8ddde651
EZ
1267 * xdisp.c (redisplay_window): When computing centering_position,
1268 account for the height of the header line. (Bug#8874)
1269
425cc014
EZ
1270 * dispnew.c (buffer_posn_from_coords): Use buf_charpos_to_bytepos
1271 instead of CHAR_TO_BYTE. Fixes a crash when a completion
1272 candidate is selected by the mouse, and that candidate has a
1273 composed character under the mouse.
1274
1a2e6670
EZ
1275 * xdisp.c (x_produce_glyphs): Set it->nglyphs to 1. Fixes pixel
1276 coordinates reported by pos-visible-in-window-p for a composed
1277 character in column zero.
1278
8b76d6f8
SM
12792011-08-23 Stefan Monnier <monnier@iro.umontreal.ca>
1280
1281 * cmds.c (Fself_insert_command): Mention post-self-insert-hook.
1282
dac347dd
EZ
12832011-08-22 Eli Zaretskii <eliz@gnu.org>
1284
1285 * xdisp.c (BUFFER_POS_REACHED_P): If this is a composition,
1286 consider it a hit if to_charpos is anywhere in the range of the
1287 composed buffer positions.
1288
e013fb34
CY
12892011-08-22 Chong Yidong <cyd@stupidchicken.com>
1290
1291 * image.c (gif_load): Don't assume that each subimage has the same
1292 dimensions as the base image. Handle disposal method that is
1293 "undefined" by the gif spec (Bug#9335).
1294
bd1ba3e8
CY
12952011-08-20 Chong Yidong <cyd@stupidchicken.com>
1296
1297 * eval.c (Fsignal): Handle `debug' symbol in error handler (Bug#9329).
024a2d76 1298 (Fcondition_case): Document `debug' symbol in error handler.
bd1ba3e8 1299
54a1215b
EZ
13002011-08-19 Eli Zaretskii <eliz@gnu.org>
1301
823564e5
EZ
1302 * xfaces.c (face_at_buffer_position): Avoid repeated evaluation of
1303 face ID by FACE_FROM_ID, and avoid a crash when mouse is moved
1304 from an Org mode buffer to a Speedbar frame.
1305
54a1215b
EZ
1306 * xdisp.c (RECORD_MAX_MIN_POS): If the display element comes from
1307 a composition, take its buffer position from IT->cmp_it.charpos.
1308 Fixes cursor positioning at the beginning of a line that begins
1309 with a composed character.
1310
9778ebcc
EZ
13112011-08-18 Eli Zaretskii <eliz@gnu.org>
1312
0be6ee06
EZ
1313 * bidi.c (bidi_get_type): If bidi_type_table reports zero as the
1314 character bidirectional type, use STRONG_L instead. Fixes crashes
1315 in a buffer produced by `describe-categories'.
1316
9778ebcc
EZ
1317 * dispextern.h (struct bidi_it): Move disp_pos and disp_prop_p
1318 members before the level stack, so they would be saved and
1319 restored when copying iterator state. Fixes incorrect reordering
1320 around TABs covered by display properties.
1321
156bffbe
AS
13222011-08-18 Andreas Schwab <schwab@linux-m68k.org>
1323
6b02f655 1324 * process.c (Fnetwork_interface_list): Correctly determine buffer size.
156bffbe 1325
72ad093b
CY
13262011-08-17 Chong Yidong <cyd@stupidchicken.com>
1327
1328 * eval.c (internal_condition_case, internal_condition_case_1)
8b76d6f8
SM
1329 (internal_condition_case_2, internal_condition_case_n):
1330 Remove unnecessary aborts (Bug#9081).
72ad093b 1331
35774242
EZ
13322011-08-17 Eli Zaretskii <eliz@gnu.org>
1333
1334 * lread.c (Fload) [DOS_NT]: If `openp' returns -2, but the file
1335 has no `load' handler, try opening the file locally. (Bug#9311)
1336
db76dd85
KB
13372011-08-16 Ken Brown <kbrown@cornell.edu>
1338
1339 * gmalloc.c: Expand comment.
1340
b215eee5
EZ
13412011-08-16 Eli Zaretskii <eliz@gnu.org>
1342
1343 * xdisp.c (set_cursor_from_row): Don't accept a previous candidate
1344 if it fails the cursor_row_p test. Fixes cursor positioning at ZV.
1345
a4579d33
KB
13462011-08-16 Ken Brown <kbrown@cornell.edu>
1347
1348 Fix memory allocation problems in Cygwin build (Bug#9273).
1349
1350 * unexcw.c ( __malloc_initialized): Declare external variable.
1351 (fixup_executable): Force the dumped emacs to reinitialize malloc.
1352
8b76d6f8
SM
1353 * gmalloc.c [CYGWIN] (bss_sbrk_heapbase, bss_sbrk_heapinfo):
1354 New variables.
a4579d33
KB
1355 (malloc_initialize_1) [CYGWIN]: Prepare for reinitializing the
1356 dumped emacs.
1357 (_free_internal_nolock) [CYGWIN]: Ignore requests to free storage
1358 in the static heap.
1359 [CYGWIN] (special_realloc): New function.
1360 (_realloc_internal_nolock) [CYGWIN]: Use the new function on
1361 requests to realloc storage in the static heap.
1362
3ebec551
PE
13632011-08-15 Paul Eggert <eggert@cs.ucla.edu>
1364
1365 * bidi.c (bidi_initialize): Remove unused local.
1366
9fd8be00
EZ
13672011-08-15 Eli Zaretskii <eliz@gnu.org>
1368
6b02f655
SM
1369 * bidimirror.h:
1370 * biditype.h: Remove file.
1371 * makefile.w32-in ($(BLD)/bidi.$(O)):
1372 * deps.mk (bidi.o): Remove biditype.h and bidimirror.h.
474a8465
EZ
1373
1374 * dispextern.h: Fix a typo in the comment to bidi_type_t.
1375
1376 * chartab.c: Improve commentary for the uniprop_table API.
1377
32413314
EZ
1378 * bidi.c (bidi_paragraph_init): Support zero value of
1379 bidi_ignore_explicit_marks_for_paragraph_level.
474a8465
EZ
1380 (bidi_initialize): Use uniprop_table instead of including
1381 biditype.h and bidimirror.h.
32413314 1382
9fd8be00
EZ
1383 * xdisp.c (move_it_in_display_line_to): Don't reset pixel
1384 coordinates of the iterator when restoring from ppos_it.
1385 (Bug#9296)
1386
5cf2b69b
KH
13872011-08-14 Kenichi Handa <handa@m17n.org>
1388
1389 * process.c (create_process): Call setup_process_coding_systems
72ad093b 1390 after the pid of the process is set to -1 (Bug#8162).
5cf2b69b 1391
daf17d00
EZ
13922011-08-14 Eli Zaretskii <eliz@gnu.org>
1393
1394 * xdisp.c (move_it_in_display_line_to): Don't invoke
1395 IT_RESET_X_ASCENT_DESCENT when iterator position was restored from
1396 ppos_it. Fixes vertical cursor motion when line beginning is
1397 covered by an image. (Bug#9296)
1398
08e3161a
JD
13992011-08-14 Jan Djärv <jan.h.d@swipnet.se>
1400
1401 * nsterm.h (ns_run_ascript): Declare.
1402 (NSAPP_DATA2_RUNASSCRIPT): Define.
1403
1404 * nsfns.m (as_script, as_result, as_status): New static variables.
1405 (ns_run_ascript): New function.
5e617bc2 1406 (Fns_do_applescript): Set variables as_*. Make an NSApplicationDefined
08e3161a
JD
1407 event with data2 set to NSAPP_DATA2_RUNASSCRIPT, post it and then start
1408 the event loop. Get status from as_status (Bug#7276).
1409
1410 * nsterm.m (sendEvent): If event is NSApplicationDefined and
1411 data2 is NSAPP_DATA2_RUNASSCRIPT, call ns_run_ascript and then exit
1412 the event loop (Bug#7276).
1413
a3720aa2
AS
14142011-08-14 Andreas Schwab <schwab@linux-m68k.org>
1415
1416 * gnutls.c (QCgnutls_bootprop_priority)
1417 (QCgnutls_bootprop_trustfiles, QCgnutls_bootprop_keylist)
1418 (QCgnutls_bootprop_crlfiles, QCgnutls_bootprop_callbacks)
1419 (QCgnutls_bootprop_loglevel, QCgnutls_bootprop_hostname)
1420 (QCgnutls_bootprop_min_prime_bits, QCgnutls_bootprop_verify_flags)
1421 (QCgnutls_bootprop_verify_hostname_error)
1422 (QCgnutls_bootprop_callbacks_verify): Rename from
1423 Qgnutls_bootprop_..., all uses changed.
1424
1425 * xfaces.c (QCignore_defface): Rename from Qignore_defface, all
1426 uses changed.
1427
0a0d27fb
PE
14282011-08-14 Paul Eggert <eggert@cs.ucla.edu>
1429
19d5c50c
PE
1430 * xfaces.c (Qframe_set_background_mode): Now static.
1431 * dispextern.h (Qframe_set_background_mode): Remove decl.
1432
0a0d27fb
PE
1433 * process.c (Fnetwork_interface_info): Declare local only if needed.
1434
377538cb
JD
14352011-08-13 Jan Djärv <jan.h.d@swipnet.se>
1436
1437 * process.c: Include ifaddrs.h and net/if_dl.h if available (Bug#8477).
1438 (Fnetwork_interface_list): Allocate in increments of bytes instead
1439 of sizeof (struct ifreq). Iterate over ifconf.ifc_req by counting
1440 bytes (Bug#8477). Count bytes correctly when ifr_addr is a struct
1441 sockaddr.
1442 (struct ifflag_def): notrailers is smart on OSX.
1443 (Fnetwork_interface_info): Handle case when ifr_flags is negative.
1444 Get hardware address with getifaddrs if available.
1445
08fff70c
EZ
14462011-08-12 Eli Zaretskii <eliz@gnu.org>
1447
1448 * xdisp.c (iterate_out_of_display_property): xassert that
1449 IT->position is set to within IT->object's boundaries. Break from
1450 the loop as soon as EOB is reached; avoids infloops in redisplay
8b76d6f8
SM
1451 when IT->position is set up wrongly due to some bug.
1452 Set IT->current to match the bidi iterator unconditionally.
08fff70c
EZ
1453 (push_display_prop): Allow GET_FROM_STRING as IT->method on
1454 entry. Force push_it to save on the stack the current
1455 buffer/string position, to be restored by pop_it. Fix flags in
1456 the iterator structure wrt the object coming from a display
1457 property, as `line-prefix' and `wrap-prefix' are not ``replacing''
1458 properties. (Bug#9284)
1459
7be1c708 14602011-08-09 Andreas Schwab <schwab@linux-m68k.org>
aac0c6e3 1461
7be1c708
CY
1462 * fontset.c (fontset_get_font_group): Add proper type checks.
1463 (Bug#9172)
aac0c6e3 1464
7be1c708 14652011-08-09 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
aac0c6e3 1466
7be1c708
CY
1467 * unexmacosx.c (print_load_command_name): Add cases LC_FUNCTION_STARTS
1468 and LC_VERSION_MIN_MACOSX.
1469 (copy_linkedit_data) [LC_FUNCTION_STARTS]: New function.
1470 (dump_it) [LC_FUNCTION_STARTS]: Use it.
aac0c6e3 1471
97bb72a6
EZ
14722011-08-08 Eli Zaretskii <eliz@gnu.org>
1473
1474 * xdisp.c (forward_to_next_line_start): Allow to use the
8b76d6f8
SM
1475 no-display-properties-and-no-overlays under bidi display.
1476 Set disp_pos in the bidi iterator to avoid searches for display
757664a4 1477 properties and overlays.
97bb72a6 1478
d5617611
CY
14792011-08-08 Chong Yidong <cyd@stupidchicken.com>
1480
37e11a63
CY
1481 * editfns.c (Fset_time_zone_rule): Document relationship with the
1482 setenv function.
1483
d5617611
CY
1484 * ftfont.c (ftfont_pattern_entity): Copy the extras argument to
1485 the font entity extracted from the cache (Bug#8109).
1486
58872834
CY
14872011-08-07 Chong Yidong <cyd@stupidchicken.com>
1488
1489 * composite.c (autocmp_chars): Don't reset point. That is done by
1490 restore_point_unwind (Bug#5984).
1491
75bfc667
JL
14922011-08-07 Juri Linkov <juri@jurta.org>
1493
1494 * editfns.c (Fformat_time_string): Doc fix, add tag `usage:'
1495 to show the arg `TIME' instead of `TIMEVAL'.
1496
d1410150
EZ
14972011-08-06 Eli Zaretskii <eliz@gnu.org>
1498
1499 * xdisp.c (set_cursor_from_row): Fix cursor positioning when a
1500 display property strides EOL and includes a newline, as in
1501 longlines-mode. (Bug#9254)
75b771e4
EZ
1502 (move_it_in_display_line_to): Fix vertical-motion in a buffer with
1503 word-wrap under bidirectional display. (Bug#9224)
d1410150
EZ
1504
1505 * bidi.c (bidi_unshelve_cache): Don't reset the cache if JUST_FREE
1506 is non-zero, even if the data buffer is NULL. Fixes a crash in
1507 vertical-motion with longlines-mode. (Bug#9254)
1508
35928349
EZ
15092011-08-05 Eli Zaretskii <eliz@gnu.org>
1510
ec7cc85b
EZ
1511 * bidi.c <bidi_cache_total_alloc>: Now static.
1512 (bidi_initialize): Initialize bidi_cache_total_alloc.
1513
8b76d6f8 1514 * xdisp.c (display_line): Release buffer allocated for shelved bidi
35928349
EZ
1515 cache. (Bug#9221)
1516
1517 * bidi.c (bidi_shelve_cache, bidi_unshelve_cache): Track total
1518 amount allocated this far in `bidi_cache_total_alloc'.
1519 (bidi_unshelve_cache): Accept an additional argument JUST_FREE; if
1520 non-zero, only free the data buffer without restoring the cache
1521 contents. All callers changed.
1522
1523 * dispextern.h (bidi_unshelve_cache): Update prototype.
1524
1525 * xdisp.c (SAVE_IT, pos_visible_p, move_it_in_display_line_to)
1526 (move_it_in_display_line, move_it_to)
1527 (move_it_vertically_backward, move_it_by_lines): Replace the call
1528 to xfree to an equivalent call to bidi_unshelve_cache.
1529 (move_it_in_display_line_to): Fix logic of returning
412b6358 1530 MOVE_POS_MATCH_OR_ZV in the bidi case. (Bug#9224)
35928349 1531
e2e2423b
EZ
15322011-08-05 Eli Zaretskii <eliz@gnu.org>
1533
1534 * xdisp.c (set_cursor_from_row): Prefer the candidate glyph that
1535 came from a string character with a `cursor' property. (Bug#9229)
1536
ae9e757a
JD
15372011-08-04 Jan Djärv <jan.h.d@swipnet.se>
1538
1539 * Makefile.in (LIB_PTHREAD): New variable.
1540 (LIBES): Add LIB_PTHREAD (Bug#9216).
1541
1542 * alloc.c, emacs.c, gmalloc.c, gtkutil.c, keyboard.c, syssignal.h:
1543 Rename HAVE_GTK_AND_PTHREAD to HAVE_PTHREAD (Bug#9216).
1544
213bd7f2
AS
15452011-08-04 Andreas Schwab <schwab@linux-m68k.org>
1546
6b02f655 1547 * regex.c (re_iswctype): Remove some redundant boolean conversions.
213bd7f2 1548
99aaf75f
JD
15492011-08-04 Jan Djärv <jan.h.d@swipnet.se>
1550
1551 * xterm.c (x_find_topmost_parent): New function.
1552 (x_set_frame_alpha): Find topmost parent window with
1553 x_find_topmost_parent and set the property there also (bug#9181).
1554 (handle_one_xevent): Call x_set_frame_alpha on ReparentNotify.
1555
c74e9d86
PE
15562011-08-04 Paul Eggert <eggert@cs.ucla.edu>
1557
1558 * callproc.c (Fcall_process): Avoid vfork clobbering
1559 the local vars buffer, coding_systems, current_dir.
1560
640c8776
SM
15612011-08-03 Stefan Monnier <monnier@iro.umontreal.ca>
1562
1563 * keymap.c (Fmake_composed_keymap): Move to subr.el.
1564
f26d0e4c
PE
15652011-08-03 Paul Eggert <eggert@cs.ucla.edu>
1566
8a10d76c
PE
1567 * fontset.c (dump_fontset) [FONTSET_DEBUG]: Declare EXTERNALLY_VISIBLE
1568 so that it is not optimized away.
1569
f26d0e4c
PE
1570 * xdisp.c (compute_display_string_pos): Remove unused local.
1571
55439c61
EZ
15722011-08-02 Eli Zaretskii <eliz@gnu.org>
1573
1574 Fix slow cursor motion and scrolling in large buffers with
1575 selective display, like Org Mode buffers. (Bug#9218)
1576
1577 * dispextern.h (struct bidi_it): New member disp_prop_p.
1578
1579 * xdisp.c: Remove one-slot cache of display string positions.
1580 (compute_display_string_pos): Accept an additional argument
5e617bc2 1581 DISP_PROP_P; callers changed. Scan at most 5K characters forward
55439c61
EZ
1582 for a display string or property. If found, set DISP_PROP_P
1583 non-zero.
1584
1585 * bidi.c (bidi_fetch_char): Accept an additional argument
640c8776
SM
1586 DISP_PROP_P, and pass it to compute_display_string_pos.
1587 Only handle text covered by a display string if DISP_PROP_P is returned
55439c61
EZ
1588 non-zero. All callers of bidi_fetch_char changed.
1589
fb33fa43
SM
15902011-08-02 Stefan Monnier <monnier@iro.umontreal.ca>
1591
1592 * keymap.c (Fdefine_key): Fix Lisp_Object/int mixup; apply some CSE.
1593
b099e063
DM
15942010-12-03 Don March <don@ohspite.net>
1595
1596 * keymap.c (Fdefine_key): Fix non-prefix key error message when
1597 last character M-[char] is translated to ESC [char] (bug#7541).
1598
5cc7f7af
KH
15992011-08-02 Kenichi Handa <handa@m17n.org>
1600
d0fffa3f 1601 * lisp.h (uniprop_table): Extern it.
5cc7f7af
KH
1602
1603 * chartab.c (uniprop_table): Make it non-static.
1604
525d5e6e
EZ
16052011-08-01 Eli Zaretskii <eliz@gnu.org>
1606
1607 * xdisp.c (forward_to_next_line_start): Accept additional argument
1608 BIDI_IT_PREV, and store into it the state of the bidi iterator had
1609 on the newline.
1610 (reseat_at_next_visible_line_start): Use the bidi iterator state
1611 returned by forward_to_next_line_start to restore the state of
1612 it->bidi_it after backing up to previous newline. (Bug#9212)
1613
31011111
AS
16142011-07-30 Andreas Schwab <schwab@linux-m68k.org>
1615
1616 * regex.c (re_comp): Protoize.
1617 (re_exec): Fix return type.
1618 (regexec): Fix type of `ret'. (Bug#9203)
1619
476371c4
PE
16202011-07-28 Paul Eggert <eggert@cs.ucla.edu>
1621
e5d76069
PE
1622 * image.c (check_image_size): Use 1024x1024 if unknown frame (Bug#9189).
1623 This is needed if max-image-size is a floating-point number.
1624
9a79b20c
AS
16252011-07-28 Andreas Schwab <schwab@linux-m68k.org>
1626
1627 * print.c (print_object): Print empty symbol as ##.
1628
1629 * lread.c (read1): Read ## as empty symbol.
1630
d8c2fa78
AA
16312011-07-28 Alp Aker <alp.tekin.aker@gmail.com>
1632
1633 * nsfns.m (x_set_foreground_color): Set f->foreground_pixel when
1634 setting frame foreground color (Bug#9175).
1635 (x_set_background_color): Likewise.
1636
ffe57a7a
AA
1637 * nsmenu.m (-setText): Size tooltip dimensions precisely to
1638 contents (Bug#9176).
1639 (EmacsTooltip -init): Remove bezels and add shadows to
1640 tooltip windows.
1641
bf3492a5
AA
1642 * nsterm.m (ns_dumpglyphs_stretch): Avoid overwriting left fringe
1643 or scroll bar (Bug#8470).
1644
d55e9c53
AA
1645 * nsfont.m (nsfont_open): Remove assignment to voffset and
1646 unnecessary vars hshink, expand, hd, full_height, min_height.
1647 (nsfont_draw): Use s->ybase as baseline for glyph drawing (Bug#8913).
1648
1649 * nsterm.h (nsfont_info): Remove voffset field.
1650
d8c2fa78 16512011-07-28 Alp Aker <alp.tekin.aker@gmail.com>
4843aac3
AA
1652
1653 Implement strike-through and overline on NextStep (Bug#8863).
1654
1655 * nsfont.m (nsfont_open): Use underline position provided by font,
1656 instead of hard-coded value of 2.
1657 (nsfont_draw): Call ns_draw_text_decoration instead.
1658
1659 * nsterm.h: Add declaration for ns_draw_text_decoration.
1660
1661 * nsterm.m (ns_draw_text_decoration): New function for drawing
1662 underline, overline, and strike-through.
1663 (ns_dumpglyphs_image, ns_dumpglyphs_stretch): Add call to
1664 ns_draw_text_decoration. Change treatment of cursor drawing to
8d5ed899 1665 accommodate underlining, etc.
4843aac3 1666
4cc60b9b
EZ
16672011-07-28 Eli Zaretskii <eliz@gnu.org>
1668
bc7ece87
EZ
1669 * buffer.c (init_buffer_once): Set bidi-display-reordering to t by
1670 default.
4cc60b9b 1671
476371c4
PE
16722011-07-28 Paul Eggert <eggert@cs.ucla.edu>
1673
66606eea
PE
1674 * alloc.c (memory_full) [!SYNC_INPUT]: Fix signal-related race.
1675 Without this fix, if a signal arrives just after memory fills up,
1676 'malloc' might be invoked reentrantly.
1677
476371c4
PE
1678 * image.c (x_check_image_size) [!HAVE_X_WINDOWS]: Return 1.
1679 In other words, assume that every image size is allowed, on non-X
1680 hosts. This assumption is probably wrong, but it lets Emacs compile.
1681
f3fcc40d
AS
16822011-07-28 Andreas Schwab <schwab@linux-m68k.org>
1683
1684 * regex.c (re_iswctype): Convert return values to boolean.
1685
350c992f
EZ
16862011-07-28 Eli Zaretskii <eliz@fencepost.gnu.org>
1687
1688 * xdisp.c (compute_display_string_pos): Don't use cached display
1689 string position if the buffer had its restriction changed.
1690 (Bug#9184)
1691
5266b4bb
PE
16922011-07-28 Paul Eggert <eggert@cs.ucla.edu>
1693
1694 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork clobbering.
1695
2573a837 16962011-07-28 Paul Eggert <eggert@cs.ucla.edu>
ca4aa935 1697
41f55ccd 1698 Integer signedness and overflow and related fixes. (Bug#9079)
cf950e6b 1699
39e378da
PE
1700 * bidi.c: Integer size and overflow fixes.
1701 (bidi_cache_size, bidi_cache_idx, bidi_cache_last_idx)
1702 (bidi_cache_start, bidi_cache_fetch_state, bidi_cache_search)
1703 (bidi_cache_find_level_change, bidi_cache_ensure_space)
1704 (bidi_cache_iterator_state, bidi_cache_find, bidi_cache_start_stack)
1705 (bidi_find_other_level_edge):
1706 Use ptrdiff_t instead of EMACS_INT where either will do.
1707 This works better on 32-bit hosts configured --with-wide-int.
1708 (bidi_cache_ensure_space): Check for size-calculation overflow.
1709 Use % rather than repeated addition, for better worst-case speed.
1710 Don't set bidi_cache_size until after xrealloc returns, because it
1711 might not return.
1712 (bidi_dump_cached_states): Use ptrdiff_t, not int, to avoid overflow.
f0eb61e9
PE
1713 (bidi_cache_ensure_space): Also check that the bidi cache size
1714 does not exceed that of the largest Lisp string or buffer. See Eli
1715 Zaretskii in <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=9079#29>.
39e378da 1716
5e927815
PE
1717 * alloc.c (__malloc_size_t): Remove.
1718 All uses replaced by size_t. See Andreas Schwab's note
1719 <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=9079#8>.
1720
ca4aa935
PE
1721 * image.c: Improve checking for integer overflow.
1722 (check_image_size): Assume that f is nonnull, since
1723 it is always nonnull in practice. This is one less thing to
1724 worry about when checking for integer overflow later.
1725 (x_check_image_size): New function, which checks for integer
1726 overflow issues inside X.
1727 (x_create_x_image_and_pixmap, xbm_read_bitmap_data): Use it.
1728 This removes the need for a memory_full check.
1729 (xbm_image_p): Rewrite to avoid integer multiplication overflow.
1730 (Create_Pixmap_From_Bitmap_Data, xbm_load): Use x_check_image_size.
1731 (xbm_read_bitmap_data): Change locals back to 'int', since
1732 their values must fit in 'int'.
1733 (xpm_load_image, png_load, tiff_load):
1734 Invoke x_create_x_image_and_pixmap earlier,
1735 to avoid much needless work if the image is too large.
1736 (tiff_load): Treat overly large images as if
1737 x_create_x_image_and_pixmap failed, not as malloc failures.
1738 (gs_load): Use x_check_image_size.
1739
5f8f9cc2
PE
1740 * gtkutil.c: Omit integer casts.
1741 (xg_get_pixbuf_from_pixmap): Remove unnecessary cast.
1742 (xg_set_toolkit_scroll_bar_thumb): Rewrite to avoid need for cast.
1743
5adf60bc
PE
1744 * image.c (png_load): Don't assume height * row_bytes fits in 'int'.
1745
c8907a93
PE
1746 * xfaces.c (Fbitmap_spec_p): Fix integer overflow bug.
1747 Without this fix, (bitmap-spec-p '(34359738368 1 "x"))
1748 would wrongly return t on a 64-bit host.
1749
e3c25c68
PE
1750 * dispnew.c (init_display): Use *_RANGE_OVERFLOW macros.
1751 The plain *_OVERFLOW macros run afoul of GCC bug 49705
1752 <http://gcc.gnu.org/bugzilla/show_bug.cgi?id=49705>
1753 and therefore cause GCC to emit a bogus diagnostic in some cases.
1754
3f791afe
PE
1755 * image.c: Integer signedness and overflow and related fixes.
1756 This is not an exhaustive set of fixes, but it's time to
1757 record what I've got.
1758 (lookup_pixel_color, check_image_size): Remove redundant decls.
1759 (check_image_size): Don't assume that arbitrary EMACS_INT values
1760 fit in 'int', or that arbitrary 'double' values fit in 'int'.
1761 (x_alloc_image_color, x_create_x_image_and_pixmap, png_load)
1762 (tiff_load, imagemagick_load_image):
1763 Check for overflow in size calculations.
1764 (x_create_x_image_and_pixmap): Remove unnecessary test for
1765 xmalloc returning NULL; that can't happen.
1766 (xbm_read_bitmap_data): Don't assume sizes fit into 'int'.
1767 (xpm_color_bucket): Use better integer hashing function.
1768 (xpm_cache_color): Don't possibly over-allocate memory.
1769 (struct png_memory_storage, tiff_memory_source, tiff_seek_in_memory)
1770 (gif_memory_source):
1771 Use ptrdiff_t, not int or size_t, to record sizes.
1772 (png_load): Don't assume values greater than 2**31 fit in 'int'.
1773 (our_stdio_fill_input_buffer): Prefer ptrdiff_t to size_t when
1774 either works, as we prefer signed integers.
1775 (tiff_read_from_memory, tiff_write_from_memory):
1776 Return tsize_t, not size_t, since that's what the TIFF API wants.
1777 (tiff_read_from_memory): Don't fail simply because the read would
1778 go past EOF; instead, return a short read.
1779 (tiff_load): Omit no-longer-needed casts.
1780 (Fimagemagick_types): Don't assume size fits into 'int'.
1781
3cc5a532
PE
1782 Improve hashing quality when configured --with-wide-int.
1783 * fns.c (hash_string): New function, taken from sxhash_string.
1784 Do not discard information about ASCII character case; this
1785 discarding is no longer needed.
1786 (sxhash-string): Use it. Change sig to match it. Caller changed.
1787 * lisp.h: Declare it.
1788 * lread.c (hash_string): Remove, since we now use fns.c's version.
1789 The fns.c version returns a wider integer if --with-wide-int is
1790 specified, so this should help the quality of the hashing a bit.
1791
b312a492
PE
1792 * emacs.c: Integer overflow minor fix.
1793 (heap_bss_diff): Now uprintmax_t, not unsigned long. All used changed.
1794 Define only if GNU_LINUX.
1795 (main, Fdump_emacs): Set and use heap_bss_diff only if GNU_LINUX.
1796
dfd153ae
PE
1797 * dispnew.c: Integer signedness and overflow fixes.
1798 Remove unnecessary forward decls, that were a maintenance hassle.
1799 (history_tick): Now uprintmax_t, so it's more likely to avoid overflow.
1800 All uses changed.
1801 (adjust_glyph_matrix, realloc_glyph_pool, adjust_frame_message_buffer)
1802 (scrolling_window): Use ptrdiff_t, not int, for byte count.
1803 (prepare_desired_row, line_draw_cost):
1804 Use int, not unsigned, where either works.
1805 (save_current_matrix, restore_current_matrix):
1806 Use ptrdiff_t, not size_t, where either works.
1807 (init_display): Check for overflow more accurately, and without
1808 relying on undefined behavior.
1809
a81d11a3
PE
1810 * editfns.c (pWIDE, pWIDElen, signed_wide, unsigned_wide):
1811 Remove, replacing with the new symbols in lisp.h. All uses changed.
1812 * fileio.c (make_temp_name):
1813 * filelock.c (lock_file_1, lock_file):
1814 * xdisp.c (message_dolog):
1815 Don't assume PRIdMAX etc. works; this isn't portable to pre-C99 hosts.
1816 Use pMd etc. instead.
1817 * lisp.h (printmax_t, uprintmax_t, pMd, pMu): New types and macros,
1818 replacing the pWIDE etc. symbols removed from editfns.c.
1819
3300e6fd
PE
1820 * keyboard.h (num_input_events): Now uintmax_t.
1821 This is (very slightly) less likely to mess up due to wraparound.
1822 All uses changed.
1823
fd05c7e9
PE
1824 * buffer.c: Integer signedness fixes.
1825 (alloc_buffer_text, enlarge_buffer_text):
1826 Use ptrdiff_t rather than size_t when either will do, as we prefer
1827 signed integers.
1828
903fe15d
PE
1829 * alloc.c: Integer signedness and overflow fixes.
1830 Do not impose an arbitrary 32-bit limit on malloc sizes when debugging.
1831 (__malloc_size_t): Default to size_t, not to int.
1832 (pure_size, pure_bytes_used_before_overflow, stack_copy_size)
1833 (Fgarbage_collect, mark_object_loop_halt, mark_object):
1834 Prefer ptrdiff_t to size_t when either would do, as we prefer
1835 signed integers.
1836 (XMALLOC_OVERRUN_CHECK_OVERHEAD): New macro.
1837 (xmalloc_overrun_check_header, xmalloc_overrun_check_trailer):
1838 Now const. Initialize with values that are in range even if char
1839 is signed.
1840 (XMALLOC_PUT_SIZE, XMALLOC_GET_SIZE): Remove, replacing with ...
1841 (xmalloc_put_size, xmalloc_get_size): New functions. All uses changed.
1842 These functions do the right thing with sizes > 2**32.
1843 (check_depth): Now ptrdiff_t, not int.
1844 (overrun_check_malloc, overrun_check_realloc, overrun_check_free):
1845 Adjust to new way of storing sizes. Check for size overflow bugs
1846 in rest of code.
1847 (STRING_BYTES_MAX): Adjust to new overheads. The old code was
1848 slightly wrong anyway, as it missed one instance of
1849 XMALLOC_OVERRUN_CHECK_OVERHEAD.
1850 (refill_memory_reserve): Omit needless cast to size_t.
1851 (mark_object_loop_halt): Mark as externally visible.
1852
ac82cc6a
PE
1853 * xselect.c: Integer signedness and overflow fixes.
1854 (Fx_register_dnd_atom, x_handle_dnd_message):
1855 Use ptrdiff_t, not size_t, since we prefer signed.
1856 (Fx_register_dnd_atom): Check for ptrdiff_t (and size_t) overflow.
1857 * xterm.h (struct x_display_info): Use ptrdiff_t, not size_t, for
1858 x_dnd_atoms_size and x_dnd_atoms_length.
1859
c2d1e36d
PE
1860 * doprnt.c: Prefer signed to unsigned when either works.
1861 * eval.c (verror):
1862 * doprnt.c (doprnt):
1863 * lisp.h (doprnt):
1864 * xdisp.c (vmessage):
1865 Use ptrdiff_t, not size_t, when using or implementing doprnt,
1866 since the sizes cannot exceed ptrdiff_t bounds anyway, and we
1867 prefer signed arithmetic to avoid comparison confusion.
1868 * doprnt.c (doprnt): Avoid a "+ 1" that can't overflow,
1869 but is a bit tricky.
1870
0e926e56
PE
1871 Assume freestanding C89 headers, string.h, stdlib.h.
1872 * data.c, doprnt.c, floatfns.c, print.c:
1873 Include float.h unconditionally.
1874 * gmalloc.c: Assume C89-at-least behavior for preprocessor,
1875 limits.h, stddef.h, string.h. Use memset instead of 'flood'.
1876 * regex.c: Likewise for stddef.h, string.h.
1877 (ISASCII): Remove; can assume it returns 1 now. All uses removed.
1878 * s/aix4-2.h (HAVE_STRING_H): Remove obsolete undef.
1879 * s/ms-w32.h (HAVE_LIMITS_H, HAVE_STRING_H, HAVE_STDLIB_H)
1880 (STDC_HEADERS): Remove obsolete defines.
1881 * sysdep.c: Include limits.h unconditionally.
1882
9cfdb3ec
PE
1883 Assume support for memcmp, memcpy, memmove, memset.
1884 * lisp.h, sysdep.c (memcmp, memcpy, memmove, memset):
1885 * regex.c (memcmp, memcpy):
1886 Remove; we assume C89 now.
1887
1888 * gmalloc.c (memcpy, memset, memmove): Remove; we assume C89 now.
1889 (__malloc_safe_bcopy): Remove; no longer needed.
1890
cf950e6b 1891 * lisp.h (struct vectorlike_header, struct Lisp_Subr): Signed sizes.
6089c567
PE
1892 Use EMACS_INT, not EMACS_UINT, for sizes. The code works equally
1893 well either way, and we prefer signed to unsigned.
1894
dbf38e02
LMI
18952011-07-27 Lars Magne Ingebrigtsen <larsi@gnus.org>
1896
1897 * gnutls.c (emacs_gnutls_read): Don't message anything if the peer
1898 closes the connection while we're reading (bug#9182).
1899
d6f0886c 19002011-07-25 Jan Djärv <jan.h.d@swipnet.se>
24e0f6b1 1901
d6f0886c
JD
1902 * nsmenu.m (ns_popup_dialog): Add an "ok" button if no buttons
1903 are specified (Bug#9168).
24e0f6b1 1904
2eb1f9e6
PE
19052011-07-25 Paul Eggert <eggert@cs.ucla.edu>
1906
1907 * bidi.c (bidi_dump_cached_states): Fix printf format mismatch.
1908 Found by GCC static checking and --with-wide-int on a 32-bit host.
1909
22381272 19102011-07-25 Eli Zaretskii <eliz@gnu.org>
7daee910
EZ
1911
1912 * xdisp.c (compute_display_string_pos): Fix logic of caching
1913 previous display string position. Initialize cached_prev_pos to
1914 -1. Fixes slow-down at the beginning of a buffer.
1915
f25e39b4
EZ
19162011-07-24 Eli Zaretskii <eliz@gnu.org>
1917
1918 * xfaces.c (check_lface_attrs) [HAVE_WINDOW_SYSTEM]: Allow `nil'
1919 for attrs[LFACE_FONTSET_INDEX].
1920
04c4b52e
PE
19212011-07-23 Paul Eggert <eggert@cs.ucla.edu>
1922
1923 * xml.c (parse_region): Remove unused local
1924 that was recently introduced.
1925
c1734fbd
EZ
19262011-07-23 Eli Zaretskii <eliz@gnu.org>
1927
be18c5a5
EZ
1928 * xfns.c (unwind_create_frame) [GLYPH_DEBUG]: Adapt to changes in
1929 2008-02-22T17:42:09Z!monnier@iro.umontreal.ca.
1930
c1734fbd
EZ
1931 * xdisp.c (move_it_in_display_line_to): Record the best matching
1932 position for TO_CHARPOS while scanning the line, and restore it on
640c8776
SM
1933 exit if none of the characters scanned was an exact match.
1934 Fixes vertical-motion and pos-visible-in-window-p under bidi redisplay
a9269c18
EZ
1935 when exact match is impossible due to invisible text, and the
1936 lines are truncated.
1937
a258d627
JD
19382011-07-23 Jan Djärv <jan.h.d@swipnet.se>
1939
1940 * nsterm.m (initFrameFromEmacs): Set NSTitledWindowMask in styleMask
1941 for OSX >= 10.7.
1942
b6d5a689
EZ
19432011-07-22 Eli Zaretskii <eliz@gnu.org>
1944
0f74f785
EZ
1945 Fix a significant slow-down of cursor motion with C-n, C-p,
1946 C-f/C-b, and C-v/M-v that couldn't keep up with keyboard
1947 auto-repeat under bidi redisplay in fontified buffers.
b6d5a689 1948 * xdisp.c (compute_stop_pos_backwards): New function.
b6d5a689
EZ
1949 (next_element_from_buffer): Call compute_stop_pos_backwards to
1950 find a suitable prev_stop when we find ourselves before
0f74f785
EZ
1951 base_level_stop.
1952 (reseat): Don't look for prev_stop, as that could mean a very long
1953 run.
1954 <cached_disp_pos, cached_disp_buffer, cached_disp_modiff>
1955 <cached_disp_overlay_modiff>: Cache for last found display string
1956 position.
551918c1 1957 (compute_display_string_pos): Return the cached position if asked
0f74f785
EZ
1958 about the same buffer in the same area of character positions, and
1959 the buffer wasn't changed since the time the display string
1960 position was cached.
551918c1 1961
b2d0c91a
EZ
19622011-07-22 Eli Zaretskii <eliz@gnu.org>
1963
1964 * xdisp.c (rows_from_pos_range): Don't ignore glyphs whose object
1965 is an integer, which is important for empty lines. (Bug#9149)
1966
043604ee
CY
19672011-07-22 Chong Yidong <cyd@stupidchicken.com>
1968
1969 * frame.c (Fmodify_frame_parameters): In tty case, update the
1970 default face if necessary (Bug#4238).
1971
da4adb04
CY
19722011-07-21 Chong Yidong <cyd@stupidchicken.com>
1973
1974 * editfns.c (Fstring_to_char): No need to explain what a character
1975 is in the docstring (Bug#6576).
1976
9abd0532
LMI
19772011-07-20 Lars Magne Ingebrigtsen <larsi@gnus.org>
1978
1979 * xml.c (parse_region): Make sure we always return a tree.
1980
36881d16
HK
19812011-07-20 HAMANO Kiyoto <khiker.mail@gmail.com>
1982
1983 * xml.c (parse_region): If a document contains only comments,
1984 return that, too.
1985
1e98674d
LMI
19862011-07-20 Lars Magne Ingebrigtsen <larsi@gnus.org>
1987
1988 * xml.c (make_dom): Return comments, too.
1989
590bd467
PE
19902011-07-19 Paul Eggert <eggert@cs.ucla.edu>
1991
1992 Port to OpenBSD.
1993 See http://lists.gnu.org/archive/html/emacs-devel/2011-07/msg00688.html
1994 and the surrounding thread.
1995 * minibuf.c (read_minibuf_noninteractive): Rewrite to use getchar
1996 rather than fgets, and retry after EINTR. Otherwise, 'emacs
1997 --batch -f byte-compile-file' fails on OpenBSD if an inactivity
1998 timer goes off.
1999 * s/openbsd.h (BROKEN_SIGIO): Define.
2000 * unexelf.c (unexec) [__OpenBSD__]:
2001 Don't update the .mdebug section of the Alpha COFF symbol table.
2002
f41628b2
LMI
20032011-07-19 Lars Magne Ingebrigtsen <larsi@gnus.org>
2004
2005 * lread.c (syms_of_lread): Clarify when `lexical-binding' is used
2006 (bug#8460).
2007
b59b67c5
PE
20082011-07-18 Paul Eggert <eggert@cs.ucla.edu>
2009
15e3a074
PE
2010 * fileio.c (Fcopy_file) [!MSDOS]: Tighten created file's mask.
2011 This fixes some race conditions on the permissions of any newly
2012 created file.
2013
41bed37d
PE
2014 * alloc.c (valid_pointer_p): Use pipe, not open.
2015 This fixes some permissions issues when debugging.
2016
b59b67c5
PE
2017 * fileio.c (Fcopy_file): Adjust mode if fchown fails. (Bug#9002)
2018 If fchown fails to set both uid and gid, try to set just gid,
2019 as that is sometimes allowed. Adjust the file's mode to eliminate
2020 setuid or setgid bits that are inappropriate if fchown fails.
2021
925a6be7
SM
20222011-07-18 Stefan Monnier <monnier@iro.umontreal.ca>
2023
2024 * xdisp.c (next_element_from_string, next_element_from_buffer): Use EQ
2025 to compare Lisp_Objects.
2026 * gnutls.c (syms_of_gnutls): Rename Vgnutls_log_level to
2027 global_gnutls_log_level, don't mistake it for a Lisp_Object.
2028 (init_gnutls_functions, emacs_gnutls_handle_error): Fix up uses.
2029
52968808
AS
20302011-07-17 Andreas Schwab <schwab@linux-m68k.org>
2031
0a6a104b
AS
2032 * lread.c (read_integer): Unread even EOF character.
2033 (read1): Likewise. Properly record start position of symbol.
2034
52968808
AS
2035 * lread.c (read1): Read `#:' as empty uninterned symbol if no
2036 symbol character follows.
2037
9e381cdd
PE
20382011-07-17 Paul Eggert <eggert@cs.ucla.edu>
2039
2040 * fileio.c (Fcopy_file): Pacify gcc re fchown. (Bug#9002)
2041 This works around a problem with the previous change to Fcopy_file.
2042 Recent glibc declares fchown with __attribute__((warn_unused_result)),
2043 and without this change, GCC might complain about discarding
2044 fchown's return value.
2045
b5641435
JB
20462011-07-16 Juanma Barranquero <lekktu@gmail.com>
2047
2048 * makefile.w32-in (GLOBAL_SOURCES): Add gnutls.c (followup to bug#9059).
2049
a8031457
PE
20502011-07-16 Paul Eggert <eggert@cs.ucla.edu>
2051
2052 * fileio.c (Fcopy_file): Don't diagnose fchown failures. (Bug#9002)
2053
dd889327
LMI
20542011-07-16 Lars Magne Ingebrigtsen <larsi@gnus.org>
2055
750c33f7
LMI
2056 * gnutls.c (syms_of_gnutls): Define `gnutls-log-level' here, since
2057 it's used from the C level.
2058
dd889327
LMI
2059 * process.c: Use the same condition for POLL_FOR_INPUT in both
2060 keyboard.c and process.c (bug#1858).
2061
87e86684
LM
20622011-07-09 Lawrence Mitchell <wence@gmx.li>
2063
2064 * gnutls.c (Qgnutls_bootprop_min_prime_bits): New variable.
2065 (Fgnutls_boot): Use it.
2066
64348f40
AS
20672011-07-15 Andreas Schwab <schwab@linux-m68k.org>
2068
2069 * doc.c (Fsubstitute_command_keys): Revert last change.
2070
1d698799
LMI
20712011-07-15 Lars Magne Ingebrigtsen <larsi@gnus.org>
2072
f863868c
LMI
2073 * doc.c (Fsubstitute_command_keys): Clarify that \= really only
2074 quotes the next character, and doesn't affect other longer
2075 sequences (bug#8935).
2076
1d698799
LMI
2077 * lread.c (syms_of_lread): Clarify that is isn't only
2078 `eval-buffer' and `eval-defun' that's affected by
2079 `lexical-binding' (bug#8460).
2080
aa4b6df6
EZ
20812011-07-15 Eli Zaretskii <eliz@gnu.org>
2082
2083 * xdisp.c (move_it_in_display_line_to): Fix vertical motion with
6b02f655 2084 bidi redisplay when a line includes both an image and is truncated.
aa4b6df6 2085
5d856da6
PE
20862011-07-14 Paul Eggert <eggert@cs.ucla.edu>
2087
ad6042bb
PE
2088 Fix minor problems found by static checking.
2089 * bidi.c (bidi_cache_size): Now EMACS_INT, not size_t.
2090 (elsz): Now a signed constant, not a size_t var. We prefer signed
2091 types to unsigned, to avoid integer comparison confusion. Without
2092 this change, GCC 4.6.1 with -Wunsafe-loop-optimizations complains
2093 "cannot optimize loop, the loop counter may overflow", a symptom
2094 of the confusion.
f00bbb22 2095 * indent.c (Fvertical_motion): Mark locals as initialized.
5d856da6
PE
2096 * xdisp.c (reseat_to_string): Fix pointer signedness issue.
2097
6468f31c
LMI
20982011-07-14 Lars Magne Ingebrigtsen <larsi@gnus.org>
2099
49080b10
LMI
2100 * search.c (Fre_search_backward): Mention `case-fold-search' in
2101 all the re_search_* functions (bug#8138).
2102
6468f31c
LMI
2103 * keyboard.c (Fopen_dribble_file): Document when the file is
2104 closed (bug#8056).
2105
c965adc5
EZ
21062011-07-14 Eli Zaretskii <eliz@gnu.org>
2107
df9733bf
EZ
2108 * bidi.c (bidi_dump_cached_states): Fix format of displaying
2109 bidi_cache_idx.
2110
0bb23927
EZ
2111 Support bidi reordering of display and overlay strings.
2112 * xdisp.c (compute_display_string_pos)
2113 (compute_display_string_end): Accept additional argument STRING.
2114 (init_iterator, reseat_1): Initialize bidi_it->string.s to NULL.
2115 (reseat_to_string): Initialize bidi_it->string.s and
2116 bidi_it->string.schars.
2117 (Fcurrent_bidi_paragraph_direction): Initialize itb.string.s to
640c8776
SM
2118 NULL (avoids a crash in bidi_paragraph_init).
2119 Initialize itb.string.lstring.
0bb23927
EZ
2120 (init_iterator): Call bidi_init_it only of a valid
2121 buffer position was specified. Initialize paragraph_embedding to
2122 L2R.
2123 (reseat_to_string): Initialize the bidi iterator.
2124 (display_string): If we need to ignore text properties of
2125 LISP_STRING, set IT->stop_charpos to IT->end_charpos. (The
2126 original value of -1 will not work with bidi.)
2127 (compute_display_string_pos): First arg is now struct
2128 `text_pos *'; all callers changed. Support display properties on
2129 Lisp strings.
2130 (compute_display_string_end): Support display properties on Lisp
2131 strings.
2132 (init_iterator, reseat_1, reseat_to_string): Initialize the
2133 string.bufpos member to 0 (zero, for compatibility with IT_CHARPOS
2134 when iterating on a string not from display properties).
640c8776
SM
2135 (compute_display_string_pos, compute_display_string_end):
2136 Fix calculation of the object to scan. Fixes an error when using
0bb23927
EZ
2137 arrow keys.
2138 (next_element_from_buffer): Don't abort when IT_CHARPOS is before
640c8776
SM
2139 base_level_stop; instead, set base_level_stop to BEGV.
2140 Fixes crashes in vertical-motion.
0bb23927
EZ
2141 (next_element_from_buffer): Improve commentary for when
2142 the iterator is before prev_stop.
2143 (init_iterator): Initialize bidi_p from the default value of
2144 bidi-display-reordering, not from buffer-local value. Use the
2145 buffer-local value only if initializing for buffer iteration.
2146 (handle_invisible_prop): Support invisible properties on strings
2147 that are being bidi-reordered.
2148 (set_iterator_to_next): Support bidi reordering of C strings and
2149 Lisp strings.
2150 (next_element_from_string): Support bidi reordering of Lisp
2151 strings.
2152 (handle_stop_backwards): Support Lisp strings as well.
640c8776
SM
2153 (display_string): Support display of R2L glyph rows.
2154 Use IT_STRING_CHARPOS when displaying from a Lisp string.
0bb23927
EZ
2155 (init_iterator): Don't initialize it->bidi_p for strings
2156 here.
2157 (reseat_to_string): Initialize it->bidi_p for strings here.
2158 (next_element_from_string, next_element_from_c_string)
2159 (next_element_from_buffer): Add xassert's for correspondence
2160 between IT's object being iterated and it->bidi_it.string
2161 structure.
2162 (face_before_or_after_it_pos): Support bidi iteration.
2163 (next_element_from_c_string): Handle the case of the first string
2164 character that is not the first one in the visual order.
2165 (get_visually_first_element): New function, refactored from common
2166 parts of next_element_from_buffer, next_element_from_string, and
2167 next_element_from_c_string.
2168 (tool_bar_lines_needed, redisplay_tool_bar)
2169 (display_menu_bar): Force left-to-right direction. Add a FIXME
2170 comment for making that be controlled by a user option.
2171 (push_it, pop_it): Save and restore the state of the
2172 bidi iterator. Save and restore the bidi_p flag.
2173 (pop_it): Iterate out of display property for string iteration as
2174 well.
2175 (iterate_out_of_display_property): Support iteration over strings.
2176 (handle_single_display_spec): Set up it->bidi_it for iteration
2177 over a display string, and call bidi_init_it.
2178 (handle_single_display_spec, next_overlay_string)
2179 (get_overlay_strings_1, push_display_prop): Set up the bidi
2180 iterator for displaying display or overlay strings.
2181 (forward_to_next_line_start): Don't use the shortcut if
2182 bidi-iterating.
2183 (back_to_previous_visible_line_start): If handle_display_prop
2184 pushed the iterator stack, restore the internal state of the bidi
2185 iterator by calling bidi_pop_it same number of times.
2186 (reseat_at_next_visible_line_start): If ON_NEWLINE_P is non-zero,
2187 and we are bidi-iterating, don't decrement the iterator position;
2188 instead, set the first_elt flag in the bidi iterator, to produce
2189 the same effect.
2190 (reseat_1): Remove redundant setting of string_from_display_prop_p.
2191 (push_display_prop): xassert that we are iterating a buffer.
2192 (push_it, pop_it): Save and restore paragraph_embedding member.
2193 (handle_single_display_spec, next_overlay_string)
2194 (get_overlay_strings_1, reseat_1, reseat_to_string)
2195 (push_display_prop): Set up the `unibyte' member of bidi_it.string
2196 correctly. Don't assume unibyte strings are not bidi-reordered.
2197 (compute_display_string_pos)
2198 (compute_display_string_end): Fix handling the case of C string.
2199 (push_it, pop_it): Save and restore from_disp_prop_p.
2200 (handle_single_display_spec, push_display_prop): Set the
2201 from_disp_prop_p flag.
2202 (get_overlay_strings_1): Reset the from_disp_prop_p flag.
2203 (pop_it): Call iterate_out_of_display_property only if we are
2204 popping after iteration over a string that came from a display
2205 property. Fix a typo in popping stretch info. Add an assertion
2206 for verifying that the iterator position is in sync with the bidi
2207 iterator.
2208 (handle_single_display_spec, get_overlay_strings_1)
2209 (push_display_prop): Fix initialization of paragraph direction for
2210 string when that of the parent object is not yet determined.
2211 (reseat_1): Call bidi_init_it to resync the bidi
2212 iterator with IT's position. (Bug#7616)
2213 (find_row_edges): If ROW->start.pos gives position
2214 smaller than min_pos, use it as ROW->minpos. (Bug#7616)
2215 (handle_stop, back_to_previous_visible_line_start, reseat_1):
2216 Reset the from_disp_prop_p flag.
2217 (SAVE_IT, RESTORE_IT): New macros.
2218 (pos_visible_p, face_before_or_after_it_pos)
2219 (back_to_previous_visible_line_start)
2220 (move_it_in_display_line_to, move_it_in_display_line)
2221 (move_it_to, move_it_vertically_backward, move_it_by_lines)
2222 (try_scrolling, redisplay_window, display_line): Use them when
2223 saving a temporary copy of the iterator and restoring it back.
2224 (back_to_previous_visible_line_start, reseat_1)
2225 (init_iterator): Empty the bidi cache "stack".
2226 (move_it_in_display_line_to): If iterator ended up at
2227 EOL, but we never saw any buffer positions smaller than
2228 to_charpos, return MOVE_POS_MATCH_OR_ZV. Fixes vertical cursor
2229 motion in bidi-reordered lines.
2230 (move_it_in_display_line_to): Record prev_method and prev_pos
2231 immediately before the call to set_iterator_to_next. Fixes cursor
2232 motion in bidi-reordered lines with stretch glyphs and strings
2233 displayed in margins. (Bug#8133) (Bug#8867)
2234 Return MOVE_POS_MATCH_OR_ZV only if iterator position is past
2235 TO_CHARPOS.
640c8776
SM
2236 (pos_visible_p): Support positions in bidi-reordered lines.
2237 Save and restore bidi cache.
0bb23927
EZ
2238
2239 * bidi.c (bidi_level_of_next_char): clen should be EMACS_NT, not int.
2240 (bidi_paragraph_info): Delete unused struct.
2241 (bidi_cache_idx, bidi_cache_last_idx): Declare EMACS_INT.
2242 (bidi_cache_start): New variable.
2243 (bidi_cache_reset): Reset bidi_cache_idx to bidi_cache_start, not
2244 to zero.
2245 (bidi_cache_fetch_state, bidi_cache_search)
2246 (bidi_cache_find_level_change, bidi_cache_iterator_state)
2247 (bidi_cache_find, bidi_peek_at_next_level)
2248 (bidi_level_of_next_char, bidi_find_other_level_edge)
2249 (bidi_move_to_visually_next): Compare cache index with
2250 bidi_cache_start rather than with zero.
2251 (bidi_fetch_char): Accept new argument STRING; all callers
2252 changed. Support iteration over a string. Support strings with
2253 display properties. Support unibyte strings. Fix the type of
2254 `len' according to what STRING_CHAR_AND_LENGTH expects.
2255 (bidi_paragraph_init, bidi_resolve_explicit_1)
2256 (bidi_resolve_explicit, bidi_resolve_weak)
640c8776
SM
2257 (bidi_level_of_next_char, bidi_move_to_visually_next):
2258 Support iteration over a string.
0bb23927
EZ
2259 (bidi_set_sor_type, bidi_resolve_explicit_1)
2260 (bidi_resolve_explicit, bidi_type_of_next_char): ignore_bn_limit
2261 can now be zero (for strings); special values 0 and -1 were
2262 changed to -1 and -2, respectively.
2263 (bidi_char_at_pos): New function.
2264 (bidi_paragraph_init, bidi_resolve_explicit, bidi_resolve_weak):
2265 Call it instead of FETCH_MULTIBYTE_CHAR.
2266 (bidi_move_to_visually_next): Abort if charpos or bytepos were not
2267 initialized to valid values.
2268 (bidi_init_it): Don't initialize charpos and bytepos with invalid
2269 values.
2270 (bidi_level_of_next_char): Allow the sentinel "position" to pass
2271 the test for valid cached positions. Fix the logic for looking up
2272 the sentinel state in the cache. GCPRO the Lisp string we are
2273 iterating.
2274 (bidi_push_it, bidi_pop_it): New functions.
2275 (bidi_initialize): Initialize the bidi cache start stack pointer.
2276 (bidi_cache_ensure_space): New function, refactored from part of
2277 bidi_cache_iterator_state. Don't assume the required size is just
2278 one BIDI_CACHE_CHUNK away.
2279 (bidi_cache_start_stack, bidi_push_it): Use IT_STACK_SIZE.
2280 (bidi_count_bytes, bidi_char_at_pos): New functions.
2281 (bidi_cache_search): Don't assume bidi_cache_last_idx is
2282 always valid if bidi_cache_idx is valid.
2283 (bidi_cache_find_level_change): xassert that bidi_cache_last_idx
2284 is valid if it's going to be used.
2285 (bidi_shelve_cache, bidi_unshelve_cache): New functions.
2286 (bidi_cache_fetch_state, bidi_cache_search)
c965adc5
EZ
2287 (bidi_cache_find_level_change, bidi_cache_ensure_space)
2288 (bidi_cache_iterator_state, bidi_cache_find)
640c8776
SM
2289 (bidi_find_other_level_edge, bidi_cache_start_stack):
2290 All variables related to cache indices are now EMACS_INT.
c965adc5 2291
0bb23927
EZ
2292 * dispextern.h (struct bidi_string_data): New structure.
2293 (struct bidi_it): New member `string'. Make flag members be 1-bit
2294 fields, and put them last in the struct.
640c8776
SM
2295 (compute_display_string_pos, compute_display_string_end):
2296 Update prototypes.
0bb23927
EZ
2297 (bidi_push_it, bidi_pop_it): Add prototypes.
2298 (struct iterator_stack_entry): New members bidi_p,
2299 paragraph_embedding, and from_disp_prop_p.
2300 (struct it): Member bidi_p is now a bit field 1 bit wide.
640c8776
SM
2301 (bidi_shelve_cache, bidi_unshelve_cache):
2302 Declare prototypes.
0bb23927
EZ
2303
2304 * .gdbinit (xvectype, xvector, xcompiled, xchartable, xboolvector)
2305 (xpr, xfont, xbacktrace): Use "header.size" when accessing vectors
2306 and vector-like objects.
2307
2308 * dispnew.c (buffer_posn_from_coords): Save and restore the bidi
2309 cache around display iteration.
2310
2311 * window.c (Fwindow_end, window_scroll_pixel_based)
2312 (displayed_window_lines, Frecenter): Save and restore the bidi
2313 cache around display iteration.
2314
3bbd2265
LMI
23152011-07-14 Lars Magne Ingebrigtsen <larsi@gnus.org>
2316
2317 * editfns.c (Fdelete_region): Clarify the use of the named
2318 parameters (bug#6788).
2319
adc47434
MR
23202011-07-14 Martin Rudalics <rudalics@gmx.at>
2321
2322 * indent.c (Fvertical_motion): Set and restore w->pointm when
2323 saving and restoring the window's buffer (Bug#9006).
2324
837c31f8
LMI
23252011-07-13 Lars Magne Ingebrigtsen <larsi@gnus.org>
2326
2327 * editfns.c (Fstring_to_char): Clarify just what is returned
2328 (bug#6576). Text by Eli Zaretskii.
2329
ac389d0c
JB
23302011-07-13 Juanma Barranquero <lekktu@gmail.com>
2331
2332 * gnutls.c (init_gnutls_functions): Honor gnutls_log_level (bug#9059).
2333
0be0ce47
EZ
23342011-07-13 Eli Zaretskii <eliz@gnu.org>
2335
2336 * buffer.c (mmap_find): Fix a typo.
2337
cd18e7e3
JB
23382011-07-13 Johan Bockgård <bojohan@gnu.org>
2339
2340 Fix execution of x selection hooks.
2341 * xselect.c (Qx_lost_selection_functions)
2342 (Qx_sent_selection_functions): New vars.
2343 (syms_of_xselect): DEFSYM them.
2344 (x_handle_selection_request): Pass Qx_sent_selection_functions
2345 rather than Vx_sent_selection_functions to Frun_hook_with_args.
2346 (x_handle_selection_clear,x_clear_frame_selections):
2347 Pass Qx_lost_selection_functions rather than
2348 Vx_lost_selection_functions to Frun_hook_with_args.
2349
47ea7f44
PE
23502011-07-13 Paul Eggert <eggert@cs.ucla.edu>
2351
ac389d0c 2352 * buffer.c (Fget_buffer_create): Initialize inhibit_shrinking.
2941c447
PE
2353 The old code sometimes used this field without initializing it.
2354
47ea7f44
PE
2355 * alloc.c (gc_sweep): Don't read past end of array.
2356 In theory, the old code could also have corrupted Emacs internals,
2357 though it'd be very unlikely.
2358
bc985c87
AS
23592011-07-12 Andreas Schwab <schwab@linux-m68k.org>
2360
2361 * character.c (Fcharacterp): Don't advertise optional ignored
ac389d0c 2362 argument. (Bug#4026)
bc985c87 2363
0cf34688
LMI
23642011-07-12 Lars Magne Ingebrigtsen <larsi@gnus.org>
2365
b3dadd76
LMI
2366 * keymap.c (syms_of_keymap): Clarify that "modifier" is "modifier
2367 key" (bug#4257).
2368
0cf34688
LMI
2369 * window.c (Fset_window_start): Doc fix (bug#4199).
2370 (Fset_window_hscroll): Ditto.
2371
270768cd
PE
23722011-07-12 Paul Eggert <eggert@cs.ucla.edu>
2373
077e3dda 2374 Fix minor new problems caught by GCC 4.6.1.
270768cd 2375 * term.c (init_tty): Remove unused local.
490011a6 2376 * xsettings.c (store_monospaced_changed): Define this function only
077e3dda 2377 if (defined HAVE_GSETTINGS || defined HAVE_GCONF), as it's
490011a6 2378 not used otherwise.
270768cd 2379
b1f58454
CY
23802011-07-12 Chong Yidong <cyd@stupidchicken.com>
2381
2382 * xdisp.c (Vresize_mini_windows): Minor doc fix (Bug#3300).
2383
22b9578d
LMI
23842011-07-11 Lars Magne Ingebrigtsen <larsi@gnus.org>
2385
6e70ab07
LMI
2386 * xdisp.c (syms_of_xdisp): Make it explicit that the mini-windows
2387 are the mini-buffer and the echo area (bug#3320).
2388
22b9578d
LMI
2389 * term.c (init_tty): Remove support for supdup, c10 and perq
2390 terminals, which are no longer supported (bug#1482).
2391
8974cc9f
JB
23922011-07-10 Johan Bockgård <bojohan@gnu.org>
2393
2394 * xdisp.c (Ftool_bar_lines_needed): Fix WINDOWP check.
2395
a560d974
JD
23962011-07-10 Jan Djärv <jan.h.d@swipnet.se>
2397
2398 * xmenu.c (menu_highlight_callback): Only pass frame to show_help_event
2399 for non-popups (Bug#3642).
2400
1dae0f0a
AS
24012011-07-10 Andreas Schwab <schwab@linux-m68k.org>
2402
268c2c36 2403 * alloc.c (reset_malloc_hooks): Protoize.
1dae0f0a 2404 * buffer.c (mmap_init, mmap_find, mmap_free_1, mmap_enlarge)
268c2c36
AS
2405 (mmap_set_vars, mmap_alloc, mmap_free, mmap_realloc): Likewise.
2406 * cm.c (losecursor): Likewise.
1dae0f0a
AS
2407 * data.c (fmod): Likewise.
2408 * dispnew.c (swap_glyphs_in_rows): Likewise.
2409 * emacs.c (memory_warning_signal): Likewise.
2410 * floatfns.c (float_error): Likewise.
2411 * font.c (check_gstring, check_otf_features, otf_tag_symbol)
2412 (otf_open, font_otf_capability, generate_otf_features)
2413 (font_otf_DeviceTable, font_otf_ValueRecord, font_otf_Anchor):
2414 Likewise.
2415 * image.c (pbm_read_file): Likewise.
2416 * indent.c (string_display_width): Likewise.
2417 * intervals.c (check_for_interval, search_for_interval)
2418 (inc_interval_count, count_intervals, root_interval)
2419 (adjust_intervals_for_insertion, make_new_interval): Likewise.
2420 * lread.c (defalias): Likewise.
268c2c36 2421 * ralloc.c (r_alloc_check): Likewise.
1dae0f0a
AS
2422 * regex.c (set_image_of_range_1, set_image_of_range)
2423 (regex_grow_registers): Likewise.
2424 * sysdep.c (strerror): Likewise.
2425 * termcap.c (valid_filename_p, tprint, main): Likewise.
2426 * tparam.c (main): Likewise.
2427 * unexhp9k800.c (run_time_remap, save_data_space)
2428 (update_file_ptrs, read_header, write_header, calculate_checksum)
2429 (copy_file, copy_rest, display_header): Likewise.
2430 * widget.c (mark_shell_size_user_specified, create_frame_gcs):
2431 Likewise.
2432 * xdisp.c (check_it): Likewise.
2433 * xfaces.c (register_color, unregister_color, unregister_colors):
2434 Likewise.
2435 * xfns.c (print_fontset_result): Likewise.
2436 * xrdb.c (member, fatal, main): Likewise.
2437
99033785
PE
24382011-07-10 Paul Eggert <eggert@cs.ucla.edu>
2439
2440 Fix minor problems found by static checking (Bug#9031).
2441 * chartab.c (char_table_set_range, map_sub_char_table):
2442 Remove unused locals.
2443 (uniprop_table): Now static.
2444 * composite.c (_work_char): Remove unused static var.
2445
9cb2ac56
JB
24462011-07-09 Juanma Barranquero <lekktu@gmail.com>
2447
2448 * chartab.c (uniprop_table_uncompress): Remove unused local variable.
2449
f25661f0
JD
24502011-07-09 Jan Djärv <jan.h.d@swipnet.se>
2451
2452 * gtkutil.c (qttip_cb): Remove code without function.
2453
8278c4fe
EZ
24542011-07-09 Eli Zaretskii <eliz@gnu.org>
2455
2456 * w32.c (pthread_sigmask): New stub.
2457
1692ae2d 24582011-07-08 Paul Eggert <eggert@cs.ucla.edu>
123403e4 2459
8a6ebd58 2460 Use pthread_sigmask, not sigprocmask (Bug#9010).
123403e4
PE
2461 sigprocmask is portable only for single-threaded applications, and
2462 Emacs can be multi-threaded when it uses GTK.
1301ac26
PE
2463 * Makefile.in (LIB_PTHREAD_SIGMASK): New macro.
2464 (LIBES): Use it.
2465 * callproc.c (Fcall_process):
2466 * process.c (create_process):
2467 * sysdep.c (sys_sigblock, sys_sigunblock, sys_sigsetmask):
2468 Use pthread_sigmask, not sigprocmask.
123403e4 2469
1b854618
JD
24702011-07-08 Jan Djärv <jan.h.d@swipnet.se>
2471
2472 * gtkutil.c (qttip_cb): Set line wrap to FALSE for tooltip widget.
2473 (xg_prepare_tooltip): Revert text in x->ttip_lbl, margins was
2474 wrong (Bug#8591).
2475
3fe4b549
JD
24762011-07-08 Jan Djärv <jan.h.d@swipnet.se>
2477
0ce7e563
JD
2478 * gtkutil.c (xg_prepare_tooltip): Fix indentation and comment.
2479 Put text in x->ttip_lbl instead of gtk_tooltip_set_text (Bug#8591).
2480 (xg_hide_tooltip): Fix comment.
2481
3fe4b549
JD
2482 * nsterm.m (initFrameFromEmacs): Don't use ns_return_types
2483 in registerServicesMenuSendTypes.
2484 (validRequestorForSendType): Don't check ns_return_types.
2485
2486 * nsfns.m (Fx_open_connection): Put NSStringPboardType into
2487 ns_return_type.
2488
5df75e47
JR
24892011-07-08 Jason Rumney <jasonr@gnu.org>
2490
2491 * w32fns.c (w32_wnd_proc) [WM_TIMER, WM_SET_CURSOR]: Avoid using
2492 frame struct members of non-existent frames (Bug#6284).
2493
699c10bd
JD
24942011-07-08 Jan Djärv <jan.h.d@swipnet.se>
2495
4393663b
JD
2496 * nsterm.m (keyDown): Call to wantsToDelayTextChangeNotifications and
2497 variable firstTime not needed on OSX >= 10.6.
2498 (setPosition): setFloatValue:knobProportion: is deprecated on OSX
2499 >= 10.5. Use setKnobProportion, setDoubleValue.
2500
2501 * nsterm.h (MAC_OS_X_VERSION_10_3, MAC_OS_X_VERSION_10_4)
2502 (MAC_OS_X_VERSION_10_5): Define if not defined.
2503 (EmacsView, EmacsTooltip): Implements NSWindowDelegate on OSX >= 10.6.
2504 (EmacsMenu): Implements NSMenuDelegate on OSX >= 10.6.
2505 (EmacsToolbar): Implements NSToolbarDelegate on OSX >= 10.6.
2506
2507 * nsselect.m (ns_string_from_pasteboard): Don't use deprecated methods
2508 cString and lossyCString on OSX >= 10.4
2509
2510 * nsmenu.m (fillWithWidgetValue): Don't use depercated method
2511 sizeToFit on OSX >= 10.2.
2512
2513 * nsimage.m (allocInitFromFile): Don't use deprecated method
2514 bestRepresentationForDevice on OSX >= 10.6.
2515
2516 * nsfns.m (check_ns_display_info): Cast to long and use %ld in error
2517 to avoid warning.
2518
2519 * emacs.c: Declare unexec_init_emacs_zone.
2520
a63e0781
JD
2521 * nsgui.h: Fix compiler warning about gnulib redefining verify.
2522
699c10bd
JD
2523 * nsselect.m (ns_get_local_selection): Change to extern (Bug#8842).
2524
2525 * nsmenu.m (ns_update_menubar): Remove useless setDelegate call
2526 on svcsMenu (Bug#8842).
2527
2528 * nsfns.m (Fx_open_connection): Remove NSStringPboardType from
2529 ns_return_types.
2530 (Fns_list_services): Just return Qnil on 10.6, code not working there.
2531
2532 * nsterm.m (QUTF8_STRING): Declare.
2533 (initFrameFromEmacs): Call registerServicesMenuSendTypes.
2534 (validRequestorForSendType): Return type is (id).
2535 Change indexOfObjectIdenticalTo to indexOfObject.
2536 Check if we have local selection before returning self (Bug#8842).
2537 (writeSelectionToPasteboard): Put local selection into paste board
2538 if we have a local selection (Bug#8842).
2539 (syms_of_nsterm): DEFSYM QUTF8_STRING.
2540
2541 * nsterm.h (MAC_OS_X_VERSION_10_6): Define here instead of nsterm.m.
2542 (ns_get_local_selection): Declare.
2543
54e10184
LMI
25442011-07-07 Lars Magne Ingebrigtsen <larsi@gnus.org>
2545
9888ff71
LMI
2546 * keymap.c (describe_map_tree): Don't insert a double newline at
2547 the end of the buffer (bug#1169) and return whether we inserted
2548 something.
2549
54e10184
LMI
2550 * callint.c (Fcall_interactively): Change "reading args" to
2551 "providing args" to try to clarify what it does (bug#1010).
2552
15fa4783
KH
25532011-07-07 Kenichi Handa <handa@m17n.org>
2554
2555 * composite.c (composition_compute_stop_pos): Ignore a static
2556 composition starting before CHARPOS (Bug#8915).
2557
2558 * xdisp.c (handle_composition_prop): Likewise.
2559
a8815b00
EZ
25602011-07-07 Eli Zaretskii <eliz@gnu.org>
2561
2562 * term.c (produce_glyphs) <xassert>: Allow IT_GLYPHLESS in it->what.
2563 (Bug#9015)
2564
ef7b981d 25652011-07-07 Kenichi Handa <handa@m17n.org>
c805dec0
KH
2566
2567 * character.h (unicode_category_t): New enum type.
2568
2569 * chartab.c (uniprop_decoder_t, uniprop_encoder_t): New types.
2570 (Qchar_code_property_table): New variable.
2571 (UNIPROP_TABLE_P, UNIPROP_GET_DECODER)
2572 (UNIPROP_COMPRESSED_FORM_P): New macros.
2573 (char_table_ascii): Uncompress the compressed values.
2574 (sub_char_table_ref): New arg is_uniprop. Callers changed.
2575 Uncompress the compressed values.
ac389d0c 2576 (sub_char_table_ref_and_range): Likewise.
c805dec0
KH
2577 (char_table_ref_and_range): Uncompress the compressed values.
2578 (sub_char_table_set): New arg is_uniprop. Callers changed.
2579 Uncompress the compressed values.
2580 (sub_char_table_set_range): Args changed. Callers changed.
2581 (char_table_set_range): Adjuted for the above change.
2582 (map_sub_char_table): Delete args default_val and parent. Add arg
2583 top. Give decoded values to a Lisp function.
640c8776 2584 (map_char_table): Adjust for the above change. Give decoded
c805dec0
KH
2585 values to a Lisp function. Gcpro more variables.
2586 (uniprop_table_uncompress)
2587 (uniprop_decode_value_run_length): New functions.
2588 (uniprop_decoder, uniprop_decoder_count): New variables.
2589 (uniprop_get_decoder, uniprop_encode_value_character)
2590 (uniprop_encode_value_run_length, uniprop_encode_value_numeric):
2591 New functions.
2592 (uniprop_encoder, uniprop_encoder_count): New variables.
2593 (uniprop_get_encoder, uniprop_table)
2594 (Funicode_property_table_internal, Fget_unicode_property_internal)
2595 (Fput_unicode_property_internal): New functions.
2596 (syms_of_chartab): DEFSYM Qchar_code_property_table, defsubr
2597 Sunicode_property_table_internal, Sget_unicode_property_internal,
5e617bc2 2598 and Sput_unicode_property_internal. Defvar_lisp
c805dec0
KH
2599 char-code-property-alist.
2600
640c8776 2601 * composite.c (CHAR_COMPOSABLE_P): Adjust for the change of
c805dec0
KH
2602 Vunicode_category_table.
2603
640c8776 2604 * font.c (font_range): Adjust for the change of
c805dec0
KH
2605 Vunicode_category_table.
2606
76b397fb
DN
26072011-07-07 Dan Nicolaescu <dann@ics.uci.edu>
2608
2609 * m/iris4d.h: Remove file, move contents ...
2610 * s/irix6-5.h: ... here.
2611
22b4128e
PE
26122011-07-06 Paul Eggert <eggert@cs.ucla.edu>
2613
2614 Remove unportable assumption about struct layout (Bug#8884).
8a5c77bb
PE
2615 * alloc.c (mark_buffer):
2616 * buffer.c (reset_buffer_local_variables, Fbuffer_local_variables)
2617 (clone_per_buffer_values): Don't assume that
22b4128e
PE
2618 sizeof (struct buffer) is a multiple of sizeof (Lisp_Object).
2619 This isn't true in general, and it's particularly not true
2620 if Emacs is configured with --with-wide-int.
2621 * buffer.h (FIRST_FIELD_PER_BUFFER, LAST_FIELD_PER_BUFFER):
2622 New macros, used in the buffer.c change.
2623
869795d6
JD
26242011-07-05 Jan Djärv <jan.h.d@swipnet.se>
2625
2626 * xsettings.c: Use both GConf and GSettings if both are available.
2627 (store_config_changed_event): Add comment.
2628 (dpyinfo_valid, store_font_name_changed, map_tool_bar_style)
2629 (store_tool_bar_style_changed): New functions.
5e617bc2 2630 (store_monospaced_changed): Add comment. Call dpyinfo_valid.
869795d6
JD
2631 (struct xsettings): Move font inside HAVE_XFT.
2632 (GSETTINGS_TOOL_BAR_STYLE, GSETTINGS_FONT_NAME): New defines.
640c8776 2633 (GSETTINGS_MONO_FONT): Rename from SYSTEM_MONO_FONT.
869795d6 2634 Move inside HAVE_XFT.
640c8776 2635 (something_changed_gsettingsCB): Rename from something_changedCB.
869795d6
JD
2636 Check for changes in GSETTINGS_TOOL_BAR_STYLE and GSETTINGS_FONT_NAME
2637 also.
2638 (GCONF_TOOL_BAR_STYLE, GCONF_FONT_NAME): New defines.
5e617bc2 2639 (GCONF_MONO_FONT): Rename from SYSTEM_MONO_FONT. Move inside HAVE_XFT.
640c8776 2640 (something_changed_gconfCB): Rename from something_changedCB.
869795d6
JD
2641 Check for changes in GCONF_TOOL_BAR_STYLE and GCONF_FONT_NAME also.
2642 (parse_settings): Move check for font inside HAVE_XFT.
2643 (read_settings, apply_xft_settings): Add comment.
2644 (read_and_apply_settings): Add comment. Call map_tool_bar_style and
2645 store_tool_bar_style_changed. Move check for font inside HAVE_XFT and
2646 call store_font_name_changed.
2647 (xft_settings_event): Add comment.
2648 (init_gsettings): Add comment. Get values for GSETTINGS_TOOL_BAR_STYLE
2649 and GSETTINGS_FONT_NAME. Move check for fonts within HAVE_XFT.
2650 (init_gconf): Add comment. Get values for GCONF_TOOL_BAR_STYLE
2651 and GCONF_FONT_NAME. Move check for fonts within HAVE_XFT.
2652 (xsettings_initialize): Call init_gsettings last.
640c8776
SM
2653 (xsettings_get_system_font, xsettings_get_system_normal_font):
2654 Add comment.
869795d6 2655
d8ed26bd
PE
26562011-07-05 Paul Eggert <eggert@cs.ucla.edu>
2657
2658 Random fixes. E.g., (random) never returned negative values.
2659 * fns.c (Frandom): Use GET_EMACS_TIME for random seed, and add the
2660 subseconds part to the entropy, as that's a bit more random.
2661 Prefer signed to unsigned, since the signedness doesn't matter and
2662 in general we prefer signed. When given a limit, use a
2663 denominator equal to INTMASK + 1, not to VALMASK + 1, because the
2664 latter isn't right if USE_2_TAGS_FOR_INTS.
2665 * sysdep.c (get_random): Return a value in the range 0..INTMASK,
2666 not 0..VALMASK. Don't discard "excess" bits that random () returns.
2667
cabf1cac
SM
26682011-07-04 Stefan Monnier <monnier@iro.umontreal.ca>
2669
2670 * textprop.c (text_property_stickiness):
2671 Obey Vtext_property_default_nonsticky.
2672 (syms_of_textprop): Add `display' to Vtext_property_default_nonsticky.
2673 * w32fns.c (syms_of_w32fns):
2674 * xfns.c (syms_of_xfns): Don't Add `display' since it's there by default.
2675
6e9b2be9
PE
26762011-07-04 Paul Eggert <eggert@cs.ucla.edu>
2677
2678 * fileio.c (barf_or_query_if_file_exists): Use S_ISDIR.
2679 This is more efficient than Ffile_directory_p and avoids a minor race.
2680
90186c68
LMI
26812011-07-04 Lars Magne Ingebrigtsen <larsi@gnus.org>
2682
7c301272
LMI
2683 * buffer.c (Foverlay_put): Say what the return value is
2684 (bug#7835).
2685
c4f2d8d4
LMI
2686 * fileio.c (barf_or_query_if_file_exists): Check first if the file
2687 is a directory before asking whether to use the file name
2688 (bug#7564).
ad637907
LMI
2689 (barf_or_query_if_file_exists): Make the "File is a directory"
2690 error be more correct.
c4f2d8d4 2691
90186c68
LMI
2692 * fns.c (Frequire): Remove the mention of the .gz files, since
2693 that's installation-specific, but keep the mention of
2694 `get-load-suffixes'.
2695
da64016e
PE
26962011-07-04 Paul Eggert <eggert@cs.ucla.edu>
2697
2698 * editfns.c (Fformat_time_string): Don't assume strlen fits in int.
2699 Report string overflow if the output is too long.
2700
7d47b580
JB
27012011-07-04 Juanma Barranquero <lekktu@gmail.com>
2702
a555cb87
JB
2703 * gnutls.c (Fgnutls_boot): Don't mention :verify-error.
2704 (syms_of_gnutls): Remove duplicate DEFSYM for
2705 Qgnutls_bootprop_verify_hostname_error, an error for
2706 Qgnutls_bootprop_verify_error (which is no longer used).
2707
7d47b580
JB
2708 * eval.c (find_handler_clause): Remove parameters `sig' and `data',
2709 unused since 2011-01-26T20:02:07Z!monnier@iro.umontreal.ca. All callers changed.
2710 Also (re)move comments that are misplaced or no longer relevant.
2711
1e49bfab
LMI
27122011-07-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
2713
2714 * callint.c (Finteractive): Clarify the meaning of "@" (bug#8813).
2715
1485f4c0
CY
27162011-07-03 Chong Yidong <cyd@stupidchicken.com>
2717
2718 * xfaces.c (Finternal_merge_in_global_face): Modify the foreground
2719 and background color parameters if they have been changed.
2720
a9ab721e
LMI
27212011-07-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
2722
2723 * editfns.c (Fformat): Clarify the - and 0 flags (bug#6659).
2724
cf7cff57
PE
27252011-07-03 Paul Eggert <eggert@cs.ucla.edu>
2726
2e13213d
PE
2727 * xsettings.c (SYSTEM_FONT): Define only when used.
2728 No need to define when HAVE_GSETTINGS || !HAVE_XFT.
2729
cf7cff57
PE
2730 * keymap.c (access_keymap_1): Now static.
2731
7a8e04f7
CY
27322011-07-02 Chong Yidong <cyd@stupidchicken.com>
2733
2734 * keyboard.c (command_loop_1): If a down-mouse event is unbound,
2735 leave any prefix arg for the up event (Bug#1586).
2736
61352f62
LMI
27372011-07-02 Lars Magne Ingebrigtsen <larsi@gnus.org>
2738
69bb1ef7
LMI
2739 * lread.c (syms_of_lread): Mention single symbols defined by
2740 `defvar' or `defconst' (bug#7154).
2741
61352f62 2742 * fns.c (Frequire): Mention .el.gz files (bug#7314).
7b3747f9 2743 (Frequire): Mention get-load-suffixes.
61352f62 2744
28545e04
MR
27452011-07-02 Martin Rudalics <rudalics@gmx.at>
2746
2747 * window.h (window): Remove clone_number slot.
2748 * window.c (Fwindow_clone_number, Fset_window_clone_number):
2749 Remove.
2750 (make_parent_window, make_window, saved_window)
2751 (Fset_window_configuration, save_window_save): Don't deal with
2752 clone numbers.
2753 * buffer.c (Qclone_number): Remove declaration.
2754 (sort_overlays, overlay_strings): Don't deal with clone numbers.
2755
3349e122
SM
27562011-07-02 Stefan Monnier <monnier@iro.umontreal.ca>
2757
2758 Add multiple inheritance to keymaps.
2759 * keymap.c (Fmake_composed_keymap): New function.
2760 (Fset_keymap_parent): Simplify.
2761 (fix_submap_inheritance): Remove.
2762 (access_keymap_1): New function extracted from access_keymap to handle
2763 embedded parents and handle lists of maps.
2764 (access_keymap): Use it.
2765 (Fkeymap_prompt, map_keymap_internal, map_keymap, store_in_keymap)
2766 (Fcopy_keymap): Handle embedded parents.
2767 (Fcommand_remapping, define_as_prefix): Simplify.
2768 (Fkey_binding): Simplify.
2769 (syms_of_keymap): Move minibuffer-local-completion-map,
2770 minibuffer-local-filename-completion-map,
2771 minibuffer-local-must-match-map, and
2772 minibuffer-local-filename-must-match-map to Elisp.
2773 (syms_of_keymap): Defsubr make-composed-keymap.
2774 * keyboard.c (menu_bar_items): Use map_keymap_canonical.
2775 (parse_menu_item): Trivial simplification.
2776
3279eb87
GM
27772011-07-01 Glenn Morris <rgm@gnu.org>
2778
2779 * Makefile.in (SETTINGS_LIBS): Fix typo.
2780
4550efdf
KI
27812011-07-01 Kazuhiro Ito <kzhr@d1.dion.ne.jp> (tiny patch)
2782
2783 * coding.c (Fencode_coding_string): Record the last coding system
2784 used, as the function doc string says (bug#8738).
2785
0949d2b6
JD
27862011-07-01 Jan Djärv <jan.h.d@swipnet.se>
2787
2788 * xsettings.c (store_monospaced_changed): Take new font as arg and
2789 check for change against current_mono_font.
2790 (EMACS_TYPE_SETTINGS): Remove this and related defines.
2791 (emacs_settings_constructor, emacs_settings_get_property)
2792 (emacs_settings_set_property, emacs_settings_class_init)
2793 (emacs_settings_init, gsettings_obj): Remove.
2794 (something_changedCB): New function for HAVE_GSETTINGS.
2795 (something_changedCB): HAVE_GCONF: Call store_monospaced_changed
2796 with value as argument.
2797 (init_gsettings): Check that GSETTINGS_SCHEMA exists before calling
2798 g_settings_new (Bug#8967). Do not create gsettings_obj.
9173deec 2799 Remove calls to g_settings_bind. Connect something_changedCB to
0949d2b6
JD
2800 "changed".
2801
2802 * xgselect.c: Add defined (HAVE_GSETTINGS).
2803 (xgselect_initialize): Ditto.
2804
2805 * process.c: Add defined (HAVE_GSETTINGS) for xgselect.h
2806 (wait_reading_process_output): Add defined (HAVE_GSETTINGS) for
2807 xg_select.
2808
bbc6b304
PE
28092011-07-01 Paul Eggert <eggert@cs.ucla.edu>
2810
2811 * eval.c (struct backtrace): Simplify and port the data structure.
2812 Do not assume that "int nargs : BITS_PER_INT - 2;" produces a
2813 signed bit field, as this assumption is not portable and it makes
2814 Emacs crash when compiled with Sun C 5.8 on sparc. Do not use
2815 "char debug_on_exit : 1" as this is not portable either; instead,
2816 use the portable "unsigned int debug_on_exit : 1". Remove unused
2817 member evalargs. Remove obsolete comments about cc bombing out.
2818
9851bfc5
JD
28192011-06-30 Jan Djärv <jan.h.d@swipnet.se>
2820
51bb811f 2821 * xsettings.c: Include glib-object.h, gio/gio.h if HAVE_GSETTINGS.
9851bfc5
JD
2822 Let HAVE_GSETTINGS override HAVE_GCONF.
2823 (store_monospaced_changed): New function.
2824 (EMACS_SETTINGS): A new type derived from GObject to handle
2825 GSettings notifications.
2826 (emacs_settings_constructor, emacs_settings_get_property)
2827 (emacs_settings_set_property, emacs_settings_class_init):
2828 New functions.
2829 (gsettings_client, gsettings_obj): New variables.
2830 (GSETTINGS_SCHEMA): New define.
2831 (something_changedCB): Call store_monospaced_changed.
2832 (init_gsettings): New function.
2833 (xsettings_initialize): Call init_gsettings.
2834 (syms_of_xsettings): Initialize gsettings_client, gsettings_obj
2835 to NULL.
2836
640c8776 2837 * Makefile.in (SETTINGS_CFLAGS, SETTINGS_LIBS): Rename from
9851bfc5
JD
2838 GCONF_CFLAGS/LIBS.
2839
5386012d
MR
28402011-06-29 Martin Rudalics <rudalics@gmx.at>
2841
2842 * window.c (resize_root_window, grow_mini_window)
2843 (shrink_mini_window): Rename Qresize_root_window to
2844 Qwindow_resize_root_window and Qresize_root_window_vertically to
2845 Qwindow_resize_root_window_vertically.
2846
f13e0b08
PE
28472011-06-28 Paul Eggert <eggert@cs.ucla.edu>
2848
2849 * gnutls.c (Qgnutls_bootprop_verify_error): Remove unused var.
2850
94515237
JB
28512011-06-27 Juanma Barranquero <lekktu@gmail.com>
2852
2853 * makefile.w32-in: Redesign dependencies so they reflect more
2854 clearly which files are directly included by each source file,
2855 and not through other includes.
2856
e43b6e43
MR
28572011-06-27 Martin Rudalics <rudalics@gmx.at>
2858
2859 * buffer.c (Qclone_number): Declare static and DEFSYM it.
2860 (sort_overlays, overlay_strings): When an overlay's clone number
2861 matches the window's clone number process the overlay even if
2862 the overlay's window property doesn't match the current window.
2863
d68443dc
MR
2864 * window.c (Fwindow_vchild): Rename to Fwindow_top_child.
2865 (Fwindow_hchild): Rename to Fwindow_left_child.
2866 (Fwindow_next): Rename to Fwindow_next_sibling.
2867 (Fwindow_prev): Rename to Fwindow_prev_sibling.
d615d6d2
MR
2868 (resize_window_check): Rename to window_resize_check.
2869 (resize_window_apply): Rename to window_resize_apply.
2870 (Fresize_window_apply): Rename to Fwindow_resize_apply.
2871 (Fdelete_other_windows_internal, resize_frame_windows)
2872 (Fsplit_window_internal, Fdelete_window_internal)
2873 (grow_mini_window, shrink_mini_window)
2874 (Fresize_mini_window_internal): Fix callers accordingly.
d68443dc 2875
c7e73be5
JD
28762011-06-26 Jan Djärv <jan.h.d@swipnet.se>
2877
2878 * emacsgtkfixed.h: State that this is only used with Gtk+3.
2879 (emacs_fixed_set_min_size): Remove.
2880 (emacs_fixed_new): Take frame as argument.
2881
2882 * emacsgtkfixed.c: State that this is only used with Gtk+3.
2883 (_EmacsFixedPrivate): Remove minwidth/height.
2884 Add struct frame *f.
2885 (emacs_fixed_init): Initialize priv->f.
2886 (get_parent_class, emacs_fixed_set_min_size): Remove.
2887 (emacs_fixed_new): Set priv->f to argument.
2888 (emacs_fixed_get_preferred_width)
2889 (emacs_fixed_get_preferred_height): Use min_width/height from
2890 frames size_hint to set minimum and natural (Bug#8919).
2891 (XSetWMSizeHints, XSetWMNormalHints): Override these functions
2892 and use min_width/height from frames size_hint to set
2893 min_width/height (Bug#8919).
2894
2895 * gtkutil.c (xg_create_frame_widgets): Pass f to emacs_fixed_new.
9173deec
JB
2896 (x_wm_set_size_hint): Remove call to emacs_fixed_set_min_size.
2897 Fix indentation.
c7e73be5 2898
cf99dcf8
EZ
28992011-06-26 Eli Zaretskii <eliz@gnu.org>
2900
2901 * bidi.c (bidi_paragraph_init): Test for ZV_BYTE before calling
2902 bidi_at_paragraph_end, since fast_looking_at doesn't like to be
2903 called at ZV.
2904
029529ac
CY
29052011-06-26 Chong Yidong <cyd@stupidchicken.com>
2906
2907 * process.c (wait_reading_process_output): Bypass select if
2908 waiting for a cell while ignoring keyboard input, and input is
2909 pending. Suggested by Jan Djärv (Bug#8869).
2910
7a7ef429
PE
29112011-06-25 Paul Eggert <eggert@cs.ucla.edu>
2912
2913 Use gnulib's dup2 module instead of rolling our own.
2914 * sysdep.c (dup2) [!HAVE_DUP2]: Remove; gnulib now does this.
2915
11fdef7d 29162011-06-25 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
989b42d2
YM
2917
2918 * dispnew.c (scrolling_window): Before scrolling, turn off a
2919 mouse-highlight in the window being scrolled.
2920
cd3520a4
JB
29212011-06-24 Juanma Barranquero <lekktu@gmail.com>
2922
2923 Move DEFSYM to lisp.h and use everywhere.
2924
2925 * character.h (DEFSYM): Move declaration...
2926 * lisp.h (DEFSYM): ...here.
2927
2928 * gnutls.c:
2929 * minibuf.c:
2930 * w32menu.c:
2931 * w32proc.c:
2932 * w32select.c: Don't include character.h.
2933
2934 * alloc.c (syms_of_alloc):
2935 * buffer.c (syms_of_buffer):
2936 * bytecode.c (syms_of_bytecode):
2937 * callint.c (syms_of_callint):
2938 * casefiddle.c (syms_of_casefiddle):
2939 * casetab.c (init_casetab_once):
2940 * category.c (init_category_once, syms_of_category):
2941 * ccl.c (syms_of_ccl):
2942 * cmds.c (syms_of_cmds):
2943 * composite.c (syms_of_composite):
2944 * dbusbind.c (syms_of_dbusbind):
2945 * dired.c (syms_of_dired):
2946 * dispnew.c (syms_of_display):
2947 * doc.c (syms_of_doc):
2948 * editfns.c (syms_of_editfns):
2949 * emacs.c (syms_of_emacs):
2950 * eval.c (syms_of_eval):
2951 * fileio.c (syms_of_fileio):
2952 * fns.c (syms_of_fns):
2953 * frame.c (syms_of_frame):
2954 * fringe.c (syms_of_fringe):
2955 * insdel.c (syms_of_insdel):
2956 * keymap.c (syms_of_keymap):
2957 * lread.c (init_obarray, syms_of_lread):
2958 * macros.c (syms_of_macros):
2959 * msdos.c (syms_of_msdos):
2960 * print.c (syms_of_print):
2961 * process.c (syms_of_process):
2962 * search.c (syms_of_search):
2963 * sound.c (syms_of_sound):
2964 * syntax.c (init_syntax_once, syms_of_syntax):
2965 * terminal.c (syms_of_terminal):
2966 * textprop.c (syms_of_textprop):
2967 * undo.c (syms_of_undo):
2968 * w32.c (globals_of_w32):
2969 * window.c (syms_of_window):
2970 * xdisp.c (syms_of_xdisp):
2971 * xfaces.c (syms_of_xfaces):
2972 * xfns.c (syms_of_xfns):
2973 * xmenu.c (syms_of_xmenu):
2974 * xsettings.c (syms_of_xsettings):
2975 * xterm.c (syms_of_xterm): Use DEFSYM.
2976
4228cf16
TZ
29772011-06-24 Teodor Zlatanov <tzz@lifelogs.com>
2978
cd3520a4 2979 * gnutls.c (syms_of_gnutls): Use the DEFSYM macro from character.h.
4228cf16 2980
7fcccf1e
PE
29812011-06-23 Paul Eggert <eggert@cs.ucla.edu>
2982
7efb4e0e
PE
2983 Integer and buffer overflow fixes (Bug#8873).
2984
ff5844ad
PE
2985 * print.c (printchar, strout): Check for string overflow.
2986 (PRINTPREPARE, printchar, strout):
2987 Don't set size unless allocation succeeds.
2988
90532f02
PE
2989 * minibuf.c (read_minibuf_noninteractive): Use ptrdiff_t, not int,
2990 for sizes. Check for string overflow more accurately.
2991 Simplify newline removal at end; this suppresses a GCC 4.6.0 warning.
2992
6d84508d
PE
2993 * macros.c: Integer and buffer overflow fixes.
2994 * keyboard.h (struct keyboard.kbd_macro_bufsize):
2995 * macros.c (Fstart_kbd_macro, store_kbd_macro_char):
2996 Use ptrdiff_t, not int, for sizes.
2997 Don't increment bufsize until after realloc succeeds.
2998 Check for size-calculation overflow.
2999 (Fstart_kbd_macro): Use EMACS_INT, not int, for XINT result.
3000
437b2cb4
PE
3001 * lisp.h (DEFVAR_KBOARD): Use offsetof instead of char * finagling.
3002
8b9ac8b4
PE
3003 * lread.c: Integer overflow fixes.
3004 (read_integer): Radix is now EMACS_INT, not int,
3005 to improve quality of diagnostics for out-of-range radices.
3006 Calculate buffer size correctly for out-of-range radices.
3007 (read1): Check for integer overflow in radices, and in
3008 read-circle numbers.
82cb60d3
PE
3009 (read_escape): Avoid int overflow.
3010 (Fload, openp, read_buffer_size, read1)
3011 (substitute_object_recurse, read_vector, read_list, map_obarray):
3012 Use ptrdiff_t, not int, for sizes.
3013 (read1): Use EMACS_INT, not int, for sizes.
20270765 3014 Check for size overflow.
8b9ac8b4 3015
7fcccf1e
PE
3016 * image.c (cache_image): Check for size arithmetic overflow.
3017
bfbbd7e7
PE
3018 * lread.c: Integer overflow issues.
3019 (saved_doc_string_size, saved_doc_string_length)
3020 (prev_saved_doc_string_size, prev_saved_doc_string_length):
3021 Now ptrdiff_t, not int.
3022 (read1): Don't assume doc string length fits in int. Check for
3023 out-of-range doc string lengths.
3024 (read_list): Don't assume file position fits in int.
39019e54 3025 (read_escape): Check for hex character overflow.
bfbbd7e7 3026
4e323265
LL
30272011-06-22 Leo Liu <sdl.web@gmail.com>
3028
3029 * minibuf.c (Fcompleting_read_default, Vcompleting_read_function):
3030 Move to minibuffer.el.
3031
85fece3e
PE
30322011-06-22 Paul Eggert <eggert@cs.ucla.edu>
3033
20b84ce9 3034 Fixes for GLYPH_DEBUG found by GCC 4.6.0 static checking.
85fece3e
PE
3035 The following patches are for when GLYPH_DEBUG && !XASSERT.
3036 * dispextern.h (trace_redisplay_p, dump_glyph_string):
3037 * dispnew.c (flush_stdout):
3038 * xdisp.c (dump_glyph_row, dump_glyph_matrix, dump_glyph):
3039 Mark as externally visible.
3040 * dispnew.c (check_window_matrix_pointers): Now static.
3041 * dispnew.c (window_to_frame_vpos):
3042 * xfns.c (unwind_create_frame):
3043 * xterm.c (x_check_font): Remove unused local.
3044 * scroll.c (CHECK_BOUNDS):
3045 * xfaces.c (cache_fache): Rename local to avoid shadowing.
3046 * xfns.c, w32fns.c (image_cache_refcount, dpyinfo_refcount): Now static.
3047 * xdisp.c (check_window_end): Now a no-op if !XASSERTS.
3048 (debug_first_unchanged_at_end_vpos, debug_last_unchanged_at_beg_vpos)
3049 (debug_dvpos, debug_dy, debug_delta, debug_delta_bytes, debug_end_vpos):
3050 Now static.
3051 (debug_method_add): Use va_list and vsprintf rather than relying
3052 on undefined behavior with wrong number of arguments.
3053 (dump_glyph, dump_glyph_row, Fdump_glyph_matrix):
3054 Don't assume ptrdiff_t and EMACS_INT are the same width as int.
3055 In this code, it's OK to assume C99 behavior for ptrdiff_t formats
3056 since we're not interested in debugging glyphs with old libraries.
3057 * xfaces.c (cache_face): Move debugging code earlier; this pacifies
3058 GCC 4.6.0's static checking.
3059
0766b489
PE
30602011-06-22 Paul Eggert <eggert@cs.ucla.edu>
3061
31fd4b32
PE
3062 Integer overflow and signedness fixes (Bug#8873).
3063 A few related buffer overrun fixes, too.
3064
b79e8648
PE
3065 * font.c (font_score): Use EMACS_INT, not int, to store XINT value.
3066
0766b489
PE
3067 * dispextern.h (struct face.stipple):
3068 * image.c (x_bitmap_height, x_bitmap_width, x_bitmap_pixmap)
3069 (x_bitmap_mask, x_allocate_bitmap_record)
3070 (x_create_bitmap_from_data, x_create_bitmap_from_file)
3071 (x_destroy_bitmap, x_destroy_all_bitmaps, x_create_bitmap_mask)
3072 (x_create_bitmap_from_xpm_data):
3073 * nsterm.h (struct ns_display_info.bitmaps_size, .bitmaps_last):
3074 * w32term.h (struct w32_display_info.icon_bitmap_id, .bitmaps_size)
3075 (.bitmaps_last):
3076 * xfaces.c (load_pixmap):
3077 * xterm.c (x_bitmap_icon, x_wm_set_icon_pixmap):
3078 * xterm.h (struct x_display_info.icon_bitmap_id, .bitmaps_size)
3079 (.bitmaps_last, struct x_output.icon_bitmap):
3080 Use ptrdiff_t, not int, for bitmap indexes.
3081 (x_allocate_bitmap_record): Check for size overflow.
3082 * dispextern.h, lisp.h: Adjust to API changes elsewhere.
3083
b081724f
PE
3084 Use ptrdiff_t, not int, for overlay counts.
3085 * buffer.h (overlays_at, sort_overlays, GET_OVERLAYS_AT):
3086 * editfns.c (overlays_around, get_pos_property):
3087 * textprop.c (get_char_property_and_overlay):
3088 * xdisp.c (next_overlay_change, note_mouse_highlight):
3089 * xfaces.c (face_at_buffer_position):
21514da7
PE
3090 * buffer.c (OVERLAY_COUNT_MAX): New macro.
3091 (overlays_at, overlays_in, sort_overlays, Foverlays_at)
3092 (Fnext_overlay_change, Fprevious_overlay_change)
3093 (mouse_face_overlay_overlaps, Foverlays_in):
b081724f 3094 Use ptrdiff_t, not int, for sizes.
21514da7 3095 (overlays_at, overlays_in): Check for size-calculation overflow.
b081724f 3096
3de73e5e
PE
3097 * xterm.c (xim_initialize, same_x_server): Strlen may not fit in int.
3098
2606c57b
PE
3099 * xsmfns.c (smc_save_yourself_CB, x_session_initialize): Avoid strlen.
3100 (x_session_initialize): Do not assume string length fits in int.
3101
aaafe47a
PE
3102 * xsettings.c (apply_xft_settings): Fix potential buffer overrun.
3103 This is unlikely, but can occur if DPI is outlandish.
3104
2674ddc8 3105 * xsettings.c (Ffont_get_system_normal_font, Ffont_get_system_font):
3a5077c5
PE
3106 * xselect.c (Fx_get_atom_name): Avoid need for strlen.
3107
28154962
PE
3108 * xrdb.c: Don't assume strlen fits in int; avoid some strlens.
3109 * xrdb.c (magic_file_p, search_magic_path):
3110 Omit last arg SUFFIX; it was always 0. All callers changed.
3111 (magic_file_p): Use ptrdiff_t, not int. Check for size overflow.
3112
7de51af5
PE
3113 * xfont.c (xfont_match): Avoid need for strlen.
3114
25ed6cc3
PE
3115 * xfns.c: Don't assume strlen fits in int.
3116 (xic_create_fontsetname, x_window): Use ptrdiff_t, not int.
3117
4eab31dd
PE
3118 * xdisp.c (message_log_check_duplicate): Return intmax_t,
3119 not unsigned long, as we prefer signed integers. All callers changed.
3120 Detect integer overflow in repeat count.
3121 (message_dolog): Don't assume print length fits in 39 bytes.
df1f27af 3122 (display_mode_element): Don't assume strlen fits in int.
4eab31dd 3123
171e2a58
PE
3124 * termcap.c: Don't assume sizes fit in int and never overflow.
3125 (struct termcap_buffer, tgetent): Use ptrdiff_t, not int, for sizes.
3126 (gobble_line): Check for size-calculation overflow.
3127
ad39faca 3128 * minibuf.c (Fread_buffer):
6e5bb2dc 3129 * lread.c (intern, intern_c_string):
74ca2eb3
PE
3130 * image.c (xpm_scan) [HAVE_NS && !HAVE_XPM]:
3131 Don't assume string length fits in int.
3132
52c61c22 3133 * keyboard.c (parse_tool_bar_item):
9bda3520
PE
3134 * gtkutil.c (style_changed_cb): Avoid need for strlen.
3135
b5b8c9e5
PE
3136 * font.c: Don't assume string length fits in int.
3137 (font_parse_xlfd, font_parse_fcname, font_unparse_fcname):
3138 Use ptrdiff_t, not int.
ccd6111c
PE
3139 (font_intern_prop): Don't assume string length fits in int.
3140 Don't assume integer property fits in fixnum.
3141 * font.h (font_intern_prop): 2nd arg is now ptrdiff_t, not int.
b5b8c9e5 3142
882f0d81 3143 * filelock.c: Fix some buffer overrun and integer overflow issues.
51cab52b 3144 (get_boot_time): Don't assume gzip command string fits in 100 bytes.
882f0d81
PE
3145 Reformulate so as not to need the command string.
3146 Invoke gzip -cd rather than gunzip, as it's more portable.
3147 (lock_info_type, lock_file_1, lock_file):
3148 Don't assume pid_t and time_t fit in unsigned long.
3149 (LOCK_PID_MAX): Remove; we now use more-reliable bounds.
3150 (current_lock_owner): Prefer signed type for sizes.
3151 Use memcpy, not strncpy, where memcpy is what is really wanted.
3152 Don't assume (via atoi) that time_t and pid_t fit in int.
3153 Check for time_t and/or pid_t out of range, e.g., via a network share.
3154 Don't alloca where an auto var works fine.
3155
93f4cf88
PE
3156 * fileio.c: Fix some integer overflow issues.
3157 (file_name_as_directory, Fexpand_file_name, Fsubstitute_in_file_name):
3158 Don't assume string length fits in int.
3159 (directory_file_name): Don't assume string length fits in long.
3160 (make_temp_name): Don't assume pid fits in int, or that its print
3161 length is less than 20.
3162
f3e92b69
PE
3163 * data.c (Fsubr_name): Rewrite to avoid a strlen call.
3164
1bfdaf10
PE
3165 * coding.c (make_subsidiaries): Don't assume string length fits in int.
3166
35016e9a
PE
3167 * callproc.c (child_setup): Rewrite to avoid two strlen calls.
3168
3d1e65a1
PE
3169 * process.c (Fformat_network_address): Use EMACS_INT, not EMACS_UINT.
3170 We prefer signed integers, even for size calculations.
3171
0b963a93
PE
3172 * emacs.c: Don't assume string length fits in 'int'.
3173 (DEFINE_DUMMY_FUNCTION, sort_args): Use ptrdiff_t, not int.
3174 (main): Don't invoke strlen when not needed.
3175
573f4b54
PE
3176 * dbusbind.c (XD_ERROR): Don't arbitrarily truncate string.
3177 (XD_DEBUG_MESSAGE): Don't waste a byte.
3178
989f33ba
PE
3179 * callproc.c (getenv_internal_1, getenv_internal)
3180 (Fgetenv_internal):
965d34eb
PE
3181 * buffer.c (init_buffer): Don't assume string length fits in 'int'.
3182
e4d29b33
PE
3183 * lread.c (invalid_syntax): Omit length argument.
3184 All uses changed. This doesn't fix a bug, but it simplifies the
3185 code away from its former Hollerith-constant appearance, and it's
3186 one less 'int' to worry about when looking at integer-overflow issues.
51cab52b 3187 (string_to_number): Simplify 2011-04-26 change by invoking xsignal1.
e4d29b33 3188
eb49b136
PE
3189 * lisp.h (DEFUN): Remove bogus use of sizeof (struct Lisp_Subr).
3190 This didn't break anything, but it didn't help either.
3191 It's confusing to put a bogus integer in a place where the actual
3192 value does not matter.
9f62aeb1 3193 (LIST_END_P): Remove unused macro and its bogus comment.
cbeff735 3194 (make_fixnum_or_float): Remove unnecessary cast to EMACS_INT.
eb49b136 3195
15375a22
PE
3196 * lisp.h (union Lisp_Object.i): EMACS_INT, not EMACS_UINT.
3197 This is for consistency with the ordinary, non-USE_LISP_UNION_TYPE,
3198 implementation.
b61cc01c
PE
3199 (struct Lisp_Bool_Vector.size): EMACS_INT, not EMACS_UINT.
3200 We prefer signed types, and the value cannot exceed the EMACS_INT
3201 range anyway (because otherwise the length would not be representable).
9a8e8d9b
PE
3202 (XSET) [USE_LISP_UNION_TYPE]: Use uintptr_t and intptr_t,
3203 not EMACS_UINT and EMACS_INT, when converting pointer to integer.
3204 This avoids a GCC warning when WIDE_EMACS_INT.
15375a22 3205
53b2623d
PE
3206 * indent.c (sane_tab_width): New function.
3207 (current_column, scan_for_column, Findent_to, position_indentation)
3208 (compute_motion): Use it. This is just for clarity.
8fcaf9cc 3209 (Fcompute_motion): Don't assume hscroll and tab offset fit in int.
53b2623d 3210
51cab52b 3211 * image.c (xbm_image_p): Don't assume stated width, height fit in int.
45aebb64 3212
f2ed8a70
PE
3213 * lisp.h (lint_assume): New macro.
3214 * composite.c (composition_gstring_put_cache):
3215 * ftfont.c (ftfont_shape_by_flt): Use it to pacify GCC 4.6.0.
3216
abe80cc6
PE
3217 * editfns.c, insdel.c:
3218 Omit unnecessary forward decls, to simplify future changes.
a9e860e1 3219
b02c740e
PE
3220 * ftfont.c (ftfont_shape_by_flt): Use signed integers for lengths.
3221
ebc96716
PE
3222 * font.c (Ffont_shape_gstring): Don't assume glyph len fits in 'int'.
3223
b4e50fa0 3224 * fns.c (Ffillarray): Don't assume bool vector size fits in 'int'.
f03dc6ef 3225 Use much-faster test for byte-length change.
311d5d7c 3226 Don't assume string byte-length fits in 'int'.
a4cf38e4 3227 Check that character arg fits in 'int'.
85461888 3228 (mapcar1): Declare byte as byte, for clarity.
b4e50fa0 3229
c0c1ee9f
PE
3230 * alloc.c (Fmake_bool_vector): Avoid unnecessary multiplication.
3231
a498d7f4
PE
3232 * fns.c (concat): Catch string overflow earlier.
3233 Do not rely on integer wraparound.
3234
51cab52b
PE
3235 * dispextern.h (struct it.overlay_strings_charpos)
3236 (struct it.selective): Now EMACS_INT, not int.
87830974
PE
3237 * xdisp.c (forward_to_next_line_start)
3238 (back_to_previous_visible_line_start)
3239 (reseat_at_next_visible_line_start, next_element_from_buffer):
3240 Don't arbitrarily truncate the value of 'selective' to int.
3241
76031fad
PE
3242 * xdisp.c (init_iterator): Use XINT, not XFASTINT; it might be < 0.
3243
5eb55db9
PE
3244 * composite.c: Don't truncate sizes to 'int'.
3245 (composition_gstring_p, composition_reseat_it)
3246 (composition_adjust_point): Use EMACS_INT, not int.
7d100a81
PE
3247 (get_composition_id, composition_gstring_put_cache): Use EMACS_INT,
3248 not EMACS_UINT, for indexes.
5eb55db9 3249
0703a717
PE
3250 * category.h (CATEGORY_SET_P): Remove unnecessary cast to EMACS_INT.
3251
d6202519
PE
3252 * buffer.c: Include <verify.h>.
3253 (struct sortvec.priority, struct sortstr.priority):
8961a454 3254 Now EMACS_INT, not int.
c20998a7 3255 (compare_overlays, cmp_for_strings): Avoid subtraction overflow.
67c36fce
PE
3256 (struct sortstr.size, record_overlay_string)
3257 (struct sortstrlist.size, struct sortlist.used):
3258 Don't truncate size to int.
3259 (record_overlay_string): Check for size-calculation overflow.
d6202519 3260 (init_buffer_once): Check at compile-time, not run-time.
fadf4e30 3261
d5a19415
JM
32622011-06-22 Jim Meyering <meyering@redhat.com>
3263
029529ac 3264 Don't leak an XBM-image-sized buffer
d5a19415
JM
3265 * image.c (xbm_load): Free the image buffer after using it.
3266
a9041e6c
PE
32672011-06-21 Paul Eggert <eggert@cs.ucla.edu>
3268
3269 Port to Sun C.
3270 * composite.c (find_automatic_composition): Omit needless 'return 0;'
3271 that Sun C diagnosed.
3272 * fns.c (secure_hash): Fix pointer signedness issue.
3273 * intervals.c (static_offset_intervals): New function.
3274 (offset_intervals): Use it.
3275
7f3f739f
LL
32762011-06-21 Leo Liu <sdl.web@gmail.com>
3277
3278 * deps.mk (fns.o):
3279 * makefile.w32-in ($(BLD)/fns.$(O)): Include sha256.h and
3280 sha512.h.
3281
3282 * fns.c (secure_hash): Rename from crypto_hash_function and change
3283 the first arg to accept symbols.
5b66d427 3284 (Fsecure_hash): New primitive.
7f3f739f
LL
3285 (syms_of_fns): New symbols.
3286
76147d94
DD
32872011-06-20 Deniz Dogan <deniz@dogan.se>
3288
3289 * process.c (Fset_process_buffer): Clarify return value in
3290 docstring.
3291
7d7d0045
CY
32922011-06-18 Chong Yidong <cyd@stupidchicken.com>
3293
3294 * dispnew.c (add_window_display_history): Use BVAR.
3295
3296 * xdisp.c (debug_method_add): Use BVAR.
3297 (check_window_end, dump_glyph_matrix, dump_glyph)
3298 (dump_glyph_row, dump_glyph_string): Convert arglist to ANSI C.
3299
3300 * xfaces.c (check_lface_attrs, check_lface, dump_realized_face):
3301 Likewise.
3302
3303 * xfns.c (Fx_create_frame, x_create_tip_frame): Delay image cache
3304 check till after the cache is created in init_frame_faces.
3305
ff2bc410
SM
33062011-06-17 Stefan Monnier <monnier@iro.umontreal.ca>
3307
3308 * fns.c (Fsafe_length): Yet another int/Lisp_Object mixup.
3309
28177add
PE
33102011-06-16 Paul Eggert <eggert@cs.ucla.edu>
3311
dd3482fe
PE
3312 * lisp.h: Include <limits.h>, for INT_MAX, LONG_MAX, LLONG_MAX.
3313 Without this, prin1 mishandles Lisp_Misc_Save_Value printing on
3314 hosts with pre-C99 libraries, because pD is wrongly defined to "t".
3315
393d71f3 3316 Improve buffer-overflow checking (Bug#8873).
1c8e352f
PE
3317 * fileio.c (Finsert_file_contents):
3318 * insdel.c (insert_from_buffer_1, replace_range, replace_range_2):
3319 Remove the old (too-loose) buffer overflow checks.
3320 They weren't needed, since make_gap checks for buffer overflow.
3321 * insdel.c (make_gap_larger): Catch buffer overflows that were missed.
3322 The old code merely checked for Emacs fixnum overflow, and relied
3323 on undefined (wraparound) behavior. The new code avoids undefined
3324 behavior, and also checks for ptrdiff_t and/or size_t overflow.
3325
2e6813b0 3326 * editfns.c (Finsert_char): Don't dump core with very negative counts.
21d890a4
PE
3327 Tune. Don't use wider integers than needed. Don't use alloca.
3328 Use a bigger 'string' buffer. Rewrite to avoid 'n > 0' test.
2e6813b0 3329
599a9e4f
PE
3330 * insdel.c (replace_range): Fix buf overflow when insbytes < outgoing.
3331
99561444
PE
3332 * insdel.c, lisp.h (buffer_overflow): New function.
3333 (insert_from_buffer_1, replace_range, replace_range_2):
3334 * insdel.c (make_gap_larger):
3335 * editfns.c (Finsert_char):
3336 * fileio.c (Finsert_file_contents): Use it, to normalize wording.
3337
28177add
PE
3338 * buffer.h (BUF_BYTES_MAX): Cast to ptrdiff_t so that it's signed.
3339
e69dafad
PE
33402011-06-15 Paul Eggert <eggert@cs.ucla.edu>
3341
a7af7fde 3342 Integer overflow and signedness fixes (Bug#8873).
ff672d2c 3343
b1c46f02
PE
3344 * ccl.c (ASCENDING_ORDER): New macro, to work around GCC bug 43772.
3345 (GET_CCL_RANGE, IN_INT_RANGE): Use it.
3346
e69dafad
PE
3347 * fileio.c: Don't assume EMACS_INT fits in off_t.
3348 (emacs_lseek): New static function.
3349 (Finsert_file_contents, Fwrite_region): Use it.
3350 Use SEEK_SET, SEEK_CUR, SEEK_END as appropriate.
3351
566684ea
PE
3352 * fns.c (Fload_average): Don't assume 100 * load average fits in int.
3353
e6966cd6
PE
3354 * fns.c: Don't overflow int when computing a list length.
3355 * fns.c (QUIT_COUNT_HEURISTIC): New constant.
3356 (Flength, Fsafe_length): Use EMACS_INT, not int, to avoid unwanted
3357 truncation on 64-bit hosts. Check for QUIT every
3358 QUIT_COUNT_HEURISTIC entries rather than every other entry; that's
3359 faster and is responsive enough.
3360 (Flength): Report an error instead of overflowing an integer.
3361 (Fsafe_length): Return a float if the value is not representable
3362 as a fixnum. This shouldn't happen except in contrived situations.
6346d301 3363 (Fnthcdr, Fsort): Don't assume list length fits in int.
de41a810 3364 (Fcopy_sequence): Don't assume vector length fits in int.
00c604f2 3365
dd0b0efb
PE
3366 * alloc.c: Check that resized vectors' lengths fit in fixnums.
3367 (header_size, word_size): New constants.
3368 (allocate_vectorlike): Don't check size overflow here.
3369 (allocate_vector): Check it here instead, since this is the only
3370 caller of allocate_vectorlike that could cause overflow.
3371 Check that the new vector's length is representable as a fixnum.
3372
86fe5cfe
PE
3373 * fns.c (next_almost_prime): Don't return a multiple of 3 or 5.
3374 The previous code was bogus. For example, next_almost_prime (32)
3375 returned 39, which is undesirable as it is a multiple of 3; and
3376 next_almost_prime (24) returned 25, which is a multiple of 5 so
3377 why was the code bothering to check for multiples of 7?
3378
80e88859
PE
3379 * bytecode.c (exec_byte_code): Use ptrdiff_t, not int, for vector length.
3380
4a2f0ad6
PE
3381 * eval.c, doprnt.c (SIZE_MAX): Remove; inttypes.h defines this now.
3382
f66c7cf8
PE
3383 Variadic C functions now count arguments with ptrdiff_t.
3384 This partly undoes my 2011-03-30 change, which replaced int with size_t.
3385 Back then I didn't know that the Emacs coding style prefers signed int.
3386 Also, in the meantime I found a few more instances where arguments
4a2f0ad6
PE
3387 were being counted with int, which may truncate counts on 64-bit
3388 machines, or EMACS_INT, which may be unnecessarily wide.
f66c7cf8
PE
3389 * lisp.h (struct Lisp_Subr.function.aMANY)
3390 (DEFUN_ARGS_MANY, internal_condition_case_n, safe_call):
3391 Arg counts are now ptrdiff_t, not size_t.
3392 All variadic functions and their callers changed accordingly.
3393 (struct gcpro.nvars): Now size_t, not size_t. All uses changed.
3394 * bytecode.c (exec_byte_code): Check maxdepth for overflow,
3395 to avoid potential buffer overrun. Don't assume arg counts fit in 'int'.
3396 * callint.c (Fcall_interactively): Check arg count for overflow,
3397 to avoid potential buffer overrun. Use signed char, not 'int',
3398 for 'varies' array, so that we needn't bother to check its size
3399 calculation for overflow.
3400 * editfns.c (Fformat): Use ptrdiff_t, not EMACS_INT, to count args.
3401 * eval.c (apply_lambda):
3402 * fns.c (Fmapconcat): Use XFASTINT, not XINT, to get args length.
3403 (struct textprop_rec.argnum): Now ptrdiff_t, not int. All uses changed.
3404 (mapconcat): Use ptrdiff_t, not int and EMACS_INT, to count args.
3405
a1759b76
PE
3406 * callint.c (Fcall_interactively): Don't use index var as event count.
3407
d96be9fc
PE
3408 * vm-limit.c (check_memory_limits): Fix incorrect extern function decls.
3409 * mem-limits.h (SIZE): Remove; no longer used.
3410
a690a978 3411 * xterm.c (x_alloc_nearest_color_1): Prefer int to long when int works.
5efd304b 3412
578c21e6
PE
3413 Remove unnecessary casts.
3414 * xterm.c (x_term_init):
3415 * xfns.c (x_set_border_pixel):
3416 * widget.c (create_frame_gcs): Remove casts to unsigned long etc.
3417 These aren't needed now that we assume ANSI C.
3418
96f53c6c
PE
3419 * sound.c (Fplay_sound_internal): Remove cast to unsigned long.
3420 It's more likely to cause problems (due to unsigned overflow)
3421 than to cure them.
3422
83c77d31
PE
3423 * dired.c (Ffile_attributes): Don't use 32-bit hack on 64-bit hosts.
3424
ee2079f1
PE
3425 * unexelf.c (unexec): Don't assume BSS addr fits in unsigned.
3426
6da65536
PE
3427 * xterm.c (handle_one_xevent): Omit unnecessary casts to unsigned.
3428
7147c4a4
PE
3429 * keyboard.c (modify_event_symbol): Don't limit alist len to UINT_MAX.
3430
193e32d9
PE
3431 * lisp.h (CHAR_TABLE_SET): Omit now-redundant test.
3432
e5533da6
PE
3433 * lread.c (Fload): Don't compare a possibly-garbage time_t value.
3434
9910e595
PE
3435 GLYPH_CODE_FACE returns EMACS_INT, not int.
3436 * dispextern.h (merge_faces):
3437 * xfaces.c (merge_faces):
01103c44
PE
3438 * xdisp.c (get_next_display_element, next_element_from_display_vector):
3439 Don't assume EMACS_INT fits in int.
9910e595 3440
2638320e
PE
3441 * character.h (CHAR_VALID_P): Remove unused parameter.
3442 * fontset.c, lisp.h, xdisp.c: All uses changed.
3443
045eb8d9
PE
3444 * editfns.c (Ftranslate_region_internal): Omit redundant test.
3445
c1f134b5
PE
3446 * fns.c (concat): Minor tuning based on overflow analysis.
3447 This doesn't fix any bugs. Use int to hold character, instead
3448 of constantly refetching from Emacs object. Use XFASTINT, not
3449 XINT, for value known to be a character. Don't bother comparing
3450 a single byte to 0400, as it's always less.
3451
395fcb93 3452 * floatfns.c (Fexpt):
327eeec8
PE
3453 * fileio.c (make_temp_name): Omit unnecessary cast to unsigned.
3454
abbd3d23
PE
3455 * editfns.c (Ftranslate_region_internal): Use int, not EMACS_INT
3456 for characters.
3457
684a03ef
PE
3458 * doc.c (get_doc_string): Omit (unsigned)c that mishandled negatives.
3459
0fed43f3
PE
3460 * data.c (Faset): If ARRAY is a string, check that NEWELT is a char.
3461 Without this fix, on a 64-bit host (aset S 0 4294967386) would
3462 incorrectly succeed when S was a string, because 4294967386 was
3463 truncated before it was used.
3464
8fd02eb7
PE
3465 * chartab.c (Fchar_table_range): Use CHARACTERP to check range.
3466 Otherwise, an out-of-range integer could cause undefined behavior
3467 on a 64-bit host.
3468
f8c86b69
PE
3469 * composite.c: Use int, not EMACS_INT, for characters.
3470 (fill_gstring_body, composition_compute_stop_pos): Use int, not
3471 EMACS_INT, for values that are known to be in character range.
3472 This doesn't fix any bugs but is the usual style inside Emacs and
3473 may generate better code on 32-bit machines.
3474
34206dd2
PE
3475 Make sure a 64-bit char is never passed to ENCODE_CHAR.
3476 This is for reasons similar to the recent CHAR_STRING fix.
3477 * charset.c (Fencode_char): Check that character arg is actually
3478 a character. Pass an int to ENCODE_CHAR.
3479 * charset.h (ENCODE_CHAR): Verify that the character argument is no
3480 wider than 'int', as a compile-time check to prevent future regressions
3481 in this area.
3482
c5958d4c 3483 * character.c (char_string): Remove unnecessary casts.
13bdea59
PE
3484
3485 Make sure a 64-bit char is never passed to CHAR_STRING.
3486 Otherwise, CHAR_STRING would do the wrong thing on a 64-bit platform,
3487 by silently ignoring the top 32 bits, allowing some values
3488 that were far too large to be valid characters.
3489 * character.h: Include <verify.h>.
3490 (CHAR_STRING, CHAR_STRING_ADVANCE): Verify that the character
3491 arguments are no wider than unsigned, as a compile-time check
3492 to prevent future regressions in this area.
3493 * data.c (Faset):
01103c44 3494 * editfns.c (Fchar_to_string, general_insert_function, Finsert_char)
13bdea59
PE
3495 (Fsubst_char_in_region):
3496 * fns.c (concat):
3497 * xdisp.c (decode_mode_spec_coding):
3498 Adjust to CHAR_STRING's new requirement.
3499 * editfns.c (Finsert_char, Fsubst_char_in_region):
3500 * fns.c (concat): Check that character args are actually
3501 characters. Without this test, these functions did the wrong
3502 thing with wildly out-of-range values on 64-bit hosts.
3503
d37ca623
PE
3504 Remove incorrect casts to 'unsigned' that lose info on 64-bit hosts.
3505 These casts should not be needed on 32-bit hosts, either.
3506 * keyboard.c (read_char):
3507 * lread.c (Fload): Remove casts to unsigned.
3508
ea204efb
PE
3509 * lisp.h (UNSIGNED_CMP): New macro.
3510 This fixes comparison bugs on 64-bit hosts.
3511 (ASCII_CHAR_P): Use it.
3512 * casefiddle.c (casify_object):
01103c44 3513 * character.h (ASCII_BYTE_P, CHAR_VALID_P)
ea204efb
PE
3514 (SINGLE_BYTE_CHAR_P, CHAR_STRING):
3515 * composite.h (COMPOSITION_ENCODE_RULE_VALID):
3516 * dispextern.h (FACE_FROM_ID):
3517 * keyboard.c (read_char): Use UNSIGNED_CMP.
3518
41cb286c
PE
3519 * xmenu.c (dialog_selection_callback) [!USE_GTK]: Cast to intptr_t,
3520 not to EMACS_INT, to avoid GCC warning.
3521
4a1b9832
PE
3522 * xfns.c (x_set_scroll_bar_default_width): Remove unused 'int' locals.
3523
55daad71
PE
3524 * buffer.h (PTR_BYTE_POS, BUF_PTR_BYTE_POS): Remove harmful cast.
3525 The cast incorrectly truncated 64-bit byte offsets to 32 bits, and
3526 isn't needed on 32-bit machines.
8f95c75c 3527
01103c44
PE
3528 * buffer.c (Fgenerate_new_buffer_name):
3529 Use EMACS_INT for count, not int.
0ceccced 3530 (advance_to_char_boundary): Return EMACS_INT, not int.
e762cafe
PE
3531
3532 * data.c (Qcompiled_function): Now static.
3533
c6f072e7
PE
3534 * window.c (window_body_lines): Now static.
3535
20ce5912
PE
3536 * image.c (gif_load): Rename local to avoid shadowing.
3537
9c4c5f81
PE
3538 * lisp.h (SAFE_ALLOCA_LISP): Check for integer overflow.
3539 (struct Lisp_Save_Value): Use ptrdiff_t, not int, for 'integer' member.
3540 * alloc.c (make_save_value): Integer argument is now of type
3541 ptrdiff_t, not int.
3542 (mark_object): Use ptrdiff_t, not int.
3543 * lisp.h (pD): New macro.
3544 * print.c (print_object): Use it.
3545
c0c5c8ae
PE
3546 * alloc.c: Use EMACS_INT, not int, to count objects.
3547 (total_conses, total_markers, total_symbols, total_vector_size)
3548 (total_free_conses, total_free_markers, total_free_symbols)
01103c44
PE
3549 (total_free_floats, total_floats, total_free_intervals)
3550 (total_intervals, total_strings, total_free_strings):
c0c5c8ae
PE
3551 Now EMACS_INT, not int. All uses changed.
3552 (Fgarbage_collect): Compute overall total using a double, so that
3553 integer overflow is less likely to be a problem. Check for overflow
3554 when converting back to an integer.
5a25e253
PE
3555 (n_interval_blocks, n_string_blocks, n_float_blocks, n_cons_blocks)
3556 (n_vectors, n_symbol_blocks, n_marker_blocks): Remove.
3557 These were 'int' variables that could overflow on 64-bit hosts;
3558 they were never used, so remove them instead of repairing them.
211a0b2a 3559 (nzombies, ngcs, max_live, max_zombies): Now EMACS_INT, not 'int'.
6349ae4d
PE
3560 (inhibit_garbage_collection): Set gc_cons_threshold to max value.
3561 Previously, this ceilinged at INT_MAX, but that doesn't work on
3562 64-bit machines.
e46bb31a 3563 (allocate_pseudovector): Don't use EMACS_INT when int would do.
c0c5c8ae 3564
c78baabf 3565 * alloc.c (Fmake_bool_vector): Don't assume vector size fits in int.
86f61a15 3566 (allocate_vectorlike): Check for ptrdiff_t overflow.
b6439961
PE
3567 (mark_vectorlike, mark_char_table, mark_object): Avoid EMACS_UINT
3568 when a (possibly-narrower) signed value would do just as well.
3569 We prefer using signed arithmetic, to avoid comparison confusion.
c78baabf 3570
c9d624c6
PE
3571 * alloc.c: Catch some string size overflows that we were missing.
3572 (XMALLOC_OVERRUN_CHECK_SIZE) [!XMALLOC_OVERRUN_CHECK]: Define to 0,
3573 for convenience in STRING_BYTES_MAX.
3574 (STRING_BYTES_MAX): New macro, superseding the old one in lisp.h.
3575 The definition here is exact; the one in lisp.h was approximate.
3576 (allocate_string_data): Check for string overflow. This catches
3577 some instances we weren't catching before. Also, it catches
3578 size_t overflow on (unusual) hosts where SIZE_MAX <= min
3579 (PTRDIFF_MAX, MOST_POSITIVE_FIXNUM), e.g., when size_t is 32 bits
3580 and ptrdiff_t and EMACS_INT are both 64 bits.
c78baabf 3581
c9d624c6
PE
3582 * character.c, coding.c, doprnt.c, editfns.c, eval.c:
3583 All uses of STRING_BYTES_MAX replaced by STRING_BYTES_BOUND.
640c8776 3584 * lisp.h (STRING_BYTES_BOUND): Rename from STRING_BYTES_MAX.
c9d624c6 3585
353032ce
PE
3586 * character.c (string_escape_byte8): Fix nbytes/nchars typo.
3587
2bccce07
PE
3588 * alloc.c (Fmake_string): Check for out-of-range init.
3589
0ac30604
SM
35902011-06-15 Stefan Monnier <monnier@iro.umontreal.ca>
3591
3592 * eval.c (Fdefvaralias): Also mark the target as variable-special-p.
3593
c195f2de
JD
35942011-06-14 Jan Djärv <jan.h.d@swipnet.se>
3595
3596 * xfns.c (x_set_scroll_bar_default_width): Remove argument to
3597 xg_get_default_scrollbar_width.
3598
3599 * gtkutil.c: Include emacsgtkfixed.h if HAVE_GTK3.
3600 (int_gtk_range_get_value): Move to the scroll bar part of the file.
3601 (style_changed_cb): Call update_theme_scrollbar_width and call
3602 x_set_scroll_bar_default_width and xg_frame_set_char_size for
3603 all frames (Bug#8505).
3604 (xg_create_frame_widgets): Call emacs_fixed_new if HAVE_GTK3 (Bug#8505).
3605 Call gtk_window_set_resizable if HAVE_GTK3.
3606 (x_wm_set_size_hint): Call emacs_fixed_set_min_size with min width
3607 and height if HAVE_GTK3 (Bug#8505).
3608 (scroll_bar_width_for_theme): New variable.
3609 (update_theme_scrollbar_width): New function.
3610 (xg_get_default_scrollbar_width): Move code to
3611 update_theme_scrollbar_width, just return scroll_bar_width_for_theme.
3612 (xg_initialize): Call update_theme_scrollbar_width.
3613
3614 * gtkutil.h (xg_get_default_scrollbar_width): Remove argument.
3615
3616 * emacsgtkfixed.c, emacsgtkfixed.h: New files.
3617
e10ac9f1
MR
36182011-06-12 Martin Rudalics <rudalics@gmx.at>
3619
3620 * frame.c (make_frame): Call other_buffer_safely instead of
3621 other_buffer.
3622
3623 * window.c (temp_output_buffer_show): Call display_buffer with
3624 second argument Vtemp_buffer_show_specifiers and reset latter
3625 immediately after the call.
3626 (Vtemp_buffer_show_specifiers): New variable.
3627 (auto_window_vscroll_p, next_screen_context_lines)
3628 (Vscroll_preserve_screen_position): Remove leading asterisks from
3629 doc-strings.
3630
2d3c217e 36312011-06-12 Paul Eggert <eggert@cs.ucla.edu>
4475bec4 3632
7b7f97e8 3633 Fix minor problems found by GCC 4.6.0 static checking.
4475bec4
PE
3634 * buffer.c (Qclone_number): Remove for now, as it's unused.
3635 (record_buffer, Funrecord_buffer): Rename local to avoid shadowing.
3636 (record_buffer): Remove unused local.
3637 * frame.c (other_visible_frames, frame_buffer_list): Now static.
3638 (set_frame_buffer_list): Remove; unused.
3639 * frame.h (other_visible_frames): Remove decl.
3640 * keyboard.h (menu_items_inuse): Declare only if USE_GTK || USE_MOTIF.
3641 * lisp.h (frame_buffer_list, set_frame_buffer_list): Remove decls.
3642 (add_gpm_wait_descriptor, delete_gpm_wait_descriptor): Declare only
3643 if HAVE_GPM.
3644 * menu.c (menu_items_inuse): Now static unless USE_GTK || USE_MOTIF.
3645 * process.c (add_gpm_wait_descriptor, delete_gpm_wait_descriptor):
3646 Define only if HAVE_GPM.
3647 * widget.c (EmacsFrameResize, emacsFrameClassRec): Now static.
3648 (update_hints_inhibit): Remove; never set. All uses removed.
3649 * widgetprv.h (emacsFrameClassRec): Remove decl.
3650 * window.c (delete_deletable_window): Now returns void, since it
3651 wasn't returning anything.
3652 (compare_window_configurations): Remove unused locals.
3653 * xfns.c (x_set_scroll_bar_default_width): Remove unused locals.
3654 * xmenu.c (x_menu_set_in_use): Define only if USE_GTK || USE_MOTIF.
4475bec4
PE
3655 (dialog_selection_callback) [!USE_GTK]: Prefer intptr_t for integers
3656 the same widths as pointers. This follows up on the 2011-05-06 patch.
3657 * xterm.c (x_alloc_lighter_color_for_widget): Define only if USE_LUCID.
3658 * xterm.h: Likewise.
3659 (x_menu_set_in_use): Declare only if USE_GTK || USE_MOTIF.
3660
1384b89e
JB
36612011-06-12 Juanma Barranquero <lekktu@gmail.com>
3662
3663 * makefile.w32-in: Update dependencies.
3664 (LISP_H): Add lib/intprops.h.
3665
1100a63c
CY
36662011-06-11 Chong Yidong <cyd@stupidchicken.com>
3667
3668 * image.c (gif_load): Add animation frame delay to the metadata.
3669 (syms_of_image): Use DEFSYM. New symbol `delay'.
3670
6198ccd0
MR
36712011-06-11 Martin Rudalics <rudalics@gmx.at>
3672
3673 * window.c (delete_deletable_window): Re-add.
3674 (Fset_window_configuration): Rewrite to handle dead buffers and
3675 consequently deletable windows.
3676 (window_tree, Fwindow_tree): Remove. Supply functionality in
3677 window.el.
3678 (compare_window_configurations): Simplify code.
3679
b6e3633c
AS
36802011-06-11 Andreas Schwab <schwab@linux-m68k.org>
3681
1ab0dee5
AS
3682 * image.c (imagemagick_load_image): Fix type mismatch.
3683 (Fimagemagick_types): Likewise.
3684
b6e3633c
AS
3685 * window.h (replace_buffer_in_windows): Declare.
3686
9397e56f
MR
36872011-06-11 Martin Rudalics <rudalics@gmx.at>
3688
3689 * buffer.c: New Lisp objects Qbuffer_list_update_hook and
3690 Qclone_number. Remove external declaration of Qdelete_window.
3691 (Fbuffer_list): Rewrite doc-string. Minor restructuring of
3692 code.
640c8776
SM
3693 (Fget_buffer_create, Fmake_indirect_buffer, Frename_buffer):
3694 Run Qbuffer_list_update_hook if allowed.
9397e56f
MR
3695 (Fother_buffer): Rewrite doc-string. Major rewrite for new
3696 buffer list implementation.
3697 (other_buffer_safely): New function.
3698 (Fkill_buffer): Replace call to replace_buffer_in_all_windows by
3699 calls to replace_buffer_in_windows and
3700 replace_buffer_in_windows_safely. Run Qbuffer_list_update_hook
3701 if allowed.
3702 (record_buffer): Inhibit quitting and rewrite using quittable
3703 functions. Run Qbuffer_list_update_hook if allowed.
3704 (Frecord_buffer, Funrecord_buffer): New functions.
640c8776
SM
3705 (switch_to_buffer_1, Fswitch_to_buffer): Remove.
3706 Move switch-to-buffer to window.el.
9397e56f
MR
3707 (bury-buffer): Move to window.el.
3708 (Vbuffer_list_update_hook): New variable.
3709
3710 * lisp.h (other_buffer_safely): Add prototype in buffer.c
3711 section.
3712
3713 * window.h (resize_frame_windows): Move up in code.
3714 (Fwindow_frame): Remove EXFUN.
3715 (replace_buffer_in_all_windows): Remove prototype.
3716 (replace_buffer_in_windows_safely): Add prototype.
3717
3718 * window.c: Declare Qdelete_window static again. Move down
3719 declaration of select_count.
3720 (Fnext_window, Fprevious_window): Rewrite doc-strings.
3721 (Fother_window): Move to window.el.
3722 (window_loop): Remove DELETE_BUFFER_WINDOWS and UNSHOW_BUFFER
3723 cases. Add REPLACE_BUFFER_IN_WINDOWS_SAFELY case.
3724 (Fdelete_windows_on, Freplace_buffer_in_windows): Move to
3725 window.el.
3726 (replace_buffer_in_windows): Implement by calling
3727 Qreplace_buffer_in_windows.
3728 (replace_buffer_in_all_windows): Remove with some functionality
3729 moved into replace_buffer_in_windows_safely.
3730 (replace_buffer_in_windows_safely): New function.
3731 (select_window_norecord, select_frame_norecord): Move in front
3732 of run_window_configuration_change_hook. Remove now obsolete
3733 declarations.
640c8776
SM
3734 (Fset_window_buffer): Rewrite doc-string.
3735 Call Qrecord_window_buffer.
9397e56f
MR
3736 (keys_of_window): Move binding for other-window to window.el.
3737
b50691aa
CY
37382011-06-11 Chong Yidong <cyd@stupidchicken.com>
3739
3740 * dispextern.h (struct image): Replace data member, whose int_val
3741 and ptr_val fields were not used by anything, with a single
3742 lisp_val object.
3743
3744 * image.c (Fimage_metadata, make_image, mark_image, tiff_load)
3745 (gif_clear_image, gif_load, imagemagick_load_image)
3746 (gs_clear_image, gs_load): Callers changed.
3747
3f754b86
PE
37482011-06-10 Paul Eggert <eggert@cs.ucla.edu>
3749
cca69397
PE
3750 * buffer.h: Include <time.h>, for time_t.
3751 Needed to build on FreeBSD 8.2. Problem reported by Herbert J. Skuhra.
3752
109e28d0
PE
3753 Fix minor problems found by static checking.
3754
60737f02
PE
3755 * image.c (PixelGetMagickColor): Declare if ImageMagick headers don't.
3756
4b66faf3
PE
3757 Make identifiers static if they are not used in other modules.
3758 * data.c (Qcompiled_function, Qframe, Qvector):
3759 * image.c (QimageMagick, Qsvg):
3760 * minibuf.c (Qmetadata):
3761 * window.c (resize_window_check, resize_root_window): Now static.
3762 * window.h (resize_window_check, resize_root_window): Remove decls.
3763
109e28d0
PE
3764 * window.c (window_deletion_count, delete_deletable_window):
3765 Remove; unused.
46a4ce9e
PE
3766 (window_body_lines): Now static.
3767 (Fdelete_other_windows_internal): Mark vars as initialized.
3768 Make sure 'resize_failed' is initialized.
3769 (run_window_configuration_change_hook): Rename local to avoid shadowing.
3770 (resize_window_apply): Remove unused local.
3771 * window.h (delete_deletable_window): Remove decl.
3772
109e28d0 3773 * image.c (gif_load, svg_load_image): Rename locals to avoid shadowing.
33290528
PE
3774 (imagemagick_load_image): Fix pointer signedness problem by changing
3775 last arg from unsigned char * to char *. All uses changed.
3776 Also, fix a local for similar reasons.
3777 Remove unused locals. Remove locals to avoid shadowing.
3778 (fn_rsvg_handle_free): Remove; unused.
3779 (svg_load, svg_load_image): Fix pointer signedness problem.
f7e13da3 3780 (imagemagick_load_image): Don't use garbage pointer image_wand.
33290528 3781
3f754b86
PE
3782 * ftfont.c (ftfont_get_metrics, ftfont_drive_otf): Remove unused locals.
3783
2547adb1
CY
37842011-06-10 Chong Yidong <cyd@stupidchicken.com>
3785
3786 * image.c (gif_load): Fix omitted cast error introduced by
3787 2011-06-06 change.
3788
2c8e37d4
MR
37892011-06-10 Martin Rudalics <rudalics@gmx.at>
3790
3791 * window.h (resize_proportionally, orig_total_lines)
3792 (orig_top_line): Remove from window structure.
3793 (set_window_height, set_window_width, change_window_heights)
3794 (Fdelete_window): Remove prototypes.
3795 (resize_frame_windows): Remove duplicate declaration.
3796
440a42e3
EZ
37972011-06-10 Eli Zaretskii <eliz@gnu.org>
3798
3799 * window.h (resize_frame_windows, resize_window_check)
3800 (delete_deletable_window, resize_root_window)
3801 (resize_frame_windows): Declare prototypes.
3802
3803 * window.c (resize_window_apply): Make definition be "static" to
3804 match the prototype.
3805
562dd5e9
MR
38062011-06-10 Martin Rudalics <rudalics@gmx.at>
3807
3808 * window.c: Remove declarations of Qwindow_size_fixed,
3809 window_min_size_1, window_min_size_2, window_min_size,
3810 size_window, window_fixed_size_p, enlarge_window, delete_window.
3811 Remove static from declaration of Qdelete_window, it's
3812 temporarily needed by Fbury_buffer.
3813 (replace_window): Don't assign orig_top_line and
3814 orig_total_lines.
3815 (Fdelete_window, delete_window): Remove. Window deletion is
3816 handled by window.el.
640c8776
SM
3817 (window_loop): Remove DELETE_OTHER_WINDOWS case.
3818 Replace Fdelete_window calls with calls to Qdelete_window.
562dd5e9
MR
3819 (Fdelete_other_windows): Remove. Deleting other windows is
3820 handled by window.el.
3821 (window_fixed_size_p): Remove. Fixed-sizeness of windows is
3822 handled in window.el.
3823 (window_min_size_2, window_min_size_1, window_min_size): Remove.
3824 Window minimum sizes are handled in window.el.
3825 (shrink_windows, size_window, set_window_height)
3826 (set_window_width, change_window_heights, window_height)
3827 (window_width, CURBEG, CURSIZE, enlarge_window)
3828 (adjust_window_trailing_edge, Fadjust_window_trailing_edge)
3829 (Fenlarge_window, Fshrink_window): Remove. Window resizing is
3830 handled in window.el.
3831 (make_dummy_parent): Rename to make_parent_window and give it a
3832 second argument horflag.
3833 (make_window): Don't set resize_proportionally any more.
3834 (Fsplit_window): Remove. Windows are split in window.el.
3835 (save_restore_action, save_restore_orig_size)
3836 (shrink_window_lowest_first, save_restore_orig_size): Remove.
3837 Resize mini windows in window.el.
3838 (grow_mini_window, shrink_mini_window): Implement by calling
3839 Qresize_root_window_vertically, resize_window_check and
3840 resize_window_apply.
640c8776
SM
3841 (saved_window, Fset_window_configuration, save_window_save):
3842 Do not handle orig_top_line, orig_total_lines, and
562dd5e9
MR
3843 resize_proportionally.
3844 (window_min_height, window_min_width): Move to window.el.
3845 (keys_of_window): Move bindings for delete-other-windows,
3846 split-window, delete-window and enlarge-window to window.el.
3847
3848 * buffer.c: Temporarily extern Qdelete_window.
3849 (Fbury_buffer): Temporarily call Qdelete_window instead of
3850 Fdelete_window (Fbury_buffer will move to window.el soon).
3851
3852 * frame.c (set_menu_bar_lines_1): Remove code handling
3853 orig_top_line and orig_total_lines.
3854
3855 * dispnew.c (adjust_frame_glyphs_initially): Don't use
3856 set_window_height but set heights directly.
3857 (change_frame_size_1): Use resize_frame_windows.
3858
3859 * xdisp.c (init_xdisp): Don't use set_window_height but set
3860 heights directly.
3861
640c8776
SM
3862 * xfns.c (x_set_menu_bar_lines, x_set_tool_bar_lines):
3863 Use resize_frame_windows instead of change_window_heights and run
562dd5e9
MR
3864 run_window_configuration_change_hook.
3865
3866 * w32fns.c (x_set_tool_bar_lines): Use resize_frame_windows
3867 instead of change_window_heights and run
3868 run_window_configuration_change_hook.
3869
1a13852e
MR
38702011-06-09 Martin Rudalics <rudalics@gmx.at>
3871
3872 * window.c (replace_window): Rename second argument REPLACEMENT to
3873 NEW. New third argument SETFLAG. Rewrite.
3874 (delete_window, make_dummy_parent): Call replace_window with
3875 third argument 1.
3876 (window_list_1): Move down in code.
3877 (run_window_configuration_change_hook): Move set_buffer part
3878 before select_frame_norecord part in order to unwind correctly.
3879 Rename count1 to count.
3880 (recombine_windows, delete_deletable_window, resize_root_window)
3881 (Fdelete_other_windows_internal)
3882 (Frun_window_configuration_change_hook, make_parent_window)
3883 (resize_window_check, resize_window_apply, Fresize_window_apply)
3884 (resize_frame_windows, Fsplit_window_internal)
640c8776
SM
3885 (Fdelete_window_internal, Fresize_mini_window_internal):
3886 New functions.
1a13852e
MR
3887 (syms_of_window): New variables Vwindow_splits and Vwindow_nest.
3888
f3d1777e
MR
38892011-06-08 Martin Rudalics <rudalics@gmx.at>
3890
496e208e
MR
3891 * window.h (window): Add some new members to window structure -
3892 normal_lines, normal_cols, new_total, new_normal, clone_number,
3893 splits, nest, prev_buffers, next_buffers.
3894 (WINDOW_TOTAL_SIZE): Move here from window.c.
b9e809c2 3895 (MIN_SAFE_WINDOW_WIDTH, MIN_SAFE_WINDOW_HEIGHT): Define here.
496e208e 3896
f3d1777e
MR
3897 * window.c (Fwindow_height, Fwindow_width, Fwindow_full_width_p):
3898 Remove.
496e208e
MR
3899 (make_dummy_parent): Set new members of windows structure.
3900 (make_window): Move down in code. Handle new members of window
3901 structure.
3902 (Fwindow_clone_number, Fwindow_splits, Fset_window_splits)
3903 (Fwindow_nest, Fset_window_nest, Fwindow_new_total)
3904 (Fwindow_normal_size, Fwindow_new_normal, Fwindow_prev_buffers)
3905 (Fset_window_prev_buffers, Fwindow_next_buffers)
640c8776
SM
3906 (Fset_window_next_buffers, Fset_window_clone_number):
3907 New functions.
496e208e
MR
3908 (Fwindow_hscroll, Fwindow_at, Fwindow_point, Fwindow_start)
3909 (Fwindow_end, Fwindow_line_height, Fset_window_dedicated_p):
3910 Doc-string fixes.
3911 (Fwindow_parameters, Fwindow_parameter, Fset_window_parameter):
3912 Argument WINDOW can be now internal window too.
3913 (Fwindow_use_time): Move up in code.
3914 (Fget_buffer_window): Rename argument FRAME to ALL-FRAMES.
3915 Rewrite doc-string.
3916 (Fset_window_configuration, saved_window)
3917 (Fcurrent_window_configuration, save_window_save): Handle new
3918 members of window structure.
b9e809c2
MR
3919 (WINDOW_TOTAL_SIZE, MIN_SAFE_WINDOW_WIDTH)
3920 (MIN_SAFE_WINDOW_HEIGHT): Move to window.h.
3921 (syms_of_window): New Lisp objects Qrecord_window_buffer,
3922 Qwindow_deletable_p, Qdelete_window, Qreplace_buffer_in_windows,
3923 Qget_mru_window, Qresize_root_window,
3924 Qresize_root_window_vertically, Qsafe, Qabove, Qbelow,
3925 Qauto_buffer_name; staticpro them.
f3d1777e 3926
abde8f8c
MR
39272011-06-07 Martin Rudalics <rudalics@gmx.at>
3928
3929 * window.c (Fwindow_total_size, Fwindow_left_column)
3930 (Fwindow_top_line, window_body_lines, Fwindow_body_size)
3931 (Fwindow_list_1): New functions.
3932 (window_box_text_cols): Replace with window_body_cols.
640c8776
SM
3933 (Fwindow_width, Fscroll_left, Fscroll_right):
3934 Use window_body_cols instead of window_box_text_cols.
3935 (delete_window, Fset_window_configuration):
3936 Call delete_all_subwindows with window as argument.
fa8a67e6
MR
3937 (delete_all_subwindows): Take a window as argument and not a
3938 structure. Rewrite.
190b47e6
MR
3939 (window_loop): Remove handling of GET_LRU_WINDOW and
3940 GET_LARGEST_WINDOW.
3941 (Fget_lru_window, Fget_largest_window): Move to window.el.
abde8f8c
MR
3942
3943 * window.h: Extern window_body_cols instead of
fa8a67e6
MR
3944 window_box_text_cols. delete_all_subwindows now takes a
3945 Lisp_Object as argument.
abde8f8c 3946
640c8776
SM
3947 * indent.c (compute_motion, Fcompute_motion):
3948 Use window_body_cols instead of window_box_text_cols.
abde8f8c 3949
fa8a67e6
MR
3950 * frame.c (delete_frame): Call delete_all_subwindows with root
3951 window as argument.
3952
a54e3482
DC
39532011-06-07 Daniel Colascione <dan.colascione@gmail.com>
3954
3955 * fns.c (Fputhash): Document return value.
3956
60002bf5
CY
39572011-06-06 Chong Yidong <cyd@stupidchicken.com>
3958
3959 * image.c (gif_load): Implement gif89a spec "no disposal" method.
3960
0c671da6 39612011-06-06 Paul Eggert <eggert@cs.ucla.edu>
ccd9a01a 3962
b862a52a 3963 Cons<->int and similar integer overflow fixes (Bug#8794).
77984278 3964
be44ca6c
PE
3965 Check for overflow when converting integer to cons and back.
3966 * charset.c (Fdefine_charset_internal, Fdecode_char):
3967 Use cons_to_unsigned to catch overflow.
3968 (Fencode_char): Use INTEGER_TO_CONS.
3969 * composite.h (LGLYPH_CODE): Use cons_to_unsigned.
3970 (LGLYPH_SET_CODE): Use INTEGER_TO_CONS.
3971 * data.c (long_to_cons, cons_to_long): Remove.
3972 (cons_to_unsigned, cons_to_signed): New functions.
3973 These signal an error for invalid or out-of-range values.
3974 * dired.c (Ffile_attributes): Use INTEGER_TO_CONS.
3975 * fileio.c (Fset_visited_file_modtime): Use CONS_TO_INTEGER.
3976 * font.c (Ffont_variation_glyphs):
3977 * fontset.c (Finternal_char_font): Use INTEGER_TO_CONS.
3978 * lisp.h: Include <intprops.h>.
3979 (INTEGER_TO_CONS, CONS_TO_INTEGER): New macros.
3980 (cons_to_signed, cons_to_unsigned): New decls.
3981 (long_to_cons, cons_to_long): Remove decls.
3982 * undo.c (record_first_change): Use INTEGER_TO_CONS.
3983 (Fprimitive_undo): Use CONS_TO_INTEGER.
3984 * xfns.c (Fx_window_property): Likewise.
3985 * xselect.c: Include <limits.h>.
3986 (x_own_selection, selection_data_to_lisp_data):
3987 Use INTEGER_TO_CONS.
3988 (x_handle_selection_request, x_handle_selection_clear)
3989 (x_get_foreign_selection, Fx_disown_selection_internal)
3990 (Fx_get_atom_name, x_send_client_event): Use CONS_TO_INTEGER.
3991 (lisp_data_to_selection_data): Use cons_to_unsigned.
3992 (x_fill_property_data): Use cons_to_signed.
3993 Report values out of range.
3994
d1f3d2af
PE
3995 Check for buffer and string overflow more precisely.
3996 * buffer.h (BUF_BYTES_MAX): New macro.
3997 * lisp.h (STRING_BYTES_MAX): New macro.
3998 * alloc.c (Fmake_string):
3999 * character.c (string_escape_byte8):
4000 * coding.c (coding_alloc_by_realloc):
4001 * doprnt.c (doprnt):
4002 * editfns.c (Fformat):
4003 * eval.c (verror):
4004 Use STRING_BYTES_MAX, not MOST_POSITIVE_FIXNUM,
4005 since they may not be the same number.
4006 * editfns.c (Finsert_char):
4007 * fileio.c (Finsert_file_contents):
4008 Likewise for BUF_BYTES_MAX.
4009
dd52fcea
PE
4010 * image.c: Use ptrdiff_t, not int, for sizes.
4011 (slurp_file): Switch from int to ptrdiff_t.
4012 All uses changed.
4013 (slurp_file): Check that file size fits in both size_t (for
4014 malloc) and ptrdiff_t (for sanity and safety).
4015
7f9bbdbb
PE
4016 * fileio.c (Fverify_visited_file_modtime): Avoid time overflow
4017 if b->modtime has its maximal value.
4018
dfe18f82
PE
4019 * dired.c (Ffile_attributes): Don't assume EMACS_INT has >32 bits.
4020
84acfcf0
PE
4021 Don't assume time_t can fit into int.
4022 * buffer.h (struct buffer.modtime): Now time_t, not int.
4023 * fileio.c (Fvisited_file_modtime): No need for time_t cast now.
4024 * undo.c (Fprimitive_undo): Use time_t, not int, for time_t value.
4025
ccd9a01a
PE
4026 Minor fixes for signed vs unsigned integers.
4027 * character.h (MAYBE_UNIFY_CHAR):
4028 * charset.c (maybe_unify_char):
4029 * keyboard.c (read_char, reorder_modifiers):
4030 XINT -> XFASTINT, since the integer must be nonnegative.
4031 * ftfont.c (ftfont_spec_pattern):
4032 * keymap.c (access_keymap, silly_event_symbol_error):
4033 XUINT -> XFASTINT, since the integer must be nonnegative.
4034 (Fsingle_key_description, preferred_sequence_p): XUINT -> XINT,
4035 since it makes no difference and we prefer signed.
4036 * keyboard.c (record_char): Use XUINT when all the neighbors do.
4037 (access_keymap): NATNUMP -> INTEGERP, since the integer must be
4038 nonnegative.
4039
d6d100dd
SM
40402011-06-06 Stefan Monnier <monnier@iro.umontreal.ca>
4041
4042 * window.h (Fwindow_frame): Declare.
4043
2b6148e4
PE
40442011-06-06 Paul Eggert <eggert@cs.ucla.edu>
4045
4046 * alloc.c: Simplify handling of large-request failures (Bug#8800).
4047 (SPARE_MEMORY): Always define.
4048 (LARGE_REQUEST): Remove.
4049 (memory_full): Use SPARE_MEMORY rather than LARGE_REQUEST.
4050
f230ecc9
MR
40512011-06-06 Martin Rudalics <rudalics@gmx.at>
4052
727e958e
MR
4053 * lisp.h: Move EXFUNS for Fframe_root_window,
4054 Fframe_first_window and Fset_frame_selected_window to window.h.
4055
4056 * window.h: Move EXFUNS for Fframe_root_window,
4057 Fframe_first_window and Fset_frame_selected_window here from
4058 lisp.h.
4059
4060 * frame.c (Fwindow_frame, Fframe_first_window)
4061 (Fframe_root_window, Fframe_selected_window)
4062 (Fset_frame_selected_window): Move to window.c.
4063 (Factive_minibuffer_window): Move to minibuf.c.
4064 (Fother_visible_frames_p): New function.
4065
4066 * minibuf.c (Factive_minibuffer_window): Move here from frame.c.
4067
f230ecc9
MR
4068 * window.c (decode_window, decode_any_window): Move up in code.
4069 (Fwindowp, Fwindow_live_p): Rewrite doc-strings.
4070 (inhibit_frame_unsplittable): Remove unused variable.
bf60a96b
MR
4071 (Fwindow_buffer): Move up and rewrite doc-string.
4072 (Fwindow_parent, Fwindow_vchild, Fwindow_hchild, Fwindow_next)
4073 (Fwindow_prev): New functions.
727e958e
MR
4074 (Fwindow_frame): Move here from frame.c. Accept any window as
4075 argument.
4076 (Fframe_root_window, Fframe_first_window)
4077 (Fframe_selected_window): Move here from frame.c. Accept frame
4078 or arbitrary window as argument. Update doc-strings.
4079 (Fminibuffer_window): Move up in code.
4080 (Fwindow_minibuffer_p): Move up in code and simplify.
d6d100dd
SM
4081 (Fset_frame_selected_window): Move here from frame.c.
4082 Marginal rewrite.
727e958e
MR
4083 (Fselected_window, select_window, Fselect_window): Move up in
4084 code. Minor doc-string fixes.
f230ecc9 4085
4d09bcf6
PE
40862011-06-06 Paul Eggert <eggert@cs.ucla.edu>
4087
4088 * alloc.c (memory_full) [SYSTEM_MALLOC]: Port to MacOS (Bug#8800).
4089 Do not assume that spare memory exists; that assumption is valid
4090 only if SYSTEM_MALLOC.
4091 (LARGE_REQUEST): New macro, so that the issue of large requests
4092 is separated from the issue of spare memory.
4093
810928a2
AS
40942011-06-05 Andreas Schwab <schwab@linux-m68k.org>
4095
172418ad
AS
4096 * editfns.c (Fformat): Correctly handle zero flag with hexadecimal
4097 format. (Bug#8806)
4098
43f862f7
AS
4099 * gtkutil.c (xg_get_default_scrollbar_width): Avoid warning.
4100
810928a2
AS
4101 * xfns.c (x_set_scroll_bar_default_width): Move declarations
4102 before statements.
4103
a059fe24
JD
41042011-06-05 Jan Djärv <jan.h.d@swipnet.se>
4105
4106 * gtkutil.c (xg_get_default_scrollbar_width): New function.
4107
4108 * gtkutil.h: Declare xg_get_default_scrollbar_width.
4109
4110 * xfns.c (x_set_scroll_bar_default_width): If USE_GTK, get
4111 min width by calling x_set_scroll_bar_default_width (Bug#8505).
4112
989bf368
JB
41132011-06-05 Juanma Barranquero <lekktu@gmail.com>
4114
4115 * xdisp.c (single_display_spec_intangible_p): Remove declaration.
4116
4b80f674
CY
41172011-06-04 Chong Yidong <cyd@stupidchicken.com>
4118
4119 * xselect.c (x_clipboard_manager_save): Remove redundant arg.
4120 (x_clipboard_manager_save): Add return value.
d6d100dd
SM
4121 (x_clipboard_manager_error_1, x_clipboard_manager_error_2):
4122 New error handlers.
4b80f674
CY
4123 (x_clipboard_manager_save_frame, x_clipboard_manager_save_all):
4124 Obey Vx_select_enable_clipboard_manager. Catch errors in
4125 x_clipboard_manager_save (Bug#8779).
4126 (Vx_select_enable_clipboard_manager): New variable.
de65b42c 4127 (x_get_foreign_selection): Reduce scope of x_catch_errors (Bug#8790).
4b80f674 4128
99a33b77 41292011-06-04 Dan Nicolaescu <dann@ics.uci.edu>
8b3115e7
DN
4130
4131 * emacs.c (main): Warn when starting a GTK emacs in daemon mode.
4132
99a33b77 41332011-06-04 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
14eca62f
YM
4134
4135 * fringe.c (update_window_fringes): Don't update overlay arrow bitmap
4136 in the current matrix if keep_current_p is non-zero.
4137
8264569d
EZ
41382011-06-04 Eli Zaretskii <eliz@gnu.org>
4139
4140 * bidi.c (bidi_level_of_next_char): Fix last change.
4141
57f97249
EZ
41422011-06-03 Eli Zaretskii <eliz@gnu.org>
4143
fec2107c 4144 Support bidi reordering of text covered by display properties.
57f97249 4145
fec2107c
EZ
4146 * bidi.c (bidi_copy_it): Use offsetof instead of emulating it.
4147 (bidi_fetch_char, bidi_fetch_char_advance): New functions.
4148 (bidi_cache_search, bidi_cache_iterator_state)
4149 (bidi_paragraph_init, bidi_resolve_explicit, bidi_resolve_weak)
d6d100dd
SM
4150 (bidi_level_of_next_char, bidi_move_to_visually_next):
4151 Support character positions inside a run of characters covered by a
fec2107c
EZ
4152 display string.
4153 (bidi_paragraph_init, bidi_resolve_explicit_1)
4154 (bidi_level_of_next_char): Call bidi_fetch_char and
4155 bidi_fetch_char_advance instead of FETCH_CHAR and
4156 FETCH_CHAR_ADVANCE.
4157 (bidi_init_it): Initialize new members.
4158 (LRE_CHAR, RLE_CHAR, PDF_CHAR, LRO_CHAR, RLO_CHAR): Remove macro
4159 definitions.
4160 (bidi_explicit_dir_char): Lookup character type in bidi_type_table,
4161 instead of using explicit *_CHAR codes.
d6d100dd
SM
4162 (bidi_resolve_explicit, bidi_resolve_weak):
4163 Use FETCH_MULTIBYTE_CHAR instead of FETCH_CHAR, as reordering of
fec2107c
EZ
4164 bidirectional text is supported only in multibyte buffers.
4165 (bidi_init_it): Accept additional argument FRAME_WINDOW_P and use
4166 it to initialize the frame_window_p member of struct bidi_it.
4167 (bidi_cache_iterator_state, bidi_resolve_explicit_1)
4168 (bidi_resolve_explicit, bidi_resolve_weak)
4169 (bidi_level_of_next_char, bidi_move_to_visually_next): Abort if
4170 bidi_it->nchars is non-positive.
4171 (bidi_level_of_next_char): Don't try to lookup the cache for the
4172 next/previous character if nothing is cached there yet, or if we
4173 were just reseat()'ed to a new position.
c40e2fb2 4174
0e14fe90
EZ
4175 * xdisp.c (set_cursor_from_row): Set start and stop points
4176 according to the row's direction when priming the loop that looks
4177 for the glyph on which to display cursor.
4178 (single_display_spec_intangible_p): Function deleted.
4179 (display_prop_intangible_p): Reimplement to call
4180 handle_display_spec instead of single_display_spec_intangible_p.
d6d100dd
SM
4181 Accept 3 additional arguments needed by handle_display_spec.
4182 This fixes incorrect cursor motion across display property with complex
0e14fe90
EZ
4183 values: lists, `(when COND...)' forms, etc.
4184 (single_display_spec_string_p): Support property values that are
4185 lists with the argument STRING its top-level element.
4186 (display_prop_string_p): Fix the condition for processing a
4187 property that is a list to be consistent with handle_display_spec.
fec2107c 4188 (handle_display_spec): New function, refactored from the
fc6f18ce
EZ
4189 last portion of handle_display_prop.
4190 (compute_display_string_pos): Accept additional argument
4191 FRAME_WINDOW_P. Call handle_display_spec to determine whether the
4192 value of a `display' property is a "replacing spec".
4193 (handle_single_display_spec): Accept 2 additional arguments BUFPOS
4194 and FRAME_WINDOW_P. If IT is NULL, don't set up the iterator from
4195 the display property, but just return a value indicating whether
4196 the display property will replace the characters it covers.
4197 (Fcurrent_bidi_paragraph_direction): Initialize the nchars and
4198 frame_window_p members of struct bidi_it.
d6d100dd
SM
4199 (compute_display_string_pos, compute_display_string_end):
4200 New functions.
fec2107c
EZ
4201 (push_it): Accept second argument POSITION, where pop_it should
4202 jump to continue iteration.
4203 (reseat_1): Initialize bidi_it.disp_pos.
fc6f18ce 4204
fec2107c
EZ
4205 * keyboard.c (adjust_point_for_property): Adjust the call to
4206 display_prop_intangible_p to its new signature.
fc6f18ce
EZ
4207
4208 * dispextern.h (struct bidi_it): New member frame_window_p.
fec2107c
EZ
4209 (bidi_init_it): Update prototypes.
4210 (display_prop_intangible_p): Update prototype.
d6d100dd
SM
4211 (compute_display_string_pos, compute_display_string_end):
4212 Declare prototypes.
fec2107c
EZ
4213 (struct bidi_it): New members nchars and disp_pos. ch_len is now
4214 EMACS_INT.
fc6f18ce 4215
40087514 42162011-06-02 Paul Eggert <eggert@cs.ucla.edu>
0de4bb68 4217
57f53182
PE
4218 Malloc failure behavior now depends on size of allocation.
4219 * alloc.c (buffer_memory_full, memory_full): New arg NBYTES.
4220 * lisp.h: Change signatures accordingly.
4221 * alloc.c, buffer.c, editfns.c, menu.c, minibuf.c, xterm.c:
4222 All callers changed. (Bug#8762)
4223
4224 * gnutls.c: Use Emacs's memory allocators.
4225 Without this change, the gnutls library would invoke malloc etc.
4226 directly, which causes problems on non-SYNC_INPUT hosts, and which
4227 runs afoul of improving memory_full behavior. (Bug#8761)
4228 (fn_gnutls_global_set_mem_functions): New macro or function pointer.
4229 (emacs_gnutls_global_init): Use it to specify xmalloc, xrealloc,
4230 xfree instead of the default malloc, realloc, free.
4231 (Fgnutls_boot): No need to check for memory allocation failure,
4232 since xmalloc does that for us.
4233
ac32cd99 4234 Remove arbitrary limit of 2**31 entries in hash tables. (Bug#8771)
3870d916
PE
4235 * category.c (hash_get_category_set):
4236 * ccl.c (ccl_driver):
4237 * charset.c (Fdefine_charset_internal):
4238 * charset.h (struct charset.hash_index):
4239 * composite.c (get_composition_id, gstring_lookup_cache)
4240 (composition_gstring_put_cache):
4241 * composite.h (struct composition.hash_index):
4242 * dispextern.h (struct image.hash):
4243 * fns.c (next_almost_prime, larger_vector, cmpfn_eql)
4244 (cmpfn_equal, cmpfn_user_defined, hashfn_eq, hashfn_eql)
4245 (hashfn_equal, hashfn_user_defined, make_hash_table)
4246 (maybe_resize_hash_table, hash_lookup, hash_put)
4247 (hash_remove_from_table, hash_clear, sweep_weak_table, SXHASH_COMBINE)
4248 (sxhash_string, sxhash_list, sxhash_vector, sxhash_bool_vector)
4249 (Fsxhash, Fgethash, Fputhash, Fmaphash):
4250 * image.c (make_image, search_image_cache, lookup_image)
4251 (xpm_put_color_table_h):
4252 * lisp.h (struct Lisp_Hash_Table):
0de4bb68 4253 * minibuf.c (Ftry_completion, Fall_completions, Ftest_completion):
ac389d0c 4254 * print.c (print): Use 'EMACS_UINT' and 'EMACS_INT'
3870d916 4255 for hashes and hash indexes, instead of 'unsigned' and 'int'.
40087514
PE
4256 * alloc.c (allocate_vectorlike):
4257 Check for overflow in vector size calculations.
4258 * ccl.c (ccl_driver):
4259 Check for overflow when converting EMACS_INT to int.
0de4bb68
PE
4260 * fns.c, image.c: Remove unnecessary static decls that would otherwise
4261 need to be updated by these changes.
40087514
PE
4262 * fns.c (make_hash_table, maybe_resize_hash_table):
4263 Check for integer overflow with large hash tables.
0de4bb68
PE
4264 (make_hash_table, maybe_resize_hash_table, Fmake_hash_table):
4265 Prefer the faster XFLOAT_DATA to XFLOATINT where either will do.
4266 (SXHASH_REDUCE): New macro.
4267 (sxhash_string, sxhash_list, sxhash_vector, sxhash_bool_vector):
4268 Use it instead of discarding useful hash info with large hash values.
4269 (sxhash_float): New function.
4270 (sxhash): Use it. No more need for "& INTMASK" due to above changes.
4271 * lisp.h (FIXNUM_BITS): New macro, useful for SXHASH_REDUCE etc.
40087514
PE
4272 (MOST_NEGATIVE_FIXNUM, MOST_POSITIVE_FIXNUM, INTMASK):
4273 Rewrite to use FIXNUM_BITS, as this simplifies things.
0de4bb68
PE
4274 (next_almost_prime, larger_vector, sxhash, hash_lookup, hash_put):
4275 Adjust signatures to match updated version of code.
4276 (consing_since_gc): Now EMACS_INT, since a single hash table can
4277 use more than INT_MAX bytes.
4278
698d32e2
DN
42792011-06-01 Dan Nicolaescu <dann@ics.uci.edu>
4280
4281 Make it possible to build with GCC-4.6+ -O2 -flto.
4282
4283 * emacs.c (__malloc_initialize_hook): Mark as EXTERNALLY_VISIBLE.
4284
fd6fa53f
SM
42852011-06-01 Stefan Monnier <monnier@iro.umontreal.ca>
4286
4287 * minibuf.c (get_minibuffer, read_minibuf_unwind):
4288 Call minibuffer-inactive-mode.
4289
864db017
JB
42902011-05-31 Juanma Barranquero <lekktu@gmail.com>
4291
4292 * makefile.w32-in ($(BLD)/data.$(O), $(BLD)/editfns.$(O)):
4293 Update dependencies.
4294
2ad0baf4
DN
42952011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
4296
4297 * data.c (init_data): Remove code for UTS, this system is not
4298 supported anymore.
4299
4fcc2638
DN
43002011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
4301
4302 Don't force ./temacs to start in terminal mode.
4303
4304 * frame.c (make_initial_frame): Initialize faces in all cases, not
4305 only when CANNOT_DUMP is defined.
4306 * dispnew.c (init_display): Remove CANNOT_DUMP condition.
4307
c56e0fd5
DN
43082011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
4309
4310 * dispnew.c (add_window_display_history): Use const for the string
4311 pointer. Remove declaration, not needed.
4312
333d54da 43132011-05-31 Paul Eggert <eggert@cs.ucla.edu>
9cf9f756 4314
55d4c1b2 4315 Use 'inline', not 'INLINE'.
333d54da 4316 <http://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00914.html>
55d4c1b2
PE
4317 * alloc.c, fontset.c (INLINE): Remove.
4318 * alloc.c, bidi.c, charset.c, coding.c, dispnew.c, fns.c, image.c:
4319 * intervals.c, keyboard.c, process.c, syntax.c, textprop.c, w32term.c:
4320 * xdisp.c, xfaces.c, xterm.c: Replace all uses of INLINE with inline.
4321 * gmalloc.c (register_heapinfo): Use inline unconditionally.
4322 * lisp.h (LISP_MAKE_RVALUE): Use inline, not __inline__.
4323
738db178
DN
43242011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
4325
4326 Make it possible to run ./temacs.
4327
4328 * callproc.c (set_initial_environment): Remove CANNOT_DUMP code,
4329 syms_of_callproc does the same thing. Remove test for
4330 "initialized", do it in the caller.
4331 * emacs.c (main): Avoid calling set_initial_environment when dumping.
4332
620c53a6
SM
43332011-05-31 Stefan Monnier <monnier@iro.umontreal.ca>
4334
4335 * minibuf.c (Finternal_complete_buffer): Return `category' metadata.
4336 (read_minibuf): Use get_minibuffer.
4337 (syms_of_minibuf): Use DEFSYM.
4338 (Qmetadata): New var.
4339 * data.c (Qbuffer): Don't make it static.
4340 (syms_of_data): Use DEFSYM.
4341
e003a292
PE
43422011-05-31 Paul Eggert <eggert@cs.ucla.edu>
4343
4344 * ccl.c (CCL_CODE_RANGE): Allow negative numbers. (Bug#8751)
4345 (CCL_CODE_MIN): New macro.
4346
ed008a6d
PE
43472011-05-30 Paul Eggert <eggert@cs.ucla.edu>
4348
3687c2ef
PE
4349 * alloc.c (lisp_align_malloc): Omit unnecessary val==NULL tests.
4350
ed008a6d
PE
4351 * eval.c (Qdebug): Now static.
4352 * lisp.h (Qdebug): Remove decl. This reverts a part of the
4353 2011-04-26T11:26:05Z!dan.colascione@gmail.com that inadvertently undid part of
4354 2011-04-14T06:48:41Z!eggert@cs.ucla.edu.
4355
d66c4c7c
CY
43562011-05-29 Chong Yidong <cyd@stupidchicken.com>
4357
4358 * image.c: Various fixes to ImageMagick code comments.
4359 (Fimagemagick_types): Doc fix.
4360
5fbc2025
PE
43612011-05-29 Paul Eggert <eggert@cs.ucla.edu>
4362
0196f88a
PE
4363 Minor fixes prompted by GCC 4.6.0 warnings.
4364
4365 * xselect.c (converted_selections, conversion_fail_tag): Now static.
4366
5fbc2025
PE
4367 * emacs.c [HAVE_X_WINDOWS]: Include "xterm.h".
4368 (x_clipboard_manager_save_all): Move extern decl to ...
4369 * xterm.h: ... here, so that it can be checked for consistency.
4370
1dd3c2d9
CY
43712011-05-29 Chong Yidong <cyd@stupidchicken.com>
4372
4373 * xselect.c (x_clipboard_manager_save_frame)
4374 (x_clipboard_manager_save_all): New functions.
4375 (Fx_clipboard_manager_save): Lisp function deleted.
4376
4377 * emacs.c (Fkill_emacs): Call x_clipboard_manager_save_all.
4378 * frame.c (delete_frame): Call x_clipboard_manager_save_frame.
4379
4380 * xterm.h: Update prototype.
4381
5ba6571d
WX
43822011-05-28 William Xu <william.xwl@gmail.com>
4383
4384 * nsterm.m (ns_term_shutdown): Synchronize user defaults before
4385 exiting (Bug#8239).
4386
3eaff834
JM
43872011-05-28 Jim Meyering <meyering@redhat.com>
4388
e1900994 4389 Avoid a sign-extension bug in crypto_hash_function.
3eaff834
JM
4390 * fns.c (to_uchar): Define.
4391 (crypto_hash_function): Use it to convert some newly-signed
4392 variables to unsigned, to avoid sign-extension bugs. For example,
4393 without this change, (md5 "truc") would evaluate to
4394 45723a2aff78ff4fff7fff1114760e62 rather than the expected
4395 45723a2af3788c4ff17f8d1114760e62. Reported by Antoine Levitt in
e1900994 4396 https://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00883.html.
3eaff834 4397
0f6990a7
PE
43982011-05-27 Paul Eggert <eggert@cs.ucla.edu>
4399
4400 Integer overflow fixes.
c8a9ca5a 4401
08686060
PE
4402 * dbusbind.c: Serial number integer overflow fixes.
4403 (CHECK_DBUS_SERIAL_GET_SERIAL): New macro.
08686060
PE
4404 (Fdbus_call_method_asynchronously, xd_read_message_1): Use a float
4405 to hold a serial number that is too large for a fixnum.
4406 (Fdbus_method_return_internal, Fdbus_method_error_internal):
4407 Check for serial numbers out of range. Decode any serial number
59568bf0 4408 that was so large that it became a float. (Bug#8722)
08686060 4409
2d1fc3c7
PE
4410 * dbusbind.c: Use XFASTINT rather than XUINT, and check for nonneg.
4411 (Fdbus_call_method, Fdbus_call_method_asynchronously):
4412 Use XFASTINT rather than XUINT when numbers are nonnegative.
4413 (xd_append_arg, Fdbus_method_return_internal):
4414 (Fdbus_method_error_internal): Likewise. Also, for unsigned
4415 arguments, check that Lisp number is nonnegative, rather than
59568bf0 4416 silently wrapping negative numbers around. (Bug#8722)
30217ff0 4417 (xd_read_message_1): Don't assume dbus_uint32_t can fit in int.
59568bf0 4418 (Bug#8722)
2d1fc3c7 4419
c8a9ca5a
PE
4420 * data.c (arith_driver, Flsh): Avoid unnecessary casts to EMACS_UINT.
4421
519e1d69
PE
4422 * ccl.c (ccl_driver): Redo slightly to avoid the need for 'unsigned'.
4423
30569699
PE
4424 ccl: add integer overflow checks
4425 * ccl.c (CCL_CODE_MAX, GET_CCL_RANGE, GET_CCL_CODE, GET_CCL_INT):
4426 (IN_INT_RANGE): New macros.
4427 (ccl_driver): Use them to check for integer overflow when
4428 decoding a CCL program. Many of the new checks are whether XINT (x)
4429 fits in int; it doesn't always, on 64-bit hosts. The new version
4430 doesn't catch all possible integer overflows, but it's an
847044ea 4431 improvement. (Bug#8719)
30569699 4432
c11285dc
PE
4433 * alloc.c (make_event_array): Use XINT, not XUINT.
4434 There's no need for unsigned here.
4435
fdccd48e
PE
4436 * mem-limits.h (EXCEEDS_LISP_PTR) [!USE_LSB_TAG]: EMACS_UINT -> uintptr_t
4437 This follows up to the 2011-05-06 change that substituted uintptr_t
4438 for EMACS_INT. This case wasn't caught back then.
4439
37910ab2
PE
4440 Rework Fformat to avoid integer overflow issues.
4441 * editfns.c: Include <float.h> unconditionally, as it's everywhere
4442 now (part of C89). Include <verify.h>.
4443 (MAX_10_EXP, CONVERTED_BYTE_SIZE): Remove; no longer needed.
4444 (pWIDE, pWIDElen, signed_wide, unsigned_wide): New defns.
4445 (Fformat): Avoid the prepass trying to compute sizes; it was only
4446 approximate and thus did not catch overflow reliably. Instead, walk
4447 through the format just once, formatting and computing sizes as we go,
4448 checking for integer overflow at every step, and allocating a larger
4449 buffer as needed. Keep track separately whether the format is
4450 multibyte. Keep only the most-recently calculated precision, rather
4451 than them all. Record whether each argument has been converted to
4452 string. Use EMACS_INT, not int, for byte and char and arg counts.
4453 Support field widths and precisions larger than INT_MAX. Avoid
4454 sprintf's undefined behavior with conversion specifications such as %#d
4455 and %.0c. Fix bug with strchr succeeding on '\0' when looking for
4456 flags. Fix bug with (format "%c" 256.0). Avoid integer overflow when
4457 formatting out-of-range floating point numbers with int
9173deec 4458 formats. (Bug#8668)
37910ab2 4459
2e6578fb
PE
4460 * lisp.h (FIXNUM_OVERFLOW_P): Work even if arg is a NaN.
4461
0ae6bdee
PE
4462 * data.c: Avoid integer truncation in expressions involving floats.
4463 * data.c: Include <intprops.h>.
4464 (arith_driver): When there's an integer overflow in an expression
4465 involving floating point, convert the integers to floating point
4466 so that the resulting value does not suffer from catastrophic
4467 integer truncation. For example, on a 64-bit host (* 4
4468 most-negative-fixnum 0.5) should yield about -4.6e+18, not zero.
4469 Do not rely on undefined behavior after integer overflow.
4470
de883a70
PE
4471 merge count_size_as_multibyte, parse_str_to_multibyte
4472 * character.c, character.h (count_size_as_multibyte):
fd6fa53f 4473 Rename from parse_str_to_multibyte; all uses changed.
de883a70
PE
4474 Check for integer overflow.
4475 * insdel.c, lisp.h (count_size_as_multibyte): Remove,
4476 since it's now a duplicate of the other. This is more of
4477 a character than a buffer op, so better that it's in character.c.
4478 * fns.c, print.c: Adjust to above changes.
4479
2ff916cb
PE
44802011-05-27 Stefan Monnier <monnier@iro.umontreal.ca>
4481
4482 * xselect.c (x_convert_selection): Yet another int/Lisp_Object mixup.
4483
f1b54466
PE
44842011-05-27 Paul Eggert <eggert@cs.ucla.edu>
4485
fb1ac845
PE
4486 * xselect.c: Fix minor problems prompted by GCC 4.6.0 warnings.
4487 (x_handle_selection_request, frame_for_x_selection): Remove unused vars.
4488 (x_clipboard_manager_save): Now static.
4489 (Fx_clipboard_manager_save): Rename local to avoid shadowing.
4490
f1b54466
PE
4491 * fns.c: Fix minor problems prompted by GCC 4.6.0 warnings.
4492 (crypto_hash_function): Now static.
4493 Fix pointer signedness problems. Avoid unnecessary initializations.
4494
a9f737ee
CY
44952011-05-27 Chong Yidong <cyd@stupidchicken.com>
4496
4497 * termhooks.h (Vselection_alist): Make it terminal-local.
4498
4499 * terminal.c (create_terminal): Initialize it.
4500
4501 * xselect.c: Support for clipboard managers.
4502 (Vselection_alist): Move to termhooks.h as terminal-local var.
4503 (LOCAL_SELECTION): New macro.
4504 (x_atom_to_symbol): Handle x_display_info_for_display fail case.
4505 (symbol_to_x_atom): Remove gratuitous arg.
4506 (x_handle_selection_request, lisp_data_to_selection_data)
4507 (x_get_foreign_selection, Fx_register_dnd_atom): Callers changed.
620c53a6
SM
4508 (x_own_selection, x_get_local_selection, x_convert_selection):
4509 New arg, specifying work frame. Use terminal-local Vselection_alist.
a9f737ee
CY
4510 (some_frame_on_display): Delete unused function.
4511 (Fx_own_selection_internal, Fx_get_selection_internal)
4512 (Fx_disown_selection_internal, Fx_selection_owner_p)
4513 (Fx_selection_exists_p): New optional frame arg.
4514 (frame_for_x_selection, Fx_clipboard_manager_save): New functions.
4515 (x_handle_selection_clear): Don't treat other terminals with the
4516 same keyboard specially. Use the terminal-local Vselection_alist.
4517 (x_clear_frame_selections): Use Frun_hook_with_args.
4518
4519 * xterm.c (x_term_init): Intern ATOM and CLIPBOARD_MANAGER atoms.
4520
4521 * xterm.h: Add support for those atoms.
4522
e067f0c1
CY
45232011-05-26 Chong Yidong <cyd@stupidchicken.com>
4524
4525 * xselect.c: ICCCM-compliant handling of MULTIPLE targets.
4526 (converted_selections, conversion_fail_tag): New global variables.
4527 (x_selection_request_lisp_error): Free the above.
4528 (x_get_local_selection): Remove unnecessary code.
4529 (x_reply_selection_request): Args changed; handle arbitrary array
620c53a6
SM
4530 of converted selections stored in converted_selections.
4531 Separate the XChangeProperty and SelectionNotify steps.
e067f0c1
CY
4532 (x_handle_selection_request): Rewrite to handle MULTIPLE target.
4533 (x_convert_selection): New function.
4534 (x_handle_selection_event): Simplify.
4535 (x_get_foreign_selection): Don't ignore incoming requests while
4536 waiting for an answer; this will fail when we implement
4537 SAVE_TARGETS, and seems unnecessary anyway.
4538 (selection_data_to_lisp_data): Recognize ATOM_PAIR type.
4539 (Vx_sent_selection_functions): Doc fix.
4540
0f4aebc0
LL
45412011-05-26 Leo Liu <sdl.web@gmail.com>
4542
4543 * editfns.c (Ftranspose_regions): Allow empty regions. (Bug#8699)
4544
e61124cd
YM
45452011-05-25 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
4546
4547 * dispextern.h (struct glyph_row): New member fringe_bitmap_periodic_p.
4548
4549 * dispnew.c (shift_glyph_matrix, scrolling_window): Mark scrolled row
4550 for fringe update if it has periodic bitmap.
ac389d0c 4551 (row_equal_p): Also compare left_fringe_offset, right_fringe_offset,
e61124cd
YM
4552 and fringe_bitmap_periodic_p.
4553
4554 * fringe.c (get_fringe_bitmap_data): New function.
4555 (draw_fringe_bitmap_1, update_window_fringes): Use it.
4556 (update_window_fringes): Record periodicity of fringe bitmap in glyph
4557 row. Mark glyph row for fringe update if periodicity changed.
4558
4559 * xdisp.c (try_window_reusing_current_matrix): Don't mark scrolled row
4560 for fringe update unless it has periodic bitmap.
4561
f16d9837
KH
45622011-05-25 Kenichi Handa <handa@m17n.org>
4563
4564 * xdisp.c (get_next_display_element): Set correct it->face_id for
4565 a static composition.
4566
e1b90ef6
LL
45672011-05-24 Leo Liu <sdl.web@gmail.com>
4568
4569 * deps.mk (fns.o):
4570 * makefile.w32-in ($(BLD)/fns.$(O)): Include sha1.h.
4571
4572 * fns.c (crypto_hash_function, Fsha1): New function.
4573 (Fmd5): Use crypto_hash_function.
4574 (syms_of_fns): Add Ssha1.
4575
7400048f
PE
45762011-05-22 Paul Eggert <eggert@cs.ucla.edu>
4577
4578 * gnutls.c: Remove unused macros.
4579 (fn_gnutls_transport_set_lowat, fn_gnutls_transport_set_pull_function):
4580 (fn_gnutls_transport_set_push_function) [!WINDOWSNT]:
4581 Remove macros that are defined and never used.
4582 Caught by gcc -Wunused-macros (GCC 4.6.0, Fedora 14).
4583
abb71cf4
CY
45842011-05-22 Chong Yidong <cyd@stupidchicken.com>
4585
4586 * xselect.c (syms_of_xselect): Remove unused symbol SAVE_TARGETS.
4587 (Fx_get_selection_internal): Minor cleanup.
4588 (Fx_own_selection_internal): Rename arguments for consistency with
4589 select.el.
4590
6307db39
PE
45912011-05-22 Paul Eggert <eggert@cs.ucla.edu>
4592
4593 * xselect.c (QSAVE_TARGETS): New static var, to fix build failure.
4594
f3d4e0a4
CY
45952011-05-22 Chong Yidong <cyd@stupidchicken.com>
4596
4597 * xselect.c (syms_of_xselect): Include character.h; use DEFSYM.
4598
4d8ade89
YM
45992011-05-21 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
4600
4601 * dispnew.c (scrolling_window): Don't exclude the case that the
4602 last enabled row in the desired matrix touches the bottom boundary.
4603
32078c8d
GM
46042011-05-21 Glenn Morris <rgm@gnu.org>
4605
4606 * Makefile.in ($(etc)/DOC): Make second command line even shorter.
33cf345f
GM
4607 (SOME_MACHINE_OBJECTS): Replace FONT_OBJ by its maximal expansion,
4608 and add some more files.
32078c8d 4609
7285dc67
EZ
46102011-05-20 Eli Zaretskii <eliz@gnu.org>
4611
4612 * callproc.c (Fcall_process) [MSDOS]: Fix arguments to
4613 report_file_error introduced by the change from 2011-05-07.
4614
89d1bd22
PE
46152011-05-20 Paul Eggert <eggert@cs.ucla.edu>
4616
4617 * systime.h (Time): Define only if emacs is defined.
4618 This is to allow ../lib-src/profile.c to be compiled on FreeBSD,
4619 where the include path doesn't have X11/X.h by default. See
4620 <http://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00561.html>.
4621
e23640bb 46222011-05-20 Kenichi Handa <handa@m17n.org>
31bfc35c
KH
4623
4624 * composite.c (find_automatic_composition): Fix previous change.
4625
b9704ad9
GM
46262011-05-20 Glenn Morris <rgm@gnu.org>
4627
4628 * lisp.mk: New file, split from Makefile.in.
4629 * Makefile.in (lisp): Move to separate file, inserted by @lisp_frag@.
4630 (shortlisp): Remove.
4631 ($(etc)/DOC): Edit lisp.mk rather than using $shortlisp.
4632
4a720484
GM
46332011-05-19 Glenn Morris <rgm@gnu.org>
4634
4635 * Makefile.in (MSDOS_SUPPORT_REAL, MSDOS_SUPPORT, NS_SUPPORT)
4636 (REAL_MOUSE_SUPPORT, GPM_MOUSE_SUPPORT, MOUSE_SUPPORT, TOOLTIP_SUPPORT)
4637 (BASE_WINDOW_SUPPORT, X_WINDOW_SUPPORT, WINDOW_SUPPORT): Remove.
4638 (lisp): Set the order to that of loadup.el.
4639 (shortlisp): Make it a copy of $lisp.
4640 (SOME_MACHINE_LISP): Remove.
4641 ($(etc)/DOC): Depend just on $lisp, not $SOME_MACHINE_LISP too.
4642 Use just $shortlisp, not $SOME_MACHINE_LISP too.
4643
a28d4396
KH
46442011-05-18 Kenichi Handa <handa@m17n.org>
4645
4646 * composite.c (CHAR_COMPOSABLE_P): Add more check for efficiency.
4647 (BACKWARD_CHAR): Wrap the arg STOP by parenthesis.
4648 (find_automatic_composition): Mostly rewrite for efficiency.
4649
a2b1fa8e
JB
46502011-05-18 Juanma Barranquero <lekktu@gmail.com>
4651
4652 * makefile.w32-in: Update dependencies.
4653
8e1f5610
CS
46542011-05-18 Christoph Scholtes <cschol2112@googlemail.com>
4655
4656 * menu.c: Include limits.h (fixes the MS-Windows build broken by
7d7d0045 4657 2011-06-18T18:49:19Z!cyd@stupidchicken.com).
8e1f5610 4658
7025ee00 46592011-05-18 Paul Eggert <eggert@cs.ucla.edu>
cb93f9be 4660
cdfa6eab
PE
4661 Fix some integer overflow issues, such as string length overflow.
4662
06d6db33
PE
4663 * insdel.c (count_size_as_multibyte): Check for string overflow.
4664
2b4560a8
PE
4665 * character.c (lisp_string_width): Check for string overflow.
4666 Use EMACS_INT, not int, for string indexes and lengths; in
4667 particular, 2nd arg is now EMACS_INT, not int. Do not crash if
4668 the resulting string length overflows an EMACS_INT; instead,
4669 report a string overflow if no precision given. When checking for
4670 precision exhaustion, use a check that cannot possibly have
4671 integer overflow. (Bug#8675)
4672 * character.h (lisp_string_width): Adjust to new signature.
4673
cb93f9be
PE
4674 * alloc.c (string_overflow): New function.
4675 (Fmake_string): Use it. This doesn't change behavior, but saves
4676 a few bytes and will simplify future changes.
4677 * character.c (string_escape_byte8): Likewise.
4678 * lisp.h (string_overflow): New decl.
4679
1a1f3366
PE
4680 Fixups, following up to the user-interface timestamp change.
4681 * nsterm.m (last_mouse_movement_time, ns_mouse_position): Use Time
4682 for UI timestamps, instead of unsigned long.
9fbd6841
PE
4683 * msdos.c (mouse_get_pos): Likewise.
4684 * w32inevt.c (movement_time, w32_console_mouse_position): Likewise.
1a1f3366
PE
4685 * w32gui.h (Time): Define by including "systime.h" rather than by
4686 declaring it ourselves. (Bug#8664)
4687
d4e3e4d3
PE
4688 * dispextern.h (struct image): Don't assume time_t <= unsigned long.
4689 * image.c (clear_image_cache): Likewise.
4690
f6a24d19
PE
4691 * term.c (term_mouse_position): Don't assume time_t wraparound.
4692
08dc5ae6
PE
4693 Be more systematic about user-interface timestamps.
4694 Before, the code sometimes used 'Time', sometimes 'unsigned long',
620c53a6
SM
4695 and sometimes 'EMACS_UINT', to represent these timestamps.
4696 This change causes it to use 'Time' uniformly, as that's what X uses.
08dc5ae6
PE
4697 This makes the code easier to follow, and makes it easier to catch
4698 integer overflow bugs such as Bug#8664.
4699 * frame.c (Fmouse_position, Fmouse_pixel_position):
4700 Use Time, not unsigned long, for user-interface timestamps.
4701 * keyboard.c (last_event_timestamp, kbd_buffer_get_event): Likewise.
4702 (button_down_time, make_lispy_position, make_lispy_movement): Likewise.
4703 * keyboard.h (last_event_timestamp): Likewise.
4704 * menu.c (Fx_popup_menu) [!HAVE_X_WINDOWS]: Likewise.
4705 * menu.h (xmenu_show): Likewise.
4706 * term.c (term_mouse_position): Likewise.
4707 * termhooks.h (struct input_event.timestamp): Likewise.
4708 (struct terminal.mouse_position_hook): Likewise.
4709 * xmenu.c (create_and_show_popup_menu, xmenu_show): Likewise.
4710 * xterm.c (XTmouse_position, x_scroll_bar_report_motion): Likewise.
4711 * systime.h (Time): New decl. Pull it in from <X11/X.h> if
4712 HAVE_X_WINDOWS, otherwise define it as unsigned long, which is
4713 what it was before.
4714 * menu.h, termhooks.h: Include "systime.h", for Time.
4715
8e55734a
PE
4716 * keyboard.c (make_lispy_event): Fix problem in integer overflow.
4717 Don't assume that the difference between two unsigned long values
4718 can fit into an integer. At this point, we know button_down_time
4719 <= event->timestamp, so the difference must be nonnegative, so
4720 there's no need to cast the result if double-click-time is
4721 nonnegative, as it should be; check that it's nonnegative, just in
4722 case. This bug is triggered when events are more than 2**31 ms
86db42d2 4723 apart (about 25 days). (Bug#8664)
8e55734a 4724
841f1b75 4725 * xselect.c (last_event_timestamp): Remove duplicate decl.
6434756c 4726 (x_own_selection): Remove needless cast to unsigned long.
841f1b75 4727
3e26f69c
PE
4728 * xmenu.c (set_frame_menubar): Use int, not EMACS_UINT, for indexes
4729 that always fit in int. Use a sentinel instead of a counter, to
4730 avoid a temp and to allay GCC's concerns about possible int overflow.
d230cb74
PE
4731 * frame.h (struct frame): Use int for menu_bar_items_used
4732 instead of EMACS_INT, since it always fits in int.
3e26f69c 4733
5cc152c0
PE
4734 * menu.c (grow_menu_items): Check for int overflow.
4735
d89eb65e
PE
4736 * xmenu.c (set_frame_menubar): Don't mishandle vectors with no nils.
4737
5235bd3e
PE
4738 * xterm.c: Use EMACS_INT for Emacs modifiers, and int for X modifiers.
4739 Before, the code was not consistent. These values cannot exceed
4740 2**31 - 1 so there's no need to make them unsigned.
4741 (x_x_to_emacs_modifiers): Accept int and return EMACS_INT.
4742 (x_emacs_to_x_modifiers): Accept EMACS_INT and return int.
4743 (x_x_to_emacs_modifiers, x_emacs_to_x_modifiers): Reject non-integers
4744 as modifiers.
4745 * xterm.h (x_x_to_emacs_modifiers): Adjust to signature change.
4746
bc827e23
PE
4747 * lisp.h (XINT) [USE_LISP_UNION_TYPE]: Cast to EMACS_INT.
4748 (XUINT) [USE_LISP_UNION_TYPE]: Cast to EMACS_UINT.
4749 Otherwise, GCC 4.6.0 warns about printf (pI, XINT (...)),
4750 presumably because the widths might not match.
4751
78eb494e
PE
4752 * window.c (size_window): Avoid needless test at loop start.
4753
04f2d78b
CB
47542011-05-18 Courtney Bane <emacs-bugs-7626@cbane.org> (tiny change)
4755
4756 * term.c (Fresume_tty): Restore hooks before reinitializing (bug#8687).
4757
d2fc7e3d 47582011-05-12 Drew Adams <drew.adams@oracle.com>
e531bdff
DA
4759
4760 * textprop.c (Fprevious_single_char_property_change): Doc fix (bug#8655).
4761
d2fc7e3d 47622011-05-12 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
7db47798
YM
4763
4764 * w32term.c (w32_draw_fringe_bitmap): Rename local vars `left' and
4765 `width' to `bar_area_x' and `bar_area_width', respectively.
4766 (x_scroll_run): Take account of fringe background extension.
4767
04f2d78b
CB
4768 * xterm.c (x_draw_fringe_bitmap) [USE_TOOLKIT_SCROLL_BARS]:
4769 Rename local vars `left' and `width' to `bar_area_x' and
7db47798
YM
4770 `bar_area_width', respectively.
4771 (x_scroll_run) [USE_TOOLKIT_SCROLL_BARS]: Take account of fringe
4772 background extension.
4773
79b70037
GM
47742011-05-10 Jim Meyering <meyering@redhat.com>
4775
4776 * xdisp.c (x_intersect_rectangles): Fix typo "the the -> the".
4777
2f142cc5
JB
47782011-05-10 Juanma Barranquero <lekktu@gmail.com>
4779
4780 * image.c (Finit_image_library): Return t for built-in image types,
4781 like pbm and xbm. (Bug#8640)
4782
57679c86
AS
47832011-05-09 Andreas Schwab <schwab@linux-m68k.org>
4784
4785 * w32menu.c (set_frame_menubar): Fix submenu allocation.
4786
888c9e86
EZ
47872011-05-07 Eli Zaretskii <eliz@gnu.org>
4788
b0512a1d
EZ
4789 * w32console.c (Fset_screen_color): Doc fix.
4790 (Fget_screen_color): New function.
4791 (syms_of_ntterm): Defsubr it.
4792
7285dc67
EZ
4793 * callproc.c (call_process_cleanup) [MSDOS]: Don't close and
4794 unlink the temporary file if Fcall_process didn't create it in the
4795 first place.
4796 (Fcall_process) [MSDOS]: Don't create tempfile if stdout of the
4797 child process will be redirected to a file specified with `:file'.
888c9e86
EZ
4798 Don't try to re-open tempfile in that case, and set fd[0] to -1 as
4799 cue to call_process_cleanup not to close that handle.
4800
4d3fcc8e
BK
48012011-05-07 Ben Key <bkey76@gmail.com>
4802
4803 * makefile.w32-in: The bootstrap-temacs rule now makes use of
4804 one of two shell specific rules, either bootstrap-temacs-CMD or
4805 bootstrap-temacs-SH. The bootstrap-temacs-SH rule is identical
4806 to the previous implementation of the bootstrap-temacs rule.
4807 The bootstrap-temacs-CMD rule is similar to the previous
4808 implementation of the bootstrap-temacs rule except that it
4809 makes use of the ESC_CFLAGS variable instead of the CFLAGS
4810 variable.
4811
4812 These changes, along with some changes to nt/configure.bat,
4813 nt/gmake.defs, and nt/nmake.defs, are required to extend my
4814 earlier fix to add support for --cflags and --ldflags options
4815 that include quotes so that it works whether make uses cmd or
4816 sh as the shell.
4817
b4289b64
MA
48182011-05-06 Michael Albinus <michael.albinus@gmx.de>
4819
4820 * dbusbind.c (QCdbus_type_unix_fd): Declare static.
4821 (xd_remove_watch): Don't check QCdbus_type_unix_fd for SYMBOLP, it
4822 is a constant.
4823 (Fdbus_init_bus, xd_read_queued_messages): Bus can be a symbol or
4824 a string. Handle both cases.
4825 (Fdbus_call_method_asynchronously, Fdbus_register_signal)
4826 (Fdbus_register_method): Use Qinvalid_function.
4827
af4c0e28
JB
48282011-05-06 Juanma Barranquero <lekktu@gmail.com>
4829
4830 * makefile.w32-in: Update dependencies.
4831 (LISP_H): Add inttypes.h and stdin.h.
4832 (PROCESS_H): Add unistd.h.
4833
c51453d9
EZ
48342011-05-06 Eli Zaretskii <eliz@gnu.org>
4835
4836 * lread.c: Include limits.h (fixes the MS-Windows build broken by
4837 2011-05-06T07:13:19Z!eggert@cs.ucla.edu).
4838
8ff0ac3c 48392011-05-06 Paul Eggert <eggert@cs.ucla.edu>
c032b5f8 4840
4c4b566b
PE
4841 * image.c (Finit_image_library) [!HAVE_NTGUI]: Omit unused local.
4842
aab2b9b5
PE
4843 * term.c (vfatal): Remove stray call to va_end.
4844 It's not needed and the C Standard doesn't allow it here anyway.
4845
c378da0b
PE
4846 Use C99's va_copy to avoid undefined behavior on x86-64 GNU/Linux.
4847 * eval.c (verror): doprnt a copy of ap, not the original. (Bug#8545)
4848
288b08c7
PE
4849 * eval.c (verror): OK to create a string of up to MOST_POSITIVE_FIXNUM
4850 bytes.
4851
e3601888
PE
4852 * term.c: Don't include <stdarg.h>, as <lisp.h> does that.
4853
db6c0e74
PE
4854 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork clobbering.
4855
dd5963ea
PE
4856 * process.c (Fformat_network_address): Fix typo: args2 -> *args2.
4857
88c9450f
PE
4858 * xmenu.c (set_frame_menubar): Fix typo: int * -> int (3 times).
4859
2f9442b8
PE
4860 * coding.c (detect_coding_charset): Fix typo: * 2 -> *4 (Bug#8601).
4861
c032b5f8
PE
4862 * charset.h (struct charset.code_space): Now has 15 elements, not 16.
4863 * charset.c (Fdefine_charset_internal): Don't initialize
4864 charset.code_space[15]. The value was garbage, on hosts with
2d38271b 4865 32-bit int (Bug#8600).
a108c10b
PE
4866
4867 * lread.c (read_integer): Be more consistent with string-to-number.
4868 Use string_to_number to do the actual conversion; this avoids
4869 rounding errors and fixes some other screwups. Without this fix,
4870 for example, #x1fffffffffffffff was misread as -2305843009213693952.
4871 (digit_to_number): Move earlier, for benefit of read_integer.
4872 Return -1 if the digit is out of range for the base, -2 if it is
48e400f0 4873 not a digit in any supported base. (Bug#8602)
a108c10b 4874
ad5f9eea
PE
4875 * doprnt.c (doprnt): Support arbitrary pI values, such as "I64".
4876
aec1708a
PE
4877 * dispnew.c (scrolling_window): Return 1 if we scrolled,
4878 to match comment at start of function. This also removes a
4879 GCC warning about overflow in a 32+64-bit port.
4880
47be4ab5
PE
4881 * lisp.h (EMACS_INT, EMACS_UINT, BITS_PER_EMACS_INT, pI): Simplify.
4882
371cac43
PE
4883 * dbusbind.c: Do not use XPNTR on a value that may be an integer.
4884 Reported by Stefan Monnier in
4885 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00919.html>.
04f2d78b
CB
4886 (xd_remove_watch, Fdbus_init_bus, xd_read_queued_messages):
4887 Use SYMBOLP-guarded XSYMBOL, not XPNTR.
371cac43 4888
d01a7826
PE
4889 * lisp.h (EMACS_INTPTR): Remove. All uses changed to intptr_t.
4890 (EMACS_UINTPTR): Likewise, with uintptr_t.
4891
7fd47d5c
PE
4892 * lisp.h: Prefer 64-bit EMACS_INT if available.
4893 (EMACS_INT, EMACS_UINT, BITS_PER_EMACS_INT, pI): Define to 64-bit
4894 on 32-bit hosts that have 64-bit int, so that they can access
4895 large files.
122b0c86
PE
4896 However, temporarily disable this change unless the temporary
4897 symbol WIDE_EMACS_INT is defined.
7fd47d5c 4898
8727937b
PE
4899 * lread.c, process.c: Do not include <inttypes.h>; lisp.h does it now.
4900
8ac068ac
PE
4901 Prefer intptr_t/uintptr_t for integers the same widths as pointers.
4902 This removes an assumption that EMACS_INT and long are the same
4903 width as pointers. The assumption is true for Emacs porting targets
4904 now, but we want to make other targets possible.
4905 * lisp.h: Include <inttypes.h>, for INTPTR_MAX, UINTPTR_MAX.
4906 (EMACS_INTPTR, EMACS_UINTPTR): New macros.
4907 In the rest of the code, change types of integers that hold casted
4908 pointers to EMACS_INTPTR and EMACS_UINTPTR, systematically
4909 replacing EMACS_INT, long, EMACS_UINT, and unsigned long.
4910 (XTYPE): Don't cast arg to EMACS_UINT; normally is not needed.
4911 (XSET): Cast type of XTYPE arg to EMACS_INTPTR; it is needed here.
4912 No need to cast type when ORing.
4913 (XPNTR): Return a value of type EMACS_INTPTR or EMACS_UINTPTR.
4914 * alloc.c (lisp_align_malloc): Remove a no-longer-needed cast.
4915 * doc.c (store_function_docstring): Use EMACS_INTPTR, so as not to
4916 assume EMACS_INT is the same width as char *.
4917 * gtkutil.c (xg_gtk_scroll_destroy, xg_tool_bar_button_cb):
4918 (xg_tool_bar_callback, xg_tool_bar_help_callback, xg_make_tool_item):
4919 Remove no-longer-needed casts.
4920 (xg_create_scroll_bar, xg_tool_bar_button_cb, xg_tool_bar_callback):
4921 (xg_tool_bar_help_callback, xg_make_tool_item):
4922 Use EMACS_INTPTR to hold an integer
4923 that will be cast to void *; this can avoid a GCC warning
4924 if EMACS_INT is not the same width as void *.
4925 * menu.c (find_and_call_menu_selection): Remove no-longer-needed cast.
4926 * xdisp.c (display_echo_area_1, resize_mini_window_1):
4927 (current_message_1, set_message_1):
4928 Use a local to convert to proper width without a cast.
4929 * xmenu.c (dialog_selection_callback): Likewise.
4930
ede49d71
PE
4931 * sysdep.c (get_random): Don't assume EMACS_INT is no wider than long.
4932 Also, don't assume VALBITS / RAND_BITS is less than 5,
4933 and don't rely on undefined behavior when shifting a 1 left into
4934 the sign bit.
4935 * lisp.h (get_random): Change signature to match.
4936
2f30ecd0
PE
4937 * lread.c (hash_string): Use size_t, not int, for hash computation.
4938 Normally we prefer signed values; but hashing is special, because
4939 it's better to use unsigned division on hash table sizes so that
4940 the remainder is nonnegative. Also, size_t is the natural width
4941 for hashing into memory. The previous code used 'int', which doesn't
4942 retain enough info to hash well into very large tables.
4943 (oblookup, oblookup_last_bucket_number, Funintern): Likewise.
4944
2a866e7b
PE
4945 * dbusbind.c: Don't possibly lose pointer info when converting.
4946 (xd_remove_watch, Fdbus_init_bus, xd_read_queued_messages):
4947 Use XPNTR rather than XHASH, so that the high-order bits of
4948 the pointer aren't lost when converting through void *.
4949
51639eac
PE
4950 * eval.c (Fautoload): Don't double-shift a pointer.
4951
92394119
PE
4952 * fns.c (Frandom): Let EMACS_UINT be wider than unsigned long.
4953
dbdb9a7c
JB
49542011-05-06 Juanma Barranquero <lekktu@gmail.com>
4955
4956 * gnutls.c (DEF_GNUTLS_FN):
4957 * image.c (DEF_IMGLIB_FN): Make function pointers static.
4958
db7a0b4f
AS
49592011-05-05 Andreas Schwab <schwab@linux-m68k.org>
4960
4961 * lread.c (lisp_file_lexically_bound_p): Stop scanning at end
4962 marker. (Bug#8610)
4963
f7ff1b0f 49642011-05-05 Eli Zaretskii <eliz@gnu.org>
fab624aa
EZ
4965
4966 * w32heap.c (allocate_heap) [USE_LISP_UNION_TYPE || USE_LSB_TAG]:
4967 New version that can reserve upto 2GB of heap space.
4968
f7ff1b0f 49692011-05-05 Chong Yidong <cyd@stupidchicken.com>
45cb8994
CY
4970
4971 * nsfns.m (Fns_read_file_name): Doc fix (Bug#8534).
4972
639c109b
TZ
49732011-05-05 Teodor Zlatanov <tzz@lifelogs.com>
4974
4975 * gnutls.c (fn_gnutls_certificate_set_x509_key_file): Add alias to
4976 `gnutls_certificate_set_x509_key_file'.
4977
d2127135
JB
49782011-05-05 Juanma Barranquero <lekktu@gmail.com>
4979
4980 * makefile.w32-in ($(BLD)/image.$(O), $(BLD)/process.$(O)):
4981 Update dependencies.
4982
e968f4f3
JB
49832011-05-04 Juanma Barranquero <lekktu@gmail.com>
4984
4985 * gnutls.h (emacs_gnutls_write, emacs_gnutls_read):
4986 * gnutls.c (emacs_gnutls_write, emacs_gnutls_read):
4987 Remove unused parameter `fildes'.
4988 * process.c (read_process_output, send_process): Don't pass it.
4989
84d358f0
JB
49902011-05-04 Juanma Barranquero <lekktu@gmail.com>
4991
4992 Fix previous change: the library cache is defined in w32.c.
4993 * image.c (CACHE_IMAGE_TYPE) [!HAVE_NTGUI]: Define to noop.
4994 (Finit_image_library): Wrap Vlibrary_cache on "#ifdef HAVE_NTGUI".
4995
0898ca10
JB
49962011-05-04 Juanma Barranquero <lekktu@gmail.com>
4997
4998 Implement dynamic loading of GnuTLS on Windows.
4999
5000 * gnutls.h (GNUTLS_EMACS_ERROR_NOT_LOADED): New macro.
5001 (emacs_gnutls_write, emacs_gnutls_read): Mark as extern.
5002 (emacs_gnutls_record_check_pending, emacs_gnutls_transport_set_errno):
5003 Declare.
5004
5005 * gnutls.c (Qgnutls_dll): Define.
5006 (DEF_GNUTLS_FN, LOAD_GNUTLS_FN): New macros.
5007 (gnutls_*): Declare function pointers.
5008 (init_gnutls_functions): New function to initialize function pointers.
5009 (emacs_gnutls_handshake, Fgnutls_error_string, Fgnutls_deinit)
5010 (emacs_gnutls_global_init, Fgnutls_bye): Use function pointers.
5011 (emacs_gnutls_record_check_pending, emacs_gnutls_transport_set_errno):
5012 Wrappers for gnutls_record_check_pending and gnutls_transport_set_errno.
5013 (emacs_gnutls_write, emacs_gnutls_read)
5014 (emacs_gnutls_handle_error, Fgnutls_error_fatalp)
5015 (Fgnutls_available_p): New function.
5016 (Fgnutls_boot): Call Fgnutls_available_p. Use function pointers.
5017 (syms_of_gnutls) <Qgnutls_dll>: Initialize and staticpro it.
5018 (syms_of_gnutls) <Sgnutls_available_p>: defsubr it.
5019
5020 * image.c: Include w32.h.
5021 (Vimage_type_cache): Delete.
5022 (syms_of_image) <Vimage_type_cache>: Don't initialize and staticpro it.
5023 (CACHE_IMAGE_TYPE, Finit_image_library): Use Vlibrary_cache instead.
5024 (w32_delayed_load): Move to w32.c.
5025
5026 * w32.h (VlibraryCache, QCloaded_from, w32_delayed_load): Declare.
5027
5028 * w32.c (QCloaded_from, Vlibrary_cache): Define.
5029 (w32_delayed_load): Move from image.c. When loading a library, record
5030 its filename in the :loaded-from property of the library id.
5031 (globals_of_w32) <QCloaded_from, Vlibrary_cache>:
5032 Initialize and staticpro them.
5033 (emacs_gnutls_pull, emacs_gnutls_push): Call emacs_gnutls_* functions.
5034
5035 * process.c: Include lisp.h before w32.h, not after.
5036 (wait_reading_process_output): Call emacs_gnutls_record_check_pending
5037 instead of gnutls_record_check_pending.
5038
5039 * callproc.c, emacs.c: Include lisp.h before w32.h, not after.
5040
ff4de4aa
TZ
50412011-05-04 Teodor Zlatanov <tzz@lifelogs.com>
5042
5043 * gnutls.c (Fgnutls_boot): Support :keylist and :crlfiles options
5044 instead of :keyfiles. Give GnuTLS the keylist and the CRL lists
5045 as passed in.
5046
abe95abb
JD
50472011-05-03 Jan Djärv <jan.h.d@swipnet.se>
5048
5049 * xterm.c (x_set_frame_alpha): Do not set property on anything
5050 else than FRAME_X_OUTER_WINDOW (Bug#8608).
5051
e16e55d4
JB
50522011-05-02 Juanma Barranquero <lekktu@gmail.com>
5053
5054 * sysdep.c (get_tty_size) [WINDOWSNT]: Implement. (Bug#8596)
5055
bafcf6a5
JB
50562011-05-02 Juanma Barranquero <lekktu@gmail.com>
5057
5058 * gnutls.c (Qgnutls_log_level, Qgnutls_code, Qgnutls_anon)
5059 (Qgnutls_x509pki, Qgnutls_e_interrupted, Qgnutls_e_again)
5060 (Qgnutls_e_invalid_session, Qgnutls_e_not_ready_for_handshake)
5061 (gnutls_global_initialized, Qgnutls_bootprop_priority)
5062 (Qgnutls_bootprop_trustfiles, Qgnutls_bootprop_keyfiles)
5063 (Qgnutls_bootprop_callbacks, Qgnutls_bootprop_loglevel)
5064 (Qgnutls_bootprop_hostname, Qgnutls_bootprop_verify_flags)
5065 (Qgnutls_bootprop_verify_error, Qgnutls_bootprop_verify_hostname_error)
5066 (Qgnutls_bootprop_callbacks_verify): Make static.
5067
e7a6747f
AS
50682011-05-01 Andreas Schwab <schwab@linux-m68k.org>
5069
19ed11ba
AS
5070 * callproc.c: Indentation fixup.
5071
e7a6747f 5072 * sysdep.c (wait_for_termination_1): Make static.
04f2d78b
CB
5073 (wait_for_termination, interruptible_wait_for_termination):
5074 Move after wait_for_termination_1.
e7a6747f 5075
1ef14cb4
LMI
50762011-05-01 Lars Magne Ingebrigtsen <larsi@gnus.org>
5077
5078 * sysdep.c (interruptible_wait_for_termination): New function
5079 which is like wait_for_termination, but allows keyboard
5080 interruptions.
5081
5082 * callproc.c (Fcall_process): Add (:file "file") as an option for
5083 the STDOUT buffer.
5084 (Fcall_process_region): Ditto.
5085
330d880c
EZ
50862011-04-30 Eli Zaretskii <eliz@gnu.org>
5087
8db90b73
EZ
5088 * dosfns.c (Fint86, Fdos_memget, Fdos_memput): Use `ASIZE (FOO)'
5089 rather than `XVECTOR (FOO)->size'.
5090
330d880c
EZ
5091 * process.c: Remove HAVE_INTTYPES_H condition from inclusion of
5092 inttypes.h, as a gnulib replacement is used if it not available in
5093 system headers.
5094
15cbd324
EZ
50952011-04-21 Eli Zaretskii <eliz@gnu.org>
5096
5097 Lift the MOST_POSITIVE_FIXNUM/4 limitation on visited files.
5098 * fileio.c (Finsert_file_contents): Don't limit file size to 1/4
5099 of MOST_POSITIVE_FIXNUM. (Bug#8528)
5100
5101 * coding.c (coding_alloc_by_realloc): Error out if destination
5102 will grow beyond MOST_POSITIVE_FIXNUM.
5103 (decode_coding_emacs_mule): Abort if there isn't enough place in
5104 charbuf for the composition carryover bytes. Reserve an extra
5105 space for up to 2 characters produced in a loop.
5106 (decode_coding_iso_2022): Abort if there isn't enough place in
5107 charbuf for the composition carryover bytes.
5108
51092011-04-21 Eli Zaretskii <eliz@gnu.org>
afda1437 5110
ae940cca
EZ
5111 * doprnt.c (doprnt) [!HAVE_LONG_LONG_INT]: Error out instead of
5112 aborting when %lld or %lll format is passed.
5113 [!HAVE_UNSIGNED_LONG_LONG_INT]: Error out instead of aborting when
5114 %llo or %llx format is passed. (Bug#8545)
5115
03ab8921
EZ
5116 * window.c (window_scroll_line_based): Use a marker instead of
5117 simple variables to record original value of point. (Bug#7952)
5118
afda1437
EZ
5119 * doprnt.c (doprnt): Fix the case where a multibyte sequence
5120 produced by %s or %c overflows available buffer space. (Bug#8545)
5121
f76dee0c
PE
51222011-04-28 Paul Eggert <eggert@cs.ucla.edu>
5123
5124 * doprnt.c (doprnt): Omit useless test; int overflow check (Bug#8545).
283cdbef 5125 (SIZE_MAX): Move defn after all includes, as they might #define it.
f76dee0c 5126
fdc5744d
JB
51272011-04-28 Juanma Barranquero <lekktu@gmail.com>
5128
5129 * w32.c (init_environment): Warn about defaulting HOME to C:\.
5130
638f053a
JB
51312011-04-28 Juanma Barranquero <lekktu@gmail.com>
5132
5133 * keyboard.c (Qdelayed_warnings_hook): Define.
5134 (command_loop_1): Run `delayed-warnings-hook'
5135 if Vdelayed_warnings_list is non-nil.
5136 (syms_of_keyboard) <delayed-warnings-hook>: DEFSYM it.
5137 (syms_of_keyboard) <delayed-warnings-list>: DEFVAR_LISP it.
5138
d178f871
EZ
51392011-04-28 Eli Zaretskii <eliz@gnu.org>
5140
5141 * doprnt.c (doprnt): Don't return value smaller than the buffer
5142 size if the message was truncated. (Bug#8545).
5143
b124fd93
JB
51442011-04-28 Juanma Barranquero <lekktu@gmail.com>
5145
5146 * w32fns.c (Fx_change_window_property, Fx_delete_window_property)
5147 (Fx_window_property): #if-0 the whole functions, not just the bodies.
5148
e810457d
PE
51492011-04-27 Paul Eggert <eggert@cs.ucla.edu>
5150
5151 * doprnt.c (doprnt): Support "ll" length modifier, for long long.
5152
ea51cceb
JB
51532011-04-27 Juanma Barranquero <lekktu@gmail.com>
5154
5155 * makefile.w32-in: Update dependencies.
5156
94dcfacf
EZ
51572011-04-27 Eli Zaretskii <eliz@gnu.org>
5158
5159 Improve `doprnt' and its usage. (Bug#8545)
5160 * doprnt.c (doprnt): Make sure `format' is never accessed beyond
5161 `format_end'. Remove support for %l as a conversion specifier.
5162 Don't use xrealloc. Improve diagnostics when the %l size modifier
5163 is used. Update the commentary.
5164
5165 * eval.c (verror): Simplify calculation of size_t.
5166
5167 * coding.c (Ffind_operation_coding_system): Fix diagnostic error
5168 messages.
5169
f61f41d7
PE
51702011-04-27 Yoshiaki Kasahara <kasahara@nc.kyushu-u.ac.jp> (tiny change)
5171
5172 * buffer.c (init_buffer) [USE_MMAP_FOR_BUFFERS]: Adjust to aliasing
5173 change.
5174
96fb4434
PE
51752011-04-27 Paul Eggert <eggert@cs.ucla.edu>
5176
5177 * nsmenu.m: Replace all uses of XVECTOR with ASIZE and AREF.
5178 This makes this file independent of the recent pseudovector change.
5179
671875da 51802011-04-26 Paul Eggert <eggert@cs.ucla.edu>
eab3844f 5181
69e9b5a3
PE
5182 * keyboard.c (handle_user_signal): Fix pointer signedness problem.
5183
b5f869a7 5184 * gnutls.c (emacs_gnutls_handle_error): Remove unused local.
7754e151 5185 (Fgnutls_boot): gnutls_certificate_verify_peers2 wants unsigned *.
8d4c3955 5186 Remove unused local.
c8926152 5187 (emacs_gnutls_write): Don't use uninitialized rtnval if nbyte <= 0.
080e5a8d 5188
841a1577 5189 * lisp.h: Fix a problem with aliasing and vector headers. (Bug#8546)
04f2d78b
CB
5190 GCC 4.6.0 optimizes based on type-based alias analysis.
5191 For example, if b is of type struct buffer * and v of type struct
eab3844f
PE
5192 Lisp_Vector *, then gcc -O2 was incorrectly assuming that &b->size
5193 != &v->size, and therefore "v->size = 1; b->size = 2; return
5194 v->size;" must therefore return 1. This assumption is incorrect
5195 for Emacs, since it type-puns struct Lisp_Vector * with many other
5196 types. To fix this problem, this patch adds a new type struct
f904488f 5197 vectorlike_header that documents the constraints on layout of vectors
eab3844f
PE
5198 and pseudovectors, and helps optimizing compilers not get fooled
5199 by Emacs's type punning. It also adds the macros XSETTYPED_PVECTYPE
5200 XSETTYPED_PSEUDOVECTOR, TYPED_PSEUDOVECTORP, for similar reasons.
f904488f
PE
5201 * lisp.h (XSETTYPED_PVECTYPE): New macro, specifying the name of
5202 the size member.
eab3844f
PE
5203 (XSETPVECTYPE): Rewrite in terms of new macro.
5204 (XSETPVECTYPESIZE): New macro, specifying both type and size.
5205 This is a bit clearer, and further avoids the possibility of
5206 undesirable aliasing.
5207 (XSETTYPED_PSEUDOVECTOR): New macro, specifying the size.
f904488f 5208 (XSETPSEUDOVECTOR): Rewrite in terms of XSETTYPED_PSEUDOVECTOR.
eab3844f
PE
5209 (XSETSUBR): Rewrite in terms of XSETTYPED_PSEUDOVECTOR and XSIZE,
5210 since Lisp_Subr is a special case (no "next" field).
04f2d78b
CB
5211 (ASIZE): Now uses header.size rather than size.
5212 All previous uses of XVECTOR (foo)->size replaced to use this macro,
f904488f
PE
5213 to avoid the hassle of writing XVECTOR (foo)->header.size.
5214 (struct vectorlike_header): New type.
eab3844f
PE
5215 (TYPED_PSEUDOVECTORP): New macro, also specifying the C type of the
5216 object, to help avoid aliasing.
5217 (PSEUDOVECTORP): Rewrite in terms of TYPED_PSEUDOVECTORP.
5218 (SUBRP): Likewise, since Lisp_Subr is a special case.
5219 * lisp.h (struct Lisp_Vector, struct Lisp_Char_Table):
5220 (struct Lisp_Sub_Char_Table, struct Lisp_Bool_Vector):
5221 (struct Lisp_Hash_Table): Combine first two members into a single
f904488f 5222 struct vectorlike_header member. All uses of "size" and "next" members
eab3844f
PE
5223 changed to be "header.size" and "header.next".
5224 * buffer.h (struct buffer): Likewise.
5225 * font.h (struct font_spec, struct font_entity, struct font): Likewise.
5226 * frame.h (struct frame): Likewise.
5227 * process.h (struct Lisp_Process): Likewise.
5228 * termhooks.h (struct terminal): Likewise.
5229 * window.c (struct save_window_data, struct saved_window): Likewise.
5230 * window.h (struct window): Likewise.
5231 * alloc.c (allocate_buffer, Fmake_bool_vector, allocate_pseudovector):
5232 Use XSETPVECTYPESIZE, not XSETPVECTYPE, to avoid aliasing problems.
5233 * buffer.c (init_buffer_once): Likewise.
5234 * lread.c (defsubr): Use XSETTYPED_PVECTYPE, since Lisp_Subr is a
5235 special case.
5236 * process.c (Fformat_network_address): Use local var for size,
5237 for brevity.
5238
0df1eac5
PE
5239 * bytecode.c (exec_byte_code): Don't use XVECTOR before CHECK_VECTOR.
5240
847ab9d1 5241 Make the Lisp reader and string-to-float more consistent (Bug#8525)
452f4150
PE
5242 * data.c (atof): Remove decl; no longer used or needed.
5243 (digit_to_number): Move to lread.c.
5244 (Fstring_to_number): Use new string_to_number function, to be
5245 consistent with how the Lisp reader treats infinities and NaNs.
5246 Do not assume that floating-point numbers represent EMACS_INT
5247 without losing information; this is not true on most 64-bit hosts.
5248 Avoid double-rounding errors, by insisting on integers when
5249 parsing non-base-10 numbers, as the documentation specifies.
5250 * lisp.h (string_to_number): New decl, replacing ...
5251 (isfloat_string): Remove.
bc0a5c13 5252 * lread.c: Include <inttypes.h>, for uintmax_t and strtoumax.
d78050d6 5253 (read1): Do not accept +. and -. as integers; this
452f4150
PE
5254 appears to have been a coding error. Similarly, do not accept
5255 strings like +-1e0 as floating point numbers. Do not report
5256 overflow for integer overflows unless the base is not 10 which
5257 means we have no simple and reliable way to continue.
5258 Break out the floating-point parsing into a new
5259 function string_to_number, so that Fstring_to_number parses
5260 floating point numbers consistently with the Lisp reader.
04f2d78b 5261 (digit_to_number): Move here from data.c. Make it static inline.
452f4150
PE
5262 (E_CHAR, EXP_INT): Remove, replacing with ...
5263 (E_EXP): New macro, to solve the "1.0e+" problem mentioned below.
5264 (string_to_number): New function, replacing isfloat_string.
5265 This function checks for valid syntax and produces the resulting
5266 Lisp float number too. Rework it so that string-to-number
bc0a5c13 5267 no longer mishandles examples like "1.0e+". Use strtoumax,
d78050d6
PE
5268 so that overflow for non-base-10 numbers is reported only when
5269 there's no portable and simple way to convert to floating point.
452f4150 5270
67769ffc
PE
5271 * textprop.c (set_text_properties_1): Rewrite for clarity,
5272 and to avoid GCC warning about integer overflow.
5273
c20db43f
PE
5274 * intervals.h (struct interval): Use EMACS_INT for members
5275 where EMACS_UINT might cause problems. See
5276 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00514.html>.
5277 (CHECK_TOTAL_LENGTH): Remove cast to EMACS_INT; no longer needed.
5278 * intervals.c (interval_deletion_adjustment): Now returns EMACS_INT.
5279 All uses changed.
37aa2f85
PE
5280 (offset_intervals): Tell GCC not to worry about length overflow
5281 when negating a negative length.
c20db43f 5282
2538aa2f
PE
5283 * alloc.c (overrun_check_malloc, overrun_check_realloc): Now static.
5284 (overrun_check_free): Likewise.
5285
f2d3008d
PE
5286 * alloc.c (SDATA_SIZE) [!GC_CHECK_STRING_BYTES]: Avoid runtime check
5287 in the common case where SDATA_DATA_OFFSET is a multiple of Emacs
5288 word size.
5289
ec8df744
PE
5290 * gnutls.c: Fix problems found by GCC 4.6.0 on Ubuntu 10.10.
5291 (gnutls_make_error): Rename local to avoid shadowing.
5292 (gnutls_emacs_global_deinit): ifdef out; not used.
5293 (Fgnutls_boot): Use const for pointer to readonly storage.
5294 Comment out unused local. Fix pointer signedness problems.
5295
640ee02d
PE
5296 * lread.c (openp): Don't stuff size_t into an 'int'.
5297 Use <= on length, not < on length + 1, to avoid GCC 4.6.0 warning
5298 about possible signed overflow.
5299
6048fb2a
PE
5300 * gtkutil.c: Fix problems found by GCC 4.6.0 on Ubuntu 10.10.
5301 (GDK_KEY_g): Don't define if already defined.
5302 (xg_prepare_tooltip): Avoid pointer signedness problem.
5303 (xg_set_toolkit_scroll_bar_thumb): Redo to avoid two casts.
5304
fa3c87e1
PE
5305 * process.c (Fnetwork_interface_info): Avoid left-shift undefined
5306 behavior with 1 << 31. GCC 4.6.0 warns about this on 32-bit hosts.
5307
2172544b
PE
5308 * xfns.c (Fx_window_property): Simplify a bit,
5309 to make a bit faster and to avoid GCC 4.6.0 warning.
5310 * xselect.c (x_get_window_property, x_handle_dnd_message): Likewise.
5311
9b821a21
PE
5312 * fns.c (internal_equal): Don't assume size_t fits in int.
5313
3c616cfa
PE
5314 * alloc.c (compact_small_strings): Tighten assertion a little.
5315
c2982e87
PE
5316 Replace pEd with more-general pI, and fix some printf arg casts.
5317 * lisp.h (pI): New macro, generalizing old pEd macro to other
5318 conversion specifiers. For example, use "...%"pI"d..." rather
5319 than "...%"pEd"...".
5320 (pEd): Remove. All uses replaced with similar uses of pI.
5321 * src/m/amdx86-64.h, src/m/ia64.h, src/m/ibms390x.h: Likewise.
5322 * alloc.c (check_pure_size): Don't overflow by converting size to int.
5323 * bidi.c (bidi_dump_cached_states): Use pI to avoid cast.
5324 * data.c (Fnumber_to_string): Use pI instead of if-then-else-abort.
5325 * dbusbind.c (xd_append_arg): Use pI to avoid cast.
5326 (Fdbus_method_return_internal, Fdbus_method_error_internal): Likewise.
5327 * font.c (font_unparse_xlfd): Avoid potential buffer overrun on
5328 64-bit hosts.
5329 (font_unparse_xlfd, font_unparse_fcname): Use pI to avoid casts.
5330 * keyboard.c (record_char, modify_event_symbol): Use pI to avoid casts.
5331 * print.c (safe_debug_print, print_object): Likewise.
5332 (print_object): Don't overflow by converting EMACS_INT or EMACS_UINT
5333 to int.
6f04d126
PE
5334 Use pI instead of if-then-else-abort. Use %p to avoid casts,
5335 avoiding the 0 flag, which is not portable.
c2982e87
PE
5336 * process.c (Fmake_network_process): Use pI to avoid cast.
5337 * region-cache.c (pp_cache): Likewise.
5338 * xdisp.c (decode_mode_spec): Likewise.
5339 * xrdb.c (x_load_resources) [USE_MOTIF]: Use pI to avoid undefined
5340 behavior on 64-bit hosts with printf arg.
6f04d126 5341 * xselect.c (x_queue_event): Use %p to avoid casts, avoiding 0 flag.
c2982e87
PE
5342 (x_stop_queuing_selection_requests): Likewise.
5343 (x_get_window_property): Don't truncate byte count to an 'int'
5344 when tracing.
0b432f21 5345
5e073ec7
PE
5346 * frame.c (frame_name_fnn_p): Get rid of strtol, which isn't right
5347 here, since it parses constructs like leading '-' and spaces,
5348 which are not wanted; and it overflows with large numbers.
5349 Instead, simply match F[0-9]+, which is what is wanted anyway.
5350
36372bf9
PE
5351 * alloc.c: Remove unportable assumptions about struct layout.
5352 (SDATA_SELECTOR, SDATA_DATA_OFFSET): New macros.
5353 (SDATA_OF_STRING, SDATA_SIZE, allocate_string_data):
5354 (allocate_vectorlike, make_pure_vector): Use the new macros,
5355 plus offsetof, to remove unportable assumptions about struct layout.
5356 These assumptions hold on all porting targets that I know of, but
5357 they are not guaranteed, they're easy to remove, and removing them
5358 makes further changes easier.
5359
0b432f21
PE
5360 * alloc.c (BLOCK BYTES): Fix typo by changing "ablock" to "ablocks".
5361 This doesn't fix a bug but makes the code clearer.
bfd1c781
PE
5362 (string_overrun_cookie): Now const. Use initializers that
5363 don't formally overflow signed char, to avoid warnings.
000098c1
PE
5364 (allocate_string_data) [GC_CHECK_STRING_OVERRUN]: Fix typo that
5365 can cause Emacs to crash when string overrun checking is enabled.
c7bda33c
PE
5366 (allocate_buffer): Don't assume sizeof (struct buffer) is a
5367 multiple of sizeof (EMACS_INT); it need not be, if
5368 alignof(EMACS_INT) < sizeof (EMACS_INT).
d0f4e1f5 5369 (check_sblock, check_string_bytes, check_string_free_list): Protoize.
0b432f21 5370
895009e1
JB
53712011-04-26 Juanma Barranquero <lekktu@gmail.com>
5372
5373 * keyboard.c (QCrtl): Rename from Qrtl. All uses changed.
5374
6a7a1b0b
TZ
53752011-04-26 Teodor Zlatanov <tzz@lifelogs.com>
5376
5377 * gnutls.c (emacs_gnutls_handshake): Return an error if we're not
b5f869a7 5378 supposed to be handshaking. (Bug#8556)
6a7a1b0b
TZ
5379 Reported by Paul Eggert <eggert@cs.ucla.edu>.
5380
841a1577 53812011-04-26 Daniel Colascione <dan.colascione@gmail.com>
0438ce91
DC
5382
5383 * lisp.h (Qdebug): List symbol.
895009e1 5384 * eval.c (Qdebug): Restore global linkage.
0438ce91
DC
5385 * keyboard.c (debug-on-event): New variable.
5386 (handle_user_signal): Break into debugger when debug-on-event
5387 matches the current signal symbol.
5388
f2d3ba6f
DN
53892011-04-25 Dan Nicolaescu <dann@ics.uci.edu>
5390
5391 * alloc.c (check_sblock, check_string_bytes)
5392 (check_string_free_list): Convert to standard C.
5393
42ce4c63
TZ
53942011-04-25 Teodor Zlatanov <tzz@lifelogs.com>
5395
5396 * w32.c (emacs_gnutls_push): Fix typo.
5397
825cd63c
EZ
53982011-04-25 Eli Zaretskii <eliz@gnu.org>
5399
fb11d64d
EZ
5400 * gnutls.c (emacs_gnutls_handshake): Avoid compiler warnings about
5401 "cast to pointer from integer of different size".
5402
825cd63c
EZ
5403 Improve doprnt and its use in verror. (Bug#8545)
5404 * doprnt.c (doprnt): Document the set of format control sequences
5405 supported by the function. Use SAFE_ALLOCA instead of always
5406 using `alloca'.
5407
5408 * eval.c (verror): Don't limit the buffer size at size_max-1, that
5409 is one byte too soon. Don't use xrealloc; instead xfree and
5410 xmalloc anew.
5411
e061a11b
TZ
54122011-04-24 Teodor Zlatanov <tzz@lifelogs.com>
5413
5414 * gnutls.h: Add GNUTLS_STAGE_CALLBACKS enum to denote we're in the
5415 callbacks stage.
5416
5417 * gnutls.c: Renamed global_initialized to
5418 gnutls_global_initialized. Added internals for the
5419 :verify-hostname-error, :verify-error, and :verify-flags
5420 parameters of `gnutls-boot' and documented those parameters in the
5421 docstring. Start callback support.
9173deec
JB
5422 (emacs_gnutls_handshake): Add Woe32 support. Retry handshake
5423 unless a fatal error occurred. Call gnutls_alert_send_appropriate
5424 on error. Return error code.
e061a11b
TZ
5425 (emacs_gnutls_write): Call emacs_gnutls_handle_error.
5426 (emacs_gnutls_read): Likewise.
5427 (Fgnutls_boot): Return handshake error code.
5428 (emacs_gnutls_handle_error): New function.
5429 (wsaerror_to_errno): Likewise.
5430
5431 * w32.h (emacs_gnutls_pull): Add prototype.
5432 (emacs_gnutls_push): Likewise.
5433
5434 * w32.c (emacs_gnutls_pull): New function for GnuTLS on Woe32.
5435 (emacs_gnutls_push): Likewise.
5436
54372011-04-24 Claudio Bley <claudio.bley@gmail.com> (tiny change)
5438
5439 * process.c (wait_reading_process_output): Check if GnuTLS
5440 buffered some data internally if no FDs are set for TLS
5441 connections.
5442
5443 * makefile.w32-in (OBJ2): Add gnutls.$(O).
5444 (LIBS): Link to USER_LIBS.
5445 ($(BLD)/gnutls.$(0)): New target.
5446
fa6996bc
EZ
54472011-04-24 Eli Zaretskii <eliz@gnu.org>
5448
eb35682e
EZ
5449 * xdisp.c (handle_single_display_spec): Rename the
5450 display_replaced_before_p argument into display_replaced_p, to
5451 make it consistent with the commentary. Fix typos in the
5452 commentary.
5453
e2ad650c
EZ
5454 * textprop.c (syms_of_textprop): Remove dead code.
5455 (copy_text_properties): Delete obsolete commentary about an
5456 interface that was deleted long ago. Fix typos in the description
5457 of arguments.
5458
1b2de274
EZ
5459 * msdos.c (XMenuActivate, XMenuAddSelection): Adjust argument list
5460 to changes in oldXMenu/XMenu.h from 2011-04-16.
5461 <menu_help_message, prev_menu_help_message>: Constify.
5462 (IT_menu_make_room): menu->help_text is now `const char **';
5463 adjust.
5464
5465 * msdos.h (XMenuActivate, XMenuAddSelection): Adjust prototypes
5466 to changes in oldXMenu/XMenu.h from 2011-04-16.
5467 (struct XMenu): Declare `help_text' `const char **'.
5468
5469 * xfaces.c <Qunspecified>: Make extern again.
5470
5471 * syntax.c: Include sys/types.h before including regex.h, as
5472 required by Posix.
5473
762b15be
EZ
5474 * doc.c (get_doc_string): Improve the format passed to `error'.
5475
5476 * doprnt.c (doprnt): Improve commentary.
5477
5478 * term.c (init_tty) [MSDOS]: Fix 1st argument to maybe_fatal.
5479
5480 * Makefile.in (TAGS): Depend on $(M_FILE) and $(S_FILE), and scan
5481 them with etags.
5482
f1052e5d
EZ
5483 * makefile.w32-in (globals.h): Add a dummy recipe, to make any
5484 changes in globals.h immediately force recompilation.
762b15be
EZ
5485 (TAGS): Depend on $(CURDIR)/m/intel386.h and
5486 $(CURDIR)/s/ms-w32.h.
5487 (TAGS-gmake): Scan $(CURDIR)/m/intel386.h and $(CURDIR)/s/ms-w32.h.
f1052e5d 5488
fa6996bc
EZ
5489 * character.c (Fchar_direction): Function deleted.
5490 (syms_of_character): Don't defsubr it.
5491 <char-direction-table>: Deleted.
5492
e6c3da20
EZ
54932011-04-23 Eli Zaretskii <eliz@gnu.org>
5494
5495 Fix doprnt so it could be used again safely in `verror'. (Bug#8435)
5496 * doprnt.c: Include limits.h.
5497 (SIZE_MAX): New macro.
04f2d78b
CB
5498 (doprnt): Return a size_t value. 2nd arg is now size_t.
5499 Many local variables are now size_t instead of int or unsigned.
e6c3da20
EZ
5500 Improve overflow protection. Support `l' modifier for integer
5501 conversions. Support %l conversion. Don't assume an EMACS_INT
5502 argument for integer conversions and for %c.
5503
5504 * lisp.h (doprnt): Restore prototype.
5505
5506 * makefile.w32-in ($(BLD)/callint.$(O)): Depend on
5507 $(SRC)/character.h.
5508
5509 * Makefile.in (base_obj): Add back doprnt.o.
5510
5511 * deps.mk (doprnt.o): Add back prerequisites.
5512 (callint.o): Depend on character.h.
5513
5514 * eval.c (internal_lisp_condition_case): Include the handler
5515 representation in the error message.
5516 (verror): Call doprnt instead of vsnprintf. Fix an off-by-one bug
5517 when breaking from the loop.
5518
5519 * xdisp.c (vmessage): Call doprnt instead of vsnprintf.
5520
5521 * callint.c (Fcall_interactively): When displaying error message
5522 about invalid control letter, pass the character's codepoint, not
5523 a pointer to its multibyte form. Improve display of the character
5524 in octal and display also its hex code.
5525
5526 * character.c (char_string): Use %x to display the (unsigned)
5527 codepoint of an invalid character, to avoid displaying a bogus
5528 negative value.
5529
5530 * font.c (check_otf_features): Pass SDATA of SYMBOL_NAME to
5531 `error', not SYMBOL_NAME itself.
5532
5533 * coding.c (Fencode_sjis_char, Fencode_big5_char): Use %c for
5534 character arguments to `error'.
5535
5536 * charset.c (check_iso_charset_parameter): Fix incorrect argument
5537 to `error' in error message about FINAL_CHAR argument. Make sure
5538 FINAL_CHAR is a character, and use %c when it is passed as
5539 argument to `error'.
5540
4ffd0d6b 55412011-04-23 Eli Zaretskii <eliz@gnu.org>
97a93095
EZ
5542
5543 * s/ms-w32.h (localtime): Redirect to sys_localtime.
5544
5545 * w32.c: Include <time.h>.
5546 (sys_localtime): New function.
5547
4ffd0d6b 55482011-04-23 Chong Yidong <cyd@stupidchicken.com>
c17819f4
CY
5549
5550 * xdisp.c (init_xdisp): Initialize echo_area_window (Bug#6451).
5551
4ffd0d6b 5552 * buffer.c (syms_of_buffer): Doc fix (Bug#6902).
aac0c6e3 5553
4ffd0d6b 55542011-04-23 Samuel Thibault <sthibault@debian.org> (tiny change)
aac0c6e3 5555
4ffd0d6b
GM
5556 * sysdep.c (wait_for_termination): On GNU Hurd, kill returns -1 on
5557 zombies (Bug#8467).
aac0c6e3 5558
04c56954
EZ
55592011-04-19 Eli Zaretskii <eliz@gnu.org>
5560
5561 * syntax.h (SETUP_SYNTAX_TABLE_FOR_OBJECT): Fix setting of
5562 gl_state.e_property when gl_state.object is Qt.
5563
5564 * insdel.c (make_gap_larger): Remove limitation of buffer size
5565 to <= INT_MAX.
5566
16a43933
CY
55672011-04-18 Chong Yidong <cyd@stupidchicken.com>
5568
5569 * xdisp.c (lookup_glyphless_char_display)
5570 (produce_glyphless_glyph): Handle cons cell entry in
5571 glyphless-char-display.
5572 (Vglyphless_char_display): Document it.
5573
5574 * term.c (produce_glyphless_glyph): Handle cons cell entry in
5575 glyphless-char-display.
5576
4581706e
CY
55772011-04-17 Chong Yidong <cyd@stupidchicken.com>
5578
5579 * xdisp.c (get_next_display_element): Remove unnecessary ifdefs.
5580
5581 * termhooks.h (FRAME_WINDOW_P): Remove duplicated definitions.
5582
5583 * dispextern.h (FACE_SUITABLE_FOR_ASCII_CHAR_P): Add missing
5584 definition for no-X builds.
5585
4887c6e2 55862011-04-16 Paul Eggert <eggert@cs.ucla.edu>
764430a3 5587
fd35b6f9
PE
5588 Static checks with GCC 4.6.0 and non-default toolkits.
5589
5c1ccb01
PE
5590 * s/sol2-6.h, s/unixware.h (PTY_TTY_NAME_SPRINTF): Protoize decl.
5591
006c5daa
PE
5592 * process.c (keyboard_bit_set): Define only if SIGIO.
5593 (send_process_trap): Mark it with NO_RETURN if it doesn't return.
5594 (send_process): Repair possible setjmp clobbering.
5595
efc736d3
PE
5596 * s/usg5-4-common.h (SETUP_SLAVE_PTY): Don't pass extra arg to 'fatal'.
5597
4e2fe2e6
PE
5598 * eval.c: Include <stdio.h>, for vsnprintf on non-GNU/Linux hosts.
5599
f97334a2
PE
5600 * data.c (arith_error): Mark with NO_RETURN if it doesn't return.
5601
4e75f29d
PE
5602 * alloc.c (bytes_used_when_full, SPARE_MEMORY, BYTES_USED):
5603 Define only if needed.
5604
90efadd1
PE
5605 * sysdep.c (_FILE_OFFSET_BITS): Make this hack even uglier
5606 by pacifying GCC about it. Maybe it's time to retire it?
875975e9 5607 * xfaces.c (USG, __TIMEVAL__): Likewise.
90efadd1 5608
3c647824
PE
5609 * dispextern.h (struct redisplay_interface): Rename param
5610 to avoid shadowing.
e264f262 5611 * termhooks.h (struct terminal): Likewise.
761383f4 5612 * xterm.c (xembed_send_message): Likewise.
3c647824 5613
b58c5c4a
PE
5614 * insdel.c (make_gap_smaller): Define only if
5615 USE_MMAP_FOR_BUFFERS || REL_ALLOC || DOUG_LEA_MALLOC.
5616
cad59032
PE
5617 * keyboard.c (read_char): Make a var volatile so longjmp won't clobber
5618 it.
5619
c339dc2e
PE
5620 * emacs.c (MAX_HEAP_BSS_DIFF, my_edata): Move to where they're used,
5621 so that we aren't warned about unused symbols.
5622
91a3e27b
PE
5623 * xfns.c (Fx_file_dialog): Rename local to avoid shadowing.
5624
399c71d3 5625 * xdisp.c (x_produce_glyphs): Mark var as initialized (Bug#8512).
7a3fb125 5626
8ffc96f5
PE
5627 * xfns.c (x_real_positions): Mark locals as initialized.
5628
eef9bc79
PE
5629 * xmenu.c (xmenu_show): Don't use uninitialized vars.
5630
098db9dd
PE
5631 * xterm.c: Fix problems found by static analysis with other toolkits.
5632 (toolkit_scroll_bar_interaction): Define and use only if USE_X_TOOLKIT.
dda3aedd
PE
5633 (x_dispatch_event): Declare static if USE_GTK, and
5634 define if USE_GTK || USE_X_TOOLKIT.
098db9dd 5635 (SET_SAVED_BUTTON_EVENT): Define only if USE_X_TOOLKIT || USE_GTK.
dda3aedd 5636 * xterm.h (x_dispatch_event): Extern only if USE_X_TOOLKIT.
841a1577
JB
5637 * xterm.c, xterm.h (x_mouse_leave): Bring this function back, but only
5638 if defined HAVE_MENUS && !defined USE_X_TOOLKIT && !defined USE_GTK.
098db9dd 5639
eb18f6cc
PE
5640 * xmenu.c (menu_help_callback): Pointer type fixes.
5641 Use const pointers when pointing at readonly data. Avoid pointer
5642 signedness clashes.
5643 (FALSE): Remove unused macro.
5644 (update_frame_menubar): Remove unused decl.
5645
1fe72bf8
PE
5646 * xfns.c (Fx_hide_tip): Move locals to avoid shadowing.
5647
60d9e1db
PE
5648 * menu.c (push_submenu_start, push_submenu_end): Do not define unless
5649 USE_X_TOOLKIT || USE_GTK || HAVE_NS || defined HAVE_NTGUI.
5650 (single_menu_item): Rename local to avoid shadowing.
5651
39261c26
PE
5652 * keyboard.c (make_lispy_event): Remove unused local var.
5653
018c5e19
PE
5654 * frame.c, frame.h (x_get_resource_string): Bring this back, but
5655 only if HAVE_X_WINDOWS && !USE_X_TOOLKIT.
5656
63d2b86e
PE
5657 * bitmaps: Change bitmaps from unsigned char back to the X11
5658 compatible char. Avoid the old compiler warnings about
5659 out-of-range initializers by using, for example, '\xab' rather
5660 than 0xab.
5661
aefd87e1
PE
5662 * xgselect.c (xgselect_initialize): Check vs interface
5663 even if ! (defined (USE_GTK) || defined (HAVE_GCONF)).
5664
bf501fb9
PE
5665 * xmenu.c (xmenu_show): Rename parm to avoid shadowing.
5666
e9829fdf
PE
5667 * xterm.c (x_create_toolkit_scroll_bar): Use const * for pointers
5668 to read-only memory.
5669
1086c095
PE
5670 * fns.c (vector): Remove; this old hack is no longer needed.
5671
2baccd04 5672 * xsmfns.c (create_client_leader_window): Rename shadowing arg.
401f10cb 5673 Remove unused var.
dde42981 5674 (gdk_x11_set_sm_client_id) [!USE_GTK]: Don't define.
2baccd04 5675
72391843 5676 * xrdb.c (x_load_resources): Omit unused local.
3565b346 5677
436c16df 5678 * xfns.c (free_frame_menubar, atof): Remove duplicate decls.
8a94ea33 5679 (x_window): Rename locals to avoid shadowing.
dc5ddd85 5680 (USG): Use the kludged USG macro, to pacify gcc.
436c16df 5681
92bb796d 5682 * xterm.c (x_alloc_nearest_color_for_widget): Remove; unused.
bbbef9e1 5683 (x_term_init): Remove local to avoid shadowing.
92bb796d 5684
764430a3 5685 * xfns.c, xterm.c (_XEditResCheckMessages): Protoize decl.
4887c6e2
PE
5686
5687 * xdisp.c, dispextern.h (set_vertical_scroll_bar): Now extern if
5688 USE_TOOLKIT_SCROLL_BARS && !USE_GTK, as xterm.c needs it then.
5689
d1dfb56c
EZ
56902011-04-16 Eli Zaretskii <eliz@gnu.org>
5691
c4354cb4
EZ
5692 * gnutls.c (Fgnutls_boot): Don't pass Lisp_Object to `error'.
5693
d1dfb56c
EZ
5694 Fix regex.c, syntax.c and friends for buffers > 2GB.
5695 * syntax.h (struct gl_state_s): Declare character position members
5696 EMACS_INT.
5697
5698 * syntax.c (update_syntax_table): Declare 2nd argument EMACS_INT.
5699
04f2d78b
CB
5700 * textprop.c (verify_interval_modification, interval_of):
5701 Declare arguments EMACS_INT.
d1dfb56c
EZ
5702
5703 * intervals.c (adjust_intervals_for_insertion): Declare arguments
5704 EMACS_INT.
5705
5706 * intervals.h (CHECK_TOTAL_LENGTH): Cast to EMACS_INT, not `int'.
5707
5708 * indent.c (Fvertical_motion): Local variable it_start is now
5709 EMACS_INT.
5710
5711 * regex.c (re_match, re_match_2, re_match_2_internal)
5712 (bcmp_translate, regcomp, regexec, print_double_string)
5713 (group_in_compile_stack, re_search, re_search_2, regex_compile)
5714 (re_compile_pattern, re_exec): Declare arguments and local
5715 variables `size_t' and `ssize_t' and return values `regoff_t', as
5716 appropriate.
5717 (POP_FAILURE_REG_OR_COUNT) <pfreg>: Declare `long'.
5718 (CHECK_INFINITE_LOOP) <failure>: Declare `ssize_t'.
5719 <compile_stack_type>: `size' and `avail' are now `size_t'.
5720
5721 * regex.h <regoff_t>: Use ssize_t, not int.
5722 (re_search, re_search_2, re_match, re_match_2): Arguments that
5723 specify buffer/string position and length are now ssize_t and
5724 size_t. Return type is regoff_t.
5725
613052cd
BK
57262011-04-16 Ben Key <bkey76@gmail.com>
5727
5728 * nsfont.m: Fixed bugs in ns_get_family and
5729 ns_descriptor_to_entity that were caused by using free to
5730 deallocate memory blocks that were allocated by xmalloc (via
5731 xstrdup). This caused Emacs to crash when compiled with
5732 XMALLOC_OVERRUN_CHECK defined (when Emacs was configured with
5733 --enable-checking=xmallocoverrun). xfree is now used to
5734 deallocate these memory blocks.
5735
4170f62f 57362011-04-15 Paul Eggert <eggert@cs.ucla.edu>
3e047f51 5737
71b41406
PE
5738 * sysdep.c (emacs_read): Remove unnecessary check vs MAX_RW_COUNT.
5739
9587a89d
PE
5740 emacs_write: Accept and return EMACS_INT for sizes.
5741 See http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00514.html
5742 et seq.
5743 * gnutls.c, gnutls.h (emacs_gnutls_read, emacs_gnutls_write):
5744 Accept and return EMACS_INT.
5745 (emacs_gnutls_write): Return the number of bytes written on
5746 partial writes.
5747 * sysdep.c, lisp.h (emacs_read, emacs_write): Likewise.
273a5f82
PE
5748 (emacs_read, emacs_write): Remove check for negative size, as the
5749 Emacs source code has been audited now.
9587a89d
PE
5750 * sysdep.c (MAX_RW_COUNT): New macro, to work around kernel bugs.
5751 (emacs_read, emacs_write): Use it.
273a5f82
PE
5752 * process.c (send_process): Adjust to the new signatures of
5753 emacs_write and emacs_gnutls_write. Do not attempt to store
5754 a byte offset into an 'int'; it might overflow.
9587a89d 5755 See http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00483.html
273a5f82 5756
3e047f51
PE
5757 * sound.c: Don't assume sizes fit in 'int'.
5758 (struct sound_device.period_size, alsa_period_size):
9c3c56a7 5759 Return EMACS_INT, not int.
3e047f51 5760 (struct sound_device.write, vox_write, alsa_write):
9c3c56a7
PE
5761 Accept EMACS_INT, not int.
5762 (wav_play, au_play): Use EMACS_INT to store sizes and to
3e047f51
PE
5763 record read return values.
5764
cc39a9db
BK
57652011-04-15 Ben Key <bkey76@gmail.com>
5766
c9d0ec6d
JB
5767 * keyboard.c (Qundefined): Don't declare static since it is used
5768 in nsfns.m.
5769 * xfaces.c (Qbold, Qexpanded, Qitalic, Qcondensed): Don't declare
5770 static since they are used in nsfont.m.
cc39a9db 5771
6c60eb9f
SM
57722011-04-15 Stefan Monnier <monnier@iro.umontreal.ca>
5773
5774 * process.c (Qprocessp): Don't declare static.
5775 * lisp.h (Qprocessp): Declare again.
5776
7990b61a
JB
57772011-04-15 Juanma Barranquero <lekktu@gmail.com>
5778
5779 * font.c (Qopentype): Don't make static (used from w32uniscribe.c).
5780
5d4cb038
PE
57812011-04-14 Paul Eggert <eggert@cs.ucla.edu>
5782
8bd7b830 5783 Improve C-level modularity by making more things 'static'.
cd64ea1d 5784
e3b27b31
PE
5785 Don't publish debugger-only interfaces to other modules.
5786 * lisp.h (safe_debug_print, debug_output_compilation_hack):
5787 (verify_bytepos, count_markers): Move decls to the only modules
5788 that need them.
5789 * region-cache.h (pp_cache): Likewise.
5790 * window.h (check_all_windows): Likewise.
5791 * marker.c, print.c, region-cache.c, window.c: Decls moved here.
5792
5d4cb038
PE
5793 * sysdep.c (croak): Now static, if
5794 defined TIOCNOTTY || defined USG5 || defined CYGWIN.
5795 * syssignal.h (croak): Declare only if not static.
69003fd8
PE
5796
5797 * alloc.c (refill_memory_reserve): Now static if
5798 !defined REL_ALLOC || defined SYSTEM_MALLOC.
5799 * lisp.h (refill_memory_reserve): Declare only if not static.
93ea6e8f 5800
e87b6180
PE
5801 * xsettings.c, xsettings.h (xsettings_get_system_normal_font):
5802 Define only if USE_LUCID.
5803
ac64929e
PE
5804 * xrdb.c (x_customization_string, x_rm_string): Now static.
5805
6f37259d
PE
5806 * xmenu.c (x_menu_wait_for_event): Export only if USE_MOTIF.
5807 * xterm.h (x_menu_wait_for_event): Declare only if USE_MOTIF.
5808
1683e3ab
PE
5809 * xdisp.c (draw_row_with_mouse_face): Now static.
5810 * dispextern.h (draw_row_with_mouse_fave): Remove decl.
5811
de9c2632
PE
5812 * window.h (check_all_windows): Mark externally visible.
5813
2b96acb7
PE
5814 * window.c (window_deletion_count): Now static.
5815
5816 * undo.c: Make symbols static if they're not exported.
5817 (last_undo_buffer, last_boundary_position, pending_boundary):
5818 Now static.
5819
50436f33
PE
5820 * textprop.c (interval_insert_behind_hooks): Now static.
5821 (interval_insert_in_front_hooks): Likewise.
5822
64520e5c
PE
5823 * term.c: Make symbols static if they're not exported.
5824 (tty_turn_off_highlight, get_tty_terminal, max_frame_cols):
5825 (max_frame_lines, tty_set_terminal_modes):
5826 (tty_reset_terminal_modes, tty_turn_off_highlight):
5827 (get_tty_terminal): Now static.
5828 (term_mouse_moveto): Do not define if HAVE_WINDOW_SYSTEM.
5829 * termhooks.h (term_mouse_moveto): Do not declare if
8bd7b830 5830 HAVE_WINDOW_SYSTEM.
64520e5c
PE
5831 * dispextern.h (tty_set_terminal_modes, tty_reset_terminal_modes):
5832 (tty_turn_off_highlight, get_tty_terminal): Remove decls.
5833
1fa53021
PE
5834 * sysdep.c: Make symbols static if they're not exported.
5835 (emacs_get_tty, emacs_set_tty, old_fcntl_flags, old_fcntl_owner):
5836 Now static.
5837 (sigprocmask_set, full_mask): Remove; unused.
5838 (wait_debugging): Mark as visible.
5839 * syssignal.h (SIGFULLMASK, full_mask): Remove decls.
5840 * systty.h (emacs_get_tty, emacs_set_tty): Remove decls.
5841
d4b43b22
PE
5842 * syntax.c (syntax_temp): Define only if !__GNUC__.
5843
b7c513d0
PE
5844 * sound.c (current_sound_device, current_sound): Now static.
5845
989b29ad
PE
5846 * search.c (searchbufs, searchbuf_head): Now static.
5847
13a55a78
PE
5848 * scroll.c (scroll_cost): Remove; unused.
5849 * dispextern.h (scroll_cost): Remove decl.
5850
de68a1fc
PE
5851 * region-cache.h (pp_cache): Mark as externally visible.
5852
40ccffa6
PE
5853 * process.c: Make symbols static if they're not exported.
5854 (process_tick, update_tick, create_process, chan_process):
5855 (Vprocess_alist, proc_buffered_char, datagram_access):
5856 (fd_callback_data, send_process_frame, process_sent_to): Now static.
5857 (deactivate_process): Mark defn as static, as well as decl.
5858 * lisp.h (create_process): Remove decl.
5859 * process.h (chan_process, Vprocess_alist): Remove decls.
5860
ad64fc97
PE
5861 * print.c: Make symbols static if they're not exported.
5862 (print_depth, new_backquote_output, being_printed, print_buffer):
5863 (print_buffer_size, print_buffer_pos, print_buffer_pos_byte):
5864 (print_interval, print_number_index, initial_stderr_stream):
5865 Now static.
5866 * lisp.h (Fprinc): Remove decl.
5867 (debug_output_compilation_hack): Mark as externally visible.
5868
adddb265
PE
5869 * sysdep.c (croak): Move decl from here to syssignal.h.
5870 * syssignal.h (croak): Put it here, so the API can be checked when
5871 'croak' is called from dissociate_if_controlling_tty.
5872
1717ede2
PE
5873 * minibuf.c: Make symbols static if they're not exported.
5874 (minibuf_save_list, choose_minibuf_frame): Now static.
5875 * lisp.h (choose_minibuf_frame): Remove decl.
5876
fa5fb2bc
PE
5877 * lisp.h (verify_bytepos, count_markers): Mark as externally visible.
5878
1e3890d1
PE
5879 * lread.c: Make symbols static if they're not exported.
5880 (read_objects, initial_obarray, oblookup_last_bucket_number):
5881 Now static.
5882 (make_symbol): Remove; unused.
5883 * lisp.h (initial_obarray, make_symbol): Remove decls.
5884
8a1414fa
PE
5885 * keyboard.c: Make symbols static if they're not exported.
5886 (single_kboard, recent_keys_index, total_keys, recent_keys):
5887 (this_command_key_count_reset, raw_keybuf, raw_keybuf_count):
5888 (this_single_command_key_start, echoing, last_auto_save):
5889 (read_key_sequence_cmd, dribble, recursive_edit_unwind):
5890 (command_loop, echo_now, keyboard_init_hook, help_char_p):
5891 (quit_throw_to_read_char, command_loop_2, top_level_1, poll_timer):
5892 (Vlispy_mouse_stem, double_click_count):
5893 Now static.
5894 (force_auto_save_soon): Define only if SIGDANGER.
5895 (ignore_mouse_drag_p): Now static if
5896 !defined HAVE_WINDOW_SYSTEM || defined USE_GTK || defined HAVE_NS.
5897 (print_help): Remove; unused.
5898 (stop_character, last_timer_event): Mark as externally visible.
5899 * keyboard.h (ignore_mouse_drag_p): Declare only if
5900 defined HAVE_WINDOW_SYSTEM && !defined USE_GTK && !defined HAVE_NS.
5901 (echo_now, help_char_p, quit_throw_to_read_char): Remove decls.
5902 * lisp.h (echoing): Remove decl.
5903 (force_auto_save_soon): Declare only if SIGDANGER.
5904 * xdisp.c (redisplay_window): Simplify code, to make it more
5905 obvious that ignore_mouse_drag_p is not accessed if !defined
5906 USE_GTK && !defined HAVE_NS.
5907
93ea6e8f
PE
5908 * intervals.c: Make symbols static if they're not exported.
5909 (merge_properties_sticky, merge_interval_right, delete_interval):
5910 Now static.
5911 * intervals.h (merge_interval_right, delete_interval): Remove decls.
5912
77382fcc
PE
5913 * insdel.c: Make symbols static if they're not exported.
5914 However, leave prepare_to_modify_buffer alone. It's never
5915 called from outside this function, but that appears to be a bug.
5916 (combine_after_change_list, combine_after_change_buffer):
4889fc82 5917 (adjust_after_replace, signal_before_change): Now static.
77382fcc
PE
5918 (adjust_after_replace_noundo): Remove; unused.
5919 * lisp.h (adjust_after_replace, adjust_after_replace_noundo):
4889fc82 5920 (signal_before_change): Remove decls.
77382fcc 5921
9306c32e
PE
5922 * indent.c (val_compute_motion, val_vmotion): Now static.
5923
cd44d2eb
PE
5924 * image.c: Make symbols static if they're not exported.
5925 * dispextern.h (x_create_bitmap_from_xpm_data): Do not declare
5926 if USE_GTK.
5927 * image.c (x_create_bitmap_from_xpm_data): Do not define if USE_GTK.
5928 (xpm_color_cache, ct_table, ct_colors_allocated): Now static.
5929
ad9a7a06
PE
5930 * fringe.c (standard_bitmaps): Now static.
5931 (max_used_fringe_bitmap): Now static, unless HAVE_NS.
5932
81626931
PE
5933 * frame.c: Make symbols static if they're not exported.
5934 (x_report_frame_params, make_terminal_frame): Now static.
5935 (get_frame_param): Now static, unless HAVE_NS.
5936 (x_fullscreen_adjust): Define if WINDOWSNT, not if HAVE_WINDOW_SYSTEM.
5937 (x_get_resource_string): Remove; not used.
5938 * frame.h (make_terminal_frame, x_report_frame_params):
5939 (x_get_resource_string); Remove decls.
5940 (x_fullscreen_adjust): Declare only if WINDOWSNT.
5941 * lisp.h (get_frame_param): Declare only if HAVE_NS.
5942
239f9db9
PE
5943 * font.c, fontset.c: Make symbols static if they're not exported.
5944 * dispextern.h (FACE_SUITABLE_FOR_ASCII_CHAR_P): New macro.
5945 (FACE_SUITABLE_FOR_CHAR_P): Use it.
5946 * font.c (font_close_object): Now static.
5947 * font.h (font_close_object): Remove.
5948 * fontset.c (FONTSET_OBJLIST): Remove.
5949 (free_realized_fontset) #if-0 the body, which does nothing.
5950 (face_suitable_for_char_p): #if-0, as it's never called.
5951 * fontset.h (face_suitable_for_char_p): Remove decl.
04f2d78b
CB
5952 * xfaces.c (face_at_string_position):
5953 Use FACE_SUITABLE_FOR_ASCII_CHAR_P, not FACE_SUITABLE_FOR_CHAR_P,
239f9db9
PE
5954 since 0 is always ASCII.
5955
dfcf3579
PE
5956 * fns.c (weak_hash_tables): Now static.
5957
5045092b
PE
5958 * fileio.c: Make symbols static if they're not exported.
5959 (auto_saving, auto_save_mode_bits, auto_save_error_occurred):
5960 (Vwrite_region_annotation_buffers): Now static.
5961
57a96f5c
PE
5962 * eval.c: Make symbols static if they're not exported.
5963 (backtrace_list, lisp_eval_depth, when_entered_debugger): Now static.
5964 * lisp.h (backtrace_list): Remove decl.
5965
35f08c38
PE
5966 * emacs.c: Make symbols static if they're not exported.
5967 (malloc_state_ptr, malloc_using_checking, syms_of_emacs):
5968 (fatal_error_code, fatal_error_signal_hook, standard_args):
5969 Now static.
5970 (fatal_error_signal): Now static, unless FLOAT_CATCH_SIGKILL.
5971 (DEFINE_DUMMY_FUNCTION): Mark function as externally visible.
5972 (__CTOR_LIST__, __DTOR_LIST__): Now externally visible.
5973 * lisp.h (fatal_error_signal_hook): Remove decl.
5974 (fatal_error_signal): Declare only if FLOAT_CATCH_SIGKILL.
5975
f44bd759
PE
5976 * editfns.c: Move a (normally-unused) function to its only use.
5977 * editfns.c, lisp.h (get_operating_system_release): Remove.
5978 * process.c (init_process) [DARWIN_OS]: Do it inline, as it is not
5979 worth the hassle of breaking this out.
5980
b532497d
PE
5981 * xterm.c: Make symbols static if they're not exported.
5982 (x_raise_frame, x_lower_frame, x_wm_set_window_state):
5983 (x_wm_set_icon_pixmap, x_initialize, XTread_socket_fake_io_error):
5984 (x_destroy_window, x_delete_display):
5985 Now static.
5986 (x_dispatch_event): Now static if ! (USE_MOTIF || USE_X_TOOLKIT).
5987 (x_mouse_leave): Remove; unused.
5988 * xterm.h (x_display_info_for_name, x_raise_frame, x_lower_frame):
5989 (x_destroy_window, x_wm_set_window_state, x_wm_set_icon_pixmap):
5990 (x_delete_display, x_initialize, x_set_border_pixel, x_screen_planes):
5991 Remove decls.
5992 (x_mouse_leave): Declare only if WINDOWSNT.
5993 (x_dispatch_event): Declare only if USE_MOTIF or USE_X_TOOLKIT.
5994 (xic_create_fontsetname): Declare only if HAVE_X_WINDOWS &&
5995 USE_X_TOOLKIT.
5996
1675728f
PE
5997 * ftxfont.c: Make symbols static if they're not exported.
5998 (ftxfont_driver): Export only if !defined HAVE_XFT && def8ined
5999 HAVE_FREETYPE.
6000 * font.h (ftxfont_driver): Likewise.
6001
e4cebfca
PE
6002 * xfns.c: Make symbols static if they're not exported.
6003 (x_last_font_name, x_display_info_for_name):
6004 (x_set_foreground_color, x_set_background_color, x_set_mouse_color):
6005 (x_set_cursor_color, x_set_border_pixel, x_set_border_color):
6006 (x_set_cursor_type, x_set_icon_type, x_set_icon_name):
6007 (x_set_scroll_bar_foreground, x_set_scroll_bar_background):
6008 (x_explicitly_set_name, x_set_title, xic_defaut_fontset, tip_timer):
6009 (last_show_tip_args): Now static.
6010 (xic_defaut_fontset, xic_create_fontsetname): Define only if
6011 defined HAVE_X_WINDOWS && defined USE_X_TOOLKIT
6012 (x_screen_planes): Remove; unused.
6013 * dispextern.h (x_screen_planes): Remove decl.
6014
5bf46f05
PE
6015 * dispnew.c: Make symbols static if they're not exported.
6016 * dispextern.h (redraw_garbaged_frames, scrolling):
6017 (increment_row_positions): Remove.
6018 * dispnew.c (new_glyph_matrix, increment_row_positions, scrolling):
6019 (delayed_size_change, glyph_matrix_count, glyph_pool_count):
6020 Now static.
6021 (redraw_garbaged_frames): Remove; unused.
6022
435f4c28
PE
6023 * xfaces.c: Make symbols static if they're not exported.
6024 * dispextern.h (ascii_face_of_lisp_face, free_realized_face):
6025 Remove decls.
6026 * xterm.h (defined_color): Remove decls.
6027 (x_free_dpy_colors): Declare only if USE_X_TOOLKIT.
6028 * xfaces.c (tty_suppress_bold_inverse_default_colors_p):
6029 (menu_face_changed_default, defined_color, free_realized_face):
6030 (x_free_dpy_colors): Define only if USE_X_TOOLKIT.
6031 (ascii_face_of_lisp_face): Remove; unused.
6032
8524aef3
PE
6033 * xdisp.c: Make symbols static if they're not exported.
6034 * dispextern.h (scratch_glyph_row, window_box_edges):
6035 (glyph_to_pixel_coords, set_cursor_from_row):
6036 (get_next_display_element, set_iterator_to_next):
6037 (highlight_trailing_whitespace, frame_to_window_pixel_xy):
6038 (show_mouse_face): Remove decls
6039 * frame.h (message_buf_print): Likewise.
6040 * lisp.h (pop_message, set_message, check_point_in_composition):
6041 Likewise.
6042 * xterm.h (set_vertical_scroll_bar): Likewise.
6043 * xdisp.c (list_of_error, Vmessage_stack, line_number_displayed):
6044 (message_buf_print, scratch_glyph_row, displayed_buffer):
6045 (set_iterator_to_next, pop_message, set_message, set_cursor_from_row):
6046 (get_next_display_element, show_mouse_face, window_box_edges):
6047 (frame_to_window_pixel_xy, check_point_in_composition):
6048 (set_vertical_scroll_bar, highlight_trailing_whitespace): Now static.
6049 (glyph_to_pixel_coords): Remove; unused.
6050
16390cd2
PE
6051 * dired.c (file_name_completion): Now static.
6052
6053 * dbusbind.c (xd_in_read_queued_messages): Now static.
6054
a25f4dfa
PE
6055 * lisp.h (circular_list_error, FOREACH): Remove; unused.
6056 * data.c (circular_list_error): Remove.
6057
14a9c8df
PE
6058 * commands.h (last_point_position, last_point_position_buffer):
6059 (last_point_position_window): Remove decls.
6060 * keyboard.c: Make these variables static.
6061
04f2d78b
CB
6062 * coding.h (coding, code_convert_region, encode_coding_gap):
6063 Remove decls.
74ab6df5
PE
6064 * coding.c (Vsjis_coding_system, Vbig5_coding_system):
6065 (iso_code_class, detect_coding, code_convert_region): Now static.
6066 (encode_coding_gap): Remove; unused.
6067
38dfbee1
PE
6068 * chartab.c (chartab_chars, chartab_bits): Now static.
6069
a2cb4e63
PE
6070 * charset.h (charset_iso_8859_1): Remove decl.
6071 * charset.c (charset_iso_8859_1, charset_emacs, map_charset_for_dump):
6072 Now static.
6073
127198fd
PE
6074 * ccl.h (check_ccl_update, Vccl_program_table): Remove decls.
6075 * ccl.c (Vccl_program_table): Now static.
6076 (check_ccl_update): Remove; unused.
6077
d85b608f
PE
6078 * category.c (SET_CATEGORY_SET, set_category_set): Move here.
6079 * category.h: ... from here.
6080 * category.c (check_category_table, set_category_set): Now static.
6081
31cd66f3
PE
6082 * casetab.c (Vascii_upcase_table, Vascii_eqv_table): Now static.
6083 * lisp.h: Remove these decls.
6084
c358e587
PE
6085 * buffer.c (buffer_count): Remove unused var.
6086
e78aecca
PE
6087 * bidi.c (bidi_dump_cached_states): Mark as externally visible,
6088 so that it's not optimized away.
6089 (bidi_ignore_explicit_marks_for_paragraph_level): Likewise.
6090 * dispextern.h (bidi_dump_cached_states): Remove, since it's
6091 exported only to the debugger.
6092
e192d7d3 6093 * atimer.c (alarm_signal_handler, run_all_atimers): Now static.
04f2d78b 6094 * atimer.h (run_all_atimers): Remove; not exported.
e192d7d3 6095
92470028
PE
6096 font.c: Make copy_font_spec and merge_font_spec ordinary C functions.
6097 * font.c (copy_font_spec): Rename from Fcopy_font_spec, since it
6098 was inaccessible from Lisp.
6099 (merge_font_spec): Likewise, renaming from Fmerge_font_spec.
6100 * font.c, font.h, fontset.c, xfaces.c, xfont.c: Change all uses.
6101
244ed907
PE
6102 alloc.c: Import and export fewer symbols, and remove unused items.
6103 * lisp.h (suppress_checking, die): Declare only if ENABLE_CHECKING
6104 is defined.
6105 (suppress_checking): Add EXTERNALLY_VISIBLE attribute, so that
6106 it's not optimized away by whole-program optimization.
6107 (message_enable_multibyte, free_misc): Remove.
6108 (catchlist, handlerlist, mark_backtrace):
6109 Declare only if BYTE_MARK_STACK.
6110 (mark_byte_stack): Likewise, fixing a ifdef-vs-if typo.
6111 * alloc.c (pure): Export only if VIRT_ADDR_VARIES is defined.
6112 (message_enable_multibyte): Remove decl.
6113 (free_misc, interval_free_list, float_block, float_block_index):
6114 (n_float_blocks, float_free_list, cons_block, cons_block_index):
6115 (cons_free_list, last_marked_index):
6116 Now static.
6117 (suppress_checking, die): Define only if ENABLE_CHECKING is defined.
6118 * eval.c (catchlist, handlerlist): Export only if BYTE_MARK_STACK.
6119 (mark_backtrace): Define only if BYTE_MARK_STACK.
6120 * xdisp.c (message_enable_multibyte): Now static.
6121
61c2b50e 6122 Declare Lisp_Object Q* variables to be 'static' if not exported.
955cbe7b
PE
6123 This makes it easier for human readers (and static analyzers)
6124 to see whether these variables are used from other modules.
6125 * alloc.c, buffer.c, bytecode.c, callint.c, casetab.c, category.c:
6126 * ccl.c, character.c, charset.c, cmds.c, coding.c, composite.c:
6127 * data.c, dbusbind.c, dired.c, editfns.c, eval.c, fileio.c, fns.c:
6128 * font.c, frame.c, fringe.c, ftfont.c, image.c, keyboard.c, keymap.c:
6129 * lread.c, macros.c, minibuf.c, print.c, process.c, search.c:
6130 * sound.c, syntax.c, textprop.c, window.c, xdisp.c, xfaces.c, xfns.c:
6131 * xmenu.c, xselect.c:
6132 Declare Q* vars static if they are not used in other modules.
6133 * ccl.h, character.h, charset.h, coding.h, composite.h, font.h:
6134 * frame.h, intervals.h, keyboard.h, lisp.h, process.h, syntax.h:
6135 Remove decls of unexported vars.
6136 * keyboard.h (EVENT_HEAD_UNMODIFIED): Remove now-unused macro.
6137
95c82688
PE
6138 * lisp.h (DEFINE_FUNC): Make sname 'static'.
6139
16a97296
PE
6140 Make Emacs functions such as Fatom 'static' by default.
6141 This makes it easier for human readers (and static analyzers)
6142 to see whether these functions can be called from other modules.
6143 DEFUN now defines a static function. To make the function external
6144 so that it can be used in other C modules, use the new macro DEFUE.
8bd7b830
PE
6145 * lisp.h (Funibyte_char_to_multibyte, Fsyntax_table_p):
6146 (Finit_image_library):
16a97296
PE
6147 (Feval_region, Fbacktrace, Ffetch_bytecode, Fswitch_to_buffer):
6148 (Ffile_executable_p, Fmake_symbolic_link, Fcommand_execute):
6149 (Fget_process, Fdocumentation_property, Fbyte_code, Ffile_attributes):
6150 Remove decls, since these functions are now static.
6151 (Funintern, Fget_internal_run_time): New decls, since these functions
6152 were already external.
95c82688 6153
16a97296
PE
6154 * alloc.c, buffer.c, callint.c, callproc.c, casefiddle.c, casetab.c:
6155 * ccl.c, character.c, chartab.c, cmds.c, coding.c, data.c, dispnew.c:
6156 * doc.c, editfns.c, emacs.c, eval.c, fileio.c, filelock.c, floatfns.c:
6157 * fns.c, font.c, fontset.c, frame.c, image.c, indent.c:
6158 * keyboard.c, keymap.c, lread.c:
6159 * macros.c, marker.c, menu.c, minibuf.c, print.c, process.c, search.c:
6160 * syntax.c, term.c, terminal.c, textprop.c, undo.c:
6161 * window.c, xdisp.c, xfaces.c, xfns.c, xmenu.c, xsettings.c:
6162 Mark functions with DEFUE instead of DEFUN,
6163 if they are used in other modules.
6164 * buffer.c (Fset_buffer_major_mode, Fdelete_overlay): New forward
6165 decls for now-static functions.
6166 * buffer.h (Fdelete_overlay): Remove decl.
6167 * callproc.c (Fgetenv_internal): Mark as internal.
6168 * composite.c (Fremove_list_of_text_properties): Remove decl.
6169 (Fcomposition_get_gstring): New forward static decl.
6170 * composite.h (Fcomposite_get_gstring): Remove decl.
6171 * dired.c (Ffile_attributes): New forward static decl.
6172 * doc.c (Fdocumntation_property): New forward static decl.
6173 * eval.c (Ffetch_bytecode): New forward static decl.
6174 (Funintern): Remove extern decl; now in .h file where it belongs.
6175 * fileio.c (Fmake_symbolic_link): New forward static decl.
6176 * image.c (Finit_image_library): New forward static decl.
6177 * insdel.c (Fcombine_after_change_execute): Make forward decl static.
6178 * intervals.h (Fprevious_property_change):
6179 (Fremove_list_of_text_properties): Remove decls.
6180 * keyboard.c (Fthis_command_keys): Remove decl.
6181 (Fcommand_execute): New forward static decl.
6182 * keymap.c (Flookup_key): New forward static decl.
6183 (Fcopy_keymap): Now static.
6184 * keymap.h (Flookup_key): Remove decl.
6185 * process.c (Fget_process): New forward static decl.
6186 (Fprocess_datagram_address): Mark as internal.
6187 * syntax.c (Fsyntax_table_p): New forward static decl.
6188 (skip_chars): Remove duplicate decl.
6189 * textprop.c (Fprevious_property_change): New forward static decl.
6190 * window.c (Fset_window_fringes, Fset_window_scroll_bars):
6191 Now internal.
6192 (Fset_window_margins, Fset_window_vscroll): New forward static decls.
6193 * window.h (Fset_window_vscroll, Fset_window_margins): Remove decls.
6194
785bbd42
PE
6195 * editfns.c (Fformat): Remove unreachable code.
6196
8b913b57
AS
61972011-04-14 Andreas Schwab <schwab@linux-m68k.org>
6198
6199 * fileio.c (Finsert_file_contents): Fix typo in 2005-05-13
6200 change. (Bug#8496)
6201
a6744a35
EZ
62022011-04-13 Eli Zaretskii <eliz@gnu.org>
6203
6204 * xdisp.c (handle_invisible_prop): Don't call bidi_paragraph_init
6205 when at ZV. (Bug#8487)
6206
e7974947
AS
62072011-04-12 Andreas Schwab <schwab@linux-m68k.org>
6208
baad03f0
AS
6209 * charset.c (Fclear_charset_maps): Use xfree instead of free.
6210 (Bug#8437)
6211 * keyboard.c (parse_tool_bar_item): Likewise.
6212 * sound.c (sound_cleanup, alsa_close): Likewise.
6213 * termcap.c (tgetent): Likewise.
6214 * xfns.c (x_default_font_parameter): Likewise.
6215 * xsettings.c (read_and_apply_settings): Likewise.
6216
e7974947
AS
6217 * alloc.c (overrun_check_malloc, overrun_check_realloc)
6218 (overrun_check_free): Protoize.
6219
28272684
PE
62202011-04-12 Paul Eggert <eggert@cs.ucla.edu>
6221
6222 * sysdep.c (emacs_read, emacs_write): Check for negative sizes
6223 since callers should never pass a negative size.
6224 Change the signature to match that of plain 'read' and 'write'; see
6225 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00397.html>.
6226 * lisp.h: Update prototypes of emacs_write and emacs_read.
6227
11997c76
EZ
62282011-04-11 Eli Zaretskii <eliz@gnu.org>
6229
6230 * xdisp.c (redisplay_window): Don't try to determine the character
6231 position of the scroll margin if the window start point w->startp
e896f03c 6232 is outside the buffer's accessible region. (Bug#8468)
11997c76 6233
8a2cbd72
EZ
62342011-04-10 Eli Zaretskii <eliz@gnu.org>
6235
6236 Fix write-region and its subroutines for buffers > 2GB.
6237 * fileio.c (a_write, e_write): Modify declaration of arguments and
6238 local variables to support buffers larger than 2GB.
6239 (Fcopy_file): Use EMACS_INT for return value of emacs_read.
6240
6241 * sysdep.c (emacs_write, emacs_read): Use ssize_t for last
6242 argument, local variables, and return value.
6243
6244 * lisp.h: Update prototypes of emacs_write and emacs_read.
6245
6246 * sound.c (vox_write): Use ssize_t for return value of emacs_write.
6247
4073e537 62482011-04-10 Paul Eggert <eggert@cs.ucla.edu>
eb3f1cc8 6249
1ebfdcb6
PE
6250 * xdisp.c (vmessage): Use memchr, not strnlen, which some hosts lack.
6251
b2ded58d
PE
6252 Fix more problems found by GCC 4.6.0's static checks.
6253
7d66342c
PE
6254 * xdisp.c (vmessage): Use a better test for character truncation.
6255
bbf47d44
PE
6256 * charset.c (load_charset_map): <, not <=, for optimization,
6257 and to avoid potential problems with integer overflow.
9248994d 6258 * chartab.c (sub_char_table_set_range, char_table_set_range): Likewise.
f9a68bc5 6259 * casetab.c (set_identity, shuffle): Likewise.
3ab1c7ce 6260 * editfns.c (Fformat): Likewise.
1e69125e 6261 * syntax.c (skip_chars): Likewise.
3befa583 6262
e3019616
PE
6263 * xmenu.c (set_frame_menubar): Allocate smaller local vectors.
6264 This also lets GCC 4.6.0 generate slightly better loop code.
6265
becfa255
PE
6266 * callint.c (Fcall_interactively): <, not <=, for optimization.
6267 (Fcall_interactively): Count the number of arguments produced,
6268 not the number of arguments given. This is simpler and lets GCC
6269 4.6.0 generate slightly better code.
6270
dae0cd48
PE
6271 * ftfont.c: Distingish more carefully between FcChar8 and char.
6272 The previous code passed unsigned char * to a functions like
6273 strlen and xstrcasecmp that expect char *, which does not
6274 conform to the C standard.
6275 (get_adstyle_property, ftfont_pattern_entity): Use FcChar8 for
6276 arguments to FcPatternGetString, and explicitly cast FcChar8 * to
6277 char * when the C standard requires it.
6278
76032d70
PE
6279 * keyboard.c (read_char): Remove unused var.
6280
eb3f1cc8
PE
6281 * eval.c: Port to Windows vsnprintf (Bug#8435).
6282 Include <limits.h>.
6283 (SIZE_MAX): Define if the headers do not.
6284 (verror): Do not give up if vsnprintf returns a negative count.
6285 Instead, grow the buffer. This ports to Windows vsnprintf, which
6286 does not conform to C99. Problem reported by Eli Zaretskii.
6287 Also, simplify the allocation scheme, by avoiding the need for
6288 calling realloc, and removing the ALLOCATED variable.
6289
70476b54
PE
6290 * eval.c (verror): Initial buffer size is 4000 (not 200) bytes.
6291
12020a9e
PE
6292 Remove invocations of doprnt, as Emacs now uses vsnprintf.
6293 But keep the doprint source code for now, as we might revamp it
6294 and use it again (Bug#8435).
ea6c7ae6
PE
6295 * lisp.h (doprnt): Remove.
6296 * Makefile.in (base_obj): Remove doprnt.o.
6297 * deps.mk (doprnt.o): Remove.
6298
5fdb398c
PE
6299 error: Print 32- and 64-bit integers portably (Bug#8435).
6300 Without this change, on typical 64-bit hosts error ("...%d...", N)
6301 was used to print both 32- and 64-bit integers N, which relied on
6302 undefined behavior.
6303 * lisp.h, src/m/amdx86-64.h, src/m/ia64.h, src/m/ibms390x.h (pEd):
6304 New macro.
6305 * lisp.h (error, verror): Mark as printf-like functions.
6306 * eval.c (verror): Use vsnprintf, not doprnt, to do the real work.
6307 Report overflow in size calculations when allocating printf buffer.
6308 Do not truncate output string at its first null byte.
6309 * xdisp.c (vmessage): Use vsnprintf, not doprnt, to do the real work.
6310 Truncate the output at a character boundary, since vsnprintf does not
6311 do that.
6312 * charset.c (check_iso_charset_parameter): Convert internal
6313 character to string before calling 'error', since %c now has the
6314 printf meaning.
6315 * coding.c (Fdecode_sjis_char, Fdecode_big5_char): Avoid int
6316 overflow when computing char to be passed to 'error'. Do not
6317 pass Lisp_Object to 'error'; pass the integer instead.
6318 * nsfns.m (Fns_do_applescript): Use int, not long, since it's
6319 formatted with plain %d.
6320
b189fa66
PE
6321 * eval.c (internal_lisp_condition_case): Don't pass spurious arg.
6322
bff87ef0
PE
6323 * keyboard.c (access_keymap_keyremap): Print func name, not garbage.
6324
7e2cac20
PE
6325 * coding.c (Fdecode_sjis_char): Don't assume CODE fits in int.
6326
ce4d90b5
PE
6327 * xterm.c (x_catch_errors): Remove duplicate declaration.
6328
266c9547
PE
6329 * term.c (maybe_fatal): Mark its 3rd arg as a printf format, too.
6330
79c49ad2
PE
6331 * xdisp.c, lisp.h (message_nolog): Remove; unused.
6332
368f4090
JM
63332011-04-10 Jim Meyering <meyering@redhat.com>
6334
6335 use ssize_t and size_t for read- and write-like emacs_gnutls_* functions
6336 * gnutls.c (emacs_gnutls_read): Adjust signature to be more read-like:
6337 return ssize_t not "int", and use size_t as the buffer length.
6338 (emacs_gnutls_write): Likewise, and make the buffer pointer "const".
6339 * gnutls.h: Update declarations.
6340 * process.c (read_process_output): Use ssize_t, to match.
6341 (send_process): Likewise.
6342
a32d4040
CY
63432011-04-09 Chong Yidong <cyd@stupidchicken.com>
6344
6345 * image.c (Fimagemagick_types): Doc fix, and comment cleanup.
6346
8546720e 63472011-04-09 Chong Yidong <cyd@stupidchicken.com>
aac0c6e3 6348
04f2d78b
CB
6349 * ftfont.c (get_adstyle_property, ftfont_pattern_entity):
6350 Use unsigned char, to match FcChar8 type definition.
aac0c6e3 6351
8546720e
GM
6352 * xterm.c (handle_one_xevent):
6353 * xmenu.c (create_and_show_popup_menu):
6354 * xselect.c (x_decline_selection_request)
6355 (x_reply_selection_request): Avoid type-punned deref of X events.
aac0c6e3 6356
0a2f5c1a 63572011-04-09 Eli Zaretskii <eliz@gnu.org>
a53e2e89
EZ
6358
6359 Fix some uses of `int' instead of EMACS_INT.
6360 * search.c (string_match_1, fast_string_match)
6361 (fast_c_string_match_ignore_case, fast_string_match_ignore_case)
6362 (scan_buffer, find_next_newline_no_quit)
6363 (find_before_next_newline, search_command, Freplace_match)
6364 (Fmatch_data): Make some `int' variables be EMACS_INT.
6365
6366 * xdisp.c (display_count_lines): 3rd argument and return value now
6367 EMACS_INT. All callers changed.
6368 (pint2hrstr): Last argument is now EMACS_INT.
6369
6370 * coding.c (detect_coding_utf_8, detect_coding_emacs_mule)
6371 (detect_coding_iso_2022, detect_coding_sjis, detect_coding_big5)
6372 (detect_coding_ccl, detect_coding_charset, decode_coding_utf_8)
6373 (decode_coding_utf_16, decode_coding_emacs_mule)
6374 (decode_coding_iso_2022, decode_coding_sjis, decode_coding_big5)
6375 (decode_coding_ccl, decode_coding_charset)
6376 <consumed_chars, consumed_chars_base>: Declare EMACS_INT.
6377 (decode_coding_iso_2022, decode_coding_emacs_mule)
6378 (decode_coding_sjis, decode_coding_big5, decode_coding_charset)
6379 <char_offset, last_offset>: Declare EMACS_INT.
6380 (encode_coding_utf_8, encode_coding_utf_16)
6381 (encode_coding_emacs_mule, encode_invocation_designation)
6382 (encode_designation_at_bol, encode_coding_iso_2022)
6383 (encode_coding_sjis, encode_coding_big5, encode_coding_ccl)
6384 (encode_coding_raw_text, encode_coding_charset) <produced_chars>:
6385 Declare EMACS_INT.
6386 (ASSURE_DESTINATION): Declare more_bytes EMACS_INT.
6387 (encode_invocation_designation): Last argument P_NCHARS is now
6388 EMACS_INT.
6389 (decode_eol): Declare pos_byte, pos, and pos_end EMACS_INT.
6390 (produce_chars): from_nchars and to_nchars are now EMACS_INT.
6391
6392 * coding.h (struct coding_system) <head_ascii>: Declare EMACS_INT.
6393 All users changed.
6394
6395 * ccl.c (Fccl_execute_on_string): Declare some variables
6396 EMACS_INT.
6397
8546720e 63982011-04-08 Samuel Thibault <sthibault@debian.org> (tiny change)
0080dc6b
SS
6399
6400 * term.c (init_tty): Fix incorrect ifdef placement (Bug#8450).
6401
4e19a977
CS
64022011-03-19 Christoph Scholtes <cschol2112@googlemail.com>
6403
6404 * process.c (Fformat_network_address): Doc fix.
6405
87302331
R
64062011-04-08 T.V. Raman <tv.raman.tv@gmail.com> (tiny change)
6407
6408 * xml.c (parse_region): Avoid creating spurious whiespace nodes.
6409
cbb59342
CY
64102011-04-08 Chong Yidong <cyd@stupidchicken.com>
6411
6412 * keyboard.c (read_char): Call Lisp function help-form-show,
6413 instead of using internal_with_output_to_temp_buffer.
6414 (Qhelp_form_show): New var.
e0d38eeb 6415 (syms_of_keyboard): Use DEFSYM macro.
cbb59342
CY
6416
6417 * print.c (internal_with_output_to_temp_buffer): Function deleted.
6418
6419 * lisp.h (internal_with_output_to_temp_buffer): Remove prototype.
6420
e67a13ab
CY
64212011-04-06 Chong Yidong <cyd@stupidchicken.com>
6422
04f2d78b
CB
6423 * process.c (Flist_processes): Remove to Lisp.
6424 (list_processes_1): Delete.
e67a13ab 6425
973f782d
EZ
64262011-04-06 Eli Zaretskii <eliz@gnu.org>
6427
7c106b1e
EZ
6428 * msdos.c (careadlinkat, careadlinkatcwd): MS-DOS replacements.
6429
973f782d
EZ
6430 * w32.c (careadlinkat, careadlinkatcwd): New always-fail stubs.
6431
41cf7d1a 64322011-04-06 Paul Eggert <eggert@cs.ucla.edu>
27ccc379 6433
ca23cc88
PE
6434 Fix more problems found by GCC 4.6.0's static checks.
6435
f390e2d5
PE
6436 * xmenu.c (Fx_popup_dialog): Don't assume string is free of formats.
6437
42eea0d0
PE
6438 * menu.c (Fx_popup_menu): Don't assume error_name lacks printf formats.
6439
b69769da 6440 * lisp.h (message, message_nolog, fatal): Mark as printf-like.
1e973bc7 6441
f9541e84
PE
6442 * xdisp.c (vmessage): Mark as a printf-like function.
6443
13841b55
PE
6444 * term.c (vfatal, maybe_fatal): Mark as printf-like functions.
6445
c136c10f
PE
6446 * sound.c (sound_warning): Don't crash if arg contains a printf format.
6447
5e2d4a30
PE
6448 * image.c (tiff_error_handler, tiff_warning_handler): Mark as
6449 printf-like functions.
6450 (tiff_load): Add casts to remove these marks before passing them
6451 to system-supplied API.
6452
583f48b9
PE
6453 * eval.c (Fsignal): Remove excess argument to 'fatal'.
6454
b25d760e
PE
6455 * coding.c (EMIT_ONE_BYTE, EMIT_TWO_BYTES): Use unsigned, not int.
6456 This avoids several warnings with gcc -Wstrict-overflow.
d5efd1d1
PE
6457 (DECODE_COMPOSITION_RULE): If the rule is invalid, goto invalid_code
6458 directly, rather than having caller test rule sign. This avoids
6459 some unnecessary tests.
6460 * composite.h (COMPOSITION_ENCODE_RULE_VALID): New macro.
6461 (COMPOSITION_ENCODE_RULE): Arguments now must be valid. This
6462 affects only one use, in DECODE_COMPOSITION_RULE, which is changed.
b25d760e 6463
bc7b6697 6464 * xfont.c (xfont_text_extents): Remove var that was set but not used.
625a3eb1 6465 (xfont_open): Avoid unnecessary tests.
bc7b6697 6466
27ccc379
PE
6467 * composite.c (composition_gstring_put_cache): Use unsigned integer.
6468
dcd5c89a
PE
6469 * composite.h, composite.c (composition_gstring_put_cache):
6470 Use EMACS_INT, not int, for length.
6471
b13a45c6
PE
6472 * composite.h (COMPOSITION_DECODE_REFS): New macro,
6473 breaking out part of COMPOSITION_DECODE_RULE.
6474 (COMPOSITION_DECODE_RULE): Use it.
6475 * composite.c (get_composition_id): Remove unused local vars,
6476 by using the new macro.
6477
1e792e4d
PE
6478 * textprop.c (set_text_properties_1): Change while to do-while,
6479 since the condition is always true at first.
6480
dc6c6455 6481 * intervals.c (graft_intervals_into_buffer): Mark var as used.
aa86731f
PE
6482 (interval_deletion_adjustment): Return unsigned value.
6483 All uses changed.
dc6c6455 6484
aba7731a
PE
6485 * process.c (list_processes_1, create_pty, read_process_output):
6486 (exec_sentinel): Remove vars that were set but not used.
afd4052b 6487 (create_pty): Remove unnecessary "volatile"s.
bc57d757 6488 (Fnetwork_interface_info): Avoid possibility of int overflow.
82eaa333 6489 (read_process_output): Do adaptive read buffering even if carryover.
fe07cdfa 6490 (read_process_output): Simplify nbytes computation if buffered.
aba7731a 6491
fdfc4bf3
PE
6492 * bytecode.c (exec_byte_code): Rename local to avoid shadowing.
6493
fca8fe46 6494 * syntax.c (scan_words): Remove var that was set but not used.
12cbf13f 6495 (update_syntax_table): Use unsigned instead of int.
fca8fe46 6496
06a0259a 6497 * lread.c (lisp_file_lexically_bound_p): Use ints rather than endptrs.
3c346cc3 6498 (lisp_file_lexically_bound_p, read1): Use unsigned instead of int.
e6eb4e9e 6499 (safe_to_load_p): Make the end-of-loop test the inverse of the in-loop.
06a0259a 6500
e7b9e80f
PE
6501 * print.c (print_error_message): Avoid int overflow.
6502
56201685
PE
6503 * font.c (font_list_entities): Redo for clarity,
6504 so that reader need not know FONT_DPI_INDEX + 1 == FONT_SPACING_INDEX.
6505
78834453 6506 * font.c (font_find_for_lface, Ffont_get_glyphs): Remove unused vars.
790771b1 6507 (font_score): Avoid potential overflow in diff calculation.
78834453 6508
0bc0b309 6509 * fns.c (substring_both): Remove var that is set but not used.
8cd55cb4 6510 (sxhash): Redo loop for clarity and to avoid wraparound warning.
0bc0b309 6511
e610eaca
PE
6512 * eval.c (funcall_lambda): Rename local to avoid shadowing.
6513
b895abce
PE
6514 * alloc.c (mark_object_loop_halt, mark_object): Use size_t, not int.
6515 Otherwise, GCC 4.6.0 optimizes the loop check away since the check
6516 can always succeed if overflow has undefined behavior.
6517
1f1d9321 6518 * search.c (boyer_moore, wordify): Remove vars set but not used.
6f076cc7 6519 (wordify): Omit three unnecessary tests.
1f1d9321 6520
c59478bc
PE
6521 * indent.c (MULTIBYTE_BYTES_WIDTH): Don't compute wide_column.
6522 All callers changed. This avoids the need for an unused var.
6523
79b73827
PE
6524 * casefiddle.c (casify_region): Remove var that is set but not used.
6525
a4db5dfe
PE
6526 * dired.c (file_name_completion): Remove var that is set but not used.
6527
43aae36e
PE
6528 * fileio.c (Finsert_file_contents): Make EOF condition clearer.
6529
2a47c44d 6530 * fileio.c (Finsert_file_contents): Avoid signed integer overflow.
163c5f32 6531 (Finsert_file_contents): Remove unnecessary code checking fd.
2a47c44d 6532
a37c69bf
PE
6533 * minibuf.c (read_minibuf_noninteractive): Use size_t for sizes.
6534 Check for integer overflow on size calculations.
6535
328ab8e7
PE
6536 * buffer.c (Fprevious_overlay_change): Remove var that is set
6537 but not used.
6538
e5a2a5cb
PE
6539 * keyboard.c (menu_bar_items, read_char_minibuf_menu_prompt):
6540 Remove vars that are set but not used.
8d84a6eb 6541 (timer_check_2): Don't assume timer-list and idle-timer-list are lists.
6b043475 6542 (timer_check_2): Mark vars as initialized.
e5a2a5cb 6543
a60e5f68
PE
6544 * gtkutil.c (xg_get_file_with_chooser): Mark var as initialized.
6545
f661cb61 6546 * image.c (lookup_image): Remove var that is set but not used.
35fa624f 6547 (xbm_load): Use parse_p, for gcc -Werror=unused-but-set-variable.
f661cb61 6548
f0397f5a
PE
6549 * fontset.c (Finternal_char_font, Ffontset_info): Remove vars
6550 that are set but not used.
6551
8664db06 6552 * xfns.c (make_invisible_cursor): Don't return garbage
03733ee7 6553 if XCreateBitmapFromData fails (Bug#8410).
8664db06 6554
6abdaa4a
PE
6555 * xselect.c (x_get_local_selection, x_handle_property_notify):
6556 Remove vars that are set but not used.
6557
0ce7538d 6558 * xfns.c (x_create_tip_frame): Remove var that is set but not used.
6abdaa4a 6559 (make_invisible_cursor): Initialize a possibly-uninitialized variable.
0ce7538d 6560
9ae848fc
PE
6561 * xterm.c (x_scroll_bar_to_input_event) [!USE_GTK]:
6562 Remove var that is set but not used.
0b918413
PE
6563 (scroll_bar_windows_size): Now size_t, not int.
6564 (x_send_scroll_bar_event): Use size_t, not int, for sizes.
6565 Check for overflow.
9ae848fc 6566
a5a62657
PE
6567 * xfaces.c (realize_named_face): Remove vars that are set but not used.
6568 (map_tty_color) [!defined MSDOS]: Likewise.
6569
5c5cdd39
PE
6570 * term.c (tty_write_glyphs): Use size_t; this avoids overflow warning.
6571
66ebf983
PE
6572 * coding.c: Remove vars that are set but not used.
6573 (DECODE_COMPOSITION_RULE): Remove 2nd arg, which is unused.
6574 All callers changed.
6575 (decode_coding_utf_8, decode_coding_utf_16 decode_coding_emacs_mule):
6576 (decode_coding_iso_2022, encode_coding_sjis, encode_coding_big5):
6577 (decode_coding_charset): Remove vars that are set but not used.
6578
1be4d761
PE
6579 * bytecode.c (Fbyte_code) [!defined BYTE_CODE_SAFE]: Remove var
6580 that is set but not used.
6581
47553fa8
PE
6582 * print.c (print_object): Remove var that is set but not used.
6583
1f7196bf 6584 Replace 2 copies of readlink code with 1 gnulib version (Bug#8401).
d1fdcab7
PE
6585 The gnulib version avoids calling malloc in the usual case,
6586 and on 64-bit hosts doesn't have some arbitrary 32-bit limits.
6587 * fileio.c (Ffile_symlink_p): Use emacs_readlink.
6588 * filelock.c (current_lock_owner): Likewise.
6589 * lisp.h (READLINK_BUFSIZE, emacs_readlink): New function.
6590 * sysdep.c: Include allocator.h, careadlinkat.h.
6591 (emacs_no_realloc_allocator): New static constant.
6592 (emacs_readlink): New function.
fdb61804
PE
6593 * deps.mk (sysdep.o): Depend on ../lib/allocator.h and on
6594 ../lib/careadlinkat.h.
d1fdcab7 6595
f84c17c7
SM
65962011-04-04 Stefan Monnier <monnier@iro.umontreal.ca>
6597
6598 * keyboard.c (safe_run_hook_funcall): Fix last change (don't stop at the
6599 first non-nil return value).
6600
ef3862ad
JD
66012011-04-03 Jan Djärv <jan.h.d@swipnet.se>
6602
6603 * nsterm.m (ns_update_auto_hide_menu_bar): Define MAC_OS_X_VERSION_10_6
6604 if not defined (Bug#8403).
6605
376a7006
JB
66062011-04-02 Juanma Barranquero <lekktu@gmail.com>
6607
6608 * xdisp.c (display_count_lines): Remove parameter `start',
6609 unused since 1998-01-01T02:27:27Z!rms@gnu.org. All callers changed.
6610 (get_char_face_and_encoding): Remove parameter `multibyte_p',
6611 unused since 2008-05-14T01:40:23Z!handa@m17n.org. All callers changed.
6612 (fill_stretch_glyph_string): Remove parameters `row' and `area',
6613 unused at least since Kim's GUI unification at 2003-03-16T20:45:46Z!storm@cua.dk
6614 and thereabouts. All callers changed.
6615 (get_per_char_metric): Remove parameter `f', unused since
6616 2008-05-14T01:40:23Z!handa@m17n.org. All callers changed.
6617
6ca3801d
JM
66182011-04-02 Jim Meyering <meyering@redhat.com>
6619
6620 do not dereference NULL upon failed strdup
6621 * nsfont.m (ns_descriptor_to_entity): Use xstrdup, not strdup.
6622 (ns_get_family): Likewise.
6623
d8e2b5ba
JB
66242011-04-02 Juanma Barranquero <lekktu@gmail.com>
6625
6626 * eval.c (unwind_to_catch) [DEBUG_GCPRO]: Remove redundant assignment.
6627
8c74fcbd
JD
66282011-04-02 Jan Djärv <jan.h.d@swipnet.se>
6629
6630 * nsterm.m (ns_update_auto_hide_menu_bar): Only for OSX 10.6 or
6631 later (Bug#8403).
6632
7200d79c
SM
66332011-04-01 Stefan Monnier <monnier@iro.umontreal.ca>
6634
03408648 6635 Add lexical binding.
7200d79c 6636
03408648
SM
6637 * window.c (Ftemp_output_buffer_show): New fun.
6638 (Fsave_window_excursion):
6639 * print.c (Fwith_output_to_temp_buffer): Move to subr.el.
6640
6641 * lread.c (lisp_file_lexically_bound_p): New function.
6642 (Fload): Bind Qlexical_binding.
6643 (readevalloop): Remove `evalfun' arg.
6644 Bind Qinternal_interpreter_environment.
6645 (Feval_buffer): Bind Qlexical_binding.
6646 (defvar_int, defvar_bool, defvar_lisp_nopro, defvar_kboard):
6647 Mark as dynamic.
6648 (syms_of_lread): Declare `lexical-binding'.
6649
6650 * lisp.h (struct Lisp_Symbol): New field `declared_special'.
6651
6652 * keyboard.c (eval_dyn): New fun.
6653 (menu_item_eval_property): Use it.
ca105506
SM
6654
6655 * image.c (parse_image_spec): Use Ffunctionp.
ca105506 6656
03408648
SM
6657 * fns.c (concat, mapcar1): Accept byte-code-functions.
6658
6659 * eval.c (Fsetq): Handle lexical vars.
6660 (Fdefun, Fdefmacro, Ffunction): Make closures when needed.
6661 (Fdefconst, Fdefvaralias, Fdefvar): Mark as dynamic.
6662 (FletX, Flet): Obey lexical binding.
6663 (Fcommandp): Handle closures.
6664 (Feval): New `lexical' arg.
6665 (eval_sub): New function extracted from Feval. Use it almost
6666 everywhere where Feval was used. Look up vars in lexical env.
6667 Handle closures.
6668 (Ffunctionp): Move from subr.el.
6669 (Ffuncall): Handle closures.
6670 (apply_lambda): Remove `eval_flags'.
6671 (funcall_lambda): Handle closures and new byte-code-functions.
6672 (Fspecial_variable_p): New function.
6673 (syms_of_eval): Initialize the Vinternal_interpreter_environment var,
6674 but without exporting it to Lisp.
23aba0ea 6675
23aba0ea 6676 * doc.c (Fdocumentation, store_function_docstring):
03408648 6677 * data.c (Finteractive_form): Handle closures.
23aba0ea 6678
03408648
SM
6679 * callint.c (Fcall_interactively): Preserve lexical-binding mode for
6680 interactive spec.
ba83908c 6681
04f2d78b
CB
6682 * bytecode.c (Bstack_ref, Bstack_set, Bstack_set2, BdiscardN):
6683 New byte-codes.
03408648
SM
6684 (exec_byte_code): New function extracted from Fbyte_code to handle new
6685 calling convention for byte-code-functions. Add new byte-codes.
ba83908c 6686
03408648 6687 * buffer.c (defvar_per_buffer): Set new `declared_special' field.
e2abe5a1 6688
03408648 6689 * alloc.c (Fmake_symbol): Init new `declared_special' field.
e2abe5a1 6690
e2abce01
JB
66912011-03-31 Juanma Barranquero <lekktu@gmail.com>
6692
6693 * xdisp.c (redisplay_internal): Fix prototype.
6694
63696a73 66952011-03-31 Eli Zaretskii <eliz@gnu.org>
09725d26 6696
63696a73 6697 * xdisp.c (SCROLL_LIMIT): New macro.
04f2d78b
CB
6698 (try_scrolling): Use it when setting scroll_limit.
6699 Limit scrolling to 100 screen lines.
63696a73
EZ
6700 (redisplay_window): Even when falling back on "recentering",
6701 position point in the window according to scroll-conservatively,
6702 scroll-margin, and scroll-*-aggressively variables. (Bug#6671)
6703
6704 (try_scrolling): When point is above the window, allow searching
6705 as far as scroll_max, or one screenful, to compute vertical
6706 distance from PT to the scroll margin position. This prevents
6707 try_scrolling from unnecessarily failing when
6708 scroll-conservatively is set to a value slightly larger than the
6709 window height. Clean up the case of PT below the margin at bottom
6710 of window: scroll_max can no longer be INT_MAX. When aggressive
6711 scrolling is in use, don't let point enter the opposite scroll
6712 margin as result of the scroll.
6713 (syms_of_xdisp) <scroll-conservatively>: Document the
09725d26
EZ
6714 threshold of 100 lines for never-recentering scrolling.
6715
e4cc2dfc
JB
67162011-03-31 Juanma Barranquero <lekktu@gmail.com>
6717
6718 * dispextern.h (move_it_by_lines):
6719 * xdisp.c (move_it_by_lines): Remove parameter `need_y_p', unused
6720 since 2000-12-29T14:24:09Z!gerd@gnu.org. All callers changed.
6721 (message_log_check_duplicate): Remove parameters `prev_bol' and
6722 `this_bol', unused since 1998-01-01T02:27:27Z!rms@gnu.org. All callers changed.
6723 (redisplay_internal): Remove parameter `preserve_echo_area',
6724 unused since 1999-07-21T21:43:52Z!gerd@gnu.org. All callers changed.
6725
6726 * indent.c (Fvertical_motion):
6727 * window.c (window_scroll_pixel_based, Frecenter):
6728 Don't pass `need_y_p' to `move_it_by_lines'.
6729
1c470562
SM
67302011-03-30 Stefan Monnier <monnier@iro.umontreal.ca>
6731
44f230aa
SM
6732 * eval.c (struct backtrace): Don't cheat with negative numbers, but do
6733 steal a few bits to be more compact.
6734 (interactive_p, Fbacktrace, Fbacktrace_frame, mark_backtrace):
6735 Remove unneeded casts.
6736
1c470562
SM
6737 * bytecode.c (Fbyte_code): CAR and CDR can GC.
6738
888adce9
ZK
67392011-03-30 Zachary Kanfer <zkanfer@gmail.com> (tiny change)
6740
6741 * keyboard.c (Fexecute_extended_command): Do log the "suggest key
6742 binding" message (bug#7967).
6743
f838ed7b
PE
67442011-03-30 Paul Eggert <eggert@cs.ucla.edu>
6745
77861b95
PE
6746 Fix more problems found by GCC 4.6.0's static checks.
6747
de6dbc14
PE
6748 * unexelf.c (unexec) [! (defined _SYSTYPE_SYSV || defined __sgi)]:
6749 Remove unused local var.
6750
f838ed7b
PE
6751 * editfns.c (Fmessage_box): Remove unused local var.
6752
792c7b2b
PE
6753 * xdisp.c (try_window_reusing_current_matrix, x_produce_glyphs):
6754 (note_mode_line_or_margin_highlight, note_mouse_highlight):
6755 Omit unused local vars.
c499e557 6756 * window.c (shrink_windows): Omit unused local var.
b01a1c29 6757 * menu.c (digest_single_submenu): Omit unused local var.
0bc32927
PE
6758 * dispnew.c (update_window) [PERIODIC_PREEMPTION_CHECKING]:
6759 Omit unused local var.
6760
ba0165e1
PE
6761 * keyboard.c (parse_modifiers_uncached, parse_modifiers):
6762 Don't assume string length fits in int.
32ad8845 6763 (keyremap_step, read_key_sequence): Use size_t for sizes.
48011560 6764 (read_key_sequence): Don't check last_real_key_start redundantly.
ba0165e1 6765
3c59b4c9
PE
6766 * callproc.c (Fcall_process, Fcall_process_region): Use SAFE_ALLOCA
6767 instead of alloca (Bug#8344).
6768
a3eed478 6769 * eval.c (Fbacktrace): Don't assume nargs fits in int.
5d5d959d 6770 (Fbacktrace_frame): Don't assume nframes fits in int.
a3eed478 6771
eb4d412d
PE
6772 * syntax.c (scan_sexps_forward): Avoid pointer wraparound.
6773
1658b401
PE
6774 * xterm.c (x_make_frame_visible, same_x_server): Redo to avoid overflow
6775 concerns.
6776
6777 * term.c (produce_glyphless_glyph): Remove unnecessary test.
6778
6779 * cm.c (calccost): Turn while-do into do-while, for clarity.
44f730c8 6780
9a2c6e05
PE
6781 * keyboard.c (syms_of_keyboard): Use the same style as later
6782 in this function when indexing through an array. This also
6783 works around GCC bug 48267.
6784
03d0a109
PE
6785 * image.c (tiff_load): Fix off-by-one image count (Bug#8336).
6786
44f730c8
PE
6787 * xselect.c (x_check_property_data): Return correct size (Bug#8335).
6788
fe75f926
PE
6789 * chartab.c (sub_char_table_ref_and_range): Redo for slight
6790 efficiency gain, and to bypass a gcc -Wstrict-overflow warning.
6791
ffa8c828
PE
6792 * keyboard.c, keyboard.h (num_input_events): Now size_t.
6793 This avoids undefined behavior on integer overflow, and is a bit
6794 more convenient anyway since it is compared to a size_t variable.
6795
c5101a77
PE
6796 Variadic C functions now count arguments with size_t, not int.
6797 This avoids an unnecessary limitation on 64-bit machines, which
6798 caused (substring ...) to crash on large vectors (Bug#8344).
6799 * lisp.h (struct Lisp_Subr.function.aMANY): Now takes size_t, not int.
6800 (DEFUN_ARGS_MANY, internal_condition_case_n, safe_call): Likewise.
77861b95 6801 All variadic functions and their callers changed accordingly.
c5101a77
PE
6802 (struct gcpro.nvars): Now size_t, not int. All uses changed.
6803 * data.c (arith_driver, float_arith_driver): Likewise.
6804 * editfns.c (general_insert_function): Likewise.
6805 * eval.c (struct backtrace.nargs, interactive_p)
6806 (internal_condition_case_n, run_hook_with_args, apply_lambda)
6807 (funcall_lambda, mark_backtrace): Likewise.
6808 * fns.c (concat): Likewise.
6809 * frame.c (x_set_frame_parameters): Likewise.
6810 * fns.c (get_key_arg): Now accepts and returns size_t, and returns
6811 0 if not found, not -1. All callers changed.
6812
dd3f25f7
PE
6813 * alloc.c (garbage_collect): Don't assume stack size fits in int.
6814 (stack_copy_size): Now size_t, not int.
6815 (stack_copy, stack_copy_size): Define only if MAX_SAVE_STACK > 0.
6816
461c2ab9
JB
68172011-03-28 Juanma Barranquero <lekktu@gmail.com>
6818
6819 * coding.c (encode_designation_at_bol): Remove parameter `charbuf_end',
6820 unused since 2002-03-01T01:17:24Z!handa@m17n.org and 2008-02-01T16:01:31Z!miles@gnu.org.
6821 All callers changed.
6822
6823 * lisp.h (multibyte_char_to_unibyte):
6824 * character.c (multibyte_char_to_unibyte): Remove parameter `rev_tbl',
6825 unused since 2002-03-01T01:16:34Z!handa@m17n.org and 2008-02-01T16:01:31Z!miles@gnu.org.
6826 * character.h (CHAR_TO_BYTE8):
6827 * cmds.c (internal_self_insert):
6828 * editfns.c (general_insert_function):
6829 * keymap.c (push_key_description):
6830 * search.c (Freplace_match):
6831 * xdisp.c (message_dolog, set_message_1): All callers changed.
6832
f6d62986
SM
68332011-03-28 Stefan Monnier <monnier@iro.umontreal.ca>
6834
6835 * keyboard.c (safe_run_hook_funcall): New function.
6836 (safe_run_hooks_1, safe_run_hooks_error, safe_run_hooks): On error,
6837 don't set the hook to nil, but remove the offending function instead.
6838 (Qcommand_hook_internal): Remove, unused.
6839 (syms_of_keyboard): Don't initialize Qcommand_hook_internal nor define
6840 Vcommand_hook_internal.
6841
6842 * eval.c (enum run_hooks_condition): Remove.
6843 (funcall_nil, funcall_not): New functions.
6844 (run_hook_with_args): Call each function through a `funcall' argument.
6845 Remove `cond' argument, now redundant.
6846 (Frun_hooks, Frun_hook_with_args, Frun_hook_with_args_until_success)
6847 (Frun_hook_with_args_until_failure): Adjust accordingly.
6848 (run_hook_wrapped_funcall, Frun_hook_wrapped): New functions.
6849
1db5b1ad
JB
68502011-03-28 Juanma Barranquero <lekktu@gmail.com>
6851
6852 * dispextern.h (string_buffer_position): Remove declaration.
6853
6854 * print.c (strout): Remove parameter `multibyte', unused since
6855 1999-08-21T19:30:21Z!gerd@gnu.org. All callers changed.
6856
6857 * search.c (boyer_moore): Remove parameters `len', `pos' and `lim',
6858 never used since function introduction in 1998-02-08T21:33:56Z!rms@gnu.org.
6859 All callers changed.
6860
6861 * w32.c (_wsa_errlist): Use braces for struct initializers.
6862
6863 * xdisp.c (string_buffer_position_lim): Remove parameter `w',
6864 never used since function introduction in 2001-03-09T18:41:50Z!gerd@gnu.org.
6865 All callers changed.
6866 (string_buffer_position): Likewise. Also, make static (it's never
6867 used outside xdisp.c).
6868 (cursor_row_p): Remove parameter `w', unused since
6869 2000-10-17T16:08:57Z!gerd@gnu.org. All callers changed.
6870 (decode_mode_spec): Remove parameter `precision', introduced during
6871 Gerd Moellmann's rewrite at 1999-07-21T21:43:52Z!gerd@gnu.org, but never used.
6872 All callers changed.
6873
5ffb62aa
JD
68742011-03-27 Jan Djärv <jan.h.d@swipnet.se>
6875
6876 * nsterm.m (syms_of_nsterm): Use doc: for ns-auto-hide-menu-bar.
6877
461c2ab9 68782011-03-27 Anders Lindgren <andlind@gmail.com>
f0a1382a
JD
6879
6880 * nsterm.m (ns_menu_bar_is_hidden): New variable.
6881 (ns_constrain_all_frames, ns_menu_bar_should_be_hidden)
6882 (ns_update_auto_hide_menu_bar): New functions.
6883 (ns_update_begin): Call ns_update_auto_hide_menu_bar.
6884 (applicationDidBecomeActive): Call ns_update_auto_hide_menu_bar and
6885 ns_constrain_all_frames.
6886 (constrainFrameRect): Return at once if ns_menu_bar_should_be_hidden.
6887 (syms_of_nsterm): DEFVAR ns-auto-hide-menu-bar, init to Qnil.
6888
5c380ffb
JD
68892011-03-27 Jan Djärv <jan.h.d@swipnet.se>
6890
6891 * nsmenu.m (runDialogAt): Remove argument to timer_check.
6892
9af30bdf
GM
68932011-03-27 Glenn Morris <rgm@gnu.org>
6894
6895 * syssignal.h: Replace RETSIGTYPE with void.
6896 * atimer.c, data.c, dispnew.c, emacs.c, floatfns.c, keyboard.c:
6897 * keyboard.h, lisp.h, process.c, sysdep.c, xterm.c:
6898 Replace SIGTYPE with void everywhere.
6899 * s/usg5-4-common.h (SIGTYPE): Remove definition.
6900 * s/template.h (SIGTYPE): Remove commented out definition.
6901
e2abce01
JB
69022011-03-26 Eli Zaretskii <eliz@gnu.org>
6903
6904 * xdisp.c (redisplay_window): Don't check buffer's clip_changed
6905 flag as a prerequisite for invoking try_scrolling. (Bug#6671)
6906
f868cd8a
JB
69072011-03-26 Juanma Barranquero <lekktu@gmail.com>
6908
59eb0929
JB
6909 * w32.c (read_unc_volume): Use parameter `henum', instead of
6910 global variable `wget_enum_handle'.
6911
6912 * keymap.c (describe_vector): Remove parameters `indices' and
6913 `char_table_depth', unused since 2002-03-01T01:43:26Z!handa@m17n.org.
6914 (describe_map, Fdescribe_vector): Adjust calls to `describe_vector'.
6915
f868cd8a
JB
6916 * keyboard.h (timer_check, show_help_echo): Remove unused parameters.
6917
6918 * keyboard.c (timer_check): Remove parameter `do_it_now',
6919 unused since 1996-04-12T06:01:29Z!rms@gnu.org.
6920 (show_help_echo): Remove parameter `ok_to_overwrite_keystroke_echo',
6921 unused since 2008-04-19T19:30:53Z!monnier@iro.umontreal.ca.
6922
6923 * keyboard.c (read_char):
6924 * w32menu.c (w32_menu_display_help):
6925 * xmenu.c (show_help_event, menu_help_callback):
6926 Adjust calls to `show_help_echo'.
6927
6928 * gtkutil.c (xg_maybe_add_timer):
6929 * keyboard.c (readable_events):
6930 * process.c (wait_reading_process_output):
6931 * xmenu.c (x_menu_wait_for_event): Adjust calls to `timer_check'.
6932
6933 * insdel.c (adjust_markers_gap_motion):
6934 Remove; no-op since 1998-01-02T21:29:48Z!rms@gnu.org.
6935 (gap_left, gap_right): Don't call it.
6936
2ecf6fdb
CY
69372011-03-25 Chong Yidong <cyd@stupidchicken.com>
6938
6939 * xdisp.c (handle_fontified_prop): Discard changes to clip_changed
6940 incurred during fontification.
6941
6b1f9ba4
JB
69422011-03-25 Juanma Barranquero <lekktu@gmail.com>
6943
6944 * buffer.c (defvar_per_buffer): Remove unused parameter `doc'.
6945 (DEFVAR_PER_BUFFER): Don't pass it.
6946
6947 * dispnew.c (row_equal_p, add_row_entry): Remove unused parameter `w'.
6948 (scrolling_window): Don't pass it.
6949
0f4a96b5
JB
69502011-03-25 Juanma Barranquero <lekktu@gmail.com>
6951
6952 * dispextern.h (glyph_matric): Use #if GLYPH_DEBUG, not #ifdef.
6953
6954 * fileio.c (check_executable) [DOS_NT]: Remove unused variables `len'
6955 and `suffix'.
6956 (Fset_file_selinux_context) [HAVE_LIBSELINUX]: Move here declaration
6957 of variables specific to SELinux and computation of `encoded_absname'.
6958
6959 * image.c (XPutPixel): Remove unused variable `height'.
6960
6961 * keyboard.c (make_lispy_event): Remove unused variable `hpos'.
6962
6963 * unexw32.c (get_section_info): Remove unused variable `section'.
6964
6965 * w32.c (stat): Remove unused variables `drive_root' and `devtype'.
6966 (system_process_attributes): Remove unused variable `sess'.
6967 (sys_read): Remove unused variable `err'.
6968
6969 * w32fns.c (top): Wrap variables with #if GLYPH_DEBUG, not #ifdef.
6970 (w32_wnd_proc): Remove unused variable `isdead'.
6971 (unwind_create_frame): Use #if GLYPH_DEBUG, not #ifdef.
6972 (Fx_server_max_request_size): Remove unused variable `dpyinfo'.
6973 (x_create_tip_frame): Remove unused variable `tem'.
6974
6975 * w32inevt.c (w32_console_read_socket):
6976 Remove unused variable `no_events'.
6977
6978 * w32term.c (x_draw_composite_glyph_string_foreground):
6979 Remove unused variable `width'.
6980
1149507c
JB
69812011-03-24 Juanma Barranquero <lekktu@gmail.com>
6982
6983 * w32term.c (x_set_glyph_string_clipping):
6984 Don't pass uninitialized region to CombineRgn.
6985
9c88f339
JB
69862011-03-23 Juanma Barranquero <lekktu@gmail.com>
6987
6988 * w32fns.c (x_set_menu_bar_lines): Remove unused variable `olines'.
6989 (w32_wnd_proc): Pass NULL to Windows API, not uninitialized buffer.
6990 (Fx_close_connection): Remove unused variable `i'.
6991
6992 * w32font.c (w32font_draw): Return number of glyphs.
6993 (w32font_open_internal): Remove unused variable `i'.
6994 (w32font_driver): Add missing initializer.
6995
6996 * w32menu.c (utf8to16): Remove unused variable `utf16'.
6997 (fill_in_menu): Remove unused variable `items_added'.
6998
6999 * w32term.c (last_mouse_press_frame): Remove static global variable.
7000 (w32_clip_to_row): Remove unused variable `f'.
7001 (x_delete_terminal): Remove unused variable `i'.
7002
7003 * w32uniscribe.c (uniscribe_shape): Remove unused variable `nclusters'.
7004 (NOTHING): Remove unused static global variable.
7005 (uniscribe_check_otf): Remove unused variable `table'.
7006 (uniscribe_font_driver): Add missing initializers.
7007
dee091a3
JD
70082011-03-23 Julien Danjou <julien@danjou.info>
7009
7010 * term.c (Fsuspend_tty, Fresume_tty):
7011 * minibuf.c (read_minibuf, run_exit_minibuf_hook):
7012 * window.c (temp_output_buffer_show):
7013 * insdel.c (signal_before_change):
7014 * frame.c (Fhandle_switch_frame):
7015 * fileio.c (Fdo_auto_save):
7016 * emacs.c (Fkill_emacs):
7017 * editfns.c (save_excursion_restore):
7018 * cmds.c (internal_self_insert):
7019 * callint.c (Fcall_interactively):
7020 * buffer.c (Fkill_all_local_variables):
7021 * keyboard.c (Fcommand_execute, Fsuspend_emacs, safe_run_hooks_1):
7022 Use Frun_hooks.
0f4a96b5 7023 (command_loop_1): Use Frun_hooks. Call safe_run_hooks
dee091a3
JD
7024 unconditionnaly since it does the check itself.
7025
2c520ab5 70262011-03-23 Paul Eggert <eggert@cs.ucla.edu>
f0641eff 7027
c9c49752
PE
7028 Fix more problems found by GCC 4.5.2's static checks.
7029
8abc3f12
PE
7030 * coding.c (encode_coding_raw_text): Avoid unnecessary test
7031 the first time through the loop, since we know p0 < p1 then.
7032 This also avoids a gcc -Wstrict-overflow warning.
7033
a2d26660
PE
7034 * lisp.h (SAFE_ALLOCA, SAFE_ALLOCA_LISP): Avoid 'int' overflow
7035 leading to a memory leak, possible in functions like
7036 load_charset_map_from_file that can allocate an unbounded number
b12ef411 7037 of objects (Bug#8318).
a2d26660 7038
916c72e9
PE
7039 * xmenu.c (set_frame_menubar): Use EMACS_UINT, not int, for indexes
7040 that could (at least in theory) be that large.
7041
19ab8a18
PE
7042 * xdisp.c (message_log_check_duplicate): Return unsigned long, not int.
7043 This is less likely to overflow, and avoids undefined behavior if
7044 overflow does occur. All callers changed. Use strtoul to scan
7045 for the unsigned long integer.
b7cbbd6f
PE
7046 (pint2hrstr): Simplify and tune code slightly.
7047 This also avoids a (bogus) GCC warning with gcc -Wstrict-overflow.
19ab8a18 7048
f0641eff
PE
7049 * scroll.c (do_scrolling): Work around GCC bug 48228.
7050 See <http://gcc.gnu.org/bugzilla/show_bug.cgi?id=48228>.
7051
7f650bb9
PE
7052 * frame.c (Fmodify_frame_parameters): Simplify loop counter.
7053 This also avoids a warning with gcc -Wstrict-overflow.
39f5e519
PE
7054 (validate_x_resource_name): Simplify count usage.
7055 This also avoids a warning with gcc -Wstrict-overflow.
7f650bb9 7056
37dd57d1
PE
7057 * fileio.c (Fcopy_file): Report error if fchown or fchmod
7058 fail (Bug#8306).
81e56e61 7059
699979fc 7060 * emacs.c (Fdaemon_initialized): Do not ignore I/O errors (Bug#8303).
dc1ca6a8 7061
401bf9b4
PE
7062 * process.c (Fmake_network_process): Use socklen_t, not int,
7063 where POSIX says socklen_t is required in portable programs.
7064 This fixes a porting bug on hosts like 64-bit HP-UX, where
591b2973 7065 socklen_t is wider than int (Bug#8277).
401bf9b4
PE
7066 (Fmake_network_process, server_accept_connection):
7067 (wait_reading_process_output, read_process_output):
7068 Likewise.
7069
b93aacde
PE
7070 * process.c: Rename or move locals to avoid shadowing.
7071 (list_processes_1, Fmake_network_process):
7072 (read_process_output_error_handler, exec_sentinel_error_handler):
7073 Rename or move locals.
4dc343ee 7074 (Fmake_network_process): Define label "retry_connect" only if needed.
0da49335 7075 (Fnetwork_interface_info): Fix pointer signedness.
f990b4e5 7076 (process_send_signal): Add cast to avoid pointer signedness problem.
7b808126 7077 (FIRST_PROC_DESC, IF_NON_BLOCKING_CONNECT): Remove unused macros.
c939f91b 7078 (create_process): Use 'volatile' to avoid vfork clobbering (Bug#8298).
b93aacde 7079
af8a867c 7080 Make tparam.h and terminfo.c consistent.
44f230aa
SM
7081 * cm.c (tputs, tgoto, BC, UP): Remove extern decls.
7082 Include tparam.h instead, since it declares them.
af8a867c
PE
7083 * cm.h (PC): Remove extern decl; tparam.h now does this.
7084 * deps.mk (cm.o, terminfo.o): Depend on tparam.h.
7085 * terminfo.c: Include tparam.h, to check interfaces.
7086 (tparm): Make 1st arg a const pointer in decl. Put it at top level.
7087 (tparam): Adjust signature to match interface in tparam.h;
7088 this removes some undefined behavior. Check that outstring and len
7089 are zero, which they always are with Emacs.
7090 * tparam.h (PC, BC, UP): New extern decls.
7091
0248044d 7092 * xftfont.c (xftfont_shape): Now static, and defined only if needed.
001a7ab4 7093 (xftfont_open): Rename locals to avoid shadowing.
0248044d 7094
8ff096c1 7095 * ftfont.c (ftfont_resolve_generic_family): Fix pointer signedness.
a00924bb
PE
7096 (ftfont_otf_capability, ftfont_shape): Omit decls if not needed.
7097 (OTF_TAG_SYM): Omit macro if not needed.
e932860f 7098 (ftfont_list): Remove unused local.
49eaafba
PE
7099 (get_adstyle_property, ftfont_pattern_entity):
7100 (ftfont_lookup_cache, ftfont_open, ftfont_anchor_point):
7101 Rename locals to avoid shadowing.
8ff096c1 7102
e2be39f6
PE
7103 * xfont.c (xfont_list_family): Mark var as initialized.
7104
c9735e30
PE
7105 * xml.c (make_dom): Now static.
7106
8f5201ae
PE
7107 * composite.c (composition_compute_stop_pos): Rename local to
7108 avoid shadowing.
b246f932
PE
7109 (composition_reseat_it): Remove unused locals.
7110 (find_automatic_composition, composition_adjust_point): Likewise.
80e079b2 7111 (composition_update_it): Mark var as initialized.
11b61122
PE
7112 (find_automatic_composition): Mark vars as initialized,
7113 with a FIXME (Bug#8290).
8f5201ae 7114
760fbc2c
PE
7115 character.h: Rename locals to avoid shadowing.
7116 * character.h (PREV_CHAR_BOUNDARY, FETCH_STRING_CHAR_ADVANCE):
7117 (FETCH_STRING_CHAR_AS_MULTIBYTE_ADVANCE, FETCH_CHAR_ADVANCE):
7118 (FETCH_CHAR_ADVANCE_NO_CHECK, INC_POS, DEC_POS, BUF_INC_POS):
7119 (BUF_DEC_POS): Be more systematic about renaming local temporaries
7120 to avoid shadowing.
7121
ff08eb85
PE
7122 * textprop.c (property_change_between_p): Remove; unused.
7123
fc7bf025
PE
7124 * intervals.c (interval_start_pos): Now static.
7125
235d7abc
PE
7126 * intervals.h (CHECK_TOTAL_LENGTH): Avoid empty "else".
7127
44f230aa
SM
7128 * atimer.c (start_atimer, append_atimer_lists, set_alarm):
7129 Rename locals to avoid shadowing.
3e7d6594 7130
50060332
PE
7131 * sound.c (wav_play, au_play, Fplay_sound_internal):
7132 Fix pointer signedness.
d01f234b 7133 (alsa_choose_format): Remove unused local var.
c83b8872
PE
7134 (wav_play): Initialize a variable to 0, to prevent undefined
7135 behavior (Bug#8278).
50060332 7136
c4fc4e30
PE
7137 * region-cache.c (insert_cache_boundary): Redo var to avoid shadowing.
7138
918436ed
PE
7139 * region-cache.h (pp_cache): New decl, for gcc -Wmissing-prototypes.
7140
c939f91b
PE
7141 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork
7142 clobbering (Bug#8298).
b9c7f648
PE
7143 * sysdep.c (sys_subshell): Likewise.
7144 Previously, the sys_subshell 'volatile' was incorrectly IF_LINTted out.
7e9123a2 7145
6bd8c144
PE
7146 * lisp.h (child_setup): Now NO_RETURN unless DOS_NT.
7147 This should get cleaned up, so that child_setup has the
7148 same signature on all platforms.
7149
7710357c 7150 * callproc.c (call_process_cleanup): Now static.
cb1d0ef7 7151 (relocate_fd): Rename locals to avoid shadowing.
7710357c 7152
c59da222
CY
71532011-03-22 Chong Yidong <cyd@stupidchicken.com>
7154
7155 * xterm.c (x_clear_frame): Remove XClearWindow call. This appears
7156 not to be necessary, and produces flickering.
7157
66b87493
GM
71582011-03-20 Glenn Morris <rgm@gnu.org>
7159
7160 * config.in: Remove file.
7161
45b6f6d5
JB
71622011-03-20 Juanma Barranquero <lekktu@gmail.com>
7163
7164 * minibuf.c (Vcompleting_read_function): Don't declare, global variables
7165 are now in src/globals.h.
7166 (syms_of_minibuf): Remove spurious & from previous change.
7167
3ec03f7e
LL
71682011-03-20 Leo <sdl.web@gmail.com>
7169
7170 * minibuf.c (completing-read-function): New variable.
7171 (completing-read-default): Rename from completing-read.
7172 (completing-read): Call completing-read-function.
7173
b14e3e21
CY
71742011-03-19 Juanma Barranquero <lekktu@gmail.com>
7175
7176 * xfaces.c (Fx_load_color_file):
7177 Read color file from absolute filename (bug#8250).
7178
f2b726e6
JB
71792011-03-19 Juanma Barranquero <lekktu@gmail.com>
7180
7181 * makefile.w32-in: Update dependencies.
7182
09f6ff02
EZ
71832011-03-17 Eli Zaretskii <eliz@gnu.org>
7184
7185 * makefile.w32-in ($(BLD)/unexw32.$(O)): Depend on $(SRC)/unexec.h.
7186
29a6015a
PE
71872011-03-17 Paul Eggert <eggert@cs.ucla.edu>
7188
a3a6c54e
PE
7189 Fix more problems found by GCC 4.5.2's static checks.
7190
b766f867
PE
7191 * process.c (make_serial_process_unwind, send_process_trap):
7192 (sigchld_handler): Now static.
7193
be02381c
PE
7194 * process.c (allocate_pty): Let PTY_ITERATION declare iteration vars.
7195 That way, the code declares only the vars that it needs.
7196 * s/aix4-2.h (PTY_ITERATION): Declare iteration vars.
7197 * s/cygwin.h (PTY_ITERATION): Likewise.
7198 * s/darwin.h (PTY_ITERATION): Likewise.
7199 * s/gnu-linux.h (PTY_ITERATION): Likewise.
7200
57048744
PE
7201 * s/irix6-5.h (PTY_OPEN): Declare stb, to loosen coupling.
7202 * process.c (allocate_pty): Don't declare stb unless it's needed.
7203
7914961c 7204 * bytecode.c (MAYBE_GC): Rewrite so as not to use empty "else".
615f2d59
PE
7205 (CONSTANTLIM): Remove; unused.
7206 (METER_CODE, Bscan_buffer, Bread_char, Bset_mark):
7207 Define only if needed.
7914961c 7208
b3967b18
PE
7209 * unexelf.c (unexec): Name an expression,
7210 to avoid gcc -Wbad-function-cast warning.
9ae71512
PE
7211 Use a different way to cause a compilation error if anyone uses
7212 n rather than nn, a way that does not involve shadowing.
73366a00 7213 (ELF_BSS_SECTION_NAME, OLD_PROGRAM_H): Remove; unused.
b3967b18 7214
29a6015a
PE
7215 * deps.mk (unexalpha.o): Remove; unused.
7216
43cfc33e 7217 New file unexec.h, the (simple) interface for unexec (Bug#8267).
7feda0d2 7218 * unexec.h: New file.
ce701a33
PE
7219 * deps.mk (emacs.o, unexaix.o, unexcw.o, unexcoff.o, unexelf.o):
7220 (unexhp9k800.o, unexmacosx.o, unexsol.o, unexw32.o):
7221 Depend on unexec.h.
7222 * emacs.c [!defined CANNOT_DUMP]: Include unexec.h.
7223 * unexaix.c, unexcoff.c, unexcw.c, unexelf.c, unexhp9k800.c:
7224 * unexmacosx.c, unexsol.c, unexw32.c: Include unexec.h.
381259ef 7225 Change as necessary to match prototype in unexec.h.
ce701a33 7226
01f44d5a
PE
7227 * syntax.c (Fforward_comment, scan_lists): Rename locals to avoid
7228 shadowing.
4f63c6bb 7229 (back_comment, skip_chars): Mark vars as initialized.
01f44d5a 7230
a6670b0b
PE
7231 * character.h (FETCH_STRING_CHAR_ADVANCE_NO_CHECK, BUF_INC_POS):
7232 Rename locals to avoid shadowing.
7233
cef2010d 7234 * lread.c (read1): Rewrite so as not to use empty "else".
0902fe45 7235 (Fload, readevalloop, read1): Rename locals to avoid shadowing.
cef2010d 7236
d4d7173a
PE
7237 * print.c (Fredirect_debugging_output): Fix pointer signedess.
7238
f08b802a
PE
7239 * lisp.h (debug_output_compilation_hack): Add decl here, to avoid
7240 warning when compiling print.c.
7241
3ddb0639
PE
7242 * font.c (font_unparse_fcname): Abort in an "impossible" situation
7243 instead of using an uninitialized var.
5ad03b97 7244 (font_sort_entities): Mark var as initialized.
3ddb0639 7245
170a2692
PE
7246 * character.h (FETCH_CHAR_ADVANCE): Rename locals to avoid shadowing.
7247
e663c700
PE
7248 * font.c (font_unparse_xlfd): Don't mix pointers to variables with
7249 pointers to constants.
89bc529a 7250 (font_parse_fcname): Remove unused vars.
7b81e2d0 7251 (font_delete_unmatched): Now static.
ea838e10 7252 (font_get_spec): Remove; unused.
13a547c6
PE
7253 (font_style_to_value, font_prop_validate_style, font_unparse_fcname):
7254 (font_update_drivers, Ffont_get_glyphs, font_add_log):
7255 Rename or move locals to avoid shadowing.
e663c700 7256
2a80c887 7257 * fns.c (require_nesting_list, require_unwind): Now static.
612f56df 7258 (Ffillarray): Rename locals to avoid shadowing.
2a80c887 7259
1384fa33 7260 * floatfns.c (domain_error2): Define only if needed.
a885e2ed 7261 (Ffrexp, Fldexp): Rename locals to avoid shadowing.
1384fa33 7262
8b2c52e9
PE
7263 * alloc.c (mark_backtrace): Move decl from here ...
7264 * lisp.h: ... to here, so that it can be checked.
7265
475545b5 7266 * eval.c (call_debugger, do_debug_on_call, grow_specpdl): Now static.
d28a2170 7267 (Fdefvar): Rewrite so as not to use empty "else".
cfcbfb1a
PE
7268 (lisp_indirect_variable): Name an expression,
7269 to avoid gcc -Wbad-function-cast warning.
1faed8ae 7270 (Fdefvar): Rename locals to avoid shadowing.
475545b5 7271
b1349114 7272 * callint.c (quotify_arg, quotify_args): Now static.
a3e8cbda 7273 (Fcall_interactively): Rename locals to avoid shadowing.
b0e80955 7274 Use const pointer when appropriate.
b1349114 7275
a2928364
PE
7276 * lisp.h (get_system_name, get_operating_system_release):
7277 Move decls here, to check interfaces.
7278 * process.c (get_operating_system_release): Move decl to lisp.h.
7279 * xrdb.c (get_system_name): Likewise.
63c5d10b
PE
7280 * editfns.c (init_editfns, Fuser_login_name, Fuser_uid):
7281 (Fuser_real_uid, Fuser_full_name): Remove unnecessary casts,
7282 some of which prompt warnings from gcc -Wbad-function-cast.
545b49b4
PE
7283 (Fformat_time_string, Fencode_time, Finsert_char):
7284 (Ftranslate_region_internal, Fformat):
7285 Rename or remove local vars to avoid shadowing.
9710023e 7286 (Ftranslate_region_internal): Mark var as initialized.
63c5d10b 7287
a415e694
PE
7288 * doc.c (Fdocumentation, Fsnarf_documentation): Move locals to
7289 avoid shadowing.
7290
8ef4622d
PE
7291 * lisp.h (eassert): Check that the argument compiles, even if
7292 ENABLE_CHECKING is not defined.
7293
946f9a5b
PE
7294 * data.c (Findirect_variable): Name an expression, to avoid
7295 gcc -Wbad-function-cast warning.
112396d6 7296 (default_value, arithcompare, arith_driver, arith_error): Now static.
b9b84fa9 7297 (store_symval_forwarding): Rename local to avoid shadowing.
44f230aa
SM
7298 (Fmake_variable_buffer_local, Fmake_local_variable):
7299 Mark variables as initialized.
52746918 7300 (do_blv_forwarding, do_symval_forwarding): Remove; unused.
946f9a5b 7301
e5aab7e7 7302 * alloc.c (check_cons_list): Do not define unless GC_CHECK_CONS_LIST.
ae35e756
PE
7303 (Fmake_vector, Fvector, Fmake_byte_code, Fgarbage_collect):
7304 Rename locals to avoid shadowing.
dff45157
PE
7305 (mark_stack): Move local variables into the #ifdef region where
7306 they're used.
7bc26fdb
PE
7307 (BLOCK_INPUT_ALLOC, UNBLOCK_INPUT_ALLOC): Define only if
7308 ! defined SYSTEM_MALLOC && ! defined SYNC_INPUT, as they are not
7309 needed otherwise.
7310 (CHECK_ALLOCATED): Define only if GC_CHECK_MARKED_OBJECTS.
7311 (GC_STRING_CHARS): Remove; not used.
d40d4be1 7312 (Fmemory_limit): Cast sbrk's returned value to char *.
ae35e756 7313
e5aab7e7
PE
7314 * lisp.h (check_cons_list): Declare if GC_CHECK_CONS_LIST; this
7315 avoids undefined behavior in theory.
7316
4da60324
PE
7317 * regex.c (IF_LINT): Add defn, for benefit of ../lib-src.
7318
88043301
PE
7319 Use functions, not macros, for up- and down-casing (Bug#8254).
7320 * buffer.h (DOWNCASE_TABLE, UPCASE_TABLE, DOWNCASE, UPPERCASEP):
7321 (NOCASEP, LOWERCASEP, UPCASE, UPCASE1): Remove. All callers changed
7322 to use the following functions instead of these macros.
7323 (downcase): Adjust to lack of DOWNCASE_TABLE. Return int, not
7324 EMACS_INT, since callers assume the returned value fits in int.
7325 (upcase1): Likewise, for UPCASE_TABLE.
7326 (uppercasep, lowercasep, upcase): New static inline functions.
0da09c43 7327 * editfns.c (Fchar_equal): Remove no-longer-needed workaround for
db69b0cd 7328 the race-condition problem in the old DOWNCASE.
88043301 7329
19ed5445
PE
7330 * regex.c (CHARSET_LOOKUP_RANGE_TABLE_RAW, POP_FAILURE_REG_OR_COUNT):
7331 Rename locals to avoid shadowing.
7332 (regex_compile, re_match_2_internal): Move locals to avoid shadowing.
abbd1bcf
PE
7333 (regex_compile, re_search_2, re_match_2_internal):
7334 Remove unused local vars.
952db0d7
PE
7335 (FREE_VAR): Rewrite so as not to use empty "else",
7336 which gcc can warn about.
da053e48 7337 (regex_compile, re_match_2_internal): Mark locals as initialized.
b313f9d8
PE
7338 (RETALLOC_IF): Define only if needed.
7339 (WORDCHAR_P): Likewise. This one is never needed, but is used
7340 only in a comment talking about a compiler bug, so put inside
7341 the #if 0 of that comment.
7342 (CHARSET_LOOKUP_BITMAP, FAIL_STACK_FULL, RESET_FAIL_STACK):
7343 (PUSH_FAILURE_ELT, BUF_PUSH_3, STOP_ADDR_VSTRING):
7344 Remove; unused.
19ed5445 7345
1f3561e4 7346 * search.c (boyer_moore): Rename locals to avoid shadowing.
76ef09b7
PE
7347 * character.h (FETCH_STRING_CHAR_AS_MULTIBYTE_ADVANCE):
7348 (PREV_CHAR_BOUNDARY): Likewise.
1f3561e4 7349
ded6f8f7
PE
7350 * search.c (simple_search): Remove unused var.
7351
dbd37a95
PE
7352 * dired.c (compile_pattern): Move decl from here ...
7353 * lisp.h: ... to here, so that it can be checked.
7354 (struct re_registers): New forward decl.
7355
7e47afad
PE
7356 * character.h (INC_POS, DEC_POS): Rename locals to avoid shadowing.
7357
85f24f61
PE
7358 * indent.c (MULTIBYTE_BYTES_WIDTH): New args bytes, width.
7359 All uses changed.
7360 (MULTIBYTE_BYTES_WIDTH, scan_for_column, compute_motion):
7361 Rename locals to avoid shadowing.
5671df8f 7362 (Fvertical_motion): Mark locals as initialized.
85f24f61 7363
181aa2be 7364 * casefiddle.c (casify_object, casify_region): Now static.
e45a141a 7365 (casify_region): Mark local as initialized.
181aa2be 7366
930d429c
PE
7367 * cmds.c (internal_self_insert): Rename local to avoid shadowing.
7368
7082eac6
PE
7369 * lisp.h (GCPRO2_VAR, GCPRO3_VAR, GCPRO4_VAR, GCPRO5_VAR, GCPRO6_VAR):
7370 New macros, so that the caller can use some names other than
7371 gcpro1, gcpro2, etc.
7372 (GCPRO2, GCPRO3, GCPRO4, GCPRO5, GCPRO6): Reimplement in terms
7373 of the new macros.
7374 (GCPRO1_VAR, UNGCPRO_VAR): Change the meaning of the second
7375 argument, for consistency with GCPRO2_VAR, etc: it is now the
7376 prefix of the variable, not the variable itself. All uses
7377 changed.
38b2c076
PE
7378 * dired.c (directory_files_internal, file_name_completion):
7379 Rename locals to avoid shadowing.
7380
15206ed9
PE
7381 Fix a race condition diagnosed by gcc -Wsequence-point (Bug#8254).
7382 An expression of the form (DOWNCASE (x) == DOWNCASE (y)), found in
7383 dired.c's scmp function, had undefined behavior.
7384 * lisp.h (DOWNCASE_TABLE, UPCASE_TABLE, DOWNCASE, UPPERCASEP):
7385 (NOCASEP, LOWERCASEP, UPCASE, UPCASE1): Move from here ...
7386 * buffer.h: ... to here, because these macros use current_buffer,
7387 and the new implementation with inline functions needs to have
7388 current_buffer in scope now, rather than later when the macros
7389 are used.
7390 (downcase, upcase1): New static inline functions.
7391 (DOWNCASE, UPCASE1): Reimplement using these functions.
7392 This avoids undefined behavior in expressions like
7393 DOWNCASE (x) == DOWNCASE (y), which previously suffered
7394 from race conditions in accessing the global variables
7395 case_temp1 and case_temp2.
7396 * casetab.c (case_temp1, case_temp2): Remove; no longer needed.
7397 * lisp.h (case_temp1, case_temp2): Remove their decls.
7398 * character.h (ASCII_CHAR_P): Move from here ...
7399 * lisp.h: ... to here, so that the inline functions mentioned
7400 above can use them.
7401
4a6bea26
PE
7402 * dired.c (directory_files_internal_unwind): Now static.
7403
f14b7e14
PE
7404 * fileio.c (file_name_as_directory, directory_file_name):
7405 (barf_or_query_if_file_exists, auto_save_error, auto_save_1):
7406 Now static.
2893f146
PE
7407 (file_name_as_directory): Use const pointers when appropriate.
7408 (Fexpand_file_name): Likewise. In particular, newdir might
7409 point at constant storage, so make it a const pointer.
fd4ead52 7410 (Fmake_directory_internal, Fread_file_name): Remove unused vars.
b14aac08
PE
7411 (Ffile_selinux_context, Fset_file_selinux_context): Fix pointer
7412 signedness issues.
f839df0c
PE
7413 (Fset_file_times, Finsert_file_contents, auto_save_error):
7414 Rename locals to avoid shadowing.
f14b7e14 7415
5716756e 7416 * minibuf.c (choose_minibuf_frame_1): Now static.
62137a95
PE
7417 (Ftry_completion, Fall_completions): Rename or remove locals
7418 to avoid shadowing.
5716756e 7419
b4c3046a
PE
7420 * marker.c (bytepos_to_charpos): Remove; unused.
7421
b45db522
PE
7422 * lisp.h (verify_bytepos, count_markers): New decls,
7423 so that gcc does not warn that these functions aren't declared.
7424
85876d07
PE
7425 * insdel.c (check_markers, make_gap_larger, make_gap_smaller):
7426 (reset_var_on_error, Fcombine_after_change_execute_1): Now static.
f0cb4a60 7427 (CHECK_MARKERS): Redo to avoid gcc -Wempty-body diagnostic.
40ef059e 7428 (copy_text): Remove unused local var.
85876d07 7429
03d78a21 7430 * filelock.c (within_one_second): Now static.
b3dd38ab 7431 (lock_file_1): Rename local to avoid shadowing.
03d78a21 7432
5df8f01b
PE
7433 * buffer.c (fix_overlays_before): Mark locals as initialized.
7434 (fix_start_end_in_overlays): Likewise. This function should be
7435 simplified by using pointers-to-pointers, but that's a different
7436 matter.
b1d876f1 7437 (switch_to_buffer_1): Now static.
8f54f30a
PE
7438 (Fkill_buffer, record_buffer, Fbury_buffer, Fset_buffer_multibyte):
7439 (report_overlay_modification): Rename locals to avoid shadowing.
c3bd59b5 7440
a70072c9 7441 * sysdep.c (system_process_attributes): Rename vars to avoid shadowing.
fbd02d7b 7442 Fix pointer signedness issue.
edced198
PE
7443 (sys_subshell): Mark local as volatile if checking for lint,
7444 to suppress a gcc -Wclobbered warning that does not seem to be right.
15dfd3d9 7445 (MAXPATHLEN): Define only if needed.
a70072c9 7446
a0977c44
PE
7447 * process.c (serial_open, serial_configure): Move decls from here ...
7448 * systty.h: ... to here, so that they can be checked.
7449
a884fdcc
PE
7450 * fns.c (get_random, seed_random): Move extern decls from here ...
7451 * lisp.h: ... to here, so that they can be checked.
7452
604efe86 7453 * sysdep.c (reset_io): Now static.
b8950c94 7454 (wait_for_termination_signal): Remove; unused.
604efe86 7455
38fc62d9
PE
7456 * keymap.c (keymap_parent, keymap_memberp, map_keymap_internal):
7457 (copy_keymap_item, append_key, push_text_char_description):
7458 Now static.
1004a21a 7459 (Fwhere_is_internal): Don't test CONSP (sequences) unnecessarily.
dbbb8427 7460 (DENSE_TABLE_SIZE): Remove; unused.
c1141155
PE
7461 (get_keymap, access_keymap, Fdefine_key, Fwhere_is_internal):
7462 (describe_map_tree):
7463 Rename locals to avoid shadowing.
38fc62d9 7464
2f2650da
PE
7465 * keyboard.c: Declare functions static if they are not used elsewhere.
7466 (echo_char, echo_dash, cmd_error, top_level_2):
7467 (poll_for_input, handle_async_input): Now static.
69a058fa
PE
7468 (read_char, kbd_buffer_get_event, make_lispy_position):
7469 (make_lispy_event, make_lispy_movement, apply_modifiers):
7470 (decode_keyboard_code, tty_read_avail_input, menu_bar_items):
7471 (parse_tool_bar_item, read_key_sequence, Fread_key_sequence):
7472 (Fread_key_sequence_vector): Rename locals to avoid shadowing.
c8a06054 7473 (read_key_sequence, read_char): Mark locals as initialized.
3ac94672 7474 (Fexit_recursive_edit, Fabort_recursive_edit): Mark with NO_RETURN.
2f2650da 7475
a053e86c 7476 * keyboard.h (make_ctrl_char): New decl.
da2f2dd9
PE
7477 (mark_kboards): Move decl here ...
7478 * alloc.c (mark_kboards): ... from here.
a053e86c 7479
4752793e
PE
7480 * lisp.h (force_auto_save_soon): New decl.
7481
74f10ca7 7482 * emacs.c (init_cmdargs): Rename local to avoid shadowing.
244fc23d
PE
7483 (DEFINE_DUMMY_FUNCTION): New macro.
7484 (__do_global_ctors, __do_global_ctors_aux, __do_global_dtors, __main):
7485 Use it.
c03cd23f
PE
7486 (main): Add casts to avoid warnings
7487 if GCC considers string literals to be constants.
74f10ca7 7488
022e70d4
PE
7489 * lisp.h (fatal_error_signal): Add decl, since it's exported.
7490
59d6fe83
PE
7491 * dbusbind.c: Pointer signedness fixes.
7492 (xd_signature, xd_append_arg, xd_initialize):
7493 (Fdbus_call_method, Fdbus_call_method_asynchronously):
7494 (Fdbus_method_return_internal, Fdbus_method_error_internal):
7495 (Fdbus_send_signal, xd_read_message_1, Fdbus_register_service):
7496 (Fdbus_register_signal): Use SSDATA when the context wants char *.
7497
78320123
PE
7498 * dbusbind.c (Fdbus_init_bus): Add cast to avoid warning
7499 if GCC considers string literals to be constants.
49cebcca 7500 (Fdbus_register_service, Fdbus_register_method): Remove unused vars.
78320123 7501
35ac2a97
SM
75022011-03-16 Stefan Monnier <monnier@iro.umontreal.ca>
7503
fb103ca9
SM
7504 * print.c (PRINT_CIRCLE_CANDIDATE_P): New macro.
7505 (print_preprocess, print_object): New macro to fix last change.
7506
35ac2a97
SM
7507 * print.c (print_preprocess): Don't forget font objects.
7508
62973b41
JB
75092011-03-16 Juanma Barranquero <lekktu@gmail.com>
7510
7511 * emacs.c (USAGE3): Doc fixes.
7512
0e48bb22
AS
75132011-03-15 Andreas Schwab <schwab@linux-m68k.org>
7514
7515 * coding.c (detect_coding_iso_2022): Reorganize code to clarify
7516 structure.
7517
7684e57b
JB
75182011-03-14 Juanma Barranquero <lekktu@gmail.com>
7519
7520 * lisp.h (VWindow_system, Qfile_name_history):
7521 * keyboard.h (lispy_function_keys) [WINDOWSNT]:
7522 * w32term.h (w32_system_caret_hwnd, w32_system_caret_height)
7523 (w32_system_caret_x, w32_system_caret_y): Declare extern.
7524
7525 * w32select.c: Don't #include "keyboard.h".
c96bbc66 7526 (run_protected): Add extern declaration for waiting_for_input.
7684e57b
JB
7527
7528 * w32.c (Qlocal, noninteractive1, inhibit_window_system):
7529 * w32console.c (detect_input_pending, read_input_pending)
7530 (encode_terminal_code):
7531 * w32fns.c (quit_char, lispy_function_keys, Qtooltip)
7532 (w32_system_caret_hwnd, w32_system_caret_height, w32_system_caret_x)
7533 (w32_system_caret_y, Qfile_name_history):
7534 * w32font.c (w32font_driver, QCantialias, QCotf, QClang):
7535 * w32inevt.c (reinvoke_input_signal, lispy_function_keys):
7536 * w32menu.c (Qmenu_bar, QCtoggle, QCradio, Qoverriding_local_map)
7537 (Qoverriding_terminal_local_map, Qmenu_bar_update_hook):
7538 * w32proc.c (Qlocal, report_file_error):
7539 * w32term.c (Vwindow_system, updating_frame):
7540 * w32uniscribe.c (initialized, uniscribe_font_driver):
7541 Remove unneeded extern declarations.
7542
2aa46d6c
CY
75432011-03-14 Chong Yidong <cyd@stupidchicken.com>
7544
c96bbc66 7545 * buffer.c (Fmake_indirect_buffer): Fix incorrect assertions.
2aa46d6c 7546
cffc6f3b
CY
75472011-03-13 Chong Yidong <cyd@stupidchicken.com>
7548
7549 * buffer.h (BUF_BEGV, BUF_BEGV_BYTE, BUF_ZV, BUF_ZV_BYTE, BUF_PT)
7550 (BUF_PT_BYTE): Rewrite to handle indirect buffers (Bug#8219).
7551 These macros can no longer be used for assignment.
7552
44f230aa
SM
7553 * buffer.c (Fget_buffer_create, Fmake_indirect_buffer):
7554 Assign struct members directly, instead of using BUF_BEGV etc.
cffc6f3b
CY
7555 (record_buffer_markers, fetch_buffer_markers): New functions for
7556 recording and fetching special buffer markers.
7557 (set_buffer_internal_1, set_buffer_temp): Use them.
7558
7559 * lread.c (unreadchar): Use SET_BUF_PT_BOTH.
7560
7561 * insdel.c (adjust_point): Use SET_BUF_PT_BOTH.
7562
7563 * intervals.c (temp_set_point_both): Use SET_BUF_PT_BOTH.
7564 (get_local_map): Use SET_BUF_BEGV_BOTH and SET_BUF_ZV_BOTH.
7565
7566 * xdisp.c (hscroll_window_tree):
7567 (reconsider_clip_changes): Use PT instead of BUF_PT.
7568
d251f04b
EZ
75692011-03-13 Eli Zaretskii <eliz@gnu.org>
7570
7571 * makefile.w32-in ($(BLD)/editfns.$(O)): Depend on
7572 $(EMACS_ROOT)/lib/intprops.h.
7573
f0c77cd1
PE
75742011-03-13 Paul Eggert <eggert@cs.ucla.edu>
7575
3eca4629
PE
7576 Fix more problems found by GCC 4.5.2's static checks.
7577
7c86ee98
PE
7578 * gtkutil.c (xg_get_pixbuf_from_pixmap): Add cast from char *
7579 to unsigned char * to avoid compiler diagnostic.
b0afc268
PE
7580 (xg_free_frame_widgets): Make it clear that a local variable is
7581 needed only if USE_GTK_TOOLTIP.
01e0b5ad
PE
7582 (gdk_window_get_screen): Make it clear that this macro is needed
7583 only if USE_GTK_TOOLTIP.
1e5524e7
PE
7584 (int_gtk_range_get_value): New function, which avoids a diagnostic
7585 from gcc -Wbad-function-cast.
7586 (xg_set_toolkit_scroll_bar_thumb): Use it.
7587 (xg_tool_bar_callback, xg_tool_item_stale_p): Rewrite to avoid
7588 diagnostic from gcc -Wbad-function-cast.
65dc836c
PE
7589 (get_utf8_string, xg_get_file_with_chooser):
7590 Rename locals to avoid shadowing.
7591 (create_dialog): Move locals to avoid shadowing.
7c86ee98 7592
41729b81
PE
7593 * xgselect.c (xg_select): Remove unused var.
7594
f0c77cd1
PE
7595 * image.c (four_corners_best): Mark locals as initialized.
7596 (gif_load): Initialize transparent_p to zero (Bug#8238).
7597 Mark another local as initialized.
ec6cf4c6 7598 (my_png_error, my_error_exit): Mark with NO_RETURN.
f0c77cd1 7599
ce0ad53d 7600 * image.c (clear_image_cache): Now static.
d5d5a617 7601 (DIM, HAVE_STDLIB_H_1): Remove unused macros.
e22cffbc 7602 (xpm_load): Redo to avoid "discards qualifiers" gcc warning.
77a765fd
PE
7603 (x_edge_detection): Remove unnecessary cast that
7604 gcc -Wbad-function-cast diagnoses.
2037898d 7605 (gif_load): Fix pointer signedness.
6ae141d6
PE
7606 (clear_image_cache, xbm_read_bitmap_data, x_detect_edges):
7607 (jpeg_load, gif_load): Rename locals to avoid shadowing.
ce0ad53d 7608
33383987 76092011-03-12 Paul Eggert <eggert@cs.ucla.edu>
3eca4629 7610
d32df629
PE
7611 Improve quality of tests for time stamp overflow.
7612 For example, without this patch (encode-time 0 0 0 1 1
7613 1152921504606846976) returns the obviously-bogus value (-948597
7614 62170) on my RHEL 5.5 x86-64 host. With the patch, it correctly
7615 reports time overflow. See
7616 <http://lists.gnu.org/archive/html/emacs-devel/2011-03/msg00470.html>.
b8d9bd41
PE
7617 * deps.mk (editfns.o): Depend on ../lib/intprops.h.
7618 * editfns.c: Include limits.h and intprops.h.
7619 (TIME_T_MIN, TIME_T_MAX): New macros.
7620 (time_overflow): Move earlier, to before first use.
7621 (hi_time, lo_time): New functions, for an accurate test for
7622 out-of-range times.
7623 (Fcurrent_time, Fget_internal_run_time, make_time): Use them.
7624 (Fget_internal_run_time): Don't assume time_t fits in int.
7625 (make_time): Use list2 instead of Fcons twice.
7626 (Fdecode_time): More accurate test for out-of-range times.
7627 (check_tm_member): New function.
7628 (Fencode_time): Use it, to test for out-of-range times.
d32df629
PE
7629 (lisp_time_argument): Don't rely on undefined left-shift and
7630 right-shift behavior when checking for time stamp overflow.
8be6f318 7631
fe31d94c
PE
7632 * editfns.c (time_overflow): New function, refactoring common code.
7633 (Fformat_time_string, Fdecode_time, Fencode_time):
7634 (Fcurrent_time_string): Use it.
7635
8be6f318
PE
7636 Move 'make_time' to be next to its inverse 'lisp_time_argument'.
7637 * dired.c (make_time): Move to ...
7638 * editfns.c (make_time): ... here.
7639 * systime.h: Note the move.
7640
09d9db2c 76412011-03-12 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
c47cbdfd 7642
126bc0dc
YM
7643 * fringe.c (update_window_fringes): Remove unused variables.
7644
c47cbdfd
YM
7645 * unexmacosx.c (copy_data_segment): Also copy __got section.
7646 (Bug#8223)
7647
7ac80be9
EZ
76482011-03-12 Eli Zaretskii <eliz@gnu.org>
7649
c96bbc66 7650 * termcap.c [MSDOS]: Include "msdos.h".
058e5dad
EZ
7651 (find_capability, tgetnum, tgetflag, tgetstr, tputs, tgetent):
7652 Constify `char *' arguments and their references according to
7653 prototypes in tparam.h.
7654
ecb0f94d 7655 * deps.mk (termcap.o): Depend on tparam.h and msdos.h.
058e5dad 7656
7ac80be9
EZ
7657 * msdos.c (XMenuAddPane): 3rd argument is `const char *' now.
7658 Adapt all references accordingly.
7659
7660 * msdos.h (XMenuAddPane): 3rd argument is `const char *' now.
7661
ef1fd07e
TT
76622011-03-11 Tom Tromey <tromey@redhat.com>
7663
7664 * buffer.c (syms_of_buffer): Remove obsolete comment.
7665
7ef4b50c
EZ
76662011-03-11 Eli Zaretskii <eliz@gnu.org>
7667
7668 * termhooks.h (encode_terminal_code): Declare prototype.
7669
7670 * msdos.c (encode_terminal_code): Don't declare prototype.
7671
7672 * term.c (encode_terminal_code): Now external again, used by
7673 w32console.c and msdos.c.
7674
44f230aa
SM
7675 * makefile.w32-in ($(BLD)/term.$(O), ($(BLD)/tparam.$(O)):
7676 Depend on $(SRC)/tparam.h, see 2011-03-11T07:24:21Z!eggert@cs.ucla.edu.
7ef4b50c 7677
4b1ec863 76782011-03-11 Paul Eggert <eggert@cs.ucla.edu>
f78faa98 7679
1714f52b 7680 Fix some minor problems found by GCC 4.5.2's static checks.
83316bf4 7681
4b1ec863
PE
7682 * fringe.c (update_window_fringes): Mark locals as initialized
7683 (Bug#8227).
7684 (destroy_fringe_bitmap, init_fringe_bitmap): Now static.
bf60f616 7685
524c7aa6
PE
7686 * alloc.c (mark_fringe_data): Move decl from here ...
7687 * lisp.h (mark_fringe_data) [HAVE_WINDOW_SYSTEM]: ... to here,
7688 to check its interface.
7689 (init_fringe_once): Do not declare unless HAVE_WINDOW_SYSTEM.
7690
a5c0af81 7691 * fontset.c (free_realized_fontset): Now static.
7519b8cd 7692 (Fset_fontset_font): Rename local to avoid shadowing.
cc6e5db1 7693 (fontset_font): Mark local as initialized.
a9a06e0b 7694 (FONTSET_SPEC, FONTSET_REPERTORY, RFONT_DEF_REPERTORY): Remove; unused.
a5c0af81 7695
b4716021
PE
7696 * xrdb.c: Include "xterm.h", to check x_load_resources's interface.
7697
811e9bac 7698 * xselect.c (x_disown_buffer_selections): Remove; not used.
7b83e2f1 7699 (TRACE3) [!defined TRACE_SELECTION]: Remove; not used.
aa0daa9f
PE
7700 (x_own_selection, Fx_disown_selection_internal): Rename locals
7701 to avoid shadowing.
7702 (x_handle_dnd_message): Remove local to avoid shadowing.
811e9bac 7703
7e3ab302
PE
7704 * lisp.h (GCPRO1_VAR, UNGCPRO_VAR): New macros,
7705 so that the caller can use some name other than gcpro1.
7706 (GCPRO1, UNGCPRO): Reimplement in terms of the new macros.
58d2d479
PE
7707 * xfns.c (Fx_create_frame, x_create_tip_frame, Fx_show_tip):
7708 (Fx_backspace_delete_keys_p):
7709 Use them to avoid shadowing, and rename vars to avoid shadowing.
7710 (x_decode_color, x_set_name, x_window): Now static.
6b437900 7711 (Fx_create_frame): Add braces to silence GCC warning.
c0951e53 7712 (Fx_file_dialog, Fx_select_font): Fix pointer signedness.
06b0c8a0
PE
7713 (x_real_positions, xg_set_icon_from_xpm_data, x_create_tip_frame):
7714 Remove unused locals.
7e3ab302
PE
7715 (Fx_create_frame, x_create_tip_frame, Fx_show_tip):
7716 (Fx_backspace_delete_keys_p): Rename locals to avoid shadowing.
7717 Some of these renamings use the new GCPRO1_VAR and UNGCPRO_VAR
7718 macros.
f78faa98 7719
e2b13473
PE
7720 * xterm.h (x_mouse_leave): New decl.
7721
77f23912
PE
7722 * xterm.c (x_copy_dpy_color, x_focus_on_frame, x_unfocus_frame):
7723 Remove unused functions.
cdf4ba58
PE
7724 (x_shift_glyphs_for_insert, XTflash, XTring_bell):
7725 (x_calc_absolute_position): Now static.
7411c686 7726 (XTread_socket): Don't define label "out" unless it's used.
2b07bcff 7727 Don't declare local "event" unless it's used.
ed7bf3a5
PE
7728 (x_iconify_frame, x_free_frame_resources): Don't declare locals
7729 unless they are used.
38d0b34a
PE
7730 (XEMBED_VERSION, xembed_set_info): Don't define unless needed.
7731 (x_fatal_error_signal): Remove; not used.
a6067996
PE
7732 (x_draw_image_foreground, redo_mouse_highlight, XTmouse_position):
7733 (x_scroll_bar_report_motion, handle_one_xevent, x_draw_bar_cursor):
7734 (x_error_catcher, x_connection_closed, x_error_handler):
7735 (x_error_quitter, xembed_send_message, x_iconify_frame):
7736 (my_log_handler): Rename locals to avoid shadowing.
28f1c698 7737 (x_delete_glyphs, x_ins_del_lines): Mark with NO_RETURN.
2a8fade0 7738 (x_connection_closed): Tell GCC not to suggest NO_RETURN.
77f23912 7739
44f230aa
SM
7740 * xfaces.c (clear_face_cache, Fx_list_fonts, Fface_font):
7741 Rename or move locals to avoid shadowing.
6b463e58 7742 (tty_defined_color, merge_face_heights): Now static.
5967d051 7743 (free_realized_faces_for_fontset): Remove; not used.
1e9966ea
PE
7744 (Fx_list_fonts): Mark variable that gcc -Wuninitialized
7745 does not deduce is never used uninitialized.
73719eba
PE
7746 (STRDUPA, LSTRDUPA, FONT_POINT_SIZE_QUANTUM): Remove; not used.
7747 (LFACEP): Define only if XASSERTS, as it's not needed otherwise.
071048a3 7748
426994c3 7749 * terminal.c (store_terminal_param): Now static.
5489860b 7750
032f1620 7751 * xmenu.c (menu_highlight_callback): Now static.
9d66f88e 7752 (set_frame_menubar): Remove unused local.
d4323972 7753 (xmenu_show): Rename parameter to avoid shadowing.
6d1f7fee
PE
7754 (xmenu_show, xdialog_show, xmenu_show): Make local pointers "const"
7755 since they might point to immutable storage.
281585b0
PE
7756 (next_menubar_widget_id): Declare only if USE_X_TOOLKIT,
7757 since it's unused otherwise.
032f1620 7758
367c19e5 7759 * xdisp.c (produce_glyphless_glyph): Initialize lower_xoff.
53df7c11 7760 Add a FIXME, since the code still doesn't look right. (Bug#8215)
9f36b9fd
PE
7761 (Fcurrent_bidi_paragraph_direction): Simplify slightly; this
7762 avoids a gcc -Wuninitialized diagnostic.
0e086e8f 7763 (display_line, BUILD_COMPOSITE_GLYPH_STRING, draw_glyphs):
44a3a108
PE
7764 (note_mouse_highlight): Mark variables that gcc -Wuninitialized
7765 does not deduce are never used uninitialized.
70739cbe 7766
07b48fa9
PE
7767 * lisp.h (IF_LINT): New macro, copied from ../lib-src/emacsclient.c.
7768
8868a238 7769 * xdisp.c (redisplay_window): Rename local to avoid shadowing.
4554d213
PE
7770 * window.c (window_loop, size_window):
7771 (run_window_configuration_change_hook, enlarge_window): Likewise.
8868a238 7772
7e5cf297 7773 * window.c (display_buffer): Now static.
d6550a9f
PE
7774 (size_window): Mark variables that gcc -Wuninitialized
7775 does not deduce are never used uninitialized.
a586633d
PE
7776 * window.h (check_all_windows): New decl, to forestall
7777 gcc -Wmissing-prototypes diagnostic.
5b555da1 7778 * dispextern.h (bidi_dump_cached_states): Likewise.
7e5cf297 7779
f6095868
PE
7780 * charset.h (CHECK_CHARSET_GET_CHARSET): Rename locals to avoid
7781 shadowing.
7782 * charset.c (map_charset_for_dump, Fchar_charset): Likewise.
726929c4
PE
7783 Include <limits.h>.
7784 (Fsort_charsets): Redo min/max calculation to shorten the code a bit
7785 and to avoid gcc -Wuninitialized warning.
89ef49df
PE
7786 (load_charset_map): Mark variables that gcc -Wuninitialized
7787 does not deduce are never used uninitialized.
53df7c11 7788 (load_charset): Abort instead of using uninitialized var (Bug#8229).
f6095868 7789
f38b440c
PE
7790 * coding.c (coding_set_source, coding_set_destination):
7791 Use "else { /* comment */ }" rather than "else /* comment */;"
7792 for clarity, and to avoid gcc -Wempty-body warning.
2735d060
PE
7793 (Fdefine_coding_system_internal): Don't redeclare 'i' inside
7794 a block, when the outer 'i' will do.
7795 (decode_coding_utf_8, decode_coding_utf_16, detect_coding_emacs_mule):
7796 (emacs_mule_char, decode_coding_emacs_mule, detect_coding_iso_2022):
7797 (decode_coding_iso_2022, decode_coding_sjis, decode_coding_big5):
7798 (decode_coding_raw_text, decode_coding_charset, get_translation_table):
7799 (Fdecode_sjis_char, Fdefine_coding_system_internal):
7800 Rename locals to avoid shadowing.
7801 * character.h (FETCH_STRING_CHAR_ADVANCE): Likewise.
e2f1bab9
PE
7802 * coding.c (emacs_mule_char, encode_invocation_designation):
7803 Now static, since they're not used elsewhere.
413bb2db 7804 (decode_coding_iso_2022): Add "default: abort ();" as a safety check.
c4a63b12 7805 (decode_coding_object, encode_coding_object, detect_coding_system):
ee05f961
PE
7806 (decode_coding_emacs_mule): Mark variables that gcc
7807 -Wuninitialized does not deduce are never used uninitialized.
160b01f6
PE
7808 (detect_coding_iso_2022): Initialize a local variable that might
7809 be used uninitialized. Leave a FIXME because it's not clear that
53df7c11 7810 this initialization is needed. (Bug#8211)
5f58e762
PE
7811 (ISO_CODE_LF, ISO_CODE_CR, CODING_ISO_FLAG_EUC_TW_SHIFT):
7812 (ONE_MORE_BYTE_NO_CHECK, UTF_BOM, UTF_16_INVALID_P):
7813 (SHIFT_OUT_OK, ENCODE_CONTROL_SEQUENCE_INTRODUCER):
7814 (ENCODE_DIRECTION_R2L, ENCODE_DIRECTION_L2R):
7815 Remove unused macros.
f38b440c 7816
232b38b9 7817 * category.c (hash_get_category_set): Remove unused local var.
9f3b5e69 7818 (copy_category_table): Now static, since it's not used elsewhere.
d0891610 7819 * character.c (string_count_byte8): Likewise.
232b38b9 7820
fb90da1b
PE
7821 * ccl.c (CCL_WRITE_STRING, CCL_ENCODE_CHAR, Fccl_execute_on_string):
7822 (Fregister_code_conversion_map): Rename locals to avoid shadowing.
7823
fb93dbc2
PE
7824 * chartab.c (copy_sub_char_table): Now static, since it's not used
7825 elsewhere.
5c156ace
PE
7826 (sub_char_table_ref_and_range, char_table_ref_and_range):
7827 Rename locals to avoid shadowing.
bbcd0949 7828 (ASET_RANGE, GET_SUB_CHAR_TABLE): Remove unused macros.
fb93dbc2 7829
7d3b3862 7830 * bidi.c (bidi_check_type): Now static, since it's not used elsewhere.
630d6892 7831 (BIDI_BOB): Remove unused macro.
7d3b3862 7832
6be7d3da
PE
7833 * cm.c (cmgoto): Mark variables that gcc -Wuninitialized does not
7834 deduce are never used uninitialized.
c2ed9c8b 7835 * term.c (encode_terminal_code): Likewise.
6be7d3da 7836
75f8807f 7837 * term.c (encode_terminal_code): Now static. Remove unused local.
72abad34 7838
50938595
PE
7839 * tparam.h: New file.
7840 * term.c, tparam.h: Include it.
7841 * deps.mk (term.o, tparam.o): Depend on tparam.h.
7842 * term.c (tputs, tgetent, tgetflag, tgetnum, tparam, tgetstr):
7843 Move these decls to tparam.h, and make them agree with what
7844 is actually in tparam.c. The previous trick of using incompatible
7845 decls in different modules does not conform to the C standard.
7846 All callers of tparam changed to use tparam's actual API.
7847 * tparam.c (tparam1, tparam, tgoto):
7848 Use const pointers where appropriate.
7849
fbceeba2
PE
7850 * cm.c (calccost, cmgoto): Use const pointers where appropriate.
7851 * cm.h (struct cm): Likewise.
7852 * dispextern.h (do_line_insertion_deletion_costs): Likewise.
7853 * scroll.c (ins_del_costs, do_line_insertion_deletion_costs): Likewise.
7854 * term.c (tty_ins_del_lines, calculate_costs, struct fkey_table):
7855 (term_get_fkeys_1, append_glyphless_glyph, produce_glyphless_glyph):
7856 (turn_on_face, init_tty): Likewise.
7857 * termchar.h (struct tty_display_info): Likewise.
fbceeba2 7858
7f3f1250
PE
7859 * term.c (term_mouse_position): Rename local to avoid shadowing.
7860
e6ca6543
PE
7861 * alloc.c (mark_ttys): Move decl from here ...
7862 * lisp.h (mark_ttys): ... to here, so that it's checked against defn.
7863
c40f8d15
AS
78642011-03-11 Andreas Schwab <schwab@linux-m68k.org>
7865
7866 * .gdbinit (pwinx, xbuffer): Fix access to buffer name.
7867
cfe0661d
JB
78682011-03-09 Juanma Barranquero <lekktu@gmail.com>
7869
7870 * search.c (compile_pattern_1): Remove argument regp, unused since
7871 revid:rms@gnu.org-19941211082627-3x1g1wyqkjmwloig.
7872 (compile_pattern): Don't pass it.
7873
0afb4571
J
78742011-03-08 Jan Djärv <jan.h.d@swipnet.se>
7875
7876 * xterm.h (DEFAULT_GDK_DISPLAY): New define.
7877 (GDK_WINDOW_XID, gtk_widget_get_preferred_size): New defines
7878 for ! HAVE_GTK3.
7879 (GTK_WIDGET_TO_X_WIN): Use GDK_WINDOW_XID.
7880
7881 * xmenu.c (menu_position_func): Call gtk_widget_get_preferred_size.
7882
7883 * gtkutil.c: Include gtkx.h if HAVE_GTK3. If ! HAVE_GTK3, define
7884 gdk_window_get_screen, gdk_window_get_geometry,
7885 gdk_x11_window_lookup_for_display and GDK_KEY_g.
7886 (xg_set_screen): Use DEFAULT_GDK_DISPLAY.
7887 (xg_get_pixbuf_from_pixmap): New function.
7888 (xg_get_pixbuf_from_pix_and_mask): Change parameters from GdkPixmap
7889 to Pixmap, take frame as parameter, remove GdkColormap parameter.
7890 Call xg_get_pixbuf_from_pixmap instead of
7891 gdk_pixbuf_get_from_drawable.
7892 (xg_get_image_for_pixmap): Do not make GdkPixmaps, call
7893 xg_get_pixbuf_from_pix_and_mask with Pixmap parameters instead.
7894 (xg_check_special_colors): Use GtkStyleContext and its functions
7895 for HAVE_GTK3.
7896 (xg_prepare_tooltip, xg_hide_tooltip): Call gdk_window_get_screen.
7897 (xg_prepare_tooltip, create_dialog, menubar_map_cb)
7898 (xg_update_frame_menubar, xg_tool_bar_detach_callback)
44f230aa
SM
7899 (xg_tool_bar_attach_callback, xg_update_tool_bar_sizes):
7900 Call gtk_widget_get_preferred_size.
0afb4571
J
7901 (xg_frame_resized): gdk_window_get_geometry only takes 5
7902 parameters.
44f230aa
SM
7903 (xg_win_to_widget, xg_event_is_for_menubar):
7904 Call gdk_x11_window_lookup_for_display.
0afb4571
J
7905 (xg_set_widget_bg): New function.
7906 (delete_cb): New function.
895009e1 7907 (xg_create_frame_widgets): Connect delete-event to delete_cb.
0afb4571
J
7908 Call xg_set_widget_bg. Only set backgrund pixmap for ! HAVE_GTK3
7909 (xg_set_background_color): Call xg_set_widget_bg.
7910 (xg_set_frame_icon): Call xg_get_pixbuf_from_pix_and_mask.
7911 (xg_create_scroll_bar): vadj is a GtkAdjustment for HAVE_GTK3.
7912 Only call gtk_range_set_update_policy if ! HAVE_GTK3.
7913 (xg_make_tool_item): Only connect xg_tool_bar_item_expose_callback
7914 if ! HAVE_GTK3.
7915 (update_frame_tool_bar): Call gtk_widget_hide.
7916 (xg_initialize): Use GDK_KEY_g.
7917
7918 * xsmfns.c (gdk_set_sm_client_id): Define to gdk_set_sm_client_id
7919 if ! HAVE_GTK3
7920 (x_session_initialize): Call gdk_x11_set_sm_client_id.
7921
7922 * xterm.c (XFillRectangle): Use cairo routines for HAVE_GTK3.
7923 (x_term_init): Disable Xinput(2) with GDK_CORE_DEVICE_EVENTS.
7924 Load ~/emacs.d/gtkrc only for ! HAVE_GTK3.
7925
1c2cc4ef
JB
79262011-03-08 Juanma Barranquero <lekktu@gmail.com>
7927
7928 * w32xfns.c (select_palette): Check success of RealizePalette against
7929 GDI_ERROR, not zero.
7930
33383987 7931See ChangeLog.11 for earlier changes.
aac0c6e3
MR
7932
7933;; Local Variables:
7934;; coding: utf-8
aac0c6e3
MR
7935;; End:
7936
33383987 7937 Copyright (C) 2011 Free Software Foundation, Inc.
aac0c6e3
MR
7938
7939 This file is part of GNU Emacs.
7940
7941 GNU Emacs is free software: you can redistribute it and/or modify
7942 it under the terms of the GNU General Public License as published by
7943 the Free Software Foundation, either version 3 of the License, or
7944 (at your option) any later version.
7945
7946 GNU Emacs is distributed in the hope that it will be useful,
7947 but WITHOUT ANY WARRANTY; without even the implied warranty of
7948 MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
7949 GNU General Public License for more details.
7950
7951 You should have received a copy of the GNU General Public License
7952 along with GNU Emacs. If not, see <http://www.gnu.org/licenses/>.