* lisp.h (LIST_END_P): Remove unused macro and its bogus comment.
[bpt/emacs.git] / src / ChangeLog
CommitLineData
eb49b136
PE
12011-06-19 Paul Eggert <eggert@cs.ucla.edu>
2
3 * lisp.h (DEFUN): Remove bogus use of sizeof (struct Lisp_Subr).
4 This didn't break anything, but it didn't help either.
5 It's confusing to put a bogus integer in a place where the actual
6 value does not matter.
9f62aeb1 7 (LIST_END_P): Remove unused macro and its bogus comment.
eb49b136 8
e39e811e
PE
92011-06-18 Paul Eggert <eggert@cs.ucla.edu>
10
15375a22
PE
11 * lisp.h (union Lisp_Object.i): EMACS_INT, not EMACS_UINT.
12 This is for consistency with the ordinary, non-USE_LISP_UNION_TYPE,
13 implementation.
b61cc01c
PE
14 (struct Lisp_Bool_Vector.size): EMACS_INT, not EMACS_UINT.
15 We prefer signed types, and the value cannot exceed the EMACS_INT
16 range anyway (because otherwise the length would not be representable).
9a8e8d9b
PE
17 (XSET) [USE_LISP_UNION_TYPE]: Use uintptr_t and intptr_t,
18 not EMACS_UINT and EMACS_INT, when converting pointer to integer.
19 This avoids a GCC warning when WIDE_EMACS_INT.
15375a22 20
53b2623d
PE
21 * indent.c (sane_tab_width): New function.
22 (current_column, scan_for_column, Findent_to, position_indentation)
23 (compute_motion): Use it. This is just for clarity.
8fcaf9cc 24 (Fcompute_motion): Don't assume hscroll and tab offset fit in int.
53b2623d 25
45aebb64
PE
26 * image.c (xbm_image_p): Don't assume stated width and height fit in int.
27
f2ed8a70
PE
28 * lisp.h (lint_assume): New macro.
29 * composite.c (composition_gstring_put_cache):
30 * ftfont.c (ftfont_shape_by_flt): Use it to pacify GCC 4.6.0.
31
abe80cc6
PE
32 * editfns.c, insdel.c:
33 Omit unnecessary forward decls, to simplify future changes.
a9e860e1 34
b02c740e
PE
35 * ftfont.c (ftfont_shape_by_flt): Use signed integers for lengths.
36
ebc96716
PE
37 * font.c (Ffont_shape_gstring): Don't assume glyph len fits in 'int'.
38
b4e50fa0 39 * fns.c (Ffillarray): Don't assume bool vector size fits in 'int'.
f03dc6ef 40 Use much-faster test for byte-length change.
311d5d7c 41 Don't assume string byte-length fits in 'int'.
a4cf38e4 42 Check that character arg fits in 'int'.
85461888 43 (mapcar1): Declare byte as byte, for clarity.
b4e50fa0 44
c0c1ee9f
PE
45 * alloc.c (Fmake_bool_vector): Avoid unnecessary multiplication.
46
a498d7f4
PE
47 * fns.c (concat): Catch string overflow earlier.
48 Do not rely on integer wraparound.
49
e39e811e
PE
50 * dispextern.h (struct it.overlay_strings_charpos): EMACS_INT, not int.
51
fadf4e30
PE
522011-06-17 Paul Eggert <eggert@cs.ucla.edu>
53
87830974
PE
54 * dispextern.h (struct it.selective): Now EMACS_INT, not int.
55 * xdisp.c (forward_to_next_line_start)
56 (back_to_previous_visible_line_start)
57 (reseat_at_next_visible_line_start, next_element_from_buffer):
58 Don't arbitrarily truncate the value of 'selective' to int.
59
76031fad
PE
60 * xdisp.c (init_iterator): Use XINT, not XFASTINT; it might be < 0.
61
5eb55db9
PE
62 * composite.c: Don't truncate sizes to 'int'.
63 (composition_gstring_p, composition_reseat_it)
64 (composition_adjust_point): Use EMACS_INT, not int.
7d100a81
PE
65 (get_composition_id, composition_gstring_put_cache): Use EMACS_INT,
66 not EMACS_UINT, for indexes.
5eb55db9 67
0703a717
PE
68 * category.h (CATEGORY_SET_P): Remove unnecessary cast to EMACS_INT.
69
d6202519
PE
70 * buffer.c: Include <verify.h>.
71 (struct sortvec.priority, struct sortstr.priority):
8961a454 72 Now EMACS_INT, not int.
c20998a7 73 (compare_overlays, cmp_for_strings): Avoid subtraction overflow.
67c36fce
PE
74 (struct sortstr.size, record_overlay_string)
75 (struct sortstrlist.size, struct sortlist.used):
76 Don't truncate size to int.
77 (record_overlay_string): Check for size-calculation overflow.
d6202519 78 (init_buffer_once): Check at compile-time, not run-time.
fadf4e30 79
28177add
PE
802011-06-16 Paul Eggert <eggert@cs.ucla.edu>
81
dd3482fe
PE
82 * lisp.h: Include <limits.h>, for INT_MAX, LONG_MAX, LLONG_MAX.
83 Without this, prin1 mishandles Lisp_Misc_Save_Value printing on
84 hosts with pre-C99 libraries, because pD is wrongly defined to "t".
85
393d71f3 86 Improve buffer-overflow checking (Bug#8873).
1c8e352f
PE
87 * fileio.c (Finsert_file_contents):
88 * insdel.c (insert_from_buffer_1, replace_range, replace_range_2):
89 Remove the old (too-loose) buffer overflow checks.
90 They weren't needed, since make_gap checks for buffer overflow.
91 * insdel.c (make_gap_larger): Catch buffer overflows that were missed.
92 The old code merely checked for Emacs fixnum overflow, and relied
93 on undefined (wraparound) behavior. The new code avoids undefined
94 behavior, and also checks for ptrdiff_t and/or size_t overflow.
95
2e6813b0 96 * editfns.c (Finsert_char): Don't dump core with very negative counts.
21d890a4
PE
97 Tune. Don't use wider integers than needed. Don't use alloca.
98 Use a bigger 'string' buffer. Rewrite to avoid 'n > 0' test.
2e6813b0 99
599a9e4f
PE
100 * insdel.c (replace_range): Fix buf overflow when insbytes < outgoing.
101
99561444
PE
102 * insdel.c, lisp.h (buffer_overflow): New function.
103 (insert_from_buffer_1, replace_range, replace_range_2):
104 * insdel.c (make_gap_larger):
105 * editfns.c (Finsert_char):
106 * fileio.c (Finsert_file_contents): Use it, to normalize wording.
107
28177add
PE
108 * buffer.h (BUF_BYTES_MAX): Cast to ptrdiff_t so that it's signed.
109
e69dafad
PE
1102011-06-15 Paul Eggert <eggert@cs.ucla.edu>
111
a7af7fde 112 Integer overflow and signedness fixes (Bug#8873).
ff672d2c 113
b1c46f02
PE
114 * ccl.c (ASCENDING_ORDER): New macro, to work around GCC bug 43772.
115 (GET_CCL_RANGE, IN_INT_RANGE): Use it.
116
e69dafad
PE
117 * fileio.c: Don't assume EMACS_INT fits in off_t.
118 (emacs_lseek): New static function.
119 (Finsert_file_contents, Fwrite_region): Use it.
120 Use SEEK_SET, SEEK_CUR, SEEK_END as appropriate.
121
566684ea
PE
122 * fns.c (Fload_average): Don't assume 100 * load average fits in int.
123
e6966cd6
PE
124 * fns.c: Don't overflow int when computing a list length.
125 * fns.c (QUIT_COUNT_HEURISTIC): New constant.
126 (Flength, Fsafe_length): Use EMACS_INT, not int, to avoid unwanted
127 truncation on 64-bit hosts. Check for QUIT every
128 QUIT_COUNT_HEURISTIC entries rather than every other entry; that's
129 faster and is responsive enough.
130 (Flength): Report an error instead of overflowing an integer.
131 (Fsafe_length): Return a float if the value is not representable
132 as a fixnum. This shouldn't happen except in contrived situations.
6346d301 133 (Fnthcdr, Fsort): Don't assume list length fits in int.
de41a810 134 (Fcopy_sequence): Don't assume vector length fits in int.
00c604f2 135
dd0b0efb
PE
136 * alloc.c: Check that resized vectors' lengths fit in fixnums.
137 (header_size, word_size): New constants.
138 (allocate_vectorlike): Don't check size overflow here.
139 (allocate_vector): Check it here instead, since this is the only
140 caller of allocate_vectorlike that could cause overflow.
141 Check that the new vector's length is representable as a fixnum.
142
86fe5cfe
PE
143 * fns.c (next_almost_prime): Don't return a multiple of 3 or 5.
144 The previous code was bogus. For example, next_almost_prime (32)
145 returned 39, which is undesirable as it is a multiple of 3; and
146 next_almost_prime (24) returned 25, which is a multiple of 5 so
147 why was the code bothering to check for multiples of 7?
148
80e88859
PE
149 * bytecode.c (exec_byte_code): Use ptrdiff_t, not int, for vector length.
150
4a2f0ad6
PE
151 * eval.c, doprnt.c (SIZE_MAX): Remove; inttypes.h defines this now.
152
f66c7cf8
PE
153 Variadic C functions now count arguments with ptrdiff_t.
154 This partly undoes my 2011-03-30 change, which replaced int with size_t.
155 Back then I didn't know that the Emacs coding style prefers signed int.
156 Also, in the meantime I found a few more instances where arguments
4a2f0ad6
PE
157 were being counted with int, which may truncate counts on 64-bit
158 machines, or EMACS_INT, which may be unnecessarily wide.
f66c7cf8
PE
159 * lisp.h (struct Lisp_Subr.function.aMANY)
160 (DEFUN_ARGS_MANY, internal_condition_case_n, safe_call):
161 Arg counts are now ptrdiff_t, not size_t.
162 All variadic functions and their callers changed accordingly.
163 (struct gcpro.nvars): Now size_t, not size_t. All uses changed.
164 * bytecode.c (exec_byte_code): Check maxdepth for overflow,
165 to avoid potential buffer overrun. Don't assume arg counts fit in 'int'.
166 * callint.c (Fcall_interactively): Check arg count for overflow,
167 to avoid potential buffer overrun. Use signed char, not 'int',
168 for 'varies' array, so that we needn't bother to check its size
169 calculation for overflow.
170 * editfns.c (Fformat): Use ptrdiff_t, not EMACS_INT, to count args.
171 * eval.c (apply_lambda):
172 * fns.c (Fmapconcat): Use XFASTINT, not XINT, to get args length.
173 (struct textprop_rec.argnum): Now ptrdiff_t, not int. All uses changed.
174 (mapconcat): Use ptrdiff_t, not int and EMACS_INT, to count args.
175
a1759b76
PE
176 * callint.c (Fcall_interactively): Don't use index var as event count.
177
d96be9fc
PE
178 * vm-limit.c (check_memory_limits): Fix incorrect extern function decls.
179 * mem-limits.h (SIZE): Remove; no longer used.
180
a690a978 181 * xterm.c (x_alloc_nearest_color_1): Prefer int to long when int works.
5efd304b 182
578c21e6
PE
183 Remove unnecessary casts.
184 * xterm.c (x_term_init):
185 * xfns.c (x_set_border_pixel):
186 * widget.c (create_frame_gcs): Remove casts to unsigned long etc.
187 These aren't needed now that we assume ANSI C.
188
96f53c6c
PE
189 * sound.c (Fplay_sound_internal): Remove cast to unsigned long.
190 It's more likely to cause problems (due to unsigned overflow)
191 than to cure them.
192
83c77d31
PE
193 * dired.c (Ffile_attributes): Don't use 32-bit hack on 64-bit hosts.
194
ee2079f1
PE
195 * unexelf.c (unexec): Don't assume BSS addr fits in unsigned.
196
6da65536
PE
197 * xterm.c (handle_one_xevent): Omit unnecessary casts to unsigned.
198
7147c4a4
PE
199 * keyboard.c (modify_event_symbol): Don't limit alist len to UINT_MAX.
200
193e32d9
PE
201 * lisp.h (CHAR_TABLE_SET): Omit now-redundant test.
202
e5533da6
PE
203 * lread.c (Fload): Don't compare a possibly-garbage time_t value.
204
9910e595
PE
205 GLYPH_CODE_FACE returns EMACS_INT, not int.
206 * dispextern.h (merge_faces):
207 * xfaces.c (merge_faces):
01103c44
PE
208 * xdisp.c (get_next_display_element, next_element_from_display_vector):
209 Don't assume EMACS_INT fits in int.
9910e595 210
2638320e
PE
211 * character.h (CHAR_VALID_P): Remove unused parameter.
212 * fontset.c, lisp.h, xdisp.c: All uses changed.
213
045eb8d9
PE
214 * editfns.c (Ftranslate_region_internal): Omit redundant test.
215
c1f134b5
PE
216 * fns.c (concat): Minor tuning based on overflow analysis.
217 This doesn't fix any bugs. Use int to hold character, instead
218 of constantly refetching from Emacs object. Use XFASTINT, not
219 XINT, for value known to be a character. Don't bother comparing
220 a single byte to 0400, as it's always less.
221
395fcb93 222 * floatfns.c (Fexpt):
327eeec8
PE
223 * fileio.c (make_temp_name): Omit unnecessary cast to unsigned.
224
abbd3d23
PE
225 * editfns.c (Ftranslate_region_internal): Use int, not EMACS_INT
226 for characters.
227
684a03ef
PE
228 * doc.c (get_doc_string): Omit (unsigned)c that mishandled negatives.
229
0fed43f3
PE
230 * data.c (Faset): If ARRAY is a string, check that NEWELT is a char.
231 Without this fix, on a 64-bit host (aset S 0 4294967386) would
232 incorrectly succeed when S was a string, because 4294967386 was
233 truncated before it was used.
234
8fd02eb7
PE
235 * chartab.c (Fchar_table_range): Use CHARACTERP to check range.
236 Otherwise, an out-of-range integer could cause undefined behavior
237 on a 64-bit host.
238
f8c86b69
PE
239 * composite.c: Use int, not EMACS_INT, for characters.
240 (fill_gstring_body, composition_compute_stop_pos): Use int, not
241 EMACS_INT, for values that are known to be in character range.
242 This doesn't fix any bugs but is the usual style inside Emacs and
243 may generate better code on 32-bit machines.
244
34206dd2
PE
245 Make sure a 64-bit char is never passed to ENCODE_CHAR.
246 This is for reasons similar to the recent CHAR_STRING fix.
247 * charset.c (Fencode_char): Check that character arg is actually
248 a character. Pass an int to ENCODE_CHAR.
249 * charset.h (ENCODE_CHAR): Verify that the character argument is no
250 wider than 'int', as a compile-time check to prevent future regressions
251 in this area.
252
c5958d4c 253 * character.c (char_string): Remove unnecessary casts.
13bdea59
PE
254
255 Make sure a 64-bit char is never passed to CHAR_STRING.
256 Otherwise, CHAR_STRING would do the wrong thing on a 64-bit platform,
257 by silently ignoring the top 32 bits, allowing some values
258 that were far too large to be valid characters.
259 * character.h: Include <verify.h>.
260 (CHAR_STRING, CHAR_STRING_ADVANCE): Verify that the character
261 arguments are no wider than unsigned, as a compile-time check
262 to prevent future regressions in this area.
263 * data.c (Faset):
01103c44 264 * editfns.c (Fchar_to_string, general_insert_function, Finsert_char)
13bdea59
PE
265 (Fsubst_char_in_region):
266 * fns.c (concat):
267 * xdisp.c (decode_mode_spec_coding):
268 Adjust to CHAR_STRING's new requirement.
269 * editfns.c (Finsert_char, Fsubst_char_in_region):
270 * fns.c (concat): Check that character args are actually
271 characters. Without this test, these functions did the wrong
272 thing with wildly out-of-range values on 64-bit hosts.
273
d37ca623
PE
274 Remove incorrect casts to 'unsigned' that lose info on 64-bit hosts.
275 These casts should not be needed on 32-bit hosts, either.
276 * keyboard.c (read_char):
277 * lread.c (Fload): Remove casts to unsigned.
278
ea204efb
PE
279 * lisp.h (UNSIGNED_CMP): New macro.
280 This fixes comparison bugs on 64-bit hosts.
281 (ASCII_CHAR_P): Use it.
282 * casefiddle.c (casify_object):
01103c44 283 * character.h (ASCII_BYTE_P, CHAR_VALID_P)
ea204efb
PE
284 (SINGLE_BYTE_CHAR_P, CHAR_STRING):
285 * composite.h (COMPOSITION_ENCODE_RULE_VALID):
286 * dispextern.h (FACE_FROM_ID):
287 * keyboard.c (read_char): Use UNSIGNED_CMP.
288
41cb286c
PE
289 * xmenu.c (dialog_selection_callback) [!USE_GTK]: Cast to intptr_t,
290 not to EMACS_INT, to avoid GCC warning.
291
4a1b9832
PE
292 * xfns.c (x_set_scroll_bar_default_width): Remove unused 'int' locals.
293
55daad71
PE
294 * buffer.h (PTR_BYTE_POS, BUF_PTR_BYTE_POS): Remove harmful cast.
295 The cast incorrectly truncated 64-bit byte offsets to 32 bits, and
296 isn't needed on 32-bit machines.
8f95c75c 297
01103c44
PE
298 * buffer.c (Fgenerate_new_buffer_name):
299 Use EMACS_INT for count, not int.
0ceccced 300 (advance_to_char_boundary): Return EMACS_INT, not int.
e762cafe
PE
301
302 * data.c (Qcompiled_function): Now static.
303
c6f072e7
PE
304 * window.c (window_body_lines): Now static.
305
20ce5912
PE
306 * image.c (gif_load): Rename local to avoid shadowing.
307
9c4c5f81
PE
308 * lisp.h (SAFE_ALLOCA_LISP): Check for integer overflow.
309 (struct Lisp_Save_Value): Use ptrdiff_t, not int, for 'integer' member.
310 * alloc.c (make_save_value): Integer argument is now of type
311 ptrdiff_t, not int.
312 (mark_object): Use ptrdiff_t, not int.
313 * lisp.h (pD): New macro.
314 * print.c (print_object): Use it.
315
c0c5c8ae
PE
316 * alloc.c: Use EMACS_INT, not int, to count objects.
317 (total_conses, total_markers, total_symbols, total_vector_size)
318 (total_free_conses, total_free_markers, total_free_symbols)
01103c44
PE
319 (total_free_floats, total_floats, total_free_intervals)
320 (total_intervals, total_strings, total_free_strings):
c0c5c8ae
PE
321 Now EMACS_INT, not int. All uses changed.
322 (Fgarbage_collect): Compute overall total using a double, so that
323 integer overflow is less likely to be a problem. Check for overflow
324 when converting back to an integer.
5a25e253
PE
325 (n_interval_blocks, n_string_blocks, n_float_blocks, n_cons_blocks)
326 (n_vectors, n_symbol_blocks, n_marker_blocks): Remove.
327 These were 'int' variables that could overflow on 64-bit hosts;
328 they were never used, so remove them instead of repairing them.
211a0b2a 329 (nzombies, ngcs, max_live, max_zombies): Now EMACS_INT, not 'int'.
6349ae4d
PE
330 (inhibit_garbage_collection): Set gc_cons_threshold to max value.
331 Previously, this ceilinged at INT_MAX, but that doesn't work on
332 64-bit machines.
e46bb31a 333 (allocate_pseudovector): Don't use EMACS_INT when int would do.
c0c5c8ae 334
c78baabf 335 * alloc.c (Fmake_bool_vector): Don't assume vector size fits in int.
86f61a15 336 (allocate_vectorlike): Check for ptrdiff_t overflow.
b6439961
PE
337 (mark_vectorlike, mark_char_table, mark_object): Avoid EMACS_UINT
338 when a (possibly-narrower) signed value would do just as well.
339 We prefer using signed arithmetic, to avoid comparison confusion.
c78baabf 340
c9d624c6
PE
341 * alloc.c: Catch some string size overflows that we were missing.
342 (XMALLOC_OVERRUN_CHECK_SIZE) [!XMALLOC_OVERRUN_CHECK]: Define to 0,
343 for convenience in STRING_BYTES_MAX.
344 (STRING_BYTES_MAX): New macro, superseding the old one in lisp.h.
345 The definition here is exact; the one in lisp.h was approximate.
346 (allocate_string_data): Check for string overflow. This catches
347 some instances we weren't catching before. Also, it catches
348 size_t overflow on (unusual) hosts where SIZE_MAX <= min
349 (PTRDIFF_MAX, MOST_POSITIVE_FIXNUM), e.g., when size_t is 32 bits
350 and ptrdiff_t and EMACS_INT are both 64 bits.
c78baabf 351
c9d624c6
PE
352 * character.c, coding.c, doprnt.c, editfns.c, eval.c:
353 All uses of STRING_BYTES_MAX replaced by STRING_BYTES_BOUND.
354 * lisp.h (STRING_BYTES_BOUND): Renamed from STRING_BYTES_MAX.
355
353032ce
PE
356 * character.c (string_escape_byte8): Fix nbytes/nchars typo.
357
2bccce07
PE
358 * alloc.c (Fmake_string): Check for out-of-range init.
359
0ac30604
SM
3602011-06-15 Stefan Monnier <monnier@iro.umontreal.ca>
361
362 * eval.c (Fdefvaralias): Also mark the target as variable-special-p.
363
c195f2de
JD
3642011-06-14 Jan Djärv <jan.h.d@swipnet.se>
365
366 * xfns.c (x_set_scroll_bar_default_width): Remove argument to
367 xg_get_default_scrollbar_width.
368
369 * gtkutil.c: Include emacsgtkfixed.h if HAVE_GTK3.
370 (int_gtk_range_get_value): Move to the scroll bar part of the file.
371 (style_changed_cb): Call update_theme_scrollbar_width and call
372 x_set_scroll_bar_default_width and xg_frame_set_char_size for
373 all frames (Bug#8505).
374 (xg_create_frame_widgets): Call emacs_fixed_new if HAVE_GTK3 (Bug#8505).
375 Call gtk_window_set_resizable if HAVE_GTK3.
376 (x_wm_set_size_hint): Call emacs_fixed_set_min_size with min width
377 and height if HAVE_GTK3 (Bug#8505).
378 (scroll_bar_width_for_theme): New variable.
379 (update_theme_scrollbar_width): New function.
380 (xg_get_default_scrollbar_width): Move code to
381 update_theme_scrollbar_width, just return scroll_bar_width_for_theme.
382 (xg_initialize): Call update_theme_scrollbar_width.
383
384 * gtkutil.h (xg_get_default_scrollbar_width): Remove argument.
385
386 * emacsgtkfixed.c, emacsgtkfixed.h: New files.
387
e10ac9f1
MR
3882011-06-12 Martin Rudalics <rudalics@gmx.at>
389
390 * frame.c (make_frame): Call other_buffer_safely instead of
391 other_buffer.
392
393 * window.c (temp_output_buffer_show): Call display_buffer with
394 second argument Vtemp_buffer_show_specifiers and reset latter
395 immediately after the call.
396 (Vtemp_buffer_show_specifiers): New variable.
397 (auto_window_vscroll_p, next_screen_context_lines)
398 (Vscroll_preserve_screen_position): Remove leading asterisks from
399 doc-strings.
400
2d3c217e 4012011-06-12 Paul Eggert <eggert@cs.ucla.edu>
4475bec4 402
7b7f97e8 403 Fix minor problems found by GCC 4.6.0 static checking.
4475bec4
PE
404 * buffer.c (Qclone_number): Remove for now, as it's unused.
405 (record_buffer, Funrecord_buffer): Rename local to avoid shadowing.
406 (record_buffer): Remove unused local.
407 * frame.c (other_visible_frames, frame_buffer_list): Now static.
408 (set_frame_buffer_list): Remove; unused.
409 * frame.h (other_visible_frames): Remove decl.
410 * keyboard.h (menu_items_inuse): Declare only if USE_GTK || USE_MOTIF.
411 * lisp.h (frame_buffer_list, set_frame_buffer_list): Remove decls.
412 (add_gpm_wait_descriptor, delete_gpm_wait_descriptor): Declare only
413 if HAVE_GPM.
414 * menu.c (menu_items_inuse): Now static unless USE_GTK || USE_MOTIF.
415 * process.c (add_gpm_wait_descriptor, delete_gpm_wait_descriptor):
416 Define only if HAVE_GPM.
417 * widget.c (EmacsFrameResize, emacsFrameClassRec): Now static.
418 (update_hints_inhibit): Remove; never set. All uses removed.
419 * widgetprv.h (emacsFrameClassRec): Remove decl.
420 * window.c (delete_deletable_window): Now returns void, since it
421 wasn't returning anything.
422 (compare_window_configurations): Remove unused locals.
423 * xfns.c (x_set_scroll_bar_default_width): Remove unused locals.
424 * xmenu.c (x_menu_set_in_use): Define only if USE_GTK || USE_MOTIF.
4475bec4
PE
425 (dialog_selection_callback) [!USE_GTK]: Prefer intptr_t for integers
426 the same widths as pointers. This follows up on the 2011-05-06 patch.
427 * xterm.c (x_alloc_lighter_color_for_widget): Define only if USE_LUCID.
428 * xterm.h: Likewise.
429 (x_menu_set_in_use): Declare only if USE_GTK || USE_MOTIF.
430
1384b89e
JB
4312011-06-12 Juanma Barranquero <lekktu@gmail.com>
432
433 * makefile.w32-in: Update dependencies.
434 (LISP_H): Add lib/intprops.h.
435
1100a63c
CY
4362011-06-11 Chong Yidong <cyd@stupidchicken.com>
437
438 * image.c (gif_load): Add animation frame delay to the metadata.
439 (syms_of_image): Use DEFSYM. New symbol `delay'.
440
6198ccd0
MR
4412011-06-11 Martin Rudalics <rudalics@gmx.at>
442
443 * window.c (delete_deletable_window): Re-add.
444 (Fset_window_configuration): Rewrite to handle dead buffers and
445 consequently deletable windows.
446 (window_tree, Fwindow_tree): Remove. Supply functionality in
447 window.el.
448 (compare_window_configurations): Simplify code.
449
b6e3633c
AS
4502011-06-11 Andreas Schwab <schwab@linux-m68k.org>
451
1ab0dee5
AS
452 * image.c (imagemagick_load_image): Fix type mismatch.
453 (Fimagemagick_types): Likewise.
454
b6e3633c
AS
455 * window.h (replace_buffer_in_windows): Declare.
456
9397e56f
MR
4572011-06-11 Martin Rudalics <rudalics@gmx.at>
458
459 * buffer.c: New Lisp objects Qbuffer_list_update_hook and
460 Qclone_number. Remove external declaration of Qdelete_window.
461 (Fbuffer_list): Rewrite doc-string. Minor restructuring of
462 code.
463 (Fget_buffer_create, Fmake_indirect_buffer, Frename_buffer): Run
464 Qbuffer_list_update_hook if allowed.
465 (Fother_buffer): Rewrite doc-string. Major rewrite for new
466 buffer list implementation.
467 (other_buffer_safely): New function.
468 (Fkill_buffer): Replace call to replace_buffer_in_all_windows by
469 calls to replace_buffer_in_windows and
470 replace_buffer_in_windows_safely. Run Qbuffer_list_update_hook
471 if allowed.
472 (record_buffer): Inhibit quitting and rewrite using quittable
473 functions. Run Qbuffer_list_update_hook if allowed.
474 (Frecord_buffer, Funrecord_buffer): New functions.
475 (switch_to_buffer_1, Fswitch_to_buffer): Remove. Move
476 switch-to-buffer to window.el.
477 (bury-buffer): Move to window.el.
478 (Vbuffer_list_update_hook): New variable.
479
480 * lisp.h (other_buffer_safely): Add prototype in buffer.c
481 section.
482
483 * window.h (resize_frame_windows): Move up in code.
484 (Fwindow_frame): Remove EXFUN.
485 (replace_buffer_in_all_windows): Remove prototype.
486 (replace_buffer_in_windows_safely): Add prototype.
487
488 * window.c: Declare Qdelete_window static again. Move down
489 declaration of select_count.
490 (Fnext_window, Fprevious_window): Rewrite doc-strings.
491 (Fother_window): Move to window.el.
492 (window_loop): Remove DELETE_BUFFER_WINDOWS and UNSHOW_BUFFER
493 cases. Add REPLACE_BUFFER_IN_WINDOWS_SAFELY case.
494 (Fdelete_windows_on, Freplace_buffer_in_windows): Move to
495 window.el.
496 (replace_buffer_in_windows): Implement by calling
497 Qreplace_buffer_in_windows.
498 (replace_buffer_in_all_windows): Remove with some functionality
499 moved into replace_buffer_in_windows_safely.
500 (replace_buffer_in_windows_safely): New function.
501 (select_window_norecord, select_frame_norecord): Move in front
502 of run_window_configuration_change_hook. Remove now obsolete
503 declarations.
504 (Fset_window_buffer): Rewrite doc-string. Call
505 Qrecord_window_buffer.
506 (keys_of_window): Move binding for other-window to window.el.
507
b50691aa
CY
5082011-06-11 Chong Yidong <cyd@stupidchicken.com>
509
510 * dispextern.h (struct image): Replace data member, whose int_val
511 and ptr_val fields were not used by anything, with a single
512 lisp_val object.
513
514 * image.c (Fimage_metadata, make_image, mark_image, tiff_load)
515 (gif_clear_image, gif_load, imagemagick_load_image)
516 (gs_clear_image, gs_load): Callers changed.
517
3f754b86
PE
5182011-06-10 Paul Eggert <eggert@cs.ucla.edu>
519
cca69397
PE
520 * buffer.h: Include <time.h>, for time_t.
521 Needed to build on FreeBSD 8.2. Problem reported by Herbert J. Skuhra.
522
109e28d0
PE
523 Fix minor problems found by static checking.
524
60737f02
PE
525 * image.c (PixelGetMagickColor): Declare if ImageMagick headers don't.
526
4b66faf3
PE
527 Make identifiers static if they are not used in other modules.
528 * data.c (Qcompiled_function, Qframe, Qvector):
529 * image.c (QimageMagick, Qsvg):
530 * minibuf.c (Qmetadata):
531 * window.c (resize_window_check, resize_root_window): Now static.
532 * window.h (resize_window_check, resize_root_window): Remove decls.
533
109e28d0
PE
534 * window.c (window_deletion_count, delete_deletable_window):
535 Remove; unused.
46a4ce9e
PE
536 (window_body_lines): Now static.
537 (Fdelete_other_windows_internal): Mark vars as initialized.
538 Make sure 'resize_failed' is initialized.
539 (run_window_configuration_change_hook): Rename local to avoid shadowing.
540 (resize_window_apply): Remove unused local.
541 * window.h (delete_deletable_window): Remove decl.
542
109e28d0 543 * image.c (gif_load, svg_load_image): Rename locals to avoid shadowing.
33290528
PE
544 (imagemagick_load_image): Fix pointer signedness problem by changing
545 last arg from unsigned char * to char *. All uses changed.
546 Also, fix a local for similar reasons.
547 Remove unused locals. Remove locals to avoid shadowing.
548 (fn_rsvg_handle_free): Remove; unused.
549 (svg_load, svg_load_image): Fix pointer signedness problem.
f7e13da3 550 (imagemagick_load_image): Don't use garbage pointer image_wand.
33290528 551
3f754b86
PE
552 * ftfont.c (ftfont_get_metrics, ftfont_drive_otf): Remove unused locals.
553
2547adb1
CY
5542011-06-10 Chong Yidong <cyd@stupidchicken.com>
555
556 * image.c (gif_load): Fix omitted cast error introduced by
557 2011-06-06 change.
558
2c8e37d4
MR
5592011-06-10 Martin Rudalics <rudalics@gmx.at>
560
561 * window.h (resize_proportionally, orig_total_lines)
562 (orig_top_line): Remove from window structure.
563 (set_window_height, set_window_width, change_window_heights)
564 (Fdelete_window): Remove prototypes.
565 (resize_frame_windows): Remove duplicate declaration.
566
440a42e3
EZ
5672011-06-10 Eli Zaretskii <eliz@gnu.org>
568
569 * window.h (resize_frame_windows, resize_window_check)
570 (delete_deletable_window, resize_root_window)
571 (resize_frame_windows): Declare prototypes.
572
573 * window.c (resize_window_apply): Make definition be "static" to
574 match the prototype.
575
562dd5e9
MR
5762011-06-10 Martin Rudalics <rudalics@gmx.at>
577
578 * window.c: Remove declarations of Qwindow_size_fixed,
579 window_min_size_1, window_min_size_2, window_min_size,
580 size_window, window_fixed_size_p, enlarge_window, delete_window.
581 Remove static from declaration of Qdelete_window, it's
582 temporarily needed by Fbury_buffer.
583 (replace_window): Don't assign orig_top_line and
584 orig_total_lines.
585 (Fdelete_window, delete_window): Remove. Window deletion is
586 handled by window.el.
587 (window_loop): Remove DELETE_OTHER_WINDOWS case. Replace
588 Fdelete_window calls with calls to Qdelete_window.
589 (Fdelete_other_windows): Remove. Deleting other windows is
590 handled by window.el.
591 (window_fixed_size_p): Remove. Fixed-sizeness of windows is
592 handled in window.el.
593 (window_min_size_2, window_min_size_1, window_min_size): Remove.
594 Window minimum sizes are handled in window.el.
595 (shrink_windows, size_window, set_window_height)
596 (set_window_width, change_window_heights, window_height)
597 (window_width, CURBEG, CURSIZE, enlarge_window)
598 (adjust_window_trailing_edge, Fadjust_window_trailing_edge)
599 (Fenlarge_window, Fshrink_window): Remove. Window resizing is
600 handled in window.el.
601 (make_dummy_parent): Rename to make_parent_window and give it a
602 second argument horflag.
603 (make_window): Don't set resize_proportionally any more.
604 (Fsplit_window): Remove. Windows are split in window.el.
605 (save_restore_action, save_restore_orig_size)
606 (shrink_window_lowest_first, save_restore_orig_size): Remove.
607 Resize mini windows in window.el.
608 (grow_mini_window, shrink_mini_window): Implement by calling
609 Qresize_root_window_vertically, resize_window_check and
610 resize_window_apply.
611 (saved_window, Fset_window_configuration, save_window_save): Do
612 not handle orig_top_line, orig_total_lines, and
613 resize_proportionally.
614 (window_min_height, window_min_width): Move to window.el.
615 (keys_of_window): Move bindings for delete-other-windows,
616 split-window, delete-window and enlarge-window to window.el.
617
618 * buffer.c: Temporarily extern Qdelete_window.
619 (Fbury_buffer): Temporarily call Qdelete_window instead of
620 Fdelete_window (Fbury_buffer will move to window.el soon).
621
622 * frame.c (set_menu_bar_lines_1): Remove code handling
623 orig_top_line and orig_total_lines.
624
625 * dispnew.c (adjust_frame_glyphs_initially): Don't use
626 set_window_height but set heights directly.
627 (change_frame_size_1): Use resize_frame_windows.
628
629 * xdisp.c (init_xdisp): Don't use set_window_height but set
630 heights directly.
631
632 * xfns.c (x_set_menu_bar_lines, x_set_tool_bar_lines): Use
633 resize_frame_windows instead of change_window_heights and run
634 run_window_configuration_change_hook.
635
636 * w32fns.c (x_set_tool_bar_lines): Use resize_frame_windows
637 instead of change_window_heights and run
638 run_window_configuration_change_hook.
639
1a13852e
MR
6402011-06-09 Martin Rudalics <rudalics@gmx.at>
641
642 * window.c (replace_window): Rename second argument REPLACEMENT to
643 NEW. New third argument SETFLAG. Rewrite.
644 (delete_window, make_dummy_parent): Call replace_window with
645 third argument 1.
646 (window_list_1): Move down in code.
647 (run_window_configuration_change_hook): Move set_buffer part
648 before select_frame_norecord part in order to unwind correctly.
649 Rename count1 to count.
650 (recombine_windows, delete_deletable_window, resize_root_window)
651 (Fdelete_other_windows_internal)
652 (Frun_window_configuration_change_hook, make_parent_window)
653 (resize_window_check, resize_window_apply, Fresize_window_apply)
654 (resize_frame_windows, Fsplit_window_internal)
655 (Fdelete_window_internal, Fresize_mini_window_internal): New
656 functions.
657 (syms_of_window): New variables Vwindow_splits and Vwindow_nest.
658
f3d1777e
MR
6592011-06-08 Martin Rudalics <rudalics@gmx.at>
660
496e208e
MR
661 * window.h (window): Add some new members to window structure -
662 normal_lines, normal_cols, new_total, new_normal, clone_number,
663 splits, nest, prev_buffers, next_buffers.
664 (WINDOW_TOTAL_SIZE): Move here from window.c.
b9e809c2 665 (MIN_SAFE_WINDOW_WIDTH, MIN_SAFE_WINDOW_HEIGHT): Define here.
496e208e 666
f3d1777e
MR
667 * window.c (Fwindow_height, Fwindow_width, Fwindow_full_width_p):
668 Remove.
496e208e
MR
669 (make_dummy_parent): Set new members of windows structure.
670 (make_window): Move down in code. Handle new members of window
671 structure.
672 (Fwindow_clone_number, Fwindow_splits, Fset_window_splits)
673 (Fwindow_nest, Fset_window_nest, Fwindow_new_total)
674 (Fwindow_normal_size, Fwindow_new_normal, Fwindow_prev_buffers)
675 (Fset_window_prev_buffers, Fwindow_next_buffers)
676 (Fset_window_next_buffers, Fset_window_clone_number): New
677 functions.
678 (Fwindow_hscroll, Fwindow_at, Fwindow_point, Fwindow_start)
679 (Fwindow_end, Fwindow_line_height, Fset_window_dedicated_p):
680 Doc-string fixes.
681 (Fwindow_parameters, Fwindow_parameter, Fset_window_parameter):
682 Argument WINDOW can be now internal window too.
683 (Fwindow_use_time): Move up in code.
684 (Fget_buffer_window): Rename argument FRAME to ALL-FRAMES.
685 Rewrite doc-string.
686 (Fset_window_configuration, saved_window)
687 (Fcurrent_window_configuration, save_window_save): Handle new
688 members of window structure.
b9e809c2
MR
689 (WINDOW_TOTAL_SIZE, MIN_SAFE_WINDOW_WIDTH)
690 (MIN_SAFE_WINDOW_HEIGHT): Move to window.h.
691 (syms_of_window): New Lisp objects Qrecord_window_buffer,
692 Qwindow_deletable_p, Qdelete_window, Qreplace_buffer_in_windows,
693 Qget_mru_window, Qresize_root_window,
694 Qresize_root_window_vertically, Qsafe, Qabove, Qbelow,
695 Qauto_buffer_name; staticpro them.
f3d1777e 696
abde8f8c
MR
6972011-06-07 Martin Rudalics <rudalics@gmx.at>
698
699 * window.c (Fwindow_total_size, Fwindow_left_column)
700 (Fwindow_top_line, window_body_lines, Fwindow_body_size)
701 (Fwindow_list_1): New functions.
702 (window_box_text_cols): Replace with window_body_cols.
703 (Fwindow_width, Fscroll_left, Fscroll_right): Use
704 window_body_cols instead of window_box_text_cols.
fa8a67e6
MR
705 (delete_window, Fset_window_configuration): Call
706 delete_all_subwindows with window as argument.
707 (delete_all_subwindows): Take a window as argument and not a
708 structure. Rewrite.
190b47e6
MR
709 (window_loop): Remove handling of GET_LRU_WINDOW and
710 GET_LARGEST_WINDOW.
711 (Fget_lru_window, Fget_largest_window): Move to window.el.
abde8f8c
MR
712
713 * window.h: Extern window_body_cols instead of
fa8a67e6
MR
714 window_box_text_cols. delete_all_subwindows now takes a
715 Lisp_Object as argument.
abde8f8c
MR
716
717 * indent.c (compute_motion, Fcompute_motion): Use
718 window_body_cols instead of window_box_text_cols.
719
fa8a67e6
MR
720 * frame.c (delete_frame): Call delete_all_subwindows with root
721 window as argument.
722
a54e3482
DC
7232011-06-07 Daniel Colascione <dan.colascione@gmail.com>
724
725 * fns.c (Fputhash): Document return value.
726
60002bf5
CY
7272011-06-06 Chong Yidong <cyd@stupidchicken.com>
728
729 * image.c (gif_load): Implement gif89a spec "no disposal" method.
730
0c671da6 7312011-06-06 Paul Eggert <eggert@cs.ucla.edu>
ccd9a01a 732
b862a52a 733 Cons<->int and similar integer overflow fixes (Bug#8794).
77984278 734
be44ca6c
PE
735 Check for overflow when converting integer to cons and back.
736 * charset.c (Fdefine_charset_internal, Fdecode_char):
737 Use cons_to_unsigned to catch overflow.
738 (Fencode_char): Use INTEGER_TO_CONS.
739 * composite.h (LGLYPH_CODE): Use cons_to_unsigned.
740 (LGLYPH_SET_CODE): Use INTEGER_TO_CONS.
741 * data.c (long_to_cons, cons_to_long): Remove.
742 (cons_to_unsigned, cons_to_signed): New functions.
743 These signal an error for invalid or out-of-range values.
744 * dired.c (Ffile_attributes): Use INTEGER_TO_CONS.
745 * fileio.c (Fset_visited_file_modtime): Use CONS_TO_INTEGER.
746 * font.c (Ffont_variation_glyphs):
747 * fontset.c (Finternal_char_font): Use INTEGER_TO_CONS.
748 * lisp.h: Include <intprops.h>.
749 (INTEGER_TO_CONS, CONS_TO_INTEGER): New macros.
750 (cons_to_signed, cons_to_unsigned): New decls.
751 (long_to_cons, cons_to_long): Remove decls.
752 * undo.c (record_first_change): Use INTEGER_TO_CONS.
753 (Fprimitive_undo): Use CONS_TO_INTEGER.
754 * xfns.c (Fx_window_property): Likewise.
755 * xselect.c: Include <limits.h>.
756 (x_own_selection, selection_data_to_lisp_data):
757 Use INTEGER_TO_CONS.
758 (x_handle_selection_request, x_handle_selection_clear)
759 (x_get_foreign_selection, Fx_disown_selection_internal)
760 (Fx_get_atom_name, x_send_client_event): Use CONS_TO_INTEGER.
761 (lisp_data_to_selection_data): Use cons_to_unsigned.
762 (x_fill_property_data): Use cons_to_signed.
763 Report values out of range.
764
d1f3d2af
PE
765 Check for buffer and string overflow more precisely.
766 * buffer.h (BUF_BYTES_MAX): New macro.
767 * lisp.h (STRING_BYTES_MAX): New macro.
768 * alloc.c (Fmake_string):
769 * character.c (string_escape_byte8):
770 * coding.c (coding_alloc_by_realloc):
771 * doprnt.c (doprnt):
772 * editfns.c (Fformat):
773 * eval.c (verror):
774 Use STRING_BYTES_MAX, not MOST_POSITIVE_FIXNUM,
775 since they may not be the same number.
776 * editfns.c (Finsert_char):
777 * fileio.c (Finsert_file_contents):
778 Likewise for BUF_BYTES_MAX.
779
dd52fcea
PE
780 * image.c: Use ptrdiff_t, not int, for sizes.
781 (slurp_file): Switch from int to ptrdiff_t.
782 All uses changed.
783 (slurp_file): Check that file size fits in both size_t (for
784 malloc) and ptrdiff_t (for sanity and safety).
785
7f9bbdbb
PE
786 * fileio.c (Fverify_visited_file_modtime): Avoid time overflow
787 if b->modtime has its maximal value.
788
dfe18f82
PE
789 * dired.c (Ffile_attributes): Don't assume EMACS_INT has >32 bits.
790
84acfcf0
PE
791 Don't assume time_t can fit into int.
792 * buffer.h (struct buffer.modtime): Now time_t, not int.
793 * fileio.c (Fvisited_file_modtime): No need for time_t cast now.
794 * undo.c (Fprimitive_undo): Use time_t, not int, for time_t value.
795
ccd9a01a
PE
796 Minor fixes for signed vs unsigned integers.
797 * character.h (MAYBE_UNIFY_CHAR):
798 * charset.c (maybe_unify_char):
799 * keyboard.c (read_char, reorder_modifiers):
800 XINT -> XFASTINT, since the integer must be nonnegative.
801 * ftfont.c (ftfont_spec_pattern):
802 * keymap.c (access_keymap, silly_event_symbol_error):
803 XUINT -> XFASTINT, since the integer must be nonnegative.
804 (Fsingle_key_description, preferred_sequence_p): XUINT -> XINT,
805 since it makes no difference and we prefer signed.
806 * keyboard.c (record_char): Use XUINT when all the neighbors do.
807 (access_keymap): NATNUMP -> INTEGERP, since the integer must be
808 nonnegative.
809
d6d100dd
SM
8102011-06-06 Stefan Monnier <monnier@iro.umontreal.ca>
811
812 * window.h (Fwindow_frame): Declare.
813
2b6148e4
PE
8142011-06-06 Paul Eggert <eggert@cs.ucla.edu>
815
816 * alloc.c: Simplify handling of large-request failures (Bug#8800).
817 (SPARE_MEMORY): Always define.
818 (LARGE_REQUEST): Remove.
819 (memory_full): Use SPARE_MEMORY rather than LARGE_REQUEST.
820
f230ecc9
MR
8212011-06-06 Martin Rudalics <rudalics@gmx.at>
822
727e958e
MR
823 * lisp.h: Move EXFUNS for Fframe_root_window,
824 Fframe_first_window and Fset_frame_selected_window to window.h.
825
826 * window.h: Move EXFUNS for Fframe_root_window,
827 Fframe_first_window and Fset_frame_selected_window here from
828 lisp.h.
829
830 * frame.c (Fwindow_frame, Fframe_first_window)
831 (Fframe_root_window, Fframe_selected_window)
832 (Fset_frame_selected_window): Move to window.c.
833 (Factive_minibuffer_window): Move to minibuf.c.
834 (Fother_visible_frames_p): New function.
835
836 * minibuf.c (Factive_minibuffer_window): Move here from frame.c.
837
f230ecc9
MR
838 * window.c (decode_window, decode_any_window): Move up in code.
839 (Fwindowp, Fwindow_live_p): Rewrite doc-strings.
840 (inhibit_frame_unsplittable): Remove unused variable.
bf60a96b
MR
841 (Fwindow_buffer): Move up and rewrite doc-string.
842 (Fwindow_parent, Fwindow_vchild, Fwindow_hchild, Fwindow_next)
843 (Fwindow_prev): New functions.
727e958e
MR
844 (Fwindow_frame): Move here from frame.c. Accept any window as
845 argument.
846 (Fframe_root_window, Fframe_first_window)
847 (Fframe_selected_window): Move here from frame.c. Accept frame
848 or arbitrary window as argument. Update doc-strings.
849 (Fminibuffer_window): Move up in code.
850 (Fwindow_minibuffer_p): Move up in code and simplify.
d6d100dd
SM
851 (Fset_frame_selected_window): Move here from frame.c.
852 Marginal rewrite.
727e958e
MR
853 (Fselected_window, select_window, Fselect_window): Move up in
854 code. Minor doc-string fixes.
f230ecc9 855
4d09bcf6
PE
8562011-06-06 Paul Eggert <eggert@cs.ucla.edu>
857
858 * alloc.c (memory_full) [SYSTEM_MALLOC]: Port to MacOS (Bug#8800).
859 Do not assume that spare memory exists; that assumption is valid
860 only if SYSTEM_MALLOC.
861 (LARGE_REQUEST): New macro, so that the issue of large requests
862 is separated from the issue of spare memory.
863
810928a2
AS
8642011-06-05 Andreas Schwab <schwab@linux-m68k.org>
865
172418ad
AS
866 * editfns.c (Fformat): Correctly handle zero flag with hexadecimal
867 format. (Bug#8806)
868
43f862f7
AS
869 * gtkutil.c (xg_get_default_scrollbar_width): Avoid warning.
870
810928a2
AS
871 * xfns.c (x_set_scroll_bar_default_width): Move declarations
872 before statements.
873
a059fe24
JD
8742011-06-05 Jan Djärv <jan.h.d@swipnet.se>
875
876 * gtkutil.c (xg_get_default_scrollbar_width): New function.
877
878 * gtkutil.h: Declare xg_get_default_scrollbar_width.
879
880 * xfns.c (x_set_scroll_bar_default_width): If USE_GTK, get
881 min width by calling x_set_scroll_bar_default_width (Bug#8505).
882
989bf368
JB
8832011-06-05 Juanma Barranquero <lekktu@gmail.com>
884
885 * xdisp.c (single_display_spec_intangible_p): Remove declaration.
886
4b80f674
CY
8872011-06-04 Chong Yidong <cyd@stupidchicken.com>
888
889 * xselect.c (x_clipboard_manager_save): Remove redundant arg.
890 (x_clipboard_manager_save): Add return value.
d6d100dd
SM
891 (x_clipboard_manager_error_1, x_clipboard_manager_error_2):
892 New error handlers.
4b80f674
CY
893 (x_clipboard_manager_save_frame, x_clipboard_manager_save_all):
894 Obey Vx_select_enable_clipboard_manager. Catch errors in
895 x_clipboard_manager_save (Bug#8779).
896 (Vx_select_enable_clipboard_manager): New variable.
de65b42c 897 (x_get_foreign_selection): Reduce scope of x_catch_errors (Bug#8790).
4b80f674 898
99a33b77 8992011-06-04 Dan Nicolaescu <dann@ics.uci.edu>
8b3115e7
DN
900
901 * emacs.c (main): Warn when starting a GTK emacs in daemon mode.
902
99a33b77 9032011-06-04 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
14eca62f
YM
904
905 * fringe.c (update_window_fringes): Don't update overlay arrow bitmap
906 in the current matrix if keep_current_p is non-zero.
907
8264569d
EZ
9082011-06-04 Eli Zaretskii <eliz@gnu.org>
909
910 * bidi.c (bidi_level_of_next_char): Fix last change.
911
57f97249
EZ
9122011-06-03 Eli Zaretskii <eliz@gnu.org>
913
fec2107c 914 Support bidi reordering of text covered by display properties.
57f97249 915
fec2107c
EZ
916 * bidi.c (bidi_copy_it): Use offsetof instead of emulating it.
917 (bidi_fetch_char, bidi_fetch_char_advance): New functions.
918 (bidi_cache_search, bidi_cache_iterator_state)
919 (bidi_paragraph_init, bidi_resolve_explicit, bidi_resolve_weak)
d6d100dd
SM
920 (bidi_level_of_next_char, bidi_move_to_visually_next):
921 Support character positions inside a run of characters covered by a
fec2107c
EZ
922 display string.
923 (bidi_paragraph_init, bidi_resolve_explicit_1)
924 (bidi_level_of_next_char): Call bidi_fetch_char and
925 bidi_fetch_char_advance instead of FETCH_CHAR and
926 FETCH_CHAR_ADVANCE.
927 (bidi_init_it): Initialize new members.
928 (LRE_CHAR, RLE_CHAR, PDF_CHAR, LRO_CHAR, RLO_CHAR): Remove macro
929 definitions.
930 (bidi_explicit_dir_char): Lookup character type in bidi_type_table,
931 instead of using explicit *_CHAR codes.
d6d100dd
SM
932 (bidi_resolve_explicit, bidi_resolve_weak):
933 Use FETCH_MULTIBYTE_CHAR instead of FETCH_CHAR, as reordering of
fec2107c
EZ
934 bidirectional text is supported only in multibyte buffers.
935 (bidi_init_it): Accept additional argument FRAME_WINDOW_P and use
936 it to initialize the frame_window_p member of struct bidi_it.
937 (bidi_cache_iterator_state, bidi_resolve_explicit_1)
938 (bidi_resolve_explicit, bidi_resolve_weak)
939 (bidi_level_of_next_char, bidi_move_to_visually_next): Abort if
940 bidi_it->nchars is non-positive.
941 (bidi_level_of_next_char): Don't try to lookup the cache for the
942 next/previous character if nothing is cached there yet, or if we
943 were just reseat()'ed to a new position.
c40e2fb2 944
0e14fe90
EZ
945 * xdisp.c (set_cursor_from_row): Set start and stop points
946 according to the row's direction when priming the loop that looks
947 for the glyph on which to display cursor.
948 (single_display_spec_intangible_p): Function deleted.
949 (display_prop_intangible_p): Reimplement to call
950 handle_display_spec instead of single_display_spec_intangible_p.
d6d100dd
SM
951 Accept 3 additional arguments needed by handle_display_spec.
952 This fixes incorrect cursor motion across display property with complex
0e14fe90
EZ
953 values: lists, `(when COND...)' forms, etc.
954 (single_display_spec_string_p): Support property values that are
955 lists with the argument STRING its top-level element.
956 (display_prop_string_p): Fix the condition for processing a
957 property that is a list to be consistent with handle_display_spec.
fec2107c 958 (handle_display_spec): New function, refactored from the
fc6f18ce
EZ
959 last portion of handle_display_prop.
960 (compute_display_string_pos): Accept additional argument
961 FRAME_WINDOW_P. Call handle_display_spec to determine whether the
962 value of a `display' property is a "replacing spec".
963 (handle_single_display_spec): Accept 2 additional arguments BUFPOS
964 and FRAME_WINDOW_P. If IT is NULL, don't set up the iterator from
965 the display property, but just return a value indicating whether
966 the display property will replace the characters it covers.
967 (Fcurrent_bidi_paragraph_direction): Initialize the nchars and
968 frame_window_p members of struct bidi_it.
d6d100dd
SM
969 (compute_display_string_pos, compute_display_string_end):
970 New functions.
fec2107c
EZ
971 (push_it): Accept second argument POSITION, where pop_it should
972 jump to continue iteration.
973 (reseat_1): Initialize bidi_it.disp_pos.
fc6f18ce 974
fec2107c
EZ
975 * keyboard.c (adjust_point_for_property): Adjust the call to
976 display_prop_intangible_p to its new signature.
fc6f18ce
EZ
977
978 * dispextern.h (struct bidi_it): New member frame_window_p.
fec2107c
EZ
979 (bidi_init_it): Update prototypes.
980 (display_prop_intangible_p): Update prototype.
d6d100dd
SM
981 (compute_display_string_pos, compute_display_string_end):
982 Declare prototypes.
fec2107c
EZ
983 (struct bidi_it): New members nchars and disp_pos. ch_len is now
984 EMACS_INT.
fc6f18ce 985
40087514 9862011-06-02 Paul Eggert <eggert@cs.ucla.edu>
0de4bb68 987
57f53182
PE
988 Malloc failure behavior now depends on size of allocation.
989 * alloc.c (buffer_memory_full, memory_full): New arg NBYTES.
990 * lisp.h: Change signatures accordingly.
991 * alloc.c, buffer.c, editfns.c, menu.c, minibuf.c, xterm.c:
992 All callers changed. (Bug#8762)
993
994 * gnutls.c: Use Emacs's memory allocators.
995 Without this change, the gnutls library would invoke malloc etc.
996 directly, which causes problems on non-SYNC_INPUT hosts, and which
997 runs afoul of improving memory_full behavior. (Bug#8761)
998 (fn_gnutls_global_set_mem_functions): New macro or function pointer.
999 (emacs_gnutls_global_init): Use it to specify xmalloc, xrealloc,
1000 xfree instead of the default malloc, realloc, free.
1001 (Fgnutls_boot): No need to check for memory allocation failure,
1002 since xmalloc does that for us.
1003
ac32cd99 1004 Remove arbitrary limit of 2**31 entries in hash tables. (Bug#8771)
3870d916
PE
1005 * category.c (hash_get_category_set):
1006 * ccl.c (ccl_driver):
1007 * charset.c (Fdefine_charset_internal):
1008 * charset.h (struct charset.hash_index):
1009 * composite.c (get_composition_id, gstring_lookup_cache)
1010 (composition_gstring_put_cache):
1011 * composite.h (struct composition.hash_index):
1012 * dispextern.h (struct image.hash):
1013 * fns.c (next_almost_prime, larger_vector, cmpfn_eql)
1014 (cmpfn_equal, cmpfn_user_defined, hashfn_eq, hashfn_eql)
1015 (hashfn_equal, hashfn_user_defined, make_hash_table)
1016 (maybe_resize_hash_table, hash_lookup, hash_put)
1017 (hash_remove_from_table, hash_clear, sweep_weak_table, SXHASH_COMBINE)
1018 (sxhash_string, sxhash_list, sxhash_vector, sxhash_bool_vector)
1019 (Fsxhash, Fgethash, Fputhash, Fmaphash):
1020 * image.c (make_image, search_image_cache, lookup_image)
1021 (xpm_put_color_table_h):
1022 * lisp.h (struct Lisp_Hash_Table):
0de4bb68 1023 * minibuf.c (Ftry_completion, Fall_completions, Ftest_completion):
3870d916
PE
1024 * print.c (print): Use 'EMACS_UINT' and 'EMACS_INT'
1025 for hashes and hash indexes, instead of 'unsigned' and 'int'.
40087514
PE
1026 * alloc.c (allocate_vectorlike):
1027 Check for overflow in vector size calculations.
1028 * ccl.c (ccl_driver):
1029 Check for overflow when converting EMACS_INT to int.
0de4bb68
PE
1030 * fns.c, image.c: Remove unnecessary static decls that would otherwise
1031 need to be updated by these changes.
40087514
PE
1032 * fns.c (make_hash_table, maybe_resize_hash_table):
1033 Check for integer overflow with large hash tables.
0de4bb68
PE
1034 (make_hash_table, maybe_resize_hash_table, Fmake_hash_table):
1035 Prefer the faster XFLOAT_DATA to XFLOATINT where either will do.
1036 (SXHASH_REDUCE): New macro.
1037 (sxhash_string, sxhash_list, sxhash_vector, sxhash_bool_vector):
1038 Use it instead of discarding useful hash info with large hash values.
1039 (sxhash_float): New function.
1040 (sxhash): Use it. No more need for "& INTMASK" due to above changes.
1041 * lisp.h (FIXNUM_BITS): New macro, useful for SXHASH_REDUCE etc.
40087514
PE
1042 (MOST_NEGATIVE_FIXNUM, MOST_POSITIVE_FIXNUM, INTMASK):
1043 Rewrite to use FIXNUM_BITS, as this simplifies things.
0de4bb68
PE
1044 (next_almost_prime, larger_vector, sxhash, hash_lookup, hash_put):
1045 Adjust signatures to match updated version of code.
1046 (consing_since_gc): Now EMACS_INT, since a single hash table can
1047 use more than INT_MAX bytes.
1048
698d32e2
DN
10492011-06-01 Dan Nicolaescu <dann@ics.uci.edu>
1050
1051 Make it possible to build with GCC-4.6+ -O2 -flto.
1052
1053 * emacs.c (__malloc_initialize_hook): Mark as EXTERNALLY_VISIBLE.
1054
fd6fa53f
SM
10552011-06-01 Stefan Monnier <monnier@iro.umontreal.ca>
1056
1057 * minibuf.c (get_minibuffer, read_minibuf_unwind):
1058 Call minibuffer-inactive-mode.
1059
864db017
JB
10602011-05-31 Juanma Barranquero <lekktu@gmail.com>
1061
1062 * makefile.w32-in ($(BLD)/data.$(O), $(BLD)/editfns.$(O)):
1063 Update dependencies.
1064
2ad0baf4
DN
10652011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
1066
1067 * data.c (init_data): Remove code for UTS, this system is not
1068 supported anymore.
1069
4fcc2638
DN
10702011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
1071
1072 Don't force ./temacs to start in terminal mode.
1073
1074 * frame.c (make_initial_frame): Initialize faces in all cases, not
1075 only when CANNOT_DUMP is defined.
1076 * dispnew.c (init_display): Remove CANNOT_DUMP condition.
1077
c56e0fd5
DN
10782011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
1079
1080 * dispnew.c (add_window_display_history): Use const for the string
1081 pointer. Remove declaration, not needed.
1082
333d54da 10832011-05-31 Paul Eggert <eggert@cs.ucla.edu>
9cf9f756 1084
55d4c1b2 1085 Use 'inline', not 'INLINE'.
333d54da 1086 <http://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00914.html>
55d4c1b2
PE
1087 * alloc.c, fontset.c (INLINE): Remove.
1088 * alloc.c, bidi.c, charset.c, coding.c, dispnew.c, fns.c, image.c:
1089 * intervals.c, keyboard.c, process.c, syntax.c, textprop.c, w32term.c:
1090 * xdisp.c, xfaces.c, xterm.c: Replace all uses of INLINE with inline.
1091 * gmalloc.c (register_heapinfo): Use inline unconditionally.
1092 * lisp.h (LISP_MAKE_RVALUE): Use inline, not __inline__.
1093
738db178
DN
10942011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
1095
1096 Make it possible to run ./temacs.
1097
1098 * callproc.c (set_initial_environment): Remove CANNOT_DUMP code,
1099 syms_of_callproc does the same thing. Remove test for
1100 "initialized", do it in the caller.
1101 * emacs.c (main): Avoid calling set_initial_environment when dumping.
1102
620c53a6
SM
11032011-05-31 Stefan Monnier <monnier@iro.umontreal.ca>
1104
1105 * minibuf.c (Finternal_complete_buffer): Return `category' metadata.
1106 (read_minibuf): Use get_minibuffer.
1107 (syms_of_minibuf): Use DEFSYM.
1108 (Qmetadata): New var.
1109 * data.c (Qbuffer): Don't make it static.
1110 (syms_of_data): Use DEFSYM.
1111
e003a292
PE
11122011-05-31 Paul Eggert <eggert@cs.ucla.edu>
1113
1114 * ccl.c (CCL_CODE_RANGE): Allow negative numbers. (Bug#8751)
1115 (CCL_CODE_MIN): New macro.
1116
ed008a6d
PE
11172011-05-30 Paul Eggert <eggert@cs.ucla.edu>
1118
3687c2ef
PE
1119 * alloc.c (lisp_align_malloc): Omit unnecessary val==NULL tests.
1120
ed008a6d
PE
1121 * eval.c (Qdebug): Now static.
1122 * lisp.h (Qdebug): Remove decl. This reverts a part of the
1123 2011-04-26T11:26:05Z!dan.colascione@gmail.com that inadvertently undid part of
1124 2011-04-14T06:48:41Z!eggert@cs.ucla.edu.
1125
d66c4c7c
CY
11262011-05-29 Chong Yidong <cyd@stupidchicken.com>
1127
1128 * image.c: Various fixes to ImageMagick code comments.
1129 (Fimagemagick_types): Doc fix.
1130
5fbc2025
PE
11312011-05-29 Paul Eggert <eggert@cs.ucla.edu>
1132
0196f88a
PE
1133 Minor fixes prompted by GCC 4.6.0 warnings.
1134
1135 * xselect.c (converted_selections, conversion_fail_tag): Now static.
1136
5fbc2025
PE
1137 * emacs.c [HAVE_X_WINDOWS]: Include "xterm.h".
1138 (x_clipboard_manager_save_all): Move extern decl to ...
1139 * xterm.h: ... here, so that it can be checked for consistency.
1140
1dd3c2d9
CY
11412011-05-29 Chong Yidong <cyd@stupidchicken.com>
1142
1143 * xselect.c (x_clipboard_manager_save_frame)
1144 (x_clipboard_manager_save_all): New functions.
1145 (Fx_clipboard_manager_save): Lisp function deleted.
1146
1147 * emacs.c (Fkill_emacs): Call x_clipboard_manager_save_all.
1148 * frame.c (delete_frame): Call x_clipboard_manager_save_frame.
1149
1150 * xterm.h: Update prototype.
1151
5ba6571d
WX
11522011-05-28 William Xu <william.xwl@gmail.com>
1153
1154 * nsterm.m (ns_term_shutdown): Synchronize user defaults before
1155 exiting (Bug#8239).
1156
3eaff834
JM
11572011-05-28 Jim Meyering <meyering@redhat.com>
1158
e1900994 1159 Avoid a sign-extension bug in crypto_hash_function.
3eaff834
JM
1160 * fns.c (to_uchar): Define.
1161 (crypto_hash_function): Use it to convert some newly-signed
1162 variables to unsigned, to avoid sign-extension bugs. For example,
1163 without this change, (md5 "truc") would evaluate to
1164 45723a2aff78ff4fff7fff1114760e62 rather than the expected
1165 45723a2af3788c4ff17f8d1114760e62. Reported by Antoine Levitt in
e1900994 1166 https://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00883.html.
3eaff834 1167
0f6990a7
PE
11682011-05-27 Paul Eggert <eggert@cs.ucla.edu>
1169
1170 Integer overflow fixes.
c8a9ca5a 1171
08686060
PE
1172 * dbusbind.c: Serial number integer overflow fixes.
1173 (CHECK_DBUS_SERIAL_GET_SERIAL): New macro.
08686060
PE
1174 (Fdbus_call_method_asynchronously, xd_read_message_1): Use a float
1175 to hold a serial number that is too large for a fixnum.
1176 (Fdbus_method_return_internal, Fdbus_method_error_internal):
1177 Check for serial numbers out of range. Decode any serial number
59568bf0 1178 that was so large that it became a float. (Bug#8722)
08686060 1179
2d1fc3c7
PE
1180 * dbusbind.c: Use XFASTINT rather than XUINT, and check for nonneg.
1181 (Fdbus_call_method, Fdbus_call_method_asynchronously):
1182 Use XFASTINT rather than XUINT when numbers are nonnegative.
1183 (xd_append_arg, Fdbus_method_return_internal):
1184 (Fdbus_method_error_internal): Likewise. Also, for unsigned
1185 arguments, check that Lisp number is nonnegative, rather than
59568bf0 1186 silently wrapping negative numbers around. (Bug#8722)
30217ff0 1187 (xd_read_message_1): Don't assume dbus_uint32_t can fit in int.
59568bf0 1188 (Bug#8722)
2d1fc3c7 1189
c8a9ca5a
PE
1190 * data.c (arith_driver, Flsh): Avoid unnecessary casts to EMACS_UINT.
1191
519e1d69
PE
1192 * ccl.c (ccl_driver): Redo slightly to avoid the need for 'unsigned'.
1193
30569699
PE
1194 ccl: add integer overflow checks
1195 * ccl.c (CCL_CODE_MAX, GET_CCL_RANGE, GET_CCL_CODE, GET_CCL_INT):
1196 (IN_INT_RANGE): New macros.
1197 (ccl_driver): Use them to check for integer overflow when
1198 decoding a CCL program. Many of the new checks are whether XINT (x)
1199 fits in int; it doesn't always, on 64-bit hosts. The new version
1200 doesn't catch all possible integer overflows, but it's an
847044ea 1201 improvement. (Bug#8719)
30569699 1202
c11285dc
PE
1203 * alloc.c (make_event_array): Use XINT, not XUINT.
1204 There's no need for unsigned here.
1205
fdccd48e
PE
1206 * mem-limits.h (EXCEEDS_LISP_PTR) [!USE_LSB_TAG]: EMACS_UINT -> uintptr_t
1207 This follows up to the 2011-05-06 change that substituted uintptr_t
1208 for EMACS_INT. This case wasn't caught back then.
1209
37910ab2
PE
1210 Rework Fformat to avoid integer overflow issues.
1211 * editfns.c: Include <float.h> unconditionally, as it's everywhere
1212 now (part of C89). Include <verify.h>.
1213 (MAX_10_EXP, CONVERTED_BYTE_SIZE): Remove; no longer needed.
1214 (pWIDE, pWIDElen, signed_wide, unsigned_wide): New defns.
1215 (Fformat): Avoid the prepass trying to compute sizes; it was only
1216 approximate and thus did not catch overflow reliably. Instead, walk
1217 through the format just once, formatting and computing sizes as we go,
1218 checking for integer overflow at every step, and allocating a larger
1219 buffer as needed. Keep track separately whether the format is
1220 multibyte. Keep only the most-recently calculated precision, rather
1221 than them all. Record whether each argument has been converted to
1222 string. Use EMACS_INT, not int, for byte and char and arg counts.
1223 Support field widths and precisions larger than INT_MAX. Avoid
1224 sprintf's undefined behavior with conversion specifications such as %#d
1225 and %.0c. Fix bug with strchr succeeding on '\0' when looking for
1226 flags. Fix bug with (format "%c" 256.0). Avoid integer overflow when
1227 formatting out-of-range floating point numbers with int
1228 formats. (Bug#8668)
1229
2e6578fb
PE
1230 * lisp.h (FIXNUM_OVERFLOW_P): Work even if arg is a NaN.
1231
0ae6bdee
PE
1232 * data.c: Avoid integer truncation in expressions involving floats.
1233 * data.c: Include <intprops.h>.
1234 (arith_driver): When there's an integer overflow in an expression
1235 involving floating point, convert the integers to floating point
1236 so that the resulting value does not suffer from catastrophic
1237 integer truncation. For example, on a 64-bit host (* 4
1238 most-negative-fixnum 0.5) should yield about -4.6e+18, not zero.
1239 Do not rely on undefined behavior after integer overflow.
1240
de883a70
PE
1241 merge count_size_as_multibyte, parse_str_to_multibyte
1242 * character.c, character.h (count_size_as_multibyte):
fd6fa53f 1243 Rename from parse_str_to_multibyte; all uses changed.
de883a70
PE
1244 Check for integer overflow.
1245 * insdel.c, lisp.h (count_size_as_multibyte): Remove,
1246 since it's now a duplicate of the other. This is more of
1247 a character than a buffer op, so better that it's in character.c.
1248 * fns.c, print.c: Adjust to above changes.
1249
2ff916cb
PE
12502011-05-27 Stefan Monnier <monnier@iro.umontreal.ca>
1251
1252 * xselect.c (x_convert_selection): Yet another int/Lisp_Object mixup.
1253
f1b54466
PE
12542011-05-27 Paul Eggert <eggert@cs.ucla.edu>
1255
fb1ac845
PE
1256 * xselect.c: Fix minor problems prompted by GCC 4.6.0 warnings.
1257 (x_handle_selection_request, frame_for_x_selection): Remove unused vars.
1258 (x_clipboard_manager_save): Now static.
1259 (Fx_clipboard_manager_save): Rename local to avoid shadowing.
1260
f1b54466
PE
1261 * fns.c: Fix minor problems prompted by GCC 4.6.0 warnings.
1262 (crypto_hash_function): Now static.
1263 Fix pointer signedness problems. Avoid unnecessary initializations.
1264
a9f737ee
CY
12652011-05-27 Chong Yidong <cyd@stupidchicken.com>
1266
1267 * termhooks.h (Vselection_alist): Make it terminal-local.
1268
1269 * terminal.c (create_terminal): Initialize it.
1270
1271 * xselect.c: Support for clipboard managers.
1272 (Vselection_alist): Move to termhooks.h as terminal-local var.
1273 (LOCAL_SELECTION): New macro.
1274 (x_atom_to_symbol): Handle x_display_info_for_display fail case.
1275 (symbol_to_x_atom): Remove gratuitous arg.
1276 (x_handle_selection_request, lisp_data_to_selection_data)
1277 (x_get_foreign_selection, Fx_register_dnd_atom): Callers changed.
620c53a6
SM
1278 (x_own_selection, x_get_local_selection, x_convert_selection):
1279 New arg, specifying work frame. Use terminal-local Vselection_alist.
a9f737ee
CY
1280 (some_frame_on_display): Delete unused function.
1281 (Fx_own_selection_internal, Fx_get_selection_internal)
1282 (Fx_disown_selection_internal, Fx_selection_owner_p)
1283 (Fx_selection_exists_p): New optional frame arg.
1284 (frame_for_x_selection, Fx_clipboard_manager_save): New functions.
1285 (x_handle_selection_clear): Don't treat other terminals with the
1286 same keyboard specially. Use the terminal-local Vselection_alist.
1287 (x_clear_frame_selections): Use Frun_hook_with_args.
1288
1289 * xterm.c (x_term_init): Intern ATOM and CLIPBOARD_MANAGER atoms.
1290
1291 * xterm.h: Add support for those atoms.
1292
e067f0c1
CY
12932011-05-26 Chong Yidong <cyd@stupidchicken.com>
1294
1295 * xselect.c: ICCCM-compliant handling of MULTIPLE targets.
1296 (converted_selections, conversion_fail_tag): New global variables.
1297 (x_selection_request_lisp_error): Free the above.
1298 (x_get_local_selection): Remove unnecessary code.
1299 (x_reply_selection_request): Args changed; handle arbitrary array
620c53a6
SM
1300 of converted selections stored in converted_selections.
1301 Separate the XChangeProperty and SelectionNotify steps.
e067f0c1
CY
1302 (x_handle_selection_request): Rewrite to handle MULTIPLE target.
1303 (x_convert_selection): New function.
1304 (x_handle_selection_event): Simplify.
1305 (x_get_foreign_selection): Don't ignore incoming requests while
1306 waiting for an answer; this will fail when we implement
1307 SAVE_TARGETS, and seems unnecessary anyway.
1308 (selection_data_to_lisp_data): Recognize ATOM_PAIR type.
1309 (Vx_sent_selection_functions): Doc fix.
1310
0f4aebc0
LL
13112011-05-26 Leo Liu <sdl.web@gmail.com>
1312
1313 * editfns.c (Ftranspose_regions): Allow empty regions. (Bug#8699)
1314
e61124cd
YM
13152011-05-25 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
1316
1317 * dispextern.h (struct glyph_row): New member fringe_bitmap_periodic_p.
1318
1319 * dispnew.c (shift_glyph_matrix, scrolling_window): Mark scrolled row
1320 for fringe update if it has periodic bitmap.
1321 (row_equal_p): Also compare left_fringe_offset, right_fringe_offset,
1322 and fringe_bitmap_periodic_p.
1323
1324 * fringe.c (get_fringe_bitmap_data): New function.
1325 (draw_fringe_bitmap_1, update_window_fringes): Use it.
1326 (update_window_fringes): Record periodicity of fringe bitmap in glyph
1327 row. Mark glyph row for fringe update if periodicity changed.
1328
1329 * xdisp.c (try_window_reusing_current_matrix): Don't mark scrolled row
1330 for fringe update unless it has periodic bitmap.
1331
f16d9837
KH
13322011-05-25 Kenichi Handa <handa@m17n.org>
1333
1334 * xdisp.c (get_next_display_element): Set correct it->face_id for
1335 a static composition.
1336
e1b90ef6
LL
13372011-05-24 Leo Liu <sdl.web@gmail.com>
1338
1339 * deps.mk (fns.o):
1340 * makefile.w32-in ($(BLD)/fns.$(O)): Include sha1.h.
1341
1342 * fns.c (crypto_hash_function, Fsha1): New function.
1343 (Fmd5): Use crypto_hash_function.
1344 (syms_of_fns): Add Ssha1.
1345
7400048f
PE
13462011-05-22 Paul Eggert <eggert@cs.ucla.edu>
1347
1348 * gnutls.c: Remove unused macros.
1349 (fn_gnutls_transport_set_lowat, fn_gnutls_transport_set_pull_function):
1350 (fn_gnutls_transport_set_push_function) [!WINDOWSNT]:
1351 Remove macros that are defined and never used.
1352 Caught by gcc -Wunused-macros (GCC 4.6.0, Fedora 14).
1353
abb71cf4
CY
13542011-05-22 Chong Yidong <cyd@stupidchicken.com>
1355
1356 * xselect.c (syms_of_xselect): Remove unused symbol SAVE_TARGETS.
1357 (Fx_get_selection_internal): Minor cleanup.
1358 (Fx_own_selection_internal): Rename arguments for consistency with
1359 select.el.
1360
6307db39
PE
13612011-05-22 Paul Eggert <eggert@cs.ucla.edu>
1362
1363 * xselect.c (QSAVE_TARGETS): New static var, to fix build failure.
1364
f3d4e0a4
CY
13652011-05-22 Chong Yidong <cyd@stupidchicken.com>
1366
1367 * xselect.c (syms_of_xselect): Include character.h; use DEFSYM.
1368
4d8ade89
YM
13692011-05-21 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
1370
1371 * dispnew.c (scrolling_window): Don't exclude the case that the
1372 last enabled row in the desired matrix touches the bottom boundary.
1373
32078c8d
GM
13742011-05-21 Glenn Morris <rgm@gnu.org>
1375
1376 * Makefile.in ($(etc)/DOC): Make second command line even shorter.
33cf345f
GM
1377 (SOME_MACHINE_OBJECTS): Replace FONT_OBJ by its maximal expansion,
1378 and add some more files.
32078c8d 1379
7285dc67
EZ
13802011-05-20 Eli Zaretskii <eliz@gnu.org>
1381
1382 * callproc.c (Fcall_process) [MSDOS]: Fix arguments to
1383 report_file_error introduced by the change from 2011-05-07.
1384
89d1bd22
PE
13852011-05-20 Paul Eggert <eggert@cs.ucla.edu>
1386
1387 * systime.h (Time): Define only if emacs is defined.
1388 This is to allow ../lib-src/profile.c to be compiled on FreeBSD,
1389 where the include path doesn't have X11/X.h by default. See
1390 <http://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00561.html>.
1391
e23640bb 13922011-05-20 Kenichi Handa <handa@m17n.org>
31bfc35c
KH
1393
1394 * composite.c (find_automatic_composition): Fix previous change.
1395
b9704ad9
GM
13962011-05-20 Glenn Morris <rgm@gnu.org>
1397
1398 * lisp.mk: New file, split from Makefile.in.
1399 * Makefile.in (lisp): Move to separate file, inserted by @lisp_frag@.
1400 (shortlisp): Remove.
1401 ($(etc)/DOC): Edit lisp.mk rather than using $shortlisp.
1402
4a720484
GM
14032011-05-19 Glenn Morris <rgm@gnu.org>
1404
1405 * Makefile.in (MSDOS_SUPPORT_REAL, MSDOS_SUPPORT, NS_SUPPORT)
1406 (REAL_MOUSE_SUPPORT, GPM_MOUSE_SUPPORT, MOUSE_SUPPORT, TOOLTIP_SUPPORT)
1407 (BASE_WINDOW_SUPPORT, X_WINDOW_SUPPORT, WINDOW_SUPPORT): Remove.
1408 (lisp): Set the order to that of loadup.el.
1409 (shortlisp): Make it a copy of $lisp.
1410 (SOME_MACHINE_LISP): Remove.
1411 ($(etc)/DOC): Depend just on $lisp, not $SOME_MACHINE_LISP too.
1412 Use just $shortlisp, not $SOME_MACHINE_LISP too.
1413
a28d4396
KH
14142011-05-18 Kenichi Handa <handa@m17n.org>
1415
1416 * composite.c (CHAR_COMPOSABLE_P): Add more check for efficiency.
1417 (BACKWARD_CHAR): Wrap the arg STOP by parenthesis.
1418 (find_automatic_composition): Mostly rewrite for efficiency.
1419
a2b1fa8e
JB
14202011-05-18 Juanma Barranquero <lekktu@gmail.com>
1421
1422 * makefile.w32-in: Update dependencies.
1423
8e1f5610
CS
14242011-05-18 Christoph Scholtes <cschol2112@googlemail.com>
1425
1426 * menu.c: Include limits.h (fixes the MS-Windows build broken by
fadf4e30 1427 2011-06-18T18:49:19Z!cyd@stupidchicken.com).
8e1f5610 1428
7025ee00 14292011-05-18 Paul Eggert <eggert@cs.ucla.edu>
cb93f9be 1430
cdfa6eab
PE
1431 Fix some integer overflow issues, such as string length overflow.
1432
06d6db33
PE
1433 * insdel.c (count_size_as_multibyte): Check for string overflow.
1434
2b4560a8
PE
1435 * character.c (lisp_string_width): Check for string overflow.
1436 Use EMACS_INT, not int, for string indexes and lengths; in
1437 particular, 2nd arg is now EMACS_INT, not int. Do not crash if
1438 the resulting string length overflows an EMACS_INT; instead,
1439 report a string overflow if no precision given. When checking for
1440 precision exhaustion, use a check that cannot possibly have
1441 integer overflow. (Bug#8675)
1442 * character.h (lisp_string_width): Adjust to new signature.
1443
cb93f9be
PE
1444 * alloc.c (string_overflow): New function.
1445 (Fmake_string): Use it. This doesn't change behavior, but saves
1446 a few bytes and will simplify future changes.
1447 * character.c (string_escape_byte8): Likewise.
1448 * lisp.h (string_overflow): New decl.
1449
1a1f3366
PE
1450 Fixups, following up to the user-interface timestamp change.
1451 * nsterm.m (last_mouse_movement_time, ns_mouse_position): Use Time
1452 for UI timestamps, instead of unsigned long.
9fbd6841
PE
1453 * msdos.c (mouse_get_pos): Likewise.
1454 * w32inevt.c (movement_time, w32_console_mouse_position): Likewise.
1a1f3366
PE
1455 * w32gui.h (Time): Define by including "systime.h" rather than by
1456 declaring it ourselves. (Bug#8664)
1457
d4e3e4d3
PE
1458 * dispextern.h (struct image): Don't assume time_t <= unsigned long.
1459 * image.c (clear_image_cache): Likewise.
1460
f6a24d19
PE
1461 * term.c (term_mouse_position): Don't assume time_t wraparound.
1462
08dc5ae6
PE
1463 Be more systematic about user-interface timestamps.
1464 Before, the code sometimes used 'Time', sometimes 'unsigned long',
620c53a6
SM
1465 and sometimes 'EMACS_UINT', to represent these timestamps.
1466 This change causes it to use 'Time' uniformly, as that's what X uses.
08dc5ae6
PE
1467 This makes the code easier to follow, and makes it easier to catch
1468 integer overflow bugs such as Bug#8664.
1469 * frame.c (Fmouse_position, Fmouse_pixel_position):
1470 Use Time, not unsigned long, for user-interface timestamps.
1471 * keyboard.c (last_event_timestamp, kbd_buffer_get_event): Likewise.
1472 (button_down_time, make_lispy_position, make_lispy_movement): Likewise.
1473 * keyboard.h (last_event_timestamp): Likewise.
1474 * menu.c (Fx_popup_menu) [!HAVE_X_WINDOWS]: Likewise.
1475 * menu.h (xmenu_show): Likewise.
1476 * term.c (term_mouse_position): Likewise.
1477 * termhooks.h (struct input_event.timestamp): Likewise.
1478 (struct terminal.mouse_position_hook): Likewise.
1479 * xmenu.c (create_and_show_popup_menu, xmenu_show): Likewise.
1480 * xterm.c (XTmouse_position, x_scroll_bar_report_motion): Likewise.
1481 * systime.h (Time): New decl. Pull it in from <X11/X.h> if
1482 HAVE_X_WINDOWS, otherwise define it as unsigned long, which is
1483 what it was before.
1484 * menu.h, termhooks.h: Include "systime.h", for Time.
1485
8e55734a
PE
1486 * keyboard.c (make_lispy_event): Fix problem in integer overflow.
1487 Don't assume that the difference between two unsigned long values
1488 can fit into an integer. At this point, we know button_down_time
1489 <= event->timestamp, so the difference must be nonnegative, so
1490 there's no need to cast the result if double-click-time is
1491 nonnegative, as it should be; check that it's nonnegative, just in
1492 case. This bug is triggered when events are more than 2**31 ms
86db42d2 1493 apart (about 25 days). (Bug#8664)
8e55734a 1494
841f1b75 1495 * xselect.c (last_event_timestamp): Remove duplicate decl.
6434756c 1496 (x_own_selection): Remove needless cast to unsigned long.
841f1b75 1497
3e26f69c
PE
1498 * xmenu.c (set_frame_menubar): Use int, not EMACS_UINT, for indexes
1499 that always fit in int. Use a sentinel instead of a counter, to
1500 avoid a temp and to allay GCC's concerns about possible int overflow.
d230cb74
PE
1501 * frame.h (struct frame): Use int for menu_bar_items_used
1502 instead of EMACS_INT, since it always fits in int.
3e26f69c 1503
5cc152c0
PE
1504 * menu.c (grow_menu_items): Check for int overflow.
1505
d89eb65e
PE
1506 * xmenu.c (set_frame_menubar): Don't mishandle vectors with no nils.
1507
5235bd3e
PE
1508 * xterm.c: Use EMACS_INT for Emacs modifiers, and int for X modifiers.
1509 Before, the code was not consistent. These values cannot exceed
1510 2**31 - 1 so there's no need to make them unsigned.
1511 (x_x_to_emacs_modifiers): Accept int and return EMACS_INT.
1512 (x_emacs_to_x_modifiers): Accept EMACS_INT and return int.
1513 (x_x_to_emacs_modifiers, x_emacs_to_x_modifiers): Reject non-integers
1514 as modifiers.
1515 * xterm.h (x_x_to_emacs_modifiers): Adjust to signature change.
1516
bc827e23
PE
1517 * lisp.h (XINT) [USE_LISP_UNION_TYPE]: Cast to EMACS_INT.
1518 (XUINT) [USE_LISP_UNION_TYPE]: Cast to EMACS_UINT.
1519 Otherwise, GCC 4.6.0 warns about printf (pI, XINT (...)),
1520 presumably because the widths might not match.
1521
78eb494e
PE
1522 * window.c (size_window): Avoid needless test at loop start.
1523
04f2d78b
CB
15242011-05-18 Courtney Bane <emacs-bugs-7626@cbane.org> (tiny change)
1525
1526 * term.c (Fresume_tty): Restore hooks before reinitializing (bug#8687).
1527
d2fc7e3d 15282011-05-12 Drew Adams <drew.adams@oracle.com>
e531bdff
DA
1529
1530 * textprop.c (Fprevious_single_char_property_change): Doc fix (bug#8655).
1531
d2fc7e3d 15322011-05-12 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
7db47798
YM
1533
1534 * w32term.c (w32_draw_fringe_bitmap): Rename local vars `left' and
1535 `width' to `bar_area_x' and `bar_area_width', respectively.
1536 (x_scroll_run): Take account of fringe background extension.
1537
04f2d78b
CB
1538 * xterm.c (x_draw_fringe_bitmap) [USE_TOOLKIT_SCROLL_BARS]:
1539 Rename local vars `left' and `width' to `bar_area_x' and
7db47798
YM
1540 `bar_area_width', respectively.
1541 (x_scroll_run) [USE_TOOLKIT_SCROLL_BARS]: Take account of fringe
1542 background extension.
1543
79b70037
GM
15442011-05-10 Jim Meyering <meyering@redhat.com>
1545
1546 * xdisp.c (x_intersect_rectangles): Fix typo "the the -> the".
1547
2f142cc5
JB
15482011-05-10 Juanma Barranquero <lekktu@gmail.com>
1549
1550 * image.c (Finit_image_library): Return t for built-in image types,
1551 like pbm and xbm. (Bug#8640)
1552
57679c86
AS
15532011-05-09 Andreas Schwab <schwab@linux-m68k.org>
1554
1555 * w32menu.c (set_frame_menubar): Fix submenu allocation.
1556
888c9e86
EZ
15572011-05-07 Eli Zaretskii <eliz@gnu.org>
1558
b0512a1d
EZ
1559 * w32console.c (Fset_screen_color): Doc fix.
1560 (Fget_screen_color): New function.
1561 (syms_of_ntterm): Defsubr it.
1562
7285dc67
EZ
1563 * callproc.c (call_process_cleanup) [MSDOS]: Don't close and
1564 unlink the temporary file if Fcall_process didn't create it in the
1565 first place.
1566 (Fcall_process) [MSDOS]: Don't create tempfile if stdout of the
1567 child process will be redirected to a file specified with `:file'.
888c9e86
EZ
1568 Don't try to re-open tempfile in that case, and set fd[0] to -1 as
1569 cue to call_process_cleanup not to close that handle.
1570
4d3fcc8e
BK
15712011-05-07 Ben Key <bkey76@gmail.com>
1572
1573 * makefile.w32-in: The bootstrap-temacs rule now makes use of
1574 one of two shell specific rules, either bootstrap-temacs-CMD or
1575 bootstrap-temacs-SH. The bootstrap-temacs-SH rule is identical
1576 to the previous implementation of the bootstrap-temacs rule.
1577 The bootstrap-temacs-CMD rule is similar to the previous
1578 implementation of the bootstrap-temacs rule except that it
1579 makes use of the ESC_CFLAGS variable instead of the CFLAGS
1580 variable.
1581
1582 These changes, along with some changes to nt/configure.bat,
1583 nt/gmake.defs, and nt/nmake.defs, are required to extend my
1584 earlier fix to add support for --cflags and --ldflags options
1585 that include quotes so that it works whether make uses cmd or
1586 sh as the shell.
1587
b4289b64
MA
15882011-05-06 Michael Albinus <michael.albinus@gmx.de>
1589
1590 * dbusbind.c (QCdbus_type_unix_fd): Declare static.
1591 (xd_remove_watch): Don't check QCdbus_type_unix_fd for SYMBOLP, it
1592 is a constant.
1593 (Fdbus_init_bus, xd_read_queued_messages): Bus can be a symbol or
1594 a string. Handle both cases.
1595 (Fdbus_call_method_asynchronously, Fdbus_register_signal)
1596 (Fdbus_register_method): Use Qinvalid_function.
1597
af4c0e28
JB
15982011-05-06 Juanma Barranquero <lekktu@gmail.com>
1599
1600 * makefile.w32-in: Update dependencies.
1601 (LISP_H): Add inttypes.h and stdin.h.
1602 (PROCESS_H): Add unistd.h.
1603
c51453d9
EZ
16042011-05-06 Eli Zaretskii <eliz@gnu.org>
1605
1606 * lread.c: Include limits.h (fixes the MS-Windows build broken by
1607 2011-05-06T07:13:19Z!eggert@cs.ucla.edu).
1608
8ff0ac3c 16092011-05-06 Paul Eggert <eggert@cs.ucla.edu>
c032b5f8 1610
4c4b566b
PE
1611 * image.c (Finit_image_library) [!HAVE_NTGUI]: Omit unused local.
1612
aab2b9b5
PE
1613 * term.c (vfatal): Remove stray call to va_end.
1614 It's not needed and the C Standard doesn't allow it here anyway.
1615
c378da0b
PE
1616 Use C99's va_copy to avoid undefined behavior on x86-64 GNU/Linux.
1617 * eval.c (verror): doprnt a copy of ap, not the original. (Bug#8545)
1618
288b08c7
PE
1619 * eval.c (verror): OK to create a string of up to MOST_POSITIVE_FIXNUM
1620 bytes.
1621
e3601888
PE
1622 * term.c: Don't include <stdarg.h>, as <lisp.h> does that.
1623
db6c0e74
PE
1624 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork clobbering.
1625
dd5963ea
PE
1626 * process.c (Fformat_network_address): Fix typo: args2 -> *args2.
1627
88c9450f
PE
1628 * xmenu.c (set_frame_menubar): Fix typo: int * -> int (3 times).
1629
2f9442b8
PE
1630 * coding.c (detect_coding_charset): Fix typo: * 2 -> *4 (Bug#8601).
1631
c032b5f8
PE
1632 * charset.h (struct charset.code_space): Now has 15 elements, not 16.
1633 * charset.c (Fdefine_charset_internal): Don't initialize
1634 charset.code_space[15]. The value was garbage, on hosts with
2d38271b 1635 32-bit int (Bug#8600).
a108c10b
PE
1636
1637 * lread.c (read_integer): Be more consistent with string-to-number.
1638 Use string_to_number to do the actual conversion; this avoids
1639 rounding errors and fixes some other screwups. Without this fix,
1640 for example, #x1fffffffffffffff was misread as -2305843009213693952.
1641 (digit_to_number): Move earlier, for benefit of read_integer.
1642 Return -1 if the digit is out of range for the base, -2 if it is
48e400f0 1643 not a digit in any supported base. (Bug#8602)
a108c10b 1644
ad5f9eea
PE
1645 * doprnt.c (doprnt): Support arbitrary pI values, such as "I64".
1646
aec1708a
PE
1647 * dispnew.c (scrolling_window): Return 1 if we scrolled,
1648 to match comment at start of function. This also removes a
1649 GCC warning about overflow in a 32+64-bit port.
1650
47be4ab5
PE
1651 * lisp.h (EMACS_INT, EMACS_UINT, BITS_PER_EMACS_INT, pI): Simplify.
1652
371cac43
PE
1653 * dbusbind.c: Do not use XPNTR on a value that may be an integer.
1654 Reported by Stefan Monnier in
1655 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00919.html>.
04f2d78b
CB
1656 (xd_remove_watch, Fdbus_init_bus, xd_read_queued_messages):
1657 Use SYMBOLP-guarded XSYMBOL, not XPNTR.
371cac43 1658
d01a7826
PE
1659 * lisp.h (EMACS_INTPTR): Remove. All uses changed to intptr_t.
1660 (EMACS_UINTPTR): Likewise, with uintptr_t.
1661
7fd47d5c
PE
1662 * lisp.h: Prefer 64-bit EMACS_INT if available.
1663 (EMACS_INT, EMACS_UINT, BITS_PER_EMACS_INT, pI): Define to 64-bit
1664 on 32-bit hosts that have 64-bit int, so that they can access
1665 large files.
122b0c86
PE
1666 However, temporarily disable this change unless the temporary
1667 symbol WIDE_EMACS_INT is defined.
7fd47d5c 1668
8727937b
PE
1669 * lread.c, process.c: Do not include <inttypes.h>; lisp.h does it now.
1670
8ac068ac
PE
1671 Prefer intptr_t/uintptr_t for integers the same widths as pointers.
1672 This removes an assumption that EMACS_INT and long are the same
1673 width as pointers. The assumption is true for Emacs porting targets
1674 now, but we want to make other targets possible.
1675 * lisp.h: Include <inttypes.h>, for INTPTR_MAX, UINTPTR_MAX.
1676 (EMACS_INTPTR, EMACS_UINTPTR): New macros.
1677 In the rest of the code, change types of integers that hold casted
1678 pointers to EMACS_INTPTR and EMACS_UINTPTR, systematically
1679 replacing EMACS_INT, long, EMACS_UINT, and unsigned long.
1680 (XTYPE): Don't cast arg to EMACS_UINT; normally is not needed.
1681 (XSET): Cast type of XTYPE arg to EMACS_INTPTR; it is needed here.
1682 No need to cast type when ORing.
1683 (XPNTR): Return a value of type EMACS_INTPTR or EMACS_UINTPTR.
1684 * alloc.c (lisp_align_malloc): Remove a no-longer-needed cast.
1685 * doc.c (store_function_docstring): Use EMACS_INTPTR, so as not to
1686 assume EMACS_INT is the same width as char *.
1687 * gtkutil.c (xg_gtk_scroll_destroy, xg_tool_bar_button_cb):
1688 (xg_tool_bar_callback, xg_tool_bar_help_callback, xg_make_tool_item):
1689 Remove no-longer-needed casts.
1690 (xg_create_scroll_bar, xg_tool_bar_button_cb, xg_tool_bar_callback):
1691 (xg_tool_bar_help_callback, xg_make_tool_item):
1692 Use EMACS_INTPTR to hold an integer
1693 that will be cast to void *; this can avoid a GCC warning
1694 if EMACS_INT is not the same width as void *.
1695 * menu.c (find_and_call_menu_selection): Remove no-longer-needed cast.
1696 * xdisp.c (display_echo_area_1, resize_mini_window_1):
1697 (current_message_1, set_message_1):
1698 Use a local to convert to proper width without a cast.
1699 * xmenu.c (dialog_selection_callback): Likewise.
1700
ede49d71
PE
1701 * sysdep.c (get_random): Don't assume EMACS_INT is no wider than long.
1702 Also, don't assume VALBITS / RAND_BITS is less than 5,
1703 and don't rely on undefined behavior when shifting a 1 left into
1704 the sign bit.
1705 * lisp.h (get_random): Change signature to match.
1706
2f30ecd0
PE
1707 * lread.c (hash_string): Use size_t, not int, for hash computation.
1708 Normally we prefer signed values; but hashing is special, because
1709 it's better to use unsigned division on hash table sizes so that
1710 the remainder is nonnegative. Also, size_t is the natural width
1711 for hashing into memory. The previous code used 'int', which doesn't
1712 retain enough info to hash well into very large tables.
1713 (oblookup, oblookup_last_bucket_number, Funintern): Likewise.
1714
2a866e7b
PE
1715 * dbusbind.c: Don't possibly lose pointer info when converting.
1716 (xd_remove_watch, Fdbus_init_bus, xd_read_queued_messages):
1717 Use XPNTR rather than XHASH, so that the high-order bits of
1718 the pointer aren't lost when converting through void *.
1719
51639eac
PE
1720 * eval.c (Fautoload): Don't double-shift a pointer.
1721
92394119
PE
1722 * fns.c (Frandom): Let EMACS_UINT be wider than unsigned long.
1723
dbdb9a7c
JB
17242011-05-06 Juanma Barranquero <lekktu@gmail.com>
1725
1726 * gnutls.c (DEF_GNUTLS_FN):
1727 * image.c (DEF_IMGLIB_FN): Make function pointers static.
1728
db7a0b4f
AS
17292011-05-05 Andreas Schwab <schwab@linux-m68k.org>
1730
1731 * lread.c (lisp_file_lexically_bound_p): Stop scanning at end
1732 marker. (Bug#8610)
1733
f7ff1b0f 17342011-05-05 Eli Zaretskii <eliz@gnu.org>
fab624aa
EZ
1735
1736 * w32heap.c (allocate_heap) [USE_LISP_UNION_TYPE || USE_LSB_TAG]:
1737 New version that can reserve upto 2GB of heap space.
1738
f7ff1b0f 17392011-05-05 Chong Yidong <cyd@stupidchicken.com>
45cb8994
CY
1740
1741 * nsfns.m (Fns_read_file_name): Doc fix (Bug#8534).
1742
639c109b
TZ
17432011-05-05 Teodor Zlatanov <tzz@lifelogs.com>
1744
1745 * gnutls.c (fn_gnutls_certificate_set_x509_key_file): Add alias to
1746 `gnutls_certificate_set_x509_key_file'.
1747
d2127135
JB
17482011-05-05 Juanma Barranquero <lekktu@gmail.com>
1749
1750 * makefile.w32-in ($(BLD)/image.$(O), $(BLD)/process.$(O)):
1751 Update dependencies.
1752
e968f4f3
JB
17532011-05-04 Juanma Barranquero <lekktu@gmail.com>
1754
1755 * gnutls.h (emacs_gnutls_write, emacs_gnutls_read):
1756 * gnutls.c (emacs_gnutls_write, emacs_gnutls_read):
1757 Remove unused parameter `fildes'.
1758 * process.c (read_process_output, send_process): Don't pass it.
1759
84d358f0
JB
17602011-05-04 Juanma Barranquero <lekktu@gmail.com>
1761
1762 Fix previous change: the library cache is defined in w32.c.
1763 * image.c (CACHE_IMAGE_TYPE) [!HAVE_NTGUI]: Define to noop.
1764 (Finit_image_library): Wrap Vlibrary_cache on "#ifdef HAVE_NTGUI".
1765
0898ca10
JB
17662011-05-04 Juanma Barranquero <lekktu@gmail.com>
1767
1768 Implement dynamic loading of GnuTLS on Windows.
1769
1770 * gnutls.h (GNUTLS_EMACS_ERROR_NOT_LOADED): New macro.
1771 (emacs_gnutls_write, emacs_gnutls_read): Mark as extern.
1772 (emacs_gnutls_record_check_pending, emacs_gnutls_transport_set_errno):
1773 Declare.
1774
1775 * gnutls.c (Qgnutls_dll): Define.
1776 (DEF_GNUTLS_FN, LOAD_GNUTLS_FN): New macros.
1777 (gnutls_*): Declare function pointers.
1778 (init_gnutls_functions): New function to initialize function pointers.
1779 (emacs_gnutls_handshake, Fgnutls_error_string, Fgnutls_deinit)
1780 (emacs_gnutls_global_init, Fgnutls_bye): Use function pointers.
1781 (emacs_gnutls_record_check_pending, emacs_gnutls_transport_set_errno):
1782 Wrappers for gnutls_record_check_pending and gnutls_transport_set_errno.
1783 (emacs_gnutls_write, emacs_gnutls_read)
1784 (emacs_gnutls_handle_error, Fgnutls_error_fatalp)
1785 (Fgnutls_available_p): New function.
1786 (Fgnutls_boot): Call Fgnutls_available_p. Use function pointers.
1787 (syms_of_gnutls) <Qgnutls_dll>: Initialize and staticpro it.
1788 (syms_of_gnutls) <Sgnutls_available_p>: defsubr it.
1789
1790 * image.c: Include w32.h.
1791 (Vimage_type_cache): Delete.
1792 (syms_of_image) <Vimage_type_cache>: Don't initialize and staticpro it.
1793 (CACHE_IMAGE_TYPE, Finit_image_library): Use Vlibrary_cache instead.
1794 (w32_delayed_load): Move to w32.c.
1795
1796 * w32.h (VlibraryCache, QCloaded_from, w32_delayed_load): Declare.
1797
1798 * w32.c (QCloaded_from, Vlibrary_cache): Define.
1799 (w32_delayed_load): Move from image.c. When loading a library, record
1800 its filename in the :loaded-from property of the library id.
1801 (globals_of_w32) <QCloaded_from, Vlibrary_cache>:
1802 Initialize and staticpro them.
1803 (emacs_gnutls_pull, emacs_gnutls_push): Call emacs_gnutls_* functions.
1804
1805 * process.c: Include lisp.h before w32.h, not after.
1806 (wait_reading_process_output): Call emacs_gnutls_record_check_pending
1807 instead of gnutls_record_check_pending.
1808
1809 * callproc.c, emacs.c: Include lisp.h before w32.h, not after.
1810
ff4de4aa
TZ
18112011-05-04 Teodor Zlatanov <tzz@lifelogs.com>
1812
1813 * gnutls.c (Fgnutls_boot): Support :keylist and :crlfiles options
1814 instead of :keyfiles. Give GnuTLS the keylist and the CRL lists
1815 as passed in.
1816
abe95abb
JD
18172011-05-03 Jan Djärv <jan.h.d@swipnet.se>
1818
1819 * xterm.c (x_set_frame_alpha): Do not set property on anything
1820 else than FRAME_X_OUTER_WINDOW (Bug#8608).
1821
e16e55d4
JB
18222011-05-02 Juanma Barranquero <lekktu@gmail.com>
1823
1824 * sysdep.c (get_tty_size) [WINDOWSNT]: Implement. (Bug#8596)
1825
bafcf6a5
JB
18262011-05-02 Juanma Barranquero <lekktu@gmail.com>
1827
1828 * gnutls.c (Qgnutls_log_level, Qgnutls_code, Qgnutls_anon)
1829 (Qgnutls_x509pki, Qgnutls_e_interrupted, Qgnutls_e_again)
1830 (Qgnutls_e_invalid_session, Qgnutls_e_not_ready_for_handshake)
1831 (gnutls_global_initialized, Qgnutls_bootprop_priority)
1832 (Qgnutls_bootprop_trustfiles, Qgnutls_bootprop_keyfiles)
1833 (Qgnutls_bootprop_callbacks, Qgnutls_bootprop_loglevel)
1834 (Qgnutls_bootprop_hostname, Qgnutls_bootprop_verify_flags)
1835 (Qgnutls_bootprop_verify_error, Qgnutls_bootprop_verify_hostname_error)
1836 (Qgnutls_bootprop_callbacks_verify): Make static.
1837
e7a6747f
AS
18382011-05-01 Andreas Schwab <schwab@linux-m68k.org>
1839
19ed11ba
AS
1840 * callproc.c: Indentation fixup.
1841
e7a6747f 1842 * sysdep.c (wait_for_termination_1): Make static.
04f2d78b
CB
1843 (wait_for_termination, interruptible_wait_for_termination):
1844 Move after wait_for_termination_1.
e7a6747f 1845
1ef14cb4
LMI
18462011-05-01 Lars Magne Ingebrigtsen <larsi@gnus.org>
1847
1848 * sysdep.c (interruptible_wait_for_termination): New function
1849 which is like wait_for_termination, but allows keyboard
1850 interruptions.
1851
1852 * callproc.c (Fcall_process): Add (:file "file") as an option for
1853 the STDOUT buffer.
1854 (Fcall_process_region): Ditto.
1855
330d880c
EZ
18562011-04-30 Eli Zaretskii <eliz@gnu.org>
1857
8db90b73
EZ
1858 * dosfns.c (Fint86, Fdos_memget, Fdos_memput): Use `ASIZE (FOO)'
1859 rather than `XVECTOR (FOO)->size'.
1860
330d880c
EZ
1861 * process.c: Remove HAVE_INTTYPES_H condition from inclusion of
1862 inttypes.h, as a gnulib replacement is used if it not available in
1863 system headers.
1864
15cbd324
EZ
18652011-04-21 Eli Zaretskii <eliz@gnu.org>
1866
1867 Lift the MOST_POSITIVE_FIXNUM/4 limitation on visited files.
1868 * fileio.c (Finsert_file_contents): Don't limit file size to 1/4
1869 of MOST_POSITIVE_FIXNUM. (Bug#8528)
1870
1871 * coding.c (coding_alloc_by_realloc): Error out if destination
1872 will grow beyond MOST_POSITIVE_FIXNUM.
1873 (decode_coding_emacs_mule): Abort if there isn't enough place in
1874 charbuf for the composition carryover bytes. Reserve an extra
1875 space for up to 2 characters produced in a loop.
1876 (decode_coding_iso_2022): Abort if there isn't enough place in
1877 charbuf for the composition carryover bytes.
1878
18792011-04-21 Eli Zaretskii <eliz@gnu.org>
afda1437 1880
ae940cca
EZ
1881 * doprnt.c (doprnt) [!HAVE_LONG_LONG_INT]: Error out instead of
1882 aborting when %lld or %lll format is passed.
1883 [!HAVE_UNSIGNED_LONG_LONG_INT]: Error out instead of aborting when
1884 %llo or %llx format is passed. (Bug#8545)
1885
03ab8921
EZ
1886 * window.c (window_scroll_line_based): Use a marker instead of
1887 simple variables to record original value of point. (Bug#7952)
1888
afda1437
EZ
1889 * doprnt.c (doprnt): Fix the case where a multibyte sequence
1890 produced by %s or %c overflows available buffer space. (Bug#8545)
1891
f76dee0c
PE
18922011-04-28 Paul Eggert <eggert@cs.ucla.edu>
1893
1894 * doprnt.c (doprnt): Omit useless test; int overflow check (Bug#8545).
283cdbef 1895 (SIZE_MAX): Move defn after all includes, as they might #define it.
f76dee0c 1896
fdc5744d
JB
18972011-04-28 Juanma Barranquero <lekktu@gmail.com>
1898
1899 * w32.c (init_environment): Warn about defaulting HOME to C:\.
1900
638f053a
JB
19012011-04-28 Juanma Barranquero <lekktu@gmail.com>
1902
1903 * keyboard.c (Qdelayed_warnings_hook): Define.
1904 (command_loop_1): Run `delayed-warnings-hook'
1905 if Vdelayed_warnings_list is non-nil.
1906 (syms_of_keyboard) <delayed-warnings-hook>: DEFSYM it.
1907 (syms_of_keyboard) <delayed-warnings-list>: DEFVAR_LISP it.
1908
d178f871
EZ
19092011-04-28 Eli Zaretskii <eliz@gnu.org>
1910
1911 * doprnt.c (doprnt): Don't return value smaller than the buffer
1912 size if the message was truncated. (Bug#8545).
1913
b124fd93
JB
19142011-04-28 Juanma Barranquero <lekktu@gmail.com>
1915
1916 * w32fns.c (Fx_change_window_property, Fx_delete_window_property)
1917 (Fx_window_property): #if-0 the whole functions, not just the bodies.
1918
e810457d
PE
19192011-04-27 Paul Eggert <eggert@cs.ucla.edu>
1920
1921 * doprnt.c (doprnt): Support "ll" length modifier, for long long.
1922
ea51cceb
JB
19232011-04-27 Juanma Barranquero <lekktu@gmail.com>
1924
1925 * makefile.w32-in: Update dependencies.
1926
94dcfacf
EZ
19272011-04-27 Eli Zaretskii <eliz@gnu.org>
1928
1929 Improve `doprnt' and its usage. (Bug#8545)
1930 * doprnt.c (doprnt): Make sure `format' is never accessed beyond
1931 `format_end'. Remove support for %l as a conversion specifier.
1932 Don't use xrealloc. Improve diagnostics when the %l size modifier
1933 is used. Update the commentary.
1934
1935 * eval.c (verror): Simplify calculation of size_t.
1936
1937 * coding.c (Ffind_operation_coding_system): Fix diagnostic error
1938 messages.
1939
f61f41d7
PE
19402011-04-27 Yoshiaki Kasahara <kasahara@nc.kyushu-u.ac.jp> (tiny change)
1941
1942 * buffer.c (init_buffer) [USE_MMAP_FOR_BUFFERS]: Adjust to aliasing
1943 change.
1944
96fb4434
PE
19452011-04-27 Paul Eggert <eggert@cs.ucla.edu>
1946
1947 * nsmenu.m: Replace all uses of XVECTOR with ASIZE and AREF.
1948 This makes this file independent of the recent pseudovector change.
1949
671875da 19502011-04-26 Paul Eggert <eggert@cs.ucla.edu>
eab3844f 1951
69e9b5a3
PE
1952 * keyboard.c (handle_user_signal): Fix pointer signedness problem.
1953
b5f869a7 1954 * gnutls.c (emacs_gnutls_handle_error): Remove unused local.
7754e151 1955 (Fgnutls_boot): gnutls_certificate_verify_peers2 wants unsigned *.
8d4c3955 1956 Remove unused local.
c8926152 1957 (emacs_gnutls_write): Don't use uninitialized rtnval if nbyte <= 0.
080e5a8d 1958
841a1577 1959 * lisp.h: Fix a problem with aliasing and vector headers. (Bug#8546)
04f2d78b
CB
1960 GCC 4.6.0 optimizes based on type-based alias analysis.
1961 For example, if b is of type struct buffer * and v of type struct
eab3844f
PE
1962 Lisp_Vector *, then gcc -O2 was incorrectly assuming that &b->size
1963 != &v->size, and therefore "v->size = 1; b->size = 2; return
1964 v->size;" must therefore return 1. This assumption is incorrect
1965 for Emacs, since it type-puns struct Lisp_Vector * with many other
1966 types. To fix this problem, this patch adds a new type struct
f904488f 1967 vectorlike_header that documents the constraints on layout of vectors
eab3844f
PE
1968 and pseudovectors, and helps optimizing compilers not get fooled
1969 by Emacs's type punning. It also adds the macros XSETTYPED_PVECTYPE
1970 XSETTYPED_PSEUDOVECTOR, TYPED_PSEUDOVECTORP, for similar reasons.
f904488f
PE
1971 * lisp.h (XSETTYPED_PVECTYPE): New macro, specifying the name of
1972 the size member.
eab3844f
PE
1973 (XSETPVECTYPE): Rewrite in terms of new macro.
1974 (XSETPVECTYPESIZE): New macro, specifying both type and size.
1975 This is a bit clearer, and further avoids the possibility of
1976 undesirable aliasing.
1977 (XSETTYPED_PSEUDOVECTOR): New macro, specifying the size.
f904488f 1978 (XSETPSEUDOVECTOR): Rewrite in terms of XSETTYPED_PSEUDOVECTOR.
eab3844f
PE
1979 (XSETSUBR): Rewrite in terms of XSETTYPED_PSEUDOVECTOR and XSIZE,
1980 since Lisp_Subr is a special case (no "next" field).
04f2d78b
CB
1981 (ASIZE): Now uses header.size rather than size.
1982 All previous uses of XVECTOR (foo)->size replaced to use this macro,
f904488f
PE
1983 to avoid the hassle of writing XVECTOR (foo)->header.size.
1984 (struct vectorlike_header): New type.
eab3844f
PE
1985 (TYPED_PSEUDOVECTORP): New macro, also specifying the C type of the
1986 object, to help avoid aliasing.
1987 (PSEUDOVECTORP): Rewrite in terms of TYPED_PSEUDOVECTORP.
1988 (SUBRP): Likewise, since Lisp_Subr is a special case.
1989 * lisp.h (struct Lisp_Vector, struct Lisp_Char_Table):
1990 (struct Lisp_Sub_Char_Table, struct Lisp_Bool_Vector):
1991 (struct Lisp_Hash_Table): Combine first two members into a single
f904488f 1992 struct vectorlike_header member. All uses of "size" and "next" members
eab3844f
PE
1993 changed to be "header.size" and "header.next".
1994 * buffer.h (struct buffer): Likewise.
1995 * font.h (struct font_spec, struct font_entity, struct font): Likewise.
1996 * frame.h (struct frame): Likewise.
1997 * process.h (struct Lisp_Process): Likewise.
1998 * termhooks.h (struct terminal): Likewise.
1999 * window.c (struct save_window_data, struct saved_window): Likewise.
2000 * window.h (struct window): Likewise.
2001 * alloc.c (allocate_buffer, Fmake_bool_vector, allocate_pseudovector):
2002 Use XSETPVECTYPESIZE, not XSETPVECTYPE, to avoid aliasing problems.
2003 * buffer.c (init_buffer_once): Likewise.
2004 * lread.c (defsubr): Use XSETTYPED_PVECTYPE, since Lisp_Subr is a
2005 special case.
2006 * process.c (Fformat_network_address): Use local var for size,
2007 for brevity.
2008
0df1eac5
PE
2009 * bytecode.c (exec_byte_code): Don't use XVECTOR before CHECK_VECTOR.
2010
847ab9d1 2011 Make the Lisp reader and string-to-float more consistent (Bug#8525)
452f4150
PE
2012 * data.c (atof): Remove decl; no longer used or needed.
2013 (digit_to_number): Move to lread.c.
2014 (Fstring_to_number): Use new string_to_number function, to be
2015 consistent with how the Lisp reader treats infinities and NaNs.
2016 Do not assume that floating-point numbers represent EMACS_INT
2017 without losing information; this is not true on most 64-bit hosts.
2018 Avoid double-rounding errors, by insisting on integers when
2019 parsing non-base-10 numbers, as the documentation specifies.
2020 * lisp.h (string_to_number): New decl, replacing ...
2021 (isfloat_string): Remove.
bc0a5c13 2022 * lread.c: Include <inttypes.h>, for uintmax_t and strtoumax.
d78050d6 2023 (read1): Do not accept +. and -. as integers; this
452f4150
PE
2024 appears to have been a coding error. Similarly, do not accept
2025 strings like +-1e0 as floating point numbers. Do not report
2026 overflow for integer overflows unless the base is not 10 which
2027 means we have no simple and reliable way to continue.
2028 Break out the floating-point parsing into a new
2029 function string_to_number, so that Fstring_to_number parses
2030 floating point numbers consistently with the Lisp reader.
04f2d78b 2031 (digit_to_number): Move here from data.c. Make it static inline.
452f4150
PE
2032 (E_CHAR, EXP_INT): Remove, replacing with ...
2033 (E_EXP): New macro, to solve the "1.0e+" problem mentioned below.
2034 (string_to_number): New function, replacing isfloat_string.
2035 This function checks for valid syntax and produces the resulting
2036 Lisp float number too. Rework it so that string-to-number
bc0a5c13 2037 no longer mishandles examples like "1.0e+". Use strtoumax,
d78050d6
PE
2038 so that overflow for non-base-10 numbers is reported only when
2039 there's no portable and simple way to convert to floating point.
452f4150 2040
67769ffc
PE
2041 * textprop.c (set_text_properties_1): Rewrite for clarity,
2042 and to avoid GCC warning about integer overflow.
2043
c20db43f
PE
2044 * intervals.h (struct interval): Use EMACS_INT for members
2045 where EMACS_UINT might cause problems. See
2046 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00514.html>.
2047 (CHECK_TOTAL_LENGTH): Remove cast to EMACS_INT; no longer needed.
2048 * intervals.c (interval_deletion_adjustment): Now returns EMACS_INT.
2049 All uses changed.
37aa2f85
PE
2050 (offset_intervals): Tell GCC not to worry about length overflow
2051 when negating a negative length.
c20db43f 2052
2538aa2f
PE
2053 * alloc.c (overrun_check_malloc, overrun_check_realloc): Now static.
2054 (overrun_check_free): Likewise.
2055
f2d3008d
PE
2056 * alloc.c (SDATA_SIZE) [!GC_CHECK_STRING_BYTES]: Avoid runtime check
2057 in the common case where SDATA_DATA_OFFSET is a multiple of Emacs
2058 word size.
2059
ec8df744
PE
2060 * gnutls.c: Fix problems found by GCC 4.6.0 on Ubuntu 10.10.
2061 (gnutls_make_error): Rename local to avoid shadowing.
2062 (gnutls_emacs_global_deinit): ifdef out; not used.
2063 (Fgnutls_boot): Use const for pointer to readonly storage.
2064 Comment out unused local. Fix pointer signedness problems.
2065
640ee02d
PE
2066 * lread.c (openp): Don't stuff size_t into an 'int'.
2067 Use <= on length, not < on length + 1, to avoid GCC 4.6.0 warning
2068 about possible signed overflow.
2069
6048fb2a
PE
2070 * gtkutil.c: Fix problems found by GCC 4.6.0 on Ubuntu 10.10.
2071 (GDK_KEY_g): Don't define if already defined.
2072 (xg_prepare_tooltip): Avoid pointer signedness problem.
2073 (xg_set_toolkit_scroll_bar_thumb): Redo to avoid two casts.
2074
fa3c87e1
PE
2075 * process.c (Fnetwork_interface_info): Avoid left-shift undefined
2076 behavior with 1 << 31. GCC 4.6.0 warns about this on 32-bit hosts.
2077
2172544b
PE
2078 * xfns.c (Fx_window_property): Simplify a bit,
2079 to make a bit faster and to avoid GCC 4.6.0 warning.
2080 * xselect.c (x_get_window_property, x_handle_dnd_message): Likewise.
2081
9b821a21
PE
2082 * fns.c (internal_equal): Don't assume size_t fits in int.
2083
3c616cfa
PE
2084 * alloc.c (compact_small_strings): Tighten assertion a little.
2085
c2982e87
PE
2086 Replace pEd with more-general pI, and fix some printf arg casts.
2087 * lisp.h (pI): New macro, generalizing old pEd macro to other
2088 conversion specifiers. For example, use "...%"pI"d..." rather
2089 than "...%"pEd"...".
2090 (pEd): Remove. All uses replaced with similar uses of pI.
2091 * src/m/amdx86-64.h, src/m/ia64.h, src/m/ibms390x.h: Likewise.
2092 * alloc.c (check_pure_size): Don't overflow by converting size to int.
2093 * bidi.c (bidi_dump_cached_states): Use pI to avoid cast.
2094 * data.c (Fnumber_to_string): Use pI instead of if-then-else-abort.
2095 * dbusbind.c (xd_append_arg): Use pI to avoid cast.
2096 (Fdbus_method_return_internal, Fdbus_method_error_internal): Likewise.
2097 * font.c (font_unparse_xlfd): Avoid potential buffer overrun on
2098 64-bit hosts.
2099 (font_unparse_xlfd, font_unparse_fcname): Use pI to avoid casts.
2100 * keyboard.c (record_char, modify_event_symbol): Use pI to avoid casts.
2101 * print.c (safe_debug_print, print_object): Likewise.
2102 (print_object): Don't overflow by converting EMACS_INT or EMACS_UINT
2103 to int.
6f04d126
PE
2104 Use pI instead of if-then-else-abort. Use %p to avoid casts,
2105 avoiding the 0 flag, which is not portable.
c2982e87
PE
2106 * process.c (Fmake_network_process): Use pI to avoid cast.
2107 * region-cache.c (pp_cache): Likewise.
2108 * xdisp.c (decode_mode_spec): Likewise.
2109 * xrdb.c (x_load_resources) [USE_MOTIF]: Use pI to avoid undefined
2110 behavior on 64-bit hosts with printf arg.
6f04d126 2111 * xselect.c (x_queue_event): Use %p to avoid casts, avoiding 0 flag.
c2982e87
PE
2112 (x_stop_queuing_selection_requests): Likewise.
2113 (x_get_window_property): Don't truncate byte count to an 'int'
2114 when tracing.
0b432f21 2115
5e073ec7
PE
2116 * frame.c (frame_name_fnn_p): Get rid of strtol, which isn't right
2117 here, since it parses constructs like leading '-' and spaces,
2118 which are not wanted; and it overflows with large numbers.
2119 Instead, simply match F[0-9]+, which is what is wanted anyway.
2120
36372bf9
PE
2121 * alloc.c: Remove unportable assumptions about struct layout.
2122 (SDATA_SELECTOR, SDATA_DATA_OFFSET): New macros.
2123 (SDATA_OF_STRING, SDATA_SIZE, allocate_string_data):
2124 (allocate_vectorlike, make_pure_vector): Use the new macros,
2125 plus offsetof, to remove unportable assumptions about struct layout.
2126 These assumptions hold on all porting targets that I know of, but
2127 they are not guaranteed, they're easy to remove, and removing them
2128 makes further changes easier.
2129
0b432f21
PE
2130 * alloc.c (BLOCK BYTES): Fix typo by changing "ablock" to "ablocks".
2131 This doesn't fix a bug but makes the code clearer.
bfd1c781
PE
2132 (string_overrun_cookie): Now const. Use initializers that
2133 don't formally overflow signed char, to avoid warnings.
000098c1
PE
2134 (allocate_string_data) [GC_CHECK_STRING_OVERRUN]: Fix typo that
2135 can cause Emacs to crash when string overrun checking is enabled.
c7bda33c
PE
2136 (allocate_buffer): Don't assume sizeof (struct buffer) is a
2137 multiple of sizeof (EMACS_INT); it need not be, if
2138 alignof(EMACS_INT) < sizeof (EMACS_INT).
d0f4e1f5 2139 (check_sblock, check_string_bytes, check_string_free_list): Protoize.
0b432f21 2140
895009e1
JB
21412011-04-26 Juanma Barranquero <lekktu@gmail.com>
2142
2143 * keyboard.c (QCrtl): Rename from Qrtl. All uses changed.
2144
6a7a1b0b
TZ
21452011-04-26 Teodor Zlatanov <tzz@lifelogs.com>
2146
2147 * gnutls.c (emacs_gnutls_handshake): Return an error if we're not
b5f869a7 2148 supposed to be handshaking. (Bug#8556)
6a7a1b0b
TZ
2149 Reported by Paul Eggert <eggert@cs.ucla.edu>.
2150
841a1577 21512011-04-26 Daniel Colascione <dan.colascione@gmail.com>
0438ce91
DC
2152
2153 * lisp.h (Qdebug): List symbol.
895009e1 2154 * eval.c (Qdebug): Restore global linkage.
0438ce91
DC
2155 * keyboard.c (debug-on-event): New variable.
2156 (handle_user_signal): Break into debugger when debug-on-event
2157 matches the current signal symbol.
2158
f2d3ba6f
DN
21592011-04-25 Dan Nicolaescu <dann@ics.uci.edu>
2160
2161 * alloc.c (check_sblock, check_string_bytes)
2162 (check_string_free_list): Convert to standard C.
2163
42ce4c63
TZ
21642011-04-25 Teodor Zlatanov <tzz@lifelogs.com>
2165
2166 * w32.c (emacs_gnutls_push): Fix typo.
2167
825cd63c
EZ
21682011-04-25 Eli Zaretskii <eliz@gnu.org>
2169
fb11d64d
EZ
2170 * gnutls.c (emacs_gnutls_handshake): Avoid compiler warnings about
2171 "cast to pointer from integer of different size".
2172
825cd63c
EZ
2173 Improve doprnt and its use in verror. (Bug#8545)
2174 * doprnt.c (doprnt): Document the set of format control sequences
2175 supported by the function. Use SAFE_ALLOCA instead of always
2176 using `alloca'.
2177
2178 * eval.c (verror): Don't limit the buffer size at size_max-1, that
2179 is one byte too soon. Don't use xrealloc; instead xfree and
2180 xmalloc anew.
2181
e061a11b
TZ
21822011-04-24 Teodor Zlatanov <tzz@lifelogs.com>
2183
2184 * gnutls.h: Add GNUTLS_STAGE_CALLBACKS enum to denote we're in the
2185 callbacks stage.
2186
2187 * gnutls.c: Renamed global_initialized to
2188 gnutls_global_initialized. Added internals for the
2189 :verify-hostname-error, :verify-error, and :verify-flags
2190 parameters of `gnutls-boot' and documented those parameters in the
2191 docstring. Start callback support.
2192 (emacs_gnutls_handshake): Add Woe32 support. Retry handshake
2193 unless a fatal error occured. Call gnutls_alert_send_appropriate
2194 on error. Return error code.
2195 (emacs_gnutls_write): Call emacs_gnutls_handle_error.
2196 (emacs_gnutls_read): Likewise.
2197 (Fgnutls_boot): Return handshake error code.
2198 (emacs_gnutls_handle_error): New function.
2199 (wsaerror_to_errno): Likewise.
2200
2201 * w32.h (emacs_gnutls_pull): Add prototype.
2202 (emacs_gnutls_push): Likewise.
2203
2204 * w32.c (emacs_gnutls_pull): New function for GnuTLS on Woe32.
2205 (emacs_gnutls_push): Likewise.
2206
22072011-04-24 Claudio Bley <claudio.bley@gmail.com> (tiny change)
2208
2209 * process.c (wait_reading_process_output): Check if GnuTLS
2210 buffered some data internally if no FDs are set for TLS
2211 connections.
2212
2213 * makefile.w32-in (OBJ2): Add gnutls.$(O).
2214 (LIBS): Link to USER_LIBS.
2215 ($(BLD)/gnutls.$(0)): New target.
2216
fa6996bc
EZ
22172011-04-24 Eli Zaretskii <eliz@gnu.org>
2218
eb35682e
EZ
2219 * xdisp.c (handle_single_display_spec): Rename the
2220 display_replaced_before_p argument into display_replaced_p, to
2221 make it consistent with the commentary. Fix typos in the
2222 commentary.
2223
e2ad650c
EZ
2224 * textprop.c (syms_of_textprop): Remove dead code.
2225 (copy_text_properties): Delete obsolete commentary about an
2226 interface that was deleted long ago. Fix typos in the description
2227 of arguments.
2228
1b2de274
EZ
2229 * msdos.c (XMenuActivate, XMenuAddSelection): Adjust argument list
2230 to changes in oldXMenu/XMenu.h from 2011-04-16.
2231 <menu_help_message, prev_menu_help_message>: Constify.
2232 (IT_menu_make_room): menu->help_text is now `const char **';
2233 adjust.
2234
2235 * msdos.h (XMenuActivate, XMenuAddSelection): Adjust prototypes
2236 to changes in oldXMenu/XMenu.h from 2011-04-16.
2237 (struct XMenu): Declare `help_text' `const char **'.
2238
2239 * xfaces.c <Qunspecified>: Make extern again.
2240
2241 * syntax.c: Include sys/types.h before including regex.h, as
2242 required by Posix.
2243
762b15be
EZ
2244 * doc.c (get_doc_string): Improve the format passed to `error'.
2245
2246 * doprnt.c (doprnt): Improve commentary.
2247
2248 * term.c (init_tty) [MSDOS]: Fix 1st argument to maybe_fatal.
2249
2250 * Makefile.in (TAGS): Depend on $(M_FILE) and $(S_FILE), and scan
2251 them with etags.
2252
f1052e5d
EZ
2253 * makefile.w32-in (globals.h): Add a dummy recipe, to make any
2254 changes in globals.h immediately force recompilation.
762b15be
EZ
2255 (TAGS): Depend on $(CURDIR)/m/intel386.h and
2256 $(CURDIR)/s/ms-w32.h.
2257 (TAGS-gmake): Scan $(CURDIR)/m/intel386.h and $(CURDIR)/s/ms-w32.h.
f1052e5d 2258
fa6996bc
EZ
2259 * character.c (Fchar_direction): Function deleted.
2260 (syms_of_character): Don't defsubr it.
2261 <char-direction-table>: Deleted.
2262
e6c3da20
EZ
22632011-04-23 Eli Zaretskii <eliz@gnu.org>
2264
2265 Fix doprnt so it could be used again safely in `verror'. (Bug#8435)
2266 * doprnt.c: Include limits.h.
2267 (SIZE_MAX): New macro.
04f2d78b
CB
2268 (doprnt): Return a size_t value. 2nd arg is now size_t.
2269 Many local variables are now size_t instead of int or unsigned.
e6c3da20
EZ
2270 Improve overflow protection. Support `l' modifier for integer
2271 conversions. Support %l conversion. Don't assume an EMACS_INT
2272 argument for integer conversions and for %c.
2273
2274 * lisp.h (doprnt): Restore prototype.
2275
2276 * makefile.w32-in ($(BLD)/callint.$(O)): Depend on
2277 $(SRC)/character.h.
2278
2279 * Makefile.in (base_obj): Add back doprnt.o.
2280
2281 * deps.mk (doprnt.o): Add back prerequisites.
2282 (callint.o): Depend on character.h.
2283
2284 * eval.c (internal_lisp_condition_case): Include the handler
2285 representation in the error message.
2286 (verror): Call doprnt instead of vsnprintf. Fix an off-by-one bug
2287 when breaking from the loop.
2288
2289 * xdisp.c (vmessage): Call doprnt instead of vsnprintf.
2290
2291 * callint.c (Fcall_interactively): When displaying error message
2292 about invalid control letter, pass the character's codepoint, not
2293 a pointer to its multibyte form. Improve display of the character
2294 in octal and display also its hex code.
2295
2296 * character.c (char_string): Use %x to display the (unsigned)
2297 codepoint of an invalid character, to avoid displaying a bogus
2298 negative value.
2299
2300 * font.c (check_otf_features): Pass SDATA of SYMBOL_NAME to
2301 `error', not SYMBOL_NAME itself.
2302
2303 * coding.c (Fencode_sjis_char, Fencode_big5_char): Use %c for
2304 character arguments to `error'.
2305
2306 * charset.c (check_iso_charset_parameter): Fix incorrect argument
2307 to `error' in error message about FINAL_CHAR argument. Make sure
2308 FINAL_CHAR is a character, and use %c when it is passed as
2309 argument to `error'.
2310
4ffd0d6b 23112011-04-23 Eli Zaretskii <eliz@gnu.org>
97a93095
EZ
2312
2313 * s/ms-w32.h (localtime): Redirect to sys_localtime.
2314
2315 * w32.c: Include <time.h>.
2316 (sys_localtime): New function.
2317
4ffd0d6b 23182011-04-23 Chong Yidong <cyd@stupidchicken.com>
c17819f4
CY
2319
2320 * xdisp.c (init_xdisp): Initialize echo_area_window (Bug#6451).
2321
4ffd0d6b 2322 * buffer.c (syms_of_buffer): Doc fix (Bug#6902).
aac0c6e3 2323
4ffd0d6b 23242011-04-23 Samuel Thibault <sthibault@debian.org> (tiny change)
aac0c6e3 2325
4ffd0d6b
GM
2326 * sysdep.c (wait_for_termination): On GNU Hurd, kill returns -1 on
2327 zombies (Bug#8467).
aac0c6e3 2328
04c56954
EZ
23292011-04-19 Eli Zaretskii <eliz@gnu.org>
2330
2331 * syntax.h (SETUP_SYNTAX_TABLE_FOR_OBJECT): Fix setting of
2332 gl_state.e_property when gl_state.object is Qt.
2333
2334 * insdel.c (make_gap_larger): Remove limitation of buffer size
2335 to <= INT_MAX.
2336
16a43933
CY
23372011-04-18 Chong Yidong <cyd@stupidchicken.com>
2338
2339 * xdisp.c (lookup_glyphless_char_display)
2340 (produce_glyphless_glyph): Handle cons cell entry in
2341 glyphless-char-display.
2342 (Vglyphless_char_display): Document it.
2343
2344 * term.c (produce_glyphless_glyph): Handle cons cell entry in
2345 glyphless-char-display.
2346
4581706e
CY
23472011-04-17 Chong Yidong <cyd@stupidchicken.com>
2348
2349 * xdisp.c (get_next_display_element): Remove unnecessary ifdefs.
2350
2351 * termhooks.h (FRAME_WINDOW_P): Remove duplicated definitions.
2352
2353 * dispextern.h (FACE_SUITABLE_FOR_ASCII_CHAR_P): Add missing
2354 definition for no-X builds.
2355
4887c6e2 23562011-04-16 Paul Eggert <eggert@cs.ucla.edu>
764430a3 2357
fd35b6f9
PE
2358 Static checks with GCC 4.6.0 and non-default toolkits.
2359
5c1ccb01
PE
2360 * s/sol2-6.h, s/unixware.h (PTY_TTY_NAME_SPRINTF): Protoize decl.
2361
006c5daa
PE
2362 * process.c (keyboard_bit_set): Define only if SIGIO.
2363 (send_process_trap): Mark it with NO_RETURN if it doesn't return.
2364 (send_process): Repair possible setjmp clobbering.
2365
efc736d3
PE
2366 * s/usg5-4-common.h (SETUP_SLAVE_PTY): Don't pass extra arg to 'fatal'.
2367
4e2fe2e6
PE
2368 * eval.c: Include <stdio.h>, for vsnprintf on non-GNU/Linux hosts.
2369
f97334a2
PE
2370 * data.c (arith_error): Mark with NO_RETURN if it doesn't return.
2371
4e75f29d
PE
2372 * alloc.c (bytes_used_when_full, SPARE_MEMORY, BYTES_USED):
2373 Define only if needed.
2374
90efadd1
PE
2375 * sysdep.c (_FILE_OFFSET_BITS): Make this hack even uglier
2376 by pacifying GCC about it. Maybe it's time to retire it?
875975e9 2377 * xfaces.c (USG, __TIMEVAL__): Likewise.
90efadd1 2378
3c647824
PE
2379 * dispextern.h (struct redisplay_interface): Rename param
2380 to avoid shadowing.
e264f262 2381 * termhooks.h (struct terminal): Likewise.
761383f4 2382 * xterm.c (xembed_send_message): Likewise.
3c647824 2383
b58c5c4a
PE
2384 * insdel.c (make_gap_smaller): Define only if
2385 USE_MMAP_FOR_BUFFERS || REL_ALLOC || DOUG_LEA_MALLOC.
2386
cad59032
PE
2387 * keyboard.c (read_char): Make a var volatile so longjmp won't clobber
2388 it.
2389
c339dc2e
PE
2390 * emacs.c (MAX_HEAP_BSS_DIFF, my_edata): Move to where they're used,
2391 so that we aren't warned about unused symbols.
2392
91a3e27b
PE
2393 * xfns.c (Fx_file_dialog): Rename local to avoid shadowing.
2394
399c71d3 2395 * xdisp.c (x_produce_glyphs): Mark var as initialized (Bug#8512).
7a3fb125 2396
8ffc96f5
PE
2397 * xfns.c (x_real_positions): Mark locals as initialized.
2398
eef9bc79
PE
2399 * xmenu.c (xmenu_show): Don't use uninitialized vars.
2400
098db9dd
PE
2401 * xterm.c: Fix problems found by static analysis with other toolkits.
2402 (toolkit_scroll_bar_interaction): Define and use only if USE_X_TOOLKIT.
dda3aedd
PE
2403 (x_dispatch_event): Declare static if USE_GTK, and
2404 define if USE_GTK || USE_X_TOOLKIT.
098db9dd 2405 (SET_SAVED_BUTTON_EVENT): Define only if USE_X_TOOLKIT || USE_GTK.
dda3aedd 2406 * xterm.h (x_dispatch_event): Extern only if USE_X_TOOLKIT.
841a1577
JB
2407 * xterm.c, xterm.h (x_mouse_leave): Bring this function back, but only
2408 if defined HAVE_MENUS && !defined USE_X_TOOLKIT && !defined USE_GTK.
098db9dd 2409
eb18f6cc
PE
2410 * xmenu.c (menu_help_callback): Pointer type fixes.
2411 Use const pointers when pointing at readonly data. Avoid pointer
2412 signedness clashes.
2413 (FALSE): Remove unused macro.
2414 (update_frame_menubar): Remove unused decl.
2415
1fe72bf8
PE
2416 * xfns.c (Fx_hide_tip): Move locals to avoid shadowing.
2417
60d9e1db
PE
2418 * menu.c (push_submenu_start, push_submenu_end): Do not define unless
2419 USE_X_TOOLKIT || USE_GTK || HAVE_NS || defined HAVE_NTGUI.
2420 (single_menu_item): Rename local to avoid shadowing.
2421
39261c26
PE
2422 * keyboard.c (make_lispy_event): Remove unused local var.
2423
018c5e19
PE
2424 * frame.c, frame.h (x_get_resource_string): Bring this back, but
2425 only if HAVE_X_WINDOWS && !USE_X_TOOLKIT.
2426
63d2b86e
PE
2427 * bitmaps: Change bitmaps from unsigned char back to the X11
2428 compatible char. Avoid the old compiler warnings about
2429 out-of-range initializers by using, for example, '\xab' rather
2430 than 0xab.
2431
aefd87e1
PE
2432 * xgselect.c (xgselect_initialize): Check vs interface
2433 even if ! (defined (USE_GTK) || defined (HAVE_GCONF)).
2434
bf501fb9
PE
2435 * xmenu.c (xmenu_show): Rename parm to avoid shadowing.
2436
e9829fdf
PE
2437 * xterm.c (x_create_toolkit_scroll_bar): Use const * for pointers
2438 to read-only memory.
2439
1086c095
PE
2440 * fns.c (vector): Remove; this old hack is no longer needed.
2441
2baccd04 2442 * xsmfns.c (create_client_leader_window): Rename shadowing arg.
401f10cb 2443 Remove unused var.
dde42981 2444 (gdk_x11_set_sm_client_id) [!USE_GTK]: Don't define.
2baccd04 2445
72391843 2446 * xrdb.c (x_load_resources): Omit unused local.
3565b346 2447
436c16df 2448 * xfns.c (free_frame_menubar, atof): Remove duplicate decls.
8a94ea33 2449 (x_window): Rename locals to avoid shadowing.
dc5ddd85 2450 (USG): Use the kludged USG macro, to pacify gcc.
436c16df 2451
92bb796d 2452 * xterm.c (x_alloc_nearest_color_for_widget): Remove; unused.
bbbef9e1 2453 (x_term_init): Remove local to avoid shadowing.
92bb796d 2454
764430a3 2455 * xfns.c, xterm.c (_XEditResCheckMessages): Protoize decl.
4887c6e2
PE
2456
2457 * xdisp.c, dispextern.h (set_vertical_scroll_bar): Now extern if
2458 USE_TOOLKIT_SCROLL_BARS && !USE_GTK, as xterm.c needs it then.
2459
d1dfb56c
EZ
24602011-04-16 Eli Zaretskii <eliz@gnu.org>
2461
c4354cb4
EZ
2462 * gnutls.c (Fgnutls_boot): Don't pass Lisp_Object to `error'.
2463
d1dfb56c
EZ
2464 Fix regex.c, syntax.c and friends for buffers > 2GB.
2465 * syntax.h (struct gl_state_s): Declare character position members
2466 EMACS_INT.
2467
2468 * syntax.c (update_syntax_table): Declare 2nd argument EMACS_INT.
2469
04f2d78b
CB
2470 * textprop.c (verify_interval_modification, interval_of):
2471 Declare arguments EMACS_INT.
d1dfb56c
EZ
2472
2473 * intervals.c (adjust_intervals_for_insertion): Declare arguments
2474 EMACS_INT.
2475
2476 * intervals.h (CHECK_TOTAL_LENGTH): Cast to EMACS_INT, not `int'.
2477
2478 * indent.c (Fvertical_motion): Local variable it_start is now
2479 EMACS_INT.
2480
2481 * regex.c (re_match, re_match_2, re_match_2_internal)
2482 (bcmp_translate, regcomp, regexec, print_double_string)
2483 (group_in_compile_stack, re_search, re_search_2, regex_compile)
2484 (re_compile_pattern, re_exec): Declare arguments and local
2485 variables `size_t' and `ssize_t' and return values `regoff_t', as
2486 appropriate.
2487 (POP_FAILURE_REG_OR_COUNT) <pfreg>: Declare `long'.
2488 (CHECK_INFINITE_LOOP) <failure>: Declare `ssize_t'.
2489 <compile_stack_type>: `size' and `avail' are now `size_t'.
2490
2491 * regex.h <regoff_t>: Use ssize_t, not int.
2492 (re_search, re_search_2, re_match, re_match_2): Arguments that
2493 specify buffer/string position and length are now ssize_t and
2494 size_t. Return type is regoff_t.
2495
613052cd
BK
24962011-04-16 Ben Key <bkey76@gmail.com>
2497
2498 * nsfont.m: Fixed bugs in ns_get_family and
2499 ns_descriptor_to_entity that were caused by using free to
2500 deallocate memory blocks that were allocated by xmalloc (via
2501 xstrdup). This caused Emacs to crash when compiled with
2502 XMALLOC_OVERRUN_CHECK defined (when Emacs was configured with
2503 --enable-checking=xmallocoverrun). xfree is now used to
2504 deallocate these memory blocks.
2505
4170f62f 25062011-04-15 Paul Eggert <eggert@cs.ucla.edu>
3e047f51 2507
71b41406
PE
2508 * sysdep.c (emacs_read): Remove unnecessary check vs MAX_RW_COUNT.
2509
9587a89d
PE
2510 emacs_write: Accept and return EMACS_INT for sizes.
2511 See http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00514.html
2512 et seq.
2513 * gnutls.c, gnutls.h (emacs_gnutls_read, emacs_gnutls_write):
2514 Accept and return EMACS_INT.
2515 (emacs_gnutls_write): Return the number of bytes written on
2516 partial writes.
2517 * sysdep.c, lisp.h (emacs_read, emacs_write): Likewise.
273a5f82
PE
2518 (emacs_read, emacs_write): Remove check for negative size, as the
2519 Emacs source code has been audited now.
9587a89d
PE
2520 * sysdep.c (MAX_RW_COUNT): New macro, to work around kernel bugs.
2521 (emacs_read, emacs_write): Use it.
273a5f82
PE
2522 * process.c (send_process): Adjust to the new signatures of
2523 emacs_write and emacs_gnutls_write. Do not attempt to store
2524 a byte offset into an 'int'; it might overflow.
9587a89d 2525 See http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00483.html
273a5f82 2526
3e047f51
PE
2527 * sound.c: Don't assume sizes fit in 'int'.
2528 (struct sound_device.period_size, alsa_period_size):
9c3c56a7 2529 Return EMACS_INT, not int.
3e047f51 2530 (struct sound_device.write, vox_write, alsa_write):
9c3c56a7
PE
2531 Accept EMACS_INT, not int.
2532 (wav_play, au_play): Use EMACS_INT to store sizes and to
3e047f51
PE
2533 record read return values.
2534
cc39a9db
BK
25352011-04-15 Ben Key <bkey76@gmail.com>
2536
c9d0ec6d
JB
2537 * keyboard.c (Qundefined): Don't declare static since it is used
2538 in nsfns.m.
2539 * xfaces.c (Qbold, Qexpanded, Qitalic, Qcondensed): Don't declare
2540 static since they are used in nsfont.m.
cc39a9db 2541
6c60eb9f
SM
25422011-04-15 Stefan Monnier <monnier@iro.umontreal.ca>
2543
2544 * process.c (Qprocessp): Don't declare static.
2545 * lisp.h (Qprocessp): Declare again.
2546
7990b61a
JB
25472011-04-15 Juanma Barranquero <lekktu@gmail.com>
2548
2549 * font.c (Qopentype): Don't make static (used from w32uniscribe.c).
2550
5d4cb038
PE
25512011-04-14 Paul Eggert <eggert@cs.ucla.edu>
2552
8bd7b830 2553 Improve C-level modularity by making more things 'static'.
cd64ea1d 2554
e3b27b31
PE
2555 Don't publish debugger-only interfaces to other modules.
2556 * lisp.h (safe_debug_print, debug_output_compilation_hack):
2557 (verify_bytepos, count_markers): Move decls to the only modules
2558 that need them.
2559 * region-cache.h (pp_cache): Likewise.
2560 * window.h (check_all_windows): Likewise.
2561 * marker.c, print.c, region-cache.c, window.c: Decls moved here.
2562
5d4cb038
PE
2563 * sysdep.c (croak): Now static, if
2564 defined TIOCNOTTY || defined USG5 || defined CYGWIN.
2565 * syssignal.h (croak): Declare only if not static.
69003fd8
PE
2566
2567 * alloc.c (refill_memory_reserve): Now static if
2568 !defined REL_ALLOC || defined SYSTEM_MALLOC.
2569 * lisp.h (refill_memory_reserve): Declare only if not static.
93ea6e8f 2570
e87b6180
PE
2571 * xsettings.c, xsettings.h (xsettings_get_system_normal_font):
2572 Define only if USE_LUCID.
2573
ac64929e
PE
2574 * xrdb.c (x_customization_string, x_rm_string): Now static.
2575
6f37259d
PE
2576 * xmenu.c (x_menu_wait_for_event): Export only if USE_MOTIF.
2577 * xterm.h (x_menu_wait_for_event): Declare only if USE_MOTIF.
2578
1683e3ab
PE
2579 * xdisp.c (draw_row_with_mouse_face): Now static.
2580 * dispextern.h (draw_row_with_mouse_fave): Remove decl.
2581
de9c2632
PE
2582 * window.h (check_all_windows): Mark externally visible.
2583
2b96acb7
PE
2584 * window.c (window_deletion_count): Now static.
2585
2586 * undo.c: Make symbols static if they're not exported.
2587 (last_undo_buffer, last_boundary_position, pending_boundary):
2588 Now static.
2589
50436f33
PE
2590 * textprop.c (interval_insert_behind_hooks): Now static.
2591 (interval_insert_in_front_hooks): Likewise.
2592
64520e5c
PE
2593 * term.c: Make symbols static if they're not exported.
2594 (tty_turn_off_highlight, get_tty_terminal, max_frame_cols):
2595 (max_frame_lines, tty_set_terminal_modes):
2596 (tty_reset_terminal_modes, tty_turn_off_highlight):
2597 (get_tty_terminal): Now static.
2598 (term_mouse_moveto): Do not define if HAVE_WINDOW_SYSTEM.
2599 * termhooks.h (term_mouse_moveto): Do not declare if
8bd7b830 2600 HAVE_WINDOW_SYSTEM.
64520e5c
PE
2601 * dispextern.h (tty_set_terminal_modes, tty_reset_terminal_modes):
2602 (tty_turn_off_highlight, get_tty_terminal): Remove decls.
2603
1fa53021
PE
2604 * sysdep.c: Make symbols static if they're not exported.
2605 (emacs_get_tty, emacs_set_tty, old_fcntl_flags, old_fcntl_owner):
2606 Now static.
2607 (sigprocmask_set, full_mask): Remove; unused.
2608 (wait_debugging): Mark as visible.
2609 * syssignal.h (SIGFULLMASK, full_mask): Remove decls.
2610 * systty.h (emacs_get_tty, emacs_set_tty): Remove decls.
2611
d4b43b22
PE
2612 * syntax.c (syntax_temp): Define only if !__GNUC__.
2613
b7c513d0
PE
2614 * sound.c (current_sound_device, current_sound): Now static.
2615
989b29ad
PE
2616 * search.c (searchbufs, searchbuf_head): Now static.
2617
13a55a78
PE
2618 * scroll.c (scroll_cost): Remove; unused.
2619 * dispextern.h (scroll_cost): Remove decl.
2620
de68a1fc
PE
2621 * region-cache.h (pp_cache): Mark as externally visible.
2622
40ccffa6
PE
2623 * process.c: Make symbols static if they're not exported.
2624 (process_tick, update_tick, create_process, chan_process):
2625 (Vprocess_alist, proc_buffered_char, datagram_access):
2626 (fd_callback_data, send_process_frame, process_sent_to): Now static.
2627 (deactivate_process): Mark defn as static, as well as decl.
2628 * lisp.h (create_process): Remove decl.
2629 * process.h (chan_process, Vprocess_alist): Remove decls.
2630
ad64fc97
PE
2631 * print.c: Make symbols static if they're not exported.
2632 (print_depth, new_backquote_output, being_printed, print_buffer):
2633 (print_buffer_size, print_buffer_pos, print_buffer_pos_byte):
2634 (print_interval, print_number_index, initial_stderr_stream):
2635 Now static.
2636 * lisp.h (Fprinc): Remove decl.
2637 (debug_output_compilation_hack): Mark as externally visible.
2638
adddb265
PE
2639 * sysdep.c (croak): Move decl from here to syssignal.h.
2640 * syssignal.h (croak): Put it here, so the API can be checked when
2641 'croak' is called from dissociate_if_controlling_tty.
2642
1717ede2
PE
2643 * minibuf.c: Make symbols static if they're not exported.
2644 (minibuf_save_list, choose_minibuf_frame): Now static.
2645 * lisp.h (choose_minibuf_frame): Remove decl.
2646
fa5fb2bc
PE
2647 * lisp.h (verify_bytepos, count_markers): Mark as externally visible.
2648
1e3890d1
PE
2649 * lread.c: Make symbols static if they're not exported.
2650 (read_objects, initial_obarray, oblookup_last_bucket_number):
2651 Now static.
2652 (make_symbol): Remove; unused.
2653 * lisp.h (initial_obarray, make_symbol): Remove decls.
2654
8a1414fa
PE
2655 * keyboard.c: Make symbols static if they're not exported.
2656 (single_kboard, recent_keys_index, total_keys, recent_keys):
2657 (this_command_key_count_reset, raw_keybuf, raw_keybuf_count):
2658 (this_single_command_key_start, echoing, last_auto_save):
2659 (read_key_sequence_cmd, dribble, recursive_edit_unwind):
2660 (command_loop, echo_now, keyboard_init_hook, help_char_p):
2661 (quit_throw_to_read_char, command_loop_2, top_level_1, poll_timer):
2662 (Vlispy_mouse_stem, double_click_count):
2663 Now static.
2664 (force_auto_save_soon): Define only if SIGDANGER.
2665 (ignore_mouse_drag_p): Now static if
2666 !defined HAVE_WINDOW_SYSTEM || defined USE_GTK || defined HAVE_NS.
2667 (print_help): Remove; unused.
2668 (stop_character, last_timer_event): Mark as externally visible.
2669 * keyboard.h (ignore_mouse_drag_p): Declare only if
2670 defined HAVE_WINDOW_SYSTEM && !defined USE_GTK && !defined HAVE_NS.
2671 (echo_now, help_char_p, quit_throw_to_read_char): Remove decls.
2672 * lisp.h (echoing): Remove decl.
2673 (force_auto_save_soon): Declare only if SIGDANGER.
2674 * xdisp.c (redisplay_window): Simplify code, to make it more
2675 obvious that ignore_mouse_drag_p is not accessed if !defined
2676 USE_GTK && !defined HAVE_NS.
2677
93ea6e8f
PE
2678 * intervals.c: Make symbols static if they're not exported.
2679 (merge_properties_sticky, merge_interval_right, delete_interval):
2680 Now static.
2681 * intervals.h (merge_interval_right, delete_interval): Remove decls.
2682
77382fcc
PE
2683 * insdel.c: Make symbols static if they're not exported.
2684 However, leave prepare_to_modify_buffer alone. It's never
2685 called from outside this function, but that appears to be a bug.
2686 (combine_after_change_list, combine_after_change_buffer):
4889fc82 2687 (adjust_after_replace, signal_before_change): Now static.
77382fcc
PE
2688 (adjust_after_replace_noundo): Remove; unused.
2689 * lisp.h (adjust_after_replace, adjust_after_replace_noundo):
4889fc82 2690 (signal_before_change): Remove decls.
77382fcc 2691
9306c32e
PE
2692 * indent.c (val_compute_motion, val_vmotion): Now static.
2693
cd44d2eb
PE
2694 * image.c: Make symbols static if they're not exported.
2695 * dispextern.h (x_create_bitmap_from_xpm_data): Do not declare
2696 if USE_GTK.
2697 * image.c (x_create_bitmap_from_xpm_data): Do not define if USE_GTK.
2698 (xpm_color_cache, ct_table, ct_colors_allocated): Now static.
2699
ad9a7a06
PE
2700 * fringe.c (standard_bitmaps): Now static.
2701 (max_used_fringe_bitmap): Now static, unless HAVE_NS.
2702
81626931
PE
2703 * frame.c: Make symbols static if they're not exported.
2704 (x_report_frame_params, make_terminal_frame): Now static.
2705 (get_frame_param): Now static, unless HAVE_NS.
2706 (x_fullscreen_adjust): Define if WINDOWSNT, not if HAVE_WINDOW_SYSTEM.
2707 (x_get_resource_string): Remove; not used.
2708 * frame.h (make_terminal_frame, x_report_frame_params):
2709 (x_get_resource_string); Remove decls.
2710 (x_fullscreen_adjust): Declare only if WINDOWSNT.
2711 * lisp.h (get_frame_param): Declare only if HAVE_NS.
2712
239f9db9
PE
2713 * font.c, fontset.c: Make symbols static if they're not exported.
2714 * dispextern.h (FACE_SUITABLE_FOR_ASCII_CHAR_P): New macro.
2715 (FACE_SUITABLE_FOR_CHAR_P): Use it.
2716 * font.c (font_close_object): Now static.
2717 * font.h (font_close_object): Remove.
2718 * fontset.c (FONTSET_OBJLIST): Remove.
2719 (free_realized_fontset) #if-0 the body, which does nothing.
2720 (face_suitable_for_char_p): #if-0, as it's never called.
2721 * fontset.h (face_suitable_for_char_p): Remove decl.
04f2d78b
CB
2722 * xfaces.c (face_at_string_position):
2723 Use FACE_SUITABLE_FOR_ASCII_CHAR_P, not FACE_SUITABLE_FOR_CHAR_P,
239f9db9
PE
2724 since 0 is always ASCII.
2725
dfcf3579
PE
2726 * fns.c (weak_hash_tables): Now static.
2727
5045092b
PE
2728 * fileio.c: Make symbols static if they're not exported.
2729 (auto_saving, auto_save_mode_bits, auto_save_error_occurred):
2730 (Vwrite_region_annotation_buffers): Now static.
2731
57a96f5c
PE
2732 * eval.c: Make symbols static if they're not exported.
2733 (backtrace_list, lisp_eval_depth, when_entered_debugger): Now static.
2734 * lisp.h (backtrace_list): Remove decl.
2735
35f08c38
PE
2736 * emacs.c: Make symbols static if they're not exported.
2737 (malloc_state_ptr, malloc_using_checking, syms_of_emacs):
2738 (fatal_error_code, fatal_error_signal_hook, standard_args):
2739 Now static.
2740 (fatal_error_signal): Now static, unless FLOAT_CATCH_SIGKILL.
2741 (DEFINE_DUMMY_FUNCTION): Mark function as externally visible.
2742 (__CTOR_LIST__, __DTOR_LIST__): Now externally visible.
2743 * lisp.h (fatal_error_signal_hook): Remove decl.
2744 (fatal_error_signal): Declare only if FLOAT_CATCH_SIGKILL.
2745
f44bd759
PE
2746 * editfns.c: Move a (normally-unused) function to its only use.
2747 * editfns.c, lisp.h (get_operating_system_release): Remove.
2748 * process.c (init_process) [DARWIN_OS]: Do it inline, as it is not
2749 worth the hassle of breaking this out.
2750
b532497d
PE
2751 * xterm.c: Make symbols static if they're not exported.
2752 (x_raise_frame, x_lower_frame, x_wm_set_window_state):
2753 (x_wm_set_icon_pixmap, x_initialize, XTread_socket_fake_io_error):
2754 (x_destroy_window, x_delete_display):
2755 Now static.
2756 (x_dispatch_event): Now static if ! (USE_MOTIF || USE_X_TOOLKIT).
2757 (x_mouse_leave): Remove; unused.
2758 * xterm.h (x_display_info_for_name, x_raise_frame, x_lower_frame):
2759 (x_destroy_window, x_wm_set_window_state, x_wm_set_icon_pixmap):
2760 (x_delete_display, x_initialize, x_set_border_pixel, x_screen_planes):
2761 Remove decls.
2762 (x_mouse_leave): Declare only if WINDOWSNT.
2763 (x_dispatch_event): Declare only if USE_MOTIF or USE_X_TOOLKIT.
2764 (xic_create_fontsetname): Declare only if HAVE_X_WINDOWS &&
2765 USE_X_TOOLKIT.
2766
1675728f
PE
2767 * ftxfont.c: Make symbols static if they're not exported.
2768 (ftxfont_driver): Export only if !defined HAVE_XFT && def8ined
2769 HAVE_FREETYPE.
2770 * font.h (ftxfont_driver): Likewise.
2771
e4cebfca
PE
2772 * xfns.c: Make symbols static if they're not exported.
2773 (x_last_font_name, x_display_info_for_name):
2774 (x_set_foreground_color, x_set_background_color, x_set_mouse_color):
2775 (x_set_cursor_color, x_set_border_pixel, x_set_border_color):
2776 (x_set_cursor_type, x_set_icon_type, x_set_icon_name):
2777 (x_set_scroll_bar_foreground, x_set_scroll_bar_background):
2778 (x_explicitly_set_name, x_set_title, xic_defaut_fontset, tip_timer):
2779 (last_show_tip_args): Now static.
2780 (xic_defaut_fontset, xic_create_fontsetname): Define only if
2781 defined HAVE_X_WINDOWS && defined USE_X_TOOLKIT
2782 (x_screen_planes): Remove; unused.
2783 * dispextern.h (x_screen_planes): Remove decl.
2784
5bf46f05
PE
2785 * dispnew.c: Make symbols static if they're not exported.
2786 * dispextern.h (redraw_garbaged_frames, scrolling):
2787 (increment_row_positions): Remove.
2788 * dispnew.c (new_glyph_matrix, increment_row_positions, scrolling):
2789 (delayed_size_change, glyph_matrix_count, glyph_pool_count):
2790 Now static.
2791 (redraw_garbaged_frames): Remove; unused.
2792
435f4c28
PE
2793 * xfaces.c: Make symbols static if they're not exported.
2794 * dispextern.h (ascii_face_of_lisp_face, free_realized_face):
2795 Remove decls.
2796 * xterm.h (defined_color): Remove decls.
2797 (x_free_dpy_colors): Declare only if USE_X_TOOLKIT.
2798 * xfaces.c (tty_suppress_bold_inverse_default_colors_p):
2799 (menu_face_changed_default, defined_color, free_realized_face):
2800 (x_free_dpy_colors): Define only if USE_X_TOOLKIT.
2801 (ascii_face_of_lisp_face): Remove; unused.
2802
8524aef3
PE
2803 * xdisp.c: Make symbols static if they're not exported.
2804 * dispextern.h (scratch_glyph_row, window_box_edges):
2805 (glyph_to_pixel_coords, set_cursor_from_row):
2806 (get_next_display_element, set_iterator_to_next):
2807 (highlight_trailing_whitespace, frame_to_window_pixel_xy):
2808 (show_mouse_face): Remove decls
2809 * frame.h (message_buf_print): Likewise.
2810 * lisp.h (pop_message, set_message, check_point_in_composition):
2811 Likewise.
2812 * xterm.h (set_vertical_scroll_bar): Likewise.
2813 * xdisp.c (list_of_error, Vmessage_stack, line_number_displayed):
2814 (message_buf_print, scratch_glyph_row, displayed_buffer):
2815 (set_iterator_to_next, pop_message, set_message, set_cursor_from_row):
2816 (get_next_display_element, show_mouse_face, window_box_edges):
2817 (frame_to_window_pixel_xy, check_point_in_composition):
2818 (set_vertical_scroll_bar, highlight_trailing_whitespace): Now static.
2819 (glyph_to_pixel_coords): Remove; unused.
2820
16390cd2
PE
2821 * dired.c (file_name_completion): Now static.
2822
2823 * dbusbind.c (xd_in_read_queued_messages): Now static.
2824
a25f4dfa
PE
2825 * lisp.h (circular_list_error, FOREACH): Remove; unused.
2826 * data.c (circular_list_error): Remove.
2827
14a9c8df
PE
2828 * commands.h (last_point_position, last_point_position_buffer):
2829 (last_point_position_window): Remove decls.
2830 * keyboard.c: Make these variables static.
2831
04f2d78b
CB
2832 * coding.h (coding, code_convert_region, encode_coding_gap):
2833 Remove decls.
74ab6df5
PE
2834 * coding.c (Vsjis_coding_system, Vbig5_coding_system):
2835 (iso_code_class, detect_coding, code_convert_region): Now static.
2836 (encode_coding_gap): Remove; unused.
2837
38dfbee1
PE
2838 * chartab.c (chartab_chars, chartab_bits): Now static.
2839
a2cb4e63
PE
2840 * charset.h (charset_iso_8859_1): Remove decl.
2841 * charset.c (charset_iso_8859_1, charset_emacs, map_charset_for_dump):
2842 Now static.
2843
127198fd
PE
2844 * ccl.h (check_ccl_update, Vccl_program_table): Remove decls.
2845 * ccl.c (Vccl_program_table): Now static.
2846 (check_ccl_update): Remove; unused.
2847
d85b608f
PE
2848 * category.c (SET_CATEGORY_SET, set_category_set): Move here.
2849 * category.h: ... from here.
2850 * category.c (check_category_table, set_category_set): Now static.
2851
31cd66f3
PE
2852 * casetab.c (Vascii_upcase_table, Vascii_eqv_table): Now static.
2853 * lisp.h: Remove these decls.
2854
c358e587
PE
2855 * buffer.c (buffer_count): Remove unused var.
2856
e78aecca
PE
2857 * bidi.c (bidi_dump_cached_states): Mark as externally visible,
2858 so that it's not optimized away.
2859 (bidi_ignore_explicit_marks_for_paragraph_level): Likewise.
2860 * dispextern.h (bidi_dump_cached_states): Remove, since it's
2861 exported only to the debugger.
2862
e192d7d3 2863 * atimer.c (alarm_signal_handler, run_all_atimers): Now static.
04f2d78b 2864 * atimer.h (run_all_atimers): Remove; not exported.
e192d7d3 2865
92470028
PE
2866 font.c: Make copy_font_spec and merge_font_spec ordinary C functions.
2867 * font.c (copy_font_spec): Rename from Fcopy_font_spec, since it
2868 was inaccessible from Lisp.
2869 (merge_font_spec): Likewise, renaming from Fmerge_font_spec.
2870 * font.c, font.h, fontset.c, xfaces.c, xfont.c: Change all uses.
2871
244ed907
PE
2872 alloc.c: Import and export fewer symbols, and remove unused items.
2873 * lisp.h (suppress_checking, die): Declare only if ENABLE_CHECKING
2874 is defined.
2875 (suppress_checking): Add EXTERNALLY_VISIBLE attribute, so that
2876 it's not optimized away by whole-program optimization.
2877 (message_enable_multibyte, free_misc): Remove.
2878 (catchlist, handlerlist, mark_backtrace):
2879 Declare only if BYTE_MARK_STACK.
2880 (mark_byte_stack): Likewise, fixing a ifdef-vs-if typo.
2881 * alloc.c (pure): Export only if VIRT_ADDR_VARIES is defined.
2882 (message_enable_multibyte): Remove decl.
2883 (free_misc, interval_free_list, float_block, float_block_index):
2884 (n_float_blocks, float_free_list, cons_block, cons_block_index):
2885 (cons_free_list, last_marked_index):
2886 Now static.
2887 (suppress_checking, die): Define only if ENABLE_CHECKING is defined.
2888 * eval.c (catchlist, handlerlist): Export only if BYTE_MARK_STACK.
2889 (mark_backtrace): Define only if BYTE_MARK_STACK.
2890 * xdisp.c (message_enable_multibyte): Now static.
2891
61c2b50e 2892 Declare Lisp_Object Q* variables to be 'static' if not exported.
955cbe7b
PE
2893 This makes it easier for human readers (and static analyzers)
2894 to see whether these variables are used from other modules.
2895 * alloc.c, buffer.c, bytecode.c, callint.c, casetab.c, category.c:
2896 * ccl.c, character.c, charset.c, cmds.c, coding.c, composite.c:
2897 * data.c, dbusbind.c, dired.c, editfns.c, eval.c, fileio.c, fns.c:
2898 * font.c, frame.c, fringe.c, ftfont.c, image.c, keyboard.c, keymap.c:
2899 * lread.c, macros.c, minibuf.c, print.c, process.c, search.c:
2900 * sound.c, syntax.c, textprop.c, window.c, xdisp.c, xfaces.c, xfns.c:
2901 * xmenu.c, xselect.c:
2902 Declare Q* vars static if they are not used in other modules.
2903 * ccl.h, character.h, charset.h, coding.h, composite.h, font.h:
2904 * frame.h, intervals.h, keyboard.h, lisp.h, process.h, syntax.h:
2905 Remove decls of unexported vars.
2906 * keyboard.h (EVENT_HEAD_UNMODIFIED): Remove now-unused macro.
2907
95c82688
PE
2908 * lisp.h (DEFINE_FUNC): Make sname 'static'.
2909
16a97296
PE
2910 Make Emacs functions such as Fatom 'static' by default.
2911 This makes it easier for human readers (and static analyzers)
2912 to see whether these functions can be called from other modules.
2913 DEFUN now defines a static function. To make the function external
2914 so that it can be used in other C modules, use the new macro DEFUE.
8bd7b830
PE
2915 * lisp.h (Funibyte_char_to_multibyte, Fsyntax_table_p):
2916 (Finit_image_library):
16a97296
PE
2917 (Feval_region, Fbacktrace, Ffetch_bytecode, Fswitch_to_buffer):
2918 (Ffile_executable_p, Fmake_symbolic_link, Fcommand_execute):
2919 (Fget_process, Fdocumentation_property, Fbyte_code, Ffile_attributes):
2920 Remove decls, since these functions are now static.
2921 (Funintern, Fget_internal_run_time): New decls, since these functions
2922 were already external.
95c82688 2923
16a97296
PE
2924 * alloc.c, buffer.c, callint.c, callproc.c, casefiddle.c, casetab.c:
2925 * ccl.c, character.c, chartab.c, cmds.c, coding.c, data.c, dispnew.c:
2926 * doc.c, editfns.c, emacs.c, eval.c, fileio.c, filelock.c, floatfns.c:
2927 * fns.c, font.c, fontset.c, frame.c, image.c, indent.c:
2928 * keyboard.c, keymap.c, lread.c:
2929 * macros.c, marker.c, menu.c, minibuf.c, print.c, process.c, search.c:
2930 * syntax.c, term.c, terminal.c, textprop.c, undo.c:
2931 * window.c, xdisp.c, xfaces.c, xfns.c, xmenu.c, xsettings.c:
2932 Mark functions with DEFUE instead of DEFUN,
2933 if they are used in other modules.
2934 * buffer.c (Fset_buffer_major_mode, Fdelete_overlay): New forward
2935 decls for now-static functions.
2936 * buffer.h (Fdelete_overlay): Remove decl.
2937 * callproc.c (Fgetenv_internal): Mark as internal.
2938 * composite.c (Fremove_list_of_text_properties): Remove decl.
2939 (Fcomposition_get_gstring): New forward static decl.
2940 * composite.h (Fcomposite_get_gstring): Remove decl.
2941 * dired.c (Ffile_attributes): New forward static decl.
2942 * doc.c (Fdocumntation_property): New forward static decl.
2943 * eval.c (Ffetch_bytecode): New forward static decl.
2944 (Funintern): Remove extern decl; now in .h file where it belongs.
2945 * fileio.c (Fmake_symbolic_link): New forward static decl.
2946 * image.c (Finit_image_library): New forward static decl.
2947 * insdel.c (Fcombine_after_change_execute): Make forward decl static.
2948 * intervals.h (Fprevious_property_change):
2949 (Fremove_list_of_text_properties): Remove decls.
2950 * keyboard.c (Fthis_command_keys): Remove decl.
2951 (Fcommand_execute): New forward static decl.
2952 * keymap.c (Flookup_key): New forward static decl.
2953 (Fcopy_keymap): Now static.
2954 * keymap.h (Flookup_key): Remove decl.
2955 * process.c (Fget_process): New forward static decl.
2956 (Fprocess_datagram_address): Mark as internal.
2957 * syntax.c (Fsyntax_table_p): New forward static decl.
2958 (skip_chars): Remove duplicate decl.
2959 * textprop.c (Fprevious_property_change): New forward static decl.
2960 * window.c (Fset_window_fringes, Fset_window_scroll_bars):
2961 Now internal.
2962 (Fset_window_margins, Fset_window_vscroll): New forward static decls.
2963 * window.h (Fset_window_vscroll, Fset_window_margins): Remove decls.
2964
785bbd42
PE
2965 * editfns.c (Fformat): Remove unreachable code.
2966
8b913b57
AS
29672011-04-14 Andreas Schwab <schwab@linux-m68k.org>
2968
2969 * fileio.c (Finsert_file_contents): Fix typo in 2005-05-13
2970 change. (Bug#8496)
2971
a6744a35
EZ
29722011-04-13 Eli Zaretskii <eliz@gnu.org>
2973
2974 * xdisp.c (handle_invisible_prop): Don't call bidi_paragraph_init
2975 when at ZV. (Bug#8487)
2976
e7974947
AS
29772011-04-12 Andreas Schwab <schwab@linux-m68k.org>
2978
baad03f0
AS
2979 * charset.c (Fclear_charset_maps): Use xfree instead of free.
2980 (Bug#8437)
2981 * keyboard.c (parse_tool_bar_item): Likewise.
2982 * sound.c (sound_cleanup, alsa_close): Likewise.
2983 * termcap.c (tgetent): Likewise.
2984 * xfns.c (x_default_font_parameter): Likewise.
2985 * xsettings.c (read_and_apply_settings): Likewise.
2986
e7974947
AS
2987 * alloc.c (overrun_check_malloc, overrun_check_realloc)
2988 (overrun_check_free): Protoize.
2989
28272684
PE
29902011-04-12 Paul Eggert <eggert@cs.ucla.edu>
2991
2992 * sysdep.c (emacs_read, emacs_write): Check for negative sizes
2993 since callers should never pass a negative size.
2994 Change the signature to match that of plain 'read' and 'write'; see
2995 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00397.html>.
2996 * lisp.h: Update prototypes of emacs_write and emacs_read.
2997
11997c76
EZ
29982011-04-11 Eli Zaretskii <eliz@gnu.org>
2999
3000 * xdisp.c (redisplay_window): Don't try to determine the character
3001 position of the scroll margin if the window start point w->startp
e896f03c 3002 is outside the buffer's accessible region. (Bug#8468)
11997c76 3003
8a2cbd72
EZ
30042011-04-10 Eli Zaretskii <eliz@gnu.org>
3005
3006 Fix write-region and its subroutines for buffers > 2GB.
3007 * fileio.c (a_write, e_write): Modify declaration of arguments and
3008 local variables to support buffers larger than 2GB.
3009 (Fcopy_file): Use EMACS_INT for return value of emacs_read.
3010
3011 * sysdep.c (emacs_write, emacs_read): Use ssize_t for last
3012 argument, local variables, and return value.
3013
3014 * lisp.h: Update prototypes of emacs_write and emacs_read.
3015
3016 * sound.c (vox_write): Use ssize_t for return value of emacs_write.
3017
4073e537 30182011-04-10 Paul Eggert <eggert@cs.ucla.edu>
eb3f1cc8 3019
1ebfdcb6
PE
3020 * xdisp.c (vmessage): Use memchr, not strnlen, which some hosts lack.
3021
b2ded58d
PE
3022 Fix more problems found by GCC 4.6.0's static checks.
3023
7d66342c
PE
3024 * xdisp.c (vmessage): Use a better test for character truncation.
3025
bbf47d44
PE
3026 * charset.c (load_charset_map): <, not <=, for optimization,
3027 and to avoid potential problems with integer overflow.
9248994d 3028 * chartab.c (sub_char_table_set_range, char_table_set_range): Likewise.
f9a68bc5 3029 * casetab.c (set_identity, shuffle): Likewise.
3ab1c7ce 3030 * editfns.c (Fformat): Likewise.
1e69125e 3031 * syntax.c (skip_chars): Likewise.
3befa583 3032
e3019616
PE
3033 * xmenu.c (set_frame_menubar): Allocate smaller local vectors.
3034 This also lets GCC 4.6.0 generate slightly better loop code.
3035
becfa255
PE
3036 * callint.c (Fcall_interactively): <, not <=, for optimization.
3037 (Fcall_interactively): Count the number of arguments produced,
3038 not the number of arguments given. This is simpler and lets GCC
3039 4.6.0 generate slightly better code.
3040
dae0cd48
PE
3041 * ftfont.c: Distingish more carefully between FcChar8 and char.
3042 The previous code passed unsigned char * to a functions like
3043 strlen and xstrcasecmp that expect char *, which does not
3044 conform to the C standard.
3045 (get_adstyle_property, ftfont_pattern_entity): Use FcChar8 for
3046 arguments to FcPatternGetString, and explicitly cast FcChar8 * to
3047 char * when the C standard requires it.
3048
76032d70
PE
3049 * keyboard.c (read_char): Remove unused var.
3050
eb3f1cc8
PE
3051 * eval.c: Port to Windows vsnprintf (Bug#8435).
3052 Include <limits.h>.
3053 (SIZE_MAX): Define if the headers do not.
3054 (verror): Do not give up if vsnprintf returns a negative count.
3055 Instead, grow the buffer. This ports to Windows vsnprintf, which
3056 does not conform to C99. Problem reported by Eli Zaretskii.
3057 Also, simplify the allocation scheme, by avoiding the need for
3058 calling realloc, and removing the ALLOCATED variable.
3059
70476b54
PE
3060 * eval.c (verror): Initial buffer size is 4000 (not 200) bytes.
3061
12020a9e
PE
3062 Remove invocations of doprnt, as Emacs now uses vsnprintf.
3063 But keep the doprint source code for now, as we might revamp it
3064 and use it again (Bug#8435).
ea6c7ae6
PE
3065 * lisp.h (doprnt): Remove.
3066 * Makefile.in (base_obj): Remove doprnt.o.
3067 * deps.mk (doprnt.o): Remove.
3068
5fdb398c
PE
3069 error: Print 32- and 64-bit integers portably (Bug#8435).
3070 Without this change, on typical 64-bit hosts error ("...%d...", N)
3071 was used to print both 32- and 64-bit integers N, which relied on
3072 undefined behavior.
3073 * lisp.h, src/m/amdx86-64.h, src/m/ia64.h, src/m/ibms390x.h (pEd):
3074 New macro.
3075 * lisp.h (error, verror): Mark as printf-like functions.
3076 * eval.c (verror): Use vsnprintf, not doprnt, to do the real work.
3077 Report overflow in size calculations when allocating printf buffer.
3078 Do not truncate output string at its first null byte.
3079 * xdisp.c (vmessage): Use vsnprintf, not doprnt, to do the real work.
3080 Truncate the output at a character boundary, since vsnprintf does not
3081 do that.
3082 * charset.c (check_iso_charset_parameter): Convert internal
3083 character to string before calling 'error', since %c now has the
3084 printf meaning.
3085 * coding.c (Fdecode_sjis_char, Fdecode_big5_char): Avoid int
3086 overflow when computing char to be passed to 'error'. Do not
3087 pass Lisp_Object to 'error'; pass the integer instead.
3088 * nsfns.m (Fns_do_applescript): Use int, not long, since it's
3089 formatted with plain %d.
3090
b189fa66
PE
3091 * eval.c (internal_lisp_condition_case): Don't pass spurious arg.
3092
bff87ef0
PE
3093 * keyboard.c (access_keymap_keyremap): Print func name, not garbage.
3094
7e2cac20
PE
3095 * coding.c (Fdecode_sjis_char): Don't assume CODE fits in int.
3096
ce4d90b5
PE
3097 * xterm.c (x_catch_errors): Remove duplicate declaration.
3098
266c9547
PE
3099 * term.c (maybe_fatal): Mark its 3rd arg as a printf format, too.
3100
79c49ad2
PE
3101 * xdisp.c, lisp.h (message_nolog): Remove; unused.
3102
368f4090
JM
31032011-04-10 Jim Meyering <meyering@redhat.com>
3104
3105 use ssize_t and size_t for read- and write-like emacs_gnutls_* functions
3106 * gnutls.c (emacs_gnutls_read): Adjust signature to be more read-like:
3107 return ssize_t not "int", and use size_t as the buffer length.
3108 (emacs_gnutls_write): Likewise, and make the buffer pointer "const".
3109 * gnutls.h: Update declarations.
3110 * process.c (read_process_output): Use ssize_t, to match.
3111 (send_process): Likewise.
3112
a32d4040
CY
31132011-04-09 Chong Yidong <cyd@stupidchicken.com>
3114
3115 * image.c (Fimagemagick_types): Doc fix, and comment cleanup.
3116
8546720e 31172011-04-09 Chong Yidong <cyd@stupidchicken.com>
aac0c6e3 3118
04f2d78b
CB
3119 * ftfont.c (get_adstyle_property, ftfont_pattern_entity):
3120 Use unsigned char, to match FcChar8 type definition.
aac0c6e3 3121
8546720e
GM
3122 * xterm.c (handle_one_xevent):
3123 * xmenu.c (create_and_show_popup_menu):
3124 * xselect.c (x_decline_selection_request)
3125 (x_reply_selection_request): Avoid type-punned deref of X events.
aac0c6e3 3126
0a2f5c1a 31272011-04-09 Eli Zaretskii <eliz@gnu.org>
a53e2e89
EZ
3128
3129 Fix some uses of `int' instead of EMACS_INT.
3130 * search.c (string_match_1, fast_string_match)
3131 (fast_c_string_match_ignore_case, fast_string_match_ignore_case)
3132 (scan_buffer, find_next_newline_no_quit)
3133 (find_before_next_newline, search_command, Freplace_match)
3134 (Fmatch_data): Make some `int' variables be EMACS_INT.
3135
3136 * xdisp.c (display_count_lines): 3rd argument and return value now
3137 EMACS_INT. All callers changed.
3138 (pint2hrstr): Last argument is now EMACS_INT.
3139
3140 * coding.c (detect_coding_utf_8, detect_coding_emacs_mule)
3141 (detect_coding_iso_2022, detect_coding_sjis, detect_coding_big5)
3142 (detect_coding_ccl, detect_coding_charset, decode_coding_utf_8)
3143 (decode_coding_utf_16, decode_coding_emacs_mule)
3144 (decode_coding_iso_2022, decode_coding_sjis, decode_coding_big5)
3145 (decode_coding_ccl, decode_coding_charset)
3146 <consumed_chars, consumed_chars_base>: Declare EMACS_INT.
3147 (decode_coding_iso_2022, decode_coding_emacs_mule)
3148 (decode_coding_sjis, decode_coding_big5, decode_coding_charset)
3149 <char_offset, last_offset>: Declare EMACS_INT.
3150 (encode_coding_utf_8, encode_coding_utf_16)
3151 (encode_coding_emacs_mule, encode_invocation_designation)
3152 (encode_designation_at_bol, encode_coding_iso_2022)
3153 (encode_coding_sjis, encode_coding_big5, encode_coding_ccl)
3154 (encode_coding_raw_text, encode_coding_charset) <produced_chars>:
3155 Declare EMACS_INT.
3156 (ASSURE_DESTINATION): Declare more_bytes EMACS_INT.
3157 (encode_invocation_designation): Last argument P_NCHARS is now
3158 EMACS_INT.
3159 (decode_eol): Declare pos_byte, pos, and pos_end EMACS_INT.
3160 (produce_chars): from_nchars and to_nchars are now EMACS_INT.
3161
3162 * coding.h (struct coding_system) <head_ascii>: Declare EMACS_INT.
3163 All users changed.
3164
3165 * ccl.c (Fccl_execute_on_string): Declare some variables
3166 EMACS_INT.
3167
8546720e 31682011-04-08 Samuel Thibault <sthibault@debian.org> (tiny change)
0080dc6b
SS
3169
3170 * term.c (init_tty): Fix incorrect ifdef placement (Bug#8450).
3171
4e19a977
CS
31722011-03-19 Christoph Scholtes <cschol2112@googlemail.com>
3173
3174 * process.c (Fformat_network_address): Doc fix.
3175
87302331
R
31762011-04-08 T.V. Raman <tv.raman.tv@gmail.com> (tiny change)
3177
3178 * xml.c (parse_region): Avoid creating spurious whiespace nodes.
3179
cbb59342
CY
31802011-04-08 Chong Yidong <cyd@stupidchicken.com>
3181
3182 * keyboard.c (read_char): Call Lisp function help-form-show,
3183 instead of using internal_with_output_to_temp_buffer.
3184 (Qhelp_form_show): New var.
e0d38eeb 3185 (syms_of_keyboard): Use DEFSYM macro.
cbb59342
CY
3186
3187 * print.c (internal_with_output_to_temp_buffer): Function deleted.
3188
3189 * lisp.h (internal_with_output_to_temp_buffer): Remove prototype.
3190
e67a13ab
CY
31912011-04-06 Chong Yidong <cyd@stupidchicken.com>
3192
04f2d78b
CB
3193 * process.c (Flist_processes): Remove to Lisp.
3194 (list_processes_1): Delete.
e67a13ab 3195
973f782d
EZ
31962011-04-06 Eli Zaretskii <eliz@gnu.org>
3197
7c106b1e
EZ
3198 * msdos.c (careadlinkat, careadlinkatcwd): MS-DOS replacements.
3199
973f782d
EZ
3200 * w32.c (careadlinkat, careadlinkatcwd): New always-fail stubs.
3201
41cf7d1a 32022011-04-06 Paul Eggert <eggert@cs.ucla.edu>
27ccc379 3203
ca23cc88
PE
3204 Fix more problems found by GCC 4.6.0's static checks.
3205
f390e2d5
PE
3206 * xmenu.c (Fx_popup_dialog): Don't assume string is free of formats.
3207
42eea0d0
PE
3208 * menu.c (Fx_popup_menu): Don't assume error_name lacks printf formats.
3209
b69769da 3210 * lisp.h (message, message_nolog, fatal): Mark as printf-like.
1e973bc7 3211
f9541e84
PE
3212 * xdisp.c (vmessage): Mark as a printf-like function.
3213
13841b55
PE
3214 * term.c (vfatal, maybe_fatal): Mark as printf-like functions.
3215
c136c10f
PE
3216 * sound.c (sound_warning): Don't crash if arg contains a printf format.
3217
5e2d4a30
PE
3218 * image.c (tiff_error_handler, tiff_warning_handler): Mark as
3219 printf-like functions.
3220 (tiff_load): Add casts to remove these marks before passing them
3221 to system-supplied API.
3222
583f48b9
PE
3223 * eval.c (Fsignal): Remove excess argument to 'fatal'.
3224
b25d760e
PE
3225 * coding.c (EMIT_ONE_BYTE, EMIT_TWO_BYTES): Use unsigned, not int.
3226 This avoids several warnings with gcc -Wstrict-overflow.
d5efd1d1
PE
3227 (DECODE_COMPOSITION_RULE): If the rule is invalid, goto invalid_code
3228 directly, rather than having caller test rule sign. This avoids
3229 some unnecessary tests.
3230 * composite.h (COMPOSITION_ENCODE_RULE_VALID): New macro.
3231 (COMPOSITION_ENCODE_RULE): Arguments now must be valid. This
3232 affects only one use, in DECODE_COMPOSITION_RULE, which is changed.
b25d760e 3233
bc7b6697 3234 * xfont.c (xfont_text_extents): Remove var that was set but not used.
625a3eb1 3235 (xfont_open): Avoid unnecessary tests.
bc7b6697 3236
27ccc379
PE
3237 * composite.c (composition_gstring_put_cache): Use unsigned integer.
3238
dcd5c89a
PE
3239 * composite.h, composite.c (composition_gstring_put_cache):
3240 Use EMACS_INT, not int, for length.
3241
b13a45c6
PE
3242 * composite.h (COMPOSITION_DECODE_REFS): New macro,
3243 breaking out part of COMPOSITION_DECODE_RULE.
3244 (COMPOSITION_DECODE_RULE): Use it.
3245 * composite.c (get_composition_id): Remove unused local vars,
3246 by using the new macro.
3247
1e792e4d
PE
3248 * textprop.c (set_text_properties_1): Change while to do-while,
3249 since the condition is always true at first.
3250
dc6c6455 3251 * intervals.c (graft_intervals_into_buffer): Mark var as used.
aa86731f
PE
3252 (interval_deletion_adjustment): Return unsigned value.
3253 All uses changed.
dc6c6455 3254
aba7731a
PE
3255 * process.c (list_processes_1, create_pty, read_process_output):
3256 (exec_sentinel): Remove vars that were set but not used.
afd4052b 3257 (create_pty): Remove unnecessary "volatile"s.
bc57d757 3258 (Fnetwork_interface_info): Avoid possibility of int overflow.
82eaa333 3259 (read_process_output): Do adaptive read buffering even if carryover.
fe07cdfa 3260 (read_process_output): Simplify nbytes computation if buffered.
aba7731a 3261
fdfc4bf3
PE
3262 * bytecode.c (exec_byte_code): Rename local to avoid shadowing.
3263
fca8fe46 3264 * syntax.c (scan_words): Remove var that was set but not used.
12cbf13f 3265 (update_syntax_table): Use unsigned instead of int.
fca8fe46 3266
06a0259a 3267 * lread.c (lisp_file_lexically_bound_p): Use ints rather than endptrs.
3c346cc3 3268 (lisp_file_lexically_bound_p, read1): Use unsigned instead of int.
e6eb4e9e 3269 (safe_to_load_p): Make the end-of-loop test the inverse of the in-loop.
06a0259a 3270
e7b9e80f
PE
3271 * print.c (print_error_message): Avoid int overflow.
3272
56201685
PE
3273 * font.c (font_list_entities): Redo for clarity,
3274 so that reader need not know FONT_DPI_INDEX + 1 == FONT_SPACING_INDEX.
3275
78834453 3276 * font.c (font_find_for_lface, Ffont_get_glyphs): Remove unused vars.
790771b1 3277 (font_score): Avoid potential overflow in diff calculation.
78834453 3278
0bc0b309 3279 * fns.c (substring_both): Remove var that is set but not used.
8cd55cb4 3280 (sxhash): Redo loop for clarity and to avoid wraparound warning.
0bc0b309 3281
e610eaca
PE
3282 * eval.c (funcall_lambda): Rename local to avoid shadowing.
3283
b895abce
PE
3284 * alloc.c (mark_object_loop_halt, mark_object): Use size_t, not int.
3285 Otherwise, GCC 4.6.0 optimizes the loop check away since the check
3286 can always succeed if overflow has undefined behavior.
3287
1f1d9321 3288 * search.c (boyer_moore, wordify): Remove vars set but not used.
6f076cc7 3289 (wordify): Omit three unnecessary tests.
1f1d9321 3290
c59478bc
PE
3291 * indent.c (MULTIBYTE_BYTES_WIDTH): Don't compute wide_column.
3292 All callers changed. This avoids the need for an unused var.
3293
79b73827
PE
3294 * casefiddle.c (casify_region): Remove var that is set but not used.
3295
a4db5dfe
PE
3296 * dired.c (file_name_completion): Remove var that is set but not used.
3297
43aae36e
PE
3298 * fileio.c (Finsert_file_contents): Make EOF condition clearer.
3299
2a47c44d 3300 * fileio.c (Finsert_file_contents): Avoid signed integer overflow.
163c5f32 3301 (Finsert_file_contents): Remove unnecessary code checking fd.
2a47c44d 3302
a37c69bf
PE
3303 * minibuf.c (read_minibuf_noninteractive): Use size_t for sizes.
3304 Check for integer overflow on size calculations.
3305
328ab8e7
PE
3306 * buffer.c (Fprevious_overlay_change): Remove var that is set
3307 but not used.
3308
e5a2a5cb
PE
3309 * keyboard.c (menu_bar_items, read_char_minibuf_menu_prompt):
3310 Remove vars that are set but not used.
8d84a6eb 3311 (timer_check_2): Don't assume timer-list and idle-timer-list are lists.
6b043475 3312 (timer_check_2): Mark vars as initialized.
e5a2a5cb 3313
a60e5f68
PE
3314 * gtkutil.c (xg_get_file_with_chooser): Mark var as initialized.
3315
f661cb61 3316 * image.c (lookup_image): Remove var that is set but not used.
35fa624f 3317 (xbm_load): Use parse_p, for gcc -Werror=unused-but-set-variable.
f661cb61 3318
f0397f5a
PE
3319 * fontset.c (Finternal_char_font, Ffontset_info): Remove vars
3320 that are set but not used.
3321
8664db06 3322 * xfns.c (make_invisible_cursor): Don't return garbage
03733ee7 3323 if XCreateBitmapFromData fails (Bug#8410).
8664db06 3324
6abdaa4a
PE
3325 * xselect.c (x_get_local_selection, x_handle_property_notify):
3326 Remove vars that are set but not used.
3327
0ce7538d 3328 * xfns.c (x_create_tip_frame): Remove var that is set but not used.
6abdaa4a 3329 (make_invisible_cursor): Initialize a possibly-uninitialized variable.
0ce7538d 3330
9ae848fc
PE
3331 * xterm.c (x_scroll_bar_to_input_event) [!USE_GTK]:
3332 Remove var that is set but not used.
0b918413
PE
3333 (scroll_bar_windows_size): Now size_t, not int.
3334 (x_send_scroll_bar_event): Use size_t, not int, for sizes.
3335 Check for overflow.
9ae848fc 3336
a5a62657
PE
3337 * xfaces.c (realize_named_face): Remove vars that are set but not used.
3338 (map_tty_color) [!defined MSDOS]: Likewise.
3339
5c5cdd39
PE
3340 * term.c (tty_write_glyphs): Use size_t; this avoids overflow warning.
3341
66ebf983
PE
3342 * coding.c: Remove vars that are set but not used.
3343 (DECODE_COMPOSITION_RULE): Remove 2nd arg, which is unused.
3344 All callers changed.
3345 (decode_coding_utf_8, decode_coding_utf_16 decode_coding_emacs_mule):
3346 (decode_coding_iso_2022, encode_coding_sjis, encode_coding_big5):
3347 (decode_coding_charset): Remove vars that are set but not used.
3348
1be4d761
PE
3349 * bytecode.c (Fbyte_code) [!defined BYTE_CODE_SAFE]: Remove var
3350 that is set but not used.
3351
47553fa8
PE
3352 * print.c (print_object): Remove var that is set but not used.
3353
1f7196bf 3354 Replace 2 copies of readlink code with 1 gnulib version (Bug#8401).
d1fdcab7
PE
3355 The gnulib version avoids calling malloc in the usual case,
3356 and on 64-bit hosts doesn't have some arbitrary 32-bit limits.
3357 * fileio.c (Ffile_symlink_p): Use emacs_readlink.
3358 * filelock.c (current_lock_owner): Likewise.
3359 * lisp.h (READLINK_BUFSIZE, emacs_readlink): New function.
3360 * sysdep.c: Include allocator.h, careadlinkat.h.
3361 (emacs_no_realloc_allocator): New static constant.
3362 (emacs_readlink): New function.
fdb61804
PE
3363 * deps.mk (sysdep.o): Depend on ../lib/allocator.h and on
3364 ../lib/careadlinkat.h.
d1fdcab7 3365
f84c17c7
SM
33662011-04-04 Stefan Monnier <monnier@iro.umontreal.ca>
3367
3368 * keyboard.c (safe_run_hook_funcall): Fix last change (don't stop at the
3369 first non-nil return value).
3370
ef3862ad
JD
33712011-04-03 Jan Djärv <jan.h.d@swipnet.se>
3372
3373 * nsterm.m (ns_update_auto_hide_menu_bar): Define MAC_OS_X_VERSION_10_6
3374 if not defined (Bug#8403).
3375
376a7006
JB
33762011-04-02 Juanma Barranquero <lekktu@gmail.com>
3377
3378 * xdisp.c (display_count_lines): Remove parameter `start',
3379 unused since 1998-01-01T02:27:27Z!rms@gnu.org. All callers changed.
3380 (get_char_face_and_encoding): Remove parameter `multibyte_p',
3381 unused since 2008-05-14T01:40:23Z!handa@m17n.org. All callers changed.
3382 (fill_stretch_glyph_string): Remove parameters `row' and `area',
3383 unused at least since Kim's GUI unification at 2003-03-16T20:45:46Z!storm@cua.dk
3384 and thereabouts. All callers changed.
3385 (get_per_char_metric): Remove parameter `f', unused since
3386 2008-05-14T01:40:23Z!handa@m17n.org. All callers changed.
3387
6ca3801d
JM
33882011-04-02 Jim Meyering <meyering@redhat.com>
3389
3390 do not dereference NULL upon failed strdup
3391 * nsfont.m (ns_descriptor_to_entity): Use xstrdup, not strdup.
3392 (ns_get_family): Likewise.
3393
d8e2b5ba
JB
33942011-04-02 Juanma Barranquero <lekktu@gmail.com>
3395
3396 * eval.c (unwind_to_catch) [DEBUG_GCPRO]: Remove redundant assignment.
3397
8c74fcbd
JD
33982011-04-02 Jan Djärv <jan.h.d@swipnet.se>
3399
3400 * nsterm.m (ns_update_auto_hide_menu_bar): Only for OSX 10.6 or
3401 later (Bug#8403).
3402
7200d79c
SM
34032011-04-01 Stefan Monnier <monnier@iro.umontreal.ca>
3404
03408648 3405 Add lexical binding.
7200d79c 3406
03408648
SM
3407 * window.c (Ftemp_output_buffer_show): New fun.
3408 (Fsave_window_excursion):
3409 * print.c (Fwith_output_to_temp_buffer): Move to subr.el.
3410
3411 * lread.c (lisp_file_lexically_bound_p): New function.
3412 (Fload): Bind Qlexical_binding.
3413 (readevalloop): Remove `evalfun' arg.
3414 Bind Qinternal_interpreter_environment.
3415 (Feval_buffer): Bind Qlexical_binding.
3416 (defvar_int, defvar_bool, defvar_lisp_nopro, defvar_kboard):
3417 Mark as dynamic.
3418 (syms_of_lread): Declare `lexical-binding'.
3419
3420 * lisp.h (struct Lisp_Symbol): New field `declared_special'.
3421
3422 * keyboard.c (eval_dyn): New fun.
3423 (menu_item_eval_property): Use it.
ca105506
SM
3424
3425 * image.c (parse_image_spec): Use Ffunctionp.
ca105506 3426
03408648
SM
3427 * fns.c (concat, mapcar1): Accept byte-code-functions.
3428
3429 * eval.c (Fsetq): Handle lexical vars.
3430 (Fdefun, Fdefmacro, Ffunction): Make closures when needed.
3431 (Fdefconst, Fdefvaralias, Fdefvar): Mark as dynamic.
3432 (FletX, Flet): Obey lexical binding.
3433 (Fcommandp): Handle closures.
3434 (Feval): New `lexical' arg.
3435 (eval_sub): New function extracted from Feval. Use it almost
3436 everywhere where Feval was used. Look up vars in lexical env.
3437 Handle closures.
3438 (Ffunctionp): Move from subr.el.
3439 (Ffuncall): Handle closures.
3440 (apply_lambda): Remove `eval_flags'.
3441 (funcall_lambda): Handle closures and new byte-code-functions.
3442 (Fspecial_variable_p): New function.
3443 (syms_of_eval): Initialize the Vinternal_interpreter_environment var,
3444 but without exporting it to Lisp.
23aba0ea 3445
23aba0ea 3446 * doc.c (Fdocumentation, store_function_docstring):
03408648 3447 * data.c (Finteractive_form): Handle closures.
23aba0ea 3448
03408648
SM
3449 * callint.c (Fcall_interactively): Preserve lexical-binding mode for
3450 interactive spec.
ba83908c 3451
04f2d78b
CB
3452 * bytecode.c (Bstack_ref, Bstack_set, Bstack_set2, BdiscardN):
3453 New byte-codes.
03408648
SM
3454 (exec_byte_code): New function extracted from Fbyte_code to handle new
3455 calling convention for byte-code-functions. Add new byte-codes.
ba83908c 3456
03408648 3457 * buffer.c (defvar_per_buffer): Set new `declared_special' field.
e2abe5a1 3458
03408648 3459 * alloc.c (Fmake_symbol): Init new `declared_special' field.
e2abe5a1 3460
e2abce01
JB
34612011-03-31 Juanma Barranquero <lekktu@gmail.com>
3462
3463 * xdisp.c (redisplay_internal): Fix prototype.
3464
63696a73 34652011-03-31 Eli Zaretskii <eliz@gnu.org>
09725d26 3466
63696a73 3467 * xdisp.c (SCROLL_LIMIT): New macro.
04f2d78b
CB
3468 (try_scrolling): Use it when setting scroll_limit.
3469 Limit scrolling to 100 screen lines.
63696a73
EZ
3470 (redisplay_window): Even when falling back on "recentering",
3471 position point in the window according to scroll-conservatively,
3472 scroll-margin, and scroll-*-aggressively variables. (Bug#6671)
3473
3474 (try_scrolling): When point is above the window, allow searching
3475 as far as scroll_max, or one screenful, to compute vertical
3476 distance from PT to the scroll margin position. This prevents
3477 try_scrolling from unnecessarily failing when
3478 scroll-conservatively is set to a value slightly larger than the
3479 window height. Clean up the case of PT below the margin at bottom
3480 of window: scroll_max can no longer be INT_MAX. When aggressive
3481 scrolling is in use, don't let point enter the opposite scroll
3482 margin as result of the scroll.
3483 (syms_of_xdisp) <scroll-conservatively>: Document the
09725d26
EZ
3484 threshold of 100 lines for never-recentering scrolling.
3485
e4cc2dfc
JB
34862011-03-31 Juanma Barranquero <lekktu@gmail.com>
3487
3488 * dispextern.h (move_it_by_lines):
3489 * xdisp.c (move_it_by_lines): Remove parameter `need_y_p', unused
3490 since 2000-12-29T14:24:09Z!gerd@gnu.org. All callers changed.
3491 (message_log_check_duplicate): Remove parameters `prev_bol' and
3492 `this_bol', unused since 1998-01-01T02:27:27Z!rms@gnu.org. All callers changed.
3493 (redisplay_internal): Remove parameter `preserve_echo_area',
3494 unused since 1999-07-21T21:43:52Z!gerd@gnu.org. All callers changed.
3495
3496 * indent.c (Fvertical_motion):
3497 * window.c (window_scroll_pixel_based, Frecenter):
3498 Don't pass `need_y_p' to `move_it_by_lines'.
3499
1c470562
SM
35002011-03-30 Stefan Monnier <monnier@iro.umontreal.ca>
3501
44f230aa
SM
3502 * eval.c (struct backtrace): Don't cheat with negative numbers, but do
3503 steal a few bits to be more compact.
3504 (interactive_p, Fbacktrace, Fbacktrace_frame, mark_backtrace):
3505 Remove unneeded casts.
3506
1c470562
SM
3507 * bytecode.c (Fbyte_code): CAR and CDR can GC.
3508
888adce9
ZK
35092011-03-30 Zachary Kanfer <zkanfer@gmail.com> (tiny change)
3510
3511 * keyboard.c (Fexecute_extended_command): Do log the "suggest key
3512 binding" message (bug#7967).
3513
f838ed7b
PE
35142011-03-30 Paul Eggert <eggert@cs.ucla.edu>
3515
77861b95
PE
3516 Fix more problems found by GCC 4.6.0's static checks.
3517
de6dbc14
PE
3518 * unexelf.c (unexec) [! (defined _SYSTYPE_SYSV || defined __sgi)]:
3519 Remove unused local var.
3520
f838ed7b
PE
3521 * editfns.c (Fmessage_box): Remove unused local var.
3522
792c7b2b
PE
3523 * xdisp.c (try_window_reusing_current_matrix, x_produce_glyphs):
3524 (note_mode_line_or_margin_highlight, note_mouse_highlight):
3525 Omit unused local vars.
c499e557 3526 * window.c (shrink_windows): Omit unused local var.
b01a1c29 3527 * menu.c (digest_single_submenu): Omit unused local var.
0bc32927
PE
3528 * dispnew.c (update_window) [PERIODIC_PREEMPTION_CHECKING]:
3529 Omit unused local var.
3530
ba0165e1
PE
3531 * keyboard.c (parse_modifiers_uncached, parse_modifiers):
3532 Don't assume string length fits in int.
32ad8845 3533 (keyremap_step, read_key_sequence): Use size_t for sizes.
48011560 3534 (read_key_sequence): Don't check last_real_key_start redundantly.
ba0165e1 3535
3c59b4c9
PE
3536 * callproc.c (Fcall_process, Fcall_process_region): Use SAFE_ALLOCA
3537 instead of alloca (Bug#8344).
3538
a3eed478 3539 * eval.c (Fbacktrace): Don't assume nargs fits in int.
5d5d959d 3540 (Fbacktrace_frame): Don't assume nframes fits in int.
a3eed478 3541
eb4d412d
PE
3542 * syntax.c (scan_sexps_forward): Avoid pointer wraparound.
3543
1658b401
PE
3544 * xterm.c (x_make_frame_visible, same_x_server): Redo to avoid overflow
3545 concerns.
3546
3547 * term.c (produce_glyphless_glyph): Remove unnecessary test.
3548
3549 * cm.c (calccost): Turn while-do into do-while, for clarity.
44f730c8 3550
9a2c6e05
PE
3551 * keyboard.c (syms_of_keyboard): Use the same style as later
3552 in this function when indexing through an array. This also
3553 works around GCC bug 48267.
3554
03d0a109
PE
3555 * image.c (tiff_load): Fix off-by-one image count (Bug#8336).
3556
44f730c8
PE
3557 * xselect.c (x_check_property_data): Return correct size (Bug#8335).
3558
fe75f926
PE
3559 * chartab.c (sub_char_table_ref_and_range): Redo for slight
3560 efficiency gain, and to bypass a gcc -Wstrict-overflow warning.
3561
ffa8c828
PE
3562 * keyboard.c, keyboard.h (num_input_events): Now size_t.
3563 This avoids undefined behavior on integer overflow, and is a bit
3564 more convenient anyway since it is compared to a size_t variable.
3565
c5101a77
PE
3566 Variadic C functions now count arguments with size_t, not int.
3567 This avoids an unnecessary limitation on 64-bit machines, which
3568 caused (substring ...) to crash on large vectors (Bug#8344).
3569 * lisp.h (struct Lisp_Subr.function.aMANY): Now takes size_t, not int.
3570 (DEFUN_ARGS_MANY, internal_condition_case_n, safe_call): Likewise.
77861b95 3571 All variadic functions and their callers changed accordingly.
c5101a77
PE
3572 (struct gcpro.nvars): Now size_t, not int. All uses changed.
3573 * data.c (arith_driver, float_arith_driver): Likewise.
3574 * editfns.c (general_insert_function): Likewise.
3575 * eval.c (struct backtrace.nargs, interactive_p)
3576 (internal_condition_case_n, run_hook_with_args, apply_lambda)
3577 (funcall_lambda, mark_backtrace): Likewise.
3578 * fns.c (concat): Likewise.
3579 * frame.c (x_set_frame_parameters): Likewise.
3580 * fns.c (get_key_arg): Now accepts and returns size_t, and returns
3581 0 if not found, not -1. All callers changed.
3582
dd3f25f7
PE
3583 * alloc.c (garbage_collect): Don't assume stack size fits in int.
3584 (stack_copy_size): Now size_t, not int.
3585 (stack_copy, stack_copy_size): Define only if MAX_SAVE_STACK > 0.
3586
461c2ab9
JB
35872011-03-28 Juanma Barranquero <lekktu@gmail.com>
3588
3589 * coding.c (encode_designation_at_bol): Remove parameter `charbuf_end',
3590 unused since 2002-03-01T01:17:24Z!handa@m17n.org and 2008-02-01T16:01:31Z!miles@gnu.org.
3591 All callers changed.
3592
3593 * lisp.h (multibyte_char_to_unibyte):
3594 * character.c (multibyte_char_to_unibyte): Remove parameter `rev_tbl',
3595 unused since 2002-03-01T01:16:34Z!handa@m17n.org and 2008-02-01T16:01:31Z!miles@gnu.org.
3596 * character.h (CHAR_TO_BYTE8):
3597 * cmds.c (internal_self_insert):
3598 * editfns.c (general_insert_function):
3599 * keymap.c (push_key_description):
3600 * search.c (Freplace_match):
3601 * xdisp.c (message_dolog, set_message_1): All callers changed.
3602
f6d62986
SM
36032011-03-28 Stefan Monnier <monnier@iro.umontreal.ca>
3604
3605 * keyboard.c (safe_run_hook_funcall): New function.
3606 (safe_run_hooks_1, safe_run_hooks_error, safe_run_hooks): On error,
3607 don't set the hook to nil, but remove the offending function instead.
3608 (Qcommand_hook_internal): Remove, unused.
3609 (syms_of_keyboard): Don't initialize Qcommand_hook_internal nor define
3610 Vcommand_hook_internal.
3611
3612 * eval.c (enum run_hooks_condition): Remove.
3613 (funcall_nil, funcall_not): New functions.
3614 (run_hook_with_args): Call each function through a `funcall' argument.
3615 Remove `cond' argument, now redundant.
3616 (Frun_hooks, Frun_hook_with_args, Frun_hook_with_args_until_success)
3617 (Frun_hook_with_args_until_failure): Adjust accordingly.
3618 (run_hook_wrapped_funcall, Frun_hook_wrapped): New functions.
3619
1db5b1ad
JB
36202011-03-28 Juanma Barranquero <lekktu@gmail.com>
3621
3622 * dispextern.h (string_buffer_position): Remove declaration.
3623
3624 * print.c (strout): Remove parameter `multibyte', unused since
3625 1999-08-21T19:30:21Z!gerd@gnu.org. All callers changed.
3626
3627 * search.c (boyer_moore): Remove parameters `len', `pos' and `lim',
3628 never used since function introduction in 1998-02-08T21:33:56Z!rms@gnu.org.
3629 All callers changed.
3630
3631 * w32.c (_wsa_errlist): Use braces for struct initializers.
3632
3633 * xdisp.c (string_buffer_position_lim): Remove parameter `w',
3634 never used since function introduction in 2001-03-09T18:41:50Z!gerd@gnu.org.
3635 All callers changed.
3636 (string_buffer_position): Likewise. Also, make static (it's never
3637 used outside xdisp.c).
3638 (cursor_row_p): Remove parameter `w', unused since
3639 2000-10-17T16:08:57Z!gerd@gnu.org. All callers changed.
3640 (decode_mode_spec): Remove parameter `precision', introduced during
3641 Gerd Moellmann's rewrite at 1999-07-21T21:43:52Z!gerd@gnu.org, but never used.
3642 All callers changed.
3643
5ffb62aa
JD
36442011-03-27 Jan Djärv <jan.h.d@swipnet.se>
3645
3646 * nsterm.m (syms_of_nsterm): Use doc: for ns-auto-hide-menu-bar.
3647
461c2ab9 36482011-03-27 Anders Lindgren <andlind@gmail.com>
f0a1382a
JD
3649
3650 * nsterm.m (ns_menu_bar_is_hidden): New variable.
3651 (ns_constrain_all_frames, ns_menu_bar_should_be_hidden)
3652 (ns_update_auto_hide_menu_bar): New functions.
3653 (ns_update_begin): Call ns_update_auto_hide_menu_bar.
3654 (applicationDidBecomeActive): Call ns_update_auto_hide_menu_bar and
3655 ns_constrain_all_frames.
3656 (constrainFrameRect): Return at once if ns_menu_bar_should_be_hidden.
3657 (syms_of_nsterm): DEFVAR ns-auto-hide-menu-bar, init to Qnil.
3658
5c380ffb
JD
36592011-03-27 Jan Djärv <jan.h.d@swipnet.se>
3660
3661 * nsmenu.m (runDialogAt): Remove argument to timer_check.
3662
9af30bdf
GM
36632011-03-27 Glenn Morris <rgm@gnu.org>
3664
3665 * syssignal.h: Replace RETSIGTYPE with void.
3666 * atimer.c, data.c, dispnew.c, emacs.c, floatfns.c, keyboard.c:
3667 * keyboard.h, lisp.h, process.c, sysdep.c, xterm.c:
3668 Replace SIGTYPE with void everywhere.
3669 * s/usg5-4-common.h (SIGTYPE): Remove definition.
3670 * s/template.h (SIGTYPE): Remove commented out definition.
3671
e2abce01
JB
36722011-03-26 Eli Zaretskii <eliz@gnu.org>
3673
3674 * xdisp.c (redisplay_window): Don't check buffer's clip_changed
3675 flag as a prerequisite for invoking try_scrolling. (Bug#6671)
3676
f868cd8a
JB
36772011-03-26 Juanma Barranquero <lekktu@gmail.com>
3678
59eb0929
JB
3679 * w32.c (read_unc_volume): Use parameter `henum', instead of
3680 global variable `wget_enum_handle'.
3681
3682 * keymap.c (describe_vector): Remove parameters `indices' and
3683 `char_table_depth', unused since 2002-03-01T01:43:26Z!handa@m17n.org.
3684 (describe_map, Fdescribe_vector): Adjust calls to `describe_vector'.
3685
f868cd8a
JB
3686 * keyboard.h (timer_check, show_help_echo): Remove unused parameters.
3687
3688 * keyboard.c (timer_check): Remove parameter `do_it_now',
3689 unused since 1996-04-12T06:01:29Z!rms@gnu.org.
3690 (show_help_echo): Remove parameter `ok_to_overwrite_keystroke_echo',
3691 unused since 2008-04-19T19:30:53Z!monnier@iro.umontreal.ca.
3692
3693 * keyboard.c (read_char):
3694 * w32menu.c (w32_menu_display_help):
3695 * xmenu.c (show_help_event, menu_help_callback):
3696 Adjust calls to `show_help_echo'.
3697
3698 * gtkutil.c (xg_maybe_add_timer):
3699 * keyboard.c (readable_events):
3700 * process.c (wait_reading_process_output):
3701 * xmenu.c (x_menu_wait_for_event): Adjust calls to `timer_check'.
3702
3703 * insdel.c (adjust_markers_gap_motion):
3704 Remove; no-op since 1998-01-02T21:29:48Z!rms@gnu.org.
3705 (gap_left, gap_right): Don't call it.
3706
2ecf6fdb
CY
37072011-03-25 Chong Yidong <cyd@stupidchicken.com>
3708
3709 * xdisp.c (handle_fontified_prop): Discard changes to clip_changed
3710 incurred during fontification.
3711
6b1f9ba4
JB
37122011-03-25 Juanma Barranquero <lekktu@gmail.com>
3713
3714 * buffer.c (defvar_per_buffer): Remove unused parameter `doc'.
3715 (DEFVAR_PER_BUFFER): Don't pass it.
3716
3717 * dispnew.c (row_equal_p, add_row_entry): Remove unused parameter `w'.
3718 (scrolling_window): Don't pass it.
3719
0f4a96b5
JB
37202011-03-25 Juanma Barranquero <lekktu@gmail.com>
3721
3722 * dispextern.h (glyph_matric): Use #if GLYPH_DEBUG, not #ifdef.
3723
3724 * fileio.c (check_executable) [DOS_NT]: Remove unused variables `len'
3725 and `suffix'.
3726 (Fset_file_selinux_context) [HAVE_LIBSELINUX]: Move here declaration
3727 of variables specific to SELinux and computation of `encoded_absname'.
3728
3729 * image.c (XPutPixel): Remove unused variable `height'.
3730
3731 * keyboard.c (make_lispy_event): Remove unused variable `hpos'.
3732
3733 * unexw32.c (get_section_info): Remove unused variable `section'.
3734
3735 * w32.c (stat): Remove unused variables `drive_root' and `devtype'.
3736 (system_process_attributes): Remove unused variable `sess'.
3737 (sys_read): Remove unused variable `err'.
3738
3739 * w32fns.c (top): Wrap variables with #if GLYPH_DEBUG, not #ifdef.
3740 (w32_wnd_proc): Remove unused variable `isdead'.
3741 (unwind_create_frame): Use #if GLYPH_DEBUG, not #ifdef.
3742 (Fx_server_max_request_size): Remove unused variable `dpyinfo'.
3743 (x_create_tip_frame): Remove unused variable `tem'.
3744
3745 * w32inevt.c (w32_console_read_socket):
3746 Remove unused variable `no_events'.
3747
3748 * w32term.c (x_draw_composite_glyph_string_foreground):
3749 Remove unused variable `width'.
3750
1149507c
JB
37512011-03-24 Juanma Barranquero <lekktu@gmail.com>
3752
3753 * w32term.c (x_set_glyph_string_clipping):
3754 Don't pass uninitialized region to CombineRgn.
3755
9c88f339
JB
37562011-03-23 Juanma Barranquero <lekktu@gmail.com>
3757
3758 * w32fns.c (x_set_menu_bar_lines): Remove unused variable `olines'.
3759 (w32_wnd_proc): Pass NULL to Windows API, not uninitialized buffer.
3760 (Fx_close_connection): Remove unused variable `i'.
3761
3762 * w32font.c (w32font_draw): Return number of glyphs.
3763 (w32font_open_internal): Remove unused variable `i'.
3764 (w32font_driver): Add missing initializer.
3765
3766 * w32menu.c (utf8to16): Remove unused variable `utf16'.
3767 (fill_in_menu): Remove unused variable `items_added'.
3768
3769 * w32term.c (last_mouse_press_frame): Remove static global variable.
3770 (w32_clip_to_row): Remove unused variable `f'.
3771 (x_delete_terminal): Remove unused variable `i'.
3772
3773 * w32uniscribe.c (uniscribe_shape): Remove unused variable `nclusters'.
3774 (NOTHING): Remove unused static global variable.
3775 (uniscribe_check_otf): Remove unused variable `table'.
3776 (uniscribe_font_driver): Add missing initializers.
3777
dee091a3
JD
37782011-03-23 Julien Danjou <julien@danjou.info>
3779
3780 * term.c (Fsuspend_tty, Fresume_tty):
3781 * minibuf.c (read_minibuf, run_exit_minibuf_hook):
3782 * window.c (temp_output_buffer_show):
3783 * insdel.c (signal_before_change):
3784 * frame.c (Fhandle_switch_frame):
3785 * fileio.c (Fdo_auto_save):
3786 * emacs.c (Fkill_emacs):
3787 * editfns.c (save_excursion_restore):
3788 * cmds.c (internal_self_insert):
3789 * callint.c (Fcall_interactively):
3790 * buffer.c (Fkill_all_local_variables):
3791 * keyboard.c (Fcommand_execute, Fsuspend_emacs, safe_run_hooks_1):
3792 Use Frun_hooks.
0f4a96b5 3793 (command_loop_1): Use Frun_hooks. Call safe_run_hooks
dee091a3
JD
3794 unconditionnaly since it does the check itself.
3795
2c520ab5 37962011-03-23 Paul Eggert <eggert@cs.ucla.edu>
f0641eff 3797
c9c49752
PE
3798 Fix more problems found by GCC 4.5.2's static checks.
3799
8abc3f12
PE
3800 * coding.c (encode_coding_raw_text): Avoid unnecessary test
3801 the first time through the loop, since we know p0 < p1 then.
3802 This also avoids a gcc -Wstrict-overflow warning.
3803
a2d26660
PE
3804 * lisp.h (SAFE_ALLOCA, SAFE_ALLOCA_LISP): Avoid 'int' overflow
3805 leading to a memory leak, possible in functions like
3806 load_charset_map_from_file that can allocate an unbounded number
b12ef411 3807 of objects (Bug#8318).
a2d26660 3808
916c72e9
PE
3809 * xmenu.c (set_frame_menubar): Use EMACS_UINT, not int, for indexes
3810 that could (at least in theory) be that large.
3811
19ab8a18
PE
3812 * xdisp.c (message_log_check_duplicate): Return unsigned long, not int.
3813 This is less likely to overflow, and avoids undefined behavior if
3814 overflow does occur. All callers changed. Use strtoul to scan
3815 for the unsigned long integer.
b7cbbd6f
PE
3816 (pint2hrstr): Simplify and tune code slightly.
3817 This also avoids a (bogus) GCC warning with gcc -Wstrict-overflow.
19ab8a18 3818
f0641eff
PE
3819 * scroll.c (do_scrolling): Work around GCC bug 48228.
3820 See <http://gcc.gnu.org/bugzilla/show_bug.cgi?id=48228>.
3821
7f650bb9
PE
3822 * frame.c (Fmodify_frame_parameters): Simplify loop counter.
3823 This also avoids a warning with gcc -Wstrict-overflow.
39f5e519
PE
3824 (validate_x_resource_name): Simplify count usage.
3825 This also avoids a warning with gcc -Wstrict-overflow.
7f650bb9 3826
37dd57d1
PE
3827 * fileio.c (Fcopy_file): Report error if fchown or fchmod
3828 fail (Bug#8306).
81e56e61 3829
699979fc 3830 * emacs.c (Fdaemon_initialized): Do not ignore I/O errors (Bug#8303).
dc1ca6a8 3831
401bf9b4
PE
3832 * process.c (Fmake_network_process): Use socklen_t, not int,
3833 where POSIX says socklen_t is required in portable programs.
3834 This fixes a porting bug on hosts like 64-bit HP-UX, where
591b2973 3835 socklen_t is wider than int (Bug#8277).
401bf9b4
PE
3836 (Fmake_network_process, server_accept_connection):
3837 (wait_reading_process_output, read_process_output):
3838 Likewise.
3839
b93aacde
PE
3840 * process.c: Rename or move locals to avoid shadowing.
3841 (list_processes_1, Fmake_network_process):
3842 (read_process_output_error_handler, exec_sentinel_error_handler):
3843 Rename or move locals.
4dc343ee 3844 (Fmake_network_process): Define label "retry_connect" only if needed.
0da49335 3845 (Fnetwork_interface_info): Fix pointer signedness.
f990b4e5 3846 (process_send_signal): Add cast to avoid pointer signedness problem.
7b808126 3847 (FIRST_PROC_DESC, IF_NON_BLOCKING_CONNECT): Remove unused macros.
c939f91b 3848 (create_process): Use 'volatile' to avoid vfork clobbering (Bug#8298).
b93aacde 3849
af8a867c 3850 Make tparam.h and terminfo.c consistent.
44f230aa
SM
3851 * cm.c (tputs, tgoto, BC, UP): Remove extern decls.
3852 Include tparam.h instead, since it declares them.
af8a867c
PE
3853 * cm.h (PC): Remove extern decl; tparam.h now does this.
3854 * deps.mk (cm.o, terminfo.o): Depend on tparam.h.
3855 * terminfo.c: Include tparam.h, to check interfaces.
3856 (tparm): Make 1st arg a const pointer in decl. Put it at top level.
3857 (tparam): Adjust signature to match interface in tparam.h;
3858 this removes some undefined behavior. Check that outstring and len
3859 are zero, which they always are with Emacs.
3860 * tparam.h (PC, BC, UP): New extern decls.
3861
0248044d 3862 * xftfont.c (xftfont_shape): Now static, and defined only if needed.
001a7ab4 3863 (xftfont_open): Rename locals to avoid shadowing.
0248044d 3864
8ff096c1 3865 * ftfont.c (ftfont_resolve_generic_family): Fix pointer signedness.
a00924bb
PE
3866 (ftfont_otf_capability, ftfont_shape): Omit decls if not needed.
3867 (OTF_TAG_SYM): Omit macro if not needed.
e932860f 3868 (ftfont_list): Remove unused local.
49eaafba
PE
3869 (get_adstyle_property, ftfont_pattern_entity):
3870 (ftfont_lookup_cache, ftfont_open, ftfont_anchor_point):
3871 Rename locals to avoid shadowing.
8ff096c1 3872
e2be39f6
PE
3873 * xfont.c (xfont_list_family): Mark var as initialized.
3874
c9735e30
PE
3875 * xml.c (make_dom): Now static.
3876
8f5201ae
PE
3877 * composite.c (composition_compute_stop_pos): Rename local to
3878 avoid shadowing.
b246f932
PE
3879 (composition_reseat_it): Remove unused locals.
3880 (find_automatic_composition, composition_adjust_point): Likewise.
80e079b2 3881 (composition_update_it): Mark var as initialized.
11b61122
PE
3882 (find_automatic_composition): Mark vars as initialized,
3883 with a FIXME (Bug#8290).
8f5201ae 3884
760fbc2c
PE
3885 character.h: Rename locals to avoid shadowing.
3886 * character.h (PREV_CHAR_BOUNDARY, FETCH_STRING_CHAR_ADVANCE):
3887 (FETCH_STRING_CHAR_AS_MULTIBYTE_ADVANCE, FETCH_CHAR_ADVANCE):
3888 (FETCH_CHAR_ADVANCE_NO_CHECK, INC_POS, DEC_POS, BUF_INC_POS):
3889 (BUF_DEC_POS): Be more systematic about renaming local temporaries
3890 to avoid shadowing.
3891
ff08eb85
PE
3892 * textprop.c (property_change_between_p): Remove; unused.
3893
fc7bf025
PE
3894 * intervals.c (interval_start_pos): Now static.
3895
235d7abc
PE
3896 * intervals.h (CHECK_TOTAL_LENGTH): Avoid empty "else".
3897
44f230aa
SM
3898 * atimer.c (start_atimer, append_atimer_lists, set_alarm):
3899 Rename locals to avoid shadowing.
3e7d6594 3900
50060332
PE
3901 * sound.c (wav_play, au_play, Fplay_sound_internal):
3902 Fix pointer signedness.
d01f234b 3903 (alsa_choose_format): Remove unused local var.
c83b8872
PE
3904 (wav_play): Initialize a variable to 0, to prevent undefined
3905 behavior (Bug#8278).
50060332 3906
c4fc4e30
PE
3907 * region-cache.c (insert_cache_boundary): Redo var to avoid shadowing.
3908
918436ed
PE
3909 * region-cache.h (pp_cache): New decl, for gcc -Wmissing-prototypes.
3910
c939f91b
PE
3911 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork
3912 clobbering (Bug#8298).
b9c7f648
PE
3913 * sysdep.c (sys_subshell): Likewise.
3914 Previously, the sys_subshell 'volatile' was incorrectly IF_LINTted out.
7e9123a2 3915
6bd8c144
PE
3916 * lisp.h (child_setup): Now NO_RETURN unless DOS_NT.
3917 This should get cleaned up, so that child_setup has the
3918 same signature on all platforms.
3919
7710357c 3920 * callproc.c (call_process_cleanup): Now static.
cb1d0ef7 3921 (relocate_fd): Rename locals to avoid shadowing.
7710357c 3922
c59da222
CY
39232011-03-22 Chong Yidong <cyd@stupidchicken.com>
3924
3925 * xterm.c (x_clear_frame): Remove XClearWindow call. This appears
3926 not to be necessary, and produces flickering.
3927
66b87493
GM
39282011-03-20 Glenn Morris <rgm@gnu.org>
3929
3930 * config.in: Remove file.
3931
45b6f6d5
JB
39322011-03-20 Juanma Barranquero <lekktu@gmail.com>
3933
3934 * minibuf.c (Vcompleting_read_function): Don't declare, global variables
3935 are now in src/globals.h.
3936 (syms_of_minibuf): Remove spurious & from previous change.
3937
3ec03f7e
LL
39382011-03-20 Leo <sdl.web@gmail.com>
3939
3940 * minibuf.c (completing-read-function): New variable.
3941 (completing-read-default): Rename from completing-read.
3942 (completing-read): Call completing-read-function.
3943
b14e3e21
CY
39442011-03-19 Juanma Barranquero <lekktu@gmail.com>
3945
3946 * xfaces.c (Fx_load_color_file):
3947 Read color file from absolute filename (bug#8250).
3948
f2b726e6
JB
39492011-03-19 Juanma Barranquero <lekktu@gmail.com>
3950
3951 * makefile.w32-in: Update dependencies.
3952
09f6ff02
EZ
39532011-03-17 Eli Zaretskii <eliz@gnu.org>
3954
3955 * makefile.w32-in ($(BLD)/unexw32.$(O)): Depend on $(SRC)/unexec.h.
3956
29a6015a
PE
39572011-03-17 Paul Eggert <eggert@cs.ucla.edu>
3958
a3a6c54e
PE
3959 Fix more problems found by GCC 4.5.2's static checks.
3960
b766f867
PE
3961 * process.c (make_serial_process_unwind, send_process_trap):
3962 (sigchld_handler): Now static.
3963
be02381c
PE
3964 * process.c (allocate_pty): Let PTY_ITERATION declare iteration vars.
3965 That way, the code declares only the vars that it needs.
3966 * s/aix4-2.h (PTY_ITERATION): Declare iteration vars.
3967 * s/cygwin.h (PTY_ITERATION): Likewise.
3968 * s/darwin.h (PTY_ITERATION): Likewise.
3969 * s/gnu-linux.h (PTY_ITERATION): Likewise.
3970
57048744
PE
3971 * s/irix6-5.h (PTY_OPEN): Declare stb, to loosen coupling.
3972 * process.c (allocate_pty): Don't declare stb unless it's needed.
3973
7914961c 3974 * bytecode.c (MAYBE_GC): Rewrite so as not to use empty "else".
615f2d59
PE
3975 (CONSTANTLIM): Remove; unused.
3976 (METER_CODE, Bscan_buffer, Bread_char, Bset_mark):
3977 Define only if needed.
7914961c 3978
b3967b18
PE
3979 * unexelf.c (unexec): Name an expression,
3980 to avoid gcc -Wbad-function-cast warning.
9ae71512
PE
3981 Use a different way to cause a compilation error if anyone uses
3982 n rather than nn, a way that does not involve shadowing.
73366a00 3983 (ELF_BSS_SECTION_NAME, OLD_PROGRAM_H): Remove; unused.
b3967b18 3984
29a6015a
PE
3985 * deps.mk (unexalpha.o): Remove; unused.
3986
43cfc33e 3987 New file unexec.h, the (simple) interface for unexec (Bug#8267).
7feda0d2 3988 * unexec.h: New file.
ce701a33
PE
3989 * deps.mk (emacs.o, unexaix.o, unexcw.o, unexcoff.o, unexelf.o):
3990 (unexhp9k800.o, unexmacosx.o, unexsol.o, unexw32.o):
3991 Depend on unexec.h.
3992 * emacs.c [!defined CANNOT_DUMP]: Include unexec.h.
3993 * unexaix.c, unexcoff.c, unexcw.c, unexelf.c, unexhp9k800.c:
3994 * unexmacosx.c, unexsol.c, unexw32.c: Include unexec.h.
381259ef 3995 Change as necessary to match prototype in unexec.h.
ce701a33 3996
01f44d5a
PE
3997 * syntax.c (Fforward_comment, scan_lists): Rename locals to avoid
3998 shadowing.
4f63c6bb 3999 (back_comment, skip_chars): Mark vars as initialized.
01f44d5a 4000
a6670b0b
PE
4001 * character.h (FETCH_STRING_CHAR_ADVANCE_NO_CHECK, BUF_INC_POS):
4002 Rename locals to avoid shadowing.
4003
cef2010d 4004 * lread.c (read1): Rewrite so as not to use empty "else".
0902fe45 4005 (Fload, readevalloop, read1): Rename locals to avoid shadowing.
cef2010d 4006
d4d7173a
PE
4007 * print.c (Fredirect_debugging_output): Fix pointer signedess.
4008
f08b802a
PE
4009 * lisp.h (debug_output_compilation_hack): Add decl here, to avoid
4010 warning when compiling print.c.
4011
3ddb0639
PE
4012 * font.c (font_unparse_fcname): Abort in an "impossible" situation
4013 instead of using an uninitialized var.
5ad03b97 4014 (font_sort_entities): Mark var as initialized.
3ddb0639 4015
170a2692
PE
4016 * character.h (FETCH_CHAR_ADVANCE): Rename locals to avoid shadowing.
4017
e663c700
PE
4018 * font.c (font_unparse_xlfd): Don't mix pointers to variables with
4019 pointers to constants.
89bc529a 4020 (font_parse_fcname): Remove unused vars.
7b81e2d0 4021 (font_delete_unmatched): Now static.
ea838e10 4022 (font_get_spec): Remove; unused.
13a547c6
PE
4023 (font_style_to_value, font_prop_validate_style, font_unparse_fcname):
4024 (font_update_drivers, Ffont_get_glyphs, font_add_log):
4025 Rename or move locals to avoid shadowing.
e663c700 4026
2a80c887 4027 * fns.c (require_nesting_list, require_unwind): Now static.
612f56df 4028 (Ffillarray): Rename locals to avoid shadowing.
2a80c887 4029
1384fa33 4030 * floatfns.c (domain_error2): Define only if needed.
a885e2ed 4031 (Ffrexp, Fldexp): Rename locals to avoid shadowing.
1384fa33 4032
8b2c52e9
PE
4033 * alloc.c (mark_backtrace): Move decl from here ...
4034 * lisp.h: ... to here, so that it can be checked.
4035
475545b5 4036 * eval.c (call_debugger, do_debug_on_call, grow_specpdl): Now static.
d28a2170 4037 (Fdefvar): Rewrite so as not to use empty "else".
cfcbfb1a
PE
4038 (lisp_indirect_variable): Name an expression,
4039 to avoid gcc -Wbad-function-cast warning.
1faed8ae 4040 (Fdefvar): Rename locals to avoid shadowing.
475545b5 4041
b1349114 4042 * callint.c (quotify_arg, quotify_args): Now static.
a3e8cbda 4043 (Fcall_interactively): Rename locals to avoid shadowing.
b0e80955 4044 Use const pointer when appropriate.
b1349114 4045
a2928364
PE
4046 * lisp.h (get_system_name, get_operating_system_release):
4047 Move decls here, to check interfaces.
4048 * process.c (get_operating_system_release): Move decl to lisp.h.
4049 * xrdb.c (get_system_name): Likewise.
63c5d10b
PE
4050 * editfns.c (init_editfns, Fuser_login_name, Fuser_uid):
4051 (Fuser_real_uid, Fuser_full_name): Remove unnecessary casts,
4052 some of which prompt warnings from gcc -Wbad-function-cast.
545b49b4
PE
4053 (Fformat_time_string, Fencode_time, Finsert_char):
4054 (Ftranslate_region_internal, Fformat):
4055 Rename or remove local vars to avoid shadowing.
9710023e 4056 (Ftranslate_region_internal): Mark var as initialized.
63c5d10b 4057
a415e694
PE
4058 * doc.c (Fdocumentation, Fsnarf_documentation): Move locals to
4059 avoid shadowing.
4060
8ef4622d
PE
4061 * lisp.h (eassert): Check that the argument compiles, even if
4062 ENABLE_CHECKING is not defined.
4063
946f9a5b
PE
4064 * data.c (Findirect_variable): Name an expression, to avoid
4065 gcc -Wbad-function-cast warning.
112396d6 4066 (default_value, arithcompare, arith_driver, arith_error): Now static.
b9b84fa9 4067 (store_symval_forwarding): Rename local to avoid shadowing.
44f230aa
SM
4068 (Fmake_variable_buffer_local, Fmake_local_variable):
4069 Mark variables as initialized.
52746918 4070 (do_blv_forwarding, do_symval_forwarding): Remove; unused.
946f9a5b 4071
e5aab7e7 4072 * alloc.c (check_cons_list): Do not define unless GC_CHECK_CONS_LIST.
ae35e756
PE
4073 (Fmake_vector, Fvector, Fmake_byte_code, Fgarbage_collect):
4074 Rename locals to avoid shadowing.
dff45157
PE
4075 (mark_stack): Move local variables into the #ifdef region where
4076 they're used.
7bc26fdb
PE
4077 (BLOCK_INPUT_ALLOC, UNBLOCK_INPUT_ALLOC): Define only if
4078 ! defined SYSTEM_MALLOC && ! defined SYNC_INPUT, as they are not
4079 needed otherwise.
4080 (CHECK_ALLOCATED): Define only if GC_CHECK_MARKED_OBJECTS.
4081 (GC_STRING_CHARS): Remove; not used.
d40d4be1 4082 (Fmemory_limit): Cast sbrk's returned value to char *.
ae35e756 4083
e5aab7e7
PE
4084 * lisp.h (check_cons_list): Declare if GC_CHECK_CONS_LIST; this
4085 avoids undefined behavior in theory.
4086
4da60324
PE
4087 * regex.c (IF_LINT): Add defn, for benefit of ../lib-src.
4088
88043301
PE
4089 Use functions, not macros, for up- and down-casing (Bug#8254).
4090 * buffer.h (DOWNCASE_TABLE, UPCASE_TABLE, DOWNCASE, UPPERCASEP):
4091 (NOCASEP, LOWERCASEP, UPCASE, UPCASE1): Remove. All callers changed
4092 to use the following functions instead of these macros.
4093 (downcase): Adjust to lack of DOWNCASE_TABLE. Return int, not
4094 EMACS_INT, since callers assume the returned value fits in int.
4095 (upcase1): Likewise, for UPCASE_TABLE.
4096 (uppercasep, lowercasep, upcase): New static inline functions.
0da09c43 4097 * editfns.c (Fchar_equal): Remove no-longer-needed workaround for
db69b0cd 4098 the race-condition problem in the old DOWNCASE.
88043301 4099
19ed5445
PE
4100 * regex.c (CHARSET_LOOKUP_RANGE_TABLE_RAW, POP_FAILURE_REG_OR_COUNT):
4101 Rename locals to avoid shadowing.
4102 (regex_compile, re_match_2_internal): Move locals to avoid shadowing.
abbd1bcf
PE
4103 (regex_compile, re_search_2, re_match_2_internal):
4104 Remove unused local vars.
952db0d7
PE
4105 (FREE_VAR): Rewrite so as not to use empty "else",
4106 which gcc can warn about.
da053e48 4107 (regex_compile, re_match_2_internal): Mark locals as initialized.
b313f9d8
PE
4108 (RETALLOC_IF): Define only if needed.
4109 (WORDCHAR_P): Likewise. This one is never needed, but is used
4110 only in a comment talking about a compiler bug, so put inside
4111 the #if 0 of that comment.
4112 (CHARSET_LOOKUP_BITMAP, FAIL_STACK_FULL, RESET_FAIL_STACK):
4113 (PUSH_FAILURE_ELT, BUF_PUSH_3, STOP_ADDR_VSTRING):
4114 Remove; unused.
19ed5445 4115
1f3561e4 4116 * search.c (boyer_moore): Rename locals to avoid shadowing.
76ef09b7
PE
4117 * character.h (FETCH_STRING_CHAR_AS_MULTIBYTE_ADVANCE):
4118 (PREV_CHAR_BOUNDARY): Likewise.
1f3561e4 4119
ded6f8f7
PE
4120 * search.c (simple_search): Remove unused var.
4121
dbd37a95
PE
4122 * dired.c (compile_pattern): Move decl from here ...
4123 * lisp.h: ... to here, so that it can be checked.
4124 (struct re_registers): New forward decl.
4125
7e47afad
PE
4126 * character.h (INC_POS, DEC_POS): Rename locals to avoid shadowing.
4127
85f24f61
PE
4128 * indent.c (MULTIBYTE_BYTES_WIDTH): New args bytes, width.
4129 All uses changed.
4130 (MULTIBYTE_BYTES_WIDTH, scan_for_column, compute_motion):
4131 Rename locals to avoid shadowing.
5671df8f 4132 (Fvertical_motion): Mark locals as initialized.
85f24f61 4133
181aa2be 4134 * casefiddle.c (casify_object, casify_region): Now static.
e45a141a 4135 (casify_region): Mark local as initialized.
181aa2be 4136
930d429c
PE
4137 * cmds.c (internal_self_insert): Rename local to avoid shadowing.
4138
7082eac6
PE
4139 * lisp.h (GCPRO2_VAR, GCPRO3_VAR, GCPRO4_VAR, GCPRO5_VAR, GCPRO6_VAR):
4140 New macros, so that the caller can use some names other than
4141 gcpro1, gcpro2, etc.
4142 (GCPRO2, GCPRO3, GCPRO4, GCPRO5, GCPRO6): Reimplement in terms
4143 of the new macros.
4144 (GCPRO1_VAR, UNGCPRO_VAR): Change the meaning of the second
4145 argument, for consistency with GCPRO2_VAR, etc: it is now the
4146 prefix of the variable, not the variable itself. All uses
4147 changed.
38b2c076
PE
4148 * dired.c (directory_files_internal, file_name_completion):
4149 Rename locals to avoid shadowing.
4150
15206ed9
PE
4151 Fix a race condition diagnosed by gcc -Wsequence-point (Bug#8254).
4152 An expression of the form (DOWNCASE (x) == DOWNCASE (y)), found in
4153 dired.c's scmp function, had undefined behavior.
4154 * lisp.h (DOWNCASE_TABLE, UPCASE_TABLE, DOWNCASE, UPPERCASEP):
4155 (NOCASEP, LOWERCASEP, UPCASE, UPCASE1): Move from here ...
4156 * buffer.h: ... to here, because these macros use current_buffer,
4157 and the new implementation with inline functions needs to have
4158 current_buffer in scope now, rather than later when the macros
4159 are used.
4160 (downcase, upcase1): New static inline functions.
4161 (DOWNCASE, UPCASE1): Reimplement using these functions.
4162 This avoids undefined behavior in expressions like
4163 DOWNCASE (x) == DOWNCASE (y), which previously suffered
4164 from race conditions in accessing the global variables
4165 case_temp1 and case_temp2.
4166 * casetab.c (case_temp1, case_temp2): Remove; no longer needed.
4167 * lisp.h (case_temp1, case_temp2): Remove their decls.
4168 * character.h (ASCII_CHAR_P): Move from here ...
4169 * lisp.h: ... to here, so that the inline functions mentioned
4170 above can use them.
4171
4a6bea26
PE
4172 * dired.c (directory_files_internal_unwind): Now static.
4173
f14b7e14
PE
4174 * fileio.c (file_name_as_directory, directory_file_name):
4175 (barf_or_query_if_file_exists, auto_save_error, auto_save_1):
4176 Now static.
2893f146
PE
4177 (file_name_as_directory): Use const pointers when appropriate.
4178 (Fexpand_file_name): Likewise. In particular, newdir might
4179 point at constant storage, so make it a const pointer.
fd4ead52 4180 (Fmake_directory_internal, Fread_file_name): Remove unused vars.
b14aac08
PE
4181 (Ffile_selinux_context, Fset_file_selinux_context): Fix pointer
4182 signedness issues.
f839df0c
PE
4183 (Fset_file_times, Finsert_file_contents, auto_save_error):
4184 Rename locals to avoid shadowing.
f14b7e14 4185
5716756e 4186 * minibuf.c (choose_minibuf_frame_1): Now static.
62137a95
PE
4187 (Ftry_completion, Fall_completions): Rename or remove locals
4188 to avoid shadowing.
5716756e 4189
b4c3046a
PE
4190 * marker.c (bytepos_to_charpos): Remove; unused.
4191
b45db522
PE
4192 * lisp.h (verify_bytepos, count_markers): New decls,
4193 so that gcc does not warn that these functions aren't declared.
4194
85876d07
PE
4195 * insdel.c (check_markers, make_gap_larger, make_gap_smaller):
4196 (reset_var_on_error, Fcombine_after_change_execute_1): Now static.
f0cb4a60 4197 (CHECK_MARKERS): Redo to avoid gcc -Wempty-body diagnostic.
40ef059e 4198 (copy_text): Remove unused local var.
85876d07 4199
03d78a21 4200 * filelock.c (within_one_second): Now static.
b3dd38ab 4201 (lock_file_1): Rename local to avoid shadowing.
03d78a21 4202
5df8f01b
PE
4203 * buffer.c (fix_overlays_before): Mark locals as initialized.
4204 (fix_start_end_in_overlays): Likewise. This function should be
4205 simplified by using pointers-to-pointers, but that's a different
4206 matter.
b1d876f1 4207 (switch_to_buffer_1): Now static.
8f54f30a
PE
4208 (Fkill_buffer, record_buffer, Fbury_buffer, Fset_buffer_multibyte):
4209 (report_overlay_modification): Rename locals to avoid shadowing.
c3bd59b5 4210
a70072c9 4211 * sysdep.c (system_process_attributes): Rename vars to avoid shadowing.
fbd02d7b 4212 Fix pointer signedness issue.
edced198
PE
4213 (sys_subshell): Mark local as volatile if checking for lint,
4214 to suppress a gcc -Wclobbered warning that does not seem to be right.
15dfd3d9 4215 (MAXPATHLEN): Define only if needed.
a70072c9 4216
a0977c44
PE
4217 * process.c (serial_open, serial_configure): Move decls from here ...
4218 * systty.h: ... to here, so that they can be checked.
4219
a884fdcc
PE
4220 * fns.c (get_random, seed_random): Move extern decls from here ...
4221 * lisp.h: ... to here, so that they can be checked.
4222
604efe86 4223 * sysdep.c (reset_io): Now static.
b8950c94 4224 (wait_for_termination_signal): Remove; unused.
604efe86 4225
38fc62d9
PE
4226 * keymap.c (keymap_parent, keymap_memberp, map_keymap_internal):
4227 (copy_keymap_item, append_key, push_text_char_description):
4228 Now static.
1004a21a 4229 (Fwhere_is_internal): Don't test CONSP (sequences) unnecessarily.
dbbb8427 4230 (DENSE_TABLE_SIZE): Remove; unused.
c1141155
PE
4231 (get_keymap, access_keymap, Fdefine_key, Fwhere_is_internal):
4232 (describe_map_tree):
4233 Rename locals to avoid shadowing.
38fc62d9 4234
2f2650da
PE
4235 * keyboard.c: Declare functions static if they are not used elsewhere.
4236 (echo_char, echo_dash, cmd_error, top_level_2):
4237 (poll_for_input, handle_async_input): Now static.
69a058fa
PE
4238 (read_char, kbd_buffer_get_event, make_lispy_position):
4239 (make_lispy_event, make_lispy_movement, apply_modifiers):
4240 (decode_keyboard_code, tty_read_avail_input, menu_bar_items):
4241 (parse_tool_bar_item, read_key_sequence, Fread_key_sequence):
4242 (Fread_key_sequence_vector): Rename locals to avoid shadowing.
c8a06054 4243 (read_key_sequence, read_char): Mark locals as initialized.
3ac94672 4244 (Fexit_recursive_edit, Fabort_recursive_edit): Mark with NO_RETURN.
2f2650da 4245
a053e86c 4246 * keyboard.h (make_ctrl_char): New decl.
da2f2dd9
PE
4247 (mark_kboards): Move decl here ...
4248 * alloc.c (mark_kboards): ... from here.
a053e86c 4249
4752793e
PE
4250 * lisp.h (force_auto_save_soon): New decl.
4251
74f10ca7 4252 * emacs.c (init_cmdargs): Rename local to avoid shadowing.
244fc23d
PE
4253 (DEFINE_DUMMY_FUNCTION): New macro.
4254 (__do_global_ctors, __do_global_ctors_aux, __do_global_dtors, __main):
4255 Use it.
c03cd23f
PE
4256 (main): Add casts to avoid warnings
4257 if GCC considers string literals to be constants.
74f10ca7 4258
022e70d4
PE
4259 * lisp.h (fatal_error_signal): Add decl, since it's exported.
4260
59d6fe83
PE
4261 * dbusbind.c: Pointer signedness fixes.
4262 (xd_signature, xd_append_arg, xd_initialize):
4263 (Fdbus_call_method, Fdbus_call_method_asynchronously):
4264 (Fdbus_method_return_internal, Fdbus_method_error_internal):
4265 (Fdbus_send_signal, xd_read_message_1, Fdbus_register_service):
4266 (Fdbus_register_signal): Use SSDATA when the context wants char *.
4267
78320123
PE
4268 * dbusbind.c (Fdbus_init_bus): Add cast to avoid warning
4269 if GCC considers string literals to be constants.
49cebcca 4270 (Fdbus_register_service, Fdbus_register_method): Remove unused vars.
78320123 4271
35ac2a97
SM
42722011-03-16 Stefan Monnier <monnier@iro.umontreal.ca>
4273
fb103ca9
SM
4274 * print.c (PRINT_CIRCLE_CANDIDATE_P): New macro.
4275 (print_preprocess, print_object): New macro to fix last change.
4276
35ac2a97
SM
4277 * print.c (print_preprocess): Don't forget font objects.
4278
62973b41
JB
42792011-03-16 Juanma Barranquero <lekktu@gmail.com>
4280
4281 * emacs.c (USAGE3): Doc fixes.
4282
0e48bb22
AS
42832011-03-15 Andreas Schwab <schwab@linux-m68k.org>
4284
4285 * coding.c (detect_coding_iso_2022): Reorganize code to clarify
4286 structure.
4287
7684e57b
JB
42882011-03-14 Juanma Barranquero <lekktu@gmail.com>
4289
4290 * lisp.h (VWindow_system, Qfile_name_history):
4291 * keyboard.h (lispy_function_keys) [WINDOWSNT]:
4292 * w32term.h (w32_system_caret_hwnd, w32_system_caret_height)
4293 (w32_system_caret_x, w32_system_caret_y): Declare extern.
4294
4295 * w32select.c: Don't #include "keyboard.h".
c96bbc66 4296 (run_protected): Add extern declaration for waiting_for_input.
7684e57b
JB
4297
4298 * w32.c (Qlocal, noninteractive1, inhibit_window_system):
4299 * w32console.c (detect_input_pending, read_input_pending)
4300 (encode_terminal_code):
4301 * w32fns.c (quit_char, lispy_function_keys, Qtooltip)
4302 (w32_system_caret_hwnd, w32_system_caret_height, w32_system_caret_x)
4303 (w32_system_caret_y, Qfile_name_history):
4304 * w32font.c (w32font_driver, QCantialias, QCotf, QClang):
4305 * w32inevt.c (reinvoke_input_signal, lispy_function_keys):
4306 * w32menu.c (Qmenu_bar, QCtoggle, QCradio, Qoverriding_local_map)
4307 (Qoverriding_terminal_local_map, Qmenu_bar_update_hook):
4308 * w32proc.c (Qlocal, report_file_error):
4309 * w32term.c (Vwindow_system, updating_frame):
4310 * w32uniscribe.c (initialized, uniscribe_font_driver):
4311 Remove unneeded extern declarations.
4312
2aa46d6c
CY
43132011-03-14 Chong Yidong <cyd@stupidchicken.com>
4314
c96bbc66 4315 * buffer.c (Fmake_indirect_buffer): Fix incorrect assertions.
2aa46d6c 4316
cffc6f3b
CY
43172011-03-13 Chong Yidong <cyd@stupidchicken.com>
4318
4319 * buffer.h (BUF_BEGV, BUF_BEGV_BYTE, BUF_ZV, BUF_ZV_BYTE, BUF_PT)
4320 (BUF_PT_BYTE): Rewrite to handle indirect buffers (Bug#8219).
4321 These macros can no longer be used for assignment.
4322
44f230aa
SM
4323 * buffer.c (Fget_buffer_create, Fmake_indirect_buffer):
4324 Assign struct members directly, instead of using BUF_BEGV etc.
cffc6f3b
CY
4325 (record_buffer_markers, fetch_buffer_markers): New functions for
4326 recording and fetching special buffer markers.
4327 (set_buffer_internal_1, set_buffer_temp): Use them.
4328
4329 * lread.c (unreadchar): Use SET_BUF_PT_BOTH.
4330
4331 * insdel.c (adjust_point): Use SET_BUF_PT_BOTH.
4332
4333 * intervals.c (temp_set_point_both): Use SET_BUF_PT_BOTH.
4334 (get_local_map): Use SET_BUF_BEGV_BOTH and SET_BUF_ZV_BOTH.
4335
4336 * xdisp.c (hscroll_window_tree):
4337 (reconsider_clip_changes): Use PT instead of BUF_PT.
4338
d251f04b
EZ
43392011-03-13 Eli Zaretskii <eliz@gnu.org>
4340
4341 * makefile.w32-in ($(BLD)/editfns.$(O)): Depend on
4342 $(EMACS_ROOT)/lib/intprops.h.
4343
f0c77cd1
PE
43442011-03-13 Paul Eggert <eggert@cs.ucla.edu>
4345
3eca4629
PE
4346 Fix more problems found by GCC 4.5.2's static checks.
4347
7c86ee98
PE
4348 * gtkutil.c (xg_get_pixbuf_from_pixmap): Add cast from char *
4349 to unsigned char * to avoid compiler diagnostic.
b0afc268
PE
4350 (xg_free_frame_widgets): Make it clear that a local variable is
4351 needed only if USE_GTK_TOOLTIP.
01e0b5ad
PE
4352 (gdk_window_get_screen): Make it clear that this macro is needed
4353 only if USE_GTK_TOOLTIP.
1e5524e7
PE
4354 (int_gtk_range_get_value): New function, which avoids a diagnostic
4355 from gcc -Wbad-function-cast.
4356 (xg_set_toolkit_scroll_bar_thumb): Use it.
4357 (xg_tool_bar_callback, xg_tool_item_stale_p): Rewrite to avoid
4358 diagnostic from gcc -Wbad-function-cast.
65dc836c
PE
4359 (get_utf8_string, xg_get_file_with_chooser):
4360 Rename locals to avoid shadowing.
4361 (create_dialog): Move locals to avoid shadowing.
7c86ee98 4362
41729b81
PE
4363 * xgselect.c (xg_select): Remove unused var.
4364
f0c77cd1
PE
4365 * image.c (four_corners_best): Mark locals as initialized.
4366 (gif_load): Initialize transparent_p to zero (Bug#8238).
4367 Mark another local as initialized.
ec6cf4c6 4368 (my_png_error, my_error_exit): Mark with NO_RETURN.
f0c77cd1 4369
ce0ad53d 4370 * image.c (clear_image_cache): Now static.
d5d5a617 4371 (DIM, HAVE_STDLIB_H_1): Remove unused macros.
e22cffbc 4372 (xpm_load): Redo to avoid "discards qualifiers" gcc warning.
77a765fd
PE
4373 (x_edge_detection): Remove unnecessary cast that
4374 gcc -Wbad-function-cast diagnoses.
2037898d 4375 (gif_load): Fix pointer signedness.
6ae141d6
PE
4376 (clear_image_cache, xbm_read_bitmap_data, x_detect_edges):
4377 (jpeg_load, gif_load): Rename locals to avoid shadowing.
ce0ad53d 4378
33383987 43792011-03-12 Paul Eggert <eggert@cs.ucla.edu>
3eca4629 4380
d32df629
PE
4381 Improve quality of tests for time stamp overflow.
4382 For example, without this patch (encode-time 0 0 0 1 1
4383 1152921504606846976) returns the obviously-bogus value (-948597
4384 62170) on my RHEL 5.5 x86-64 host. With the patch, it correctly
4385 reports time overflow. See
4386 <http://lists.gnu.org/archive/html/emacs-devel/2011-03/msg00470.html>.
b8d9bd41
PE
4387 * deps.mk (editfns.o): Depend on ../lib/intprops.h.
4388 * editfns.c: Include limits.h and intprops.h.
4389 (TIME_T_MIN, TIME_T_MAX): New macros.
4390 (time_overflow): Move earlier, to before first use.
4391 (hi_time, lo_time): New functions, for an accurate test for
4392 out-of-range times.
4393 (Fcurrent_time, Fget_internal_run_time, make_time): Use them.
4394 (Fget_internal_run_time): Don't assume time_t fits in int.
4395 (make_time): Use list2 instead of Fcons twice.
4396 (Fdecode_time): More accurate test for out-of-range times.
4397 (check_tm_member): New function.
4398 (Fencode_time): Use it, to test for out-of-range times.
d32df629
PE
4399 (lisp_time_argument): Don't rely on undefined left-shift and
4400 right-shift behavior when checking for time stamp overflow.
8be6f318 4401
fe31d94c
PE
4402 * editfns.c (time_overflow): New function, refactoring common code.
4403 (Fformat_time_string, Fdecode_time, Fencode_time):
4404 (Fcurrent_time_string): Use it.
4405
8be6f318
PE
4406 Move 'make_time' to be next to its inverse 'lisp_time_argument'.
4407 * dired.c (make_time): Move to ...
4408 * editfns.c (make_time): ... here.
4409 * systime.h: Note the move.
4410
09d9db2c 44112011-03-12 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
c47cbdfd 4412
126bc0dc
YM
4413 * fringe.c (update_window_fringes): Remove unused variables.
4414
c47cbdfd
YM
4415 * unexmacosx.c (copy_data_segment): Also copy __got section.
4416 (Bug#8223)
4417
7ac80be9
EZ
44182011-03-12 Eli Zaretskii <eliz@gnu.org>
4419
c96bbc66 4420 * termcap.c [MSDOS]: Include "msdos.h".
058e5dad
EZ
4421 (find_capability, tgetnum, tgetflag, tgetstr, tputs, tgetent):
4422 Constify `char *' arguments and their references according to
4423 prototypes in tparam.h.
4424
ecb0f94d 4425 * deps.mk (termcap.o): Depend on tparam.h and msdos.h.
058e5dad 4426
7ac80be9
EZ
4427 * msdos.c (XMenuAddPane): 3rd argument is `const char *' now.
4428 Adapt all references accordingly.
4429
4430 * msdos.h (XMenuAddPane): 3rd argument is `const char *' now.
4431
ef1fd07e
TT
44322011-03-11 Tom Tromey <tromey@redhat.com>
4433
4434 * buffer.c (syms_of_buffer): Remove obsolete comment.
4435
7ef4b50c
EZ
44362011-03-11 Eli Zaretskii <eliz@gnu.org>
4437
4438 * termhooks.h (encode_terminal_code): Declare prototype.
4439
4440 * msdos.c (encode_terminal_code): Don't declare prototype.
4441
4442 * term.c (encode_terminal_code): Now external again, used by
4443 w32console.c and msdos.c.
4444
44f230aa
SM
4445 * makefile.w32-in ($(BLD)/term.$(O), ($(BLD)/tparam.$(O)):
4446 Depend on $(SRC)/tparam.h, see 2011-03-11T07:24:21Z!eggert@cs.ucla.edu.
7ef4b50c 4447
4b1ec863 44482011-03-11 Paul Eggert <eggert@cs.ucla.edu>
f78faa98 4449
1714f52b 4450 Fix some minor problems found by GCC 4.5.2's static checks.
83316bf4 4451
4b1ec863
PE
4452 * fringe.c (update_window_fringes): Mark locals as initialized
4453 (Bug#8227).
4454 (destroy_fringe_bitmap, init_fringe_bitmap): Now static.
bf60f616 4455
524c7aa6
PE
4456 * alloc.c (mark_fringe_data): Move decl from here ...
4457 * lisp.h (mark_fringe_data) [HAVE_WINDOW_SYSTEM]: ... to here,
4458 to check its interface.
4459 (init_fringe_once): Do not declare unless HAVE_WINDOW_SYSTEM.
4460
a5c0af81 4461 * fontset.c (free_realized_fontset): Now static.
7519b8cd 4462 (Fset_fontset_font): Rename local to avoid shadowing.
cc6e5db1 4463 (fontset_font): Mark local as initialized.
a9a06e0b 4464 (FONTSET_SPEC, FONTSET_REPERTORY, RFONT_DEF_REPERTORY): Remove; unused.
a5c0af81 4465
b4716021
PE
4466 * xrdb.c: Include "xterm.h", to check x_load_resources's interface.
4467
811e9bac 4468 * xselect.c (x_disown_buffer_selections): Remove; not used.
7b83e2f1 4469 (TRACE3) [!defined TRACE_SELECTION]: Remove; not used.
aa0daa9f
PE
4470 (x_own_selection, Fx_disown_selection_internal): Rename locals
4471 to avoid shadowing.
4472 (x_handle_dnd_message): Remove local to avoid shadowing.
811e9bac 4473
7e3ab302
PE
4474 * lisp.h (GCPRO1_VAR, UNGCPRO_VAR): New macros,
4475 so that the caller can use some name other than gcpro1.
4476 (GCPRO1, UNGCPRO): Reimplement in terms of the new macros.
58d2d479
PE
4477 * xfns.c (Fx_create_frame, x_create_tip_frame, Fx_show_tip):
4478 (Fx_backspace_delete_keys_p):
4479 Use them to avoid shadowing, and rename vars to avoid shadowing.
4480 (x_decode_color, x_set_name, x_window): Now static.
6b437900 4481 (Fx_create_frame): Add braces to silence GCC warning.
c0951e53 4482 (Fx_file_dialog, Fx_select_font): Fix pointer signedness.
06b0c8a0
PE
4483 (x_real_positions, xg_set_icon_from_xpm_data, x_create_tip_frame):
4484 Remove unused locals.
7e3ab302
PE
4485 (Fx_create_frame, x_create_tip_frame, Fx_show_tip):
4486 (Fx_backspace_delete_keys_p): Rename locals to avoid shadowing.
4487 Some of these renamings use the new GCPRO1_VAR and UNGCPRO_VAR
4488 macros.
f78faa98 4489
e2b13473
PE
4490 * xterm.h (x_mouse_leave): New decl.
4491
77f23912
PE
4492 * xterm.c (x_copy_dpy_color, x_focus_on_frame, x_unfocus_frame):
4493 Remove unused functions.
cdf4ba58
PE
4494 (x_shift_glyphs_for_insert, XTflash, XTring_bell):
4495 (x_calc_absolute_position): Now static.
7411c686 4496 (XTread_socket): Don't define label "out" unless it's used.
2b07bcff 4497 Don't declare local "event" unless it's used.
ed7bf3a5
PE
4498 (x_iconify_frame, x_free_frame_resources): Don't declare locals
4499 unless they are used.
38d0b34a
PE
4500 (XEMBED_VERSION, xembed_set_info): Don't define unless needed.
4501 (x_fatal_error_signal): Remove; not used.
a6067996
PE
4502 (x_draw_image_foreground, redo_mouse_highlight, XTmouse_position):
4503 (x_scroll_bar_report_motion, handle_one_xevent, x_draw_bar_cursor):
4504 (x_error_catcher, x_connection_closed, x_error_handler):
4505 (x_error_quitter, xembed_send_message, x_iconify_frame):
4506 (my_log_handler): Rename locals to avoid shadowing.
28f1c698 4507 (x_delete_glyphs, x_ins_del_lines): Mark with NO_RETURN.
2a8fade0 4508 (x_connection_closed): Tell GCC not to suggest NO_RETURN.
77f23912 4509
44f230aa
SM
4510 * xfaces.c (clear_face_cache, Fx_list_fonts, Fface_font):
4511 Rename or move locals to avoid shadowing.
6b463e58 4512 (tty_defined_color, merge_face_heights): Now static.
5967d051 4513 (free_realized_faces_for_fontset): Remove; not used.
1e9966ea
PE
4514 (Fx_list_fonts): Mark variable that gcc -Wuninitialized
4515 does not deduce is never used uninitialized.
73719eba
PE
4516 (STRDUPA, LSTRDUPA, FONT_POINT_SIZE_QUANTUM): Remove; not used.
4517 (LFACEP): Define only if XASSERTS, as it's not needed otherwise.
071048a3 4518
426994c3 4519 * terminal.c (store_terminal_param): Now static.
5489860b 4520
032f1620 4521 * xmenu.c (menu_highlight_callback): Now static.
9d66f88e 4522 (set_frame_menubar): Remove unused local.
d4323972 4523 (xmenu_show): Rename parameter to avoid shadowing.
6d1f7fee
PE
4524 (xmenu_show, xdialog_show, xmenu_show): Make local pointers "const"
4525 since they might point to immutable storage.
281585b0
PE
4526 (next_menubar_widget_id): Declare only if USE_X_TOOLKIT,
4527 since it's unused otherwise.
032f1620 4528
367c19e5 4529 * xdisp.c (produce_glyphless_glyph): Initialize lower_xoff.
53df7c11 4530 Add a FIXME, since the code still doesn't look right. (Bug#8215)
9f36b9fd
PE
4531 (Fcurrent_bidi_paragraph_direction): Simplify slightly; this
4532 avoids a gcc -Wuninitialized diagnostic.
0e086e8f 4533 (display_line, BUILD_COMPOSITE_GLYPH_STRING, draw_glyphs):
44a3a108
PE
4534 (note_mouse_highlight): Mark variables that gcc -Wuninitialized
4535 does not deduce are never used uninitialized.
70739cbe 4536
07b48fa9
PE
4537 * lisp.h (IF_LINT): New macro, copied from ../lib-src/emacsclient.c.
4538
8868a238 4539 * xdisp.c (redisplay_window): Rename local to avoid shadowing.
4554d213
PE
4540 * window.c (window_loop, size_window):
4541 (run_window_configuration_change_hook, enlarge_window): Likewise.
8868a238 4542
7e5cf297 4543 * window.c (display_buffer): Now static.
d6550a9f
PE
4544 (size_window): Mark variables that gcc -Wuninitialized
4545 does not deduce are never used uninitialized.
a586633d
PE
4546 * window.h (check_all_windows): New decl, to forestall
4547 gcc -Wmissing-prototypes diagnostic.
5b555da1 4548 * dispextern.h (bidi_dump_cached_states): Likewise.
7e5cf297 4549
f6095868
PE
4550 * charset.h (CHECK_CHARSET_GET_CHARSET): Rename locals to avoid
4551 shadowing.
4552 * charset.c (map_charset_for_dump, Fchar_charset): Likewise.
726929c4
PE
4553 Include <limits.h>.
4554 (Fsort_charsets): Redo min/max calculation to shorten the code a bit
4555 and to avoid gcc -Wuninitialized warning.
89ef49df
PE
4556 (load_charset_map): Mark variables that gcc -Wuninitialized
4557 does not deduce are never used uninitialized.
53df7c11 4558 (load_charset): Abort instead of using uninitialized var (Bug#8229).
f6095868 4559
f38b440c
PE
4560 * coding.c (coding_set_source, coding_set_destination):
4561 Use "else { /* comment */ }" rather than "else /* comment */;"
4562 for clarity, and to avoid gcc -Wempty-body warning.
2735d060
PE
4563 (Fdefine_coding_system_internal): Don't redeclare 'i' inside
4564 a block, when the outer 'i' will do.
4565 (decode_coding_utf_8, decode_coding_utf_16, detect_coding_emacs_mule):
4566 (emacs_mule_char, decode_coding_emacs_mule, detect_coding_iso_2022):
4567 (decode_coding_iso_2022, decode_coding_sjis, decode_coding_big5):
4568 (decode_coding_raw_text, decode_coding_charset, get_translation_table):
4569 (Fdecode_sjis_char, Fdefine_coding_system_internal):
4570 Rename locals to avoid shadowing.
4571 * character.h (FETCH_STRING_CHAR_ADVANCE): Likewise.
e2f1bab9
PE
4572 * coding.c (emacs_mule_char, encode_invocation_designation):
4573 Now static, since they're not used elsewhere.
413bb2db 4574 (decode_coding_iso_2022): Add "default: abort ();" as a safety check.
c4a63b12 4575 (decode_coding_object, encode_coding_object, detect_coding_system):
ee05f961
PE
4576 (decode_coding_emacs_mule): Mark variables that gcc
4577 -Wuninitialized does not deduce are never used uninitialized.
160b01f6
PE
4578 (detect_coding_iso_2022): Initialize a local variable that might
4579 be used uninitialized. Leave a FIXME because it's not clear that
53df7c11 4580 this initialization is needed. (Bug#8211)
5f58e762
PE
4581 (ISO_CODE_LF, ISO_CODE_CR, CODING_ISO_FLAG_EUC_TW_SHIFT):
4582 (ONE_MORE_BYTE_NO_CHECK, UTF_BOM, UTF_16_INVALID_P):
4583 (SHIFT_OUT_OK, ENCODE_CONTROL_SEQUENCE_INTRODUCER):
4584 (ENCODE_DIRECTION_R2L, ENCODE_DIRECTION_L2R):
4585 Remove unused macros.
f38b440c 4586
232b38b9 4587 * category.c (hash_get_category_set): Remove unused local var.
9f3b5e69 4588 (copy_category_table): Now static, since it's not used elsewhere.
d0891610 4589 * character.c (string_count_byte8): Likewise.
232b38b9 4590
fb90da1b
PE
4591 * ccl.c (CCL_WRITE_STRING, CCL_ENCODE_CHAR, Fccl_execute_on_string):
4592 (Fregister_code_conversion_map): Rename locals to avoid shadowing.
4593
fb93dbc2
PE
4594 * chartab.c (copy_sub_char_table): Now static, since it's not used
4595 elsewhere.
5c156ace
PE
4596 (sub_char_table_ref_and_range, char_table_ref_and_range):
4597 Rename locals to avoid shadowing.
bbcd0949 4598 (ASET_RANGE, GET_SUB_CHAR_TABLE): Remove unused macros.
fb93dbc2 4599
7d3b3862 4600 * bidi.c (bidi_check_type): Now static, since it's not used elsewhere.
630d6892 4601 (BIDI_BOB): Remove unused macro.
7d3b3862 4602
6be7d3da
PE
4603 * cm.c (cmgoto): Mark variables that gcc -Wuninitialized does not
4604 deduce are never used uninitialized.
c2ed9c8b 4605 * term.c (encode_terminal_code): Likewise.
6be7d3da 4606
75f8807f 4607 * term.c (encode_terminal_code): Now static. Remove unused local.
72abad34 4608
50938595
PE
4609 * tparam.h: New file.
4610 * term.c, tparam.h: Include it.
4611 * deps.mk (term.o, tparam.o): Depend on tparam.h.
4612 * term.c (tputs, tgetent, tgetflag, tgetnum, tparam, tgetstr):
4613 Move these decls to tparam.h, and make them agree with what
4614 is actually in tparam.c. The previous trick of using incompatible
4615 decls in different modules does not conform to the C standard.
4616 All callers of tparam changed to use tparam's actual API.
4617 * tparam.c (tparam1, tparam, tgoto):
4618 Use const pointers where appropriate.
4619
fbceeba2
PE
4620 * cm.c (calccost, cmgoto): Use const pointers where appropriate.
4621 * cm.h (struct cm): Likewise.
4622 * dispextern.h (do_line_insertion_deletion_costs): Likewise.
4623 * scroll.c (ins_del_costs, do_line_insertion_deletion_costs): Likewise.
4624 * term.c (tty_ins_del_lines, calculate_costs, struct fkey_table):
4625 (term_get_fkeys_1, append_glyphless_glyph, produce_glyphless_glyph):
4626 (turn_on_face, init_tty): Likewise.
4627 * termchar.h (struct tty_display_info): Likewise.
fbceeba2 4628
7f3f1250
PE
4629 * term.c (term_mouse_position): Rename local to avoid shadowing.
4630
e6ca6543
PE
4631 * alloc.c (mark_ttys): Move decl from here ...
4632 * lisp.h (mark_ttys): ... to here, so that it's checked against defn.
4633
c40f8d15
AS
46342011-03-11 Andreas Schwab <schwab@linux-m68k.org>
4635
4636 * .gdbinit (pwinx, xbuffer): Fix access to buffer name.
4637
cfe0661d
JB
46382011-03-09 Juanma Barranquero <lekktu@gmail.com>
4639
4640 * search.c (compile_pattern_1): Remove argument regp, unused since
4641 revid:rms@gnu.org-19941211082627-3x1g1wyqkjmwloig.
4642 (compile_pattern): Don't pass it.
4643
0afb4571
J
46442011-03-08 Jan Djärv <jan.h.d@swipnet.se>
4645
4646 * xterm.h (DEFAULT_GDK_DISPLAY): New define.
4647 (GDK_WINDOW_XID, gtk_widget_get_preferred_size): New defines
4648 for ! HAVE_GTK3.
4649 (GTK_WIDGET_TO_X_WIN): Use GDK_WINDOW_XID.
4650
4651 * xmenu.c (menu_position_func): Call gtk_widget_get_preferred_size.
4652
4653 * gtkutil.c: Include gtkx.h if HAVE_GTK3. If ! HAVE_GTK3, define
4654 gdk_window_get_screen, gdk_window_get_geometry,
4655 gdk_x11_window_lookup_for_display and GDK_KEY_g.
4656 (xg_set_screen): Use DEFAULT_GDK_DISPLAY.
4657 (xg_get_pixbuf_from_pixmap): New function.
4658 (xg_get_pixbuf_from_pix_and_mask): Change parameters from GdkPixmap
4659 to Pixmap, take frame as parameter, remove GdkColormap parameter.
4660 Call xg_get_pixbuf_from_pixmap instead of
4661 gdk_pixbuf_get_from_drawable.
4662 (xg_get_image_for_pixmap): Do not make GdkPixmaps, call
4663 xg_get_pixbuf_from_pix_and_mask with Pixmap parameters instead.
4664 (xg_check_special_colors): Use GtkStyleContext and its functions
4665 for HAVE_GTK3.
4666 (xg_prepare_tooltip, xg_hide_tooltip): Call gdk_window_get_screen.
4667 (xg_prepare_tooltip, create_dialog, menubar_map_cb)
4668 (xg_update_frame_menubar, xg_tool_bar_detach_callback)
44f230aa
SM
4669 (xg_tool_bar_attach_callback, xg_update_tool_bar_sizes):
4670 Call gtk_widget_get_preferred_size.
0afb4571
J
4671 (xg_frame_resized): gdk_window_get_geometry only takes 5
4672 parameters.
44f230aa
SM
4673 (xg_win_to_widget, xg_event_is_for_menubar):
4674 Call gdk_x11_window_lookup_for_display.
0afb4571
J
4675 (xg_set_widget_bg): New function.
4676 (delete_cb): New function.
895009e1 4677 (xg_create_frame_widgets): Connect delete-event to delete_cb.
0afb4571
J
4678 Call xg_set_widget_bg. Only set backgrund pixmap for ! HAVE_GTK3
4679 (xg_set_background_color): Call xg_set_widget_bg.
4680 (xg_set_frame_icon): Call xg_get_pixbuf_from_pix_and_mask.
4681 (xg_create_scroll_bar): vadj is a GtkAdjustment for HAVE_GTK3.
4682 Only call gtk_range_set_update_policy if ! HAVE_GTK3.
4683 (xg_make_tool_item): Only connect xg_tool_bar_item_expose_callback
4684 if ! HAVE_GTK3.
4685 (update_frame_tool_bar): Call gtk_widget_hide.
4686 (xg_initialize): Use GDK_KEY_g.
4687
4688 * xsmfns.c (gdk_set_sm_client_id): Define to gdk_set_sm_client_id
4689 if ! HAVE_GTK3
4690 (x_session_initialize): Call gdk_x11_set_sm_client_id.
4691
4692 * xterm.c (XFillRectangle): Use cairo routines for HAVE_GTK3.
4693 (x_term_init): Disable Xinput(2) with GDK_CORE_DEVICE_EVENTS.
4694 Load ~/emacs.d/gtkrc only for ! HAVE_GTK3.
4695
1c2cc4ef
JB
46962011-03-08 Juanma Barranquero <lekktu@gmail.com>
4697
4698 * w32xfns.c (select_palette): Check success of RealizePalette against
4699 GDI_ERROR, not zero.
4700
33383987 4701See ChangeLog.11 for earlier changes.
aac0c6e3
MR
4702
4703;; Local Variables:
4704;; coding: utf-8
aac0c6e3
MR
4705;; End:
4706
33383987 4707 Copyright (C) 2011 Free Software Foundation, Inc.
aac0c6e3
MR
4708
4709 This file is part of GNU Emacs.
4710
4711 GNU Emacs is free software: you can redistribute it and/or modify
4712 it under the terms of the GNU General Public License as published by
4713 the Free Software Foundation, either version 3 of the License, or
4714 (at your option) any later version.
4715
4716 GNU Emacs is distributed in the hope that it will be useful,
4717 but WITHOUT ANY WARRANTY; without even the implied warranty of
4718 MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
4719 GNU General Public License for more details.
4720
4721 You should have received a copy of the GNU General Public License
4722 along with GNU Emacs. If not, see <http://www.gnu.org/licenses/>.