callproc.c (Fcall_process): Set the member dst_multibyte of process_coding.
[bpt/emacs.git] / src / ChangeLog
CommitLineData
659afede
KH
12011-11-11 Kenichi Handa <handa@m17n.org>
2
3 * callproc.c (Fcall_process): Set the member dst_multibyte of
4 process_coding.
5
9ac0394b
KH
62011-11-11 Johan Bockgård <bojohan@gnu.org>
7
8 * xdisp.c (fill_composite_glyph_string): Always set s->face, to
9 avoid a crash (bug#9496).
10
2fbdc249
CY
112011-11-09 Chong Yidong <cyd@gnu.org>
12
13 * window.c (Fwindow_inside_edges, Fwindow_inside_pixel_edges)
14 (Fwindow_inside_absolute_pixel_edges): Only allow live windows.
15
ac6b1f81
PE
162011-11-08 Paul Eggert <eggert@cs.ucla.edu>
17
18 * s/gnu.h (GC_MARK_STACK): Define to GC_MAKE_GCPROS_NOOPS (Bug#9926).
19
09db192c
PE
202011-11-08 Paul Eggert <eggert@cs.ucla.edu>
21
22 Avoid some portability problems by eschewing 'extern inline' functions.
23 The trivial performance wins aren't worth the portability hassles; see
24 <http://lists.gnu.org/archive/html/emacs-devel/2011-11/msg00084.html>
25 et seq.
26 * dispextern.h (window_box, window_box_height, window_text_bottom_y)
27 (window_box_width, window_box_left, window_box_left_offset)
28 (window_box_right, window_box_right_offset): Undo previous change,
29 by removing the "extern"s.
30 * intervals.c (adjust_intervals_for_insertion)
31 (adjust_intervals_for_deletion): Undo previous change,
32 making these static again.
33 (offset_intervals, temp_set_point_both, temp_set_point)
34 (copy_intervals_to_string): No longer inline.
35 * xdisp.c (window_text_bottom_y, window_box_width)
36 (window_box_height, window_box_left_offset)
37 (window_box_right_offset, window_box_left, window_box_right)
38 (window_box): No longer inline.
39
105216ed
CY
402011-11-08 Chong Yidong <cyd@gnu.org>
41
42 * window.c (Fwindow_left_column, Fwindow_top_line): Doc fix.
43 (Fwindow_body_height, Fwindow_body_width): Move from Lisp. Signal
44 an error if not a live window.
45 (Fwindow_total_width, Fwindow_total_height): Move from Lisp.
46 (Fwindow_total_size, Fwindow_body_size): Move to Lisp.
47
ae9e237f
JB
482011-11-07 Juanma Barranquero <lekktu@gmail.com>
49
50 * lisp.h (syms_of_abbrev): Remove declaration.
51 Reported by CHENG Gao <chenggao@royau.me>.
52
c7aa8333
EZ
532011-11-07 Eli Zaretskii <eliz@gnu.org>
54
55 * w32.c (check_windows_init_file): Don't look for term/w32-win.el
56 if Vpurify_flag is non-nil. Fixes a crash when running w32 build
57 of temacs in GUI mode.
58
be7f5545
MR
592011-11-07 Martin Rudalics <rudalics@gmx.at>
60
61 * window.h: Declare delete_all_child_windows instead of
62 delete_all_subwindows.
63 * window.c (Fwindow_nest, Fset_window_nest)
64 (Fset_window_new_total, Fset_window_new_normal)
65 (Fwindow_resize_apply): Don't use term subwindow in doc-strings.
66 (delete_all_subwindows): Rename to delete_all_child_windows.
67 (Fdelete_other_windows_internal, Fset_window_configuration):
68 Call delete_all_child_windows instead of delete_all_subwindows.
69 * frame.c (delete_frame): Call delete_all_child_windows instead
70 of delete_all_subwindows.
71
ca78dc43
PE
722011-11-07 Paul Eggert <eggert@cs.ucla.edu>
73
74 * alloc.c (DEADP): New macro, for porting to GNU/Hurd (Bug#9926).
75 This is also needed for porting to any host where GC_MARK_STACK is
76 not GC_MAKE_GCPROS_NOOPS.
77 (which_symbols): Use it.
78
a0241d01
KH
792011-11-07 Kenichi Handa <handa@m17n.org>
80
81 * coding.c (coding_set_destination): Check coding->src_pos only
82 when coding->src_object is a buffer (bug#9910).
83
84 * process.c (send_process): Set the member src_multibyte of coding
85 to 0 (bug#9911) when sending a unibyte text.
86
87 * callproc.c (Fcall_process): Set the member src_multibyte of
88 process_coding to 0 (bug#9912).
89
a64bfdfa 902011-11-06 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
ba24cea2
YM
91
92 * xmenu.c (cleanup_widget_value_tree): New function.
93 (xmenu_show, xdialog_show): Use it in record_unwind_protect instead of
94 calling free_menubar_widget_value_tree directly (Bug#9830).
95
cb41b32a
PE
962011-11-06 Paul Eggert <eggert@cs.ucla.edu>
97
98 Fix some portability problems with 'inline'.
99 * dispextern.h (window_box, window_box_height, window_text_bottom_y)
100 (window_box_width, window_box_left, window_box_left_offset)
101 (window_box_right, window_box_right_offset): Declare extern.
102 Otherwise, these inline functions do not conform to C99 and
103 are miscompiled by Microsoft compilers. Reported by Eli Zaretskii in
104 <http://lists.gnu.org/archive/html/emacs-devel/2011-11/msg00084.html>.
105 * intervals.c (adjust_intervals_for_insertion)
106 (adjust_intervals_for_deletion): Now extern, because otherwise the
107 extern inline functions 'offset_intervals' couldn't refer to it.
108 (static_offset_intervals): Remove.
109 (offset_intervals): Rewrite using the old contents of
110 static_offset_intervals. The old version didn't conform to C99
111 because an extern inline function contained a reference to an
112 identifier with static linkage.
113
b7041366
AS
1142011-11-06 Andreas Schwab <schwab@linux-m68k.org>
115
116 * keyboard.c (interrupt_signal): Don't call kill-emacs while in
117 GC.
118
88a37c4d
EZ
1192011-11-06 Eli Zaretskii <eliz@gnu.org>
120
121 * xdisp.c (init_iterator, reseat_to_string): Don't set the
122 iterator's bidi_p flag if Vpurify_flag is non-nil. (Bug#9963)
123 (Fcurrent_bidi_paragraph_direction): If Vpurify_flag is non-nil,
124 return Qleft_to_right.
125
49745b39
CY
1262011-11-06 Chong Yidong <cyd@gnu.org>
127
128 * window.c (Fwindow_live_p, Fwindow_frame, Fframe_root_window)
129 (Fminibuffer_window, Fwindow_buffer, Fwindow_splits)
130 (Fset_window_splits, Fwindow_nest, Fset_window_nest)
131 (Fwindow_use_time, Fwindow_total_size, Fwindow_normal_size)
132 (Fwindow_new_normal, Fwindow_left_column, Fwindow_top_line)
133 (Fwindow_margins, Fwindow_fringes, Fwindow_scroll_bars)
134 (Fwindow_vscroll): Doc fix.
135 (Fwindow_top_child, Fwindow_left_child): Eliminate a nil default
136 argument, since it makes no sense to pass a live window and for
137 consistency with window-child.
138
1f05cd82
CS
1392011-11-05 Christoph Scholtes <cschol2112@googlemail.com>
140
141 * makefile.w32-in ($(TEMACS), (gl-stamp)): Use $(THISDIR) to
142 support MSVC.
143
22610910
JR
1442011-11-05 Jason Rumney <jasonr@gnu.org>
145
146 * w32font.c (font_matches_spec): Filter out non-Japanese kana fonts.
147 (add_font_entity_to_list): Filter out non-Japanese Shift-JIS
148 fonts (Bug#6029).
149 (add_font_entity_to_list): Fix logic errors in mixed boolean and
150 bitwise arithmetic preventing use of unicode-sip and non-truetype
151 opentype fonts.
152
a06776b2
EZ
1532011-11-05 Eli Zaretskii <eliz@gnu.org>
154
3ad924ba
EZ
155 * s/ms-w32.h (fstat, stat, utime): Move redirections to
156 "emacs"-only part.
157
a06776b2
EZ
158 * w32fns.c (x_create_tip_frame, Fx_create_frame): Rearrange
159 initialization code to keep similarity to xfns.c after changes
160 from 2011-11-05.
161
c9e7db78
JD
1622011-11-05 Jan Djärv <jan.h.d@swipnet.se>
163
a97f8f3f
JD
164 * nsfns.m: Declare image_cache_refcount if GLYPH_DEBUG.
165 (unwind_create_frame): New function (Bug#9943).
166 (Fx_create_frame): Restructure code to be more similar to the one in
167 xfns.c. Call record_unwind_protect with unwind_create_frame (Bug#9943).
168 Initialize image_cache_refcount if GLYPH_DEBUG (Bug#9943).
169 Move terminal->reference_count++ just before making the frame official
170 (Bug#9943).
171
172 * nsterm.m (x_free_frame_resources): New function.
173 (x_destroy_window): Move code to x_free_frame_resources.
174
c9e7db78
JD
175 * xfns.c (unwind_create_frame): Fix comment.
176 (Fx_create_frame, x_create_tip_frame): Move
177 terminal->reference_count++ just before making the frame
178 official. Move initialization of image_cache_refcount and
179 dpyinfo_refcount before calling init_frame_faces (Bug#9943).
180
a6fc3b5c
EZ
1812011-11-05 Eli Zaretskii <eliz@gnu.org>
182
183 Support MSVC build with newer versions of Visual Studio.
184 * makefile.w32-in (TAGS-gmake): Don't use $(patsubst ...), as
185 Nmake barfs on that. Use $(OBJ*_c) variables instead, defined on
186 nt/gmake.defs.
187
188 * lisp.h (ENUM_BF): New macro, for enumerated types in bitfields,
189 which are not supported by MSVC.
190 (Lisp_Symbol, Lisp_Misc_Any, Lisp_Marker, Lisp_Misc_Overlay)
191 (Lisp_Save_Value, Lisp_Free): Use ENUM_BF for enumerated types in
192 bitfields.
193 (Lisp_Object) [USE_LISP_UNION_TYPE]: Use ENUM_BF for enumerated
194 types in bitfields.
195 (DEFUN) [_MSC_VER]: Define in a different way for MSVC.
196
197 * w32fns.c [_MSC_VER]: DECLARE_HANDLE for any MSVC version.
198
1992011-11-05 Fabrice Popineau <fabrice.popineau@supelec.fr> (tiny change)
200
201 Support MSVC build with newer versions of Visual Studio.
202 * w32.c: Don't include w32api.h for MSVC.
203 (init_environment) [_MSC_VER]: Call sys_access, not _access.
204
205 * s/ms-w32.h <sigset_t, ssize_t> [_MSC_VER]: Typedefs for MSVC.
206 [_MSC_VER]: Include sys/timeb.h, sys/stat.h, and signal.h.
207 (fstat, stat, utime) [_MSC_VER]: Redirect to their sys_* cousins.
208 (malloc, free, realloc, calloc) [_MSC_VER]: Always redirect to the
209 e_* cousins.
210 (alloca) [_MSC_VER]: Define to _alloca.
211
212 * lisp.h (DECL_ALIGN) [_MSC_VER]: Define for MSVC.
213
214 * regex.c <re_char> [_MSC_VER]: A separate definition for MSVC.
215
a58c13ed
EZ
2162011-11-04 Eli Zaretskii <eliz@gnu.org>
217
218 * xdisp.c (note_mouse_highlight): If either of
219 previous/next-single-property-change returns nil, treat that as
220 the beginning or the end of the buffer. (Bug#9955)
221
fe0b6370
JD
2222011-11-04 Jan Djärv <jan.h.d@swipnet.se>
223
a58c13ed 224 * gtkutil.c (xg_make_tool_item): Add callbacks if one of wimage or
fe0b6370
JD
225 label is not null (Bug#9951).
226 (xg_tool_item_stale_p): Handle the fact that wimage and/or wlbl
227 may be NULL.
228
89bd5ee1
EZ
2292011-11-04 Eli Zaretskii <eliz@gnu.org>
230
231 * window.c (Fwindow_body_size): Mention in the doc string that the
232 return value is in frame's canonical units. (Bug#9949)
233
84c3edb9
EZ
2342011-11-03 Eli Zaretskii <eliz@gnu.org>
235
4e2fb5c7
EZ
236 * xdisp.c (note_mouse_highlight): Initialize `area'. (Bug#9947)
237
84c3edb9 238 * w32fns.c (unwind_create_frame): If needed, free the glyph
3ab15fd6 239 matrices of the partially constructed frame. (Bug#9943)
2a58bbc1 240 * xfns.c (unwind_create_frame): Likewise.
84c3edb9 241
bc17a887
EZ
2422011-11-01 Eli Zaretskii <eliz@gnu.org>
243
244 * xdisp.c (mouse_face_from_buffer_pos): Fix a typo in a comment.
245 Don't stop backward scan on the continuation glyph, even though
246 its CHARPOS is positive.
26b46e51
EZ
247 (mouse_face_from_buffer_pos, note_mouse_highlight): Rename
248 cover_string to disp_string.
bc17a887 249
4ee88440
MR
2502011-11-01 Martin Rudalics <rudalics@gmx.at>
251
252 * window.c (temp_output_buffer_show): Don't use
253 Vtemp_buffer_show_specifiers.
254 (Vtemp_buffer_show_specifiers): Remove unused variable.
255
c2ff3c02
EZ
2562011-10-30 Eli Zaretskii <eliz@gnu.org>
257
258 * xdisp.c (try_cursor_movement): Make sure ROW isn't decremented
259 past the beginning of the current glyph matrix.
260
6e56383b
JD
2612011-10-30 Adam Sjøgren <asjo@koldfront.dk> (tiny change)
262
263 * xterm.c: Include X11/Xproto.h if HAVE_GTK3.
264 (x_error_handler): Ignore BadMatch for X_SetInputFocus for
265 HAVE_GTK3 (Bug#9869).
b77a6a7f 266
3b574623
JD
267 * gtkutil.c (xg_win_to_widget, xg_event_is_for_menubar): Initialize
268 type to GDK_NOTHING so valgrind does not complain (Bug#9901).
269
b77a6a7f
JD
270 * xterm.h (x_display_info): Add Xatom_net_wm_state_hidden (Bug#9893).
271
272 * xterm.c: Declare x_handle_net_wm_state to return int.
273 (handle_one_xevent): Check if we are iconified but don't have
274 _NET_WM_STATE_HIDDEN. If do, treat as deiconify (Bug#9893).
275 (get_current_wm_state): Return non-zero if not hidden,
276 check for _NET_WM_STATE_HIDDEN (Bug#9893).
277 (do_ewmh_fullscreen): Ignore return value from get_current_wm_state.
278 (x_handle_net_wm_state): Return what get_current_wm_state returns.
279 (x_term_init): Initialize dpyinfo->Xatom_net_wm_state_hidden.
280
196e41e4
PE
2812011-10-29 Paul Eggert <eggert@cs.ucla.edu>
282
283 * alloc.c (which_symbols): Declare EXTERNALLY_VISIBLE,
284 so that this new function doesn't get optimized away by a
285 whole-program optimizer. Make the 2nd arg EMACS_INT, not int.
286
021f2e1a
AS
2872011-10-29 Andreas Schwab <schwab@linux-m68k.org>
288
289 * frame.h (MOUSE_HL_INFO): Remove excess parens.
290
8b058d44
EZ
2912011-10-29 Eli Zaretskii <eliz@gnu.org>
292
293 Fix the `xbytecode' command.
294 * .gdbinit (xprintbytestr): New command.
295 (xwhichsymbols): Renamed from `which'; all callers changed.
296 (xbytecode): Print the byte-code string as well.
297
4452fb80
EZ
2982011-10-29 Kim Storm <storm@cua.dk>
299
8b058d44
EZ
300 * alloc.c (which_symbols): New function.
301
21b72067
AS
3022011-10-29 Andreas Schwab <schwab@linux-m68k.org>
303
304 * minibuf.c (read_minibuf_noninteractive): Allow reading empty
305 line. (Bug#9903)
306
83ed7b5c
GM
3072011-10-29 Glenn Morris <rgm@gnu.org>
308
309 * process.c (wait_reading_process_output): Revert 2009-08-30 change.
310 Not clear what it was for, and it causes various bugs. (Bug#9839)
311
5a7a728b
EZ
3122011-10-28 Eli Zaretskii <eliz@gnu.org>
313
314 * xdisp.c (note_mouse_highlight): Initialize `part', to avoid a
315 possible random value that matches one of those tested as
316 condition to clear the mouse face.
317
d3d0842f
CY
3182011-10-28 Chong Yidong <cyd@gnu.org>
319
320 * xdisp.c (note_mouse_highlight): Fix use of uninitialized var.
321
31b39d13
DN
3222011-10-28 Dan Nicolaescu <dann@ics.uci.edu>
323
324 * window.c (make_window): Initialize phys_cursor_on_p.
325
9aba6043
SM
3262011-10-28 Stefan Monnier <monnier@iro.umontreal.ca>
327
328 * lisp.h (struct Lisp_Symbol): Update comments.
329
c20992f4
JB
3302011-10-28 Juanma Barranquero <lekktu@gmail.com>
331
332 * w32font.c (w32_load_unicows_or_gdi32): Add missing return.
333
db4f02f2
EZ
3342011-10-28 Eli Zaretskii <eliz@gnu.org>
335
336 Fix Emacs on Windows 9X (bug#8562). Thanks to oslsachem
337 <oslsachem@gmail.com> for helping to debug this.
338
339 * w32font.c (g_b_init_is_w9x, g_b_init_get_outline_metrics_w)
340 (g_b_init_get_text_metrics_w, g_b_init_get_glyph_outline_w)
341 (g_b_init_get_glyph_outline_w): New static variables.
342 (GetOutlineTextMetricsW_Proc, GetTextMetricsW_Proc)
343 (GetGlyphOutlineW_Proc): New typedefs.
344 (w32_load_unicows_or_gdi32, get_outline_metrics_w)
9aba6043
SM
345 (get_text_metrics_w, get_glyph_outline_w, globals_of_w32font):
346 New functions.
347 (w32font_open_internal, compute_metrics):
348 Call get_outline_metrics_w, get_text_metrics_w, and get_glyph_outline_w
db4f02f2
EZ
349 instead of calling the "wide" APIs directly.
350
351 * emacs.c (main) [HAVE_NTGUI]: Call globals_of_w32font.
352
353 * w32.h (syms_of_w32font): Add prototype.
354
87e68db4
JB
3552011-10-27 Juanma Barranquero <lekktu@gmail.com>
356
357 * window.c (Fframe_root_window, Fframe_first_window, Fwindow_end)
358 (Fframe_selected_window, Ftemp_output_buffer_show, Fnext_window)
359 (Fdelete_window_internal, Fwindow_parameters): Fix typos in docstrings.
360 (Fmove_to_window_line): Doc fix.
361
435c1d67
CY
3622011-10-27 Chong Yidong <cyd@gnu.org>
363
364 * process.c (make_process): Set gnutls_state to NULL.
365
366 * gnutls.c (emacs_gnutls_deinit): Deinit the gnutls_state if it is
367 non-NULL, regardless of GNUTLS_INITSTAGE.
368 (Fgnutls_boot): Cleanups. Call emacs_gnutls_deinit if we signal
369 an error. Set process slots as soon as we allocate them.
370
371 * gnutls.h (GNUTLS_LOG, GNUTLS_LOG2): Fix macros.
372
9c6c6f49
CY
3732011-10-27 Chong Yidong <cyd@gnu.org>
374
9aba6043
SM
375 * gnutls.c (emacs_gnutls_deinit): New function.
376 Deallocate credentials structures as well as calling gnutls_deinit.
9c6c6f49
CY
377 (Fgnutls_deinit, Fgnutls_boot): Use it.
378
379 * process.c (make_process): Initialize GnuTLS credentials to NULL.
380 (deactivate_process): Call emacs_gnutls_deinit.
381
657d08d3
JB
3822011-10-27 Juanma Barranquero <lekktu@gmail.com>
383
384 * image.c (x_create_x_image_and_pixmap):
385 * w32.c (sys_rename, w32_delayed_load):
386 * w32font.c (fill_in_logfont):
387 * w32reg.c (x_get_string_resource): Silence compiler warnings.
388
5430d399
JB
3892011-10-26 Juanma Barranquero <lekktu@gmail.com>
390
391 * w32fns.c (w32_default_color_map): New function,
392 extracted from Fw32_default_color_map.
a7ef684b 393 (Fw32_default_color_map, Fx_open_connection): Use it. (Bug#9785)
5430d399 394
fe0055fa
PE
3952011-10-25 Paul Eggert <eggert@cs.ucla.edu>
396
397 * dispextern.h (Fcontrolling_tty_p): New decl (Bug#6649 part 2).
398
e6346438
SM
3992011-10-25 Stefan Monnier <monnier@iro.umontreal.ca>
400
401 * keyboard.c (test_undefined): New function (bug#9751).
402 (read_key_sequence): Use it to detect when a key is bound to `undefined'.
403
e112cc37
ET
4042011-10-25 Enami Tsugutomo <tsugutomo.enami@jp.sony.com>
405
406 * sysdep.c (init_sys_modes): Fix the check for the controlling
407 terminal (Bug#6649).
408
7b5d6677
EZ
4092011-10-20 Eli Zaretskii <eliz@gnu.org>
410
411 * dispextern.h (struct bidi_it): New member next_en_type.
412
413 * bidi.c (bidi_line_init): Initialize the next_en_type member.
414 (bidi_resolve_explicit_1): When next_en_pos is valid for the
415 current character, check also for next_en_type being WEAK_EN.
416 (bidi_resolve_weak): Don't enter the expensive loop if the current
417 position is before next_en_pos. Record the bidi type of the first
418 non-ET, non-BN character we find, in addition to its position.
419 (bidi_level_of_next_char): Invalidate next_en_type when
420 next_en_pos is over-stepped.
421
7da0b018
PE
4222011-10-20 Paul Eggert <eggert@cs.ucla.edu>
423
424 Time zone name fixes for non-ASCII locales (Bug#641, Bug#9794)
425 * editfns.c: Rewrite current-time-zone so that it invokes
426 the equivalent of (format-time-string "%Z") to get the time zone name.
427 This fixes a bug when the time zone name contains characters that
428 need converting from the system time locale to Emacs internal format.
429 This fixes a shortcoming that I introduced in my 1999-10-19 patch:
430 that patch fixed format-time-string to do the conversion, but
431 I forgot to fix current-time-zone.
432 (format_time_string): New function, containing most of
433 what Fformat_time_string used to contain.
434 (Fformat_time_string): Rewrite in terms of format_time_string.
435 This doesn't change this function's behavior.
436 (current-time-zone): Rewrite to use format_time_string.
437 This fixes the bug reported by Michael Schierl in
438 <http://lists.gnu.org/archive/html/emacs-devel/2007-06/msg00334.html>.
439 Jason Rumney's 2007-06-07 change worked around this bug, but
440 didn't fix it.
441 * systime.h (tzname, timezone): Remove no-longer-used declarations.
442
8547b010
EZ
4432011-10-19 Eli Zaretskii <eliz@gnu.org>
444
445 * xdisp.c (start_display): If the character at POS is displayed
446 via a display vector, reset IT->current.dpvec_index to zero.
12b32963
EZ
447 (try_window_reusing_current_matrix): If a line ends in a display
448 vector or the next line starts in a display vector, continue
449 redrawing the window even though the character position of
450 start_row was reached.
8547b010
EZ
451 (Bug#9771, part 2)
452
4e948d15
CY
4532011-10-18 Chong Yidong <cyd@gnu.org>
454
455 * xdisp.c (get_next_display_element): Handle U+2010 and U+2011
456 with nobreak-char-display too.
457
4787455f
EZ
4582011-10-18 Eli Zaretskii <eliz@gnu.org>
459
460 Fix part 3 of bug#9771.
461 * bidi.c (bidi_line_init): Initialize next_en_pos to zero, not -1.
462 (bidi_resolve_neutral): Don't enter the expensive loop looking for
463 non-neutral characters if the current character is a paragraph
464 separator (a.k.a. Newline). This avoids running the same
465 expensive loop twice, once when we consume the preceding newline
466 and the other time when the line actually needs to be displayed.
467 Avoid the loop when we see neutrals on the base embedding level
468 following a character whose directionality is the same as the
469 paragraph's. This avoids running the expensive loop when a line
470 ends in a long sequence of neutrals, like control characters.
471 Add assertion against STRONG_AL type. Slightly rearrange code
472 that determines the type of a neutral given the first non-neutral
473 that follows it.
474 (bidi_level_of_next_char): Set next_en_pos to zero when
475 invalidating its info.
476
2c91f553
EZ
4772011-10-17 Eli Zaretskii <eliz@gnu.org>
478
479 * xdisp.c (push_display_prop): Determine whether to record string
480 or buffer position by IT->string, not by IT->method. Allow
481 GET_FROM_DISPLAY_VECTOR as IT->method on entry. (Bug#9771, part 4)
f2ff9e88
EZ
482 (move_it_vertically_backward): Don't look for character position
483 immediately after the newline when in a continuation line.
484 (Bug#9771, part 1)
2c91f553 485
c7b08b0d
MR
4862011-10-15 Martin Rudalics <rudalics@gmx.at>
487
488 * window.c (coordinates_in_window): Rewrite and delabelize
489 vertical border check. (Bug#5357) (Bug#9618)
490
6b02f655
SM
4912011-10-14 Stefan Monnier <monnier@iro.umontreal.ca>
492
493 * xterm.c (frame_highlight, frame_unhighlight): Ignore unexplained
494 errors in XSetWindowBorder (bug#9310).
495
81d40c92
DA
4962011-10-13 Dmitry Antipov <dmantipov@yandex.ru>
497
498 * editfns.c (Fset_time_zone_rule): Replace free with xfree to
499 avoid crash when xmalloc overrun checking is enabled.
500
d4172c3b
EZ
5012011-10-13 Eli Zaretskii <eliz@gnu.org>
502
503 * xdisp.c (Fcurrent_bidi_paragraph_direction): Initialize
504 itb.paragraph_dir to NEUTRAL_DIR. Fixes an occasional incorrect
505 cursor motion with <left> and <right> arrow keys.
506
507 * bidi.c (bidi_init_it): Don't initialize paragraph_dir here, as
508 some callers set that themselves.
509
b00eea75
EZ
5102011-10-12 Eli Zaretskii <eliz@gnu.org>
511
512 * xdisp.c (find_row_edges): Handle the case where ROW comes from a
513 display string and the previous row comes from the same string and
514 is empty. (Bug#9739) (Bug#9738)
515
8fe012c4
SM
5162011-10-12 Stefan Monnier <monnier@iro.umontreal.ca>
517
518 * doc.c (get_doc_string): Encode file name (bug#9735).
519
0074aef2
EZ
5202011-10-12 Eli Zaretskii <eliz@gnu.org>
521
79beb178
EZ
522 * bidi.c (bidi_level_of_next_char):
523 * xdisp.c (get_visually_first_element): Remove old incorrect
524 comments regarding the Unicode Line Separator character.
525
0074aef2
EZ
526 * bidi.c (bidi_init_it): Initialize paragraph_dir to NEUTRAL_DIR.
527
6e4b3fbe
DA
5282011-10-12 Dmitry Antipov <dmantipov@yandex.ru>
529
530 * alloc.c (Fgc_status): Do not access beyond zombies array
531 boundary if nzombies > MAX_ZOMBIES.
532 * alloc.c (dump_zombies): Add missing format specifier.
533
0324f3af
PE
5342011-10-12 Paul Eggert <eggert@cs.ucla.edu>
535
b5525cac
PE
536 * xdisp.c (set_cursor_from_row): Simplify conditionals,
537 to pacify GCC 4.6.1 x86-64 with -O2 -Wstrict-overflow.
538
0324f3af
PE
539 * lread.c (read_escape): Allow hex escapes as large as ?\xfffffff.
540 Some packages use them to denote characters with modifiers.
541
e9b5f888
AS
5422011-10-11 Andreas Schwab <schwab@linux-m68k.org>
543
544 * lisp.h (GCPRO1_VAR, GCPRO2_VAR, GCPRO3_VAR, GCPRO4_VAR)
545 (GCPRO5_VAR, GCPRO6_VAR, UNGCPRO_VAR): Add whitespace to avoid
546 matching a pp-number. Rename parameter var to var1.
547
127827c0
SM
5482011-10-11 Stefan Monnier <monnier@iro.umontreal.ca>
549
550 * minibuf.c (Finternal_complete_buffer): Fix last change (bug#9709).
551
c8fd3bd0
GM
5522011-10-08 Glenn Morris <rgm@gnu.org>
553
554 * callint.c (Fcall_interactively): Give a more explicit error for the
555 'c' case with a non-character input. (Bug#8479)
556
352ec8ff
EZ
5572011-10-08 Eli Zaretskii <eliz@gnu.org>
558
03669ccb
EZ
559 * xdisp.c (hscroll_window_tree): Support hscroll in right-to-left
560 lines.
7061c986
EZ
561 (set_cursor_from_row): Fix cursor positioning in mixed L2R+R2L
562 lines that are hscrolled on the left.
03669ccb 563
352ec8ff
EZ
564 * dispnew.c (buffer_posn_from_coords): Account for a possible
565 presence of header-line. (Bug#4426)
566
a66cfb1c
SM
5672011-10-07 Stefan Monnier <monnier@iro.umontreal.ca>
568
6b02f655
SM
569 * buffer.c (syms_of_buffer) <enable-multibyte-characters>:
570 Don't advertise functionality which we discourage or doesn't work.
a66cfb1c 571
7c5ee88e
PE
5722011-10-07 Paul Eggert <eggert@cs.ucla.edu>
573
574 * alloc.c (GC_LISP_OBJECT_ALIGNMENT): Use offsetof, not __alignof__
575 or sizeof. __alignof__ gives the wrong answer on Fedora x86-64
576 with GCC 4.6.1 when configured with CC='gcc -m32' --with-wide-int;
577 this makes Emacs dump core during garbage collection on rare
578 occasions. sizeof is obviously inferior to offsetof here, so
579 stick with offsetof.
580 (GC_POINTER_ALIGNMENT): New macro.
581 (mark_memory): Omit 3rd (offset) arg; caller changed.
582 Don't assume EMACS_INT alignment is the same as pointer alignment.
583
df1bbe5b
SM
5842011-10-03 Stefan Monnier <monnier@iro.umontreal.ca>
585
586 * keyboard.c (read_key_sequence_remapped): New var.
587 (read_key_sequence): Compute remapping in the right buffer.
588 (command_loop_1): Use read_key_sequence's remapping directly.
589
51553db6
SM
5902011-10-02 Stefan Monnier <monnier@iro.umontreal.ca>
591
32c1fffd
SM
592 * dired.c (file_name_completion): Don't expand file name.
593 (Ffile_name_completion, Ffile_name_all_completions): Expand file name
594 before checking file name handler.
595
51553db6
SM
596 * minibuf.c (Finternal_complete_buffer): Only show internal buffers if
597 they've been requested explicitly (bug#9591).
598
b6bd1599 5992011-10-01 Andreas Schwab <schwab@linux-m68k.org>
fa2ec41f
AS
600
601 * keymap.c (Fsingle_key_description): Use make_specified_string
602 instead of build_string to build string from push_key_description.
603 (Bug#5193)
604
f701dc2a
PE
6052011-09-30 Paul Eggert <eggert@cs.ucla.edu>
606
4222c55d
PE
607 * buffer.h (struct buffer): Use time_t, not int, for a time stamp.
608 This fixes a Y2038 bug on 64-bit hosts.
609 * buffer.c (reset_buffer):
610 * fileio.c (Fdo_auto_save, Fset_buffer_auto_saved)
611 (Fclear_buffer_auto_save_failure):
612 Use 0, not -1, to represent an unset failure time, since time_t
613 might not be signed.
614
f701dc2a
PE
615 Remove dependency on glibc malloc internals.
616 * alloc.c (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
617 Move back here from lisp.h, but with their new implementations.
618 (XMALLOC_BASE_ALIGNMENT, COMMON_MULTIPLE, XMALLOC_HEADER_ALIGNMENT)
619 (XMALLOC_OVERRUN_SIZE_SIZE): Move these new lisp.h macros here.
620 * charset.c (charset_table_init): New static var.
621 (syms_of_charset): Use it instead of xmalloc. This removes a
622 dependency on glibc malloc internals. See Eli Zaretskii's comment in
623 <http://lists.gnu.org/archive/html/emacs-devel/2011-09/msg00815.html>.
624 * lisp.h (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
625 Move back to alloc.c.
626 (XMALLOC_BASE_ALIGNMENT, COMMON_MULTIPLE, XMALLOC_HEADER_ALIGNMENT)
627 (XMALLOC_OVERRUN_SIZE_SIZE): Move to alloc.c.
628
9ceebf39
JD
6292011-09-30 Jan Djärv <jan.h.d@swipnet.se>
630
631 * nsterm.m (windowDidResize): Call x_set_window_size only when
632 ns_in_resize is true. Otherwise set pixelwidth/height and
633 call change_frame_size (Bug#9628).
634
cb993c58
PE
6352011-09-30 Paul Eggert <eggert@cs.ucla.edu>
636
3930c88b
PE
637 Port --enable-checking=all to Fedora 14 x86-64.
638 * charset.c (syms_of_charset): Also account for glibc malloc's
639 internal overhead when calculating the initial malloc maximum.
640
cb993c58
PE
641 Port --enable-checking=all to Fedora 14 x86.
642 * alloc.c (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
643 Move to lisp.h.
644 (xmalloc_put_size, xmalloc_get_size, overrun_check_malloc)
645 (overrun_check_realloc, overrun_check_free):
646 Use XMALLOC_OVERRUN_SIZE_SIZE, not sizeof (size_t).
647 That way, xmalloc returns a properly-aligned pointer even if
648 XMALLOC_OVERRUN_CHECK is defined. The old debugging code happened
649 to align OK on typical 64-bit hosts, but not on Fedora 14 x86.
650 * charset.c (syms_of_charset): Take XMALLOC_OVERRUN_CHECK_OVERHEAD
651 into account when calculating the initial malloc maximum.
652 * lisp.h (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
653 Move here from alloc.c, so that charset.c can use it too.
654 Properly align; the old code wasn't right for common 32-bit hosts
655 when configured with --enable-checking=all.
656 (XMALLOC_BASE_ALIGNMENT, COMMON_MULTIPLE, XMALLOC_HEADER_ALIGNMENT)
657 (XMALLOC_OVERRUN_SIZE_SIZE): New macros.
658
31bed486
EZ
6592011-09-29 Eli Zaretskii <eliz@gnu.org>
660
04c70788 661 * sysdep.c (snprintf) [!EOVERFLOW]: If EOVERFLOW is not defined,
31bed486
EZ
662 use EDOM.
663
fbcaa2f3
EZ
6642011-09-28 Eli Zaretskii <eliz@gnu.org>
665
666 * xdisp.c (compute_display_string_end): If there's no display
667 string at CHARPOS, return -1.
668
669 * bidi.c (bidi_fetch_char): When compute_display_string_end
670 returns a negative value, treat the character as a normal
671 character not covered by a display string. (Bug#9624)
672
a239d4e9
JB
6732011-09-28 Juanma Barranquero <lekktu@gmail.com>
674
675 * lread.c (Fread_from_string): Fix typo in docstring.
676
88652fd5
EZ
6772011-09-27 Eli Zaretskii <eliz@gnu.org>
678
679 * xdisp.c (handle_invisible_prop): If invisible text ends on a
680 newline, reseat the iterator instead of bidi-iterating there one
681 character at a time. (Bug#9610)
32c1fffd
SM
682 (BUFFER_POS_REACHED_P, move_it_in_display_line_to): Bail when past
683 TO_CHARPOS if the bidi iterator is at base embedding level.
88652fd5 684
ed497dd4
AS
6852011-09-27 Andreas Schwab <schwab@linux-m68k.org>
686
687 * lread.c (readevalloop): Use correct code for NBSP.
688 (read1): Likewise. (Bug#9608)
689
b2bf61aa
MA
6902011-09-25 Michael Albinus <michael.albinus@gmx.de>
691
692 * dbusbind.c (Fdbus_register_signal): When service is not
693 registered, use nil in Vdbus_registered_objects_table. (Bug#9581)
694
32bbb17c
GM
6952011-09-25 Glenn Morris <rgm@gnu.org>
696
697 * buffer.c (truncate-lines): Doc fix.
698
94e0933e
CY
6992011-09-24 Chong Yidong <cyd@stupidchicken.com>
700
701 * window.c (Fwindow_prev_buffers, Fset_window_prev_buffers)
702 (Fset_window_next_buffers): Doc fix.
703
cddde921
GM
7042011-09-24 Glenn Morris <rgm@gnu.org>
705
706 * minibuf.c (read_minibuf): Disable line truncation. (Bug#5715)
707
1260aef1
PE
7082011-09-24 Paul Eggert <eggert@cs.ucla.edu>
709
25b4bfa0
PE
710 Fix minor problems found by static checking.
711 * xdisp.c (string_from_display_spec): Don't assume vecsize fits in int.
1260aef1
PE
712 * indent.c (Fvertical_motion): Fix == vs = typo.
713
e3cbd34b
EZ
7142011-09-24 Eli Zaretskii <eliz@gnu.org>
715
a66cfb1c
SM
716 * dispnew.c (syms_of_display) <redisplay-dont-pause>:
717 Default value is now t. Doc fix.
6bf7006f 718
e3cbd34b 719 * indent.c (Fvertical_motion): Compute and apply the overshoot
32c1fffd 720 logic when moving up, not only when moving down. Fix the
e3cbd34b 721 confusing name and values of the it_overshoot_expected variable;
32c1fffd 722 logic changes accordingly. (Bug#9254) (Bug#9549)
e3cbd34b
EZ
723
724 * xdisp.c (pos_visible_p): Produce correct pixel coordinates when
725 CHARPOS is covered by a display string which includes newlines.
726 (move_it_vertically_backward): Avoid inflooping when START_CHARPOS
727 is covered by a display string with embedded newlines.
728
a3de0cbd
MA
7292011-09-24 Michael Albinus <michael.albinus@gmx.de>
730
731 * dbusbind.c (Fdbus_register_signal): Add match rule to
732 Vdbus_registered_objects_table. (Bug#9581)
a66cfb1c
SM
733 (Fdbus_register_method, Vdbus_registered_objects_table):
734 Fix docstring.
a3de0cbd 735
b260039d
JM
7362011-09-24 Jim Meyering <meyering@redhat.com>
737
32c1fffd 738 do not ignore write error for any output size
b260039d
JM
739 The previous change was incomplete.
740 While it makes emacs --batch detect the vast majority of stdout
741 write failures, errors were still ignored whenever the output size is
742 k * (BUFSIZ+1) - 4. E.g., on a system with BUFSIZ of 4096,
743 $ emacs --batch --eval '(print (format "%4093d" 0))' > /dev/full \
744 && echo FAIL: ignored write error
745 FAIL: ignored write error
746 $ emacs --batch --eval '(print (format "%20481d" 0))' > /dev/full \
747 && echo FAIL: ignored write error
748 FAIL: ignored write error
749 * emacs.c (Fkill_emacs): Also test ferror. (Bug#9574)
750
8eca8a7c
AS
7512011-09-23 Andreas Schwab <schwab@linux-m68k.org>
752
753 * emacs.c (Fkill_emacs): In noninteractive mode exit
754 non-successfully if a write error occurred on stdout. (Bug#9574)
755
3341db62
EZ
7562011-09-21 Eli Zaretskii <eliz@gnu.org>
757
758 * xdisp.c (pop_it): Allow it->object that is a cons cell to pass
759 the xassert test.
760
761 * dispextern.h (struct it): Update the comment documenting what
762 can it->OBJECT be.
763
8c203dbf
EZ
7642011-09-20 Eli Zaretskii <eliz@gnu.org>
765
766 * xdisp.c (set_cursor_from_row): If the row ends in a newline from
767 a display string, extend search for cursor position to end of row.
768 (find_row_edges): If the row ends in a newline from a display
769 string, increment its MATRIX_ROW_END_CHARPOS by one. (Bug#9549)
770 Handle the case of a display string with multiple newlines.
fd317ddf
EZ
771 (Fcurrent_bidi_paragraph_direction): Fix search for previous
772 non-empty line. Fixes confusing cursor motion with arrow keys at
773 the beginning of a line that starts with whitespace.
8c203dbf 774
a4824228
LMI
7752011-09-19 Lars Magne Ingebrigtsen <larsi@gnus.org>
776
777 * lread.c (Fread_from_string): Document what FINAL-STRING-INDEX is
778 (bug#9493).
779
33ed493b
CY
7802011-09-18 Chong Yidong <cyd@stupidchicken.com>
781
782 * xfns.c (Fx_create_frame): Handle the bitmapIcon resource as
783 boolean (Bug#9154).
784
56cd55c8
EZ
7852011-09-18 Eli Zaretskii <eliz@gnu.org>
786
787 * xdisp.c (display_line): Record maximum and minimum buffer
788 positions even if no glyphs were produced (e.g., by a zero-width
789 stretch). Fixes bug#9530 on a TTY. Under word-wrap, don't record
790 buffer positions that will be removed from the glyph row because
791 they don't fit.
c02dcedf
EZ
792 (produce_stretch_glyph): Fix a bug in :align-to on a TTY when the
793 column is beyond frame width: don't subtract 1 "pixel" when
794 computing width of the stretch.
3e62b7e0
EZ
795 (reseat_at_next_visible_line_start): Undo the change made on
796 2011-09-17 that saved paragraph information and restored it after
797 the call to `reseat'. (Bug#9545)
56cd55c8 798
5ed99d36 7992011-09-18 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
3390454c
YM
800
801 * xdisp.c (expose_window): Save original value of phys_cursor_on_p
802 and turn window cursor on if cleared (Bug#9415).
803
5ed99d36 8042011-09-18 Andreas Schwab <schwab@linux-m68k.org>
edb7b4dc
AS
805
806 * search.c (boyer_moore): Take unibyte characters from pattern
807 literally. (Bug#9458)
808
9bade7b2
EZ
8092011-09-18 Eli Zaretskii <eliz@gnu.org>
810
811 * xdisp.c (reseat_at_next_visible_line_start): Fix last change.
812
e5e9d610
PE
8132011-09-18 Paul Eggert <eggert@cs.ucla.edu>
814
87e4427a
PE
815 Fix minor problem found by static checking.
816 * xdisp.c (reseat_at_next_visible_line_start): Mark locals as
817 initialized, to pacify gcc -Wuninitialized.
818
e5e9d610
PE
819 * fileio.c: Report proper errno when syscall falls.
820 (Finsert_file_contents): Save and restore errno,
821 so that report_file_error outputs the correct diagnostic.
822 (Fwrite_region) [CLASH_DETECTION]: Likewise.
823
a1674f0b
EZ
8242011-09-18 Eli Zaretskii <eliz@gnu.org>
825
826 * .gdbinit (pgx): Fix references to fields of `struct glyph'.
827
fbfb6dd4
EZ
8282011-09-17 Eli Zaretskii <eliz@gnu.org>
829
830 * xdisp.c (produce_stretch_glyph): Another fix for changes made on
831 2011-08-30T17:32:44Z!eliz@gnu.org. (Bug#9530)
832
bb187662
EZ
8332011-09-17 Eli Zaretskii <eliz@gnu.org>
834
1137e8b8 835 * xdisp.c (reseat_at_next_visible_line_start): Keep information
6b02f655 836 about the current paragraph and restore it after the call to reseat.
1137e8b8
EZ
837
838 * bidi.c (MAX_PARAGRAPH_SEARCH): New macro.
839 (bidi_find_paragraph_start): Search back for paragraph beginning
840 at most MAX_PARAGRAPH_SEARCH lines; if not found, return BEGV_BYTE.
841 (bidi_move_to_visually_next): Only trigger paragraph-related
842 computations when the last character is a newline or at EOB, not
843 just any NEUTRAL_B. (Bug#9470)
844
bb187662
EZ
845 * xdisp.c (set_cursor_from_row): Don't invoke special treatment of
846 truncated lines if point is covered by a display string. (Bug#9524)
847
2e621251
PE
8482011-09-16 Paul Eggert <eggert@cs.ucla.edu>
849
850 * xselect.c: Relax test for outgoing X longs (Bug#9498).
851 (cons_to_x_long): New function.
852 (lisp_data_to_selection_data): Use it. Correct the test for
853 short-versus-long data; it was negated. Break out of vector
854 loop, for efficiency, when a long datum is discovered.
855
91a15bc6
SM
8562011-09-16 Stefan Monnier <monnier@iro.umontreal.ca>
857
858 * eval.c (Fquote): Document its non-consing behavior (bug#9482).
859
b41c3a35
EZ
8602011-09-16 Eli Zaretskii <eliz@gnu.org>
861
862 * image.c (tiff_handler): Work around a bug in MinGW GCC 3.x (see
863 GCC PR/17406) by declaring this function with external scope.
864
7812ba2d
PE
8652011-09-15 Paul Eggert <eggert@cs.ucla.edu>
866
867 * editfns.c (Fformat): Fix bug in text-property fix (Bug#9514).
868 Don't mishandle (length (format "%%")) and (format "%4000s%%" "").
869
cf7edc2a
AS
8702011-09-15 Andreas Schwab <schwab@linux-m68k.org>
871
872 * editfns.c (Fformat): Correctly handle text properties on "%%".
873
bd01620e
EZ
8742011-09-15 Eli Zaretskii <eliz@gnu.org>
875
876 * xterm.c (x_draw_composite_glyph_string_foreground):
877 * w32term.c (x_draw_composite_glyph_string_foreground):
878 * term.c (encode_terminal_code):
879 * composite.c (composition_update_it, get_composition_id):
880 * xdisp.c (get_next_display_element)
881 (fill_composite_glyph_string): Add comments about special meaning
882 of TAB characters in a composition.
883
a02719a3
PE
8842011-09-15 Paul Eggert <eggert@cs.ucla.edu>
885
886 * editfns.c (Fformat): Fix off-by-1 bug for "%%b" (Bug#9514).
4c122725
PE
887 This occurs when processing a multibyte format.
888 Problem reported by Wolfgang Jenker.
a02719a3 889
72589a3c
JB
8902011-09-15 Johan Bockgård <bojohan@gnu.org>
891
892 * xdisp.c (try_cursor_movement): Only check for exact match if
893 cursor hpos found by set_cursor_from_row is valid. (Bug#9495)
894
1c14176c
PE
8952011-09-14 Paul Eggert <eggert@cs.ucla.edu>
896
897 Remove unused external symbols.
898 * dispextern.h (calc_pixel_width_or_height): Remove decl.
899 * xdisp.c (calc_pixel_width_or_height): Now static.
900 * doprnt.c (exprintf) [! (HAVE_X_WINDOWS && USE_X_TOOLKIT)]: Remove.
901 * indent.c (check_display_width):
902 * w32term.c: Fix comment to match code.
903 * xterm.c, xterm.h (x_catching_errors): Remove.
904
d2eea5b5
PE
9052011-09-14 Paul Eggert <eggert@cs.ucla.edu>
906
907 * xselect.c: Use signed conversions more consistently (Bug#9498).
908 (selection_data_to_lisp_data): Assume incoming selection data are
909 signed integers, not unsigned. This is to be consistent with
910 outgoing selection data, which was modified to use signed integers
911 in as part of the fix to Bug#9196 in response to Jan D.'s comment
912 in <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=9196#32> that X11
913 expects long, not unsigned long.
914
46888499
EZ
9152011-09-14 Eli Zaretskii <eliz@gnu.org>
916
917 * xdisp.c (try_window_reusing_current_matrix): Fix incorrect
918 computation of loop end. Reported by Johan Bockgård
919 <bojohan@gnu.org>.
920
ef8ef9fb
CY
9212011-09-13 Chong Yidong <cyd@stupidchicken.com>
922
923 * frame.c (Fother_visible_frames_p): Function deleted.
924
fa819fed
EZ
9252011-09-12 Eli Zaretskii <eliz@gnu.org>
926
927 * indent.c (compute_motion): Process display vector front to back
928 rather than the other way around. (Bug#2496)
929
2ba8e008
SM
9302011-09-12 Stefan Monnier <monnier@iro.umontreal.ca>
931
932 * fileio.c (Finsert_file_contents): Don't assume beg_offset is 0.
933
20f53c69
CY
9342011-09-11 Chong Yidong <cyd@stupidchicken.com>
935
936 * minibuf.c (Fread_from_minibuffer): Doc fix.
937
d562d7a4
EZ
9382011-09-11 Eli Zaretskii <eliz@gnu.org>
939
940 * xdisp.c (produce_stretch_glyph): Fix a typo made in changes from
941 2011-08-30T17:32:44Z!eliz@gnu.org. (Bug#9475)
942
1c4d7f3d
LMI
9432011-09-11 Lars Magne Ingebrigtsen <larsi@gnus.org>
944
945 * fileio.c (Fvisited_file_modtime): Document `(-1 65535)' as a
946 value for non-existent files.
947
b885bf36
EZ
9482011-09-11 Eli Zaretskii <eliz@gnu.org>
949
950 * fileio.c (Finsert_file_contents): If the file cannot be opened,
951 set its "size" to -1. This will set the modtime_size field of
952 the corresponding buffer to -1, which is what
953 verify-visited-file-modtime expects for files that do not exist.
954 (Bug#9139)
955
6612f0bf
PE
9562011-09-11 Paul Eggert <eggert@cs.ucla.edu>
957
958 * keymap.h (KEY_DESCRIPTION_SIZE, push_key_description): Move decls
959 here ...
960 * lisp.h: ... from here. push_key_description is no longer
961 defined in keyboard.c, so its declaration should not be in
962 lisp.h's "Defined in keyboard.c" section, and KEY_DESCRIPTION_SIZE
963 logically belongs with push_key_description.
964
dfb3f755
PE
9652011-09-10 Paul Eggert <eggert@cs.ucla.edu>
966
967 * buffer.h: Include <sys/types.h> instead of <time.h>.
968 Otherwise, off_t wasn't defined on FreeBSD 9.0-BETA2 i386.
969 Problem reported by Herbert J. Skuhra.
970
3134906c
LMI
9712011-09-10 Lars Magne Ingebrigtsen <larsi@gnus.org>
972
973 * xml.c (parse_region): Make the parsing work for
974 non-comment-starting XML files again (bug#9144).
975
8d903f4e
AS
9762011-09-10 Andreas Schwab <schwab@linux-m68k.org>
977
978 * image.c (gif_load): Fix calculation of bottom and right corner.
979 (Bug#9468)
980
80ad64f4
EZ
9812011-09-10 Eli Zaretskii <eliz@gnu.org>
982
983 * xdisp.c (MAX_DISP_SCAN): Decrease to 250. Prevents sluggish
984 redisplay in small windows.
985
208a048d
EZ
9862011-09-09 Eli Zaretskii <eliz@gnu.org>
987
988 * frame.c (x_report_frame_params): Cast to avoid compiler warnings.
989
9b1c252e
MR
9902011-09-08 Martin Rudalics <rudalics@gmx.at>
991
992 * window.c (Fset_window_prev_buffers, Fset_window_next_buffers):
993 Operate on live windows only.
994
2949f33b
JB
9952011-09-08 Juanma Barranquero <lekktu@gmail.com>
996
997 * emacs.c (my_heap_start): #ifdef to avoid warnings when unused.
998
e08dcafd
EZ
9992011-09-07 Eli Zaretskii <eliz@gnu.org>
1000
1001 * xdisp.c (move_it_in_display_line_to): Call RESTORE_IT on ppos_it
1002 only under bidi iteration.
1003
115b96bd
JD
10042011-09-07 Jan Djärv <jan.h.d@swipnet.se>
1005
1006 * gtkutil.c (xg_make_tool_item): Insert comment about eventbox.
1007
c8199d0f
PE
10082011-09-06 Paul Eggert <eggert@cs.ucla.edu>
1009
1010 isnan: Fix porting problem to Solaris 10 with bundled gcc.
1011 Without this fix, the command to link temacs failed due to an
1012 undefined symbol __builtin_isnan. This is because
1013 /usr/include/iso/math_c99.h #defines isnan(x) to
1014 __builtin_isnan(x), but the bundled gcc, which identifies itself
1015 as gcc 3.4.3 (csl-sol210-3_4-branch+sol_rpath), does not have
1016 a __builtin_isnan.
1017 * floatfns.c (isnan): #undef, and then #define to a clone of
1018 what's in data.c.
1019 (Fisnan): Always define, since it's always available now.
1020 (syms_of_floatfns): Always define isnan at the Lisp level.
1021
e39b275c 10222011-09-06 Paul Eggert <eggert@cs.ucla.edu>
1c262cae
PE
1023
1024 * Makefile.in (gl-stamp): move-if-change now in build-aux (Bug#9169).
1025
b2db44d9 10262011-09-06 Paul Eggert <eggert@cs.ucla.edu>
728f8f0a 1027
f4af5137 1028 * fileio.c: Fix bugs with large file offsets (Bug#9428).
728f8f0a
PE
1029 The previous code assumed that file offsets (off_t values) fit in
1030 EMACS_INT variables, which is not true on typical 32-bit hosts.
1031 The code messed up by falsely reporting buffer overflow in cases
1032 such as (insert-file-contents "big" nil 1 2) into an empty buffer
1033 when "big" contains more than 2**29 bytes, even though this
1034 inserts just one byte and does not overflow the buffer.
1035 (Finsert_file_contents): Store file offsets as off_t
1036 values, not as EMACS_INT values. Check for overflow when
1037 converting between EMACS_INT and off_t. When checking for
1038 buffer overflow or for overlap, take the offsets into account.
1039 Don't use EMACS_INT for small values where int suffices.
1040 When checking for overlap, fix a typo: ZV was used where
1041 ZV_BYTE was intended.
1042 (Fwrite_region): Don't assume off_t fits into 'long'.
1043 * buffer.h (struct buffer.modtime_size): Now off_t, not EMACS_INT.
1044
ecfc0a49
MA
10452011-09-05 Michael Albinus <michael.albinus@gmx.de>
1046
1047 * dbusbind.c (xd_signature_cat): Rename from signature_cat.
1048
6511acf2 10492011-09-04 Paul Eggert <eggert@cs.ucla.edu>
61bfeeb7 1050
0999621a 1051 sprintf-related integer and memory overflow issues (Bug#9412).
62f19c19
PE
1052
1053 * doprnt.c (doprnt): Support printing ptrdiff_t and intmax_t values.
8666506e 1054 (esprintf, exprintf, evxprintf): New functions.
62f19c19 1055 * keyboard.c (command_loop_level): Now EMACS_INT, not int.
6b02f655 1056 (cmd_error): Kbd macro iterations count is now EMACS_INT, not int.
62f19c19
PE
1057 (modify_event_symbol): Do not assume that the length of
1058 name_alist_or_stem is safe to alloca and fits in int.
1059 (Fexecute_extended_command): Likewise for function name and binding.
1060 (Frecursion_depth): Wrap around reliably on integer overflow.
1061 * keymap.c (push_key_description): First arg is now EMACS_INT, not int,
1062 since some callers pass EMACS_INT values.
1063 (Fsingle_key_description): Don't crash if symbol name contains more
1064 than MAX_ALLOCA bytes.
1065 * minibuf.c (minibuf_level): Now EMACS_INT, not int.
1066 (get_minibuffer): Arg is now EMACS_INT, not int.
1067 * lisp.h (get_minibuffer, push_key_description): Reflect API changes.
8666506e 1068 (esprintf, exprintf, evxprintf): New decls.
62f19c19
PE
1069 * window.h (command_loop_level, minibuf_level): Reflect API changes.
1070
2be7d702
PE
1071 * dbusbind.c (signature_cat): New function.
1072 (xd_signature, Fdbus_register_signal):
2ea16b89
PE
1073 Do not overrun buffer; instead, report string overflow.
1074
9d1df220
PE
1075 * dispnew.c (add_window_display_history): Don't overrun buffer.
1076 Truncate instead; this is OK since it's just a log.
1077
33ef5c64
PE
1078 * editfns.c (Fcurrent_time_zone): Don't overrun buffer
1079 even if the time zone offset is outlandishly large.
1080 Don't mishandle offset == INT_MIN.
1081
66c6fdd5
PE
1082 * emacs.c (main) [NS_IMPL_COCOA]: Don't overrun buffer
1083 when creating daemon; the previous buffer-overflow check was incorrect.
1084
d749b01b
PE
1085 * eval.c (verror): Simplify by rewriting in terms of evxprintf,
1086 which has the guts of the old verror function.
1087
b5cd1905
PE
1088 * filelock.c (lock_file_1, lock_file): Don't blindly alloca long name;
1089 use SAFE_ALLOCA instead. Use esprintf to avoid int-overflow issues.
1090
6e1a67fb
PE
1091 * font.c: Include <float.h>, for DBL_MAX_10_EXP.
1092 (font_unparse_xlfd): Don't blindly alloca long strings.
c21721cc 1093 Don't assume XINT result fits in int, or that XFLOAT_DATA * 10
8666506e 1094 fits in int, when using sprintf. Use single snprintf to count
c21721cc
PE
1095 length of string rather than counting it via multiple sprintfs;
1096 that's simpler and more reliable.
c21721cc
PE
1097 (font_unparse_fcname): Use it to avoid sprintf buffer overrun.
1098 (generate_otf_features) [0 && HAVE_LIBOTF]: Use esprintf, not
1099 sprintf, in case result does not fit in int.
1100
c57b67fc
PE
1101 * fontset.c (num_auto_fontsets): Now printmax_t, not int.
1102 (fontset_from_font): Print it.
1103
8a401434
PE
1104 * frame.c (tty_frame_count): Now printmax_t, not int.
1105 (make_terminal_frame, set_term_frame_name): Print it.
1106 (x_report_frame_params): In X, window IDs are unsigned long,
1107 not signed long, so print them as unsigned.
1108 (validate_x_resource_name): Check for implausibly long names,
1109 and don't assume name length fits in 'int'.
1110 (x_get_resource_string): Don't blindly alloca invocation name;
1111 use SAFE_ALLOCA. Use esprintf, not sprintf, in case result does
1112 not fit in int.
1113
6e1a67fb
PE
1114 * gtkutil.c: Include <float.h>, for DBL_MAX_10_EXP.
1115 (xg_check_special_colors, xg_set_geometry):
84722b3d
PE
1116 Make sprintf buffers a bit bigger, to avoid potential buffer overrun.
1117
0df02bf3
PE
1118 * lread.c (dir_warning): Don't blindly alloca buffer; use SAFE_ALLOCA.
1119 Use esprintf, not sprintf, in case result does not fit in int.
1120
48e30793
PE
1121 * macros.c (executing_kbd_macro_iterations): Now EMACS_INT, not int.
1122 (Fend_kbd_macro): Don't mishandle MOST_NEGATIVE_FIXNUM by treating
1123 it as a large positive number.
1124 (Fexecute_kbd_macro): Don't assume repeat count fits in int.
1125 * macros.h (executing_kbd_macro_iterations): Now EMACS_INT, not int.
1126
a66ff6d8
PE
1127 * nsterm.m ((NSSize)windowWillResize): Use esprintf, not sprintf,
1128 in case result does not fit in int.
1129
aca216ff
PE
1130 * print.c (float_to_string): Detect width overflow more reliably.
1131 (print_object): Make sprintf buffer a bit bigger, to avoid potential
1132 buffer overrun. Don't assume list length fits in 'int'. Treat
1133 print length of 0 as 0, not as infinity; to be consistent with other
1134 uses of print length in this function. Don't overflow print length
1135 index. Don't assume hash table size fits in 'long', or that
1136 vectorlike size fits in 'unsigned long'.
1137
31c286f7
PE
1138 * process.c (make_process): Use printmax_t, not int, to format
1139 process-name gensyms.
1140
55e5faa1
PE
1141 * sysdep.c (snprintf) [! HAVE_SNPRINTF]: New function.
1142
80f2e268
PE
1143 * term.c (produce_glyphless_glyph): Make sprintf buffer a bit bigger
1144 to avoid potential buffer overrun.
1145
670741ab
PE
1146 * xfaces.c (x_update_menu_appearance): Don't overrun buffer
1147 if X resource line is longer than 512 bytes.
1148
b7163a50
PE
1149 * xfns.c (x_window): Make sprintf buffer a bit bigger
1150 to avoid potential buffer overrun.
1151
ae58ff1f
PE
1152 * xterm.c (x_io_error_quitter): Don't overrun sprintf buffer.
1153
c43c8a6a
PE
1154 * xterm.h (x_check_errors): Add ATTRIBUTE_FORMAT_PRINTF.
1155
3f8236f4
PE
11562011-09-04 Paul Eggert <eggert@cs.ucla.edu>
1157
53e9fe90 1158 Integer overflow fixes for scrolling, etc.
6511acf2
PE
1159 Without these, Emacs silently mishandles large integers sometimes.
1160 For example, "C-u 4294967297 M-x recenter" was treated as if
53e9fe90
PE
1161 it were "C-u 1 M-x recenter" on a typical 64-bit host.
1162
6511acf2
PE
1163 * xdisp.c (try_window_id): Check Emacs fixnum range before
1164 converting to 'int'.
806add1d 1165
6511acf2 1166 * window.c (window_scroll_line_based, Frecenter):
71f02bc5
PE
1167 Check that an Emacs fixnum is in range before assigning it to 'int'.
1168 (Frecenter, Fmove_to_window_line): Use EMACS_INT, not int, for
1169 values converted from Emacs fixnums.
1170 (Frecenter): Don't wrap around a line count if it is out of 'int'
1171 range; instead, treat it as an extreme value.
1172 (Fset_window_configuration, compare_window_configurations):
1173 Use ptrdiff_t, not int, for index that might exceed 2 GiB.
1174
6511acf2
PE
1175 * search.c (Freplace_match): Use ptrdiff_t, not int, for indexes
1176 that can exceed INT_MAX. Check that EMACS_INT value is in range
1177 before assigning it to the (possibly-narrower) index.
a0efffc8
PE
1178 (match_limit): Don't assume that a fixnum can fit in 'int'.
1179
6511acf2 1180 * print.c (print_object): Use ptrdiff_t, not int, for index that can
29ebea3b
PE
1181 exceed INT_MAX.
1182
6511acf2 1183 * indent.c (position_indentation): Now takes ptrdiff_t, not int.
3f8236f4
PE
1184 (Fvertical_motion): Don't wrap around LINES values that don't fit
1185 in 'int'. Instead, treat them as extreme values. This is good
1186 enough for windows, which can't have more than INT_MAX lines anyway.
1187
fcb901a7
LMI
11882011-09-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
1189
0f2f6b6d
LMI
1190 * Require libxml/parser.h to avoid compilation warning.
1191
fcb901a7
LMI
1192 * emacs.c (shut_down_emacs): Call xmlCleanupParser on shutdown.
1193
1194 * xml.c (parse_region): Don't call xmlCleanupParser after parsing,
1195 since this reportedly can destroy thread storage.
1196
6e20a0d4
CY
11972011-08-30 Chong Yidong <cyd@stupidchicken.com>
1198
1199 * syntax.c (find_defun_start): Update all cache variables if
1200 exiting early (Bug#9401).
1201
148ae00e
EZ
12022011-08-30 Eli Zaretskii <eliz@gnu.org>
1203
f6cfbd8f
EZ
1204 * image.c (x_bitmap_pixmap): Cast to int to avoid compiler warnings.
1205
148ae00e
EZ
1206 * xdisp.c (produce_stretch_glyph): No longer static, compiled also
1207 when HAVE_WINDOW_SYSTEM is not defined. Support both GUI and TTY
1208 frames. Call tty_append_glyph in the TTY case. (Bug#9402)
1209
1210 * term.c (tty_append_glyph): New function.
1211 (produce_stretch_glyph): Static function and its prototype deleted.
1212
a66cfb1c
SM
1213 * dispextern.h (produce_stretch_glyph, tty_append_glyph):
1214 Add prototypes.
148ae00e 1215
c4a07a4c
PE
12162011-08-29 Paul Eggert <eggert@cs.ucla.edu>
1217
1218 * image.c (parse_image_spec): Check for nonnegative, not for positive,
1219 when checking :margin (Bug#9390).
1220 (IMAGE_NON_NEGATIVE_INTEGER_VALUE_OR_PAIR):
a66cfb1c 1221 Rename from IMAGE_POSITIVE_INTEGER_VALUE_OR_PAIR,
c4a07a4c
PE
1222 so that the name doesn't mislead. All uses changed.
1223
6bc8cd65
JB
12242011-08-28 Johan Bockgård <bojohan@gnu.org>
1225
1226 * term.c (init_tty) [HAVE_GPM]: Move mouse settings after
1227 set_tty_hooks.
1228
dca4927e
EZ
12292011-08-27 Eli Zaretskii <eliz@gnu.org>
1230
1231 * xdisp.c (move_it_to): Don't bail out early when reaching
1232 position beyond to_charpos, if we are scanning backwards.
1233 (move_it_vertically_backward): When DY == 0, make sure we get to
1234 the first character in the line after the newline.
1235
f2cad773
PE
12362011-08-27 Paul Eggert <eggert@cs.ucla.edu>
1237
1238 * ccl.c: Improve and simplify overflow checking (Bug#9196).
1239 (ccl_driver): Do not generate an out-of-range pointer.
1240 (Fccl_execute_on_string): Remove unnecessary check for
1241 integer overflow, noted by Stefan Monnier in
1242 <http://lists.gnu.org/archive/html/emacs-devel/2011-08/msg00979.html>.
1243 Remove a FIXME that didn't need fixing.
1244 Simplify the newly-introduced buffer reallocation code.
1245
0cae2cdb
JB
12462011-08-27 Juanma Barranquero <lekktu@gmail.com>
1247
1248 * makefile.w32-in ($(BLD)/alloc.$(O)): Depend on lib/verify.h.
1249
5fc295a4 12502011-08-26 Paul Eggert <eggert@cs.ucla.edu>
ddff3151 1251
70c60eb2 1252 Integer and memory overflow issues (Bug#9196).
726e0ab1 1253
d31850da
PE
1254 * doc.c (get_doc_string): Rework so that
1255 get_doc_string_buffer_size is the actual buffer size, rather than
1256 being 1 less than the actual buffer size; this makes xpalloc more
1257 convenient.
1258
a69fbedb
PE
1259 * image.c (x_allocate_bitmap_record, cache_image):
1260 * xselect.c (Fx_register_dnd_atom):
1261 Simplify previous changes by using xpalloc.
1262
fe5c5d37
PE
1263 * buffer.c (overlay_str_len): Now ptrdiff_t, not EMACS_INT,
1264 since either will do and ptrdiff_t is convenient with xpalloc.
1265
0065d054
PE
1266 * charset.c (charset_table_size)
1267 (struct charset_sort_data.priority): Now ptrdiff_t.
1268 (charset_compare): Don't overflow if priorities differ greatly.
1269 (Fsort_charsets): Don't assume list length fits in int.
1270 Check for size-calculation overflow when allocating sort data.
1271 (syms_of_charset): Allocate an initial charset table that is
1272 just under 64 KiB, to avoid problems with glibc malloc and mmap.
1273
1274 * cmds.c (internal_self_insert): Check for size-calculation overflow.
1275
1276 * composite.h (struct composition.glyph_len): Now int, not unsigned.
1277 The actual value is always <= INT_MAX, and leaving it unsigned made
1278 overflow checking harder.
1279
1280 * dispextern.h (struct glyph_matrix.rows_allocated)
1281 (struct face_cache.size): Now ptrdiff_t, for convenience in use
1282 with xpalloc. The values are still always <= INT_MAX.
1283
1284 * indent.c (compute_motion): Adjust to region_cache_forward sig change.
1285
1286 * lisp.h (xnmalloc, xnrealloc, xpalloc): New decls.
1287 (SAFE_NALLOCA): New macro.
1288
1289 * region-cache.c (struct boundary.pos, find_cache_boundary)
1290 (move_cache_gap, insert_cache_boundary, delete_cache_boundaries)
1291 (set_cache_region, invalidate_region_cache)
1292 (revalidate_region_cache, know_region_cache, region_cache_forward)
1293 (region_cache_backward, pp_cache):
1294 Use ptrdiff_t, not EMACS_INT, since either will do. This is needed
1295 so that ptrdiff_t * can be passed to xpalloc.
1296 (struct region_cache): Similarly, for gap_start, gap_len, cache_len,
1297 beg_unchanged, end_unchanged, buffer_beg, buffer_end members.
1298 (pp_cache): Don't assume cache_len fits in int.
1299 * region-cache.h: Adjust extern decls to match.
1300
1301 * search.c (scan_buffer, Freplace_match): Use ptrdiff_t, not
1302 EMACS_INT, since either will do, for xpalloc.
1303
1304 * alloc.c: Include verify.h, and check that int fits in ptrdiff_t.
1305 (xnmalloc, xnrealloc, xpalloc): New functions.
1306
726e0ab1
PE
1307 * bidi.c (bidi_shelve_header_size): New constant.
1308 (bidi_cache_ensure_space, bidi_shelve_cache): Use it.
1309 (bidi_cache_ensure_space): Avoid integer overflow when allocating.
1310
51f30bc5 1311 * bidi.c (bidi_cache_shrink):
726e0ab1
PE
1312 * buffer.c (overlays_at, overlays_in, record_overlay_string)
1313 (overlay_strings):
1314 Don't update size of array until after memory allocation succeeds,
1315 because xmalloc/xrealloc may not return.
0065d054
PE
1316 (struct sortstrlist.bytes): Now ptrdiff_t, as EMACS_INT doesn't help
1317 now that we have proper integer overflow checking.
1318 (record_overlay_string, overlay_strings): Catch overflows when
1319 calculating size of overlay_str_buf.
726e0ab1 1320
0065d054
PE
1321 * callproc.c (Fcall_process): Check for size overflow when
1322 calculating size of args2.
1323 (child_setup): Avoid overflow by using size_t rather than ptrdiff_t.
1324 Normally we prefer signed values, but sticking with ptrdiff_t would
1325 require adding more-complicated checks.
726e0ab1
PE
1326
1327 * ccl.c (Fccl_execute_on_string): Check for memory overflow.
1328 Use ptrdiff_t rather than EMACS_INT where ptrdiff_t will do.
1329 Redo buffer-overflow calculations to avoid integer overflow.
0065d054 1330 Add a FIXME comment where memory seems to be over-allocated.
726e0ab1
PE
1331
1332 * character.c (Fstring): Check for size-calculation overflow.
1333
1334 * coding.c (produce_chars): Redo buffer-overflow calculations to avoid
1335 unnecessary integer overflow. Check for size overflow.
1336 (encode_coding_object): Don't update size until xmalloc succeeds.
1337
1338 * composite.c (get_composition_id): Check for overflow in glyph
1339 length calculations.
1340
1341 Integer and memory overflow fixes for display code.
1342 * dispextern.h (struct glyph_pool.nglyphs): Now ptrdiff_t, not int.
1343 * dispnew.c (adjust_glyph_matrix, realloc_glyph_pool)
1344 (scrolling_window): Check for overflow in size calculations.
1345 (line_draw_cost, realloc_glyph_pool, add_row_entry):
1346 Don't assume glyph table len fits in int.
1347 (struct row_entry.bucket, row_entry_pool_size, row_entry_idx)
1348 (row_table_size): Now ptrdiff_t, not int.
1349 (scrolling_window): Avoid overflow in size calculations.
1350 Don't update size until allocation succeeds.
1351 * fns.c (concat): Check for overflow in size calculations.
1352 (next_almost_prime): Verify NEXT_ALMOST_PRIME_LIMIT.
1353 * lisp.h (RANGED_INTEGERP, TYPE_RANGED_INTEGERP): New macros.
1354 (NEXT_ALMOST_PRIME_LIMIT): New constant.
1355
1356 * doc.c (get_doc_string_buffer_size): Now ptrdiff_t, not int.
1357 (get_doc_string): Check for size calculation overflow.
1358 Don't update size until allocation succeeds.
1359 (get_doc_string, Fsubstitute_command_keys): Use ptrdiff_t, not
1360 EMACS_INT, where ptrdiff_t will do.
1361 (Fsubstitute_command_keys): Check for string overflow.
1362
1363 * editfns.c (set_time_zone_rule): Don't assume environment length
1364 fits in int.
1365 (message_length): Now ptrdiff_t, not int.
1366 (Fmessage_box): Don't update size until allocation succeeds.
1367 Don't assume message length fits in int.
1368 (Fformat): Use ptrdiff_t, not EMACS_INT, where ptrdiff_t will do.
1369
0065d054
PE
1370 * emacs.c (main): Do not reallocate argv, since there is a null at
1371 the end that can be overwritten, and this way there's no need to
1372 worry about size-calculation overflow.
1373 (sort_args): Check for size-calculation overflow.
726e0ab1
PE
1374
1375 * eval.c (init_eval_once, grow_specpdl): Don't update size until
1376 alloc succeeds.
1377 (call_debugger, grow_specpdl): Redo calculations to avoid overflow.
1378
1379 * frame.c (set_menu_bar_lines, x_set_frame_parameters)
1380 (x_set_scroll_bar_width, x_figure_window_size):
1381 Check for integer overflow.
1382 (x_set_alpha): Do not assume XINT fits in int.
1383
1384 * frame.h (struct frame): Use int, not EMACS_INT, where int works.
1385 This is for the members text_lines, text_cols, total_lines, total_cols,
1386 where the system imposes an 'int' limit.
1387
1388 * fringe.c (Fdefine_fringe_bitmap):
1389 Don't update size until alloc works.
1390
1391 * ftfont.c (ftfont_get_open_type_spec, setup_otf_gstring)
1392 (ftfont_shape_by_flt): Check for integer overflow in size calculations.
1393
1394 * gtkutil.c (get_utf8_string, xg_store_widget_in_map):
1395 Check for size-calculation overflow.
1396 (get_utf8_string): Use ptrdiff_t, not size_t, where either will
1397 do, as we prefer signed integers.
1398 (id_to_widget.max_size, id_to_widget.used)
1399 (xg_store_widget_in_map, xg_remove_widget_from_map)
1400 (xg_get_widget_from_map, xg_get_scroll_id_for_window)
1401 (xg_remove_scroll_bar, xg_update_scrollbar_pos):
1402 Use and return ptrdiff_t, not int.
1403 (xg_gtk_scroll_destroy): Don't assume ptrdiff_t fits in int.
1404 * gtkutil.h: Change prototypes to match the above.
1405
1406 * image.c (RANGED_INTEGERP, TYPE_RANGED_INTEGERP): Remove; these
1407 are duplicate now that they've been promoted to lisp.h.
1408 (x_allocate_bitmap_record, x_alloc_image_color)
1409 (make_image_cache, cache_image, xpm_load):
1410 Don't update size until alloc is done.
1411 (xpm_load, lookup_rgb_color, lookup_pixel_color, x_to_xcolors)
1412 (x_detect_edges):
3256efce 1413 Check for size calculation overflow.
726e0ab1
PE
1414 (ct_colors_allocated_max): New constant.
1415 (x_to_xcolors, x_detect_edges): Reorder multiplicands to avoid
1416 overflow.
3256efce 1417
726e0ab1
PE
1418 * keyboard.c (read_char, menu_bar_items, tool_bar_items)
1419 (read_char_x_menu_prompt, read_char_minibuf_menu_width)
1420 (read_char_minibuf_menu_prompt, follow_key, read_key_sequence):
1421 Use ptrdiff_t, not int, to count maps.
1422 (read_char_minibuf_menu_prompt): Check for overflow in size
a66cfb1c
SM
1423 calculations. Don't update size until allocation succeeds.
1424 Redo calculations to avoid overflow.
726e0ab1
PE
1425 * keyboard.h: Change prototypes to match the above.
1426
1427 * keymap.c (cmm_size, current_minor_maps): Use ptrdiff_t, not int,
1428 to count maps.
1429 (current_minor_maps): Check for size calculation overflow.
1430 * keymap.h: Change prototypes to match the above.
1431
1432 * lread.c (read1, init_obarray): Don't update size until alloc done.
1433
1434 * macros.c (Fstart_kbd_macro): Don't update size until alloc done.
1435 (store_kbd_macro_char): Reorder multiplicands to avoid overflow.
1436
726e0ab1
PE
1437 * nsterm.h (struct ns_color_table.size, struct ns_color_table.avail):
1438 Now ptrdiff_t, not int.
1439 * nsterm.m (ns_index_color): Use ptrdiff_t, not int, for table indexes.
1440 (ns_draw_fringe_bitmap): Rewrite to avoid overflow.
1441
1442 * process.c (Fnetwork_interface_list): Check for overflow
1443 in size calculation.
1444
1445 * region-cache.c (move_cache_gap): Check for size calculation overflow.
1446
1447 * scroll.c (do_line_insertion_deletion_costs): Check for size calc
1448 overflow. Don't bother calling xmalloc when xrealloc will do.
1449
1450 * search.c (Freplace_match): Check for size calculation overflow.
1451 (Fset_match_data): Don't assume list lengths fit in 'int'.
1452
1453 * sysdep.c (system_process_attributes): Use ptrdiff_t, not int,
1454 for command line length. Do not attempt to address one before the
1455 beginning of an array, as that's not portable.
1456
1457 * term.c (max_frame_lines): Remove; unused.
1458 (encode_terminal_src_size, encode_terminal_dst_size): Now ptrdiff_t,
1459 not int.
1460 (encode_terminal_code, calculate_costs): Check for size
1461 calculation overflow.
1462 (encode_terminal_code): Use ptrdiff_t, not int, to record glyph
1463 table lengths and related sizes. Don't update size until alloc
1464 done. Redo calculations to avoid overflow.
1465 (calculate_costs): Don't bother calling xmalloc when xrealloc will do.
1466
1467 * termcap.c (tgetent): Use ptrdiff_t, not int, to record results of
1468 subtracting pointers.
1469 (gobble_line): Check for overflow more carefully. Don't update size
1470 until alloc done.
1471
1472 * tparam.c (tparam1): Use ptrdiff_t, not int, for sizes.
1473 Don't update size until alloc done.
1474 Redo size calculations to avoid overflow.
1475 Check for size calculation overflow.
0065d054 1476 (main) [DEBUG]: Fix typo in invoking tparam1.
726e0ab1
PE
1477
1478 * xdisp.c (store_mode_line_noprop_char, x_consider_frame_title):
1479 Use ptrdiff_t, not int, for sizes.
1480 (store_mode_line_noprop_char): Don't update size until alloc done.
1481
0065d054
PE
1482 * xfaces.c (lface_id_to_name_size, Finternal_make_lisp_face):
1483 Use ptrdiff_t, not int, for sizes.
1484 (Finternal_make_lisp_face, cache_face):
1485 Check for size calculation overflow.
1486 (cache_face): Treat size calculation overflows as if they were
1487 memory exhaustion (the usual treatment), rather than aborting.
726e0ab1
PE
1488
1489 * xfns.c (x_encode_text, x_set_name_internal)
1490 (Fx_change_window_property): Use ptrdiff_t, not int, to count
1491 sizes, since they can exceed INT_MAX in size. Check for size
1492 calculation overflow.
1493
0065d054
PE
1494 * xgselect.c (gfds_size): Now ptrdiff_t, for convenience with xpalloc.
1495 (xg_select): Check for size calculation overflow.
726e0ab1
PE
1496 Don't update size until alloc done.
1497
0065d054 1498 * xrdb.c (get_environ_db): Don't assume path length fits in int,
726e0ab1 1499 as sprintf is limited to int lengths.
1d526e2f 1500
252c5ee1
PE
1501 * xselect.c (X_LONG_SIZE, X_SHRT_MAX, X_SHRT_MIN, X_LONG_MAX)
1502 (X_LONG_MIN): New macros.
864d7ce7
PE
1503 Use them to make the following changes clearer.
1504 (MAX_SELECTION_QUANTUM): Make the other bounds on this value clearer.
1505 This change doesn't affect the value now, but it may help remind
1506 future maintainers not to raise the value too much later.
1507 (SELECTION_QUANTUM): Remove, replacing with ...
1508 (selection_quantum): ... new function, which avoids overflow.
1509 All uses changed.
1510 (struct selection_data.size): Now ptrdiff_t, not int, to avoid
1511 assumption that selection length fits in 'int'.
1512 (x_reply_selection_request, x_handle_selection_request)
1513 (x_get_window_property, receive_incremental_selection)
1514 (x_get_window_property_as_lisp_data, selection_data_to_lisp_data)
1515 (lisp_data_to_selection_data, clean_local_selection_data):
1516 Use ptrdiff_t, not int, to record length of selection.
1517 (x_reply_selection_request, x_get_window_property)
1518 (receive_incremental_selection, x_property_data_to_lisp):
1519 Redo calculations to avoid overflow.
1520 (x_reply_selection_request): When sending hint, ceiling it at
252c5ee1 1521 X_LONG_MAX rather than relying on wraparound overflow to send
864d7ce7
PE
1522 something.
1523 (x_get_window_property, receive_incremental_selection)
1524 (lisp_data_to_selection_data, x_property_data_to_lisp):
1525 Check for size-calculation overflow.
1526 (x_get_window_property, receive_incremental_selection)
1527 (lisp_data_to_selection_data, Fx_register_dnd_atom):
1528 Don't store size until memory allocation succeeds.
1529 (x_get_window_property): Plug memory leak on memory exhaustion.
1530 Don't double-block input; malloc is safe here. Don't assume 2**34
1531 - 4 fits in unsigned long. Add an xassert to check
1532 XGetWindowProperty overflow. Be more careful about overflow
1533 calculations, and distinguish size from memory overflow better.
1534 (receive_incremental_selection): When tracing, don't assume
1535 unsigned int is less than INT_MAX.
1536 (x_selection_data_to_lisp_data): Remove unnecessary (and in theory
1537 harmful) conversions of unsigned short to int.
1538 (lisp_data_to_selection_data): Don't assume that integers
1539 in the range -65535 through -1 fit in an X unsigned short.
1540 Don't assume that ULONG_MAX == X_ULONG_MAX. Don't store into
1541 result parameters unless successful. Rely on cons_to_unsigned
1542 to report problems with elements; the old code wasn't right anyway.
1543 (x_check_property_data): Check for int overflow; we cannot use
1544 a wider type due to X limits.
1545 (x_handle_dnd_message): Use unsigned int, to avoid int overflow.
1546
726e0ab1 1547 * xsmfns.c (smc_save_yourself_CB): Check for size calc overflow.
34db673b 1548
0065d054
PE
1549 * xterm.c (x_color_cells, x_send_scrollbar_event, handle_one_xevent)
1550 (x_term_init): Check for size calculation overflow.
726e0ab1
PE
1551 (x_color_cells): Don't store size until memory allocation succeeds.
1552 (handle_one_xevent): Use ptrdiff_t, not int, for byte counts.
0065d054 1553 Don't assume alloca size is less than MAX_ALLOCA.
726e0ab1
PE
1554 (x_term_init): Don't assume length fits in int (sprintf is limited
1555 to int size).
bc18e09d 1556
ebfa62c0
PE
1557 Use ptrdiff_t for composition IDs.
1558 * character.c (lisp_string_width):
1559 * composite.c (composition_table_size, n_compositions)
1560 (get_composition_id, composition_gstring_from_id):
1561 * dispextern.h (struct glyph_string.cmp_id, struct composition_it.id):
1562 * xdisp.c (BUILD_COMPOSITE_GLYPH_STRING):
1563 * window.c (Frecenter):
1564 Use ptrdiff_t, not int, for composition IDs.
1565 * composite.c (get_composition_id): Check for integer overflow.
1566 * composite.h: Adjust prototypes to match the above changes.
1567
d3411f89
PE
1568 Use ptrdiff_t for hash table indexes.
1569 * category.c (hash_get_category_set):
1570 * ccl.c (ccl_driver):
1571 * charset.h (struct charset.hash_index, CHECK_CHARSET_GET_ID):
1572 * coding.c (coding_system_charset_list, detect_coding_system):
1573 * coding.h (struct coding_system.id):
1574 * composite.c (get_composition_id, gstring_lookup_cache):
1575 * fns.c (hash_lookup, hash_put, Fgethash, Fputhash):
1576 * image.c (xpm_get_color_table_h):
1577 * lisp.h (hash_lookup, hash_put):
1578 * minibuf.c (Ftest_completion):
1579 Use ptrdiff_t for hash table indexes, not int (which is too
1580 narrow, on 64-bit hosts) or EMACS_INT (which is too wide, on
1581 32-bit --with-wide-int hosts).
1582
e097a6fa
PE
1583 * charset.c (Fdefine_charset_internal): Check for integer overflow.
1584 Add a FIXME comment about memory leaks.
1585 (syms_of_charset): Don't assume xmalloc returns.
1586
5637687f
PE
1587 Don't assume that stated character widths fit in int.
1588 * character.c (Fchar_width, c_string_width, lisp_string_width):
1589 * character.h (CHAR_WIDTH):
1590 * indent.c (MULTIBYTE_BYTES_WIDTH):
1591 Use sanitize_char_width to avoid undefined and/or bad behavior
1592 with outlandish widths.
a66cfb1c 1593 * character.h (sanitize_tab_width): Rename from sanitize_width,
5637687f
PE
1594 now that we have two such functions. All uses changed.
1595 (sanitize_char_width): New inline function.
1596
a2271ba2
PE
1597 Don't assume that tab-width fits in int.
1598 * character.h (sanitize_width): New inline function.
1599 (SANE_TAB_WIDTH): New macro.
1600 (ASCII_CHAR_WIDTH): Use it.
1601 * indent.c (sane_tab_width): Remove. All uses replaced by
1602 SANE_TAB_WIDTH (current_buffer).
1603 * xdisp.c (init_iterator): Use SANE_TAB_WIDTH.
1604
18c52557
PE
1605 * fileio.c: Integer overflow issues with file modes.
1606 (Fset_file_modes, auto_save_1): Don't assume EMACS_INT fits in int.
1607
caeeedc1
PE
1608 * charset.c (read_hex): New arg OVERFLOW. All uses changed.
1609 Remove unreachable code.
1610 (read_hex, load_charset_map_from_file): Check for integer overflow.
1611
50849c52
PE
1612 * xterm.c: don't go over XClientMessageEvent limit
1613 (scroll_bar_windows_size): Now ptrdiff_t, as we prefer signed.
1614 (x_send_scroll_bar_event): Likewise. Check that the size does not
1615 exceed limits imposed by XClientMessageEvent, as well as the usual
1616 ptrdiff_t and size_t limits.
1617
b13995db
PE
1618 * keyboard.c: Overflow, signedness and related fixes.
1619 (make_lispy_movement): Use same integer type in forward decl
1620 that is used in the definition.
1621 (read_key_sequence, keyremap_step):
1622 Change bufsize argument back to int, undoing my 2011-03-30 change.
1623 We prefer signed types, and int is wide enough here.
1624 (parse_tool_bar_item): Don't assume tool_bar_max_label_size is less
1625 than TYPE_MAXIMUM (EMACS_INT) / 2. Don't let the label size grow
1626 larger than STRING_BYTES_BOUND. Use ptrdiff_t for Emacs string
1627 length, not size_t. Use ptrdiff_t for index, not int.
1628 (keyremap_step, read_key_sequence): Redo bufsize check to avoid
1629 possibility of integer overflow.
1630
13464394
PE
1631 Overflow, signedness and related fixes for images.
1632
1633 * dispextern.h (struct it.stack[0].u.image.image_id)
1634 (struct_it.image_id, struct image.id, struct image_cache.size)
1635 (struct image_cache.used, struct image_cache.ref_count):
1636 * gtkutil.c (update_frame_tool_bar):
1637 * image.c (x_reference_bitmap, Fimage_size, Fimage_mask_p)
1638 (Fimage_metadata, free_image_cache, clear_image_cache, lookup_image)
1639 (cache_image, mark_image_cache, x_kill_gs_process, Flookup_image):
1640 * nsmenu.m (update_frame_tool_bar):
1641 * xdisp.c (calc_pixel_width_or_height):
1642 * xfns.c (image_cache_refcount):
1643 Image IDs are now ptrdiff_t, not int, to avoid arbitrary limits
1644 on typical 64-bit hosts.
1645
1646 * image.c (RANGED_INTEGERP, TYPE_RANGED_INTEGERP): New macros.
1647 (x_bitmap_pixmap, x_create_x_image_and_pixmap):
1648 Omit unnecessary casts to int.
1649 (parse_image_spec): Check that integers fall into 'int' range
1650 when the callers expect that.
1651 (image_ascent): Redo ascent calculation to avoid int overflow.
1652 (clear_image_cache): Avoid overflow when sqrt (INT_MAX) < nimages.
1653 (lookup_image): Remove unnecessary tests.
1654 (xbm_image_p): Locals are now of int, not EMACS_INT,
1655 since parse_image_check makes sure they fit into int.
1656 (png_load, gif_load, svg_load_image):
1657 Prefer int to unsigned where either will do.
1658 (tiff_handler): New function, combining the cores of the
a66cfb1c
SM
1659 old tiff_error_handler and tiff_warning_handler.
1660 This function is rewritten to use vsnprintf and thereby avoid
13464394
PE
1661 stack buffer overflows. It uses only the features of vsnprintf
1662 that are common to both POSIX and native Microsoft.
1663 (tiff_error_handler, tiff_warning_handler): Use it.
1664 (tiff_load, gif_load, imagemagick_load_image):
1665 Don't assume :index value fits in 'int'.
1666 (gif_load): Omit unnecessary cast to double, and avoid double-rounding.
1667 (imagemagick_load_image): Check that crop parameters fit into
1668 the integer types that MagickCropImage accepts. Don't assume
1669 Vimagemagick_render_type has a nonnegative value. Don't assume
1670 size_t fits in 'long'.
1671 (gs_load): Use printmax_t to print the widest integers possible.
1672 Check for integer overflow when computing image height and width.
1673
c11821d4
EZ
16742011-08-26 Eli Zaretskii <eliz@gnu.org>
1675
1676 * xdisp.c (redisplay_window): Don't force window start if point
1677 will be invisible in the resulting window. (Bug#9324)
1678
0c95fcf7
EZ
16792011-08-25 Eli Zaretskii <eliz@gnu.org>
1680
1681 * xdisp.c (compute_display_string_pos): Return 2 in DISP_PROP when
1682 the display spec is of the form `(space ...)'.
1683 (handle_display_spec): Return the value returned by
1684 handle_single_display_spec, not just 1 or zero.
1685 (handle_single_display_spec): If the display spec is of the form
1686 `(space ...)', and specifies display in the text area, return 2
1687 rather than 1.
fee65a97 1688 (try_cursor_movement): Check for the need to scroll more
a66cfb1c
SM
1689 accurately, and prefer exact match for point under bidi.
1690 Don't advance `row' beyond the last row of the window.
0c95fcf7
EZ
1691
1692 * dispextern.h (struct bidi_it): Rename the disp_prop_p member
1693 into disp_prop; all users changed.
1694
1695 * bidi.c (bidi_fetch_char): If compute_display_string_pos returns
1696 DISP_PROP = 2, substitute the u+2029 PARAGRAPH SEPARATOR character
1697 for the text covered by the display property.
1698
e4ed06f1
CY
16992011-08-25 Chong Yidong <cyd@stupidchicken.com>
1700
1701 * buffer.c (Fbury_buffer_internal): Rename from Funrecord_buffer.
1702 Change return value to nil.
1703 (Frecord_buffer): Delete unused function.
1704
f67cdd7f
EZ
17052011-08-24 Eli Zaretskii <eliz@gnu.org>
1706
5980d4c6
EZ
1707 * xdisp.c (Fcurrent_bidi_paragraph_direction): For unibyte
1708 buffers, return left-to-right.
8610fe8b
EZ
1709 (set_cursor_from_row): Consider candidate row a win if its glyph
1710 represents a newline and point is on that newline. Fixes cursor
1711 positioning on the newline at EOL of R2L text within L2R
1712 paragraph, and vice versa.
1713 (try_cursor_movement): Check continued rows, in addition to
1714 continuation rows. Fixes unwarranted scroll when point enters a
1715 continued line of R2L text within an L2R paragraph, or vice versa.
1716 (cursor_row_p): Consider the case of point being equal to
1717 MATRIX_ROW_END_CHARPOS. Prevents cursor being stuck when moving
1718 from the end of a short line to the beginning of a continued line
1719 of R2L text within L2R paragraph.
1720 (RECORD_MAX_MIN_POS): For max_pos, use IT_CHARPOS even for
1721 composed characters.
5980d4c6 1722
f67cdd7f
EZ
1723 * bidi.c (bidi_check_type): Use xassert.
1724 (bidi_cache_iterator_state): Update the disp_pos and disp_prop_p
1725 members.
1726
bca633fb
EZ
17272011-08-23 Eli Zaretskii <eliz@gnu.org>
1728
1729 * bidi.c (bidi_get_type): Abort if we get zero as the bidi type of
1730 a character.
1731
4a5885a7
CY
17322011-08-23 Chong Yidong <cyd@stupidchicken.com>
1733
1734 * nsfont.m (ns_otf_to_script): Fix typo.
1735
0902a04e
KH
17362011-08-22 Kenichi Handa <handa@m17n.org>
1737
1738 * chartab.c (Fset_char_table_extra_slot): Do not inhibit setting a
1739 extra slot even if the purpose is char-code-property-table.
1740
1a2e6670
EZ
17412011-08-23 Eli Zaretskii <eliz@gnu.org>
1742
8ddde651
EZ
1743 * xdisp.c (redisplay_window): When computing centering_position,
1744 account for the height of the header line. (Bug#8874)
1745
425cc014
EZ
1746 * dispnew.c (buffer_posn_from_coords): Use buf_charpos_to_bytepos
1747 instead of CHAR_TO_BYTE. Fixes a crash when a completion
1748 candidate is selected by the mouse, and that candidate has a
1749 composed character under the mouse.
1750
1a2e6670
EZ
1751 * xdisp.c (x_produce_glyphs): Set it->nglyphs to 1. Fixes pixel
1752 coordinates reported by pos-visible-in-window-p for a composed
1753 character in column zero.
1754
8b76d6f8
SM
17552011-08-23 Stefan Monnier <monnier@iro.umontreal.ca>
1756
1757 * cmds.c (Fself_insert_command): Mention post-self-insert-hook.
1758
dac347dd
EZ
17592011-08-22 Eli Zaretskii <eliz@gnu.org>
1760
1761 * xdisp.c (BUFFER_POS_REACHED_P): If this is a composition,
1762 consider it a hit if to_charpos is anywhere in the range of the
1763 composed buffer positions.
1764
e013fb34
CY
17652011-08-22 Chong Yidong <cyd@stupidchicken.com>
1766
1767 * image.c (gif_load): Don't assume that each subimage has the same
1768 dimensions as the base image. Handle disposal method that is
1769 "undefined" by the gif spec (Bug#9335).
1770
bd1ba3e8
CY
17712011-08-20 Chong Yidong <cyd@stupidchicken.com>
1772
1773 * eval.c (Fsignal): Handle `debug' symbol in error handler (Bug#9329).
024a2d76 1774 (Fcondition_case): Document `debug' symbol in error handler.
bd1ba3e8 1775
54a1215b
EZ
17762011-08-19 Eli Zaretskii <eliz@gnu.org>
1777
823564e5
EZ
1778 * xfaces.c (face_at_buffer_position): Avoid repeated evaluation of
1779 face ID by FACE_FROM_ID, and avoid a crash when mouse is moved
1780 from an Org mode buffer to a Speedbar frame.
1781
54a1215b
EZ
1782 * xdisp.c (RECORD_MAX_MIN_POS): If the display element comes from
1783 a composition, take its buffer position from IT->cmp_it.charpos.
1784 Fixes cursor positioning at the beginning of a line that begins
1785 with a composed character.
1786
9778ebcc
EZ
17872011-08-18 Eli Zaretskii <eliz@gnu.org>
1788
0be6ee06
EZ
1789 * bidi.c (bidi_get_type): If bidi_type_table reports zero as the
1790 character bidirectional type, use STRONG_L instead. Fixes crashes
1791 in a buffer produced by `describe-categories'.
1792
9778ebcc
EZ
1793 * dispextern.h (struct bidi_it): Move disp_pos and disp_prop_p
1794 members before the level stack, so they would be saved and
1795 restored when copying iterator state. Fixes incorrect reordering
1796 around TABs covered by display properties.
1797
156bffbe
AS
17982011-08-18 Andreas Schwab <schwab@linux-m68k.org>
1799
6b02f655 1800 * process.c (Fnetwork_interface_list): Correctly determine buffer size.
156bffbe 1801
72ad093b
CY
18022011-08-17 Chong Yidong <cyd@stupidchicken.com>
1803
1804 * eval.c (internal_condition_case, internal_condition_case_1)
8b76d6f8
SM
1805 (internal_condition_case_2, internal_condition_case_n):
1806 Remove unnecessary aborts (Bug#9081).
72ad093b 1807
35774242
EZ
18082011-08-17 Eli Zaretskii <eliz@gnu.org>
1809
1810 * lread.c (Fload) [DOS_NT]: If `openp' returns -2, but the file
1811 has no `load' handler, try opening the file locally. (Bug#9311)
1812
db76dd85
KB
18132011-08-16 Ken Brown <kbrown@cornell.edu>
1814
1815 * gmalloc.c: Expand comment.
1816
b215eee5
EZ
18172011-08-16 Eli Zaretskii <eliz@gnu.org>
1818
1819 * xdisp.c (set_cursor_from_row): Don't accept a previous candidate
1820 if it fails the cursor_row_p test. Fixes cursor positioning at ZV.
1821
a4579d33
KB
18222011-08-16 Ken Brown <kbrown@cornell.edu>
1823
1824 Fix memory allocation problems in Cygwin build (Bug#9273).
1825
1826 * unexcw.c ( __malloc_initialized): Declare external variable.
1827 (fixup_executable): Force the dumped emacs to reinitialize malloc.
1828
8b76d6f8
SM
1829 * gmalloc.c [CYGWIN] (bss_sbrk_heapbase, bss_sbrk_heapinfo):
1830 New variables.
a4579d33
KB
1831 (malloc_initialize_1) [CYGWIN]: Prepare for reinitializing the
1832 dumped emacs.
1833 (_free_internal_nolock) [CYGWIN]: Ignore requests to free storage
1834 in the static heap.
1835 [CYGWIN] (special_realloc): New function.
1836 (_realloc_internal_nolock) [CYGWIN]: Use the new function on
1837 requests to realloc storage in the static heap.
1838
3ebec551
PE
18392011-08-15 Paul Eggert <eggert@cs.ucla.edu>
1840
1841 * bidi.c (bidi_initialize): Remove unused local.
1842
9fd8be00
EZ
18432011-08-15 Eli Zaretskii <eliz@gnu.org>
1844
6b02f655
SM
1845 * bidimirror.h:
1846 * biditype.h: Remove file.
1847 * makefile.w32-in ($(BLD)/bidi.$(O)):
1848 * deps.mk (bidi.o): Remove biditype.h and bidimirror.h.
474a8465
EZ
1849
1850 * dispextern.h: Fix a typo in the comment to bidi_type_t.
1851
1852 * chartab.c: Improve commentary for the uniprop_table API.
1853
32413314
EZ
1854 * bidi.c (bidi_paragraph_init): Support zero value of
1855 bidi_ignore_explicit_marks_for_paragraph_level.
474a8465
EZ
1856 (bidi_initialize): Use uniprop_table instead of including
1857 biditype.h and bidimirror.h.
32413314 1858
9fd8be00
EZ
1859 * xdisp.c (move_it_in_display_line_to): Don't reset pixel
1860 coordinates of the iterator when restoring from ppos_it.
1861 (Bug#9296)
1862
5cf2b69b
KH
18632011-08-14 Kenichi Handa <handa@m17n.org>
1864
1865 * process.c (create_process): Call setup_process_coding_systems
72ad093b 1866 after the pid of the process is set to -1 (Bug#8162).
5cf2b69b 1867
daf17d00
EZ
18682011-08-14 Eli Zaretskii <eliz@gnu.org>
1869
1870 * xdisp.c (move_it_in_display_line_to): Don't invoke
1871 IT_RESET_X_ASCENT_DESCENT when iterator position was restored from
1872 ppos_it. Fixes vertical cursor motion when line beginning is
1873 covered by an image. (Bug#9296)
1874
08e3161a
JD
18752011-08-14 Jan Djärv <jan.h.d@swipnet.se>
1876
1877 * nsterm.h (ns_run_ascript): Declare.
1878 (NSAPP_DATA2_RUNASSCRIPT): Define.
1879
1880 * nsfns.m (as_script, as_result, as_status): New static variables.
1881 (ns_run_ascript): New function.
5e617bc2 1882 (Fns_do_applescript): Set variables as_*. Make an NSApplicationDefined
08e3161a
JD
1883 event with data2 set to NSAPP_DATA2_RUNASSCRIPT, post it and then start
1884 the event loop. Get status from as_status (Bug#7276).
1885
1886 * nsterm.m (sendEvent): If event is NSApplicationDefined and
1887 data2 is NSAPP_DATA2_RUNASSCRIPT, call ns_run_ascript and then exit
1888 the event loop (Bug#7276).
1889
a3720aa2
AS
18902011-08-14 Andreas Schwab <schwab@linux-m68k.org>
1891
1892 * gnutls.c (QCgnutls_bootprop_priority)
1893 (QCgnutls_bootprop_trustfiles, QCgnutls_bootprop_keylist)
1894 (QCgnutls_bootprop_crlfiles, QCgnutls_bootprop_callbacks)
1895 (QCgnutls_bootprop_loglevel, QCgnutls_bootprop_hostname)
1896 (QCgnutls_bootprop_min_prime_bits, QCgnutls_bootprop_verify_flags)
1897 (QCgnutls_bootprop_verify_hostname_error)
1898 (QCgnutls_bootprop_callbacks_verify): Rename from
1899 Qgnutls_bootprop_..., all uses changed.
1900
1901 * xfaces.c (QCignore_defface): Rename from Qignore_defface, all
1902 uses changed.
1903
0a0d27fb
PE
19042011-08-14 Paul Eggert <eggert@cs.ucla.edu>
1905
19d5c50c
PE
1906 * xfaces.c (Qframe_set_background_mode): Now static.
1907 * dispextern.h (Qframe_set_background_mode): Remove decl.
1908
0a0d27fb
PE
1909 * process.c (Fnetwork_interface_info): Declare local only if needed.
1910
377538cb
JD
19112011-08-13 Jan Djärv <jan.h.d@swipnet.se>
1912
1913 * process.c: Include ifaddrs.h and net/if_dl.h if available (Bug#8477).
1914 (Fnetwork_interface_list): Allocate in increments of bytes instead
1915 of sizeof (struct ifreq). Iterate over ifconf.ifc_req by counting
1916 bytes (Bug#8477). Count bytes correctly when ifr_addr is a struct
1917 sockaddr.
1918 (struct ifflag_def): notrailers is smart on OSX.
1919 (Fnetwork_interface_info): Handle case when ifr_flags is negative.
1920 Get hardware address with getifaddrs if available.
1921
08fff70c
EZ
19222011-08-12 Eli Zaretskii <eliz@gnu.org>
1923
1924 * xdisp.c (iterate_out_of_display_property): xassert that
1925 IT->position is set to within IT->object's boundaries. Break from
1926 the loop as soon as EOB is reached; avoids infloops in redisplay
8b76d6f8
SM
1927 when IT->position is set up wrongly due to some bug.
1928 Set IT->current to match the bidi iterator unconditionally.
08fff70c
EZ
1929 (push_display_prop): Allow GET_FROM_STRING as IT->method on
1930 entry. Force push_it to save on the stack the current
1931 buffer/string position, to be restored by pop_it. Fix flags in
1932 the iterator structure wrt the object coming from a display
1933 property, as `line-prefix' and `wrap-prefix' are not ``replacing''
1934 properties. (Bug#9284)
1935
7be1c708 19362011-08-09 Andreas Schwab <schwab@linux-m68k.org>
aac0c6e3 1937
7be1c708
CY
1938 * fontset.c (fontset_get_font_group): Add proper type checks.
1939 (Bug#9172)
aac0c6e3 1940
7be1c708 19412011-08-09 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
aac0c6e3 1942
7be1c708
CY
1943 * unexmacosx.c (print_load_command_name): Add cases LC_FUNCTION_STARTS
1944 and LC_VERSION_MIN_MACOSX.
1945 (copy_linkedit_data) [LC_FUNCTION_STARTS]: New function.
1946 (dump_it) [LC_FUNCTION_STARTS]: Use it.
aac0c6e3 1947
97bb72a6
EZ
19482011-08-08 Eli Zaretskii <eliz@gnu.org>
1949
1950 * xdisp.c (forward_to_next_line_start): Allow to use the
8b76d6f8
SM
1951 no-display-properties-and-no-overlays under bidi display.
1952 Set disp_pos in the bidi iterator to avoid searches for display
757664a4 1953 properties and overlays.
97bb72a6 1954
d5617611
CY
19552011-08-08 Chong Yidong <cyd@stupidchicken.com>
1956
37e11a63
CY
1957 * editfns.c (Fset_time_zone_rule): Document relationship with the
1958 setenv function.
1959
d5617611
CY
1960 * ftfont.c (ftfont_pattern_entity): Copy the extras argument to
1961 the font entity extracted from the cache (Bug#8109).
1962
58872834
CY
19632011-08-07 Chong Yidong <cyd@stupidchicken.com>
1964
1965 * composite.c (autocmp_chars): Don't reset point. That is done by
1966 restore_point_unwind (Bug#5984).
1967
75bfc667
JL
19682011-08-07 Juri Linkov <juri@jurta.org>
1969
1970 * editfns.c (Fformat_time_string): Doc fix, add tag `usage:'
1971 to show the arg `TIME' instead of `TIMEVAL'.
1972
d1410150
EZ
19732011-08-06 Eli Zaretskii <eliz@gnu.org>
1974
1975 * xdisp.c (set_cursor_from_row): Fix cursor positioning when a
1976 display property strides EOL and includes a newline, as in
1977 longlines-mode. (Bug#9254)
75b771e4
EZ
1978 (move_it_in_display_line_to): Fix vertical-motion in a buffer with
1979 word-wrap under bidirectional display. (Bug#9224)
d1410150
EZ
1980
1981 * bidi.c (bidi_unshelve_cache): Don't reset the cache if JUST_FREE
1982 is non-zero, even if the data buffer is NULL. Fixes a crash in
1983 vertical-motion with longlines-mode. (Bug#9254)
1984
35928349
EZ
19852011-08-05 Eli Zaretskii <eliz@gnu.org>
1986
ec7cc85b
EZ
1987 * bidi.c <bidi_cache_total_alloc>: Now static.
1988 (bidi_initialize): Initialize bidi_cache_total_alloc.
1989
8b76d6f8 1990 * xdisp.c (display_line): Release buffer allocated for shelved bidi
35928349
EZ
1991 cache. (Bug#9221)
1992
1993 * bidi.c (bidi_shelve_cache, bidi_unshelve_cache): Track total
1994 amount allocated this far in `bidi_cache_total_alloc'.
1995 (bidi_unshelve_cache): Accept an additional argument JUST_FREE; if
1996 non-zero, only free the data buffer without restoring the cache
1997 contents. All callers changed.
1998
1999 * dispextern.h (bidi_unshelve_cache): Update prototype.
2000
2001 * xdisp.c (SAVE_IT, pos_visible_p, move_it_in_display_line_to)
2002 (move_it_in_display_line, move_it_to)
2003 (move_it_vertically_backward, move_it_by_lines): Replace the call
2004 to xfree to an equivalent call to bidi_unshelve_cache.
2005 (move_it_in_display_line_to): Fix logic of returning
412b6358 2006 MOVE_POS_MATCH_OR_ZV in the bidi case. (Bug#9224)
35928349 2007
e2e2423b
EZ
20082011-08-05 Eli Zaretskii <eliz@gnu.org>
2009
2010 * xdisp.c (set_cursor_from_row): Prefer the candidate glyph that
2011 came from a string character with a `cursor' property. (Bug#9229)
2012
ae9e757a
JD
20132011-08-04 Jan Djärv <jan.h.d@swipnet.se>
2014
2015 * Makefile.in (LIB_PTHREAD): New variable.
2016 (LIBES): Add LIB_PTHREAD (Bug#9216).
2017
2018 * alloc.c, emacs.c, gmalloc.c, gtkutil.c, keyboard.c, syssignal.h:
2019 Rename HAVE_GTK_AND_PTHREAD to HAVE_PTHREAD (Bug#9216).
2020
213bd7f2
AS
20212011-08-04 Andreas Schwab <schwab@linux-m68k.org>
2022
6b02f655 2023 * regex.c (re_iswctype): Remove some redundant boolean conversions.
213bd7f2 2024
99aaf75f
JD
20252011-08-04 Jan Djärv <jan.h.d@swipnet.se>
2026
2027 * xterm.c (x_find_topmost_parent): New function.
2028 (x_set_frame_alpha): Find topmost parent window with
2029 x_find_topmost_parent and set the property there also (bug#9181).
2030 (handle_one_xevent): Call x_set_frame_alpha on ReparentNotify.
2031
c74e9d86
PE
20322011-08-04 Paul Eggert <eggert@cs.ucla.edu>
2033
2034 * callproc.c (Fcall_process): Avoid vfork clobbering
2035 the local vars buffer, coding_systems, current_dir.
2036
640c8776
SM
20372011-08-03 Stefan Monnier <monnier@iro.umontreal.ca>
2038
2039 * keymap.c (Fmake_composed_keymap): Move to subr.el.
2040
f26d0e4c
PE
20412011-08-03 Paul Eggert <eggert@cs.ucla.edu>
2042
8a10d76c
PE
2043 * fontset.c (dump_fontset) [FONTSET_DEBUG]: Declare EXTERNALLY_VISIBLE
2044 so that it is not optimized away.
2045
f26d0e4c
PE
2046 * xdisp.c (compute_display_string_pos): Remove unused local.
2047
55439c61
EZ
20482011-08-02 Eli Zaretskii <eliz@gnu.org>
2049
2050 Fix slow cursor motion and scrolling in large buffers with
2051 selective display, like Org Mode buffers. (Bug#9218)
2052
2053 * dispextern.h (struct bidi_it): New member disp_prop_p.
2054
2055 * xdisp.c: Remove one-slot cache of display string positions.
2056 (compute_display_string_pos): Accept an additional argument
5e617bc2 2057 DISP_PROP_P; callers changed. Scan at most 5K characters forward
55439c61
EZ
2058 for a display string or property. If found, set DISP_PROP_P
2059 non-zero.
2060
2061 * bidi.c (bidi_fetch_char): Accept an additional argument
640c8776
SM
2062 DISP_PROP_P, and pass it to compute_display_string_pos.
2063 Only handle text covered by a display string if DISP_PROP_P is returned
55439c61
EZ
2064 non-zero. All callers of bidi_fetch_char changed.
2065
fb33fa43
SM
20662011-08-02 Stefan Monnier <monnier@iro.umontreal.ca>
2067
2068 * keymap.c (Fdefine_key): Fix Lisp_Object/int mixup; apply some CSE.
2069
b099e063
DM
20702010-12-03 Don March <don@ohspite.net>
2071
2072 * keymap.c (Fdefine_key): Fix non-prefix key error message when
2073 last character M-[char] is translated to ESC [char] (bug#7541).
2074
5cc7f7af
KH
20752011-08-02 Kenichi Handa <handa@m17n.org>
2076
d0fffa3f 2077 * lisp.h (uniprop_table): Extern it.
5cc7f7af
KH
2078
2079 * chartab.c (uniprop_table): Make it non-static.
2080
525d5e6e
EZ
20812011-08-01 Eli Zaretskii <eliz@gnu.org>
2082
2083 * xdisp.c (forward_to_next_line_start): Accept additional argument
2084 BIDI_IT_PREV, and store into it the state of the bidi iterator had
2085 on the newline.
2086 (reseat_at_next_visible_line_start): Use the bidi iterator state
2087 returned by forward_to_next_line_start to restore the state of
2088 it->bidi_it after backing up to previous newline. (Bug#9212)
2089
31011111
AS
20902011-07-30 Andreas Schwab <schwab@linux-m68k.org>
2091
2092 * regex.c (re_comp): Protoize.
2093 (re_exec): Fix return type.
2094 (regexec): Fix type of `ret'. (Bug#9203)
2095
476371c4
PE
20962011-07-28 Paul Eggert <eggert@cs.ucla.edu>
2097
e5d76069
PE
2098 * image.c (check_image_size): Use 1024x1024 if unknown frame (Bug#9189).
2099 This is needed if max-image-size is a floating-point number.
2100
9a79b20c
AS
21012011-07-28 Andreas Schwab <schwab@linux-m68k.org>
2102
2103 * print.c (print_object): Print empty symbol as ##.
2104
2105 * lread.c (read1): Read ## as empty symbol.
2106
d8c2fa78
AA
21072011-07-28 Alp Aker <alp.tekin.aker@gmail.com>
2108
2109 * nsfns.m (x_set_foreground_color): Set f->foreground_pixel when
2110 setting frame foreground color (Bug#9175).
2111 (x_set_background_color): Likewise.
2112
ffe57a7a
AA
2113 * nsmenu.m (-setText): Size tooltip dimensions precisely to
2114 contents (Bug#9176).
2115 (EmacsTooltip -init): Remove bezels and add shadows to
2116 tooltip windows.
2117
bf3492a5
AA
2118 * nsterm.m (ns_dumpglyphs_stretch): Avoid overwriting left fringe
2119 or scroll bar (Bug#8470).
2120
d55e9c53
AA
2121 * nsfont.m (nsfont_open): Remove assignment to voffset and
2122 unnecessary vars hshink, expand, hd, full_height, min_height.
2123 (nsfont_draw): Use s->ybase as baseline for glyph drawing (Bug#8913).
2124
2125 * nsterm.h (nsfont_info): Remove voffset field.
2126
d8c2fa78 21272011-07-28 Alp Aker <alp.tekin.aker@gmail.com>
4843aac3
AA
2128
2129 Implement strike-through and overline on NextStep (Bug#8863).
2130
2131 * nsfont.m (nsfont_open): Use underline position provided by font,
2132 instead of hard-coded value of 2.
2133 (nsfont_draw): Call ns_draw_text_decoration instead.
2134
2135 * nsterm.h: Add declaration for ns_draw_text_decoration.
2136
2137 * nsterm.m (ns_draw_text_decoration): New function for drawing
2138 underline, overline, and strike-through.
2139 (ns_dumpglyphs_image, ns_dumpglyphs_stretch): Add call to
2140 ns_draw_text_decoration. Change treatment of cursor drawing to
8d5ed899 2141 accommodate underlining, etc.
4843aac3 2142
4cc60b9b
EZ
21432011-07-28 Eli Zaretskii <eliz@gnu.org>
2144
bc7ece87
EZ
2145 * buffer.c (init_buffer_once): Set bidi-display-reordering to t by
2146 default.
4cc60b9b 2147
476371c4
PE
21482011-07-28 Paul Eggert <eggert@cs.ucla.edu>
2149
66606eea
PE
2150 * alloc.c (memory_full) [!SYNC_INPUT]: Fix signal-related race.
2151 Without this fix, if a signal arrives just after memory fills up,
2152 'malloc' might be invoked reentrantly.
2153
476371c4
PE
2154 * image.c (x_check_image_size) [!HAVE_X_WINDOWS]: Return 1.
2155 In other words, assume that every image size is allowed, on non-X
2156 hosts. This assumption is probably wrong, but it lets Emacs compile.
2157
f3fcc40d
AS
21582011-07-28 Andreas Schwab <schwab@linux-m68k.org>
2159
2160 * regex.c (re_iswctype): Convert return values to boolean.
2161
350c992f
EZ
21622011-07-28 Eli Zaretskii <eliz@fencepost.gnu.org>
2163
2164 * xdisp.c (compute_display_string_pos): Don't use cached display
2165 string position if the buffer had its restriction changed.
2166 (Bug#9184)
2167
5266b4bb
PE
21682011-07-28 Paul Eggert <eggert@cs.ucla.edu>
2169
2170 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork clobbering.
2171
2573a837 21722011-07-28 Paul Eggert <eggert@cs.ucla.edu>
ca4aa935 2173
41f55ccd 2174 Integer signedness and overflow and related fixes. (Bug#9079)
cf950e6b 2175
39e378da
PE
2176 * bidi.c: Integer size and overflow fixes.
2177 (bidi_cache_size, bidi_cache_idx, bidi_cache_last_idx)
2178 (bidi_cache_start, bidi_cache_fetch_state, bidi_cache_search)
2179 (bidi_cache_find_level_change, bidi_cache_ensure_space)
2180 (bidi_cache_iterator_state, bidi_cache_find, bidi_cache_start_stack)
2181 (bidi_find_other_level_edge):
2182 Use ptrdiff_t instead of EMACS_INT where either will do.
2183 This works better on 32-bit hosts configured --with-wide-int.
2184 (bidi_cache_ensure_space): Check for size-calculation overflow.
2185 Use % rather than repeated addition, for better worst-case speed.
2186 Don't set bidi_cache_size until after xrealloc returns, because it
2187 might not return.
2188 (bidi_dump_cached_states): Use ptrdiff_t, not int, to avoid overflow.
f0eb61e9
PE
2189 (bidi_cache_ensure_space): Also check that the bidi cache size
2190 does not exceed that of the largest Lisp string or buffer. See Eli
2191 Zaretskii in <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=9079#29>.
39e378da 2192
5e927815
PE
2193 * alloc.c (__malloc_size_t): Remove.
2194 All uses replaced by size_t. See Andreas Schwab's note
2195 <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=9079#8>.
2196
ca4aa935
PE
2197 * image.c: Improve checking for integer overflow.
2198 (check_image_size): Assume that f is nonnull, since
2199 it is always nonnull in practice. This is one less thing to
2200 worry about when checking for integer overflow later.
2201 (x_check_image_size): New function, which checks for integer
2202 overflow issues inside X.
2203 (x_create_x_image_and_pixmap, xbm_read_bitmap_data): Use it.
2204 This removes the need for a memory_full check.
2205 (xbm_image_p): Rewrite to avoid integer multiplication overflow.
2206 (Create_Pixmap_From_Bitmap_Data, xbm_load): Use x_check_image_size.
2207 (xbm_read_bitmap_data): Change locals back to 'int', since
2208 their values must fit in 'int'.
2209 (xpm_load_image, png_load, tiff_load):
2210 Invoke x_create_x_image_and_pixmap earlier,
2211 to avoid much needless work if the image is too large.
2212 (tiff_load): Treat overly large images as if
2213 x_create_x_image_and_pixmap failed, not as malloc failures.
2214 (gs_load): Use x_check_image_size.
2215
5f8f9cc2
PE
2216 * gtkutil.c: Omit integer casts.
2217 (xg_get_pixbuf_from_pixmap): Remove unnecessary cast.
2218 (xg_set_toolkit_scroll_bar_thumb): Rewrite to avoid need for cast.
2219
5adf60bc
PE
2220 * image.c (png_load): Don't assume height * row_bytes fits in 'int'.
2221
c8907a93
PE
2222 * xfaces.c (Fbitmap_spec_p): Fix integer overflow bug.
2223 Without this fix, (bitmap-spec-p '(34359738368 1 "x"))
2224 would wrongly return t on a 64-bit host.
2225
e3c25c68
PE
2226 * dispnew.c (init_display): Use *_RANGE_OVERFLOW macros.
2227 The plain *_OVERFLOW macros run afoul of GCC bug 49705
2228 <http://gcc.gnu.org/bugzilla/show_bug.cgi?id=49705>
2229 and therefore cause GCC to emit a bogus diagnostic in some cases.
2230
3f791afe
PE
2231 * image.c: Integer signedness and overflow and related fixes.
2232 This is not an exhaustive set of fixes, but it's time to
2233 record what I've got.
2234 (lookup_pixel_color, check_image_size): Remove redundant decls.
2235 (check_image_size): Don't assume that arbitrary EMACS_INT values
2236 fit in 'int', or that arbitrary 'double' values fit in 'int'.
2237 (x_alloc_image_color, x_create_x_image_and_pixmap, png_load)
2238 (tiff_load, imagemagick_load_image):
2239 Check for overflow in size calculations.
2240 (x_create_x_image_and_pixmap): Remove unnecessary test for
2241 xmalloc returning NULL; that can't happen.
2242 (xbm_read_bitmap_data): Don't assume sizes fit into 'int'.
2243 (xpm_color_bucket): Use better integer hashing function.
2244 (xpm_cache_color): Don't possibly over-allocate memory.
2245 (struct png_memory_storage, tiff_memory_source, tiff_seek_in_memory)
2246 (gif_memory_source):
2247 Use ptrdiff_t, not int or size_t, to record sizes.
2248 (png_load): Don't assume values greater than 2**31 fit in 'int'.
2249 (our_stdio_fill_input_buffer): Prefer ptrdiff_t to size_t when
2250 either works, as we prefer signed integers.
2251 (tiff_read_from_memory, tiff_write_from_memory):
2252 Return tsize_t, not size_t, since that's what the TIFF API wants.
2253 (tiff_read_from_memory): Don't fail simply because the read would
2254 go past EOF; instead, return a short read.
2255 (tiff_load): Omit no-longer-needed casts.
2256 (Fimagemagick_types): Don't assume size fits into 'int'.
2257
3cc5a532
PE
2258 Improve hashing quality when configured --with-wide-int.
2259 * fns.c (hash_string): New function, taken from sxhash_string.
2260 Do not discard information about ASCII character case; this
2261 discarding is no longer needed.
2262 (sxhash-string): Use it. Change sig to match it. Caller changed.
2263 * lisp.h: Declare it.
2264 * lread.c (hash_string): Remove, since we now use fns.c's version.
2265 The fns.c version returns a wider integer if --with-wide-int is
2266 specified, so this should help the quality of the hashing a bit.
2267
b312a492
PE
2268 * emacs.c: Integer overflow minor fix.
2269 (heap_bss_diff): Now uprintmax_t, not unsigned long. All used changed.
2270 Define only if GNU_LINUX.
2271 (main, Fdump_emacs): Set and use heap_bss_diff only if GNU_LINUX.
2272
dfd153ae
PE
2273 * dispnew.c: Integer signedness and overflow fixes.
2274 Remove unnecessary forward decls, that were a maintenance hassle.
2275 (history_tick): Now uprintmax_t, so it's more likely to avoid overflow.
2276 All uses changed.
2277 (adjust_glyph_matrix, realloc_glyph_pool, adjust_frame_message_buffer)
2278 (scrolling_window): Use ptrdiff_t, not int, for byte count.
2279 (prepare_desired_row, line_draw_cost):
2280 Use int, not unsigned, where either works.
2281 (save_current_matrix, restore_current_matrix):
2282 Use ptrdiff_t, not size_t, where either works.
2283 (init_display): Check for overflow more accurately, and without
2284 relying on undefined behavior.
2285
a81d11a3
PE
2286 * editfns.c (pWIDE, pWIDElen, signed_wide, unsigned_wide):
2287 Remove, replacing with the new symbols in lisp.h. All uses changed.
2288 * fileio.c (make_temp_name):
2289 * filelock.c (lock_file_1, lock_file):
2290 * xdisp.c (message_dolog):
2291 Don't assume PRIdMAX etc. works; this isn't portable to pre-C99 hosts.
2292 Use pMd etc. instead.
2293 * lisp.h (printmax_t, uprintmax_t, pMd, pMu): New types and macros,
2294 replacing the pWIDE etc. symbols removed from editfns.c.
2295
3300e6fd
PE
2296 * keyboard.h (num_input_events): Now uintmax_t.
2297 This is (very slightly) less likely to mess up due to wraparound.
2298 All uses changed.
2299
fd05c7e9
PE
2300 * buffer.c: Integer signedness fixes.
2301 (alloc_buffer_text, enlarge_buffer_text):
2302 Use ptrdiff_t rather than size_t when either will do, as we prefer
2303 signed integers.
2304
903fe15d
PE
2305 * alloc.c: Integer signedness and overflow fixes.
2306 Do not impose an arbitrary 32-bit limit on malloc sizes when debugging.
2307 (__malloc_size_t): Default to size_t, not to int.
2308 (pure_size, pure_bytes_used_before_overflow, stack_copy_size)
2309 (Fgarbage_collect, mark_object_loop_halt, mark_object):
2310 Prefer ptrdiff_t to size_t when either would do, as we prefer
2311 signed integers.
2312 (XMALLOC_OVERRUN_CHECK_OVERHEAD): New macro.
2313 (xmalloc_overrun_check_header, xmalloc_overrun_check_trailer):
2314 Now const. Initialize with values that are in range even if char
2315 is signed.
2316 (XMALLOC_PUT_SIZE, XMALLOC_GET_SIZE): Remove, replacing with ...
2317 (xmalloc_put_size, xmalloc_get_size): New functions. All uses changed.
2318 These functions do the right thing with sizes > 2**32.
2319 (check_depth): Now ptrdiff_t, not int.
2320 (overrun_check_malloc, overrun_check_realloc, overrun_check_free):
2321 Adjust to new way of storing sizes. Check for size overflow bugs
2322 in rest of code.
2323 (STRING_BYTES_MAX): Adjust to new overheads. The old code was
2324 slightly wrong anyway, as it missed one instance of
2325 XMALLOC_OVERRUN_CHECK_OVERHEAD.
2326 (refill_memory_reserve): Omit needless cast to size_t.
2327 (mark_object_loop_halt): Mark as externally visible.
2328
ac82cc6a
PE
2329 * xselect.c: Integer signedness and overflow fixes.
2330 (Fx_register_dnd_atom, x_handle_dnd_message):
2331 Use ptrdiff_t, not size_t, since we prefer signed.
2332 (Fx_register_dnd_atom): Check for ptrdiff_t (and size_t) overflow.
2333 * xterm.h (struct x_display_info): Use ptrdiff_t, not size_t, for
2334 x_dnd_atoms_size and x_dnd_atoms_length.
2335
c2d1e36d
PE
2336 * doprnt.c: Prefer signed to unsigned when either works.
2337 * eval.c (verror):
2338 * doprnt.c (doprnt):
2339 * lisp.h (doprnt):
2340 * xdisp.c (vmessage):
2341 Use ptrdiff_t, not size_t, when using or implementing doprnt,
2342 since the sizes cannot exceed ptrdiff_t bounds anyway, and we
2343 prefer signed arithmetic to avoid comparison confusion.
2344 * doprnt.c (doprnt): Avoid a "+ 1" that can't overflow,
2345 but is a bit tricky.
2346
0e926e56
PE
2347 Assume freestanding C89 headers, string.h, stdlib.h.
2348 * data.c, doprnt.c, floatfns.c, print.c:
2349 Include float.h unconditionally.
2350 * gmalloc.c: Assume C89-at-least behavior for preprocessor,
2351 limits.h, stddef.h, string.h. Use memset instead of 'flood'.
2352 * regex.c: Likewise for stddef.h, string.h.
2353 (ISASCII): Remove; can assume it returns 1 now. All uses removed.
2354 * s/aix4-2.h (HAVE_STRING_H): Remove obsolete undef.
2355 * s/ms-w32.h (HAVE_LIMITS_H, HAVE_STRING_H, HAVE_STDLIB_H)
2356 (STDC_HEADERS): Remove obsolete defines.
2357 * sysdep.c: Include limits.h unconditionally.
2358
9cfdb3ec
PE
2359 Assume support for memcmp, memcpy, memmove, memset.
2360 * lisp.h, sysdep.c (memcmp, memcpy, memmove, memset):
2361 * regex.c (memcmp, memcpy):
2362 Remove; we assume C89 now.
2363
2364 * gmalloc.c (memcpy, memset, memmove): Remove; we assume C89 now.
2365 (__malloc_safe_bcopy): Remove; no longer needed.
2366
cf950e6b 2367 * lisp.h (struct vectorlike_header, struct Lisp_Subr): Signed sizes.
6089c567
PE
2368 Use EMACS_INT, not EMACS_UINT, for sizes. The code works equally
2369 well either way, and we prefer signed to unsigned.
2370
dbf38e02
LMI
23712011-07-27 Lars Magne Ingebrigtsen <larsi@gnus.org>
2372
2373 * gnutls.c (emacs_gnutls_read): Don't message anything if the peer
2374 closes the connection while we're reading (bug#9182).
2375
d6f0886c 23762011-07-25 Jan Djärv <jan.h.d@swipnet.se>
24e0f6b1 2377
d6f0886c
JD
2378 * nsmenu.m (ns_popup_dialog): Add an "ok" button if no buttons
2379 are specified (Bug#9168).
24e0f6b1 2380
2eb1f9e6
PE
23812011-07-25 Paul Eggert <eggert@cs.ucla.edu>
2382
2383 * bidi.c (bidi_dump_cached_states): Fix printf format mismatch.
2384 Found by GCC static checking and --with-wide-int on a 32-bit host.
2385
22381272 23862011-07-25 Eli Zaretskii <eliz@gnu.org>
7daee910
EZ
2387
2388 * xdisp.c (compute_display_string_pos): Fix logic of caching
2389 previous display string position. Initialize cached_prev_pos to
2390 -1. Fixes slow-down at the beginning of a buffer.
2391
f25e39b4
EZ
23922011-07-24 Eli Zaretskii <eliz@gnu.org>
2393
2394 * xfaces.c (check_lface_attrs) [HAVE_WINDOW_SYSTEM]: Allow `nil'
2395 for attrs[LFACE_FONTSET_INDEX].
2396
04c4b52e
PE
23972011-07-23 Paul Eggert <eggert@cs.ucla.edu>
2398
2399 * xml.c (parse_region): Remove unused local
2400 that was recently introduced.
2401
c1734fbd
EZ
24022011-07-23 Eli Zaretskii <eliz@gnu.org>
2403
be18c5a5
EZ
2404 * xfns.c (unwind_create_frame) [GLYPH_DEBUG]: Adapt to changes in
2405 2008-02-22T17:42:09Z!monnier@iro.umontreal.ca.
2406
c1734fbd
EZ
2407 * xdisp.c (move_it_in_display_line_to): Record the best matching
2408 position for TO_CHARPOS while scanning the line, and restore it on
640c8776
SM
2409 exit if none of the characters scanned was an exact match.
2410 Fixes vertical-motion and pos-visible-in-window-p under bidi redisplay
a9269c18
EZ
2411 when exact match is impossible due to invisible text, and the
2412 lines are truncated.
2413
a258d627
JD
24142011-07-23 Jan Djärv <jan.h.d@swipnet.se>
2415
2416 * nsterm.m (initFrameFromEmacs): Set NSTitledWindowMask in styleMask
2417 for OSX >= 10.7.
2418
b6d5a689
EZ
24192011-07-22 Eli Zaretskii <eliz@gnu.org>
2420
0f74f785
EZ
2421 Fix a significant slow-down of cursor motion with C-n, C-p,
2422 C-f/C-b, and C-v/M-v that couldn't keep up with keyboard
2423 auto-repeat under bidi redisplay in fontified buffers.
b6d5a689 2424 * xdisp.c (compute_stop_pos_backwards): New function.
b6d5a689
EZ
2425 (next_element_from_buffer): Call compute_stop_pos_backwards to
2426 find a suitable prev_stop when we find ourselves before
0f74f785
EZ
2427 base_level_stop.
2428 (reseat): Don't look for prev_stop, as that could mean a very long
2429 run.
2430 <cached_disp_pos, cached_disp_buffer, cached_disp_modiff>
2431 <cached_disp_overlay_modiff>: Cache for last found display string
2432 position.
551918c1 2433 (compute_display_string_pos): Return the cached position if asked
0f74f785
EZ
2434 about the same buffer in the same area of character positions, and
2435 the buffer wasn't changed since the time the display string
2436 position was cached.
551918c1 2437
b2d0c91a
EZ
24382011-07-22 Eli Zaretskii <eliz@gnu.org>
2439
2440 * xdisp.c (rows_from_pos_range): Don't ignore glyphs whose object
2441 is an integer, which is important for empty lines. (Bug#9149)
2442
043604ee
CY
24432011-07-22 Chong Yidong <cyd@stupidchicken.com>
2444
2445 * frame.c (Fmodify_frame_parameters): In tty case, update the
2446 default face if necessary (Bug#4238).
2447
da4adb04
CY
24482011-07-21 Chong Yidong <cyd@stupidchicken.com>
2449
2450 * editfns.c (Fstring_to_char): No need to explain what a character
2451 is in the docstring (Bug#6576).
2452
9abd0532
LMI
24532011-07-20 Lars Magne Ingebrigtsen <larsi@gnus.org>
2454
2455 * xml.c (parse_region): Make sure we always return a tree.
2456
36881d16
HK
24572011-07-20 HAMANO Kiyoto <khiker.mail@gmail.com>
2458
2459 * xml.c (parse_region): If a document contains only comments,
2460 return that, too.
2461
1e98674d
LMI
24622011-07-20 Lars Magne Ingebrigtsen <larsi@gnus.org>
2463
2464 * xml.c (make_dom): Return comments, too.
2465
590bd467
PE
24662011-07-19 Paul Eggert <eggert@cs.ucla.edu>
2467
2468 Port to OpenBSD.
2469 See http://lists.gnu.org/archive/html/emacs-devel/2011-07/msg00688.html
2470 and the surrounding thread.
2471 * minibuf.c (read_minibuf_noninteractive): Rewrite to use getchar
2472 rather than fgets, and retry after EINTR. Otherwise, 'emacs
2473 --batch -f byte-compile-file' fails on OpenBSD if an inactivity
2474 timer goes off.
2475 * s/openbsd.h (BROKEN_SIGIO): Define.
2476 * unexelf.c (unexec) [__OpenBSD__]:
2477 Don't update the .mdebug section of the Alpha COFF symbol table.
2478
f41628b2
LMI
24792011-07-19 Lars Magne Ingebrigtsen <larsi@gnus.org>
2480
2481 * lread.c (syms_of_lread): Clarify when `lexical-binding' is used
2482 (bug#8460).
2483
b59b67c5
PE
24842011-07-18 Paul Eggert <eggert@cs.ucla.edu>
2485
15e3a074
PE
2486 * fileio.c (Fcopy_file) [!MSDOS]: Tighten created file's mask.
2487 This fixes some race conditions on the permissions of any newly
2488 created file.
2489
41bed37d
PE
2490 * alloc.c (valid_pointer_p): Use pipe, not open.
2491 This fixes some permissions issues when debugging.
2492
b59b67c5
PE
2493 * fileio.c (Fcopy_file): Adjust mode if fchown fails. (Bug#9002)
2494 If fchown fails to set both uid and gid, try to set just gid,
2495 as that is sometimes allowed. Adjust the file's mode to eliminate
2496 setuid or setgid bits that are inappropriate if fchown fails.
2497
925a6be7
SM
24982011-07-18 Stefan Monnier <monnier@iro.umontreal.ca>
2499
2500 * xdisp.c (next_element_from_string, next_element_from_buffer): Use EQ
2501 to compare Lisp_Objects.
2502 * gnutls.c (syms_of_gnutls): Rename Vgnutls_log_level to
2503 global_gnutls_log_level, don't mistake it for a Lisp_Object.
2504 (init_gnutls_functions, emacs_gnutls_handle_error): Fix up uses.
2505
52968808
AS
25062011-07-17 Andreas Schwab <schwab@linux-m68k.org>
2507
0a6a104b
AS
2508 * lread.c (read_integer): Unread even EOF character.
2509 (read1): Likewise. Properly record start position of symbol.
2510
52968808
AS
2511 * lread.c (read1): Read `#:' as empty uninterned symbol if no
2512 symbol character follows.
2513
9e381cdd
PE
25142011-07-17 Paul Eggert <eggert@cs.ucla.edu>
2515
2516 * fileio.c (Fcopy_file): Pacify gcc re fchown. (Bug#9002)
2517 This works around a problem with the previous change to Fcopy_file.
2518 Recent glibc declares fchown with __attribute__((warn_unused_result)),
2519 and without this change, GCC might complain about discarding
2520 fchown's return value.
2521
b5641435
JB
25222011-07-16 Juanma Barranquero <lekktu@gmail.com>
2523
2524 * makefile.w32-in (GLOBAL_SOURCES): Add gnutls.c (followup to bug#9059).
2525
a8031457
PE
25262011-07-16 Paul Eggert <eggert@cs.ucla.edu>
2527
2528 * fileio.c (Fcopy_file): Don't diagnose fchown failures. (Bug#9002)
2529
dd889327
LMI
25302011-07-16 Lars Magne Ingebrigtsen <larsi@gnus.org>
2531
750c33f7
LMI
2532 * gnutls.c (syms_of_gnutls): Define `gnutls-log-level' here, since
2533 it's used from the C level.
2534
dd889327
LMI
2535 * process.c: Use the same condition for POLL_FOR_INPUT in both
2536 keyboard.c and process.c (bug#1858).
2537
87e86684
LM
25382011-07-09 Lawrence Mitchell <wence@gmx.li>
2539
2540 * gnutls.c (Qgnutls_bootprop_min_prime_bits): New variable.
2541 (Fgnutls_boot): Use it.
2542
64348f40
AS
25432011-07-15 Andreas Schwab <schwab@linux-m68k.org>
2544
2545 * doc.c (Fsubstitute_command_keys): Revert last change.
2546
1d698799
LMI
25472011-07-15 Lars Magne Ingebrigtsen <larsi@gnus.org>
2548
f863868c
LMI
2549 * doc.c (Fsubstitute_command_keys): Clarify that \= really only
2550 quotes the next character, and doesn't affect other longer
2551 sequences (bug#8935).
2552
1d698799
LMI
2553 * lread.c (syms_of_lread): Clarify that is isn't only
2554 `eval-buffer' and `eval-defun' that's affected by
2555 `lexical-binding' (bug#8460).
2556
aa4b6df6
EZ
25572011-07-15 Eli Zaretskii <eliz@gnu.org>
2558
2559 * xdisp.c (move_it_in_display_line_to): Fix vertical motion with
6b02f655 2560 bidi redisplay when a line includes both an image and is truncated.
aa4b6df6 2561
5d856da6
PE
25622011-07-14 Paul Eggert <eggert@cs.ucla.edu>
2563
ad6042bb
PE
2564 Fix minor problems found by static checking.
2565 * bidi.c (bidi_cache_size): Now EMACS_INT, not size_t.
2566 (elsz): Now a signed constant, not a size_t var. We prefer signed
2567 types to unsigned, to avoid integer comparison confusion. Without
2568 this change, GCC 4.6.1 with -Wunsafe-loop-optimizations complains
2569 "cannot optimize loop, the loop counter may overflow", a symptom
2570 of the confusion.
f00bbb22 2571 * indent.c (Fvertical_motion): Mark locals as initialized.
5d856da6
PE
2572 * xdisp.c (reseat_to_string): Fix pointer signedness issue.
2573
6468f31c
LMI
25742011-07-14 Lars Magne Ingebrigtsen <larsi@gnus.org>
2575
49080b10
LMI
2576 * search.c (Fre_search_backward): Mention `case-fold-search' in
2577 all the re_search_* functions (bug#8138).
2578
6468f31c
LMI
2579 * keyboard.c (Fopen_dribble_file): Document when the file is
2580 closed (bug#8056).
2581
c965adc5
EZ
25822011-07-14 Eli Zaretskii <eliz@gnu.org>
2583
df9733bf
EZ
2584 * bidi.c (bidi_dump_cached_states): Fix format of displaying
2585 bidi_cache_idx.
2586
0bb23927
EZ
2587 Support bidi reordering of display and overlay strings.
2588 * xdisp.c (compute_display_string_pos)
2589 (compute_display_string_end): Accept additional argument STRING.
2590 (init_iterator, reseat_1): Initialize bidi_it->string.s to NULL.
2591 (reseat_to_string): Initialize bidi_it->string.s and
2592 bidi_it->string.schars.
2593 (Fcurrent_bidi_paragraph_direction): Initialize itb.string.s to
640c8776
SM
2594 NULL (avoids a crash in bidi_paragraph_init).
2595 Initialize itb.string.lstring.
0bb23927
EZ
2596 (init_iterator): Call bidi_init_it only of a valid
2597 buffer position was specified. Initialize paragraph_embedding to
2598 L2R.
2599 (reseat_to_string): Initialize the bidi iterator.
2600 (display_string): If we need to ignore text properties of
2601 LISP_STRING, set IT->stop_charpos to IT->end_charpos. (The
2602 original value of -1 will not work with bidi.)
2603 (compute_display_string_pos): First arg is now struct
2604 `text_pos *'; all callers changed. Support display properties on
2605 Lisp strings.
2606 (compute_display_string_end): Support display properties on Lisp
2607 strings.
2608 (init_iterator, reseat_1, reseat_to_string): Initialize the
2609 string.bufpos member to 0 (zero, for compatibility with IT_CHARPOS
2610 when iterating on a string not from display properties).
640c8776
SM
2611 (compute_display_string_pos, compute_display_string_end):
2612 Fix calculation of the object to scan. Fixes an error when using
0bb23927
EZ
2613 arrow keys.
2614 (next_element_from_buffer): Don't abort when IT_CHARPOS is before
640c8776
SM
2615 base_level_stop; instead, set base_level_stop to BEGV.
2616 Fixes crashes in vertical-motion.
0bb23927
EZ
2617 (next_element_from_buffer): Improve commentary for when
2618 the iterator is before prev_stop.
2619 (init_iterator): Initialize bidi_p from the default value of
2620 bidi-display-reordering, not from buffer-local value. Use the
2621 buffer-local value only if initializing for buffer iteration.
2622 (handle_invisible_prop): Support invisible properties on strings
2623 that are being bidi-reordered.
2624 (set_iterator_to_next): Support bidi reordering of C strings and
2625 Lisp strings.
2626 (next_element_from_string): Support bidi reordering of Lisp
2627 strings.
2628 (handle_stop_backwards): Support Lisp strings as well.
640c8776
SM
2629 (display_string): Support display of R2L glyph rows.
2630 Use IT_STRING_CHARPOS when displaying from a Lisp string.
0bb23927
EZ
2631 (init_iterator): Don't initialize it->bidi_p for strings
2632 here.
2633 (reseat_to_string): Initialize it->bidi_p for strings here.
2634 (next_element_from_string, next_element_from_c_string)
2635 (next_element_from_buffer): Add xassert's for correspondence
2636 between IT's object being iterated and it->bidi_it.string
2637 structure.
2638 (face_before_or_after_it_pos): Support bidi iteration.
2639 (next_element_from_c_string): Handle the case of the first string
2640 character that is not the first one in the visual order.
2641 (get_visually_first_element): New function, refactored from common
2642 parts of next_element_from_buffer, next_element_from_string, and
2643 next_element_from_c_string.
2644 (tool_bar_lines_needed, redisplay_tool_bar)
2645 (display_menu_bar): Force left-to-right direction. Add a FIXME
2646 comment for making that be controlled by a user option.
2647 (push_it, pop_it): Save and restore the state of the
2648 bidi iterator. Save and restore the bidi_p flag.
2649 (pop_it): Iterate out of display property for string iteration as
2650 well.
2651 (iterate_out_of_display_property): Support iteration over strings.
2652 (handle_single_display_spec): Set up it->bidi_it for iteration
2653 over a display string, and call bidi_init_it.
2654 (handle_single_display_spec, next_overlay_string)
2655 (get_overlay_strings_1, push_display_prop): Set up the bidi
2656 iterator for displaying display or overlay strings.
2657 (forward_to_next_line_start): Don't use the shortcut if
2658 bidi-iterating.
2659 (back_to_previous_visible_line_start): If handle_display_prop
2660 pushed the iterator stack, restore the internal state of the bidi
2661 iterator by calling bidi_pop_it same number of times.
2662 (reseat_at_next_visible_line_start): If ON_NEWLINE_P is non-zero,
2663 and we are bidi-iterating, don't decrement the iterator position;
2664 instead, set the first_elt flag in the bidi iterator, to produce
2665 the same effect.
2666 (reseat_1): Remove redundant setting of string_from_display_prop_p.
2667 (push_display_prop): xassert that we are iterating a buffer.
2668 (push_it, pop_it): Save and restore paragraph_embedding member.
2669 (handle_single_display_spec, next_overlay_string)
2670 (get_overlay_strings_1, reseat_1, reseat_to_string)
2671 (push_display_prop): Set up the `unibyte' member of bidi_it.string
2672 correctly. Don't assume unibyte strings are not bidi-reordered.
2673 (compute_display_string_pos)
2674 (compute_display_string_end): Fix handling the case of C string.
2675 (push_it, pop_it): Save and restore from_disp_prop_p.
2676 (handle_single_display_spec, push_display_prop): Set the
2677 from_disp_prop_p flag.
2678 (get_overlay_strings_1): Reset the from_disp_prop_p flag.
2679 (pop_it): Call iterate_out_of_display_property only if we are
2680 popping after iteration over a string that came from a display
2681 property. Fix a typo in popping stretch info. Add an assertion
2682 for verifying that the iterator position is in sync with the bidi
2683 iterator.
2684 (handle_single_display_spec, get_overlay_strings_1)
2685 (push_display_prop): Fix initialization of paragraph direction for
2686 string when that of the parent object is not yet determined.
2687 (reseat_1): Call bidi_init_it to resync the bidi
2688 iterator with IT's position. (Bug#7616)
2689 (find_row_edges): If ROW->start.pos gives position
2690 smaller than min_pos, use it as ROW->minpos. (Bug#7616)
2691 (handle_stop, back_to_previous_visible_line_start, reseat_1):
2692 Reset the from_disp_prop_p flag.
2693 (SAVE_IT, RESTORE_IT): New macros.
2694 (pos_visible_p, face_before_or_after_it_pos)
2695 (back_to_previous_visible_line_start)
2696 (move_it_in_display_line_to, move_it_in_display_line)
2697 (move_it_to, move_it_vertically_backward, move_it_by_lines)
2698 (try_scrolling, redisplay_window, display_line): Use them when
2699 saving a temporary copy of the iterator and restoring it back.
2700 (back_to_previous_visible_line_start, reseat_1)
2701 (init_iterator): Empty the bidi cache "stack".
2702 (move_it_in_display_line_to): If iterator ended up at
2703 EOL, but we never saw any buffer positions smaller than
2704 to_charpos, return MOVE_POS_MATCH_OR_ZV. Fixes vertical cursor
2705 motion in bidi-reordered lines.
2706 (move_it_in_display_line_to): Record prev_method and prev_pos
2707 immediately before the call to set_iterator_to_next. Fixes cursor
2708 motion in bidi-reordered lines with stretch glyphs and strings
2709 displayed in margins. (Bug#8133) (Bug#8867)
2710 Return MOVE_POS_MATCH_OR_ZV only if iterator position is past
2711 TO_CHARPOS.
640c8776
SM
2712 (pos_visible_p): Support positions in bidi-reordered lines.
2713 Save and restore bidi cache.
0bb23927
EZ
2714
2715 * bidi.c (bidi_level_of_next_char): clen should be EMACS_NT, not int.
2716 (bidi_paragraph_info): Delete unused struct.
2717 (bidi_cache_idx, bidi_cache_last_idx): Declare EMACS_INT.
2718 (bidi_cache_start): New variable.
2719 (bidi_cache_reset): Reset bidi_cache_idx to bidi_cache_start, not
2720 to zero.
2721 (bidi_cache_fetch_state, bidi_cache_search)
2722 (bidi_cache_find_level_change, bidi_cache_iterator_state)
2723 (bidi_cache_find, bidi_peek_at_next_level)
2724 (bidi_level_of_next_char, bidi_find_other_level_edge)
2725 (bidi_move_to_visually_next): Compare cache index with
2726 bidi_cache_start rather than with zero.
2727 (bidi_fetch_char): Accept new argument STRING; all callers
2728 changed. Support iteration over a string. Support strings with
2729 display properties. Support unibyte strings. Fix the type of
2730 `len' according to what STRING_CHAR_AND_LENGTH expects.
2731 (bidi_paragraph_init, bidi_resolve_explicit_1)
2732 (bidi_resolve_explicit, bidi_resolve_weak)
640c8776
SM
2733 (bidi_level_of_next_char, bidi_move_to_visually_next):
2734 Support iteration over a string.
0bb23927
EZ
2735 (bidi_set_sor_type, bidi_resolve_explicit_1)
2736 (bidi_resolve_explicit, bidi_type_of_next_char): ignore_bn_limit
2737 can now be zero (for strings); special values 0 and -1 were
2738 changed to -1 and -2, respectively.
2739 (bidi_char_at_pos): New function.
2740 (bidi_paragraph_init, bidi_resolve_explicit, bidi_resolve_weak):
2741 Call it instead of FETCH_MULTIBYTE_CHAR.
2742 (bidi_move_to_visually_next): Abort if charpos or bytepos were not
2743 initialized to valid values.
2744 (bidi_init_it): Don't initialize charpos and bytepos with invalid
2745 values.
2746 (bidi_level_of_next_char): Allow the sentinel "position" to pass
2747 the test for valid cached positions. Fix the logic for looking up
2748 the sentinel state in the cache. GCPRO the Lisp string we are
2749 iterating.
2750 (bidi_push_it, bidi_pop_it): New functions.
2751 (bidi_initialize): Initialize the bidi cache start stack pointer.
2752 (bidi_cache_ensure_space): New function, refactored from part of
2753 bidi_cache_iterator_state. Don't assume the required size is just
2754 one BIDI_CACHE_CHUNK away.
2755 (bidi_cache_start_stack, bidi_push_it): Use IT_STACK_SIZE.
2756 (bidi_count_bytes, bidi_char_at_pos): New functions.
2757 (bidi_cache_search): Don't assume bidi_cache_last_idx is
2758 always valid if bidi_cache_idx is valid.
2759 (bidi_cache_find_level_change): xassert that bidi_cache_last_idx
2760 is valid if it's going to be used.
2761 (bidi_shelve_cache, bidi_unshelve_cache): New functions.
2762 (bidi_cache_fetch_state, bidi_cache_search)
c965adc5
EZ
2763 (bidi_cache_find_level_change, bidi_cache_ensure_space)
2764 (bidi_cache_iterator_state, bidi_cache_find)
640c8776
SM
2765 (bidi_find_other_level_edge, bidi_cache_start_stack):
2766 All variables related to cache indices are now EMACS_INT.
c965adc5 2767
0bb23927
EZ
2768 * dispextern.h (struct bidi_string_data): New structure.
2769 (struct bidi_it): New member `string'. Make flag members be 1-bit
2770 fields, and put them last in the struct.
640c8776
SM
2771 (compute_display_string_pos, compute_display_string_end):
2772 Update prototypes.
0bb23927
EZ
2773 (bidi_push_it, bidi_pop_it): Add prototypes.
2774 (struct iterator_stack_entry): New members bidi_p,
2775 paragraph_embedding, and from_disp_prop_p.
2776 (struct it): Member bidi_p is now a bit field 1 bit wide.
640c8776
SM
2777 (bidi_shelve_cache, bidi_unshelve_cache):
2778 Declare prototypes.
0bb23927
EZ
2779
2780 * .gdbinit (xvectype, xvector, xcompiled, xchartable, xboolvector)
2781 (xpr, xfont, xbacktrace): Use "header.size" when accessing vectors
2782 and vector-like objects.
2783
2784 * dispnew.c (buffer_posn_from_coords): Save and restore the bidi
2785 cache around display iteration.
2786
2787 * window.c (Fwindow_end, window_scroll_pixel_based)
2788 (displayed_window_lines, Frecenter): Save and restore the bidi
2789 cache around display iteration.
2790
3bbd2265
LMI
27912011-07-14 Lars Magne Ingebrigtsen <larsi@gnus.org>
2792
2793 * editfns.c (Fdelete_region): Clarify the use of the named
2794 parameters (bug#6788).
2795
adc47434
MR
27962011-07-14 Martin Rudalics <rudalics@gmx.at>
2797
2798 * indent.c (Fvertical_motion): Set and restore w->pointm when
2799 saving and restoring the window's buffer (Bug#9006).
2800
837c31f8
LMI
28012011-07-13 Lars Magne Ingebrigtsen <larsi@gnus.org>
2802
2803 * editfns.c (Fstring_to_char): Clarify just what is returned
2804 (bug#6576). Text by Eli Zaretskii.
2805
ac389d0c
JB
28062011-07-13 Juanma Barranquero <lekktu@gmail.com>
2807
2808 * gnutls.c (init_gnutls_functions): Honor gnutls_log_level (bug#9059).
2809
0be0ce47
EZ
28102011-07-13 Eli Zaretskii <eliz@gnu.org>
2811
2812 * buffer.c (mmap_find): Fix a typo.
2813
cd18e7e3
JB
28142011-07-13 Johan Bockgård <bojohan@gnu.org>
2815
2816 Fix execution of x selection hooks.
2817 * xselect.c (Qx_lost_selection_functions)
2818 (Qx_sent_selection_functions): New vars.
2819 (syms_of_xselect): DEFSYM them.
2820 (x_handle_selection_request): Pass Qx_sent_selection_functions
2821 rather than Vx_sent_selection_functions to Frun_hook_with_args.
2822 (x_handle_selection_clear,x_clear_frame_selections):
2823 Pass Qx_lost_selection_functions rather than
2824 Vx_lost_selection_functions to Frun_hook_with_args.
2825
47ea7f44
PE
28262011-07-13 Paul Eggert <eggert@cs.ucla.edu>
2827
ac389d0c 2828 * buffer.c (Fget_buffer_create): Initialize inhibit_shrinking.
2941c447
PE
2829 The old code sometimes used this field without initializing it.
2830
47ea7f44
PE
2831 * alloc.c (gc_sweep): Don't read past end of array.
2832 In theory, the old code could also have corrupted Emacs internals,
2833 though it'd be very unlikely.
2834
bc985c87
AS
28352011-07-12 Andreas Schwab <schwab@linux-m68k.org>
2836
2837 * character.c (Fcharacterp): Don't advertise optional ignored
ac389d0c 2838 argument. (Bug#4026)
bc985c87 2839
0cf34688
LMI
28402011-07-12 Lars Magne Ingebrigtsen <larsi@gnus.org>
2841
b3dadd76
LMI
2842 * keymap.c (syms_of_keymap): Clarify that "modifier" is "modifier
2843 key" (bug#4257).
2844
0cf34688
LMI
2845 * window.c (Fset_window_start): Doc fix (bug#4199).
2846 (Fset_window_hscroll): Ditto.
2847
270768cd
PE
28482011-07-12 Paul Eggert <eggert@cs.ucla.edu>
2849
077e3dda 2850 Fix minor new problems caught by GCC 4.6.1.
270768cd 2851 * term.c (init_tty): Remove unused local.
490011a6 2852 * xsettings.c (store_monospaced_changed): Define this function only
077e3dda 2853 if (defined HAVE_GSETTINGS || defined HAVE_GCONF), as it's
490011a6 2854 not used otherwise.
270768cd 2855
b1f58454
CY
28562011-07-12 Chong Yidong <cyd@stupidchicken.com>
2857
2858 * xdisp.c (Vresize_mini_windows): Minor doc fix (Bug#3300).
2859
22b9578d
LMI
28602011-07-11 Lars Magne Ingebrigtsen <larsi@gnus.org>
2861
6e70ab07
LMI
2862 * xdisp.c (syms_of_xdisp): Make it explicit that the mini-windows
2863 are the mini-buffer and the echo area (bug#3320).
2864
22b9578d
LMI
2865 * term.c (init_tty): Remove support for supdup, c10 and perq
2866 terminals, which are no longer supported (bug#1482).
2867
8974cc9f
JB
28682011-07-10 Johan Bockgård <bojohan@gnu.org>
2869
2870 * xdisp.c (Ftool_bar_lines_needed): Fix WINDOWP check.
2871
a560d974
JD
28722011-07-10 Jan Djärv <jan.h.d@swipnet.se>
2873
2874 * xmenu.c (menu_highlight_callback): Only pass frame to show_help_event
2875 for non-popups (Bug#3642).
2876
1dae0f0a
AS
28772011-07-10 Andreas Schwab <schwab@linux-m68k.org>
2878
268c2c36 2879 * alloc.c (reset_malloc_hooks): Protoize.
1dae0f0a 2880 * buffer.c (mmap_init, mmap_find, mmap_free_1, mmap_enlarge)
268c2c36
AS
2881 (mmap_set_vars, mmap_alloc, mmap_free, mmap_realloc): Likewise.
2882 * cm.c (losecursor): Likewise.
1dae0f0a
AS
2883 * data.c (fmod): Likewise.
2884 * dispnew.c (swap_glyphs_in_rows): Likewise.
2885 * emacs.c (memory_warning_signal): Likewise.
2886 * floatfns.c (float_error): Likewise.
2887 * font.c (check_gstring, check_otf_features, otf_tag_symbol)
2888 (otf_open, font_otf_capability, generate_otf_features)
2889 (font_otf_DeviceTable, font_otf_ValueRecord, font_otf_Anchor):
2890 Likewise.
2891 * image.c (pbm_read_file): Likewise.
2892 * indent.c (string_display_width): Likewise.
2893 * intervals.c (check_for_interval, search_for_interval)
2894 (inc_interval_count, count_intervals, root_interval)
2895 (adjust_intervals_for_insertion, make_new_interval): Likewise.
2896 * lread.c (defalias): Likewise.
268c2c36 2897 * ralloc.c (r_alloc_check): Likewise.
1dae0f0a
AS
2898 * regex.c (set_image_of_range_1, set_image_of_range)
2899 (regex_grow_registers): Likewise.
2900 * sysdep.c (strerror): Likewise.
2901 * termcap.c (valid_filename_p, tprint, main): Likewise.
2902 * tparam.c (main): Likewise.
2903 * unexhp9k800.c (run_time_remap, save_data_space)
2904 (update_file_ptrs, read_header, write_header, calculate_checksum)
2905 (copy_file, copy_rest, display_header): Likewise.
2906 * widget.c (mark_shell_size_user_specified, create_frame_gcs):
2907 Likewise.
2908 * xdisp.c (check_it): Likewise.
2909 * xfaces.c (register_color, unregister_color, unregister_colors):
2910 Likewise.
2911 * xfns.c (print_fontset_result): Likewise.
2912 * xrdb.c (member, fatal, main): Likewise.
2913
99033785
PE
29142011-07-10 Paul Eggert <eggert@cs.ucla.edu>
2915
2916 Fix minor problems found by static checking (Bug#9031).
2917 * chartab.c (char_table_set_range, map_sub_char_table):
2918 Remove unused locals.
2919 (uniprop_table): Now static.
2920 * composite.c (_work_char): Remove unused static var.
2921
9cb2ac56
JB
29222011-07-09 Juanma Barranquero <lekktu@gmail.com>
2923
2924 * chartab.c (uniprop_table_uncompress): Remove unused local variable.
2925
f25661f0
JD
29262011-07-09 Jan Djärv <jan.h.d@swipnet.se>
2927
2928 * gtkutil.c (qttip_cb): Remove code without function.
2929
8278c4fe
EZ
29302011-07-09 Eli Zaretskii <eliz@gnu.org>
2931
2932 * w32.c (pthread_sigmask): New stub.
2933
1692ae2d 29342011-07-08 Paul Eggert <eggert@cs.ucla.edu>
123403e4 2935
8a6ebd58 2936 Use pthread_sigmask, not sigprocmask (Bug#9010).
123403e4
PE
2937 sigprocmask is portable only for single-threaded applications, and
2938 Emacs can be multi-threaded when it uses GTK.
1301ac26
PE
2939 * Makefile.in (LIB_PTHREAD_SIGMASK): New macro.
2940 (LIBES): Use it.
2941 * callproc.c (Fcall_process):
2942 * process.c (create_process):
2943 * sysdep.c (sys_sigblock, sys_sigunblock, sys_sigsetmask):
2944 Use pthread_sigmask, not sigprocmask.
123403e4 2945
1b854618
JD
29462011-07-08 Jan Djärv <jan.h.d@swipnet.se>
2947
2948 * gtkutil.c (qttip_cb): Set line wrap to FALSE for tooltip widget.
2949 (xg_prepare_tooltip): Revert text in x->ttip_lbl, margins was
2950 wrong (Bug#8591).
2951
3fe4b549
JD
29522011-07-08 Jan Djärv <jan.h.d@swipnet.se>
2953
0ce7e563
JD
2954 * gtkutil.c (xg_prepare_tooltip): Fix indentation and comment.
2955 Put text in x->ttip_lbl instead of gtk_tooltip_set_text (Bug#8591).
2956 (xg_hide_tooltip): Fix comment.
2957
3fe4b549
JD
2958 * nsterm.m (initFrameFromEmacs): Don't use ns_return_types
2959 in registerServicesMenuSendTypes.
2960 (validRequestorForSendType): Don't check ns_return_types.
2961
2962 * nsfns.m (Fx_open_connection): Put NSStringPboardType into
2963 ns_return_type.
2964
5df75e47
JR
29652011-07-08 Jason Rumney <jasonr@gnu.org>
2966
22610910
JR
2967 * w32term.c (x_make_frame_visible): Use SH_SHOWNORMAL rather than
2968 SH_SHOW for hidden windows (Bug#5482).
2969
5df75e47
JR
2970 * w32fns.c (w32_wnd_proc) [WM_TIMER, WM_SET_CURSOR]: Avoid using
2971 frame struct members of non-existent frames (Bug#6284).
2972
699c10bd
JD
29732011-07-08 Jan Djärv <jan.h.d@swipnet.se>
2974
4393663b
JD
2975 * nsterm.m (keyDown): Call to wantsToDelayTextChangeNotifications and
2976 variable firstTime not needed on OSX >= 10.6.
2977 (setPosition): setFloatValue:knobProportion: is deprecated on OSX
2978 >= 10.5. Use setKnobProportion, setDoubleValue.
2979
2980 * nsterm.h (MAC_OS_X_VERSION_10_3, MAC_OS_X_VERSION_10_4)
2981 (MAC_OS_X_VERSION_10_5): Define if not defined.
2982 (EmacsView, EmacsTooltip): Implements NSWindowDelegate on OSX >= 10.6.
2983 (EmacsMenu): Implements NSMenuDelegate on OSX >= 10.6.
2984 (EmacsToolbar): Implements NSToolbarDelegate on OSX >= 10.6.
2985
2986 * nsselect.m (ns_string_from_pasteboard): Don't use deprecated methods
2987 cString and lossyCString on OSX >= 10.4
2988
2989 * nsmenu.m (fillWithWidgetValue): Don't use depercated method
2990 sizeToFit on OSX >= 10.2.
2991
2992 * nsimage.m (allocInitFromFile): Don't use deprecated method
2993 bestRepresentationForDevice on OSX >= 10.6.
2994
2995 * nsfns.m (check_ns_display_info): Cast to long and use %ld in error
2996 to avoid warning.
2997
2998 * emacs.c: Declare unexec_init_emacs_zone.
2999
a63e0781
JD
3000 * nsgui.h: Fix compiler warning about gnulib redefining verify.
3001
699c10bd
JD
3002 * nsselect.m (ns_get_local_selection): Change to extern (Bug#8842).
3003
3004 * nsmenu.m (ns_update_menubar): Remove useless setDelegate call
3005 on svcsMenu (Bug#8842).
3006
3007 * nsfns.m (Fx_open_connection): Remove NSStringPboardType from
3008 ns_return_types.
3009 (Fns_list_services): Just return Qnil on 10.6, code not working there.
3010
3011 * nsterm.m (QUTF8_STRING): Declare.
3012 (initFrameFromEmacs): Call registerServicesMenuSendTypes.
3013 (validRequestorForSendType): Return type is (id).
3014 Change indexOfObjectIdenticalTo to indexOfObject.
3015 Check if we have local selection before returning self (Bug#8842).
3016 (writeSelectionToPasteboard): Put local selection into paste board
3017 if we have a local selection (Bug#8842).
3018 (syms_of_nsterm): DEFSYM QUTF8_STRING.
3019
3020 * nsterm.h (MAC_OS_X_VERSION_10_6): Define here instead of nsterm.m.
3021 (ns_get_local_selection): Declare.
3022
54e10184
LMI
30232011-07-07 Lars Magne Ingebrigtsen <larsi@gnus.org>
3024
9888ff71
LMI
3025 * keymap.c (describe_map_tree): Don't insert a double newline at
3026 the end of the buffer (bug#1169) and return whether we inserted
3027 something.
3028
54e10184
LMI
3029 * callint.c (Fcall_interactively): Change "reading args" to
3030 "providing args" to try to clarify what it does (bug#1010).
3031
15fa4783
KH
30322011-07-07 Kenichi Handa <handa@m17n.org>
3033
3034 * composite.c (composition_compute_stop_pos): Ignore a static
3035 composition starting before CHARPOS (Bug#8915).
3036
3037 * xdisp.c (handle_composition_prop): Likewise.
3038
a8815b00
EZ
30392011-07-07 Eli Zaretskii <eliz@gnu.org>
3040
3041 * term.c (produce_glyphs) <xassert>: Allow IT_GLYPHLESS in it->what.
3042 (Bug#9015)
3043
ef7b981d 30442011-07-07 Kenichi Handa <handa@m17n.org>
c805dec0
KH
3045
3046 * character.h (unicode_category_t): New enum type.
3047
3048 * chartab.c (uniprop_decoder_t, uniprop_encoder_t): New types.
3049 (Qchar_code_property_table): New variable.
3050 (UNIPROP_TABLE_P, UNIPROP_GET_DECODER)
3051 (UNIPROP_COMPRESSED_FORM_P): New macros.
3052 (char_table_ascii): Uncompress the compressed values.
3053 (sub_char_table_ref): New arg is_uniprop. Callers changed.
3054 Uncompress the compressed values.
ac389d0c 3055 (sub_char_table_ref_and_range): Likewise.
c805dec0
KH
3056 (char_table_ref_and_range): Uncompress the compressed values.
3057 (sub_char_table_set): New arg is_uniprop. Callers changed.
3058 Uncompress the compressed values.
3059 (sub_char_table_set_range): Args changed. Callers changed.
3060 (char_table_set_range): Adjuted for the above change.
3061 (map_sub_char_table): Delete args default_val and parent. Add arg
3062 top. Give decoded values to a Lisp function.
640c8776 3063 (map_char_table): Adjust for the above change. Give decoded
c805dec0
KH
3064 values to a Lisp function. Gcpro more variables.
3065 (uniprop_table_uncompress)
3066 (uniprop_decode_value_run_length): New functions.
3067 (uniprop_decoder, uniprop_decoder_count): New variables.
3068 (uniprop_get_decoder, uniprop_encode_value_character)
3069 (uniprop_encode_value_run_length, uniprop_encode_value_numeric):
3070 New functions.
3071 (uniprop_encoder, uniprop_encoder_count): New variables.
3072 (uniprop_get_encoder, uniprop_table)
3073 (Funicode_property_table_internal, Fget_unicode_property_internal)
3074 (Fput_unicode_property_internal): New functions.
3075 (syms_of_chartab): DEFSYM Qchar_code_property_table, defsubr
3076 Sunicode_property_table_internal, Sget_unicode_property_internal,
5e617bc2 3077 and Sput_unicode_property_internal. Defvar_lisp
c805dec0
KH
3078 char-code-property-alist.
3079
640c8776 3080 * composite.c (CHAR_COMPOSABLE_P): Adjust for the change of
c805dec0
KH
3081 Vunicode_category_table.
3082
640c8776 3083 * font.c (font_range): Adjust for the change of
c805dec0
KH
3084 Vunicode_category_table.
3085
76b397fb
DN
30862011-07-07 Dan Nicolaescu <dann@ics.uci.edu>
3087
3088 * m/iris4d.h: Remove file, move contents ...
3089 * s/irix6-5.h: ... here.
3090
22b4128e
PE
30912011-07-06 Paul Eggert <eggert@cs.ucla.edu>
3092
3093 Remove unportable assumption about struct layout (Bug#8884).
8a5c77bb
PE
3094 * alloc.c (mark_buffer):
3095 * buffer.c (reset_buffer_local_variables, Fbuffer_local_variables)
3096 (clone_per_buffer_values): Don't assume that
22b4128e
PE
3097 sizeof (struct buffer) is a multiple of sizeof (Lisp_Object).
3098 This isn't true in general, and it's particularly not true
3099 if Emacs is configured with --with-wide-int.
3100 * buffer.h (FIRST_FIELD_PER_BUFFER, LAST_FIELD_PER_BUFFER):
3101 New macros, used in the buffer.c change.
3102
869795d6
JD
31032011-07-05 Jan Djärv <jan.h.d@swipnet.se>
3104
3105 * xsettings.c: Use both GConf and GSettings if both are available.
3106 (store_config_changed_event): Add comment.
3107 (dpyinfo_valid, store_font_name_changed, map_tool_bar_style)
3108 (store_tool_bar_style_changed): New functions.
5e617bc2 3109 (store_monospaced_changed): Add comment. Call dpyinfo_valid.
869795d6
JD
3110 (struct xsettings): Move font inside HAVE_XFT.
3111 (GSETTINGS_TOOL_BAR_STYLE, GSETTINGS_FONT_NAME): New defines.
640c8776 3112 (GSETTINGS_MONO_FONT): Rename from SYSTEM_MONO_FONT.
869795d6 3113 Move inside HAVE_XFT.
640c8776 3114 (something_changed_gsettingsCB): Rename from something_changedCB.
869795d6
JD
3115 Check for changes in GSETTINGS_TOOL_BAR_STYLE and GSETTINGS_FONT_NAME
3116 also.
3117 (GCONF_TOOL_BAR_STYLE, GCONF_FONT_NAME): New defines.
5e617bc2 3118 (GCONF_MONO_FONT): Rename from SYSTEM_MONO_FONT. Move inside HAVE_XFT.
640c8776 3119 (something_changed_gconfCB): Rename from something_changedCB.
869795d6
JD
3120 Check for changes in GCONF_TOOL_BAR_STYLE and GCONF_FONT_NAME also.
3121 (parse_settings): Move check for font inside HAVE_XFT.
3122 (read_settings, apply_xft_settings): Add comment.
3123 (read_and_apply_settings): Add comment. Call map_tool_bar_style and
3124 store_tool_bar_style_changed. Move check for font inside HAVE_XFT and
3125 call store_font_name_changed.
3126 (xft_settings_event): Add comment.
3127 (init_gsettings): Add comment. Get values for GSETTINGS_TOOL_BAR_STYLE
3128 and GSETTINGS_FONT_NAME. Move check for fonts within HAVE_XFT.
3129 (init_gconf): Add comment. Get values for GCONF_TOOL_BAR_STYLE
3130 and GCONF_FONT_NAME. Move check for fonts within HAVE_XFT.
3131 (xsettings_initialize): Call init_gsettings last.
640c8776
SM
3132 (xsettings_get_system_font, xsettings_get_system_normal_font):
3133 Add comment.
869795d6 3134
d8ed26bd
PE
31352011-07-05 Paul Eggert <eggert@cs.ucla.edu>
3136
3137 Random fixes. E.g., (random) never returned negative values.
3138 * fns.c (Frandom): Use GET_EMACS_TIME for random seed, and add the
3139 subseconds part to the entropy, as that's a bit more random.
3140 Prefer signed to unsigned, since the signedness doesn't matter and
3141 in general we prefer signed. When given a limit, use a
3142 denominator equal to INTMASK + 1, not to VALMASK + 1, because the
3143 latter isn't right if USE_2_TAGS_FOR_INTS.
3144 * sysdep.c (get_random): Return a value in the range 0..INTMASK,
3145 not 0..VALMASK. Don't discard "excess" bits that random () returns.
3146
cabf1cac
SM
31472011-07-04 Stefan Monnier <monnier@iro.umontreal.ca>
3148
3149 * textprop.c (text_property_stickiness):
3150 Obey Vtext_property_default_nonsticky.
3151 (syms_of_textprop): Add `display' to Vtext_property_default_nonsticky.
3152 * w32fns.c (syms_of_w32fns):
3153 * xfns.c (syms_of_xfns): Don't Add `display' since it's there by default.
3154
6e9b2be9
PE
31552011-07-04 Paul Eggert <eggert@cs.ucla.edu>
3156
3157 * fileio.c (barf_or_query_if_file_exists): Use S_ISDIR.
3158 This is more efficient than Ffile_directory_p and avoids a minor race.
3159
90186c68
LMI
31602011-07-04 Lars Magne Ingebrigtsen <larsi@gnus.org>
3161
7c301272
LMI
3162 * buffer.c (Foverlay_put): Say what the return value is
3163 (bug#7835).
3164
c4f2d8d4
LMI
3165 * fileio.c (barf_or_query_if_file_exists): Check first if the file
3166 is a directory before asking whether to use the file name
3167 (bug#7564).
ad637907
LMI
3168 (barf_or_query_if_file_exists): Make the "File is a directory"
3169 error be more correct.
c4f2d8d4 3170
90186c68
LMI
3171 * fns.c (Frequire): Remove the mention of the .gz files, since
3172 that's installation-specific, but keep the mention of
3173 `get-load-suffixes'.
3174
da64016e
PE
31752011-07-04 Paul Eggert <eggert@cs.ucla.edu>
3176
3177 * editfns.c (Fformat_time_string): Don't assume strlen fits in int.
3178 Report string overflow if the output is too long.
3179
7d47b580
JB
31802011-07-04 Juanma Barranquero <lekktu@gmail.com>
3181
a555cb87
JB
3182 * gnutls.c (Fgnutls_boot): Don't mention :verify-error.
3183 (syms_of_gnutls): Remove duplicate DEFSYM for
3184 Qgnutls_bootprop_verify_hostname_error, an error for
3185 Qgnutls_bootprop_verify_error (which is no longer used).
3186
7d47b580
JB
3187 * eval.c (find_handler_clause): Remove parameters `sig' and `data',
3188 unused since 2011-01-26T20:02:07Z!monnier@iro.umontreal.ca. All callers changed.
3189 Also (re)move comments that are misplaced or no longer relevant.
3190
1e49bfab
LMI
31912011-07-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
3192
3193 * callint.c (Finteractive): Clarify the meaning of "@" (bug#8813).
3194
1485f4c0
CY
31952011-07-03 Chong Yidong <cyd@stupidchicken.com>
3196
3197 * xfaces.c (Finternal_merge_in_global_face): Modify the foreground
3198 and background color parameters if they have been changed.
3199
a9ab721e
LMI
32002011-07-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
3201
3202 * editfns.c (Fformat): Clarify the - and 0 flags (bug#6659).
3203
cf7cff57
PE
32042011-07-03 Paul Eggert <eggert@cs.ucla.edu>
3205
2e13213d
PE
3206 * xsettings.c (SYSTEM_FONT): Define only when used.
3207 No need to define when HAVE_GSETTINGS || !HAVE_XFT.
3208
cf7cff57
PE
3209 * keymap.c (access_keymap_1): Now static.
3210
7a8e04f7
CY
32112011-07-02 Chong Yidong <cyd@stupidchicken.com>
3212
3213 * keyboard.c (command_loop_1): If a down-mouse event is unbound,
3214 leave any prefix arg for the up event (Bug#1586).
3215
61352f62
LMI
32162011-07-02 Lars Magne Ingebrigtsen <larsi@gnus.org>
3217
69bb1ef7
LMI
3218 * lread.c (syms_of_lread): Mention single symbols defined by
3219 `defvar' or `defconst' (bug#7154).
3220
61352f62 3221 * fns.c (Frequire): Mention .el.gz files (bug#7314).
7b3747f9 3222 (Frequire): Mention get-load-suffixes.
61352f62 3223
28545e04
MR
32242011-07-02 Martin Rudalics <rudalics@gmx.at>
3225
3226 * window.h (window): Remove clone_number slot.
3227 * window.c (Fwindow_clone_number, Fset_window_clone_number):
3228 Remove.
3229 (make_parent_window, make_window, saved_window)
3230 (Fset_window_configuration, save_window_save): Don't deal with
3231 clone numbers.
3232 * buffer.c (Qclone_number): Remove declaration.
3233 (sort_overlays, overlay_strings): Don't deal with clone numbers.
3234
3349e122
SM
32352011-07-02 Stefan Monnier <monnier@iro.umontreal.ca>
3236
3237 Add multiple inheritance to keymaps.
3238 * keymap.c (Fmake_composed_keymap): New function.
3239 (Fset_keymap_parent): Simplify.
3240 (fix_submap_inheritance): Remove.
3241 (access_keymap_1): New function extracted from access_keymap to handle
3242 embedded parents and handle lists of maps.
3243 (access_keymap): Use it.
3244 (Fkeymap_prompt, map_keymap_internal, map_keymap, store_in_keymap)
3245 (Fcopy_keymap): Handle embedded parents.
3246 (Fcommand_remapping, define_as_prefix): Simplify.
3247 (Fkey_binding): Simplify.
3248 (syms_of_keymap): Move minibuffer-local-completion-map,
3249 minibuffer-local-filename-completion-map,
3250 minibuffer-local-must-match-map, and
3251 minibuffer-local-filename-must-match-map to Elisp.
3252 (syms_of_keymap): Defsubr make-composed-keymap.
3253 * keyboard.c (menu_bar_items): Use map_keymap_canonical.
3254 (parse_menu_item): Trivial simplification.
3255
3279eb87
GM
32562011-07-01 Glenn Morris <rgm@gnu.org>
3257
3258 * Makefile.in (SETTINGS_LIBS): Fix typo.
3259
4550efdf
KI
32602011-07-01 Kazuhiro Ito <kzhr@d1.dion.ne.jp> (tiny patch)
3261
3262 * coding.c (Fencode_coding_string): Record the last coding system
3263 used, as the function doc string says (bug#8738).
3264
0949d2b6
JD
32652011-07-01 Jan Djärv <jan.h.d@swipnet.se>
3266
3267 * xsettings.c (store_monospaced_changed): Take new font as arg and
3268 check for change against current_mono_font.
3269 (EMACS_TYPE_SETTINGS): Remove this and related defines.
3270 (emacs_settings_constructor, emacs_settings_get_property)
3271 (emacs_settings_set_property, emacs_settings_class_init)
3272 (emacs_settings_init, gsettings_obj): Remove.
3273 (something_changedCB): New function for HAVE_GSETTINGS.
3274 (something_changedCB): HAVE_GCONF: Call store_monospaced_changed
3275 with value as argument.
3276 (init_gsettings): Check that GSETTINGS_SCHEMA exists before calling
3277 g_settings_new (Bug#8967). Do not create gsettings_obj.
9173deec 3278 Remove calls to g_settings_bind. Connect something_changedCB to
0949d2b6
JD
3279 "changed".
3280
3281 * xgselect.c: Add defined (HAVE_GSETTINGS).
3282 (xgselect_initialize): Ditto.
3283
3284 * process.c: Add defined (HAVE_GSETTINGS) for xgselect.h
3285 (wait_reading_process_output): Add defined (HAVE_GSETTINGS) for
3286 xg_select.
3287
bbc6b304
PE
32882011-07-01 Paul Eggert <eggert@cs.ucla.edu>
3289
3290 * eval.c (struct backtrace): Simplify and port the data structure.
3291 Do not assume that "int nargs : BITS_PER_INT - 2;" produces a
3292 signed bit field, as this assumption is not portable and it makes
3293 Emacs crash when compiled with Sun C 5.8 on sparc. Do not use
3294 "char debug_on_exit : 1" as this is not portable either; instead,
3295 use the portable "unsigned int debug_on_exit : 1". Remove unused
3296 member evalargs. Remove obsolete comments about cc bombing out.
3297
9851bfc5
JD
32982011-06-30 Jan Djärv <jan.h.d@swipnet.se>
3299
51bb811f 3300 * xsettings.c: Include glib-object.h, gio/gio.h if HAVE_GSETTINGS.
9851bfc5
JD
3301 Let HAVE_GSETTINGS override HAVE_GCONF.
3302 (store_monospaced_changed): New function.
3303 (EMACS_SETTINGS): A new type derived from GObject to handle
3304 GSettings notifications.
3305 (emacs_settings_constructor, emacs_settings_get_property)
3306 (emacs_settings_set_property, emacs_settings_class_init):
3307 New functions.
3308 (gsettings_client, gsettings_obj): New variables.
3309 (GSETTINGS_SCHEMA): New define.
3310 (something_changedCB): Call store_monospaced_changed.
3311 (init_gsettings): New function.
3312 (xsettings_initialize): Call init_gsettings.
3313 (syms_of_xsettings): Initialize gsettings_client, gsettings_obj
3314 to NULL.
3315
640c8776 3316 * Makefile.in (SETTINGS_CFLAGS, SETTINGS_LIBS): Rename from
9851bfc5
JD
3317 GCONF_CFLAGS/LIBS.
3318
5386012d
MR
33192011-06-29 Martin Rudalics <rudalics@gmx.at>
3320
3321 * window.c (resize_root_window, grow_mini_window)
3322 (shrink_mini_window): Rename Qresize_root_window to
3323 Qwindow_resize_root_window and Qresize_root_window_vertically to
3324 Qwindow_resize_root_window_vertically.
3325
f13e0b08
PE
33262011-06-28 Paul Eggert <eggert@cs.ucla.edu>
3327
3328 * gnutls.c (Qgnutls_bootprop_verify_error): Remove unused var.
3329
94515237
JB
33302011-06-27 Juanma Barranquero <lekktu@gmail.com>
3331
3332 * makefile.w32-in: Redesign dependencies so they reflect more
3333 clearly which files are directly included by each source file,
3334 and not through other includes.
3335
e43b6e43
MR
33362011-06-27 Martin Rudalics <rudalics@gmx.at>
3337
3338 * buffer.c (Qclone_number): Declare static and DEFSYM it.
3339 (sort_overlays, overlay_strings): When an overlay's clone number
3340 matches the window's clone number process the overlay even if
3341 the overlay's window property doesn't match the current window.
3342
d68443dc
MR
3343 * window.c (Fwindow_vchild): Rename to Fwindow_top_child.
3344 (Fwindow_hchild): Rename to Fwindow_left_child.
3345 (Fwindow_next): Rename to Fwindow_next_sibling.
3346 (Fwindow_prev): Rename to Fwindow_prev_sibling.
d615d6d2
MR
3347 (resize_window_check): Rename to window_resize_check.
3348 (resize_window_apply): Rename to window_resize_apply.
3349 (Fresize_window_apply): Rename to Fwindow_resize_apply.
3350 (Fdelete_other_windows_internal, resize_frame_windows)
3351 (Fsplit_window_internal, Fdelete_window_internal)
3352 (grow_mini_window, shrink_mini_window)
3353 (Fresize_mini_window_internal): Fix callers accordingly.
d68443dc 3354
c7e73be5
JD
33552011-06-26 Jan Djärv <jan.h.d@swipnet.se>
3356
3357 * emacsgtkfixed.h: State that this is only used with Gtk+3.
3358 (emacs_fixed_set_min_size): Remove.
3359 (emacs_fixed_new): Take frame as argument.
3360
3361 * emacsgtkfixed.c: State that this is only used with Gtk+3.
3362 (_EmacsFixedPrivate): Remove minwidth/height.
3363 Add struct frame *f.
3364 (emacs_fixed_init): Initialize priv->f.
3365 (get_parent_class, emacs_fixed_set_min_size): Remove.
3366 (emacs_fixed_new): Set priv->f to argument.
3367 (emacs_fixed_get_preferred_width)
3368 (emacs_fixed_get_preferred_height): Use min_width/height from
3369 frames size_hint to set minimum and natural (Bug#8919).
3370 (XSetWMSizeHints, XSetWMNormalHints): Override these functions
3371 and use min_width/height from frames size_hint to set
3372 min_width/height (Bug#8919).
3373
3374 * gtkutil.c (xg_create_frame_widgets): Pass f to emacs_fixed_new.
9173deec
JB
3375 (x_wm_set_size_hint): Remove call to emacs_fixed_set_min_size.
3376 Fix indentation.
c7e73be5 3377
cf99dcf8
EZ
33782011-06-26 Eli Zaretskii <eliz@gnu.org>
3379
3380 * bidi.c (bidi_paragraph_init): Test for ZV_BYTE before calling
3381 bidi_at_paragraph_end, since fast_looking_at doesn't like to be
3382 called at ZV.
3383
029529ac
CY
33842011-06-26 Chong Yidong <cyd@stupidchicken.com>
3385
3386 * process.c (wait_reading_process_output): Bypass select if
3387 waiting for a cell while ignoring keyboard input, and input is
3388 pending. Suggested by Jan Djärv (Bug#8869).
3389
7a7ef429
PE
33902011-06-25 Paul Eggert <eggert@cs.ucla.edu>
3391
3392 Use gnulib's dup2 module instead of rolling our own.
3393 * sysdep.c (dup2) [!HAVE_DUP2]: Remove; gnulib now does this.
3394
11fdef7d 33952011-06-25 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
989b42d2
YM
3396
3397 * dispnew.c (scrolling_window): Before scrolling, turn off a
3398 mouse-highlight in the window being scrolled.
3399
cd3520a4
JB
34002011-06-24 Juanma Barranquero <lekktu@gmail.com>
3401
3402 Move DEFSYM to lisp.h and use everywhere.
3403
3404 * character.h (DEFSYM): Move declaration...
3405 * lisp.h (DEFSYM): ...here.
3406
3407 * gnutls.c:
3408 * minibuf.c:
3409 * w32menu.c:
3410 * w32proc.c:
3411 * w32select.c: Don't include character.h.
3412
3413 * alloc.c (syms_of_alloc):
3414 * buffer.c (syms_of_buffer):
3415 * bytecode.c (syms_of_bytecode):
3416 * callint.c (syms_of_callint):
3417 * casefiddle.c (syms_of_casefiddle):
3418 * casetab.c (init_casetab_once):
3419 * category.c (init_category_once, syms_of_category):
3420 * ccl.c (syms_of_ccl):
3421 * cmds.c (syms_of_cmds):
3422 * composite.c (syms_of_composite):
3423 * dbusbind.c (syms_of_dbusbind):
3424 * dired.c (syms_of_dired):
3425 * dispnew.c (syms_of_display):
3426 * doc.c (syms_of_doc):
3427 * editfns.c (syms_of_editfns):
3428 * emacs.c (syms_of_emacs):
3429 * eval.c (syms_of_eval):
3430 * fileio.c (syms_of_fileio):
3431 * fns.c (syms_of_fns):
3432 * frame.c (syms_of_frame):
3433 * fringe.c (syms_of_fringe):
3434 * insdel.c (syms_of_insdel):
3435 * keymap.c (syms_of_keymap):
3436 * lread.c (init_obarray, syms_of_lread):
3437 * macros.c (syms_of_macros):
3438 * msdos.c (syms_of_msdos):
3439 * print.c (syms_of_print):
3440 * process.c (syms_of_process):
3441 * search.c (syms_of_search):
3442 * sound.c (syms_of_sound):
3443 * syntax.c (init_syntax_once, syms_of_syntax):
3444 * terminal.c (syms_of_terminal):
3445 * textprop.c (syms_of_textprop):
3446 * undo.c (syms_of_undo):
3447 * w32.c (globals_of_w32):
3448 * window.c (syms_of_window):
3449 * xdisp.c (syms_of_xdisp):
3450 * xfaces.c (syms_of_xfaces):
3451 * xfns.c (syms_of_xfns):
3452 * xmenu.c (syms_of_xmenu):
3453 * xsettings.c (syms_of_xsettings):
3454 * xterm.c (syms_of_xterm): Use DEFSYM.
3455
4228cf16
TZ
34562011-06-24 Teodor Zlatanov <tzz@lifelogs.com>
3457
cd3520a4 3458 * gnutls.c (syms_of_gnutls): Use the DEFSYM macro from character.h.
4228cf16 3459
7fcccf1e
PE
34602011-06-23 Paul Eggert <eggert@cs.ucla.edu>
3461
7efb4e0e
PE
3462 Integer and buffer overflow fixes (Bug#8873).
3463
ff5844ad
PE
3464 * print.c (printchar, strout): Check for string overflow.
3465 (PRINTPREPARE, printchar, strout):
3466 Don't set size unless allocation succeeds.
3467
90532f02
PE
3468 * minibuf.c (read_minibuf_noninteractive): Use ptrdiff_t, not int,
3469 for sizes. Check for string overflow more accurately.
3470 Simplify newline removal at end; this suppresses a GCC 4.6.0 warning.
3471
6d84508d
PE
3472 * macros.c: Integer and buffer overflow fixes.
3473 * keyboard.h (struct keyboard.kbd_macro_bufsize):
3474 * macros.c (Fstart_kbd_macro, store_kbd_macro_char):
3475 Use ptrdiff_t, not int, for sizes.
3476 Don't increment bufsize until after realloc succeeds.
3477 Check for size-calculation overflow.
3478 (Fstart_kbd_macro): Use EMACS_INT, not int, for XINT result.
3479
437b2cb4
PE
3480 * lisp.h (DEFVAR_KBOARD): Use offsetof instead of char * finagling.
3481
8b9ac8b4
PE
3482 * lread.c: Integer overflow fixes.
3483 (read_integer): Radix is now EMACS_INT, not int,
3484 to improve quality of diagnostics for out-of-range radices.
3485 Calculate buffer size correctly for out-of-range radices.
3486 (read1): Check for integer overflow in radices, and in
3487 read-circle numbers.
82cb60d3
PE
3488 (read_escape): Avoid int overflow.
3489 (Fload, openp, read_buffer_size, read1)
3490 (substitute_object_recurse, read_vector, read_list, map_obarray):
3491 Use ptrdiff_t, not int, for sizes.
3492 (read1): Use EMACS_INT, not int, for sizes.
20270765 3493 Check for size overflow.
8b9ac8b4 3494
7fcccf1e
PE
3495 * image.c (cache_image): Check for size arithmetic overflow.
3496
bfbbd7e7
PE
3497 * lread.c: Integer overflow issues.
3498 (saved_doc_string_size, saved_doc_string_length)
3499 (prev_saved_doc_string_size, prev_saved_doc_string_length):
3500 Now ptrdiff_t, not int.
3501 (read1): Don't assume doc string length fits in int. Check for
3502 out-of-range doc string lengths.
3503 (read_list): Don't assume file position fits in int.
39019e54 3504 (read_escape): Check for hex character overflow.
bfbbd7e7 3505
4e323265
LL
35062011-06-22 Leo Liu <sdl.web@gmail.com>
3507
3508 * minibuf.c (Fcompleting_read_default, Vcompleting_read_function):
3509 Move to minibuffer.el.
3510
85fece3e
PE
35112011-06-22 Paul Eggert <eggert@cs.ucla.edu>
3512
20b84ce9 3513 Fixes for GLYPH_DEBUG found by GCC 4.6.0 static checking.
85fece3e
PE
3514 The following patches are for when GLYPH_DEBUG && !XASSERT.
3515 * dispextern.h (trace_redisplay_p, dump_glyph_string):
3516 * dispnew.c (flush_stdout):
3517 * xdisp.c (dump_glyph_row, dump_glyph_matrix, dump_glyph):
3518 Mark as externally visible.
3519 * dispnew.c (check_window_matrix_pointers): Now static.
3520 * dispnew.c (window_to_frame_vpos):
3521 * xfns.c (unwind_create_frame):
3522 * xterm.c (x_check_font): Remove unused local.
3523 * scroll.c (CHECK_BOUNDS):
3524 * xfaces.c (cache_fache): Rename local to avoid shadowing.
3525 * xfns.c, w32fns.c (image_cache_refcount, dpyinfo_refcount): Now static.
3526 * xdisp.c (check_window_end): Now a no-op if !XASSERTS.
3527 (debug_first_unchanged_at_end_vpos, debug_last_unchanged_at_beg_vpos)
3528 (debug_dvpos, debug_dy, debug_delta, debug_delta_bytes, debug_end_vpos):
3529 Now static.
3530 (debug_method_add): Use va_list and vsprintf rather than relying
3531 on undefined behavior with wrong number of arguments.
3532 (dump_glyph, dump_glyph_row, Fdump_glyph_matrix):
3533 Don't assume ptrdiff_t and EMACS_INT are the same width as int.
3534 In this code, it's OK to assume C99 behavior for ptrdiff_t formats
3535 since we're not interested in debugging glyphs with old libraries.
3536 * xfaces.c (cache_face): Move debugging code earlier; this pacifies
3537 GCC 4.6.0's static checking.
3538
0766b489
PE
35392011-06-22 Paul Eggert <eggert@cs.ucla.edu>
3540
31fd4b32
PE
3541 Integer overflow and signedness fixes (Bug#8873).
3542 A few related buffer overrun fixes, too.
3543
b79e8648
PE
3544 * font.c (font_score): Use EMACS_INT, not int, to store XINT value.
3545
0766b489
PE
3546 * dispextern.h (struct face.stipple):
3547 * image.c (x_bitmap_height, x_bitmap_width, x_bitmap_pixmap)
3548 (x_bitmap_mask, x_allocate_bitmap_record)
3549 (x_create_bitmap_from_data, x_create_bitmap_from_file)
3550 (x_destroy_bitmap, x_destroy_all_bitmaps, x_create_bitmap_mask)
3551 (x_create_bitmap_from_xpm_data):
3552 * nsterm.h (struct ns_display_info.bitmaps_size, .bitmaps_last):
3553 * w32term.h (struct w32_display_info.icon_bitmap_id, .bitmaps_size)
3554 (.bitmaps_last):
3555 * xfaces.c (load_pixmap):
3556 * xterm.c (x_bitmap_icon, x_wm_set_icon_pixmap):
3557 * xterm.h (struct x_display_info.icon_bitmap_id, .bitmaps_size)
3558 (.bitmaps_last, struct x_output.icon_bitmap):
3559 Use ptrdiff_t, not int, for bitmap indexes.
3560 (x_allocate_bitmap_record): Check for size overflow.
3561 * dispextern.h, lisp.h: Adjust to API changes elsewhere.
3562
b081724f
PE
3563 Use ptrdiff_t, not int, for overlay counts.
3564 * buffer.h (overlays_at, sort_overlays, GET_OVERLAYS_AT):
3565 * editfns.c (overlays_around, get_pos_property):
3566 * textprop.c (get_char_property_and_overlay):
3567 * xdisp.c (next_overlay_change, note_mouse_highlight):
3568 * xfaces.c (face_at_buffer_position):
21514da7
PE
3569 * buffer.c (OVERLAY_COUNT_MAX): New macro.
3570 (overlays_at, overlays_in, sort_overlays, Foverlays_at)
3571 (Fnext_overlay_change, Fprevious_overlay_change)
3572 (mouse_face_overlay_overlaps, Foverlays_in):
b081724f 3573 Use ptrdiff_t, not int, for sizes.
21514da7 3574 (overlays_at, overlays_in): Check for size-calculation overflow.
b081724f 3575
3de73e5e
PE
3576 * xterm.c (xim_initialize, same_x_server): Strlen may not fit in int.
3577
2606c57b
PE
3578 * xsmfns.c (smc_save_yourself_CB, x_session_initialize): Avoid strlen.
3579 (x_session_initialize): Do not assume string length fits in int.
3580
aaafe47a
PE
3581 * xsettings.c (apply_xft_settings): Fix potential buffer overrun.
3582 This is unlikely, but can occur if DPI is outlandish.
3583
2674ddc8 3584 * xsettings.c (Ffont_get_system_normal_font, Ffont_get_system_font):
3a5077c5
PE
3585 * xselect.c (Fx_get_atom_name): Avoid need for strlen.
3586
28154962
PE
3587 * xrdb.c: Don't assume strlen fits in int; avoid some strlens.
3588 * xrdb.c (magic_file_p, search_magic_path):
3589 Omit last arg SUFFIX; it was always 0. All callers changed.
3590 (magic_file_p): Use ptrdiff_t, not int. Check for size overflow.
3591
7de51af5
PE
3592 * xfont.c (xfont_match): Avoid need for strlen.
3593
25ed6cc3
PE
3594 * xfns.c: Don't assume strlen fits in int.
3595 (xic_create_fontsetname, x_window): Use ptrdiff_t, not int.
3596
4eab31dd
PE
3597 * xdisp.c (message_log_check_duplicate): Return intmax_t,
3598 not unsigned long, as we prefer signed integers. All callers changed.
3599 Detect integer overflow in repeat count.
3600 (message_dolog): Don't assume print length fits in 39 bytes.
df1f27af 3601 (display_mode_element): Don't assume strlen fits in int.
4eab31dd 3602
171e2a58
PE
3603 * termcap.c: Don't assume sizes fit in int and never overflow.
3604 (struct termcap_buffer, tgetent): Use ptrdiff_t, not int, for sizes.
3605 (gobble_line): Check for size-calculation overflow.
3606
ad39faca 3607 * minibuf.c (Fread_buffer):
6e5bb2dc 3608 * lread.c (intern, intern_c_string):
74ca2eb3
PE
3609 * image.c (xpm_scan) [HAVE_NS && !HAVE_XPM]:
3610 Don't assume string length fits in int.
3611
52c61c22 3612 * keyboard.c (parse_tool_bar_item):
9bda3520
PE
3613 * gtkutil.c (style_changed_cb): Avoid need for strlen.
3614
b5b8c9e5
PE
3615 * font.c: Don't assume string length fits in int.
3616 (font_parse_xlfd, font_parse_fcname, font_unparse_fcname):
3617 Use ptrdiff_t, not int.
ccd6111c
PE
3618 (font_intern_prop): Don't assume string length fits in int.
3619 Don't assume integer property fits in fixnum.
3620 * font.h (font_intern_prop): 2nd arg is now ptrdiff_t, not int.
b5b8c9e5 3621
882f0d81 3622 * filelock.c: Fix some buffer overrun and integer overflow issues.
51cab52b 3623 (get_boot_time): Don't assume gzip command string fits in 100 bytes.
882f0d81
PE
3624 Reformulate so as not to need the command string.
3625 Invoke gzip -cd rather than gunzip, as it's more portable.
3626 (lock_info_type, lock_file_1, lock_file):
3627 Don't assume pid_t and time_t fit in unsigned long.
3628 (LOCK_PID_MAX): Remove; we now use more-reliable bounds.
3629 (current_lock_owner): Prefer signed type for sizes.
3630 Use memcpy, not strncpy, where memcpy is what is really wanted.
3631 Don't assume (via atoi) that time_t and pid_t fit in int.
3632 Check for time_t and/or pid_t out of range, e.g., via a network share.
3633 Don't alloca where an auto var works fine.
3634
93f4cf88
PE
3635 * fileio.c: Fix some integer overflow issues.
3636 (file_name_as_directory, Fexpand_file_name, Fsubstitute_in_file_name):
3637 Don't assume string length fits in int.
3638 (directory_file_name): Don't assume string length fits in long.
3639 (make_temp_name): Don't assume pid fits in int, or that its print
3640 length is less than 20.
3641
f3e92b69
PE
3642 * data.c (Fsubr_name): Rewrite to avoid a strlen call.
3643
1bfdaf10
PE
3644 * coding.c (make_subsidiaries): Don't assume string length fits in int.
3645
35016e9a
PE
3646 * callproc.c (child_setup): Rewrite to avoid two strlen calls.
3647
3d1e65a1
PE
3648 * process.c (Fformat_network_address): Use EMACS_INT, not EMACS_UINT.
3649 We prefer signed integers, even for size calculations.
3650
0b963a93
PE
3651 * emacs.c: Don't assume string length fits in 'int'.
3652 (DEFINE_DUMMY_FUNCTION, sort_args): Use ptrdiff_t, not int.
3653 (main): Don't invoke strlen when not needed.
3654
573f4b54
PE
3655 * dbusbind.c (XD_ERROR): Don't arbitrarily truncate string.
3656 (XD_DEBUG_MESSAGE): Don't waste a byte.
3657
989f33ba
PE
3658 * callproc.c (getenv_internal_1, getenv_internal)
3659 (Fgetenv_internal):
965d34eb
PE
3660 * buffer.c (init_buffer): Don't assume string length fits in 'int'.
3661
e4d29b33
PE
3662 * lread.c (invalid_syntax): Omit length argument.
3663 All uses changed. This doesn't fix a bug, but it simplifies the
3664 code away from its former Hollerith-constant appearance, and it's
3665 one less 'int' to worry about when looking at integer-overflow issues.
51cab52b 3666 (string_to_number): Simplify 2011-04-26 change by invoking xsignal1.
e4d29b33 3667
eb49b136
PE
3668 * lisp.h (DEFUN): Remove bogus use of sizeof (struct Lisp_Subr).
3669 This didn't break anything, but it didn't help either.
3670 It's confusing to put a bogus integer in a place where the actual
3671 value does not matter.
9f62aeb1 3672 (LIST_END_P): Remove unused macro and its bogus comment.
cbeff735 3673 (make_fixnum_or_float): Remove unnecessary cast to EMACS_INT.
eb49b136 3674
15375a22
PE
3675 * lisp.h (union Lisp_Object.i): EMACS_INT, not EMACS_UINT.
3676 This is for consistency with the ordinary, non-USE_LISP_UNION_TYPE,
3677 implementation.
b61cc01c
PE
3678 (struct Lisp_Bool_Vector.size): EMACS_INT, not EMACS_UINT.
3679 We prefer signed types, and the value cannot exceed the EMACS_INT
3680 range anyway (because otherwise the length would not be representable).
9a8e8d9b
PE
3681 (XSET) [USE_LISP_UNION_TYPE]: Use uintptr_t and intptr_t,
3682 not EMACS_UINT and EMACS_INT, when converting pointer to integer.
3683 This avoids a GCC warning when WIDE_EMACS_INT.
15375a22 3684
53b2623d
PE
3685 * indent.c (sane_tab_width): New function.
3686 (current_column, scan_for_column, Findent_to, position_indentation)
3687 (compute_motion): Use it. This is just for clarity.
8fcaf9cc 3688 (Fcompute_motion): Don't assume hscroll and tab offset fit in int.
53b2623d 3689
51cab52b 3690 * image.c (xbm_image_p): Don't assume stated width, height fit in int.
45aebb64 3691
f2ed8a70
PE
3692 * lisp.h (lint_assume): New macro.
3693 * composite.c (composition_gstring_put_cache):
3694 * ftfont.c (ftfont_shape_by_flt): Use it to pacify GCC 4.6.0.
3695
abe80cc6
PE
3696 * editfns.c, insdel.c:
3697 Omit unnecessary forward decls, to simplify future changes.
a9e860e1 3698
b02c740e
PE
3699 * ftfont.c (ftfont_shape_by_flt): Use signed integers for lengths.
3700
ebc96716
PE
3701 * font.c (Ffont_shape_gstring): Don't assume glyph len fits in 'int'.
3702
b4e50fa0 3703 * fns.c (Ffillarray): Don't assume bool vector size fits in 'int'.
f03dc6ef 3704 Use much-faster test for byte-length change.
311d5d7c 3705 Don't assume string byte-length fits in 'int'.
a4cf38e4 3706 Check that character arg fits in 'int'.
85461888 3707 (mapcar1): Declare byte as byte, for clarity.
b4e50fa0 3708
c0c1ee9f
PE
3709 * alloc.c (Fmake_bool_vector): Avoid unnecessary multiplication.
3710
a498d7f4
PE
3711 * fns.c (concat): Catch string overflow earlier.
3712 Do not rely on integer wraparound.
3713
51cab52b
PE
3714 * dispextern.h (struct it.overlay_strings_charpos)
3715 (struct it.selective): Now EMACS_INT, not int.
87830974
PE
3716 * xdisp.c (forward_to_next_line_start)
3717 (back_to_previous_visible_line_start)
3718 (reseat_at_next_visible_line_start, next_element_from_buffer):
3719 Don't arbitrarily truncate the value of 'selective' to int.
3720
76031fad
PE
3721 * xdisp.c (init_iterator): Use XINT, not XFASTINT; it might be < 0.
3722
5eb55db9
PE
3723 * composite.c: Don't truncate sizes to 'int'.
3724 (composition_gstring_p, composition_reseat_it)
3725 (composition_adjust_point): Use EMACS_INT, not int.
7d100a81
PE
3726 (get_composition_id, composition_gstring_put_cache): Use EMACS_INT,
3727 not EMACS_UINT, for indexes.
5eb55db9 3728
0703a717
PE
3729 * category.h (CATEGORY_SET_P): Remove unnecessary cast to EMACS_INT.
3730
d6202519
PE
3731 * buffer.c: Include <verify.h>.
3732 (struct sortvec.priority, struct sortstr.priority):
8961a454 3733 Now EMACS_INT, not int.
c20998a7 3734 (compare_overlays, cmp_for_strings): Avoid subtraction overflow.
67c36fce
PE
3735 (struct sortstr.size, record_overlay_string)
3736 (struct sortstrlist.size, struct sortlist.used):
3737 Don't truncate size to int.
3738 (record_overlay_string): Check for size-calculation overflow.
d6202519 3739 (init_buffer_once): Check at compile-time, not run-time.
fadf4e30 3740
d5a19415
JM
37412011-06-22 Jim Meyering <meyering@redhat.com>
3742
029529ac 3743 Don't leak an XBM-image-sized buffer
d5a19415
JM
3744 * image.c (xbm_load): Free the image buffer after using it.
3745
a9041e6c
PE
37462011-06-21 Paul Eggert <eggert@cs.ucla.edu>
3747
3748 Port to Sun C.
3749 * composite.c (find_automatic_composition): Omit needless 'return 0;'
3750 that Sun C diagnosed.
3751 * fns.c (secure_hash): Fix pointer signedness issue.
3752 * intervals.c (static_offset_intervals): New function.
3753 (offset_intervals): Use it.
3754
7f3f739f
LL
37552011-06-21 Leo Liu <sdl.web@gmail.com>
3756
3757 * deps.mk (fns.o):
3758 * makefile.w32-in ($(BLD)/fns.$(O)): Include sha256.h and
3759 sha512.h.
3760
3761 * fns.c (secure_hash): Rename from crypto_hash_function and change
3762 the first arg to accept symbols.
5b66d427 3763 (Fsecure_hash): New primitive.
7f3f739f
LL
3764 (syms_of_fns): New symbols.
3765
76147d94
DD
37662011-06-20 Deniz Dogan <deniz@dogan.se>
3767
3768 * process.c (Fset_process_buffer): Clarify return value in
3769 docstring.
3770
7d7d0045
CY
37712011-06-18 Chong Yidong <cyd@stupidchicken.com>
3772
3773 * dispnew.c (add_window_display_history): Use BVAR.
3774
3775 * xdisp.c (debug_method_add): Use BVAR.
3776 (check_window_end, dump_glyph_matrix, dump_glyph)
3777 (dump_glyph_row, dump_glyph_string): Convert arglist to ANSI C.
3778
3779 * xfaces.c (check_lface_attrs, check_lface, dump_realized_face):
3780 Likewise.
3781
3782 * xfns.c (Fx_create_frame, x_create_tip_frame): Delay image cache
3783 check till after the cache is created in init_frame_faces.
3784
ff2bc410
SM
37852011-06-17 Stefan Monnier <monnier@iro.umontreal.ca>
3786
3787 * fns.c (Fsafe_length): Yet another int/Lisp_Object mixup.
3788
28177add
PE
37892011-06-16 Paul Eggert <eggert@cs.ucla.edu>
3790
dd3482fe
PE
3791 * lisp.h: Include <limits.h>, for INT_MAX, LONG_MAX, LLONG_MAX.
3792 Without this, prin1 mishandles Lisp_Misc_Save_Value printing on
3793 hosts with pre-C99 libraries, because pD is wrongly defined to "t".
3794
393d71f3 3795 Improve buffer-overflow checking (Bug#8873).
1c8e352f
PE
3796 * fileio.c (Finsert_file_contents):
3797 * insdel.c (insert_from_buffer_1, replace_range, replace_range_2):
3798 Remove the old (too-loose) buffer overflow checks.
3799 They weren't needed, since make_gap checks for buffer overflow.
3800 * insdel.c (make_gap_larger): Catch buffer overflows that were missed.
3801 The old code merely checked for Emacs fixnum overflow, and relied
3802 on undefined (wraparound) behavior. The new code avoids undefined
3803 behavior, and also checks for ptrdiff_t and/or size_t overflow.
3804
2e6813b0 3805 * editfns.c (Finsert_char): Don't dump core with very negative counts.
21d890a4
PE
3806 Tune. Don't use wider integers than needed. Don't use alloca.
3807 Use a bigger 'string' buffer. Rewrite to avoid 'n > 0' test.
2e6813b0 3808
599a9e4f
PE
3809 * insdel.c (replace_range): Fix buf overflow when insbytes < outgoing.
3810
99561444
PE
3811 * insdel.c, lisp.h (buffer_overflow): New function.
3812 (insert_from_buffer_1, replace_range, replace_range_2):
3813 * insdel.c (make_gap_larger):
3814 * editfns.c (Finsert_char):
3815 * fileio.c (Finsert_file_contents): Use it, to normalize wording.
3816
28177add
PE
3817 * buffer.h (BUF_BYTES_MAX): Cast to ptrdiff_t so that it's signed.
3818
e69dafad
PE
38192011-06-15 Paul Eggert <eggert@cs.ucla.edu>
3820
a7af7fde 3821 Integer overflow and signedness fixes (Bug#8873).
ff672d2c 3822
b1c46f02
PE
3823 * ccl.c (ASCENDING_ORDER): New macro, to work around GCC bug 43772.
3824 (GET_CCL_RANGE, IN_INT_RANGE): Use it.
3825
e69dafad
PE
3826 * fileio.c: Don't assume EMACS_INT fits in off_t.
3827 (emacs_lseek): New static function.
3828 (Finsert_file_contents, Fwrite_region): Use it.
3829 Use SEEK_SET, SEEK_CUR, SEEK_END as appropriate.
3830
566684ea
PE
3831 * fns.c (Fload_average): Don't assume 100 * load average fits in int.
3832
e6966cd6
PE
3833 * fns.c: Don't overflow int when computing a list length.
3834 * fns.c (QUIT_COUNT_HEURISTIC): New constant.
3835 (Flength, Fsafe_length): Use EMACS_INT, not int, to avoid unwanted
3836 truncation on 64-bit hosts. Check for QUIT every
3837 QUIT_COUNT_HEURISTIC entries rather than every other entry; that's
3838 faster and is responsive enough.
3839 (Flength): Report an error instead of overflowing an integer.
3840 (Fsafe_length): Return a float if the value is not representable
3841 as a fixnum. This shouldn't happen except in contrived situations.
6346d301 3842 (Fnthcdr, Fsort): Don't assume list length fits in int.
de41a810 3843 (Fcopy_sequence): Don't assume vector length fits in int.
00c604f2 3844
dd0b0efb
PE
3845 * alloc.c: Check that resized vectors' lengths fit in fixnums.
3846 (header_size, word_size): New constants.
3847 (allocate_vectorlike): Don't check size overflow here.
3848 (allocate_vector): Check it here instead, since this is the only
3849 caller of allocate_vectorlike that could cause overflow.
3850 Check that the new vector's length is representable as a fixnum.
3851
86fe5cfe
PE
3852 * fns.c (next_almost_prime): Don't return a multiple of 3 or 5.
3853 The previous code was bogus. For example, next_almost_prime (32)
3854 returned 39, which is undesirable as it is a multiple of 3; and
3855 next_almost_prime (24) returned 25, which is a multiple of 5 so
3856 why was the code bothering to check for multiples of 7?
3857
80e88859
PE
3858 * bytecode.c (exec_byte_code): Use ptrdiff_t, not int, for vector length.
3859
4a2f0ad6
PE
3860 * eval.c, doprnt.c (SIZE_MAX): Remove; inttypes.h defines this now.
3861
f66c7cf8
PE
3862 Variadic C functions now count arguments with ptrdiff_t.
3863 This partly undoes my 2011-03-30 change, which replaced int with size_t.
3864 Back then I didn't know that the Emacs coding style prefers signed int.
3865 Also, in the meantime I found a few more instances where arguments
4a2f0ad6
PE
3866 were being counted with int, which may truncate counts on 64-bit
3867 machines, or EMACS_INT, which may be unnecessarily wide.
f66c7cf8
PE
3868 * lisp.h (struct Lisp_Subr.function.aMANY)
3869 (DEFUN_ARGS_MANY, internal_condition_case_n, safe_call):
3870 Arg counts are now ptrdiff_t, not size_t.
3871 All variadic functions and their callers changed accordingly.
3872 (struct gcpro.nvars): Now size_t, not size_t. All uses changed.
3873 * bytecode.c (exec_byte_code): Check maxdepth for overflow,
3874 to avoid potential buffer overrun. Don't assume arg counts fit in 'int'.
3875 * callint.c (Fcall_interactively): Check arg count for overflow,
3876 to avoid potential buffer overrun. Use signed char, not 'int',
3877 for 'varies' array, so that we needn't bother to check its size
3878 calculation for overflow.
3879 * editfns.c (Fformat): Use ptrdiff_t, not EMACS_INT, to count args.
3880 * eval.c (apply_lambda):
3881 * fns.c (Fmapconcat): Use XFASTINT, not XINT, to get args length.
3882 (struct textprop_rec.argnum): Now ptrdiff_t, not int. All uses changed.
3883 (mapconcat): Use ptrdiff_t, not int and EMACS_INT, to count args.
3884
a1759b76
PE
3885 * callint.c (Fcall_interactively): Don't use index var as event count.
3886
d96be9fc
PE
3887 * vm-limit.c (check_memory_limits): Fix incorrect extern function decls.
3888 * mem-limits.h (SIZE): Remove; no longer used.
3889
a690a978 3890 * xterm.c (x_alloc_nearest_color_1): Prefer int to long when int works.
5efd304b 3891
578c21e6
PE
3892 Remove unnecessary casts.
3893 * xterm.c (x_term_init):
3894 * xfns.c (x_set_border_pixel):
3895 * widget.c (create_frame_gcs): Remove casts to unsigned long etc.
3896 These aren't needed now that we assume ANSI C.
3897
96f53c6c
PE
3898 * sound.c (Fplay_sound_internal): Remove cast to unsigned long.
3899 It's more likely to cause problems (due to unsigned overflow)
3900 than to cure them.
3901
83c77d31
PE
3902 * dired.c (Ffile_attributes): Don't use 32-bit hack on 64-bit hosts.
3903
ee2079f1
PE
3904 * unexelf.c (unexec): Don't assume BSS addr fits in unsigned.
3905
6da65536
PE
3906 * xterm.c (handle_one_xevent): Omit unnecessary casts to unsigned.
3907
7147c4a4
PE
3908 * keyboard.c (modify_event_symbol): Don't limit alist len to UINT_MAX.
3909
193e32d9
PE
3910 * lisp.h (CHAR_TABLE_SET): Omit now-redundant test.
3911
e5533da6
PE
3912 * lread.c (Fload): Don't compare a possibly-garbage time_t value.
3913
9910e595
PE
3914 GLYPH_CODE_FACE returns EMACS_INT, not int.
3915 * dispextern.h (merge_faces):
3916 * xfaces.c (merge_faces):
01103c44
PE
3917 * xdisp.c (get_next_display_element, next_element_from_display_vector):
3918 Don't assume EMACS_INT fits in int.
9910e595 3919
2638320e
PE
3920 * character.h (CHAR_VALID_P): Remove unused parameter.
3921 * fontset.c, lisp.h, xdisp.c: All uses changed.
3922
045eb8d9
PE
3923 * editfns.c (Ftranslate_region_internal): Omit redundant test.
3924
c1f134b5
PE
3925 * fns.c (concat): Minor tuning based on overflow analysis.
3926 This doesn't fix any bugs. Use int to hold character, instead
3927 of constantly refetching from Emacs object. Use XFASTINT, not
3928 XINT, for value known to be a character. Don't bother comparing
3929 a single byte to 0400, as it's always less.
3930
395fcb93 3931 * floatfns.c (Fexpt):
327eeec8
PE
3932 * fileio.c (make_temp_name): Omit unnecessary cast to unsigned.
3933
abbd3d23
PE
3934 * editfns.c (Ftranslate_region_internal): Use int, not EMACS_INT
3935 for characters.
3936
684a03ef
PE
3937 * doc.c (get_doc_string): Omit (unsigned)c that mishandled negatives.
3938
0fed43f3
PE
3939 * data.c (Faset): If ARRAY is a string, check that NEWELT is a char.
3940 Without this fix, on a 64-bit host (aset S 0 4294967386) would
3941 incorrectly succeed when S was a string, because 4294967386 was
3942 truncated before it was used.
3943
8fd02eb7
PE
3944 * chartab.c (Fchar_table_range): Use CHARACTERP to check range.
3945 Otherwise, an out-of-range integer could cause undefined behavior
3946 on a 64-bit host.
3947
f8c86b69
PE
3948 * composite.c: Use int, not EMACS_INT, for characters.
3949 (fill_gstring_body, composition_compute_stop_pos): Use int, not
3950 EMACS_INT, for values that are known to be in character range.
3951 This doesn't fix any bugs but is the usual style inside Emacs and
3952 may generate better code on 32-bit machines.
3953
34206dd2
PE
3954 Make sure a 64-bit char is never passed to ENCODE_CHAR.
3955 This is for reasons similar to the recent CHAR_STRING fix.
3956 * charset.c (Fencode_char): Check that character arg is actually
3957 a character. Pass an int to ENCODE_CHAR.
3958 * charset.h (ENCODE_CHAR): Verify that the character argument is no
3959 wider than 'int', as a compile-time check to prevent future regressions
3960 in this area.
3961
c5958d4c 3962 * character.c (char_string): Remove unnecessary casts.
13bdea59
PE
3963
3964 Make sure a 64-bit char is never passed to CHAR_STRING.
3965 Otherwise, CHAR_STRING would do the wrong thing on a 64-bit platform,
3966 by silently ignoring the top 32 bits, allowing some values
3967 that were far too large to be valid characters.
3968 * character.h: Include <verify.h>.
3969 (CHAR_STRING, CHAR_STRING_ADVANCE): Verify that the character
3970 arguments are no wider than unsigned, as a compile-time check
3971 to prevent future regressions in this area.
3972 * data.c (Faset):
01103c44 3973 * editfns.c (Fchar_to_string, general_insert_function, Finsert_char)
13bdea59
PE
3974 (Fsubst_char_in_region):
3975 * fns.c (concat):
3976 * xdisp.c (decode_mode_spec_coding):
3977 Adjust to CHAR_STRING's new requirement.
3978 * editfns.c (Finsert_char, Fsubst_char_in_region):
3979 * fns.c (concat): Check that character args are actually
3980 characters. Without this test, these functions did the wrong
3981 thing with wildly out-of-range values on 64-bit hosts.
3982
d37ca623
PE
3983 Remove incorrect casts to 'unsigned' that lose info on 64-bit hosts.
3984 These casts should not be needed on 32-bit hosts, either.
3985 * keyboard.c (read_char):
3986 * lread.c (Fload): Remove casts to unsigned.
3987
ea204efb
PE
3988 * lisp.h (UNSIGNED_CMP): New macro.
3989 This fixes comparison bugs on 64-bit hosts.
3990 (ASCII_CHAR_P): Use it.
3991 * casefiddle.c (casify_object):
01103c44 3992 * character.h (ASCII_BYTE_P, CHAR_VALID_P)
ea204efb
PE
3993 (SINGLE_BYTE_CHAR_P, CHAR_STRING):
3994 * composite.h (COMPOSITION_ENCODE_RULE_VALID):
3995 * dispextern.h (FACE_FROM_ID):
3996 * keyboard.c (read_char): Use UNSIGNED_CMP.
3997
41cb286c
PE
3998 * xmenu.c (dialog_selection_callback) [!USE_GTK]: Cast to intptr_t,
3999 not to EMACS_INT, to avoid GCC warning.
4000
4a1b9832
PE
4001 * xfns.c (x_set_scroll_bar_default_width): Remove unused 'int' locals.
4002
55daad71
PE
4003 * buffer.h (PTR_BYTE_POS, BUF_PTR_BYTE_POS): Remove harmful cast.
4004 The cast incorrectly truncated 64-bit byte offsets to 32 bits, and
4005 isn't needed on 32-bit machines.
8f95c75c 4006
01103c44
PE
4007 * buffer.c (Fgenerate_new_buffer_name):
4008 Use EMACS_INT for count, not int.
0ceccced 4009 (advance_to_char_boundary): Return EMACS_INT, not int.
e762cafe
PE
4010
4011 * data.c (Qcompiled_function): Now static.
4012
c6f072e7
PE
4013 * window.c (window_body_lines): Now static.
4014
20ce5912
PE
4015 * image.c (gif_load): Rename local to avoid shadowing.
4016
9c4c5f81
PE
4017 * lisp.h (SAFE_ALLOCA_LISP): Check for integer overflow.
4018 (struct Lisp_Save_Value): Use ptrdiff_t, not int, for 'integer' member.
4019 * alloc.c (make_save_value): Integer argument is now of type
4020 ptrdiff_t, not int.
4021 (mark_object): Use ptrdiff_t, not int.
4022 * lisp.h (pD): New macro.
4023 * print.c (print_object): Use it.
4024
c0c5c8ae
PE
4025 * alloc.c: Use EMACS_INT, not int, to count objects.
4026 (total_conses, total_markers, total_symbols, total_vector_size)
4027 (total_free_conses, total_free_markers, total_free_symbols)
01103c44
PE
4028 (total_free_floats, total_floats, total_free_intervals)
4029 (total_intervals, total_strings, total_free_strings):
c0c5c8ae
PE
4030 Now EMACS_INT, not int. All uses changed.
4031 (Fgarbage_collect): Compute overall total using a double, so that
4032 integer overflow is less likely to be a problem. Check for overflow
4033 when converting back to an integer.
5a25e253
PE
4034 (n_interval_blocks, n_string_blocks, n_float_blocks, n_cons_blocks)
4035 (n_vectors, n_symbol_blocks, n_marker_blocks): Remove.
4036 These were 'int' variables that could overflow on 64-bit hosts;
4037 they were never used, so remove them instead of repairing them.
211a0b2a 4038 (nzombies, ngcs, max_live, max_zombies): Now EMACS_INT, not 'int'.
6349ae4d
PE
4039 (inhibit_garbage_collection): Set gc_cons_threshold to max value.
4040 Previously, this ceilinged at INT_MAX, but that doesn't work on
4041 64-bit machines.
e46bb31a 4042 (allocate_pseudovector): Don't use EMACS_INT when int would do.
c0c5c8ae 4043
c78baabf 4044 * alloc.c (Fmake_bool_vector): Don't assume vector size fits in int.
86f61a15 4045 (allocate_vectorlike): Check for ptrdiff_t overflow.
b6439961
PE
4046 (mark_vectorlike, mark_char_table, mark_object): Avoid EMACS_UINT
4047 when a (possibly-narrower) signed value would do just as well.
4048 We prefer using signed arithmetic, to avoid comparison confusion.
c78baabf 4049
c9d624c6
PE
4050 * alloc.c: Catch some string size overflows that we were missing.
4051 (XMALLOC_OVERRUN_CHECK_SIZE) [!XMALLOC_OVERRUN_CHECK]: Define to 0,
4052 for convenience in STRING_BYTES_MAX.
4053 (STRING_BYTES_MAX): New macro, superseding the old one in lisp.h.
4054 The definition here is exact; the one in lisp.h was approximate.
4055 (allocate_string_data): Check for string overflow. This catches
4056 some instances we weren't catching before. Also, it catches
4057 size_t overflow on (unusual) hosts where SIZE_MAX <= min
4058 (PTRDIFF_MAX, MOST_POSITIVE_FIXNUM), e.g., when size_t is 32 bits
4059 and ptrdiff_t and EMACS_INT are both 64 bits.
c78baabf 4060
c9d624c6
PE
4061 * character.c, coding.c, doprnt.c, editfns.c, eval.c:
4062 All uses of STRING_BYTES_MAX replaced by STRING_BYTES_BOUND.
640c8776 4063 * lisp.h (STRING_BYTES_BOUND): Rename from STRING_BYTES_MAX.
c9d624c6 4064
353032ce
PE
4065 * character.c (string_escape_byte8): Fix nbytes/nchars typo.
4066
2bccce07
PE
4067 * alloc.c (Fmake_string): Check for out-of-range init.
4068
0ac30604
SM
40692011-06-15 Stefan Monnier <monnier@iro.umontreal.ca>
4070
4071 * eval.c (Fdefvaralias): Also mark the target as variable-special-p.
4072
c195f2de
JD
40732011-06-14 Jan Djärv <jan.h.d@swipnet.se>
4074
4075 * xfns.c (x_set_scroll_bar_default_width): Remove argument to
4076 xg_get_default_scrollbar_width.
4077
4078 * gtkutil.c: Include emacsgtkfixed.h if HAVE_GTK3.
4079 (int_gtk_range_get_value): Move to the scroll bar part of the file.
4080 (style_changed_cb): Call update_theme_scrollbar_width and call
4081 x_set_scroll_bar_default_width and xg_frame_set_char_size for
4082 all frames (Bug#8505).
4083 (xg_create_frame_widgets): Call emacs_fixed_new if HAVE_GTK3 (Bug#8505).
4084 Call gtk_window_set_resizable if HAVE_GTK3.
4085 (x_wm_set_size_hint): Call emacs_fixed_set_min_size with min width
4086 and height if HAVE_GTK3 (Bug#8505).
4087 (scroll_bar_width_for_theme): New variable.
4088 (update_theme_scrollbar_width): New function.
4089 (xg_get_default_scrollbar_width): Move code to
4090 update_theme_scrollbar_width, just return scroll_bar_width_for_theme.
4091 (xg_initialize): Call update_theme_scrollbar_width.
4092
4093 * gtkutil.h (xg_get_default_scrollbar_width): Remove argument.
4094
4095 * emacsgtkfixed.c, emacsgtkfixed.h: New files.
4096
e10ac9f1
MR
40972011-06-12 Martin Rudalics <rudalics@gmx.at>
4098
4099 * frame.c (make_frame): Call other_buffer_safely instead of
4100 other_buffer.
4101
4102 * window.c (temp_output_buffer_show): Call display_buffer with
4103 second argument Vtemp_buffer_show_specifiers and reset latter
4104 immediately after the call.
4105 (Vtemp_buffer_show_specifiers): New variable.
4106 (auto_window_vscroll_p, next_screen_context_lines)
4107 (Vscroll_preserve_screen_position): Remove leading asterisks from
4108 doc-strings.
4109
2d3c217e 41102011-06-12 Paul Eggert <eggert@cs.ucla.edu>
4475bec4 4111
7b7f97e8 4112 Fix minor problems found by GCC 4.6.0 static checking.
4475bec4
PE
4113 * buffer.c (Qclone_number): Remove for now, as it's unused.
4114 (record_buffer, Funrecord_buffer): Rename local to avoid shadowing.
4115 (record_buffer): Remove unused local.
4116 * frame.c (other_visible_frames, frame_buffer_list): Now static.
4117 (set_frame_buffer_list): Remove; unused.
4118 * frame.h (other_visible_frames): Remove decl.
4119 * keyboard.h (menu_items_inuse): Declare only if USE_GTK || USE_MOTIF.
4120 * lisp.h (frame_buffer_list, set_frame_buffer_list): Remove decls.
4121 (add_gpm_wait_descriptor, delete_gpm_wait_descriptor): Declare only
4122 if HAVE_GPM.
4123 * menu.c (menu_items_inuse): Now static unless USE_GTK || USE_MOTIF.
4124 * process.c (add_gpm_wait_descriptor, delete_gpm_wait_descriptor):
4125 Define only if HAVE_GPM.
4126 * widget.c (EmacsFrameResize, emacsFrameClassRec): Now static.
4127 (update_hints_inhibit): Remove; never set. All uses removed.
4128 * widgetprv.h (emacsFrameClassRec): Remove decl.
4129 * window.c (delete_deletable_window): Now returns void, since it
4130 wasn't returning anything.
4131 (compare_window_configurations): Remove unused locals.
4132 * xfns.c (x_set_scroll_bar_default_width): Remove unused locals.
4133 * xmenu.c (x_menu_set_in_use): Define only if USE_GTK || USE_MOTIF.
4475bec4
PE
4134 (dialog_selection_callback) [!USE_GTK]: Prefer intptr_t for integers
4135 the same widths as pointers. This follows up on the 2011-05-06 patch.
4136 * xterm.c (x_alloc_lighter_color_for_widget): Define only if USE_LUCID.
4137 * xterm.h: Likewise.
4138 (x_menu_set_in_use): Declare only if USE_GTK || USE_MOTIF.
4139
1384b89e
JB
41402011-06-12 Juanma Barranquero <lekktu@gmail.com>
4141
4142 * makefile.w32-in: Update dependencies.
4143 (LISP_H): Add lib/intprops.h.
4144
1100a63c
CY
41452011-06-11 Chong Yidong <cyd@stupidchicken.com>
4146
4147 * image.c (gif_load): Add animation frame delay to the metadata.
4148 (syms_of_image): Use DEFSYM. New symbol `delay'.
4149
6198ccd0
MR
41502011-06-11 Martin Rudalics <rudalics@gmx.at>
4151
4152 * window.c (delete_deletable_window): Re-add.
4153 (Fset_window_configuration): Rewrite to handle dead buffers and
4154 consequently deletable windows.
4155 (window_tree, Fwindow_tree): Remove. Supply functionality in
4156 window.el.
4157 (compare_window_configurations): Simplify code.
4158
b6e3633c
AS
41592011-06-11 Andreas Schwab <schwab@linux-m68k.org>
4160
1ab0dee5
AS
4161 * image.c (imagemagick_load_image): Fix type mismatch.
4162 (Fimagemagick_types): Likewise.
4163
b6e3633c
AS
4164 * window.h (replace_buffer_in_windows): Declare.
4165
9397e56f
MR
41662011-06-11 Martin Rudalics <rudalics@gmx.at>
4167
4168 * buffer.c: New Lisp objects Qbuffer_list_update_hook and
4169 Qclone_number. Remove external declaration of Qdelete_window.
4170 (Fbuffer_list): Rewrite doc-string. Minor restructuring of
4171 code.
640c8776
SM
4172 (Fget_buffer_create, Fmake_indirect_buffer, Frename_buffer):
4173 Run Qbuffer_list_update_hook if allowed.
9397e56f
MR
4174 (Fother_buffer): Rewrite doc-string. Major rewrite for new
4175 buffer list implementation.
4176 (other_buffer_safely): New function.
4177 (Fkill_buffer): Replace call to replace_buffer_in_all_windows by
4178 calls to replace_buffer_in_windows and
4179 replace_buffer_in_windows_safely. Run Qbuffer_list_update_hook
4180 if allowed.
4181 (record_buffer): Inhibit quitting and rewrite using quittable
4182 functions. Run Qbuffer_list_update_hook if allowed.
4183 (Frecord_buffer, Funrecord_buffer): New functions.
640c8776
SM
4184 (switch_to_buffer_1, Fswitch_to_buffer): Remove.
4185 Move switch-to-buffer to window.el.
9397e56f
MR
4186 (bury-buffer): Move to window.el.
4187 (Vbuffer_list_update_hook): New variable.
4188
4189 * lisp.h (other_buffer_safely): Add prototype in buffer.c
4190 section.
4191
4192 * window.h (resize_frame_windows): Move up in code.
4193 (Fwindow_frame): Remove EXFUN.
4194 (replace_buffer_in_all_windows): Remove prototype.
4195 (replace_buffer_in_windows_safely): Add prototype.
4196
4197 * window.c: Declare Qdelete_window static again. Move down
4198 declaration of select_count.
4199 (Fnext_window, Fprevious_window): Rewrite doc-strings.
4200 (Fother_window): Move to window.el.
4201 (window_loop): Remove DELETE_BUFFER_WINDOWS and UNSHOW_BUFFER
4202 cases. Add REPLACE_BUFFER_IN_WINDOWS_SAFELY case.
4203 (Fdelete_windows_on, Freplace_buffer_in_windows): Move to
4204 window.el.
4205 (replace_buffer_in_windows): Implement by calling
4206 Qreplace_buffer_in_windows.
4207 (replace_buffer_in_all_windows): Remove with some functionality
4208 moved into replace_buffer_in_windows_safely.
4209 (replace_buffer_in_windows_safely): New function.
4210 (select_window_norecord, select_frame_norecord): Move in front
4211 of run_window_configuration_change_hook. Remove now obsolete
4212 declarations.
640c8776
SM
4213 (Fset_window_buffer): Rewrite doc-string.
4214 Call Qrecord_window_buffer.
9397e56f
MR
4215 (keys_of_window): Move binding for other-window to window.el.
4216
b50691aa
CY
42172011-06-11 Chong Yidong <cyd@stupidchicken.com>
4218
4219 * dispextern.h (struct image): Replace data member, whose int_val
4220 and ptr_val fields were not used by anything, with a single
4221 lisp_val object.
4222
4223 * image.c (Fimage_metadata, make_image, mark_image, tiff_load)
4224 (gif_clear_image, gif_load, imagemagick_load_image)
4225 (gs_clear_image, gs_load): Callers changed.
4226
3f754b86
PE
42272011-06-10 Paul Eggert <eggert@cs.ucla.edu>
4228
cca69397
PE
4229 * buffer.h: Include <time.h>, for time_t.
4230 Needed to build on FreeBSD 8.2. Problem reported by Herbert J. Skuhra.
4231
109e28d0
PE
4232 Fix minor problems found by static checking.
4233
60737f02
PE
4234 * image.c (PixelGetMagickColor): Declare if ImageMagick headers don't.
4235
4b66faf3
PE
4236 Make identifiers static if they are not used in other modules.
4237 * data.c (Qcompiled_function, Qframe, Qvector):
4238 * image.c (QimageMagick, Qsvg):
4239 * minibuf.c (Qmetadata):
4240 * window.c (resize_window_check, resize_root_window): Now static.
4241 * window.h (resize_window_check, resize_root_window): Remove decls.
4242
109e28d0
PE
4243 * window.c (window_deletion_count, delete_deletable_window):
4244 Remove; unused.
46a4ce9e
PE
4245 (window_body_lines): Now static.
4246 (Fdelete_other_windows_internal): Mark vars as initialized.
4247 Make sure 'resize_failed' is initialized.
4248 (run_window_configuration_change_hook): Rename local to avoid shadowing.
4249 (resize_window_apply): Remove unused local.
4250 * window.h (delete_deletable_window): Remove decl.
4251
109e28d0 4252 * image.c (gif_load, svg_load_image): Rename locals to avoid shadowing.
33290528
PE
4253 (imagemagick_load_image): Fix pointer signedness problem by changing
4254 last arg from unsigned char * to char *. All uses changed.
4255 Also, fix a local for similar reasons.
4256 Remove unused locals. Remove locals to avoid shadowing.
4257 (fn_rsvg_handle_free): Remove; unused.
4258 (svg_load, svg_load_image): Fix pointer signedness problem.
f7e13da3 4259 (imagemagick_load_image): Don't use garbage pointer image_wand.
33290528 4260
3f754b86
PE
4261 * ftfont.c (ftfont_get_metrics, ftfont_drive_otf): Remove unused locals.
4262
2547adb1
CY
42632011-06-10 Chong Yidong <cyd@stupidchicken.com>
4264
4265 * image.c (gif_load): Fix omitted cast error introduced by
4266 2011-06-06 change.
4267
2c8e37d4
MR
42682011-06-10 Martin Rudalics <rudalics@gmx.at>
4269
4270 * window.h (resize_proportionally, orig_total_lines)
4271 (orig_top_line): Remove from window structure.
4272 (set_window_height, set_window_width, change_window_heights)
4273 (Fdelete_window): Remove prototypes.
4274 (resize_frame_windows): Remove duplicate declaration.
4275
440a42e3
EZ
42762011-06-10 Eli Zaretskii <eliz@gnu.org>
4277
4278 * window.h (resize_frame_windows, resize_window_check)
4279 (delete_deletable_window, resize_root_window)
4280 (resize_frame_windows): Declare prototypes.
4281
4282 * window.c (resize_window_apply): Make definition be "static" to
4283 match the prototype.
4284
562dd5e9
MR
42852011-06-10 Martin Rudalics <rudalics@gmx.at>
4286
4287 * window.c: Remove declarations of Qwindow_size_fixed,
4288 window_min_size_1, window_min_size_2, window_min_size,
4289 size_window, window_fixed_size_p, enlarge_window, delete_window.
4290 Remove static from declaration of Qdelete_window, it's
4291 temporarily needed by Fbury_buffer.
4292 (replace_window): Don't assign orig_top_line and
4293 orig_total_lines.
4294 (Fdelete_window, delete_window): Remove. Window deletion is
4295 handled by window.el.
640c8776
SM
4296 (window_loop): Remove DELETE_OTHER_WINDOWS case.
4297 Replace Fdelete_window calls with calls to Qdelete_window.
562dd5e9
MR
4298 (Fdelete_other_windows): Remove. Deleting other windows is
4299 handled by window.el.
4300 (window_fixed_size_p): Remove. Fixed-sizeness of windows is
4301 handled in window.el.
4302 (window_min_size_2, window_min_size_1, window_min_size): Remove.
4303 Window minimum sizes are handled in window.el.
4304 (shrink_windows, size_window, set_window_height)
4305 (set_window_width, change_window_heights, window_height)
4306 (window_width, CURBEG, CURSIZE, enlarge_window)
4307 (adjust_window_trailing_edge, Fadjust_window_trailing_edge)
4308 (Fenlarge_window, Fshrink_window): Remove. Window resizing is
4309 handled in window.el.
4310 (make_dummy_parent): Rename to make_parent_window and give it a
4311 second argument horflag.
4312 (make_window): Don't set resize_proportionally any more.
4313 (Fsplit_window): Remove. Windows are split in window.el.
4314 (save_restore_action, save_restore_orig_size)
4315 (shrink_window_lowest_first, save_restore_orig_size): Remove.
4316 Resize mini windows in window.el.
4317 (grow_mini_window, shrink_mini_window): Implement by calling
4318 Qresize_root_window_vertically, resize_window_check and
4319 resize_window_apply.
640c8776
SM
4320 (saved_window, Fset_window_configuration, save_window_save):
4321 Do not handle orig_top_line, orig_total_lines, and
562dd5e9
MR
4322 resize_proportionally.
4323 (window_min_height, window_min_width): Move to window.el.
4324 (keys_of_window): Move bindings for delete-other-windows,
4325 split-window, delete-window and enlarge-window to window.el.
4326
4327 * buffer.c: Temporarily extern Qdelete_window.
4328 (Fbury_buffer): Temporarily call Qdelete_window instead of
4329 Fdelete_window (Fbury_buffer will move to window.el soon).
4330
4331 * frame.c (set_menu_bar_lines_1): Remove code handling
4332 orig_top_line and orig_total_lines.
4333
4334 * dispnew.c (adjust_frame_glyphs_initially): Don't use
4335 set_window_height but set heights directly.
4336 (change_frame_size_1): Use resize_frame_windows.
4337
4338 * xdisp.c (init_xdisp): Don't use set_window_height but set
4339 heights directly.
4340
640c8776
SM
4341 * xfns.c (x_set_menu_bar_lines, x_set_tool_bar_lines):
4342 Use resize_frame_windows instead of change_window_heights and run
562dd5e9
MR
4343 run_window_configuration_change_hook.
4344
4345 * w32fns.c (x_set_tool_bar_lines): Use resize_frame_windows
4346 instead of change_window_heights and run
4347 run_window_configuration_change_hook.
4348
1a13852e
MR
43492011-06-09 Martin Rudalics <rudalics@gmx.at>
4350
4351 * window.c (replace_window): Rename second argument REPLACEMENT to
4352 NEW. New third argument SETFLAG. Rewrite.
4353 (delete_window, make_dummy_parent): Call replace_window with
4354 third argument 1.
4355 (window_list_1): Move down in code.
4356 (run_window_configuration_change_hook): Move set_buffer part
4357 before select_frame_norecord part in order to unwind correctly.
4358 Rename count1 to count.
4359 (recombine_windows, delete_deletable_window, resize_root_window)
4360 (Fdelete_other_windows_internal)
4361 (Frun_window_configuration_change_hook, make_parent_window)
4362 (resize_window_check, resize_window_apply, Fresize_window_apply)
4363 (resize_frame_windows, Fsplit_window_internal)
640c8776
SM
4364 (Fdelete_window_internal, Fresize_mini_window_internal):
4365 New functions.
1a13852e
MR
4366 (syms_of_window): New variables Vwindow_splits and Vwindow_nest.
4367
f3d1777e
MR
43682011-06-08 Martin Rudalics <rudalics@gmx.at>
4369
496e208e
MR
4370 * window.h (window): Add some new members to window structure -
4371 normal_lines, normal_cols, new_total, new_normal, clone_number,
4372 splits, nest, prev_buffers, next_buffers.
4373 (WINDOW_TOTAL_SIZE): Move here from window.c.
b9e809c2 4374 (MIN_SAFE_WINDOW_WIDTH, MIN_SAFE_WINDOW_HEIGHT): Define here.
496e208e 4375
f3d1777e
MR
4376 * window.c (Fwindow_height, Fwindow_width, Fwindow_full_width_p):
4377 Remove.
496e208e
MR
4378 (make_dummy_parent): Set new members of windows structure.
4379 (make_window): Move down in code. Handle new members of window
4380 structure.
4381 (Fwindow_clone_number, Fwindow_splits, Fset_window_splits)
4382 (Fwindow_nest, Fset_window_nest, Fwindow_new_total)
4383 (Fwindow_normal_size, Fwindow_new_normal, Fwindow_prev_buffers)
4384 (Fset_window_prev_buffers, Fwindow_next_buffers)
640c8776
SM
4385 (Fset_window_next_buffers, Fset_window_clone_number):
4386 New functions.
496e208e
MR
4387 (Fwindow_hscroll, Fwindow_at, Fwindow_point, Fwindow_start)
4388 (Fwindow_end, Fwindow_line_height, Fset_window_dedicated_p):
4389 Doc-string fixes.
4390 (Fwindow_parameters, Fwindow_parameter, Fset_window_parameter):
4391 Argument WINDOW can be now internal window too.
4392 (Fwindow_use_time): Move up in code.
4393 (Fget_buffer_window): Rename argument FRAME to ALL-FRAMES.
4394 Rewrite doc-string.
4395 (Fset_window_configuration, saved_window)
4396 (Fcurrent_window_configuration, save_window_save): Handle new
4397 members of window structure.
b9e809c2
MR
4398 (WINDOW_TOTAL_SIZE, MIN_SAFE_WINDOW_WIDTH)
4399 (MIN_SAFE_WINDOW_HEIGHT): Move to window.h.
4400 (syms_of_window): New Lisp objects Qrecord_window_buffer,
4401 Qwindow_deletable_p, Qdelete_window, Qreplace_buffer_in_windows,
4402 Qget_mru_window, Qresize_root_window,
4403 Qresize_root_window_vertically, Qsafe, Qabove, Qbelow,
4404 Qauto_buffer_name; staticpro them.
f3d1777e 4405
abde8f8c
MR
44062011-06-07 Martin Rudalics <rudalics@gmx.at>
4407
4408 * window.c (Fwindow_total_size, Fwindow_left_column)
4409 (Fwindow_top_line, window_body_lines, Fwindow_body_size)
4410 (Fwindow_list_1): New functions.
4411 (window_box_text_cols): Replace with window_body_cols.
640c8776
SM
4412 (Fwindow_width, Fscroll_left, Fscroll_right):
4413 Use window_body_cols instead of window_box_text_cols.
4414 (delete_window, Fset_window_configuration):
4415 Call delete_all_subwindows with window as argument.
fa8a67e6
MR
4416 (delete_all_subwindows): Take a window as argument and not a
4417 structure. Rewrite.
190b47e6
MR
4418 (window_loop): Remove handling of GET_LRU_WINDOW and
4419 GET_LARGEST_WINDOW.
4420 (Fget_lru_window, Fget_largest_window): Move to window.el.
abde8f8c
MR
4421
4422 * window.h: Extern window_body_cols instead of
fa8a67e6
MR
4423 window_box_text_cols. delete_all_subwindows now takes a
4424 Lisp_Object as argument.
abde8f8c 4425
640c8776
SM
4426 * indent.c (compute_motion, Fcompute_motion):
4427 Use window_body_cols instead of window_box_text_cols.
abde8f8c 4428
fa8a67e6
MR
4429 * frame.c (delete_frame): Call delete_all_subwindows with root
4430 window as argument.
4431
a54e3482
DC
44322011-06-07 Daniel Colascione <dan.colascione@gmail.com>
4433
4434 * fns.c (Fputhash): Document return value.
4435
60002bf5
CY
44362011-06-06 Chong Yidong <cyd@stupidchicken.com>
4437
4438 * image.c (gif_load): Implement gif89a spec "no disposal" method.
4439
0c671da6 44402011-06-06 Paul Eggert <eggert@cs.ucla.edu>
ccd9a01a 4441
b862a52a 4442 Cons<->int and similar integer overflow fixes (Bug#8794).
77984278 4443
be44ca6c
PE
4444 Check for overflow when converting integer to cons and back.
4445 * charset.c (Fdefine_charset_internal, Fdecode_char):
4446 Use cons_to_unsigned to catch overflow.
4447 (Fencode_char): Use INTEGER_TO_CONS.
4448 * composite.h (LGLYPH_CODE): Use cons_to_unsigned.
4449 (LGLYPH_SET_CODE): Use INTEGER_TO_CONS.
4450 * data.c (long_to_cons, cons_to_long): Remove.
4451 (cons_to_unsigned, cons_to_signed): New functions.
4452 These signal an error for invalid or out-of-range values.
4453 * dired.c (Ffile_attributes): Use INTEGER_TO_CONS.
4454 * fileio.c (Fset_visited_file_modtime): Use CONS_TO_INTEGER.
4455 * font.c (Ffont_variation_glyphs):
4456 * fontset.c (Finternal_char_font): Use INTEGER_TO_CONS.
4457 * lisp.h: Include <intprops.h>.
4458 (INTEGER_TO_CONS, CONS_TO_INTEGER): New macros.
4459 (cons_to_signed, cons_to_unsigned): New decls.
4460 (long_to_cons, cons_to_long): Remove decls.
4461 * undo.c (record_first_change): Use INTEGER_TO_CONS.
4462 (Fprimitive_undo): Use CONS_TO_INTEGER.
4463 * xfns.c (Fx_window_property): Likewise.
4464 * xselect.c: Include <limits.h>.
4465 (x_own_selection, selection_data_to_lisp_data):
4466 Use INTEGER_TO_CONS.
4467 (x_handle_selection_request, x_handle_selection_clear)
4468 (x_get_foreign_selection, Fx_disown_selection_internal)
4469 (Fx_get_atom_name, x_send_client_event): Use CONS_TO_INTEGER.
4470 (lisp_data_to_selection_data): Use cons_to_unsigned.
4471 (x_fill_property_data): Use cons_to_signed.
4472 Report values out of range.
4473
d1f3d2af
PE
4474 Check for buffer and string overflow more precisely.
4475 * buffer.h (BUF_BYTES_MAX): New macro.
4476 * lisp.h (STRING_BYTES_MAX): New macro.
4477 * alloc.c (Fmake_string):
4478 * character.c (string_escape_byte8):
4479 * coding.c (coding_alloc_by_realloc):
4480 * doprnt.c (doprnt):
4481 * editfns.c (Fformat):
4482 * eval.c (verror):
4483 Use STRING_BYTES_MAX, not MOST_POSITIVE_FIXNUM,
4484 since they may not be the same number.
4485 * editfns.c (Finsert_char):
4486 * fileio.c (Finsert_file_contents):
4487 Likewise for BUF_BYTES_MAX.
4488
dd52fcea
PE
4489 * image.c: Use ptrdiff_t, not int, for sizes.
4490 (slurp_file): Switch from int to ptrdiff_t.
4491 All uses changed.
4492 (slurp_file): Check that file size fits in both size_t (for
4493 malloc) and ptrdiff_t (for sanity and safety).
4494
7f9bbdbb
PE
4495 * fileio.c (Fverify_visited_file_modtime): Avoid time overflow
4496 if b->modtime has its maximal value.
4497
dfe18f82
PE
4498 * dired.c (Ffile_attributes): Don't assume EMACS_INT has >32 bits.
4499
84acfcf0
PE
4500 Don't assume time_t can fit into int.
4501 * buffer.h (struct buffer.modtime): Now time_t, not int.
4502 * fileio.c (Fvisited_file_modtime): No need for time_t cast now.
4503 * undo.c (Fprimitive_undo): Use time_t, not int, for time_t value.
4504
ccd9a01a
PE
4505 Minor fixes for signed vs unsigned integers.
4506 * character.h (MAYBE_UNIFY_CHAR):
4507 * charset.c (maybe_unify_char):
4508 * keyboard.c (read_char, reorder_modifiers):
4509 XINT -> XFASTINT, since the integer must be nonnegative.
4510 * ftfont.c (ftfont_spec_pattern):
4511 * keymap.c (access_keymap, silly_event_symbol_error):
4512 XUINT -> XFASTINT, since the integer must be nonnegative.
4513 (Fsingle_key_description, preferred_sequence_p): XUINT -> XINT,
4514 since it makes no difference and we prefer signed.
4515 * keyboard.c (record_char): Use XUINT when all the neighbors do.
4516 (access_keymap): NATNUMP -> INTEGERP, since the integer must be
4517 nonnegative.
4518
d6d100dd
SM
45192011-06-06 Stefan Monnier <monnier@iro.umontreal.ca>
4520
4521 * window.h (Fwindow_frame): Declare.
4522
2b6148e4
PE
45232011-06-06 Paul Eggert <eggert@cs.ucla.edu>
4524
4525 * alloc.c: Simplify handling of large-request failures (Bug#8800).
4526 (SPARE_MEMORY): Always define.
4527 (LARGE_REQUEST): Remove.
4528 (memory_full): Use SPARE_MEMORY rather than LARGE_REQUEST.
4529
f230ecc9
MR
45302011-06-06 Martin Rudalics <rudalics@gmx.at>
4531
727e958e
MR
4532 * lisp.h: Move EXFUNS for Fframe_root_window,
4533 Fframe_first_window and Fset_frame_selected_window to window.h.
4534
4535 * window.h: Move EXFUNS for Fframe_root_window,
4536 Fframe_first_window and Fset_frame_selected_window here from
4537 lisp.h.
4538
4539 * frame.c (Fwindow_frame, Fframe_first_window)
4540 (Fframe_root_window, Fframe_selected_window)
4541 (Fset_frame_selected_window): Move to window.c.
4542 (Factive_minibuffer_window): Move to minibuf.c.
4543 (Fother_visible_frames_p): New function.
4544
4545 * minibuf.c (Factive_minibuffer_window): Move here from frame.c.
4546
f230ecc9
MR
4547 * window.c (decode_window, decode_any_window): Move up in code.
4548 (Fwindowp, Fwindow_live_p): Rewrite doc-strings.
4549 (inhibit_frame_unsplittable): Remove unused variable.
bf60a96b
MR
4550 (Fwindow_buffer): Move up and rewrite doc-string.
4551 (Fwindow_parent, Fwindow_vchild, Fwindow_hchild, Fwindow_next)
4552 (Fwindow_prev): New functions.
727e958e
MR
4553 (Fwindow_frame): Move here from frame.c. Accept any window as
4554 argument.
4555 (Fframe_root_window, Fframe_first_window)
4556 (Fframe_selected_window): Move here from frame.c. Accept frame
4557 or arbitrary window as argument. Update doc-strings.
4558 (Fminibuffer_window): Move up in code.
4559 (Fwindow_minibuffer_p): Move up in code and simplify.
d6d100dd
SM
4560 (Fset_frame_selected_window): Move here from frame.c.
4561 Marginal rewrite.
727e958e
MR
4562 (Fselected_window, select_window, Fselect_window): Move up in
4563 code. Minor doc-string fixes.
f230ecc9 4564
4d09bcf6
PE
45652011-06-06 Paul Eggert <eggert@cs.ucla.edu>
4566
4567 * alloc.c (memory_full) [SYSTEM_MALLOC]: Port to MacOS (Bug#8800).
4568 Do not assume that spare memory exists; that assumption is valid
4569 only if SYSTEM_MALLOC.
4570 (LARGE_REQUEST): New macro, so that the issue of large requests
4571 is separated from the issue of spare memory.
4572
810928a2
AS
45732011-06-05 Andreas Schwab <schwab@linux-m68k.org>
4574
172418ad
AS
4575 * editfns.c (Fformat): Correctly handle zero flag with hexadecimal
4576 format. (Bug#8806)
4577
43f862f7
AS
4578 * gtkutil.c (xg_get_default_scrollbar_width): Avoid warning.
4579
810928a2
AS
4580 * xfns.c (x_set_scroll_bar_default_width): Move declarations
4581 before statements.
4582
a059fe24
JD
45832011-06-05 Jan Djärv <jan.h.d@swipnet.se>
4584
4585 * gtkutil.c (xg_get_default_scrollbar_width): New function.
4586
4587 * gtkutil.h: Declare xg_get_default_scrollbar_width.
4588
4589 * xfns.c (x_set_scroll_bar_default_width): If USE_GTK, get
4590 min width by calling x_set_scroll_bar_default_width (Bug#8505).
4591
989bf368
JB
45922011-06-05 Juanma Barranquero <lekktu@gmail.com>
4593
4594 * xdisp.c (single_display_spec_intangible_p): Remove declaration.
4595
4b80f674
CY
45962011-06-04 Chong Yidong <cyd@stupidchicken.com>
4597
4598 * xselect.c (x_clipboard_manager_save): Remove redundant arg.
4599 (x_clipboard_manager_save): Add return value.
d6d100dd
SM
4600 (x_clipboard_manager_error_1, x_clipboard_manager_error_2):
4601 New error handlers.
4b80f674
CY
4602 (x_clipboard_manager_save_frame, x_clipboard_manager_save_all):
4603 Obey Vx_select_enable_clipboard_manager. Catch errors in
4604 x_clipboard_manager_save (Bug#8779).
4605 (Vx_select_enable_clipboard_manager): New variable.
de65b42c 4606 (x_get_foreign_selection): Reduce scope of x_catch_errors (Bug#8790).
4b80f674 4607
99a33b77 46082011-06-04 Dan Nicolaescu <dann@ics.uci.edu>
8b3115e7
DN
4609
4610 * emacs.c (main): Warn when starting a GTK emacs in daemon mode.
4611
99a33b77 46122011-06-04 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
14eca62f
YM
4613
4614 * fringe.c (update_window_fringes): Don't update overlay arrow bitmap
4615 in the current matrix if keep_current_p is non-zero.
4616
8264569d
EZ
46172011-06-04 Eli Zaretskii <eliz@gnu.org>
4618
4619 * bidi.c (bidi_level_of_next_char): Fix last change.
4620
57f97249
EZ
46212011-06-03 Eli Zaretskii <eliz@gnu.org>
4622
fec2107c 4623 Support bidi reordering of text covered by display properties.
57f97249 4624
fec2107c
EZ
4625 * bidi.c (bidi_copy_it): Use offsetof instead of emulating it.
4626 (bidi_fetch_char, bidi_fetch_char_advance): New functions.
4627 (bidi_cache_search, bidi_cache_iterator_state)
4628 (bidi_paragraph_init, bidi_resolve_explicit, bidi_resolve_weak)
d6d100dd
SM
4629 (bidi_level_of_next_char, bidi_move_to_visually_next):
4630 Support character positions inside a run of characters covered by a
fec2107c
EZ
4631 display string.
4632 (bidi_paragraph_init, bidi_resolve_explicit_1)
4633 (bidi_level_of_next_char): Call bidi_fetch_char and
4634 bidi_fetch_char_advance instead of FETCH_CHAR and
4635 FETCH_CHAR_ADVANCE.
4636 (bidi_init_it): Initialize new members.
4637 (LRE_CHAR, RLE_CHAR, PDF_CHAR, LRO_CHAR, RLO_CHAR): Remove macro
4638 definitions.
4639 (bidi_explicit_dir_char): Lookup character type in bidi_type_table,
4640 instead of using explicit *_CHAR codes.
d6d100dd
SM
4641 (bidi_resolve_explicit, bidi_resolve_weak):
4642 Use FETCH_MULTIBYTE_CHAR instead of FETCH_CHAR, as reordering of
fec2107c
EZ
4643 bidirectional text is supported only in multibyte buffers.
4644 (bidi_init_it): Accept additional argument FRAME_WINDOW_P and use
4645 it to initialize the frame_window_p member of struct bidi_it.
4646 (bidi_cache_iterator_state, bidi_resolve_explicit_1)
4647 (bidi_resolve_explicit, bidi_resolve_weak)
4648 (bidi_level_of_next_char, bidi_move_to_visually_next): Abort if
4649 bidi_it->nchars is non-positive.
4650 (bidi_level_of_next_char): Don't try to lookup the cache for the
4651 next/previous character if nothing is cached there yet, or if we
4652 were just reseat()'ed to a new position.
c40e2fb2 4653
0e14fe90
EZ
4654 * xdisp.c (set_cursor_from_row): Set start and stop points
4655 according to the row's direction when priming the loop that looks
4656 for the glyph on which to display cursor.
4657 (single_display_spec_intangible_p): Function deleted.
4658 (display_prop_intangible_p): Reimplement to call
4659 handle_display_spec instead of single_display_spec_intangible_p.
d6d100dd
SM
4660 Accept 3 additional arguments needed by handle_display_spec.
4661 This fixes incorrect cursor motion across display property with complex
0e14fe90
EZ
4662 values: lists, `(when COND...)' forms, etc.
4663 (single_display_spec_string_p): Support property values that are
4664 lists with the argument STRING its top-level element.
4665 (display_prop_string_p): Fix the condition for processing a
4666 property that is a list to be consistent with handle_display_spec.
fec2107c 4667 (handle_display_spec): New function, refactored from the
fc6f18ce
EZ
4668 last portion of handle_display_prop.
4669 (compute_display_string_pos): Accept additional argument
4670 FRAME_WINDOW_P. Call handle_display_spec to determine whether the
4671 value of a `display' property is a "replacing spec".
4672 (handle_single_display_spec): Accept 2 additional arguments BUFPOS
4673 and FRAME_WINDOW_P. If IT is NULL, don't set up the iterator from
4674 the display property, but just return a value indicating whether
4675 the display property will replace the characters it covers.
4676 (Fcurrent_bidi_paragraph_direction): Initialize the nchars and
4677 frame_window_p members of struct bidi_it.
d6d100dd
SM
4678 (compute_display_string_pos, compute_display_string_end):
4679 New functions.
fec2107c
EZ
4680 (push_it): Accept second argument POSITION, where pop_it should
4681 jump to continue iteration.
4682 (reseat_1): Initialize bidi_it.disp_pos.
fc6f18ce 4683
fec2107c
EZ
4684 * keyboard.c (adjust_point_for_property): Adjust the call to
4685 display_prop_intangible_p to its new signature.
fc6f18ce
EZ
4686
4687 * dispextern.h (struct bidi_it): New member frame_window_p.
fec2107c
EZ
4688 (bidi_init_it): Update prototypes.
4689 (display_prop_intangible_p): Update prototype.
d6d100dd
SM
4690 (compute_display_string_pos, compute_display_string_end):
4691 Declare prototypes.
fec2107c
EZ
4692 (struct bidi_it): New members nchars and disp_pos. ch_len is now
4693 EMACS_INT.
fc6f18ce 4694
40087514 46952011-06-02 Paul Eggert <eggert@cs.ucla.edu>
0de4bb68 4696
57f53182
PE
4697 Malloc failure behavior now depends on size of allocation.
4698 * alloc.c (buffer_memory_full, memory_full): New arg NBYTES.
4699 * lisp.h: Change signatures accordingly.
4700 * alloc.c, buffer.c, editfns.c, menu.c, minibuf.c, xterm.c:
4701 All callers changed. (Bug#8762)
4702
4703 * gnutls.c: Use Emacs's memory allocators.
4704 Without this change, the gnutls library would invoke malloc etc.
4705 directly, which causes problems on non-SYNC_INPUT hosts, and which
4706 runs afoul of improving memory_full behavior. (Bug#8761)
4707 (fn_gnutls_global_set_mem_functions): New macro or function pointer.
4708 (emacs_gnutls_global_init): Use it to specify xmalloc, xrealloc,
4709 xfree instead of the default malloc, realloc, free.
4710 (Fgnutls_boot): No need to check for memory allocation failure,
4711 since xmalloc does that for us.
4712
ac32cd99 4713 Remove arbitrary limit of 2**31 entries in hash tables. (Bug#8771)
3870d916
PE
4714 * category.c (hash_get_category_set):
4715 * ccl.c (ccl_driver):
4716 * charset.c (Fdefine_charset_internal):
4717 * charset.h (struct charset.hash_index):
4718 * composite.c (get_composition_id, gstring_lookup_cache)
4719 (composition_gstring_put_cache):
4720 * composite.h (struct composition.hash_index):
4721 * dispextern.h (struct image.hash):
4722 * fns.c (next_almost_prime, larger_vector, cmpfn_eql)
4723 (cmpfn_equal, cmpfn_user_defined, hashfn_eq, hashfn_eql)
4724 (hashfn_equal, hashfn_user_defined, make_hash_table)
4725 (maybe_resize_hash_table, hash_lookup, hash_put)
4726 (hash_remove_from_table, hash_clear, sweep_weak_table, SXHASH_COMBINE)
4727 (sxhash_string, sxhash_list, sxhash_vector, sxhash_bool_vector)
4728 (Fsxhash, Fgethash, Fputhash, Fmaphash):
4729 * image.c (make_image, search_image_cache, lookup_image)
4730 (xpm_put_color_table_h):
4731 * lisp.h (struct Lisp_Hash_Table):
0de4bb68 4732 * minibuf.c (Ftry_completion, Fall_completions, Ftest_completion):
ac389d0c 4733 * print.c (print): Use 'EMACS_UINT' and 'EMACS_INT'
3870d916 4734 for hashes and hash indexes, instead of 'unsigned' and 'int'.
40087514
PE
4735 * alloc.c (allocate_vectorlike):
4736 Check for overflow in vector size calculations.
4737 * ccl.c (ccl_driver):
4738 Check for overflow when converting EMACS_INT to int.
0de4bb68
PE
4739 * fns.c, image.c: Remove unnecessary static decls that would otherwise
4740 need to be updated by these changes.
40087514
PE
4741 * fns.c (make_hash_table, maybe_resize_hash_table):
4742 Check for integer overflow with large hash tables.
0de4bb68
PE
4743 (make_hash_table, maybe_resize_hash_table, Fmake_hash_table):
4744 Prefer the faster XFLOAT_DATA to XFLOATINT where either will do.
4745 (SXHASH_REDUCE): New macro.
4746 (sxhash_string, sxhash_list, sxhash_vector, sxhash_bool_vector):
4747 Use it instead of discarding useful hash info with large hash values.
4748 (sxhash_float): New function.
4749 (sxhash): Use it. No more need for "& INTMASK" due to above changes.
4750 * lisp.h (FIXNUM_BITS): New macro, useful for SXHASH_REDUCE etc.
40087514
PE
4751 (MOST_NEGATIVE_FIXNUM, MOST_POSITIVE_FIXNUM, INTMASK):
4752 Rewrite to use FIXNUM_BITS, as this simplifies things.
0de4bb68
PE
4753 (next_almost_prime, larger_vector, sxhash, hash_lookup, hash_put):
4754 Adjust signatures to match updated version of code.
4755 (consing_since_gc): Now EMACS_INT, since a single hash table can
4756 use more than INT_MAX bytes.
4757
698d32e2
DN
47582011-06-01 Dan Nicolaescu <dann@ics.uci.edu>
4759
4760 Make it possible to build with GCC-4.6+ -O2 -flto.
4761
4762 * emacs.c (__malloc_initialize_hook): Mark as EXTERNALLY_VISIBLE.
4763
fd6fa53f
SM
47642011-06-01 Stefan Monnier <monnier@iro.umontreal.ca>
4765
4766 * minibuf.c (get_minibuffer, read_minibuf_unwind):
4767 Call minibuffer-inactive-mode.
4768
864db017
JB
47692011-05-31 Juanma Barranquero <lekktu@gmail.com>
4770
4771 * makefile.w32-in ($(BLD)/data.$(O), $(BLD)/editfns.$(O)):
4772 Update dependencies.
4773
2ad0baf4
DN
47742011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
4775
4776 * data.c (init_data): Remove code for UTS, this system is not
4777 supported anymore.
4778
4fcc2638
DN
47792011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
4780
4781 Don't force ./temacs to start in terminal mode.
4782
4783 * frame.c (make_initial_frame): Initialize faces in all cases, not
4784 only when CANNOT_DUMP is defined.
4785 * dispnew.c (init_display): Remove CANNOT_DUMP condition.
4786
c56e0fd5
DN
47872011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
4788
4789 * dispnew.c (add_window_display_history): Use const for the string
4790 pointer. Remove declaration, not needed.
4791
333d54da 47922011-05-31 Paul Eggert <eggert@cs.ucla.edu>
9cf9f756 4793
55d4c1b2 4794 Use 'inline', not 'INLINE'.
333d54da 4795 <http://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00914.html>
55d4c1b2
PE
4796 * alloc.c, fontset.c (INLINE): Remove.
4797 * alloc.c, bidi.c, charset.c, coding.c, dispnew.c, fns.c, image.c:
4798 * intervals.c, keyboard.c, process.c, syntax.c, textprop.c, w32term.c:
4799 * xdisp.c, xfaces.c, xterm.c: Replace all uses of INLINE with inline.
4800 * gmalloc.c (register_heapinfo): Use inline unconditionally.
4801 * lisp.h (LISP_MAKE_RVALUE): Use inline, not __inline__.
4802
738db178
DN
48032011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
4804
4805 Make it possible to run ./temacs.
4806
4807 * callproc.c (set_initial_environment): Remove CANNOT_DUMP code,
4808 syms_of_callproc does the same thing. Remove test for
4809 "initialized", do it in the caller.
4810 * emacs.c (main): Avoid calling set_initial_environment when dumping.
4811
620c53a6
SM
48122011-05-31 Stefan Monnier <monnier@iro.umontreal.ca>
4813
4814 * minibuf.c (Finternal_complete_buffer): Return `category' metadata.
4815 (read_minibuf): Use get_minibuffer.
4816 (syms_of_minibuf): Use DEFSYM.
4817 (Qmetadata): New var.
4818 * data.c (Qbuffer): Don't make it static.
4819 (syms_of_data): Use DEFSYM.
4820
e003a292
PE
48212011-05-31 Paul Eggert <eggert@cs.ucla.edu>
4822
4823 * ccl.c (CCL_CODE_RANGE): Allow negative numbers. (Bug#8751)
4824 (CCL_CODE_MIN): New macro.
4825
ed008a6d
PE
48262011-05-30 Paul Eggert <eggert@cs.ucla.edu>
4827
3687c2ef
PE
4828 * alloc.c (lisp_align_malloc): Omit unnecessary val==NULL tests.
4829
ed008a6d
PE
4830 * eval.c (Qdebug): Now static.
4831 * lisp.h (Qdebug): Remove decl. This reverts a part of the
4832 2011-04-26T11:26:05Z!dan.colascione@gmail.com that inadvertently undid part of
4833 2011-04-14T06:48:41Z!eggert@cs.ucla.edu.
4834
d66c4c7c
CY
48352011-05-29 Chong Yidong <cyd@stupidchicken.com>
4836
4837 * image.c: Various fixes to ImageMagick code comments.
4838 (Fimagemagick_types): Doc fix.
4839
5fbc2025
PE
48402011-05-29 Paul Eggert <eggert@cs.ucla.edu>
4841
0196f88a
PE
4842 Minor fixes prompted by GCC 4.6.0 warnings.
4843
4844 * xselect.c (converted_selections, conversion_fail_tag): Now static.
4845
5fbc2025
PE
4846 * emacs.c [HAVE_X_WINDOWS]: Include "xterm.h".
4847 (x_clipboard_manager_save_all): Move extern decl to ...
4848 * xterm.h: ... here, so that it can be checked for consistency.
4849
1dd3c2d9
CY
48502011-05-29 Chong Yidong <cyd@stupidchicken.com>
4851
4852 * xselect.c (x_clipboard_manager_save_frame)
4853 (x_clipboard_manager_save_all): New functions.
4854 (Fx_clipboard_manager_save): Lisp function deleted.
4855
4856 * emacs.c (Fkill_emacs): Call x_clipboard_manager_save_all.
4857 * frame.c (delete_frame): Call x_clipboard_manager_save_frame.
4858
4859 * xterm.h: Update prototype.
4860
5ba6571d
WX
48612011-05-28 William Xu <william.xwl@gmail.com>
4862
4863 * nsterm.m (ns_term_shutdown): Synchronize user defaults before
4864 exiting (Bug#8239).
4865
3eaff834
JM
48662011-05-28 Jim Meyering <meyering@redhat.com>
4867
e1900994 4868 Avoid a sign-extension bug in crypto_hash_function.
3eaff834
JM
4869 * fns.c (to_uchar): Define.
4870 (crypto_hash_function): Use it to convert some newly-signed
4871 variables to unsigned, to avoid sign-extension bugs. For example,
4872 without this change, (md5 "truc") would evaluate to
4873 45723a2aff78ff4fff7fff1114760e62 rather than the expected
4874 45723a2af3788c4ff17f8d1114760e62. Reported by Antoine Levitt in
e1900994 4875 https://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00883.html.
3eaff834 4876
0f6990a7
PE
48772011-05-27 Paul Eggert <eggert@cs.ucla.edu>
4878
4879 Integer overflow fixes.
c8a9ca5a 4880
08686060
PE
4881 * dbusbind.c: Serial number integer overflow fixes.
4882 (CHECK_DBUS_SERIAL_GET_SERIAL): New macro.
08686060
PE
4883 (Fdbus_call_method_asynchronously, xd_read_message_1): Use a float
4884 to hold a serial number that is too large for a fixnum.
4885 (Fdbus_method_return_internal, Fdbus_method_error_internal):
4886 Check for serial numbers out of range. Decode any serial number
59568bf0 4887 that was so large that it became a float. (Bug#8722)
08686060 4888
2d1fc3c7
PE
4889 * dbusbind.c: Use XFASTINT rather than XUINT, and check for nonneg.
4890 (Fdbus_call_method, Fdbus_call_method_asynchronously):
4891 Use XFASTINT rather than XUINT when numbers are nonnegative.
4892 (xd_append_arg, Fdbus_method_return_internal):
4893 (Fdbus_method_error_internal): Likewise. Also, for unsigned
4894 arguments, check that Lisp number is nonnegative, rather than
59568bf0 4895 silently wrapping negative numbers around. (Bug#8722)
30217ff0 4896 (xd_read_message_1): Don't assume dbus_uint32_t can fit in int.
59568bf0 4897 (Bug#8722)
2d1fc3c7 4898
c8a9ca5a
PE
4899 * data.c (arith_driver, Flsh): Avoid unnecessary casts to EMACS_UINT.
4900
519e1d69
PE
4901 * ccl.c (ccl_driver): Redo slightly to avoid the need for 'unsigned'.
4902
30569699
PE
4903 ccl: add integer overflow checks
4904 * ccl.c (CCL_CODE_MAX, GET_CCL_RANGE, GET_CCL_CODE, GET_CCL_INT):
4905 (IN_INT_RANGE): New macros.
4906 (ccl_driver): Use them to check for integer overflow when
4907 decoding a CCL program. Many of the new checks are whether XINT (x)
4908 fits in int; it doesn't always, on 64-bit hosts. The new version
4909 doesn't catch all possible integer overflows, but it's an
847044ea 4910 improvement. (Bug#8719)
30569699 4911
c11285dc
PE
4912 * alloc.c (make_event_array): Use XINT, not XUINT.
4913 There's no need for unsigned here.
4914
fdccd48e
PE
4915 * mem-limits.h (EXCEEDS_LISP_PTR) [!USE_LSB_TAG]: EMACS_UINT -> uintptr_t
4916 This follows up to the 2011-05-06 change that substituted uintptr_t
4917 for EMACS_INT. This case wasn't caught back then.
4918
37910ab2
PE
4919 Rework Fformat to avoid integer overflow issues.
4920 * editfns.c: Include <float.h> unconditionally, as it's everywhere
4921 now (part of C89). Include <verify.h>.
4922 (MAX_10_EXP, CONVERTED_BYTE_SIZE): Remove; no longer needed.
4923 (pWIDE, pWIDElen, signed_wide, unsigned_wide): New defns.
4924 (Fformat): Avoid the prepass trying to compute sizes; it was only
4925 approximate and thus did not catch overflow reliably. Instead, walk
4926 through the format just once, formatting and computing sizes as we go,
4927 checking for integer overflow at every step, and allocating a larger
4928 buffer as needed. Keep track separately whether the format is
4929 multibyte. Keep only the most-recently calculated precision, rather
4930 than them all. Record whether each argument has been converted to
4931 string. Use EMACS_INT, not int, for byte and char and arg counts.
4932 Support field widths and precisions larger than INT_MAX. Avoid
4933 sprintf's undefined behavior with conversion specifications such as %#d
4934 and %.0c. Fix bug with strchr succeeding on '\0' when looking for
4935 flags. Fix bug with (format "%c" 256.0). Avoid integer overflow when
4936 formatting out-of-range floating point numbers with int
9173deec 4937 formats. (Bug#8668)
37910ab2 4938
2e6578fb
PE
4939 * lisp.h (FIXNUM_OVERFLOW_P): Work even if arg is a NaN.
4940
0ae6bdee
PE
4941 * data.c: Avoid integer truncation in expressions involving floats.
4942 * data.c: Include <intprops.h>.
4943 (arith_driver): When there's an integer overflow in an expression
4944 involving floating point, convert the integers to floating point
4945 so that the resulting value does not suffer from catastrophic
4946 integer truncation. For example, on a 64-bit host (* 4
4947 most-negative-fixnum 0.5) should yield about -4.6e+18, not zero.
4948 Do not rely on undefined behavior after integer overflow.
4949
de883a70
PE
4950 merge count_size_as_multibyte, parse_str_to_multibyte
4951 * character.c, character.h (count_size_as_multibyte):
fd6fa53f 4952 Rename from parse_str_to_multibyte; all uses changed.
de883a70
PE
4953 Check for integer overflow.
4954 * insdel.c, lisp.h (count_size_as_multibyte): Remove,
4955 since it's now a duplicate of the other. This is more of
4956 a character than a buffer op, so better that it's in character.c.
4957 * fns.c, print.c: Adjust to above changes.
4958
2ff916cb
PE
49592011-05-27 Stefan Monnier <monnier@iro.umontreal.ca>
4960
4961 * xselect.c (x_convert_selection): Yet another int/Lisp_Object mixup.
4962
f1b54466
PE
49632011-05-27 Paul Eggert <eggert@cs.ucla.edu>
4964
fb1ac845
PE
4965 * xselect.c: Fix minor problems prompted by GCC 4.6.0 warnings.
4966 (x_handle_selection_request, frame_for_x_selection): Remove unused vars.
4967 (x_clipboard_manager_save): Now static.
4968 (Fx_clipboard_manager_save): Rename local to avoid shadowing.
4969
f1b54466
PE
4970 * fns.c: Fix minor problems prompted by GCC 4.6.0 warnings.
4971 (crypto_hash_function): Now static.
4972 Fix pointer signedness problems. Avoid unnecessary initializations.
4973
a9f737ee
CY
49742011-05-27 Chong Yidong <cyd@stupidchicken.com>
4975
4976 * termhooks.h (Vselection_alist): Make it terminal-local.
4977
4978 * terminal.c (create_terminal): Initialize it.
4979
4980 * xselect.c: Support for clipboard managers.
4981 (Vselection_alist): Move to termhooks.h as terminal-local var.
4982 (LOCAL_SELECTION): New macro.
4983 (x_atom_to_symbol): Handle x_display_info_for_display fail case.
4984 (symbol_to_x_atom): Remove gratuitous arg.
4985 (x_handle_selection_request, lisp_data_to_selection_data)
4986 (x_get_foreign_selection, Fx_register_dnd_atom): Callers changed.
620c53a6
SM
4987 (x_own_selection, x_get_local_selection, x_convert_selection):
4988 New arg, specifying work frame. Use terminal-local Vselection_alist.
a9f737ee
CY
4989 (some_frame_on_display): Delete unused function.
4990 (Fx_own_selection_internal, Fx_get_selection_internal)
4991 (Fx_disown_selection_internal, Fx_selection_owner_p)
4992 (Fx_selection_exists_p): New optional frame arg.
4993 (frame_for_x_selection, Fx_clipboard_manager_save): New functions.
4994 (x_handle_selection_clear): Don't treat other terminals with the
4995 same keyboard specially. Use the terminal-local Vselection_alist.
4996 (x_clear_frame_selections): Use Frun_hook_with_args.
4997
4998 * xterm.c (x_term_init): Intern ATOM and CLIPBOARD_MANAGER atoms.
4999
5000 * xterm.h: Add support for those atoms.
5001
e067f0c1
CY
50022011-05-26 Chong Yidong <cyd@stupidchicken.com>
5003
5004 * xselect.c: ICCCM-compliant handling of MULTIPLE targets.
5005 (converted_selections, conversion_fail_tag): New global variables.
5006 (x_selection_request_lisp_error): Free the above.
5007 (x_get_local_selection): Remove unnecessary code.
5008 (x_reply_selection_request): Args changed; handle arbitrary array
620c53a6
SM
5009 of converted selections stored in converted_selections.
5010 Separate the XChangeProperty and SelectionNotify steps.
e067f0c1
CY
5011 (x_handle_selection_request): Rewrite to handle MULTIPLE target.
5012 (x_convert_selection): New function.
5013 (x_handle_selection_event): Simplify.
5014 (x_get_foreign_selection): Don't ignore incoming requests while
5015 waiting for an answer; this will fail when we implement
5016 SAVE_TARGETS, and seems unnecessary anyway.
5017 (selection_data_to_lisp_data): Recognize ATOM_PAIR type.
5018 (Vx_sent_selection_functions): Doc fix.
5019
0f4aebc0
LL
50202011-05-26 Leo Liu <sdl.web@gmail.com>
5021
5022 * editfns.c (Ftranspose_regions): Allow empty regions. (Bug#8699)
5023
e61124cd
YM
50242011-05-25 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
5025
5026 * dispextern.h (struct glyph_row): New member fringe_bitmap_periodic_p.
5027
5028 * dispnew.c (shift_glyph_matrix, scrolling_window): Mark scrolled row
5029 for fringe update if it has periodic bitmap.
ac389d0c 5030 (row_equal_p): Also compare left_fringe_offset, right_fringe_offset,
e61124cd
YM
5031 and fringe_bitmap_periodic_p.
5032
5033 * fringe.c (get_fringe_bitmap_data): New function.
5034 (draw_fringe_bitmap_1, update_window_fringes): Use it.
5035 (update_window_fringes): Record periodicity of fringe bitmap in glyph
5036 row. Mark glyph row for fringe update if periodicity changed.
5037
5038 * xdisp.c (try_window_reusing_current_matrix): Don't mark scrolled row
5039 for fringe update unless it has periodic bitmap.
5040
f16d9837
KH
50412011-05-25 Kenichi Handa <handa@m17n.org>
5042
5043 * xdisp.c (get_next_display_element): Set correct it->face_id for
5044 a static composition.
5045
e1b90ef6
LL
50462011-05-24 Leo Liu <sdl.web@gmail.com>
5047
5048 * deps.mk (fns.o):
5049 * makefile.w32-in ($(BLD)/fns.$(O)): Include sha1.h.
5050
5051 * fns.c (crypto_hash_function, Fsha1): New function.
5052 (Fmd5): Use crypto_hash_function.
5053 (syms_of_fns): Add Ssha1.
5054
7400048f
PE
50552011-05-22 Paul Eggert <eggert@cs.ucla.edu>
5056
5057 * gnutls.c: Remove unused macros.
5058 (fn_gnutls_transport_set_lowat, fn_gnutls_transport_set_pull_function):
5059 (fn_gnutls_transport_set_push_function) [!WINDOWSNT]:
5060 Remove macros that are defined and never used.
5061 Caught by gcc -Wunused-macros (GCC 4.6.0, Fedora 14).
5062
abb71cf4
CY
50632011-05-22 Chong Yidong <cyd@stupidchicken.com>
5064
5065 * xselect.c (syms_of_xselect): Remove unused symbol SAVE_TARGETS.
5066 (Fx_get_selection_internal): Minor cleanup.
5067 (Fx_own_selection_internal): Rename arguments for consistency with
5068 select.el.
5069
6307db39
PE
50702011-05-22 Paul Eggert <eggert@cs.ucla.edu>
5071
5072 * xselect.c (QSAVE_TARGETS): New static var, to fix build failure.
5073
f3d4e0a4
CY
50742011-05-22 Chong Yidong <cyd@stupidchicken.com>
5075
5076 * xselect.c (syms_of_xselect): Include character.h; use DEFSYM.
5077
4d8ade89
YM
50782011-05-21 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
5079
5080 * dispnew.c (scrolling_window): Don't exclude the case that the
5081 last enabled row in the desired matrix touches the bottom boundary.
5082
32078c8d
GM
50832011-05-21 Glenn Morris <rgm@gnu.org>
5084
5085 * Makefile.in ($(etc)/DOC): Make second command line even shorter.
33cf345f
GM
5086 (SOME_MACHINE_OBJECTS): Replace FONT_OBJ by its maximal expansion,
5087 and add some more files.
32078c8d 5088
7285dc67
EZ
50892011-05-20 Eli Zaretskii <eliz@gnu.org>
5090
5091 * callproc.c (Fcall_process) [MSDOS]: Fix arguments to
5092 report_file_error introduced by the change from 2011-05-07.
5093
89d1bd22
PE
50942011-05-20 Paul Eggert <eggert@cs.ucla.edu>
5095
5096 * systime.h (Time): Define only if emacs is defined.
5097 This is to allow ../lib-src/profile.c to be compiled on FreeBSD,
5098 where the include path doesn't have X11/X.h by default. See
5099 <http://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00561.html>.
5100
e23640bb 51012011-05-20 Kenichi Handa <handa@m17n.org>
31bfc35c
KH
5102
5103 * composite.c (find_automatic_composition): Fix previous change.
5104
b9704ad9
GM
51052011-05-20 Glenn Morris <rgm@gnu.org>
5106
5107 * lisp.mk: New file, split from Makefile.in.
5108 * Makefile.in (lisp): Move to separate file, inserted by @lisp_frag@.
5109 (shortlisp): Remove.
5110 ($(etc)/DOC): Edit lisp.mk rather than using $shortlisp.
5111
4a720484
GM
51122011-05-19 Glenn Morris <rgm@gnu.org>
5113
5114 * Makefile.in (MSDOS_SUPPORT_REAL, MSDOS_SUPPORT, NS_SUPPORT)
5115 (REAL_MOUSE_SUPPORT, GPM_MOUSE_SUPPORT, MOUSE_SUPPORT, TOOLTIP_SUPPORT)
5116 (BASE_WINDOW_SUPPORT, X_WINDOW_SUPPORT, WINDOW_SUPPORT): Remove.
5117 (lisp): Set the order to that of loadup.el.
5118 (shortlisp): Make it a copy of $lisp.
5119 (SOME_MACHINE_LISP): Remove.
5120 ($(etc)/DOC): Depend just on $lisp, not $SOME_MACHINE_LISP too.
5121 Use just $shortlisp, not $SOME_MACHINE_LISP too.
5122
a28d4396
KH
51232011-05-18 Kenichi Handa <handa@m17n.org>
5124
5125 * composite.c (CHAR_COMPOSABLE_P): Add more check for efficiency.
5126 (BACKWARD_CHAR): Wrap the arg STOP by parenthesis.
5127 (find_automatic_composition): Mostly rewrite for efficiency.
5128
a2b1fa8e
JB
51292011-05-18 Juanma Barranquero <lekktu@gmail.com>
5130
5131 * makefile.w32-in: Update dependencies.
5132
8e1f5610
CS
51332011-05-18 Christoph Scholtes <cschol2112@googlemail.com>
5134
5135 * menu.c: Include limits.h (fixes the MS-Windows build broken by
7d7d0045 5136 2011-06-18T18:49:19Z!cyd@stupidchicken.com).
8e1f5610 5137
7025ee00 51382011-05-18 Paul Eggert <eggert@cs.ucla.edu>
cb93f9be 5139
cdfa6eab
PE
5140 Fix some integer overflow issues, such as string length overflow.
5141
06d6db33
PE
5142 * insdel.c (count_size_as_multibyte): Check for string overflow.
5143
2b4560a8
PE
5144 * character.c (lisp_string_width): Check for string overflow.
5145 Use EMACS_INT, not int, for string indexes and lengths; in
5146 particular, 2nd arg is now EMACS_INT, not int. Do not crash if
5147 the resulting string length overflows an EMACS_INT; instead,
5148 report a string overflow if no precision given. When checking for
5149 precision exhaustion, use a check that cannot possibly have
5150 integer overflow. (Bug#8675)
5151 * character.h (lisp_string_width): Adjust to new signature.
5152
cb93f9be
PE
5153 * alloc.c (string_overflow): New function.
5154 (Fmake_string): Use it. This doesn't change behavior, but saves
5155 a few bytes and will simplify future changes.
5156 * character.c (string_escape_byte8): Likewise.
5157 * lisp.h (string_overflow): New decl.
5158
1a1f3366
PE
5159 Fixups, following up to the user-interface timestamp change.
5160 * nsterm.m (last_mouse_movement_time, ns_mouse_position): Use Time
5161 for UI timestamps, instead of unsigned long.
9fbd6841
PE
5162 * msdos.c (mouse_get_pos): Likewise.
5163 * w32inevt.c (movement_time, w32_console_mouse_position): Likewise.
1a1f3366
PE
5164 * w32gui.h (Time): Define by including "systime.h" rather than by
5165 declaring it ourselves. (Bug#8664)
5166
d4e3e4d3
PE
5167 * dispextern.h (struct image): Don't assume time_t <= unsigned long.
5168 * image.c (clear_image_cache): Likewise.
5169
f6a24d19
PE
5170 * term.c (term_mouse_position): Don't assume time_t wraparound.
5171
08dc5ae6
PE
5172 Be more systematic about user-interface timestamps.
5173 Before, the code sometimes used 'Time', sometimes 'unsigned long',
620c53a6
SM
5174 and sometimes 'EMACS_UINT', to represent these timestamps.
5175 This change causes it to use 'Time' uniformly, as that's what X uses.
08dc5ae6
PE
5176 This makes the code easier to follow, and makes it easier to catch
5177 integer overflow bugs such as Bug#8664.
5178 * frame.c (Fmouse_position, Fmouse_pixel_position):
5179 Use Time, not unsigned long, for user-interface timestamps.
5180 * keyboard.c (last_event_timestamp, kbd_buffer_get_event): Likewise.
5181 (button_down_time, make_lispy_position, make_lispy_movement): Likewise.
5182 * keyboard.h (last_event_timestamp): Likewise.
5183 * menu.c (Fx_popup_menu) [!HAVE_X_WINDOWS]: Likewise.
5184 * menu.h (xmenu_show): Likewise.
5185 * term.c (term_mouse_position): Likewise.
5186 * termhooks.h (struct input_event.timestamp): Likewise.
5187 (struct terminal.mouse_position_hook): Likewise.
5188 * xmenu.c (create_and_show_popup_menu, xmenu_show): Likewise.
5189 * xterm.c (XTmouse_position, x_scroll_bar_report_motion): Likewise.
5190 * systime.h (Time): New decl. Pull it in from <X11/X.h> if
5191 HAVE_X_WINDOWS, otherwise define it as unsigned long, which is
5192 what it was before.
5193 * menu.h, termhooks.h: Include "systime.h", for Time.
5194
8e55734a
PE
5195 * keyboard.c (make_lispy_event): Fix problem in integer overflow.
5196 Don't assume that the difference between two unsigned long values
5197 can fit into an integer. At this point, we know button_down_time
5198 <= event->timestamp, so the difference must be nonnegative, so
5199 there's no need to cast the result if double-click-time is
5200 nonnegative, as it should be; check that it's nonnegative, just in
5201 case. This bug is triggered when events are more than 2**31 ms
86db42d2 5202 apart (about 25 days). (Bug#8664)
8e55734a 5203
841f1b75 5204 * xselect.c (last_event_timestamp): Remove duplicate decl.
6434756c 5205 (x_own_selection): Remove needless cast to unsigned long.
841f1b75 5206
3e26f69c
PE
5207 * xmenu.c (set_frame_menubar): Use int, not EMACS_UINT, for indexes
5208 that always fit in int. Use a sentinel instead of a counter, to
5209 avoid a temp and to allay GCC's concerns about possible int overflow.
d230cb74
PE
5210 * frame.h (struct frame): Use int for menu_bar_items_used
5211 instead of EMACS_INT, since it always fits in int.
3e26f69c 5212
5cc152c0
PE
5213 * menu.c (grow_menu_items): Check for int overflow.
5214
d89eb65e
PE
5215 * xmenu.c (set_frame_menubar): Don't mishandle vectors with no nils.
5216
5235bd3e
PE
5217 * xterm.c: Use EMACS_INT for Emacs modifiers, and int for X modifiers.
5218 Before, the code was not consistent. These values cannot exceed
5219 2**31 - 1 so there's no need to make them unsigned.
5220 (x_x_to_emacs_modifiers): Accept int and return EMACS_INT.
5221 (x_emacs_to_x_modifiers): Accept EMACS_INT and return int.
5222 (x_x_to_emacs_modifiers, x_emacs_to_x_modifiers): Reject non-integers
5223 as modifiers.
5224 * xterm.h (x_x_to_emacs_modifiers): Adjust to signature change.
5225
bc827e23
PE
5226 * lisp.h (XINT) [USE_LISP_UNION_TYPE]: Cast to EMACS_INT.
5227 (XUINT) [USE_LISP_UNION_TYPE]: Cast to EMACS_UINT.
5228 Otherwise, GCC 4.6.0 warns about printf (pI, XINT (...)),
5229 presumably because the widths might not match.
5230
78eb494e
PE
5231 * window.c (size_window): Avoid needless test at loop start.
5232
04f2d78b
CB
52332011-05-18 Courtney Bane <emacs-bugs-7626@cbane.org> (tiny change)
5234
5235 * term.c (Fresume_tty): Restore hooks before reinitializing (bug#8687).
5236
d2fc7e3d 52372011-05-12 Drew Adams <drew.adams@oracle.com>
e531bdff
DA
5238
5239 * textprop.c (Fprevious_single_char_property_change): Doc fix (bug#8655).
5240
d2fc7e3d 52412011-05-12 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
7db47798
YM
5242
5243 * w32term.c (w32_draw_fringe_bitmap): Rename local vars `left' and
5244 `width' to `bar_area_x' and `bar_area_width', respectively.
5245 (x_scroll_run): Take account of fringe background extension.
5246
04f2d78b
CB
5247 * xterm.c (x_draw_fringe_bitmap) [USE_TOOLKIT_SCROLL_BARS]:
5248 Rename local vars `left' and `width' to `bar_area_x' and
7db47798
YM
5249 `bar_area_width', respectively.
5250 (x_scroll_run) [USE_TOOLKIT_SCROLL_BARS]: Take account of fringe
5251 background extension.
5252
79b70037
GM
52532011-05-10 Jim Meyering <meyering@redhat.com>
5254
5255 * xdisp.c (x_intersect_rectangles): Fix typo "the the -> the".
5256
2f142cc5
JB
52572011-05-10 Juanma Barranquero <lekktu@gmail.com>
5258
5259 * image.c (Finit_image_library): Return t for built-in image types,
5260 like pbm and xbm. (Bug#8640)
5261
57679c86
AS
52622011-05-09 Andreas Schwab <schwab@linux-m68k.org>
5263
5264 * w32menu.c (set_frame_menubar): Fix submenu allocation.
5265
888c9e86
EZ
52662011-05-07 Eli Zaretskii <eliz@gnu.org>
5267
b0512a1d
EZ
5268 * w32console.c (Fset_screen_color): Doc fix.
5269 (Fget_screen_color): New function.
5270 (syms_of_ntterm): Defsubr it.
5271
7285dc67
EZ
5272 * callproc.c (call_process_cleanup) [MSDOS]: Don't close and
5273 unlink the temporary file if Fcall_process didn't create it in the
5274 first place.
5275 (Fcall_process) [MSDOS]: Don't create tempfile if stdout of the
5276 child process will be redirected to a file specified with `:file'.
888c9e86
EZ
5277 Don't try to re-open tempfile in that case, and set fd[0] to -1 as
5278 cue to call_process_cleanup not to close that handle.
5279
4d3fcc8e
BK
52802011-05-07 Ben Key <bkey76@gmail.com>
5281
5282 * makefile.w32-in: The bootstrap-temacs rule now makes use of
5283 one of two shell specific rules, either bootstrap-temacs-CMD or
5284 bootstrap-temacs-SH. The bootstrap-temacs-SH rule is identical
5285 to the previous implementation of the bootstrap-temacs rule.
5286 The bootstrap-temacs-CMD rule is similar to the previous
5287 implementation of the bootstrap-temacs rule except that it
5288 makes use of the ESC_CFLAGS variable instead of the CFLAGS
5289 variable.
5290
5291 These changes, along with some changes to nt/configure.bat,
5292 nt/gmake.defs, and nt/nmake.defs, are required to extend my
5293 earlier fix to add support for --cflags and --ldflags options
5294 that include quotes so that it works whether make uses cmd or
5295 sh as the shell.
5296
b4289b64
MA
52972011-05-06 Michael Albinus <michael.albinus@gmx.de>
5298
5299 * dbusbind.c (QCdbus_type_unix_fd): Declare static.
5300 (xd_remove_watch): Don't check QCdbus_type_unix_fd for SYMBOLP, it
5301 is a constant.
5302 (Fdbus_init_bus, xd_read_queued_messages): Bus can be a symbol or
5303 a string. Handle both cases.
5304 (Fdbus_call_method_asynchronously, Fdbus_register_signal)
5305 (Fdbus_register_method): Use Qinvalid_function.
5306
af4c0e28
JB
53072011-05-06 Juanma Barranquero <lekktu@gmail.com>
5308
5309 * makefile.w32-in: Update dependencies.
5310 (LISP_H): Add inttypes.h and stdin.h.
5311 (PROCESS_H): Add unistd.h.
5312
c51453d9
EZ
53132011-05-06 Eli Zaretskii <eliz@gnu.org>
5314
5315 * lread.c: Include limits.h (fixes the MS-Windows build broken by
5316 2011-05-06T07:13:19Z!eggert@cs.ucla.edu).
5317
8ff0ac3c 53182011-05-06 Paul Eggert <eggert@cs.ucla.edu>
c032b5f8 5319
4c4b566b
PE
5320 * image.c (Finit_image_library) [!HAVE_NTGUI]: Omit unused local.
5321
aab2b9b5
PE
5322 * term.c (vfatal): Remove stray call to va_end.
5323 It's not needed and the C Standard doesn't allow it here anyway.
5324
c378da0b
PE
5325 Use C99's va_copy to avoid undefined behavior on x86-64 GNU/Linux.
5326 * eval.c (verror): doprnt a copy of ap, not the original. (Bug#8545)
5327
288b08c7
PE
5328 * eval.c (verror): OK to create a string of up to MOST_POSITIVE_FIXNUM
5329 bytes.
5330
e3601888
PE
5331 * term.c: Don't include <stdarg.h>, as <lisp.h> does that.
5332
db6c0e74
PE
5333 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork clobbering.
5334
dd5963ea
PE
5335 * process.c (Fformat_network_address): Fix typo: args2 -> *args2.
5336
88c9450f
PE
5337 * xmenu.c (set_frame_menubar): Fix typo: int * -> int (3 times).
5338
2f9442b8
PE
5339 * coding.c (detect_coding_charset): Fix typo: * 2 -> *4 (Bug#8601).
5340
c032b5f8
PE
5341 * charset.h (struct charset.code_space): Now has 15 elements, not 16.
5342 * charset.c (Fdefine_charset_internal): Don't initialize
5343 charset.code_space[15]. The value was garbage, on hosts with
2d38271b 5344 32-bit int (Bug#8600).
a108c10b
PE
5345
5346 * lread.c (read_integer): Be more consistent with string-to-number.
5347 Use string_to_number to do the actual conversion; this avoids
5348 rounding errors and fixes some other screwups. Without this fix,
5349 for example, #x1fffffffffffffff was misread as -2305843009213693952.
5350 (digit_to_number): Move earlier, for benefit of read_integer.
5351 Return -1 if the digit is out of range for the base, -2 if it is
48e400f0 5352 not a digit in any supported base. (Bug#8602)
a108c10b 5353
ad5f9eea
PE
5354 * doprnt.c (doprnt): Support arbitrary pI values, such as "I64".
5355
aec1708a
PE
5356 * dispnew.c (scrolling_window): Return 1 if we scrolled,
5357 to match comment at start of function. This also removes a
5358 GCC warning about overflow in a 32+64-bit port.
5359
47be4ab5
PE
5360 * lisp.h (EMACS_INT, EMACS_UINT, BITS_PER_EMACS_INT, pI): Simplify.
5361
371cac43
PE
5362 * dbusbind.c: Do not use XPNTR on a value that may be an integer.
5363 Reported by Stefan Monnier in
5364 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00919.html>.
04f2d78b
CB
5365 (xd_remove_watch, Fdbus_init_bus, xd_read_queued_messages):
5366 Use SYMBOLP-guarded XSYMBOL, not XPNTR.
371cac43 5367
d01a7826
PE
5368 * lisp.h (EMACS_INTPTR): Remove. All uses changed to intptr_t.
5369 (EMACS_UINTPTR): Likewise, with uintptr_t.
5370
7fd47d5c
PE
5371 * lisp.h: Prefer 64-bit EMACS_INT if available.
5372 (EMACS_INT, EMACS_UINT, BITS_PER_EMACS_INT, pI): Define to 64-bit
5373 on 32-bit hosts that have 64-bit int, so that they can access
5374 large files.
122b0c86
PE
5375 However, temporarily disable this change unless the temporary
5376 symbol WIDE_EMACS_INT is defined.
7fd47d5c 5377
8727937b
PE
5378 * lread.c, process.c: Do not include <inttypes.h>; lisp.h does it now.
5379
8ac068ac
PE
5380 Prefer intptr_t/uintptr_t for integers the same widths as pointers.
5381 This removes an assumption that EMACS_INT and long are the same
5382 width as pointers. The assumption is true for Emacs porting targets
5383 now, but we want to make other targets possible.
5384 * lisp.h: Include <inttypes.h>, for INTPTR_MAX, UINTPTR_MAX.
5385 (EMACS_INTPTR, EMACS_UINTPTR): New macros.
5386 In the rest of the code, change types of integers that hold casted
5387 pointers to EMACS_INTPTR and EMACS_UINTPTR, systematically
5388 replacing EMACS_INT, long, EMACS_UINT, and unsigned long.
5389 (XTYPE): Don't cast arg to EMACS_UINT; normally is not needed.
5390 (XSET): Cast type of XTYPE arg to EMACS_INTPTR; it is needed here.
5391 No need to cast type when ORing.
5392 (XPNTR): Return a value of type EMACS_INTPTR or EMACS_UINTPTR.
5393 * alloc.c (lisp_align_malloc): Remove a no-longer-needed cast.
5394 * doc.c (store_function_docstring): Use EMACS_INTPTR, so as not to
5395 assume EMACS_INT is the same width as char *.
5396 * gtkutil.c (xg_gtk_scroll_destroy, xg_tool_bar_button_cb):
5397 (xg_tool_bar_callback, xg_tool_bar_help_callback, xg_make_tool_item):
5398 Remove no-longer-needed casts.
5399 (xg_create_scroll_bar, xg_tool_bar_button_cb, xg_tool_bar_callback):
5400 (xg_tool_bar_help_callback, xg_make_tool_item):
5401 Use EMACS_INTPTR to hold an integer
5402 that will be cast to void *; this can avoid a GCC warning
5403 if EMACS_INT is not the same width as void *.
5404 * menu.c (find_and_call_menu_selection): Remove no-longer-needed cast.
5405 * xdisp.c (display_echo_area_1, resize_mini_window_1):
5406 (current_message_1, set_message_1):
5407 Use a local to convert to proper width without a cast.
5408 * xmenu.c (dialog_selection_callback): Likewise.
5409
ede49d71
PE
5410 * sysdep.c (get_random): Don't assume EMACS_INT is no wider than long.
5411 Also, don't assume VALBITS / RAND_BITS is less than 5,
5412 and don't rely on undefined behavior when shifting a 1 left into
5413 the sign bit.
5414 * lisp.h (get_random): Change signature to match.
5415
2f30ecd0
PE
5416 * lread.c (hash_string): Use size_t, not int, for hash computation.
5417 Normally we prefer signed values; but hashing is special, because
5418 it's better to use unsigned division on hash table sizes so that
5419 the remainder is nonnegative. Also, size_t is the natural width
5420 for hashing into memory. The previous code used 'int', which doesn't
5421 retain enough info to hash well into very large tables.
5422 (oblookup, oblookup_last_bucket_number, Funintern): Likewise.
5423
2a866e7b
PE
5424 * dbusbind.c: Don't possibly lose pointer info when converting.
5425 (xd_remove_watch, Fdbus_init_bus, xd_read_queued_messages):
5426 Use XPNTR rather than XHASH, so that the high-order bits of
5427 the pointer aren't lost when converting through void *.
5428
51639eac
PE
5429 * eval.c (Fautoload): Don't double-shift a pointer.
5430
92394119
PE
5431 * fns.c (Frandom): Let EMACS_UINT be wider than unsigned long.
5432
dbdb9a7c
JB
54332011-05-06 Juanma Barranquero <lekktu@gmail.com>
5434
5435 * gnutls.c (DEF_GNUTLS_FN):
5436 * image.c (DEF_IMGLIB_FN): Make function pointers static.
5437
db7a0b4f
AS
54382011-05-05 Andreas Schwab <schwab@linux-m68k.org>
5439
5440 * lread.c (lisp_file_lexically_bound_p): Stop scanning at end
5441 marker. (Bug#8610)
5442
f7ff1b0f 54432011-05-05 Eli Zaretskii <eliz@gnu.org>
fab624aa
EZ
5444
5445 * w32heap.c (allocate_heap) [USE_LISP_UNION_TYPE || USE_LSB_TAG]:
5446 New version that can reserve upto 2GB of heap space.
5447
f7ff1b0f 54482011-05-05 Chong Yidong <cyd@stupidchicken.com>
45cb8994
CY
5449
5450 * nsfns.m (Fns_read_file_name): Doc fix (Bug#8534).
5451
639c109b
TZ
54522011-05-05 Teodor Zlatanov <tzz@lifelogs.com>
5453
5454 * gnutls.c (fn_gnutls_certificate_set_x509_key_file): Add alias to
5455 `gnutls_certificate_set_x509_key_file'.
5456
d2127135
JB
54572011-05-05 Juanma Barranquero <lekktu@gmail.com>
5458
5459 * makefile.w32-in ($(BLD)/image.$(O), $(BLD)/process.$(O)):
5460 Update dependencies.
5461
e968f4f3
JB
54622011-05-04 Juanma Barranquero <lekktu@gmail.com>
5463
5464 * gnutls.h (emacs_gnutls_write, emacs_gnutls_read):
5465 * gnutls.c (emacs_gnutls_write, emacs_gnutls_read):
5466 Remove unused parameter `fildes'.
5467 * process.c (read_process_output, send_process): Don't pass it.
5468
84d358f0
JB
54692011-05-04 Juanma Barranquero <lekktu@gmail.com>
5470
5471 Fix previous change: the library cache is defined in w32.c.
5472 * image.c (CACHE_IMAGE_TYPE) [!HAVE_NTGUI]: Define to noop.
5473 (Finit_image_library): Wrap Vlibrary_cache on "#ifdef HAVE_NTGUI".
5474
0898ca10
JB
54752011-05-04 Juanma Barranquero <lekktu@gmail.com>
5476
5477 Implement dynamic loading of GnuTLS on Windows.
5478
5479 * gnutls.h (GNUTLS_EMACS_ERROR_NOT_LOADED): New macro.
5480 (emacs_gnutls_write, emacs_gnutls_read): Mark as extern.
5481 (emacs_gnutls_record_check_pending, emacs_gnutls_transport_set_errno):
5482 Declare.
5483
5484 * gnutls.c (Qgnutls_dll): Define.
5485 (DEF_GNUTLS_FN, LOAD_GNUTLS_FN): New macros.
5486 (gnutls_*): Declare function pointers.
5487 (init_gnutls_functions): New function to initialize function pointers.
5488 (emacs_gnutls_handshake, Fgnutls_error_string, Fgnutls_deinit)
5489 (emacs_gnutls_global_init, Fgnutls_bye): Use function pointers.
5490 (emacs_gnutls_record_check_pending, emacs_gnutls_transport_set_errno):
5491 Wrappers for gnutls_record_check_pending and gnutls_transport_set_errno.
5492 (emacs_gnutls_write, emacs_gnutls_read)
5493 (emacs_gnutls_handle_error, Fgnutls_error_fatalp)
5494 (Fgnutls_available_p): New function.
5495 (Fgnutls_boot): Call Fgnutls_available_p. Use function pointers.
5496 (syms_of_gnutls) <Qgnutls_dll>: Initialize and staticpro it.
5497 (syms_of_gnutls) <Sgnutls_available_p>: defsubr it.
5498
5499 * image.c: Include w32.h.
5500 (Vimage_type_cache): Delete.
5501 (syms_of_image) <Vimage_type_cache>: Don't initialize and staticpro it.
5502 (CACHE_IMAGE_TYPE, Finit_image_library): Use Vlibrary_cache instead.
5503 (w32_delayed_load): Move to w32.c.
5504
5505 * w32.h (VlibraryCache, QCloaded_from, w32_delayed_load): Declare.
5506
5507 * w32.c (QCloaded_from, Vlibrary_cache): Define.
5508 (w32_delayed_load): Move from image.c. When loading a library, record
5509 its filename in the :loaded-from property of the library id.
5510 (globals_of_w32) <QCloaded_from, Vlibrary_cache>:
5511 Initialize and staticpro them.
5512 (emacs_gnutls_pull, emacs_gnutls_push): Call emacs_gnutls_* functions.
5513
5514 * process.c: Include lisp.h before w32.h, not after.
5515 (wait_reading_process_output): Call emacs_gnutls_record_check_pending
5516 instead of gnutls_record_check_pending.
5517
5518 * callproc.c, emacs.c: Include lisp.h before w32.h, not after.
5519
ff4de4aa
TZ
55202011-05-04 Teodor Zlatanov <tzz@lifelogs.com>
5521
5522 * gnutls.c (Fgnutls_boot): Support :keylist and :crlfiles options
5523 instead of :keyfiles. Give GnuTLS the keylist and the CRL lists
5524 as passed in.
5525
abe95abb
JD
55262011-05-03 Jan Djärv <jan.h.d@swipnet.se>
5527
5528 * xterm.c (x_set_frame_alpha): Do not set property on anything
5529 else than FRAME_X_OUTER_WINDOW (Bug#8608).
5530
e16e55d4
JB
55312011-05-02 Juanma Barranquero <lekktu@gmail.com>
5532
5533 * sysdep.c (get_tty_size) [WINDOWSNT]: Implement. (Bug#8596)
5534
bafcf6a5
JB
55352011-05-02 Juanma Barranquero <lekktu@gmail.com>
5536
5537 * gnutls.c (Qgnutls_log_level, Qgnutls_code, Qgnutls_anon)
5538 (Qgnutls_x509pki, Qgnutls_e_interrupted, Qgnutls_e_again)
5539 (Qgnutls_e_invalid_session, Qgnutls_e_not_ready_for_handshake)
5540 (gnutls_global_initialized, Qgnutls_bootprop_priority)
5541 (Qgnutls_bootprop_trustfiles, Qgnutls_bootprop_keyfiles)
5542 (Qgnutls_bootprop_callbacks, Qgnutls_bootprop_loglevel)
5543 (Qgnutls_bootprop_hostname, Qgnutls_bootprop_verify_flags)
5544 (Qgnutls_bootprop_verify_error, Qgnutls_bootprop_verify_hostname_error)
5545 (Qgnutls_bootprop_callbacks_verify): Make static.
5546
e7a6747f
AS
55472011-05-01 Andreas Schwab <schwab@linux-m68k.org>
5548
19ed11ba
AS
5549 * callproc.c: Indentation fixup.
5550
e7a6747f 5551 * sysdep.c (wait_for_termination_1): Make static.
04f2d78b
CB
5552 (wait_for_termination, interruptible_wait_for_termination):
5553 Move after wait_for_termination_1.
e7a6747f 5554
1ef14cb4
LMI
55552011-05-01 Lars Magne Ingebrigtsen <larsi@gnus.org>
5556
5557 * sysdep.c (interruptible_wait_for_termination): New function
5558 which is like wait_for_termination, but allows keyboard
5559 interruptions.
5560
5561 * callproc.c (Fcall_process): Add (:file "file") as an option for
5562 the STDOUT buffer.
5563 (Fcall_process_region): Ditto.
5564
330d880c
EZ
55652011-04-30 Eli Zaretskii <eliz@gnu.org>
5566
8db90b73
EZ
5567 * dosfns.c (Fint86, Fdos_memget, Fdos_memput): Use `ASIZE (FOO)'
5568 rather than `XVECTOR (FOO)->size'.
5569
330d880c
EZ
5570 * process.c: Remove HAVE_INTTYPES_H condition from inclusion of
5571 inttypes.h, as a gnulib replacement is used if it not available in
5572 system headers.
5573
15cbd324
EZ
55742011-04-21 Eli Zaretskii <eliz@gnu.org>
5575
5576 Lift the MOST_POSITIVE_FIXNUM/4 limitation on visited files.
5577 * fileio.c (Finsert_file_contents): Don't limit file size to 1/4
5578 of MOST_POSITIVE_FIXNUM. (Bug#8528)
5579
5580 * coding.c (coding_alloc_by_realloc): Error out if destination
5581 will grow beyond MOST_POSITIVE_FIXNUM.
5582 (decode_coding_emacs_mule): Abort if there isn't enough place in
5583 charbuf for the composition carryover bytes. Reserve an extra
5584 space for up to 2 characters produced in a loop.
5585 (decode_coding_iso_2022): Abort if there isn't enough place in
5586 charbuf for the composition carryover bytes.
5587
55882011-04-21 Eli Zaretskii <eliz@gnu.org>
afda1437 5589
ae940cca
EZ
5590 * doprnt.c (doprnt) [!HAVE_LONG_LONG_INT]: Error out instead of
5591 aborting when %lld or %lll format is passed.
5592 [!HAVE_UNSIGNED_LONG_LONG_INT]: Error out instead of aborting when
5593 %llo or %llx format is passed. (Bug#8545)
5594
03ab8921
EZ
5595 * window.c (window_scroll_line_based): Use a marker instead of
5596 simple variables to record original value of point. (Bug#7952)
5597
afda1437
EZ
5598 * doprnt.c (doprnt): Fix the case where a multibyte sequence
5599 produced by %s or %c overflows available buffer space. (Bug#8545)
5600
f76dee0c
PE
56012011-04-28 Paul Eggert <eggert@cs.ucla.edu>
5602
5603 * doprnt.c (doprnt): Omit useless test; int overflow check (Bug#8545).
283cdbef 5604 (SIZE_MAX): Move defn after all includes, as they might #define it.
f76dee0c 5605
fdc5744d
JB
56062011-04-28 Juanma Barranquero <lekktu@gmail.com>
5607
5608 * w32.c (init_environment): Warn about defaulting HOME to C:\.
5609
638f053a
JB
56102011-04-28 Juanma Barranquero <lekktu@gmail.com>
5611
5612 * keyboard.c (Qdelayed_warnings_hook): Define.
5613 (command_loop_1): Run `delayed-warnings-hook'
5614 if Vdelayed_warnings_list is non-nil.
5615 (syms_of_keyboard) <delayed-warnings-hook>: DEFSYM it.
5616 (syms_of_keyboard) <delayed-warnings-list>: DEFVAR_LISP it.
5617
d178f871
EZ
56182011-04-28 Eli Zaretskii <eliz@gnu.org>
5619
5620 * doprnt.c (doprnt): Don't return value smaller than the buffer
5621 size if the message was truncated. (Bug#8545).
5622
b124fd93
JB
56232011-04-28 Juanma Barranquero <lekktu@gmail.com>
5624
5625 * w32fns.c (Fx_change_window_property, Fx_delete_window_property)
5626 (Fx_window_property): #if-0 the whole functions, not just the bodies.
5627
e810457d
PE
56282011-04-27 Paul Eggert <eggert@cs.ucla.edu>
5629
5630 * doprnt.c (doprnt): Support "ll" length modifier, for long long.
5631
ea51cceb
JB
56322011-04-27 Juanma Barranquero <lekktu@gmail.com>
5633
5634 * makefile.w32-in: Update dependencies.
5635
94dcfacf
EZ
56362011-04-27 Eli Zaretskii <eliz@gnu.org>
5637
5638 Improve `doprnt' and its usage. (Bug#8545)
5639 * doprnt.c (doprnt): Make sure `format' is never accessed beyond
5640 `format_end'. Remove support for %l as a conversion specifier.
5641 Don't use xrealloc. Improve diagnostics when the %l size modifier
5642 is used. Update the commentary.
5643
5644 * eval.c (verror): Simplify calculation of size_t.
5645
5646 * coding.c (Ffind_operation_coding_system): Fix diagnostic error
5647 messages.
5648
f61f41d7
PE
56492011-04-27 Yoshiaki Kasahara <kasahara@nc.kyushu-u.ac.jp> (tiny change)
5650
5651 * buffer.c (init_buffer) [USE_MMAP_FOR_BUFFERS]: Adjust to aliasing
5652 change.
5653
96fb4434
PE
56542011-04-27 Paul Eggert <eggert@cs.ucla.edu>
5655
5656 * nsmenu.m: Replace all uses of XVECTOR with ASIZE and AREF.
5657 This makes this file independent of the recent pseudovector change.
5658
671875da 56592011-04-26 Paul Eggert <eggert@cs.ucla.edu>
eab3844f 5660
69e9b5a3
PE
5661 * keyboard.c (handle_user_signal): Fix pointer signedness problem.
5662
b5f869a7 5663 * gnutls.c (emacs_gnutls_handle_error): Remove unused local.
7754e151 5664 (Fgnutls_boot): gnutls_certificate_verify_peers2 wants unsigned *.
8d4c3955 5665 Remove unused local.
c8926152 5666 (emacs_gnutls_write): Don't use uninitialized rtnval if nbyte <= 0.
080e5a8d 5667
841a1577 5668 * lisp.h: Fix a problem with aliasing and vector headers. (Bug#8546)
04f2d78b
CB
5669 GCC 4.6.0 optimizes based on type-based alias analysis.
5670 For example, if b is of type struct buffer * and v of type struct
eab3844f
PE
5671 Lisp_Vector *, then gcc -O2 was incorrectly assuming that &b->size
5672 != &v->size, and therefore "v->size = 1; b->size = 2; return
5673 v->size;" must therefore return 1. This assumption is incorrect
5674 for Emacs, since it type-puns struct Lisp_Vector * with many other
5675 types. To fix this problem, this patch adds a new type struct
f904488f 5676 vectorlike_header that documents the constraints on layout of vectors
eab3844f
PE
5677 and pseudovectors, and helps optimizing compilers not get fooled
5678 by Emacs's type punning. It also adds the macros XSETTYPED_PVECTYPE
5679 XSETTYPED_PSEUDOVECTOR, TYPED_PSEUDOVECTORP, for similar reasons.
f904488f
PE
5680 * lisp.h (XSETTYPED_PVECTYPE): New macro, specifying the name of
5681 the size member.
eab3844f
PE
5682 (XSETPVECTYPE): Rewrite in terms of new macro.
5683 (XSETPVECTYPESIZE): New macro, specifying both type and size.
5684 This is a bit clearer, and further avoids the possibility of
5685 undesirable aliasing.
5686 (XSETTYPED_PSEUDOVECTOR): New macro, specifying the size.
f904488f 5687 (XSETPSEUDOVECTOR): Rewrite in terms of XSETTYPED_PSEUDOVECTOR.
eab3844f
PE
5688 (XSETSUBR): Rewrite in terms of XSETTYPED_PSEUDOVECTOR and XSIZE,
5689 since Lisp_Subr is a special case (no "next" field).
04f2d78b
CB
5690 (ASIZE): Now uses header.size rather than size.
5691 All previous uses of XVECTOR (foo)->size replaced to use this macro,
f904488f
PE
5692 to avoid the hassle of writing XVECTOR (foo)->header.size.
5693 (struct vectorlike_header): New type.
eab3844f
PE
5694 (TYPED_PSEUDOVECTORP): New macro, also specifying the C type of the
5695 object, to help avoid aliasing.
5696 (PSEUDOVECTORP): Rewrite in terms of TYPED_PSEUDOVECTORP.
5697 (SUBRP): Likewise, since Lisp_Subr is a special case.
5698 * lisp.h (struct Lisp_Vector, struct Lisp_Char_Table):
5699 (struct Lisp_Sub_Char_Table, struct Lisp_Bool_Vector):
5700 (struct Lisp_Hash_Table): Combine first two members into a single
f904488f 5701 struct vectorlike_header member. All uses of "size" and "next" members
eab3844f
PE
5702 changed to be "header.size" and "header.next".
5703 * buffer.h (struct buffer): Likewise.
5704 * font.h (struct font_spec, struct font_entity, struct font): Likewise.
5705 * frame.h (struct frame): Likewise.
5706 * process.h (struct Lisp_Process): Likewise.
5707 * termhooks.h (struct terminal): Likewise.
5708 * window.c (struct save_window_data, struct saved_window): Likewise.
5709 * window.h (struct window): Likewise.
5710 * alloc.c (allocate_buffer, Fmake_bool_vector, allocate_pseudovector):
5711 Use XSETPVECTYPESIZE, not XSETPVECTYPE, to avoid aliasing problems.
5712 * buffer.c (init_buffer_once): Likewise.
5713 * lread.c (defsubr): Use XSETTYPED_PVECTYPE, since Lisp_Subr is a
5714 special case.
5715 * process.c (Fformat_network_address): Use local var for size,
5716 for brevity.
5717
0df1eac5
PE
5718 * bytecode.c (exec_byte_code): Don't use XVECTOR before CHECK_VECTOR.
5719
847ab9d1 5720 Make the Lisp reader and string-to-float more consistent (Bug#8525)
452f4150
PE
5721 * data.c (atof): Remove decl; no longer used or needed.
5722 (digit_to_number): Move to lread.c.
5723 (Fstring_to_number): Use new string_to_number function, to be
5724 consistent with how the Lisp reader treats infinities and NaNs.
5725 Do not assume that floating-point numbers represent EMACS_INT
5726 without losing information; this is not true on most 64-bit hosts.
5727 Avoid double-rounding errors, by insisting on integers when
5728 parsing non-base-10 numbers, as the documentation specifies.
5729 * lisp.h (string_to_number): New decl, replacing ...
5730 (isfloat_string): Remove.
bc0a5c13 5731 * lread.c: Include <inttypes.h>, for uintmax_t and strtoumax.
d78050d6 5732 (read1): Do not accept +. and -. as integers; this
452f4150
PE
5733 appears to have been a coding error. Similarly, do not accept
5734 strings like +-1e0 as floating point numbers. Do not report
5735 overflow for integer overflows unless the base is not 10 which
5736 means we have no simple and reliable way to continue.
5737 Break out the floating-point parsing into a new
5738 function string_to_number, so that Fstring_to_number parses
5739 floating point numbers consistently with the Lisp reader.
04f2d78b 5740 (digit_to_number): Move here from data.c. Make it static inline.
452f4150
PE
5741 (E_CHAR, EXP_INT): Remove, replacing with ...
5742 (E_EXP): New macro, to solve the "1.0e+" problem mentioned below.
5743 (string_to_number): New function, replacing isfloat_string.
5744 This function checks for valid syntax and produces the resulting
5745 Lisp float number too. Rework it so that string-to-number
bc0a5c13 5746 no longer mishandles examples like "1.0e+". Use strtoumax,
d78050d6
PE
5747 so that overflow for non-base-10 numbers is reported only when
5748 there's no portable and simple way to convert to floating point.
452f4150 5749
67769ffc
PE
5750 * textprop.c (set_text_properties_1): Rewrite for clarity,
5751 and to avoid GCC warning about integer overflow.
5752
c20db43f
PE
5753 * intervals.h (struct interval): Use EMACS_INT for members
5754 where EMACS_UINT might cause problems. See
5755 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00514.html>.
5756 (CHECK_TOTAL_LENGTH): Remove cast to EMACS_INT; no longer needed.
5757 * intervals.c (interval_deletion_adjustment): Now returns EMACS_INT.
5758 All uses changed.
37aa2f85
PE
5759 (offset_intervals): Tell GCC not to worry about length overflow
5760 when negating a negative length.
c20db43f 5761
2538aa2f
PE
5762 * alloc.c (overrun_check_malloc, overrun_check_realloc): Now static.
5763 (overrun_check_free): Likewise.
5764
f2d3008d
PE
5765 * alloc.c (SDATA_SIZE) [!GC_CHECK_STRING_BYTES]: Avoid runtime check
5766 in the common case where SDATA_DATA_OFFSET is a multiple of Emacs
5767 word size.
5768
ec8df744
PE
5769 * gnutls.c: Fix problems found by GCC 4.6.0 on Ubuntu 10.10.
5770 (gnutls_make_error): Rename local to avoid shadowing.
5771 (gnutls_emacs_global_deinit): ifdef out; not used.
5772 (Fgnutls_boot): Use const for pointer to readonly storage.
5773 Comment out unused local. Fix pointer signedness problems.
5774
640ee02d
PE
5775 * lread.c (openp): Don't stuff size_t into an 'int'.
5776 Use <= on length, not < on length + 1, to avoid GCC 4.6.0 warning
5777 about possible signed overflow.
5778
6048fb2a
PE
5779 * gtkutil.c: Fix problems found by GCC 4.6.0 on Ubuntu 10.10.
5780 (GDK_KEY_g): Don't define if already defined.
5781 (xg_prepare_tooltip): Avoid pointer signedness problem.
5782 (xg_set_toolkit_scroll_bar_thumb): Redo to avoid two casts.
5783
fa3c87e1
PE
5784 * process.c (Fnetwork_interface_info): Avoid left-shift undefined
5785 behavior with 1 << 31. GCC 4.6.0 warns about this on 32-bit hosts.
5786
2172544b
PE
5787 * xfns.c (Fx_window_property): Simplify a bit,
5788 to make a bit faster and to avoid GCC 4.6.0 warning.
5789 * xselect.c (x_get_window_property, x_handle_dnd_message): Likewise.
5790
9b821a21
PE
5791 * fns.c (internal_equal): Don't assume size_t fits in int.
5792
3c616cfa
PE
5793 * alloc.c (compact_small_strings): Tighten assertion a little.
5794
c2982e87
PE
5795 Replace pEd with more-general pI, and fix some printf arg casts.
5796 * lisp.h (pI): New macro, generalizing old pEd macro to other
5797 conversion specifiers. For example, use "...%"pI"d..." rather
5798 than "...%"pEd"...".
5799 (pEd): Remove. All uses replaced with similar uses of pI.
5800 * src/m/amdx86-64.h, src/m/ia64.h, src/m/ibms390x.h: Likewise.
5801 * alloc.c (check_pure_size): Don't overflow by converting size to int.
5802 * bidi.c (bidi_dump_cached_states): Use pI to avoid cast.
5803 * data.c (Fnumber_to_string): Use pI instead of if-then-else-abort.
5804 * dbusbind.c (xd_append_arg): Use pI to avoid cast.
5805 (Fdbus_method_return_internal, Fdbus_method_error_internal): Likewise.
5806 * font.c (font_unparse_xlfd): Avoid potential buffer overrun on
5807 64-bit hosts.
5808 (font_unparse_xlfd, font_unparse_fcname): Use pI to avoid casts.
5809 * keyboard.c (record_char, modify_event_symbol): Use pI to avoid casts.
5810 * print.c (safe_debug_print, print_object): Likewise.
5811 (print_object): Don't overflow by converting EMACS_INT or EMACS_UINT
5812 to int.
6f04d126
PE
5813 Use pI instead of if-then-else-abort. Use %p to avoid casts,
5814 avoiding the 0 flag, which is not portable.
c2982e87
PE
5815 * process.c (Fmake_network_process): Use pI to avoid cast.
5816 * region-cache.c (pp_cache): Likewise.
5817 * xdisp.c (decode_mode_spec): Likewise.
5818 * xrdb.c (x_load_resources) [USE_MOTIF]: Use pI to avoid undefined
5819 behavior on 64-bit hosts with printf arg.
6f04d126 5820 * xselect.c (x_queue_event): Use %p to avoid casts, avoiding 0 flag.
c2982e87
PE
5821 (x_stop_queuing_selection_requests): Likewise.
5822 (x_get_window_property): Don't truncate byte count to an 'int'
5823 when tracing.
0b432f21 5824
5e073ec7
PE
5825 * frame.c (frame_name_fnn_p): Get rid of strtol, which isn't right
5826 here, since it parses constructs like leading '-' and spaces,
5827 which are not wanted; and it overflows with large numbers.
5828 Instead, simply match F[0-9]+, which is what is wanted anyway.
5829
36372bf9
PE
5830 * alloc.c: Remove unportable assumptions about struct layout.
5831 (SDATA_SELECTOR, SDATA_DATA_OFFSET): New macros.
5832 (SDATA_OF_STRING, SDATA_SIZE, allocate_string_data):
5833 (allocate_vectorlike, make_pure_vector): Use the new macros,
5834 plus offsetof, to remove unportable assumptions about struct layout.
5835 These assumptions hold on all porting targets that I know of, but
5836 they are not guaranteed, they're easy to remove, and removing them
5837 makes further changes easier.
5838
0b432f21
PE
5839 * alloc.c (BLOCK BYTES): Fix typo by changing "ablock" to "ablocks".
5840 This doesn't fix a bug but makes the code clearer.
bfd1c781
PE
5841 (string_overrun_cookie): Now const. Use initializers that
5842 don't formally overflow signed char, to avoid warnings.
000098c1
PE
5843 (allocate_string_data) [GC_CHECK_STRING_OVERRUN]: Fix typo that
5844 can cause Emacs to crash when string overrun checking is enabled.
c7bda33c
PE
5845 (allocate_buffer): Don't assume sizeof (struct buffer) is a
5846 multiple of sizeof (EMACS_INT); it need not be, if
5847 alignof(EMACS_INT) < sizeof (EMACS_INT).
d0f4e1f5 5848 (check_sblock, check_string_bytes, check_string_free_list): Protoize.
0b432f21 5849
895009e1
JB
58502011-04-26 Juanma Barranquero <lekktu@gmail.com>
5851
5852 * keyboard.c (QCrtl): Rename from Qrtl. All uses changed.
5853
6a7a1b0b
TZ
58542011-04-26 Teodor Zlatanov <tzz@lifelogs.com>
5855
5856 * gnutls.c (emacs_gnutls_handshake): Return an error if we're not
b5f869a7 5857 supposed to be handshaking. (Bug#8556)
6a7a1b0b
TZ
5858 Reported by Paul Eggert <eggert@cs.ucla.edu>.
5859
841a1577 58602011-04-26 Daniel Colascione <dan.colascione@gmail.com>
0438ce91
DC
5861
5862 * lisp.h (Qdebug): List symbol.
895009e1 5863 * eval.c (Qdebug): Restore global linkage.
0438ce91
DC
5864 * keyboard.c (debug-on-event): New variable.
5865 (handle_user_signal): Break into debugger when debug-on-event
5866 matches the current signal symbol.
5867
f2d3ba6f
DN
58682011-04-25 Dan Nicolaescu <dann@ics.uci.edu>
5869
5870 * alloc.c (check_sblock, check_string_bytes)
5871 (check_string_free_list): Convert to standard C.
5872
42ce4c63
TZ
58732011-04-25 Teodor Zlatanov <tzz@lifelogs.com>
5874
5875 * w32.c (emacs_gnutls_push): Fix typo.
5876
825cd63c
EZ
58772011-04-25 Eli Zaretskii <eliz@gnu.org>
5878
fb11d64d
EZ
5879 * gnutls.c (emacs_gnutls_handshake): Avoid compiler warnings about
5880 "cast to pointer from integer of different size".
5881
825cd63c
EZ
5882 Improve doprnt and its use in verror. (Bug#8545)
5883 * doprnt.c (doprnt): Document the set of format control sequences
5884 supported by the function. Use SAFE_ALLOCA instead of always
5885 using `alloca'.
5886
5887 * eval.c (verror): Don't limit the buffer size at size_max-1, that
5888 is one byte too soon. Don't use xrealloc; instead xfree and
5889 xmalloc anew.
5890
e061a11b
TZ
58912011-04-24 Teodor Zlatanov <tzz@lifelogs.com>
5892
5893 * gnutls.h: Add GNUTLS_STAGE_CALLBACKS enum to denote we're in the
5894 callbacks stage.
5895
5896 * gnutls.c: Renamed global_initialized to
5897 gnutls_global_initialized. Added internals for the
5898 :verify-hostname-error, :verify-error, and :verify-flags
5899 parameters of `gnutls-boot' and documented those parameters in the
5900 docstring. Start callback support.
9173deec
JB
5901 (emacs_gnutls_handshake): Add Woe32 support. Retry handshake
5902 unless a fatal error occurred. Call gnutls_alert_send_appropriate
5903 on error. Return error code.
e061a11b
TZ
5904 (emacs_gnutls_write): Call emacs_gnutls_handle_error.
5905 (emacs_gnutls_read): Likewise.
5906 (Fgnutls_boot): Return handshake error code.
5907 (emacs_gnutls_handle_error): New function.
5908 (wsaerror_to_errno): Likewise.
5909
5910 * w32.h (emacs_gnutls_pull): Add prototype.
5911 (emacs_gnutls_push): Likewise.
5912
5913 * w32.c (emacs_gnutls_pull): New function for GnuTLS on Woe32.
5914 (emacs_gnutls_push): Likewise.
5915
59162011-04-24 Claudio Bley <claudio.bley@gmail.com> (tiny change)
5917
5918 * process.c (wait_reading_process_output): Check if GnuTLS
5919 buffered some data internally if no FDs are set for TLS
5920 connections.
5921
5922 * makefile.w32-in (OBJ2): Add gnutls.$(O).
5923 (LIBS): Link to USER_LIBS.
5924 ($(BLD)/gnutls.$(0)): New target.
5925
fa6996bc
EZ
59262011-04-24 Eli Zaretskii <eliz@gnu.org>
5927
eb35682e
EZ
5928 * xdisp.c (handle_single_display_spec): Rename the
5929 display_replaced_before_p argument into display_replaced_p, to
5930 make it consistent with the commentary. Fix typos in the
5931 commentary.
5932
e2ad650c
EZ
5933 * textprop.c (syms_of_textprop): Remove dead code.
5934 (copy_text_properties): Delete obsolete commentary about an
5935 interface that was deleted long ago. Fix typos in the description
5936 of arguments.
5937
1b2de274
EZ
5938 * msdos.c (XMenuActivate, XMenuAddSelection): Adjust argument list
5939 to changes in oldXMenu/XMenu.h from 2011-04-16.
5940 <menu_help_message, prev_menu_help_message>: Constify.
5941 (IT_menu_make_room): menu->help_text is now `const char **';
5942 adjust.
5943
5944 * msdos.h (XMenuActivate, XMenuAddSelection): Adjust prototypes
5945 to changes in oldXMenu/XMenu.h from 2011-04-16.
5946 (struct XMenu): Declare `help_text' `const char **'.
5947
5948 * xfaces.c <Qunspecified>: Make extern again.
5949
5950 * syntax.c: Include sys/types.h before including regex.h, as
5951 required by Posix.
5952
762b15be
EZ
5953 * doc.c (get_doc_string): Improve the format passed to `error'.
5954
5955 * doprnt.c (doprnt): Improve commentary.
5956
5957 * term.c (init_tty) [MSDOS]: Fix 1st argument to maybe_fatal.
5958
5959 * Makefile.in (TAGS): Depend on $(M_FILE) and $(S_FILE), and scan
5960 them with etags.
5961
f1052e5d
EZ
5962 * makefile.w32-in (globals.h): Add a dummy recipe, to make any
5963 changes in globals.h immediately force recompilation.
762b15be
EZ
5964 (TAGS): Depend on $(CURDIR)/m/intel386.h and
5965 $(CURDIR)/s/ms-w32.h.
5966 (TAGS-gmake): Scan $(CURDIR)/m/intel386.h and $(CURDIR)/s/ms-w32.h.
f1052e5d 5967
fa6996bc
EZ
5968 * character.c (Fchar_direction): Function deleted.
5969 (syms_of_character): Don't defsubr it.
5970 <char-direction-table>: Deleted.
5971
e6c3da20
EZ
59722011-04-23 Eli Zaretskii <eliz@gnu.org>
5973
5974 Fix doprnt so it could be used again safely in `verror'. (Bug#8435)
5975 * doprnt.c: Include limits.h.
5976 (SIZE_MAX): New macro.
04f2d78b
CB
5977 (doprnt): Return a size_t value. 2nd arg is now size_t.
5978 Many local variables are now size_t instead of int or unsigned.
e6c3da20
EZ
5979 Improve overflow protection. Support `l' modifier for integer
5980 conversions. Support %l conversion. Don't assume an EMACS_INT
5981 argument for integer conversions and for %c.
5982
5983 * lisp.h (doprnt): Restore prototype.
5984
5985 * makefile.w32-in ($(BLD)/callint.$(O)): Depend on
5986 $(SRC)/character.h.
5987
5988 * Makefile.in (base_obj): Add back doprnt.o.
5989
5990 * deps.mk (doprnt.o): Add back prerequisites.
5991 (callint.o): Depend on character.h.
5992
5993 * eval.c (internal_lisp_condition_case): Include the handler
5994 representation in the error message.
5995 (verror): Call doprnt instead of vsnprintf. Fix an off-by-one bug
5996 when breaking from the loop.
5997
5998 * xdisp.c (vmessage): Call doprnt instead of vsnprintf.
5999
6000 * callint.c (Fcall_interactively): When displaying error message
6001 about invalid control letter, pass the character's codepoint, not
6002 a pointer to its multibyte form. Improve display of the character
6003 in octal and display also its hex code.
6004
6005 * character.c (char_string): Use %x to display the (unsigned)
6006 codepoint of an invalid character, to avoid displaying a bogus
6007 negative value.
6008
6009 * font.c (check_otf_features): Pass SDATA of SYMBOL_NAME to
6010 `error', not SYMBOL_NAME itself.
6011
6012 * coding.c (Fencode_sjis_char, Fencode_big5_char): Use %c for
6013 character arguments to `error'.
6014
6015 * charset.c (check_iso_charset_parameter): Fix incorrect argument
6016 to `error' in error message about FINAL_CHAR argument. Make sure
6017 FINAL_CHAR is a character, and use %c when it is passed as
6018 argument to `error'.
6019
4ffd0d6b 60202011-04-23 Eli Zaretskii <eliz@gnu.org>
97a93095
EZ
6021
6022 * s/ms-w32.h (localtime): Redirect to sys_localtime.
6023
6024 * w32.c: Include <time.h>.
6025 (sys_localtime): New function.
6026
4ffd0d6b 60272011-04-23 Chong Yidong <cyd@stupidchicken.com>
c17819f4
CY
6028
6029 * xdisp.c (init_xdisp): Initialize echo_area_window (Bug#6451).
6030
4ffd0d6b 6031 * buffer.c (syms_of_buffer): Doc fix (Bug#6902).
aac0c6e3 6032
4ffd0d6b 60332011-04-23 Samuel Thibault <sthibault@debian.org> (tiny change)
aac0c6e3 6034
4ffd0d6b
GM
6035 * sysdep.c (wait_for_termination): On GNU Hurd, kill returns -1 on
6036 zombies (Bug#8467).
aac0c6e3 6037
04c56954
EZ
60382011-04-19 Eli Zaretskii <eliz@gnu.org>
6039
6040 * syntax.h (SETUP_SYNTAX_TABLE_FOR_OBJECT): Fix setting of
6041 gl_state.e_property when gl_state.object is Qt.
6042
6043 * insdel.c (make_gap_larger): Remove limitation of buffer size
6044 to <= INT_MAX.
6045
16a43933
CY
60462011-04-18 Chong Yidong <cyd@stupidchicken.com>
6047
6048 * xdisp.c (lookup_glyphless_char_display)
6049 (produce_glyphless_glyph): Handle cons cell entry in
6050 glyphless-char-display.
6051 (Vglyphless_char_display): Document it.
6052
6053 * term.c (produce_glyphless_glyph): Handle cons cell entry in
6054 glyphless-char-display.
6055
4581706e
CY
60562011-04-17 Chong Yidong <cyd@stupidchicken.com>
6057
6058 * xdisp.c (get_next_display_element): Remove unnecessary ifdefs.
6059
6060 * termhooks.h (FRAME_WINDOW_P): Remove duplicated definitions.
6061
6062 * dispextern.h (FACE_SUITABLE_FOR_ASCII_CHAR_P): Add missing
6063 definition for no-X builds.
6064
4887c6e2 60652011-04-16 Paul Eggert <eggert@cs.ucla.edu>
764430a3 6066
fd35b6f9
PE
6067 Static checks with GCC 4.6.0 and non-default toolkits.
6068
5c1ccb01
PE
6069 * s/sol2-6.h, s/unixware.h (PTY_TTY_NAME_SPRINTF): Protoize decl.
6070
006c5daa
PE
6071 * process.c (keyboard_bit_set): Define only if SIGIO.
6072 (send_process_trap): Mark it with NO_RETURN if it doesn't return.
6073 (send_process): Repair possible setjmp clobbering.
6074
efc736d3
PE
6075 * s/usg5-4-common.h (SETUP_SLAVE_PTY): Don't pass extra arg to 'fatal'.
6076
4e2fe2e6
PE
6077 * eval.c: Include <stdio.h>, for vsnprintf on non-GNU/Linux hosts.
6078
f97334a2
PE
6079 * data.c (arith_error): Mark with NO_RETURN if it doesn't return.
6080
4e75f29d
PE
6081 * alloc.c (bytes_used_when_full, SPARE_MEMORY, BYTES_USED):
6082 Define only if needed.
6083
90efadd1
PE
6084 * sysdep.c (_FILE_OFFSET_BITS): Make this hack even uglier
6085 by pacifying GCC about it. Maybe it's time to retire it?
875975e9 6086 * xfaces.c (USG, __TIMEVAL__): Likewise.
90efadd1 6087
3c647824
PE
6088 * dispextern.h (struct redisplay_interface): Rename param
6089 to avoid shadowing.
e264f262 6090 * termhooks.h (struct terminal): Likewise.
761383f4 6091 * xterm.c (xembed_send_message): Likewise.
3c647824 6092
b58c5c4a
PE
6093 * insdel.c (make_gap_smaller): Define only if
6094 USE_MMAP_FOR_BUFFERS || REL_ALLOC || DOUG_LEA_MALLOC.
6095
cad59032
PE
6096 * keyboard.c (read_char): Make a var volatile so longjmp won't clobber
6097 it.
6098
c339dc2e
PE
6099 * emacs.c (MAX_HEAP_BSS_DIFF, my_edata): Move to where they're used,
6100 so that we aren't warned about unused symbols.
6101
91a3e27b
PE
6102 * xfns.c (Fx_file_dialog): Rename local to avoid shadowing.
6103
399c71d3 6104 * xdisp.c (x_produce_glyphs): Mark var as initialized (Bug#8512).
7a3fb125 6105
8ffc96f5
PE
6106 * xfns.c (x_real_positions): Mark locals as initialized.
6107
eef9bc79
PE
6108 * xmenu.c (xmenu_show): Don't use uninitialized vars.
6109
098db9dd
PE
6110 * xterm.c: Fix problems found by static analysis with other toolkits.
6111 (toolkit_scroll_bar_interaction): Define and use only if USE_X_TOOLKIT.
dda3aedd
PE
6112 (x_dispatch_event): Declare static if USE_GTK, and
6113 define if USE_GTK || USE_X_TOOLKIT.
098db9dd 6114 (SET_SAVED_BUTTON_EVENT): Define only if USE_X_TOOLKIT || USE_GTK.
dda3aedd 6115 * xterm.h (x_dispatch_event): Extern only if USE_X_TOOLKIT.
841a1577
JB
6116 * xterm.c, xterm.h (x_mouse_leave): Bring this function back, but only
6117 if defined HAVE_MENUS && !defined USE_X_TOOLKIT && !defined USE_GTK.
098db9dd 6118
eb18f6cc
PE
6119 * xmenu.c (menu_help_callback): Pointer type fixes.
6120 Use const pointers when pointing at readonly data. Avoid pointer
6121 signedness clashes.
6122 (FALSE): Remove unused macro.
6123 (update_frame_menubar): Remove unused decl.
6124
1fe72bf8
PE
6125 * xfns.c (Fx_hide_tip): Move locals to avoid shadowing.
6126
60d9e1db
PE
6127 * menu.c (push_submenu_start, push_submenu_end): Do not define unless
6128 USE_X_TOOLKIT || USE_GTK || HAVE_NS || defined HAVE_NTGUI.
6129 (single_menu_item): Rename local to avoid shadowing.
6130
39261c26
PE
6131 * keyboard.c (make_lispy_event): Remove unused local var.
6132
018c5e19
PE
6133 * frame.c, frame.h (x_get_resource_string): Bring this back, but
6134 only if HAVE_X_WINDOWS && !USE_X_TOOLKIT.
6135
63d2b86e
PE
6136 * bitmaps: Change bitmaps from unsigned char back to the X11
6137 compatible char. Avoid the old compiler warnings about
6138 out-of-range initializers by using, for example, '\xab' rather
6139 than 0xab.
6140
aefd87e1
PE
6141 * xgselect.c (xgselect_initialize): Check vs interface
6142 even if ! (defined (USE_GTK) || defined (HAVE_GCONF)).
6143
bf501fb9
PE
6144 * xmenu.c (xmenu_show): Rename parm to avoid shadowing.
6145
e9829fdf
PE
6146 * xterm.c (x_create_toolkit_scroll_bar): Use const * for pointers
6147 to read-only memory.
6148
1086c095
PE
6149 * fns.c (vector): Remove; this old hack is no longer needed.
6150
2baccd04 6151 * xsmfns.c (create_client_leader_window): Rename shadowing arg.
401f10cb 6152 Remove unused var.
dde42981 6153 (gdk_x11_set_sm_client_id) [!USE_GTK]: Don't define.
2baccd04 6154
72391843 6155 * xrdb.c (x_load_resources): Omit unused local.
3565b346 6156
436c16df 6157 * xfns.c (free_frame_menubar, atof): Remove duplicate decls.
8a94ea33 6158 (x_window): Rename locals to avoid shadowing.
dc5ddd85 6159 (USG): Use the kludged USG macro, to pacify gcc.
436c16df 6160
92bb796d 6161 * xterm.c (x_alloc_nearest_color_for_widget): Remove; unused.
bbbef9e1 6162 (x_term_init): Remove local to avoid shadowing.
92bb796d 6163
764430a3 6164 * xfns.c, xterm.c (_XEditResCheckMessages): Protoize decl.
4887c6e2
PE
6165
6166 * xdisp.c, dispextern.h (set_vertical_scroll_bar): Now extern if
6167 USE_TOOLKIT_SCROLL_BARS && !USE_GTK, as xterm.c needs it then.
6168
d1dfb56c
EZ
61692011-04-16 Eli Zaretskii <eliz@gnu.org>
6170
c4354cb4
EZ
6171 * gnutls.c (Fgnutls_boot): Don't pass Lisp_Object to `error'.
6172
d1dfb56c
EZ
6173 Fix regex.c, syntax.c and friends for buffers > 2GB.
6174 * syntax.h (struct gl_state_s): Declare character position members
6175 EMACS_INT.
6176
6177 * syntax.c (update_syntax_table): Declare 2nd argument EMACS_INT.
6178
04f2d78b
CB
6179 * textprop.c (verify_interval_modification, interval_of):
6180 Declare arguments EMACS_INT.
d1dfb56c
EZ
6181
6182 * intervals.c (adjust_intervals_for_insertion): Declare arguments
6183 EMACS_INT.
6184
6185 * intervals.h (CHECK_TOTAL_LENGTH): Cast to EMACS_INT, not `int'.
6186
6187 * indent.c (Fvertical_motion): Local variable it_start is now
6188 EMACS_INT.
6189
6190 * regex.c (re_match, re_match_2, re_match_2_internal)
6191 (bcmp_translate, regcomp, regexec, print_double_string)
6192 (group_in_compile_stack, re_search, re_search_2, regex_compile)
6193 (re_compile_pattern, re_exec): Declare arguments and local
6194 variables `size_t' and `ssize_t' and return values `regoff_t', as
6195 appropriate.
6196 (POP_FAILURE_REG_OR_COUNT) <pfreg>: Declare `long'.
6197 (CHECK_INFINITE_LOOP) <failure>: Declare `ssize_t'.
6198 <compile_stack_type>: `size' and `avail' are now `size_t'.
6199
6200 * regex.h <regoff_t>: Use ssize_t, not int.
6201 (re_search, re_search_2, re_match, re_match_2): Arguments that
6202 specify buffer/string position and length are now ssize_t and
6203 size_t. Return type is regoff_t.
6204
613052cd
BK
62052011-04-16 Ben Key <bkey76@gmail.com>
6206
6207 * nsfont.m: Fixed bugs in ns_get_family and
6208 ns_descriptor_to_entity that were caused by using free to
6209 deallocate memory blocks that were allocated by xmalloc (via
6210 xstrdup). This caused Emacs to crash when compiled with
6211 XMALLOC_OVERRUN_CHECK defined (when Emacs was configured with
6212 --enable-checking=xmallocoverrun). xfree is now used to
6213 deallocate these memory blocks.
6214
4170f62f 62152011-04-15 Paul Eggert <eggert@cs.ucla.edu>
3e047f51 6216
71b41406
PE
6217 * sysdep.c (emacs_read): Remove unnecessary check vs MAX_RW_COUNT.
6218
9587a89d
PE
6219 emacs_write: Accept and return EMACS_INT for sizes.
6220 See http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00514.html
6221 et seq.
6222 * gnutls.c, gnutls.h (emacs_gnutls_read, emacs_gnutls_write):
6223 Accept and return EMACS_INT.
6224 (emacs_gnutls_write): Return the number of bytes written on
6225 partial writes.
6226 * sysdep.c, lisp.h (emacs_read, emacs_write): Likewise.
273a5f82
PE
6227 (emacs_read, emacs_write): Remove check for negative size, as the
6228 Emacs source code has been audited now.
9587a89d
PE
6229 * sysdep.c (MAX_RW_COUNT): New macro, to work around kernel bugs.
6230 (emacs_read, emacs_write): Use it.
273a5f82
PE
6231 * process.c (send_process): Adjust to the new signatures of
6232 emacs_write and emacs_gnutls_write. Do not attempt to store
6233 a byte offset into an 'int'; it might overflow.
9587a89d 6234 See http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00483.html
273a5f82 6235
3e047f51
PE
6236 * sound.c: Don't assume sizes fit in 'int'.
6237 (struct sound_device.period_size, alsa_period_size):
9c3c56a7 6238 Return EMACS_INT, not int.
3e047f51 6239 (struct sound_device.write, vox_write, alsa_write):
9c3c56a7
PE
6240 Accept EMACS_INT, not int.
6241 (wav_play, au_play): Use EMACS_INT to store sizes and to
3e047f51
PE
6242 record read return values.
6243
cc39a9db
BK
62442011-04-15 Ben Key <bkey76@gmail.com>
6245
c9d0ec6d
JB
6246 * keyboard.c (Qundefined): Don't declare static since it is used
6247 in nsfns.m.
6248 * xfaces.c (Qbold, Qexpanded, Qitalic, Qcondensed): Don't declare
6249 static since they are used in nsfont.m.
cc39a9db 6250
6c60eb9f
SM
62512011-04-15 Stefan Monnier <monnier@iro.umontreal.ca>
6252
6253 * process.c (Qprocessp): Don't declare static.
6254 * lisp.h (Qprocessp): Declare again.
6255
7990b61a
JB
62562011-04-15 Juanma Barranquero <lekktu@gmail.com>
6257
6258 * font.c (Qopentype): Don't make static (used from w32uniscribe.c).
6259
5d4cb038
PE
62602011-04-14 Paul Eggert <eggert@cs.ucla.edu>
6261
8bd7b830 6262 Improve C-level modularity by making more things 'static'.
cd64ea1d 6263
e3b27b31
PE
6264 Don't publish debugger-only interfaces to other modules.
6265 * lisp.h (safe_debug_print, debug_output_compilation_hack):
6266 (verify_bytepos, count_markers): Move decls to the only modules
6267 that need them.
6268 * region-cache.h (pp_cache): Likewise.
6269 * window.h (check_all_windows): Likewise.
6270 * marker.c, print.c, region-cache.c, window.c: Decls moved here.
6271
5d4cb038
PE
6272 * sysdep.c (croak): Now static, if
6273 defined TIOCNOTTY || defined USG5 || defined CYGWIN.
6274 * syssignal.h (croak): Declare only if not static.
69003fd8
PE
6275
6276 * alloc.c (refill_memory_reserve): Now static if
6277 !defined REL_ALLOC || defined SYSTEM_MALLOC.
6278 * lisp.h (refill_memory_reserve): Declare only if not static.
93ea6e8f 6279
e87b6180
PE
6280 * xsettings.c, xsettings.h (xsettings_get_system_normal_font):
6281 Define only if USE_LUCID.
6282
ac64929e
PE
6283 * xrdb.c (x_customization_string, x_rm_string): Now static.
6284
6f37259d
PE
6285 * xmenu.c (x_menu_wait_for_event): Export only if USE_MOTIF.
6286 * xterm.h (x_menu_wait_for_event): Declare only if USE_MOTIF.
6287
1683e3ab
PE
6288 * xdisp.c (draw_row_with_mouse_face): Now static.
6289 * dispextern.h (draw_row_with_mouse_fave): Remove decl.
6290
de9c2632
PE
6291 * window.h (check_all_windows): Mark externally visible.
6292
2b96acb7
PE
6293 * window.c (window_deletion_count): Now static.
6294
6295 * undo.c: Make symbols static if they're not exported.
6296 (last_undo_buffer, last_boundary_position, pending_boundary):
6297 Now static.
6298
50436f33
PE
6299 * textprop.c (interval_insert_behind_hooks): Now static.
6300 (interval_insert_in_front_hooks): Likewise.
6301
64520e5c
PE
6302 * term.c: Make symbols static if they're not exported.
6303 (tty_turn_off_highlight, get_tty_terminal, max_frame_cols):
6304 (max_frame_lines, tty_set_terminal_modes):
6305 (tty_reset_terminal_modes, tty_turn_off_highlight):
6306 (get_tty_terminal): Now static.
6307 (term_mouse_moveto): Do not define if HAVE_WINDOW_SYSTEM.
6308 * termhooks.h (term_mouse_moveto): Do not declare if
8bd7b830 6309 HAVE_WINDOW_SYSTEM.
64520e5c
PE
6310 * dispextern.h (tty_set_terminal_modes, tty_reset_terminal_modes):
6311 (tty_turn_off_highlight, get_tty_terminal): Remove decls.
6312
1fa53021
PE
6313 * sysdep.c: Make symbols static if they're not exported.
6314 (emacs_get_tty, emacs_set_tty, old_fcntl_flags, old_fcntl_owner):
6315 Now static.
6316 (sigprocmask_set, full_mask): Remove; unused.
6317 (wait_debugging): Mark as visible.
6318 * syssignal.h (SIGFULLMASK, full_mask): Remove decls.
6319 * systty.h (emacs_get_tty, emacs_set_tty): Remove decls.
6320
d4b43b22
PE
6321 * syntax.c (syntax_temp): Define only if !__GNUC__.
6322
b7c513d0
PE
6323 * sound.c (current_sound_device, current_sound): Now static.
6324
989b29ad
PE
6325 * search.c (searchbufs, searchbuf_head): Now static.
6326
13a55a78
PE
6327 * scroll.c (scroll_cost): Remove; unused.
6328 * dispextern.h (scroll_cost): Remove decl.
6329
de68a1fc
PE
6330 * region-cache.h (pp_cache): Mark as externally visible.
6331
40ccffa6
PE
6332 * process.c: Make symbols static if they're not exported.
6333 (process_tick, update_tick, create_process, chan_process):
6334 (Vprocess_alist, proc_buffered_char, datagram_access):
6335 (fd_callback_data, send_process_frame, process_sent_to): Now static.
6336 (deactivate_process): Mark defn as static, as well as decl.
6337 * lisp.h (create_process): Remove decl.
6338 * process.h (chan_process, Vprocess_alist): Remove decls.
6339
ad64fc97
PE
6340 * print.c: Make symbols static if they're not exported.
6341 (print_depth, new_backquote_output, being_printed, print_buffer):
6342 (print_buffer_size, print_buffer_pos, print_buffer_pos_byte):
6343 (print_interval, print_number_index, initial_stderr_stream):
6344 Now static.
6345 * lisp.h (Fprinc): Remove decl.
6346 (debug_output_compilation_hack): Mark as externally visible.
6347
adddb265
PE
6348 * sysdep.c (croak): Move decl from here to syssignal.h.
6349 * syssignal.h (croak): Put it here, so the API can be checked when
6350 'croak' is called from dissociate_if_controlling_tty.
6351
1717ede2
PE
6352 * minibuf.c: Make symbols static if they're not exported.
6353 (minibuf_save_list, choose_minibuf_frame): Now static.
6354 * lisp.h (choose_minibuf_frame): Remove decl.
6355
fa5fb2bc
PE
6356 * lisp.h (verify_bytepos, count_markers): Mark as externally visible.
6357
1e3890d1
PE
6358 * lread.c: Make symbols static if they're not exported.
6359 (read_objects, initial_obarray, oblookup_last_bucket_number):
6360 Now static.
6361 (make_symbol): Remove; unused.
6362 * lisp.h (initial_obarray, make_symbol): Remove decls.
6363
8a1414fa
PE
6364 * keyboard.c: Make symbols static if they're not exported.
6365 (single_kboard, recent_keys_index, total_keys, recent_keys):
6366 (this_command_key_count_reset, raw_keybuf, raw_keybuf_count):
6367 (this_single_command_key_start, echoing, last_auto_save):
6368 (read_key_sequence_cmd, dribble, recursive_edit_unwind):
6369 (command_loop, echo_now, keyboard_init_hook, help_char_p):
6370 (quit_throw_to_read_char, command_loop_2, top_level_1, poll_timer):
6371 (Vlispy_mouse_stem, double_click_count):
6372 Now static.
6373 (force_auto_save_soon): Define only if SIGDANGER.
6374 (ignore_mouse_drag_p): Now static if
6375 !defined HAVE_WINDOW_SYSTEM || defined USE_GTK || defined HAVE_NS.
6376 (print_help): Remove; unused.
6377 (stop_character, last_timer_event): Mark as externally visible.
6378 * keyboard.h (ignore_mouse_drag_p): Declare only if
6379 defined HAVE_WINDOW_SYSTEM && !defined USE_GTK && !defined HAVE_NS.
6380 (echo_now, help_char_p, quit_throw_to_read_char): Remove decls.
6381 * lisp.h (echoing): Remove decl.
6382 (force_auto_save_soon): Declare only if SIGDANGER.
6383 * xdisp.c (redisplay_window): Simplify code, to make it more
6384 obvious that ignore_mouse_drag_p is not accessed if !defined
6385 USE_GTK && !defined HAVE_NS.
6386
93ea6e8f
PE
6387 * intervals.c: Make symbols static if they're not exported.
6388 (merge_properties_sticky, merge_interval_right, delete_interval):
6389 Now static.
6390 * intervals.h (merge_interval_right, delete_interval): Remove decls.
6391
77382fcc
PE
6392 * insdel.c: Make symbols static if they're not exported.
6393 However, leave prepare_to_modify_buffer alone. It's never
6394 called from outside this function, but that appears to be a bug.
6395 (combine_after_change_list, combine_after_change_buffer):
4889fc82 6396 (adjust_after_replace, signal_before_change): Now static.
77382fcc
PE
6397 (adjust_after_replace_noundo): Remove; unused.
6398 * lisp.h (adjust_after_replace, adjust_after_replace_noundo):
4889fc82 6399 (signal_before_change): Remove decls.
77382fcc 6400
9306c32e
PE
6401 * indent.c (val_compute_motion, val_vmotion): Now static.
6402
cd44d2eb
PE
6403 * image.c: Make symbols static if they're not exported.
6404 * dispextern.h (x_create_bitmap_from_xpm_data): Do not declare
6405 if USE_GTK.
6406 * image.c (x_create_bitmap_from_xpm_data): Do not define if USE_GTK.
6407 (xpm_color_cache, ct_table, ct_colors_allocated): Now static.
6408
ad9a7a06
PE
6409 * fringe.c (standard_bitmaps): Now static.
6410 (max_used_fringe_bitmap): Now static, unless HAVE_NS.
6411
81626931
PE
6412 * frame.c: Make symbols static if they're not exported.
6413 (x_report_frame_params, make_terminal_frame): Now static.
6414 (get_frame_param): Now static, unless HAVE_NS.
6415 (x_fullscreen_adjust): Define if WINDOWSNT, not if HAVE_WINDOW_SYSTEM.
6416 (x_get_resource_string): Remove; not used.
6417 * frame.h (make_terminal_frame, x_report_frame_params):
6418 (x_get_resource_string); Remove decls.
6419 (x_fullscreen_adjust): Declare only if WINDOWSNT.
6420 * lisp.h (get_frame_param): Declare only if HAVE_NS.
6421
239f9db9
PE
6422 * font.c, fontset.c: Make symbols static if they're not exported.
6423 * dispextern.h (FACE_SUITABLE_FOR_ASCII_CHAR_P): New macro.
6424 (FACE_SUITABLE_FOR_CHAR_P): Use it.
6425 * font.c (font_close_object): Now static.
6426 * font.h (font_close_object): Remove.
6427 * fontset.c (FONTSET_OBJLIST): Remove.
6428 (free_realized_fontset) #if-0 the body, which does nothing.
6429 (face_suitable_for_char_p): #if-0, as it's never called.
6430 * fontset.h (face_suitable_for_char_p): Remove decl.
04f2d78b
CB
6431 * xfaces.c (face_at_string_position):
6432 Use FACE_SUITABLE_FOR_ASCII_CHAR_P, not FACE_SUITABLE_FOR_CHAR_P,
239f9db9
PE
6433 since 0 is always ASCII.
6434
dfcf3579
PE
6435 * fns.c (weak_hash_tables): Now static.
6436
5045092b
PE
6437 * fileio.c: Make symbols static if they're not exported.
6438 (auto_saving, auto_save_mode_bits, auto_save_error_occurred):
6439 (Vwrite_region_annotation_buffers): Now static.
6440
57a96f5c
PE
6441 * eval.c: Make symbols static if they're not exported.
6442 (backtrace_list, lisp_eval_depth, when_entered_debugger): Now static.
6443 * lisp.h (backtrace_list): Remove decl.
6444
35f08c38
PE
6445 * emacs.c: Make symbols static if they're not exported.
6446 (malloc_state_ptr, malloc_using_checking, syms_of_emacs):
6447 (fatal_error_code, fatal_error_signal_hook, standard_args):
6448 Now static.
6449 (fatal_error_signal): Now static, unless FLOAT_CATCH_SIGKILL.
6450 (DEFINE_DUMMY_FUNCTION): Mark function as externally visible.
6451 (__CTOR_LIST__, __DTOR_LIST__): Now externally visible.
6452 * lisp.h (fatal_error_signal_hook): Remove decl.
6453 (fatal_error_signal): Declare only if FLOAT_CATCH_SIGKILL.
6454
f44bd759
PE
6455 * editfns.c: Move a (normally-unused) function to its only use.
6456 * editfns.c, lisp.h (get_operating_system_release): Remove.
6457 * process.c (init_process) [DARWIN_OS]: Do it inline, as it is not
6458 worth the hassle of breaking this out.
6459
b532497d
PE
6460 * xterm.c: Make symbols static if they're not exported.
6461 (x_raise_frame, x_lower_frame, x_wm_set_window_state):
6462 (x_wm_set_icon_pixmap, x_initialize, XTread_socket_fake_io_error):
6463 (x_destroy_window, x_delete_display):
6464 Now static.
6465 (x_dispatch_event): Now static if ! (USE_MOTIF || USE_X_TOOLKIT).
6466 (x_mouse_leave): Remove; unused.
6467 * xterm.h (x_display_info_for_name, x_raise_frame, x_lower_frame):
6468 (x_destroy_window, x_wm_set_window_state, x_wm_set_icon_pixmap):
6469 (x_delete_display, x_initialize, x_set_border_pixel, x_screen_planes):
6470 Remove decls.
6471 (x_mouse_leave): Declare only if WINDOWSNT.
6472 (x_dispatch_event): Declare only if USE_MOTIF or USE_X_TOOLKIT.
6473 (xic_create_fontsetname): Declare only if HAVE_X_WINDOWS &&
6474 USE_X_TOOLKIT.
6475
1675728f
PE
6476 * ftxfont.c: Make symbols static if they're not exported.
6477 (ftxfont_driver): Export only if !defined HAVE_XFT && def8ined
6478 HAVE_FREETYPE.
6479 * font.h (ftxfont_driver): Likewise.
6480
e4cebfca
PE
6481 * xfns.c: Make symbols static if they're not exported.
6482 (x_last_font_name, x_display_info_for_name):
6483 (x_set_foreground_color, x_set_background_color, x_set_mouse_color):
6484 (x_set_cursor_color, x_set_border_pixel, x_set_border_color):
6485 (x_set_cursor_type, x_set_icon_type, x_set_icon_name):
6486 (x_set_scroll_bar_foreground, x_set_scroll_bar_background):
6487 (x_explicitly_set_name, x_set_title, xic_defaut_fontset, tip_timer):
6488 (last_show_tip_args): Now static.
6489 (xic_defaut_fontset, xic_create_fontsetname): Define only if
6490 defined HAVE_X_WINDOWS && defined USE_X_TOOLKIT
6491 (x_screen_planes): Remove; unused.
6492 * dispextern.h (x_screen_planes): Remove decl.
6493
5bf46f05
PE
6494 * dispnew.c: Make symbols static if they're not exported.
6495 * dispextern.h (redraw_garbaged_frames, scrolling):
6496 (increment_row_positions): Remove.
6497 * dispnew.c (new_glyph_matrix, increment_row_positions, scrolling):
6498 (delayed_size_change, glyph_matrix_count, glyph_pool_count):
6499 Now static.
6500 (redraw_garbaged_frames): Remove; unused.
6501
435f4c28
PE
6502 * xfaces.c: Make symbols static if they're not exported.
6503 * dispextern.h (ascii_face_of_lisp_face, free_realized_face):
6504 Remove decls.
6505 * xterm.h (defined_color): Remove decls.
6506 (x_free_dpy_colors): Declare only if USE_X_TOOLKIT.
6507 * xfaces.c (tty_suppress_bold_inverse_default_colors_p):
6508 (menu_face_changed_default, defined_color, free_realized_face):
6509 (x_free_dpy_colors): Define only if USE_X_TOOLKIT.
6510 (ascii_face_of_lisp_face): Remove; unused.
6511
8524aef3
PE
6512 * xdisp.c: Make symbols static if they're not exported.
6513 * dispextern.h (scratch_glyph_row, window_box_edges):
6514 (glyph_to_pixel_coords, set_cursor_from_row):
6515 (get_next_display_element, set_iterator_to_next):
6516 (highlight_trailing_whitespace, frame_to_window_pixel_xy):
6517 (show_mouse_face): Remove decls
6518 * frame.h (message_buf_print): Likewise.
6519 * lisp.h (pop_message, set_message, check_point_in_composition):
6520 Likewise.
6521 * xterm.h (set_vertical_scroll_bar): Likewise.
6522 * xdisp.c (list_of_error, Vmessage_stack, line_number_displayed):
6523 (message_buf_print, scratch_glyph_row, displayed_buffer):
6524 (set_iterator_to_next, pop_message, set_message, set_cursor_from_row):
6525 (get_next_display_element, show_mouse_face, window_box_edges):
6526 (frame_to_window_pixel_xy, check_point_in_composition):
6527 (set_vertical_scroll_bar, highlight_trailing_whitespace): Now static.
6528 (glyph_to_pixel_coords): Remove; unused.
6529
16390cd2
PE
6530 * dired.c (file_name_completion): Now static.
6531
6532 * dbusbind.c (xd_in_read_queued_messages): Now static.
6533
a25f4dfa
PE
6534 * lisp.h (circular_list_error, FOREACH): Remove; unused.
6535 * data.c (circular_list_error): Remove.
6536
14a9c8df
PE
6537 * commands.h (last_point_position, last_point_position_buffer):
6538 (last_point_position_window): Remove decls.
6539 * keyboard.c: Make these variables static.
6540
04f2d78b
CB
6541 * coding.h (coding, code_convert_region, encode_coding_gap):
6542 Remove decls.
74ab6df5
PE
6543 * coding.c (Vsjis_coding_system, Vbig5_coding_system):
6544 (iso_code_class, detect_coding, code_convert_region): Now static.
6545 (encode_coding_gap): Remove; unused.
6546
38dfbee1
PE
6547 * chartab.c (chartab_chars, chartab_bits): Now static.
6548
a2cb4e63
PE
6549 * charset.h (charset_iso_8859_1): Remove decl.
6550 * charset.c (charset_iso_8859_1, charset_emacs, map_charset_for_dump):
6551 Now static.
6552
127198fd
PE
6553 * ccl.h (check_ccl_update, Vccl_program_table): Remove decls.
6554 * ccl.c (Vccl_program_table): Now static.
6555 (check_ccl_update): Remove; unused.
6556
d85b608f
PE
6557 * category.c (SET_CATEGORY_SET, set_category_set): Move here.
6558 * category.h: ... from here.
6559 * category.c (check_category_table, set_category_set): Now static.
6560
31cd66f3
PE
6561 * casetab.c (Vascii_upcase_table, Vascii_eqv_table): Now static.
6562 * lisp.h: Remove these decls.
6563
c358e587
PE
6564 * buffer.c (buffer_count): Remove unused var.
6565
e78aecca
PE
6566 * bidi.c (bidi_dump_cached_states): Mark as externally visible,
6567 so that it's not optimized away.
6568 (bidi_ignore_explicit_marks_for_paragraph_level): Likewise.
6569 * dispextern.h (bidi_dump_cached_states): Remove, since it's
6570 exported only to the debugger.
6571
e192d7d3 6572 * atimer.c (alarm_signal_handler, run_all_atimers): Now static.
04f2d78b 6573 * atimer.h (run_all_atimers): Remove; not exported.
e192d7d3 6574
92470028
PE
6575 font.c: Make copy_font_spec and merge_font_spec ordinary C functions.
6576 * font.c (copy_font_spec): Rename from Fcopy_font_spec, since it
6577 was inaccessible from Lisp.
6578 (merge_font_spec): Likewise, renaming from Fmerge_font_spec.
6579 * font.c, font.h, fontset.c, xfaces.c, xfont.c: Change all uses.
6580
244ed907
PE
6581 alloc.c: Import and export fewer symbols, and remove unused items.
6582 * lisp.h (suppress_checking, die): Declare only if ENABLE_CHECKING
6583 is defined.
6584 (suppress_checking): Add EXTERNALLY_VISIBLE attribute, so that
6585 it's not optimized away by whole-program optimization.
6586 (message_enable_multibyte, free_misc): Remove.
6587 (catchlist, handlerlist, mark_backtrace):
6588 Declare only if BYTE_MARK_STACK.
6589 (mark_byte_stack): Likewise, fixing a ifdef-vs-if typo.
6590 * alloc.c (pure): Export only if VIRT_ADDR_VARIES is defined.
6591 (message_enable_multibyte): Remove decl.
6592 (free_misc, interval_free_list, float_block, float_block_index):
6593 (n_float_blocks, float_free_list, cons_block, cons_block_index):
6594 (cons_free_list, last_marked_index):
6595 Now static.
6596 (suppress_checking, die): Define only if ENABLE_CHECKING is defined.
6597 * eval.c (catchlist, handlerlist): Export only if BYTE_MARK_STACK.
6598 (mark_backtrace): Define only if BYTE_MARK_STACK.
6599 * xdisp.c (message_enable_multibyte): Now static.
6600
61c2b50e 6601 Declare Lisp_Object Q* variables to be 'static' if not exported.
955cbe7b
PE
6602 This makes it easier for human readers (and static analyzers)
6603 to see whether these variables are used from other modules.
6604 * alloc.c, buffer.c, bytecode.c, callint.c, casetab.c, category.c:
6605 * ccl.c, character.c, charset.c, cmds.c, coding.c, composite.c:
6606 * data.c, dbusbind.c, dired.c, editfns.c, eval.c, fileio.c, fns.c:
6607 * font.c, frame.c, fringe.c, ftfont.c, image.c, keyboard.c, keymap.c:
6608 * lread.c, macros.c, minibuf.c, print.c, process.c, search.c:
6609 * sound.c, syntax.c, textprop.c, window.c, xdisp.c, xfaces.c, xfns.c:
6610 * xmenu.c, xselect.c:
6611 Declare Q* vars static if they are not used in other modules.
6612 * ccl.h, character.h, charset.h, coding.h, composite.h, font.h:
6613 * frame.h, intervals.h, keyboard.h, lisp.h, process.h, syntax.h:
6614 Remove decls of unexported vars.
6615 * keyboard.h (EVENT_HEAD_UNMODIFIED): Remove now-unused macro.
6616
95c82688
PE
6617 * lisp.h (DEFINE_FUNC): Make sname 'static'.
6618
16a97296
PE
6619 Make Emacs functions such as Fatom 'static' by default.
6620 This makes it easier for human readers (and static analyzers)
6621 to see whether these functions can be called from other modules.
6622 DEFUN now defines a static function. To make the function external
6623 so that it can be used in other C modules, use the new macro DEFUE.
8bd7b830
PE
6624 * lisp.h (Funibyte_char_to_multibyte, Fsyntax_table_p):
6625 (Finit_image_library):
16a97296
PE
6626 (Feval_region, Fbacktrace, Ffetch_bytecode, Fswitch_to_buffer):
6627 (Ffile_executable_p, Fmake_symbolic_link, Fcommand_execute):
6628 (Fget_process, Fdocumentation_property, Fbyte_code, Ffile_attributes):
6629 Remove decls, since these functions are now static.
6630 (Funintern, Fget_internal_run_time): New decls, since these functions
6631 were already external.
95c82688 6632
16a97296
PE
6633 * alloc.c, buffer.c, callint.c, callproc.c, casefiddle.c, casetab.c:
6634 * ccl.c, character.c, chartab.c, cmds.c, coding.c, data.c, dispnew.c:
6635 * doc.c, editfns.c, emacs.c, eval.c, fileio.c, filelock.c, floatfns.c:
6636 * fns.c, font.c, fontset.c, frame.c, image.c, indent.c:
6637 * keyboard.c, keymap.c, lread.c:
6638 * macros.c, marker.c, menu.c, minibuf.c, print.c, process.c, search.c:
6639 * syntax.c, term.c, terminal.c, textprop.c, undo.c:
6640 * window.c, xdisp.c, xfaces.c, xfns.c, xmenu.c, xsettings.c:
6641 Mark functions with DEFUE instead of DEFUN,
6642 if they are used in other modules.
6643 * buffer.c (Fset_buffer_major_mode, Fdelete_overlay): New forward
6644 decls for now-static functions.
6645 * buffer.h (Fdelete_overlay): Remove decl.
6646 * callproc.c (Fgetenv_internal): Mark as internal.
6647 * composite.c (Fremove_list_of_text_properties): Remove decl.
6648 (Fcomposition_get_gstring): New forward static decl.
6649 * composite.h (Fcomposite_get_gstring): Remove decl.
6650 * dired.c (Ffile_attributes): New forward static decl.
6651 * doc.c (Fdocumntation_property): New forward static decl.
6652 * eval.c (Ffetch_bytecode): New forward static decl.
6653 (Funintern): Remove extern decl; now in .h file where it belongs.
6654 * fileio.c (Fmake_symbolic_link): New forward static decl.
6655 * image.c (Finit_image_library): New forward static decl.
6656 * insdel.c (Fcombine_after_change_execute): Make forward decl static.
6657 * intervals.h (Fprevious_property_change):
6658 (Fremove_list_of_text_properties): Remove decls.
6659 * keyboard.c (Fthis_command_keys): Remove decl.
6660 (Fcommand_execute): New forward static decl.
6661 * keymap.c (Flookup_key): New forward static decl.
6662 (Fcopy_keymap): Now static.
6663 * keymap.h (Flookup_key): Remove decl.
6664 * process.c (Fget_process): New forward static decl.
6665 (Fprocess_datagram_address): Mark as internal.
6666 * syntax.c (Fsyntax_table_p): New forward static decl.
6667 (skip_chars): Remove duplicate decl.
6668 * textprop.c (Fprevious_property_change): New forward static decl.
6669 * window.c (Fset_window_fringes, Fset_window_scroll_bars):
6670 Now internal.
6671 (Fset_window_margins, Fset_window_vscroll): New forward static decls.
6672 * window.h (Fset_window_vscroll, Fset_window_margins): Remove decls.
6673
785bbd42
PE
6674 * editfns.c (Fformat): Remove unreachable code.
6675
8b913b57
AS
66762011-04-14 Andreas Schwab <schwab@linux-m68k.org>
6677
6678 * fileio.c (Finsert_file_contents): Fix typo in 2005-05-13
6679 change. (Bug#8496)
6680
a6744a35
EZ
66812011-04-13 Eli Zaretskii <eliz@gnu.org>
6682
6683 * xdisp.c (handle_invisible_prop): Don't call bidi_paragraph_init
6684 when at ZV. (Bug#8487)
6685
e7974947
AS
66862011-04-12 Andreas Schwab <schwab@linux-m68k.org>
6687
baad03f0
AS
6688 * charset.c (Fclear_charset_maps): Use xfree instead of free.
6689 (Bug#8437)
6690 * keyboard.c (parse_tool_bar_item): Likewise.
6691 * sound.c (sound_cleanup, alsa_close): Likewise.
6692 * termcap.c (tgetent): Likewise.
6693 * xfns.c (x_default_font_parameter): Likewise.
6694 * xsettings.c (read_and_apply_settings): Likewise.
6695
e7974947
AS
6696 * alloc.c (overrun_check_malloc, overrun_check_realloc)
6697 (overrun_check_free): Protoize.
6698
28272684
PE
66992011-04-12 Paul Eggert <eggert@cs.ucla.edu>
6700
6701 * sysdep.c (emacs_read, emacs_write): Check for negative sizes
6702 since callers should never pass a negative size.
6703 Change the signature to match that of plain 'read' and 'write'; see
6704 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00397.html>.
6705 * lisp.h: Update prototypes of emacs_write and emacs_read.
6706
11997c76
EZ
67072011-04-11 Eli Zaretskii <eliz@gnu.org>
6708
6709 * xdisp.c (redisplay_window): Don't try to determine the character
6710 position of the scroll margin if the window start point w->startp
e896f03c 6711 is outside the buffer's accessible region. (Bug#8468)
11997c76 6712
8a2cbd72
EZ
67132011-04-10 Eli Zaretskii <eliz@gnu.org>
6714
6715 Fix write-region and its subroutines for buffers > 2GB.
6716 * fileio.c (a_write, e_write): Modify declaration of arguments and
6717 local variables to support buffers larger than 2GB.
6718 (Fcopy_file): Use EMACS_INT for return value of emacs_read.
6719
6720 * sysdep.c (emacs_write, emacs_read): Use ssize_t for last
6721 argument, local variables, and return value.
6722
6723 * lisp.h: Update prototypes of emacs_write and emacs_read.
6724
6725 * sound.c (vox_write): Use ssize_t for return value of emacs_write.
6726
4073e537 67272011-04-10 Paul Eggert <eggert@cs.ucla.edu>
eb3f1cc8 6728
1ebfdcb6
PE
6729 * xdisp.c (vmessage): Use memchr, not strnlen, which some hosts lack.
6730
b2ded58d
PE
6731 Fix more problems found by GCC 4.6.0's static checks.
6732
7d66342c
PE
6733 * xdisp.c (vmessage): Use a better test for character truncation.
6734
bbf47d44
PE
6735 * charset.c (load_charset_map): <, not <=, for optimization,
6736 and to avoid potential problems with integer overflow.
9248994d 6737 * chartab.c (sub_char_table_set_range, char_table_set_range): Likewise.
f9a68bc5 6738 * casetab.c (set_identity, shuffle): Likewise.
3ab1c7ce 6739 * editfns.c (Fformat): Likewise.
1e69125e 6740 * syntax.c (skip_chars): Likewise.
3befa583 6741
e3019616
PE
6742 * xmenu.c (set_frame_menubar): Allocate smaller local vectors.
6743 This also lets GCC 4.6.0 generate slightly better loop code.
6744
becfa255
PE
6745 * callint.c (Fcall_interactively): <, not <=, for optimization.
6746 (Fcall_interactively): Count the number of arguments produced,
6747 not the number of arguments given. This is simpler and lets GCC
6748 4.6.0 generate slightly better code.
6749
dae0cd48
PE
6750 * ftfont.c: Distingish more carefully between FcChar8 and char.
6751 The previous code passed unsigned char * to a functions like
6752 strlen and xstrcasecmp that expect char *, which does not
6753 conform to the C standard.
6754 (get_adstyle_property, ftfont_pattern_entity): Use FcChar8 for
6755 arguments to FcPatternGetString, and explicitly cast FcChar8 * to
6756 char * when the C standard requires it.
6757
76032d70
PE
6758 * keyboard.c (read_char): Remove unused var.
6759
eb3f1cc8
PE
6760 * eval.c: Port to Windows vsnprintf (Bug#8435).
6761 Include <limits.h>.
6762 (SIZE_MAX): Define if the headers do not.
6763 (verror): Do not give up if vsnprintf returns a negative count.
6764 Instead, grow the buffer. This ports to Windows vsnprintf, which
6765 does not conform to C99. Problem reported by Eli Zaretskii.
6766 Also, simplify the allocation scheme, by avoiding the need for
6767 calling realloc, and removing the ALLOCATED variable.
6768
70476b54
PE
6769 * eval.c (verror): Initial buffer size is 4000 (not 200) bytes.
6770
12020a9e
PE
6771 Remove invocations of doprnt, as Emacs now uses vsnprintf.
6772 But keep the doprint source code for now, as we might revamp it
6773 and use it again (Bug#8435).
ea6c7ae6
PE
6774 * lisp.h (doprnt): Remove.
6775 * Makefile.in (base_obj): Remove doprnt.o.
6776 * deps.mk (doprnt.o): Remove.
6777
5fdb398c
PE
6778 error: Print 32- and 64-bit integers portably (Bug#8435).
6779 Without this change, on typical 64-bit hosts error ("...%d...", N)
6780 was used to print both 32- and 64-bit integers N, which relied on
6781 undefined behavior.
6782 * lisp.h, src/m/amdx86-64.h, src/m/ia64.h, src/m/ibms390x.h (pEd):
6783 New macro.
6784 * lisp.h (error, verror): Mark as printf-like functions.
6785 * eval.c (verror): Use vsnprintf, not doprnt, to do the real work.
6786 Report overflow in size calculations when allocating printf buffer.
6787 Do not truncate output string at its first null byte.
6788 * xdisp.c (vmessage): Use vsnprintf, not doprnt, to do the real work.
6789 Truncate the output at a character boundary, since vsnprintf does not
6790 do that.
6791 * charset.c (check_iso_charset_parameter): Convert internal
6792 character to string before calling 'error', since %c now has the
6793 printf meaning.
6794 * coding.c (Fdecode_sjis_char, Fdecode_big5_char): Avoid int
6795 overflow when computing char to be passed to 'error'. Do not
6796 pass Lisp_Object to 'error'; pass the integer instead.
6797 * nsfns.m (Fns_do_applescript): Use int, not long, since it's
6798 formatted with plain %d.
6799
b189fa66
PE
6800 * eval.c (internal_lisp_condition_case): Don't pass spurious arg.
6801
bff87ef0
PE
6802 * keyboard.c (access_keymap_keyremap): Print func name, not garbage.
6803
7e2cac20
PE
6804 * coding.c (Fdecode_sjis_char): Don't assume CODE fits in int.
6805
ce4d90b5
PE
6806 * xterm.c (x_catch_errors): Remove duplicate declaration.
6807
266c9547
PE
6808 * term.c (maybe_fatal): Mark its 3rd arg as a printf format, too.
6809
79c49ad2
PE
6810 * xdisp.c, lisp.h (message_nolog): Remove; unused.
6811
368f4090
JM
68122011-04-10 Jim Meyering <meyering@redhat.com>
6813
6814 use ssize_t and size_t for read- and write-like emacs_gnutls_* functions
6815 * gnutls.c (emacs_gnutls_read): Adjust signature to be more read-like:
6816 return ssize_t not "int", and use size_t as the buffer length.
6817 (emacs_gnutls_write): Likewise, and make the buffer pointer "const".
6818 * gnutls.h: Update declarations.
6819 * process.c (read_process_output): Use ssize_t, to match.
6820 (send_process): Likewise.
6821
a32d4040
CY
68222011-04-09 Chong Yidong <cyd@stupidchicken.com>
6823
6824 * image.c (Fimagemagick_types): Doc fix, and comment cleanup.
6825
8546720e 68262011-04-09 Chong Yidong <cyd@stupidchicken.com>
aac0c6e3 6827
04f2d78b
CB
6828 * ftfont.c (get_adstyle_property, ftfont_pattern_entity):
6829 Use unsigned char, to match FcChar8 type definition.
aac0c6e3 6830
8546720e
GM
6831 * xterm.c (handle_one_xevent):
6832 * xmenu.c (create_and_show_popup_menu):
6833 * xselect.c (x_decline_selection_request)
6834 (x_reply_selection_request): Avoid type-punned deref of X events.
aac0c6e3 6835
0a2f5c1a 68362011-04-09 Eli Zaretskii <eliz@gnu.org>
a53e2e89
EZ
6837
6838 Fix some uses of `int' instead of EMACS_INT.
6839 * search.c (string_match_1, fast_string_match)
6840 (fast_c_string_match_ignore_case, fast_string_match_ignore_case)
6841 (scan_buffer, find_next_newline_no_quit)
6842 (find_before_next_newline, search_command, Freplace_match)
6843 (Fmatch_data): Make some `int' variables be EMACS_INT.
6844
6845 * xdisp.c (display_count_lines): 3rd argument and return value now
6846 EMACS_INT. All callers changed.
6847 (pint2hrstr): Last argument is now EMACS_INT.
6848
6849 * coding.c (detect_coding_utf_8, detect_coding_emacs_mule)
6850 (detect_coding_iso_2022, detect_coding_sjis, detect_coding_big5)
6851 (detect_coding_ccl, detect_coding_charset, decode_coding_utf_8)
6852 (decode_coding_utf_16, decode_coding_emacs_mule)
6853 (decode_coding_iso_2022, decode_coding_sjis, decode_coding_big5)
6854 (decode_coding_ccl, decode_coding_charset)
6855 <consumed_chars, consumed_chars_base>: Declare EMACS_INT.
6856 (decode_coding_iso_2022, decode_coding_emacs_mule)
6857 (decode_coding_sjis, decode_coding_big5, decode_coding_charset)
6858 <char_offset, last_offset>: Declare EMACS_INT.
6859 (encode_coding_utf_8, encode_coding_utf_16)
6860 (encode_coding_emacs_mule, encode_invocation_designation)
6861 (encode_designation_at_bol, encode_coding_iso_2022)
6862 (encode_coding_sjis, encode_coding_big5, encode_coding_ccl)
6863 (encode_coding_raw_text, encode_coding_charset) <produced_chars>:
6864 Declare EMACS_INT.
6865 (ASSURE_DESTINATION): Declare more_bytes EMACS_INT.
6866 (encode_invocation_designation): Last argument P_NCHARS is now
6867 EMACS_INT.
6868 (decode_eol): Declare pos_byte, pos, and pos_end EMACS_INT.
6869 (produce_chars): from_nchars and to_nchars are now EMACS_INT.
6870
6871 * coding.h (struct coding_system) <head_ascii>: Declare EMACS_INT.
6872 All users changed.
6873
6874 * ccl.c (Fccl_execute_on_string): Declare some variables
6875 EMACS_INT.
6876
8546720e 68772011-04-08 Samuel Thibault <sthibault@debian.org> (tiny change)
0080dc6b
SS
6878
6879 * term.c (init_tty): Fix incorrect ifdef placement (Bug#8450).
6880
4e19a977
CS
68812011-03-19 Christoph Scholtes <cschol2112@googlemail.com>
6882
6883 * process.c (Fformat_network_address): Doc fix.
6884
87302331
R
68852011-04-08 T.V. Raman <tv.raman.tv@gmail.com> (tiny change)
6886
6887 * xml.c (parse_region): Avoid creating spurious whiespace nodes.
6888
cbb59342
CY
68892011-04-08 Chong Yidong <cyd@stupidchicken.com>
6890
6891 * keyboard.c (read_char): Call Lisp function help-form-show,
6892 instead of using internal_with_output_to_temp_buffer.
6893 (Qhelp_form_show): New var.
e0d38eeb 6894 (syms_of_keyboard): Use DEFSYM macro.
cbb59342
CY
6895
6896 * print.c (internal_with_output_to_temp_buffer): Function deleted.
6897
6898 * lisp.h (internal_with_output_to_temp_buffer): Remove prototype.
6899
e67a13ab
CY
69002011-04-06 Chong Yidong <cyd@stupidchicken.com>
6901
04f2d78b
CB
6902 * process.c (Flist_processes): Remove to Lisp.
6903 (list_processes_1): Delete.
e67a13ab 6904
973f782d
EZ
69052011-04-06 Eli Zaretskii <eliz@gnu.org>
6906
7c106b1e
EZ
6907 * msdos.c (careadlinkat, careadlinkatcwd): MS-DOS replacements.
6908
973f782d
EZ
6909 * w32.c (careadlinkat, careadlinkatcwd): New always-fail stubs.
6910
41cf7d1a 69112011-04-06 Paul Eggert <eggert@cs.ucla.edu>
27ccc379 6912
ca23cc88
PE
6913 Fix more problems found by GCC 4.6.0's static checks.
6914
f390e2d5
PE
6915 * xmenu.c (Fx_popup_dialog): Don't assume string is free of formats.
6916
42eea0d0
PE
6917 * menu.c (Fx_popup_menu): Don't assume error_name lacks printf formats.
6918
b69769da 6919 * lisp.h (message, message_nolog, fatal): Mark as printf-like.
1e973bc7 6920
f9541e84
PE
6921 * xdisp.c (vmessage): Mark as a printf-like function.
6922
13841b55
PE
6923 * term.c (vfatal, maybe_fatal): Mark as printf-like functions.
6924
c136c10f
PE
6925 * sound.c (sound_warning): Don't crash if arg contains a printf format.
6926
5e2d4a30
PE
6927 * image.c (tiff_error_handler, tiff_warning_handler): Mark as
6928 printf-like functions.
6929 (tiff_load): Add casts to remove these marks before passing them
6930 to system-supplied API.
6931
583f48b9
PE
6932 * eval.c (Fsignal): Remove excess argument to 'fatal'.
6933
b25d760e
PE
6934 * coding.c (EMIT_ONE_BYTE, EMIT_TWO_BYTES): Use unsigned, not int.
6935 This avoids several warnings with gcc -Wstrict-overflow.
d5efd1d1
PE
6936 (DECODE_COMPOSITION_RULE): If the rule is invalid, goto invalid_code
6937 directly, rather than having caller test rule sign. This avoids
6938 some unnecessary tests.
6939 * composite.h (COMPOSITION_ENCODE_RULE_VALID): New macro.
6940 (COMPOSITION_ENCODE_RULE): Arguments now must be valid. This
6941 affects only one use, in DECODE_COMPOSITION_RULE, which is changed.
b25d760e 6942
bc7b6697 6943 * xfont.c (xfont_text_extents): Remove var that was set but not used.
625a3eb1 6944 (xfont_open): Avoid unnecessary tests.
bc7b6697 6945
27ccc379
PE
6946 * composite.c (composition_gstring_put_cache): Use unsigned integer.
6947
dcd5c89a
PE
6948 * composite.h, composite.c (composition_gstring_put_cache):
6949 Use EMACS_INT, not int, for length.
6950
b13a45c6
PE
6951 * composite.h (COMPOSITION_DECODE_REFS): New macro,
6952 breaking out part of COMPOSITION_DECODE_RULE.
6953 (COMPOSITION_DECODE_RULE): Use it.
6954 * composite.c (get_composition_id): Remove unused local vars,
6955 by using the new macro.
6956
1e792e4d
PE
6957 * textprop.c (set_text_properties_1): Change while to do-while,
6958 since the condition is always true at first.
6959
dc6c6455 6960 * intervals.c (graft_intervals_into_buffer): Mark var as used.
aa86731f
PE
6961 (interval_deletion_adjustment): Return unsigned value.
6962 All uses changed.
dc6c6455 6963
aba7731a
PE
6964 * process.c (list_processes_1, create_pty, read_process_output):
6965 (exec_sentinel): Remove vars that were set but not used.
afd4052b 6966 (create_pty): Remove unnecessary "volatile"s.
bc57d757 6967 (Fnetwork_interface_info): Avoid possibility of int overflow.
82eaa333 6968 (read_process_output): Do adaptive read buffering even if carryover.
fe07cdfa 6969 (read_process_output): Simplify nbytes computation if buffered.
aba7731a 6970
fdfc4bf3
PE
6971 * bytecode.c (exec_byte_code): Rename local to avoid shadowing.
6972
fca8fe46 6973 * syntax.c (scan_words): Remove var that was set but not used.
12cbf13f 6974 (update_syntax_table): Use unsigned instead of int.
fca8fe46 6975
06a0259a 6976 * lread.c (lisp_file_lexically_bound_p): Use ints rather than endptrs.
3c346cc3 6977 (lisp_file_lexically_bound_p, read1): Use unsigned instead of int.
e6eb4e9e 6978 (safe_to_load_p): Make the end-of-loop test the inverse of the in-loop.
06a0259a 6979
e7b9e80f
PE
6980 * print.c (print_error_message): Avoid int overflow.
6981
56201685
PE
6982 * font.c (font_list_entities): Redo for clarity,
6983 so that reader need not know FONT_DPI_INDEX + 1 == FONT_SPACING_INDEX.
6984
78834453 6985 * font.c (font_find_for_lface, Ffont_get_glyphs): Remove unused vars.
790771b1 6986 (font_score): Avoid potential overflow in diff calculation.
78834453 6987
0bc0b309 6988 * fns.c (substring_both): Remove var that is set but not used.
8cd55cb4 6989 (sxhash): Redo loop for clarity and to avoid wraparound warning.
0bc0b309 6990
e610eaca
PE
6991 * eval.c (funcall_lambda): Rename local to avoid shadowing.
6992
b895abce
PE
6993 * alloc.c (mark_object_loop_halt, mark_object): Use size_t, not int.
6994 Otherwise, GCC 4.6.0 optimizes the loop check away since the check
6995 can always succeed if overflow has undefined behavior.
6996
1f1d9321 6997 * search.c (boyer_moore, wordify): Remove vars set but not used.
6f076cc7 6998 (wordify): Omit three unnecessary tests.
1f1d9321 6999
c59478bc
PE
7000 * indent.c (MULTIBYTE_BYTES_WIDTH): Don't compute wide_column.
7001 All callers changed. This avoids the need for an unused var.
7002
79b73827
PE
7003 * casefiddle.c (casify_region): Remove var that is set but not used.
7004
a4db5dfe
PE
7005 * dired.c (file_name_completion): Remove var that is set but not used.
7006
43aae36e
PE
7007 * fileio.c (Finsert_file_contents): Make EOF condition clearer.
7008
2a47c44d 7009 * fileio.c (Finsert_file_contents): Avoid signed integer overflow.
163c5f32 7010 (Finsert_file_contents): Remove unnecessary code checking fd.
2a47c44d 7011
a37c69bf
PE
7012 * minibuf.c (read_minibuf_noninteractive): Use size_t for sizes.
7013 Check for integer overflow on size calculations.
7014
328ab8e7
PE
7015 * buffer.c (Fprevious_overlay_change): Remove var that is set
7016 but not used.
7017
e5a2a5cb
PE
7018 * keyboard.c (menu_bar_items, read_char_minibuf_menu_prompt):
7019 Remove vars that are set but not used.
8d84a6eb 7020 (timer_check_2): Don't assume timer-list and idle-timer-list are lists.
6b043475 7021 (timer_check_2): Mark vars as initialized.
e5a2a5cb 7022
a60e5f68
PE
7023 * gtkutil.c (xg_get_file_with_chooser): Mark var as initialized.
7024
f661cb61 7025 * image.c (lookup_image): Remove var that is set but not used.
35fa624f 7026 (xbm_load): Use parse_p, for gcc -Werror=unused-but-set-variable.
f661cb61 7027
f0397f5a
PE
7028 * fontset.c (Finternal_char_font, Ffontset_info): Remove vars
7029 that are set but not used.
7030
8664db06 7031 * xfns.c (make_invisible_cursor): Don't return garbage
03733ee7 7032 if XCreateBitmapFromData fails (Bug#8410).
8664db06 7033
6abdaa4a
PE
7034 * xselect.c (x_get_local_selection, x_handle_property_notify):
7035 Remove vars that are set but not used.
7036
0ce7538d 7037 * xfns.c (x_create_tip_frame): Remove var that is set but not used.
6abdaa4a 7038 (make_invisible_cursor): Initialize a possibly-uninitialized variable.
0ce7538d 7039
9ae848fc
PE
7040 * xterm.c (x_scroll_bar_to_input_event) [!USE_GTK]:
7041 Remove var that is set but not used.
0b918413
PE
7042 (scroll_bar_windows_size): Now size_t, not int.
7043 (x_send_scroll_bar_event): Use size_t, not int, for sizes.
7044 Check for overflow.
9ae848fc 7045
a5a62657
PE
7046 * xfaces.c (realize_named_face): Remove vars that are set but not used.
7047 (map_tty_color) [!defined MSDOS]: Likewise.
7048
5c5cdd39
PE
7049 * term.c (tty_write_glyphs): Use size_t; this avoids overflow warning.
7050
66ebf983
PE
7051 * coding.c: Remove vars that are set but not used.
7052 (DECODE_COMPOSITION_RULE): Remove 2nd arg, which is unused.
7053 All callers changed.
7054 (decode_coding_utf_8, decode_coding_utf_16 decode_coding_emacs_mule):
7055 (decode_coding_iso_2022, encode_coding_sjis, encode_coding_big5):
7056 (decode_coding_charset): Remove vars that are set but not used.
7057
1be4d761
PE
7058 * bytecode.c (Fbyte_code) [!defined BYTE_CODE_SAFE]: Remove var
7059 that is set but not used.
7060
47553fa8
PE
7061 * print.c (print_object): Remove var that is set but not used.
7062
1f7196bf 7063 Replace 2 copies of readlink code with 1 gnulib version (Bug#8401).
d1fdcab7
PE
7064 The gnulib version avoids calling malloc in the usual case,
7065 and on 64-bit hosts doesn't have some arbitrary 32-bit limits.
7066 * fileio.c (Ffile_symlink_p): Use emacs_readlink.
7067 * filelock.c (current_lock_owner): Likewise.
7068 * lisp.h (READLINK_BUFSIZE, emacs_readlink): New function.
7069 * sysdep.c: Include allocator.h, careadlinkat.h.
7070 (emacs_no_realloc_allocator): New static constant.
7071 (emacs_readlink): New function.
fdb61804
PE
7072 * deps.mk (sysdep.o): Depend on ../lib/allocator.h and on
7073 ../lib/careadlinkat.h.
d1fdcab7 7074
f84c17c7
SM
70752011-04-04 Stefan Monnier <monnier@iro.umontreal.ca>
7076
7077 * keyboard.c (safe_run_hook_funcall): Fix last change (don't stop at the
7078 first non-nil return value).
7079
ef3862ad
JD
70802011-04-03 Jan Djärv <jan.h.d@swipnet.se>
7081
7082 * nsterm.m (ns_update_auto_hide_menu_bar): Define MAC_OS_X_VERSION_10_6
7083 if not defined (Bug#8403).
7084
376a7006
JB
70852011-04-02 Juanma Barranquero <lekktu@gmail.com>
7086
7087 * xdisp.c (display_count_lines): Remove parameter `start',
7088 unused since 1998-01-01T02:27:27Z!rms@gnu.org. All callers changed.
7089 (get_char_face_and_encoding): Remove parameter `multibyte_p',
7090 unused since 2008-05-14T01:40:23Z!handa@m17n.org. All callers changed.
7091 (fill_stretch_glyph_string): Remove parameters `row' and `area',
7092 unused at least since Kim's GUI unification at 2003-03-16T20:45:46Z!storm@cua.dk
7093 and thereabouts. All callers changed.
7094 (get_per_char_metric): Remove parameter `f', unused since
7095 2008-05-14T01:40:23Z!handa@m17n.org. All callers changed.
7096
6ca3801d
JM
70972011-04-02 Jim Meyering <meyering@redhat.com>
7098
7099 do not dereference NULL upon failed strdup
7100 * nsfont.m (ns_descriptor_to_entity): Use xstrdup, not strdup.
7101 (ns_get_family): Likewise.
7102
d8e2b5ba
JB
71032011-04-02 Juanma Barranquero <lekktu@gmail.com>
7104
7105 * eval.c (unwind_to_catch) [DEBUG_GCPRO]: Remove redundant assignment.
7106
8c74fcbd
JD
71072011-04-02 Jan Djärv <jan.h.d@swipnet.se>
7108
7109 * nsterm.m (ns_update_auto_hide_menu_bar): Only for OSX 10.6 or
7110 later (Bug#8403).
7111
7200d79c
SM
71122011-04-01 Stefan Monnier <monnier@iro.umontreal.ca>
7113
03408648 7114 Add lexical binding.
7200d79c 7115
03408648
SM
7116 * window.c (Ftemp_output_buffer_show): New fun.
7117 (Fsave_window_excursion):
7118 * print.c (Fwith_output_to_temp_buffer): Move to subr.el.
7119
7120 * lread.c (lisp_file_lexically_bound_p): New function.
7121 (Fload): Bind Qlexical_binding.
7122 (readevalloop): Remove `evalfun' arg.
7123 Bind Qinternal_interpreter_environment.
7124 (Feval_buffer): Bind Qlexical_binding.
7125 (defvar_int, defvar_bool, defvar_lisp_nopro, defvar_kboard):
7126 Mark as dynamic.
7127 (syms_of_lread): Declare `lexical-binding'.
7128
7129 * lisp.h (struct Lisp_Symbol): New field `declared_special'.
7130
7131 * keyboard.c (eval_dyn): New fun.
7132 (menu_item_eval_property): Use it.
ca105506
SM
7133
7134 * image.c (parse_image_spec): Use Ffunctionp.
ca105506 7135
03408648
SM
7136 * fns.c (concat, mapcar1): Accept byte-code-functions.
7137
7138 * eval.c (Fsetq): Handle lexical vars.
7139 (Fdefun, Fdefmacro, Ffunction): Make closures when needed.
7140 (Fdefconst, Fdefvaralias, Fdefvar): Mark as dynamic.
7141 (FletX, Flet): Obey lexical binding.
7142 (Fcommandp): Handle closures.
7143 (Feval): New `lexical' arg.
7144 (eval_sub): New function extracted from Feval. Use it almost
7145 everywhere where Feval was used. Look up vars in lexical env.
7146 Handle closures.
7147 (Ffunctionp): Move from subr.el.
7148 (Ffuncall): Handle closures.
7149 (apply_lambda): Remove `eval_flags'.
7150 (funcall_lambda): Handle closures and new byte-code-functions.
7151 (Fspecial_variable_p): New function.
7152 (syms_of_eval): Initialize the Vinternal_interpreter_environment var,
7153 but without exporting it to Lisp.
23aba0ea 7154
23aba0ea 7155 * doc.c (Fdocumentation, store_function_docstring):
03408648 7156 * data.c (Finteractive_form): Handle closures.
23aba0ea 7157
03408648
SM
7158 * callint.c (Fcall_interactively): Preserve lexical-binding mode for
7159 interactive spec.
ba83908c 7160
04f2d78b
CB
7161 * bytecode.c (Bstack_ref, Bstack_set, Bstack_set2, BdiscardN):
7162 New byte-codes.
03408648
SM
7163 (exec_byte_code): New function extracted from Fbyte_code to handle new
7164 calling convention for byte-code-functions. Add new byte-codes.
ba83908c 7165
03408648 7166 * buffer.c (defvar_per_buffer): Set new `declared_special' field.
e2abe5a1 7167
03408648 7168 * alloc.c (Fmake_symbol): Init new `declared_special' field.
e2abe5a1 7169
e2abce01
JB
71702011-03-31 Juanma Barranquero <lekktu@gmail.com>
7171
7172 * xdisp.c (redisplay_internal): Fix prototype.
7173
63696a73 71742011-03-31 Eli Zaretskii <eliz@gnu.org>
09725d26 7175
63696a73 7176 * xdisp.c (SCROLL_LIMIT): New macro.
04f2d78b
CB
7177 (try_scrolling): Use it when setting scroll_limit.
7178 Limit scrolling to 100 screen lines.
63696a73
EZ
7179 (redisplay_window): Even when falling back on "recentering",
7180 position point in the window according to scroll-conservatively,
7181 scroll-margin, and scroll-*-aggressively variables. (Bug#6671)
7182
7183 (try_scrolling): When point is above the window, allow searching
7184 as far as scroll_max, or one screenful, to compute vertical
7185 distance from PT to the scroll margin position. This prevents
7186 try_scrolling from unnecessarily failing when
7187 scroll-conservatively is set to a value slightly larger than the
7188 window height. Clean up the case of PT below the margin at bottom
7189 of window: scroll_max can no longer be INT_MAX. When aggressive
7190 scrolling is in use, don't let point enter the opposite scroll
7191 margin as result of the scroll.
7192 (syms_of_xdisp) <scroll-conservatively>: Document the
09725d26
EZ
7193 threshold of 100 lines for never-recentering scrolling.
7194
e4cc2dfc
JB
71952011-03-31 Juanma Barranquero <lekktu@gmail.com>
7196
7197 * dispextern.h (move_it_by_lines):
7198 * xdisp.c (move_it_by_lines): Remove parameter `need_y_p', unused
7199 since 2000-12-29T14:24:09Z!gerd@gnu.org. All callers changed.
7200 (message_log_check_duplicate): Remove parameters `prev_bol' and
7201 `this_bol', unused since 1998-01-01T02:27:27Z!rms@gnu.org. All callers changed.
7202 (redisplay_internal): Remove parameter `preserve_echo_area',
7203 unused since 1999-07-21T21:43:52Z!gerd@gnu.org. All callers changed.
7204
7205 * indent.c (Fvertical_motion):
7206 * window.c (window_scroll_pixel_based, Frecenter):
7207 Don't pass `need_y_p' to `move_it_by_lines'.
7208
1c470562
SM
72092011-03-30 Stefan Monnier <monnier@iro.umontreal.ca>
7210
44f230aa
SM
7211 * eval.c (struct backtrace): Don't cheat with negative numbers, but do
7212 steal a few bits to be more compact.
7213 (interactive_p, Fbacktrace, Fbacktrace_frame, mark_backtrace):
7214 Remove unneeded casts.
7215
1c470562
SM
7216 * bytecode.c (Fbyte_code): CAR and CDR can GC.
7217
888adce9
ZK
72182011-03-30 Zachary Kanfer <zkanfer@gmail.com> (tiny change)
7219
7220 * keyboard.c (Fexecute_extended_command): Do log the "suggest key
7221 binding" message (bug#7967).
7222
f838ed7b
PE
72232011-03-30 Paul Eggert <eggert@cs.ucla.edu>
7224
77861b95
PE
7225 Fix more problems found by GCC 4.6.0's static checks.
7226
de6dbc14
PE
7227 * unexelf.c (unexec) [! (defined _SYSTYPE_SYSV || defined __sgi)]:
7228 Remove unused local var.
7229
f838ed7b
PE
7230 * editfns.c (Fmessage_box): Remove unused local var.
7231
792c7b2b
PE
7232 * xdisp.c (try_window_reusing_current_matrix, x_produce_glyphs):
7233 (note_mode_line_or_margin_highlight, note_mouse_highlight):
7234 Omit unused local vars.
c499e557 7235 * window.c (shrink_windows): Omit unused local var.
b01a1c29 7236 * menu.c (digest_single_submenu): Omit unused local var.
0bc32927
PE
7237 * dispnew.c (update_window) [PERIODIC_PREEMPTION_CHECKING]:
7238 Omit unused local var.
7239
ba0165e1
PE
7240 * keyboard.c (parse_modifiers_uncached, parse_modifiers):
7241 Don't assume string length fits in int.
32ad8845 7242 (keyremap_step, read_key_sequence): Use size_t for sizes.
48011560 7243 (read_key_sequence): Don't check last_real_key_start redundantly.
ba0165e1 7244
3c59b4c9
PE
7245 * callproc.c (Fcall_process, Fcall_process_region): Use SAFE_ALLOCA
7246 instead of alloca (Bug#8344).
7247
a3eed478 7248 * eval.c (Fbacktrace): Don't assume nargs fits in int.
5d5d959d 7249 (Fbacktrace_frame): Don't assume nframes fits in int.
a3eed478 7250
eb4d412d
PE
7251 * syntax.c (scan_sexps_forward): Avoid pointer wraparound.
7252
1658b401
PE
7253 * xterm.c (x_make_frame_visible, same_x_server): Redo to avoid overflow
7254 concerns.
7255
7256 * term.c (produce_glyphless_glyph): Remove unnecessary test.
7257
7258 * cm.c (calccost): Turn while-do into do-while, for clarity.
44f730c8 7259
9a2c6e05
PE
7260 * keyboard.c (syms_of_keyboard): Use the same style as later
7261 in this function when indexing through an array. This also
7262 works around GCC bug 48267.
7263
03d0a109
PE
7264 * image.c (tiff_load): Fix off-by-one image count (Bug#8336).
7265
44f730c8
PE
7266 * xselect.c (x_check_property_data): Return correct size (Bug#8335).
7267
fe75f926
PE
7268 * chartab.c (sub_char_table_ref_and_range): Redo for slight
7269 efficiency gain, and to bypass a gcc -Wstrict-overflow warning.
7270
ffa8c828
PE
7271 * keyboard.c, keyboard.h (num_input_events): Now size_t.
7272 This avoids undefined behavior on integer overflow, and is a bit
7273 more convenient anyway since it is compared to a size_t variable.
7274
c5101a77
PE
7275 Variadic C functions now count arguments with size_t, not int.
7276 This avoids an unnecessary limitation on 64-bit machines, which
7277 caused (substring ...) to crash on large vectors (Bug#8344).
7278 * lisp.h (struct Lisp_Subr.function.aMANY): Now takes size_t, not int.
7279 (DEFUN_ARGS_MANY, internal_condition_case_n, safe_call): Likewise.
77861b95 7280 All variadic functions and their callers changed accordingly.
c5101a77
PE
7281 (struct gcpro.nvars): Now size_t, not int. All uses changed.
7282 * data.c (arith_driver, float_arith_driver): Likewise.
7283 * editfns.c (general_insert_function): Likewise.
7284 * eval.c (struct backtrace.nargs, interactive_p)
7285 (internal_condition_case_n, run_hook_with_args, apply_lambda)
7286 (funcall_lambda, mark_backtrace): Likewise.
7287 * fns.c (concat): Likewise.
7288 * frame.c (x_set_frame_parameters): Likewise.
7289 * fns.c (get_key_arg): Now accepts and returns size_t, and returns
7290 0 if not found, not -1. All callers changed.
7291
dd3f25f7
PE
7292 * alloc.c (garbage_collect): Don't assume stack size fits in int.
7293 (stack_copy_size): Now size_t, not int.
7294 (stack_copy, stack_copy_size): Define only if MAX_SAVE_STACK > 0.
7295
461c2ab9
JB
72962011-03-28 Juanma Barranquero <lekktu@gmail.com>
7297
7298 * coding.c (encode_designation_at_bol): Remove parameter `charbuf_end',
7299 unused since 2002-03-01T01:17:24Z!handa@m17n.org and 2008-02-01T16:01:31Z!miles@gnu.org.
7300 All callers changed.
7301
7302 * lisp.h (multibyte_char_to_unibyte):
7303 * character.c (multibyte_char_to_unibyte): Remove parameter `rev_tbl',
7304 unused since 2002-03-01T01:16:34Z!handa@m17n.org and 2008-02-01T16:01:31Z!miles@gnu.org.
7305 * character.h (CHAR_TO_BYTE8):
7306 * cmds.c (internal_self_insert):
7307 * editfns.c (general_insert_function):
7308 * keymap.c (push_key_description):
7309 * search.c (Freplace_match):
7310 * xdisp.c (message_dolog, set_message_1): All callers changed.
7311
f6d62986
SM
73122011-03-28 Stefan Monnier <monnier@iro.umontreal.ca>
7313
7314 * keyboard.c (safe_run_hook_funcall): New function.
7315 (safe_run_hooks_1, safe_run_hooks_error, safe_run_hooks): On error,
7316 don't set the hook to nil, but remove the offending function instead.
7317 (Qcommand_hook_internal): Remove, unused.
7318 (syms_of_keyboard): Don't initialize Qcommand_hook_internal nor define
7319 Vcommand_hook_internal.
7320
7321 * eval.c (enum run_hooks_condition): Remove.
7322 (funcall_nil, funcall_not): New functions.
7323 (run_hook_with_args): Call each function through a `funcall' argument.
7324 Remove `cond' argument, now redundant.
7325 (Frun_hooks, Frun_hook_with_args, Frun_hook_with_args_until_success)
7326 (Frun_hook_with_args_until_failure): Adjust accordingly.
7327 (run_hook_wrapped_funcall, Frun_hook_wrapped): New functions.
7328
1db5b1ad
JB
73292011-03-28 Juanma Barranquero <lekktu@gmail.com>
7330
7331 * dispextern.h (string_buffer_position): Remove declaration.
7332
7333 * print.c (strout): Remove parameter `multibyte', unused since
7334 1999-08-21T19:30:21Z!gerd@gnu.org. All callers changed.
7335
7336 * search.c (boyer_moore): Remove parameters `len', `pos' and `lim',
7337 never used since function introduction in 1998-02-08T21:33:56Z!rms@gnu.org.
7338 All callers changed.
7339
7340 * w32.c (_wsa_errlist): Use braces for struct initializers.
7341
7342 * xdisp.c (string_buffer_position_lim): Remove parameter `w',
7343 never used since function introduction in 2001-03-09T18:41:50Z!gerd@gnu.org.
7344 All callers changed.
7345 (string_buffer_position): Likewise. Also, make static (it's never
7346 used outside xdisp.c).
7347 (cursor_row_p): Remove parameter `w', unused since
7348 2000-10-17T16:08:57Z!gerd@gnu.org. All callers changed.
7349 (decode_mode_spec): Remove parameter `precision', introduced during
7350 Gerd Moellmann's rewrite at 1999-07-21T21:43:52Z!gerd@gnu.org, but never used.
7351 All callers changed.
7352
5ffb62aa
JD
73532011-03-27 Jan Djärv <jan.h.d@swipnet.se>
7354
7355 * nsterm.m (syms_of_nsterm): Use doc: for ns-auto-hide-menu-bar.
7356
461c2ab9 73572011-03-27 Anders Lindgren <andlind@gmail.com>
f0a1382a
JD
7358
7359 * nsterm.m (ns_menu_bar_is_hidden): New variable.
7360 (ns_constrain_all_frames, ns_menu_bar_should_be_hidden)
7361 (ns_update_auto_hide_menu_bar): New functions.
7362 (ns_update_begin): Call ns_update_auto_hide_menu_bar.
7363 (applicationDidBecomeActive): Call ns_update_auto_hide_menu_bar and
7364 ns_constrain_all_frames.
7365 (constrainFrameRect): Return at once if ns_menu_bar_should_be_hidden.
7366 (syms_of_nsterm): DEFVAR ns-auto-hide-menu-bar, init to Qnil.
7367
5c380ffb
JD
73682011-03-27 Jan Djärv <jan.h.d@swipnet.se>
7369
7370 * nsmenu.m (runDialogAt): Remove argument to timer_check.
7371
9af30bdf
GM
73722011-03-27 Glenn Morris <rgm@gnu.org>
7373
7374 * syssignal.h: Replace RETSIGTYPE with void.
7375 * atimer.c, data.c, dispnew.c, emacs.c, floatfns.c, keyboard.c:
7376 * keyboard.h, lisp.h, process.c, sysdep.c, xterm.c:
7377 Replace SIGTYPE with void everywhere.
7378 * s/usg5-4-common.h (SIGTYPE): Remove definition.
7379 * s/template.h (SIGTYPE): Remove commented out definition.
7380
e2abce01
JB
73812011-03-26 Eli Zaretskii <eliz@gnu.org>
7382
7383 * xdisp.c (redisplay_window): Don't check buffer's clip_changed
7384 flag as a prerequisite for invoking try_scrolling. (Bug#6671)
7385
f868cd8a
JB
73862011-03-26 Juanma Barranquero <lekktu@gmail.com>
7387
59eb0929
JB
7388 * w32.c (read_unc_volume): Use parameter `henum', instead of
7389 global variable `wget_enum_handle'.
7390
7391 * keymap.c (describe_vector): Remove parameters `indices' and
7392 `char_table_depth', unused since 2002-03-01T01:43:26Z!handa@m17n.org.
7393 (describe_map, Fdescribe_vector): Adjust calls to `describe_vector'.
7394
f868cd8a
JB
7395 * keyboard.h (timer_check, show_help_echo): Remove unused parameters.
7396
7397 * keyboard.c (timer_check): Remove parameter `do_it_now',
7398 unused since 1996-04-12T06:01:29Z!rms@gnu.org.
7399 (show_help_echo): Remove parameter `ok_to_overwrite_keystroke_echo',
7400 unused since 2008-04-19T19:30:53Z!monnier@iro.umontreal.ca.
7401
7402 * keyboard.c (read_char):
7403 * w32menu.c (w32_menu_display_help):
7404 * xmenu.c (show_help_event, menu_help_callback):
7405 Adjust calls to `show_help_echo'.
7406
7407 * gtkutil.c (xg_maybe_add_timer):
7408 * keyboard.c (readable_events):
7409 * process.c (wait_reading_process_output):
7410 * xmenu.c (x_menu_wait_for_event): Adjust calls to `timer_check'.
7411
7412 * insdel.c (adjust_markers_gap_motion):
7413 Remove; no-op since 1998-01-02T21:29:48Z!rms@gnu.org.
7414 (gap_left, gap_right): Don't call it.
7415
2ecf6fdb
CY
74162011-03-25 Chong Yidong <cyd@stupidchicken.com>
7417
7418 * xdisp.c (handle_fontified_prop): Discard changes to clip_changed
7419 incurred during fontification.
7420
6b1f9ba4
JB
74212011-03-25 Juanma Barranquero <lekktu@gmail.com>
7422
7423 * buffer.c (defvar_per_buffer): Remove unused parameter `doc'.
7424 (DEFVAR_PER_BUFFER): Don't pass it.
7425
7426 * dispnew.c (row_equal_p, add_row_entry): Remove unused parameter `w'.
7427 (scrolling_window): Don't pass it.
7428
0f4a96b5
JB
74292011-03-25 Juanma Barranquero <lekktu@gmail.com>
7430
7431 * dispextern.h (glyph_matric): Use #if GLYPH_DEBUG, not #ifdef.
7432
7433 * fileio.c (check_executable) [DOS_NT]: Remove unused variables `len'
7434 and `suffix'.
7435 (Fset_file_selinux_context) [HAVE_LIBSELINUX]: Move here declaration
7436 of variables specific to SELinux and computation of `encoded_absname'.
7437
7438 * image.c (XPutPixel): Remove unused variable `height'.
7439
7440 * keyboard.c (make_lispy_event): Remove unused variable `hpos'.
7441
7442 * unexw32.c (get_section_info): Remove unused variable `section'.
7443
7444 * w32.c (stat): Remove unused variables `drive_root' and `devtype'.
7445 (system_process_attributes): Remove unused variable `sess'.
7446 (sys_read): Remove unused variable `err'.
7447
7448 * w32fns.c (top): Wrap variables with #if GLYPH_DEBUG, not #ifdef.
7449 (w32_wnd_proc): Remove unused variable `isdead'.
7450 (unwind_create_frame): Use #if GLYPH_DEBUG, not #ifdef.
7451 (Fx_server_max_request_size): Remove unused variable `dpyinfo'.
7452 (x_create_tip_frame): Remove unused variable `tem'.
7453
7454 * w32inevt.c (w32_console_read_socket):
7455 Remove unused variable `no_events'.
7456
7457 * w32term.c (x_draw_composite_glyph_string_foreground):
7458 Remove unused variable `width'.
7459
1149507c
JB
74602011-03-24 Juanma Barranquero <lekktu@gmail.com>
7461
7462 * w32term.c (x_set_glyph_string_clipping):
7463 Don't pass uninitialized region to CombineRgn.
7464
9c88f339
JB
74652011-03-23 Juanma Barranquero <lekktu@gmail.com>
7466
7467 * w32fns.c (x_set_menu_bar_lines): Remove unused variable `olines'.
7468 (w32_wnd_proc): Pass NULL to Windows API, not uninitialized buffer.
7469 (Fx_close_connection): Remove unused variable `i'.
7470
7471 * w32font.c (w32font_draw): Return number of glyphs.
7472 (w32font_open_internal): Remove unused variable `i'.
7473 (w32font_driver): Add missing initializer.
7474
7475 * w32menu.c (utf8to16): Remove unused variable `utf16'.
7476 (fill_in_menu): Remove unused variable `items_added'.
7477
7478 * w32term.c (last_mouse_press_frame): Remove static global variable.
7479 (w32_clip_to_row): Remove unused variable `f'.
7480 (x_delete_terminal): Remove unused variable `i'.
7481
7482 * w32uniscribe.c (uniscribe_shape): Remove unused variable `nclusters'.
7483 (NOTHING): Remove unused static global variable.
7484 (uniscribe_check_otf): Remove unused variable `table'.
7485 (uniscribe_font_driver): Add missing initializers.
7486
dee091a3
JD
74872011-03-23 Julien Danjou <julien@danjou.info>
7488
7489 * term.c (Fsuspend_tty, Fresume_tty):
7490 * minibuf.c (read_minibuf, run_exit_minibuf_hook):
7491 * window.c (temp_output_buffer_show):
7492 * insdel.c (signal_before_change):
7493 * frame.c (Fhandle_switch_frame):
7494 * fileio.c (Fdo_auto_save):
7495 * emacs.c (Fkill_emacs):
7496 * editfns.c (save_excursion_restore):
7497 * cmds.c (internal_self_insert):
7498 * callint.c (Fcall_interactively):
7499 * buffer.c (Fkill_all_local_variables):
7500 * keyboard.c (Fcommand_execute, Fsuspend_emacs, safe_run_hooks_1):
7501 Use Frun_hooks.
0f4a96b5 7502 (command_loop_1): Use Frun_hooks. Call safe_run_hooks
dee091a3
JD
7503 unconditionnaly since it does the check itself.
7504
2c520ab5 75052011-03-23 Paul Eggert <eggert@cs.ucla.edu>
f0641eff 7506
c9c49752
PE
7507 Fix more problems found by GCC 4.5.2's static checks.
7508
8abc3f12
PE
7509 * coding.c (encode_coding_raw_text): Avoid unnecessary test
7510 the first time through the loop, since we know p0 < p1 then.
7511 This also avoids a gcc -Wstrict-overflow warning.
7512
a2d26660
PE
7513 * lisp.h (SAFE_ALLOCA, SAFE_ALLOCA_LISP): Avoid 'int' overflow
7514 leading to a memory leak, possible in functions like
7515 load_charset_map_from_file that can allocate an unbounded number
b12ef411 7516 of objects (Bug#8318).
a2d26660 7517
916c72e9
PE
7518 * xmenu.c (set_frame_menubar): Use EMACS_UINT, not int, for indexes
7519 that could (at least in theory) be that large.
7520
19ab8a18
PE
7521 * xdisp.c (message_log_check_duplicate): Return unsigned long, not int.
7522 This is less likely to overflow, and avoids undefined behavior if
7523 overflow does occur. All callers changed. Use strtoul to scan
7524 for the unsigned long integer.
b7cbbd6f
PE
7525 (pint2hrstr): Simplify and tune code slightly.
7526 This also avoids a (bogus) GCC warning with gcc -Wstrict-overflow.
19ab8a18 7527
f0641eff
PE
7528 * scroll.c (do_scrolling): Work around GCC bug 48228.
7529 See <http://gcc.gnu.org/bugzilla/show_bug.cgi?id=48228>.
7530
7f650bb9
PE
7531 * frame.c (Fmodify_frame_parameters): Simplify loop counter.
7532 This also avoids a warning with gcc -Wstrict-overflow.
39f5e519
PE
7533 (validate_x_resource_name): Simplify count usage.
7534 This also avoids a warning with gcc -Wstrict-overflow.
7f650bb9 7535
37dd57d1
PE
7536 * fileio.c (Fcopy_file): Report error if fchown or fchmod
7537 fail (Bug#8306).
81e56e61 7538
699979fc 7539 * emacs.c (Fdaemon_initialized): Do not ignore I/O errors (Bug#8303).
dc1ca6a8 7540
401bf9b4
PE
7541 * process.c (Fmake_network_process): Use socklen_t, not int,
7542 where POSIX says socklen_t is required in portable programs.
7543 This fixes a porting bug on hosts like 64-bit HP-UX, where
591b2973 7544 socklen_t is wider than int (Bug#8277).
401bf9b4
PE
7545 (Fmake_network_process, server_accept_connection):
7546 (wait_reading_process_output, read_process_output):
7547 Likewise.
7548
b93aacde
PE
7549 * process.c: Rename or move locals to avoid shadowing.
7550 (list_processes_1, Fmake_network_process):
7551 (read_process_output_error_handler, exec_sentinel_error_handler):
7552 Rename or move locals.
4dc343ee 7553 (Fmake_network_process): Define label "retry_connect" only if needed.
0da49335 7554 (Fnetwork_interface_info): Fix pointer signedness.
f990b4e5 7555 (process_send_signal): Add cast to avoid pointer signedness problem.
7b808126 7556 (FIRST_PROC_DESC, IF_NON_BLOCKING_CONNECT): Remove unused macros.
c939f91b 7557 (create_process): Use 'volatile' to avoid vfork clobbering (Bug#8298).
b93aacde 7558
af8a867c 7559 Make tparam.h and terminfo.c consistent.
44f230aa
SM
7560 * cm.c (tputs, tgoto, BC, UP): Remove extern decls.
7561 Include tparam.h instead, since it declares them.
af8a867c
PE
7562 * cm.h (PC): Remove extern decl; tparam.h now does this.
7563 * deps.mk (cm.o, terminfo.o): Depend on tparam.h.
7564 * terminfo.c: Include tparam.h, to check interfaces.
7565 (tparm): Make 1st arg a const pointer in decl. Put it at top level.
7566 (tparam): Adjust signature to match interface in tparam.h;
7567 this removes some undefined behavior. Check that outstring and len
7568 are zero, which they always are with Emacs.
7569 * tparam.h (PC, BC, UP): New extern decls.
7570
0248044d 7571 * xftfont.c (xftfont_shape): Now static, and defined only if needed.
001a7ab4 7572 (xftfont_open): Rename locals to avoid shadowing.
0248044d 7573
8ff096c1 7574 * ftfont.c (ftfont_resolve_generic_family): Fix pointer signedness.
a00924bb
PE
7575 (ftfont_otf_capability, ftfont_shape): Omit decls if not needed.
7576 (OTF_TAG_SYM): Omit macro if not needed.
e932860f 7577 (ftfont_list): Remove unused local.
49eaafba
PE
7578 (get_adstyle_property, ftfont_pattern_entity):
7579 (ftfont_lookup_cache, ftfont_open, ftfont_anchor_point):
7580 Rename locals to avoid shadowing.
8ff096c1 7581
e2be39f6
PE
7582 * xfont.c (xfont_list_family): Mark var as initialized.
7583
c9735e30
PE
7584 * xml.c (make_dom): Now static.
7585
8f5201ae
PE
7586 * composite.c (composition_compute_stop_pos): Rename local to
7587 avoid shadowing.
b246f932
PE
7588 (composition_reseat_it): Remove unused locals.
7589 (find_automatic_composition, composition_adjust_point): Likewise.
80e079b2 7590 (composition_update_it): Mark var as initialized.
11b61122
PE
7591 (find_automatic_composition): Mark vars as initialized,
7592 with a FIXME (Bug#8290).
8f5201ae 7593
760fbc2c
PE
7594 character.h: Rename locals to avoid shadowing.
7595 * character.h (PREV_CHAR_BOUNDARY, FETCH_STRING_CHAR_ADVANCE):
7596 (FETCH_STRING_CHAR_AS_MULTIBYTE_ADVANCE, FETCH_CHAR_ADVANCE):
7597 (FETCH_CHAR_ADVANCE_NO_CHECK, INC_POS, DEC_POS, BUF_INC_POS):
7598 (BUF_DEC_POS): Be more systematic about renaming local temporaries
7599 to avoid shadowing.
7600
ff08eb85
PE
7601 * textprop.c (property_change_between_p): Remove; unused.
7602
fc7bf025
PE
7603 * intervals.c (interval_start_pos): Now static.
7604
235d7abc
PE
7605 * intervals.h (CHECK_TOTAL_LENGTH): Avoid empty "else".
7606
44f230aa
SM
7607 * atimer.c (start_atimer, append_atimer_lists, set_alarm):
7608 Rename locals to avoid shadowing.
3e7d6594 7609
50060332
PE
7610 * sound.c (wav_play, au_play, Fplay_sound_internal):
7611 Fix pointer signedness.
d01f234b 7612 (alsa_choose_format): Remove unused local var.
c83b8872
PE
7613 (wav_play): Initialize a variable to 0, to prevent undefined
7614 behavior (Bug#8278).
50060332 7615
c4fc4e30
PE
7616 * region-cache.c (insert_cache_boundary): Redo var to avoid shadowing.
7617
918436ed
PE
7618 * region-cache.h (pp_cache): New decl, for gcc -Wmissing-prototypes.
7619
c939f91b
PE
7620 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork
7621 clobbering (Bug#8298).
b9c7f648
PE
7622 * sysdep.c (sys_subshell): Likewise.
7623 Previously, the sys_subshell 'volatile' was incorrectly IF_LINTted out.
7e9123a2 7624
6bd8c144
PE
7625 * lisp.h (child_setup): Now NO_RETURN unless DOS_NT.
7626 This should get cleaned up, so that child_setup has the
7627 same signature on all platforms.
7628
7710357c 7629 * callproc.c (call_process_cleanup): Now static.
cb1d0ef7 7630 (relocate_fd): Rename locals to avoid shadowing.
7710357c 7631
c59da222
CY
76322011-03-22 Chong Yidong <cyd@stupidchicken.com>
7633
7634 * xterm.c (x_clear_frame): Remove XClearWindow call. This appears
7635 not to be necessary, and produces flickering.
7636
66b87493
GM
76372011-03-20 Glenn Morris <rgm@gnu.org>
7638
7639 * config.in: Remove file.
7640
45b6f6d5
JB
76412011-03-20 Juanma Barranquero <lekktu@gmail.com>
7642
7643 * minibuf.c (Vcompleting_read_function): Don't declare, global variables
7644 are now in src/globals.h.
7645 (syms_of_minibuf): Remove spurious & from previous change.
7646
3ec03f7e
LL
76472011-03-20 Leo <sdl.web@gmail.com>
7648
7649 * minibuf.c (completing-read-function): New variable.
7650 (completing-read-default): Rename from completing-read.
7651 (completing-read): Call completing-read-function.
7652
b14e3e21
CY
76532011-03-19 Juanma Barranquero <lekktu@gmail.com>
7654
7655 * xfaces.c (Fx_load_color_file):
7656 Read color file from absolute filename (bug#8250).
7657
f2b726e6
JB
76582011-03-19 Juanma Barranquero <lekktu@gmail.com>
7659
7660 * makefile.w32-in: Update dependencies.
7661
09f6ff02
EZ
76622011-03-17 Eli Zaretskii <eliz@gnu.org>
7663
7664 * makefile.w32-in ($(BLD)/unexw32.$(O)): Depend on $(SRC)/unexec.h.
7665
29a6015a
PE
76662011-03-17 Paul Eggert <eggert@cs.ucla.edu>
7667
a3a6c54e
PE
7668 Fix more problems found by GCC 4.5.2's static checks.
7669
b766f867
PE
7670 * process.c (make_serial_process_unwind, send_process_trap):
7671 (sigchld_handler): Now static.
7672
be02381c
PE
7673 * process.c (allocate_pty): Let PTY_ITERATION declare iteration vars.
7674 That way, the code declares only the vars that it needs.
7675 * s/aix4-2.h (PTY_ITERATION): Declare iteration vars.
7676 * s/cygwin.h (PTY_ITERATION): Likewise.
7677 * s/darwin.h (PTY_ITERATION): Likewise.
7678 * s/gnu-linux.h (PTY_ITERATION): Likewise.
7679
57048744
PE
7680 * s/irix6-5.h (PTY_OPEN): Declare stb, to loosen coupling.
7681 * process.c (allocate_pty): Don't declare stb unless it's needed.
7682
7914961c 7683 * bytecode.c (MAYBE_GC): Rewrite so as not to use empty "else".
615f2d59
PE
7684 (CONSTANTLIM): Remove; unused.
7685 (METER_CODE, Bscan_buffer, Bread_char, Bset_mark):
7686 Define only if needed.
7914961c 7687
b3967b18
PE
7688 * unexelf.c (unexec): Name an expression,
7689 to avoid gcc -Wbad-function-cast warning.
9ae71512
PE
7690 Use a different way to cause a compilation error if anyone uses
7691 n rather than nn, a way that does not involve shadowing.
73366a00 7692 (ELF_BSS_SECTION_NAME, OLD_PROGRAM_H): Remove; unused.
b3967b18 7693
29a6015a
PE
7694 * deps.mk (unexalpha.o): Remove; unused.
7695
43cfc33e 7696 New file unexec.h, the (simple) interface for unexec (Bug#8267).
7feda0d2 7697 * unexec.h: New file.
ce701a33
PE
7698 * deps.mk (emacs.o, unexaix.o, unexcw.o, unexcoff.o, unexelf.o):
7699 (unexhp9k800.o, unexmacosx.o, unexsol.o, unexw32.o):
7700 Depend on unexec.h.
7701 * emacs.c [!defined CANNOT_DUMP]: Include unexec.h.
7702 * unexaix.c, unexcoff.c, unexcw.c, unexelf.c, unexhp9k800.c:
7703 * unexmacosx.c, unexsol.c, unexw32.c: Include unexec.h.
381259ef 7704 Change as necessary to match prototype in unexec.h.
ce701a33 7705
01f44d5a
PE
7706 * syntax.c (Fforward_comment, scan_lists): Rename locals to avoid
7707 shadowing.
4f63c6bb 7708 (back_comment, skip_chars): Mark vars as initialized.
01f44d5a 7709
a6670b0b
PE
7710 * character.h (FETCH_STRING_CHAR_ADVANCE_NO_CHECK, BUF_INC_POS):
7711 Rename locals to avoid shadowing.
7712
cef2010d 7713 * lread.c (read1): Rewrite so as not to use empty "else".
0902fe45 7714 (Fload, readevalloop, read1): Rename locals to avoid shadowing.
cef2010d 7715
d4d7173a
PE
7716 * print.c (Fredirect_debugging_output): Fix pointer signedess.
7717
f08b802a
PE
7718 * lisp.h (debug_output_compilation_hack): Add decl here, to avoid
7719 warning when compiling print.c.
7720
3ddb0639
PE
7721 * font.c (font_unparse_fcname): Abort in an "impossible" situation
7722 instead of using an uninitialized var.
5ad03b97 7723 (font_sort_entities): Mark var as initialized.
3ddb0639 7724
170a2692
PE
7725 * character.h (FETCH_CHAR_ADVANCE): Rename locals to avoid shadowing.
7726
e663c700
PE
7727 * font.c (font_unparse_xlfd): Don't mix pointers to variables with
7728 pointers to constants.
89bc529a 7729 (font_parse_fcname): Remove unused vars.
7b81e2d0 7730 (font_delete_unmatched): Now static.
ea838e10 7731 (font_get_spec): Remove; unused.
13a547c6
PE
7732 (font_style_to_value, font_prop_validate_style, font_unparse_fcname):
7733 (font_update_drivers, Ffont_get_glyphs, font_add_log):
7734 Rename or move locals to avoid shadowing.
e663c700 7735
2a80c887 7736 * fns.c (require_nesting_list, require_unwind): Now static.
612f56df 7737 (Ffillarray): Rename locals to avoid shadowing.
2a80c887 7738
1384fa33 7739 * floatfns.c (domain_error2): Define only if needed.
a885e2ed 7740 (Ffrexp, Fldexp): Rename locals to avoid shadowing.
1384fa33 7741
8b2c52e9
PE
7742 * alloc.c (mark_backtrace): Move decl from here ...
7743 * lisp.h: ... to here, so that it can be checked.
7744
475545b5 7745 * eval.c (call_debugger, do_debug_on_call, grow_specpdl): Now static.
d28a2170 7746 (Fdefvar): Rewrite so as not to use empty "else".
cfcbfb1a
PE
7747 (lisp_indirect_variable): Name an expression,
7748 to avoid gcc -Wbad-function-cast warning.
1faed8ae 7749 (Fdefvar): Rename locals to avoid shadowing.
475545b5 7750
b1349114 7751 * callint.c (quotify_arg, quotify_args): Now static.
a3e8cbda 7752 (Fcall_interactively): Rename locals to avoid shadowing.
b0e80955 7753 Use const pointer when appropriate.
b1349114 7754
a2928364
PE
7755 * lisp.h (get_system_name, get_operating_system_release):
7756 Move decls here, to check interfaces.
7757 * process.c (get_operating_system_release): Move decl to lisp.h.
7758 * xrdb.c (get_system_name): Likewise.
63c5d10b
PE
7759 * editfns.c (init_editfns, Fuser_login_name, Fuser_uid):
7760 (Fuser_real_uid, Fuser_full_name): Remove unnecessary casts,
7761 some of which prompt warnings from gcc -Wbad-function-cast.
545b49b4
PE
7762 (Fformat_time_string, Fencode_time, Finsert_char):
7763 (Ftranslate_region_internal, Fformat):
7764 Rename or remove local vars to avoid shadowing.
9710023e 7765 (Ftranslate_region_internal): Mark var as initialized.
63c5d10b 7766
a415e694
PE
7767 * doc.c (Fdocumentation, Fsnarf_documentation): Move locals to
7768 avoid shadowing.
7769
8ef4622d
PE
7770 * lisp.h (eassert): Check that the argument compiles, even if
7771 ENABLE_CHECKING is not defined.
7772
946f9a5b
PE
7773 * data.c (Findirect_variable): Name an expression, to avoid
7774 gcc -Wbad-function-cast warning.
112396d6 7775 (default_value, arithcompare, arith_driver, arith_error): Now static.
b9b84fa9 7776 (store_symval_forwarding): Rename local to avoid shadowing.
44f230aa
SM
7777 (Fmake_variable_buffer_local, Fmake_local_variable):
7778 Mark variables as initialized.
52746918 7779 (do_blv_forwarding, do_symval_forwarding): Remove; unused.
946f9a5b 7780
e5aab7e7 7781 * alloc.c (check_cons_list): Do not define unless GC_CHECK_CONS_LIST.
ae35e756
PE
7782 (Fmake_vector, Fvector, Fmake_byte_code, Fgarbage_collect):
7783 Rename locals to avoid shadowing.
dff45157
PE
7784 (mark_stack): Move local variables into the #ifdef region where
7785 they're used.
7bc26fdb
PE
7786 (BLOCK_INPUT_ALLOC, UNBLOCK_INPUT_ALLOC): Define only if
7787 ! defined SYSTEM_MALLOC && ! defined SYNC_INPUT, as they are not
7788 needed otherwise.
7789 (CHECK_ALLOCATED): Define only if GC_CHECK_MARKED_OBJECTS.
7790 (GC_STRING_CHARS): Remove; not used.
d40d4be1 7791 (Fmemory_limit): Cast sbrk's returned value to char *.
ae35e756 7792
e5aab7e7
PE
7793 * lisp.h (check_cons_list): Declare if GC_CHECK_CONS_LIST; this
7794 avoids undefined behavior in theory.
7795
4da60324
PE
7796 * regex.c (IF_LINT): Add defn, for benefit of ../lib-src.
7797
88043301
PE
7798 Use functions, not macros, for up- and down-casing (Bug#8254).
7799 * buffer.h (DOWNCASE_TABLE, UPCASE_TABLE, DOWNCASE, UPPERCASEP):
7800 (NOCASEP, LOWERCASEP, UPCASE, UPCASE1): Remove. All callers changed
7801 to use the following functions instead of these macros.
7802 (downcase): Adjust to lack of DOWNCASE_TABLE. Return int, not
7803 EMACS_INT, since callers assume the returned value fits in int.
7804 (upcase1): Likewise, for UPCASE_TABLE.
7805 (uppercasep, lowercasep, upcase): New static inline functions.
0da09c43 7806 * editfns.c (Fchar_equal): Remove no-longer-needed workaround for
db69b0cd 7807 the race-condition problem in the old DOWNCASE.
88043301 7808
19ed5445
PE
7809 * regex.c (CHARSET_LOOKUP_RANGE_TABLE_RAW, POP_FAILURE_REG_OR_COUNT):
7810 Rename locals to avoid shadowing.
7811 (regex_compile, re_match_2_internal): Move locals to avoid shadowing.
abbd1bcf
PE
7812 (regex_compile, re_search_2, re_match_2_internal):
7813 Remove unused local vars.
952db0d7
PE
7814 (FREE_VAR): Rewrite so as not to use empty "else",
7815 which gcc can warn about.
da053e48 7816 (regex_compile, re_match_2_internal): Mark locals as initialized.
b313f9d8
PE
7817 (RETALLOC_IF): Define only if needed.
7818 (WORDCHAR_P): Likewise. This one is never needed, but is used
7819 only in a comment talking about a compiler bug, so put inside
7820 the #if 0 of that comment.
7821 (CHARSET_LOOKUP_BITMAP, FAIL_STACK_FULL, RESET_FAIL_STACK):
7822 (PUSH_FAILURE_ELT, BUF_PUSH_3, STOP_ADDR_VSTRING):
7823 Remove; unused.
19ed5445 7824
1f3561e4 7825 * search.c (boyer_moore): Rename locals to avoid shadowing.
76ef09b7
PE
7826 * character.h (FETCH_STRING_CHAR_AS_MULTIBYTE_ADVANCE):
7827 (PREV_CHAR_BOUNDARY): Likewise.
1f3561e4 7828
ded6f8f7
PE
7829 * search.c (simple_search): Remove unused var.
7830
dbd37a95
PE
7831 * dired.c (compile_pattern): Move decl from here ...
7832 * lisp.h: ... to here, so that it can be checked.
7833 (struct re_registers): New forward decl.
7834
7e47afad
PE
7835 * character.h (INC_POS, DEC_POS): Rename locals to avoid shadowing.
7836
85f24f61
PE
7837 * indent.c (MULTIBYTE_BYTES_WIDTH): New args bytes, width.
7838 All uses changed.
7839 (MULTIBYTE_BYTES_WIDTH, scan_for_column, compute_motion):
7840 Rename locals to avoid shadowing.
5671df8f 7841 (Fvertical_motion): Mark locals as initialized.
85f24f61 7842
181aa2be 7843 * casefiddle.c (casify_object, casify_region): Now static.
e45a141a 7844 (casify_region): Mark local as initialized.
181aa2be 7845
930d429c
PE
7846 * cmds.c (internal_self_insert): Rename local to avoid shadowing.
7847
7082eac6
PE
7848 * lisp.h (GCPRO2_VAR, GCPRO3_VAR, GCPRO4_VAR, GCPRO5_VAR, GCPRO6_VAR):
7849 New macros, so that the caller can use some names other than
7850 gcpro1, gcpro2, etc.
7851 (GCPRO2, GCPRO3, GCPRO4, GCPRO5, GCPRO6): Reimplement in terms
7852 of the new macros.
7853 (GCPRO1_VAR, UNGCPRO_VAR): Change the meaning of the second
7854 argument, for consistency with GCPRO2_VAR, etc: it is now the
7855 prefix of the variable, not the variable itself. All uses
7856 changed.
38b2c076
PE
7857 * dired.c (directory_files_internal, file_name_completion):
7858 Rename locals to avoid shadowing.
7859
15206ed9
PE
7860 Fix a race condition diagnosed by gcc -Wsequence-point (Bug#8254).
7861 An expression of the form (DOWNCASE (x) == DOWNCASE (y)), found in
7862 dired.c's scmp function, had undefined behavior.
7863 * lisp.h (DOWNCASE_TABLE, UPCASE_TABLE, DOWNCASE, UPPERCASEP):
7864 (NOCASEP, LOWERCASEP, UPCASE, UPCASE1): Move from here ...
7865 * buffer.h: ... to here, because these macros use current_buffer,
7866 and the new implementation with inline functions needs to have
7867 current_buffer in scope now, rather than later when the macros
7868 are used.
7869 (downcase, upcase1): New static inline functions.
7870 (DOWNCASE, UPCASE1): Reimplement using these functions.
7871 This avoids undefined behavior in expressions like
7872 DOWNCASE (x) == DOWNCASE (y), which previously suffered
7873 from race conditions in accessing the global variables
7874 case_temp1 and case_temp2.
7875 * casetab.c (case_temp1, case_temp2): Remove; no longer needed.
7876 * lisp.h (case_temp1, case_temp2): Remove their decls.
7877 * character.h (ASCII_CHAR_P): Move from here ...
7878 * lisp.h: ... to here, so that the inline functions mentioned
7879 above can use them.
7880
4a6bea26
PE
7881 * dired.c (directory_files_internal_unwind): Now static.
7882
f14b7e14
PE
7883 * fileio.c (file_name_as_directory, directory_file_name):
7884 (barf_or_query_if_file_exists, auto_save_error, auto_save_1):
7885 Now static.
2893f146
PE
7886 (file_name_as_directory): Use const pointers when appropriate.
7887 (Fexpand_file_name): Likewise. In particular, newdir might
7888 point at constant storage, so make it a const pointer.
fd4ead52 7889 (Fmake_directory_internal, Fread_file_name): Remove unused vars.
b14aac08
PE
7890 (Ffile_selinux_context, Fset_file_selinux_context): Fix pointer
7891 signedness issues.
f839df0c
PE
7892 (Fset_file_times, Finsert_file_contents, auto_save_error):
7893 Rename locals to avoid shadowing.
f14b7e14 7894
5716756e 7895 * minibuf.c (choose_minibuf_frame_1): Now static.
62137a95
PE
7896 (Ftry_completion, Fall_completions): Rename or remove locals
7897 to avoid shadowing.
5716756e 7898
b4c3046a
PE
7899 * marker.c (bytepos_to_charpos): Remove; unused.
7900
b45db522
PE
7901 * lisp.h (verify_bytepos, count_markers): New decls,
7902 so that gcc does not warn that these functions aren't declared.
7903
85876d07
PE
7904 * insdel.c (check_markers, make_gap_larger, make_gap_smaller):
7905 (reset_var_on_error, Fcombine_after_change_execute_1): Now static.
f0cb4a60 7906 (CHECK_MARKERS): Redo to avoid gcc -Wempty-body diagnostic.
40ef059e 7907 (copy_text): Remove unused local var.
85876d07 7908
03d78a21 7909 * filelock.c (within_one_second): Now static.
b3dd38ab 7910 (lock_file_1): Rename local to avoid shadowing.
03d78a21 7911
5df8f01b
PE
7912 * buffer.c (fix_overlays_before): Mark locals as initialized.
7913 (fix_start_end_in_overlays): Likewise. This function should be
7914 simplified by using pointers-to-pointers, but that's a different
7915 matter.
b1d876f1 7916 (switch_to_buffer_1): Now static.
8f54f30a
PE
7917 (Fkill_buffer, record_buffer, Fbury_buffer, Fset_buffer_multibyte):
7918 (report_overlay_modification): Rename locals to avoid shadowing.
c3bd59b5 7919
a70072c9 7920 * sysdep.c (system_process_attributes): Rename vars to avoid shadowing.
fbd02d7b 7921 Fix pointer signedness issue.
edced198
PE
7922 (sys_subshell): Mark local as volatile if checking for lint,
7923 to suppress a gcc -Wclobbered warning that does not seem to be right.
15dfd3d9 7924 (MAXPATHLEN): Define only if needed.
a70072c9 7925
a0977c44
PE
7926 * process.c (serial_open, serial_configure): Move decls from here ...
7927 * systty.h: ... to here, so that they can be checked.
7928
a884fdcc
PE
7929 * fns.c (get_random, seed_random): Move extern decls from here ...
7930 * lisp.h: ... to here, so that they can be checked.
7931
604efe86 7932 * sysdep.c (reset_io): Now static.
b8950c94 7933 (wait_for_termination_signal): Remove; unused.
604efe86 7934
38fc62d9
PE
7935 * keymap.c (keymap_parent, keymap_memberp, map_keymap_internal):
7936 (copy_keymap_item, append_key, push_text_char_description):
7937 Now static.
1004a21a 7938 (Fwhere_is_internal): Don't test CONSP (sequences) unnecessarily.
dbbb8427 7939 (DENSE_TABLE_SIZE): Remove; unused.
c1141155
PE
7940 (get_keymap, access_keymap, Fdefine_key, Fwhere_is_internal):
7941 (describe_map_tree):
7942 Rename locals to avoid shadowing.
38fc62d9 7943
2f2650da
PE
7944 * keyboard.c: Declare functions static if they are not used elsewhere.
7945 (echo_char, echo_dash, cmd_error, top_level_2):
7946 (poll_for_input, handle_async_input): Now static.
69a058fa
PE
7947 (read_char, kbd_buffer_get_event, make_lispy_position):
7948 (make_lispy_event, make_lispy_movement, apply_modifiers):
7949 (decode_keyboard_code, tty_read_avail_input, menu_bar_items):
7950 (parse_tool_bar_item, read_key_sequence, Fread_key_sequence):
7951 (Fread_key_sequence_vector): Rename locals to avoid shadowing.
c8a06054 7952 (read_key_sequence, read_char): Mark locals as initialized.
3ac94672 7953 (Fexit_recursive_edit, Fabort_recursive_edit): Mark with NO_RETURN.
2f2650da 7954
a053e86c 7955 * keyboard.h (make_ctrl_char): New decl.
da2f2dd9
PE
7956 (mark_kboards): Move decl here ...
7957 * alloc.c (mark_kboards): ... from here.
a053e86c 7958
4752793e
PE
7959 * lisp.h (force_auto_save_soon): New decl.
7960
74f10ca7 7961 * emacs.c (init_cmdargs): Rename local to avoid shadowing.
244fc23d
PE
7962 (DEFINE_DUMMY_FUNCTION): New macro.
7963 (__do_global_ctors, __do_global_ctors_aux, __do_global_dtors, __main):
7964 Use it.
c03cd23f
PE
7965 (main): Add casts to avoid warnings
7966 if GCC considers string literals to be constants.
74f10ca7 7967
022e70d4
PE
7968 * lisp.h (fatal_error_signal): Add decl, since it's exported.
7969
59d6fe83
PE
7970 * dbusbind.c: Pointer signedness fixes.
7971 (xd_signature, xd_append_arg, xd_initialize):
7972 (Fdbus_call_method, Fdbus_call_method_asynchronously):
7973 (Fdbus_method_return_internal, Fdbus_method_error_internal):
7974 (Fdbus_send_signal, xd_read_message_1, Fdbus_register_service):
7975 (Fdbus_register_signal): Use SSDATA when the context wants char *.
7976
78320123
PE
7977 * dbusbind.c (Fdbus_init_bus): Add cast to avoid warning
7978 if GCC considers string literals to be constants.
49cebcca 7979 (Fdbus_register_service, Fdbus_register_method): Remove unused vars.
78320123 7980
35ac2a97
SM
79812011-03-16 Stefan Monnier <monnier@iro.umontreal.ca>
7982
fb103ca9
SM
7983 * print.c (PRINT_CIRCLE_CANDIDATE_P): New macro.
7984 (print_preprocess, print_object): New macro to fix last change.
7985
35ac2a97
SM
7986 * print.c (print_preprocess): Don't forget font objects.
7987
62973b41
JB
79882011-03-16 Juanma Barranquero <lekktu@gmail.com>
7989
7990 * emacs.c (USAGE3): Doc fixes.
7991
0e48bb22
AS
79922011-03-15 Andreas Schwab <schwab@linux-m68k.org>
7993
7994 * coding.c (detect_coding_iso_2022): Reorganize code to clarify
7995 structure.
7996
7684e57b
JB
79972011-03-14 Juanma Barranquero <lekktu@gmail.com>
7998
7999 * lisp.h (VWindow_system, Qfile_name_history):
8000 * keyboard.h (lispy_function_keys) [WINDOWSNT]:
8001 * w32term.h (w32_system_caret_hwnd, w32_system_caret_height)
8002 (w32_system_caret_x, w32_system_caret_y): Declare extern.
8003
8004 * w32select.c: Don't #include "keyboard.h".
c96bbc66 8005 (run_protected): Add extern declaration for waiting_for_input.
7684e57b
JB
8006
8007 * w32.c (Qlocal, noninteractive1, inhibit_window_system):
8008 * w32console.c (detect_input_pending, read_input_pending)
8009 (encode_terminal_code):
8010 * w32fns.c (quit_char, lispy_function_keys, Qtooltip)
8011 (w32_system_caret_hwnd, w32_system_caret_height, w32_system_caret_x)
8012 (w32_system_caret_y, Qfile_name_history):
8013 * w32font.c (w32font_driver, QCantialias, QCotf, QClang):
8014 * w32inevt.c (reinvoke_input_signal, lispy_function_keys):
8015 * w32menu.c (Qmenu_bar, QCtoggle, QCradio, Qoverriding_local_map)
8016 (Qoverriding_terminal_local_map, Qmenu_bar_update_hook):
8017 * w32proc.c (Qlocal, report_file_error):
8018 * w32term.c (Vwindow_system, updating_frame):
8019 * w32uniscribe.c (initialized, uniscribe_font_driver):
8020 Remove unneeded extern declarations.
8021
2aa46d6c
CY
80222011-03-14 Chong Yidong <cyd@stupidchicken.com>
8023
c96bbc66 8024 * buffer.c (Fmake_indirect_buffer): Fix incorrect assertions.
2aa46d6c 8025
cffc6f3b
CY
80262011-03-13 Chong Yidong <cyd@stupidchicken.com>
8027
8028 * buffer.h (BUF_BEGV, BUF_BEGV_BYTE, BUF_ZV, BUF_ZV_BYTE, BUF_PT)
8029 (BUF_PT_BYTE): Rewrite to handle indirect buffers (Bug#8219).
8030 These macros can no longer be used for assignment.
8031
44f230aa
SM
8032 * buffer.c (Fget_buffer_create, Fmake_indirect_buffer):
8033 Assign struct members directly, instead of using BUF_BEGV etc.
cffc6f3b
CY
8034 (record_buffer_markers, fetch_buffer_markers): New functions for
8035 recording and fetching special buffer markers.
8036 (set_buffer_internal_1, set_buffer_temp): Use them.
8037
8038 * lread.c (unreadchar): Use SET_BUF_PT_BOTH.
8039
8040 * insdel.c (adjust_point): Use SET_BUF_PT_BOTH.
8041
8042 * intervals.c (temp_set_point_both): Use SET_BUF_PT_BOTH.
8043 (get_local_map): Use SET_BUF_BEGV_BOTH and SET_BUF_ZV_BOTH.
8044
8045 * xdisp.c (hscroll_window_tree):
8046 (reconsider_clip_changes): Use PT instead of BUF_PT.
8047
d251f04b
EZ
80482011-03-13 Eli Zaretskii <eliz@gnu.org>
8049
8050 * makefile.w32-in ($(BLD)/editfns.$(O)): Depend on
8051 $(EMACS_ROOT)/lib/intprops.h.
8052
f0c77cd1
PE
80532011-03-13 Paul Eggert <eggert@cs.ucla.edu>
8054
3eca4629
PE
8055 Fix more problems found by GCC 4.5.2's static checks.
8056
7c86ee98
PE
8057 * gtkutil.c (xg_get_pixbuf_from_pixmap): Add cast from char *
8058 to unsigned char * to avoid compiler diagnostic.
b0afc268
PE
8059 (xg_free_frame_widgets): Make it clear that a local variable is
8060 needed only if USE_GTK_TOOLTIP.
01e0b5ad
PE
8061 (gdk_window_get_screen): Make it clear that this macro is needed
8062 only if USE_GTK_TOOLTIP.
1e5524e7
PE
8063 (int_gtk_range_get_value): New function, which avoids a diagnostic
8064 from gcc -Wbad-function-cast.
8065 (xg_set_toolkit_scroll_bar_thumb): Use it.
8066 (xg_tool_bar_callback, xg_tool_item_stale_p): Rewrite to avoid
8067 diagnostic from gcc -Wbad-function-cast.
65dc836c
PE
8068 (get_utf8_string, xg_get_file_with_chooser):
8069 Rename locals to avoid shadowing.
8070 (create_dialog): Move locals to avoid shadowing.
7c86ee98 8071
41729b81
PE
8072 * xgselect.c (xg_select): Remove unused var.
8073
f0c77cd1
PE
8074 * image.c (four_corners_best): Mark locals as initialized.
8075 (gif_load): Initialize transparent_p to zero (Bug#8238).
8076 Mark another local as initialized.
ec6cf4c6 8077 (my_png_error, my_error_exit): Mark with NO_RETURN.
f0c77cd1 8078
ce0ad53d 8079 * image.c (clear_image_cache): Now static.
d5d5a617 8080 (DIM, HAVE_STDLIB_H_1): Remove unused macros.
e22cffbc 8081 (xpm_load): Redo to avoid "discards qualifiers" gcc warning.
77a765fd
PE
8082 (x_edge_detection): Remove unnecessary cast that
8083 gcc -Wbad-function-cast diagnoses.
2037898d 8084 (gif_load): Fix pointer signedness.
6ae141d6
PE
8085 (clear_image_cache, xbm_read_bitmap_data, x_detect_edges):
8086 (jpeg_load, gif_load): Rename locals to avoid shadowing.
ce0ad53d 8087
33383987 80882011-03-12 Paul Eggert <eggert@cs.ucla.edu>
3eca4629 8089
d32df629
PE
8090 Improve quality of tests for time stamp overflow.
8091 For example, without this patch (encode-time 0 0 0 1 1
8092 1152921504606846976) returns the obviously-bogus value (-948597
8093 62170) on my RHEL 5.5 x86-64 host. With the patch, it correctly
8094 reports time overflow. See
8095 <http://lists.gnu.org/archive/html/emacs-devel/2011-03/msg00470.html>.
b8d9bd41
PE
8096 * deps.mk (editfns.o): Depend on ../lib/intprops.h.
8097 * editfns.c: Include limits.h and intprops.h.
8098 (TIME_T_MIN, TIME_T_MAX): New macros.
8099 (time_overflow): Move earlier, to before first use.
8100 (hi_time, lo_time): New functions, for an accurate test for
8101 out-of-range times.
8102 (Fcurrent_time, Fget_internal_run_time, make_time): Use them.
8103 (Fget_internal_run_time): Don't assume time_t fits in int.
8104 (make_time): Use list2 instead of Fcons twice.
8105 (Fdecode_time): More accurate test for out-of-range times.
8106 (check_tm_member): New function.
8107 (Fencode_time): Use it, to test for out-of-range times.
d32df629
PE
8108 (lisp_time_argument): Don't rely on undefined left-shift and
8109 right-shift behavior when checking for time stamp overflow.
8be6f318 8110
fe31d94c
PE
8111 * editfns.c (time_overflow): New function, refactoring common code.
8112 (Fformat_time_string, Fdecode_time, Fencode_time):
8113 (Fcurrent_time_string): Use it.
8114
8be6f318
PE
8115 Move 'make_time' to be next to its inverse 'lisp_time_argument'.
8116 * dired.c (make_time): Move to ...
8117 * editfns.c (make_time): ... here.
8118 * systime.h: Note the move.
8119
09d9db2c 81202011-03-12 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
c47cbdfd 8121
126bc0dc
YM
8122 * fringe.c (update_window_fringes): Remove unused variables.
8123
c47cbdfd
YM
8124 * unexmacosx.c (copy_data_segment): Also copy __got section.
8125 (Bug#8223)
8126
7ac80be9
EZ
81272011-03-12 Eli Zaretskii <eliz@gnu.org>
8128
c96bbc66 8129 * termcap.c [MSDOS]: Include "msdos.h".
058e5dad
EZ
8130 (find_capability, tgetnum, tgetflag, tgetstr, tputs, tgetent):
8131 Constify `char *' arguments and their references according to
8132 prototypes in tparam.h.
8133
ecb0f94d 8134 * deps.mk (termcap.o): Depend on tparam.h and msdos.h.
058e5dad 8135
7ac80be9
EZ
8136 * msdos.c (XMenuAddPane): 3rd argument is `const char *' now.
8137 Adapt all references accordingly.
8138
8139 * msdos.h (XMenuAddPane): 3rd argument is `const char *' now.
8140
ef1fd07e
TT
81412011-03-11 Tom Tromey <tromey@redhat.com>
8142
8143 * buffer.c (syms_of_buffer): Remove obsolete comment.
8144
7ef4b50c
EZ
81452011-03-11 Eli Zaretskii <eliz@gnu.org>
8146
8147 * termhooks.h (encode_terminal_code): Declare prototype.
8148
8149 * msdos.c (encode_terminal_code): Don't declare prototype.
8150
8151 * term.c (encode_terminal_code): Now external again, used by
8152 w32console.c and msdos.c.
8153
44f230aa
SM
8154 * makefile.w32-in ($(BLD)/term.$(O), ($(BLD)/tparam.$(O)):
8155 Depend on $(SRC)/tparam.h, see 2011-03-11T07:24:21Z!eggert@cs.ucla.edu.
7ef4b50c 8156
4b1ec863 81572011-03-11 Paul Eggert <eggert@cs.ucla.edu>
f78faa98 8158
1714f52b 8159 Fix some minor problems found by GCC 4.5.2's static checks.
83316bf4 8160
4b1ec863
PE
8161 * fringe.c (update_window_fringes): Mark locals as initialized
8162 (Bug#8227).
8163 (destroy_fringe_bitmap, init_fringe_bitmap): Now static.
bf60f616 8164
524c7aa6
PE
8165 * alloc.c (mark_fringe_data): Move decl from here ...
8166 * lisp.h (mark_fringe_data) [HAVE_WINDOW_SYSTEM]: ... to here,
8167 to check its interface.
8168 (init_fringe_once): Do not declare unless HAVE_WINDOW_SYSTEM.
8169
a5c0af81 8170 * fontset.c (free_realized_fontset): Now static.
7519b8cd 8171 (Fset_fontset_font): Rename local to avoid shadowing.
cc6e5db1 8172 (fontset_font): Mark local as initialized.
a9a06e0b 8173 (FONTSET_SPEC, FONTSET_REPERTORY, RFONT_DEF_REPERTORY): Remove; unused.
a5c0af81 8174
b4716021
PE
8175 * xrdb.c: Include "xterm.h", to check x_load_resources's interface.
8176
811e9bac 8177 * xselect.c (x_disown_buffer_selections): Remove; not used.
7b83e2f1 8178 (TRACE3) [!defined TRACE_SELECTION]: Remove; not used.
aa0daa9f
PE
8179 (x_own_selection, Fx_disown_selection_internal): Rename locals
8180 to avoid shadowing.
8181 (x_handle_dnd_message): Remove local to avoid shadowing.
811e9bac 8182
7e3ab302
PE
8183 * lisp.h (GCPRO1_VAR, UNGCPRO_VAR): New macros,
8184 so that the caller can use some name other than gcpro1.
8185 (GCPRO1, UNGCPRO): Reimplement in terms of the new macros.
58d2d479
PE
8186 * xfns.c (Fx_create_frame, x_create_tip_frame, Fx_show_tip):
8187 (Fx_backspace_delete_keys_p):
8188 Use them to avoid shadowing, and rename vars to avoid shadowing.
8189 (x_decode_color, x_set_name, x_window): Now static.
6b437900 8190 (Fx_create_frame): Add braces to silence GCC warning.
c0951e53 8191 (Fx_file_dialog, Fx_select_font): Fix pointer signedness.
06b0c8a0
PE
8192 (x_real_positions, xg_set_icon_from_xpm_data, x_create_tip_frame):
8193 Remove unused locals.
7e3ab302
PE
8194 (Fx_create_frame, x_create_tip_frame, Fx_show_tip):
8195 (Fx_backspace_delete_keys_p): Rename locals to avoid shadowing.
8196 Some of these renamings use the new GCPRO1_VAR and UNGCPRO_VAR
8197 macros.
f78faa98 8198
e2b13473
PE
8199 * xterm.h (x_mouse_leave): New decl.
8200
77f23912
PE
8201 * xterm.c (x_copy_dpy_color, x_focus_on_frame, x_unfocus_frame):
8202 Remove unused functions.
cdf4ba58
PE
8203 (x_shift_glyphs_for_insert, XTflash, XTring_bell):
8204 (x_calc_absolute_position): Now static.
7411c686 8205 (XTread_socket): Don't define label "out" unless it's used.
2b07bcff 8206 Don't declare local "event" unless it's used.
ed7bf3a5
PE
8207 (x_iconify_frame, x_free_frame_resources): Don't declare locals
8208 unless they are used.
38d0b34a
PE
8209 (XEMBED_VERSION, xembed_set_info): Don't define unless needed.
8210 (x_fatal_error_signal): Remove; not used.
a6067996
PE
8211 (x_draw_image_foreground, redo_mouse_highlight, XTmouse_position):
8212 (x_scroll_bar_report_motion, handle_one_xevent, x_draw_bar_cursor):
8213 (x_error_catcher, x_connection_closed, x_error_handler):
8214 (x_error_quitter, xembed_send_message, x_iconify_frame):
8215 (my_log_handler): Rename locals to avoid shadowing.
28f1c698 8216 (x_delete_glyphs, x_ins_del_lines): Mark with NO_RETURN.
2a8fade0 8217 (x_connection_closed): Tell GCC not to suggest NO_RETURN.
77f23912 8218
44f230aa
SM
8219 * xfaces.c (clear_face_cache, Fx_list_fonts, Fface_font):
8220 Rename or move locals to avoid shadowing.
6b463e58 8221 (tty_defined_color, merge_face_heights): Now static.
5967d051 8222 (free_realized_faces_for_fontset): Remove; not used.
1e9966ea
PE
8223 (Fx_list_fonts): Mark variable that gcc -Wuninitialized
8224 does not deduce is never used uninitialized.
73719eba
PE
8225 (STRDUPA, LSTRDUPA, FONT_POINT_SIZE_QUANTUM): Remove; not used.
8226 (LFACEP): Define only if XASSERTS, as it's not needed otherwise.
071048a3 8227
426994c3 8228 * terminal.c (store_terminal_param): Now static.
5489860b 8229
032f1620 8230 * xmenu.c (menu_highlight_callback): Now static.
9d66f88e 8231 (set_frame_menubar): Remove unused local.
d4323972 8232 (xmenu_show): Rename parameter to avoid shadowing.
6d1f7fee
PE
8233 (xmenu_show, xdialog_show, xmenu_show): Make local pointers "const"
8234 since they might point to immutable storage.
281585b0
PE
8235 (next_menubar_widget_id): Declare only if USE_X_TOOLKIT,
8236 since it's unused otherwise.
032f1620 8237
367c19e5 8238 * xdisp.c (produce_glyphless_glyph): Initialize lower_xoff.
53df7c11 8239 Add a FIXME, since the code still doesn't look right. (Bug#8215)
9f36b9fd
PE
8240 (Fcurrent_bidi_paragraph_direction): Simplify slightly; this
8241 avoids a gcc -Wuninitialized diagnostic.
0e086e8f 8242 (display_line, BUILD_COMPOSITE_GLYPH_STRING, draw_glyphs):
44a3a108
PE
8243 (note_mouse_highlight): Mark variables that gcc -Wuninitialized
8244 does not deduce are never used uninitialized.
70739cbe 8245
07b48fa9
PE
8246 * lisp.h (IF_LINT): New macro, copied from ../lib-src/emacsclient.c.
8247
8868a238 8248 * xdisp.c (redisplay_window): Rename local to avoid shadowing.
4554d213
PE
8249 * window.c (window_loop, size_window):
8250 (run_window_configuration_change_hook, enlarge_window): Likewise.
8868a238 8251
7e5cf297 8252 * window.c (display_buffer): Now static.
d6550a9f
PE
8253 (size_window): Mark variables that gcc -Wuninitialized
8254 does not deduce are never used uninitialized.
a586633d
PE
8255 * window.h (check_all_windows): New decl, to forestall
8256 gcc -Wmissing-prototypes diagnostic.
5b555da1 8257 * dispextern.h (bidi_dump_cached_states): Likewise.
7e5cf297 8258
f6095868
PE
8259 * charset.h (CHECK_CHARSET_GET_CHARSET): Rename locals to avoid
8260 shadowing.
8261 * charset.c (map_charset_for_dump, Fchar_charset): Likewise.
726929c4
PE
8262 Include <limits.h>.
8263 (Fsort_charsets): Redo min/max calculation to shorten the code a bit
8264 and to avoid gcc -Wuninitialized warning.
89ef49df
PE
8265 (load_charset_map): Mark variables that gcc -Wuninitialized
8266 does not deduce are never used uninitialized.
53df7c11 8267 (load_charset): Abort instead of using uninitialized var (Bug#8229).
f6095868 8268
f38b440c
PE
8269 * coding.c (coding_set_source, coding_set_destination):
8270 Use "else { /* comment */ }" rather than "else /* comment */;"
8271 for clarity, and to avoid gcc -Wempty-body warning.
2735d060
PE
8272 (Fdefine_coding_system_internal): Don't redeclare 'i' inside
8273 a block, when the outer 'i' will do.
8274 (decode_coding_utf_8, decode_coding_utf_16, detect_coding_emacs_mule):
8275 (emacs_mule_char, decode_coding_emacs_mule, detect_coding_iso_2022):
8276 (decode_coding_iso_2022, decode_coding_sjis, decode_coding_big5):
8277 (decode_coding_raw_text, decode_coding_charset, get_translation_table):
8278 (Fdecode_sjis_char, Fdefine_coding_system_internal):
8279 Rename locals to avoid shadowing.
8280 * character.h (FETCH_STRING_CHAR_ADVANCE): Likewise.
e2f1bab9
PE
8281 * coding.c (emacs_mule_char, encode_invocation_designation):
8282 Now static, since they're not used elsewhere.
413bb2db 8283 (decode_coding_iso_2022): Add "default: abort ();" as a safety check.
c4a63b12 8284 (decode_coding_object, encode_coding_object, detect_coding_system):
ee05f961
PE
8285 (decode_coding_emacs_mule): Mark variables that gcc
8286 -Wuninitialized does not deduce are never used uninitialized.
160b01f6
PE
8287 (detect_coding_iso_2022): Initialize a local variable that might
8288 be used uninitialized. Leave a FIXME because it's not clear that
53df7c11 8289 this initialization is needed. (Bug#8211)
5f58e762
PE
8290 (ISO_CODE_LF, ISO_CODE_CR, CODING_ISO_FLAG_EUC_TW_SHIFT):
8291 (ONE_MORE_BYTE_NO_CHECK, UTF_BOM, UTF_16_INVALID_P):
8292 (SHIFT_OUT_OK, ENCODE_CONTROL_SEQUENCE_INTRODUCER):
8293 (ENCODE_DIRECTION_R2L, ENCODE_DIRECTION_L2R):
8294 Remove unused macros.
f38b440c 8295
232b38b9 8296 * category.c (hash_get_category_set): Remove unused local var.
9f3b5e69 8297 (copy_category_table): Now static, since it's not used elsewhere.
d0891610 8298 * character.c (string_count_byte8): Likewise.
232b38b9 8299
fb90da1b
PE
8300 * ccl.c (CCL_WRITE_STRING, CCL_ENCODE_CHAR, Fccl_execute_on_string):
8301 (Fregister_code_conversion_map): Rename locals to avoid shadowing.
8302
fb93dbc2
PE
8303 * chartab.c (copy_sub_char_table): Now static, since it's not used
8304 elsewhere.
5c156ace
PE
8305 (sub_char_table_ref_and_range, char_table_ref_and_range):
8306 Rename locals to avoid shadowing.
bbcd0949 8307 (ASET_RANGE, GET_SUB_CHAR_TABLE): Remove unused macros.
fb93dbc2 8308
7d3b3862 8309 * bidi.c (bidi_check_type): Now static, since it's not used elsewhere.
630d6892 8310 (BIDI_BOB): Remove unused macro.
7d3b3862 8311
6be7d3da
PE
8312 * cm.c (cmgoto): Mark variables that gcc -Wuninitialized does not
8313 deduce are never used uninitialized.
c2ed9c8b 8314 * term.c (encode_terminal_code): Likewise.
6be7d3da 8315
75f8807f 8316 * term.c (encode_terminal_code): Now static. Remove unused local.
72abad34 8317
50938595
PE
8318 * tparam.h: New file.
8319 * term.c, tparam.h: Include it.
8320 * deps.mk (term.o, tparam.o): Depend on tparam.h.
8321 * term.c (tputs, tgetent, tgetflag, tgetnum, tparam, tgetstr):
8322 Move these decls to tparam.h, and make them agree with what
8323 is actually in tparam.c. The previous trick of using incompatible
8324 decls in different modules does not conform to the C standard.
8325 All callers of tparam changed to use tparam's actual API.
8326 * tparam.c (tparam1, tparam, tgoto):
8327 Use const pointers where appropriate.
8328
fbceeba2
PE
8329 * cm.c (calccost, cmgoto): Use const pointers where appropriate.
8330 * cm.h (struct cm): Likewise.
8331 * dispextern.h (do_line_insertion_deletion_costs): Likewise.
8332 * scroll.c (ins_del_costs, do_line_insertion_deletion_costs): Likewise.
8333 * term.c (tty_ins_del_lines, calculate_costs, struct fkey_table):
8334 (term_get_fkeys_1, append_glyphless_glyph, produce_glyphless_glyph):
8335 (turn_on_face, init_tty): Likewise.
8336 * termchar.h (struct tty_display_info): Likewise.
fbceeba2 8337
7f3f1250
PE
8338 * term.c (term_mouse_position): Rename local to avoid shadowing.
8339
e6ca6543
PE
8340 * alloc.c (mark_ttys): Move decl from here ...
8341 * lisp.h (mark_ttys): ... to here, so that it's checked against defn.
8342
c40f8d15
AS
83432011-03-11 Andreas Schwab <schwab@linux-m68k.org>
8344
8345 * .gdbinit (pwinx, xbuffer): Fix access to buffer name.
8346
cfe0661d
JB
83472011-03-09 Juanma Barranquero <lekktu@gmail.com>
8348
8349 * search.c (compile_pattern_1): Remove argument regp, unused since
8350 revid:rms@gnu.org-19941211082627-3x1g1wyqkjmwloig.
8351 (compile_pattern): Don't pass it.
8352
0afb4571
J
83532011-03-08 Jan Djärv <jan.h.d@swipnet.se>
8354
8355 * xterm.h (DEFAULT_GDK_DISPLAY): New define.
8356 (GDK_WINDOW_XID, gtk_widget_get_preferred_size): New defines
8357 for ! HAVE_GTK3.
8358 (GTK_WIDGET_TO_X_WIN): Use GDK_WINDOW_XID.
8359
8360 * xmenu.c (menu_position_func): Call gtk_widget_get_preferred_size.
8361
8362 * gtkutil.c: Include gtkx.h if HAVE_GTK3. If ! HAVE_GTK3, define
8363 gdk_window_get_screen, gdk_window_get_geometry,
8364 gdk_x11_window_lookup_for_display and GDK_KEY_g.
8365 (xg_set_screen): Use DEFAULT_GDK_DISPLAY.
8366 (xg_get_pixbuf_from_pixmap): New function.
8367 (xg_get_pixbuf_from_pix_and_mask): Change parameters from GdkPixmap
8368 to Pixmap, take frame as parameter, remove GdkColormap parameter.
8369 Call xg_get_pixbuf_from_pixmap instead of
8370 gdk_pixbuf_get_from_drawable.
8371 (xg_get_image_for_pixmap): Do not make GdkPixmaps, call
8372 xg_get_pixbuf_from_pix_and_mask with Pixmap parameters instead.
8373 (xg_check_special_colors): Use GtkStyleContext and its functions
8374 for HAVE_GTK3.
8375 (xg_prepare_tooltip, xg_hide_tooltip): Call gdk_window_get_screen.
8376 (xg_prepare_tooltip, create_dialog, menubar_map_cb)
8377 (xg_update_frame_menubar, xg_tool_bar_detach_callback)
44f230aa
SM
8378 (xg_tool_bar_attach_callback, xg_update_tool_bar_sizes):
8379 Call gtk_widget_get_preferred_size.
0afb4571
J
8380 (xg_frame_resized): gdk_window_get_geometry only takes 5
8381 parameters.
44f230aa
SM
8382 (xg_win_to_widget, xg_event_is_for_menubar):
8383 Call gdk_x11_window_lookup_for_display.
0afb4571
J
8384 (xg_set_widget_bg): New function.
8385 (delete_cb): New function.
895009e1 8386 (xg_create_frame_widgets): Connect delete-event to delete_cb.
0afb4571
J
8387 Call xg_set_widget_bg. Only set backgrund pixmap for ! HAVE_GTK3
8388 (xg_set_background_color): Call xg_set_widget_bg.
8389 (xg_set_frame_icon): Call xg_get_pixbuf_from_pix_and_mask.
8390 (xg_create_scroll_bar): vadj is a GtkAdjustment for HAVE_GTK3.
8391 Only call gtk_range_set_update_policy if ! HAVE_GTK3.
8392 (xg_make_tool_item): Only connect xg_tool_bar_item_expose_callback
8393 if ! HAVE_GTK3.
8394 (update_frame_tool_bar): Call gtk_widget_hide.
8395 (xg_initialize): Use GDK_KEY_g.
8396
8397 * xsmfns.c (gdk_set_sm_client_id): Define to gdk_set_sm_client_id
8398 if ! HAVE_GTK3
8399 (x_session_initialize): Call gdk_x11_set_sm_client_id.
8400
8401 * xterm.c (XFillRectangle): Use cairo routines for HAVE_GTK3.
8402 (x_term_init): Disable Xinput(2) with GDK_CORE_DEVICE_EVENTS.
8403 Load ~/emacs.d/gtkrc only for ! HAVE_GTK3.
8404
1c2cc4ef
JB
84052011-03-08 Juanma Barranquero <lekktu@gmail.com>
8406
8407 * w32xfns.c (select_palette): Check success of RealizePalette against
8408 GDI_ERROR, not zero.
8409
33383987 8410See ChangeLog.11 for earlier changes.
aac0c6e3
MR
8411
8412;; Local Variables:
8413;; coding: utf-8
aac0c6e3
MR
8414;; End:
8415
33383987 8416 Copyright (C) 2011 Free Software Foundation, Inc.
aac0c6e3
MR
8417
8418 This file is part of GNU Emacs.
8419
8420 GNU Emacs is free software: you can redistribute it and/or modify
8421 it under the terms of the GNU General Public License as published by
8422 the Free Software Foundation, either version 3 of the License, or
8423 (at your option) any later version.
8424
8425 GNU Emacs is distributed in the hope that it will be useful,
8426 but WITHOUT ANY WARRANTY; without even the implied warranty of
8427 MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
8428 GNU General Public License for more details.
8429
8430 You should have received a copy of the GNU General Public License
8431 along with GNU Emacs. If not, see <http://www.gnu.org/licenses/>.