Fix Windows build errors introduced after converting to FGET and FSET.
[bpt/emacs.git] / src / ChangeLog
CommitLineData
71688bd7
DA
12012-08-06 Dmitry Antipov <dmantipov@yandex.ru>
2
3 Fix Windows build errors introduced after converting to FGET and FSET.
4 * w32term.c (x_frame_rehighlight, x_scroll_bar_create):
5 (w32_condemn_scroll_bars, w32_redeem_scroll_bar):
6 (w32_judge_scroll_bars): Change to use FSET.
7 Reported by Andy Moreton <andrewjmoreton@gmail.com>.
8
f99bac93
DA
92012-08-06 Dmitry Antipov <dmantipov@yandex.ru>
10
11 Fix replacement typo.
12 * window.c (replace_window): Set root_window instead of
13 selected_window. This fixes a total window subsystem
14 malfunction reported by Bastien Guerry <bzg@gnu.org>.
15
8c2a0f2d
GM
162012-08-06 Glenn Morris <rgm@gnu.org>
17
18 * lisp.mk (lisp): Add language/persian.elc.
19
edd74c35
DA
202012-08-06 Dmitry Antipov <dmantipov@yandex.ru>
21
22 Separate read and write access to Lisp_Object slots of struct frame.
23 * frame.h (FGET, FSET): New macros similar to AREF and ASET.
24 * buffer.c, data.c, dispnew.c, dosfns.c, eval.c, fontset.c, frame.c:
25 * fringe.c, gtkutil.c, minibuf.c, msdos.c, nsfns.m, nsmenu.m, nsterm.m:
26 * print.c, term.c, w32fns.c, w32menu.c, w32term.c, window.c, window.h:
27 * xdisp.c, xfaces.c, xfns.c, xmenu.c, xterm.c: Adjust users.
28
8671676c
AS
292012-08-05 Andreas Schwab <schwab@linux-m68k.org>
30
31 * emacs.c (decode_env_path): Only use defaulted if WINDOWSNT.
32
663e2b3f
DA
332012-08-05 Dmitry Antipov <dmantipov@yandex.ru>
34
35 Generalize common compile-time constants.
36 * lisp.h (header_size, bool_header_size, word_size): Now here.
37 (struct Lisp_Vector): Add comment.
38 (struct Lisp_Bool_Vector): Move up to define handy constants.
39 (VECSIZE, PSEUDOVECSIZE): Simplify.
40 (SAFE_ALLOCA_LISP): Use new constant. Adjust indentation.
41 * buffer.c, buffer.h, bytecode.c, callint.c, eval.c, fns.c:
42 * font.c, fontset.c, keyboard.c, keymap.c, macros.c, menu.c:
43 * msdos.c, w32menu.c, w32term.h, window.c, xdisp.c, xfaces.c:
44 * xfont.c, xmenu.c: Use word_size where appropriate.
45
d32e47af
LM
462012-08-05 Lawrence Mitchell <wence@gmx.li>
47
48 * search.c (Freplace_match): Treat \? in the replacement text
49 literally (Bug#8161).
50
e5d9c0d1
CY
512012-08-05 Chong Yidong <cyd@gnu.org>
52
53 * term.c (Vsuspend_tty_functions, Vresume_tty_functions):
54 * frame.c (Vdelete_frame_functions):
55 * emacs.c (Vkill_emacs_hook): Doc fix.
56
8da0576b
EZ
572012-08-04 Eli Zaretskii <eliz@gnu.org>
58
59 * xfns.c (x_set_menu_bar_lines): Fix compilation error in
60 --with-x-toolkit=no builds.
61 Reported by Carsten Mattner <carstenmattner@gmail.com>.
62
02676e5d
CY
632012-08-04 Chong Yidong <cyd@gnu.org>
64
65 * syntax.c (Fmodify_syntax_entry): Doc fix.
66
97147da9
EZ
672012-08-04 Eli Zaretskii <eliz@gnu.org>
68
76151e2c
EZ
69 Fix startup warnings about ../site-lisp on MS-Windows. (Bug#11959)
70 * w32.c (init_environment): Change the default values of many
71 environment variables in dflt_envvars[] to NULL, to avoid pushing
72 them into environment when they were not already defined. Remove
73 the code that deletes site-lisp subdirectories from the default
74 value of EMACSLOADPATH, as it is no longer needed.
75 (check_windows_init_file): Now external, not static. Use
76 Vload_path as is, without adding anything, as this function is now
77 called when Vload_path is already set up.
78
79 * w32.h (check_windows_init_file): Add prototype.
80
81 * emacs.c (init_cmdargs) [WINDOWSNT]: When running from the build
82 directory, ignore the /*/i386/ tail in Vinvocation_directory, for
83 compatibility with Posix platforms.
84 (main): Move the call to check_windows_init_file to here from
85 w32.c.
86 (decode_env_path) [WINDOWSNT]: Expand the %emacs_dir%/ prefix, if
87 any, in the DEFALT argument into the root of the Emacs build or
88 installation tree, as appropriate.
89
90 * callproc.c (init_callproc_1): Call decode_env_path instead of
91 doing its equivalent by hand.
92 (init_callproc): Replace DOS_NT condition with MSDOS, thus letting
93 the code that sets Vexec_path run on MS-Windows.
94
95 * lread.c (init_lread): Add comments to #ifdef's.
96
97147da9
EZ
97 * msdos.c (dos_set_window_size, IT_update_begin)
98 (IT_frame_up_to_date, IT_set_frame_parameters): Use FVAR and WVAR
99 instead of direct references.
100
185ee146
PE
1012012-08-04 Paul Eggert <eggert@cs.ucla.edu>
102
103 Export DEFAULT_REHASH_* to GDB.
104 * lisp.h (DEFAULT_REHASH_THRESHOLD, DEFAULT_REHASH_SIZE):
105 Now constants, not macros.
106
8834c57a
PE
1072012-08-03 Paul Eggert <eggert@cs.ucla.edu>
108
98c6f1e3
PE
109 Remove unnecessary casts involving pointers.
110 These casts are no longer needed now that we assume C89 or later,
111 since they involve casting to or from void *.
112 * alloc.c (make_pure_string, make_pure_c_string, pure_cons)
113 (make_pure_float, make_pure_vector):
114 * lisp.h (SAFE_ALLOCA, SAFE_ALLOCA_LISP):
115 * macros.c (Fstart_kbd_macro):
116 * menu.c (find_and_return_menu_selection):
117 * minibuf.c (read_minibuf_noninteractive):
118 * sysdep.c (closedir):
119 * xdisp.c (x_produce_glyphs):
120 * xfaces.c (compare_fonts_by_sort_order):
121 * xfns.c (x_real_positions, select_visual):
122 * xselect.c (x_stop_queuing_selection_requests)
123 (x_get_window_property, x_get_window_property_as_lisp_data):
124 * xterm.c (x_set_frame_alpha, x_find_modifier_meanings):
125 Remove unnecessary pointer casts.
126 * alloc.c (record_xmalloc): New function.
127 * lisp.h (record_xmalloc): New decl.
128 (SAFE_ALLOCA): Now takes just one arg -- the size -- and acts
129 more like a function. This is because the pointer cast is not
130 needed. All uses changed.
131 * print.c (print_string, print_error_message): Avoid length recalc.
132
8834c57a
PE
133 Improve fix for macroexp crash with debugging (Bug#12118).
134 * lisp.h (ASET) [ENABLE_CHECKING]: Pay attention to
135 ARRAY_MARK_FLAG when checking subscripts, because ASET is
136 not supposed to be invoked from the garbage collector.
137 See Andreas Schwab in <http://bugs.gnu.org/12118#25>.
138 (gc_aset): New function, which is like ASET but can be
139 used in the garbage collector.
140 (set_hash_key, set_hash_value, set_hash_next, set_hash_hash)
141 (set_hash_index): Use it instead of ASET.
142
6dad7178
EZ
1432012-08-03 Eli Zaretskii <eliz@gnu.org>
144
145 Support symlinks on latest versions of MS-Windows.
146 * w32.c: Include winioctl.h and aclapi.h.
147 (is_symlink, chase_symlinks, enable_privilege, restore_privilege)
148 (revert_to_self): Forward declarations of static functions.
149 <static BOOL g_b_init_get_security_info>:
150 <g_b_init_create_symbolic_link>: New static flags.
151 (globals_of_w32): Initialize them to zero.
152 (GetSecurityInfo_Proc, CreateSymbolicLink_Proc): New typedefs.
153 (map_w32_filename): Improve commentary. Simplify switch.
154 (SYMBOLIC_LINK_FLAG_DIRECTORY): Define if not defined in system
155 headers (most versions of MinGW w32api don't).
156 (get_security_info, create_symbolic_link)
157 (get_file_security_desc_by_handle, is_symlink, chase_symlinks):
158 New functions.
159 (sys_access, sys_chmod): Call 'chase_symlinks' to resolve symlinks
160 in the argument file name.
161 (sys_access): Call unc_volume_file_attributes only if
162 GetFileAttributes fails with network-related error codes.
163 (sys_rename): Diagnose renaming of a symlink when the user doesn't
164 have the required privileges.
165 (get_file_security_desc_by_name): Renamed from
166 get_file_security_desc.
167 (stat_worker): New function, with most of the guts of 'stat', and
168 with addition of handling of symlinks and support for 'lstat'. If
169 possible, get file's attributes and security information by
170 handle, not by name. Produce S_IFLNK bit for symlinks, when
171 called from 'lstat'.
172 (stat, lstat): New functions, call 'stat_worker'.
173 (symlink, readlink, careadlinkat): Rewritten to create and resolve
174 symlinks when the underlying filesystem supports them.
175
f162bcc3
PE
1762012-08-02 Paul Eggert <eggert@cs.ucla.edu>
177
79ea6c20
PE
178 Fix macroexp crash on Windows with debugging (Bug#12118).
179 * lisp.h (ASET) [ENABLE_CHECKING]: Ignore ARRAY_MARK_FLAG when
180 checking subscripts; problem introduced with the recent
181 "ASET (a, i, v)" rather than "AREF (a, i) = v" patch.
182 (ARRAY_MARK_FLAG): Now a macro as well as a constant,
183 since it's used in non-static inline functions now.
184
c0ce93fd
PE
185 * xfaces.c (face_at_buffer_position, face_for_overlay_string):
186 Don't assume buffer size fits in 'int'. Remove unused local.
c71f5156 187
f162bcc3
PE
188 Use C99-style 'extern inline' if available.
189 * buffer.h (BUFFER_INLINE):
190 * category.h (CATEGORY_INLINE):
191 * character.h (CHARACTER_INLINE):
192 * charset.h (CHARSET_INLINE):
193 * composite.h (COMPOSITE_INLINE):
194 * dispextern.h (DISPEXTERN_INLINE):
195 * lisp.h (LISP_INLINE):
196 * systime.h (SYSTIME_INLINE):
197 New macro, replacing 'static inline' in this header.
198 * buffer.h, category.h, character.h, charset.h, composite.h:
199 * dispextern.h, lisp.h, systime.h:
200 Use INLINE_HEADER_BEGIN, INLINE_HEADER_END.
201 * alloc.c (LISP_INLINE):
202 * buffer.c (BUFFER_INLINE):
203 * category.c (CATEGORY_INLINE):
204 * character.c (CHARACTER_INLINE):
205 * charset.c (CHARSET_INLINE):
206 * composite.c (COMPOSITE_INLINE):
207 * dispnew.c (DISPEXTERN_INLINE):
208 * sysdep.c (SYSTIME_INLINE):
209 Define to EXTERN_INLINE, so that the corresponding functions
210 are compiled into code.
211 * conf_post.h (INLINE, EXTERN_INLINE, INLINE_HEADER_BEGIN)
212 (INLINE_HEADER_END): New macros.
213 * lisp.h (PSEUDOVECTOR_FLAG): Now a macro as well as a constant,
214 since it's used in non-static inline functions now.
a8333d03 215 (VALMASK) [!USE_LSB_TAG]: Likewise.
f162bcc3 216
837b365b
GM
2172012-08-02 Glenn Morris <rgm@gnu.org>
218
d66b744d
GM
219 * s/: Remove empty directory.
220
837b365b
GM
221 * s/ms-w32.h: Move to ../nt/inc.
222 * makefile.w32-in (TAGS, TAGS-gmake, MS_W32_H):
223 Update for new ms-w32.h location.
224
13294f95
PE
2252012-08-02 Paul Eggert <eggert@cs.ucla.edu>
226
227 Port to Solaris 8.
228 * syswait.h (WRETCODE): Remove, consistently with ../configure.ac.
229
90df0db3
GM
2302012-08-02 Glenn Morris <rgm@gnu.org>
231
232 * nsterm.m (ns_exec_path, ns_load_path): Use SEPCHAR rather than
233 hard-coding the path separator.
234
4939150c
PE
2352012-08-01 Paul Eggert <eggert@cs.ucla.edu>
236
237 Use "ASET (a, i, v)" rather than "AREF (a, i) = v".
238 This how ASET and AREF are supposed to work, and makes
239 it easier to think about future improvements. See
240 <http://lists.gnu.org/archive/html/emacs-devel/2012-08/msg00026.html>.
241 * charset.h (set_charset_attr): New function.
242 All lvalue-style uses of CHARSET_DECODER etc. changed to use it.
243 * lisp.h (ASET): Rewrite so as not to use AREF in an lvalue style.
244 (aref_addr): New function. All uses of &AREF(...) changed.
245 (set_hash_key, set_hash_value, set_hash_next, set_hash_hash)
246 (set_hash_index): New functions. All lvalue-style uses of
247 HASH_KEY etc. changed.
248 * keyboard.c (set_prop): New function. All lvalue-style uses
249 of PROP changed.
250
947b2afd
AA
2512012-08-01 Alp Aker <alp.tekin.aker@gmail.com>
252
253 * nsterm.m (ns_set_vertical_scroll_bar, ns_redeem_scroll_bar)
254 (EmacsWindow-accessibilityAttributeValue, EmacsScroller-initFrame:)
255 (EmacsScroller-dealloc): Adjust to use WVAR. (Bug#12114)
256 * nsfns.m (ns_set_name_as_filename): Likewise.
257 * nsmenu.m (ns_update_menubar): Likewise.
258 * nsselect.m (symbol_to_nsstring): Adjust to use SVAR.
259
4f5d0325
EZ
2602012-08-01 Eli Zaretskii <eliz@gnu.org>
261
2008beae
EZ
262 * .gdbinit (xcar, xcdr, xlist, xwindow, nextcons, xprintsym):
263 Adapt to latest changes in field names of the corresponding Lisp
288479f6 264 objects.
2008beae 265
4f5d0325
EZ
266 * xdisp.c (try_window_id): Use WVAR in IF_DEBUG code.
267
fe3cc771
GM
2682012-08-01 Glenn Morris <rgm@gnu.org>
269
270 * s/msdos.h: Remove file.
271 * conf_post.h [MSDOS]: New section, moved from s/msdos.h.
272 * Makefile.in (S_FILE): Remove.
273 (config_h): Remove S_FILE.
274
c90acc54
JB
2752012-08-01 Juanma Barranquero <lekktu@gmail.com>
276
277 * s/ms-w32.h (DEVICE_SEP, IS_DIRECTORY_SEP, IS_ANY_SEP):
278 Remove; moved to nt/config.nt.
279
d8a05828
DA
2802012-08-01 Dmitry Antipov <dmantipov@yandex.ru>
281
282 Use INTERNAL_FIELD for conses and overlays.
283 * lisp.h (struct Lisp_Cons): Use INTERNAL_FIELD.
284 Remove obsolete comment.
285 (MVAR): New macro.
286 (struct Lisp_Overlay): Use INTERNAL_FIELD.
287 * alloc.c, buffer.c, buffer.h, fns.c: Adjust users.
288
8271d590
DA
2892012-08-01 Dmitry Antipov <dmantipov@yandex.ru>
290
291 Use INTERNAL_FIELD for symbols.
292 * lisp.h (SVAR): New macro. Adjust users.
293 * alloc.c, bytecode.c, cmds.c, data.c, doc.c, eval.c:
294 * fns.c, keyboard.c, lread.c, xterm.c: Users changed.
295
3193acd2
DA
2962012-08-01 Dmitry Antipov <dmantipov@yandex.ru>
297
298 Use INTERNAL_FIELD for processes.
299 * process.h (PVAR): New macro. Adjust style.
300 (struct Lisp_Process): Change Lisp_Object members to INTERNAL_FIELD.
301 * print.c, process.c, sysdep.c, w32.c, xdisp.c: Users changed.
302
3a45383a
DA
3032012-08-01 Dmitry Antipov <dmantipov@yandex.ru>
304
305 Use INTERNAL_FIELD for windows.
306 * window.h (WVAR): New macro.
307 (struct window): Change Lisp_Object members to INTERNAL_FIELD.
308 * alloc.c, buffer.c, composite.c, dispextern.h, dispnew.c, editfns.c:
309 * fileio.c, font.c, fontset.c, frame.c, frame.h, fringe.c, indent.c:
310 * insdel.c, keyboard.c, keymap.c, lisp.h, minibuf.c, nsterm.m, print.c:
311 * textprop.c, w32fns.c, w32menu.c, w32term.c, window.c, xdisp.c:
312 * xfaces.c, xfns.c, xmenu.c, xterm.c: Users changed.
313
c1dbc63c
PE
3142012-08-01 Paul Eggert <eggert@cs.ucla.edu>
315
316 * coding.h (CODING_ATTR_FLUSHING): Remove; unused and wouldn't work.
317
5c0c0e8a
GM
3182012-08-01 Glenn Morris <rgm@gnu.org>
319
320 * lisp.h (IS_DIRECTORY_SEP, IS_DEVICE_SEP, IS_ANY_SEP):
321 Move to configure.ac.
322
552a99b4
JB
3232012-08-01 Juanma Barranquero <lekktu@gmail.com>
324
325 * makefile.w32-in (CONFIG_H): Update dependencies.
326 (CONF_POST_H): New macro.
327
328 * s/ms-w32.h (SEPCHAR, NULL_DEVICE): Remove; moved to nt/config.nt.
329
8d8e2dfe
GM
3302012-07-31 Glenn Morris <rgm@gnu.org>
331
bc96620a
GM
332 * Makefile.in (S_FILE): No longer set by configure.
333
476b1b2d
GM
334 * conf_post.h (config_opsysfile): Move earlier, so that WINDOWSNT
335 is available.
336 (alloca.h) [WINDOWSNT]: Don't include it on MS Windows.
337
b2c7a106
GM
338 * process.h (NULL_DEVICE):
339 * emacs.c (SEPCHAR):
340 * editfns.c (USER_FULL_NAME): Let configure set them.
341
d53d062a
GM
342 * s/README, s/template.h: Remove files.
343
4515017f
GM
344 * conf_post.h [HPUX]: Undefine HAVE_RANDOM and HAVE_RINT.
345
8d8e2dfe
GM
346 * conf_post.h (AMPERSAND_FULL_NAME, subprocesses):
347 Move to configure.ac.
348
5b20b3cc
EZ
3492012-07-31 Eli Zaretskii <eliz@gnu.org>
350
1e0afd9a
EZ
351 * .gdbinit (xframe): Adapt to introduction of FVAR and the
352 resulting renaming of 'struct frame' members.
353
5b20b3cc
EZ
354 * w32menu.c (w32_menu_show): Revert bogus introduction of FVAR.
355
356 * fontset.c (dump_fontset): Fix compilation with ENABLE_CHECKING
357 after introduction of FVAR.
358
f1310128
JD
3592012-07-31 Jan Djärv <jan.h.d@swipnet.se>
360
79e721e0
JD
361 * nsmenu.m (update_frame_tool_bar): Change key from NSObject* to id.
362
363 * nsterm.m (ns_draw_fringe_bitmap, ns_dumpglyphs_image): Use drawInRect
364 instead of compositeToPoint.
365 (applicationShouldTerminate): Pass NS String literal to NSRunAlertPanel.
366
8d7c7eed 367 * nsfns.m, nsmenu.m, nsterm.m: Adopt to struct frame/FVAR changes.
f1310128 368
e34f7f79
DA
3692012-07-31 Dmitry Antipov <dmantipov@yandex.ru>
370
371 Generalize INTERNAL_FIELD between buffers, keyboards and frames.
372 * lisp.h (INTERNAL_FIELD): New macro.
373 * buffer.h (BUFFER_INTERNAL_FIELD): Removed.
374 (BVAR): Change to use INTERNAL_FIELD.
375 * keyboard.h (KBOARD_INTERNAL_FIELD): Likewise.
376 (KVAR): Change to use INTERNAL_FIELD.
377 * frame.h (FVAR): New macro.
378 (struct frame): Use INTERNAL_FIELD for all Lisp_Object fields.
3a45383a
DA
379 * alloc.c, buffer.c, data.c, dispnew.c, dosfns.c, eval.c, frame.c:
380 * fringe.c, gtkutil.c, minibuf.c, nsfns.m, nsterm.m, print.c:
381 * term.c, w32fns.c, w32menu.c, w32term.c, window.c, window.h:
e34f7f79
DA
382 * xdisp.c, xfaces.c, xfns.c, xmenu.c, xterm.c: Users changed.
383
c09bfb2f
DA
3842012-07-31 Dmitry Antipov <dmantipov@yandex.ru>
385
386 Miscellaneous fixes for non-default X toolkits.
387 * xfns.c (Fx_file_dialog): Change to SSDATA to avoid warnings.
388 * xterm.c (x_frame_of_widget): Remove redundant prototype.
389 Move under #ifdef USE_LUCID.
390 (x_create_toolkit_scroll_bar): Adjust scroll_bar_name
391 definition and usage to avoid warnings.
392
14c114ae
JD
3932012-07-31 Jan Djärv <jan.h.d@swipnet.se>
394
395 * nsterm.m (openFiles): Fix previous checkin.
396
3bd21e82
PE
3972012-07-31 Paul Eggert <eggert@cs.ucla.edu>
398
399 * indent.c (compute_motion): Remove unused local.
400
c1529ded
GM
4012012-07-31 Glenn Morris <rgm@gnu.org>
402
400d5621
GM
403 * s/usg5-4-common.h (wait3, WRETCODE): Let configure set them.
404
268e2432
GM
405 * conf_post.h [USG5_4]:
406 Move remaining contents of s/usg5-4-common.h here.
407 * s/usg5-4-common.h: Remove file.
408
7552f3ee
GM
409 * conf_post.h [IRIX6_5]: Move remaining contents of s/irix6-5.h here.
410 * s/irix6-5.h: Remove file.
411
6a381852
GM
412 * conf_post.h [DARWIN_OS]: Move remaining contents of s/darwin.h here.
413 * s/darwin.h: Remove file.
414
c1529ded
GM
415 * conf_post.h [HPUX]: Move random, srandom here from s/hpux10-20.h.
416 * s/hpux10-20.h: Remove file, which is now empty.
417
b429a4ee
GM
4182012-07-30 Glenn Morris <rgm@gnu.org>
419
420 * conf_post.h: New, split from configure.ac's AH_BOTTOM.
421 * Makefile.in (config_h): Add conf_post.h.
422 * makefile.w32-in (CONFIG_H): Add conf_post.h.
423
adff3182
JD
4242012-07-30 Jan Djärv <jan.h.d@swipnet.se>
425
426 * nsterm.m (ns_do_open_file): New variable.
b9031d69 427 (ns_term_init): Set ns_do_open_file to YES after run returns.
adff3182
JD
428 (openFile, openTempFile, openFileWithoutUI, openFiles): Open
429 files only if ns_do_open_file.
430
c32af1e4
PE
4312012-07-30 Paul Eggert <eggert@cs.ucla.edu>
432
7393bcbb
PE
433 * lisp.h (SWITCH_ENUM_CAST): Remove. All uses removed.
434 This no-op macro hasn't been needed for many years.
435 * src/regex.c (SWITCH_ENUM_CAST) [!emacs]: Likewise.
436
c32af1e4
PE
437 Export DIRECTORY_SEP, TYPEMASK, VALMASK to GDB.
438 * alloc.c (gdb_make_enums_visible) [USE_LSB_TAG]: Add lsb_bits.
439 * lisp.h (enum lsb_bits) [USE_LSB_TAG]: New enum, for
440 gdb_make_enums_visible.
441 (TYPEMASK, VALMASK) [USE_LSB_TAGS]: Now enum constants, not macros.
442 (DIRECTORY_SEP): Now a constant, not a macro.
443
302fc036
EZ
4442012-07-30 Eli Zaretskii <eliz@gnu.org>
445
446 * w32fns.c (w32_wnd_proc): Pass w32_keyboard_codepage to
447 w32_kbd_patch_key as the 2nd arg. (Bug#12082)
448
449 * w32term.c <w32_keyboard_codepage>: Renamed from
450 keyboard_codepage and now external. All users changed.
451
452 * w32term.h: Add declaration of w32_keyboard_codepage.
453
454 * w32inevt.c (w32_kbd_patch_key): Accept an additional argument --
455 the codepage to translate keys to Unicode. If this argument is
456 -1, use the value returned by GetConsoleCP. All callers changed.
457
88fb40b4
PE
4582012-07-30 Paul Eggert <eggert@cs.ucla.edu>
459
0aee6912
PE
460 Update .PHONY listings in makefiles.
461 * Makefile.in (.PHONY): Add all, mostlyclean, clean,
462 bootstrap-clean, distclean, maintainer-clean, versioclean,
463 extraclean, frc.
464
88fb40b4
PE
465 * lisp.h (STRING_BYTES_BOUND): Cast entire result to ptrdiff_t.
466 This is a bit clearer. Fix some commentary typos.
467
0a763bd1
GM
4682012-07-30 Glenn Morris <rgm@gnu.org>
469
32bac6d6
GM
470 * s/netbsd.h: Let configure include signal.h if needed.
471 Remove file, which is now empty.
472
b65e7c46
GM
473 * s/usg5-4-common.h (_longjmp, _setjmp, TIOCSIGSEND):
474 Let configure set them.
475 * s/irix6-5.h (_longjmp, _setjmp, TIOCSIGSEND):
476 No more need to undefine.
0a763bd1 477
169304bd
AS
4782012-07-30 Andreas Schwab <schwab@linux-m68k.org>
479
480 * keymap.c (Fkey_description): Don't remove 0x80 bit from
481 non-single-byte char when adding meta modifier. (Bug#12090)
482
6cd7a139
DA
4832012-07-30 Dmitry Antipov <dmantipov@yandex.ru>
484
485 Convert safe_call to use variable number of arguments.
486 * xdisp.c (safe_call): Convert to use varargs. Adjust users.
487 (safe_call2): Fix comment.
488 * lisp.h (safe_call): Adjust prototype.
489 * coding.c (encode_coding_object): Change to use safe_call2.
490 * xfaces.c (merge_face_heights): Change to use safe_call1.
491
d34d6ffc
GM
4922012-07-30 Glenn Morris <rgm@gnu.org>
493
7b8a48e4 494 * s/aix4-2.h (sigmask): No need to undefine it, since syssignal.h
227f5bd0 495 does that unconditionally. Remove file, which is now empty.
7b8a48e4 496
d34d6ffc
GM
497 * s/freebsd.h, s/gnu-linux.h, s/sol2-6.h, s/unixware.h:
498 Remove empty files.
499
03a660a6
PE
5002012-07-30 Paul Eggert <eggert@cs.ucla.edu>
501
502 Export to GDB most of lisp.h's remaining object-like macros.
503 * lisp.h (min, max): Move earlier, because they're used earlier now.
504 (INTMASK, ARRAY_MARK_FLAG, PSEUDOVECTOR_FLAG, VALMASK)
505 (CHAR_TABLE_STANDARD_SLOTS, CHARTAB_SIZE_BITS_0)
506 (CHARTAB_SIZE_BITS_1, CHARTAB_SIZE_BITS_2, CHARTAB_SIZE_BITS_3)
507 (DEFAULT_HASH_SIZE, COMPILED_ARGLIST, COMPILED_BYTECODE)
508 (COMPILED_CONSTANTS, COMPILED_STACK_DEPTH, COMPILED_DOC_STRING)
509 (COMPILED_INTERACTIVE, CHAR_ALT, CHAR_SUPER, CHAR_HYPER, CHAR_SHIFT)
510 (CHAR_CTL, CHAR_META, CHAR_MODIFIER_MASK, CHARACTERBITS)
511 (MANY, UNEVALLED, FLOAT_TO_STRING_BUFSIZE, MAX_ALLOCA):
512 Now constants, for GDB. They need not be macros.
513 (MOST_POSITIVE_FIXNUM, MOST_NEGATIVE_FIXNUM, STRING_BYTES_BOUND):
514 Now constants, for GDB, as well as macros, for static initializers.
515 (CHAR_TABLE_STANDARD_SLOTS, CHAR_TABLE_EXTRA_SLOTS):
516 Move to after the definition of struct Lisp_Char_Table,
517 since the former now needs that type defined.
518 (enum CHARTAB_SIZE_BITS, enum CHAR_TABLE_STANDARD_SLOTS)
519 (enum DEFAULT_HASH_SIZE, enum Lisp_Compiled, enum char_bits)
520 (enum maxargs, enum FLOAT_TO_STRING_BUFSIZE, enum MAX_ALLOCA):
521 New enums, for gdb_make_enums_visible.
522 (GLYPH_MODE_LINE_FACE): Remove; unused.
88fb40b4 523 * alloc.c (STRING_BYTES_MAX): Now a constant, not a macro.
03a660a6
PE
524 (gdb_make_enums_visible): Add enum CHARTAB_SIZE_BITS, enum
525 CHAR_TABLE_STANDARD_SLOTS, enum char_bits, enum DEFAULT_HASH_SIZE,
526 enum FLOAT_TO_STRING_BUFSIZE, enum Lisp_Bits, enum Lisp_Compiled,
527 enum maxargs, enum MAX_ALLOCA.
528 (ARRAY_MARK_FLAG_VAL, PSEUDOVECTOR_FLAG_VAL, VALMASK_VAL): Remove.
529 (ARRAY_MARK_FLAG, PSEUDOVECTOR_FLAG, VALMASK): Remove;
530 no longer needed, now that they are done in lisp.h.
531
e499d0ee
DA
5322012-07-30 Dmitry Antipov <dmantipov@yandex.ru>
533
534 Cleanup string bytes checking.
535 * alloc.c (GC_STRING_BYTES, CHECK_STRING_BYTES): Remove. Convert
536 all users to STRING_BYTES or string_bytes if GC_CHECK_STRING_BYTES.
537 (check_string_bytes): Define to empty if not GC_CHECK_STRING_BYTES.
538 (check_sblock, compact_small_strings): Simplify.
539
d5040d2d
PE
5402012-07-29 Paul Eggert <eggert@cs.ucla.edu>
541
542 * lisp.h (LISP_INT_TAG, LISP_INT1_TAG, LISP_STRING_TAG): Remove.
543 These macros are confusing and no longer need to be defined, as
544 the enum values now suffice. All uses replaced with definiens.
545 (Lisp_Int1, Lisp_String): Define directly; this is clearer.
546
7f259ae6
JB
5472012-07-29 Juanma Barranquero <lekktu@gmail.com>
548
549 * makefile.w32-in (LISP_H, $(BLD)/emacs.$(O), $(BLD)/w32inevt.$(O))
550 ($(BLD)/w32console.$(O)): Update dependencies.
551
7e63e0c3
DA
5522012-07-29 Dmitry Antipov <dmantipov@yandex.ru>
553
554 Remove HIDE_LISP_IMPLEMENTATION and cleanup cons free list check.
555 * lisp.h (HIDE_LISP_IMPLEMENTATION): Remove as useless for a long
556 time. Adjust users.
557 (CHECK_CONS_LIST): Remove. Convert all users to check_cons_list.
558
ffd817eb
JD
5592012-07-29 Jan Djärv <jan.h.d@swipnet.se>
560
561 * lread.c (init_lread): Remove if-statement in ifdef HAVE_NS before
562 setting sitelisp (Bug#12010).
563
417a7a0e
EZ
5642012-07-29 Eli Zaretskii <eliz@gnu.org>
565
566 * w32heap.h (OS_9X): Renamed from OS_WINDOWS_95.
567
568 * w32heap.c (cache_system_info):
569 * w32.c (sys_rename):
570 * w32proc.c (find_child_console, sys_kill): All users changed.
571
387d4d92
PE
5722012-07-29 Paul Eggert <eggert@cs.ucla.edu>
573
574 * alloc.c (Fgarbage_collect): Indent as per usual Emacs style.
575
55a6cca6
EZ
5762012-07-29 Eli Zaretskii <eliz@gnu.org>
577
578 * makefile.w32-in (LISP_H): Add $(NT_INC)/stdalign.h.
579
dbcf001c
DA
5802012-07-29 Dmitry Antipov <dmantipov@yandex.ru>
581
582 Cleanup statistics calculation in Fgarbage_collect.
583 * alloc.c (Fgarbage_collect): Rename t1 to meaningful start. Fix
584 zombies percentage calculation. Simplify elapsed time calculation.
585
e2688e4a
DA
5862012-07-29 Dmitry Antipov <dmantipov@yandex.ru>
587
588 Generalize marker debugging code under MARKER_DEBUG and use eassert.
589 * insdel.c (CHECK_MARKERS, check_markers_debug_flag): Remove.
590 (gap_left, gap_right, adjust_markers_for_delete, insert_1_both)
591 (insert_from_string_1, insert_from_gap, insert_from_buffer_1)
592 (replace_range, replace_range_2, del_range_2): Change to eassert.
593 * marker.c (byte_char_debug_check): Adjust style.
594
b46a6a83
PE
5952012-07-29 Paul Eggert <eggert@cs.ucla.edu>
596
597 Don't use the abbreviation "win" to refer to Windows (Bug#10421).
598 * regex.c (MAX_BUF_SIZE): Remove some incorrect and
599 long-ago-commented-out code that talks about "WIN32".
600 * w32heap.h (OS_WINDOWS_95): Rename from OS_WIN95.
601 All uses changed.
602
e32a5799
PE
6032012-07-28 Paul Eggert <eggert@cs.ucla.edu>
604
605 Use Gnulib stdalign module (Bug#9772, Bug#9960).
606 * alloc.c (XMALLOC_BASE_ALIGNMENT, GC_POINTER_ALIGNMENT, pure_alloc):
607 Simplify by using alignof.
608 (pure_alloc) [! USE_LSB_TAG]: Don't over-align EMACS_INT values.
609 * lisp.h: Include <stdalign.h>.
610 (GCALIGNMENT): New macro and constant.
611 (DECL_ALIGN): Remove. All uses replaced by alignas (GCALIGNMENT).
612 (USE_LSB_TAG): ifdef on alignas, not on DECL_ALIGN.
613 (stdalign): New macro, if not already defined.
614
df81cd29
EZ
6152012-07-28 Eli Zaretskii <eliz@gnu.org>
616
01bd1b0d
EZ
617 Fix non-ASCII input in non-GUI frames on MS-Windows. (Bug#12055)
618 * w32inevt.c: Include w32inevt.h.
619 (w32_read_console_input): New inline function, calls either
620 ReadConsoleInputA or ReadConsoleInputW, depending on the value of
621 w32_console_unicode_input.
622 (fill_queue): Call w32_read_console_input instead of ReadConsoleInput.
623 (w32_kbd_patch_key, key_event): Use the codepage returned by
624 GetConsoleCP, rather than the ANSI codepage returned by GetLocaleInfo.
625 (key_event): use uChar.UnicodeChar only if
626 w32_console_unicode_input is non-zero.
627
628 * w32console.c: Include w32heap.h.
629 <w32_console_unicode_input>: New global variable.
630 (initialize_w32_display): Set w32_console_unicode_input to 1 on NT
631 family of Windows, zero otherwise.
632
633 * w32inevt.h: Declare w32_console_unicode_input.
634
df81cd29
EZ
635 * xdisp.c (init_iterator): Don't reference tip_frame in a build
636 --without-x. (Bug#11742)
637
c20fdd9e
PE
6382012-07-27 Paul Eggert <eggert@cs.ucla.edu>
639
640 Adjust GDB to reflect pvec_type changes (Bug#12036).
641 * .gdbinit (xvectype, xpr, xbacktrace): Adjust to reflect the
642 2012-07-04 changes to pseudovector representation. Problem
643 reported by Eli Zaretskii in <http://bugs.gnu.org/12036#30>.
644
32770973 6452012-07-27 Michael Albinus <michael.albinus@gmx.de>
e518bc71
MA
646
647 * dbusbind.c (XD_DBUS_VALIDATE_BUS_ADDRESS): Canonicalize session
648 bus address.
649 (xd_close_bus, Fdbus_init_bus): Handle reference counter properly.
650
3438fe21
EZ
6512012-07-27 Eli Zaretskii <eliz@gnu.org>
652
bcfbc9de
EZ
653 * alloc.c (listn): Fix the order the arguments are consed onto the
654 list.
655
3438fe21
EZ
656 * lisp.h (enum constype): Use CONSTYPE_HEAP and CONSTYPE_PURE for
657 enumeration constants, as PURE and HEAP are too general, and clash
658 with other headers and sources, such as gmalloc.c and the
659 MS-Windows system headers. All users changed.
660
eeaea515
DA
6612012-07-27 Dmitry Antipov <dmantipov@yandex.ru>
662
663 Revert last save_excursion_save and save_excursion_restore changes.
664 * alloc.c, editfns.c, marker.c, lisp.h: Revert.
665 Lots of crashes reported by Chong Yidong <cyd@gnu.org>.
666
073c88c2
DA
6672012-07-27 Dmitry Antipov <dmantipov@yandex.ru>
668
669 Fix recently-introduced typos in Windows port.
670 Reported by Martin Rudalics <rudalics@gmx.at>.
671 * w32.c (init_environment): Replace comma with semicolon.
eeaea515 672 * w32fns.c (syms_of_w32fns): Add missing parenthesis.
073c88c2 673
4706125e
PE
6742012-07-27 Paul Eggert <eggert@cs.ucla.edu>
675
676 Improve GDB symbol export (Bug#12036).
677 * .gdbinit (xgetptr, xgetint, xgettype): Set $bugfix in different
678 arms of an 'if', not using conditional expressions; otherwise GDB
679 complains about the types in the unevaluated arm when the argument
680 is an integer literal.
681 (xgetint): Simplify expression.
682 * alloc.c (gdb_make_enums_visible): New constant. This ports to
683 GCC 3.4.2 the export of symbols to GDB. Problem reported by Eli
684 Zaretskii in <http://bugs.gnu.org/12036#13>.
685 * lisp.h (PUBLISH_TO_GDB): Remove. All uses removed. No longer
686 needed now that we have gdb_make_enums_visible.
687 (enum CHECK_LISP_OBJECT_TYPE, enum Lisp_Bits, enum More_Lisp_Bits)
688 (enum enum_USE_LSB_TAG):
689 New enum types, packaging up enums that need to be exported to GDB.
690
694b6c97
DA
6912012-07-27 Dmitry Antipov <dmantipov@yandex.ru>
692
693 Utility function to make a list from specified amount of objects.
694 * lisp.h (enum constype): New datatype.
695 (listn): New prototype.
696 * alloc.c (listn): New function.
697 (Fmemory_use_count, syms_of_alloc): Use it.
698 * buffer.c (syms_of_buffer): Likewise.
699 * callint.c (syms_of_callint): Likewise.
700 * charset.c (define_charset_internal): Likewise.
701 * coding.c (syms_of_coding): Likewise.
702 * keymap.c (syms_of_keymap): Likewise.
703 * search.c (syms_of_search): Likewise.
704 * syntax.c (syms_of_syntax): Likewise.
705 * w32.c (init_environment): Likewise.
706 * w32fns.c (Fw32_battery_status, syms_of_w32fns): Likewise.
707 * xdisp.c (syms_of_xdisp): Likewise.
708 * xfns.c (syms_of_xfns): Likewise.
709
6195f384
DA
7102012-07-27 Dmitry Antipov <dmantipov@yandex.ru>
711
712 Fast save_excursion_save and save_excursion_restore.
713 * lisp.h (struct Lisp_Excursion): New data type.
714 (PVEC_EXCURSION): New pseudovector type.
715 (XEXCURSION, XSETEXCURSION, EXCURSIONP): Convenient macros
716 to deal with it. Adjust comments.
717 (init_marker, attach_marker): New prototype.
718 (unchain_marker): Adjust prototype.
719 * marker.c (attach_marker): Change to global.
720 (init_marker): New function.
721 * alloc.c (Fmake_marker, build_marker): Use it.
722 (build_marker): More easserts.
723 (mark_object): Handle struct Lisp_Excursion.
724 * editfns.c (save_excursion_save, save_excursion_restore):
725 Reimplement to use struct Lisp_Excursion. Add comments.
726
5eceb8fb
PE
7272012-07-26 Paul Eggert <eggert@cs.ucla.edu>
728
729 Fix export of symbols to GDB (Bug#12036).
730 * alloc.c (ARRAY_MARK_FLAG_VAL, PSEUDOVECTOR_FLAG_VAL, VALMASK_VAL)
731 (ARRAY_MARK_FLAG, PSEUDOVECTOR_FLAG, VALMASK): Move these here from
732 emacs.c, as this is a more-suitable home. Had this been done earlier
733 the fix for 12036 would have avoided some of the problems noted in
734 <http://bugs.gnu.org/12036#13> by Eli Zaretskii, as the scope problems
735 would have been more obvious.
562157c8
PE
736 * emacs.c: Do not include <verify.h>; no longer needed.
737 (gdb_CHECK_LISP_OBJECT_TYPE, gdb_DATA_SEG_BITS)
5eceb8fb
PE
738 (gdb_GCTYPEBITS, gdb_USE_LSB_TAG)
739 (CHECK_LISP_OBJECT_TYPE, DATA_SEG_BITS, GCTYPEBITS, USE_LSB_TAG):
740 Remove; now done in lisp.h.
741 * lisp.h (PUBLISH_TO_GDB): New macro.
742 (GCTYPEBITS, USE_LSB_TAG, CHECK_LISP_OBJECT_TYPE, enum pvec_type)
743 (DATA_SEG_BITS): Use it.
744 (GCTYPEBITS, USE_LSB_TAG): Now also an enum, for GDB.
745 (CHECK_LISP_OBJECT_TYPE, DATA_SEG_BITS): Now just an enum, for GDB.
746 * mem-limits.h (EXCEEDS_LISP_PTR): Redo so that DATA_SEG_BITS need
747 not be usable in #if. This simplifies things.
748
d6749401
JB
7492012-07-26 Juanma Barranquero <lekktu@gmail.com>
750
751 * makefile.w32-in ($(BLD)/emacs.$(O)): Update dependencies.
752
1781b9e9
PE
7532012-07-26 Paul Eggert <eggert@cs.ucla.edu>
754
d89518db 755 Simplify export of symbols to GDB (Bug#12036).
1781b9e9
PE
756 * .gdbinit (xgetptr, xgetint, xgettype): Don't use "set $bugfix =
757 $bugfix.i", as this doesn't work (with GDB 7.4.1, anyway).
758 (xgetptr, xgetint, xgettype, xcoding, xcharset, xprintbytestr):
759 Adjust to changes in lisp.h and emacs.c, by using
760 CHECK_LISP_OBJECT_TYPE rather than gdb_use_struct, VALMASK instead
761 of $valmask, DATA_SEG_BITS instead of gdb_data_seg_bits,
762 INTTYPEBITS instead of gdb_gctypebits - 1, USE_LSB_TAG instead of
763 gdb_use_lsb, (1 << GCTYPEBITS) - 1 instead of $tagmask, VALBITS
764 instead of gdb_valbits.
765 (xvectype, xvector, xpr, xprintstr, xbacktrace): Similarly, use
766 PSEUDOVECTOR_FLAG instead of PVEC_FLAG, and ARRAY_MARK_FLAG
767 instead of gdb_array_mark_flag.
768 (xboolvector): Get size from $->size, not $->header.size.
769 Use BOOL_VECTOR_BITS_PER_CHAR rather than mystery constants.
770 (xreload, hook-run, hookpost-run): Remove.
771 * emacs.c: Include <verify.h>.
772 (gdb_use_lsb, gdb_use_struct, gdb_valbits, gdb_gctypebits)
773 (gdb_data_seg_bits, PVEC_FLAG, gdb_array_mark_flag, gdb_pvec_type):
774 Remove.
775 (gdb_CHECK_LISP_OBJECT_TYPE, gdb_DATA_SEG_BITS, gdb_GCTYPEBITS)
776 (gdb_USE_LSB_TAG): New enum constants.
777 (CHECK_LISP_OBJECT_TYPE, DATA_SEG_BITS, GCTYPEBITS, USE_LSB_TAG):
778 Also define these as enum constants, so they're visible to GDB.
779 (ARRAY_MARK_FLAG_VAL, PSEUDOVECTOR_FLAG_VAL, VALMASK_VAL): New macros.
780 (ARRAY_MARK_FLAG, PSEUDOVECTOR_FLAG, VALMASK): Also define these
781 as constants, so they're visible to GDB.
782 * lisp.h (VALBITS, INTTYPEBITS, FIXNUM_BITS, PSEUDOVECTOR_SIZE_BITS)
783 (PSEUDOVECTOR_SIZE_MASK, PVEC_TYPE_MASK, BOOL_VECTOR_BITS_PER_CHAR):
784 Now enum constants, not macros, so they're visible to GDB.
785 (CHECK_LISP_OBJECT_TYPE, DATA_SEG_BITS): Default to 0, as this is
786 more convenient now. All uses changed.
787 (VALMASK) [USE_LSB_TAG]: Also define in this case.
788 * mem-limits.h (EXCEEDS_LISP_PTR): Adjust to DATA_SEG_BITS change.
789
3628596a
DA
7902012-07-26 Dmitry Antipov <dmantipov@yandex.ru>
791
792 Explicitly free restriction data that are not needed anymore.
793 * editfns.c (save_restriction_restore): Free restriction data.
794
7abaf5cc
SM
7952012-07-26 Stefan Monnier <monnier@iro.umontreal.ca>
796
797 * eval.c (Fautoload_do_load): Rename from do_autoload, export to Lisp,
798 add argument, tune behavior, and adjust all callers.
799
71f88e00
PE
8002012-07-25 Paul Eggert <eggert@cs.ucla.edu>
801
802 Use typedef for EMACS_INT, EMACS_UINT.
803 * lisp.h, s/ms-w32.h (EMACS_INT, EMACS_UINT): Use typedefs rather
804 than macros. This simplifies debugging in the usual case, since
805 it lets GDB show addresses as 'EMACS_INT *' rather than 'long int *'
806 and it allows expressions involving EMACS_INT casts.
807 * .gdbinit (xreload): Simplify by using EMACS_INT cast.
808
57ec3034
JD
8092012-07-25 Jan Djärv <jan.h.d@swipnet.se>
810
811 * nsterm.m (ns_read_socket): Return early if there is a modal
812 window (Bug#12043).
813
8137e7b3
MR
8142012-07-25 Martin Rudalics <rudalics@gmx.at>
815
816 * frame.c (Fredirect_frame_focus): In doc-string don't mention
817 that FOCUS-FRAME can be omitted.
818
04e9897c
DA
8192012-07-25 Dmitry Antipov <dmantipov@yandex.ru>
820
821 Adjust buffer text indirection counters at the end of Fkill_buffer.
822 * buffer.c (Fkill_buffer): Adjust indirection counters when the
823 buffer is definitely dead. This should really fix an issue reported
824 by Christoph Scholtes again. (Bug#12007).
825 (init_buffer_once): Initialize indirection counters of
826 buffer_defaults and buffer_local_symbols (for sanity and safety).
827
8a0484e1
EZ
8282012-07-24 Eli Zaretskii <eliz@gnu.org>
829
830 * xdisp.c (init_iterator): Don't compute dimensions of truncation
831 and continuation glyphs on tooltip frames, leave them at zero.
832 Avoids continued lines in tooltips. (Bug#11832)
833
fa691a83
DA
8342012-07-24 Dmitry Antipov <dmantipov@yandex.ru>
835
836 Simplify copy_overlay.
04e9897c 837 * buffer.c (copy_overlay): Simplify. Use build_marker.
fa691a83
DA
838 * lisp.h (struct Lisp_Overlay): Restore comment with minor tweaks.
839
436bc8e0
EZ
8402012-07-23 Eli Zaretskii <eliz@gnu.org>
841
842 * print.c (print_object): Don't crash when a frame's name is nil
843 or invalid. (Bug#12025)
844
845 * window.c (decode_any_window): Disable CHECK_LIVE_FRAME test, as
846 it signals an error when a tooltip frame is being created.
847
d7a7fda3
DA
8482012-07-23 Dmitry Antipov <dmantipov@yandex.ru>
849
850 Cleanup miscellaneous objects allocation and initialization.
851 * alloc.c (allocate_misc): Change to static. Add argument to
852 specify the subtype. Adjust comment and users.
853 (build_overlay): New function.
854 * buffer.c (copy_overlays, Fmake_overlay): Use it.
855 * lisp.h (struct Lisp_Overlay): Remove obsolete comment.
856 (allocate_misc): Remove prototype.
857 (build_overlay): Add prototype.
858
8592012-07-23 Dmitry Antipov <dmantipov@yandex.ru>
372f8ffc
DA
860
861 Swap buffer text indirection counters in Fbuffer_swap_text.
862 * buffer.c (Fbuffer_swap_text): Swap indirections too.
863 This avoids crash reported by Christoph Scholtes at
864 http://lists.gnu.org/archive/html/bug-gnu-emacs/2012-07/msg00785.html.
865
9d7fa573
JD
8662012-07-22 Jan Djärv <jan.h.d@swipnet.se>
867
868 * nsmenu.m (Popdown_data): New struct.
869 (pop_down_menu): p->pointer is Popdown_data. Release the pool and
870 free Popdown_data.
871 (ns_popup_dialog): Use NSAutoreleasePool and pass it to pop_down_menu.
872 (initWithContentRect): Make imgView and contentView non-static
873 and autorelease them. Also autorelease img and matrix (Bug#12005).
874 (dealloc): Remove (Bug#12005).
875
0dd6d66d
DA
8762012-07-22 Dmitry Antipov <dmantipov@yandex.ru>
877
878 Adjust consing_since_gc when objects are explicitly freed.
879 * alloc.c (GC_DEFAULT_THRESHOLD): New macro.
880 (Fgarbage_collect): Use it. Change minimum to 1/10 of default.
881 (free_cons, free_misc): Subtract object size from consing_since_gc.
882
d36d71df
DA
8832012-07-22 Dmitry Antipov <dmantipov@yandex.ru>
884
885 Simplify and cleanup markers positioning code.
886 * marker.c (attach_marker): More useful eassert.
887 (live_buffer, set_marker_internal): New function.
888 (Fset_marker, set_marker_restricted): Use set_marker_internal.
889 (set_marker_both, set_marker_restricted_both): Use live_buffer.
890
fb9ea40f
PE
8912012-07-22 Paul Eggert <eggert@cs.ucla.edu>
892
893 * buffer.h (struct buffer.indirections): Now ptrdiff_t, not int,
894 as it's limited by the amount of memory, not by INT_MAX.
895
2d5c5f7d
EZ
8962012-07-21 Eli Zaretskii <eliz@gnu.org>
897
07fb592e
EZ
898 * keyboard.c (keys_of_keyboard): Bind language-change to 'ignore'
899 in special-event-map. See the discussion at
900 http://lists.gnu.org/archive/html/emacs-devel/2012-06/msg00417.html
901 for the reasons.
902
37a9eac8 903 * w32menu.c (add_menu_item): Cast to ULONG_PTR when assigning
2d5c5f7d
EZ
904 info.dwItemData. Fixes crashes on 64-bit Windows. Suggested by
905 Fabrice Popineau <fabrice.popineau@supelec.fr>.
906
c4328746
JD
9072012-07-21 Jan Djärv <jan.h.d@swipnet.se>
908
909 * nsterm.m (accessibilityAttributeValue): New function. (Bug#11134).
4b17afa7 910 (conversationIdentifier): Return value is NSInteger.
784051c4 911 * nsterm.m (accessibilityAttributeValue): Surround with NS_IMPL_COCOA.
c4328746 912
6e5d1c12
CY
9132012-07-21 Chong Yidong <cyd@gnu.org>
914
915 * window.c (decode_any_window): Signal an error if the window is
916 on a dead frame (Bug#11984).
917
9928463d
DA
9182012-07-20 Dmitry Antipov <dmantipov@yandex.ru>
919
920 Add indirection counting to speed up Fkill_buffer.
921 * buffer.h (struct buffer): New member.
922 * buffer.c (Fget_buffer_create): Set indirection counter to 0.
923 (Fmake_indirect_buffer): Set indirection counter to -1, increment
924 base buffer indirection counter.
925 (compact_buffer): If ENABLE_CHECKING, verify indirection counters.
926 (Fkill_buffer): Adjust indirection counters as needed, don't walk
927 through buffer list if indirection counter is 0.
928
f8643a6b
DA
9292012-07-20 Dmitry Antipov <dmantipov@yandex.ru>
930
931 Extend the value returned by Fgarbage_collect with heap statistics.
932 * alloc.c (Qheap): New symbol.
933 (syms_of_alloc): DEFSYM it.
934 (Fgarbage_collect): If DOUG_LEA_MALLOC, add mallinfo data.
935 (Fmemory_free): Remove.
936 (syms_of_alloc): Don't defsubr it.
937 * buffer.c (Fcompact_buffer): Remove.
938 (syms_of_buffer): Don't defsubr it.
939
dac616ff
DA
9402012-07-20 Dmitry Antipov <dmantipov@yandex.ru>
941
942 Make maybe_gc inline.
943 Verify that inlining is always possible (GCC 4.7.1, -O3 -Winline).
944 * lisp.h (consing_since_gc, gc_relative_threshold)
945 (memory_full_cons_threshold): Revert declaration.
946 (maybe_gc): Remove prototype, define as inline.
947 * alloc.c: Remove old commented-out code.
948 (consing_since_gc, gc_relative_threshold)
949 (memory_full_cons_threshold): Revert to global.
950 (maybe_gc): Remove.
951
d7ea76b4
DA
9522012-07-20 Dmitry Antipov <dmantipov@yandex.ru>
953
954 Simple wrapper for make_unibyte_string, adjust font_open_by_name.
955 * lisp.h (build_unibyte_string): New function.
956 * dosfns.c, fileio.c, fns.c, ftfont.c, process.c:
957 * sysdep.c, w32fns.c, xfns.c: Use it.
958 * font.c (font_open_by_name): Change 2nd and 3rd args to the only arg
959 of type Lisp_Object to avoid redundant calls to make_unibyte_string.
960 Adjust users accordingly.
961 * font.h (font_open_by_name): Adjust prototype.
962
765e61e3
DA
9632012-07-20 Dmitry Antipov <dmantipov@yandex.ru>
964
965 Cleanup calls to Fgarbage_collect.
966 * lisp.h (maybe_gc): New prototype.
967 (consing_since_gc, gc_relative_threshold, memory_full_cons_threshold):
968 Remove declarations.
969 * alloc.c (maybe_gc): New function.
970 (consing_since_gc, gc_relative_threshold, memory_full_cons_threshold):
971 Make them static.
972 * bytecode.c (MAYBE_GC): Use maybe_gc.
973 * eval.c (eval_sub, Ffuncall): Likewise.
974 * keyboard.c (read_char): Likewise. Adjust call to maybe_gc
975 to avoid dependency from auto-save feature.
976
52b852c7
PE
9772012-07-19 Paul Eggert <eggert@cs.ucla.edu>
978
979 * buffer.h (FOR_EACH_BUFFER): Rename from 'for_each_buffer'.
980 (FOR_EACH_PER_BUFFER_OBJECT_AT): Rename from
981 'for_each_per_buffer_object_at'.
982 All uses changed. It's better to use upper-case for macros that
983 cannot be implemented as functions, to give the reader a clue
984 that they're special.
985
5db81e33
SM
9862012-07-19 Stefan Monnier <monnier@iro.umontreal.ca>
987
988 * alloc.c (Fgarbage_collect): Tweak docstring.
989
5b835e1d
DA
9902012-07-19 Dmitry Antipov <dmantipov@yandex.ru>
991
992 Tweak the value returned from Fgarbage_collect again.
993 * alloc.c (Fgarbage_collect): New return value, as confirmed in
994 http://lists.gnu.org/archive/html/emacs-devel/2012-07/msg00418.html.
995 Adjust documentation.
996 (total_vector_bytes): Rename to total_vector_slots, adjust
997 accounting.
998 (total_free_vector_bytes): Rename to total_free_vector_slots,
999 adjust accounting.
1000 (Qstring_bytes, Qvector_slots): New symbols.
1001 (syms_of_alloc): DEFSYM them.
1002
9cd47b72
DA
10032012-07-19 Dmitry Antipov <dmantipov@yandex.ru>
1004
1005 Buffer compaction primitive which may be used from Lisp.
1006 * buffer.c (compact_buffer, Fcompact_buffer): New function.
1007 (syms_of_buffer): Register Fcompact_buffer.
1008 * alloc.c (Fgarbage_collect): Use compact_buffer.
1009 * buffer.h (compact_buffer): New prototype.
1010 (struct buffer_text): New member.
1011
d17337e5
DA
10122012-07-19 Dmitry Antipov <dmantipov@yandex.ru>
1013
1014 New macro to iterate over all buffers, miscellaneous cleanups.
1015 * lisp.h (all_buffers): Remove declaration.
1016 * buffer.h (all_buffers): Add declaration, with comment.
1017 (for_each_buffer): New macro.
1018 * alloc.c (Fgarbage_collect, mark_object): Use it.
1019 * buffer.c (Fkill_buffer, Fbuffer_swap_text, Fset_buffer_multibyte)
1020 (init_buffer): Likewise.
1021 * data.c (Fset_default): Likewise.
1022 * coding.c (code_conversion_restore): Remove redundant check
1023 for dead buffer.
1024 * buffer.c (Fkill_buffer): Likewise. Remove obsolete comment.
1025
60cfd278
AS
10262012-07-18 Andreas Schwab <schwab@linux-m68k.org>
1027
1028 Fix bug that created negative-length intervals.
1029 * intervals.c (merge_interval_right, merge_interval_left):
1030 Do not zero out this interval if it is absorbed by its children,
1031 as this interval's total length doesn't change in that case. See
1032 <http://lists.gnu.org/archive/html/emacs-devel/2012-07/msg00403.html>.
1033
d06714cb
PE
10342012-07-18 Paul Eggert <eggert@cs.ucla.edu>
1035
83713154
PE
1036 * alloc.c (Fmake_bool_vector): Fix off-by-8 bug
1037 when invoking (make-bool-vector N t) and N is a positive
1038 multiple of 8 -- the last 8 bits were mistakenly cleared.
1039
d06714cb
PE
1040 Remove some struct layout assumptions in bool vectors.
1041 * alloc.c (bool_header_size): New constant.
1042 (header_size, word_size): Move earlier, as they're now used earlier.
1043 Use 'word_size' in a few more places, where it's appropriate.
1044 (Fmake_bool_vector, sweep_vectors): Don't assume that there is no
1045 padding before the data member of a bool vector.
1046 (sweep_vectors): Use PSEUDOVECTOR_TYPEP, in an eassert, rather
1047 than doing the check by hand with an abort ().
1048
464d5a5e
SM
10492012-07-18 Stefan Monnier <monnier@iro.umontreal.ca>
1050
5fbc0409
SM
1051 * eval.c (Fdefvar): Don't check constants since we only set the var if
1052 it's not yet defined anyway (bug#11904).
1053
464d5a5e
SM
1054 * lisp.h (last_undo_boundary): Declare new var.
1055 * keyboard.c (command_loop_1): Set it.
1056 * cmds.c (Fself_insert_command): Use it to only remove boundaries that
1057 were auto-added by the command loop (bug#11774).
1058
8dc2e44a
AS
10592012-07-18 Andreas Schwab <schwab@linux-m68k.org>
1060
1061 * w32font.c (Qsymbol): Remove local definition.
1062 (syms_of_w32font): Don't DEFSYM it.
1063
169925ec
DA
10642012-07-18 Dmitry Antipov <dmantipov@yandex.ru>
1065
1066 Fix sweep_vectors to handle large bool vectors correctly.
1067 * alloc.c (sweep_vectors): Account total_vector_bytes for
1068 bool vectors larger than VBLOCK_BYTES_MAX.
1069
5fbfb018
CY
10702012-07-18 Chong Yidong <cyd@gnu.org>
1071
1072 * frame.c (x_set_frame_parameters): Revert bogus change introduced
1073 in 2012-05-25 commit by Paul Eggert (Bug#11738).
1074
3ab6e069
DA
10752012-07-18 Dmitry Antipov <dmantipov@yandex.ru>
1076
1077 Return more descriptive data from Fgarbage_collect.
1078 Suggested by Stefan Monnier in
1079 http://lists.gnu.org/archive/html/emacs-devel/2012-07/msg00369.html.
1080 * alloc.c (bounded_number): New function.
1081 (total_buffers, total_vectors): New variable.
1082 (total_string_size): Rename to total_string_bytes, adjust users.
1083 (total_vector_size): Rename to total_vector_bytes, adjust users.
1084 (sweep_vectors): Account total_vectors and total_vector_bytes.
1085 (Fgarbage_collect): New return value. Adjust documentation.
1086 (gc_sweep): Account total_buffers.
1087 (Fmemory_free, Fmemory_use_counts): Use bounded_number.
1088 (VECTOR_SIZE): Remove.
1089 * data.c (Qfloat, Qvector, Qsymbol, Qstring, Qcons): Make global.
1090 (Qinterval, Qmisc): New symbols.
1091 (syms_of_data): Initialize them.
1092 * lisp.h (Qinterval, Qsymbol, Qstring, Qmisc, Qvector, Qfloat)
1093 (Qcons, Qbuffer): New declarations.
1094
6d02fe5b
PE
10952012-07-17 Paul Eggert <eggert@cs.ucla.edu>
1096
1097 * alloc.c (Fmemory_free): Account for memory-free's own storage.
1098 Round up, not down. Improve doc.
1099
b7ffe040
DA
11002012-07-17 Dmitry Antipov <dmantipov@yandex.ru>
1101
1102 Restore old code in allocate_string_data to avoid Faset breakage.
1103 Reported by Julien Danjou <julien@danjou.info> in
1104 http://lists.gnu.org/archive/html/emacs-devel/2012-07/msg00371.html.
1105 * alloc.c (allocate_string_data): Restore old code with minor
1106 adjustments, fix comment to explain this subtle issue.
1107
4dc7c8d5
SM
11082012-07-17 Eli Zaretskii <eliz@gnu.org>
1109
1110 Remove FILE_SYSTEM_CASE.
1111 * s/msdos.h (FILE_SYSTEM_CASE): Don't define.
1112
1113 * fileio.c (FILE_SYSTEM_CASE): Don't define.
1114 (Ffile_name_directory, Fexpand_file_name): Don't use FILE_SYSTEM_CASE.
1115 Fixes problems on MS-DOS with Vtemp_file_name_pattern when
1116 call-process-region passes it through expand-file-name.
1117
1118 * dired.c (file_name_completion): Don't use FILE_SYSTEM_CASE.
1119
11202012-07-17 Andreas Schwab <schwab@linux-m68k.org>
1121
1122 Fix crash when creating indirect buffer (Bug#11917)
1123 * buffer.c (buffer_lisp_local_variables): Add argument CLONE.
1124 Don't handle unbound variables specially if non-zero.
1125 (Fbuffer_local_variables): Pass zero.
1126 (clone_per_buffer_values): Pass non-zero.
1127
11282012-07-17 Andreas Schwab <schwab@linux-m68k.org>
1129
1130 * gnutls.c (emacs_gnutls_handshake): Revert last change. Add QUIT
1131 to make the loop interruptible.
1132
11332012-07-17 Andreas Schwab <schwab@linux-m68k.org>
1134
1135 * gnutls.c (emacs_gnutls_handshake): Only retry if
1136 GNUTLS_E_INTERRUPTED.
1137
cce7fefc
DA
11382012-07-17 Dmitry Antipov <dmantipov@yandex.ru>
1139
1140 Cleanup and convert miscellaneous checks to eassert.
1141 * alloc.c (mark_interval): Fix comment, partially rephrase
1142 old comment from intervals.h (see below).
1143 * intervals.c (find_interval, adjust_intervals_for_insertion)
1144 (delete_interval, adjust_intervals_for_deletion)
1145 (graft_intervals_into_buffer, temp_set_point_both, copy_intervals):
1146 Convert to eassert.
1147 (adjust_intervals_for_insertion, make_new_interval):
1148 Remove obsolete and unused code.
1149 * intervals.h (struct interval): Remove obsolete comment.
1150 * textprotp.c (erase_properties): Remove unused code.
1151 (Fadd_text_properties, set_text_properties_1, Fremove_text_properties)
1152 (Fremove_list_of_text_properties): Convert to eassert.
1153
9ea10cc3
CY
11542012-07-17 Chong Yidong <cyd@gnu.org>
1155
1156 * editfns.c (Finsert_char): Doc fix.
1157
3900d5de
DA
11582012-07-17 Dmitry Antipov <dmantipov@yandex.ru>
1159
1160 Fix previous change to make Fmemory_free always accurate.
1161 * alloc.c (make_interval): Update total_free_intervals.
1162 (make_float): Likewise for total_free_floats.
1163 (free_cons, Fcons): Likewise for total_free_conses.
1164 (SETUP_ON_FREE_LIST, allocate_vector_from_block):
1165 Likewise for total_free_vector_bytes.
1166 (Fmake_symbol): Likewise for total_free_symbols.
1167 (bytes_free): Remove.
1168
7098646f
DA
11692012-07-17 Dmitry Antipov <dmantipov@yandex.ru>
1170
1171 Simple free memory accounting feature.
1172 * alloc.c (bytes_free, total_free_vector_bytes): New variable.
1173 (sweep_vectors): Accumulate size of free vectors.
1174 (Fgarbage_collect): Setup bytes_free.
1175 (Fmemory_free): New function.
1176 (syms_of_alloc): Register it.
1177
22657b40
DA
11782012-07-17 Dmitry Antipov <dmantipov@yandex.ru>
1179
1180 Cleanup overlays checking.
1181 * buffer.h (OVERLAY_VALID): Remove as useless synonym of OVERLAYP.
1182 * buffer.c (overlay_touches_p, recenter_overlay_lists): Change to
1183 eassert and OVERLAYP.
1184 (sort_overlays): Change to use OVERLAYP.
1185
ddfc8813
RK
11862012-07-16 René Kyllingstad <Rene@Kyllingstad.com> (tiny change)
1187
1188 * editfns.c (Finsert_char): Make it interactive, and make the
1189 second arg optional. Copy interactive spec and docstring from
1190 ucs-insert.
1191
7c26cf3c
PE
11922012-07-17 Paul Eggert <eggert@cs.ucla.edu>
1193
1194 * floatfns.c (Fabs): Do not wrap fabs inside IN_FLOAT (Bug#11913).
1195 Unlike the other wrapped functions, fabs has an unspecified
1196 effect on errno.
1197
5d127af9
JD
11982012-07-16 Jan Djärv <jan.h.d@swipnet.se>
1199
1200 * nsterm.m (keyDown): Interpret flags without left/right bits
1201 as the left key (Bug#11670).
1202
6a0dd1d7
DA
12032012-07-16 Dmitry Antipov <dmantipov@yandex.ru>
1204
1205 Remove empty and useless init functions.
1206 * lisp.h (init_character_once, init_fns, init_image)
1207 (init_filelock, init_sound): Remove prototype.
1208 * character.c (init_character_once): Remove.
1209 * filelock.c (init_filelock): Likewise.
1210 * fns.c (init_fns): Likewise.
1211 * image.c (init_image): Likewise.
1212 * sound.c (init_sound): Likewise.
1213 * emacs.c (main): Adjust accordingly.
1214
7a6136fd
DA
12152012-07-16 Dmitry Antipov <dmantipov@yandex.ru>
1216
1217 * gtkutil.h: Tiny cleanups.
1218 (use_old_gtk_file_dialog): Remove useless declaration.
1219 (xg_uses_old_file_dialog): Add suggested const attribute.
1220
ce811ad9
EZ
12212012-07-15 Eli Zaretskii <eliz@gnu.org>
1222
1223 * bidi.c (MAX_STRONG_CHAR_SEARCH): New macro.
1224 (bidi_paragraph_init): Use it to limit search forward for a strong
1225 directional character in abnormally large paragraphs full of
1226 neutral or weak characters. (Bug#11943)
1227
c9adfeaa
SF
12282012-07-15 Stefano Facchini <stefano.facchini@gmail.com> (tiny change)
1229
1230 * gtkutil.c (xg_create_tool_bar): Apply "primary-toolbar" style to
1231 the toolbar (Bug#9451).
1232 (xg_make_tool_item): Give the widget event box a transparent
1233 background.
1234
fff62aa9
DA
12352012-07-15 Dmitry Antipov <dmantipov@yandex.ru>
1236
1237 Cleanup basic allocation variables and functions.
1238 * alloc.c (ignore_warnings, init_intervals, init_float)
1239 (init_cons, init_symbol, init_marker): Remove.
1240 (interval_block_index): Initialize to INTERVAL_BLOCK_SIZE.
1241 (float_block_index): Initialize to FLOAT_BLOCK_SIZE.
1242 (cons_block_index): Initialize to CONS_BLOCK_SIZE.
1243 (symbol_block_size): Initialize to SYMBOL_BLOCK_SIZE.
1244 (marker_block_index): Initialize to MARKER_BLOCK_SIZE.
1245 (staticidx, init_alloc_once, init_strings, free_ablock):
1246 Remove redundant initialization.
1247 * fns.c (init_weak_hash_tables): Remove.
1248 * lisp.h (init_weak_hash_tables): Remove prototype.
1249
9730daca
DA
12502012-07-15 Dmitry Antipov <dmantipov@yandex.ru>
1251
1252 Use zero_vector where appropriate.
1253 * alloc.c (zero_vector): Define as Lisp_Object. Adjust users
1254 accordingly.
1255 * lisp.h (zero_vector): New declaration.
1256 * font.c (null_vector): Remove.
1257 (syms_of_font): Remove initialization and staticpro.
1258 (font_list_entities, font_find_for_lface): Change to use zero_vector.
1259 * keymap.c (Faccessible_keymaps): Likewise.
1260
2e2d2a13
LL
12612012-07-15 Leo Liu <sdl.web@gmail.com>
1262
1263 * fringe.c: Fix typo in comments.
1264
cd276f6e
LL
12652012-07-14 Leo Liu <sdl.web@gmail.com>
1266
1267 * fringe.c: Add a new bitmap exclamation-mark.
1268
5a1131d9
EZ
12692012-07-14 Eli Zaretskii <eliz@gnu.org>
1270
1271 * gmalloc.c (GMALLOC_INHIBIT_VALLOC): Don't reference.
1272
1273 * s/msdos.h (BSD_SYSTEM, DATA_START, GC_SETJMP_WORKS, HAVE_MOUSE)
1274 (HAVE_MENUS): Don't define, defined by editing config.in with
1275 msdos/sed2v2.inp.
1276 (GMALLOC_INHIBIT_VALLOC): Don't define.
1277 (MODE_LINE_BINARY_TEXT): Remove, not used anymore.
1278
22e983b7
JB
12792012-07-14 Juanma Barranquero <lekktu@gmail.com>
1280
1281 * s/ms-w32.h (GC_SETJMP_WORKS, GC_MARK_STACK): Set in nt/config.nt.
1282
5b3f250f
GM
12832012-07-14 Glenn Morris <rgm@gnu.org>
1284
1285 * s/aix4-2.h, s/freebsd.h, s/gnu-linux.h, s/hpux10-20.h:
1286 * s/irix6-5.h, s/netbsd.h, s/sol2-6.h, s/unixware.h:
1287 Let configure set GC_SETJMP_WORKS, GC_MARK_STACK.
1288
33d63ff4
GM
12892012-07-13 Glenn Morris <rgm@gnu.org>
1290
5b633342
GM
1291 * s/gnu-linux.h (GC_MARK_SECONDARY_STACK): Let configure set it.
1292
33d63ff4
GM
1293 * s/usg5-4-common.h (SETUP_SLAVE_PTY): Let configure set it.
1294 * s/irix6-5.h (SETUP_SLAVE_PTY): No more need to unset it.
1295
b55b9f85
JD
12962012-07-13 Jan Djärv <jan.h.d@swipnet.se>
1297
0dc8cf50
JD
1298 * nsterm.m (uRect): Only define if NS_IMPL_GNUSTEP.
1299 (x_free_frame_resources): Pass x_free_frame_resources to NSTRACE.
1300 (ns_lisp_to_color, ns_string_to_lispmod, ns_term_init)
1301 (ns_term_shutdown, requestService, initFrameFromEmacs): Use SSDATA
1302 where appropriate.
1303 (ns_exec_path, ns_load_path, changeFont): Put () around assignment used
1304 as boolean expression.
1305 (x_set_window_size): Remove unused variable toolbar.
1306 (ns_get_color_default, ns_mod_to_lisp): Remove.
1307 (ns_mouse_position): Remove unused variables xchar and ychar.
1308 (ns_compute_glyph_string_overhangs): Remove unused variable face.
1309 (ns_set_vertical_scroll_bar): Remove unused variable count.
1310 (ns_delete_terminal): Remove unused variable i.
1311 (ns_term_init): Remove unused variables r, g and b.
1312 (mouseDown): Remove unused variable window.
1313 (windowDidResize): Move definition of theWindow inside NS_IMPL_GNUSTEP.
1314 (initFrameFromEmacs): Remove unused variable vbextra.
1315 (mouseEntered): Remove unused variables p and dpyinfo.
1316 (mouseExited): Remove unused variables p and r.
1317 (ns_define_frame_cursor, ns_clear_frame_area)
1318 (ns_draw_window_cursor, ns_initialize_display_info): Make static.
1319 (menuDown): Assign [sender tag] to variable and cast the variable.
1320
1321 * nsterm.h (menuDown): Add id as type to argument sender.
1322 (ns_display_info_for_name): Add Lisp_Object argument.
1323 (ns_term_init): Add Lisp_Object argument.
1324 (ns_map_event_to_object): Add void argument.
1325 (ns_string_from_pasteboard, ns_string_to_pasteboard): Add correct
1326 prototype with arguments and only declare if __OBJC__.
1327 (nxatoms_of_nsselect): Add void argument.
1328 (ns_lisp_to_cursor_type): Add Lisp_Object argument.
1329 (ns_alloc_autorelease_pool): Add void argument.
1330 (ns_release_autorelease_pool): Add void* argument.
1331 (ns_get_defaults_value): Add const char* argument.
1332
1333 * nsmenu.m (ns_update_menubar, ns_menu_show, process_dialog)
1334 (initFromContents): Use SSDATA where appropriate.
1335 (ns_update_menubar): Add braces to ambigous if-else.
1336 (initWithTitle): Put () around assignment in if statement.
1337 (ns_menu_show): Remove unused variables window and keymap.
1338 (update_frame_tool_bar): Remove unused variable selected_p.
1339 (initWithContentRect): Remove unused variable this_cmd_name.
1340
1341 * nsimage.m (ns_load_image, allocInitFromFile): Use SSDATA where
1342 appropriate.
1343 (setXBMColor): Remove unused variable len.
1344 (setPixmapData): Put () around assignment in loop statement.
1345
1346 * nsfont.m (ns_get_family, ns_lang_to_script, ns_otf_to_script)
1347 (ns_registry_to_script, ns_get_req_script, nsfont_open): Use SSDATA
1348 where appropriate.
1349 (ns_get_covering_families, ns_findfonts, nsfont_list_family): Put ()
1350 around assignment in loop statement.
1351 (nsfont_open): Remove unused variable i.
1352 (nsfont_open): Remove unused variable len.
1353 (nsfont_draw): Remove unused variable cs.
1354
1355 * nsfns.m (x_set_icon_name, ns_set_name_internal)
1356 (ns_set_name_as_filename, ns_implicitly_set_icon_type)
1357 (x_set_icon_type, ns_lisp_to_cursor_type, Fns_read_file_name)
1358 (Fns_get_resource, Fns_set_resource, Fx_open_connection)
1359 (Fns_font_name, Fns_perform_service)
1360 (Fns_convert_utf8_nfd_to_nfc, ns_do_applescript)
1361 (Fns_do_applescript, Fx_show_tip): Use SSDATA where appropriate.
1362 (ns_set_name): Remove unused variable view.
1363 (x_set_menu_bar_lines): Remove unused variable olines.
1364 (x_set_tool_bar_lines): Remove unused variable root_window.
1365 (Fns_list_colors): Put () around assignment in while statement.
1366 (Fns_perform_service): Remove unused variable len.
1367 (Fns_display_usable_bounds): Remove unused variable top.
1368 (syms_of_nsfns): Remove unused variable i.
1369
b55b9f85
JD
1370 * nsmenu.m (ns_update_menubar): Exchange place of argument 2 and 3 to
1371 memcpy (Bug#11907).
1372
ed9265fc 13732012-07-13 Kalle Kankare <kalle.kankare@iki.fi> (tiny change)
2277de02
JD
1374
1375 * image.c (Fimagemagick_types): Initialize ex with GetExceptionInfo
1376 and free it with DestroyExceptionInfo (Bug#11558).
1377
ef099b57
JB
13782012-07-13 Juanma Barranquero <lekktu@gmail.com>
1379
1380 * s/ms-w32.h (FIRST_PTY_LETTER, HAVE_SOCKETS): Move to nt/config.nt.
1381 (HAVE_ATTRIBUTE_ALIGNED, HAVE_C99_STRTOLD, HAVE___BUILTIN_UNWIND_INIT):
1382 Set here, not in nt/config.nt.
1383
ea814a5d
EZ
13842012-07-13 Eli Zaretskii <eliz@gnu.org>
1385
1386 * xdisp.c (move_it_in_display_line_to): On GUI terminals, allow
1387 cursor overflow into the last glyph on display line when the right
1388 fringe is off. (Bug#11832)
1389
1a952767
PE
13902012-07-13 Paul Eggert <eggert@cs.ucla.edu>
1391
1392 * xdisp.c (produce_special_glyphs): Now static.
1393 * dispextern.h (produce_special_glyphs): Remove decl.
1394
983188fd
GM
13952012-07-13 Glenn Morris <rgm@gnu.org>
1396
8d7c7eed 1397 * s/bsd-common.h, s/cygwin.h: Remove empty files.
32fb4bb6
GM
1398 * s/freebsd.h, s/netbsd.h: Do not include bsd-common.h.
1399
983188fd
GM
1400 * s/usg5-4-common.h (USG, USG5):
1401 * s/template.h (USG5, USG, HPUX, BSD4_2, BSD_SYSTEM):
1402 * s/sol2-6.h (SOLARIS2):
1403 * s/irix6-5.h (IRIX6_5):
1404 * s/hpux10-20.h (USG, USG5, HPUX):
1405 * s/gnu-linux.h (USG, GNU_LINUX):
1406 * s/freebsd.h (BSD_SYSTEM):
1407 * s/darwin.h (BSD4_2, BSD_SYSTEM, DARWIN_OS):
1408 * s/cygwin.h (CYGWIN):
1409 * s/bsd-common.h (BSD_SYSTEM, BSD4_2):
1410 * s/aix4-2.h (USG, USG5, _AIX): Move "system type" macros to configure.
1411
d1e68667 14122012-07-13 BT Templeton <bpt@hcoop.net> (tiny change)
24ef80ae
PE
1413
1414 * nsfont.m (ns_charset_covers): Don't abort if no bitmap (Bug#11853).
24ef80ae 1415
6de0e799
GM
14162012-07-13 Glenn Morris <rgm@gnu.org>
1417
739ae010
GM
1418 * s/usg5-4-common.h (NSIG_MINIMUM): Let configure set it.
1419
dbee5793
GM
1420 * s/gnu-linux.h, s/irix6-5.h: Let configure set ULIMIT_BREAK_VALUE.
1421
6de0e799
GM
1422 * process.c (init_process_emacs): Replace MIN_PTY_KERNEL_VERSION.
1423 * s/darwin.h (MIN_PTY_KERNEL_VERSION): Remove single-use macro.
1424
b82da769
GM
14252012-07-12 Glenn Morris <rgm@gnu.org>
1426
4fae5a7a 1427 * s/darwin.h (SYSTEM_PURESIZE_EXTRA): Move to configure.
b82da769
GM
1428
1429 * process.c (init_process_emacs): Rename from init_process.
1430 The old name is also the name of a Mach system call.
1431 * lisp.h, emacs.c: Update for this name change.
1432 * nsgui.h, sysselect.h, s/darwin.h: Remove workaround that is no
1433 longer needed.
1434
5a979817
EZ
14352012-07-12 Eli Zaretskii <eliz@gnu.org>
1436
1437 * xdisp.c (insert_left_trunc_glyphs): Fix incorrect size in
1438 memmove call that removes glyphs covered by the left truncation
1439 glyph. Improve commentary.
1440 (display_line): Fix display of continuation glyphs on GUI frames
1441 when the right fringe is turned off and variable-size fonts are
1442 used in the window. Move the code that appends a stretch glyph to
1443 produce_special_glyphs, so that it could be used for truncation
1444 and continuation glyphs alike.
1445 (produce_special_glyphs) [HAVE_WINDOW_SYSTEM]: Produce a stretch
1446 glyph of a suitably computed width, to align the special glyphs at
1447 the window margin. Code moved from display_line. (Bug#11832)
1448
3e91a053
GM
14492012-07-12 Glenn Morris <rgm@gnu.org>
1450
ba9e4b84
GM
1451 * s/aix4-2.h, s/hpux10-20.h: Let configure set NO_EDITRES.
1452
1453 * s/gnu-linux.h, s/hpux10-20.h:
1454 Do not unconditionally define HAVE_XRMSETDATABASE.
1455
3e91a053
GM
1456 * s/gnu-linux.h (UNIX98_PTYS): Let configure set it.
1457
b300b1f4
PE
14582012-07-12 Paul Eggert <eggert@cs.ucla.edu>
1459
1460 Fix typos that broke OS X build.
1461 Reported by Randal L. Schwartz in
1462 <http://lists.gnu.org/archive/html/emacs-devel/2012-07/msg00225.html>.
1463 * nsterm.m (ns_timeout): Add missing local decl.
1464 (ns_get_color): snprintf -> sprintf, to fix typo.
1465
6e777848
GM
14662012-07-12 Glenn Morris <rgm@gnu.org>
1467
3f922c37
GM
1468 * src/s/aix4-2.h, src/s/cygwin.h, src/s/darwin.h:
1469 * src/s/gnu-linux.h, src/s/hpux10-20.h, src/s/irix6-5.h:
1470 * src/s/sol2-6.h, src/s/unixware.h, src/s/usg5-4-common.h:
1471 Move PTY_NAME_SPRINTF, PTY_TTY_NAME_SPRINTF to configure.
1472
0ab7b23a
GM
1473 * s/cygwin.h, s/darwin.h, s/gnu-linux.h, s/irix6-5.h:
1474 Move PTY_OPEN to configure.
1475
6e777848
GM
1476 * s/aix4-2.h, s/bsd-common.h, s/cygwin.h, s/darwin.h:
1477 * s/gnu-linux.h, s/hpux10-20.h, s/irix6-5.h, s/template.h:
1478 * s/usg5-4-common.h: Move FIRST_PTY_LETTER, PTY_ITERATION to configure.
1479
4a7edc24
DA
14802012-07-12 Dmitry Antipov <dmantipov@yandex.ru>
1481
1482 Use empty_unibyte_string where applicable.
1483 * keyboard.c (parse_tool_bar_item): Use empty_unibyte_string.
1484 * lread.c (read1): Likewise.
1485 * xsettings.c (syms_of_xsettings): Likewise.
1486
308aab79
GM
14872012-07-12 Glenn Morris <rgm@gnu.org>
1488
42bd1719
GM
1489 * s/cygwin.h (G_SLICE_ALWAYS_MALLOC):
1490 * s/freebsd.h (BROKEN_PTY_READ_AFTER_EAGAIN):
7ccad002
GM
1491 * s/irix6-5.h (SETPGRP_RELEASES_CTTY, PREFER_VSUSP):
1492 * s/hpux10-20.h (RUN_TIME_REMAP):
1493 * s/bsd-common.h (TABDLY): Move to configure.
1494
1495 * s/hpux10-20.h, s/sol2-6.h: Move XOS_NEEDS_TIME_H to configure.
1496
1497 * s/bsd-common.h, s/darwin.h: Move TAB3 to configure.
1498
ea0bbd17 1499 * s/aix4-2.h (BROKEN_FIONREAD, BROKEN_SIGAIO, BROKEN_SIGPTY)
42bd1719 1500 (BROKEN_SIGPOLL, BROKEN_GET_CURRENT_DIR_NAME): Let configure set them.
ea0bbd17
GM
1501
1502 * s/darwin.h (NO_ABORT, NO_MATHERR): Let configure set them.
51c3b9b4 1503
308aab79
GM
1504 * s/bsd-common.h, s/cygwin.h, s/gnu-linux.h, s/irix6-5.h:
1505 * s/template.h: Move NARROWPROTO to configure.
1506
ee1cf5cf
GM
15072012-07-11 Glenn Morris <rgm@gnu.org>
1508
30fe9bf4
GM
1509 * s/gnu-linux.h, s/sol2-6.h: No longer define POSIX,
1510 unused since 2011-01-17 change to systty.h.
1511
ee1cf5cf
GM
1512 * s/aix4-2.h, s/bsd-common.h, s/cygwin.h, s/darwin.h, s/gnu-linux.h:
1513 * s/hpux10-20.h, s/template.h, s/usg5-4-common.h:
1514 Move HAVE_PTYS and HAVE_SOCKETS to configure.
1515
63e47e07
PE
15162012-07-11 Paul Eggert <eggert@cs.ucla.edu>
1517
1518 * s/sol2-6.h (HAVE_LIBKSTAT): Remove. (Bug#11914)
1519
c43fb4c3
GM
15202012-07-11 Glenn Morris <rgm@gnu.org>
1521
1522 * s/darwin.h, s/gnu-linux.h, s/template.h:
1523 Move INTERRUPT_INPUT to configure.
1524
e8df9267
DA
15252012-07-11 Dmitry Antipov <dmantipov@yandex.ru>
1526
1527 Minor adjustments to interning code.
1528 * lisp.h (intern, intern_c_string): Redefine as static inline
1529 wrappers for intern_1 and intern_c_string_1, respectively.
1530 (intern_1, intern_c_string_1): Rename prototypes.
2bce5643
DA
1531 * lread.c (intern_1, intern_c_string_1, oblookup): Simplify
1532 Vobarray checking.
e8df9267
DA
1533 * font.c (font_intern_prop): Likewise. Adjust comment.
1534 * w32font.c (intern_font_name): Likewise.
1535
34348bd4
AS
15362012-07-11 Andreas Schwab <schwab@linux-m68k.org>
1537
d96a1e0c
AS
1538 * gnutls.c (Fgnutls_boot): Properly parse :keylist argument.
1539
34348bd4
AS
1540 * coding.c (Fdefine_coding_system_internal): Use XCAR/XCDR instead
1541 of Fcar/Fcdr if possible.
1542 * font.c (check_otf_features): Likewise.
1543 * fontset.c (Fnew_fontset): Likewise.
1544 * gnutls.c (Fgnutls_boot): Likewise.
1545 * minibuf.c (read_minibuf): Likewise.
1546 * msdos.c (IT_set_frame_parameters): Likewise.
1547 * xmenu.c (Fx_popup_dialog): Likewise.
1548 * w32menu.c (Fx_popup_dialog): Likewise.
1549
c8add24e
GM
15502012-07-11 Glenn Morris <rgm@gnu.org>
1551
4b575b3c
GM
1552 * s/bsd-common.h, s/cygwin.h: No need to undefine INTERRUPT_INPUT,
1553 since nothing has defined it on these platforms.
1554
09f4e3b0
GM
1555 * s/aix4-2.h, s/bsd-common.h, s/cygwin.h, s/gnu-linux.h:
1556 * s/irix6-5.h: Move SIGNALS_VIA_CHARACTERS to configure.
1557
172bedef
GM
1558 * s/aix4-2.h, s/bsd-common.h, s/cygwin.h, s/darwin.h:
1559 * s/gnu-linux.h, s/hpux10-20.h, s/template.h, s/usg5-4-common.h:
1560 Move CLASH_DETECTION to configure.
1561
249685df
GM
1562 * s/gnu.h: Remove file, which is now empty.
1563
c8add24e
GM
1564 * s/gnu.h, s/gnu-linux.h:
1565 Move GNU_LIBRARY_PENDING_OUTPUT_COUNT to configure.
1566
b41253a3
JW
15672012-07-11 John Wiegley <johnw@newartisans.com>
1568
1569 * alloc.c (mark_memory): Guard the "no_address_safety_analysis"
1570 function attribute, so we only use it if it exists in the
1571 compiler.
1572
d923b542
DA
15732012-07-11 Dmitry Antipov <dmantipov@yandex.ru>
1574
1575 Avoid call to strlen in fast_c_string_match_ignore_case.
1576 * search.c (fast_c_string_match_ignore_case): Change to use
1577 length argument. Adjust users accordingly.
1578 * lisp.h (fast_c_string_match_ignore_case): Adjust prototype.
1579
5ebbef1d
PE
15802012-07-11 Paul Eggert <eggert@cs.ucla.edu>
1581
bb352260
PE
1582 Assume mkdir, rmdir.
1583 * sysdep.c (mkdir) [!HAVE_MKDIR]: Remove.
1584 * sysdep.c (rmdir) [!HAVE_RMDIR]: Remove.
1585
57054ddd
PE
1586 Assume rename.
1587 * sysdep.c (rename) [!HAVE_RENAME]: Remove.
1588
b747d3f7
PE
1589 Assume perror.
1590 * s/hpux10-20.h (HAVE_PERROR): Remove.
1591 * sysdep.c (perror) [HPUX && !HAVE_PERROR]:
1592 Remove dummy definition, as this problem was obsolete long ago.
1593
5ebbef1d
PE
1594 Assume strerror.
1595 * sysdep.c (strerror) [!HAVE_STRERROR && !WINDOWSNT]: Remove.
1596
984e7f30
DA
15972012-07-11 Dmitry Antipov <dmantipov@yandex.ru>
1598
1599 Avoid calls to strlen in font processing functions.
1600 * font.c (font_parse_name, font_parse_xlfd, font_parse_fcname)
d923b542 1601 (font_open_by_name): Change to use length argument. Adjust
984e7f30 1602 users accordingly.
d923b542
DA
1603 * font.h (font_open_by_name, font_parse_xlfd, font_unparse_xlfd):
1604 Adjust prototypes.
1605 * xfont.c (xfont_decode_coding_xlfd, font_unparse_xlfd):
1606 Change to return ptrdiff_t.
984e7f30
DA
1607 (xfont_list_pattern, xfont_match): Use length returned by
1608 xfont_decode_coding_xlfd.
1609 * xfns.c (x_default_font_parameter): Omit useless xstrdup.
1610
20e94fdd
GM
16112012-07-11 Glenn Morris <rgm@gnu.org>
1612
9d596af3
GM
1613 * s/darwin.h, s/freebsd.h, s/netbsd.h:
1614 Move DONT_REOPEN_PTY to configure.
1615
20e94fdd
GM
1616 * sound.c (DEFAULT_SOUND_DEVICE) [!WINDOWSNT]:
1617 * s/netbsd.h (DEFAULT_SOUND_DEVICE): Let configure set it.
1618
e99a530f
PE
16192012-07-10 Paul Eggert <eggert@cs.ucla.edu>
1620
22ffb973
PE
1621 Remove "#define unix" that is no longer needed (Bug#11905).
1622 * s/aix4-2.h (unix): Remove; no longer needed.
1623
e9a9ae03
PE
1624 EMACS_TIME simplification (Bug#11875).
1625 This replaces macros (which typically do not work in GDB)
1626 with functions, typedefs and enums, making the code easier to debug.
1627 The functional style also makes code easier to read and maintain.
1628 * systime.h: Include <sys/time.h> on all hosts, not just if
1629 WINDOWSNT, since 'struct timeval' is needed in general.
1630 (EMACS_TIME): Now a typedef, not a macro.
1631 (EMACS_TIME_RESOLUTION, LOG10_EMACS_TIME_RESOLUTION): Now constants,
1632 not macros.
1633 (EMACS_SECS, EMACS_NSECS, EMACS_TIME_SIGN, EMACS_TIME_VALID_P)
1634 (EMACS_TIME_FROM_DOUBLE, EMACS_TIME_TO_DOUBLE, EMACS_TIME_EQ)
1635 (EMACS_TIME_NE, EMACS_TIME_GT, EMACS_TIME_GE, EMACS_TIME_LT)
1636 (EMACS_TIME_LE): Now functions, not macros.
1637 (EMACS_SET_SECS, EMACS_SET_NSECS, EMACS_SET_SECS_NSECS)
1638 (EMACS_SET_USECS, EMACS_SET_SECS_USECS): Remove these macros,
1639 which are not functions. All uses rewritten to use:
1640 (make_emacs_time): New function.
1641 (EMACS_SECS_ADDR, EMACS_SET_INVALID_TIME, EMACS_GET_TIME)
1642 (EMACS_ADD_TIME, EMACS_SUB_TIME): Remove these macros, which are
1643 not functions. All uses rewritten to use the following, respectively:
1644 (emacs_secs_addr, invalid_emacs_time, get_emacs_time)
1645 (add_emacs_time, sub_emacs_time): New functions.
ed9265fc 1646 * atimer.c: Don't include <sys/time.h>, as "systime.h" does this.
e9a9ae03
PE
1647 * fileio.c (Fcopy_file):
1648 * xterm.c (XTflash): Get the current time closer to when it's used.
1649 * makefile.w32-in ($(BLD)/atimer.$(O)): Update dependencies.
1650
ffacb126
PE
1651 * bytecode.c (targets): Suppress -Woverride-init warnings.
1652
e99a530f
PE
1653 Simplify by avoiding confusing use of strncpy etc.
1654 * doc.c (Fsnarf_documentation):
1655 * fileio.c (Ffile_name_directory, Fsubstitute_in_file_name):
1656 * frame.c (Fmake_terminal_frame):
1657 * gtkutil.c (get_utf8_string):
1658 * lread.c (openp):
1659 * nsmenu.m (ns_update_menubar):
1660 * regex.c (regerror):
1661 Prefer memcpy to strncpy and strncat when either will do.
1662 * fileio.c (Fsubstitute_in_file_name):
1663 * keyboard.c (MULTI_LETTER_MOD, parse_modifiers_uncached)
1664 (menu_separator_name_p):
1665 * nsmenu.m (ns_update_menubar):
1666 Prefer memcmp to strncmp when either will do.
1667 * nsterm.m: Include <ftoastr.h>.
1668 (ns_get_color):
1669 * s/gnu-linux.h, s/sol2-6.h, s/unixware.h (PTY_TTY_NAME_SPRINTF):
1670 Prefer snprintf to strncpy.
1671 * nsterm.m (ns_term_init):
1672 * widget.c (set_frame_size) [0]: Prefer xstrdup to xmalloc + strncpy.
1673 * nsterm.m (ns_term_init):
1674 Avoid the need for strncpy, by using build_string or
1675 make_unibyte_string directly. Use dtoastr, not snprintf.
1676 * process.c (Fmake_network_process): Diagnose service names that
1677 are too long, rather than silently truncating them or creating
1678 non-null-terminated names.
1679 (Fnetwork_interface_info): Likewise, for interface names.
1680 * sysdep.c (system_process_attributes) [GNU_LINUX]:
1681 Prefer sprintf to strncat.
1682 * xdisp.c (debug_method_add) [GLYPH_DEBUG]:
1683 Prefer vsnprintf to vsprintf + strncpy.
1684
c59592b3
GM
16852012-07-10 Glenn Morris <rgm@gnu.org>
1686
1687 * dispnew.c (PENDING_OUTPUT_COUNT) [!__GNU_LIBRARY__]:
1688 Clarify fallback case.
1689
7d7bbefd
DA
16902012-07-10 Dmitry Antipov <dmantipov@yandex.ru>
1691
1692 Use XCAR and XCDR instead of Fcar and Fcdr where possible.
1693 * callint.c, coding.c, doc.c, editfns.c, eval.c, font.c, fontset.c,
1694 * frame.c, gnutls.c, minibuf.c, msdos.c, textprop.c, w32fns.c,
d923b542 1695 * w32menu.c, window.c, xmenu.c: Change to use XCAR and XCDR
7d7bbefd
DA
1696 where argument type is known to be a Lisp_Cons.
1697
3a4c8000
TT
16982012-07-10 Tom Tromey <tromey@redhat.com>
1699
1700 * bytecode.c (BYTE_CODE_THREADED): New macro.
1701 (BYTE_CODES): New macro. Replaces all old byte-code defines.
1702 (enum byte_code_op): New type.
1703 (CASE, NEXT, FIRST, CASE_DEFAULT, CASE_ABORT): New macros.
1704 (exec_byte_code): Use them. Use token threading when applicable.
1705
2a0213a6
DA
17062012-07-10 Dmitry Antipov <dmantipov@yandex.ru>
1707
1708 Optimize pure C strings initialization.
1709 * lisp.h (make_pure_string): Fix prototype.
1710 (build_pure_c_string): New function, defined as static inline. This
1711 provides a better opportunity to optimize away calls to strlen when
1712 the function is called with compile-time constant argument.
1713 * alloc.c (make_pure_c_string): Fix comment. Change to add nchars
1714 argument, adjust users accordingly. Use build_pure_c_string where
1715 appropriate.
1716 * buffer.c, coding.c, data.c, dbusbind.c, fileio.c, fontset.c, frame.c,
1717 * keyboard.c, keymap.c, lread.c, search.c, syntax.c, w32fns.c, xdisp.c,
1718 * xfaces.c, xfns.c, xterm.c: Use build_pure_c_string where appropriate.
1719
cb1caeaf
DA
17202012-07-10 Dmitry Antipov <dmantipov@yandex.ru>
1721
1722 Avoid calls to strlen in miscellaneous functions.
1723 * buffer.c (init_buffer): Use precalculated len, adjust if needed.
1724 * font.c (Ffont_xlfd_name): Likewise. Change to call make_string.
1725 * lread.c (openp): Likewise.
1726
c293e30c
DA
17272012-07-10 Dmitry Antipov <dmantipov@yandex.ru>
1728
1729 Avoid calls to strlen in path processing functions.
1730 * fileio.c (file_name_as_directory): Add comment. Change to add
1731 srclen argument and return the length of result. Adjust users
1732 accordingly.
1733 (directory_file_name): Fix comment. Change to add srclen argument,
cb1caeaf 1734 swap 1st and 2nd arguments to obey the common convention. Adjust
c293e30c
DA
1735 users accordingly.
1736 * filelock.c (fill_in_lock_file_name): Avoid calls to strlen.
1737
9e059e3f
GM
17382012-07-10 Glenn Morris <rgm@gnu.org>
1739
d02eb359
GM
1740 * s/cygwin.h, s/darwin.h, s/freebsd.h, s/netbsd.h, s/unixware.h:
1741 Move PENDING_OUTPUT_COUNT definition to configure.
1742
882cf227
GM
1743 * s/irix6-5.h (DATA_START, DATA_SEG_BITS):
1744 * s/hpux10-20.h (DATA_SEG_BITS, DATA_START):
1745 * s/gnu.h (DATA_START): Move definitions to configure.
1746
af6e839f
GM
1747 * s/irix6-5.h (SETUP_SLAVE_PTY, PTY_NAME_SPRINTF): Drop ifdef guards.
1748 We include usg5-4-common.h, which defines them both.
1749
40289a12
GM
1750 * s/gnu.h: Don't include fcntl.h (every file in Emacs that uses
1751 O_RDONLY already includes it).
1752
9e059e3f
GM
1753 Stop ns builds setting the EMACSLOADPATH environment variable.
1754 * nsterm.m (ns_load_path): Rename from ns_init_paths.
1755 Now it does not set EMACSLOADPATH, just returns the load-path string.
1756 * nsterm.h: Update accordingly.
1757 * lread.c [HAVE_NS]: Include nsterm.h.
1758 (init_lread) [HAVE_NS]: Use ns_load_path.
1759 * emacs.c (main) [HAVE_NS]: No longer call ns_init_paths.
1760
7c4e8ec0
GM
17612012-07-09 Glenn Morris <rgm@gnu.org>
1762
d4f600ff
GM
1763 * s/gnu.h (SIGNALS_VIA_CHARACTERS): No need to define it here,
1764 since the included bsd-common.h does so.
1765
cbb31951
GM
1766 Stop ns builds setting the EMACSPATH environment variable.
1767 * nsterm.m (ns_exec_path): New function, split from ns_init_paths.
1768 (ns_init_paths): Do not set EMACSPATH.
1769 * nsterm.h (ns_exec_path): Add it.
1770 * callproc.c (init_callproc_1, init_callproc) [HAVE_NS]:
1771 Use ns_exec_path.
1772
7c4e8ec0
GM
1773 * nsterm.m, nsterm.h (ns_etc_directory): Fix type, empty return.
1774
26bccfae
PE
17752012-07-09 Paul Eggert <eggert@cs.ucla.edu>
1776
a0bee46f
PE
1777 * process.c (wait_reading_process_output): 'waitchannels' was unset
1778 when read_kbd || !NILP (wait_for_cell); fix this.
1779
5994c183
PE
1780 Add GCC-style 'const' attribute to functions that can use it.
1781 * character.h (char_resolve_modifier_mask):
1782 * keyboard.h (make_ctrl_char):
1783 * lisp.h (multibyte_char_to_unibyte, multibyte_char_to_unibyte_safe)
1784 (init_character_once, next_almost_prime, init_fns, init_image)
1785 (flush_pending_output, init_sound):
1786 * mem-limits.h (start_of_data):
1787 * menu.h (finish_menu_items):
1788 Add ATTRIBUTE_CONST.
1789 * emacs.c (DEFINE_DUMMY_FUNCTION):
1790 Declare the dummy function with ATTRIBUTE_CONST.
1791 * lisp.h (Fbyteorder, Fmax_char, Fidentity):
1792 Add decls with ATTRIBUTE_CONST.
1793
26bccfae
PE
1794 Minor improvements to make_formatted_string.
1795 * alloc.c (make_formatted_string): Prefer int to ptrdiff_t
1796 where int is good enough, as vsprintf returns an int.
1797 * lisp.h (make_formatted_string): Add ATTRIBUTE_FORMAT_PRINTF.
1798
a8290ec3
DA
17992012-07-09 Dmitry Antipov <dmantipov@yandex.ru>
1800
1801 Use make_formatted_string to avoid double length calculation.
1802 * lisp.h (make_formatted_string): New prototype.
1803 * alloc.c (make_formatted_string): New function.
1804 * buffer.c (Fgenerate_new_buffer_name): Use it.
1805 * dbus.c (syms_of_dbusbind): Likewise.
1806 * editfns.c (Fcurrent_time_zone): Likewise.
1807 * filelock.c (get_boot_time): Likewise.
1808 * frame.c (make_terminal_frame, set_term_frame_name)
1809 (x_report_frame_params): Likewise.
1810 * image.c (gs_load): Likewise.
1811 * minibuf.c (get_minibuffer): Likewise.
1812 * msdos.c (dos_set_window_size): Likewise.
1813 * process.c (make_process): Likewise.
1814 * xdisp.c (ensure_echo_area_buffers): Likewise.
1815 * xsettings.c (apply_xft_settings): Likewise.
1816
d01ba2f1
GM
18172012-07-09 Glenn Morris <rgm@gnu.org>
1818
1819 Stop ns builds polluting the environment with EMACSDATA, EMACSDOC.
1820 * nsterm.m (ns_etc_directory): New function, split from ns_init_paths.
1821 (ns_init_paths): Do not set EMACSDATA, EMACSDOC.
1822 * nsterm.h (ns_etc_directory): Add it.
1823 * callproc.c [HAVE_NS]: Include nsterm.h.
1824 (init_callproc_1, init_callproc) [HAVE_NS]: Use ns_etc_directory.
1825
f1f924b6
DA
18262012-07-09 Dmitry Antipov <dmantipov@yandex.ru>
1827
1828 Move marker debugging code under MARKER_DEBUG.
1829 * marker.c (MARKER_DEBUG): Move marker debugging code under
1830 #ifdef MARKER_DEBUG because byte_char_debug_check is too slow
1831 for bootstrap with --enable-checking (~3x slowdown reported
1832 by Juanma Barranquero <lekktu@gmail.com>).
1833 (verify_bytepos): Move under #ifdef MARKER_DEBUG.
1834
ab531b66
PE
18352012-07-08 Paul Eggert <eggert@cs.ucla.edu>
1836
1837 * systime.h (EMACS_SUB_TIME): Clarify behavior with unsigned time_t.
1838 See <http://bugs.gnu.org/11825#29>.
1839
c4b3bc8a
EZ
18402012-07-08 Eli Zaretskii <eliz@gnu.org>
1841
1842 * xdisp.c (fill_glyphless_glyph_string): If the face of the glyph
1843 has no font, use the frame's font. (Bug#11813)
3434fe8a
EZ
1844 (display_line): Add commentary about displaying truncation glyphs
1845 on GUI frames.
1846 (produce_special_glyphs): Move here from term.c.
1847
1848 * term.c (produce_special_glyphs): Move to xdisp.c.
1849
1850 * dispextern.h (produce_special_glyphs): Move prototype to xdisp.c
1851 section.
c4b3bc8a 1852
b676b881
AS
18532012-07-07 Andreas Schwab <schwab@linux-m68k.org>
1854
f17c5273
AS
1855 * xdisp.c (display_line): Avoid warning about implicit declaration
1856 of FRAME_FONT.
1857
298819b9
AS
1858 * frame.c (get_frame_param): Define only if HAVE_WINDOW_SYSTEM.
1859
b676b881
AS
1860 * lisp.h: Remove empty conditional.
1861
6045c4fd
PE
18622012-07-07 Paul Eggert <eggert@cs.ucla.edu>
1863
b3350bf9
PE
1864 * lread.c (load_path_check): Now static.
1865
6045c4fd
PE
1866 Fix some minor --with-ns problems found by static checking.
1867 * frame.c (Ftool_bar_pixel_width) [!FRAME_TOOLBAR_WIDTH]:
1868 (x_set_font) [!HAVE_X_WINDOWS]:
1869 * image.c (xpm_load_image) [HAVE_NS]:
1870 (x_to_xcolors) [!HAVE_X_WINDOWS && !HAVE_NTGUI]:
1871 (x_disable_image) [!HAVE_NS && !HAVE_NTGUI]:
1872 Remove unused local.
1873 (Fx_parse_geometry) [HAVE_NS]: Don't return garbage.
1874 (xpm_load_image) [HAVE_NS && !HAVE_XPM]: Remove unused label.
1875 * image.c (x_create_bitmap_from_file) [HAVE_NS]:
1876 (xpm_load_image, xpm_load) [HAVE_NS && !HAVE_XPM]:
1877 * nsselect.m (symbol_to_nsstring, ns_string_to_pasteboard_internal):
1878 * xfaces.c (Fx_load_color_file) [!HAVE_X_WINDOWS]:
1879 Fix pointer signedness problem.
1880 * xfaces.c (FRAME_X_FONT_TABLE):
1881 * xterm.h (FRAME_X_FONT_TABLE): Remove unused, incompatible macros.
1882
929e7845
GM
18832012-07-07 Glenn Morris <rgm@gnu.org>
1884
1885 * lread.c (load_path_check): New function, split from init_lread.
1886 (init_lread): Reorganize. Motivation:
1887 If EMACSLOADPATH is set, check/warn about that rather than the
1888 defaults, which we are not going to use. Hence we can remove
1889 the turn_off_warning and WINDOWSNT || HAVE_NS tests.
1890 Don't warn if site-lisp directories are missing.
1891 If not installed, start from a blank load-path, since
1892 PATH_LOADSEARCH refers to the eventual installation directories.
1893
58dd0aa4
EZ
18942012-07-07 Eli Zaretskii <eliz@gnu.org>
1895
1896 Support truncation and continuation glyphs on GUI frames, when
1897 fringes are disabled. (Bug#11832)
1898 * xdisp.c (init_iterator): Get dimensions of truncation and
1899 continuation glyphs even if on GUI frames. Adjust
1900 it->last_visible_x on GUI frames when the left or right fringes,
1901 or both, are absent.
1902 (start_display, move_it_in_display_line_to): Handle the case of a
1903 GUI frame without a fringe to display continuation or truncation
1904 glyphs.
1905 (insert_left_trunc_glyphs): Support GUI frames: make sure
1906 truncation glyphs overwrite enough glyphs from the current line to
1907 have sufficient space in pixels.
1908 (display_line): Support truncation and continuation glyphs on GUI
1909 frames. If some spare pixels are left on the line after inserting
1910 the truncation glyphs, fill that space with a stretch glyph of a
1911 suitably computed width.
1912
1913 * term.c (produce_special_glyphs): Call PRODUCE_GLYPHS, not
1914 produce_glyphs, to support GUI sessions.
1915
31571fd7
PE
19162012-07-07 Paul Eggert <eggert@cs.ucla.edu>
1917
5a16b9bc
PE
1918 * sysdep.c (ULLONG_MAX): Define if not already defined (Bug#11781).
1919
f3047c75
PE
1920 * sysdep.c (list_system_processes): Port to NetBSD-current (Bug#11797).
1921
31571fd7
PE
1922 Do not require float-time's arg to fit in time_t (Bug#11825).
1923 This works better on hosts where time_t is unsigned, and where
1924 float-time is applied to the (negative) difference between two times.
1925 * editfns.c (decode_time_components): Last arg is now double *,
1926 not int *, and means to store all the result as a double, without
1927 worrying about whether the seconds part fits in time_t.
1928 All callers changed.
1929 (lisp_time_argument): Remove last int * arg, as it's no longer needed.
1930 All callers changed.
1931 (Ffloat_time): Do not fail merely because the specified time falls
1932 outside of time_t range.
1933
4516fbef
GM
19342012-07-07 Glenn Morris <rgm@gnu.org>
1935
1936 * s/darwin.h (HAVE_RES_INIT, HAVE_LIBRESOLV):
1937 * s/hpux10-20.h (HAVE_RINT, HAVE_RANDOM):
1938 * s/unixware.h (HAVE_GETWD): Move undefs to configure (effectively).
1939
07adc2c6
JB
19402012-07-07 Juanma Barranquero <lekktu@gmail.com>
1941
1942 * makefile.w32-in (DISPEXTERN_H, $(BLD)/regex.$(O)):
1943 Update dependencies.
1944
1945 * s/ms-w32.h [_MSC_VER]: Remove strcasecmp, strncasecmp.
1946
fd573f31
PE
19472012-07-06 Paul Eggert <eggert@cs.ucla.edu>
1948
fee5959d
PE
1949 Use c_strcasecmp for ASCII case-insensitive comparison (Bug#11786).
1950 * dispextern.h, nsfns.m, nsterm.m: Include <c-strcase.h>.
1951 * dispextern.h (xstrcasecmp): Rewrite using c_strcasecmp.
1952 * nsfns.m (x_get_string_resource): Use c_strncasecmp, not strncasecmp.
1953 * nsterm.m (ns_default): Use c_strcasecmp, not strcasecmp.
1954 * xfaces.c (xstrcasecmp) [!HAVE_STRCASECMP]: Remove.
1955
fd573f31
PE
1956 * xfont.c (compare_font_names): Redo to omit the need for casts.
1957
ddadbc0e
AS
19582012-07-06 Andreas Schwab <schwab@linux-m68k.org>
1959
fca8d6b6
AS
1960 * xfns.c (Fx_change_window_property): Doc fix.
1961 * w32fns.c (Fx_change_window_property): Doc fix.
1962
ddadbc0e
AS
1963 * w32fns.c (Fx_window_property): Accept the same arguments as the
1964 X Windows version. Doc fix.
1965 * xfns.c (Fx_window_property): Doc fix. (Bug#11870)
1966
ed9265fc 19672012-07-06 Juanma Barranquero <lekktu@gmail.com>
f247498e
JB
1968 Eli Zaretskii <eliz@gnu.org>
1969
1970 * s/ms-w32.h: Settings not specific to Windows moved to nt/config.nt.
1971 Windows-specific code from nt/config.nt moved here.
1972 Obsolete settings removed.
1973
216ee680
PE
19742012-07-06 Paul Eggert <eggert@cs.ucla.edu>
1975
1976 * process.c: Avoid unnecessary calls to gettime.
1977 (wait_reading_process_output): Don't get the time of day
1978 when gobbling data immediately and not waiting, as there's no need
1979 for it in that case. This removes a FIXME.
1980
bdd091e4
JD
19812012-07-06 Jan Djärv <jan.h.d@swipnet.se>
1982
1983 * gtkutil.c (xg_event_is_for_scrollbar): Assign gwin when HAVE_GTK3
1984 is defined (Bug#11768).
1985
9d44f8ce
DA
19862012-07-06 Dmitry Antipov <dmantipov@yandex.ru>
1987
1988 Fix marker debugging code.
1989 * marker.c (byte_char_debug_check): Do not perform the check
1990 if buffer is not multibyte.
090bd7cb
JB
1991 (buf_charpos_to_bytepos, buf_bytepos_to_charpos):
1992 Call byte_char_debug_check with correct arguments.
9d44f8ce 1993
90fc4786
DA
19942012-07-06 Dmitry Antipov <dmantipov@yandex.ru>
1995
1996 Compile marker debugging code only if ENABLE_CHECKING is defined.
090bd7cb
JB
1997 * marker.c (byte_char_debug_check, count_markers):
1998 Use only if ENABLE_CHECKING is defined.
90fc4786
DA
1999 (byte_debug_flag): Remove.
2000 (CONSIDER, buf_charpos_to_bytepos, buf_bytepos_to_charpos):
2001 Always call byte_char_debug_check if ENABLE_CHECKING is defined.
2002
7b7ae965
DA
20032012-07-06 Dmitry Antipov <dmantipov@yandex.ru>
2004
4e57b342
DA
2005 Avoid code repetition in marker-related functions.
2006 * marker.c (attach_marker): New function.
2007 (Fset_marker, set_marker_restricted, set_marker_both)
2008 (set_marker_restricted_both): Use it.
2009 (Fset_marker, set_marker_restricted, Fbuffer_has_markers_at):
2010 Consistently rename charno to charpos.
2011 (marker_position): Add eassert.
2012 (marker_byte_position): Convert to eassert.
2013
20142012-07-06 Dmitry Antipov <dmantipov@yandex.ru>
2015
2016 Simplify list operations in unchain_overlay and unchain_marker.
7b7ae965 2017 * buffer.c (unchain_overlay): Simplify. Add comment.
4e57b342 2018 * marker.c (unchain_marker): Simplify. Fix comments.
7b7ae965 2019
657924ff
DA
20202012-07-06 Dmitry Antipov <dmantipov@yandex.ru>
2021
2022 Introduce fast path for the widely used marker operation.
2023 * alloc.c (build_marker): New function.
2024 * lisp.h (build_marker): New prototype.
2025 * buffer.c (clone_per_buffer_values, Fmake_indirect_buffer): Use it.
2026 * composite.c (autocmp_chars): Likewise.
2027 * editfns.c (buildmark): Remove.
2028 (Fpoint_marker, Fpoint_min_marker, Fpoint_max_marker)
2029 (save_restriction_save): Use build_marker.
2030 * marker.c (buf_charpos_to_bytepos, buf_bytepos_to_charpos): Likewise.
2031 * window.c (save_window_save): Likewise.
2032
041a49a6
DA
20332012-07-06 Dmitry Antipov <dmantipov@yandex.ru>
2034
2035 Do not use Fdelete_overlay in delete_all_overlays
2036 to avoid redundant calls to unchain_overlay.
2037 * buffer.c (drop_overlay): New function.
2038 (delete_all_overlays, Fdelete_overlay): Use it.
2039 * minibuf.c (get_minibuffer): Fix comment.
2040
7dca65a4
PE
20412012-07-06 Paul Eggert <eggert@cs.ucla.edu>
2042
2043 Port to OpenBSD 5.1 amd64.
2044 * sysdep.c [BSD_SYSTEM]: Include <sys/param.h> before <sys/sysctl.h>.
2045 This is needed for OpenBSD, and should be harmless on all BSD systems.
2046 Also, include <sys/sysctl.h>, as it should be available on all
2047 BSD_SYSTEM hosts given that we're already calling sysctl in that case.
2048 (list_system_processes) [__OpenBSD__]: Use DARWIN_OS style mib, but
2049 use p_pid member, not kp_proc.pid.
2050
8eb876e2
GM
20512012-07-06 Glenn Morris <rgm@gnu.org>
2052
2053 * Makefile.in (emacs$(EXEEXT)): Don't check for load-path shadows.
2054
38182d90
PE
20552012-07-05 Paul Eggert <eggert@cs.ucla.edu>
2056
2057 More xmalloc and related cleanup.
2058 * alloc.c, bidi.c, buffer.c, buffer.h, bytecode.c, callint.c:
2059 * callproc.c, charset.c, coding.c, composite.c, data.c, dispnew.c:
2060 * doc.c, editfns.c, emacs.c, eval.c, fileio.c, filelock.c, fns.c:
2061 * font.c, fontset.c, frame.c, fringe.c, ftfont.c, ftxfont.c, gmalloc.c:
2062 * gtkutil.c, image.c, keyboard.c, keymap.c, lread.c, macros.c, menu.c:
2063 * nsfns.m, nsfont.m, nsmenu.m, nsterm.m, print.c, process.c, ralloc.c:
2064 * regex.c, region-cache.c, scroll.c, search.c, sound.c, syntax.c:
2065 * sysdep.c, term.c, termcap.c, unexmacosx.c, window.c, xdisp.c:
2066 * xfaces.c, xfns.c, xftfont.c, xgselect.c, xmenu.c, xrdb.c, xselect.c:
2067 * xterm.c:
2068 Omit needless casts involving void * pointers and allocation.
2069 Prefer "P = xmalloc (sizeof *P)" to "P = xmalloc (sizeof (TYPE_OF_P))",
2070 as the former is more robust if P's type is changed.
2071 Prefer xzalloc to xmalloc + memset 0.
2072 Simplify malloc-or-realloc to realloc.
2073 Don't worry about xmalloc returning a null pointer.
2074 Prefer xstrdup to xmalloc + strcpy.
2075 * editfns.c (Fmessage_box): Grow message_text by at least 80 when
2076 growing it.
2077 * keyboard.c (apply_modifiers_uncached): Prefer local array to
2078 alloca of a constant.
2079
6dd5a677
EZ
20802012-07-05 Eli Zaretskii <eliz@gnu.org>
2081
2082 * xdisp.c (display_line): Fix horizontal pixel coordinates when
2083 hscroll is larger than the line width. Fixes long and futile
2084 looping inside extend_face_to_end_of_line (on a TTY) producing
2085 glyphs that are not needed and thrown away.
2086
6b312f0f
DA
20872012-07-05 Dmitry Antipov <dmantipov@yandex.ru>
2088
2089 * marker.c (set_marker_restricted_both): Simplify by using
2090 clip_to_bounds.
2091
f520ef9b
PE
20922012-07-05 Paul Eggert <eggert@cs.ucla.edu>
2093
2094 * editfns.c (region_limit): Simplify by using clip_to_bounds.
2095
383b7c95
JD
20962012-07-05 Jan Djärv <jan.h.d@swipnet.se>
2097
2098 * gtkutil.c (gtk_scrollbar_new, gtk_box_new): Define when HAVE_GTK3 is
2099 not defined (Bug#11768).
2100 (xg_create_frame_widgets): Use gtk_plug_new_for_display (Bug#11768).
2101 (xg_create_frame_widgets, create_dialog, xg_get_file_with_chooser)
2102 (make_widget_for_menu_item, xg_make_tool_item): Use gtk_box_new
2103 followed by gtk_box_set_homogeneous (Bug#11768).
2104 (xg_update_menu_item): Use GTK_IS_BOX (Bug#11768).
090bd7cb
JB
2105 (update_theme_scrollbar_width, xg_create_scroll_bar):
2106 Use gtk_scrollbar_new (Bug#11768).
383b7c95
JD
2107 (xg_event_is_for_scrollbar): Use Gdk Device functions for HAVE_GTK3.
2108 (is_box_type): New function (Bug#11768).
2109 (xg_tool_item_stale_p): Call is_box_type.
5293d758 2110 (xg_initialize): Get settings by calling gtk_settings_get_for_screen
383b7c95
JD
2111 with default display (Bug#11768).
2112
d6e7bf45
EZ
21132012-07-05 Eli Zaretskii <eliz@gnu.org>
2114
2115 * xdisp.c (window_hscroll_limited): New function.
2116 (pos_visible_p, init_iterator): Use it to avoid overflow of pixel
2117 coordinates when window's hscroll is set to insanely large
2118 values. (Bug#11857)
2119
431391ec
JB
21202012-07-05 Juanma Barranquero <lekktu@gmail.com>
2121
2122 * makefile.w32-in ($(BLD)/dired.$(O), $(BLD)/fileio.$(O)): Fix typo.
2123 ($(BLD)/terminal.$(O), $(BLD)/syntax.$(O)): Update dependencies.
2124
23f86fce
DA
21252012-07-05 Dmitry Antipov <dmantipov@yandex.ru>
2126
2127 Cleanup xmalloc.
2128 * lisp.h (xzalloc): New prototype. Omit needless casts.
2129 * alloc.c (xzalloc): New function. Omit needless casts.
2130 * charset.c: Omit needless casts. Convert all calls to
2131 xmalloc with following memset to xzalloc.
2132 * dispnew.c: Likewise.
2133 * fringe.c: Likewise.
2134 * image.c: Likewise.
2135 * sound.c: Likewise.
2136 * term.c: Likewise.
2137 * w32fns.c: Likewise.
2138 * w32font.c: Likewise.
2139 * w32term.c: Likewise.
2140 * xfaces.c: Likewise.
2141 * xfns.c: Likewise.
2142 * xterm.c: Likewise.
2143 * atimer.c: Omit needless casts.
2144 * buffer.c: Likewise.
2145 * callproc.c: Likewise.
2146 * ccl.c: Likewise.
2147 * coding.c: Likewise.
2148 * composite.c: Likewise.
2149 * doc.c: Likewise.
2150 * doprnt.c: Likewise.
2151 * editfns.c: Likewise.
2152 * emacs.c: Likewise.
2153 * eval.c: Likewise.
2154 * filelock.c: Likewise.
2155 * fns.c: Likewise.
2156 * gtkutil.c: Likewise.
2157 * keyboard.c: Likewise.
2158 * lisp.h: Likewise.
2159 * lread.c: Likewise.
2160 * minibuf.c: Likewise.
2161 * msdos.c: Likewise.
2162 * print.c: Likewise.
2163 * process.c: Likewise.
2164 * region-cache.c: Likewise.
2165 * search.c: Likewise.
2166 * sysdep.c: Likewise.
2167 * termcap.c: Likewise.
2168 * terminal.c: Likewise.
2169 * tparam.c: Likewise.
2170 * w16select.c: Likewise.
2171 * w32.c: Likewise.
2172 * w32reg.c: Likewise.
2173 * w32select.c: Likewise.
2174 * w32uniscribe.c: Likewise.
2175 * widget.c: Likewise.
2176 * xdisp.c: Likewise.
2177 * xmenu.c: Likewise.
2178 * xrdb.c: Likewise.
2179 * xselect.c: Likewise.
2180
0497dc44
PE
21812012-07-05 Paul Eggert <eggert@cs.ucla.edu>
2182
2183 * fileio.c (time_error_value): Check the right error number.
2184 Problem reported by Troels Nielsen in
2185 <http://lists.gnu.org/archive/html/emacs-devel/2012-07/msg00095.html>.
2186
356e7178
PE
21872012-07-04 Paul Eggert <eggert@cs.ucla.edu>
2188
4e71fd89
PE
2189 * window.c (set_window_hscroll): Revert the 100000 hscroll limit.
2190 This should be fixed in a better way; see Eli Zaretskii in
2191 <http://lists.gnu.org/archive/html/emacs-devel/2012-07/msg00088.html>.
2192 (HSCROLL_MAX): Remove; this is now internal to set_window_hscroll.
2193
f0941253
PE
2194 * fileio.c (time_error_value): Rename from special_mtime.
2195 The old name's problems were noted by Eli Zaretskii in
2196 <http://lists.gnu.org/archive/html/emacs-devel/2012-07/msg00087.html>.
2197
065c9eb4
PE
2198 * emacs.c (gdb_pvec_type): Change it back to enum pvec_type.
2199 This variable's comment says Emacs needs at least one GDB-visible
2200 symbol of type enum pvec_type, to work around GDB problems.
2201 The symbol's value doesn't matter.
2202
356e7178
PE
2203 * alloc.c (PSEUDOVECTOR_NBYTES): Remove stray ';'
2204 that causes compilation to fail on pre-C99 compilers.
2205
ed9265fc 22062012-07-04 Juanma Barranquero <lekktu@gmail.com>
95f61aa2
JB
2207
2208 * s/ms-w32.h (LISP_FLOAT_TYPE, HAVE_MEMCMP, HAVE_MEMCPY)
2209 (HAVE_MEMMOVE, HAVE_MEMSET): Don't set, obsolete.
2210
3884d954
DA
22112012-07-04 Dmitry Antipov <dmantipov@yandex.ru>
2212
d209e2fb 2213 * buffer.c (init_buffer_once): Fix initialization of
3884d954
DA
2214 headers for buffer_defaults and buffer_local_symbols.
2215 Reported by Juanma Barranquero <lekktu@gmail.com>.
2216
ee28be33
SM
22172012-07-04 Stefan Monnier <monnier@iro.umontreal.ca>
2218
2219 Turn VECTOR_FREE_LIST_FLAG into PVEC_FREE.
2220 * lisp.h (enum pvec_type): Use fewer bits.
2221 (PSEUDOVECTOR_SIZE_BITS): New constant.
2222 (PSEUDOVECTOR_SIZE_MASK, PVEC_TYPE_MASK): Use it.
2223 (XSETPVECTYPESIZE, XSETTYPED_PSEUDOVECTOR, DEFUN): Adapt code to
2224 change in pvec_type.
2225 (PSEUDOVECTOR_TYPEP): New macro.
2226 (TYPED_PSEUDOVECTORP): Use it.
2227 * fns.c (internal_equal): Adapt code to extract pvectype.
2228 * emacs.c (gdb_pvec_type): Update type.
2229 * alloc.c (PSEUDOVECTOR_NBYTES): New macro.
2230 (VECTOR_FREE_LIST_SIZE_MASK): Remove (=> PSEUDOVECTOR_SIZE_MASK).
2231 (VECTOR_FREE_LIST_FLAG): Remove (=> PVEC_FREE).
2232 (SETUP_ON_FREE_LIST): Use XSETPVECTYPESIZE.
2233 (sweep_vectors): Use it. Use local var `total_bytes' instead of
2234 abusing vector->header.next.nbytes.
2235 (live_vector_p): Use PVEC_TYPE.
2236 (mark_object): Adapt code to extract pvectype. Use switch.
2237
c7f2cd7f
PE
22382012-07-04 Paul Eggert <eggert@cs.ucla.edu>
2239
2240 * doprnt.c (doprnt): Don't assume string length fits in 'int'.
2241 Tighten new eassert a bit.
2242
8ce70ed2
DA
22432012-07-04 Dmitry Antipov <dmantipov@yandex.ru>
2244
2245 Fix compilation with --enable-gcc-warnings and -O1
2246 optimization level.
2247 * doprnt.c (doprnt): Change type of tem to int, initialize
2248 to avoid compiler warning. Add eassert.
2249 * search.c (simple_search): Initialize match_byte to avoid
2250 compiler warning. Add eassert.
2251
dea7f1e5
PE
22522012-07-04 Paul Eggert <eggert@cs.ucla.edu>
2253
24a212eb
PE
2254 Avoid weird behavior with large horizontal scrolls.
2255 Without this change, for example, large hscroll values would
2256 mess up Emacs's display on Fedora 15 x86, presumably due to
2257 overflows in int calculations in the display code.
2258 Also, if buffers had long lines, Emacs would freeze.
2259 * window.c (HSCROLL_MAX): Reduce to 100000, and make it visible to GDB.
2260 (set_window_hscroll): New function, containing the old guts of
2261 Fset_window_hscroll. Return the clipped value.
2262 (Fset_window_hscroll, Fscroll_left, Fscroll_right): Use it.
2263 This avoids the need to check against PTRDIFF_MAX.
2264
dea7f1e5
PE
2265 * buffer.c (Fgenerate_new_buffer_name): Fix sprintf format mismatch.
2266
76046526
DA
22672012-07-04 Dmitry Antipov <dmantipov@yandex.ru>
2268
2269 * buffer.c (Fgenerate_new_buffer_name): Fix type mismatch.
2270
39adff0d
PE
22712012-07-04 Paul Eggert <eggert@cs.ucla.edu>
2272
63807d47
PE
2273 * regex.c: Suppress GCC warning on RHEL 6. (Bug#11207)
2274 Conditionalize the pragmas on GCC 4.5 or later, not GCC 4.3 or later,
2275 since GCC 4.4.6 issues a bogus warning for them.
2276
39adff0d
PE
2277 Fix bugs in file timestamp newness comparisons.
2278 * fileio.c (Ffile_newer_than_file_p):
2279 * lread.c (Fload): Use full timestamp resolution of files,
2280 not just the 1-second resolution, so that files that are only
2281 slightly newer still count as newer.
2282 * fileio.c (Ffile_newer_than_file_p): Don't assume file
2283 timestamps fit in 'int'; this fixes a Y2038 bug on most hosts.
2284
dbeed9a6
PE
22852012-07-03 Paul Eggert <eggert@cs.ucla.edu>
2286
2287 * fileio.c: Improve handling of file time marker. (Bug#11852)
2288 (special_mtime): New function.
2289 (Finsert_file_contents, Fverify_visited_file_modtime):
2290 Use it to set special mtime values consistently.
2291
636334d6
AS
22922012-07-03 Andreas Schwab <schwab@linux-m68k.org>
2293
2294 * fileio.c (Finsert_file_contents): Properly handle st_mtime
2295 marker for non-existing file. (Bug#11852)
2296
e2017fe2
GM
22972012-07-03 Glenn Morris <rgm@gnu.org>
2298
2299 * lisp.h (Fread_file_name): Restore EXFUN (it's not a normal DEFUN
2300 and did not make it into globals.h).
2301
404dbd37
TT
23022012-07-03 Tom Tromey <tromey@redhat.com>
2303
2304 * window.c (Fset_window_margins, Fset_window_fringes)
2305 (Fset_window_scroll_bars, Fset_window_vscroll): No longer static.
2306 * textprop.c (Fprevious_property_change): No longer static.
2307 * syntax.c (Fsyntax_table_p): No longer static.
2308 * process.c (Fget_process, Fprocess_datagram_address): No longer
2309 static.
2310 * keymap.c (Flookup_key, Fcopy_keymap): No longer static.
2311 * keyboard.c (Fcommand_execute): No longer static.
2312 Remove EXFUN.
2313 * insdel.c (Fcombine_after_change_execute): No longer static.
2314 * image.c (Finit_image_library): No longer static.
2315 * fileio.c (Fmake_symbolic_link): No longer static.
2316 * eval.c (Ffetch_bytecode): No longer static.
2317 * editfns.c (Fuser_full_name): No longer static.
d209e2fb
JB
2318 * doc.c (Fdocumentation_property, Fsnarf_documentation):
2319 No longer static.
404dbd37
TT
2320 * buffer.c (Fset_buffer_major_mode, Fdelete_overlay): No longer
2321 static.
2322 * dired.c (Ffile_attributes): No longer static.
2323 * composite.c (Fcomposition_get_gstring): No longer static.
2324 * callproc.c (Fgetenv_internal): No longer static.
2325
2326 * ccl.h: Remove EXFUNs.
2327 * buffer.h: Remove EXFUNs.
2328 * dispextern.h: Remove EXFUNs.
2329 * intervals.h: Remove EXFUNs.
2330 * fontset.h: Remove EXFUN.
2331 * font.h: Remove EXFUNs.
2332 * dosfns.c (system_process_attributes): Remove EXFUN.
2333 * keymap.h: Remove EXFUNs.
2334 * lisp.h: Remove EXFUNs.
2335 * w32term.h: Remove EXFUNs.
2336 * window.h: Remove EXFUNs.
2337 * xsettings.h: Remove EXFUN.
2338 * xterm.h: Remove EXFUN.
2339
8e4fd1e1
GM
23402012-07-03 Glenn Morris <rgm@gnu.org>
2341
2342 * lisp.h (Frandom): Make it visible to C.
2343 * buffer.c (Fgenerate_new_buffer_name): Speed up finding a new
2344 buffer for invisible buffers. (Bug#1229)
2345
ca95b3eb
DA
23462012-07-03 Dmitry Antipov <dmantipov@yandex.ru>
2347
2348 Fix block vector allocation code to allow VECTOR_BLOCK_SIZE
2349 values which aren't power of 2.
2350 * alloc.c (VECTOR_FREE_LIST_SIZE_MASK): New macro. Verify
2351 it's value and the value of VECTOR_BLOCK_SIZE. Adjust users
2352 accordingly.
2353
7555c33f
SM
23542012-07-03 Stefan Monnier <monnier@iro.umontreal.ca>
2355
2356 * lisp.h (Lisp_Misc, Lisp_Fwd): Move around to group better.
2357
2358 * alloc.c (mark_object): Revert part of last patch to use `switch'.
2359
d12e8f5a
DA
23602012-07-03 Dmitry Antipov <dmantipov@yandex.ru>
2361
2362 * alloc.c (allocate_vector_block): Remove redundant
2363 calls to mallopt if DOUG_LEA_MALLOC is defined.
2364 (allocate_vectorlike): If DOUG_LEA_MALLOC is defined,
2365 avoid calls to mallopt if zero_vector is returned.
2366
296094c3
DA
23672012-07-03 Dmitry Antipov <dmantipov@yandex.ru>
2368
2369 * alloc.c (check_string_bytes): If GC_CHECK_STRING_BYTES
2370 is enabled, avoid dereferencing NULL current_sblock if
2371 running undumped.
2372
36429c89
DA
23732012-07-03 Dmitry Antipov <dmantipov@yandex.ru>
2374
2375 Cleanup basic buffer management.
2376 * buffer.h (struct buffer): Change layout to use generic vector
2377 marking code. Fix some comments. Change type of 'clip_changed'
2378 to bitfield. Remove unused #ifndef old.
2379 (FIRST_FIELD_PER_BUFFER, LAST_FIELD_PER_BUFFER): Remove.
2380 (GET_OVERLAYS_AT): Fix indentation.
2381 (for_each_per_buffer_object_at): New macro.
2382 * buffer.c (clone_per_buffer_values, reset_buffer_local_variables)
2383 (Fbuffer_local_variables): Use it.
2384 (init_buffer_once, syms_of_buffer): Remove unused #ifndef old.
2385 * alloc.c (allocate_buffer): Adjust to match new layout of
2386 struct buffer. Fix comment.
2387 (mark_overlay): New function.
2388 (mark_buffer): Use it. Use mark_vectorlike to mark normal
2389 Lisp area of struct buffer.
2390 (mark_object): Use it. Adjust marking of misc objects
2391 and related comments.
2392
3b3e4cac
PE
23932012-07-02 Paul Eggert <eggert@cs.ucla.edu>
2394
2395 * alloc.c (mark_object): Remove "#ifdef GC_CHECK_MARKED_OBJECTS"
2396 wrapper that is not needed because the wrapped code is a no-op (zero
2397 machine instructions) when GC_CHECK_MARKED_OBJECTS is not defined.
2398 This avoids a -Wunused-macros diagnostic with GCC 4.7.1 x86-64.
2399
cf5c0175
DA
24002012-07-02 Dmitry Antipov <dmantipov@yandex.ru>
2401
2402 * alloc.c (mark_buffer): Simplify. Remove prototype.
2403 (mark_object): Add comment. Reorganize marking of vector-like
faf611c7 2404 objects. Use CHECK_LIVE for all vector-like objects except buffers
cf5c0175
DA
2405 and subroutines when GC_CHECK_MARKED_OBJECTS is defined. Avoid
2406 redundant calls to mark_vectorlike for bool vectors.
2407
ca26824c
GM
24082012-06-30 Glenn Morris <rgm@gnu.org>
2409
2e4c5312
GM
2410 * nsterm.m (ns_init_paths): Ignore site-lisp if --no-site-lisp.
2411
ca26824c
GM
2412 * epaths.in (PATH_SITELOADSEARCH): New.
2413 * lread.c (init_lread): Use PATH_SITELOADSEARCH.
2414 This is rather than relying on --enable-locallisppath elements
2415 having "site-lisp" in their names. (Bug#10208#25, 11658)
2416
0d23c240
EZ
24172012-06-30 Eli Zaretskii <eliz@gnu.org>
2418
c9240d7a
EZ
2419 * w32proc.c (sys_select): Accept and ignore one more argument.
2420
2421 * w32.c (emacs_gnutls_pull): Call select with one more argument.
2422
0d23c240 2423 * sysselect.h [DOS_NT]: Don't include sys/select.h.
9ff8f76b 2424 (pselect) [!MS_DOS]: Redirect to sys_select.
0d23c240
EZ
2425
2426 * sysdep.c: Don't include dos.h and dosfns.h.
2427
2428 * process.c (sys_select):
2429 * msdos.c (sys_select): Accept one more argument and ignore it.
2430
2431 * msdos.c (event_timestamp, sys_select): Use gnulib's gettime;
2432 adapt data types and code to that.
2433
2434 * dosfns.c:
2435 * msdos.c (gettime, settime): Define away the prototypes in dos.h,
2436 which clashes with the gnulib function of the same name.
2437
af5a5a98
AS
24382012-06-30 Andreas Schwab <schwab@linux-m68k.org>
2439
c5e4379c
AS
2440 * font.c (font_style_to_value, font_style_symbolic)
2441 (font_prop_validate_style): Add type checks for values in
2442 font_style_table.
2443
af5a5a98
AS
2444 * lisp.h (CHECK_RANGED_INTEGER): Make value to check the first
2445 argument.
2446 * character.c, charset.c, menu.c, process.c, window.c: Adjust all
2447 uses.
2448
8d38f461
EZ
24492012-06-29 Eli Zaretskii <eliz@gnu.org>
2450
2e5a6631
EZ
2451 * xdisp.c (try_window_id): Undo last change.
2452
8d38f461
EZ
2453 * w32.c (getwd): Adjust commentary about startup_dir.
2454 (init_environment): Always call sys_access, even in non-MSVC
2455 builds. Don't chdir to the directory of the Emacs executable.
2456 This undoes code from 1997 which was justified by the need to
2457 "avoid conflicts when removing and renaming directories". But its
2458 downside was that every relative file name was being interpreted
2459 relative to the directory of the Emacs executable, which can never
2460 be TRT. In particular, it broke sys_access when called with
2461 relative file names.
2462 (sys_access): Map GetLastError to errno.
2463
2af3565e
DA
24642012-06-29 Dmitry Antipov <dmantipov@yandex.ru>
2465
2466 * window.h (struct window): Change type of 'fringes_outside_margins'
2467 to bitfield. Fix comment. Adjust users accordingly.
cf5c0175 2468 (struct window): Change type of 'window_end_bytepos' to ptrdiff_t.
2af3565e
DA
2469 Adjust comment.
2470 * xdisp.c (try_window_id): Change type of 'first_vpos' and 'vpos'
2471 to ptrdiff_t.
2472
c8d3a25c 24732012-06-29 Andreas Schwab <schwab@linux-m68k.org>
57570cd3 2474
c8d3a25c
GM
2475 * gnutls.c (emacs_gnutls_handshake):
2476 Add QUIT to make the loop interruptible.
57570cd3 2477
c8d3a25c 24782012-06-29 Glenn Morris <rgm@gnu.org>
d01fd55f 2479
c8d3a25c
GM
2480 * charset.c (init_charset): Make lack of etc/charsets fatal.
2481
3e984ee8
DA
24822012-06-29 Dmitry Antipov <dmantipov@yandex.ru>
2483
2484 * editfns.c (region_limit): Fix type mismatch.
2485
ef884f23
DA
24862012-06-29 Dmitry Antipov <dmantipov@yandex.ru>
2487
2488 * nsfns.m: Fix GLYPH_DEBUG usage assuming that it may be
2489 undefined. Convert from xassert to eassert.
2490 * nsmenu.m: Convert from xassert to eassert.
2491 * nsterm.m: Likewise.
2492
7d7e0027
SM
24932012-06-28 Stefan Monnier <monnier@iro.umontreal.ca>
2494
2495 * editfns.c (region_limit): Clip to narrowing (bug#11770).
2496
aa754e6a
PE
24972012-06-28 Paul Eggert <eggert@cs.ucla.edu>
2498
2499 Avoid integer overflow on scroll-left and scroll-right.
2500 * window.c (HSCROLL_MAX): New macro.
2501 (Fscroll_left, Fscroll_right): Avoid undefined behavior on integer
2502 overflow when requested scroll falls outside ptrdiff_t range.
2503
80b00b08
DA
25042012-06-28 Dmitry Antipov <dmantipov@yandex.ru>
2505
2506 * window.h (struct window): Change type of 'hscroll',
2507 'min_hscroll' and 'last_point' from Lisp_Object to ptrdiff_t,
2508 'last_modified' and 'last_overlay_modified' to EMACS_INT.
2509 Adjust users accordingly.
2510 * xdisp.c (try_cursor_movement): Replace type check with eassert.
2511 * window.c (Fscroll_left, Fscroll_right): Change type of 'hscroll'
2512 from EMACS_INT to ptrdiff_t.
2513 (make_window): Omit redundant initialization.
2514
62b2bcf6
JB
25152012-06-28 Juanma Barranquero <lekktu@gmail.com>
2516
2517 * makefile.w32-in ($(BLD)/regex.$(O)): Update dependencies.
2518
45942c7d
DA
25192012-06-28 Dmitry Antipov <dmantipov@yandex.ru>
2520
2521 * window.h (struct window): Change type of 'use_time' and
2522 'sequence_number' from Lisp_Object to int.
2523 * frame.c (make_frame): Adjust users accordingly.
2524 * print.c (print_object): Likewise.
2525 * window.c (select_window, Fwindow_use_time, make_parent_window)
2526 (make_window): Likewise.
2527
e509cfa6
DA
25282012-06-28 Dmitry Antipov <dmantipov@yandex.ru>
2529
2530 * dispextern.h (GLYPH_DEBUG): Now defined in config.h if
2531 enabled with --enable-checking=[all,glyphs] configure option.
2532 Fix GLYPH_DEBUG usage assuming that it may be undefined,
2533 adjust comments accordingly.
2534 * dispnew.c: Fix GLYPH_DEBUG usage assuming that it may be
2535 undefined, adjust comments accordingly.
2536 * image.c: Likewise.
2537 * scroll.c: Likewise.
2538 * w32fns.c: Likewise.
2539 * w32term.c: Likewise.
2540 * xdisp.c: Likewise.
2541 * xfaces.c: Likewise.
2542 * xfns.c: Likewise.
2543 * xterm.c: Likewise.
2544
a54e2c05
DA
25452012-06-28 Dmitry Antipov <dmantipov@yandex.ru>
2546
2547 Generalize run-time debugging checks.
2548 * dispextern.h (XASSERTS): Remove.
2549 * fontset.c (xassert): Remove.
2550 Convert from xassert to eassert.
2551 * alloc.c: Convert from xassert to eassert.
2552 * bidi.c: Likewise.
2553 * dispnew.c: Likewise.
2554 * fns.c: Likewise.
2555 * fringe.c: Likewise.
2556 * ftfont.c: Likewise.
2557 * gtkutil.c: Likewise.
2558 * image.c: Likewise.
2559 * keyboard.c: Likewise.
2560 * menu.c: Likewise.
2561 * process.c: Likewise.
2562 * scroll.c: Likewise.
2563 * sound.c: Likewise.
2564 * term.c: Likewise.
2565 * w32console.c: Likewise.
2566 * w32fns.c: Likewise.
2567 * w32term.c: Likewise.
2568 * window.c: Likewise.
2569 * xdisp.c: Likewise.
2570 * xfaces.c: Likewise.
2571 * xfns.c: Likewise.
2572 * xselect.c: Likewise.
2573 * xterm.c: Likewise.
2574
1ec4b7b2
SM
25752012-06-27 Stefan Monnier <monnier@iro.umontreal.ca>
2576
2577 * fns.c (maybe_resize_hash_table): Output message when growing the
2578 purify-hashtable.
2579
2014308a
DA
25802012-06-27 Dmitry Antipov <dmantipov@yandex.ru>
2581
2582 * alloc.c (allocate_string_data): Remove dead code.
2583 * xsettings.c (XSETTINGS_FONT_NAME): Move under HAVE_XFT to
2584 avoid GCC warning about unused macro.
2585
246155eb
DA
25862012-06-27 Dmitry Antipov <dmantipov@yandex.ru>
2587
2588 * alloc.c (allocate_string): Omit intervals initialization.
2589 * alloc.c (make_uninit_multibyte_string): Initialize intervals
2590 as in make_pure_string and make_pure_c_string.
2591
43184b7b
DA
25922012-06-27 Dmitry Antipov <dmantipov@yandex.ru>
2593
d209e2fb 2594 * alloc.c (allocate_string): Fix last change.
43184b7b 2595
3fe6dd74
DA
25962012-06-27 Dmitry Antipov <dmantipov@yandex.ru>
2597
d209e2fb 2598 * alloc.c (allocate_string): Remove two redundant calls
3fe6dd74
DA
2599 to memset, add explicit initialization where appropriate.
2600
1ba6038a
GM
26012012-06-27 Glenn Morris <rgm@gnu.org>
2602
2603 * lisp.mk (lisp): Remove paths.elc.
2604
c89926a5
CY
26052012-06-27 Chong Yidong <cyd@gnu.org>
2606
2607 * doc.c (Fsubstitute_command_keys): Fix punctuation.
2608
ed6b3510
JW
26092012-06-26 John Wiegley <johnw@newartisans.com>
2610
1ec4b7b2 2611 * unexmacosx.c (copy_data_segment): Add two section names used
157e99e4
JW
2612 on Mac OS X Lion: __mod_init_func and __mod_term_func.
2613
ed6b3510
JW
2614 * alloc.c (mark_memory): Do not check with -faddress-sanitizer
2615 when building with Clang.
2616
8edd4a2b
SM
26172012-06-26 Stefan Monnier <monnier@iro.umontreal.ca>
2618
2619 * eval.c (Fapply): Allow calling it with a single argument.
2620
f6f62d1b
EZ
26212012-06-26 Eli Zaretskii <eliz@gnu.org>
2622
2623 * s/ms-w32.h (strcasecmp, strncasecmp) [_MSC_VER]: Redirect to
2624 _stricmp and _strnicmp.
2625 (HAVE_STRCASECMP, HAVE_STRNCASECMP): Define to 1.
2626
62efea5e
DA
26272012-06-26 Dmitry Antipov <dmantipov@yandex.ru>
2628
2629 * alloc.c (allocate_window): Zero out non-Lisp part of newly
2630 allocated window.
2631 (allocate_process): Likewise for new process.
8edd4a2b 2632 (allocate_terminal): Change to use offsetof.
62efea5e
DA
2633 (allocate_frame): Likewise.
2634 * frame.c (make_frame): Omit redundant initialization.
2635 * window.c (make_parent_window): Use memset.
2636 (make_window): Omit redundant initialization.
2637 * process.c (make_process): Omit redundant initialization.
2638 * terminal.c (create_terminal): Likewise.
2639
42997f4d
DA
26402012-06-26 Dmitry Antipov <dmantipov@yandex.ru>
2641
2642 * term.c (delete_tty): Remove redundant call to memset.
2643
1130ecfc
DA
26442012-06-26 Dmitry Antipov <dmantipov@yandex.ru>
2645
2646 * alloc.c: Remove build_string.
2647 * lisp.h: Define build_string as static inline. This provides
2648 a better opportunity to optimize away calls to strlen when the
2649 function is called with compile-time constant argument.
2650 * image.c (imagemagick_error): Convert to build_string.
2651 * w32proc.c (sys_spawnve): Likewise.
2652 * xterm.c (x_term_init): Likewise.
2653
cf38a720
PE
26542012-06-26 Paul Eggert <eggert@cs.ucla.edu>
2655
99027bdd
PE
2656 Use sprintf return value instead of invoking strlen on result.
2657 In the old days this wasn't portable, since some sprintf
2658 implementations returned char *. But they died out years ago and
2659 Emacs already assumes sprintf returns int.
2660 Similarly for float_to_string.
2661 This patch speeds up (number-to-string 1000) by 3% on Fedora 15 x86-64.
2662 * ccl.c (ccl_driver):
2663 * character.c (string_escape_byte8):
2664 * data.c (Fnumber_to_string):
2665 * doprnt.c (doprnt):
2666 * print.c (print_object):
2667 * xdisp.c (message_dolog):
2668 * xfns.c (syms_of_xfns):
2669 Use sprintf or float_to_string result to avoid need to call strlen.
2670 * data.c (Fnumber_to_string):
2671 Use make_unibyte_string, since the string must be ASCII.
2672 * lisp.h, print.c (float_to_string): Now returns int length.
2673 * term.c (produce_glyphless_glyph):
2674 Use sprintf result rather than recomputing it.
2675
cf38a720
PE
2676 Clean out last vestiges of the old HAVE_CONFIG_H stuff.
2677 * Makefile.in (ALL_CFLAGS):
2678 * makefile.w32-in (LOCAL_FLAGS): Remove -DHAVE_CONFIG_H.
2679 * gmalloc.c, regex.c: Include <config.h> unconditionally.
2680
3511c784
DA
26812012-06-25 Dmitry Antipov <dmantipov@yandex.ru>
2682
0a08eb21 2683 * dispextern.h (xstrcasecmp): Define to library function
3511c784
DA
2684 strcasecmp if available.
2685 * xfaces.c: Do not use xstrcasecmp if strcasecmp is available.
2686
fb7da12e
AS
26872012-06-25 Andreas Schwab <schwab@linux-m68k.org>
2688
2689 * keyboard.c (menu_bar_items, menu_bar_item, read_key_sequence):
2690 Avoid comma operator.
2691 * menu.c (push_submenu_start, push_submenu_end)
2692 (push_left_right_boundary, push_menu_pane): Likewise.
2693 * msdos.c (dos_rawgetc): Likewise.
2694
afa2ffd8
DA
26952012-06-25 Dmitry Antipov <dmantipov@yandex.ru>
2696
2697 * xfns.c (xic_create_fontsetname): Remove redundant calls
2698 to memset.
2699
b3b4476b
PE
27002012-06-25 Paul Eggert <eggert@cs.ucla.edu>
2701
4495ff38
PE
2702 * gtkutil.c (get_utf8_string): Remove redundant assignment.
2703 sprintf already null-terminates its output.
2704
b3b4476b
PE
2705 * xfns.c (x_window): Remove redundant cast.
2706
b00876c9
DA
27072012-06-25 Dmitry Antipov <dmantipov@yandex.ru>
2708
2709 * xmenu.c (xmenu_show, xdialog_show): Explicit cast from
2710 `const char *' to `char *' to avoid compiler warning.
2711
d188e26b
PE
27122012-06-24 Paul Eggert <eggert@cs.ucla.edu>
2713
885d1d74
PE
2714 * xterm.c (x_term_init): Build proper-sized _XSETTINGS_Snnn string
2715 instead of truncating it to 63 (admittedly a generous limit).
2716
d188e26b
PE
2717 * process.c: Fix spelling and caps in comments.
2718
e2f560b1
DN
27192012-06-24 Dan Nicolaescu <dann@ics.uci.edu>
2720
e86db54b 2721 * emacs.c (setpgrp): Remove definition, unused.
e2f560b1
DN
2722 * sysdep.c (setpgrp): Remove definition, not used in this file.
2723
7583a3a1
JB
27242012-06-24 Juanma Barranquero <lekktu@gmail.com>
2725
2726 * makefile.w32-in: Update dependencies.
2727
696056c2
EZ
27282012-06-24 Eli Zaretskii <eliz@gnu.org>
2729
2730 * makefile.w32-in (TIMESPEC_H): Remove nt/inc/sys/time.h.
2731 (SYSTIME_H): Add nt/inc/sys/time.h.
2732
2733 * systime.h [WINDOWSNT]: Include sys/time.h.
2734
2735 * s/ms-w32.h (struct timespec): Definition moved from
2736 nt/inc/sys/time.h. Suggested by Paul Eggert <eggert@cs.ucla.edu>.
2737
845ca893
PE
27382012-06-24 Paul Eggert <eggert@cs.ucla.edu>
2739
2740 Switch from NO_RETURN to C11's _Noreturn (Bug#11750).
2741 * buffer.h (buffer_slot_type_mismatch):
2742 * data.c (arith_error) [!FORWARD_SIGNAL_TO_MAIN_THREAD]:
2743 * eval.c (unwind_to_catch):
2744 * image.c (my_png_error, my_error_exit):
2745 * keyboard.c (quit_throw_to_read_char, user_error)
2746 (Fexit_recursive_edit, Fabort_recursive_edit):
2747 * lisp.h (die, args_out_of_range, args_out_of_range_3)
2748 (wrong_type_argument, buffer_overflow, __executable_start)
2749 (memory_full, buffer_memory_full, string_overflow, Fthrow)
2750 (xsignal, xsignal0, xsignal1, xsignal2, xsignal3, signal_error)
2751 (error, verror, nsberror, report_file_error, Ftop_level, Fkill_emacs)
2752 (fatal):
2753 (child_setup) [!DOS_NT]:
2754 * lread.c (end_of_file_error, invalid_syntax):
2755 * process.c (send_process_trap) [!FORWARD_SIGNAL_TO_MAIN_THREAD]:
2756 * puresize.h (pure_write_error):
2757 * search.c (matcher_overflow):
2758 * sound.c (sound_perror, alsa_sound_perror):
2759 * sysdep.c, syssignal.h (croak):
2760 * term.c (maybe_fatal, vfatal):
2761 * textprop.c (text_read_only):
2762 * undo.c (user_error):
2763 * unexmacosx.c (unexec_error):
2764 * xterm.c (x_ins_del_lines, x_delete_glyphs):
2765 Use _Noreturn rather than NO_RETURN.
2766 No need for separate decl merely because of _Noreturn.
2767 * sound.c (sound_warning, parse_sound):
2768 Remove unnecessary forward decls.
2769
f1dd8073
PE
27702012-06-24 Paul Eggert <eggert@cs.ucla.edu>
2771
2772 Fix bug when time_t is unsigned and as wide as intmax_t (Bug#9000).
2773 * lisp.h (WAIT_READING_MAX): New macro.
2774 * dispnew.c (Fsleep_for, sit_for):
2775 * keyboard.c (kbd_buffer_get_event):
2776 * process.c (Faccept_process_output):
2777 Use it to avoid bogus compiler warnings with obsolescent GCC versions.
2778 This improves on the previous patch, which introduced a bug
2779 when time_t is unsigned and as wide as intmax_t.
2780 See <http://bugs.gnu.org/9000#51>.
2781
b82c1755
EZ
27822012-06-23 Eli Zaretskii <eliz@gnu.org>
2783
2784 * dispnew.c (sit_for, Fsleep_for):
2785 * keyboard.c (kbd_buffer_get_event):
2786 * process.c (Faccept_process_output): Avoid compiler warnings when
2787 comparing a 32-bit time_t with a 64-bit INTMAX_MAX.
2788
ca300656
JB
27892012-06-23 Juanma Barranquero <lekktu@gmail.com>
2790
049ec95b
JB
2791 * makefile.w32-in: Update dependencies.
2792
ca300656
JB
2793 * w32.c (ltime): Add return type and declare static.
2794 (w32_get_internal_run_time): Remove usused variable `time_100ns'.
2795
db7b8d06
PE
27962012-06-23 Paul Eggert <eggert@cs.ucla.edu>
2797
2798 * sysdep.c [__FreeBSD__]: Fix more recently-introduced typos.
2799 Privately reported by Herbert J. Skuhra.
2800 (make_lisp_timeval) [__FreeBSD__]: Rename from TIMELIST.
2801 All uses changed.
2802 (system_process_attributes) [__FreeBSD__]: Invoke make_lisp_time,
2803 not make_lisp_timeval, when the argument is of type EMACS_TIME.
2804
0bd8297f
EZ
28052012-06-23 Eli Zaretskii <eliz@gnu.org>
2806
96512555
EZ
2807 * w32proc.c (Fw32_get_locale_info): Fix an off-by-one error in
2808 last argument of make_unibyte_string.
2809
0bd8297f
EZ
2810 * keyboard.c (kbd_buffer_get_event): Include the codepage and the
2811 language ID in the event parameters.
2812
2813 * w32term.c (w32_read_socket): Put the new keyboard codepage into
2814 event.code, not the obscure "character set ID".
2815
63def6b6
CY
28162012-06-23 Chong Yidong <cyd@gnu.org>
2817
2818 * xmenu.c (x_menu_wait_for_event): Adapt GTK3 to new xg_select.
2819
e8a02204
EZ
28202012-06-23 Eli Zaretskii <eliz@gnu.org>
2821
388cdec0
EZ
2822 Fix the MS-Windows build broken by 2012-06-22T21:17:42Z!eggert@cs.ucla.edu.
2823 * w32.c (fdutimens): New function.
2824
2825 * w32proc.c (sys_select): Adapt to change in the EMACS_TIME type.
2826
2827 * s/ms-w32.h (pselect): Redirect to sys_select.
2828
2829 * sysselect.h [WINDOWSNT]: Don't include sys/select.h.
2830
e8a02204
EZ
2831 * ralloc.c (r_alloc_inhibit_buffer_relocation): Fix stupid thinko
2832 in the logic of incrementing and decrementing the value of
2833 use_relocatable_buffers.
2834
d054f3fb
PE
28352012-06-23 Paul Eggert <eggert@cs.ucla.edu>
2836
2837 * sysdep.c [__FreeBSD__]: Fix recently-introduced typos.
2838 Privately reported by Herbert J. Skuhra.
2839 [__FreeBSD__]: Remove "*/" typo after "#include".
2840 (timeval_to_EMACS_TIME) [__FreeBSD__]: New static function.
2841 (TIMEVAL) [__FreeBSD__]: Now a static function rather than a macro.
2842 (TIMEVAL, system_process_attributes) [__FreeBSD__]:
2843 Don't assume EMACS_TIME and struct timeval are the same type.
2844
d35af63c
PE
28452012-06-22 Paul Eggert <eggert@cs.ucla.edu>
2846
2847 Support higher-resolution time stamps (Bug#9000).
2848 The time stamps are only nanosecond-resolution at the C level,
2849 since that's the best that any real-world system supports now.
2850 But they are picosecond-resolution at the Lisp level, as that's
2851 easy, and leaves room for future OS improvements.
2852
2853 * Makefile.in (LIB_CLOCK_GETTIME): New macro.
2854 (LIBES): Use it.
2855
2856 * alloc.c (Fgarbage_collect): Port to higher-res time stamps.
2857 Don't get current time unless it's needed.
2858
2859 * atimer.c: Include <sys/time.h> unconditionally, since gnulib
2860 now provides it if it's absent.
2861 (start_atimer): Port to higher-res time stamps.
2862 Check for time stamp overflow. Don't get current time more
2863 often than is needed.
2864
2865 * buffer.h (struct buffer): Buffer modtime now has high resolution.
2866 Include systime.h, not time.h.
2867 (NONEXISTENT_MODTIME_NSECS, UNKNOWN_MODTIME_NSECS): New macros.
2868
2869 * dired.c: Include stat-time.h.
2870 (Ffile-attributes): File times now have higher resolution.
2871
2872 * dispextern.h [HAVE_WINDOW_SYSTEM]: Include systime.h.
2873 (struct image): Timestamp now has higher resolution.
2874
2875 * dispnew.c (PERIODIC_PREEMPTION_CHECKING): Remove, as Emacs always
2876 has at least microseconds now. All uses removed.
2877 (update_frame, update_single_window, update_window, update_frame_1)
2878 (Fsleep_for, sit_for): Port to higher-resolution time stamps.
2879
2880 * editfns.c (time_overflow): Now extern.
2881 (Fcurrent_time, Fget_internal_run_time, make_time, lisp_time_argument)
2882 (float-time, Fformat_time_string, Fcurrent_time_string)
2883 (Fcurrent_time_zone): Accept and generate higher-resolution
2884 time stamps.
2885 (make_time_tail, make_lisp_time, dissassemble_lisp_time)
2886 (decode_time_components, lisp_seconds_argument): New functions.
2887 (make_time): Now static.
2888 (lisp_time_argument): Now returns EMACS_TIME. New arg ppsec.
2889 Report an error if the time is invalid, rather than having the caller
2890 do that.
2891
2892 * fileio.c: Include <stat-time.h>
2893 (Fcopy_file): Copy higher-resolution time stamps.
2894 Prefer to set the time stamp via a file descriptor if that works.
2895 (Fset_file_times, Finsert_file_contents, Fwrite_region)
2896 (Fverify_visited_file_modtime, Fclear_visited_file_modtime)
2897 (Fvisited_file_modtime, Fset_visited_file_modtime):
2898 Support higher-resolution time stamps.
2899
2900 * fns.c (Frandom): Use nanoseconds, not microseconds, for seed.
2901
2902 * gtkutil.c (xg_maybe_add_timer): Port to higher-res time stamps.
2903
2904 * image.c (prepare_image_for_display, clear_image_cache)
2905 (lookup_image): Port to higer-resolution time stamps.
2906
2907 * keyboard.c (start_polling, bind_polling_period):
2908 Check for time stamp overflow.
2909 (read_char, kbd_buffer_get_event, timer_start_idle)
2910 (timer_stop_idle, timer_resume_idle, timer_check_2, timer_check)
2911 (Fcurrent_idle_time, init_keyboard, set_waiting_for_input):
2912 Port to higher-resolution time stamps. Do not assume time_t is signed.
2913 (decode_timer): New function. Timers are now vectors of length 9,
2914 not 8, to accommodate the picosecond component.
2915 (timer_check_2): Use it.
2916
2917 * nsterm.m (select_timeout, timeval_subtract): Remove.
2918 (ns_timeout): Use Emacs's facilities for time stamp arithmetic,
2919 as they're a bit more accurate and handle overflow better.
2920 (ns_select): Change prototype to be compatible with pselect.
2921 (ns_select, ns_term_shutdown): Port to ns-resolution time stamps.
2922 * nsterm.h (ns_select): Adjust prototype.
2923
2924 * msdos.c (EMACS_TIME_ZERO_OR_NEG_P): Remove, as it assumes
2925 us-resolution time stamps.
2926 (sys_select): Use the new EMACS_TIME_SIGN macro instead.
2927
2928 * lread.c (read_filtered_event): Port to ns-resolution time stamps.
2929
2930 * lisp.h (time_overflow): New decl.
2931 (wait_reading_process_output): First arg is now intmax_t, not int,
2932 to accommodate larger waits.
2933
2934 * process.h (struct Lisp_Process.read_output_delay):
2935 Now counts nanoseconds, not microseconds.
2936 * process.c (ADAPTIVE_READ_BUFFERING): Don't worry about
2937 EMACS_HAS_USECS.
2938 (READ_OUTPUT_DELAY_INCREMENT, Faccept_process_output)
2939 (wait_reading_process_output):
2940 Port to ns-resolution time stamps.
2941 (Faccept_process_output, wait_reading_process_output):
2942 Check for time stamp overflow. Do not assume time_t is signed.
2943 (select_wrapper): Remove; we now use pselect.
2944 (Fprocess_attributes): Now generates ns-resolution time stamps.
2945
2946 * sysdep.c: Include utimens.h. Don't include utime.h
2947 or worry about struct utimbuf; gnulib does that for us now.
2948 (gettimeofday): Remove; gnulib provides a substitute.
2949 (make_timeval): New function.
2950 (set_file_times): Now sets ns-resolution time stamps.
2951 New arg FD; all uses changed.
2952 (time_from_jiffies, ltime_from_jiffies, get_up_time)
2953 (system_process_attributes):
2954 Now returns ns-resolution time stamp. All uses changed.
2955 Check for time stamp overflow.
2956
2957 * sysselect.h: Don't depend on HAVE_SYS_SELECT_H; gnulib
2958 provides a substitute now.
2959
2960 * systime.h: Include timespec.h rather than sys/time.h and time.h,
2961 since it guarantees struct timespec.
2962 (EMACS_TIME): Now struct timespec, so that we can support
2963 ns-resolution time stamps.
2964 (EMACS_TIME_RESOLUTION, LOG10_EMACS_TIME_RESOLUTION): New macros.
2965 (EMACS_HAS_USECS): Remove; Emacs always has sub-second time stamps now.
2966 (EMACS_USECS): Remove.
2967 (EMACS_SET_USECS): The underlying time stamp now has ns resolution,
2968 so multiply the arg by 1000 before storing it.
2969 (EMACS_NSECS, EMACS_SECS_ADDR, EMACS_SET_NSECS, EMACS_SET_SECS_NSECS):
2970 New macros.
2971 (EMACS_GET_TIME, EMACS_ADD_TIME, EMACS_SUB_TIME):
2972 Port to ns-resolution time stamps.
2973 (EMACS_TIME_NEG_P): Remove; replaced by....
2974 (EMACS_TIME_SIGN): New macro.
2975 (EMACS_SET_INVALID_TIME, EMACS_TIME_VALID_P)
2976 (EMACS_TIME_FROM_DOUBLE, EMACS_TIME_TO_DOUBLE): New macros.
2977 (set_file_times, make_time, lisp_time_argument): Adjust signature.
2978 (make_timeval, make_lisp_time, decode_time_components): New decls.
2979 (EMACS_TIME_CMP): Remove; no longer used. Plus, it was buggy, in
2980 that it mishandled time_t overflow. You can't compare by subtracting!
2981 (EMACS_TIME_EQ, EMACS_TIME_NE, EMACS_TIME_GT, EMACS_TIME_GE)
2982 (EMACS_TIME_LT, EMACS_TIME_LE): Rewrite in terms of timespec_cmp.
2983
2984 * term.c: Include <sys/time.h>.
2985 (timeval_to_Time): New function, for proper overflow wraparound.
2986 (term_mouse_position, term_mouse_click): Use it.
2987
2988 * undo.c (record_first_change): Support higher-resolution time stamps
2989 in the undo buffer.
2990 (Fprimitive_undo): Use them when restoring time stamps.
2991
2992 * w32.c (ltime, U64_TO_LISP_TIME, process_times, emacs_gnutls_pull)
2993 (w32_get_internal_run_time):
2994 Port to higher-resolution Emacs time stamps.
2995 (ltime): Now accepts single 64-bit integer, as that's more convenient
2996 for callers.
2997
2998 * xdisp.c (start_hourglass): Port to ns-resolution time stamps.
2999
3000 * xgselect.c, xgselect.h (xg_select): Add sigmask argument,
3001 for compatibility with pselect. Support ns-resolution time stamps.
3002
3003 * xmenu.c (x_menu_wait_for_event): Support ns-resolution time stamps.
3004
3005 * xselect.c (wait_for_property_change, x_get_foreign_selection):
3006 Check for time stamp overflow, and support ns-resolution time stamps.
3007
3008 * xterm.c: Don't include sys/time.h; gnulib does that for us now.
3009 Don't worry about whether HAVE_TIMEVAL and HAVE_SELECT are set.
3010 (timeval_subtract): Remove; no longer needed.
3011 (XTflash, XTring_bell, x_wait_for_event):
3012 Port to ns-resolution time stamps. Don't assume time_t is signed.
3013
b6a92dfe
CY
30142012-06-22 Chong Yidong <cyd@gnu.org>
3015
3016 * xdisp.c (x_consider_frame_title): Revert last change.
3017
d251c37c
EZ
30182012-06-22 Eli Zaretskii <eliz@gnu.org>
3019
3020 * alloc.c (NSTATICS): Enlarge to 0x650. Otherwise, Emacs compiled
3021 with -DENABLE_CHECKING -DXASSERTS -DGLYPH_DEBUG=1 -DBYTE_CODE_METER
3022 aborts in staticpro during startup. (Without -DBYTE_CODE_METER,
3023 staticidx goes up to 1597 out of 1600 = 0x640.)
3024
f10deafb
PE
30252012-06-20 Paul Eggert <eggert@cs.ucla.edu>
3026
3027 * fileio.c (Fdefault_file_modes): Block input while fiddling with umask.
3028 Otherwise, the umask might be mistakenly 0 while handling input signals.
3029
ec6de1e2
SM
30302012-06-19 Stefan Monnier <monnier@iro.umontreal.ca>
3031
3032 * minibuf.c (Fread_string): Bind minibuffer-completion-table.
3033
28be1ada
DA
30342012-06-19 Dmitry Antipov <dmantipov@yandex.ru>
3035
3036 * alloc.c, bytecode.c, ccl.c, coding.c, composite.c, data.c, dosfns.c:
3037 * font.c, image.c, keyboard.c, lread.c, menu.c, minibuf.c, msdos.c:
3038 * print.c, syntax.c, window.c, xmenu.c, xselect.c: Replace direct
3039 access to `contents' member of Lisp_Vector objects with AREF and ASET
3040 where appropriate.
3041
c6bf3022
CY
30422012-06-19 Chong Yidong <cyd@gnu.org>
3043
3044 * frame.c (delete_frame): When selecting a frame on a different
3045 text terminal, do not alter the terminal's top-frame.
3046
3047 * xdisp.c (format_mode_line_unwind_data): Record the target
3048 frame's selected window and its terminal's top-frame.
3049 (unwind_format_mode_line): Restore them.
3050 (x_consider_frame_title, display_mode_line, Fformat_mode_line):
3051 Callers changed.
3052 (x_consider_frame_title): Do not condition on HAVE_WINDOW_SYSTEM,
3053 since tty frames can be explicitly named.
3054 (prepare_menu_bars): Likewise.
3055
3056 * term.c (Ftty_top_frame): New function.
3057
defd4196
PE
30582012-06-18 Paul Eggert <eggert@cs.ucla.edu>
3059
3060 Port byte-code-meter to modern targets.
3061 * bytecode.c (METER_CODE) [BYTE_CODE_METER]: Don't assume
3062 !CHECK_LISP_OBJECT_TYPE && !USE_LSB_TAG. Problem with
8b5257e1 3063 CHECK_LISP_OBJECT_TYPE reported by Dmitry Antipov in
defd4196
PE
3064 <http://lists.gnu.org/archive/html/emacs-devel/2012-06/msg00282.html>.
3065 (METER_1, METER_2): Simplify.
3066
1053a871
SM
30672012-06-18 Stefan Monnier <monnier@iro.umontreal.ca>
3068
3069 * data.c (Fdefalias): Return `symbol' (bug#11686).
3070
b7e8d081
MR
30712012-06-18 Martin Rudalics <rudalics@gmx.at>
3072
3073 * buffer.c (Fkill_buffer): Don't throw an error when the buffer
1053a871
SM
3074 gets killed during executing of this function (Bug#11665).
3075 Try to always return Qt when the buffer has been actually killed.
b7e8d081
MR
3076 (Vkill_buffer_query_functions): In doc-string say that functions
3077 run by this hook should not change the current buffer.
3078
7ea2b339
PE
30792012-06-18 Paul Eggert <eggert@cs.ucla.edu>
3080
3081 Fix recently-introduced process.c problems found by static checking.
3082 * process.c (write_queue_push, write_queue_pop, send_process):
3083 Use ptrdiff_t, not int or EMACS_INT, for buffer lengths and offsets.
3084 (write_queue_pop): Fix pointer signedness problem.
3085 (send_process): Remove unused local.
3086
96a313a1
CY
30872012-06-17 Chong Yidong <cyd@gnu.org>
3088
3089 * xdisp.c (redisplay_internal): No need to redisplay terminal
3090 frames that are not on top.
3091
20ca2e94
TN
30922012-06-17 Troels Nielsen <bn.troels@gmail.com>
3093
3094 * process.c (make_process): Initialize write_queue.
3095 (write_queue_push, write_queue_pop): New functions.
3096 (send_process): Use them to maintain correct ordering of process
3097 writes (Bug#10815).
3098
9a900ca9
PE
30992012-06-17 Paul Eggert <eggert@cs.ucla.edu>
3100
310fbfa8
PE
3101 * lisp.h (eassert): Assume C89 or later.
3102 This removes the need for CHECK.
3103 (CHECK): Remove. Its comments about always evaluating its
3104 argument were confusing, as 'eassert' typically does not evaluate
3105 its argument.
3106
27bb1ca4
PE
3107 * coding.c (produce_chars): Use ptrdiff_t, not int.
3108
9a900ca9
PE
3109 * xterm.c (x_draw_underwave): Check for integer overflow.
3110 This pacifies gcc 4.7.0 -Wunsafe-loop-optimizations on x86-64.
3111
41b7f8bc 31122012-06-17 Jan Djärv <jan.h.d@swipnet.se>
50a93863
JD
3113
3114 * nsterm.m (x_free_frame_resources): Move xfree so freed memory isn't
3115 referenced (Bug#11583).
3116
9b0e3eba
AA
31172012-06-16 Aurelien Aptel <aurelien.aptel@gmail.com>
3118
3119 Implement wave-style variant of underlining.
3120 * dispextern.h (face_underline_type): New enum.
3121 (face): Add field for underline type.
3122 * nsterm.m (ns_draw_underwave): New function.
3123 (ns_draw_text_decoration): Use it.
3124 * w32term.c (w32_restore_glyph_string_clip, w32_draw_underwave):
3125 New functions.
3126 (x_draw_glyph_string): Use them.
3127 * xfaces.c (Qline, Qwave): New Lisp objects.
3128 (check_lface_attrs, merge_face_ref)
1053a871
SM
3129 (Finternal_set_lisp_face_attribute, realize_x_face):
3130 Handle wave-style underline face attributes.
9b0e3eba
AA
3131 * xterm.c (x_draw_underwave): New function.
3132 (x_draw_glyph_string): Use it.
3133
0fb52f11
JB
31342012-06-16 Juanma Barranquero <lekktu@gmail.com>
3135
3136 * makefile.w32-in ($(BLD)/emacs.$(O), $(BLD)/fringe.$(O))
3137 ($(BLD)/xml.$(O), $(BLD)/intervals.$(O), $(BLD)/macros.$(O))
3138 ($(BLD)/minibuf.$(O), $(BLD)/regex.$(O), $(BLD)/region-cache.$(O))
3139 ($(BLD)/textprop.$(O), $(BLD)/undo.$(O), $(BLD)/window.$(O))
3140 ($(BLD)/w32select.$(O)): Update dependencies.
3141
e5560ff7
AS
31422012-06-16 Andreas Schwab <schwab@linux-m68k.org>
3143
3144 * buffer.h (FETCH_MULTIBYTE_CHAR): Define as inline.
3145 (BUF_FETCH_MULTIBYTE_CHAR): Likewise.
3146 * character.c (_fetch_multibyte_char_p): Remove.
3147 * alloc.c: Include "character.h" before "buffer.h".
3148 * bidi.c: Likewise.
3149 * buffer.c: Likewise.
3150 * bytecode.c: Likewise.
3151 * callint.c: Likewise.
3152 * callproc.c: Likewise.
3153 * casefiddle.c: Likewise.
3154 * casetab.c: Likewise.
3155 * category.c: Likewise.
3156 * cmds.c: Likewise.
3157 * coding.c: Likewise.
3158 * composite.c: Likewise.
3159 * dired.c: Likewise.
3160 * dispnew.c: Likewise.
3161 * doc.c: Likewise.
3162 * dosfns.c: Likewise.
3163 * editfns.c: Likewise.
3164 * emacs.c: Likewise.
3165 * fileio.c: Likewise.
3166 * filelock.c: Likewise.
3167 * font.c: Likewise.
3168 * fontset.c: Likewise.
3169 * fringe.c: Likewise.
3170 * indent.c: Likewise.
3171 * insdel.c: Likewise.
3172 * intervals.c: Likewise.
3173 * keyboard.c: Likewise.
3174 * keymap.c: Likewise.
3175 * lread.c: Likewise.
3176 * macros.c: Likewise.
3177 * marker.c: Likewise.
3178 * minibuf.c: Likewise.
3179 * nsfns.m: Likewise.
3180 * nsmenu.m: Likewise.
3181 * print.c: Likewise.
3182 * process.c: Likewise.
3183 * regex.c: Likewise.
3184 * region-cache.c: Likewise.
3185 * search.c: Likewise.
3186 * syntax.c: Likewise.
3187 * term.c: Likewise.
3188 * textprop.c: Likewise.
3189 * undo.c: Likewise.
3190 * unexsol.c: Likewise.
3191 * w16select.c: Likewise.
3192 * w32fns.c: Likewise.
3193 * w32menu.c: Likewise.
3194 * window.c: Likewise.
3195 * xdisp.c: Likewise.
3196 * xfns.c: Likewise.
3197 * xmenu.c: Likewise.
3198 * xml.c: Likewise.
3199 * xselect.c: Likewise.
3200
2f07e6af
EZ
32012012-06-16 Eli Zaretskii <eliz@gnu.org>
3202
1053a871
SM
3203 * xdisp.c (set_cursor_from_row): Don't dereference glyphs_end.
3204 If all the glyphs of the glyph row came from strings, and we have no
2f07e6af 3205 cursor positioning clues, put the cursor on the first glyph of the
1097afe4
EZ
3206 row.
3207 (handle_face_prop): Use chunk-relative overlay string index when
3208 indexing into it->string_overlays array. (Bug#11653)
946fdb73
EZ
3209 (set_cursor_from_row): Use the leftmost glyph as GLYPH_BEFORE, not
3210 the rightmost. (Bug#11720)
2f07e6af 3211
29b83cec
AS
32122012-06-16 Andreas Schwab <schwab@linux-m68k.org>
3213
3214 * category.h (CHAR_HAS_CATEGORY): Define as inline.
3215 (CATEGORY_MEMBER): Enforce 1/0 value.
3216 * category.c (_temp_category_set): Remove.
3217
4c5501e9
EZ
32182012-06-16 Eli Zaretskii <eliz@gnu.org>
3219
3220 * window.c (Fdelete_other_windows_internal)
3221 (Fdelete_window_internal): Don't access frame's mouse highlight
3222 info of the initial frame. (Bug#11677)
3223
2b570124
PE
32242012-06-14 Paul Eggert <eggert@cs.ucla.edu>
3225
e93864f9
PE
3226 * .gdbinit (xgetint): Fix recently-introduced paren typo.
3227 Assume USE_2_TAGS_FOR_INTS.
3228 (xreload): Adjust $tagmask width to match recent lisp.h change.
3229
2b570124
PE
3230 Simplify lisp.h in minor ways that should not affect code.
3231 * lisp.h (USE_2_TAGS_FOR_INTS): Remove, as it was always defined.
3232 (LISP_INT_TAG, case_Lisp_Int, LISP_STRING_TAG, LISP_INT_TAG_P)
3233 (LISP_INT1_TAG, enum Lisp_Type, XINT, XUINT, make_number):
3234 Simplify under the assumption that USE_2_TAGS_FOR_INTS is defined.
3235 (INTTYPEBITS): New macro, for clarity.
3236 (INTMASK, MOST_POSITIVE_FIXNUM): Use it.
1053a871
SM
3237 (LISP_INT1_TAG, LISP_STRING_TAG, LISP_INT_TAG_P):
3238 Simplify now that USE_LSB_TAG is always defined.
2b570124
PE
3239 (TYPEMASK, XINT) [USE_LSB_TAG]: Remove unnecessary cast.
3240 (make_number) [!USE_LSB_TAG]: Use INTMASK; that's simpler.
3241
81755f69
JB
32422012-06-13 Juanma Barranquero <lekktu@gmail.com>
3243
3244 * makefile.w32-in ($(BLD)/data.$(O)): Update dependencies.
3245
16192a57
GM
32462012-06-13 Glenn Morris <rgm@gnu.org>
3247
3248 * s/bsd-common.h (BSD4_3):
3249 * s/usg5-4-common.h (USG5_4): No longer define; unused.
3250
646b5f55
AS
32512012-06-13 Andreas Schwab <schwab@linux-m68k.org>
3252
3253 * lisp.h (Lisp_Object) [CHECK_LISP_OBJECT_TYPE]: Define as struct
3254 instead of union.
3255 (XLI, XIL): Define.
1053a871
SM
3256 (XHASH, XTYPE, XINT, XUINT, make_number, XSET, XPNTR, XUNTAG):
3257 Use them.
3258 * emacs.c (gdb_use_struct): Rename from gdb_use_union.
646b5f55 3259 * .gdbinit: Check gdb_use_struct instead of gdb_use_union.
1053a871 3260 * alloc.c (widen_to_Lisp_Object): Remove.
646b5f55
AS
3261 (mark_memory): Use XIL instead of widen_to_Lisp_Object.
3262 * frame.c (delete_frame): Remove outdated comment.
3263 * w32fns.c (Fw32_register_hot_key): Use XLI instead of checking
3264 USE_LISP_UNION_TYPE.
3265 (Fw32_unregister_hot_key): Likewise.
3266 (Fw32_toggle_lock_key): Likewise.
3267 * w32menu.c (add_menu_item): Likewise.
3268 (w32_menu_display_help): Use XIL instead of checking
3269 USE_LISP_UNION_TYPE.
3270 * w32heap.c (allocate_heap): Don't check USE_LISP_UNION_TYPE.
3271 (init_heap): Likewise.
3272 * w32term.c (w32_read_socket): Update comment.
3273
1d3823c9
GM
32742012-06-13 Glenn Morris <rgm@gnu.org>
3275
c62ff706
GM
3276 * s/usg5-4-common.h, src/s/unixware.h:
3277 Remove define/undef of HAVE_SYSV_SIGPAUSE (not used since 2010-05-04).
3278
1d3823c9
GM
3279 * s/gnu.h (POSIX_SIGNALS): Remove (not used since 2010-05-04).
3280
bfe3e0a2
PE
32812012-06-13 Paul Eggert <eggert@cs.ucla.edu>
3282
3283 USE_LISP_UNION_TYPE + USE_LSB_TAG cleanup (Bug#11604)
3284 * alloc.c (make_number) [!defined make_number]:
3285 Remove, as lisp.h always defines this now.
3286 (mark_maybe_pointer): Simplify since USE_LSB_TAG is always defined now.
3287 (roundup_size): Verify that it is a power of 2.
3288 * data.c (Fmake_variable_buffer_local, Fmake_local_variable):
3289 * ftfont.c (ftfont_driver): Use LISP_INITIALLY_ZERO.
3290 * lisp.h (USE_LSB_TAG): Allow the builder to compile with
3291 -DUSE_LSB_TAG=0, to override the automatically-selected default.
3292 USE_LSB_TAG now is always defined to be either 0 or 1.
3293 All uses changed.
3294 (union Lisp_Object): Don't worry about WORDS_BIGENDIAN; the
3295 code works fine either way, and efficiency is not a concern here,
3296 as the union type is for debugging, not for production.
3297 (LISP_MAKE_RVALUE, make_number) [USE_LISP_UNION_TYPE]:
3298 Use an inline function on all platforms when using the union type,
3299 since this is simpler and 'static inline' can be used portably
3300 within Emacs now.
3301 (LISP_INITIALLY_ZERO): New macro.
3302 (XFASTINT, XSETFASTINT) [USE_LISP_UNION_TYPE]: Remove.
3303 (XSET) [USE_LISP_UNION_TYPE]: Don't overparenthesize.
3304
45fa9c0f
GM
33052012-06-12 Glenn Morris <rgm@gnu.org>
3306
b4492cba
GM
3307 * s/gnu-kfreebsd.h, s/hpux11.h, s/openbsd.h, s/sol2-10.h: Remove files.
3308
3309 * s/gnu-linux.h (HAVE_PROCFS): Move to configure.
0d369729 3310
45fa9c0f
GM
3311 * s/hpux10-20.h, s/openbsd.h, s/usg5-4-common.h:
3312 Move BROKEN_SIGIO to configure.
3313
3314 * s/bsd-common.h, s/darwin.h, s/gnu-kfreebsd.h, s/hpux10-20.h:
3315 Move NO_TERMIO to configure.
3316
0e25d334
CY
33172012-06-12 Chong Yidong <cyd@gnu.org>
3318
3319 * image.c (imagemagick_load_image): Use MagickFlattenImage if
3320 MagickMergeImageLayers is undefined. Use pixel pusher loop if
3321 MagickExportImagePixels is undefined.
3322
43682bb6
PE
33232012-06-12 Paul Eggert <eggert@cs.ucla.edu>
3324
3325 * image.c (imagemagick_load_image): Remove unused label.
3326
a9be7d2b
GM
33272012-06-11 Glenn Morris <rgm@gnu.org>
3328
3329 * s/aix4-2.h, s/bsd-common.h, s/cygwin.h, s/darwin.h:
3330 * s/gnu-kfreebsd.h, s/gnu-linux.h, s/gnu.h, s/hpux10-20.h:
3331 * s/irix6-5.h, s/ms-w32.h, s/msdos.h, s/template.h:
3332 * s/usg5-4-common.h: Move SYSTEM_TYPE to configure.
3333
3017f87f
SM
33342012-06-11 Stefan Monnier <monnier@iro.umontreal.ca>
3335
3336 * alloc.c (make_byte_code): New function.
3337 (Fmake_byte_code): Use it. Don't purify here.
3338 * lread.c (read1): Use it as well to avoid extra allocation.
3339
1b9b4cf4
CY
33402012-06-11 Chong Yidong <cyd@gnu.org>
3341
3342 * image.c (imagemagick_load_image): Implement transparency.
3343
95988fcf
AS
33442012-06-10 Andreas Schwab <schwab@linux-m68k.org>
3345
3346 * regex.c (at_begline_loc_p): Also recognize `(?N:' and correctly
3347 account for preceding backslashes. (Bug#11663)
3348
cd4eb164
CY
33492012-06-09 Chong Yidong <cyd@gnu.org>
3350
3351 * term.c: Support italics in capable terminals (Bug#9652).
3352 (no_color_bit): Replace unused NC_BLINK with NC_ITALIC.
3353 (turn_on_face): Output using TS_enter_italic_mode if available.
3354 Don't handle unused blinking and alt-charset cases.
3355 (turn_off_face): Handle italic case; discard unused tty_blinking_p
3356 and tty_alt_charset_p cases.
3357 (tty_capable_p, init_tty): Support italics.
3358
3359 * termchar.h (struct tty_display_info): Add field for italics.
3360 Remove unused blink field.
3361
3362 * xfaces.c (tty_supports_face_attributes_p, realize_tty_face):
3363 Handle slant.
3364
3365 * dispextern.h: Replace unused TTY_CAP_BLINK with TTY_CAP_ITALIC.
3366 (struct face): Remove unused fields tty_dim_p, tty_blinking_p, and
3367 tty_alt_charset_p. Add tty_italic_p.
3368
ff88beb8
MA
33692012-06-09 Michael Albinus <michael.albinus@gmx.de>
3370
3371 * dbusbind.c (XD_BASIC_DBUS_TYPE): Use dbus_type_is_valid and
3372 dbus_type_is_basic if available.
3373 (xd_extract_signed, xd_extract_unsigned): Rename from
3374 extract_signed and extract_unsigned, respectively. Adapt callers.
3375
44286096
CY
33762012-06-09 Chong Yidong <cyd@gnu.org>
3377
1682701f
CY
3378 * xfaces.c (face_for_overlay_string): Handle face remapping (Bug#2066).
3379
44286096
CY
3380 * fringe.c (Fset_fringe_bitmap_face): Handle the noninteractive
3381 case (Bug#9752).
3382
d86feb17
PE
33832012-06-08 Paul Eggert <eggert@cs.ucla.edu>
3384
3385 * xdisp.c (vmessage): Treat frame message as multibyte.
3386 Without this change, (let ((§ 1)) (make-variable-buffer-local '§))
3387 would generate the diagnostic "Making \302\247 buffer-local while
3388 let-bound!".
3389
d5c20fe8
EZ
33902012-06-08 Eli Zaretskii <eliz@gnu.org>
3391
3392 * dispnew.c (showing_window_margins_p): Undo last change, which
3393 was done due to an inadvertent commit.
3394 (adjust_frame_glyphs_for_frame_redisplay): Do call
3395 showing_window_margins_p.
3396
513749ee
SM
33972012-06-08 Stefan Monnier <monnier@iro.umontreal.ca>
3398
3399 * eval.c (Fmake_var_non_special): New primitive.
3400 (syms_of_eval): Defsubr it.
3401 * lread.c (syms_of_lread): Mark `values' as lexically scoped.
3402
d4a8f5c1
JB
34032012-06-08 Juanma Barranquero <lekktu@gmail.com>
3404
3405 * dispnew.c (showing_window_margins_p): Wrap in #if 0 to prevent unused
3406 function warning (the only call is inside #if 0 since 2012-06-08T08:44:45Z!eliz@gnu.org).
3407
8bbbc977
EZ
34082012-06-08 Eli Zaretskii <eliz@gnu.org>
3409
3410 * alloc.c (allocate_vectorlike): Fix last change.
3411
f3372c87
DA
34122012-06-08 Dmitry Antipov <dmantipov@yandex.ru>
3413
3414 Block-based vector allocation of small vectors.
3415 * lisp.h (struct vectorlike_header): New field `nbytes',
3416 adjust comment accordingly.
3417 * alloc.c (enum mem_type): New type `MEM_TYPE_VECTOR_BLOCK'
3418 to denote vector blocks. Adjust users (live_vector_p,
3419 mark_maybe_pointer, valid_lisp_object_p) accordingly.
3420 (COMMON_MULTIPLE): Move outside #if USE_LSB_TAG.
3421 (VECTOR_BLOCK_SIZE, vroundup, VECTOR_BLOCK_BYTES),
3422 (VBLOCK_BYTES_MIN, VBLOCK_BYTES_MAX, VECTOR_MAX_FREE_LIST_INDEX),
3423 (VECTOR_FREE_LIST_FLAG, ADVANCE, VINDEX, SETUP_ON_FREE_LIST),
3424 (VECTOR_SIZE, VECTOR_IN_BLOCK): New macros.
3425 (roundup_size): New constant.
3426 (struct vector_block): New data type.
3427 (vector_blocks, vector_free_lists, zero_vector): New variables.
513749ee 3428 (all_vectors): Rename to `large_vectors'.
f3372c87
DA
3429 (allocate_vector_from_block, init_vectors, allocate_vector_from_block)
3430 (sweep_vectors): New functions.
3431 (allocate_vectorlike): Return `zero_vector' as the only vector of
3432 0 items. Allocate new vector from block if vector size is less than
3433 or equal to VBLOCK_BYTES_MAX.
3434 (Fgarbage_collect): Move all vector sweeping code to sweep_vectors.
3435 (init_alloc_once): Add call to init_vectors.
3436
4f18a4ed
SM
34372012-06-08 Stefan Monnier <monnier@iro.umontreal.ca>
3438
3439 * eval.c (Fmacroexpand): Stop if the macro returns the same form.
3440
86f158bc
PE
34412012-06-07 Paul Eggert <eggert@cs.ucla.edu>
3442
3443 * doprnt.c (doprnt): Truncate multibyte char correctly.
3444 Without this change, doprnt (buf, 2, "%s", FORMAT_END, AP)
3445 would mishandle a string argument "Xc" if X was a multibyte
3446 character of length 2: it would truncate after X's first byte
3447 rather than including all of X.
3448
c5cfcbe0
CY
34492012-06-06 Chong Yidong <cyd@gnu.org>
3450
3451 * buffer.c (word_wrap): Doc fix.
3452
c05cf390
PE
34532012-06-04 Paul Eggert <eggert@cs.ucla.edu>
3454
3455 * xdisp.c (note_mode_line_or_margin_highlight): Pacify gcc -Wall.
3456
0c3461de
GM
34572012-06-03 Glenn Morris <rgm@gnu.org>
3458
3459 * xdisp.c (tool-bar-style): Doc fix.
3460
c71232db
UM
34612012-06-03 Ulrich Müller <ulm@gentoo.org>
3462
3463 * Makefile.in (PAXCTL): Define.
3464 (temacs$(EXEEXT)): Disable memory randomization for the temacs
3465 binary via PaX flags if the paxctl utility is available.
3466 (emacs$(EXEEXT), bootstrap-emacs$(EXEEXT)):
3467 Restore PaX flags to their default. (Bug#11398)
3468
383f7350
CY
34692012-06-03 Chong Yidong <cyd@gnu.org>
3470
3471 * xdisp.c (decode_mode_spec_coding): Display a space for a unibyte
3472 buffer (Bug#11226).
3473
5f2c76c6
CY
34742012-06-03 Chong Yidong <cyd@gnu.org>
3475
3476 * xdisp.c (calc_pixel_width_or_height): Use Fbuffer_local_value.
3477 (note_mode_line_or_margin_highlight): If there is no help echo,
3478 use mode-line-default-help-echo. Handle the case where the mouse
3479 position is past the end of the mode line string.
3480
3481 * buffer.c (buffer_local_value_1): New function, split from
3482 Fbuffer_local_value; can return Qunbound.
3483 (Fbuffer_local_value): Use it.
3484 (Vmode_line_format): Docstring tweaks.
3485
773d47f6
PE
34862012-06-02 Paul Eggert <eggert@cs.ucla.edu>
3487
3488 * sysdep.c (system_process_attributes): Improve comment.
3489
f2d6a3df
SM
34902012-06-02 Stefan Monnier <monnier@iro.umontreal.ca>
3491
3492 * keyboard.c: Export real-this-command to Elisp.
3493 (syms_of_keyboard): Rename real_this_command to Vreal_this_command
3494 and DEFVAR it. Update all users.
3495
63810350
PE
34962012-06-02 Paul Eggert <eggert@cs.ucla.edu>
3497
7bd5c1f4
PE
3498 * minibuf.c (Fassoc_string): Remove duplicate declaration.
3499
63810350
PE
3500 * sysdep.c (system_process_attributes) [SOLARIS2 && HAVE_PROCFS]:
3501 Convert pctcpu and pctmem to Lisp float properly.
3502 Let the compiler fold better, as 100.0/0x8000 is exact.
3503
a2821611
AS
35042012-06-02 Andreas Schwab <schwab@linux-m68k.org>
3505
3506 * alloc.c (CONS_BLOCK_SIZE): Account for padding at the end of
3507 cons_block.
3508
5fceba1d
PE
35092012-06-01 Paul Eggert <eggert@cs.ucla.edu>
3510
3511 * xfns.c (x_set_tool_bar_lines) [USE_GTK]: Adjust to bitfield change.
3512
c98ff5dd
DA
35132012-06-01 Dmitry Antipov <dmantipov@yandex.ru>
3514
3515 For a 'struct window', replace some Lisp_Object fields to
3516 bitfields where appropriate, remove unused fields.
3517 * window.h (struct window): Remove unused 'last_mark_x' and
3518 'last_mark_y' fields. Rename 'mini_p' field to 'mini',
3519 change it's type from Lisp_Object to bitfield.
3520 Change type of 'force_start', 'optional_new_start',
3521 'last_had_star', 'update_mode_line' and 'start_at_line_beg'
3522 fields from Lisp_Object to bitfield. Adjust users accordingly.
3523
ca34e0be
PE
35242012-05-31 Paul Eggert <eggert@cs.ucla.edu>
3525
3526 Pacify gcc -Wdouble-precision when using Xaw.
3527 * xterm.c (xaw_jump_callback, x_set_toolkit_scroll_bar_thumb)
3528 [HAVE_X_WINDOWS && USE_TOOLKIT_SCROLL_BARS && !USE_MOTIF && !USE_GTK]:
3529 Use 'float' consistently, rather than 'float' in most places
3530 and 'double' in a couple of places.
3531
efc00ab1 35322012-05-31 Eli Zaretskii <eliz@gnu.org>
d5fd2c54
EZ
3533
3534 * xdisp.c (handle_stop): Detect whether we have overlay strings
3535 loaded by testing it->current.overlay_string_index to be
3536 non-negative, instead of checking whether n_overlay_strings is
3537 positive. (Bug#11587)
3538
efc00ab1 35392012-05-31 Chong Yidong <cyd@gnu.org>
353c87f6
CY
3540
3541 * keymap.c (describe_map_tree): Revert 2011-07-07 change (Bug#1169).
3542
3543 * doc.c (Fsubstitute_command_keys): Doc fix.
3544
efc00ab1 35452012-05-31 Eli Zaretskii <eliz@gnu.org>
a02ae4e5
EZ
3546
3547 * search.c (search_buffer): Remove calls to
3548 r_alloc_inhibit_buffer_relocation, as it is now called by
3549 maybe_unify_char, which was the cause of relocation of buffer text
3550 in bug#11519.
3551
efc00ab1 35522012-05-31 Eli Zaretskii <eliz@gnu.org>
291d430f
EZ
3553
3554 * charset.c (maybe_unify_char): Inhibit relocation of buffer text
3555 for the duration of call to load_charset, to avoid problems with
3556 callers of maybe_unify_char that access buffer text through C
3557 pointers.
3558
3559 * ralloc.c (r_alloc_inhibit_buffer_relocation): Increment and
3560 decrement the inhibition flag, instead of just setting or
3561 resetting it.
3562
ba93a187
PE
35632012-05-31 Paul Eggert <eggert@cs.ucla.edu>
3564
3565 Remove obsolete '#define static' cruft.
3566 * s/hpux10-20.h (_FILE_OFFSET_BITS): Don't #undef.
3567 This #undef was "temporary" in 2000; it is no longer needed
3568 now that '#define static' has gone away.
3569 * xfns.c, xterm.h (gray_bitmap_width, gray_bitmap_height)
3570 (gray_bitmap_bits): Remove; no longer needed.
3571 All uses replaced with definiens.
3572 * xterm.c: Include "bitmaps/gray.xbm".
3573
9e4bf381
PE
35742012-05-30 Paul Eggert <eggert@cs.ucla.edu>
3575
3576 Clean up __executable_start, monstartup when --enable-profiling.
3577 The following changes affect the code only when profiling.
3578 * dispnew.c (__executable_start): Rename from safe_bcopy.
3579 Define only on platforms that need it.
3580 * emacs.c: Include <sys/gmon.h> when profiling.
3581 (_mcleanup): Remove decl, since <sys/gmon.h> does it now.
3582 (__executable_start): Remove decl, since lisp.h does it now.
3583 (safe_bcopy): Remove decl; no longer has that name.
3584 (main): Coalesce #if into single bit of code, for simplicity.
3585 Cast pointers to uintptr_t, since standard libraries want integers
3586 and not pointers.
3587 * lisp.h (__executable_start): New decl.
3588
32d72c2f
GM
35892012-05-31 Glenn Morris <rgm@gnu.org>
3590
3591 * image.c (Fimagemagick_types): Doc fix.
3592
baac5bc7
JM
35932012-05-30 Jim Meyering <meyering@redhat.com>
3594
3595 * callproc.c (Fcall_process_region): Include directory component
3596 in mkstemp error message (Bug#11586).
3597
72cb32cf
PE
35982012-05-30 Paul Eggert <eggert@cs.ucla.edu>
3599
3600 * alloc.c, lisp.h (make_pure_vector): Now static.
3601
61b108cc
SM
36022012-05-30 Stefan Monnier <monnier@iro.umontreal.ca>
3603
3604 * eval.c (Fdefun, Fdefmacro, Vmacro_declaration_function):
3605 Move to byte-run.el.
3606 (Fautoload): Do the hash-doc more carefully.
3607 * data.c (Fdefalias): Purify definition, except for keymaps.
3608 (Qdefun): Move from eval.c.
3609 * lisp.h (Qdefun): Remove.
3610 * lread.c (read1): Tiny simplification.
3611
471fe23d
TN
36122012-05-29 Troels Nielsen <bn.troels@gmail.com>
3613
934f3f58 3614 Do not create empty overlays with the evaporate property (Bug#9642).
471fe23d
TN
3615 * buffer.c (Fmove_overlay): Reinstate the earlier fix for
3616 Bug#9642, but explicitly check that the buffer the overlay would
3617 be moved to is live and rearrange lines to make sure that errors
3618 will not put the overlay in an inconsistent state.
3619 (Fdelete_overlay): Cosmetics.
3620
85d0efd1
EZ
36212012-05-28 Eli Zaretskii <eliz@gnu.org>
3622
3623 * w32term.c (my_bring_window_to_top): New function.
3624 (x_raise_frame): Use handle returned by DeferWindowPos, which
61b108cc
SM
3625 could be different from the original one.
3626 Call my_bring_window_to_top instead of my_set_foreground_window.
85d0efd1
EZ
3627 (Bug#11513)
3628
3629 * w32fns.c (w32_wnd_proc): Accept and process WM_EMACS_BRINGTOTOP
3630 by calling BringWindowToTop.
3631
3632 * w32term.h (WM_EMACS_BRINGTOTOP): New message.
3633 (WM_EMACS_END): Increase by one.
3634
da92a98c
PE
36352012-05-28 Paul Eggert <eggert@cs.ucla.edu>
3636
3637 * bidi.c (bidi_mirror_char): Put eassert before conversion to int.
3638 This avoids undefined behavior that might cause the eassert
3639 to not catch an out-of-range value.
3640
74d1f848
JB
36412012-05-28 Juanma Barranquero <lekktu@gmail.com>
3642
3643 * makefile.w32-in ($(BLD)/w32inevt.$(O), $(BLD)/w32console.$(O)):
3644 Update dependencies.
3645
9e1a06fc
EZ
36462012-05-27 Eli Zaretskii <eliz@gnu.org>
3647
3648 * bidi.c (bidi_mirror_char): Fix last change.
3649
f3dd7312
AS
36502012-05-27 Andreas Schwab <schwab@linux-m68k.org>
3651
3652 * unexmacosx.c (copy_data_segment): Truncate after 16 characters
3653 when referring to sectname field in printf format.
3654
81899c91
PE
36552012-05-27 Paul Eggert <eggert@cs.ucla.edu>
3656
57b81a9f
PE
3657 * lisp.h [REL_ALLOC]: Omit duplicate prototypes.
3658 Only r_alloc_inhibit_buffer_relocation needed to be added;
3659 the others were already declared.
3660
81899c91
PE
3661 * bidi.c (bidi_mirror_char): Don't possibly truncate the integer
3662 before checking whether it's out of range. Put the check inside
3663 eassert. See
3664 <http://lists.gnu.org/archive/html/emacs-devel/2012-05/msg00485.html>.
3665
33017faf 36662012-05-27 Ken Brown <kbrown@cornell.edu>
2f9b9adb
KB
3667
3668 * callproc.c (Fcall_process): Restore a line that was accidentally
3669 commented out in the 2011-02-13 change (bug#11547).
3670
33017faf 36712012-05-27 Eli Zaretskii <eliz@gnu.org>
52c55cc7
EZ
3672
3673 * lisp.h [REL_ALLOC]: Add prototypes for external functions
3674 defined on ralloc.c.
3675
3676 * buffer.c [REL_ALLOC]: Remove prototypes of
3677 r_alloc_reset_variable, r_alloc, r_re_alloc, and r_alloc_free,
3678 they are now on lisp.h.
3679
3680 * ralloc.c (r_alloc_inhibit_buffer_relocation): New function.
3681
3682 * search.c (search_buffer): Use it to inhibit relocation of buffer
3683 text while re_search_2 is doing its job, because re_search_2 is
3684 passed C pointers to buffer text. (Bug#11519)
3685
23415acf
EZ
3686 * msdos.c (internal_terminal_init) <Vwindow_system_version>:
3687 Update value to 24.
3688
44e27368
EZ
3689 * xdisp.c (move_it_to): Under MOVE_TO_Y, when restoring iterator
3690 state after an additional call to move_it_in_display_line_to, keep
3691 the values of it->max_ascent and it->max_descent found for the
3692 entire line.
3693 (pos_visible_p): Revert the comparison against bottom_y to what it
3694 was in revid eliz@gnu.org-20120513182235-4p6386j761ld0nwb.
3695 (Bug#11464)
3696
c1892f11
PE
36972012-05-26 Paul Eggert <eggert@cs.ucla.edu>
3698
3699 Fix coding-related core dumps with gcc -ftrapv.
3700 The code was computing A - B, where A and B are pointers, and B is
3701 random garbage. This can lead to core dumps on platforms that
3702 have special pointer registers, and it also leads to core dumps on
3703 x86-64 when compiled with gcc -ftrapv. The fix is to compute
3704 A - B only when B is initialized properly.
3705 * coding.c (coding_set_source, coding_set_destination): Return void.
3706 (coding_change_source, coding_change_destinations): New functions,
3707 with the old behaviors of coding_set_source and coding_set_destination.
3708 All callers that need an offset changed to use these new functions.
3709
eb7afdad
GM
37102012-05-26 Glenn Morris <rgm@gnu.org>
3711
3712 * nsterm.m (ns_init_paths): Don't mess with INFOPATH. (Bug#2791)
3713
f12fdf02
EZ
37142012-05-26 Eli Zaretskii <eliz@gnu.org>
3715
53a63be6 3716 Extend mouse support on W32 text-mode console.
61b108cc
SM
3717 * xdisp.c (draw_row_with_mouse_face):
3718 Call tty_draw_row_with_mouse_face for WINDOWSNT as well.
eb3f6f01 3719
eb3f6f01 3720 * w32console.c: Include window.h.
61b108cc
SM
3721 (w32con_write_glyphs_with_face, tty_draw_row_with_mouse_face):
3722 New functions.
eb3f6f01
EZ
3723 (initialize_w32_display): Initialize mouse-highlight data.
3724
53a63be6
EZ
3725 * w32inevt.c: Include termchar.h and window.h.
3726 (do_mouse_event): Support mouse-autoselect-window. When the mouse
3727 moves, call note_mouse_highlight. If help_echo changed, call
3728 gen_help_event to produce help-echo message in the echo area.
3729 Call clear_mouse_face if mouse_face_hidden is set in the mouse
3730 highlight info.
3731
4cfd81f6
PE
37322012-05-26 Paul Eggert <eggert@cs.ucla.edu>
3733
3734 * lread.c (read1): Simplify slightly to avoid an overflow warning
3735 with GCC 4.7.0 on x86-64.
3736
4446092a
EZ
37372012-05-26 Eli Zaretskii <eliz@gnu.org>
3738
3739 * bidi.c (bidi_mirror_char): Revert last change: an int is
3740 definitely wide enough here.
3741
42b2a986 37422012-05-25 Paul Eggert <eggert@cs.ucla.edu>
3164aeac 3743
42b2a986 3744 Fix integer width and related bugs (Bug#9874).
eb106a49 3745 * alloc.c (pure_bytes_used_lisp, pure_bytes_used_non_lisp):
d311d28c
PE
3746 (allocate_vectorlike, buffer_memory_full, struct sdata, SDATA_SIZE)
3747 (string_bytes, check_sblock, allocate_string_data):
3748 (compact_small_strings, Fmake_bool_vector, make_string)
3749 (make_unibyte_string, make_multibyte_string)
3750 (make_string_from_bytes, make_specified_string)
3751 (allocate_vectorlike, Fmake_vector, find_string_data_in_pure)
3752 (make_pure_string, make_pure_c_string, make_pure_vector, Fpurecopy)
3753 (mark_vectorlike):
3754 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3755 (allocate_pseudovector):
3756 Use int, not EMACS_INT, where int is wide enough.
3757 (inhibit_garbage_collection, Fgarbage_collect):
3758 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3759 * bidi.c (bidi_mirror_char): Use EMACS_INT, not int, where
3760 int might not be wide enough.
3761 (bidi_cache_search, bidi_cache_find, bidi_init_it)
3762 (bidi_count_bytes, bidi_char_at_pos, bidi_fetch_char)
3763 (bidi_at_paragraph_end, bidi_find_paragraph_start)
3764 (bidi_paragraph_init, bidi_resolve_explicit, bidi_resolve_weak)
3765 (bidi_level_of_next_char, bidi_move_to_visually_next):
3766 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3767 * buffer.c (copy_overlays, Fgenerate_new_buffer_name)
3768 (Fkill_buffer, Fset_buffer_major_mode)
3769 (advance_to_char_boundary, Fbuffer_swap_text)
3770 (Fset_buffer_multibyte, overlays_at, overlays_in)
3771 (overlay_touches_p, struct sortvec, record_overlay_string)
3772 (overlay_strings, recenter_overlay_lists)
3773 (adjust_overlays_for_insert, adjust_overlays_for_delete)
3774 (fix_start_end_in_overlays, fix_overlays_before, modify_overlay)
3775 (Fmove_overlay, Fnext_overlay_change, Fprevious_overlay_change)
3776 (Foverlay_recenter, last_overlay_modification_hooks_used)
3777 (report_overlay_modification, evaporate_overlays, enlarge_buffer_text):
3778 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
977b0e45
PE
3779 (validate_region): Omit unnecessary test for b <= e,
3780 since that's guaranteed by the previous test.
d311d28c
PE
3781 (adjust_overlays_for_delete): Avoid pos + length overflow.
3782 (Fmove_overlay, Fdelete_overlay, add_overlay_mod_hooklist)
3783 (report_overlay_modification):
3784 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3785 (Foverlays_at, Fnext_overlay_change, Fprevious_overlay_change):
3786 Omit pointer cast, which isn't needed anyway, and doesn't work
3787 after the EMACS_INT -> ptrdiff_t change.
02481186 3788 (Fmove_overlay): Clip BEG and END to ptrdiff_t to avoid overflow.
d311d28c
PE
3789 * buffer.h: Adjust decls to match defn changes elsewhere.
3790 (struct buffer_text, struct buffer):
3791 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3792 Use EMACS_INT, not int, where int might not be wide enough.
39b5db3b
PE
3793 * bytecode.c (unmark_byte_stack, exec_byte_code): Use ptrdiff_t,
3794 not int, to avoid needless 32-bit limit on 64-bit hosts.
3795 (exec_byte_code): Use tighter memory-full test, one that checks
3796 for alloca overflow. Don't compute the address of the object just
3797 before an array, as that's not portable. Use EMACS_INT, not
3798 ptrdiff_t or int, where ptrdiff_t or int might not be wide enough.
d311d28c
PE
3799 * callint.c (Fcall_interactively):
3800 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3801 * callproc.c (call_process_kill, Fcall_process):
3802 Don't assume pid_t fits into an Emacs fixnum.
3803 (call_process_cleanup, Fcall_process, child_setup):
3804 Don't assume pid_t fits into int.
3805 (call_process_cleanup, Fcall_process, delete_temp_file)
3806 (Fcall_process_region):
3807 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3808 (Fcall_process): Simplify handling of volatile integers.
3809 Use int, not EMACS_INT, where int will do.
3810 * casefiddle.c (casify_object, casify_region, operate_on_word)
3811 (Fupcase_word, Fdowncase_word, Fcapitalize_word):
3812 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3813 (casify_object): Avoid integer overflow when overallocating buffer.
3814 * casetab.c (set_identity, shuffle): Prefer int to unsigned when
45c2afd6 3815 either works. Use lint_assume to convince GCC 4.6.1 that it's OK.
d311d28c
PE
3816 * category.c (Fchar_category_set): Don't assume fixnum fits in int.
3817 * category.h (CATEGORYP): Don't assume arg is nonnegative.
3818 * ccl.c (GET_CCL_INT): Remove; no longer needed, since the
3819 integers are now checked earlier. All uses replaced with XINT.
3820 (ccl_driver):
3821 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3822 For CCL_MapSingle, check that content and value are in int range.
c801946a
PE
3823 (ccl_driver, Fregister_code_conversion_map):
3824 Check that Vcode_version_map_vector is a vector.
d311d28c
PE
3825 (resolve_symbol_ccl_program): Check that vector header is in range.
3826 Always copy the vector, so that we can check its contents reliably
3827 now rather than having to recheck each instruction as it's being
3828 executed. Check that vector words fit in 'int'.
3829 (ccl_get_compiled_code, Fregister_ccl_program)
3830 (Fregister_code_conversion_map): Use ptrdiff_t, not int, for
3831 program indexes, to avoid needless 32-bit limit on 64-bit hosts.
3832 (Fccl_execute, Fccl_execute_on_string): Check that initial reg
3833 contents are in range.
3834 (Fccl_execute_on_string): Check that status is in range.
3835 * ccl.h (struct ccl_program.idx): Now ptrdiff_t, not int.
3836 * character.c (char_resolve_modifier_mask, Fchar_resolve_modifiers):
3837 Accept and return EMACS_INT, not int, because callers can pass values
3838 out of 'int' range.
3839 (c_string_width, strwidth, lisp_string_width, chars_in_text)
3840 (multibyte_chars_in_text, parse_str_as_multibyte)
3841 (str_as_multibyte, count_size_as_multibyte, str_to_multibyte)
3842 (str_as_unibyte, str_to_unibyte, string_count_byte8)
3843 (string_escape_byte8, Fget_byte):
3844 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
a14e1568 3845 (Funibyte_string): Use CHECK_RANGED_INTEGER, not CHECK_NATNUM, to
d311d28c
PE
3846 avoid mishandling large integers.
3847 * character.h: Adjust decls to match defn changes elsewhere.
3848 * charset.c (load_charset_map_from_file, find_charsets_in_text)
3849 (Ffind_charset_region):
3850 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3851 (load_charset_map_from_file): Redo idx calculation to avoid overflow.
3852 (load_charset_map_from_vector, Fdefine_charset_internal):
3c7649c1 3853 Don't assume fixnum fits in int.
d311d28c
PE
3854 (load_charset_map_from_vector, Fmap_charset_chars):
3855 Remove now-unnecessary CHECK_NATNUMs.
3856 (Fdefine_charset_internal): Check ranges here, more carefully.
3c7649c1
PE
3857 Don't rely on undefined behavior with signed left shift overflow.
3858 Don't assume unsigned int fits into fixnum, or that fixnum fits
3859 into unsigned int. Don't require max_code to be a valid fixnum;
3860 that's not true for gb10830 4-byte on a 32-bit host. Allow
3861 invalid_code to be a cons, for the same reason. Require code_offset
3862 to be a character. Avoid int overflow if max_char is close
3863 to INT_MAX.
3864 (CODE_POINT_TO_INDEX): On 32-bit hosts, return int, not unsigned;
3865 this is intended anyway and avoids some undefined behavior.
3866 (load_charset_map): Pass unsigned, not int, as 2nd arg of
3867 INDEX_TO_CODE_POINT, as that's what it expects.
3868 (Funify_charset, encode_char): Don't stuff unsigned vals into int vars.
60ad3eab
PE
3869 * charset.h (DECODE_CHAR): Return int, not unsigned;
3870 this is what was intended anyway, and it avoids undefined behavior.
3871 (CHARSET_OFFSET): Remove unused macro, instead of fixing its
3872 integer-overflow issues.
3873 (ENCODE_CHAR): Return unsigned on all hosts, not just on 32-bit hosts.
3874 Formerly, it returned EMACS_INT on 64-bit hosts in the common case
3875 where the argument is EMACS_INT, and this behavior is not intended.
d311d28c
PE
3876 * chartab.c (Fmake_char_table, Fset_char_table_range)
3877 (uniprop_get_decoder, uniprop_get_encoder):
3878 Don't assume fixnum fits in int.
3879 * cmds.c (move_point): New function, that does the gist of
3880 Fforward_char and Fbackward_char, but does so while checking
3881 for integer overflow more accurately.
c96e5d6a 3882 (Fforward_char, Fbackward_char): Use it.
d311d28c
PE
3883 (Fforward_line, Fend_of_line, internal_self_insert)
3884 (internal_self_insert):
3885 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3886 Fix a FIXME, by checking for integer overflow when calculating
3887 target_clm and actual_clm.
3888 * coding.c (detect_coding_XXX, encode_coding_XXX, CODING_DECODE_CHAR)
8f50130c 3889 (CODING_ENCODE_CHAR, CODING_CHAR_CHARSET, CODING_CHAR_CHARSET_P)
d311d28c
PE
3890 (ASSURE_DESTINATION, coding_alloc_by_realloc)
3891 (coding_alloc_by_making_gap, alloc_destination)
3892 (detect_coding_utf_8, encode_coding_utf_8, decode_coding_utf_16)
3893 (encode_coding_utf_16, detect_coding_emacs_mule)
3894 (decode_coding_emacs_mule, encode_coding_emacs_mule)
3895 (detect_coding_iso_2022, decode_coding_iso_2022)
3896 (encode_invocation_designation, encode_designation_at_bol)
3897 (encode_coding_iso_2022, detect_coding_sjis, detect_coding_big5)
3898 (decode_coding_sjis, decode_coding_big5, encode_coding_sjis)
3899 (encode_coding_big5, detect_coding_ccl, decode_coding_ccl)
3900 (encode_coding_ccl, encode_coding_raw_text)
3901 (detect_coding_charset, decode_coding_charset)
3902 (encode_coding_charset, detect_eol, decode_eol, produce_chars)
3903 (produce_composition, produce_charset, produce_annotation)
3904 (decode_coding, handle_composition_annotation)
3905 (handle_charset_annotation, consume_chars, decode_coding_gap)
3906 (decode_coding_object, encode_coding_object, detect_coding_system)
3907 (Ffind_coding_systems_region_internal, Fcheck_coding_systems_region)
3908 (code_convert_region, code_convert_string)
8f50130c
PE
3909 (Fdefine_coding_system_internal)
3910 (coding_set_source, coding_set_destination):
d311d28c
PE
3911 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3912 (setup_iso_safe_charsets, consume_chars, Funencodable_char_position)
3913 (Fdefine_coding_system_internal):
3914 Don't assume fixnums fit in int.
3915 (decode_coding_gap, decode_coding_object, encode_coding_object)
5895d7b9 3916 (Fread_coding_system, Fdetect_coding_region)
2c6a9faa
PE
3917 (Funencodable_char_position, Fcheck_coding_systems_region)
3918 (get_translation, handle_composition_annotation, consume_chars):
d311d28c 3919 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
977b0e45 3920 (consume_chars): Rewrite to not calculate an address outside buffer.
d311d28c 3921 (Ffind_operation_coding_system): NATNUMP can eval its arg twice.
7b09a37a 3922 Don't access memory outside of the args array.
d311d28c 3923 (Fdefine_coding_system_internal): Check for charset-id overflow.
47664caa
PE
3924 (ENCODE_ISO_CHARACTER): Use unsigned, not int, to store the unsigned
3925 result of ENCODE_CHAR.
d311d28c
PE
3926 * coding.h: Adjust decls to match defn changes elsewhere.
3927 (struct coding_system):
3928 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3929 * composite.c (get_composition_id, find_composition)
3930 (run_composition_function, update_compositions)
3931 (compose_text, composition_gstring_put_cache)
3932 (composition_gstring_p, composition_gstring_width)
3933 (fill_gstring_header, fill_gstring_body, autocmp_chars)
3934 (composition_compute_stop_pos, composition_reseat_it)
3935 (composition_update_it, struct position_record)
3936 (find_automatic_composition, composition_adjust_point)
3937 (Fcomposition_get_gstring, Ffind_composition_internal):
3938 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3939 (update_compositions):
3940 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3941 * composite.h: Adjust decls to match defn changes elsewhere.
3942 (struct composition):
3943 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3944 * data.c (let_shadows_buffer_binding_p, let_shadows_global_binding_p):
3945 Do not attempt to compute the address of the object just before a
3946 buffer; this is not portable.
3947 (Faref, Faset):
3948 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3949 (Faset): Use int, not EMACS_INT, where int is wide enough.
3950 (Fstring_to_number): Don't assume fixnums fit in int.
3951 (Frem): Don't assume arg is nonnegative.
3952 * dbusbind.c (xd_append_arg): Check for integers out of range.
3953 (Fdbus_call_method): Don't overflow the timeout int.
42b2a986 3954 (extract_signed, extract_unsigned): New functions.
243e0530
PE
3955 (XD_CHECK_DBUS_SERIAL): Remove; superseded by extract_unsigned.
3956 (xd_get_connection_references): Return ptrdiff_t, not int.
3957 All uses changed.
3958 (xd_signature, xd_append_arg, xd_retrieve_arg, Fdbus_message_internal)
3959 (xd_read_message_1):
3960 Use int, not unsigned, where the dbus API uses int.
3961 (Fdbus_message_internal): Don't overflow mtype.
3962 (syms_of_dbusbind): Allocate right-sized buffer for integers.
d311d28c
PE
3963 * dired.c (directory_files_internal, file_name_completion, scmp)
3964 (file_name_completion_stat):
3965 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3966 (file_name_completion): Don't overflow matchcount.
3967 (file_name_completion_stat): Use SAFE_ALLOCA, not alloca.
3968 * dispextern.h: Adjust decls to match defn changes elsewhere.
3969 (struct text_pos, struct glyph, struct bidi_saved_info)
3970 (struct bidi_string_data, struct bidi_it, struct composition_it)
3971 (struct it):
3972 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3973 (struct display_pos, struct composition_it, struct it):
3974 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3975 * dispnew.c (increment_matrix_positions)
3976 (increment_row_positions, mode_line_string)
3977 (marginal_area_string):
3978 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
54e1617f 3979 (change_frame_size_1, Fredisplay, Fframe_or_buffer_changed_p):
d311d28c
PE
3980 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3981 (duration_to_sec_usec): New function, to check for overflow better.
3982 (Fsleep_for, sit_for): Use it.
3983 * doc.c (get_doc_string, store_function_docstring):
3984 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3985 (get_doc_string, Fsnarf_documentation):
3986 Use int, not EMACS_INT, where int is wide enough.
3987 (get_doc_string):
3988 Use SAFE_ALLOCA, not alloca.
3989 Check for overflow when converting EMACS_INT to off_t.
3990 * doprnt.c (doprnt):
3991 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3992 * editfns.c (init_editfns, Fuser_uid, Fuser_real_uid):
3993 Don't assume uid_t fits into fixnum.
3994 (buildmark, Fgoto_char, overlays_around, find_field, Fdelete_field)
3995 (Ffield_string, Ffield_string_no_properties, Ffield_beginning)
3996 (Ffield_end, Fconstrain_to_field, Fline_beginning_position)
3997 (Fline_end_position, Fprevious_char, Fchar_after, Fchar_before)
3998 (general_insert_function)
3999 (Finsert_char, make_buffer_string, make_buffer_string_both)
4000 (update_buffer_properties, Fbuffer_substring)
4001 (Fbuffer_substring_no_properties, Fcompare_buffer_substrings)
4002 (Fsubst_char_in_region, check_translation)
4003 (Ftranslate_region_internal, save_restriction_restore, Fformat)
4004 (transpose_markers, Ftranspose_regions):
4005 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
4006 (clip_to_bounds): Move to lisp.h as an inline function).
4007 (Fconstrain_to_field): Don't assume integers are nonnegative.
4008 (Fline_beginning_position, Fsave_excursion, Fsave_current_buffer):
4009 (Fsubst_char_in_region, Fsave_restriction):
4010 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
4011 (Femacs_pid): Don't assume pid_t fits into fixnum.
4012 (lo_time): Use int, not EMACS_INT, when int suffices.
4013 (lisp_time_argument): Check for usec out of range.
4014 (Fencode_time): Don't assume fixnum fits in int.
3f4eabd1
PE
4015 (Fuser_login_name, Fuser_full_name): Signal an error
4016 if a uid argument is out of range, rather than relying on
4017 undefined behavior.
c8d5c857
PE
4018 (Fformat_time_string): Remove now-unnecessary check.
4019 lisp_time_argument checks for out-of-range usec now.
243e0530 4020 Use ptrdiff_t, not size_t, where ptrdiff_t will do.
d311d28c
PE
4021 * emacs.c (gdb_valbits, gdb_gctypebits): Now int, not EMACS_INT.
4022 (gdb_data_seg_bits): Now uintptr_t, not EMACS_INT.
4023 (PVEC_FLAG, gdb_array_mark_flag): Now ptrdiff_t, not EMACS_INT.
4024 (init_cmdargs, Fdump_emacs):
4025 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
4026 (Fkill_emacs): Don't assume fixnum fits in int; instead, take just
4027 the bottom (typically) 32 bits of the fixnum.
4028 * eval.c (specpdl_size, call_debugger):
4029 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
4030 (when_entered_debugger, Fbacktrace_debug):
4031 Don't assume fixnum can fit in int.
4032 (Fdefvaralias, Fdefvar): Do not attempt to compute the address of
4033 the object just before a buffer; this is not portable.
4034 (FletX, Flet, Funwind_protect, do_autoload, Feval, funcall_lambda)
4035 (grow_specpdl, unbind_to):
4036 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
4037 (Fapply, apply_lambda): Don't assume ptrdiff_t can hold fixnum.
4038 (grow_specpdl): Simplify allocation by using xpalloc.
856bbc81 4039 (Fprog1, Fprog2): Don't assume list length fits in int. Simplify.
d311d28c
PE
4040 * fileio.c (Ffind_file_name_handler, Fcopy_file, Frename_file)
4041 (Finsert_file_contents, Fwrite_region, Fdo_auto_save):
4042 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
4043 (Ffind_file_name_handler, non_regular_inserted, Finsert_file_contents)
4044 (a_write, e_write):
4045 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
4046 (Fcopy_file, non_regular_nbytes, read_non_regular)
4047 (Finsert_file_contents):
4048 Use int, not EMACS_INT, where int is wide enough.
4049 (READ_BUF_SIZE): Verify that it fits in int.
4050 (Finsert_file_contents): Check that counts are in proper range,
4051 rather than assuming fixnums fit into ptrdiff_t etc.
4052 Don't assume fixnums fit into int.
125b3835 4053 * floatfns.c (Fexpt): Avoid undefined signed * signed overflow.
5895d7b9
PE
4054 * fns.c (Fcompare_strings, Fstring_lessp, struct textprop_rec, concat)
4055 (string_char_byte_cache_charpos, string_char_byte_cache_bytepos)
d311d28c
PE
4056 (string_char_to_byte, string_byte_to_char)
4057 (string_make_multibyte, string_to_multibyte)
4058 (string_make_unibyte, Fstring_as_unibyte, Fstring_as_multibyte)
4059 (Fstring_to_unibyte, Fsubstring, Fsubstring_no_properties)
4060 (substring_both, Fdelete, internal_equal, Ffillarray)
4061 (Fclear_string, mapcar1)
4062 (Fbase64_encode_region, Fbase64_encode_string, base64_encode_1)
4063 (Fbase64_decode_region, Fbase64_decode_string, base64_decode_1)
4064 (larger_vector, make_hash_table, maybe_resize_hash_table)
4065 (hash_lookup, hash_remove_from_table, hash_clear, sweep_weak_table)
4066 (Fmaphash, secure_hash):
4067 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
4068 (concat): Check for string index and length overflow.
4069 (Fmapconcat): Don't assume fixnums fit into ptrdiff_t.
4070 (Frequire):
4071 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
4072 (larger_vector): New API (vec, incr_min, size_max) replaces old
4073 one (vec, new_size, init). This catches size overflow.
4074 INIT was removed because it was always Qnil.
4075 All callers changed.
4076 (INDEX_SIZE_BOUND): New macro, which calculates more precisely
4077 the upper bound on a hash table index size.
4078 (make_hash_table, maybe_resize_hash_table): Use it.
4079 (secure_hash): Computer start_byte and end_byte only after
4080 they're known to be in ptrdiff_t range.
4081 * font.c (font_intern_prop, font_at, font_range, Ffont_shape_gstring)
4082 (Ffont_get_glyphs, Ffont_at):
4083 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
4084 (font_style_to_value, font_prop_validate_style, font_expand_wildcards)
4085 (Flist_fonts, Fopen_font):
4086 Don't assume fixnum can fit in int.
4087 (check_gstring): Don't assume index can fit in int.
4088 (font_match_p): Check that fixnum is a character, not a nonnegative
4089 fixnum, since the later code needs to stuff it into an int.
4090 (font_find_for_lface): Use SAFE_ALLOCA_LISP, not alloca.
4091 (font_fill_lglyph_metrics): Use unsigned, not EMACS_INT, to avoid
4092 conversion overflow issues.
4093 (Fopen_font): Check for integer out of range.
4094 (Ffont_get_glyphs): Don't assume index can fit in int.
4095 * font.h: Adjust decls to match defn changes elsewhere.
4096 * fontset.c (reorder_font_vector): Redo score calculation to avoid
4097 integer overflow.
4098 (num_auto_fontsets, fontset_from_font): Use ptrdiff_t, not
4099 printmax_t, where ptrdiff_t is wide enough.
4100 (Finternal_char_font):
4101 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
4102 * frame.c (Fset_mouse_position, Fset_mouse_pixel_position)
4103 (Fset_frame_height, Fset_frame_width, Fset_frame_size)
4104 (Fset_frame_position, x_set_frame_parameters)
4105 (x_set_line_spacing, x_set_border_width)
4106 (x_set_internal_border_width, x_set_alpha, x_figure_window_size):
4107 Check that fixnums are in proper range for system types.
4108 (frame_name_fnn_p, Fframe_parameter, Fmodify_frame_parameters):
4109 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
4110 (Fmodify_frame_parameters): Don't assume fixnum fits in int.
4111 Use SAFE_ALLOCA_LISP, not alloca.
4112 * frame.h (struct frame): Use intptr_t, not EMACS_INT, where
4113 intptr_t is wide enough.
4114 * fringe.c (lookup_fringe_bitmap, get_logical_fringe_bitmap)
4115 (Fdefine_fringe_bitmap): Don't assume fixnum fits in int.
4116 (Ffringe_bitmaps_at_pos): Don't assume index fits in int.
4117 Check for fixnum out of range.
4118 * ftfont.c (ftfont_list): Don't assume index fits in int.
4119 Check that fixnums are in proper range for system types.
4120 (ftfont_shape_by_flt):
4121 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
d311d28c
PE
4122 * gnutls.c (emacs_gnutls_write, emacs_gnutls_read):
4123 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
4124 (Fgnutls_error_fatalp, Fgnutls_error_string, Fgnutls_boot):
4125 Check that fixnums are in proper range for system types.
4126 * gnutls.h: Adjust decls to match defn changes elsewhere.
4127 * gtkutil.c (xg_dialog_run):
4128 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
4129 (update_frame_tool_bar):
4130 Check that fixnums are in proper range for system types.
4131 * image.c (parse_image_spec): Redo count calculation to avoid overflow.
5895d7b9 4132 (lookup_image): Check that fixnums are in range for system types.
d311d28c
PE
4133 * indent.c (last_known_column, last_known_column_point):
4134 (current_column_bol_cache):
4135 (skip_invisible, current_column, check_display_width):
4136 (check_display_width, scan_for_column, current_column_1)
4137 (Findent_to, Fcurrent_indentation, position_indentation)
4138 (indented_beyond_p, Fmove_to_column, compute_motion):
4139 (Fcompute_motion, Fvertical_motion):
4140 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
4141 (last_known_column_modified): Use EMACS_INT, not int.
4142 (check_display_width):
4143 (Fcompute_motion):
4144 Check that fixnums and floats are in proper range for system types.
4145 (compute_motion): Don't assume index or fixnum fits in int.
4146 (compute_motion, Fcompute_motion):
4147 Use int, not EMACS_INT, when it is wide enough.
4148 (vmotion): Omit local var start_hpos that is always 0; that way
4149 we don't need to worry about overflow in expressions involving it.
4150 * indent.h: Adjust decls to match defn changes elsewhere.
4151 (struct position):
4152 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
4153 Use int, not EMACS_INT, where int is wide enough.
4154 Remove unused members ovstring_chars_done and tab_offset;
4155 all uses removed.
4156 * insdel.c (move_gap, move_gap_both, gap_left, gap_right)
4157 (adjust_markers_for_delete, adjust_markers_for_insert, adjust_point)
4158 (adjust_markers_for_replace, make_gap_larger, make_gap_smaller)
4159 (make_gap, copy_text, insert, insert_and_inherit)
4160 (insert_before_markers, insert_before_markers_and_inherit)
4161 (insert_1, count_combining_before, count_combining_after)
4162 (insert_1_both, insert_from_string)
4163 (insert_from_string_before_markers, insert_from_string_1)
4164 (insert_from_gap, insert_from_buffer, insert_from_buffer_1)
4165 (adjust_after_replace, adjust_after_insert, replace_range)
4166 (replace_range_2, del_range, del_range_1, del_range_byte)
4167 (del_range_both, del_range_2, modify_region)
4168 (prepare_to_modify_buffer, signal_before_change)
4169 (signal_after_change, Fcombine_after_change_execute):
4170 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
4171 * intervals.c (traverse_intervals, rotate_right, rotate_left)
4172 (balance_an_interval, split_interval_right, split_interval_left)
4173 (find_interval, next_interval, update_interval)
4174 (adjust_intervals_for_insertion, delete_node, delete_interval)
4175 (interval_deletion_adjustment, adjust_intervals_for_deletion)
4176 (static_offset_intervals, offset_intervals)
4177 (merge_interval_right, merge_interval_left, make_new_interval)
4178 (graft_intervals_into_buffer, temp_set_point_both)
4179 (temp_set_point, set_point, adjust_for_invis_intang)
4180 (set_point_both, move_if_not_intangible, get_property_and_range)
4181 (get_local_map, copy_intervals, copy_intervals_to_string)
4182 (compare_string_intervals, set_intervals_multibyte_1):
4183 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
4184 * intervals.h: Adjust decls to match defn changes elsewhere.
4185 (struct interval):
4186 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
4187 * keyboard.c (this_command_key_count, this_single_command_key_start)
4188 (before_command_key_count, before_command_echo_length, echo_now)
4189 (echo_length, recursive_edit_1, Frecursive_edit, Ftrack_mouse)
4190 (command_loop_1, safe_run_hooks, read_char, timer_check_2)
4191 (menu_item_eval_property, read_key_sequence, Fread_key_sequence)
4192 (Fread_key_sequence_vector, Fexecute_extended_command, Fsuspend_emacs):
4193 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
4194 (last_non_minibuf_size, last_point_position, echo_truncate)
4195 (command_loop_1, adjust_point_for_property, read_char, gen_help_event)
4196 (make_lispy_position, make_lispy_event, parse_modifiers_uncached)
4197 (parse_modifiers, modify_event_symbol, Fexecute_extended_command)
4198 (stuff_buffered_input):
4199 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
4200 (last_auto_save, command_loop_1, read_char):
4201 Use EMACS_INT, not int, to avoid integer overflow.
4202 (record_char): Avoid overflow in total_keys computation.
4203 (parse_modifiers_uncached): Redo index calculation to avoid overflow.
4204 * keyboard.h: Adjust decls to match defn changes elsewhere.
4205 * keymap.c (Fdefine_key, Fcurrent_active_maps, accessible_keymaps_1)
4206 (Fkey_description, Fdescribe_vector, Flookup_key):
4207 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
4208 (click_position): New function, to check that positions are in range.
4209 (Fcurrent_active_maps):
4210 (describe_command):
4211 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
4212 (Faccessible_keymaps, Fkey_description):
4213 (preferred_sequence_p):
4214 Don't assume fixnum can fit into int.
4215 (Fkey_description): Use SAFE_ALLOCA_LISP, not alloca.
4216 Check for integer overflow in size calculations.
4217 (Ftext_char_description): Use CHECK_CHARACTER, not CHECK_NUMBER, to
4218 avoid mishandling large integers.
4219 * lisp.h: Adjust decls to match defn changes elsewhere.
4220 (ARRAY_MARK_FLAG, PSEUDOVECTOR_FLAG, struct Lisp_String)
4221 (struct vectorlike_header, struct Lisp_Subr, struct Lisp_Hash_Table)
4222 (struct Lisp_Marker):
4223 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
4224 (clip_to_bounds): Now an inline function, moved here from editfns.c.
d311d28c
PE
4225 (GLYPH_CODE_P): Check for overflow in system types, subsuming the
4226 need for GLYPH_CODE_CHAR_VALID_P and doing proper checking ourselves.
4227 All callers changed.
4228 (GLYPH_CODE_CHAR, GLYPH_CODE_FACE):
4229 Assume the arg has valid form, since it always does.
4230 (TYPE_RANGED_INTEGERP): Avoid bug when checking against a wide
4231 unsigned integer system type.
4232 (CHECK_RANGED_INTEGER, CHECK_TYPE_RANGED_INTEGER): New macros.
4233 (struct catchtag, specpdl_size, SPECPDL_INDEX, USE_SAFE_ALLOCA):
4234 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
4235 (struct catchtag): Use EMACS_INT, not int, since it may be a fixnum.
4236 (duration_to_sec_usec): New decl.
4237 * lread.c (read_from_string_index, read_from_string_index_byte)
4238 (read_from_string_limit, readchar, unreadchar, openp)
4239 (read_internal_start, read1, oblookup):
4240 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
4241 (Fload, readevalloop, Feval_buffer, Feval_region):
4242 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
4243 (openp): Check for out-of-range argument to 'access'.
4244 (read1): Use int, not EMACS_INT, where int is wide enough.
4245 Don't assume fixnum fits into int.
6efdadfd 4246 Fix off-by-one error that can read outside a buffer.
1ab7b8ac
PE
4247 (read_filtered_event): Use duration_to_sec_usec
4248 to do proper overflow checking on durations.
d311d28c
PE
4249 * macros.c (Fstart_kbd_macro): Use xpalloc to check for overflow
4250 in size calculation.
4251 (Fexecute_kbd_macro):
4252 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
4253 * marker.c (cached_charpos, cached_bytepos, CONSIDER)
4254 (byte_char_debug_check, buf_charpos_to_bytepos, verify_bytepos)
4255 (buf_bytepos_to_charpos, Fset_marker, set_marker_restricted)
4256 (set_marker_both, set_marker_restricted_both, marker_position)
4257 (marker_byte_position, Fbuffer_has_markers_at):
4258 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
4259 (Fset_marker, set_marker_restricted): Don't assume fixnum fits in int.
61b108cc 4260 * menu.c (ensure_menu_items): Rename from grow_menu_items.
d311d28c
PE
4261 It now merely ensures that the menu is large enough, without
4262 necessarily growing it, as this avoids some integer overflow issues.
4263 All callers changed.
4264 (keymap_panes, parse_single_submenu, Fx_popup_menu):
4265 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
4266 (parse_single_submenu, Fx_popup_menu): Don't assume fixnum fits in int.
4267 Use SAFE_ALLOCA_LISP, not alloca.
4268 (find_and_return_menu_selection): Avoid unnecessary casts of pointers
4269 to EMACS_INT. Check that fixnums are in proper range for system types.
4270 * minibuf.c (minibuf_prompt_width, string_to_object)
4271 (Fminibuffer_contents, Fminibuffer_contents_no_properties)
4272 (Fminibuffer_completion_contents, Ftry_completion, Fall_completions):
4273 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
4274 (get_minibuffer, read_minibuf_unwind):
4275 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
4276 (read_minibuf): Omit unnecessary arg BACKUP_N, which is always nil;
4277 this simplifies overflow checking. All callers changed.
4278 (read_minibuf, Fread_buffer, Ftry_completion, Fall_completions)
4279 (Ftest_completion):
4280 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
4281 * nsfns.m (check_ns_display_info): Don't assume fixnum fits in long.
4282 (x_set_menu_bar_lines, x_set_tool_bar_lines, Fx_create_frame):
4283 Check that fixnums are in proper range for system types.
4284 (Fx_create_frame, Fx_show_tip):
4285 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
4286 * nsfont.m (ns_findfonts, nsfont_list_family):
4287 Don't assume fixnum fits in long.
4288 * nsmenu.m (ns_update_menubar, ns_menu_show, ns_popup_dialog):
4289 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
4290 (ns_update_menubar): Use intptr_t, not EMACS_INT, when intptr_t is
4291 wide enough.
17fdb222 4292 * nsselect.m (ns_get_local_selection, clean_local_selection_data):
d311d28c
PE
4293 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
4294 * print.c (print_buffer_size, print_buffer_pos, print_buffer_pos_byte)
4295 (PRINTDECLARE, PRINTPREPARE):
4296 (strout, print_string):
4297 (print, print_preprocess, print_check_string_charset_prop)
4298 (print_object):
4299 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
4300 (PRINTDECLARE):
4301 (temp_output_buffer_setup, Fprin1_to_string, print_object):
4302 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
4303 (PRINTPREPARE): Use int, not ptrdiff_t, where int is wide enough.
d311d28c 4304 (printchar, strout): Use xpalloc to catch size calculation overflow.
0fd11aa5 4305 (Fexternal_debugging_output): Don't overflow EMACS_INT->int conversion.
d311d28c
PE
4306 (print_error_message): Use SAFE_ALLOCA, not alloca.
4307 (print_object): Use int, not EMACS_INT, where int is wide enough.
a8b7caa3
PE
4308 (print_depth, new_backquote_output, print_number_index):
4309 Use ptrdiff_t, not int, where int might not be wide enough.
d311d28c
PE
4310 * process.c (Fdelete_process): Don't assume pid fits into EMACS_INT.
4311 (Fset_process_window_size, Fformat_network_address)
4312 (get_lisp_to_sockaddr_size, set_socket_option, Fmake_network_process)
d44287d4 4313 (sigchld_handler):
d311d28c 4314 Check that fixnums are in proper range for system types.
d44287d4 4315 (Fsignal_process): Simplify by avoiding a goto.
d83cf4cc
PE
4316 Check for process-ids out of pid_t range rather than relying on
4317 undefined behavior.
e4d81efc 4318 (process_tick, update_tick): Use EMACS_INT, not int.
d311d28c
PE
4319 (Fformat_network_address, read_process_output, send_process)
4320 (Fprocess_send_region, status_notify):
4321 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
4322 (Fformat_network_address, Fmake_serial_process, Fmake_network_process)
4323 (wait_reading_process_output, read_process_output, exec_sentinel):
4324 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
4325 (conv_lisp_to_sockaddr): Don't assume fixnums fit into int.
4326 (Faccept_process_output): Use duration_to_sec_usec to do proper
4327 overflow checking on durations.
dde14581
PE
4328 (emacs_get_tty_pgrp, Fprocess_running_child_p, process_send_signal):
4329 Don't assume pid_t fits in int.
02481186
PE
4330 * process.h (struct Lisp_Process): Members tick and update_tick
4331 are now of type EMACS_INT, not int.
b62b53e8
PE
4332 * puresize.h (PURESIZE_RATIO): Shrink this to 8/6 on 32-bit hosts
4333 configured --with-wide-int.
d311d28c
PE
4334 * scroll.c (calculate_scrolling, calculate_direct_scrolling)
4335 (line_ins_del): Use int, not EMACS_INT, where int is wide enough.
4336 * search.c (looking_at_1, string_match_1):
4337 (fast_string_match, fast_c_string_match_ignore_case)
4338 (fast_string_match_ignore_case, fast_looking_at, scan_buffer)
4339 (scan_newline, find_before_next_newline, search_command)
4340 (trivial_regexp_p, search_buffer, simple_search, boyer_moore)
4341 (set_search_regs, wordify):
4342 (Freplace_match):
4343 (Fmatch_data):
4344 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
4345 (string_match_1, search_buffer, set_search_regs):
4346 (Fmatch_data):
4347 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
4348 (wordify): Check for overflow in size calculation.
4349 (Freplace_match): Avoid potential buffer overflow in search_regs.start.
4350 (Fset_match_data): Don't assume fixnum fits in ptrdiff_t.
4351 Check that fixnums are in proper range for system types.
4352 * sound.c (struct sound_device)
4353 (wav_play, au_play, vox_write, alsa_period_size, alsa_write):
4354 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
4355 (Fplay_sound_internal):
4356 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
eacd378d 4357 * syntax.c (struct lisp_parse_state, find_start_modiff)
d311d28c
PE
4358 (Finternal_describe_syntax_value, scan_lists, scan_sexps_forward):
4359 (Fparse_partial_sexp):
4360 Don't assume fixnums can fit in int.
4361 (struct lisp_parse_state, find_start_pos, find_start_value)
4362 (find_start_value_byte, find_start_begv)
4363 (update_syntax_table, char_quoted, dec_bytepos)
4364 (find_defun_start, prev_char_comend_first, back_comment):
4365 (scan_words, skip_chars, skip_syntaxes, forw_comment, Fforward_comment)
4366 (scan_lists, Fbackward_prefix_chars, scan_sexps_forward):
4367 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
4368 (Finternal_describe_syntax_value): Check that match_lisp is a
4369 character, not an integer, since the code stuffs it into int.
4370 (scan_words, scan_sexps_forward):
4371 Check that fixnums are in proper range for system types.
4372 (Fforward_word):
4373 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
4374 (scan_sexps_forward):
4375 Use CHARACTERP, not INTEGERP, since the value must fit into int.
4376 (Fparse_partial_sexp): Fix doc; element 8 is not ignored.
4377 * syntax.h: Adjust decls to match defn changes elsewhere.
4378 (struct gl_state_s):
4379 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
e4ecdc9c
PE
4380 (SETUP_SYNTAX_TABLE_FOR_OBJECT): Use PTRDIFF_MAX, not
4381 MOST_POSITIVE_FIXNUM.
d311d28c
PE
4382 * sysdep.c (wait_for_termination_1, wait_for_termination)
4383 (interruptible_wait_for_termination, mkdir):
4384 Don't assume pid_t fits in int; on 64-bit AIX pid_t is 64-bit.
4385 (emacs_read, emacs_write):
4386 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
225a2cff
PE
4387 (system_process_attributes): Don't assume uid_t, gid_t, EMACS_INT,
4388 and double all fit in int.
d311d28c
PE
4389 * term.c (set_tty_color_mode):
4390 Check that fixnums are in proper range for system types.
4391 * termhooks.h (struct input_event):
4392 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
4393 * textprop.c (validate_interval_range, interval_of)
4394 (Fadd_text_properties, set_text_properties_1)
4395 (Fremove_text_properties, Fremove_list_of_text_properties)
4396 (Ftext_property_any, Ftext_property_not_all)
4397 (copy_text_properties, text_property_list, extend_property_ranges)
4398 (verify_interval_modification):
4399 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
4400 (Fnext_single_char_property_change)
4401 (Fprevious_single_char_property_change):
4402 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
5895d7b9
PE
4403 (copy_text_properties):
4404 Check for integer overflow in index calculation.
d311d28c
PE
4405 * undo.c (last_boundary_position, record_point, record_insert)
4406 (record_delete, record_marker_adjustment, record_change)
4407 (record_property_change):
4408 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
4409 (truncate_undo_list, Fprimitive_undo): Don't assume fixnum fits in int.
4410 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
4411 * w32fns.c (Fx_create_frame, x_create_tip_frame, Fx_show_tip)
4412 (Fx_hide_tip, Fx_file_dialog):
4413 * w32menu.c (set_frame_menubar):
4414 Use ptrdiff_t, not int, for consistency with rest of code.
4415 * window.c (window_scroll_preserve_hpos, window_scroll_preserve_vpos)
4416 (select_window, Fdelete_other_windows_internal)
4417 (window_scroll_pixel_based, window_scroll_line_based)
4418 (Frecenter, Fset_window_configuration):
4419 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
4420 (Fset_window_hscroll, run_window_configuration_change_hook)
4421 (set_window_buffer, temp_output_buffer_show, scroll_command)
5895d7b9 4422 (Fscroll_other_window, Frecenter):
d311d28c
PE
4423 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
4424 (Fwindow_line_height, window_scroll, Fscroll_left, Fscroll_right):
4425 Don't assume fixnum fits in int.
4426 (Fset_window_scroll_bars):
4427 Check that fixnums are in proper range for system types.
4428 * xdisp.c (help_echo_pos, pos_visible_p, string_pos_nchars_ahead)
4429 (string_pos, c_string_pos, number_of_chars, init_iterator)
4430 (in_ellipses_for_invisible_text_p, init_from_display_pos)
4431 (compute_stop_pos, next_overlay_change, compute_display_string_pos)
4432 (compute_display_string_end, handle_face_prop)
5895d7b9
PE
4433 (face_before_or_after_it_pos, handle_invisible_prop)
4434 (handle_display_prop, handle_display_spec, handle_single_display_spec)
d311d28c
PE
4435 (display_prop_intangible_p, string_buffer_position_lim)
4436 (string_buffer_position, handle_composition_prop, load_overlay_strings)
4437 (get_overlay_strings_1, get_overlay_strings)
4438 (iterate_out_of_display_property, forward_to_next_line_start)
4439 (back_to_previous_visible_line_start, reseat, reseat_to_string)
4440 (get_next_display_element, set_iterator_to_next)
4441 (get_visually_first_element, compute_stop_pos_backwards)
4442 (handle_stop_backwards, next_element_from_buffer)
4443 (move_it_in_display_line_to, move_it_in_display_line)
4444 (move_it_to, move_it_vertically_backward, move_it_by_lines)
4445 (add_to_log, message_dolog, message_log_check_duplicate)
4446 (message2, message2_nolog, message3, message3_nolog
4447 (with_echo_area_buffer, display_echo_area_1, resize_mini_window_1)
4448 (current_message_1, truncate_echo_area, truncate_message_1)
4449 (set_message, set_message_1, store_mode_line_noprop)
4450 (hscroll_window_tree, debug_delta, debug_delta_bytes, debug_end_vpos)
4451 (text_outside_line_unchanged_p, check_point_in_composition)
4452 (reconsider_clip_changes)
4453 (redisplay_internal, set_cursor_from_row, try_scrolling)
4454 (try_cursor_movement, set_vertical_scroll_bar, redisplay_window)
4455 (redisplay_window, find_last_unchanged_at_beg_row)
4456 (find_first_unchanged_at_end_row, row_containing_pos, try_window_id)
4457 (trailing_whitespace_p, find_row_edges, display_line)
4458 (RECORD_MAX_MIN_POS, Fcurrent_bidi_paragraph_direction)
4459 (display_mode_element, store_mode_line_string)
4460 (pint2str, pint2hrstr, decode_mode_spec)
4461 (display_count_lines, display_string, draw_glyphs)
4462 (x_produce_glyphs, x_insert_glyphs)
4463 (rows_from_pos_range, mouse_face_from_buffer_pos)
4464 (fast_find_string_pos, mouse_face_from_string_pos)
4465 (note_mode_line_or_margin_highlight, note_mouse_highlight):
4466 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
4467 (safe_call, init_from_display_pos, handle_fontified_prop)
4468 (handle_single_display_spec, load_overlay_strings)
4469 (with_echo_area_buffer, setup_echo_area_for_printing)
4470 (display_echo_area, echo_area_display)
4471 (x_consider_frame_title, prepare_menu_bars, update_menu_bar)
4472 (update_tool_bar, hscroll_window_tree, redisplay_internal)
5895d7b9
PE
4473 (redisplay_window, dump_glyph_row, display_mode_line)
4474 (Fformat_mode_line, decode_mode_spec, on_hot_spot_p):
43ad2e9a 4475 (handle_display_spec, display_prop_string_p):
d311d28c
PE
4476 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
4477 (handle_single_display_spec, build_desired_tool_bar_string)
4478 (redisplay_tool_bar, scroll_window_tree, Fdump_glyph_matrix)
4479 (get_specified_cursor_type):
4480 Check that fixnums are in proper range for system types.
4481 (struct overlay_entry, resize_mini_window, Fdump_glyph_row)
4482 (Flookup_image_map):
4483 Don't assume fixnums fit in int.
4484 (compare_overlay_entries):
4485 Avoid mishandling comparisons due to subtraction overflow.
4486 (load_overlay_strings): Use SAFE_NALLOCA, not alloca.
4487 (last_escape_glyph_face_id, last_glyphless_glyph_face_id):
4488 (handle_tool_bar_click):
4489 Use int, not unsigned, since we prefer signed and the signedness
4490 doesn't matter here.
4491 (get_next_display_element, next_element_from_display_vector):
4492 Use int, not EMACS_INT, when int is wide enough.
4493 (start_hourglass): Use duration_to_sec_usec to do proper
4494 overflow checking on durations.
4495 * xfaces.c (Fbitmap_spec_p):
4496 Check that fixnums are in proper range for system types.
4497 (compare_fonts_by_sort_order):
4498 Avoid mishandling comparisons due to subtraction overflow.
4499 (Fx_family_fonts, realize_basic_faces):
4500 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
4501 (Fx_family_fonts):
4502 Don't assume fixnum fits in int.
4503 Use SAFE_ALLOCA_LISP, not alloca.
4504 (merge_face_heights): Remove unnecessary cast to EMACS_INT.
4505 (Finternal_make_lisp_face): Don't allocate more than MAX_FACE_ID.
4506 (face_at_buffer_position, face_for_overlay_string)
4507 (face_at_string_position):
4508 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
4509 (merge_faces): Use int, not EMACS_INT, where int is wide enough.
4510 * xfns.c (x_set_menu_bar_lines, x_set_tool_bar_lines, x_icon_verify)
4511 (Fx_show_tip):
4512 Check that fixnums are in proper range for system types.
4513 (Fx_create_frame, x_create_tip_frame, Fx_show_tip)
4514 (Fx_hide_tip, Fx_file_dialog, Fx_select_font):
4515 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
4516 (Fx_change_window_property): Don't assume fixnums fit in int.
4517 * xfont.c (xfont_chars_supported):
4518 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
4519 * xmenu.c (Fx_popup_dialog, set_frame_menubar)
4520 (create_and_show_popup_menu, create_and_show_dialog, xmenu_show):
4521 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
4522 * xml.c (parse_region):
4523 * xrdb.c (magic_file_p):
4524 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
4525 * xselect.c (TRACE1): Don't assume pid_t promotes to int.
4526 (x_get_local_selection, x_reply_selection_request)
4527 (x_handle_selection_request, wait_for_property_change):
4528 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
4529 (selection_data_to_lisp_data): Use short, not EMACS_INT, where
4530 short is wide enough.
4531 (x_send_client_event): Don't assume fixnum fits in int.
4532 * xterm.c (x_x_to_emacs_modifiers):
4533 Don't assume EMACS_INT overflows nicely into int.
4534 (x_emacs_to_x_modifiers): Use EMACS_INT, not int, because values
4535 may come from Lisp.
4536 (handle_one_xevent): NATNUMP can eval its arg twice.
4537 (x_connection_closed):
4538 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
4539 * xterm.h: Adjust decls to match defn changes elsewhere.
4540 (struct scroll_bar): Use struct vectorlike_header
4541 rather than rolling our own approximation.
4542 (SCROLL_BAR_VEC_SIZE): Remove; not used.
4543
c6574eb5
GM
45442012-05-25 Glenn Morris <rgm@gnu.org>
4545
4546 * lisp.mk (lisp): Update for more files being compiled now.
4547
e8d32c7e
SM
45482012-05-25 Stefan Monnier <monnier@iro.umontreal.ca>
4549
48def666
SM
4550 * lread.c: Remove `read_pure' which makes no difference.
4551 (read_pure): Remove var.
4552 (unreadpure): Remove function.
4553 (readevalloop): Don't call read_list with -1 flag.
4554 (read1, read_vector): Don't test read_pure any more.
4555 (read_list): Simplify.
4556
e8d32c7e
SM
4557 * fileio.c, character.h: Minor style tweaks.
4558
4b2addb7
DA
45592012-05-24 Dmitry Antipov <dmantipov@yandex.ru>
4560
4561 * window.h (clip_changed): Remove useless declaration.
4562
584461b2
JB
45632012-05-22 Juanma Barranquero <lekktu@gmail.com>
4564
4565 * makefile.w32-in: Follow-up to 2012-05-22T16:20:27Z!eggert@cs.ucla.edu.
4566 (TAGS, TAGS-gmake, CONFIG_H): Remove further references to m/intel386.h.
4567
34374650
PE
45682012-05-22 Paul Eggert <eggert@cs.ucla.edu>
4569
4570 Remove src/m/*.
4571 This directory predates autoconf and is no longer needed nowadays.
4572 Move its few remaining bits of functionality to where they're needed.
4573 * m/README, m/alpha.h, m/amdx86-64.h, m/ia64.h, m/ibmrs6000.h:
4574 * m/ibms390x.h, m/intel386.h, m/m68k.h, m/macppc.h, m/sparc.h:
4575 * m/template.h: Remove.
4576 * Makefile.in (M_FILE): Remove. All uses removed.
4577 * alloc.c (POINTERS_MIGHT_HIDE_IN_OBJECTS):
4578 * lisp.h (USE_LSB_TAG):
4579 * mem-limits.h (EXCEEDS_LISP_PTR):
4580 Use VAL_MAX, not VALBITS, in #if.
4581 * lisp.h (EMACS_INT_MAX): New macro, useful in #if.
4582 (EMACS_UINT): Define unconditionally now.
4583 (BITS_PER_CHAR, BITS_PER_SHORT, BITS_PER_INT, BITS_PER_LONG)
4584 (BITS_PER_EMACS_INT): New constants, replacing
4585 what used to be in config.h, but not useful in #if.
4586 (GCTYPEBITS, VALBITS): Define unconditionally, since m/* files don't
4587 define them any more.
4588 (VAL_MAX): New macro.
4589 (VALMASK): Use it.
4590 * puresize.h (PURESIZE_RATIO): Use EMACS_INT_MAX, not
4591 BITS_PER_EMACS_INT, in #if.
4592 * s/aix4-2.h (BROKEN_FIONREAD, BROKEN_SIGAIO, BROKEN_SIGPTY)
4593 (BROKEN_SIGPOLL): Move here from m/ibmrs6000.h, which was removed.
4594 * s/gnu-linux.h (ULIMIT_BREAK_VALUE) [__i386__]:
4595 * s/ms-w32.h (DATA_START):
4596 Move here from removed file m/intel386.h.
4597 * s/gnu.h (NLIST_STRUCT): Remove undef; 'configure' does this.
4598 * s/irix6-5.h (_LP64): Remove; lisp.h no longer needs this.
4599
261cb4bb
PE
46002012-05-21 Paul Eggert <eggert@cs.ucla.edu>
4601
4602 Assume C89 or later.
4603 * alloc.c, buffer.c, lisp.h: Replace POINTER_TYPE with void.
4604 * alloc.c (overrun_check_malloc, overrun_check_realloc, xmalloc)
4605 (xrealloc):
4606 * buffer.c (mmap_free_1, mmap_enlarge): Omit needless casts.
4607 * editfns.c, fns.c, gmalloc.c, insdel.c, sysdep.c, termcap.c (NULL):
4608 * textprop.c, tparam.c (NULL): Remove.
4609 * ralloc.c, vm-limit.c (POINTER): Assume void * works.
4610 * regex.c (SIGN_EXTEND_CHAR): Assume signed char works.
4611 * regex.h (_RE_ARGS): Remove. All uses rewritten to use prototypes.
4612 * unexelf.c (ElfBitsW): Assume c89 preprocessor or better.
4613 * xterm.c (input_signal_count): Assume volatile works.
4614
ff23cd9f
KB
46152012-05-21 Ken Brown <kbrown@cornell.edu>
4616
4617 * xgselect.c (xg_select): Fix first argument in call to 'select'
4618 (bug#11508).
4619
1b170bc6
KB
46202012-05-20 Ken Brown <kbrown@cornell.edu>
4621
4622 * gmalloc.c (_free_internal_nolock, _realloc_internal_nolock)
bd7239f5 4623 [CYGWIN]: Cast ptr to (char *) before comparing to _heapbase.
1b170bc6 4624
b2f4d39f
KB
46252012-05-19 Ken Brown <kbrown@cornell.edu>
4626
4627 * xfns.c (x_in_use): Remove `static' qualifier.
4628 * xterm.h (x_in_use): Declare.
4629 * xgselect.c: Include xterm.h.
4630 (xg_select): Test `x_in_use' instead of `inhibit_window_system'
4631 and `display_arg' (bug#9754).
4632
003fdae2
PE
46332012-05-19 Paul Eggert <eggert@cs.ucla.edu>
4634
9232a6d9
PE
4635 * s/ms-w32.h (HAVE_GETDOMAINNAME): Remove; not needed.
4636
003fdae2
PE
4637 * m/vax.h: Remove; no longer needed since HAVE_FTIME is being removed.
4638 * s/ms-w32.h (HAVE_FTIME): Remove; not needed.
4639
784b56e2
EZ
46402012-05-18 Eli Zaretskii <eliz@gnu.org>
4641
4642 Fix compilation with -DGLYPH_DEBUG=1 on MS-Windows.
4643
4644 * w32term.c [GLYPH_DEBUG]: Add prototype for x_check_font.
090bd7cb 4645 (x_check_font) [GLYPH_DEBUG]: New function, copied from xterm.c.
784b56e2
EZ
4646
4647 * w32fns.c (unwind_create_frame) [GLYPH_DEBUG]: Fix broken
4648 reference to image_cache->refcount.
4649 (x_create_tip_frame): Fix broken use of FRAME_IMAGE_CACHE.
4650
a0a79cde
JL
46512012-05-17 Juri Linkov <juri@jurta.org>
4652
4653 * search.c (Fword_search_regexp, Fword_search_backward)
4654 (Fword_search_forward, Fword_search_backward_lax)
4655 (Fword_search_forward_lax): Move functions to isearch.el
4656 (bug#10145, bug#11381).
4657
b0572523
PE
46582012-05-16 Paul Eggert <eggert@cs.ucla.edu>
4659
4660 * xgselect.c (xg_select): Just invoke 'select' if -nw (Bug#9754).
4661
9660f5fc
SM
46622012-05-15 Stefan Monnier <monnier@iro.umontreal.ca>
4663
4664 * lread.c (init_obarray): Declare Qt and Qnil as special.
4665
4374de83
GM
46662012-05-14 Glenn Morris <rgm@gnu.org>
4667
4668 * nsterm.m (ns_init_paths): Fix typo ("libexec" not "lib-exec").
985584ae 4669 Put "libexec" before "bin", for the sake of init_callproc_1.
4374de83 4670
dc44c39a
PE
46712012-05-14 Paul Eggert <eggert@cs.ucla.edu>
4672
078c97cb
PE
4673 * keyboard.c (kbd_buffer_get_event) [!HAVE_DBUS]: Omit unused local.
4674
dc44c39a
PE
4675 * unexaix.c: Port to more-recent AIX compilers.
4676 (report_error, report_error_1, make_hdr, copy_sym)
4677 (mark_x, adjust_lnnoptrs, unrelocate_symbols):
4678 Make arguments const char *, not char *, to avoid violations of C
4679 standard and to fix some AIX warnings reported by Gilles Pion.
4680
e18afed7 46812012-05-14 Eli Zaretskii <eliz@gnu.org>
ac268e67
EZ
4682
4683 * xdisp.c (handle_stop): Don't call get_overlay_strings_1 if we
4684 already have overlays loaded.
4685 (handle_single_display_spec): Before returning without displaying
4686 fringe bitmap, synchronize the bidi iterator with the main display
4687 iterator, by calling iterate_out_of_display_property.
4688 (iterate_out_of_display_property): Detect buffer iteration by
4689 testing that it->string is a Lisp string.
4690 (get_next_display_element): When the current object is exhausted,
4691 and there's something on it->stack, call set_iterator_to_next to
4692 proceed with what's on the stack, instead of returning zero.
4693 (set_iterator_to_next): If called at the end of a Lisp string,
4694 proceed to consider_string_end without incrementing string
4695 position. Don't increment display vector index past the end of
4696 the display vector. (Bug#11417)
c8fb9dc6
EZ
4697 (pos_visible_p): Don't report a position visible when move_it_to
4698 stopped at the last line of window, which happens to be scanned
4699 backwards by the bidi iteration. (Bug#11464)
ac268e67 4700
e18afed7 47012012-05-14 Eli Zaretskii <eliz@gnu.org>
82f9b393
EZ
4702
4703 * xdisp.c (handle_single_display_spec): Return 1 for left-margin
4704 and right-margin display specs even if the spec is invalid or we
61b108cc
SM
4705 are on a TTY, and thus unable to display on the fringes.
4706 That's because the text with the property will not be displayed anyway,
82f9b393
EZ
4707 so we need to signal to the caller that this is a "replacing"
4708 display spec. This fixes display when the spec is invalid or we
4709 are on a TTY.
4710
e18afed7 47112012-05-14 Paul Eggert <eggert@cs.ucla.edu>
297834cd
PE
4712
4713 * unexaix.c (make_hdr): Fix typo in prototype.
4714 This bug broke the build on AIX. Problem reported by Gilles Pion.
4715
9d0a235a
MA
47162012-05-14 Michael Albinus <michael.albinus@gmx.de>
4717
4718 * keyboard.c (kbd_buffer_get_event): Read special events also in
4719 batch mode. (Bug#11415)
4720
9e6b06ed
GM
47212012-05-12 Glenn Morris <rgm@gnu.org>
4722
4723 * ns.mk: Update for ns_appbindir no longer having trailing "/".
4724
c1a1d7a3
EZ
47252012-05-12 Eli Zaretskii <eliz@gnu.org>
4726
4727 * lisp.mk (lisp): Add newcomment.elc.
4728
3fe7cdc8
GM
47292012-05-12 Glenn Morris <rgm@gnu.org>
4730
4731 * Makefile.in (MKDIR_P): New, set by configure.
4732 * ns.mk (${ns_appdir}, ${ns_appbindir}Emacs): Use $MKDIR_P.
4733
53f7d2c0
PE
47342012-05-11 Paul Eggert <eggert@cs.ucla.edu>
4735
4736 Remove unused function hourglass_started.
4737 * dispextern.h (hourglass_started):
4738 * w32fns.c (hourglass_started):
4739 * xdisp.c (hourglass_started): Remove.
4740
75aafb17
JB
47412012-05-10 Juanma Barranquero <lekktu@gmail.com>
4742
4743 * makefile.w32-in ($(BLD)/gmalloc.$(O), $(BLD)/w32menu.$(O)):
4744 Update dependencies.
4745
12959e8e
PE
47462012-05-10 Paul Eggert <eggert@cs.ucla.edu>
4747
97107e2e
PE
4748 * xgselect.c (xg_select): Put maxfds+1 into a var.
4749 This is slightly clearer, and pacifies Ubuntu 12.04 gcc.
4750
12959e8e
PE
4751 * sound.c (DEFAULT_ALSA_SOUND_DEVICE): Define only if HAVE_ALSA.
4752
836d29b3
DA
47532012-05-10 Dave Abrahams <dave@boostpro.com>
4754
4755 * filelock.c (syms_of_filelock): New boolean create-lockfiles.
4756 (lock_file): If create_lockfiles is 0, do nothing. (Bug#11227)
4757
5cb67954
MA
47582012-05-09 Michael Albinus <michael.albinus@gmx.de>
4759
4760 * dbusbind.c (xd_registered_buses): New internal Lisp object.
4761 Rename all occurences of Vdbus_registered_buses to xd_registered_buses.
4762 (syms_of_dbusbind): Remove declaration of Vdbus_registered_buses.
4763 Initialize xd_registered_buses.
4764
3478ec45
PE
47652012-05-09 Paul Eggert <eggert@cs.ucla.edu>
4766
b263a6b0
PE
4767 Untag more efficiently if USE_LSB_TAG.
4768 This is based on a proposal by YAMAMOTO Mitsuharu in
4769 <http://lists.gnu.org/archive/html/emacs-devel/2008-01/msg01876.html>.
4770 For an admittedly artificial (nth 8000 longlist) benchmark on
4771 Fedora 15 x86-64, this yields a 25% CPU speedup. Also, it shrinks
4772 Emacs's overall text size by 1%.
4773 * lisp.h (XUNTAG): New macro.
4774 (XCONS, XVECTOR, XSTRING, XSYMBOL, XFLOAT, XMISC, XPROCESS, XWINDOW)
4775 (XTERMINAL, XSUBR, XBUFFER, XCHAR_TABLE, XSUB_CHAR_TABLE, XBOOL_VECTOR)
4776 (XSETTYPED_PSEUDOVECTOR, XHASH_TABLE, TYPED_PSEUDOVECTORP): Use it.
4777 * eval.c (Fautoload):
4778 * font.h (XFONT_SPEC, XFONT_ENTITY, XFONT_OBJECT):
4779 * frame.h (XFRAME): Use XUNTAG.
4780
3478ec45
PE
4781 Port recent dbusbind.c changes to 32-bit --with-wide-int.
4782 * dbusbind.c (xd_append_arg, xd_retrieve_arg, Fdbus_message_internal):
4783 Remove unportable assumptions about print widths of types like
4784 dbus_uint32_t.
4785 (xd_get_connection_address, Fdbus_init_bus): Cast Emacs integer to
4786 intptr_t when converting between pointer and integer, to avoid GCC
4787 warnings about wrong width.
4788
666b903b 47892012-05-09 Eli Zaretskii <eliz@gnu.org>
0d887c7d
EZ
4790
4791 * w32proc.c (new_child): Force Windows to reserve only 64KB of
4792 stack for each reader_thread, instead of defaulting to 8MB
4793 determined by the linker. This avoids failures in creating
4794 subprocesses on Windows 7, see the discussion in this thread:
4795 http://lists.gnu.org/archive/html/emacs-devel/2012-03/msg00119.html.
4796
b120cc17
JC
47972012-05-07 Jérémy Compostella <jeremy.compostella@gmail.com>
4798
4799 Fix up display of the *Minibuf-0* buffer in the mini window.
4800 * keyboard.c (read_char): Don't clear the echo area if there's no
4801 message to clear.
4802 * xdisp.c (redisplay_internal): Redisplay the mini window (with the
2fed2689 4803 contents of *Minibuf-0*) if there's no message displayed in its stead.
b120cc17 4804
9a4b36f8
MA
48052012-05-07 Michael Albinus <michael.albinus@gmx.de>
4806
4807 * dbusbind.c (XD_DEBUG_MESSAGE): Don't print message twice in
4808 batch mode.
4809
e5f9458f
CY
48102012-05-06 Chong Yidong <cyd@gnu.org>
4811
4812 * lisp.mk (lisp): Update.
4813
eceeb5fc 48142012-05-05 Jim Meyering <meyering@redhat.com>
bf98199c
JM
4815
4816 * w32font.c (fill_in_logfont): NUL-terminate a string (Bug#11372).
4817
71873e2b
SM
48182012-05-04 Stefan Monnier <monnier@iro.umontreal.ca>
4819
4820 * data.c (PUT_ERROR): New macro.
4821 (syms_of_data): Use it. Add new error type `user-error'.
4822 * undo.c (user_error): New function.
4823 (Fprimitive_undo): Use it.
4824 * print.c (print_error_message): Adjust print style for `user-error'.
4825 * keyboard.c (user_error): New function.
4826 (Fexit_recursive_edit, Fabort_recursive_edit): Use it.
4827
ab0fa4e4
PE
48282012-05-03 Paul Eggert <eggert@cs.ucla.edu>
4829
4830 Do not limit current-time-string to years 1000..9999.
4831 * editfns.c (TM_YEAR_IN_ASCTIME_RANGE): Remove.
4832 (Fcurrent_time_string): Support any year that is supported by the
4833 underlying localtime representation. Don't use asctime, as it
4834 has undefined behavior for years outside the range -999..9999.
4835
7ed806a7
PE
48362012-05-02 Paul Eggert <eggert@cs.ucla.edu>
4837
4838 Fix race conditions involving setenv, gmtime, localtime, asctime.
4839 Without this fix, interrupts could mess up code that uses these
4840 nonreentrant functions, since setting TZ invalidates existing
4841 tm_zone or tzname values, and since most of these functions return
4842 pointers to static storage.
4843 * editfns.c (format_time_string, Fdecode_time, Fencode_time)
4844 (Fcurrent_time_string, Fcurrent_time_zone, Fset_time_zone_rule):
4845 Grow the critical sections to include not just invoking
4846 localtime/gmtime, but also accessing these functions' results
4847 including their tm_zone values if any, and any related TZ setting.
4848 (format_time_string): Last arg is now struct tm *, not struct tm **,
71873e2b
SM
4849 so that the struct tm is saved in the critical section.
4850 All callers changed. Simplify allocation of initial buffer, partly
7ed806a7
PE
4851 motivated by the fact that memory allocation needs to be outside
4852 the critical section.
4853
0c16dfed
DA
48542012-05-02 Dmitry Antipov <dmantipov@yandex.ru>
4855
4856 * intervals.c (adjust_intervals_for_insertion): Initialize `newi'
4857 with RESET_INTERVAL.
4858
4859 * buffer.c (Fget_buffer_create, Fmake_indirect_buffer):
4860 Remove duplicated buffer name initialization.
4861
3f83ace8
JM
48622012-05-02 Jim Meyering <jim@meyering.net>
4863
4864 * xterm.c (x_term_init): Use memcpy instead of strncpy (Bug#11373).
4865
c7b8541e
JM
4866 * xfns.c (x_window): Use xstrdup (Bug#11375).
4867
90207a15 48682012-05-02 Eli Zaretskii <eliz@gnu.org>
2fa85638
EZ
4869
4870 * xdisp.c (pos_visible_p): If already at a newline from the
4871 display string before the 'while' loop, don't walk back the glyphs
4872 from it3.glyph_row. Solves assertion violation when the display
4873 string begins with a newline (egg.el). (Bug#11367)
4874
b593d6a9
AH
48752012-05-01 Stefan Monnier <monnier@iro.umontreal.ca>
4876
4877 * keyboard.c (Fexecute_extended_command, Vsuggest_key_bindings):
4878 Move to simple.el.
4879
4737362e
GM
48802012-05-01 Glenn Morris <rgm@gnu.org>
4881
99cf43f9
GM
4882 * syssignal.h: Remove reference to BROKEN_SIGINFO (last used in
4883 s/ptx4.h), BROKEN_SIGTSTP (last used in m/ustation.h, m/dpx2.h),
4884 and BROKEN_SIGURG (was in s/gnu-linux.h prior to 2008-02-10).
4885 All were removed before 23.1.
4886
9311dcff
GM
4887 * dispnew.c: Remove HAVE_LIBNCURSES test;
4888 it is always true on relevant platforms.
4889
4d5c6349
GM
4890 * Makefile.in (LD_SWITCH_X_SITE_RPATH):
4891 Rename from LD_SWITCH_X_SITE_AUX_RPATH.
4892
4737362e
GM
4893 * Makefile.in (LD_SWITCH_X_SITE_AUX): Remove; no longer used.
4894
74dd3a6b
AS
48952012-04-30 Andreas Schwab <schwab@linux-m68k.org>
4896
4897 * .gdbinit (xpr): Remove checks for no longer existing misc types.
4898 (xintfwd, xboolfwd, xobjfwd, xbufobjfwd, xkbobjfwd, xbuflocal):
4899 Remove.
4900
13c379ee
PE
49012012-04-28 Paul Eggert <eggert@cs.ucla.edu>
4902
4903 Do not avoid creating empty evaporating overlays (Bug#9642).
4904 * buffer.c (Fmove_overlay): Revert the change of 2012-04-23.
4905 That is, do not delete an evaporating overlay if it becomes
4906 empty after its bounds are adjusted to fit within its buffer.
4907 This fix caused other problems, and I'm reverting it until we get
4908 to the bottom of them.
4909
a8e7d6d7 49102012-04-27 Chong Yidong <cyd@gnu.org>
9be2fd9b
CY
4911
4912 * xselect.c (x_convert_selection): Initialize a pointer (Bug#11315).
4913
a8e7d6d7 49142012-04-27 Eli Zaretskii <eliz@gnu.org>
f0ee99a0
EZ
4915
4916 * xdisp.c (pos_visible_p): If the window start position is beyond
4917 ZV, start the display from buffer beginning. Prevents assertion
4918 violation in init_iterator when the minibuffer window is scrolled
4919 via the scroll bar.
4920
4921 * window.c (window_scroll_pixel_based): Likewise.
4922
a8e7d6d7 49232012-04-27 Chong Yidong <cyd@gnu.org>
9ec7751f
CY
4924
4925 * keymap.c (where_is_internal): Doc fix (Bug#10872).
4926
a8e7d6d7 49272012-04-27 Glenn Morris <rgm@gnu.org>
24c51a09
GM
4928
4929 * fileio.c (Fcopy_file, Fset_file_selinux_context):
4930 Ignore ENOTSUP failures from setfilecon functions. (Bug#11245)
4931
a8e7d6d7 49322012-04-27 Eli Zaretskii <eliz@gnu.org>
73055685 4933
b593d6a9
AH
4934 * dispnew.c (swap_glyph_pointers, copy_row_except_pointers):
4935 Don't overrun array limits of glyph row's used[] array. (Bug#11288)
73055685 4936
1c6900d9
EZ
49372012-04-26 Eli Zaretskii <eliz@gnu.org>
4938
4c3fa1d9
EZ
4939 * xdisp.c (IT_DISPLAYING_WHITESPACE): In addition to the loaded
4940 display element, check also the underlying string or buffer
4941 character. (Bug#11341)
4942
1c6900d9
EZ
4943 * w32menu.c: Include w32heap.h.
4944 (add_menu_item): If the call to AppendMenuW (via
4945 unicode_append_menu) fails, disable Unicode menus only if we are
4946 running on Windows 9X/Me.
4947
42bf8205
AS
49482012-04-24 Andreas Schwab <schwab@linux-m68k.org>
4949
4950 * .gdbinit (xpr): Handle USE_2_TAGS_FOR_INTS.
4951 (xgetint): Add missing shift for LSB tags.
4952
b1bac16e
MR
49532012-04-24 Martin Rudalics <rudalics@gmx.at>
4954
4955 * keyboard.c (read_char): Don't wipe echo area for select window
4956 events: These might get delayed via `mouse-autoselect-window'
4957 (Bug#11304).
4958
d69621cc
JB
49592012-04-24 Juanma Barranquero <lekktu@gmail.com>
4960
4961 * gnutls.c (init_gnutls_functions): Protect against (unlikely)
4962 manipulation of :loaded-from data.
4963
02fd101b
JB
49642012-04-23 Juanma Barranquero <lekktu@gmail.com>
4965
4966 * gnutls.c (init_gnutls_functions): The value of :loaded-from is
4967 now a cons (bug#11311).
4968
888bec30
PE
49692012-04-23 Paul Eggert <eggert@cs.ucla.edu>
4970
89a438bd
PE
4971 Do not create empty overlays with the evaporate property (Bug#9642).
4972 * buffer.c (Fmove_overlay): Delete an evaporating overlay
4973 if it becomes empty after its bounds are adjusted to fit within
4974 its buffer. Without this fix, in a nonempty buffer (let ((o
4975 (make-overlay 1 2))) (overlay-put o 'evaporate t) (move-overlay o 0 1))
4976 yields an empty overlay that has the evaporate property, which is
4977 not supposed to happen.
4978
1068fe4d
PE
4979 Fix minor GTK3 problems found by static checking.
4980 * emacsgtkfixed.c (EMACS_TYPE_FIXED, EMACS_FIXED, EmacsFixed)
4981 (EmacsFixedPrivate, EmacsFixedClass, struct _EmacsFixed)
4982 (struct _EmacsFixedClass, emacs_fixed_get_type):
4983 Move decls here from emacsgtkfixed.h, since they needn't be public.
4984 (emacs_fixed_get_type): Now static.
4985 (emacs_fixed_class_init): Omit unused local.
4986 (emacs_fixed_child_type): Remove; unused.
4987 * emacsgtkfixed.h (EMACS_TYPE_FIXED, EMACS_FIXED, EmacsFixed)
4988 (EmacsFixedPrivate, EmacsFixedClass, struct _EmacsFixed)
4989 (struct _EmacsFixedClass): Move to emacsgtkfixed.c.
4990 (EMACS_FIXED_CLASS, EMACS_IS_FIXED, EMACS_IS_FIXED_CLASS)
4991 (EMACS_FIXED_GET_CLASS): Remove; unused.
4992 * gtkutil.c (xg_create_frame_widgets) [!HAVE_GTK3]: Omit unused local.
4993
888bec30
PE
4994 * keyboard.c (handle_async_input): Define only if SYNC_INPUT || SIGIO.
4995 Problem reported by Juanma Barranquero for Windows -Wunused-function.
4996
de85e130
PE
49972012-04-22 Paul Eggert <eggert@cs.ucla.edu>
4998
d0baac98 4999 Modernize and clean up gmalloc.c to assume C89 (Bug#9119).
bd7239f5 5000 * gmalloc.c (_MALLOC_INTERNAL, _MALLOC_H, _PP, __ptr_t)
d0baac98
PE
5001 (__malloc_size_t, __malloc_ptrdiff_t):
5002 Remove. All uses removed, replaced by the definiens if needed,
5003 since we can assume C89 or better now.
5004 Include <stdint.h>, for PTRDIFF_MAX, uintptr_t.
5005 (protect_malloc_state, align, get_contiguous_space)
5006 (malloc_atfork_handler_prepare, malloc_atfork_handler_parent)
5007 (malloc_atfork_handler_child, malloc_enable_thread)
5008 (malloc_initialize_1, __malloc_initialize, morecore_nolock)
5009 (_malloc_internal_nolock, _malloc_internal, malloc, _malloc)
5010 (_free, _realloc, _free_internal_nolock, _free_internal, free, cfree)
5011 (special_realloc, _realloc_internal_nolock, _realloc_internal)
5012 (realloc, calloc, __default_morecore, memalign, valloc, checkhdr)
5013 (freehook, mallochook, reallochook, mabort, mcheck, mprobe):
5014 Define using prototypes, not old style.
5015 (align, _malloc_internal_nolock, _free_internal_nolock, memalign):
5016 Don't assume ptrdiff_t and uintptr_t are no wider than unsigned long.
5017 (align): Don't assume that signed integer overflow wraps around.
5018 Omit unused local var.
5019 (malloc_initialize_1, morecore_nolock, _malloc_internal_nolock)
5020 (_free_internal_nolock, memalign, mallochook, reallochook):
5021 Omit no-longer-needed casts.
5022 (valloc): Use getpagesize, not __getpagesize.
5023 (MAGICWORD, MAGICFREE): Now randomish size_t values, not 32-bit.
5024 (struct hdr): The 'magic' member is now size_t, not unsigned long.
5025
de85e130
PE
5026 * dbusbind.c (XD_DBUS_VALIDATE_OBJECT): Define only if needed.
5027
dcbf5805
MA
50282012-04-22 Michael Albinus <michael.albinus@gmx.de>
5029
5030 Move functions from C to Lisp. Make non-blocking method calls
5031 the default. Implement further D-Bus standard interfaces.
5032
5033 * dbusbind.c (DBUS_NUM_MESSAGE_TYPES): Declare.
5034 (QCdbus_request_name_allow_replacement)
5035 (QCdbus_request_name_replace_existing)
5036 (QCdbus_request_name_do_not_queue)
5037 (QCdbus_request_name_reply_primary_owner)
5038 (QCdbus_request_name_reply_in_queue)
5039 (QCdbus_request_name_reply_exists)
5040 (QCdbus_request_name_reply_already_owner): Move to dbus.el.
5041 (QCdbus_registered_serial, QCdbus_registered_method)
5042 (QCdbus_registered_signal): New Lisp objects.
5043 (XD_DEBUG_MESSAGE): Use sizeof.
5044 (XD_MESSAGE_TYPE_TO_STRING, XD_OBJECT_TO_STRING)
5045 (XD_DBUS_VALIDATE_BUS_ADDRESS, XD_DBUS_VALIDATE_OBJECT)
5046 (XD_DBUS_VALIDATE_BUS_NAME, XD_DBUS_VALIDATE_PATH)
5047 (XD_DBUS_VALIDATE_INTERFACE, XD_DBUS_VALIDATE_MEMBER): New macros.
5048 (XD_CHECK_DBUS_SERIAL): Rename from CHECK_DBUS_SERIAL_GET_SERIAL.
5049 (xd_signature, xd_append_arg): Allow float for integer types.
5050 (xd_get_connection_references): New function.
b593d6a9
AH
5051 (xd_get_connection_address): Rename from xd_initialize.
5052 Return cached address.
dcbf5805
MA
5053 (xd_remove_watch): Do not unset $DBUS_SESSION_BUS_ADDRESS.
5054 (xd_close_bus): Rename from Fdbus_close_bus. Not needed on Lisp
5055 level.
5056 (Fdbus_init_bus): New optional arg PRIVATE. Cache address.
9a4b36f8 5057 Return number of refcounts.
dcbf5805
MA
5058 (Fdbus_get_unique_name): Make stronger parameter check.
5059 (Fdbus_message_internal): New defun.
5060 (Fdbus_call_method, Fdbus_call_method_asynchronously)
5061 (Fdbus_method_return_internal, Fdbus_method_error_internal)
5062 (Fdbus_send_signal, Fdbus_register_service)
5063 (Fdbus_register_signal, Fdbus_register_method): Move to dbus.el.
5064 (xd_read_message_1): Obey new structure of Vdbus_registered_objects.
5065 (xd_read_queued_messages): Obey new structure of Vdbus_registered_buses.
5066 (Vdbus_compiled_version, Vdbus_runtime_version)
5067 (Vdbus_message_type_invalid, Vdbus_message_type_method_call)
5068 (Vdbus_message_type_method_return, Vdbus_message_type_error)
5069 (Vdbus_message_type_signal): New defvars.
b593d6a9
AH
5070 (Vdbus_registered_buses, Vdbus_registered_objects_table):
5071 Adapt docstring.
dcbf5805 5072
52828e02
PE
50732012-04-22 Paul Eggert <eggert@cs.ucla.edu>
5074
da05bc4c
PE
5075 Fix GC_MALLOC_CHECK debugging output on 64-bit hosts.
5076 * alloc.c (emacs_blocked_malloc) [GC_MALLOC_CHECK]:
5077 Do not assume ptrdiff_t is the same width as 'int'.
5078
52828e02
PE
5079 * alloc.c: Handle unusual debugging option combinations.
5080 (GC_CHECK_MARKED_OBJECTS): Undef if ! GC_MARK_STACK,
5081 since the two debugging options are incompatible.
5082 (GC_MALLOC_CHECK): Similarly, undef if GC_CHECK_MARKED_OBJECTS
5083 is defined.
5084 (mem_init, mem_insert, mem_insert_fixup):
5085 Define if GC_MARK_STACK || GC_MALLOC_CHECK.
5086 (NEED_MEM_INSERT): Remove; no longer needed.
5087
f01769f9
LL
50882012-04-22 Leo Liu <sdl.web@gmail.com>
5089
5090 * sysdep.c (list_system_processes): Support Darwin (Bug#5725).
5091
5790543d
PE
50922012-04-22 Paul Eggert <eggert@cs.ucla.edu>
5093
5094 * sysdep.c [__FreeBSD__]: Minor cleanups.
5095 (list_system_processes, system_process_attributes) [__FreeBSD__]:
5096 Use Emacs indenting style more consistently. Avoid some casts.
5097 Use 'double' consistently rather than mixing 'float' and 'double'.
5098
b91b7e4d
EW
50992012-04-21 Eduard Wiebe <usenet@pusto.de>
5100
b593d6a9
AH
5101 * sysdep.c (list_system_processes, system_process_attributes):
5102 Add implementation for FreeBSD (Bug#5243).
b91b7e4d 5103
6114eb15
AS
51042012-04-21 Andreas Schwab <schwab@linux-m68k.org>
5105
5106 * lisp.mk (lisp): Update.
5107
2f38dff7
PE
51082012-04-20 Paul Eggert <eggert@cs.ucla.edu>
5109
5110 * keyboard.c (process_pending_signals): Define only if SYNC_INPUT.
5111 It is never used otherwise.
5112
4ae29f89
SM
51132012-04-20 Stefan Monnier <monnier@iro.umontreal.ca>
5114
5115 * print.c (print_preprocess): Only check print_depth if print-circle
5116 is nil.
5117 (print_object): Check for cycles even when print-circle is nil and
5118 print-gensym is t, but only check print_depth if print-circle is nil.
5119
f30d612a
CY
51202012-04-20 Chong Yidong <cyd@gnu.org>
5121
5122 * process.c (wait_reading_process_output): If EIO occurs on a pty,
5123 set the status to "failed" and ensure that sentinel is run.
5124
c07a4c0b 51252012-04-20 Glenn Morris <rgm@gnu.org>
016a35df
GM
5126
5127 * process.c (Fset_process_inherit_coding_system_flag)
5128 (Fset_process_query_on_exit_flag): Doc fix (mention return value).
4373fd43 5129 (Fmake_network_process, Fmake_serial_process): Doc fix.
016a35df 5130
c07a4c0b 51312012-04-20 Eli Zaretskii <eliz@gnu.org>
20a68157
EZ
5132
5133 * xdisp.c (string_buffer_position_lim): Limit starting position to
5134 BEGV.
5135 (set_cursor_from_row): If called for a mode-line or header-line
5136 row, return zero immediately.
5137 (try_cursor_movement): If inside continuation line, don't back up
4ae29f89
SM
5138 farther than the first row after the header line, if any.
5139 Don't consider the header-line row as "partially visible", even if
20a68157
EZ
5140 MATRIX_ROW_PARTIALLY_VISIBLE_P returns non-zero. (Bug#11261)
5141
c07a4c0b 51422012-04-20 Atsuo Ohki <ohki@gssm.otsuka.tsukuba.ac.jp> (tiny change)
ad3a2b41 5143
4ae29f89
SM
5144 * lread.c (lisp_file_lexically_bound_p): Fix hang at ";-*-\n"
5145 (bug#11238).
ad3a2b41 5146
c07a4c0b 51472012-04-20 Teodor Zlatanov <tzz@lifelogs.com>
6c94c34f 51482012-04-18 Paul Eggert <eggert@cs.ucla.edu>
ae6e112d
PE
5149
5150 configure: new option --enable-gcc-warnings (Bug#11207)
5151 * Makefile.in (C_WARNINGS_SWITCH): Remove.
5152 (WARN_CFLAGS, WERROR_CFLAGS): New macros.
5153 (ALL_CFLAGS): Use new macros rather than old.
5154 * process.c: Ignore -Wstrict-overflow to work around GCC bug 52904.
5155 * regex.c: Ignore -Wstrict-overflow. If !emacs, also ignore
5156 -Wunused-but-set-variable, -Wunused-function, -Wunused-macros,
5157 -Wunused-result, -Wunused-variable. This should go away once
5158 the Emacs and Gnulib regex code is merged.
5159 (xmalloc, xrealloc): Now static.
5160
aba027e8
PE
51612012-04-17 Paul Eggert <eggert@cs.ucla.edu>
5162
5163 * dired.c (Fsystem_groups): Remove unused local.
5164
e5a36063
GM
51652012-04-17 Glenn Morris <rgm@gnu.org>
5166
5167 * dired.c (Fsystem_users): Doc fix.
5168
316411f0
DA
51692012-04-17 Dmitry Antipov <dmantipov@yandex.ru>
5170
5171 * dired.c (Fsystem_users, Fsystem_groups): New functions. (Bug#7900)
5172 (syms_of_dired): Add them.
5173
9426aba4
PE
51742012-04-16 Paul Eggert <eggert@cs.ucla.edu>
5175
b62a57be
PE
5176 Fix minor alloc.c problems found by static checking.
5177 * alloc.c (_malloc_internal, _free_internal) [!DOUG_LEA_MALLOC]:
5178 New extern decls, to avoid calling undeclared functions.
5179 (dont_register_blocks): Define if ((!SYSTEM_MALLOC && !SYNC_INPUT)
5180 && GC_MALLOC_CHECK), not if ((GC_MARK_STACK || defined
5181 GC_MALLOC_CHECK) && GC_MALLOC_CHECK), to match when it's used.
5182 (NEED_MEM_INSERT): New macro.
5183 (mem_insert, mem_insert_fixup) [!NEED_MEM_INSERT]: Remove; unused.
4b5afbb0 5184 Remove one incorrect comment and fix another.
b62a57be 5185
3539f31f
PE
5186 Fix minor ralloc.c problems found by static checking.
5187 See http://lists.gnu.org/archive/html/emacs-devel/2011-12/msg00720.html
5188 * ralloc.c (ALIGNED, ROUND_TO_PAGE, HEAP_PTR_SIZE)
5189 (r_alloc_size_in_use, r_alloc_freeze, r_alloc_thaw): Remove; unused.
5190 (r_alloc_sbrk): Now static.
5191
a041960a
PE
5192 Improve ralloc.c interface checking.
5193 See http://lists.gnu.org/archive/html/emacs-devel/2011-12/msg00720.html
5194 * buffer.c (ralloc_reset_variable, r_alloc, r_re_alloc)
5195 (r_alloc_free) [REL_ALLOC]: Move decls from here ...
5196 * lisp.h (r_alloc, r_alloc_free, r_re_alloc, r_alloc_reset_variable)
5197 [REL_ALLOC]: ... to here, to check interface.
5198 * m/ia64.h (r_alloc, r_alloc_free) [REL_ALLOC && !_MALLOC_INTERNAL]:
5199 Remove decls. This fixes an "It stinks!".
5200
9426aba4
PE
5201 * alloc.c (which_symbols): Fix alignment issue / type clash.
5202
d55c12ed
AS
52032012-04-15 Andreas Schwab <schwab@linux-m68k.org>
5204
5205 * lisp.h (struct Lisp_Symbol): Remove explicit padding.
5206 (struct Lisp_Misc_Any): Likewise.
5207 (struct Lisp_Free): Likewise.
5208 * alloc.c (union aligned_Lisp_Symbol): Define.
5209 (SYMBOL_BLOCK_SIZE, struct symbol_block): Use union
5210 aligned_Lisp_Symbol instead of struct Lisp_Symbol.
5211 (union aligned_Lisp_Misc): Define.
5212 (MARKER_BLOCK_SIZE, struct marker_block): Use union
5213 aligned_Lisp_Misc instead of union Lisp_Misc.
4ae29f89 5214 (Fmake_symbol, allocate_misc, gc_sweep): Adjust.
d55c12ed 5215
b948ce8b
PE
52162012-04-14 Paul Eggert <eggert@cs.ucla.edu>
5217
5218 Make GC_MAKE_GCPROS_NOOPS the default (Bug#9926).
5219 * lisp.h (GC_MARK_STACK): Default to GC_MAKE_GCPROS_NOOPS.
5220 * s/cygwin.h, s/darwin.h, s/freebsd.h, s/gnu.h, s/irix6-5.h, s/msdos.h:
5221 * s/netbsd.h, s/sol2-6.h:
5222 Remove definition of GC_MARK_STACK, since the default now works.
5223 * s/aix4-2.h, s/hpux10-20.h, s/unixware.h:
5224 Define GC_MARK_STACK to GC_USE_GCPROS_AS_BEFORE, since that's
5225 no longer the default.
5226 * s/gnu-linux.h (GC_MARK_STACK): Adjust to change in default.
5227
35dc09a1 52282012-04-14 Atsuo Ohki <ohki@gssm.otsuka.tsukuba.ac.jp> (tiny change)
ad3a2b41 5229
35dc09a1
GM
5230 * lread.c (lisp_file_lexically_bound_p):
5231 Fix hang at ";-*-\n" (bug#11238).
ad3a2b41 5232
35dc09a1
GM
52332012-04-14 Eli Zaretskii <eliz@gnu.org>
5234
5235 * xdisp.c (find_last_unchanged_at_beg_row): Don't consider a row
5236 "unchanged" if its end.pos is beyond ZV. (Bug#11199)
5237
52382012-04-14 Jan Djärv <jan.h.d@swipnet.se>
5239
5240 * nsterm.m (constrainFrameRect): Always constrain when there is only
5241 one screen (Bug#10962).
5242
bcd86815
KB
52432012-04-13 Ken Brown <kbrown@cornell.edu>
5244
5245 * s/cygwin.h (PTY_OPEN): Don't try to close a bogus file descriptor.
5246
c25df26e
RT
52472012-04-13 Reuben Thomas <rrt@sc3d.org>
5248
5249 * indent.c (Fmove_to_column): Change interactive spec (Bug#739).
5250
0fc59f1e
DC
52512012-04-11 Daniel Colascione <dancol@dancol.org>
5252
5253 * s/cygwin.h: The vfork the #define in cygwin.h was protecting
5254 against is gone. It's better to use vfork now so that when Cygwin
5255 gains a new, working vfork, we use it automatically (bug#10398).
5256
de8c03dc
SM
52572012-04-11 Stefan Monnier <monnier@iro.umontreal.ca>
5258
5259 * window.c (save_window_save): Obey window-point-insertion-type.
5260
2f097256
GM
52612012-04-11 Glenn Morris <rgm@gnu.org>
5262
5263 * Makefile.in (GNUSTEP_CFLAGS): Rename from C_SWITCH_X_SYSTEM.
5264
453b951e
SM
52652012-04-11 Stefan Monnier <monnier@iro.umontreal.ca>
5266
5267 * alloc.c (lisp_align_malloc): Remove unneeded prototype.
5268
75f1671a 52692012-04-10 Jason S. Cornez <jcornez@ravenpack.com> (tiny change)
6bbef4e5
JC
5270
5271 * keyboard.c: Override inhibit-quit after the third C-g (bug#6585).
5272 (force_quit_count): New var.
5273 (handle_interrupt): Use it.
5274
2a8ce227
JB
52752012-04-10 Juanma Barranquero <lekktu@gmail.com>
5276
5277 * w32.c (w32_delayed_load): Record the full path of the library
5278 being loaded (bug#10424).
5279
935396c0
GM
52802012-04-09 Glenn Morris <rgm@gnu.org>
5281
05920a43
GM
5282 * doc.c (Fsnarf_documentation): Check variables, functions are bound,
5283 not just in the obarray, before snarfing them. (Bug#11036)
5284
935396c0
GM
5285 * Makefile.in ($(leimdir)/leim-list.el):
5286 Pass EMACS rather than BUILT_EMACS.
5287
a18ecafa
TZ
52882012-04-09 Teodor Zlatanov <tzz@lifelogs.com>
5289
5290 * process.c (make_process):
5291 * process.h: Add integer `gnutls_handshakes_tried' member to
5292 process struct.
5293
6bbef4e5
JC
5294 * gnutls.h: Add `GNUTLS_EMACS_HANDSHAKES_LIMIT' upper limit.
5295 Add convenience `GNUTLS_LOG2i' macro.
a18ecafa
TZ
5296
5297 * gnutls.c (gnutls_log_function2i): Convenience log function.
5298 (emacs_gnutls_read): Use new log functions,
5299 `gnutls_handshakes_tried' process member, and
5300 `GNUTLS_EMACS_HANDSHAKES_LIMIT' to limit the number of handshake
5301 attempts per process (connection).
5302
b4d3bc10
CY
53032012-04-09 Chong Yidong <cyd@gnu.org>
5304
5305 * eval.c (Fuser_variable_p, user_variable_p_eh)
5306 (lisp_indirect_variable): Functions deleted.
5307 (Fdefvar): Caller changed.
5308
5309 * callint.c (Finteractive, Fcall_interactively):
5310 * minibuf.c (Fread_variable): Callers changed.
5311
70f4d973
EZ
53122012-04-09 Eli Zaretskii <eliz@gnu.org>
5313
5314 * xdisp.c (set_cursor_from_row): If the display string appears in
5315 the buffer at position that is closer to point than the position
5316 after the display string, display the cursor on the first glyph of
5317 the display string. Fixes cursor display when a 'display' text
5318 property immediately follows invisible text. (Bug#11094)
5319
cb3c2e3e
PE
53202012-04-09 Paul Eggert <eggert@cs.ucla.edu>
5321
5322 composite.c: use 'double' consistently
5323 * composite.c (get_composition_id): Use 'double' consistently
5324 instead of converting 'float' to 'double' and vice versa; this is
5325 easier to understand and avoids a GCC warning.
5326
fd06db5d
GM
53272012-04-09 Glenn Morris <rgm@gnu.org>
5328
50fe702a
GM
5329 * Makefile.in: Generate leim-list with bootstrap-emacs, in
5330 preparation for dumping it with emacs. (Bug#4789)
5331 (leimdir): New variable.
5332 ($(leimdir)/leim-list.el): New rule.
5333 (emacs$(EXEEXT)): Depend on leim-list.el.
5334
fd06db5d
GM
5335 * buffer.c (Qucs_set_table_for_input): Remove. (Bug#9821)
5336 (Fget_buffer_create): Don't call Qucs_set_table_for_input.
5337 (init_buffer_once, syms_of_buffer): Remove Qucs_set_table_for_input.
5338
55c131ee
AS
53392012-04-08 Andreas Schwab <schwab@linux-m68k.org>
5340
5341 * lisp.h (struct Lisp_Symbol): Add explicit padding to ensure
5342 proper alignment.
5343
9209588f
JB
53442012-04-07 Juanma Barranquero <lekktu@gmail.com>
5345
5346 * xml.c (init_libxml2_functions) [WINDOWSNT]:
5347 Remove unused local variable.
5348
e3fb2efb
PE
53492012-04-07 Paul Eggert <eggert@cs.ucla.edu>
5350
5351 Avoid unnecessary pointer scanning in garbage collection (Bug#10780).
5352 * alloc.c (POINTERS_MIGHT_HIDE_IN_OBJECTS): New macro.
5353 (mark_memory): Mark Lisp_Objects only if pointers might hide in
5354 objects, as mark_maybe_pointer will catch them otherwise.
5355 (GC_LISP_OBJECT_ALIGNMENT): Remove; no longer needed.
5356 * s/gnu-linux.h (GC_LISP_OBJECT_ALIGNMENT) [__mc68000__]: Likewise.
5357
b5385551
PE
53582012-04-07 Paul Eggert <eggert@cs.ucla.edu>
5359
5360 Fix typo that broke non-Windows builds.
5361 * xml.c (libxml2_loaded_p) [!!WINDOWSNT]: 'inine' -> 'inline'.
5362
9078ead6
EZ
53632012-04-07 Eli Zaretskii <eliz@gnu.org>
5364
5365 Support building on MS-Windows with libxml2.
5366
5367 * makefile.w32-in (OBJ2): Add xml.$(O).
5368 (GLOBAL_SOURCES): Add xml.c.
5369 ($(BLD)/xml.$(O)): New dependency list.
5370
5371 * xml.c (DEF_XML2_FN, LOAD_XML2_FN) [WINDOWSNT]: New macros.
5372 (fn_htmlReadMemory, fn_xmlReadMemory, fn_xmlDocGetRootElement)
5373 (fn_xmlFreeDoc, fn_xmlCleanupParser, fn_xmlCheckVersion)
5374 [!WINDOWSNT]: New macros.
5375 (init_libxml2_functions, libxml2_loaded_p): New functions.
5376 (parse_region): Call fn_xmlCheckVersion instead of using the macro
5377 LIBXML_TEST_VERSION. Call libxml2 functions via the fn_* macros.
5378 (xml_cleanup_parser): New function, export for fn_xmlCleanupParser.
5379 Calls xmlCleanupParser only if libxml2 was loaded (or statically
5380 linked in).
6bbef4e5
JC
5381 (Flibxml_parse_html_region, Flibxml_parse_xml_region):
5382 Call init_libxml2_functions before calling libxml2 functions.
9078ead6
EZ
5383 (syms_of_xml) <Qlibxml2_dll>: DEFSYM it.
5384
5385 * emacs.c: Don't include libxml/parser.h.
5386 (shut_down_emacs): Call xml_cleanup_parser, instead of calling
5387 xmlCleanupParser directly.
5388
5389 * lisp.h [HAVE_LIBXML2]: Add prototype for xml_cleanup_parser.
5390
3811fdf3
EZ
53912012-04-07 Eli Zaretskii <eliz@gnu.org>
5392
5393 * indent.c (Fvertical_motion): If there is a display string at
5394 point, use it.vpos to compute how many lines to backtrack after
5395 move_it_to point. (Bug#11133)
5396
2f8e16b2
EZ
53972012-04-06 Eli Zaretskii <eliz@gnu.org>
5398
5399 * buffer.h (FETCH_CHAR, FETCH_MULTIBYTE_CHAR):
5400 * character.h (STRING_CHAR, STRING_CHAR_AND_LENGTH): Add comments
5401 about subtle differences between FETCH_CHAR* and STRING_CHAR*
5402 macros related to unification of CJK characters. For the details,
5403 see the discussion following the message here:
5404 http://debbugs.gnu.org/cgi/bugreport.cgi?bug=11073#14.
5405
3d439cd1
CY
54062012-04-04 Chong Yidong <cyd@gnu.org>
5407
5408 * keyboard.c (Vdelayed_warnings_list): Doc fix.
5409
8bc53d00
EZ
54102012-04-01 Eli Zaretskii <eliz@gnu.org>
5411
5412 * w32menu.c (simple_dialog_show, add_menu_item): Use SAFE_ALLOCA
5413 instead of alloca. (Bug#11138)
5414
3b0512a3
AS
54152012-04-01 Andreas Schwab <schwab@linux-m68k.org>
5416
5417 * w32menu.c (is_simple_dialog): Properly check lisp types.
5418 (Bug#11141)
5419
8427ddd2
EZ
54202012-03-31 Eli Zaretskii <eliz@gnu.org>
5421
979022ef
EZ
5422 * xdisp.c (move_it_by_lines): When DVPOS is positive, and the
5423 position we get to after a call to move_it_to fails the
5424 IS_POS_VALID_AFTER_MOVE_P test, move to the next buffer position
5425 only if we wind up in a string from display property. (Bug#11063)
5426
a6b1c7cc
EZ
5427 * window.c (Fdelete_other_windows_internal): Invalidate the row
5428 and column information about mouse highlight, so that redisplay
5429 restores it after reallocating the glyph matrices. (Bug#7464)
5430
8427ddd2
EZ
5431 * xdisp.c (set_cursor_from_row): If `cursor' property on a display
5432 string comes from a `display' text property, use the buffer
5433 position of that property as if we actually saw that position in
5434 the row's glyphs.
697ba24b
EZ
5435 (move_it_by_lines): Remove the assertion that
5436 "it->current_x == 0 && it->hpos == 0" which can be legitimately
5437 violated when there's a before-string at the beginning of a line.
5438 (Bug#11063)
8427ddd2 5439
65a0a738
EZ
54402012-03-30 Eli Zaretskii <eliz@gnu.org>
5441
5442 * xdisp.c (append_space_for_newline): If the default face was
5443 remapped, use the remapped face for the appended newline.
5444 (extend_face_to_end_of_line): Use the remapped default face for
5445 extending the face to the end of the line.
5446 (display_line): Call extend_face_to_end_of_line when the default
5447 face was remapped. (Bug#11068)
5448
581355cc
EZ
54492012-03-29 Eli Zaretskii <eliz@gnu.org>
5450
5451 * s/ms-w32.h: Discourage from defining HAVE_GETCWD.
5452
e8fc049f
SM
54532012-03-28 Stefan Monnier <monnier@iro.umontreal.ca>
5454
5455 * keyboard.c (safe_run_hooks_error): Don't unquote strings.
5456
4fb9a543
GM
54572012-03-27 Glenn Morris <rgm@gnu.org>
5458
5459 * search.c (Fword_search_backward_lax, Fword_search_forward_lax):
5460 Doc fixes.
5461
679910f1
KH
54622012-03-26 Kenichi Handa <handa@m17n.org>
5463
5464 * dispextern.h (struct glyph): Fix previous change. Change the
5465 bit length of glyphless.ch to 25 (Bug#11082).
5466
90d49b7f
CY
54672012-03-26 Chong Yidong <cyd@gnu.org>
5468
5469 * keyboard.c (Vselection_inhibit_update_commands): New variable.
5470 (command_loop_1): Use it; inhibit selection update for
5471 handle-select-window too (Bug#8996).
5472
f514f6f0
FP
54732012-03-25 Fabrice Popineau <fabrice.popineau@supelec.fr>
5474
e8fc049f 5475 * w32heap.c (_heap_init, _heap_term): Remove dead MSVC-specific code.
f514f6f0 5476
bf43fa51
KH
54772012-03-25 Kenichi Handa <handa@m17n.org>
5478
5479 * dispextern.h (struct glyph): Change the bit length of
5480 glyphless.ch to 22 to make the member glyphless fit in 32 bits.
5481
8a0c01dd
EZ
54822012-03-24 Eli Zaretskii <eliz@gnu.org>
5483
5484 * s/ms-w32.h (tzname): Include time.h before redirecting to
5485 _tzname. Fixes the MSVC build. (Bug#9960)
5486
7d1c3a76
AS
54872012-03-24 Andreas Schwab <schwab@linux-m68k.org>
5488
8ed79523
AS
5489 * xdisp.c (produce_glyphless_glyph): Limit length of acronym to 6
5490 characters.
5491
7d1c3a76
AS
5492 * xterm.c (XTread_socket): Only modify handling_signal if
5493 !SYNC_INPUT. (Bug#11080)
5494
e99a9b8b
EZ
54952012-03-23 Eli Zaretskii <eliz@gnu.org>
5496
5497 * bidi.c (bidi_fetch_char): Use STRING_CHAR_AND_LENGTH instead of
5498 FETCH_MULTIBYTE_CHAR followed by CHAR_BYTES. Prevents crashes
5499 when fetching a multibyte character consumes more bytes than
5500 CHAR_BYTES returns, due to unification of CJK characters in
5501 string_char. (Bug#11073)
5502
5063c0e1
TN
55032012-03-23 Troels Nielsen <bn.troels@gmail.com> (tiny change)
5504
5505 * process.c (wait_reading_process_output): Handle pty disconnect
5506 by refraining from sending oneself a SIGCHLD (bug#10933).
5507
9f851fbd
CY
55082012-03-22 Chong Yidong <cyd@gnu.org>
5509
5510 * dispextern.h (struct it): New member string_from_prefix_prop_p.
5511
5063c0e1 5512 * xdisp.c (push_prefix_prop): Rename from push_display_prop.
9f851fbd
CY
5513 Mark string as coming from a prefix property.
5514 (handle_face_prop): Use default face for prefix strings (Bug#4281).
5515 (pop_it, reseat_1): Save and restore string_from_prefix_prop_p.
5516
fb5b8aca
CY
55172012-03-21 Chong Yidong <cyd@gnu.org>
5518
5519 * xfaces.c (Vface_remapping_alist): Doc fix.
5520
62356a1b
EZ
55212012-03-20 Eli Zaretskii <eliz@gnu.org>
5522
5523 * w32proc.c (Fw32_set_console_codepage)
5063c0e1
TN
5524 (Fw32_set_console_output_codepage, Fw32_get_codepage_charset):
5525 Doc fixes.
62356a1b 5526
025de85b
CY
55272012-03-20 Chong Yidong <cyd@gnu.org>
5528
5529 * dispnew.c (Fredisplay, Vredisplay_preemption_period): Update doc
5530 to reflect default non-nil value of redisplay-dont-pause.
5531
4827f94e
KH
55322012-03-19 Kenichi Handa <handa@m17n.org>
5533
5534 * ftfont.c (ftfont_drive_otf): Mask bits of character code to make
5535 it fit in a valid range (Bug#11003).
5536
e50a24a2
EZ
55372012-03-18 Eli Zaretskii <eliz@gnu.org>
5538
5539 * xdisp.c (cursor_row_p): Even if the glyph row ends in a string
5540 that is not from display property, accept the row as a "cursor
5541 row" if one of the string's character has a non-nil `cursor'
5542 property. Fixes cursor positioning when there are newlines in
5543 overlay strings, e.g. in icomplete.el. (Bug#11035)
5544
9af5ed87
PE
55452012-03-12 Paul Eggert <eggert@cs.ucla.edu>
5546
5547 * buffer.c (compare_overlays): Don't assume args differ (Bug#6830).
5548
d1f55f16
CY
55492012-03-12 Chong Yidong <cyd@gnu.org>
5550
5551 * eval.c (inhibit_lisp_code): Rename from
5552 inhibit_window_configuration_change_hook; move from window.c.
5553
5554 * xfns.c (unwind_create_frame_1, Fx_create_frame):
5555 * window.c (run_window_configuration_change_hook)
5556 (syms_of_window): Callers changed.
5557
66c5eebd
CY
55582012-03-11 Chong Yidong <cyd@gnu.org>
5559
413df973
CY
5560 * keymap.c (Fkey_description): Doc fix (Bug#9700).
5561
66c5eebd
CY
5562 * editfns.c (Fconstrain_to_field): Doc fix (Bug#9452).
5563
1de11f56
CY
55642012-03-10 Chong Yidong <cyd@gnu.org>
5565
5566 * frame.c (other_visible_frames): Don't assume the selected frame
5567 is visible (Bug#10955).
5568
cae07000
SM
55692012-03-09 Stefan Monnier <monnier@iro.umontreal.ca>
5570
5571 * buffer.c (compare_overlays): Avoid qsort's instability (bug#6830).
5572
89c94350
JD
55732012-03-08 Jan Djärv <jan.h.d@swipnet.se>
5574
5575 * gtkutil.c (x_wm_set_size_hint): Use one row in call to
5576 FRAME_TEXT_LINES_TO_PIXEL_HEIGHT so base_height is greater than
5577 zero (Bug#10954).
5578
999dd333
GM
55792012-03-03 Glenn Morris <rgm@gnu.org>
5580
01a6dcc8 5581 * alloc.c (Fgarbage_collect, misc-objects-consed): Doc fixes.
999dd333 5582
de0100f2
EZ
55832012-03-02 Eli Zaretskii <eliz@gnu.org>
5584
5585 * xdisp.c (try_window_reusing_current_matrix): Don't move cursor
5586 position past the first glyph_row that ends at ZV. (Bug#10902)
b8456c5c
EZ
5587 (redisplay_window, next_element_from_string): Fix typos in
5588 comments.
3e441275
EZ
5589 (redisplay_window): Pass to move_it_vertically the margin in
5590 pixels, not in screen lines.
de0100f2 5591
96a72ee9
GM
55922012-03-02 Glenn Morris <rgm@gnu.org>
5593
5594 * buffer.c (buffer-list-update-hook): Doc fix.
5595
312508d7
EZ
55962012-02-29 Eli Zaretskii <eliz@gnu.org>
5597
5598 * xdisp.c (get_overlay_strings_1): Under bidi redisplay, call
5599 push_it before setting up the iterator for the first overlay
5600 string, even if we have an empty string loaded.
5601 (next_overlay_string): If there's an empty string on the iterator
5602 stack, pop the stack. (Bug#10903)
5603
27f3c637
PE
56042012-02-25 Paul Eggert <eggert@cs.ucla.edu>
5605
5606 Generalize fix for crash due to non-contiguous EMACS_INT (Bug#10780).
5607 Suggested by Stefan Monnier in
5608 <http://lists.gnu.org/archive/html/emacs-devel/2012-02/msg00692.html>.
5609 * alloc.c (widen_to_Lisp_Object): New static function.
5610 (mark_memory): Also mark Lisp_Objects by fetching pointer words
5611 and widening them to Lisp_Objects. This would work even if
5612 USE_LSB_TAG is defined and wide integers are used, which might
5613 happen in a future version of Emacs.
5614
3c9dfce6
CY
56152012-02-25 Chong Yidong <cyd@gnu.org>
5616
fa74b241
CY
5617 * fileio.c (Ffile_selinux_context, Fset_file_selinux_context):
5618 Doc fix.
5619
3c9dfce6
CY
5620 * xselect.c (Fx_selection_exists_p): Doc fix.
5621 (x_clipboard_manager_save_all): Print an informative message
5622 before saving to clipboard manager.
5623
9486df08
CY
56242012-02-24 Chong Yidong <cyd@gnu.org>
5625
5626 * keyboard.c (process_special_events): Handle all X selection
5627 requests in kbd_buffer, not just the next one (Bug#8869).
5628
f01d3321
CY
56292012-02-23 Chong Yidong <cyd@gnu.org>
5630
5631 * xfns.c (Fx_create_frame): Avoid window-configuration-change-hook
5632 call when setting menu-bar-lines and tool-bar-lines parameters.
5633 (unwind_create_frame_1): New helper function.
5634
5635 * window.c (inhibit_window_configuration_change_hook): New var.
5636 (run_window_configuration_change_hook): Obey it.
b2e4ca7d 5637 (syms_of_window): Initialize it.
f01d3321 5638
86b847b6
CY
56392012-02-22 Chong Yidong <cyd@gnu.org>
5640
5641 * xterm.c (x_draw_image_relief): Add missing type check for
5642 Vtool_bar_button_margin (Bug#10743).
5643
a59225b1
CY
56442012-02-21 Chong Yidong <cyd@gnu.org>
5645
5646 * fileio.c (Vfile_name_handler_alist): Doc fix.
5647
5648 * buffer.c (Fget_file_buffer): Protect against invalid file
5649 handler return value.
5650
310f5bd4
PE
56512012-02-20 Paul Eggert <eggert@cs.ucla.edu>
5652
cb3a28cc
PE
5653 * .gdbinit (xreload): Don't assume EMACS_INT fits in 'long'
5654 when computing $valmask.
5655
310f5bd4
PE
5656 Fix crash due to non-contiguous EMACS_INT (Bug#10780).
5657 * lisp.h (VALBITS): Move definition up, so that USE_LSB_TAG can use it.
5658 (USE_LSB_TAG): Do not define if UINTPTR_MAX >> VALBITS == 0.
5659 It's useless in that case, and it can cause problems on hosts
5660 that allocate halves of EMACS_INT values separately.
5661 Reported by Dan Horák. Diagnosed by Andreas Schwab in
5662 <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=10780#30>.
5663 * mem-limits.h (EXCEEDS_LISP_PTR): Define to 0 on hosts where
5664 UINTPTR_MAX >> VALBITS == 0. This is required by the above change;
5665 it avoids undefined behavior on hosts where shifting right by more
5666 than the word width has undefined behavior.
5667
2375c96a
CY
56682012-02-19 Chong Yidong <cyd@gnu.org>
5669
5670 * fileio.c (Ffile_name_directory, Ffile_name_nondirectory)
5671 (Funhandled_file_name_directory, Ffile_name_as_directory)
5672 (Fdirectory_file_name, Fexpand_file_name)
5673 (Fsubstitute_in_file_name): Protect against invalid file handler
5674 return values (Bug#10845).
5675
3eb49e71
EZ
56762012-02-18 Eli Zaretskii <eliz@gnu.org>
5677
5678 * .gdbinit (pitx): Fix incorrect references to fields of the
5679 iterator stack.
5680
7b926f3f
CY
56812012-02-17 Chong Yidong <cyd@gnu.org>
5682
5683 * syntax.c (Fscan_lists): Doc fix (Bug#10833).
5684
11273115
PE
56852012-02-15 Paul Eggert <eggert@cs.ucla.edu>
5686
5687 * image.c (MAX_IMAGE_SIZE): Increase from 6.0 to 10.0; see
5688 <http://lists.gnu.org/archive/html/emacs-devel/2012-02/msg00540.html>.
5689
c3a70e2b
CY
56902012-02-15 Chong Yidong <cyd@gnu.org>
5691
5692 * eval.c (Fdefvar, Fdefconst): Doc fix; note that the variable is
5693 marked as special. Also, starting docstrings with * is obsolete.
5694
0ca43699
AS
56952012-02-13 Andreas Schwab <schwab@linux-m68k.org>
5696
5697 * gnutls.c (emacs_gnutls_write): Fix last change.
5698
2e8f3c56
LI
56992012-02-13 Lars Ingebrigtsen <larsi@gnus.org>
5700
5701 * gnutls.c (emacs_gnutls_write): Set errno appropriately for
5702 send_process.
5703
af70074f
SM
57042012-02-13 Stefan Monnier <monnier@iro.umontreal.ca>
5705
5706 * keymap.c (Fsingle_key_description): Handle char ranges.
5707
95986d52
CY
57082012-02-12 Chong Yidong <cyd@gnu.org>
5709
afd83bd1
CY
5710 * xdisp.c (handle_stop): Avoid assigning -1 to it->face_id here,
5711 as that creates a dangerous corner case.
5712
95986d52
CY
5713 * window.c (Fdelete_window_internal): Invalidate the mouse
5714 highlight (Bug#9904).
5715
bd7da63e
GM
57162012-02-12 Glenn Morris <rgm@gnu.org>
5717
5718 * xselect.c (Fx_own_selection_internal)
5719 (Fx_get_selection_internal, Fx_disown_selection_internal)
5720 (Fx_selection_owner_p, Fx_selection_exists_p): Doc fixes.
5721 * nsselect.m (Fx_own_selection_internal)
5722 (Fx_disown_selection_internal, Fx_selection_exists_p)
5723 (Fx_selection_owner_p, Fx_get_selection_internal):
5724 Sync docs and argument specs with the xselect.c versions.
5725
77abcbc2
LI
57262012-02-11 Lars Ingebrigtsen <larsi@gnus.org>
5727
5728 * gnutls.c (emacs_gnutls_write): Don't infloop if sendto fails.
5729
90b671e2
EZ
57302012-02-11 Eli Zaretskii <eliz@gnu.org>
5731
1c0ca0b7
EZ
5732 * w32select.c (Fx_selection_exists_p): Sync doc string and
5733 argument list with xselect.c. (Bug#10783)
5734
5735 * w16select.c (Fx_selection_exists_p): Sync doc string and
5736 argument list with xselect.c. (Bug#10783)
90b671e2 5737
49241268
GM
57382012-02-10 Glenn Morris <rgm@gnu.org>
5739
5740 * fns.c (Fsecure_hash): Doc fix.
5741
f998bbe7 57422012-02-09 Kenichi Handa <handa@m17n.org>
5c1ca13d
KH
5743
5744 * coding.c (produce_chars): Fix updating of src_end (Bug#10701).
5745
0992bd9c
CY
57462012-02-07 Chong Yidong <cyd@gnu.org>
5747
5748 * buffer.c (Fbuffer_local_variables)
5749 (buffer_lisp_local_variables): Handle unbound vars correctly;
5750 don't let Qunbound leak into Lisp.
5751
af008560
GM
57522012-02-07 Glenn Morris <rgm@gnu.org>
5753
dd605cc4
GM
5754 * image.c (Fimagemagick_types): Doc fix.
5755
af008560
GM
5756 * image.c (imagemagick-render-type): Change it from a lisp object
5757 to an integer. Move the doc here from the lisp manual.
5758 Treat all values not equal to 0 the same.
5759
1449fa1d
CY
57602012-02-06 Chong Yidong <cyd@gnu.org>
5761
5762 * doc.c (store_function_docstring): Avoid applying docstring of
5763 alias to base function (Bug#2603).
5764
3723ec07
AS
57652012-02-04 Andreas Schwab <schwab@linux-m68k.org>
5766
5767 * .gdbinit (pp1, pv1): Remove redundant defines.
5768 (pr): Use pp.
5769
79c1cc1e
CY
57702012-02-04 Chong Yidong <cyd@gnu.org>
5771
5772 * nsterm.m: Declare a global (Bug#10694).
5773
d7f29f8e
EZ
57742012-02-04 Eli Zaretskii <eliz@gnu.org>
5775
cae07000
SM
5776 * w32.c (get_emacs_configuration_options):
5777 Include --enable-checking, if specified, in the return value.
d7f29f8e 5778
3b95a6f9
MR
57792012-02-04 Martin Rudalics <rudalics@gmx.at>
5780
5781 * dispnew.c (change_frame_size_1): Calculate new_frame_total_cols
5782 after rounding frame sizes. (Bug#9723)
5783
d6fa96a6
EZ
57842012-02-04 Eli Zaretskii <eliz@gnu.org>
5785
5786 * keyboard.c (adjust_point_for_property): Don't position point
5787 before BEGV. (Bug#10696)
5788
df0b2940
PE
57892012-02-03 Paul Eggert <eggert@cs.ucla.edu>
5790
5791 Handle overflow when computing char display width (Bug#9496).
5792 * character.c (char_width): Return EMACS_INT, not int.
5793 (char_width, c_string_width): Check for overflow when
5794 computing the width; this is possible now that individual
5795 characters can have unbounded width. Problem introduced
5796 by merge from Emacs 23 on 2012-01-19.
5797
6bee44d6
MA
57982012-02-02 Michael Albinus <michael.albinus@gmx.de>
5799
5800 * dbusbind.c (Fdbus_register_method): Mention the return value
5801 :ignore in the docstring.
5802
44f92739
GM
58032012-02-02 Glenn Morris <rgm@gnu.org>
5804
1b9f60cc
GM
5805 * callproc.c (Fcall_process, Fcall_process_region): Doc fix.
5806
44f92739
GM
5807 * nsterm.m (syms_of_nsterm) <x-toolkit-scroll-bars>:
5808 Unconditionally set to t. (Bug#10673)
5809 * nsterm.m (syms_of_nsterm) <x-toolkit-scroll-bars>:
5810 * w32term.c (syms_of_w32term) <x-toolkit-scroll-bars>:
5811 * xterm.c (syms_of_xterm) <x-toolkit-scroll-bars>: Doc fix.
5812
c5d3843c
KH
58132012-02-02 Kenichi Handa <handa@m17n.org>
5814
5815 (x_produce_glyphs): Cancel previous change. If cmp->glyph_len is
5816 0, do not call append_composite_glyph.
5817
159462d4 58182012-02-02 Kenichi Handa <handa@m17n.org>
d2a51fd7
KH
5819
5820 * xdisp.c (BUILD_COMPOSITE_GLYPH_STRING): Initialize first_s to
5821 NULL (Bug#6988).
5822 (x_produce_glyphs): If the component of a composition is a null
5823 string, set it->pixel_width to 1 to avoid zero-width glyph.
5824
78cef877
EZ
58252012-02-01 Eli Zaretskii <eliz@gnu.org>
5826
5827 * ralloc.c (resize_bloc, r_alloc_sbrk): Don't call memmove if its
5828 first 2 arguments are identical. This makes inserting large
5829 output from a subprocess an order of magnitude faster on
5830 MS-Windows, where all sbrk'ed memory is always contiguous.
5831
97897668
GM
58322012-01-31 Glenn Morris <rgm@gnu.org>
5833
5834 * nsterm.m (syms_of_nsterm) <x-toolkit-scroll-bars>:
c78c6e0b 5835 * w32term.c (syms_of_w32term) <x-toolkit-scroll-bars>:
97897668
GM
5836 * xterm.c (syms_of_xterm) <x-toolkit-scroll-bars>: Sync docs.
5837
31fd3586
GM
58382012-01-29 Glenn Morris <rgm@gnu.org>
5839
5840 * gnutls.c (syms_of_gnutls): More doc (from etc/NEWS).
5841
0e24a8b2
CY
58422012-01-28 Samuel Thibault <sthibault@debian.org> (tiny change)
5843
5844 * s/gnu.h: Define POSIX_SIGNALS (Bug#10552).
5845
cc0adcb0
CY
58462012-01-28 Chong Yidong <cyd@gnu.org>
5847
5848 * minibuf.c (syms_of_minibuf): Doc fix (Bug#10550).
5849
acc28cb9
CY
58502012-01-26 Chong Yidong <cyd@gnu.org>
5851
9c69cfb7
CY
5852 * keyboard.c (Vecho_keystrokes): Document zero value (Bug#10503).
5853
acc28cb9
CY
5854 * search.c (Fsearch_forward, Fsearch_backward): Document negative
5855 repeat counts (Bug#10507).
5856
48da7392
GM
58572012-01-26 Glenn Morris <rgm@gnu.org>
5858
5859 * lread.c (syms_of_lread): Doc fix.
5860
14af5f7f
CY
58612012-01-25 HIROSHI OOTA <nil@mad.dog.cx> (tiny change)
5862
5863 * coding.c (encode_designation_at_bol): Change return value to
5864 EMACS_INT.
5865
0b21c100
CY
58662012-01-25 Chong Yidong <cyd@gnu.org>
5867
5868 * eval.c (Fuser_variable_p): Doc fix; mention custom-variable-p.
5869
3c2907f7
CY
58702012-01-21 Chong Yidong <cyd@gnu.org>
5871
5872 * floatfns.c (Fcopysign): Make the second argument non-optional,
5873 since nil is not allowed anyway.
5874
959ad23f
AS
58752012-01-21 Andreas Schwab <schwab@linux-m68k.org>
5876
5877 * process.c (read_process_output): Use p instead of XPROCESS (proc).
5878 (send_process): Likewise.
5879
34a02f46
MR
58802012-01-19 Martin Rudalics <rudalics@gmx.at>
5881
5882 * window.c (save_window_save, Fcurrent_window_configuration)
cae07000
SM
5883 (Vwindow_persistent_parameters): Do not use Qstate.
5884 Rewrite doc-strings.
34a02f46 5885
1259009a 58862012-01-19 Kenichi Handa <handa@m17n.org>
25ed9e61
KH
5887
5888 * character.c (char_width): New function.
70d4fdf6
GM
5889 (Fchar_width, c_string_width, lisp_string_width):
5890 Use char_width (Bug#9496).
25ed9e61 5891
6a6ee00d
MR
58922012-01-16 Martin Rudalics <rudalics@gmx.at>
5893
5894 * window.c (Vwindow_persistent_parameters): New variable.
5895 (Fset_window_configuration, save_window_save): Handle persistent
5896 window parameters.
5897
c85efaf7
EZ
58982012-01-14 Eli Zaretskii <eliz@gnu.org>
5899
5900 * w32fns.c (signal_user_input): Don't do a QUIT, to avoid
5901 thrashing the stack of the thread. (Bug#9087)
5902
5944709e
PE
59032012-01-12 Paul Eggert <eggert@cs.ucla.edu>
5904
5905 * xdisp.c (rows_from_pos_range): Add parens as per gcc -Wparentheses.
5906
e71f5d99
EZ
59072012-01-11 Eli Zaretskii <eliz@gnu.org>
5908
5909 * xdisp.c (rows_from_pos_range): Handle the case where the
5910 highlight ends on a newline. (Bug#10464)
5911 (mouse_face_from_buffer_pos): Fix off-by-one error in calculating
5912 he end column for display of highlight that ends on a newline
5913 before a R2L line.
5914
ce316182
GM
59152012-01-11 Glenn Morris <rgm@gnu.org>
5916
5917 * lread.c (init_lread): If no-site-lisp, remove site-lisp dirs
5918 from load-path also when installation-directory is nil. (Bug#10208)
5919
5b43da69
GM
59202012-01-10 Glenn Morris <rgm@gnu.org>
5921
74cc8ff9
GM
5922 * emacs.c (syms_of_emacs) <installation-directory>: Doc fix.
5923
7d8d6e4e
GM
5924 * epaths.in (PATH_LOADSEARCH, PATH_EXEC, PATH_DATA, PATH_DOC):
5925 Update template values to be closer to their typical values these days.
5b43da69 5926
a0db8d43
EZ
59272012-01-09 Eli Zaretskii <eliz@gnu.org>
5928
5929 * xdisp.c (rows_from_pos_range): Accept additional argument
5930 DISP_STRING, and accept any glyph in a row whose object is that
5931 string as eligible for mouse highlight. Fixes mouse highlight of
5932 display strings from overlays. (Bug#10464)
5933
9a0115ab 59342012-01-07 Paul Eggert <eggert@cs.ucla.edu>
09450bae 5935
b9110d6a 5936 emacs: fix an auto-save permissions race condition (Bug#10400)
09450bae
PE
5937 * fileio.c (auto_saving_dir_umask): New static var.
5938 (Fmake_directory_internal): Use it.
5939 (do_auto_save_make_dir): Set it, instead of invoking chmod after
5940 creating the directory. The old code temporarily assigns
5941 too-generous permissions to the directory.
5942 (do_auto_save_eh): Clear it.
b9110d6a 5943 (Fdo_auto_save): Catch all errors, not just file errors, so
09450bae
PE
5944 that the var is always cleared.
5945
6c1bd3f3
EZ
59462012-01-07 Eli Zaretskii <eliz@gnu.org>
5947
5948 * search.c (scan_buffer): Pass character positions to
5949 know_region_cache, not byte positions. (Bug#6540)
5950
069d2b50
L
59512012-01-07 LynX <_LynX@bk.ru> (tiny change)
5952
5953 * w32.c (sys_rename): Report EXDEV when rename of a directory
5954 fails because the target is on another logical disk. (Bug#10284)
5955
75bf0d33
DB
59562012-01-07 David Benjamin <davidben@mit.edu> (tiny change)
5957
5958 * xterm.c (x_embed_request_focus): New function.
5959
5960 * xterm.h: Add prototype.
5961
5962 * xfns.c (Fx_focus_frame): Use it for embedded frames (Bug#9977).
5963
1c6e5a32
GM
59642012-01-05 Glenn Morris <rgm@gnu.org>
5965
5966 * emacs.c (emacs_copyright): Update short copyright year to 2012.
5967
651e947e
EZ
59682012-01-01 Eli Zaretskii <eliz@gnu.org>
5969
5970 * gnutls.c (init_gnutls_functions): Load gnutls_check_version.
5971 Load gnutls_transport_set_lowat only if GnuTLS version is below
5972 2.11.1.
5973 (emacs_gnutls_handshake): Call gnutls_transport_set_lowat only for
5974 GnuTLS versions below 2.11.1.
5975
3778cdd8
AL
59762011-12-31 Antoine Levitt <antoine.levitt@gmail.com>
5977
5978 * xdisp.c (syms_of_xdisp) <window-scroll-functions>: Add warning
5979 to the doc string advising against its use for altering the way
5980 windows are scrolled.
5981
0e5317f7
KH
59822011-12-28 Kenichi Handa <handa@m17n.org>
5983
5984 * coding.c (Fdefine_coding_system_internal): Make an utf-8 base
5985 coding-system ASCII compatible only when it does not produce BOM
5986 on encoding (Bug#10383).
5987
93d5ca1f
JD
59882011-12-26 Jan Djärv <jan.h.d@swipnet.se>
5989
5990 * xmenu.c (x_menu_wait_for_event): Use xg_select for Gtk3 so menus
5991 can scroll.
5992 (create_and_show_popup_menu): Always use menu_position_func for
5993 Gtk3 (Bug#10361).
5994
ca22b785
AS
59952011-12-24 Andreas Schwab <schwab@linux-m68k.org>
5996
5997 * callint.c (Fcall_interactively): Don't truncate prompt string.
5998
d048e1e6
EZ
59992011-12-23 Eli Zaretskii <eliz@gnu.org>
6000
6001 * xdisp.c (handle_invisible_prop): Handle correctly an invisible
6002 property that ends at ZV, so that the bidi iteration could be
3ba1a2ad 6003 resumed from there (after widening). (Bug#10360)
d048e1e6 6004
5ccaba1f
JD
60052011-12-22 Jan Djärv <jan.h.d@swipnet.se>
6006
6007 * nsfont.m (ns_spec_to_descriptor): Do not autorelease fdesc.
6008
204ee57f
JD
60092011-12-21 Jan Djärv <jan.h.d@swipnet.se>
6010
b81d40f0
JB
6011 * nsterm.m (x_free_frame_resources):
6012 Release f->output_data.ns->miniimage.
204ee57f
JD
6013 (ns_index_color): Fix indentation. Do not retain
6014 color_table->colors[i].
6015
6016 * nsmenu.m (ns_update_menubar): Call free_menubar_widget_value_tree
6017 before returning.
6018
6019 * nsfns.m (x_set_background_color): Assign return value from
6020 ns_index_color to face-background instead of NSColor*.
6021 (ns_implicitly_set_icon_type): Fix indentation.
6022 Change assignment in for loop to comparison.
6023
6024 * emacs.c (ns_pool): New variable.
6025 (main): Assign ns_pool.
6026 (Fkill_emacs): Call ns_release_autorelease_pool.
6027
6028 * nsfont.m (ns_spec_to_descriptor): Fix indentation,
6029 autorelease fdesc, release fdAttrs and tdict.
6030 (ns_get_covering_families): Release charset.
6031 (ns_findfonts): Release NSFontDescriptor created with new.
6032 (ns_uni_to_glyphs): Fix indentation.
6033 (setString): Release attrStr before assigning new value.
6034
c803b2b7
JD
60352011-12-18 Jan Djärv <jan.h.d@swipnet.se>
6036
678f4426
JD
6037 * nsmenu.m (NSMenuDidBeginTrackingNotification): Declare if OSX < 10.5
6038 and NS_IMPL_COCOA.
6039 (trackingNotification): Surround with ifdef NS_IMPL_COCOA.
6040 (syms_of_nsmenu): Set trackingMenu to 1 if not NS_IMPL_COCOA.
6041
cd394be1 60422011-12-18 David Reitter <reitter@cmu.edu>
678f4426 6043
5fecd5fc
JD
6044 * nsterm.m (ns_term_init): Subscribe for notifications
6045 NSMenuDidBeginTrackingNotification and NSMenuDidEndTrackingNotification
6046 to method trackingNotification in EmacsMenu.
6047
6048 * nsmenu.m (trackingMenu): New variable.
3771cb17 6049 (trackingNotification): New method (from Aquamacs).
5fecd5fc 6050 (menuNeedsUpdate): Expand comment and return if trackingMenu is 0,
3771cb17 6051 from Aquamacs (Bug#7030).
678f4426
JD
6052
60532011-12-18 Jan Djärv <jan.h.d@swipnet.se>
5fecd5fc 6054
c803b2b7
JD
6055 * nsselect.m (CUT_BUFFER_SUPPORT): Remove define.
6056 (symbol_to_nsstring): Fix indentation.
6057 (ns_symbol_to_pb): New function.
cae07000
SM
6058 (Fns_get_selection_internal): Rename from Fns_get_cut_buffer_internal.
6059 (Fns_rotate_cut_buffers_internal): Remove.
6060 (Fns_store_selection_internal): Rename from
c803b2b7
JD
6061 Fns_store_cut_buffer_internal.
6062 (ns_get_foreign_selection, Fx_own_selection_internal)
6063 (Fx_disown_selection_internal, Fx_selection_exists_p)
b81d40f0
JB
6064 (Fns_get_selection_internal, Fns_store_selection_internal):
6065 Use ns_symbol_to_pb and check if return value is nil.
6066 (syms_of_nsselect): Remove ifdef CUT_BUFFER_SUPPORT. Remove defsubr
6067 Sns_rotate_cut_buffers_internal. Sns_get_cut_buffer_internal
c803b2b7
JD
6068 renamed to Sns_get_selection_internal, Sns_store_cut_buffer_internal
6069 renamed to Sns_store_selection_internal.
6070 (ns_handle_selection_request): Move code to Fx_own_selection_internal
6071 and remove this function.
6072 (ns_handle_selection_clear): Remove, never used.
6073 (Fx_own_selection_internal): Move code from ns_handle_selection_request
6074 here.
6075
e1b01a3a
KB
60762011-12-17 Ken Brown <kbrown@cornell.edu>
6077
6078 * fileio.c (check_writable) [CYGWIN]: Return non-zero if UID or
6079 GID is unknown (Bug#10257).
6080
2adb6e85
PE
60812011-12-17 Paul Eggert <eggert@cs.ucla.edu>
6082
6083 * s/gnu-linux.h: Fix mark_memory typo (Bug#10286).
6084 (GC_MARK_SECONDARY_STACK): Omit removed 3rd arg to mark_memory,
6085 which caused a build failure on GNU/Linux IA-64. This problem was
6086 introduced by my 2011-10-07 patch.
6087
d1d7b339
JL
60882011-12-15 Juri Linkov <juri@jurta.org>
6089
6090 * image.c (imagemagick_error): New function. (Bug#10112)
6091 (imagemagick_load_image): Comment out `MagickSetResolution' call.
6092 Use `imagemagick_error' where ImageMagick functions return
6093 `MagickFalse'.
6094 (Fimagemagick_types): Add `Fnreverse' to return the list in the
6095 proper order.
6096
100d5755
KH
60972011-12-15 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
6098
6099 * xftfont.c (xftfont_draw): Use the font metrics of s->font to
6100 fill background (Bug#8992).
6101
454592a6
MR
61022011-12-13 Martin Rudalics <rudalics@gmx.at>
6103
6104 * window.c (Vwindow_combination_resize)
6105 (Vwindow_combination_limit): Use t instead of non-nil in
6106 doc-strings.
61d4b438
MR
6107 (Vrecenter_redisplay): Add first sentence of doc-string on
6108 separate line.
53524d93 6109 (Frecenter): Fix doc-string typo.
454592a6 6110
3633e3aa
KH
61112011-12-11 Kenichi Handa <handa@m17n.org>
6112
6113 * coding.c (Funencodable_char_position): Pay attention to the
6114 buffer text relocation (Bug#9389).
6115
7b9d523a 61162011-12-10 Jan Djärv <jan.h.d@swipnet.se>
61ccba97 6117
7b9d523a
JD
6118 * xterm.c (x_term_init): Move call to gdk_window_add_filter before
6119 gtk_init (Bug#10100).
6120
b73189c6
EZ
61212011-12-10 Eli Zaretskii <eliz@gnu.org>
6122
6123 * xdisp.c (RECORD_MAX_MIN_POS): Use IT->cmp_it.charpos only if
6124 IT->string is nil. (Bug#10263)
6125
f7dfe5d6
JD
61262011-12-10 Jan Djärv <jan.h.d@swipnet.se>
6127
83faebb4
JD
6128 * nsterm.h (x_free_frame_resources): Declare.
6129
f7dfe5d6
JD
6130 * nsfns.m (ns_get_defaults_value): New function (Bug#10103).
6131 (Fns_get_resource, x_get_string_resource): Call ns_get_defaults_value.
6132
6133 * nsterm.h (ns_get_defaults_value): Declare.
6134
6135 * nsterm.m (ns_default): Call ns_get_defaults_value.
6136
7cd4e72c
EZ
61372011-12-09 Eli Zaretskii <eliz@gnu.org>
6138
6139 * xdisp.c (try_scrolling): Don't set scroll_down_p if dy is zero.
6140 (Bug#10170)
6141
b34d7317
YM
61422011-12-09 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
6143
6144 * unexelf.c (unexec) [NS_IMPL_GNUSTEP]: Take account of the case
6145 that where the value of an _OBJC_* symbol points to is in the .bss
6146 section (Bug#10240).
6147
76470ad1
KH
61482011-12-08 Kazuhiro Ito <kzhr@d1.dion.ne.jp> (tiny change)
6149
6150 * coding.c (encode_coding_ccl): Check (charbuf < charbuf_end)
2fac8180 6151 after the loop to call ccl_driver at least once (Bug#8619).
76470ad1 6152
745fff94
KH
61532011-12-08 Kenichi Handa <handa@m17n.org>
6154
6155 * ftfont.c (get_adstyle_property): Fix previous change
6156 (Bug#10233).
6157
6e44397c
JB
61582011-12-07 Juanma Barranquero <lekktu@gmail.com>
6159
6160 * w32.c (init_environment): If no_site_lisp, remove site-lisp
6161 dirs from the default value of EMACSLOADPATH (bug#10208).
6162
7efa6272
GM
61632011-12-07 Glenn Morris <rgm@gnu.org>
6164
6165 * lread.c (init_lread): If no_site_lisp, exclude site-lisp/ in
6166 installation and source directories as well. (Bug#10208)
6167
f6fc4d87
CY
61682011-12-06 Chong Yidong <cyd@gnu.org>
6169
6170 * minibuf.c (Fread_from_minibuffer): Doc fix (Bug#10228).
6171
2bf26180
GM
61722011-12-06 Glenn Morris <rgm@gnu.org>
6173
6174 * process.c (start_process_unwind): Treat any pid <= 0, except -2,
6175 as an error, not just -1. (Bug#10217)
6176
3a6ad4f0
CY
61772011-12-05 Chong Yidong <cyd@gnu.org>
6178
6179 * keyboard.c (process_special_events): New function.
6180 (swallow_events, Finput_pending_p): Use it (Bug#10195).
6181
75a3b399
PE
61822011-12-05 Paul Eggert <eggert@cs.ucla.edu>
6183
6184 * coding.c (encode_designation_at_bol): Don't use uninitialized
6185 local variable (Bug#9318).
6186
c3c9e25e
KH
61872011-12-05 Kenichi Handa <handa@m17n.org>
6188
6189 * ftfont.c (get_adstyle_property): If the font is not BDF nor PCF,
6190 return Qnil (Bug#8046, Bug#10193).
6191
5eb05ea3
KH
61922011-12-05 Kenichi Handa <handa@m17n.org>
6193
6194 * coding.c (encode_designation_at_bol): New args charbuf_end and
6195 dst. Return the number of produced bytes. Callers changed.
a79703f5
KH
6196 (coding_set_source): Return how many bytes coding->source was
6197 relocated.
6198 (coding_set_destination): Return how many bytes
6199 coding->destination was relocated.
6200 (CODING_DECODE_CHAR, CODING_ENCODE_CHAR, CODING_CHAR_CHARSET)
cae07000 6201 (CODING_CHAR_CHARSET_P): Adjust for the avove changes.
5eb05ea3
KH
6202
62032011-12-05 Kazuhiro Ito <kzhr@d1.dion.ne.jp> (tiny change)
6204
6205 * coding.c (CODING_CHAR_CHARSET_P): New macro.
6206 (encode_coding_emacs_mule, encode_coding_iso_2022): Use the above
6207 macro (Bug#9318).
6208
62092011-12-05 Andreas Schwab <schwab@linux-m68k.org>
6210
6211 The following changes are to fix Bug#9318.
6212
a79703f5 6213 * coding.c (CODING_ENCODE_CHAR, CODING_CHAR_CHARSET): New macros.
5eb05ea3
KH
6214 (encode_coding_emacs_mule, ENCODE_ISO_CHARACTER)
6215 (encode_coding_iso_2022, encode_coding_sjis)
a79703f5 6216 (encode_coding_big5, encode_coding_charset): Use the above macros.
5eb05ea3 6217
7dbda6df
JB
62182011-12-05 Juanma Barranquero <lekktu@gmail.com>
6219
6220 * lisp.h (process_quit_flag): Fix external declaration.
6221
6d5eb5b0
SM
62222011-12-04 Stefan Monnier <monnier@iro.umontreal.ca>
6223
6224 Don't macro-inline non-performance-critical code.
6225 * eval.c (process_quit_flag): New function.
6226 * lisp.h (QUIT): Use it.
6227
a0c3fad0
JD
62282011-12-04 Jan Djärv <jan.h.d@swipnet.se>
6229
6230 * nsfns.m (get_geometry_from_preferences): New function.
6231 (Fx_create_frame): Call get_geometry_from_preferences (Bug#10103).
6232
6c07aac2
AS
62332011-12-04 Andreas Schwab <schwab@linux-m68k.org>
6234
6235 * emacs.c (Qkill_emacs): Define.
6236 (syms_of_emacs): Initialize it.
6237 * keyboard.c (interrupt_signal): Don't call Fkill_emacs here, set
6238 Qquit_flag to `kill-emacs' instead.
6d5eb5b0
SM
6239 (quit_throw_to_read_char): Add parameter `from_signal'.
6240 All callers changed. Call Fkill_emacs if requested and safe.
6c07aac2
AS
6241 * lisp.h (QUIT): Call Fkill_emacs if requested.
6242
c052ead4
JD
62432011-12-03 Jan Djärv <jan.h.d@swipnet.se>
6244
6245 * widget.c (update_wm_hints): Return if wmshell is null.
6246 (widget_update_wm_size_hints): New function.
6247
6248 * widget.h (widget_update_wm_size_hints): Declare.
6249
6250 * xterm.c (x_wm_set_size_hint): If USE_X_TOOLKIT, call
6251 widget_update_wm_size_hints (Bug#10104).
6252
9e49252b
EZ
62532011-12-03 Eli Zaretskii <eliz@gnu.org>
6254
6255 * xdisp.c (handle_invisible_prop): If the invisible text ends just
6256 before a newline, prepare the bidi iterator for consuming the
6257 newline, and keep the current paragraph direction. (Bug#10183)
e9a49426 6258 (redisplay_window): Don't let `margin' become negative. (Bug#10192)
9e49252b 6259
02b16839
JL
62602011-12-02 Juri Linkov <juri@jurta.org>
6261
6262 * search.c (Fword_search_regexp): New Lisp function created from
6263 `wordify'. Change type of arg `lax' from `int' to `Lisp_Object'.
6264 (Fword_search_backward, Fword_search_forward)
6265 (Fword_search_backward_lax, Fword_search_forward_lax):
6266 Use `Fword_search_regexp' instead of `wordify'. Doc fix.
6267 (syms_of_search): Define `Sword_search_regexp'. (Bug#10145)
6268
0068070e
SM
62692011-12-01 Stefan Monnier <monnier@iro.umontreal.ca>
6270
6271 * fileio.c (Finsert_file_contents): Move after-change-function call
6272 to before the "handled:" label, since all "goto handled" appear in
6273 cases where the *-change-functions have already been properly called
6274 (bug#10117).
6275
3360a3fc
AS
62762011-12-01 Andreas Schwab <schwab@linux-m68k.org>
6277
6278 * keyboard.c (interrupt_signal): Don't call kill-emacs when
6279 waiting for input. (Bug#10169)
6280
73d6c093
EZ
62812011-11-30 Eli Zaretskii <eliz@gnu.org>
6282
6283 * dispnew.c (adjust_glyph_matrix): Remove the assertion that
6284 verifies glyph row's hash code--we have just reallocated the
6285 glyphs, so their contents can be complete garbage. (Bug#10164)
6286
febe6bea
JB
62872011-11-30 Juanma Barranquero <lekktu@gmail.com>
6288
6289 * dispnew.c (adjust_glyph_matrix) [XASSERTS]: Add missing check.
6290
801a4313
EZ
62912011-11-30 Eli Zaretskii <eliz@gnu.org>
6292
6293 * dispnew.c (adjust_glyph_matrix) [XASSERTS]: Ensure ROW's
6294 attributes are tested _before_ calling verify_row_hash, to protect
6295 against GCC re-ordering of the tests. (Bug#10164)
6296
2b56b87e
JD
62972011-11-29 Jan Djärv <jan.h.d@swipnet.se>
6298
6299 * xterm.h (struct x_output): net_wm_state_hidden_seen is new.
6300
6301 * xterm.c (handle_one_xevent): Only set async_visible and friends
6302 if net_wm_state_hidden_seen is non-zero (Bug#10002)
7dbda6df 6303 (get_current_wm_state): Set net_wm_state_hidden_seen to 1 if
2b56b87e
JD
6304 _NET_WM_STATE_HIDDEN is in NET_WM_STATE.
6305
dbf31225
PE
63062011-11-28 Paul Eggert <eggert@cs.ucla.edu>
6307
6308 Remove GCPRO-related macros that exist only to avoid shadowing locals.
6309 * lisp.h (GCPRO1_VAR, GCPRO2_VAR, GCPRO3_VAR, GCPRO4_VAR, GCPRO5_VAR)
6310 (GCPRO6_VAR, UNGCPRO_VAR): Remove. See
6311 <http://lists.gnu.org/archive/html/emacs-diffs/2011-11/msg00265.html>.
6312 All uses changed to use GCPRO1 etc.
6313 (GCPRO1, GCPRO2, GCPRO3, GCPRO4, GCPRO5, GCPRO6, UNGCPRO):
6314 Revert to old implementation (i.e., before 2011-03-11).
6315
1305621b
YM
63162011-11-28 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
6317
6318 * dispnew.c (scrolling_window): Truncate overlaps in copy destination
6319 of scroll runs so as to avoid assigning disabled bogus rows and
6320 unnecessary graphics copy operations.
6321
8c9afb46
EZ
63222011-11-27 Eli Zaretskii <eliz@gnu.org>
6323
6324 * s/ms-w32.h (utimbuf) [_MSC_VER]: Don't define.
6325 (snprintf) [_MSC_VER]: Redirect to _snprintf.
6326 (strtoll) [_MSC_VER]: Redirect to _strtoi64.
6327 (malloc, free, realloc, calloc): Redirect to e_* only when
6328 compiling Emacs.
6329
6330 * lisp.h (GCTYPEBITS): Move before first use.
6331 (ALIGN_GCTYPEBITS) [_MSC_VER]: Define.
6332 (DECL_ALIGN) [_MSC_VER]: Use it, as MSVC doesn't like bit ops in
6333 this macro definition.
6334
6335 * s/ms-w32.h (tzname): Redirect to _tzname for all values of
6336 _MSC_VER.
6337
54e9e3bf
JD
63382011-11-27 Jan Djärv <jan.h.d@swipnet.se>
6339
6d5eb5b0
SM
6340 * gtkutil.c (xg_create_frame_widgets):
6341 Call gtk_window_set_has_resize_grip (FALSE) if that function is
54e9e3bf
JD
6342 present with Gtk+ 2.0.
6343
83aca1cb
PE
63442011-11-26 Paul Eggert <eggert@cs.ucla.edu>
6345
6346 * fileio.c (Finsert_file_contents): Undo previous change; see
6347 <http://lists.gnu.org/archive/html/emacs-diffs/2011-11/msg00265.html>.
6348
5b76caa4
PE
63492011-11-26 Paul Eggert <eggert@cs.ucla.edu>
6350
6351 Rename locals to avoid shadowing.
6352 * fileio.c (Finsert_file_contents):
6353 Rename inner 'gcpro1' to 'inner_gcpro1' to avoid shadowing.
6354 * process.c (wait_reading_process_output):
6355 Rename inner 'proc' to 'p' to avoid shadowing.
6356 Indent for consistency with usual Emacs style.
6357
8c535114
EZ
63582011-11-25 Eli Zaretskii <eliz@gnu.org>
6359
6360 * xdisp.c (redisplay_window): If cursor row is not fully visible
6361 after recentering, and scroll-conservatively is set to a large
6362 number, scroll window by a few more lines to make the cursor fully
6363 visible and out of scroll-margin. (Bug#10105)
91b4a718
EZ
6364 (start_display): Don't move to the next line if the display should
6365 start at a newline that is part of a display vector or an overlay
6366 string. (Bug#10119)
8c535114 6367
fa4fdb5c
JL
63682011-11-24 Juri Linkov <juri@jurta.org>
6369
6370 * image.c (imagemagick_load_image): Move `MagickSetResolution' down
6371 after the `MagickPingImage' call. (Bug#10112)
6372
90ec88df
CY
63732011-11-23 Chong Yidong <cyd@gnu.org>
6374
6375 * window.c (Fcoordinates_in_window_p): Accept only live windows.
6376
56e2e794
MR
63772011-11-23 Martin Rudalics <rudalics@gmx.at>
6378
6379 * buffer.c (Fkill_buffer): Run replace_buffer_in_windows before
6380 making another buffer current. (Bug#10114)
6381
b6e64c41
GM
63822011-11-23 Glenn Morris <rgm@gnu.org>
6383
6384 * font.c (font_find_for_lface) [HAVE_NS]: Ignore case. (Bug#2526)
6385
6b21de18
CY
63862011-11-23 Chong Yidong <cyd@gnu.org>
6387
6388 * xdisp.c (compute_stop_pos): Check validity of end_charpos before
6389 using it (Bug#5984).
6390
b12cd789
EZ
63912011-11-22 Eli Zaretskii <eliz@gnu.org>
6392
6393 * dispnew.c (adjust_glyph_matrix): Don't verify hash code of mode-
6394 and header-lines, as they don't have one computed for them.
6395 (Bug#10098)
6396
6397 * .gdbinit (prow): Make displayed values more self-explaining.
6398 Add row's hash code.
6399
261b6fd4
LMI
64002011-11-21 Lars Magne Ingebrigtsen <larsi@gnus.org>
6401
6402 * process.c (wait_reading_process_output): Fix asynchrounous
6403 GnuTLS socket handling on some versions of the GnuTLS library.
16c1ad08 6404 (wait_reading_process_output): Add comment and URL.
261b6fd4 6405
e7cfd277
JD
64062011-11-21 Jan Djärv <jan.h.d@swipnet.se>
6407
6408 * xterm.c (x_clear_frame): Reinstate the XClearWindow call.
6409
a9b9b7f5
CY
64102011-11-21 Chong Yidong <cyd@gnu.org>
6411
6412 * window.c (Fnext_window, Fprevious_window): Doc fix.
6413
b0d15b4f
SM
64142011-11-20 Stefan Monnier <monnier@iro.umontreal.ca>
6415
6416 * window.c (get_phys_cursor_glyph): Fix Lisp_Object/int mixup.
6417
fe7a3057
JB
64182011-11-20 Juanma Barranquero <lekktu@gmail.com>
6419
6420 * nsfont.m (syms_of_nsfont) <ns-reg-to-script>: Fix typo.
6421
d2999b1a
MR
64222011-11-20 Martin Rudalics <rudalics@gmx.at>
6423
6424 * window.c (Fset_window_combination_limit): Rename argument
6425 STATUS to LIMIT.
6426 (Vwindow_combination_limit): Remove "status" from doc-string.
6427
d5ff9cd0
AS
64282011-11-20 Andreas Schwab <schwab@linux-m68k.org>
6429
6430 * m/ibms390.h: Remove.
6431 * m/ibms390x.h: Don't include "ibms390.h".
6432
a5bb9bd3
SM
64332011-11-20 Stefan Monnier <monnier@iro.umontreal.ca>
6434
6435 * fileio.c (Finsert_file_contents): Add missing gcpro1 variable.
6436 Suggested by Dmitry Antipov <dmantipov@yandex.ru>.
6437
cd1181db
JB
64382011-11-20 Juanma Barranquero <lekktu@gmail.com>
6439
6440 * casetab.c (Fset_case_table):
6441 * charset.c (Fcharset_after): Fix typos.
6442
615a3b8d 64432011-11-20 Paul Eggert <eggert@cs.ucla.edu>
6a0bf43d 6444
17e845af
PE
6445 Standardize on VIRT_ADDR_VARIES behavior (Bug#10042).
6446 Otherwise, valgrind does not work on some platforms.
6447 Problem reported by Andreas Schwab in
6a0bf43d
PE
6448 <http://lists.gnu.org/archive/html/emacs-devel/2011-11/msg00081.html>.
6449 * puresize.h (pure, PURE_P): Always behave as if VIRT_ADDR_VARIES
6450 is set, removing the need for VIRT_ADDRESS_VARIES.
6451 (PURE_P): Use a more-efficient implementation that needs just one
6452 comparison, not two: on x86-64 with GCC 4.6.2, this cut down the
6453 number of instructions from 6 (xorl, cmpq, jge, xorl, cmpq, setge)
6454 to 4 (xorl, subq, cmpq, setbe).
6455 * alloc.c (pure): Always extern now, since that's the
6456 VIRT_ADDR_VARIES behavior.
6457 (PURE_POINTER_P): Use a single comparison, not two, for
6458 consistency with the new puresize.h.
6459 * lisp.h (PNTR_COMPARISON_TYPE): Remove; no longer needed.
6460 * m/ibms390.h, m/intel386.h, m/template.h, s/cygwin.h, s/hpux10-20.h:
6461 Remove VIRT_ADDR_VARIES no longer needed.
6462
f8fe6f96
EZ
64632011-11-19 Eli Zaretskii <eliz@gnu.org>
6464
6465 * xdisp.c (x_write_glyphs, draw_phys_cursor_glyph)
6466 (erase_phys_cursor, update_window_cursor, show_mouse_face)
6467 (cursor_in_mouse_face_p): If the cursor position is out of bounds,
6468 behave as if the cursor position were at the window margin.
6469
6470 * window.c (get_phys_cursor_glyph): If the window is hscrolled,
6471 and the cursor position is out of bounds, behave as if the cursor
6472 position were at the window margin. (Bug#10075)
6473
df05a53c
CY
64742011-11-18 Chong Yidong <cyd@gnu.org>
6475
6476 * window.c (Fwindow_combination_limit): Make first argument
6477 non-optional, since it is meaningless for live windows like the
6478 selected window.
61ccba97 6479
2071918e
DA
64802011-11-18 Dmitry Antipov <dmantipov@yandex.ru>
6481
6482 * keymap.c (Fwhere_is_internal): Add missing RETURN_UNGCPROs.
6483
b50a28de
SM
64842011-11-18 Stefan Monnier <monnier@iro.umontreal.ca>
6485
6486 * intervals.c: Fix grafting over the whole buffer (bug#10071).
6487 (graft_intervals_into_buffer): Simplify.
6488
015137db
EZ
64892011-11-18 Eli Zaretskii <eliz@gnu.org>
6490
6491 * dispnew.c (swap_glyph_pointers): Swap the used[] arrays and the
6492 hash values of the two rows.
6493 (copy_row_except_pointers): Preserve the used[] arrays and the
6494 hash values of the two rows. (Bug#10035)
68c95424 6495 (add_row_entry): Add xassert to verify that ROW's hash code is valid.
015137db
EZ
6496
6497 * xdisp.c (row_hash): New function, body extracted from
6498 compute_line_metrics.
6499 (compute_line_metrics): Call row_hash, instead of computing the
6500 hash code inline.
6501
6502 * dispnew.c (verify_row_hash): Call row_hash for computing the
6503 hash code of a row, instead of duplicating code from xdisp.c.
6504
6505 * dispextern.h (row_hash): Add prototype.
6506
a2addb04
TH
65072011-11-18 Tassilo Horn <tassilo@member.fsf.org>
6508
6509 * frame.c (delete_frame): Don't delete the terminal when the last
6510 X frame is closed if emacs is built with GTK toolkit.
6511
df85d315
JB
65122011-11-17 Juanma Barranquero <lekktu@gmail.com>
6513
6514 * window.c (syms_of_window) <window-combination-resize>: Fix typo.
6515
a0c2d0ae
MR
65162011-11-17 Martin Rudalics <rudalics@gmx.at>
6517
6518 * window.c (Vwindow_splits): Rename to
6519 Vwindow_combination_resize. Suggested by Juri Linkov.
6520 (Fsplit_window_internal): Use Vwindow_combination_resize instead
6521 of Vwindow_splits.
6522
58179cce
JB
65232011-11-16 Juanma Barranquero <lekktu@gmail.com>
6524
7877f373
JB
6525 * nsfns.m (Fns_font_name):
6526 * window.c (syms_of_window) <window-combination-limit>: Fix typos.
58179cce 6527
b6f67890
MR
65282011-11-16 Martin Rudalics <rudalics@gmx.at>
6529
6530 * window.h (window): Rename slot "nest" to "combination_limit".
6531 * window.c (Fwindow_nest): Rename to Fwindow_combination_limit.
6532 (Fset_window_nest): Rename to Fset_window_combination_limit.
6533 (Vwindow_nest): Rename to Vwindow_combination_limit.
6534 (recombine_windows, make_parent_window, make_window)
6535 (Fsplit_window_internal, saved_window)
6536 (Fset_window_configuration, save_window_save): Rename all
6537 occurrences of window_nest to window_combination_limit.
6538
c7015153
JB
65392011-11-15 Juanma Barranquero <lekktu@gmail.com>
6540
6541 * image.c (imagemagick_load_image): Fix typo.
6542
322ad6ec
EZ
65432011-11-14 Eli Zaretskii <eliz@gnu.org>
6544
6545 * xdisp.c (display_line): Move the call to
6546 highlight_trailing_whitespace before the call to
6547 compute_line_metrics, since the latter needs to see the final
6d5eb5b0
SM
6548 faces of all the glyphs to compute ROW's hash value.
6549 Fixes assertion violations in row_equal_p. (Bug#10035)
322ad6ec 6550
f067b8ec
JB
65512011-11-14 Juanma Barranquero <lekktu@gmail.com>
6552
6553 * w32proc.c (reader_thread): Don't check pending input if cp->fd < 0,
6554 just return (bug#10044).
6555
1e5b2111
EZ
65562011-11-12 Eli Zaretskii <eliz@gnu.org>
6557
7ef3cbd5
EZ
6558 * makefile.w32-in (HEAPSIZE): New variable, allows to build temacs
6559 with user-defined heap size. Bump the default size of the temacs
6560 heap to 27MB, to avoid memory warning when running temacs.
6561 ($(TEMACS)): Use HEAPSIZE instead of a hardcoded value.
6562
1e5b2111
EZ
6563 * dispnew.c (scrolling_window): Fix incorrect indices in accessing
6564 current_matrix and desired_matrix. (Bug#9990)
7a7270dd
EZ
6565 (verify_row_hash) [XASSERTS]: New function.
6566 (adjust_glyph_matrix, row_equal_p): Use it in xassert to verify
6567 that the hash value of glyph rows is correct.
1e5b2111 6568
89d61221
MR
65692011-11-12 Martin Rudalics <rudalics@gmx.at>
6570
6571 * window.h (window): Remove splits slot.
6572 * window.c (Fwindow_splits, Fset_window_splits): Remove.
6573 (Fdelete_other_windows_internal, make_parent_window)
6574 (make_window, Fsplit_window_internal, Fdelete_window_internal)
6575 (Fset_window_configuration, save_window_save): Don't deal with
6576 split status of windows.
6577 (saved_window): Remove splits slot.
6578 (Vwindow_splits): Rewrite doc-string.
6579
97f18cc8
JD
65802011-11-11 Jan Djärv <jan.h.d@swipnet.se>
6581
6582 * xfns.c (unwind_create_frame):
6583 * nsfns.m (unwind_create_frame):
6584 * w32fns.c (unwind_create_frame): Use Fmemq to check if frame is in
6585 Vframe_list (Bug#9999).
6586
22a648b4
DA
65872011-11-11 Dmitry Antipov <dmantipov@yandex.ru>
6588
0b381c7e 6589 * xdisp.c (syms_of_xdisp): Remove duplicated definition of Qtext.
22a648b4 6590
659afede
KH
65912011-11-11 Kenichi Handa <handa@m17n.org>
6592
6593 * callproc.c (Fcall_process): Set the member dst_multibyte of
6594 process_coding.
6595
9ac0394b
KH
65962011-11-11 Johan Bockgård <bojohan@gnu.org>
6597
6598 * xdisp.c (fill_composite_glyph_string): Always set s->face, to
6599 avoid a crash (bug#9496).
6600
2fbdc249
CY
66012011-11-09 Chong Yidong <cyd@gnu.org>
6602
6603 * window.c (Fwindow_inside_edges, Fwindow_inside_pixel_edges)
6604 (Fwindow_inside_absolute_pixel_edges): Only allow live windows.
6605
ac6b1f81
PE
66062011-11-08 Paul Eggert <eggert@cs.ucla.edu>
6607
6608 * s/gnu.h (GC_MARK_STACK): Define to GC_MAKE_GCPROS_NOOPS (Bug#9926).
6609
09db192c
PE
66102011-11-08 Paul Eggert <eggert@cs.ucla.edu>
6611
6612 Avoid some portability problems by eschewing 'extern inline' functions.
6613 The trivial performance wins aren't worth the portability hassles; see
6614 <http://lists.gnu.org/archive/html/emacs-devel/2011-11/msg00084.html>
6615 et seq.
6616 * dispextern.h (window_box, window_box_height, window_text_bottom_y)
6617 (window_box_width, window_box_left, window_box_left_offset)
6618 (window_box_right, window_box_right_offset): Undo previous change,
6619 by removing the "extern"s.
6620 * intervals.c (adjust_intervals_for_insertion)
6621 (adjust_intervals_for_deletion): Undo previous change,
6622 making these static again.
6623 (offset_intervals, temp_set_point_both, temp_set_point)
6624 (copy_intervals_to_string): No longer inline.
6625 * xdisp.c (window_text_bottom_y, window_box_width)
6626 (window_box_height, window_box_left_offset)
6627 (window_box_right_offset, window_box_left, window_box_right)
6628 (window_box): No longer inline.
6629
105216ed
CY
66302011-11-08 Chong Yidong <cyd@gnu.org>
6631
6632 * window.c (Fwindow_left_column, Fwindow_top_line): Doc fix.
6d5eb5b0
SM
6633 (Fwindow_body_height, Fwindow_body_width): Move from Lisp.
6634 Signal an error if not a live window.
105216ed
CY
6635 (Fwindow_total_width, Fwindow_total_height): Move from Lisp.
6636 (Fwindow_total_size, Fwindow_body_size): Move to Lisp.
6637
ae9e237f
JB
66382011-11-07 Juanma Barranquero <lekktu@gmail.com>
6639
6640 * lisp.h (syms_of_abbrev): Remove declaration.
6641 Reported by CHENG Gao <chenggao@royau.me>.
6642
c7aa8333
EZ
66432011-11-07 Eli Zaretskii <eliz@gnu.org>
6644
6645 * w32.c (check_windows_init_file): Don't look for term/w32-win.el
6646 if Vpurify_flag is non-nil. Fixes a crash when running w32 build
6647 of temacs in GUI mode.
6648
be7f5545
MR
66492011-11-07 Martin Rudalics <rudalics@gmx.at>
6650
6651 * window.h: Declare delete_all_child_windows instead of
6652 delete_all_subwindows.
6653 * window.c (Fwindow_nest, Fset_window_nest)
6654 (Fset_window_new_total, Fset_window_new_normal)
6655 (Fwindow_resize_apply): Don't use term subwindow in doc-strings.
6656 (delete_all_subwindows): Rename to delete_all_child_windows.
6657 (Fdelete_other_windows_internal, Fset_window_configuration):
6658 Call delete_all_child_windows instead of delete_all_subwindows.
6659 * frame.c (delete_frame): Call delete_all_child_windows instead
6660 of delete_all_subwindows.
6661
ca78dc43
PE
66622011-11-07 Paul Eggert <eggert@cs.ucla.edu>
6663
6664 * alloc.c (DEADP): New macro, for porting to GNU/Hurd (Bug#9926).
6665 This is also needed for porting to any host where GC_MARK_STACK is
6666 not GC_MAKE_GCPROS_NOOPS.
6667 (which_symbols): Use it.
6668
a0241d01
KH
66692011-11-07 Kenichi Handa <handa@m17n.org>
6670
6671 * coding.c (coding_set_destination): Check coding->src_pos only
6672 when coding->src_object is a buffer (bug#9910).
6673
6674 * process.c (send_process): Set the member src_multibyte of coding
6675 to 0 (bug#9911) when sending a unibyte text.
6676
6677 * callproc.c (Fcall_process): Set the member src_multibyte of
6678 process_coding to 0 (bug#9912).
6679
a64bfdfa 66802011-11-06 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
ba24cea2
YM
6681
6682 * xmenu.c (cleanup_widget_value_tree): New function.
6683 (xmenu_show, xdialog_show): Use it in record_unwind_protect instead of
6684 calling free_menubar_widget_value_tree directly (Bug#9830).
6685
cb41b32a
PE
66862011-11-06 Paul Eggert <eggert@cs.ucla.edu>
6687
6688 Fix some portability problems with 'inline'.
6689 * dispextern.h (window_box, window_box_height, window_text_bottom_y)
6690 (window_box_width, window_box_left, window_box_left_offset)
6691 (window_box_right, window_box_right_offset): Declare extern.
6692 Otherwise, these inline functions do not conform to C99 and
6693 are miscompiled by Microsoft compilers. Reported by Eli Zaretskii in
6694 <http://lists.gnu.org/archive/html/emacs-devel/2011-11/msg00084.html>.
6695 * intervals.c (adjust_intervals_for_insertion)
6696 (adjust_intervals_for_deletion): Now extern, because otherwise the
6697 extern inline functions 'offset_intervals' couldn't refer to it.
6698 (static_offset_intervals): Remove.
6699 (offset_intervals): Rewrite using the old contents of
6700 static_offset_intervals. The old version didn't conform to C99
6701 because an extern inline function contained a reference to an
6702 identifier with static linkage.
6703
b7041366
AS
67042011-11-06 Andreas Schwab <schwab@linux-m68k.org>
6705
6706 * keyboard.c (interrupt_signal): Don't call kill-emacs while in
6707 GC.
6708
88a37c4d
EZ
67092011-11-06 Eli Zaretskii <eliz@gnu.org>
6710
6711 * xdisp.c (init_iterator, reseat_to_string): Don't set the
6712 iterator's bidi_p flag if Vpurify_flag is non-nil. (Bug#9963)
6713 (Fcurrent_bidi_paragraph_direction): If Vpurify_flag is non-nil,
6714 return Qleft_to_right.
6715
49745b39
CY
67162011-11-06 Chong Yidong <cyd@gnu.org>
6717
6718 * window.c (Fwindow_live_p, Fwindow_frame, Fframe_root_window)
6719 (Fminibuffer_window, Fwindow_buffer, Fwindow_splits)
6720 (Fset_window_splits, Fwindow_nest, Fset_window_nest)
6721 (Fwindow_use_time, Fwindow_total_size, Fwindow_normal_size)
6722 (Fwindow_new_normal, Fwindow_left_column, Fwindow_top_line)
6723 (Fwindow_margins, Fwindow_fringes, Fwindow_scroll_bars)
6724 (Fwindow_vscroll): Doc fix.
6725 (Fwindow_top_child, Fwindow_left_child): Eliminate a nil default
6726 argument, since it makes no sense to pass a live window and for
6727 consistency with window-child.
6728
1f05cd82
CS
67292011-11-05 Christoph Scholtes <cschol2112@googlemail.com>
6730
6731 * makefile.w32-in ($(TEMACS), (gl-stamp)): Use $(THISDIR) to
6732 support MSVC.
6733
22610910
JR
67342011-11-05 Jason Rumney <jasonr@gnu.org>
6735
6736 * w32font.c (font_matches_spec): Filter out non-Japanese kana fonts.
6737 (add_font_entity_to_list): Filter out non-Japanese Shift-JIS
6738 fonts (Bug#6029).
6739 (add_font_entity_to_list): Fix logic errors in mixed boolean and
6740 bitwise arithmetic preventing use of unicode-sip and non-truetype
6741 opentype fonts.
6742
a06776b2
EZ
67432011-11-05 Eli Zaretskii <eliz@gnu.org>
6744
3ad924ba
EZ
6745 * s/ms-w32.h (fstat, stat, utime): Move redirections to
6746 "emacs"-only part.
6747
a06776b2
EZ
6748 * w32fns.c (x_create_tip_frame, Fx_create_frame): Rearrange
6749 initialization code to keep similarity to xfns.c after changes
6750 from 2011-11-05.
6751
c9e7db78
JD
67522011-11-05 Jan Djärv <jan.h.d@swipnet.se>
6753
a97f8f3f
JD
6754 * nsfns.m: Declare image_cache_refcount if GLYPH_DEBUG.
6755 (unwind_create_frame): New function (Bug#9943).
6756 (Fx_create_frame): Restructure code to be more similar to the one in
6757 xfns.c. Call record_unwind_protect with unwind_create_frame (Bug#9943).
6758 Initialize image_cache_refcount if GLYPH_DEBUG (Bug#9943).
6759 Move terminal->reference_count++ just before making the frame official
6760 (Bug#9943).
6761
6762 * nsterm.m (x_free_frame_resources): New function.
6763 (x_destroy_window): Move code to x_free_frame_resources.
6764
c9e7db78 6765 * xfns.c (unwind_create_frame): Fix comment.
6d5eb5b0
SM
6766 (Fx_create_frame, x_create_tip_frame):
6767 Move terminal->reference_count++ just before making the frame
75f1671a 6768 official. Move initialization of image_cache_refcount and
c9e7db78
JD
6769 dpyinfo_refcount before calling init_frame_faces (Bug#9943).
6770
a6fc3b5c
EZ
67712011-11-05 Eli Zaretskii <eliz@gnu.org>
6772
6773 Support MSVC build with newer versions of Visual Studio.
6774 * makefile.w32-in (TAGS-gmake): Don't use $(patsubst ...), as
6775 Nmake barfs on that. Use $(OBJ*_c) variables instead, defined on
6776 nt/gmake.defs.
6777
6778 * lisp.h (ENUM_BF): New macro, for enumerated types in bitfields,
6779 which are not supported by MSVC.
6780 (Lisp_Symbol, Lisp_Misc_Any, Lisp_Marker, Lisp_Misc_Overlay)
6781 (Lisp_Save_Value, Lisp_Free): Use ENUM_BF for enumerated types in
6782 bitfields.
6783 (Lisp_Object) [USE_LISP_UNION_TYPE]: Use ENUM_BF for enumerated
6784 types in bitfields.
6785 (DEFUN) [_MSC_VER]: Define in a different way for MSVC.
6786
6787 * w32fns.c [_MSC_VER]: DECLARE_HANDLE for any MSVC version.
6788
58179cce 67892011-11-05 Fabrice Popineau <fabrice.popineau@supelec.fr> (tiny change)
a6fc3b5c
EZ
6790
6791 Support MSVC build with newer versions of Visual Studio.
6792 * w32.c: Don't include w32api.h for MSVC.
6793 (init_environment) [_MSC_VER]: Call sys_access, not _access.
6794
6795 * s/ms-w32.h <sigset_t, ssize_t> [_MSC_VER]: Typedefs for MSVC.
6796 [_MSC_VER]: Include sys/timeb.h, sys/stat.h, and signal.h.
6797 (fstat, stat, utime) [_MSC_VER]: Redirect to their sys_* cousins.
6798 (malloc, free, realloc, calloc) [_MSC_VER]: Always redirect to the
6799 e_* cousins.
6800 (alloca) [_MSC_VER]: Define to _alloca.
6801
6802 * lisp.h (DECL_ALIGN) [_MSC_VER]: Define for MSVC.
6803
6804 * regex.c <re_char> [_MSC_VER]: A separate definition for MSVC.
6805
a58c13ed
EZ
68062011-11-04 Eli Zaretskii <eliz@gnu.org>
6807
6808 * xdisp.c (note_mouse_highlight): If either of
6809 previous/next-single-property-change returns nil, treat that as
6810 the beginning or the end of the buffer. (Bug#9955)
6811
fe0b6370
JD
68122011-11-04 Jan Djärv <jan.h.d@swipnet.se>
6813
a58c13ed 6814 * gtkutil.c (xg_make_tool_item): Add callbacks if one of wimage or
fe0b6370
JD
6815 label is not null (Bug#9951).
6816 (xg_tool_item_stale_p): Handle the fact that wimage and/or wlbl
6817 may be NULL.
6818
89bd5ee1
EZ
68192011-11-04 Eli Zaretskii <eliz@gnu.org>
6820
6821 * window.c (Fwindow_body_size): Mention in the doc string that the
6822 return value is in frame's canonical units. (Bug#9949)
6823
84c3edb9
EZ
68242011-11-03 Eli Zaretskii <eliz@gnu.org>
6825
4e2fb5c7
EZ
6826 * xdisp.c (note_mouse_highlight): Initialize `area'. (Bug#9947)
6827
84c3edb9 6828 * w32fns.c (unwind_create_frame): If needed, free the glyph
3ab15fd6 6829 matrices of the partially constructed frame. (Bug#9943)
2a58bbc1 6830 * xfns.c (unwind_create_frame): Likewise.
84c3edb9 6831
bc17a887
EZ
68322011-11-01 Eli Zaretskii <eliz@gnu.org>
6833
6834 * xdisp.c (mouse_face_from_buffer_pos): Fix a typo in a comment.
6835 Don't stop backward scan on the continuation glyph, even though
6836 its CHARPOS is positive.
6d5eb5b0
SM
6837 (mouse_face_from_buffer_pos, note_mouse_highlight):
6838 Rename cover_string to disp_string.
bc17a887 6839
4ee88440
MR
68402011-11-01 Martin Rudalics <rudalics@gmx.at>
6841
6842 * window.c (temp_output_buffer_show): Don't use
6843 Vtemp_buffer_show_specifiers.
6844 (Vtemp_buffer_show_specifiers): Remove unused variable.
6845
c2ff3c02
EZ
68462011-10-30 Eli Zaretskii <eliz@gnu.org>
6847
6848 * xdisp.c (try_cursor_movement): Make sure ROW isn't decremented
6849 past the beginning of the current glyph matrix.
6850
58179cce 68512011-10-30 Adam Sjøgren <asjo@koldfront.dk> (tiny change)
6e56383b
JD
6852
6853 * xterm.c: Include X11/Xproto.h if HAVE_GTK3.
6854 (x_error_handler): Ignore BadMatch for X_SetInputFocus for
6855 HAVE_GTK3 (Bug#9869).
b77a6a7f 6856
3b574623
JD
6857 * gtkutil.c (xg_win_to_widget, xg_event_is_for_menubar): Initialize
6858 type to GDK_NOTHING so valgrind does not complain (Bug#9901).
6859
b77a6a7f
JD
6860 * xterm.h (x_display_info): Add Xatom_net_wm_state_hidden (Bug#9893).
6861
6862 * xterm.c: Declare x_handle_net_wm_state to return int.
6863 (handle_one_xevent): Check if we are iconified but don't have
6864 _NET_WM_STATE_HIDDEN. If do, treat as deiconify (Bug#9893).
6865 (get_current_wm_state): Return non-zero if not hidden,
6866 check for _NET_WM_STATE_HIDDEN (Bug#9893).
6867 (do_ewmh_fullscreen): Ignore return value from get_current_wm_state.
6868 (x_handle_net_wm_state): Return what get_current_wm_state returns.
6869 (x_term_init): Initialize dpyinfo->Xatom_net_wm_state_hidden.
6870
196e41e4
PE
68712011-10-29 Paul Eggert <eggert@cs.ucla.edu>
6872
6873 * alloc.c (which_symbols): Declare EXTERNALLY_VISIBLE,
6874 so that this new function doesn't get optimized away by a
6875 whole-program optimizer. Make the 2nd arg EMACS_INT, not int.
6876
021f2e1a
AS
68772011-10-29 Andreas Schwab <schwab@linux-m68k.org>
6878
6879 * frame.h (MOUSE_HL_INFO): Remove excess parens.
6880
8b058d44
EZ
68812011-10-29 Eli Zaretskii <eliz@gnu.org>
6882
6883 Fix the `xbytecode' command.
6884 * .gdbinit (xprintbytestr): New command.
b50a28de 6885 (xwhichsymbols): Rename from `which'; all callers changed.
8b058d44
EZ
6886 (xbytecode): Print the byte-code string as well.
6887
4452fb80
EZ
68882011-10-29 Kim Storm <storm@cua.dk>
6889
8b058d44
EZ
6890 * alloc.c (which_symbols): New function.
6891
21b72067
AS
68922011-10-29 Andreas Schwab <schwab@linux-m68k.org>
6893
6894 * minibuf.c (read_minibuf_noninteractive): Allow reading empty
6895 line. (Bug#9903)
6896
83ed7b5c
GM
68972011-10-29 Glenn Morris <rgm@gnu.org>
6898
6899 * process.c (wait_reading_process_output): Revert 2009-08-30 change.
6900 Not clear what it was for, and it causes various bugs. (Bug#9839)
6901
5a7a728b
EZ
69022011-10-28 Eli Zaretskii <eliz@gnu.org>
6903
6904 * xdisp.c (note_mouse_highlight): Initialize `part', to avoid a
6905 possible random value that matches one of those tested as
6906 condition to clear the mouse face.
6907
d3d0842f
CY
69082011-10-28 Chong Yidong <cyd@gnu.org>
6909
6910 * xdisp.c (note_mouse_highlight): Fix use of uninitialized var.
6911
31b39d13
DN
69122011-10-28 Dan Nicolaescu <dann@ics.uci.edu>
6913
6914 * window.c (make_window): Initialize phys_cursor_on_p.
6915
9aba6043
SM
69162011-10-28 Stefan Monnier <monnier@iro.umontreal.ca>
6917
6918 * lisp.h (struct Lisp_Symbol): Update comments.
6919
c20992f4
JB
69202011-10-28 Juanma Barranquero <lekktu@gmail.com>
6921
6922 * w32font.c (w32_load_unicows_or_gdi32): Add missing return.
6923
db4f02f2
EZ
69242011-10-28 Eli Zaretskii <eliz@gnu.org>
6925
6926 Fix Emacs on Windows 9X (bug#8562). Thanks to oslsachem
6927 <oslsachem@gmail.com> for helping to debug this.
6928
6929 * w32font.c (g_b_init_is_w9x, g_b_init_get_outline_metrics_w)
6930 (g_b_init_get_text_metrics_w, g_b_init_get_glyph_outline_w)
6931 (g_b_init_get_glyph_outline_w): New static variables.
6932 (GetOutlineTextMetricsW_Proc, GetTextMetricsW_Proc)
6933 (GetGlyphOutlineW_Proc): New typedefs.
6934 (w32_load_unicows_or_gdi32, get_outline_metrics_w)
9aba6043
SM
6935 (get_text_metrics_w, get_glyph_outline_w, globals_of_w32font):
6936 New functions.
6937 (w32font_open_internal, compute_metrics):
6938 Call get_outline_metrics_w, get_text_metrics_w, and get_glyph_outline_w
db4f02f2
EZ
6939 instead of calling the "wide" APIs directly.
6940
6941 * emacs.c (main) [HAVE_NTGUI]: Call globals_of_w32font.
6942
6943 * w32.h (syms_of_w32font): Add prototype.
6944
87e68db4
JB
69452011-10-27 Juanma Barranquero <lekktu@gmail.com>
6946
6947 * window.c (Fframe_root_window, Fframe_first_window, Fwindow_end)
6948 (Fframe_selected_window, Ftemp_output_buffer_show, Fnext_window)
6949 (Fdelete_window_internal, Fwindow_parameters): Fix typos in docstrings.
6950 (Fmove_to_window_line): Doc fix.
6951
435c1d67
CY
69522011-10-27 Chong Yidong <cyd@gnu.org>
6953
6954 * process.c (make_process): Set gnutls_state to NULL.
6955
6956 * gnutls.c (emacs_gnutls_deinit): Deinit the gnutls_state if it is
6957 non-NULL, regardless of GNUTLS_INITSTAGE.
6958 (Fgnutls_boot): Cleanups. Call emacs_gnutls_deinit if we signal
6959 an error. Set process slots as soon as we allocate them.
6960
6961 * gnutls.h (GNUTLS_LOG, GNUTLS_LOG2): Fix macros.
6962
9c6c6f49
CY
69632011-10-27 Chong Yidong <cyd@gnu.org>
6964
9aba6043
SM
6965 * gnutls.c (emacs_gnutls_deinit): New function.
6966 Deallocate credentials structures as well as calling gnutls_deinit.
9c6c6f49
CY
6967 (Fgnutls_deinit, Fgnutls_boot): Use it.
6968
6969 * process.c (make_process): Initialize GnuTLS credentials to NULL.
6970 (deactivate_process): Call emacs_gnutls_deinit.
6971
657d08d3
JB
69722011-10-27 Juanma Barranquero <lekktu@gmail.com>
6973
6974 * image.c (x_create_x_image_and_pixmap):
6975 * w32.c (sys_rename, w32_delayed_load):
6976 * w32font.c (fill_in_logfont):
6977 * w32reg.c (x_get_string_resource): Silence compiler warnings.
6978
5430d399
JB
69792011-10-26 Juanma Barranquero <lekktu@gmail.com>
6980
6981 * w32fns.c (w32_default_color_map): New function,
6982 extracted from Fw32_default_color_map.
a7ef684b 6983 (Fw32_default_color_map, Fx_open_connection): Use it. (Bug#9785)
5430d399 6984
fe0055fa
PE
69852011-10-25 Paul Eggert <eggert@cs.ucla.edu>
6986
6987 * dispextern.h (Fcontrolling_tty_p): New decl (Bug#6649 part 2).
6988
e6346438
SM
69892011-10-25 Stefan Monnier <monnier@iro.umontreal.ca>
6990
6991 * keyboard.c (test_undefined): New function (bug#9751).
6992 (read_key_sequence): Use it to detect when a key is bound to `undefined'.
6993
e112cc37
ET
69942011-10-25 Enami Tsugutomo <tsugutomo.enami@jp.sony.com>
6995
6996 * sysdep.c (init_sys_modes): Fix the check for the controlling
6997 terminal (Bug#6649).
6998
7b5d6677
EZ
69992011-10-20 Eli Zaretskii <eliz@gnu.org>
7000
7001 * dispextern.h (struct bidi_it): New member next_en_type.
7002
7003 * bidi.c (bidi_line_init): Initialize the next_en_type member.
7004 (bidi_resolve_explicit_1): When next_en_pos is valid for the
7005 current character, check also for next_en_type being WEAK_EN.
7006 (bidi_resolve_weak): Don't enter the expensive loop if the current
7007 position is before next_en_pos. Record the bidi type of the first
7008 non-ET, non-BN character we find, in addition to its position.
7009 (bidi_level_of_next_char): Invalidate next_en_type when
7010 next_en_pos is over-stepped.
7011
7da0b018
PE
70122011-10-20 Paul Eggert <eggert@cs.ucla.edu>
7013
7014 Time zone name fixes for non-ASCII locales (Bug#641, Bug#9794)
7015 * editfns.c: Rewrite current-time-zone so that it invokes
7016 the equivalent of (format-time-string "%Z") to get the time zone name.
7017 This fixes a bug when the time zone name contains characters that
7018 need converting from the system time locale to Emacs internal format.
7019 This fixes a shortcoming that I introduced in my 1999-10-19 patch:
7020 that patch fixed format-time-string to do the conversion, but
7021 I forgot to fix current-time-zone.
7022 (format_time_string): New function, containing most of
7023 what Fformat_time_string used to contain.
7024 (Fformat_time_string): Rewrite in terms of format_time_string.
7025 This doesn't change this function's behavior.
7026 (current-time-zone): Rewrite to use format_time_string.
7027 This fixes the bug reported by Michael Schierl in
7028 <http://lists.gnu.org/archive/html/emacs-devel/2007-06/msg00334.html>.
7029 Jason Rumney's 2007-06-07 change worked around this bug, but
7030 didn't fix it.
7031 * systime.h (tzname, timezone): Remove no-longer-used declarations.
7032
8547b010
EZ
70332011-10-19 Eli Zaretskii <eliz@gnu.org>
7034
7035 * xdisp.c (start_display): If the character at POS is displayed
7036 via a display vector, reset IT->current.dpvec_index to zero.
12b32963
EZ
7037 (try_window_reusing_current_matrix): If a line ends in a display
7038 vector or the next line starts in a display vector, continue
7039 redrawing the window even though the character position of
7040 start_row was reached.
8547b010
EZ
7041 (Bug#9771, part 2)
7042
4e948d15
CY
70432011-10-18 Chong Yidong <cyd@gnu.org>
7044
7045 * xdisp.c (get_next_display_element): Handle U+2010 and U+2011
7046 with nobreak-char-display too.
7047
4787455f
EZ
70482011-10-18 Eli Zaretskii <eliz@gnu.org>
7049
7050 Fix part 3 of bug#9771.
7051 * bidi.c (bidi_line_init): Initialize next_en_pos to zero, not -1.
7052 (bidi_resolve_neutral): Don't enter the expensive loop looking for
7053 non-neutral characters if the current character is a paragraph
7054 separator (a.k.a. Newline). This avoids running the same
7055 expensive loop twice, once when we consume the preceding newline
7056 and the other time when the line actually needs to be displayed.
7057 Avoid the loop when we see neutrals on the base embedding level
7058 following a character whose directionality is the same as the
7059 paragraph's. This avoids running the expensive loop when a line
7060 ends in a long sequence of neutrals, like control characters.
7061 Add assertion against STRONG_AL type. Slightly rearrange code
7062 that determines the type of a neutral given the first non-neutral
7063 that follows it.
7064 (bidi_level_of_next_char): Set next_en_pos to zero when
7065 invalidating its info.
7066
2c91f553
EZ
70672011-10-17 Eli Zaretskii <eliz@gnu.org>
7068
7069 * xdisp.c (push_display_prop): Determine whether to record string
7070 or buffer position by IT->string, not by IT->method. Allow
7071 GET_FROM_DISPLAY_VECTOR as IT->method on entry. (Bug#9771, part 4)
f2ff9e88
EZ
7072 (move_it_vertically_backward): Don't look for character position
7073 immediately after the newline when in a continuation line.
7074 (Bug#9771, part 1)
2c91f553 7075
c7b08b0d
MR
70762011-10-15 Martin Rudalics <rudalics@gmx.at>
7077
7078 * window.c (coordinates_in_window): Rewrite and delabelize
7079 vertical border check. (Bug#5357) (Bug#9618)
7080
6b02f655
SM
70812011-10-14 Stefan Monnier <monnier@iro.umontreal.ca>
7082
7083 * xterm.c (frame_highlight, frame_unhighlight): Ignore unexplained
7084 errors in XSetWindowBorder (bug#9310).
7085
81d40c92
DA
70862011-10-13 Dmitry Antipov <dmantipov@yandex.ru>
7087
7088 * editfns.c (Fset_time_zone_rule): Replace free with xfree to
7089 avoid crash when xmalloc overrun checking is enabled.
7090
d4172c3b
EZ
70912011-10-13 Eli Zaretskii <eliz@gnu.org>
7092
7093 * xdisp.c (Fcurrent_bidi_paragraph_direction): Initialize
7094 itb.paragraph_dir to NEUTRAL_DIR. Fixes an occasional incorrect
7095 cursor motion with <left> and <right> arrow keys.
7096
7097 * bidi.c (bidi_init_it): Don't initialize paragraph_dir here, as
7098 some callers set that themselves.
7099
b00eea75
EZ
71002011-10-12 Eli Zaretskii <eliz@gnu.org>
7101
7102 * xdisp.c (find_row_edges): Handle the case where ROW comes from a
7103 display string and the previous row comes from the same string and
7104 is empty. (Bug#9739) (Bug#9738)
7105
8fe012c4
SM
71062011-10-12 Stefan Monnier <monnier@iro.umontreal.ca>
7107
7108 * doc.c (get_doc_string): Encode file name (bug#9735).
7109
0074aef2
EZ
71102011-10-12 Eli Zaretskii <eliz@gnu.org>
7111
79beb178
EZ
7112 * bidi.c (bidi_level_of_next_char):
7113 * xdisp.c (get_visually_first_element): Remove old incorrect
7114 comments regarding the Unicode Line Separator character.
7115
0074aef2
EZ
7116 * bidi.c (bidi_init_it): Initialize paragraph_dir to NEUTRAL_DIR.
7117
6e4b3fbe
DA
71182011-10-12 Dmitry Antipov <dmantipov@yandex.ru>
7119
7120 * alloc.c (Fgc_status): Do not access beyond zombies array
7121 boundary if nzombies > MAX_ZOMBIES.
7122 * alloc.c (dump_zombies): Add missing format specifier.
7123
0324f3af
PE
71242011-10-12 Paul Eggert <eggert@cs.ucla.edu>
7125
b5525cac
PE
7126 * xdisp.c (set_cursor_from_row): Simplify conditionals,
7127 to pacify GCC 4.6.1 x86-64 with -O2 -Wstrict-overflow.
7128
0324f3af
PE
7129 * lread.c (read_escape): Allow hex escapes as large as ?\xfffffff.
7130 Some packages use them to denote characters with modifiers.
7131
e9b5f888
AS
71322011-10-11 Andreas Schwab <schwab@linux-m68k.org>
7133
7134 * lisp.h (GCPRO1_VAR, GCPRO2_VAR, GCPRO3_VAR, GCPRO4_VAR)
7135 (GCPRO5_VAR, GCPRO6_VAR, UNGCPRO_VAR): Add whitespace to avoid
7136 matching a pp-number. Rename parameter var to var1.
7137
127827c0
SM
71382011-10-11 Stefan Monnier <monnier@iro.umontreal.ca>
7139
7140 * minibuf.c (Finternal_complete_buffer): Fix last change (bug#9709).
7141
c8fd3bd0
GM
71422011-10-08 Glenn Morris <rgm@gnu.org>
7143
7144 * callint.c (Fcall_interactively): Give a more explicit error for the
7145 'c' case with a non-character input. (Bug#8479)
7146
352ec8ff
EZ
71472011-10-08 Eli Zaretskii <eliz@gnu.org>
7148
03669ccb
EZ
7149 * xdisp.c (hscroll_window_tree): Support hscroll in right-to-left
7150 lines.
7061c986
EZ
7151 (set_cursor_from_row): Fix cursor positioning in mixed L2R+R2L
7152 lines that are hscrolled on the left.
03669ccb 7153
352ec8ff
EZ
7154 * dispnew.c (buffer_posn_from_coords): Account for a possible
7155 presence of header-line. (Bug#4426)
7156
a66cfb1c
SM
71572011-10-07 Stefan Monnier <monnier@iro.umontreal.ca>
7158
6b02f655
SM
7159 * buffer.c (syms_of_buffer) <enable-multibyte-characters>:
7160 Don't advertise functionality which we discourage or doesn't work.
a66cfb1c 7161
7c5ee88e
PE
71622011-10-07 Paul Eggert <eggert@cs.ucla.edu>
7163
7164 * alloc.c (GC_LISP_OBJECT_ALIGNMENT): Use offsetof, not __alignof__
7165 or sizeof. __alignof__ gives the wrong answer on Fedora x86-64
7166 with GCC 4.6.1 when configured with CC='gcc -m32' --with-wide-int;
7167 this makes Emacs dump core during garbage collection on rare
7168 occasions. sizeof is obviously inferior to offsetof here, so
7169 stick with offsetof.
7170 (GC_POINTER_ALIGNMENT): New macro.
7171 (mark_memory): Omit 3rd (offset) arg; caller changed.
7172 Don't assume EMACS_INT alignment is the same as pointer alignment.
7173
df1bbe5b
SM
71742011-10-03 Stefan Monnier <monnier@iro.umontreal.ca>
7175
7176 * keyboard.c (read_key_sequence_remapped): New var.
7177 (read_key_sequence): Compute remapping in the right buffer.
7178 (command_loop_1): Use read_key_sequence's remapping directly.
7179
51553db6
SM
71802011-10-02 Stefan Monnier <monnier@iro.umontreal.ca>
7181
32c1fffd
SM
7182 * dired.c (file_name_completion): Don't expand file name.
7183 (Ffile_name_completion, Ffile_name_all_completions): Expand file name
7184 before checking file name handler.
7185
51553db6
SM
7186 * minibuf.c (Finternal_complete_buffer): Only show internal buffers if
7187 they've been requested explicitly (bug#9591).
7188
b6bd1599 71892011-10-01 Andreas Schwab <schwab@linux-m68k.org>
fa2ec41f
AS
7190
7191 * keymap.c (Fsingle_key_description): Use make_specified_string
7192 instead of build_string to build string from push_key_description.
7193 (Bug#5193)
7194
f701dc2a
PE
71952011-09-30 Paul Eggert <eggert@cs.ucla.edu>
7196
4222c55d
PE
7197 * buffer.h (struct buffer): Use time_t, not int, for a time stamp.
7198 This fixes a Y2038 bug on 64-bit hosts.
7199 * buffer.c (reset_buffer):
7200 * fileio.c (Fdo_auto_save, Fset_buffer_auto_saved)
7201 (Fclear_buffer_auto_save_failure):
7202 Use 0, not -1, to represent an unset failure time, since time_t
7203 might not be signed.
7204
f701dc2a
PE
7205 Remove dependency on glibc malloc internals.
7206 * alloc.c (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
7207 Move back here from lisp.h, but with their new implementations.
7208 (XMALLOC_BASE_ALIGNMENT, COMMON_MULTIPLE, XMALLOC_HEADER_ALIGNMENT)
7209 (XMALLOC_OVERRUN_SIZE_SIZE): Move these new lisp.h macros here.
7210 * charset.c (charset_table_init): New static var.
7211 (syms_of_charset): Use it instead of xmalloc. This removes a
7212 dependency on glibc malloc internals. See Eli Zaretskii's comment in
7213 <http://lists.gnu.org/archive/html/emacs-devel/2011-09/msg00815.html>.
7214 * lisp.h (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
7215 Move back to alloc.c.
7216 (XMALLOC_BASE_ALIGNMENT, COMMON_MULTIPLE, XMALLOC_HEADER_ALIGNMENT)
7217 (XMALLOC_OVERRUN_SIZE_SIZE): Move to alloc.c.
7218
9ceebf39
JD
72192011-09-30 Jan Djärv <jan.h.d@swipnet.se>
7220
7221 * nsterm.m (windowDidResize): Call x_set_window_size only when
7222 ns_in_resize is true. Otherwise set pixelwidth/height and
7223 call change_frame_size (Bug#9628).
7224
cb993c58
PE
72252011-09-30 Paul Eggert <eggert@cs.ucla.edu>
7226
3930c88b
PE
7227 Port --enable-checking=all to Fedora 14 x86-64.
7228 * charset.c (syms_of_charset): Also account for glibc malloc's
7229 internal overhead when calculating the initial malloc maximum.
7230
cb993c58
PE
7231 Port --enable-checking=all to Fedora 14 x86.
7232 * alloc.c (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
7233 Move to lisp.h.
7234 (xmalloc_put_size, xmalloc_get_size, overrun_check_malloc)
7235 (overrun_check_realloc, overrun_check_free):
7236 Use XMALLOC_OVERRUN_SIZE_SIZE, not sizeof (size_t).
7237 That way, xmalloc returns a properly-aligned pointer even if
7238 XMALLOC_OVERRUN_CHECK is defined. The old debugging code happened
7239 to align OK on typical 64-bit hosts, but not on Fedora 14 x86.
7240 * charset.c (syms_of_charset): Take XMALLOC_OVERRUN_CHECK_OVERHEAD
7241 into account when calculating the initial malloc maximum.
7242 * lisp.h (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
7243 Move here from alloc.c, so that charset.c can use it too.
7244 Properly align; the old code wasn't right for common 32-bit hosts
7245 when configured with --enable-checking=all.
7246 (XMALLOC_BASE_ALIGNMENT, COMMON_MULTIPLE, XMALLOC_HEADER_ALIGNMENT)
7247 (XMALLOC_OVERRUN_SIZE_SIZE): New macros.
7248
31bed486
EZ
72492011-09-29 Eli Zaretskii <eliz@gnu.org>
7250
04c70788 7251 * sysdep.c (snprintf) [!EOVERFLOW]: If EOVERFLOW is not defined,
31bed486
EZ
7252 use EDOM.
7253
fbcaa2f3
EZ
72542011-09-28 Eli Zaretskii <eliz@gnu.org>
7255
7256 * xdisp.c (compute_display_string_end): If there's no display
7257 string at CHARPOS, return -1.
7258
7259 * bidi.c (bidi_fetch_char): When compute_display_string_end
7260 returns a negative value, treat the character as a normal
7261 character not covered by a display string. (Bug#9624)
7262
a239d4e9
JB
72632011-09-28 Juanma Barranquero <lekktu@gmail.com>
7264
7265 * lread.c (Fread_from_string): Fix typo in docstring.
7266
88652fd5
EZ
72672011-09-27 Eli Zaretskii <eliz@gnu.org>
7268
7269 * xdisp.c (handle_invisible_prop): If invisible text ends on a
7270 newline, reseat the iterator instead of bidi-iterating there one
7271 character at a time. (Bug#9610)
32c1fffd
SM
7272 (BUFFER_POS_REACHED_P, move_it_in_display_line_to): Bail when past
7273 TO_CHARPOS if the bidi iterator is at base embedding level.
88652fd5 7274
ed497dd4
AS
72752011-09-27 Andreas Schwab <schwab@linux-m68k.org>
7276
7277 * lread.c (readevalloop): Use correct code for NBSP.
7278 (read1): Likewise. (Bug#9608)
7279
b2bf61aa
MA
72802011-09-25 Michael Albinus <michael.albinus@gmx.de>
7281
7282 * dbusbind.c (Fdbus_register_signal): When service is not
7283 registered, use nil in Vdbus_registered_objects_table. (Bug#9581)
7284
32bbb17c
GM
72852011-09-25 Glenn Morris <rgm@gnu.org>
7286
7287 * buffer.c (truncate-lines): Doc fix.
7288
94e0933e
CY
72892011-09-24 Chong Yidong <cyd@stupidchicken.com>
7290
7291 * window.c (Fwindow_prev_buffers, Fset_window_prev_buffers)
7292 (Fset_window_next_buffers): Doc fix.
7293
cddde921
GM
72942011-09-24 Glenn Morris <rgm@gnu.org>
7295
7296 * minibuf.c (read_minibuf): Disable line truncation. (Bug#5715)
7297
1260aef1
PE
72982011-09-24 Paul Eggert <eggert@cs.ucla.edu>
7299
25b4bfa0
PE
7300 Fix minor problems found by static checking.
7301 * xdisp.c (string_from_display_spec): Don't assume vecsize fits in int.
1260aef1
PE
7302 * indent.c (Fvertical_motion): Fix == vs = typo.
7303
e3cbd34b
EZ
73042011-09-24 Eli Zaretskii <eliz@gnu.org>
7305
a66cfb1c
SM
7306 * dispnew.c (syms_of_display) <redisplay-dont-pause>:
7307 Default value is now t. Doc fix.
6bf7006f 7308
e3cbd34b 7309 * indent.c (Fvertical_motion): Compute and apply the overshoot
32c1fffd 7310 logic when moving up, not only when moving down. Fix the
e3cbd34b 7311 confusing name and values of the it_overshoot_expected variable;
32c1fffd 7312 logic changes accordingly. (Bug#9254) (Bug#9549)
e3cbd34b
EZ
7313
7314 * xdisp.c (pos_visible_p): Produce correct pixel coordinates when
7315 CHARPOS is covered by a display string which includes newlines.
7316 (move_it_vertically_backward): Avoid inflooping when START_CHARPOS
7317 is covered by a display string with embedded newlines.
7318
a3de0cbd
MA
73192011-09-24 Michael Albinus <michael.albinus@gmx.de>
7320
7321 * dbusbind.c (Fdbus_register_signal): Add match rule to
7322 Vdbus_registered_objects_table. (Bug#9581)
a66cfb1c
SM
7323 (Fdbus_register_method, Vdbus_registered_objects_table):
7324 Fix docstring.
a3de0cbd 7325
b260039d
JM
73262011-09-24 Jim Meyering <meyering@redhat.com>
7327
32c1fffd 7328 do not ignore write error for any output size
b260039d
JM
7329 The previous change was incomplete.
7330 While it makes emacs --batch detect the vast majority of stdout
7331 write failures, errors were still ignored whenever the output size is
7332 k * (BUFSIZ+1) - 4. E.g., on a system with BUFSIZ of 4096,
7333 $ emacs --batch --eval '(print (format "%4093d" 0))' > /dev/full \
7334 && echo FAIL: ignored write error
7335 FAIL: ignored write error
7336 $ emacs --batch --eval '(print (format "%20481d" 0))' > /dev/full \
7337 && echo FAIL: ignored write error
7338 FAIL: ignored write error
7339 * emacs.c (Fkill_emacs): Also test ferror. (Bug#9574)
7340
8eca8a7c
AS
73412011-09-23 Andreas Schwab <schwab@linux-m68k.org>
7342
7343 * emacs.c (Fkill_emacs): In noninteractive mode exit
7344 non-successfully if a write error occurred on stdout. (Bug#9574)
7345
3341db62
EZ
73462011-09-21 Eli Zaretskii <eliz@gnu.org>
7347
7348 * xdisp.c (pop_it): Allow it->object that is a cons cell to pass
7349 the xassert test.
7350
7351 * dispextern.h (struct it): Update the comment documenting what
7352 can it->OBJECT be.
7353
8c203dbf
EZ
73542011-09-20 Eli Zaretskii <eliz@gnu.org>
7355
7356 * xdisp.c (set_cursor_from_row): If the row ends in a newline from
7357 a display string, extend search for cursor position to end of row.
7358 (find_row_edges): If the row ends in a newline from a display
7359 string, increment its MATRIX_ROW_END_CHARPOS by one. (Bug#9549)
7360 Handle the case of a display string with multiple newlines.
fd317ddf
EZ
7361 (Fcurrent_bidi_paragraph_direction): Fix search for previous
7362 non-empty line. Fixes confusing cursor motion with arrow keys at
7363 the beginning of a line that starts with whitespace.
8c203dbf 7364
a4824228
LMI
73652011-09-19 Lars Magne Ingebrigtsen <larsi@gnus.org>
7366
7367 * lread.c (Fread_from_string): Document what FINAL-STRING-INDEX is
7368 (bug#9493).
7369
33ed493b
CY
73702011-09-18 Chong Yidong <cyd@stupidchicken.com>
7371
7372 * xfns.c (Fx_create_frame): Handle the bitmapIcon resource as
7373 boolean (Bug#9154).
7374
56cd55c8
EZ
73752011-09-18 Eli Zaretskii <eliz@gnu.org>
7376
7377 * xdisp.c (display_line): Record maximum and minimum buffer
7378 positions even if no glyphs were produced (e.g., by a zero-width
7379 stretch). Fixes bug#9530 on a TTY. Under word-wrap, don't record
7380 buffer positions that will be removed from the glyph row because
7381 they don't fit.
c02dcedf
EZ
7382 (produce_stretch_glyph): Fix a bug in :align-to on a TTY when the
7383 column is beyond frame width: don't subtract 1 "pixel" when
7384 computing width of the stretch.
3e62b7e0
EZ
7385 (reseat_at_next_visible_line_start): Undo the change made on
7386 2011-09-17 that saved paragraph information and restored it after
7387 the call to `reseat'. (Bug#9545)
56cd55c8 7388
5ed99d36 73892011-09-18 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
3390454c
YM
7390
7391 * xdisp.c (expose_window): Save original value of phys_cursor_on_p
7392 and turn window cursor on if cleared (Bug#9415).
7393
5ed99d36 73942011-09-18 Andreas Schwab <schwab@linux-m68k.org>
edb7b4dc
AS
7395
7396 * search.c (boyer_moore): Take unibyte characters from pattern
7397 literally. (Bug#9458)
7398
9bade7b2
EZ
73992011-09-18 Eli Zaretskii <eliz@gnu.org>
7400
7401 * xdisp.c (reseat_at_next_visible_line_start): Fix last change.
7402
e5e9d610
PE
74032011-09-18 Paul Eggert <eggert@cs.ucla.edu>
7404
87e4427a
PE
7405 Fix minor problem found by static checking.
7406 * xdisp.c (reseat_at_next_visible_line_start): Mark locals as
7407 initialized, to pacify gcc -Wuninitialized.
7408
e5e9d610
PE
7409 * fileio.c: Report proper errno when syscall falls.
7410 (Finsert_file_contents): Save and restore errno,
7411 so that report_file_error outputs the correct diagnostic.
7412 (Fwrite_region) [CLASH_DETECTION]: Likewise.
7413
a1674f0b
EZ
74142011-09-18 Eli Zaretskii <eliz@gnu.org>
7415
7416 * .gdbinit (pgx): Fix references to fields of `struct glyph'.
7417
fbfb6dd4
EZ
74182011-09-17 Eli Zaretskii <eliz@gnu.org>
7419
7420 * xdisp.c (produce_stretch_glyph): Another fix for changes made on
7421 2011-08-30T17:32:44Z!eliz@gnu.org. (Bug#9530)
7422
bb187662
EZ
74232011-09-17 Eli Zaretskii <eliz@gnu.org>
7424
1137e8b8 7425 * xdisp.c (reseat_at_next_visible_line_start): Keep information
6b02f655 7426 about the current paragraph and restore it after the call to reseat.
1137e8b8
EZ
7427
7428 * bidi.c (MAX_PARAGRAPH_SEARCH): New macro.
7429 (bidi_find_paragraph_start): Search back for paragraph beginning
7430 at most MAX_PARAGRAPH_SEARCH lines; if not found, return BEGV_BYTE.
7431 (bidi_move_to_visually_next): Only trigger paragraph-related
7432 computations when the last character is a newline or at EOB, not
7433 just any NEUTRAL_B. (Bug#9470)
7434
bb187662
EZ
7435 * xdisp.c (set_cursor_from_row): Don't invoke special treatment of
7436 truncated lines if point is covered by a display string. (Bug#9524)
7437
2e621251
PE
74382011-09-16 Paul Eggert <eggert@cs.ucla.edu>
7439
7440 * xselect.c: Relax test for outgoing X longs (Bug#9498).
7441 (cons_to_x_long): New function.
7442 (lisp_data_to_selection_data): Use it. Correct the test for
7443 short-versus-long data; it was negated. Break out of vector
7444 loop, for efficiency, when a long datum is discovered.
7445
91a15bc6
SM
74462011-09-16 Stefan Monnier <monnier@iro.umontreal.ca>
7447
7448 * eval.c (Fquote): Document its non-consing behavior (bug#9482).
7449
b41c3a35
EZ
74502011-09-16 Eli Zaretskii <eliz@gnu.org>
7451
7452 * image.c (tiff_handler): Work around a bug in MinGW GCC 3.x (see
7453 GCC PR/17406) by declaring this function with external scope.
7454
7812ba2d
PE
74552011-09-15 Paul Eggert <eggert@cs.ucla.edu>
7456
7457 * editfns.c (Fformat): Fix bug in text-property fix (Bug#9514).
7458 Don't mishandle (length (format "%%")) and (format "%4000s%%" "").
7459
cf7edc2a
AS
74602011-09-15 Andreas Schwab <schwab@linux-m68k.org>
7461
7462 * editfns.c (Fformat): Correctly handle text properties on "%%".
7463
bd01620e
EZ
74642011-09-15 Eli Zaretskii <eliz@gnu.org>
7465
7466 * xterm.c (x_draw_composite_glyph_string_foreground):
7467 * w32term.c (x_draw_composite_glyph_string_foreground):
7468 * term.c (encode_terminal_code):
7469 * composite.c (composition_update_it, get_composition_id):
7470 * xdisp.c (get_next_display_element)
7471 (fill_composite_glyph_string): Add comments about special meaning
7472 of TAB characters in a composition.
7473
a02719a3
PE
74742011-09-15 Paul Eggert <eggert@cs.ucla.edu>
7475
7476 * editfns.c (Fformat): Fix off-by-1 bug for "%%b" (Bug#9514).
4c122725
PE
7477 This occurs when processing a multibyte format.
7478 Problem reported by Wolfgang Jenker.
a02719a3 7479
72589a3c
JB
74802011-09-15 Johan Bockgård <bojohan@gnu.org>
7481
7482 * xdisp.c (try_cursor_movement): Only check for exact match if
7483 cursor hpos found by set_cursor_from_row is valid. (Bug#9495)
7484
1c14176c
PE
74852011-09-14 Paul Eggert <eggert@cs.ucla.edu>
7486
7487 Remove unused external symbols.
7488 * dispextern.h (calc_pixel_width_or_height): Remove decl.
7489 * xdisp.c (calc_pixel_width_or_height): Now static.
7490 * doprnt.c (exprintf) [! (HAVE_X_WINDOWS && USE_X_TOOLKIT)]: Remove.
7491 * indent.c (check_display_width):
7492 * w32term.c: Fix comment to match code.
7493 * xterm.c, xterm.h (x_catching_errors): Remove.
7494
d2eea5b5
PE
74952011-09-14 Paul Eggert <eggert@cs.ucla.edu>
7496
7497 * xselect.c: Use signed conversions more consistently (Bug#9498).
7498 (selection_data_to_lisp_data): Assume incoming selection data are
7499 signed integers, not unsigned. This is to be consistent with
7500 outgoing selection data, which was modified to use signed integers
7501 in as part of the fix to Bug#9196 in response to Jan D.'s comment
7502 in <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=9196#32> that X11
7503 expects long, not unsigned long.
7504
46888499
EZ
75052011-09-14 Eli Zaretskii <eliz@gnu.org>
7506
7507 * xdisp.c (try_window_reusing_current_matrix): Fix incorrect
7508 computation of loop end. Reported by Johan Bockgård
7509 <bojohan@gnu.org>.
7510
ef8ef9fb
CY
75112011-09-13 Chong Yidong <cyd@stupidchicken.com>
7512
7513 * frame.c (Fother_visible_frames_p): Function deleted.
7514
fa819fed
EZ
75152011-09-12 Eli Zaretskii <eliz@gnu.org>
7516
7517 * indent.c (compute_motion): Process display vector front to back
7518 rather than the other way around. (Bug#2496)
7519
2ba8e008
SM
75202011-09-12 Stefan Monnier <monnier@iro.umontreal.ca>
7521
7522 * fileio.c (Finsert_file_contents): Don't assume beg_offset is 0.
7523
20f53c69
CY
75242011-09-11 Chong Yidong <cyd@stupidchicken.com>
7525
7526 * minibuf.c (Fread_from_minibuffer): Doc fix.
7527
d562d7a4
EZ
75282011-09-11 Eli Zaretskii <eliz@gnu.org>
7529
7530 * xdisp.c (produce_stretch_glyph): Fix a typo made in changes from
7531 2011-08-30T17:32:44Z!eliz@gnu.org. (Bug#9475)
7532
1c4d7f3d
LMI
75332011-09-11 Lars Magne Ingebrigtsen <larsi@gnus.org>
7534
7535 * fileio.c (Fvisited_file_modtime): Document `(-1 65535)' as a
7536 value for non-existent files.
7537
b885bf36
EZ
75382011-09-11 Eli Zaretskii <eliz@gnu.org>
7539
7540 * fileio.c (Finsert_file_contents): If the file cannot be opened,
7541 set its "size" to -1. This will set the modtime_size field of
7542 the corresponding buffer to -1, which is what
7543 verify-visited-file-modtime expects for files that do not exist.
7544 (Bug#9139)
7545
6612f0bf
PE
75462011-09-11 Paul Eggert <eggert@cs.ucla.edu>
7547
7548 * keymap.h (KEY_DESCRIPTION_SIZE, push_key_description): Move decls
7549 here ...
7550 * lisp.h: ... from here. push_key_description is no longer
7551 defined in keyboard.c, so its declaration should not be in
7552 lisp.h's "Defined in keyboard.c" section, and KEY_DESCRIPTION_SIZE
7553 logically belongs with push_key_description.
7554
dfb3f755
PE
75552011-09-10 Paul Eggert <eggert@cs.ucla.edu>
7556
7557 * buffer.h: Include <sys/types.h> instead of <time.h>.
7558 Otherwise, off_t wasn't defined on FreeBSD 9.0-BETA2 i386.
7559 Problem reported by Herbert J. Skuhra.
7560
3134906c
LMI
75612011-09-10 Lars Magne Ingebrigtsen <larsi@gnus.org>
7562
7563 * xml.c (parse_region): Make the parsing work for
7564 non-comment-starting XML files again (bug#9144).
7565
8d903f4e
AS
75662011-09-10 Andreas Schwab <schwab@linux-m68k.org>
7567
7568 * image.c (gif_load): Fix calculation of bottom and right corner.
7569 (Bug#9468)
7570
80ad64f4
EZ
75712011-09-10 Eli Zaretskii <eliz@gnu.org>
7572
7573 * xdisp.c (MAX_DISP_SCAN): Decrease to 250. Prevents sluggish
7574 redisplay in small windows.
7575
208a048d
EZ
75762011-09-09 Eli Zaretskii <eliz@gnu.org>
7577
7578 * frame.c (x_report_frame_params): Cast to avoid compiler warnings.
7579
9b1c252e
MR
75802011-09-08 Martin Rudalics <rudalics@gmx.at>
7581
7582 * window.c (Fset_window_prev_buffers, Fset_window_next_buffers):
7583 Operate on live windows only.
7584
2949f33b
JB
75852011-09-08 Juanma Barranquero <lekktu@gmail.com>
7586
7587 * emacs.c (my_heap_start): #ifdef to avoid warnings when unused.
7588
e08dcafd
EZ
75892011-09-07 Eli Zaretskii <eliz@gnu.org>
7590
7591 * xdisp.c (move_it_in_display_line_to): Call RESTORE_IT on ppos_it
7592 only under bidi iteration.
7593
115b96bd
JD
75942011-09-07 Jan Djärv <jan.h.d@swipnet.se>
7595
7596 * gtkutil.c (xg_make_tool_item): Insert comment about eventbox.
7597
c8199d0f
PE
75982011-09-06 Paul Eggert <eggert@cs.ucla.edu>
7599
7600 isnan: Fix porting problem to Solaris 10 with bundled gcc.
7601 Without this fix, the command to link temacs failed due to an
7602 undefined symbol __builtin_isnan. This is because
7603 /usr/include/iso/math_c99.h #defines isnan(x) to
7604 __builtin_isnan(x), but the bundled gcc, which identifies itself
7605 as gcc 3.4.3 (csl-sol210-3_4-branch+sol_rpath), does not have
7606 a __builtin_isnan.
7607 * floatfns.c (isnan): #undef, and then #define to a clone of
7608 what's in data.c.
7609 (Fisnan): Always define, since it's always available now.
7610 (syms_of_floatfns): Always define isnan at the Lisp level.
7611
e39b275c 76122011-09-06 Paul Eggert <eggert@cs.ucla.edu>
1c262cae
PE
7613
7614 * Makefile.in (gl-stamp): move-if-change now in build-aux (Bug#9169).
7615
b2db44d9 76162011-09-06 Paul Eggert <eggert@cs.ucla.edu>
728f8f0a 7617
f4af5137 7618 * fileio.c: Fix bugs with large file offsets (Bug#9428).
728f8f0a
PE
7619 The previous code assumed that file offsets (off_t values) fit in
7620 EMACS_INT variables, which is not true on typical 32-bit hosts.
7621 The code messed up by falsely reporting buffer overflow in cases
7622 such as (insert-file-contents "big" nil 1 2) into an empty buffer
7623 when "big" contains more than 2**29 bytes, even though this
7624 inserts just one byte and does not overflow the buffer.
7625 (Finsert_file_contents): Store file offsets as off_t
7626 values, not as EMACS_INT values. Check for overflow when
7627 converting between EMACS_INT and off_t. When checking for
7628 buffer overflow or for overlap, take the offsets into account.
7629 Don't use EMACS_INT for small values where int suffices.
7630 When checking for overlap, fix a typo: ZV was used where
7631 ZV_BYTE was intended.
7632 (Fwrite_region): Don't assume off_t fits into 'long'.
7633 * buffer.h (struct buffer.modtime_size): Now off_t, not EMACS_INT.
7634
ecfc0a49
MA
76352011-09-05 Michael Albinus <michael.albinus@gmx.de>
7636
7637 * dbusbind.c (xd_signature_cat): Rename from signature_cat.
7638
6511acf2 76392011-09-04 Paul Eggert <eggert@cs.ucla.edu>
61bfeeb7 7640
0999621a 7641 sprintf-related integer and memory overflow issues (Bug#9412).
62f19c19
PE
7642
7643 * doprnt.c (doprnt): Support printing ptrdiff_t and intmax_t values.
8666506e 7644 (esprintf, exprintf, evxprintf): New functions.
62f19c19 7645 * keyboard.c (command_loop_level): Now EMACS_INT, not int.
6b02f655 7646 (cmd_error): Kbd macro iterations count is now EMACS_INT, not int.
62f19c19
PE
7647 (modify_event_symbol): Do not assume that the length of
7648 name_alist_or_stem is safe to alloca and fits in int.
7649 (Fexecute_extended_command): Likewise for function name and binding.
7650 (Frecursion_depth): Wrap around reliably on integer overflow.
7651 * keymap.c (push_key_description): First arg is now EMACS_INT, not int,
7652 since some callers pass EMACS_INT values.
7653 (Fsingle_key_description): Don't crash if symbol name contains more
7654 than MAX_ALLOCA bytes.
7655 * minibuf.c (minibuf_level): Now EMACS_INT, not int.
7656 (get_minibuffer): Arg is now EMACS_INT, not int.
7657 * lisp.h (get_minibuffer, push_key_description): Reflect API changes.
8666506e 7658 (esprintf, exprintf, evxprintf): New decls.
62f19c19
PE
7659 * window.h (command_loop_level, minibuf_level): Reflect API changes.
7660
2be7d702
PE
7661 * dbusbind.c (signature_cat): New function.
7662 (xd_signature, Fdbus_register_signal):
2ea16b89
PE
7663 Do not overrun buffer; instead, report string overflow.
7664
9d1df220
PE
7665 * dispnew.c (add_window_display_history): Don't overrun buffer.
7666 Truncate instead; this is OK since it's just a log.
7667
33ef5c64
PE
7668 * editfns.c (Fcurrent_time_zone): Don't overrun buffer
7669 even if the time zone offset is outlandishly large.
7670 Don't mishandle offset == INT_MIN.
7671
66c6fdd5
PE
7672 * emacs.c (main) [NS_IMPL_COCOA]: Don't overrun buffer
7673 when creating daemon; the previous buffer-overflow check was incorrect.
7674
d749b01b
PE
7675 * eval.c (verror): Simplify by rewriting in terms of evxprintf,
7676 which has the guts of the old verror function.
7677
b5cd1905
PE
7678 * filelock.c (lock_file_1, lock_file): Don't blindly alloca long name;
7679 use SAFE_ALLOCA instead. Use esprintf to avoid int-overflow issues.
7680
6e1a67fb
PE
7681 * font.c: Include <float.h>, for DBL_MAX_10_EXP.
7682 (font_unparse_xlfd): Don't blindly alloca long strings.
c21721cc 7683 Don't assume XINT result fits in int, or that XFLOAT_DATA * 10
8666506e 7684 fits in int, when using sprintf. Use single snprintf to count
c21721cc
PE
7685 length of string rather than counting it via multiple sprintfs;
7686 that's simpler and more reliable.
c21721cc
PE
7687 (font_unparse_fcname): Use it to avoid sprintf buffer overrun.
7688 (generate_otf_features) [0 && HAVE_LIBOTF]: Use esprintf, not
7689 sprintf, in case result does not fit in int.
7690
c57b67fc
PE
7691 * fontset.c (num_auto_fontsets): Now printmax_t, not int.
7692 (fontset_from_font): Print it.
7693
8a401434
PE
7694 * frame.c (tty_frame_count): Now printmax_t, not int.
7695 (make_terminal_frame, set_term_frame_name): Print it.
7696 (x_report_frame_params): In X, window IDs are unsigned long,
7697 not signed long, so print them as unsigned.
7698 (validate_x_resource_name): Check for implausibly long names,
7699 and don't assume name length fits in 'int'.
7700 (x_get_resource_string): Don't blindly alloca invocation name;
7701 use SAFE_ALLOCA. Use esprintf, not sprintf, in case result does
7702 not fit in int.
7703
6e1a67fb
PE
7704 * gtkutil.c: Include <float.h>, for DBL_MAX_10_EXP.
7705 (xg_check_special_colors, xg_set_geometry):
84722b3d
PE
7706 Make sprintf buffers a bit bigger, to avoid potential buffer overrun.
7707
0df02bf3
PE
7708 * lread.c (dir_warning): Don't blindly alloca buffer; use SAFE_ALLOCA.
7709 Use esprintf, not sprintf, in case result does not fit in int.
7710
48e30793
PE
7711 * macros.c (executing_kbd_macro_iterations): Now EMACS_INT, not int.
7712 (Fend_kbd_macro): Don't mishandle MOST_NEGATIVE_FIXNUM by treating
7713 it as a large positive number.
7714 (Fexecute_kbd_macro): Don't assume repeat count fits in int.
7715 * macros.h (executing_kbd_macro_iterations): Now EMACS_INT, not int.
7716
a66ff6d8
PE
7717 * nsterm.m ((NSSize)windowWillResize): Use esprintf, not sprintf,
7718 in case result does not fit in int.
7719
aca216ff
PE
7720 * print.c (float_to_string): Detect width overflow more reliably.
7721 (print_object): Make sprintf buffer a bit bigger, to avoid potential
7722 buffer overrun. Don't assume list length fits in 'int'. Treat
7723 print length of 0 as 0, not as infinity; to be consistent with other
7724 uses of print length in this function. Don't overflow print length
7725 index. Don't assume hash table size fits in 'long', or that
7726 vectorlike size fits in 'unsigned long'.
7727
31c286f7
PE
7728 * process.c (make_process): Use printmax_t, not int, to format
7729 process-name gensyms.
7730
55e5faa1
PE
7731 * sysdep.c (snprintf) [! HAVE_SNPRINTF]: New function.
7732
80f2e268
PE
7733 * term.c (produce_glyphless_glyph): Make sprintf buffer a bit bigger
7734 to avoid potential buffer overrun.
7735
670741ab
PE
7736 * xfaces.c (x_update_menu_appearance): Don't overrun buffer
7737 if X resource line is longer than 512 bytes.
7738
b7163a50
PE
7739 * xfns.c (x_window): Make sprintf buffer a bit bigger
7740 to avoid potential buffer overrun.
7741
ae58ff1f
PE
7742 * xterm.c (x_io_error_quitter): Don't overrun sprintf buffer.
7743
c43c8a6a
PE
7744 * xterm.h (x_check_errors): Add ATTRIBUTE_FORMAT_PRINTF.
7745
3f8236f4
PE
77462011-09-04 Paul Eggert <eggert@cs.ucla.edu>
7747
53e9fe90 7748 Integer overflow fixes for scrolling, etc.
6511acf2
PE
7749 Without these, Emacs silently mishandles large integers sometimes.
7750 For example, "C-u 4294967297 M-x recenter" was treated as if
53e9fe90
PE
7751 it were "C-u 1 M-x recenter" on a typical 64-bit host.
7752
6511acf2
PE
7753 * xdisp.c (try_window_id): Check Emacs fixnum range before
7754 converting to 'int'.
806add1d 7755
6511acf2 7756 * window.c (window_scroll_line_based, Frecenter):
71f02bc5
PE
7757 Check that an Emacs fixnum is in range before assigning it to 'int'.
7758 (Frecenter, Fmove_to_window_line): Use EMACS_INT, not int, for
7759 values converted from Emacs fixnums.
7760 (Frecenter): Don't wrap around a line count if it is out of 'int'
7761 range; instead, treat it as an extreme value.
7762 (Fset_window_configuration, compare_window_configurations):
7763 Use ptrdiff_t, not int, for index that might exceed 2 GiB.
7764
6511acf2
PE
7765 * search.c (Freplace_match): Use ptrdiff_t, not int, for indexes
7766 that can exceed INT_MAX. Check that EMACS_INT value is in range
7767 before assigning it to the (possibly-narrower) index.
a0efffc8
PE
7768 (match_limit): Don't assume that a fixnum can fit in 'int'.
7769
6511acf2 7770 * print.c (print_object): Use ptrdiff_t, not int, for index that can
29ebea3b
PE
7771 exceed INT_MAX.
7772
6511acf2 7773 * indent.c (position_indentation): Now takes ptrdiff_t, not int.
3f8236f4
PE
7774 (Fvertical_motion): Don't wrap around LINES values that don't fit
7775 in 'int'. Instead, treat them as extreme values. This is good
7776 enough for windows, which can't have more than INT_MAX lines anyway.
7777
fcb901a7
LMI
77782011-09-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
7779
0f2f6b6d
LMI
7780 * Require libxml/parser.h to avoid compilation warning.
7781
fcb901a7
LMI
7782 * emacs.c (shut_down_emacs): Call xmlCleanupParser on shutdown.
7783
7784 * xml.c (parse_region): Don't call xmlCleanupParser after parsing,
7785 since this reportedly can destroy thread storage.
7786
6e20a0d4
CY
77872011-08-30 Chong Yidong <cyd@stupidchicken.com>
7788
7789 * syntax.c (find_defun_start): Update all cache variables if
7790 exiting early (Bug#9401).
7791
148ae00e
EZ
77922011-08-30 Eli Zaretskii <eliz@gnu.org>
7793
f6cfbd8f
EZ
7794 * image.c (x_bitmap_pixmap): Cast to int to avoid compiler warnings.
7795
148ae00e
EZ
7796 * xdisp.c (produce_stretch_glyph): No longer static, compiled also
7797 when HAVE_WINDOW_SYSTEM is not defined. Support both GUI and TTY
7798 frames. Call tty_append_glyph in the TTY case. (Bug#9402)
7799
7800 * term.c (tty_append_glyph): New function.
7801 (produce_stretch_glyph): Static function and its prototype deleted.
7802
a66cfb1c
SM
7803 * dispextern.h (produce_stretch_glyph, tty_append_glyph):
7804 Add prototypes.
148ae00e 7805
c4a07a4c
PE
78062011-08-29 Paul Eggert <eggert@cs.ucla.edu>
7807
7808 * image.c (parse_image_spec): Check for nonnegative, not for positive,
7809 when checking :margin (Bug#9390).
7810 (IMAGE_NON_NEGATIVE_INTEGER_VALUE_OR_PAIR):
a66cfb1c 7811 Rename from IMAGE_POSITIVE_INTEGER_VALUE_OR_PAIR,
c4a07a4c
PE
7812 so that the name doesn't mislead. All uses changed.
7813
6bc8cd65
JB
78142011-08-28 Johan Bockgård <bojohan@gnu.org>
7815
7816 * term.c (init_tty) [HAVE_GPM]: Move mouse settings after
7817 set_tty_hooks.
7818
dca4927e
EZ
78192011-08-27 Eli Zaretskii <eliz@gnu.org>
7820
7821 * xdisp.c (move_it_to): Don't bail out early when reaching
7822 position beyond to_charpos, if we are scanning backwards.
7823 (move_it_vertically_backward): When DY == 0, make sure we get to
7824 the first character in the line after the newline.
7825
f2cad773
PE
78262011-08-27 Paul Eggert <eggert@cs.ucla.edu>
7827
7828 * ccl.c: Improve and simplify overflow checking (Bug#9196).
7829 (ccl_driver): Do not generate an out-of-range pointer.
7830 (Fccl_execute_on_string): Remove unnecessary check for
7831 integer overflow, noted by Stefan Monnier in
7832 <http://lists.gnu.org/archive/html/emacs-devel/2011-08/msg00979.html>.
7833 Remove a FIXME that didn't need fixing.
7834 Simplify the newly-introduced buffer reallocation code.
7835
0cae2cdb
JB
78362011-08-27 Juanma Barranquero <lekktu@gmail.com>
7837
7838 * makefile.w32-in ($(BLD)/alloc.$(O)): Depend on lib/verify.h.
7839
5fc295a4 78402011-08-26 Paul Eggert <eggert@cs.ucla.edu>
ddff3151 7841
70c60eb2 7842 Integer and memory overflow issues (Bug#9196).
726e0ab1 7843
d31850da
PE
7844 * doc.c (get_doc_string): Rework so that
7845 get_doc_string_buffer_size is the actual buffer size, rather than
7846 being 1 less than the actual buffer size; this makes xpalloc more
7847 convenient.
7848
a69fbedb
PE
7849 * image.c (x_allocate_bitmap_record, cache_image):
7850 * xselect.c (Fx_register_dnd_atom):
7851 Simplify previous changes by using xpalloc.
7852
fe5c5d37
PE
7853 * buffer.c (overlay_str_len): Now ptrdiff_t, not EMACS_INT,
7854 since either will do and ptrdiff_t is convenient with xpalloc.
7855
0065d054
PE
7856 * charset.c (charset_table_size)
7857 (struct charset_sort_data.priority): Now ptrdiff_t.
7858 (charset_compare): Don't overflow if priorities differ greatly.
7859 (Fsort_charsets): Don't assume list length fits in int.
7860 Check for size-calculation overflow when allocating sort data.
7861 (syms_of_charset): Allocate an initial charset table that is
7862 just under 64 KiB, to avoid problems with glibc malloc and mmap.
7863
7864 * cmds.c (internal_self_insert): Check for size-calculation overflow.
7865
7866 * composite.h (struct composition.glyph_len): Now int, not unsigned.
7867 The actual value is always <= INT_MAX, and leaving it unsigned made
7868 overflow checking harder.
7869
7870 * dispextern.h (struct glyph_matrix.rows_allocated)
7871 (struct face_cache.size): Now ptrdiff_t, for convenience in use
7872 with xpalloc. The values are still always <= INT_MAX.
7873
7874 * indent.c (compute_motion): Adjust to region_cache_forward sig change.
7875
7876 * lisp.h (xnmalloc, xnrealloc, xpalloc): New decls.
7877 (SAFE_NALLOCA): New macro.
7878
7879 * region-cache.c (struct boundary.pos, find_cache_boundary)
7880 (move_cache_gap, insert_cache_boundary, delete_cache_boundaries)
7881 (set_cache_region, invalidate_region_cache)
7882 (revalidate_region_cache, know_region_cache, region_cache_forward)
7883 (region_cache_backward, pp_cache):
7884 Use ptrdiff_t, not EMACS_INT, since either will do. This is needed
7885 so that ptrdiff_t * can be passed to xpalloc.
7886 (struct region_cache): Similarly, for gap_start, gap_len, cache_len,
7887 beg_unchanged, end_unchanged, buffer_beg, buffer_end members.
7888 (pp_cache): Don't assume cache_len fits in int.
7889 * region-cache.h: Adjust extern decls to match.
7890
7891 * search.c (scan_buffer, Freplace_match): Use ptrdiff_t, not
7892 EMACS_INT, since either will do, for xpalloc.
7893
7894 * alloc.c: Include verify.h, and check that int fits in ptrdiff_t.
7895 (xnmalloc, xnrealloc, xpalloc): New functions.
7896
726e0ab1
PE
7897 * bidi.c (bidi_shelve_header_size): New constant.
7898 (bidi_cache_ensure_space, bidi_shelve_cache): Use it.
7899 (bidi_cache_ensure_space): Avoid integer overflow when allocating.
7900
51f30bc5 7901 * bidi.c (bidi_cache_shrink):
726e0ab1
PE
7902 * buffer.c (overlays_at, overlays_in, record_overlay_string)
7903 (overlay_strings):
7904 Don't update size of array until after memory allocation succeeds,
7905 because xmalloc/xrealloc may not return.
0065d054
PE
7906 (struct sortstrlist.bytes): Now ptrdiff_t, as EMACS_INT doesn't help
7907 now that we have proper integer overflow checking.
7908 (record_overlay_string, overlay_strings): Catch overflows when
7909 calculating size of overlay_str_buf.
726e0ab1 7910
0065d054
PE
7911 * callproc.c (Fcall_process): Check for size overflow when
7912 calculating size of args2.
7913 (child_setup): Avoid overflow by using size_t rather than ptrdiff_t.
7914 Normally we prefer signed values, but sticking with ptrdiff_t would
7915 require adding more-complicated checks.
726e0ab1
PE
7916
7917 * ccl.c (Fccl_execute_on_string): Check for memory overflow.
7918 Use ptrdiff_t rather than EMACS_INT where ptrdiff_t will do.
7919 Redo buffer-overflow calculations to avoid integer overflow.
0065d054 7920 Add a FIXME comment where memory seems to be over-allocated.
726e0ab1
PE
7921
7922 * character.c (Fstring): Check for size-calculation overflow.
7923
7924 * coding.c (produce_chars): Redo buffer-overflow calculations to avoid
7925 unnecessary integer overflow. Check for size overflow.
7926 (encode_coding_object): Don't update size until xmalloc succeeds.
7927
7928 * composite.c (get_composition_id): Check for overflow in glyph
7929 length calculations.
7930
7931 Integer and memory overflow fixes for display code.
7932 * dispextern.h (struct glyph_pool.nglyphs): Now ptrdiff_t, not int.
7933 * dispnew.c (adjust_glyph_matrix, realloc_glyph_pool)
7934 (scrolling_window): Check for overflow in size calculations.
7935 (line_draw_cost, realloc_glyph_pool, add_row_entry):
7936 Don't assume glyph table len fits in int.
7937 (struct row_entry.bucket, row_entry_pool_size, row_entry_idx)
7938 (row_table_size): Now ptrdiff_t, not int.
7939 (scrolling_window): Avoid overflow in size calculations.
7940 Don't update size until allocation succeeds.
7941 * fns.c (concat): Check for overflow in size calculations.
7942 (next_almost_prime): Verify NEXT_ALMOST_PRIME_LIMIT.
7943 * lisp.h (RANGED_INTEGERP, TYPE_RANGED_INTEGERP): New macros.
7944 (NEXT_ALMOST_PRIME_LIMIT): New constant.
7945
7946 * doc.c (get_doc_string_buffer_size): Now ptrdiff_t, not int.
7947 (get_doc_string): Check for size calculation overflow.
7948 Don't update size until allocation succeeds.
7949 (get_doc_string, Fsubstitute_command_keys): Use ptrdiff_t, not
7950 EMACS_INT, where ptrdiff_t will do.
7951 (Fsubstitute_command_keys): Check for string overflow.
7952
7953 * editfns.c (set_time_zone_rule): Don't assume environment length
7954 fits in int.
7955 (message_length): Now ptrdiff_t, not int.
7956 (Fmessage_box): Don't update size until allocation succeeds.
7957 Don't assume message length fits in int.
7958 (Fformat): Use ptrdiff_t, not EMACS_INT, where ptrdiff_t will do.
7959
0065d054
PE
7960 * emacs.c (main): Do not reallocate argv, since there is a null at
7961 the end that can be overwritten, and this way there's no need to
7962 worry about size-calculation overflow.
7963 (sort_args): Check for size-calculation overflow.
726e0ab1
PE
7964
7965 * eval.c (init_eval_once, grow_specpdl): Don't update size until
7966 alloc succeeds.
7967 (call_debugger, grow_specpdl): Redo calculations to avoid overflow.
7968
7969 * frame.c (set_menu_bar_lines, x_set_frame_parameters)
7970 (x_set_scroll_bar_width, x_figure_window_size):
7971 Check for integer overflow.
7972 (x_set_alpha): Do not assume XINT fits in int.
7973
7974 * frame.h (struct frame): Use int, not EMACS_INT, where int works.
7975 This is for the members text_lines, text_cols, total_lines, total_cols,
7976 where the system imposes an 'int' limit.
7977
7978 * fringe.c (Fdefine_fringe_bitmap):
7979 Don't update size until alloc works.
7980
7981 * ftfont.c (ftfont_get_open_type_spec, setup_otf_gstring)
7982 (ftfont_shape_by_flt): Check for integer overflow in size calculations.
7983
7984 * gtkutil.c (get_utf8_string, xg_store_widget_in_map):
7985 Check for size-calculation overflow.
7986 (get_utf8_string): Use ptrdiff_t, not size_t, where either will
7987 do, as we prefer signed integers.
7988 (id_to_widget.max_size, id_to_widget.used)
7989 (xg_store_widget_in_map, xg_remove_widget_from_map)
7990 (xg_get_widget_from_map, xg_get_scroll_id_for_window)
7991 (xg_remove_scroll_bar, xg_update_scrollbar_pos):
7992 Use and return ptrdiff_t, not int.
7993 (xg_gtk_scroll_destroy): Don't assume ptrdiff_t fits in int.
7994 * gtkutil.h: Change prototypes to match the above.
7995
7996 * image.c (RANGED_INTEGERP, TYPE_RANGED_INTEGERP): Remove; these
7997 are duplicate now that they've been promoted to lisp.h.
7998 (x_allocate_bitmap_record, x_alloc_image_color)
7999 (make_image_cache, cache_image, xpm_load):
8000 Don't update size until alloc is done.
8001 (xpm_load, lookup_rgb_color, lookup_pixel_color, x_to_xcolors)
8002 (x_detect_edges):
3256efce 8003 Check for size calculation overflow.
726e0ab1
PE
8004 (ct_colors_allocated_max): New constant.
8005 (x_to_xcolors, x_detect_edges): Reorder multiplicands to avoid
8006 overflow.
3256efce 8007
726e0ab1
PE
8008 * keyboard.c (read_char, menu_bar_items, tool_bar_items)
8009 (read_char_x_menu_prompt, read_char_minibuf_menu_width)
8010 (read_char_minibuf_menu_prompt, follow_key, read_key_sequence):
8011 Use ptrdiff_t, not int, to count maps.
8012 (read_char_minibuf_menu_prompt): Check for overflow in size
a66cfb1c
SM
8013 calculations. Don't update size until allocation succeeds.
8014 Redo calculations to avoid overflow.
726e0ab1
PE
8015 * keyboard.h: Change prototypes to match the above.
8016
8017 * keymap.c (cmm_size, current_minor_maps): Use ptrdiff_t, not int,
8018 to count maps.
8019 (current_minor_maps): Check for size calculation overflow.
8020 * keymap.h: Change prototypes to match the above.
8021
8022 * lread.c (read1, init_obarray): Don't update size until alloc done.
8023
8024 * macros.c (Fstart_kbd_macro): Don't update size until alloc done.
8025 (store_kbd_macro_char): Reorder multiplicands to avoid overflow.
8026
726e0ab1
PE
8027 * nsterm.h (struct ns_color_table.size, struct ns_color_table.avail):
8028 Now ptrdiff_t, not int.
8029 * nsterm.m (ns_index_color): Use ptrdiff_t, not int, for table indexes.
8030 (ns_draw_fringe_bitmap): Rewrite to avoid overflow.
8031
8032 * process.c (Fnetwork_interface_list): Check for overflow
8033 in size calculation.
8034
8035 * region-cache.c (move_cache_gap): Check for size calculation overflow.
8036
8037 * scroll.c (do_line_insertion_deletion_costs): Check for size calc
8038 overflow. Don't bother calling xmalloc when xrealloc will do.
8039
8040 * search.c (Freplace_match): Check for size calculation overflow.
8041 (Fset_match_data): Don't assume list lengths fit in 'int'.
8042
8043 * sysdep.c (system_process_attributes): Use ptrdiff_t, not int,
8044 for command line length. Do not attempt to address one before the
8045 beginning of an array, as that's not portable.
8046
8047 * term.c (max_frame_lines): Remove; unused.
8048 (encode_terminal_src_size, encode_terminal_dst_size): Now ptrdiff_t,
8049 not int.
8050 (encode_terminal_code, calculate_costs): Check for size
8051 calculation overflow.
8052 (encode_terminal_code): Use ptrdiff_t, not int, to record glyph
8053 table lengths and related sizes. Don't update size until alloc
8054 done. Redo calculations to avoid overflow.
8055 (calculate_costs): Don't bother calling xmalloc when xrealloc will do.
8056
8057 * termcap.c (tgetent): Use ptrdiff_t, not int, to record results of
8058 subtracting pointers.
8059 (gobble_line): Check for overflow more carefully. Don't update size
8060 until alloc done.
8061
8062 * tparam.c (tparam1): Use ptrdiff_t, not int, for sizes.
8063 Don't update size until alloc done.
8064 Redo size calculations to avoid overflow.
8065 Check for size calculation overflow.
0065d054 8066 (main) [DEBUG]: Fix typo in invoking tparam1.
726e0ab1
PE
8067
8068 * xdisp.c (store_mode_line_noprop_char, x_consider_frame_title):
8069 Use ptrdiff_t, not int, for sizes.
8070 (store_mode_line_noprop_char): Don't update size until alloc done.
8071
0065d054
PE
8072 * xfaces.c (lface_id_to_name_size, Finternal_make_lisp_face):
8073 Use ptrdiff_t, not int, for sizes.
8074 (Finternal_make_lisp_face, cache_face):
8075 Check for size calculation overflow.
8076 (cache_face): Treat size calculation overflows as if they were
8077 memory exhaustion (the usual treatment), rather than aborting.
726e0ab1
PE
8078
8079 * xfns.c (x_encode_text, x_set_name_internal)
8080 (Fx_change_window_property): Use ptrdiff_t, not int, to count
8081 sizes, since they can exceed INT_MAX in size. Check for size
8082 calculation overflow.
8083
0065d054
PE
8084 * xgselect.c (gfds_size): Now ptrdiff_t, for convenience with xpalloc.
8085 (xg_select): Check for size calculation overflow.
726e0ab1
PE
8086 Don't update size until alloc done.
8087
0065d054 8088 * xrdb.c (get_environ_db): Don't assume path length fits in int,
726e0ab1 8089 as sprintf is limited to int lengths.
1d526e2f 8090
252c5ee1
PE
8091 * xselect.c (X_LONG_SIZE, X_SHRT_MAX, X_SHRT_MIN, X_LONG_MAX)
8092 (X_LONG_MIN): New macros.
864d7ce7
PE
8093 Use them to make the following changes clearer.
8094 (MAX_SELECTION_QUANTUM): Make the other bounds on this value clearer.
8095 This change doesn't affect the value now, but it may help remind
8096 future maintainers not to raise the value too much later.
8097 (SELECTION_QUANTUM): Remove, replacing with ...
8098 (selection_quantum): ... new function, which avoids overflow.
8099 All uses changed.
8100 (struct selection_data.size): Now ptrdiff_t, not int, to avoid
8101 assumption that selection length fits in 'int'.
8102 (x_reply_selection_request, x_handle_selection_request)
8103 (x_get_window_property, receive_incremental_selection)
8104 (x_get_window_property_as_lisp_data, selection_data_to_lisp_data)
8105 (lisp_data_to_selection_data, clean_local_selection_data):
8106 Use ptrdiff_t, not int, to record length of selection.
8107 (x_reply_selection_request, x_get_window_property)
8108 (receive_incremental_selection, x_property_data_to_lisp):
8109 Redo calculations to avoid overflow.
8110 (x_reply_selection_request): When sending hint, ceiling it at
252c5ee1 8111 X_LONG_MAX rather than relying on wraparound overflow to send
864d7ce7
PE
8112 something.
8113 (x_get_window_property, receive_incremental_selection)
8114 (lisp_data_to_selection_data, x_property_data_to_lisp):
8115 Check for size-calculation overflow.
8116 (x_get_window_property, receive_incremental_selection)
8117 (lisp_data_to_selection_data, Fx_register_dnd_atom):
8118 Don't store size until memory allocation succeeds.
8119 (x_get_window_property): Plug memory leak on memory exhaustion.
8120 Don't double-block input; malloc is safe here. Don't assume 2**34
8121 - 4 fits in unsigned long. Add an xassert to check
8122 XGetWindowProperty overflow. Be more careful about overflow
8123 calculations, and distinguish size from memory overflow better.
8124 (receive_incremental_selection): When tracing, don't assume
8125 unsigned int is less than INT_MAX.
8126 (x_selection_data_to_lisp_data): Remove unnecessary (and in theory
8127 harmful) conversions of unsigned short to int.
8128 (lisp_data_to_selection_data): Don't assume that integers
8129 in the range -65535 through -1 fit in an X unsigned short.
8130 Don't assume that ULONG_MAX == X_ULONG_MAX. Don't store into
8131 result parameters unless successful. Rely on cons_to_unsigned
8132 to report problems with elements; the old code wasn't right anyway.
8133 (x_check_property_data): Check for int overflow; we cannot use
8134 a wider type due to X limits.
8135 (x_handle_dnd_message): Use unsigned int, to avoid int overflow.
8136
726e0ab1 8137 * xsmfns.c (smc_save_yourself_CB): Check for size calc overflow.
34db673b 8138
0065d054
PE
8139 * xterm.c (x_color_cells, x_send_scrollbar_event, handle_one_xevent)
8140 (x_term_init): Check for size calculation overflow.
726e0ab1
PE
8141 (x_color_cells): Don't store size until memory allocation succeeds.
8142 (handle_one_xevent): Use ptrdiff_t, not int, for byte counts.
0065d054 8143 Don't assume alloca size is less than MAX_ALLOCA.
726e0ab1
PE
8144 (x_term_init): Don't assume length fits in int (sprintf is limited
8145 to int size).
bc18e09d 8146
ebfa62c0
PE
8147 Use ptrdiff_t for composition IDs.
8148 * character.c (lisp_string_width):
8149 * composite.c (composition_table_size, n_compositions)
8150 (get_composition_id, composition_gstring_from_id):
8151 * dispextern.h (struct glyph_string.cmp_id, struct composition_it.id):
8152 * xdisp.c (BUILD_COMPOSITE_GLYPH_STRING):
8153 * window.c (Frecenter):
8154 Use ptrdiff_t, not int, for composition IDs.
8155 * composite.c (get_composition_id): Check for integer overflow.
8156 * composite.h: Adjust prototypes to match the above changes.
8157
d3411f89
PE
8158 Use ptrdiff_t for hash table indexes.
8159 * category.c (hash_get_category_set):
8160 * ccl.c (ccl_driver):
8161 * charset.h (struct charset.hash_index, CHECK_CHARSET_GET_ID):
8162 * coding.c (coding_system_charset_list, detect_coding_system):
8163 * coding.h (struct coding_system.id):
8164 * composite.c (get_composition_id, gstring_lookup_cache):
8165 * fns.c (hash_lookup, hash_put, Fgethash, Fputhash):
8166 * image.c (xpm_get_color_table_h):
8167 * lisp.h (hash_lookup, hash_put):
8168 * minibuf.c (Ftest_completion):
8169 Use ptrdiff_t for hash table indexes, not int (which is too
8170 narrow, on 64-bit hosts) or EMACS_INT (which is too wide, on
8171 32-bit --with-wide-int hosts).
8172
e097a6fa
PE
8173 * charset.c (Fdefine_charset_internal): Check for integer overflow.
8174 Add a FIXME comment about memory leaks.
8175 (syms_of_charset): Don't assume xmalloc returns.
8176
5637687f
PE
8177 Don't assume that stated character widths fit in int.
8178 * character.c (Fchar_width, c_string_width, lisp_string_width):
8179 * character.h (CHAR_WIDTH):
8180 * indent.c (MULTIBYTE_BYTES_WIDTH):
8181 Use sanitize_char_width to avoid undefined and/or bad behavior
8182 with outlandish widths.
a66cfb1c 8183 * character.h (sanitize_tab_width): Rename from sanitize_width,
5637687f
PE
8184 now that we have two such functions. All uses changed.
8185 (sanitize_char_width): New inline function.
8186
a2271ba2
PE
8187 Don't assume that tab-width fits in int.
8188 * character.h (sanitize_width): New inline function.
8189 (SANE_TAB_WIDTH): New macro.
8190 (ASCII_CHAR_WIDTH): Use it.
8191 * indent.c (sane_tab_width): Remove. All uses replaced by
8192 SANE_TAB_WIDTH (current_buffer).
8193 * xdisp.c (init_iterator): Use SANE_TAB_WIDTH.
8194
18c52557
PE
8195 * fileio.c: Integer overflow issues with file modes.
8196 (Fset_file_modes, auto_save_1): Don't assume EMACS_INT fits in int.
8197
caeeedc1
PE
8198 * charset.c (read_hex): New arg OVERFLOW. All uses changed.
8199 Remove unreachable code.
8200 (read_hex, load_charset_map_from_file): Check for integer overflow.
8201
6df6ae42 8202 * xterm.c: Don't go over XClientMessageEvent limit.
50849c52
PE
8203 (scroll_bar_windows_size): Now ptrdiff_t, as we prefer signed.
8204 (x_send_scroll_bar_event): Likewise. Check that the size does not
8205 exceed limits imposed by XClientMessageEvent, as well as the usual
8206 ptrdiff_t and size_t limits.
8207
b13995db
PE
8208 * keyboard.c: Overflow, signedness and related fixes.
8209 (make_lispy_movement): Use same integer type in forward decl
8210 that is used in the definition.
8211 (read_key_sequence, keyremap_step):
8212 Change bufsize argument back to int, undoing my 2011-03-30 change.
8213 We prefer signed types, and int is wide enough here.
8214 (parse_tool_bar_item): Don't assume tool_bar_max_label_size is less
8215 than TYPE_MAXIMUM (EMACS_INT) / 2. Don't let the label size grow
8216 larger than STRING_BYTES_BOUND. Use ptrdiff_t for Emacs string
8217 length, not size_t. Use ptrdiff_t for index, not int.
8218 (keyremap_step, read_key_sequence): Redo bufsize check to avoid
8219 possibility of integer overflow.
8220
13464394
PE
8221 Overflow, signedness and related fixes for images.
8222
8223 * dispextern.h (struct it.stack[0].u.image.image_id)
8224 (struct_it.image_id, struct image.id, struct image_cache.size)
8225 (struct image_cache.used, struct image_cache.ref_count):
8226 * gtkutil.c (update_frame_tool_bar):
8227 * image.c (x_reference_bitmap, Fimage_size, Fimage_mask_p)
8228 (Fimage_metadata, free_image_cache, clear_image_cache, lookup_image)
8229 (cache_image, mark_image_cache, x_kill_gs_process, Flookup_image):
8230 * nsmenu.m (update_frame_tool_bar):
8231 * xdisp.c (calc_pixel_width_or_height):
8232 * xfns.c (image_cache_refcount):
8233 Image IDs are now ptrdiff_t, not int, to avoid arbitrary limits
8234 on typical 64-bit hosts.
8235
8236 * image.c (RANGED_INTEGERP, TYPE_RANGED_INTEGERP): New macros.
8237 (x_bitmap_pixmap, x_create_x_image_and_pixmap):
8238 Omit unnecessary casts to int.
8239 (parse_image_spec): Check that integers fall into 'int' range
8240 when the callers expect that.
8241 (image_ascent): Redo ascent calculation to avoid int overflow.
8242 (clear_image_cache): Avoid overflow when sqrt (INT_MAX) < nimages.
8243 (lookup_image): Remove unnecessary tests.
8244 (xbm_image_p): Locals are now of int, not EMACS_INT,
8245 since parse_image_check makes sure they fit into int.
8246 (png_load, gif_load, svg_load_image):
8247 Prefer int to unsigned where either will do.
8248 (tiff_handler): New function, combining the cores of the
a66cfb1c
SM
8249 old tiff_error_handler and tiff_warning_handler.
8250 This function is rewritten to use vsnprintf and thereby avoid
13464394
PE
8251 stack buffer overflows. It uses only the features of vsnprintf
8252 that are common to both POSIX and native Microsoft.
8253 (tiff_error_handler, tiff_warning_handler): Use it.
8254 (tiff_load, gif_load, imagemagick_load_image):
8255 Don't assume :index value fits in 'int'.
8256 (gif_load): Omit unnecessary cast to double, and avoid double-rounding.
8257 (imagemagick_load_image): Check that crop parameters fit into
8258 the integer types that MagickCropImage accepts. Don't assume
8259 Vimagemagick_render_type has a nonnegative value. Don't assume
8260 size_t fits in 'long'.
8261 (gs_load): Use printmax_t to print the widest integers possible.
8262 Check for integer overflow when computing image height and width.
8263
c11821d4
EZ
82642011-08-26 Eli Zaretskii <eliz@gnu.org>
8265
8266 * xdisp.c (redisplay_window): Don't force window start if point
8267 will be invisible in the resulting window. (Bug#9324)
8268
0c95fcf7
EZ
82692011-08-25 Eli Zaretskii <eliz@gnu.org>
8270
8271 * xdisp.c (compute_display_string_pos): Return 2 in DISP_PROP when
8272 the display spec is of the form `(space ...)'.
8273 (handle_display_spec): Return the value returned by
8274 handle_single_display_spec, not just 1 or zero.
8275 (handle_single_display_spec): If the display spec is of the form
8276 `(space ...)', and specifies display in the text area, return 2
8277 rather than 1.
fee65a97 8278 (try_cursor_movement): Check for the need to scroll more
a66cfb1c
SM
8279 accurately, and prefer exact match for point under bidi.
8280 Don't advance `row' beyond the last row of the window.
0c95fcf7
EZ
8281
8282 * dispextern.h (struct bidi_it): Rename the disp_prop_p member
8283 into disp_prop; all users changed.
8284
8285 * bidi.c (bidi_fetch_char): If compute_display_string_pos returns
8286 DISP_PROP = 2, substitute the u+2029 PARAGRAPH SEPARATOR character
8287 for the text covered by the display property.
8288
e4ed06f1
CY
82892011-08-25 Chong Yidong <cyd@stupidchicken.com>
8290
8291 * buffer.c (Fbury_buffer_internal): Rename from Funrecord_buffer.
8292 Change return value to nil.
8293 (Frecord_buffer): Delete unused function.
8294
f67cdd7f
EZ
82952011-08-24 Eli Zaretskii <eliz@gnu.org>
8296
5980d4c6
EZ
8297 * xdisp.c (Fcurrent_bidi_paragraph_direction): For unibyte
8298 buffers, return left-to-right.
8610fe8b
EZ
8299 (set_cursor_from_row): Consider candidate row a win if its glyph
8300 represents a newline and point is on that newline. Fixes cursor
8301 positioning on the newline at EOL of R2L text within L2R
8302 paragraph, and vice versa.
8303 (try_cursor_movement): Check continued rows, in addition to
8304 continuation rows. Fixes unwarranted scroll when point enters a
8305 continued line of R2L text within an L2R paragraph, or vice versa.
8306 (cursor_row_p): Consider the case of point being equal to
8307 MATRIX_ROW_END_CHARPOS. Prevents cursor being stuck when moving
8308 from the end of a short line to the beginning of a continued line
8309 of R2L text within L2R paragraph.
8310 (RECORD_MAX_MIN_POS): For max_pos, use IT_CHARPOS even for
8311 composed characters.
5980d4c6 8312
f67cdd7f
EZ
8313 * bidi.c (bidi_check_type): Use xassert.
8314 (bidi_cache_iterator_state): Update the disp_pos and disp_prop_p
8315 members.
8316
bca633fb
EZ
83172011-08-23 Eli Zaretskii <eliz@gnu.org>
8318
8319 * bidi.c (bidi_get_type): Abort if we get zero as the bidi type of
8320 a character.
8321
4a5885a7
CY
83222011-08-23 Chong Yidong <cyd@stupidchicken.com>
8323
8324 * nsfont.m (ns_otf_to_script): Fix typo.
8325
0902a04e
KH
83262011-08-22 Kenichi Handa <handa@m17n.org>
8327
8328 * chartab.c (Fset_char_table_extra_slot): Do not inhibit setting a
8329 extra slot even if the purpose is char-code-property-table.
8330
1a2e6670
EZ
83312011-08-23 Eli Zaretskii <eliz@gnu.org>
8332
8ddde651
EZ
8333 * xdisp.c (redisplay_window): When computing centering_position,
8334 account for the height of the header line. (Bug#8874)
8335
425cc014
EZ
8336 * dispnew.c (buffer_posn_from_coords): Use buf_charpos_to_bytepos
8337 instead of CHAR_TO_BYTE. Fixes a crash when a completion
8338 candidate is selected by the mouse, and that candidate has a
8339 composed character under the mouse.
8340
1a2e6670
EZ
8341 * xdisp.c (x_produce_glyphs): Set it->nglyphs to 1. Fixes pixel
8342 coordinates reported by pos-visible-in-window-p for a composed
8343 character in column zero.
8344
8b76d6f8
SM
83452011-08-23 Stefan Monnier <monnier@iro.umontreal.ca>
8346
8347 * cmds.c (Fself_insert_command): Mention post-self-insert-hook.
8348
dac347dd
EZ
83492011-08-22 Eli Zaretskii <eliz@gnu.org>
8350
8351 * xdisp.c (BUFFER_POS_REACHED_P): If this is a composition,
8352 consider it a hit if to_charpos is anywhere in the range of the
8353 composed buffer positions.
8354
e013fb34
CY
83552011-08-22 Chong Yidong <cyd@stupidchicken.com>
8356
8357 * image.c (gif_load): Don't assume that each subimage has the same
8358 dimensions as the base image. Handle disposal method that is
8359 "undefined" by the gif spec (Bug#9335).
8360
bd1ba3e8
CY
83612011-08-20 Chong Yidong <cyd@stupidchicken.com>
8362
8363 * eval.c (Fsignal): Handle `debug' symbol in error handler (Bug#9329).
024a2d76 8364 (Fcondition_case): Document `debug' symbol in error handler.
bd1ba3e8 8365
54a1215b
EZ
83662011-08-19 Eli Zaretskii <eliz@gnu.org>
8367
823564e5
EZ
8368 * xfaces.c (face_at_buffer_position): Avoid repeated evaluation of
8369 face ID by FACE_FROM_ID, and avoid a crash when mouse is moved
8370 from an Org mode buffer to a Speedbar frame.
8371
54a1215b
EZ
8372 * xdisp.c (RECORD_MAX_MIN_POS): If the display element comes from
8373 a composition, take its buffer position from IT->cmp_it.charpos.
8374 Fixes cursor positioning at the beginning of a line that begins
8375 with a composed character.
8376
9778ebcc
EZ
83772011-08-18 Eli Zaretskii <eliz@gnu.org>
8378
0be6ee06
EZ
8379 * bidi.c (bidi_get_type): If bidi_type_table reports zero as the
8380 character bidirectional type, use STRONG_L instead. Fixes crashes
8381 in a buffer produced by `describe-categories'.
8382
9778ebcc
EZ
8383 * dispextern.h (struct bidi_it): Move disp_pos and disp_prop_p
8384 members before the level stack, so they would be saved and
8385 restored when copying iterator state. Fixes incorrect reordering
8386 around TABs covered by display properties.
8387
156bffbe
AS
83882011-08-18 Andreas Schwab <schwab@linux-m68k.org>
8389
6b02f655 8390 * process.c (Fnetwork_interface_list): Correctly determine buffer size.
156bffbe 8391
72ad093b
CY
83922011-08-17 Chong Yidong <cyd@stupidchicken.com>
8393
8394 * eval.c (internal_condition_case, internal_condition_case_1)
8b76d6f8
SM
8395 (internal_condition_case_2, internal_condition_case_n):
8396 Remove unnecessary aborts (Bug#9081).
72ad093b 8397
35774242
EZ
83982011-08-17 Eli Zaretskii <eliz@gnu.org>
8399
8400 * lread.c (Fload) [DOS_NT]: If `openp' returns -2, but the file
8401 has no `load' handler, try opening the file locally. (Bug#9311)
8402
db76dd85
KB
84032011-08-16 Ken Brown <kbrown@cornell.edu>
8404
8405 * gmalloc.c: Expand comment.
8406
b215eee5
EZ
84072011-08-16 Eli Zaretskii <eliz@gnu.org>
8408
8409 * xdisp.c (set_cursor_from_row): Don't accept a previous candidate
8410 if it fails the cursor_row_p test. Fixes cursor positioning at ZV.
8411
a4579d33
KB
84122011-08-16 Ken Brown <kbrown@cornell.edu>
8413
8414 Fix memory allocation problems in Cygwin build (Bug#9273).
8415
8416 * unexcw.c ( __malloc_initialized): Declare external variable.
8417 (fixup_executable): Force the dumped emacs to reinitialize malloc.
8418
8b76d6f8
SM
8419 * gmalloc.c [CYGWIN] (bss_sbrk_heapbase, bss_sbrk_heapinfo):
8420 New variables.
a4579d33
KB
8421 (malloc_initialize_1) [CYGWIN]: Prepare for reinitializing the
8422 dumped emacs.
8423 (_free_internal_nolock) [CYGWIN]: Ignore requests to free storage
8424 in the static heap.
8425 [CYGWIN] (special_realloc): New function.
8426 (_realloc_internal_nolock) [CYGWIN]: Use the new function on
8427 requests to realloc storage in the static heap.
8428
3ebec551
PE
84292011-08-15 Paul Eggert <eggert@cs.ucla.edu>
8430
8431 * bidi.c (bidi_initialize): Remove unused local.
8432
9fd8be00
EZ
84332011-08-15 Eli Zaretskii <eliz@gnu.org>
8434
6b02f655
SM
8435 * bidimirror.h:
8436 * biditype.h: Remove file.
8437 * makefile.w32-in ($(BLD)/bidi.$(O)):
8438 * deps.mk (bidi.o): Remove biditype.h and bidimirror.h.
474a8465
EZ
8439
8440 * dispextern.h: Fix a typo in the comment to bidi_type_t.
8441
8442 * chartab.c: Improve commentary for the uniprop_table API.
8443
32413314
EZ
8444 * bidi.c (bidi_paragraph_init): Support zero value of
8445 bidi_ignore_explicit_marks_for_paragraph_level.
474a8465
EZ
8446 (bidi_initialize): Use uniprop_table instead of including
8447 biditype.h and bidimirror.h.
32413314 8448
9fd8be00
EZ
8449 * xdisp.c (move_it_in_display_line_to): Don't reset pixel
8450 coordinates of the iterator when restoring from ppos_it.
8451 (Bug#9296)
8452
5cf2b69b
KH
84532011-08-14 Kenichi Handa <handa@m17n.org>
8454
8455 * process.c (create_process): Call setup_process_coding_systems
72ad093b 8456 after the pid of the process is set to -1 (Bug#8162).
5cf2b69b 8457
daf17d00
EZ
84582011-08-14 Eli Zaretskii <eliz@gnu.org>
8459
8460 * xdisp.c (move_it_in_display_line_to): Don't invoke
8461 IT_RESET_X_ASCENT_DESCENT when iterator position was restored from
8462 ppos_it. Fixes vertical cursor motion when line beginning is
8463 covered by an image. (Bug#9296)
8464
08e3161a
JD
84652011-08-14 Jan Djärv <jan.h.d@swipnet.se>
8466
8467 * nsterm.h (ns_run_ascript): Declare.
8468 (NSAPP_DATA2_RUNASSCRIPT): Define.
8469
8470 * nsfns.m (as_script, as_result, as_status): New static variables.
8471 (ns_run_ascript): New function.
5e617bc2 8472 (Fns_do_applescript): Set variables as_*. Make an NSApplicationDefined
08e3161a
JD
8473 event with data2 set to NSAPP_DATA2_RUNASSCRIPT, post it and then start
8474 the event loop. Get status from as_status (Bug#7276).
8475
8476 * nsterm.m (sendEvent): If event is NSApplicationDefined and
8477 data2 is NSAPP_DATA2_RUNASSCRIPT, call ns_run_ascript and then exit
8478 the event loop (Bug#7276).
8479
a3720aa2
AS
84802011-08-14 Andreas Schwab <schwab@linux-m68k.org>
8481
8482 * gnutls.c (QCgnutls_bootprop_priority)
8483 (QCgnutls_bootprop_trustfiles, QCgnutls_bootprop_keylist)
8484 (QCgnutls_bootprop_crlfiles, QCgnutls_bootprop_callbacks)
8485 (QCgnutls_bootprop_loglevel, QCgnutls_bootprop_hostname)
8486 (QCgnutls_bootprop_min_prime_bits, QCgnutls_bootprop_verify_flags)
8487 (QCgnutls_bootprop_verify_hostname_error)
8488 (QCgnutls_bootprop_callbacks_verify): Rename from
8489 Qgnutls_bootprop_..., all uses changed.
8490
8491 * xfaces.c (QCignore_defface): Rename from Qignore_defface, all
8492 uses changed.
8493
0a0d27fb
PE
84942011-08-14 Paul Eggert <eggert@cs.ucla.edu>
8495
19d5c50c
PE
8496 * xfaces.c (Qframe_set_background_mode): Now static.
8497 * dispextern.h (Qframe_set_background_mode): Remove decl.
8498
0a0d27fb
PE
8499 * process.c (Fnetwork_interface_info): Declare local only if needed.
8500
377538cb
JD
85012011-08-13 Jan Djärv <jan.h.d@swipnet.se>
8502
8503 * process.c: Include ifaddrs.h and net/if_dl.h if available (Bug#8477).
8504 (Fnetwork_interface_list): Allocate in increments of bytes instead
8505 of sizeof (struct ifreq). Iterate over ifconf.ifc_req by counting
8506 bytes (Bug#8477). Count bytes correctly when ifr_addr is a struct
8507 sockaddr.
8508 (struct ifflag_def): notrailers is smart on OSX.
8509 (Fnetwork_interface_info): Handle case when ifr_flags is negative.
8510 Get hardware address with getifaddrs if available.
8511
08fff70c
EZ
85122011-08-12 Eli Zaretskii <eliz@gnu.org>
8513
8514 * xdisp.c (iterate_out_of_display_property): xassert that
8515 IT->position is set to within IT->object's boundaries. Break from
8516 the loop as soon as EOB is reached; avoids infloops in redisplay
8b76d6f8
SM
8517 when IT->position is set up wrongly due to some bug.
8518 Set IT->current to match the bidi iterator unconditionally.
08fff70c
EZ
8519 (push_display_prop): Allow GET_FROM_STRING as IT->method on
8520 entry. Force push_it to save on the stack the current
8521 buffer/string position, to be restored by pop_it. Fix flags in
8522 the iterator structure wrt the object coming from a display
8523 property, as `line-prefix' and `wrap-prefix' are not ``replacing''
8524 properties. (Bug#9284)
8525
7be1c708 85262011-08-09 Andreas Schwab <schwab@linux-m68k.org>
aac0c6e3 8527
7be1c708
CY
8528 * fontset.c (fontset_get_font_group): Add proper type checks.
8529 (Bug#9172)
aac0c6e3 8530
7be1c708 85312011-08-09 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
aac0c6e3 8532
7be1c708
CY
8533 * unexmacosx.c (print_load_command_name): Add cases LC_FUNCTION_STARTS
8534 and LC_VERSION_MIN_MACOSX.
8535 (copy_linkedit_data) [LC_FUNCTION_STARTS]: New function.
8536 (dump_it) [LC_FUNCTION_STARTS]: Use it.
aac0c6e3 8537
97bb72a6
EZ
85382011-08-08 Eli Zaretskii <eliz@gnu.org>
8539
8540 * xdisp.c (forward_to_next_line_start): Allow to use the
8b76d6f8
SM
8541 no-display-properties-and-no-overlays under bidi display.
8542 Set disp_pos in the bidi iterator to avoid searches for display
757664a4 8543 properties and overlays.
97bb72a6 8544
d5617611
CY
85452011-08-08 Chong Yidong <cyd@stupidchicken.com>
8546
37e11a63
CY
8547 * editfns.c (Fset_time_zone_rule): Document relationship with the
8548 setenv function.
8549
d5617611
CY
8550 * ftfont.c (ftfont_pattern_entity): Copy the extras argument to
8551 the font entity extracted from the cache (Bug#8109).
8552
58872834
CY
85532011-08-07 Chong Yidong <cyd@stupidchicken.com>
8554
8555 * composite.c (autocmp_chars): Don't reset point. That is done by
8556 restore_point_unwind (Bug#5984).
8557
75bfc667
JL
85582011-08-07 Juri Linkov <juri@jurta.org>
8559
8560 * editfns.c (Fformat_time_string): Doc fix, add tag `usage:'
8561 to show the arg `TIME' instead of `TIMEVAL'.
8562
d1410150
EZ
85632011-08-06 Eli Zaretskii <eliz@gnu.org>
8564
8565 * xdisp.c (set_cursor_from_row): Fix cursor positioning when a
8566 display property strides EOL and includes a newline, as in
8567 longlines-mode. (Bug#9254)
75b771e4
EZ
8568 (move_it_in_display_line_to): Fix vertical-motion in a buffer with
8569 word-wrap under bidirectional display. (Bug#9224)
d1410150
EZ
8570
8571 * bidi.c (bidi_unshelve_cache): Don't reset the cache if JUST_FREE
8572 is non-zero, even if the data buffer is NULL. Fixes a crash in
8573 vertical-motion with longlines-mode. (Bug#9254)
8574
35928349
EZ
85752011-08-05 Eli Zaretskii <eliz@gnu.org>
8576
ec7cc85b
EZ
8577 * bidi.c <bidi_cache_total_alloc>: Now static.
8578 (bidi_initialize): Initialize bidi_cache_total_alloc.
8579
8b76d6f8 8580 * xdisp.c (display_line): Release buffer allocated for shelved bidi
35928349
EZ
8581 cache. (Bug#9221)
8582
8583 * bidi.c (bidi_shelve_cache, bidi_unshelve_cache): Track total
8584 amount allocated this far in `bidi_cache_total_alloc'.
8585 (bidi_unshelve_cache): Accept an additional argument JUST_FREE; if
8586 non-zero, only free the data buffer without restoring the cache
8587 contents. All callers changed.
8588
8589 * dispextern.h (bidi_unshelve_cache): Update prototype.
8590
8591 * xdisp.c (SAVE_IT, pos_visible_p, move_it_in_display_line_to)
8592 (move_it_in_display_line, move_it_to)
8593 (move_it_vertically_backward, move_it_by_lines): Replace the call
8594 to xfree to an equivalent call to bidi_unshelve_cache.
8595 (move_it_in_display_line_to): Fix logic of returning
412b6358 8596 MOVE_POS_MATCH_OR_ZV in the bidi case. (Bug#9224)
35928349 8597
e2e2423b
EZ
85982011-08-05 Eli Zaretskii <eliz@gnu.org>
8599
8600 * xdisp.c (set_cursor_from_row): Prefer the candidate glyph that
8601 came from a string character with a `cursor' property. (Bug#9229)
8602
ae9e757a
JD
86032011-08-04 Jan Djärv <jan.h.d@swipnet.se>
8604
8605 * Makefile.in (LIB_PTHREAD): New variable.
8606 (LIBES): Add LIB_PTHREAD (Bug#9216).
8607
8608 * alloc.c, emacs.c, gmalloc.c, gtkutil.c, keyboard.c, syssignal.h:
8609 Rename HAVE_GTK_AND_PTHREAD to HAVE_PTHREAD (Bug#9216).
8610
213bd7f2
AS
86112011-08-04 Andreas Schwab <schwab@linux-m68k.org>
8612
6b02f655 8613 * regex.c (re_iswctype): Remove some redundant boolean conversions.
213bd7f2 8614
99aaf75f
JD
86152011-08-04 Jan Djärv <jan.h.d@swipnet.se>
8616
8617 * xterm.c (x_find_topmost_parent): New function.
8618 (x_set_frame_alpha): Find topmost parent window with
8619 x_find_topmost_parent and set the property there also (bug#9181).
8620 (handle_one_xevent): Call x_set_frame_alpha on ReparentNotify.
8621
c74e9d86
PE
86222011-08-04 Paul Eggert <eggert@cs.ucla.edu>
8623
8624 * callproc.c (Fcall_process): Avoid vfork clobbering
8625 the local vars buffer, coding_systems, current_dir.
8626
640c8776
SM
86272011-08-03 Stefan Monnier <monnier@iro.umontreal.ca>
8628
8629 * keymap.c (Fmake_composed_keymap): Move to subr.el.
8630
f26d0e4c
PE
86312011-08-03 Paul Eggert <eggert@cs.ucla.edu>
8632
8a10d76c
PE
8633 * fontset.c (dump_fontset) [FONTSET_DEBUG]: Declare EXTERNALLY_VISIBLE
8634 so that it is not optimized away.
8635
f26d0e4c
PE
8636 * xdisp.c (compute_display_string_pos): Remove unused local.
8637
55439c61
EZ
86382011-08-02 Eli Zaretskii <eliz@gnu.org>
8639
8640 Fix slow cursor motion and scrolling in large buffers with
8641 selective display, like Org Mode buffers. (Bug#9218)
8642
8643 * dispextern.h (struct bidi_it): New member disp_prop_p.
8644
8645 * xdisp.c: Remove one-slot cache of display string positions.
8646 (compute_display_string_pos): Accept an additional argument
5e617bc2 8647 DISP_PROP_P; callers changed. Scan at most 5K characters forward
55439c61
EZ
8648 for a display string or property. If found, set DISP_PROP_P
8649 non-zero.
8650
8651 * bidi.c (bidi_fetch_char): Accept an additional argument
640c8776
SM
8652 DISP_PROP_P, and pass it to compute_display_string_pos.
8653 Only handle text covered by a display string if DISP_PROP_P is returned
55439c61
EZ
8654 non-zero. All callers of bidi_fetch_char changed.
8655
fb33fa43
SM
86562011-08-02 Stefan Monnier <monnier@iro.umontreal.ca>
8657
8658 * keymap.c (Fdefine_key): Fix Lisp_Object/int mixup; apply some CSE.
8659
b099e063
DM
86602010-12-03 Don March <don@ohspite.net>
8661
8662 * keymap.c (Fdefine_key): Fix non-prefix key error message when
8663 last character M-[char] is translated to ESC [char] (bug#7541).
8664
5cc7f7af
KH
86652011-08-02 Kenichi Handa <handa@m17n.org>
8666
d0fffa3f 8667 * lisp.h (uniprop_table): Extern it.
5cc7f7af
KH
8668
8669 * chartab.c (uniprop_table): Make it non-static.
8670
525d5e6e
EZ
86712011-08-01 Eli Zaretskii <eliz@gnu.org>
8672
8673 * xdisp.c (forward_to_next_line_start): Accept additional argument
8674 BIDI_IT_PREV, and store into it the state of the bidi iterator had
8675 on the newline.
8676 (reseat_at_next_visible_line_start): Use the bidi iterator state
8677 returned by forward_to_next_line_start to restore the state of
8678 it->bidi_it after backing up to previous newline. (Bug#9212)
8679
31011111
AS
86802011-07-30 Andreas Schwab <schwab@linux-m68k.org>
8681
8682 * regex.c (re_comp): Protoize.
8683 (re_exec): Fix return type.
8684 (regexec): Fix type of `ret'. (Bug#9203)
8685
476371c4
PE
86862011-07-28 Paul Eggert <eggert@cs.ucla.edu>
8687
e5d76069
PE
8688 * image.c (check_image_size): Use 1024x1024 if unknown frame (Bug#9189).
8689 This is needed if max-image-size is a floating-point number.
8690
9a79b20c
AS
86912011-07-28 Andreas Schwab <schwab@linux-m68k.org>
8692
8693 * print.c (print_object): Print empty symbol as ##.
8694
8695 * lread.c (read1): Read ## as empty symbol.
8696
d8c2fa78
AA
86972011-07-28 Alp Aker <alp.tekin.aker@gmail.com>
8698
8699 * nsfns.m (x_set_foreground_color): Set f->foreground_pixel when
8700 setting frame foreground color (Bug#9175).
8701 (x_set_background_color): Likewise.
8702
ffe57a7a
AA
8703 * nsmenu.m (-setText): Size tooltip dimensions precisely to
8704 contents (Bug#9176).
8705 (EmacsTooltip -init): Remove bezels and add shadows to
8706 tooltip windows.
8707
bf3492a5
AA
8708 * nsterm.m (ns_dumpglyphs_stretch): Avoid overwriting left fringe
8709 or scroll bar (Bug#8470).
8710
d55e9c53
AA
8711 * nsfont.m (nsfont_open): Remove assignment to voffset and
8712 unnecessary vars hshink, expand, hd, full_height, min_height.
8713 (nsfont_draw): Use s->ybase as baseline for glyph drawing (Bug#8913).
8714
8715 * nsterm.h (nsfont_info): Remove voffset field.
8716
d8c2fa78 87172011-07-28 Alp Aker <alp.tekin.aker@gmail.com>
4843aac3
AA
8718
8719 Implement strike-through and overline on NextStep (Bug#8863).
8720
8721 * nsfont.m (nsfont_open): Use underline position provided by font,
8722 instead of hard-coded value of 2.
8723 (nsfont_draw): Call ns_draw_text_decoration instead.
8724
8725 * nsterm.h: Add declaration for ns_draw_text_decoration.
8726
8727 * nsterm.m (ns_draw_text_decoration): New function for drawing
8728 underline, overline, and strike-through.
8729 (ns_dumpglyphs_image, ns_dumpglyphs_stretch): Add call to
8730 ns_draw_text_decoration. Change treatment of cursor drawing to
8d5ed899 8731 accommodate underlining, etc.
4843aac3 8732
4cc60b9b
EZ
87332011-07-28 Eli Zaretskii <eliz@gnu.org>
8734
bc7ece87
EZ
8735 * buffer.c (init_buffer_once): Set bidi-display-reordering to t by
8736 default.
4cc60b9b 8737
476371c4
PE
87382011-07-28 Paul Eggert <eggert@cs.ucla.edu>
8739
66606eea
PE
8740 * alloc.c (memory_full) [!SYNC_INPUT]: Fix signal-related race.
8741 Without this fix, if a signal arrives just after memory fills up,
8742 'malloc' might be invoked reentrantly.
8743
476371c4
PE
8744 * image.c (x_check_image_size) [!HAVE_X_WINDOWS]: Return 1.
8745 In other words, assume that every image size is allowed, on non-X
8746 hosts. This assumption is probably wrong, but it lets Emacs compile.
8747
f3fcc40d
AS
87482011-07-28 Andreas Schwab <schwab@linux-m68k.org>
8749
8750 * regex.c (re_iswctype): Convert return values to boolean.
8751
350c992f
EZ
87522011-07-28 Eli Zaretskii <eliz@fencepost.gnu.org>
8753
8754 * xdisp.c (compute_display_string_pos): Don't use cached display
8755 string position if the buffer had its restriction changed.
8756 (Bug#9184)
8757
5266b4bb
PE
87582011-07-28 Paul Eggert <eggert@cs.ucla.edu>
8759
8760 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork clobbering.
8761
2573a837 87622011-07-28 Paul Eggert <eggert@cs.ucla.edu>
ca4aa935 8763
41f55ccd 8764 Integer signedness and overflow and related fixes. (Bug#9079)
cf950e6b 8765
39e378da
PE
8766 * bidi.c: Integer size and overflow fixes.
8767 (bidi_cache_size, bidi_cache_idx, bidi_cache_last_idx)
8768 (bidi_cache_start, bidi_cache_fetch_state, bidi_cache_search)
8769 (bidi_cache_find_level_change, bidi_cache_ensure_space)
8770 (bidi_cache_iterator_state, bidi_cache_find, bidi_cache_start_stack)
8771 (bidi_find_other_level_edge):
8772 Use ptrdiff_t instead of EMACS_INT where either will do.
8773 This works better on 32-bit hosts configured --with-wide-int.
8774 (bidi_cache_ensure_space): Check for size-calculation overflow.
8775 Use % rather than repeated addition, for better worst-case speed.
8776 Don't set bidi_cache_size until after xrealloc returns, because it
8777 might not return.
8778 (bidi_dump_cached_states): Use ptrdiff_t, not int, to avoid overflow.
f0eb61e9
PE
8779 (bidi_cache_ensure_space): Also check that the bidi cache size
8780 does not exceed that of the largest Lisp string or buffer. See Eli
8781 Zaretskii in <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=9079#29>.
39e378da 8782
5e927815
PE
8783 * alloc.c (__malloc_size_t): Remove.
8784 All uses replaced by size_t. See Andreas Schwab's note
8785 <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=9079#8>.
8786
ca4aa935
PE
8787 * image.c: Improve checking for integer overflow.
8788 (check_image_size): Assume that f is nonnull, since
8789 it is always nonnull in practice. This is one less thing to
8790 worry about when checking for integer overflow later.
8791 (x_check_image_size): New function, which checks for integer
8792 overflow issues inside X.
8793 (x_create_x_image_and_pixmap, xbm_read_bitmap_data): Use it.
8794 This removes the need for a memory_full check.
8795 (xbm_image_p): Rewrite to avoid integer multiplication overflow.
8796 (Create_Pixmap_From_Bitmap_Data, xbm_load): Use x_check_image_size.
8797 (xbm_read_bitmap_data): Change locals back to 'int', since
8798 their values must fit in 'int'.
8799 (xpm_load_image, png_load, tiff_load):
8800 Invoke x_create_x_image_and_pixmap earlier,
8801 to avoid much needless work if the image is too large.
8802 (tiff_load): Treat overly large images as if
8803 x_create_x_image_and_pixmap failed, not as malloc failures.
8804 (gs_load): Use x_check_image_size.
8805
5f8f9cc2
PE
8806 * gtkutil.c: Omit integer casts.
8807 (xg_get_pixbuf_from_pixmap): Remove unnecessary cast.
8808 (xg_set_toolkit_scroll_bar_thumb): Rewrite to avoid need for cast.
8809
5adf60bc
PE
8810 * image.c (png_load): Don't assume height * row_bytes fits in 'int'.
8811
c8907a93
PE
8812 * xfaces.c (Fbitmap_spec_p): Fix integer overflow bug.
8813 Without this fix, (bitmap-spec-p '(34359738368 1 "x"))
8814 would wrongly return t on a 64-bit host.
8815
e3c25c68
PE
8816 * dispnew.c (init_display): Use *_RANGE_OVERFLOW macros.
8817 The plain *_OVERFLOW macros run afoul of GCC bug 49705
8818 <http://gcc.gnu.org/bugzilla/show_bug.cgi?id=49705>
8819 and therefore cause GCC to emit a bogus diagnostic in some cases.
8820
3f791afe
PE
8821 * image.c: Integer signedness and overflow and related fixes.
8822 This is not an exhaustive set of fixes, but it's time to
8823 record what I've got.
8824 (lookup_pixel_color, check_image_size): Remove redundant decls.
8825 (check_image_size): Don't assume that arbitrary EMACS_INT values
8826 fit in 'int', or that arbitrary 'double' values fit in 'int'.
8827 (x_alloc_image_color, x_create_x_image_and_pixmap, png_load)
8828 (tiff_load, imagemagick_load_image):
8829 Check for overflow in size calculations.
8830 (x_create_x_image_and_pixmap): Remove unnecessary test for
8831 xmalloc returning NULL; that can't happen.
8832 (xbm_read_bitmap_data): Don't assume sizes fit into 'int'.
8833 (xpm_color_bucket): Use better integer hashing function.
8834 (xpm_cache_color): Don't possibly over-allocate memory.
8835 (struct png_memory_storage, tiff_memory_source, tiff_seek_in_memory)
8836 (gif_memory_source):
8837 Use ptrdiff_t, not int or size_t, to record sizes.
8838 (png_load): Don't assume values greater than 2**31 fit in 'int'.
8839 (our_stdio_fill_input_buffer): Prefer ptrdiff_t to size_t when
8840 either works, as we prefer signed integers.
8841 (tiff_read_from_memory, tiff_write_from_memory):
8842 Return tsize_t, not size_t, since that's what the TIFF API wants.
8843 (tiff_read_from_memory): Don't fail simply because the read would
8844 go past EOF; instead, return a short read.
8845 (tiff_load): Omit no-longer-needed casts.
8846 (Fimagemagick_types): Don't assume size fits into 'int'.
8847
3cc5a532
PE
8848 Improve hashing quality when configured --with-wide-int.
8849 * fns.c (hash_string): New function, taken from sxhash_string.
8850 Do not discard information about ASCII character case; this
8851 discarding is no longer needed.
8852 (sxhash-string): Use it. Change sig to match it. Caller changed.
8853 * lisp.h: Declare it.
8854 * lread.c (hash_string): Remove, since we now use fns.c's version.
8855 The fns.c version returns a wider integer if --with-wide-int is
8856 specified, so this should help the quality of the hashing a bit.
8857
b312a492
PE
8858 * emacs.c: Integer overflow minor fix.
8859 (heap_bss_diff): Now uprintmax_t, not unsigned long. All used changed.
8860 Define only if GNU_LINUX.
8861 (main, Fdump_emacs): Set and use heap_bss_diff only if GNU_LINUX.
8862
dfd153ae
PE
8863 * dispnew.c: Integer signedness and overflow fixes.
8864 Remove unnecessary forward decls, that were a maintenance hassle.
8865 (history_tick): Now uprintmax_t, so it's more likely to avoid overflow.
8866 All uses changed.
8867 (adjust_glyph_matrix, realloc_glyph_pool, adjust_frame_message_buffer)
8868 (scrolling_window): Use ptrdiff_t, not int, for byte count.
8869 (prepare_desired_row, line_draw_cost):
8870 Use int, not unsigned, where either works.
8871 (save_current_matrix, restore_current_matrix):
8872 Use ptrdiff_t, not size_t, where either works.
8873 (init_display): Check for overflow more accurately, and without
8874 relying on undefined behavior.
8875
a81d11a3
PE
8876 * editfns.c (pWIDE, pWIDElen, signed_wide, unsigned_wide):
8877 Remove, replacing with the new symbols in lisp.h. All uses changed.
8878 * fileio.c (make_temp_name):
8879 * filelock.c (lock_file_1, lock_file):
8880 * xdisp.c (message_dolog):
8881 Don't assume PRIdMAX etc. works; this isn't portable to pre-C99 hosts.
8882 Use pMd etc. instead.
8883 * lisp.h (printmax_t, uprintmax_t, pMd, pMu): New types and macros,
8884 replacing the pWIDE etc. symbols removed from editfns.c.
8885
3300e6fd
PE
8886 * keyboard.h (num_input_events): Now uintmax_t.
8887 This is (very slightly) less likely to mess up due to wraparound.
8888 All uses changed.
8889
fd05c7e9
PE
8890 * buffer.c: Integer signedness fixes.
8891 (alloc_buffer_text, enlarge_buffer_text):
8892 Use ptrdiff_t rather than size_t when either will do, as we prefer
8893 signed integers.
8894
903fe15d
PE
8895 * alloc.c: Integer signedness and overflow fixes.
8896 Do not impose an arbitrary 32-bit limit on malloc sizes when debugging.
8897 (__malloc_size_t): Default to size_t, not to int.
8898 (pure_size, pure_bytes_used_before_overflow, stack_copy_size)
8899 (Fgarbage_collect, mark_object_loop_halt, mark_object):
8900 Prefer ptrdiff_t to size_t when either would do, as we prefer
8901 signed integers.
8902 (XMALLOC_OVERRUN_CHECK_OVERHEAD): New macro.
8903 (xmalloc_overrun_check_header, xmalloc_overrun_check_trailer):
8904 Now const. Initialize with values that are in range even if char
8905 is signed.
8906 (XMALLOC_PUT_SIZE, XMALLOC_GET_SIZE): Remove, replacing with ...
8907 (xmalloc_put_size, xmalloc_get_size): New functions. All uses changed.
8908 These functions do the right thing with sizes > 2**32.
8909 (check_depth): Now ptrdiff_t, not int.
8910 (overrun_check_malloc, overrun_check_realloc, overrun_check_free):
8911 Adjust to new way of storing sizes. Check for size overflow bugs
8912 in rest of code.
8913 (STRING_BYTES_MAX): Adjust to new overheads. The old code was
8914 slightly wrong anyway, as it missed one instance of
8915 XMALLOC_OVERRUN_CHECK_OVERHEAD.
8916 (refill_memory_reserve): Omit needless cast to size_t.
8917 (mark_object_loop_halt): Mark as externally visible.
8918
ac82cc6a
PE
8919 * xselect.c: Integer signedness and overflow fixes.
8920 (Fx_register_dnd_atom, x_handle_dnd_message):
8921 Use ptrdiff_t, not size_t, since we prefer signed.
8922 (Fx_register_dnd_atom): Check for ptrdiff_t (and size_t) overflow.
8923 * xterm.h (struct x_display_info): Use ptrdiff_t, not size_t, for
8924 x_dnd_atoms_size and x_dnd_atoms_length.
8925
c2d1e36d
PE
8926 * doprnt.c: Prefer signed to unsigned when either works.
8927 * eval.c (verror):
8928 * doprnt.c (doprnt):
8929 * lisp.h (doprnt):
8930 * xdisp.c (vmessage):
8931 Use ptrdiff_t, not size_t, when using or implementing doprnt,
8932 since the sizes cannot exceed ptrdiff_t bounds anyway, and we
8933 prefer signed arithmetic to avoid comparison confusion.
8934 * doprnt.c (doprnt): Avoid a "+ 1" that can't overflow,
8935 but is a bit tricky.
8936
0e926e56
PE
8937 Assume freestanding C89 headers, string.h, stdlib.h.
8938 * data.c, doprnt.c, floatfns.c, print.c:
8939 Include float.h unconditionally.
8940 * gmalloc.c: Assume C89-at-least behavior for preprocessor,
8941 limits.h, stddef.h, string.h. Use memset instead of 'flood'.
8942 * regex.c: Likewise for stddef.h, string.h.
8943 (ISASCII): Remove; can assume it returns 1 now. All uses removed.
8944 * s/aix4-2.h (HAVE_STRING_H): Remove obsolete undef.
8945 * s/ms-w32.h (HAVE_LIMITS_H, HAVE_STRING_H, HAVE_STDLIB_H)
8946 (STDC_HEADERS): Remove obsolete defines.
8947 * sysdep.c: Include limits.h unconditionally.
8948
9cfdb3ec
PE
8949 Assume support for memcmp, memcpy, memmove, memset.
8950 * lisp.h, sysdep.c (memcmp, memcpy, memmove, memset):
8951 * regex.c (memcmp, memcpy):
8952 Remove; we assume C89 now.
8953
8954 * gmalloc.c (memcpy, memset, memmove): Remove; we assume C89 now.
8955 (__malloc_safe_bcopy): Remove; no longer needed.
8956
cf950e6b 8957 * lisp.h (struct vectorlike_header, struct Lisp_Subr): Signed sizes.
6089c567
PE
8958 Use EMACS_INT, not EMACS_UINT, for sizes. The code works equally
8959 well either way, and we prefer signed to unsigned.
8960
dbf38e02
LMI
89612011-07-27 Lars Magne Ingebrigtsen <larsi@gnus.org>
8962
8963 * gnutls.c (emacs_gnutls_read): Don't message anything if the peer
8964 closes the connection while we're reading (bug#9182).
8965
d6f0886c 89662011-07-25 Jan Djärv <jan.h.d@swipnet.se>
24e0f6b1 8967
d6f0886c
JD
8968 * nsmenu.m (ns_popup_dialog): Add an "ok" button if no buttons
8969 are specified (Bug#9168).
24e0f6b1 8970
2eb1f9e6
PE
89712011-07-25 Paul Eggert <eggert@cs.ucla.edu>
8972
8973 * bidi.c (bidi_dump_cached_states): Fix printf format mismatch.
8974 Found by GCC static checking and --with-wide-int on a 32-bit host.
8975
22381272 89762011-07-25 Eli Zaretskii <eliz@gnu.org>
7daee910
EZ
8977
8978 * xdisp.c (compute_display_string_pos): Fix logic of caching
8979 previous display string position. Initialize cached_prev_pos to
8980 -1. Fixes slow-down at the beginning of a buffer.
8981
f25e39b4
EZ
89822011-07-24 Eli Zaretskii <eliz@gnu.org>
8983
8984 * xfaces.c (check_lface_attrs) [HAVE_WINDOW_SYSTEM]: Allow `nil'
8985 for attrs[LFACE_FONTSET_INDEX].
8986
04c4b52e
PE
89872011-07-23 Paul Eggert <eggert@cs.ucla.edu>
8988
8989 * xml.c (parse_region): Remove unused local
8990 that was recently introduced.
8991
c1734fbd
EZ
89922011-07-23 Eli Zaretskii <eliz@gnu.org>
8993
be18c5a5
EZ
8994 * xfns.c (unwind_create_frame) [GLYPH_DEBUG]: Adapt to changes in
8995 2008-02-22T17:42:09Z!monnier@iro.umontreal.ca.
8996
c1734fbd
EZ
8997 * xdisp.c (move_it_in_display_line_to): Record the best matching
8998 position for TO_CHARPOS while scanning the line, and restore it on
640c8776
SM
8999 exit if none of the characters scanned was an exact match.
9000 Fixes vertical-motion and pos-visible-in-window-p under bidi redisplay
a9269c18
EZ
9001 when exact match is impossible due to invisible text, and the
9002 lines are truncated.
9003
a258d627
JD
90042011-07-23 Jan Djärv <jan.h.d@swipnet.se>
9005
9006 * nsterm.m (initFrameFromEmacs): Set NSTitledWindowMask in styleMask
9007 for OSX >= 10.7.
9008
b6d5a689
EZ
90092011-07-22 Eli Zaretskii <eliz@gnu.org>
9010
0f74f785
EZ
9011 Fix a significant slow-down of cursor motion with C-n, C-p,
9012 C-f/C-b, and C-v/M-v that couldn't keep up with keyboard
9013 auto-repeat under bidi redisplay in fontified buffers.
b6d5a689 9014 * xdisp.c (compute_stop_pos_backwards): New function.
b6d5a689
EZ
9015 (next_element_from_buffer): Call compute_stop_pos_backwards to
9016 find a suitable prev_stop when we find ourselves before
0f74f785
EZ
9017 base_level_stop.
9018 (reseat): Don't look for prev_stop, as that could mean a very long
9019 run.
9020 <cached_disp_pos, cached_disp_buffer, cached_disp_modiff>
9021 <cached_disp_overlay_modiff>: Cache for last found display string
9022 position.
551918c1 9023 (compute_display_string_pos): Return the cached position if asked
0f74f785
EZ
9024 about the same buffer in the same area of character positions, and
9025 the buffer wasn't changed since the time the display string
9026 position was cached.
551918c1 9027
b2d0c91a
EZ
90282011-07-22 Eli Zaretskii <eliz@gnu.org>
9029
9030 * xdisp.c (rows_from_pos_range): Don't ignore glyphs whose object
9031 is an integer, which is important for empty lines. (Bug#9149)
9032
043604ee
CY
90332011-07-22 Chong Yidong <cyd@stupidchicken.com>
9034
9035 * frame.c (Fmodify_frame_parameters): In tty case, update the
9036 default face if necessary (Bug#4238).
9037
da4adb04
CY
90382011-07-21 Chong Yidong <cyd@stupidchicken.com>
9039
9040 * editfns.c (Fstring_to_char): No need to explain what a character
9041 is in the docstring (Bug#6576).
9042
9abd0532
LMI
90432011-07-20 Lars Magne Ingebrigtsen <larsi@gnus.org>
9044
9045 * xml.c (parse_region): Make sure we always return a tree.
9046
36881d16
HK
90472011-07-20 HAMANO Kiyoto <khiker.mail@gmail.com>
9048
9049 * xml.c (parse_region): If a document contains only comments,
9050 return that, too.
9051
1e98674d
LMI
90522011-07-20 Lars Magne Ingebrigtsen <larsi@gnus.org>
9053
9054 * xml.c (make_dom): Return comments, too.
9055
590bd467
PE
90562011-07-19 Paul Eggert <eggert@cs.ucla.edu>
9057
9058 Port to OpenBSD.
9059 See http://lists.gnu.org/archive/html/emacs-devel/2011-07/msg00688.html
9060 and the surrounding thread.
9061 * minibuf.c (read_minibuf_noninteractive): Rewrite to use getchar
9062 rather than fgets, and retry after EINTR. Otherwise, 'emacs
9063 --batch -f byte-compile-file' fails on OpenBSD if an inactivity
9064 timer goes off.
9065 * s/openbsd.h (BROKEN_SIGIO): Define.
9066 * unexelf.c (unexec) [__OpenBSD__]:
9067 Don't update the .mdebug section of the Alpha COFF symbol table.
9068
f41628b2
LMI
90692011-07-19 Lars Magne Ingebrigtsen <larsi@gnus.org>
9070
9071 * lread.c (syms_of_lread): Clarify when `lexical-binding' is used
9072 (bug#8460).
9073
b59b67c5
PE
90742011-07-18 Paul Eggert <eggert@cs.ucla.edu>
9075
15e3a074
PE
9076 * fileio.c (Fcopy_file) [!MSDOS]: Tighten created file's mask.
9077 This fixes some race conditions on the permissions of any newly
9078 created file.
9079
41bed37d
PE
9080 * alloc.c (valid_pointer_p): Use pipe, not open.
9081 This fixes some permissions issues when debugging.
9082
b59b67c5
PE
9083 * fileio.c (Fcopy_file): Adjust mode if fchown fails. (Bug#9002)
9084 If fchown fails to set both uid and gid, try to set just gid,
9085 as that is sometimes allowed. Adjust the file's mode to eliminate
9086 setuid or setgid bits that are inappropriate if fchown fails.
9087
925a6be7
SM
90882011-07-18 Stefan Monnier <monnier@iro.umontreal.ca>
9089
9090 * xdisp.c (next_element_from_string, next_element_from_buffer): Use EQ
9091 to compare Lisp_Objects.
9092 * gnutls.c (syms_of_gnutls): Rename Vgnutls_log_level to
9093 global_gnutls_log_level, don't mistake it for a Lisp_Object.
9094 (init_gnutls_functions, emacs_gnutls_handle_error): Fix up uses.
9095
52968808
AS
90962011-07-17 Andreas Schwab <schwab@linux-m68k.org>
9097
0a6a104b
AS
9098 * lread.c (read_integer): Unread even EOF character.
9099 (read1): Likewise. Properly record start position of symbol.
9100
52968808
AS
9101 * lread.c (read1): Read `#:' as empty uninterned symbol if no
9102 symbol character follows.
9103
9e381cdd
PE
91042011-07-17 Paul Eggert <eggert@cs.ucla.edu>
9105
9106 * fileio.c (Fcopy_file): Pacify gcc re fchown. (Bug#9002)
9107 This works around a problem with the previous change to Fcopy_file.
9108 Recent glibc declares fchown with __attribute__((warn_unused_result)),
9109 and without this change, GCC might complain about discarding
9110 fchown's return value.
9111
b5641435
JB
91122011-07-16 Juanma Barranquero <lekktu@gmail.com>
9113
9114 * makefile.w32-in (GLOBAL_SOURCES): Add gnutls.c (followup to bug#9059).
9115
a8031457
PE
91162011-07-16 Paul Eggert <eggert@cs.ucla.edu>
9117
9118 * fileio.c (Fcopy_file): Don't diagnose fchown failures. (Bug#9002)
9119
dd889327
LMI
91202011-07-16 Lars Magne Ingebrigtsen <larsi@gnus.org>
9121
750c33f7
LMI
9122 * gnutls.c (syms_of_gnutls): Define `gnutls-log-level' here, since
9123 it's used from the C level.
9124
dd889327
LMI
9125 * process.c: Use the same condition for POLL_FOR_INPUT in both
9126 keyboard.c and process.c (bug#1858).
9127
87e86684
LM
91282011-07-09 Lawrence Mitchell <wence@gmx.li>
9129
9130 * gnutls.c (Qgnutls_bootprop_min_prime_bits): New variable.
9131 (Fgnutls_boot): Use it.
9132
64348f40
AS
91332011-07-15 Andreas Schwab <schwab@linux-m68k.org>
9134
9135 * doc.c (Fsubstitute_command_keys): Revert last change.
9136
1d698799
LMI
91372011-07-15 Lars Magne Ingebrigtsen <larsi@gnus.org>
9138
f863868c
LMI
9139 * doc.c (Fsubstitute_command_keys): Clarify that \= really only
9140 quotes the next character, and doesn't affect other longer
9141 sequences (bug#8935).
9142
1d698799
LMI
9143 * lread.c (syms_of_lread): Clarify that is isn't only
9144 `eval-buffer' and `eval-defun' that's affected by
9145 `lexical-binding' (bug#8460).
9146
aa4b6df6
EZ
91472011-07-15 Eli Zaretskii <eliz@gnu.org>
9148
9149 * xdisp.c (move_it_in_display_line_to): Fix vertical motion with
6b02f655 9150 bidi redisplay when a line includes both an image and is truncated.
aa4b6df6 9151
5d856da6
PE
91522011-07-14 Paul Eggert <eggert@cs.ucla.edu>
9153
ad6042bb
PE
9154 Fix minor problems found by static checking.
9155 * bidi.c (bidi_cache_size): Now EMACS_INT, not size_t.
9156 (elsz): Now a signed constant, not a size_t var. We prefer signed
9157 types to unsigned, to avoid integer comparison confusion. Without
9158 this change, GCC 4.6.1 with -Wunsafe-loop-optimizations complains
9159 "cannot optimize loop, the loop counter may overflow", a symptom
9160 of the confusion.
f00bbb22 9161 * indent.c (Fvertical_motion): Mark locals as initialized.
5d856da6
PE
9162 * xdisp.c (reseat_to_string): Fix pointer signedness issue.
9163
6468f31c
LMI
91642011-07-14 Lars Magne Ingebrigtsen <larsi@gnus.org>
9165
49080b10
LMI
9166 * search.c (Fre_search_backward): Mention `case-fold-search' in
9167 all the re_search_* functions (bug#8138).
9168
6468f31c
LMI
9169 * keyboard.c (Fopen_dribble_file): Document when the file is
9170 closed (bug#8056).
9171
c965adc5
EZ
91722011-07-14 Eli Zaretskii <eliz@gnu.org>
9173
df9733bf
EZ
9174 * bidi.c (bidi_dump_cached_states): Fix format of displaying
9175 bidi_cache_idx.
9176
0bb23927
EZ
9177 Support bidi reordering of display and overlay strings.
9178 * xdisp.c (compute_display_string_pos)
9179 (compute_display_string_end): Accept additional argument STRING.
9180 (init_iterator, reseat_1): Initialize bidi_it->string.s to NULL.
9181 (reseat_to_string): Initialize bidi_it->string.s and
9182 bidi_it->string.schars.
9183 (Fcurrent_bidi_paragraph_direction): Initialize itb.string.s to
640c8776
SM
9184 NULL (avoids a crash in bidi_paragraph_init).
9185 Initialize itb.string.lstring.
0bb23927
EZ
9186 (init_iterator): Call bidi_init_it only of a valid
9187 buffer position was specified. Initialize paragraph_embedding to
9188 L2R.
9189 (reseat_to_string): Initialize the bidi iterator.
9190 (display_string): If we need to ignore text properties of
9191 LISP_STRING, set IT->stop_charpos to IT->end_charpos. (The
9192 original value of -1 will not work with bidi.)
9193 (compute_display_string_pos): First arg is now struct
9194 `text_pos *'; all callers changed. Support display properties on
9195 Lisp strings.
9196 (compute_display_string_end): Support display properties on Lisp
9197 strings.
9198 (init_iterator, reseat_1, reseat_to_string): Initialize the
9199 string.bufpos member to 0 (zero, for compatibility with IT_CHARPOS
9200 when iterating on a string not from display properties).
640c8776
SM
9201 (compute_display_string_pos, compute_display_string_end):
9202 Fix calculation of the object to scan. Fixes an error when using
0bb23927
EZ
9203 arrow keys.
9204 (next_element_from_buffer): Don't abort when IT_CHARPOS is before
640c8776
SM
9205 base_level_stop; instead, set base_level_stop to BEGV.
9206 Fixes crashes in vertical-motion.
0bb23927
EZ
9207 (next_element_from_buffer): Improve commentary for when
9208 the iterator is before prev_stop.
9209 (init_iterator): Initialize bidi_p from the default value of
9210 bidi-display-reordering, not from buffer-local value. Use the
9211 buffer-local value only if initializing for buffer iteration.
9212 (handle_invisible_prop): Support invisible properties on strings
9213 that are being bidi-reordered.
9214 (set_iterator_to_next): Support bidi reordering of C strings and
9215 Lisp strings.
9216 (next_element_from_string): Support bidi reordering of Lisp
9217 strings.
9218 (handle_stop_backwards): Support Lisp strings as well.
640c8776
SM
9219 (display_string): Support display of R2L glyph rows.
9220 Use IT_STRING_CHARPOS when displaying from a Lisp string.
0bb23927
EZ
9221 (init_iterator): Don't initialize it->bidi_p for strings
9222 here.
9223 (reseat_to_string): Initialize it->bidi_p for strings here.
9224 (next_element_from_string, next_element_from_c_string)
9225 (next_element_from_buffer): Add xassert's for correspondence
9226 between IT's object being iterated and it->bidi_it.string
9227 structure.
9228 (face_before_or_after_it_pos): Support bidi iteration.
9229 (next_element_from_c_string): Handle the case of the first string
9230 character that is not the first one in the visual order.
9231 (get_visually_first_element): New function, refactored from common
9232 parts of next_element_from_buffer, next_element_from_string, and
9233 next_element_from_c_string.
9234 (tool_bar_lines_needed, redisplay_tool_bar)
9235 (display_menu_bar): Force left-to-right direction. Add a FIXME
9236 comment for making that be controlled by a user option.
9237 (push_it, pop_it): Save and restore the state of the
9238 bidi iterator. Save and restore the bidi_p flag.
9239 (pop_it): Iterate out of display property for string iteration as
9240 well.
9241 (iterate_out_of_display_property): Support iteration over strings.
9242 (handle_single_display_spec): Set up it->bidi_it for iteration
9243 over a display string, and call bidi_init_it.
9244 (handle_single_display_spec, next_overlay_string)
9245 (get_overlay_strings_1, push_display_prop): Set up the bidi
9246 iterator for displaying display or overlay strings.
9247 (forward_to_next_line_start): Don't use the shortcut if
9248 bidi-iterating.
9249 (back_to_previous_visible_line_start): If handle_display_prop
9250 pushed the iterator stack, restore the internal state of the bidi
9251 iterator by calling bidi_pop_it same number of times.
9252 (reseat_at_next_visible_line_start): If ON_NEWLINE_P is non-zero,
9253 and we are bidi-iterating, don't decrement the iterator position;
9254 instead, set the first_elt flag in the bidi iterator, to produce
9255 the same effect.
9256 (reseat_1): Remove redundant setting of string_from_display_prop_p.
9257 (push_display_prop): xassert that we are iterating a buffer.
9258 (push_it, pop_it): Save and restore paragraph_embedding member.
9259 (handle_single_display_spec, next_overlay_string)
9260 (get_overlay_strings_1, reseat_1, reseat_to_string)
9261 (push_display_prop): Set up the `unibyte' member of bidi_it.string
9262 correctly. Don't assume unibyte strings are not bidi-reordered.
9263 (compute_display_string_pos)
9264 (compute_display_string_end): Fix handling the case of C string.
9265 (push_it, pop_it): Save and restore from_disp_prop_p.
9266 (handle_single_display_spec, push_display_prop): Set the
9267 from_disp_prop_p flag.
9268 (get_overlay_strings_1): Reset the from_disp_prop_p flag.
9269 (pop_it): Call iterate_out_of_display_property only if we are
9270 popping after iteration over a string that came from a display
9271 property. Fix a typo in popping stretch info. Add an assertion
9272 for verifying that the iterator position is in sync with the bidi
9273 iterator.
9274 (handle_single_display_spec, get_overlay_strings_1)
9275 (push_display_prop): Fix initialization of paragraph direction for
9276 string when that of the parent object is not yet determined.
9277 (reseat_1): Call bidi_init_it to resync the bidi
9278 iterator with IT's position. (Bug#7616)
9279 (find_row_edges): If ROW->start.pos gives position
9280 smaller than min_pos, use it as ROW->minpos. (Bug#7616)
9281 (handle_stop, back_to_previous_visible_line_start, reseat_1):
9282 Reset the from_disp_prop_p flag.
9283 (SAVE_IT, RESTORE_IT): New macros.
9284 (pos_visible_p, face_before_or_after_it_pos)
9285 (back_to_previous_visible_line_start)
9286 (move_it_in_display_line_to, move_it_in_display_line)
9287 (move_it_to, move_it_vertically_backward, move_it_by_lines)
9288 (try_scrolling, redisplay_window, display_line): Use them when
9289 saving a temporary copy of the iterator and restoring it back.
9290 (back_to_previous_visible_line_start, reseat_1)
9291 (init_iterator): Empty the bidi cache "stack".
9292 (move_it_in_display_line_to): If iterator ended up at
9293 EOL, but we never saw any buffer positions smaller than
9294 to_charpos, return MOVE_POS_MATCH_OR_ZV. Fixes vertical cursor
9295 motion in bidi-reordered lines.
9296 (move_it_in_display_line_to): Record prev_method and prev_pos
9297 immediately before the call to set_iterator_to_next. Fixes cursor
9298 motion in bidi-reordered lines with stretch glyphs and strings
9299 displayed in margins. (Bug#8133) (Bug#8867)
9300 Return MOVE_POS_MATCH_OR_ZV only if iterator position is past
9301 TO_CHARPOS.
640c8776
SM
9302 (pos_visible_p): Support positions in bidi-reordered lines.
9303 Save and restore bidi cache.
0bb23927
EZ
9304
9305 * bidi.c (bidi_level_of_next_char): clen should be EMACS_NT, not int.
9306 (bidi_paragraph_info): Delete unused struct.
9307 (bidi_cache_idx, bidi_cache_last_idx): Declare EMACS_INT.
9308 (bidi_cache_start): New variable.
9309 (bidi_cache_reset): Reset bidi_cache_idx to bidi_cache_start, not
9310 to zero.
9311 (bidi_cache_fetch_state, bidi_cache_search)
9312 (bidi_cache_find_level_change, bidi_cache_iterator_state)
9313 (bidi_cache_find, bidi_peek_at_next_level)
9314 (bidi_level_of_next_char, bidi_find_other_level_edge)
9315 (bidi_move_to_visually_next): Compare cache index with
9316 bidi_cache_start rather than with zero.
9317 (bidi_fetch_char): Accept new argument STRING; all callers
9318 changed. Support iteration over a string. Support strings with
9319 display properties. Support unibyte strings. Fix the type of
9320 `len' according to what STRING_CHAR_AND_LENGTH expects.
9321 (bidi_paragraph_init, bidi_resolve_explicit_1)
9322 (bidi_resolve_explicit, bidi_resolve_weak)
640c8776
SM
9323 (bidi_level_of_next_char, bidi_move_to_visually_next):
9324 Support iteration over a string.
0bb23927
EZ
9325 (bidi_set_sor_type, bidi_resolve_explicit_1)
9326 (bidi_resolve_explicit, bidi_type_of_next_char): ignore_bn_limit
9327 can now be zero (for strings); special values 0 and -1 were
9328 changed to -1 and -2, respectively.
9329 (bidi_char_at_pos): New function.
9330 (bidi_paragraph_init, bidi_resolve_explicit, bidi_resolve_weak):
9331 Call it instead of FETCH_MULTIBYTE_CHAR.
9332 (bidi_move_to_visually_next): Abort if charpos or bytepos were not
9333 initialized to valid values.
9334 (bidi_init_it): Don't initialize charpos and bytepos with invalid
9335 values.
9336 (bidi_level_of_next_char): Allow the sentinel "position" to pass
9337 the test for valid cached positions. Fix the logic for looking up
9338 the sentinel state in the cache. GCPRO the Lisp string we are
9339 iterating.
9340 (bidi_push_it, bidi_pop_it): New functions.
9341 (bidi_initialize): Initialize the bidi cache start stack pointer.
9342 (bidi_cache_ensure_space): New function, refactored from part of
9343 bidi_cache_iterator_state. Don't assume the required size is just
9344 one BIDI_CACHE_CHUNK away.
9345 (bidi_cache_start_stack, bidi_push_it): Use IT_STACK_SIZE.
9346 (bidi_count_bytes, bidi_char_at_pos): New functions.
9347 (bidi_cache_search): Don't assume bidi_cache_last_idx is
9348 always valid if bidi_cache_idx is valid.
9349 (bidi_cache_find_level_change): xassert that bidi_cache_last_idx
9350 is valid if it's going to be used.
9351 (bidi_shelve_cache, bidi_unshelve_cache): New functions.
9352 (bidi_cache_fetch_state, bidi_cache_search)
c965adc5
EZ
9353 (bidi_cache_find_level_change, bidi_cache_ensure_space)
9354 (bidi_cache_iterator_state, bidi_cache_find)
640c8776
SM
9355 (bidi_find_other_level_edge, bidi_cache_start_stack):
9356 All variables related to cache indices are now EMACS_INT.
c965adc5 9357
0bb23927
EZ
9358 * dispextern.h (struct bidi_string_data): New structure.
9359 (struct bidi_it): New member `string'. Make flag members be 1-bit
9360 fields, and put them last in the struct.
640c8776
SM
9361 (compute_display_string_pos, compute_display_string_end):
9362 Update prototypes.
0bb23927
EZ
9363 (bidi_push_it, bidi_pop_it): Add prototypes.
9364 (struct iterator_stack_entry): New members bidi_p,
9365 paragraph_embedding, and from_disp_prop_p.
9366 (struct it): Member bidi_p is now a bit field 1 bit wide.
640c8776
SM
9367 (bidi_shelve_cache, bidi_unshelve_cache):
9368 Declare prototypes.
0bb23927
EZ
9369
9370 * .gdbinit (xvectype, xvector, xcompiled, xchartable, xboolvector)
9371 (xpr, xfont, xbacktrace): Use "header.size" when accessing vectors
9372 and vector-like objects.
9373
9374 * dispnew.c (buffer_posn_from_coords): Save and restore the bidi
9375 cache around display iteration.
9376
9377 * window.c (Fwindow_end, window_scroll_pixel_based)
9378 (displayed_window_lines, Frecenter): Save and restore the bidi
9379 cache around display iteration.
9380
3bbd2265
LMI
93812011-07-14 Lars Magne Ingebrigtsen <larsi@gnus.org>
9382
9383 * editfns.c (Fdelete_region): Clarify the use of the named
9384 parameters (bug#6788).
9385
adc47434
MR
93862011-07-14 Martin Rudalics <rudalics@gmx.at>
9387
9388 * indent.c (Fvertical_motion): Set and restore w->pointm when
9389 saving and restoring the window's buffer (Bug#9006).
9390
837c31f8
LMI
93912011-07-13 Lars Magne Ingebrigtsen <larsi@gnus.org>
9392
9393 * editfns.c (Fstring_to_char): Clarify just what is returned
9394 (bug#6576). Text by Eli Zaretskii.
9395
ac389d0c
JB
93962011-07-13 Juanma Barranquero <lekktu@gmail.com>
9397
9398 * gnutls.c (init_gnutls_functions): Honor gnutls_log_level (bug#9059).
9399
0be0ce47
EZ
94002011-07-13 Eli Zaretskii <eliz@gnu.org>
9401
9402 * buffer.c (mmap_find): Fix a typo.
9403
cd18e7e3
JB
94042011-07-13 Johan Bockgård <bojohan@gnu.org>
9405
9406 Fix execution of x selection hooks.
9407 * xselect.c (Qx_lost_selection_functions)
9408 (Qx_sent_selection_functions): New vars.
9409 (syms_of_xselect): DEFSYM them.
9410 (x_handle_selection_request): Pass Qx_sent_selection_functions
9411 rather than Vx_sent_selection_functions to Frun_hook_with_args.
9412 (x_handle_selection_clear,x_clear_frame_selections):
9413 Pass Qx_lost_selection_functions rather than
9414 Vx_lost_selection_functions to Frun_hook_with_args.
9415
47ea7f44
PE
94162011-07-13 Paul Eggert <eggert@cs.ucla.edu>
9417
ac389d0c 9418 * buffer.c (Fget_buffer_create): Initialize inhibit_shrinking.
2941c447
PE
9419 The old code sometimes used this field without initializing it.
9420
47ea7f44
PE
9421 * alloc.c (gc_sweep): Don't read past end of array.
9422 In theory, the old code could also have corrupted Emacs internals,
9423 though it'd be very unlikely.
9424
bc985c87
AS
94252011-07-12 Andreas Schwab <schwab@linux-m68k.org>
9426
9427 * character.c (Fcharacterp): Don't advertise optional ignored
ac389d0c 9428 argument. (Bug#4026)
bc985c87 9429
0cf34688
LMI
94302011-07-12 Lars Magne Ingebrigtsen <larsi@gnus.org>
9431
b3dadd76
LMI
9432 * keymap.c (syms_of_keymap): Clarify that "modifier" is "modifier
9433 key" (bug#4257).
9434
0cf34688
LMI
9435 * window.c (Fset_window_start): Doc fix (bug#4199).
9436 (Fset_window_hscroll): Ditto.
9437
270768cd
PE
94382011-07-12 Paul Eggert <eggert@cs.ucla.edu>
9439
077e3dda 9440 Fix minor new problems caught by GCC 4.6.1.
270768cd 9441 * term.c (init_tty): Remove unused local.
490011a6 9442 * xsettings.c (store_monospaced_changed): Define this function only
077e3dda 9443 if (defined HAVE_GSETTINGS || defined HAVE_GCONF), as it's
490011a6 9444 not used otherwise.
270768cd 9445
b1f58454
CY
94462011-07-12 Chong Yidong <cyd@stupidchicken.com>
9447
9448 * xdisp.c (Vresize_mini_windows): Minor doc fix (Bug#3300).
9449
22b9578d
LMI
94502011-07-11 Lars Magne Ingebrigtsen <larsi@gnus.org>
9451
6e70ab07
LMI
9452 * xdisp.c (syms_of_xdisp): Make it explicit that the mini-windows
9453 are the mini-buffer and the echo area (bug#3320).
9454
22b9578d
LMI
9455 * term.c (init_tty): Remove support for supdup, c10 and perq
9456 terminals, which are no longer supported (bug#1482).
9457
8974cc9f
JB
94582011-07-10 Johan Bockgård <bojohan@gnu.org>
9459
9460 * xdisp.c (Ftool_bar_lines_needed): Fix WINDOWP check.
9461
a560d974
JD
94622011-07-10 Jan Djärv <jan.h.d@swipnet.se>
9463
9464 * xmenu.c (menu_highlight_callback): Only pass frame to show_help_event
9465 for non-popups (Bug#3642).
9466
1dae0f0a
AS
94672011-07-10 Andreas Schwab <schwab@linux-m68k.org>
9468
268c2c36 9469 * alloc.c (reset_malloc_hooks): Protoize.
1dae0f0a 9470 * buffer.c (mmap_init, mmap_find, mmap_free_1, mmap_enlarge)
268c2c36
AS
9471 (mmap_set_vars, mmap_alloc, mmap_free, mmap_realloc): Likewise.
9472 * cm.c (losecursor): Likewise.
1dae0f0a
AS
9473 * data.c (fmod): Likewise.
9474 * dispnew.c (swap_glyphs_in_rows): Likewise.
9475 * emacs.c (memory_warning_signal): Likewise.
9476 * floatfns.c (float_error): Likewise.
9477 * font.c (check_gstring, check_otf_features, otf_tag_symbol)
9478 (otf_open, font_otf_capability, generate_otf_features)
9479 (font_otf_DeviceTable, font_otf_ValueRecord, font_otf_Anchor):
9480 Likewise.
9481 * image.c (pbm_read_file): Likewise.
9482 * indent.c (string_display_width): Likewise.
9483 * intervals.c (check_for_interval, search_for_interval)
9484 (inc_interval_count, count_intervals, root_interval)
9485 (adjust_intervals_for_insertion, make_new_interval): Likewise.
9486 * lread.c (defalias): Likewise.
268c2c36 9487 * ralloc.c (r_alloc_check): Likewise.
1dae0f0a
AS
9488 * regex.c (set_image_of_range_1, set_image_of_range)
9489 (regex_grow_registers): Likewise.
9490 * sysdep.c (strerror): Likewise.
9491 * termcap.c (valid_filename_p, tprint, main): Likewise.
9492 * tparam.c (main): Likewise.
9493 * unexhp9k800.c (run_time_remap, save_data_space)
9494 (update_file_ptrs, read_header, write_header, calculate_checksum)
9495 (copy_file, copy_rest, display_header): Likewise.
9496 * widget.c (mark_shell_size_user_specified, create_frame_gcs):
9497 Likewise.
9498 * xdisp.c (check_it): Likewise.
9499 * xfaces.c (register_color, unregister_color, unregister_colors):
9500 Likewise.
9501 * xfns.c (print_fontset_result): Likewise.
9502 * xrdb.c (member, fatal, main): Likewise.
9503
99033785
PE
95042011-07-10 Paul Eggert <eggert@cs.ucla.edu>
9505
9506 Fix minor problems found by static checking (Bug#9031).
9507 * chartab.c (char_table_set_range, map_sub_char_table):
9508 Remove unused locals.
9509 (uniprop_table): Now static.
9510 * composite.c (_work_char): Remove unused static var.
9511
9cb2ac56
JB
95122011-07-09 Juanma Barranquero <lekktu@gmail.com>
9513
9514 * chartab.c (uniprop_table_uncompress): Remove unused local variable.
9515
f25661f0
JD
95162011-07-09 Jan Djärv <jan.h.d@swipnet.se>
9517
9518 * gtkutil.c (qttip_cb): Remove code without function.
9519
8278c4fe
EZ
95202011-07-09 Eli Zaretskii <eliz@gnu.org>
9521
9522 * w32.c (pthread_sigmask): New stub.
9523
1692ae2d 95242011-07-08 Paul Eggert <eggert@cs.ucla.edu>
123403e4 9525
8a6ebd58 9526 Use pthread_sigmask, not sigprocmask (Bug#9010).
123403e4
PE
9527 sigprocmask is portable only for single-threaded applications, and
9528 Emacs can be multi-threaded when it uses GTK.
1301ac26
PE
9529 * Makefile.in (LIB_PTHREAD_SIGMASK): New macro.
9530 (LIBES): Use it.
9531 * callproc.c (Fcall_process):
9532 * process.c (create_process):
9533 * sysdep.c (sys_sigblock, sys_sigunblock, sys_sigsetmask):
9534 Use pthread_sigmask, not sigprocmask.
123403e4 9535
1b854618
JD
95362011-07-08 Jan Djärv <jan.h.d@swipnet.se>
9537
9538 * gtkutil.c (qttip_cb): Set line wrap to FALSE for tooltip widget.
9539 (xg_prepare_tooltip): Revert text in x->ttip_lbl, margins was
9540 wrong (Bug#8591).
9541
3fe4b549
JD
95422011-07-08 Jan Djärv <jan.h.d@swipnet.se>
9543
0ce7e563
JD
9544 * gtkutil.c (xg_prepare_tooltip): Fix indentation and comment.
9545 Put text in x->ttip_lbl instead of gtk_tooltip_set_text (Bug#8591).
9546 (xg_hide_tooltip): Fix comment.
9547
3fe4b549
JD
9548 * nsterm.m (initFrameFromEmacs): Don't use ns_return_types
9549 in registerServicesMenuSendTypes.
9550 (validRequestorForSendType): Don't check ns_return_types.
9551
9552 * nsfns.m (Fx_open_connection): Put NSStringPboardType into
9553 ns_return_type.
9554
5df75e47
JR
95552011-07-08 Jason Rumney <jasonr@gnu.org>
9556
22610910
JR
9557 * w32term.c (x_make_frame_visible): Use SH_SHOWNORMAL rather than
9558 SH_SHOW for hidden windows (Bug#5482).
9559
5df75e47
JR
9560 * w32fns.c (w32_wnd_proc) [WM_TIMER, WM_SET_CURSOR]: Avoid using
9561 frame struct members of non-existent frames (Bug#6284).
9562
699c10bd
JD
95632011-07-08 Jan Djärv <jan.h.d@swipnet.se>
9564
4393663b
JD
9565 * nsterm.m (keyDown): Call to wantsToDelayTextChangeNotifications and
9566 variable firstTime not needed on OSX >= 10.6.
9567 (setPosition): setFloatValue:knobProportion: is deprecated on OSX
9568 >= 10.5. Use setKnobProportion, setDoubleValue.
9569
9570 * nsterm.h (MAC_OS_X_VERSION_10_3, MAC_OS_X_VERSION_10_4)
9571 (MAC_OS_X_VERSION_10_5): Define if not defined.
9572 (EmacsView, EmacsTooltip): Implements NSWindowDelegate on OSX >= 10.6.
9573 (EmacsMenu): Implements NSMenuDelegate on OSX >= 10.6.
9574 (EmacsToolbar): Implements NSToolbarDelegate on OSX >= 10.6.
9575
9576 * nsselect.m (ns_string_from_pasteboard): Don't use deprecated methods
090bd7cb 9577 cString and lossyCString on OSX >= 10.4.
4393663b 9578
58179cce 9579 * nsmenu.m (fillWithWidgetValue): Don't use deprecated method
4393663b
JD
9580 sizeToFit on OSX >= 10.2.
9581
9582 * nsimage.m (allocInitFromFile): Don't use deprecated method
9583 bestRepresentationForDevice on OSX >= 10.6.
9584
9585 * nsfns.m (check_ns_display_info): Cast to long and use %ld in error
9586 to avoid warning.
9587
9588 * emacs.c: Declare unexec_init_emacs_zone.
9589
a63e0781
JD
9590 * nsgui.h: Fix compiler warning about gnulib redefining verify.
9591
699c10bd
JD
9592 * nsselect.m (ns_get_local_selection): Change to extern (Bug#8842).
9593
9594 * nsmenu.m (ns_update_menubar): Remove useless setDelegate call
9595 on svcsMenu (Bug#8842).
9596
9597 * nsfns.m (Fx_open_connection): Remove NSStringPboardType from
9598 ns_return_types.
9599 (Fns_list_services): Just return Qnil on 10.6, code not working there.
9600
9601 * nsterm.m (QUTF8_STRING): Declare.
9602 (initFrameFromEmacs): Call registerServicesMenuSendTypes.
9603 (validRequestorForSendType): Return type is (id).
9604 Change indexOfObjectIdenticalTo to indexOfObject.
9605 Check if we have local selection before returning self (Bug#8842).
9606 (writeSelectionToPasteboard): Put local selection into paste board
9607 if we have a local selection (Bug#8842).
9608 (syms_of_nsterm): DEFSYM QUTF8_STRING.
9609
9610 * nsterm.h (MAC_OS_X_VERSION_10_6): Define here instead of nsterm.m.
9611 (ns_get_local_selection): Declare.
9612
54e10184
LMI
96132011-07-07 Lars Magne Ingebrigtsen <larsi@gnus.org>
9614
9888ff71
LMI
9615 * keymap.c (describe_map_tree): Don't insert a double newline at
9616 the end of the buffer (bug#1169) and return whether we inserted
9617 something.
9618
54e10184
LMI
9619 * callint.c (Fcall_interactively): Change "reading args" to
9620 "providing args" to try to clarify what it does (bug#1010).
9621
15fa4783
KH
96222011-07-07 Kenichi Handa <handa@m17n.org>
9623
9624 * composite.c (composition_compute_stop_pos): Ignore a static
9625 composition starting before CHARPOS (Bug#8915).
9626
9627 * xdisp.c (handle_composition_prop): Likewise.
9628
a8815b00
EZ
96292011-07-07 Eli Zaretskii <eliz@gnu.org>
9630
9631 * term.c (produce_glyphs) <xassert>: Allow IT_GLYPHLESS in it->what.
9632 (Bug#9015)
9633
ef7b981d 96342011-07-07 Kenichi Handa <handa@m17n.org>
c805dec0
KH
9635
9636 * character.h (unicode_category_t): New enum type.
9637
9638 * chartab.c (uniprop_decoder_t, uniprop_encoder_t): New types.
9639 (Qchar_code_property_table): New variable.
9640 (UNIPROP_TABLE_P, UNIPROP_GET_DECODER)
9641 (UNIPROP_COMPRESSED_FORM_P): New macros.
9642 (char_table_ascii): Uncompress the compressed values.
9643 (sub_char_table_ref): New arg is_uniprop. Callers changed.
9644 Uncompress the compressed values.
ac389d0c 9645 (sub_char_table_ref_and_range): Likewise.
c805dec0
KH
9646 (char_table_ref_and_range): Uncompress the compressed values.
9647 (sub_char_table_set): New arg is_uniprop. Callers changed.
9648 Uncompress the compressed values.
9649 (sub_char_table_set_range): Args changed. Callers changed.
9650 (char_table_set_range): Adjuted for the above change.
9651 (map_sub_char_table): Delete args default_val and parent. Add arg
9652 top. Give decoded values to a Lisp function.
640c8776 9653 (map_char_table): Adjust for the above change. Give decoded
c805dec0
KH
9654 values to a Lisp function. Gcpro more variables.
9655 (uniprop_table_uncompress)
9656 (uniprop_decode_value_run_length): New functions.
9657 (uniprop_decoder, uniprop_decoder_count): New variables.
9658 (uniprop_get_decoder, uniprop_encode_value_character)
9659 (uniprop_encode_value_run_length, uniprop_encode_value_numeric):
9660 New functions.
9661 (uniprop_encoder, uniprop_encoder_count): New variables.
9662 (uniprop_get_encoder, uniprop_table)
9663 (Funicode_property_table_internal, Fget_unicode_property_internal)
9664 (Fput_unicode_property_internal): New functions.
9665 (syms_of_chartab): DEFSYM Qchar_code_property_table, defsubr
9666 Sunicode_property_table_internal, Sget_unicode_property_internal,
5e617bc2 9667 and Sput_unicode_property_internal. Defvar_lisp
c805dec0
KH
9668 char-code-property-alist.
9669
640c8776 9670 * composite.c (CHAR_COMPOSABLE_P): Adjust for the change of
c805dec0
KH
9671 Vunicode_category_table.
9672
640c8776 9673 * font.c (font_range): Adjust for the change of
c805dec0
KH
9674 Vunicode_category_table.
9675
76b397fb
DN
96762011-07-07 Dan Nicolaescu <dann@ics.uci.edu>
9677
9678 * m/iris4d.h: Remove file, move contents ...
9679 * s/irix6-5.h: ... here.
9680
22b4128e
PE
96812011-07-06 Paul Eggert <eggert@cs.ucla.edu>
9682
9683 Remove unportable assumption about struct layout (Bug#8884).
8a5c77bb
PE
9684 * alloc.c (mark_buffer):
9685 * buffer.c (reset_buffer_local_variables, Fbuffer_local_variables)
9686 (clone_per_buffer_values): Don't assume that
22b4128e
PE
9687 sizeof (struct buffer) is a multiple of sizeof (Lisp_Object).
9688 This isn't true in general, and it's particularly not true
9689 if Emacs is configured with --with-wide-int.
9690 * buffer.h (FIRST_FIELD_PER_BUFFER, LAST_FIELD_PER_BUFFER):
9691 New macros, used in the buffer.c change.
9692
869795d6
JD
96932011-07-05 Jan Djärv <jan.h.d@swipnet.se>
9694
9695 * xsettings.c: Use both GConf and GSettings if both are available.
9696 (store_config_changed_event): Add comment.
9697 (dpyinfo_valid, store_font_name_changed, map_tool_bar_style)
9698 (store_tool_bar_style_changed): New functions.
5e617bc2 9699 (store_monospaced_changed): Add comment. Call dpyinfo_valid.
869795d6
JD
9700 (struct xsettings): Move font inside HAVE_XFT.
9701 (GSETTINGS_TOOL_BAR_STYLE, GSETTINGS_FONT_NAME): New defines.
640c8776 9702 (GSETTINGS_MONO_FONT): Rename from SYSTEM_MONO_FONT.
869795d6 9703 Move inside HAVE_XFT.
640c8776 9704 (something_changed_gsettingsCB): Rename from something_changedCB.
869795d6
JD
9705 Check for changes in GSETTINGS_TOOL_BAR_STYLE and GSETTINGS_FONT_NAME
9706 also.
9707 (GCONF_TOOL_BAR_STYLE, GCONF_FONT_NAME): New defines.
5e617bc2 9708 (GCONF_MONO_FONT): Rename from SYSTEM_MONO_FONT. Move inside HAVE_XFT.
640c8776 9709 (something_changed_gconfCB): Rename from something_changedCB.
869795d6
JD
9710 Check for changes in GCONF_TOOL_BAR_STYLE and GCONF_FONT_NAME also.
9711 (parse_settings): Move check for font inside HAVE_XFT.
9712 (read_settings, apply_xft_settings): Add comment.
9713 (read_and_apply_settings): Add comment. Call map_tool_bar_style and
9714 store_tool_bar_style_changed. Move check for font inside HAVE_XFT and
9715 call store_font_name_changed.
9716 (xft_settings_event): Add comment.
9717 (init_gsettings): Add comment. Get values for GSETTINGS_TOOL_BAR_STYLE
9718 and GSETTINGS_FONT_NAME. Move check for fonts within HAVE_XFT.
9719 (init_gconf): Add comment. Get values for GCONF_TOOL_BAR_STYLE
9720 and GCONF_FONT_NAME. Move check for fonts within HAVE_XFT.
9721 (xsettings_initialize): Call init_gsettings last.
640c8776
SM
9722 (xsettings_get_system_font, xsettings_get_system_normal_font):
9723 Add comment.
869795d6 9724
d8ed26bd
PE
97252011-07-05 Paul Eggert <eggert@cs.ucla.edu>
9726
9727 Random fixes. E.g., (random) never returned negative values.
9728 * fns.c (Frandom): Use GET_EMACS_TIME for random seed, and add the
9729 subseconds part to the entropy, as that's a bit more random.
9730 Prefer signed to unsigned, since the signedness doesn't matter and
9731 in general we prefer signed. When given a limit, use a
9732 denominator equal to INTMASK + 1, not to VALMASK + 1, because the
9733 latter isn't right if USE_2_TAGS_FOR_INTS.
9734 * sysdep.c (get_random): Return a value in the range 0..INTMASK,
9735 not 0..VALMASK. Don't discard "excess" bits that random () returns.
9736
cabf1cac
SM
97372011-07-04 Stefan Monnier <monnier@iro.umontreal.ca>
9738
9739 * textprop.c (text_property_stickiness):
9740 Obey Vtext_property_default_nonsticky.
9741 (syms_of_textprop): Add `display' to Vtext_property_default_nonsticky.
9742 * w32fns.c (syms_of_w32fns):
9743 * xfns.c (syms_of_xfns): Don't Add `display' since it's there by default.
9744
6e9b2be9
PE
97452011-07-04 Paul Eggert <eggert@cs.ucla.edu>
9746
9747 * fileio.c (barf_or_query_if_file_exists): Use S_ISDIR.
9748 This is more efficient than Ffile_directory_p and avoids a minor race.
9749
90186c68
LMI
97502011-07-04 Lars Magne Ingebrigtsen <larsi@gnus.org>
9751
7c301272
LMI
9752 * buffer.c (Foverlay_put): Say what the return value is
9753 (bug#7835).
9754
c4f2d8d4
LMI
9755 * fileio.c (barf_or_query_if_file_exists): Check first if the file
9756 is a directory before asking whether to use the file name
9757 (bug#7564).
ad637907
LMI
9758 (barf_or_query_if_file_exists): Make the "File is a directory"
9759 error be more correct.
c4f2d8d4 9760
90186c68
LMI
9761 * fns.c (Frequire): Remove the mention of the .gz files, since
9762 that's installation-specific, but keep the mention of
9763 `get-load-suffixes'.
9764
da64016e
PE
97652011-07-04 Paul Eggert <eggert@cs.ucla.edu>
9766
9767 * editfns.c (Fformat_time_string): Don't assume strlen fits in int.
9768 Report string overflow if the output is too long.
9769
7d47b580
JB
97702011-07-04 Juanma Barranquero <lekktu@gmail.com>
9771
a555cb87
JB
9772 * gnutls.c (Fgnutls_boot): Don't mention :verify-error.
9773 (syms_of_gnutls): Remove duplicate DEFSYM for
9774 Qgnutls_bootprop_verify_hostname_error, an error for
9775 Qgnutls_bootprop_verify_error (which is no longer used).
9776
7d47b580
JB
9777 * eval.c (find_handler_clause): Remove parameters `sig' and `data',
9778 unused since 2011-01-26T20:02:07Z!monnier@iro.umontreal.ca. All callers changed.
9779 Also (re)move comments that are misplaced or no longer relevant.
9780
1e49bfab
LMI
97812011-07-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
9782
9783 * callint.c (Finteractive): Clarify the meaning of "@" (bug#8813).
9784
1485f4c0
CY
97852011-07-03 Chong Yidong <cyd@stupidchicken.com>
9786
9787 * xfaces.c (Finternal_merge_in_global_face): Modify the foreground
9788 and background color parameters if they have been changed.
9789
a9ab721e
LMI
97902011-07-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
9791
9792 * editfns.c (Fformat): Clarify the - and 0 flags (bug#6659).
9793
cf7cff57
PE
97942011-07-03 Paul Eggert <eggert@cs.ucla.edu>
9795
2e13213d
PE
9796 * xsettings.c (SYSTEM_FONT): Define only when used.
9797 No need to define when HAVE_GSETTINGS || !HAVE_XFT.
9798
cf7cff57
PE
9799 * keymap.c (access_keymap_1): Now static.
9800
7a8e04f7
CY
98012011-07-02 Chong Yidong <cyd@stupidchicken.com>
9802
9803 * keyboard.c (command_loop_1): If a down-mouse event is unbound,
9804 leave any prefix arg for the up event (Bug#1586).
9805
61352f62
LMI
98062011-07-02 Lars Magne Ingebrigtsen <larsi@gnus.org>
9807
69bb1ef7
LMI
9808 * lread.c (syms_of_lread): Mention single symbols defined by
9809 `defvar' or `defconst' (bug#7154).
9810
61352f62 9811 * fns.c (Frequire): Mention .el.gz files (bug#7314).
7b3747f9 9812 (Frequire): Mention get-load-suffixes.
61352f62 9813
28545e04
MR
98142011-07-02 Martin Rudalics <rudalics@gmx.at>
9815
9816 * window.h (window): Remove clone_number slot.
9817 * window.c (Fwindow_clone_number, Fset_window_clone_number):
9818 Remove.
9819 (make_parent_window, make_window, saved_window)
9820 (Fset_window_configuration, save_window_save): Don't deal with
9821 clone numbers.
9822 * buffer.c (Qclone_number): Remove declaration.
9823 (sort_overlays, overlay_strings): Don't deal with clone numbers.
9824
3349e122
SM
98252011-07-02 Stefan Monnier <monnier@iro.umontreal.ca>
9826
9827 Add multiple inheritance to keymaps.
9828 * keymap.c (Fmake_composed_keymap): New function.
9829 (Fset_keymap_parent): Simplify.
9830 (fix_submap_inheritance): Remove.
9831 (access_keymap_1): New function extracted from access_keymap to handle
9832 embedded parents and handle lists of maps.
9833 (access_keymap): Use it.
9834 (Fkeymap_prompt, map_keymap_internal, map_keymap, store_in_keymap)
9835 (Fcopy_keymap): Handle embedded parents.
9836 (Fcommand_remapping, define_as_prefix): Simplify.
9837 (Fkey_binding): Simplify.
9838 (syms_of_keymap): Move minibuffer-local-completion-map,
9839 minibuffer-local-filename-completion-map,
9840 minibuffer-local-must-match-map, and
9841 minibuffer-local-filename-must-match-map to Elisp.
9842 (syms_of_keymap): Defsubr make-composed-keymap.
9843 * keyboard.c (menu_bar_items): Use map_keymap_canonical.
9844 (parse_menu_item): Trivial simplification.
9845
3279eb87
GM
98462011-07-01 Glenn Morris <rgm@gnu.org>
9847
9848 * Makefile.in (SETTINGS_LIBS): Fix typo.
9849
4550efdf
KI
98502011-07-01 Kazuhiro Ito <kzhr@d1.dion.ne.jp> (tiny patch)
9851
9852 * coding.c (Fencode_coding_string): Record the last coding system
9853 used, as the function doc string says (bug#8738).
9854
0949d2b6
JD
98552011-07-01 Jan Djärv <jan.h.d@swipnet.se>
9856
9857 * xsettings.c (store_monospaced_changed): Take new font as arg and
9858 check for change against current_mono_font.
9859 (EMACS_TYPE_SETTINGS): Remove this and related defines.
9860 (emacs_settings_constructor, emacs_settings_get_property)
9861 (emacs_settings_set_property, emacs_settings_class_init)
9862 (emacs_settings_init, gsettings_obj): Remove.
9863 (something_changedCB): New function for HAVE_GSETTINGS.
9864 (something_changedCB): HAVE_GCONF: Call store_monospaced_changed
9865 with value as argument.
9866 (init_gsettings): Check that GSETTINGS_SCHEMA exists before calling
9867 g_settings_new (Bug#8967). Do not create gsettings_obj.
9173deec 9868 Remove calls to g_settings_bind. Connect something_changedCB to
0949d2b6
JD
9869 "changed".
9870
9871 * xgselect.c: Add defined (HAVE_GSETTINGS).
9872 (xgselect_initialize): Ditto.
9873
9874 * process.c: Add defined (HAVE_GSETTINGS) for xgselect.h
9875 (wait_reading_process_output): Add defined (HAVE_GSETTINGS) for
9876 xg_select.
9877
bbc6b304
PE
98782011-07-01 Paul Eggert <eggert@cs.ucla.edu>
9879
9880 * eval.c (struct backtrace): Simplify and port the data structure.
9881 Do not assume that "int nargs : BITS_PER_INT - 2;" produces a
9882 signed bit field, as this assumption is not portable and it makes
9883 Emacs crash when compiled with Sun C 5.8 on sparc. Do not use
9884 "char debug_on_exit : 1" as this is not portable either; instead,
9885 use the portable "unsigned int debug_on_exit : 1". Remove unused
9886 member evalargs. Remove obsolete comments about cc bombing out.
9887
9851bfc5
JD
98882011-06-30 Jan Djärv <jan.h.d@swipnet.se>
9889
51bb811f 9890 * xsettings.c: Include glib-object.h, gio/gio.h if HAVE_GSETTINGS.
9851bfc5
JD
9891 Let HAVE_GSETTINGS override HAVE_GCONF.
9892 (store_monospaced_changed): New function.
9893 (EMACS_SETTINGS): A new type derived from GObject to handle
9894 GSettings notifications.
9895 (emacs_settings_constructor, emacs_settings_get_property)
9896 (emacs_settings_set_property, emacs_settings_class_init):
9897 New functions.
9898 (gsettings_client, gsettings_obj): New variables.
9899 (GSETTINGS_SCHEMA): New define.
9900 (something_changedCB): Call store_monospaced_changed.
9901 (init_gsettings): New function.
9902 (xsettings_initialize): Call init_gsettings.
9903 (syms_of_xsettings): Initialize gsettings_client, gsettings_obj
9904 to NULL.
9905
640c8776 9906 * Makefile.in (SETTINGS_CFLAGS, SETTINGS_LIBS): Rename from
9851bfc5
JD
9907 GCONF_CFLAGS/LIBS.
9908
5386012d
MR
99092011-06-29 Martin Rudalics <rudalics@gmx.at>
9910
9911 * window.c (resize_root_window, grow_mini_window)
9912 (shrink_mini_window): Rename Qresize_root_window to
9913 Qwindow_resize_root_window and Qresize_root_window_vertically to
9914 Qwindow_resize_root_window_vertically.
9915
f13e0b08
PE
99162011-06-28 Paul Eggert <eggert@cs.ucla.edu>
9917
9918 * gnutls.c (Qgnutls_bootprop_verify_error): Remove unused var.
9919
94515237
JB
99202011-06-27 Juanma Barranquero <lekktu@gmail.com>
9921
9922 * makefile.w32-in: Redesign dependencies so they reflect more
9923 clearly which files are directly included by each source file,
9924 and not through other includes.
9925
e43b6e43
MR
99262011-06-27 Martin Rudalics <rudalics@gmx.at>
9927
9928 * buffer.c (Qclone_number): Declare static and DEFSYM it.
9929 (sort_overlays, overlay_strings): When an overlay's clone number
9930 matches the window's clone number process the overlay even if
9931 the overlay's window property doesn't match the current window.
9932
d68443dc
MR
9933 * window.c (Fwindow_vchild): Rename to Fwindow_top_child.
9934 (Fwindow_hchild): Rename to Fwindow_left_child.
9935 (Fwindow_next): Rename to Fwindow_next_sibling.
9936 (Fwindow_prev): Rename to Fwindow_prev_sibling.
d615d6d2
MR
9937 (resize_window_check): Rename to window_resize_check.
9938 (resize_window_apply): Rename to window_resize_apply.
9939 (Fresize_window_apply): Rename to Fwindow_resize_apply.
9940 (Fdelete_other_windows_internal, resize_frame_windows)
9941 (Fsplit_window_internal, Fdelete_window_internal)
9942 (grow_mini_window, shrink_mini_window)
9943 (Fresize_mini_window_internal): Fix callers accordingly.
d68443dc 9944
c7e73be5
JD
99452011-06-26 Jan Djärv <jan.h.d@swipnet.se>
9946
9947 * emacsgtkfixed.h: State that this is only used with Gtk+3.
9948 (emacs_fixed_set_min_size): Remove.
9949 (emacs_fixed_new): Take frame as argument.
9950
9951 * emacsgtkfixed.c: State that this is only used with Gtk+3.
9952 (_EmacsFixedPrivate): Remove minwidth/height.
9953 Add struct frame *f.
9954 (emacs_fixed_init): Initialize priv->f.
9955 (get_parent_class, emacs_fixed_set_min_size): Remove.
9956 (emacs_fixed_new): Set priv->f to argument.
9957 (emacs_fixed_get_preferred_width)
9958 (emacs_fixed_get_preferred_height): Use min_width/height from
9959 frames size_hint to set minimum and natural (Bug#8919).
9960 (XSetWMSizeHints, XSetWMNormalHints): Override these functions
9961 and use min_width/height from frames size_hint to set
9962 min_width/height (Bug#8919).
9963
9964 * gtkutil.c (xg_create_frame_widgets): Pass f to emacs_fixed_new.
9173deec
JB
9965 (x_wm_set_size_hint): Remove call to emacs_fixed_set_min_size.
9966 Fix indentation.
c7e73be5 9967
cf99dcf8
EZ
99682011-06-26 Eli Zaretskii <eliz@gnu.org>
9969
9970 * bidi.c (bidi_paragraph_init): Test for ZV_BYTE before calling
9971 bidi_at_paragraph_end, since fast_looking_at doesn't like to be
9972 called at ZV.
9973
029529ac
CY
99742011-06-26 Chong Yidong <cyd@stupidchicken.com>
9975
9976 * process.c (wait_reading_process_output): Bypass select if
9977 waiting for a cell while ignoring keyboard input, and input is
9978 pending. Suggested by Jan Djärv (Bug#8869).
9979
7a7ef429
PE
99802011-06-25 Paul Eggert <eggert@cs.ucla.edu>
9981
9982 Use gnulib's dup2 module instead of rolling our own.
9983 * sysdep.c (dup2) [!HAVE_DUP2]: Remove; gnulib now does this.
9984
11fdef7d 99852011-06-25 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
989b42d2
YM
9986
9987 * dispnew.c (scrolling_window): Before scrolling, turn off a
9988 mouse-highlight in the window being scrolled.
9989
cd3520a4
JB
99902011-06-24 Juanma Barranquero <lekktu@gmail.com>
9991
9992 Move DEFSYM to lisp.h and use everywhere.
9993
9994 * character.h (DEFSYM): Move declaration...
9995 * lisp.h (DEFSYM): ...here.
9996
9997 * gnutls.c:
9998 * minibuf.c:
9999 * w32menu.c:
10000 * w32proc.c:
10001 * w32select.c: Don't include character.h.
10002
10003 * alloc.c (syms_of_alloc):
10004 * buffer.c (syms_of_buffer):
10005 * bytecode.c (syms_of_bytecode):
10006 * callint.c (syms_of_callint):
10007 * casefiddle.c (syms_of_casefiddle):
10008 * casetab.c (init_casetab_once):
10009 * category.c (init_category_once, syms_of_category):
10010 * ccl.c (syms_of_ccl):
10011 * cmds.c (syms_of_cmds):
10012 * composite.c (syms_of_composite):
10013 * dbusbind.c (syms_of_dbusbind):
10014 * dired.c (syms_of_dired):
10015 * dispnew.c (syms_of_display):
10016 * doc.c (syms_of_doc):
10017 * editfns.c (syms_of_editfns):
10018 * emacs.c (syms_of_emacs):
10019 * eval.c (syms_of_eval):
10020 * fileio.c (syms_of_fileio):
10021 * fns.c (syms_of_fns):
10022 * frame.c (syms_of_frame):
10023 * fringe.c (syms_of_fringe):
10024 * insdel.c (syms_of_insdel):
10025 * keymap.c (syms_of_keymap):
10026 * lread.c (init_obarray, syms_of_lread):
10027 * macros.c (syms_of_macros):
10028 * msdos.c (syms_of_msdos):
10029 * print.c (syms_of_print):
10030 * process.c (syms_of_process):
10031 * search.c (syms_of_search):
10032 * sound.c (syms_of_sound):
10033 * syntax.c (init_syntax_once, syms_of_syntax):
10034 * terminal.c (syms_of_terminal):
10035 * textprop.c (syms_of_textprop):
10036 * undo.c (syms_of_undo):
10037 * w32.c (globals_of_w32):
10038 * window.c (syms_of_window):
10039 * xdisp.c (syms_of_xdisp):
10040 * xfaces.c (syms_of_xfaces):
10041 * xfns.c (syms_of_xfns):
10042 * xmenu.c (syms_of_xmenu):
10043 * xsettings.c (syms_of_xsettings):
10044 * xterm.c (syms_of_xterm): Use DEFSYM.
10045
4228cf16
TZ
100462011-06-24 Teodor Zlatanov <tzz@lifelogs.com>
10047
cd3520a4 10048 * gnutls.c (syms_of_gnutls): Use the DEFSYM macro from character.h.
4228cf16 10049
7fcccf1e
PE
100502011-06-23 Paul Eggert <eggert@cs.ucla.edu>
10051
7efb4e0e
PE
10052 Integer and buffer overflow fixes (Bug#8873).
10053
ff5844ad
PE
10054 * print.c (printchar, strout): Check for string overflow.
10055 (PRINTPREPARE, printchar, strout):
10056 Don't set size unless allocation succeeds.
10057
90532f02
PE
10058 * minibuf.c (read_minibuf_noninteractive): Use ptrdiff_t, not int,
10059 for sizes. Check for string overflow more accurately.
10060 Simplify newline removal at end; this suppresses a GCC 4.6.0 warning.
10061
6d84508d
PE
10062 * macros.c: Integer and buffer overflow fixes.
10063 * keyboard.h (struct keyboard.kbd_macro_bufsize):
10064 * macros.c (Fstart_kbd_macro, store_kbd_macro_char):
10065 Use ptrdiff_t, not int, for sizes.
10066 Don't increment bufsize until after realloc succeeds.
10067 Check for size-calculation overflow.
10068 (Fstart_kbd_macro): Use EMACS_INT, not int, for XINT result.
10069
437b2cb4
PE
10070 * lisp.h (DEFVAR_KBOARD): Use offsetof instead of char * finagling.
10071
8b9ac8b4
PE
10072 * lread.c: Integer overflow fixes.
10073 (read_integer): Radix is now EMACS_INT, not int,
10074 to improve quality of diagnostics for out-of-range radices.
10075 Calculate buffer size correctly for out-of-range radices.
10076 (read1): Check for integer overflow in radices, and in
10077 read-circle numbers.
82cb60d3
PE
10078 (read_escape): Avoid int overflow.
10079 (Fload, openp, read_buffer_size, read1)
10080 (substitute_object_recurse, read_vector, read_list, map_obarray):
10081 Use ptrdiff_t, not int, for sizes.
10082 (read1): Use EMACS_INT, not int, for sizes.
20270765 10083 Check for size overflow.
8b9ac8b4 10084
7fcccf1e
PE
10085 * image.c (cache_image): Check for size arithmetic overflow.
10086
bfbbd7e7
PE
10087 * lread.c: Integer overflow issues.
10088 (saved_doc_string_size, saved_doc_string_length)
10089 (prev_saved_doc_string_size, prev_saved_doc_string_length):
10090 Now ptrdiff_t, not int.
10091 (read1): Don't assume doc string length fits in int. Check for
10092 out-of-range doc string lengths.
10093 (read_list): Don't assume file position fits in int.
39019e54 10094 (read_escape): Check for hex character overflow.
bfbbd7e7 10095
4e323265
LL
100962011-06-22 Leo Liu <sdl.web@gmail.com>
10097
10098 * minibuf.c (Fcompleting_read_default, Vcompleting_read_function):
10099 Move to minibuffer.el.
10100
85fece3e
PE
101012011-06-22 Paul Eggert <eggert@cs.ucla.edu>
10102
20b84ce9 10103 Fixes for GLYPH_DEBUG found by GCC 4.6.0 static checking.
85fece3e
PE
10104 The following patches are for when GLYPH_DEBUG && !XASSERT.
10105 * dispextern.h (trace_redisplay_p, dump_glyph_string):
10106 * dispnew.c (flush_stdout):
10107 * xdisp.c (dump_glyph_row, dump_glyph_matrix, dump_glyph):
10108 Mark as externally visible.
10109 * dispnew.c (check_window_matrix_pointers): Now static.
10110 * dispnew.c (window_to_frame_vpos):
10111 * xfns.c (unwind_create_frame):
10112 * xterm.c (x_check_font): Remove unused local.
10113 * scroll.c (CHECK_BOUNDS):
10114 * xfaces.c (cache_fache): Rename local to avoid shadowing.
10115 * xfns.c, w32fns.c (image_cache_refcount, dpyinfo_refcount): Now static.
10116 * xdisp.c (check_window_end): Now a no-op if !XASSERTS.
10117 (debug_first_unchanged_at_end_vpos, debug_last_unchanged_at_beg_vpos)
10118 (debug_dvpos, debug_dy, debug_delta, debug_delta_bytes, debug_end_vpos):
10119 Now static.
10120 (debug_method_add): Use va_list and vsprintf rather than relying
10121 on undefined behavior with wrong number of arguments.
10122 (dump_glyph, dump_glyph_row, Fdump_glyph_matrix):
10123 Don't assume ptrdiff_t and EMACS_INT are the same width as int.
10124 In this code, it's OK to assume C99 behavior for ptrdiff_t formats
10125 since we're not interested in debugging glyphs with old libraries.
10126 * xfaces.c (cache_face): Move debugging code earlier; this pacifies
10127 GCC 4.6.0's static checking.
10128
0766b489
PE
101292011-06-22 Paul Eggert <eggert@cs.ucla.edu>
10130
31fd4b32
PE
10131 Integer overflow and signedness fixes (Bug#8873).
10132 A few related buffer overrun fixes, too.
10133
b79e8648
PE
10134 * font.c (font_score): Use EMACS_INT, not int, to store XINT value.
10135
0766b489
PE
10136 * dispextern.h (struct face.stipple):
10137 * image.c (x_bitmap_height, x_bitmap_width, x_bitmap_pixmap)
10138 (x_bitmap_mask, x_allocate_bitmap_record)
10139 (x_create_bitmap_from_data, x_create_bitmap_from_file)
10140 (x_destroy_bitmap, x_destroy_all_bitmaps, x_create_bitmap_mask)
10141 (x_create_bitmap_from_xpm_data):
10142 * nsterm.h (struct ns_display_info.bitmaps_size, .bitmaps_last):
10143 * w32term.h (struct w32_display_info.icon_bitmap_id, .bitmaps_size)
10144 (.bitmaps_last):
10145 * xfaces.c (load_pixmap):
10146 * xterm.c (x_bitmap_icon, x_wm_set_icon_pixmap):
10147 * xterm.h (struct x_display_info.icon_bitmap_id, .bitmaps_size)
10148 (.bitmaps_last, struct x_output.icon_bitmap):
10149 Use ptrdiff_t, not int, for bitmap indexes.
10150 (x_allocate_bitmap_record): Check for size overflow.
10151 * dispextern.h, lisp.h: Adjust to API changes elsewhere.
10152
b081724f
PE
10153 Use ptrdiff_t, not int, for overlay counts.
10154 * buffer.h (overlays_at, sort_overlays, GET_OVERLAYS_AT):
10155 * editfns.c (overlays_around, get_pos_property):
10156 * textprop.c (get_char_property_and_overlay):
10157 * xdisp.c (next_overlay_change, note_mouse_highlight):
10158 * xfaces.c (face_at_buffer_position):
21514da7
PE
10159 * buffer.c (OVERLAY_COUNT_MAX): New macro.
10160 (overlays_at, overlays_in, sort_overlays, Foverlays_at)
10161 (Fnext_overlay_change, Fprevious_overlay_change)
10162 (mouse_face_overlay_overlaps, Foverlays_in):
b081724f 10163 Use ptrdiff_t, not int, for sizes.
21514da7 10164 (overlays_at, overlays_in): Check for size-calculation overflow.
b081724f 10165
3de73e5e
PE
10166 * xterm.c (xim_initialize, same_x_server): Strlen may not fit in int.
10167
2606c57b
PE
10168 * xsmfns.c (smc_save_yourself_CB, x_session_initialize): Avoid strlen.
10169 (x_session_initialize): Do not assume string length fits in int.
10170
aaafe47a
PE
10171 * xsettings.c (apply_xft_settings): Fix potential buffer overrun.
10172 This is unlikely, but can occur if DPI is outlandish.
10173
2674ddc8 10174 * xsettings.c (Ffont_get_system_normal_font, Ffont_get_system_font):
3a5077c5
PE
10175 * xselect.c (Fx_get_atom_name): Avoid need for strlen.
10176
28154962
PE
10177 * xrdb.c: Don't assume strlen fits in int; avoid some strlens.
10178 * xrdb.c (magic_file_p, search_magic_path):
10179 Omit last arg SUFFIX; it was always 0. All callers changed.
10180 (magic_file_p): Use ptrdiff_t, not int. Check for size overflow.
10181
7de51af5
PE
10182 * xfont.c (xfont_match): Avoid need for strlen.
10183
25ed6cc3
PE
10184 * xfns.c: Don't assume strlen fits in int.
10185 (xic_create_fontsetname, x_window): Use ptrdiff_t, not int.
10186
4eab31dd
PE
10187 * xdisp.c (message_log_check_duplicate): Return intmax_t,
10188 not unsigned long, as we prefer signed integers. All callers changed.
10189 Detect integer overflow in repeat count.
10190 (message_dolog): Don't assume print length fits in 39 bytes.
df1f27af 10191 (display_mode_element): Don't assume strlen fits in int.
4eab31dd 10192
171e2a58
PE
10193 * termcap.c: Don't assume sizes fit in int and never overflow.
10194 (struct termcap_buffer, tgetent): Use ptrdiff_t, not int, for sizes.
10195 (gobble_line): Check for size-calculation overflow.
10196
ad39faca 10197 * minibuf.c (Fread_buffer):
6e5bb2dc 10198 * lread.c (intern, intern_c_string):
74ca2eb3
PE
10199 * image.c (xpm_scan) [HAVE_NS && !HAVE_XPM]:
10200 Don't assume string length fits in int.
10201
52c61c22 10202 * keyboard.c (parse_tool_bar_item):
9bda3520
PE
10203 * gtkutil.c (style_changed_cb): Avoid need for strlen.
10204
b5b8c9e5
PE
10205 * font.c: Don't assume string length fits in int.
10206 (font_parse_xlfd, font_parse_fcname, font_unparse_fcname):
10207 Use ptrdiff_t, not int.
ccd6111c
PE
10208 (font_intern_prop): Don't assume string length fits in int.
10209 Don't assume integer property fits in fixnum.
10210 * font.h (font_intern_prop): 2nd arg is now ptrdiff_t, not int.
b5b8c9e5 10211
882f0d81 10212 * filelock.c: Fix some buffer overrun and integer overflow issues.
51cab52b 10213 (get_boot_time): Don't assume gzip command string fits in 100 bytes.
882f0d81
PE
10214 Reformulate so as not to need the command string.
10215 Invoke gzip -cd rather than gunzip, as it's more portable.
10216 (lock_info_type, lock_file_1, lock_file):
10217 Don't assume pid_t and time_t fit in unsigned long.
10218 (LOCK_PID_MAX): Remove; we now use more-reliable bounds.
10219 (current_lock_owner): Prefer signed type for sizes.
10220 Use memcpy, not strncpy, where memcpy is what is really wanted.
10221 Don't assume (via atoi) that time_t and pid_t fit in int.
10222 Check for time_t and/or pid_t out of range, e.g., via a network share.
10223 Don't alloca where an auto var works fine.
10224
93f4cf88
PE
10225 * fileio.c: Fix some integer overflow issues.
10226 (file_name_as_directory, Fexpand_file_name, Fsubstitute_in_file_name):
10227 Don't assume string length fits in int.
10228 (directory_file_name): Don't assume string length fits in long.
10229 (make_temp_name): Don't assume pid fits in int, or that its print
10230 length is less than 20.
10231
f3e92b69
PE
10232 * data.c (Fsubr_name): Rewrite to avoid a strlen call.
10233
1bfdaf10
PE
10234 * coding.c (make_subsidiaries): Don't assume string length fits in int.
10235
35016e9a
PE
10236 * callproc.c (child_setup): Rewrite to avoid two strlen calls.
10237
3d1e65a1
PE
10238 * process.c (Fformat_network_address): Use EMACS_INT, not EMACS_UINT.
10239 We prefer signed integers, even for size calculations.
10240
0b963a93
PE
10241 * emacs.c: Don't assume string length fits in 'int'.
10242 (DEFINE_DUMMY_FUNCTION, sort_args): Use ptrdiff_t, not int.
10243 (main): Don't invoke strlen when not needed.
10244
573f4b54
PE
10245 * dbusbind.c (XD_ERROR): Don't arbitrarily truncate string.
10246 (XD_DEBUG_MESSAGE): Don't waste a byte.
10247
989f33ba
PE
10248 * callproc.c (getenv_internal_1, getenv_internal)
10249 (Fgetenv_internal):
965d34eb
PE
10250 * buffer.c (init_buffer): Don't assume string length fits in 'int'.
10251
e4d29b33
PE
10252 * lread.c (invalid_syntax): Omit length argument.
10253 All uses changed. This doesn't fix a bug, but it simplifies the
10254 code away from its former Hollerith-constant appearance, and it's
10255 one less 'int' to worry about when looking at integer-overflow issues.
51cab52b 10256 (string_to_number): Simplify 2011-04-26 change by invoking xsignal1.
e4d29b33 10257
eb49b136
PE
10258 * lisp.h (DEFUN): Remove bogus use of sizeof (struct Lisp_Subr).
10259 This didn't break anything, but it didn't help either.
10260 It's confusing to put a bogus integer in a place where the actual
10261 value does not matter.
9f62aeb1 10262 (LIST_END_P): Remove unused macro and its bogus comment.
cbeff735 10263 (make_fixnum_or_float): Remove unnecessary cast to EMACS_INT.
eb49b136 10264
15375a22
PE
10265 * lisp.h (union Lisp_Object.i): EMACS_INT, not EMACS_UINT.
10266 This is for consistency with the ordinary, non-USE_LISP_UNION_TYPE,
10267 implementation.
b61cc01c
PE
10268 (struct Lisp_Bool_Vector.size): EMACS_INT, not EMACS_UINT.
10269 We prefer signed types, and the value cannot exceed the EMACS_INT
10270 range anyway (because otherwise the length would not be representable).
9a8e8d9b
PE
10271 (XSET) [USE_LISP_UNION_TYPE]: Use uintptr_t and intptr_t,
10272 not EMACS_UINT and EMACS_INT, when converting pointer to integer.
10273 This avoids a GCC warning when WIDE_EMACS_INT.
15375a22 10274
53b2623d
PE
10275 * indent.c (sane_tab_width): New function.
10276 (current_column, scan_for_column, Findent_to, position_indentation)
10277 (compute_motion): Use it. This is just for clarity.
8fcaf9cc 10278 (Fcompute_motion): Don't assume hscroll and tab offset fit in int.
53b2623d 10279
51cab52b 10280 * image.c (xbm_image_p): Don't assume stated width, height fit in int.
45aebb64 10281
f2ed8a70
PE
10282 * lisp.h (lint_assume): New macro.
10283 * composite.c (composition_gstring_put_cache):
10284 * ftfont.c (ftfont_shape_by_flt): Use it to pacify GCC 4.6.0.
10285
abe80cc6
PE
10286 * editfns.c, insdel.c:
10287 Omit unnecessary forward decls, to simplify future changes.
a9e860e1 10288
b02c740e
PE
10289 * ftfont.c (ftfont_shape_by_flt): Use signed integers for lengths.
10290
ebc96716
PE
10291 * font.c (Ffont_shape_gstring): Don't assume glyph len fits in 'int'.
10292
b4e50fa0 10293 * fns.c (Ffillarray): Don't assume bool vector size fits in 'int'.
f03dc6ef 10294 Use much-faster test for byte-length change.
311d5d7c 10295 Don't assume string byte-length fits in 'int'.
a4cf38e4 10296 Check that character arg fits in 'int'.
85461888 10297 (mapcar1): Declare byte as byte, for clarity.
b4e50fa0 10298
c0c1ee9f
PE
10299 * alloc.c (Fmake_bool_vector): Avoid unnecessary multiplication.
10300
a498d7f4
PE
10301 * fns.c (concat): Catch string overflow earlier.
10302 Do not rely on integer wraparound.
10303
51cab52b
PE
10304 * dispextern.h (struct it.overlay_strings_charpos)
10305 (struct it.selective): Now EMACS_INT, not int.
87830974
PE
10306 * xdisp.c (forward_to_next_line_start)
10307 (back_to_previous_visible_line_start)
10308 (reseat_at_next_visible_line_start, next_element_from_buffer):
10309 Don't arbitrarily truncate the value of 'selective' to int.
10310
76031fad
PE
10311 * xdisp.c (init_iterator): Use XINT, not XFASTINT; it might be < 0.
10312
5eb55db9
PE
10313 * composite.c: Don't truncate sizes to 'int'.
10314 (composition_gstring_p, composition_reseat_it)
10315 (composition_adjust_point): Use EMACS_INT, not int.
7d100a81
PE
10316 (get_composition_id, composition_gstring_put_cache): Use EMACS_INT,
10317 not EMACS_UINT, for indexes.
5eb55db9 10318
0703a717
PE
10319 * category.h (CATEGORY_SET_P): Remove unnecessary cast to EMACS_INT.
10320
d6202519
PE
10321 * buffer.c: Include <verify.h>.
10322 (struct sortvec.priority, struct sortstr.priority):
8961a454 10323 Now EMACS_INT, not int.
c20998a7 10324 (compare_overlays, cmp_for_strings): Avoid subtraction overflow.
67c36fce
PE
10325 (struct sortstr.size, record_overlay_string)
10326 (struct sortstrlist.size, struct sortlist.used):
10327 Don't truncate size to int.
10328 (record_overlay_string): Check for size-calculation overflow.
d6202519 10329 (init_buffer_once): Check at compile-time, not run-time.
fadf4e30 10330
d5a19415
JM
103312011-06-22 Jim Meyering <meyering@redhat.com>
10332
029529ac 10333 Don't leak an XBM-image-sized buffer
d5a19415
JM
10334 * image.c (xbm_load): Free the image buffer after using it.
10335
a9041e6c
PE
103362011-06-21 Paul Eggert <eggert@cs.ucla.edu>
10337
10338 Port to Sun C.
10339 * composite.c (find_automatic_composition): Omit needless 'return 0;'
10340 that Sun C diagnosed.
10341 * fns.c (secure_hash): Fix pointer signedness issue.
10342 * intervals.c (static_offset_intervals): New function.
10343 (offset_intervals): Use it.
10344
7f3f739f
LL
103452011-06-21 Leo Liu <sdl.web@gmail.com>
10346
10347 * deps.mk (fns.o):
10348 * makefile.w32-in ($(BLD)/fns.$(O)): Include sha256.h and
10349 sha512.h.
10350
10351 * fns.c (secure_hash): Rename from crypto_hash_function and change
10352 the first arg to accept symbols.
5b66d427 10353 (Fsecure_hash): New primitive.
7f3f739f
LL
10354 (syms_of_fns): New symbols.
10355
76147d94
DD
103562011-06-20 Deniz Dogan <deniz@dogan.se>
10357
10358 * process.c (Fset_process_buffer): Clarify return value in
10359 docstring.
10360
7d7d0045
CY
103612011-06-18 Chong Yidong <cyd@stupidchicken.com>
10362
10363 * dispnew.c (add_window_display_history): Use BVAR.
10364
10365 * xdisp.c (debug_method_add): Use BVAR.
10366 (check_window_end, dump_glyph_matrix, dump_glyph)
10367 (dump_glyph_row, dump_glyph_string): Convert arglist to ANSI C.
10368
10369 * xfaces.c (check_lface_attrs, check_lface, dump_realized_face):
10370 Likewise.
10371
10372 * xfns.c (Fx_create_frame, x_create_tip_frame): Delay image cache
10373 check till after the cache is created in init_frame_faces.
10374
ff2bc410
SM
103752011-06-17 Stefan Monnier <monnier@iro.umontreal.ca>
10376
10377 * fns.c (Fsafe_length): Yet another int/Lisp_Object mixup.
10378
28177add
PE
103792011-06-16 Paul Eggert <eggert@cs.ucla.edu>
10380
dd3482fe
PE
10381 * lisp.h: Include <limits.h>, for INT_MAX, LONG_MAX, LLONG_MAX.
10382 Without this, prin1 mishandles Lisp_Misc_Save_Value printing on
10383 hosts with pre-C99 libraries, because pD is wrongly defined to "t".
10384
393d71f3 10385 Improve buffer-overflow checking (Bug#8873).
1c8e352f
PE
10386 * fileio.c (Finsert_file_contents):
10387 * insdel.c (insert_from_buffer_1, replace_range, replace_range_2):
10388 Remove the old (too-loose) buffer overflow checks.
10389 They weren't needed, since make_gap checks for buffer overflow.
10390 * insdel.c (make_gap_larger): Catch buffer overflows that were missed.
10391 The old code merely checked for Emacs fixnum overflow, and relied
10392 on undefined (wraparound) behavior. The new code avoids undefined
10393 behavior, and also checks for ptrdiff_t and/or size_t overflow.
10394
2e6813b0 10395 * editfns.c (Finsert_char): Don't dump core with very negative counts.
21d890a4
PE
10396 Tune. Don't use wider integers than needed. Don't use alloca.
10397 Use a bigger 'string' buffer. Rewrite to avoid 'n > 0' test.
2e6813b0 10398
599a9e4f
PE
10399 * insdel.c (replace_range): Fix buf overflow when insbytes < outgoing.
10400
99561444
PE
10401 * insdel.c, lisp.h (buffer_overflow): New function.
10402 (insert_from_buffer_1, replace_range, replace_range_2):
10403 * insdel.c (make_gap_larger):
10404 * editfns.c (Finsert_char):
10405 * fileio.c (Finsert_file_contents): Use it, to normalize wording.
10406
28177add
PE
10407 * buffer.h (BUF_BYTES_MAX): Cast to ptrdiff_t so that it's signed.
10408
e69dafad
PE
104092011-06-15 Paul Eggert <eggert@cs.ucla.edu>
10410
4baa020d 10411 Integer overflow and signedness fixes (Bug#8873, Bug#8828).
ff672d2c 10412
b1c46f02
PE
10413 * ccl.c (ASCENDING_ORDER): New macro, to work around GCC bug 43772.
10414 (GET_CCL_RANGE, IN_INT_RANGE): Use it.
10415
e69dafad
PE
10416 * fileio.c: Don't assume EMACS_INT fits in off_t.
10417 (emacs_lseek): New static function.
10418 (Finsert_file_contents, Fwrite_region): Use it.
10419 Use SEEK_SET, SEEK_CUR, SEEK_END as appropriate.
10420
566684ea
PE
10421 * fns.c (Fload_average): Don't assume 100 * load average fits in int.
10422
e6966cd6
PE
10423 * fns.c: Don't overflow int when computing a list length.
10424 * fns.c (QUIT_COUNT_HEURISTIC): New constant.
10425 (Flength, Fsafe_length): Use EMACS_INT, not int, to avoid unwanted
10426 truncation on 64-bit hosts. Check for QUIT every
10427 QUIT_COUNT_HEURISTIC entries rather than every other entry; that's
10428 faster and is responsive enough.
10429 (Flength): Report an error instead of overflowing an integer.
10430 (Fsafe_length): Return a float if the value is not representable
10431 as a fixnum. This shouldn't happen except in contrived situations.
6346d301 10432 (Fnthcdr, Fsort): Don't assume list length fits in int.
de41a810 10433 (Fcopy_sequence): Don't assume vector length fits in int.
00c604f2 10434
dd0b0efb
PE
10435 * alloc.c: Check that resized vectors' lengths fit in fixnums.
10436 (header_size, word_size): New constants.
10437 (allocate_vectorlike): Don't check size overflow here.
10438 (allocate_vector): Check it here instead, since this is the only
10439 caller of allocate_vectorlike that could cause overflow.
10440 Check that the new vector's length is representable as a fixnum.
10441
86fe5cfe
PE
10442 * fns.c (next_almost_prime): Don't return a multiple of 3 or 5.
10443 The previous code was bogus. For example, next_almost_prime (32)
10444 returned 39, which is undesirable as it is a multiple of 3; and
10445 next_almost_prime (24) returned 25, which is a multiple of 5 so
10446 why was the code bothering to check for multiples of 7?
10447
80e88859
PE
10448 * bytecode.c (exec_byte_code): Use ptrdiff_t, not int, for vector length.
10449
4a2f0ad6
PE
10450 * eval.c, doprnt.c (SIZE_MAX): Remove; inttypes.h defines this now.
10451
f66c7cf8
PE
10452 Variadic C functions now count arguments with ptrdiff_t.
10453 This partly undoes my 2011-03-30 change, which replaced int with size_t.
10454 Back then I didn't know that the Emacs coding style prefers signed int.
10455 Also, in the meantime I found a few more instances where arguments
4a2f0ad6
PE
10456 were being counted with int, which may truncate counts on 64-bit
10457 machines, or EMACS_INT, which may be unnecessarily wide.
f66c7cf8
PE
10458 * lisp.h (struct Lisp_Subr.function.aMANY)
10459 (DEFUN_ARGS_MANY, internal_condition_case_n, safe_call):
10460 Arg counts are now ptrdiff_t, not size_t.
10461 All variadic functions and their callers changed accordingly.
10462 (struct gcpro.nvars): Now size_t, not size_t. All uses changed.
10463 * bytecode.c (exec_byte_code): Check maxdepth for overflow,
10464 to avoid potential buffer overrun. Don't assume arg counts fit in 'int'.
10465 * callint.c (Fcall_interactively): Check arg count for overflow,
10466 to avoid potential buffer overrun. Use signed char, not 'int',
10467 for 'varies' array, so that we needn't bother to check its size
10468 calculation for overflow.
10469 * editfns.c (Fformat): Use ptrdiff_t, not EMACS_INT, to count args.
10470 * eval.c (apply_lambda):
10471 * fns.c (Fmapconcat): Use XFASTINT, not XINT, to get args length.
10472 (struct textprop_rec.argnum): Now ptrdiff_t, not int. All uses changed.
10473 (mapconcat): Use ptrdiff_t, not int and EMACS_INT, to count args.
10474
a1759b76
PE
10475 * callint.c (Fcall_interactively): Don't use index var as event count.
10476
d96be9fc
PE
10477 * vm-limit.c (check_memory_limits): Fix incorrect extern function decls.
10478 * mem-limits.h (SIZE): Remove; no longer used.
10479
a690a978 10480 * xterm.c (x_alloc_nearest_color_1): Prefer int to long when int works.
5efd304b 10481
578c21e6
PE
10482 Remove unnecessary casts.
10483 * xterm.c (x_term_init):
10484 * xfns.c (x_set_border_pixel):
10485 * widget.c (create_frame_gcs): Remove casts to unsigned long etc.
10486 These aren't needed now that we assume ANSI C.
10487
96f53c6c
PE
10488 * sound.c (Fplay_sound_internal): Remove cast to unsigned long.
10489 It's more likely to cause problems (due to unsigned overflow)
10490 than to cure them.
10491
83c77d31
PE
10492 * dired.c (Ffile_attributes): Don't use 32-bit hack on 64-bit hosts.
10493
ee2079f1
PE
10494 * unexelf.c (unexec): Don't assume BSS addr fits in unsigned.
10495
6da65536
PE
10496 * xterm.c (handle_one_xevent): Omit unnecessary casts to unsigned.
10497
7147c4a4
PE
10498 * keyboard.c (modify_event_symbol): Don't limit alist len to UINT_MAX.
10499
193e32d9
PE
10500 * lisp.h (CHAR_TABLE_SET): Omit now-redundant test.
10501
e5533da6
PE
10502 * lread.c (Fload): Don't compare a possibly-garbage time_t value.
10503
9910e595
PE
10504 GLYPH_CODE_FACE returns EMACS_INT, not int.
10505 * dispextern.h (merge_faces):
10506 * xfaces.c (merge_faces):
01103c44
PE
10507 * xdisp.c (get_next_display_element, next_element_from_display_vector):
10508 Don't assume EMACS_INT fits in int.
9910e595 10509
2638320e
PE
10510 * character.h (CHAR_VALID_P): Remove unused parameter.
10511 * fontset.c, lisp.h, xdisp.c: All uses changed.
10512
045eb8d9
PE
10513 * editfns.c (Ftranslate_region_internal): Omit redundant test.
10514
c1f134b5
PE
10515 * fns.c (concat): Minor tuning based on overflow analysis.
10516 This doesn't fix any bugs. Use int to hold character, instead
10517 of constantly refetching from Emacs object. Use XFASTINT, not
10518 XINT, for value known to be a character. Don't bother comparing
10519 a single byte to 0400, as it's always less.
10520
395fcb93 10521 * floatfns.c (Fexpt):
327eeec8
PE
10522 * fileio.c (make_temp_name): Omit unnecessary cast to unsigned.
10523
abbd3d23
PE
10524 * editfns.c (Ftranslate_region_internal): Use int, not EMACS_INT
10525 for characters.
10526
684a03ef
PE
10527 * doc.c (get_doc_string): Omit (unsigned)c that mishandled negatives.
10528
0fed43f3
PE
10529 * data.c (Faset): If ARRAY is a string, check that NEWELT is a char.
10530 Without this fix, on a 64-bit host (aset S 0 4294967386) would
10531 incorrectly succeed when S was a string, because 4294967386 was
10532 truncated before it was used.
10533
8fd02eb7
PE
10534 * chartab.c (Fchar_table_range): Use CHARACTERP to check range.
10535 Otherwise, an out-of-range integer could cause undefined behavior
10536 on a 64-bit host.
10537
f8c86b69
PE
10538 * composite.c: Use int, not EMACS_INT, for characters.
10539 (fill_gstring_body, composition_compute_stop_pos): Use int, not
10540 EMACS_INT, for values that are known to be in character range.
10541 This doesn't fix any bugs but is the usual style inside Emacs and
10542 may generate better code on 32-bit machines.
10543
34206dd2
PE
10544 Make sure a 64-bit char is never passed to ENCODE_CHAR.
10545 This is for reasons similar to the recent CHAR_STRING fix.
10546 * charset.c (Fencode_char): Check that character arg is actually
10547 a character. Pass an int to ENCODE_CHAR.
10548 * charset.h (ENCODE_CHAR): Verify that the character argument is no
10549 wider than 'int', as a compile-time check to prevent future regressions
10550 in this area.
10551
c5958d4c 10552 * character.c (char_string): Remove unnecessary casts.
13bdea59
PE
10553
10554 Make sure a 64-bit char is never passed to CHAR_STRING.
10555 Otherwise, CHAR_STRING would do the wrong thing on a 64-bit platform,
10556 by silently ignoring the top 32 bits, allowing some values
10557 that were far too large to be valid characters.
10558 * character.h: Include <verify.h>.
10559 (CHAR_STRING, CHAR_STRING_ADVANCE): Verify that the character
10560 arguments are no wider than unsigned, as a compile-time check
10561 to prevent future regressions in this area.
10562 * data.c (Faset):
01103c44 10563 * editfns.c (Fchar_to_string, general_insert_function, Finsert_char)
13bdea59
PE
10564 (Fsubst_char_in_region):
10565 * fns.c (concat):
10566 * xdisp.c (decode_mode_spec_coding):
10567 Adjust to CHAR_STRING's new requirement.
10568 * editfns.c (Finsert_char, Fsubst_char_in_region):
10569 * fns.c (concat): Check that character args are actually
10570 characters. Without this test, these functions did the wrong
10571 thing with wildly out-of-range values on 64-bit hosts.
10572
d37ca623
PE
10573 Remove incorrect casts to 'unsigned' that lose info on 64-bit hosts.
10574 These casts should not be needed on 32-bit hosts, either.
10575 * keyboard.c (read_char):
10576 * lread.c (Fload): Remove casts to unsigned.
10577
ea204efb
PE
10578 * lisp.h (UNSIGNED_CMP): New macro.
10579 This fixes comparison bugs on 64-bit hosts.
10580 (ASCII_CHAR_P): Use it.
10581 * casefiddle.c (casify_object):
01103c44 10582 * character.h (ASCII_BYTE_P, CHAR_VALID_P)
ea204efb
PE
10583 (SINGLE_BYTE_CHAR_P, CHAR_STRING):
10584 * composite.h (COMPOSITION_ENCODE_RULE_VALID):
10585 * dispextern.h (FACE_FROM_ID):
10586 * keyboard.c (read_char): Use UNSIGNED_CMP.
10587
41cb286c
PE
10588 * xmenu.c (dialog_selection_callback) [!USE_GTK]: Cast to intptr_t,
10589 not to EMACS_INT, to avoid GCC warning.
10590
4a1b9832
PE
10591 * xfns.c (x_set_scroll_bar_default_width): Remove unused 'int' locals.
10592
55daad71
PE
10593 * buffer.h (PTR_BYTE_POS, BUF_PTR_BYTE_POS): Remove harmful cast.
10594 The cast incorrectly truncated 64-bit byte offsets to 32 bits, and
10595 isn't needed on 32-bit machines.
8f95c75c 10596
01103c44
PE
10597 * buffer.c (Fgenerate_new_buffer_name):
10598 Use EMACS_INT for count, not int.
0ceccced 10599 (advance_to_char_boundary): Return EMACS_INT, not int.
e762cafe
PE
10600
10601 * data.c (Qcompiled_function): Now static.
10602
c6f072e7
PE
10603 * window.c (window_body_lines): Now static.
10604
20ce5912
PE
10605 * image.c (gif_load): Rename local to avoid shadowing.
10606
9c4c5f81
PE
10607 * lisp.h (SAFE_ALLOCA_LISP): Check for integer overflow.
10608 (struct Lisp_Save_Value): Use ptrdiff_t, not int, for 'integer' member.
10609 * alloc.c (make_save_value): Integer argument is now of type
10610 ptrdiff_t, not int.
10611 (mark_object): Use ptrdiff_t, not int.
10612 * lisp.h (pD): New macro.
10613 * print.c (print_object): Use it.
10614
c0c5c8ae
PE
10615 * alloc.c: Use EMACS_INT, not int, to count objects.
10616 (total_conses, total_markers, total_symbols, total_vector_size)
10617 (total_free_conses, total_free_markers, total_free_symbols)
01103c44
PE
10618 (total_free_floats, total_floats, total_free_intervals)
10619 (total_intervals, total_strings, total_free_strings):
c0c5c8ae
PE
10620 Now EMACS_INT, not int. All uses changed.
10621 (Fgarbage_collect): Compute overall total using a double, so that
10622 integer overflow is less likely to be a problem. Check for overflow
10623 when converting back to an integer.
5a25e253
PE
10624 (n_interval_blocks, n_string_blocks, n_float_blocks, n_cons_blocks)
10625 (n_vectors, n_symbol_blocks, n_marker_blocks): Remove.
10626 These were 'int' variables that could overflow on 64-bit hosts;
10627 they were never used, so remove them instead of repairing them.
211a0b2a 10628 (nzombies, ngcs, max_live, max_zombies): Now EMACS_INT, not 'int'.
6349ae4d
PE
10629 (inhibit_garbage_collection): Set gc_cons_threshold to max value.
10630 Previously, this ceilinged at INT_MAX, but that doesn't work on
10631 64-bit machines.
e46bb31a 10632 (allocate_pseudovector): Don't use EMACS_INT when int would do.
c0c5c8ae 10633
c78baabf 10634 * alloc.c (Fmake_bool_vector): Don't assume vector size fits in int.
86f61a15 10635 (allocate_vectorlike): Check for ptrdiff_t overflow.
b6439961
PE
10636 (mark_vectorlike, mark_char_table, mark_object): Avoid EMACS_UINT
10637 when a (possibly-narrower) signed value would do just as well.
10638 We prefer using signed arithmetic, to avoid comparison confusion.
c78baabf 10639
c9d624c6
PE
10640 * alloc.c: Catch some string size overflows that we were missing.
10641 (XMALLOC_OVERRUN_CHECK_SIZE) [!XMALLOC_OVERRUN_CHECK]: Define to 0,
10642 for convenience in STRING_BYTES_MAX.
10643 (STRING_BYTES_MAX): New macro, superseding the old one in lisp.h.
10644 The definition here is exact; the one in lisp.h was approximate.
10645 (allocate_string_data): Check for string overflow. This catches
10646 some instances we weren't catching before. Also, it catches
10647 size_t overflow on (unusual) hosts where SIZE_MAX <= min
10648 (PTRDIFF_MAX, MOST_POSITIVE_FIXNUM), e.g., when size_t is 32 bits
10649 and ptrdiff_t and EMACS_INT are both 64 bits.
c78baabf 10650
c9d624c6
PE
10651 * character.c, coding.c, doprnt.c, editfns.c, eval.c:
10652 All uses of STRING_BYTES_MAX replaced by STRING_BYTES_BOUND.
640c8776 10653 * lisp.h (STRING_BYTES_BOUND): Rename from STRING_BYTES_MAX.
c9d624c6 10654
353032ce
PE
10655 * character.c (string_escape_byte8): Fix nbytes/nchars typo.
10656
2bccce07
PE
10657 * alloc.c (Fmake_string): Check for out-of-range init.
10658
0ac30604
SM
106592011-06-15 Stefan Monnier <monnier@iro.umontreal.ca>
10660
10661 * eval.c (Fdefvaralias): Also mark the target as variable-special-p.
10662
c195f2de
JD
106632011-06-14 Jan Djärv <jan.h.d@swipnet.se>
10664
10665 * xfns.c (x_set_scroll_bar_default_width): Remove argument to
10666 xg_get_default_scrollbar_width.
10667
10668 * gtkutil.c: Include emacsgtkfixed.h if HAVE_GTK3.
10669 (int_gtk_range_get_value): Move to the scroll bar part of the file.
10670 (style_changed_cb): Call update_theme_scrollbar_width and call
10671 x_set_scroll_bar_default_width and xg_frame_set_char_size for
10672 all frames (Bug#8505).
10673 (xg_create_frame_widgets): Call emacs_fixed_new if HAVE_GTK3 (Bug#8505).
10674 Call gtk_window_set_resizable if HAVE_GTK3.
10675 (x_wm_set_size_hint): Call emacs_fixed_set_min_size with min width
10676 and height if HAVE_GTK3 (Bug#8505).
10677 (scroll_bar_width_for_theme): New variable.
10678 (update_theme_scrollbar_width): New function.
10679 (xg_get_default_scrollbar_width): Move code to
10680 update_theme_scrollbar_width, just return scroll_bar_width_for_theme.
10681 (xg_initialize): Call update_theme_scrollbar_width.
10682
10683 * gtkutil.h (xg_get_default_scrollbar_width): Remove argument.
10684
10685 * emacsgtkfixed.c, emacsgtkfixed.h: New files.
10686
e10ac9f1
MR
106872011-06-12 Martin Rudalics <rudalics@gmx.at>
10688
10689 * frame.c (make_frame): Call other_buffer_safely instead of
10690 other_buffer.
10691
10692 * window.c (temp_output_buffer_show): Call display_buffer with
10693 second argument Vtemp_buffer_show_specifiers and reset latter
10694 immediately after the call.
10695 (Vtemp_buffer_show_specifiers): New variable.
10696 (auto_window_vscroll_p, next_screen_context_lines)
10697 (Vscroll_preserve_screen_position): Remove leading asterisks from
10698 doc-strings.
10699
2d3c217e 107002011-06-12 Paul Eggert <eggert@cs.ucla.edu>
4475bec4 10701
7b7f97e8 10702 Fix minor problems found by GCC 4.6.0 static checking.
4475bec4
PE
10703 * buffer.c (Qclone_number): Remove for now, as it's unused.
10704 (record_buffer, Funrecord_buffer): Rename local to avoid shadowing.
10705 (record_buffer): Remove unused local.
10706 * frame.c (other_visible_frames, frame_buffer_list): Now static.
10707 (set_frame_buffer_list): Remove; unused.
10708 * frame.h (other_visible_frames): Remove decl.
10709 * keyboard.h (menu_items_inuse): Declare only if USE_GTK || USE_MOTIF.
10710 * lisp.h (frame_buffer_list, set_frame_buffer_list): Remove decls.
10711 (add_gpm_wait_descriptor, delete_gpm_wait_descriptor): Declare only
10712 if HAVE_GPM.
10713 * menu.c (menu_items_inuse): Now static unless USE_GTK || USE_MOTIF.
10714 * process.c (add_gpm_wait_descriptor, delete_gpm_wait_descriptor):
10715 Define only if HAVE_GPM.
10716 * widget.c (EmacsFrameResize, emacsFrameClassRec): Now static.
10717 (update_hints_inhibit): Remove; never set. All uses removed.
10718 * widgetprv.h (emacsFrameClassRec): Remove decl.
10719 * window.c (delete_deletable_window): Now returns void, since it
10720 wasn't returning anything.
10721 (compare_window_configurations): Remove unused locals.
10722 * xfns.c (x_set_scroll_bar_default_width): Remove unused locals.
10723 * xmenu.c (x_menu_set_in_use): Define only if USE_GTK || USE_MOTIF.
4475bec4
PE
10724 (dialog_selection_callback) [!USE_GTK]: Prefer intptr_t for integers
10725 the same widths as pointers. This follows up on the 2011-05-06 patch.
10726 * xterm.c (x_alloc_lighter_color_for_widget): Define only if USE_LUCID.
10727 * xterm.h: Likewise.
10728 (x_menu_set_in_use): Declare only if USE_GTK || USE_MOTIF.
10729
1384b89e
JB
107302011-06-12 Juanma Barranquero <lekktu@gmail.com>
10731
10732 * makefile.w32-in: Update dependencies.
10733 (LISP_H): Add lib/intprops.h.
10734
1100a63c
CY
107352011-06-11 Chong Yidong <cyd@stupidchicken.com>
10736
10737 * image.c (gif_load): Add animation frame delay to the metadata.
10738 (syms_of_image): Use DEFSYM. New symbol `delay'.
10739
6198ccd0
MR
107402011-06-11 Martin Rudalics <rudalics@gmx.at>
10741
10742 * window.c (delete_deletable_window): Re-add.
10743 (Fset_window_configuration): Rewrite to handle dead buffers and
10744 consequently deletable windows.
10745 (window_tree, Fwindow_tree): Remove. Supply functionality in
10746 window.el.
10747 (compare_window_configurations): Simplify code.
10748
b6e3633c
AS
107492011-06-11 Andreas Schwab <schwab@linux-m68k.org>
10750
1ab0dee5
AS
10751 * image.c (imagemagick_load_image): Fix type mismatch.
10752 (Fimagemagick_types): Likewise.
10753
b6e3633c
AS
10754 * window.h (replace_buffer_in_windows): Declare.
10755
9397e56f
MR
107562011-06-11 Martin Rudalics <rudalics@gmx.at>
10757
10758 * buffer.c: New Lisp objects Qbuffer_list_update_hook and
10759 Qclone_number. Remove external declaration of Qdelete_window.
10760 (Fbuffer_list): Rewrite doc-string. Minor restructuring of
10761 code.
640c8776
SM
10762 (Fget_buffer_create, Fmake_indirect_buffer, Frename_buffer):
10763 Run Qbuffer_list_update_hook if allowed.
9397e56f
MR
10764 (Fother_buffer): Rewrite doc-string. Major rewrite for new
10765 buffer list implementation.
10766 (other_buffer_safely): New function.
10767 (Fkill_buffer): Replace call to replace_buffer_in_all_windows by
10768 calls to replace_buffer_in_windows and
10769 replace_buffer_in_windows_safely. Run Qbuffer_list_update_hook
10770 if allowed.
10771 (record_buffer): Inhibit quitting and rewrite using quittable
10772 functions. Run Qbuffer_list_update_hook if allowed.
10773 (Frecord_buffer, Funrecord_buffer): New functions.
640c8776
SM
10774 (switch_to_buffer_1, Fswitch_to_buffer): Remove.
10775 Move switch-to-buffer to window.el.
9397e56f
MR
10776 (bury-buffer): Move to window.el.
10777 (Vbuffer_list_update_hook): New variable.
10778
10779 * lisp.h (other_buffer_safely): Add prototype in buffer.c
10780 section.
10781
10782 * window.h (resize_frame_windows): Move up in code.
10783 (Fwindow_frame): Remove EXFUN.
10784 (replace_buffer_in_all_windows): Remove prototype.
10785 (replace_buffer_in_windows_safely): Add prototype.
10786
10787 * window.c: Declare Qdelete_window static again. Move down
10788 declaration of select_count.
10789 (Fnext_window, Fprevious_window): Rewrite doc-strings.
10790 (Fother_window): Move to window.el.
10791 (window_loop): Remove DELETE_BUFFER_WINDOWS and UNSHOW_BUFFER
10792 cases. Add REPLACE_BUFFER_IN_WINDOWS_SAFELY case.
10793 (Fdelete_windows_on, Freplace_buffer_in_windows): Move to
10794 window.el.
10795 (replace_buffer_in_windows): Implement by calling
10796 Qreplace_buffer_in_windows.
10797 (replace_buffer_in_all_windows): Remove with some functionality
10798 moved into replace_buffer_in_windows_safely.
10799 (replace_buffer_in_windows_safely): New function.
10800 (select_window_norecord, select_frame_norecord): Move in front
10801 of run_window_configuration_change_hook. Remove now obsolete
10802 declarations.
640c8776
SM
10803 (Fset_window_buffer): Rewrite doc-string.
10804 Call Qrecord_window_buffer.
9397e56f
MR
10805 (keys_of_window): Move binding for other-window to window.el.
10806
b50691aa
CY
108072011-06-11 Chong Yidong <cyd@stupidchicken.com>
10808
10809 * dispextern.h (struct image): Replace data member, whose int_val
10810 and ptr_val fields were not used by anything, with a single
10811 lisp_val object.
10812
10813 * image.c (Fimage_metadata, make_image, mark_image, tiff_load)
10814 (gif_clear_image, gif_load, imagemagick_load_image)
10815 (gs_clear_image, gs_load): Callers changed.
10816
3f754b86
PE
108172011-06-10 Paul Eggert <eggert@cs.ucla.edu>
10818
cca69397
PE
10819 * buffer.h: Include <time.h>, for time_t.
10820 Needed to build on FreeBSD 8.2. Problem reported by Herbert J. Skuhra.
10821
109e28d0
PE
10822 Fix minor problems found by static checking.
10823
60737f02
PE
10824 * image.c (PixelGetMagickColor): Declare if ImageMagick headers don't.
10825
4b66faf3
PE
10826 Make identifiers static if they are not used in other modules.
10827 * data.c (Qcompiled_function, Qframe, Qvector):
10828 * image.c (QimageMagick, Qsvg):
10829 * minibuf.c (Qmetadata):
10830 * window.c (resize_window_check, resize_root_window): Now static.
10831 * window.h (resize_window_check, resize_root_window): Remove decls.
10832
109e28d0
PE
10833 * window.c (window_deletion_count, delete_deletable_window):
10834 Remove; unused.
46a4ce9e
PE
10835 (window_body_lines): Now static.
10836 (Fdelete_other_windows_internal): Mark vars as initialized.
10837 Make sure 'resize_failed' is initialized.
10838 (run_window_configuration_change_hook): Rename local to avoid shadowing.
10839 (resize_window_apply): Remove unused local.
10840 * window.h (delete_deletable_window): Remove decl.
10841
109e28d0 10842 * image.c (gif_load, svg_load_image): Rename locals to avoid shadowing.
33290528
PE
10843 (imagemagick_load_image): Fix pointer signedness problem by changing
10844 last arg from unsigned char * to char *. All uses changed.
10845 Also, fix a local for similar reasons.
10846 Remove unused locals. Remove locals to avoid shadowing.
10847 (fn_rsvg_handle_free): Remove; unused.
10848 (svg_load, svg_load_image): Fix pointer signedness problem.
f7e13da3 10849 (imagemagick_load_image): Don't use garbage pointer image_wand.
33290528 10850
3f754b86
PE
10851 * ftfont.c (ftfont_get_metrics, ftfont_drive_otf): Remove unused locals.
10852
2547adb1
CY
108532011-06-10 Chong Yidong <cyd@stupidchicken.com>
10854
10855 * image.c (gif_load): Fix omitted cast error introduced by
10856 2011-06-06 change.
10857
2c8e37d4
MR
108582011-06-10 Martin Rudalics <rudalics@gmx.at>
10859
10860 * window.h (resize_proportionally, orig_total_lines)
10861 (orig_top_line): Remove from window structure.
10862 (set_window_height, set_window_width, change_window_heights)
10863 (Fdelete_window): Remove prototypes.
10864 (resize_frame_windows): Remove duplicate declaration.
10865
440a42e3
EZ
108662011-06-10 Eli Zaretskii <eliz@gnu.org>
10867
10868 * window.h (resize_frame_windows, resize_window_check)
10869 (delete_deletable_window, resize_root_window)
10870 (resize_frame_windows): Declare prototypes.
10871
10872 * window.c (resize_window_apply): Make definition be "static" to
10873 match the prototype.
10874
562dd5e9
MR
108752011-06-10 Martin Rudalics <rudalics@gmx.at>
10876
10877 * window.c: Remove declarations of Qwindow_size_fixed,
10878 window_min_size_1, window_min_size_2, window_min_size,
10879 size_window, window_fixed_size_p, enlarge_window, delete_window.
10880 Remove static from declaration of Qdelete_window, it's
10881 temporarily needed by Fbury_buffer.
10882 (replace_window): Don't assign orig_top_line and
10883 orig_total_lines.
10884 (Fdelete_window, delete_window): Remove. Window deletion is
10885 handled by window.el.
640c8776
SM
10886 (window_loop): Remove DELETE_OTHER_WINDOWS case.
10887 Replace Fdelete_window calls with calls to Qdelete_window.
562dd5e9
MR
10888 (Fdelete_other_windows): Remove. Deleting other windows is
10889 handled by window.el.
10890 (window_fixed_size_p): Remove. Fixed-sizeness of windows is
10891 handled in window.el.
10892 (window_min_size_2, window_min_size_1, window_min_size): Remove.
10893 Window minimum sizes are handled in window.el.
10894 (shrink_windows, size_window, set_window_height)
10895 (set_window_width, change_window_heights, window_height)
10896 (window_width, CURBEG, CURSIZE, enlarge_window)
10897 (adjust_window_trailing_edge, Fadjust_window_trailing_edge)
10898 (Fenlarge_window, Fshrink_window): Remove. Window resizing is
10899 handled in window.el.
10900 (make_dummy_parent): Rename to make_parent_window and give it a
10901 second argument horflag.
10902 (make_window): Don't set resize_proportionally any more.
10903 (Fsplit_window): Remove. Windows are split in window.el.
10904 (save_restore_action, save_restore_orig_size)
10905 (shrink_window_lowest_first, save_restore_orig_size): Remove.
10906 Resize mini windows in window.el.
10907 (grow_mini_window, shrink_mini_window): Implement by calling
10908 Qresize_root_window_vertically, resize_window_check and
10909 resize_window_apply.
640c8776
SM
10910 (saved_window, Fset_window_configuration, save_window_save):
10911 Do not handle orig_top_line, orig_total_lines, and
562dd5e9
MR
10912 resize_proportionally.
10913 (window_min_height, window_min_width): Move to window.el.
10914 (keys_of_window): Move bindings for delete-other-windows,
10915 split-window, delete-window and enlarge-window to window.el.
10916
10917 * buffer.c: Temporarily extern Qdelete_window.
10918 (Fbury_buffer): Temporarily call Qdelete_window instead of
10919 Fdelete_window (Fbury_buffer will move to window.el soon).
10920
10921 * frame.c (set_menu_bar_lines_1): Remove code handling
10922 orig_top_line and orig_total_lines.
10923
10924 * dispnew.c (adjust_frame_glyphs_initially): Don't use
10925 set_window_height but set heights directly.
10926 (change_frame_size_1): Use resize_frame_windows.
10927
10928 * xdisp.c (init_xdisp): Don't use set_window_height but set
10929 heights directly.
10930
640c8776
SM
10931 * xfns.c (x_set_menu_bar_lines, x_set_tool_bar_lines):
10932 Use resize_frame_windows instead of change_window_heights and run
562dd5e9
MR
10933 run_window_configuration_change_hook.
10934
10935 * w32fns.c (x_set_tool_bar_lines): Use resize_frame_windows
10936 instead of change_window_heights and run
10937 run_window_configuration_change_hook.
10938
1a13852e
MR
109392011-06-09 Martin Rudalics <rudalics@gmx.at>
10940
10941 * window.c (replace_window): Rename second argument REPLACEMENT to
10942 NEW. New third argument SETFLAG. Rewrite.
10943 (delete_window, make_dummy_parent): Call replace_window with
10944 third argument 1.
10945 (window_list_1): Move down in code.
10946 (run_window_configuration_change_hook): Move set_buffer part
10947 before select_frame_norecord part in order to unwind correctly.
10948 Rename count1 to count.
10949 (recombine_windows, delete_deletable_window, resize_root_window)
10950 (Fdelete_other_windows_internal)
10951 (Frun_window_configuration_change_hook, make_parent_window)
10952 (resize_window_check, resize_window_apply, Fresize_window_apply)
10953 (resize_frame_windows, Fsplit_window_internal)
640c8776
SM
10954 (Fdelete_window_internal, Fresize_mini_window_internal):
10955 New functions.
1a13852e
MR
10956 (syms_of_window): New variables Vwindow_splits and Vwindow_nest.
10957
f3d1777e
MR
109582011-06-08 Martin Rudalics <rudalics@gmx.at>
10959
496e208e
MR
10960 * window.h (window): Add some new members to window structure -
10961 normal_lines, normal_cols, new_total, new_normal, clone_number,
10962 splits, nest, prev_buffers, next_buffers.
10963 (WINDOW_TOTAL_SIZE): Move here from window.c.
b9e809c2 10964 (MIN_SAFE_WINDOW_WIDTH, MIN_SAFE_WINDOW_HEIGHT): Define here.
496e208e 10965
f3d1777e
MR
10966 * window.c (Fwindow_height, Fwindow_width, Fwindow_full_width_p):
10967 Remove.
496e208e
MR
10968 (make_dummy_parent): Set new members of windows structure.
10969 (make_window): Move down in code. Handle new members of window
10970 structure.
10971 (Fwindow_clone_number, Fwindow_splits, Fset_window_splits)
10972 (Fwindow_nest, Fset_window_nest, Fwindow_new_total)
10973 (Fwindow_normal_size, Fwindow_new_normal, Fwindow_prev_buffers)
10974 (Fset_window_prev_buffers, Fwindow_next_buffers)
640c8776
SM
10975 (Fset_window_next_buffers, Fset_window_clone_number):
10976 New functions.
496e208e
MR
10977 (Fwindow_hscroll, Fwindow_at, Fwindow_point, Fwindow_start)
10978 (Fwindow_end, Fwindow_line_height, Fset_window_dedicated_p):
10979 Doc-string fixes.
10980 (Fwindow_parameters, Fwindow_parameter, Fset_window_parameter):
10981 Argument WINDOW can be now internal window too.
10982 (Fwindow_use_time): Move up in code.
10983 (Fget_buffer_window): Rename argument FRAME to ALL-FRAMES.
10984 Rewrite doc-string.
10985 (Fset_window_configuration, saved_window)
10986 (Fcurrent_window_configuration, save_window_save): Handle new
10987 members of window structure.
b9e809c2
MR
10988 (WINDOW_TOTAL_SIZE, MIN_SAFE_WINDOW_WIDTH)
10989 (MIN_SAFE_WINDOW_HEIGHT): Move to window.h.
10990 (syms_of_window): New Lisp objects Qrecord_window_buffer,
10991 Qwindow_deletable_p, Qdelete_window, Qreplace_buffer_in_windows,
10992 Qget_mru_window, Qresize_root_window,
10993 Qresize_root_window_vertically, Qsafe, Qabove, Qbelow,
10994 Qauto_buffer_name; staticpro them.
f3d1777e 10995
abde8f8c
MR
109962011-06-07 Martin Rudalics <rudalics@gmx.at>
10997
10998 * window.c (Fwindow_total_size, Fwindow_left_column)
10999 (Fwindow_top_line, window_body_lines, Fwindow_body_size)
11000 (Fwindow_list_1): New functions.
11001 (window_box_text_cols): Replace with window_body_cols.
640c8776
SM
11002 (Fwindow_width, Fscroll_left, Fscroll_right):
11003 Use window_body_cols instead of window_box_text_cols.
11004 (delete_window, Fset_window_configuration):
11005 Call delete_all_subwindows with window as argument.
fa8a67e6
MR
11006 (delete_all_subwindows): Take a window as argument and not a
11007 structure. Rewrite.
190b47e6
MR
11008 (window_loop): Remove handling of GET_LRU_WINDOW and
11009 GET_LARGEST_WINDOW.
11010 (Fget_lru_window, Fget_largest_window): Move to window.el.
abde8f8c
MR
11011
11012 * window.h: Extern window_body_cols instead of
fa8a67e6
MR
11013 window_box_text_cols. delete_all_subwindows now takes a
11014 Lisp_Object as argument.
abde8f8c 11015
640c8776
SM
11016 * indent.c (compute_motion, Fcompute_motion):
11017 Use window_body_cols instead of window_box_text_cols.
abde8f8c 11018
fa8a67e6
MR
11019 * frame.c (delete_frame): Call delete_all_subwindows with root
11020 window as argument.
11021
a54e3482
DC
110222011-06-07 Daniel Colascione <dan.colascione@gmail.com>
11023
11024 * fns.c (Fputhash): Document return value.
11025
60002bf5
CY
110262011-06-06 Chong Yidong <cyd@stupidchicken.com>
11027
11028 * image.c (gif_load): Implement gif89a spec "no disposal" method.
11029
0c671da6 110302011-06-06 Paul Eggert <eggert@cs.ucla.edu>
ccd9a01a 11031
b862a52a 11032 Cons<->int and similar integer overflow fixes (Bug#8794).
77984278 11033
be44ca6c
PE
11034 Check for overflow when converting integer to cons and back.
11035 * charset.c (Fdefine_charset_internal, Fdecode_char):
11036 Use cons_to_unsigned to catch overflow.
11037 (Fencode_char): Use INTEGER_TO_CONS.
11038 * composite.h (LGLYPH_CODE): Use cons_to_unsigned.
11039 (LGLYPH_SET_CODE): Use INTEGER_TO_CONS.
11040 * data.c (long_to_cons, cons_to_long): Remove.
11041 (cons_to_unsigned, cons_to_signed): New functions.
11042 These signal an error for invalid or out-of-range values.
11043 * dired.c (Ffile_attributes): Use INTEGER_TO_CONS.
11044 * fileio.c (Fset_visited_file_modtime): Use CONS_TO_INTEGER.
11045 * font.c (Ffont_variation_glyphs):
11046 * fontset.c (Finternal_char_font): Use INTEGER_TO_CONS.
11047 * lisp.h: Include <intprops.h>.
11048 (INTEGER_TO_CONS, CONS_TO_INTEGER): New macros.
11049 (cons_to_signed, cons_to_unsigned): New decls.
11050 (long_to_cons, cons_to_long): Remove decls.
11051 * undo.c (record_first_change): Use INTEGER_TO_CONS.
11052 (Fprimitive_undo): Use CONS_TO_INTEGER.
11053 * xfns.c (Fx_window_property): Likewise.
11054 * xselect.c: Include <limits.h>.
11055 (x_own_selection, selection_data_to_lisp_data):
11056 Use INTEGER_TO_CONS.
11057 (x_handle_selection_request, x_handle_selection_clear)
11058 (x_get_foreign_selection, Fx_disown_selection_internal)
11059 (Fx_get_atom_name, x_send_client_event): Use CONS_TO_INTEGER.
11060 (lisp_data_to_selection_data): Use cons_to_unsigned.
11061 (x_fill_property_data): Use cons_to_signed.
11062 Report values out of range.
11063
d1f3d2af
PE
11064 Check for buffer and string overflow more precisely.
11065 * buffer.h (BUF_BYTES_MAX): New macro.
11066 * lisp.h (STRING_BYTES_MAX): New macro.
11067 * alloc.c (Fmake_string):
11068 * character.c (string_escape_byte8):
11069 * coding.c (coding_alloc_by_realloc):
11070 * doprnt.c (doprnt):
11071 * editfns.c (Fformat):
11072 * eval.c (verror):
11073 Use STRING_BYTES_MAX, not MOST_POSITIVE_FIXNUM,
11074 since they may not be the same number.
11075 * editfns.c (Finsert_char):
11076 * fileio.c (Finsert_file_contents):
11077 Likewise for BUF_BYTES_MAX.
11078
dd52fcea
PE
11079 * image.c: Use ptrdiff_t, not int, for sizes.
11080 (slurp_file): Switch from int to ptrdiff_t.
11081 All uses changed.
11082 (slurp_file): Check that file size fits in both size_t (for
11083 malloc) and ptrdiff_t (for sanity and safety).
11084
7f9bbdbb
PE
11085 * fileio.c (Fverify_visited_file_modtime): Avoid time overflow
11086 if b->modtime has its maximal value.
11087
dfe18f82
PE
11088 * dired.c (Ffile_attributes): Don't assume EMACS_INT has >32 bits.
11089
84acfcf0
PE
11090 Don't assume time_t can fit into int.
11091 * buffer.h (struct buffer.modtime): Now time_t, not int.
11092 * fileio.c (Fvisited_file_modtime): No need for time_t cast now.
11093 * undo.c (Fprimitive_undo): Use time_t, not int, for time_t value.
11094
ccd9a01a
PE
11095 Minor fixes for signed vs unsigned integers.
11096 * character.h (MAYBE_UNIFY_CHAR):
11097 * charset.c (maybe_unify_char):
11098 * keyboard.c (read_char, reorder_modifiers):
11099 XINT -> XFASTINT, since the integer must be nonnegative.
11100 * ftfont.c (ftfont_spec_pattern):
11101 * keymap.c (access_keymap, silly_event_symbol_error):
11102 XUINT -> XFASTINT, since the integer must be nonnegative.
11103 (Fsingle_key_description, preferred_sequence_p): XUINT -> XINT,
11104 since it makes no difference and we prefer signed.
11105 * keyboard.c (record_char): Use XUINT when all the neighbors do.
11106 (access_keymap): NATNUMP -> INTEGERP, since the integer must be
11107 nonnegative.
11108
d6d100dd
SM
111092011-06-06 Stefan Monnier <monnier@iro.umontreal.ca>
11110
11111 * window.h (Fwindow_frame): Declare.
11112
2b6148e4
PE
111132011-06-06 Paul Eggert <eggert@cs.ucla.edu>
11114
11115 * alloc.c: Simplify handling of large-request failures (Bug#8800).
11116 (SPARE_MEMORY): Always define.
11117 (LARGE_REQUEST): Remove.
11118 (memory_full): Use SPARE_MEMORY rather than LARGE_REQUEST.
11119
f230ecc9
MR
111202011-06-06 Martin Rudalics <rudalics@gmx.at>
11121
727e958e
MR
11122 * lisp.h: Move EXFUNS for Fframe_root_window,
11123 Fframe_first_window and Fset_frame_selected_window to window.h.
11124
11125 * window.h: Move EXFUNS for Fframe_root_window,
11126 Fframe_first_window and Fset_frame_selected_window here from
11127 lisp.h.
11128
11129 * frame.c (Fwindow_frame, Fframe_first_window)
11130 (Fframe_root_window, Fframe_selected_window)
11131 (Fset_frame_selected_window): Move to window.c.
11132 (Factive_minibuffer_window): Move to minibuf.c.
11133 (Fother_visible_frames_p): New function.
11134
11135 * minibuf.c (Factive_minibuffer_window): Move here from frame.c.
11136
f230ecc9
MR
11137 * window.c (decode_window, decode_any_window): Move up in code.
11138 (Fwindowp, Fwindow_live_p): Rewrite doc-strings.
11139 (inhibit_frame_unsplittable): Remove unused variable.
bf60a96b
MR
11140 (Fwindow_buffer): Move up and rewrite doc-string.
11141 (Fwindow_parent, Fwindow_vchild, Fwindow_hchild, Fwindow_next)
11142 (Fwindow_prev): New functions.
727e958e
MR
11143 (Fwindow_frame): Move here from frame.c. Accept any window as
11144 argument.
11145 (Fframe_root_window, Fframe_first_window)
11146 (Fframe_selected_window): Move here from frame.c. Accept frame
11147 or arbitrary window as argument. Update doc-strings.
11148 (Fminibuffer_window): Move up in code.
11149 (Fwindow_minibuffer_p): Move up in code and simplify.
d6d100dd
SM
11150 (Fset_frame_selected_window): Move here from frame.c.
11151 Marginal rewrite.
727e958e
MR
11152 (Fselected_window, select_window, Fselect_window): Move up in
11153 code. Minor doc-string fixes.
f230ecc9 11154
4d09bcf6
PE
111552011-06-06 Paul Eggert <eggert@cs.ucla.edu>
11156
11157 * alloc.c (memory_full) [SYSTEM_MALLOC]: Port to MacOS (Bug#8800).
11158 Do not assume that spare memory exists; that assumption is valid
11159 only if SYSTEM_MALLOC.
11160 (LARGE_REQUEST): New macro, so that the issue of large requests
11161 is separated from the issue of spare memory.
11162
810928a2
AS
111632011-06-05 Andreas Schwab <schwab@linux-m68k.org>
11164
172418ad
AS
11165 * editfns.c (Fformat): Correctly handle zero flag with hexadecimal
11166 format. (Bug#8806)
11167
43f862f7
AS
11168 * gtkutil.c (xg_get_default_scrollbar_width): Avoid warning.
11169
810928a2
AS
11170 * xfns.c (x_set_scroll_bar_default_width): Move declarations
11171 before statements.
11172
a059fe24
JD
111732011-06-05 Jan Djärv <jan.h.d@swipnet.se>
11174
11175 * gtkutil.c (xg_get_default_scrollbar_width): New function.
11176
11177 * gtkutil.h: Declare xg_get_default_scrollbar_width.
11178
11179 * xfns.c (x_set_scroll_bar_default_width): If USE_GTK, get
11180 min width by calling x_set_scroll_bar_default_width (Bug#8505).
11181
989bf368
JB
111822011-06-05 Juanma Barranquero <lekktu@gmail.com>
11183
11184 * xdisp.c (single_display_spec_intangible_p): Remove declaration.
11185
4b80f674
CY
111862011-06-04 Chong Yidong <cyd@stupidchicken.com>
11187
11188 * xselect.c (x_clipboard_manager_save): Remove redundant arg.
11189 (x_clipboard_manager_save): Add return value.
d6d100dd
SM
11190 (x_clipboard_manager_error_1, x_clipboard_manager_error_2):
11191 New error handlers.
4b80f674
CY
11192 (x_clipboard_manager_save_frame, x_clipboard_manager_save_all):
11193 Obey Vx_select_enable_clipboard_manager. Catch errors in
11194 x_clipboard_manager_save (Bug#8779).
11195 (Vx_select_enable_clipboard_manager): New variable.
de65b42c 11196 (x_get_foreign_selection): Reduce scope of x_catch_errors (Bug#8790).
4b80f674 11197
99a33b77 111982011-06-04 Dan Nicolaescu <dann@ics.uci.edu>
8b3115e7
DN
11199
11200 * emacs.c (main): Warn when starting a GTK emacs in daemon mode.
11201
99a33b77 112022011-06-04 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
14eca62f
YM
11203
11204 * fringe.c (update_window_fringes): Don't update overlay arrow bitmap
11205 in the current matrix if keep_current_p is non-zero.
11206
8264569d
EZ
112072011-06-04 Eli Zaretskii <eliz@gnu.org>
11208
11209 * bidi.c (bidi_level_of_next_char): Fix last change.
11210
57f97249
EZ
112112011-06-03 Eli Zaretskii <eliz@gnu.org>
11212
fec2107c 11213 Support bidi reordering of text covered by display properties.
57f97249 11214
fec2107c
EZ
11215 * bidi.c (bidi_copy_it): Use offsetof instead of emulating it.
11216 (bidi_fetch_char, bidi_fetch_char_advance): New functions.
11217 (bidi_cache_search, bidi_cache_iterator_state)
11218 (bidi_paragraph_init, bidi_resolve_explicit, bidi_resolve_weak)
d6d100dd
SM
11219 (bidi_level_of_next_char, bidi_move_to_visually_next):
11220 Support character positions inside a run of characters covered by a
fec2107c
EZ
11221 display string.
11222 (bidi_paragraph_init, bidi_resolve_explicit_1)
11223 (bidi_level_of_next_char): Call bidi_fetch_char and
11224 bidi_fetch_char_advance instead of FETCH_CHAR and
11225 FETCH_CHAR_ADVANCE.
11226 (bidi_init_it): Initialize new members.
11227 (LRE_CHAR, RLE_CHAR, PDF_CHAR, LRO_CHAR, RLO_CHAR): Remove macro
11228 definitions.
11229 (bidi_explicit_dir_char): Lookup character type in bidi_type_table,
11230 instead of using explicit *_CHAR codes.
d6d100dd
SM
11231 (bidi_resolve_explicit, bidi_resolve_weak):
11232 Use FETCH_MULTIBYTE_CHAR instead of FETCH_CHAR, as reordering of
fec2107c
EZ
11233 bidirectional text is supported only in multibyte buffers.
11234 (bidi_init_it): Accept additional argument FRAME_WINDOW_P and use
11235 it to initialize the frame_window_p member of struct bidi_it.
11236 (bidi_cache_iterator_state, bidi_resolve_explicit_1)
11237 (bidi_resolve_explicit, bidi_resolve_weak)
11238 (bidi_level_of_next_char, bidi_move_to_visually_next): Abort if
11239 bidi_it->nchars is non-positive.
11240 (bidi_level_of_next_char): Don't try to lookup the cache for the
11241 next/previous character if nothing is cached there yet, or if we
11242 were just reseat()'ed to a new position.
c40e2fb2 11243
0e14fe90
EZ
11244 * xdisp.c (set_cursor_from_row): Set start and stop points
11245 according to the row's direction when priming the loop that looks
11246 for the glyph on which to display cursor.
11247 (single_display_spec_intangible_p): Function deleted.
11248 (display_prop_intangible_p): Reimplement to call
11249 handle_display_spec instead of single_display_spec_intangible_p.
d6d100dd
SM
11250 Accept 3 additional arguments needed by handle_display_spec.
11251 This fixes incorrect cursor motion across display property with complex
0e14fe90
EZ
11252 values: lists, `(when COND...)' forms, etc.
11253 (single_display_spec_string_p): Support property values that are
11254 lists with the argument STRING its top-level element.
11255 (display_prop_string_p): Fix the condition for processing a
11256 property that is a list to be consistent with handle_display_spec.
fec2107c 11257 (handle_display_spec): New function, refactored from the
fc6f18ce
EZ
11258 last portion of handle_display_prop.
11259 (compute_display_string_pos): Accept additional argument
11260 FRAME_WINDOW_P. Call handle_display_spec to determine whether the
11261 value of a `display' property is a "replacing spec".
11262 (handle_single_display_spec): Accept 2 additional arguments BUFPOS
11263 and FRAME_WINDOW_P. If IT is NULL, don't set up the iterator from
11264 the display property, but just return a value indicating whether
11265 the display property will replace the characters it covers.
11266 (Fcurrent_bidi_paragraph_direction): Initialize the nchars and
11267 frame_window_p members of struct bidi_it.
d6d100dd
SM
11268 (compute_display_string_pos, compute_display_string_end):
11269 New functions.
fec2107c
EZ
11270 (push_it): Accept second argument POSITION, where pop_it should
11271 jump to continue iteration.
11272 (reseat_1): Initialize bidi_it.disp_pos.
fc6f18ce 11273
fec2107c
EZ
11274 * keyboard.c (adjust_point_for_property): Adjust the call to
11275 display_prop_intangible_p to its new signature.
fc6f18ce
EZ
11276
11277 * dispextern.h (struct bidi_it): New member frame_window_p.
fec2107c
EZ
11278 (bidi_init_it): Update prototypes.
11279 (display_prop_intangible_p): Update prototype.
d6d100dd
SM
11280 (compute_display_string_pos, compute_display_string_end):
11281 Declare prototypes.
fec2107c
EZ
11282 (struct bidi_it): New members nchars and disp_pos. ch_len is now
11283 EMACS_INT.
fc6f18ce 11284
40087514 112852011-06-02 Paul Eggert <eggert@cs.ucla.edu>
0de4bb68 11286
57f53182
PE
11287 Malloc failure behavior now depends on size of allocation.
11288 * alloc.c (buffer_memory_full, memory_full): New arg NBYTES.
11289 * lisp.h: Change signatures accordingly.
11290 * alloc.c, buffer.c, editfns.c, menu.c, minibuf.c, xterm.c:
11291 All callers changed. (Bug#8762)
11292
11293 * gnutls.c: Use Emacs's memory allocators.
11294 Without this change, the gnutls library would invoke malloc etc.
11295 directly, which causes problems on non-SYNC_INPUT hosts, and which
11296 runs afoul of improving memory_full behavior. (Bug#8761)
11297 (fn_gnutls_global_set_mem_functions): New macro or function pointer.
11298 (emacs_gnutls_global_init): Use it to specify xmalloc, xrealloc,
11299 xfree instead of the default malloc, realloc, free.
11300 (Fgnutls_boot): No need to check for memory allocation failure,
11301 since xmalloc does that for us.
11302
ac32cd99 11303 Remove arbitrary limit of 2**31 entries in hash tables. (Bug#8771)
3870d916
PE
11304 * category.c (hash_get_category_set):
11305 * ccl.c (ccl_driver):
11306 * charset.c (Fdefine_charset_internal):
11307 * charset.h (struct charset.hash_index):
11308 * composite.c (get_composition_id, gstring_lookup_cache)
11309 (composition_gstring_put_cache):
11310 * composite.h (struct composition.hash_index):
11311 * dispextern.h (struct image.hash):
11312 * fns.c (next_almost_prime, larger_vector, cmpfn_eql)
11313 (cmpfn_equal, cmpfn_user_defined, hashfn_eq, hashfn_eql)
11314 (hashfn_equal, hashfn_user_defined, make_hash_table)
11315 (maybe_resize_hash_table, hash_lookup, hash_put)
11316 (hash_remove_from_table, hash_clear, sweep_weak_table, SXHASH_COMBINE)
11317 (sxhash_string, sxhash_list, sxhash_vector, sxhash_bool_vector)
11318 (Fsxhash, Fgethash, Fputhash, Fmaphash):
11319 * image.c (make_image, search_image_cache, lookup_image)
11320 (xpm_put_color_table_h):
11321 * lisp.h (struct Lisp_Hash_Table):
0de4bb68 11322 * minibuf.c (Ftry_completion, Fall_completions, Ftest_completion):
ac389d0c 11323 * print.c (print): Use 'EMACS_UINT' and 'EMACS_INT'
3870d916 11324 for hashes and hash indexes, instead of 'unsigned' and 'int'.
40087514
PE
11325 * alloc.c (allocate_vectorlike):
11326 Check for overflow in vector size calculations.
11327 * ccl.c (ccl_driver):
11328 Check for overflow when converting EMACS_INT to int.
0de4bb68
PE
11329 * fns.c, image.c: Remove unnecessary static decls that would otherwise
11330 need to be updated by these changes.
40087514
PE
11331 * fns.c (make_hash_table, maybe_resize_hash_table):
11332 Check for integer overflow with large hash tables.
0de4bb68
PE
11333 (make_hash_table, maybe_resize_hash_table, Fmake_hash_table):
11334 Prefer the faster XFLOAT_DATA to XFLOATINT where either will do.
11335 (SXHASH_REDUCE): New macro.
11336 (sxhash_string, sxhash_list, sxhash_vector, sxhash_bool_vector):
11337 Use it instead of discarding useful hash info with large hash values.
11338 (sxhash_float): New function.
11339 (sxhash): Use it. No more need for "& INTMASK" due to above changes.
11340 * lisp.h (FIXNUM_BITS): New macro, useful for SXHASH_REDUCE etc.
40087514
PE
11341 (MOST_NEGATIVE_FIXNUM, MOST_POSITIVE_FIXNUM, INTMASK):
11342 Rewrite to use FIXNUM_BITS, as this simplifies things.
0de4bb68
PE
11343 (next_almost_prime, larger_vector, sxhash, hash_lookup, hash_put):
11344 Adjust signatures to match updated version of code.
11345 (consing_since_gc): Now EMACS_INT, since a single hash table can
11346 use more than INT_MAX bytes.
11347
698d32e2
DN
113482011-06-01 Dan Nicolaescu <dann@ics.uci.edu>
11349
11350 Make it possible to build with GCC-4.6+ -O2 -flto.
11351
11352 * emacs.c (__malloc_initialize_hook): Mark as EXTERNALLY_VISIBLE.
11353
fd6fa53f
SM
113542011-06-01 Stefan Monnier <monnier@iro.umontreal.ca>
11355
11356 * minibuf.c (get_minibuffer, read_minibuf_unwind):
11357 Call minibuffer-inactive-mode.
11358
864db017
JB
113592011-05-31 Juanma Barranquero <lekktu@gmail.com>
11360
11361 * makefile.w32-in ($(BLD)/data.$(O), $(BLD)/editfns.$(O)):
11362 Update dependencies.
11363
2ad0baf4
DN
113642011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
11365
11366 * data.c (init_data): Remove code for UTS, this system is not
11367 supported anymore.
11368
4fcc2638
DN
113692011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
11370
11371 Don't force ./temacs to start in terminal mode.
11372
11373 * frame.c (make_initial_frame): Initialize faces in all cases, not
11374 only when CANNOT_DUMP is defined.
11375 * dispnew.c (init_display): Remove CANNOT_DUMP condition.
11376
c56e0fd5
DN
113772011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
11378
11379 * dispnew.c (add_window_display_history): Use const for the string
11380 pointer. Remove declaration, not needed.
11381
333d54da 113822011-05-31 Paul Eggert <eggert@cs.ucla.edu>
9cf9f756 11383
55d4c1b2 11384 Use 'inline', not 'INLINE'.
333d54da 11385 <http://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00914.html>
55d4c1b2
PE
11386 * alloc.c, fontset.c (INLINE): Remove.
11387 * alloc.c, bidi.c, charset.c, coding.c, dispnew.c, fns.c, image.c:
11388 * intervals.c, keyboard.c, process.c, syntax.c, textprop.c, w32term.c:
11389 * xdisp.c, xfaces.c, xterm.c: Replace all uses of INLINE with inline.
11390 * gmalloc.c (register_heapinfo): Use inline unconditionally.
11391 * lisp.h (LISP_MAKE_RVALUE): Use inline, not __inline__.
11392
738db178
DN
113932011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
11394
11395 Make it possible to run ./temacs.
11396
11397 * callproc.c (set_initial_environment): Remove CANNOT_DUMP code,
11398 syms_of_callproc does the same thing. Remove test for
11399 "initialized", do it in the caller.
11400 * emacs.c (main): Avoid calling set_initial_environment when dumping.
11401
620c53a6
SM
114022011-05-31 Stefan Monnier <monnier@iro.umontreal.ca>
11403
11404 * minibuf.c (Finternal_complete_buffer): Return `category' metadata.
11405 (read_minibuf): Use get_minibuffer.
11406 (syms_of_minibuf): Use DEFSYM.
11407 (Qmetadata): New var.
11408 * data.c (Qbuffer): Don't make it static.
11409 (syms_of_data): Use DEFSYM.
11410
e003a292
PE
114112011-05-31 Paul Eggert <eggert@cs.ucla.edu>
11412
11413 * ccl.c (CCL_CODE_RANGE): Allow negative numbers. (Bug#8751)
11414 (CCL_CODE_MIN): New macro.
11415
ed008a6d
PE
114162011-05-30 Paul Eggert <eggert@cs.ucla.edu>
11417
3687c2ef
PE
11418 * alloc.c (lisp_align_malloc): Omit unnecessary val==NULL tests.
11419
ed008a6d
PE
11420 * eval.c (Qdebug): Now static.
11421 * lisp.h (Qdebug): Remove decl. This reverts a part of the
11422 2011-04-26T11:26:05Z!dan.colascione@gmail.com that inadvertently undid part of
11423 2011-04-14T06:48:41Z!eggert@cs.ucla.edu.
11424
d66c4c7c
CY
114252011-05-29 Chong Yidong <cyd@stupidchicken.com>
11426
11427 * image.c: Various fixes to ImageMagick code comments.
11428 (Fimagemagick_types): Doc fix.
11429
5fbc2025
PE
114302011-05-29 Paul Eggert <eggert@cs.ucla.edu>
11431
0196f88a
PE
11432 Minor fixes prompted by GCC 4.6.0 warnings.
11433
11434 * xselect.c (converted_selections, conversion_fail_tag): Now static.
11435
5fbc2025
PE
11436 * emacs.c [HAVE_X_WINDOWS]: Include "xterm.h".
11437 (x_clipboard_manager_save_all): Move extern decl to ...
11438 * xterm.h: ... here, so that it can be checked for consistency.
11439
1dd3c2d9
CY
114402011-05-29 Chong Yidong <cyd@stupidchicken.com>
11441
11442 * xselect.c (x_clipboard_manager_save_frame)
11443 (x_clipboard_manager_save_all): New functions.
11444 (Fx_clipboard_manager_save): Lisp function deleted.
11445
11446 * emacs.c (Fkill_emacs): Call x_clipboard_manager_save_all.
11447 * frame.c (delete_frame): Call x_clipboard_manager_save_frame.
11448
11449 * xterm.h: Update prototype.
11450
5ba6571d
WX
114512011-05-28 William Xu <william.xwl@gmail.com>
11452
11453 * nsterm.m (ns_term_shutdown): Synchronize user defaults before
11454 exiting (Bug#8239).
11455
3eaff834
JM
114562011-05-28 Jim Meyering <meyering@redhat.com>
11457
e1900994 11458 Avoid a sign-extension bug in crypto_hash_function.
3eaff834
JM
11459 * fns.c (to_uchar): Define.
11460 (crypto_hash_function): Use it to convert some newly-signed
11461 variables to unsigned, to avoid sign-extension bugs. For example,
11462 without this change, (md5 "truc") would evaluate to
11463 45723a2aff78ff4fff7fff1114760e62 rather than the expected
11464 45723a2af3788c4ff17f8d1114760e62. Reported by Antoine Levitt in
e1900994 11465 https://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00883.html.
3eaff834 11466
0f6990a7
PE
114672011-05-27 Paul Eggert <eggert@cs.ucla.edu>
11468
11469 Integer overflow fixes.
c8a9ca5a 11470
08686060
PE
11471 * dbusbind.c: Serial number integer overflow fixes.
11472 (CHECK_DBUS_SERIAL_GET_SERIAL): New macro.
08686060
PE
11473 (Fdbus_call_method_asynchronously, xd_read_message_1): Use a float
11474 to hold a serial number that is too large for a fixnum.
11475 (Fdbus_method_return_internal, Fdbus_method_error_internal):
11476 Check for serial numbers out of range. Decode any serial number
59568bf0 11477 that was so large that it became a float. (Bug#8722)
08686060 11478
2d1fc3c7
PE
11479 * dbusbind.c: Use XFASTINT rather than XUINT, and check for nonneg.
11480 (Fdbus_call_method, Fdbus_call_method_asynchronously):
11481 Use XFASTINT rather than XUINT when numbers are nonnegative.
11482 (xd_append_arg, Fdbus_method_return_internal):
11483 (Fdbus_method_error_internal): Likewise. Also, for unsigned
11484 arguments, check that Lisp number is nonnegative, rather than
59568bf0 11485 silently wrapping negative numbers around. (Bug#8722)
30217ff0 11486 (xd_read_message_1): Don't assume dbus_uint32_t can fit in int.
59568bf0 11487 (Bug#8722)
2d1fc3c7 11488
c8a9ca5a
PE
11489 * data.c (arith_driver, Flsh): Avoid unnecessary casts to EMACS_UINT.
11490
519e1d69
PE
11491 * ccl.c (ccl_driver): Redo slightly to avoid the need for 'unsigned'.
11492
6df6ae42 11493 ccl: Add integer overflow checks.
30569699
PE
11494 * ccl.c (CCL_CODE_MAX, GET_CCL_RANGE, GET_CCL_CODE, GET_CCL_INT):
11495 (IN_INT_RANGE): New macros.
11496 (ccl_driver): Use them to check for integer overflow when
11497 decoding a CCL program. Many of the new checks are whether XINT (x)
11498 fits in int; it doesn't always, on 64-bit hosts. The new version
11499 doesn't catch all possible integer overflows, but it's an
847044ea 11500 improvement. (Bug#8719)
30569699 11501
c11285dc
PE
11502 * alloc.c (make_event_array): Use XINT, not XUINT.
11503 There's no need for unsigned here.
11504
fdccd48e
PE
11505 * mem-limits.h (EXCEEDS_LISP_PTR) [!USE_LSB_TAG]: EMACS_UINT -> uintptr_t
11506 This follows up to the 2011-05-06 change that substituted uintptr_t
11507 for EMACS_INT. This case wasn't caught back then.
11508
37910ab2
PE
11509 Rework Fformat to avoid integer overflow issues.
11510 * editfns.c: Include <float.h> unconditionally, as it's everywhere
11511 now (part of C89). Include <verify.h>.
11512 (MAX_10_EXP, CONVERTED_BYTE_SIZE): Remove; no longer needed.
11513 (pWIDE, pWIDElen, signed_wide, unsigned_wide): New defns.
11514 (Fformat): Avoid the prepass trying to compute sizes; it was only
11515 approximate and thus did not catch overflow reliably. Instead, walk
11516 through the format just once, formatting and computing sizes as we go,
11517 checking for integer overflow at every step, and allocating a larger
11518 buffer as needed. Keep track separately whether the format is
11519 multibyte. Keep only the most-recently calculated precision, rather
11520 than them all. Record whether each argument has been converted to
11521 string. Use EMACS_INT, not int, for byte and char and arg counts.
11522 Support field widths and precisions larger than INT_MAX. Avoid
11523 sprintf's undefined behavior with conversion specifications such as %#d
11524 and %.0c. Fix bug with strchr succeeding on '\0' when looking for
11525 flags. Fix bug with (format "%c" 256.0). Avoid integer overflow when
11526 formatting out-of-range floating point numbers with int
9173deec 11527 formats. (Bug#8668)
37910ab2 11528
2e6578fb
PE
11529 * lisp.h (FIXNUM_OVERFLOW_P): Work even if arg is a NaN.
11530
0ae6bdee
PE
11531 * data.c: Avoid integer truncation in expressions involving floats.
11532 * data.c: Include <intprops.h>.
11533 (arith_driver): When there's an integer overflow in an expression
11534 involving floating point, convert the integers to floating point
11535 so that the resulting value does not suffer from catastrophic
11536 integer truncation. For example, on a 64-bit host (* 4
11537 most-negative-fixnum 0.5) should yield about -4.6e+18, not zero.
11538 Do not rely on undefined behavior after integer overflow.
11539
de883a70
PE
11540 merge count_size_as_multibyte, parse_str_to_multibyte
11541 * character.c, character.h (count_size_as_multibyte):
fd6fa53f 11542 Rename from parse_str_to_multibyte; all uses changed.
de883a70
PE
11543 Check for integer overflow.
11544 * insdel.c, lisp.h (count_size_as_multibyte): Remove,
11545 since it's now a duplicate of the other. This is more of
11546 a character than a buffer op, so better that it's in character.c.
11547 * fns.c, print.c: Adjust to above changes.
11548
2ff916cb
PE
115492011-05-27 Stefan Monnier <monnier@iro.umontreal.ca>
11550
11551 * xselect.c (x_convert_selection): Yet another int/Lisp_Object mixup.
11552
f1b54466
PE
115532011-05-27 Paul Eggert <eggert@cs.ucla.edu>
11554
fb1ac845
PE
11555 * xselect.c: Fix minor problems prompted by GCC 4.6.0 warnings.
11556 (x_handle_selection_request, frame_for_x_selection): Remove unused vars.
11557 (x_clipboard_manager_save): Now static.
11558 (Fx_clipboard_manager_save): Rename local to avoid shadowing.
11559
f1b54466
PE
11560 * fns.c: Fix minor problems prompted by GCC 4.6.0 warnings.
11561 (crypto_hash_function): Now static.
11562 Fix pointer signedness problems. Avoid unnecessary initializations.
11563
a9f737ee
CY
115642011-05-27 Chong Yidong <cyd@stupidchicken.com>
11565
11566 * termhooks.h (Vselection_alist): Make it terminal-local.
11567
11568 * terminal.c (create_terminal): Initialize it.
11569
11570 * xselect.c: Support for clipboard managers.
11571 (Vselection_alist): Move to termhooks.h as terminal-local var.
11572 (LOCAL_SELECTION): New macro.
11573 (x_atom_to_symbol): Handle x_display_info_for_display fail case.
11574 (symbol_to_x_atom): Remove gratuitous arg.
11575 (x_handle_selection_request, lisp_data_to_selection_data)
11576 (x_get_foreign_selection, Fx_register_dnd_atom): Callers changed.
620c53a6
SM
11577 (x_own_selection, x_get_local_selection, x_convert_selection):
11578 New arg, specifying work frame. Use terminal-local Vselection_alist.
a9f737ee
CY
11579 (some_frame_on_display): Delete unused function.
11580 (Fx_own_selection_internal, Fx_get_selection_internal)
11581 (Fx_disown_selection_internal, Fx_selection_owner_p)
11582 (Fx_selection_exists_p): New optional frame arg.
11583 (frame_for_x_selection, Fx_clipboard_manager_save): New functions.
11584 (x_handle_selection_clear): Don't treat other terminals with the
11585 same keyboard specially. Use the terminal-local Vselection_alist.
11586 (x_clear_frame_selections): Use Frun_hook_with_args.
11587
11588 * xterm.c (x_term_init): Intern ATOM and CLIPBOARD_MANAGER atoms.
11589
11590 * xterm.h: Add support for those atoms.
11591
e067f0c1
CY
115922011-05-26 Chong Yidong <cyd@stupidchicken.com>
11593
11594 * xselect.c: ICCCM-compliant handling of MULTIPLE targets.
11595 (converted_selections, conversion_fail_tag): New global variables.
11596 (x_selection_request_lisp_error): Free the above.
11597 (x_get_local_selection): Remove unnecessary code.
11598 (x_reply_selection_request): Args changed; handle arbitrary array
620c53a6
SM
11599 of converted selections stored in converted_selections.
11600 Separate the XChangeProperty and SelectionNotify steps.
e067f0c1
CY
11601 (x_handle_selection_request): Rewrite to handle MULTIPLE target.
11602 (x_convert_selection): New function.
11603 (x_handle_selection_event): Simplify.
11604 (x_get_foreign_selection): Don't ignore incoming requests while
11605 waiting for an answer; this will fail when we implement
11606 SAVE_TARGETS, and seems unnecessary anyway.
11607 (selection_data_to_lisp_data): Recognize ATOM_PAIR type.
11608 (Vx_sent_selection_functions): Doc fix.
11609
0f4aebc0
LL
116102011-05-26 Leo Liu <sdl.web@gmail.com>
11611
11612 * editfns.c (Ftranspose_regions): Allow empty regions. (Bug#8699)
11613
e61124cd
YM
116142011-05-25 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
11615
11616 * dispextern.h (struct glyph_row): New member fringe_bitmap_periodic_p.
11617
11618 * dispnew.c (shift_glyph_matrix, scrolling_window): Mark scrolled row
11619 for fringe update if it has periodic bitmap.
ac389d0c 11620 (row_equal_p): Also compare left_fringe_offset, right_fringe_offset,
e61124cd
YM
11621 and fringe_bitmap_periodic_p.
11622
11623 * fringe.c (get_fringe_bitmap_data): New function.
11624 (draw_fringe_bitmap_1, update_window_fringes): Use it.
11625 (update_window_fringes): Record periodicity of fringe bitmap in glyph
11626 row. Mark glyph row for fringe update if periodicity changed.
11627
11628 * xdisp.c (try_window_reusing_current_matrix): Don't mark scrolled row
11629 for fringe update unless it has periodic bitmap.
11630
f16d9837
KH
116312011-05-25 Kenichi Handa <handa@m17n.org>
11632
11633 * xdisp.c (get_next_display_element): Set correct it->face_id for
11634 a static composition.
11635
e1b90ef6
LL
116362011-05-24 Leo Liu <sdl.web@gmail.com>
11637
11638 * deps.mk (fns.o):
11639 * makefile.w32-in ($(BLD)/fns.$(O)): Include sha1.h.
11640
11641 * fns.c (crypto_hash_function, Fsha1): New function.
11642 (Fmd5): Use crypto_hash_function.
11643 (syms_of_fns): Add Ssha1.
11644
7400048f
PE
116452011-05-22 Paul Eggert <eggert@cs.ucla.edu>
11646
11647 * gnutls.c: Remove unused macros.
11648 (fn_gnutls_transport_set_lowat, fn_gnutls_transport_set_pull_function):
11649 (fn_gnutls_transport_set_push_function) [!WINDOWSNT]:
11650 Remove macros that are defined and never used.
11651 Caught by gcc -Wunused-macros (GCC 4.6.0, Fedora 14).
11652
abb71cf4
CY
116532011-05-22 Chong Yidong <cyd@stupidchicken.com>
11654
11655 * xselect.c (syms_of_xselect): Remove unused symbol SAVE_TARGETS.
11656 (Fx_get_selection_internal): Minor cleanup.
11657 (Fx_own_selection_internal): Rename arguments for consistency with
11658 select.el.
11659
6307db39
PE
116602011-05-22 Paul Eggert <eggert@cs.ucla.edu>
11661
11662 * xselect.c (QSAVE_TARGETS): New static var, to fix build failure.
11663
f3d4e0a4
CY
116642011-05-22 Chong Yidong <cyd@stupidchicken.com>
11665
11666 * xselect.c (syms_of_xselect): Include character.h; use DEFSYM.
11667
4d8ade89
YM
116682011-05-21 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
11669
11670 * dispnew.c (scrolling_window): Don't exclude the case that the
11671 last enabled row in the desired matrix touches the bottom boundary.
11672
32078c8d
GM
116732011-05-21 Glenn Morris <rgm@gnu.org>
11674
11675 * Makefile.in ($(etc)/DOC): Make second command line even shorter.
33cf345f
GM
11676 (SOME_MACHINE_OBJECTS): Replace FONT_OBJ by its maximal expansion,
11677 and add some more files.
32078c8d 11678
7285dc67
EZ
116792011-05-20 Eli Zaretskii <eliz@gnu.org>
11680
11681 * callproc.c (Fcall_process) [MSDOS]: Fix arguments to
11682 report_file_error introduced by the change from 2011-05-07.
11683
89d1bd22
PE
116842011-05-20 Paul Eggert <eggert@cs.ucla.edu>
11685
11686 * systime.h (Time): Define only if emacs is defined.
11687 This is to allow ../lib-src/profile.c to be compiled on FreeBSD,
11688 where the include path doesn't have X11/X.h by default. See
11689 <http://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00561.html>.
11690
cd394be1 116912011-05-20 Kenichi Handa <handa@m17n.org>
31bfc35c
KH
11692
11693 * composite.c (find_automatic_composition): Fix previous change.
11694
b9704ad9
GM
116952011-05-20 Glenn Morris <rgm@gnu.org>
11696
11697 * lisp.mk: New file, split from Makefile.in.
11698 * Makefile.in (lisp): Move to separate file, inserted by @lisp_frag@.
11699 (shortlisp): Remove.
11700 ($(etc)/DOC): Edit lisp.mk rather than using $shortlisp.
11701
4a720484
GM
117022011-05-19 Glenn Morris <rgm@gnu.org>
11703
11704 * Makefile.in (MSDOS_SUPPORT_REAL, MSDOS_SUPPORT, NS_SUPPORT)
11705 (REAL_MOUSE_SUPPORT, GPM_MOUSE_SUPPORT, MOUSE_SUPPORT, TOOLTIP_SUPPORT)
11706 (BASE_WINDOW_SUPPORT, X_WINDOW_SUPPORT, WINDOW_SUPPORT): Remove.
11707 (lisp): Set the order to that of loadup.el.
11708 (shortlisp): Make it a copy of $lisp.
11709 (SOME_MACHINE_LISP): Remove.
11710 ($(etc)/DOC): Depend just on $lisp, not $SOME_MACHINE_LISP too.
11711 Use just $shortlisp, not $SOME_MACHINE_LISP too.
11712
a28d4396
KH
117132011-05-18 Kenichi Handa <handa@m17n.org>
11714
11715 * composite.c (CHAR_COMPOSABLE_P): Add more check for efficiency.
11716 (BACKWARD_CHAR): Wrap the arg STOP by parenthesis.
11717 (find_automatic_composition): Mostly rewrite for efficiency.
11718
a2b1fa8e
JB
117192011-05-18 Juanma Barranquero <lekktu@gmail.com>
11720
11721 * makefile.w32-in: Update dependencies.
11722
8e1f5610
CS
117232011-05-18 Christoph Scholtes <cschol2112@googlemail.com>
11724
11725 * menu.c: Include limits.h (fixes the MS-Windows build broken by
7d7d0045 11726 2011-06-18T18:49:19Z!cyd@stupidchicken.com).
8e1f5610 11727
7025ee00 117282011-05-18 Paul Eggert <eggert@cs.ucla.edu>
cb93f9be 11729
cdfa6eab
PE
11730 Fix some integer overflow issues, such as string length overflow.
11731
06d6db33
PE
11732 * insdel.c (count_size_as_multibyte): Check for string overflow.
11733
2b4560a8
PE
11734 * character.c (lisp_string_width): Check for string overflow.
11735 Use EMACS_INT, not int, for string indexes and lengths; in
11736 particular, 2nd arg is now EMACS_INT, not int. Do not crash if
11737 the resulting string length overflows an EMACS_INT; instead,
11738 report a string overflow if no precision given. When checking for
11739 precision exhaustion, use a check that cannot possibly have
11740 integer overflow. (Bug#8675)
11741 * character.h (lisp_string_width): Adjust to new signature.
11742
cb93f9be
PE
11743 * alloc.c (string_overflow): New function.
11744 (Fmake_string): Use it. This doesn't change behavior, but saves
11745 a few bytes and will simplify future changes.
11746 * character.c (string_escape_byte8): Likewise.
11747 * lisp.h (string_overflow): New decl.
11748
1a1f3366
PE
11749 Fixups, following up to the user-interface timestamp change.
11750 * nsterm.m (last_mouse_movement_time, ns_mouse_position): Use Time
11751 for UI timestamps, instead of unsigned long.
9fbd6841
PE
11752 * msdos.c (mouse_get_pos): Likewise.
11753 * w32inevt.c (movement_time, w32_console_mouse_position): Likewise.
1a1f3366
PE
11754 * w32gui.h (Time): Define by including "systime.h" rather than by
11755 declaring it ourselves. (Bug#8664)
11756
d4e3e4d3
PE
11757 * dispextern.h (struct image): Don't assume time_t <= unsigned long.
11758 * image.c (clear_image_cache): Likewise.
11759
f6a24d19
PE
11760 * term.c (term_mouse_position): Don't assume time_t wraparound.
11761
08dc5ae6
PE
11762 Be more systematic about user-interface timestamps.
11763 Before, the code sometimes used 'Time', sometimes 'unsigned long',
620c53a6
SM
11764 and sometimes 'EMACS_UINT', to represent these timestamps.
11765 This change causes it to use 'Time' uniformly, as that's what X uses.
08dc5ae6
PE
11766 This makes the code easier to follow, and makes it easier to catch
11767 integer overflow bugs such as Bug#8664.
11768 * frame.c (Fmouse_position, Fmouse_pixel_position):
11769 Use Time, not unsigned long, for user-interface timestamps.
11770 * keyboard.c (last_event_timestamp, kbd_buffer_get_event): Likewise.
11771 (button_down_time, make_lispy_position, make_lispy_movement): Likewise.
11772 * keyboard.h (last_event_timestamp): Likewise.
11773 * menu.c (Fx_popup_menu) [!HAVE_X_WINDOWS]: Likewise.
11774 * menu.h (xmenu_show): Likewise.
11775 * term.c (term_mouse_position): Likewise.
11776 * termhooks.h (struct input_event.timestamp): Likewise.
11777 (struct terminal.mouse_position_hook): Likewise.
11778 * xmenu.c (create_and_show_popup_menu, xmenu_show): Likewise.
11779 * xterm.c (XTmouse_position, x_scroll_bar_report_motion): Likewise.
11780 * systime.h (Time): New decl. Pull it in from <X11/X.h> if
11781 HAVE_X_WINDOWS, otherwise define it as unsigned long, which is
11782 what it was before.
11783 * menu.h, termhooks.h: Include "systime.h", for Time.
11784
8e55734a
PE
11785 * keyboard.c (make_lispy_event): Fix problem in integer overflow.
11786 Don't assume that the difference between two unsigned long values
11787 can fit into an integer. At this point, we know button_down_time
11788 <= event->timestamp, so the difference must be nonnegative, so
11789 there's no need to cast the result if double-click-time is
11790 nonnegative, as it should be; check that it's nonnegative, just in
11791 case. This bug is triggered when events are more than 2**31 ms
86db42d2 11792 apart (about 25 days). (Bug#8664)
8e55734a 11793
841f1b75 11794 * xselect.c (last_event_timestamp): Remove duplicate decl.
6434756c 11795 (x_own_selection): Remove needless cast to unsigned long.
841f1b75 11796
3e26f69c
PE
11797 * xmenu.c (set_frame_menubar): Use int, not EMACS_UINT, for indexes
11798 that always fit in int. Use a sentinel instead of a counter, to
11799 avoid a temp and to allay GCC's concerns about possible int overflow.
d230cb74
PE
11800 * frame.h (struct frame): Use int for menu_bar_items_used
11801 instead of EMACS_INT, since it always fits in int.
3e26f69c 11802
5cc152c0
PE
11803 * menu.c (grow_menu_items): Check for int overflow.
11804
d89eb65e
PE
11805 * xmenu.c (set_frame_menubar): Don't mishandle vectors with no nils.
11806
5235bd3e
PE
11807 * xterm.c: Use EMACS_INT for Emacs modifiers, and int for X modifiers.
11808 Before, the code was not consistent. These values cannot exceed
11809 2**31 - 1 so there's no need to make them unsigned.
11810 (x_x_to_emacs_modifiers): Accept int and return EMACS_INT.
11811 (x_emacs_to_x_modifiers): Accept EMACS_INT and return int.
11812 (x_x_to_emacs_modifiers, x_emacs_to_x_modifiers): Reject non-integers
11813 as modifiers.
11814 * xterm.h (x_x_to_emacs_modifiers): Adjust to signature change.
11815
bc827e23
PE
11816 * lisp.h (XINT) [USE_LISP_UNION_TYPE]: Cast to EMACS_INT.
11817 (XUINT) [USE_LISP_UNION_TYPE]: Cast to EMACS_UINT.
11818 Otherwise, GCC 4.6.0 warns about printf (pI, XINT (...)),
11819 presumably because the widths might not match.
11820
78eb494e
PE
11821 * window.c (size_window): Avoid needless test at loop start.
11822
04f2d78b
CB
118232011-05-18 Courtney Bane <emacs-bugs-7626@cbane.org> (tiny change)
11824
11825 * term.c (Fresume_tty): Restore hooks before reinitializing (bug#8687).
11826
d2fc7e3d 118272011-05-12 Drew Adams <drew.adams@oracle.com>
e531bdff
DA
11828
11829 * textprop.c (Fprevious_single_char_property_change): Doc fix (bug#8655).
11830
d2fc7e3d 118312011-05-12 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
7db47798
YM
11832
11833 * w32term.c (w32_draw_fringe_bitmap): Rename local vars `left' and
11834 `width' to `bar_area_x' and `bar_area_width', respectively.
11835 (x_scroll_run): Take account of fringe background extension.
11836
04f2d78b
CB
11837 * xterm.c (x_draw_fringe_bitmap) [USE_TOOLKIT_SCROLL_BARS]:
11838 Rename local vars `left' and `width' to `bar_area_x' and
7db47798
YM
11839 `bar_area_width', respectively.
11840 (x_scroll_run) [USE_TOOLKIT_SCROLL_BARS]: Take account of fringe
11841 background extension.
11842
79b70037
GM
118432011-05-10 Jim Meyering <meyering@redhat.com>
11844
11845 * xdisp.c (x_intersect_rectangles): Fix typo "the the -> the".
11846
2f142cc5
JB
118472011-05-10 Juanma Barranquero <lekktu@gmail.com>
11848
11849 * image.c (Finit_image_library): Return t for built-in image types,
11850 like pbm and xbm. (Bug#8640)
11851
57679c86
AS
118522011-05-09 Andreas Schwab <schwab@linux-m68k.org>
11853
11854 * w32menu.c (set_frame_menubar): Fix submenu allocation.
11855
888c9e86
EZ
118562011-05-07 Eli Zaretskii <eliz@gnu.org>
11857
b0512a1d
EZ
11858 * w32console.c (Fset_screen_color): Doc fix.
11859 (Fget_screen_color): New function.
11860 (syms_of_ntterm): Defsubr it.
11861
7285dc67
EZ
11862 * callproc.c (call_process_cleanup) [MSDOS]: Don't close and
11863 unlink the temporary file if Fcall_process didn't create it in the
11864 first place.
11865 (Fcall_process) [MSDOS]: Don't create tempfile if stdout of the
11866 child process will be redirected to a file specified with `:file'.
888c9e86
EZ
11867 Don't try to re-open tempfile in that case, and set fd[0] to -1 as
11868 cue to call_process_cleanup not to close that handle.
11869
4d3fcc8e
BK
118702011-05-07 Ben Key <bkey76@gmail.com>
11871
11872 * makefile.w32-in: The bootstrap-temacs rule now makes use of
11873 one of two shell specific rules, either bootstrap-temacs-CMD or
11874 bootstrap-temacs-SH. The bootstrap-temacs-SH rule is identical
11875 to the previous implementation of the bootstrap-temacs rule.
11876 The bootstrap-temacs-CMD rule is similar to the previous
11877 implementation of the bootstrap-temacs rule except that it
11878 makes use of the ESC_CFLAGS variable instead of the CFLAGS
11879 variable.
11880
11881 These changes, along with some changes to nt/configure.bat,
11882 nt/gmake.defs, and nt/nmake.defs, are required to extend my
11883 earlier fix to add support for --cflags and --ldflags options
11884 that include quotes so that it works whether make uses cmd or
11885 sh as the shell.
11886
b4289b64
MA
118872011-05-06 Michael Albinus <michael.albinus@gmx.de>
11888
11889 * dbusbind.c (QCdbus_type_unix_fd): Declare static.
11890 (xd_remove_watch): Don't check QCdbus_type_unix_fd for SYMBOLP, it
11891 is a constant.
11892 (Fdbus_init_bus, xd_read_queued_messages): Bus can be a symbol or
11893 a string. Handle both cases.
11894 (Fdbus_call_method_asynchronously, Fdbus_register_signal)
11895 (Fdbus_register_method): Use Qinvalid_function.
11896
af4c0e28
JB
118972011-05-06 Juanma Barranquero <lekktu@gmail.com>
11898
11899 * makefile.w32-in: Update dependencies.
11900 (LISP_H): Add inttypes.h and stdin.h.
11901 (PROCESS_H): Add unistd.h.
11902
c51453d9
EZ
119032011-05-06 Eli Zaretskii <eliz@gnu.org>
11904
11905 * lread.c: Include limits.h (fixes the MS-Windows build broken by
11906 2011-05-06T07:13:19Z!eggert@cs.ucla.edu).
11907
8ff0ac3c 119082011-05-06 Paul Eggert <eggert@cs.ucla.edu>
c032b5f8 11909
4c4b566b
PE
11910 * image.c (Finit_image_library) [!HAVE_NTGUI]: Omit unused local.
11911
aab2b9b5
PE
11912 * term.c (vfatal): Remove stray call to va_end.
11913 It's not needed and the C Standard doesn't allow it here anyway.
11914
c378da0b
PE
11915 Use C99's va_copy to avoid undefined behavior on x86-64 GNU/Linux.
11916 * eval.c (verror): doprnt a copy of ap, not the original. (Bug#8545)
11917
288b08c7
PE
11918 * eval.c (verror): OK to create a string of up to MOST_POSITIVE_FIXNUM
11919 bytes.
11920
e3601888
PE
11921 * term.c: Don't include <stdarg.h>, as <lisp.h> does that.
11922
db6c0e74
PE
11923 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork clobbering.
11924
dd5963ea
PE
11925 * process.c (Fformat_network_address): Fix typo: args2 -> *args2.
11926
88c9450f
PE
11927 * xmenu.c (set_frame_menubar): Fix typo: int * -> int (3 times).
11928
2f9442b8
PE
11929 * coding.c (detect_coding_charset): Fix typo: * 2 -> *4 (Bug#8601).
11930
c032b5f8
PE
11931 * charset.h (struct charset.code_space): Now has 15 elements, not 16.
11932 * charset.c (Fdefine_charset_internal): Don't initialize
11933 charset.code_space[15]. The value was garbage, on hosts with
2d38271b 11934 32-bit int (Bug#8600).
a108c10b
PE
11935
11936 * lread.c (read_integer): Be more consistent with string-to-number.
11937 Use string_to_number to do the actual conversion; this avoids
11938 rounding errors and fixes some other screwups. Without this fix,
11939 for example, #x1fffffffffffffff was misread as -2305843009213693952.
11940 (digit_to_number): Move earlier, for benefit of read_integer.
11941 Return -1 if the digit is out of range for the base, -2 if it is
48e400f0 11942 not a digit in any supported base. (Bug#8602)
a108c10b 11943
ad5f9eea
PE
11944 * doprnt.c (doprnt): Support arbitrary pI values, such as "I64".
11945
aec1708a
PE
11946 * dispnew.c (scrolling_window): Return 1 if we scrolled,
11947 to match comment at start of function. This also removes a
11948 GCC warning about overflow in a 32+64-bit port.
11949
47be4ab5
PE
11950 * lisp.h (EMACS_INT, EMACS_UINT, BITS_PER_EMACS_INT, pI): Simplify.
11951
371cac43
PE
11952 * dbusbind.c: Do not use XPNTR on a value that may be an integer.
11953 Reported by Stefan Monnier in
11954 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00919.html>.
04f2d78b
CB
11955 (xd_remove_watch, Fdbus_init_bus, xd_read_queued_messages):
11956 Use SYMBOLP-guarded XSYMBOL, not XPNTR.
371cac43 11957
d01a7826
PE
11958 * lisp.h (EMACS_INTPTR): Remove. All uses changed to intptr_t.
11959 (EMACS_UINTPTR): Likewise, with uintptr_t.
11960
7fd47d5c
PE
11961 * lisp.h: Prefer 64-bit EMACS_INT if available.
11962 (EMACS_INT, EMACS_UINT, BITS_PER_EMACS_INT, pI): Define to 64-bit
11963 on 32-bit hosts that have 64-bit int, so that they can access
11964 large files.
122b0c86
PE
11965 However, temporarily disable this change unless the temporary
11966 symbol WIDE_EMACS_INT is defined.
7fd47d5c 11967
8727937b
PE
11968 * lread.c, process.c: Do not include <inttypes.h>; lisp.h does it now.
11969
8ac068ac
PE
11970 Prefer intptr_t/uintptr_t for integers the same widths as pointers.
11971 This removes an assumption that EMACS_INT and long are the same
11972 width as pointers. The assumption is true for Emacs porting targets
11973 now, but we want to make other targets possible.
11974 * lisp.h: Include <inttypes.h>, for INTPTR_MAX, UINTPTR_MAX.
11975 (EMACS_INTPTR, EMACS_UINTPTR): New macros.
11976 In the rest of the code, change types of integers that hold casted
11977 pointers to EMACS_INTPTR and EMACS_UINTPTR, systematically
11978 replacing EMACS_INT, long, EMACS_UINT, and unsigned long.
11979 (XTYPE): Don't cast arg to EMACS_UINT; normally is not needed.
11980 (XSET): Cast type of XTYPE arg to EMACS_INTPTR; it is needed here.
11981 No need to cast type when ORing.
11982 (XPNTR): Return a value of type EMACS_INTPTR or EMACS_UINTPTR.
11983 * alloc.c (lisp_align_malloc): Remove a no-longer-needed cast.
11984 * doc.c (store_function_docstring): Use EMACS_INTPTR, so as not to
11985 assume EMACS_INT is the same width as char *.
11986 * gtkutil.c (xg_gtk_scroll_destroy, xg_tool_bar_button_cb):
11987 (xg_tool_bar_callback, xg_tool_bar_help_callback, xg_make_tool_item):
11988 Remove no-longer-needed casts.
11989 (xg_create_scroll_bar, xg_tool_bar_button_cb, xg_tool_bar_callback):
11990 (xg_tool_bar_help_callback, xg_make_tool_item):
11991 Use EMACS_INTPTR to hold an integer
11992 that will be cast to void *; this can avoid a GCC warning
11993 if EMACS_INT is not the same width as void *.
11994 * menu.c (find_and_call_menu_selection): Remove no-longer-needed cast.
11995 * xdisp.c (display_echo_area_1, resize_mini_window_1):
11996 (current_message_1, set_message_1):
11997 Use a local to convert to proper width without a cast.
11998 * xmenu.c (dialog_selection_callback): Likewise.
11999
ede49d71
PE
12000 * sysdep.c (get_random): Don't assume EMACS_INT is no wider than long.
12001 Also, don't assume VALBITS / RAND_BITS is less than 5,
12002 and don't rely on undefined behavior when shifting a 1 left into
12003 the sign bit.
12004 * lisp.h (get_random): Change signature to match.
12005
2f30ecd0
PE
12006 * lread.c (hash_string): Use size_t, not int, for hash computation.
12007 Normally we prefer signed values; but hashing is special, because
12008 it's better to use unsigned division on hash table sizes so that
12009 the remainder is nonnegative. Also, size_t is the natural width
12010 for hashing into memory. The previous code used 'int', which doesn't
12011 retain enough info to hash well into very large tables.
12012 (oblookup, oblookup_last_bucket_number, Funintern): Likewise.
12013
2a866e7b
PE
12014 * dbusbind.c: Don't possibly lose pointer info when converting.
12015 (xd_remove_watch, Fdbus_init_bus, xd_read_queued_messages):
12016 Use XPNTR rather than XHASH, so that the high-order bits of
12017 the pointer aren't lost when converting through void *.
12018
51639eac
PE
12019 * eval.c (Fautoload): Don't double-shift a pointer.
12020
92394119
PE
12021 * fns.c (Frandom): Let EMACS_UINT be wider than unsigned long.
12022
dbdb9a7c
JB
120232011-05-06 Juanma Barranquero <lekktu@gmail.com>
12024
12025 * gnutls.c (DEF_GNUTLS_FN):
12026 * image.c (DEF_IMGLIB_FN): Make function pointers static.
12027
db7a0b4f
AS
120282011-05-05 Andreas Schwab <schwab@linux-m68k.org>
12029
12030 * lread.c (lisp_file_lexically_bound_p): Stop scanning at end
12031 marker. (Bug#8610)
12032
cd394be1 120332011-05-05 Eli Zaretskii <eliz@gnu.org>
fab624aa
EZ
12034
12035 * w32heap.c (allocate_heap) [USE_LISP_UNION_TYPE || USE_LSB_TAG]:
12036 New version that can reserve upto 2GB of heap space.
12037
f7ff1b0f 120382011-05-05 Chong Yidong <cyd@stupidchicken.com>
45cb8994
CY
12039
12040 * nsfns.m (Fns_read_file_name): Doc fix (Bug#8534).
12041
639c109b
TZ
120422011-05-05 Teodor Zlatanov <tzz@lifelogs.com>
12043
12044 * gnutls.c (fn_gnutls_certificate_set_x509_key_file): Add alias to
12045 `gnutls_certificate_set_x509_key_file'.
12046
d2127135
JB
120472011-05-05 Juanma Barranquero <lekktu@gmail.com>
12048
12049 * makefile.w32-in ($(BLD)/image.$(O), $(BLD)/process.$(O)):
12050 Update dependencies.
12051
e968f4f3
JB
120522011-05-04 Juanma Barranquero <lekktu@gmail.com>
12053
12054 * gnutls.h (emacs_gnutls_write, emacs_gnutls_read):
12055 * gnutls.c (emacs_gnutls_write, emacs_gnutls_read):
12056 Remove unused parameter `fildes'.
12057 * process.c (read_process_output, send_process): Don't pass it.
12058
84d358f0
JB
120592011-05-04 Juanma Barranquero <lekktu@gmail.com>
12060
12061 Fix previous change: the library cache is defined in w32.c.
12062 * image.c (CACHE_IMAGE_TYPE) [!HAVE_NTGUI]: Define to noop.
12063 (Finit_image_library): Wrap Vlibrary_cache on "#ifdef HAVE_NTGUI".
12064
0898ca10
JB
120652011-05-04 Juanma Barranquero <lekktu@gmail.com>
12066
12067 Implement dynamic loading of GnuTLS on Windows.
12068
12069 * gnutls.h (GNUTLS_EMACS_ERROR_NOT_LOADED): New macro.
12070 (emacs_gnutls_write, emacs_gnutls_read): Mark as extern.
12071 (emacs_gnutls_record_check_pending, emacs_gnutls_transport_set_errno):
12072 Declare.
12073
12074 * gnutls.c (Qgnutls_dll): Define.
12075 (DEF_GNUTLS_FN, LOAD_GNUTLS_FN): New macros.
12076 (gnutls_*): Declare function pointers.
12077 (init_gnutls_functions): New function to initialize function pointers.
12078 (emacs_gnutls_handshake, Fgnutls_error_string, Fgnutls_deinit)
12079 (emacs_gnutls_global_init, Fgnutls_bye): Use function pointers.
12080 (emacs_gnutls_record_check_pending, emacs_gnutls_transport_set_errno):
12081 Wrappers for gnutls_record_check_pending and gnutls_transport_set_errno.
12082 (emacs_gnutls_write, emacs_gnutls_read)
12083 (emacs_gnutls_handle_error, Fgnutls_error_fatalp)
12084 (Fgnutls_available_p): New function.
12085 (Fgnutls_boot): Call Fgnutls_available_p. Use function pointers.
12086 (syms_of_gnutls) <Qgnutls_dll>: Initialize and staticpro it.
12087 (syms_of_gnutls) <Sgnutls_available_p>: defsubr it.
12088
12089 * image.c: Include w32.h.
12090 (Vimage_type_cache): Delete.
12091 (syms_of_image) <Vimage_type_cache>: Don't initialize and staticpro it.
12092 (CACHE_IMAGE_TYPE, Finit_image_library): Use Vlibrary_cache instead.
12093 (w32_delayed_load): Move to w32.c.
12094
12095 * w32.h (VlibraryCache, QCloaded_from, w32_delayed_load): Declare.
12096
12097 * w32.c (QCloaded_from, Vlibrary_cache): Define.
12098 (w32_delayed_load): Move from image.c. When loading a library, record
12099 its filename in the :loaded-from property of the library id.
12100 (globals_of_w32) <QCloaded_from, Vlibrary_cache>:
12101 Initialize and staticpro them.
12102 (emacs_gnutls_pull, emacs_gnutls_push): Call emacs_gnutls_* functions.
12103
12104 * process.c: Include lisp.h before w32.h, not after.
12105 (wait_reading_process_output): Call emacs_gnutls_record_check_pending
12106 instead of gnutls_record_check_pending.
12107
12108 * callproc.c, emacs.c: Include lisp.h before w32.h, not after.
12109
ff4de4aa
TZ
121102011-05-04 Teodor Zlatanov <tzz@lifelogs.com>
12111
12112 * gnutls.c (Fgnutls_boot): Support :keylist and :crlfiles options
12113 instead of :keyfiles. Give GnuTLS the keylist and the CRL lists
12114 as passed in.
12115
abe95abb
JD
121162011-05-03 Jan Djärv <jan.h.d@swipnet.se>
12117
12118 * xterm.c (x_set_frame_alpha): Do not set property on anything
12119 else than FRAME_X_OUTER_WINDOW (Bug#8608).
12120
e16e55d4
JB
121212011-05-02 Juanma Barranquero <lekktu@gmail.com>
12122
12123 * sysdep.c (get_tty_size) [WINDOWSNT]: Implement. (Bug#8596)
12124
bafcf6a5
JB
121252011-05-02 Juanma Barranquero <lekktu@gmail.com>
12126
12127 * gnutls.c (Qgnutls_log_level, Qgnutls_code, Qgnutls_anon)
12128 (Qgnutls_x509pki, Qgnutls_e_interrupted, Qgnutls_e_again)
12129 (Qgnutls_e_invalid_session, Qgnutls_e_not_ready_for_handshake)
12130 (gnutls_global_initialized, Qgnutls_bootprop_priority)
12131 (Qgnutls_bootprop_trustfiles, Qgnutls_bootprop_keyfiles)
12132 (Qgnutls_bootprop_callbacks, Qgnutls_bootprop_loglevel)
12133 (Qgnutls_bootprop_hostname, Qgnutls_bootprop_verify_flags)
12134 (Qgnutls_bootprop_verify_error, Qgnutls_bootprop_verify_hostname_error)
12135 (Qgnutls_bootprop_callbacks_verify): Make static.
12136
e7a6747f
AS
121372011-05-01 Andreas Schwab <schwab@linux-m68k.org>
12138
19ed11ba
AS
12139 * callproc.c: Indentation fixup.
12140
e7a6747f 12141 * sysdep.c (wait_for_termination_1): Make static.
04f2d78b
CB
12142 (wait_for_termination, interruptible_wait_for_termination):
12143 Move after wait_for_termination_1.
e7a6747f 12144
1ef14cb4
LMI
121452011-05-01 Lars Magne Ingebrigtsen <larsi@gnus.org>
12146
12147 * sysdep.c (interruptible_wait_for_termination): New function
12148 which is like wait_for_termination, but allows keyboard
12149 interruptions.
12150
12151 * callproc.c (Fcall_process): Add (:file "file") as an option for
12152 the STDOUT buffer.
12153 (Fcall_process_region): Ditto.
12154
330d880c
EZ
121552011-04-30 Eli Zaretskii <eliz@gnu.org>
12156
8db90b73
EZ
12157 * dosfns.c (Fint86, Fdos_memget, Fdos_memput): Use `ASIZE (FOO)'
12158 rather than `XVECTOR (FOO)->size'.
12159
330d880c
EZ
12160 * process.c: Remove HAVE_INTTYPES_H condition from inclusion of
12161 inttypes.h, as a gnulib replacement is used if it not available in
12162 system headers.
12163
15cbd324
EZ
121642011-04-21 Eli Zaretskii <eliz@gnu.org>
12165
12166 Lift the MOST_POSITIVE_FIXNUM/4 limitation on visited files.
12167 * fileio.c (Finsert_file_contents): Don't limit file size to 1/4
12168 of MOST_POSITIVE_FIXNUM. (Bug#8528)
12169
12170 * coding.c (coding_alloc_by_realloc): Error out if destination
12171 will grow beyond MOST_POSITIVE_FIXNUM.
12172 (decode_coding_emacs_mule): Abort if there isn't enough place in
12173 charbuf for the composition carryover bytes. Reserve an extra
12174 space for up to 2 characters produced in a loop.
12175 (decode_coding_iso_2022): Abort if there isn't enough place in
12176 charbuf for the composition carryover bytes.
12177
121782011-04-21 Eli Zaretskii <eliz@gnu.org>
afda1437 12179
ae940cca
EZ
12180 * doprnt.c (doprnt) [!HAVE_LONG_LONG_INT]: Error out instead of
12181 aborting when %lld or %lll format is passed.
12182 [!HAVE_UNSIGNED_LONG_LONG_INT]: Error out instead of aborting when
12183 %llo or %llx format is passed. (Bug#8545)
12184
03ab8921
EZ
12185 * window.c (window_scroll_line_based): Use a marker instead of
12186 simple variables to record original value of point. (Bug#7952)
12187
afda1437
EZ
12188 * doprnt.c (doprnt): Fix the case where a multibyte sequence
12189 produced by %s or %c overflows available buffer space. (Bug#8545)
12190
f76dee0c
PE
121912011-04-28 Paul Eggert <eggert@cs.ucla.edu>
12192
12193 * doprnt.c (doprnt): Omit useless test; int overflow check (Bug#8545).
283cdbef 12194 (SIZE_MAX): Move defn after all includes, as they might #define it.
f76dee0c 12195
fdc5744d
JB
121962011-04-28 Juanma Barranquero <lekktu@gmail.com>
12197
12198 * w32.c (init_environment): Warn about defaulting HOME to C:\.
12199
638f053a
JB
122002011-04-28 Juanma Barranquero <lekktu@gmail.com>
12201
12202 * keyboard.c (Qdelayed_warnings_hook): Define.
12203 (command_loop_1): Run `delayed-warnings-hook'
12204 if Vdelayed_warnings_list is non-nil.
12205 (syms_of_keyboard) <delayed-warnings-hook>: DEFSYM it.
12206 (syms_of_keyboard) <delayed-warnings-list>: DEFVAR_LISP it.
12207
d178f871
EZ
122082011-04-28 Eli Zaretskii <eliz@gnu.org>
12209
12210 * doprnt.c (doprnt): Don't return value smaller than the buffer
12211 size if the message was truncated. (Bug#8545).
12212
b124fd93
JB
122132011-04-28 Juanma Barranquero <lekktu@gmail.com>
12214
12215 * w32fns.c (Fx_change_window_property, Fx_delete_window_property)
12216 (Fx_window_property): #if-0 the whole functions, not just the bodies.
12217
e810457d
PE
122182011-04-27 Paul Eggert <eggert@cs.ucla.edu>
12219
12220 * doprnt.c (doprnt): Support "ll" length modifier, for long long.
12221
ea51cceb
JB
122222011-04-27 Juanma Barranquero <lekktu@gmail.com>
12223
12224 * makefile.w32-in: Update dependencies.
12225
94dcfacf
EZ
122262011-04-27 Eli Zaretskii <eliz@gnu.org>
12227
12228 Improve `doprnt' and its usage. (Bug#8545)
12229 * doprnt.c (doprnt): Make sure `format' is never accessed beyond
12230 `format_end'. Remove support for %l as a conversion specifier.
12231 Don't use xrealloc. Improve diagnostics when the %l size modifier
12232 is used. Update the commentary.
12233
12234 * eval.c (verror): Simplify calculation of size_t.
12235
12236 * coding.c (Ffind_operation_coding_system): Fix diagnostic error
12237 messages.
12238
f61f41d7
PE
122392011-04-27 Yoshiaki Kasahara <kasahara@nc.kyushu-u.ac.jp> (tiny change)
12240
12241 * buffer.c (init_buffer) [USE_MMAP_FOR_BUFFERS]: Adjust to aliasing
12242 change.
12243
96fb4434
PE
122442011-04-27 Paul Eggert <eggert@cs.ucla.edu>
12245
12246 * nsmenu.m: Replace all uses of XVECTOR with ASIZE and AREF.
12247 This makes this file independent of the recent pseudovector change.
12248
671875da 122492011-04-26 Paul Eggert <eggert@cs.ucla.edu>
eab3844f 12250
69e9b5a3
PE
12251 * keyboard.c (handle_user_signal): Fix pointer signedness problem.
12252
b5f869a7 12253 * gnutls.c (emacs_gnutls_handle_error): Remove unused local.
7754e151 12254 (Fgnutls_boot): gnutls_certificate_verify_peers2 wants unsigned *.
8d4c3955 12255 Remove unused local.
c8926152 12256 (emacs_gnutls_write): Don't use uninitialized rtnval if nbyte <= 0.
080e5a8d 12257
841a1577 12258 * lisp.h: Fix a problem with aliasing and vector headers. (Bug#8546)
04f2d78b
CB
12259 GCC 4.6.0 optimizes based on type-based alias analysis.
12260 For example, if b is of type struct buffer * and v of type struct
eab3844f
PE
12261 Lisp_Vector *, then gcc -O2 was incorrectly assuming that &b->size
12262 != &v->size, and therefore "v->size = 1; b->size = 2; return
12263 v->size;" must therefore return 1. This assumption is incorrect
12264 for Emacs, since it type-puns struct Lisp_Vector * with many other
12265 types. To fix this problem, this patch adds a new type struct
f904488f 12266 vectorlike_header that documents the constraints on layout of vectors
eab3844f
PE
12267 and pseudovectors, and helps optimizing compilers not get fooled
12268 by Emacs's type punning. It also adds the macros XSETTYPED_PVECTYPE
12269 XSETTYPED_PSEUDOVECTOR, TYPED_PSEUDOVECTORP, for similar reasons.
f904488f
PE
12270 * lisp.h (XSETTYPED_PVECTYPE): New macro, specifying the name of
12271 the size member.
eab3844f
PE
12272 (XSETPVECTYPE): Rewrite in terms of new macro.
12273 (XSETPVECTYPESIZE): New macro, specifying both type and size.
12274 This is a bit clearer, and further avoids the possibility of
12275 undesirable aliasing.
12276 (XSETTYPED_PSEUDOVECTOR): New macro, specifying the size.
f904488f 12277 (XSETPSEUDOVECTOR): Rewrite in terms of XSETTYPED_PSEUDOVECTOR.
eab3844f
PE
12278 (XSETSUBR): Rewrite in terms of XSETTYPED_PSEUDOVECTOR and XSIZE,
12279 since Lisp_Subr is a special case (no "next" field).
04f2d78b
CB
12280 (ASIZE): Now uses header.size rather than size.
12281 All previous uses of XVECTOR (foo)->size replaced to use this macro,
f904488f
PE
12282 to avoid the hassle of writing XVECTOR (foo)->header.size.
12283 (struct vectorlike_header): New type.
eab3844f
PE
12284 (TYPED_PSEUDOVECTORP): New macro, also specifying the C type of the
12285 object, to help avoid aliasing.
12286 (PSEUDOVECTORP): Rewrite in terms of TYPED_PSEUDOVECTORP.
12287 (SUBRP): Likewise, since Lisp_Subr is a special case.
12288 * lisp.h (struct Lisp_Vector, struct Lisp_Char_Table):
12289 (struct Lisp_Sub_Char_Table, struct Lisp_Bool_Vector):
12290 (struct Lisp_Hash_Table): Combine first two members into a single
f904488f 12291 struct vectorlike_header member. All uses of "size" and "next" members
eab3844f
PE
12292 changed to be "header.size" and "header.next".
12293 * buffer.h (struct buffer): Likewise.
12294 * font.h (struct font_spec, struct font_entity, struct font): Likewise.
12295 * frame.h (struct frame): Likewise.
12296 * process.h (struct Lisp_Process): Likewise.
12297 * termhooks.h (struct terminal): Likewise.
12298 * window.c (struct save_window_data, struct saved_window): Likewise.
12299 * window.h (struct window): Likewise.
12300 * alloc.c (allocate_buffer, Fmake_bool_vector, allocate_pseudovector):
12301 Use XSETPVECTYPESIZE, not XSETPVECTYPE, to avoid aliasing problems.
12302 * buffer.c (init_buffer_once): Likewise.
12303 * lread.c (defsubr): Use XSETTYPED_PVECTYPE, since Lisp_Subr is a
12304 special case.
12305 * process.c (Fformat_network_address): Use local var for size,
12306 for brevity.
12307
0df1eac5
PE
12308 * bytecode.c (exec_byte_code): Don't use XVECTOR before CHECK_VECTOR.
12309
847ab9d1 12310 Make the Lisp reader and string-to-float more consistent (Bug#8525)
452f4150
PE
12311 * data.c (atof): Remove decl; no longer used or needed.
12312 (digit_to_number): Move to lread.c.
12313 (Fstring_to_number): Use new string_to_number function, to be
12314 consistent with how the Lisp reader treats infinities and NaNs.
12315 Do not assume that floating-point numbers represent EMACS_INT
12316 without losing information; this is not true on most 64-bit hosts.
12317 Avoid double-rounding errors, by insisting on integers when
12318 parsing non-base-10 numbers, as the documentation specifies.
12319 * lisp.h (string_to_number): New decl, replacing ...
12320 (isfloat_string): Remove.
bc0a5c13 12321 * lread.c: Include <inttypes.h>, for uintmax_t and strtoumax.
d78050d6 12322 (read1): Do not accept +. and -. as integers; this
452f4150
PE
12323 appears to have been a coding error. Similarly, do not accept
12324 strings like +-1e0 as floating point numbers. Do not report
12325 overflow for integer overflows unless the base is not 10 which
12326 means we have no simple and reliable way to continue.
12327 Break out the floating-point parsing into a new
12328 function string_to_number, so that Fstring_to_number parses
12329 floating point numbers consistently with the Lisp reader.
04f2d78b 12330 (digit_to_number): Move here from data.c. Make it static inline.
452f4150
PE
12331 (E_CHAR, EXP_INT): Remove, replacing with ...
12332 (E_EXP): New macro, to solve the "1.0e+" problem mentioned below.
12333 (string_to_number): New function, replacing isfloat_string.
12334 This function checks for valid syntax and produces the resulting
12335 Lisp float number too. Rework it so that string-to-number
bc0a5c13 12336 no longer mishandles examples like "1.0e+". Use strtoumax,
d78050d6
PE
12337 so that overflow for non-base-10 numbers is reported only when
12338 there's no portable and simple way to convert to floating point.
452f4150 12339
67769ffc
PE
12340 * textprop.c (set_text_properties_1): Rewrite for clarity,
12341 and to avoid GCC warning about integer overflow.
12342
c20db43f
PE
12343 * intervals.h (struct interval): Use EMACS_INT for members
12344 where EMACS_UINT might cause problems. See
12345 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00514.html>.
12346 (CHECK_TOTAL_LENGTH): Remove cast to EMACS_INT; no longer needed.
12347 * intervals.c (interval_deletion_adjustment): Now returns EMACS_INT.
12348 All uses changed.
37aa2f85
PE
12349 (offset_intervals): Tell GCC not to worry about length overflow
12350 when negating a negative length.
c20db43f 12351
2538aa2f
PE
12352 * alloc.c (overrun_check_malloc, overrun_check_realloc): Now static.
12353 (overrun_check_free): Likewise.
12354
f2d3008d
PE
12355 * alloc.c (SDATA_SIZE) [!GC_CHECK_STRING_BYTES]: Avoid runtime check
12356 in the common case where SDATA_DATA_OFFSET is a multiple of Emacs
12357 word size.
12358
ec8df744
PE
12359 * gnutls.c: Fix problems found by GCC 4.6.0 on Ubuntu 10.10.
12360 (gnutls_make_error): Rename local to avoid shadowing.
12361 (gnutls_emacs_global_deinit): ifdef out; not used.
12362 (Fgnutls_boot): Use const for pointer to readonly storage.
12363 Comment out unused local. Fix pointer signedness problems.
12364
640ee02d
PE
12365 * lread.c (openp): Don't stuff size_t into an 'int'.
12366 Use <= on length, not < on length + 1, to avoid GCC 4.6.0 warning
12367 about possible signed overflow.
12368
6048fb2a
PE
12369 * gtkutil.c: Fix problems found by GCC 4.6.0 on Ubuntu 10.10.
12370 (GDK_KEY_g): Don't define if already defined.
12371 (xg_prepare_tooltip): Avoid pointer signedness problem.
12372 (xg_set_toolkit_scroll_bar_thumb): Redo to avoid two casts.
12373
fa3c87e1
PE
12374 * process.c (Fnetwork_interface_info): Avoid left-shift undefined
12375 behavior with 1 << 31. GCC 4.6.0 warns about this on 32-bit hosts.
12376
2172544b
PE
12377 * xfns.c (Fx_window_property): Simplify a bit,
12378 to make a bit faster and to avoid GCC 4.6.0 warning.
12379 * xselect.c (x_get_window_property, x_handle_dnd_message): Likewise.
12380
9b821a21
PE
12381 * fns.c (internal_equal): Don't assume size_t fits in int.
12382
3c616cfa
PE
12383 * alloc.c (compact_small_strings): Tighten assertion a little.
12384
c2982e87
PE
12385 Replace pEd with more-general pI, and fix some printf arg casts.
12386 * lisp.h (pI): New macro, generalizing old pEd macro to other
12387 conversion specifiers. For example, use "...%"pI"d..." rather
12388 than "...%"pEd"...".
12389 (pEd): Remove. All uses replaced with similar uses of pI.
61bdb816 12390 * m/amdx86-64.h, m/ia64.h, m/ibms390x.h: Likewise.
c2982e87
PE
12391 * alloc.c (check_pure_size): Don't overflow by converting size to int.
12392 * bidi.c (bidi_dump_cached_states): Use pI to avoid cast.
12393 * data.c (Fnumber_to_string): Use pI instead of if-then-else-abort.
12394 * dbusbind.c (xd_append_arg): Use pI to avoid cast.
12395 (Fdbus_method_return_internal, Fdbus_method_error_internal): Likewise.
12396 * font.c (font_unparse_xlfd): Avoid potential buffer overrun on
12397 64-bit hosts.
12398 (font_unparse_xlfd, font_unparse_fcname): Use pI to avoid casts.
12399 * keyboard.c (record_char, modify_event_symbol): Use pI to avoid casts.
12400 * print.c (safe_debug_print, print_object): Likewise.
12401 (print_object): Don't overflow by converting EMACS_INT or EMACS_UINT
12402 to int.
6f04d126
PE
12403 Use pI instead of if-then-else-abort. Use %p to avoid casts,
12404 avoiding the 0 flag, which is not portable.
c2982e87
PE
12405 * process.c (Fmake_network_process): Use pI to avoid cast.
12406 * region-cache.c (pp_cache): Likewise.
12407 * xdisp.c (decode_mode_spec): Likewise.
12408 * xrdb.c (x_load_resources) [USE_MOTIF]: Use pI to avoid undefined
12409 behavior on 64-bit hosts with printf arg.
6f04d126 12410 * xselect.c (x_queue_event): Use %p to avoid casts, avoiding 0 flag.
c2982e87
PE
12411 (x_stop_queuing_selection_requests): Likewise.
12412 (x_get_window_property): Don't truncate byte count to an 'int'
12413 when tracing.
0b432f21 12414
5e073ec7
PE
12415 * frame.c (frame_name_fnn_p): Get rid of strtol, which isn't right
12416 here, since it parses constructs like leading '-' and spaces,
12417 which are not wanted; and it overflows with large numbers.
12418 Instead, simply match F[0-9]+, which is what is wanted anyway.
12419
36372bf9
PE
12420 * alloc.c: Remove unportable assumptions about struct layout.
12421 (SDATA_SELECTOR, SDATA_DATA_OFFSET): New macros.
12422 (SDATA_OF_STRING, SDATA_SIZE, allocate_string_data):
12423 (allocate_vectorlike, make_pure_vector): Use the new macros,
12424 plus offsetof, to remove unportable assumptions about struct layout.
12425 These assumptions hold on all porting targets that I know of, but
12426 they are not guaranteed, they're easy to remove, and removing them
12427 makes further changes easier.
12428
0b432f21
PE
12429 * alloc.c (BLOCK BYTES): Fix typo by changing "ablock" to "ablocks".
12430 This doesn't fix a bug but makes the code clearer.
bfd1c781
PE
12431 (string_overrun_cookie): Now const. Use initializers that
12432 don't formally overflow signed char, to avoid warnings.
000098c1
PE
12433 (allocate_string_data) [GC_CHECK_STRING_OVERRUN]: Fix typo that
12434 can cause Emacs to crash when string overrun checking is enabled.
c7bda33c
PE
12435 (allocate_buffer): Don't assume sizeof (struct buffer) is a
12436 multiple of sizeof (EMACS_INT); it need not be, if
12437 alignof(EMACS_INT) < sizeof (EMACS_INT).
d0f4e1f5 12438 (check_sblock, check_string_bytes, check_string_free_list): Protoize.
0b432f21 12439
895009e1
JB
124402011-04-26 Juanma Barranquero <lekktu@gmail.com>
12441
12442 * keyboard.c (QCrtl): Rename from Qrtl. All uses changed.
12443
6a7a1b0b
TZ
124442011-04-26 Teodor Zlatanov <tzz@lifelogs.com>
12445
12446 * gnutls.c (emacs_gnutls_handshake): Return an error if we're not
b5f869a7 12447 supposed to be handshaking. (Bug#8556)
6a7a1b0b
TZ
12448 Reported by Paul Eggert <eggert@cs.ucla.edu>.
12449
841a1577 124502011-04-26 Daniel Colascione <dan.colascione@gmail.com>
0438ce91
DC
12451
12452 * lisp.h (Qdebug): List symbol.
895009e1 12453 * eval.c (Qdebug): Restore global linkage.
0438ce91
DC
12454 * keyboard.c (debug-on-event): New variable.
12455 (handle_user_signal): Break into debugger when debug-on-event
12456 matches the current signal symbol.
12457
f2d3ba6f
DN
124582011-04-25 Dan Nicolaescu <dann@ics.uci.edu>
12459
12460 * alloc.c (check_sblock, check_string_bytes)
12461 (check_string_free_list): Convert to standard C.
12462
42ce4c63
TZ
124632011-04-25 Teodor Zlatanov <tzz@lifelogs.com>
12464
12465 * w32.c (emacs_gnutls_push): Fix typo.
12466
825cd63c
EZ
124672011-04-25 Eli Zaretskii <eliz@gnu.org>
12468
fb11d64d
EZ
12469 * gnutls.c (emacs_gnutls_handshake): Avoid compiler warnings about
12470 "cast to pointer from integer of different size".
12471
825cd63c
EZ
12472 Improve doprnt and its use in verror. (Bug#8545)
12473 * doprnt.c (doprnt): Document the set of format control sequences
12474 supported by the function. Use SAFE_ALLOCA instead of always
12475 using `alloca'.
12476
12477 * eval.c (verror): Don't limit the buffer size at size_max-1, that
12478 is one byte too soon. Don't use xrealloc; instead xfree and
12479 xmalloc anew.
12480
e061a11b
TZ
124812011-04-24 Teodor Zlatanov <tzz@lifelogs.com>
12482
12483 * gnutls.h: Add GNUTLS_STAGE_CALLBACKS enum to denote we're in the
12484 callbacks stage.
12485
12486 * gnutls.c: Renamed global_initialized to
12487 gnutls_global_initialized. Added internals for the
12488 :verify-hostname-error, :verify-error, and :verify-flags
12489 parameters of `gnutls-boot' and documented those parameters in the
12490 docstring. Start callback support.
9173deec
JB
12491 (emacs_gnutls_handshake): Add Woe32 support. Retry handshake
12492 unless a fatal error occurred. Call gnutls_alert_send_appropriate
12493 on error. Return error code.
e061a11b
TZ
12494 (emacs_gnutls_write): Call emacs_gnutls_handle_error.
12495 (emacs_gnutls_read): Likewise.
12496 (Fgnutls_boot): Return handshake error code.
12497 (emacs_gnutls_handle_error): New function.
12498 (wsaerror_to_errno): Likewise.
12499
12500 * w32.h (emacs_gnutls_pull): Add prototype.
12501 (emacs_gnutls_push): Likewise.
12502
12503 * w32.c (emacs_gnutls_pull): New function for GnuTLS on Woe32.
12504 (emacs_gnutls_push): Likewise.
12505
125062011-04-24 Claudio Bley <claudio.bley@gmail.com> (tiny change)
12507
12508 * process.c (wait_reading_process_output): Check if GnuTLS
12509 buffered some data internally if no FDs are set for TLS
12510 connections.
12511
12512 * makefile.w32-in (OBJ2): Add gnutls.$(O).
12513 (LIBS): Link to USER_LIBS.
12514 ($(BLD)/gnutls.$(0)): New target.
12515
fa6996bc
EZ
125162011-04-24 Eli Zaretskii <eliz@gnu.org>
12517
eb35682e
EZ
12518 * xdisp.c (handle_single_display_spec): Rename the
12519 display_replaced_before_p argument into display_replaced_p, to
12520 make it consistent with the commentary. Fix typos in the
12521 commentary.
12522
e2ad650c
EZ
12523 * textprop.c (syms_of_textprop): Remove dead code.
12524 (copy_text_properties): Delete obsolete commentary about an
12525 interface that was deleted long ago. Fix typos in the description
12526 of arguments.
12527
1b2de274
EZ
12528 * msdos.c (XMenuActivate, XMenuAddSelection): Adjust argument list
12529 to changes in oldXMenu/XMenu.h from 2011-04-16.
12530 <menu_help_message, prev_menu_help_message>: Constify.
12531 (IT_menu_make_room): menu->help_text is now `const char **';
12532 adjust.
12533
12534 * msdos.h (XMenuActivate, XMenuAddSelection): Adjust prototypes
12535 to changes in oldXMenu/XMenu.h from 2011-04-16.
12536 (struct XMenu): Declare `help_text' `const char **'.
12537
12538 * xfaces.c <Qunspecified>: Make extern again.
12539
12540 * syntax.c: Include sys/types.h before including regex.h, as
75f1671a 12541 required by POSIX.
1b2de274 12542
762b15be
EZ
12543 * doc.c (get_doc_string): Improve the format passed to `error'.
12544
12545 * doprnt.c (doprnt): Improve commentary.
12546
12547 * term.c (init_tty) [MSDOS]: Fix 1st argument to maybe_fatal.
12548
12549 * Makefile.in (TAGS): Depend on $(M_FILE) and $(S_FILE), and scan
12550 them with etags.
12551
f1052e5d
EZ
12552 * makefile.w32-in (globals.h): Add a dummy recipe, to make any
12553 changes in globals.h immediately force recompilation.
762b15be
EZ
12554 (TAGS): Depend on $(CURDIR)/m/intel386.h and
12555 $(CURDIR)/s/ms-w32.h.
12556 (TAGS-gmake): Scan $(CURDIR)/m/intel386.h and $(CURDIR)/s/ms-w32.h.
f1052e5d 12557
fa6996bc
EZ
12558 * character.c (Fchar_direction): Function deleted.
12559 (syms_of_character): Don't defsubr it.
12560 <char-direction-table>: Deleted.
12561
e6c3da20
EZ
125622011-04-23 Eli Zaretskii <eliz@gnu.org>
12563
12564 Fix doprnt so it could be used again safely in `verror'. (Bug#8435)
12565 * doprnt.c: Include limits.h.
12566 (SIZE_MAX): New macro.
04f2d78b
CB
12567 (doprnt): Return a size_t value. 2nd arg is now size_t.
12568 Many local variables are now size_t instead of int or unsigned.
e6c3da20
EZ
12569 Improve overflow protection. Support `l' modifier for integer
12570 conversions. Support %l conversion. Don't assume an EMACS_INT
12571 argument for integer conversions and for %c.
12572
12573 * lisp.h (doprnt): Restore prototype.
12574
12575 * makefile.w32-in ($(BLD)/callint.$(O)): Depend on
12576 $(SRC)/character.h.
12577
12578 * Makefile.in (base_obj): Add back doprnt.o.
12579
12580 * deps.mk (doprnt.o): Add back prerequisites.
12581 (callint.o): Depend on character.h.
12582
12583 * eval.c (internal_lisp_condition_case): Include the handler
12584 representation in the error message.
12585 (verror): Call doprnt instead of vsnprintf. Fix an off-by-one bug
12586 when breaking from the loop.
12587
12588 * xdisp.c (vmessage): Call doprnt instead of vsnprintf.
12589
12590 * callint.c (Fcall_interactively): When displaying error message
12591 about invalid control letter, pass the character's codepoint, not
12592 a pointer to its multibyte form. Improve display of the character
12593 in octal and display also its hex code.
12594
12595 * character.c (char_string): Use %x to display the (unsigned)
12596 codepoint of an invalid character, to avoid displaying a bogus
12597 negative value.
12598
12599 * font.c (check_otf_features): Pass SDATA of SYMBOL_NAME to
12600 `error', not SYMBOL_NAME itself.
12601
12602 * coding.c (Fencode_sjis_char, Fencode_big5_char): Use %c for
12603 character arguments to `error'.
12604
12605 * charset.c (check_iso_charset_parameter): Fix incorrect argument
12606 to `error' in error message about FINAL_CHAR argument. Make sure
12607 FINAL_CHAR is a character, and use %c when it is passed as
12608 argument to `error'.
12609
4ffd0d6b 126102011-04-23 Eli Zaretskii <eliz@gnu.org>
97a93095
EZ
12611
12612 * s/ms-w32.h (localtime): Redirect to sys_localtime.
12613
12614 * w32.c: Include <time.h>.
12615 (sys_localtime): New function.
12616
4ffd0d6b 126172011-04-23 Chong Yidong <cyd@stupidchicken.com>
c17819f4
CY
12618
12619 * xdisp.c (init_xdisp): Initialize echo_area_window (Bug#6451).
12620
4ffd0d6b 12621 * buffer.c (syms_of_buffer): Doc fix (Bug#6902).
aac0c6e3 12622
4ffd0d6b 126232011-04-23 Samuel Thibault <sthibault@debian.org> (tiny change)
aac0c6e3 12624
4ffd0d6b
GM
12625 * sysdep.c (wait_for_termination): On GNU Hurd, kill returns -1 on
12626 zombies (Bug#8467).
aac0c6e3 12627
04c56954
EZ
126282011-04-19 Eli Zaretskii <eliz@gnu.org>
12629
12630 * syntax.h (SETUP_SYNTAX_TABLE_FOR_OBJECT): Fix setting of
12631 gl_state.e_property when gl_state.object is Qt.
12632
12633 * insdel.c (make_gap_larger): Remove limitation of buffer size
12634 to <= INT_MAX.
12635
16a43933
CY
126362011-04-18 Chong Yidong <cyd@stupidchicken.com>
12637
12638 * xdisp.c (lookup_glyphless_char_display)
12639 (produce_glyphless_glyph): Handle cons cell entry in
12640 glyphless-char-display.
12641 (Vglyphless_char_display): Document it.
12642
12643 * term.c (produce_glyphless_glyph): Handle cons cell entry in
12644 glyphless-char-display.
12645
4581706e
CY
126462011-04-17 Chong Yidong <cyd@stupidchicken.com>
12647
12648 * xdisp.c (get_next_display_element): Remove unnecessary ifdefs.
12649
12650 * termhooks.h (FRAME_WINDOW_P): Remove duplicated definitions.
12651
12652 * dispextern.h (FACE_SUITABLE_FOR_ASCII_CHAR_P): Add missing
12653 definition for no-X builds.
12654
4887c6e2 126552011-04-16 Paul Eggert <eggert@cs.ucla.edu>
764430a3 12656
fd35b6f9
PE
12657 Static checks with GCC 4.6.0 and non-default toolkits.
12658
5c1ccb01
PE
12659 * s/sol2-6.h, s/unixware.h (PTY_TTY_NAME_SPRINTF): Protoize decl.
12660
006c5daa
PE
12661 * process.c (keyboard_bit_set): Define only if SIGIO.
12662 (send_process_trap): Mark it with NO_RETURN if it doesn't return.
12663 (send_process): Repair possible setjmp clobbering.
12664
efc736d3
PE
12665 * s/usg5-4-common.h (SETUP_SLAVE_PTY): Don't pass extra arg to 'fatal'.
12666
4e2fe2e6
PE
12667 * eval.c: Include <stdio.h>, for vsnprintf on non-GNU/Linux hosts.
12668
f97334a2
PE
12669 * data.c (arith_error): Mark with NO_RETURN if it doesn't return.
12670
4e75f29d
PE
12671 * alloc.c (bytes_used_when_full, SPARE_MEMORY, BYTES_USED):
12672 Define only if needed.
12673
90efadd1
PE
12674 * sysdep.c (_FILE_OFFSET_BITS): Make this hack even uglier
12675 by pacifying GCC about it. Maybe it's time to retire it?
875975e9 12676 * xfaces.c (USG, __TIMEVAL__): Likewise.
90efadd1 12677
3c647824
PE
12678 * dispextern.h (struct redisplay_interface): Rename param
12679 to avoid shadowing.
e264f262 12680 * termhooks.h (struct terminal): Likewise.
761383f4 12681 * xterm.c (xembed_send_message): Likewise.
3c647824 12682
b58c5c4a
PE
12683 * insdel.c (make_gap_smaller): Define only if
12684 USE_MMAP_FOR_BUFFERS || REL_ALLOC || DOUG_LEA_MALLOC.
12685
cad59032
PE
12686 * keyboard.c (read_char): Make a var volatile so longjmp won't clobber
12687 it.
12688
c339dc2e
PE
12689 * emacs.c (MAX_HEAP_BSS_DIFF, my_edata): Move to where they're used,
12690 so that we aren't warned about unused symbols.
12691
91a3e27b
PE
12692 * xfns.c (Fx_file_dialog): Rename local to avoid shadowing.
12693
399c71d3 12694 * xdisp.c (x_produce_glyphs): Mark var as initialized (Bug#8512).
7a3fb125 12695
8ffc96f5
PE
12696 * xfns.c (x_real_positions): Mark locals as initialized.
12697
eef9bc79
PE
12698 * xmenu.c (xmenu_show): Don't use uninitialized vars.
12699
098db9dd
PE
12700 * xterm.c: Fix problems found by static analysis with other toolkits.
12701 (toolkit_scroll_bar_interaction): Define and use only if USE_X_TOOLKIT.
dda3aedd
PE
12702 (x_dispatch_event): Declare static if USE_GTK, and
12703 define if USE_GTK || USE_X_TOOLKIT.
098db9dd 12704 (SET_SAVED_BUTTON_EVENT): Define only if USE_X_TOOLKIT || USE_GTK.
dda3aedd 12705 * xterm.h (x_dispatch_event): Extern only if USE_X_TOOLKIT.
841a1577
JB
12706 * xterm.c, xterm.h (x_mouse_leave): Bring this function back, but only
12707 if defined HAVE_MENUS && !defined USE_X_TOOLKIT && !defined USE_GTK.
098db9dd 12708
eb18f6cc
PE
12709 * xmenu.c (menu_help_callback): Pointer type fixes.
12710 Use const pointers when pointing at readonly data. Avoid pointer
12711 signedness clashes.
12712 (FALSE): Remove unused macro.
12713 (update_frame_menubar): Remove unused decl.
12714
1fe72bf8
PE
12715 * xfns.c (Fx_hide_tip): Move locals to avoid shadowing.
12716
60d9e1db
PE
12717 * menu.c (push_submenu_start, push_submenu_end): Do not define unless
12718 USE_X_TOOLKIT || USE_GTK || HAVE_NS || defined HAVE_NTGUI.
12719 (single_menu_item): Rename local to avoid shadowing.
12720
39261c26
PE
12721 * keyboard.c (make_lispy_event): Remove unused local var.
12722
018c5e19
PE
12723 * frame.c, frame.h (x_get_resource_string): Bring this back, but
12724 only if HAVE_X_WINDOWS && !USE_X_TOOLKIT.
12725
63d2b86e
PE
12726 * bitmaps: Change bitmaps from unsigned char back to the X11
12727 compatible char. Avoid the old compiler warnings about
12728 out-of-range initializers by using, for example, '\xab' rather
12729 than 0xab.
12730
aefd87e1
PE
12731 * xgselect.c (xgselect_initialize): Check vs interface
12732 even if ! (defined (USE_GTK) || defined (HAVE_GCONF)).
12733
bf501fb9
PE
12734 * xmenu.c (xmenu_show): Rename parm to avoid shadowing.
12735
e9829fdf
PE
12736 * xterm.c (x_create_toolkit_scroll_bar): Use const * for pointers
12737 to read-only memory.
12738
1086c095
PE
12739 * fns.c (vector): Remove; this old hack is no longer needed.
12740
2baccd04 12741 * xsmfns.c (create_client_leader_window): Rename shadowing arg.
401f10cb 12742 Remove unused var.
dde42981 12743 (gdk_x11_set_sm_client_id) [!USE_GTK]: Don't define.
2baccd04 12744
72391843 12745 * xrdb.c (x_load_resources): Omit unused local.
3565b346 12746
436c16df 12747 * xfns.c (free_frame_menubar, atof): Remove duplicate decls.
8a94ea33 12748 (x_window): Rename locals to avoid shadowing.
dc5ddd85 12749 (USG): Use the kludged USG macro, to pacify gcc.
436c16df 12750
92bb796d 12751 * xterm.c (x_alloc_nearest_color_for_widget): Remove; unused.
bbbef9e1 12752 (x_term_init): Remove local to avoid shadowing.
92bb796d 12753
764430a3 12754 * xfns.c, xterm.c (_XEditResCheckMessages): Protoize decl.
4887c6e2
PE
12755
12756 * xdisp.c, dispextern.h (set_vertical_scroll_bar): Now extern if
12757 USE_TOOLKIT_SCROLL_BARS && !USE_GTK, as xterm.c needs it then.
12758
d1dfb56c
EZ
127592011-04-16 Eli Zaretskii <eliz@gnu.org>
12760
c4354cb4
EZ
12761 * gnutls.c (Fgnutls_boot): Don't pass Lisp_Object to `error'.
12762
d1dfb56c
EZ
12763 Fix regex.c, syntax.c and friends for buffers > 2GB.
12764 * syntax.h (struct gl_state_s): Declare character position members
12765 EMACS_INT.
12766
12767 * syntax.c (update_syntax_table): Declare 2nd argument EMACS_INT.
12768
04f2d78b
CB
12769 * textprop.c (verify_interval_modification, interval_of):
12770 Declare arguments EMACS_INT.
d1dfb56c
EZ
12771
12772 * intervals.c (adjust_intervals_for_insertion): Declare arguments
12773 EMACS_INT.
12774
12775 * intervals.h (CHECK_TOTAL_LENGTH): Cast to EMACS_INT, not `int'.
12776
12777 * indent.c (Fvertical_motion): Local variable it_start is now
12778 EMACS_INT.
12779
12780 * regex.c (re_match, re_match_2, re_match_2_internal)
12781 (bcmp_translate, regcomp, regexec, print_double_string)
12782 (group_in_compile_stack, re_search, re_search_2, regex_compile)
12783 (re_compile_pattern, re_exec): Declare arguments and local
12784 variables `size_t' and `ssize_t' and return values `regoff_t', as
12785 appropriate.
12786 (POP_FAILURE_REG_OR_COUNT) <pfreg>: Declare `long'.
12787 (CHECK_INFINITE_LOOP) <failure>: Declare `ssize_t'.
12788 <compile_stack_type>: `size' and `avail' are now `size_t'.
12789
12790 * regex.h <regoff_t>: Use ssize_t, not int.
12791 (re_search, re_search_2, re_match, re_match_2): Arguments that
12792 specify buffer/string position and length are now ssize_t and
12793 size_t. Return type is regoff_t.
12794
613052cd
BK
127952011-04-16 Ben Key <bkey76@gmail.com>
12796
12797 * nsfont.m: Fixed bugs in ns_get_family and
12798 ns_descriptor_to_entity that were caused by using free to
12799 deallocate memory blocks that were allocated by xmalloc (via
12800 xstrdup). This caused Emacs to crash when compiled with
12801 XMALLOC_OVERRUN_CHECK defined (when Emacs was configured with
12802 --enable-checking=xmallocoverrun). xfree is now used to
12803 deallocate these memory blocks.
12804
4170f62f 128052011-04-15 Paul Eggert <eggert@cs.ucla.edu>
3e047f51 12806
71b41406
PE
12807 * sysdep.c (emacs_read): Remove unnecessary check vs MAX_RW_COUNT.
12808
9587a89d
PE
12809 emacs_write: Accept and return EMACS_INT for sizes.
12810 See http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00514.html
12811 et seq.
12812 * gnutls.c, gnutls.h (emacs_gnutls_read, emacs_gnutls_write):
12813 Accept and return EMACS_INT.
12814 (emacs_gnutls_write): Return the number of bytes written on
12815 partial writes.
12816 * sysdep.c, lisp.h (emacs_read, emacs_write): Likewise.
273a5f82
PE
12817 (emacs_read, emacs_write): Remove check for negative size, as the
12818 Emacs source code has been audited now.
9587a89d
PE
12819 * sysdep.c (MAX_RW_COUNT): New macro, to work around kernel bugs.
12820 (emacs_read, emacs_write): Use it.
273a5f82
PE
12821 * process.c (send_process): Adjust to the new signatures of
12822 emacs_write and emacs_gnutls_write. Do not attempt to store
12823 a byte offset into an 'int'; it might overflow.
9587a89d 12824 See http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00483.html
273a5f82 12825
3e047f51
PE
12826 * sound.c: Don't assume sizes fit in 'int'.
12827 (struct sound_device.period_size, alsa_period_size):
9c3c56a7 12828 Return EMACS_INT, not int.
3e047f51 12829 (struct sound_device.write, vox_write, alsa_write):
9c3c56a7
PE
12830 Accept EMACS_INT, not int.
12831 (wav_play, au_play): Use EMACS_INT to store sizes and to
3e047f51
PE
12832 record read return values.
12833
cc39a9db
BK
128342011-04-15 Ben Key <bkey76@gmail.com>
12835
c9d0ec6d
JB
12836 * keyboard.c (Qundefined): Don't declare static since it is used
12837 in nsfns.m.
12838 * xfaces.c (Qbold, Qexpanded, Qitalic, Qcondensed): Don't declare
12839 static since they are used in nsfont.m.
cc39a9db 12840
6c60eb9f
SM
128412011-04-15 Stefan Monnier <monnier@iro.umontreal.ca>
12842
12843 * process.c (Qprocessp): Don't declare static.
12844 * lisp.h (Qprocessp): Declare again.
12845
7990b61a
JB
128462011-04-15 Juanma Barranquero <lekktu@gmail.com>
12847
12848 * font.c (Qopentype): Don't make static (used from w32uniscribe.c).
12849
5d4cb038
PE
128502011-04-14 Paul Eggert <eggert@cs.ucla.edu>
12851
8bd7b830 12852 Improve C-level modularity by making more things 'static'.
cd64ea1d 12853
e3b27b31
PE
12854 Don't publish debugger-only interfaces to other modules.
12855 * lisp.h (safe_debug_print, debug_output_compilation_hack):
12856 (verify_bytepos, count_markers): Move decls to the only modules
12857 that need them.
12858 * region-cache.h (pp_cache): Likewise.
12859 * window.h (check_all_windows): Likewise.
12860 * marker.c, print.c, region-cache.c, window.c: Decls moved here.
12861
5d4cb038
PE
12862 * sysdep.c (croak): Now static, if
12863 defined TIOCNOTTY || defined USG5 || defined CYGWIN.
12864 * syssignal.h (croak): Declare only if not static.
69003fd8
PE
12865
12866 * alloc.c (refill_memory_reserve): Now static if
12867 !defined REL_ALLOC || defined SYSTEM_MALLOC.
12868 * lisp.h (refill_memory_reserve): Declare only if not static.
93ea6e8f 12869
e87b6180
PE
12870 * xsettings.c, xsettings.h (xsettings_get_system_normal_font):
12871 Define only if USE_LUCID.
12872
ac64929e
PE
12873 * xrdb.c (x_customization_string, x_rm_string): Now static.
12874
6f37259d
PE
12875 * xmenu.c (x_menu_wait_for_event): Export only if USE_MOTIF.
12876 * xterm.h (x_menu_wait_for_event): Declare only if USE_MOTIF.
12877
1683e3ab
PE
12878 * xdisp.c (draw_row_with_mouse_face): Now static.
12879 * dispextern.h (draw_row_with_mouse_fave): Remove decl.
12880
de9c2632
PE
12881 * window.h (check_all_windows): Mark externally visible.
12882
2b96acb7
PE
12883 * window.c (window_deletion_count): Now static.
12884
12885 * undo.c: Make symbols static if they're not exported.
12886 (last_undo_buffer, last_boundary_position, pending_boundary):
12887 Now static.
12888
50436f33
PE
12889 * textprop.c (interval_insert_behind_hooks): Now static.
12890 (interval_insert_in_front_hooks): Likewise.
12891
64520e5c
PE
12892 * term.c: Make symbols static if they're not exported.
12893 (tty_turn_off_highlight, get_tty_terminal, max_frame_cols):
12894 (max_frame_lines, tty_set_terminal_modes):
12895 (tty_reset_terminal_modes, tty_turn_off_highlight):
12896 (get_tty_terminal): Now static.
12897 (term_mouse_moveto): Do not define if HAVE_WINDOW_SYSTEM.
12898 * termhooks.h (term_mouse_moveto): Do not declare if
8bd7b830 12899 HAVE_WINDOW_SYSTEM.
64520e5c
PE
12900 * dispextern.h (tty_set_terminal_modes, tty_reset_terminal_modes):
12901 (tty_turn_off_highlight, get_tty_terminal): Remove decls.
12902
1fa53021
PE
12903 * sysdep.c: Make symbols static if they're not exported.
12904 (emacs_get_tty, emacs_set_tty, old_fcntl_flags, old_fcntl_owner):
12905 Now static.
12906 (sigprocmask_set, full_mask): Remove; unused.
12907 (wait_debugging): Mark as visible.
12908 * syssignal.h (SIGFULLMASK, full_mask): Remove decls.
12909 * systty.h (emacs_get_tty, emacs_set_tty): Remove decls.
12910
d4b43b22
PE
12911 * syntax.c (syntax_temp): Define only if !__GNUC__.
12912
b7c513d0
PE
12913 * sound.c (current_sound_device, current_sound): Now static.
12914
989b29ad
PE
12915 * search.c (searchbufs, searchbuf_head): Now static.
12916
13a55a78
PE
12917 * scroll.c (scroll_cost): Remove; unused.
12918 * dispextern.h (scroll_cost): Remove decl.
12919
de68a1fc
PE
12920 * region-cache.h (pp_cache): Mark as externally visible.
12921
40ccffa6
PE
12922 * process.c: Make symbols static if they're not exported.
12923 (process_tick, update_tick, create_process, chan_process):
12924 (Vprocess_alist, proc_buffered_char, datagram_access):
12925 (fd_callback_data, send_process_frame, process_sent_to): Now static.
12926 (deactivate_process): Mark defn as static, as well as decl.
12927 * lisp.h (create_process): Remove decl.
12928 * process.h (chan_process, Vprocess_alist): Remove decls.
12929
ad64fc97
PE
12930 * print.c: Make symbols static if they're not exported.
12931 (print_depth, new_backquote_output, being_printed, print_buffer):
12932 (print_buffer_size, print_buffer_pos, print_buffer_pos_byte):
12933 (print_interval, print_number_index, initial_stderr_stream):
12934 Now static.
12935 * lisp.h (Fprinc): Remove decl.
12936 (debug_output_compilation_hack): Mark as externally visible.
12937
adddb265
PE
12938 * sysdep.c (croak): Move decl from here to syssignal.h.
12939 * syssignal.h (croak): Put it here, so the API can be checked when
12940 'croak' is called from dissociate_if_controlling_tty.
12941
1717ede2
PE
12942 * minibuf.c: Make symbols static if they're not exported.
12943 (minibuf_save_list, choose_minibuf_frame): Now static.
12944 * lisp.h (choose_minibuf_frame): Remove decl.
12945
fa5fb2bc
PE
12946 * lisp.h (verify_bytepos, count_markers): Mark as externally visible.
12947
1e3890d1
PE
12948 * lread.c: Make symbols static if they're not exported.
12949 (read_objects, initial_obarray, oblookup_last_bucket_number):
12950 Now static.
12951 (make_symbol): Remove; unused.
12952 * lisp.h (initial_obarray, make_symbol): Remove decls.
12953
8a1414fa
PE
12954 * keyboard.c: Make symbols static if they're not exported.
12955 (single_kboard, recent_keys_index, total_keys, recent_keys):
12956 (this_command_key_count_reset, raw_keybuf, raw_keybuf_count):
12957 (this_single_command_key_start, echoing, last_auto_save):
12958 (read_key_sequence_cmd, dribble, recursive_edit_unwind):
12959 (command_loop, echo_now, keyboard_init_hook, help_char_p):
12960 (quit_throw_to_read_char, command_loop_2, top_level_1, poll_timer):
12961 (Vlispy_mouse_stem, double_click_count):
12962 Now static.
12963 (force_auto_save_soon): Define only if SIGDANGER.
12964 (ignore_mouse_drag_p): Now static if
12965 !defined HAVE_WINDOW_SYSTEM || defined USE_GTK || defined HAVE_NS.
12966 (print_help): Remove; unused.
12967 (stop_character, last_timer_event): Mark as externally visible.
12968 * keyboard.h (ignore_mouse_drag_p): Declare only if
12969 defined HAVE_WINDOW_SYSTEM && !defined USE_GTK && !defined HAVE_NS.
12970 (echo_now, help_char_p, quit_throw_to_read_char): Remove decls.
12971 * lisp.h (echoing): Remove decl.
12972 (force_auto_save_soon): Declare only if SIGDANGER.
12973 * xdisp.c (redisplay_window): Simplify code, to make it more
12974 obvious that ignore_mouse_drag_p is not accessed if !defined
12975 USE_GTK && !defined HAVE_NS.
12976
93ea6e8f
PE
12977 * intervals.c: Make symbols static if they're not exported.
12978 (merge_properties_sticky, merge_interval_right, delete_interval):
12979 Now static.
12980 * intervals.h (merge_interval_right, delete_interval): Remove decls.
12981
77382fcc
PE
12982 * insdel.c: Make symbols static if they're not exported.
12983 However, leave prepare_to_modify_buffer alone. It's never
12984 called from outside this function, but that appears to be a bug.
12985 (combine_after_change_list, combine_after_change_buffer):
4889fc82 12986 (adjust_after_replace, signal_before_change): Now static.
77382fcc
PE
12987 (adjust_after_replace_noundo): Remove; unused.
12988 * lisp.h (adjust_after_replace, adjust_after_replace_noundo):
4889fc82 12989 (signal_before_change): Remove decls.
77382fcc 12990
9306c32e
PE
12991 * indent.c (val_compute_motion, val_vmotion): Now static.
12992
cd44d2eb
PE
12993 * image.c: Make symbols static if they're not exported.
12994 * dispextern.h (x_create_bitmap_from_xpm_data): Do not declare
12995 if USE_GTK.
12996 * image.c (x_create_bitmap_from_xpm_data): Do not define if USE_GTK.
12997 (xpm_color_cache, ct_table, ct_colors_allocated): Now static.
12998
ad9a7a06
PE
12999 * fringe.c (standard_bitmaps): Now static.
13000 (max_used_fringe_bitmap): Now static, unless HAVE_NS.
13001
81626931
PE
13002 * frame.c: Make symbols static if they're not exported.
13003 (x_report_frame_params, make_terminal_frame): Now static.
13004 (get_frame_param): Now static, unless HAVE_NS.
13005 (x_fullscreen_adjust): Define if WINDOWSNT, not if HAVE_WINDOW_SYSTEM.
13006 (x_get_resource_string): Remove; not used.
13007 * frame.h (make_terminal_frame, x_report_frame_params):
13008 (x_get_resource_string); Remove decls.
13009 (x_fullscreen_adjust): Declare only if WINDOWSNT.
13010 * lisp.h (get_frame_param): Declare only if HAVE_NS.
13011
239f9db9
PE
13012 * font.c, fontset.c: Make symbols static if they're not exported.
13013 * dispextern.h (FACE_SUITABLE_FOR_ASCII_CHAR_P): New macro.
13014 (FACE_SUITABLE_FOR_CHAR_P): Use it.
13015 * font.c (font_close_object): Now static.
13016 * font.h (font_close_object): Remove.
13017 * fontset.c (FONTSET_OBJLIST): Remove.
13018 (free_realized_fontset) #if-0 the body, which does nothing.
13019 (face_suitable_for_char_p): #if-0, as it's never called.
13020 * fontset.h (face_suitable_for_char_p): Remove decl.
04f2d78b
CB
13021 * xfaces.c (face_at_string_position):
13022 Use FACE_SUITABLE_FOR_ASCII_CHAR_P, not FACE_SUITABLE_FOR_CHAR_P,
239f9db9
PE
13023 since 0 is always ASCII.
13024
dfcf3579
PE
13025 * fns.c (weak_hash_tables): Now static.
13026
5045092b
PE
13027 * fileio.c: Make symbols static if they're not exported.
13028 (auto_saving, auto_save_mode_bits, auto_save_error_occurred):
13029 (Vwrite_region_annotation_buffers): Now static.
13030
57a96f5c
PE
13031 * eval.c: Make symbols static if they're not exported.
13032 (backtrace_list, lisp_eval_depth, when_entered_debugger): Now static.
13033 * lisp.h (backtrace_list): Remove decl.
13034
35f08c38
PE
13035 * emacs.c: Make symbols static if they're not exported.
13036 (malloc_state_ptr, malloc_using_checking, syms_of_emacs):
13037 (fatal_error_code, fatal_error_signal_hook, standard_args):
13038 Now static.
13039 (fatal_error_signal): Now static, unless FLOAT_CATCH_SIGKILL.
13040 (DEFINE_DUMMY_FUNCTION): Mark function as externally visible.
13041 (__CTOR_LIST__, __DTOR_LIST__): Now externally visible.
13042 * lisp.h (fatal_error_signal_hook): Remove decl.
13043 (fatal_error_signal): Declare only if FLOAT_CATCH_SIGKILL.
13044
f44bd759
PE
13045 * editfns.c: Move a (normally-unused) function to its only use.
13046 * editfns.c, lisp.h (get_operating_system_release): Remove.
13047 * process.c (init_process) [DARWIN_OS]: Do it inline, as it is not
13048 worth the hassle of breaking this out.
13049
b532497d
PE
13050 * xterm.c: Make symbols static if they're not exported.
13051 (x_raise_frame, x_lower_frame, x_wm_set_window_state):
13052 (x_wm_set_icon_pixmap, x_initialize, XTread_socket_fake_io_error):
13053 (x_destroy_window, x_delete_display):
13054 Now static.
13055 (x_dispatch_event): Now static if ! (USE_MOTIF || USE_X_TOOLKIT).
13056 (x_mouse_leave): Remove; unused.
13057 * xterm.h (x_display_info_for_name, x_raise_frame, x_lower_frame):
13058 (x_destroy_window, x_wm_set_window_state, x_wm_set_icon_pixmap):
13059 (x_delete_display, x_initialize, x_set_border_pixel, x_screen_planes):
13060 Remove decls.
13061 (x_mouse_leave): Declare only if WINDOWSNT.
13062 (x_dispatch_event): Declare only if USE_MOTIF or USE_X_TOOLKIT.
13063 (xic_create_fontsetname): Declare only if HAVE_X_WINDOWS &&
13064 USE_X_TOOLKIT.
13065
1675728f
PE
13066 * ftxfont.c: Make symbols static if they're not exported.
13067 (ftxfont_driver): Export only if !defined HAVE_XFT && def8ined
13068 HAVE_FREETYPE.
13069 * font.h (ftxfont_driver): Likewise.
13070
e4cebfca
PE
13071 * xfns.c: Make symbols static if they're not exported.
13072 (x_last_font_name, x_display_info_for_name):
13073 (x_set_foreground_color, x_set_background_color, x_set_mouse_color):
13074 (x_set_cursor_color, x_set_border_pixel, x_set_border_color):
13075 (x_set_cursor_type, x_set_icon_type, x_set_icon_name):
13076 (x_set_scroll_bar_foreground, x_set_scroll_bar_background):
13077 (x_explicitly_set_name, x_set_title, xic_defaut_fontset, tip_timer):
13078 (last_show_tip_args): Now static.
13079 (xic_defaut_fontset, xic_create_fontsetname): Define only if
13080 defined HAVE_X_WINDOWS && defined USE_X_TOOLKIT
13081 (x_screen_planes): Remove; unused.
13082 * dispextern.h (x_screen_planes): Remove decl.
13083
5bf46f05
PE
13084 * dispnew.c: Make symbols static if they're not exported.
13085 * dispextern.h (redraw_garbaged_frames, scrolling):
13086 (increment_row_positions): Remove.
13087 * dispnew.c (new_glyph_matrix, increment_row_positions, scrolling):
13088 (delayed_size_change, glyph_matrix_count, glyph_pool_count):
13089 Now static.
13090 (redraw_garbaged_frames): Remove; unused.
13091
435f4c28
PE
13092 * xfaces.c: Make symbols static if they're not exported.
13093 * dispextern.h (ascii_face_of_lisp_face, free_realized_face):
13094 Remove decls.
13095 * xterm.h (defined_color): Remove decls.
13096 (x_free_dpy_colors): Declare only if USE_X_TOOLKIT.
13097 * xfaces.c (tty_suppress_bold_inverse_default_colors_p):
13098 (menu_face_changed_default, defined_color, free_realized_face):
13099 (x_free_dpy_colors): Define only if USE_X_TOOLKIT.
13100 (ascii_face_of_lisp_face): Remove; unused.
13101
8524aef3
PE
13102 * xdisp.c: Make symbols static if they're not exported.
13103 * dispextern.h (scratch_glyph_row, window_box_edges):
13104 (glyph_to_pixel_coords, set_cursor_from_row):
13105 (get_next_display_element, set_iterator_to_next):
13106 (highlight_trailing_whitespace, frame_to_window_pixel_xy):
13107 (show_mouse_face): Remove decls
13108 * frame.h (message_buf_print): Likewise.
13109 * lisp.h (pop_message, set_message, check_point_in_composition):
13110 Likewise.
13111 * xterm.h (set_vertical_scroll_bar): Likewise.
13112 * xdisp.c (list_of_error, Vmessage_stack, line_number_displayed):
13113 (message_buf_print, scratch_glyph_row, displayed_buffer):
13114 (set_iterator_to_next, pop_message, set_message, set_cursor_from_row):
13115 (get_next_display_element, show_mouse_face, window_box_edges):
13116 (frame_to_window_pixel_xy, check_point_in_composition):
13117 (set_vertical_scroll_bar, highlight_trailing_whitespace): Now static.
13118 (glyph_to_pixel_coords): Remove; unused.
13119
16390cd2
PE
13120 * dired.c (file_name_completion): Now static.
13121
13122 * dbusbind.c (xd_in_read_queued_messages): Now static.
13123
a25f4dfa
PE
13124 * lisp.h (circular_list_error, FOREACH): Remove; unused.
13125 * data.c (circular_list_error): Remove.
13126
14a9c8df
PE
13127 * commands.h (last_point_position, last_point_position_buffer):
13128 (last_point_position_window): Remove decls.
13129 * keyboard.c: Make these variables static.
13130
04f2d78b
CB
13131 * coding.h (coding, code_convert_region, encode_coding_gap):
13132 Remove decls.
74ab6df5
PE
13133 * coding.c (Vsjis_coding_system, Vbig5_coding_system):
13134 (iso_code_class, detect_coding, code_convert_region): Now static.
13135 (encode_coding_gap): Remove; unused.
13136
38dfbee1
PE
13137 * chartab.c (chartab_chars, chartab_bits): Now static.
13138
a2cb4e63
PE
13139 * charset.h (charset_iso_8859_1): Remove decl.
13140 * charset.c (charset_iso_8859_1, charset_emacs, map_charset_for_dump):
13141 Now static.
13142
127198fd
PE
13143 * ccl.h (check_ccl_update, Vccl_program_table): Remove decls.
13144 * ccl.c (Vccl_program_table): Now static.
13145 (check_ccl_update): Remove; unused.
13146
d85b608f
PE
13147 * category.c (SET_CATEGORY_SET, set_category_set): Move here.
13148 * category.h: ... from here.
13149 * category.c (check_category_table, set_category_set): Now static.
13150
31cd66f3
PE
13151 * casetab.c (Vascii_upcase_table, Vascii_eqv_table): Now static.
13152 * lisp.h: Remove these decls.
13153
c358e587
PE
13154 * buffer.c (buffer_count): Remove unused var.
13155
e78aecca
PE
13156 * bidi.c (bidi_dump_cached_states): Mark as externally visible,
13157 so that it's not optimized away.
13158 (bidi_ignore_explicit_marks_for_paragraph_level): Likewise.
13159 * dispextern.h (bidi_dump_cached_states): Remove, since it's
13160 exported only to the debugger.
13161
e192d7d3 13162 * atimer.c (alarm_signal_handler, run_all_atimers): Now static.
04f2d78b 13163 * atimer.h (run_all_atimers): Remove; not exported.
e192d7d3 13164
92470028
PE
13165 font.c: Make copy_font_spec and merge_font_spec ordinary C functions.
13166 * font.c (copy_font_spec): Rename from Fcopy_font_spec, since it
13167 was inaccessible from Lisp.
13168 (merge_font_spec): Likewise, renaming from Fmerge_font_spec.
13169 * font.c, font.h, fontset.c, xfaces.c, xfont.c: Change all uses.
13170
244ed907
PE
13171 alloc.c: Import and export fewer symbols, and remove unused items.
13172 * lisp.h (suppress_checking, die): Declare only if ENABLE_CHECKING
13173 is defined.
13174 (suppress_checking): Add EXTERNALLY_VISIBLE attribute, so that
13175 it's not optimized away by whole-program optimization.
13176 (message_enable_multibyte, free_misc): Remove.
13177 (catchlist, handlerlist, mark_backtrace):
13178 Declare only if BYTE_MARK_STACK.
13179 (mark_byte_stack): Likewise, fixing a ifdef-vs-if typo.
13180 * alloc.c (pure): Export only if VIRT_ADDR_VARIES is defined.
13181 (message_enable_multibyte): Remove decl.
13182 (free_misc, interval_free_list, float_block, float_block_index):
13183 (n_float_blocks, float_free_list, cons_block, cons_block_index):
13184 (cons_free_list, last_marked_index):
13185 Now static.
13186 (suppress_checking, die): Define only if ENABLE_CHECKING is defined.
13187 * eval.c (catchlist, handlerlist): Export only if BYTE_MARK_STACK.
13188 (mark_backtrace): Define only if BYTE_MARK_STACK.
13189 * xdisp.c (message_enable_multibyte): Now static.
13190
61c2b50e 13191 Declare Lisp_Object Q* variables to be 'static' if not exported.
955cbe7b
PE
13192 This makes it easier for human readers (and static analyzers)
13193 to see whether these variables are used from other modules.
13194 * alloc.c, buffer.c, bytecode.c, callint.c, casetab.c, category.c:
13195 * ccl.c, character.c, charset.c, cmds.c, coding.c, composite.c:
13196 * data.c, dbusbind.c, dired.c, editfns.c, eval.c, fileio.c, fns.c:
13197 * font.c, frame.c, fringe.c, ftfont.c, image.c, keyboard.c, keymap.c:
13198 * lread.c, macros.c, minibuf.c, print.c, process.c, search.c:
13199 * sound.c, syntax.c, textprop.c, window.c, xdisp.c, xfaces.c, xfns.c:
13200 * xmenu.c, xselect.c:
13201 Declare Q* vars static if they are not used in other modules.
13202 * ccl.h, character.h, charset.h, coding.h, composite.h, font.h:
13203 * frame.h, intervals.h, keyboard.h, lisp.h, process.h, syntax.h:
13204 Remove decls of unexported vars.
13205 * keyboard.h (EVENT_HEAD_UNMODIFIED): Remove now-unused macro.
13206
95c82688
PE
13207 * lisp.h (DEFINE_FUNC): Make sname 'static'.
13208
16a97296
PE
13209 Make Emacs functions such as Fatom 'static' by default.
13210 This makes it easier for human readers (and static analyzers)
13211 to see whether these functions can be called from other modules.
13212 DEFUN now defines a static function. To make the function external
13213 so that it can be used in other C modules, use the new macro DEFUE.
8bd7b830
PE
13214 * lisp.h (Funibyte_char_to_multibyte, Fsyntax_table_p):
13215 (Finit_image_library):
16a97296
PE
13216 (Feval_region, Fbacktrace, Ffetch_bytecode, Fswitch_to_buffer):
13217 (Ffile_executable_p, Fmake_symbolic_link, Fcommand_execute):
13218 (Fget_process, Fdocumentation_property, Fbyte_code, Ffile_attributes):
13219 Remove decls, since these functions are now static.
13220 (Funintern, Fget_internal_run_time): New decls, since these functions
13221 were already external.
95c82688 13222
16a97296
PE
13223 * alloc.c, buffer.c, callint.c, callproc.c, casefiddle.c, casetab.c:
13224 * ccl.c, character.c, chartab.c, cmds.c, coding.c, data.c, dispnew.c:
13225 * doc.c, editfns.c, emacs.c, eval.c, fileio.c, filelock.c, floatfns.c:
13226 * fns.c, font.c, fontset.c, frame.c, image.c, indent.c:
13227 * keyboard.c, keymap.c, lread.c:
13228 * macros.c, marker.c, menu.c, minibuf.c, print.c, process.c, search.c:
13229 * syntax.c, term.c, terminal.c, textprop.c, undo.c:
13230 * window.c, xdisp.c, xfaces.c, xfns.c, xmenu.c, xsettings.c:
13231 Mark functions with DEFUE instead of DEFUN,
13232 if they are used in other modules.
13233 * buffer.c (Fset_buffer_major_mode, Fdelete_overlay): New forward
13234 decls for now-static functions.
13235 * buffer.h (Fdelete_overlay): Remove decl.
13236 * callproc.c (Fgetenv_internal): Mark as internal.
13237 * composite.c (Fremove_list_of_text_properties): Remove decl.
13238 (Fcomposition_get_gstring): New forward static decl.
13239 * composite.h (Fcomposite_get_gstring): Remove decl.
13240 * dired.c (Ffile_attributes): New forward static decl.
13241 * doc.c (Fdocumntation_property): New forward static decl.
13242 * eval.c (Ffetch_bytecode): New forward static decl.
13243 (Funintern): Remove extern decl; now in .h file where it belongs.
13244 * fileio.c (Fmake_symbolic_link): New forward static decl.
13245 * image.c (Finit_image_library): New forward static decl.
13246 * insdel.c (Fcombine_after_change_execute): Make forward decl static.
13247 * intervals.h (Fprevious_property_change):
13248 (Fremove_list_of_text_properties): Remove decls.
13249 * keyboard.c (Fthis_command_keys): Remove decl.
13250 (Fcommand_execute): New forward static decl.
13251 * keymap.c (Flookup_key): New forward static decl.
13252 (Fcopy_keymap): Now static.
13253 * keymap.h (Flookup_key): Remove decl.
13254 * process.c (Fget_process): New forward static decl.
13255 (Fprocess_datagram_address): Mark as internal.
13256 * syntax.c (Fsyntax_table_p): New forward static decl.
13257 (skip_chars): Remove duplicate decl.
13258 * textprop.c (Fprevious_property_change): New forward static decl.
13259 * window.c (Fset_window_fringes, Fset_window_scroll_bars):
13260 Now internal.
13261 (Fset_window_margins, Fset_window_vscroll): New forward static decls.
13262 * window.h (Fset_window_vscroll, Fset_window_margins): Remove decls.
13263
785bbd42
PE
13264 * editfns.c (Fformat): Remove unreachable code.
13265
8b913b57
AS
132662011-04-14 Andreas Schwab <schwab@linux-m68k.org>
13267
13268 * fileio.c (Finsert_file_contents): Fix typo in 2005-05-13
13269 change. (Bug#8496)
13270
a6744a35
EZ
132712011-04-13 Eli Zaretskii <eliz@gnu.org>
13272
13273 * xdisp.c (handle_invisible_prop): Don't call bidi_paragraph_init
13274 when at ZV. (Bug#8487)
13275
e7974947
AS
132762011-04-12 Andreas Schwab <schwab@linux-m68k.org>
13277
baad03f0
AS
13278 * charset.c (Fclear_charset_maps): Use xfree instead of free.
13279 (Bug#8437)
13280 * keyboard.c (parse_tool_bar_item): Likewise.
13281 * sound.c (sound_cleanup, alsa_close): Likewise.
13282 * termcap.c (tgetent): Likewise.
13283 * xfns.c (x_default_font_parameter): Likewise.
13284 * xsettings.c (read_and_apply_settings): Likewise.
13285
e7974947
AS
13286 * alloc.c (overrun_check_malloc, overrun_check_realloc)
13287 (overrun_check_free): Protoize.
13288
28272684
PE
132892011-04-12 Paul Eggert <eggert@cs.ucla.edu>
13290
13291 * sysdep.c (emacs_read, emacs_write): Check for negative sizes
13292 since callers should never pass a negative size.
13293 Change the signature to match that of plain 'read' and 'write'; see
13294 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00397.html>.
13295 * lisp.h: Update prototypes of emacs_write and emacs_read.
13296
11997c76
EZ
132972011-04-11 Eli Zaretskii <eliz@gnu.org>
13298
13299 * xdisp.c (redisplay_window): Don't try to determine the character
13300 position of the scroll margin if the window start point w->startp
e896f03c 13301 is outside the buffer's accessible region. (Bug#8468)
11997c76 13302
8a2cbd72
EZ
133032011-04-10 Eli Zaretskii <eliz@gnu.org>
13304
13305 Fix write-region and its subroutines for buffers > 2GB.
13306 * fileio.c (a_write, e_write): Modify declaration of arguments and
13307 local variables to support buffers larger than 2GB.
13308 (Fcopy_file): Use EMACS_INT for return value of emacs_read.
13309
13310 * sysdep.c (emacs_write, emacs_read): Use ssize_t for last
13311 argument, local variables, and return value.
13312
13313 * lisp.h: Update prototypes of emacs_write and emacs_read.
13314
13315 * sound.c (vox_write): Use ssize_t for return value of emacs_write.
13316
4073e537 133172011-04-10 Paul Eggert <eggert@cs.ucla.edu>
eb3f1cc8 13318
1ebfdcb6
PE
13319 * xdisp.c (vmessage): Use memchr, not strnlen, which some hosts lack.
13320
b2ded58d
PE
13321 Fix more problems found by GCC 4.6.0's static checks.
13322
7d66342c
PE
13323 * xdisp.c (vmessage): Use a better test for character truncation.
13324
bbf47d44
PE
13325 * charset.c (load_charset_map): <, not <=, for optimization,
13326 and to avoid potential problems with integer overflow.
9248994d 13327 * chartab.c (sub_char_table_set_range, char_table_set_range): Likewise.
f9a68bc5 13328 * casetab.c (set_identity, shuffle): Likewise.
3ab1c7ce 13329 * editfns.c (Fformat): Likewise.
1e69125e 13330 * syntax.c (skip_chars): Likewise.
3befa583 13331
e3019616
PE
13332 * xmenu.c (set_frame_menubar): Allocate smaller local vectors.
13333 This also lets GCC 4.6.0 generate slightly better loop code.
13334
becfa255
PE
13335 * callint.c (Fcall_interactively): <, not <=, for optimization.
13336 (Fcall_interactively): Count the number of arguments produced,
13337 not the number of arguments given. This is simpler and lets GCC
13338 4.6.0 generate slightly better code.
13339
dae0cd48
PE
13340 * ftfont.c: Distingish more carefully between FcChar8 and char.
13341 The previous code passed unsigned char * to a functions like
13342 strlen and xstrcasecmp that expect char *, which does not
13343 conform to the C standard.
13344 (get_adstyle_property, ftfont_pattern_entity): Use FcChar8 for
13345 arguments to FcPatternGetString, and explicitly cast FcChar8 * to
13346 char * when the C standard requires it.
13347
76032d70
PE
13348 * keyboard.c (read_char): Remove unused var.
13349
eb3f1cc8
PE
13350 * eval.c: Port to Windows vsnprintf (Bug#8435).
13351 Include <limits.h>.
13352 (SIZE_MAX): Define if the headers do not.
13353 (verror): Do not give up if vsnprintf returns a negative count.
13354 Instead, grow the buffer. This ports to Windows vsnprintf, which
13355 does not conform to C99. Problem reported by Eli Zaretskii.
13356 Also, simplify the allocation scheme, by avoiding the need for
13357 calling realloc, and removing the ALLOCATED variable.
13358
70476b54
PE
13359 * eval.c (verror): Initial buffer size is 4000 (not 200) bytes.
13360
12020a9e
PE
13361 Remove invocations of doprnt, as Emacs now uses vsnprintf.
13362 But keep the doprint source code for now, as we might revamp it
13363 and use it again (Bug#8435).
ea6c7ae6
PE
13364 * lisp.h (doprnt): Remove.
13365 * Makefile.in (base_obj): Remove doprnt.o.
13366 * deps.mk (doprnt.o): Remove.
13367
5fdb398c
PE
13368 error: Print 32- and 64-bit integers portably (Bug#8435).
13369 Without this change, on typical 64-bit hosts error ("...%d...", N)
13370 was used to print both 32- and 64-bit integers N, which relied on
13371 undefined behavior.
61bdb816 13372 * lisp.h, m/amdx86-64.h, m/ia64.h, m/ibms390x.h (pEd): New macro.
5fdb398c
PE
13373 * lisp.h (error, verror): Mark as printf-like functions.
13374 * eval.c (verror): Use vsnprintf, not doprnt, to do the real work.
13375 Report overflow in size calculations when allocating printf buffer.
13376 Do not truncate output string at its first null byte.
13377 * xdisp.c (vmessage): Use vsnprintf, not doprnt, to do the real work.
13378 Truncate the output at a character boundary, since vsnprintf does not
13379 do that.
13380 * charset.c (check_iso_charset_parameter): Convert internal
13381 character to string before calling 'error', since %c now has the
13382 printf meaning.
13383 * coding.c (Fdecode_sjis_char, Fdecode_big5_char): Avoid int
13384 overflow when computing char to be passed to 'error'. Do not
13385 pass Lisp_Object to 'error'; pass the integer instead.
13386 * nsfns.m (Fns_do_applescript): Use int, not long, since it's
13387 formatted with plain %d.
13388
b189fa66
PE
13389 * eval.c (internal_lisp_condition_case): Don't pass spurious arg.
13390
bff87ef0
PE
13391 * keyboard.c (access_keymap_keyremap): Print func name, not garbage.
13392
7e2cac20
PE
13393 * coding.c (Fdecode_sjis_char): Don't assume CODE fits in int.
13394
ce4d90b5
PE
13395 * xterm.c (x_catch_errors): Remove duplicate declaration.
13396
266c9547
PE
13397 * term.c (maybe_fatal): Mark its 3rd arg as a printf format, too.
13398
79c49ad2
PE
13399 * xdisp.c, lisp.h (message_nolog): Remove; unused.
13400
368f4090
JM
134012011-04-10 Jim Meyering <meyering@redhat.com>
13402
13403 use ssize_t and size_t for read- and write-like emacs_gnutls_* functions
13404 * gnutls.c (emacs_gnutls_read): Adjust signature to be more read-like:
13405 return ssize_t not "int", and use size_t as the buffer length.
13406 (emacs_gnutls_write): Likewise, and make the buffer pointer "const".
13407 * gnutls.h: Update declarations.
13408 * process.c (read_process_output): Use ssize_t, to match.
13409 (send_process): Likewise.
13410
a32d4040
CY
134112011-04-09 Chong Yidong <cyd@stupidchicken.com>
13412
13413 * image.c (Fimagemagick_types): Doc fix, and comment cleanup.
13414
8546720e 134152011-04-09 Chong Yidong <cyd@stupidchicken.com>
aac0c6e3 13416
04f2d78b
CB
13417 * ftfont.c (get_adstyle_property, ftfont_pattern_entity):
13418 Use unsigned char, to match FcChar8 type definition.
aac0c6e3 13419
8546720e
GM
13420 * xterm.c (handle_one_xevent):
13421 * xmenu.c (create_and_show_popup_menu):
13422 * xselect.c (x_decline_selection_request)
13423 (x_reply_selection_request): Avoid type-punned deref of X events.
aac0c6e3 13424
0a2f5c1a 134252011-04-09 Eli Zaretskii <eliz@gnu.org>
a53e2e89
EZ
13426
13427 Fix some uses of `int' instead of EMACS_INT.
13428 * search.c (string_match_1, fast_string_match)
13429 (fast_c_string_match_ignore_case, fast_string_match_ignore_case)
13430 (scan_buffer, find_next_newline_no_quit)
13431 (find_before_next_newline, search_command, Freplace_match)
13432 (Fmatch_data): Make some `int' variables be EMACS_INT.
13433
13434 * xdisp.c (display_count_lines): 3rd argument and return value now
13435 EMACS_INT. All callers changed.
13436 (pint2hrstr): Last argument is now EMACS_INT.
13437
13438 * coding.c (detect_coding_utf_8, detect_coding_emacs_mule)
13439 (detect_coding_iso_2022, detect_coding_sjis, detect_coding_big5)
13440 (detect_coding_ccl, detect_coding_charset, decode_coding_utf_8)
13441 (decode_coding_utf_16, decode_coding_emacs_mule)
13442 (decode_coding_iso_2022, decode_coding_sjis, decode_coding_big5)
13443 (decode_coding_ccl, decode_coding_charset)
13444 <consumed_chars, consumed_chars_base>: Declare EMACS_INT.
13445 (decode_coding_iso_2022, decode_coding_emacs_mule)
13446 (decode_coding_sjis, decode_coding_big5, decode_coding_charset)
13447 <char_offset, last_offset>: Declare EMACS_INT.
13448 (encode_coding_utf_8, encode_coding_utf_16)
13449 (encode_coding_emacs_mule, encode_invocation_designation)
13450 (encode_designation_at_bol, encode_coding_iso_2022)
13451 (encode_coding_sjis, encode_coding_big5, encode_coding_ccl)
13452 (encode_coding_raw_text, encode_coding_charset) <produced_chars>:
13453 Declare EMACS_INT.
13454 (ASSURE_DESTINATION): Declare more_bytes EMACS_INT.
13455 (encode_invocation_designation): Last argument P_NCHARS is now
13456 EMACS_INT.
13457 (decode_eol): Declare pos_byte, pos, and pos_end EMACS_INT.
13458 (produce_chars): from_nchars and to_nchars are now EMACS_INT.
13459
13460 * coding.h (struct coding_system) <head_ascii>: Declare EMACS_INT.
13461 All users changed.
13462
13463 * ccl.c (Fccl_execute_on_string): Declare some variables
13464 EMACS_INT.
13465
8546720e 134662011-04-08 Samuel Thibault <sthibault@debian.org> (tiny change)
0080dc6b
SS
13467
13468 * term.c (init_tty): Fix incorrect ifdef placement (Bug#8450).
13469
4e19a977
CS
134702011-03-19 Christoph Scholtes <cschol2112@googlemail.com>
13471
13472 * process.c (Fformat_network_address): Doc fix.
13473
87302331
R
134742011-04-08 T.V. Raman <tv.raman.tv@gmail.com> (tiny change)
13475
ee7683eb 13476 * xml.c (parse_region): Avoid creating spurious whitespace nodes.
87302331 13477
cbb59342
CY
134782011-04-08 Chong Yidong <cyd@stupidchicken.com>
13479
13480 * keyboard.c (read_char): Call Lisp function help-form-show,
13481 instead of using internal_with_output_to_temp_buffer.
13482 (Qhelp_form_show): New var.
e0d38eeb 13483 (syms_of_keyboard): Use DEFSYM macro.
cbb59342
CY
13484
13485 * print.c (internal_with_output_to_temp_buffer): Function deleted.
13486
13487 * lisp.h (internal_with_output_to_temp_buffer): Remove prototype.
13488
e67a13ab
CY
134892011-04-06 Chong Yidong <cyd@stupidchicken.com>
13490
04f2d78b
CB
13491 * process.c (Flist_processes): Remove to Lisp.
13492 (list_processes_1): Delete.
e67a13ab 13493
973f782d
EZ
134942011-04-06 Eli Zaretskii <eliz@gnu.org>
13495
7c106b1e
EZ
13496 * msdos.c (careadlinkat, careadlinkatcwd): MS-DOS replacements.
13497
973f782d
EZ
13498 * w32.c (careadlinkat, careadlinkatcwd): New always-fail stubs.
13499
41cf7d1a 135002011-04-06 Paul Eggert <eggert@cs.ucla.edu>
27ccc379 13501
ca23cc88
PE
13502 Fix more problems found by GCC 4.6.0's static checks.
13503
f390e2d5
PE
13504 * xmenu.c (Fx_popup_dialog): Don't assume string is free of formats.
13505
42eea0d0
PE
13506 * menu.c (Fx_popup_menu): Don't assume error_name lacks printf formats.
13507
b69769da 13508 * lisp.h (message, message_nolog, fatal): Mark as printf-like.
1e973bc7 13509
f9541e84
PE
13510 * xdisp.c (vmessage): Mark as a printf-like function.
13511
13841b55
PE
13512 * term.c (vfatal, maybe_fatal): Mark as printf-like functions.
13513
c136c10f
PE
13514 * sound.c (sound_warning): Don't crash if arg contains a printf format.
13515
5e2d4a30
PE
13516 * image.c (tiff_error_handler, tiff_warning_handler): Mark as
13517 printf-like functions.
13518 (tiff_load): Add casts to remove these marks before passing them
13519 to system-supplied API.
13520
583f48b9
PE
13521 * eval.c (Fsignal): Remove excess argument to 'fatal'.
13522
b25d760e
PE
13523 * coding.c (EMIT_ONE_BYTE, EMIT_TWO_BYTES): Use unsigned, not int.
13524 This avoids several warnings with gcc -Wstrict-overflow.
d5efd1d1
PE
13525 (DECODE_COMPOSITION_RULE): If the rule is invalid, goto invalid_code
13526 directly, rather than having caller test rule sign. This avoids
13527 some unnecessary tests.
13528 * composite.h (COMPOSITION_ENCODE_RULE_VALID): New macro.
13529 (COMPOSITION_ENCODE_RULE): Arguments now must be valid. This
13530 affects only one use, in DECODE_COMPOSITION_RULE, which is changed.
b25d760e 13531
bc7b6697 13532 * xfont.c (xfont_text_extents): Remove var that was set but not used.
625a3eb1 13533 (xfont_open): Avoid unnecessary tests.
bc7b6697 13534
27ccc379
PE
13535 * composite.c (composition_gstring_put_cache): Use unsigned integer.
13536
dcd5c89a
PE
13537 * composite.h, composite.c (composition_gstring_put_cache):
13538 Use EMACS_INT, not int, for length.
13539
b13a45c6
PE
13540 * composite.h (COMPOSITION_DECODE_REFS): New macro,
13541 breaking out part of COMPOSITION_DECODE_RULE.
13542 (COMPOSITION_DECODE_RULE): Use it.
13543 * composite.c (get_composition_id): Remove unused local vars,
13544 by using the new macro.
13545
1e792e4d
PE
13546 * textprop.c (set_text_properties_1): Change while to do-while,
13547 since the condition is always true at first.
13548
dc6c6455 13549 * intervals.c (graft_intervals_into_buffer): Mark var as used.
aa86731f
PE
13550 (interval_deletion_adjustment): Return unsigned value.
13551 All uses changed.
dc6c6455 13552
aba7731a
PE
13553 * process.c (list_processes_1, create_pty, read_process_output):
13554 (exec_sentinel): Remove vars that were set but not used.
afd4052b 13555 (create_pty): Remove unnecessary "volatile"s.
bc57d757 13556 (Fnetwork_interface_info): Avoid possibility of int overflow.
82eaa333 13557 (read_process_output): Do adaptive read buffering even if carryover.
fe07cdfa 13558 (read_process_output): Simplify nbytes computation if buffered.
aba7731a 13559
fdfc4bf3
PE
13560 * bytecode.c (exec_byte_code): Rename local to avoid shadowing.
13561
fca8fe46 13562 * syntax.c (scan_words): Remove var that was set but not used.
12cbf13f 13563 (update_syntax_table): Use unsigned instead of int.
fca8fe46 13564
06a0259a 13565 * lread.c (lisp_file_lexically_bound_p): Use ints rather than endptrs.
3c346cc3 13566 (lisp_file_lexically_bound_p, read1): Use unsigned instead of int.
e6eb4e9e 13567 (safe_to_load_p): Make the end-of-loop test the inverse of the in-loop.
06a0259a 13568
e7b9e80f
PE
13569 * print.c (print_error_message): Avoid int overflow.
13570
56201685
PE
13571 * font.c (font_list_entities): Redo for clarity,
13572 so that reader need not know FONT_DPI_INDEX + 1 == FONT_SPACING_INDEX.
13573
78834453 13574 * font.c (font_find_for_lface, Ffont_get_glyphs): Remove unused vars.
790771b1 13575 (font_score): Avoid potential overflow in diff calculation.
78834453 13576
0bc0b309 13577 * fns.c (substring_both): Remove var that is set but not used.
8cd55cb4 13578 (sxhash): Redo loop for clarity and to avoid wraparound warning.
0bc0b309 13579
e610eaca
PE
13580 * eval.c (funcall_lambda): Rename local to avoid shadowing.
13581
b895abce
PE
13582 * alloc.c (mark_object_loop_halt, mark_object): Use size_t, not int.
13583 Otherwise, GCC 4.6.0 optimizes the loop check away since the check
13584 can always succeed if overflow has undefined behavior.
13585
1f1d9321 13586 * search.c (boyer_moore, wordify): Remove vars set but not used.
6f076cc7 13587 (wordify): Omit three unnecessary tests.
1f1d9321 13588
c59478bc
PE
13589 * indent.c (MULTIBYTE_BYTES_WIDTH): Don't compute wide_column.
13590 All callers changed. This avoids the need for an unused var.
13591
79b73827
PE
13592 * casefiddle.c (casify_region): Remove var that is set but not used.
13593
a4db5dfe
PE
13594 * dired.c (file_name_completion): Remove var that is set but not used.
13595
43aae36e
PE
13596 * fileio.c (Finsert_file_contents): Make EOF condition clearer.
13597
2a47c44d 13598 * fileio.c (Finsert_file_contents): Avoid signed integer overflow.
163c5f32 13599 (Finsert_file_contents): Remove unnecessary code checking fd.
2a47c44d 13600
a37c69bf
PE
13601 * minibuf.c (read_minibuf_noninteractive): Use size_t for sizes.
13602 Check for integer overflow on size calculations.
13603
328ab8e7
PE
13604 * buffer.c (Fprevious_overlay_change): Remove var that is set
13605 but not used.
13606
e5a2a5cb
PE
13607 * keyboard.c (menu_bar_items, read_char_minibuf_menu_prompt):
13608 Remove vars that are set but not used.
8d84a6eb 13609 (timer_check_2): Don't assume timer-list and idle-timer-list are lists.
6b043475 13610 (timer_check_2): Mark vars as initialized.
e5a2a5cb 13611
a60e5f68
PE
13612 * gtkutil.c (xg_get_file_with_chooser): Mark var as initialized.
13613
f661cb61 13614 * image.c (lookup_image): Remove var that is set but not used.
35fa624f 13615 (xbm_load): Use parse_p, for gcc -Werror=unused-but-set-variable.
f661cb61 13616
f0397f5a
PE
13617 * fontset.c (Finternal_char_font, Ffontset_info): Remove vars
13618 that are set but not used.
13619
8664db06 13620 * xfns.c (make_invisible_cursor): Don't return garbage
03733ee7 13621 if XCreateBitmapFromData fails (Bug#8410).
8664db06 13622
6abdaa4a
PE
13623 * xselect.c (x_get_local_selection, x_handle_property_notify):
13624 Remove vars that are set but not used.
13625
0ce7538d 13626 * xfns.c (x_create_tip_frame): Remove var that is set but not used.
6abdaa4a 13627 (make_invisible_cursor): Initialize a possibly-uninitialized variable.
0ce7538d 13628
9ae848fc
PE
13629 * xterm.c (x_scroll_bar_to_input_event) [!USE_GTK]:
13630 Remove var that is set but not used.
0b918413
PE
13631 (scroll_bar_windows_size): Now size_t, not int.
13632 (x_send_scroll_bar_event): Use size_t, not int, for sizes.
13633 Check for overflow.
9ae848fc 13634
a5a62657
PE
13635 * xfaces.c (realize_named_face): Remove vars that are set but not used.
13636 (map_tty_color) [!defined MSDOS]: Likewise.
13637
5c5cdd39
PE
13638 * term.c (tty_write_glyphs): Use size_t; this avoids overflow warning.
13639
66ebf983
PE
13640 * coding.c: Remove vars that are set but not used.
13641 (DECODE_COMPOSITION_RULE): Remove 2nd arg, which is unused.
13642 All callers changed.
13643 (decode_coding_utf_8, decode_coding_utf_16 decode_coding_emacs_mule):
13644 (decode_coding_iso_2022, encode_coding_sjis, encode_coding_big5):
13645 (decode_coding_charset): Remove vars that are set but not used.
13646
1be4d761
PE
13647 * bytecode.c (Fbyte_code) [!defined BYTE_CODE_SAFE]: Remove var
13648 that is set but not used.
13649
47553fa8
PE
13650 * print.c (print_object): Remove var that is set but not used.
13651
1f7196bf 13652 Replace 2 copies of readlink code with 1 gnulib version (Bug#8401).
d1fdcab7
PE
13653 The gnulib version avoids calling malloc in the usual case,
13654 and on 64-bit hosts doesn't have some arbitrary 32-bit limits.
13655 * fileio.c (Ffile_symlink_p): Use emacs_readlink.
13656 * filelock.c (current_lock_owner): Likewise.
13657 * lisp.h (READLINK_BUFSIZE, emacs_readlink): New function.
13658 * sysdep.c: Include allocator.h, careadlinkat.h.
13659 (emacs_no_realloc_allocator): New static constant.
13660 (emacs_readlink): New function.
fdb61804
PE
13661 * deps.mk (sysdep.o): Depend on ../lib/allocator.h and on
13662 ../lib/careadlinkat.h.
d1fdcab7 13663
f84c17c7
SM
136642011-04-04 Stefan Monnier <monnier@iro.umontreal.ca>
13665
13666 * keyboard.c (safe_run_hook_funcall): Fix last change (don't stop at the
13667 first non-nil return value).
13668
ef3862ad
JD
136692011-04-03 Jan Djärv <jan.h.d@swipnet.se>
13670
13671 * nsterm.m (ns_update_auto_hide_menu_bar): Define MAC_OS_X_VERSION_10_6
13672 if not defined (Bug#8403).
13673
376a7006
JB
136742011-04-02 Juanma Barranquero <lekktu@gmail.com>
13675
13676 * xdisp.c (display_count_lines): Remove parameter `start',
13677 unused since 1998-01-01T02:27:27Z!rms@gnu.org. All callers changed.
13678 (get_char_face_and_encoding): Remove parameter `multibyte_p',
13679 unused since 2008-05-14T01:40:23Z!handa@m17n.org. All callers changed.
13680 (fill_stretch_glyph_string): Remove parameters `row' and `area',
13681 unused at least since Kim's GUI unification at 2003-03-16T20:45:46Z!storm@cua.dk
13682 and thereabouts. All callers changed.
13683 (get_per_char_metric): Remove parameter `f', unused since
13684 2008-05-14T01:40:23Z!handa@m17n.org. All callers changed.
13685
6ca3801d
JM
136862011-04-02 Jim Meyering <meyering@redhat.com>
13687
13688 do not dereference NULL upon failed strdup
13689 * nsfont.m (ns_descriptor_to_entity): Use xstrdup, not strdup.
13690 (ns_get_family): Likewise.
13691
d8e2b5ba
JB
136922011-04-02 Juanma Barranquero <lekktu@gmail.com>
13693
13694 * eval.c (unwind_to_catch) [DEBUG_GCPRO]: Remove redundant assignment.
13695
8c74fcbd
JD
136962011-04-02 Jan Djärv <jan.h.d@swipnet.se>
13697
13698 * nsterm.m (ns_update_auto_hide_menu_bar): Only for OSX 10.6 or
13699 later (Bug#8403).
13700
7200d79c
SM
137012011-04-01 Stefan Monnier <monnier@iro.umontreal.ca>
13702
03408648 13703 Add lexical binding.
7200d79c 13704
03408648
SM
13705 * window.c (Ftemp_output_buffer_show): New fun.
13706 (Fsave_window_excursion):
13707 * print.c (Fwith_output_to_temp_buffer): Move to subr.el.
13708
13709 * lread.c (lisp_file_lexically_bound_p): New function.
13710 (Fload): Bind Qlexical_binding.
13711 (readevalloop): Remove `evalfun' arg.
13712 Bind Qinternal_interpreter_environment.
13713 (Feval_buffer): Bind Qlexical_binding.
13714 (defvar_int, defvar_bool, defvar_lisp_nopro, defvar_kboard):
13715 Mark as dynamic.
13716 (syms_of_lread): Declare `lexical-binding'.
13717
13718 * lisp.h (struct Lisp_Symbol): New field `declared_special'.
13719
13720 * keyboard.c (eval_dyn): New fun.
13721 (menu_item_eval_property): Use it.
ca105506
SM
13722
13723 * image.c (parse_image_spec): Use Ffunctionp.
ca105506 13724
03408648
SM
13725 * fns.c (concat, mapcar1): Accept byte-code-functions.
13726
13727 * eval.c (Fsetq): Handle lexical vars.
13728 (Fdefun, Fdefmacro, Ffunction): Make closures when needed.
13729 (Fdefconst, Fdefvaralias, Fdefvar): Mark as dynamic.
13730 (FletX, Flet): Obey lexical binding.
13731 (Fcommandp): Handle closures.
13732 (Feval): New `lexical' arg.
13733 (eval_sub): New function extracted from Feval. Use it almost
13734 everywhere where Feval was used. Look up vars in lexical env.
13735 Handle closures.
13736 (Ffunctionp): Move from subr.el.
13737 (Ffuncall): Handle closures.
13738 (apply_lambda): Remove `eval_flags'.
13739 (funcall_lambda): Handle closures and new byte-code-functions.
13740 (Fspecial_variable_p): New function.
13741 (syms_of_eval): Initialize the Vinternal_interpreter_environment var,
13742 but without exporting it to Lisp.
23aba0ea 13743
23aba0ea 13744 * doc.c (Fdocumentation, store_function_docstring):
03408648 13745 * data.c (Finteractive_form): Handle closures.
23aba0ea 13746
03408648
SM
13747 * callint.c (Fcall_interactively): Preserve lexical-binding mode for
13748 interactive spec.
ba83908c 13749
04f2d78b
CB
13750 * bytecode.c (Bstack_ref, Bstack_set, Bstack_set2, BdiscardN):
13751 New byte-codes.
03408648
SM
13752 (exec_byte_code): New function extracted from Fbyte_code to handle new
13753 calling convention for byte-code-functions. Add new byte-codes.
ba83908c 13754
03408648 13755 * buffer.c (defvar_per_buffer): Set new `declared_special' field.
e2abe5a1 13756
03408648 13757 * alloc.c (Fmake_symbol): Init new `declared_special' field.
e2abe5a1 13758
e2abce01
JB
137592011-03-31 Juanma Barranquero <lekktu@gmail.com>
13760
13761 * xdisp.c (redisplay_internal): Fix prototype.
13762
63696a73 137632011-03-31 Eli Zaretskii <eliz@gnu.org>
09725d26 13764
63696a73 13765 * xdisp.c (SCROLL_LIMIT): New macro.
04f2d78b
CB
13766 (try_scrolling): Use it when setting scroll_limit.
13767 Limit scrolling to 100 screen lines.
63696a73
EZ
13768 (redisplay_window): Even when falling back on "recentering",
13769 position point in the window according to scroll-conservatively,
13770 scroll-margin, and scroll-*-aggressively variables. (Bug#6671)
13771
13772 (try_scrolling): When point is above the window, allow searching
13773 as far as scroll_max, or one screenful, to compute vertical
13774 distance from PT to the scroll margin position. This prevents
13775 try_scrolling from unnecessarily failing when
13776 scroll-conservatively is set to a value slightly larger than the
13777 window height. Clean up the case of PT below the margin at bottom
13778 of window: scroll_max can no longer be INT_MAX. When aggressive
13779 scrolling is in use, don't let point enter the opposite scroll
13780 margin as result of the scroll.
13781 (syms_of_xdisp) <scroll-conservatively>: Document the
09725d26
EZ
13782 threshold of 100 lines for never-recentering scrolling.
13783
e4cc2dfc
JB
137842011-03-31 Juanma Barranquero <lekktu@gmail.com>
13785
13786 * dispextern.h (move_it_by_lines):
13787 * xdisp.c (move_it_by_lines): Remove parameter `need_y_p', unused
13788 since 2000-12-29T14:24:09Z!gerd@gnu.org. All callers changed.
13789 (message_log_check_duplicate): Remove parameters `prev_bol' and
13790 `this_bol', unused since 1998-01-01T02:27:27Z!rms@gnu.org. All callers changed.
13791 (redisplay_internal): Remove parameter `preserve_echo_area',
13792 unused since 1999-07-21T21:43:52Z!gerd@gnu.org. All callers changed.
13793
13794 * indent.c (Fvertical_motion):
13795 * window.c (window_scroll_pixel_based, Frecenter):
13796 Don't pass `need_y_p' to `move_it_by_lines'.
13797
1c470562
SM
137982011-03-30 Stefan Monnier <monnier@iro.umontreal.ca>
13799
44f230aa
SM
13800 * eval.c (struct backtrace): Don't cheat with negative numbers, but do
13801 steal a few bits to be more compact.
13802 (interactive_p, Fbacktrace, Fbacktrace_frame, mark_backtrace):
13803 Remove unneeded casts.
13804
1c470562
SM
13805 * bytecode.c (Fbyte_code): CAR and CDR can GC.
13806
888adce9
ZK
138072011-03-30 Zachary Kanfer <zkanfer@gmail.com> (tiny change)
13808
13809 * keyboard.c (Fexecute_extended_command): Do log the "suggest key
13810 binding" message (bug#7967).
13811
f838ed7b
PE
138122011-03-30 Paul Eggert <eggert@cs.ucla.edu>
13813
77861b95
PE
13814 Fix more problems found by GCC 4.6.0's static checks.
13815
de6dbc14
PE
13816 * unexelf.c (unexec) [! (defined _SYSTYPE_SYSV || defined __sgi)]:
13817 Remove unused local var.
13818
f838ed7b
PE
13819 * editfns.c (Fmessage_box): Remove unused local var.
13820
792c7b2b
PE
13821 * xdisp.c (try_window_reusing_current_matrix, x_produce_glyphs):
13822 (note_mode_line_or_margin_highlight, note_mouse_highlight):
13823 Omit unused local vars.
c499e557 13824 * window.c (shrink_windows): Omit unused local var.
b01a1c29 13825 * menu.c (digest_single_submenu): Omit unused local var.
0bc32927
PE
13826 * dispnew.c (update_window) [PERIODIC_PREEMPTION_CHECKING]:
13827 Omit unused local var.
13828
ba0165e1
PE
13829 * keyboard.c (parse_modifiers_uncached, parse_modifiers):
13830 Don't assume string length fits in int.
32ad8845 13831 (keyremap_step, read_key_sequence): Use size_t for sizes.
48011560 13832 (read_key_sequence): Don't check last_real_key_start redundantly.
ba0165e1 13833
3c59b4c9
PE
13834 * callproc.c (Fcall_process, Fcall_process_region): Use SAFE_ALLOCA
13835 instead of alloca (Bug#8344).
13836
a3eed478 13837 * eval.c (Fbacktrace): Don't assume nargs fits in int.
5d5d959d 13838 (Fbacktrace_frame): Don't assume nframes fits in int.
a3eed478 13839
eb4d412d
PE
13840 * syntax.c (scan_sexps_forward): Avoid pointer wraparound.
13841
1658b401
PE
13842 * xterm.c (x_make_frame_visible, same_x_server): Redo to avoid overflow
13843 concerns.
13844
13845 * term.c (produce_glyphless_glyph): Remove unnecessary test.
13846
13847 * cm.c (calccost): Turn while-do into do-while, for clarity.
44f730c8 13848
9a2c6e05
PE
13849 * keyboard.c (syms_of_keyboard): Use the same style as later
13850 in this function when indexing through an array. This also
13851 works around GCC bug 48267.
13852
03d0a109
PE
13853 * image.c (tiff_load): Fix off-by-one image count (Bug#8336).
13854
44f730c8
PE
13855 * xselect.c (x_check_property_data): Return correct size (Bug#8335).
13856
fe75f926
PE
13857 * chartab.c (sub_char_table_ref_and_range): Redo for slight
13858 efficiency gain, and to bypass a gcc -Wstrict-overflow warning.
13859
ffa8c828
PE
13860 * keyboard.c, keyboard.h (num_input_events): Now size_t.
13861 This avoids undefined behavior on integer overflow, and is a bit
13862 more convenient anyway since it is compared to a size_t variable.
13863
c5101a77
PE
13864 Variadic C functions now count arguments with size_t, not int.
13865 This avoids an unnecessary limitation on 64-bit machines, which
13866 caused (substring ...) to crash on large vectors (Bug#8344).
13867 * lisp.h (struct Lisp_Subr.function.aMANY): Now takes size_t, not int.
13868 (DEFUN_ARGS_MANY, internal_condition_case_n, safe_call): Likewise.
77861b95 13869 All variadic functions and their callers changed accordingly.
c5101a77
PE
13870 (struct gcpro.nvars): Now size_t, not int. All uses changed.
13871 * data.c (arith_driver, float_arith_driver): Likewise.
13872 * editfns.c (general_insert_function): Likewise.
13873 * eval.c (struct backtrace.nargs, interactive_p)
13874 (internal_condition_case_n, run_hook_with_args, apply_lambda)
13875 (funcall_lambda, mark_backtrace): Likewise.
13876 * fns.c (concat): Likewise.
13877 * frame.c (x_set_frame_parameters): Likewise.
13878 * fns.c (get_key_arg): Now accepts and returns size_t, and returns
13879 0 if not found, not -1. All callers changed.
13880
dd3f25f7
PE
13881 * alloc.c (garbage_collect): Don't assume stack size fits in int.
13882 (stack_copy_size): Now size_t, not int.
13883 (stack_copy, stack_copy_size): Define only if MAX_SAVE_STACK > 0.
13884
461c2ab9
JB
138852011-03-28 Juanma Barranquero <lekktu@gmail.com>
13886
13887 * coding.c (encode_designation_at_bol): Remove parameter `charbuf_end',
13888 unused since 2002-03-01T01:17:24Z!handa@m17n.org and 2008-02-01T16:01:31Z!miles@gnu.org.
13889 All callers changed.
13890
13891 * lisp.h (multibyte_char_to_unibyte):
13892 * character.c (multibyte_char_to_unibyte): Remove parameter `rev_tbl',
13893 unused since 2002-03-01T01:16:34Z!handa@m17n.org and 2008-02-01T16:01:31Z!miles@gnu.org.
13894 * character.h (CHAR_TO_BYTE8):
13895 * cmds.c (internal_self_insert):
13896 * editfns.c (general_insert_function):
13897 * keymap.c (push_key_description):
13898 * search.c (Freplace_match):
13899 * xdisp.c (message_dolog, set_message_1): All callers changed.
13900
f6d62986
SM
139012011-03-28 Stefan Monnier <monnier@iro.umontreal.ca>
13902
13903 * keyboard.c (safe_run_hook_funcall): New function.
13904 (safe_run_hooks_1, safe_run_hooks_error, safe_run_hooks): On error,
13905 don't set the hook to nil, but remove the offending function instead.
13906 (Qcommand_hook_internal): Remove, unused.
13907 (syms_of_keyboard): Don't initialize Qcommand_hook_internal nor define
13908 Vcommand_hook_internal.
13909
13910 * eval.c (enum run_hooks_condition): Remove.
13911 (funcall_nil, funcall_not): New functions.
13912 (run_hook_with_args): Call each function through a `funcall' argument.
13913 Remove `cond' argument, now redundant.
13914 (Frun_hooks, Frun_hook_with_args, Frun_hook_with_args_until_success)
13915 (Frun_hook_with_args_until_failure): Adjust accordingly.
13916 (run_hook_wrapped_funcall, Frun_hook_wrapped): New functions.
13917
1db5b1ad
JB
139182011-03-28 Juanma Barranquero <lekktu@gmail.com>
13919
13920 * dispextern.h (string_buffer_position): Remove declaration.
13921
13922 * print.c (strout): Remove parameter `multibyte', unused since
13923 1999-08-21T19:30:21Z!gerd@gnu.org. All callers changed.
13924
13925 * search.c (boyer_moore): Remove parameters `len', `pos' and `lim',
13926 never used since function introduction in 1998-02-08T21:33:56Z!rms@gnu.org.
13927 All callers changed.
13928
13929 * w32.c (_wsa_errlist): Use braces for struct initializers.
13930
13931 * xdisp.c (string_buffer_position_lim): Remove parameter `w',
13932 never used since function introduction in 2001-03-09T18:41:50Z!gerd@gnu.org.
13933 All callers changed.
13934 (string_buffer_position): Likewise. Also, make static (it's never
13935 used outside xdisp.c).
13936 (cursor_row_p): Remove parameter `w', unused since
13937 2000-10-17T16:08:57Z!gerd@gnu.org. All callers changed.
13938 (decode_mode_spec): Remove parameter `precision', introduced during
13939 Gerd Moellmann's rewrite at 1999-07-21T21:43:52Z!gerd@gnu.org, but never used.
13940 All callers changed.
13941
5ffb62aa
JD
139422011-03-27 Jan Djärv <jan.h.d@swipnet.se>
13943
13944 * nsterm.m (syms_of_nsterm): Use doc: for ns-auto-hide-menu-bar.
13945
461c2ab9 139462011-03-27 Anders Lindgren <andlind@gmail.com>
f0a1382a
JD
13947
13948 * nsterm.m (ns_menu_bar_is_hidden): New variable.
13949 (ns_constrain_all_frames, ns_menu_bar_should_be_hidden)
13950 (ns_update_auto_hide_menu_bar): New functions.
13951 (ns_update_begin): Call ns_update_auto_hide_menu_bar.
13952 (applicationDidBecomeActive): Call ns_update_auto_hide_menu_bar and
13953 ns_constrain_all_frames.
13954 (constrainFrameRect): Return at once if ns_menu_bar_should_be_hidden.
13955 (syms_of_nsterm): DEFVAR ns-auto-hide-menu-bar, init to Qnil.
13956
5c380ffb
JD
139572011-03-27 Jan Djärv <jan.h.d@swipnet.se>
13958
13959 * nsmenu.m (runDialogAt): Remove argument to timer_check.
13960
9af30bdf
GM
139612011-03-27 Glenn Morris <rgm@gnu.org>
13962
13963 * syssignal.h: Replace RETSIGTYPE with void.
13964 * atimer.c, data.c, dispnew.c, emacs.c, floatfns.c, keyboard.c:
13965 * keyboard.h, lisp.h, process.c, sysdep.c, xterm.c:
13966 Replace SIGTYPE with void everywhere.
13967 * s/usg5-4-common.h (SIGTYPE): Remove definition.
13968 * s/template.h (SIGTYPE): Remove commented out definition.
13969
e2abce01
JB
139702011-03-26 Eli Zaretskii <eliz@gnu.org>
13971
13972 * xdisp.c (redisplay_window): Don't check buffer's clip_changed
13973 flag as a prerequisite for invoking try_scrolling. (Bug#6671)
13974
f868cd8a
JB
139752011-03-26 Juanma Barranquero <lekktu@gmail.com>
13976
59eb0929
JB
13977 * w32.c (read_unc_volume): Use parameter `henum', instead of
13978 global variable `wget_enum_handle'.
13979
13980 * keymap.c (describe_vector): Remove parameters `indices' and
13981 `char_table_depth', unused since 2002-03-01T01:43:26Z!handa@m17n.org.
13982 (describe_map, Fdescribe_vector): Adjust calls to `describe_vector'.
13983
f868cd8a
JB
13984 * keyboard.h (timer_check, show_help_echo): Remove unused parameters.
13985
13986 * keyboard.c (timer_check): Remove parameter `do_it_now',
13987 unused since 1996-04-12T06:01:29Z!rms@gnu.org.
13988 (show_help_echo): Remove parameter `ok_to_overwrite_keystroke_echo',
13989 unused since 2008-04-19T19:30:53Z!monnier@iro.umontreal.ca.
13990
13991 * keyboard.c (read_char):
13992 * w32menu.c (w32_menu_display_help):
13993 * xmenu.c (show_help_event, menu_help_callback):
13994 Adjust calls to `show_help_echo'.
13995
13996 * gtkutil.c (xg_maybe_add_timer):
13997 * keyboard.c (readable_events):
13998 * process.c (wait_reading_process_output):
13999 * xmenu.c (x_menu_wait_for_event): Adjust calls to `timer_check'.
14000
14001 * insdel.c (adjust_markers_gap_motion):
14002 Remove; no-op since 1998-01-02T21:29:48Z!rms@gnu.org.
14003 (gap_left, gap_right): Don't call it.
14004
2ecf6fdb
CY
140052011-03-25 Chong Yidong <cyd@stupidchicken.com>
14006
14007 * xdisp.c (handle_fontified_prop): Discard changes to clip_changed
14008 incurred during fontification.
14009
6b1f9ba4
JB
140102011-03-25 Juanma Barranquero <lekktu@gmail.com>
14011
14012 * buffer.c (defvar_per_buffer): Remove unused parameter `doc'.
14013 (DEFVAR_PER_BUFFER): Don't pass it.
14014
14015 * dispnew.c (row_equal_p, add_row_entry): Remove unused parameter `w'.
14016 (scrolling_window): Don't pass it.
14017
0f4a96b5
JB
140182011-03-25 Juanma Barranquero <lekktu@gmail.com>
14019
14020 * dispextern.h (glyph_matric): Use #if GLYPH_DEBUG, not #ifdef.
14021
14022 * fileio.c (check_executable) [DOS_NT]: Remove unused variables `len'
14023 and `suffix'.
14024 (Fset_file_selinux_context) [HAVE_LIBSELINUX]: Move here declaration
14025 of variables specific to SELinux and computation of `encoded_absname'.
14026
14027 * image.c (XPutPixel): Remove unused variable `height'.
14028
14029 * keyboard.c (make_lispy_event): Remove unused variable `hpos'.
14030
14031 * unexw32.c (get_section_info): Remove unused variable `section'.
14032
14033 * w32.c (stat): Remove unused variables `drive_root' and `devtype'.
14034 (system_process_attributes): Remove unused variable `sess'.
14035 (sys_read): Remove unused variable `err'.
14036
14037 * w32fns.c (top): Wrap variables with #if GLYPH_DEBUG, not #ifdef.
14038 (w32_wnd_proc): Remove unused variable `isdead'.
14039 (unwind_create_frame): Use #if GLYPH_DEBUG, not #ifdef.
14040 (Fx_server_max_request_size): Remove unused variable `dpyinfo'.
14041 (x_create_tip_frame): Remove unused variable `tem'.
14042
14043 * w32inevt.c (w32_console_read_socket):
14044 Remove unused variable `no_events'.
14045
14046 * w32term.c (x_draw_composite_glyph_string_foreground):
14047 Remove unused variable `width'.
14048
1149507c
JB
140492011-03-24 Juanma Barranquero <lekktu@gmail.com>
14050
14051 * w32term.c (x_set_glyph_string_clipping):
14052 Don't pass uninitialized region to CombineRgn.
14053
9c88f339
JB
140542011-03-23 Juanma Barranquero <lekktu@gmail.com>
14055
14056 * w32fns.c (x_set_menu_bar_lines): Remove unused variable `olines'.
14057 (w32_wnd_proc): Pass NULL to Windows API, not uninitialized buffer.
14058 (Fx_close_connection): Remove unused variable `i'.
14059
14060 * w32font.c (w32font_draw): Return number of glyphs.
14061 (w32font_open_internal): Remove unused variable `i'.
14062 (w32font_driver): Add missing initializer.
14063
14064 * w32menu.c (utf8to16): Remove unused variable `utf16'.
14065 (fill_in_menu): Remove unused variable `items_added'.
14066
14067 * w32term.c (last_mouse_press_frame): Remove static global variable.
14068 (w32_clip_to_row): Remove unused variable `f'.
14069 (x_delete_terminal): Remove unused variable `i'.
14070
14071 * w32uniscribe.c (uniscribe_shape): Remove unused variable `nclusters'.
14072 (NOTHING): Remove unused static global variable.
14073 (uniscribe_check_otf): Remove unused variable `table'.
14074 (uniscribe_font_driver): Add missing initializers.
14075
dee091a3
JD
140762011-03-23 Julien Danjou <julien@danjou.info>
14077
14078 * term.c (Fsuspend_tty, Fresume_tty):
14079 * minibuf.c (read_minibuf, run_exit_minibuf_hook):
14080 * window.c (temp_output_buffer_show):
14081 * insdel.c (signal_before_change):
14082 * frame.c (Fhandle_switch_frame):
14083 * fileio.c (Fdo_auto_save):
14084 * emacs.c (Fkill_emacs):
14085 * editfns.c (save_excursion_restore):
14086 * cmds.c (internal_self_insert):
14087 * callint.c (Fcall_interactively):
14088 * buffer.c (Fkill_all_local_variables):
14089 * keyboard.c (Fcommand_execute, Fsuspend_emacs, safe_run_hooks_1):
14090 Use Frun_hooks.
0f4a96b5 14091 (command_loop_1): Use Frun_hooks. Call safe_run_hooks
e9fce1ac 14092 unconditionally since it does the check itself.
dee091a3 14093
2c520ab5 140942011-03-23 Paul Eggert <eggert@cs.ucla.edu>
f0641eff 14095
c9c49752
PE
14096 Fix more problems found by GCC 4.5.2's static checks.
14097
8abc3f12
PE
14098 * coding.c (encode_coding_raw_text): Avoid unnecessary test
14099 the first time through the loop, since we know p0 < p1 then.
14100 This also avoids a gcc -Wstrict-overflow warning.
14101
a2d26660
PE
14102 * lisp.h (SAFE_ALLOCA, SAFE_ALLOCA_LISP): Avoid 'int' overflow
14103 leading to a memory leak, possible in functions like
14104 load_charset_map_from_file that can allocate an unbounded number
b12ef411 14105 of objects (Bug#8318).
a2d26660 14106
916c72e9
PE
14107 * xmenu.c (set_frame_menubar): Use EMACS_UINT, not int, for indexes
14108 that could (at least in theory) be that large.
14109
19ab8a18
PE
14110 * xdisp.c (message_log_check_duplicate): Return unsigned long, not int.
14111 This is less likely to overflow, and avoids undefined behavior if
14112 overflow does occur. All callers changed. Use strtoul to scan
14113 for the unsigned long integer.
b7cbbd6f
PE
14114 (pint2hrstr): Simplify and tune code slightly.
14115 This also avoids a (bogus) GCC warning with gcc -Wstrict-overflow.
19ab8a18 14116
f0641eff
PE
14117 * scroll.c (do_scrolling): Work around GCC bug 48228.
14118 See <http://gcc.gnu.org/bugzilla/show_bug.cgi?id=48228>.
14119
7f650bb9
PE
14120 * frame.c (Fmodify_frame_parameters): Simplify loop counter.
14121 This also avoids a warning with gcc -Wstrict-overflow.
39f5e519
PE
14122 (validate_x_resource_name): Simplify count usage.
14123 This also avoids a warning with gcc -Wstrict-overflow.
7f650bb9 14124
37dd57d1
PE
14125 * fileio.c (Fcopy_file): Report error if fchown or fchmod
14126 fail (Bug#8306).
81e56e61 14127
699979fc 14128 * emacs.c (Fdaemon_initialized): Do not ignore I/O errors (Bug#8303).
dc1ca6a8 14129
401bf9b4
PE
14130 * process.c (Fmake_network_process): Use socklen_t, not int,
14131 where POSIX says socklen_t is required in portable programs.
14132 This fixes a porting bug on hosts like 64-bit HP-UX, where
591b2973 14133 socklen_t is wider than int (Bug#8277).
401bf9b4
PE
14134 (Fmake_network_process, server_accept_connection):
14135 (wait_reading_process_output, read_process_output):
14136 Likewise.
14137
b93aacde
PE
14138 * process.c: Rename or move locals to avoid shadowing.
14139 (list_processes_1, Fmake_network_process):
14140 (read_process_output_error_handler, exec_sentinel_error_handler):
14141 Rename or move locals.
4dc343ee 14142 (Fmake_network_process): Define label "retry_connect" only if needed.
0da49335 14143 (Fnetwork_interface_info): Fix pointer signedness.
f990b4e5 14144 (process_send_signal): Add cast to avoid pointer signedness problem.
7b808126 14145 (FIRST_PROC_DESC, IF_NON_BLOCKING_CONNECT): Remove unused macros.
c939f91b 14146 (create_process): Use 'volatile' to avoid vfork clobbering (Bug#8298).
b93aacde 14147
af8a867c 14148 Make tparam.h and terminfo.c consistent.
44f230aa
SM
14149 * cm.c (tputs, tgoto, BC, UP): Remove extern decls.
14150 Include tparam.h instead, since it declares them.
af8a867c
PE
14151 * cm.h (PC): Remove extern decl; tparam.h now does this.
14152 * deps.mk (cm.o, terminfo.o): Depend on tparam.h.
14153 * terminfo.c: Include tparam.h, to check interfaces.
14154 (tparm): Make 1st arg a const pointer in decl. Put it at top level.
14155 (tparam): Adjust signature to match interface in tparam.h;
14156 this removes some undefined behavior. Check that outstring and len
14157 are zero, which they always are with Emacs.
14158 * tparam.h (PC, BC, UP): New extern decls.
14159
0248044d 14160 * xftfont.c (xftfont_shape): Now static, and defined only if needed.
001a7ab4 14161 (xftfont_open): Rename locals to avoid shadowing.
0248044d 14162
8ff096c1 14163 * ftfont.c (ftfont_resolve_generic_family): Fix pointer signedness.
a00924bb
PE
14164 (ftfont_otf_capability, ftfont_shape): Omit decls if not needed.
14165 (OTF_TAG_SYM): Omit macro if not needed.
e932860f 14166 (ftfont_list): Remove unused local.
49eaafba
PE
14167 (get_adstyle_property, ftfont_pattern_entity):
14168 (ftfont_lookup_cache, ftfont_open, ftfont_anchor_point):
14169 Rename locals to avoid shadowing.
8ff096c1 14170
e2be39f6
PE
14171 * xfont.c (xfont_list_family): Mark var as initialized.
14172
c9735e30
PE
14173 * xml.c (make_dom): Now static.
14174
8f5201ae
PE
14175 * composite.c (composition_compute_stop_pos): Rename local to
14176 avoid shadowing.
b246f932
PE
14177 (composition_reseat_it): Remove unused locals.
14178 (find_automatic_composition, composition_adjust_point): Likewise.
80e079b2 14179 (composition_update_it): Mark var as initialized.
11b61122
PE
14180 (find_automatic_composition): Mark vars as initialized,
14181 with a FIXME (Bug#8290).
8f5201ae 14182
760fbc2c
PE
14183 character.h: Rename locals to avoid shadowing.
14184 * character.h (PREV_CHAR_BOUNDARY, FETCH_STRING_CHAR_ADVANCE):
14185 (FETCH_STRING_CHAR_AS_MULTIBYTE_ADVANCE, FETCH_CHAR_ADVANCE):
14186 (FETCH_CHAR_ADVANCE_NO_CHECK, INC_POS, DEC_POS, BUF_INC_POS):
14187 (BUF_DEC_POS): Be more systematic about renaming local temporaries
14188 to avoid shadowing.
14189
ff08eb85
PE
14190 * textprop.c (property_change_between_p): Remove; unused.
14191
fc7bf025
PE
14192 * intervals.c (interval_start_pos): Now static.
14193
235d7abc
PE
14194 * intervals.h (CHECK_TOTAL_LENGTH): Avoid empty "else".
14195
44f230aa
SM
14196 * atimer.c (start_atimer, append_atimer_lists, set_alarm):
14197 Rename locals to avoid shadowing.
3e7d6594 14198
50060332
PE
14199 * sound.c (wav_play, au_play, Fplay_sound_internal):
14200 Fix pointer signedness.
d01f234b 14201 (alsa_choose_format): Remove unused local var.
c83b8872
PE
14202 (wav_play): Initialize a variable to 0, to prevent undefined
14203 behavior (Bug#8278).
50060332 14204
c4fc4e30
PE
14205 * region-cache.c (insert_cache_boundary): Redo var to avoid shadowing.
14206
918436ed
PE
14207 * region-cache.h (pp_cache): New decl, for gcc -Wmissing-prototypes.
14208
c939f91b
PE
14209 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork
14210 clobbering (Bug#8298).
b9c7f648
PE
14211 * sysdep.c (sys_subshell): Likewise.
14212 Previously, the sys_subshell 'volatile' was incorrectly IF_LINTted out.
7e9123a2 14213
6bd8c144
PE
14214 * lisp.h (child_setup): Now NO_RETURN unless DOS_NT.
14215 This should get cleaned up, so that child_setup has the
14216 same signature on all platforms.
14217
7710357c 14218 * callproc.c (call_process_cleanup): Now static.
cb1d0ef7 14219 (relocate_fd): Rename locals to avoid shadowing.
7710357c 14220
c59da222
CY
142212011-03-22 Chong Yidong <cyd@stupidchicken.com>
14222
14223 * xterm.c (x_clear_frame): Remove XClearWindow call. This appears
14224 not to be necessary, and produces flickering.
14225
66b87493
GM
142262011-03-20 Glenn Morris <rgm@gnu.org>
14227
14228 * config.in: Remove file.
14229
45b6f6d5
JB
142302011-03-20 Juanma Barranquero <lekktu@gmail.com>
14231
14232 * minibuf.c (Vcompleting_read_function): Don't declare, global variables
14233 are now in src/globals.h.
14234 (syms_of_minibuf): Remove spurious & from previous change.
14235
cd394be1 142362011-03-20 Leo Liu <sdl.web@gmail.com>
3ec03f7e
LL
14237
14238 * minibuf.c (completing-read-function): New variable.
14239 (completing-read-default): Rename from completing-read.
14240 (completing-read): Call completing-read-function.
14241
b14e3e21
CY
142422011-03-19 Juanma Barranquero <lekktu@gmail.com>
14243
14244 * xfaces.c (Fx_load_color_file):
14245 Read color file from absolute filename (bug#8250).
14246
f2b726e6
JB
142472011-03-19 Juanma Barranquero <lekktu@gmail.com>
14248
14249 * makefile.w32-in: Update dependencies.
14250
09f6ff02
EZ
142512011-03-17 Eli Zaretskii <eliz@gnu.org>
14252
14253 * makefile.w32-in ($(BLD)/unexw32.$(O)): Depend on $(SRC)/unexec.h.
14254
29a6015a
PE
142552011-03-17 Paul Eggert <eggert@cs.ucla.edu>
14256
a3a6c54e
PE
14257 Fix more problems found by GCC 4.5.2's static checks.
14258
b766f867
PE
14259 * process.c (make_serial_process_unwind, send_process_trap):
14260 (sigchld_handler): Now static.
14261
be02381c
PE
14262 * process.c (allocate_pty): Let PTY_ITERATION declare iteration vars.
14263 That way, the code declares only the vars that it needs.
14264 * s/aix4-2.h (PTY_ITERATION): Declare iteration vars.
14265 * s/cygwin.h (PTY_ITERATION): Likewise.
14266 * s/darwin.h (PTY_ITERATION): Likewise.
14267 * s/gnu-linux.h (PTY_ITERATION): Likewise.
14268
57048744
PE
14269 * s/irix6-5.h (PTY_OPEN): Declare stb, to loosen coupling.
14270 * process.c (allocate_pty): Don't declare stb unless it's needed.
14271
7914961c 14272 * bytecode.c (MAYBE_GC): Rewrite so as not to use empty "else".
615f2d59
PE
14273 (CONSTANTLIM): Remove; unused.
14274 (METER_CODE, Bscan_buffer, Bread_char, Bset_mark):
14275 Define only if needed.
7914961c 14276
b3967b18
PE
14277 * unexelf.c (unexec): Name an expression,
14278 to avoid gcc -Wbad-function-cast warning.
9ae71512
PE
14279 Use a different way to cause a compilation error if anyone uses
14280 n rather than nn, a way that does not involve shadowing.
73366a00 14281 (ELF_BSS_SECTION_NAME, OLD_PROGRAM_H): Remove; unused.
b3967b18 14282
29a6015a
PE
14283 * deps.mk (unexalpha.o): Remove; unused.
14284
43cfc33e 14285 New file unexec.h, the (simple) interface for unexec (Bug#8267).
7feda0d2 14286 * unexec.h: New file.
ce701a33
PE
14287 * deps.mk (emacs.o, unexaix.o, unexcw.o, unexcoff.o, unexelf.o):
14288 (unexhp9k800.o, unexmacosx.o, unexsol.o, unexw32.o):
14289 Depend on unexec.h.
14290 * emacs.c [!defined CANNOT_DUMP]: Include unexec.h.
14291 * unexaix.c, unexcoff.c, unexcw.c, unexelf.c, unexhp9k800.c:
14292 * unexmacosx.c, unexsol.c, unexw32.c: Include unexec.h.
381259ef 14293 Change as necessary to match prototype in unexec.h.
ce701a33 14294
01f44d5a
PE
14295 * syntax.c (Fforward_comment, scan_lists): Rename locals to avoid
14296 shadowing.
4f63c6bb 14297 (back_comment, skip_chars): Mark vars as initialized.
01f44d5a 14298
a6670b0b
PE
14299 * character.h (FETCH_STRING_CHAR_ADVANCE_NO_CHECK, BUF_INC_POS):
14300 Rename locals to avoid shadowing.
14301
cef2010d 14302 * lread.c (read1): Rewrite so as not to use empty "else".
0902fe45 14303 (Fload, readevalloop, read1): Rename locals to avoid shadowing.
cef2010d 14304
d4d7173a
PE
14305 * print.c (Fredirect_debugging_output): Fix pointer signedess.
14306
f08b802a
PE
14307 * lisp.h (debug_output_compilation_hack): Add decl here, to avoid
14308 warning when compiling print.c.
14309
3ddb0639
PE
14310 * font.c (font_unparse_fcname): Abort in an "impossible" situation
14311 instead of using an uninitialized var.
5ad03b97 14312 (font_sort_entities): Mark var as initialized.
3ddb0639 14313
170a2692
PE
14314 * character.h (FETCH_CHAR_ADVANCE): Rename locals to avoid shadowing.
14315
e663c700
PE
14316 * font.c (font_unparse_xlfd): Don't mix pointers to variables with
14317 pointers to constants.
89bc529a 14318 (font_parse_fcname): Remove unused vars.
7b81e2d0 14319 (font_delete_unmatched): Now static.
ea838e10 14320 (font_get_spec): Remove; unused.
13a547c6
PE
14321 (font_style_to_value, font_prop_validate_style, font_unparse_fcname):
14322 (font_update_drivers, Ffont_get_glyphs, font_add_log):
14323 Rename or move locals to avoid shadowing.
e663c700 14324
2a80c887 14325 * fns.c (require_nesting_list, require_unwind): Now static.
612f56df 14326 (Ffillarray): Rename locals to avoid shadowing.
2a80c887 14327
1384fa33 14328 * floatfns.c (domain_error2): Define only if needed.
a885e2ed 14329 (Ffrexp, Fldexp): Rename locals to avoid shadowing.
1384fa33 14330
8b2c52e9
PE
14331 * alloc.c (mark_backtrace): Move decl from here ...
14332 * lisp.h: ... to here, so that it can be checked.
14333
475545b5 14334 * eval.c (call_debugger, do_debug_on_call, grow_specpdl): Now static.
d28a2170 14335 (Fdefvar): Rewrite so as not to use empty "else".
cfcbfb1a
PE
14336 (lisp_indirect_variable): Name an expression,
14337 to avoid gcc -Wbad-function-cast warning.
1faed8ae 14338 (Fdefvar): Rename locals to avoid shadowing.
475545b5 14339
b1349114 14340 * callint.c (quotify_arg, quotify_args): Now static.
a3e8cbda 14341 (Fcall_interactively): Rename locals to avoid shadowing.
b0e80955 14342 Use const pointer when appropriate.
b1349114 14343
a2928364
PE
14344 * lisp.h (get_system_name, get_operating_system_release):
14345 Move decls here, to check interfaces.
14346 * process.c (get_operating_system_release): Move decl to lisp.h.
14347 * xrdb.c (get_system_name): Likewise.
63c5d10b
PE
14348 * editfns.c (init_editfns, Fuser_login_name, Fuser_uid):
14349 (Fuser_real_uid, Fuser_full_name): Remove unnecessary casts,
14350 some of which prompt warnings from gcc -Wbad-function-cast.
545b49b4
PE
14351 (Fformat_time_string, Fencode_time, Finsert_char):
14352 (Ftranslate_region_internal, Fformat):
14353 Rename or remove local vars to avoid shadowing.
9710023e 14354 (Ftranslate_region_internal): Mark var as initialized.
63c5d10b 14355
a415e694
PE
14356 * doc.c (Fdocumentation, Fsnarf_documentation): Move locals to
14357 avoid shadowing.
14358
8ef4622d
PE
14359 * lisp.h (eassert): Check that the argument compiles, even if
14360 ENABLE_CHECKING is not defined.
14361
946f9a5b
PE
14362 * data.c (Findirect_variable): Name an expression, to avoid
14363 gcc -Wbad-function-cast warning.
112396d6 14364 (default_value, arithcompare, arith_driver, arith_error): Now static.
b9b84fa9 14365 (store_symval_forwarding): Rename local to avoid shadowing.
44f230aa
SM
14366 (Fmake_variable_buffer_local, Fmake_local_variable):
14367 Mark variables as initialized.
52746918 14368 (do_blv_forwarding, do_symval_forwarding): Remove; unused.
946f9a5b 14369
e5aab7e7 14370 * alloc.c (check_cons_list): Do not define unless GC_CHECK_CONS_LIST.
ae35e756
PE
14371 (Fmake_vector, Fvector, Fmake_byte_code, Fgarbage_collect):
14372 Rename locals to avoid shadowing.
dff45157
PE
14373 (mark_stack): Move local variables into the #ifdef region where
14374 they're used.
7bc26fdb
PE
14375 (BLOCK_INPUT_ALLOC, UNBLOCK_INPUT_ALLOC): Define only if
14376 ! defined SYSTEM_MALLOC && ! defined SYNC_INPUT, as they are not
14377 needed otherwise.
14378 (CHECK_ALLOCATED): Define only if GC_CHECK_MARKED_OBJECTS.
14379 (GC_STRING_CHARS): Remove; not used.
d40d4be1 14380 (Fmemory_limit): Cast sbrk's returned value to char *.
ae35e756 14381
e5aab7e7
PE
14382 * lisp.h (check_cons_list): Declare if GC_CHECK_CONS_LIST; this
14383 avoids undefined behavior in theory.
14384
4da60324
PE
14385 * regex.c (IF_LINT): Add defn, for benefit of ../lib-src.
14386
88043301
PE
14387 Use functions, not macros, for up- and down-casing (Bug#8254).
14388 * buffer.h (DOWNCASE_TABLE, UPCASE_TABLE, DOWNCASE, UPPERCASEP):
14389 (NOCASEP, LOWERCASEP, UPCASE, UPCASE1): Remove. All callers changed
14390 to use the following functions instead of these macros.
14391 (downcase): Adjust to lack of DOWNCASE_TABLE. Return int, not
14392 EMACS_INT, since callers assume the returned value fits in int.
14393 (upcase1): Likewise, for UPCASE_TABLE.
14394 (uppercasep, lowercasep, upcase): New static inline functions.
0da09c43 14395 * editfns.c (Fchar_equal): Remove no-longer-needed workaround for
db69b0cd 14396 the race-condition problem in the old DOWNCASE.
88043301 14397
19ed5445
PE
14398 * regex.c (CHARSET_LOOKUP_RANGE_TABLE_RAW, POP_FAILURE_REG_OR_COUNT):
14399 Rename locals to avoid shadowing.
14400 (regex_compile, re_match_2_internal): Move locals to avoid shadowing.
abbd1bcf
PE
14401 (regex_compile, re_search_2, re_match_2_internal):
14402 Remove unused local vars.
952db0d7
PE
14403 (FREE_VAR): Rewrite so as not to use empty "else",
14404 which gcc can warn about.
da053e48 14405 (regex_compile, re_match_2_internal): Mark locals as initialized.
b313f9d8
PE
14406 (RETALLOC_IF): Define only if needed.
14407 (WORDCHAR_P): Likewise. This one is never needed, but is used
14408 only in a comment talking about a compiler bug, so put inside
14409 the #if 0 of that comment.
14410 (CHARSET_LOOKUP_BITMAP, FAIL_STACK_FULL, RESET_FAIL_STACK):
14411 (PUSH_FAILURE_ELT, BUF_PUSH_3, STOP_ADDR_VSTRING):
14412 Remove; unused.
19ed5445 14413
1f3561e4 14414 * search.c (boyer_moore): Rename locals to avoid shadowing.
76ef09b7
PE
14415 * character.h (FETCH_STRING_CHAR_AS_MULTIBYTE_ADVANCE):
14416 (PREV_CHAR_BOUNDARY): Likewise.
1f3561e4 14417
ded6f8f7
PE
14418 * search.c (simple_search): Remove unused var.
14419
dbd37a95
PE
14420 * dired.c (compile_pattern): Move decl from here ...
14421 * lisp.h: ... to here, so that it can be checked.
14422 (struct re_registers): New forward decl.
14423
7e47afad
PE
14424 * character.h (INC_POS, DEC_POS): Rename locals to avoid shadowing.
14425
85f24f61
PE
14426 * indent.c (MULTIBYTE_BYTES_WIDTH): New args bytes, width.
14427 All uses changed.
14428 (MULTIBYTE_BYTES_WIDTH, scan_for_column, compute_motion):
14429 Rename locals to avoid shadowing.
5671df8f 14430 (Fvertical_motion): Mark locals as initialized.
85f24f61 14431
181aa2be 14432 * casefiddle.c (casify_object, casify_region): Now static.
e45a141a 14433 (casify_region): Mark local as initialized.
181aa2be 14434
930d429c
PE
14435 * cmds.c (internal_self_insert): Rename local to avoid shadowing.
14436
7082eac6
PE
14437 * lisp.h (GCPRO2_VAR, GCPRO3_VAR, GCPRO4_VAR, GCPRO5_VAR, GCPRO6_VAR):
14438 New macros, so that the caller can use some names other than
14439 gcpro1, gcpro2, etc.
14440 (GCPRO2, GCPRO3, GCPRO4, GCPRO5, GCPRO6): Reimplement in terms
14441 of the new macros.
14442 (GCPRO1_VAR, UNGCPRO_VAR): Change the meaning of the second
14443 argument, for consistency with GCPRO2_VAR, etc: it is now the
14444 prefix of the variable, not the variable itself. All uses
14445 changed.
38b2c076
PE
14446 * dired.c (directory_files_internal, file_name_completion):
14447 Rename locals to avoid shadowing.
14448
15206ed9
PE
14449 Fix a race condition diagnosed by gcc -Wsequence-point (Bug#8254).
14450 An expression of the form (DOWNCASE (x) == DOWNCASE (y)), found in
14451 dired.c's scmp function, had undefined behavior.
14452 * lisp.h (DOWNCASE_TABLE, UPCASE_TABLE, DOWNCASE, UPPERCASEP):
14453 (NOCASEP, LOWERCASEP, UPCASE, UPCASE1): Move from here ...
14454 * buffer.h: ... to here, because these macros use current_buffer,
14455 and the new implementation with inline functions needs to have
14456 current_buffer in scope now, rather than later when the macros
14457 are used.
14458 (downcase, upcase1): New static inline functions.
14459 (DOWNCASE, UPCASE1): Reimplement using these functions.
14460 This avoids undefined behavior in expressions like
14461 DOWNCASE (x) == DOWNCASE (y), which previously suffered
14462 from race conditions in accessing the global variables
14463 case_temp1 and case_temp2.
14464 * casetab.c (case_temp1, case_temp2): Remove; no longer needed.
14465 * lisp.h (case_temp1, case_temp2): Remove their decls.
14466 * character.h (ASCII_CHAR_P): Move from here ...
14467 * lisp.h: ... to here, so that the inline functions mentioned
14468 above can use them.
14469
4a6bea26
PE
14470 * dired.c (directory_files_internal_unwind): Now static.
14471
f14b7e14
PE
14472 * fileio.c (file_name_as_directory, directory_file_name):
14473 (barf_or_query_if_file_exists, auto_save_error, auto_save_1):
14474 Now static.
2893f146
PE
14475 (file_name_as_directory): Use const pointers when appropriate.
14476 (Fexpand_file_name): Likewise. In particular, newdir might
14477 point at constant storage, so make it a const pointer.
fd4ead52 14478 (Fmake_directory_internal, Fread_file_name): Remove unused vars.
b14aac08
PE
14479 (Ffile_selinux_context, Fset_file_selinux_context): Fix pointer
14480 signedness issues.
f839df0c
PE
14481 (Fset_file_times, Finsert_file_contents, auto_save_error):
14482 Rename locals to avoid shadowing.
f14b7e14 14483
5716756e 14484 * minibuf.c (choose_minibuf_frame_1): Now static.
62137a95
PE
14485 (Ftry_completion, Fall_completions): Rename or remove locals
14486 to avoid shadowing.
5716756e 14487
b4c3046a
PE
14488 * marker.c (bytepos_to_charpos): Remove; unused.
14489
b45db522
PE
14490 * lisp.h (verify_bytepos, count_markers): New decls,
14491 so that gcc does not warn that these functions aren't declared.
14492
85876d07
PE
14493 * insdel.c (check_markers, make_gap_larger, make_gap_smaller):
14494 (reset_var_on_error, Fcombine_after_change_execute_1): Now static.
f0cb4a60 14495 (CHECK_MARKERS): Redo to avoid gcc -Wempty-body diagnostic.
40ef059e 14496 (copy_text): Remove unused local var.
85876d07 14497
03d78a21 14498 * filelock.c (within_one_second): Now static.
b3dd38ab 14499 (lock_file_1): Rename local to avoid shadowing.
03d78a21 14500
5df8f01b
PE
14501 * buffer.c (fix_overlays_before): Mark locals as initialized.
14502 (fix_start_end_in_overlays): Likewise. This function should be
14503 simplified by using pointers-to-pointers, but that's a different
14504 matter.
b1d876f1 14505 (switch_to_buffer_1): Now static.
8f54f30a
PE
14506 (Fkill_buffer, record_buffer, Fbury_buffer, Fset_buffer_multibyte):
14507 (report_overlay_modification): Rename locals to avoid shadowing.
c3bd59b5 14508
a70072c9 14509 * sysdep.c (system_process_attributes): Rename vars to avoid shadowing.
fbd02d7b 14510 Fix pointer signedness issue.
edced198
PE
14511 (sys_subshell): Mark local as volatile if checking for lint,
14512 to suppress a gcc -Wclobbered warning that does not seem to be right.
15dfd3d9 14513 (MAXPATHLEN): Define only if needed.
a70072c9 14514
a0977c44
PE
14515 * process.c (serial_open, serial_configure): Move decls from here ...
14516 * systty.h: ... to here, so that they can be checked.
14517
a884fdcc
PE
14518 * fns.c (get_random, seed_random): Move extern decls from here ...
14519 * lisp.h: ... to here, so that they can be checked.
14520
604efe86 14521 * sysdep.c (reset_io): Now static.
b8950c94 14522 (wait_for_termination_signal): Remove; unused.
604efe86 14523
38fc62d9
PE
14524 * keymap.c (keymap_parent, keymap_memberp, map_keymap_internal):
14525 (copy_keymap_item, append_key, push_text_char_description):
14526 Now static.
1004a21a 14527 (Fwhere_is_internal): Don't test CONSP (sequences) unnecessarily.
dbbb8427 14528 (DENSE_TABLE_SIZE): Remove; unused.
c1141155
PE
14529 (get_keymap, access_keymap, Fdefine_key, Fwhere_is_internal):
14530 (describe_map_tree):
14531 Rename locals to avoid shadowing.
38fc62d9 14532
2f2650da
PE
14533 * keyboard.c: Declare functions static if they are not used elsewhere.
14534 (echo_char, echo_dash, cmd_error, top_level_2):
14535 (poll_for_input, handle_async_input): Now static.
69a058fa
PE
14536 (read_char, kbd_buffer_get_event, make_lispy_position):
14537 (make_lispy_event, make_lispy_movement, apply_modifiers):
14538 (decode_keyboard_code, tty_read_avail_input, menu_bar_items):
14539 (parse_tool_bar_item, read_key_sequence, Fread_key_sequence):
14540 (Fread_key_sequence_vector): Rename locals to avoid shadowing.
c8a06054 14541 (read_key_sequence, read_char): Mark locals as initialized.
3ac94672 14542 (Fexit_recursive_edit, Fabort_recursive_edit): Mark with NO_RETURN.
2f2650da 14543
a053e86c 14544 * keyboard.h (make_ctrl_char): New decl.
da2f2dd9
PE
14545 (mark_kboards): Move decl here ...
14546 * alloc.c (mark_kboards): ... from here.
a053e86c 14547
4752793e
PE
14548 * lisp.h (force_auto_save_soon): New decl.
14549
74f10ca7 14550 * emacs.c (init_cmdargs): Rename local to avoid shadowing.
244fc23d
PE
14551 (DEFINE_DUMMY_FUNCTION): New macro.
14552 (__do_global_ctors, __do_global_ctors_aux, __do_global_dtors, __main):
14553 Use it.
c03cd23f
PE
14554 (main): Add casts to avoid warnings
14555 if GCC considers string literals to be constants.
74f10ca7 14556
022e70d4
PE
14557 * lisp.h (fatal_error_signal): Add decl, since it's exported.
14558
59d6fe83
PE
14559 * dbusbind.c: Pointer signedness fixes.
14560 (xd_signature, xd_append_arg, xd_initialize):
14561 (Fdbus_call_method, Fdbus_call_method_asynchronously):
14562 (Fdbus_method_return_internal, Fdbus_method_error_internal):
14563 (Fdbus_send_signal, xd_read_message_1, Fdbus_register_service):
14564 (Fdbus_register_signal): Use SSDATA when the context wants char *.
14565
78320123
PE
14566 * dbusbind.c (Fdbus_init_bus): Add cast to avoid warning
14567 if GCC considers string literals to be constants.
49cebcca 14568 (Fdbus_register_service, Fdbus_register_method): Remove unused vars.
78320123 14569
35ac2a97
SM
145702011-03-16 Stefan Monnier <monnier@iro.umontreal.ca>
14571
fb103ca9
SM
14572 * print.c (PRINT_CIRCLE_CANDIDATE_P): New macro.
14573 (print_preprocess, print_object): New macro to fix last change.
14574
35ac2a97
SM
14575 * print.c (print_preprocess): Don't forget font objects.
14576
62973b41
JB
145772011-03-16 Juanma Barranquero <lekktu@gmail.com>
14578
14579 * emacs.c (USAGE3): Doc fixes.
14580
0e48bb22
AS
145812011-03-15 Andreas Schwab <schwab@linux-m68k.org>
14582
14583 * coding.c (detect_coding_iso_2022): Reorganize code to clarify
14584 structure.
14585
7684e57b
JB
145862011-03-14 Juanma Barranquero <lekktu@gmail.com>
14587
14588 * lisp.h (VWindow_system, Qfile_name_history):
14589 * keyboard.h (lispy_function_keys) [WINDOWSNT]:
14590 * w32term.h (w32_system_caret_hwnd, w32_system_caret_height)
14591 (w32_system_caret_x, w32_system_caret_y): Declare extern.
14592
14593 * w32select.c: Don't #include "keyboard.h".
c96bbc66 14594 (run_protected): Add extern declaration for waiting_for_input.
7684e57b
JB
14595
14596 * w32.c (Qlocal, noninteractive1, inhibit_window_system):
14597 * w32console.c (detect_input_pending, read_input_pending)
14598 (encode_terminal_code):
14599 * w32fns.c (quit_char, lispy_function_keys, Qtooltip)
14600 (w32_system_caret_hwnd, w32_system_caret_height, w32_system_caret_x)
14601 (w32_system_caret_y, Qfile_name_history):
14602 * w32font.c (w32font_driver, QCantialias, QCotf, QClang):
14603 * w32inevt.c (reinvoke_input_signal, lispy_function_keys):
14604 * w32menu.c (Qmenu_bar, QCtoggle, QCradio, Qoverriding_local_map)
14605 (Qoverriding_terminal_local_map, Qmenu_bar_update_hook):
14606 * w32proc.c (Qlocal, report_file_error):
14607 * w32term.c (Vwindow_system, updating_frame):
14608 * w32uniscribe.c (initialized, uniscribe_font_driver):
14609 Remove unneeded extern declarations.
14610
2aa46d6c
CY
146112011-03-14 Chong Yidong <cyd@stupidchicken.com>
14612
c96bbc66 14613 * buffer.c (Fmake_indirect_buffer): Fix incorrect assertions.
2aa46d6c 14614
cffc6f3b
CY
146152011-03-13 Chong Yidong <cyd@stupidchicken.com>
14616
14617 * buffer.h (BUF_BEGV, BUF_BEGV_BYTE, BUF_ZV, BUF_ZV_BYTE, BUF_PT)
14618 (BUF_PT_BYTE): Rewrite to handle indirect buffers (Bug#8219).
14619 These macros can no longer be used for assignment.
14620
44f230aa
SM
14621 * buffer.c (Fget_buffer_create, Fmake_indirect_buffer):
14622 Assign struct members directly, instead of using BUF_BEGV etc.
cffc6f3b
CY
14623 (record_buffer_markers, fetch_buffer_markers): New functions for
14624 recording and fetching special buffer markers.
14625 (set_buffer_internal_1, set_buffer_temp): Use them.
14626
14627 * lread.c (unreadchar): Use SET_BUF_PT_BOTH.
14628
14629 * insdel.c (adjust_point): Use SET_BUF_PT_BOTH.
14630
14631 * intervals.c (temp_set_point_both): Use SET_BUF_PT_BOTH.
14632 (get_local_map): Use SET_BUF_BEGV_BOTH and SET_BUF_ZV_BOTH.
14633
14634 * xdisp.c (hscroll_window_tree):
14635 (reconsider_clip_changes): Use PT instead of BUF_PT.
14636
d251f04b
EZ
146372011-03-13 Eli Zaretskii <eliz@gnu.org>
14638
14639 * makefile.w32-in ($(BLD)/editfns.$(O)): Depend on
14640 $(EMACS_ROOT)/lib/intprops.h.
14641
f0c77cd1
PE
146422011-03-13 Paul Eggert <eggert@cs.ucla.edu>
14643
3eca4629
PE
14644 Fix more problems found by GCC 4.5.2's static checks.
14645
7c86ee98
PE
14646 * gtkutil.c (xg_get_pixbuf_from_pixmap): Add cast from char *
14647 to unsigned char * to avoid compiler diagnostic.
b0afc268
PE
14648 (xg_free_frame_widgets): Make it clear that a local variable is
14649 needed only if USE_GTK_TOOLTIP.
01e0b5ad
PE
14650 (gdk_window_get_screen): Make it clear that this macro is needed
14651 only if USE_GTK_TOOLTIP.
1e5524e7
PE
14652 (int_gtk_range_get_value): New function, which avoids a diagnostic
14653 from gcc -Wbad-function-cast.
14654 (xg_set_toolkit_scroll_bar_thumb): Use it.
14655 (xg_tool_bar_callback, xg_tool_item_stale_p): Rewrite to avoid
14656 diagnostic from gcc -Wbad-function-cast.
65dc836c
PE
14657 (get_utf8_string, xg_get_file_with_chooser):
14658 Rename locals to avoid shadowing.
14659 (create_dialog): Move locals to avoid shadowing.
7c86ee98 14660
41729b81
PE
14661 * xgselect.c (xg_select): Remove unused var.
14662
f0c77cd1
PE
14663 * image.c (four_corners_best): Mark locals as initialized.
14664 (gif_load): Initialize transparent_p to zero (Bug#8238).
14665 Mark another local as initialized.
ec6cf4c6 14666 (my_png_error, my_error_exit): Mark with NO_RETURN.
f0c77cd1 14667
ce0ad53d 14668 * image.c (clear_image_cache): Now static.
d5d5a617 14669 (DIM, HAVE_STDLIB_H_1): Remove unused macros.
e22cffbc 14670 (xpm_load): Redo to avoid "discards qualifiers" gcc warning.
77a765fd
PE
14671 (x_edge_detection): Remove unnecessary cast that
14672 gcc -Wbad-function-cast diagnoses.
2037898d 14673 (gif_load): Fix pointer signedness.
6ae141d6
PE
14674 (clear_image_cache, xbm_read_bitmap_data, x_detect_edges):
14675 (jpeg_load, gif_load): Rename locals to avoid shadowing.
ce0ad53d 14676
33383987 146772011-03-12 Paul Eggert <eggert@cs.ucla.edu>
3eca4629 14678
d32df629
PE
14679 Improve quality of tests for time stamp overflow.
14680 For example, without this patch (encode-time 0 0 0 1 1
14681 1152921504606846976) returns the obviously-bogus value (-948597
14682 62170) on my RHEL 5.5 x86-64 host. With the patch, it correctly
14683 reports time overflow. See
14684 <http://lists.gnu.org/archive/html/emacs-devel/2011-03/msg00470.html>.
b8d9bd41
PE
14685 * deps.mk (editfns.o): Depend on ../lib/intprops.h.
14686 * editfns.c: Include limits.h and intprops.h.
14687 (TIME_T_MIN, TIME_T_MAX): New macros.
14688 (time_overflow): Move earlier, to before first use.
14689 (hi_time, lo_time): New functions, for an accurate test for
14690 out-of-range times.
14691 (Fcurrent_time, Fget_internal_run_time, make_time): Use them.
14692 (Fget_internal_run_time): Don't assume time_t fits in int.
14693 (make_time): Use list2 instead of Fcons twice.
14694 (Fdecode_time): More accurate test for out-of-range times.
14695 (check_tm_member): New function.
14696 (Fencode_time): Use it, to test for out-of-range times.
d32df629
PE
14697 (lisp_time_argument): Don't rely on undefined left-shift and
14698 right-shift behavior when checking for time stamp overflow.
8be6f318 14699
fe31d94c
PE
14700 * editfns.c (time_overflow): New function, refactoring common code.
14701 (Fformat_time_string, Fdecode_time, Fencode_time):
14702 (Fcurrent_time_string): Use it.
14703
8be6f318
PE
14704 Move 'make_time' to be next to its inverse 'lisp_time_argument'.
14705 * dired.c (make_time): Move to ...
14706 * editfns.c (make_time): ... here.
14707 * systime.h: Note the move.
14708
09d9db2c 147092011-03-12 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
c47cbdfd 14710
126bc0dc
YM
14711 * fringe.c (update_window_fringes): Remove unused variables.
14712
c47cbdfd
YM
14713 * unexmacosx.c (copy_data_segment): Also copy __got section.
14714 (Bug#8223)
14715
7ac80be9
EZ
147162011-03-12 Eli Zaretskii <eliz@gnu.org>
14717
c96bbc66 14718 * termcap.c [MSDOS]: Include "msdos.h".
058e5dad
EZ
14719 (find_capability, tgetnum, tgetflag, tgetstr, tputs, tgetent):
14720 Constify `char *' arguments and their references according to
14721 prototypes in tparam.h.
14722
ecb0f94d 14723 * deps.mk (termcap.o): Depend on tparam.h and msdos.h.
058e5dad 14724
7ac80be9
EZ
14725 * msdos.c (XMenuAddPane): 3rd argument is `const char *' now.
14726 Adapt all references accordingly.
14727
14728 * msdos.h (XMenuAddPane): 3rd argument is `const char *' now.
14729
ef1fd07e
TT
147302011-03-11 Tom Tromey <tromey@redhat.com>
14731
14732 * buffer.c (syms_of_buffer): Remove obsolete comment.
14733
7ef4b50c
EZ
147342011-03-11 Eli Zaretskii <eliz@gnu.org>
14735
14736 * termhooks.h (encode_terminal_code): Declare prototype.
14737
14738 * msdos.c (encode_terminal_code): Don't declare prototype.
14739
14740 * term.c (encode_terminal_code): Now external again, used by
14741 w32console.c and msdos.c.
14742
44f230aa
SM
14743 * makefile.w32-in ($(BLD)/term.$(O), ($(BLD)/tparam.$(O)):
14744 Depend on $(SRC)/tparam.h, see 2011-03-11T07:24:21Z!eggert@cs.ucla.edu.
7ef4b50c 14745
4b1ec863 147462011-03-11 Paul Eggert <eggert@cs.ucla.edu>
f78faa98 14747
1714f52b 14748 Fix some minor problems found by GCC 4.5.2's static checks.
83316bf4 14749
4b1ec863
PE
14750 * fringe.c (update_window_fringes): Mark locals as initialized
14751 (Bug#8227).
14752 (destroy_fringe_bitmap, init_fringe_bitmap): Now static.
bf60f616 14753
524c7aa6
PE
14754 * alloc.c (mark_fringe_data): Move decl from here ...
14755 * lisp.h (mark_fringe_data) [HAVE_WINDOW_SYSTEM]: ... to here,
14756 to check its interface.
14757 (init_fringe_once): Do not declare unless HAVE_WINDOW_SYSTEM.
14758
a5c0af81 14759 * fontset.c (free_realized_fontset): Now static.
7519b8cd 14760 (Fset_fontset_font): Rename local to avoid shadowing.
cc6e5db1 14761 (fontset_font): Mark local as initialized.
a9a06e0b 14762 (FONTSET_SPEC, FONTSET_REPERTORY, RFONT_DEF_REPERTORY): Remove; unused.
a5c0af81 14763
b4716021
PE
14764 * xrdb.c: Include "xterm.h", to check x_load_resources's interface.
14765
811e9bac 14766 * xselect.c (x_disown_buffer_selections): Remove; not used.
7b83e2f1 14767 (TRACE3) [!defined TRACE_SELECTION]: Remove; not used.
aa0daa9f
PE
14768 (x_own_selection, Fx_disown_selection_internal): Rename locals
14769 to avoid shadowing.
14770 (x_handle_dnd_message): Remove local to avoid shadowing.
811e9bac 14771
7e3ab302
PE
14772 * lisp.h (GCPRO1_VAR, UNGCPRO_VAR): New macros,
14773 so that the caller can use some name other than gcpro1.
14774 (GCPRO1, UNGCPRO): Reimplement in terms of the new macros.
58d2d479
PE
14775 * xfns.c (Fx_create_frame, x_create_tip_frame, Fx_show_tip):
14776 (Fx_backspace_delete_keys_p):
14777 Use them to avoid shadowing, and rename vars to avoid shadowing.
14778 (x_decode_color, x_set_name, x_window): Now static.
6b437900 14779 (Fx_create_frame): Add braces to silence GCC warning.
c0951e53 14780 (Fx_file_dialog, Fx_select_font): Fix pointer signedness.
06b0c8a0
PE
14781 (x_real_positions, xg_set_icon_from_xpm_data, x_create_tip_frame):
14782 Remove unused locals.
7e3ab302
PE
14783 (Fx_create_frame, x_create_tip_frame, Fx_show_tip):
14784 (Fx_backspace_delete_keys_p): Rename locals to avoid shadowing.
14785 Some of these renamings use the new GCPRO1_VAR and UNGCPRO_VAR
14786 macros.
f78faa98 14787
e2b13473
PE
14788 * xterm.h (x_mouse_leave): New decl.
14789
77f23912
PE
14790 * xterm.c (x_copy_dpy_color, x_focus_on_frame, x_unfocus_frame):
14791 Remove unused functions.
cdf4ba58
PE
14792 (x_shift_glyphs_for_insert, XTflash, XTring_bell):
14793 (x_calc_absolute_position): Now static.
7411c686 14794 (XTread_socket): Don't define label "out" unless it's used.
2b07bcff 14795 Don't declare local "event" unless it's used.
ed7bf3a5
PE
14796 (x_iconify_frame, x_free_frame_resources): Don't declare locals
14797 unless they are used.
38d0b34a
PE
14798 (XEMBED_VERSION, xembed_set_info): Don't define unless needed.
14799 (x_fatal_error_signal): Remove; not used.
a6067996
PE
14800 (x_draw_image_foreground, redo_mouse_highlight, XTmouse_position):
14801 (x_scroll_bar_report_motion, handle_one_xevent, x_draw_bar_cursor):
14802 (x_error_catcher, x_connection_closed, x_error_handler):
14803 (x_error_quitter, xembed_send_message, x_iconify_frame):
14804 (my_log_handler): Rename locals to avoid shadowing.
28f1c698 14805 (x_delete_glyphs, x_ins_del_lines): Mark with NO_RETURN.
2a8fade0 14806 (x_connection_closed): Tell GCC not to suggest NO_RETURN.
77f23912 14807
44f230aa
SM
14808 * xfaces.c (clear_face_cache, Fx_list_fonts, Fface_font):
14809 Rename or move locals to avoid shadowing.
6b463e58 14810 (tty_defined_color, merge_face_heights): Now static.
5967d051 14811 (free_realized_faces_for_fontset): Remove; not used.
1e9966ea
PE
14812 (Fx_list_fonts): Mark variable that gcc -Wuninitialized
14813 does not deduce is never used uninitialized.
73719eba
PE
14814 (STRDUPA, LSTRDUPA, FONT_POINT_SIZE_QUANTUM): Remove; not used.
14815 (LFACEP): Define only if XASSERTS, as it's not needed otherwise.
071048a3 14816
426994c3 14817 * terminal.c (store_terminal_param): Now static.
5489860b 14818
032f1620 14819 * xmenu.c (menu_highlight_callback): Now static.
9d66f88e 14820 (set_frame_menubar): Remove unused local.
d4323972 14821 (xmenu_show): Rename parameter to avoid shadowing.
6d1f7fee
PE
14822 (xmenu_show, xdialog_show, xmenu_show): Make local pointers "const"
14823 since they might point to immutable storage.
281585b0
PE
14824 (next_menubar_widget_id): Declare only if USE_X_TOOLKIT,
14825 since it's unused otherwise.
032f1620 14826
367c19e5 14827 * xdisp.c (produce_glyphless_glyph): Initialize lower_xoff.
53df7c11 14828 Add a FIXME, since the code still doesn't look right. (Bug#8215)
9f36b9fd
PE
14829 (Fcurrent_bidi_paragraph_direction): Simplify slightly; this
14830 avoids a gcc -Wuninitialized diagnostic.
0e086e8f 14831 (display_line, BUILD_COMPOSITE_GLYPH_STRING, draw_glyphs):
44a3a108
PE
14832 (note_mouse_highlight): Mark variables that gcc -Wuninitialized
14833 does not deduce are never used uninitialized.
70739cbe 14834
07b48fa9
PE
14835 * lisp.h (IF_LINT): New macro, copied from ../lib-src/emacsclient.c.
14836
8868a238 14837 * xdisp.c (redisplay_window): Rename local to avoid shadowing.
4554d213
PE
14838 * window.c (window_loop, size_window):
14839 (run_window_configuration_change_hook, enlarge_window): Likewise.
8868a238 14840
7e5cf297 14841 * window.c (display_buffer): Now static.
d6550a9f
PE
14842 (size_window): Mark variables that gcc -Wuninitialized
14843 does not deduce are never used uninitialized.
a586633d
PE
14844 * window.h (check_all_windows): New decl, to forestall
14845 gcc -Wmissing-prototypes diagnostic.
5b555da1 14846 * dispextern.h (bidi_dump_cached_states): Likewise.
7e5cf297 14847
f6095868
PE
14848 * charset.h (CHECK_CHARSET_GET_CHARSET): Rename locals to avoid
14849 shadowing.
14850 * charset.c (map_charset_for_dump, Fchar_charset): Likewise.
726929c4
PE
14851 Include <limits.h>.
14852 (Fsort_charsets): Redo min/max calculation to shorten the code a bit
14853 and to avoid gcc -Wuninitialized warning.
89ef49df
PE
14854 (load_charset_map): Mark variables that gcc -Wuninitialized
14855 does not deduce are never used uninitialized.
53df7c11 14856 (load_charset): Abort instead of using uninitialized var (Bug#8229).
f6095868 14857
f38b440c
PE
14858 * coding.c (coding_set_source, coding_set_destination):
14859 Use "else { /* comment */ }" rather than "else /* comment */;"
14860 for clarity, and to avoid gcc -Wempty-body warning.
2735d060
PE
14861 (Fdefine_coding_system_internal): Don't redeclare 'i' inside
14862 a block, when the outer 'i' will do.
14863 (decode_coding_utf_8, decode_coding_utf_16, detect_coding_emacs_mule):
14864 (emacs_mule_char, decode_coding_emacs_mule, detect_coding_iso_2022):
14865 (decode_coding_iso_2022, decode_coding_sjis, decode_coding_big5):
14866 (decode_coding_raw_text, decode_coding_charset, get_translation_table):
14867 (Fdecode_sjis_char, Fdefine_coding_system_internal):
14868 Rename locals to avoid shadowing.
14869 * character.h (FETCH_STRING_CHAR_ADVANCE): Likewise.
e2f1bab9
PE
14870 * coding.c (emacs_mule_char, encode_invocation_designation):
14871 Now static, since they're not used elsewhere.
413bb2db 14872 (decode_coding_iso_2022): Add "default: abort ();" as a safety check.
c4a63b12 14873 (decode_coding_object, encode_coding_object, detect_coding_system):
ee05f961
PE
14874 (decode_coding_emacs_mule): Mark variables that gcc
14875 -Wuninitialized does not deduce are never used uninitialized.
160b01f6
PE
14876 (detect_coding_iso_2022): Initialize a local variable that might
14877 be used uninitialized. Leave a FIXME because it's not clear that
53df7c11 14878 this initialization is needed. (Bug#8211)
5f58e762
PE
14879 (ISO_CODE_LF, ISO_CODE_CR, CODING_ISO_FLAG_EUC_TW_SHIFT):
14880 (ONE_MORE_BYTE_NO_CHECK, UTF_BOM, UTF_16_INVALID_P):
14881 (SHIFT_OUT_OK, ENCODE_CONTROL_SEQUENCE_INTRODUCER):
14882 (ENCODE_DIRECTION_R2L, ENCODE_DIRECTION_L2R):
14883 Remove unused macros.
f38b440c 14884
232b38b9 14885 * category.c (hash_get_category_set): Remove unused local var.
9f3b5e69 14886 (copy_category_table): Now static, since it's not used elsewhere.
d0891610 14887 * character.c (string_count_byte8): Likewise.
232b38b9 14888
fb90da1b
PE
14889 * ccl.c (CCL_WRITE_STRING, CCL_ENCODE_CHAR, Fccl_execute_on_string):
14890 (Fregister_code_conversion_map): Rename locals to avoid shadowing.
14891
fb93dbc2
PE
14892 * chartab.c (copy_sub_char_table): Now static, since it's not used
14893 elsewhere.
5c156ace
PE
14894 (sub_char_table_ref_and_range, char_table_ref_and_range):
14895 Rename locals to avoid shadowing.
bbcd0949 14896 (ASET_RANGE, GET_SUB_CHAR_TABLE): Remove unused macros.
fb93dbc2 14897
7d3b3862 14898 * bidi.c (bidi_check_type): Now static, since it's not used elsewhere.
630d6892 14899 (BIDI_BOB): Remove unused macro.
7d3b3862 14900
6be7d3da
PE
14901 * cm.c (cmgoto): Mark variables that gcc -Wuninitialized does not
14902 deduce are never used uninitialized.
c2ed9c8b 14903 * term.c (encode_terminal_code): Likewise.
6be7d3da 14904
75f8807f 14905 * term.c (encode_terminal_code): Now static. Remove unused local.
72abad34 14906
50938595
PE
14907 * tparam.h: New file.
14908 * term.c, tparam.h: Include it.
14909 * deps.mk (term.o, tparam.o): Depend on tparam.h.
14910 * term.c (tputs, tgetent, tgetflag, tgetnum, tparam, tgetstr):
14911 Move these decls to tparam.h, and make them agree with what
14912 is actually in tparam.c. The previous trick of using incompatible
14913 decls in different modules does not conform to the C standard.
14914 All callers of tparam changed to use tparam's actual API.
14915 * tparam.c (tparam1, tparam, tgoto):
14916 Use const pointers where appropriate.
14917
fbceeba2
PE
14918 * cm.c (calccost, cmgoto): Use const pointers where appropriate.
14919 * cm.h (struct cm): Likewise.
14920 * dispextern.h (do_line_insertion_deletion_costs): Likewise.
14921 * scroll.c (ins_del_costs, do_line_insertion_deletion_costs): Likewise.
14922 * term.c (tty_ins_del_lines, calculate_costs, struct fkey_table):
14923 (term_get_fkeys_1, append_glyphless_glyph, produce_glyphless_glyph):
14924 (turn_on_face, init_tty): Likewise.
14925 * termchar.h (struct tty_display_info): Likewise.
fbceeba2 14926
7f3f1250
PE
14927 * term.c (term_mouse_position): Rename local to avoid shadowing.
14928
e6ca6543
PE
14929 * alloc.c (mark_ttys): Move decl from here ...
14930 * lisp.h (mark_ttys): ... to here, so that it's checked against defn.
14931
c40f8d15
AS
149322011-03-11 Andreas Schwab <schwab@linux-m68k.org>
14933
14934 * .gdbinit (pwinx, xbuffer): Fix access to buffer name.
14935
cfe0661d
JB
149362011-03-09 Juanma Barranquero <lekktu@gmail.com>
14937
14938 * search.c (compile_pattern_1): Remove argument regp, unused since
14939 revid:rms@gnu.org-19941211082627-3x1g1wyqkjmwloig.
14940 (compile_pattern): Don't pass it.
14941
0afb4571
J
149422011-03-08 Jan Djärv <jan.h.d@swipnet.se>
14943
14944 * xterm.h (DEFAULT_GDK_DISPLAY): New define.
14945 (GDK_WINDOW_XID, gtk_widget_get_preferred_size): New defines
14946 for ! HAVE_GTK3.
14947 (GTK_WIDGET_TO_X_WIN): Use GDK_WINDOW_XID.
14948
14949 * xmenu.c (menu_position_func): Call gtk_widget_get_preferred_size.
14950
14951 * gtkutil.c: Include gtkx.h if HAVE_GTK3. If ! HAVE_GTK3, define
14952 gdk_window_get_screen, gdk_window_get_geometry,
14953 gdk_x11_window_lookup_for_display and GDK_KEY_g.
14954 (xg_set_screen): Use DEFAULT_GDK_DISPLAY.
14955 (xg_get_pixbuf_from_pixmap): New function.
14956 (xg_get_pixbuf_from_pix_and_mask): Change parameters from GdkPixmap
14957 to Pixmap, take frame as parameter, remove GdkColormap parameter.
14958 Call xg_get_pixbuf_from_pixmap instead of
14959 gdk_pixbuf_get_from_drawable.
14960 (xg_get_image_for_pixmap): Do not make GdkPixmaps, call
14961 xg_get_pixbuf_from_pix_and_mask with Pixmap parameters instead.
14962 (xg_check_special_colors): Use GtkStyleContext and its functions
14963 for HAVE_GTK3.
14964 (xg_prepare_tooltip, xg_hide_tooltip): Call gdk_window_get_screen.
14965 (xg_prepare_tooltip, create_dialog, menubar_map_cb)
14966 (xg_update_frame_menubar, xg_tool_bar_detach_callback)
44f230aa
SM
14967 (xg_tool_bar_attach_callback, xg_update_tool_bar_sizes):
14968 Call gtk_widget_get_preferred_size.
0afb4571
J
14969 (xg_frame_resized): gdk_window_get_geometry only takes 5
14970 parameters.
44f230aa
SM
14971 (xg_win_to_widget, xg_event_is_for_menubar):
14972 Call gdk_x11_window_lookup_for_display.
0afb4571
J
14973 (xg_set_widget_bg): New function.
14974 (delete_cb): New function.
895009e1 14975 (xg_create_frame_widgets): Connect delete-event to delete_cb.
5c32d3f2 14976 Call xg_set_widget_bg. Only set background pixmap for ! HAVE_GTK3
0afb4571
J
14977 (xg_set_background_color): Call xg_set_widget_bg.
14978 (xg_set_frame_icon): Call xg_get_pixbuf_from_pix_and_mask.
14979 (xg_create_scroll_bar): vadj is a GtkAdjustment for HAVE_GTK3.
14980 Only call gtk_range_set_update_policy if ! HAVE_GTK3.
14981 (xg_make_tool_item): Only connect xg_tool_bar_item_expose_callback
14982 if ! HAVE_GTK3.
14983 (update_frame_tool_bar): Call gtk_widget_hide.
14984 (xg_initialize): Use GDK_KEY_g.
14985
14986 * xsmfns.c (gdk_set_sm_client_id): Define to gdk_set_sm_client_id
14987 if ! HAVE_GTK3
14988 (x_session_initialize): Call gdk_x11_set_sm_client_id.
14989
14990 * xterm.c (XFillRectangle): Use cairo routines for HAVE_GTK3.
14991 (x_term_init): Disable Xinput(2) with GDK_CORE_DEVICE_EVENTS.
14992 Load ~/emacs.d/gtkrc only for ! HAVE_GTK3.
14993
1c2cc4ef
JB
149942011-03-08 Juanma Barranquero <lekktu@gmail.com>
14995
14996 * w32xfns.c (select_palette): Check success of RealizePalette against
14997 GDI_ERROR, not zero.
14998
33383987 14999See ChangeLog.11 for earlier changes.
aac0c6e3
MR
15000
15001;; Local Variables:
15002;; coding: utf-8
aac0c6e3
MR
15003;; End:
15004
2f097256 15005 Copyright (C) 2011-2012 Free Software Foundation, Inc.
aac0c6e3
MR
15006
15007 This file is part of GNU Emacs.
15008
15009 GNU Emacs is free software: you can redistribute it and/or modify
15010 it under the terms of the GNU General Public License as published by
15011 the Free Software Foundation, either version 3 of the License, or
15012 (at your option) any later version.
15013
15014 GNU Emacs is distributed in the hope that it will be useful,
15015 but WITHOUT ANY WARRANTY; without even the implied warranty of
15016 MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
15017 GNU General Public License for more details.
15018
15019 You should have received a copy of the GNU General Public License
15020 along with GNU Emacs. If not, see <http://www.gnu.org/licenses/>.