* src/image.c (gif_load): Fix calculation of bottom and right corner.
[bpt/emacs.git] / src / ChangeLog
CommitLineData
8d903f4e
AS
12011-09-10 Andreas Schwab <schwab@linux-m68k.org>
2
3 * image.c (gif_load): Fix calculation of bottom and right corner.
4 (Bug#9468)
5
80ad64f4
EZ
62011-09-10 Eli Zaretskii <eliz@gnu.org>
7
8 * xdisp.c (MAX_DISP_SCAN): Decrease to 250. Prevents sluggish
9 redisplay in small windows.
10
208a048d
EZ
112011-09-09 Eli Zaretskii <eliz@gnu.org>
12
13 * frame.c (x_report_frame_params): Cast to avoid compiler warnings.
14
9b1c252e
MR
152011-09-08 Martin Rudalics <rudalics@gmx.at>
16
17 * window.c (Fset_window_prev_buffers, Fset_window_next_buffers):
18 Operate on live windows only.
19
2949f33b
JB
202011-09-08 Juanma Barranquero <lekktu@gmail.com>
21
22 * emacs.c (my_heap_start): #ifdef to avoid warnings when unused.
23
e08dcafd
EZ
242011-09-07 Eli Zaretskii <eliz@gnu.org>
25
26 * xdisp.c (move_it_in_display_line_to): Call RESTORE_IT on ppos_it
27 only under bidi iteration.
28
115b96bd
JD
292011-09-07 Jan Djärv <jan.h.d@swipnet.se>
30
31 * gtkutil.c (xg_make_tool_item): Insert comment about eventbox.
32
c8199d0f
PE
332011-09-06 Paul Eggert <eggert@cs.ucla.edu>
34
35 isnan: Fix porting problem to Solaris 10 with bundled gcc.
36 Without this fix, the command to link temacs failed due to an
37 undefined symbol __builtin_isnan. This is because
38 /usr/include/iso/math_c99.h #defines isnan(x) to
39 __builtin_isnan(x), but the bundled gcc, which identifies itself
40 as gcc 3.4.3 (csl-sol210-3_4-branch+sol_rpath), does not have
41 a __builtin_isnan.
42 * floatfns.c (isnan): #undef, and then #define to a clone of
43 what's in data.c.
44 (Fisnan): Always define, since it's always available now.
45 (syms_of_floatfns): Always define isnan at the Lisp level.
46
e39b275c 472011-09-06 Paul Eggert <eggert@cs.ucla.edu>
1c262cae
PE
48
49 * Makefile.in (gl-stamp): move-if-change now in build-aux (Bug#9169).
50
b2db44d9 512011-09-06 Paul Eggert <eggert@cs.ucla.edu>
728f8f0a 52
f4af5137 53 * fileio.c: Fix bugs with large file offsets (Bug#9428).
728f8f0a
PE
54 The previous code assumed that file offsets (off_t values) fit in
55 EMACS_INT variables, which is not true on typical 32-bit hosts.
56 The code messed up by falsely reporting buffer overflow in cases
57 such as (insert-file-contents "big" nil 1 2) into an empty buffer
58 when "big" contains more than 2**29 bytes, even though this
59 inserts just one byte and does not overflow the buffer.
60 (Finsert_file_contents): Store file offsets as off_t
61 values, not as EMACS_INT values. Check for overflow when
62 converting between EMACS_INT and off_t. When checking for
63 buffer overflow or for overlap, take the offsets into account.
64 Don't use EMACS_INT for small values where int suffices.
65 When checking for overlap, fix a typo: ZV was used where
66 ZV_BYTE was intended.
67 (Fwrite_region): Don't assume off_t fits into 'long'.
68 * buffer.h (struct buffer.modtime_size): Now off_t, not EMACS_INT.
69
ecfc0a49
MA
702011-09-05 Michael Albinus <michael.albinus@gmx.de>
71
72 * dbusbind.c (xd_signature_cat): Rename from signature_cat.
73
6511acf2 742011-09-04 Paul Eggert <eggert@cs.ucla.edu>
61bfeeb7 75
0999621a 76 sprintf-related integer and memory overflow issues (Bug#9412).
62f19c19
PE
77
78 * doprnt.c (doprnt): Support printing ptrdiff_t and intmax_t values.
8666506e 79 (esprintf, exprintf, evxprintf): New functions.
62f19c19
PE
80 * keyboard.c (command_loop_level): Now EMACS_INT, not int.
81 (cmd_error): kbd macro iterations count is now EMACS_INT, not int.
82 (modify_event_symbol): Do not assume that the length of
83 name_alist_or_stem is safe to alloca and fits in int.
84 (Fexecute_extended_command): Likewise for function name and binding.
85 (Frecursion_depth): Wrap around reliably on integer overflow.
86 * keymap.c (push_key_description): First arg is now EMACS_INT, not int,
87 since some callers pass EMACS_INT values.
88 (Fsingle_key_description): Don't crash if symbol name contains more
89 than MAX_ALLOCA bytes.
90 * minibuf.c (minibuf_level): Now EMACS_INT, not int.
91 (get_minibuffer): Arg is now EMACS_INT, not int.
92 * lisp.h (get_minibuffer, push_key_description): Reflect API changes.
8666506e 93 (esprintf, exprintf, evxprintf): New decls.
62f19c19
PE
94 * window.h (command_loop_level, minibuf_level): Reflect API changes.
95
2be7d702
PE
96 * dbusbind.c (signature_cat): New function.
97 (xd_signature, Fdbus_register_signal):
2ea16b89
PE
98 Do not overrun buffer; instead, report string overflow.
99
9d1df220
PE
100 * dispnew.c (add_window_display_history): Don't overrun buffer.
101 Truncate instead; this is OK since it's just a log.
102
33ef5c64
PE
103 * editfns.c (Fcurrent_time_zone): Don't overrun buffer
104 even if the time zone offset is outlandishly large.
105 Don't mishandle offset == INT_MIN.
106
66c6fdd5
PE
107 * emacs.c (main) [NS_IMPL_COCOA]: Don't overrun buffer
108 when creating daemon; the previous buffer-overflow check was incorrect.
109
d749b01b
PE
110 * eval.c (verror): Simplify by rewriting in terms of evxprintf,
111 which has the guts of the old verror function.
112
b5cd1905
PE
113 * filelock.c (lock_file_1, lock_file): Don't blindly alloca long name;
114 use SAFE_ALLOCA instead. Use esprintf to avoid int-overflow issues.
115
6e1a67fb
PE
116 * font.c: Include <float.h>, for DBL_MAX_10_EXP.
117 (font_unparse_xlfd): Don't blindly alloca long strings.
c21721cc 118 Don't assume XINT result fits in int, or that XFLOAT_DATA * 10
8666506e 119 fits in int, when using sprintf. Use single snprintf to count
c21721cc
PE
120 length of string rather than counting it via multiple sprintfs;
121 that's simpler and more reliable.
c21721cc
PE
122 (font_unparse_fcname): Use it to avoid sprintf buffer overrun.
123 (generate_otf_features) [0 && HAVE_LIBOTF]: Use esprintf, not
124 sprintf, in case result does not fit in int.
125
c57b67fc
PE
126 * fontset.c (num_auto_fontsets): Now printmax_t, not int.
127 (fontset_from_font): Print it.
128
8a401434
PE
129 * frame.c (tty_frame_count): Now printmax_t, not int.
130 (make_terminal_frame, set_term_frame_name): Print it.
131 (x_report_frame_params): In X, window IDs are unsigned long,
132 not signed long, so print them as unsigned.
133 (validate_x_resource_name): Check for implausibly long names,
134 and don't assume name length fits in 'int'.
135 (x_get_resource_string): Don't blindly alloca invocation name;
136 use SAFE_ALLOCA. Use esprintf, not sprintf, in case result does
137 not fit in int.
138
6e1a67fb
PE
139 * gtkutil.c: Include <float.h>, for DBL_MAX_10_EXP.
140 (xg_check_special_colors, xg_set_geometry):
84722b3d
PE
141 Make sprintf buffers a bit bigger, to avoid potential buffer overrun.
142
0df02bf3
PE
143 * lread.c (dir_warning): Don't blindly alloca buffer; use SAFE_ALLOCA.
144 Use esprintf, not sprintf, in case result does not fit in int.
145
48e30793
PE
146 * macros.c (executing_kbd_macro_iterations): Now EMACS_INT, not int.
147 (Fend_kbd_macro): Don't mishandle MOST_NEGATIVE_FIXNUM by treating
148 it as a large positive number.
149 (Fexecute_kbd_macro): Don't assume repeat count fits in int.
150 * macros.h (executing_kbd_macro_iterations): Now EMACS_INT, not int.
151
a66ff6d8
PE
152 * nsterm.m ((NSSize)windowWillResize): Use esprintf, not sprintf,
153 in case result does not fit in int.
154
aca216ff
PE
155 * print.c (float_to_string): Detect width overflow more reliably.
156 (print_object): Make sprintf buffer a bit bigger, to avoid potential
157 buffer overrun. Don't assume list length fits in 'int'. Treat
158 print length of 0 as 0, not as infinity; to be consistent with other
159 uses of print length in this function. Don't overflow print length
160 index. Don't assume hash table size fits in 'long', or that
161 vectorlike size fits in 'unsigned long'.
162
31c286f7
PE
163 * process.c (make_process): Use printmax_t, not int, to format
164 process-name gensyms.
165
55e5faa1
PE
166 * sysdep.c (snprintf) [! HAVE_SNPRINTF]: New function.
167
80f2e268
PE
168 * term.c (produce_glyphless_glyph): Make sprintf buffer a bit bigger
169 to avoid potential buffer overrun.
170
670741ab
PE
171 * xfaces.c (x_update_menu_appearance): Don't overrun buffer
172 if X resource line is longer than 512 bytes.
173
b7163a50
PE
174 * xfns.c (x_window): Make sprintf buffer a bit bigger
175 to avoid potential buffer overrun.
176
ae58ff1f
PE
177 * xterm.c (x_io_error_quitter): Don't overrun sprintf buffer.
178
c43c8a6a
PE
179 * xterm.h (x_check_errors): Add ATTRIBUTE_FORMAT_PRINTF.
180
3f8236f4
PE
1812011-09-04 Paul Eggert <eggert@cs.ucla.edu>
182
53e9fe90 183 Integer overflow fixes for scrolling, etc.
6511acf2
PE
184 Without these, Emacs silently mishandles large integers sometimes.
185 For example, "C-u 4294967297 M-x recenter" was treated as if
53e9fe90
PE
186 it were "C-u 1 M-x recenter" on a typical 64-bit host.
187
6511acf2
PE
188 * xdisp.c (try_window_id): Check Emacs fixnum range before
189 converting to 'int'.
806add1d 190
6511acf2 191 * window.c (window_scroll_line_based, Frecenter):
71f02bc5
PE
192 Check that an Emacs fixnum is in range before assigning it to 'int'.
193 (Frecenter, Fmove_to_window_line): Use EMACS_INT, not int, for
194 values converted from Emacs fixnums.
195 (Frecenter): Don't wrap around a line count if it is out of 'int'
196 range; instead, treat it as an extreme value.
197 (Fset_window_configuration, compare_window_configurations):
198 Use ptrdiff_t, not int, for index that might exceed 2 GiB.
199
6511acf2
PE
200 * search.c (Freplace_match): Use ptrdiff_t, not int, for indexes
201 that can exceed INT_MAX. Check that EMACS_INT value is in range
202 before assigning it to the (possibly-narrower) index.
a0efffc8
PE
203 (match_limit): Don't assume that a fixnum can fit in 'int'.
204
6511acf2 205 * print.c (print_object): Use ptrdiff_t, not int, for index that can
29ebea3b
PE
206 exceed INT_MAX.
207
6511acf2 208 * indent.c (position_indentation): Now takes ptrdiff_t, not int.
3f8236f4
PE
209 (Fvertical_motion): Don't wrap around LINES values that don't fit
210 in 'int'. Instead, treat them as extreme values. This is good
211 enough for windows, which can't have more than INT_MAX lines anyway.
212
fcb901a7
LMI
2132011-09-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
214
0f2f6b6d
LMI
215 * Require libxml/parser.h to avoid compilation warning.
216
fcb901a7
LMI
217 * emacs.c (shut_down_emacs): Call xmlCleanupParser on shutdown.
218
219 * xml.c (parse_region): Don't call xmlCleanupParser after parsing,
220 since this reportedly can destroy thread storage.
221
6e20a0d4
CY
2222011-08-30 Chong Yidong <cyd@stupidchicken.com>
223
224 * syntax.c (find_defun_start): Update all cache variables if
225 exiting early (Bug#9401).
226
148ae00e
EZ
2272011-08-30 Eli Zaretskii <eliz@gnu.org>
228
f6cfbd8f
EZ
229 * image.c (x_bitmap_pixmap): Cast to int to avoid compiler warnings.
230
148ae00e
EZ
231 * xdisp.c (produce_stretch_glyph): No longer static, compiled also
232 when HAVE_WINDOW_SYSTEM is not defined. Support both GUI and TTY
233 frames. Call tty_append_glyph in the TTY case. (Bug#9402)
234
235 * term.c (tty_append_glyph): New function.
236 (produce_stretch_glyph): Static function and its prototype deleted.
237
238 * dispextern.h (produce_stretch_glyph, tty_append_glyph): Add
239 prototypes.
240
c4a07a4c
PE
2412011-08-29 Paul Eggert <eggert@cs.ucla.edu>
242
243 * image.c (parse_image_spec): Check for nonnegative, not for positive,
244 when checking :margin (Bug#9390).
245 (IMAGE_NON_NEGATIVE_INTEGER_VALUE_OR_PAIR):
246 Renamed from IMAGE_POSITIVE_INTEGER_VALUE_OR_PAIR,
247 so that the name doesn't mislead. All uses changed.
248
6bc8cd65
JB
2492011-08-28 Johan Bockgård <bojohan@gnu.org>
250
251 * term.c (init_tty) [HAVE_GPM]: Move mouse settings after
252 set_tty_hooks.
253
dca4927e
EZ
2542011-08-27 Eli Zaretskii <eliz@gnu.org>
255
256 * xdisp.c (move_it_to): Don't bail out early when reaching
257 position beyond to_charpos, if we are scanning backwards.
258 (move_it_vertically_backward): When DY == 0, make sure we get to
259 the first character in the line after the newline.
260
f2cad773
PE
2612011-08-27 Paul Eggert <eggert@cs.ucla.edu>
262
263 * ccl.c: Improve and simplify overflow checking (Bug#9196).
264 (ccl_driver): Do not generate an out-of-range pointer.
265 (Fccl_execute_on_string): Remove unnecessary check for
266 integer overflow, noted by Stefan Monnier in
267 <http://lists.gnu.org/archive/html/emacs-devel/2011-08/msg00979.html>.
268 Remove a FIXME that didn't need fixing.
269 Simplify the newly-introduced buffer reallocation code.
270
0cae2cdb
JB
2712011-08-27 Juanma Barranquero <lekktu@gmail.com>
272
273 * makefile.w32-in ($(BLD)/alloc.$(O)): Depend on lib/verify.h.
274
5fc295a4 2752011-08-26 Paul Eggert <eggert@cs.ucla.edu>
ddff3151 276
70c60eb2 277 Integer and memory overflow issues (Bug#9196).
726e0ab1 278
d31850da
PE
279 * doc.c (get_doc_string): Rework so that
280 get_doc_string_buffer_size is the actual buffer size, rather than
281 being 1 less than the actual buffer size; this makes xpalloc more
282 convenient.
283
a69fbedb
PE
284 * image.c (x_allocate_bitmap_record, cache_image):
285 * xselect.c (Fx_register_dnd_atom):
286 Simplify previous changes by using xpalloc.
287
fe5c5d37
PE
288 * buffer.c (overlay_str_len): Now ptrdiff_t, not EMACS_INT,
289 since either will do and ptrdiff_t is convenient with xpalloc.
290
0065d054
PE
291 * charset.c (charset_table_size)
292 (struct charset_sort_data.priority): Now ptrdiff_t.
293 (charset_compare): Don't overflow if priorities differ greatly.
294 (Fsort_charsets): Don't assume list length fits in int.
295 Check for size-calculation overflow when allocating sort data.
296 (syms_of_charset): Allocate an initial charset table that is
297 just under 64 KiB, to avoid problems with glibc malloc and mmap.
298
299 * cmds.c (internal_self_insert): Check for size-calculation overflow.
300
301 * composite.h (struct composition.glyph_len): Now int, not unsigned.
302 The actual value is always <= INT_MAX, and leaving it unsigned made
303 overflow checking harder.
304
305 * dispextern.h (struct glyph_matrix.rows_allocated)
306 (struct face_cache.size): Now ptrdiff_t, for convenience in use
307 with xpalloc. The values are still always <= INT_MAX.
308
309 * indent.c (compute_motion): Adjust to region_cache_forward sig change.
310
311 * lisp.h (xnmalloc, xnrealloc, xpalloc): New decls.
312 (SAFE_NALLOCA): New macro.
313
314 * region-cache.c (struct boundary.pos, find_cache_boundary)
315 (move_cache_gap, insert_cache_boundary, delete_cache_boundaries)
316 (set_cache_region, invalidate_region_cache)
317 (revalidate_region_cache, know_region_cache, region_cache_forward)
318 (region_cache_backward, pp_cache):
319 Use ptrdiff_t, not EMACS_INT, since either will do. This is needed
320 so that ptrdiff_t * can be passed to xpalloc.
321 (struct region_cache): Similarly, for gap_start, gap_len, cache_len,
322 beg_unchanged, end_unchanged, buffer_beg, buffer_end members.
323 (pp_cache): Don't assume cache_len fits in int.
324 * region-cache.h: Adjust extern decls to match.
325
326 * search.c (scan_buffer, Freplace_match): Use ptrdiff_t, not
327 EMACS_INT, since either will do, for xpalloc.
328
329 * alloc.c: Include verify.h, and check that int fits in ptrdiff_t.
330 (xnmalloc, xnrealloc, xpalloc): New functions.
331
726e0ab1
PE
332 * bidi.c (bidi_shelve_header_size): New constant.
333 (bidi_cache_ensure_space, bidi_shelve_cache): Use it.
334 (bidi_cache_ensure_space): Avoid integer overflow when allocating.
335
51f30bc5 336 * bidi.c (bidi_cache_shrink):
726e0ab1
PE
337 * buffer.c (overlays_at, overlays_in, record_overlay_string)
338 (overlay_strings):
339 Don't update size of array until after memory allocation succeeds,
340 because xmalloc/xrealloc may not return.
0065d054
PE
341 (struct sortstrlist.bytes): Now ptrdiff_t, as EMACS_INT doesn't help
342 now that we have proper integer overflow checking.
343 (record_overlay_string, overlay_strings): Catch overflows when
344 calculating size of overlay_str_buf.
726e0ab1 345
0065d054
PE
346 * callproc.c (Fcall_process): Check for size overflow when
347 calculating size of args2.
348 (child_setup): Avoid overflow by using size_t rather than ptrdiff_t.
349 Normally we prefer signed values, but sticking with ptrdiff_t would
350 require adding more-complicated checks.
726e0ab1
PE
351
352 * ccl.c (Fccl_execute_on_string): Check for memory overflow.
353 Use ptrdiff_t rather than EMACS_INT where ptrdiff_t will do.
354 Redo buffer-overflow calculations to avoid integer overflow.
0065d054 355 Add a FIXME comment where memory seems to be over-allocated.
726e0ab1
PE
356
357 * character.c (Fstring): Check for size-calculation overflow.
358
359 * coding.c (produce_chars): Redo buffer-overflow calculations to avoid
360 unnecessary integer overflow. Check for size overflow.
361 (encode_coding_object): Don't update size until xmalloc succeeds.
362
363 * composite.c (get_composition_id): Check for overflow in glyph
364 length calculations.
365
366 Integer and memory overflow fixes for display code.
367 * dispextern.h (struct glyph_pool.nglyphs): Now ptrdiff_t, not int.
368 * dispnew.c (adjust_glyph_matrix, realloc_glyph_pool)
369 (scrolling_window): Check for overflow in size calculations.
370 (line_draw_cost, realloc_glyph_pool, add_row_entry):
371 Don't assume glyph table len fits in int.
372 (struct row_entry.bucket, row_entry_pool_size, row_entry_idx)
373 (row_table_size): Now ptrdiff_t, not int.
374 (scrolling_window): Avoid overflow in size calculations.
375 Don't update size until allocation succeeds.
376 * fns.c (concat): Check for overflow in size calculations.
377 (next_almost_prime): Verify NEXT_ALMOST_PRIME_LIMIT.
378 * lisp.h (RANGED_INTEGERP, TYPE_RANGED_INTEGERP): New macros.
379 (NEXT_ALMOST_PRIME_LIMIT): New constant.
380
381 * doc.c (get_doc_string_buffer_size): Now ptrdiff_t, not int.
382 (get_doc_string): Check for size calculation overflow.
383 Don't update size until allocation succeeds.
384 (get_doc_string, Fsubstitute_command_keys): Use ptrdiff_t, not
385 EMACS_INT, where ptrdiff_t will do.
386 (Fsubstitute_command_keys): Check for string overflow.
387
388 * editfns.c (set_time_zone_rule): Don't assume environment length
389 fits in int.
390 (message_length): Now ptrdiff_t, not int.
391 (Fmessage_box): Don't update size until allocation succeeds.
392 Don't assume message length fits in int.
393 (Fformat): Use ptrdiff_t, not EMACS_INT, where ptrdiff_t will do.
394
0065d054
PE
395 * emacs.c (main): Do not reallocate argv, since there is a null at
396 the end that can be overwritten, and this way there's no need to
397 worry about size-calculation overflow.
398 (sort_args): Check for size-calculation overflow.
726e0ab1
PE
399
400 * eval.c (init_eval_once, grow_specpdl): Don't update size until
401 alloc succeeds.
402 (call_debugger, grow_specpdl): Redo calculations to avoid overflow.
403
404 * frame.c (set_menu_bar_lines, x_set_frame_parameters)
405 (x_set_scroll_bar_width, x_figure_window_size):
406 Check for integer overflow.
407 (x_set_alpha): Do not assume XINT fits in int.
408
409 * frame.h (struct frame): Use int, not EMACS_INT, where int works.
410 This is for the members text_lines, text_cols, total_lines, total_cols,
411 where the system imposes an 'int' limit.
412
413 * fringe.c (Fdefine_fringe_bitmap):
414 Don't update size until alloc works.
415
416 * ftfont.c (ftfont_get_open_type_spec, setup_otf_gstring)
417 (ftfont_shape_by_flt): Check for integer overflow in size calculations.
418
419 * gtkutil.c (get_utf8_string, xg_store_widget_in_map):
420 Check for size-calculation overflow.
421 (get_utf8_string): Use ptrdiff_t, not size_t, where either will
422 do, as we prefer signed integers.
423 (id_to_widget.max_size, id_to_widget.used)
424 (xg_store_widget_in_map, xg_remove_widget_from_map)
425 (xg_get_widget_from_map, xg_get_scroll_id_for_window)
426 (xg_remove_scroll_bar, xg_update_scrollbar_pos):
427 Use and return ptrdiff_t, not int.
428 (xg_gtk_scroll_destroy): Don't assume ptrdiff_t fits in int.
429 * gtkutil.h: Change prototypes to match the above.
430
431 * image.c (RANGED_INTEGERP, TYPE_RANGED_INTEGERP): Remove; these
432 are duplicate now that they've been promoted to lisp.h.
433 (x_allocate_bitmap_record, x_alloc_image_color)
434 (make_image_cache, cache_image, xpm_load):
435 Don't update size until alloc is done.
436 (xpm_load, lookup_rgb_color, lookup_pixel_color, x_to_xcolors)
437 (x_detect_edges):
3256efce 438 Check for size calculation overflow.
726e0ab1
PE
439 (ct_colors_allocated_max): New constant.
440 (x_to_xcolors, x_detect_edges): Reorder multiplicands to avoid
441 overflow.
3256efce 442
726e0ab1
PE
443 * keyboard.c (read_char, menu_bar_items, tool_bar_items)
444 (read_char_x_menu_prompt, read_char_minibuf_menu_width)
445 (read_char_minibuf_menu_prompt, follow_key, read_key_sequence):
446 Use ptrdiff_t, not int, to count maps.
447 (read_char_minibuf_menu_prompt): Check for overflow in size
448 calculations. Don't update size until allocation succeeds. Redo
449 calculations to avoid overflow.
450 * keyboard.h: Change prototypes to match the above.
451
452 * keymap.c (cmm_size, current_minor_maps): Use ptrdiff_t, not int,
453 to count maps.
454 (current_minor_maps): Check for size calculation overflow.
455 * keymap.h: Change prototypes to match the above.
456
457 * lread.c (read1, init_obarray): Don't update size until alloc done.
458
459 * macros.c (Fstart_kbd_macro): Don't update size until alloc done.
460 (store_kbd_macro_char): Reorder multiplicands to avoid overflow.
461
726e0ab1
PE
462 * nsterm.h (struct ns_color_table.size, struct ns_color_table.avail):
463 Now ptrdiff_t, not int.
464 * nsterm.m (ns_index_color): Use ptrdiff_t, not int, for table indexes.
465 (ns_draw_fringe_bitmap): Rewrite to avoid overflow.
466
467 * process.c (Fnetwork_interface_list): Check for overflow
468 in size calculation.
469
470 * region-cache.c (move_cache_gap): Check for size calculation overflow.
471
472 * scroll.c (do_line_insertion_deletion_costs): Check for size calc
473 overflow. Don't bother calling xmalloc when xrealloc will do.
474
475 * search.c (Freplace_match): Check for size calculation overflow.
476 (Fset_match_data): Don't assume list lengths fit in 'int'.
477
478 * sysdep.c (system_process_attributes): Use ptrdiff_t, not int,
479 for command line length. Do not attempt to address one before the
480 beginning of an array, as that's not portable.
481
482 * term.c (max_frame_lines): Remove; unused.
483 (encode_terminal_src_size, encode_terminal_dst_size): Now ptrdiff_t,
484 not int.
485 (encode_terminal_code, calculate_costs): Check for size
486 calculation overflow.
487 (encode_terminal_code): Use ptrdiff_t, not int, to record glyph
488 table lengths and related sizes. Don't update size until alloc
489 done. Redo calculations to avoid overflow.
490 (calculate_costs): Don't bother calling xmalloc when xrealloc will do.
491
492 * termcap.c (tgetent): Use ptrdiff_t, not int, to record results of
493 subtracting pointers.
494 (gobble_line): Check for overflow more carefully. Don't update size
495 until alloc done.
496
497 * tparam.c (tparam1): Use ptrdiff_t, not int, for sizes.
498 Don't update size until alloc done.
499 Redo size calculations to avoid overflow.
500 Check for size calculation overflow.
0065d054 501 (main) [DEBUG]: Fix typo in invoking tparam1.
726e0ab1
PE
502
503 * xdisp.c (store_mode_line_noprop_char, x_consider_frame_title):
504 Use ptrdiff_t, not int, for sizes.
505 (store_mode_line_noprop_char): Don't update size until alloc done.
506
0065d054
PE
507 * xfaces.c (lface_id_to_name_size, Finternal_make_lisp_face):
508 Use ptrdiff_t, not int, for sizes.
509 (Finternal_make_lisp_face, cache_face):
510 Check for size calculation overflow.
511 (cache_face): Treat size calculation overflows as if they were
512 memory exhaustion (the usual treatment), rather than aborting.
726e0ab1
PE
513
514 * xfns.c (x_encode_text, x_set_name_internal)
515 (Fx_change_window_property): Use ptrdiff_t, not int, to count
516 sizes, since they can exceed INT_MAX in size. Check for size
517 calculation overflow.
518
0065d054
PE
519 * xgselect.c (gfds_size): Now ptrdiff_t, for convenience with xpalloc.
520 (xg_select): Check for size calculation overflow.
726e0ab1
PE
521 Don't update size until alloc done.
522
0065d054 523 * xrdb.c (get_environ_db): Don't assume path length fits in int,
726e0ab1 524 as sprintf is limited to int lengths.
1d526e2f 525
252c5ee1
PE
526 * xselect.c (X_LONG_SIZE, X_SHRT_MAX, X_SHRT_MIN, X_LONG_MAX)
527 (X_LONG_MIN): New macros.
864d7ce7
PE
528 Use them to make the following changes clearer.
529 (MAX_SELECTION_QUANTUM): Make the other bounds on this value clearer.
530 This change doesn't affect the value now, but it may help remind
531 future maintainers not to raise the value too much later.
532 (SELECTION_QUANTUM): Remove, replacing with ...
533 (selection_quantum): ... new function, which avoids overflow.
534 All uses changed.
535 (struct selection_data.size): Now ptrdiff_t, not int, to avoid
536 assumption that selection length fits in 'int'.
537 (x_reply_selection_request, x_handle_selection_request)
538 (x_get_window_property, receive_incremental_selection)
539 (x_get_window_property_as_lisp_data, selection_data_to_lisp_data)
540 (lisp_data_to_selection_data, clean_local_selection_data):
541 Use ptrdiff_t, not int, to record length of selection.
542 (x_reply_selection_request, x_get_window_property)
543 (receive_incremental_selection, x_property_data_to_lisp):
544 Redo calculations to avoid overflow.
545 (x_reply_selection_request): When sending hint, ceiling it at
252c5ee1 546 X_LONG_MAX rather than relying on wraparound overflow to send
864d7ce7
PE
547 something.
548 (x_get_window_property, receive_incremental_selection)
549 (lisp_data_to_selection_data, x_property_data_to_lisp):
550 Check for size-calculation overflow.
551 (x_get_window_property, receive_incremental_selection)
552 (lisp_data_to_selection_data, Fx_register_dnd_atom):
553 Don't store size until memory allocation succeeds.
554 (x_get_window_property): Plug memory leak on memory exhaustion.
555 Don't double-block input; malloc is safe here. Don't assume 2**34
556 - 4 fits in unsigned long. Add an xassert to check
557 XGetWindowProperty overflow. Be more careful about overflow
558 calculations, and distinguish size from memory overflow better.
559 (receive_incremental_selection): When tracing, don't assume
560 unsigned int is less than INT_MAX.
561 (x_selection_data_to_lisp_data): Remove unnecessary (and in theory
562 harmful) conversions of unsigned short to int.
563 (lisp_data_to_selection_data): Don't assume that integers
564 in the range -65535 through -1 fit in an X unsigned short.
565 Don't assume that ULONG_MAX == X_ULONG_MAX. Don't store into
566 result parameters unless successful. Rely on cons_to_unsigned
567 to report problems with elements; the old code wasn't right anyway.
568 (x_check_property_data): Check for int overflow; we cannot use
569 a wider type due to X limits.
570 (x_handle_dnd_message): Use unsigned int, to avoid int overflow.
571
726e0ab1 572 * xsmfns.c (smc_save_yourself_CB): Check for size calc overflow.
34db673b 573
0065d054
PE
574 * xterm.c (x_color_cells, x_send_scrollbar_event, handle_one_xevent)
575 (x_term_init): Check for size calculation overflow.
726e0ab1
PE
576 (x_color_cells): Don't store size until memory allocation succeeds.
577 (handle_one_xevent): Use ptrdiff_t, not int, for byte counts.
0065d054 578 Don't assume alloca size is less than MAX_ALLOCA.
726e0ab1
PE
579 (x_term_init): Don't assume length fits in int (sprintf is limited
580 to int size).
bc18e09d 581
ebfa62c0
PE
582 Use ptrdiff_t for composition IDs.
583 * character.c (lisp_string_width):
584 * composite.c (composition_table_size, n_compositions)
585 (get_composition_id, composition_gstring_from_id):
586 * dispextern.h (struct glyph_string.cmp_id, struct composition_it.id):
587 * xdisp.c (BUILD_COMPOSITE_GLYPH_STRING):
588 * window.c (Frecenter):
589 Use ptrdiff_t, not int, for composition IDs.
590 * composite.c (get_composition_id): Check for integer overflow.
591 * composite.h: Adjust prototypes to match the above changes.
592
d3411f89
PE
593 Use ptrdiff_t for hash table indexes.
594 * category.c (hash_get_category_set):
595 * ccl.c (ccl_driver):
596 * charset.h (struct charset.hash_index, CHECK_CHARSET_GET_ID):
597 * coding.c (coding_system_charset_list, detect_coding_system):
598 * coding.h (struct coding_system.id):
599 * composite.c (get_composition_id, gstring_lookup_cache):
600 * fns.c (hash_lookup, hash_put, Fgethash, Fputhash):
601 * image.c (xpm_get_color_table_h):
602 * lisp.h (hash_lookup, hash_put):
603 * minibuf.c (Ftest_completion):
604 Use ptrdiff_t for hash table indexes, not int (which is too
605 narrow, on 64-bit hosts) or EMACS_INT (which is too wide, on
606 32-bit --with-wide-int hosts).
607
e097a6fa
PE
608 * charset.c (Fdefine_charset_internal): Check for integer overflow.
609 Add a FIXME comment about memory leaks.
610 (syms_of_charset): Don't assume xmalloc returns.
611
5637687f
PE
612 Don't assume that stated character widths fit in int.
613 * character.c (Fchar_width, c_string_width, lisp_string_width):
614 * character.h (CHAR_WIDTH):
615 * indent.c (MULTIBYTE_BYTES_WIDTH):
616 Use sanitize_char_width to avoid undefined and/or bad behavior
617 with outlandish widths.
618 * character.h (sanitize_tab_width): Renamed from sanitize_width,
619 now that we have two such functions. All uses changed.
620 (sanitize_char_width): New inline function.
621
a2271ba2
PE
622 Don't assume that tab-width fits in int.
623 * character.h (sanitize_width): New inline function.
624 (SANE_TAB_WIDTH): New macro.
625 (ASCII_CHAR_WIDTH): Use it.
626 * indent.c (sane_tab_width): Remove. All uses replaced by
627 SANE_TAB_WIDTH (current_buffer).
628 * xdisp.c (init_iterator): Use SANE_TAB_WIDTH.
629
18c52557
PE
630 * fileio.c: Integer overflow issues with file modes.
631 (Fset_file_modes, auto_save_1): Don't assume EMACS_INT fits in int.
632
caeeedc1
PE
633 * charset.c (read_hex): New arg OVERFLOW. All uses changed.
634 Remove unreachable code.
635 (read_hex, load_charset_map_from_file): Check for integer overflow.
636
50849c52
PE
637 * xterm.c: don't go over XClientMessageEvent limit
638 (scroll_bar_windows_size): Now ptrdiff_t, as we prefer signed.
639 (x_send_scroll_bar_event): Likewise. Check that the size does not
640 exceed limits imposed by XClientMessageEvent, as well as the usual
641 ptrdiff_t and size_t limits.
642
b13995db
PE
643 * keyboard.c: Overflow, signedness and related fixes.
644 (make_lispy_movement): Use same integer type in forward decl
645 that is used in the definition.
646 (read_key_sequence, keyremap_step):
647 Change bufsize argument back to int, undoing my 2011-03-30 change.
648 We prefer signed types, and int is wide enough here.
649 (parse_tool_bar_item): Don't assume tool_bar_max_label_size is less
650 than TYPE_MAXIMUM (EMACS_INT) / 2. Don't let the label size grow
651 larger than STRING_BYTES_BOUND. Use ptrdiff_t for Emacs string
652 length, not size_t. Use ptrdiff_t for index, not int.
653 (keyremap_step, read_key_sequence): Redo bufsize check to avoid
654 possibility of integer overflow.
655
13464394
PE
656 Overflow, signedness and related fixes for images.
657
658 * dispextern.h (struct it.stack[0].u.image.image_id)
659 (struct_it.image_id, struct image.id, struct image_cache.size)
660 (struct image_cache.used, struct image_cache.ref_count):
661 * gtkutil.c (update_frame_tool_bar):
662 * image.c (x_reference_bitmap, Fimage_size, Fimage_mask_p)
663 (Fimage_metadata, free_image_cache, clear_image_cache, lookup_image)
664 (cache_image, mark_image_cache, x_kill_gs_process, Flookup_image):
665 * nsmenu.m (update_frame_tool_bar):
666 * xdisp.c (calc_pixel_width_or_height):
667 * xfns.c (image_cache_refcount):
668 Image IDs are now ptrdiff_t, not int, to avoid arbitrary limits
669 on typical 64-bit hosts.
670
671 * image.c (RANGED_INTEGERP, TYPE_RANGED_INTEGERP): New macros.
672 (x_bitmap_pixmap, x_create_x_image_and_pixmap):
673 Omit unnecessary casts to int.
674 (parse_image_spec): Check that integers fall into 'int' range
675 when the callers expect that.
676 (image_ascent): Redo ascent calculation to avoid int overflow.
677 (clear_image_cache): Avoid overflow when sqrt (INT_MAX) < nimages.
678 (lookup_image): Remove unnecessary tests.
679 (xbm_image_p): Locals are now of int, not EMACS_INT,
680 since parse_image_check makes sure they fit into int.
681 (png_load, gif_load, svg_load_image):
682 Prefer int to unsigned where either will do.
683 (tiff_handler): New function, combining the cores of the
684 old tiff_error_handler and tiff_warning_handler. This
685 function is rewritten to use vsnprintf and thereby avoid
686 stack buffer overflows. It uses only the features of vsnprintf
687 that are common to both POSIX and native Microsoft.
688 (tiff_error_handler, tiff_warning_handler): Use it.
689 (tiff_load, gif_load, imagemagick_load_image):
690 Don't assume :index value fits in 'int'.
691 (gif_load): Omit unnecessary cast to double, and avoid double-rounding.
692 (imagemagick_load_image): Check that crop parameters fit into
693 the integer types that MagickCropImage accepts. Don't assume
694 Vimagemagick_render_type has a nonnegative value. Don't assume
695 size_t fits in 'long'.
696 (gs_load): Use printmax_t to print the widest integers possible.
697 Check for integer overflow when computing image height and width.
698
c11821d4
EZ
6992011-08-26 Eli Zaretskii <eliz@gnu.org>
700
701 * xdisp.c (redisplay_window): Don't force window start if point
702 will be invisible in the resulting window. (Bug#9324)
703
0c95fcf7
EZ
7042011-08-25 Eli Zaretskii <eliz@gnu.org>
705
706 * xdisp.c (compute_display_string_pos): Return 2 in DISP_PROP when
707 the display spec is of the form `(space ...)'.
708 (handle_display_spec): Return the value returned by
709 handle_single_display_spec, not just 1 or zero.
710 (handle_single_display_spec): If the display spec is of the form
711 `(space ...)', and specifies display in the text area, return 2
712 rather than 1.
fee65a97 713 (try_cursor_movement): Check for the need to scroll more
e25be792
EZ
714 accurately, and prefer exact match for point under bidi. Don't
715 advance `row' beyond the last row of the window.
0c95fcf7
EZ
716
717 * dispextern.h (struct bidi_it): Rename the disp_prop_p member
718 into disp_prop; all users changed.
719
720 * bidi.c (bidi_fetch_char): If compute_display_string_pos returns
721 DISP_PROP = 2, substitute the u+2029 PARAGRAPH SEPARATOR character
722 for the text covered by the display property.
723
e4ed06f1
CY
7242011-08-25 Chong Yidong <cyd@stupidchicken.com>
725
726 * buffer.c (Fbury_buffer_internal): Rename from Funrecord_buffer.
727 Change return value to nil.
728 (Frecord_buffer): Delete unused function.
729
f67cdd7f
EZ
7302011-08-24 Eli Zaretskii <eliz@gnu.org>
731
5980d4c6
EZ
732 * xdisp.c (Fcurrent_bidi_paragraph_direction): For unibyte
733 buffers, return left-to-right.
8610fe8b
EZ
734 (set_cursor_from_row): Consider candidate row a win if its glyph
735 represents a newline and point is on that newline. Fixes cursor
736 positioning on the newline at EOL of R2L text within L2R
737 paragraph, and vice versa.
738 (try_cursor_movement): Check continued rows, in addition to
739 continuation rows. Fixes unwarranted scroll when point enters a
740 continued line of R2L text within an L2R paragraph, or vice versa.
741 (cursor_row_p): Consider the case of point being equal to
742 MATRIX_ROW_END_CHARPOS. Prevents cursor being stuck when moving
743 from the end of a short line to the beginning of a continued line
744 of R2L text within L2R paragraph.
745 (RECORD_MAX_MIN_POS): For max_pos, use IT_CHARPOS even for
746 composed characters.
5980d4c6 747
f67cdd7f
EZ
748 * bidi.c (bidi_check_type): Use xassert.
749 (bidi_cache_iterator_state): Update the disp_pos and disp_prop_p
750 members.
751
bca633fb
EZ
7522011-08-23 Eli Zaretskii <eliz@gnu.org>
753
754 * bidi.c (bidi_get_type): Abort if we get zero as the bidi type of
755 a character.
756
4a5885a7
CY
7572011-08-23 Chong Yidong <cyd@stupidchicken.com>
758
759 * nsfont.m (ns_otf_to_script): Fix typo.
760
0902a04e
KH
7612011-08-22 Kenichi Handa <handa@m17n.org>
762
763 * chartab.c (Fset_char_table_extra_slot): Do not inhibit setting a
764 extra slot even if the purpose is char-code-property-table.
765
1a2e6670
EZ
7662011-08-23 Eli Zaretskii <eliz@gnu.org>
767
8ddde651
EZ
768 * xdisp.c (redisplay_window): When computing centering_position,
769 account for the height of the header line. (Bug#8874)
770
425cc014
EZ
771 * dispnew.c (buffer_posn_from_coords): Use buf_charpos_to_bytepos
772 instead of CHAR_TO_BYTE. Fixes a crash when a completion
773 candidate is selected by the mouse, and that candidate has a
774 composed character under the mouse.
775
1a2e6670
EZ
776 * xdisp.c (x_produce_glyphs): Set it->nglyphs to 1. Fixes pixel
777 coordinates reported by pos-visible-in-window-p for a composed
778 character in column zero.
779
8b76d6f8
SM
7802011-08-23 Stefan Monnier <monnier@iro.umontreal.ca>
781
782 * cmds.c (Fself_insert_command): Mention post-self-insert-hook.
783
dac347dd
EZ
7842011-08-22 Eli Zaretskii <eliz@gnu.org>
785
786 * xdisp.c (BUFFER_POS_REACHED_P): If this is a composition,
787 consider it a hit if to_charpos is anywhere in the range of the
788 composed buffer positions.
789
e013fb34
CY
7902011-08-22 Chong Yidong <cyd@stupidchicken.com>
791
792 * image.c (gif_load): Don't assume that each subimage has the same
793 dimensions as the base image. Handle disposal method that is
794 "undefined" by the gif spec (Bug#9335).
795
bd1ba3e8
CY
7962011-08-20 Chong Yidong <cyd@stupidchicken.com>
797
798 * eval.c (Fsignal): Handle `debug' symbol in error handler (Bug#9329).
024a2d76 799 (Fcondition_case): Document `debug' symbol in error handler.
bd1ba3e8 800
54a1215b
EZ
8012011-08-19 Eli Zaretskii <eliz@gnu.org>
802
823564e5
EZ
803 * xfaces.c (face_at_buffer_position): Avoid repeated evaluation of
804 face ID by FACE_FROM_ID, and avoid a crash when mouse is moved
805 from an Org mode buffer to a Speedbar frame.
806
54a1215b
EZ
807 * xdisp.c (RECORD_MAX_MIN_POS): If the display element comes from
808 a composition, take its buffer position from IT->cmp_it.charpos.
809 Fixes cursor positioning at the beginning of a line that begins
810 with a composed character.
811
9778ebcc
EZ
8122011-08-18 Eli Zaretskii <eliz@gnu.org>
813
0be6ee06
EZ
814 * bidi.c (bidi_get_type): If bidi_type_table reports zero as the
815 character bidirectional type, use STRONG_L instead. Fixes crashes
816 in a buffer produced by `describe-categories'.
817
9778ebcc
EZ
818 * dispextern.h (struct bidi_it): Move disp_pos and disp_prop_p
819 members before the level stack, so they would be saved and
820 restored when copying iterator state. Fixes incorrect reordering
821 around TABs covered by display properties.
822
156bffbe
AS
8232011-08-18 Andreas Schwab <schwab@linux-m68k.org>
824
825 * process.c (Fnetwork_interface_list): Correctly determine buffer
826 size.
827
72ad093b
CY
8282011-08-17 Chong Yidong <cyd@stupidchicken.com>
829
830 * eval.c (internal_condition_case, internal_condition_case_1)
8b76d6f8
SM
831 (internal_condition_case_2, internal_condition_case_n):
832 Remove unnecessary aborts (Bug#9081).
72ad093b 833
35774242
EZ
8342011-08-17 Eli Zaretskii <eliz@gnu.org>
835
836 * lread.c (Fload) [DOS_NT]: If `openp' returns -2, but the file
837 has no `load' handler, try opening the file locally. (Bug#9311)
838
db76dd85
KB
8392011-08-16 Ken Brown <kbrown@cornell.edu>
840
841 * gmalloc.c: Expand comment.
842
b215eee5
EZ
8432011-08-16 Eli Zaretskii <eliz@gnu.org>
844
845 * xdisp.c (set_cursor_from_row): Don't accept a previous candidate
846 if it fails the cursor_row_p test. Fixes cursor positioning at ZV.
847
a4579d33
KB
8482011-08-16 Ken Brown <kbrown@cornell.edu>
849
850 Fix memory allocation problems in Cygwin build (Bug#9273).
851
852 * unexcw.c ( __malloc_initialized): Declare external variable.
853 (fixup_executable): Force the dumped emacs to reinitialize malloc.
854
8b76d6f8
SM
855 * gmalloc.c [CYGWIN] (bss_sbrk_heapbase, bss_sbrk_heapinfo):
856 New variables.
a4579d33
KB
857 (malloc_initialize_1) [CYGWIN]: Prepare for reinitializing the
858 dumped emacs.
859 (_free_internal_nolock) [CYGWIN]: Ignore requests to free storage
860 in the static heap.
861 [CYGWIN] (special_realloc): New function.
862 (_realloc_internal_nolock) [CYGWIN]: Use the new function on
863 requests to realloc storage in the static heap.
864
3ebec551
PE
8652011-08-15 Paul Eggert <eggert@cs.ucla.edu>
866
867 * bidi.c (bidi_initialize): Remove unused local.
868
9fd8be00
EZ
8692011-08-15 Eli Zaretskii <eliz@gnu.org>
870
474a8465
EZ
871 * biditype.h: File removed.
872
873 * bidimirror.h: File removed.
874
875 * deps.mk (bidi.o): Remove biditype.h and
876 bidimirror.h.
877
878 * makefile.w32-in ($(BLD)/bidi.$(O)): Remove biditype.h and
879 bidimirror.h.
880
881 * dispextern.h: Fix a typo in the comment to bidi_type_t.
882
883 * chartab.c: Improve commentary for the uniprop_table API.
884
32413314
EZ
885 * bidi.c (bidi_paragraph_init): Support zero value of
886 bidi_ignore_explicit_marks_for_paragraph_level.
474a8465
EZ
887 (bidi_initialize): Use uniprop_table instead of including
888 biditype.h and bidimirror.h.
32413314 889
9fd8be00
EZ
890 * xdisp.c (move_it_in_display_line_to): Don't reset pixel
891 coordinates of the iterator when restoring from ppos_it.
892 (Bug#9296)
893
5cf2b69b
KH
8942011-08-14 Kenichi Handa <handa@m17n.org>
895
896 * process.c (create_process): Call setup_process_coding_systems
72ad093b 897 after the pid of the process is set to -1 (Bug#8162).
5cf2b69b 898
daf17d00
EZ
8992011-08-14 Eli Zaretskii <eliz@gnu.org>
900
901 * xdisp.c (move_it_in_display_line_to): Don't invoke
902 IT_RESET_X_ASCENT_DESCENT when iterator position was restored from
903 ppos_it. Fixes vertical cursor motion when line beginning is
904 covered by an image. (Bug#9296)
905
08e3161a
JD
9062011-08-14 Jan Djärv <jan.h.d@swipnet.se>
907
908 * nsterm.h (ns_run_ascript): Declare.
909 (NSAPP_DATA2_RUNASSCRIPT): Define.
910
911 * nsfns.m (as_script, as_result, as_status): New static variables.
912 (ns_run_ascript): New function.
5e617bc2 913 (Fns_do_applescript): Set variables as_*. Make an NSApplicationDefined
08e3161a
JD
914 event with data2 set to NSAPP_DATA2_RUNASSCRIPT, post it and then start
915 the event loop. Get status from as_status (Bug#7276).
916
917 * nsterm.m (sendEvent): If event is NSApplicationDefined and
918 data2 is NSAPP_DATA2_RUNASSCRIPT, call ns_run_ascript and then exit
919 the event loop (Bug#7276).
920
a3720aa2
AS
9212011-08-14 Andreas Schwab <schwab@linux-m68k.org>
922
923 * gnutls.c (QCgnutls_bootprop_priority)
924 (QCgnutls_bootprop_trustfiles, QCgnutls_bootprop_keylist)
925 (QCgnutls_bootprop_crlfiles, QCgnutls_bootprop_callbacks)
926 (QCgnutls_bootprop_loglevel, QCgnutls_bootprop_hostname)
927 (QCgnutls_bootprop_min_prime_bits, QCgnutls_bootprop_verify_flags)
928 (QCgnutls_bootprop_verify_hostname_error)
929 (QCgnutls_bootprop_callbacks_verify): Rename from
930 Qgnutls_bootprop_..., all uses changed.
931
932 * xfaces.c (QCignore_defface): Rename from Qignore_defface, all
933 uses changed.
934
0a0d27fb
PE
9352011-08-14 Paul Eggert <eggert@cs.ucla.edu>
936
19d5c50c
PE
937 * xfaces.c (Qframe_set_background_mode): Now static.
938 * dispextern.h (Qframe_set_background_mode): Remove decl.
939
0a0d27fb
PE
940 * process.c (Fnetwork_interface_info): Declare local only if needed.
941
377538cb
JD
9422011-08-13 Jan Djärv <jan.h.d@swipnet.se>
943
944 * process.c: Include ifaddrs.h and net/if_dl.h if available (Bug#8477).
945 (Fnetwork_interface_list): Allocate in increments of bytes instead
946 of sizeof (struct ifreq). Iterate over ifconf.ifc_req by counting
947 bytes (Bug#8477). Count bytes correctly when ifr_addr is a struct
948 sockaddr.
949 (struct ifflag_def): notrailers is smart on OSX.
950 (Fnetwork_interface_info): Handle case when ifr_flags is negative.
951 Get hardware address with getifaddrs if available.
952
08fff70c
EZ
9532011-08-12 Eli Zaretskii <eliz@gnu.org>
954
955 * xdisp.c (iterate_out_of_display_property): xassert that
956 IT->position is set to within IT->object's boundaries. Break from
957 the loop as soon as EOB is reached; avoids infloops in redisplay
8b76d6f8
SM
958 when IT->position is set up wrongly due to some bug.
959 Set IT->current to match the bidi iterator unconditionally.
08fff70c
EZ
960 (push_display_prop): Allow GET_FROM_STRING as IT->method on
961 entry. Force push_it to save on the stack the current
962 buffer/string position, to be restored by pop_it. Fix flags in
963 the iterator structure wrt the object coming from a display
964 property, as `line-prefix' and `wrap-prefix' are not ``replacing''
965 properties. (Bug#9284)
966
7be1c708 9672011-08-09 Andreas Schwab <schwab@linux-m68k.org>
aac0c6e3 968
7be1c708
CY
969 * fontset.c (fontset_get_font_group): Add proper type checks.
970 (Bug#9172)
aac0c6e3 971
7be1c708 9722011-08-09 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
aac0c6e3 973
7be1c708
CY
974 * unexmacosx.c (print_load_command_name): Add cases LC_FUNCTION_STARTS
975 and LC_VERSION_MIN_MACOSX.
976 (copy_linkedit_data) [LC_FUNCTION_STARTS]: New function.
977 (dump_it) [LC_FUNCTION_STARTS]: Use it.
aac0c6e3 978
97bb72a6
EZ
9792011-08-08 Eli Zaretskii <eliz@gnu.org>
980
981 * xdisp.c (forward_to_next_line_start): Allow to use the
8b76d6f8
SM
982 no-display-properties-and-no-overlays under bidi display.
983 Set disp_pos in the bidi iterator to avoid searches for display
757664a4 984 properties and overlays.
97bb72a6 985
d5617611
CY
9862011-08-08 Chong Yidong <cyd@stupidchicken.com>
987
37e11a63
CY
988 * editfns.c (Fset_time_zone_rule): Document relationship with the
989 setenv function.
990
d5617611
CY
991 * ftfont.c (ftfont_pattern_entity): Copy the extras argument to
992 the font entity extracted from the cache (Bug#8109).
993
58872834
CY
9942011-08-07 Chong Yidong <cyd@stupidchicken.com>
995
996 * composite.c (autocmp_chars): Don't reset point. That is done by
997 restore_point_unwind (Bug#5984).
998
75bfc667
JL
9992011-08-07 Juri Linkov <juri@jurta.org>
1000
1001 * editfns.c (Fformat_time_string): Doc fix, add tag `usage:'
1002 to show the arg `TIME' instead of `TIMEVAL'.
1003
d1410150
EZ
10042011-08-06 Eli Zaretskii <eliz@gnu.org>
1005
1006 * xdisp.c (set_cursor_from_row): Fix cursor positioning when a
1007 display property strides EOL and includes a newline, as in
1008 longlines-mode. (Bug#9254)
75b771e4
EZ
1009 (move_it_in_display_line_to): Fix vertical-motion in a buffer with
1010 word-wrap under bidirectional display. (Bug#9224)
d1410150
EZ
1011
1012 * bidi.c (bidi_unshelve_cache): Don't reset the cache if JUST_FREE
1013 is non-zero, even if the data buffer is NULL. Fixes a crash in
1014 vertical-motion with longlines-mode. (Bug#9254)
1015
35928349
EZ
10162011-08-05 Eli Zaretskii <eliz@gnu.org>
1017
ec7cc85b
EZ
1018 * bidi.c <bidi_cache_total_alloc>: Now static.
1019 (bidi_initialize): Initialize bidi_cache_total_alloc.
1020
8b76d6f8 1021 * xdisp.c (display_line): Release buffer allocated for shelved bidi
35928349
EZ
1022 cache. (Bug#9221)
1023
1024 * bidi.c (bidi_shelve_cache, bidi_unshelve_cache): Track total
1025 amount allocated this far in `bidi_cache_total_alloc'.
1026 (bidi_unshelve_cache): Accept an additional argument JUST_FREE; if
1027 non-zero, only free the data buffer without restoring the cache
1028 contents. All callers changed.
1029
1030 * dispextern.h (bidi_unshelve_cache): Update prototype.
1031
1032 * xdisp.c (SAVE_IT, pos_visible_p, move_it_in_display_line_to)
1033 (move_it_in_display_line, move_it_to)
1034 (move_it_vertically_backward, move_it_by_lines): Replace the call
1035 to xfree to an equivalent call to bidi_unshelve_cache.
1036 (move_it_in_display_line_to): Fix logic of returning
412b6358 1037 MOVE_POS_MATCH_OR_ZV in the bidi case. (Bug#9224)
35928349 1038
e2e2423b
EZ
10392011-08-05 Eli Zaretskii <eliz@gnu.org>
1040
1041 * xdisp.c (set_cursor_from_row): Prefer the candidate glyph that
1042 came from a string character with a `cursor' property. (Bug#9229)
1043
ae9e757a
JD
10442011-08-04 Jan Djärv <jan.h.d@swipnet.se>
1045
1046 * Makefile.in (LIB_PTHREAD): New variable.
1047 (LIBES): Add LIB_PTHREAD (Bug#9216).
1048
1049 * alloc.c, emacs.c, gmalloc.c, gtkutil.c, keyboard.c, syssignal.h:
1050 Rename HAVE_GTK_AND_PTHREAD to HAVE_PTHREAD (Bug#9216).
1051
213bd7f2
AS
10522011-08-04 Andreas Schwab <schwab@linux-m68k.org>
1053
1054 * regex.c (re_iswctype): Remove some redundant boolean
1055 conversions.
1056
99aaf75f
JD
10572011-08-04 Jan Djärv <jan.h.d@swipnet.se>
1058
1059 * xterm.c (x_find_topmost_parent): New function.
1060 (x_set_frame_alpha): Find topmost parent window with
1061 x_find_topmost_parent and set the property there also (bug#9181).
1062 (handle_one_xevent): Call x_set_frame_alpha on ReparentNotify.
1063
c74e9d86
PE
10642011-08-04 Paul Eggert <eggert@cs.ucla.edu>
1065
1066 * callproc.c (Fcall_process): Avoid vfork clobbering
1067 the local vars buffer, coding_systems, current_dir.
1068
640c8776
SM
10692011-08-03 Stefan Monnier <monnier@iro.umontreal.ca>
1070
1071 * keymap.c (Fmake_composed_keymap): Move to subr.el.
1072
f26d0e4c
PE
10732011-08-03 Paul Eggert <eggert@cs.ucla.edu>
1074
8a10d76c
PE
1075 * fontset.c (dump_fontset) [FONTSET_DEBUG]: Declare EXTERNALLY_VISIBLE
1076 so that it is not optimized away.
1077
f26d0e4c
PE
1078 * xdisp.c (compute_display_string_pos): Remove unused local.
1079
55439c61
EZ
10802011-08-02 Eli Zaretskii <eliz@gnu.org>
1081
1082 Fix slow cursor motion and scrolling in large buffers with
1083 selective display, like Org Mode buffers. (Bug#9218)
1084
1085 * dispextern.h (struct bidi_it): New member disp_prop_p.
1086
1087 * xdisp.c: Remove one-slot cache of display string positions.
1088 (compute_display_string_pos): Accept an additional argument
5e617bc2 1089 DISP_PROP_P; callers changed. Scan at most 5K characters forward
55439c61
EZ
1090 for a display string or property. If found, set DISP_PROP_P
1091 non-zero.
1092
1093 * bidi.c (bidi_fetch_char): Accept an additional argument
640c8776
SM
1094 DISP_PROP_P, and pass it to compute_display_string_pos.
1095 Only handle text covered by a display string if DISP_PROP_P is returned
55439c61
EZ
1096 non-zero. All callers of bidi_fetch_char changed.
1097
fb33fa43
SM
10982011-08-02 Stefan Monnier <monnier@iro.umontreal.ca>
1099
1100 * keymap.c (Fdefine_key): Fix Lisp_Object/int mixup; apply some CSE.
1101
b099e063
DM
11022010-12-03 Don March <don@ohspite.net>
1103
1104 * keymap.c (Fdefine_key): Fix non-prefix key error message when
1105 last character M-[char] is translated to ESC [char] (bug#7541).
1106
5cc7f7af
KH
11072011-08-02 Kenichi Handa <handa@m17n.org>
1108
d0fffa3f 1109 * lisp.h (uniprop_table): Extern it.
5cc7f7af
KH
1110
1111 * chartab.c (uniprop_table): Make it non-static.
1112
525d5e6e
EZ
11132011-08-01 Eli Zaretskii <eliz@gnu.org>
1114
1115 * xdisp.c (forward_to_next_line_start): Accept additional argument
1116 BIDI_IT_PREV, and store into it the state of the bidi iterator had
1117 on the newline.
1118 (reseat_at_next_visible_line_start): Use the bidi iterator state
1119 returned by forward_to_next_line_start to restore the state of
1120 it->bidi_it after backing up to previous newline. (Bug#9212)
1121
31011111
AS
11222011-07-30 Andreas Schwab <schwab@linux-m68k.org>
1123
1124 * regex.c (re_comp): Protoize.
1125 (re_exec): Fix return type.
1126 (regexec): Fix type of `ret'. (Bug#9203)
1127
476371c4
PE
11282011-07-28 Paul Eggert <eggert@cs.ucla.edu>
1129
e5d76069
PE
1130 * image.c (check_image_size): Use 1024x1024 if unknown frame (Bug#9189).
1131 This is needed if max-image-size is a floating-point number.
1132
9a79b20c
AS
11332011-07-28 Andreas Schwab <schwab@linux-m68k.org>
1134
1135 * print.c (print_object): Print empty symbol as ##.
1136
1137 * lread.c (read1): Read ## as empty symbol.
1138
d8c2fa78
AA
11392011-07-28 Alp Aker <alp.tekin.aker@gmail.com>
1140
1141 * nsfns.m (x_set_foreground_color): Set f->foreground_pixel when
1142 setting frame foreground color (Bug#9175).
1143 (x_set_background_color): Likewise.
1144
ffe57a7a
AA
1145 * nsmenu.m (-setText): Size tooltip dimensions precisely to
1146 contents (Bug#9176).
1147 (EmacsTooltip -init): Remove bezels and add shadows to
1148 tooltip windows.
1149
bf3492a5
AA
1150 * nsterm.m (ns_dumpglyphs_stretch): Avoid overwriting left fringe
1151 or scroll bar (Bug#8470).
1152
d55e9c53
AA
1153 * nsfont.m (nsfont_open): Remove assignment to voffset and
1154 unnecessary vars hshink, expand, hd, full_height, min_height.
1155 (nsfont_draw): Use s->ybase as baseline for glyph drawing (Bug#8913).
1156
1157 * nsterm.h (nsfont_info): Remove voffset field.
1158
d8c2fa78 11592011-07-28 Alp Aker <alp.tekin.aker@gmail.com>
4843aac3
AA
1160
1161 Implement strike-through and overline on NextStep (Bug#8863).
1162
1163 * nsfont.m (nsfont_open): Use underline position provided by font,
1164 instead of hard-coded value of 2.
1165 (nsfont_draw): Call ns_draw_text_decoration instead.
1166
1167 * nsterm.h: Add declaration for ns_draw_text_decoration.
1168
1169 * nsterm.m (ns_draw_text_decoration): New function for drawing
1170 underline, overline, and strike-through.
1171 (ns_dumpglyphs_image, ns_dumpglyphs_stretch): Add call to
1172 ns_draw_text_decoration. Change treatment of cursor drawing to
1173 accomodate underlining, etc.
1174
4cc60b9b
EZ
11752011-07-28 Eli Zaretskii <eliz@gnu.org>
1176
bc7ece87
EZ
1177 * buffer.c (init_buffer_once): Set bidi-display-reordering to t by
1178 default.
4cc60b9b 1179
476371c4
PE
11802011-07-28 Paul Eggert <eggert@cs.ucla.edu>
1181
66606eea
PE
1182 * alloc.c (memory_full) [!SYNC_INPUT]: Fix signal-related race.
1183 Without this fix, if a signal arrives just after memory fills up,
1184 'malloc' might be invoked reentrantly.
1185
476371c4
PE
1186 * image.c (x_check_image_size) [!HAVE_X_WINDOWS]: Return 1.
1187 In other words, assume that every image size is allowed, on non-X
1188 hosts. This assumption is probably wrong, but it lets Emacs compile.
1189
f3fcc40d
AS
11902011-07-28 Andreas Schwab <schwab@linux-m68k.org>
1191
1192 * regex.c (re_iswctype): Convert return values to boolean.
1193
350c992f
EZ
11942011-07-28 Eli Zaretskii <eliz@fencepost.gnu.org>
1195
1196 * xdisp.c (compute_display_string_pos): Don't use cached display
1197 string position if the buffer had its restriction changed.
1198 (Bug#9184)
1199
5266b4bb
PE
12002011-07-28 Paul Eggert <eggert@cs.ucla.edu>
1201
1202 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork clobbering.
1203
2573a837 12042011-07-28 Paul Eggert <eggert@cs.ucla.edu>
ca4aa935 1205
41f55ccd 1206 Integer signedness and overflow and related fixes. (Bug#9079)
cf950e6b 1207
39e378da
PE
1208 * bidi.c: Integer size and overflow fixes.
1209 (bidi_cache_size, bidi_cache_idx, bidi_cache_last_idx)
1210 (bidi_cache_start, bidi_cache_fetch_state, bidi_cache_search)
1211 (bidi_cache_find_level_change, bidi_cache_ensure_space)
1212 (bidi_cache_iterator_state, bidi_cache_find, bidi_cache_start_stack)
1213 (bidi_find_other_level_edge):
1214 Use ptrdiff_t instead of EMACS_INT where either will do.
1215 This works better on 32-bit hosts configured --with-wide-int.
1216 (bidi_cache_ensure_space): Check for size-calculation overflow.
1217 Use % rather than repeated addition, for better worst-case speed.
1218 Don't set bidi_cache_size until after xrealloc returns, because it
1219 might not return.
1220 (bidi_dump_cached_states): Use ptrdiff_t, not int, to avoid overflow.
f0eb61e9
PE
1221 (bidi_cache_ensure_space): Also check that the bidi cache size
1222 does not exceed that of the largest Lisp string or buffer. See Eli
1223 Zaretskii in <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=9079#29>.
39e378da 1224
5e927815
PE
1225 * alloc.c (__malloc_size_t): Remove.
1226 All uses replaced by size_t. See Andreas Schwab's note
1227 <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=9079#8>.
1228
ca4aa935
PE
1229 * image.c: Improve checking for integer overflow.
1230 (check_image_size): Assume that f is nonnull, since
1231 it is always nonnull in practice. This is one less thing to
1232 worry about when checking for integer overflow later.
1233 (x_check_image_size): New function, which checks for integer
1234 overflow issues inside X.
1235 (x_create_x_image_and_pixmap, xbm_read_bitmap_data): Use it.
1236 This removes the need for a memory_full check.
1237 (xbm_image_p): Rewrite to avoid integer multiplication overflow.
1238 (Create_Pixmap_From_Bitmap_Data, xbm_load): Use x_check_image_size.
1239 (xbm_read_bitmap_data): Change locals back to 'int', since
1240 their values must fit in 'int'.
1241 (xpm_load_image, png_load, tiff_load):
1242 Invoke x_create_x_image_and_pixmap earlier,
1243 to avoid much needless work if the image is too large.
1244 (tiff_load): Treat overly large images as if
1245 x_create_x_image_and_pixmap failed, not as malloc failures.
1246 (gs_load): Use x_check_image_size.
1247
5f8f9cc2
PE
1248 * gtkutil.c: Omit integer casts.
1249 (xg_get_pixbuf_from_pixmap): Remove unnecessary cast.
1250 (xg_set_toolkit_scroll_bar_thumb): Rewrite to avoid need for cast.
1251
5adf60bc
PE
1252 * image.c (png_load): Don't assume height * row_bytes fits in 'int'.
1253
c8907a93
PE
1254 * xfaces.c (Fbitmap_spec_p): Fix integer overflow bug.
1255 Without this fix, (bitmap-spec-p '(34359738368 1 "x"))
1256 would wrongly return t on a 64-bit host.
1257
e3c25c68
PE
1258 * dispnew.c (init_display): Use *_RANGE_OVERFLOW macros.
1259 The plain *_OVERFLOW macros run afoul of GCC bug 49705
1260 <http://gcc.gnu.org/bugzilla/show_bug.cgi?id=49705>
1261 and therefore cause GCC to emit a bogus diagnostic in some cases.
1262
3f791afe
PE
1263 * image.c: Integer signedness and overflow and related fixes.
1264 This is not an exhaustive set of fixes, but it's time to
1265 record what I've got.
1266 (lookup_pixel_color, check_image_size): Remove redundant decls.
1267 (check_image_size): Don't assume that arbitrary EMACS_INT values
1268 fit in 'int', or that arbitrary 'double' values fit in 'int'.
1269 (x_alloc_image_color, x_create_x_image_and_pixmap, png_load)
1270 (tiff_load, imagemagick_load_image):
1271 Check for overflow in size calculations.
1272 (x_create_x_image_and_pixmap): Remove unnecessary test for
1273 xmalloc returning NULL; that can't happen.
1274 (xbm_read_bitmap_data): Don't assume sizes fit into 'int'.
1275 (xpm_color_bucket): Use better integer hashing function.
1276 (xpm_cache_color): Don't possibly over-allocate memory.
1277 (struct png_memory_storage, tiff_memory_source, tiff_seek_in_memory)
1278 (gif_memory_source):
1279 Use ptrdiff_t, not int or size_t, to record sizes.
1280 (png_load): Don't assume values greater than 2**31 fit in 'int'.
1281 (our_stdio_fill_input_buffer): Prefer ptrdiff_t to size_t when
1282 either works, as we prefer signed integers.
1283 (tiff_read_from_memory, tiff_write_from_memory):
1284 Return tsize_t, not size_t, since that's what the TIFF API wants.
1285 (tiff_read_from_memory): Don't fail simply because the read would
1286 go past EOF; instead, return a short read.
1287 (tiff_load): Omit no-longer-needed casts.
1288 (Fimagemagick_types): Don't assume size fits into 'int'.
1289
3cc5a532
PE
1290 Improve hashing quality when configured --with-wide-int.
1291 * fns.c (hash_string): New function, taken from sxhash_string.
1292 Do not discard information about ASCII character case; this
1293 discarding is no longer needed.
1294 (sxhash-string): Use it. Change sig to match it. Caller changed.
1295 * lisp.h: Declare it.
1296 * lread.c (hash_string): Remove, since we now use fns.c's version.
1297 The fns.c version returns a wider integer if --with-wide-int is
1298 specified, so this should help the quality of the hashing a bit.
1299
b312a492
PE
1300 * emacs.c: Integer overflow minor fix.
1301 (heap_bss_diff): Now uprintmax_t, not unsigned long. All used changed.
1302 Define only if GNU_LINUX.
1303 (main, Fdump_emacs): Set and use heap_bss_diff only if GNU_LINUX.
1304
dfd153ae
PE
1305 * dispnew.c: Integer signedness and overflow fixes.
1306 Remove unnecessary forward decls, that were a maintenance hassle.
1307 (history_tick): Now uprintmax_t, so it's more likely to avoid overflow.
1308 All uses changed.
1309 (adjust_glyph_matrix, realloc_glyph_pool, adjust_frame_message_buffer)
1310 (scrolling_window): Use ptrdiff_t, not int, for byte count.
1311 (prepare_desired_row, line_draw_cost):
1312 Use int, not unsigned, where either works.
1313 (save_current_matrix, restore_current_matrix):
1314 Use ptrdiff_t, not size_t, where either works.
1315 (init_display): Check for overflow more accurately, and without
1316 relying on undefined behavior.
1317
a81d11a3
PE
1318 * editfns.c (pWIDE, pWIDElen, signed_wide, unsigned_wide):
1319 Remove, replacing with the new symbols in lisp.h. All uses changed.
1320 * fileio.c (make_temp_name):
1321 * filelock.c (lock_file_1, lock_file):
1322 * xdisp.c (message_dolog):
1323 Don't assume PRIdMAX etc. works; this isn't portable to pre-C99 hosts.
1324 Use pMd etc. instead.
1325 * lisp.h (printmax_t, uprintmax_t, pMd, pMu): New types and macros,
1326 replacing the pWIDE etc. symbols removed from editfns.c.
1327
3300e6fd
PE
1328 * keyboard.h (num_input_events): Now uintmax_t.
1329 This is (very slightly) less likely to mess up due to wraparound.
1330 All uses changed.
1331
fd05c7e9
PE
1332 * buffer.c: Integer signedness fixes.
1333 (alloc_buffer_text, enlarge_buffer_text):
1334 Use ptrdiff_t rather than size_t when either will do, as we prefer
1335 signed integers.
1336
903fe15d
PE
1337 * alloc.c: Integer signedness and overflow fixes.
1338 Do not impose an arbitrary 32-bit limit on malloc sizes when debugging.
1339 (__malloc_size_t): Default to size_t, not to int.
1340 (pure_size, pure_bytes_used_before_overflow, stack_copy_size)
1341 (Fgarbage_collect, mark_object_loop_halt, mark_object):
1342 Prefer ptrdiff_t to size_t when either would do, as we prefer
1343 signed integers.
1344 (XMALLOC_OVERRUN_CHECK_OVERHEAD): New macro.
1345 (xmalloc_overrun_check_header, xmalloc_overrun_check_trailer):
1346 Now const. Initialize with values that are in range even if char
1347 is signed.
1348 (XMALLOC_PUT_SIZE, XMALLOC_GET_SIZE): Remove, replacing with ...
1349 (xmalloc_put_size, xmalloc_get_size): New functions. All uses changed.
1350 These functions do the right thing with sizes > 2**32.
1351 (check_depth): Now ptrdiff_t, not int.
1352 (overrun_check_malloc, overrun_check_realloc, overrun_check_free):
1353 Adjust to new way of storing sizes. Check for size overflow bugs
1354 in rest of code.
1355 (STRING_BYTES_MAX): Adjust to new overheads. The old code was
1356 slightly wrong anyway, as it missed one instance of
1357 XMALLOC_OVERRUN_CHECK_OVERHEAD.
1358 (refill_memory_reserve): Omit needless cast to size_t.
1359 (mark_object_loop_halt): Mark as externally visible.
1360
ac82cc6a
PE
1361 * xselect.c: Integer signedness and overflow fixes.
1362 (Fx_register_dnd_atom, x_handle_dnd_message):
1363 Use ptrdiff_t, not size_t, since we prefer signed.
1364 (Fx_register_dnd_atom): Check for ptrdiff_t (and size_t) overflow.
1365 * xterm.h (struct x_display_info): Use ptrdiff_t, not size_t, for
1366 x_dnd_atoms_size and x_dnd_atoms_length.
1367
c2d1e36d
PE
1368 * doprnt.c: Prefer signed to unsigned when either works.
1369 * eval.c (verror):
1370 * doprnt.c (doprnt):
1371 * lisp.h (doprnt):
1372 * xdisp.c (vmessage):
1373 Use ptrdiff_t, not size_t, when using or implementing doprnt,
1374 since the sizes cannot exceed ptrdiff_t bounds anyway, and we
1375 prefer signed arithmetic to avoid comparison confusion.
1376 * doprnt.c (doprnt): Avoid a "+ 1" that can't overflow,
1377 but is a bit tricky.
1378
0e926e56
PE
1379 Assume freestanding C89 headers, string.h, stdlib.h.
1380 * data.c, doprnt.c, floatfns.c, print.c:
1381 Include float.h unconditionally.
1382 * gmalloc.c: Assume C89-at-least behavior for preprocessor,
1383 limits.h, stddef.h, string.h. Use memset instead of 'flood'.
1384 * regex.c: Likewise for stddef.h, string.h.
1385 (ISASCII): Remove; can assume it returns 1 now. All uses removed.
1386 * s/aix4-2.h (HAVE_STRING_H): Remove obsolete undef.
1387 * s/ms-w32.h (HAVE_LIMITS_H, HAVE_STRING_H, HAVE_STDLIB_H)
1388 (STDC_HEADERS): Remove obsolete defines.
1389 * sysdep.c: Include limits.h unconditionally.
1390
9cfdb3ec
PE
1391 Assume support for memcmp, memcpy, memmove, memset.
1392 * lisp.h, sysdep.c (memcmp, memcpy, memmove, memset):
1393 * regex.c (memcmp, memcpy):
1394 Remove; we assume C89 now.
1395
1396 * gmalloc.c (memcpy, memset, memmove): Remove; we assume C89 now.
1397 (__malloc_safe_bcopy): Remove; no longer needed.
1398
cf950e6b 1399 * lisp.h (struct vectorlike_header, struct Lisp_Subr): Signed sizes.
6089c567
PE
1400 Use EMACS_INT, not EMACS_UINT, for sizes. The code works equally
1401 well either way, and we prefer signed to unsigned.
1402
dbf38e02
LMI
14032011-07-27 Lars Magne Ingebrigtsen <larsi@gnus.org>
1404
1405 * gnutls.c (emacs_gnutls_read): Don't message anything if the peer
1406 closes the connection while we're reading (bug#9182).
1407
d6f0886c 14082011-07-25 Jan Djärv <jan.h.d@swipnet.se>
24e0f6b1 1409
d6f0886c
JD
1410 * nsmenu.m (ns_popup_dialog): Add an "ok" button if no buttons
1411 are specified (Bug#9168).
24e0f6b1 1412
2eb1f9e6
PE
14132011-07-25 Paul Eggert <eggert@cs.ucla.edu>
1414
1415 * bidi.c (bidi_dump_cached_states): Fix printf format mismatch.
1416 Found by GCC static checking and --with-wide-int on a 32-bit host.
1417
22381272 14182011-07-25 Eli Zaretskii <eliz@gnu.org>
7daee910
EZ
1419
1420 * xdisp.c (compute_display_string_pos): Fix logic of caching
1421 previous display string position. Initialize cached_prev_pos to
1422 -1. Fixes slow-down at the beginning of a buffer.
1423
f25e39b4
EZ
14242011-07-24 Eli Zaretskii <eliz@gnu.org>
1425
1426 * xfaces.c (check_lface_attrs) [HAVE_WINDOW_SYSTEM]: Allow `nil'
1427 for attrs[LFACE_FONTSET_INDEX].
1428
04c4b52e
PE
14292011-07-23 Paul Eggert <eggert@cs.ucla.edu>
1430
1431 * xml.c (parse_region): Remove unused local
1432 that was recently introduced.
1433
c1734fbd
EZ
14342011-07-23 Eli Zaretskii <eliz@gnu.org>
1435
be18c5a5
EZ
1436 * xfns.c (unwind_create_frame) [GLYPH_DEBUG]: Adapt to changes in
1437 2008-02-22T17:42:09Z!monnier@iro.umontreal.ca.
1438
c1734fbd
EZ
1439 * xdisp.c (move_it_in_display_line_to): Record the best matching
1440 position for TO_CHARPOS while scanning the line, and restore it on
640c8776
SM
1441 exit if none of the characters scanned was an exact match.
1442 Fixes vertical-motion and pos-visible-in-window-p under bidi redisplay
a9269c18
EZ
1443 when exact match is impossible due to invisible text, and the
1444 lines are truncated.
1445
a258d627
JD
14462011-07-23 Jan Djärv <jan.h.d@swipnet.se>
1447
1448 * nsterm.m (initFrameFromEmacs): Set NSTitledWindowMask in styleMask
1449 for OSX >= 10.7.
1450
b6d5a689
EZ
14512011-07-22 Eli Zaretskii <eliz@gnu.org>
1452
0f74f785
EZ
1453 Fix a significant slow-down of cursor motion with C-n, C-p,
1454 C-f/C-b, and C-v/M-v that couldn't keep up with keyboard
1455 auto-repeat under bidi redisplay in fontified buffers.
b6d5a689 1456 * xdisp.c (compute_stop_pos_backwards): New function.
b6d5a689
EZ
1457 (next_element_from_buffer): Call compute_stop_pos_backwards to
1458 find a suitable prev_stop when we find ourselves before
0f74f785
EZ
1459 base_level_stop.
1460 (reseat): Don't look for prev_stop, as that could mean a very long
1461 run.
1462 <cached_disp_pos, cached_disp_buffer, cached_disp_modiff>
1463 <cached_disp_overlay_modiff>: Cache for last found display string
1464 position.
551918c1 1465 (compute_display_string_pos): Return the cached position if asked
0f74f785
EZ
1466 about the same buffer in the same area of character positions, and
1467 the buffer wasn't changed since the time the display string
1468 position was cached.
551918c1 1469
b2d0c91a
EZ
14702011-07-22 Eli Zaretskii <eliz@gnu.org>
1471
1472 * xdisp.c (rows_from_pos_range): Don't ignore glyphs whose object
1473 is an integer, which is important for empty lines. (Bug#9149)
1474
043604ee
CY
14752011-07-22 Chong Yidong <cyd@stupidchicken.com>
1476
1477 * frame.c (Fmodify_frame_parameters): In tty case, update the
1478 default face if necessary (Bug#4238).
1479
da4adb04
CY
14802011-07-21 Chong Yidong <cyd@stupidchicken.com>
1481
1482 * editfns.c (Fstring_to_char): No need to explain what a character
1483 is in the docstring (Bug#6576).
1484
9abd0532
LMI
14852011-07-20 Lars Magne Ingebrigtsen <larsi@gnus.org>
1486
1487 * xml.c (parse_region): Make sure we always return a tree.
1488
36881d16
HK
14892011-07-20 HAMANO Kiyoto <khiker.mail@gmail.com>
1490
1491 * xml.c (parse_region): If a document contains only comments,
1492 return that, too.
1493
1e98674d
LMI
14942011-07-20 Lars Magne Ingebrigtsen <larsi@gnus.org>
1495
1496 * xml.c (make_dom): Return comments, too.
1497
590bd467
PE
14982011-07-19 Paul Eggert <eggert@cs.ucla.edu>
1499
1500 Port to OpenBSD.
1501 See http://lists.gnu.org/archive/html/emacs-devel/2011-07/msg00688.html
1502 and the surrounding thread.
1503 * minibuf.c (read_minibuf_noninteractive): Rewrite to use getchar
1504 rather than fgets, and retry after EINTR. Otherwise, 'emacs
1505 --batch -f byte-compile-file' fails on OpenBSD if an inactivity
1506 timer goes off.
1507 * s/openbsd.h (BROKEN_SIGIO): Define.
1508 * unexelf.c (unexec) [__OpenBSD__]:
1509 Don't update the .mdebug section of the Alpha COFF symbol table.
1510
f41628b2
LMI
15112011-07-19 Lars Magne Ingebrigtsen <larsi@gnus.org>
1512
1513 * lread.c (syms_of_lread): Clarify when `lexical-binding' is used
1514 (bug#8460).
1515
b59b67c5
PE
15162011-07-18 Paul Eggert <eggert@cs.ucla.edu>
1517
15e3a074
PE
1518 * fileio.c (Fcopy_file) [!MSDOS]: Tighten created file's mask.
1519 This fixes some race conditions on the permissions of any newly
1520 created file.
1521
41bed37d
PE
1522 * alloc.c (valid_pointer_p): Use pipe, not open.
1523 This fixes some permissions issues when debugging.
1524
b59b67c5
PE
1525 * fileio.c (Fcopy_file): Adjust mode if fchown fails. (Bug#9002)
1526 If fchown fails to set both uid and gid, try to set just gid,
1527 as that is sometimes allowed. Adjust the file's mode to eliminate
1528 setuid or setgid bits that are inappropriate if fchown fails.
1529
925a6be7
SM
15302011-07-18 Stefan Monnier <monnier@iro.umontreal.ca>
1531
1532 * xdisp.c (next_element_from_string, next_element_from_buffer): Use EQ
1533 to compare Lisp_Objects.
1534 * gnutls.c (syms_of_gnutls): Rename Vgnutls_log_level to
1535 global_gnutls_log_level, don't mistake it for a Lisp_Object.
1536 (init_gnutls_functions, emacs_gnutls_handle_error): Fix up uses.
1537
52968808
AS
15382011-07-17 Andreas Schwab <schwab@linux-m68k.org>
1539
0a6a104b
AS
1540 * lread.c (read_integer): Unread even EOF character.
1541 (read1): Likewise. Properly record start position of symbol.
1542
52968808
AS
1543 * lread.c (read1): Read `#:' as empty uninterned symbol if no
1544 symbol character follows.
1545
9e381cdd
PE
15462011-07-17 Paul Eggert <eggert@cs.ucla.edu>
1547
1548 * fileio.c (Fcopy_file): Pacify gcc re fchown. (Bug#9002)
1549 This works around a problem with the previous change to Fcopy_file.
1550 Recent glibc declares fchown with __attribute__((warn_unused_result)),
1551 and without this change, GCC might complain about discarding
1552 fchown's return value.
1553
b5641435
JB
15542011-07-16 Juanma Barranquero <lekktu@gmail.com>
1555
1556 * makefile.w32-in (GLOBAL_SOURCES): Add gnutls.c (followup to bug#9059).
1557
a8031457
PE
15582011-07-16 Paul Eggert <eggert@cs.ucla.edu>
1559
1560 * fileio.c (Fcopy_file): Don't diagnose fchown failures. (Bug#9002)
1561
dd889327
LMI
15622011-07-16 Lars Magne Ingebrigtsen <larsi@gnus.org>
1563
750c33f7
LMI
1564 * gnutls.c (syms_of_gnutls): Define `gnutls-log-level' here, since
1565 it's used from the C level.
1566
dd889327
LMI
1567 * process.c: Use the same condition for POLL_FOR_INPUT in both
1568 keyboard.c and process.c (bug#1858).
1569
87e86684
LM
15702011-07-09 Lawrence Mitchell <wence@gmx.li>
1571
1572 * gnutls.c (Qgnutls_bootprop_min_prime_bits): New variable.
1573 (Fgnutls_boot): Use it.
1574
64348f40
AS
15752011-07-15 Andreas Schwab <schwab@linux-m68k.org>
1576
1577 * doc.c (Fsubstitute_command_keys): Revert last change.
1578
1d698799
LMI
15792011-07-15 Lars Magne Ingebrigtsen <larsi@gnus.org>
1580
f863868c
LMI
1581 * doc.c (Fsubstitute_command_keys): Clarify that \= really only
1582 quotes the next character, and doesn't affect other longer
1583 sequences (bug#8935).
1584
1d698799
LMI
1585 * lread.c (syms_of_lread): Clarify that is isn't only
1586 `eval-buffer' and `eval-defun' that's affected by
1587 `lexical-binding' (bug#8460).
1588
aa4b6df6
EZ
15892011-07-15 Eli Zaretskii <eliz@gnu.org>
1590
1591 * xdisp.c (move_it_in_display_line_to): Fix vertical motion with
1592 bidi redisplay when a line includes both an image and is
1593 truncated.
1594
5d856da6
PE
15952011-07-14 Paul Eggert <eggert@cs.ucla.edu>
1596
ad6042bb
PE
1597 Fix minor problems found by static checking.
1598 * bidi.c (bidi_cache_size): Now EMACS_INT, not size_t.
1599 (elsz): Now a signed constant, not a size_t var. We prefer signed
1600 types to unsigned, to avoid integer comparison confusion. Without
1601 this change, GCC 4.6.1 with -Wunsafe-loop-optimizations complains
1602 "cannot optimize loop, the loop counter may overflow", a symptom
1603 of the confusion.
f00bbb22 1604 * indent.c (Fvertical_motion): Mark locals as initialized.
5d856da6
PE
1605 * xdisp.c (reseat_to_string): Fix pointer signedness issue.
1606
6468f31c
LMI
16072011-07-14 Lars Magne Ingebrigtsen <larsi@gnus.org>
1608
49080b10
LMI
1609 * search.c (Fre_search_backward): Mention `case-fold-search' in
1610 all the re_search_* functions (bug#8138).
1611
6468f31c
LMI
1612 * keyboard.c (Fopen_dribble_file): Document when the file is
1613 closed (bug#8056).
1614
c965adc5
EZ
16152011-07-14 Eli Zaretskii <eliz@gnu.org>
1616
df9733bf
EZ
1617 * bidi.c (bidi_dump_cached_states): Fix format of displaying
1618 bidi_cache_idx.
1619
0bb23927
EZ
1620 Support bidi reordering of display and overlay strings.
1621 * xdisp.c (compute_display_string_pos)
1622 (compute_display_string_end): Accept additional argument STRING.
1623 (init_iterator, reseat_1): Initialize bidi_it->string.s to NULL.
1624 (reseat_to_string): Initialize bidi_it->string.s and
1625 bidi_it->string.schars.
1626 (Fcurrent_bidi_paragraph_direction): Initialize itb.string.s to
640c8776
SM
1627 NULL (avoids a crash in bidi_paragraph_init).
1628 Initialize itb.string.lstring.
0bb23927
EZ
1629 (init_iterator): Call bidi_init_it only of a valid
1630 buffer position was specified. Initialize paragraph_embedding to
1631 L2R.
1632 (reseat_to_string): Initialize the bidi iterator.
1633 (display_string): If we need to ignore text properties of
1634 LISP_STRING, set IT->stop_charpos to IT->end_charpos. (The
1635 original value of -1 will not work with bidi.)
1636 (compute_display_string_pos): First arg is now struct
1637 `text_pos *'; all callers changed. Support display properties on
1638 Lisp strings.
1639 (compute_display_string_end): Support display properties on Lisp
1640 strings.
1641 (init_iterator, reseat_1, reseat_to_string): Initialize the
1642 string.bufpos member to 0 (zero, for compatibility with IT_CHARPOS
1643 when iterating on a string not from display properties).
640c8776
SM
1644 (compute_display_string_pos, compute_display_string_end):
1645 Fix calculation of the object to scan. Fixes an error when using
0bb23927
EZ
1646 arrow keys.
1647 (next_element_from_buffer): Don't abort when IT_CHARPOS is before
640c8776
SM
1648 base_level_stop; instead, set base_level_stop to BEGV.
1649 Fixes crashes in vertical-motion.
0bb23927
EZ
1650 (next_element_from_buffer): Improve commentary for when
1651 the iterator is before prev_stop.
1652 (init_iterator): Initialize bidi_p from the default value of
1653 bidi-display-reordering, not from buffer-local value. Use the
1654 buffer-local value only if initializing for buffer iteration.
1655 (handle_invisible_prop): Support invisible properties on strings
1656 that are being bidi-reordered.
1657 (set_iterator_to_next): Support bidi reordering of C strings and
1658 Lisp strings.
1659 (next_element_from_string): Support bidi reordering of Lisp
1660 strings.
1661 (handle_stop_backwards): Support Lisp strings as well.
640c8776
SM
1662 (display_string): Support display of R2L glyph rows.
1663 Use IT_STRING_CHARPOS when displaying from a Lisp string.
0bb23927
EZ
1664 (init_iterator): Don't initialize it->bidi_p for strings
1665 here.
1666 (reseat_to_string): Initialize it->bidi_p for strings here.
1667 (next_element_from_string, next_element_from_c_string)
1668 (next_element_from_buffer): Add xassert's for correspondence
1669 between IT's object being iterated and it->bidi_it.string
1670 structure.
1671 (face_before_or_after_it_pos): Support bidi iteration.
1672 (next_element_from_c_string): Handle the case of the first string
1673 character that is not the first one in the visual order.
1674 (get_visually_first_element): New function, refactored from common
1675 parts of next_element_from_buffer, next_element_from_string, and
1676 next_element_from_c_string.
1677 (tool_bar_lines_needed, redisplay_tool_bar)
1678 (display_menu_bar): Force left-to-right direction. Add a FIXME
1679 comment for making that be controlled by a user option.
1680 (push_it, pop_it): Save and restore the state of the
1681 bidi iterator. Save and restore the bidi_p flag.
1682 (pop_it): Iterate out of display property for string iteration as
1683 well.
1684 (iterate_out_of_display_property): Support iteration over strings.
1685 (handle_single_display_spec): Set up it->bidi_it for iteration
1686 over a display string, and call bidi_init_it.
1687 (handle_single_display_spec, next_overlay_string)
1688 (get_overlay_strings_1, push_display_prop): Set up the bidi
1689 iterator for displaying display or overlay strings.
1690 (forward_to_next_line_start): Don't use the shortcut if
1691 bidi-iterating.
1692 (back_to_previous_visible_line_start): If handle_display_prop
1693 pushed the iterator stack, restore the internal state of the bidi
1694 iterator by calling bidi_pop_it same number of times.
1695 (reseat_at_next_visible_line_start): If ON_NEWLINE_P is non-zero,
1696 and we are bidi-iterating, don't decrement the iterator position;
1697 instead, set the first_elt flag in the bidi iterator, to produce
1698 the same effect.
1699 (reseat_1): Remove redundant setting of string_from_display_prop_p.
1700 (push_display_prop): xassert that we are iterating a buffer.
1701 (push_it, pop_it): Save and restore paragraph_embedding member.
1702 (handle_single_display_spec, next_overlay_string)
1703 (get_overlay_strings_1, reseat_1, reseat_to_string)
1704 (push_display_prop): Set up the `unibyte' member of bidi_it.string
1705 correctly. Don't assume unibyte strings are not bidi-reordered.
1706 (compute_display_string_pos)
1707 (compute_display_string_end): Fix handling the case of C string.
1708 (push_it, pop_it): Save and restore from_disp_prop_p.
1709 (handle_single_display_spec, push_display_prop): Set the
1710 from_disp_prop_p flag.
1711 (get_overlay_strings_1): Reset the from_disp_prop_p flag.
1712 (pop_it): Call iterate_out_of_display_property only if we are
1713 popping after iteration over a string that came from a display
1714 property. Fix a typo in popping stretch info. Add an assertion
1715 for verifying that the iterator position is in sync with the bidi
1716 iterator.
1717 (handle_single_display_spec, get_overlay_strings_1)
1718 (push_display_prop): Fix initialization of paragraph direction for
1719 string when that of the parent object is not yet determined.
1720 (reseat_1): Call bidi_init_it to resync the bidi
1721 iterator with IT's position. (Bug#7616)
1722 (find_row_edges): If ROW->start.pos gives position
1723 smaller than min_pos, use it as ROW->minpos. (Bug#7616)
1724 (handle_stop, back_to_previous_visible_line_start, reseat_1):
1725 Reset the from_disp_prop_p flag.
1726 (SAVE_IT, RESTORE_IT): New macros.
1727 (pos_visible_p, face_before_or_after_it_pos)
1728 (back_to_previous_visible_line_start)
1729 (move_it_in_display_line_to, move_it_in_display_line)
1730 (move_it_to, move_it_vertically_backward, move_it_by_lines)
1731 (try_scrolling, redisplay_window, display_line): Use them when
1732 saving a temporary copy of the iterator and restoring it back.
1733 (back_to_previous_visible_line_start, reseat_1)
1734 (init_iterator): Empty the bidi cache "stack".
1735 (move_it_in_display_line_to): If iterator ended up at
1736 EOL, but we never saw any buffer positions smaller than
1737 to_charpos, return MOVE_POS_MATCH_OR_ZV. Fixes vertical cursor
1738 motion in bidi-reordered lines.
1739 (move_it_in_display_line_to): Record prev_method and prev_pos
1740 immediately before the call to set_iterator_to_next. Fixes cursor
1741 motion in bidi-reordered lines with stretch glyphs and strings
1742 displayed in margins. (Bug#8133) (Bug#8867)
1743 Return MOVE_POS_MATCH_OR_ZV only if iterator position is past
1744 TO_CHARPOS.
640c8776
SM
1745 (pos_visible_p): Support positions in bidi-reordered lines.
1746 Save and restore bidi cache.
0bb23927
EZ
1747
1748 * bidi.c (bidi_level_of_next_char): clen should be EMACS_NT, not int.
1749 (bidi_paragraph_info): Delete unused struct.
1750 (bidi_cache_idx, bidi_cache_last_idx): Declare EMACS_INT.
1751 (bidi_cache_start): New variable.
1752 (bidi_cache_reset): Reset bidi_cache_idx to bidi_cache_start, not
1753 to zero.
1754 (bidi_cache_fetch_state, bidi_cache_search)
1755 (bidi_cache_find_level_change, bidi_cache_iterator_state)
1756 (bidi_cache_find, bidi_peek_at_next_level)
1757 (bidi_level_of_next_char, bidi_find_other_level_edge)
1758 (bidi_move_to_visually_next): Compare cache index with
1759 bidi_cache_start rather than with zero.
1760 (bidi_fetch_char): Accept new argument STRING; all callers
1761 changed. Support iteration over a string. Support strings with
1762 display properties. Support unibyte strings. Fix the type of
1763 `len' according to what STRING_CHAR_AND_LENGTH expects.
1764 (bidi_paragraph_init, bidi_resolve_explicit_1)
1765 (bidi_resolve_explicit, bidi_resolve_weak)
640c8776
SM
1766 (bidi_level_of_next_char, bidi_move_to_visually_next):
1767 Support iteration over a string.
0bb23927
EZ
1768 (bidi_set_sor_type, bidi_resolve_explicit_1)
1769 (bidi_resolve_explicit, bidi_type_of_next_char): ignore_bn_limit
1770 can now be zero (for strings); special values 0 and -1 were
1771 changed to -1 and -2, respectively.
1772 (bidi_char_at_pos): New function.
1773 (bidi_paragraph_init, bidi_resolve_explicit, bidi_resolve_weak):
1774 Call it instead of FETCH_MULTIBYTE_CHAR.
1775 (bidi_move_to_visually_next): Abort if charpos or bytepos were not
1776 initialized to valid values.
1777 (bidi_init_it): Don't initialize charpos and bytepos with invalid
1778 values.
1779 (bidi_level_of_next_char): Allow the sentinel "position" to pass
1780 the test for valid cached positions. Fix the logic for looking up
1781 the sentinel state in the cache. GCPRO the Lisp string we are
1782 iterating.
1783 (bidi_push_it, bidi_pop_it): New functions.
1784 (bidi_initialize): Initialize the bidi cache start stack pointer.
1785 (bidi_cache_ensure_space): New function, refactored from part of
1786 bidi_cache_iterator_state. Don't assume the required size is just
1787 one BIDI_CACHE_CHUNK away.
1788 (bidi_cache_start_stack, bidi_push_it): Use IT_STACK_SIZE.
1789 (bidi_count_bytes, bidi_char_at_pos): New functions.
1790 (bidi_cache_search): Don't assume bidi_cache_last_idx is
1791 always valid if bidi_cache_idx is valid.
1792 (bidi_cache_find_level_change): xassert that bidi_cache_last_idx
1793 is valid if it's going to be used.
1794 (bidi_shelve_cache, bidi_unshelve_cache): New functions.
1795 (bidi_cache_fetch_state, bidi_cache_search)
c965adc5
EZ
1796 (bidi_cache_find_level_change, bidi_cache_ensure_space)
1797 (bidi_cache_iterator_state, bidi_cache_find)
640c8776
SM
1798 (bidi_find_other_level_edge, bidi_cache_start_stack):
1799 All variables related to cache indices are now EMACS_INT.
c965adc5 1800
0bb23927
EZ
1801 * dispextern.h (struct bidi_string_data): New structure.
1802 (struct bidi_it): New member `string'. Make flag members be 1-bit
1803 fields, and put them last in the struct.
640c8776
SM
1804 (compute_display_string_pos, compute_display_string_end):
1805 Update prototypes.
0bb23927
EZ
1806 (bidi_push_it, bidi_pop_it): Add prototypes.
1807 (struct iterator_stack_entry): New members bidi_p,
1808 paragraph_embedding, and from_disp_prop_p.
1809 (struct it): Member bidi_p is now a bit field 1 bit wide.
640c8776
SM
1810 (bidi_shelve_cache, bidi_unshelve_cache):
1811 Declare prototypes.
0bb23927
EZ
1812
1813 * .gdbinit (xvectype, xvector, xcompiled, xchartable, xboolvector)
1814 (xpr, xfont, xbacktrace): Use "header.size" when accessing vectors
1815 and vector-like objects.
1816
1817 * dispnew.c (buffer_posn_from_coords): Save and restore the bidi
1818 cache around display iteration.
1819
1820 * window.c (Fwindow_end, window_scroll_pixel_based)
1821 (displayed_window_lines, Frecenter): Save and restore the bidi
1822 cache around display iteration.
1823
3bbd2265
LMI
18242011-07-14 Lars Magne Ingebrigtsen <larsi@gnus.org>
1825
1826 * editfns.c (Fdelete_region): Clarify the use of the named
1827 parameters (bug#6788).
1828
adc47434
MR
18292011-07-14 Martin Rudalics <rudalics@gmx.at>
1830
1831 * indent.c (Fvertical_motion): Set and restore w->pointm when
1832 saving and restoring the window's buffer (Bug#9006).
1833
837c31f8
LMI
18342011-07-13 Lars Magne Ingebrigtsen <larsi@gnus.org>
1835
1836 * editfns.c (Fstring_to_char): Clarify just what is returned
1837 (bug#6576). Text by Eli Zaretskii.
1838
ac389d0c
JB
18392011-07-13 Juanma Barranquero <lekktu@gmail.com>
1840
1841 * gnutls.c (init_gnutls_functions): Honor gnutls_log_level (bug#9059).
1842
0be0ce47
EZ
18432011-07-13 Eli Zaretskii <eliz@gnu.org>
1844
1845 * buffer.c (mmap_find): Fix a typo.
1846
cd18e7e3
JB
18472011-07-13 Johan Bockgård <bojohan@gnu.org>
1848
1849 Fix execution of x selection hooks.
1850 * xselect.c (Qx_lost_selection_functions)
1851 (Qx_sent_selection_functions): New vars.
1852 (syms_of_xselect): DEFSYM them.
1853 (x_handle_selection_request): Pass Qx_sent_selection_functions
1854 rather than Vx_sent_selection_functions to Frun_hook_with_args.
1855 (x_handle_selection_clear,x_clear_frame_selections):
1856 Pass Qx_lost_selection_functions rather than
1857 Vx_lost_selection_functions to Frun_hook_with_args.
1858
47ea7f44
PE
18592011-07-13 Paul Eggert <eggert@cs.ucla.edu>
1860
ac389d0c 1861 * buffer.c (Fget_buffer_create): Initialize inhibit_shrinking.
2941c447
PE
1862 The old code sometimes used this field without initializing it.
1863
47ea7f44
PE
1864 * alloc.c (gc_sweep): Don't read past end of array.
1865 In theory, the old code could also have corrupted Emacs internals,
1866 though it'd be very unlikely.
1867
bc985c87
AS
18682011-07-12 Andreas Schwab <schwab@linux-m68k.org>
1869
1870 * character.c (Fcharacterp): Don't advertise optional ignored
ac389d0c 1871 argument. (Bug#4026)
bc985c87 1872
0cf34688
LMI
18732011-07-12 Lars Magne Ingebrigtsen <larsi@gnus.org>
1874
b3dadd76
LMI
1875 * keymap.c (syms_of_keymap): Clarify that "modifier" is "modifier
1876 key" (bug#4257).
1877
0cf34688
LMI
1878 * window.c (Fset_window_start): Doc fix (bug#4199).
1879 (Fset_window_hscroll): Ditto.
1880
270768cd
PE
18812011-07-12 Paul Eggert <eggert@cs.ucla.edu>
1882
077e3dda 1883 Fix minor new problems caught by GCC 4.6.1.
270768cd 1884 * term.c (init_tty): Remove unused local.
490011a6 1885 * xsettings.c (store_monospaced_changed): Define this function only
077e3dda 1886 if (defined HAVE_GSETTINGS || defined HAVE_GCONF), as it's
490011a6 1887 not used otherwise.
270768cd 1888
b1f58454
CY
18892011-07-12 Chong Yidong <cyd@stupidchicken.com>
1890
1891 * xdisp.c (Vresize_mini_windows): Minor doc fix (Bug#3300).
1892
22b9578d
LMI
18932011-07-11 Lars Magne Ingebrigtsen <larsi@gnus.org>
1894
6e70ab07
LMI
1895 * xdisp.c (syms_of_xdisp): Make it explicit that the mini-windows
1896 are the mini-buffer and the echo area (bug#3320).
1897
22b9578d
LMI
1898 * term.c (init_tty): Remove support for supdup, c10 and perq
1899 terminals, which are no longer supported (bug#1482).
1900
8974cc9f
JB
19012011-07-10 Johan Bockgård <bojohan@gnu.org>
1902
1903 * xdisp.c (Ftool_bar_lines_needed): Fix WINDOWP check.
1904
a560d974
JD
19052011-07-10 Jan Djärv <jan.h.d@swipnet.se>
1906
1907 * xmenu.c (menu_highlight_callback): Only pass frame to show_help_event
1908 for non-popups (Bug#3642).
1909
1dae0f0a
AS
19102011-07-10 Andreas Schwab <schwab@linux-m68k.org>
1911
268c2c36 1912 * alloc.c (reset_malloc_hooks): Protoize.
1dae0f0a 1913 * buffer.c (mmap_init, mmap_find, mmap_free_1, mmap_enlarge)
268c2c36
AS
1914 (mmap_set_vars, mmap_alloc, mmap_free, mmap_realloc): Likewise.
1915 * cm.c (losecursor): Likewise.
1dae0f0a
AS
1916 * data.c (fmod): Likewise.
1917 * dispnew.c (swap_glyphs_in_rows): Likewise.
1918 * emacs.c (memory_warning_signal): Likewise.
1919 * floatfns.c (float_error): Likewise.
1920 * font.c (check_gstring, check_otf_features, otf_tag_symbol)
1921 (otf_open, font_otf_capability, generate_otf_features)
1922 (font_otf_DeviceTable, font_otf_ValueRecord, font_otf_Anchor):
1923 Likewise.
1924 * image.c (pbm_read_file): Likewise.
1925 * indent.c (string_display_width): Likewise.
1926 * intervals.c (check_for_interval, search_for_interval)
1927 (inc_interval_count, count_intervals, root_interval)
1928 (adjust_intervals_for_insertion, make_new_interval): Likewise.
1929 * lread.c (defalias): Likewise.
268c2c36 1930 * ralloc.c (r_alloc_check): Likewise.
1dae0f0a
AS
1931 * regex.c (set_image_of_range_1, set_image_of_range)
1932 (regex_grow_registers): Likewise.
1933 * sysdep.c (strerror): Likewise.
1934 * termcap.c (valid_filename_p, tprint, main): Likewise.
1935 * tparam.c (main): Likewise.
1936 * unexhp9k800.c (run_time_remap, save_data_space)
1937 (update_file_ptrs, read_header, write_header, calculate_checksum)
1938 (copy_file, copy_rest, display_header): Likewise.
1939 * widget.c (mark_shell_size_user_specified, create_frame_gcs):
1940 Likewise.
1941 * xdisp.c (check_it): Likewise.
1942 * xfaces.c (register_color, unregister_color, unregister_colors):
1943 Likewise.
1944 * xfns.c (print_fontset_result): Likewise.
1945 * xrdb.c (member, fatal, main): Likewise.
1946
99033785
PE
19472011-07-10 Paul Eggert <eggert@cs.ucla.edu>
1948
1949 Fix minor problems found by static checking (Bug#9031).
1950 * chartab.c (char_table_set_range, map_sub_char_table):
1951 Remove unused locals.
1952 (uniprop_table): Now static.
1953 * composite.c (_work_char): Remove unused static var.
1954
9cb2ac56
JB
19552011-07-09 Juanma Barranquero <lekktu@gmail.com>
1956
1957 * chartab.c (uniprop_table_uncompress): Remove unused local variable.
1958
f25661f0
JD
19592011-07-09 Jan Djärv <jan.h.d@swipnet.se>
1960
1961 * gtkutil.c (qttip_cb): Remove code without function.
1962
8278c4fe
EZ
19632011-07-09 Eli Zaretskii <eliz@gnu.org>
1964
1965 * w32.c (pthread_sigmask): New stub.
1966
1692ae2d 19672011-07-08 Paul Eggert <eggert@cs.ucla.edu>
123403e4 1968
8a6ebd58 1969 Use pthread_sigmask, not sigprocmask (Bug#9010).
123403e4
PE
1970 sigprocmask is portable only for single-threaded applications, and
1971 Emacs can be multi-threaded when it uses GTK.
1301ac26
PE
1972 * Makefile.in (LIB_PTHREAD_SIGMASK): New macro.
1973 (LIBES): Use it.
1974 * callproc.c (Fcall_process):
1975 * process.c (create_process):
1976 * sysdep.c (sys_sigblock, sys_sigunblock, sys_sigsetmask):
1977 Use pthread_sigmask, not sigprocmask.
123403e4 1978
1b854618
JD
19792011-07-08 Jan Djärv <jan.h.d@swipnet.se>
1980
1981 * gtkutil.c (qttip_cb): Set line wrap to FALSE for tooltip widget.
1982 (xg_prepare_tooltip): Revert text in x->ttip_lbl, margins was
1983 wrong (Bug#8591).
1984
3fe4b549
JD
19852011-07-08 Jan Djärv <jan.h.d@swipnet.se>
1986
0ce7e563
JD
1987 * gtkutil.c (xg_prepare_tooltip): Fix indentation and comment.
1988 Put text in x->ttip_lbl instead of gtk_tooltip_set_text (Bug#8591).
1989 (xg_hide_tooltip): Fix comment.
1990
3fe4b549
JD
1991 * nsterm.m (initFrameFromEmacs): Don't use ns_return_types
1992 in registerServicesMenuSendTypes.
1993 (validRequestorForSendType): Don't check ns_return_types.
1994
1995 * nsfns.m (Fx_open_connection): Put NSStringPboardType into
1996 ns_return_type.
1997
5df75e47
JR
19982011-07-08 Jason Rumney <jasonr@gnu.org>
1999
2000 * w32fns.c (w32_wnd_proc) [WM_TIMER, WM_SET_CURSOR]: Avoid using
2001 frame struct members of non-existent frames (Bug#6284).
2002
699c10bd
JD
20032011-07-08 Jan Djärv <jan.h.d@swipnet.se>
2004
4393663b
JD
2005 * nsterm.m (keyDown): Call to wantsToDelayTextChangeNotifications and
2006 variable firstTime not needed on OSX >= 10.6.
2007 (setPosition): setFloatValue:knobProportion: is deprecated on OSX
2008 >= 10.5. Use setKnobProportion, setDoubleValue.
2009
2010 * nsterm.h (MAC_OS_X_VERSION_10_3, MAC_OS_X_VERSION_10_4)
2011 (MAC_OS_X_VERSION_10_5): Define if not defined.
2012 (EmacsView, EmacsTooltip): Implements NSWindowDelegate on OSX >= 10.6.
2013 (EmacsMenu): Implements NSMenuDelegate on OSX >= 10.6.
2014 (EmacsToolbar): Implements NSToolbarDelegate on OSX >= 10.6.
2015
2016 * nsselect.m (ns_string_from_pasteboard): Don't use deprecated methods
2017 cString and lossyCString on OSX >= 10.4
2018
2019 * nsmenu.m (fillWithWidgetValue): Don't use depercated method
2020 sizeToFit on OSX >= 10.2.
2021
2022 * nsimage.m (allocInitFromFile): Don't use deprecated method
2023 bestRepresentationForDevice on OSX >= 10.6.
2024
2025 * nsfns.m (check_ns_display_info): Cast to long and use %ld in error
2026 to avoid warning.
2027
2028 * emacs.c: Declare unexec_init_emacs_zone.
2029
a63e0781
JD
2030 * nsgui.h: Fix compiler warning about gnulib redefining verify.
2031
699c10bd
JD
2032 * nsselect.m (ns_get_local_selection): Change to extern (Bug#8842).
2033
2034 * nsmenu.m (ns_update_menubar): Remove useless setDelegate call
2035 on svcsMenu (Bug#8842).
2036
2037 * nsfns.m (Fx_open_connection): Remove NSStringPboardType from
2038 ns_return_types.
2039 (Fns_list_services): Just return Qnil on 10.6, code not working there.
2040
2041 * nsterm.m (QUTF8_STRING): Declare.
2042 (initFrameFromEmacs): Call registerServicesMenuSendTypes.
2043 (validRequestorForSendType): Return type is (id).
2044 Change indexOfObjectIdenticalTo to indexOfObject.
2045 Check if we have local selection before returning self (Bug#8842).
2046 (writeSelectionToPasteboard): Put local selection into paste board
2047 if we have a local selection (Bug#8842).
2048 (syms_of_nsterm): DEFSYM QUTF8_STRING.
2049
2050 * nsterm.h (MAC_OS_X_VERSION_10_6): Define here instead of nsterm.m.
2051 (ns_get_local_selection): Declare.
2052
54e10184
LMI
20532011-07-07 Lars Magne Ingebrigtsen <larsi@gnus.org>
2054
9888ff71
LMI
2055 * keymap.c (describe_map_tree): Don't insert a double newline at
2056 the end of the buffer (bug#1169) and return whether we inserted
2057 something.
2058
54e10184
LMI
2059 * callint.c (Fcall_interactively): Change "reading args" to
2060 "providing args" to try to clarify what it does (bug#1010).
2061
15fa4783
KH
20622011-07-07 Kenichi Handa <handa@m17n.org>
2063
2064 * composite.c (composition_compute_stop_pos): Ignore a static
2065 composition starting before CHARPOS (Bug#8915).
2066
2067 * xdisp.c (handle_composition_prop): Likewise.
2068
a8815b00
EZ
20692011-07-07 Eli Zaretskii <eliz@gnu.org>
2070
2071 * term.c (produce_glyphs) <xassert>: Allow IT_GLYPHLESS in it->what.
2072 (Bug#9015)
2073
ef7b981d 20742011-07-07 Kenichi Handa <handa@m17n.org>
c805dec0
KH
2075
2076 * character.h (unicode_category_t): New enum type.
2077
2078 * chartab.c (uniprop_decoder_t, uniprop_encoder_t): New types.
2079 (Qchar_code_property_table): New variable.
2080 (UNIPROP_TABLE_P, UNIPROP_GET_DECODER)
2081 (UNIPROP_COMPRESSED_FORM_P): New macros.
2082 (char_table_ascii): Uncompress the compressed values.
2083 (sub_char_table_ref): New arg is_uniprop. Callers changed.
2084 Uncompress the compressed values.
ac389d0c 2085 (sub_char_table_ref_and_range): Likewise.
c805dec0
KH
2086 (char_table_ref_and_range): Uncompress the compressed values.
2087 (sub_char_table_set): New arg is_uniprop. Callers changed.
2088 Uncompress the compressed values.
2089 (sub_char_table_set_range): Args changed. Callers changed.
2090 (char_table_set_range): Adjuted for the above change.
2091 (map_sub_char_table): Delete args default_val and parent. Add arg
2092 top. Give decoded values to a Lisp function.
640c8776 2093 (map_char_table): Adjust for the above change. Give decoded
c805dec0
KH
2094 values to a Lisp function. Gcpro more variables.
2095 (uniprop_table_uncompress)
2096 (uniprop_decode_value_run_length): New functions.
2097 (uniprop_decoder, uniprop_decoder_count): New variables.
2098 (uniprop_get_decoder, uniprop_encode_value_character)
2099 (uniprop_encode_value_run_length, uniprop_encode_value_numeric):
2100 New functions.
2101 (uniprop_encoder, uniprop_encoder_count): New variables.
2102 (uniprop_get_encoder, uniprop_table)
2103 (Funicode_property_table_internal, Fget_unicode_property_internal)
2104 (Fput_unicode_property_internal): New functions.
2105 (syms_of_chartab): DEFSYM Qchar_code_property_table, defsubr
2106 Sunicode_property_table_internal, Sget_unicode_property_internal,
5e617bc2 2107 and Sput_unicode_property_internal. Defvar_lisp
c805dec0
KH
2108 char-code-property-alist.
2109
640c8776 2110 * composite.c (CHAR_COMPOSABLE_P): Adjust for the change of
c805dec0
KH
2111 Vunicode_category_table.
2112
640c8776 2113 * font.c (font_range): Adjust for the change of
c805dec0
KH
2114 Vunicode_category_table.
2115
76b397fb
DN
21162011-07-07 Dan Nicolaescu <dann@ics.uci.edu>
2117
2118 * m/iris4d.h: Remove file, move contents ...
2119 * s/irix6-5.h: ... here.
2120
22b4128e
PE
21212011-07-06 Paul Eggert <eggert@cs.ucla.edu>
2122
2123 Remove unportable assumption about struct layout (Bug#8884).
8a5c77bb
PE
2124 * alloc.c (mark_buffer):
2125 * buffer.c (reset_buffer_local_variables, Fbuffer_local_variables)
2126 (clone_per_buffer_values): Don't assume that
22b4128e
PE
2127 sizeof (struct buffer) is a multiple of sizeof (Lisp_Object).
2128 This isn't true in general, and it's particularly not true
2129 if Emacs is configured with --with-wide-int.
2130 * buffer.h (FIRST_FIELD_PER_BUFFER, LAST_FIELD_PER_BUFFER):
2131 New macros, used in the buffer.c change.
2132
869795d6
JD
21332011-07-05 Jan Djärv <jan.h.d@swipnet.se>
2134
2135 * xsettings.c: Use both GConf and GSettings if both are available.
2136 (store_config_changed_event): Add comment.
2137 (dpyinfo_valid, store_font_name_changed, map_tool_bar_style)
2138 (store_tool_bar_style_changed): New functions.
5e617bc2 2139 (store_monospaced_changed): Add comment. Call dpyinfo_valid.
869795d6
JD
2140 (struct xsettings): Move font inside HAVE_XFT.
2141 (GSETTINGS_TOOL_BAR_STYLE, GSETTINGS_FONT_NAME): New defines.
640c8776 2142 (GSETTINGS_MONO_FONT): Rename from SYSTEM_MONO_FONT.
869795d6 2143 Move inside HAVE_XFT.
640c8776 2144 (something_changed_gsettingsCB): Rename from something_changedCB.
869795d6
JD
2145 Check for changes in GSETTINGS_TOOL_BAR_STYLE and GSETTINGS_FONT_NAME
2146 also.
2147 (GCONF_TOOL_BAR_STYLE, GCONF_FONT_NAME): New defines.
5e617bc2 2148 (GCONF_MONO_FONT): Rename from SYSTEM_MONO_FONT. Move inside HAVE_XFT.
640c8776 2149 (something_changed_gconfCB): Rename from something_changedCB.
869795d6
JD
2150 Check for changes in GCONF_TOOL_BAR_STYLE and GCONF_FONT_NAME also.
2151 (parse_settings): Move check for font inside HAVE_XFT.
2152 (read_settings, apply_xft_settings): Add comment.
2153 (read_and_apply_settings): Add comment. Call map_tool_bar_style and
2154 store_tool_bar_style_changed. Move check for font inside HAVE_XFT and
2155 call store_font_name_changed.
2156 (xft_settings_event): Add comment.
2157 (init_gsettings): Add comment. Get values for GSETTINGS_TOOL_BAR_STYLE
2158 and GSETTINGS_FONT_NAME. Move check for fonts within HAVE_XFT.
2159 (init_gconf): Add comment. Get values for GCONF_TOOL_BAR_STYLE
2160 and GCONF_FONT_NAME. Move check for fonts within HAVE_XFT.
2161 (xsettings_initialize): Call init_gsettings last.
640c8776
SM
2162 (xsettings_get_system_font, xsettings_get_system_normal_font):
2163 Add comment.
869795d6 2164
d8ed26bd
PE
21652011-07-05 Paul Eggert <eggert@cs.ucla.edu>
2166
2167 Random fixes. E.g., (random) never returned negative values.
2168 * fns.c (Frandom): Use GET_EMACS_TIME for random seed, and add the
2169 subseconds part to the entropy, as that's a bit more random.
2170 Prefer signed to unsigned, since the signedness doesn't matter and
2171 in general we prefer signed. When given a limit, use a
2172 denominator equal to INTMASK + 1, not to VALMASK + 1, because the
2173 latter isn't right if USE_2_TAGS_FOR_INTS.
2174 * sysdep.c (get_random): Return a value in the range 0..INTMASK,
2175 not 0..VALMASK. Don't discard "excess" bits that random () returns.
2176
cabf1cac
SM
21772011-07-04 Stefan Monnier <monnier@iro.umontreal.ca>
2178
2179 * textprop.c (text_property_stickiness):
2180 Obey Vtext_property_default_nonsticky.
2181 (syms_of_textprop): Add `display' to Vtext_property_default_nonsticky.
2182 * w32fns.c (syms_of_w32fns):
2183 * xfns.c (syms_of_xfns): Don't Add `display' since it's there by default.
2184
6e9b2be9
PE
21852011-07-04 Paul Eggert <eggert@cs.ucla.edu>
2186
2187 * fileio.c (barf_or_query_if_file_exists): Use S_ISDIR.
2188 This is more efficient than Ffile_directory_p and avoids a minor race.
2189
90186c68
LMI
21902011-07-04 Lars Magne Ingebrigtsen <larsi@gnus.org>
2191
7c301272
LMI
2192 * buffer.c (Foverlay_put): Say what the return value is
2193 (bug#7835).
2194
c4f2d8d4
LMI
2195 * fileio.c (barf_or_query_if_file_exists): Check first if the file
2196 is a directory before asking whether to use the file name
2197 (bug#7564).
ad637907
LMI
2198 (barf_or_query_if_file_exists): Make the "File is a directory"
2199 error be more correct.
c4f2d8d4 2200
90186c68
LMI
2201 * fns.c (Frequire): Remove the mention of the .gz files, since
2202 that's installation-specific, but keep the mention of
2203 `get-load-suffixes'.
2204
da64016e
PE
22052011-07-04 Paul Eggert <eggert@cs.ucla.edu>
2206
2207 * editfns.c (Fformat_time_string): Don't assume strlen fits in int.
2208 Report string overflow if the output is too long.
2209
7d47b580
JB
22102011-07-04 Juanma Barranquero <lekktu@gmail.com>
2211
a555cb87
JB
2212 * gnutls.c (Fgnutls_boot): Don't mention :verify-error.
2213 (syms_of_gnutls): Remove duplicate DEFSYM for
2214 Qgnutls_bootprop_verify_hostname_error, an error for
2215 Qgnutls_bootprop_verify_error (which is no longer used).
2216
7d47b580
JB
2217 * eval.c (find_handler_clause): Remove parameters `sig' and `data',
2218 unused since 2011-01-26T20:02:07Z!monnier@iro.umontreal.ca. All callers changed.
2219 Also (re)move comments that are misplaced or no longer relevant.
2220
1e49bfab
LMI
22212011-07-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
2222
2223 * callint.c (Finteractive): Clarify the meaning of "@" (bug#8813).
2224
1485f4c0
CY
22252011-07-03 Chong Yidong <cyd@stupidchicken.com>
2226
2227 * xfaces.c (Finternal_merge_in_global_face): Modify the foreground
2228 and background color parameters if they have been changed.
2229
a9ab721e
LMI
22302011-07-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
2231
2232 * editfns.c (Fformat): Clarify the - and 0 flags (bug#6659).
2233
cf7cff57
PE
22342011-07-03 Paul Eggert <eggert@cs.ucla.edu>
2235
2e13213d
PE
2236 * xsettings.c (SYSTEM_FONT): Define only when used.
2237 No need to define when HAVE_GSETTINGS || !HAVE_XFT.
2238
cf7cff57
PE
2239 * keymap.c (access_keymap_1): Now static.
2240
7a8e04f7
CY
22412011-07-02 Chong Yidong <cyd@stupidchicken.com>
2242
2243 * keyboard.c (command_loop_1): If a down-mouse event is unbound,
2244 leave any prefix arg for the up event (Bug#1586).
2245
61352f62
LMI
22462011-07-02 Lars Magne Ingebrigtsen <larsi@gnus.org>
2247
69bb1ef7
LMI
2248 * lread.c (syms_of_lread): Mention single symbols defined by
2249 `defvar' or `defconst' (bug#7154).
2250
61352f62 2251 * fns.c (Frequire): Mention .el.gz files (bug#7314).
7b3747f9 2252 (Frequire): Mention get-load-suffixes.
61352f62 2253
28545e04
MR
22542011-07-02 Martin Rudalics <rudalics@gmx.at>
2255
2256 * window.h (window): Remove clone_number slot.
2257 * window.c (Fwindow_clone_number, Fset_window_clone_number):
2258 Remove.
2259 (make_parent_window, make_window, saved_window)
2260 (Fset_window_configuration, save_window_save): Don't deal with
2261 clone numbers.
2262 * buffer.c (Qclone_number): Remove declaration.
2263 (sort_overlays, overlay_strings): Don't deal with clone numbers.
2264
3349e122
SM
22652011-07-02 Stefan Monnier <monnier@iro.umontreal.ca>
2266
2267 Add multiple inheritance to keymaps.
2268 * keymap.c (Fmake_composed_keymap): New function.
2269 (Fset_keymap_parent): Simplify.
2270 (fix_submap_inheritance): Remove.
2271 (access_keymap_1): New function extracted from access_keymap to handle
2272 embedded parents and handle lists of maps.
2273 (access_keymap): Use it.
2274 (Fkeymap_prompt, map_keymap_internal, map_keymap, store_in_keymap)
2275 (Fcopy_keymap): Handle embedded parents.
2276 (Fcommand_remapping, define_as_prefix): Simplify.
2277 (Fkey_binding): Simplify.
2278 (syms_of_keymap): Move minibuffer-local-completion-map,
2279 minibuffer-local-filename-completion-map,
2280 minibuffer-local-must-match-map, and
2281 minibuffer-local-filename-must-match-map to Elisp.
2282 (syms_of_keymap): Defsubr make-composed-keymap.
2283 * keyboard.c (menu_bar_items): Use map_keymap_canonical.
2284 (parse_menu_item): Trivial simplification.
2285
3279eb87
GM
22862011-07-01 Glenn Morris <rgm@gnu.org>
2287
2288 * Makefile.in (SETTINGS_LIBS): Fix typo.
2289
4550efdf
KI
22902011-07-01 Kazuhiro Ito <kzhr@d1.dion.ne.jp> (tiny patch)
2291
2292 * coding.c (Fencode_coding_string): Record the last coding system
2293 used, as the function doc string says (bug#8738).
2294
0949d2b6
JD
22952011-07-01 Jan Djärv <jan.h.d@swipnet.se>
2296
2297 * xsettings.c (store_monospaced_changed): Take new font as arg and
2298 check for change against current_mono_font.
2299 (EMACS_TYPE_SETTINGS): Remove this and related defines.
2300 (emacs_settings_constructor, emacs_settings_get_property)
2301 (emacs_settings_set_property, emacs_settings_class_init)
2302 (emacs_settings_init, gsettings_obj): Remove.
2303 (something_changedCB): New function for HAVE_GSETTINGS.
2304 (something_changedCB): HAVE_GCONF: Call store_monospaced_changed
2305 with value as argument.
2306 (init_gsettings): Check that GSETTINGS_SCHEMA exists before calling
2307 g_settings_new (Bug#8967). Do not create gsettings_obj.
9173deec 2308 Remove calls to g_settings_bind. Connect something_changedCB to
0949d2b6
JD
2309 "changed".
2310
2311 * xgselect.c: Add defined (HAVE_GSETTINGS).
2312 (xgselect_initialize): Ditto.
2313
2314 * process.c: Add defined (HAVE_GSETTINGS) for xgselect.h
2315 (wait_reading_process_output): Add defined (HAVE_GSETTINGS) for
2316 xg_select.
2317
bbc6b304
PE
23182011-07-01 Paul Eggert <eggert@cs.ucla.edu>
2319
2320 * eval.c (struct backtrace): Simplify and port the data structure.
2321 Do not assume that "int nargs : BITS_PER_INT - 2;" produces a
2322 signed bit field, as this assumption is not portable and it makes
2323 Emacs crash when compiled with Sun C 5.8 on sparc. Do not use
2324 "char debug_on_exit : 1" as this is not portable either; instead,
2325 use the portable "unsigned int debug_on_exit : 1". Remove unused
2326 member evalargs. Remove obsolete comments about cc bombing out.
2327
9851bfc5
JD
23282011-06-30 Jan Djärv <jan.h.d@swipnet.se>
2329
51bb811f 2330 * xsettings.c: Include glib-object.h, gio/gio.h if HAVE_GSETTINGS.
9851bfc5
JD
2331 Let HAVE_GSETTINGS override HAVE_GCONF.
2332 (store_monospaced_changed): New function.
2333 (EMACS_SETTINGS): A new type derived from GObject to handle
2334 GSettings notifications.
2335 (emacs_settings_constructor, emacs_settings_get_property)
2336 (emacs_settings_set_property, emacs_settings_class_init):
2337 New functions.
2338 (gsettings_client, gsettings_obj): New variables.
2339 (GSETTINGS_SCHEMA): New define.
2340 (something_changedCB): Call store_monospaced_changed.
2341 (init_gsettings): New function.
2342 (xsettings_initialize): Call init_gsettings.
2343 (syms_of_xsettings): Initialize gsettings_client, gsettings_obj
2344 to NULL.
2345
640c8776 2346 * Makefile.in (SETTINGS_CFLAGS, SETTINGS_LIBS): Rename from
9851bfc5
JD
2347 GCONF_CFLAGS/LIBS.
2348
5386012d
MR
23492011-06-29 Martin Rudalics <rudalics@gmx.at>
2350
2351 * window.c (resize_root_window, grow_mini_window)
2352 (shrink_mini_window): Rename Qresize_root_window to
2353 Qwindow_resize_root_window and Qresize_root_window_vertically to
2354 Qwindow_resize_root_window_vertically.
2355
f13e0b08
PE
23562011-06-28 Paul Eggert <eggert@cs.ucla.edu>
2357
2358 * gnutls.c (Qgnutls_bootprop_verify_error): Remove unused var.
2359
94515237
JB
23602011-06-27 Juanma Barranquero <lekktu@gmail.com>
2361
2362 * makefile.w32-in: Redesign dependencies so they reflect more
2363 clearly which files are directly included by each source file,
2364 and not through other includes.
2365
e43b6e43
MR
23662011-06-27 Martin Rudalics <rudalics@gmx.at>
2367
2368 * buffer.c (Qclone_number): Declare static and DEFSYM it.
2369 (sort_overlays, overlay_strings): When an overlay's clone number
2370 matches the window's clone number process the overlay even if
2371 the overlay's window property doesn't match the current window.
2372
d68443dc
MR
2373 * window.c (Fwindow_vchild): Rename to Fwindow_top_child.
2374 (Fwindow_hchild): Rename to Fwindow_left_child.
2375 (Fwindow_next): Rename to Fwindow_next_sibling.
2376 (Fwindow_prev): Rename to Fwindow_prev_sibling.
d615d6d2
MR
2377 (resize_window_check): Rename to window_resize_check.
2378 (resize_window_apply): Rename to window_resize_apply.
2379 (Fresize_window_apply): Rename to Fwindow_resize_apply.
2380 (Fdelete_other_windows_internal, resize_frame_windows)
2381 (Fsplit_window_internal, Fdelete_window_internal)
2382 (grow_mini_window, shrink_mini_window)
2383 (Fresize_mini_window_internal): Fix callers accordingly.
d68443dc 2384
c7e73be5
JD
23852011-06-26 Jan Djärv <jan.h.d@swipnet.se>
2386
2387 * emacsgtkfixed.h: State that this is only used with Gtk+3.
2388 (emacs_fixed_set_min_size): Remove.
2389 (emacs_fixed_new): Take frame as argument.
2390
2391 * emacsgtkfixed.c: State that this is only used with Gtk+3.
2392 (_EmacsFixedPrivate): Remove minwidth/height.
2393 Add struct frame *f.
2394 (emacs_fixed_init): Initialize priv->f.
2395 (get_parent_class, emacs_fixed_set_min_size): Remove.
2396 (emacs_fixed_new): Set priv->f to argument.
2397 (emacs_fixed_get_preferred_width)
2398 (emacs_fixed_get_preferred_height): Use min_width/height from
2399 frames size_hint to set minimum and natural (Bug#8919).
2400 (XSetWMSizeHints, XSetWMNormalHints): Override these functions
2401 and use min_width/height from frames size_hint to set
2402 min_width/height (Bug#8919).
2403
2404 * gtkutil.c (xg_create_frame_widgets): Pass f to emacs_fixed_new.
9173deec
JB
2405 (x_wm_set_size_hint): Remove call to emacs_fixed_set_min_size.
2406 Fix indentation.
c7e73be5 2407
cf99dcf8
EZ
24082011-06-26 Eli Zaretskii <eliz@gnu.org>
2409
2410 * bidi.c (bidi_paragraph_init): Test for ZV_BYTE before calling
2411 bidi_at_paragraph_end, since fast_looking_at doesn't like to be
2412 called at ZV.
2413
029529ac
CY
24142011-06-26 Chong Yidong <cyd@stupidchicken.com>
2415
2416 * process.c (wait_reading_process_output): Bypass select if
2417 waiting for a cell while ignoring keyboard input, and input is
2418 pending. Suggested by Jan Djärv (Bug#8869).
2419
7a7ef429
PE
24202011-06-25 Paul Eggert <eggert@cs.ucla.edu>
2421
2422 Use gnulib's dup2 module instead of rolling our own.
2423 * sysdep.c (dup2) [!HAVE_DUP2]: Remove; gnulib now does this.
2424
11fdef7d 24252011-06-25 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
989b42d2
YM
2426
2427 * dispnew.c (scrolling_window): Before scrolling, turn off a
2428 mouse-highlight in the window being scrolled.
2429
cd3520a4
JB
24302011-06-24 Juanma Barranquero <lekktu@gmail.com>
2431
2432 Move DEFSYM to lisp.h and use everywhere.
2433
2434 * character.h (DEFSYM): Move declaration...
2435 * lisp.h (DEFSYM): ...here.
2436
2437 * gnutls.c:
2438 * minibuf.c:
2439 * w32menu.c:
2440 * w32proc.c:
2441 * w32select.c: Don't include character.h.
2442
2443 * alloc.c (syms_of_alloc):
2444 * buffer.c (syms_of_buffer):
2445 * bytecode.c (syms_of_bytecode):
2446 * callint.c (syms_of_callint):
2447 * casefiddle.c (syms_of_casefiddle):
2448 * casetab.c (init_casetab_once):
2449 * category.c (init_category_once, syms_of_category):
2450 * ccl.c (syms_of_ccl):
2451 * cmds.c (syms_of_cmds):
2452 * composite.c (syms_of_composite):
2453 * dbusbind.c (syms_of_dbusbind):
2454 * dired.c (syms_of_dired):
2455 * dispnew.c (syms_of_display):
2456 * doc.c (syms_of_doc):
2457 * editfns.c (syms_of_editfns):
2458 * emacs.c (syms_of_emacs):
2459 * eval.c (syms_of_eval):
2460 * fileio.c (syms_of_fileio):
2461 * fns.c (syms_of_fns):
2462 * frame.c (syms_of_frame):
2463 * fringe.c (syms_of_fringe):
2464 * insdel.c (syms_of_insdel):
2465 * keymap.c (syms_of_keymap):
2466 * lread.c (init_obarray, syms_of_lread):
2467 * macros.c (syms_of_macros):
2468 * msdos.c (syms_of_msdos):
2469 * print.c (syms_of_print):
2470 * process.c (syms_of_process):
2471 * search.c (syms_of_search):
2472 * sound.c (syms_of_sound):
2473 * syntax.c (init_syntax_once, syms_of_syntax):
2474 * terminal.c (syms_of_terminal):
2475 * textprop.c (syms_of_textprop):
2476 * undo.c (syms_of_undo):
2477 * w32.c (globals_of_w32):
2478 * window.c (syms_of_window):
2479 * xdisp.c (syms_of_xdisp):
2480 * xfaces.c (syms_of_xfaces):
2481 * xfns.c (syms_of_xfns):
2482 * xmenu.c (syms_of_xmenu):
2483 * xsettings.c (syms_of_xsettings):
2484 * xterm.c (syms_of_xterm): Use DEFSYM.
2485
4228cf16
TZ
24862011-06-24 Teodor Zlatanov <tzz@lifelogs.com>
2487
cd3520a4 2488 * gnutls.c (syms_of_gnutls): Use the DEFSYM macro from character.h.
4228cf16 2489
7fcccf1e
PE
24902011-06-23 Paul Eggert <eggert@cs.ucla.edu>
2491
7efb4e0e
PE
2492 Integer and buffer overflow fixes (Bug#8873).
2493
ff5844ad
PE
2494 * print.c (printchar, strout): Check for string overflow.
2495 (PRINTPREPARE, printchar, strout):
2496 Don't set size unless allocation succeeds.
2497
90532f02
PE
2498 * minibuf.c (read_minibuf_noninteractive): Use ptrdiff_t, not int,
2499 for sizes. Check for string overflow more accurately.
2500 Simplify newline removal at end; this suppresses a GCC 4.6.0 warning.
2501
6d84508d
PE
2502 * macros.c: Integer and buffer overflow fixes.
2503 * keyboard.h (struct keyboard.kbd_macro_bufsize):
2504 * macros.c (Fstart_kbd_macro, store_kbd_macro_char):
2505 Use ptrdiff_t, not int, for sizes.
2506 Don't increment bufsize until after realloc succeeds.
2507 Check for size-calculation overflow.
2508 (Fstart_kbd_macro): Use EMACS_INT, not int, for XINT result.
2509
437b2cb4
PE
2510 * lisp.h (DEFVAR_KBOARD): Use offsetof instead of char * finagling.
2511
8b9ac8b4
PE
2512 * lread.c: Integer overflow fixes.
2513 (read_integer): Radix is now EMACS_INT, not int,
2514 to improve quality of diagnostics for out-of-range radices.
2515 Calculate buffer size correctly for out-of-range radices.
2516 (read1): Check for integer overflow in radices, and in
2517 read-circle numbers.
82cb60d3
PE
2518 (read_escape): Avoid int overflow.
2519 (Fload, openp, read_buffer_size, read1)
2520 (substitute_object_recurse, read_vector, read_list, map_obarray):
2521 Use ptrdiff_t, not int, for sizes.
2522 (read1): Use EMACS_INT, not int, for sizes.
20270765 2523 Check for size overflow.
8b9ac8b4 2524
7fcccf1e
PE
2525 * image.c (cache_image): Check for size arithmetic overflow.
2526
bfbbd7e7
PE
2527 * lread.c: Integer overflow issues.
2528 (saved_doc_string_size, saved_doc_string_length)
2529 (prev_saved_doc_string_size, prev_saved_doc_string_length):
2530 Now ptrdiff_t, not int.
2531 (read1): Don't assume doc string length fits in int. Check for
2532 out-of-range doc string lengths.
2533 (read_list): Don't assume file position fits in int.
39019e54 2534 (read_escape): Check for hex character overflow.
bfbbd7e7 2535
4e323265
LL
25362011-06-22 Leo Liu <sdl.web@gmail.com>
2537
2538 * minibuf.c (Fcompleting_read_default, Vcompleting_read_function):
2539 Move to minibuffer.el.
2540
85fece3e
PE
25412011-06-22 Paul Eggert <eggert@cs.ucla.edu>
2542
20b84ce9 2543 Fixes for GLYPH_DEBUG found by GCC 4.6.0 static checking.
85fece3e
PE
2544 The following patches are for when GLYPH_DEBUG && !XASSERT.
2545 * dispextern.h (trace_redisplay_p, dump_glyph_string):
2546 * dispnew.c (flush_stdout):
2547 * xdisp.c (dump_glyph_row, dump_glyph_matrix, dump_glyph):
2548 Mark as externally visible.
2549 * dispnew.c (check_window_matrix_pointers): Now static.
2550 * dispnew.c (window_to_frame_vpos):
2551 * xfns.c (unwind_create_frame):
2552 * xterm.c (x_check_font): Remove unused local.
2553 * scroll.c (CHECK_BOUNDS):
2554 * xfaces.c (cache_fache): Rename local to avoid shadowing.
2555 * xfns.c, w32fns.c (image_cache_refcount, dpyinfo_refcount): Now static.
2556 * xdisp.c (check_window_end): Now a no-op if !XASSERTS.
2557 (debug_first_unchanged_at_end_vpos, debug_last_unchanged_at_beg_vpos)
2558 (debug_dvpos, debug_dy, debug_delta, debug_delta_bytes, debug_end_vpos):
2559 Now static.
2560 (debug_method_add): Use va_list and vsprintf rather than relying
2561 on undefined behavior with wrong number of arguments.
2562 (dump_glyph, dump_glyph_row, Fdump_glyph_matrix):
2563 Don't assume ptrdiff_t and EMACS_INT are the same width as int.
2564 In this code, it's OK to assume C99 behavior for ptrdiff_t formats
2565 since we're not interested in debugging glyphs with old libraries.
2566 * xfaces.c (cache_face): Move debugging code earlier; this pacifies
2567 GCC 4.6.0's static checking.
2568
0766b489
PE
25692011-06-22 Paul Eggert <eggert@cs.ucla.edu>
2570
31fd4b32
PE
2571 Integer overflow and signedness fixes (Bug#8873).
2572 A few related buffer overrun fixes, too.
2573
b79e8648
PE
2574 * font.c (font_score): Use EMACS_INT, not int, to store XINT value.
2575
0766b489
PE
2576 * dispextern.h (struct face.stipple):
2577 * image.c (x_bitmap_height, x_bitmap_width, x_bitmap_pixmap)
2578 (x_bitmap_mask, x_allocate_bitmap_record)
2579 (x_create_bitmap_from_data, x_create_bitmap_from_file)
2580 (x_destroy_bitmap, x_destroy_all_bitmaps, x_create_bitmap_mask)
2581 (x_create_bitmap_from_xpm_data):
2582 * nsterm.h (struct ns_display_info.bitmaps_size, .bitmaps_last):
2583 * w32term.h (struct w32_display_info.icon_bitmap_id, .bitmaps_size)
2584 (.bitmaps_last):
2585 * xfaces.c (load_pixmap):
2586 * xterm.c (x_bitmap_icon, x_wm_set_icon_pixmap):
2587 * xterm.h (struct x_display_info.icon_bitmap_id, .bitmaps_size)
2588 (.bitmaps_last, struct x_output.icon_bitmap):
2589 Use ptrdiff_t, not int, for bitmap indexes.
2590 (x_allocate_bitmap_record): Check for size overflow.
2591 * dispextern.h, lisp.h: Adjust to API changes elsewhere.
2592
b081724f
PE
2593 Use ptrdiff_t, not int, for overlay counts.
2594 * buffer.h (overlays_at, sort_overlays, GET_OVERLAYS_AT):
2595 * editfns.c (overlays_around, get_pos_property):
2596 * textprop.c (get_char_property_and_overlay):
2597 * xdisp.c (next_overlay_change, note_mouse_highlight):
2598 * xfaces.c (face_at_buffer_position):
21514da7
PE
2599 * buffer.c (OVERLAY_COUNT_MAX): New macro.
2600 (overlays_at, overlays_in, sort_overlays, Foverlays_at)
2601 (Fnext_overlay_change, Fprevious_overlay_change)
2602 (mouse_face_overlay_overlaps, Foverlays_in):
b081724f 2603 Use ptrdiff_t, not int, for sizes.
21514da7 2604 (overlays_at, overlays_in): Check for size-calculation overflow.
b081724f 2605
3de73e5e
PE
2606 * xterm.c (xim_initialize, same_x_server): Strlen may not fit in int.
2607
2606c57b
PE
2608 * xsmfns.c (smc_save_yourself_CB, x_session_initialize): Avoid strlen.
2609 (x_session_initialize): Do not assume string length fits in int.
2610
aaafe47a
PE
2611 * xsettings.c (apply_xft_settings): Fix potential buffer overrun.
2612 This is unlikely, but can occur if DPI is outlandish.
2613
2674ddc8 2614 * xsettings.c (Ffont_get_system_normal_font, Ffont_get_system_font):
3a5077c5
PE
2615 * xselect.c (Fx_get_atom_name): Avoid need for strlen.
2616
28154962
PE
2617 * xrdb.c: Don't assume strlen fits in int; avoid some strlens.
2618 * xrdb.c (magic_file_p, search_magic_path):
2619 Omit last arg SUFFIX; it was always 0. All callers changed.
2620 (magic_file_p): Use ptrdiff_t, not int. Check for size overflow.
2621
7de51af5
PE
2622 * xfont.c (xfont_match): Avoid need for strlen.
2623
25ed6cc3
PE
2624 * xfns.c: Don't assume strlen fits in int.
2625 (xic_create_fontsetname, x_window): Use ptrdiff_t, not int.
2626
4eab31dd
PE
2627 * xdisp.c (message_log_check_duplicate): Return intmax_t,
2628 not unsigned long, as we prefer signed integers. All callers changed.
2629 Detect integer overflow in repeat count.
2630 (message_dolog): Don't assume print length fits in 39 bytes.
df1f27af 2631 (display_mode_element): Don't assume strlen fits in int.
4eab31dd 2632
171e2a58
PE
2633 * termcap.c: Don't assume sizes fit in int and never overflow.
2634 (struct termcap_buffer, tgetent): Use ptrdiff_t, not int, for sizes.
2635 (gobble_line): Check for size-calculation overflow.
2636
ad39faca 2637 * minibuf.c (Fread_buffer):
6e5bb2dc 2638 * lread.c (intern, intern_c_string):
74ca2eb3
PE
2639 * image.c (xpm_scan) [HAVE_NS && !HAVE_XPM]:
2640 Don't assume string length fits in int.
2641
52c61c22 2642 * keyboard.c (parse_tool_bar_item):
9bda3520
PE
2643 * gtkutil.c (style_changed_cb): Avoid need for strlen.
2644
b5b8c9e5
PE
2645 * font.c: Don't assume string length fits in int.
2646 (font_parse_xlfd, font_parse_fcname, font_unparse_fcname):
2647 Use ptrdiff_t, not int.
ccd6111c
PE
2648 (font_intern_prop): Don't assume string length fits in int.
2649 Don't assume integer property fits in fixnum.
2650 * font.h (font_intern_prop): 2nd arg is now ptrdiff_t, not int.
b5b8c9e5 2651
882f0d81 2652 * filelock.c: Fix some buffer overrun and integer overflow issues.
51cab52b 2653 (get_boot_time): Don't assume gzip command string fits in 100 bytes.
882f0d81
PE
2654 Reformulate so as not to need the command string.
2655 Invoke gzip -cd rather than gunzip, as it's more portable.
2656 (lock_info_type, lock_file_1, lock_file):
2657 Don't assume pid_t and time_t fit in unsigned long.
2658 (LOCK_PID_MAX): Remove; we now use more-reliable bounds.
2659 (current_lock_owner): Prefer signed type for sizes.
2660 Use memcpy, not strncpy, where memcpy is what is really wanted.
2661 Don't assume (via atoi) that time_t and pid_t fit in int.
2662 Check for time_t and/or pid_t out of range, e.g., via a network share.
2663 Don't alloca where an auto var works fine.
2664
93f4cf88
PE
2665 * fileio.c: Fix some integer overflow issues.
2666 (file_name_as_directory, Fexpand_file_name, Fsubstitute_in_file_name):
2667 Don't assume string length fits in int.
2668 (directory_file_name): Don't assume string length fits in long.
2669 (make_temp_name): Don't assume pid fits in int, or that its print
2670 length is less than 20.
2671
f3e92b69
PE
2672 * data.c (Fsubr_name): Rewrite to avoid a strlen call.
2673
1bfdaf10
PE
2674 * coding.c (make_subsidiaries): Don't assume string length fits in int.
2675
35016e9a
PE
2676 * callproc.c (child_setup): Rewrite to avoid two strlen calls.
2677
3d1e65a1
PE
2678 * process.c (Fformat_network_address): Use EMACS_INT, not EMACS_UINT.
2679 We prefer signed integers, even for size calculations.
2680
0b963a93
PE
2681 * emacs.c: Don't assume string length fits in 'int'.
2682 (DEFINE_DUMMY_FUNCTION, sort_args): Use ptrdiff_t, not int.
2683 (main): Don't invoke strlen when not needed.
2684
573f4b54
PE
2685 * dbusbind.c (XD_ERROR): Don't arbitrarily truncate string.
2686 (XD_DEBUG_MESSAGE): Don't waste a byte.
2687
989f33ba
PE
2688 * callproc.c (getenv_internal_1, getenv_internal)
2689 (Fgetenv_internal):
965d34eb
PE
2690 * buffer.c (init_buffer): Don't assume string length fits in 'int'.
2691
e4d29b33
PE
2692 * lread.c (invalid_syntax): Omit length argument.
2693 All uses changed. This doesn't fix a bug, but it simplifies the
2694 code away from its former Hollerith-constant appearance, and it's
2695 one less 'int' to worry about when looking at integer-overflow issues.
51cab52b 2696 (string_to_number): Simplify 2011-04-26 change by invoking xsignal1.
e4d29b33 2697
eb49b136
PE
2698 * lisp.h (DEFUN): Remove bogus use of sizeof (struct Lisp_Subr).
2699 This didn't break anything, but it didn't help either.
2700 It's confusing to put a bogus integer in a place where the actual
2701 value does not matter.
9f62aeb1 2702 (LIST_END_P): Remove unused macro and its bogus comment.
cbeff735 2703 (make_fixnum_or_float): Remove unnecessary cast to EMACS_INT.
eb49b136 2704
15375a22
PE
2705 * lisp.h (union Lisp_Object.i): EMACS_INT, not EMACS_UINT.
2706 This is for consistency with the ordinary, non-USE_LISP_UNION_TYPE,
2707 implementation.
b61cc01c
PE
2708 (struct Lisp_Bool_Vector.size): EMACS_INT, not EMACS_UINT.
2709 We prefer signed types, and the value cannot exceed the EMACS_INT
2710 range anyway (because otherwise the length would not be representable).
9a8e8d9b
PE
2711 (XSET) [USE_LISP_UNION_TYPE]: Use uintptr_t and intptr_t,
2712 not EMACS_UINT and EMACS_INT, when converting pointer to integer.
2713 This avoids a GCC warning when WIDE_EMACS_INT.
15375a22 2714
53b2623d
PE
2715 * indent.c (sane_tab_width): New function.
2716 (current_column, scan_for_column, Findent_to, position_indentation)
2717 (compute_motion): Use it. This is just for clarity.
8fcaf9cc 2718 (Fcompute_motion): Don't assume hscroll and tab offset fit in int.
53b2623d 2719
51cab52b 2720 * image.c (xbm_image_p): Don't assume stated width, height fit in int.
45aebb64 2721
f2ed8a70
PE
2722 * lisp.h (lint_assume): New macro.
2723 * composite.c (composition_gstring_put_cache):
2724 * ftfont.c (ftfont_shape_by_flt): Use it to pacify GCC 4.6.0.
2725
abe80cc6
PE
2726 * editfns.c, insdel.c:
2727 Omit unnecessary forward decls, to simplify future changes.
a9e860e1 2728
b02c740e
PE
2729 * ftfont.c (ftfont_shape_by_flt): Use signed integers for lengths.
2730
ebc96716
PE
2731 * font.c (Ffont_shape_gstring): Don't assume glyph len fits in 'int'.
2732
b4e50fa0 2733 * fns.c (Ffillarray): Don't assume bool vector size fits in 'int'.
f03dc6ef 2734 Use much-faster test for byte-length change.
311d5d7c 2735 Don't assume string byte-length fits in 'int'.
a4cf38e4 2736 Check that character arg fits in 'int'.
85461888 2737 (mapcar1): Declare byte as byte, for clarity.
b4e50fa0 2738
c0c1ee9f
PE
2739 * alloc.c (Fmake_bool_vector): Avoid unnecessary multiplication.
2740
a498d7f4
PE
2741 * fns.c (concat): Catch string overflow earlier.
2742 Do not rely on integer wraparound.
2743
51cab52b
PE
2744 * dispextern.h (struct it.overlay_strings_charpos)
2745 (struct it.selective): Now EMACS_INT, not int.
87830974
PE
2746 * xdisp.c (forward_to_next_line_start)
2747 (back_to_previous_visible_line_start)
2748 (reseat_at_next_visible_line_start, next_element_from_buffer):
2749 Don't arbitrarily truncate the value of 'selective' to int.
2750
76031fad
PE
2751 * xdisp.c (init_iterator): Use XINT, not XFASTINT; it might be < 0.
2752
5eb55db9
PE
2753 * composite.c: Don't truncate sizes to 'int'.
2754 (composition_gstring_p, composition_reseat_it)
2755 (composition_adjust_point): Use EMACS_INT, not int.
7d100a81
PE
2756 (get_composition_id, composition_gstring_put_cache): Use EMACS_INT,
2757 not EMACS_UINT, for indexes.
5eb55db9 2758
0703a717
PE
2759 * category.h (CATEGORY_SET_P): Remove unnecessary cast to EMACS_INT.
2760
d6202519
PE
2761 * buffer.c: Include <verify.h>.
2762 (struct sortvec.priority, struct sortstr.priority):
8961a454 2763 Now EMACS_INT, not int.
c20998a7 2764 (compare_overlays, cmp_for_strings): Avoid subtraction overflow.
67c36fce
PE
2765 (struct sortstr.size, record_overlay_string)
2766 (struct sortstrlist.size, struct sortlist.used):
2767 Don't truncate size to int.
2768 (record_overlay_string): Check for size-calculation overflow.
d6202519 2769 (init_buffer_once): Check at compile-time, not run-time.
fadf4e30 2770
d5a19415
JM
27712011-06-22 Jim Meyering <meyering@redhat.com>
2772
029529ac 2773 Don't leak an XBM-image-sized buffer
d5a19415
JM
2774 * image.c (xbm_load): Free the image buffer after using it.
2775
a9041e6c
PE
27762011-06-21 Paul Eggert <eggert@cs.ucla.edu>
2777
2778 Port to Sun C.
2779 * composite.c (find_automatic_composition): Omit needless 'return 0;'
2780 that Sun C diagnosed.
2781 * fns.c (secure_hash): Fix pointer signedness issue.
2782 * intervals.c (static_offset_intervals): New function.
2783 (offset_intervals): Use it.
2784
7f3f739f
LL
27852011-06-21 Leo Liu <sdl.web@gmail.com>
2786
2787 * deps.mk (fns.o):
2788 * makefile.w32-in ($(BLD)/fns.$(O)): Include sha256.h and
2789 sha512.h.
2790
2791 * fns.c (secure_hash): Rename from crypto_hash_function and change
2792 the first arg to accept symbols.
5b66d427 2793 (Fsecure_hash): New primitive.
7f3f739f
LL
2794 (syms_of_fns): New symbols.
2795
76147d94
DD
27962011-06-20 Deniz Dogan <deniz@dogan.se>
2797
2798 * process.c (Fset_process_buffer): Clarify return value in
2799 docstring.
2800
7d7d0045
CY
28012011-06-18 Chong Yidong <cyd@stupidchicken.com>
2802
2803 * dispnew.c (add_window_display_history): Use BVAR.
2804
2805 * xdisp.c (debug_method_add): Use BVAR.
2806 (check_window_end, dump_glyph_matrix, dump_glyph)
2807 (dump_glyph_row, dump_glyph_string): Convert arglist to ANSI C.
2808
2809 * xfaces.c (check_lface_attrs, check_lface, dump_realized_face):
2810 Likewise.
2811
2812 * xfns.c (Fx_create_frame, x_create_tip_frame): Delay image cache
2813 check till after the cache is created in init_frame_faces.
2814
ff2bc410
SM
28152011-06-17 Stefan Monnier <monnier@iro.umontreal.ca>
2816
2817 * fns.c (Fsafe_length): Yet another int/Lisp_Object mixup.
2818
28177add
PE
28192011-06-16 Paul Eggert <eggert@cs.ucla.edu>
2820
dd3482fe
PE
2821 * lisp.h: Include <limits.h>, for INT_MAX, LONG_MAX, LLONG_MAX.
2822 Without this, prin1 mishandles Lisp_Misc_Save_Value printing on
2823 hosts with pre-C99 libraries, because pD is wrongly defined to "t".
2824
393d71f3 2825 Improve buffer-overflow checking (Bug#8873).
1c8e352f
PE
2826 * fileio.c (Finsert_file_contents):
2827 * insdel.c (insert_from_buffer_1, replace_range, replace_range_2):
2828 Remove the old (too-loose) buffer overflow checks.
2829 They weren't needed, since make_gap checks for buffer overflow.
2830 * insdel.c (make_gap_larger): Catch buffer overflows that were missed.
2831 The old code merely checked for Emacs fixnum overflow, and relied
2832 on undefined (wraparound) behavior. The new code avoids undefined
2833 behavior, and also checks for ptrdiff_t and/or size_t overflow.
2834
2e6813b0 2835 * editfns.c (Finsert_char): Don't dump core with very negative counts.
21d890a4
PE
2836 Tune. Don't use wider integers than needed. Don't use alloca.
2837 Use a bigger 'string' buffer. Rewrite to avoid 'n > 0' test.
2e6813b0 2838
599a9e4f
PE
2839 * insdel.c (replace_range): Fix buf overflow when insbytes < outgoing.
2840
99561444
PE
2841 * insdel.c, lisp.h (buffer_overflow): New function.
2842 (insert_from_buffer_1, replace_range, replace_range_2):
2843 * insdel.c (make_gap_larger):
2844 * editfns.c (Finsert_char):
2845 * fileio.c (Finsert_file_contents): Use it, to normalize wording.
2846
28177add
PE
2847 * buffer.h (BUF_BYTES_MAX): Cast to ptrdiff_t so that it's signed.
2848
e69dafad
PE
28492011-06-15 Paul Eggert <eggert@cs.ucla.edu>
2850
a7af7fde 2851 Integer overflow and signedness fixes (Bug#8873).
ff672d2c 2852
b1c46f02
PE
2853 * ccl.c (ASCENDING_ORDER): New macro, to work around GCC bug 43772.
2854 (GET_CCL_RANGE, IN_INT_RANGE): Use it.
2855
e69dafad
PE
2856 * fileio.c: Don't assume EMACS_INT fits in off_t.
2857 (emacs_lseek): New static function.
2858 (Finsert_file_contents, Fwrite_region): Use it.
2859 Use SEEK_SET, SEEK_CUR, SEEK_END as appropriate.
2860
566684ea
PE
2861 * fns.c (Fload_average): Don't assume 100 * load average fits in int.
2862
e6966cd6
PE
2863 * fns.c: Don't overflow int when computing a list length.
2864 * fns.c (QUIT_COUNT_HEURISTIC): New constant.
2865 (Flength, Fsafe_length): Use EMACS_INT, not int, to avoid unwanted
2866 truncation on 64-bit hosts. Check for QUIT every
2867 QUIT_COUNT_HEURISTIC entries rather than every other entry; that's
2868 faster and is responsive enough.
2869 (Flength): Report an error instead of overflowing an integer.
2870 (Fsafe_length): Return a float if the value is not representable
2871 as a fixnum. This shouldn't happen except in contrived situations.
6346d301 2872 (Fnthcdr, Fsort): Don't assume list length fits in int.
de41a810 2873 (Fcopy_sequence): Don't assume vector length fits in int.
00c604f2 2874
dd0b0efb
PE
2875 * alloc.c: Check that resized vectors' lengths fit in fixnums.
2876 (header_size, word_size): New constants.
2877 (allocate_vectorlike): Don't check size overflow here.
2878 (allocate_vector): Check it here instead, since this is the only
2879 caller of allocate_vectorlike that could cause overflow.
2880 Check that the new vector's length is representable as a fixnum.
2881
86fe5cfe
PE
2882 * fns.c (next_almost_prime): Don't return a multiple of 3 or 5.
2883 The previous code was bogus. For example, next_almost_prime (32)
2884 returned 39, which is undesirable as it is a multiple of 3; and
2885 next_almost_prime (24) returned 25, which is a multiple of 5 so
2886 why was the code bothering to check for multiples of 7?
2887
80e88859
PE
2888 * bytecode.c (exec_byte_code): Use ptrdiff_t, not int, for vector length.
2889
4a2f0ad6
PE
2890 * eval.c, doprnt.c (SIZE_MAX): Remove; inttypes.h defines this now.
2891
f66c7cf8
PE
2892 Variadic C functions now count arguments with ptrdiff_t.
2893 This partly undoes my 2011-03-30 change, which replaced int with size_t.
2894 Back then I didn't know that the Emacs coding style prefers signed int.
2895 Also, in the meantime I found a few more instances where arguments
4a2f0ad6
PE
2896 were being counted with int, which may truncate counts on 64-bit
2897 machines, or EMACS_INT, which may be unnecessarily wide.
f66c7cf8
PE
2898 * lisp.h (struct Lisp_Subr.function.aMANY)
2899 (DEFUN_ARGS_MANY, internal_condition_case_n, safe_call):
2900 Arg counts are now ptrdiff_t, not size_t.
2901 All variadic functions and their callers changed accordingly.
2902 (struct gcpro.nvars): Now size_t, not size_t. All uses changed.
2903 * bytecode.c (exec_byte_code): Check maxdepth for overflow,
2904 to avoid potential buffer overrun. Don't assume arg counts fit in 'int'.
2905 * callint.c (Fcall_interactively): Check arg count for overflow,
2906 to avoid potential buffer overrun. Use signed char, not 'int',
2907 for 'varies' array, so that we needn't bother to check its size
2908 calculation for overflow.
2909 * editfns.c (Fformat): Use ptrdiff_t, not EMACS_INT, to count args.
2910 * eval.c (apply_lambda):
2911 * fns.c (Fmapconcat): Use XFASTINT, not XINT, to get args length.
2912 (struct textprop_rec.argnum): Now ptrdiff_t, not int. All uses changed.
2913 (mapconcat): Use ptrdiff_t, not int and EMACS_INT, to count args.
2914
a1759b76
PE
2915 * callint.c (Fcall_interactively): Don't use index var as event count.
2916
d96be9fc
PE
2917 * vm-limit.c (check_memory_limits): Fix incorrect extern function decls.
2918 * mem-limits.h (SIZE): Remove; no longer used.
2919
a690a978 2920 * xterm.c (x_alloc_nearest_color_1): Prefer int to long when int works.
5efd304b 2921
578c21e6
PE
2922 Remove unnecessary casts.
2923 * xterm.c (x_term_init):
2924 * xfns.c (x_set_border_pixel):
2925 * widget.c (create_frame_gcs): Remove casts to unsigned long etc.
2926 These aren't needed now that we assume ANSI C.
2927
96f53c6c
PE
2928 * sound.c (Fplay_sound_internal): Remove cast to unsigned long.
2929 It's more likely to cause problems (due to unsigned overflow)
2930 than to cure them.
2931
83c77d31
PE
2932 * dired.c (Ffile_attributes): Don't use 32-bit hack on 64-bit hosts.
2933
ee2079f1
PE
2934 * unexelf.c (unexec): Don't assume BSS addr fits in unsigned.
2935
6da65536
PE
2936 * xterm.c (handle_one_xevent): Omit unnecessary casts to unsigned.
2937
7147c4a4
PE
2938 * keyboard.c (modify_event_symbol): Don't limit alist len to UINT_MAX.
2939
193e32d9
PE
2940 * lisp.h (CHAR_TABLE_SET): Omit now-redundant test.
2941
e5533da6
PE
2942 * lread.c (Fload): Don't compare a possibly-garbage time_t value.
2943
9910e595
PE
2944 GLYPH_CODE_FACE returns EMACS_INT, not int.
2945 * dispextern.h (merge_faces):
2946 * xfaces.c (merge_faces):
01103c44
PE
2947 * xdisp.c (get_next_display_element, next_element_from_display_vector):
2948 Don't assume EMACS_INT fits in int.
9910e595 2949
2638320e
PE
2950 * character.h (CHAR_VALID_P): Remove unused parameter.
2951 * fontset.c, lisp.h, xdisp.c: All uses changed.
2952
045eb8d9
PE
2953 * editfns.c (Ftranslate_region_internal): Omit redundant test.
2954
c1f134b5
PE
2955 * fns.c (concat): Minor tuning based on overflow analysis.
2956 This doesn't fix any bugs. Use int to hold character, instead
2957 of constantly refetching from Emacs object. Use XFASTINT, not
2958 XINT, for value known to be a character. Don't bother comparing
2959 a single byte to 0400, as it's always less.
2960
395fcb93 2961 * floatfns.c (Fexpt):
327eeec8
PE
2962 * fileio.c (make_temp_name): Omit unnecessary cast to unsigned.
2963
abbd3d23
PE
2964 * editfns.c (Ftranslate_region_internal): Use int, not EMACS_INT
2965 for characters.
2966
684a03ef
PE
2967 * doc.c (get_doc_string): Omit (unsigned)c that mishandled negatives.
2968
0fed43f3
PE
2969 * data.c (Faset): If ARRAY is a string, check that NEWELT is a char.
2970 Without this fix, on a 64-bit host (aset S 0 4294967386) would
2971 incorrectly succeed when S was a string, because 4294967386 was
2972 truncated before it was used.
2973
8fd02eb7
PE
2974 * chartab.c (Fchar_table_range): Use CHARACTERP to check range.
2975 Otherwise, an out-of-range integer could cause undefined behavior
2976 on a 64-bit host.
2977
f8c86b69
PE
2978 * composite.c: Use int, not EMACS_INT, for characters.
2979 (fill_gstring_body, composition_compute_stop_pos): Use int, not
2980 EMACS_INT, for values that are known to be in character range.
2981 This doesn't fix any bugs but is the usual style inside Emacs and
2982 may generate better code on 32-bit machines.
2983
34206dd2
PE
2984 Make sure a 64-bit char is never passed to ENCODE_CHAR.
2985 This is for reasons similar to the recent CHAR_STRING fix.
2986 * charset.c (Fencode_char): Check that character arg is actually
2987 a character. Pass an int to ENCODE_CHAR.
2988 * charset.h (ENCODE_CHAR): Verify that the character argument is no
2989 wider than 'int', as a compile-time check to prevent future regressions
2990 in this area.
2991
c5958d4c 2992 * character.c (char_string): Remove unnecessary casts.
13bdea59
PE
2993
2994 Make sure a 64-bit char is never passed to CHAR_STRING.
2995 Otherwise, CHAR_STRING would do the wrong thing on a 64-bit platform,
2996 by silently ignoring the top 32 bits, allowing some values
2997 that were far too large to be valid characters.
2998 * character.h: Include <verify.h>.
2999 (CHAR_STRING, CHAR_STRING_ADVANCE): Verify that the character
3000 arguments are no wider than unsigned, as a compile-time check
3001 to prevent future regressions in this area.
3002 * data.c (Faset):
01103c44 3003 * editfns.c (Fchar_to_string, general_insert_function, Finsert_char)
13bdea59
PE
3004 (Fsubst_char_in_region):
3005 * fns.c (concat):
3006 * xdisp.c (decode_mode_spec_coding):
3007 Adjust to CHAR_STRING's new requirement.
3008 * editfns.c (Finsert_char, Fsubst_char_in_region):
3009 * fns.c (concat): Check that character args are actually
3010 characters. Without this test, these functions did the wrong
3011 thing with wildly out-of-range values on 64-bit hosts.
3012
d37ca623
PE
3013 Remove incorrect casts to 'unsigned' that lose info on 64-bit hosts.
3014 These casts should not be needed on 32-bit hosts, either.
3015 * keyboard.c (read_char):
3016 * lread.c (Fload): Remove casts to unsigned.
3017
ea204efb
PE
3018 * lisp.h (UNSIGNED_CMP): New macro.
3019 This fixes comparison bugs on 64-bit hosts.
3020 (ASCII_CHAR_P): Use it.
3021 * casefiddle.c (casify_object):
01103c44 3022 * character.h (ASCII_BYTE_P, CHAR_VALID_P)
ea204efb
PE
3023 (SINGLE_BYTE_CHAR_P, CHAR_STRING):
3024 * composite.h (COMPOSITION_ENCODE_RULE_VALID):
3025 * dispextern.h (FACE_FROM_ID):
3026 * keyboard.c (read_char): Use UNSIGNED_CMP.
3027
41cb286c
PE
3028 * xmenu.c (dialog_selection_callback) [!USE_GTK]: Cast to intptr_t,
3029 not to EMACS_INT, to avoid GCC warning.
3030
4a1b9832
PE
3031 * xfns.c (x_set_scroll_bar_default_width): Remove unused 'int' locals.
3032
55daad71
PE
3033 * buffer.h (PTR_BYTE_POS, BUF_PTR_BYTE_POS): Remove harmful cast.
3034 The cast incorrectly truncated 64-bit byte offsets to 32 bits, and
3035 isn't needed on 32-bit machines.
8f95c75c 3036
01103c44
PE
3037 * buffer.c (Fgenerate_new_buffer_name):
3038 Use EMACS_INT for count, not int.
0ceccced 3039 (advance_to_char_boundary): Return EMACS_INT, not int.
e762cafe
PE
3040
3041 * data.c (Qcompiled_function): Now static.
3042
c6f072e7
PE
3043 * window.c (window_body_lines): Now static.
3044
20ce5912
PE
3045 * image.c (gif_load): Rename local to avoid shadowing.
3046
9c4c5f81
PE
3047 * lisp.h (SAFE_ALLOCA_LISP): Check for integer overflow.
3048 (struct Lisp_Save_Value): Use ptrdiff_t, not int, for 'integer' member.
3049 * alloc.c (make_save_value): Integer argument is now of type
3050 ptrdiff_t, not int.
3051 (mark_object): Use ptrdiff_t, not int.
3052 * lisp.h (pD): New macro.
3053 * print.c (print_object): Use it.
3054
c0c5c8ae
PE
3055 * alloc.c: Use EMACS_INT, not int, to count objects.
3056 (total_conses, total_markers, total_symbols, total_vector_size)
3057 (total_free_conses, total_free_markers, total_free_symbols)
01103c44
PE
3058 (total_free_floats, total_floats, total_free_intervals)
3059 (total_intervals, total_strings, total_free_strings):
c0c5c8ae
PE
3060 Now EMACS_INT, not int. All uses changed.
3061 (Fgarbage_collect): Compute overall total using a double, so that
3062 integer overflow is less likely to be a problem. Check for overflow
3063 when converting back to an integer.
5a25e253
PE
3064 (n_interval_blocks, n_string_blocks, n_float_blocks, n_cons_blocks)
3065 (n_vectors, n_symbol_blocks, n_marker_blocks): Remove.
3066 These were 'int' variables that could overflow on 64-bit hosts;
3067 they were never used, so remove them instead of repairing them.
211a0b2a 3068 (nzombies, ngcs, max_live, max_zombies): Now EMACS_INT, not 'int'.
6349ae4d
PE
3069 (inhibit_garbage_collection): Set gc_cons_threshold to max value.
3070 Previously, this ceilinged at INT_MAX, but that doesn't work on
3071 64-bit machines.
e46bb31a 3072 (allocate_pseudovector): Don't use EMACS_INT when int would do.
c0c5c8ae 3073
c78baabf 3074 * alloc.c (Fmake_bool_vector): Don't assume vector size fits in int.
86f61a15 3075 (allocate_vectorlike): Check for ptrdiff_t overflow.
b6439961
PE
3076 (mark_vectorlike, mark_char_table, mark_object): Avoid EMACS_UINT
3077 when a (possibly-narrower) signed value would do just as well.
3078 We prefer using signed arithmetic, to avoid comparison confusion.
c78baabf 3079
c9d624c6
PE
3080 * alloc.c: Catch some string size overflows that we were missing.
3081 (XMALLOC_OVERRUN_CHECK_SIZE) [!XMALLOC_OVERRUN_CHECK]: Define to 0,
3082 for convenience in STRING_BYTES_MAX.
3083 (STRING_BYTES_MAX): New macro, superseding the old one in lisp.h.
3084 The definition here is exact; the one in lisp.h was approximate.
3085 (allocate_string_data): Check for string overflow. This catches
3086 some instances we weren't catching before. Also, it catches
3087 size_t overflow on (unusual) hosts where SIZE_MAX <= min
3088 (PTRDIFF_MAX, MOST_POSITIVE_FIXNUM), e.g., when size_t is 32 bits
3089 and ptrdiff_t and EMACS_INT are both 64 bits.
c78baabf 3090
c9d624c6
PE
3091 * character.c, coding.c, doprnt.c, editfns.c, eval.c:
3092 All uses of STRING_BYTES_MAX replaced by STRING_BYTES_BOUND.
640c8776 3093 * lisp.h (STRING_BYTES_BOUND): Rename from STRING_BYTES_MAX.
c9d624c6 3094
353032ce
PE
3095 * character.c (string_escape_byte8): Fix nbytes/nchars typo.
3096
2bccce07
PE
3097 * alloc.c (Fmake_string): Check for out-of-range init.
3098
0ac30604
SM
30992011-06-15 Stefan Monnier <monnier@iro.umontreal.ca>
3100
3101 * eval.c (Fdefvaralias): Also mark the target as variable-special-p.
3102
c195f2de
JD
31032011-06-14 Jan Djärv <jan.h.d@swipnet.se>
3104
3105 * xfns.c (x_set_scroll_bar_default_width): Remove argument to
3106 xg_get_default_scrollbar_width.
3107
3108 * gtkutil.c: Include emacsgtkfixed.h if HAVE_GTK3.
3109 (int_gtk_range_get_value): Move to the scroll bar part of the file.
3110 (style_changed_cb): Call update_theme_scrollbar_width and call
3111 x_set_scroll_bar_default_width and xg_frame_set_char_size for
3112 all frames (Bug#8505).
3113 (xg_create_frame_widgets): Call emacs_fixed_new if HAVE_GTK3 (Bug#8505).
3114 Call gtk_window_set_resizable if HAVE_GTK3.
3115 (x_wm_set_size_hint): Call emacs_fixed_set_min_size with min width
3116 and height if HAVE_GTK3 (Bug#8505).
3117 (scroll_bar_width_for_theme): New variable.
3118 (update_theme_scrollbar_width): New function.
3119 (xg_get_default_scrollbar_width): Move code to
3120 update_theme_scrollbar_width, just return scroll_bar_width_for_theme.
3121 (xg_initialize): Call update_theme_scrollbar_width.
3122
3123 * gtkutil.h (xg_get_default_scrollbar_width): Remove argument.
3124
3125 * emacsgtkfixed.c, emacsgtkfixed.h: New files.
3126
e10ac9f1
MR
31272011-06-12 Martin Rudalics <rudalics@gmx.at>
3128
3129 * frame.c (make_frame): Call other_buffer_safely instead of
3130 other_buffer.
3131
3132 * window.c (temp_output_buffer_show): Call display_buffer with
3133 second argument Vtemp_buffer_show_specifiers and reset latter
3134 immediately after the call.
3135 (Vtemp_buffer_show_specifiers): New variable.
3136 (auto_window_vscroll_p, next_screen_context_lines)
3137 (Vscroll_preserve_screen_position): Remove leading asterisks from
3138 doc-strings.
3139
2d3c217e 31402011-06-12 Paul Eggert <eggert@cs.ucla.edu>
4475bec4 3141
7b7f97e8 3142 Fix minor problems found by GCC 4.6.0 static checking.
4475bec4
PE
3143 * buffer.c (Qclone_number): Remove for now, as it's unused.
3144 (record_buffer, Funrecord_buffer): Rename local to avoid shadowing.
3145 (record_buffer): Remove unused local.
3146 * frame.c (other_visible_frames, frame_buffer_list): Now static.
3147 (set_frame_buffer_list): Remove; unused.
3148 * frame.h (other_visible_frames): Remove decl.
3149 * keyboard.h (menu_items_inuse): Declare only if USE_GTK || USE_MOTIF.
3150 * lisp.h (frame_buffer_list, set_frame_buffer_list): Remove decls.
3151 (add_gpm_wait_descriptor, delete_gpm_wait_descriptor): Declare only
3152 if HAVE_GPM.
3153 * menu.c (menu_items_inuse): Now static unless USE_GTK || USE_MOTIF.
3154 * process.c (add_gpm_wait_descriptor, delete_gpm_wait_descriptor):
3155 Define only if HAVE_GPM.
3156 * widget.c (EmacsFrameResize, emacsFrameClassRec): Now static.
3157 (update_hints_inhibit): Remove; never set. All uses removed.
3158 * widgetprv.h (emacsFrameClassRec): Remove decl.
3159 * window.c (delete_deletable_window): Now returns void, since it
3160 wasn't returning anything.
3161 (compare_window_configurations): Remove unused locals.
3162 * xfns.c (x_set_scroll_bar_default_width): Remove unused locals.
3163 * xmenu.c (x_menu_set_in_use): Define only if USE_GTK || USE_MOTIF.
4475bec4
PE
3164 (dialog_selection_callback) [!USE_GTK]: Prefer intptr_t for integers
3165 the same widths as pointers. This follows up on the 2011-05-06 patch.
3166 * xterm.c (x_alloc_lighter_color_for_widget): Define only if USE_LUCID.
3167 * xterm.h: Likewise.
3168 (x_menu_set_in_use): Declare only if USE_GTK || USE_MOTIF.
3169
1384b89e
JB
31702011-06-12 Juanma Barranquero <lekktu@gmail.com>
3171
3172 * makefile.w32-in: Update dependencies.
3173 (LISP_H): Add lib/intprops.h.
3174
1100a63c
CY
31752011-06-11 Chong Yidong <cyd@stupidchicken.com>
3176
3177 * image.c (gif_load): Add animation frame delay to the metadata.
3178 (syms_of_image): Use DEFSYM. New symbol `delay'.
3179
6198ccd0
MR
31802011-06-11 Martin Rudalics <rudalics@gmx.at>
3181
3182 * window.c (delete_deletable_window): Re-add.
3183 (Fset_window_configuration): Rewrite to handle dead buffers and
3184 consequently deletable windows.
3185 (window_tree, Fwindow_tree): Remove. Supply functionality in
3186 window.el.
3187 (compare_window_configurations): Simplify code.
3188
b6e3633c
AS
31892011-06-11 Andreas Schwab <schwab@linux-m68k.org>
3190
1ab0dee5
AS
3191 * image.c (imagemagick_load_image): Fix type mismatch.
3192 (Fimagemagick_types): Likewise.
3193
b6e3633c
AS
3194 * window.h (replace_buffer_in_windows): Declare.
3195
9397e56f
MR
31962011-06-11 Martin Rudalics <rudalics@gmx.at>
3197
3198 * buffer.c: New Lisp objects Qbuffer_list_update_hook and
3199 Qclone_number. Remove external declaration of Qdelete_window.
3200 (Fbuffer_list): Rewrite doc-string. Minor restructuring of
3201 code.
640c8776
SM
3202 (Fget_buffer_create, Fmake_indirect_buffer, Frename_buffer):
3203 Run Qbuffer_list_update_hook if allowed.
9397e56f
MR
3204 (Fother_buffer): Rewrite doc-string. Major rewrite for new
3205 buffer list implementation.
3206 (other_buffer_safely): New function.
3207 (Fkill_buffer): Replace call to replace_buffer_in_all_windows by
3208 calls to replace_buffer_in_windows and
3209 replace_buffer_in_windows_safely. Run Qbuffer_list_update_hook
3210 if allowed.
3211 (record_buffer): Inhibit quitting and rewrite using quittable
3212 functions. Run Qbuffer_list_update_hook if allowed.
3213 (Frecord_buffer, Funrecord_buffer): New functions.
640c8776
SM
3214 (switch_to_buffer_1, Fswitch_to_buffer): Remove.
3215 Move switch-to-buffer to window.el.
9397e56f
MR
3216 (bury-buffer): Move to window.el.
3217 (Vbuffer_list_update_hook): New variable.
3218
3219 * lisp.h (other_buffer_safely): Add prototype in buffer.c
3220 section.
3221
3222 * window.h (resize_frame_windows): Move up in code.
3223 (Fwindow_frame): Remove EXFUN.
3224 (replace_buffer_in_all_windows): Remove prototype.
3225 (replace_buffer_in_windows_safely): Add prototype.
3226
3227 * window.c: Declare Qdelete_window static again. Move down
3228 declaration of select_count.
3229 (Fnext_window, Fprevious_window): Rewrite doc-strings.
3230 (Fother_window): Move to window.el.
3231 (window_loop): Remove DELETE_BUFFER_WINDOWS and UNSHOW_BUFFER
3232 cases. Add REPLACE_BUFFER_IN_WINDOWS_SAFELY case.
3233 (Fdelete_windows_on, Freplace_buffer_in_windows): Move to
3234 window.el.
3235 (replace_buffer_in_windows): Implement by calling
3236 Qreplace_buffer_in_windows.
3237 (replace_buffer_in_all_windows): Remove with some functionality
3238 moved into replace_buffer_in_windows_safely.
3239 (replace_buffer_in_windows_safely): New function.
3240 (select_window_norecord, select_frame_norecord): Move in front
3241 of run_window_configuration_change_hook. Remove now obsolete
3242 declarations.
640c8776
SM
3243 (Fset_window_buffer): Rewrite doc-string.
3244 Call Qrecord_window_buffer.
9397e56f
MR
3245 (keys_of_window): Move binding for other-window to window.el.
3246
b50691aa
CY
32472011-06-11 Chong Yidong <cyd@stupidchicken.com>
3248
3249 * dispextern.h (struct image): Replace data member, whose int_val
3250 and ptr_val fields were not used by anything, with a single
3251 lisp_val object.
3252
3253 * image.c (Fimage_metadata, make_image, mark_image, tiff_load)
3254 (gif_clear_image, gif_load, imagemagick_load_image)
3255 (gs_clear_image, gs_load): Callers changed.
3256
3f754b86
PE
32572011-06-10 Paul Eggert <eggert@cs.ucla.edu>
3258
cca69397
PE
3259 * buffer.h: Include <time.h>, for time_t.
3260 Needed to build on FreeBSD 8.2. Problem reported by Herbert J. Skuhra.
3261
109e28d0
PE
3262 Fix minor problems found by static checking.
3263
60737f02
PE
3264 * image.c (PixelGetMagickColor): Declare if ImageMagick headers don't.
3265
4b66faf3
PE
3266 Make identifiers static if they are not used in other modules.
3267 * data.c (Qcompiled_function, Qframe, Qvector):
3268 * image.c (QimageMagick, Qsvg):
3269 * minibuf.c (Qmetadata):
3270 * window.c (resize_window_check, resize_root_window): Now static.
3271 * window.h (resize_window_check, resize_root_window): Remove decls.
3272
109e28d0
PE
3273 * window.c (window_deletion_count, delete_deletable_window):
3274 Remove; unused.
46a4ce9e
PE
3275 (window_body_lines): Now static.
3276 (Fdelete_other_windows_internal): Mark vars as initialized.
3277 Make sure 'resize_failed' is initialized.
3278 (run_window_configuration_change_hook): Rename local to avoid shadowing.
3279 (resize_window_apply): Remove unused local.
3280 * window.h (delete_deletable_window): Remove decl.
3281
109e28d0 3282 * image.c (gif_load, svg_load_image): Rename locals to avoid shadowing.
33290528
PE
3283 (imagemagick_load_image): Fix pointer signedness problem by changing
3284 last arg from unsigned char * to char *. All uses changed.
3285 Also, fix a local for similar reasons.
3286 Remove unused locals. Remove locals to avoid shadowing.
3287 (fn_rsvg_handle_free): Remove; unused.
3288 (svg_load, svg_load_image): Fix pointer signedness problem.
f7e13da3 3289 (imagemagick_load_image): Don't use garbage pointer image_wand.
33290528 3290
3f754b86
PE
3291 * ftfont.c (ftfont_get_metrics, ftfont_drive_otf): Remove unused locals.
3292
2547adb1
CY
32932011-06-10 Chong Yidong <cyd@stupidchicken.com>
3294
3295 * image.c (gif_load): Fix omitted cast error introduced by
3296 2011-06-06 change.
3297
2c8e37d4
MR
32982011-06-10 Martin Rudalics <rudalics@gmx.at>
3299
3300 * window.h (resize_proportionally, orig_total_lines)
3301 (orig_top_line): Remove from window structure.
3302 (set_window_height, set_window_width, change_window_heights)
3303 (Fdelete_window): Remove prototypes.
3304 (resize_frame_windows): Remove duplicate declaration.
3305
440a42e3
EZ
33062011-06-10 Eli Zaretskii <eliz@gnu.org>
3307
3308 * window.h (resize_frame_windows, resize_window_check)
3309 (delete_deletable_window, resize_root_window)
3310 (resize_frame_windows): Declare prototypes.
3311
3312 * window.c (resize_window_apply): Make definition be "static" to
3313 match the prototype.
3314
562dd5e9
MR
33152011-06-10 Martin Rudalics <rudalics@gmx.at>
3316
3317 * window.c: Remove declarations of Qwindow_size_fixed,
3318 window_min_size_1, window_min_size_2, window_min_size,
3319 size_window, window_fixed_size_p, enlarge_window, delete_window.
3320 Remove static from declaration of Qdelete_window, it's
3321 temporarily needed by Fbury_buffer.
3322 (replace_window): Don't assign orig_top_line and
3323 orig_total_lines.
3324 (Fdelete_window, delete_window): Remove. Window deletion is
3325 handled by window.el.
640c8776
SM
3326 (window_loop): Remove DELETE_OTHER_WINDOWS case.
3327 Replace Fdelete_window calls with calls to Qdelete_window.
562dd5e9
MR
3328 (Fdelete_other_windows): Remove. Deleting other windows is
3329 handled by window.el.
3330 (window_fixed_size_p): Remove. Fixed-sizeness of windows is
3331 handled in window.el.
3332 (window_min_size_2, window_min_size_1, window_min_size): Remove.
3333 Window minimum sizes are handled in window.el.
3334 (shrink_windows, size_window, set_window_height)
3335 (set_window_width, change_window_heights, window_height)
3336 (window_width, CURBEG, CURSIZE, enlarge_window)
3337 (adjust_window_trailing_edge, Fadjust_window_trailing_edge)
3338 (Fenlarge_window, Fshrink_window): Remove. Window resizing is
3339 handled in window.el.
3340 (make_dummy_parent): Rename to make_parent_window and give it a
3341 second argument horflag.
3342 (make_window): Don't set resize_proportionally any more.
3343 (Fsplit_window): Remove. Windows are split in window.el.
3344 (save_restore_action, save_restore_orig_size)
3345 (shrink_window_lowest_first, save_restore_orig_size): Remove.
3346 Resize mini windows in window.el.
3347 (grow_mini_window, shrink_mini_window): Implement by calling
3348 Qresize_root_window_vertically, resize_window_check and
3349 resize_window_apply.
640c8776
SM
3350 (saved_window, Fset_window_configuration, save_window_save):
3351 Do not handle orig_top_line, orig_total_lines, and
562dd5e9
MR
3352 resize_proportionally.
3353 (window_min_height, window_min_width): Move to window.el.
3354 (keys_of_window): Move bindings for delete-other-windows,
3355 split-window, delete-window and enlarge-window to window.el.
3356
3357 * buffer.c: Temporarily extern Qdelete_window.
3358 (Fbury_buffer): Temporarily call Qdelete_window instead of
3359 Fdelete_window (Fbury_buffer will move to window.el soon).
3360
3361 * frame.c (set_menu_bar_lines_1): Remove code handling
3362 orig_top_line and orig_total_lines.
3363
3364 * dispnew.c (adjust_frame_glyphs_initially): Don't use
3365 set_window_height but set heights directly.
3366 (change_frame_size_1): Use resize_frame_windows.
3367
3368 * xdisp.c (init_xdisp): Don't use set_window_height but set
3369 heights directly.
3370
640c8776
SM
3371 * xfns.c (x_set_menu_bar_lines, x_set_tool_bar_lines):
3372 Use resize_frame_windows instead of change_window_heights and run
562dd5e9
MR
3373 run_window_configuration_change_hook.
3374
3375 * w32fns.c (x_set_tool_bar_lines): Use resize_frame_windows
3376 instead of change_window_heights and run
3377 run_window_configuration_change_hook.
3378
1a13852e
MR
33792011-06-09 Martin Rudalics <rudalics@gmx.at>
3380
3381 * window.c (replace_window): Rename second argument REPLACEMENT to
3382 NEW. New third argument SETFLAG. Rewrite.
3383 (delete_window, make_dummy_parent): Call replace_window with
3384 third argument 1.
3385 (window_list_1): Move down in code.
3386 (run_window_configuration_change_hook): Move set_buffer part
3387 before select_frame_norecord part in order to unwind correctly.
3388 Rename count1 to count.
3389 (recombine_windows, delete_deletable_window, resize_root_window)
3390 (Fdelete_other_windows_internal)
3391 (Frun_window_configuration_change_hook, make_parent_window)
3392 (resize_window_check, resize_window_apply, Fresize_window_apply)
3393 (resize_frame_windows, Fsplit_window_internal)
640c8776
SM
3394 (Fdelete_window_internal, Fresize_mini_window_internal):
3395 New functions.
1a13852e
MR
3396 (syms_of_window): New variables Vwindow_splits and Vwindow_nest.
3397
f3d1777e
MR
33982011-06-08 Martin Rudalics <rudalics@gmx.at>
3399
496e208e
MR
3400 * window.h (window): Add some new members to window structure -
3401 normal_lines, normal_cols, new_total, new_normal, clone_number,
3402 splits, nest, prev_buffers, next_buffers.
3403 (WINDOW_TOTAL_SIZE): Move here from window.c.
b9e809c2 3404 (MIN_SAFE_WINDOW_WIDTH, MIN_SAFE_WINDOW_HEIGHT): Define here.
496e208e 3405
f3d1777e
MR
3406 * window.c (Fwindow_height, Fwindow_width, Fwindow_full_width_p):
3407 Remove.
496e208e
MR
3408 (make_dummy_parent): Set new members of windows structure.
3409 (make_window): Move down in code. Handle new members of window
3410 structure.
3411 (Fwindow_clone_number, Fwindow_splits, Fset_window_splits)
3412 (Fwindow_nest, Fset_window_nest, Fwindow_new_total)
3413 (Fwindow_normal_size, Fwindow_new_normal, Fwindow_prev_buffers)
3414 (Fset_window_prev_buffers, Fwindow_next_buffers)
640c8776
SM
3415 (Fset_window_next_buffers, Fset_window_clone_number):
3416 New functions.
496e208e
MR
3417 (Fwindow_hscroll, Fwindow_at, Fwindow_point, Fwindow_start)
3418 (Fwindow_end, Fwindow_line_height, Fset_window_dedicated_p):
3419 Doc-string fixes.
3420 (Fwindow_parameters, Fwindow_parameter, Fset_window_parameter):
3421 Argument WINDOW can be now internal window too.
3422 (Fwindow_use_time): Move up in code.
3423 (Fget_buffer_window): Rename argument FRAME to ALL-FRAMES.
3424 Rewrite doc-string.
3425 (Fset_window_configuration, saved_window)
3426 (Fcurrent_window_configuration, save_window_save): Handle new
3427 members of window structure.
b9e809c2
MR
3428 (WINDOW_TOTAL_SIZE, MIN_SAFE_WINDOW_WIDTH)
3429 (MIN_SAFE_WINDOW_HEIGHT): Move to window.h.
3430 (syms_of_window): New Lisp objects Qrecord_window_buffer,
3431 Qwindow_deletable_p, Qdelete_window, Qreplace_buffer_in_windows,
3432 Qget_mru_window, Qresize_root_window,
3433 Qresize_root_window_vertically, Qsafe, Qabove, Qbelow,
3434 Qauto_buffer_name; staticpro them.
f3d1777e 3435
abde8f8c
MR
34362011-06-07 Martin Rudalics <rudalics@gmx.at>
3437
3438 * window.c (Fwindow_total_size, Fwindow_left_column)
3439 (Fwindow_top_line, window_body_lines, Fwindow_body_size)
3440 (Fwindow_list_1): New functions.
3441 (window_box_text_cols): Replace with window_body_cols.
640c8776
SM
3442 (Fwindow_width, Fscroll_left, Fscroll_right):
3443 Use window_body_cols instead of window_box_text_cols.
3444 (delete_window, Fset_window_configuration):
3445 Call delete_all_subwindows with window as argument.
fa8a67e6
MR
3446 (delete_all_subwindows): Take a window as argument and not a
3447 structure. Rewrite.
190b47e6
MR
3448 (window_loop): Remove handling of GET_LRU_WINDOW and
3449 GET_LARGEST_WINDOW.
3450 (Fget_lru_window, Fget_largest_window): Move to window.el.
abde8f8c
MR
3451
3452 * window.h: Extern window_body_cols instead of
fa8a67e6
MR
3453 window_box_text_cols. delete_all_subwindows now takes a
3454 Lisp_Object as argument.
abde8f8c 3455
640c8776
SM
3456 * indent.c (compute_motion, Fcompute_motion):
3457 Use window_body_cols instead of window_box_text_cols.
abde8f8c 3458
fa8a67e6
MR
3459 * frame.c (delete_frame): Call delete_all_subwindows with root
3460 window as argument.
3461
a54e3482
DC
34622011-06-07 Daniel Colascione <dan.colascione@gmail.com>
3463
3464 * fns.c (Fputhash): Document return value.
3465
60002bf5
CY
34662011-06-06 Chong Yidong <cyd@stupidchicken.com>
3467
3468 * image.c (gif_load): Implement gif89a spec "no disposal" method.
3469
0c671da6 34702011-06-06 Paul Eggert <eggert@cs.ucla.edu>
ccd9a01a 3471
b862a52a 3472 Cons<->int and similar integer overflow fixes (Bug#8794).
77984278 3473
be44ca6c
PE
3474 Check for overflow when converting integer to cons and back.
3475 * charset.c (Fdefine_charset_internal, Fdecode_char):
3476 Use cons_to_unsigned to catch overflow.
3477 (Fencode_char): Use INTEGER_TO_CONS.
3478 * composite.h (LGLYPH_CODE): Use cons_to_unsigned.
3479 (LGLYPH_SET_CODE): Use INTEGER_TO_CONS.
3480 * data.c (long_to_cons, cons_to_long): Remove.
3481 (cons_to_unsigned, cons_to_signed): New functions.
3482 These signal an error for invalid or out-of-range values.
3483 * dired.c (Ffile_attributes): Use INTEGER_TO_CONS.
3484 * fileio.c (Fset_visited_file_modtime): Use CONS_TO_INTEGER.
3485 * font.c (Ffont_variation_glyphs):
3486 * fontset.c (Finternal_char_font): Use INTEGER_TO_CONS.
3487 * lisp.h: Include <intprops.h>.
3488 (INTEGER_TO_CONS, CONS_TO_INTEGER): New macros.
3489 (cons_to_signed, cons_to_unsigned): New decls.
3490 (long_to_cons, cons_to_long): Remove decls.
3491 * undo.c (record_first_change): Use INTEGER_TO_CONS.
3492 (Fprimitive_undo): Use CONS_TO_INTEGER.
3493 * xfns.c (Fx_window_property): Likewise.
3494 * xselect.c: Include <limits.h>.
3495 (x_own_selection, selection_data_to_lisp_data):
3496 Use INTEGER_TO_CONS.
3497 (x_handle_selection_request, x_handle_selection_clear)
3498 (x_get_foreign_selection, Fx_disown_selection_internal)
3499 (Fx_get_atom_name, x_send_client_event): Use CONS_TO_INTEGER.
3500 (lisp_data_to_selection_data): Use cons_to_unsigned.
3501 (x_fill_property_data): Use cons_to_signed.
3502 Report values out of range.
3503
d1f3d2af
PE
3504 Check for buffer and string overflow more precisely.
3505 * buffer.h (BUF_BYTES_MAX): New macro.
3506 * lisp.h (STRING_BYTES_MAX): New macro.
3507 * alloc.c (Fmake_string):
3508 * character.c (string_escape_byte8):
3509 * coding.c (coding_alloc_by_realloc):
3510 * doprnt.c (doprnt):
3511 * editfns.c (Fformat):
3512 * eval.c (verror):
3513 Use STRING_BYTES_MAX, not MOST_POSITIVE_FIXNUM,
3514 since they may not be the same number.
3515 * editfns.c (Finsert_char):
3516 * fileio.c (Finsert_file_contents):
3517 Likewise for BUF_BYTES_MAX.
3518
dd52fcea
PE
3519 * image.c: Use ptrdiff_t, not int, for sizes.
3520 (slurp_file): Switch from int to ptrdiff_t.
3521 All uses changed.
3522 (slurp_file): Check that file size fits in both size_t (for
3523 malloc) and ptrdiff_t (for sanity and safety).
3524
7f9bbdbb
PE
3525 * fileio.c (Fverify_visited_file_modtime): Avoid time overflow
3526 if b->modtime has its maximal value.
3527
dfe18f82
PE
3528 * dired.c (Ffile_attributes): Don't assume EMACS_INT has >32 bits.
3529
84acfcf0
PE
3530 Don't assume time_t can fit into int.
3531 * buffer.h (struct buffer.modtime): Now time_t, not int.
3532 * fileio.c (Fvisited_file_modtime): No need for time_t cast now.
3533 * undo.c (Fprimitive_undo): Use time_t, not int, for time_t value.
3534
ccd9a01a
PE
3535 Minor fixes for signed vs unsigned integers.
3536 * character.h (MAYBE_UNIFY_CHAR):
3537 * charset.c (maybe_unify_char):
3538 * keyboard.c (read_char, reorder_modifiers):
3539 XINT -> XFASTINT, since the integer must be nonnegative.
3540 * ftfont.c (ftfont_spec_pattern):
3541 * keymap.c (access_keymap, silly_event_symbol_error):
3542 XUINT -> XFASTINT, since the integer must be nonnegative.
3543 (Fsingle_key_description, preferred_sequence_p): XUINT -> XINT,
3544 since it makes no difference and we prefer signed.
3545 * keyboard.c (record_char): Use XUINT when all the neighbors do.
3546 (access_keymap): NATNUMP -> INTEGERP, since the integer must be
3547 nonnegative.
3548
d6d100dd
SM
35492011-06-06 Stefan Monnier <monnier@iro.umontreal.ca>
3550
3551 * window.h (Fwindow_frame): Declare.
3552
2b6148e4
PE
35532011-06-06 Paul Eggert <eggert@cs.ucla.edu>
3554
3555 * alloc.c: Simplify handling of large-request failures (Bug#8800).
3556 (SPARE_MEMORY): Always define.
3557 (LARGE_REQUEST): Remove.
3558 (memory_full): Use SPARE_MEMORY rather than LARGE_REQUEST.
3559
f230ecc9
MR
35602011-06-06 Martin Rudalics <rudalics@gmx.at>
3561
727e958e
MR
3562 * lisp.h: Move EXFUNS for Fframe_root_window,
3563 Fframe_first_window and Fset_frame_selected_window to window.h.
3564
3565 * window.h: Move EXFUNS for Fframe_root_window,
3566 Fframe_first_window and Fset_frame_selected_window here from
3567 lisp.h.
3568
3569 * frame.c (Fwindow_frame, Fframe_first_window)
3570 (Fframe_root_window, Fframe_selected_window)
3571 (Fset_frame_selected_window): Move to window.c.
3572 (Factive_minibuffer_window): Move to minibuf.c.
3573 (Fother_visible_frames_p): New function.
3574
3575 * minibuf.c (Factive_minibuffer_window): Move here from frame.c.
3576
f230ecc9
MR
3577 * window.c (decode_window, decode_any_window): Move up in code.
3578 (Fwindowp, Fwindow_live_p): Rewrite doc-strings.
3579 (inhibit_frame_unsplittable): Remove unused variable.
bf60a96b
MR
3580 (Fwindow_buffer): Move up and rewrite doc-string.
3581 (Fwindow_parent, Fwindow_vchild, Fwindow_hchild, Fwindow_next)
3582 (Fwindow_prev): New functions.
727e958e
MR
3583 (Fwindow_frame): Move here from frame.c. Accept any window as
3584 argument.
3585 (Fframe_root_window, Fframe_first_window)
3586 (Fframe_selected_window): Move here from frame.c. Accept frame
3587 or arbitrary window as argument. Update doc-strings.
3588 (Fminibuffer_window): Move up in code.
3589 (Fwindow_minibuffer_p): Move up in code and simplify.
d6d100dd
SM
3590 (Fset_frame_selected_window): Move here from frame.c.
3591 Marginal rewrite.
727e958e
MR
3592 (Fselected_window, select_window, Fselect_window): Move up in
3593 code. Minor doc-string fixes.
f230ecc9 3594
4d09bcf6
PE
35952011-06-06 Paul Eggert <eggert@cs.ucla.edu>
3596
3597 * alloc.c (memory_full) [SYSTEM_MALLOC]: Port to MacOS (Bug#8800).
3598 Do not assume that spare memory exists; that assumption is valid
3599 only if SYSTEM_MALLOC.
3600 (LARGE_REQUEST): New macro, so that the issue of large requests
3601 is separated from the issue of spare memory.
3602
810928a2
AS
36032011-06-05 Andreas Schwab <schwab@linux-m68k.org>
3604
172418ad
AS
3605 * editfns.c (Fformat): Correctly handle zero flag with hexadecimal
3606 format. (Bug#8806)
3607
43f862f7
AS
3608 * gtkutil.c (xg_get_default_scrollbar_width): Avoid warning.
3609
810928a2
AS
3610 * xfns.c (x_set_scroll_bar_default_width): Move declarations
3611 before statements.
3612
a059fe24
JD
36132011-06-05 Jan Djärv <jan.h.d@swipnet.se>
3614
3615 * gtkutil.c (xg_get_default_scrollbar_width): New function.
3616
3617 * gtkutil.h: Declare xg_get_default_scrollbar_width.
3618
3619 * xfns.c (x_set_scroll_bar_default_width): If USE_GTK, get
3620 min width by calling x_set_scroll_bar_default_width (Bug#8505).
3621
989bf368
JB
36222011-06-05 Juanma Barranquero <lekktu@gmail.com>
3623
3624 * xdisp.c (single_display_spec_intangible_p): Remove declaration.
3625
4b80f674
CY
36262011-06-04 Chong Yidong <cyd@stupidchicken.com>
3627
3628 * xselect.c (x_clipboard_manager_save): Remove redundant arg.
3629 (x_clipboard_manager_save): Add return value.
d6d100dd
SM
3630 (x_clipboard_manager_error_1, x_clipboard_manager_error_2):
3631 New error handlers.
4b80f674
CY
3632 (x_clipboard_manager_save_frame, x_clipboard_manager_save_all):
3633 Obey Vx_select_enable_clipboard_manager. Catch errors in
3634 x_clipboard_manager_save (Bug#8779).
3635 (Vx_select_enable_clipboard_manager): New variable.
de65b42c 3636 (x_get_foreign_selection): Reduce scope of x_catch_errors (Bug#8790).
4b80f674 3637
99a33b77 36382011-06-04 Dan Nicolaescu <dann@ics.uci.edu>
8b3115e7
DN
3639
3640 * emacs.c (main): Warn when starting a GTK emacs in daemon mode.
3641
99a33b77 36422011-06-04 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
14eca62f
YM
3643
3644 * fringe.c (update_window_fringes): Don't update overlay arrow bitmap
3645 in the current matrix if keep_current_p is non-zero.
3646
8264569d
EZ
36472011-06-04 Eli Zaretskii <eliz@gnu.org>
3648
3649 * bidi.c (bidi_level_of_next_char): Fix last change.
3650
57f97249
EZ
36512011-06-03 Eli Zaretskii <eliz@gnu.org>
3652
fec2107c 3653 Support bidi reordering of text covered by display properties.
57f97249 3654
fec2107c
EZ
3655 * bidi.c (bidi_copy_it): Use offsetof instead of emulating it.
3656 (bidi_fetch_char, bidi_fetch_char_advance): New functions.
3657 (bidi_cache_search, bidi_cache_iterator_state)
3658 (bidi_paragraph_init, bidi_resolve_explicit, bidi_resolve_weak)
d6d100dd
SM
3659 (bidi_level_of_next_char, bidi_move_to_visually_next):
3660 Support character positions inside a run of characters covered by a
fec2107c
EZ
3661 display string.
3662 (bidi_paragraph_init, bidi_resolve_explicit_1)
3663 (bidi_level_of_next_char): Call bidi_fetch_char and
3664 bidi_fetch_char_advance instead of FETCH_CHAR and
3665 FETCH_CHAR_ADVANCE.
3666 (bidi_init_it): Initialize new members.
3667 (LRE_CHAR, RLE_CHAR, PDF_CHAR, LRO_CHAR, RLO_CHAR): Remove macro
3668 definitions.
3669 (bidi_explicit_dir_char): Lookup character type in bidi_type_table,
3670 instead of using explicit *_CHAR codes.
d6d100dd
SM
3671 (bidi_resolve_explicit, bidi_resolve_weak):
3672 Use FETCH_MULTIBYTE_CHAR instead of FETCH_CHAR, as reordering of
fec2107c
EZ
3673 bidirectional text is supported only in multibyte buffers.
3674 (bidi_init_it): Accept additional argument FRAME_WINDOW_P and use
3675 it to initialize the frame_window_p member of struct bidi_it.
3676 (bidi_cache_iterator_state, bidi_resolve_explicit_1)
3677 (bidi_resolve_explicit, bidi_resolve_weak)
3678 (bidi_level_of_next_char, bidi_move_to_visually_next): Abort if
3679 bidi_it->nchars is non-positive.
3680 (bidi_level_of_next_char): Don't try to lookup the cache for the
3681 next/previous character if nothing is cached there yet, or if we
3682 were just reseat()'ed to a new position.
c40e2fb2 3683
0e14fe90
EZ
3684 * xdisp.c (set_cursor_from_row): Set start and stop points
3685 according to the row's direction when priming the loop that looks
3686 for the glyph on which to display cursor.
3687 (single_display_spec_intangible_p): Function deleted.
3688 (display_prop_intangible_p): Reimplement to call
3689 handle_display_spec instead of single_display_spec_intangible_p.
d6d100dd
SM
3690 Accept 3 additional arguments needed by handle_display_spec.
3691 This fixes incorrect cursor motion across display property with complex
0e14fe90
EZ
3692 values: lists, `(when COND...)' forms, etc.
3693 (single_display_spec_string_p): Support property values that are
3694 lists with the argument STRING its top-level element.
3695 (display_prop_string_p): Fix the condition for processing a
3696 property that is a list to be consistent with handle_display_spec.
fec2107c 3697 (handle_display_spec): New function, refactored from the
fc6f18ce
EZ
3698 last portion of handle_display_prop.
3699 (compute_display_string_pos): Accept additional argument
3700 FRAME_WINDOW_P. Call handle_display_spec to determine whether the
3701 value of a `display' property is a "replacing spec".
3702 (handle_single_display_spec): Accept 2 additional arguments BUFPOS
3703 and FRAME_WINDOW_P. If IT is NULL, don't set up the iterator from
3704 the display property, but just return a value indicating whether
3705 the display property will replace the characters it covers.
3706 (Fcurrent_bidi_paragraph_direction): Initialize the nchars and
3707 frame_window_p members of struct bidi_it.
d6d100dd
SM
3708 (compute_display_string_pos, compute_display_string_end):
3709 New functions.
fec2107c
EZ
3710 (push_it): Accept second argument POSITION, where pop_it should
3711 jump to continue iteration.
3712 (reseat_1): Initialize bidi_it.disp_pos.
fc6f18ce 3713
fec2107c
EZ
3714 * keyboard.c (adjust_point_for_property): Adjust the call to
3715 display_prop_intangible_p to its new signature.
fc6f18ce
EZ
3716
3717 * dispextern.h (struct bidi_it): New member frame_window_p.
fec2107c
EZ
3718 (bidi_init_it): Update prototypes.
3719 (display_prop_intangible_p): Update prototype.
d6d100dd
SM
3720 (compute_display_string_pos, compute_display_string_end):
3721 Declare prototypes.
fec2107c
EZ
3722 (struct bidi_it): New members nchars and disp_pos. ch_len is now
3723 EMACS_INT.
fc6f18ce 3724
40087514 37252011-06-02 Paul Eggert <eggert@cs.ucla.edu>
0de4bb68 3726
57f53182
PE
3727 Malloc failure behavior now depends on size of allocation.
3728 * alloc.c (buffer_memory_full, memory_full): New arg NBYTES.
3729 * lisp.h: Change signatures accordingly.
3730 * alloc.c, buffer.c, editfns.c, menu.c, minibuf.c, xterm.c:
3731 All callers changed. (Bug#8762)
3732
3733 * gnutls.c: Use Emacs's memory allocators.
3734 Without this change, the gnutls library would invoke malloc etc.
3735 directly, which causes problems on non-SYNC_INPUT hosts, and which
3736 runs afoul of improving memory_full behavior. (Bug#8761)
3737 (fn_gnutls_global_set_mem_functions): New macro or function pointer.
3738 (emacs_gnutls_global_init): Use it to specify xmalloc, xrealloc,
3739 xfree instead of the default malloc, realloc, free.
3740 (Fgnutls_boot): No need to check for memory allocation failure,
3741 since xmalloc does that for us.
3742
ac32cd99 3743 Remove arbitrary limit of 2**31 entries in hash tables. (Bug#8771)
3870d916
PE
3744 * category.c (hash_get_category_set):
3745 * ccl.c (ccl_driver):
3746 * charset.c (Fdefine_charset_internal):
3747 * charset.h (struct charset.hash_index):
3748 * composite.c (get_composition_id, gstring_lookup_cache)
3749 (composition_gstring_put_cache):
3750 * composite.h (struct composition.hash_index):
3751 * dispextern.h (struct image.hash):
3752 * fns.c (next_almost_prime, larger_vector, cmpfn_eql)
3753 (cmpfn_equal, cmpfn_user_defined, hashfn_eq, hashfn_eql)
3754 (hashfn_equal, hashfn_user_defined, make_hash_table)
3755 (maybe_resize_hash_table, hash_lookup, hash_put)
3756 (hash_remove_from_table, hash_clear, sweep_weak_table, SXHASH_COMBINE)
3757 (sxhash_string, sxhash_list, sxhash_vector, sxhash_bool_vector)
3758 (Fsxhash, Fgethash, Fputhash, Fmaphash):
3759 * image.c (make_image, search_image_cache, lookup_image)
3760 (xpm_put_color_table_h):
3761 * lisp.h (struct Lisp_Hash_Table):
0de4bb68 3762 * minibuf.c (Ftry_completion, Fall_completions, Ftest_completion):
ac389d0c 3763 * print.c (print): Use 'EMACS_UINT' and 'EMACS_INT'
3870d916 3764 for hashes and hash indexes, instead of 'unsigned' and 'int'.
40087514
PE
3765 * alloc.c (allocate_vectorlike):
3766 Check for overflow in vector size calculations.
3767 * ccl.c (ccl_driver):
3768 Check for overflow when converting EMACS_INT to int.
0de4bb68
PE
3769 * fns.c, image.c: Remove unnecessary static decls that would otherwise
3770 need to be updated by these changes.
40087514
PE
3771 * fns.c (make_hash_table, maybe_resize_hash_table):
3772 Check for integer overflow with large hash tables.
0de4bb68
PE
3773 (make_hash_table, maybe_resize_hash_table, Fmake_hash_table):
3774 Prefer the faster XFLOAT_DATA to XFLOATINT where either will do.
3775 (SXHASH_REDUCE): New macro.
3776 (sxhash_string, sxhash_list, sxhash_vector, sxhash_bool_vector):
3777 Use it instead of discarding useful hash info with large hash values.
3778 (sxhash_float): New function.
3779 (sxhash): Use it. No more need for "& INTMASK" due to above changes.
3780 * lisp.h (FIXNUM_BITS): New macro, useful for SXHASH_REDUCE etc.
40087514
PE
3781 (MOST_NEGATIVE_FIXNUM, MOST_POSITIVE_FIXNUM, INTMASK):
3782 Rewrite to use FIXNUM_BITS, as this simplifies things.
0de4bb68
PE
3783 (next_almost_prime, larger_vector, sxhash, hash_lookup, hash_put):
3784 Adjust signatures to match updated version of code.
3785 (consing_since_gc): Now EMACS_INT, since a single hash table can
3786 use more than INT_MAX bytes.
3787
698d32e2
DN
37882011-06-01 Dan Nicolaescu <dann@ics.uci.edu>
3789
3790 Make it possible to build with GCC-4.6+ -O2 -flto.
3791
3792 * emacs.c (__malloc_initialize_hook): Mark as EXTERNALLY_VISIBLE.
3793
fd6fa53f
SM
37942011-06-01 Stefan Monnier <monnier@iro.umontreal.ca>
3795
3796 * minibuf.c (get_minibuffer, read_minibuf_unwind):
3797 Call minibuffer-inactive-mode.
3798
864db017
JB
37992011-05-31 Juanma Barranquero <lekktu@gmail.com>
3800
3801 * makefile.w32-in ($(BLD)/data.$(O), $(BLD)/editfns.$(O)):
3802 Update dependencies.
3803
2ad0baf4
DN
38042011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
3805
3806 * data.c (init_data): Remove code for UTS, this system is not
3807 supported anymore.
3808
4fcc2638
DN
38092011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
3810
3811 Don't force ./temacs to start in terminal mode.
3812
3813 * frame.c (make_initial_frame): Initialize faces in all cases, not
3814 only when CANNOT_DUMP is defined.
3815 * dispnew.c (init_display): Remove CANNOT_DUMP condition.
3816
c56e0fd5
DN
38172011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
3818
3819 * dispnew.c (add_window_display_history): Use const for the string
3820 pointer. Remove declaration, not needed.
3821
333d54da 38222011-05-31 Paul Eggert <eggert@cs.ucla.edu>
9cf9f756 3823
55d4c1b2 3824 Use 'inline', not 'INLINE'.
333d54da 3825 <http://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00914.html>
55d4c1b2
PE
3826 * alloc.c, fontset.c (INLINE): Remove.
3827 * alloc.c, bidi.c, charset.c, coding.c, dispnew.c, fns.c, image.c:
3828 * intervals.c, keyboard.c, process.c, syntax.c, textprop.c, w32term.c:
3829 * xdisp.c, xfaces.c, xterm.c: Replace all uses of INLINE with inline.
3830 * gmalloc.c (register_heapinfo): Use inline unconditionally.
3831 * lisp.h (LISP_MAKE_RVALUE): Use inline, not __inline__.
3832
738db178
DN
38332011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
3834
3835 Make it possible to run ./temacs.
3836
3837 * callproc.c (set_initial_environment): Remove CANNOT_DUMP code,
3838 syms_of_callproc does the same thing. Remove test for
3839 "initialized", do it in the caller.
3840 * emacs.c (main): Avoid calling set_initial_environment when dumping.
3841
620c53a6
SM
38422011-05-31 Stefan Monnier <monnier@iro.umontreal.ca>
3843
3844 * minibuf.c (Finternal_complete_buffer): Return `category' metadata.
3845 (read_minibuf): Use get_minibuffer.
3846 (syms_of_minibuf): Use DEFSYM.
3847 (Qmetadata): New var.
3848 * data.c (Qbuffer): Don't make it static.
3849 (syms_of_data): Use DEFSYM.
3850
e003a292
PE
38512011-05-31 Paul Eggert <eggert@cs.ucla.edu>
3852
3853 * ccl.c (CCL_CODE_RANGE): Allow negative numbers. (Bug#8751)
3854 (CCL_CODE_MIN): New macro.
3855
ed008a6d
PE
38562011-05-30 Paul Eggert <eggert@cs.ucla.edu>
3857
3687c2ef
PE
3858 * alloc.c (lisp_align_malloc): Omit unnecessary val==NULL tests.
3859
ed008a6d
PE
3860 * eval.c (Qdebug): Now static.
3861 * lisp.h (Qdebug): Remove decl. This reverts a part of the
3862 2011-04-26T11:26:05Z!dan.colascione@gmail.com that inadvertently undid part of
3863 2011-04-14T06:48:41Z!eggert@cs.ucla.edu.
3864
d66c4c7c
CY
38652011-05-29 Chong Yidong <cyd@stupidchicken.com>
3866
3867 * image.c: Various fixes to ImageMagick code comments.
3868 (Fimagemagick_types): Doc fix.
3869
5fbc2025
PE
38702011-05-29 Paul Eggert <eggert@cs.ucla.edu>
3871
0196f88a
PE
3872 Minor fixes prompted by GCC 4.6.0 warnings.
3873
3874 * xselect.c (converted_selections, conversion_fail_tag): Now static.
3875
5fbc2025
PE
3876 * emacs.c [HAVE_X_WINDOWS]: Include "xterm.h".
3877 (x_clipboard_manager_save_all): Move extern decl to ...
3878 * xterm.h: ... here, so that it can be checked for consistency.
3879
1dd3c2d9
CY
38802011-05-29 Chong Yidong <cyd@stupidchicken.com>
3881
3882 * xselect.c (x_clipboard_manager_save_frame)
3883 (x_clipboard_manager_save_all): New functions.
3884 (Fx_clipboard_manager_save): Lisp function deleted.
3885
3886 * emacs.c (Fkill_emacs): Call x_clipboard_manager_save_all.
3887 * frame.c (delete_frame): Call x_clipboard_manager_save_frame.
3888
3889 * xterm.h: Update prototype.
3890
5ba6571d
WX
38912011-05-28 William Xu <william.xwl@gmail.com>
3892
3893 * nsterm.m (ns_term_shutdown): Synchronize user defaults before
3894 exiting (Bug#8239).
3895
3eaff834
JM
38962011-05-28 Jim Meyering <meyering@redhat.com>
3897
e1900994 3898 Avoid a sign-extension bug in crypto_hash_function.
3eaff834
JM
3899 * fns.c (to_uchar): Define.
3900 (crypto_hash_function): Use it to convert some newly-signed
3901 variables to unsigned, to avoid sign-extension bugs. For example,
3902 without this change, (md5 "truc") would evaluate to
3903 45723a2aff78ff4fff7fff1114760e62 rather than the expected
3904 45723a2af3788c4ff17f8d1114760e62. Reported by Antoine Levitt in
e1900994 3905 https://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00883.html.
3eaff834 3906
0f6990a7
PE
39072011-05-27 Paul Eggert <eggert@cs.ucla.edu>
3908
3909 Integer overflow fixes.
c8a9ca5a 3910
08686060
PE
3911 * dbusbind.c: Serial number integer overflow fixes.
3912 (CHECK_DBUS_SERIAL_GET_SERIAL): New macro.
08686060
PE
3913 (Fdbus_call_method_asynchronously, xd_read_message_1): Use a float
3914 to hold a serial number that is too large for a fixnum.
3915 (Fdbus_method_return_internal, Fdbus_method_error_internal):
3916 Check for serial numbers out of range. Decode any serial number
59568bf0 3917 that was so large that it became a float. (Bug#8722)
08686060 3918
2d1fc3c7
PE
3919 * dbusbind.c: Use XFASTINT rather than XUINT, and check for nonneg.
3920 (Fdbus_call_method, Fdbus_call_method_asynchronously):
3921 Use XFASTINT rather than XUINT when numbers are nonnegative.
3922 (xd_append_arg, Fdbus_method_return_internal):
3923 (Fdbus_method_error_internal): Likewise. Also, for unsigned
3924 arguments, check that Lisp number is nonnegative, rather than
59568bf0 3925 silently wrapping negative numbers around. (Bug#8722)
30217ff0 3926 (xd_read_message_1): Don't assume dbus_uint32_t can fit in int.
59568bf0 3927 (Bug#8722)
2d1fc3c7 3928
c8a9ca5a
PE
3929 * data.c (arith_driver, Flsh): Avoid unnecessary casts to EMACS_UINT.
3930
519e1d69
PE
3931 * ccl.c (ccl_driver): Redo slightly to avoid the need for 'unsigned'.
3932
30569699
PE
3933 ccl: add integer overflow checks
3934 * ccl.c (CCL_CODE_MAX, GET_CCL_RANGE, GET_CCL_CODE, GET_CCL_INT):
3935 (IN_INT_RANGE): New macros.
3936 (ccl_driver): Use them to check for integer overflow when
3937 decoding a CCL program. Many of the new checks are whether XINT (x)
3938 fits in int; it doesn't always, on 64-bit hosts. The new version
3939 doesn't catch all possible integer overflows, but it's an
847044ea 3940 improvement. (Bug#8719)
30569699 3941
c11285dc
PE
3942 * alloc.c (make_event_array): Use XINT, not XUINT.
3943 There's no need for unsigned here.
3944
fdccd48e
PE
3945 * mem-limits.h (EXCEEDS_LISP_PTR) [!USE_LSB_TAG]: EMACS_UINT -> uintptr_t
3946 This follows up to the 2011-05-06 change that substituted uintptr_t
3947 for EMACS_INT. This case wasn't caught back then.
3948
37910ab2
PE
3949 Rework Fformat to avoid integer overflow issues.
3950 * editfns.c: Include <float.h> unconditionally, as it's everywhere
3951 now (part of C89). Include <verify.h>.
3952 (MAX_10_EXP, CONVERTED_BYTE_SIZE): Remove; no longer needed.
3953 (pWIDE, pWIDElen, signed_wide, unsigned_wide): New defns.
3954 (Fformat): Avoid the prepass trying to compute sizes; it was only
3955 approximate and thus did not catch overflow reliably. Instead, walk
3956 through the format just once, formatting and computing sizes as we go,
3957 checking for integer overflow at every step, and allocating a larger
3958 buffer as needed. Keep track separately whether the format is
3959 multibyte. Keep only the most-recently calculated precision, rather
3960 than them all. Record whether each argument has been converted to
3961 string. Use EMACS_INT, not int, for byte and char and arg counts.
3962 Support field widths and precisions larger than INT_MAX. Avoid
3963 sprintf's undefined behavior with conversion specifications such as %#d
3964 and %.0c. Fix bug with strchr succeeding on '\0' when looking for
3965 flags. Fix bug with (format "%c" 256.0). Avoid integer overflow when
3966 formatting out-of-range floating point numbers with int
9173deec 3967 formats. (Bug#8668)
37910ab2 3968
2e6578fb
PE
3969 * lisp.h (FIXNUM_OVERFLOW_P): Work even if arg is a NaN.
3970
0ae6bdee
PE
3971 * data.c: Avoid integer truncation in expressions involving floats.
3972 * data.c: Include <intprops.h>.
3973 (arith_driver): When there's an integer overflow in an expression
3974 involving floating point, convert the integers to floating point
3975 so that the resulting value does not suffer from catastrophic
3976 integer truncation. For example, on a 64-bit host (* 4
3977 most-negative-fixnum 0.5) should yield about -4.6e+18, not zero.
3978 Do not rely on undefined behavior after integer overflow.
3979
de883a70
PE
3980 merge count_size_as_multibyte, parse_str_to_multibyte
3981 * character.c, character.h (count_size_as_multibyte):
fd6fa53f 3982 Rename from parse_str_to_multibyte; all uses changed.
de883a70
PE
3983 Check for integer overflow.
3984 * insdel.c, lisp.h (count_size_as_multibyte): Remove,
3985 since it's now a duplicate of the other. This is more of
3986 a character than a buffer op, so better that it's in character.c.
3987 * fns.c, print.c: Adjust to above changes.
3988
2ff916cb
PE
39892011-05-27 Stefan Monnier <monnier@iro.umontreal.ca>
3990
3991 * xselect.c (x_convert_selection): Yet another int/Lisp_Object mixup.
3992
f1b54466
PE
39932011-05-27 Paul Eggert <eggert@cs.ucla.edu>
3994
fb1ac845
PE
3995 * xselect.c: Fix minor problems prompted by GCC 4.6.0 warnings.
3996 (x_handle_selection_request, frame_for_x_selection): Remove unused vars.
3997 (x_clipboard_manager_save): Now static.
3998 (Fx_clipboard_manager_save): Rename local to avoid shadowing.
3999
f1b54466
PE
4000 * fns.c: Fix minor problems prompted by GCC 4.6.0 warnings.
4001 (crypto_hash_function): Now static.
4002 Fix pointer signedness problems. Avoid unnecessary initializations.
4003
a9f737ee
CY
40042011-05-27 Chong Yidong <cyd@stupidchicken.com>
4005
4006 * termhooks.h (Vselection_alist): Make it terminal-local.
4007
4008 * terminal.c (create_terminal): Initialize it.
4009
4010 * xselect.c: Support for clipboard managers.
4011 (Vselection_alist): Move to termhooks.h as terminal-local var.
4012 (LOCAL_SELECTION): New macro.
4013 (x_atom_to_symbol): Handle x_display_info_for_display fail case.
4014 (symbol_to_x_atom): Remove gratuitous arg.
4015 (x_handle_selection_request, lisp_data_to_selection_data)
4016 (x_get_foreign_selection, Fx_register_dnd_atom): Callers changed.
620c53a6
SM
4017 (x_own_selection, x_get_local_selection, x_convert_selection):
4018 New arg, specifying work frame. Use terminal-local Vselection_alist.
a9f737ee
CY
4019 (some_frame_on_display): Delete unused function.
4020 (Fx_own_selection_internal, Fx_get_selection_internal)
4021 (Fx_disown_selection_internal, Fx_selection_owner_p)
4022 (Fx_selection_exists_p): New optional frame arg.
4023 (frame_for_x_selection, Fx_clipboard_manager_save): New functions.
4024 (x_handle_selection_clear): Don't treat other terminals with the
4025 same keyboard specially. Use the terminal-local Vselection_alist.
4026 (x_clear_frame_selections): Use Frun_hook_with_args.
4027
4028 * xterm.c (x_term_init): Intern ATOM and CLIPBOARD_MANAGER atoms.
4029
4030 * xterm.h: Add support for those atoms.
4031
e067f0c1
CY
40322011-05-26 Chong Yidong <cyd@stupidchicken.com>
4033
4034 * xselect.c: ICCCM-compliant handling of MULTIPLE targets.
4035 (converted_selections, conversion_fail_tag): New global variables.
4036 (x_selection_request_lisp_error): Free the above.
4037 (x_get_local_selection): Remove unnecessary code.
4038 (x_reply_selection_request): Args changed; handle arbitrary array
620c53a6
SM
4039 of converted selections stored in converted_selections.
4040 Separate the XChangeProperty and SelectionNotify steps.
e067f0c1
CY
4041 (x_handle_selection_request): Rewrite to handle MULTIPLE target.
4042 (x_convert_selection): New function.
4043 (x_handle_selection_event): Simplify.
4044 (x_get_foreign_selection): Don't ignore incoming requests while
4045 waiting for an answer; this will fail when we implement
4046 SAVE_TARGETS, and seems unnecessary anyway.
4047 (selection_data_to_lisp_data): Recognize ATOM_PAIR type.
4048 (Vx_sent_selection_functions): Doc fix.
4049
0f4aebc0
LL
40502011-05-26 Leo Liu <sdl.web@gmail.com>
4051
4052 * editfns.c (Ftranspose_regions): Allow empty regions. (Bug#8699)
4053
e61124cd
YM
40542011-05-25 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
4055
4056 * dispextern.h (struct glyph_row): New member fringe_bitmap_periodic_p.
4057
4058 * dispnew.c (shift_glyph_matrix, scrolling_window): Mark scrolled row
4059 for fringe update if it has periodic bitmap.
ac389d0c 4060 (row_equal_p): Also compare left_fringe_offset, right_fringe_offset,
e61124cd
YM
4061 and fringe_bitmap_periodic_p.
4062
4063 * fringe.c (get_fringe_bitmap_data): New function.
4064 (draw_fringe_bitmap_1, update_window_fringes): Use it.
4065 (update_window_fringes): Record periodicity of fringe bitmap in glyph
4066 row. Mark glyph row for fringe update if periodicity changed.
4067
4068 * xdisp.c (try_window_reusing_current_matrix): Don't mark scrolled row
4069 for fringe update unless it has periodic bitmap.
4070
f16d9837
KH
40712011-05-25 Kenichi Handa <handa@m17n.org>
4072
4073 * xdisp.c (get_next_display_element): Set correct it->face_id for
4074 a static composition.
4075
e1b90ef6
LL
40762011-05-24 Leo Liu <sdl.web@gmail.com>
4077
4078 * deps.mk (fns.o):
4079 * makefile.w32-in ($(BLD)/fns.$(O)): Include sha1.h.
4080
4081 * fns.c (crypto_hash_function, Fsha1): New function.
4082 (Fmd5): Use crypto_hash_function.
4083 (syms_of_fns): Add Ssha1.
4084
7400048f
PE
40852011-05-22 Paul Eggert <eggert@cs.ucla.edu>
4086
4087 * gnutls.c: Remove unused macros.
4088 (fn_gnutls_transport_set_lowat, fn_gnutls_transport_set_pull_function):
4089 (fn_gnutls_transport_set_push_function) [!WINDOWSNT]:
4090 Remove macros that are defined and never used.
4091 Caught by gcc -Wunused-macros (GCC 4.6.0, Fedora 14).
4092
abb71cf4
CY
40932011-05-22 Chong Yidong <cyd@stupidchicken.com>
4094
4095 * xselect.c (syms_of_xselect): Remove unused symbol SAVE_TARGETS.
4096 (Fx_get_selection_internal): Minor cleanup.
4097 (Fx_own_selection_internal): Rename arguments for consistency with
4098 select.el.
4099
6307db39
PE
41002011-05-22 Paul Eggert <eggert@cs.ucla.edu>
4101
4102 * xselect.c (QSAVE_TARGETS): New static var, to fix build failure.
4103
f3d4e0a4
CY
41042011-05-22 Chong Yidong <cyd@stupidchicken.com>
4105
4106 * xselect.c (syms_of_xselect): Include character.h; use DEFSYM.
4107
4d8ade89
YM
41082011-05-21 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
4109
4110 * dispnew.c (scrolling_window): Don't exclude the case that the
4111 last enabled row in the desired matrix touches the bottom boundary.
4112
32078c8d
GM
41132011-05-21 Glenn Morris <rgm@gnu.org>
4114
4115 * Makefile.in ($(etc)/DOC): Make second command line even shorter.
33cf345f
GM
4116 (SOME_MACHINE_OBJECTS): Replace FONT_OBJ by its maximal expansion,
4117 and add some more files.
32078c8d 4118
7285dc67
EZ
41192011-05-20 Eli Zaretskii <eliz@gnu.org>
4120
4121 * callproc.c (Fcall_process) [MSDOS]: Fix arguments to
4122 report_file_error introduced by the change from 2011-05-07.
4123
89d1bd22
PE
41242011-05-20 Paul Eggert <eggert@cs.ucla.edu>
4125
4126 * systime.h (Time): Define only if emacs is defined.
4127 This is to allow ../lib-src/profile.c to be compiled on FreeBSD,
4128 where the include path doesn't have X11/X.h by default. See
4129 <http://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00561.html>.
4130
e23640bb 41312011-05-20 Kenichi Handa <handa@m17n.org>
31bfc35c
KH
4132
4133 * composite.c (find_automatic_composition): Fix previous change.
4134
b9704ad9
GM
41352011-05-20 Glenn Morris <rgm@gnu.org>
4136
4137 * lisp.mk: New file, split from Makefile.in.
4138 * Makefile.in (lisp): Move to separate file, inserted by @lisp_frag@.
4139 (shortlisp): Remove.
4140 ($(etc)/DOC): Edit lisp.mk rather than using $shortlisp.
4141
4a720484
GM
41422011-05-19 Glenn Morris <rgm@gnu.org>
4143
4144 * Makefile.in (MSDOS_SUPPORT_REAL, MSDOS_SUPPORT, NS_SUPPORT)
4145 (REAL_MOUSE_SUPPORT, GPM_MOUSE_SUPPORT, MOUSE_SUPPORT, TOOLTIP_SUPPORT)
4146 (BASE_WINDOW_SUPPORT, X_WINDOW_SUPPORT, WINDOW_SUPPORT): Remove.
4147 (lisp): Set the order to that of loadup.el.
4148 (shortlisp): Make it a copy of $lisp.
4149 (SOME_MACHINE_LISP): Remove.
4150 ($(etc)/DOC): Depend just on $lisp, not $SOME_MACHINE_LISP too.
4151 Use just $shortlisp, not $SOME_MACHINE_LISP too.
4152
a28d4396
KH
41532011-05-18 Kenichi Handa <handa@m17n.org>
4154
4155 * composite.c (CHAR_COMPOSABLE_P): Add more check for efficiency.
4156 (BACKWARD_CHAR): Wrap the arg STOP by parenthesis.
4157 (find_automatic_composition): Mostly rewrite for efficiency.
4158
a2b1fa8e
JB
41592011-05-18 Juanma Barranquero <lekktu@gmail.com>
4160
4161 * makefile.w32-in: Update dependencies.
4162
8e1f5610
CS
41632011-05-18 Christoph Scholtes <cschol2112@googlemail.com>
4164
4165 * menu.c: Include limits.h (fixes the MS-Windows build broken by
7d7d0045 4166 2011-06-18T18:49:19Z!cyd@stupidchicken.com).
8e1f5610 4167
7025ee00 41682011-05-18 Paul Eggert <eggert@cs.ucla.edu>
cb93f9be 4169
cdfa6eab
PE
4170 Fix some integer overflow issues, such as string length overflow.
4171
06d6db33
PE
4172 * insdel.c (count_size_as_multibyte): Check for string overflow.
4173
2b4560a8
PE
4174 * character.c (lisp_string_width): Check for string overflow.
4175 Use EMACS_INT, not int, for string indexes and lengths; in
4176 particular, 2nd arg is now EMACS_INT, not int. Do not crash if
4177 the resulting string length overflows an EMACS_INT; instead,
4178 report a string overflow if no precision given. When checking for
4179 precision exhaustion, use a check that cannot possibly have
4180 integer overflow. (Bug#8675)
4181 * character.h (lisp_string_width): Adjust to new signature.
4182
cb93f9be
PE
4183 * alloc.c (string_overflow): New function.
4184 (Fmake_string): Use it. This doesn't change behavior, but saves
4185 a few bytes and will simplify future changes.
4186 * character.c (string_escape_byte8): Likewise.
4187 * lisp.h (string_overflow): New decl.
4188
1a1f3366
PE
4189 Fixups, following up to the user-interface timestamp change.
4190 * nsterm.m (last_mouse_movement_time, ns_mouse_position): Use Time
4191 for UI timestamps, instead of unsigned long.
9fbd6841
PE
4192 * msdos.c (mouse_get_pos): Likewise.
4193 * w32inevt.c (movement_time, w32_console_mouse_position): Likewise.
1a1f3366
PE
4194 * w32gui.h (Time): Define by including "systime.h" rather than by
4195 declaring it ourselves. (Bug#8664)
4196
d4e3e4d3
PE
4197 * dispextern.h (struct image): Don't assume time_t <= unsigned long.
4198 * image.c (clear_image_cache): Likewise.
4199
f6a24d19
PE
4200 * term.c (term_mouse_position): Don't assume time_t wraparound.
4201
08dc5ae6
PE
4202 Be more systematic about user-interface timestamps.
4203 Before, the code sometimes used 'Time', sometimes 'unsigned long',
620c53a6
SM
4204 and sometimes 'EMACS_UINT', to represent these timestamps.
4205 This change causes it to use 'Time' uniformly, as that's what X uses.
08dc5ae6
PE
4206 This makes the code easier to follow, and makes it easier to catch
4207 integer overflow bugs such as Bug#8664.
4208 * frame.c (Fmouse_position, Fmouse_pixel_position):
4209 Use Time, not unsigned long, for user-interface timestamps.
4210 * keyboard.c (last_event_timestamp, kbd_buffer_get_event): Likewise.
4211 (button_down_time, make_lispy_position, make_lispy_movement): Likewise.
4212 * keyboard.h (last_event_timestamp): Likewise.
4213 * menu.c (Fx_popup_menu) [!HAVE_X_WINDOWS]: Likewise.
4214 * menu.h (xmenu_show): Likewise.
4215 * term.c (term_mouse_position): Likewise.
4216 * termhooks.h (struct input_event.timestamp): Likewise.
4217 (struct terminal.mouse_position_hook): Likewise.
4218 * xmenu.c (create_and_show_popup_menu, xmenu_show): Likewise.
4219 * xterm.c (XTmouse_position, x_scroll_bar_report_motion): Likewise.
4220 * systime.h (Time): New decl. Pull it in from <X11/X.h> if
4221 HAVE_X_WINDOWS, otherwise define it as unsigned long, which is
4222 what it was before.
4223 * menu.h, termhooks.h: Include "systime.h", for Time.
4224
8e55734a
PE
4225 * keyboard.c (make_lispy_event): Fix problem in integer overflow.
4226 Don't assume that the difference between two unsigned long values
4227 can fit into an integer. At this point, we know button_down_time
4228 <= event->timestamp, so the difference must be nonnegative, so
4229 there's no need to cast the result if double-click-time is
4230 nonnegative, as it should be; check that it's nonnegative, just in
4231 case. This bug is triggered when events are more than 2**31 ms
86db42d2 4232 apart (about 25 days). (Bug#8664)
8e55734a 4233
841f1b75 4234 * xselect.c (last_event_timestamp): Remove duplicate decl.
6434756c 4235 (x_own_selection): Remove needless cast to unsigned long.
841f1b75 4236
3e26f69c
PE
4237 * xmenu.c (set_frame_menubar): Use int, not EMACS_UINT, for indexes
4238 that always fit in int. Use a sentinel instead of a counter, to
4239 avoid a temp and to allay GCC's concerns about possible int overflow.
d230cb74
PE
4240 * frame.h (struct frame): Use int for menu_bar_items_used
4241 instead of EMACS_INT, since it always fits in int.
3e26f69c 4242
5cc152c0
PE
4243 * menu.c (grow_menu_items): Check for int overflow.
4244
d89eb65e
PE
4245 * xmenu.c (set_frame_menubar): Don't mishandle vectors with no nils.
4246
5235bd3e
PE
4247 * xterm.c: Use EMACS_INT for Emacs modifiers, and int for X modifiers.
4248 Before, the code was not consistent. These values cannot exceed
4249 2**31 - 1 so there's no need to make them unsigned.
4250 (x_x_to_emacs_modifiers): Accept int and return EMACS_INT.
4251 (x_emacs_to_x_modifiers): Accept EMACS_INT and return int.
4252 (x_x_to_emacs_modifiers, x_emacs_to_x_modifiers): Reject non-integers
4253 as modifiers.
4254 * xterm.h (x_x_to_emacs_modifiers): Adjust to signature change.
4255
bc827e23
PE
4256 * lisp.h (XINT) [USE_LISP_UNION_TYPE]: Cast to EMACS_INT.
4257 (XUINT) [USE_LISP_UNION_TYPE]: Cast to EMACS_UINT.
4258 Otherwise, GCC 4.6.0 warns about printf (pI, XINT (...)),
4259 presumably because the widths might not match.
4260
78eb494e
PE
4261 * window.c (size_window): Avoid needless test at loop start.
4262
04f2d78b
CB
42632011-05-18 Courtney Bane <emacs-bugs-7626@cbane.org> (tiny change)
4264
4265 * term.c (Fresume_tty): Restore hooks before reinitializing (bug#8687).
4266
d2fc7e3d 42672011-05-12 Drew Adams <drew.adams@oracle.com>
e531bdff
DA
4268
4269 * textprop.c (Fprevious_single_char_property_change): Doc fix (bug#8655).
4270
d2fc7e3d 42712011-05-12 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
7db47798
YM
4272
4273 * w32term.c (w32_draw_fringe_bitmap): Rename local vars `left' and
4274 `width' to `bar_area_x' and `bar_area_width', respectively.
4275 (x_scroll_run): Take account of fringe background extension.
4276
04f2d78b
CB
4277 * xterm.c (x_draw_fringe_bitmap) [USE_TOOLKIT_SCROLL_BARS]:
4278 Rename local vars `left' and `width' to `bar_area_x' and
7db47798
YM
4279 `bar_area_width', respectively.
4280 (x_scroll_run) [USE_TOOLKIT_SCROLL_BARS]: Take account of fringe
4281 background extension.
4282
79b70037
GM
42832011-05-10 Jim Meyering <meyering@redhat.com>
4284
4285 * xdisp.c (x_intersect_rectangles): Fix typo "the the -> the".
4286
2f142cc5
JB
42872011-05-10 Juanma Barranquero <lekktu@gmail.com>
4288
4289 * image.c (Finit_image_library): Return t for built-in image types,
4290 like pbm and xbm. (Bug#8640)
4291
57679c86
AS
42922011-05-09 Andreas Schwab <schwab@linux-m68k.org>
4293
4294 * w32menu.c (set_frame_menubar): Fix submenu allocation.
4295
888c9e86
EZ
42962011-05-07 Eli Zaretskii <eliz@gnu.org>
4297
b0512a1d
EZ
4298 * w32console.c (Fset_screen_color): Doc fix.
4299 (Fget_screen_color): New function.
4300 (syms_of_ntterm): Defsubr it.
4301
7285dc67
EZ
4302 * callproc.c (call_process_cleanup) [MSDOS]: Don't close and
4303 unlink the temporary file if Fcall_process didn't create it in the
4304 first place.
4305 (Fcall_process) [MSDOS]: Don't create tempfile if stdout of the
4306 child process will be redirected to a file specified with `:file'.
888c9e86
EZ
4307 Don't try to re-open tempfile in that case, and set fd[0] to -1 as
4308 cue to call_process_cleanup not to close that handle.
4309
4d3fcc8e
BK
43102011-05-07 Ben Key <bkey76@gmail.com>
4311
4312 * makefile.w32-in: The bootstrap-temacs rule now makes use of
4313 one of two shell specific rules, either bootstrap-temacs-CMD or
4314 bootstrap-temacs-SH. The bootstrap-temacs-SH rule is identical
4315 to the previous implementation of the bootstrap-temacs rule.
4316 The bootstrap-temacs-CMD rule is similar to the previous
4317 implementation of the bootstrap-temacs rule except that it
4318 makes use of the ESC_CFLAGS variable instead of the CFLAGS
4319 variable.
4320
4321 These changes, along with some changes to nt/configure.bat,
4322 nt/gmake.defs, and nt/nmake.defs, are required to extend my
4323 earlier fix to add support for --cflags and --ldflags options
4324 that include quotes so that it works whether make uses cmd or
4325 sh as the shell.
4326
b4289b64
MA
43272011-05-06 Michael Albinus <michael.albinus@gmx.de>
4328
4329 * dbusbind.c (QCdbus_type_unix_fd): Declare static.
4330 (xd_remove_watch): Don't check QCdbus_type_unix_fd for SYMBOLP, it
4331 is a constant.
4332 (Fdbus_init_bus, xd_read_queued_messages): Bus can be a symbol or
4333 a string. Handle both cases.
4334 (Fdbus_call_method_asynchronously, Fdbus_register_signal)
4335 (Fdbus_register_method): Use Qinvalid_function.
4336
af4c0e28
JB
43372011-05-06 Juanma Barranquero <lekktu@gmail.com>
4338
4339 * makefile.w32-in: Update dependencies.
4340 (LISP_H): Add inttypes.h and stdin.h.
4341 (PROCESS_H): Add unistd.h.
4342
c51453d9
EZ
43432011-05-06 Eli Zaretskii <eliz@gnu.org>
4344
4345 * lread.c: Include limits.h (fixes the MS-Windows build broken by
4346 2011-05-06T07:13:19Z!eggert@cs.ucla.edu).
4347
8ff0ac3c 43482011-05-06 Paul Eggert <eggert@cs.ucla.edu>
c032b5f8 4349
4c4b566b
PE
4350 * image.c (Finit_image_library) [!HAVE_NTGUI]: Omit unused local.
4351
aab2b9b5
PE
4352 * term.c (vfatal): Remove stray call to va_end.
4353 It's not needed and the C Standard doesn't allow it here anyway.
4354
c378da0b
PE
4355 Use C99's va_copy to avoid undefined behavior on x86-64 GNU/Linux.
4356 * eval.c (verror): doprnt a copy of ap, not the original. (Bug#8545)
4357
288b08c7
PE
4358 * eval.c (verror): OK to create a string of up to MOST_POSITIVE_FIXNUM
4359 bytes.
4360
e3601888
PE
4361 * term.c: Don't include <stdarg.h>, as <lisp.h> does that.
4362
db6c0e74
PE
4363 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork clobbering.
4364
dd5963ea
PE
4365 * process.c (Fformat_network_address): Fix typo: args2 -> *args2.
4366
88c9450f
PE
4367 * xmenu.c (set_frame_menubar): Fix typo: int * -> int (3 times).
4368
2f9442b8
PE
4369 * coding.c (detect_coding_charset): Fix typo: * 2 -> *4 (Bug#8601).
4370
c032b5f8
PE
4371 * charset.h (struct charset.code_space): Now has 15 elements, not 16.
4372 * charset.c (Fdefine_charset_internal): Don't initialize
4373 charset.code_space[15]. The value was garbage, on hosts with
2d38271b 4374 32-bit int (Bug#8600).
a108c10b
PE
4375
4376 * lread.c (read_integer): Be more consistent with string-to-number.
4377 Use string_to_number to do the actual conversion; this avoids
4378 rounding errors and fixes some other screwups. Without this fix,
4379 for example, #x1fffffffffffffff was misread as -2305843009213693952.
4380 (digit_to_number): Move earlier, for benefit of read_integer.
4381 Return -1 if the digit is out of range for the base, -2 if it is
48e400f0 4382 not a digit in any supported base. (Bug#8602)
a108c10b 4383
ad5f9eea
PE
4384 * doprnt.c (doprnt): Support arbitrary pI values, such as "I64".
4385
aec1708a
PE
4386 * dispnew.c (scrolling_window): Return 1 if we scrolled,
4387 to match comment at start of function. This also removes a
4388 GCC warning about overflow in a 32+64-bit port.
4389
47be4ab5
PE
4390 * lisp.h (EMACS_INT, EMACS_UINT, BITS_PER_EMACS_INT, pI): Simplify.
4391
371cac43
PE
4392 * dbusbind.c: Do not use XPNTR on a value that may be an integer.
4393 Reported by Stefan Monnier in
4394 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00919.html>.
04f2d78b
CB
4395 (xd_remove_watch, Fdbus_init_bus, xd_read_queued_messages):
4396 Use SYMBOLP-guarded XSYMBOL, not XPNTR.
371cac43 4397
d01a7826
PE
4398 * lisp.h (EMACS_INTPTR): Remove. All uses changed to intptr_t.
4399 (EMACS_UINTPTR): Likewise, with uintptr_t.
4400
7fd47d5c
PE
4401 * lisp.h: Prefer 64-bit EMACS_INT if available.
4402 (EMACS_INT, EMACS_UINT, BITS_PER_EMACS_INT, pI): Define to 64-bit
4403 on 32-bit hosts that have 64-bit int, so that they can access
4404 large files.
122b0c86
PE
4405 However, temporarily disable this change unless the temporary
4406 symbol WIDE_EMACS_INT is defined.
7fd47d5c 4407
8727937b
PE
4408 * lread.c, process.c: Do not include <inttypes.h>; lisp.h does it now.
4409
8ac068ac
PE
4410 Prefer intptr_t/uintptr_t for integers the same widths as pointers.
4411 This removes an assumption that EMACS_INT and long are the same
4412 width as pointers. The assumption is true for Emacs porting targets
4413 now, but we want to make other targets possible.
4414 * lisp.h: Include <inttypes.h>, for INTPTR_MAX, UINTPTR_MAX.
4415 (EMACS_INTPTR, EMACS_UINTPTR): New macros.
4416 In the rest of the code, change types of integers that hold casted
4417 pointers to EMACS_INTPTR and EMACS_UINTPTR, systematically
4418 replacing EMACS_INT, long, EMACS_UINT, and unsigned long.
4419 (XTYPE): Don't cast arg to EMACS_UINT; normally is not needed.
4420 (XSET): Cast type of XTYPE arg to EMACS_INTPTR; it is needed here.
4421 No need to cast type when ORing.
4422 (XPNTR): Return a value of type EMACS_INTPTR or EMACS_UINTPTR.
4423 * alloc.c (lisp_align_malloc): Remove a no-longer-needed cast.
4424 * doc.c (store_function_docstring): Use EMACS_INTPTR, so as not to
4425 assume EMACS_INT is the same width as char *.
4426 * gtkutil.c (xg_gtk_scroll_destroy, xg_tool_bar_button_cb):
4427 (xg_tool_bar_callback, xg_tool_bar_help_callback, xg_make_tool_item):
4428 Remove no-longer-needed casts.
4429 (xg_create_scroll_bar, xg_tool_bar_button_cb, xg_tool_bar_callback):
4430 (xg_tool_bar_help_callback, xg_make_tool_item):
4431 Use EMACS_INTPTR to hold an integer
4432 that will be cast to void *; this can avoid a GCC warning
4433 if EMACS_INT is not the same width as void *.
4434 * menu.c (find_and_call_menu_selection): Remove no-longer-needed cast.
4435 * xdisp.c (display_echo_area_1, resize_mini_window_1):
4436 (current_message_1, set_message_1):
4437 Use a local to convert to proper width without a cast.
4438 * xmenu.c (dialog_selection_callback): Likewise.
4439
ede49d71
PE
4440 * sysdep.c (get_random): Don't assume EMACS_INT is no wider than long.
4441 Also, don't assume VALBITS / RAND_BITS is less than 5,
4442 and don't rely on undefined behavior when shifting a 1 left into
4443 the sign bit.
4444 * lisp.h (get_random): Change signature to match.
4445
2f30ecd0
PE
4446 * lread.c (hash_string): Use size_t, not int, for hash computation.
4447 Normally we prefer signed values; but hashing is special, because
4448 it's better to use unsigned division on hash table sizes so that
4449 the remainder is nonnegative. Also, size_t is the natural width
4450 for hashing into memory. The previous code used 'int', which doesn't
4451 retain enough info to hash well into very large tables.
4452 (oblookup, oblookup_last_bucket_number, Funintern): Likewise.
4453
2a866e7b
PE
4454 * dbusbind.c: Don't possibly lose pointer info when converting.
4455 (xd_remove_watch, Fdbus_init_bus, xd_read_queued_messages):
4456 Use XPNTR rather than XHASH, so that the high-order bits of
4457 the pointer aren't lost when converting through void *.
4458
51639eac
PE
4459 * eval.c (Fautoload): Don't double-shift a pointer.
4460
92394119
PE
4461 * fns.c (Frandom): Let EMACS_UINT be wider than unsigned long.
4462
dbdb9a7c
JB
44632011-05-06 Juanma Barranquero <lekktu@gmail.com>
4464
4465 * gnutls.c (DEF_GNUTLS_FN):
4466 * image.c (DEF_IMGLIB_FN): Make function pointers static.
4467
db7a0b4f
AS
44682011-05-05 Andreas Schwab <schwab@linux-m68k.org>
4469
4470 * lread.c (lisp_file_lexically_bound_p): Stop scanning at end
4471 marker. (Bug#8610)
4472
f7ff1b0f 44732011-05-05 Eli Zaretskii <eliz@gnu.org>
fab624aa
EZ
4474
4475 * w32heap.c (allocate_heap) [USE_LISP_UNION_TYPE || USE_LSB_TAG]:
4476 New version that can reserve upto 2GB of heap space.
4477
f7ff1b0f 44782011-05-05 Chong Yidong <cyd@stupidchicken.com>
45cb8994
CY
4479
4480 * nsfns.m (Fns_read_file_name): Doc fix (Bug#8534).
4481
639c109b
TZ
44822011-05-05 Teodor Zlatanov <tzz@lifelogs.com>
4483
4484 * gnutls.c (fn_gnutls_certificate_set_x509_key_file): Add alias to
4485 `gnutls_certificate_set_x509_key_file'.
4486
d2127135
JB
44872011-05-05 Juanma Barranquero <lekktu@gmail.com>
4488
4489 * makefile.w32-in ($(BLD)/image.$(O), $(BLD)/process.$(O)):
4490 Update dependencies.
4491
e968f4f3
JB
44922011-05-04 Juanma Barranquero <lekktu@gmail.com>
4493
4494 * gnutls.h (emacs_gnutls_write, emacs_gnutls_read):
4495 * gnutls.c (emacs_gnutls_write, emacs_gnutls_read):
4496 Remove unused parameter `fildes'.
4497 * process.c (read_process_output, send_process): Don't pass it.
4498
84d358f0
JB
44992011-05-04 Juanma Barranquero <lekktu@gmail.com>
4500
4501 Fix previous change: the library cache is defined in w32.c.
4502 * image.c (CACHE_IMAGE_TYPE) [!HAVE_NTGUI]: Define to noop.
4503 (Finit_image_library): Wrap Vlibrary_cache on "#ifdef HAVE_NTGUI".
4504
0898ca10
JB
45052011-05-04 Juanma Barranquero <lekktu@gmail.com>
4506
4507 Implement dynamic loading of GnuTLS on Windows.
4508
4509 * gnutls.h (GNUTLS_EMACS_ERROR_NOT_LOADED): New macro.
4510 (emacs_gnutls_write, emacs_gnutls_read): Mark as extern.
4511 (emacs_gnutls_record_check_pending, emacs_gnutls_transport_set_errno):
4512 Declare.
4513
4514 * gnutls.c (Qgnutls_dll): Define.
4515 (DEF_GNUTLS_FN, LOAD_GNUTLS_FN): New macros.
4516 (gnutls_*): Declare function pointers.
4517 (init_gnutls_functions): New function to initialize function pointers.
4518 (emacs_gnutls_handshake, Fgnutls_error_string, Fgnutls_deinit)
4519 (emacs_gnutls_global_init, Fgnutls_bye): Use function pointers.
4520 (emacs_gnutls_record_check_pending, emacs_gnutls_transport_set_errno):
4521 Wrappers for gnutls_record_check_pending and gnutls_transport_set_errno.
4522 (emacs_gnutls_write, emacs_gnutls_read)
4523 (emacs_gnutls_handle_error, Fgnutls_error_fatalp)
4524 (Fgnutls_available_p): New function.
4525 (Fgnutls_boot): Call Fgnutls_available_p. Use function pointers.
4526 (syms_of_gnutls) <Qgnutls_dll>: Initialize and staticpro it.
4527 (syms_of_gnutls) <Sgnutls_available_p>: defsubr it.
4528
4529 * image.c: Include w32.h.
4530 (Vimage_type_cache): Delete.
4531 (syms_of_image) <Vimage_type_cache>: Don't initialize and staticpro it.
4532 (CACHE_IMAGE_TYPE, Finit_image_library): Use Vlibrary_cache instead.
4533 (w32_delayed_load): Move to w32.c.
4534
4535 * w32.h (VlibraryCache, QCloaded_from, w32_delayed_load): Declare.
4536
4537 * w32.c (QCloaded_from, Vlibrary_cache): Define.
4538 (w32_delayed_load): Move from image.c. When loading a library, record
4539 its filename in the :loaded-from property of the library id.
4540 (globals_of_w32) <QCloaded_from, Vlibrary_cache>:
4541 Initialize and staticpro them.
4542 (emacs_gnutls_pull, emacs_gnutls_push): Call emacs_gnutls_* functions.
4543
4544 * process.c: Include lisp.h before w32.h, not after.
4545 (wait_reading_process_output): Call emacs_gnutls_record_check_pending
4546 instead of gnutls_record_check_pending.
4547
4548 * callproc.c, emacs.c: Include lisp.h before w32.h, not after.
4549
ff4de4aa
TZ
45502011-05-04 Teodor Zlatanov <tzz@lifelogs.com>
4551
4552 * gnutls.c (Fgnutls_boot): Support :keylist and :crlfiles options
4553 instead of :keyfiles. Give GnuTLS the keylist and the CRL lists
4554 as passed in.
4555
abe95abb
JD
45562011-05-03 Jan Djärv <jan.h.d@swipnet.se>
4557
4558 * xterm.c (x_set_frame_alpha): Do not set property on anything
4559 else than FRAME_X_OUTER_WINDOW (Bug#8608).
4560
e16e55d4
JB
45612011-05-02 Juanma Barranquero <lekktu@gmail.com>
4562
4563 * sysdep.c (get_tty_size) [WINDOWSNT]: Implement. (Bug#8596)
4564
bafcf6a5
JB
45652011-05-02 Juanma Barranquero <lekktu@gmail.com>
4566
4567 * gnutls.c (Qgnutls_log_level, Qgnutls_code, Qgnutls_anon)
4568 (Qgnutls_x509pki, Qgnutls_e_interrupted, Qgnutls_e_again)
4569 (Qgnutls_e_invalid_session, Qgnutls_e_not_ready_for_handshake)
4570 (gnutls_global_initialized, Qgnutls_bootprop_priority)
4571 (Qgnutls_bootprop_trustfiles, Qgnutls_bootprop_keyfiles)
4572 (Qgnutls_bootprop_callbacks, Qgnutls_bootprop_loglevel)
4573 (Qgnutls_bootprop_hostname, Qgnutls_bootprop_verify_flags)
4574 (Qgnutls_bootprop_verify_error, Qgnutls_bootprop_verify_hostname_error)
4575 (Qgnutls_bootprop_callbacks_verify): Make static.
4576
e7a6747f
AS
45772011-05-01 Andreas Schwab <schwab@linux-m68k.org>
4578
19ed11ba
AS
4579 * callproc.c: Indentation fixup.
4580
e7a6747f 4581 * sysdep.c (wait_for_termination_1): Make static.
04f2d78b
CB
4582 (wait_for_termination, interruptible_wait_for_termination):
4583 Move after wait_for_termination_1.
e7a6747f 4584
1ef14cb4
LMI
45852011-05-01 Lars Magne Ingebrigtsen <larsi@gnus.org>
4586
4587 * sysdep.c (interruptible_wait_for_termination): New function
4588 which is like wait_for_termination, but allows keyboard
4589 interruptions.
4590
4591 * callproc.c (Fcall_process): Add (:file "file") as an option for
4592 the STDOUT buffer.
4593 (Fcall_process_region): Ditto.
4594
330d880c
EZ
45952011-04-30 Eli Zaretskii <eliz@gnu.org>
4596
8db90b73
EZ
4597 * dosfns.c (Fint86, Fdos_memget, Fdos_memput): Use `ASIZE (FOO)'
4598 rather than `XVECTOR (FOO)->size'.
4599
330d880c
EZ
4600 * process.c: Remove HAVE_INTTYPES_H condition from inclusion of
4601 inttypes.h, as a gnulib replacement is used if it not available in
4602 system headers.
4603
15cbd324
EZ
46042011-04-21 Eli Zaretskii <eliz@gnu.org>
4605
4606 Lift the MOST_POSITIVE_FIXNUM/4 limitation on visited files.
4607 * fileio.c (Finsert_file_contents): Don't limit file size to 1/4
4608 of MOST_POSITIVE_FIXNUM. (Bug#8528)
4609
4610 * coding.c (coding_alloc_by_realloc): Error out if destination
4611 will grow beyond MOST_POSITIVE_FIXNUM.
4612 (decode_coding_emacs_mule): Abort if there isn't enough place in
4613 charbuf for the composition carryover bytes. Reserve an extra
4614 space for up to 2 characters produced in a loop.
4615 (decode_coding_iso_2022): Abort if there isn't enough place in
4616 charbuf for the composition carryover bytes.
4617
46182011-04-21 Eli Zaretskii <eliz@gnu.org>
afda1437 4619
ae940cca
EZ
4620 * doprnt.c (doprnt) [!HAVE_LONG_LONG_INT]: Error out instead of
4621 aborting when %lld or %lll format is passed.
4622 [!HAVE_UNSIGNED_LONG_LONG_INT]: Error out instead of aborting when
4623 %llo or %llx format is passed. (Bug#8545)
4624
03ab8921
EZ
4625 * window.c (window_scroll_line_based): Use a marker instead of
4626 simple variables to record original value of point. (Bug#7952)
4627
afda1437
EZ
4628 * doprnt.c (doprnt): Fix the case where a multibyte sequence
4629 produced by %s or %c overflows available buffer space. (Bug#8545)
4630
f76dee0c
PE
46312011-04-28 Paul Eggert <eggert@cs.ucla.edu>
4632
4633 * doprnt.c (doprnt): Omit useless test; int overflow check (Bug#8545).
283cdbef 4634 (SIZE_MAX): Move defn after all includes, as they might #define it.
f76dee0c 4635
fdc5744d
JB
46362011-04-28 Juanma Barranquero <lekktu@gmail.com>
4637
4638 * w32.c (init_environment): Warn about defaulting HOME to C:\.
4639
638f053a
JB
46402011-04-28 Juanma Barranquero <lekktu@gmail.com>
4641
4642 * keyboard.c (Qdelayed_warnings_hook): Define.
4643 (command_loop_1): Run `delayed-warnings-hook'
4644 if Vdelayed_warnings_list is non-nil.
4645 (syms_of_keyboard) <delayed-warnings-hook>: DEFSYM it.
4646 (syms_of_keyboard) <delayed-warnings-list>: DEFVAR_LISP it.
4647
d178f871
EZ
46482011-04-28 Eli Zaretskii <eliz@gnu.org>
4649
4650 * doprnt.c (doprnt): Don't return value smaller than the buffer
4651 size if the message was truncated. (Bug#8545).
4652
b124fd93
JB
46532011-04-28 Juanma Barranquero <lekktu@gmail.com>
4654
4655 * w32fns.c (Fx_change_window_property, Fx_delete_window_property)
4656 (Fx_window_property): #if-0 the whole functions, not just the bodies.
4657
e810457d
PE
46582011-04-27 Paul Eggert <eggert@cs.ucla.edu>
4659
4660 * doprnt.c (doprnt): Support "ll" length modifier, for long long.
4661
ea51cceb
JB
46622011-04-27 Juanma Barranquero <lekktu@gmail.com>
4663
4664 * makefile.w32-in: Update dependencies.
4665
94dcfacf
EZ
46662011-04-27 Eli Zaretskii <eliz@gnu.org>
4667
4668 Improve `doprnt' and its usage. (Bug#8545)
4669 * doprnt.c (doprnt): Make sure `format' is never accessed beyond
4670 `format_end'. Remove support for %l as a conversion specifier.
4671 Don't use xrealloc. Improve diagnostics when the %l size modifier
4672 is used. Update the commentary.
4673
4674 * eval.c (verror): Simplify calculation of size_t.
4675
4676 * coding.c (Ffind_operation_coding_system): Fix diagnostic error
4677 messages.
4678
f61f41d7
PE
46792011-04-27 Yoshiaki Kasahara <kasahara@nc.kyushu-u.ac.jp> (tiny change)
4680
4681 * buffer.c (init_buffer) [USE_MMAP_FOR_BUFFERS]: Adjust to aliasing
4682 change.
4683
96fb4434
PE
46842011-04-27 Paul Eggert <eggert@cs.ucla.edu>
4685
4686 * nsmenu.m: Replace all uses of XVECTOR with ASIZE and AREF.
4687 This makes this file independent of the recent pseudovector change.
4688
671875da 46892011-04-26 Paul Eggert <eggert@cs.ucla.edu>
eab3844f 4690
69e9b5a3
PE
4691 * keyboard.c (handle_user_signal): Fix pointer signedness problem.
4692
b5f869a7 4693 * gnutls.c (emacs_gnutls_handle_error): Remove unused local.
7754e151 4694 (Fgnutls_boot): gnutls_certificate_verify_peers2 wants unsigned *.
8d4c3955 4695 Remove unused local.
c8926152 4696 (emacs_gnutls_write): Don't use uninitialized rtnval if nbyte <= 0.
080e5a8d 4697
841a1577 4698 * lisp.h: Fix a problem with aliasing and vector headers. (Bug#8546)
04f2d78b
CB
4699 GCC 4.6.0 optimizes based on type-based alias analysis.
4700 For example, if b is of type struct buffer * and v of type struct
eab3844f
PE
4701 Lisp_Vector *, then gcc -O2 was incorrectly assuming that &b->size
4702 != &v->size, and therefore "v->size = 1; b->size = 2; return
4703 v->size;" must therefore return 1. This assumption is incorrect
4704 for Emacs, since it type-puns struct Lisp_Vector * with many other
4705 types. To fix this problem, this patch adds a new type struct
f904488f 4706 vectorlike_header that documents the constraints on layout of vectors
eab3844f
PE
4707 and pseudovectors, and helps optimizing compilers not get fooled
4708 by Emacs's type punning. It also adds the macros XSETTYPED_PVECTYPE
4709 XSETTYPED_PSEUDOVECTOR, TYPED_PSEUDOVECTORP, for similar reasons.
f904488f
PE
4710 * lisp.h (XSETTYPED_PVECTYPE): New macro, specifying the name of
4711 the size member.
eab3844f
PE
4712 (XSETPVECTYPE): Rewrite in terms of new macro.
4713 (XSETPVECTYPESIZE): New macro, specifying both type and size.
4714 This is a bit clearer, and further avoids the possibility of
4715 undesirable aliasing.
4716 (XSETTYPED_PSEUDOVECTOR): New macro, specifying the size.
f904488f 4717 (XSETPSEUDOVECTOR): Rewrite in terms of XSETTYPED_PSEUDOVECTOR.
eab3844f
PE
4718 (XSETSUBR): Rewrite in terms of XSETTYPED_PSEUDOVECTOR and XSIZE,
4719 since Lisp_Subr is a special case (no "next" field).
04f2d78b
CB
4720 (ASIZE): Now uses header.size rather than size.
4721 All previous uses of XVECTOR (foo)->size replaced to use this macro,
f904488f
PE
4722 to avoid the hassle of writing XVECTOR (foo)->header.size.
4723 (struct vectorlike_header): New type.
eab3844f
PE
4724 (TYPED_PSEUDOVECTORP): New macro, also specifying the C type of the
4725 object, to help avoid aliasing.
4726 (PSEUDOVECTORP): Rewrite in terms of TYPED_PSEUDOVECTORP.
4727 (SUBRP): Likewise, since Lisp_Subr is a special case.
4728 * lisp.h (struct Lisp_Vector, struct Lisp_Char_Table):
4729 (struct Lisp_Sub_Char_Table, struct Lisp_Bool_Vector):
4730 (struct Lisp_Hash_Table): Combine first two members into a single
f904488f 4731 struct vectorlike_header member. All uses of "size" and "next" members
eab3844f
PE
4732 changed to be "header.size" and "header.next".
4733 * buffer.h (struct buffer): Likewise.
4734 * font.h (struct font_spec, struct font_entity, struct font): Likewise.
4735 * frame.h (struct frame): Likewise.
4736 * process.h (struct Lisp_Process): Likewise.
4737 * termhooks.h (struct terminal): Likewise.
4738 * window.c (struct save_window_data, struct saved_window): Likewise.
4739 * window.h (struct window): Likewise.
4740 * alloc.c (allocate_buffer, Fmake_bool_vector, allocate_pseudovector):
4741 Use XSETPVECTYPESIZE, not XSETPVECTYPE, to avoid aliasing problems.
4742 * buffer.c (init_buffer_once): Likewise.
4743 * lread.c (defsubr): Use XSETTYPED_PVECTYPE, since Lisp_Subr is a
4744 special case.
4745 * process.c (Fformat_network_address): Use local var for size,
4746 for brevity.
4747
0df1eac5
PE
4748 * bytecode.c (exec_byte_code): Don't use XVECTOR before CHECK_VECTOR.
4749
847ab9d1 4750 Make the Lisp reader and string-to-float more consistent (Bug#8525)
452f4150
PE
4751 * data.c (atof): Remove decl; no longer used or needed.
4752 (digit_to_number): Move to lread.c.
4753 (Fstring_to_number): Use new string_to_number function, to be
4754 consistent with how the Lisp reader treats infinities and NaNs.
4755 Do not assume that floating-point numbers represent EMACS_INT
4756 without losing information; this is not true on most 64-bit hosts.
4757 Avoid double-rounding errors, by insisting on integers when
4758 parsing non-base-10 numbers, as the documentation specifies.
4759 * lisp.h (string_to_number): New decl, replacing ...
4760 (isfloat_string): Remove.
bc0a5c13 4761 * lread.c: Include <inttypes.h>, for uintmax_t and strtoumax.
d78050d6 4762 (read1): Do not accept +. and -. as integers; this
452f4150
PE
4763 appears to have been a coding error. Similarly, do not accept
4764 strings like +-1e0 as floating point numbers. Do not report
4765 overflow for integer overflows unless the base is not 10 which
4766 means we have no simple and reliable way to continue.
4767 Break out the floating-point parsing into a new
4768 function string_to_number, so that Fstring_to_number parses
4769 floating point numbers consistently with the Lisp reader.
04f2d78b 4770 (digit_to_number): Move here from data.c. Make it static inline.
452f4150
PE
4771 (E_CHAR, EXP_INT): Remove, replacing with ...
4772 (E_EXP): New macro, to solve the "1.0e+" problem mentioned below.
4773 (string_to_number): New function, replacing isfloat_string.
4774 This function checks for valid syntax and produces the resulting
4775 Lisp float number too. Rework it so that string-to-number
bc0a5c13 4776 no longer mishandles examples like "1.0e+". Use strtoumax,
d78050d6
PE
4777 so that overflow for non-base-10 numbers is reported only when
4778 there's no portable and simple way to convert to floating point.
452f4150 4779
67769ffc
PE
4780 * textprop.c (set_text_properties_1): Rewrite for clarity,
4781 and to avoid GCC warning about integer overflow.
4782
c20db43f
PE
4783 * intervals.h (struct interval): Use EMACS_INT for members
4784 where EMACS_UINT might cause problems. See
4785 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00514.html>.
4786 (CHECK_TOTAL_LENGTH): Remove cast to EMACS_INT; no longer needed.
4787 * intervals.c (interval_deletion_adjustment): Now returns EMACS_INT.
4788 All uses changed.
37aa2f85
PE
4789 (offset_intervals): Tell GCC not to worry about length overflow
4790 when negating a negative length.
c20db43f 4791
2538aa2f
PE
4792 * alloc.c (overrun_check_malloc, overrun_check_realloc): Now static.
4793 (overrun_check_free): Likewise.
4794
f2d3008d
PE
4795 * alloc.c (SDATA_SIZE) [!GC_CHECK_STRING_BYTES]: Avoid runtime check
4796 in the common case where SDATA_DATA_OFFSET is a multiple of Emacs
4797 word size.
4798
ec8df744
PE
4799 * gnutls.c: Fix problems found by GCC 4.6.0 on Ubuntu 10.10.
4800 (gnutls_make_error): Rename local to avoid shadowing.
4801 (gnutls_emacs_global_deinit): ifdef out; not used.
4802 (Fgnutls_boot): Use const for pointer to readonly storage.
4803 Comment out unused local. Fix pointer signedness problems.
4804
640ee02d
PE
4805 * lread.c (openp): Don't stuff size_t into an 'int'.
4806 Use <= on length, not < on length + 1, to avoid GCC 4.6.0 warning
4807 about possible signed overflow.
4808
6048fb2a
PE
4809 * gtkutil.c: Fix problems found by GCC 4.6.0 on Ubuntu 10.10.
4810 (GDK_KEY_g): Don't define if already defined.
4811 (xg_prepare_tooltip): Avoid pointer signedness problem.
4812 (xg_set_toolkit_scroll_bar_thumb): Redo to avoid two casts.
4813
fa3c87e1
PE
4814 * process.c (Fnetwork_interface_info): Avoid left-shift undefined
4815 behavior with 1 << 31. GCC 4.6.0 warns about this on 32-bit hosts.
4816
2172544b
PE
4817 * xfns.c (Fx_window_property): Simplify a bit,
4818 to make a bit faster and to avoid GCC 4.6.0 warning.
4819 * xselect.c (x_get_window_property, x_handle_dnd_message): Likewise.
4820
9b821a21
PE
4821 * fns.c (internal_equal): Don't assume size_t fits in int.
4822
3c616cfa
PE
4823 * alloc.c (compact_small_strings): Tighten assertion a little.
4824
c2982e87
PE
4825 Replace pEd with more-general pI, and fix some printf arg casts.
4826 * lisp.h (pI): New macro, generalizing old pEd macro to other
4827 conversion specifiers. For example, use "...%"pI"d..." rather
4828 than "...%"pEd"...".
4829 (pEd): Remove. All uses replaced with similar uses of pI.
4830 * src/m/amdx86-64.h, src/m/ia64.h, src/m/ibms390x.h: Likewise.
4831 * alloc.c (check_pure_size): Don't overflow by converting size to int.
4832 * bidi.c (bidi_dump_cached_states): Use pI to avoid cast.
4833 * data.c (Fnumber_to_string): Use pI instead of if-then-else-abort.
4834 * dbusbind.c (xd_append_arg): Use pI to avoid cast.
4835 (Fdbus_method_return_internal, Fdbus_method_error_internal): Likewise.
4836 * font.c (font_unparse_xlfd): Avoid potential buffer overrun on
4837 64-bit hosts.
4838 (font_unparse_xlfd, font_unparse_fcname): Use pI to avoid casts.
4839 * keyboard.c (record_char, modify_event_symbol): Use pI to avoid casts.
4840 * print.c (safe_debug_print, print_object): Likewise.
4841 (print_object): Don't overflow by converting EMACS_INT or EMACS_UINT
4842 to int.
6f04d126
PE
4843 Use pI instead of if-then-else-abort. Use %p to avoid casts,
4844 avoiding the 0 flag, which is not portable.
c2982e87
PE
4845 * process.c (Fmake_network_process): Use pI to avoid cast.
4846 * region-cache.c (pp_cache): Likewise.
4847 * xdisp.c (decode_mode_spec): Likewise.
4848 * xrdb.c (x_load_resources) [USE_MOTIF]: Use pI to avoid undefined
4849 behavior on 64-bit hosts with printf arg.
6f04d126 4850 * xselect.c (x_queue_event): Use %p to avoid casts, avoiding 0 flag.
c2982e87
PE
4851 (x_stop_queuing_selection_requests): Likewise.
4852 (x_get_window_property): Don't truncate byte count to an 'int'
4853 when tracing.
0b432f21 4854
5e073ec7
PE
4855 * frame.c (frame_name_fnn_p): Get rid of strtol, which isn't right
4856 here, since it parses constructs like leading '-' and spaces,
4857 which are not wanted; and it overflows with large numbers.
4858 Instead, simply match F[0-9]+, which is what is wanted anyway.
4859
36372bf9
PE
4860 * alloc.c: Remove unportable assumptions about struct layout.
4861 (SDATA_SELECTOR, SDATA_DATA_OFFSET): New macros.
4862 (SDATA_OF_STRING, SDATA_SIZE, allocate_string_data):
4863 (allocate_vectorlike, make_pure_vector): Use the new macros,
4864 plus offsetof, to remove unportable assumptions about struct layout.
4865 These assumptions hold on all porting targets that I know of, but
4866 they are not guaranteed, they're easy to remove, and removing them
4867 makes further changes easier.
4868
0b432f21
PE
4869 * alloc.c (BLOCK BYTES): Fix typo by changing "ablock" to "ablocks".
4870 This doesn't fix a bug but makes the code clearer.
bfd1c781
PE
4871 (string_overrun_cookie): Now const. Use initializers that
4872 don't formally overflow signed char, to avoid warnings.
000098c1
PE
4873 (allocate_string_data) [GC_CHECK_STRING_OVERRUN]: Fix typo that
4874 can cause Emacs to crash when string overrun checking is enabled.
c7bda33c
PE
4875 (allocate_buffer): Don't assume sizeof (struct buffer) is a
4876 multiple of sizeof (EMACS_INT); it need not be, if
4877 alignof(EMACS_INT) < sizeof (EMACS_INT).
d0f4e1f5 4878 (check_sblock, check_string_bytes, check_string_free_list): Protoize.
0b432f21 4879
895009e1
JB
48802011-04-26 Juanma Barranquero <lekktu@gmail.com>
4881
4882 * keyboard.c (QCrtl): Rename from Qrtl. All uses changed.
4883
6a7a1b0b
TZ
48842011-04-26 Teodor Zlatanov <tzz@lifelogs.com>
4885
4886 * gnutls.c (emacs_gnutls_handshake): Return an error if we're not
b5f869a7 4887 supposed to be handshaking. (Bug#8556)
6a7a1b0b
TZ
4888 Reported by Paul Eggert <eggert@cs.ucla.edu>.
4889
841a1577 48902011-04-26 Daniel Colascione <dan.colascione@gmail.com>
0438ce91
DC
4891
4892 * lisp.h (Qdebug): List symbol.
895009e1 4893 * eval.c (Qdebug): Restore global linkage.
0438ce91
DC
4894 * keyboard.c (debug-on-event): New variable.
4895 (handle_user_signal): Break into debugger when debug-on-event
4896 matches the current signal symbol.
4897
f2d3ba6f
DN
48982011-04-25 Dan Nicolaescu <dann@ics.uci.edu>
4899
4900 * alloc.c (check_sblock, check_string_bytes)
4901 (check_string_free_list): Convert to standard C.
4902
42ce4c63
TZ
49032011-04-25 Teodor Zlatanov <tzz@lifelogs.com>
4904
4905 * w32.c (emacs_gnutls_push): Fix typo.
4906
825cd63c
EZ
49072011-04-25 Eli Zaretskii <eliz@gnu.org>
4908
fb11d64d
EZ
4909 * gnutls.c (emacs_gnutls_handshake): Avoid compiler warnings about
4910 "cast to pointer from integer of different size".
4911
825cd63c
EZ
4912 Improve doprnt and its use in verror. (Bug#8545)
4913 * doprnt.c (doprnt): Document the set of format control sequences
4914 supported by the function. Use SAFE_ALLOCA instead of always
4915 using `alloca'.
4916
4917 * eval.c (verror): Don't limit the buffer size at size_max-1, that
4918 is one byte too soon. Don't use xrealloc; instead xfree and
4919 xmalloc anew.
4920
e061a11b
TZ
49212011-04-24 Teodor Zlatanov <tzz@lifelogs.com>
4922
4923 * gnutls.h: Add GNUTLS_STAGE_CALLBACKS enum to denote we're in the
4924 callbacks stage.
4925
4926 * gnutls.c: Renamed global_initialized to
4927 gnutls_global_initialized. Added internals for the
4928 :verify-hostname-error, :verify-error, and :verify-flags
4929 parameters of `gnutls-boot' and documented those parameters in the
4930 docstring. Start callback support.
9173deec
JB
4931 (emacs_gnutls_handshake): Add Woe32 support. Retry handshake
4932 unless a fatal error occurred. Call gnutls_alert_send_appropriate
4933 on error. Return error code.
e061a11b
TZ
4934 (emacs_gnutls_write): Call emacs_gnutls_handle_error.
4935 (emacs_gnutls_read): Likewise.
4936 (Fgnutls_boot): Return handshake error code.
4937 (emacs_gnutls_handle_error): New function.
4938 (wsaerror_to_errno): Likewise.
4939
4940 * w32.h (emacs_gnutls_pull): Add prototype.
4941 (emacs_gnutls_push): Likewise.
4942
4943 * w32.c (emacs_gnutls_pull): New function for GnuTLS on Woe32.
4944 (emacs_gnutls_push): Likewise.
4945
49462011-04-24 Claudio Bley <claudio.bley@gmail.com> (tiny change)
4947
4948 * process.c (wait_reading_process_output): Check if GnuTLS
4949 buffered some data internally if no FDs are set for TLS
4950 connections.
4951
4952 * makefile.w32-in (OBJ2): Add gnutls.$(O).
4953 (LIBS): Link to USER_LIBS.
4954 ($(BLD)/gnutls.$(0)): New target.
4955
fa6996bc
EZ
49562011-04-24 Eli Zaretskii <eliz@gnu.org>
4957
eb35682e
EZ
4958 * xdisp.c (handle_single_display_spec): Rename the
4959 display_replaced_before_p argument into display_replaced_p, to
4960 make it consistent with the commentary. Fix typos in the
4961 commentary.
4962
e2ad650c
EZ
4963 * textprop.c (syms_of_textprop): Remove dead code.
4964 (copy_text_properties): Delete obsolete commentary about an
4965 interface that was deleted long ago. Fix typos in the description
4966 of arguments.
4967
1b2de274
EZ
4968 * msdos.c (XMenuActivate, XMenuAddSelection): Adjust argument list
4969 to changes in oldXMenu/XMenu.h from 2011-04-16.
4970 <menu_help_message, prev_menu_help_message>: Constify.
4971 (IT_menu_make_room): menu->help_text is now `const char **';
4972 adjust.
4973
4974 * msdos.h (XMenuActivate, XMenuAddSelection): Adjust prototypes
4975 to changes in oldXMenu/XMenu.h from 2011-04-16.
4976 (struct XMenu): Declare `help_text' `const char **'.
4977
4978 * xfaces.c <Qunspecified>: Make extern again.
4979
4980 * syntax.c: Include sys/types.h before including regex.h, as
4981 required by Posix.
4982
762b15be
EZ
4983 * doc.c (get_doc_string): Improve the format passed to `error'.
4984
4985 * doprnt.c (doprnt): Improve commentary.
4986
4987 * term.c (init_tty) [MSDOS]: Fix 1st argument to maybe_fatal.
4988
4989 * Makefile.in (TAGS): Depend on $(M_FILE) and $(S_FILE), and scan
4990 them with etags.
4991
f1052e5d
EZ
4992 * makefile.w32-in (globals.h): Add a dummy recipe, to make any
4993 changes in globals.h immediately force recompilation.
762b15be
EZ
4994 (TAGS): Depend on $(CURDIR)/m/intel386.h and
4995 $(CURDIR)/s/ms-w32.h.
4996 (TAGS-gmake): Scan $(CURDIR)/m/intel386.h and $(CURDIR)/s/ms-w32.h.
f1052e5d 4997
fa6996bc
EZ
4998 * character.c (Fchar_direction): Function deleted.
4999 (syms_of_character): Don't defsubr it.
5000 <char-direction-table>: Deleted.
5001
e6c3da20
EZ
50022011-04-23 Eli Zaretskii <eliz@gnu.org>
5003
5004 Fix doprnt so it could be used again safely in `verror'. (Bug#8435)
5005 * doprnt.c: Include limits.h.
5006 (SIZE_MAX): New macro.
04f2d78b
CB
5007 (doprnt): Return a size_t value. 2nd arg is now size_t.
5008 Many local variables are now size_t instead of int or unsigned.
e6c3da20
EZ
5009 Improve overflow protection. Support `l' modifier for integer
5010 conversions. Support %l conversion. Don't assume an EMACS_INT
5011 argument for integer conversions and for %c.
5012
5013 * lisp.h (doprnt): Restore prototype.
5014
5015 * makefile.w32-in ($(BLD)/callint.$(O)): Depend on
5016 $(SRC)/character.h.
5017
5018 * Makefile.in (base_obj): Add back doprnt.o.
5019
5020 * deps.mk (doprnt.o): Add back prerequisites.
5021 (callint.o): Depend on character.h.
5022
5023 * eval.c (internal_lisp_condition_case): Include the handler
5024 representation in the error message.
5025 (verror): Call doprnt instead of vsnprintf. Fix an off-by-one bug
5026 when breaking from the loop.
5027
5028 * xdisp.c (vmessage): Call doprnt instead of vsnprintf.
5029
5030 * callint.c (Fcall_interactively): When displaying error message
5031 about invalid control letter, pass the character's codepoint, not
5032 a pointer to its multibyte form. Improve display of the character
5033 in octal and display also its hex code.
5034
5035 * character.c (char_string): Use %x to display the (unsigned)
5036 codepoint of an invalid character, to avoid displaying a bogus
5037 negative value.
5038
5039 * font.c (check_otf_features): Pass SDATA of SYMBOL_NAME to
5040 `error', not SYMBOL_NAME itself.
5041
5042 * coding.c (Fencode_sjis_char, Fencode_big5_char): Use %c for
5043 character arguments to `error'.
5044
5045 * charset.c (check_iso_charset_parameter): Fix incorrect argument
5046 to `error' in error message about FINAL_CHAR argument. Make sure
5047 FINAL_CHAR is a character, and use %c when it is passed as
5048 argument to `error'.
5049
4ffd0d6b 50502011-04-23 Eli Zaretskii <eliz@gnu.org>
97a93095
EZ
5051
5052 * s/ms-w32.h (localtime): Redirect to sys_localtime.
5053
5054 * w32.c: Include <time.h>.
5055 (sys_localtime): New function.
5056
4ffd0d6b 50572011-04-23 Chong Yidong <cyd@stupidchicken.com>
c17819f4
CY
5058
5059 * xdisp.c (init_xdisp): Initialize echo_area_window (Bug#6451).
5060
4ffd0d6b 5061 * buffer.c (syms_of_buffer): Doc fix (Bug#6902).
aac0c6e3 5062
4ffd0d6b 50632011-04-23 Samuel Thibault <sthibault@debian.org> (tiny change)
aac0c6e3 5064
4ffd0d6b
GM
5065 * sysdep.c (wait_for_termination): On GNU Hurd, kill returns -1 on
5066 zombies (Bug#8467).
aac0c6e3 5067
04c56954
EZ
50682011-04-19 Eli Zaretskii <eliz@gnu.org>
5069
5070 * syntax.h (SETUP_SYNTAX_TABLE_FOR_OBJECT): Fix setting of
5071 gl_state.e_property when gl_state.object is Qt.
5072
5073 * insdel.c (make_gap_larger): Remove limitation of buffer size
5074 to <= INT_MAX.
5075
16a43933
CY
50762011-04-18 Chong Yidong <cyd@stupidchicken.com>
5077
5078 * xdisp.c (lookup_glyphless_char_display)
5079 (produce_glyphless_glyph): Handle cons cell entry in
5080 glyphless-char-display.
5081 (Vglyphless_char_display): Document it.
5082
5083 * term.c (produce_glyphless_glyph): Handle cons cell entry in
5084 glyphless-char-display.
5085
4581706e
CY
50862011-04-17 Chong Yidong <cyd@stupidchicken.com>
5087
5088 * xdisp.c (get_next_display_element): Remove unnecessary ifdefs.
5089
5090 * termhooks.h (FRAME_WINDOW_P): Remove duplicated definitions.
5091
5092 * dispextern.h (FACE_SUITABLE_FOR_ASCII_CHAR_P): Add missing
5093 definition for no-X builds.
5094
4887c6e2 50952011-04-16 Paul Eggert <eggert@cs.ucla.edu>
764430a3 5096
fd35b6f9
PE
5097 Static checks with GCC 4.6.0 and non-default toolkits.
5098
5c1ccb01
PE
5099 * s/sol2-6.h, s/unixware.h (PTY_TTY_NAME_SPRINTF): Protoize decl.
5100
006c5daa
PE
5101 * process.c (keyboard_bit_set): Define only if SIGIO.
5102 (send_process_trap): Mark it with NO_RETURN if it doesn't return.
5103 (send_process): Repair possible setjmp clobbering.
5104
efc736d3
PE
5105 * s/usg5-4-common.h (SETUP_SLAVE_PTY): Don't pass extra arg to 'fatal'.
5106
4e2fe2e6
PE
5107 * eval.c: Include <stdio.h>, for vsnprintf on non-GNU/Linux hosts.
5108
f97334a2
PE
5109 * data.c (arith_error): Mark with NO_RETURN if it doesn't return.
5110
4e75f29d
PE
5111 * alloc.c (bytes_used_when_full, SPARE_MEMORY, BYTES_USED):
5112 Define only if needed.
5113
90efadd1
PE
5114 * sysdep.c (_FILE_OFFSET_BITS): Make this hack even uglier
5115 by pacifying GCC about it. Maybe it's time to retire it?
875975e9 5116 * xfaces.c (USG, __TIMEVAL__): Likewise.
90efadd1 5117
3c647824
PE
5118 * dispextern.h (struct redisplay_interface): Rename param
5119 to avoid shadowing.
e264f262 5120 * termhooks.h (struct terminal): Likewise.
761383f4 5121 * xterm.c (xembed_send_message): Likewise.
3c647824 5122
b58c5c4a
PE
5123 * insdel.c (make_gap_smaller): Define only if
5124 USE_MMAP_FOR_BUFFERS || REL_ALLOC || DOUG_LEA_MALLOC.
5125
cad59032
PE
5126 * keyboard.c (read_char): Make a var volatile so longjmp won't clobber
5127 it.
5128
c339dc2e
PE
5129 * emacs.c (MAX_HEAP_BSS_DIFF, my_edata): Move to where they're used,
5130 so that we aren't warned about unused symbols.
5131
91a3e27b
PE
5132 * xfns.c (Fx_file_dialog): Rename local to avoid shadowing.
5133
399c71d3 5134 * xdisp.c (x_produce_glyphs): Mark var as initialized (Bug#8512).
7a3fb125 5135
8ffc96f5
PE
5136 * xfns.c (x_real_positions): Mark locals as initialized.
5137
eef9bc79
PE
5138 * xmenu.c (xmenu_show): Don't use uninitialized vars.
5139
098db9dd
PE
5140 * xterm.c: Fix problems found by static analysis with other toolkits.
5141 (toolkit_scroll_bar_interaction): Define and use only if USE_X_TOOLKIT.
dda3aedd
PE
5142 (x_dispatch_event): Declare static if USE_GTK, and
5143 define if USE_GTK || USE_X_TOOLKIT.
098db9dd 5144 (SET_SAVED_BUTTON_EVENT): Define only if USE_X_TOOLKIT || USE_GTK.
dda3aedd 5145 * xterm.h (x_dispatch_event): Extern only if USE_X_TOOLKIT.
841a1577
JB
5146 * xterm.c, xterm.h (x_mouse_leave): Bring this function back, but only
5147 if defined HAVE_MENUS && !defined USE_X_TOOLKIT && !defined USE_GTK.
098db9dd 5148
eb18f6cc
PE
5149 * xmenu.c (menu_help_callback): Pointer type fixes.
5150 Use const pointers when pointing at readonly data. Avoid pointer
5151 signedness clashes.
5152 (FALSE): Remove unused macro.
5153 (update_frame_menubar): Remove unused decl.
5154
1fe72bf8
PE
5155 * xfns.c (Fx_hide_tip): Move locals to avoid shadowing.
5156
60d9e1db
PE
5157 * menu.c (push_submenu_start, push_submenu_end): Do not define unless
5158 USE_X_TOOLKIT || USE_GTK || HAVE_NS || defined HAVE_NTGUI.
5159 (single_menu_item): Rename local to avoid shadowing.
5160
39261c26
PE
5161 * keyboard.c (make_lispy_event): Remove unused local var.
5162
018c5e19
PE
5163 * frame.c, frame.h (x_get_resource_string): Bring this back, but
5164 only if HAVE_X_WINDOWS && !USE_X_TOOLKIT.
5165
63d2b86e
PE
5166 * bitmaps: Change bitmaps from unsigned char back to the X11
5167 compatible char. Avoid the old compiler warnings about
5168 out-of-range initializers by using, for example, '\xab' rather
5169 than 0xab.
5170
aefd87e1
PE
5171 * xgselect.c (xgselect_initialize): Check vs interface
5172 even if ! (defined (USE_GTK) || defined (HAVE_GCONF)).
5173
bf501fb9
PE
5174 * xmenu.c (xmenu_show): Rename parm to avoid shadowing.
5175
e9829fdf
PE
5176 * xterm.c (x_create_toolkit_scroll_bar): Use const * for pointers
5177 to read-only memory.
5178
1086c095
PE
5179 * fns.c (vector): Remove; this old hack is no longer needed.
5180
2baccd04 5181 * xsmfns.c (create_client_leader_window): Rename shadowing arg.
401f10cb 5182 Remove unused var.
dde42981 5183 (gdk_x11_set_sm_client_id) [!USE_GTK]: Don't define.
2baccd04 5184
72391843 5185 * xrdb.c (x_load_resources): Omit unused local.
3565b346 5186
436c16df 5187 * xfns.c (free_frame_menubar, atof): Remove duplicate decls.
8a94ea33 5188 (x_window): Rename locals to avoid shadowing.
dc5ddd85 5189 (USG): Use the kludged USG macro, to pacify gcc.
436c16df 5190
92bb796d 5191 * xterm.c (x_alloc_nearest_color_for_widget): Remove; unused.
bbbef9e1 5192 (x_term_init): Remove local to avoid shadowing.
92bb796d 5193
764430a3 5194 * xfns.c, xterm.c (_XEditResCheckMessages): Protoize decl.
4887c6e2
PE
5195
5196 * xdisp.c, dispextern.h (set_vertical_scroll_bar): Now extern if
5197 USE_TOOLKIT_SCROLL_BARS && !USE_GTK, as xterm.c needs it then.
5198
d1dfb56c
EZ
51992011-04-16 Eli Zaretskii <eliz@gnu.org>
5200
c4354cb4
EZ
5201 * gnutls.c (Fgnutls_boot): Don't pass Lisp_Object to `error'.
5202
d1dfb56c
EZ
5203 Fix regex.c, syntax.c and friends for buffers > 2GB.
5204 * syntax.h (struct gl_state_s): Declare character position members
5205 EMACS_INT.
5206
5207 * syntax.c (update_syntax_table): Declare 2nd argument EMACS_INT.
5208
04f2d78b
CB
5209 * textprop.c (verify_interval_modification, interval_of):
5210 Declare arguments EMACS_INT.
d1dfb56c
EZ
5211
5212 * intervals.c (adjust_intervals_for_insertion): Declare arguments
5213 EMACS_INT.
5214
5215 * intervals.h (CHECK_TOTAL_LENGTH): Cast to EMACS_INT, not `int'.
5216
5217 * indent.c (Fvertical_motion): Local variable it_start is now
5218 EMACS_INT.
5219
5220 * regex.c (re_match, re_match_2, re_match_2_internal)
5221 (bcmp_translate, regcomp, regexec, print_double_string)
5222 (group_in_compile_stack, re_search, re_search_2, regex_compile)
5223 (re_compile_pattern, re_exec): Declare arguments and local
5224 variables `size_t' and `ssize_t' and return values `regoff_t', as
5225 appropriate.
5226 (POP_FAILURE_REG_OR_COUNT) <pfreg>: Declare `long'.
5227 (CHECK_INFINITE_LOOP) <failure>: Declare `ssize_t'.
5228 <compile_stack_type>: `size' and `avail' are now `size_t'.
5229
5230 * regex.h <regoff_t>: Use ssize_t, not int.
5231 (re_search, re_search_2, re_match, re_match_2): Arguments that
5232 specify buffer/string position and length are now ssize_t and
5233 size_t. Return type is regoff_t.
5234
613052cd
BK
52352011-04-16 Ben Key <bkey76@gmail.com>
5236
5237 * nsfont.m: Fixed bugs in ns_get_family and
5238 ns_descriptor_to_entity that were caused by using free to
5239 deallocate memory blocks that were allocated by xmalloc (via
5240 xstrdup). This caused Emacs to crash when compiled with
5241 XMALLOC_OVERRUN_CHECK defined (when Emacs was configured with
5242 --enable-checking=xmallocoverrun). xfree is now used to
5243 deallocate these memory blocks.
5244
4170f62f 52452011-04-15 Paul Eggert <eggert@cs.ucla.edu>
3e047f51 5246
71b41406
PE
5247 * sysdep.c (emacs_read): Remove unnecessary check vs MAX_RW_COUNT.
5248
9587a89d
PE
5249 emacs_write: Accept and return EMACS_INT for sizes.
5250 See http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00514.html
5251 et seq.
5252 * gnutls.c, gnutls.h (emacs_gnutls_read, emacs_gnutls_write):
5253 Accept and return EMACS_INT.
5254 (emacs_gnutls_write): Return the number of bytes written on
5255 partial writes.
5256 * sysdep.c, lisp.h (emacs_read, emacs_write): Likewise.
273a5f82
PE
5257 (emacs_read, emacs_write): Remove check for negative size, as the
5258 Emacs source code has been audited now.
9587a89d
PE
5259 * sysdep.c (MAX_RW_COUNT): New macro, to work around kernel bugs.
5260 (emacs_read, emacs_write): Use it.
273a5f82
PE
5261 * process.c (send_process): Adjust to the new signatures of
5262 emacs_write and emacs_gnutls_write. Do not attempt to store
5263 a byte offset into an 'int'; it might overflow.
9587a89d 5264 See http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00483.html
273a5f82 5265
3e047f51
PE
5266 * sound.c: Don't assume sizes fit in 'int'.
5267 (struct sound_device.period_size, alsa_period_size):
9c3c56a7 5268 Return EMACS_INT, not int.
3e047f51 5269 (struct sound_device.write, vox_write, alsa_write):
9c3c56a7
PE
5270 Accept EMACS_INT, not int.
5271 (wav_play, au_play): Use EMACS_INT to store sizes and to
3e047f51
PE
5272 record read return values.
5273
cc39a9db
BK
52742011-04-15 Ben Key <bkey76@gmail.com>
5275
c9d0ec6d
JB
5276 * keyboard.c (Qundefined): Don't declare static since it is used
5277 in nsfns.m.
5278 * xfaces.c (Qbold, Qexpanded, Qitalic, Qcondensed): Don't declare
5279 static since they are used in nsfont.m.
cc39a9db 5280
6c60eb9f
SM
52812011-04-15 Stefan Monnier <monnier@iro.umontreal.ca>
5282
5283 * process.c (Qprocessp): Don't declare static.
5284 * lisp.h (Qprocessp): Declare again.
5285
7990b61a
JB
52862011-04-15 Juanma Barranquero <lekktu@gmail.com>
5287
5288 * font.c (Qopentype): Don't make static (used from w32uniscribe.c).
5289
5d4cb038
PE
52902011-04-14 Paul Eggert <eggert@cs.ucla.edu>
5291
8bd7b830 5292 Improve C-level modularity by making more things 'static'.
cd64ea1d 5293
e3b27b31
PE
5294 Don't publish debugger-only interfaces to other modules.
5295 * lisp.h (safe_debug_print, debug_output_compilation_hack):
5296 (verify_bytepos, count_markers): Move decls to the only modules
5297 that need them.
5298 * region-cache.h (pp_cache): Likewise.
5299 * window.h (check_all_windows): Likewise.
5300 * marker.c, print.c, region-cache.c, window.c: Decls moved here.
5301
5d4cb038
PE
5302 * sysdep.c (croak): Now static, if
5303 defined TIOCNOTTY || defined USG5 || defined CYGWIN.
5304 * syssignal.h (croak): Declare only if not static.
69003fd8
PE
5305
5306 * alloc.c (refill_memory_reserve): Now static if
5307 !defined REL_ALLOC || defined SYSTEM_MALLOC.
5308 * lisp.h (refill_memory_reserve): Declare only if not static.
93ea6e8f 5309
e87b6180
PE
5310 * xsettings.c, xsettings.h (xsettings_get_system_normal_font):
5311 Define only if USE_LUCID.
5312
ac64929e
PE
5313 * xrdb.c (x_customization_string, x_rm_string): Now static.
5314
6f37259d
PE
5315 * xmenu.c (x_menu_wait_for_event): Export only if USE_MOTIF.
5316 * xterm.h (x_menu_wait_for_event): Declare only if USE_MOTIF.
5317
1683e3ab
PE
5318 * xdisp.c (draw_row_with_mouse_face): Now static.
5319 * dispextern.h (draw_row_with_mouse_fave): Remove decl.
5320
de9c2632
PE
5321 * window.h (check_all_windows): Mark externally visible.
5322
2b96acb7
PE
5323 * window.c (window_deletion_count): Now static.
5324
5325 * undo.c: Make symbols static if they're not exported.
5326 (last_undo_buffer, last_boundary_position, pending_boundary):
5327 Now static.
5328
50436f33
PE
5329 * textprop.c (interval_insert_behind_hooks): Now static.
5330 (interval_insert_in_front_hooks): Likewise.
5331
64520e5c
PE
5332 * term.c: Make symbols static if they're not exported.
5333 (tty_turn_off_highlight, get_tty_terminal, max_frame_cols):
5334 (max_frame_lines, tty_set_terminal_modes):
5335 (tty_reset_terminal_modes, tty_turn_off_highlight):
5336 (get_tty_terminal): Now static.
5337 (term_mouse_moveto): Do not define if HAVE_WINDOW_SYSTEM.
5338 * termhooks.h (term_mouse_moveto): Do not declare if
8bd7b830 5339 HAVE_WINDOW_SYSTEM.
64520e5c
PE
5340 * dispextern.h (tty_set_terminal_modes, tty_reset_terminal_modes):
5341 (tty_turn_off_highlight, get_tty_terminal): Remove decls.
5342
1fa53021
PE
5343 * sysdep.c: Make symbols static if they're not exported.
5344 (emacs_get_tty, emacs_set_tty, old_fcntl_flags, old_fcntl_owner):
5345 Now static.
5346 (sigprocmask_set, full_mask): Remove; unused.
5347 (wait_debugging): Mark as visible.
5348 * syssignal.h (SIGFULLMASK, full_mask): Remove decls.
5349 * systty.h (emacs_get_tty, emacs_set_tty): Remove decls.
5350
d4b43b22
PE
5351 * syntax.c (syntax_temp): Define only if !__GNUC__.
5352
b7c513d0
PE
5353 * sound.c (current_sound_device, current_sound): Now static.
5354
989b29ad
PE
5355 * search.c (searchbufs, searchbuf_head): Now static.
5356
13a55a78
PE
5357 * scroll.c (scroll_cost): Remove; unused.
5358 * dispextern.h (scroll_cost): Remove decl.
5359
de68a1fc
PE
5360 * region-cache.h (pp_cache): Mark as externally visible.
5361
40ccffa6
PE
5362 * process.c: Make symbols static if they're not exported.
5363 (process_tick, update_tick, create_process, chan_process):
5364 (Vprocess_alist, proc_buffered_char, datagram_access):
5365 (fd_callback_data, send_process_frame, process_sent_to): Now static.
5366 (deactivate_process): Mark defn as static, as well as decl.
5367 * lisp.h (create_process): Remove decl.
5368 * process.h (chan_process, Vprocess_alist): Remove decls.
5369
ad64fc97
PE
5370 * print.c: Make symbols static if they're not exported.
5371 (print_depth, new_backquote_output, being_printed, print_buffer):
5372 (print_buffer_size, print_buffer_pos, print_buffer_pos_byte):
5373 (print_interval, print_number_index, initial_stderr_stream):
5374 Now static.
5375 * lisp.h (Fprinc): Remove decl.
5376 (debug_output_compilation_hack): Mark as externally visible.
5377
adddb265
PE
5378 * sysdep.c (croak): Move decl from here to syssignal.h.
5379 * syssignal.h (croak): Put it here, so the API can be checked when
5380 'croak' is called from dissociate_if_controlling_tty.
5381
1717ede2
PE
5382 * minibuf.c: Make symbols static if they're not exported.
5383 (minibuf_save_list, choose_minibuf_frame): Now static.
5384 * lisp.h (choose_minibuf_frame): Remove decl.
5385
fa5fb2bc
PE
5386 * lisp.h (verify_bytepos, count_markers): Mark as externally visible.
5387
1e3890d1
PE
5388 * lread.c: Make symbols static if they're not exported.
5389 (read_objects, initial_obarray, oblookup_last_bucket_number):
5390 Now static.
5391 (make_symbol): Remove; unused.
5392 * lisp.h (initial_obarray, make_symbol): Remove decls.
5393
8a1414fa
PE
5394 * keyboard.c: Make symbols static if they're not exported.
5395 (single_kboard, recent_keys_index, total_keys, recent_keys):
5396 (this_command_key_count_reset, raw_keybuf, raw_keybuf_count):
5397 (this_single_command_key_start, echoing, last_auto_save):
5398 (read_key_sequence_cmd, dribble, recursive_edit_unwind):
5399 (command_loop, echo_now, keyboard_init_hook, help_char_p):
5400 (quit_throw_to_read_char, command_loop_2, top_level_1, poll_timer):
5401 (Vlispy_mouse_stem, double_click_count):
5402 Now static.
5403 (force_auto_save_soon): Define only if SIGDANGER.
5404 (ignore_mouse_drag_p): Now static if
5405 !defined HAVE_WINDOW_SYSTEM || defined USE_GTK || defined HAVE_NS.
5406 (print_help): Remove; unused.
5407 (stop_character, last_timer_event): Mark as externally visible.
5408 * keyboard.h (ignore_mouse_drag_p): Declare only if
5409 defined HAVE_WINDOW_SYSTEM && !defined USE_GTK && !defined HAVE_NS.
5410 (echo_now, help_char_p, quit_throw_to_read_char): Remove decls.
5411 * lisp.h (echoing): Remove decl.
5412 (force_auto_save_soon): Declare only if SIGDANGER.
5413 * xdisp.c (redisplay_window): Simplify code, to make it more
5414 obvious that ignore_mouse_drag_p is not accessed if !defined
5415 USE_GTK && !defined HAVE_NS.
5416
93ea6e8f
PE
5417 * intervals.c: Make symbols static if they're not exported.
5418 (merge_properties_sticky, merge_interval_right, delete_interval):
5419 Now static.
5420 * intervals.h (merge_interval_right, delete_interval): Remove decls.
5421
77382fcc
PE
5422 * insdel.c: Make symbols static if they're not exported.
5423 However, leave prepare_to_modify_buffer alone. It's never
5424 called from outside this function, but that appears to be a bug.
5425 (combine_after_change_list, combine_after_change_buffer):
4889fc82 5426 (adjust_after_replace, signal_before_change): Now static.
77382fcc
PE
5427 (adjust_after_replace_noundo): Remove; unused.
5428 * lisp.h (adjust_after_replace, adjust_after_replace_noundo):
4889fc82 5429 (signal_before_change): Remove decls.
77382fcc 5430
9306c32e
PE
5431 * indent.c (val_compute_motion, val_vmotion): Now static.
5432
cd44d2eb
PE
5433 * image.c: Make symbols static if they're not exported.
5434 * dispextern.h (x_create_bitmap_from_xpm_data): Do not declare
5435 if USE_GTK.
5436 * image.c (x_create_bitmap_from_xpm_data): Do not define if USE_GTK.
5437 (xpm_color_cache, ct_table, ct_colors_allocated): Now static.
5438
ad9a7a06
PE
5439 * fringe.c (standard_bitmaps): Now static.
5440 (max_used_fringe_bitmap): Now static, unless HAVE_NS.
5441
81626931
PE
5442 * frame.c: Make symbols static if they're not exported.
5443 (x_report_frame_params, make_terminal_frame): Now static.
5444 (get_frame_param): Now static, unless HAVE_NS.
5445 (x_fullscreen_adjust): Define if WINDOWSNT, not if HAVE_WINDOW_SYSTEM.
5446 (x_get_resource_string): Remove; not used.
5447 * frame.h (make_terminal_frame, x_report_frame_params):
5448 (x_get_resource_string); Remove decls.
5449 (x_fullscreen_adjust): Declare only if WINDOWSNT.
5450 * lisp.h (get_frame_param): Declare only if HAVE_NS.
5451
239f9db9
PE
5452 * font.c, fontset.c: Make symbols static if they're not exported.
5453 * dispextern.h (FACE_SUITABLE_FOR_ASCII_CHAR_P): New macro.
5454 (FACE_SUITABLE_FOR_CHAR_P): Use it.
5455 * font.c (font_close_object): Now static.
5456 * font.h (font_close_object): Remove.
5457 * fontset.c (FONTSET_OBJLIST): Remove.
5458 (free_realized_fontset) #if-0 the body, which does nothing.
5459 (face_suitable_for_char_p): #if-0, as it's never called.
5460 * fontset.h (face_suitable_for_char_p): Remove decl.
04f2d78b
CB
5461 * xfaces.c (face_at_string_position):
5462 Use FACE_SUITABLE_FOR_ASCII_CHAR_P, not FACE_SUITABLE_FOR_CHAR_P,
239f9db9
PE
5463 since 0 is always ASCII.
5464
dfcf3579
PE
5465 * fns.c (weak_hash_tables): Now static.
5466
5045092b
PE
5467 * fileio.c: Make symbols static if they're not exported.
5468 (auto_saving, auto_save_mode_bits, auto_save_error_occurred):
5469 (Vwrite_region_annotation_buffers): Now static.
5470
57a96f5c
PE
5471 * eval.c: Make symbols static if they're not exported.
5472 (backtrace_list, lisp_eval_depth, when_entered_debugger): Now static.
5473 * lisp.h (backtrace_list): Remove decl.
5474
35f08c38
PE
5475 * emacs.c: Make symbols static if they're not exported.
5476 (malloc_state_ptr, malloc_using_checking, syms_of_emacs):
5477 (fatal_error_code, fatal_error_signal_hook, standard_args):
5478 Now static.
5479 (fatal_error_signal): Now static, unless FLOAT_CATCH_SIGKILL.
5480 (DEFINE_DUMMY_FUNCTION): Mark function as externally visible.
5481 (__CTOR_LIST__, __DTOR_LIST__): Now externally visible.
5482 * lisp.h (fatal_error_signal_hook): Remove decl.
5483 (fatal_error_signal): Declare only if FLOAT_CATCH_SIGKILL.
5484
f44bd759
PE
5485 * editfns.c: Move a (normally-unused) function to its only use.
5486 * editfns.c, lisp.h (get_operating_system_release): Remove.
5487 * process.c (init_process) [DARWIN_OS]: Do it inline, as it is not
5488 worth the hassle of breaking this out.
5489
b532497d
PE
5490 * xterm.c: Make symbols static if they're not exported.
5491 (x_raise_frame, x_lower_frame, x_wm_set_window_state):
5492 (x_wm_set_icon_pixmap, x_initialize, XTread_socket_fake_io_error):
5493 (x_destroy_window, x_delete_display):
5494 Now static.
5495 (x_dispatch_event): Now static if ! (USE_MOTIF || USE_X_TOOLKIT).
5496 (x_mouse_leave): Remove; unused.
5497 * xterm.h (x_display_info_for_name, x_raise_frame, x_lower_frame):
5498 (x_destroy_window, x_wm_set_window_state, x_wm_set_icon_pixmap):
5499 (x_delete_display, x_initialize, x_set_border_pixel, x_screen_planes):
5500 Remove decls.
5501 (x_mouse_leave): Declare only if WINDOWSNT.
5502 (x_dispatch_event): Declare only if USE_MOTIF or USE_X_TOOLKIT.
5503 (xic_create_fontsetname): Declare only if HAVE_X_WINDOWS &&
5504 USE_X_TOOLKIT.
5505
1675728f
PE
5506 * ftxfont.c: Make symbols static if they're not exported.
5507 (ftxfont_driver): Export only if !defined HAVE_XFT && def8ined
5508 HAVE_FREETYPE.
5509 * font.h (ftxfont_driver): Likewise.
5510
e4cebfca
PE
5511 * xfns.c: Make symbols static if they're not exported.
5512 (x_last_font_name, x_display_info_for_name):
5513 (x_set_foreground_color, x_set_background_color, x_set_mouse_color):
5514 (x_set_cursor_color, x_set_border_pixel, x_set_border_color):
5515 (x_set_cursor_type, x_set_icon_type, x_set_icon_name):
5516 (x_set_scroll_bar_foreground, x_set_scroll_bar_background):
5517 (x_explicitly_set_name, x_set_title, xic_defaut_fontset, tip_timer):
5518 (last_show_tip_args): Now static.
5519 (xic_defaut_fontset, xic_create_fontsetname): Define only if
5520 defined HAVE_X_WINDOWS && defined USE_X_TOOLKIT
5521 (x_screen_planes): Remove; unused.
5522 * dispextern.h (x_screen_planes): Remove decl.
5523
5bf46f05
PE
5524 * dispnew.c: Make symbols static if they're not exported.
5525 * dispextern.h (redraw_garbaged_frames, scrolling):
5526 (increment_row_positions): Remove.
5527 * dispnew.c (new_glyph_matrix, increment_row_positions, scrolling):
5528 (delayed_size_change, glyph_matrix_count, glyph_pool_count):
5529 Now static.
5530 (redraw_garbaged_frames): Remove; unused.
5531
435f4c28
PE
5532 * xfaces.c: Make symbols static if they're not exported.
5533 * dispextern.h (ascii_face_of_lisp_face, free_realized_face):
5534 Remove decls.
5535 * xterm.h (defined_color): Remove decls.
5536 (x_free_dpy_colors): Declare only if USE_X_TOOLKIT.
5537 * xfaces.c (tty_suppress_bold_inverse_default_colors_p):
5538 (menu_face_changed_default, defined_color, free_realized_face):
5539 (x_free_dpy_colors): Define only if USE_X_TOOLKIT.
5540 (ascii_face_of_lisp_face): Remove; unused.
5541
8524aef3
PE
5542 * xdisp.c: Make symbols static if they're not exported.
5543 * dispextern.h (scratch_glyph_row, window_box_edges):
5544 (glyph_to_pixel_coords, set_cursor_from_row):
5545 (get_next_display_element, set_iterator_to_next):
5546 (highlight_trailing_whitespace, frame_to_window_pixel_xy):
5547 (show_mouse_face): Remove decls
5548 * frame.h (message_buf_print): Likewise.
5549 * lisp.h (pop_message, set_message, check_point_in_composition):
5550 Likewise.
5551 * xterm.h (set_vertical_scroll_bar): Likewise.
5552 * xdisp.c (list_of_error, Vmessage_stack, line_number_displayed):
5553 (message_buf_print, scratch_glyph_row, displayed_buffer):
5554 (set_iterator_to_next, pop_message, set_message, set_cursor_from_row):
5555 (get_next_display_element, show_mouse_face, window_box_edges):
5556 (frame_to_window_pixel_xy, check_point_in_composition):
5557 (set_vertical_scroll_bar, highlight_trailing_whitespace): Now static.
5558 (glyph_to_pixel_coords): Remove; unused.
5559
16390cd2
PE
5560 * dired.c (file_name_completion): Now static.
5561
5562 * dbusbind.c (xd_in_read_queued_messages): Now static.
5563
a25f4dfa
PE
5564 * lisp.h (circular_list_error, FOREACH): Remove; unused.
5565 * data.c (circular_list_error): Remove.
5566
14a9c8df
PE
5567 * commands.h (last_point_position, last_point_position_buffer):
5568 (last_point_position_window): Remove decls.
5569 * keyboard.c: Make these variables static.
5570
04f2d78b
CB
5571 * coding.h (coding, code_convert_region, encode_coding_gap):
5572 Remove decls.
74ab6df5
PE
5573 * coding.c (Vsjis_coding_system, Vbig5_coding_system):
5574 (iso_code_class, detect_coding, code_convert_region): Now static.
5575 (encode_coding_gap): Remove; unused.
5576
38dfbee1
PE
5577 * chartab.c (chartab_chars, chartab_bits): Now static.
5578
a2cb4e63
PE
5579 * charset.h (charset_iso_8859_1): Remove decl.
5580 * charset.c (charset_iso_8859_1, charset_emacs, map_charset_for_dump):
5581 Now static.
5582
127198fd
PE
5583 * ccl.h (check_ccl_update, Vccl_program_table): Remove decls.
5584 * ccl.c (Vccl_program_table): Now static.
5585 (check_ccl_update): Remove; unused.
5586
d85b608f
PE
5587 * category.c (SET_CATEGORY_SET, set_category_set): Move here.
5588 * category.h: ... from here.
5589 * category.c (check_category_table, set_category_set): Now static.
5590
31cd66f3
PE
5591 * casetab.c (Vascii_upcase_table, Vascii_eqv_table): Now static.
5592 * lisp.h: Remove these decls.
5593
c358e587
PE
5594 * buffer.c (buffer_count): Remove unused var.
5595
e78aecca
PE
5596 * bidi.c (bidi_dump_cached_states): Mark as externally visible,
5597 so that it's not optimized away.
5598 (bidi_ignore_explicit_marks_for_paragraph_level): Likewise.
5599 * dispextern.h (bidi_dump_cached_states): Remove, since it's
5600 exported only to the debugger.
5601
e192d7d3 5602 * atimer.c (alarm_signal_handler, run_all_atimers): Now static.
04f2d78b 5603 * atimer.h (run_all_atimers): Remove; not exported.
e192d7d3 5604
92470028
PE
5605 font.c: Make copy_font_spec and merge_font_spec ordinary C functions.
5606 * font.c (copy_font_spec): Rename from Fcopy_font_spec, since it
5607 was inaccessible from Lisp.
5608 (merge_font_spec): Likewise, renaming from Fmerge_font_spec.
5609 * font.c, font.h, fontset.c, xfaces.c, xfont.c: Change all uses.
5610
244ed907
PE
5611 alloc.c: Import and export fewer symbols, and remove unused items.
5612 * lisp.h (suppress_checking, die): Declare only if ENABLE_CHECKING
5613 is defined.
5614 (suppress_checking): Add EXTERNALLY_VISIBLE attribute, so that
5615 it's not optimized away by whole-program optimization.
5616 (message_enable_multibyte, free_misc): Remove.
5617 (catchlist, handlerlist, mark_backtrace):
5618 Declare only if BYTE_MARK_STACK.
5619 (mark_byte_stack): Likewise, fixing a ifdef-vs-if typo.
5620 * alloc.c (pure): Export only if VIRT_ADDR_VARIES is defined.
5621 (message_enable_multibyte): Remove decl.
5622 (free_misc, interval_free_list, float_block, float_block_index):
5623 (n_float_blocks, float_free_list, cons_block, cons_block_index):
5624 (cons_free_list, last_marked_index):
5625 Now static.
5626 (suppress_checking, die): Define only if ENABLE_CHECKING is defined.
5627 * eval.c (catchlist, handlerlist): Export only if BYTE_MARK_STACK.
5628 (mark_backtrace): Define only if BYTE_MARK_STACK.
5629 * xdisp.c (message_enable_multibyte): Now static.
5630
61c2b50e 5631 Declare Lisp_Object Q* variables to be 'static' if not exported.
955cbe7b
PE
5632 This makes it easier for human readers (and static analyzers)
5633 to see whether these variables are used from other modules.
5634 * alloc.c, buffer.c, bytecode.c, callint.c, casetab.c, category.c:
5635 * ccl.c, character.c, charset.c, cmds.c, coding.c, composite.c:
5636 * data.c, dbusbind.c, dired.c, editfns.c, eval.c, fileio.c, fns.c:
5637 * font.c, frame.c, fringe.c, ftfont.c, image.c, keyboard.c, keymap.c:
5638 * lread.c, macros.c, minibuf.c, print.c, process.c, search.c:
5639 * sound.c, syntax.c, textprop.c, window.c, xdisp.c, xfaces.c, xfns.c:
5640 * xmenu.c, xselect.c:
5641 Declare Q* vars static if they are not used in other modules.
5642 * ccl.h, character.h, charset.h, coding.h, composite.h, font.h:
5643 * frame.h, intervals.h, keyboard.h, lisp.h, process.h, syntax.h:
5644 Remove decls of unexported vars.
5645 * keyboard.h (EVENT_HEAD_UNMODIFIED): Remove now-unused macro.
5646
95c82688
PE
5647 * lisp.h (DEFINE_FUNC): Make sname 'static'.
5648
16a97296
PE
5649 Make Emacs functions such as Fatom 'static' by default.
5650 This makes it easier for human readers (and static analyzers)
5651 to see whether these functions can be called from other modules.
5652 DEFUN now defines a static function. To make the function external
5653 so that it can be used in other C modules, use the new macro DEFUE.
8bd7b830
PE
5654 * lisp.h (Funibyte_char_to_multibyte, Fsyntax_table_p):
5655 (Finit_image_library):
16a97296
PE
5656 (Feval_region, Fbacktrace, Ffetch_bytecode, Fswitch_to_buffer):
5657 (Ffile_executable_p, Fmake_symbolic_link, Fcommand_execute):
5658 (Fget_process, Fdocumentation_property, Fbyte_code, Ffile_attributes):
5659 Remove decls, since these functions are now static.
5660 (Funintern, Fget_internal_run_time): New decls, since these functions
5661 were already external.
95c82688 5662
16a97296
PE
5663 * alloc.c, buffer.c, callint.c, callproc.c, casefiddle.c, casetab.c:
5664 * ccl.c, character.c, chartab.c, cmds.c, coding.c, data.c, dispnew.c:
5665 * doc.c, editfns.c, emacs.c, eval.c, fileio.c, filelock.c, floatfns.c:
5666 * fns.c, font.c, fontset.c, frame.c, image.c, indent.c:
5667 * keyboard.c, keymap.c, lread.c:
5668 * macros.c, marker.c, menu.c, minibuf.c, print.c, process.c, search.c:
5669 * syntax.c, term.c, terminal.c, textprop.c, undo.c:
5670 * window.c, xdisp.c, xfaces.c, xfns.c, xmenu.c, xsettings.c:
5671 Mark functions with DEFUE instead of DEFUN,
5672 if they are used in other modules.
5673 * buffer.c (Fset_buffer_major_mode, Fdelete_overlay): New forward
5674 decls for now-static functions.
5675 * buffer.h (Fdelete_overlay): Remove decl.
5676 * callproc.c (Fgetenv_internal): Mark as internal.
5677 * composite.c (Fremove_list_of_text_properties): Remove decl.
5678 (Fcomposition_get_gstring): New forward static decl.
5679 * composite.h (Fcomposite_get_gstring): Remove decl.
5680 * dired.c (Ffile_attributes): New forward static decl.
5681 * doc.c (Fdocumntation_property): New forward static decl.
5682 * eval.c (Ffetch_bytecode): New forward static decl.
5683 (Funintern): Remove extern decl; now in .h file where it belongs.
5684 * fileio.c (Fmake_symbolic_link): New forward static decl.
5685 * image.c (Finit_image_library): New forward static decl.
5686 * insdel.c (Fcombine_after_change_execute): Make forward decl static.
5687 * intervals.h (Fprevious_property_change):
5688 (Fremove_list_of_text_properties): Remove decls.
5689 * keyboard.c (Fthis_command_keys): Remove decl.
5690 (Fcommand_execute): New forward static decl.
5691 * keymap.c (Flookup_key): New forward static decl.
5692 (Fcopy_keymap): Now static.
5693 * keymap.h (Flookup_key): Remove decl.
5694 * process.c (Fget_process): New forward static decl.
5695 (Fprocess_datagram_address): Mark as internal.
5696 * syntax.c (Fsyntax_table_p): New forward static decl.
5697 (skip_chars): Remove duplicate decl.
5698 * textprop.c (Fprevious_property_change): New forward static decl.
5699 * window.c (Fset_window_fringes, Fset_window_scroll_bars):
5700 Now internal.
5701 (Fset_window_margins, Fset_window_vscroll): New forward static decls.
5702 * window.h (Fset_window_vscroll, Fset_window_margins): Remove decls.
5703
785bbd42
PE
5704 * editfns.c (Fformat): Remove unreachable code.
5705
8b913b57
AS
57062011-04-14 Andreas Schwab <schwab@linux-m68k.org>
5707
5708 * fileio.c (Finsert_file_contents): Fix typo in 2005-05-13
5709 change. (Bug#8496)
5710
a6744a35
EZ
57112011-04-13 Eli Zaretskii <eliz@gnu.org>
5712
5713 * xdisp.c (handle_invisible_prop): Don't call bidi_paragraph_init
5714 when at ZV. (Bug#8487)
5715
e7974947
AS
57162011-04-12 Andreas Schwab <schwab@linux-m68k.org>
5717
baad03f0
AS
5718 * charset.c (Fclear_charset_maps): Use xfree instead of free.
5719 (Bug#8437)
5720 * keyboard.c (parse_tool_bar_item): Likewise.
5721 * sound.c (sound_cleanup, alsa_close): Likewise.
5722 * termcap.c (tgetent): Likewise.
5723 * xfns.c (x_default_font_parameter): Likewise.
5724 * xsettings.c (read_and_apply_settings): Likewise.
5725
e7974947
AS
5726 * alloc.c (overrun_check_malloc, overrun_check_realloc)
5727 (overrun_check_free): Protoize.
5728
28272684
PE
57292011-04-12 Paul Eggert <eggert@cs.ucla.edu>
5730
5731 * sysdep.c (emacs_read, emacs_write): Check for negative sizes
5732 since callers should never pass a negative size.
5733 Change the signature to match that of plain 'read' and 'write'; see
5734 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00397.html>.
5735 * lisp.h: Update prototypes of emacs_write and emacs_read.
5736
11997c76
EZ
57372011-04-11 Eli Zaretskii <eliz@gnu.org>
5738
5739 * xdisp.c (redisplay_window): Don't try to determine the character
5740 position of the scroll margin if the window start point w->startp
e896f03c 5741 is outside the buffer's accessible region. (Bug#8468)
11997c76 5742
8a2cbd72
EZ
57432011-04-10 Eli Zaretskii <eliz@gnu.org>
5744
5745 Fix write-region and its subroutines for buffers > 2GB.
5746 * fileio.c (a_write, e_write): Modify declaration of arguments and
5747 local variables to support buffers larger than 2GB.
5748 (Fcopy_file): Use EMACS_INT for return value of emacs_read.
5749
5750 * sysdep.c (emacs_write, emacs_read): Use ssize_t for last
5751 argument, local variables, and return value.
5752
5753 * lisp.h: Update prototypes of emacs_write and emacs_read.
5754
5755 * sound.c (vox_write): Use ssize_t for return value of emacs_write.
5756
4073e537 57572011-04-10 Paul Eggert <eggert@cs.ucla.edu>
eb3f1cc8 5758
1ebfdcb6
PE
5759 * xdisp.c (vmessage): Use memchr, not strnlen, which some hosts lack.
5760
b2ded58d
PE
5761 Fix more problems found by GCC 4.6.0's static checks.
5762
7d66342c
PE
5763 * xdisp.c (vmessage): Use a better test for character truncation.
5764
bbf47d44
PE
5765 * charset.c (load_charset_map): <, not <=, for optimization,
5766 and to avoid potential problems with integer overflow.
9248994d 5767 * chartab.c (sub_char_table_set_range, char_table_set_range): Likewise.
f9a68bc5 5768 * casetab.c (set_identity, shuffle): Likewise.
3ab1c7ce 5769 * editfns.c (Fformat): Likewise.
1e69125e 5770 * syntax.c (skip_chars): Likewise.
3befa583 5771
e3019616
PE
5772 * xmenu.c (set_frame_menubar): Allocate smaller local vectors.
5773 This also lets GCC 4.6.0 generate slightly better loop code.
5774
becfa255
PE
5775 * callint.c (Fcall_interactively): <, not <=, for optimization.
5776 (Fcall_interactively): Count the number of arguments produced,
5777 not the number of arguments given. This is simpler and lets GCC
5778 4.6.0 generate slightly better code.
5779
dae0cd48
PE
5780 * ftfont.c: Distingish more carefully between FcChar8 and char.
5781 The previous code passed unsigned char * to a functions like
5782 strlen and xstrcasecmp that expect char *, which does not
5783 conform to the C standard.
5784 (get_adstyle_property, ftfont_pattern_entity): Use FcChar8 for
5785 arguments to FcPatternGetString, and explicitly cast FcChar8 * to
5786 char * when the C standard requires it.
5787
76032d70
PE
5788 * keyboard.c (read_char): Remove unused var.
5789
eb3f1cc8
PE
5790 * eval.c: Port to Windows vsnprintf (Bug#8435).
5791 Include <limits.h>.
5792 (SIZE_MAX): Define if the headers do not.
5793 (verror): Do not give up if vsnprintf returns a negative count.
5794 Instead, grow the buffer. This ports to Windows vsnprintf, which
5795 does not conform to C99. Problem reported by Eli Zaretskii.
5796 Also, simplify the allocation scheme, by avoiding the need for
5797 calling realloc, and removing the ALLOCATED variable.
5798
70476b54
PE
5799 * eval.c (verror): Initial buffer size is 4000 (not 200) bytes.
5800
12020a9e
PE
5801 Remove invocations of doprnt, as Emacs now uses vsnprintf.
5802 But keep the doprint source code for now, as we might revamp it
5803 and use it again (Bug#8435).
ea6c7ae6
PE
5804 * lisp.h (doprnt): Remove.
5805 * Makefile.in (base_obj): Remove doprnt.o.
5806 * deps.mk (doprnt.o): Remove.
5807
5fdb398c
PE
5808 error: Print 32- and 64-bit integers portably (Bug#8435).
5809 Without this change, on typical 64-bit hosts error ("...%d...", N)
5810 was used to print both 32- and 64-bit integers N, which relied on
5811 undefined behavior.
5812 * lisp.h, src/m/amdx86-64.h, src/m/ia64.h, src/m/ibms390x.h (pEd):
5813 New macro.
5814 * lisp.h (error, verror): Mark as printf-like functions.
5815 * eval.c (verror): Use vsnprintf, not doprnt, to do the real work.
5816 Report overflow in size calculations when allocating printf buffer.
5817 Do not truncate output string at its first null byte.
5818 * xdisp.c (vmessage): Use vsnprintf, not doprnt, to do the real work.
5819 Truncate the output at a character boundary, since vsnprintf does not
5820 do that.
5821 * charset.c (check_iso_charset_parameter): Convert internal
5822 character to string before calling 'error', since %c now has the
5823 printf meaning.
5824 * coding.c (Fdecode_sjis_char, Fdecode_big5_char): Avoid int
5825 overflow when computing char to be passed to 'error'. Do not
5826 pass Lisp_Object to 'error'; pass the integer instead.
5827 * nsfns.m (Fns_do_applescript): Use int, not long, since it's
5828 formatted with plain %d.
5829
b189fa66
PE
5830 * eval.c (internal_lisp_condition_case): Don't pass spurious arg.
5831
bff87ef0
PE
5832 * keyboard.c (access_keymap_keyremap): Print func name, not garbage.
5833
7e2cac20
PE
5834 * coding.c (Fdecode_sjis_char): Don't assume CODE fits in int.
5835
ce4d90b5
PE
5836 * xterm.c (x_catch_errors): Remove duplicate declaration.
5837
266c9547
PE
5838 * term.c (maybe_fatal): Mark its 3rd arg as a printf format, too.
5839
79c49ad2
PE
5840 * xdisp.c, lisp.h (message_nolog): Remove; unused.
5841
368f4090
JM
58422011-04-10 Jim Meyering <meyering@redhat.com>
5843
5844 use ssize_t and size_t for read- and write-like emacs_gnutls_* functions
5845 * gnutls.c (emacs_gnutls_read): Adjust signature to be more read-like:
5846 return ssize_t not "int", and use size_t as the buffer length.
5847 (emacs_gnutls_write): Likewise, and make the buffer pointer "const".
5848 * gnutls.h: Update declarations.
5849 * process.c (read_process_output): Use ssize_t, to match.
5850 (send_process): Likewise.
5851
a32d4040
CY
58522011-04-09 Chong Yidong <cyd@stupidchicken.com>
5853
5854 * image.c (Fimagemagick_types): Doc fix, and comment cleanup.
5855
8546720e 58562011-04-09 Chong Yidong <cyd@stupidchicken.com>
aac0c6e3 5857
04f2d78b
CB
5858 * ftfont.c (get_adstyle_property, ftfont_pattern_entity):
5859 Use unsigned char, to match FcChar8 type definition.
aac0c6e3 5860
8546720e
GM
5861 * xterm.c (handle_one_xevent):
5862 * xmenu.c (create_and_show_popup_menu):
5863 * xselect.c (x_decline_selection_request)
5864 (x_reply_selection_request): Avoid type-punned deref of X events.
aac0c6e3 5865
0a2f5c1a 58662011-04-09 Eli Zaretskii <eliz@gnu.org>
a53e2e89
EZ
5867
5868 Fix some uses of `int' instead of EMACS_INT.
5869 * search.c (string_match_1, fast_string_match)
5870 (fast_c_string_match_ignore_case, fast_string_match_ignore_case)
5871 (scan_buffer, find_next_newline_no_quit)
5872 (find_before_next_newline, search_command, Freplace_match)
5873 (Fmatch_data): Make some `int' variables be EMACS_INT.
5874
5875 * xdisp.c (display_count_lines): 3rd argument and return value now
5876 EMACS_INT. All callers changed.
5877 (pint2hrstr): Last argument is now EMACS_INT.
5878
5879 * coding.c (detect_coding_utf_8, detect_coding_emacs_mule)
5880 (detect_coding_iso_2022, detect_coding_sjis, detect_coding_big5)
5881 (detect_coding_ccl, detect_coding_charset, decode_coding_utf_8)
5882 (decode_coding_utf_16, decode_coding_emacs_mule)
5883 (decode_coding_iso_2022, decode_coding_sjis, decode_coding_big5)
5884 (decode_coding_ccl, decode_coding_charset)
5885 <consumed_chars, consumed_chars_base>: Declare EMACS_INT.
5886 (decode_coding_iso_2022, decode_coding_emacs_mule)
5887 (decode_coding_sjis, decode_coding_big5, decode_coding_charset)
5888 <char_offset, last_offset>: Declare EMACS_INT.
5889 (encode_coding_utf_8, encode_coding_utf_16)
5890 (encode_coding_emacs_mule, encode_invocation_designation)
5891 (encode_designation_at_bol, encode_coding_iso_2022)
5892 (encode_coding_sjis, encode_coding_big5, encode_coding_ccl)
5893 (encode_coding_raw_text, encode_coding_charset) <produced_chars>:
5894 Declare EMACS_INT.
5895 (ASSURE_DESTINATION): Declare more_bytes EMACS_INT.
5896 (encode_invocation_designation): Last argument P_NCHARS is now
5897 EMACS_INT.
5898 (decode_eol): Declare pos_byte, pos, and pos_end EMACS_INT.
5899 (produce_chars): from_nchars and to_nchars are now EMACS_INT.
5900
5901 * coding.h (struct coding_system) <head_ascii>: Declare EMACS_INT.
5902 All users changed.
5903
5904 * ccl.c (Fccl_execute_on_string): Declare some variables
5905 EMACS_INT.
5906
8546720e 59072011-04-08 Samuel Thibault <sthibault@debian.org> (tiny change)
0080dc6b
SS
5908
5909 * term.c (init_tty): Fix incorrect ifdef placement (Bug#8450).
5910
4e19a977
CS
59112011-03-19 Christoph Scholtes <cschol2112@googlemail.com>
5912
5913 * process.c (Fformat_network_address): Doc fix.
5914
87302331
R
59152011-04-08 T.V. Raman <tv.raman.tv@gmail.com> (tiny change)
5916
5917 * xml.c (parse_region): Avoid creating spurious whiespace nodes.
5918
cbb59342
CY
59192011-04-08 Chong Yidong <cyd@stupidchicken.com>
5920
5921 * keyboard.c (read_char): Call Lisp function help-form-show,
5922 instead of using internal_with_output_to_temp_buffer.
5923 (Qhelp_form_show): New var.
e0d38eeb 5924 (syms_of_keyboard): Use DEFSYM macro.
cbb59342
CY
5925
5926 * print.c (internal_with_output_to_temp_buffer): Function deleted.
5927
5928 * lisp.h (internal_with_output_to_temp_buffer): Remove prototype.
5929
e67a13ab
CY
59302011-04-06 Chong Yidong <cyd@stupidchicken.com>
5931
04f2d78b
CB
5932 * process.c (Flist_processes): Remove to Lisp.
5933 (list_processes_1): Delete.
e67a13ab 5934
973f782d
EZ
59352011-04-06 Eli Zaretskii <eliz@gnu.org>
5936
7c106b1e
EZ
5937 * msdos.c (careadlinkat, careadlinkatcwd): MS-DOS replacements.
5938
973f782d
EZ
5939 * w32.c (careadlinkat, careadlinkatcwd): New always-fail stubs.
5940
41cf7d1a 59412011-04-06 Paul Eggert <eggert@cs.ucla.edu>
27ccc379 5942
ca23cc88
PE
5943 Fix more problems found by GCC 4.6.0's static checks.
5944
f390e2d5
PE
5945 * xmenu.c (Fx_popup_dialog): Don't assume string is free of formats.
5946
42eea0d0
PE
5947 * menu.c (Fx_popup_menu): Don't assume error_name lacks printf formats.
5948
b69769da 5949 * lisp.h (message, message_nolog, fatal): Mark as printf-like.
1e973bc7 5950
f9541e84
PE
5951 * xdisp.c (vmessage): Mark as a printf-like function.
5952
13841b55
PE
5953 * term.c (vfatal, maybe_fatal): Mark as printf-like functions.
5954
c136c10f
PE
5955 * sound.c (sound_warning): Don't crash if arg contains a printf format.
5956
5e2d4a30
PE
5957 * image.c (tiff_error_handler, tiff_warning_handler): Mark as
5958 printf-like functions.
5959 (tiff_load): Add casts to remove these marks before passing them
5960 to system-supplied API.
5961
583f48b9
PE
5962 * eval.c (Fsignal): Remove excess argument to 'fatal'.
5963
b25d760e
PE
5964 * coding.c (EMIT_ONE_BYTE, EMIT_TWO_BYTES): Use unsigned, not int.
5965 This avoids several warnings with gcc -Wstrict-overflow.
d5efd1d1
PE
5966 (DECODE_COMPOSITION_RULE): If the rule is invalid, goto invalid_code
5967 directly, rather than having caller test rule sign. This avoids
5968 some unnecessary tests.
5969 * composite.h (COMPOSITION_ENCODE_RULE_VALID): New macro.
5970 (COMPOSITION_ENCODE_RULE): Arguments now must be valid. This
5971 affects only one use, in DECODE_COMPOSITION_RULE, which is changed.
b25d760e 5972
bc7b6697 5973 * xfont.c (xfont_text_extents): Remove var that was set but not used.
625a3eb1 5974 (xfont_open): Avoid unnecessary tests.
bc7b6697 5975
27ccc379
PE
5976 * composite.c (composition_gstring_put_cache): Use unsigned integer.
5977
dcd5c89a
PE
5978 * composite.h, composite.c (composition_gstring_put_cache):
5979 Use EMACS_INT, not int, for length.
5980
b13a45c6
PE
5981 * composite.h (COMPOSITION_DECODE_REFS): New macro,
5982 breaking out part of COMPOSITION_DECODE_RULE.
5983 (COMPOSITION_DECODE_RULE): Use it.
5984 * composite.c (get_composition_id): Remove unused local vars,
5985 by using the new macro.
5986
1e792e4d
PE
5987 * textprop.c (set_text_properties_1): Change while to do-while,
5988 since the condition is always true at first.
5989
dc6c6455 5990 * intervals.c (graft_intervals_into_buffer): Mark var as used.
aa86731f
PE
5991 (interval_deletion_adjustment): Return unsigned value.
5992 All uses changed.
dc6c6455 5993
aba7731a
PE
5994 * process.c (list_processes_1, create_pty, read_process_output):
5995 (exec_sentinel): Remove vars that were set but not used.
afd4052b 5996 (create_pty): Remove unnecessary "volatile"s.
bc57d757 5997 (Fnetwork_interface_info): Avoid possibility of int overflow.
82eaa333 5998 (read_process_output): Do adaptive read buffering even if carryover.
fe07cdfa 5999 (read_process_output): Simplify nbytes computation if buffered.
aba7731a 6000
fdfc4bf3
PE
6001 * bytecode.c (exec_byte_code): Rename local to avoid shadowing.
6002
fca8fe46 6003 * syntax.c (scan_words): Remove var that was set but not used.
12cbf13f 6004 (update_syntax_table): Use unsigned instead of int.
fca8fe46 6005
06a0259a 6006 * lread.c (lisp_file_lexically_bound_p): Use ints rather than endptrs.
3c346cc3 6007 (lisp_file_lexically_bound_p, read1): Use unsigned instead of int.
e6eb4e9e 6008 (safe_to_load_p): Make the end-of-loop test the inverse of the in-loop.
06a0259a 6009
e7b9e80f
PE
6010 * print.c (print_error_message): Avoid int overflow.
6011
56201685
PE
6012 * font.c (font_list_entities): Redo for clarity,
6013 so that reader need not know FONT_DPI_INDEX + 1 == FONT_SPACING_INDEX.
6014
78834453 6015 * font.c (font_find_for_lface, Ffont_get_glyphs): Remove unused vars.
790771b1 6016 (font_score): Avoid potential overflow in diff calculation.
78834453 6017
0bc0b309 6018 * fns.c (substring_both): Remove var that is set but not used.
8cd55cb4 6019 (sxhash): Redo loop for clarity and to avoid wraparound warning.
0bc0b309 6020
e610eaca
PE
6021 * eval.c (funcall_lambda): Rename local to avoid shadowing.
6022
b895abce
PE
6023 * alloc.c (mark_object_loop_halt, mark_object): Use size_t, not int.
6024 Otherwise, GCC 4.6.0 optimizes the loop check away since the check
6025 can always succeed if overflow has undefined behavior.
6026
1f1d9321 6027 * search.c (boyer_moore, wordify): Remove vars set but not used.
6f076cc7 6028 (wordify): Omit three unnecessary tests.
1f1d9321 6029
c59478bc
PE
6030 * indent.c (MULTIBYTE_BYTES_WIDTH): Don't compute wide_column.
6031 All callers changed. This avoids the need for an unused var.
6032
79b73827
PE
6033 * casefiddle.c (casify_region): Remove var that is set but not used.
6034
a4db5dfe
PE
6035 * dired.c (file_name_completion): Remove var that is set but not used.
6036
43aae36e
PE
6037 * fileio.c (Finsert_file_contents): Make EOF condition clearer.
6038
2a47c44d 6039 * fileio.c (Finsert_file_contents): Avoid signed integer overflow.
163c5f32 6040 (Finsert_file_contents): Remove unnecessary code checking fd.
2a47c44d 6041
a37c69bf
PE
6042 * minibuf.c (read_minibuf_noninteractive): Use size_t for sizes.
6043 Check for integer overflow on size calculations.
6044
328ab8e7
PE
6045 * buffer.c (Fprevious_overlay_change): Remove var that is set
6046 but not used.
6047
e5a2a5cb
PE
6048 * keyboard.c (menu_bar_items, read_char_minibuf_menu_prompt):
6049 Remove vars that are set but not used.
8d84a6eb 6050 (timer_check_2): Don't assume timer-list and idle-timer-list are lists.
6b043475 6051 (timer_check_2): Mark vars as initialized.
e5a2a5cb 6052
a60e5f68
PE
6053 * gtkutil.c (xg_get_file_with_chooser): Mark var as initialized.
6054
f661cb61 6055 * image.c (lookup_image): Remove var that is set but not used.
35fa624f 6056 (xbm_load): Use parse_p, for gcc -Werror=unused-but-set-variable.
f661cb61 6057
f0397f5a
PE
6058 * fontset.c (Finternal_char_font, Ffontset_info): Remove vars
6059 that are set but not used.
6060
8664db06 6061 * xfns.c (make_invisible_cursor): Don't return garbage
03733ee7 6062 if XCreateBitmapFromData fails (Bug#8410).
8664db06 6063
6abdaa4a
PE
6064 * xselect.c (x_get_local_selection, x_handle_property_notify):
6065 Remove vars that are set but not used.
6066
0ce7538d 6067 * xfns.c (x_create_tip_frame): Remove var that is set but not used.
6abdaa4a 6068 (make_invisible_cursor): Initialize a possibly-uninitialized variable.
0ce7538d 6069
9ae848fc
PE
6070 * xterm.c (x_scroll_bar_to_input_event) [!USE_GTK]:
6071 Remove var that is set but not used.
0b918413
PE
6072 (scroll_bar_windows_size): Now size_t, not int.
6073 (x_send_scroll_bar_event): Use size_t, not int, for sizes.
6074 Check for overflow.
9ae848fc 6075
a5a62657
PE
6076 * xfaces.c (realize_named_face): Remove vars that are set but not used.
6077 (map_tty_color) [!defined MSDOS]: Likewise.
6078
5c5cdd39
PE
6079 * term.c (tty_write_glyphs): Use size_t; this avoids overflow warning.
6080
66ebf983
PE
6081 * coding.c: Remove vars that are set but not used.
6082 (DECODE_COMPOSITION_RULE): Remove 2nd arg, which is unused.
6083 All callers changed.
6084 (decode_coding_utf_8, decode_coding_utf_16 decode_coding_emacs_mule):
6085 (decode_coding_iso_2022, encode_coding_sjis, encode_coding_big5):
6086 (decode_coding_charset): Remove vars that are set but not used.
6087
1be4d761
PE
6088 * bytecode.c (Fbyte_code) [!defined BYTE_CODE_SAFE]: Remove var
6089 that is set but not used.
6090
47553fa8
PE
6091 * print.c (print_object): Remove var that is set but not used.
6092
1f7196bf 6093 Replace 2 copies of readlink code with 1 gnulib version (Bug#8401).
d1fdcab7
PE
6094 The gnulib version avoids calling malloc in the usual case,
6095 and on 64-bit hosts doesn't have some arbitrary 32-bit limits.
6096 * fileio.c (Ffile_symlink_p): Use emacs_readlink.
6097 * filelock.c (current_lock_owner): Likewise.
6098 * lisp.h (READLINK_BUFSIZE, emacs_readlink): New function.
6099 * sysdep.c: Include allocator.h, careadlinkat.h.
6100 (emacs_no_realloc_allocator): New static constant.
6101 (emacs_readlink): New function.
fdb61804
PE
6102 * deps.mk (sysdep.o): Depend on ../lib/allocator.h and on
6103 ../lib/careadlinkat.h.
d1fdcab7 6104
f84c17c7
SM
61052011-04-04 Stefan Monnier <monnier@iro.umontreal.ca>
6106
6107 * keyboard.c (safe_run_hook_funcall): Fix last change (don't stop at the
6108 first non-nil return value).
6109
ef3862ad
JD
61102011-04-03 Jan Djärv <jan.h.d@swipnet.se>
6111
6112 * nsterm.m (ns_update_auto_hide_menu_bar): Define MAC_OS_X_VERSION_10_6
6113 if not defined (Bug#8403).
6114
376a7006
JB
61152011-04-02 Juanma Barranquero <lekktu@gmail.com>
6116
6117 * xdisp.c (display_count_lines): Remove parameter `start',
6118 unused since 1998-01-01T02:27:27Z!rms@gnu.org. All callers changed.
6119 (get_char_face_and_encoding): Remove parameter `multibyte_p',
6120 unused since 2008-05-14T01:40:23Z!handa@m17n.org. All callers changed.
6121 (fill_stretch_glyph_string): Remove parameters `row' and `area',
6122 unused at least since Kim's GUI unification at 2003-03-16T20:45:46Z!storm@cua.dk
6123 and thereabouts. All callers changed.
6124 (get_per_char_metric): Remove parameter `f', unused since
6125 2008-05-14T01:40:23Z!handa@m17n.org. All callers changed.
6126
6ca3801d
JM
61272011-04-02 Jim Meyering <meyering@redhat.com>
6128
6129 do not dereference NULL upon failed strdup
6130 * nsfont.m (ns_descriptor_to_entity): Use xstrdup, not strdup.
6131 (ns_get_family): Likewise.
6132
d8e2b5ba
JB
61332011-04-02 Juanma Barranquero <lekktu@gmail.com>
6134
6135 * eval.c (unwind_to_catch) [DEBUG_GCPRO]: Remove redundant assignment.
6136
8c74fcbd
JD
61372011-04-02 Jan Djärv <jan.h.d@swipnet.se>
6138
6139 * nsterm.m (ns_update_auto_hide_menu_bar): Only for OSX 10.6 or
6140 later (Bug#8403).
6141
7200d79c
SM
61422011-04-01 Stefan Monnier <monnier@iro.umontreal.ca>
6143
03408648 6144 Add lexical binding.
7200d79c 6145
03408648
SM
6146 * window.c (Ftemp_output_buffer_show): New fun.
6147 (Fsave_window_excursion):
6148 * print.c (Fwith_output_to_temp_buffer): Move to subr.el.
6149
6150 * lread.c (lisp_file_lexically_bound_p): New function.
6151 (Fload): Bind Qlexical_binding.
6152 (readevalloop): Remove `evalfun' arg.
6153 Bind Qinternal_interpreter_environment.
6154 (Feval_buffer): Bind Qlexical_binding.
6155 (defvar_int, defvar_bool, defvar_lisp_nopro, defvar_kboard):
6156 Mark as dynamic.
6157 (syms_of_lread): Declare `lexical-binding'.
6158
6159 * lisp.h (struct Lisp_Symbol): New field `declared_special'.
6160
6161 * keyboard.c (eval_dyn): New fun.
6162 (menu_item_eval_property): Use it.
ca105506
SM
6163
6164 * image.c (parse_image_spec): Use Ffunctionp.
ca105506 6165
03408648
SM
6166 * fns.c (concat, mapcar1): Accept byte-code-functions.
6167
6168 * eval.c (Fsetq): Handle lexical vars.
6169 (Fdefun, Fdefmacro, Ffunction): Make closures when needed.
6170 (Fdefconst, Fdefvaralias, Fdefvar): Mark as dynamic.
6171 (FletX, Flet): Obey lexical binding.
6172 (Fcommandp): Handle closures.
6173 (Feval): New `lexical' arg.
6174 (eval_sub): New function extracted from Feval. Use it almost
6175 everywhere where Feval was used. Look up vars in lexical env.
6176 Handle closures.
6177 (Ffunctionp): Move from subr.el.
6178 (Ffuncall): Handle closures.
6179 (apply_lambda): Remove `eval_flags'.
6180 (funcall_lambda): Handle closures and new byte-code-functions.
6181 (Fspecial_variable_p): New function.
6182 (syms_of_eval): Initialize the Vinternal_interpreter_environment var,
6183 but without exporting it to Lisp.
23aba0ea 6184
23aba0ea 6185 * doc.c (Fdocumentation, store_function_docstring):
03408648 6186 * data.c (Finteractive_form): Handle closures.
23aba0ea 6187
03408648
SM
6188 * callint.c (Fcall_interactively): Preserve lexical-binding mode for
6189 interactive spec.
ba83908c 6190
04f2d78b
CB
6191 * bytecode.c (Bstack_ref, Bstack_set, Bstack_set2, BdiscardN):
6192 New byte-codes.
03408648
SM
6193 (exec_byte_code): New function extracted from Fbyte_code to handle new
6194 calling convention for byte-code-functions. Add new byte-codes.
ba83908c 6195
03408648 6196 * buffer.c (defvar_per_buffer): Set new `declared_special' field.
e2abe5a1 6197
03408648 6198 * alloc.c (Fmake_symbol): Init new `declared_special' field.
e2abe5a1 6199
e2abce01
JB
62002011-03-31 Juanma Barranquero <lekktu@gmail.com>
6201
6202 * xdisp.c (redisplay_internal): Fix prototype.
6203
63696a73 62042011-03-31 Eli Zaretskii <eliz@gnu.org>
09725d26 6205
63696a73 6206 * xdisp.c (SCROLL_LIMIT): New macro.
04f2d78b
CB
6207 (try_scrolling): Use it when setting scroll_limit.
6208 Limit scrolling to 100 screen lines.
63696a73
EZ
6209 (redisplay_window): Even when falling back on "recentering",
6210 position point in the window according to scroll-conservatively,
6211 scroll-margin, and scroll-*-aggressively variables. (Bug#6671)
6212
6213 (try_scrolling): When point is above the window, allow searching
6214 as far as scroll_max, or one screenful, to compute vertical
6215 distance from PT to the scroll margin position. This prevents
6216 try_scrolling from unnecessarily failing when
6217 scroll-conservatively is set to a value slightly larger than the
6218 window height. Clean up the case of PT below the margin at bottom
6219 of window: scroll_max can no longer be INT_MAX. When aggressive
6220 scrolling is in use, don't let point enter the opposite scroll
6221 margin as result of the scroll.
6222 (syms_of_xdisp) <scroll-conservatively>: Document the
09725d26
EZ
6223 threshold of 100 lines for never-recentering scrolling.
6224
e4cc2dfc
JB
62252011-03-31 Juanma Barranquero <lekktu@gmail.com>
6226
6227 * dispextern.h (move_it_by_lines):
6228 * xdisp.c (move_it_by_lines): Remove parameter `need_y_p', unused
6229 since 2000-12-29T14:24:09Z!gerd@gnu.org. All callers changed.
6230 (message_log_check_duplicate): Remove parameters `prev_bol' and
6231 `this_bol', unused since 1998-01-01T02:27:27Z!rms@gnu.org. All callers changed.
6232 (redisplay_internal): Remove parameter `preserve_echo_area',
6233 unused since 1999-07-21T21:43:52Z!gerd@gnu.org. All callers changed.
6234
6235 * indent.c (Fvertical_motion):
6236 * window.c (window_scroll_pixel_based, Frecenter):
6237 Don't pass `need_y_p' to `move_it_by_lines'.
6238
1c470562
SM
62392011-03-30 Stefan Monnier <monnier@iro.umontreal.ca>
6240
44f230aa
SM
6241 * eval.c (struct backtrace): Don't cheat with negative numbers, but do
6242 steal a few bits to be more compact.
6243 (interactive_p, Fbacktrace, Fbacktrace_frame, mark_backtrace):
6244 Remove unneeded casts.
6245
1c470562
SM
6246 * bytecode.c (Fbyte_code): CAR and CDR can GC.
6247
888adce9
ZK
62482011-03-30 Zachary Kanfer <zkanfer@gmail.com> (tiny change)
6249
6250 * keyboard.c (Fexecute_extended_command): Do log the "suggest key
6251 binding" message (bug#7967).
6252
f838ed7b
PE
62532011-03-30 Paul Eggert <eggert@cs.ucla.edu>
6254
77861b95
PE
6255 Fix more problems found by GCC 4.6.0's static checks.
6256
de6dbc14
PE
6257 * unexelf.c (unexec) [! (defined _SYSTYPE_SYSV || defined __sgi)]:
6258 Remove unused local var.
6259
f838ed7b
PE
6260 * editfns.c (Fmessage_box): Remove unused local var.
6261
792c7b2b
PE
6262 * xdisp.c (try_window_reusing_current_matrix, x_produce_glyphs):
6263 (note_mode_line_or_margin_highlight, note_mouse_highlight):
6264 Omit unused local vars.
c499e557 6265 * window.c (shrink_windows): Omit unused local var.
b01a1c29 6266 * menu.c (digest_single_submenu): Omit unused local var.
0bc32927
PE
6267 * dispnew.c (update_window) [PERIODIC_PREEMPTION_CHECKING]:
6268 Omit unused local var.
6269
ba0165e1
PE
6270 * keyboard.c (parse_modifiers_uncached, parse_modifiers):
6271 Don't assume string length fits in int.
32ad8845 6272 (keyremap_step, read_key_sequence): Use size_t for sizes.
48011560 6273 (read_key_sequence): Don't check last_real_key_start redundantly.
ba0165e1 6274
3c59b4c9
PE
6275 * callproc.c (Fcall_process, Fcall_process_region): Use SAFE_ALLOCA
6276 instead of alloca (Bug#8344).
6277
a3eed478 6278 * eval.c (Fbacktrace): Don't assume nargs fits in int.
5d5d959d 6279 (Fbacktrace_frame): Don't assume nframes fits in int.
a3eed478 6280
eb4d412d
PE
6281 * syntax.c (scan_sexps_forward): Avoid pointer wraparound.
6282
1658b401
PE
6283 * xterm.c (x_make_frame_visible, same_x_server): Redo to avoid overflow
6284 concerns.
6285
6286 * term.c (produce_glyphless_glyph): Remove unnecessary test.
6287
6288 * cm.c (calccost): Turn while-do into do-while, for clarity.
44f730c8 6289
9a2c6e05
PE
6290 * keyboard.c (syms_of_keyboard): Use the same style as later
6291 in this function when indexing through an array. This also
6292 works around GCC bug 48267.
6293
03d0a109
PE
6294 * image.c (tiff_load): Fix off-by-one image count (Bug#8336).
6295
44f730c8
PE
6296 * xselect.c (x_check_property_data): Return correct size (Bug#8335).
6297
fe75f926
PE
6298 * chartab.c (sub_char_table_ref_and_range): Redo for slight
6299 efficiency gain, and to bypass a gcc -Wstrict-overflow warning.
6300
ffa8c828
PE
6301 * keyboard.c, keyboard.h (num_input_events): Now size_t.
6302 This avoids undefined behavior on integer overflow, and is a bit
6303 more convenient anyway since it is compared to a size_t variable.
6304
c5101a77
PE
6305 Variadic C functions now count arguments with size_t, not int.
6306 This avoids an unnecessary limitation on 64-bit machines, which
6307 caused (substring ...) to crash on large vectors (Bug#8344).
6308 * lisp.h (struct Lisp_Subr.function.aMANY): Now takes size_t, not int.
6309 (DEFUN_ARGS_MANY, internal_condition_case_n, safe_call): Likewise.
77861b95 6310 All variadic functions and their callers changed accordingly.
c5101a77
PE
6311 (struct gcpro.nvars): Now size_t, not int. All uses changed.
6312 * data.c (arith_driver, float_arith_driver): Likewise.
6313 * editfns.c (general_insert_function): Likewise.
6314 * eval.c (struct backtrace.nargs, interactive_p)
6315 (internal_condition_case_n, run_hook_with_args, apply_lambda)
6316 (funcall_lambda, mark_backtrace): Likewise.
6317 * fns.c (concat): Likewise.
6318 * frame.c (x_set_frame_parameters): Likewise.
6319 * fns.c (get_key_arg): Now accepts and returns size_t, and returns
6320 0 if not found, not -1. All callers changed.
6321
dd3f25f7
PE
6322 * alloc.c (garbage_collect): Don't assume stack size fits in int.
6323 (stack_copy_size): Now size_t, not int.
6324 (stack_copy, stack_copy_size): Define only if MAX_SAVE_STACK > 0.
6325
461c2ab9
JB
63262011-03-28 Juanma Barranquero <lekktu@gmail.com>
6327
6328 * coding.c (encode_designation_at_bol): Remove parameter `charbuf_end',
6329 unused since 2002-03-01T01:17:24Z!handa@m17n.org and 2008-02-01T16:01:31Z!miles@gnu.org.
6330 All callers changed.
6331
6332 * lisp.h (multibyte_char_to_unibyte):
6333 * character.c (multibyte_char_to_unibyte): Remove parameter `rev_tbl',
6334 unused since 2002-03-01T01:16:34Z!handa@m17n.org and 2008-02-01T16:01:31Z!miles@gnu.org.
6335 * character.h (CHAR_TO_BYTE8):
6336 * cmds.c (internal_self_insert):
6337 * editfns.c (general_insert_function):
6338 * keymap.c (push_key_description):
6339 * search.c (Freplace_match):
6340 * xdisp.c (message_dolog, set_message_1): All callers changed.
6341
f6d62986
SM
63422011-03-28 Stefan Monnier <monnier@iro.umontreal.ca>
6343
6344 * keyboard.c (safe_run_hook_funcall): New function.
6345 (safe_run_hooks_1, safe_run_hooks_error, safe_run_hooks): On error,
6346 don't set the hook to nil, but remove the offending function instead.
6347 (Qcommand_hook_internal): Remove, unused.
6348 (syms_of_keyboard): Don't initialize Qcommand_hook_internal nor define
6349 Vcommand_hook_internal.
6350
6351 * eval.c (enum run_hooks_condition): Remove.
6352 (funcall_nil, funcall_not): New functions.
6353 (run_hook_with_args): Call each function through a `funcall' argument.
6354 Remove `cond' argument, now redundant.
6355 (Frun_hooks, Frun_hook_with_args, Frun_hook_with_args_until_success)
6356 (Frun_hook_with_args_until_failure): Adjust accordingly.
6357 (run_hook_wrapped_funcall, Frun_hook_wrapped): New functions.
6358
1db5b1ad
JB
63592011-03-28 Juanma Barranquero <lekktu@gmail.com>
6360
6361 * dispextern.h (string_buffer_position): Remove declaration.
6362
6363 * print.c (strout): Remove parameter `multibyte', unused since
6364 1999-08-21T19:30:21Z!gerd@gnu.org. All callers changed.
6365
6366 * search.c (boyer_moore): Remove parameters `len', `pos' and `lim',
6367 never used since function introduction in 1998-02-08T21:33:56Z!rms@gnu.org.
6368 All callers changed.
6369
6370 * w32.c (_wsa_errlist): Use braces for struct initializers.
6371
6372 * xdisp.c (string_buffer_position_lim): Remove parameter `w',
6373 never used since function introduction in 2001-03-09T18:41:50Z!gerd@gnu.org.
6374 All callers changed.
6375 (string_buffer_position): Likewise. Also, make static (it's never
6376 used outside xdisp.c).
6377 (cursor_row_p): Remove parameter `w', unused since
6378 2000-10-17T16:08:57Z!gerd@gnu.org. All callers changed.
6379 (decode_mode_spec): Remove parameter `precision', introduced during
6380 Gerd Moellmann's rewrite at 1999-07-21T21:43:52Z!gerd@gnu.org, but never used.
6381 All callers changed.
6382
5ffb62aa
JD
63832011-03-27 Jan Djärv <jan.h.d@swipnet.se>
6384
6385 * nsterm.m (syms_of_nsterm): Use doc: for ns-auto-hide-menu-bar.
6386
461c2ab9 63872011-03-27 Anders Lindgren <andlind@gmail.com>
f0a1382a
JD
6388
6389 * nsterm.m (ns_menu_bar_is_hidden): New variable.
6390 (ns_constrain_all_frames, ns_menu_bar_should_be_hidden)
6391 (ns_update_auto_hide_menu_bar): New functions.
6392 (ns_update_begin): Call ns_update_auto_hide_menu_bar.
6393 (applicationDidBecomeActive): Call ns_update_auto_hide_menu_bar and
6394 ns_constrain_all_frames.
6395 (constrainFrameRect): Return at once if ns_menu_bar_should_be_hidden.
6396 (syms_of_nsterm): DEFVAR ns-auto-hide-menu-bar, init to Qnil.
6397
5c380ffb
JD
63982011-03-27 Jan Djärv <jan.h.d@swipnet.se>
6399
6400 * nsmenu.m (runDialogAt): Remove argument to timer_check.
6401
9af30bdf
GM
64022011-03-27 Glenn Morris <rgm@gnu.org>
6403
6404 * syssignal.h: Replace RETSIGTYPE with void.
6405 * atimer.c, data.c, dispnew.c, emacs.c, floatfns.c, keyboard.c:
6406 * keyboard.h, lisp.h, process.c, sysdep.c, xterm.c:
6407 Replace SIGTYPE with void everywhere.
6408 * s/usg5-4-common.h (SIGTYPE): Remove definition.
6409 * s/template.h (SIGTYPE): Remove commented out definition.
6410
e2abce01
JB
64112011-03-26 Eli Zaretskii <eliz@gnu.org>
6412
6413 * xdisp.c (redisplay_window): Don't check buffer's clip_changed
6414 flag as a prerequisite for invoking try_scrolling. (Bug#6671)
6415
f868cd8a
JB
64162011-03-26 Juanma Barranquero <lekktu@gmail.com>
6417
59eb0929
JB
6418 * w32.c (read_unc_volume): Use parameter `henum', instead of
6419 global variable `wget_enum_handle'.
6420
6421 * keymap.c (describe_vector): Remove parameters `indices' and
6422 `char_table_depth', unused since 2002-03-01T01:43:26Z!handa@m17n.org.
6423 (describe_map, Fdescribe_vector): Adjust calls to `describe_vector'.
6424
f868cd8a
JB
6425 * keyboard.h (timer_check, show_help_echo): Remove unused parameters.
6426
6427 * keyboard.c (timer_check): Remove parameter `do_it_now',
6428 unused since 1996-04-12T06:01:29Z!rms@gnu.org.
6429 (show_help_echo): Remove parameter `ok_to_overwrite_keystroke_echo',
6430 unused since 2008-04-19T19:30:53Z!monnier@iro.umontreal.ca.
6431
6432 * keyboard.c (read_char):
6433 * w32menu.c (w32_menu_display_help):
6434 * xmenu.c (show_help_event, menu_help_callback):
6435 Adjust calls to `show_help_echo'.
6436
6437 * gtkutil.c (xg_maybe_add_timer):
6438 * keyboard.c (readable_events):
6439 * process.c (wait_reading_process_output):
6440 * xmenu.c (x_menu_wait_for_event): Adjust calls to `timer_check'.
6441
6442 * insdel.c (adjust_markers_gap_motion):
6443 Remove; no-op since 1998-01-02T21:29:48Z!rms@gnu.org.
6444 (gap_left, gap_right): Don't call it.
6445
2ecf6fdb
CY
64462011-03-25 Chong Yidong <cyd@stupidchicken.com>
6447
6448 * xdisp.c (handle_fontified_prop): Discard changes to clip_changed
6449 incurred during fontification.
6450
6b1f9ba4
JB
64512011-03-25 Juanma Barranquero <lekktu@gmail.com>
6452
6453 * buffer.c (defvar_per_buffer): Remove unused parameter `doc'.
6454 (DEFVAR_PER_BUFFER): Don't pass it.
6455
6456 * dispnew.c (row_equal_p, add_row_entry): Remove unused parameter `w'.
6457 (scrolling_window): Don't pass it.
6458
0f4a96b5
JB
64592011-03-25 Juanma Barranquero <lekktu@gmail.com>
6460
6461 * dispextern.h (glyph_matric): Use #if GLYPH_DEBUG, not #ifdef.
6462
6463 * fileio.c (check_executable) [DOS_NT]: Remove unused variables `len'
6464 and `suffix'.
6465 (Fset_file_selinux_context) [HAVE_LIBSELINUX]: Move here declaration
6466 of variables specific to SELinux and computation of `encoded_absname'.
6467
6468 * image.c (XPutPixel): Remove unused variable `height'.
6469
6470 * keyboard.c (make_lispy_event): Remove unused variable `hpos'.
6471
6472 * unexw32.c (get_section_info): Remove unused variable `section'.
6473
6474 * w32.c (stat): Remove unused variables `drive_root' and `devtype'.
6475 (system_process_attributes): Remove unused variable `sess'.
6476 (sys_read): Remove unused variable `err'.
6477
6478 * w32fns.c (top): Wrap variables with #if GLYPH_DEBUG, not #ifdef.
6479 (w32_wnd_proc): Remove unused variable `isdead'.
6480 (unwind_create_frame): Use #if GLYPH_DEBUG, not #ifdef.
6481 (Fx_server_max_request_size): Remove unused variable `dpyinfo'.
6482 (x_create_tip_frame): Remove unused variable `tem'.
6483
6484 * w32inevt.c (w32_console_read_socket):
6485 Remove unused variable `no_events'.
6486
6487 * w32term.c (x_draw_composite_glyph_string_foreground):
6488 Remove unused variable `width'.
6489
1149507c
JB
64902011-03-24 Juanma Barranquero <lekktu@gmail.com>
6491
6492 * w32term.c (x_set_glyph_string_clipping):
6493 Don't pass uninitialized region to CombineRgn.
6494
9c88f339
JB
64952011-03-23 Juanma Barranquero <lekktu@gmail.com>
6496
6497 * w32fns.c (x_set_menu_bar_lines): Remove unused variable `olines'.
6498 (w32_wnd_proc): Pass NULL to Windows API, not uninitialized buffer.
6499 (Fx_close_connection): Remove unused variable `i'.
6500
6501 * w32font.c (w32font_draw): Return number of glyphs.
6502 (w32font_open_internal): Remove unused variable `i'.
6503 (w32font_driver): Add missing initializer.
6504
6505 * w32menu.c (utf8to16): Remove unused variable `utf16'.
6506 (fill_in_menu): Remove unused variable `items_added'.
6507
6508 * w32term.c (last_mouse_press_frame): Remove static global variable.
6509 (w32_clip_to_row): Remove unused variable `f'.
6510 (x_delete_terminal): Remove unused variable `i'.
6511
6512 * w32uniscribe.c (uniscribe_shape): Remove unused variable `nclusters'.
6513 (NOTHING): Remove unused static global variable.
6514 (uniscribe_check_otf): Remove unused variable `table'.
6515 (uniscribe_font_driver): Add missing initializers.
6516
dee091a3
JD
65172011-03-23 Julien Danjou <julien@danjou.info>
6518
6519 * term.c (Fsuspend_tty, Fresume_tty):
6520 * minibuf.c (read_minibuf, run_exit_minibuf_hook):
6521 * window.c (temp_output_buffer_show):
6522 * insdel.c (signal_before_change):
6523 * frame.c (Fhandle_switch_frame):
6524 * fileio.c (Fdo_auto_save):
6525 * emacs.c (Fkill_emacs):
6526 * editfns.c (save_excursion_restore):
6527 * cmds.c (internal_self_insert):
6528 * callint.c (Fcall_interactively):
6529 * buffer.c (Fkill_all_local_variables):
6530 * keyboard.c (Fcommand_execute, Fsuspend_emacs, safe_run_hooks_1):
6531 Use Frun_hooks.
0f4a96b5 6532 (command_loop_1): Use Frun_hooks. Call safe_run_hooks
dee091a3
JD
6533 unconditionnaly since it does the check itself.
6534
2c520ab5 65352011-03-23 Paul Eggert <eggert@cs.ucla.edu>
f0641eff 6536
c9c49752
PE
6537 Fix more problems found by GCC 4.5.2's static checks.
6538
8abc3f12
PE
6539 * coding.c (encode_coding_raw_text): Avoid unnecessary test
6540 the first time through the loop, since we know p0 < p1 then.
6541 This also avoids a gcc -Wstrict-overflow warning.
6542
a2d26660
PE
6543 * lisp.h (SAFE_ALLOCA, SAFE_ALLOCA_LISP): Avoid 'int' overflow
6544 leading to a memory leak, possible in functions like
6545 load_charset_map_from_file that can allocate an unbounded number
b12ef411 6546 of objects (Bug#8318).
a2d26660 6547
916c72e9
PE
6548 * xmenu.c (set_frame_menubar): Use EMACS_UINT, not int, for indexes
6549 that could (at least in theory) be that large.
6550
19ab8a18
PE
6551 * xdisp.c (message_log_check_duplicate): Return unsigned long, not int.
6552 This is less likely to overflow, and avoids undefined behavior if
6553 overflow does occur. All callers changed. Use strtoul to scan
6554 for the unsigned long integer.
b7cbbd6f
PE
6555 (pint2hrstr): Simplify and tune code slightly.
6556 This also avoids a (bogus) GCC warning with gcc -Wstrict-overflow.
19ab8a18 6557
f0641eff
PE
6558 * scroll.c (do_scrolling): Work around GCC bug 48228.
6559 See <http://gcc.gnu.org/bugzilla/show_bug.cgi?id=48228>.
6560
7f650bb9
PE
6561 * frame.c (Fmodify_frame_parameters): Simplify loop counter.
6562 This also avoids a warning with gcc -Wstrict-overflow.
39f5e519
PE
6563 (validate_x_resource_name): Simplify count usage.
6564 This also avoids a warning with gcc -Wstrict-overflow.
7f650bb9 6565
37dd57d1
PE
6566 * fileio.c (Fcopy_file): Report error if fchown or fchmod
6567 fail (Bug#8306).
81e56e61 6568
699979fc 6569 * emacs.c (Fdaemon_initialized): Do not ignore I/O errors (Bug#8303).
dc1ca6a8 6570
401bf9b4
PE
6571 * process.c (Fmake_network_process): Use socklen_t, not int,
6572 where POSIX says socklen_t is required in portable programs.
6573 This fixes a porting bug on hosts like 64-bit HP-UX, where
591b2973 6574 socklen_t is wider than int (Bug#8277).
401bf9b4
PE
6575 (Fmake_network_process, server_accept_connection):
6576 (wait_reading_process_output, read_process_output):
6577 Likewise.
6578
b93aacde
PE
6579 * process.c: Rename or move locals to avoid shadowing.
6580 (list_processes_1, Fmake_network_process):
6581 (read_process_output_error_handler, exec_sentinel_error_handler):
6582 Rename or move locals.
4dc343ee 6583 (Fmake_network_process): Define label "retry_connect" only if needed.
0da49335 6584 (Fnetwork_interface_info): Fix pointer signedness.
f990b4e5 6585 (process_send_signal): Add cast to avoid pointer signedness problem.
7b808126 6586 (FIRST_PROC_DESC, IF_NON_BLOCKING_CONNECT): Remove unused macros.
c939f91b 6587 (create_process): Use 'volatile' to avoid vfork clobbering (Bug#8298).
b93aacde 6588
af8a867c 6589 Make tparam.h and terminfo.c consistent.
44f230aa
SM
6590 * cm.c (tputs, tgoto, BC, UP): Remove extern decls.
6591 Include tparam.h instead, since it declares them.
af8a867c
PE
6592 * cm.h (PC): Remove extern decl; tparam.h now does this.
6593 * deps.mk (cm.o, terminfo.o): Depend on tparam.h.
6594 * terminfo.c: Include tparam.h, to check interfaces.
6595 (tparm): Make 1st arg a const pointer in decl. Put it at top level.
6596 (tparam): Adjust signature to match interface in tparam.h;
6597 this removes some undefined behavior. Check that outstring and len
6598 are zero, which they always are with Emacs.
6599 * tparam.h (PC, BC, UP): New extern decls.
6600
0248044d 6601 * xftfont.c (xftfont_shape): Now static, and defined only if needed.
001a7ab4 6602 (xftfont_open): Rename locals to avoid shadowing.
0248044d 6603
8ff096c1 6604 * ftfont.c (ftfont_resolve_generic_family): Fix pointer signedness.
a00924bb
PE
6605 (ftfont_otf_capability, ftfont_shape): Omit decls if not needed.
6606 (OTF_TAG_SYM): Omit macro if not needed.
e932860f 6607 (ftfont_list): Remove unused local.
49eaafba
PE
6608 (get_adstyle_property, ftfont_pattern_entity):
6609 (ftfont_lookup_cache, ftfont_open, ftfont_anchor_point):
6610 Rename locals to avoid shadowing.
8ff096c1 6611
e2be39f6
PE
6612 * xfont.c (xfont_list_family): Mark var as initialized.
6613
c9735e30
PE
6614 * xml.c (make_dom): Now static.
6615
8f5201ae
PE
6616 * composite.c (composition_compute_stop_pos): Rename local to
6617 avoid shadowing.
b246f932
PE
6618 (composition_reseat_it): Remove unused locals.
6619 (find_automatic_composition, composition_adjust_point): Likewise.
80e079b2 6620 (composition_update_it): Mark var as initialized.
11b61122
PE
6621 (find_automatic_composition): Mark vars as initialized,
6622 with a FIXME (Bug#8290).
8f5201ae 6623
760fbc2c
PE
6624 character.h: Rename locals to avoid shadowing.
6625 * character.h (PREV_CHAR_BOUNDARY, FETCH_STRING_CHAR_ADVANCE):
6626 (FETCH_STRING_CHAR_AS_MULTIBYTE_ADVANCE, FETCH_CHAR_ADVANCE):
6627 (FETCH_CHAR_ADVANCE_NO_CHECK, INC_POS, DEC_POS, BUF_INC_POS):
6628 (BUF_DEC_POS): Be more systematic about renaming local temporaries
6629 to avoid shadowing.
6630
ff08eb85
PE
6631 * textprop.c (property_change_between_p): Remove; unused.
6632
fc7bf025
PE
6633 * intervals.c (interval_start_pos): Now static.
6634
235d7abc
PE
6635 * intervals.h (CHECK_TOTAL_LENGTH): Avoid empty "else".
6636
44f230aa
SM
6637 * atimer.c (start_atimer, append_atimer_lists, set_alarm):
6638 Rename locals to avoid shadowing.
3e7d6594 6639
50060332
PE
6640 * sound.c (wav_play, au_play, Fplay_sound_internal):
6641 Fix pointer signedness.
d01f234b 6642 (alsa_choose_format): Remove unused local var.
c83b8872
PE
6643 (wav_play): Initialize a variable to 0, to prevent undefined
6644 behavior (Bug#8278).
50060332 6645
c4fc4e30
PE
6646 * region-cache.c (insert_cache_boundary): Redo var to avoid shadowing.
6647
918436ed
PE
6648 * region-cache.h (pp_cache): New decl, for gcc -Wmissing-prototypes.
6649
c939f91b
PE
6650 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork
6651 clobbering (Bug#8298).
b9c7f648
PE
6652 * sysdep.c (sys_subshell): Likewise.
6653 Previously, the sys_subshell 'volatile' was incorrectly IF_LINTted out.
7e9123a2 6654
6bd8c144
PE
6655 * lisp.h (child_setup): Now NO_RETURN unless DOS_NT.
6656 This should get cleaned up, so that child_setup has the
6657 same signature on all platforms.
6658
7710357c 6659 * callproc.c (call_process_cleanup): Now static.
cb1d0ef7 6660 (relocate_fd): Rename locals to avoid shadowing.
7710357c 6661
c59da222
CY
66622011-03-22 Chong Yidong <cyd@stupidchicken.com>
6663
6664 * xterm.c (x_clear_frame): Remove XClearWindow call. This appears
6665 not to be necessary, and produces flickering.
6666
66b87493
GM
66672011-03-20 Glenn Morris <rgm@gnu.org>
6668
6669 * config.in: Remove file.
6670
45b6f6d5
JB
66712011-03-20 Juanma Barranquero <lekktu@gmail.com>
6672
6673 * minibuf.c (Vcompleting_read_function): Don't declare, global variables
6674 are now in src/globals.h.
6675 (syms_of_minibuf): Remove spurious & from previous change.
6676
3ec03f7e
LL
66772011-03-20 Leo <sdl.web@gmail.com>
6678
6679 * minibuf.c (completing-read-function): New variable.
6680 (completing-read-default): Rename from completing-read.
6681 (completing-read): Call completing-read-function.
6682
b14e3e21
CY
66832011-03-19 Juanma Barranquero <lekktu@gmail.com>
6684
6685 * xfaces.c (Fx_load_color_file):
6686 Read color file from absolute filename (bug#8250).
6687
f2b726e6
JB
66882011-03-19 Juanma Barranquero <lekktu@gmail.com>
6689
6690 * makefile.w32-in: Update dependencies.
6691
09f6ff02
EZ
66922011-03-17 Eli Zaretskii <eliz@gnu.org>
6693
6694 * makefile.w32-in ($(BLD)/unexw32.$(O)): Depend on $(SRC)/unexec.h.
6695
29a6015a
PE
66962011-03-17 Paul Eggert <eggert@cs.ucla.edu>
6697
a3a6c54e
PE
6698 Fix more problems found by GCC 4.5.2's static checks.
6699
b766f867
PE
6700 * process.c (make_serial_process_unwind, send_process_trap):
6701 (sigchld_handler): Now static.
6702
be02381c
PE
6703 * process.c (allocate_pty): Let PTY_ITERATION declare iteration vars.
6704 That way, the code declares only the vars that it needs.
6705 * s/aix4-2.h (PTY_ITERATION): Declare iteration vars.
6706 * s/cygwin.h (PTY_ITERATION): Likewise.
6707 * s/darwin.h (PTY_ITERATION): Likewise.
6708 * s/gnu-linux.h (PTY_ITERATION): Likewise.
6709
57048744
PE
6710 * s/irix6-5.h (PTY_OPEN): Declare stb, to loosen coupling.
6711 * process.c (allocate_pty): Don't declare stb unless it's needed.
6712
7914961c 6713 * bytecode.c (MAYBE_GC): Rewrite so as not to use empty "else".
615f2d59
PE
6714 (CONSTANTLIM): Remove; unused.
6715 (METER_CODE, Bscan_buffer, Bread_char, Bset_mark):
6716 Define only if needed.
7914961c 6717
b3967b18
PE
6718 * unexelf.c (unexec): Name an expression,
6719 to avoid gcc -Wbad-function-cast warning.
9ae71512
PE
6720 Use a different way to cause a compilation error if anyone uses
6721 n rather than nn, a way that does not involve shadowing.
73366a00 6722 (ELF_BSS_SECTION_NAME, OLD_PROGRAM_H): Remove; unused.
b3967b18 6723
29a6015a
PE
6724 * deps.mk (unexalpha.o): Remove; unused.
6725
43cfc33e 6726 New file unexec.h, the (simple) interface for unexec (Bug#8267).
7feda0d2 6727 * unexec.h: New file.
ce701a33
PE
6728 * deps.mk (emacs.o, unexaix.o, unexcw.o, unexcoff.o, unexelf.o):
6729 (unexhp9k800.o, unexmacosx.o, unexsol.o, unexw32.o):
6730 Depend on unexec.h.
6731 * emacs.c [!defined CANNOT_DUMP]: Include unexec.h.
6732 * unexaix.c, unexcoff.c, unexcw.c, unexelf.c, unexhp9k800.c:
6733 * unexmacosx.c, unexsol.c, unexw32.c: Include unexec.h.
381259ef 6734 Change as necessary to match prototype in unexec.h.
ce701a33 6735
01f44d5a
PE
6736 * syntax.c (Fforward_comment, scan_lists): Rename locals to avoid
6737 shadowing.
4f63c6bb 6738 (back_comment, skip_chars): Mark vars as initialized.
01f44d5a 6739
a6670b0b
PE
6740 * character.h (FETCH_STRING_CHAR_ADVANCE_NO_CHECK, BUF_INC_POS):
6741 Rename locals to avoid shadowing.
6742
cef2010d 6743 * lread.c (read1): Rewrite so as not to use empty "else".
0902fe45 6744 (Fload, readevalloop, read1): Rename locals to avoid shadowing.
cef2010d 6745
d4d7173a
PE
6746 * print.c (Fredirect_debugging_output): Fix pointer signedess.
6747
f08b802a
PE
6748 * lisp.h (debug_output_compilation_hack): Add decl here, to avoid
6749 warning when compiling print.c.
6750
3ddb0639
PE
6751 * font.c (font_unparse_fcname): Abort in an "impossible" situation
6752 instead of using an uninitialized var.
5ad03b97 6753 (font_sort_entities): Mark var as initialized.
3ddb0639 6754
170a2692
PE
6755 * character.h (FETCH_CHAR_ADVANCE): Rename locals to avoid shadowing.
6756
e663c700
PE
6757 * font.c (font_unparse_xlfd): Don't mix pointers to variables with
6758 pointers to constants.
89bc529a 6759 (font_parse_fcname): Remove unused vars.
7b81e2d0 6760 (font_delete_unmatched): Now static.
ea838e10 6761 (font_get_spec): Remove; unused.
13a547c6
PE
6762 (font_style_to_value, font_prop_validate_style, font_unparse_fcname):
6763 (font_update_drivers, Ffont_get_glyphs, font_add_log):
6764 Rename or move locals to avoid shadowing.
e663c700 6765
2a80c887 6766 * fns.c (require_nesting_list, require_unwind): Now static.
612f56df 6767 (Ffillarray): Rename locals to avoid shadowing.
2a80c887 6768
1384fa33 6769 * floatfns.c (domain_error2): Define only if needed.
a885e2ed 6770 (Ffrexp, Fldexp): Rename locals to avoid shadowing.
1384fa33 6771
8b2c52e9
PE
6772 * alloc.c (mark_backtrace): Move decl from here ...
6773 * lisp.h: ... to here, so that it can be checked.
6774
475545b5 6775 * eval.c (call_debugger, do_debug_on_call, grow_specpdl): Now static.
d28a2170 6776 (Fdefvar): Rewrite so as not to use empty "else".
cfcbfb1a
PE
6777 (lisp_indirect_variable): Name an expression,
6778 to avoid gcc -Wbad-function-cast warning.
1faed8ae 6779 (Fdefvar): Rename locals to avoid shadowing.
475545b5 6780
b1349114 6781 * callint.c (quotify_arg, quotify_args): Now static.
a3e8cbda 6782 (Fcall_interactively): Rename locals to avoid shadowing.
b0e80955 6783 Use const pointer when appropriate.
b1349114 6784
a2928364
PE
6785 * lisp.h (get_system_name, get_operating_system_release):
6786 Move decls here, to check interfaces.
6787 * process.c (get_operating_system_release): Move decl to lisp.h.
6788 * xrdb.c (get_system_name): Likewise.
63c5d10b
PE
6789 * editfns.c (init_editfns, Fuser_login_name, Fuser_uid):
6790 (Fuser_real_uid, Fuser_full_name): Remove unnecessary casts,
6791 some of which prompt warnings from gcc -Wbad-function-cast.
545b49b4
PE
6792 (Fformat_time_string, Fencode_time, Finsert_char):
6793 (Ftranslate_region_internal, Fformat):
6794 Rename or remove local vars to avoid shadowing.
9710023e 6795 (Ftranslate_region_internal): Mark var as initialized.
63c5d10b 6796
a415e694
PE
6797 * doc.c (Fdocumentation, Fsnarf_documentation): Move locals to
6798 avoid shadowing.
6799
8ef4622d
PE
6800 * lisp.h (eassert): Check that the argument compiles, even if
6801 ENABLE_CHECKING is not defined.
6802
946f9a5b
PE
6803 * data.c (Findirect_variable): Name an expression, to avoid
6804 gcc -Wbad-function-cast warning.
112396d6 6805 (default_value, arithcompare, arith_driver, arith_error): Now static.
b9b84fa9 6806 (store_symval_forwarding): Rename local to avoid shadowing.
44f230aa
SM
6807 (Fmake_variable_buffer_local, Fmake_local_variable):
6808 Mark variables as initialized.
52746918 6809 (do_blv_forwarding, do_symval_forwarding): Remove; unused.
946f9a5b 6810
e5aab7e7 6811 * alloc.c (check_cons_list): Do not define unless GC_CHECK_CONS_LIST.
ae35e756
PE
6812 (Fmake_vector, Fvector, Fmake_byte_code, Fgarbage_collect):
6813 Rename locals to avoid shadowing.
dff45157
PE
6814 (mark_stack): Move local variables into the #ifdef region where
6815 they're used.
7bc26fdb
PE
6816 (BLOCK_INPUT_ALLOC, UNBLOCK_INPUT_ALLOC): Define only if
6817 ! defined SYSTEM_MALLOC && ! defined SYNC_INPUT, as they are not
6818 needed otherwise.
6819 (CHECK_ALLOCATED): Define only if GC_CHECK_MARKED_OBJECTS.
6820 (GC_STRING_CHARS): Remove; not used.
d40d4be1 6821 (Fmemory_limit): Cast sbrk's returned value to char *.
ae35e756 6822
e5aab7e7
PE
6823 * lisp.h (check_cons_list): Declare if GC_CHECK_CONS_LIST; this
6824 avoids undefined behavior in theory.
6825
4da60324
PE
6826 * regex.c (IF_LINT): Add defn, for benefit of ../lib-src.
6827
88043301
PE
6828 Use functions, not macros, for up- and down-casing (Bug#8254).
6829 * buffer.h (DOWNCASE_TABLE, UPCASE_TABLE, DOWNCASE, UPPERCASEP):
6830 (NOCASEP, LOWERCASEP, UPCASE, UPCASE1): Remove. All callers changed
6831 to use the following functions instead of these macros.
6832 (downcase): Adjust to lack of DOWNCASE_TABLE. Return int, not
6833 EMACS_INT, since callers assume the returned value fits in int.
6834 (upcase1): Likewise, for UPCASE_TABLE.
6835 (uppercasep, lowercasep, upcase): New static inline functions.
0da09c43 6836 * editfns.c (Fchar_equal): Remove no-longer-needed workaround for
db69b0cd 6837 the race-condition problem in the old DOWNCASE.
88043301 6838
19ed5445
PE
6839 * regex.c (CHARSET_LOOKUP_RANGE_TABLE_RAW, POP_FAILURE_REG_OR_COUNT):
6840 Rename locals to avoid shadowing.
6841 (regex_compile, re_match_2_internal): Move locals to avoid shadowing.
abbd1bcf
PE
6842 (regex_compile, re_search_2, re_match_2_internal):
6843 Remove unused local vars.
952db0d7
PE
6844 (FREE_VAR): Rewrite so as not to use empty "else",
6845 which gcc can warn about.
da053e48 6846 (regex_compile, re_match_2_internal): Mark locals as initialized.
b313f9d8
PE
6847 (RETALLOC_IF): Define only if needed.
6848 (WORDCHAR_P): Likewise. This one is never needed, but is used
6849 only in a comment talking about a compiler bug, so put inside
6850 the #if 0 of that comment.
6851 (CHARSET_LOOKUP_BITMAP, FAIL_STACK_FULL, RESET_FAIL_STACK):
6852 (PUSH_FAILURE_ELT, BUF_PUSH_3, STOP_ADDR_VSTRING):
6853 Remove; unused.
19ed5445 6854
1f3561e4 6855 * search.c (boyer_moore): Rename locals to avoid shadowing.
76ef09b7
PE
6856 * character.h (FETCH_STRING_CHAR_AS_MULTIBYTE_ADVANCE):
6857 (PREV_CHAR_BOUNDARY): Likewise.
1f3561e4 6858
ded6f8f7
PE
6859 * search.c (simple_search): Remove unused var.
6860
dbd37a95
PE
6861 * dired.c (compile_pattern): Move decl from here ...
6862 * lisp.h: ... to here, so that it can be checked.
6863 (struct re_registers): New forward decl.
6864
7e47afad
PE
6865 * character.h (INC_POS, DEC_POS): Rename locals to avoid shadowing.
6866
85f24f61
PE
6867 * indent.c (MULTIBYTE_BYTES_WIDTH): New args bytes, width.
6868 All uses changed.
6869 (MULTIBYTE_BYTES_WIDTH, scan_for_column, compute_motion):
6870 Rename locals to avoid shadowing.
5671df8f 6871 (Fvertical_motion): Mark locals as initialized.
85f24f61 6872
181aa2be 6873 * casefiddle.c (casify_object, casify_region): Now static.
e45a141a 6874 (casify_region): Mark local as initialized.
181aa2be 6875
930d429c
PE
6876 * cmds.c (internal_self_insert): Rename local to avoid shadowing.
6877
7082eac6
PE
6878 * lisp.h (GCPRO2_VAR, GCPRO3_VAR, GCPRO4_VAR, GCPRO5_VAR, GCPRO6_VAR):
6879 New macros, so that the caller can use some names other than
6880 gcpro1, gcpro2, etc.
6881 (GCPRO2, GCPRO3, GCPRO4, GCPRO5, GCPRO6): Reimplement in terms
6882 of the new macros.
6883 (GCPRO1_VAR, UNGCPRO_VAR): Change the meaning of the second
6884 argument, for consistency with GCPRO2_VAR, etc: it is now the
6885 prefix of the variable, not the variable itself. All uses
6886 changed.
38b2c076
PE
6887 * dired.c (directory_files_internal, file_name_completion):
6888 Rename locals to avoid shadowing.
6889
15206ed9
PE
6890 Fix a race condition diagnosed by gcc -Wsequence-point (Bug#8254).
6891 An expression of the form (DOWNCASE (x) == DOWNCASE (y)), found in
6892 dired.c's scmp function, had undefined behavior.
6893 * lisp.h (DOWNCASE_TABLE, UPCASE_TABLE, DOWNCASE, UPPERCASEP):
6894 (NOCASEP, LOWERCASEP, UPCASE, UPCASE1): Move from here ...
6895 * buffer.h: ... to here, because these macros use current_buffer,
6896 and the new implementation with inline functions needs to have
6897 current_buffer in scope now, rather than later when the macros
6898 are used.
6899 (downcase, upcase1): New static inline functions.
6900 (DOWNCASE, UPCASE1): Reimplement using these functions.
6901 This avoids undefined behavior in expressions like
6902 DOWNCASE (x) == DOWNCASE (y), which previously suffered
6903 from race conditions in accessing the global variables
6904 case_temp1 and case_temp2.
6905 * casetab.c (case_temp1, case_temp2): Remove; no longer needed.
6906 * lisp.h (case_temp1, case_temp2): Remove their decls.
6907 * character.h (ASCII_CHAR_P): Move from here ...
6908 * lisp.h: ... to here, so that the inline functions mentioned
6909 above can use them.
6910
4a6bea26
PE
6911 * dired.c (directory_files_internal_unwind): Now static.
6912
f14b7e14
PE
6913 * fileio.c (file_name_as_directory, directory_file_name):
6914 (barf_or_query_if_file_exists, auto_save_error, auto_save_1):
6915 Now static.
2893f146
PE
6916 (file_name_as_directory): Use const pointers when appropriate.
6917 (Fexpand_file_name): Likewise. In particular, newdir might
6918 point at constant storage, so make it a const pointer.
fd4ead52 6919 (Fmake_directory_internal, Fread_file_name): Remove unused vars.
b14aac08
PE
6920 (Ffile_selinux_context, Fset_file_selinux_context): Fix pointer
6921 signedness issues.
f839df0c
PE
6922 (Fset_file_times, Finsert_file_contents, auto_save_error):
6923 Rename locals to avoid shadowing.
f14b7e14 6924
5716756e 6925 * minibuf.c (choose_minibuf_frame_1): Now static.
62137a95
PE
6926 (Ftry_completion, Fall_completions): Rename or remove locals
6927 to avoid shadowing.
5716756e 6928
b4c3046a
PE
6929 * marker.c (bytepos_to_charpos): Remove; unused.
6930
b45db522
PE
6931 * lisp.h (verify_bytepos, count_markers): New decls,
6932 so that gcc does not warn that these functions aren't declared.
6933
85876d07
PE
6934 * insdel.c (check_markers, make_gap_larger, make_gap_smaller):
6935 (reset_var_on_error, Fcombine_after_change_execute_1): Now static.
f0cb4a60 6936 (CHECK_MARKERS): Redo to avoid gcc -Wempty-body diagnostic.
40ef059e 6937 (copy_text): Remove unused local var.
85876d07 6938
03d78a21 6939 * filelock.c (within_one_second): Now static.
b3dd38ab 6940 (lock_file_1): Rename local to avoid shadowing.
03d78a21 6941
5df8f01b
PE
6942 * buffer.c (fix_overlays_before): Mark locals as initialized.
6943 (fix_start_end_in_overlays): Likewise. This function should be
6944 simplified by using pointers-to-pointers, but that's a different
6945 matter.
b1d876f1 6946 (switch_to_buffer_1): Now static.
8f54f30a
PE
6947 (Fkill_buffer, record_buffer, Fbury_buffer, Fset_buffer_multibyte):
6948 (report_overlay_modification): Rename locals to avoid shadowing.
c3bd59b5 6949
a70072c9 6950 * sysdep.c (system_process_attributes): Rename vars to avoid shadowing.
fbd02d7b 6951 Fix pointer signedness issue.
edced198
PE
6952 (sys_subshell): Mark local as volatile if checking for lint,
6953 to suppress a gcc -Wclobbered warning that does not seem to be right.
15dfd3d9 6954 (MAXPATHLEN): Define only if needed.
a70072c9 6955
a0977c44
PE
6956 * process.c (serial_open, serial_configure): Move decls from here ...
6957 * systty.h: ... to here, so that they can be checked.
6958
a884fdcc
PE
6959 * fns.c (get_random, seed_random): Move extern decls from here ...
6960 * lisp.h: ... to here, so that they can be checked.
6961
604efe86 6962 * sysdep.c (reset_io): Now static.
b8950c94 6963 (wait_for_termination_signal): Remove; unused.
604efe86 6964
38fc62d9
PE
6965 * keymap.c (keymap_parent, keymap_memberp, map_keymap_internal):
6966 (copy_keymap_item, append_key, push_text_char_description):
6967 Now static.
1004a21a 6968 (Fwhere_is_internal): Don't test CONSP (sequences) unnecessarily.
dbbb8427 6969 (DENSE_TABLE_SIZE): Remove; unused.
c1141155
PE
6970 (get_keymap, access_keymap, Fdefine_key, Fwhere_is_internal):
6971 (describe_map_tree):
6972 Rename locals to avoid shadowing.
38fc62d9 6973
2f2650da
PE
6974 * keyboard.c: Declare functions static if they are not used elsewhere.
6975 (echo_char, echo_dash, cmd_error, top_level_2):
6976 (poll_for_input, handle_async_input): Now static.
69a058fa
PE
6977 (read_char, kbd_buffer_get_event, make_lispy_position):
6978 (make_lispy_event, make_lispy_movement, apply_modifiers):
6979 (decode_keyboard_code, tty_read_avail_input, menu_bar_items):
6980 (parse_tool_bar_item, read_key_sequence, Fread_key_sequence):
6981 (Fread_key_sequence_vector): Rename locals to avoid shadowing.
c8a06054 6982 (read_key_sequence, read_char): Mark locals as initialized.
3ac94672 6983 (Fexit_recursive_edit, Fabort_recursive_edit): Mark with NO_RETURN.
2f2650da 6984
a053e86c 6985 * keyboard.h (make_ctrl_char): New decl.
da2f2dd9
PE
6986 (mark_kboards): Move decl here ...
6987 * alloc.c (mark_kboards): ... from here.
a053e86c 6988
4752793e
PE
6989 * lisp.h (force_auto_save_soon): New decl.
6990
74f10ca7 6991 * emacs.c (init_cmdargs): Rename local to avoid shadowing.
244fc23d
PE
6992 (DEFINE_DUMMY_FUNCTION): New macro.
6993 (__do_global_ctors, __do_global_ctors_aux, __do_global_dtors, __main):
6994 Use it.
c03cd23f
PE
6995 (main): Add casts to avoid warnings
6996 if GCC considers string literals to be constants.
74f10ca7 6997
022e70d4
PE
6998 * lisp.h (fatal_error_signal): Add decl, since it's exported.
6999
59d6fe83
PE
7000 * dbusbind.c: Pointer signedness fixes.
7001 (xd_signature, xd_append_arg, xd_initialize):
7002 (Fdbus_call_method, Fdbus_call_method_asynchronously):
7003 (Fdbus_method_return_internal, Fdbus_method_error_internal):
7004 (Fdbus_send_signal, xd_read_message_1, Fdbus_register_service):
7005 (Fdbus_register_signal): Use SSDATA when the context wants char *.
7006
78320123
PE
7007 * dbusbind.c (Fdbus_init_bus): Add cast to avoid warning
7008 if GCC considers string literals to be constants.
49cebcca 7009 (Fdbus_register_service, Fdbus_register_method): Remove unused vars.
78320123 7010
35ac2a97
SM
70112011-03-16 Stefan Monnier <monnier@iro.umontreal.ca>
7012
fb103ca9
SM
7013 * print.c (PRINT_CIRCLE_CANDIDATE_P): New macro.
7014 (print_preprocess, print_object): New macro to fix last change.
7015
35ac2a97
SM
7016 * print.c (print_preprocess): Don't forget font objects.
7017
62973b41
JB
70182011-03-16 Juanma Barranquero <lekktu@gmail.com>
7019
7020 * emacs.c (USAGE3): Doc fixes.
7021
0e48bb22
AS
70222011-03-15 Andreas Schwab <schwab@linux-m68k.org>
7023
7024 * coding.c (detect_coding_iso_2022): Reorganize code to clarify
7025 structure.
7026
7684e57b
JB
70272011-03-14 Juanma Barranquero <lekktu@gmail.com>
7028
7029 * lisp.h (VWindow_system, Qfile_name_history):
7030 * keyboard.h (lispy_function_keys) [WINDOWSNT]:
7031 * w32term.h (w32_system_caret_hwnd, w32_system_caret_height)
7032 (w32_system_caret_x, w32_system_caret_y): Declare extern.
7033
7034 * w32select.c: Don't #include "keyboard.h".
c96bbc66 7035 (run_protected): Add extern declaration for waiting_for_input.
7684e57b
JB
7036
7037 * w32.c (Qlocal, noninteractive1, inhibit_window_system):
7038 * w32console.c (detect_input_pending, read_input_pending)
7039 (encode_terminal_code):
7040 * w32fns.c (quit_char, lispy_function_keys, Qtooltip)
7041 (w32_system_caret_hwnd, w32_system_caret_height, w32_system_caret_x)
7042 (w32_system_caret_y, Qfile_name_history):
7043 * w32font.c (w32font_driver, QCantialias, QCotf, QClang):
7044 * w32inevt.c (reinvoke_input_signal, lispy_function_keys):
7045 * w32menu.c (Qmenu_bar, QCtoggle, QCradio, Qoverriding_local_map)
7046 (Qoverriding_terminal_local_map, Qmenu_bar_update_hook):
7047 * w32proc.c (Qlocal, report_file_error):
7048 * w32term.c (Vwindow_system, updating_frame):
7049 * w32uniscribe.c (initialized, uniscribe_font_driver):
7050 Remove unneeded extern declarations.
7051
2aa46d6c
CY
70522011-03-14 Chong Yidong <cyd@stupidchicken.com>
7053
c96bbc66 7054 * buffer.c (Fmake_indirect_buffer): Fix incorrect assertions.
2aa46d6c 7055
cffc6f3b
CY
70562011-03-13 Chong Yidong <cyd@stupidchicken.com>
7057
7058 * buffer.h (BUF_BEGV, BUF_BEGV_BYTE, BUF_ZV, BUF_ZV_BYTE, BUF_PT)
7059 (BUF_PT_BYTE): Rewrite to handle indirect buffers (Bug#8219).
7060 These macros can no longer be used for assignment.
7061
44f230aa
SM
7062 * buffer.c (Fget_buffer_create, Fmake_indirect_buffer):
7063 Assign struct members directly, instead of using BUF_BEGV etc.
cffc6f3b
CY
7064 (record_buffer_markers, fetch_buffer_markers): New functions for
7065 recording and fetching special buffer markers.
7066 (set_buffer_internal_1, set_buffer_temp): Use them.
7067
7068 * lread.c (unreadchar): Use SET_BUF_PT_BOTH.
7069
7070 * insdel.c (adjust_point): Use SET_BUF_PT_BOTH.
7071
7072 * intervals.c (temp_set_point_both): Use SET_BUF_PT_BOTH.
7073 (get_local_map): Use SET_BUF_BEGV_BOTH and SET_BUF_ZV_BOTH.
7074
7075 * xdisp.c (hscroll_window_tree):
7076 (reconsider_clip_changes): Use PT instead of BUF_PT.
7077
d251f04b
EZ
70782011-03-13 Eli Zaretskii <eliz@gnu.org>
7079
7080 * makefile.w32-in ($(BLD)/editfns.$(O)): Depend on
7081 $(EMACS_ROOT)/lib/intprops.h.
7082
f0c77cd1
PE
70832011-03-13 Paul Eggert <eggert@cs.ucla.edu>
7084
3eca4629
PE
7085 Fix more problems found by GCC 4.5.2's static checks.
7086
7c86ee98
PE
7087 * gtkutil.c (xg_get_pixbuf_from_pixmap): Add cast from char *
7088 to unsigned char * to avoid compiler diagnostic.
b0afc268
PE
7089 (xg_free_frame_widgets): Make it clear that a local variable is
7090 needed only if USE_GTK_TOOLTIP.
01e0b5ad
PE
7091 (gdk_window_get_screen): Make it clear that this macro is needed
7092 only if USE_GTK_TOOLTIP.
1e5524e7
PE
7093 (int_gtk_range_get_value): New function, which avoids a diagnostic
7094 from gcc -Wbad-function-cast.
7095 (xg_set_toolkit_scroll_bar_thumb): Use it.
7096 (xg_tool_bar_callback, xg_tool_item_stale_p): Rewrite to avoid
7097 diagnostic from gcc -Wbad-function-cast.
65dc836c
PE
7098 (get_utf8_string, xg_get_file_with_chooser):
7099 Rename locals to avoid shadowing.
7100 (create_dialog): Move locals to avoid shadowing.
7c86ee98 7101
41729b81
PE
7102 * xgselect.c (xg_select): Remove unused var.
7103
f0c77cd1
PE
7104 * image.c (four_corners_best): Mark locals as initialized.
7105 (gif_load): Initialize transparent_p to zero (Bug#8238).
7106 Mark another local as initialized.
ec6cf4c6 7107 (my_png_error, my_error_exit): Mark with NO_RETURN.
f0c77cd1 7108
ce0ad53d 7109 * image.c (clear_image_cache): Now static.
d5d5a617 7110 (DIM, HAVE_STDLIB_H_1): Remove unused macros.
e22cffbc 7111 (xpm_load): Redo to avoid "discards qualifiers" gcc warning.
77a765fd
PE
7112 (x_edge_detection): Remove unnecessary cast that
7113 gcc -Wbad-function-cast diagnoses.
2037898d 7114 (gif_load): Fix pointer signedness.
6ae141d6
PE
7115 (clear_image_cache, xbm_read_bitmap_data, x_detect_edges):
7116 (jpeg_load, gif_load): Rename locals to avoid shadowing.
ce0ad53d 7117
33383987 71182011-03-12 Paul Eggert <eggert@cs.ucla.edu>
3eca4629 7119
d32df629
PE
7120 Improve quality of tests for time stamp overflow.
7121 For example, without this patch (encode-time 0 0 0 1 1
7122 1152921504606846976) returns the obviously-bogus value (-948597
7123 62170) on my RHEL 5.5 x86-64 host. With the patch, it correctly
7124 reports time overflow. See
7125 <http://lists.gnu.org/archive/html/emacs-devel/2011-03/msg00470.html>.
b8d9bd41
PE
7126 * deps.mk (editfns.o): Depend on ../lib/intprops.h.
7127 * editfns.c: Include limits.h and intprops.h.
7128 (TIME_T_MIN, TIME_T_MAX): New macros.
7129 (time_overflow): Move earlier, to before first use.
7130 (hi_time, lo_time): New functions, for an accurate test for
7131 out-of-range times.
7132 (Fcurrent_time, Fget_internal_run_time, make_time): Use them.
7133 (Fget_internal_run_time): Don't assume time_t fits in int.
7134 (make_time): Use list2 instead of Fcons twice.
7135 (Fdecode_time): More accurate test for out-of-range times.
7136 (check_tm_member): New function.
7137 (Fencode_time): Use it, to test for out-of-range times.
d32df629
PE
7138 (lisp_time_argument): Don't rely on undefined left-shift and
7139 right-shift behavior when checking for time stamp overflow.
8be6f318 7140
fe31d94c
PE
7141 * editfns.c (time_overflow): New function, refactoring common code.
7142 (Fformat_time_string, Fdecode_time, Fencode_time):
7143 (Fcurrent_time_string): Use it.
7144
8be6f318
PE
7145 Move 'make_time' to be next to its inverse 'lisp_time_argument'.
7146 * dired.c (make_time): Move to ...
7147 * editfns.c (make_time): ... here.
7148 * systime.h: Note the move.
7149
09d9db2c 71502011-03-12 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
c47cbdfd 7151
126bc0dc
YM
7152 * fringe.c (update_window_fringes): Remove unused variables.
7153
c47cbdfd
YM
7154 * unexmacosx.c (copy_data_segment): Also copy __got section.
7155 (Bug#8223)
7156
7ac80be9
EZ
71572011-03-12 Eli Zaretskii <eliz@gnu.org>
7158
c96bbc66 7159 * termcap.c [MSDOS]: Include "msdos.h".
058e5dad
EZ
7160 (find_capability, tgetnum, tgetflag, tgetstr, tputs, tgetent):
7161 Constify `char *' arguments and their references according to
7162 prototypes in tparam.h.
7163
ecb0f94d 7164 * deps.mk (termcap.o): Depend on tparam.h and msdos.h.
058e5dad 7165
7ac80be9
EZ
7166 * msdos.c (XMenuAddPane): 3rd argument is `const char *' now.
7167 Adapt all references accordingly.
7168
7169 * msdos.h (XMenuAddPane): 3rd argument is `const char *' now.
7170
ef1fd07e
TT
71712011-03-11 Tom Tromey <tromey@redhat.com>
7172
7173 * buffer.c (syms_of_buffer): Remove obsolete comment.
7174
7ef4b50c
EZ
71752011-03-11 Eli Zaretskii <eliz@gnu.org>
7176
7177 * termhooks.h (encode_terminal_code): Declare prototype.
7178
7179 * msdos.c (encode_terminal_code): Don't declare prototype.
7180
7181 * term.c (encode_terminal_code): Now external again, used by
7182 w32console.c and msdos.c.
7183
44f230aa
SM
7184 * makefile.w32-in ($(BLD)/term.$(O), ($(BLD)/tparam.$(O)):
7185 Depend on $(SRC)/tparam.h, see 2011-03-11T07:24:21Z!eggert@cs.ucla.edu.
7ef4b50c 7186
4b1ec863 71872011-03-11 Paul Eggert <eggert@cs.ucla.edu>
f78faa98 7188
1714f52b 7189 Fix some minor problems found by GCC 4.5.2's static checks.
83316bf4 7190
4b1ec863
PE
7191 * fringe.c (update_window_fringes): Mark locals as initialized
7192 (Bug#8227).
7193 (destroy_fringe_bitmap, init_fringe_bitmap): Now static.
bf60f616 7194
524c7aa6
PE
7195 * alloc.c (mark_fringe_data): Move decl from here ...
7196 * lisp.h (mark_fringe_data) [HAVE_WINDOW_SYSTEM]: ... to here,
7197 to check its interface.
7198 (init_fringe_once): Do not declare unless HAVE_WINDOW_SYSTEM.
7199
a5c0af81 7200 * fontset.c (free_realized_fontset): Now static.
7519b8cd 7201 (Fset_fontset_font): Rename local to avoid shadowing.
cc6e5db1 7202 (fontset_font): Mark local as initialized.
a9a06e0b 7203 (FONTSET_SPEC, FONTSET_REPERTORY, RFONT_DEF_REPERTORY): Remove; unused.
a5c0af81 7204
b4716021
PE
7205 * xrdb.c: Include "xterm.h", to check x_load_resources's interface.
7206
811e9bac 7207 * xselect.c (x_disown_buffer_selections): Remove; not used.
7b83e2f1 7208 (TRACE3) [!defined TRACE_SELECTION]: Remove; not used.
aa0daa9f
PE
7209 (x_own_selection, Fx_disown_selection_internal): Rename locals
7210 to avoid shadowing.
7211 (x_handle_dnd_message): Remove local to avoid shadowing.
811e9bac 7212
7e3ab302
PE
7213 * lisp.h (GCPRO1_VAR, UNGCPRO_VAR): New macros,
7214 so that the caller can use some name other than gcpro1.
7215 (GCPRO1, UNGCPRO): Reimplement in terms of the new macros.
58d2d479
PE
7216 * xfns.c (Fx_create_frame, x_create_tip_frame, Fx_show_tip):
7217 (Fx_backspace_delete_keys_p):
7218 Use them to avoid shadowing, and rename vars to avoid shadowing.
7219 (x_decode_color, x_set_name, x_window): Now static.
6b437900 7220 (Fx_create_frame): Add braces to silence GCC warning.
c0951e53 7221 (Fx_file_dialog, Fx_select_font): Fix pointer signedness.
06b0c8a0
PE
7222 (x_real_positions, xg_set_icon_from_xpm_data, x_create_tip_frame):
7223 Remove unused locals.
7e3ab302
PE
7224 (Fx_create_frame, x_create_tip_frame, Fx_show_tip):
7225 (Fx_backspace_delete_keys_p): Rename locals to avoid shadowing.
7226 Some of these renamings use the new GCPRO1_VAR and UNGCPRO_VAR
7227 macros.
f78faa98 7228
e2b13473
PE
7229 * xterm.h (x_mouse_leave): New decl.
7230
77f23912
PE
7231 * xterm.c (x_copy_dpy_color, x_focus_on_frame, x_unfocus_frame):
7232 Remove unused functions.
cdf4ba58
PE
7233 (x_shift_glyphs_for_insert, XTflash, XTring_bell):
7234 (x_calc_absolute_position): Now static.
7411c686 7235 (XTread_socket): Don't define label "out" unless it's used.
2b07bcff 7236 Don't declare local "event" unless it's used.
ed7bf3a5
PE
7237 (x_iconify_frame, x_free_frame_resources): Don't declare locals
7238 unless they are used.
38d0b34a
PE
7239 (XEMBED_VERSION, xembed_set_info): Don't define unless needed.
7240 (x_fatal_error_signal): Remove; not used.
a6067996
PE
7241 (x_draw_image_foreground, redo_mouse_highlight, XTmouse_position):
7242 (x_scroll_bar_report_motion, handle_one_xevent, x_draw_bar_cursor):
7243 (x_error_catcher, x_connection_closed, x_error_handler):
7244 (x_error_quitter, xembed_send_message, x_iconify_frame):
7245 (my_log_handler): Rename locals to avoid shadowing.
28f1c698 7246 (x_delete_glyphs, x_ins_del_lines): Mark with NO_RETURN.
2a8fade0 7247 (x_connection_closed): Tell GCC not to suggest NO_RETURN.
77f23912 7248
44f230aa
SM
7249 * xfaces.c (clear_face_cache, Fx_list_fonts, Fface_font):
7250 Rename or move locals to avoid shadowing.
6b463e58 7251 (tty_defined_color, merge_face_heights): Now static.
5967d051 7252 (free_realized_faces_for_fontset): Remove; not used.
1e9966ea
PE
7253 (Fx_list_fonts): Mark variable that gcc -Wuninitialized
7254 does not deduce is never used uninitialized.
73719eba
PE
7255 (STRDUPA, LSTRDUPA, FONT_POINT_SIZE_QUANTUM): Remove; not used.
7256 (LFACEP): Define only if XASSERTS, as it's not needed otherwise.
071048a3 7257
426994c3 7258 * terminal.c (store_terminal_param): Now static.
5489860b 7259
032f1620 7260 * xmenu.c (menu_highlight_callback): Now static.
9d66f88e 7261 (set_frame_menubar): Remove unused local.
d4323972 7262 (xmenu_show): Rename parameter to avoid shadowing.
6d1f7fee
PE
7263 (xmenu_show, xdialog_show, xmenu_show): Make local pointers "const"
7264 since they might point to immutable storage.
281585b0
PE
7265 (next_menubar_widget_id): Declare only if USE_X_TOOLKIT,
7266 since it's unused otherwise.
032f1620 7267
367c19e5 7268 * xdisp.c (produce_glyphless_glyph): Initialize lower_xoff.
53df7c11 7269 Add a FIXME, since the code still doesn't look right. (Bug#8215)
9f36b9fd
PE
7270 (Fcurrent_bidi_paragraph_direction): Simplify slightly; this
7271 avoids a gcc -Wuninitialized diagnostic.
0e086e8f 7272 (display_line, BUILD_COMPOSITE_GLYPH_STRING, draw_glyphs):
44a3a108
PE
7273 (note_mouse_highlight): Mark variables that gcc -Wuninitialized
7274 does not deduce are never used uninitialized.
70739cbe 7275
07b48fa9
PE
7276 * lisp.h (IF_LINT): New macro, copied from ../lib-src/emacsclient.c.
7277
8868a238 7278 * xdisp.c (redisplay_window): Rename local to avoid shadowing.
4554d213
PE
7279 * window.c (window_loop, size_window):
7280 (run_window_configuration_change_hook, enlarge_window): Likewise.
8868a238 7281
7e5cf297 7282 * window.c (display_buffer): Now static.
d6550a9f
PE
7283 (size_window): Mark variables that gcc -Wuninitialized
7284 does not deduce are never used uninitialized.
a586633d
PE
7285 * window.h (check_all_windows): New decl, to forestall
7286 gcc -Wmissing-prototypes diagnostic.
5b555da1 7287 * dispextern.h (bidi_dump_cached_states): Likewise.
7e5cf297 7288
f6095868
PE
7289 * charset.h (CHECK_CHARSET_GET_CHARSET): Rename locals to avoid
7290 shadowing.
7291 * charset.c (map_charset_for_dump, Fchar_charset): Likewise.
726929c4
PE
7292 Include <limits.h>.
7293 (Fsort_charsets): Redo min/max calculation to shorten the code a bit
7294 and to avoid gcc -Wuninitialized warning.
89ef49df
PE
7295 (load_charset_map): Mark variables that gcc -Wuninitialized
7296 does not deduce are never used uninitialized.
53df7c11 7297 (load_charset): Abort instead of using uninitialized var (Bug#8229).
f6095868 7298
f38b440c
PE
7299 * coding.c (coding_set_source, coding_set_destination):
7300 Use "else { /* comment */ }" rather than "else /* comment */;"
7301 for clarity, and to avoid gcc -Wempty-body warning.
2735d060
PE
7302 (Fdefine_coding_system_internal): Don't redeclare 'i' inside
7303 a block, when the outer 'i' will do.
7304 (decode_coding_utf_8, decode_coding_utf_16, detect_coding_emacs_mule):
7305 (emacs_mule_char, decode_coding_emacs_mule, detect_coding_iso_2022):
7306 (decode_coding_iso_2022, decode_coding_sjis, decode_coding_big5):
7307 (decode_coding_raw_text, decode_coding_charset, get_translation_table):
7308 (Fdecode_sjis_char, Fdefine_coding_system_internal):
7309 Rename locals to avoid shadowing.
7310 * character.h (FETCH_STRING_CHAR_ADVANCE): Likewise.
e2f1bab9
PE
7311 * coding.c (emacs_mule_char, encode_invocation_designation):
7312 Now static, since they're not used elsewhere.
413bb2db 7313 (decode_coding_iso_2022): Add "default: abort ();" as a safety check.
c4a63b12 7314 (decode_coding_object, encode_coding_object, detect_coding_system):
ee05f961
PE
7315 (decode_coding_emacs_mule): Mark variables that gcc
7316 -Wuninitialized does not deduce are never used uninitialized.
160b01f6
PE
7317 (detect_coding_iso_2022): Initialize a local variable that might
7318 be used uninitialized. Leave a FIXME because it's not clear that
53df7c11 7319 this initialization is needed. (Bug#8211)
5f58e762
PE
7320 (ISO_CODE_LF, ISO_CODE_CR, CODING_ISO_FLAG_EUC_TW_SHIFT):
7321 (ONE_MORE_BYTE_NO_CHECK, UTF_BOM, UTF_16_INVALID_P):
7322 (SHIFT_OUT_OK, ENCODE_CONTROL_SEQUENCE_INTRODUCER):
7323 (ENCODE_DIRECTION_R2L, ENCODE_DIRECTION_L2R):
7324 Remove unused macros.
f38b440c 7325
232b38b9 7326 * category.c (hash_get_category_set): Remove unused local var.
9f3b5e69 7327 (copy_category_table): Now static, since it's not used elsewhere.
d0891610 7328 * character.c (string_count_byte8): Likewise.
232b38b9 7329
fb90da1b
PE
7330 * ccl.c (CCL_WRITE_STRING, CCL_ENCODE_CHAR, Fccl_execute_on_string):
7331 (Fregister_code_conversion_map): Rename locals to avoid shadowing.
7332
fb93dbc2
PE
7333 * chartab.c (copy_sub_char_table): Now static, since it's not used
7334 elsewhere.
5c156ace
PE
7335 (sub_char_table_ref_and_range, char_table_ref_and_range):
7336 Rename locals to avoid shadowing.
bbcd0949 7337 (ASET_RANGE, GET_SUB_CHAR_TABLE): Remove unused macros.
fb93dbc2 7338
7d3b3862 7339 * bidi.c (bidi_check_type): Now static, since it's not used elsewhere.
630d6892 7340 (BIDI_BOB): Remove unused macro.
7d3b3862 7341
6be7d3da
PE
7342 * cm.c (cmgoto): Mark variables that gcc -Wuninitialized does not
7343 deduce are never used uninitialized.
c2ed9c8b 7344 * term.c (encode_terminal_code): Likewise.
6be7d3da 7345
75f8807f 7346 * term.c (encode_terminal_code): Now static. Remove unused local.
72abad34 7347
50938595
PE
7348 * tparam.h: New file.
7349 * term.c, tparam.h: Include it.
7350 * deps.mk (term.o, tparam.o): Depend on tparam.h.
7351 * term.c (tputs, tgetent, tgetflag, tgetnum, tparam, tgetstr):
7352 Move these decls to tparam.h, and make them agree with what
7353 is actually in tparam.c. The previous trick of using incompatible
7354 decls in different modules does not conform to the C standard.
7355 All callers of tparam changed to use tparam's actual API.
7356 * tparam.c (tparam1, tparam, tgoto):
7357 Use const pointers where appropriate.
7358
fbceeba2
PE
7359 * cm.c (calccost, cmgoto): Use const pointers where appropriate.
7360 * cm.h (struct cm): Likewise.
7361 * dispextern.h (do_line_insertion_deletion_costs): Likewise.
7362 * scroll.c (ins_del_costs, do_line_insertion_deletion_costs): Likewise.
7363 * term.c (tty_ins_del_lines, calculate_costs, struct fkey_table):
7364 (term_get_fkeys_1, append_glyphless_glyph, produce_glyphless_glyph):
7365 (turn_on_face, init_tty): Likewise.
7366 * termchar.h (struct tty_display_info): Likewise.
fbceeba2 7367
7f3f1250
PE
7368 * term.c (term_mouse_position): Rename local to avoid shadowing.
7369
e6ca6543
PE
7370 * alloc.c (mark_ttys): Move decl from here ...
7371 * lisp.h (mark_ttys): ... to here, so that it's checked against defn.
7372
c40f8d15
AS
73732011-03-11 Andreas Schwab <schwab@linux-m68k.org>
7374
7375 * .gdbinit (pwinx, xbuffer): Fix access to buffer name.
7376
cfe0661d
JB
73772011-03-09 Juanma Barranquero <lekktu@gmail.com>
7378
7379 * search.c (compile_pattern_1): Remove argument regp, unused since
7380 revid:rms@gnu.org-19941211082627-3x1g1wyqkjmwloig.
7381 (compile_pattern): Don't pass it.
7382
0afb4571
J
73832011-03-08 Jan Djärv <jan.h.d@swipnet.se>
7384
7385 * xterm.h (DEFAULT_GDK_DISPLAY): New define.
7386 (GDK_WINDOW_XID, gtk_widget_get_preferred_size): New defines
7387 for ! HAVE_GTK3.
7388 (GTK_WIDGET_TO_X_WIN): Use GDK_WINDOW_XID.
7389
7390 * xmenu.c (menu_position_func): Call gtk_widget_get_preferred_size.
7391
7392 * gtkutil.c: Include gtkx.h if HAVE_GTK3. If ! HAVE_GTK3, define
7393 gdk_window_get_screen, gdk_window_get_geometry,
7394 gdk_x11_window_lookup_for_display and GDK_KEY_g.
7395 (xg_set_screen): Use DEFAULT_GDK_DISPLAY.
7396 (xg_get_pixbuf_from_pixmap): New function.
7397 (xg_get_pixbuf_from_pix_and_mask): Change parameters from GdkPixmap
7398 to Pixmap, take frame as parameter, remove GdkColormap parameter.
7399 Call xg_get_pixbuf_from_pixmap instead of
7400 gdk_pixbuf_get_from_drawable.
7401 (xg_get_image_for_pixmap): Do not make GdkPixmaps, call
7402 xg_get_pixbuf_from_pix_and_mask with Pixmap parameters instead.
7403 (xg_check_special_colors): Use GtkStyleContext and its functions
7404 for HAVE_GTK3.
7405 (xg_prepare_tooltip, xg_hide_tooltip): Call gdk_window_get_screen.
7406 (xg_prepare_tooltip, create_dialog, menubar_map_cb)
7407 (xg_update_frame_menubar, xg_tool_bar_detach_callback)
44f230aa
SM
7408 (xg_tool_bar_attach_callback, xg_update_tool_bar_sizes):
7409 Call gtk_widget_get_preferred_size.
0afb4571
J
7410 (xg_frame_resized): gdk_window_get_geometry only takes 5
7411 parameters.
44f230aa
SM
7412 (xg_win_to_widget, xg_event_is_for_menubar):
7413 Call gdk_x11_window_lookup_for_display.
0afb4571
J
7414 (xg_set_widget_bg): New function.
7415 (delete_cb): New function.
895009e1 7416 (xg_create_frame_widgets): Connect delete-event to delete_cb.
0afb4571
J
7417 Call xg_set_widget_bg. Only set backgrund pixmap for ! HAVE_GTK3
7418 (xg_set_background_color): Call xg_set_widget_bg.
7419 (xg_set_frame_icon): Call xg_get_pixbuf_from_pix_and_mask.
7420 (xg_create_scroll_bar): vadj is a GtkAdjustment for HAVE_GTK3.
7421 Only call gtk_range_set_update_policy if ! HAVE_GTK3.
7422 (xg_make_tool_item): Only connect xg_tool_bar_item_expose_callback
7423 if ! HAVE_GTK3.
7424 (update_frame_tool_bar): Call gtk_widget_hide.
7425 (xg_initialize): Use GDK_KEY_g.
7426
7427 * xsmfns.c (gdk_set_sm_client_id): Define to gdk_set_sm_client_id
7428 if ! HAVE_GTK3
7429 (x_session_initialize): Call gdk_x11_set_sm_client_id.
7430
7431 * xterm.c (XFillRectangle): Use cairo routines for HAVE_GTK3.
7432 (x_term_init): Disable Xinput(2) with GDK_CORE_DEVICE_EVENTS.
7433 Load ~/emacs.d/gtkrc only for ! HAVE_GTK3.
7434
1c2cc4ef
JB
74352011-03-08 Juanma Barranquero <lekktu@gmail.com>
7436
7437 * w32xfns.c (select_palette): Check success of RealizePalette against
7438 GDI_ERROR, not zero.
7439
33383987 7440See ChangeLog.11 for earlier changes.
aac0c6e3
MR
7441
7442;; Local Variables:
7443;; coding: utf-8
aac0c6e3
MR
7444;; End:
7445
33383987 7446 Copyright (C) 2011 Free Software Foundation, Inc.
aac0c6e3
MR
7447
7448 This file is part of GNU Emacs.
7449
7450 GNU Emacs is free software: you can redistribute it and/or modify
7451 it under the terms of the GNU General Public License as published by
7452 the Free Software Foundation, either version 3 of the License, or
7453 (at your option) any later version.
7454
7455 GNU Emacs is distributed in the hope that it will be useful,
7456 but WITHOUT ANY WARRANTY; without even the implied warranty of
7457 MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
7458 GNU General Public License for more details.
7459
7460 You should have received a copy of the GNU General Public License
7461 along with GNU Emacs. If not, see <http://www.gnu.org/licenses/>.