Merge from mainline.
[bpt/emacs.git] / src / ChangeLog
CommitLineData
762f8d96 12011-04-09 Paul Eggert <eggert@cs.ucla.edu>
eb3f1cc8 2
7d66342c
PE
3 * xdisp.c (vmessage): Use a better test for character truncation.
4
bbf47d44
PE
5 * charset.c (load_charset_map): <, not <=, for optimization,
6 and to avoid potential problems with integer overflow.
9248994d 7 * chartab.c (sub_char_table_set_range, char_table_set_range): Likewise.
f9a68bc5 8 * casetab.c (set_identity, shuffle): Likewise.
3ab1c7ce 9 * editfns.c (Fformat): Likewise.
1e69125e 10 * syntax.c (skip_chars): Likewise.
3befa583 11
e3019616
PE
12 * xmenu.c (set_frame_menubar): Allocate smaller local vectors.
13 This also lets GCC 4.6.0 generate slightly better loop code.
14
becfa255
PE
15 * callint.c (Fcall_interactively): <, not <=, for optimization.
16 (Fcall_interactively): Count the number of arguments produced,
17 not the number of arguments given. This is simpler and lets GCC
18 4.6.0 generate slightly better code.
19
dae0cd48
PE
20 * ftfont.c: Distingish more carefully between FcChar8 and char.
21 The previous code passed unsigned char * to a functions like
22 strlen and xstrcasecmp that expect char *, which does not
23 conform to the C standard.
24 (get_adstyle_property, ftfont_pattern_entity): Use FcChar8 for
25 arguments to FcPatternGetString, and explicitly cast FcChar8 * to
26 char * when the C standard requires it.
27
76032d70
PE
28 * keyboard.c (read_char): Remove unused var.
29
eb3f1cc8
PE
30 * eval.c: Port to Windows vsnprintf (Bug#8435).
31 Include <limits.h>.
32 (SIZE_MAX): Define if the headers do not.
33 (verror): Do not give up if vsnprintf returns a negative count.
34 Instead, grow the buffer. This ports to Windows vsnprintf, which
35 does not conform to C99. Problem reported by Eli Zaretskii.
36 Also, simplify the allocation scheme, by avoiding the need for
37 calling realloc, and removing the ALLOCATED variable.
38
70476b54
PE
39 * eval.c (verror): Initial buffer size is 4000 (not 200) bytes.
40
ea6c7ae6
PE
41 Remove the doprnt implementation, as Emacs now uses vsnprintf.
42 * doprnt.c: Remove.
43 * lisp.h (doprnt): Remove.
44 * Makefile.in (base_obj): Remove doprnt.o.
45 * deps.mk (doprnt.o): Remove.
46
5fdb398c
PE
47 error: Print 32- and 64-bit integers portably (Bug#8435).
48 Without this change, on typical 64-bit hosts error ("...%d...", N)
49 was used to print both 32- and 64-bit integers N, which relied on
50 undefined behavior.
51 * lisp.h, src/m/amdx86-64.h, src/m/ia64.h, src/m/ibms390x.h (pEd):
52 New macro.
53 * lisp.h (error, verror): Mark as printf-like functions.
54 * eval.c (verror): Use vsnprintf, not doprnt, to do the real work.
55 Report overflow in size calculations when allocating printf buffer.
56 Do not truncate output string at its first null byte.
57 * xdisp.c (vmessage): Use vsnprintf, not doprnt, to do the real work.
58 Truncate the output at a character boundary, since vsnprintf does not
59 do that.
60 * charset.c (check_iso_charset_parameter): Convert internal
61 character to string before calling 'error', since %c now has the
62 printf meaning.
63 * coding.c (Fdecode_sjis_char, Fdecode_big5_char): Avoid int
64 overflow when computing char to be passed to 'error'. Do not
65 pass Lisp_Object to 'error'; pass the integer instead.
66 * nsfns.m (Fns_do_applescript): Use int, not long, since it's
67 formatted with plain %d.
68
b189fa66
PE
69 * eval.c (internal_lisp_condition_case): Don't pass spurious arg.
70
bff87ef0
PE
71 * keyboard.c (access_keymap_keyremap): Print func name, not garbage.
72
7e2cac20
PE
73 * coding.c (Fdecode_sjis_char): Don't assume CODE fits in int.
74
ce4d90b5
PE
75 * xterm.c (x_catch_errors): Remove duplicate declaration.
76
266c9547
PE
77 * term.c (maybe_fatal): Mark its 3rd arg as a printf format, too.
78
79c49ad2
PE
79 * xdisp.c, lisp.h (message_nolog): Remove; unused.
80
a32d4040
CY
812011-04-09 Chong Yidong <cyd@stupidchicken.com>
82
83 * image.c (Fimagemagick_types): Doc fix, and comment cleanup.
84
8546720e 852011-04-09 Chong Yidong <cyd@stupidchicken.com>
aac0c6e3 86
8546720e
GM
87 * ftfont.c (get_adstyle_property, ftfont_pattern_entity): Use
88 unsigned char, to match FcChar8 type definition.
aac0c6e3 89
8546720e
GM
90 * xterm.c (handle_one_xevent):
91 * xmenu.c (create_and_show_popup_menu):
92 * xselect.c (x_decline_selection_request)
93 (x_reply_selection_request): Avoid type-punned deref of X events.
aac0c6e3 94
a53e2e89
EZ
952011-04-09 Eli Zaretskii <eliz@emacstest.gnu.org>
96
97 Fix some uses of `int' instead of EMACS_INT.
98 * search.c (string_match_1, fast_string_match)
99 (fast_c_string_match_ignore_case, fast_string_match_ignore_case)
100 (scan_buffer, find_next_newline_no_quit)
101 (find_before_next_newline, search_command, Freplace_match)
102 (Fmatch_data): Make some `int' variables be EMACS_INT.
103
104 * xdisp.c (display_count_lines): 3rd argument and return value now
105 EMACS_INT. All callers changed.
106 (pint2hrstr): Last argument is now EMACS_INT.
107
108 * coding.c (detect_coding_utf_8, detect_coding_emacs_mule)
109 (detect_coding_iso_2022, detect_coding_sjis, detect_coding_big5)
110 (detect_coding_ccl, detect_coding_charset, decode_coding_utf_8)
111 (decode_coding_utf_16, decode_coding_emacs_mule)
112 (decode_coding_iso_2022, decode_coding_sjis, decode_coding_big5)
113 (decode_coding_ccl, decode_coding_charset)
114 <consumed_chars, consumed_chars_base>: Declare EMACS_INT.
115 (decode_coding_iso_2022, decode_coding_emacs_mule)
116 (decode_coding_sjis, decode_coding_big5, decode_coding_charset)
117 <char_offset, last_offset>: Declare EMACS_INT.
118 (encode_coding_utf_8, encode_coding_utf_16)
119 (encode_coding_emacs_mule, encode_invocation_designation)
120 (encode_designation_at_bol, encode_coding_iso_2022)
121 (encode_coding_sjis, encode_coding_big5, encode_coding_ccl)
122 (encode_coding_raw_text, encode_coding_charset) <produced_chars>:
123 Declare EMACS_INT.
124 (ASSURE_DESTINATION): Declare more_bytes EMACS_INT.
125 (encode_invocation_designation): Last argument P_NCHARS is now
126 EMACS_INT.
127 (decode_eol): Declare pos_byte, pos, and pos_end EMACS_INT.
128 (produce_chars): from_nchars and to_nchars are now EMACS_INT.
129
130 * coding.h (struct coding_system) <head_ascii>: Declare EMACS_INT.
131 All users changed.
132
133 * ccl.c (Fccl_execute_on_string): Declare some variables
134 EMACS_INT.
135
8546720e 1362011-04-08 Samuel Thibault <sthibault@debian.org> (tiny change)
0080dc6b
SS
137
138 * term.c (init_tty): Fix incorrect ifdef placement (Bug#8450).
139
4e19a977
CS
1402011-03-19 Christoph Scholtes <cschol2112@googlemail.com>
141
142 * process.c (Fformat_network_address): Doc fix.
143
87302331
R
1442011-04-08 T.V. Raman <tv.raman.tv@gmail.com> (tiny change)
145
146 * xml.c (parse_region): Avoid creating spurious whiespace nodes.
147
cbb59342
CY
1482011-04-08 Chong Yidong <cyd@stupidchicken.com>
149
150 * keyboard.c (read_char): Call Lisp function help-form-show,
151 instead of using internal_with_output_to_temp_buffer.
152 (Qhelp_form_show): New var.
e0d38eeb 153 (syms_of_keyboard): Use DEFSYM macro.
cbb59342
CY
154
155 * print.c (internal_with_output_to_temp_buffer): Function deleted.
156
157 * lisp.h (internal_with_output_to_temp_buffer): Remove prototype.
158
e67a13ab
CY
1592011-04-06 Chong Yidong <cyd@stupidchicken.com>
160
161 * process.c (Flist_processes): Removed to Lisp.
162 (list_processes_1): Deleted.
163
973f782d
EZ
1642011-04-06 Eli Zaretskii <eliz@gnu.org>
165
7c106b1e
EZ
166 * msdos.c (careadlinkat, careadlinkatcwd): MS-DOS replacements.
167
973f782d
EZ
168 * w32.c (careadlinkat, careadlinkatcwd): New always-fail stubs.
169
41cf7d1a 1702011-04-06 Paul Eggert <eggert@cs.ucla.edu>
27ccc379 171
ca23cc88
PE
172 Fix more problems found by GCC 4.6.0's static checks.
173
f390e2d5
PE
174 * xmenu.c (Fx_popup_dialog): Don't assume string is free of formats.
175
42eea0d0
PE
176 * menu.c (Fx_popup_menu): Don't assume error_name lacks printf formats.
177
b69769da 178 * lisp.h (message, message_nolog, fatal): Mark as printf-like.
1e973bc7 179
f9541e84
PE
180 * xdisp.c (vmessage): Mark as a printf-like function.
181
13841b55
PE
182 * term.c (vfatal, maybe_fatal): Mark as printf-like functions.
183
c136c10f
PE
184 * sound.c (sound_warning): Don't crash if arg contains a printf format.
185
5e2d4a30
PE
186 * image.c (tiff_error_handler, tiff_warning_handler): Mark as
187 printf-like functions.
188 (tiff_load): Add casts to remove these marks before passing them
189 to system-supplied API.
190
583f48b9
PE
191 * eval.c (Fsignal): Remove excess argument to 'fatal'.
192
b25d760e
PE
193 * coding.c (EMIT_ONE_BYTE, EMIT_TWO_BYTES): Use unsigned, not int.
194 This avoids several warnings with gcc -Wstrict-overflow.
d5efd1d1
PE
195 (DECODE_COMPOSITION_RULE): If the rule is invalid, goto invalid_code
196 directly, rather than having caller test rule sign. This avoids
197 some unnecessary tests.
198 * composite.h (COMPOSITION_ENCODE_RULE_VALID): New macro.
199 (COMPOSITION_ENCODE_RULE): Arguments now must be valid. This
200 affects only one use, in DECODE_COMPOSITION_RULE, which is changed.
b25d760e 201
bc7b6697 202 * xfont.c (xfont_text_extents): Remove var that was set but not used.
625a3eb1 203 (xfont_open): Avoid unnecessary tests.
bc7b6697 204
27ccc379
PE
205 * composite.c (composition_gstring_put_cache): Use unsigned integer.
206
dcd5c89a
PE
207 * composite.h, composite.c (composition_gstring_put_cache):
208 Use EMACS_INT, not int, for length.
209
b13a45c6
PE
210 * composite.h (COMPOSITION_DECODE_REFS): New macro,
211 breaking out part of COMPOSITION_DECODE_RULE.
212 (COMPOSITION_DECODE_RULE): Use it.
213 * composite.c (get_composition_id): Remove unused local vars,
214 by using the new macro.
215
1e792e4d
PE
216 * textprop.c (set_text_properties_1): Change while to do-while,
217 since the condition is always true at first.
218
dc6c6455 219 * intervals.c (graft_intervals_into_buffer): Mark var as used.
aa86731f
PE
220 (interval_deletion_adjustment): Return unsigned value.
221 All uses changed.
dc6c6455 222
aba7731a
PE
223 * process.c (list_processes_1, create_pty, read_process_output):
224 (exec_sentinel): Remove vars that were set but not used.
afd4052b 225 (create_pty): Remove unnecessary "volatile"s.
bc57d757 226 (Fnetwork_interface_info): Avoid possibility of int overflow.
82eaa333 227 (read_process_output): Do adaptive read buffering even if carryover.
fe07cdfa 228 (read_process_output): Simplify nbytes computation if buffered.
aba7731a 229
fdfc4bf3
PE
230 * bytecode.c (exec_byte_code): Rename local to avoid shadowing.
231
fca8fe46 232 * syntax.c (scan_words): Remove var that was set but not used.
12cbf13f 233 (update_syntax_table): Use unsigned instead of int.
fca8fe46 234
06a0259a 235 * lread.c (lisp_file_lexically_bound_p): Use ints rather than endptrs.
3c346cc3 236 (lisp_file_lexically_bound_p, read1): Use unsigned instead of int.
e6eb4e9e 237 (safe_to_load_p): Make the end-of-loop test the inverse of the in-loop.
06a0259a 238
e7b9e80f
PE
239 * print.c (print_error_message): Avoid int overflow.
240
56201685
PE
241 * font.c (font_list_entities): Redo for clarity,
242 so that reader need not know FONT_DPI_INDEX + 1 == FONT_SPACING_INDEX.
243
78834453 244 * font.c (font_find_for_lface, Ffont_get_glyphs): Remove unused vars.
790771b1 245 (font_score): Avoid potential overflow in diff calculation.
78834453 246
0bc0b309 247 * fns.c (substring_both): Remove var that is set but not used.
8cd55cb4 248 (sxhash): Redo loop for clarity and to avoid wraparound warning.
0bc0b309 249
e610eaca
PE
250 * eval.c (funcall_lambda): Rename local to avoid shadowing.
251
b895abce
PE
252 * alloc.c (mark_object_loop_halt, mark_object): Use size_t, not int.
253 Otherwise, GCC 4.6.0 optimizes the loop check away since the check
254 can always succeed if overflow has undefined behavior.
255
1f1d9321 256 * search.c (boyer_moore, wordify): Remove vars set but not used.
6f076cc7 257 (wordify): Omit three unnecessary tests.
1f1d9321 258
c59478bc
PE
259 * indent.c (MULTIBYTE_BYTES_WIDTH): Don't compute wide_column.
260 All callers changed. This avoids the need for an unused var.
261
79b73827
PE
262 * casefiddle.c (casify_region): Remove var that is set but not used.
263
a4db5dfe
PE
264 * dired.c (file_name_completion): Remove var that is set but not used.
265
43aae36e
PE
266 * fileio.c (Finsert_file_contents): Make EOF condition clearer.
267
2a47c44d 268 * fileio.c (Finsert_file_contents): Avoid signed integer overflow.
163c5f32 269 (Finsert_file_contents): Remove unnecessary code checking fd.
2a47c44d 270
a37c69bf
PE
271 * minibuf.c (read_minibuf_noninteractive): Use size_t for sizes.
272 Check for integer overflow on size calculations.
273
328ab8e7
PE
274 * buffer.c (Fprevious_overlay_change): Remove var that is set
275 but not used.
276
e5a2a5cb
PE
277 * keyboard.c (menu_bar_items, read_char_minibuf_menu_prompt):
278 Remove vars that are set but not used.
8d84a6eb 279 (timer_check_2): Don't assume timer-list and idle-timer-list are lists.
6b043475 280 (timer_check_2): Mark vars as initialized.
e5a2a5cb 281
a60e5f68
PE
282 * gtkutil.c (xg_get_file_with_chooser): Mark var as initialized.
283
f661cb61 284 * image.c (lookup_image): Remove var that is set but not used.
35fa624f 285 (xbm_load): Use parse_p, for gcc -Werror=unused-but-set-variable.
f661cb61 286
f0397f5a
PE
287 * fontset.c (Finternal_char_font, Ffontset_info): Remove vars
288 that are set but not used.
289
8664db06 290 * xfns.c (make_invisible_cursor): Don't return garbage
03733ee7 291 if XCreateBitmapFromData fails (Bug#8410).
8664db06 292
6abdaa4a
PE
293 * xselect.c (x_get_local_selection, x_handle_property_notify):
294 Remove vars that are set but not used.
295
0ce7538d 296 * xfns.c (x_create_tip_frame): Remove var that is set but not used.
6abdaa4a 297 (make_invisible_cursor): Initialize a possibly-uninitialized variable.
0ce7538d 298
9ae848fc
PE
299 * xterm.c (x_scroll_bar_to_input_event) [!USE_GTK]:
300 Remove var that is set but not used.
0b918413
PE
301 (scroll_bar_windows_size): Now size_t, not int.
302 (x_send_scroll_bar_event): Use size_t, not int, for sizes.
303 Check for overflow.
9ae848fc 304
a5a62657
PE
305 * xfaces.c (realize_named_face): Remove vars that are set but not used.
306 (map_tty_color) [!defined MSDOS]: Likewise.
307
5c5cdd39
PE
308 * term.c (tty_write_glyphs): Use size_t; this avoids overflow warning.
309
66ebf983
PE
310 * coding.c: Remove vars that are set but not used.
311 (DECODE_COMPOSITION_RULE): Remove 2nd arg, which is unused.
312 All callers changed.
313 (decode_coding_utf_8, decode_coding_utf_16 decode_coding_emacs_mule):
314 (decode_coding_iso_2022, encode_coding_sjis, encode_coding_big5):
315 (decode_coding_charset): Remove vars that are set but not used.
316
1be4d761
PE
317 * bytecode.c (Fbyte_code) [!defined BYTE_CODE_SAFE]: Remove var
318 that is set but not used.
319
47553fa8
PE
320 * print.c (print_object): Remove var that is set but not used.
321
1f7196bf 322 Replace 2 copies of readlink code with 1 gnulib version (Bug#8401).
d1fdcab7
PE
323 The gnulib version avoids calling malloc in the usual case,
324 and on 64-bit hosts doesn't have some arbitrary 32-bit limits.
325 * fileio.c (Ffile_symlink_p): Use emacs_readlink.
326 * filelock.c (current_lock_owner): Likewise.
327 * lisp.h (READLINK_BUFSIZE, emacs_readlink): New function.
328 * sysdep.c: Include allocator.h, careadlinkat.h.
329 (emacs_no_realloc_allocator): New static constant.
330 (emacs_readlink): New function.
fdb61804
PE
331 * deps.mk (sysdep.o): Depend on ../lib/allocator.h and on
332 ../lib/careadlinkat.h.
d1fdcab7 333
f84c17c7
SM
3342011-04-04 Stefan Monnier <monnier@iro.umontreal.ca>
335
336 * keyboard.c (safe_run_hook_funcall): Fix last change (don't stop at the
337 first non-nil return value).
338
ef3862ad
JD
3392011-04-03 Jan Djärv <jan.h.d@swipnet.se>
340
341 * nsterm.m (ns_update_auto_hide_menu_bar): Define MAC_OS_X_VERSION_10_6
342 if not defined (Bug#8403).
343
376a7006
JB
3442011-04-02 Juanma Barranquero <lekktu@gmail.com>
345
346 * xdisp.c (display_count_lines): Remove parameter `start',
347 unused since 1998-01-01T02:27:27Z!rms@gnu.org. All callers changed.
348 (get_char_face_and_encoding): Remove parameter `multibyte_p',
349 unused since 2008-05-14T01:40:23Z!handa@m17n.org. All callers changed.
350 (fill_stretch_glyph_string): Remove parameters `row' and `area',
351 unused at least since Kim's GUI unification at 2003-03-16T20:45:46Z!storm@cua.dk
352 and thereabouts. All callers changed.
353 (get_per_char_metric): Remove parameter `f', unused since
354 2008-05-14T01:40:23Z!handa@m17n.org. All callers changed.
355
6ca3801d
JM
3562011-04-02 Jim Meyering <meyering@redhat.com>
357
358 do not dereference NULL upon failed strdup
359 * nsfont.m (ns_descriptor_to_entity): Use xstrdup, not strdup.
360 (ns_get_family): Likewise.
361
d8e2b5ba
JB
3622011-04-02 Juanma Barranquero <lekktu@gmail.com>
363
364 * eval.c (unwind_to_catch) [DEBUG_GCPRO]: Remove redundant assignment.
365
8c74fcbd
JD
3662011-04-02 Jan Djärv <jan.h.d@swipnet.se>
367
368 * nsterm.m (ns_update_auto_hide_menu_bar): Only for OSX 10.6 or
369 later (Bug#8403).
370
7200d79c
SM
3712011-04-01 Stefan Monnier <monnier@iro.umontreal.ca>
372
03408648 373 Add lexical binding.
7200d79c 374
03408648
SM
375 * window.c (Ftemp_output_buffer_show): New fun.
376 (Fsave_window_excursion):
377 * print.c (Fwith_output_to_temp_buffer): Move to subr.el.
378
379 * lread.c (lisp_file_lexically_bound_p): New function.
380 (Fload): Bind Qlexical_binding.
381 (readevalloop): Remove `evalfun' arg.
382 Bind Qinternal_interpreter_environment.
383 (Feval_buffer): Bind Qlexical_binding.
384 (defvar_int, defvar_bool, defvar_lisp_nopro, defvar_kboard):
385 Mark as dynamic.
386 (syms_of_lread): Declare `lexical-binding'.
387
388 * lisp.h (struct Lisp_Symbol): New field `declared_special'.
389
390 * keyboard.c (eval_dyn): New fun.
391 (menu_item_eval_property): Use it.
ca105506
SM
392
393 * image.c (parse_image_spec): Use Ffunctionp.
ca105506 394
03408648
SM
395 * fns.c (concat, mapcar1): Accept byte-code-functions.
396
397 * eval.c (Fsetq): Handle lexical vars.
398 (Fdefun, Fdefmacro, Ffunction): Make closures when needed.
399 (Fdefconst, Fdefvaralias, Fdefvar): Mark as dynamic.
400 (FletX, Flet): Obey lexical binding.
401 (Fcommandp): Handle closures.
402 (Feval): New `lexical' arg.
403 (eval_sub): New function extracted from Feval. Use it almost
404 everywhere where Feval was used. Look up vars in lexical env.
405 Handle closures.
406 (Ffunctionp): Move from subr.el.
407 (Ffuncall): Handle closures.
408 (apply_lambda): Remove `eval_flags'.
409 (funcall_lambda): Handle closures and new byte-code-functions.
410 (Fspecial_variable_p): New function.
411 (syms_of_eval): Initialize the Vinternal_interpreter_environment var,
412 but without exporting it to Lisp.
23aba0ea 413
23aba0ea 414 * doc.c (Fdocumentation, store_function_docstring):
03408648 415 * data.c (Finteractive_form): Handle closures.
23aba0ea 416
03408648
SM
417 * callint.c (Fcall_interactively): Preserve lexical-binding mode for
418 interactive spec.
ba83908c 419
03408648
SM
420 * bytecode.c (Bstack_ref, Bstack_set, Bstack_set2, BdiscardN): New
421 byte-codes.
422 (exec_byte_code): New function extracted from Fbyte_code to handle new
423 calling convention for byte-code-functions. Add new byte-codes.
ba83908c 424
03408648 425 * buffer.c (defvar_per_buffer): Set new `declared_special' field.
e2abe5a1 426
03408648 427 * alloc.c (Fmake_symbol): Init new `declared_special' field.
e2abe5a1 428
e2abce01
JB
4292011-03-31 Juanma Barranquero <lekktu@gmail.com>
430
431 * xdisp.c (redisplay_internal): Fix prototype.
432
63696a73 4332011-03-31 Eli Zaretskii <eliz@gnu.org>
09725d26 434
63696a73
EZ
435 * xdisp.c (SCROLL_LIMIT): New macro.
436 (try_scrolling): Use it when setting scroll_limit. Limit
437 scrolling to 100 screen lines.
438 (redisplay_window): Even when falling back on "recentering",
439 position point in the window according to scroll-conservatively,
440 scroll-margin, and scroll-*-aggressively variables. (Bug#6671)
441
442 (try_scrolling): When point is above the window, allow searching
443 as far as scroll_max, or one screenful, to compute vertical
444 distance from PT to the scroll margin position. This prevents
445 try_scrolling from unnecessarily failing when
446 scroll-conservatively is set to a value slightly larger than the
447 window height. Clean up the case of PT below the margin at bottom
448 of window: scroll_max can no longer be INT_MAX. When aggressive
449 scrolling is in use, don't let point enter the opposite scroll
450 margin as result of the scroll.
451 (syms_of_xdisp) <scroll-conservatively>: Document the
09725d26
EZ
452 threshold of 100 lines for never-recentering scrolling.
453
e4cc2dfc
JB
4542011-03-31 Juanma Barranquero <lekktu@gmail.com>
455
456 * dispextern.h (move_it_by_lines):
457 * xdisp.c (move_it_by_lines): Remove parameter `need_y_p', unused
458 since 2000-12-29T14:24:09Z!gerd@gnu.org. All callers changed.
459 (message_log_check_duplicate): Remove parameters `prev_bol' and
460 `this_bol', unused since 1998-01-01T02:27:27Z!rms@gnu.org. All callers changed.
461 (redisplay_internal): Remove parameter `preserve_echo_area',
462 unused since 1999-07-21T21:43:52Z!gerd@gnu.org. All callers changed.
463
464 * indent.c (Fvertical_motion):
465 * window.c (window_scroll_pixel_based, Frecenter):
466 Don't pass `need_y_p' to `move_it_by_lines'.
467
1c470562
SM
4682011-03-30 Stefan Monnier <monnier@iro.umontreal.ca>
469
44f230aa
SM
470 * eval.c (struct backtrace): Don't cheat with negative numbers, but do
471 steal a few bits to be more compact.
472 (interactive_p, Fbacktrace, Fbacktrace_frame, mark_backtrace):
473 Remove unneeded casts.
474
1c470562
SM
475 * bytecode.c (Fbyte_code): CAR and CDR can GC.
476
888adce9
ZK
4772011-03-30 Zachary Kanfer <zkanfer@gmail.com> (tiny change)
478
479 * keyboard.c (Fexecute_extended_command): Do log the "suggest key
480 binding" message (bug#7967).
481
f838ed7b
PE
4822011-03-30 Paul Eggert <eggert@cs.ucla.edu>
483
77861b95
PE
484 Fix more problems found by GCC 4.6.0's static checks.
485
de6dbc14
PE
486 * unexelf.c (unexec) [! (defined _SYSTYPE_SYSV || defined __sgi)]:
487 Remove unused local var.
488
f838ed7b
PE
489 * editfns.c (Fmessage_box): Remove unused local var.
490
792c7b2b
PE
491 * xdisp.c (try_window_reusing_current_matrix, x_produce_glyphs):
492 (note_mode_line_or_margin_highlight, note_mouse_highlight):
493 Omit unused local vars.
c499e557 494 * window.c (shrink_windows): Omit unused local var.
b01a1c29 495 * menu.c (digest_single_submenu): Omit unused local var.
0bc32927
PE
496 * dispnew.c (update_window) [PERIODIC_PREEMPTION_CHECKING]:
497 Omit unused local var.
498
ba0165e1
PE
499 * keyboard.c (parse_modifiers_uncached, parse_modifiers):
500 Don't assume string length fits in int.
32ad8845 501 (keyremap_step, read_key_sequence): Use size_t for sizes.
48011560 502 (read_key_sequence): Don't check last_real_key_start redundantly.
ba0165e1 503
3c59b4c9
PE
504 * callproc.c (Fcall_process, Fcall_process_region): Use SAFE_ALLOCA
505 instead of alloca (Bug#8344).
506
a3eed478 507 * eval.c (Fbacktrace): Don't assume nargs fits in int.
5d5d959d 508 (Fbacktrace_frame): Don't assume nframes fits in int.
a3eed478 509
eb4d412d
PE
510 * syntax.c (scan_sexps_forward): Avoid pointer wraparound.
511
1658b401
PE
512 * xterm.c (x_make_frame_visible, same_x_server): Redo to avoid overflow
513 concerns.
514
515 * term.c (produce_glyphless_glyph): Remove unnecessary test.
516
517 * cm.c (calccost): Turn while-do into do-while, for clarity.
44f730c8 518
9a2c6e05
PE
519 * keyboard.c (syms_of_keyboard): Use the same style as later
520 in this function when indexing through an array. This also
521 works around GCC bug 48267.
522
03d0a109
PE
523 * image.c (tiff_load): Fix off-by-one image count (Bug#8336).
524
44f730c8
PE
525 * xselect.c (x_check_property_data): Return correct size (Bug#8335).
526
fe75f926
PE
527 * chartab.c (sub_char_table_ref_and_range): Redo for slight
528 efficiency gain, and to bypass a gcc -Wstrict-overflow warning.
529
ffa8c828
PE
530 * keyboard.c, keyboard.h (num_input_events): Now size_t.
531 This avoids undefined behavior on integer overflow, and is a bit
532 more convenient anyway since it is compared to a size_t variable.
533
c5101a77
PE
534 Variadic C functions now count arguments with size_t, not int.
535 This avoids an unnecessary limitation on 64-bit machines, which
536 caused (substring ...) to crash on large vectors (Bug#8344).
537 * lisp.h (struct Lisp_Subr.function.aMANY): Now takes size_t, not int.
538 (DEFUN_ARGS_MANY, internal_condition_case_n, safe_call): Likewise.
77861b95 539 All variadic functions and their callers changed accordingly.
c5101a77
PE
540 (struct gcpro.nvars): Now size_t, not int. All uses changed.
541 * data.c (arith_driver, float_arith_driver): Likewise.
542 * editfns.c (general_insert_function): Likewise.
543 * eval.c (struct backtrace.nargs, interactive_p)
544 (internal_condition_case_n, run_hook_with_args, apply_lambda)
545 (funcall_lambda, mark_backtrace): Likewise.
546 * fns.c (concat): Likewise.
547 * frame.c (x_set_frame_parameters): Likewise.
548 * fns.c (get_key_arg): Now accepts and returns size_t, and returns
549 0 if not found, not -1. All callers changed.
550
dd3f25f7
PE
551 * alloc.c (garbage_collect): Don't assume stack size fits in int.
552 (stack_copy_size): Now size_t, not int.
553 (stack_copy, stack_copy_size): Define only if MAX_SAVE_STACK > 0.
554
461c2ab9
JB
5552011-03-28 Juanma Barranquero <lekktu@gmail.com>
556
557 * coding.c (encode_designation_at_bol): Remove parameter `charbuf_end',
558 unused since 2002-03-01T01:17:24Z!handa@m17n.org and 2008-02-01T16:01:31Z!miles@gnu.org.
559 All callers changed.
560
561 * lisp.h (multibyte_char_to_unibyte):
562 * character.c (multibyte_char_to_unibyte): Remove parameter `rev_tbl',
563 unused since 2002-03-01T01:16:34Z!handa@m17n.org and 2008-02-01T16:01:31Z!miles@gnu.org.
564 * character.h (CHAR_TO_BYTE8):
565 * cmds.c (internal_self_insert):
566 * editfns.c (general_insert_function):
567 * keymap.c (push_key_description):
568 * search.c (Freplace_match):
569 * xdisp.c (message_dolog, set_message_1): All callers changed.
570
f6d62986
SM
5712011-03-28 Stefan Monnier <monnier@iro.umontreal.ca>
572
573 * keyboard.c (safe_run_hook_funcall): New function.
574 (safe_run_hooks_1, safe_run_hooks_error, safe_run_hooks): On error,
575 don't set the hook to nil, but remove the offending function instead.
576 (Qcommand_hook_internal): Remove, unused.
577 (syms_of_keyboard): Don't initialize Qcommand_hook_internal nor define
578 Vcommand_hook_internal.
579
580 * eval.c (enum run_hooks_condition): Remove.
581 (funcall_nil, funcall_not): New functions.
582 (run_hook_with_args): Call each function through a `funcall' argument.
583 Remove `cond' argument, now redundant.
584 (Frun_hooks, Frun_hook_with_args, Frun_hook_with_args_until_success)
585 (Frun_hook_with_args_until_failure): Adjust accordingly.
586 (run_hook_wrapped_funcall, Frun_hook_wrapped): New functions.
587
1db5b1ad
JB
5882011-03-28 Juanma Barranquero <lekktu@gmail.com>
589
590 * dispextern.h (string_buffer_position): Remove declaration.
591
592 * print.c (strout): Remove parameter `multibyte', unused since
593 1999-08-21T19:30:21Z!gerd@gnu.org. All callers changed.
594
595 * search.c (boyer_moore): Remove parameters `len', `pos' and `lim',
596 never used since function introduction in 1998-02-08T21:33:56Z!rms@gnu.org.
597 All callers changed.
598
599 * w32.c (_wsa_errlist): Use braces for struct initializers.
600
601 * xdisp.c (string_buffer_position_lim): Remove parameter `w',
602 never used since function introduction in 2001-03-09T18:41:50Z!gerd@gnu.org.
603 All callers changed.
604 (string_buffer_position): Likewise. Also, make static (it's never
605 used outside xdisp.c).
606 (cursor_row_p): Remove parameter `w', unused since
607 2000-10-17T16:08:57Z!gerd@gnu.org. All callers changed.
608 (decode_mode_spec): Remove parameter `precision', introduced during
609 Gerd Moellmann's rewrite at 1999-07-21T21:43:52Z!gerd@gnu.org, but never used.
610 All callers changed.
611
5ffb62aa
JD
6122011-03-27 Jan Djärv <jan.h.d@swipnet.se>
613
614 * nsterm.m (syms_of_nsterm): Use doc: for ns-auto-hide-menu-bar.
615
461c2ab9 6162011-03-27 Anders Lindgren <andlind@gmail.com>
f0a1382a
JD
617
618 * nsterm.m (ns_menu_bar_is_hidden): New variable.
619 (ns_constrain_all_frames, ns_menu_bar_should_be_hidden)
620 (ns_update_auto_hide_menu_bar): New functions.
621 (ns_update_begin): Call ns_update_auto_hide_menu_bar.
622 (applicationDidBecomeActive): Call ns_update_auto_hide_menu_bar and
623 ns_constrain_all_frames.
624 (constrainFrameRect): Return at once if ns_menu_bar_should_be_hidden.
625 (syms_of_nsterm): DEFVAR ns-auto-hide-menu-bar, init to Qnil.
626
5c380ffb
JD
6272011-03-27 Jan Djärv <jan.h.d@swipnet.se>
628
629 * nsmenu.m (runDialogAt): Remove argument to timer_check.
630
9af30bdf
GM
6312011-03-27 Glenn Morris <rgm@gnu.org>
632
633 * syssignal.h: Replace RETSIGTYPE with void.
634 * atimer.c, data.c, dispnew.c, emacs.c, floatfns.c, keyboard.c:
635 * keyboard.h, lisp.h, process.c, sysdep.c, xterm.c:
636 Replace SIGTYPE with void everywhere.
637 * s/usg5-4-common.h (SIGTYPE): Remove definition.
638 * s/template.h (SIGTYPE): Remove commented out definition.
639
e2abce01
JB
6402011-03-26 Eli Zaretskii <eliz@gnu.org>
641
642 * xdisp.c (redisplay_window): Don't check buffer's clip_changed
643 flag as a prerequisite for invoking try_scrolling. (Bug#6671)
644
f868cd8a
JB
6452011-03-26 Juanma Barranquero <lekktu@gmail.com>
646
59eb0929
JB
647 * w32.c (read_unc_volume): Use parameter `henum', instead of
648 global variable `wget_enum_handle'.
649
650 * keymap.c (describe_vector): Remove parameters `indices' and
651 `char_table_depth', unused since 2002-03-01T01:43:26Z!handa@m17n.org.
652 (describe_map, Fdescribe_vector): Adjust calls to `describe_vector'.
653
f868cd8a
JB
654 * keyboard.h (timer_check, show_help_echo): Remove unused parameters.
655
656 * keyboard.c (timer_check): Remove parameter `do_it_now',
657 unused since 1996-04-12T06:01:29Z!rms@gnu.org.
658 (show_help_echo): Remove parameter `ok_to_overwrite_keystroke_echo',
659 unused since 2008-04-19T19:30:53Z!monnier@iro.umontreal.ca.
660
661 * keyboard.c (read_char):
662 * w32menu.c (w32_menu_display_help):
663 * xmenu.c (show_help_event, menu_help_callback):
664 Adjust calls to `show_help_echo'.
665
666 * gtkutil.c (xg_maybe_add_timer):
667 * keyboard.c (readable_events):
668 * process.c (wait_reading_process_output):
669 * xmenu.c (x_menu_wait_for_event): Adjust calls to `timer_check'.
670
671 * insdel.c (adjust_markers_gap_motion):
672 Remove; no-op since 1998-01-02T21:29:48Z!rms@gnu.org.
673 (gap_left, gap_right): Don't call it.
674
2ecf6fdb
CY
6752011-03-25 Chong Yidong <cyd@stupidchicken.com>
676
677 * xdisp.c (handle_fontified_prop): Discard changes to clip_changed
678 incurred during fontification.
679
6b1f9ba4
JB
6802011-03-25 Juanma Barranquero <lekktu@gmail.com>
681
682 * buffer.c (defvar_per_buffer): Remove unused parameter `doc'.
683 (DEFVAR_PER_BUFFER): Don't pass it.
684
685 * dispnew.c (row_equal_p, add_row_entry): Remove unused parameter `w'.
686 (scrolling_window): Don't pass it.
687
0f4a96b5
JB
6882011-03-25 Juanma Barranquero <lekktu@gmail.com>
689
690 * dispextern.h (glyph_matric): Use #if GLYPH_DEBUG, not #ifdef.
691
692 * fileio.c (check_executable) [DOS_NT]: Remove unused variables `len'
693 and `suffix'.
694 (Fset_file_selinux_context) [HAVE_LIBSELINUX]: Move here declaration
695 of variables specific to SELinux and computation of `encoded_absname'.
696
697 * image.c (XPutPixel): Remove unused variable `height'.
698
699 * keyboard.c (make_lispy_event): Remove unused variable `hpos'.
700
701 * unexw32.c (get_section_info): Remove unused variable `section'.
702
703 * w32.c (stat): Remove unused variables `drive_root' and `devtype'.
704 (system_process_attributes): Remove unused variable `sess'.
705 (sys_read): Remove unused variable `err'.
706
707 * w32fns.c (top): Wrap variables with #if GLYPH_DEBUG, not #ifdef.
708 (w32_wnd_proc): Remove unused variable `isdead'.
709 (unwind_create_frame): Use #if GLYPH_DEBUG, not #ifdef.
710 (Fx_server_max_request_size): Remove unused variable `dpyinfo'.
711 (x_create_tip_frame): Remove unused variable `tem'.
712
713 * w32inevt.c (w32_console_read_socket):
714 Remove unused variable `no_events'.
715
716 * w32term.c (x_draw_composite_glyph_string_foreground):
717 Remove unused variable `width'.
718
1149507c
JB
7192011-03-24 Juanma Barranquero <lekktu@gmail.com>
720
721 * w32term.c (x_set_glyph_string_clipping):
722 Don't pass uninitialized region to CombineRgn.
723
9c88f339
JB
7242011-03-23 Juanma Barranquero <lekktu@gmail.com>
725
726 * w32fns.c (x_set_menu_bar_lines): Remove unused variable `olines'.
727 (w32_wnd_proc): Pass NULL to Windows API, not uninitialized buffer.
728 (Fx_close_connection): Remove unused variable `i'.
729
730 * w32font.c (w32font_draw): Return number of glyphs.
731 (w32font_open_internal): Remove unused variable `i'.
732 (w32font_driver): Add missing initializer.
733
734 * w32menu.c (utf8to16): Remove unused variable `utf16'.
735 (fill_in_menu): Remove unused variable `items_added'.
736
737 * w32term.c (last_mouse_press_frame): Remove static global variable.
738 (w32_clip_to_row): Remove unused variable `f'.
739 (x_delete_terminal): Remove unused variable `i'.
740
741 * w32uniscribe.c (uniscribe_shape): Remove unused variable `nclusters'.
742 (NOTHING): Remove unused static global variable.
743 (uniscribe_check_otf): Remove unused variable `table'.
744 (uniscribe_font_driver): Add missing initializers.
745
dee091a3
JD
7462011-03-23 Julien Danjou <julien@danjou.info>
747
748 * term.c (Fsuspend_tty, Fresume_tty):
749 * minibuf.c (read_minibuf, run_exit_minibuf_hook):
750 * window.c (temp_output_buffer_show):
751 * insdel.c (signal_before_change):
752 * frame.c (Fhandle_switch_frame):
753 * fileio.c (Fdo_auto_save):
754 * emacs.c (Fkill_emacs):
755 * editfns.c (save_excursion_restore):
756 * cmds.c (internal_self_insert):
757 * callint.c (Fcall_interactively):
758 * buffer.c (Fkill_all_local_variables):
759 * keyboard.c (Fcommand_execute, Fsuspend_emacs, safe_run_hooks_1):
760 Use Frun_hooks.
0f4a96b5 761 (command_loop_1): Use Frun_hooks. Call safe_run_hooks
dee091a3
JD
762 unconditionnaly since it does the check itself.
763
2c520ab5 7642011-03-23 Paul Eggert <eggert@cs.ucla.edu>
f0641eff 765
c9c49752
PE
766 Fix more problems found by GCC 4.5.2's static checks.
767
8abc3f12
PE
768 * coding.c (encode_coding_raw_text): Avoid unnecessary test
769 the first time through the loop, since we know p0 < p1 then.
770 This also avoids a gcc -Wstrict-overflow warning.
771
a2d26660
PE
772 * lisp.h (SAFE_ALLOCA, SAFE_ALLOCA_LISP): Avoid 'int' overflow
773 leading to a memory leak, possible in functions like
774 load_charset_map_from_file that can allocate an unbounded number
b12ef411 775 of objects (Bug#8318).
a2d26660 776
916c72e9
PE
777 * xmenu.c (set_frame_menubar): Use EMACS_UINT, not int, for indexes
778 that could (at least in theory) be that large.
779
19ab8a18
PE
780 * xdisp.c (message_log_check_duplicate): Return unsigned long, not int.
781 This is less likely to overflow, and avoids undefined behavior if
782 overflow does occur. All callers changed. Use strtoul to scan
783 for the unsigned long integer.
b7cbbd6f
PE
784 (pint2hrstr): Simplify and tune code slightly.
785 This also avoids a (bogus) GCC warning with gcc -Wstrict-overflow.
19ab8a18 786
f0641eff
PE
787 * scroll.c (do_scrolling): Work around GCC bug 48228.
788 See <http://gcc.gnu.org/bugzilla/show_bug.cgi?id=48228>.
789
7f650bb9
PE
790 * frame.c (Fmodify_frame_parameters): Simplify loop counter.
791 This also avoids a warning with gcc -Wstrict-overflow.
39f5e519
PE
792 (validate_x_resource_name): Simplify count usage.
793 This also avoids a warning with gcc -Wstrict-overflow.
7f650bb9 794
37dd57d1
PE
795 * fileio.c (Fcopy_file): Report error if fchown or fchmod
796 fail (Bug#8306).
81e56e61 797
699979fc 798 * emacs.c (Fdaemon_initialized): Do not ignore I/O errors (Bug#8303).
dc1ca6a8 799
401bf9b4
PE
800 * process.c (Fmake_network_process): Use socklen_t, not int,
801 where POSIX says socklen_t is required in portable programs.
802 This fixes a porting bug on hosts like 64-bit HP-UX, where
591b2973 803 socklen_t is wider than int (Bug#8277).
401bf9b4
PE
804 (Fmake_network_process, server_accept_connection):
805 (wait_reading_process_output, read_process_output):
806 Likewise.
807
b93aacde
PE
808 * process.c: Rename or move locals to avoid shadowing.
809 (list_processes_1, Fmake_network_process):
810 (read_process_output_error_handler, exec_sentinel_error_handler):
811 Rename or move locals.
4dc343ee 812 (Fmake_network_process): Define label "retry_connect" only if needed.
0da49335 813 (Fnetwork_interface_info): Fix pointer signedness.
f990b4e5 814 (process_send_signal): Add cast to avoid pointer signedness problem.
7b808126 815 (FIRST_PROC_DESC, IF_NON_BLOCKING_CONNECT): Remove unused macros.
c939f91b 816 (create_process): Use 'volatile' to avoid vfork clobbering (Bug#8298).
b93aacde 817
af8a867c 818 Make tparam.h and terminfo.c consistent.
44f230aa
SM
819 * cm.c (tputs, tgoto, BC, UP): Remove extern decls.
820 Include tparam.h instead, since it declares them.
af8a867c
PE
821 * cm.h (PC): Remove extern decl; tparam.h now does this.
822 * deps.mk (cm.o, terminfo.o): Depend on tparam.h.
823 * terminfo.c: Include tparam.h, to check interfaces.
824 (tparm): Make 1st arg a const pointer in decl. Put it at top level.
825 (tparam): Adjust signature to match interface in tparam.h;
826 this removes some undefined behavior. Check that outstring and len
827 are zero, which they always are with Emacs.
828 * tparam.h (PC, BC, UP): New extern decls.
829
0248044d 830 * xftfont.c (xftfont_shape): Now static, and defined only if needed.
001a7ab4 831 (xftfont_open): Rename locals to avoid shadowing.
0248044d 832
8ff096c1 833 * ftfont.c (ftfont_resolve_generic_family): Fix pointer signedness.
a00924bb
PE
834 (ftfont_otf_capability, ftfont_shape): Omit decls if not needed.
835 (OTF_TAG_SYM): Omit macro if not needed.
e932860f 836 (ftfont_list): Remove unused local.
49eaafba
PE
837 (get_adstyle_property, ftfont_pattern_entity):
838 (ftfont_lookup_cache, ftfont_open, ftfont_anchor_point):
839 Rename locals to avoid shadowing.
8ff096c1 840
e2be39f6
PE
841 * xfont.c (xfont_list_family): Mark var as initialized.
842
c9735e30
PE
843 * xml.c (make_dom): Now static.
844
8f5201ae
PE
845 * composite.c (composition_compute_stop_pos): Rename local to
846 avoid shadowing.
b246f932
PE
847 (composition_reseat_it): Remove unused locals.
848 (find_automatic_composition, composition_adjust_point): Likewise.
80e079b2 849 (composition_update_it): Mark var as initialized.
11b61122
PE
850 (find_automatic_composition): Mark vars as initialized,
851 with a FIXME (Bug#8290).
8f5201ae 852
760fbc2c
PE
853 character.h: Rename locals to avoid shadowing.
854 * character.h (PREV_CHAR_BOUNDARY, FETCH_STRING_CHAR_ADVANCE):
855 (FETCH_STRING_CHAR_AS_MULTIBYTE_ADVANCE, FETCH_CHAR_ADVANCE):
856 (FETCH_CHAR_ADVANCE_NO_CHECK, INC_POS, DEC_POS, BUF_INC_POS):
857 (BUF_DEC_POS): Be more systematic about renaming local temporaries
858 to avoid shadowing.
859
ff08eb85
PE
860 * textprop.c (property_change_between_p): Remove; unused.
861
fc7bf025
PE
862 * intervals.c (interval_start_pos): Now static.
863
235d7abc
PE
864 * intervals.h (CHECK_TOTAL_LENGTH): Avoid empty "else".
865
44f230aa
SM
866 * atimer.c (start_atimer, append_atimer_lists, set_alarm):
867 Rename locals to avoid shadowing.
3e7d6594 868
50060332
PE
869 * sound.c (wav_play, au_play, Fplay_sound_internal):
870 Fix pointer signedness.
d01f234b 871 (alsa_choose_format): Remove unused local var.
c83b8872
PE
872 (wav_play): Initialize a variable to 0, to prevent undefined
873 behavior (Bug#8278).
50060332 874
c4fc4e30
PE
875 * region-cache.c (insert_cache_boundary): Redo var to avoid shadowing.
876
918436ed
PE
877 * region-cache.h (pp_cache): New decl, for gcc -Wmissing-prototypes.
878
c939f91b
PE
879 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork
880 clobbering (Bug#8298).
b9c7f648
PE
881 * sysdep.c (sys_subshell): Likewise.
882 Previously, the sys_subshell 'volatile' was incorrectly IF_LINTted out.
7e9123a2 883
6bd8c144
PE
884 * lisp.h (child_setup): Now NO_RETURN unless DOS_NT.
885 This should get cleaned up, so that child_setup has the
886 same signature on all platforms.
887
7710357c 888 * callproc.c (call_process_cleanup): Now static.
cb1d0ef7 889 (relocate_fd): Rename locals to avoid shadowing.
7710357c 890
c59da222
CY
8912011-03-22 Chong Yidong <cyd@stupidchicken.com>
892
893 * xterm.c (x_clear_frame): Remove XClearWindow call. This appears
894 not to be necessary, and produces flickering.
895
66b87493
GM
8962011-03-20 Glenn Morris <rgm@gnu.org>
897
898 * config.in: Remove file.
899
45b6f6d5
JB
9002011-03-20 Juanma Barranquero <lekktu@gmail.com>
901
902 * minibuf.c (Vcompleting_read_function): Don't declare, global variables
903 are now in src/globals.h.
904 (syms_of_minibuf): Remove spurious & from previous change.
905
3ec03f7e
LL
9062011-03-20 Leo <sdl.web@gmail.com>
907
908 * minibuf.c (completing-read-function): New variable.
909 (completing-read-default): Rename from completing-read.
910 (completing-read): Call completing-read-function.
911
b14e3e21
CY
9122011-03-19 Juanma Barranquero <lekktu@gmail.com>
913
914 * xfaces.c (Fx_load_color_file):
915 Read color file from absolute filename (bug#8250).
916
f2b726e6
JB
9172011-03-19 Juanma Barranquero <lekktu@gmail.com>
918
919 * makefile.w32-in: Update dependencies.
920
09f6ff02
EZ
9212011-03-17 Eli Zaretskii <eliz@gnu.org>
922
923 * makefile.w32-in ($(BLD)/unexw32.$(O)): Depend on $(SRC)/unexec.h.
924
29a6015a
PE
9252011-03-17 Paul Eggert <eggert@cs.ucla.edu>
926
a3a6c54e
PE
927 Fix more problems found by GCC 4.5.2's static checks.
928
b766f867
PE
929 * process.c (make_serial_process_unwind, send_process_trap):
930 (sigchld_handler): Now static.
931
be02381c
PE
932 * process.c (allocate_pty): Let PTY_ITERATION declare iteration vars.
933 That way, the code declares only the vars that it needs.
934 * s/aix4-2.h (PTY_ITERATION): Declare iteration vars.
935 * s/cygwin.h (PTY_ITERATION): Likewise.
936 * s/darwin.h (PTY_ITERATION): Likewise.
937 * s/gnu-linux.h (PTY_ITERATION): Likewise.
938
57048744
PE
939 * s/irix6-5.h (PTY_OPEN): Declare stb, to loosen coupling.
940 * process.c (allocate_pty): Don't declare stb unless it's needed.
941
7914961c 942 * bytecode.c (MAYBE_GC): Rewrite so as not to use empty "else".
615f2d59
PE
943 (CONSTANTLIM): Remove; unused.
944 (METER_CODE, Bscan_buffer, Bread_char, Bset_mark):
945 Define only if needed.
7914961c 946
b3967b18
PE
947 * unexelf.c (unexec): Name an expression,
948 to avoid gcc -Wbad-function-cast warning.
9ae71512
PE
949 Use a different way to cause a compilation error if anyone uses
950 n rather than nn, a way that does not involve shadowing.
73366a00 951 (ELF_BSS_SECTION_NAME, OLD_PROGRAM_H): Remove; unused.
b3967b18 952
29a6015a
PE
953 * deps.mk (unexalpha.o): Remove; unused.
954
43cfc33e 955 New file unexec.h, the (simple) interface for unexec (Bug#8267).
7feda0d2 956 * unexec.h: New file.
ce701a33
PE
957 * deps.mk (emacs.o, unexaix.o, unexcw.o, unexcoff.o, unexelf.o):
958 (unexhp9k800.o, unexmacosx.o, unexsol.o, unexw32.o):
959 Depend on unexec.h.
960 * emacs.c [!defined CANNOT_DUMP]: Include unexec.h.
961 * unexaix.c, unexcoff.c, unexcw.c, unexelf.c, unexhp9k800.c:
962 * unexmacosx.c, unexsol.c, unexw32.c: Include unexec.h.
381259ef 963 Change as necessary to match prototype in unexec.h.
ce701a33 964
01f44d5a
PE
965 * syntax.c (Fforward_comment, scan_lists): Rename locals to avoid
966 shadowing.
4f63c6bb 967 (back_comment, skip_chars): Mark vars as initialized.
01f44d5a 968
a6670b0b
PE
969 * character.h (FETCH_STRING_CHAR_ADVANCE_NO_CHECK, BUF_INC_POS):
970 Rename locals to avoid shadowing.
971
cef2010d 972 * lread.c (read1): Rewrite so as not to use empty "else".
0902fe45 973 (Fload, readevalloop, read1): Rename locals to avoid shadowing.
cef2010d 974
d4d7173a
PE
975 * print.c (Fredirect_debugging_output): Fix pointer signedess.
976
f08b802a
PE
977 * lisp.h (debug_output_compilation_hack): Add decl here, to avoid
978 warning when compiling print.c.
979
3ddb0639
PE
980 * font.c (font_unparse_fcname): Abort in an "impossible" situation
981 instead of using an uninitialized var.
5ad03b97 982 (font_sort_entities): Mark var as initialized.
3ddb0639 983
170a2692
PE
984 * character.h (FETCH_CHAR_ADVANCE): Rename locals to avoid shadowing.
985
e663c700
PE
986 * font.c (font_unparse_xlfd): Don't mix pointers to variables with
987 pointers to constants.
89bc529a 988 (font_parse_fcname): Remove unused vars.
7b81e2d0 989 (font_delete_unmatched): Now static.
ea838e10 990 (font_get_spec): Remove; unused.
13a547c6
PE
991 (font_style_to_value, font_prop_validate_style, font_unparse_fcname):
992 (font_update_drivers, Ffont_get_glyphs, font_add_log):
993 Rename or move locals to avoid shadowing.
e663c700 994
2a80c887 995 * fns.c (require_nesting_list, require_unwind): Now static.
612f56df 996 (Ffillarray): Rename locals to avoid shadowing.
2a80c887 997
1384fa33 998 * floatfns.c (domain_error2): Define only if needed.
a885e2ed 999 (Ffrexp, Fldexp): Rename locals to avoid shadowing.
1384fa33 1000
8b2c52e9
PE
1001 * alloc.c (mark_backtrace): Move decl from here ...
1002 * lisp.h: ... to here, so that it can be checked.
1003
475545b5 1004 * eval.c (call_debugger, do_debug_on_call, grow_specpdl): Now static.
d28a2170 1005 (Fdefvar): Rewrite so as not to use empty "else".
cfcbfb1a
PE
1006 (lisp_indirect_variable): Name an expression,
1007 to avoid gcc -Wbad-function-cast warning.
1faed8ae 1008 (Fdefvar): Rename locals to avoid shadowing.
475545b5 1009
b1349114 1010 * callint.c (quotify_arg, quotify_args): Now static.
a3e8cbda 1011 (Fcall_interactively): Rename locals to avoid shadowing.
b0e80955 1012 Use const pointer when appropriate.
b1349114 1013
a2928364
PE
1014 * lisp.h (get_system_name, get_operating_system_release):
1015 Move decls here, to check interfaces.
1016 * process.c (get_operating_system_release): Move decl to lisp.h.
1017 * xrdb.c (get_system_name): Likewise.
63c5d10b
PE
1018 * editfns.c (init_editfns, Fuser_login_name, Fuser_uid):
1019 (Fuser_real_uid, Fuser_full_name): Remove unnecessary casts,
1020 some of which prompt warnings from gcc -Wbad-function-cast.
545b49b4
PE
1021 (Fformat_time_string, Fencode_time, Finsert_char):
1022 (Ftranslate_region_internal, Fformat):
1023 Rename or remove local vars to avoid shadowing.
9710023e 1024 (Ftranslate_region_internal): Mark var as initialized.
63c5d10b 1025
a415e694
PE
1026 * doc.c (Fdocumentation, Fsnarf_documentation): Move locals to
1027 avoid shadowing.
1028
8ef4622d
PE
1029 * lisp.h (eassert): Check that the argument compiles, even if
1030 ENABLE_CHECKING is not defined.
1031
946f9a5b
PE
1032 * data.c (Findirect_variable): Name an expression, to avoid
1033 gcc -Wbad-function-cast warning.
112396d6 1034 (default_value, arithcompare, arith_driver, arith_error): Now static.
b9b84fa9 1035 (store_symval_forwarding): Rename local to avoid shadowing.
44f230aa
SM
1036 (Fmake_variable_buffer_local, Fmake_local_variable):
1037 Mark variables as initialized.
52746918 1038 (do_blv_forwarding, do_symval_forwarding): Remove; unused.
946f9a5b 1039
e5aab7e7 1040 * alloc.c (check_cons_list): Do not define unless GC_CHECK_CONS_LIST.
ae35e756
PE
1041 (Fmake_vector, Fvector, Fmake_byte_code, Fgarbage_collect):
1042 Rename locals to avoid shadowing.
dff45157
PE
1043 (mark_stack): Move local variables into the #ifdef region where
1044 they're used.
7bc26fdb
PE
1045 (BLOCK_INPUT_ALLOC, UNBLOCK_INPUT_ALLOC): Define only if
1046 ! defined SYSTEM_MALLOC && ! defined SYNC_INPUT, as they are not
1047 needed otherwise.
1048 (CHECK_ALLOCATED): Define only if GC_CHECK_MARKED_OBJECTS.
1049 (GC_STRING_CHARS): Remove; not used.
d40d4be1 1050 (Fmemory_limit): Cast sbrk's returned value to char *.
ae35e756 1051
e5aab7e7
PE
1052 * lisp.h (check_cons_list): Declare if GC_CHECK_CONS_LIST; this
1053 avoids undefined behavior in theory.
1054
4da60324
PE
1055 * regex.c (IF_LINT): Add defn, for benefit of ../lib-src.
1056
88043301
PE
1057 Use functions, not macros, for up- and down-casing (Bug#8254).
1058 * buffer.h (DOWNCASE_TABLE, UPCASE_TABLE, DOWNCASE, UPPERCASEP):
1059 (NOCASEP, LOWERCASEP, UPCASE, UPCASE1): Remove. All callers changed
1060 to use the following functions instead of these macros.
1061 (downcase): Adjust to lack of DOWNCASE_TABLE. Return int, not
1062 EMACS_INT, since callers assume the returned value fits in int.
1063 (upcase1): Likewise, for UPCASE_TABLE.
1064 (uppercasep, lowercasep, upcase): New static inline functions.
0da09c43 1065 * editfns.c (Fchar_equal): Remove no-longer-needed workaround for
db69b0cd 1066 the race-condition problem in the old DOWNCASE.
88043301 1067
19ed5445
PE
1068 * regex.c (CHARSET_LOOKUP_RANGE_TABLE_RAW, POP_FAILURE_REG_OR_COUNT):
1069 Rename locals to avoid shadowing.
1070 (regex_compile, re_match_2_internal): Move locals to avoid shadowing.
abbd1bcf
PE
1071 (regex_compile, re_search_2, re_match_2_internal):
1072 Remove unused local vars.
952db0d7
PE
1073 (FREE_VAR): Rewrite so as not to use empty "else",
1074 which gcc can warn about.
da053e48 1075 (regex_compile, re_match_2_internal): Mark locals as initialized.
b313f9d8
PE
1076 (RETALLOC_IF): Define only if needed.
1077 (WORDCHAR_P): Likewise. This one is never needed, but is used
1078 only in a comment talking about a compiler bug, so put inside
1079 the #if 0 of that comment.
1080 (CHARSET_LOOKUP_BITMAP, FAIL_STACK_FULL, RESET_FAIL_STACK):
1081 (PUSH_FAILURE_ELT, BUF_PUSH_3, STOP_ADDR_VSTRING):
1082 Remove; unused.
19ed5445 1083
1f3561e4 1084 * search.c (boyer_moore): Rename locals to avoid shadowing.
76ef09b7
PE
1085 * character.h (FETCH_STRING_CHAR_AS_MULTIBYTE_ADVANCE):
1086 (PREV_CHAR_BOUNDARY): Likewise.
1f3561e4 1087
ded6f8f7
PE
1088 * search.c (simple_search): Remove unused var.
1089
dbd37a95
PE
1090 * dired.c (compile_pattern): Move decl from here ...
1091 * lisp.h: ... to here, so that it can be checked.
1092 (struct re_registers): New forward decl.
1093
7e47afad
PE
1094 * character.h (INC_POS, DEC_POS): Rename locals to avoid shadowing.
1095
85f24f61
PE
1096 * indent.c (MULTIBYTE_BYTES_WIDTH): New args bytes, width.
1097 All uses changed.
1098 (MULTIBYTE_BYTES_WIDTH, scan_for_column, compute_motion):
1099 Rename locals to avoid shadowing.
5671df8f 1100 (Fvertical_motion): Mark locals as initialized.
85f24f61 1101
181aa2be 1102 * casefiddle.c (casify_object, casify_region): Now static.
e45a141a 1103 (casify_region): Mark local as initialized.
181aa2be 1104
930d429c
PE
1105 * cmds.c (internal_self_insert): Rename local to avoid shadowing.
1106
7082eac6
PE
1107 * lisp.h (GCPRO2_VAR, GCPRO3_VAR, GCPRO4_VAR, GCPRO5_VAR, GCPRO6_VAR):
1108 New macros, so that the caller can use some names other than
1109 gcpro1, gcpro2, etc.
1110 (GCPRO2, GCPRO3, GCPRO4, GCPRO5, GCPRO6): Reimplement in terms
1111 of the new macros.
1112 (GCPRO1_VAR, UNGCPRO_VAR): Change the meaning of the second
1113 argument, for consistency with GCPRO2_VAR, etc: it is now the
1114 prefix of the variable, not the variable itself. All uses
1115 changed.
38b2c076
PE
1116 * dired.c (directory_files_internal, file_name_completion):
1117 Rename locals to avoid shadowing.
1118
15206ed9
PE
1119 Fix a race condition diagnosed by gcc -Wsequence-point (Bug#8254).
1120 An expression of the form (DOWNCASE (x) == DOWNCASE (y)), found in
1121 dired.c's scmp function, had undefined behavior.
1122 * lisp.h (DOWNCASE_TABLE, UPCASE_TABLE, DOWNCASE, UPPERCASEP):
1123 (NOCASEP, LOWERCASEP, UPCASE, UPCASE1): Move from here ...
1124 * buffer.h: ... to here, because these macros use current_buffer,
1125 and the new implementation with inline functions needs to have
1126 current_buffer in scope now, rather than later when the macros
1127 are used.
1128 (downcase, upcase1): New static inline functions.
1129 (DOWNCASE, UPCASE1): Reimplement using these functions.
1130 This avoids undefined behavior in expressions like
1131 DOWNCASE (x) == DOWNCASE (y), which previously suffered
1132 from race conditions in accessing the global variables
1133 case_temp1 and case_temp2.
1134 * casetab.c (case_temp1, case_temp2): Remove; no longer needed.
1135 * lisp.h (case_temp1, case_temp2): Remove their decls.
1136 * character.h (ASCII_CHAR_P): Move from here ...
1137 * lisp.h: ... to here, so that the inline functions mentioned
1138 above can use them.
1139
4a6bea26
PE
1140 * dired.c (directory_files_internal_unwind): Now static.
1141
f14b7e14
PE
1142 * fileio.c (file_name_as_directory, directory_file_name):
1143 (barf_or_query_if_file_exists, auto_save_error, auto_save_1):
1144 Now static.
2893f146
PE
1145 (file_name_as_directory): Use const pointers when appropriate.
1146 (Fexpand_file_name): Likewise. In particular, newdir might
1147 point at constant storage, so make it a const pointer.
fd4ead52 1148 (Fmake_directory_internal, Fread_file_name): Remove unused vars.
b14aac08
PE
1149 (Ffile_selinux_context, Fset_file_selinux_context): Fix pointer
1150 signedness issues.
f839df0c
PE
1151 (Fset_file_times, Finsert_file_contents, auto_save_error):
1152 Rename locals to avoid shadowing.
f14b7e14 1153
5716756e 1154 * minibuf.c (choose_minibuf_frame_1): Now static.
62137a95
PE
1155 (Ftry_completion, Fall_completions): Rename or remove locals
1156 to avoid shadowing.
5716756e 1157
b4c3046a
PE
1158 * marker.c (bytepos_to_charpos): Remove; unused.
1159
b45db522
PE
1160 * lisp.h (verify_bytepos, count_markers): New decls,
1161 so that gcc does not warn that these functions aren't declared.
1162
85876d07
PE
1163 * insdel.c (check_markers, make_gap_larger, make_gap_smaller):
1164 (reset_var_on_error, Fcombine_after_change_execute_1): Now static.
f0cb4a60 1165 (CHECK_MARKERS): Redo to avoid gcc -Wempty-body diagnostic.
40ef059e 1166 (copy_text): Remove unused local var.
85876d07 1167
03d78a21 1168 * filelock.c (within_one_second): Now static.
b3dd38ab 1169 (lock_file_1): Rename local to avoid shadowing.
03d78a21 1170
5df8f01b
PE
1171 * buffer.c (fix_overlays_before): Mark locals as initialized.
1172 (fix_start_end_in_overlays): Likewise. This function should be
1173 simplified by using pointers-to-pointers, but that's a different
1174 matter.
b1d876f1 1175 (switch_to_buffer_1): Now static.
8f54f30a
PE
1176 (Fkill_buffer, record_buffer, Fbury_buffer, Fset_buffer_multibyte):
1177 (report_overlay_modification): Rename locals to avoid shadowing.
c3bd59b5 1178
a70072c9 1179 * sysdep.c (system_process_attributes): Rename vars to avoid shadowing.
fbd02d7b 1180 Fix pointer signedness issue.
edced198
PE
1181 (sys_subshell): Mark local as volatile if checking for lint,
1182 to suppress a gcc -Wclobbered warning that does not seem to be right.
15dfd3d9 1183 (MAXPATHLEN): Define only if needed.
a70072c9 1184
a0977c44
PE
1185 * process.c (serial_open, serial_configure): Move decls from here ...
1186 * systty.h: ... to here, so that they can be checked.
1187
a884fdcc
PE
1188 * fns.c (get_random, seed_random): Move extern decls from here ...
1189 * lisp.h: ... to here, so that they can be checked.
1190
604efe86 1191 * sysdep.c (reset_io): Now static.
b8950c94 1192 (wait_for_termination_signal): Remove; unused.
604efe86 1193
38fc62d9
PE
1194 * keymap.c (keymap_parent, keymap_memberp, map_keymap_internal):
1195 (copy_keymap_item, append_key, push_text_char_description):
1196 Now static.
1004a21a 1197 (Fwhere_is_internal): Don't test CONSP (sequences) unnecessarily.
dbbb8427 1198 (DENSE_TABLE_SIZE): Remove; unused.
c1141155
PE
1199 (get_keymap, access_keymap, Fdefine_key, Fwhere_is_internal):
1200 (describe_map_tree):
1201 Rename locals to avoid shadowing.
38fc62d9 1202
2f2650da
PE
1203 * keyboard.c: Declare functions static if they are not used elsewhere.
1204 (echo_char, echo_dash, cmd_error, top_level_2):
1205 (poll_for_input, handle_async_input): Now static.
69a058fa
PE
1206 (read_char, kbd_buffer_get_event, make_lispy_position):
1207 (make_lispy_event, make_lispy_movement, apply_modifiers):
1208 (decode_keyboard_code, tty_read_avail_input, menu_bar_items):
1209 (parse_tool_bar_item, read_key_sequence, Fread_key_sequence):
1210 (Fread_key_sequence_vector): Rename locals to avoid shadowing.
c8a06054 1211 (read_key_sequence, read_char): Mark locals as initialized.
3ac94672 1212 (Fexit_recursive_edit, Fabort_recursive_edit): Mark with NO_RETURN.
2f2650da 1213
a053e86c 1214 * keyboard.h (make_ctrl_char): New decl.
da2f2dd9
PE
1215 (mark_kboards): Move decl here ...
1216 * alloc.c (mark_kboards): ... from here.
a053e86c 1217
4752793e
PE
1218 * lisp.h (force_auto_save_soon): New decl.
1219
74f10ca7 1220 * emacs.c (init_cmdargs): Rename local to avoid shadowing.
244fc23d
PE
1221 (DEFINE_DUMMY_FUNCTION): New macro.
1222 (__do_global_ctors, __do_global_ctors_aux, __do_global_dtors, __main):
1223 Use it.
c03cd23f
PE
1224 (main): Add casts to avoid warnings
1225 if GCC considers string literals to be constants.
74f10ca7 1226
022e70d4
PE
1227 * lisp.h (fatal_error_signal): Add decl, since it's exported.
1228
59d6fe83
PE
1229 * dbusbind.c: Pointer signedness fixes.
1230 (xd_signature, xd_append_arg, xd_initialize):
1231 (Fdbus_call_method, Fdbus_call_method_asynchronously):
1232 (Fdbus_method_return_internal, Fdbus_method_error_internal):
1233 (Fdbus_send_signal, xd_read_message_1, Fdbus_register_service):
1234 (Fdbus_register_signal): Use SSDATA when the context wants char *.
1235
78320123
PE
1236 * dbusbind.c (Fdbus_init_bus): Add cast to avoid warning
1237 if GCC considers string literals to be constants.
49cebcca 1238 (Fdbus_register_service, Fdbus_register_method): Remove unused vars.
78320123 1239
35ac2a97
SM
12402011-03-16 Stefan Monnier <monnier@iro.umontreal.ca>
1241
fb103ca9
SM
1242 * print.c (PRINT_CIRCLE_CANDIDATE_P): New macro.
1243 (print_preprocess, print_object): New macro to fix last change.
1244
35ac2a97
SM
1245 * print.c (print_preprocess): Don't forget font objects.
1246
62973b41
JB
12472011-03-16 Juanma Barranquero <lekktu@gmail.com>
1248
1249 * emacs.c (USAGE3): Doc fixes.
1250
0e48bb22
AS
12512011-03-15 Andreas Schwab <schwab@linux-m68k.org>
1252
1253 * coding.c (detect_coding_iso_2022): Reorganize code to clarify
1254 structure.
1255
7684e57b
JB
12562011-03-14 Juanma Barranquero <lekktu@gmail.com>
1257
1258 * lisp.h (VWindow_system, Qfile_name_history):
1259 * keyboard.h (lispy_function_keys) [WINDOWSNT]:
1260 * w32term.h (w32_system_caret_hwnd, w32_system_caret_height)
1261 (w32_system_caret_x, w32_system_caret_y): Declare extern.
1262
1263 * w32select.c: Don't #include "keyboard.h".
c96bbc66 1264 (run_protected): Add extern declaration for waiting_for_input.
7684e57b
JB
1265
1266 * w32.c (Qlocal, noninteractive1, inhibit_window_system):
1267 * w32console.c (detect_input_pending, read_input_pending)
1268 (encode_terminal_code):
1269 * w32fns.c (quit_char, lispy_function_keys, Qtooltip)
1270 (w32_system_caret_hwnd, w32_system_caret_height, w32_system_caret_x)
1271 (w32_system_caret_y, Qfile_name_history):
1272 * w32font.c (w32font_driver, QCantialias, QCotf, QClang):
1273 * w32inevt.c (reinvoke_input_signal, lispy_function_keys):
1274 * w32menu.c (Qmenu_bar, QCtoggle, QCradio, Qoverriding_local_map)
1275 (Qoverriding_terminal_local_map, Qmenu_bar_update_hook):
1276 * w32proc.c (Qlocal, report_file_error):
1277 * w32term.c (Vwindow_system, updating_frame):
1278 * w32uniscribe.c (initialized, uniscribe_font_driver):
1279 Remove unneeded extern declarations.
1280
2aa46d6c
CY
12812011-03-14 Chong Yidong <cyd@stupidchicken.com>
1282
c96bbc66 1283 * buffer.c (Fmake_indirect_buffer): Fix incorrect assertions.
2aa46d6c 1284
cffc6f3b
CY
12852011-03-13 Chong Yidong <cyd@stupidchicken.com>
1286
1287 * buffer.h (BUF_BEGV, BUF_BEGV_BYTE, BUF_ZV, BUF_ZV_BYTE, BUF_PT)
1288 (BUF_PT_BYTE): Rewrite to handle indirect buffers (Bug#8219).
1289 These macros can no longer be used for assignment.
1290
44f230aa
SM
1291 * buffer.c (Fget_buffer_create, Fmake_indirect_buffer):
1292 Assign struct members directly, instead of using BUF_BEGV etc.
cffc6f3b
CY
1293 (record_buffer_markers, fetch_buffer_markers): New functions for
1294 recording and fetching special buffer markers.
1295 (set_buffer_internal_1, set_buffer_temp): Use them.
1296
1297 * lread.c (unreadchar): Use SET_BUF_PT_BOTH.
1298
1299 * insdel.c (adjust_point): Use SET_BUF_PT_BOTH.
1300
1301 * intervals.c (temp_set_point_both): Use SET_BUF_PT_BOTH.
1302 (get_local_map): Use SET_BUF_BEGV_BOTH and SET_BUF_ZV_BOTH.
1303
1304 * xdisp.c (hscroll_window_tree):
1305 (reconsider_clip_changes): Use PT instead of BUF_PT.
1306
d251f04b
EZ
13072011-03-13 Eli Zaretskii <eliz@gnu.org>
1308
1309 * makefile.w32-in ($(BLD)/editfns.$(O)): Depend on
1310 $(EMACS_ROOT)/lib/intprops.h.
1311
f0c77cd1
PE
13122011-03-13 Paul Eggert <eggert@cs.ucla.edu>
1313
3eca4629
PE
1314 Fix more problems found by GCC 4.5.2's static checks.
1315
7c86ee98
PE
1316 * gtkutil.c (xg_get_pixbuf_from_pixmap): Add cast from char *
1317 to unsigned char * to avoid compiler diagnostic.
b0afc268
PE
1318 (xg_free_frame_widgets): Make it clear that a local variable is
1319 needed only if USE_GTK_TOOLTIP.
01e0b5ad
PE
1320 (gdk_window_get_screen): Make it clear that this macro is needed
1321 only if USE_GTK_TOOLTIP.
1e5524e7
PE
1322 (int_gtk_range_get_value): New function, which avoids a diagnostic
1323 from gcc -Wbad-function-cast.
1324 (xg_set_toolkit_scroll_bar_thumb): Use it.
1325 (xg_tool_bar_callback, xg_tool_item_stale_p): Rewrite to avoid
1326 diagnostic from gcc -Wbad-function-cast.
65dc836c
PE
1327 (get_utf8_string, xg_get_file_with_chooser):
1328 Rename locals to avoid shadowing.
1329 (create_dialog): Move locals to avoid shadowing.
7c86ee98 1330
41729b81
PE
1331 * xgselect.c (xg_select): Remove unused var.
1332
f0c77cd1
PE
1333 * image.c (four_corners_best): Mark locals as initialized.
1334 (gif_load): Initialize transparent_p to zero (Bug#8238).
1335 Mark another local as initialized.
ec6cf4c6 1336 (my_png_error, my_error_exit): Mark with NO_RETURN.
f0c77cd1 1337
ce0ad53d 1338 * image.c (clear_image_cache): Now static.
d5d5a617 1339 (DIM, HAVE_STDLIB_H_1): Remove unused macros.
e22cffbc 1340 (xpm_load): Redo to avoid "discards qualifiers" gcc warning.
77a765fd
PE
1341 (x_edge_detection): Remove unnecessary cast that
1342 gcc -Wbad-function-cast diagnoses.
2037898d 1343 (gif_load): Fix pointer signedness.
6ae141d6
PE
1344 (clear_image_cache, xbm_read_bitmap_data, x_detect_edges):
1345 (jpeg_load, gif_load): Rename locals to avoid shadowing.
ce0ad53d 1346
33383987 13472011-03-12 Paul Eggert <eggert@cs.ucla.edu>
3eca4629 1348
d32df629
PE
1349 Improve quality of tests for time stamp overflow.
1350 For example, without this patch (encode-time 0 0 0 1 1
1351 1152921504606846976) returns the obviously-bogus value (-948597
1352 62170) on my RHEL 5.5 x86-64 host. With the patch, it correctly
1353 reports time overflow. See
1354 <http://lists.gnu.org/archive/html/emacs-devel/2011-03/msg00470.html>.
b8d9bd41
PE
1355 * deps.mk (editfns.o): Depend on ../lib/intprops.h.
1356 * editfns.c: Include limits.h and intprops.h.
1357 (TIME_T_MIN, TIME_T_MAX): New macros.
1358 (time_overflow): Move earlier, to before first use.
1359 (hi_time, lo_time): New functions, for an accurate test for
1360 out-of-range times.
1361 (Fcurrent_time, Fget_internal_run_time, make_time): Use them.
1362 (Fget_internal_run_time): Don't assume time_t fits in int.
1363 (make_time): Use list2 instead of Fcons twice.
1364 (Fdecode_time): More accurate test for out-of-range times.
1365 (check_tm_member): New function.
1366 (Fencode_time): Use it, to test for out-of-range times.
d32df629
PE
1367 (lisp_time_argument): Don't rely on undefined left-shift and
1368 right-shift behavior when checking for time stamp overflow.
8be6f318 1369
fe31d94c
PE
1370 * editfns.c (time_overflow): New function, refactoring common code.
1371 (Fformat_time_string, Fdecode_time, Fencode_time):
1372 (Fcurrent_time_string): Use it.
1373
8be6f318
PE
1374 Move 'make_time' to be next to its inverse 'lisp_time_argument'.
1375 * dired.c (make_time): Move to ...
1376 * editfns.c (make_time): ... here.
1377 * systime.h: Note the move.
1378
09d9db2c 13792011-03-12 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
c47cbdfd 1380
126bc0dc
YM
1381 * fringe.c (update_window_fringes): Remove unused variables.
1382
c47cbdfd
YM
1383 * unexmacosx.c (copy_data_segment): Also copy __got section.
1384 (Bug#8223)
1385
7ac80be9
EZ
13862011-03-12 Eli Zaretskii <eliz@gnu.org>
1387
c96bbc66 1388 * termcap.c [MSDOS]: Include "msdos.h".
058e5dad
EZ
1389 (find_capability, tgetnum, tgetflag, tgetstr, tputs, tgetent):
1390 Constify `char *' arguments and their references according to
1391 prototypes in tparam.h.
1392
ecb0f94d 1393 * deps.mk (termcap.o): Depend on tparam.h and msdos.h.
058e5dad 1394
7ac80be9
EZ
1395 * msdos.c (XMenuAddPane): 3rd argument is `const char *' now.
1396 Adapt all references accordingly.
1397
1398 * msdos.h (XMenuAddPane): 3rd argument is `const char *' now.
1399
ef1fd07e
TT
14002011-03-11 Tom Tromey <tromey@redhat.com>
1401
1402 * buffer.c (syms_of_buffer): Remove obsolete comment.
1403
7ef4b50c
EZ
14042011-03-11 Eli Zaretskii <eliz@gnu.org>
1405
1406 * termhooks.h (encode_terminal_code): Declare prototype.
1407
1408 * msdos.c (encode_terminal_code): Don't declare prototype.
1409
1410 * term.c (encode_terminal_code): Now external again, used by
1411 w32console.c and msdos.c.
1412
44f230aa
SM
1413 * makefile.w32-in ($(BLD)/term.$(O), ($(BLD)/tparam.$(O)):
1414 Depend on $(SRC)/tparam.h, see 2011-03-11T07:24:21Z!eggert@cs.ucla.edu.
7ef4b50c 1415
4b1ec863 14162011-03-11 Paul Eggert <eggert@cs.ucla.edu>
f78faa98 1417
1714f52b 1418 Fix some minor problems found by GCC 4.5.2's static checks.
83316bf4 1419
4b1ec863
PE
1420 * fringe.c (update_window_fringes): Mark locals as initialized
1421 (Bug#8227).
1422 (destroy_fringe_bitmap, init_fringe_bitmap): Now static.
bf60f616 1423
524c7aa6
PE
1424 * alloc.c (mark_fringe_data): Move decl from here ...
1425 * lisp.h (mark_fringe_data) [HAVE_WINDOW_SYSTEM]: ... to here,
1426 to check its interface.
1427 (init_fringe_once): Do not declare unless HAVE_WINDOW_SYSTEM.
1428
a5c0af81 1429 * fontset.c (free_realized_fontset): Now static.
7519b8cd 1430 (Fset_fontset_font): Rename local to avoid shadowing.
cc6e5db1 1431 (fontset_font): Mark local as initialized.
a9a06e0b 1432 (FONTSET_SPEC, FONTSET_REPERTORY, RFONT_DEF_REPERTORY): Remove; unused.
a5c0af81 1433
b4716021
PE
1434 * xrdb.c: Include "xterm.h", to check x_load_resources's interface.
1435
811e9bac 1436 * xselect.c (x_disown_buffer_selections): Remove; not used.
7b83e2f1 1437 (TRACE3) [!defined TRACE_SELECTION]: Remove; not used.
aa0daa9f
PE
1438 (x_own_selection, Fx_disown_selection_internal): Rename locals
1439 to avoid shadowing.
1440 (x_handle_dnd_message): Remove local to avoid shadowing.
811e9bac 1441
7e3ab302
PE
1442 * lisp.h (GCPRO1_VAR, UNGCPRO_VAR): New macros,
1443 so that the caller can use some name other than gcpro1.
1444 (GCPRO1, UNGCPRO): Reimplement in terms of the new macros.
58d2d479
PE
1445 * xfns.c (Fx_create_frame, x_create_tip_frame, Fx_show_tip):
1446 (Fx_backspace_delete_keys_p):
1447 Use them to avoid shadowing, and rename vars to avoid shadowing.
1448 (x_decode_color, x_set_name, x_window): Now static.
6b437900 1449 (Fx_create_frame): Add braces to silence GCC warning.
c0951e53 1450 (Fx_file_dialog, Fx_select_font): Fix pointer signedness.
06b0c8a0
PE
1451 (x_real_positions, xg_set_icon_from_xpm_data, x_create_tip_frame):
1452 Remove unused locals.
7e3ab302
PE
1453 (Fx_create_frame, x_create_tip_frame, Fx_show_tip):
1454 (Fx_backspace_delete_keys_p): Rename locals to avoid shadowing.
1455 Some of these renamings use the new GCPRO1_VAR and UNGCPRO_VAR
1456 macros.
f78faa98 1457
e2b13473
PE
1458 * xterm.h (x_mouse_leave): New decl.
1459
77f23912
PE
1460 * xterm.c (x_copy_dpy_color, x_focus_on_frame, x_unfocus_frame):
1461 Remove unused functions.
cdf4ba58
PE
1462 (x_shift_glyphs_for_insert, XTflash, XTring_bell):
1463 (x_calc_absolute_position): Now static.
7411c686 1464 (XTread_socket): Don't define label "out" unless it's used.
2b07bcff 1465 Don't declare local "event" unless it's used.
ed7bf3a5
PE
1466 (x_iconify_frame, x_free_frame_resources): Don't declare locals
1467 unless they are used.
38d0b34a
PE
1468 (XEMBED_VERSION, xembed_set_info): Don't define unless needed.
1469 (x_fatal_error_signal): Remove; not used.
a6067996
PE
1470 (x_draw_image_foreground, redo_mouse_highlight, XTmouse_position):
1471 (x_scroll_bar_report_motion, handle_one_xevent, x_draw_bar_cursor):
1472 (x_error_catcher, x_connection_closed, x_error_handler):
1473 (x_error_quitter, xembed_send_message, x_iconify_frame):
1474 (my_log_handler): Rename locals to avoid shadowing.
28f1c698 1475 (x_delete_glyphs, x_ins_del_lines): Mark with NO_RETURN.
2a8fade0 1476 (x_connection_closed): Tell GCC not to suggest NO_RETURN.
77f23912 1477
44f230aa
SM
1478 * xfaces.c (clear_face_cache, Fx_list_fonts, Fface_font):
1479 Rename or move locals to avoid shadowing.
6b463e58 1480 (tty_defined_color, merge_face_heights): Now static.
5967d051 1481 (free_realized_faces_for_fontset): Remove; not used.
1e9966ea
PE
1482 (Fx_list_fonts): Mark variable that gcc -Wuninitialized
1483 does not deduce is never used uninitialized.
73719eba
PE
1484 (STRDUPA, LSTRDUPA, FONT_POINT_SIZE_QUANTUM): Remove; not used.
1485 (LFACEP): Define only if XASSERTS, as it's not needed otherwise.
071048a3 1486
426994c3 1487 * terminal.c (store_terminal_param): Now static.
5489860b 1488
032f1620 1489 * xmenu.c (menu_highlight_callback): Now static.
9d66f88e 1490 (set_frame_menubar): Remove unused local.
d4323972 1491 (xmenu_show): Rename parameter to avoid shadowing.
6d1f7fee
PE
1492 (xmenu_show, xdialog_show, xmenu_show): Make local pointers "const"
1493 since they might point to immutable storage.
281585b0
PE
1494 (next_menubar_widget_id): Declare only if USE_X_TOOLKIT,
1495 since it's unused otherwise.
032f1620 1496
367c19e5 1497 * xdisp.c (produce_glyphless_glyph): Initialize lower_xoff.
53df7c11 1498 Add a FIXME, since the code still doesn't look right. (Bug#8215)
9f36b9fd
PE
1499 (Fcurrent_bidi_paragraph_direction): Simplify slightly; this
1500 avoids a gcc -Wuninitialized diagnostic.
0e086e8f 1501 (display_line, BUILD_COMPOSITE_GLYPH_STRING, draw_glyphs):
44a3a108
PE
1502 (note_mouse_highlight): Mark variables that gcc -Wuninitialized
1503 does not deduce are never used uninitialized.
70739cbe 1504
07b48fa9
PE
1505 * lisp.h (IF_LINT): New macro, copied from ../lib-src/emacsclient.c.
1506
8868a238 1507 * xdisp.c (redisplay_window): Rename local to avoid shadowing.
4554d213
PE
1508 * window.c (window_loop, size_window):
1509 (run_window_configuration_change_hook, enlarge_window): Likewise.
8868a238 1510
7e5cf297 1511 * window.c (display_buffer): Now static.
d6550a9f
PE
1512 (size_window): Mark variables that gcc -Wuninitialized
1513 does not deduce are never used uninitialized.
a586633d
PE
1514 * window.h (check_all_windows): New decl, to forestall
1515 gcc -Wmissing-prototypes diagnostic.
5b555da1 1516 * dispextern.h (bidi_dump_cached_states): Likewise.
7e5cf297 1517
f6095868
PE
1518 * charset.h (CHECK_CHARSET_GET_CHARSET): Rename locals to avoid
1519 shadowing.
1520 * charset.c (map_charset_for_dump, Fchar_charset): Likewise.
726929c4
PE
1521 Include <limits.h>.
1522 (Fsort_charsets): Redo min/max calculation to shorten the code a bit
1523 and to avoid gcc -Wuninitialized warning.
89ef49df
PE
1524 (load_charset_map): Mark variables that gcc -Wuninitialized
1525 does not deduce are never used uninitialized.
53df7c11 1526 (load_charset): Abort instead of using uninitialized var (Bug#8229).
f6095868 1527
f38b440c
PE
1528 * coding.c (coding_set_source, coding_set_destination):
1529 Use "else { /* comment */ }" rather than "else /* comment */;"
1530 for clarity, and to avoid gcc -Wempty-body warning.
2735d060
PE
1531 (Fdefine_coding_system_internal): Don't redeclare 'i' inside
1532 a block, when the outer 'i' will do.
1533 (decode_coding_utf_8, decode_coding_utf_16, detect_coding_emacs_mule):
1534 (emacs_mule_char, decode_coding_emacs_mule, detect_coding_iso_2022):
1535 (decode_coding_iso_2022, decode_coding_sjis, decode_coding_big5):
1536 (decode_coding_raw_text, decode_coding_charset, get_translation_table):
1537 (Fdecode_sjis_char, Fdefine_coding_system_internal):
1538 Rename locals to avoid shadowing.
1539 * character.h (FETCH_STRING_CHAR_ADVANCE): Likewise.
e2f1bab9
PE
1540 * coding.c (emacs_mule_char, encode_invocation_designation):
1541 Now static, since they're not used elsewhere.
413bb2db 1542 (decode_coding_iso_2022): Add "default: abort ();" as a safety check.
c4a63b12 1543 (decode_coding_object, encode_coding_object, detect_coding_system):
ee05f961
PE
1544 (decode_coding_emacs_mule): Mark variables that gcc
1545 -Wuninitialized does not deduce are never used uninitialized.
160b01f6
PE
1546 (detect_coding_iso_2022): Initialize a local variable that might
1547 be used uninitialized. Leave a FIXME because it's not clear that
53df7c11 1548 this initialization is needed. (Bug#8211)
5f58e762
PE
1549 (ISO_CODE_LF, ISO_CODE_CR, CODING_ISO_FLAG_EUC_TW_SHIFT):
1550 (ONE_MORE_BYTE_NO_CHECK, UTF_BOM, UTF_16_INVALID_P):
1551 (SHIFT_OUT_OK, ENCODE_CONTROL_SEQUENCE_INTRODUCER):
1552 (ENCODE_DIRECTION_R2L, ENCODE_DIRECTION_L2R):
1553 Remove unused macros.
f38b440c 1554
232b38b9 1555 * category.c (hash_get_category_set): Remove unused local var.
9f3b5e69 1556 (copy_category_table): Now static, since it's not used elsewhere.
d0891610 1557 * character.c (string_count_byte8): Likewise.
232b38b9 1558
fb90da1b
PE
1559 * ccl.c (CCL_WRITE_STRING, CCL_ENCODE_CHAR, Fccl_execute_on_string):
1560 (Fregister_code_conversion_map): Rename locals to avoid shadowing.
1561
fb93dbc2
PE
1562 * chartab.c (copy_sub_char_table): Now static, since it's not used
1563 elsewhere.
5c156ace
PE
1564 (sub_char_table_ref_and_range, char_table_ref_and_range):
1565 Rename locals to avoid shadowing.
bbcd0949 1566 (ASET_RANGE, GET_SUB_CHAR_TABLE): Remove unused macros.
fb93dbc2 1567
7d3b3862 1568 * bidi.c (bidi_check_type): Now static, since it's not used elsewhere.
630d6892 1569 (BIDI_BOB): Remove unused macro.
7d3b3862 1570
6be7d3da
PE
1571 * cm.c (cmgoto): Mark variables that gcc -Wuninitialized does not
1572 deduce are never used uninitialized.
c2ed9c8b 1573 * term.c (encode_terminal_code): Likewise.
6be7d3da 1574
75f8807f 1575 * term.c (encode_terminal_code): Now static. Remove unused local.
72abad34 1576
50938595
PE
1577 * tparam.h: New file.
1578 * term.c, tparam.h: Include it.
1579 * deps.mk (term.o, tparam.o): Depend on tparam.h.
1580 * term.c (tputs, tgetent, tgetflag, tgetnum, tparam, tgetstr):
1581 Move these decls to tparam.h, and make them agree with what
1582 is actually in tparam.c. The previous trick of using incompatible
1583 decls in different modules does not conform to the C standard.
1584 All callers of tparam changed to use tparam's actual API.
1585 * tparam.c (tparam1, tparam, tgoto):
1586 Use const pointers where appropriate.
1587
fbceeba2
PE
1588 * cm.c (calccost, cmgoto): Use const pointers where appropriate.
1589 * cm.h (struct cm): Likewise.
1590 * dispextern.h (do_line_insertion_deletion_costs): Likewise.
1591 * scroll.c (ins_del_costs, do_line_insertion_deletion_costs): Likewise.
1592 * term.c (tty_ins_del_lines, calculate_costs, struct fkey_table):
1593 (term_get_fkeys_1, append_glyphless_glyph, produce_glyphless_glyph):
1594 (turn_on_face, init_tty): Likewise.
1595 * termchar.h (struct tty_display_info): Likewise.
fbceeba2 1596
7f3f1250
PE
1597 * term.c (term_mouse_position): Rename local to avoid shadowing.
1598
e6ca6543
PE
1599 * alloc.c (mark_ttys): Move decl from here ...
1600 * lisp.h (mark_ttys): ... to here, so that it's checked against defn.
1601
c40f8d15
AS
16022011-03-11 Andreas Schwab <schwab@linux-m68k.org>
1603
1604 * .gdbinit (pwinx, xbuffer): Fix access to buffer name.
1605
cfe0661d
JB
16062011-03-09 Juanma Barranquero <lekktu@gmail.com>
1607
1608 * search.c (compile_pattern_1): Remove argument regp, unused since
1609 revid:rms@gnu.org-19941211082627-3x1g1wyqkjmwloig.
1610 (compile_pattern): Don't pass it.
1611
0afb4571
J
16122011-03-08 Jan Djärv <jan.h.d@swipnet.se>
1613
1614 * xterm.h (DEFAULT_GDK_DISPLAY): New define.
1615 (GDK_WINDOW_XID, gtk_widget_get_preferred_size): New defines
1616 for ! HAVE_GTK3.
1617 (GTK_WIDGET_TO_X_WIN): Use GDK_WINDOW_XID.
1618
1619 * xmenu.c (menu_position_func): Call gtk_widget_get_preferred_size.
1620
1621 * gtkutil.c: Include gtkx.h if HAVE_GTK3. If ! HAVE_GTK3, define
1622 gdk_window_get_screen, gdk_window_get_geometry,
1623 gdk_x11_window_lookup_for_display and GDK_KEY_g.
1624 (xg_set_screen): Use DEFAULT_GDK_DISPLAY.
1625 (xg_get_pixbuf_from_pixmap): New function.
1626 (xg_get_pixbuf_from_pix_and_mask): Change parameters from GdkPixmap
1627 to Pixmap, take frame as parameter, remove GdkColormap parameter.
1628 Call xg_get_pixbuf_from_pixmap instead of
1629 gdk_pixbuf_get_from_drawable.
1630 (xg_get_image_for_pixmap): Do not make GdkPixmaps, call
1631 xg_get_pixbuf_from_pix_and_mask with Pixmap parameters instead.
1632 (xg_check_special_colors): Use GtkStyleContext and its functions
1633 for HAVE_GTK3.
1634 (xg_prepare_tooltip, xg_hide_tooltip): Call gdk_window_get_screen.
1635 (xg_prepare_tooltip, create_dialog, menubar_map_cb)
1636 (xg_update_frame_menubar, xg_tool_bar_detach_callback)
44f230aa
SM
1637 (xg_tool_bar_attach_callback, xg_update_tool_bar_sizes):
1638 Call gtk_widget_get_preferred_size.
0afb4571
J
1639 (xg_frame_resized): gdk_window_get_geometry only takes 5
1640 parameters.
44f230aa
SM
1641 (xg_win_to_widget, xg_event_is_for_menubar):
1642 Call gdk_x11_window_lookup_for_display.
0afb4571
J
1643 (xg_set_widget_bg): New function.
1644 (delete_cb): New function.
1645 (xg_create_frame_widgets): connect delete-event to delete_cb.
1646 Call xg_set_widget_bg. Only set backgrund pixmap for ! HAVE_GTK3
1647 (xg_set_background_color): Call xg_set_widget_bg.
1648 (xg_set_frame_icon): Call xg_get_pixbuf_from_pix_and_mask.
1649 (xg_create_scroll_bar): vadj is a GtkAdjustment for HAVE_GTK3.
1650 Only call gtk_range_set_update_policy if ! HAVE_GTK3.
1651 (xg_make_tool_item): Only connect xg_tool_bar_item_expose_callback
1652 if ! HAVE_GTK3.
1653 (update_frame_tool_bar): Call gtk_widget_hide.
1654 (xg_initialize): Use GDK_KEY_g.
1655
1656 * xsmfns.c (gdk_set_sm_client_id): Define to gdk_set_sm_client_id
1657 if ! HAVE_GTK3
1658 (x_session_initialize): Call gdk_x11_set_sm_client_id.
1659
1660 * xterm.c (XFillRectangle): Use cairo routines for HAVE_GTK3.
1661 (x_term_init): Disable Xinput(2) with GDK_CORE_DEVICE_EVENTS.
1662 Load ~/emacs.d/gtkrc only for ! HAVE_GTK3.
1663
1c2cc4ef
JB
16642011-03-08 Juanma Barranquero <lekktu@gmail.com>
1665
1666 * w32xfns.c (select_palette): Check success of RealizePalette against
1667 GDI_ERROR, not zero.
1668
33383987 1669See ChangeLog.11 for earlier changes.
aac0c6e3
MR
1670
1671;; Local Variables:
1672;; coding: utf-8
aac0c6e3
MR
1673;; End:
1674
33383987 1675 Copyright (C) 2011 Free Software Foundation, Inc.
aac0c6e3
MR
1676
1677 This file is part of GNU Emacs.
1678
1679 GNU Emacs is free software: you can redistribute it and/or modify
1680 it under the terms of the GNU General Public License as published by
1681 the Free Software Foundation, either version 3 of the License, or
1682 (at your option) any later version.
1683
1684 GNU Emacs is distributed in the hope that it will be useful,
1685 but WITHOUT ANY WARRANTY; without even the implied warranty of
1686 MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
1687 GNU General Public License for more details.
1688
1689 You should have received a copy of the GNU General Public License
1690 along with GNU Emacs. If not, see <http://www.gnu.org/licenses/>.