*print.c (Fexternal_debugging_output): Use more-conservative overflow fix.
[bpt/emacs.git] / src / ChangeLog
CommitLineData
6efdadfd 12011-10-24 Paul Eggert <eggert@cs.ucla.edu>
3164aeac 2
682432fc 3 Fix integer width and related bugs.
eb106a49 4 * alloc.c (pure_bytes_used_lisp, pure_bytes_used_non_lisp):
d311d28c
PE
5 (allocate_vectorlike, buffer_memory_full, struct sdata, SDATA_SIZE)
6 (string_bytes, check_sblock, allocate_string_data):
7 (compact_small_strings, Fmake_bool_vector, make_string)
8 (make_unibyte_string, make_multibyte_string)
9 (make_string_from_bytes, make_specified_string)
10 (allocate_vectorlike, Fmake_vector, find_string_data_in_pure)
11 (make_pure_string, make_pure_c_string, make_pure_vector, Fpurecopy)
12 (mark_vectorlike):
13 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
14 (allocate_pseudovector):
15 Use int, not EMACS_INT, where int is wide enough.
16 (inhibit_garbage_collection, Fgarbage_collect):
17 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
18 * bidi.c (bidi_mirror_char): Use EMACS_INT, not int, where
19 int might not be wide enough.
20 (bidi_cache_search, bidi_cache_find, bidi_init_it)
21 (bidi_count_bytes, bidi_char_at_pos, bidi_fetch_char)
22 (bidi_at_paragraph_end, bidi_find_paragraph_start)
23 (bidi_paragraph_init, bidi_resolve_explicit, bidi_resolve_weak)
24 (bidi_level_of_next_char, bidi_move_to_visually_next):
25 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
26 * buffer.c (copy_overlays, Fgenerate_new_buffer_name)
27 (Fkill_buffer, Fset_buffer_major_mode)
28 (advance_to_char_boundary, Fbuffer_swap_text)
29 (Fset_buffer_multibyte, overlays_at, overlays_in)
30 (overlay_touches_p, struct sortvec, record_overlay_string)
31 (overlay_strings, recenter_overlay_lists)
32 (adjust_overlays_for_insert, adjust_overlays_for_delete)
33 (fix_start_end_in_overlays, fix_overlays_before, modify_overlay)
34 (Fmove_overlay, Fnext_overlay_change, Fprevious_overlay_change)
35 (Foverlay_recenter, last_overlay_modification_hooks_used)
36 (report_overlay_modification, evaporate_overlays, enlarge_buffer_text):
37 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
977b0e45
PE
38 (validate_region): Omit unnecessary test for b <= e,
39 since that's guaranteed by the previous test.
d311d28c
PE
40 (adjust_overlays_for_delete): Avoid pos + length overflow.
41 (Fmove_overlay, Fdelete_overlay, add_overlay_mod_hooklist)
42 (report_overlay_modification):
43 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
44 (Foverlays_at, Fnext_overlay_change, Fprevious_overlay_change):
45 Omit pointer cast, which isn't needed anyway, and doesn't work
46 after the EMACS_INT -> ptrdiff_t change.
79cce3f2
PE
47 (Fmove_overlay): Delete an evaporating overlay
48 if it becomes empty after its bounds are adjusted to fit within
49 its buffer. Without this fix, in a nonempty buffer (let ((o
50 (make-overlay 1 2))) (overlay-put o 'evaporate t) (move-overlay o 0 1))
51 yields an empty overlay that has the evaporate property, which is
52 not supposed to happen. (Bug#9642)
d311d28c
PE
53 * buffer.h: Adjust decls to match defn changes elsewhere.
54 (struct buffer_text, struct buffer):
55 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
56 Use EMACS_INT, not int, where int might not be wide enough.
39b5db3b
PE
57 * bytecode.c (unmark_byte_stack, exec_byte_code): Use ptrdiff_t,
58 not int, to avoid needless 32-bit limit on 64-bit hosts.
59 (exec_byte_code): Use tighter memory-full test, one that checks
60 for alloca overflow. Don't compute the address of the object just
61 before an array, as that's not portable. Use EMACS_INT, not
62 ptrdiff_t or int, where ptrdiff_t or int might not be wide enough.
d311d28c
PE
63 * callint.c (Fcall_interactively):
64 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
65 * callproc.c (call_process_kill, Fcall_process):
66 Don't assume pid_t fits into an Emacs fixnum.
67 (call_process_cleanup, Fcall_process, child_setup):
68 Don't assume pid_t fits into int.
69 (call_process_cleanup, Fcall_process, delete_temp_file)
70 (Fcall_process_region):
71 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
72 (Fcall_process): Simplify handling of volatile integers.
73 Use int, not EMACS_INT, where int will do.
74 * casefiddle.c (casify_object, casify_region, operate_on_word)
75 (Fupcase_word, Fdowncase_word, Fcapitalize_word):
76 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
77 (casify_object): Avoid integer overflow when overallocating buffer.
78 * casetab.c (set_identity, shuffle): Prefer int to unsigned when
45c2afd6 79 either works. Use lint_assume to convince GCC 4.6.1 that it's OK.
d311d28c
PE
80 * category.c (Fchar_category_set): Don't assume fixnum fits in int.
81 * category.h (CATEGORYP): Don't assume arg is nonnegative.
82 * ccl.c (GET_CCL_INT): Remove; no longer needed, since the
83 integers are now checked earlier. All uses replaced with XINT.
84 (ccl_driver):
85 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
86 For CCL_MapSingle, check that content and value are in int range.
c801946a
PE
87 (ccl_driver, Fregister_code_conversion_map):
88 Check that Vcode_version_map_vector is a vector.
d311d28c
PE
89 (resolve_symbol_ccl_program): Check that vector header is in range.
90 Always copy the vector, so that we can check its contents reliably
91 now rather than having to recheck each instruction as it's being
92 executed. Check that vector words fit in 'int'.
93 (ccl_get_compiled_code, Fregister_ccl_program)
94 (Fregister_code_conversion_map): Use ptrdiff_t, not int, for
95 program indexes, to avoid needless 32-bit limit on 64-bit hosts.
96 (Fccl_execute, Fccl_execute_on_string): Check that initial reg
97 contents are in range.
98 (Fccl_execute_on_string): Check that status is in range.
99 * ccl.h (struct ccl_program.idx): Now ptrdiff_t, not int.
100 * character.c (char_resolve_modifier_mask, Fchar_resolve_modifiers):
101 Accept and return EMACS_INT, not int, because callers can pass values
102 out of 'int' range.
103 (c_string_width, strwidth, lisp_string_width, chars_in_text)
104 (multibyte_chars_in_text, parse_str_as_multibyte)
105 (str_as_multibyte, count_size_as_multibyte, str_to_multibyte)
106 (str_as_unibyte, str_to_unibyte, string_count_byte8)
107 (string_escape_byte8, Fget_byte):
108 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
109 (Funibyte_string): Use CHECK_CHARACTER, not CHECK_NATNUM, to
110 avoid mishandling large integers.
111 * character.h: Adjust decls to match defn changes elsewhere.
112 * charset.c (load_charset_map_from_file, find_charsets_in_text)
113 (Ffind_charset_region):
114 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
115 (load_charset_map_from_file): Redo idx calculation to avoid overflow.
116 (load_charset_map_from_vector, Fdefine_charset_internal):
3c7649c1 117 Don't assume fixnum fits in int.
d311d28c
PE
118 (load_charset_map_from_vector, Fmap_charset_chars):
119 Remove now-unnecessary CHECK_NATNUMs.
120 (Fdefine_charset_internal): Check ranges here, more carefully.
3c7649c1
PE
121 Don't rely on undefined behavior with signed left shift overflow.
122 Don't assume unsigned int fits into fixnum, or that fixnum fits
123 into unsigned int. Don't require max_code to be a valid fixnum;
124 that's not true for gb10830 4-byte on a 32-bit host. Allow
125 invalid_code to be a cons, for the same reason. Require code_offset
126 to be a character. Avoid int overflow if max_char is close
127 to INT_MAX.
128 (CODE_POINT_TO_INDEX): On 32-bit hosts, return int, not unsigned;
129 this is intended anyway and avoids some undefined behavior.
130 (load_charset_map): Pass unsigned, not int, as 2nd arg of
131 INDEX_TO_CODE_POINT, as that's what it expects.
132 (Funify_charset, encode_char): Don't stuff unsigned vals into int vars.
60ad3eab
PE
133 * charset.h (DECODE_CHAR): Return int, not unsigned;
134 this is what was intended anyway, and it avoids undefined behavior.
135 (CHARSET_OFFSET): Remove unused macro, instead of fixing its
136 integer-overflow issues.
137 (ENCODE_CHAR): Return unsigned on all hosts, not just on 32-bit hosts.
138 Formerly, it returned EMACS_INT on 64-bit hosts in the common case
139 where the argument is EMACS_INT, and this behavior is not intended.
d311d28c
PE
140 * chartab.c (Fmake_char_table, Fset_char_table_range)
141 (uniprop_get_decoder, uniprop_get_encoder):
142 Don't assume fixnum fits in int.
143 * cmds.c (move_point): New function, that does the gist of
144 Fforward_char and Fbackward_char, but does so while checking
145 for integer overflow more accurately.
c96e5d6a 146 (Fforward_char, Fbackward_char): Use it.
d311d28c
PE
147 (Fforward_line, Fend_of_line, internal_self_insert)
148 (internal_self_insert):
149 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
150 Fix a FIXME, by checking for integer overflow when calculating
151 target_clm and actual_clm.
152 * coding.c (detect_coding_XXX, encode_coding_XXX, CODING_DECODE_CHAR)
153 (ASSURE_DESTINATION, coding_alloc_by_realloc)
154 (coding_alloc_by_making_gap, alloc_destination)
155 (detect_coding_utf_8, encode_coding_utf_8, decode_coding_utf_16)
156 (encode_coding_utf_16, detect_coding_emacs_mule)
157 (decode_coding_emacs_mule, encode_coding_emacs_mule)
158 (detect_coding_iso_2022, decode_coding_iso_2022)
159 (encode_invocation_designation, encode_designation_at_bol)
160 (encode_coding_iso_2022, detect_coding_sjis, detect_coding_big5)
161 (decode_coding_sjis, decode_coding_big5, encode_coding_sjis)
162 (encode_coding_big5, detect_coding_ccl, decode_coding_ccl)
163 (encode_coding_ccl, encode_coding_raw_text)
164 (detect_coding_charset, decode_coding_charset)
165 (encode_coding_charset, detect_eol, decode_eol, produce_chars)
166 (produce_composition, produce_charset, produce_annotation)
167 (decode_coding, handle_composition_annotation)
168 (handle_charset_annotation, consume_chars, decode_coding_gap)
169 (decode_coding_object, encode_coding_object, detect_coding_system)
170 (Ffind_coding_systems_region_internal, Fcheck_coding_systems_region)
171 (code_convert_region, code_convert_string)
172 (Fdefine_coding_system_internal):
173 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
174 (setup_iso_safe_charsets, consume_chars, Funencodable_char_position)
175 (Fdefine_coding_system_internal):
176 Don't assume fixnums fit in int.
177 (decode_coding_gap, decode_coding_object, encode_coding_object)
5895d7b9 178 (Fread_coding_system, Fdetect_coding_region)
2c6a9faa
PE
179 (Funencodable_char_position, Fcheck_coding_systems_region)
180 (get_translation, handle_composition_annotation, consume_chars):
d311d28c 181 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
977b0e45 182 (consume_chars): Rewrite to not calculate an address outside buffer.
d311d28c 183 (Ffind_operation_coding_system): NATNUMP can eval its arg twice.
7b09a37a 184 Don't access memory outside of the args array.
d311d28c 185 (Fdefine_coding_system_internal): Check for charset-id overflow.
47664caa
PE
186 (ENCODE_ISO_CHARACTER): Use unsigned, not int, to store the unsigned
187 result of ENCODE_CHAR.
d311d28c
PE
188 * coding.h: Adjust decls to match defn changes elsewhere.
189 (struct coding_system):
190 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
191 * composite.c (get_composition_id, find_composition)
192 (run_composition_function, update_compositions)
193 (compose_text, composition_gstring_put_cache)
194 (composition_gstring_p, composition_gstring_width)
195 (fill_gstring_header, fill_gstring_body, autocmp_chars)
196 (composition_compute_stop_pos, composition_reseat_it)
197 (composition_update_it, struct position_record)
198 (find_automatic_composition, composition_adjust_point)
199 (Fcomposition_get_gstring, Ffind_composition_internal):
200 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
201 (update_compositions):
202 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
203 * composite.h: Adjust decls to match defn changes elsewhere.
204 (struct composition):
205 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
206 * data.c (let_shadows_buffer_binding_p, let_shadows_global_binding_p):
207 Do not attempt to compute the address of the object just before a
208 buffer; this is not portable.
209 (Faref, Faset):
210 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
211 (Faset): Use int, not EMACS_INT, where int is wide enough.
212 (Fstring_to_number): Don't assume fixnums fit in int.
213 (Frem): Don't assume arg is nonnegative.
214 * dbusbind.c (xd_append_arg): Check for integers out of range.
215 (Fdbus_call_method): Don't overflow the timeout int.
216 * dired.c (directory_files_internal, file_name_completion, scmp)
217 (file_name_completion_stat):
218 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
219 (file_name_completion): Don't overflow matchcount.
220 (file_name_completion_stat): Use SAFE_ALLOCA, not alloca.
221 * dispextern.h: Adjust decls to match defn changes elsewhere.
222 (struct text_pos, struct glyph, struct bidi_saved_info)
223 (struct bidi_string_data, struct bidi_it, struct composition_it)
224 (struct it):
225 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
226 (struct display_pos, struct composition_it, struct it):
227 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
228 * dispnew.c (increment_matrix_positions)
229 (increment_row_positions, mode_line_string)
230 (marginal_area_string):
231 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
54e1617f 232 (change_frame_size_1, Fredisplay, Fframe_or_buffer_changed_p):
d311d28c
PE
233 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
234 (duration_to_sec_usec): New function, to check for overflow better.
235 (Fsleep_for, sit_for): Use it.
236 * doc.c (get_doc_string, store_function_docstring):
237 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
238 (get_doc_string, Fsnarf_documentation):
239 Use int, not EMACS_INT, where int is wide enough.
240 (get_doc_string):
241 Use SAFE_ALLOCA, not alloca.
242 Check for overflow when converting EMACS_INT to off_t.
243 * doprnt.c (doprnt):
244 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
245 * editfns.c (init_editfns, Fuser_uid, Fuser_real_uid):
246 Don't assume uid_t fits into fixnum.
247 (buildmark, Fgoto_char, overlays_around, find_field, Fdelete_field)
248 (Ffield_string, Ffield_string_no_properties, Ffield_beginning)
249 (Ffield_end, Fconstrain_to_field, Fline_beginning_position)
250 (Fline_end_position, Fprevious_char, Fchar_after, Fchar_before)
251 (general_insert_function)
252 (Finsert_char, make_buffer_string, make_buffer_string_both)
253 (update_buffer_properties, Fbuffer_substring)
254 (Fbuffer_substring_no_properties, Fcompare_buffer_substrings)
255 (Fsubst_char_in_region, check_translation)
256 (Ftranslate_region_internal, save_restriction_restore, Fformat)
257 (transpose_markers, Ftranspose_regions):
258 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
259 (clip_to_bounds): Move to lisp.h as an inline function).
260 (Fconstrain_to_field): Don't assume integers are nonnegative.
261 (Fline_beginning_position, Fsave_excursion, Fsave_current_buffer):
262 (Fsubst_char_in_region, Fsave_restriction):
263 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
264 (Femacs_pid): Don't assume pid_t fits into fixnum.
265 (lo_time): Use int, not EMACS_INT, when int suffices.
266 (lisp_time_argument): Check for usec out of range.
267 (Fencode_time): Don't assume fixnum fits in int.
3f4eabd1
PE
268 (Fuser_login_name, Fuser_full_name): Signal an error
269 if a uid argument is out of range, rather than relying on
270 undefined behavior.
c8d5c857
PE
271 (Fformat_time_string): Remove now-unnecessary check.
272 lisp_time_argument checks for out-of-range usec now.
d311d28c
PE
273 * emacs.c (gdb_valbits, gdb_gctypebits): Now int, not EMACS_INT.
274 (gdb_data_seg_bits): Now uintptr_t, not EMACS_INT.
275 (PVEC_FLAG, gdb_array_mark_flag): Now ptrdiff_t, not EMACS_INT.
276 (init_cmdargs, Fdump_emacs):
277 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
278 (Fkill_emacs): Don't assume fixnum fits in int; instead, take just
279 the bottom (typically) 32 bits of the fixnum.
280 * eval.c (specpdl_size, call_debugger):
281 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
282 (when_entered_debugger, Fbacktrace_debug):
283 Don't assume fixnum can fit in int.
284 (Fdefvaralias, Fdefvar): Do not attempt to compute the address of
285 the object just before a buffer; this is not portable.
286 (FletX, Flet, Funwind_protect, do_autoload, Feval, funcall_lambda)
287 (grow_specpdl, unbind_to):
288 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
289 (Fapply, apply_lambda): Don't assume ptrdiff_t can hold fixnum.
290 (grow_specpdl): Simplify allocation by using xpalloc.
856bbc81 291 (Fprog1, Fprog2): Don't assume list length fits in int. Simplify.
d311d28c
PE
292 * fileio.c (Ffind_file_name_handler, Fcopy_file, Frename_file)
293 (Finsert_file_contents, Fwrite_region, Fdo_auto_save):
294 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
295 (Ffind_file_name_handler, non_regular_inserted, Finsert_file_contents)
296 (a_write, e_write):
297 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
298 (Fcopy_file, non_regular_nbytes, read_non_regular)
299 (Finsert_file_contents):
300 Use int, not EMACS_INT, where int is wide enough.
301 (READ_BUF_SIZE): Verify that it fits in int.
302 (Finsert_file_contents): Check that counts are in proper range,
303 rather than assuming fixnums fit into ptrdiff_t etc.
304 Don't assume fixnums fit into int.
125b3835 305 * floatfns.c (Fexpt): Avoid undefined signed * signed overflow.
5895d7b9
PE
306 * fns.c (Fcompare_strings, Fstring_lessp, struct textprop_rec, concat)
307 (string_char_byte_cache_charpos, string_char_byte_cache_bytepos)
d311d28c
PE
308 (string_char_to_byte, string_byte_to_char)
309 (string_make_multibyte, string_to_multibyte)
310 (string_make_unibyte, Fstring_as_unibyte, Fstring_as_multibyte)
311 (Fstring_to_unibyte, Fsubstring, Fsubstring_no_properties)
312 (substring_both, Fdelete, internal_equal, Ffillarray)
313 (Fclear_string, mapcar1)
314 (Fbase64_encode_region, Fbase64_encode_string, base64_encode_1)
315 (Fbase64_decode_region, Fbase64_decode_string, base64_decode_1)
316 (larger_vector, make_hash_table, maybe_resize_hash_table)
317 (hash_lookup, hash_remove_from_table, hash_clear, sweep_weak_table)
318 (Fmaphash, secure_hash):
319 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
320 (concat): Check for string index and length overflow.
321 (Fmapconcat): Don't assume fixnums fit into ptrdiff_t.
322 (Frequire):
323 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
324 (larger_vector): New API (vec, incr_min, size_max) replaces old
325 one (vec, new_size, init). This catches size overflow.
326 INIT was removed because it was always Qnil.
327 All callers changed.
328 (INDEX_SIZE_BOUND): New macro, which calculates more precisely
329 the upper bound on a hash table index size.
330 (make_hash_table, maybe_resize_hash_table): Use it.
331 (secure_hash): Computer start_byte and end_byte only after
332 they're known to be in ptrdiff_t range.
333 * font.c (font_intern_prop, font_at, font_range, Ffont_shape_gstring)
334 (Ffont_get_glyphs, Ffont_at):
335 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
336 (font_style_to_value, font_prop_validate_style, font_expand_wildcards)
337 (Flist_fonts, Fopen_font):
338 Don't assume fixnum can fit in int.
339 (check_gstring): Don't assume index can fit in int.
340 (font_match_p): Check that fixnum is a character, not a nonnegative
341 fixnum, since the later code needs to stuff it into an int.
342 (font_find_for_lface): Use SAFE_ALLOCA_LISP, not alloca.
343 (font_fill_lglyph_metrics): Use unsigned, not EMACS_INT, to avoid
344 conversion overflow issues.
345 (Fopen_font): Check for integer out of range.
346 (Ffont_get_glyphs): Don't assume index can fit in int.
347 * font.h: Adjust decls to match defn changes elsewhere.
348 * fontset.c (reorder_font_vector): Redo score calculation to avoid
349 integer overflow.
350 (num_auto_fontsets, fontset_from_font): Use ptrdiff_t, not
351 printmax_t, where ptrdiff_t is wide enough.
352 (Finternal_char_font):
353 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
354 * frame.c (Fset_mouse_position, Fset_mouse_pixel_position)
355 (Fset_frame_height, Fset_frame_width, Fset_frame_size)
356 (Fset_frame_position, x_set_frame_parameters)
357 (x_set_line_spacing, x_set_border_width)
358 (x_set_internal_border_width, x_set_alpha, x_figure_window_size):
359 Check that fixnums are in proper range for system types.
360 (frame_name_fnn_p, Fframe_parameter, Fmodify_frame_parameters):
361 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
362 (Fmodify_frame_parameters): Don't assume fixnum fits in int.
363 Use SAFE_ALLOCA_LISP, not alloca.
364 * frame.h (struct frame): Use intptr_t, not EMACS_INT, where
365 intptr_t is wide enough.
366 * fringe.c (lookup_fringe_bitmap, get_logical_fringe_bitmap)
367 (Fdefine_fringe_bitmap): Don't assume fixnum fits in int.
368 (Ffringe_bitmaps_at_pos): Don't assume index fits in int.
369 Check for fixnum out of range.
370 * ftfont.c (ftfont_list): Don't assume index fits in int.
371 Check that fixnums are in proper range for system types.
372 (ftfont_shape_by_flt):
373 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
d311d28c
PE
374 * gnutls.c (emacs_gnutls_write, emacs_gnutls_read):
375 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
376 (Fgnutls_error_fatalp, Fgnutls_error_string, Fgnutls_boot):
377 Check that fixnums are in proper range for system types.
378 * gnutls.h: Adjust decls to match defn changes elsewhere.
379 * gtkutil.c (xg_dialog_run):
380 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
381 (update_frame_tool_bar):
382 Check that fixnums are in proper range for system types.
383 * image.c (parse_image_spec): Redo count calculation to avoid overflow.
5895d7b9 384 (lookup_image): Check that fixnums are in range for system types.
d311d28c
PE
385 * indent.c (last_known_column, last_known_column_point):
386 (current_column_bol_cache):
387 (skip_invisible, current_column, check_display_width):
388 (check_display_width, scan_for_column, current_column_1)
389 (Findent_to, Fcurrent_indentation, position_indentation)
390 (indented_beyond_p, Fmove_to_column, compute_motion):
391 (Fcompute_motion, Fvertical_motion):
392 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
393 (last_known_column_modified): Use EMACS_INT, not int.
394 (check_display_width):
395 (Fcompute_motion):
396 Check that fixnums and floats are in proper range for system types.
397 (compute_motion): Don't assume index or fixnum fits in int.
398 (compute_motion, Fcompute_motion):
399 Use int, not EMACS_INT, when it is wide enough.
400 (vmotion): Omit local var start_hpos that is always 0; that way
401 we don't need to worry about overflow in expressions involving it.
402 * indent.h: Adjust decls to match defn changes elsewhere.
403 (struct position):
404 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
405 Use int, not EMACS_INT, where int is wide enough.
406 Remove unused members ovstring_chars_done and tab_offset;
407 all uses removed.
408 * insdel.c (move_gap, move_gap_both, gap_left, gap_right)
409 (adjust_markers_for_delete, adjust_markers_for_insert, adjust_point)
410 (adjust_markers_for_replace, make_gap_larger, make_gap_smaller)
411 (make_gap, copy_text, insert, insert_and_inherit)
412 (insert_before_markers, insert_before_markers_and_inherit)
413 (insert_1, count_combining_before, count_combining_after)
414 (insert_1_both, insert_from_string)
415 (insert_from_string_before_markers, insert_from_string_1)
416 (insert_from_gap, insert_from_buffer, insert_from_buffer_1)
417 (adjust_after_replace, adjust_after_insert, replace_range)
418 (replace_range_2, del_range, del_range_1, del_range_byte)
419 (del_range_both, del_range_2, modify_region)
420 (prepare_to_modify_buffer, signal_before_change)
421 (signal_after_change, Fcombine_after_change_execute):
422 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
423 * intervals.c (traverse_intervals, rotate_right, rotate_left)
424 (balance_an_interval, split_interval_right, split_interval_left)
425 (find_interval, next_interval, update_interval)
426 (adjust_intervals_for_insertion, delete_node, delete_interval)
427 (interval_deletion_adjustment, adjust_intervals_for_deletion)
428 (static_offset_intervals, offset_intervals)
429 (merge_interval_right, merge_interval_left, make_new_interval)
430 (graft_intervals_into_buffer, temp_set_point_both)
431 (temp_set_point, set_point, adjust_for_invis_intang)
432 (set_point_both, move_if_not_intangible, get_property_and_range)
433 (get_local_map, copy_intervals, copy_intervals_to_string)
434 (compare_string_intervals, set_intervals_multibyte_1):
435 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
436 * intervals.h: Adjust decls to match defn changes elsewhere.
437 (struct interval):
438 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
439 * keyboard.c (this_command_key_count, this_single_command_key_start)
440 (before_command_key_count, before_command_echo_length, echo_now)
441 (echo_length, recursive_edit_1, Frecursive_edit, Ftrack_mouse)
442 (command_loop_1, safe_run_hooks, read_char, timer_check_2)
443 (menu_item_eval_property, read_key_sequence, Fread_key_sequence)
444 (Fread_key_sequence_vector, Fexecute_extended_command, Fsuspend_emacs):
445 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
446 (last_non_minibuf_size, last_point_position, echo_truncate)
447 (command_loop_1, adjust_point_for_property, read_char, gen_help_event)
448 (make_lispy_position, make_lispy_event, parse_modifiers_uncached)
449 (parse_modifiers, modify_event_symbol, Fexecute_extended_command)
450 (stuff_buffered_input):
451 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
452 (last_auto_save, command_loop_1, read_char):
453 Use EMACS_INT, not int, to avoid integer overflow.
454 (record_char): Avoid overflow in total_keys computation.
455 (parse_modifiers_uncached): Redo index calculation to avoid overflow.
456 * keyboard.h: Adjust decls to match defn changes elsewhere.
457 * keymap.c (Fdefine_key, Fcurrent_active_maps, accessible_keymaps_1)
458 (Fkey_description, Fdescribe_vector, Flookup_key):
459 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
460 (click_position): New function, to check that positions are in range.
461 (Fcurrent_active_maps):
462 (describe_command):
463 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
464 (Faccessible_keymaps, Fkey_description):
465 (preferred_sequence_p):
466 Don't assume fixnum can fit into int.
467 (Fkey_description): Use SAFE_ALLOCA_LISP, not alloca.
468 Check for integer overflow in size calculations.
469 (Ftext_char_description): Use CHECK_CHARACTER, not CHECK_NUMBER, to
470 avoid mishandling large integers.
471 * lisp.h: Adjust decls to match defn changes elsewhere.
472 (ARRAY_MARK_FLAG, PSEUDOVECTOR_FLAG, struct Lisp_String)
473 (struct vectorlike_header, struct Lisp_Subr, struct Lisp_Hash_Table)
474 (struct Lisp_Marker):
475 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
476 (clip_to_bounds): Now an inline function, moved here from editfns.c.
d311d28c
PE
477 (GLYPH_CODE_P): Check for overflow in system types, subsuming the
478 need for GLYPH_CODE_CHAR_VALID_P and doing proper checking ourselves.
479 All callers changed.
480 (GLYPH_CODE_CHAR, GLYPH_CODE_FACE):
481 Assume the arg has valid form, since it always does.
482 (TYPE_RANGED_INTEGERP): Avoid bug when checking against a wide
483 unsigned integer system type.
484 (CHECK_RANGED_INTEGER, CHECK_TYPE_RANGED_INTEGER): New macros.
485 (struct catchtag, specpdl_size, SPECPDL_INDEX, USE_SAFE_ALLOCA):
486 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
487 (struct catchtag): Use EMACS_INT, not int, since it may be a fixnum.
488 (duration_to_sec_usec): New decl.
489 * lread.c (read_from_string_index, read_from_string_index_byte)
490 (read_from_string_limit, readchar, unreadchar, openp)
491 (read_internal_start, read1, oblookup):
492 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
493 (Fload, readevalloop, Feval_buffer, Feval_region):
494 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
495 (openp): Check for out-of-range argument to 'access'.
496 (read1): Use int, not EMACS_INT, where int is wide enough.
497 Don't assume fixnum fits into int.
6efdadfd 498 Fix off-by-one error that can read outside a buffer.
1ab7b8ac
PE
499 (read_filtered_event): Use duration_to_sec_usec
500 to do proper overflow checking on durations.
d311d28c
PE
501 * macros.c (Fstart_kbd_macro): Use xpalloc to check for overflow
502 in size calculation.
503 (Fexecute_kbd_macro):
504 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
505 * marker.c (cached_charpos, cached_bytepos, CONSIDER)
506 (byte_char_debug_check, buf_charpos_to_bytepos, verify_bytepos)
507 (buf_bytepos_to_charpos, Fset_marker, set_marker_restricted)
508 (set_marker_both, set_marker_restricted_both, marker_position)
509 (marker_byte_position, Fbuffer_has_markers_at):
510 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
511 (Fset_marker, set_marker_restricted): Don't assume fixnum fits in int.
512 * menu.c (ensure_menu_items): Renamed from grow_menu_items.
513 It now merely ensures that the menu is large enough, without
514 necessarily growing it, as this avoids some integer overflow issues.
515 All callers changed.
516 (keymap_panes, parse_single_submenu, Fx_popup_menu):
517 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
518 (parse_single_submenu, Fx_popup_menu): Don't assume fixnum fits in int.
519 Use SAFE_ALLOCA_LISP, not alloca.
520 (find_and_return_menu_selection): Avoid unnecessary casts of pointers
521 to EMACS_INT. Check that fixnums are in proper range for system types.
522 * minibuf.c (minibuf_prompt_width, string_to_object)
523 (Fminibuffer_contents, Fminibuffer_contents_no_properties)
524 (Fminibuffer_completion_contents, Ftry_completion, Fall_completions):
525 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
526 (get_minibuffer, read_minibuf_unwind):
527 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
528 (read_minibuf): Omit unnecessary arg BACKUP_N, which is always nil;
529 this simplifies overflow checking. All callers changed.
530 (read_minibuf, Fread_buffer, Ftry_completion, Fall_completions)
531 (Ftest_completion):
532 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
533 * nsfns.m (check_ns_display_info): Don't assume fixnum fits in long.
534 (x_set_menu_bar_lines, x_set_tool_bar_lines, Fx_create_frame):
535 Check that fixnums are in proper range for system types.
536 (Fx_create_frame, Fx_show_tip):
537 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
538 * nsfont.m (ns_findfonts, nsfont_list_family):
539 Don't assume fixnum fits in long.
540 * nsmenu.m (ns_update_menubar, ns_menu_show, ns_popup_dialog):
541 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
542 (ns_update_menubar): Use intptr_t, not EMACS_INT, when intptr_t is
543 wide enough.
17fdb222 544 * nsselect.m (ns_get_local_selection, clean_local_selection_data):
d311d28c
PE
545 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
546 * print.c (print_buffer_size, print_buffer_pos, print_buffer_pos_byte)
547 (PRINTDECLARE, PRINTPREPARE):
548 (strout, print_string):
549 (print, print_preprocess, print_check_string_charset_prop)
550 (print_object):
551 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
552 (PRINTDECLARE):
553 (temp_output_buffer_setup, Fprin1_to_string, print_object):
554 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
555 (PRINTPREPARE): Use int, not ptrdiff_t, where int is wide enough.
d311d28c 556 (printchar, strout): Use xpalloc to catch size calculation overflow.
0fd11aa5 557 (Fexternal_debugging_output): Don't overflow EMACS_INT->int conversion.
d311d28c
PE
558 (print_error_message): Use SAFE_ALLOCA, not alloca.
559 (print_object): Use int, not EMACS_INT, where int is wide enough.
560 * process.c (Fdelete_process): Don't assume pid fits into EMACS_INT.
561 (Fset_process_window_size, Fformat_network_address)
562 (get_lisp_to_sockaddr_size, set_socket_option, Fmake_network_process)
d44287d4 563 (sigchld_handler):
d311d28c 564 Check that fixnums are in proper range for system types.
d44287d4 565 (Fsignal_process): Simplify by avoiding a goto.
d83cf4cc
PE
566 Check for process-ids out of pid_t range rather than relying on
567 undefined behavior.
d311d28c
PE
568 (Fformat_network_address, read_process_output, send_process)
569 (Fprocess_send_region, status_notify):
570 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
571 (Fformat_network_address, Fmake_serial_process, Fmake_network_process)
572 (wait_reading_process_output, read_process_output, exec_sentinel):
573 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
574 (conv_lisp_to_sockaddr): Don't assume fixnums fit into int.
575 (Faccept_process_output): Use duration_to_sec_usec to do proper
576 overflow checking on durations.
b62b53e8
PE
577 * puresize.h (PURESIZE_RATIO): Shrink this to 8/6 on 32-bit hosts
578 configured --with-wide-int.
d311d28c
PE
579 * scroll.c (calculate_scrolling, calculate_direct_scrolling)
580 (line_ins_del): Use int, not EMACS_INT, where int is wide enough.
581 * search.c (looking_at_1, string_match_1):
582 (fast_string_match, fast_c_string_match_ignore_case)
583 (fast_string_match_ignore_case, fast_looking_at, scan_buffer)
584 (scan_newline, find_before_next_newline, search_command)
585 (trivial_regexp_p, search_buffer, simple_search, boyer_moore)
586 (set_search_regs, wordify):
587 (Freplace_match):
588 (Fmatch_data):
589 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
590 (string_match_1, search_buffer, set_search_regs):
591 (Fmatch_data):
592 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
593 (wordify): Check for overflow in size calculation.
594 (Freplace_match): Avoid potential buffer overflow in search_regs.start.
595 (Fset_match_data): Don't assume fixnum fits in ptrdiff_t.
596 Check that fixnums are in proper range for system types.
597 * sound.c (struct sound_device)
598 (wav_play, au_play, vox_write, alsa_period_size, alsa_write):
599 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
600 (Fplay_sound_internal):
601 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
602 * syntax.c (ST_COMMENT_STYLE, ST_STRING_STYLE):
603 In definitions, make it clearer that these values must be out of range
5895d7b9
PE
604 for the respective integer ranges. This fixes a bug with
605 ST_STRING_STYLE and non-ASCII characters.
d311d28c
PE
606 (struct lisp_parse_state, find_start_modiff)
607 (Finternal_describe_syntax_value, scan_lists, scan_sexps_forward):
608 (Fparse_partial_sexp):
609 Don't assume fixnums can fit in int.
610 (struct lisp_parse_state, find_start_pos, find_start_value)
611 (find_start_value_byte, find_start_begv)
612 (update_syntax_table, char_quoted, dec_bytepos)
613 (find_defun_start, prev_char_comend_first, back_comment):
614 (scan_words, skip_chars, skip_syntaxes, forw_comment, Fforward_comment)
615 (scan_lists, Fbackward_prefix_chars, scan_sexps_forward):
616 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
617 (Finternal_describe_syntax_value): Check that match_lisp is a
618 character, not an integer, since the code stuffs it into int.
619 (scan_words, scan_sexps_forward):
620 Check that fixnums are in proper range for system types.
621 (Fforward_word):
622 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
623 (scan_sexps_forward):
624 Use CHARACTERP, not INTEGERP, since the value must fit into int.
625 (Fparse_partial_sexp): Fix doc; element 8 is not ignored.
626 * syntax.h: Adjust decls to match defn changes elsewhere.
627 (struct gl_state_s):
628 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
629 * sysdep.c (wait_for_termination_1, wait_for_termination)
630 (interruptible_wait_for_termination, mkdir):
631 Don't assume pid_t fits in int; on 64-bit AIX pid_t is 64-bit.
632 (emacs_read, emacs_write):
633 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
634 (system_process_attributes): Don't assume uid_t, gid_t, and
635 double all fit in int or even EMACS_INT.
636 * term.c (set_tty_color_mode):
637 Check that fixnums are in proper range for system types.
638 * termhooks.h (struct input_event):
639 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
640 * textprop.c (validate_interval_range, interval_of)
641 (Fadd_text_properties, set_text_properties_1)
642 (Fremove_text_properties, Fremove_list_of_text_properties)
643 (Ftext_property_any, Ftext_property_not_all)
644 (copy_text_properties, text_property_list, extend_property_ranges)
645 (verify_interval_modification):
646 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
647 (Fnext_single_char_property_change)
648 (Fprevious_single_char_property_change):
649 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
5895d7b9
PE
650 (copy_text_properties):
651 Check for integer overflow in index calculation.
d311d28c
PE
652 * undo.c (last_boundary_position, record_point, record_insert)
653 (record_delete, record_marker_adjustment, record_change)
654 (record_property_change):
655 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
656 (truncate_undo_list, Fprimitive_undo): Don't assume fixnum fits in int.
657 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
658 * w32fns.c (Fx_create_frame, x_create_tip_frame, Fx_show_tip)
659 (Fx_hide_tip, Fx_file_dialog):
660 * w32menu.c (set_frame_menubar):
661 Use ptrdiff_t, not int, for consistency with rest of code.
662 * window.c (window_scroll_preserve_hpos, window_scroll_preserve_vpos)
663 (select_window, Fdelete_other_windows_internal)
664 (window_scroll_pixel_based, window_scroll_line_based)
665 (Frecenter, Fset_window_configuration):
666 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
667 (Fset_window_hscroll, run_window_configuration_change_hook)
668 (set_window_buffer, temp_output_buffer_show, scroll_command)
5895d7b9 669 (Fscroll_other_window, Frecenter):
d311d28c
PE
670 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
671 (Fwindow_line_height, window_scroll, Fscroll_left, Fscroll_right):
672 Don't assume fixnum fits in int.
673 (Fset_window_scroll_bars):
674 Check that fixnums are in proper range for system types.
675 * xdisp.c (help_echo_pos, pos_visible_p, string_pos_nchars_ahead)
676 (string_pos, c_string_pos, number_of_chars, init_iterator)
677 (in_ellipses_for_invisible_text_p, init_from_display_pos)
678 (compute_stop_pos, next_overlay_change, compute_display_string_pos)
679 (compute_display_string_end, handle_face_prop)
5895d7b9
PE
680 (face_before_or_after_it_pos, handle_invisible_prop)
681 (handle_display_prop, handle_display_spec, handle_single_display_spec)
d311d28c
PE
682 (display_prop_intangible_p, string_buffer_position_lim)
683 (string_buffer_position, handle_composition_prop, load_overlay_strings)
684 (get_overlay_strings_1, get_overlay_strings)
685 (iterate_out_of_display_property, forward_to_next_line_start)
686 (back_to_previous_visible_line_start, reseat, reseat_to_string)
687 (get_next_display_element, set_iterator_to_next)
688 (get_visually_first_element, compute_stop_pos_backwards)
689 (handle_stop_backwards, next_element_from_buffer)
690 (move_it_in_display_line_to, move_it_in_display_line)
691 (move_it_to, move_it_vertically_backward, move_it_by_lines)
692 (add_to_log, message_dolog, message_log_check_duplicate)
693 (message2, message2_nolog, message3, message3_nolog
694 (with_echo_area_buffer, display_echo_area_1, resize_mini_window_1)
695 (current_message_1, truncate_echo_area, truncate_message_1)
696 (set_message, set_message_1, store_mode_line_noprop)
697 (hscroll_window_tree, debug_delta, debug_delta_bytes, debug_end_vpos)
698 (text_outside_line_unchanged_p, check_point_in_composition)
699 (reconsider_clip_changes)
700 (redisplay_internal, set_cursor_from_row, try_scrolling)
701 (try_cursor_movement, set_vertical_scroll_bar, redisplay_window)
702 (redisplay_window, find_last_unchanged_at_beg_row)
703 (find_first_unchanged_at_end_row, row_containing_pos, try_window_id)
704 (trailing_whitespace_p, find_row_edges, display_line)
705 (RECORD_MAX_MIN_POS, Fcurrent_bidi_paragraph_direction)
706 (display_mode_element, store_mode_line_string)
707 (pint2str, pint2hrstr, decode_mode_spec)
708 (display_count_lines, display_string, draw_glyphs)
709 (x_produce_glyphs, x_insert_glyphs)
710 (rows_from_pos_range, mouse_face_from_buffer_pos)
711 (fast_find_string_pos, mouse_face_from_string_pos)
712 (note_mode_line_or_margin_highlight, note_mouse_highlight):
713 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
714 (safe_call, init_from_display_pos, handle_fontified_prop)
715 (handle_single_display_spec, load_overlay_strings)
716 (with_echo_area_buffer, setup_echo_area_for_printing)
717 (display_echo_area, echo_area_display)
718 (x_consider_frame_title, prepare_menu_bars, update_menu_bar)
719 (update_tool_bar, hscroll_window_tree, redisplay_internal)
5895d7b9
PE
720 (redisplay_window, dump_glyph_row, display_mode_line)
721 (Fformat_mode_line, decode_mode_spec, on_hot_spot_p):
43ad2e9a 722 (handle_display_spec, display_prop_string_p):
d311d28c
PE
723 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
724 (handle_single_display_spec, build_desired_tool_bar_string)
725 (redisplay_tool_bar, scroll_window_tree, Fdump_glyph_matrix)
726 (get_specified_cursor_type):
727 Check that fixnums are in proper range for system types.
728 (struct overlay_entry, resize_mini_window, Fdump_glyph_row)
729 (Flookup_image_map):
730 Don't assume fixnums fit in int.
731 (compare_overlay_entries):
732 Avoid mishandling comparisons due to subtraction overflow.
733 (load_overlay_strings): Use SAFE_NALLOCA, not alloca.
734 (last_escape_glyph_face_id, last_glyphless_glyph_face_id):
735 (handle_tool_bar_click):
736 Use int, not unsigned, since we prefer signed and the signedness
737 doesn't matter here.
738 (get_next_display_element, next_element_from_display_vector):
739 Use int, not EMACS_INT, when int is wide enough.
740 (start_hourglass): Use duration_to_sec_usec to do proper
741 overflow checking on durations.
742 * xfaces.c (Fbitmap_spec_p):
743 Check that fixnums are in proper range for system types.
744 (compare_fonts_by_sort_order):
745 Avoid mishandling comparisons due to subtraction overflow.
746 (Fx_family_fonts, realize_basic_faces):
747 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
748 (Fx_family_fonts):
749 Don't assume fixnum fits in int.
750 Use SAFE_ALLOCA_LISP, not alloca.
751 (merge_face_heights): Remove unnecessary cast to EMACS_INT.
752 (Finternal_make_lisp_face): Don't allocate more than MAX_FACE_ID.
753 (face_at_buffer_position, face_for_overlay_string)
754 (face_at_string_position):
755 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
756 (merge_faces): Use int, not EMACS_INT, where int is wide enough.
757 * xfns.c (x_set_menu_bar_lines, x_set_tool_bar_lines, x_icon_verify)
758 (Fx_show_tip):
759 Check that fixnums are in proper range for system types.
760 (Fx_create_frame, x_create_tip_frame, Fx_show_tip)
761 (Fx_hide_tip, Fx_file_dialog, Fx_select_font):
762 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
763 (Fx_change_window_property): Don't assume fixnums fit in int.
764 * xfont.c (xfont_chars_supported):
765 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
766 * xmenu.c (Fx_popup_dialog, set_frame_menubar)
767 (create_and_show_popup_menu, create_and_show_dialog, xmenu_show):
768 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
769 * xml.c (parse_region):
770 * xrdb.c (magic_file_p):
771 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
772 * xselect.c (TRACE1): Don't assume pid_t promotes to int.
773 (x_get_local_selection, x_reply_selection_request)
774 (x_handle_selection_request, wait_for_property_change):
775 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
776 (selection_data_to_lisp_data): Use short, not EMACS_INT, where
777 short is wide enough.
778 (x_send_client_event): Don't assume fixnum fits in int.
779 * xterm.c (x_x_to_emacs_modifiers):
780 Don't assume EMACS_INT overflows nicely into int.
781 (x_emacs_to_x_modifiers): Use EMACS_INT, not int, because values
782 may come from Lisp.
783 (handle_one_xevent): NATNUMP can eval its arg twice.
784 (x_connection_closed):
785 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
786 * xterm.h: Adjust decls to match defn changes elsewhere.
787 (struct scroll_bar): Use struct vectorlike_header
788 rather than rolling our own approximation.
789 (SCROLL_BAR_VEC_SIZE): Remove; not used.
790
7b5d6677
EZ
7912011-10-20 Eli Zaretskii <eliz@gnu.org>
792
793 * dispextern.h (struct bidi_it): New member next_en_type.
794
795 * bidi.c (bidi_line_init): Initialize the next_en_type member.
796 (bidi_resolve_explicit_1): When next_en_pos is valid for the
797 current character, check also for next_en_type being WEAK_EN.
798 (bidi_resolve_weak): Don't enter the expensive loop if the current
799 position is before next_en_pos. Record the bidi type of the first
800 non-ET, non-BN character we find, in addition to its position.
801 (bidi_level_of_next_char): Invalidate next_en_type when
802 next_en_pos is over-stepped.
803
7da0b018
PE
8042011-10-20 Paul Eggert <eggert@cs.ucla.edu>
805
806 Time zone name fixes for non-ASCII locales (Bug#641, Bug#9794)
807 * editfns.c: Rewrite current-time-zone so that it invokes
808 the equivalent of (format-time-string "%Z") to get the time zone name.
809 This fixes a bug when the time zone name contains characters that
810 need converting from the system time locale to Emacs internal format.
811 This fixes a shortcoming that I introduced in my 1999-10-19 patch:
812 that patch fixed format-time-string to do the conversion, but
813 I forgot to fix current-time-zone.
814 (format_time_string): New function, containing most of
815 what Fformat_time_string used to contain.
816 (Fformat_time_string): Rewrite in terms of format_time_string.
817 This doesn't change this function's behavior.
818 (current-time-zone): Rewrite to use format_time_string.
819 This fixes the bug reported by Michael Schierl in
820 <http://lists.gnu.org/archive/html/emacs-devel/2007-06/msg00334.html>.
821 Jason Rumney's 2007-06-07 change worked around this bug, but
822 didn't fix it.
823 * systime.h (tzname, timezone): Remove no-longer-used declarations.
824
8547b010
EZ
8252011-10-19 Eli Zaretskii <eliz@gnu.org>
826
827 * xdisp.c (start_display): If the character at POS is displayed
828 via a display vector, reset IT->current.dpvec_index to zero.
12b32963
EZ
829 (try_window_reusing_current_matrix): If a line ends in a display
830 vector or the next line starts in a display vector, continue
831 redrawing the window even though the character position of
832 start_row was reached.
8547b010
EZ
833 (Bug#9771, part 2)
834
4e948d15
CY
8352011-10-18 Chong Yidong <cyd@gnu.org>
836
837 * xdisp.c (get_next_display_element): Handle U+2010 and U+2011
838 with nobreak-char-display too.
839
4787455f
EZ
8402011-10-18 Eli Zaretskii <eliz@gnu.org>
841
842 Fix part 3 of bug#9771.
843 * bidi.c (bidi_line_init): Initialize next_en_pos to zero, not -1.
844 (bidi_resolve_neutral): Don't enter the expensive loop looking for
845 non-neutral characters if the current character is a paragraph
846 separator (a.k.a. Newline). This avoids running the same
847 expensive loop twice, once when we consume the preceding newline
848 and the other time when the line actually needs to be displayed.
849 Avoid the loop when we see neutrals on the base embedding level
850 following a character whose directionality is the same as the
851 paragraph's. This avoids running the expensive loop when a line
852 ends in a long sequence of neutrals, like control characters.
853 Add assertion against STRONG_AL type. Slightly rearrange code
854 that determines the type of a neutral given the first non-neutral
855 that follows it.
856 (bidi_level_of_next_char): Set next_en_pos to zero when
857 invalidating its info.
858
2c91f553
EZ
8592011-10-17 Eli Zaretskii <eliz@gnu.org>
860
861 * xdisp.c (push_display_prop): Determine whether to record string
862 or buffer position by IT->string, not by IT->method. Allow
863 GET_FROM_DISPLAY_VECTOR as IT->method on entry. (Bug#9771, part 4)
f2ff9e88
EZ
864 (move_it_vertically_backward): Don't look for character position
865 immediately after the newline when in a continuation line.
866 (Bug#9771, part 1)
2c91f553 867
c7b08b0d
MR
8682011-10-15 Martin Rudalics <rudalics@gmx.at>
869
870 * window.c (coordinates_in_window): Rewrite and delabelize
871 vertical border check. (Bug#5357) (Bug#9618)
872
6b02f655
SM
8732011-10-14 Stefan Monnier <monnier@iro.umontreal.ca>
874
875 * xterm.c (frame_highlight, frame_unhighlight): Ignore unexplained
876 errors in XSetWindowBorder (bug#9310).
877
81d40c92
DA
8782011-10-13 Dmitry Antipov <dmantipov@yandex.ru>
879
880 * editfns.c (Fset_time_zone_rule): Replace free with xfree to
881 avoid crash when xmalloc overrun checking is enabled.
882
d4172c3b
EZ
8832011-10-13 Eli Zaretskii <eliz@gnu.org>
884
885 * xdisp.c (Fcurrent_bidi_paragraph_direction): Initialize
886 itb.paragraph_dir to NEUTRAL_DIR. Fixes an occasional incorrect
887 cursor motion with <left> and <right> arrow keys.
888
889 * bidi.c (bidi_init_it): Don't initialize paragraph_dir here, as
890 some callers set that themselves.
891
b00eea75
EZ
8922011-10-12 Eli Zaretskii <eliz@gnu.org>
893
894 * xdisp.c (find_row_edges): Handle the case where ROW comes from a
895 display string and the previous row comes from the same string and
896 is empty. (Bug#9739) (Bug#9738)
897
8fe012c4
SM
8982011-10-12 Stefan Monnier <monnier@iro.umontreal.ca>
899
900 * doc.c (get_doc_string): Encode file name (bug#9735).
901
0074aef2
EZ
9022011-10-12 Eli Zaretskii <eliz@gnu.org>
903
79beb178
EZ
904 * bidi.c (bidi_level_of_next_char):
905 * xdisp.c (get_visually_first_element): Remove old incorrect
906 comments regarding the Unicode Line Separator character.
907
0074aef2
EZ
908 * bidi.c (bidi_init_it): Initialize paragraph_dir to NEUTRAL_DIR.
909
6e4b3fbe
DA
9102011-10-12 Dmitry Antipov <dmantipov@yandex.ru>
911
912 * alloc.c (Fgc_status): Do not access beyond zombies array
913 boundary if nzombies > MAX_ZOMBIES.
914 * alloc.c (dump_zombies): Add missing format specifier.
915
0324f3af
PE
9162011-10-12 Paul Eggert <eggert@cs.ucla.edu>
917
b5525cac
PE
918 * xdisp.c (set_cursor_from_row): Simplify conditionals,
919 to pacify GCC 4.6.1 x86-64 with -O2 -Wstrict-overflow.
920
0324f3af
PE
921 * lread.c (read_escape): Allow hex escapes as large as ?\xfffffff.
922 Some packages use them to denote characters with modifiers.
923
e9b5f888
AS
9242011-10-11 Andreas Schwab <schwab@linux-m68k.org>
925
926 * lisp.h (GCPRO1_VAR, GCPRO2_VAR, GCPRO3_VAR, GCPRO4_VAR)
927 (GCPRO5_VAR, GCPRO6_VAR, UNGCPRO_VAR): Add whitespace to avoid
928 matching a pp-number. Rename parameter var to var1.
929
127827c0
SM
9302011-10-11 Stefan Monnier <monnier@iro.umontreal.ca>
931
932 * minibuf.c (Finternal_complete_buffer): Fix last change (bug#9709).
933
c8fd3bd0
GM
9342011-10-08 Glenn Morris <rgm@gnu.org>
935
936 * callint.c (Fcall_interactively): Give a more explicit error for the
937 'c' case with a non-character input. (Bug#8479)
938
352ec8ff
EZ
9392011-10-08 Eli Zaretskii <eliz@gnu.org>
940
03669ccb
EZ
941 * xdisp.c (hscroll_window_tree): Support hscroll in right-to-left
942 lines.
7061c986
EZ
943 (set_cursor_from_row): Fix cursor positioning in mixed L2R+R2L
944 lines that are hscrolled on the left.
03669ccb 945
352ec8ff
EZ
946 * dispnew.c (buffer_posn_from_coords): Account for a possible
947 presence of header-line. (Bug#4426)
948
a66cfb1c
SM
9492011-10-07 Stefan Monnier <monnier@iro.umontreal.ca>
950
6b02f655
SM
951 * buffer.c (syms_of_buffer) <enable-multibyte-characters>:
952 Don't advertise functionality which we discourage or doesn't work.
a66cfb1c 953
7c5ee88e
PE
9542011-10-07 Paul Eggert <eggert@cs.ucla.edu>
955
956 * alloc.c (GC_LISP_OBJECT_ALIGNMENT): Use offsetof, not __alignof__
957 or sizeof. __alignof__ gives the wrong answer on Fedora x86-64
958 with GCC 4.6.1 when configured with CC='gcc -m32' --with-wide-int;
959 this makes Emacs dump core during garbage collection on rare
960 occasions. sizeof is obviously inferior to offsetof here, so
961 stick with offsetof.
962 (GC_POINTER_ALIGNMENT): New macro.
963 (mark_memory): Omit 3rd (offset) arg; caller changed.
964 Don't assume EMACS_INT alignment is the same as pointer alignment.
965
df1bbe5b
SM
9662011-10-03 Stefan Monnier <monnier@iro.umontreal.ca>
967
968 * keyboard.c (read_key_sequence_remapped): New var.
969 (read_key_sequence): Compute remapping in the right buffer.
970 (command_loop_1): Use read_key_sequence's remapping directly.
971
51553db6
SM
9722011-10-02 Stefan Monnier <monnier@iro.umontreal.ca>
973
32c1fffd
SM
974 * dired.c (file_name_completion): Don't expand file name.
975 (Ffile_name_completion, Ffile_name_all_completions): Expand file name
976 before checking file name handler.
977
51553db6
SM
978 * minibuf.c (Finternal_complete_buffer): Only show internal buffers if
979 they've been requested explicitly (bug#9591).
980
b6bd1599 9812011-10-01 Andreas Schwab <schwab@linux-m68k.org>
fa2ec41f
AS
982
983 * keymap.c (Fsingle_key_description): Use make_specified_string
984 instead of build_string to build string from push_key_description.
985 (Bug#5193)
986
f701dc2a
PE
9872011-09-30 Paul Eggert <eggert@cs.ucla.edu>
988
4222c55d
PE
989 * buffer.h (struct buffer): Use time_t, not int, for a time stamp.
990 This fixes a Y2038 bug on 64-bit hosts.
991 * buffer.c (reset_buffer):
992 * fileio.c (Fdo_auto_save, Fset_buffer_auto_saved)
993 (Fclear_buffer_auto_save_failure):
994 Use 0, not -1, to represent an unset failure time, since time_t
995 might not be signed.
996
f701dc2a
PE
997 Remove dependency on glibc malloc internals.
998 * alloc.c (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
999 Move back here from lisp.h, but with their new implementations.
1000 (XMALLOC_BASE_ALIGNMENT, COMMON_MULTIPLE, XMALLOC_HEADER_ALIGNMENT)
1001 (XMALLOC_OVERRUN_SIZE_SIZE): Move these new lisp.h macros here.
1002 * charset.c (charset_table_init): New static var.
1003 (syms_of_charset): Use it instead of xmalloc. This removes a
1004 dependency on glibc malloc internals. See Eli Zaretskii's comment in
1005 <http://lists.gnu.org/archive/html/emacs-devel/2011-09/msg00815.html>.
1006 * lisp.h (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
1007 Move back to alloc.c.
1008 (XMALLOC_BASE_ALIGNMENT, COMMON_MULTIPLE, XMALLOC_HEADER_ALIGNMENT)
1009 (XMALLOC_OVERRUN_SIZE_SIZE): Move to alloc.c.
1010
9ceebf39
JD
10112011-09-30 Jan Djärv <jan.h.d@swipnet.se>
1012
1013 * nsterm.m (windowDidResize): Call x_set_window_size only when
1014 ns_in_resize is true. Otherwise set pixelwidth/height and
1015 call change_frame_size (Bug#9628).
1016
cb993c58
PE
10172011-09-30 Paul Eggert <eggert@cs.ucla.edu>
1018
3930c88b
PE
1019 Port --enable-checking=all to Fedora 14 x86-64.
1020 * charset.c (syms_of_charset): Also account for glibc malloc's
1021 internal overhead when calculating the initial malloc maximum.
1022
cb993c58
PE
1023 Port --enable-checking=all to Fedora 14 x86.
1024 * alloc.c (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
1025 Move to lisp.h.
1026 (xmalloc_put_size, xmalloc_get_size, overrun_check_malloc)
1027 (overrun_check_realloc, overrun_check_free):
1028 Use XMALLOC_OVERRUN_SIZE_SIZE, not sizeof (size_t).
1029 That way, xmalloc returns a properly-aligned pointer even if
1030 XMALLOC_OVERRUN_CHECK is defined. The old debugging code happened
1031 to align OK on typical 64-bit hosts, but not on Fedora 14 x86.
1032 * charset.c (syms_of_charset): Take XMALLOC_OVERRUN_CHECK_OVERHEAD
1033 into account when calculating the initial malloc maximum.
1034 * lisp.h (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
1035 Move here from alloc.c, so that charset.c can use it too.
1036 Properly align; the old code wasn't right for common 32-bit hosts
1037 when configured with --enable-checking=all.
1038 (XMALLOC_BASE_ALIGNMENT, COMMON_MULTIPLE, XMALLOC_HEADER_ALIGNMENT)
1039 (XMALLOC_OVERRUN_SIZE_SIZE): New macros.
1040
31bed486
EZ
10412011-09-29 Eli Zaretskii <eliz@gnu.org>
1042
04c70788 1043 * sysdep.c (snprintf) [!EOVERFLOW]: If EOVERFLOW is not defined,
31bed486
EZ
1044 use EDOM.
1045
fbcaa2f3
EZ
10462011-09-28 Eli Zaretskii <eliz@gnu.org>
1047
1048 * xdisp.c (compute_display_string_end): If there's no display
1049 string at CHARPOS, return -1.
1050
1051 * bidi.c (bidi_fetch_char): When compute_display_string_end
1052 returns a negative value, treat the character as a normal
1053 character not covered by a display string. (Bug#9624)
1054
a239d4e9
JB
10552011-09-28 Juanma Barranquero <lekktu@gmail.com>
1056
1057 * lread.c (Fread_from_string): Fix typo in docstring.
1058
88652fd5
EZ
10592011-09-27 Eli Zaretskii <eliz@gnu.org>
1060
1061 * xdisp.c (handle_invisible_prop): If invisible text ends on a
1062 newline, reseat the iterator instead of bidi-iterating there one
1063 character at a time. (Bug#9610)
32c1fffd
SM
1064 (BUFFER_POS_REACHED_P, move_it_in_display_line_to): Bail when past
1065 TO_CHARPOS if the bidi iterator is at base embedding level.
88652fd5 1066
ed497dd4
AS
10672011-09-27 Andreas Schwab <schwab@linux-m68k.org>
1068
1069 * lread.c (readevalloop): Use correct code for NBSP.
1070 (read1): Likewise. (Bug#9608)
1071
b2bf61aa
MA
10722011-09-25 Michael Albinus <michael.albinus@gmx.de>
1073
1074 * dbusbind.c (Fdbus_register_signal): When service is not
1075 registered, use nil in Vdbus_registered_objects_table. (Bug#9581)
1076
32bbb17c
GM
10772011-09-25 Glenn Morris <rgm@gnu.org>
1078
1079 * buffer.c (truncate-lines): Doc fix.
1080
94e0933e
CY
10812011-09-24 Chong Yidong <cyd@stupidchicken.com>
1082
1083 * window.c (Fwindow_prev_buffers, Fset_window_prev_buffers)
1084 (Fset_window_next_buffers): Doc fix.
1085
cddde921
GM
10862011-09-24 Glenn Morris <rgm@gnu.org>
1087
1088 * minibuf.c (read_minibuf): Disable line truncation. (Bug#5715)
1089
1260aef1
PE
10902011-09-24 Paul Eggert <eggert@cs.ucla.edu>
1091
25b4bfa0
PE
1092 Fix minor problems found by static checking.
1093 * xdisp.c (string_from_display_spec): Don't assume vecsize fits in int.
1260aef1
PE
1094 * indent.c (Fvertical_motion): Fix == vs = typo.
1095
e3cbd34b
EZ
10962011-09-24 Eli Zaretskii <eliz@gnu.org>
1097
a66cfb1c
SM
1098 * dispnew.c (syms_of_display) <redisplay-dont-pause>:
1099 Default value is now t. Doc fix.
6bf7006f 1100
e3cbd34b 1101 * indent.c (Fvertical_motion): Compute and apply the overshoot
32c1fffd 1102 logic when moving up, not only when moving down. Fix the
e3cbd34b 1103 confusing name and values of the it_overshoot_expected variable;
32c1fffd 1104 logic changes accordingly. (Bug#9254) (Bug#9549)
e3cbd34b
EZ
1105
1106 * xdisp.c (pos_visible_p): Produce correct pixel coordinates when
1107 CHARPOS is covered by a display string which includes newlines.
1108 (move_it_vertically_backward): Avoid inflooping when START_CHARPOS
1109 is covered by a display string with embedded newlines.
1110
a3de0cbd
MA
11112011-09-24 Michael Albinus <michael.albinus@gmx.de>
1112
1113 * dbusbind.c (Fdbus_register_signal): Add match rule to
1114 Vdbus_registered_objects_table. (Bug#9581)
a66cfb1c
SM
1115 (Fdbus_register_method, Vdbus_registered_objects_table):
1116 Fix docstring.
a3de0cbd 1117
b260039d
JM
11182011-09-24 Jim Meyering <meyering@redhat.com>
1119
32c1fffd 1120 do not ignore write error for any output size
b260039d
JM
1121 The previous change was incomplete.
1122 While it makes emacs --batch detect the vast majority of stdout
1123 write failures, errors were still ignored whenever the output size is
1124 k * (BUFSIZ+1) - 4. E.g., on a system with BUFSIZ of 4096,
1125 $ emacs --batch --eval '(print (format "%4093d" 0))' > /dev/full \
1126 && echo FAIL: ignored write error
1127 FAIL: ignored write error
1128 $ emacs --batch --eval '(print (format "%20481d" 0))' > /dev/full \
1129 && echo FAIL: ignored write error
1130 FAIL: ignored write error
1131 * emacs.c (Fkill_emacs): Also test ferror. (Bug#9574)
1132
8eca8a7c
AS
11332011-09-23 Andreas Schwab <schwab@linux-m68k.org>
1134
1135 * emacs.c (Fkill_emacs): In noninteractive mode exit
1136 non-successfully if a write error occurred on stdout. (Bug#9574)
1137
3341db62
EZ
11382011-09-21 Eli Zaretskii <eliz@gnu.org>
1139
1140 * xdisp.c (pop_it): Allow it->object that is a cons cell to pass
1141 the xassert test.
1142
1143 * dispextern.h (struct it): Update the comment documenting what
1144 can it->OBJECT be.
1145
8c203dbf
EZ
11462011-09-20 Eli Zaretskii <eliz@gnu.org>
1147
1148 * xdisp.c (set_cursor_from_row): If the row ends in a newline from
1149 a display string, extend search for cursor position to end of row.
1150 (find_row_edges): If the row ends in a newline from a display
1151 string, increment its MATRIX_ROW_END_CHARPOS by one. (Bug#9549)
1152 Handle the case of a display string with multiple newlines.
fd317ddf
EZ
1153 (Fcurrent_bidi_paragraph_direction): Fix search for previous
1154 non-empty line. Fixes confusing cursor motion with arrow keys at
1155 the beginning of a line that starts with whitespace.
8c203dbf 1156
a4824228
LMI
11572011-09-19 Lars Magne Ingebrigtsen <larsi@gnus.org>
1158
1159 * lread.c (Fread_from_string): Document what FINAL-STRING-INDEX is
1160 (bug#9493).
1161
33ed493b
CY
11622011-09-18 Chong Yidong <cyd@stupidchicken.com>
1163
1164 * xfns.c (Fx_create_frame): Handle the bitmapIcon resource as
1165 boolean (Bug#9154).
1166
56cd55c8
EZ
11672011-09-18 Eli Zaretskii <eliz@gnu.org>
1168
1169 * xdisp.c (display_line): Record maximum and minimum buffer
1170 positions even if no glyphs were produced (e.g., by a zero-width
1171 stretch). Fixes bug#9530 on a TTY. Under word-wrap, don't record
1172 buffer positions that will be removed from the glyph row because
1173 they don't fit.
c02dcedf
EZ
1174 (produce_stretch_glyph): Fix a bug in :align-to on a TTY when the
1175 column is beyond frame width: don't subtract 1 "pixel" when
1176 computing width of the stretch.
3e62b7e0
EZ
1177 (reseat_at_next_visible_line_start): Undo the change made on
1178 2011-09-17 that saved paragraph information and restored it after
1179 the call to `reseat'. (Bug#9545)
56cd55c8 1180
5ed99d36 11812011-09-18 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
3390454c
YM
1182
1183 * xdisp.c (expose_window): Save original value of phys_cursor_on_p
1184 and turn window cursor on if cleared (Bug#9415).
1185
5ed99d36 11862011-09-18 Andreas Schwab <schwab@linux-m68k.org>
edb7b4dc
AS
1187
1188 * search.c (boyer_moore): Take unibyte characters from pattern
1189 literally. (Bug#9458)
1190
9bade7b2
EZ
11912011-09-18 Eli Zaretskii <eliz@gnu.org>
1192
1193 * xdisp.c (reseat_at_next_visible_line_start): Fix last change.
1194
e5e9d610
PE
11952011-09-18 Paul Eggert <eggert@cs.ucla.edu>
1196
87e4427a
PE
1197 Fix minor problem found by static checking.
1198 * xdisp.c (reseat_at_next_visible_line_start): Mark locals as
1199 initialized, to pacify gcc -Wuninitialized.
1200
e5e9d610
PE
1201 * fileio.c: Report proper errno when syscall falls.
1202 (Finsert_file_contents): Save and restore errno,
1203 so that report_file_error outputs the correct diagnostic.
1204 (Fwrite_region) [CLASH_DETECTION]: Likewise.
1205
a1674f0b
EZ
12062011-09-18 Eli Zaretskii <eliz@gnu.org>
1207
1208 * .gdbinit (pgx): Fix references to fields of `struct glyph'.
1209
fbfb6dd4
EZ
12102011-09-17 Eli Zaretskii <eliz@gnu.org>
1211
1212 * xdisp.c (produce_stretch_glyph): Another fix for changes made on
1213 2011-08-30T17:32:44Z!eliz@gnu.org. (Bug#9530)
1214
bb187662
EZ
12152011-09-17 Eli Zaretskii <eliz@gnu.org>
1216
1137e8b8 1217 * xdisp.c (reseat_at_next_visible_line_start): Keep information
6b02f655 1218 about the current paragraph and restore it after the call to reseat.
1137e8b8
EZ
1219
1220 * bidi.c (MAX_PARAGRAPH_SEARCH): New macro.
1221 (bidi_find_paragraph_start): Search back for paragraph beginning
1222 at most MAX_PARAGRAPH_SEARCH lines; if not found, return BEGV_BYTE.
1223 (bidi_move_to_visually_next): Only trigger paragraph-related
1224 computations when the last character is a newline or at EOB, not
1225 just any NEUTRAL_B. (Bug#9470)
1226
bb187662
EZ
1227 * xdisp.c (set_cursor_from_row): Don't invoke special treatment of
1228 truncated lines if point is covered by a display string. (Bug#9524)
1229
2e621251
PE
12302011-09-16 Paul Eggert <eggert@cs.ucla.edu>
1231
1232 * xselect.c: Relax test for outgoing X longs (Bug#9498).
1233 (cons_to_x_long): New function.
1234 (lisp_data_to_selection_data): Use it. Correct the test for
1235 short-versus-long data; it was negated. Break out of vector
1236 loop, for efficiency, when a long datum is discovered.
1237
91a15bc6
SM
12382011-09-16 Stefan Monnier <monnier@iro.umontreal.ca>
1239
1240 * eval.c (Fquote): Document its non-consing behavior (bug#9482).
1241
b41c3a35
EZ
12422011-09-16 Eli Zaretskii <eliz@gnu.org>
1243
1244 * image.c (tiff_handler): Work around a bug in MinGW GCC 3.x (see
1245 GCC PR/17406) by declaring this function with external scope.
1246
7812ba2d
PE
12472011-09-15 Paul Eggert <eggert@cs.ucla.edu>
1248
1249 * editfns.c (Fformat): Fix bug in text-property fix (Bug#9514).
1250 Don't mishandle (length (format "%%")) and (format "%4000s%%" "").
1251
cf7edc2a
AS
12522011-09-15 Andreas Schwab <schwab@linux-m68k.org>
1253
1254 * editfns.c (Fformat): Correctly handle text properties on "%%".
1255
bd01620e
EZ
12562011-09-15 Eli Zaretskii <eliz@gnu.org>
1257
1258 * xterm.c (x_draw_composite_glyph_string_foreground):
1259 * w32term.c (x_draw_composite_glyph_string_foreground):
1260 * term.c (encode_terminal_code):
1261 * composite.c (composition_update_it, get_composition_id):
1262 * xdisp.c (get_next_display_element)
1263 (fill_composite_glyph_string): Add comments about special meaning
1264 of TAB characters in a composition.
1265
a02719a3
PE
12662011-09-15 Paul Eggert <eggert@cs.ucla.edu>
1267
1268 * editfns.c (Fformat): Fix off-by-1 bug for "%%b" (Bug#9514).
4c122725
PE
1269 This occurs when processing a multibyte format.
1270 Problem reported by Wolfgang Jenker.
a02719a3 1271
72589a3c
JB
12722011-09-15 Johan Bockgård <bojohan@gnu.org>
1273
1274 * xdisp.c (try_cursor_movement): Only check for exact match if
1275 cursor hpos found by set_cursor_from_row is valid. (Bug#9495)
1276
1c14176c
PE
12772011-09-14 Paul Eggert <eggert@cs.ucla.edu>
1278
1279 Remove unused external symbols.
1280 * dispextern.h (calc_pixel_width_or_height): Remove decl.
1281 * xdisp.c (calc_pixel_width_or_height): Now static.
1282 * doprnt.c (exprintf) [! (HAVE_X_WINDOWS && USE_X_TOOLKIT)]: Remove.
1283 * indent.c (check_display_width):
1284 * w32term.c: Fix comment to match code.
1285 * xterm.c, xterm.h (x_catching_errors): Remove.
1286
d2eea5b5
PE
12872011-09-14 Paul Eggert <eggert@cs.ucla.edu>
1288
1289 * xselect.c: Use signed conversions more consistently (Bug#9498).
1290 (selection_data_to_lisp_data): Assume incoming selection data are
1291 signed integers, not unsigned. This is to be consistent with
1292 outgoing selection data, which was modified to use signed integers
1293 in as part of the fix to Bug#9196 in response to Jan D.'s comment
1294 in <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=9196#32> that X11
1295 expects long, not unsigned long.
1296
46888499
EZ
12972011-09-14 Eli Zaretskii <eliz@gnu.org>
1298
1299 * xdisp.c (try_window_reusing_current_matrix): Fix incorrect
1300 computation of loop end. Reported by Johan Bockgård
1301 <bojohan@gnu.org>.
1302
ef8ef9fb
CY
13032011-09-13 Chong Yidong <cyd@stupidchicken.com>
1304
1305 * frame.c (Fother_visible_frames_p): Function deleted.
1306
fa819fed
EZ
13072011-09-12 Eli Zaretskii <eliz@gnu.org>
1308
1309 * indent.c (compute_motion): Process display vector front to back
1310 rather than the other way around. (Bug#2496)
1311
2ba8e008
SM
13122011-09-12 Stefan Monnier <monnier@iro.umontreal.ca>
1313
1314 * fileio.c (Finsert_file_contents): Don't assume beg_offset is 0.
1315
20f53c69
CY
13162011-09-11 Chong Yidong <cyd@stupidchicken.com>
1317
1318 * minibuf.c (Fread_from_minibuffer): Doc fix.
1319
d562d7a4
EZ
13202011-09-11 Eli Zaretskii <eliz@gnu.org>
1321
1322 * xdisp.c (produce_stretch_glyph): Fix a typo made in changes from
1323 2011-08-30T17:32:44Z!eliz@gnu.org. (Bug#9475)
1324
1c4d7f3d
LMI
13252011-09-11 Lars Magne Ingebrigtsen <larsi@gnus.org>
1326
1327 * fileio.c (Fvisited_file_modtime): Document `(-1 65535)' as a
1328 value for non-existent files.
1329
b885bf36
EZ
13302011-09-11 Eli Zaretskii <eliz@gnu.org>
1331
1332 * fileio.c (Finsert_file_contents): If the file cannot be opened,
1333 set its "size" to -1. This will set the modtime_size field of
1334 the corresponding buffer to -1, which is what
1335 verify-visited-file-modtime expects for files that do not exist.
1336 (Bug#9139)
1337
6612f0bf
PE
13382011-09-11 Paul Eggert <eggert@cs.ucla.edu>
1339
1340 * keymap.h (KEY_DESCRIPTION_SIZE, push_key_description): Move decls
1341 here ...
1342 * lisp.h: ... from here. push_key_description is no longer
1343 defined in keyboard.c, so its declaration should not be in
1344 lisp.h's "Defined in keyboard.c" section, and KEY_DESCRIPTION_SIZE
1345 logically belongs with push_key_description.
1346
dfb3f755
PE
13472011-09-10 Paul Eggert <eggert@cs.ucla.edu>
1348
1349 * buffer.h: Include <sys/types.h> instead of <time.h>.
1350 Otherwise, off_t wasn't defined on FreeBSD 9.0-BETA2 i386.
1351 Problem reported by Herbert J. Skuhra.
1352
3134906c
LMI
13532011-09-10 Lars Magne Ingebrigtsen <larsi@gnus.org>
1354
1355 * xml.c (parse_region): Make the parsing work for
1356 non-comment-starting XML files again (bug#9144).
1357
8d903f4e
AS
13582011-09-10 Andreas Schwab <schwab@linux-m68k.org>
1359
1360 * image.c (gif_load): Fix calculation of bottom and right corner.
1361 (Bug#9468)
1362
80ad64f4
EZ
13632011-09-10 Eli Zaretskii <eliz@gnu.org>
1364
1365 * xdisp.c (MAX_DISP_SCAN): Decrease to 250. Prevents sluggish
1366 redisplay in small windows.
1367
208a048d
EZ
13682011-09-09 Eli Zaretskii <eliz@gnu.org>
1369
1370 * frame.c (x_report_frame_params): Cast to avoid compiler warnings.
1371
9b1c252e
MR
13722011-09-08 Martin Rudalics <rudalics@gmx.at>
1373
1374 * window.c (Fset_window_prev_buffers, Fset_window_next_buffers):
1375 Operate on live windows only.
1376
2949f33b
JB
13772011-09-08 Juanma Barranquero <lekktu@gmail.com>
1378
1379 * emacs.c (my_heap_start): #ifdef to avoid warnings when unused.
1380
e08dcafd
EZ
13812011-09-07 Eli Zaretskii <eliz@gnu.org>
1382
1383 * xdisp.c (move_it_in_display_line_to): Call RESTORE_IT on ppos_it
1384 only under bidi iteration.
1385
115b96bd
JD
13862011-09-07 Jan Djärv <jan.h.d@swipnet.se>
1387
1388 * gtkutil.c (xg_make_tool_item): Insert comment about eventbox.
1389
c8199d0f
PE
13902011-09-06 Paul Eggert <eggert@cs.ucla.edu>
1391
1392 isnan: Fix porting problem to Solaris 10 with bundled gcc.
1393 Without this fix, the command to link temacs failed due to an
1394 undefined symbol __builtin_isnan. This is because
1395 /usr/include/iso/math_c99.h #defines isnan(x) to
1396 __builtin_isnan(x), but the bundled gcc, which identifies itself
1397 as gcc 3.4.3 (csl-sol210-3_4-branch+sol_rpath), does not have
1398 a __builtin_isnan.
1399 * floatfns.c (isnan): #undef, and then #define to a clone of
1400 what's in data.c.
1401 (Fisnan): Always define, since it's always available now.
1402 (syms_of_floatfns): Always define isnan at the Lisp level.
1403
e39b275c 14042011-09-06 Paul Eggert <eggert@cs.ucla.edu>
1c262cae
PE
1405
1406 * Makefile.in (gl-stamp): move-if-change now in build-aux (Bug#9169).
1407
b2db44d9 14082011-09-06 Paul Eggert <eggert@cs.ucla.edu>
728f8f0a 1409
f4af5137 1410 * fileio.c: Fix bugs with large file offsets (Bug#9428).
728f8f0a
PE
1411 The previous code assumed that file offsets (off_t values) fit in
1412 EMACS_INT variables, which is not true on typical 32-bit hosts.
1413 The code messed up by falsely reporting buffer overflow in cases
1414 such as (insert-file-contents "big" nil 1 2) into an empty buffer
1415 when "big" contains more than 2**29 bytes, even though this
1416 inserts just one byte and does not overflow the buffer.
1417 (Finsert_file_contents): Store file offsets as off_t
1418 values, not as EMACS_INT values. Check for overflow when
1419 converting between EMACS_INT and off_t. When checking for
1420 buffer overflow or for overlap, take the offsets into account.
1421 Don't use EMACS_INT for small values where int suffices.
1422 When checking for overlap, fix a typo: ZV was used where
1423 ZV_BYTE was intended.
1424 (Fwrite_region): Don't assume off_t fits into 'long'.
1425 * buffer.h (struct buffer.modtime_size): Now off_t, not EMACS_INT.
1426
ecfc0a49
MA
14272011-09-05 Michael Albinus <michael.albinus@gmx.de>
1428
1429 * dbusbind.c (xd_signature_cat): Rename from signature_cat.
1430
6511acf2 14312011-09-04 Paul Eggert <eggert@cs.ucla.edu>
61bfeeb7 1432
0999621a 1433 sprintf-related integer and memory overflow issues (Bug#9412).
62f19c19
PE
1434
1435 * doprnt.c (doprnt): Support printing ptrdiff_t and intmax_t values.
8666506e 1436 (esprintf, exprintf, evxprintf): New functions.
62f19c19 1437 * keyboard.c (command_loop_level): Now EMACS_INT, not int.
6b02f655 1438 (cmd_error): Kbd macro iterations count is now EMACS_INT, not int.
62f19c19
PE
1439 (modify_event_symbol): Do not assume that the length of
1440 name_alist_or_stem is safe to alloca and fits in int.
1441 (Fexecute_extended_command): Likewise for function name and binding.
1442 (Frecursion_depth): Wrap around reliably on integer overflow.
1443 * keymap.c (push_key_description): First arg is now EMACS_INT, not int,
1444 since some callers pass EMACS_INT values.
1445 (Fsingle_key_description): Don't crash if symbol name contains more
1446 than MAX_ALLOCA bytes.
1447 * minibuf.c (minibuf_level): Now EMACS_INT, not int.
1448 (get_minibuffer): Arg is now EMACS_INT, not int.
1449 * lisp.h (get_minibuffer, push_key_description): Reflect API changes.
8666506e 1450 (esprintf, exprintf, evxprintf): New decls.
62f19c19
PE
1451 * window.h (command_loop_level, minibuf_level): Reflect API changes.
1452
2be7d702
PE
1453 * dbusbind.c (signature_cat): New function.
1454 (xd_signature, Fdbus_register_signal):
2ea16b89
PE
1455 Do not overrun buffer; instead, report string overflow.
1456
9d1df220
PE
1457 * dispnew.c (add_window_display_history): Don't overrun buffer.
1458 Truncate instead; this is OK since it's just a log.
1459
33ef5c64
PE
1460 * editfns.c (Fcurrent_time_zone): Don't overrun buffer
1461 even if the time zone offset is outlandishly large.
1462 Don't mishandle offset == INT_MIN.
1463
66c6fdd5
PE
1464 * emacs.c (main) [NS_IMPL_COCOA]: Don't overrun buffer
1465 when creating daemon; the previous buffer-overflow check was incorrect.
1466
d749b01b
PE
1467 * eval.c (verror): Simplify by rewriting in terms of evxprintf,
1468 which has the guts of the old verror function.
1469
b5cd1905
PE
1470 * filelock.c (lock_file_1, lock_file): Don't blindly alloca long name;
1471 use SAFE_ALLOCA instead. Use esprintf to avoid int-overflow issues.
1472
6e1a67fb
PE
1473 * font.c: Include <float.h>, for DBL_MAX_10_EXP.
1474 (font_unparse_xlfd): Don't blindly alloca long strings.
c21721cc 1475 Don't assume XINT result fits in int, or that XFLOAT_DATA * 10
8666506e 1476 fits in int, when using sprintf. Use single snprintf to count
c21721cc
PE
1477 length of string rather than counting it via multiple sprintfs;
1478 that's simpler and more reliable.
c21721cc
PE
1479 (font_unparse_fcname): Use it to avoid sprintf buffer overrun.
1480 (generate_otf_features) [0 && HAVE_LIBOTF]: Use esprintf, not
1481 sprintf, in case result does not fit in int.
1482
c57b67fc
PE
1483 * fontset.c (num_auto_fontsets): Now printmax_t, not int.
1484 (fontset_from_font): Print it.
1485
8a401434
PE
1486 * frame.c (tty_frame_count): Now printmax_t, not int.
1487 (make_terminal_frame, set_term_frame_name): Print it.
1488 (x_report_frame_params): In X, window IDs are unsigned long,
1489 not signed long, so print them as unsigned.
1490 (validate_x_resource_name): Check for implausibly long names,
1491 and don't assume name length fits in 'int'.
1492 (x_get_resource_string): Don't blindly alloca invocation name;
1493 use SAFE_ALLOCA. Use esprintf, not sprintf, in case result does
1494 not fit in int.
1495
6e1a67fb
PE
1496 * gtkutil.c: Include <float.h>, for DBL_MAX_10_EXP.
1497 (xg_check_special_colors, xg_set_geometry):
84722b3d
PE
1498 Make sprintf buffers a bit bigger, to avoid potential buffer overrun.
1499
0df02bf3
PE
1500 * lread.c (dir_warning): Don't blindly alloca buffer; use SAFE_ALLOCA.
1501 Use esprintf, not sprintf, in case result does not fit in int.
1502
48e30793
PE
1503 * macros.c (executing_kbd_macro_iterations): Now EMACS_INT, not int.
1504 (Fend_kbd_macro): Don't mishandle MOST_NEGATIVE_FIXNUM by treating
1505 it as a large positive number.
1506 (Fexecute_kbd_macro): Don't assume repeat count fits in int.
1507 * macros.h (executing_kbd_macro_iterations): Now EMACS_INT, not int.
1508
a66ff6d8
PE
1509 * nsterm.m ((NSSize)windowWillResize): Use esprintf, not sprintf,
1510 in case result does not fit in int.
1511
aca216ff
PE
1512 * print.c (float_to_string): Detect width overflow more reliably.
1513 (print_object): Make sprintf buffer a bit bigger, to avoid potential
1514 buffer overrun. Don't assume list length fits in 'int'. Treat
1515 print length of 0 as 0, not as infinity; to be consistent with other
1516 uses of print length in this function. Don't overflow print length
1517 index. Don't assume hash table size fits in 'long', or that
1518 vectorlike size fits in 'unsigned long'.
1519
31c286f7
PE
1520 * process.c (make_process): Use printmax_t, not int, to format
1521 process-name gensyms.
1522
55e5faa1
PE
1523 * sysdep.c (snprintf) [! HAVE_SNPRINTF]: New function.
1524
80f2e268
PE
1525 * term.c (produce_glyphless_glyph): Make sprintf buffer a bit bigger
1526 to avoid potential buffer overrun.
1527
670741ab
PE
1528 * xfaces.c (x_update_menu_appearance): Don't overrun buffer
1529 if X resource line is longer than 512 bytes.
1530
b7163a50
PE
1531 * xfns.c (x_window): Make sprintf buffer a bit bigger
1532 to avoid potential buffer overrun.
1533
ae58ff1f
PE
1534 * xterm.c (x_io_error_quitter): Don't overrun sprintf buffer.
1535
c43c8a6a
PE
1536 * xterm.h (x_check_errors): Add ATTRIBUTE_FORMAT_PRINTF.
1537
3f8236f4
PE
15382011-09-04 Paul Eggert <eggert@cs.ucla.edu>
1539
53e9fe90 1540 Integer overflow fixes for scrolling, etc.
6511acf2
PE
1541 Without these, Emacs silently mishandles large integers sometimes.
1542 For example, "C-u 4294967297 M-x recenter" was treated as if
53e9fe90
PE
1543 it were "C-u 1 M-x recenter" on a typical 64-bit host.
1544
6511acf2
PE
1545 * xdisp.c (try_window_id): Check Emacs fixnum range before
1546 converting to 'int'.
806add1d 1547
6511acf2 1548 * window.c (window_scroll_line_based, Frecenter):
71f02bc5
PE
1549 Check that an Emacs fixnum is in range before assigning it to 'int'.
1550 (Frecenter, Fmove_to_window_line): Use EMACS_INT, not int, for
1551 values converted from Emacs fixnums.
1552 (Frecenter): Don't wrap around a line count if it is out of 'int'
1553 range; instead, treat it as an extreme value.
1554 (Fset_window_configuration, compare_window_configurations):
1555 Use ptrdiff_t, not int, for index that might exceed 2 GiB.
1556
6511acf2
PE
1557 * search.c (Freplace_match): Use ptrdiff_t, not int, for indexes
1558 that can exceed INT_MAX. Check that EMACS_INT value is in range
1559 before assigning it to the (possibly-narrower) index.
a0efffc8
PE
1560 (match_limit): Don't assume that a fixnum can fit in 'int'.
1561
6511acf2 1562 * print.c (print_object): Use ptrdiff_t, not int, for index that can
29ebea3b
PE
1563 exceed INT_MAX.
1564
6511acf2 1565 * indent.c (position_indentation): Now takes ptrdiff_t, not int.
3f8236f4
PE
1566 (Fvertical_motion): Don't wrap around LINES values that don't fit
1567 in 'int'. Instead, treat them as extreme values. This is good
1568 enough for windows, which can't have more than INT_MAX lines anyway.
1569
fcb901a7
LMI
15702011-09-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
1571
0f2f6b6d
LMI
1572 * Require libxml/parser.h to avoid compilation warning.
1573
fcb901a7
LMI
1574 * emacs.c (shut_down_emacs): Call xmlCleanupParser on shutdown.
1575
1576 * xml.c (parse_region): Don't call xmlCleanupParser after parsing,
1577 since this reportedly can destroy thread storage.
1578
6e20a0d4
CY
15792011-08-30 Chong Yidong <cyd@stupidchicken.com>
1580
1581 * syntax.c (find_defun_start): Update all cache variables if
1582 exiting early (Bug#9401).
1583
148ae00e
EZ
15842011-08-30 Eli Zaretskii <eliz@gnu.org>
1585
f6cfbd8f
EZ
1586 * image.c (x_bitmap_pixmap): Cast to int to avoid compiler warnings.
1587
148ae00e
EZ
1588 * xdisp.c (produce_stretch_glyph): No longer static, compiled also
1589 when HAVE_WINDOW_SYSTEM is not defined. Support both GUI and TTY
1590 frames. Call tty_append_glyph in the TTY case. (Bug#9402)
1591
1592 * term.c (tty_append_glyph): New function.
1593 (produce_stretch_glyph): Static function and its prototype deleted.
1594
a66cfb1c
SM
1595 * dispextern.h (produce_stretch_glyph, tty_append_glyph):
1596 Add prototypes.
148ae00e 1597
c4a07a4c
PE
15982011-08-29 Paul Eggert <eggert@cs.ucla.edu>
1599
1600 * image.c (parse_image_spec): Check for nonnegative, not for positive,
1601 when checking :margin (Bug#9390).
1602 (IMAGE_NON_NEGATIVE_INTEGER_VALUE_OR_PAIR):
a66cfb1c 1603 Rename from IMAGE_POSITIVE_INTEGER_VALUE_OR_PAIR,
c4a07a4c
PE
1604 so that the name doesn't mislead. All uses changed.
1605
6bc8cd65
JB
16062011-08-28 Johan Bockgård <bojohan@gnu.org>
1607
1608 * term.c (init_tty) [HAVE_GPM]: Move mouse settings after
1609 set_tty_hooks.
1610
dca4927e
EZ
16112011-08-27 Eli Zaretskii <eliz@gnu.org>
1612
1613 * xdisp.c (move_it_to): Don't bail out early when reaching
1614 position beyond to_charpos, if we are scanning backwards.
1615 (move_it_vertically_backward): When DY == 0, make sure we get to
1616 the first character in the line after the newline.
1617
f2cad773
PE
16182011-08-27 Paul Eggert <eggert@cs.ucla.edu>
1619
1620 * ccl.c: Improve and simplify overflow checking (Bug#9196).
1621 (ccl_driver): Do not generate an out-of-range pointer.
1622 (Fccl_execute_on_string): Remove unnecessary check for
1623 integer overflow, noted by Stefan Monnier in
1624 <http://lists.gnu.org/archive/html/emacs-devel/2011-08/msg00979.html>.
1625 Remove a FIXME that didn't need fixing.
1626 Simplify the newly-introduced buffer reallocation code.
1627
0cae2cdb
JB
16282011-08-27 Juanma Barranquero <lekktu@gmail.com>
1629
1630 * makefile.w32-in ($(BLD)/alloc.$(O)): Depend on lib/verify.h.
1631
5fc295a4 16322011-08-26 Paul Eggert <eggert@cs.ucla.edu>
ddff3151 1633
70c60eb2 1634 Integer and memory overflow issues (Bug#9196).
726e0ab1 1635
d31850da
PE
1636 * doc.c (get_doc_string): Rework so that
1637 get_doc_string_buffer_size is the actual buffer size, rather than
1638 being 1 less than the actual buffer size; this makes xpalloc more
1639 convenient.
1640
a69fbedb
PE
1641 * image.c (x_allocate_bitmap_record, cache_image):
1642 * xselect.c (Fx_register_dnd_atom):
1643 Simplify previous changes by using xpalloc.
1644
fe5c5d37
PE
1645 * buffer.c (overlay_str_len): Now ptrdiff_t, not EMACS_INT,
1646 since either will do and ptrdiff_t is convenient with xpalloc.
1647
0065d054
PE
1648 * charset.c (charset_table_size)
1649 (struct charset_sort_data.priority): Now ptrdiff_t.
1650 (charset_compare): Don't overflow if priorities differ greatly.
1651 (Fsort_charsets): Don't assume list length fits in int.
1652 Check for size-calculation overflow when allocating sort data.
1653 (syms_of_charset): Allocate an initial charset table that is
1654 just under 64 KiB, to avoid problems with glibc malloc and mmap.
1655
1656 * cmds.c (internal_self_insert): Check for size-calculation overflow.
1657
1658 * composite.h (struct composition.glyph_len): Now int, not unsigned.
1659 The actual value is always <= INT_MAX, and leaving it unsigned made
1660 overflow checking harder.
1661
1662 * dispextern.h (struct glyph_matrix.rows_allocated)
1663 (struct face_cache.size): Now ptrdiff_t, for convenience in use
1664 with xpalloc. The values are still always <= INT_MAX.
1665
1666 * indent.c (compute_motion): Adjust to region_cache_forward sig change.
1667
1668 * lisp.h (xnmalloc, xnrealloc, xpalloc): New decls.
1669 (SAFE_NALLOCA): New macro.
1670
1671 * region-cache.c (struct boundary.pos, find_cache_boundary)
1672 (move_cache_gap, insert_cache_boundary, delete_cache_boundaries)
1673 (set_cache_region, invalidate_region_cache)
1674 (revalidate_region_cache, know_region_cache, region_cache_forward)
1675 (region_cache_backward, pp_cache):
1676 Use ptrdiff_t, not EMACS_INT, since either will do. This is needed
1677 so that ptrdiff_t * can be passed to xpalloc.
1678 (struct region_cache): Similarly, for gap_start, gap_len, cache_len,
1679 beg_unchanged, end_unchanged, buffer_beg, buffer_end members.
1680 (pp_cache): Don't assume cache_len fits in int.
1681 * region-cache.h: Adjust extern decls to match.
1682
1683 * search.c (scan_buffer, Freplace_match): Use ptrdiff_t, not
1684 EMACS_INT, since either will do, for xpalloc.
1685
1686 * alloc.c: Include verify.h, and check that int fits in ptrdiff_t.
1687 (xnmalloc, xnrealloc, xpalloc): New functions.
1688
726e0ab1
PE
1689 * bidi.c (bidi_shelve_header_size): New constant.
1690 (bidi_cache_ensure_space, bidi_shelve_cache): Use it.
1691 (bidi_cache_ensure_space): Avoid integer overflow when allocating.
1692
51f30bc5 1693 * bidi.c (bidi_cache_shrink):
726e0ab1
PE
1694 * buffer.c (overlays_at, overlays_in, record_overlay_string)
1695 (overlay_strings):
1696 Don't update size of array until after memory allocation succeeds,
1697 because xmalloc/xrealloc may not return.
0065d054
PE
1698 (struct sortstrlist.bytes): Now ptrdiff_t, as EMACS_INT doesn't help
1699 now that we have proper integer overflow checking.
1700 (record_overlay_string, overlay_strings): Catch overflows when
1701 calculating size of overlay_str_buf.
726e0ab1 1702
0065d054
PE
1703 * callproc.c (Fcall_process): Check for size overflow when
1704 calculating size of args2.
1705 (child_setup): Avoid overflow by using size_t rather than ptrdiff_t.
1706 Normally we prefer signed values, but sticking with ptrdiff_t would
1707 require adding more-complicated checks.
726e0ab1
PE
1708
1709 * ccl.c (Fccl_execute_on_string): Check for memory overflow.
1710 Use ptrdiff_t rather than EMACS_INT where ptrdiff_t will do.
1711 Redo buffer-overflow calculations to avoid integer overflow.
0065d054 1712 Add a FIXME comment where memory seems to be over-allocated.
726e0ab1
PE
1713
1714 * character.c (Fstring): Check for size-calculation overflow.
1715
1716 * coding.c (produce_chars): Redo buffer-overflow calculations to avoid
1717 unnecessary integer overflow. Check for size overflow.
1718 (encode_coding_object): Don't update size until xmalloc succeeds.
1719
1720 * composite.c (get_composition_id): Check for overflow in glyph
1721 length calculations.
1722
1723 Integer and memory overflow fixes for display code.
1724 * dispextern.h (struct glyph_pool.nglyphs): Now ptrdiff_t, not int.
1725 * dispnew.c (adjust_glyph_matrix, realloc_glyph_pool)
1726 (scrolling_window): Check for overflow in size calculations.
1727 (line_draw_cost, realloc_glyph_pool, add_row_entry):
1728 Don't assume glyph table len fits in int.
1729 (struct row_entry.bucket, row_entry_pool_size, row_entry_idx)
1730 (row_table_size): Now ptrdiff_t, not int.
1731 (scrolling_window): Avoid overflow in size calculations.
1732 Don't update size until allocation succeeds.
1733 * fns.c (concat): Check for overflow in size calculations.
1734 (next_almost_prime): Verify NEXT_ALMOST_PRIME_LIMIT.
1735 * lisp.h (RANGED_INTEGERP, TYPE_RANGED_INTEGERP): New macros.
1736 (NEXT_ALMOST_PRIME_LIMIT): New constant.
1737
1738 * doc.c (get_doc_string_buffer_size): Now ptrdiff_t, not int.
1739 (get_doc_string): Check for size calculation overflow.
1740 Don't update size until allocation succeeds.
1741 (get_doc_string, Fsubstitute_command_keys): Use ptrdiff_t, not
1742 EMACS_INT, where ptrdiff_t will do.
1743 (Fsubstitute_command_keys): Check for string overflow.
1744
1745 * editfns.c (set_time_zone_rule): Don't assume environment length
1746 fits in int.
1747 (message_length): Now ptrdiff_t, not int.
1748 (Fmessage_box): Don't update size until allocation succeeds.
1749 Don't assume message length fits in int.
1750 (Fformat): Use ptrdiff_t, not EMACS_INT, where ptrdiff_t will do.
1751
0065d054
PE
1752 * emacs.c (main): Do not reallocate argv, since there is a null at
1753 the end that can be overwritten, and this way there's no need to
1754 worry about size-calculation overflow.
1755 (sort_args): Check for size-calculation overflow.
726e0ab1
PE
1756
1757 * eval.c (init_eval_once, grow_specpdl): Don't update size until
1758 alloc succeeds.
1759 (call_debugger, grow_specpdl): Redo calculations to avoid overflow.
1760
1761 * frame.c (set_menu_bar_lines, x_set_frame_parameters)
1762 (x_set_scroll_bar_width, x_figure_window_size):
1763 Check for integer overflow.
1764 (x_set_alpha): Do not assume XINT fits in int.
1765
1766 * frame.h (struct frame): Use int, not EMACS_INT, where int works.
1767 This is for the members text_lines, text_cols, total_lines, total_cols,
1768 where the system imposes an 'int' limit.
1769
1770 * fringe.c (Fdefine_fringe_bitmap):
1771 Don't update size until alloc works.
1772
1773 * ftfont.c (ftfont_get_open_type_spec, setup_otf_gstring)
1774 (ftfont_shape_by_flt): Check for integer overflow in size calculations.
1775
1776 * gtkutil.c (get_utf8_string, xg_store_widget_in_map):
1777 Check for size-calculation overflow.
1778 (get_utf8_string): Use ptrdiff_t, not size_t, where either will
1779 do, as we prefer signed integers.
1780 (id_to_widget.max_size, id_to_widget.used)
1781 (xg_store_widget_in_map, xg_remove_widget_from_map)
1782 (xg_get_widget_from_map, xg_get_scroll_id_for_window)
1783 (xg_remove_scroll_bar, xg_update_scrollbar_pos):
1784 Use and return ptrdiff_t, not int.
1785 (xg_gtk_scroll_destroy): Don't assume ptrdiff_t fits in int.
1786 * gtkutil.h: Change prototypes to match the above.
1787
1788 * image.c (RANGED_INTEGERP, TYPE_RANGED_INTEGERP): Remove; these
1789 are duplicate now that they've been promoted to lisp.h.
1790 (x_allocate_bitmap_record, x_alloc_image_color)
1791 (make_image_cache, cache_image, xpm_load):
1792 Don't update size until alloc is done.
1793 (xpm_load, lookup_rgb_color, lookup_pixel_color, x_to_xcolors)
1794 (x_detect_edges):
3256efce 1795 Check for size calculation overflow.
726e0ab1
PE
1796 (ct_colors_allocated_max): New constant.
1797 (x_to_xcolors, x_detect_edges): Reorder multiplicands to avoid
1798 overflow.
3256efce 1799
726e0ab1
PE
1800 * keyboard.c (read_char, menu_bar_items, tool_bar_items)
1801 (read_char_x_menu_prompt, read_char_minibuf_menu_width)
1802 (read_char_minibuf_menu_prompt, follow_key, read_key_sequence):
1803 Use ptrdiff_t, not int, to count maps.
1804 (read_char_minibuf_menu_prompt): Check for overflow in size
a66cfb1c
SM
1805 calculations. Don't update size until allocation succeeds.
1806 Redo calculations to avoid overflow.
726e0ab1
PE
1807 * keyboard.h: Change prototypes to match the above.
1808
1809 * keymap.c (cmm_size, current_minor_maps): Use ptrdiff_t, not int,
1810 to count maps.
1811 (current_minor_maps): Check for size calculation overflow.
1812 * keymap.h: Change prototypes to match the above.
1813
1814 * lread.c (read1, init_obarray): Don't update size until alloc done.
1815
1816 * macros.c (Fstart_kbd_macro): Don't update size until alloc done.
1817 (store_kbd_macro_char): Reorder multiplicands to avoid overflow.
1818
726e0ab1
PE
1819 * nsterm.h (struct ns_color_table.size, struct ns_color_table.avail):
1820 Now ptrdiff_t, not int.
1821 * nsterm.m (ns_index_color): Use ptrdiff_t, not int, for table indexes.
1822 (ns_draw_fringe_bitmap): Rewrite to avoid overflow.
1823
1824 * process.c (Fnetwork_interface_list): Check for overflow
1825 in size calculation.
1826
1827 * region-cache.c (move_cache_gap): Check for size calculation overflow.
1828
1829 * scroll.c (do_line_insertion_deletion_costs): Check for size calc
1830 overflow. Don't bother calling xmalloc when xrealloc will do.
1831
1832 * search.c (Freplace_match): Check for size calculation overflow.
1833 (Fset_match_data): Don't assume list lengths fit in 'int'.
1834
1835 * sysdep.c (system_process_attributes): Use ptrdiff_t, not int,
1836 for command line length. Do not attempt to address one before the
1837 beginning of an array, as that's not portable.
1838
1839 * term.c (max_frame_lines): Remove; unused.
1840 (encode_terminal_src_size, encode_terminal_dst_size): Now ptrdiff_t,
1841 not int.
1842 (encode_terminal_code, calculate_costs): Check for size
1843 calculation overflow.
1844 (encode_terminal_code): Use ptrdiff_t, not int, to record glyph
1845 table lengths and related sizes. Don't update size until alloc
1846 done. Redo calculations to avoid overflow.
1847 (calculate_costs): Don't bother calling xmalloc when xrealloc will do.
1848
1849 * termcap.c (tgetent): Use ptrdiff_t, not int, to record results of
1850 subtracting pointers.
1851 (gobble_line): Check for overflow more carefully. Don't update size
1852 until alloc done.
1853
1854 * tparam.c (tparam1): Use ptrdiff_t, not int, for sizes.
1855 Don't update size until alloc done.
1856 Redo size calculations to avoid overflow.
1857 Check for size calculation overflow.
0065d054 1858 (main) [DEBUG]: Fix typo in invoking tparam1.
726e0ab1
PE
1859
1860 * xdisp.c (store_mode_line_noprop_char, x_consider_frame_title):
1861 Use ptrdiff_t, not int, for sizes.
1862 (store_mode_line_noprop_char): Don't update size until alloc done.
1863
0065d054
PE
1864 * xfaces.c (lface_id_to_name_size, Finternal_make_lisp_face):
1865 Use ptrdiff_t, not int, for sizes.
1866 (Finternal_make_lisp_face, cache_face):
1867 Check for size calculation overflow.
1868 (cache_face): Treat size calculation overflows as if they were
1869 memory exhaustion (the usual treatment), rather than aborting.
726e0ab1
PE
1870
1871 * xfns.c (x_encode_text, x_set_name_internal)
1872 (Fx_change_window_property): Use ptrdiff_t, not int, to count
1873 sizes, since they can exceed INT_MAX in size. Check for size
1874 calculation overflow.
1875
0065d054
PE
1876 * xgselect.c (gfds_size): Now ptrdiff_t, for convenience with xpalloc.
1877 (xg_select): Check for size calculation overflow.
726e0ab1
PE
1878 Don't update size until alloc done.
1879
0065d054 1880 * xrdb.c (get_environ_db): Don't assume path length fits in int,
726e0ab1 1881 as sprintf is limited to int lengths.
1d526e2f 1882
252c5ee1
PE
1883 * xselect.c (X_LONG_SIZE, X_SHRT_MAX, X_SHRT_MIN, X_LONG_MAX)
1884 (X_LONG_MIN): New macros.
864d7ce7
PE
1885 Use them to make the following changes clearer.
1886 (MAX_SELECTION_QUANTUM): Make the other bounds on this value clearer.
1887 This change doesn't affect the value now, but it may help remind
1888 future maintainers not to raise the value too much later.
1889 (SELECTION_QUANTUM): Remove, replacing with ...
1890 (selection_quantum): ... new function, which avoids overflow.
1891 All uses changed.
1892 (struct selection_data.size): Now ptrdiff_t, not int, to avoid
1893 assumption that selection length fits in 'int'.
1894 (x_reply_selection_request, x_handle_selection_request)
1895 (x_get_window_property, receive_incremental_selection)
1896 (x_get_window_property_as_lisp_data, selection_data_to_lisp_data)
1897 (lisp_data_to_selection_data, clean_local_selection_data):
1898 Use ptrdiff_t, not int, to record length of selection.
1899 (x_reply_selection_request, x_get_window_property)
1900 (receive_incremental_selection, x_property_data_to_lisp):
1901 Redo calculations to avoid overflow.
1902 (x_reply_selection_request): When sending hint, ceiling it at
252c5ee1 1903 X_LONG_MAX rather than relying on wraparound overflow to send
864d7ce7
PE
1904 something.
1905 (x_get_window_property, receive_incremental_selection)
1906 (lisp_data_to_selection_data, x_property_data_to_lisp):
1907 Check for size-calculation overflow.
1908 (x_get_window_property, receive_incremental_selection)
1909 (lisp_data_to_selection_data, Fx_register_dnd_atom):
1910 Don't store size until memory allocation succeeds.
1911 (x_get_window_property): Plug memory leak on memory exhaustion.
1912 Don't double-block input; malloc is safe here. Don't assume 2**34
1913 - 4 fits in unsigned long. Add an xassert to check
1914 XGetWindowProperty overflow. Be more careful about overflow
1915 calculations, and distinguish size from memory overflow better.
1916 (receive_incremental_selection): When tracing, don't assume
1917 unsigned int is less than INT_MAX.
1918 (x_selection_data_to_lisp_data): Remove unnecessary (and in theory
1919 harmful) conversions of unsigned short to int.
1920 (lisp_data_to_selection_data): Don't assume that integers
1921 in the range -65535 through -1 fit in an X unsigned short.
1922 Don't assume that ULONG_MAX == X_ULONG_MAX. Don't store into
1923 result parameters unless successful. Rely on cons_to_unsigned
1924 to report problems with elements; the old code wasn't right anyway.
1925 (x_check_property_data): Check for int overflow; we cannot use
1926 a wider type due to X limits.
1927 (x_handle_dnd_message): Use unsigned int, to avoid int overflow.
1928
726e0ab1 1929 * xsmfns.c (smc_save_yourself_CB): Check for size calc overflow.
34db673b 1930
0065d054
PE
1931 * xterm.c (x_color_cells, x_send_scrollbar_event, handle_one_xevent)
1932 (x_term_init): Check for size calculation overflow.
726e0ab1
PE
1933 (x_color_cells): Don't store size until memory allocation succeeds.
1934 (handle_one_xevent): Use ptrdiff_t, not int, for byte counts.
0065d054 1935 Don't assume alloca size is less than MAX_ALLOCA.
726e0ab1
PE
1936 (x_term_init): Don't assume length fits in int (sprintf is limited
1937 to int size).
bc18e09d 1938
ebfa62c0
PE
1939 Use ptrdiff_t for composition IDs.
1940 * character.c (lisp_string_width):
1941 * composite.c (composition_table_size, n_compositions)
1942 (get_composition_id, composition_gstring_from_id):
1943 * dispextern.h (struct glyph_string.cmp_id, struct composition_it.id):
1944 * xdisp.c (BUILD_COMPOSITE_GLYPH_STRING):
1945 * window.c (Frecenter):
1946 Use ptrdiff_t, not int, for composition IDs.
1947 * composite.c (get_composition_id): Check for integer overflow.
1948 * composite.h: Adjust prototypes to match the above changes.
1949
d3411f89
PE
1950 Use ptrdiff_t for hash table indexes.
1951 * category.c (hash_get_category_set):
1952 * ccl.c (ccl_driver):
1953 * charset.h (struct charset.hash_index, CHECK_CHARSET_GET_ID):
1954 * coding.c (coding_system_charset_list, detect_coding_system):
1955 * coding.h (struct coding_system.id):
1956 * composite.c (get_composition_id, gstring_lookup_cache):
1957 * fns.c (hash_lookup, hash_put, Fgethash, Fputhash):
1958 * image.c (xpm_get_color_table_h):
1959 * lisp.h (hash_lookup, hash_put):
1960 * minibuf.c (Ftest_completion):
1961 Use ptrdiff_t for hash table indexes, not int (which is too
1962 narrow, on 64-bit hosts) or EMACS_INT (which is too wide, on
1963 32-bit --with-wide-int hosts).
1964
e097a6fa
PE
1965 * charset.c (Fdefine_charset_internal): Check for integer overflow.
1966 Add a FIXME comment about memory leaks.
1967 (syms_of_charset): Don't assume xmalloc returns.
1968
5637687f
PE
1969 Don't assume that stated character widths fit in int.
1970 * character.c (Fchar_width, c_string_width, lisp_string_width):
1971 * character.h (CHAR_WIDTH):
1972 * indent.c (MULTIBYTE_BYTES_WIDTH):
1973 Use sanitize_char_width to avoid undefined and/or bad behavior
1974 with outlandish widths.
a66cfb1c 1975 * character.h (sanitize_tab_width): Rename from sanitize_width,
5637687f
PE
1976 now that we have two such functions. All uses changed.
1977 (sanitize_char_width): New inline function.
1978
a2271ba2
PE
1979 Don't assume that tab-width fits in int.
1980 * character.h (sanitize_width): New inline function.
1981 (SANE_TAB_WIDTH): New macro.
1982 (ASCII_CHAR_WIDTH): Use it.
1983 * indent.c (sane_tab_width): Remove. All uses replaced by
1984 SANE_TAB_WIDTH (current_buffer).
1985 * xdisp.c (init_iterator): Use SANE_TAB_WIDTH.
1986
18c52557
PE
1987 * fileio.c: Integer overflow issues with file modes.
1988 (Fset_file_modes, auto_save_1): Don't assume EMACS_INT fits in int.
1989
caeeedc1
PE
1990 * charset.c (read_hex): New arg OVERFLOW. All uses changed.
1991 Remove unreachable code.
1992 (read_hex, load_charset_map_from_file): Check for integer overflow.
1993
50849c52
PE
1994 * xterm.c: don't go over XClientMessageEvent limit
1995 (scroll_bar_windows_size): Now ptrdiff_t, as we prefer signed.
1996 (x_send_scroll_bar_event): Likewise. Check that the size does not
1997 exceed limits imposed by XClientMessageEvent, as well as the usual
1998 ptrdiff_t and size_t limits.
1999
b13995db
PE
2000 * keyboard.c: Overflow, signedness and related fixes.
2001 (make_lispy_movement): Use same integer type in forward decl
2002 that is used in the definition.
2003 (read_key_sequence, keyremap_step):
2004 Change bufsize argument back to int, undoing my 2011-03-30 change.
2005 We prefer signed types, and int is wide enough here.
2006 (parse_tool_bar_item): Don't assume tool_bar_max_label_size is less
2007 than TYPE_MAXIMUM (EMACS_INT) / 2. Don't let the label size grow
2008 larger than STRING_BYTES_BOUND. Use ptrdiff_t for Emacs string
2009 length, not size_t. Use ptrdiff_t for index, not int.
2010 (keyremap_step, read_key_sequence): Redo bufsize check to avoid
2011 possibility of integer overflow.
2012
13464394
PE
2013 Overflow, signedness and related fixes for images.
2014
2015 * dispextern.h (struct it.stack[0].u.image.image_id)
2016 (struct_it.image_id, struct image.id, struct image_cache.size)
2017 (struct image_cache.used, struct image_cache.ref_count):
2018 * gtkutil.c (update_frame_tool_bar):
2019 * image.c (x_reference_bitmap, Fimage_size, Fimage_mask_p)
2020 (Fimage_metadata, free_image_cache, clear_image_cache, lookup_image)
2021 (cache_image, mark_image_cache, x_kill_gs_process, Flookup_image):
2022 * nsmenu.m (update_frame_tool_bar):
2023 * xdisp.c (calc_pixel_width_or_height):
2024 * xfns.c (image_cache_refcount):
2025 Image IDs are now ptrdiff_t, not int, to avoid arbitrary limits
2026 on typical 64-bit hosts.
2027
2028 * image.c (RANGED_INTEGERP, TYPE_RANGED_INTEGERP): New macros.
2029 (x_bitmap_pixmap, x_create_x_image_and_pixmap):
2030 Omit unnecessary casts to int.
2031 (parse_image_spec): Check that integers fall into 'int' range
2032 when the callers expect that.
2033 (image_ascent): Redo ascent calculation to avoid int overflow.
2034 (clear_image_cache): Avoid overflow when sqrt (INT_MAX) < nimages.
2035 (lookup_image): Remove unnecessary tests.
2036 (xbm_image_p): Locals are now of int, not EMACS_INT,
2037 since parse_image_check makes sure they fit into int.
2038 (png_load, gif_load, svg_load_image):
2039 Prefer int to unsigned where either will do.
2040 (tiff_handler): New function, combining the cores of the
a66cfb1c
SM
2041 old tiff_error_handler and tiff_warning_handler.
2042 This function is rewritten to use vsnprintf and thereby avoid
13464394
PE
2043 stack buffer overflows. It uses only the features of vsnprintf
2044 that are common to both POSIX and native Microsoft.
2045 (tiff_error_handler, tiff_warning_handler): Use it.
2046 (tiff_load, gif_load, imagemagick_load_image):
2047 Don't assume :index value fits in 'int'.
2048 (gif_load): Omit unnecessary cast to double, and avoid double-rounding.
2049 (imagemagick_load_image): Check that crop parameters fit into
2050 the integer types that MagickCropImage accepts. Don't assume
2051 Vimagemagick_render_type has a nonnegative value. Don't assume
2052 size_t fits in 'long'.
2053 (gs_load): Use printmax_t to print the widest integers possible.
2054 Check for integer overflow when computing image height and width.
2055
c11821d4
EZ
20562011-08-26 Eli Zaretskii <eliz@gnu.org>
2057
2058 * xdisp.c (redisplay_window): Don't force window start if point
2059 will be invisible in the resulting window. (Bug#9324)
2060
0c95fcf7
EZ
20612011-08-25 Eli Zaretskii <eliz@gnu.org>
2062
2063 * xdisp.c (compute_display_string_pos): Return 2 in DISP_PROP when
2064 the display spec is of the form `(space ...)'.
2065 (handle_display_spec): Return the value returned by
2066 handle_single_display_spec, not just 1 or zero.
2067 (handle_single_display_spec): If the display spec is of the form
2068 `(space ...)', and specifies display in the text area, return 2
2069 rather than 1.
fee65a97 2070 (try_cursor_movement): Check for the need to scroll more
a66cfb1c
SM
2071 accurately, and prefer exact match for point under bidi.
2072 Don't advance `row' beyond the last row of the window.
0c95fcf7
EZ
2073
2074 * dispextern.h (struct bidi_it): Rename the disp_prop_p member
2075 into disp_prop; all users changed.
2076
2077 * bidi.c (bidi_fetch_char): If compute_display_string_pos returns
2078 DISP_PROP = 2, substitute the u+2029 PARAGRAPH SEPARATOR character
2079 for the text covered by the display property.
2080
e4ed06f1
CY
20812011-08-25 Chong Yidong <cyd@stupidchicken.com>
2082
2083 * buffer.c (Fbury_buffer_internal): Rename from Funrecord_buffer.
2084 Change return value to nil.
2085 (Frecord_buffer): Delete unused function.
2086
f67cdd7f
EZ
20872011-08-24 Eli Zaretskii <eliz@gnu.org>
2088
5980d4c6
EZ
2089 * xdisp.c (Fcurrent_bidi_paragraph_direction): For unibyte
2090 buffers, return left-to-right.
8610fe8b
EZ
2091 (set_cursor_from_row): Consider candidate row a win if its glyph
2092 represents a newline and point is on that newline. Fixes cursor
2093 positioning on the newline at EOL of R2L text within L2R
2094 paragraph, and vice versa.
2095 (try_cursor_movement): Check continued rows, in addition to
2096 continuation rows. Fixes unwarranted scroll when point enters a
2097 continued line of R2L text within an L2R paragraph, or vice versa.
2098 (cursor_row_p): Consider the case of point being equal to
2099 MATRIX_ROW_END_CHARPOS. Prevents cursor being stuck when moving
2100 from the end of a short line to the beginning of a continued line
2101 of R2L text within L2R paragraph.
2102 (RECORD_MAX_MIN_POS): For max_pos, use IT_CHARPOS even for
2103 composed characters.
5980d4c6 2104
f67cdd7f
EZ
2105 * bidi.c (bidi_check_type): Use xassert.
2106 (bidi_cache_iterator_state): Update the disp_pos and disp_prop_p
2107 members.
2108
bca633fb
EZ
21092011-08-23 Eli Zaretskii <eliz@gnu.org>
2110
2111 * bidi.c (bidi_get_type): Abort if we get zero as the bidi type of
2112 a character.
2113
4a5885a7
CY
21142011-08-23 Chong Yidong <cyd@stupidchicken.com>
2115
2116 * nsfont.m (ns_otf_to_script): Fix typo.
2117
0902a04e
KH
21182011-08-22 Kenichi Handa <handa@m17n.org>
2119
2120 * chartab.c (Fset_char_table_extra_slot): Do not inhibit setting a
2121 extra slot even if the purpose is char-code-property-table.
2122
1a2e6670
EZ
21232011-08-23 Eli Zaretskii <eliz@gnu.org>
2124
8ddde651
EZ
2125 * xdisp.c (redisplay_window): When computing centering_position,
2126 account for the height of the header line. (Bug#8874)
2127
425cc014
EZ
2128 * dispnew.c (buffer_posn_from_coords): Use buf_charpos_to_bytepos
2129 instead of CHAR_TO_BYTE. Fixes a crash when a completion
2130 candidate is selected by the mouse, and that candidate has a
2131 composed character under the mouse.
2132
1a2e6670
EZ
2133 * xdisp.c (x_produce_glyphs): Set it->nglyphs to 1. Fixes pixel
2134 coordinates reported by pos-visible-in-window-p for a composed
2135 character in column zero.
2136
8b76d6f8
SM
21372011-08-23 Stefan Monnier <monnier@iro.umontreal.ca>
2138
2139 * cmds.c (Fself_insert_command): Mention post-self-insert-hook.
2140
dac347dd
EZ
21412011-08-22 Eli Zaretskii <eliz@gnu.org>
2142
2143 * xdisp.c (BUFFER_POS_REACHED_P): If this is a composition,
2144 consider it a hit if to_charpos is anywhere in the range of the
2145 composed buffer positions.
2146
e013fb34
CY
21472011-08-22 Chong Yidong <cyd@stupidchicken.com>
2148
2149 * image.c (gif_load): Don't assume that each subimage has the same
2150 dimensions as the base image. Handle disposal method that is
2151 "undefined" by the gif spec (Bug#9335).
2152
bd1ba3e8
CY
21532011-08-20 Chong Yidong <cyd@stupidchicken.com>
2154
2155 * eval.c (Fsignal): Handle `debug' symbol in error handler (Bug#9329).
024a2d76 2156 (Fcondition_case): Document `debug' symbol in error handler.
bd1ba3e8 2157
54a1215b
EZ
21582011-08-19 Eli Zaretskii <eliz@gnu.org>
2159
823564e5
EZ
2160 * xfaces.c (face_at_buffer_position): Avoid repeated evaluation of
2161 face ID by FACE_FROM_ID, and avoid a crash when mouse is moved
2162 from an Org mode buffer to a Speedbar frame.
2163
54a1215b
EZ
2164 * xdisp.c (RECORD_MAX_MIN_POS): If the display element comes from
2165 a composition, take its buffer position from IT->cmp_it.charpos.
2166 Fixes cursor positioning at the beginning of a line that begins
2167 with a composed character.
2168
9778ebcc
EZ
21692011-08-18 Eli Zaretskii <eliz@gnu.org>
2170
0be6ee06
EZ
2171 * bidi.c (bidi_get_type): If bidi_type_table reports zero as the
2172 character bidirectional type, use STRONG_L instead. Fixes crashes
2173 in a buffer produced by `describe-categories'.
2174
9778ebcc
EZ
2175 * dispextern.h (struct bidi_it): Move disp_pos and disp_prop_p
2176 members before the level stack, so they would be saved and
2177 restored when copying iterator state. Fixes incorrect reordering
2178 around TABs covered by display properties.
2179
156bffbe
AS
21802011-08-18 Andreas Schwab <schwab@linux-m68k.org>
2181
6b02f655 2182 * process.c (Fnetwork_interface_list): Correctly determine buffer size.
156bffbe 2183
72ad093b
CY
21842011-08-17 Chong Yidong <cyd@stupidchicken.com>
2185
2186 * eval.c (internal_condition_case, internal_condition_case_1)
8b76d6f8
SM
2187 (internal_condition_case_2, internal_condition_case_n):
2188 Remove unnecessary aborts (Bug#9081).
72ad093b 2189
35774242
EZ
21902011-08-17 Eli Zaretskii <eliz@gnu.org>
2191
2192 * lread.c (Fload) [DOS_NT]: If `openp' returns -2, but the file
2193 has no `load' handler, try opening the file locally. (Bug#9311)
2194
db76dd85
KB
21952011-08-16 Ken Brown <kbrown@cornell.edu>
2196
2197 * gmalloc.c: Expand comment.
2198
b215eee5
EZ
21992011-08-16 Eli Zaretskii <eliz@gnu.org>
2200
2201 * xdisp.c (set_cursor_from_row): Don't accept a previous candidate
2202 if it fails the cursor_row_p test. Fixes cursor positioning at ZV.
2203
a4579d33
KB
22042011-08-16 Ken Brown <kbrown@cornell.edu>
2205
2206 Fix memory allocation problems in Cygwin build (Bug#9273).
2207
2208 * unexcw.c ( __malloc_initialized): Declare external variable.
2209 (fixup_executable): Force the dumped emacs to reinitialize malloc.
2210
8b76d6f8
SM
2211 * gmalloc.c [CYGWIN] (bss_sbrk_heapbase, bss_sbrk_heapinfo):
2212 New variables.
a4579d33
KB
2213 (malloc_initialize_1) [CYGWIN]: Prepare for reinitializing the
2214 dumped emacs.
2215 (_free_internal_nolock) [CYGWIN]: Ignore requests to free storage
2216 in the static heap.
2217 [CYGWIN] (special_realloc): New function.
2218 (_realloc_internal_nolock) [CYGWIN]: Use the new function on
2219 requests to realloc storage in the static heap.
2220
3ebec551
PE
22212011-08-15 Paul Eggert <eggert@cs.ucla.edu>
2222
2223 * bidi.c (bidi_initialize): Remove unused local.
2224
9fd8be00
EZ
22252011-08-15 Eli Zaretskii <eliz@gnu.org>
2226
6b02f655
SM
2227 * bidimirror.h:
2228 * biditype.h: Remove file.
2229 * makefile.w32-in ($(BLD)/bidi.$(O)):
2230 * deps.mk (bidi.o): Remove biditype.h and bidimirror.h.
474a8465
EZ
2231
2232 * dispextern.h: Fix a typo in the comment to bidi_type_t.
2233
2234 * chartab.c: Improve commentary for the uniprop_table API.
2235
32413314
EZ
2236 * bidi.c (bidi_paragraph_init): Support zero value of
2237 bidi_ignore_explicit_marks_for_paragraph_level.
474a8465
EZ
2238 (bidi_initialize): Use uniprop_table instead of including
2239 biditype.h and bidimirror.h.
32413314 2240
9fd8be00
EZ
2241 * xdisp.c (move_it_in_display_line_to): Don't reset pixel
2242 coordinates of the iterator when restoring from ppos_it.
2243 (Bug#9296)
2244
5cf2b69b
KH
22452011-08-14 Kenichi Handa <handa@m17n.org>
2246
2247 * process.c (create_process): Call setup_process_coding_systems
72ad093b 2248 after the pid of the process is set to -1 (Bug#8162).
5cf2b69b 2249
daf17d00
EZ
22502011-08-14 Eli Zaretskii <eliz@gnu.org>
2251
2252 * xdisp.c (move_it_in_display_line_to): Don't invoke
2253 IT_RESET_X_ASCENT_DESCENT when iterator position was restored from
2254 ppos_it. Fixes vertical cursor motion when line beginning is
2255 covered by an image. (Bug#9296)
2256
08e3161a
JD
22572011-08-14 Jan Djärv <jan.h.d@swipnet.se>
2258
2259 * nsterm.h (ns_run_ascript): Declare.
2260 (NSAPP_DATA2_RUNASSCRIPT): Define.
2261
2262 * nsfns.m (as_script, as_result, as_status): New static variables.
2263 (ns_run_ascript): New function.
5e617bc2 2264 (Fns_do_applescript): Set variables as_*. Make an NSApplicationDefined
08e3161a
JD
2265 event with data2 set to NSAPP_DATA2_RUNASSCRIPT, post it and then start
2266 the event loop. Get status from as_status (Bug#7276).
2267
2268 * nsterm.m (sendEvent): If event is NSApplicationDefined and
2269 data2 is NSAPP_DATA2_RUNASSCRIPT, call ns_run_ascript and then exit
2270 the event loop (Bug#7276).
2271
a3720aa2
AS
22722011-08-14 Andreas Schwab <schwab@linux-m68k.org>
2273
2274 * gnutls.c (QCgnutls_bootprop_priority)
2275 (QCgnutls_bootprop_trustfiles, QCgnutls_bootprop_keylist)
2276 (QCgnutls_bootprop_crlfiles, QCgnutls_bootprop_callbacks)
2277 (QCgnutls_bootprop_loglevel, QCgnutls_bootprop_hostname)
2278 (QCgnutls_bootprop_min_prime_bits, QCgnutls_bootprop_verify_flags)
2279 (QCgnutls_bootprop_verify_hostname_error)
2280 (QCgnutls_bootprop_callbacks_verify): Rename from
2281 Qgnutls_bootprop_..., all uses changed.
2282
2283 * xfaces.c (QCignore_defface): Rename from Qignore_defface, all
2284 uses changed.
2285
0a0d27fb
PE
22862011-08-14 Paul Eggert <eggert@cs.ucla.edu>
2287
19d5c50c
PE
2288 * xfaces.c (Qframe_set_background_mode): Now static.
2289 * dispextern.h (Qframe_set_background_mode): Remove decl.
2290
0a0d27fb
PE
2291 * process.c (Fnetwork_interface_info): Declare local only if needed.
2292
377538cb
JD
22932011-08-13 Jan Djärv <jan.h.d@swipnet.se>
2294
2295 * process.c: Include ifaddrs.h and net/if_dl.h if available (Bug#8477).
2296 (Fnetwork_interface_list): Allocate in increments of bytes instead
2297 of sizeof (struct ifreq). Iterate over ifconf.ifc_req by counting
2298 bytes (Bug#8477). Count bytes correctly when ifr_addr is a struct
2299 sockaddr.
2300 (struct ifflag_def): notrailers is smart on OSX.
2301 (Fnetwork_interface_info): Handle case when ifr_flags is negative.
2302 Get hardware address with getifaddrs if available.
2303
08fff70c
EZ
23042011-08-12 Eli Zaretskii <eliz@gnu.org>
2305
2306 * xdisp.c (iterate_out_of_display_property): xassert that
2307 IT->position is set to within IT->object's boundaries. Break from
2308 the loop as soon as EOB is reached; avoids infloops in redisplay
8b76d6f8
SM
2309 when IT->position is set up wrongly due to some bug.
2310 Set IT->current to match the bidi iterator unconditionally.
08fff70c
EZ
2311 (push_display_prop): Allow GET_FROM_STRING as IT->method on
2312 entry. Force push_it to save on the stack the current
2313 buffer/string position, to be restored by pop_it. Fix flags in
2314 the iterator structure wrt the object coming from a display
2315 property, as `line-prefix' and `wrap-prefix' are not ``replacing''
2316 properties. (Bug#9284)
2317
7be1c708 23182011-08-09 Andreas Schwab <schwab@linux-m68k.org>
aac0c6e3 2319
7be1c708
CY
2320 * fontset.c (fontset_get_font_group): Add proper type checks.
2321 (Bug#9172)
aac0c6e3 2322
7be1c708 23232011-08-09 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
aac0c6e3 2324
7be1c708
CY
2325 * unexmacosx.c (print_load_command_name): Add cases LC_FUNCTION_STARTS
2326 and LC_VERSION_MIN_MACOSX.
2327 (copy_linkedit_data) [LC_FUNCTION_STARTS]: New function.
2328 (dump_it) [LC_FUNCTION_STARTS]: Use it.
aac0c6e3 2329
97bb72a6
EZ
23302011-08-08 Eli Zaretskii <eliz@gnu.org>
2331
2332 * xdisp.c (forward_to_next_line_start): Allow to use the
8b76d6f8
SM
2333 no-display-properties-and-no-overlays under bidi display.
2334 Set disp_pos in the bidi iterator to avoid searches for display
757664a4 2335 properties and overlays.
97bb72a6 2336
d5617611
CY
23372011-08-08 Chong Yidong <cyd@stupidchicken.com>
2338
37e11a63
CY
2339 * editfns.c (Fset_time_zone_rule): Document relationship with the
2340 setenv function.
2341
d5617611
CY
2342 * ftfont.c (ftfont_pattern_entity): Copy the extras argument to
2343 the font entity extracted from the cache (Bug#8109).
2344
58872834
CY
23452011-08-07 Chong Yidong <cyd@stupidchicken.com>
2346
2347 * composite.c (autocmp_chars): Don't reset point. That is done by
2348 restore_point_unwind (Bug#5984).
2349
75bfc667
JL
23502011-08-07 Juri Linkov <juri@jurta.org>
2351
2352 * editfns.c (Fformat_time_string): Doc fix, add tag `usage:'
2353 to show the arg `TIME' instead of `TIMEVAL'.
2354
d1410150
EZ
23552011-08-06 Eli Zaretskii <eliz@gnu.org>
2356
2357 * xdisp.c (set_cursor_from_row): Fix cursor positioning when a
2358 display property strides EOL and includes a newline, as in
2359 longlines-mode. (Bug#9254)
75b771e4
EZ
2360 (move_it_in_display_line_to): Fix vertical-motion in a buffer with
2361 word-wrap under bidirectional display. (Bug#9224)
d1410150
EZ
2362
2363 * bidi.c (bidi_unshelve_cache): Don't reset the cache if JUST_FREE
2364 is non-zero, even if the data buffer is NULL. Fixes a crash in
2365 vertical-motion with longlines-mode. (Bug#9254)
2366
35928349
EZ
23672011-08-05 Eli Zaretskii <eliz@gnu.org>
2368
ec7cc85b
EZ
2369 * bidi.c <bidi_cache_total_alloc>: Now static.
2370 (bidi_initialize): Initialize bidi_cache_total_alloc.
2371
8b76d6f8 2372 * xdisp.c (display_line): Release buffer allocated for shelved bidi
35928349
EZ
2373 cache. (Bug#9221)
2374
2375 * bidi.c (bidi_shelve_cache, bidi_unshelve_cache): Track total
2376 amount allocated this far in `bidi_cache_total_alloc'.
2377 (bidi_unshelve_cache): Accept an additional argument JUST_FREE; if
2378 non-zero, only free the data buffer without restoring the cache
2379 contents. All callers changed.
2380
2381 * dispextern.h (bidi_unshelve_cache): Update prototype.
2382
2383 * xdisp.c (SAVE_IT, pos_visible_p, move_it_in_display_line_to)
2384 (move_it_in_display_line, move_it_to)
2385 (move_it_vertically_backward, move_it_by_lines): Replace the call
2386 to xfree to an equivalent call to bidi_unshelve_cache.
2387 (move_it_in_display_line_to): Fix logic of returning
412b6358 2388 MOVE_POS_MATCH_OR_ZV in the bidi case. (Bug#9224)
35928349 2389
e2e2423b
EZ
23902011-08-05 Eli Zaretskii <eliz@gnu.org>
2391
2392 * xdisp.c (set_cursor_from_row): Prefer the candidate glyph that
2393 came from a string character with a `cursor' property. (Bug#9229)
2394
ae9e757a
JD
23952011-08-04 Jan Djärv <jan.h.d@swipnet.se>
2396
2397 * Makefile.in (LIB_PTHREAD): New variable.
2398 (LIBES): Add LIB_PTHREAD (Bug#9216).
2399
2400 * alloc.c, emacs.c, gmalloc.c, gtkutil.c, keyboard.c, syssignal.h:
2401 Rename HAVE_GTK_AND_PTHREAD to HAVE_PTHREAD (Bug#9216).
2402
213bd7f2
AS
24032011-08-04 Andreas Schwab <schwab@linux-m68k.org>
2404
6b02f655 2405 * regex.c (re_iswctype): Remove some redundant boolean conversions.
213bd7f2 2406
99aaf75f
JD
24072011-08-04 Jan Djärv <jan.h.d@swipnet.se>
2408
2409 * xterm.c (x_find_topmost_parent): New function.
2410 (x_set_frame_alpha): Find topmost parent window with
2411 x_find_topmost_parent and set the property there also (bug#9181).
2412 (handle_one_xevent): Call x_set_frame_alpha on ReparentNotify.
2413
c74e9d86
PE
24142011-08-04 Paul Eggert <eggert@cs.ucla.edu>
2415
2416 * callproc.c (Fcall_process): Avoid vfork clobbering
2417 the local vars buffer, coding_systems, current_dir.
2418
640c8776
SM
24192011-08-03 Stefan Monnier <monnier@iro.umontreal.ca>
2420
2421 * keymap.c (Fmake_composed_keymap): Move to subr.el.
2422
f26d0e4c
PE
24232011-08-03 Paul Eggert <eggert@cs.ucla.edu>
2424
8a10d76c
PE
2425 * fontset.c (dump_fontset) [FONTSET_DEBUG]: Declare EXTERNALLY_VISIBLE
2426 so that it is not optimized away.
2427
f26d0e4c
PE
2428 * xdisp.c (compute_display_string_pos): Remove unused local.
2429
55439c61
EZ
24302011-08-02 Eli Zaretskii <eliz@gnu.org>
2431
2432 Fix slow cursor motion and scrolling in large buffers with
2433 selective display, like Org Mode buffers. (Bug#9218)
2434
2435 * dispextern.h (struct bidi_it): New member disp_prop_p.
2436
2437 * xdisp.c: Remove one-slot cache of display string positions.
2438 (compute_display_string_pos): Accept an additional argument
5e617bc2 2439 DISP_PROP_P; callers changed. Scan at most 5K characters forward
55439c61
EZ
2440 for a display string or property. If found, set DISP_PROP_P
2441 non-zero.
2442
2443 * bidi.c (bidi_fetch_char): Accept an additional argument
640c8776
SM
2444 DISP_PROP_P, and pass it to compute_display_string_pos.
2445 Only handle text covered by a display string if DISP_PROP_P is returned
55439c61
EZ
2446 non-zero. All callers of bidi_fetch_char changed.
2447
fb33fa43
SM
24482011-08-02 Stefan Monnier <monnier@iro.umontreal.ca>
2449
2450 * keymap.c (Fdefine_key): Fix Lisp_Object/int mixup; apply some CSE.
2451
b099e063
DM
24522010-12-03 Don March <don@ohspite.net>
2453
2454 * keymap.c (Fdefine_key): Fix non-prefix key error message when
2455 last character M-[char] is translated to ESC [char] (bug#7541).
2456
5cc7f7af
KH
24572011-08-02 Kenichi Handa <handa@m17n.org>
2458
d0fffa3f 2459 * lisp.h (uniprop_table): Extern it.
5cc7f7af
KH
2460
2461 * chartab.c (uniprop_table): Make it non-static.
2462
525d5e6e
EZ
24632011-08-01 Eli Zaretskii <eliz@gnu.org>
2464
2465 * xdisp.c (forward_to_next_line_start): Accept additional argument
2466 BIDI_IT_PREV, and store into it the state of the bidi iterator had
2467 on the newline.
2468 (reseat_at_next_visible_line_start): Use the bidi iterator state
2469 returned by forward_to_next_line_start to restore the state of
2470 it->bidi_it after backing up to previous newline. (Bug#9212)
2471
31011111
AS
24722011-07-30 Andreas Schwab <schwab@linux-m68k.org>
2473
2474 * regex.c (re_comp): Protoize.
2475 (re_exec): Fix return type.
2476 (regexec): Fix type of `ret'. (Bug#9203)
2477
476371c4
PE
24782011-07-28 Paul Eggert <eggert@cs.ucla.edu>
2479
e5d76069
PE
2480 * image.c (check_image_size): Use 1024x1024 if unknown frame (Bug#9189).
2481 This is needed if max-image-size is a floating-point number.
2482
9a79b20c
AS
24832011-07-28 Andreas Schwab <schwab@linux-m68k.org>
2484
2485 * print.c (print_object): Print empty symbol as ##.
2486
2487 * lread.c (read1): Read ## as empty symbol.
2488
d8c2fa78
AA
24892011-07-28 Alp Aker <alp.tekin.aker@gmail.com>
2490
2491 * nsfns.m (x_set_foreground_color): Set f->foreground_pixel when
2492 setting frame foreground color (Bug#9175).
2493 (x_set_background_color): Likewise.
2494
ffe57a7a
AA
2495 * nsmenu.m (-setText): Size tooltip dimensions precisely to
2496 contents (Bug#9176).
2497 (EmacsTooltip -init): Remove bezels and add shadows to
2498 tooltip windows.
2499
bf3492a5
AA
2500 * nsterm.m (ns_dumpglyphs_stretch): Avoid overwriting left fringe
2501 or scroll bar (Bug#8470).
2502
d55e9c53
AA
2503 * nsfont.m (nsfont_open): Remove assignment to voffset and
2504 unnecessary vars hshink, expand, hd, full_height, min_height.
2505 (nsfont_draw): Use s->ybase as baseline for glyph drawing (Bug#8913).
2506
2507 * nsterm.h (nsfont_info): Remove voffset field.
2508
d8c2fa78 25092011-07-28 Alp Aker <alp.tekin.aker@gmail.com>
4843aac3
AA
2510
2511 Implement strike-through and overline on NextStep (Bug#8863).
2512
2513 * nsfont.m (nsfont_open): Use underline position provided by font,
2514 instead of hard-coded value of 2.
2515 (nsfont_draw): Call ns_draw_text_decoration instead.
2516
2517 * nsterm.h: Add declaration for ns_draw_text_decoration.
2518
2519 * nsterm.m (ns_draw_text_decoration): New function for drawing
2520 underline, overline, and strike-through.
2521 (ns_dumpglyphs_image, ns_dumpglyphs_stretch): Add call to
2522 ns_draw_text_decoration. Change treatment of cursor drawing to
8d5ed899 2523 accommodate underlining, etc.
4843aac3 2524
4cc60b9b
EZ
25252011-07-28 Eli Zaretskii <eliz@gnu.org>
2526
bc7ece87
EZ
2527 * buffer.c (init_buffer_once): Set bidi-display-reordering to t by
2528 default.
4cc60b9b 2529
476371c4
PE
25302011-07-28 Paul Eggert <eggert@cs.ucla.edu>
2531
66606eea
PE
2532 * alloc.c (memory_full) [!SYNC_INPUT]: Fix signal-related race.
2533 Without this fix, if a signal arrives just after memory fills up,
2534 'malloc' might be invoked reentrantly.
2535
476371c4
PE
2536 * image.c (x_check_image_size) [!HAVE_X_WINDOWS]: Return 1.
2537 In other words, assume that every image size is allowed, on non-X
2538 hosts. This assumption is probably wrong, but it lets Emacs compile.
2539
f3fcc40d
AS
25402011-07-28 Andreas Schwab <schwab@linux-m68k.org>
2541
2542 * regex.c (re_iswctype): Convert return values to boolean.
2543
350c992f
EZ
25442011-07-28 Eli Zaretskii <eliz@fencepost.gnu.org>
2545
2546 * xdisp.c (compute_display_string_pos): Don't use cached display
2547 string position if the buffer had its restriction changed.
2548 (Bug#9184)
2549
5266b4bb
PE
25502011-07-28 Paul Eggert <eggert@cs.ucla.edu>
2551
2552 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork clobbering.
2553
2573a837 25542011-07-28 Paul Eggert <eggert@cs.ucla.edu>
ca4aa935 2555
41f55ccd 2556 Integer signedness and overflow and related fixes. (Bug#9079)
cf950e6b 2557
39e378da
PE
2558 * bidi.c: Integer size and overflow fixes.
2559 (bidi_cache_size, bidi_cache_idx, bidi_cache_last_idx)
2560 (bidi_cache_start, bidi_cache_fetch_state, bidi_cache_search)
2561 (bidi_cache_find_level_change, bidi_cache_ensure_space)
2562 (bidi_cache_iterator_state, bidi_cache_find, bidi_cache_start_stack)
2563 (bidi_find_other_level_edge):
2564 Use ptrdiff_t instead of EMACS_INT where either will do.
2565 This works better on 32-bit hosts configured --with-wide-int.
2566 (bidi_cache_ensure_space): Check for size-calculation overflow.
2567 Use % rather than repeated addition, for better worst-case speed.
2568 Don't set bidi_cache_size until after xrealloc returns, because it
2569 might not return.
2570 (bidi_dump_cached_states): Use ptrdiff_t, not int, to avoid overflow.
f0eb61e9
PE
2571 (bidi_cache_ensure_space): Also check that the bidi cache size
2572 does not exceed that of the largest Lisp string or buffer. See Eli
2573 Zaretskii in <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=9079#29>.
39e378da 2574
5e927815
PE
2575 * alloc.c (__malloc_size_t): Remove.
2576 All uses replaced by size_t. See Andreas Schwab's note
2577 <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=9079#8>.
2578
ca4aa935
PE
2579 * image.c: Improve checking for integer overflow.
2580 (check_image_size): Assume that f is nonnull, since
2581 it is always nonnull in practice. This is one less thing to
2582 worry about when checking for integer overflow later.
2583 (x_check_image_size): New function, which checks for integer
2584 overflow issues inside X.
2585 (x_create_x_image_and_pixmap, xbm_read_bitmap_data): Use it.
2586 This removes the need for a memory_full check.
2587 (xbm_image_p): Rewrite to avoid integer multiplication overflow.
2588 (Create_Pixmap_From_Bitmap_Data, xbm_load): Use x_check_image_size.
2589 (xbm_read_bitmap_data): Change locals back to 'int', since
2590 their values must fit in 'int'.
2591 (xpm_load_image, png_load, tiff_load):
2592 Invoke x_create_x_image_and_pixmap earlier,
2593 to avoid much needless work if the image is too large.
2594 (tiff_load): Treat overly large images as if
2595 x_create_x_image_and_pixmap failed, not as malloc failures.
2596 (gs_load): Use x_check_image_size.
2597
5f8f9cc2
PE
2598 * gtkutil.c: Omit integer casts.
2599 (xg_get_pixbuf_from_pixmap): Remove unnecessary cast.
2600 (xg_set_toolkit_scroll_bar_thumb): Rewrite to avoid need for cast.
2601
5adf60bc
PE
2602 * image.c (png_load): Don't assume height * row_bytes fits in 'int'.
2603
c8907a93
PE
2604 * xfaces.c (Fbitmap_spec_p): Fix integer overflow bug.
2605 Without this fix, (bitmap-spec-p '(34359738368 1 "x"))
2606 would wrongly return t on a 64-bit host.
2607
e3c25c68
PE
2608 * dispnew.c (init_display): Use *_RANGE_OVERFLOW macros.
2609 The plain *_OVERFLOW macros run afoul of GCC bug 49705
2610 <http://gcc.gnu.org/bugzilla/show_bug.cgi?id=49705>
2611 and therefore cause GCC to emit a bogus diagnostic in some cases.
2612
3f791afe
PE
2613 * image.c: Integer signedness and overflow and related fixes.
2614 This is not an exhaustive set of fixes, but it's time to
2615 record what I've got.
2616 (lookup_pixel_color, check_image_size): Remove redundant decls.
2617 (check_image_size): Don't assume that arbitrary EMACS_INT values
2618 fit in 'int', or that arbitrary 'double' values fit in 'int'.
2619 (x_alloc_image_color, x_create_x_image_and_pixmap, png_load)
2620 (tiff_load, imagemagick_load_image):
2621 Check for overflow in size calculations.
2622 (x_create_x_image_and_pixmap): Remove unnecessary test for
2623 xmalloc returning NULL; that can't happen.
2624 (xbm_read_bitmap_data): Don't assume sizes fit into 'int'.
2625 (xpm_color_bucket): Use better integer hashing function.
2626 (xpm_cache_color): Don't possibly over-allocate memory.
2627 (struct png_memory_storage, tiff_memory_source, tiff_seek_in_memory)
2628 (gif_memory_source):
2629 Use ptrdiff_t, not int or size_t, to record sizes.
2630 (png_load): Don't assume values greater than 2**31 fit in 'int'.
2631 (our_stdio_fill_input_buffer): Prefer ptrdiff_t to size_t when
2632 either works, as we prefer signed integers.
2633 (tiff_read_from_memory, tiff_write_from_memory):
2634 Return tsize_t, not size_t, since that's what the TIFF API wants.
2635 (tiff_read_from_memory): Don't fail simply because the read would
2636 go past EOF; instead, return a short read.
2637 (tiff_load): Omit no-longer-needed casts.
2638 (Fimagemagick_types): Don't assume size fits into 'int'.
2639
3cc5a532
PE
2640 Improve hashing quality when configured --with-wide-int.
2641 * fns.c (hash_string): New function, taken from sxhash_string.
2642 Do not discard information about ASCII character case; this
2643 discarding is no longer needed.
2644 (sxhash-string): Use it. Change sig to match it. Caller changed.
2645 * lisp.h: Declare it.
2646 * lread.c (hash_string): Remove, since we now use fns.c's version.
2647 The fns.c version returns a wider integer if --with-wide-int is
2648 specified, so this should help the quality of the hashing a bit.
2649
b312a492
PE
2650 * emacs.c: Integer overflow minor fix.
2651 (heap_bss_diff): Now uprintmax_t, not unsigned long. All used changed.
2652 Define only if GNU_LINUX.
2653 (main, Fdump_emacs): Set and use heap_bss_diff only if GNU_LINUX.
2654
dfd153ae
PE
2655 * dispnew.c: Integer signedness and overflow fixes.
2656 Remove unnecessary forward decls, that were a maintenance hassle.
2657 (history_tick): Now uprintmax_t, so it's more likely to avoid overflow.
2658 All uses changed.
2659 (adjust_glyph_matrix, realloc_glyph_pool, adjust_frame_message_buffer)
2660 (scrolling_window): Use ptrdiff_t, not int, for byte count.
2661 (prepare_desired_row, line_draw_cost):
2662 Use int, not unsigned, where either works.
2663 (save_current_matrix, restore_current_matrix):
2664 Use ptrdiff_t, not size_t, where either works.
2665 (init_display): Check for overflow more accurately, and without
2666 relying on undefined behavior.
2667
a81d11a3
PE
2668 * editfns.c (pWIDE, pWIDElen, signed_wide, unsigned_wide):
2669 Remove, replacing with the new symbols in lisp.h. All uses changed.
2670 * fileio.c (make_temp_name):
2671 * filelock.c (lock_file_1, lock_file):
2672 * xdisp.c (message_dolog):
2673 Don't assume PRIdMAX etc. works; this isn't portable to pre-C99 hosts.
2674 Use pMd etc. instead.
2675 * lisp.h (printmax_t, uprintmax_t, pMd, pMu): New types and macros,
2676 replacing the pWIDE etc. symbols removed from editfns.c.
2677
3300e6fd
PE
2678 * keyboard.h (num_input_events): Now uintmax_t.
2679 This is (very slightly) less likely to mess up due to wraparound.
2680 All uses changed.
2681
fd05c7e9
PE
2682 * buffer.c: Integer signedness fixes.
2683 (alloc_buffer_text, enlarge_buffer_text):
2684 Use ptrdiff_t rather than size_t when either will do, as we prefer
2685 signed integers.
2686
903fe15d
PE
2687 * alloc.c: Integer signedness and overflow fixes.
2688 Do not impose an arbitrary 32-bit limit on malloc sizes when debugging.
2689 (__malloc_size_t): Default to size_t, not to int.
2690 (pure_size, pure_bytes_used_before_overflow, stack_copy_size)
2691 (Fgarbage_collect, mark_object_loop_halt, mark_object):
2692 Prefer ptrdiff_t to size_t when either would do, as we prefer
2693 signed integers.
2694 (XMALLOC_OVERRUN_CHECK_OVERHEAD): New macro.
2695 (xmalloc_overrun_check_header, xmalloc_overrun_check_trailer):
2696 Now const. Initialize with values that are in range even if char
2697 is signed.
2698 (XMALLOC_PUT_SIZE, XMALLOC_GET_SIZE): Remove, replacing with ...
2699 (xmalloc_put_size, xmalloc_get_size): New functions. All uses changed.
2700 These functions do the right thing with sizes > 2**32.
2701 (check_depth): Now ptrdiff_t, not int.
2702 (overrun_check_malloc, overrun_check_realloc, overrun_check_free):
2703 Adjust to new way of storing sizes. Check for size overflow bugs
2704 in rest of code.
2705 (STRING_BYTES_MAX): Adjust to new overheads. The old code was
2706 slightly wrong anyway, as it missed one instance of
2707 XMALLOC_OVERRUN_CHECK_OVERHEAD.
2708 (refill_memory_reserve): Omit needless cast to size_t.
2709 (mark_object_loop_halt): Mark as externally visible.
2710
ac82cc6a
PE
2711 * xselect.c: Integer signedness and overflow fixes.
2712 (Fx_register_dnd_atom, x_handle_dnd_message):
2713 Use ptrdiff_t, not size_t, since we prefer signed.
2714 (Fx_register_dnd_atom): Check for ptrdiff_t (and size_t) overflow.
2715 * xterm.h (struct x_display_info): Use ptrdiff_t, not size_t, for
2716 x_dnd_atoms_size and x_dnd_atoms_length.
2717
c2d1e36d
PE
2718 * doprnt.c: Prefer signed to unsigned when either works.
2719 * eval.c (verror):
2720 * doprnt.c (doprnt):
2721 * lisp.h (doprnt):
2722 * xdisp.c (vmessage):
2723 Use ptrdiff_t, not size_t, when using or implementing doprnt,
2724 since the sizes cannot exceed ptrdiff_t bounds anyway, and we
2725 prefer signed arithmetic to avoid comparison confusion.
2726 * doprnt.c (doprnt): Avoid a "+ 1" that can't overflow,
2727 but is a bit tricky.
2728
0e926e56
PE
2729 Assume freestanding C89 headers, string.h, stdlib.h.
2730 * data.c, doprnt.c, floatfns.c, print.c:
2731 Include float.h unconditionally.
2732 * gmalloc.c: Assume C89-at-least behavior for preprocessor,
2733 limits.h, stddef.h, string.h. Use memset instead of 'flood'.
2734 * regex.c: Likewise for stddef.h, string.h.
2735 (ISASCII): Remove; can assume it returns 1 now. All uses removed.
2736 * s/aix4-2.h (HAVE_STRING_H): Remove obsolete undef.
2737 * s/ms-w32.h (HAVE_LIMITS_H, HAVE_STRING_H, HAVE_STDLIB_H)
2738 (STDC_HEADERS): Remove obsolete defines.
2739 * sysdep.c: Include limits.h unconditionally.
2740
9cfdb3ec
PE
2741 Assume support for memcmp, memcpy, memmove, memset.
2742 * lisp.h, sysdep.c (memcmp, memcpy, memmove, memset):
2743 * regex.c (memcmp, memcpy):
2744 Remove; we assume C89 now.
2745
2746 * gmalloc.c (memcpy, memset, memmove): Remove; we assume C89 now.
2747 (__malloc_safe_bcopy): Remove; no longer needed.
2748
cf950e6b 2749 * lisp.h (struct vectorlike_header, struct Lisp_Subr): Signed sizes.
6089c567
PE
2750 Use EMACS_INT, not EMACS_UINT, for sizes. The code works equally
2751 well either way, and we prefer signed to unsigned.
2752
dbf38e02
LMI
27532011-07-27 Lars Magne Ingebrigtsen <larsi@gnus.org>
2754
2755 * gnutls.c (emacs_gnutls_read): Don't message anything if the peer
2756 closes the connection while we're reading (bug#9182).
2757
d6f0886c 27582011-07-25 Jan Djärv <jan.h.d@swipnet.se>
24e0f6b1 2759
d6f0886c
JD
2760 * nsmenu.m (ns_popup_dialog): Add an "ok" button if no buttons
2761 are specified (Bug#9168).
24e0f6b1 2762
2eb1f9e6
PE
27632011-07-25 Paul Eggert <eggert@cs.ucla.edu>
2764
2765 * bidi.c (bidi_dump_cached_states): Fix printf format mismatch.
2766 Found by GCC static checking and --with-wide-int on a 32-bit host.
2767
22381272 27682011-07-25 Eli Zaretskii <eliz@gnu.org>
7daee910
EZ
2769
2770 * xdisp.c (compute_display_string_pos): Fix logic of caching
2771 previous display string position. Initialize cached_prev_pos to
2772 -1. Fixes slow-down at the beginning of a buffer.
2773
f25e39b4
EZ
27742011-07-24 Eli Zaretskii <eliz@gnu.org>
2775
2776 * xfaces.c (check_lface_attrs) [HAVE_WINDOW_SYSTEM]: Allow `nil'
2777 for attrs[LFACE_FONTSET_INDEX].
2778
04c4b52e
PE
27792011-07-23 Paul Eggert <eggert@cs.ucla.edu>
2780
2781 * xml.c (parse_region): Remove unused local
2782 that was recently introduced.
2783
c1734fbd
EZ
27842011-07-23 Eli Zaretskii <eliz@gnu.org>
2785
be18c5a5
EZ
2786 * xfns.c (unwind_create_frame) [GLYPH_DEBUG]: Adapt to changes in
2787 2008-02-22T17:42:09Z!monnier@iro.umontreal.ca.
2788
c1734fbd
EZ
2789 * xdisp.c (move_it_in_display_line_to): Record the best matching
2790 position for TO_CHARPOS while scanning the line, and restore it on
640c8776
SM
2791 exit if none of the characters scanned was an exact match.
2792 Fixes vertical-motion and pos-visible-in-window-p under bidi redisplay
a9269c18
EZ
2793 when exact match is impossible due to invisible text, and the
2794 lines are truncated.
2795
a258d627
JD
27962011-07-23 Jan Djärv <jan.h.d@swipnet.se>
2797
2798 * nsterm.m (initFrameFromEmacs): Set NSTitledWindowMask in styleMask
2799 for OSX >= 10.7.
2800
b6d5a689
EZ
28012011-07-22 Eli Zaretskii <eliz@gnu.org>
2802
0f74f785
EZ
2803 Fix a significant slow-down of cursor motion with C-n, C-p,
2804 C-f/C-b, and C-v/M-v that couldn't keep up with keyboard
2805 auto-repeat under bidi redisplay in fontified buffers.
b6d5a689 2806 * xdisp.c (compute_stop_pos_backwards): New function.
b6d5a689
EZ
2807 (next_element_from_buffer): Call compute_stop_pos_backwards to
2808 find a suitable prev_stop when we find ourselves before
0f74f785
EZ
2809 base_level_stop.
2810 (reseat): Don't look for prev_stop, as that could mean a very long
2811 run.
2812 <cached_disp_pos, cached_disp_buffer, cached_disp_modiff>
2813 <cached_disp_overlay_modiff>: Cache for last found display string
2814 position.
551918c1 2815 (compute_display_string_pos): Return the cached position if asked
0f74f785
EZ
2816 about the same buffer in the same area of character positions, and
2817 the buffer wasn't changed since the time the display string
2818 position was cached.
551918c1 2819
b2d0c91a
EZ
28202011-07-22 Eli Zaretskii <eliz@gnu.org>
2821
2822 * xdisp.c (rows_from_pos_range): Don't ignore glyphs whose object
2823 is an integer, which is important for empty lines. (Bug#9149)
2824
043604ee
CY
28252011-07-22 Chong Yidong <cyd@stupidchicken.com>
2826
2827 * frame.c (Fmodify_frame_parameters): In tty case, update the
2828 default face if necessary (Bug#4238).
2829
da4adb04
CY
28302011-07-21 Chong Yidong <cyd@stupidchicken.com>
2831
2832 * editfns.c (Fstring_to_char): No need to explain what a character
2833 is in the docstring (Bug#6576).
2834
9abd0532
LMI
28352011-07-20 Lars Magne Ingebrigtsen <larsi@gnus.org>
2836
2837 * xml.c (parse_region): Make sure we always return a tree.
2838
36881d16
HK
28392011-07-20 HAMANO Kiyoto <khiker.mail@gmail.com>
2840
2841 * xml.c (parse_region): If a document contains only comments,
2842 return that, too.
2843
1e98674d
LMI
28442011-07-20 Lars Magne Ingebrigtsen <larsi@gnus.org>
2845
2846 * xml.c (make_dom): Return comments, too.
2847
590bd467
PE
28482011-07-19 Paul Eggert <eggert@cs.ucla.edu>
2849
2850 Port to OpenBSD.
2851 See http://lists.gnu.org/archive/html/emacs-devel/2011-07/msg00688.html
2852 and the surrounding thread.
2853 * minibuf.c (read_minibuf_noninteractive): Rewrite to use getchar
2854 rather than fgets, and retry after EINTR. Otherwise, 'emacs
2855 --batch -f byte-compile-file' fails on OpenBSD if an inactivity
2856 timer goes off.
2857 * s/openbsd.h (BROKEN_SIGIO): Define.
2858 * unexelf.c (unexec) [__OpenBSD__]:
2859 Don't update the .mdebug section of the Alpha COFF symbol table.
2860
f41628b2
LMI
28612011-07-19 Lars Magne Ingebrigtsen <larsi@gnus.org>
2862
2863 * lread.c (syms_of_lread): Clarify when `lexical-binding' is used
2864 (bug#8460).
2865
b59b67c5
PE
28662011-07-18 Paul Eggert <eggert@cs.ucla.edu>
2867
15e3a074
PE
2868 * fileio.c (Fcopy_file) [!MSDOS]: Tighten created file's mask.
2869 This fixes some race conditions on the permissions of any newly
2870 created file.
2871
41bed37d
PE
2872 * alloc.c (valid_pointer_p): Use pipe, not open.
2873 This fixes some permissions issues when debugging.
2874
b59b67c5
PE
2875 * fileio.c (Fcopy_file): Adjust mode if fchown fails. (Bug#9002)
2876 If fchown fails to set both uid and gid, try to set just gid,
2877 as that is sometimes allowed. Adjust the file's mode to eliminate
2878 setuid or setgid bits that are inappropriate if fchown fails.
2879
925a6be7
SM
28802011-07-18 Stefan Monnier <monnier@iro.umontreal.ca>
2881
2882 * xdisp.c (next_element_from_string, next_element_from_buffer): Use EQ
2883 to compare Lisp_Objects.
2884 * gnutls.c (syms_of_gnutls): Rename Vgnutls_log_level to
2885 global_gnutls_log_level, don't mistake it for a Lisp_Object.
2886 (init_gnutls_functions, emacs_gnutls_handle_error): Fix up uses.
2887
52968808
AS
28882011-07-17 Andreas Schwab <schwab@linux-m68k.org>
2889
0a6a104b
AS
2890 * lread.c (read_integer): Unread even EOF character.
2891 (read1): Likewise. Properly record start position of symbol.
2892
52968808
AS
2893 * lread.c (read1): Read `#:' as empty uninterned symbol if no
2894 symbol character follows.
2895
9e381cdd
PE
28962011-07-17 Paul Eggert <eggert@cs.ucla.edu>
2897
2898 * fileio.c (Fcopy_file): Pacify gcc re fchown. (Bug#9002)
2899 This works around a problem with the previous change to Fcopy_file.
2900 Recent glibc declares fchown with __attribute__((warn_unused_result)),
2901 and without this change, GCC might complain about discarding
2902 fchown's return value.
2903
b5641435
JB
29042011-07-16 Juanma Barranquero <lekktu@gmail.com>
2905
2906 * makefile.w32-in (GLOBAL_SOURCES): Add gnutls.c (followup to bug#9059).
2907
a8031457
PE
29082011-07-16 Paul Eggert <eggert@cs.ucla.edu>
2909
2910 * fileio.c (Fcopy_file): Don't diagnose fchown failures. (Bug#9002)
2911
dd889327
LMI
29122011-07-16 Lars Magne Ingebrigtsen <larsi@gnus.org>
2913
750c33f7
LMI
2914 * gnutls.c (syms_of_gnutls): Define `gnutls-log-level' here, since
2915 it's used from the C level.
2916
dd889327
LMI
2917 * process.c: Use the same condition for POLL_FOR_INPUT in both
2918 keyboard.c and process.c (bug#1858).
2919
87e86684
LM
29202011-07-09 Lawrence Mitchell <wence@gmx.li>
2921
2922 * gnutls.c (Qgnutls_bootprop_min_prime_bits): New variable.
2923 (Fgnutls_boot): Use it.
2924
64348f40
AS
29252011-07-15 Andreas Schwab <schwab@linux-m68k.org>
2926
2927 * doc.c (Fsubstitute_command_keys): Revert last change.
2928
1d698799
LMI
29292011-07-15 Lars Magne Ingebrigtsen <larsi@gnus.org>
2930
f863868c
LMI
2931 * doc.c (Fsubstitute_command_keys): Clarify that \= really only
2932 quotes the next character, and doesn't affect other longer
2933 sequences (bug#8935).
2934
1d698799
LMI
2935 * lread.c (syms_of_lread): Clarify that is isn't only
2936 `eval-buffer' and `eval-defun' that's affected by
2937 `lexical-binding' (bug#8460).
2938
aa4b6df6
EZ
29392011-07-15 Eli Zaretskii <eliz@gnu.org>
2940
2941 * xdisp.c (move_it_in_display_line_to): Fix vertical motion with
6b02f655 2942 bidi redisplay when a line includes both an image and is truncated.
aa4b6df6 2943
5d856da6
PE
29442011-07-14 Paul Eggert <eggert@cs.ucla.edu>
2945
ad6042bb
PE
2946 Fix minor problems found by static checking.
2947 * bidi.c (bidi_cache_size): Now EMACS_INT, not size_t.
2948 (elsz): Now a signed constant, not a size_t var. We prefer signed
2949 types to unsigned, to avoid integer comparison confusion. Without
2950 this change, GCC 4.6.1 with -Wunsafe-loop-optimizations complains
2951 "cannot optimize loop, the loop counter may overflow", a symptom
2952 of the confusion.
f00bbb22 2953 * indent.c (Fvertical_motion): Mark locals as initialized.
5d856da6
PE
2954 * xdisp.c (reseat_to_string): Fix pointer signedness issue.
2955
6468f31c
LMI
29562011-07-14 Lars Magne Ingebrigtsen <larsi@gnus.org>
2957
49080b10
LMI
2958 * search.c (Fre_search_backward): Mention `case-fold-search' in
2959 all the re_search_* functions (bug#8138).
2960
6468f31c
LMI
2961 * keyboard.c (Fopen_dribble_file): Document when the file is
2962 closed (bug#8056).
2963
c965adc5
EZ
29642011-07-14 Eli Zaretskii <eliz@gnu.org>
2965
df9733bf
EZ
2966 * bidi.c (bidi_dump_cached_states): Fix format of displaying
2967 bidi_cache_idx.
2968
0bb23927
EZ
2969 Support bidi reordering of display and overlay strings.
2970 * xdisp.c (compute_display_string_pos)
2971 (compute_display_string_end): Accept additional argument STRING.
2972 (init_iterator, reseat_1): Initialize bidi_it->string.s to NULL.
2973 (reseat_to_string): Initialize bidi_it->string.s and
2974 bidi_it->string.schars.
2975 (Fcurrent_bidi_paragraph_direction): Initialize itb.string.s to
640c8776
SM
2976 NULL (avoids a crash in bidi_paragraph_init).
2977 Initialize itb.string.lstring.
0bb23927
EZ
2978 (init_iterator): Call bidi_init_it only of a valid
2979 buffer position was specified. Initialize paragraph_embedding to
2980 L2R.
2981 (reseat_to_string): Initialize the bidi iterator.
2982 (display_string): If we need to ignore text properties of
2983 LISP_STRING, set IT->stop_charpos to IT->end_charpos. (The
2984 original value of -1 will not work with bidi.)
2985 (compute_display_string_pos): First arg is now struct
2986 `text_pos *'; all callers changed. Support display properties on
2987 Lisp strings.
2988 (compute_display_string_end): Support display properties on Lisp
2989 strings.
2990 (init_iterator, reseat_1, reseat_to_string): Initialize the
2991 string.bufpos member to 0 (zero, for compatibility with IT_CHARPOS
2992 when iterating on a string not from display properties).
640c8776
SM
2993 (compute_display_string_pos, compute_display_string_end):
2994 Fix calculation of the object to scan. Fixes an error when using
0bb23927
EZ
2995 arrow keys.
2996 (next_element_from_buffer): Don't abort when IT_CHARPOS is before
640c8776
SM
2997 base_level_stop; instead, set base_level_stop to BEGV.
2998 Fixes crashes in vertical-motion.
0bb23927
EZ
2999 (next_element_from_buffer): Improve commentary for when
3000 the iterator is before prev_stop.
3001 (init_iterator): Initialize bidi_p from the default value of
3002 bidi-display-reordering, not from buffer-local value. Use the
3003 buffer-local value only if initializing for buffer iteration.
3004 (handle_invisible_prop): Support invisible properties on strings
3005 that are being bidi-reordered.
3006 (set_iterator_to_next): Support bidi reordering of C strings and
3007 Lisp strings.
3008 (next_element_from_string): Support bidi reordering of Lisp
3009 strings.
3010 (handle_stop_backwards): Support Lisp strings as well.
640c8776
SM
3011 (display_string): Support display of R2L glyph rows.
3012 Use IT_STRING_CHARPOS when displaying from a Lisp string.
0bb23927
EZ
3013 (init_iterator): Don't initialize it->bidi_p for strings
3014 here.
3015 (reseat_to_string): Initialize it->bidi_p for strings here.
3016 (next_element_from_string, next_element_from_c_string)
3017 (next_element_from_buffer): Add xassert's for correspondence
3018 between IT's object being iterated and it->bidi_it.string
3019 structure.
3020 (face_before_or_after_it_pos): Support bidi iteration.
3021 (next_element_from_c_string): Handle the case of the first string
3022 character that is not the first one in the visual order.
3023 (get_visually_first_element): New function, refactored from common
3024 parts of next_element_from_buffer, next_element_from_string, and
3025 next_element_from_c_string.
3026 (tool_bar_lines_needed, redisplay_tool_bar)
3027 (display_menu_bar): Force left-to-right direction. Add a FIXME
3028 comment for making that be controlled by a user option.
3029 (push_it, pop_it): Save and restore the state of the
3030 bidi iterator. Save and restore the bidi_p flag.
3031 (pop_it): Iterate out of display property for string iteration as
3032 well.
3033 (iterate_out_of_display_property): Support iteration over strings.
3034 (handle_single_display_spec): Set up it->bidi_it for iteration
3035 over a display string, and call bidi_init_it.
3036 (handle_single_display_spec, next_overlay_string)
3037 (get_overlay_strings_1, push_display_prop): Set up the bidi
3038 iterator for displaying display or overlay strings.
3039 (forward_to_next_line_start): Don't use the shortcut if
3040 bidi-iterating.
3041 (back_to_previous_visible_line_start): If handle_display_prop
3042 pushed the iterator stack, restore the internal state of the bidi
3043 iterator by calling bidi_pop_it same number of times.
3044 (reseat_at_next_visible_line_start): If ON_NEWLINE_P is non-zero,
3045 and we are bidi-iterating, don't decrement the iterator position;
3046 instead, set the first_elt flag in the bidi iterator, to produce
3047 the same effect.
3048 (reseat_1): Remove redundant setting of string_from_display_prop_p.
3049 (push_display_prop): xassert that we are iterating a buffer.
3050 (push_it, pop_it): Save and restore paragraph_embedding member.
3051 (handle_single_display_spec, next_overlay_string)
3052 (get_overlay_strings_1, reseat_1, reseat_to_string)
3053 (push_display_prop): Set up the `unibyte' member of bidi_it.string
3054 correctly. Don't assume unibyte strings are not bidi-reordered.
3055 (compute_display_string_pos)
3056 (compute_display_string_end): Fix handling the case of C string.
3057 (push_it, pop_it): Save and restore from_disp_prop_p.
3058 (handle_single_display_spec, push_display_prop): Set the
3059 from_disp_prop_p flag.
3060 (get_overlay_strings_1): Reset the from_disp_prop_p flag.
3061 (pop_it): Call iterate_out_of_display_property only if we are
3062 popping after iteration over a string that came from a display
3063 property. Fix a typo in popping stretch info. Add an assertion
3064 for verifying that the iterator position is in sync with the bidi
3065 iterator.
3066 (handle_single_display_spec, get_overlay_strings_1)
3067 (push_display_prop): Fix initialization of paragraph direction for
3068 string when that of the parent object is not yet determined.
3069 (reseat_1): Call bidi_init_it to resync the bidi
3070 iterator with IT's position. (Bug#7616)
3071 (find_row_edges): If ROW->start.pos gives position
3072 smaller than min_pos, use it as ROW->minpos. (Bug#7616)
3073 (handle_stop, back_to_previous_visible_line_start, reseat_1):
3074 Reset the from_disp_prop_p flag.
3075 (SAVE_IT, RESTORE_IT): New macros.
3076 (pos_visible_p, face_before_or_after_it_pos)
3077 (back_to_previous_visible_line_start)
3078 (move_it_in_display_line_to, move_it_in_display_line)
3079 (move_it_to, move_it_vertically_backward, move_it_by_lines)
3080 (try_scrolling, redisplay_window, display_line): Use them when
3081 saving a temporary copy of the iterator and restoring it back.
3082 (back_to_previous_visible_line_start, reseat_1)
3083 (init_iterator): Empty the bidi cache "stack".
3084 (move_it_in_display_line_to): If iterator ended up at
3085 EOL, but we never saw any buffer positions smaller than
3086 to_charpos, return MOVE_POS_MATCH_OR_ZV. Fixes vertical cursor
3087 motion in bidi-reordered lines.
3088 (move_it_in_display_line_to): Record prev_method and prev_pos
3089 immediately before the call to set_iterator_to_next. Fixes cursor
3090 motion in bidi-reordered lines with stretch glyphs and strings
3091 displayed in margins. (Bug#8133) (Bug#8867)
3092 Return MOVE_POS_MATCH_OR_ZV only if iterator position is past
3093 TO_CHARPOS.
640c8776
SM
3094 (pos_visible_p): Support positions in bidi-reordered lines.
3095 Save and restore bidi cache.
0bb23927
EZ
3096
3097 * bidi.c (bidi_level_of_next_char): clen should be EMACS_NT, not int.
3098 (bidi_paragraph_info): Delete unused struct.
3099 (bidi_cache_idx, bidi_cache_last_idx): Declare EMACS_INT.
3100 (bidi_cache_start): New variable.
3101 (bidi_cache_reset): Reset bidi_cache_idx to bidi_cache_start, not
3102 to zero.
3103 (bidi_cache_fetch_state, bidi_cache_search)
3104 (bidi_cache_find_level_change, bidi_cache_iterator_state)
3105 (bidi_cache_find, bidi_peek_at_next_level)
3106 (bidi_level_of_next_char, bidi_find_other_level_edge)
3107 (bidi_move_to_visually_next): Compare cache index with
3108 bidi_cache_start rather than with zero.
3109 (bidi_fetch_char): Accept new argument STRING; all callers
3110 changed. Support iteration over a string. Support strings with
3111 display properties. Support unibyte strings. Fix the type of
3112 `len' according to what STRING_CHAR_AND_LENGTH expects.
3113 (bidi_paragraph_init, bidi_resolve_explicit_1)
3114 (bidi_resolve_explicit, bidi_resolve_weak)
640c8776
SM
3115 (bidi_level_of_next_char, bidi_move_to_visually_next):
3116 Support iteration over a string.
0bb23927
EZ
3117 (bidi_set_sor_type, bidi_resolve_explicit_1)
3118 (bidi_resolve_explicit, bidi_type_of_next_char): ignore_bn_limit
3119 can now be zero (for strings); special values 0 and -1 were
3120 changed to -1 and -2, respectively.
3121 (bidi_char_at_pos): New function.
3122 (bidi_paragraph_init, bidi_resolve_explicit, bidi_resolve_weak):
3123 Call it instead of FETCH_MULTIBYTE_CHAR.
3124 (bidi_move_to_visually_next): Abort if charpos or bytepos were not
3125 initialized to valid values.
3126 (bidi_init_it): Don't initialize charpos and bytepos with invalid
3127 values.
3128 (bidi_level_of_next_char): Allow the sentinel "position" to pass
3129 the test for valid cached positions. Fix the logic for looking up
3130 the sentinel state in the cache. GCPRO the Lisp string we are
3131 iterating.
3132 (bidi_push_it, bidi_pop_it): New functions.
3133 (bidi_initialize): Initialize the bidi cache start stack pointer.
3134 (bidi_cache_ensure_space): New function, refactored from part of
3135 bidi_cache_iterator_state. Don't assume the required size is just
3136 one BIDI_CACHE_CHUNK away.
3137 (bidi_cache_start_stack, bidi_push_it): Use IT_STACK_SIZE.
3138 (bidi_count_bytes, bidi_char_at_pos): New functions.
3139 (bidi_cache_search): Don't assume bidi_cache_last_idx is
3140 always valid if bidi_cache_idx is valid.
3141 (bidi_cache_find_level_change): xassert that bidi_cache_last_idx
3142 is valid if it's going to be used.
3143 (bidi_shelve_cache, bidi_unshelve_cache): New functions.
3144 (bidi_cache_fetch_state, bidi_cache_search)
c965adc5
EZ
3145 (bidi_cache_find_level_change, bidi_cache_ensure_space)
3146 (bidi_cache_iterator_state, bidi_cache_find)
640c8776
SM
3147 (bidi_find_other_level_edge, bidi_cache_start_stack):
3148 All variables related to cache indices are now EMACS_INT.
c965adc5 3149
0bb23927
EZ
3150 * dispextern.h (struct bidi_string_data): New structure.
3151 (struct bidi_it): New member `string'. Make flag members be 1-bit
3152 fields, and put them last in the struct.
640c8776
SM
3153 (compute_display_string_pos, compute_display_string_end):
3154 Update prototypes.
0bb23927
EZ
3155 (bidi_push_it, bidi_pop_it): Add prototypes.
3156 (struct iterator_stack_entry): New members bidi_p,
3157 paragraph_embedding, and from_disp_prop_p.
3158 (struct it): Member bidi_p is now a bit field 1 bit wide.
640c8776
SM
3159 (bidi_shelve_cache, bidi_unshelve_cache):
3160 Declare prototypes.
0bb23927
EZ
3161
3162 * .gdbinit (xvectype, xvector, xcompiled, xchartable, xboolvector)
3163 (xpr, xfont, xbacktrace): Use "header.size" when accessing vectors
3164 and vector-like objects.
3165
3166 * dispnew.c (buffer_posn_from_coords): Save and restore the bidi
3167 cache around display iteration.
3168
3169 * window.c (Fwindow_end, window_scroll_pixel_based)
3170 (displayed_window_lines, Frecenter): Save and restore the bidi
3171 cache around display iteration.
3172
3bbd2265
LMI
31732011-07-14 Lars Magne Ingebrigtsen <larsi@gnus.org>
3174
3175 * editfns.c (Fdelete_region): Clarify the use of the named
3176 parameters (bug#6788).
3177
adc47434
MR
31782011-07-14 Martin Rudalics <rudalics@gmx.at>
3179
3180 * indent.c (Fvertical_motion): Set and restore w->pointm when
3181 saving and restoring the window's buffer (Bug#9006).
3182
837c31f8
LMI
31832011-07-13 Lars Magne Ingebrigtsen <larsi@gnus.org>
3184
3185 * editfns.c (Fstring_to_char): Clarify just what is returned
3186 (bug#6576). Text by Eli Zaretskii.
3187
ac389d0c
JB
31882011-07-13 Juanma Barranquero <lekktu@gmail.com>
3189
3190 * gnutls.c (init_gnutls_functions): Honor gnutls_log_level (bug#9059).
3191
0be0ce47
EZ
31922011-07-13 Eli Zaretskii <eliz@gnu.org>
3193
3194 * buffer.c (mmap_find): Fix a typo.
3195
cd18e7e3
JB
31962011-07-13 Johan Bockgård <bojohan@gnu.org>
3197
3198 Fix execution of x selection hooks.
3199 * xselect.c (Qx_lost_selection_functions)
3200 (Qx_sent_selection_functions): New vars.
3201 (syms_of_xselect): DEFSYM them.
3202 (x_handle_selection_request): Pass Qx_sent_selection_functions
3203 rather than Vx_sent_selection_functions to Frun_hook_with_args.
3204 (x_handle_selection_clear,x_clear_frame_selections):
3205 Pass Qx_lost_selection_functions rather than
3206 Vx_lost_selection_functions to Frun_hook_with_args.
3207
47ea7f44
PE
32082011-07-13 Paul Eggert <eggert@cs.ucla.edu>
3209
ac389d0c 3210 * buffer.c (Fget_buffer_create): Initialize inhibit_shrinking.
2941c447
PE
3211 The old code sometimes used this field without initializing it.
3212
47ea7f44
PE
3213 * alloc.c (gc_sweep): Don't read past end of array.
3214 In theory, the old code could also have corrupted Emacs internals,
3215 though it'd be very unlikely.
3216
bc985c87
AS
32172011-07-12 Andreas Schwab <schwab@linux-m68k.org>
3218
3219 * character.c (Fcharacterp): Don't advertise optional ignored
ac389d0c 3220 argument. (Bug#4026)
bc985c87 3221
0cf34688
LMI
32222011-07-12 Lars Magne Ingebrigtsen <larsi@gnus.org>
3223
b3dadd76
LMI
3224 * keymap.c (syms_of_keymap): Clarify that "modifier" is "modifier
3225 key" (bug#4257).
3226
0cf34688
LMI
3227 * window.c (Fset_window_start): Doc fix (bug#4199).
3228 (Fset_window_hscroll): Ditto.
3229
270768cd
PE
32302011-07-12 Paul Eggert <eggert@cs.ucla.edu>
3231
077e3dda 3232 Fix minor new problems caught by GCC 4.6.1.
270768cd 3233 * term.c (init_tty): Remove unused local.
490011a6 3234 * xsettings.c (store_monospaced_changed): Define this function only
077e3dda 3235 if (defined HAVE_GSETTINGS || defined HAVE_GCONF), as it's
490011a6 3236 not used otherwise.
270768cd 3237
b1f58454
CY
32382011-07-12 Chong Yidong <cyd@stupidchicken.com>
3239
3240 * xdisp.c (Vresize_mini_windows): Minor doc fix (Bug#3300).
3241
22b9578d
LMI
32422011-07-11 Lars Magne Ingebrigtsen <larsi@gnus.org>
3243
6e70ab07
LMI
3244 * xdisp.c (syms_of_xdisp): Make it explicit that the mini-windows
3245 are the mini-buffer and the echo area (bug#3320).
3246
22b9578d
LMI
3247 * term.c (init_tty): Remove support for supdup, c10 and perq
3248 terminals, which are no longer supported (bug#1482).
3249
8974cc9f
JB
32502011-07-10 Johan Bockgård <bojohan@gnu.org>
3251
3252 * xdisp.c (Ftool_bar_lines_needed): Fix WINDOWP check.
3253
a560d974
JD
32542011-07-10 Jan Djärv <jan.h.d@swipnet.se>
3255
3256 * xmenu.c (menu_highlight_callback): Only pass frame to show_help_event
3257 for non-popups (Bug#3642).
3258
1dae0f0a
AS
32592011-07-10 Andreas Schwab <schwab@linux-m68k.org>
3260
268c2c36 3261 * alloc.c (reset_malloc_hooks): Protoize.
1dae0f0a 3262 * buffer.c (mmap_init, mmap_find, mmap_free_1, mmap_enlarge)
268c2c36
AS
3263 (mmap_set_vars, mmap_alloc, mmap_free, mmap_realloc): Likewise.
3264 * cm.c (losecursor): Likewise.
1dae0f0a
AS
3265 * data.c (fmod): Likewise.
3266 * dispnew.c (swap_glyphs_in_rows): Likewise.
3267 * emacs.c (memory_warning_signal): Likewise.
3268 * floatfns.c (float_error): Likewise.
3269 * font.c (check_gstring, check_otf_features, otf_tag_symbol)
3270 (otf_open, font_otf_capability, generate_otf_features)
3271 (font_otf_DeviceTable, font_otf_ValueRecord, font_otf_Anchor):
3272 Likewise.
3273 * image.c (pbm_read_file): Likewise.
3274 * indent.c (string_display_width): Likewise.
3275 * intervals.c (check_for_interval, search_for_interval)
3276 (inc_interval_count, count_intervals, root_interval)
3277 (adjust_intervals_for_insertion, make_new_interval): Likewise.
3278 * lread.c (defalias): Likewise.
268c2c36 3279 * ralloc.c (r_alloc_check): Likewise.
1dae0f0a
AS
3280 * regex.c (set_image_of_range_1, set_image_of_range)
3281 (regex_grow_registers): Likewise.
3282 * sysdep.c (strerror): Likewise.
3283 * termcap.c (valid_filename_p, tprint, main): Likewise.
3284 * tparam.c (main): Likewise.
3285 * unexhp9k800.c (run_time_remap, save_data_space)
3286 (update_file_ptrs, read_header, write_header, calculate_checksum)
3287 (copy_file, copy_rest, display_header): Likewise.
3288 * widget.c (mark_shell_size_user_specified, create_frame_gcs):
3289 Likewise.
3290 * xdisp.c (check_it): Likewise.
3291 * xfaces.c (register_color, unregister_color, unregister_colors):
3292 Likewise.
3293 * xfns.c (print_fontset_result): Likewise.
3294 * xrdb.c (member, fatal, main): Likewise.
3295
99033785
PE
32962011-07-10 Paul Eggert <eggert@cs.ucla.edu>
3297
3298 Fix minor problems found by static checking (Bug#9031).
3299 * chartab.c (char_table_set_range, map_sub_char_table):
3300 Remove unused locals.
3301 (uniprop_table): Now static.
3302 * composite.c (_work_char): Remove unused static var.
3303
9cb2ac56
JB
33042011-07-09 Juanma Barranquero <lekktu@gmail.com>
3305
3306 * chartab.c (uniprop_table_uncompress): Remove unused local variable.
3307
f25661f0
JD
33082011-07-09 Jan Djärv <jan.h.d@swipnet.se>
3309
3310 * gtkutil.c (qttip_cb): Remove code without function.
3311
8278c4fe
EZ
33122011-07-09 Eli Zaretskii <eliz@gnu.org>
3313
3314 * w32.c (pthread_sigmask): New stub.
3315
1692ae2d 33162011-07-08 Paul Eggert <eggert@cs.ucla.edu>
123403e4 3317
8a6ebd58 3318 Use pthread_sigmask, not sigprocmask (Bug#9010).
123403e4
PE
3319 sigprocmask is portable only for single-threaded applications, and
3320 Emacs can be multi-threaded when it uses GTK.
1301ac26
PE
3321 * Makefile.in (LIB_PTHREAD_SIGMASK): New macro.
3322 (LIBES): Use it.
3323 * callproc.c (Fcall_process):
3324 * process.c (create_process):
3325 * sysdep.c (sys_sigblock, sys_sigunblock, sys_sigsetmask):
3326 Use pthread_sigmask, not sigprocmask.
123403e4 3327
1b854618
JD
33282011-07-08 Jan Djärv <jan.h.d@swipnet.se>
3329
3330 * gtkutil.c (qttip_cb): Set line wrap to FALSE for tooltip widget.
3331 (xg_prepare_tooltip): Revert text in x->ttip_lbl, margins was
3332 wrong (Bug#8591).
3333
3fe4b549
JD
33342011-07-08 Jan Djärv <jan.h.d@swipnet.se>
3335
0ce7e563
JD
3336 * gtkutil.c (xg_prepare_tooltip): Fix indentation and comment.
3337 Put text in x->ttip_lbl instead of gtk_tooltip_set_text (Bug#8591).
3338 (xg_hide_tooltip): Fix comment.
3339
3fe4b549
JD
3340 * nsterm.m (initFrameFromEmacs): Don't use ns_return_types
3341 in registerServicesMenuSendTypes.
3342 (validRequestorForSendType): Don't check ns_return_types.
3343
3344 * nsfns.m (Fx_open_connection): Put NSStringPboardType into
3345 ns_return_type.
3346
5df75e47
JR
33472011-07-08 Jason Rumney <jasonr@gnu.org>
3348
3349 * w32fns.c (w32_wnd_proc) [WM_TIMER, WM_SET_CURSOR]: Avoid using
3350 frame struct members of non-existent frames (Bug#6284).
3351
699c10bd
JD
33522011-07-08 Jan Djärv <jan.h.d@swipnet.se>
3353
4393663b
JD
3354 * nsterm.m (keyDown): Call to wantsToDelayTextChangeNotifications and
3355 variable firstTime not needed on OSX >= 10.6.
3356 (setPosition): setFloatValue:knobProportion: is deprecated on OSX
3357 >= 10.5. Use setKnobProportion, setDoubleValue.
3358
3359 * nsterm.h (MAC_OS_X_VERSION_10_3, MAC_OS_X_VERSION_10_4)
3360 (MAC_OS_X_VERSION_10_5): Define if not defined.
3361 (EmacsView, EmacsTooltip): Implements NSWindowDelegate on OSX >= 10.6.
3362 (EmacsMenu): Implements NSMenuDelegate on OSX >= 10.6.
3363 (EmacsToolbar): Implements NSToolbarDelegate on OSX >= 10.6.
3364
3365 * nsselect.m (ns_string_from_pasteboard): Don't use deprecated methods
3366 cString and lossyCString on OSX >= 10.4
3367
3368 * nsmenu.m (fillWithWidgetValue): Don't use depercated method
3369 sizeToFit on OSX >= 10.2.
3370
3371 * nsimage.m (allocInitFromFile): Don't use deprecated method
3372 bestRepresentationForDevice on OSX >= 10.6.
3373
3374 * nsfns.m (check_ns_display_info): Cast to long and use %ld in error
3375 to avoid warning.
3376
3377 * emacs.c: Declare unexec_init_emacs_zone.
3378
a63e0781
JD
3379 * nsgui.h: Fix compiler warning about gnulib redefining verify.
3380
699c10bd
JD
3381 * nsselect.m (ns_get_local_selection): Change to extern (Bug#8842).
3382
3383 * nsmenu.m (ns_update_menubar): Remove useless setDelegate call
3384 on svcsMenu (Bug#8842).
3385
3386 * nsfns.m (Fx_open_connection): Remove NSStringPboardType from
3387 ns_return_types.
3388 (Fns_list_services): Just return Qnil on 10.6, code not working there.
3389
3390 * nsterm.m (QUTF8_STRING): Declare.
3391 (initFrameFromEmacs): Call registerServicesMenuSendTypes.
3392 (validRequestorForSendType): Return type is (id).
3393 Change indexOfObjectIdenticalTo to indexOfObject.
3394 Check if we have local selection before returning self (Bug#8842).
3395 (writeSelectionToPasteboard): Put local selection into paste board
3396 if we have a local selection (Bug#8842).
3397 (syms_of_nsterm): DEFSYM QUTF8_STRING.
3398
3399 * nsterm.h (MAC_OS_X_VERSION_10_6): Define here instead of nsterm.m.
3400 (ns_get_local_selection): Declare.
3401
54e10184
LMI
34022011-07-07 Lars Magne Ingebrigtsen <larsi@gnus.org>
3403
9888ff71
LMI
3404 * keymap.c (describe_map_tree): Don't insert a double newline at
3405 the end of the buffer (bug#1169) and return whether we inserted
3406 something.
3407
54e10184
LMI
3408 * callint.c (Fcall_interactively): Change "reading args" to
3409 "providing args" to try to clarify what it does (bug#1010).
3410
15fa4783
KH
34112011-07-07 Kenichi Handa <handa@m17n.org>
3412
3413 * composite.c (composition_compute_stop_pos): Ignore a static
3414 composition starting before CHARPOS (Bug#8915).
3415
3416 * xdisp.c (handle_composition_prop): Likewise.
3417
a8815b00
EZ
34182011-07-07 Eli Zaretskii <eliz@gnu.org>
3419
3420 * term.c (produce_glyphs) <xassert>: Allow IT_GLYPHLESS in it->what.
3421 (Bug#9015)
3422
ef7b981d 34232011-07-07 Kenichi Handa <handa@m17n.org>
c805dec0
KH
3424
3425 * character.h (unicode_category_t): New enum type.
3426
3427 * chartab.c (uniprop_decoder_t, uniprop_encoder_t): New types.
3428 (Qchar_code_property_table): New variable.
3429 (UNIPROP_TABLE_P, UNIPROP_GET_DECODER)
3430 (UNIPROP_COMPRESSED_FORM_P): New macros.
3431 (char_table_ascii): Uncompress the compressed values.
3432 (sub_char_table_ref): New arg is_uniprop. Callers changed.
3433 Uncompress the compressed values.
ac389d0c 3434 (sub_char_table_ref_and_range): Likewise.
c805dec0
KH
3435 (char_table_ref_and_range): Uncompress the compressed values.
3436 (sub_char_table_set): New arg is_uniprop. Callers changed.
3437 Uncompress the compressed values.
3438 (sub_char_table_set_range): Args changed. Callers changed.
3439 (char_table_set_range): Adjuted for the above change.
3440 (map_sub_char_table): Delete args default_val and parent. Add arg
3441 top. Give decoded values to a Lisp function.
640c8776 3442 (map_char_table): Adjust for the above change. Give decoded
c805dec0
KH
3443 values to a Lisp function. Gcpro more variables.
3444 (uniprop_table_uncompress)
3445 (uniprop_decode_value_run_length): New functions.
3446 (uniprop_decoder, uniprop_decoder_count): New variables.
3447 (uniprop_get_decoder, uniprop_encode_value_character)
3448 (uniprop_encode_value_run_length, uniprop_encode_value_numeric):
3449 New functions.
3450 (uniprop_encoder, uniprop_encoder_count): New variables.
3451 (uniprop_get_encoder, uniprop_table)
3452 (Funicode_property_table_internal, Fget_unicode_property_internal)
3453 (Fput_unicode_property_internal): New functions.
3454 (syms_of_chartab): DEFSYM Qchar_code_property_table, defsubr
3455 Sunicode_property_table_internal, Sget_unicode_property_internal,
5e617bc2 3456 and Sput_unicode_property_internal. Defvar_lisp
c805dec0
KH
3457 char-code-property-alist.
3458
640c8776 3459 * composite.c (CHAR_COMPOSABLE_P): Adjust for the change of
c805dec0
KH
3460 Vunicode_category_table.
3461
640c8776 3462 * font.c (font_range): Adjust for the change of
c805dec0
KH
3463 Vunicode_category_table.
3464
76b397fb
DN
34652011-07-07 Dan Nicolaescu <dann@ics.uci.edu>
3466
3467 * m/iris4d.h: Remove file, move contents ...
3468 * s/irix6-5.h: ... here.
3469
22b4128e
PE
34702011-07-06 Paul Eggert <eggert@cs.ucla.edu>
3471
3472 Remove unportable assumption about struct layout (Bug#8884).
8a5c77bb
PE
3473 * alloc.c (mark_buffer):
3474 * buffer.c (reset_buffer_local_variables, Fbuffer_local_variables)
3475 (clone_per_buffer_values): Don't assume that
22b4128e
PE
3476 sizeof (struct buffer) is a multiple of sizeof (Lisp_Object).
3477 This isn't true in general, and it's particularly not true
3478 if Emacs is configured with --with-wide-int.
3479 * buffer.h (FIRST_FIELD_PER_BUFFER, LAST_FIELD_PER_BUFFER):
3480 New macros, used in the buffer.c change.
3481
869795d6
JD
34822011-07-05 Jan Djärv <jan.h.d@swipnet.se>
3483
3484 * xsettings.c: Use both GConf and GSettings if both are available.
3485 (store_config_changed_event): Add comment.
3486 (dpyinfo_valid, store_font_name_changed, map_tool_bar_style)
3487 (store_tool_bar_style_changed): New functions.
5e617bc2 3488 (store_monospaced_changed): Add comment. Call dpyinfo_valid.
869795d6
JD
3489 (struct xsettings): Move font inside HAVE_XFT.
3490 (GSETTINGS_TOOL_BAR_STYLE, GSETTINGS_FONT_NAME): New defines.
640c8776 3491 (GSETTINGS_MONO_FONT): Rename from SYSTEM_MONO_FONT.
869795d6 3492 Move inside HAVE_XFT.
640c8776 3493 (something_changed_gsettingsCB): Rename from something_changedCB.
869795d6
JD
3494 Check for changes in GSETTINGS_TOOL_BAR_STYLE and GSETTINGS_FONT_NAME
3495 also.
3496 (GCONF_TOOL_BAR_STYLE, GCONF_FONT_NAME): New defines.
5e617bc2 3497 (GCONF_MONO_FONT): Rename from SYSTEM_MONO_FONT. Move inside HAVE_XFT.
640c8776 3498 (something_changed_gconfCB): Rename from something_changedCB.
869795d6
JD
3499 Check for changes in GCONF_TOOL_BAR_STYLE and GCONF_FONT_NAME also.
3500 (parse_settings): Move check for font inside HAVE_XFT.
3501 (read_settings, apply_xft_settings): Add comment.
3502 (read_and_apply_settings): Add comment. Call map_tool_bar_style and
3503 store_tool_bar_style_changed. Move check for font inside HAVE_XFT and
3504 call store_font_name_changed.
3505 (xft_settings_event): Add comment.
3506 (init_gsettings): Add comment. Get values for GSETTINGS_TOOL_BAR_STYLE
3507 and GSETTINGS_FONT_NAME. Move check for fonts within HAVE_XFT.
3508 (init_gconf): Add comment. Get values for GCONF_TOOL_BAR_STYLE
3509 and GCONF_FONT_NAME. Move check for fonts within HAVE_XFT.
3510 (xsettings_initialize): Call init_gsettings last.
640c8776
SM
3511 (xsettings_get_system_font, xsettings_get_system_normal_font):
3512 Add comment.
869795d6 3513
d8ed26bd
PE
35142011-07-05 Paul Eggert <eggert@cs.ucla.edu>
3515
3516 Random fixes. E.g., (random) never returned negative values.
3517 * fns.c (Frandom): Use GET_EMACS_TIME for random seed, and add the
3518 subseconds part to the entropy, as that's a bit more random.
3519 Prefer signed to unsigned, since the signedness doesn't matter and
3520 in general we prefer signed. When given a limit, use a
3521 denominator equal to INTMASK + 1, not to VALMASK + 1, because the
3522 latter isn't right if USE_2_TAGS_FOR_INTS.
3523 * sysdep.c (get_random): Return a value in the range 0..INTMASK,
3524 not 0..VALMASK. Don't discard "excess" bits that random () returns.
3525
cabf1cac
SM
35262011-07-04 Stefan Monnier <monnier@iro.umontreal.ca>
3527
3528 * textprop.c (text_property_stickiness):
3529 Obey Vtext_property_default_nonsticky.
3530 (syms_of_textprop): Add `display' to Vtext_property_default_nonsticky.
3531 * w32fns.c (syms_of_w32fns):
3532 * xfns.c (syms_of_xfns): Don't Add `display' since it's there by default.
3533
6e9b2be9
PE
35342011-07-04 Paul Eggert <eggert@cs.ucla.edu>
3535
3536 * fileio.c (barf_or_query_if_file_exists): Use S_ISDIR.
3537 This is more efficient than Ffile_directory_p and avoids a minor race.
3538
90186c68
LMI
35392011-07-04 Lars Magne Ingebrigtsen <larsi@gnus.org>
3540
7c301272
LMI
3541 * buffer.c (Foverlay_put): Say what the return value is
3542 (bug#7835).
3543
c4f2d8d4
LMI
3544 * fileio.c (barf_or_query_if_file_exists): Check first if the file
3545 is a directory before asking whether to use the file name
3546 (bug#7564).
ad637907
LMI
3547 (barf_or_query_if_file_exists): Make the "File is a directory"
3548 error be more correct.
c4f2d8d4 3549
90186c68
LMI
3550 * fns.c (Frequire): Remove the mention of the .gz files, since
3551 that's installation-specific, but keep the mention of
3552 `get-load-suffixes'.
3553
da64016e
PE
35542011-07-04 Paul Eggert <eggert@cs.ucla.edu>
3555
3556 * editfns.c (Fformat_time_string): Don't assume strlen fits in int.
3557 Report string overflow if the output is too long.
3558
7d47b580
JB
35592011-07-04 Juanma Barranquero <lekktu@gmail.com>
3560
a555cb87
JB
3561 * gnutls.c (Fgnutls_boot): Don't mention :verify-error.
3562 (syms_of_gnutls): Remove duplicate DEFSYM for
3563 Qgnutls_bootprop_verify_hostname_error, an error for
3564 Qgnutls_bootprop_verify_error (which is no longer used).
3565
7d47b580
JB
3566 * eval.c (find_handler_clause): Remove parameters `sig' and `data',
3567 unused since 2011-01-26T20:02:07Z!monnier@iro.umontreal.ca. All callers changed.
3568 Also (re)move comments that are misplaced or no longer relevant.
3569
1e49bfab
LMI
35702011-07-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
3571
3572 * callint.c (Finteractive): Clarify the meaning of "@" (bug#8813).
3573
1485f4c0
CY
35742011-07-03 Chong Yidong <cyd@stupidchicken.com>
3575
3576 * xfaces.c (Finternal_merge_in_global_face): Modify the foreground
3577 and background color parameters if they have been changed.
3578
a9ab721e
LMI
35792011-07-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
3580
3581 * editfns.c (Fformat): Clarify the - and 0 flags (bug#6659).
3582
cf7cff57
PE
35832011-07-03 Paul Eggert <eggert@cs.ucla.edu>
3584
2e13213d
PE
3585 * xsettings.c (SYSTEM_FONT): Define only when used.
3586 No need to define when HAVE_GSETTINGS || !HAVE_XFT.
3587
cf7cff57
PE
3588 * keymap.c (access_keymap_1): Now static.
3589
7a8e04f7
CY
35902011-07-02 Chong Yidong <cyd@stupidchicken.com>
3591
3592 * keyboard.c (command_loop_1): If a down-mouse event is unbound,
3593 leave any prefix arg for the up event (Bug#1586).
3594
61352f62
LMI
35952011-07-02 Lars Magne Ingebrigtsen <larsi@gnus.org>
3596
69bb1ef7
LMI
3597 * lread.c (syms_of_lread): Mention single symbols defined by
3598 `defvar' or `defconst' (bug#7154).
3599
61352f62 3600 * fns.c (Frequire): Mention .el.gz files (bug#7314).
7b3747f9 3601 (Frequire): Mention get-load-suffixes.
61352f62 3602
28545e04
MR
36032011-07-02 Martin Rudalics <rudalics@gmx.at>
3604
3605 * window.h (window): Remove clone_number slot.
3606 * window.c (Fwindow_clone_number, Fset_window_clone_number):
3607 Remove.
3608 (make_parent_window, make_window, saved_window)
3609 (Fset_window_configuration, save_window_save): Don't deal with
3610 clone numbers.
3611 * buffer.c (Qclone_number): Remove declaration.
3612 (sort_overlays, overlay_strings): Don't deal with clone numbers.
3613
3349e122
SM
36142011-07-02 Stefan Monnier <monnier@iro.umontreal.ca>
3615
3616 Add multiple inheritance to keymaps.
3617 * keymap.c (Fmake_composed_keymap): New function.
3618 (Fset_keymap_parent): Simplify.
3619 (fix_submap_inheritance): Remove.
3620 (access_keymap_1): New function extracted from access_keymap to handle
3621 embedded parents and handle lists of maps.
3622 (access_keymap): Use it.
3623 (Fkeymap_prompt, map_keymap_internal, map_keymap, store_in_keymap)
3624 (Fcopy_keymap): Handle embedded parents.
3625 (Fcommand_remapping, define_as_prefix): Simplify.
3626 (Fkey_binding): Simplify.
3627 (syms_of_keymap): Move minibuffer-local-completion-map,
3628 minibuffer-local-filename-completion-map,
3629 minibuffer-local-must-match-map, and
3630 minibuffer-local-filename-must-match-map to Elisp.
3631 (syms_of_keymap): Defsubr make-composed-keymap.
3632 * keyboard.c (menu_bar_items): Use map_keymap_canonical.
3633 (parse_menu_item): Trivial simplification.
3634
3279eb87
GM
36352011-07-01 Glenn Morris <rgm@gnu.org>
3636
3637 * Makefile.in (SETTINGS_LIBS): Fix typo.
3638
4550efdf
KI
36392011-07-01 Kazuhiro Ito <kzhr@d1.dion.ne.jp> (tiny patch)
3640
3641 * coding.c (Fencode_coding_string): Record the last coding system
3642 used, as the function doc string says (bug#8738).
3643
0949d2b6
JD
36442011-07-01 Jan Djärv <jan.h.d@swipnet.se>
3645
3646 * xsettings.c (store_monospaced_changed): Take new font as arg and
3647 check for change against current_mono_font.
3648 (EMACS_TYPE_SETTINGS): Remove this and related defines.
3649 (emacs_settings_constructor, emacs_settings_get_property)
3650 (emacs_settings_set_property, emacs_settings_class_init)
3651 (emacs_settings_init, gsettings_obj): Remove.
3652 (something_changedCB): New function for HAVE_GSETTINGS.
3653 (something_changedCB): HAVE_GCONF: Call store_monospaced_changed
3654 with value as argument.
3655 (init_gsettings): Check that GSETTINGS_SCHEMA exists before calling
3656 g_settings_new (Bug#8967). Do not create gsettings_obj.
9173deec 3657 Remove calls to g_settings_bind. Connect something_changedCB to
0949d2b6
JD
3658 "changed".
3659
3660 * xgselect.c: Add defined (HAVE_GSETTINGS).
3661 (xgselect_initialize): Ditto.
3662
3663 * process.c: Add defined (HAVE_GSETTINGS) for xgselect.h
3664 (wait_reading_process_output): Add defined (HAVE_GSETTINGS) for
3665 xg_select.
3666
bbc6b304
PE
36672011-07-01 Paul Eggert <eggert@cs.ucla.edu>
3668
3669 * eval.c (struct backtrace): Simplify and port the data structure.
3670 Do not assume that "int nargs : BITS_PER_INT - 2;" produces a
3671 signed bit field, as this assumption is not portable and it makes
3672 Emacs crash when compiled with Sun C 5.8 on sparc. Do not use
3673 "char debug_on_exit : 1" as this is not portable either; instead,
3674 use the portable "unsigned int debug_on_exit : 1". Remove unused
3675 member evalargs. Remove obsolete comments about cc bombing out.
3676
9851bfc5
JD
36772011-06-30 Jan Djärv <jan.h.d@swipnet.se>
3678
51bb811f 3679 * xsettings.c: Include glib-object.h, gio/gio.h if HAVE_GSETTINGS.
9851bfc5
JD
3680 Let HAVE_GSETTINGS override HAVE_GCONF.
3681 (store_monospaced_changed): New function.
3682 (EMACS_SETTINGS): A new type derived from GObject to handle
3683 GSettings notifications.
3684 (emacs_settings_constructor, emacs_settings_get_property)
3685 (emacs_settings_set_property, emacs_settings_class_init):
3686 New functions.
3687 (gsettings_client, gsettings_obj): New variables.
3688 (GSETTINGS_SCHEMA): New define.
3689 (something_changedCB): Call store_monospaced_changed.
3690 (init_gsettings): New function.
3691 (xsettings_initialize): Call init_gsettings.
3692 (syms_of_xsettings): Initialize gsettings_client, gsettings_obj
3693 to NULL.
3694
640c8776 3695 * Makefile.in (SETTINGS_CFLAGS, SETTINGS_LIBS): Rename from
9851bfc5
JD
3696 GCONF_CFLAGS/LIBS.
3697
5386012d
MR
36982011-06-29 Martin Rudalics <rudalics@gmx.at>
3699
3700 * window.c (resize_root_window, grow_mini_window)
3701 (shrink_mini_window): Rename Qresize_root_window to
3702 Qwindow_resize_root_window and Qresize_root_window_vertically to
3703 Qwindow_resize_root_window_vertically.
3704
f13e0b08
PE
37052011-06-28 Paul Eggert <eggert@cs.ucla.edu>
3706
3707 * gnutls.c (Qgnutls_bootprop_verify_error): Remove unused var.
3708
94515237
JB
37092011-06-27 Juanma Barranquero <lekktu@gmail.com>
3710
3711 * makefile.w32-in: Redesign dependencies so they reflect more
3712 clearly which files are directly included by each source file,
3713 and not through other includes.
3714
e43b6e43
MR
37152011-06-27 Martin Rudalics <rudalics@gmx.at>
3716
3717 * buffer.c (Qclone_number): Declare static and DEFSYM it.
3718 (sort_overlays, overlay_strings): When an overlay's clone number
3719 matches the window's clone number process the overlay even if
3720 the overlay's window property doesn't match the current window.
3721
d68443dc
MR
3722 * window.c (Fwindow_vchild): Rename to Fwindow_top_child.
3723 (Fwindow_hchild): Rename to Fwindow_left_child.
3724 (Fwindow_next): Rename to Fwindow_next_sibling.
3725 (Fwindow_prev): Rename to Fwindow_prev_sibling.
d615d6d2
MR
3726 (resize_window_check): Rename to window_resize_check.
3727 (resize_window_apply): Rename to window_resize_apply.
3728 (Fresize_window_apply): Rename to Fwindow_resize_apply.
3729 (Fdelete_other_windows_internal, resize_frame_windows)
3730 (Fsplit_window_internal, Fdelete_window_internal)
3731 (grow_mini_window, shrink_mini_window)
3732 (Fresize_mini_window_internal): Fix callers accordingly.
d68443dc 3733
c7e73be5
JD
37342011-06-26 Jan Djärv <jan.h.d@swipnet.se>
3735
3736 * emacsgtkfixed.h: State that this is only used with Gtk+3.
3737 (emacs_fixed_set_min_size): Remove.
3738 (emacs_fixed_new): Take frame as argument.
3739
3740 * emacsgtkfixed.c: State that this is only used with Gtk+3.
3741 (_EmacsFixedPrivate): Remove minwidth/height.
3742 Add struct frame *f.
3743 (emacs_fixed_init): Initialize priv->f.
3744 (get_parent_class, emacs_fixed_set_min_size): Remove.
3745 (emacs_fixed_new): Set priv->f to argument.
3746 (emacs_fixed_get_preferred_width)
3747 (emacs_fixed_get_preferred_height): Use min_width/height from
3748 frames size_hint to set minimum and natural (Bug#8919).
3749 (XSetWMSizeHints, XSetWMNormalHints): Override these functions
3750 and use min_width/height from frames size_hint to set
3751 min_width/height (Bug#8919).
3752
3753 * gtkutil.c (xg_create_frame_widgets): Pass f to emacs_fixed_new.
9173deec
JB
3754 (x_wm_set_size_hint): Remove call to emacs_fixed_set_min_size.
3755 Fix indentation.
c7e73be5 3756
cf99dcf8
EZ
37572011-06-26 Eli Zaretskii <eliz@gnu.org>
3758
3759 * bidi.c (bidi_paragraph_init): Test for ZV_BYTE before calling
3760 bidi_at_paragraph_end, since fast_looking_at doesn't like to be
3761 called at ZV.
3762
029529ac
CY
37632011-06-26 Chong Yidong <cyd@stupidchicken.com>
3764
3765 * process.c (wait_reading_process_output): Bypass select if
3766 waiting for a cell while ignoring keyboard input, and input is
3767 pending. Suggested by Jan Djärv (Bug#8869).
3768
7a7ef429
PE
37692011-06-25 Paul Eggert <eggert@cs.ucla.edu>
3770
3771 Use gnulib's dup2 module instead of rolling our own.
3772 * sysdep.c (dup2) [!HAVE_DUP2]: Remove; gnulib now does this.
3773
11fdef7d 37742011-06-25 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
989b42d2
YM
3775
3776 * dispnew.c (scrolling_window): Before scrolling, turn off a
3777 mouse-highlight in the window being scrolled.
3778
cd3520a4
JB
37792011-06-24 Juanma Barranquero <lekktu@gmail.com>
3780
3781 Move DEFSYM to lisp.h and use everywhere.
3782
3783 * character.h (DEFSYM): Move declaration...
3784 * lisp.h (DEFSYM): ...here.
3785
3786 * gnutls.c:
3787 * minibuf.c:
3788 * w32menu.c:
3789 * w32proc.c:
3790 * w32select.c: Don't include character.h.
3791
3792 * alloc.c (syms_of_alloc):
3793 * buffer.c (syms_of_buffer):
3794 * bytecode.c (syms_of_bytecode):
3795 * callint.c (syms_of_callint):
3796 * casefiddle.c (syms_of_casefiddle):
3797 * casetab.c (init_casetab_once):
3798 * category.c (init_category_once, syms_of_category):
3799 * ccl.c (syms_of_ccl):
3800 * cmds.c (syms_of_cmds):
3801 * composite.c (syms_of_composite):
3802 * dbusbind.c (syms_of_dbusbind):
3803 * dired.c (syms_of_dired):
3804 * dispnew.c (syms_of_display):
3805 * doc.c (syms_of_doc):
3806 * editfns.c (syms_of_editfns):
3807 * emacs.c (syms_of_emacs):
3808 * eval.c (syms_of_eval):
3809 * fileio.c (syms_of_fileio):
3810 * fns.c (syms_of_fns):
3811 * frame.c (syms_of_frame):
3812 * fringe.c (syms_of_fringe):
3813 * insdel.c (syms_of_insdel):
3814 * keymap.c (syms_of_keymap):
3815 * lread.c (init_obarray, syms_of_lread):
3816 * macros.c (syms_of_macros):
3817 * msdos.c (syms_of_msdos):
3818 * print.c (syms_of_print):
3819 * process.c (syms_of_process):
3820 * search.c (syms_of_search):
3821 * sound.c (syms_of_sound):
3822 * syntax.c (init_syntax_once, syms_of_syntax):
3823 * terminal.c (syms_of_terminal):
3824 * textprop.c (syms_of_textprop):
3825 * undo.c (syms_of_undo):
3826 * w32.c (globals_of_w32):
3827 * window.c (syms_of_window):
3828 * xdisp.c (syms_of_xdisp):
3829 * xfaces.c (syms_of_xfaces):
3830 * xfns.c (syms_of_xfns):
3831 * xmenu.c (syms_of_xmenu):
3832 * xsettings.c (syms_of_xsettings):
3833 * xterm.c (syms_of_xterm): Use DEFSYM.
3834
4228cf16
TZ
38352011-06-24 Teodor Zlatanov <tzz@lifelogs.com>
3836
cd3520a4 3837 * gnutls.c (syms_of_gnutls): Use the DEFSYM macro from character.h.
4228cf16 3838
7fcccf1e
PE
38392011-06-23 Paul Eggert <eggert@cs.ucla.edu>
3840
7efb4e0e
PE
3841 Integer and buffer overflow fixes (Bug#8873).
3842
ff5844ad
PE
3843 * print.c (printchar, strout): Check for string overflow.
3844 (PRINTPREPARE, printchar, strout):
3845 Don't set size unless allocation succeeds.
3846
90532f02
PE
3847 * minibuf.c (read_minibuf_noninteractive): Use ptrdiff_t, not int,
3848 for sizes. Check for string overflow more accurately.
3849 Simplify newline removal at end; this suppresses a GCC 4.6.0 warning.
3850
6d84508d
PE
3851 * macros.c: Integer and buffer overflow fixes.
3852 * keyboard.h (struct keyboard.kbd_macro_bufsize):
3853 * macros.c (Fstart_kbd_macro, store_kbd_macro_char):
3854 Use ptrdiff_t, not int, for sizes.
3855 Don't increment bufsize until after realloc succeeds.
3856 Check for size-calculation overflow.
3857 (Fstart_kbd_macro): Use EMACS_INT, not int, for XINT result.
3858
437b2cb4
PE
3859 * lisp.h (DEFVAR_KBOARD): Use offsetof instead of char * finagling.
3860
8b9ac8b4
PE
3861 * lread.c: Integer overflow fixes.
3862 (read_integer): Radix is now EMACS_INT, not int,
3863 to improve quality of diagnostics for out-of-range radices.
3864 Calculate buffer size correctly for out-of-range radices.
3865 (read1): Check for integer overflow in radices, and in
3866 read-circle numbers.
82cb60d3
PE
3867 (read_escape): Avoid int overflow.
3868 (Fload, openp, read_buffer_size, read1)
3869 (substitute_object_recurse, read_vector, read_list, map_obarray):
3870 Use ptrdiff_t, not int, for sizes.
3871 (read1): Use EMACS_INT, not int, for sizes.
20270765 3872 Check for size overflow.
8b9ac8b4 3873
7fcccf1e
PE
3874 * image.c (cache_image): Check for size arithmetic overflow.
3875
bfbbd7e7
PE
3876 * lread.c: Integer overflow issues.
3877 (saved_doc_string_size, saved_doc_string_length)
3878 (prev_saved_doc_string_size, prev_saved_doc_string_length):
3879 Now ptrdiff_t, not int.
3880 (read1): Don't assume doc string length fits in int. Check for
3881 out-of-range doc string lengths.
3882 (read_list): Don't assume file position fits in int.
39019e54 3883 (read_escape): Check for hex character overflow.
bfbbd7e7 3884
4e323265
LL
38852011-06-22 Leo Liu <sdl.web@gmail.com>
3886
3887 * minibuf.c (Fcompleting_read_default, Vcompleting_read_function):
3888 Move to minibuffer.el.
3889
85fece3e
PE
38902011-06-22 Paul Eggert <eggert@cs.ucla.edu>
3891
20b84ce9 3892 Fixes for GLYPH_DEBUG found by GCC 4.6.0 static checking.
85fece3e
PE
3893 The following patches are for when GLYPH_DEBUG && !XASSERT.
3894 * dispextern.h (trace_redisplay_p, dump_glyph_string):
3895 * dispnew.c (flush_stdout):
3896 * xdisp.c (dump_glyph_row, dump_glyph_matrix, dump_glyph):
3897 Mark as externally visible.
3898 * dispnew.c (check_window_matrix_pointers): Now static.
3899 * dispnew.c (window_to_frame_vpos):
3900 * xfns.c (unwind_create_frame):
3901 * xterm.c (x_check_font): Remove unused local.
3902 * scroll.c (CHECK_BOUNDS):
3903 * xfaces.c (cache_fache): Rename local to avoid shadowing.
3904 * xfns.c, w32fns.c (image_cache_refcount, dpyinfo_refcount): Now static.
3905 * xdisp.c (check_window_end): Now a no-op if !XASSERTS.
3906 (debug_first_unchanged_at_end_vpos, debug_last_unchanged_at_beg_vpos)
3907 (debug_dvpos, debug_dy, debug_delta, debug_delta_bytes, debug_end_vpos):
3908 Now static.
3909 (debug_method_add): Use va_list and vsprintf rather than relying
3910 on undefined behavior with wrong number of arguments.
3911 (dump_glyph, dump_glyph_row, Fdump_glyph_matrix):
3912 Don't assume ptrdiff_t and EMACS_INT are the same width as int.
3913 In this code, it's OK to assume C99 behavior for ptrdiff_t formats
3914 since we're not interested in debugging glyphs with old libraries.
3915 * xfaces.c (cache_face): Move debugging code earlier; this pacifies
3916 GCC 4.6.0's static checking.
3917
0766b489
PE
39182011-06-22 Paul Eggert <eggert@cs.ucla.edu>
3919
31fd4b32
PE
3920 Integer overflow and signedness fixes (Bug#8873).
3921 A few related buffer overrun fixes, too.
3922
b79e8648
PE
3923 * font.c (font_score): Use EMACS_INT, not int, to store XINT value.
3924
0766b489
PE
3925 * dispextern.h (struct face.stipple):
3926 * image.c (x_bitmap_height, x_bitmap_width, x_bitmap_pixmap)
3927 (x_bitmap_mask, x_allocate_bitmap_record)
3928 (x_create_bitmap_from_data, x_create_bitmap_from_file)
3929 (x_destroy_bitmap, x_destroy_all_bitmaps, x_create_bitmap_mask)
3930 (x_create_bitmap_from_xpm_data):
3931 * nsterm.h (struct ns_display_info.bitmaps_size, .bitmaps_last):
3932 * w32term.h (struct w32_display_info.icon_bitmap_id, .bitmaps_size)
3933 (.bitmaps_last):
3934 * xfaces.c (load_pixmap):
3935 * xterm.c (x_bitmap_icon, x_wm_set_icon_pixmap):
3936 * xterm.h (struct x_display_info.icon_bitmap_id, .bitmaps_size)
3937 (.bitmaps_last, struct x_output.icon_bitmap):
3938 Use ptrdiff_t, not int, for bitmap indexes.
3939 (x_allocate_bitmap_record): Check for size overflow.
3940 * dispextern.h, lisp.h: Adjust to API changes elsewhere.
3941
b081724f
PE
3942 Use ptrdiff_t, not int, for overlay counts.
3943 * buffer.h (overlays_at, sort_overlays, GET_OVERLAYS_AT):
3944 * editfns.c (overlays_around, get_pos_property):
3945 * textprop.c (get_char_property_and_overlay):
3946 * xdisp.c (next_overlay_change, note_mouse_highlight):
3947 * xfaces.c (face_at_buffer_position):
21514da7
PE
3948 * buffer.c (OVERLAY_COUNT_MAX): New macro.
3949 (overlays_at, overlays_in, sort_overlays, Foverlays_at)
3950 (Fnext_overlay_change, Fprevious_overlay_change)
3951 (mouse_face_overlay_overlaps, Foverlays_in):
b081724f 3952 Use ptrdiff_t, not int, for sizes.
21514da7 3953 (overlays_at, overlays_in): Check for size-calculation overflow.
b081724f 3954
3de73e5e
PE
3955 * xterm.c (xim_initialize, same_x_server): Strlen may not fit in int.
3956
2606c57b
PE
3957 * xsmfns.c (smc_save_yourself_CB, x_session_initialize): Avoid strlen.
3958 (x_session_initialize): Do not assume string length fits in int.
3959
aaafe47a
PE
3960 * xsettings.c (apply_xft_settings): Fix potential buffer overrun.
3961 This is unlikely, but can occur if DPI is outlandish.
3962
2674ddc8 3963 * xsettings.c (Ffont_get_system_normal_font, Ffont_get_system_font):
3a5077c5
PE
3964 * xselect.c (Fx_get_atom_name): Avoid need for strlen.
3965
28154962
PE
3966 * xrdb.c: Don't assume strlen fits in int; avoid some strlens.
3967 * xrdb.c (magic_file_p, search_magic_path):
3968 Omit last arg SUFFIX; it was always 0. All callers changed.
3969 (magic_file_p): Use ptrdiff_t, not int. Check for size overflow.
3970
7de51af5
PE
3971 * xfont.c (xfont_match): Avoid need for strlen.
3972
25ed6cc3
PE
3973 * xfns.c: Don't assume strlen fits in int.
3974 (xic_create_fontsetname, x_window): Use ptrdiff_t, not int.
3975
4eab31dd
PE
3976 * xdisp.c (message_log_check_duplicate): Return intmax_t,
3977 not unsigned long, as we prefer signed integers. All callers changed.
3978 Detect integer overflow in repeat count.
3979 (message_dolog): Don't assume print length fits in 39 bytes.
df1f27af 3980 (display_mode_element): Don't assume strlen fits in int.
4eab31dd 3981
171e2a58
PE
3982 * termcap.c: Don't assume sizes fit in int and never overflow.
3983 (struct termcap_buffer, tgetent): Use ptrdiff_t, not int, for sizes.
3984 (gobble_line): Check for size-calculation overflow.
3985
ad39faca 3986 * minibuf.c (Fread_buffer):
6e5bb2dc 3987 * lread.c (intern, intern_c_string):
74ca2eb3
PE
3988 * image.c (xpm_scan) [HAVE_NS && !HAVE_XPM]:
3989 Don't assume string length fits in int.
3990
52c61c22 3991 * keyboard.c (parse_tool_bar_item):
9bda3520
PE
3992 * gtkutil.c (style_changed_cb): Avoid need for strlen.
3993
b5b8c9e5
PE
3994 * font.c: Don't assume string length fits in int.
3995 (font_parse_xlfd, font_parse_fcname, font_unparse_fcname):
3996 Use ptrdiff_t, not int.
ccd6111c
PE
3997 (font_intern_prop): Don't assume string length fits in int.
3998 Don't assume integer property fits in fixnum.
3999 * font.h (font_intern_prop): 2nd arg is now ptrdiff_t, not int.
b5b8c9e5 4000
882f0d81 4001 * filelock.c: Fix some buffer overrun and integer overflow issues.
51cab52b 4002 (get_boot_time): Don't assume gzip command string fits in 100 bytes.
882f0d81
PE
4003 Reformulate so as not to need the command string.
4004 Invoke gzip -cd rather than gunzip, as it's more portable.
4005 (lock_info_type, lock_file_1, lock_file):
4006 Don't assume pid_t and time_t fit in unsigned long.
4007 (LOCK_PID_MAX): Remove; we now use more-reliable bounds.
4008 (current_lock_owner): Prefer signed type for sizes.
4009 Use memcpy, not strncpy, where memcpy is what is really wanted.
4010 Don't assume (via atoi) that time_t and pid_t fit in int.
4011 Check for time_t and/or pid_t out of range, e.g., via a network share.
4012 Don't alloca where an auto var works fine.
4013
93f4cf88
PE
4014 * fileio.c: Fix some integer overflow issues.
4015 (file_name_as_directory, Fexpand_file_name, Fsubstitute_in_file_name):
4016 Don't assume string length fits in int.
4017 (directory_file_name): Don't assume string length fits in long.
4018 (make_temp_name): Don't assume pid fits in int, or that its print
4019 length is less than 20.
4020
f3e92b69
PE
4021 * data.c (Fsubr_name): Rewrite to avoid a strlen call.
4022
1bfdaf10
PE
4023 * coding.c (make_subsidiaries): Don't assume string length fits in int.
4024
35016e9a
PE
4025 * callproc.c (child_setup): Rewrite to avoid two strlen calls.
4026
3d1e65a1
PE
4027 * process.c (Fformat_network_address): Use EMACS_INT, not EMACS_UINT.
4028 We prefer signed integers, even for size calculations.
4029
0b963a93
PE
4030 * emacs.c: Don't assume string length fits in 'int'.
4031 (DEFINE_DUMMY_FUNCTION, sort_args): Use ptrdiff_t, not int.
4032 (main): Don't invoke strlen when not needed.
4033
573f4b54
PE
4034 * dbusbind.c (XD_ERROR): Don't arbitrarily truncate string.
4035 (XD_DEBUG_MESSAGE): Don't waste a byte.
4036
989f33ba
PE
4037 * callproc.c (getenv_internal_1, getenv_internal)
4038 (Fgetenv_internal):
965d34eb
PE
4039 * buffer.c (init_buffer): Don't assume string length fits in 'int'.
4040
e4d29b33
PE
4041 * lread.c (invalid_syntax): Omit length argument.
4042 All uses changed. This doesn't fix a bug, but it simplifies the
4043 code away from its former Hollerith-constant appearance, and it's
4044 one less 'int' to worry about when looking at integer-overflow issues.
51cab52b 4045 (string_to_number): Simplify 2011-04-26 change by invoking xsignal1.
e4d29b33 4046
eb49b136
PE
4047 * lisp.h (DEFUN): Remove bogus use of sizeof (struct Lisp_Subr).
4048 This didn't break anything, but it didn't help either.
4049 It's confusing to put a bogus integer in a place where the actual
4050 value does not matter.
9f62aeb1 4051 (LIST_END_P): Remove unused macro and its bogus comment.
cbeff735 4052 (make_fixnum_or_float): Remove unnecessary cast to EMACS_INT.
eb49b136 4053
15375a22
PE
4054 * lisp.h (union Lisp_Object.i): EMACS_INT, not EMACS_UINT.
4055 This is for consistency with the ordinary, non-USE_LISP_UNION_TYPE,
4056 implementation.
b61cc01c
PE
4057 (struct Lisp_Bool_Vector.size): EMACS_INT, not EMACS_UINT.
4058 We prefer signed types, and the value cannot exceed the EMACS_INT
4059 range anyway (because otherwise the length would not be representable).
9a8e8d9b
PE
4060 (XSET) [USE_LISP_UNION_TYPE]: Use uintptr_t and intptr_t,
4061 not EMACS_UINT and EMACS_INT, when converting pointer to integer.
4062 This avoids a GCC warning when WIDE_EMACS_INT.
15375a22 4063
53b2623d
PE
4064 * indent.c (sane_tab_width): New function.
4065 (current_column, scan_for_column, Findent_to, position_indentation)
4066 (compute_motion): Use it. This is just for clarity.
8fcaf9cc 4067 (Fcompute_motion): Don't assume hscroll and tab offset fit in int.
53b2623d 4068
51cab52b 4069 * image.c (xbm_image_p): Don't assume stated width, height fit in int.
45aebb64 4070
f2ed8a70
PE
4071 * lisp.h (lint_assume): New macro.
4072 * composite.c (composition_gstring_put_cache):
4073 * ftfont.c (ftfont_shape_by_flt): Use it to pacify GCC 4.6.0.
4074
abe80cc6
PE
4075 * editfns.c, insdel.c:
4076 Omit unnecessary forward decls, to simplify future changes.
a9e860e1 4077
b02c740e
PE
4078 * ftfont.c (ftfont_shape_by_flt): Use signed integers for lengths.
4079
ebc96716
PE
4080 * font.c (Ffont_shape_gstring): Don't assume glyph len fits in 'int'.
4081
b4e50fa0 4082 * fns.c (Ffillarray): Don't assume bool vector size fits in 'int'.
f03dc6ef 4083 Use much-faster test for byte-length change.
311d5d7c 4084 Don't assume string byte-length fits in 'int'.
a4cf38e4 4085 Check that character arg fits in 'int'.
85461888 4086 (mapcar1): Declare byte as byte, for clarity.
b4e50fa0 4087
c0c1ee9f
PE
4088 * alloc.c (Fmake_bool_vector): Avoid unnecessary multiplication.
4089
a498d7f4
PE
4090 * fns.c (concat): Catch string overflow earlier.
4091 Do not rely on integer wraparound.
4092
51cab52b
PE
4093 * dispextern.h (struct it.overlay_strings_charpos)
4094 (struct it.selective): Now EMACS_INT, not int.
87830974
PE
4095 * xdisp.c (forward_to_next_line_start)
4096 (back_to_previous_visible_line_start)
4097 (reseat_at_next_visible_line_start, next_element_from_buffer):
4098 Don't arbitrarily truncate the value of 'selective' to int.
4099
76031fad
PE
4100 * xdisp.c (init_iterator): Use XINT, not XFASTINT; it might be < 0.
4101
5eb55db9
PE
4102 * composite.c: Don't truncate sizes to 'int'.
4103 (composition_gstring_p, composition_reseat_it)
4104 (composition_adjust_point): Use EMACS_INT, not int.
7d100a81
PE
4105 (get_composition_id, composition_gstring_put_cache): Use EMACS_INT,
4106 not EMACS_UINT, for indexes.
5eb55db9 4107
0703a717
PE
4108 * category.h (CATEGORY_SET_P): Remove unnecessary cast to EMACS_INT.
4109
d6202519
PE
4110 * buffer.c: Include <verify.h>.
4111 (struct sortvec.priority, struct sortstr.priority):
8961a454 4112 Now EMACS_INT, not int.
c20998a7 4113 (compare_overlays, cmp_for_strings): Avoid subtraction overflow.
67c36fce
PE
4114 (struct sortstr.size, record_overlay_string)
4115 (struct sortstrlist.size, struct sortlist.used):
4116 Don't truncate size to int.
4117 (record_overlay_string): Check for size-calculation overflow.
d6202519 4118 (init_buffer_once): Check at compile-time, not run-time.
fadf4e30 4119
d5a19415
JM
41202011-06-22 Jim Meyering <meyering@redhat.com>
4121
029529ac 4122 Don't leak an XBM-image-sized buffer
d5a19415
JM
4123 * image.c (xbm_load): Free the image buffer after using it.
4124
a9041e6c
PE
41252011-06-21 Paul Eggert <eggert@cs.ucla.edu>
4126
4127 Port to Sun C.
4128 * composite.c (find_automatic_composition): Omit needless 'return 0;'
4129 that Sun C diagnosed.
4130 * fns.c (secure_hash): Fix pointer signedness issue.
4131 * intervals.c (static_offset_intervals): New function.
4132 (offset_intervals): Use it.
4133
7f3f739f
LL
41342011-06-21 Leo Liu <sdl.web@gmail.com>
4135
4136 * deps.mk (fns.o):
4137 * makefile.w32-in ($(BLD)/fns.$(O)): Include sha256.h and
4138 sha512.h.
4139
4140 * fns.c (secure_hash): Rename from crypto_hash_function and change
4141 the first arg to accept symbols.
5b66d427 4142 (Fsecure_hash): New primitive.
7f3f739f
LL
4143 (syms_of_fns): New symbols.
4144
76147d94
DD
41452011-06-20 Deniz Dogan <deniz@dogan.se>
4146
4147 * process.c (Fset_process_buffer): Clarify return value in
4148 docstring.
4149
7d7d0045
CY
41502011-06-18 Chong Yidong <cyd@stupidchicken.com>
4151
4152 * dispnew.c (add_window_display_history): Use BVAR.
4153
4154 * xdisp.c (debug_method_add): Use BVAR.
4155 (check_window_end, dump_glyph_matrix, dump_glyph)
4156 (dump_glyph_row, dump_glyph_string): Convert arglist to ANSI C.
4157
4158 * xfaces.c (check_lface_attrs, check_lface, dump_realized_face):
4159 Likewise.
4160
4161 * xfns.c (Fx_create_frame, x_create_tip_frame): Delay image cache
4162 check till after the cache is created in init_frame_faces.
4163
ff2bc410
SM
41642011-06-17 Stefan Monnier <monnier@iro.umontreal.ca>
4165
4166 * fns.c (Fsafe_length): Yet another int/Lisp_Object mixup.
4167
28177add
PE
41682011-06-16 Paul Eggert <eggert@cs.ucla.edu>
4169
dd3482fe
PE
4170 * lisp.h: Include <limits.h>, for INT_MAX, LONG_MAX, LLONG_MAX.
4171 Without this, prin1 mishandles Lisp_Misc_Save_Value printing on
4172 hosts with pre-C99 libraries, because pD is wrongly defined to "t".
4173
393d71f3 4174 Improve buffer-overflow checking (Bug#8873).
1c8e352f
PE
4175 * fileio.c (Finsert_file_contents):
4176 * insdel.c (insert_from_buffer_1, replace_range, replace_range_2):
4177 Remove the old (too-loose) buffer overflow checks.
4178 They weren't needed, since make_gap checks for buffer overflow.
4179 * insdel.c (make_gap_larger): Catch buffer overflows that were missed.
4180 The old code merely checked for Emacs fixnum overflow, and relied
4181 on undefined (wraparound) behavior. The new code avoids undefined
4182 behavior, and also checks for ptrdiff_t and/or size_t overflow.
4183
2e6813b0 4184 * editfns.c (Finsert_char): Don't dump core with very negative counts.
21d890a4
PE
4185 Tune. Don't use wider integers than needed. Don't use alloca.
4186 Use a bigger 'string' buffer. Rewrite to avoid 'n > 0' test.
2e6813b0 4187
599a9e4f
PE
4188 * insdel.c (replace_range): Fix buf overflow when insbytes < outgoing.
4189
99561444
PE
4190 * insdel.c, lisp.h (buffer_overflow): New function.
4191 (insert_from_buffer_1, replace_range, replace_range_2):
4192 * insdel.c (make_gap_larger):
4193 * editfns.c (Finsert_char):
4194 * fileio.c (Finsert_file_contents): Use it, to normalize wording.
4195
28177add
PE
4196 * buffer.h (BUF_BYTES_MAX): Cast to ptrdiff_t so that it's signed.
4197
e69dafad
PE
41982011-06-15 Paul Eggert <eggert@cs.ucla.edu>
4199
a7af7fde 4200 Integer overflow and signedness fixes (Bug#8873).
ff672d2c 4201
b1c46f02
PE
4202 * ccl.c (ASCENDING_ORDER): New macro, to work around GCC bug 43772.
4203 (GET_CCL_RANGE, IN_INT_RANGE): Use it.
4204
e69dafad
PE
4205 * fileio.c: Don't assume EMACS_INT fits in off_t.
4206 (emacs_lseek): New static function.
4207 (Finsert_file_contents, Fwrite_region): Use it.
4208 Use SEEK_SET, SEEK_CUR, SEEK_END as appropriate.
4209
566684ea
PE
4210 * fns.c (Fload_average): Don't assume 100 * load average fits in int.
4211
e6966cd6
PE
4212 * fns.c: Don't overflow int when computing a list length.
4213 * fns.c (QUIT_COUNT_HEURISTIC): New constant.
4214 (Flength, Fsafe_length): Use EMACS_INT, not int, to avoid unwanted
4215 truncation on 64-bit hosts. Check for QUIT every
4216 QUIT_COUNT_HEURISTIC entries rather than every other entry; that's
4217 faster and is responsive enough.
4218 (Flength): Report an error instead of overflowing an integer.
4219 (Fsafe_length): Return a float if the value is not representable
4220 as a fixnum. This shouldn't happen except in contrived situations.
6346d301 4221 (Fnthcdr, Fsort): Don't assume list length fits in int.
de41a810 4222 (Fcopy_sequence): Don't assume vector length fits in int.
00c604f2 4223
dd0b0efb
PE
4224 * alloc.c: Check that resized vectors' lengths fit in fixnums.
4225 (header_size, word_size): New constants.
4226 (allocate_vectorlike): Don't check size overflow here.
4227 (allocate_vector): Check it here instead, since this is the only
4228 caller of allocate_vectorlike that could cause overflow.
4229 Check that the new vector's length is representable as a fixnum.
4230
86fe5cfe
PE
4231 * fns.c (next_almost_prime): Don't return a multiple of 3 or 5.
4232 The previous code was bogus. For example, next_almost_prime (32)
4233 returned 39, which is undesirable as it is a multiple of 3; and
4234 next_almost_prime (24) returned 25, which is a multiple of 5 so
4235 why was the code bothering to check for multiples of 7?
4236
80e88859
PE
4237 * bytecode.c (exec_byte_code): Use ptrdiff_t, not int, for vector length.
4238
4a2f0ad6
PE
4239 * eval.c, doprnt.c (SIZE_MAX): Remove; inttypes.h defines this now.
4240
f66c7cf8
PE
4241 Variadic C functions now count arguments with ptrdiff_t.
4242 This partly undoes my 2011-03-30 change, which replaced int with size_t.
4243 Back then I didn't know that the Emacs coding style prefers signed int.
4244 Also, in the meantime I found a few more instances where arguments
4a2f0ad6
PE
4245 were being counted with int, which may truncate counts on 64-bit
4246 machines, or EMACS_INT, which may be unnecessarily wide.
f66c7cf8
PE
4247 * lisp.h (struct Lisp_Subr.function.aMANY)
4248 (DEFUN_ARGS_MANY, internal_condition_case_n, safe_call):
4249 Arg counts are now ptrdiff_t, not size_t.
4250 All variadic functions and their callers changed accordingly.
4251 (struct gcpro.nvars): Now size_t, not size_t. All uses changed.
4252 * bytecode.c (exec_byte_code): Check maxdepth for overflow,
4253 to avoid potential buffer overrun. Don't assume arg counts fit in 'int'.
4254 * callint.c (Fcall_interactively): Check arg count for overflow,
4255 to avoid potential buffer overrun. Use signed char, not 'int',
4256 for 'varies' array, so that we needn't bother to check its size
4257 calculation for overflow.
4258 * editfns.c (Fformat): Use ptrdiff_t, not EMACS_INT, to count args.
4259 * eval.c (apply_lambda):
4260 * fns.c (Fmapconcat): Use XFASTINT, not XINT, to get args length.
4261 (struct textprop_rec.argnum): Now ptrdiff_t, not int. All uses changed.
4262 (mapconcat): Use ptrdiff_t, not int and EMACS_INT, to count args.
4263
a1759b76
PE
4264 * callint.c (Fcall_interactively): Don't use index var as event count.
4265
d96be9fc
PE
4266 * vm-limit.c (check_memory_limits): Fix incorrect extern function decls.
4267 * mem-limits.h (SIZE): Remove; no longer used.
4268
a690a978 4269 * xterm.c (x_alloc_nearest_color_1): Prefer int to long when int works.
5efd304b 4270
578c21e6
PE
4271 Remove unnecessary casts.
4272 * xterm.c (x_term_init):
4273 * xfns.c (x_set_border_pixel):
4274 * widget.c (create_frame_gcs): Remove casts to unsigned long etc.
4275 These aren't needed now that we assume ANSI C.
4276
96f53c6c
PE
4277 * sound.c (Fplay_sound_internal): Remove cast to unsigned long.
4278 It's more likely to cause problems (due to unsigned overflow)
4279 than to cure them.
4280
83c77d31
PE
4281 * dired.c (Ffile_attributes): Don't use 32-bit hack on 64-bit hosts.
4282
ee2079f1
PE
4283 * unexelf.c (unexec): Don't assume BSS addr fits in unsigned.
4284
6da65536
PE
4285 * xterm.c (handle_one_xevent): Omit unnecessary casts to unsigned.
4286
7147c4a4
PE
4287 * keyboard.c (modify_event_symbol): Don't limit alist len to UINT_MAX.
4288
193e32d9
PE
4289 * lisp.h (CHAR_TABLE_SET): Omit now-redundant test.
4290
e5533da6
PE
4291 * lread.c (Fload): Don't compare a possibly-garbage time_t value.
4292
9910e595
PE
4293 GLYPH_CODE_FACE returns EMACS_INT, not int.
4294 * dispextern.h (merge_faces):
4295 * xfaces.c (merge_faces):
01103c44
PE
4296 * xdisp.c (get_next_display_element, next_element_from_display_vector):
4297 Don't assume EMACS_INT fits in int.
9910e595 4298
2638320e
PE
4299 * character.h (CHAR_VALID_P): Remove unused parameter.
4300 * fontset.c, lisp.h, xdisp.c: All uses changed.
4301
045eb8d9
PE
4302 * editfns.c (Ftranslate_region_internal): Omit redundant test.
4303
c1f134b5
PE
4304 * fns.c (concat): Minor tuning based on overflow analysis.
4305 This doesn't fix any bugs. Use int to hold character, instead
4306 of constantly refetching from Emacs object. Use XFASTINT, not
4307 XINT, for value known to be a character. Don't bother comparing
4308 a single byte to 0400, as it's always less.
4309
395fcb93 4310 * floatfns.c (Fexpt):
327eeec8
PE
4311 * fileio.c (make_temp_name): Omit unnecessary cast to unsigned.
4312
abbd3d23
PE
4313 * editfns.c (Ftranslate_region_internal): Use int, not EMACS_INT
4314 for characters.
4315
684a03ef
PE
4316 * doc.c (get_doc_string): Omit (unsigned)c that mishandled negatives.
4317
0fed43f3
PE
4318 * data.c (Faset): If ARRAY is a string, check that NEWELT is a char.
4319 Without this fix, on a 64-bit host (aset S 0 4294967386) would
4320 incorrectly succeed when S was a string, because 4294967386 was
4321 truncated before it was used.
4322
8fd02eb7
PE
4323 * chartab.c (Fchar_table_range): Use CHARACTERP to check range.
4324 Otherwise, an out-of-range integer could cause undefined behavior
4325 on a 64-bit host.
4326
f8c86b69
PE
4327 * composite.c: Use int, not EMACS_INT, for characters.
4328 (fill_gstring_body, composition_compute_stop_pos): Use int, not
4329 EMACS_INT, for values that are known to be in character range.
4330 This doesn't fix any bugs but is the usual style inside Emacs and
4331 may generate better code on 32-bit machines.
4332
34206dd2
PE
4333 Make sure a 64-bit char is never passed to ENCODE_CHAR.
4334 This is for reasons similar to the recent CHAR_STRING fix.
4335 * charset.c (Fencode_char): Check that character arg is actually
4336 a character. Pass an int to ENCODE_CHAR.
4337 * charset.h (ENCODE_CHAR): Verify that the character argument is no
4338 wider than 'int', as a compile-time check to prevent future regressions
4339 in this area.
4340
c5958d4c 4341 * character.c (char_string): Remove unnecessary casts.
13bdea59
PE
4342
4343 Make sure a 64-bit char is never passed to CHAR_STRING.
4344 Otherwise, CHAR_STRING would do the wrong thing on a 64-bit platform,
4345 by silently ignoring the top 32 bits, allowing some values
4346 that were far too large to be valid characters.
4347 * character.h: Include <verify.h>.
4348 (CHAR_STRING, CHAR_STRING_ADVANCE): Verify that the character
4349 arguments are no wider than unsigned, as a compile-time check
4350 to prevent future regressions in this area.
4351 * data.c (Faset):
01103c44 4352 * editfns.c (Fchar_to_string, general_insert_function, Finsert_char)
13bdea59
PE
4353 (Fsubst_char_in_region):
4354 * fns.c (concat):
4355 * xdisp.c (decode_mode_spec_coding):
4356 Adjust to CHAR_STRING's new requirement.
4357 * editfns.c (Finsert_char, Fsubst_char_in_region):
4358 * fns.c (concat): Check that character args are actually
4359 characters. Without this test, these functions did the wrong
4360 thing with wildly out-of-range values on 64-bit hosts.
4361
d37ca623
PE
4362 Remove incorrect casts to 'unsigned' that lose info on 64-bit hosts.
4363 These casts should not be needed on 32-bit hosts, either.
4364 * keyboard.c (read_char):
4365 * lread.c (Fload): Remove casts to unsigned.
4366
ea204efb
PE
4367 * lisp.h (UNSIGNED_CMP): New macro.
4368 This fixes comparison bugs on 64-bit hosts.
4369 (ASCII_CHAR_P): Use it.
4370 * casefiddle.c (casify_object):
01103c44 4371 * character.h (ASCII_BYTE_P, CHAR_VALID_P)
ea204efb
PE
4372 (SINGLE_BYTE_CHAR_P, CHAR_STRING):
4373 * composite.h (COMPOSITION_ENCODE_RULE_VALID):
4374 * dispextern.h (FACE_FROM_ID):
4375 * keyboard.c (read_char): Use UNSIGNED_CMP.
4376
41cb286c
PE
4377 * xmenu.c (dialog_selection_callback) [!USE_GTK]: Cast to intptr_t,
4378 not to EMACS_INT, to avoid GCC warning.
4379
4a1b9832
PE
4380 * xfns.c (x_set_scroll_bar_default_width): Remove unused 'int' locals.
4381
55daad71
PE
4382 * buffer.h (PTR_BYTE_POS, BUF_PTR_BYTE_POS): Remove harmful cast.
4383 The cast incorrectly truncated 64-bit byte offsets to 32 bits, and
4384 isn't needed on 32-bit machines.
8f95c75c 4385
01103c44
PE
4386 * buffer.c (Fgenerate_new_buffer_name):
4387 Use EMACS_INT for count, not int.
0ceccced 4388 (advance_to_char_boundary): Return EMACS_INT, not int.
e762cafe
PE
4389
4390 * data.c (Qcompiled_function): Now static.
4391
c6f072e7
PE
4392 * window.c (window_body_lines): Now static.
4393
20ce5912
PE
4394 * image.c (gif_load): Rename local to avoid shadowing.
4395
9c4c5f81
PE
4396 * lisp.h (SAFE_ALLOCA_LISP): Check for integer overflow.
4397 (struct Lisp_Save_Value): Use ptrdiff_t, not int, for 'integer' member.
4398 * alloc.c (make_save_value): Integer argument is now of type
4399 ptrdiff_t, not int.
4400 (mark_object): Use ptrdiff_t, not int.
4401 * lisp.h (pD): New macro.
4402 * print.c (print_object): Use it.
4403
c0c5c8ae
PE
4404 * alloc.c: Use EMACS_INT, not int, to count objects.
4405 (total_conses, total_markers, total_symbols, total_vector_size)
4406 (total_free_conses, total_free_markers, total_free_symbols)
01103c44
PE
4407 (total_free_floats, total_floats, total_free_intervals)
4408 (total_intervals, total_strings, total_free_strings):
c0c5c8ae
PE
4409 Now EMACS_INT, not int. All uses changed.
4410 (Fgarbage_collect): Compute overall total using a double, so that
4411 integer overflow is less likely to be a problem. Check for overflow
4412 when converting back to an integer.
5a25e253
PE
4413 (n_interval_blocks, n_string_blocks, n_float_blocks, n_cons_blocks)
4414 (n_vectors, n_symbol_blocks, n_marker_blocks): Remove.
4415 These were 'int' variables that could overflow on 64-bit hosts;
4416 they were never used, so remove them instead of repairing them.
211a0b2a 4417 (nzombies, ngcs, max_live, max_zombies): Now EMACS_INT, not 'int'.
6349ae4d
PE
4418 (inhibit_garbage_collection): Set gc_cons_threshold to max value.
4419 Previously, this ceilinged at INT_MAX, but that doesn't work on
4420 64-bit machines.
e46bb31a 4421 (allocate_pseudovector): Don't use EMACS_INT when int would do.
c0c5c8ae 4422
c78baabf 4423 * alloc.c (Fmake_bool_vector): Don't assume vector size fits in int.
86f61a15 4424 (allocate_vectorlike): Check for ptrdiff_t overflow.
b6439961
PE
4425 (mark_vectorlike, mark_char_table, mark_object): Avoid EMACS_UINT
4426 when a (possibly-narrower) signed value would do just as well.
4427 We prefer using signed arithmetic, to avoid comparison confusion.
c78baabf 4428
c9d624c6
PE
4429 * alloc.c: Catch some string size overflows that we were missing.
4430 (XMALLOC_OVERRUN_CHECK_SIZE) [!XMALLOC_OVERRUN_CHECK]: Define to 0,
4431 for convenience in STRING_BYTES_MAX.
4432 (STRING_BYTES_MAX): New macro, superseding the old one in lisp.h.
4433 The definition here is exact; the one in lisp.h was approximate.
4434 (allocate_string_data): Check for string overflow. This catches
4435 some instances we weren't catching before. Also, it catches
4436 size_t overflow on (unusual) hosts where SIZE_MAX <= min
4437 (PTRDIFF_MAX, MOST_POSITIVE_FIXNUM), e.g., when size_t is 32 bits
4438 and ptrdiff_t and EMACS_INT are both 64 bits.
c78baabf 4439
c9d624c6
PE
4440 * character.c, coding.c, doprnt.c, editfns.c, eval.c:
4441 All uses of STRING_BYTES_MAX replaced by STRING_BYTES_BOUND.
640c8776 4442 * lisp.h (STRING_BYTES_BOUND): Rename from STRING_BYTES_MAX.
c9d624c6 4443
353032ce
PE
4444 * character.c (string_escape_byte8): Fix nbytes/nchars typo.
4445
2bccce07
PE
4446 * alloc.c (Fmake_string): Check for out-of-range init.
4447
0ac30604
SM
44482011-06-15 Stefan Monnier <monnier@iro.umontreal.ca>
4449
4450 * eval.c (Fdefvaralias): Also mark the target as variable-special-p.
4451
c195f2de
JD
44522011-06-14 Jan Djärv <jan.h.d@swipnet.se>
4453
4454 * xfns.c (x_set_scroll_bar_default_width): Remove argument to
4455 xg_get_default_scrollbar_width.
4456
4457 * gtkutil.c: Include emacsgtkfixed.h if HAVE_GTK3.
4458 (int_gtk_range_get_value): Move to the scroll bar part of the file.
4459 (style_changed_cb): Call update_theme_scrollbar_width and call
4460 x_set_scroll_bar_default_width and xg_frame_set_char_size for
4461 all frames (Bug#8505).
4462 (xg_create_frame_widgets): Call emacs_fixed_new if HAVE_GTK3 (Bug#8505).
4463 Call gtk_window_set_resizable if HAVE_GTK3.
4464 (x_wm_set_size_hint): Call emacs_fixed_set_min_size with min width
4465 and height if HAVE_GTK3 (Bug#8505).
4466 (scroll_bar_width_for_theme): New variable.
4467 (update_theme_scrollbar_width): New function.
4468 (xg_get_default_scrollbar_width): Move code to
4469 update_theme_scrollbar_width, just return scroll_bar_width_for_theme.
4470 (xg_initialize): Call update_theme_scrollbar_width.
4471
4472 * gtkutil.h (xg_get_default_scrollbar_width): Remove argument.
4473
4474 * emacsgtkfixed.c, emacsgtkfixed.h: New files.
4475
e10ac9f1
MR
44762011-06-12 Martin Rudalics <rudalics@gmx.at>
4477
4478 * frame.c (make_frame): Call other_buffer_safely instead of
4479 other_buffer.
4480
4481 * window.c (temp_output_buffer_show): Call display_buffer with
4482 second argument Vtemp_buffer_show_specifiers and reset latter
4483 immediately after the call.
4484 (Vtemp_buffer_show_specifiers): New variable.
4485 (auto_window_vscroll_p, next_screen_context_lines)
4486 (Vscroll_preserve_screen_position): Remove leading asterisks from
4487 doc-strings.
4488
2d3c217e 44892011-06-12 Paul Eggert <eggert@cs.ucla.edu>
4475bec4 4490
7b7f97e8 4491 Fix minor problems found by GCC 4.6.0 static checking.
4475bec4
PE
4492 * buffer.c (Qclone_number): Remove for now, as it's unused.
4493 (record_buffer, Funrecord_buffer): Rename local to avoid shadowing.
4494 (record_buffer): Remove unused local.
4495 * frame.c (other_visible_frames, frame_buffer_list): Now static.
4496 (set_frame_buffer_list): Remove; unused.
4497 * frame.h (other_visible_frames): Remove decl.
4498 * keyboard.h (menu_items_inuse): Declare only if USE_GTK || USE_MOTIF.
4499 * lisp.h (frame_buffer_list, set_frame_buffer_list): Remove decls.
4500 (add_gpm_wait_descriptor, delete_gpm_wait_descriptor): Declare only
4501 if HAVE_GPM.
4502 * menu.c (menu_items_inuse): Now static unless USE_GTK || USE_MOTIF.
4503 * process.c (add_gpm_wait_descriptor, delete_gpm_wait_descriptor):
4504 Define only if HAVE_GPM.
4505 * widget.c (EmacsFrameResize, emacsFrameClassRec): Now static.
4506 (update_hints_inhibit): Remove; never set. All uses removed.
4507 * widgetprv.h (emacsFrameClassRec): Remove decl.
4508 * window.c (delete_deletable_window): Now returns void, since it
4509 wasn't returning anything.
4510 (compare_window_configurations): Remove unused locals.
4511 * xfns.c (x_set_scroll_bar_default_width): Remove unused locals.
4512 * xmenu.c (x_menu_set_in_use): Define only if USE_GTK || USE_MOTIF.
4475bec4
PE
4513 (dialog_selection_callback) [!USE_GTK]: Prefer intptr_t for integers
4514 the same widths as pointers. This follows up on the 2011-05-06 patch.
4515 * xterm.c (x_alloc_lighter_color_for_widget): Define only if USE_LUCID.
4516 * xterm.h: Likewise.
4517 (x_menu_set_in_use): Declare only if USE_GTK || USE_MOTIF.
4518
1384b89e
JB
45192011-06-12 Juanma Barranquero <lekktu@gmail.com>
4520
4521 * makefile.w32-in: Update dependencies.
4522 (LISP_H): Add lib/intprops.h.
4523
1100a63c
CY
45242011-06-11 Chong Yidong <cyd@stupidchicken.com>
4525
4526 * image.c (gif_load): Add animation frame delay to the metadata.
4527 (syms_of_image): Use DEFSYM. New symbol `delay'.
4528
6198ccd0
MR
45292011-06-11 Martin Rudalics <rudalics@gmx.at>
4530
4531 * window.c (delete_deletable_window): Re-add.
4532 (Fset_window_configuration): Rewrite to handle dead buffers and
4533 consequently deletable windows.
4534 (window_tree, Fwindow_tree): Remove. Supply functionality in
4535 window.el.
4536 (compare_window_configurations): Simplify code.
4537
b6e3633c
AS
45382011-06-11 Andreas Schwab <schwab@linux-m68k.org>
4539
1ab0dee5
AS
4540 * image.c (imagemagick_load_image): Fix type mismatch.
4541 (Fimagemagick_types): Likewise.
4542
b6e3633c
AS
4543 * window.h (replace_buffer_in_windows): Declare.
4544
9397e56f
MR
45452011-06-11 Martin Rudalics <rudalics@gmx.at>
4546
4547 * buffer.c: New Lisp objects Qbuffer_list_update_hook and
4548 Qclone_number. Remove external declaration of Qdelete_window.
4549 (Fbuffer_list): Rewrite doc-string. Minor restructuring of
4550 code.
640c8776
SM
4551 (Fget_buffer_create, Fmake_indirect_buffer, Frename_buffer):
4552 Run Qbuffer_list_update_hook if allowed.
9397e56f
MR
4553 (Fother_buffer): Rewrite doc-string. Major rewrite for new
4554 buffer list implementation.
4555 (other_buffer_safely): New function.
4556 (Fkill_buffer): Replace call to replace_buffer_in_all_windows by
4557 calls to replace_buffer_in_windows and
4558 replace_buffer_in_windows_safely. Run Qbuffer_list_update_hook
4559 if allowed.
4560 (record_buffer): Inhibit quitting and rewrite using quittable
4561 functions. Run Qbuffer_list_update_hook if allowed.
4562 (Frecord_buffer, Funrecord_buffer): New functions.
640c8776
SM
4563 (switch_to_buffer_1, Fswitch_to_buffer): Remove.
4564 Move switch-to-buffer to window.el.
9397e56f
MR
4565 (bury-buffer): Move to window.el.
4566 (Vbuffer_list_update_hook): New variable.
4567
4568 * lisp.h (other_buffer_safely): Add prototype in buffer.c
4569 section.
4570
4571 * window.h (resize_frame_windows): Move up in code.
4572 (Fwindow_frame): Remove EXFUN.
4573 (replace_buffer_in_all_windows): Remove prototype.
4574 (replace_buffer_in_windows_safely): Add prototype.
4575
4576 * window.c: Declare Qdelete_window static again. Move down
4577 declaration of select_count.
4578 (Fnext_window, Fprevious_window): Rewrite doc-strings.
4579 (Fother_window): Move to window.el.
4580 (window_loop): Remove DELETE_BUFFER_WINDOWS and UNSHOW_BUFFER
4581 cases. Add REPLACE_BUFFER_IN_WINDOWS_SAFELY case.
4582 (Fdelete_windows_on, Freplace_buffer_in_windows): Move to
4583 window.el.
4584 (replace_buffer_in_windows): Implement by calling
4585 Qreplace_buffer_in_windows.
4586 (replace_buffer_in_all_windows): Remove with some functionality
4587 moved into replace_buffer_in_windows_safely.
4588 (replace_buffer_in_windows_safely): New function.
4589 (select_window_norecord, select_frame_norecord): Move in front
4590 of run_window_configuration_change_hook. Remove now obsolete
4591 declarations.
640c8776
SM
4592 (Fset_window_buffer): Rewrite doc-string.
4593 Call Qrecord_window_buffer.
9397e56f
MR
4594 (keys_of_window): Move binding for other-window to window.el.
4595
b50691aa
CY
45962011-06-11 Chong Yidong <cyd@stupidchicken.com>
4597
4598 * dispextern.h (struct image): Replace data member, whose int_val
4599 and ptr_val fields were not used by anything, with a single
4600 lisp_val object.
4601
4602 * image.c (Fimage_metadata, make_image, mark_image, tiff_load)
4603 (gif_clear_image, gif_load, imagemagick_load_image)
4604 (gs_clear_image, gs_load): Callers changed.
4605
3f754b86
PE
46062011-06-10 Paul Eggert <eggert@cs.ucla.edu>
4607
cca69397
PE
4608 * buffer.h: Include <time.h>, for time_t.
4609 Needed to build on FreeBSD 8.2. Problem reported by Herbert J. Skuhra.
4610
109e28d0
PE
4611 Fix minor problems found by static checking.
4612
60737f02
PE
4613 * image.c (PixelGetMagickColor): Declare if ImageMagick headers don't.
4614
4b66faf3
PE
4615 Make identifiers static if they are not used in other modules.
4616 * data.c (Qcompiled_function, Qframe, Qvector):
4617 * image.c (QimageMagick, Qsvg):
4618 * minibuf.c (Qmetadata):
4619 * window.c (resize_window_check, resize_root_window): Now static.
4620 * window.h (resize_window_check, resize_root_window): Remove decls.
4621
109e28d0
PE
4622 * window.c (window_deletion_count, delete_deletable_window):
4623 Remove; unused.
46a4ce9e
PE
4624 (window_body_lines): Now static.
4625 (Fdelete_other_windows_internal): Mark vars as initialized.
4626 Make sure 'resize_failed' is initialized.
4627 (run_window_configuration_change_hook): Rename local to avoid shadowing.
4628 (resize_window_apply): Remove unused local.
4629 * window.h (delete_deletable_window): Remove decl.
4630
109e28d0 4631 * image.c (gif_load, svg_load_image): Rename locals to avoid shadowing.
33290528
PE
4632 (imagemagick_load_image): Fix pointer signedness problem by changing
4633 last arg from unsigned char * to char *. All uses changed.
4634 Also, fix a local for similar reasons.
4635 Remove unused locals. Remove locals to avoid shadowing.
4636 (fn_rsvg_handle_free): Remove; unused.
4637 (svg_load, svg_load_image): Fix pointer signedness problem.
f7e13da3 4638 (imagemagick_load_image): Don't use garbage pointer image_wand.
33290528 4639
3f754b86
PE
4640 * ftfont.c (ftfont_get_metrics, ftfont_drive_otf): Remove unused locals.
4641
2547adb1
CY
46422011-06-10 Chong Yidong <cyd@stupidchicken.com>
4643
4644 * image.c (gif_load): Fix omitted cast error introduced by
4645 2011-06-06 change.
4646
2c8e37d4
MR
46472011-06-10 Martin Rudalics <rudalics@gmx.at>
4648
4649 * window.h (resize_proportionally, orig_total_lines)
4650 (orig_top_line): Remove from window structure.
4651 (set_window_height, set_window_width, change_window_heights)
4652 (Fdelete_window): Remove prototypes.
4653 (resize_frame_windows): Remove duplicate declaration.
4654
440a42e3
EZ
46552011-06-10 Eli Zaretskii <eliz@gnu.org>
4656
4657 * window.h (resize_frame_windows, resize_window_check)
4658 (delete_deletable_window, resize_root_window)
4659 (resize_frame_windows): Declare prototypes.
4660
4661 * window.c (resize_window_apply): Make definition be "static" to
4662 match the prototype.
4663
562dd5e9
MR
46642011-06-10 Martin Rudalics <rudalics@gmx.at>
4665
4666 * window.c: Remove declarations of Qwindow_size_fixed,
4667 window_min_size_1, window_min_size_2, window_min_size,
4668 size_window, window_fixed_size_p, enlarge_window, delete_window.
4669 Remove static from declaration of Qdelete_window, it's
4670 temporarily needed by Fbury_buffer.
4671 (replace_window): Don't assign orig_top_line and
4672 orig_total_lines.
4673 (Fdelete_window, delete_window): Remove. Window deletion is
4674 handled by window.el.
640c8776
SM
4675 (window_loop): Remove DELETE_OTHER_WINDOWS case.
4676 Replace Fdelete_window calls with calls to Qdelete_window.
562dd5e9
MR
4677 (Fdelete_other_windows): Remove. Deleting other windows is
4678 handled by window.el.
4679 (window_fixed_size_p): Remove. Fixed-sizeness of windows is
4680 handled in window.el.
4681 (window_min_size_2, window_min_size_1, window_min_size): Remove.
4682 Window minimum sizes are handled in window.el.
4683 (shrink_windows, size_window, set_window_height)
4684 (set_window_width, change_window_heights, window_height)
4685 (window_width, CURBEG, CURSIZE, enlarge_window)
4686 (adjust_window_trailing_edge, Fadjust_window_trailing_edge)
4687 (Fenlarge_window, Fshrink_window): Remove. Window resizing is
4688 handled in window.el.
4689 (make_dummy_parent): Rename to make_parent_window and give it a
4690 second argument horflag.
4691 (make_window): Don't set resize_proportionally any more.
4692 (Fsplit_window): Remove. Windows are split in window.el.
4693 (save_restore_action, save_restore_orig_size)
4694 (shrink_window_lowest_first, save_restore_orig_size): Remove.
4695 Resize mini windows in window.el.
4696 (grow_mini_window, shrink_mini_window): Implement by calling
4697 Qresize_root_window_vertically, resize_window_check and
4698 resize_window_apply.
640c8776
SM
4699 (saved_window, Fset_window_configuration, save_window_save):
4700 Do not handle orig_top_line, orig_total_lines, and
562dd5e9
MR
4701 resize_proportionally.
4702 (window_min_height, window_min_width): Move to window.el.
4703 (keys_of_window): Move bindings for delete-other-windows,
4704 split-window, delete-window and enlarge-window to window.el.
4705
4706 * buffer.c: Temporarily extern Qdelete_window.
4707 (Fbury_buffer): Temporarily call Qdelete_window instead of
4708 Fdelete_window (Fbury_buffer will move to window.el soon).
4709
4710 * frame.c (set_menu_bar_lines_1): Remove code handling
4711 orig_top_line and orig_total_lines.
4712
4713 * dispnew.c (adjust_frame_glyphs_initially): Don't use
4714 set_window_height but set heights directly.
4715 (change_frame_size_1): Use resize_frame_windows.
4716
4717 * xdisp.c (init_xdisp): Don't use set_window_height but set
4718 heights directly.
4719
640c8776
SM
4720 * xfns.c (x_set_menu_bar_lines, x_set_tool_bar_lines):
4721 Use resize_frame_windows instead of change_window_heights and run
562dd5e9
MR
4722 run_window_configuration_change_hook.
4723
4724 * w32fns.c (x_set_tool_bar_lines): Use resize_frame_windows
4725 instead of change_window_heights and run
4726 run_window_configuration_change_hook.
4727
1a13852e
MR
47282011-06-09 Martin Rudalics <rudalics@gmx.at>
4729
4730 * window.c (replace_window): Rename second argument REPLACEMENT to
4731 NEW. New third argument SETFLAG. Rewrite.
4732 (delete_window, make_dummy_parent): Call replace_window with
4733 third argument 1.
4734 (window_list_1): Move down in code.
4735 (run_window_configuration_change_hook): Move set_buffer part
4736 before select_frame_norecord part in order to unwind correctly.
4737 Rename count1 to count.
4738 (recombine_windows, delete_deletable_window, resize_root_window)
4739 (Fdelete_other_windows_internal)
4740 (Frun_window_configuration_change_hook, make_parent_window)
4741 (resize_window_check, resize_window_apply, Fresize_window_apply)
4742 (resize_frame_windows, Fsplit_window_internal)
640c8776
SM
4743 (Fdelete_window_internal, Fresize_mini_window_internal):
4744 New functions.
1a13852e
MR
4745 (syms_of_window): New variables Vwindow_splits and Vwindow_nest.
4746
f3d1777e
MR
47472011-06-08 Martin Rudalics <rudalics@gmx.at>
4748
496e208e
MR
4749 * window.h (window): Add some new members to window structure -
4750 normal_lines, normal_cols, new_total, new_normal, clone_number,
4751 splits, nest, prev_buffers, next_buffers.
4752 (WINDOW_TOTAL_SIZE): Move here from window.c.
b9e809c2 4753 (MIN_SAFE_WINDOW_WIDTH, MIN_SAFE_WINDOW_HEIGHT): Define here.
496e208e 4754
f3d1777e
MR
4755 * window.c (Fwindow_height, Fwindow_width, Fwindow_full_width_p):
4756 Remove.
496e208e
MR
4757 (make_dummy_parent): Set new members of windows structure.
4758 (make_window): Move down in code. Handle new members of window
4759 structure.
4760 (Fwindow_clone_number, Fwindow_splits, Fset_window_splits)
4761 (Fwindow_nest, Fset_window_nest, Fwindow_new_total)
4762 (Fwindow_normal_size, Fwindow_new_normal, Fwindow_prev_buffers)
4763 (Fset_window_prev_buffers, Fwindow_next_buffers)
640c8776
SM
4764 (Fset_window_next_buffers, Fset_window_clone_number):
4765 New functions.
496e208e
MR
4766 (Fwindow_hscroll, Fwindow_at, Fwindow_point, Fwindow_start)
4767 (Fwindow_end, Fwindow_line_height, Fset_window_dedicated_p):
4768 Doc-string fixes.
4769 (Fwindow_parameters, Fwindow_parameter, Fset_window_parameter):
4770 Argument WINDOW can be now internal window too.
4771 (Fwindow_use_time): Move up in code.
4772 (Fget_buffer_window): Rename argument FRAME to ALL-FRAMES.
4773 Rewrite doc-string.
4774 (Fset_window_configuration, saved_window)
4775 (Fcurrent_window_configuration, save_window_save): Handle new
4776 members of window structure.
b9e809c2
MR
4777 (WINDOW_TOTAL_SIZE, MIN_SAFE_WINDOW_WIDTH)
4778 (MIN_SAFE_WINDOW_HEIGHT): Move to window.h.
4779 (syms_of_window): New Lisp objects Qrecord_window_buffer,
4780 Qwindow_deletable_p, Qdelete_window, Qreplace_buffer_in_windows,
4781 Qget_mru_window, Qresize_root_window,
4782 Qresize_root_window_vertically, Qsafe, Qabove, Qbelow,
4783 Qauto_buffer_name; staticpro them.
f3d1777e 4784
abde8f8c
MR
47852011-06-07 Martin Rudalics <rudalics@gmx.at>
4786
4787 * window.c (Fwindow_total_size, Fwindow_left_column)
4788 (Fwindow_top_line, window_body_lines, Fwindow_body_size)
4789 (Fwindow_list_1): New functions.
4790 (window_box_text_cols): Replace with window_body_cols.
640c8776
SM
4791 (Fwindow_width, Fscroll_left, Fscroll_right):
4792 Use window_body_cols instead of window_box_text_cols.
4793 (delete_window, Fset_window_configuration):
4794 Call delete_all_subwindows with window as argument.
fa8a67e6
MR
4795 (delete_all_subwindows): Take a window as argument and not a
4796 structure. Rewrite.
190b47e6
MR
4797 (window_loop): Remove handling of GET_LRU_WINDOW and
4798 GET_LARGEST_WINDOW.
4799 (Fget_lru_window, Fget_largest_window): Move to window.el.
abde8f8c
MR
4800
4801 * window.h: Extern window_body_cols instead of
fa8a67e6
MR
4802 window_box_text_cols. delete_all_subwindows now takes a
4803 Lisp_Object as argument.
abde8f8c 4804
640c8776
SM
4805 * indent.c (compute_motion, Fcompute_motion):
4806 Use window_body_cols instead of window_box_text_cols.
abde8f8c 4807
fa8a67e6
MR
4808 * frame.c (delete_frame): Call delete_all_subwindows with root
4809 window as argument.
4810
a54e3482
DC
48112011-06-07 Daniel Colascione <dan.colascione@gmail.com>
4812
4813 * fns.c (Fputhash): Document return value.
4814
60002bf5
CY
48152011-06-06 Chong Yidong <cyd@stupidchicken.com>
4816
4817 * image.c (gif_load): Implement gif89a spec "no disposal" method.
4818
0c671da6 48192011-06-06 Paul Eggert <eggert@cs.ucla.edu>
ccd9a01a 4820
b862a52a 4821 Cons<->int and similar integer overflow fixes (Bug#8794).
77984278 4822
be44ca6c
PE
4823 Check for overflow when converting integer to cons and back.
4824 * charset.c (Fdefine_charset_internal, Fdecode_char):
4825 Use cons_to_unsigned to catch overflow.
4826 (Fencode_char): Use INTEGER_TO_CONS.
4827 * composite.h (LGLYPH_CODE): Use cons_to_unsigned.
4828 (LGLYPH_SET_CODE): Use INTEGER_TO_CONS.
4829 * data.c (long_to_cons, cons_to_long): Remove.
4830 (cons_to_unsigned, cons_to_signed): New functions.
4831 These signal an error for invalid or out-of-range values.
4832 * dired.c (Ffile_attributes): Use INTEGER_TO_CONS.
4833 * fileio.c (Fset_visited_file_modtime): Use CONS_TO_INTEGER.
4834 * font.c (Ffont_variation_glyphs):
4835 * fontset.c (Finternal_char_font): Use INTEGER_TO_CONS.
4836 * lisp.h: Include <intprops.h>.
4837 (INTEGER_TO_CONS, CONS_TO_INTEGER): New macros.
4838 (cons_to_signed, cons_to_unsigned): New decls.
4839 (long_to_cons, cons_to_long): Remove decls.
4840 * undo.c (record_first_change): Use INTEGER_TO_CONS.
4841 (Fprimitive_undo): Use CONS_TO_INTEGER.
4842 * xfns.c (Fx_window_property): Likewise.
4843 * xselect.c: Include <limits.h>.
4844 (x_own_selection, selection_data_to_lisp_data):
4845 Use INTEGER_TO_CONS.
4846 (x_handle_selection_request, x_handle_selection_clear)
4847 (x_get_foreign_selection, Fx_disown_selection_internal)
4848 (Fx_get_atom_name, x_send_client_event): Use CONS_TO_INTEGER.
4849 (lisp_data_to_selection_data): Use cons_to_unsigned.
4850 (x_fill_property_data): Use cons_to_signed.
4851 Report values out of range.
4852
d1f3d2af
PE
4853 Check for buffer and string overflow more precisely.
4854 * buffer.h (BUF_BYTES_MAX): New macro.
4855 * lisp.h (STRING_BYTES_MAX): New macro.
4856 * alloc.c (Fmake_string):
4857 * character.c (string_escape_byte8):
4858 * coding.c (coding_alloc_by_realloc):
4859 * doprnt.c (doprnt):
4860 * editfns.c (Fformat):
4861 * eval.c (verror):
4862 Use STRING_BYTES_MAX, not MOST_POSITIVE_FIXNUM,
4863 since they may not be the same number.
4864 * editfns.c (Finsert_char):
4865 * fileio.c (Finsert_file_contents):
4866 Likewise for BUF_BYTES_MAX.
4867
dd52fcea
PE
4868 * image.c: Use ptrdiff_t, not int, for sizes.
4869 (slurp_file): Switch from int to ptrdiff_t.
4870 All uses changed.
4871 (slurp_file): Check that file size fits in both size_t (for
4872 malloc) and ptrdiff_t (for sanity and safety).
4873
7f9bbdbb
PE
4874 * fileio.c (Fverify_visited_file_modtime): Avoid time overflow
4875 if b->modtime has its maximal value.
4876
dfe18f82
PE
4877 * dired.c (Ffile_attributes): Don't assume EMACS_INT has >32 bits.
4878
84acfcf0
PE
4879 Don't assume time_t can fit into int.
4880 * buffer.h (struct buffer.modtime): Now time_t, not int.
4881 * fileio.c (Fvisited_file_modtime): No need for time_t cast now.
4882 * undo.c (Fprimitive_undo): Use time_t, not int, for time_t value.
4883
ccd9a01a
PE
4884 Minor fixes for signed vs unsigned integers.
4885 * character.h (MAYBE_UNIFY_CHAR):
4886 * charset.c (maybe_unify_char):
4887 * keyboard.c (read_char, reorder_modifiers):
4888 XINT -> XFASTINT, since the integer must be nonnegative.
4889 * ftfont.c (ftfont_spec_pattern):
4890 * keymap.c (access_keymap, silly_event_symbol_error):
4891 XUINT -> XFASTINT, since the integer must be nonnegative.
4892 (Fsingle_key_description, preferred_sequence_p): XUINT -> XINT,
4893 since it makes no difference and we prefer signed.
4894 * keyboard.c (record_char): Use XUINT when all the neighbors do.
4895 (access_keymap): NATNUMP -> INTEGERP, since the integer must be
4896 nonnegative.
4897
d6d100dd
SM
48982011-06-06 Stefan Monnier <monnier@iro.umontreal.ca>
4899
4900 * window.h (Fwindow_frame): Declare.
4901
2b6148e4
PE
49022011-06-06 Paul Eggert <eggert@cs.ucla.edu>
4903
4904 * alloc.c: Simplify handling of large-request failures (Bug#8800).
4905 (SPARE_MEMORY): Always define.
4906 (LARGE_REQUEST): Remove.
4907 (memory_full): Use SPARE_MEMORY rather than LARGE_REQUEST.
4908
f230ecc9
MR
49092011-06-06 Martin Rudalics <rudalics@gmx.at>
4910
727e958e
MR
4911 * lisp.h: Move EXFUNS for Fframe_root_window,
4912 Fframe_first_window and Fset_frame_selected_window to window.h.
4913
4914 * window.h: Move EXFUNS for Fframe_root_window,
4915 Fframe_first_window and Fset_frame_selected_window here from
4916 lisp.h.
4917
4918 * frame.c (Fwindow_frame, Fframe_first_window)
4919 (Fframe_root_window, Fframe_selected_window)
4920 (Fset_frame_selected_window): Move to window.c.
4921 (Factive_minibuffer_window): Move to minibuf.c.
4922 (Fother_visible_frames_p): New function.
4923
4924 * minibuf.c (Factive_minibuffer_window): Move here from frame.c.
4925
f230ecc9
MR
4926 * window.c (decode_window, decode_any_window): Move up in code.
4927 (Fwindowp, Fwindow_live_p): Rewrite doc-strings.
4928 (inhibit_frame_unsplittable): Remove unused variable.
bf60a96b
MR
4929 (Fwindow_buffer): Move up and rewrite doc-string.
4930 (Fwindow_parent, Fwindow_vchild, Fwindow_hchild, Fwindow_next)
4931 (Fwindow_prev): New functions.
727e958e
MR
4932 (Fwindow_frame): Move here from frame.c. Accept any window as
4933 argument.
4934 (Fframe_root_window, Fframe_first_window)
4935 (Fframe_selected_window): Move here from frame.c. Accept frame
4936 or arbitrary window as argument. Update doc-strings.
4937 (Fminibuffer_window): Move up in code.
4938 (Fwindow_minibuffer_p): Move up in code and simplify.
d6d100dd
SM
4939 (Fset_frame_selected_window): Move here from frame.c.
4940 Marginal rewrite.
727e958e
MR
4941 (Fselected_window, select_window, Fselect_window): Move up in
4942 code. Minor doc-string fixes.
f230ecc9 4943
4d09bcf6
PE
49442011-06-06 Paul Eggert <eggert@cs.ucla.edu>
4945
4946 * alloc.c (memory_full) [SYSTEM_MALLOC]: Port to MacOS (Bug#8800).
4947 Do not assume that spare memory exists; that assumption is valid
4948 only if SYSTEM_MALLOC.
4949 (LARGE_REQUEST): New macro, so that the issue of large requests
4950 is separated from the issue of spare memory.
4951
810928a2
AS
49522011-06-05 Andreas Schwab <schwab@linux-m68k.org>
4953
172418ad
AS
4954 * editfns.c (Fformat): Correctly handle zero flag with hexadecimal
4955 format. (Bug#8806)
4956
43f862f7
AS
4957 * gtkutil.c (xg_get_default_scrollbar_width): Avoid warning.
4958
810928a2
AS
4959 * xfns.c (x_set_scroll_bar_default_width): Move declarations
4960 before statements.
4961
a059fe24
JD
49622011-06-05 Jan Djärv <jan.h.d@swipnet.se>
4963
4964 * gtkutil.c (xg_get_default_scrollbar_width): New function.
4965
4966 * gtkutil.h: Declare xg_get_default_scrollbar_width.
4967
4968 * xfns.c (x_set_scroll_bar_default_width): If USE_GTK, get
4969 min width by calling x_set_scroll_bar_default_width (Bug#8505).
4970
989bf368
JB
49712011-06-05 Juanma Barranquero <lekktu@gmail.com>
4972
4973 * xdisp.c (single_display_spec_intangible_p): Remove declaration.
4974
4b80f674
CY
49752011-06-04 Chong Yidong <cyd@stupidchicken.com>
4976
4977 * xselect.c (x_clipboard_manager_save): Remove redundant arg.
4978 (x_clipboard_manager_save): Add return value.
d6d100dd
SM
4979 (x_clipboard_manager_error_1, x_clipboard_manager_error_2):
4980 New error handlers.
4b80f674
CY
4981 (x_clipboard_manager_save_frame, x_clipboard_manager_save_all):
4982 Obey Vx_select_enable_clipboard_manager. Catch errors in
4983 x_clipboard_manager_save (Bug#8779).
4984 (Vx_select_enable_clipboard_manager): New variable.
de65b42c 4985 (x_get_foreign_selection): Reduce scope of x_catch_errors (Bug#8790).
4b80f674 4986
99a33b77 49872011-06-04 Dan Nicolaescu <dann@ics.uci.edu>
8b3115e7
DN
4988
4989 * emacs.c (main): Warn when starting a GTK emacs in daemon mode.
4990
99a33b77 49912011-06-04 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
14eca62f
YM
4992
4993 * fringe.c (update_window_fringes): Don't update overlay arrow bitmap
4994 in the current matrix if keep_current_p is non-zero.
4995
8264569d
EZ
49962011-06-04 Eli Zaretskii <eliz@gnu.org>
4997
4998 * bidi.c (bidi_level_of_next_char): Fix last change.
4999
57f97249
EZ
50002011-06-03 Eli Zaretskii <eliz@gnu.org>
5001
fec2107c 5002 Support bidi reordering of text covered by display properties.
57f97249 5003
fec2107c
EZ
5004 * bidi.c (bidi_copy_it): Use offsetof instead of emulating it.
5005 (bidi_fetch_char, bidi_fetch_char_advance): New functions.
5006 (bidi_cache_search, bidi_cache_iterator_state)
5007 (bidi_paragraph_init, bidi_resolve_explicit, bidi_resolve_weak)
d6d100dd
SM
5008 (bidi_level_of_next_char, bidi_move_to_visually_next):
5009 Support character positions inside a run of characters covered by a
fec2107c
EZ
5010 display string.
5011 (bidi_paragraph_init, bidi_resolve_explicit_1)
5012 (bidi_level_of_next_char): Call bidi_fetch_char and
5013 bidi_fetch_char_advance instead of FETCH_CHAR and
5014 FETCH_CHAR_ADVANCE.
5015 (bidi_init_it): Initialize new members.
5016 (LRE_CHAR, RLE_CHAR, PDF_CHAR, LRO_CHAR, RLO_CHAR): Remove macro
5017 definitions.
5018 (bidi_explicit_dir_char): Lookup character type in bidi_type_table,
5019 instead of using explicit *_CHAR codes.
d6d100dd
SM
5020 (bidi_resolve_explicit, bidi_resolve_weak):
5021 Use FETCH_MULTIBYTE_CHAR instead of FETCH_CHAR, as reordering of
fec2107c
EZ
5022 bidirectional text is supported only in multibyte buffers.
5023 (bidi_init_it): Accept additional argument FRAME_WINDOW_P and use
5024 it to initialize the frame_window_p member of struct bidi_it.
5025 (bidi_cache_iterator_state, bidi_resolve_explicit_1)
5026 (bidi_resolve_explicit, bidi_resolve_weak)
5027 (bidi_level_of_next_char, bidi_move_to_visually_next): Abort if
5028 bidi_it->nchars is non-positive.
5029 (bidi_level_of_next_char): Don't try to lookup the cache for the
5030 next/previous character if nothing is cached there yet, or if we
5031 were just reseat()'ed to a new position.
c40e2fb2 5032
0e14fe90
EZ
5033 * xdisp.c (set_cursor_from_row): Set start and stop points
5034 according to the row's direction when priming the loop that looks
5035 for the glyph on which to display cursor.
5036 (single_display_spec_intangible_p): Function deleted.
5037 (display_prop_intangible_p): Reimplement to call
5038 handle_display_spec instead of single_display_spec_intangible_p.
d6d100dd
SM
5039 Accept 3 additional arguments needed by handle_display_spec.
5040 This fixes incorrect cursor motion across display property with complex
0e14fe90
EZ
5041 values: lists, `(when COND...)' forms, etc.
5042 (single_display_spec_string_p): Support property values that are
5043 lists with the argument STRING its top-level element.
5044 (display_prop_string_p): Fix the condition for processing a
5045 property that is a list to be consistent with handle_display_spec.
fec2107c 5046 (handle_display_spec): New function, refactored from the
fc6f18ce
EZ
5047 last portion of handle_display_prop.
5048 (compute_display_string_pos): Accept additional argument
5049 FRAME_WINDOW_P. Call handle_display_spec to determine whether the
5050 value of a `display' property is a "replacing spec".
5051 (handle_single_display_spec): Accept 2 additional arguments BUFPOS
5052 and FRAME_WINDOW_P. If IT is NULL, don't set up the iterator from
5053 the display property, but just return a value indicating whether
5054 the display property will replace the characters it covers.
5055 (Fcurrent_bidi_paragraph_direction): Initialize the nchars and
5056 frame_window_p members of struct bidi_it.
d6d100dd
SM
5057 (compute_display_string_pos, compute_display_string_end):
5058 New functions.
fec2107c
EZ
5059 (push_it): Accept second argument POSITION, where pop_it should
5060 jump to continue iteration.
5061 (reseat_1): Initialize bidi_it.disp_pos.
fc6f18ce 5062
fec2107c
EZ
5063 * keyboard.c (adjust_point_for_property): Adjust the call to
5064 display_prop_intangible_p to its new signature.
fc6f18ce
EZ
5065
5066 * dispextern.h (struct bidi_it): New member frame_window_p.
fec2107c
EZ
5067 (bidi_init_it): Update prototypes.
5068 (display_prop_intangible_p): Update prototype.
d6d100dd
SM
5069 (compute_display_string_pos, compute_display_string_end):
5070 Declare prototypes.
fec2107c
EZ
5071 (struct bidi_it): New members nchars and disp_pos. ch_len is now
5072 EMACS_INT.
fc6f18ce 5073
40087514 50742011-06-02 Paul Eggert <eggert@cs.ucla.edu>
0de4bb68 5075
57f53182
PE
5076 Malloc failure behavior now depends on size of allocation.
5077 * alloc.c (buffer_memory_full, memory_full): New arg NBYTES.
5078 * lisp.h: Change signatures accordingly.
5079 * alloc.c, buffer.c, editfns.c, menu.c, minibuf.c, xterm.c:
5080 All callers changed. (Bug#8762)
5081
5082 * gnutls.c: Use Emacs's memory allocators.
5083 Without this change, the gnutls library would invoke malloc etc.
5084 directly, which causes problems on non-SYNC_INPUT hosts, and which
5085 runs afoul of improving memory_full behavior. (Bug#8761)
5086 (fn_gnutls_global_set_mem_functions): New macro or function pointer.
5087 (emacs_gnutls_global_init): Use it to specify xmalloc, xrealloc,
5088 xfree instead of the default malloc, realloc, free.
5089 (Fgnutls_boot): No need to check for memory allocation failure,
5090 since xmalloc does that for us.
5091
ac32cd99 5092 Remove arbitrary limit of 2**31 entries in hash tables. (Bug#8771)
3870d916
PE
5093 * category.c (hash_get_category_set):
5094 * ccl.c (ccl_driver):
5095 * charset.c (Fdefine_charset_internal):
5096 * charset.h (struct charset.hash_index):
5097 * composite.c (get_composition_id, gstring_lookup_cache)
5098 (composition_gstring_put_cache):
5099 * composite.h (struct composition.hash_index):
5100 * dispextern.h (struct image.hash):
5101 * fns.c (next_almost_prime, larger_vector, cmpfn_eql)
5102 (cmpfn_equal, cmpfn_user_defined, hashfn_eq, hashfn_eql)
5103 (hashfn_equal, hashfn_user_defined, make_hash_table)
5104 (maybe_resize_hash_table, hash_lookup, hash_put)
5105 (hash_remove_from_table, hash_clear, sweep_weak_table, SXHASH_COMBINE)
5106 (sxhash_string, sxhash_list, sxhash_vector, sxhash_bool_vector)
5107 (Fsxhash, Fgethash, Fputhash, Fmaphash):
5108 * image.c (make_image, search_image_cache, lookup_image)
5109 (xpm_put_color_table_h):
5110 * lisp.h (struct Lisp_Hash_Table):
0de4bb68 5111 * minibuf.c (Ftry_completion, Fall_completions, Ftest_completion):
ac389d0c 5112 * print.c (print): Use 'EMACS_UINT' and 'EMACS_INT'
3870d916 5113 for hashes and hash indexes, instead of 'unsigned' and 'int'.
40087514
PE
5114 * alloc.c (allocate_vectorlike):
5115 Check for overflow in vector size calculations.
5116 * ccl.c (ccl_driver):
5117 Check for overflow when converting EMACS_INT to int.
0de4bb68
PE
5118 * fns.c, image.c: Remove unnecessary static decls that would otherwise
5119 need to be updated by these changes.
40087514
PE
5120 * fns.c (make_hash_table, maybe_resize_hash_table):
5121 Check for integer overflow with large hash tables.
0de4bb68
PE
5122 (make_hash_table, maybe_resize_hash_table, Fmake_hash_table):
5123 Prefer the faster XFLOAT_DATA to XFLOATINT where either will do.
5124 (SXHASH_REDUCE): New macro.
5125 (sxhash_string, sxhash_list, sxhash_vector, sxhash_bool_vector):
5126 Use it instead of discarding useful hash info with large hash values.
5127 (sxhash_float): New function.
5128 (sxhash): Use it. No more need for "& INTMASK" due to above changes.
5129 * lisp.h (FIXNUM_BITS): New macro, useful for SXHASH_REDUCE etc.
40087514
PE
5130 (MOST_NEGATIVE_FIXNUM, MOST_POSITIVE_FIXNUM, INTMASK):
5131 Rewrite to use FIXNUM_BITS, as this simplifies things.
0de4bb68
PE
5132 (next_almost_prime, larger_vector, sxhash, hash_lookup, hash_put):
5133 Adjust signatures to match updated version of code.
5134 (consing_since_gc): Now EMACS_INT, since a single hash table can
5135 use more than INT_MAX bytes.
5136
698d32e2
DN
51372011-06-01 Dan Nicolaescu <dann@ics.uci.edu>
5138
5139 Make it possible to build with GCC-4.6+ -O2 -flto.
5140
5141 * emacs.c (__malloc_initialize_hook): Mark as EXTERNALLY_VISIBLE.
5142
fd6fa53f
SM
51432011-06-01 Stefan Monnier <monnier@iro.umontreal.ca>
5144
5145 * minibuf.c (get_minibuffer, read_minibuf_unwind):
5146 Call minibuffer-inactive-mode.
5147
864db017
JB
51482011-05-31 Juanma Barranquero <lekktu@gmail.com>
5149
5150 * makefile.w32-in ($(BLD)/data.$(O), $(BLD)/editfns.$(O)):
5151 Update dependencies.
5152
2ad0baf4
DN
51532011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
5154
5155 * data.c (init_data): Remove code for UTS, this system is not
5156 supported anymore.
5157
4fcc2638
DN
51582011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
5159
5160 Don't force ./temacs to start in terminal mode.
5161
5162 * frame.c (make_initial_frame): Initialize faces in all cases, not
5163 only when CANNOT_DUMP is defined.
5164 * dispnew.c (init_display): Remove CANNOT_DUMP condition.
5165
c56e0fd5
DN
51662011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
5167
5168 * dispnew.c (add_window_display_history): Use const for the string
5169 pointer. Remove declaration, not needed.
5170
333d54da 51712011-05-31 Paul Eggert <eggert@cs.ucla.edu>
9cf9f756 5172
55d4c1b2 5173 Use 'inline', not 'INLINE'.
333d54da 5174 <http://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00914.html>
55d4c1b2
PE
5175 * alloc.c, fontset.c (INLINE): Remove.
5176 * alloc.c, bidi.c, charset.c, coding.c, dispnew.c, fns.c, image.c:
5177 * intervals.c, keyboard.c, process.c, syntax.c, textprop.c, w32term.c:
5178 * xdisp.c, xfaces.c, xterm.c: Replace all uses of INLINE with inline.
5179 * gmalloc.c (register_heapinfo): Use inline unconditionally.
5180 * lisp.h (LISP_MAKE_RVALUE): Use inline, not __inline__.
5181
738db178
DN
51822011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
5183
5184 Make it possible to run ./temacs.
5185
5186 * callproc.c (set_initial_environment): Remove CANNOT_DUMP code,
5187 syms_of_callproc does the same thing. Remove test for
5188 "initialized", do it in the caller.
5189 * emacs.c (main): Avoid calling set_initial_environment when dumping.
5190
620c53a6
SM
51912011-05-31 Stefan Monnier <monnier@iro.umontreal.ca>
5192
5193 * minibuf.c (Finternal_complete_buffer): Return `category' metadata.
5194 (read_minibuf): Use get_minibuffer.
5195 (syms_of_minibuf): Use DEFSYM.
5196 (Qmetadata): New var.
5197 * data.c (Qbuffer): Don't make it static.
5198 (syms_of_data): Use DEFSYM.
5199
e003a292
PE
52002011-05-31 Paul Eggert <eggert@cs.ucla.edu>
5201
5202 * ccl.c (CCL_CODE_RANGE): Allow negative numbers. (Bug#8751)
5203 (CCL_CODE_MIN): New macro.
5204
ed008a6d
PE
52052011-05-30 Paul Eggert <eggert@cs.ucla.edu>
5206
3687c2ef
PE
5207 * alloc.c (lisp_align_malloc): Omit unnecessary val==NULL tests.
5208
ed008a6d
PE
5209 * eval.c (Qdebug): Now static.
5210 * lisp.h (Qdebug): Remove decl. This reverts a part of the
5211 2011-04-26T11:26:05Z!dan.colascione@gmail.com that inadvertently undid part of
5212 2011-04-14T06:48:41Z!eggert@cs.ucla.edu.
5213
d66c4c7c
CY
52142011-05-29 Chong Yidong <cyd@stupidchicken.com>
5215
5216 * image.c: Various fixes to ImageMagick code comments.
5217 (Fimagemagick_types): Doc fix.
5218
5fbc2025
PE
52192011-05-29 Paul Eggert <eggert@cs.ucla.edu>
5220
0196f88a
PE
5221 Minor fixes prompted by GCC 4.6.0 warnings.
5222
5223 * xselect.c (converted_selections, conversion_fail_tag): Now static.
5224
5fbc2025
PE
5225 * emacs.c [HAVE_X_WINDOWS]: Include "xterm.h".
5226 (x_clipboard_manager_save_all): Move extern decl to ...
5227 * xterm.h: ... here, so that it can be checked for consistency.
5228
1dd3c2d9
CY
52292011-05-29 Chong Yidong <cyd@stupidchicken.com>
5230
5231 * xselect.c (x_clipboard_manager_save_frame)
5232 (x_clipboard_manager_save_all): New functions.
5233 (Fx_clipboard_manager_save): Lisp function deleted.
5234
5235 * emacs.c (Fkill_emacs): Call x_clipboard_manager_save_all.
5236 * frame.c (delete_frame): Call x_clipboard_manager_save_frame.
5237
5238 * xterm.h: Update prototype.
5239
5ba6571d
WX
52402011-05-28 William Xu <william.xwl@gmail.com>
5241
5242 * nsterm.m (ns_term_shutdown): Synchronize user defaults before
5243 exiting (Bug#8239).
5244
3eaff834
JM
52452011-05-28 Jim Meyering <meyering@redhat.com>
5246
e1900994 5247 Avoid a sign-extension bug in crypto_hash_function.
3eaff834
JM
5248 * fns.c (to_uchar): Define.
5249 (crypto_hash_function): Use it to convert some newly-signed
5250 variables to unsigned, to avoid sign-extension bugs. For example,
5251 without this change, (md5 "truc") would evaluate to
5252 45723a2aff78ff4fff7fff1114760e62 rather than the expected
5253 45723a2af3788c4ff17f8d1114760e62. Reported by Antoine Levitt in
e1900994 5254 https://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00883.html.
3eaff834 5255
0f6990a7
PE
52562011-05-27 Paul Eggert <eggert@cs.ucla.edu>
5257
5258 Integer overflow fixes.
c8a9ca5a 5259
08686060
PE
5260 * dbusbind.c: Serial number integer overflow fixes.
5261 (CHECK_DBUS_SERIAL_GET_SERIAL): New macro.
08686060
PE
5262 (Fdbus_call_method_asynchronously, xd_read_message_1): Use a float
5263 to hold a serial number that is too large for a fixnum.
5264 (Fdbus_method_return_internal, Fdbus_method_error_internal):
5265 Check for serial numbers out of range. Decode any serial number
59568bf0 5266 that was so large that it became a float. (Bug#8722)
08686060 5267
2d1fc3c7
PE
5268 * dbusbind.c: Use XFASTINT rather than XUINT, and check for nonneg.
5269 (Fdbus_call_method, Fdbus_call_method_asynchronously):
5270 Use XFASTINT rather than XUINT when numbers are nonnegative.
5271 (xd_append_arg, Fdbus_method_return_internal):
5272 (Fdbus_method_error_internal): Likewise. Also, for unsigned
5273 arguments, check that Lisp number is nonnegative, rather than
59568bf0 5274 silently wrapping negative numbers around. (Bug#8722)
30217ff0 5275 (xd_read_message_1): Don't assume dbus_uint32_t can fit in int.
59568bf0 5276 (Bug#8722)
2d1fc3c7 5277
c8a9ca5a
PE
5278 * data.c (arith_driver, Flsh): Avoid unnecessary casts to EMACS_UINT.
5279
519e1d69
PE
5280 * ccl.c (ccl_driver): Redo slightly to avoid the need for 'unsigned'.
5281
30569699
PE
5282 ccl: add integer overflow checks
5283 * ccl.c (CCL_CODE_MAX, GET_CCL_RANGE, GET_CCL_CODE, GET_CCL_INT):
5284 (IN_INT_RANGE): New macros.
5285 (ccl_driver): Use them to check for integer overflow when
5286 decoding a CCL program. Many of the new checks are whether XINT (x)
5287 fits in int; it doesn't always, on 64-bit hosts. The new version
5288 doesn't catch all possible integer overflows, but it's an
847044ea 5289 improvement. (Bug#8719)
30569699 5290
c11285dc
PE
5291 * alloc.c (make_event_array): Use XINT, not XUINT.
5292 There's no need for unsigned here.
5293
fdccd48e
PE
5294 * mem-limits.h (EXCEEDS_LISP_PTR) [!USE_LSB_TAG]: EMACS_UINT -> uintptr_t
5295 This follows up to the 2011-05-06 change that substituted uintptr_t
5296 for EMACS_INT. This case wasn't caught back then.
5297
37910ab2
PE
5298 Rework Fformat to avoid integer overflow issues.
5299 * editfns.c: Include <float.h> unconditionally, as it's everywhere
5300 now (part of C89). Include <verify.h>.
5301 (MAX_10_EXP, CONVERTED_BYTE_SIZE): Remove; no longer needed.
5302 (pWIDE, pWIDElen, signed_wide, unsigned_wide): New defns.
5303 (Fformat): Avoid the prepass trying to compute sizes; it was only
5304 approximate and thus did not catch overflow reliably. Instead, walk
5305 through the format just once, formatting and computing sizes as we go,
5306 checking for integer overflow at every step, and allocating a larger
5307 buffer as needed. Keep track separately whether the format is
5308 multibyte. Keep only the most-recently calculated precision, rather
5309 than them all. Record whether each argument has been converted to
5310 string. Use EMACS_INT, not int, for byte and char and arg counts.
5311 Support field widths and precisions larger than INT_MAX. Avoid
5312 sprintf's undefined behavior with conversion specifications such as %#d
5313 and %.0c. Fix bug with strchr succeeding on '\0' when looking for
5314 flags. Fix bug with (format "%c" 256.0). Avoid integer overflow when
5315 formatting out-of-range floating point numbers with int
9173deec 5316 formats. (Bug#8668)
37910ab2 5317
2e6578fb
PE
5318 * lisp.h (FIXNUM_OVERFLOW_P): Work even if arg is a NaN.
5319
0ae6bdee
PE
5320 * data.c: Avoid integer truncation in expressions involving floats.
5321 * data.c: Include <intprops.h>.
5322 (arith_driver): When there's an integer overflow in an expression
5323 involving floating point, convert the integers to floating point
5324 so that the resulting value does not suffer from catastrophic
5325 integer truncation. For example, on a 64-bit host (* 4
5326 most-negative-fixnum 0.5) should yield about -4.6e+18, not zero.
5327 Do not rely on undefined behavior after integer overflow.
5328
de883a70
PE
5329 merge count_size_as_multibyte, parse_str_to_multibyte
5330 * character.c, character.h (count_size_as_multibyte):
fd6fa53f 5331 Rename from parse_str_to_multibyte; all uses changed.
de883a70
PE
5332 Check for integer overflow.
5333 * insdel.c, lisp.h (count_size_as_multibyte): Remove,
5334 since it's now a duplicate of the other. This is more of
5335 a character than a buffer op, so better that it's in character.c.
5336 * fns.c, print.c: Adjust to above changes.
5337
2ff916cb
PE
53382011-05-27 Stefan Monnier <monnier@iro.umontreal.ca>
5339
5340 * xselect.c (x_convert_selection): Yet another int/Lisp_Object mixup.
5341
f1b54466
PE
53422011-05-27 Paul Eggert <eggert@cs.ucla.edu>
5343
fb1ac845
PE
5344 * xselect.c: Fix minor problems prompted by GCC 4.6.0 warnings.
5345 (x_handle_selection_request, frame_for_x_selection): Remove unused vars.
5346 (x_clipboard_manager_save): Now static.
5347 (Fx_clipboard_manager_save): Rename local to avoid shadowing.
5348
f1b54466
PE
5349 * fns.c: Fix minor problems prompted by GCC 4.6.0 warnings.
5350 (crypto_hash_function): Now static.
5351 Fix pointer signedness problems. Avoid unnecessary initializations.
5352
a9f737ee
CY
53532011-05-27 Chong Yidong <cyd@stupidchicken.com>
5354
5355 * termhooks.h (Vselection_alist): Make it terminal-local.
5356
5357 * terminal.c (create_terminal): Initialize it.
5358
5359 * xselect.c: Support for clipboard managers.
5360 (Vselection_alist): Move to termhooks.h as terminal-local var.
5361 (LOCAL_SELECTION): New macro.
5362 (x_atom_to_symbol): Handle x_display_info_for_display fail case.
5363 (symbol_to_x_atom): Remove gratuitous arg.
5364 (x_handle_selection_request, lisp_data_to_selection_data)
5365 (x_get_foreign_selection, Fx_register_dnd_atom): Callers changed.
620c53a6
SM
5366 (x_own_selection, x_get_local_selection, x_convert_selection):
5367 New arg, specifying work frame. Use terminal-local Vselection_alist.
a9f737ee
CY
5368 (some_frame_on_display): Delete unused function.
5369 (Fx_own_selection_internal, Fx_get_selection_internal)
5370 (Fx_disown_selection_internal, Fx_selection_owner_p)
5371 (Fx_selection_exists_p): New optional frame arg.
5372 (frame_for_x_selection, Fx_clipboard_manager_save): New functions.
5373 (x_handle_selection_clear): Don't treat other terminals with the
5374 same keyboard specially. Use the terminal-local Vselection_alist.
5375 (x_clear_frame_selections): Use Frun_hook_with_args.
5376
5377 * xterm.c (x_term_init): Intern ATOM and CLIPBOARD_MANAGER atoms.
5378
5379 * xterm.h: Add support for those atoms.
5380
e067f0c1
CY
53812011-05-26 Chong Yidong <cyd@stupidchicken.com>
5382
5383 * xselect.c: ICCCM-compliant handling of MULTIPLE targets.
5384 (converted_selections, conversion_fail_tag): New global variables.
5385 (x_selection_request_lisp_error): Free the above.
5386 (x_get_local_selection): Remove unnecessary code.
5387 (x_reply_selection_request): Args changed; handle arbitrary array
620c53a6
SM
5388 of converted selections stored in converted_selections.
5389 Separate the XChangeProperty and SelectionNotify steps.
e067f0c1
CY
5390 (x_handle_selection_request): Rewrite to handle MULTIPLE target.
5391 (x_convert_selection): New function.
5392 (x_handle_selection_event): Simplify.
5393 (x_get_foreign_selection): Don't ignore incoming requests while
5394 waiting for an answer; this will fail when we implement
5395 SAVE_TARGETS, and seems unnecessary anyway.
5396 (selection_data_to_lisp_data): Recognize ATOM_PAIR type.
5397 (Vx_sent_selection_functions): Doc fix.
5398
0f4aebc0
LL
53992011-05-26 Leo Liu <sdl.web@gmail.com>
5400
5401 * editfns.c (Ftranspose_regions): Allow empty regions. (Bug#8699)
5402
e61124cd
YM
54032011-05-25 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
5404
5405 * dispextern.h (struct glyph_row): New member fringe_bitmap_periodic_p.
5406
5407 * dispnew.c (shift_glyph_matrix, scrolling_window): Mark scrolled row
5408 for fringe update if it has periodic bitmap.
ac389d0c 5409 (row_equal_p): Also compare left_fringe_offset, right_fringe_offset,
e61124cd
YM
5410 and fringe_bitmap_periodic_p.
5411
5412 * fringe.c (get_fringe_bitmap_data): New function.
5413 (draw_fringe_bitmap_1, update_window_fringes): Use it.
5414 (update_window_fringes): Record periodicity of fringe bitmap in glyph
5415 row. Mark glyph row for fringe update if periodicity changed.
5416
5417 * xdisp.c (try_window_reusing_current_matrix): Don't mark scrolled row
5418 for fringe update unless it has periodic bitmap.
5419
f16d9837
KH
54202011-05-25 Kenichi Handa <handa@m17n.org>
5421
5422 * xdisp.c (get_next_display_element): Set correct it->face_id for
5423 a static composition.
5424
e1b90ef6
LL
54252011-05-24 Leo Liu <sdl.web@gmail.com>
5426
5427 * deps.mk (fns.o):
5428 * makefile.w32-in ($(BLD)/fns.$(O)): Include sha1.h.
5429
5430 * fns.c (crypto_hash_function, Fsha1): New function.
5431 (Fmd5): Use crypto_hash_function.
5432 (syms_of_fns): Add Ssha1.
5433
7400048f
PE
54342011-05-22 Paul Eggert <eggert@cs.ucla.edu>
5435
5436 * gnutls.c: Remove unused macros.
5437 (fn_gnutls_transport_set_lowat, fn_gnutls_transport_set_pull_function):
5438 (fn_gnutls_transport_set_push_function) [!WINDOWSNT]:
5439 Remove macros that are defined and never used.
5440 Caught by gcc -Wunused-macros (GCC 4.6.0, Fedora 14).
5441
abb71cf4
CY
54422011-05-22 Chong Yidong <cyd@stupidchicken.com>
5443
5444 * xselect.c (syms_of_xselect): Remove unused symbol SAVE_TARGETS.
5445 (Fx_get_selection_internal): Minor cleanup.
5446 (Fx_own_selection_internal): Rename arguments for consistency with
5447 select.el.
5448
6307db39
PE
54492011-05-22 Paul Eggert <eggert@cs.ucla.edu>
5450
5451 * xselect.c (QSAVE_TARGETS): New static var, to fix build failure.
5452
f3d4e0a4
CY
54532011-05-22 Chong Yidong <cyd@stupidchicken.com>
5454
5455 * xselect.c (syms_of_xselect): Include character.h; use DEFSYM.
5456
4d8ade89
YM
54572011-05-21 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
5458
5459 * dispnew.c (scrolling_window): Don't exclude the case that the
5460 last enabled row in the desired matrix touches the bottom boundary.
5461
32078c8d
GM
54622011-05-21 Glenn Morris <rgm@gnu.org>
5463
5464 * Makefile.in ($(etc)/DOC): Make second command line even shorter.
33cf345f
GM
5465 (SOME_MACHINE_OBJECTS): Replace FONT_OBJ by its maximal expansion,
5466 and add some more files.
32078c8d 5467
7285dc67
EZ
54682011-05-20 Eli Zaretskii <eliz@gnu.org>
5469
5470 * callproc.c (Fcall_process) [MSDOS]: Fix arguments to
5471 report_file_error introduced by the change from 2011-05-07.
5472
89d1bd22
PE
54732011-05-20 Paul Eggert <eggert@cs.ucla.edu>
5474
5475 * systime.h (Time): Define only if emacs is defined.
5476 This is to allow ../lib-src/profile.c to be compiled on FreeBSD,
5477 where the include path doesn't have X11/X.h by default. See
5478 <http://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00561.html>.
5479
e23640bb 54802011-05-20 Kenichi Handa <handa@m17n.org>
31bfc35c
KH
5481
5482 * composite.c (find_automatic_composition): Fix previous change.
5483
b9704ad9
GM
54842011-05-20 Glenn Morris <rgm@gnu.org>
5485
5486 * lisp.mk: New file, split from Makefile.in.
5487 * Makefile.in (lisp): Move to separate file, inserted by @lisp_frag@.
5488 (shortlisp): Remove.
5489 ($(etc)/DOC): Edit lisp.mk rather than using $shortlisp.
5490
4a720484
GM
54912011-05-19 Glenn Morris <rgm@gnu.org>
5492
5493 * Makefile.in (MSDOS_SUPPORT_REAL, MSDOS_SUPPORT, NS_SUPPORT)
5494 (REAL_MOUSE_SUPPORT, GPM_MOUSE_SUPPORT, MOUSE_SUPPORT, TOOLTIP_SUPPORT)
5495 (BASE_WINDOW_SUPPORT, X_WINDOW_SUPPORT, WINDOW_SUPPORT): Remove.
5496 (lisp): Set the order to that of loadup.el.
5497 (shortlisp): Make it a copy of $lisp.
5498 (SOME_MACHINE_LISP): Remove.
5499 ($(etc)/DOC): Depend just on $lisp, not $SOME_MACHINE_LISP too.
5500 Use just $shortlisp, not $SOME_MACHINE_LISP too.
5501
a28d4396
KH
55022011-05-18 Kenichi Handa <handa@m17n.org>
5503
5504 * composite.c (CHAR_COMPOSABLE_P): Add more check for efficiency.
5505 (BACKWARD_CHAR): Wrap the arg STOP by parenthesis.
5506 (find_automatic_composition): Mostly rewrite for efficiency.
5507
a2b1fa8e
JB
55082011-05-18 Juanma Barranquero <lekktu@gmail.com>
5509
5510 * makefile.w32-in: Update dependencies.
5511
8e1f5610
CS
55122011-05-18 Christoph Scholtes <cschol2112@googlemail.com>
5513
5514 * menu.c: Include limits.h (fixes the MS-Windows build broken by
7d7d0045 5515 2011-06-18T18:49:19Z!cyd@stupidchicken.com).
8e1f5610 5516
7025ee00 55172011-05-18 Paul Eggert <eggert@cs.ucla.edu>
cb93f9be 5518
cdfa6eab
PE
5519 Fix some integer overflow issues, such as string length overflow.
5520
06d6db33
PE
5521 * insdel.c (count_size_as_multibyte): Check for string overflow.
5522
2b4560a8
PE
5523 * character.c (lisp_string_width): Check for string overflow.
5524 Use EMACS_INT, not int, for string indexes and lengths; in
5525 particular, 2nd arg is now EMACS_INT, not int. Do not crash if
5526 the resulting string length overflows an EMACS_INT; instead,
5527 report a string overflow if no precision given. When checking for
5528 precision exhaustion, use a check that cannot possibly have
5529 integer overflow. (Bug#8675)
5530 * character.h (lisp_string_width): Adjust to new signature.
5531
cb93f9be
PE
5532 * alloc.c (string_overflow): New function.
5533 (Fmake_string): Use it. This doesn't change behavior, but saves
5534 a few bytes and will simplify future changes.
5535 * character.c (string_escape_byte8): Likewise.
5536 * lisp.h (string_overflow): New decl.
5537
1a1f3366
PE
5538 Fixups, following up to the user-interface timestamp change.
5539 * nsterm.m (last_mouse_movement_time, ns_mouse_position): Use Time
5540 for UI timestamps, instead of unsigned long.
9fbd6841
PE
5541 * msdos.c (mouse_get_pos): Likewise.
5542 * w32inevt.c (movement_time, w32_console_mouse_position): Likewise.
1a1f3366
PE
5543 * w32gui.h (Time): Define by including "systime.h" rather than by
5544 declaring it ourselves. (Bug#8664)
5545
d4e3e4d3
PE
5546 * dispextern.h (struct image): Don't assume time_t <= unsigned long.
5547 * image.c (clear_image_cache): Likewise.
5548
f6a24d19
PE
5549 * term.c (term_mouse_position): Don't assume time_t wraparound.
5550
08dc5ae6
PE
5551 Be more systematic about user-interface timestamps.
5552 Before, the code sometimes used 'Time', sometimes 'unsigned long',
620c53a6
SM
5553 and sometimes 'EMACS_UINT', to represent these timestamps.
5554 This change causes it to use 'Time' uniformly, as that's what X uses.
08dc5ae6
PE
5555 This makes the code easier to follow, and makes it easier to catch
5556 integer overflow bugs such as Bug#8664.
5557 * frame.c (Fmouse_position, Fmouse_pixel_position):
5558 Use Time, not unsigned long, for user-interface timestamps.
5559 * keyboard.c (last_event_timestamp, kbd_buffer_get_event): Likewise.
5560 (button_down_time, make_lispy_position, make_lispy_movement): Likewise.
5561 * keyboard.h (last_event_timestamp): Likewise.
5562 * menu.c (Fx_popup_menu) [!HAVE_X_WINDOWS]: Likewise.
5563 * menu.h (xmenu_show): Likewise.
5564 * term.c (term_mouse_position): Likewise.
5565 * termhooks.h (struct input_event.timestamp): Likewise.
5566 (struct terminal.mouse_position_hook): Likewise.
5567 * xmenu.c (create_and_show_popup_menu, xmenu_show): Likewise.
5568 * xterm.c (XTmouse_position, x_scroll_bar_report_motion): Likewise.
5569 * systime.h (Time): New decl. Pull it in from <X11/X.h> if
5570 HAVE_X_WINDOWS, otherwise define it as unsigned long, which is
5571 what it was before.
5572 * menu.h, termhooks.h: Include "systime.h", for Time.
5573
8e55734a
PE
5574 * keyboard.c (make_lispy_event): Fix problem in integer overflow.
5575 Don't assume that the difference between two unsigned long values
5576 can fit into an integer. At this point, we know button_down_time
5577 <= event->timestamp, so the difference must be nonnegative, so
5578 there's no need to cast the result if double-click-time is
5579 nonnegative, as it should be; check that it's nonnegative, just in
5580 case. This bug is triggered when events are more than 2**31 ms
86db42d2 5581 apart (about 25 days). (Bug#8664)
8e55734a 5582
841f1b75 5583 * xselect.c (last_event_timestamp): Remove duplicate decl.
6434756c 5584 (x_own_selection): Remove needless cast to unsigned long.
841f1b75 5585
3e26f69c
PE
5586 * xmenu.c (set_frame_menubar): Use int, not EMACS_UINT, for indexes
5587 that always fit in int. Use a sentinel instead of a counter, to
5588 avoid a temp and to allay GCC's concerns about possible int overflow.
d230cb74
PE
5589 * frame.h (struct frame): Use int for menu_bar_items_used
5590 instead of EMACS_INT, since it always fits in int.
3e26f69c 5591
5cc152c0
PE
5592 * menu.c (grow_menu_items): Check for int overflow.
5593
d89eb65e
PE
5594 * xmenu.c (set_frame_menubar): Don't mishandle vectors with no nils.
5595
5235bd3e
PE
5596 * xterm.c: Use EMACS_INT for Emacs modifiers, and int for X modifiers.
5597 Before, the code was not consistent. These values cannot exceed
5598 2**31 - 1 so there's no need to make them unsigned.
5599 (x_x_to_emacs_modifiers): Accept int and return EMACS_INT.
5600 (x_emacs_to_x_modifiers): Accept EMACS_INT and return int.
5601 (x_x_to_emacs_modifiers, x_emacs_to_x_modifiers): Reject non-integers
5602 as modifiers.
5603 * xterm.h (x_x_to_emacs_modifiers): Adjust to signature change.
5604
bc827e23
PE
5605 * lisp.h (XINT) [USE_LISP_UNION_TYPE]: Cast to EMACS_INT.
5606 (XUINT) [USE_LISP_UNION_TYPE]: Cast to EMACS_UINT.
5607 Otherwise, GCC 4.6.0 warns about printf (pI, XINT (...)),
5608 presumably because the widths might not match.
5609
78eb494e
PE
5610 * window.c (size_window): Avoid needless test at loop start.
5611
04f2d78b
CB
56122011-05-18 Courtney Bane <emacs-bugs-7626@cbane.org> (tiny change)
5613
5614 * term.c (Fresume_tty): Restore hooks before reinitializing (bug#8687).
5615
d2fc7e3d 56162011-05-12 Drew Adams <drew.adams@oracle.com>
e531bdff
DA
5617
5618 * textprop.c (Fprevious_single_char_property_change): Doc fix (bug#8655).
5619
d2fc7e3d 56202011-05-12 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
7db47798
YM
5621
5622 * w32term.c (w32_draw_fringe_bitmap): Rename local vars `left' and
5623 `width' to `bar_area_x' and `bar_area_width', respectively.
5624 (x_scroll_run): Take account of fringe background extension.
5625
04f2d78b
CB
5626 * xterm.c (x_draw_fringe_bitmap) [USE_TOOLKIT_SCROLL_BARS]:
5627 Rename local vars `left' and `width' to `bar_area_x' and
7db47798
YM
5628 `bar_area_width', respectively.
5629 (x_scroll_run) [USE_TOOLKIT_SCROLL_BARS]: Take account of fringe
5630 background extension.
5631
79b70037
GM
56322011-05-10 Jim Meyering <meyering@redhat.com>
5633
5634 * xdisp.c (x_intersect_rectangles): Fix typo "the the -> the".
5635
2f142cc5
JB
56362011-05-10 Juanma Barranquero <lekktu@gmail.com>
5637
5638 * image.c (Finit_image_library): Return t for built-in image types,
5639 like pbm and xbm. (Bug#8640)
5640
57679c86
AS
56412011-05-09 Andreas Schwab <schwab@linux-m68k.org>
5642
5643 * w32menu.c (set_frame_menubar): Fix submenu allocation.
5644
888c9e86
EZ
56452011-05-07 Eli Zaretskii <eliz@gnu.org>
5646
b0512a1d
EZ
5647 * w32console.c (Fset_screen_color): Doc fix.
5648 (Fget_screen_color): New function.
5649 (syms_of_ntterm): Defsubr it.
5650
7285dc67
EZ
5651 * callproc.c (call_process_cleanup) [MSDOS]: Don't close and
5652 unlink the temporary file if Fcall_process didn't create it in the
5653 first place.
5654 (Fcall_process) [MSDOS]: Don't create tempfile if stdout of the
5655 child process will be redirected to a file specified with `:file'.
888c9e86
EZ
5656 Don't try to re-open tempfile in that case, and set fd[0] to -1 as
5657 cue to call_process_cleanup not to close that handle.
5658
4d3fcc8e
BK
56592011-05-07 Ben Key <bkey76@gmail.com>
5660
5661 * makefile.w32-in: The bootstrap-temacs rule now makes use of
5662 one of two shell specific rules, either bootstrap-temacs-CMD or
5663 bootstrap-temacs-SH. The bootstrap-temacs-SH rule is identical
5664 to the previous implementation of the bootstrap-temacs rule.
5665 The bootstrap-temacs-CMD rule is similar to the previous
5666 implementation of the bootstrap-temacs rule except that it
5667 makes use of the ESC_CFLAGS variable instead of the CFLAGS
5668 variable.
5669
5670 These changes, along with some changes to nt/configure.bat,
5671 nt/gmake.defs, and nt/nmake.defs, are required to extend my
5672 earlier fix to add support for --cflags and --ldflags options
5673 that include quotes so that it works whether make uses cmd or
5674 sh as the shell.
5675
b4289b64
MA
56762011-05-06 Michael Albinus <michael.albinus@gmx.de>
5677
5678 * dbusbind.c (QCdbus_type_unix_fd): Declare static.
5679 (xd_remove_watch): Don't check QCdbus_type_unix_fd for SYMBOLP, it
5680 is a constant.
5681 (Fdbus_init_bus, xd_read_queued_messages): Bus can be a symbol or
5682 a string. Handle both cases.
5683 (Fdbus_call_method_asynchronously, Fdbus_register_signal)
5684 (Fdbus_register_method): Use Qinvalid_function.
5685
af4c0e28
JB
56862011-05-06 Juanma Barranquero <lekktu@gmail.com>
5687
5688 * makefile.w32-in: Update dependencies.
5689 (LISP_H): Add inttypes.h and stdin.h.
5690 (PROCESS_H): Add unistd.h.
5691
c51453d9
EZ
56922011-05-06 Eli Zaretskii <eliz@gnu.org>
5693
5694 * lread.c: Include limits.h (fixes the MS-Windows build broken by
5695 2011-05-06T07:13:19Z!eggert@cs.ucla.edu).
5696
8ff0ac3c 56972011-05-06 Paul Eggert <eggert@cs.ucla.edu>
c032b5f8 5698
4c4b566b
PE
5699 * image.c (Finit_image_library) [!HAVE_NTGUI]: Omit unused local.
5700
aab2b9b5
PE
5701 * term.c (vfatal): Remove stray call to va_end.
5702 It's not needed and the C Standard doesn't allow it here anyway.
5703
c378da0b
PE
5704 Use C99's va_copy to avoid undefined behavior on x86-64 GNU/Linux.
5705 * eval.c (verror): doprnt a copy of ap, not the original. (Bug#8545)
5706
288b08c7
PE
5707 * eval.c (verror): OK to create a string of up to MOST_POSITIVE_FIXNUM
5708 bytes.
5709
e3601888
PE
5710 * term.c: Don't include <stdarg.h>, as <lisp.h> does that.
5711
db6c0e74
PE
5712 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork clobbering.
5713
dd5963ea
PE
5714 * process.c (Fformat_network_address): Fix typo: args2 -> *args2.
5715
88c9450f
PE
5716 * xmenu.c (set_frame_menubar): Fix typo: int * -> int (3 times).
5717
2f9442b8
PE
5718 * coding.c (detect_coding_charset): Fix typo: * 2 -> *4 (Bug#8601).
5719
c032b5f8
PE
5720 * charset.h (struct charset.code_space): Now has 15 elements, not 16.
5721 * charset.c (Fdefine_charset_internal): Don't initialize
5722 charset.code_space[15]. The value was garbage, on hosts with
2d38271b 5723 32-bit int (Bug#8600).
a108c10b
PE
5724
5725 * lread.c (read_integer): Be more consistent with string-to-number.
5726 Use string_to_number to do the actual conversion; this avoids
5727 rounding errors and fixes some other screwups. Without this fix,
5728 for example, #x1fffffffffffffff was misread as -2305843009213693952.
5729 (digit_to_number): Move earlier, for benefit of read_integer.
5730 Return -1 if the digit is out of range for the base, -2 if it is
48e400f0 5731 not a digit in any supported base. (Bug#8602)
a108c10b 5732
ad5f9eea
PE
5733 * doprnt.c (doprnt): Support arbitrary pI values, such as "I64".
5734
aec1708a
PE
5735 * dispnew.c (scrolling_window): Return 1 if we scrolled,
5736 to match comment at start of function. This also removes a
5737 GCC warning about overflow in a 32+64-bit port.
5738
47be4ab5
PE
5739 * lisp.h (EMACS_INT, EMACS_UINT, BITS_PER_EMACS_INT, pI): Simplify.
5740
371cac43
PE
5741 * dbusbind.c: Do not use XPNTR on a value that may be an integer.
5742 Reported by Stefan Monnier in
5743 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00919.html>.
04f2d78b
CB
5744 (xd_remove_watch, Fdbus_init_bus, xd_read_queued_messages):
5745 Use SYMBOLP-guarded XSYMBOL, not XPNTR.
371cac43 5746
d01a7826
PE
5747 * lisp.h (EMACS_INTPTR): Remove. All uses changed to intptr_t.
5748 (EMACS_UINTPTR): Likewise, with uintptr_t.
5749
7fd47d5c
PE
5750 * lisp.h: Prefer 64-bit EMACS_INT if available.
5751 (EMACS_INT, EMACS_UINT, BITS_PER_EMACS_INT, pI): Define to 64-bit
5752 on 32-bit hosts that have 64-bit int, so that they can access
5753 large files.
122b0c86
PE
5754 However, temporarily disable this change unless the temporary
5755 symbol WIDE_EMACS_INT is defined.
7fd47d5c 5756
8727937b
PE
5757 * lread.c, process.c: Do not include <inttypes.h>; lisp.h does it now.
5758
8ac068ac
PE
5759 Prefer intptr_t/uintptr_t for integers the same widths as pointers.
5760 This removes an assumption that EMACS_INT and long are the same
5761 width as pointers. The assumption is true for Emacs porting targets
5762 now, but we want to make other targets possible.
5763 * lisp.h: Include <inttypes.h>, for INTPTR_MAX, UINTPTR_MAX.
5764 (EMACS_INTPTR, EMACS_UINTPTR): New macros.
5765 In the rest of the code, change types of integers that hold casted
5766 pointers to EMACS_INTPTR and EMACS_UINTPTR, systematically
5767 replacing EMACS_INT, long, EMACS_UINT, and unsigned long.
5768 (XTYPE): Don't cast arg to EMACS_UINT; normally is not needed.
5769 (XSET): Cast type of XTYPE arg to EMACS_INTPTR; it is needed here.
5770 No need to cast type when ORing.
5771 (XPNTR): Return a value of type EMACS_INTPTR or EMACS_UINTPTR.
5772 * alloc.c (lisp_align_malloc): Remove a no-longer-needed cast.
5773 * doc.c (store_function_docstring): Use EMACS_INTPTR, so as not to
5774 assume EMACS_INT is the same width as char *.
5775 * gtkutil.c (xg_gtk_scroll_destroy, xg_tool_bar_button_cb):
5776 (xg_tool_bar_callback, xg_tool_bar_help_callback, xg_make_tool_item):
5777 Remove no-longer-needed casts.
5778 (xg_create_scroll_bar, xg_tool_bar_button_cb, xg_tool_bar_callback):
5779 (xg_tool_bar_help_callback, xg_make_tool_item):
5780 Use EMACS_INTPTR to hold an integer
5781 that will be cast to void *; this can avoid a GCC warning
5782 if EMACS_INT is not the same width as void *.
5783 * menu.c (find_and_call_menu_selection): Remove no-longer-needed cast.
5784 * xdisp.c (display_echo_area_1, resize_mini_window_1):
5785 (current_message_1, set_message_1):
5786 Use a local to convert to proper width without a cast.
5787 * xmenu.c (dialog_selection_callback): Likewise.
5788
ede49d71
PE
5789 * sysdep.c (get_random): Don't assume EMACS_INT is no wider than long.
5790 Also, don't assume VALBITS / RAND_BITS is less than 5,
5791 and don't rely on undefined behavior when shifting a 1 left into
5792 the sign bit.
5793 * lisp.h (get_random): Change signature to match.
5794
2f30ecd0
PE
5795 * lread.c (hash_string): Use size_t, not int, for hash computation.
5796 Normally we prefer signed values; but hashing is special, because
5797 it's better to use unsigned division on hash table sizes so that
5798 the remainder is nonnegative. Also, size_t is the natural width
5799 for hashing into memory. The previous code used 'int', which doesn't
5800 retain enough info to hash well into very large tables.
5801 (oblookup, oblookup_last_bucket_number, Funintern): Likewise.
5802
2a866e7b
PE
5803 * dbusbind.c: Don't possibly lose pointer info when converting.
5804 (xd_remove_watch, Fdbus_init_bus, xd_read_queued_messages):
5805 Use XPNTR rather than XHASH, so that the high-order bits of
5806 the pointer aren't lost when converting through void *.
5807
51639eac
PE
5808 * eval.c (Fautoload): Don't double-shift a pointer.
5809
92394119
PE
5810 * fns.c (Frandom): Let EMACS_UINT be wider than unsigned long.
5811
dbdb9a7c
JB
58122011-05-06 Juanma Barranquero <lekktu@gmail.com>
5813
5814 * gnutls.c (DEF_GNUTLS_FN):
5815 * image.c (DEF_IMGLIB_FN): Make function pointers static.
5816
db7a0b4f
AS
58172011-05-05 Andreas Schwab <schwab@linux-m68k.org>
5818
5819 * lread.c (lisp_file_lexically_bound_p): Stop scanning at end
5820 marker. (Bug#8610)
5821
f7ff1b0f 58222011-05-05 Eli Zaretskii <eliz@gnu.org>
fab624aa
EZ
5823
5824 * w32heap.c (allocate_heap) [USE_LISP_UNION_TYPE || USE_LSB_TAG]:
5825 New version that can reserve upto 2GB of heap space.
5826
f7ff1b0f 58272011-05-05 Chong Yidong <cyd@stupidchicken.com>
45cb8994
CY
5828
5829 * nsfns.m (Fns_read_file_name): Doc fix (Bug#8534).
5830
639c109b
TZ
58312011-05-05 Teodor Zlatanov <tzz@lifelogs.com>
5832
5833 * gnutls.c (fn_gnutls_certificate_set_x509_key_file): Add alias to
5834 `gnutls_certificate_set_x509_key_file'.
5835
d2127135
JB
58362011-05-05 Juanma Barranquero <lekktu@gmail.com>
5837
5838 * makefile.w32-in ($(BLD)/image.$(O), $(BLD)/process.$(O)):
5839 Update dependencies.
5840
e968f4f3
JB
58412011-05-04 Juanma Barranquero <lekktu@gmail.com>
5842
5843 * gnutls.h (emacs_gnutls_write, emacs_gnutls_read):
5844 * gnutls.c (emacs_gnutls_write, emacs_gnutls_read):
5845 Remove unused parameter `fildes'.
5846 * process.c (read_process_output, send_process): Don't pass it.
5847
84d358f0
JB
58482011-05-04 Juanma Barranquero <lekktu@gmail.com>
5849
5850 Fix previous change: the library cache is defined in w32.c.
5851 * image.c (CACHE_IMAGE_TYPE) [!HAVE_NTGUI]: Define to noop.
5852 (Finit_image_library): Wrap Vlibrary_cache on "#ifdef HAVE_NTGUI".
5853
0898ca10
JB
58542011-05-04 Juanma Barranquero <lekktu@gmail.com>
5855
5856 Implement dynamic loading of GnuTLS on Windows.
5857
5858 * gnutls.h (GNUTLS_EMACS_ERROR_NOT_LOADED): New macro.
5859 (emacs_gnutls_write, emacs_gnutls_read): Mark as extern.
5860 (emacs_gnutls_record_check_pending, emacs_gnutls_transport_set_errno):
5861 Declare.
5862
5863 * gnutls.c (Qgnutls_dll): Define.
5864 (DEF_GNUTLS_FN, LOAD_GNUTLS_FN): New macros.
5865 (gnutls_*): Declare function pointers.
5866 (init_gnutls_functions): New function to initialize function pointers.
5867 (emacs_gnutls_handshake, Fgnutls_error_string, Fgnutls_deinit)
5868 (emacs_gnutls_global_init, Fgnutls_bye): Use function pointers.
5869 (emacs_gnutls_record_check_pending, emacs_gnutls_transport_set_errno):
5870 Wrappers for gnutls_record_check_pending and gnutls_transport_set_errno.
5871 (emacs_gnutls_write, emacs_gnutls_read)
5872 (emacs_gnutls_handle_error, Fgnutls_error_fatalp)
5873 (Fgnutls_available_p): New function.
5874 (Fgnutls_boot): Call Fgnutls_available_p. Use function pointers.
5875 (syms_of_gnutls) <Qgnutls_dll>: Initialize and staticpro it.
5876 (syms_of_gnutls) <Sgnutls_available_p>: defsubr it.
5877
5878 * image.c: Include w32.h.
5879 (Vimage_type_cache): Delete.
5880 (syms_of_image) <Vimage_type_cache>: Don't initialize and staticpro it.
5881 (CACHE_IMAGE_TYPE, Finit_image_library): Use Vlibrary_cache instead.
5882 (w32_delayed_load): Move to w32.c.
5883
5884 * w32.h (VlibraryCache, QCloaded_from, w32_delayed_load): Declare.
5885
5886 * w32.c (QCloaded_from, Vlibrary_cache): Define.
5887 (w32_delayed_load): Move from image.c. When loading a library, record
5888 its filename in the :loaded-from property of the library id.
5889 (globals_of_w32) <QCloaded_from, Vlibrary_cache>:
5890 Initialize and staticpro them.
5891 (emacs_gnutls_pull, emacs_gnutls_push): Call emacs_gnutls_* functions.
5892
5893 * process.c: Include lisp.h before w32.h, not after.
5894 (wait_reading_process_output): Call emacs_gnutls_record_check_pending
5895 instead of gnutls_record_check_pending.
5896
5897 * callproc.c, emacs.c: Include lisp.h before w32.h, not after.
5898
ff4de4aa
TZ
58992011-05-04 Teodor Zlatanov <tzz@lifelogs.com>
5900
5901 * gnutls.c (Fgnutls_boot): Support :keylist and :crlfiles options
5902 instead of :keyfiles. Give GnuTLS the keylist and the CRL lists
5903 as passed in.
5904
abe95abb
JD
59052011-05-03 Jan Djärv <jan.h.d@swipnet.se>
5906
5907 * xterm.c (x_set_frame_alpha): Do not set property on anything
5908 else than FRAME_X_OUTER_WINDOW (Bug#8608).
5909
e16e55d4
JB
59102011-05-02 Juanma Barranquero <lekktu@gmail.com>
5911
5912 * sysdep.c (get_tty_size) [WINDOWSNT]: Implement. (Bug#8596)
5913
bafcf6a5
JB
59142011-05-02 Juanma Barranquero <lekktu@gmail.com>
5915
5916 * gnutls.c (Qgnutls_log_level, Qgnutls_code, Qgnutls_anon)
5917 (Qgnutls_x509pki, Qgnutls_e_interrupted, Qgnutls_e_again)
5918 (Qgnutls_e_invalid_session, Qgnutls_e_not_ready_for_handshake)
5919 (gnutls_global_initialized, Qgnutls_bootprop_priority)
5920 (Qgnutls_bootprop_trustfiles, Qgnutls_bootprop_keyfiles)
5921 (Qgnutls_bootprop_callbacks, Qgnutls_bootprop_loglevel)
5922 (Qgnutls_bootprop_hostname, Qgnutls_bootprop_verify_flags)
5923 (Qgnutls_bootprop_verify_error, Qgnutls_bootprop_verify_hostname_error)
5924 (Qgnutls_bootprop_callbacks_verify): Make static.
5925
e7a6747f
AS
59262011-05-01 Andreas Schwab <schwab@linux-m68k.org>
5927
19ed11ba
AS
5928 * callproc.c: Indentation fixup.
5929
e7a6747f 5930 * sysdep.c (wait_for_termination_1): Make static.
04f2d78b
CB
5931 (wait_for_termination, interruptible_wait_for_termination):
5932 Move after wait_for_termination_1.
e7a6747f 5933
1ef14cb4
LMI
59342011-05-01 Lars Magne Ingebrigtsen <larsi@gnus.org>
5935
5936 * sysdep.c (interruptible_wait_for_termination): New function
5937 which is like wait_for_termination, but allows keyboard
5938 interruptions.
5939
5940 * callproc.c (Fcall_process): Add (:file "file") as an option for
5941 the STDOUT buffer.
5942 (Fcall_process_region): Ditto.
5943
330d880c
EZ
59442011-04-30 Eli Zaretskii <eliz@gnu.org>
5945
8db90b73
EZ
5946 * dosfns.c (Fint86, Fdos_memget, Fdos_memput): Use `ASIZE (FOO)'
5947 rather than `XVECTOR (FOO)->size'.
5948
330d880c
EZ
5949 * process.c: Remove HAVE_INTTYPES_H condition from inclusion of
5950 inttypes.h, as a gnulib replacement is used if it not available in
5951 system headers.
5952
15cbd324
EZ
59532011-04-21 Eli Zaretskii <eliz@gnu.org>
5954
5955 Lift the MOST_POSITIVE_FIXNUM/4 limitation on visited files.
5956 * fileio.c (Finsert_file_contents): Don't limit file size to 1/4
5957 of MOST_POSITIVE_FIXNUM. (Bug#8528)
5958
5959 * coding.c (coding_alloc_by_realloc): Error out if destination
5960 will grow beyond MOST_POSITIVE_FIXNUM.
5961 (decode_coding_emacs_mule): Abort if there isn't enough place in
5962 charbuf for the composition carryover bytes. Reserve an extra
5963 space for up to 2 characters produced in a loop.
5964 (decode_coding_iso_2022): Abort if there isn't enough place in
5965 charbuf for the composition carryover bytes.
5966
59672011-04-21 Eli Zaretskii <eliz@gnu.org>
afda1437 5968
ae940cca
EZ
5969 * doprnt.c (doprnt) [!HAVE_LONG_LONG_INT]: Error out instead of
5970 aborting when %lld or %lll format is passed.
5971 [!HAVE_UNSIGNED_LONG_LONG_INT]: Error out instead of aborting when
5972 %llo or %llx format is passed. (Bug#8545)
5973
03ab8921
EZ
5974 * window.c (window_scroll_line_based): Use a marker instead of
5975 simple variables to record original value of point. (Bug#7952)
5976
afda1437
EZ
5977 * doprnt.c (doprnt): Fix the case where a multibyte sequence
5978 produced by %s or %c overflows available buffer space. (Bug#8545)
5979
f76dee0c
PE
59802011-04-28 Paul Eggert <eggert@cs.ucla.edu>
5981
5982 * doprnt.c (doprnt): Omit useless test; int overflow check (Bug#8545).
283cdbef 5983 (SIZE_MAX): Move defn after all includes, as they might #define it.
f76dee0c 5984
fdc5744d
JB
59852011-04-28 Juanma Barranquero <lekktu@gmail.com>
5986
5987 * w32.c (init_environment): Warn about defaulting HOME to C:\.
5988
638f053a
JB
59892011-04-28 Juanma Barranquero <lekktu@gmail.com>
5990
5991 * keyboard.c (Qdelayed_warnings_hook): Define.
5992 (command_loop_1): Run `delayed-warnings-hook'
5993 if Vdelayed_warnings_list is non-nil.
5994 (syms_of_keyboard) <delayed-warnings-hook>: DEFSYM it.
5995 (syms_of_keyboard) <delayed-warnings-list>: DEFVAR_LISP it.
5996
d178f871
EZ
59972011-04-28 Eli Zaretskii <eliz@gnu.org>
5998
5999 * doprnt.c (doprnt): Don't return value smaller than the buffer
6000 size if the message was truncated. (Bug#8545).
6001
b124fd93
JB
60022011-04-28 Juanma Barranquero <lekktu@gmail.com>
6003
6004 * w32fns.c (Fx_change_window_property, Fx_delete_window_property)
6005 (Fx_window_property): #if-0 the whole functions, not just the bodies.
6006
e810457d
PE
60072011-04-27 Paul Eggert <eggert@cs.ucla.edu>
6008
6009 * doprnt.c (doprnt): Support "ll" length modifier, for long long.
6010
ea51cceb
JB
60112011-04-27 Juanma Barranquero <lekktu@gmail.com>
6012
6013 * makefile.w32-in: Update dependencies.
6014
94dcfacf
EZ
60152011-04-27 Eli Zaretskii <eliz@gnu.org>
6016
6017 Improve `doprnt' and its usage. (Bug#8545)
6018 * doprnt.c (doprnt): Make sure `format' is never accessed beyond
6019 `format_end'. Remove support for %l as a conversion specifier.
6020 Don't use xrealloc. Improve diagnostics when the %l size modifier
6021 is used. Update the commentary.
6022
6023 * eval.c (verror): Simplify calculation of size_t.
6024
6025 * coding.c (Ffind_operation_coding_system): Fix diagnostic error
6026 messages.
6027
f61f41d7
PE
60282011-04-27 Yoshiaki Kasahara <kasahara@nc.kyushu-u.ac.jp> (tiny change)
6029
6030 * buffer.c (init_buffer) [USE_MMAP_FOR_BUFFERS]: Adjust to aliasing
6031 change.
6032
96fb4434
PE
60332011-04-27 Paul Eggert <eggert@cs.ucla.edu>
6034
6035 * nsmenu.m: Replace all uses of XVECTOR with ASIZE and AREF.
6036 This makes this file independent of the recent pseudovector change.
6037
671875da 60382011-04-26 Paul Eggert <eggert@cs.ucla.edu>
eab3844f 6039
69e9b5a3
PE
6040 * keyboard.c (handle_user_signal): Fix pointer signedness problem.
6041
b5f869a7 6042 * gnutls.c (emacs_gnutls_handle_error): Remove unused local.
7754e151 6043 (Fgnutls_boot): gnutls_certificate_verify_peers2 wants unsigned *.
8d4c3955 6044 Remove unused local.
c8926152 6045 (emacs_gnutls_write): Don't use uninitialized rtnval if nbyte <= 0.
080e5a8d 6046
841a1577 6047 * lisp.h: Fix a problem with aliasing and vector headers. (Bug#8546)
04f2d78b
CB
6048 GCC 4.6.0 optimizes based on type-based alias analysis.
6049 For example, if b is of type struct buffer * and v of type struct
eab3844f
PE
6050 Lisp_Vector *, then gcc -O2 was incorrectly assuming that &b->size
6051 != &v->size, and therefore "v->size = 1; b->size = 2; return
6052 v->size;" must therefore return 1. This assumption is incorrect
6053 for Emacs, since it type-puns struct Lisp_Vector * with many other
6054 types. To fix this problem, this patch adds a new type struct
f904488f 6055 vectorlike_header that documents the constraints on layout of vectors
eab3844f
PE
6056 and pseudovectors, and helps optimizing compilers not get fooled
6057 by Emacs's type punning. It also adds the macros XSETTYPED_PVECTYPE
6058 XSETTYPED_PSEUDOVECTOR, TYPED_PSEUDOVECTORP, for similar reasons.
f904488f
PE
6059 * lisp.h (XSETTYPED_PVECTYPE): New macro, specifying the name of
6060 the size member.
eab3844f
PE
6061 (XSETPVECTYPE): Rewrite in terms of new macro.
6062 (XSETPVECTYPESIZE): New macro, specifying both type and size.
6063 This is a bit clearer, and further avoids the possibility of
6064 undesirable aliasing.
6065 (XSETTYPED_PSEUDOVECTOR): New macro, specifying the size.
f904488f 6066 (XSETPSEUDOVECTOR): Rewrite in terms of XSETTYPED_PSEUDOVECTOR.
eab3844f
PE
6067 (XSETSUBR): Rewrite in terms of XSETTYPED_PSEUDOVECTOR and XSIZE,
6068 since Lisp_Subr is a special case (no "next" field).
04f2d78b
CB
6069 (ASIZE): Now uses header.size rather than size.
6070 All previous uses of XVECTOR (foo)->size replaced to use this macro,
f904488f
PE
6071 to avoid the hassle of writing XVECTOR (foo)->header.size.
6072 (struct vectorlike_header): New type.
eab3844f
PE
6073 (TYPED_PSEUDOVECTORP): New macro, also specifying the C type of the
6074 object, to help avoid aliasing.
6075 (PSEUDOVECTORP): Rewrite in terms of TYPED_PSEUDOVECTORP.
6076 (SUBRP): Likewise, since Lisp_Subr is a special case.
6077 * lisp.h (struct Lisp_Vector, struct Lisp_Char_Table):
6078 (struct Lisp_Sub_Char_Table, struct Lisp_Bool_Vector):
6079 (struct Lisp_Hash_Table): Combine first two members into a single
f904488f 6080 struct vectorlike_header member. All uses of "size" and "next" members
eab3844f
PE
6081 changed to be "header.size" and "header.next".
6082 * buffer.h (struct buffer): Likewise.
6083 * font.h (struct font_spec, struct font_entity, struct font): Likewise.
6084 * frame.h (struct frame): Likewise.
6085 * process.h (struct Lisp_Process): Likewise.
6086 * termhooks.h (struct terminal): Likewise.
6087 * window.c (struct save_window_data, struct saved_window): Likewise.
6088 * window.h (struct window): Likewise.
6089 * alloc.c (allocate_buffer, Fmake_bool_vector, allocate_pseudovector):
6090 Use XSETPVECTYPESIZE, not XSETPVECTYPE, to avoid aliasing problems.
6091 * buffer.c (init_buffer_once): Likewise.
6092 * lread.c (defsubr): Use XSETTYPED_PVECTYPE, since Lisp_Subr is a
6093 special case.
6094 * process.c (Fformat_network_address): Use local var for size,
6095 for brevity.
6096
0df1eac5
PE
6097 * bytecode.c (exec_byte_code): Don't use XVECTOR before CHECK_VECTOR.
6098
847ab9d1 6099 Make the Lisp reader and string-to-float more consistent (Bug#8525)
452f4150
PE
6100 * data.c (atof): Remove decl; no longer used or needed.
6101 (digit_to_number): Move to lread.c.
6102 (Fstring_to_number): Use new string_to_number function, to be
6103 consistent with how the Lisp reader treats infinities and NaNs.
6104 Do not assume that floating-point numbers represent EMACS_INT
6105 without losing information; this is not true on most 64-bit hosts.
6106 Avoid double-rounding errors, by insisting on integers when
6107 parsing non-base-10 numbers, as the documentation specifies.
6108 * lisp.h (string_to_number): New decl, replacing ...
6109 (isfloat_string): Remove.
bc0a5c13 6110 * lread.c: Include <inttypes.h>, for uintmax_t and strtoumax.
d78050d6 6111 (read1): Do not accept +. and -. as integers; this
452f4150
PE
6112 appears to have been a coding error. Similarly, do not accept
6113 strings like +-1e0 as floating point numbers. Do not report
6114 overflow for integer overflows unless the base is not 10 which
6115 means we have no simple and reliable way to continue.
6116 Break out the floating-point parsing into a new
6117 function string_to_number, so that Fstring_to_number parses
6118 floating point numbers consistently with the Lisp reader.
04f2d78b 6119 (digit_to_number): Move here from data.c. Make it static inline.
452f4150
PE
6120 (E_CHAR, EXP_INT): Remove, replacing with ...
6121 (E_EXP): New macro, to solve the "1.0e+" problem mentioned below.
6122 (string_to_number): New function, replacing isfloat_string.
6123 This function checks for valid syntax and produces the resulting
6124 Lisp float number too. Rework it so that string-to-number
bc0a5c13 6125 no longer mishandles examples like "1.0e+". Use strtoumax,
d78050d6
PE
6126 so that overflow for non-base-10 numbers is reported only when
6127 there's no portable and simple way to convert to floating point.
452f4150 6128
67769ffc
PE
6129 * textprop.c (set_text_properties_1): Rewrite for clarity,
6130 and to avoid GCC warning about integer overflow.
6131
c20db43f
PE
6132 * intervals.h (struct interval): Use EMACS_INT for members
6133 where EMACS_UINT might cause problems. See
6134 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00514.html>.
6135 (CHECK_TOTAL_LENGTH): Remove cast to EMACS_INT; no longer needed.
6136 * intervals.c (interval_deletion_adjustment): Now returns EMACS_INT.
6137 All uses changed.
37aa2f85
PE
6138 (offset_intervals): Tell GCC not to worry about length overflow
6139 when negating a negative length.
c20db43f 6140
2538aa2f
PE
6141 * alloc.c (overrun_check_malloc, overrun_check_realloc): Now static.
6142 (overrun_check_free): Likewise.
6143
f2d3008d
PE
6144 * alloc.c (SDATA_SIZE) [!GC_CHECK_STRING_BYTES]: Avoid runtime check
6145 in the common case where SDATA_DATA_OFFSET is a multiple of Emacs
6146 word size.
6147
ec8df744
PE
6148 * gnutls.c: Fix problems found by GCC 4.6.0 on Ubuntu 10.10.
6149 (gnutls_make_error): Rename local to avoid shadowing.
6150 (gnutls_emacs_global_deinit): ifdef out; not used.
6151 (Fgnutls_boot): Use const for pointer to readonly storage.
6152 Comment out unused local. Fix pointer signedness problems.
6153
640ee02d
PE
6154 * lread.c (openp): Don't stuff size_t into an 'int'.
6155 Use <= on length, not < on length + 1, to avoid GCC 4.6.0 warning
6156 about possible signed overflow.
6157
6048fb2a
PE
6158 * gtkutil.c: Fix problems found by GCC 4.6.0 on Ubuntu 10.10.
6159 (GDK_KEY_g): Don't define if already defined.
6160 (xg_prepare_tooltip): Avoid pointer signedness problem.
6161 (xg_set_toolkit_scroll_bar_thumb): Redo to avoid two casts.
6162
fa3c87e1
PE
6163 * process.c (Fnetwork_interface_info): Avoid left-shift undefined
6164 behavior with 1 << 31. GCC 4.6.0 warns about this on 32-bit hosts.
6165
2172544b
PE
6166 * xfns.c (Fx_window_property): Simplify a bit,
6167 to make a bit faster and to avoid GCC 4.6.0 warning.
6168 * xselect.c (x_get_window_property, x_handle_dnd_message): Likewise.
6169
9b821a21
PE
6170 * fns.c (internal_equal): Don't assume size_t fits in int.
6171
3c616cfa
PE
6172 * alloc.c (compact_small_strings): Tighten assertion a little.
6173
c2982e87
PE
6174 Replace pEd with more-general pI, and fix some printf arg casts.
6175 * lisp.h (pI): New macro, generalizing old pEd macro to other
6176 conversion specifiers. For example, use "...%"pI"d..." rather
6177 than "...%"pEd"...".
6178 (pEd): Remove. All uses replaced with similar uses of pI.
6179 * src/m/amdx86-64.h, src/m/ia64.h, src/m/ibms390x.h: Likewise.
6180 * alloc.c (check_pure_size): Don't overflow by converting size to int.
6181 * bidi.c (bidi_dump_cached_states): Use pI to avoid cast.
6182 * data.c (Fnumber_to_string): Use pI instead of if-then-else-abort.
6183 * dbusbind.c (xd_append_arg): Use pI to avoid cast.
6184 (Fdbus_method_return_internal, Fdbus_method_error_internal): Likewise.
6185 * font.c (font_unparse_xlfd): Avoid potential buffer overrun on
6186 64-bit hosts.
6187 (font_unparse_xlfd, font_unparse_fcname): Use pI to avoid casts.
6188 * keyboard.c (record_char, modify_event_symbol): Use pI to avoid casts.
6189 * print.c (safe_debug_print, print_object): Likewise.
6190 (print_object): Don't overflow by converting EMACS_INT or EMACS_UINT
6191 to int.
6f04d126
PE
6192 Use pI instead of if-then-else-abort. Use %p to avoid casts,
6193 avoiding the 0 flag, which is not portable.
c2982e87
PE
6194 * process.c (Fmake_network_process): Use pI to avoid cast.
6195 * region-cache.c (pp_cache): Likewise.
6196 * xdisp.c (decode_mode_spec): Likewise.
6197 * xrdb.c (x_load_resources) [USE_MOTIF]: Use pI to avoid undefined
6198 behavior on 64-bit hosts with printf arg.
6f04d126 6199 * xselect.c (x_queue_event): Use %p to avoid casts, avoiding 0 flag.
c2982e87
PE
6200 (x_stop_queuing_selection_requests): Likewise.
6201 (x_get_window_property): Don't truncate byte count to an 'int'
6202 when tracing.
0b432f21 6203
5e073ec7
PE
6204 * frame.c (frame_name_fnn_p): Get rid of strtol, which isn't right
6205 here, since it parses constructs like leading '-' and spaces,
6206 which are not wanted; and it overflows with large numbers.
6207 Instead, simply match F[0-9]+, which is what is wanted anyway.
6208
36372bf9
PE
6209 * alloc.c: Remove unportable assumptions about struct layout.
6210 (SDATA_SELECTOR, SDATA_DATA_OFFSET): New macros.
6211 (SDATA_OF_STRING, SDATA_SIZE, allocate_string_data):
6212 (allocate_vectorlike, make_pure_vector): Use the new macros,
6213 plus offsetof, to remove unportable assumptions about struct layout.
6214 These assumptions hold on all porting targets that I know of, but
6215 they are not guaranteed, they're easy to remove, and removing them
6216 makes further changes easier.
6217
0b432f21
PE
6218 * alloc.c (BLOCK BYTES): Fix typo by changing "ablock" to "ablocks".
6219 This doesn't fix a bug but makes the code clearer.
bfd1c781
PE
6220 (string_overrun_cookie): Now const. Use initializers that
6221 don't formally overflow signed char, to avoid warnings.
000098c1
PE
6222 (allocate_string_data) [GC_CHECK_STRING_OVERRUN]: Fix typo that
6223 can cause Emacs to crash when string overrun checking is enabled.
c7bda33c
PE
6224 (allocate_buffer): Don't assume sizeof (struct buffer) is a
6225 multiple of sizeof (EMACS_INT); it need not be, if
6226 alignof(EMACS_INT) < sizeof (EMACS_INT).
d0f4e1f5 6227 (check_sblock, check_string_bytes, check_string_free_list): Protoize.
0b432f21 6228
895009e1
JB
62292011-04-26 Juanma Barranquero <lekktu@gmail.com>
6230
6231 * keyboard.c (QCrtl): Rename from Qrtl. All uses changed.
6232
6a7a1b0b
TZ
62332011-04-26 Teodor Zlatanov <tzz@lifelogs.com>
6234
6235 * gnutls.c (emacs_gnutls_handshake): Return an error if we're not
b5f869a7 6236 supposed to be handshaking. (Bug#8556)
6a7a1b0b
TZ
6237 Reported by Paul Eggert <eggert@cs.ucla.edu>.
6238
841a1577 62392011-04-26 Daniel Colascione <dan.colascione@gmail.com>
0438ce91
DC
6240
6241 * lisp.h (Qdebug): List symbol.
895009e1 6242 * eval.c (Qdebug): Restore global linkage.
0438ce91
DC
6243 * keyboard.c (debug-on-event): New variable.
6244 (handle_user_signal): Break into debugger when debug-on-event
6245 matches the current signal symbol.
6246
f2d3ba6f
DN
62472011-04-25 Dan Nicolaescu <dann@ics.uci.edu>
6248
6249 * alloc.c (check_sblock, check_string_bytes)
6250 (check_string_free_list): Convert to standard C.
6251
42ce4c63
TZ
62522011-04-25 Teodor Zlatanov <tzz@lifelogs.com>
6253
6254 * w32.c (emacs_gnutls_push): Fix typo.
6255
825cd63c
EZ
62562011-04-25 Eli Zaretskii <eliz@gnu.org>
6257
fb11d64d
EZ
6258 * gnutls.c (emacs_gnutls_handshake): Avoid compiler warnings about
6259 "cast to pointer from integer of different size".
6260
825cd63c
EZ
6261 Improve doprnt and its use in verror. (Bug#8545)
6262 * doprnt.c (doprnt): Document the set of format control sequences
6263 supported by the function. Use SAFE_ALLOCA instead of always
6264 using `alloca'.
6265
6266 * eval.c (verror): Don't limit the buffer size at size_max-1, that
6267 is one byte too soon. Don't use xrealloc; instead xfree and
6268 xmalloc anew.
6269
e061a11b
TZ
62702011-04-24 Teodor Zlatanov <tzz@lifelogs.com>
6271
6272 * gnutls.h: Add GNUTLS_STAGE_CALLBACKS enum to denote we're in the
6273 callbacks stage.
6274
6275 * gnutls.c: Renamed global_initialized to
6276 gnutls_global_initialized. Added internals for the
6277 :verify-hostname-error, :verify-error, and :verify-flags
6278 parameters of `gnutls-boot' and documented those parameters in the
6279 docstring. Start callback support.
9173deec
JB
6280 (emacs_gnutls_handshake): Add Woe32 support. Retry handshake
6281 unless a fatal error occurred. Call gnutls_alert_send_appropriate
6282 on error. Return error code.
e061a11b
TZ
6283 (emacs_gnutls_write): Call emacs_gnutls_handle_error.
6284 (emacs_gnutls_read): Likewise.
6285 (Fgnutls_boot): Return handshake error code.
6286 (emacs_gnutls_handle_error): New function.
6287 (wsaerror_to_errno): Likewise.
6288
6289 * w32.h (emacs_gnutls_pull): Add prototype.
6290 (emacs_gnutls_push): Likewise.
6291
6292 * w32.c (emacs_gnutls_pull): New function for GnuTLS on Woe32.
6293 (emacs_gnutls_push): Likewise.
6294
62952011-04-24 Claudio Bley <claudio.bley@gmail.com> (tiny change)
6296
6297 * process.c (wait_reading_process_output): Check if GnuTLS
6298 buffered some data internally if no FDs are set for TLS
6299 connections.
6300
6301 * makefile.w32-in (OBJ2): Add gnutls.$(O).
6302 (LIBS): Link to USER_LIBS.
6303 ($(BLD)/gnutls.$(0)): New target.
6304
fa6996bc
EZ
63052011-04-24 Eli Zaretskii <eliz@gnu.org>
6306
eb35682e
EZ
6307 * xdisp.c (handle_single_display_spec): Rename the
6308 display_replaced_before_p argument into display_replaced_p, to
6309 make it consistent with the commentary. Fix typos in the
6310 commentary.
6311
e2ad650c
EZ
6312 * textprop.c (syms_of_textprop): Remove dead code.
6313 (copy_text_properties): Delete obsolete commentary about an
6314 interface that was deleted long ago. Fix typos in the description
6315 of arguments.
6316
1b2de274
EZ
6317 * msdos.c (XMenuActivate, XMenuAddSelection): Adjust argument list
6318 to changes in oldXMenu/XMenu.h from 2011-04-16.
6319 <menu_help_message, prev_menu_help_message>: Constify.
6320 (IT_menu_make_room): menu->help_text is now `const char **';
6321 adjust.
6322
6323 * msdos.h (XMenuActivate, XMenuAddSelection): Adjust prototypes
6324 to changes in oldXMenu/XMenu.h from 2011-04-16.
6325 (struct XMenu): Declare `help_text' `const char **'.
6326
6327 * xfaces.c <Qunspecified>: Make extern again.
6328
6329 * syntax.c: Include sys/types.h before including regex.h, as
6330 required by Posix.
6331
762b15be
EZ
6332 * doc.c (get_doc_string): Improve the format passed to `error'.
6333
6334 * doprnt.c (doprnt): Improve commentary.
6335
6336 * term.c (init_tty) [MSDOS]: Fix 1st argument to maybe_fatal.
6337
6338 * Makefile.in (TAGS): Depend on $(M_FILE) and $(S_FILE), and scan
6339 them with etags.
6340
f1052e5d
EZ
6341 * makefile.w32-in (globals.h): Add a dummy recipe, to make any
6342 changes in globals.h immediately force recompilation.
762b15be
EZ
6343 (TAGS): Depend on $(CURDIR)/m/intel386.h and
6344 $(CURDIR)/s/ms-w32.h.
6345 (TAGS-gmake): Scan $(CURDIR)/m/intel386.h and $(CURDIR)/s/ms-w32.h.
f1052e5d 6346
fa6996bc
EZ
6347 * character.c (Fchar_direction): Function deleted.
6348 (syms_of_character): Don't defsubr it.
6349 <char-direction-table>: Deleted.
6350
e6c3da20
EZ
63512011-04-23 Eli Zaretskii <eliz@gnu.org>
6352
6353 Fix doprnt so it could be used again safely in `verror'. (Bug#8435)
6354 * doprnt.c: Include limits.h.
6355 (SIZE_MAX): New macro.
04f2d78b
CB
6356 (doprnt): Return a size_t value. 2nd arg is now size_t.
6357 Many local variables are now size_t instead of int or unsigned.
e6c3da20
EZ
6358 Improve overflow protection. Support `l' modifier for integer
6359 conversions. Support %l conversion. Don't assume an EMACS_INT
6360 argument for integer conversions and for %c.
6361
6362 * lisp.h (doprnt): Restore prototype.
6363
6364 * makefile.w32-in ($(BLD)/callint.$(O)): Depend on
6365 $(SRC)/character.h.
6366
6367 * Makefile.in (base_obj): Add back doprnt.o.
6368
6369 * deps.mk (doprnt.o): Add back prerequisites.
6370 (callint.o): Depend on character.h.
6371
6372 * eval.c (internal_lisp_condition_case): Include the handler
6373 representation in the error message.
6374 (verror): Call doprnt instead of vsnprintf. Fix an off-by-one bug
6375 when breaking from the loop.
6376
6377 * xdisp.c (vmessage): Call doprnt instead of vsnprintf.
6378
6379 * callint.c (Fcall_interactively): When displaying error message
6380 about invalid control letter, pass the character's codepoint, not
6381 a pointer to its multibyte form. Improve display of the character
6382 in octal and display also its hex code.
6383
6384 * character.c (char_string): Use %x to display the (unsigned)
6385 codepoint of an invalid character, to avoid displaying a bogus
6386 negative value.
6387
6388 * font.c (check_otf_features): Pass SDATA of SYMBOL_NAME to
6389 `error', not SYMBOL_NAME itself.
6390
6391 * coding.c (Fencode_sjis_char, Fencode_big5_char): Use %c for
6392 character arguments to `error'.
6393
6394 * charset.c (check_iso_charset_parameter): Fix incorrect argument
6395 to `error' in error message about FINAL_CHAR argument. Make sure
6396 FINAL_CHAR is a character, and use %c when it is passed as
6397 argument to `error'.
6398
4ffd0d6b 63992011-04-23 Eli Zaretskii <eliz@gnu.org>
97a93095
EZ
6400
6401 * s/ms-w32.h (localtime): Redirect to sys_localtime.
6402
6403 * w32.c: Include <time.h>.
6404 (sys_localtime): New function.
6405
4ffd0d6b 64062011-04-23 Chong Yidong <cyd@stupidchicken.com>
c17819f4
CY
6407
6408 * xdisp.c (init_xdisp): Initialize echo_area_window (Bug#6451).
6409
4ffd0d6b 6410 * buffer.c (syms_of_buffer): Doc fix (Bug#6902).
aac0c6e3 6411
4ffd0d6b 64122011-04-23 Samuel Thibault <sthibault@debian.org> (tiny change)
aac0c6e3 6413
4ffd0d6b
GM
6414 * sysdep.c (wait_for_termination): On GNU Hurd, kill returns -1 on
6415 zombies (Bug#8467).
aac0c6e3 6416
04c56954
EZ
64172011-04-19 Eli Zaretskii <eliz@gnu.org>
6418
6419 * syntax.h (SETUP_SYNTAX_TABLE_FOR_OBJECT): Fix setting of
6420 gl_state.e_property when gl_state.object is Qt.
6421
6422 * insdel.c (make_gap_larger): Remove limitation of buffer size
6423 to <= INT_MAX.
6424
16a43933
CY
64252011-04-18 Chong Yidong <cyd@stupidchicken.com>
6426
6427 * xdisp.c (lookup_glyphless_char_display)
6428 (produce_glyphless_glyph): Handle cons cell entry in
6429 glyphless-char-display.
6430 (Vglyphless_char_display): Document it.
6431
6432 * term.c (produce_glyphless_glyph): Handle cons cell entry in
6433 glyphless-char-display.
6434
4581706e
CY
64352011-04-17 Chong Yidong <cyd@stupidchicken.com>
6436
6437 * xdisp.c (get_next_display_element): Remove unnecessary ifdefs.
6438
6439 * termhooks.h (FRAME_WINDOW_P): Remove duplicated definitions.
6440
6441 * dispextern.h (FACE_SUITABLE_FOR_ASCII_CHAR_P): Add missing
6442 definition for no-X builds.
6443
4887c6e2 64442011-04-16 Paul Eggert <eggert@cs.ucla.edu>
764430a3 6445
fd35b6f9
PE
6446 Static checks with GCC 4.6.0 and non-default toolkits.
6447
5c1ccb01
PE
6448 * s/sol2-6.h, s/unixware.h (PTY_TTY_NAME_SPRINTF): Protoize decl.
6449
006c5daa
PE
6450 * process.c (keyboard_bit_set): Define only if SIGIO.
6451 (send_process_trap): Mark it with NO_RETURN if it doesn't return.
6452 (send_process): Repair possible setjmp clobbering.
6453
efc736d3
PE
6454 * s/usg5-4-common.h (SETUP_SLAVE_PTY): Don't pass extra arg to 'fatal'.
6455
4e2fe2e6
PE
6456 * eval.c: Include <stdio.h>, for vsnprintf on non-GNU/Linux hosts.
6457
f97334a2
PE
6458 * data.c (arith_error): Mark with NO_RETURN if it doesn't return.
6459
4e75f29d
PE
6460 * alloc.c (bytes_used_when_full, SPARE_MEMORY, BYTES_USED):
6461 Define only if needed.
6462
90efadd1
PE
6463 * sysdep.c (_FILE_OFFSET_BITS): Make this hack even uglier
6464 by pacifying GCC about it. Maybe it's time to retire it?
875975e9 6465 * xfaces.c (USG, __TIMEVAL__): Likewise.
90efadd1 6466
3c647824
PE
6467 * dispextern.h (struct redisplay_interface): Rename param
6468 to avoid shadowing.
e264f262 6469 * termhooks.h (struct terminal): Likewise.
761383f4 6470 * xterm.c (xembed_send_message): Likewise.
3c647824 6471
b58c5c4a
PE
6472 * insdel.c (make_gap_smaller): Define only if
6473 USE_MMAP_FOR_BUFFERS || REL_ALLOC || DOUG_LEA_MALLOC.
6474
cad59032
PE
6475 * keyboard.c (read_char): Make a var volatile so longjmp won't clobber
6476 it.
6477
c339dc2e
PE
6478 * emacs.c (MAX_HEAP_BSS_DIFF, my_edata): Move to where they're used,
6479 so that we aren't warned about unused symbols.
6480
91a3e27b
PE
6481 * xfns.c (Fx_file_dialog): Rename local to avoid shadowing.
6482
399c71d3 6483 * xdisp.c (x_produce_glyphs): Mark var as initialized (Bug#8512).
7a3fb125 6484
8ffc96f5
PE
6485 * xfns.c (x_real_positions): Mark locals as initialized.
6486
eef9bc79
PE
6487 * xmenu.c (xmenu_show): Don't use uninitialized vars.
6488
098db9dd
PE
6489 * xterm.c: Fix problems found by static analysis with other toolkits.
6490 (toolkit_scroll_bar_interaction): Define and use only if USE_X_TOOLKIT.
dda3aedd
PE
6491 (x_dispatch_event): Declare static if USE_GTK, and
6492 define if USE_GTK || USE_X_TOOLKIT.
098db9dd 6493 (SET_SAVED_BUTTON_EVENT): Define only if USE_X_TOOLKIT || USE_GTK.
dda3aedd 6494 * xterm.h (x_dispatch_event): Extern only if USE_X_TOOLKIT.
841a1577
JB
6495 * xterm.c, xterm.h (x_mouse_leave): Bring this function back, but only
6496 if defined HAVE_MENUS && !defined USE_X_TOOLKIT && !defined USE_GTK.
098db9dd 6497
eb18f6cc
PE
6498 * xmenu.c (menu_help_callback): Pointer type fixes.
6499 Use const pointers when pointing at readonly data. Avoid pointer
6500 signedness clashes.
6501 (FALSE): Remove unused macro.
6502 (update_frame_menubar): Remove unused decl.
6503
1fe72bf8
PE
6504 * xfns.c (Fx_hide_tip): Move locals to avoid shadowing.
6505
60d9e1db
PE
6506 * menu.c (push_submenu_start, push_submenu_end): Do not define unless
6507 USE_X_TOOLKIT || USE_GTK || HAVE_NS || defined HAVE_NTGUI.
6508 (single_menu_item): Rename local to avoid shadowing.
6509
39261c26
PE
6510 * keyboard.c (make_lispy_event): Remove unused local var.
6511
018c5e19
PE
6512 * frame.c, frame.h (x_get_resource_string): Bring this back, but
6513 only if HAVE_X_WINDOWS && !USE_X_TOOLKIT.
6514
63d2b86e
PE
6515 * bitmaps: Change bitmaps from unsigned char back to the X11
6516 compatible char. Avoid the old compiler warnings about
6517 out-of-range initializers by using, for example, '\xab' rather
6518 than 0xab.
6519
aefd87e1
PE
6520 * xgselect.c (xgselect_initialize): Check vs interface
6521 even if ! (defined (USE_GTK) || defined (HAVE_GCONF)).
6522
bf501fb9
PE
6523 * xmenu.c (xmenu_show): Rename parm to avoid shadowing.
6524
e9829fdf
PE
6525 * xterm.c (x_create_toolkit_scroll_bar): Use const * for pointers
6526 to read-only memory.
6527
1086c095
PE
6528 * fns.c (vector): Remove; this old hack is no longer needed.
6529
2baccd04 6530 * xsmfns.c (create_client_leader_window): Rename shadowing arg.
401f10cb 6531 Remove unused var.
dde42981 6532 (gdk_x11_set_sm_client_id) [!USE_GTK]: Don't define.
2baccd04 6533
72391843 6534 * xrdb.c (x_load_resources): Omit unused local.
3565b346 6535
436c16df 6536 * xfns.c (free_frame_menubar, atof): Remove duplicate decls.
8a94ea33 6537 (x_window): Rename locals to avoid shadowing.
dc5ddd85 6538 (USG): Use the kludged USG macro, to pacify gcc.
436c16df 6539
92bb796d 6540 * xterm.c (x_alloc_nearest_color_for_widget): Remove; unused.
bbbef9e1 6541 (x_term_init): Remove local to avoid shadowing.
92bb796d 6542
764430a3 6543 * xfns.c, xterm.c (_XEditResCheckMessages): Protoize decl.
4887c6e2
PE
6544
6545 * xdisp.c, dispextern.h (set_vertical_scroll_bar): Now extern if
6546 USE_TOOLKIT_SCROLL_BARS && !USE_GTK, as xterm.c needs it then.
6547
d1dfb56c
EZ
65482011-04-16 Eli Zaretskii <eliz@gnu.org>
6549
c4354cb4
EZ
6550 * gnutls.c (Fgnutls_boot): Don't pass Lisp_Object to `error'.
6551
d1dfb56c
EZ
6552 Fix regex.c, syntax.c and friends for buffers > 2GB.
6553 * syntax.h (struct gl_state_s): Declare character position members
6554 EMACS_INT.
6555
6556 * syntax.c (update_syntax_table): Declare 2nd argument EMACS_INT.
6557
04f2d78b
CB
6558 * textprop.c (verify_interval_modification, interval_of):
6559 Declare arguments EMACS_INT.
d1dfb56c
EZ
6560
6561 * intervals.c (adjust_intervals_for_insertion): Declare arguments
6562 EMACS_INT.
6563
6564 * intervals.h (CHECK_TOTAL_LENGTH): Cast to EMACS_INT, not `int'.
6565
6566 * indent.c (Fvertical_motion): Local variable it_start is now
6567 EMACS_INT.
6568
6569 * regex.c (re_match, re_match_2, re_match_2_internal)
6570 (bcmp_translate, regcomp, regexec, print_double_string)
6571 (group_in_compile_stack, re_search, re_search_2, regex_compile)
6572 (re_compile_pattern, re_exec): Declare arguments and local
6573 variables `size_t' and `ssize_t' and return values `regoff_t', as
6574 appropriate.
6575 (POP_FAILURE_REG_OR_COUNT) <pfreg>: Declare `long'.
6576 (CHECK_INFINITE_LOOP) <failure>: Declare `ssize_t'.
6577 <compile_stack_type>: `size' and `avail' are now `size_t'.
6578
6579 * regex.h <regoff_t>: Use ssize_t, not int.
6580 (re_search, re_search_2, re_match, re_match_2): Arguments that
6581 specify buffer/string position and length are now ssize_t and
6582 size_t. Return type is regoff_t.
6583
613052cd
BK
65842011-04-16 Ben Key <bkey76@gmail.com>
6585
6586 * nsfont.m: Fixed bugs in ns_get_family and
6587 ns_descriptor_to_entity that were caused by using free to
6588 deallocate memory blocks that were allocated by xmalloc (via
6589 xstrdup). This caused Emacs to crash when compiled with
6590 XMALLOC_OVERRUN_CHECK defined (when Emacs was configured with
6591 --enable-checking=xmallocoverrun). xfree is now used to
6592 deallocate these memory blocks.
6593
4170f62f 65942011-04-15 Paul Eggert <eggert@cs.ucla.edu>
3e047f51 6595
71b41406
PE
6596 * sysdep.c (emacs_read): Remove unnecessary check vs MAX_RW_COUNT.
6597
9587a89d
PE
6598 emacs_write: Accept and return EMACS_INT for sizes.
6599 See http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00514.html
6600 et seq.
6601 * gnutls.c, gnutls.h (emacs_gnutls_read, emacs_gnutls_write):
6602 Accept and return EMACS_INT.
6603 (emacs_gnutls_write): Return the number of bytes written on
6604 partial writes.
6605 * sysdep.c, lisp.h (emacs_read, emacs_write): Likewise.
273a5f82
PE
6606 (emacs_read, emacs_write): Remove check for negative size, as the
6607 Emacs source code has been audited now.
9587a89d
PE
6608 * sysdep.c (MAX_RW_COUNT): New macro, to work around kernel bugs.
6609 (emacs_read, emacs_write): Use it.
273a5f82
PE
6610 * process.c (send_process): Adjust to the new signatures of
6611 emacs_write and emacs_gnutls_write. Do not attempt to store
6612 a byte offset into an 'int'; it might overflow.
9587a89d 6613 See http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00483.html
273a5f82 6614
3e047f51
PE
6615 * sound.c: Don't assume sizes fit in 'int'.
6616 (struct sound_device.period_size, alsa_period_size):
9c3c56a7 6617 Return EMACS_INT, not int.
3e047f51 6618 (struct sound_device.write, vox_write, alsa_write):
9c3c56a7
PE
6619 Accept EMACS_INT, not int.
6620 (wav_play, au_play): Use EMACS_INT to store sizes and to
3e047f51
PE
6621 record read return values.
6622
cc39a9db
BK
66232011-04-15 Ben Key <bkey76@gmail.com>
6624
c9d0ec6d
JB
6625 * keyboard.c (Qundefined): Don't declare static since it is used
6626 in nsfns.m.
6627 * xfaces.c (Qbold, Qexpanded, Qitalic, Qcondensed): Don't declare
6628 static since they are used in nsfont.m.
cc39a9db 6629
6c60eb9f
SM
66302011-04-15 Stefan Monnier <monnier@iro.umontreal.ca>
6631
6632 * process.c (Qprocessp): Don't declare static.
6633 * lisp.h (Qprocessp): Declare again.
6634
7990b61a
JB
66352011-04-15 Juanma Barranquero <lekktu@gmail.com>
6636
6637 * font.c (Qopentype): Don't make static (used from w32uniscribe.c).
6638
5d4cb038
PE
66392011-04-14 Paul Eggert <eggert@cs.ucla.edu>
6640
8bd7b830 6641 Improve C-level modularity by making more things 'static'.
cd64ea1d 6642
e3b27b31
PE
6643 Don't publish debugger-only interfaces to other modules.
6644 * lisp.h (safe_debug_print, debug_output_compilation_hack):
6645 (verify_bytepos, count_markers): Move decls to the only modules
6646 that need them.
6647 * region-cache.h (pp_cache): Likewise.
6648 * window.h (check_all_windows): Likewise.
6649 * marker.c, print.c, region-cache.c, window.c: Decls moved here.
6650
5d4cb038
PE
6651 * sysdep.c (croak): Now static, if
6652 defined TIOCNOTTY || defined USG5 || defined CYGWIN.
6653 * syssignal.h (croak): Declare only if not static.
69003fd8
PE
6654
6655 * alloc.c (refill_memory_reserve): Now static if
6656 !defined REL_ALLOC || defined SYSTEM_MALLOC.
6657 * lisp.h (refill_memory_reserve): Declare only if not static.
93ea6e8f 6658
e87b6180
PE
6659 * xsettings.c, xsettings.h (xsettings_get_system_normal_font):
6660 Define only if USE_LUCID.
6661
ac64929e
PE
6662 * xrdb.c (x_customization_string, x_rm_string): Now static.
6663
6f37259d
PE
6664 * xmenu.c (x_menu_wait_for_event): Export only if USE_MOTIF.
6665 * xterm.h (x_menu_wait_for_event): Declare only if USE_MOTIF.
6666
1683e3ab
PE
6667 * xdisp.c (draw_row_with_mouse_face): Now static.
6668 * dispextern.h (draw_row_with_mouse_fave): Remove decl.
6669
de9c2632
PE
6670 * window.h (check_all_windows): Mark externally visible.
6671
2b96acb7
PE
6672 * window.c (window_deletion_count): Now static.
6673
6674 * undo.c: Make symbols static if they're not exported.
6675 (last_undo_buffer, last_boundary_position, pending_boundary):
6676 Now static.
6677
50436f33
PE
6678 * textprop.c (interval_insert_behind_hooks): Now static.
6679 (interval_insert_in_front_hooks): Likewise.
6680
64520e5c
PE
6681 * term.c: Make symbols static if they're not exported.
6682 (tty_turn_off_highlight, get_tty_terminal, max_frame_cols):
6683 (max_frame_lines, tty_set_terminal_modes):
6684 (tty_reset_terminal_modes, tty_turn_off_highlight):
6685 (get_tty_terminal): Now static.
6686 (term_mouse_moveto): Do not define if HAVE_WINDOW_SYSTEM.
6687 * termhooks.h (term_mouse_moveto): Do not declare if
8bd7b830 6688 HAVE_WINDOW_SYSTEM.
64520e5c
PE
6689 * dispextern.h (tty_set_terminal_modes, tty_reset_terminal_modes):
6690 (tty_turn_off_highlight, get_tty_terminal): Remove decls.
6691
1fa53021
PE
6692 * sysdep.c: Make symbols static if they're not exported.
6693 (emacs_get_tty, emacs_set_tty, old_fcntl_flags, old_fcntl_owner):
6694 Now static.
6695 (sigprocmask_set, full_mask): Remove; unused.
6696 (wait_debugging): Mark as visible.
6697 * syssignal.h (SIGFULLMASK, full_mask): Remove decls.
6698 * systty.h (emacs_get_tty, emacs_set_tty): Remove decls.
6699
d4b43b22
PE
6700 * syntax.c (syntax_temp): Define only if !__GNUC__.
6701
b7c513d0
PE
6702 * sound.c (current_sound_device, current_sound): Now static.
6703
989b29ad
PE
6704 * search.c (searchbufs, searchbuf_head): Now static.
6705
13a55a78
PE
6706 * scroll.c (scroll_cost): Remove; unused.
6707 * dispextern.h (scroll_cost): Remove decl.
6708
de68a1fc
PE
6709 * region-cache.h (pp_cache): Mark as externally visible.
6710
40ccffa6
PE
6711 * process.c: Make symbols static if they're not exported.
6712 (process_tick, update_tick, create_process, chan_process):
6713 (Vprocess_alist, proc_buffered_char, datagram_access):
6714 (fd_callback_data, send_process_frame, process_sent_to): Now static.
6715 (deactivate_process): Mark defn as static, as well as decl.
6716 * lisp.h (create_process): Remove decl.
6717 * process.h (chan_process, Vprocess_alist): Remove decls.
6718
ad64fc97
PE
6719 * print.c: Make symbols static if they're not exported.
6720 (print_depth, new_backquote_output, being_printed, print_buffer):
6721 (print_buffer_size, print_buffer_pos, print_buffer_pos_byte):
6722 (print_interval, print_number_index, initial_stderr_stream):
6723 Now static.
6724 * lisp.h (Fprinc): Remove decl.
6725 (debug_output_compilation_hack): Mark as externally visible.
6726
adddb265
PE
6727 * sysdep.c (croak): Move decl from here to syssignal.h.
6728 * syssignal.h (croak): Put it here, so the API can be checked when
6729 'croak' is called from dissociate_if_controlling_tty.
6730
1717ede2
PE
6731 * minibuf.c: Make symbols static if they're not exported.
6732 (minibuf_save_list, choose_minibuf_frame): Now static.
6733 * lisp.h (choose_minibuf_frame): Remove decl.
6734
fa5fb2bc
PE
6735 * lisp.h (verify_bytepos, count_markers): Mark as externally visible.
6736
1e3890d1
PE
6737 * lread.c: Make symbols static if they're not exported.
6738 (read_objects, initial_obarray, oblookup_last_bucket_number):
6739 Now static.
6740 (make_symbol): Remove; unused.
6741 * lisp.h (initial_obarray, make_symbol): Remove decls.
6742
8a1414fa
PE
6743 * keyboard.c: Make symbols static if they're not exported.
6744 (single_kboard, recent_keys_index, total_keys, recent_keys):
6745 (this_command_key_count_reset, raw_keybuf, raw_keybuf_count):
6746 (this_single_command_key_start, echoing, last_auto_save):
6747 (read_key_sequence_cmd, dribble, recursive_edit_unwind):
6748 (command_loop, echo_now, keyboard_init_hook, help_char_p):
6749 (quit_throw_to_read_char, command_loop_2, top_level_1, poll_timer):
6750 (Vlispy_mouse_stem, double_click_count):
6751 Now static.
6752 (force_auto_save_soon): Define only if SIGDANGER.
6753 (ignore_mouse_drag_p): Now static if
6754 !defined HAVE_WINDOW_SYSTEM || defined USE_GTK || defined HAVE_NS.
6755 (print_help): Remove; unused.
6756 (stop_character, last_timer_event): Mark as externally visible.
6757 * keyboard.h (ignore_mouse_drag_p): Declare only if
6758 defined HAVE_WINDOW_SYSTEM && !defined USE_GTK && !defined HAVE_NS.
6759 (echo_now, help_char_p, quit_throw_to_read_char): Remove decls.
6760 * lisp.h (echoing): Remove decl.
6761 (force_auto_save_soon): Declare only if SIGDANGER.
6762 * xdisp.c (redisplay_window): Simplify code, to make it more
6763 obvious that ignore_mouse_drag_p is not accessed if !defined
6764 USE_GTK && !defined HAVE_NS.
6765
93ea6e8f
PE
6766 * intervals.c: Make symbols static if they're not exported.
6767 (merge_properties_sticky, merge_interval_right, delete_interval):
6768 Now static.
6769 * intervals.h (merge_interval_right, delete_interval): Remove decls.
6770
77382fcc
PE
6771 * insdel.c: Make symbols static if they're not exported.
6772 However, leave prepare_to_modify_buffer alone. It's never
6773 called from outside this function, but that appears to be a bug.
6774 (combine_after_change_list, combine_after_change_buffer):
4889fc82 6775 (adjust_after_replace, signal_before_change): Now static.
77382fcc
PE
6776 (adjust_after_replace_noundo): Remove; unused.
6777 * lisp.h (adjust_after_replace, adjust_after_replace_noundo):
4889fc82 6778 (signal_before_change): Remove decls.
77382fcc 6779
9306c32e
PE
6780 * indent.c (val_compute_motion, val_vmotion): Now static.
6781
cd44d2eb
PE
6782 * image.c: Make symbols static if they're not exported.
6783 * dispextern.h (x_create_bitmap_from_xpm_data): Do not declare
6784 if USE_GTK.
6785 * image.c (x_create_bitmap_from_xpm_data): Do not define if USE_GTK.
6786 (xpm_color_cache, ct_table, ct_colors_allocated): Now static.
6787
ad9a7a06
PE
6788 * fringe.c (standard_bitmaps): Now static.
6789 (max_used_fringe_bitmap): Now static, unless HAVE_NS.
6790
81626931
PE
6791 * frame.c: Make symbols static if they're not exported.
6792 (x_report_frame_params, make_terminal_frame): Now static.
6793 (get_frame_param): Now static, unless HAVE_NS.
6794 (x_fullscreen_adjust): Define if WINDOWSNT, not if HAVE_WINDOW_SYSTEM.
6795 (x_get_resource_string): Remove; not used.
6796 * frame.h (make_terminal_frame, x_report_frame_params):
6797 (x_get_resource_string); Remove decls.
6798 (x_fullscreen_adjust): Declare only if WINDOWSNT.
6799 * lisp.h (get_frame_param): Declare only if HAVE_NS.
6800
239f9db9
PE
6801 * font.c, fontset.c: Make symbols static if they're not exported.
6802 * dispextern.h (FACE_SUITABLE_FOR_ASCII_CHAR_P): New macro.
6803 (FACE_SUITABLE_FOR_CHAR_P): Use it.
6804 * font.c (font_close_object): Now static.
6805 * font.h (font_close_object): Remove.
6806 * fontset.c (FONTSET_OBJLIST): Remove.
6807 (free_realized_fontset) #if-0 the body, which does nothing.
6808 (face_suitable_for_char_p): #if-0, as it's never called.
6809 * fontset.h (face_suitable_for_char_p): Remove decl.
04f2d78b
CB
6810 * xfaces.c (face_at_string_position):
6811 Use FACE_SUITABLE_FOR_ASCII_CHAR_P, not FACE_SUITABLE_FOR_CHAR_P,
239f9db9
PE
6812 since 0 is always ASCII.
6813
dfcf3579
PE
6814 * fns.c (weak_hash_tables): Now static.
6815
5045092b
PE
6816 * fileio.c: Make symbols static if they're not exported.
6817 (auto_saving, auto_save_mode_bits, auto_save_error_occurred):
6818 (Vwrite_region_annotation_buffers): Now static.
6819
57a96f5c
PE
6820 * eval.c: Make symbols static if they're not exported.
6821 (backtrace_list, lisp_eval_depth, when_entered_debugger): Now static.
6822 * lisp.h (backtrace_list): Remove decl.
6823
35f08c38
PE
6824 * emacs.c: Make symbols static if they're not exported.
6825 (malloc_state_ptr, malloc_using_checking, syms_of_emacs):
6826 (fatal_error_code, fatal_error_signal_hook, standard_args):
6827 Now static.
6828 (fatal_error_signal): Now static, unless FLOAT_CATCH_SIGKILL.
6829 (DEFINE_DUMMY_FUNCTION): Mark function as externally visible.
6830 (__CTOR_LIST__, __DTOR_LIST__): Now externally visible.
6831 * lisp.h (fatal_error_signal_hook): Remove decl.
6832 (fatal_error_signal): Declare only if FLOAT_CATCH_SIGKILL.
6833
f44bd759
PE
6834 * editfns.c: Move a (normally-unused) function to its only use.
6835 * editfns.c, lisp.h (get_operating_system_release): Remove.
6836 * process.c (init_process) [DARWIN_OS]: Do it inline, as it is not
6837 worth the hassle of breaking this out.
6838
b532497d
PE
6839 * xterm.c: Make symbols static if they're not exported.
6840 (x_raise_frame, x_lower_frame, x_wm_set_window_state):
6841 (x_wm_set_icon_pixmap, x_initialize, XTread_socket_fake_io_error):
6842 (x_destroy_window, x_delete_display):
6843 Now static.
6844 (x_dispatch_event): Now static if ! (USE_MOTIF || USE_X_TOOLKIT).
6845 (x_mouse_leave): Remove; unused.
6846 * xterm.h (x_display_info_for_name, x_raise_frame, x_lower_frame):
6847 (x_destroy_window, x_wm_set_window_state, x_wm_set_icon_pixmap):
6848 (x_delete_display, x_initialize, x_set_border_pixel, x_screen_planes):
6849 Remove decls.
6850 (x_mouse_leave): Declare only if WINDOWSNT.
6851 (x_dispatch_event): Declare only if USE_MOTIF or USE_X_TOOLKIT.
6852 (xic_create_fontsetname): Declare only if HAVE_X_WINDOWS &&
6853 USE_X_TOOLKIT.
6854
1675728f
PE
6855 * ftxfont.c: Make symbols static if they're not exported.
6856 (ftxfont_driver): Export only if !defined HAVE_XFT && def8ined
6857 HAVE_FREETYPE.
6858 * font.h (ftxfont_driver): Likewise.
6859
e4cebfca
PE
6860 * xfns.c: Make symbols static if they're not exported.
6861 (x_last_font_name, x_display_info_for_name):
6862 (x_set_foreground_color, x_set_background_color, x_set_mouse_color):
6863 (x_set_cursor_color, x_set_border_pixel, x_set_border_color):
6864 (x_set_cursor_type, x_set_icon_type, x_set_icon_name):
6865 (x_set_scroll_bar_foreground, x_set_scroll_bar_background):
6866 (x_explicitly_set_name, x_set_title, xic_defaut_fontset, tip_timer):
6867 (last_show_tip_args): Now static.
6868 (xic_defaut_fontset, xic_create_fontsetname): Define only if
6869 defined HAVE_X_WINDOWS && defined USE_X_TOOLKIT
6870 (x_screen_planes): Remove; unused.
6871 * dispextern.h (x_screen_planes): Remove decl.
6872
5bf46f05
PE
6873 * dispnew.c: Make symbols static if they're not exported.
6874 * dispextern.h (redraw_garbaged_frames, scrolling):
6875 (increment_row_positions): Remove.
6876 * dispnew.c (new_glyph_matrix, increment_row_positions, scrolling):
6877 (delayed_size_change, glyph_matrix_count, glyph_pool_count):
6878 Now static.
6879 (redraw_garbaged_frames): Remove; unused.
6880
435f4c28
PE
6881 * xfaces.c: Make symbols static if they're not exported.
6882 * dispextern.h (ascii_face_of_lisp_face, free_realized_face):
6883 Remove decls.
6884 * xterm.h (defined_color): Remove decls.
6885 (x_free_dpy_colors): Declare only if USE_X_TOOLKIT.
6886 * xfaces.c (tty_suppress_bold_inverse_default_colors_p):
6887 (menu_face_changed_default, defined_color, free_realized_face):
6888 (x_free_dpy_colors): Define only if USE_X_TOOLKIT.
6889 (ascii_face_of_lisp_face): Remove; unused.
6890
8524aef3
PE
6891 * xdisp.c: Make symbols static if they're not exported.
6892 * dispextern.h (scratch_glyph_row, window_box_edges):
6893 (glyph_to_pixel_coords, set_cursor_from_row):
6894 (get_next_display_element, set_iterator_to_next):
6895 (highlight_trailing_whitespace, frame_to_window_pixel_xy):
6896 (show_mouse_face): Remove decls
6897 * frame.h (message_buf_print): Likewise.
6898 * lisp.h (pop_message, set_message, check_point_in_composition):
6899 Likewise.
6900 * xterm.h (set_vertical_scroll_bar): Likewise.
6901 * xdisp.c (list_of_error, Vmessage_stack, line_number_displayed):
6902 (message_buf_print, scratch_glyph_row, displayed_buffer):
6903 (set_iterator_to_next, pop_message, set_message, set_cursor_from_row):
6904 (get_next_display_element, show_mouse_face, window_box_edges):
6905 (frame_to_window_pixel_xy, check_point_in_composition):
6906 (set_vertical_scroll_bar, highlight_trailing_whitespace): Now static.
6907 (glyph_to_pixel_coords): Remove; unused.
6908
16390cd2
PE
6909 * dired.c (file_name_completion): Now static.
6910
6911 * dbusbind.c (xd_in_read_queued_messages): Now static.
6912
a25f4dfa
PE
6913 * lisp.h (circular_list_error, FOREACH): Remove; unused.
6914 * data.c (circular_list_error): Remove.
6915
14a9c8df
PE
6916 * commands.h (last_point_position, last_point_position_buffer):
6917 (last_point_position_window): Remove decls.
6918 * keyboard.c: Make these variables static.
6919
04f2d78b
CB
6920 * coding.h (coding, code_convert_region, encode_coding_gap):
6921 Remove decls.
74ab6df5
PE
6922 * coding.c (Vsjis_coding_system, Vbig5_coding_system):
6923 (iso_code_class, detect_coding, code_convert_region): Now static.
6924 (encode_coding_gap): Remove; unused.
6925
38dfbee1
PE
6926 * chartab.c (chartab_chars, chartab_bits): Now static.
6927
a2cb4e63
PE
6928 * charset.h (charset_iso_8859_1): Remove decl.
6929 * charset.c (charset_iso_8859_1, charset_emacs, map_charset_for_dump):
6930 Now static.
6931
127198fd
PE
6932 * ccl.h (check_ccl_update, Vccl_program_table): Remove decls.
6933 * ccl.c (Vccl_program_table): Now static.
6934 (check_ccl_update): Remove; unused.
6935
d85b608f
PE
6936 * category.c (SET_CATEGORY_SET, set_category_set): Move here.
6937 * category.h: ... from here.
6938 * category.c (check_category_table, set_category_set): Now static.
6939
31cd66f3
PE
6940 * casetab.c (Vascii_upcase_table, Vascii_eqv_table): Now static.
6941 * lisp.h: Remove these decls.
6942
c358e587
PE
6943 * buffer.c (buffer_count): Remove unused var.
6944
e78aecca
PE
6945 * bidi.c (bidi_dump_cached_states): Mark as externally visible,
6946 so that it's not optimized away.
6947 (bidi_ignore_explicit_marks_for_paragraph_level): Likewise.
6948 * dispextern.h (bidi_dump_cached_states): Remove, since it's
6949 exported only to the debugger.
6950
e192d7d3 6951 * atimer.c (alarm_signal_handler, run_all_atimers): Now static.
04f2d78b 6952 * atimer.h (run_all_atimers): Remove; not exported.
e192d7d3 6953
92470028
PE
6954 font.c: Make copy_font_spec and merge_font_spec ordinary C functions.
6955 * font.c (copy_font_spec): Rename from Fcopy_font_spec, since it
6956 was inaccessible from Lisp.
6957 (merge_font_spec): Likewise, renaming from Fmerge_font_spec.
6958 * font.c, font.h, fontset.c, xfaces.c, xfont.c: Change all uses.
6959
244ed907
PE
6960 alloc.c: Import and export fewer symbols, and remove unused items.
6961 * lisp.h (suppress_checking, die): Declare only if ENABLE_CHECKING
6962 is defined.
6963 (suppress_checking): Add EXTERNALLY_VISIBLE attribute, so that
6964 it's not optimized away by whole-program optimization.
6965 (message_enable_multibyte, free_misc): Remove.
6966 (catchlist, handlerlist, mark_backtrace):
6967 Declare only if BYTE_MARK_STACK.
6968 (mark_byte_stack): Likewise, fixing a ifdef-vs-if typo.
6969 * alloc.c (pure): Export only if VIRT_ADDR_VARIES is defined.
6970 (message_enable_multibyte): Remove decl.
6971 (free_misc, interval_free_list, float_block, float_block_index):
6972 (n_float_blocks, float_free_list, cons_block, cons_block_index):
6973 (cons_free_list, last_marked_index):
6974 Now static.
6975 (suppress_checking, die): Define only if ENABLE_CHECKING is defined.
6976 * eval.c (catchlist, handlerlist): Export only if BYTE_MARK_STACK.
6977 (mark_backtrace): Define only if BYTE_MARK_STACK.
6978 * xdisp.c (message_enable_multibyte): Now static.
6979
61c2b50e 6980 Declare Lisp_Object Q* variables to be 'static' if not exported.
955cbe7b
PE
6981 This makes it easier for human readers (and static analyzers)
6982 to see whether these variables are used from other modules.
6983 * alloc.c, buffer.c, bytecode.c, callint.c, casetab.c, category.c:
6984 * ccl.c, character.c, charset.c, cmds.c, coding.c, composite.c:
6985 * data.c, dbusbind.c, dired.c, editfns.c, eval.c, fileio.c, fns.c:
6986 * font.c, frame.c, fringe.c, ftfont.c, image.c, keyboard.c, keymap.c:
6987 * lread.c, macros.c, minibuf.c, print.c, process.c, search.c:
6988 * sound.c, syntax.c, textprop.c, window.c, xdisp.c, xfaces.c, xfns.c:
6989 * xmenu.c, xselect.c:
6990 Declare Q* vars static if they are not used in other modules.
6991 * ccl.h, character.h, charset.h, coding.h, composite.h, font.h:
6992 * frame.h, intervals.h, keyboard.h, lisp.h, process.h, syntax.h:
6993 Remove decls of unexported vars.
6994 * keyboard.h (EVENT_HEAD_UNMODIFIED): Remove now-unused macro.
6995
95c82688
PE
6996 * lisp.h (DEFINE_FUNC): Make sname 'static'.
6997
16a97296
PE
6998 Make Emacs functions such as Fatom 'static' by default.
6999 This makes it easier for human readers (and static analyzers)
7000 to see whether these functions can be called from other modules.
7001 DEFUN now defines a static function. To make the function external
7002 so that it can be used in other C modules, use the new macro DEFUE.
8bd7b830
PE
7003 * lisp.h (Funibyte_char_to_multibyte, Fsyntax_table_p):
7004 (Finit_image_library):
16a97296
PE
7005 (Feval_region, Fbacktrace, Ffetch_bytecode, Fswitch_to_buffer):
7006 (Ffile_executable_p, Fmake_symbolic_link, Fcommand_execute):
7007 (Fget_process, Fdocumentation_property, Fbyte_code, Ffile_attributes):
7008 Remove decls, since these functions are now static.
7009 (Funintern, Fget_internal_run_time): New decls, since these functions
7010 were already external.
95c82688 7011
16a97296
PE
7012 * alloc.c, buffer.c, callint.c, callproc.c, casefiddle.c, casetab.c:
7013 * ccl.c, character.c, chartab.c, cmds.c, coding.c, data.c, dispnew.c:
7014 * doc.c, editfns.c, emacs.c, eval.c, fileio.c, filelock.c, floatfns.c:
7015 * fns.c, font.c, fontset.c, frame.c, image.c, indent.c:
7016 * keyboard.c, keymap.c, lread.c:
7017 * macros.c, marker.c, menu.c, minibuf.c, print.c, process.c, search.c:
7018 * syntax.c, term.c, terminal.c, textprop.c, undo.c:
7019 * window.c, xdisp.c, xfaces.c, xfns.c, xmenu.c, xsettings.c:
7020 Mark functions with DEFUE instead of DEFUN,
7021 if they are used in other modules.
7022 * buffer.c (Fset_buffer_major_mode, Fdelete_overlay): New forward
7023 decls for now-static functions.
7024 * buffer.h (Fdelete_overlay): Remove decl.
7025 * callproc.c (Fgetenv_internal): Mark as internal.
7026 * composite.c (Fremove_list_of_text_properties): Remove decl.
7027 (Fcomposition_get_gstring): New forward static decl.
7028 * composite.h (Fcomposite_get_gstring): Remove decl.
7029 * dired.c (Ffile_attributes): New forward static decl.
7030 * doc.c (Fdocumntation_property): New forward static decl.
7031 * eval.c (Ffetch_bytecode): New forward static decl.
7032 (Funintern): Remove extern decl; now in .h file where it belongs.
7033 * fileio.c (Fmake_symbolic_link): New forward static decl.
7034 * image.c (Finit_image_library): New forward static decl.
7035 * insdel.c (Fcombine_after_change_execute): Make forward decl static.
7036 * intervals.h (Fprevious_property_change):
7037 (Fremove_list_of_text_properties): Remove decls.
7038 * keyboard.c (Fthis_command_keys): Remove decl.
7039 (Fcommand_execute): New forward static decl.
7040 * keymap.c (Flookup_key): New forward static decl.
7041 (Fcopy_keymap): Now static.
7042 * keymap.h (Flookup_key): Remove decl.
7043 * process.c (Fget_process): New forward static decl.
7044 (Fprocess_datagram_address): Mark as internal.
7045 * syntax.c (Fsyntax_table_p): New forward static decl.
7046 (skip_chars): Remove duplicate decl.
7047 * textprop.c (Fprevious_property_change): New forward static decl.
7048 * window.c (Fset_window_fringes, Fset_window_scroll_bars):
7049 Now internal.
7050 (Fset_window_margins, Fset_window_vscroll): New forward static decls.
7051 * window.h (Fset_window_vscroll, Fset_window_margins): Remove decls.
7052
785bbd42
PE
7053 * editfns.c (Fformat): Remove unreachable code.
7054
8b913b57
AS
70552011-04-14 Andreas Schwab <schwab@linux-m68k.org>
7056
7057 * fileio.c (Finsert_file_contents): Fix typo in 2005-05-13
7058 change. (Bug#8496)
7059
a6744a35
EZ
70602011-04-13 Eli Zaretskii <eliz@gnu.org>
7061
7062 * xdisp.c (handle_invisible_prop): Don't call bidi_paragraph_init
7063 when at ZV. (Bug#8487)
7064
e7974947
AS
70652011-04-12 Andreas Schwab <schwab@linux-m68k.org>
7066
baad03f0
AS
7067 * charset.c (Fclear_charset_maps): Use xfree instead of free.
7068 (Bug#8437)
7069 * keyboard.c (parse_tool_bar_item): Likewise.
7070 * sound.c (sound_cleanup, alsa_close): Likewise.
7071 * termcap.c (tgetent): Likewise.
7072 * xfns.c (x_default_font_parameter): Likewise.
7073 * xsettings.c (read_and_apply_settings): Likewise.
7074
e7974947
AS
7075 * alloc.c (overrun_check_malloc, overrun_check_realloc)
7076 (overrun_check_free): Protoize.
7077
28272684
PE
70782011-04-12 Paul Eggert <eggert@cs.ucla.edu>
7079
7080 * sysdep.c (emacs_read, emacs_write): Check for negative sizes
7081 since callers should never pass a negative size.
7082 Change the signature to match that of plain 'read' and 'write'; see
7083 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00397.html>.
7084 * lisp.h: Update prototypes of emacs_write and emacs_read.
7085
11997c76
EZ
70862011-04-11 Eli Zaretskii <eliz@gnu.org>
7087
7088 * xdisp.c (redisplay_window): Don't try to determine the character
7089 position of the scroll margin if the window start point w->startp
e896f03c 7090 is outside the buffer's accessible region. (Bug#8468)
11997c76 7091
8a2cbd72
EZ
70922011-04-10 Eli Zaretskii <eliz@gnu.org>
7093
7094 Fix write-region and its subroutines for buffers > 2GB.
7095 * fileio.c (a_write, e_write): Modify declaration of arguments and
7096 local variables to support buffers larger than 2GB.
7097 (Fcopy_file): Use EMACS_INT for return value of emacs_read.
7098
7099 * sysdep.c (emacs_write, emacs_read): Use ssize_t for last
7100 argument, local variables, and return value.
7101
7102 * lisp.h: Update prototypes of emacs_write and emacs_read.
7103
7104 * sound.c (vox_write): Use ssize_t for return value of emacs_write.
7105
4073e537 71062011-04-10 Paul Eggert <eggert@cs.ucla.edu>
eb3f1cc8 7107
1ebfdcb6
PE
7108 * xdisp.c (vmessage): Use memchr, not strnlen, which some hosts lack.
7109
b2ded58d
PE
7110 Fix more problems found by GCC 4.6.0's static checks.
7111
7d66342c
PE
7112 * xdisp.c (vmessage): Use a better test for character truncation.
7113
bbf47d44
PE
7114 * charset.c (load_charset_map): <, not <=, for optimization,
7115 and to avoid potential problems with integer overflow.
9248994d 7116 * chartab.c (sub_char_table_set_range, char_table_set_range): Likewise.
f9a68bc5 7117 * casetab.c (set_identity, shuffle): Likewise.
3ab1c7ce 7118 * editfns.c (Fformat): Likewise.
1e69125e 7119 * syntax.c (skip_chars): Likewise.
3befa583 7120
e3019616
PE
7121 * xmenu.c (set_frame_menubar): Allocate smaller local vectors.
7122 This also lets GCC 4.6.0 generate slightly better loop code.
7123
becfa255
PE
7124 * callint.c (Fcall_interactively): <, not <=, for optimization.
7125 (Fcall_interactively): Count the number of arguments produced,
7126 not the number of arguments given. This is simpler and lets GCC
7127 4.6.0 generate slightly better code.
7128
dae0cd48
PE
7129 * ftfont.c: Distingish more carefully between FcChar8 and char.
7130 The previous code passed unsigned char * to a functions like
7131 strlen and xstrcasecmp that expect char *, which does not
7132 conform to the C standard.
7133 (get_adstyle_property, ftfont_pattern_entity): Use FcChar8 for
7134 arguments to FcPatternGetString, and explicitly cast FcChar8 * to
7135 char * when the C standard requires it.
7136
76032d70
PE
7137 * keyboard.c (read_char): Remove unused var.
7138
eb3f1cc8
PE
7139 * eval.c: Port to Windows vsnprintf (Bug#8435).
7140 Include <limits.h>.
7141 (SIZE_MAX): Define if the headers do not.
7142 (verror): Do not give up if vsnprintf returns a negative count.
7143 Instead, grow the buffer. This ports to Windows vsnprintf, which
7144 does not conform to C99. Problem reported by Eli Zaretskii.
7145 Also, simplify the allocation scheme, by avoiding the need for
7146 calling realloc, and removing the ALLOCATED variable.
7147
70476b54
PE
7148 * eval.c (verror): Initial buffer size is 4000 (not 200) bytes.
7149
12020a9e
PE
7150 Remove invocations of doprnt, as Emacs now uses vsnprintf.
7151 But keep the doprint source code for now, as we might revamp it
7152 and use it again (Bug#8435).
ea6c7ae6
PE
7153 * lisp.h (doprnt): Remove.
7154 * Makefile.in (base_obj): Remove doprnt.o.
7155 * deps.mk (doprnt.o): Remove.
7156
5fdb398c
PE
7157 error: Print 32- and 64-bit integers portably (Bug#8435).
7158 Without this change, on typical 64-bit hosts error ("...%d...", N)
7159 was used to print both 32- and 64-bit integers N, which relied on
7160 undefined behavior.
7161 * lisp.h, src/m/amdx86-64.h, src/m/ia64.h, src/m/ibms390x.h (pEd):
7162 New macro.
7163 * lisp.h (error, verror): Mark as printf-like functions.
7164 * eval.c (verror): Use vsnprintf, not doprnt, to do the real work.
7165 Report overflow in size calculations when allocating printf buffer.
7166 Do not truncate output string at its first null byte.
7167 * xdisp.c (vmessage): Use vsnprintf, not doprnt, to do the real work.
7168 Truncate the output at a character boundary, since vsnprintf does not
7169 do that.
7170 * charset.c (check_iso_charset_parameter): Convert internal
7171 character to string before calling 'error', since %c now has the
7172 printf meaning.
7173 * coding.c (Fdecode_sjis_char, Fdecode_big5_char): Avoid int
7174 overflow when computing char to be passed to 'error'. Do not
7175 pass Lisp_Object to 'error'; pass the integer instead.
7176 * nsfns.m (Fns_do_applescript): Use int, not long, since it's
7177 formatted with plain %d.
7178
b189fa66
PE
7179 * eval.c (internal_lisp_condition_case): Don't pass spurious arg.
7180
bff87ef0
PE
7181 * keyboard.c (access_keymap_keyremap): Print func name, not garbage.
7182
7e2cac20
PE
7183 * coding.c (Fdecode_sjis_char): Don't assume CODE fits in int.
7184
ce4d90b5
PE
7185 * xterm.c (x_catch_errors): Remove duplicate declaration.
7186
266c9547
PE
7187 * term.c (maybe_fatal): Mark its 3rd arg as a printf format, too.
7188
79c49ad2
PE
7189 * xdisp.c, lisp.h (message_nolog): Remove; unused.
7190
368f4090
JM
71912011-04-10 Jim Meyering <meyering@redhat.com>
7192
7193 use ssize_t and size_t for read- and write-like emacs_gnutls_* functions
7194 * gnutls.c (emacs_gnutls_read): Adjust signature to be more read-like:
7195 return ssize_t not "int", and use size_t as the buffer length.
7196 (emacs_gnutls_write): Likewise, and make the buffer pointer "const".
7197 * gnutls.h: Update declarations.
7198 * process.c (read_process_output): Use ssize_t, to match.
7199 (send_process): Likewise.
7200
a32d4040
CY
72012011-04-09 Chong Yidong <cyd@stupidchicken.com>
7202
7203 * image.c (Fimagemagick_types): Doc fix, and comment cleanup.
7204
8546720e 72052011-04-09 Chong Yidong <cyd@stupidchicken.com>
aac0c6e3 7206
04f2d78b
CB
7207 * ftfont.c (get_adstyle_property, ftfont_pattern_entity):
7208 Use unsigned char, to match FcChar8 type definition.
aac0c6e3 7209
8546720e
GM
7210 * xterm.c (handle_one_xevent):
7211 * xmenu.c (create_and_show_popup_menu):
7212 * xselect.c (x_decline_selection_request)
7213 (x_reply_selection_request): Avoid type-punned deref of X events.
aac0c6e3 7214
0a2f5c1a 72152011-04-09 Eli Zaretskii <eliz@gnu.org>
a53e2e89
EZ
7216
7217 Fix some uses of `int' instead of EMACS_INT.
7218 * search.c (string_match_1, fast_string_match)
7219 (fast_c_string_match_ignore_case, fast_string_match_ignore_case)
7220 (scan_buffer, find_next_newline_no_quit)
7221 (find_before_next_newline, search_command, Freplace_match)
7222 (Fmatch_data): Make some `int' variables be EMACS_INT.
7223
7224 * xdisp.c (display_count_lines): 3rd argument and return value now
7225 EMACS_INT. All callers changed.
7226 (pint2hrstr): Last argument is now EMACS_INT.
7227
7228 * coding.c (detect_coding_utf_8, detect_coding_emacs_mule)
7229 (detect_coding_iso_2022, detect_coding_sjis, detect_coding_big5)
7230 (detect_coding_ccl, detect_coding_charset, decode_coding_utf_8)
7231 (decode_coding_utf_16, decode_coding_emacs_mule)
7232 (decode_coding_iso_2022, decode_coding_sjis, decode_coding_big5)
7233 (decode_coding_ccl, decode_coding_charset)
7234 <consumed_chars, consumed_chars_base>: Declare EMACS_INT.
7235 (decode_coding_iso_2022, decode_coding_emacs_mule)
7236 (decode_coding_sjis, decode_coding_big5, decode_coding_charset)
7237 <char_offset, last_offset>: Declare EMACS_INT.
7238 (encode_coding_utf_8, encode_coding_utf_16)
7239 (encode_coding_emacs_mule, encode_invocation_designation)
7240 (encode_designation_at_bol, encode_coding_iso_2022)
7241 (encode_coding_sjis, encode_coding_big5, encode_coding_ccl)
7242 (encode_coding_raw_text, encode_coding_charset) <produced_chars>:
7243 Declare EMACS_INT.
7244 (ASSURE_DESTINATION): Declare more_bytes EMACS_INT.
7245 (encode_invocation_designation): Last argument P_NCHARS is now
7246 EMACS_INT.
7247 (decode_eol): Declare pos_byte, pos, and pos_end EMACS_INT.
7248 (produce_chars): from_nchars and to_nchars are now EMACS_INT.
7249
7250 * coding.h (struct coding_system) <head_ascii>: Declare EMACS_INT.
7251 All users changed.
7252
7253 * ccl.c (Fccl_execute_on_string): Declare some variables
7254 EMACS_INT.
7255
8546720e 72562011-04-08 Samuel Thibault <sthibault@debian.org> (tiny change)
0080dc6b
SS
7257
7258 * term.c (init_tty): Fix incorrect ifdef placement (Bug#8450).
7259
4e19a977
CS
72602011-03-19 Christoph Scholtes <cschol2112@googlemail.com>
7261
7262 * process.c (Fformat_network_address): Doc fix.
7263
87302331
R
72642011-04-08 T.V. Raman <tv.raman.tv@gmail.com> (tiny change)
7265
7266 * xml.c (parse_region): Avoid creating spurious whiespace nodes.
7267
cbb59342
CY
72682011-04-08 Chong Yidong <cyd@stupidchicken.com>
7269
7270 * keyboard.c (read_char): Call Lisp function help-form-show,
7271 instead of using internal_with_output_to_temp_buffer.
7272 (Qhelp_form_show): New var.
e0d38eeb 7273 (syms_of_keyboard): Use DEFSYM macro.
cbb59342
CY
7274
7275 * print.c (internal_with_output_to_temp_buffer): Function deleted.
7276
7277 * lisp.h (internal_with_output_to_temp_buffer): Remove prototype.
7278
e67a13ab
CY
72792011-04-06 Chong Yidong <cyd@stupidchicken.com>
7280
04f2d78b
CB
7281 * process.c (Flist_processes): Remove to Lisp.
7282 (list_processes_1): Delete.
e67a13ab 7283
973f782d
EZ
72842011-04-06 Eli Zaretskii <eliz@gnu.org>
7285
7c106b1e
EZ
7286 * msdos.c (careadlinkat, careadlinkatcwd): MS-DOS replacements.
7287
973f782d
EZ
7288 * w32.c (careadlinkat, careadlinkatcwd): New always-fail stubs.
7289
41cf7d1a 72902011-04-06 Paul Eggert <eggert@cs.ucla.edu>
27ccc379 7291
ca23cc88
PE
7292 Fix more problems found by GCC 4.6.0's static checks.
7293
f390e2d5
PE
7294 * xmenu.c (Fx_popup_dialog): Don't assume string is free of formats.
7295
42eea0d0
PE
7296 * menu.c (Fx_popup_menu): Don't assume error_name lacks printf formats.
7297
b69769da 7298 * lisp.h (message, message_nolog, fatal): Mark as printf-like.
1e973bc7 7299
f9541e84
PE
7300 * xdisp.c (vmessage): Mark as a printf-like function.
7301
13841b55
PE
7302 * term.c (vfatal, maybe_fatal): Mark as printf-like functions.
7303
c136c10f
PE
7304 * sound.c (sound_warning): Don't crash if arg contains a printf format.
7305
5e2d4a30
PE
7306 * image.c (tiff_error_handler, tiff_warning_handler): Mark as
7307 printf-like functions.
7308 (tiff_load): Add casts to remove these marks before passing them
7309 to system-supplied API.
7310
583f48b9
PE
7311 * eval.c (Fsignal): Remove excess argument to 'fatal'.
7312
b25d760e
PE
7313 * coding.c (EMIT_ONE_BYTE, EMIT_TWO_BYTES): Use unsigned, not int.
7314 This avoids several warnings with gcc -Wstrict-overflow.
d5efd1d1
PE
7315 (DECODE_COMPOSITION_RULE): If the rule is invalid, goto invalid_code
7316 directly, rather than having caller test rule sign. This avoids
7317 some unnecessary tests.
7318 * composite.h (COMPOSITION_ENCODE_RULE_VALID): New macro.
7319 (COMPOSITION_ENCODE_RULE): Arguments now must be valid. This
7320 affects only one use, in DECODE_COMPOSITION_RULE, which is changed.
b25d760e 7321
bc7b6697 7322 * xfont.c (xfont_text_extents): Remove var that was set but not used.
625a3eb1 7323 (xfont_open): Avoid unnecessary tests.
bc7b6697 7324
27ccc379
PE
7325 * composite.c (composition_gstring_put_cache): Use unsigned integer.
7326
dcd5c89a
PE
7327 * composite.h, composite.c (composition_gstring_put_cache):
7328 Use EMACS_INT, not int, for length.
7329
b13a45c6
PE
7330 * composite.h (COMPOSITION_DECODE_REFS): New macro,
7331 breaking out part of COMPOSITION_DECODE_RULE.
7332 (COMPOSITION_DECODE_RULE): Use it.
7333 * composite.c (get_composition_id): Remove unused local vars,
7334 by using the new macro.
7335
1e792e4d
PE
7336 * textprop.c (set_text_properties_1): Change while to do-while,
7337 since the condition is always true at first.
7338
dc6c6455 7339 * intervals.c (graft_intervals_into_buffer): Mark var as used.
aa86731f
PE
7340 (interval_deletion_adjustment): Return unsigned value.
7341 All uses changed.
dc6c6455 7342
aba7731a
PE
7343 * process.c (list_processes_1, create_pty, read_process_output):
7344 (exec_sentinel): Remove vars that were set but not used.
afd4052b 7345 (create_pty): Remove unnecessary "volatile"s.
bc57d757 7346 (Fnetwork_interface_info): Avoid possibility of int overflow.
82eaa333 7347 (read_process_output): Do adaptive read buffering even if carryover.
fe07cdfa 7348 (read_process_output): Simplify nbytes computation if buffered.
aba7731a 7349
fdfc4bf3
PE
7350 * bytecode.c (exec_byte_code): Rename local to avoid shadowing.
7351
fca8fe46 7352 * syntax.c (scan_words): Remove var that was set but not used.
12cbf13f 7353 (update_syntax_table): Use unsigned instead of int.
fca8fe46 7354
06a0259a 7355 * lread.c (lisp_file_lexically_bound_p): Use ints rather than endptrs.
3c346cc3 7356 (lisp_file_lexically_bound_p, read1): Use unsigned instead of int.
e6eb4e9e 7357 (safe_to_load_p): Make the end-of-loop test the inverse of the in-loop.
06a0259a 7358
e7b9e80f
PE
7359 * print.c (print_error_message): Avoid int overflow.
7360
56201685
PE
7361 * font.c (font_list_entities): Redo for clarity,
7362 so that reader need not know FONT_DPI_INDEX + 1 == FONT_SPACING_INDEX.
7363
78834453 7364 * font.c (font_find_for_lface, Ffont_get_glyphs): Remove unused vars.
790771b1 7365 (font_score): Avoid potential overflow in diff calculation.
78834453 7366
0bc0b309 7367 * fns.c (substring_both): Remove var that is set but not used.
8cd55cb4 7368 (sxhash): Redo loop for clarity and to avoid wraparound warning.
0bc0b309 7369
e610eaca
PE
7370 * eval.c (funcall_lambda): Rename local to avoid shadowing.
7371
b895abce
PE
7372 * alloc.c (mark_object_loop_halt, mark_object): Use size_t, not int.
7373 Otherwise, GCC 4.6.0 optimizes the loop check away since the check
7374 can always succeed if overflow has undefined behavior.
7375
1f1d9321 7376 * search.c (boyer_moore, wordify): Remove vars set but not used.
6f076cc7 7377 (wordify): Omit three unnecessary tests.
1f1d9321 7378
c59478bc
PE
7379 * indent.c (MULTIBYTE_BYTES_WIDTH): Don't compute wide_column.
7380 All callers changed. This avoids the need for an unused var.
7381
79b73827
PE
7382 * casefiddle.c (casify_region): Remove var that is set but not used.
7383
a4db5dfe
PE
7384 * dired.c (file_name_completion): Remove var that is set but not used.
7385
43aae36e
PE
7386 * fileio.c (Finsert_file_contents): Make EOF condition clearer.
7387
2a47c44d 7388 * fileio.c (Finsert_file_contents): Avoid signed integer overflow.
163c5f32 7389 (Finsert_file_contents): Remove unnecessary code checking fd.
2a47c44d 7390
a37c69bf
PE
7391 * minibuf.c (read_minibuf_noninteractive): Use size_t for sizes.
7392 Check for integer overflow on size calculations.
7393
328ab8e7
PE
7394 * buffer.c (Fprevious_overlay_change): Remove var that is set
7395 but not used.
7396
e5a2a5cb
PE
7397 * keyboard.c (menu_bar_items, read_char_minibuf_menu_prompt):
7398 Remove vars that are set but not used.
8d84a6eb 7399 (timer_check_2): Don't assume timer-list and idle-timer-list are lists.
6b043475 7400 (timer_check_2): Mark vars as initialized.
e5a2a5cb 7401
a60e5f68
PE
7402 * gtkutil.c (xg_get_file_with_chooser): Mark var as initialized.
7403
f661cb61 7404 * image.c (lookup_image): Remove var that is set but not used.
35fa624f 7405 (xbm_load): Use parse_p, for gcc -Werror=unused-but-set-variable.
f661cb61 7406
f0397f5a
PE
7407 * fontset.c (Finternal_char_font, Ffontset_info): Remove vars
7408 that are set but not used.
7409
8664db06 7410 * xfns.c (make_invisible_cursor): Don't return garbage
03733ee7 7411 if XCreateBitmapFromData fails (Bug#8410).
8664db06 7412
6abdaa4a
PE
7413 * xselect.c (x_get_local_selection, x_handle_property_notify):
7414 Remove vars that are set but not used.
7415
0ce7538d 7416 * xfns.c (x_create_tip_frame): Remove var that is set but not used.
6abdaa4a 7417 (make_invisible_cursor): Initialize a possibly-uninitialized variable.
0ce7538d 7418
9ae848fc
PE
7419 * xterm.c (x_scroll_bar_to_input_event) [!USE_GTK]:
7420 Remove var that is set but not used.
0b918413
PE
7421 (scroll_bar_windows_size): Now size_t, not int.
7422 (x_send_scroll_bar_event): Use size_t, not int, for sizes.
7423 Check for overflow.
9ae848fc 7424
a5a62657
PE
7425 * xfaces.c (realize_named_face): Remove vars that are set but not used.
7426 (map_tty_color) [!defined MSDOS]: Likewise.
7427
5c5cdd39
PE
7428 * term.c (tty_write_glyphs): Use size_t; this avoids overflow warning.
7429
66ebf983
PE
7430 * coding.c: Remove vars that are set but not used.
7431 (DECODE_COMPOSITION_RULE): Remove 2nd arg, which is unused.
7432 All callers changed.
7433 (decode_coding_utf_8, decode_coding_utf_16 decode_coding_emacs_mule):
7434 (decode_coding_iso_2022, encode_coding_sjis, encode_coding_big5):
7435 (decode_coding_charset): Remove vars that are set but not used.
7436
1be4d761
PE
7437 * bytecode.c (Fbyte_code) [!defined BYTE_CODE_SAFE]: Remove var
7438 that is set but not used.
7439
47553fa8
PE
7440 * print.c (print_object): Remove var that is set but not used.
7441
1f7196bf 7442 Replace 2 copies of readlink code with 1 gnulib version (Bug#8401).
d1fdcab7
PE
7443 The gnulib version avoids calling malloc in the usual case,
7444 and on 64-bit hosts doesn't have some arbitrary 32-bit limits.
7445 * fileio.c (Ffile_symlink_p): Use emacs_readlink.
7446 * filelock.c (current_lock_owner): Likewise.
7447 * lisp.h (READLINK_BUFSIZE, emacs_readlink): New function.
7448 * sysdep.c: Include allocator.h, careadlinkat.h.
7449 (emacs_no_realloc_allocator): New static constant.
7450 (emacs_readlink): New function.
fdb61804
PE
7451 * deps.mk (sysdep.o): Depend on ../lib/allocator.h and on
7452 ../lib/careadlinkat.h.
d1fdcab7 7453
f84c17c7
SM
74542011-04-04 Stefan Monnier <monnier@iro.umontreal.ca>
7455
7456 * keyboard.c (safe_run_hook_funcall): Fix last change (don't stop at the
7457 first non-nil return value).
7458
ef3862ad
JD
74592011-04-03 Jan Djärv <jan.h.d@swipnet.se>
7460
7461 * nsterm.m (ns_update_auto_hide_menu_bar): Define MAC_OS_X_VERSION_10_6
7462 if not defined (Bug#8403).
7463
376a7006
JB
74642011-04-02 Juanma Barranquero <lekktu@gmail.com>
7465
7466 * xdisp.c (display_count_lines): Remove parameter `start',
7467 unused since 1998-01-01T02:27:27Z!rms@gnu.org. All callers changed.
7468 (get_char_face_and_encoding): Remove parameter `multibyte_p',
7469 unused since 2008-05-14T01:40:23Z!handa@m17n.org. All callers changed.
7470 (fill_stretch_glyph_string): Remove parameters `row' and `area',
7471 unused at least since Kim's GUI unification at 2003-03-16T20:45:46Z!storm@cua.dk
7472 and thereabouts. All callers changed.
7473 (get_per_char_metric): Remove parameter `f', unused since
7474 2008-05-14T01:40:23Z!handa@m17n.org. All callers changed.
7475
6ca3801d
JM
74762011-04-02 Jim Meyering <meyering@redhat.com>
7477
7478 do not dereference NULL upon failed strdup
7479 * nsfont.m (ns_descriptor_to_entity): Use xstrdup, not strdup.
7480 (ns_get_family): Likewise.
7481
d8e2b5ba
JB
74822011-04-02 Juanma Barranquero <lekktu@gmail.com>
7483
7484 * eval.c (unwind_to_catch) [DEBUG_GCPRO]: Remove redundant assignment.
7485
8c74fcbd
JD
74862011-04-02 Jan Djärv <jan.h.d@swipnet.se>
7487
7488 * nsterm.m (ns_update_auto_hide_menu_bar): Only for OSX 10.6 or
7489 later (Bug#8403).
7490
7200d79c
SM
74912011-04-01 Stefan Monnier <monnier@iro.umontreal.ca>
7492
03408648 7493 Add lexical binding.
7200d79c 7494
03408648
SM
7495 * window.c (Ftemp_output_buffer_show): New fun.
7496 (Fsave_window_excursion):
7497 * print.c (Fwith_output_to_temp_buffer): Move to subr.el.
7498
7499 * lread.c (lisp_file_lexically_bound_p): New function.
7500 (Fload): Bind Qlexical_binding.
7501 (readevalloop): Remove `evalfun' arg.
7502 Bind Qinternal_interpreter_environment.
7503 (Feval_buffer): Bind Qlexical_binding.
7504 (defvar_int, defvar_bool, defvar_lisp_nopro, defvar_kboard):
7505 Mark as dynamic.
7506 (syms_of_lread): Declare `lexical-binding'.
7507
7508 * lisp.h (struct Lisp_Symbol): New field `declared_special'.
7509
7510 * keyboard.c (eval_dyn): New fun.
7511 (menu_item_eval_property): Use it.
ca105506
SM
7512
7513 * image.c (parse_image_spec): Use Ffunctionp.
ca105506 7514
03408648
SM
7515 * fns.c (concat, mapcar1): Accept byte-code-functions.
7516
7517 * eval.c (Fsetq): Handle lexical vars.
7518 (Fdefun, Fdefmacro, Ffunction): Make closures when needed.
7519 (Fdefconst, Fdefvaralias, Fdefvar): Mark as dynamic.
7520 (FletX, Flet): Obey lexical binding.
7521 (Fcommandp): Handle closures.
7522 (Feval): New `lexical' arg.
7523 (eval_sub): New function extracted from Feval. Use it almost
7524 everywhere where Feval was used. Look up vars in lexical env.
7525 Handle closures.
7526 (Ffunctionp): Move from subr.el.
7527 (Ffuncall): Handle closures.
7528 (apply_lambda): Remove `eval_flags'.
7529 (funcall_lambda): Handle closures and new byte-code-functions.
7530 (Fspecial_variable_p): New function.
7531 (syms_of_eval): Initialize the Vinternal_interpreter_environment var,
7532 but without exporting it to Lisp.
23aba0ea 7533
23aba0ea 7534 * doc.c (Fdocumentation, store_function_docstring):
03408648 7535 * data.c (Finteractive_form): Handle closures.
23aba0ea 7536
03408648
SM
7537 * callint.c (Fcall_interactively): Preserve lexical-binding mode for
7538 interactive spec.
ba83908c 7539
04f2d78b
CB
7540 * bytecode.c (Bstack_ref, Bstack_set, Bstack_set2, BdiscardN):
7541 New byte-codes.
03408648
SM
7542 (exec_byte_code): New function extracted from Fbyte_code to handle new
7543 calling convention for byte-code-functions. Add new byte-codes.
ba83908c 7544
03408648 7545 * buffer.c (defvar_per_buffer): Set new `declared_special' field.
e2abe5a1 7546
03408648 7547 * alloc.c (Fmake_symbol): Init new `declared_special' field.
e2abe5a1 7548
e2abce01
JB
75492011-03-31 Juanma Barranquero <lekktu@gmail.com>
7550
7551 * xdisp.c (redisplay_internal): Fix prototype.
7552
63696a73 75532011-03-31 Eli Zaretskii <eliz@gnu.org>
09725d26 7554
63696a73 7555 * xdisp.c (SCROLL_LIMIT): New macro.
04f2d78b
CB
7556 (try_scrolling): Use it when setting scroll_limit.
7557 Limit scrolling to 100 screen lines.
63696a73
EZ
7558 (redisplay_window): Even when falling back on "recentering",
7559 position point in the window according to scroll-conservatively,
7560 scroll-margin, and scroll-*-aggressively variables. (Bug#6671)
7561
7562 (try_scrolling): When point is above the window, allow searching
7563 as far as scroll_max, or one screenful, to compute vertical
7564 distance from PT to the scroll margin position. This prevents
7565 try_scrolling from unnecessarily failing when
7566 scroll-conservatively is set to a value slightly larger than the
7567 window height. Clean up the case of PT below the margin at bottom
7568 of window: scroll_max can no longer be INT_MAX. When aggressive
7569 scrolling is in use, don't let point enter the opposite scroll
7570 margin as result of the scroll.
7571 (syms_of_xdisp) <scroll-conservatively>: Document the
09725d26
EZ
7572 threshold of 100 lines for never-recentering scrolling.
7573
e4cc2dfc
JB
75742011-03-31 Juanma Barranquero <lekktu@gmail.com>
7575
7576 * dispextern.h (move_it_by_lines):
7577 * xdisp.c (move_it_by_lines): Remove parameter `need_y_p', unused
7578 since 2000-12-29T14:24:09Z!gerd@gnu.org. All callers changed.
7579 (message_log_check_duplicate): Remove parameters `prev_bol' and
7580 `this_bol', unused since 1998-01-01T02:27:27Z!rms@gnu.org. All callers changed.
7581 (redisplay_internal): Remove parameter `preserve_echo_area',
7582 unused since 1999-07-21T21:43:52Z!gerd@gnu.org. All callers changed.
7583
7584 * indent.c (Fvertical_motion):
7585 * window.c (window_scroll_pixel_based, Frecenter):
7586 Don't pass `need_y_p' to `move_it_by_lines'.
7587
1c470562
SM
75882011-03-30 Stefan Monnier <monnier@iro.umontreal.ca>
7589
44f230aa
SM
7590 * eval.c (struct backtrace): Don't cheat with negative numbers, but do
7591 steal a few bits to be more compact.
7592 (interactive_p, Fbacktrace, Fbacktrace_frame, mark_backtrace):
7593 Remove unneeded casts.
7594
1c470562
SM
7595 * bytecode.c (Fbyte_code): CAR and CDR can GC.
7596
888adce9
ZK
75972011-03-30 Zachary Kanfer <zkanfer@gmail.com> (tiny change)
7598
7599 * keyboard.c (Fexecute_extended_command): Do log the "suggest key
7600 binding" message (bug#7967).
7601
f838ed7b
PE
76022011-03-30 Paul Eggert <eggert@cs.ucla.edu>
7603
77861b95
PE
7604 Fix more problems found by GCC 4.6.0's static checks.
7605
de6dbc14
PE
7606 * unexelf.c (unexec) [! (defined _SYSTYPE_SYSV || defined __sgi)]:
7607 Remove unused local var.
7608
f838ed7b
PE
7609 * editfns.c (Fmessage_box): Remove unused local var.
7610
792c7b2b
PE
7611 * xdisp.c (try_window_reusing_current_matrix, x_produce_glyphs):
7612 (note_mode_line_or_margin_highlight, note_mouse_highlight):
7613 Omit unused local vars.
c499e557 7614 * window.c (shrink_windows): Omit unused local var.
b01a1c29 7615 * menu.c (digest_single_submenu): Omit unused local var.
0bc32927
PE
7616 * dispnew.c (update_window) [PERIODIC_PREEMPTION_CHECKING]:
7617 Omit unused local var.
7618
ba0165e1
PE
7619 * keyboard.c (parse_modifiers_uncached, parse_modifiers):
7620 Don't assume string length fits in int.
32ad8845 7621 (keyremap_step, read_key_sequence): Use size_t for sizes.
48011560 7622 (read_key_sequence): Don't check last_real_key_start redundantly.
ba0165e1 7623
3c59b4c9
PE
7624 * callproc.c (Fcall_process, Fcall_process_region): Use SAFE_ALLOCA
7625 instead of alloca (Bug#8344).
7626
a3eed478 7627 * eval.c (Fbacktrace): Don't assume nargs fits in int.
5d5d959d 7628 (Fbacktrace_frame): Don't assume nframes fits in int.
a3eed478 7629
eb4d412d
PE
7630 * syntax.c (scan_sexps_forward): Avoid pointer wraparound.
7631
1658b401
PE
7632 * xterm.c (x_make_frame_visible, same_x_server): Redo to avoid overflow
7633 concerns.
7634
7635 * term.c (produce_glyphless_glyph): Remove unnecessary test.
7636
7637 * cm.c (calccost): Turn while-do into do-while, for clarity.
44f730c8 7638
9a2c6e05
PE
7639 * keyboard.c (syms_of_keyboard): Use the same style as later
7640 in this function when indexing through an array. This also
7641 works around GCC bug 48267.
7642
03d0a109
PE
7643 * image.c (tiff_load): Fix off-by-one image count (Bug#8336).
7644
44f730c8
PE
7645 * xselect.c (x_check_property_data): Return correct size (Bug#8335).
7646
fe75f926
PE
7647 * chartab.c (sub_char_table_ref_and_range): Redo for slight
7648 efficiency gain, and to bypass a gcc -Wstrict-overflow warning.
7649
ffa8c828
PE
7650 * keyboard.c, keyboard.h (num_input_events): Now size_t.
7651 This avoids undefined behavior on integer overflow, and is a bit
7652 more convenient anyway since it is compared to a size_t variable.
7653
c5101a77
PE
7654 Variadic C functions now count arguments with size_t, not int.
7655 This avoids an unnecessary limitation on 64-bit machines, which
7656 caused (substring ...) to crash on large vectors (Bug#8344).
7657 * lisp.h (struct Lisp_Subr.function.aMANY): Now takes size_t, not int.
7658 (DEFUN_ARGS_MANY, internal_condition_case_n, safe_call): Likewise.
77861b95 7659 All variadic functions and their callers changed accordingly.
c5101a77
PE
7660 (struct gcpro.nvars): Now size_t, not int. All uses changed.
7661 * data.c (arith_driver, float_arith_driver): Likewise.
7662 * editfns.c (general_insert_function): Likewise.
7663 * eval.c (struct backtrace.nargs, interactive_p)
7664 (internal_condition_case_n, run_hook_with_args, apply_lambda)
7665 (funcall_lambda, mark_backtrace): Likewise.
7666 * fns.c (concat): Likewise.
7667 * frame.c (x_set_frame_parameters): Likewise.
7668 * fns.c (get_key_arg): Now accepts and returns size_t, and returns
7669 0 if not found, not -1. All callers changed.
7670
dd3f25f7
PE
7671 * alloc.c (garbage_collect): Don't assume stack size fits in int.
7672 (stack_copy_size): Now size_t, not int.
7673 (stack_copy, stack_copy_size): Define only if MAX_SAVE_STACK > 0.
7674
461c2ab9
JB
76752011-03-28 Juanma Barranquero <lekktu@gmail.com>
7676
7677 * coding.c (encode_designation_at_bol): Remove parameter `charbuf_end',
7678 unused since 2002-03-01T01:17:24Z!handa@m17n.org and 2008-02-01T16:01:31Z!miles@gnu.org.
7679 All callers changed.
7680
7681 * lisp.h (multibyte_char_to_unibyte):
7682 * character.c (multibyte_char_to_unibyte): Remove parameter `rev_tbl',
7683 unused since 2002-03-01T01:16:34Z!handa@m17n.org and 2008-02-01T16:01:31Z!miles@gnu.org.
7684 * character.h (CHAR_TO_BYTE8):
7685 * cmds.c (internal_self_insert):
7686 * editfns.c (general_insert_function):
7687 * keymap.c (push_key_description):
7688 * search.c (Freplace_match):
7689 * xdisp.c (message_dolog, set_message_1): All callers changed.
7690
f6d62986
SM
76912011-03-28 Stefan Monnier <monnier@iro.umontreal.ca>
7692
7693 * keyboard.c (safe_run_hook_funcall): New function.
7694 (safe_run_hooks_1, safe_run_hooks_error, safe_run_hooks): On error,
7695 don't set the hook to nil, but remove the offending function instead.
7696 (Qcommand_hook_internal): Remove, unused.
7697 (syms_of_keyboard): Don't initialize Qcommand_hook_internal nor define
7698 Vcommand_hook_internal.
7699
7700 * eval.c (enum run_hooks_condition): Remove.
7701 (funcall_nil, funcall_not): New functions.
7702 (run_hook_with_args): Call each function through a `funcall' argument.
7703 Remove `cond' argument, now redundant.
7704 (Frun_hooks, Frun_hook_with_args, Frun_hook_with_args_until_success)
7705 (Frun_hook_with_args_until_failure): Adjust accordingly.
7706 (run_hook_wrapped_funcall, Frun_hook_wrapped): New functions.
7707
1db5b1ad
JB
77082011-03-28 Juanma Barranquero <lekktu@gmail.com>
7709
7710 * dispextern.h (string_buffer_position): Remove declaration.
7711
7712 * print.c (strout): Remove parameter `multibyte', unused since
7713 1999-08-21T19:30:21Z!gerd@gnu.org. All callers changed.
7714
7715 * search.c (boyer_moore): Remove parameters `len', `pos' and `lim',
7716 never used since function introduction in 1998-02-08T21:33:56Z!rms@gnu.org.
7717 All callers changed.
7718
7719 * w32.c (_wsa_errlist): Use braces for struct initializers.
7720
7721 * xdisp.c (string_buffer_position_lim): Remove parameter `w',
7722 never used since function introduction in 2001-03-09T18:41:50Z!gerd@gnu.org.
7723 All callers changed.
7724 (string_buffer_position): Likewise. Also, make static (it's never
7725 used outside xdisp.c).
7726 (cursor_row_p): Remove parameter `w', unused since
7727 2000-10-17T16:08:57Z!gerd@gnu.org. All callers changed.
7728 (decode_mode_spec): Remove parameter `precision', introduced during
7729 Gerd Moellmann's rewrite at 1999-07-21T21:43:52Z!gerd@gnu.org, but never used.
7730 All callers changed.
7731
5ffb62aa
JD
77322011-03-27 Jan Djärv <jan.h.d@swipnet.se>
7733
7734 * nsterm.m (syms_of_nsterm): Use doc: for ns-auto-hide-menu-bar.
7735
461c2ab9 77362011-03-27 Anders Lindgren <andlind@gmail.com>
f0a1382a
JD
7737
7738 * nsterm.m (ns_menu_bar_is_hidden): New variable.
7739 (ns_constrain_all_frames, ns_menu_bar_should_be_hidden)
7740 (ns_update_auto_hide_menu_bar): New functions.
7741 (ns_update_begin): Call ns_update_auto_hide_menu_bar.
7742 (applicationDidBecomeActive): Call ns_update_auto_hide_menu_bar and
7743 ns_constrain_all_frames.
7744 (constrainFrameRect): Return at once if ns_menu_bar_should_be_hidden.
7745 (syms_of_nsterm): DEFVAR ns-auto-hide-menu-bar, init to Qnil.
7746
5c380ffb
JD
77472011-03-27 Jan Djärv <jan.h.d@swipnet.se>
7748
7749 * nsmenu.m (runDialogAt): Remove argument to timer_check.
7750
9af30bdf
GM
77512011-03-27 Glenn Morris <rgm@gnu.org>
7752
7753 * syssignal.h: Replace RETSIGTYPE with void.
7754 * atimer.c, data.c, dispnew.c, emacs.c, floatfns.c, keyboard.c:
7755 * keyboard.h, lisp.h, process.c, sysdep.c, xterm.c:
7756 Replace SIGTYPE with void everywhere.
7757 * s/usg5-4-common.h (SIGTYPE): Remove definition.
7758 * s/template.h (SIGTYPE): Remove commented out definition.
7759
e2abce01
JB
77602011-03-26 Eli Zaretskii <eliz@gnu.org>
7761
7762 * xdisp.c (redisplay_window): Don't check buffer's clip_changed
7763 flag as a prerequisite for invoking try_scrolling. (Bug#6671)
7764
f868cd8a
JB
77652011-03-26 Juanma Barranquero <lekktu@gmail.com>
7766
59eb0929
JB
7767 * w32.c (read_unc_volume): Use parameter `henum', instead of
7768 global variable `wget_enum_handle'.
7769
7770 * keymap.c (describe_vector): Remove parameters `indices' and
7771 `char_table_depth', unused since 2002-03-01T01:43:26Z!handa@m17n.org.
7772 (describe_map, Fdescribe_vector): Adjust calls to `describe_vector'.
7773
f868cd8a
JB
7774 * keyboard.h (timer_check, show_help_echo): Remove unused parameters.
7775
7776 * keyboard.c (timer_check): Remove parameter `do_it_now',
7777 unused since 1996-04-12T06:01:29Z!rms@gnu.org.
7778 (show_help_echo): Remove parameter `ok_to_overwrite_keystroke_echo',
7779 unused since 2008-04-19T19:30:53Z!monnier@iro.umontreal.ca.
7780
7781 * keyboard.c (read_char):
7782 * w32menu.c (w32_menu_display_help):
7783 * xmenu.c (show_help_event, menu_help_callback):
7784 Adjust calls to `show_help_echo'.
7785
7786 * gtkutil.c (xg_maybe_add_timer):
7787 * keyboard.c (readable_events):
7788 * process.c (wait_reading_process_output):
7789 * xmenu.c (x_menu_wait_for_event): Adjust calls to `timer_check'.
7790
7791 * insdel.c (adjust_markers_gap_motion):
7792 Remove; no-op since 1998-01-02T21:29:48Z!rms@gnu.org.
7793 (gap_left, gap_right): Don't call it.
7794
2ecf6fdb
CY
77952011-03-25 Chong Yidong <cyd@stupidchicken.com>
7796
7797 * xdisp.c (handle_fontified_prop): Discard changes to clip_changed
7798 incurred during fontification.
7799
6b1f9ba4
JB
78002011-03-25 Juanma Barranquero <lekktu@gmail.com>
7801
7802 * buffer.c (defvar_per_buffer): Remove unused parameter `doc'.
7803 (DEFVAR_PER_BUFFER): Don't pass it.
7804
7805 * dispnew.c (row_equal_p, add_row_entry): Remove unused parameter `w'.
7806 (scrolling_window): Don't pass it.
7807
0f4a96b5
JB
78082011-03-25 Juanma Barranquero <lekktu@gmail.com>
7809
7810 * dispextern.h (glyph_matric): Use #if GLYPH_DEBUG, not #ifdef.
7811
7812 * fileio.c (check_executable) [DOS_NT]: Remove unused variables `len'
7813 and `suffix'.
7814 (Fset_file_selinux_context) [HAVE_LIBSELINUX]: Move here declaration
7815 of variables specific to SELinux and computation of `encoded_absname'.
7816
7817 * image.c (XPutPixel): Remove unused variable `height'.
7818
7819 * keyboard.c (make_lispy_event): Remove unused variable `hpos'.
7820
7821 * unexw32.c (get_section_info): Remove unused variable `section'.
7822
7823 * w32.c (stat): Remove unused variables `drive_root' and `devtype'.
7824 (system_process_attributes): Remove unused variable `sess'.
7825 (sys_read): Remove unused variable `err'.
7826
7827 * w32fns.c (top): Wrap variables with #if GLYPH_DEBUG, not #ifdef.
7828 (w32_wnd_proc): Remove unused variable `isdead'.
7829 (unwind_create_frame): Use #if GLYPH_DEBUG, not #ifdef.
7830 (Fx_server_max_request_size): Remove unused variable `dpyinfo'.
7831 (x_create_tip_frame): Remove unused variable `tem'.
7832
7833 * w32inevt.c (w32_console_read_socket):
7834 Remove unused variable `no_events'.
7835
7836 * w32term.c (x_draw_composite_glyph_string_foreground):
7837 Remove unused variable `width'.
7838
1149507c
JB
78392011-03-24 Juanma Barranquero <lekktu@gmail.com>
7840
7841 * w32term.c (x_set_glyph_string_clipping):
7842 Don't pass uninitialized region to CombineRgn.
7843
9c88f339
JB
78442011-03-23 Juanma Barranquero <lekktu@gmail.com>
7845
7846 * w32fns.c (x_set_menu_bar_lines): Remove unused variable `olines'.
7847 (w32_wnd_proc): Pass NULL to Windows API, not uninitialized buffer.
7848 (Fx_close_connection): Remove unused variable `i'.
7849
7850 * w32font.c (w32font_draw): Return number of glyphs.
7851 (w32font_open_internal): Remove unused variable `i'.
7852 (w32font_driver): Add missing initializer.
7853
7854 * w32menu.c (utf8to16): Remove unused variable `utf16'.
7855 (fill_in_menu): Remove unused variable `items_added'.
7856
7857 * w32term.c (last_mouse_press_frame): Remove static global variable.
7858 (w32_clip_to_row): Remove unused variable `f'.
7859 (x_delete_terminal): Remove unused variable `i'.
7860
7861 * w32uniscribe.c (uniscribe_shape): Remove unused variable `nclusters'.
7862 (NOTHING): Remove unused static global variable.
7863 (uniscribe_check_otf): Remove unused variable `table'.
7864 (uniscribe_font_driver): Add missing initializers.
7865
dee091a3
JD
78662011-03-23 Julien Danjou <julien@danjou.info>
7867
7868 * term.c (Fsuspend_tty, Fresume_tty):
7869 * minibuf.c (read_minibuf, run_exit_minibuf_hook):
7870 * window.c (temp_output_buffer_show):
7871 * insdel.c (signal_before_change):
7872 * frame.c (Fhandle_switch_frame):
7873 * fileio.c (Fdo_auto_save):
7874 * emacs.c (Fkill_emacs):
7875 * editfns.c (save_excursion_restore):
7876 * cmds.c (internal_self_insert):
7877 * callint.c (Fcall_interactively):
7878 * buffer.c (Fkill_all_local_variables):
7879 * keyboard.c (Fcommand_execute, Fsuspend_emacs, safe_run_hooks_1):
7880 Use Frun_hooks.
0f4a96b5 7881 (command_loop_1): Use Frun_hooks. Call safe_run_hooks
dee091a3
JD
7882 unconditionnaly since it does the check itself.
7883
2c520ab5 78842011-03-23 Paul Eggert <eggert@cs.ucla.edu>
f0641eff 7885
c9c49752
PE
7886 Fix more problems found by GCC 4.5.2's static checks.
7887
8abc3f12
PE
7888 * coding.c (encode_coding_raw_text): Avoid unnecessary test
7889 the first time through the loop, since we know p0 < p1 then.
7890 This also avoids a gcc -Wstrict-overflow warning.
7891
a2d26660
PE
7892 * lisp.h (SAFE_ALLOCA, SAFE_ALLOCA_LISP): Avoid 'int' overflow
7893 leading to a memory leak, possible in functions like
7894 load_charset_map_from_file that can allocate an unbounded number
b12ef411 7895 of objects (Bug#8318).
a2d26660 7896
916c72e9
PE
7897 * xmenu.c (set_frame_menubar): Use EMACS_UINT, not int, for indexes
7898 that could (at least in theory) be that large.
7899
19ab8a18
PE
7900 * xdisp.c (message_log_check_duplicate): Return unsigned long, not int.
7901 This is less likely to overflow, and avoids undefined behavior if
7902 overflow does occur. All callers changed. Use strtoul to scan
7903 for the unsigned long integer.
b7cbbd6f
PE
7904 (pint2hrstr): Simplify and tune code slightly.
7905 This also avoids a (bogus) GCC warning with gcc -Wstrict-overflow.
19ab8a18 7906
f0641eff
PE
7907 * scroll.c (do_scrolling): Work around GCC bug 48228.
7908 See <http://gcc.gnu.org/bugzilla/show_bug.cgi?id=48228>.
7909
7f650bb9
PE
7910 * frame.c (Fmodify_frame_parameters): Simplify loop counter.
7911 This also avoids a warning with gcc -Wstrict-overflow.
39f5e519
PE
7912 (validate_x_resource_name): Simplify count usage.
7913 This also avoids a warning with gcc -Wstrict-overflow.
7f650bb9 7914
37dd57d1
PE
7915 * fileio.c (Fcopy_file): Report error if fchown or fchmod
7916 fail (Bug#8306).
81e56e61 7917
699979fc 7918 * emacs.c (Fdaemon_initialized): Do not ignore I/O errors (Bug#8303).
dc1ca6a8 7919
401bf9b4
PE
7920 * process.c (Fmake_network_process): Use socklen_t, not int,
7921 where POSIX says socklen_t is required in portable programs.
7922 This fixes a porting bug on hosts like 64-bit HP-UX, where
591b2973 7923 socklen_t is wider than int (Bug#8277).
401bf9b4
PE
7924 (Fmake_network_process, server_accept_connection):
7925 (wait_reading_process_output, read_process_output):
7926 Likewise.
7927
b93aacde
PE
7928 * process.c: Rename or move locals to avoid shadowing.
7929 (list_processes_1, Fmake_network_process):
7930 (read_process_output_error_handler, exec_sentinel_error_handler):
7931 Rename or move locals.
4dc343ee 7932 (Fmake_network_process): Define label "retry_connect" only if needed.
0da49335 7933 (Fnetwork_interface_info): Fix pointer signedness.
f990b4e5 7934 (process_send_signal): Add cast to avoid pointer signedness problem.
7b808126 7935 (FIRST_PROC_DESC, IF_NON_BLOCKING_CONNECT): Remove unused macros.
c939f91b 7936 (create_process): Use 'volatile' to avoid vfork clobbering (Bug#8298).
b93aacde 7937
af8a867c 7938 Make tparam.h and terminfo.c consistent.
44f230aa
SM
7939 * cm.c (tputs, tgoto, BC, UP): Remove extern decls.
7940 Include tparam.h instead, since it declares them.
af8a867c
PE
7941 * cm.h (PC): Remove extern decl; tparam.h now does this.
7942 * deps.mk (cm.o, terminfo.o): Depend on tparam.h.
7943 * terminfo.c: Include tparam.h, to check interfaces.
7944 (tparm): Make 1st arg a const pointer in decl. Put it at top level.
7945 (tparam): Adjust signature to match interface in tparam.h;
7946 this removes some undefined behavior. Check that outstring and len
7947 are zero, which they always are with Emacs.
7948 * tparam.h (PC, BC, UP): New extern decls.
7949
0248044d 7950 * xftfont.c (xftfont_shape): Now static, and defined only if needed.
001a7ab4 7951 (xftfont_open): Rename locals to avoid shadowing.
0248044d 7952
8ff096c1 7953 * ftfont.c (ftfont_resolve_generic_family): Fix pointer signedness.
a00924bb
PE
7954 (ftfont_otf_capability, ftfont_shape): Omit decls if not needed.
7955 (OTF_TAG_SYM): Omit macro if not needed.
e932860f 7956 (ftfont_list): Remove unused local.
49eaafba
PE
7957 (get_adstyle_property, ftfont_pattern_entity):
7958 (ftfont_lookup_cache, ftfont_open, ftfont_anchor_point):
7959 Rename locals to avoid shadowing.
8ff096c1 7960
e2be39f6
PE
7961 * xfont.c (xfont_list_family): Mark var as initialized.
7962
c9735e30
PE
7963 * xml.c (make_dom): Now static.
7964
8f5201ae
PE
7965 * composite.c (composition_compute_stop_pos): Rename local to
7966 avoid shadowing.
b246f932
PE
7967 (composition_reseat_it): Remove unused locals.
7968 (find_automatic_composition, composition_adjust_point): Likewise.
80e079b2 7969 (composition_update_it): Mark var as initialized.
11b61122
PE
7970 (find_automatic_composition): Mark vars as initialized,
7971 with a FIXME (Bug#8290).
8f5201ae 7972
760fbc2c
PE
7973 character.h: Rename locals to avoid shadowing.
7974 * character.h (PREV_CHAR_BOUNDARY, FETCH_STRING_CHAR_ADVANCE):
7975 (FETCH_STRING_CHAR_AS_MULTIBYTE_ADVANCE, FETCH_CHAR_ADVANCE):
7976 (FETCH_CHAR_ADVANCE_NO_CHECK, INC_POS, DEC_POS, BUF_INC_POS):
7977 (BUF_DEC_POS): Be more systematic about renaming local temporaries
7978 to avoid shadowing.
7979
ff08eb85
PE
7980 * textprop.c (property_change_between_p): Remove; unused.
7981
fc7bf025
PE
7982 * intervals.c (interval_start_pos): Now static.
7983
235d7abc
PE
7984 * intervals.h (CHECK_TOTAL_LENGTH): Avoid empty "else".
7985
44f230aa
SM
7986 * atimer.c (start_atimer, append_atimer_lists, set_alarm):
7987 Rename locals to avoid shadowing.
3e7d6594 7988
50060332
PE
7989 * sound.c (wav_play, au_play, Fplay_sound_internal):
7990 Fix pointer signedness.
d01f234b 7991 (alsa_choose_format): Remove unused local var.
c83b8872
PE
7992 (wav_play): Initialize a variable to 0, to prevent undefined
7993 behavior (Bug#8278).
50060332 7994
c4fc4e30
PE
7995 * region-cache.c (insert_cache_boundary): Redo var to avoid shadowing.
7996
918436ed
PE
7997 * region-cache.h (pp_cache): New decl, for gcc -Wmissing-prototypes.
7998
c939f91b
PE
7999 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork
8000 clobbering (Bug#8298).
b9c7f648
PE
8001 * sysdep.c (sys_subshell): Likewise.
8002 Previously, the sys_subshell 'volatile' was incorrectly IF_LINTted out.
7e9123a2 8003
6bd8c144
PE
8004 * lisp.h (child_setup): Now NO_RETURN unless DOS_NT.
8005 This should get cleaned up, so that child_setup has the
8006 same signature on all platforms.
8007
7710357c 8008 * callproc.c (call_process_cleanup): Now static.
cb1d0ef7 8009 (relocate_fd): Rename locals to avoid shadowing.
7710357c 8010
c59da222
CY
80112011-03-22 Chong Yidong <cyd@stupidchicken.com>
8012
8013 * xterm.c (x_clear_frame): Remove XClearWindow call. This appears
8014 not to be necessary, and produces flickering.
8015
66b87493
GM
80162011-03-20 Glenn Morris <rgm@gnu.org>
8017
8018 * config.in: Remove file.
8019
45b6f6d5
JB
80202011-03-20 Juanma Barranquero <lekktu@gmail.com>
8021
8022 * minibuf.c (Vcompleting_read_function): Don't declare, global variables
8023 are now in src/globals.h.
8024 (syms_of_minibuf): Remove spurious & from previous change.
8025
3ec03f7e
LL
80262011-03-20 Leo <sdl.web@gmail.com>
8027
8028 * minibuf.c (completing-read-function): New variable.
8029 (completing-read-default): Rename from completing-read.
8030 (completing-read): Call completing-read-function.
8031
b14e3e21
CY
80322011-03-19 Juanma Barranquero <lekktu@gmail.com>
8033
8034 * xfaces.c (Fx_load_color_file):
8035 Read color file from absolute filename (bug#8250).
8036
f2b726e6
JB
80372011-03-19 Juanma Barranquero <lekktu@gmail.com>
8038
8039 * makefile.w32-in: Update dependencies.
8040
09f6ff02
EZ
80412011-03-17 Eli Zaretskii <eliz@gnu.org>
8042
8043 * makefile.w32-in ($(BLD)/unexw32.$(O)): Depend on $(SRC)/unexec.h.
8044
29a6015a
PE
80452011-03-17 Paul Eggert <eggert@cs.ucla.edu>
8046
a3a6c54e
PE
8047 Fix more problems found by GCC 4.5.2's static checks.
8048
b766f867
PE
8049 * process.c (make_serial_process_unwind, send_process_trap):
8050 (sigchld_handler): Now static.
8051
be02381c
PE
8052 * process.c (allocate_pty): Let PTY_ITERATION declare iteration vars.
8053 That way, the code declares only the vars that it needs.
8054 * s/aix4-2.h (PTY_ITERATION): Declare iteration vars.
8055 * s/cygwin.h (PTY_ITERATION): Likewise.
8056 * s/darwin.h (PTY_ITERATION): Likewise.
8057 * s/gnu-linux.h (PTY_ITERATION): Likewise.
8058
57048744
PE
8059 * s/irix6-5.h (PTY_OPEN): Declare stb, to loosen coupling.
8060 * process.c (allocate_pty): Don't declare stb unless it's needed.
8061
7914961c 8062 * bytecode.c (MAYBE_GC): Rewrite so as not to use empty "else".
615f2d59
PE
8063 (CONSTANTLIM): Remove; unused.
8064 (METER_CODE, Bscan_buffer, Bread_char, Bset_mark):
8065 Define only if needed.
7914961c 8066
b3967b18
PE
8067 * unexelf.c (unexec): Name an expression,
8068 to avoid gcc -Wbad-function-cast warning.
9ae71512
PE
8069 Use a different way to cause a compilation error if anyone uses
8070 n rather than nn, a way that does not involve shadowing.
73366a00 8071 (ELF_BSS_SECTION_NAME, OLD_PROGRAM_H): Remove; unused.
b3967b18 8072
29a6015a
PE
8073 * deps.mk (unexalpha.o): Remove; unused.
8074
43cfc33e 8075 New file unexec.h, the (simple) interface for unexec (Bug#8267).
7feda0d2 8076 * unexec.h: New file.
ce701a33
PE
8077 * deps.mk (emacs.o, unexaix.o, unexcw.o, unexcoff.o, unexelf.o):
8078 (unexhp9k800.o, unexmacosx.o, unexsol.o, unexw32.o):
8079 Depend on unexec.h.
8080 * emacs.c [!defined CANNOT_DUMP]: Include unexec.h.
8081 * unexaix.c, unexcoff.c, unexcw.c, unexelf.c, unexhp9k800.c:
8082 * unexmacosx.c, unexsol.c, unexw32.c: Include unexec.h.
381259ef 8083 Change as necessary to match prototype in unexec.h.
ce701a33 8084
01f44d5a
PE
8085 * syntax.c (Fforward_comment, scan_lists): Rename locals to avoid
8086 shadowing.
4f63c6bb 8087 (back_comment, skip_chars): Mark vars as initialized.
01f44d5a 8088
a6670b0b
PE
8089 * character.h (FETCH_STRING_CHAR_ADVANCE_NO_CHECK, BUF_INC_POS):
8090 Rename locals to avoid shadowing.
8091
cef2010d 8092 * lread.c (read1): Rewrite so as not to use empty "else".
0902fe45 8093 (Fload, readevalloop, read1): Rename locals to avoid shadowing.
cef2010d 8094
d4d7173a
PE
8095 * print.c (Fredirect_debugging_output): Fix pointer signedess.
8096
f08b802a
PE
8097 * lisp.h (debug_output_compilation_hack): Add decl here, to avoid
8098 warning when compiling print.c.
8099
3ddb0639
PE
8100 * font.c (font_unparse_fcname): Abort in an "impossible" situation
8101 instead of using an uninitialized var.
5ad03b97 8102 (font_sort_entities): Mark var as initialized.
3ddb0639 8103
170a2692
PE
8104 * character.h (FETCH_CHAR_ADVANCE): Rename locals to avoid shadowing.
8105
e663c700
PE
8106 * font.c (font_unparse_xlfd): Don't mix pointers to variables with
8107 pointers to constants.
89bc529a 8108 (font_parse_fcname): Remove unused vars.
7b81e2d0 8109 (font_delete_unmatched): Now static.
ea838e10 8110 (font_get_spec): Remove; unused.
13a547c6
PE
8111 (font_style_to_value, font_prop_validate_style, font_unparse_fcname):
8112 (font_update_drivers, Ffont_get_glyphs, font_add_log):
8113 Rename or move locals to avoid shadowing.
e663c700 8114
2a80c887 8115 * fns.c (require_nesting_list, require_unwind): Now static.
612f56df 8116 (Ffillarray): Rename locals to avoid shadowing.
2a80c887 8117
1384fa33 8118 * floatfns.c (domain_error2): Define only if needed.
a885e2ed 8119 (Ffrexp, Fldexp): Rename locals to avoid shadowing.
1384fa33 8120
8b2c52e9
PE
8121 * alloc.c (mark_backtrace): Move decl from here ...
8122 * lisp.h: ... to here, so that it can be checked.
8123
475545b5 8124 * eval.c (call_debugger, do_debug_on_call, grow_specpdl): Now static.
d28a2170 8125 (Fdefvar): Rewrite so as not to use empty "else".
cfcbfb1a
PE
8126 (lisp_indirect_variable): Name an expression,
8127 to avoid gcc -Wbad-function-cast warning.
1faed8ae 8128 (Fdefvar): Rename locals to avoid shadowing.
475545b5 8129
b1349114 8130 * callint.c (quotify_arg, quotify_args): Now static.
a3e8cbda 8131 (Fcall_interactively): Rename locals to avoid shadowing.
b0e80955 8132 Use const pointer when appropriate.
b1349114 8133
a2928364
PE
8134 * lisp.h (get_system_name, get_operating_system_release):
8135 Move decls here, to check interfaces.
8136 * process.c (get_operating_system_release): Move decl to lisp.h.
8137 * xrdb.c (get_system_name): Likewise.
63c5d10b
PE
8138 * editfns.c (init_editfns, Fuser_login_name, Fuser_uid):
8139 (Fuser_real_uid, Fuser_full_name): Remove unnecessary casts,
8140 some of which prompt warnings from gcc -Wbad-function-cast.
545b49b4
PE
8141 (Fformat_time_string, Fencode_time, Finsert_char):
8142 (Ftranslate_region_internal, Fformat):
8143 Rename or remove local vars to avoid shadowing.
9710023e 8144 (Ftranslate_region_internal): Mark var as initialized.
63c5d10b 8145
a415e694
PE
8146 * doc.c (Fdocumentation, Fsnarf_documentation): Move locals to
8147 avoid shadowing.
8148
8ef4622d
PE
8149 * lisp.h (eassert): Check that the argument compiles, even if
8150 ENABLE_CHECKING is not defined.
8151
946f9a5b
PE
8152 * data.c (Findirect_variable): Name an expression, to avoid
8153 gcc -Wbad-function-cast warning.
112396d6 8154 (default_value, arithcompare, arith_driver, arith_error): Now static.
b9b84fa9 8155 (store_symval_forwarding): Rename local to avoid shadowing.
44f230aa
SM
8156 (Fmake_variable_buffer_local, Fmake_local_variable):
8157 Mark variables as initialized.
52746918 8158 (do_blv_forwarding, do_symval_forwarding): Remove; unused.
946f9a5b 8159
e5aab7e7 8160 * alloc.c (check_cons_list): Do not define unless GC_CHECK_CONS_LIST.
ae35e756
PE
8161 (Fmake_vector, Fvector, Fmake_byte_code, Fgarbage_collect):
8162 Rename locals to avoid shadowing.
dff45157
PE
8163 (mark_stack): Move local variables into the #ifdef region where
8164 they're used.
7bc26fdb
PE
8165 (BLOCK_INPUT_ALLOC, UNBLOCK_INPUT_ALLOC): Define only if
8166 ! defined SYSTEM_MALLOC && ! defined SYNC_INPUT, as they are not
8167 needed otherwise.
8168 (CHECK_ALLOCATED): Define only if GC_CHECK_MARKED_OBJECTS.
8169 (GC_STRING_CHARS): Remove; not used.
d40d4be1 8170 (Fmemory_limit): Cast sbrk's returned value to char *.
ae35e756 8171
e5aab7e7
PE
8172 * lisp.h (check_cons_list): Declare if GC_CHECK_CONS_LIST; this
8173 avoids undefined behavior in theory.
8174
4da60324
PE
8175 * regex.c (IF_LINT): Add defn, for benefit of ../lib-src.
8176
88043301
PE
8177 Use functions, not macros, for up- and down-casing (Bug#8254).
8178 * buffer.h (DOWNCASE_TABLE, UPCASE_TABLE, DOWNCASE, UPPERCASEP):
8179 (NOCASEP, LOWERCASEP, UPCASE, UPCASE1): Remove. All callers changed
8180 to use the following functions instead of these macros.
8181 (downcase): Adjust to lack of DOWNCASE_TABLE. Return int, not
8182 EMACS_INT, since callers assume the returned value fits in int.
8183 (upcase1): Likewise, for UPCASE_TABLE.
8184 (uppercasep, lowercasep, upcase): New static inline functions.
0da09c43 8185 * editfns.c (Fchar_equal): Remove no-longer-needed workaround for
db69b0cd 8186 the race-condition problem in the old DOWNCASE.
88043301 8187
19ed5445
PE
8188 * regex.c (CHARSET_LOOKUP_RANGE_TABLE_RAW, POP_FAILURE_REG_OR_COUNT):
8189 Rename locals to avoid shadowing.
8190 (regex_compile, re_match_2_internal): Move locals to avoid shadowing.
abbd1bcf
PE
8191 (regex_compile, re_search_2, re_match_2_internal):
8192 Remove unused local vars.
952db0d7
PE
8193 (FREE_VAR): Rewrite so as not to use empty "else",
8194 which gcc can warn about.
da053e48 8195 (regex_compile, re_match_2_internal): Mark locals as initialized.
b313f9d8
PE
8196 (RETALLOC_IF): Define only if needed.
8197 (WORDCHAR_P): Likewise. This one is never needed, but is used
8198 only in a comment talking about a compiler bug, so put inside
8199 the #if 0 of that comment.
8200 (CHARSET_LOOKUP_BITMAP, FAIL_STACK_FULL, RESET_FAIL_STACK):
8201 (PUSH_FAILURE_ELT, BUF_PUSH_3, STOP_ADDR_VSTRING):
8202 Remove; unused.
19ed5445 8203
1f3561e4 8204 * search.c (boyer_moore): Rename locals to avoid shadowing.
76ef09b7
PE
8205 * character.h (FETCH_STRING_CHAR_AS_MULTIBYTE_ADVANCE):
8206 (PREV_CHAR_BOUNDARY): Likewise.
1f3561e4 8207
ded6f8f7
PE
8208 * search.c (simple_search): Remove unused var.
8209
dbd37a95
PE
8210 * dired.c (compile_pattern): Move decl from here ...
8211 * lisp.h: ... to here, so that it can be checked.
8212 (struct re_registers): New forward decl.
8213
7e47afad
PE
8214 * character.h (INC_POS, DEC_POS): Rename locals to avoid shadowing.
8215
85f24f61
PE
8216 * indent.c (MULTIBYTE_BYTES_WIDTH): New args bytes, width.
8217 All uses changed.
8218 (MULTIBYTE_BYTES_WIDTH, scan_for_column, compute_motion):
8219 Rename locals to avoid shadowing.
5671df8f 8220 (Fvertical_motion): Mark locals as initialized.
85f24f61 8221
181aa2be 8222 * casefiddle.c (casify_object, casify_region): Now static.
e45a141a 8223 (casify_region): Mark local as initialized.
181aa2be 8224
930d429c
PE
8225 * cmds.c (internal_self_insert): Rename local to avoid shadowing.
8226
7082eac6
PE
8227 * lisp.h (GCPRO2_VAR, GCPRO3_VAR, GCPRO4_VAR, GCPRO5_VAR, GCPRO6_VAR):
8228 New macros, so that the caller can use some names other than
8229 gcpro1, gcpro2, etc.
8230 (GCPRO2, GCPRO3, GCPRO4, GCPRO5, GCPRO6): Reimplement in terms
8231 of the new macros.
8232 (GCPRO1_VAR, UNGCPRO_VAR): Change the meaning of the second
8233 argument, for consistency with GCPRO2_VAR, etc: it is now the
8234 prefix of the variable, not the variable itself. All uses
8235 changed.
38b2c076
PE
8236 * dired.c (directory_files_internal, file_name_completion):
8237 Rename locals to avoid shadowing.
8238
15206ed9
PE
8239 Fix a race condition diagnosed by gcc -Wsequence-point (Bug#8254).
8240 An expression of the form (DOWNCASE (x) == DOWNCASE (y)), found in
8241 dired.c's scmp function, had undefined behavior.
8242 * lisp.h (DOWNCASE_TABLE, UPCASE_TABLE, DOWNCASE, UPPERCASEP):
8243 (NOCASEP, LOWERCASEP, UPCASE, UPCASE1): Move from here ...
8244 * buffer.h: ... to here, because these macros use current_buffer,
8245 and the new implementation with inline functions needs to have
8246 current_buffer in scope now, rather than later when the macros
8247 are used.
8248 (downcase, upcase1): New static inline functions.
8249 (DOWNCASE, UPCASE1): Reimplement using these functions.
8250 This avoids undefined behavior in expressions like
8251 DOWNCASE (x) == DOWNCASE (y), which previously suffered
8252 from race conditions in accessing the global variables
8253 case_temp1 and case_temp2.
8254 * casetab.c (case_temp1, case_temp2): Remove; no longer needed.
8255 * lisp.h (case_temp1, case_temp2): Remove their decls.
8256 * character.h (ASCII_CHAR_P): Move from here ...
8257 * lisp.h: ... to here, so that the inline functions mentioned
8258 above can use them.
8259
4a6bea26
PE
8260 * dired.c (directory_files_internal_unwind): Now static.
8261
f14b7e14
PE
8262 * fileio.c (file_name_as_directory, directory_file_name):
8263 (barf_or_query_if_file_exists, auto_save_error, auto_save_1):
8264 Now static.
2893f146
PE
8265 (file_name_as_directory): Use const pointers when appropriate.
8266 (Fexpand_file_name): Likewise. In particular, newdir might
8267 point at constant storage, so make it a const pointer.
fd4ead52 8268 (Fmake_directory_internal, Fread_file_name): Remove unused vars.
b14aac08
PE
8269 (Ffile_selinux_context, Fset_file_selinux_context): Fix pointer
8270 signedness issues.
f839df0c
PE
8271 (Fset_file_times, Finsert_file_contents, auto_save_error):
8272 Rename locals to avoid shadowing.
f14b7e14 8273
5716756e 8274 * minibuf.c (choose_minibuf_frame_1): Now static.
62137a95
PE
8275 (Ftry_completion, Fall_completions): Rename or remove locals
8276 to avoid shadowing.
5716756e 8277
b4c3046a
PE
8278 * marker.c (bytepos_to_charpos): Remove; unused.
8279
b45db522
PE
8280 * lisp.h (verify_bytepos, count_markers): New decls,
8281 so that gcc does not warn that these functions aren't declared.
8282
85876d07
PE
8283 * insdel.c (check_markers, make_gap_larger, make_gap_smaller):
8284 (reset_var_on_error, Fcombine_after_change_execute_1): Now static.
f0cb4a60 8285 (CHECK_MARKERS): Redo to avoid gcc -Wempty-body diagnostic.
40ef059e 8286 (copy_text): Remove unused local var.
85876d07 8287
03d78a21 8288 * filelock.c (within_one_second): Now static.
b3dd38ab 8289 (lock_file_1): Rename local to avoid shadowing.
03d78a21 8290
5df8f01b
PE
8291 * buffer.c (fix_overlays_before): Mark locals as initialized.
8292 (fix_start_end_in_overlays): Likewise. This function should be
8293 simplified by using pointers-to-pointers, but that's a different
8294 matter.
b1d876f1 8295 (switch_to_buffer_1): Now static.
8f54f30a
PE
8296 (Fkill_buffer, record_buffer, Fbury_buffer, Fset_buffer_multibyte):
8297 (report_overlay_modification): Rename locals to avoid shadowing.
c3bd59b5 8298
a70072c9 8299 * sysdep.c (system_process_attributes): Rename vars to avoid shadowing.
fbd02d7b 8300 Fix pointer signedness issue.
edced198
PE
8301 (sys_subshell): Mark local as volatile if checking for lint,
8302 to suppress a gcc -Wclobbered warning that does not seem to be right.
15dfd3d9 8303 (MAXPATHLEN): Define only if needed.
a70072c9 8304
a0977c44
PE
8305 * process.c (serial_open, serial_configure): Move decls from here ...
8306 * systty.h: ... to here, so that they can be checked.
8307
a884fdcc
PE
8308 * fns.c (get_random, seed_random): Move extern decls from here ...
8309 * lisp.h: ... to here, so that they can be checked.
8310
604efe86 8311 * sysdep.c (reset_io): Now static.
b8950c94 8312 (wait_for_termination_signal): Remove; unused.
604efe86 8313
38fc62d9
PE
8314 * keymap.c (keymap_parent, keymap_memberp, map_keymap_internal):
8315 (copy_keymap_item, append_key, push_text_char_description):
8316 Now static.
1004a21a 8317 (Fwhere_is_internal): Don't test CONSP (sequences) unnecessarily.
dbbb8427 8318 (DENSE_TABLE_SIZE): Remove; unused.
c1141155
PE
8319 (get_keymap, access_keymap, Fdefine_key, Fwhere_is_internal):
8320 (describe_map_tree):
8321 Rename locals to avoid shadowing.
38fc62d9 8322
2f2650da
PE
8323 * keyboard.c: Declare functions static if they are not used elsewhere.
8324 (echo_char, echo_dash, cmd_error, top_level_2):
8325 (poll_for_input, handle_async_input): Now static.
69a058fa
PE
8326 (read_char, kbd_buffer_get_event, make_lispy_position):
8327 (make_lispy_event, make_lispy_movement, apply_modifiers):
8328 (decode_keyboard_code, tty_read_avail_input, menu_bar_items):
8329 (parse_tool_bar_item, read_key_sequence, Fread_key_sequence):
8330 (Fread_key_sequence_vector): Rename locals to avoid shadowing.
c8a06054 8331 (read_key_sequence, read_char): Mark locals as initialized.
3ac94672 8332 (Fexit_recursive_edit, Fabort_recursive_edit): Mark with NO_RETURN.
2f2650da 8333
a053e86c 8334 * keyboard.h (make_ctrl_char): New decl.
da2f2dd9
PE
8335 (mark_kboards): Move decl here ...
8336 * alloc.c (mark_kboards): ... from here.
a053e86c 8337
4752793e
PE
8338 * lisp.h (force_auto_save_soon): New decl.
8339
74f10ca7 8340 * emacs.c (init_cmdargs): Rename local to avoid shadowing.
244fc23d
PE
8341 (DEFINE_DUMMY_FUNCTION): New macro.
8342 (__do_global_ctors, __do_global_ctors_aux, __do_global_dtors, __main):
8343 Use it.
c03cd23f
PE
8344 (main): Add casts to avoid warnings
8345 if GCC considers string literals to be constants.
74f10ca7 8346
022e70d4
PE
8347 * lisp.h (fatal_error_signal): Add decl, since it's exported.
8348
59d6fe83
PE
8349 * dbusbind.c: Pointer signedness fixes.
8350 (xd_signature, xd_append_arg, xd_initialize):
8351 (Fdbus_call_method, Fdbus_call_method_asynchronously):
8352 (Fdbus_method_return_internal, Fdbus_method_error_internal):
8353 (Fdbus_send_signal, xd_read_message_1, Fdbus_register_service):
8354 (Fdbus_register_signal): Use SSDATA when the context wants char *.
8355
78320123
PE
8356 * dbusbind.c (Fdbus_init_bus): Add cast to avoid warning
8357 if GCC considers string literals to be constants.
49cebcca 8358 (Fdbus_register_service, Fdbus_register_method): Remove unused vars.
78320123 8359
35ac2a97
SM
83602011-03-16 Stefan Monnier <monnier@iro.umontreal.ca>
8361
fb103ca9
SM
8362 * print.c (PRINT_CIRCLE_CANDIDATE_P): New macro.
8363 (print_preprocess, print_object): New macro to fix last change.
8364
35ac2a97
SM
8365 * print.c (print_preprocess): Don't forget font objects.
8366
62973b41
JB
83672011-03-16 Juanma Barranquero <lekktu@gmail.com>
8368
8369 * emacs.c (USAGE3): Doc fixes.
8370
0e48bb22
AS
83712011-03-15 Andreas Schwab <schwab@linux-m68k.org>
8372
8373 * coding.c (detect_coding_iso_2022): Reorganize code to clarify
8374 structure.
8375
7684e57b
JB
83762011-03-14 Juanma Barranquero <lekktu@gmail.com>
8377
8378 * lisp.h (VWindow_system, Qfile_name_history):
8379 * keyboard.h (lispy_function_keys) [WINDOWSNT]:
8380 * w32term.h (w32_system_caret_hwnd, w32_system_caret_height)
8381 (w32_system_caret_x, w32_system_caret_y): Declare extern.
8382
8383 * w32select.c: Don't #include "keyboard.h".
c96bbc66 8384 (run_protected): Add extern declaration for waiting_for_input.
7684e57b
JB
8385
8386 * w32.c (Qlocal, noninteractive1, inhibit_window_system):
8387 * w32console.c (detect_input_pending, read_input_pending)
8388 (encode_terminal_code):
8389 * w32fns.c (quit_char, lispy_function_keys, Qtooltip)
8390 (w32_system_caret_hwnd, w32_system_caret_height, w32_system_caret_x)
8391 (w32_system_caret_y, Qfile_name_history):
8392 * w32font.c (w32font_driver, QCantialias, QCotf, QClang):
8393 * w32inevt.c (reinvoke_input_signal, lispy_function_keys):
8394 * w32menu.c (Qmenu_bar, QCtoggle, QCradio, Qoverriding_local_map)
8395 (Qoverriding_terminal_local_map, Qmenu_bar_update_hook):
8396 * w32proc.c (Qlocal, report_file_error):
8397 * w32term.c (Vwindow_system, updating_frame):
8398 * w32uniscribe.c (initialized, uniscribe_font_driver):
8399 Remove unneeded extern declarations.
8400
2aa46d6c
CY
84012011-03-14 Chong Yidong <cyd@stupidchicken.com>
8402
c96bbc66 8403 * buffer.c (Fmake_indirect_buffer): Fix incorrect assertions.
2aa46d6c 8404
cffc6f3b
CY
84052011-03-13 Chong Yidong <cyd@stupidchicken.com>
8406
8407 * buffer.h (BUF_BEGV, BUF_BEGV_BYTE, BUF_ZV, BUF_ZV_BYTE, BUF_PT)
8408 (BUF_PT_BYTE): Rewrite to handle indirect buffers (Bug#8219).
8409 These macros can no longer be used for assignment.
8410
44f230aa
SM
8411 * buffer.c (Fget_buffer_create, Fmake_indirect_buffer):
8412 Assign struct members directly, instead of using BUF_BEGV etc.
cffc6f3b
CY
8413 (record_buffer_markers, fetch_buffer_markers): New functions for
8414 recording and fetching special buffer markers.
8415 (set_buffer_internal_1, set_buffer_temp): Use them.
8416
8417 * lread.c (unreadchar): Use SET_BUF_PT_BOTH.
8418
8419 * insdel.c (adjust_point): Use SET_BUF_PT_BOTH.
8420
8421 * intervals.c (temp_set_point_both): Use SET_BUF_PT_BOTH.
8422 (get_local_map): Use SET_BUF_BEGV_BOTH and SET_BUF_ZV_BOTH.
8423
8424 * xdisp.c (hscroll_window_tree):
8425 (reconsider_clip_changes): Use PT instead of BUF_PT.
8426
d251f04b
EZ
84272011-03-13 Eli Zaretskii <eliz@gnu.org>
8428
8429 * makefile.w32-in ($(BLD)/editfns.$(O)): Depend on
8430 $(EMACS_ROOT)/lib/intprops.h.
8431
f0c77cd1
PE
84322011-03-13 Paul Eggert <eggert@cs.ucla.edu>
8433
3eca4629
PE
8434 Fix more problems found by GCC 4.5.2's static checks.
8435
7c86ee98
PE
8436 * gtkutil.c (xg_get_pixbuf_from_pixmap): Add cast from char *
8437 to unsigned char * to avoid compiler diagnostic.
b0afc268
PE
8438 (xg_free_frame_widgets): Make it clear that a local variable is
8439 needed only if USE_GTK_TOOLTIP.
01e0b5ad
PE
8440 (gdk_window_get_screen): Make it clear that this macro is needed
8441 only if USE_GTK_TOOLTIP.
1e5524e7
PE
8442 (int_gtk_range_get_value): New function, which avoids a diagnostic
8443 from gcc -Wbad-function-cast.
8444 (xg_set_toolkit_scroll_bar_thumb): Use it.
8445 (xg_tool_bar_callback, xg_tool_item_stale_p): Rewrite to avoid
8446 diagnostic from gcc -Wbad-function-cast.
65dc836c
PE
8447 (get_utf8_string, xg_get_file_with_chooser):
8448 Rename locals to avoid shadowing.
8449 (create_dialog): Move locals to avoid shadowing.
7c86ee98 8450
41729b81
PE
8451 * xgselect.c (xg_select): Remove unused var.
8452
f0c77cd1
PE
8453 * image.c (four_corners_best): Mark locals as initialized.
8454 (gif_load): Initialize transparent_p to zero (Bug#8238).
8455 Mark another local as initialized.
ec6cf4c6 8456 (my_png_error, my_error_exit): Mark with NO_RETURN.
f0c77cd1 8457
ce0ad53d 8458 * image.c (clear_image_cache): Now static.
d5d5a617 8459 (DIM, HAVE_STDLIB_H_1): Remove unused macros.
e22cffbc 8460 (xpm_load): Redo to avoid "discards qualifiers" gcc warning.
77a765fd
PE
8461 (x_edge_detection): Remove unnecessary cast that
8462 gcc -Wbad-function-cast diagnoses.
2037898d 8463 (gif_load): Fix pointer signedness.
6ae141d6
PE
8464 (clear_image_cache, xbm_read_bitmap_data, x_detect_edges):
8465 (jpeg_load, gif_load): Rename locals to avoid shadowing.
ce0ad53d 8466
33383987 84672011-03-12 Paul Eggert <eggert@cs.ucla.edu>
3eca4629 8468
d32df629
PE
8469 Improve quality of tests for time stamp overflow.
8470 For example, without this patch (encode-time 0 0 0 1 1
8471 1152921504606846976) returns the obviously-bogus value (-948597
8472 62170) on my RHEL 5.5 x86-64 host. With the patch, it correctly
8473 reports time overflow. See
8474 <http://lists.gnu.org/archive/html/emacs-devel/2011-03/msg00470.html>.
b8d9bd41
PE
8475 * deps.mk (editfns.o): Depend on ../lib/intprops.h.
8476 * editfns.c: Include limits.h and intprops.h.
8477 (TIME_T_MIN, TIME_T_MAX): New macros.
8478 (time_overflow): Move earlier, to before first use.
8479 (hi_time, lo_time): New functions, for an accurate test for
8480 out-of-range times.
8481 (Fcurrent_time, Fget_internal_run_time, make_time): Use them.
8482 (Fget_internal_run_time): Don't assume time_t fits in int.
8483 (make_time): Use list2 instead of Fcons twice.
8484 (Fdecode_time): More accurate test for out-of-range times.
8485 (check_tm_member): New function.
8486 (Fencode_time): Use it, to test for out-of-range times.
d32df629
PE
8487 (lisp_time_argument): Don't rely on undefined left-shift and
8488 right-shift behavior when checking for time stamp overflow.
8be6f318 8489
fe31d94c
PE
8490 * editfns.c (time_overflow): New function, refactoring common code.
8491 (Fformat_time_string, Fdecode_time, Fencode_time):
8492 (Fcurrent_time_string): Use it.
8493
8be6f318
PE
8494 Move 'make_time' to be next to its inverse 'lisp_time_argument'.
8495 * dired.c (make_time): Move to ...
8496 * editfns.c (make_time): ... here.
8497 * systime.h: Note the move.
8498
09d9db2c 84992011-03-12 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
c47cbdfd 8500
126bc0dc
YM
8501 * fringe.c (update_window_fringes): Remove unused variables.
8502
c47cbdfd
YM
8503 * unexmacosx.c (copy_data_segment): Also copy __got section.
8504 (Bug#8223)
8505
7ac80be9
EZ
85062011-03-12 Eli Zaretskii <eliz@gnu.org>
8507
c96bbc66 8508 * termcap.c [MSDOS]: Include "msdos.h".
058e5dad
EZ
8509 (find_capability, tgetnum, tgetflag, tgetstr, tputs, tgetent):
8510 Constify `char *' arguments and their references according to
8511 prototypes in tparam.h.
8512
ecb0f94d 8513 * deps.mk (termcap.o): Depend on tparam.h and msdos.h.
058e5dad 8514
7ac80be9
EZ
8515 * msdos.c (XMenuAddPane): 3rd argument is `const char *' now.
8516 Adapt all references accordingly.
8517
8518 * msdos.h (XMenuAddPane): 3rd argument is `const char *' now.
8519
ef1fd07e
TT
85202011-03-11 Tom Tromey <tromey@redhat.com>
8521
8522 * buffer.c (syms_of_buffer): Remove obsolete comment.
8523
7ef4b50c
EZ
85242011-03-11 Eli Zaretskii <eliz@gnu.org>
8525
8526 * termhooks.h (encode_terminal_code): Declare prototype.
8527
8528 * msdos.c (encode_terminal_code): Don't declare prototype.
8529
8530 * term.c (encode_terminal_code): Now external again, used by
8531 w32console.c and msdos.c.
8532
44f230aa
SM
8533 * makefile.w32-in ($(BLD)/term.$(O), ($(BLD)/tparam.$(O)):
8534 Depend on $(SRC)/tparam.h, see 2011-03-11T07:24:21Z!eggert@cs.ucla.edu.
7ef4b50c 8535
4b1ec863 85362011-03-11 Paul Eggert <eggert@cs.ucla.edu>
f78faa98 8537
1714f52b 8538 Fix some minor problems found by GCC 4.5.2's static checks.
83316bf4 8539
4b1ec863
PE
8540 * fringe.c (update_window_fringes): Mark locals as initialized
8541 (Bug#8227).
8542 (destroy_fringe_bitmap, init_fringe_bitmap): Now static.
bf60f616 8543
524c7aa6
PE
8544 * alloc.c (mark_fringe_data): Move decl from here ...
8545 * lisp.h (mark_fringe_data) [HAVE_WINDOW_SYSTEM]: ... to here,
8546 to check its interface.
8547 (init_fringe_once): Do not declare unless HAVE_WINDOW_SYSTEM.
8548
a5c0af81 8549 * fontset.c (free_realized_fontset): Now static.
7519b8cd 8550 (Fset_fontset_font): Rename local to avoid shadowing.
cc6e5db1 8551 (fontset_font): Mark local as initialized.
a9a06e0b 8552 (FONTSET_SPEC, FONTSET_REPERTORY, RFONT_DEF_REPERTORY): Remove; unused.
a5c0af81 8553
b4716021
PE
8554 * xrdb.c: Include "xterm.h", to check x_load_resources's interface.
8555
811e9bac 8556 * xselect.c (x_disown_buffer_selections): Remove; not used.
7b83e2f1 8557 (TRACE3) [!defined TRACE_SELECTION]: Remove; not used.
aa0daa9f
PE
8558 (x_own_selection, Fx_disown_selection_internal): Rename locals
8559 to avoid shadowing.
8560 (x_handle_dnd_message): Remove local to avoid shadowing.
811e9bac 8561
7e3ab302
PE
8562 * lisp.h (GCPRO1_VAR, UNGCPRO_VAR): New macros,
8563 so that the caller can use some name other than gcpro1.
8564 (GCPRO1, UNGCPRO): Reimplement in terms of the new macros.
58d2d479
PE
8565 * xfns.c (Fx_create_frame, x_create_tip_frame, Fx_show_tip):
8566 (Fx_backspace_delete_keys_p):
8567 Use them to avoid shadowing, and rename vars to avoid shadowing.
8568 (x_decode_color, x_set_name, x_window): Now static.
6b437900 8569 (Fx_create_frame): Add braces to silence GCC warning.
c0951e53 8570 (Fx_file_dialog, Fx_select_font): Fix pointer signedness.
06b0c8a0
PE
8571 (x_real_positions, xg_set_icon_from_xpm_data, x_create_tip_frame):
8572 Remove unused locals.
7e3ab302
PE
8573 (Fx_create_frame, x_create_tip_frame, Fx_show_tip):
8574 (Fx_backspace_delete_keys_p): Rename locals to avoid shadowing.
8575 Some of these renamings use the new GCPRO1_VAR and UNGCPRO_VAR
8576 macros.
f78faa98 8577
e2b13473
PE
8578 * xterm.h (x_mouse_leave): New decl.
8579
77f23912
PE
8580 * xterm.c (x_copy_dpy_color, x_focus_on_frame, x_unfocus_frame):
8581 Remove unused functions.
cdf4ba58
PE
8582 (x_shift_glyphs_for_insert, XTflash, XTring_bell):
8583 (x_calc_absolute_position): Now static.
7411c686 8584 (XTread_socket): Don't define label "out" unless it's used.
2b07bcff 8585 Don't declare local "event" unless it's used.
ed7bf3a5
PE
8586 (x_iconify_frame, x_free_frame_resources): Don't declare locals
8587 unless they are used.
38d0b34a
PE
8588 (XEMBED_VERSION, xembed_set_info): Don't define unless needed.
8589 (x_fatal_error_signal): Remove; not used.
a6067996
PE
8590 (x_draw_image_foreground, redo_mouse_highlight, XTmouse_position):
8591 (x_scroll_bar_report_motion, handle_one_xevent, x_draw_bar_cursor):
8592 (x_error_catcher, x_connection_closed, x_error_handler):
8593 (x_error_quitter, xembed_send_message, x_iconify_frame):
8594 (my_log_handler): Rename locals to avoid shadowing.
28f1c698 8595 (x_delete_glyphs, x_ins_del_lines): Mark with NO_RETURN.
2a8fade0 8596 (x_connection_closed): Tell GCC not to suggest NO_RETURN.
77f23912 8597
44f230aa
SM
8598 * xfaces.c (clear_face_cache, Fx_list_fonts, Fface_font):
8599 Rename or move locals to avoid shadowing.
6b463e58 8600 (tty_defined_color, merge_face_heights): Now static.
5967d051 8601 (free_realized_faces_for_fontset): Remove; not used.
1e9966ea
PE
8602 (Fx_list_fonts): Mark variable that gcc -Wuninitialized
8603 does not deduce is never used uninitialized.
73719eba
PE
8604 (STRDUPA, LSTRDUPA, FONT_POINT_SIZE_QUANTUM): Remove; not used.
8605 (LFACEP): Define only if XASSERTS, as it's not needed otherwise.
071048a3 8606
426994c3 8607 * terminal.c (store_terminal_param): Now static.
5489860b 8608
032f1620 8609 * xmenu.c (menu_highlight_callback): Now static.
9d66f88e 8610 (set_frame_menubar): Remove unused local.
d4323972 8611 (xmenu_show): Rename parameter to avoid shadowing.
6d1f7fee
PE
8612 (xmenu_show, xdialog_show, xmenu_show): Make local pointers "const"
8613 since they might point to immutable storage.
281585b0
PE
8614 (next_menubar_widget_id): Declare only if USE_X_TOOLKIT,
8615 since it's unused otherwise.
032f1620 8616
367c19e5 8617 * xdisp.c (produce_glyphless_glyph): Initialize lower_xoff.
53df7c11 8618 Add a FIXME, since the code still doesn't look right. (Bug#8215)
9f36b9fd
PE
8619 (Fcurrent_bidi_paragraph_direction): Simplify slightly; this
8620 avoids a gcc -Wuninitialized diagnostic.
0e086e8f 8621 (display_line, BUILD_COMPOSITE_GLYPH_STRING, draw_glyphs):
44a3a108
PE
8622 (note_mouse_highlight): Mark variables that gcc -Wuninitialized
8623 does not deduce are never used uninitialized.
70739cbe 8624
07b48fa9
PE
8625 * lisp.h (IF_LINT): New macro, copied from ../lib-src/emacsclient.c.
8626
8868a238 8627 * xdisp.c (redisplay_window): Rename local to avoid shadowing.
4554d213
PE
8628 * window.c (window_loop, size_window):
8629 (run_window_configuration_change_hook, enlarge_window): Likewise.
8868a238 8630
7e5cf297 8631 * window.c (display_buffer): Now static.
d6550a9f
PE
8632 (size_window): Mark variables that gcc -Wuninitialized
8633 does not deduce are never used uninitialized.
a586633d
PE
8634 * window.h (check_all_windows): New decl, to forestall
8635 gcc -Wmissing-prototypes diagnostic.
5b555da1 8636 * dispextern.h (bidi_dump_cached_states): Likewise.
7e5cf297 8637
f6095868
PE
8638 * charset.h (CHECK_CHARSET_GET_CHARSET): Rename locals to avoid
8639 shadowing.
8640 * charset.c (map_charset_for_dump, Fchar_charset): Likewise.
726929c4
PE
8641 Include <limits.h>.
8642 (Fsort_charsets): Redo min/max calculation to shorten the code a bit
8643 and to avoid gcc -Wuninitialized warning.
89ef49df
PE
8644 (load_charset_map): Mark variables that gcc -Wuninitialized
8645 does not deduce are never used uninitialized.
53df7c11 8646 (load_charset): Abort instead of using uninitialized var (Bug#8229).
f6095868 8647
f38b440c
PE
8648 * coding.c (coding_set_source, coding_set_destination):
8649 Use "else { /* comment */ }" rather than "else /* comment */;"
8650 for clarity, and to avoid gcc -Wempty-body warning.
2735d060
PE
8651 (Fdefine_coding_system_internal): Don't redeclare 'i' inside
8652 a block, when the outer 'i' will do.
8653 (decode_coding_utf_8, decode_coding_utf_16, detect_coding_emacs_mule):
8654 (emacs_mule_char, decode_coding_emacs_mule, detect_coding_iso_2022):
8655 (decode_coding_iso_2022, decode_coding_sjis, decode_coding_big5):
8656 (decode_coding_raw_text, decode_coding_charset, get_translation_table):
8657 (Fdecode_sjis_char, Fdefine_coding_system_internal):
8658 Rename locals to avoid shadowing.
8659 * character.h (FETCH_STRING_CHAR_ADVANCE): Likewise.
e2f1bab9
PE
8660 * coding.c (emacs_mule_char, encode_invocation_designation):
8661 Now static, since they're not used elsewhere.
413bb2db 8662 (decode_coding_iso_2022): Add "default: abort ();" as a safety check.
c4a63b12 8663 (decode_coding_object, encode_coding_object, detect_coding_system):
ee05f961
PE
8664 (decode_coding_emacs_mule): Mark variables that gcc
8665 -Wuninitialized does not deduce are never used uninitialized.
160b01f6
PE
8666 (detect_coding_iso_2022): Initialize a local variable that might
8667 be used uninitialized. Leave a FIXME because it's not clear that
53df7c11 8668 this initialization is needed. (Bug#8211)
5f58e762
PE
8669 (ISO_CODE_LF, ISO_CODE_CR, CODING_ISO_FLAG_EUC_TW_SHIFT):
8670 (ONE_MORE_BYTE_NO_CHECK, UTF_BOM, UTF_16_INVALID_P):
8671 (SHIFT_OUT_OK, ENCODE_CONTROL_SEQUENCE_INTRODUCER):
8672 (ENCODE_DIRECTION_R2L, ENCODE_DIRECTION_L2R):
8673 Remove unused macros.
f38b440c 8674
232b38b9 8675 * category.c (hash_get_category_set): Remove unused local var.
9f3b5e69 8676 (copy_category_table): Now static, since it's not used elsewhere.
d0891610 8677 * character.c (string_count_byte8): Likewise.
232b38b9 8678
fb90da1b
PE
8679 * ccl.c (CCL_WRITE_STRING, CCL_ENCODE_CHAR, Fccl_execute_on_string):
8680 (Fregister_code_conversion_map): Rename locals to avoid shadowing.
8681
fb93dbc2
PE
8682 * chartab.c (copy_sub_char_table): Now static, since it's not used
8683 elsewhere.
5c156ace
PE
8684 (sub_char_table_ref_and_range, char_table_ref_and_range):
8685 Rename locals to avoid shadowing.
bbcd0949 8686 (ASET_RANGE, GET_SUB_CHAR_TABLE): Remove unused macros.
fb93dbc2 8687
7d3b3862 8688 * bidi.c (bidi_check_type): Now static, since it's not used elsewhere.
630d6892 8689 (BIDI_BOB): Remove unused macro.
7d3b3862 8690
6be7d3da
PE
8691 * cm.c (cmgoto): Mark variables that gcc -Wuninitialized does not
8692 deduce are never used uninitialized.
c2ed9c8b 8693 * term.c (encode_terminal_code): Likewise.
6be7d3da 8694
75f8807f 8695 * term.c (encode_terminal_code): Now static. Remove unused local.
72abad34 8696
50938595
PE
8697 * tparam.h: New file.
8698 * term.c, tparam.h: Include it.
8699 * deps.mk (term.o, tparam.o): Depend on tparam.h.
8700 * term.c (tputs, tgetent, tgetflag, tgetnum, tparam, tgetstr):
8701 Move these decls to tparam.h, and make them agree with what
8702 is actually in tparam.c. The previous trick of using incompatible
8703 decls in different modules does not conform to the C standard.
8704 All callers of tparam changed to use tparam's actual API.
8705 * tparam.c (tparam1, tparam, tgoto):
8706 Use const pointers where appropriate.
8707
fbceeba2
PE
8708 * cm.c (calccost, cmgoto): Use const pointers where appropriate.
8709 * cm.h (struct cm): Likewise.
8710 * dispextern.h (do_line_insertion_deletion_costs): Likewise.
8711 * scroll.c (ins_del_costs, do_line_insertion_deletion_costs): Likewise.
8712 * term.c (tty_ins_del_lines, calculate_costs, struct fkey_table):
8713 (term_get_fkeys_1, append_glyphless_glyph, produce_glyphless_glyph):
8714 (turn_on_face, init_tty): Likewise.
8715 * termchar.h (struct tty_display_info): Likewise.
fbceeba2 8716
7f3f1250
PE
8717 * term.c (term_mouse_position): Rename local to avoid shadowing.
8718
e6ca6543
PE
8719 * alloc.c (mark_ttys): Move decl from here ...
8720 * lisp.h (mark_ttys): ... to here, so that it's checked against defn.
8721
c40f8d15
AS
87222011-03-11 Andreas Schwab <schwab@linux-m68k.org>
8723
8724 * .gdbinit (pwinx, xbuffer): Fix access to buffer name.
8725
cfe0661d
JB
87262011-03-09 Juanma Barranquero <lekktu@gmail.com>
8727
8728 * search.c (compile_pattern_1): Remove argument regp, unused since
8729 revid:rms@gnu.org-19941211082627-3x1g1wyqkjmwloig.
8730 (compile_pattern): Don't pass it.
8731
0afb4571
J
87322011-03-08 Jan Djärv <jan.h.d@swipnet.se>
8733
8734 * xterm.h (DEFAULT_GDK_DISPLAY): New define.
8735 (GDK_WINDOW_XID, gtk_widget_get_preferred_size): New defines
8736 for ! HAVE_GTK3.
8737 (GTK_WIDGET_TO_X_WIN): Use GDK_WINDOW_XID.
8738
8739 * xmenu.c (menu_position_func): Call gtk_widget_get_preferred_size.
8740
8741 * gtkutil.c: Include gtkx.h if HAVE_GTK3. If ! HAVE_GTK3, define
8742 gdk_window_get_screen, gdk_window_get_geometry,
8743 gdk_x11_window_lookup_for_display and GDK_KEY_g.
8744 (xg_set_screen): Use DEFAULT_GDK_DISPLAY.
8745 (xg_get_pixbuf_from_pixmap): New function.
8746 (xg_get_pixbuf_from_pix_and_mask): Change parameters from GdkPixmap
8747 to Pixmap, take frame as parameter, remove GdkColormap parameter.
8748 Call xg_get_pixbuf_from_pixmap instead of
8749 gdk_pixbuf_get_from_drawable.
8750 (xg_get_image_for_pixmap): Do not make GdkPixmaps, call
8751 xg_get_pixbuf_from_pix_and_mask with Pixmap parameters instead.
8752 (xg_check_special_colors): Use GtkStyleContext and its functions
8753 for HAVE_GTK3.
8754 (xg_prepare_tooltip, xg_hide_tooltip): Call gdk_window_get_screen.
8755 (xg_prepare_tooltip, create_dialog, menubar_map_cb)
8756 (xg_update_frame_menubar, xg_tool_bar_detach_callback)
44f230aa
SM
8757 (xg_tool_bar_attach_callback, xg_update_tool_bar_sizes):
8758 Call gtk_widget_get_preferred_size.
0afb4571
J
8759 (xg_frame_resized): gdk_window_get_geometry only takes 5
8760 parameters.
44f230aa
SM
8761 (xg_win_to_widget, xg_event_is_for_menubar):
8762 Call gdk_x11_window_lookup_for_display.
0afb4571
J
8763 (xg_set_widget_bg): New function.
8764 (delete_cb): New function.
895009e1 8765 (xg_create_frame_widgets): Connect delete-event to delete_cb.
0afb4571
J
8766 Call xg_set_widget_bg. Only set backgrund pixmap for ! HAVE_GTK3
8767 (xg_set_background_color): Call xg_set_widget_bg.
8768 (xg_set_frame_icon): Call xg_get_pixbuf_from_pix_and_mask.
8769 (xg_create_scroll_bar): vadj is a GtkAdjustment for HAVE_GTK3.
8770 Only call gtk_range_set_update_policy if ! HAVE_GTK3.
8771 (xg_make_tool_item): Only connect xg_tool_bar_item_expose_callback
8772 if ! HAVE_GTK3.
8773 (update_frame_tool_bar): Call gtk_widget_hide.
8774 (xg_initialize): Use GDK_KEY_g.
8775
8776 * xsmfns.c (gdk_set_sm_client_id): Define to gdk_set_sm_client_id
8777 if ! HAVE_GTK3
8778 (x_session_initialize): Call gdk_x11_set_sm_client_id.
8779
8780 * xterm.c (XFillRectangle): Use cairo routines for HAVE_GTK3.
8781 (x_term_init): Disable Xinput(2) with GDK_CORE_DEVICE_EVENTS.
8782 Load ~/emacs.d/gtkrc only for ! HAVE_GTK3.
8783
1c2cc4ef
JB
87842011-03-08 Juanma Barranquero <lekktu@gmail.com>
8785
8786 * w32xfns.c (select_palette): Check success of RealizePalette against
8787 GDI_ERROR, not zero.
8788
33383987 8789See ChangeLog.11 for earlier changes.
aac0c6e3
MR
8790
8791;; Local Variables:
8792;; coding: utf-8
aac0c6e3
MR
8793;; End:
8794
33383987 8795 Copyright (C) 2011 Free Software Foundation, Inc.
aac0c6e3
MR
8796
8797 This file is part of GNU Emacs.
8798
8799 GNU Emacs is free software: you can redistribute it and/or modify
8800 it under the terms of the GNU General Public License as published by
8801 the Free Software Foundation, either version 3 of the License, or
8802 (at your option) any later version.
8803
8804 GNU Emacs is distributed in the hope that it will be useful,
8805 but WITHOUT ANY WARRANTY; without even the implied warranty of
8806 MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
8807 GNU General Public License for more details.
8808
8809 You should have received a copy of the GNU General Public License
8810 along with GNU Emacs. If not, see <http://www.gnu.org/licenses/>.