Merge from trunk.
[bpt/emacs.git] / src / ChangeLog
CommitLineData
a69fbedb 12011-08-16 Paul Eggert <eggert@cs.ucla.edu>
ddff3151 2
70c60eb2 3 Integer and memory overflow issues (Bug#9196).
726e0ab1 4
a69fbedb
PE
5 * image.c (x_allocate_bitmap_record, cache_image):
6 * xselect.c (Fx_register_dnd_atom):
7 Simplify previous changes by using xpalloc.
8
fe5c5d37
PE
9 * buffer.c (overlay_str_len): Now ptrdiff_t, not EMACS_INT,
10 since either will do and ptrdiff_t is convenient with xpalloc.
11
0065d054
PE
12 * charset.c (charset_table_size)
13 (struct charset_sort_data.priority): Now ptrdiff_t.
14 (charset_compare): Don't overflow if priorities differ greatly.
15 (Fsort_charsets): Don't assume list length fits in int.
16 Check for size-calculation overflow when allocating sort data.
17 (syms_of_charset): Allocate an initial charset table that is
18 just under 64 KiB, to avoid problems with glibc malloc and mmap.
19
20 * cmds.c (internal_self_insert): Check for size-calculation overflow.
21
22 * composite.h (struct composition.glyph_len): Now int, not unsigned.
23 The actual value is always <= INT_MAX, and leaving it unsigned made
24 overflow checking harder.
25
26 * dispextern.h (struct glyph_matrix.rows_allocated)
27 (struct face_cache.size): Now ptrdiff_t, for convenience in use
28 with xpalloc. The values are still always <= INT_MAX.
29
30 * indent.c (compute_motion): Adjust to region_cache_forward sig change.
31
32 * lisp.h (xnmalloc, xnrealloc, xpalloc): New decls.
33 (SAFE_NALLOCA): New macro.
34
35 * region-cache.c (struct boundary.pos, find_cache_boundary)
36 (move_cache_gap, insert_cache_boundary, delete_cache_boundaries)
37 (set_cache_region, invalidate_region_cache)
38 (revalidate_region_cache, know_region_cache, region_cache_forward)
39 (region_cache_backward, pp_cache):
40 Use ptrdiff_t, not EMACS_INT, since either will do. This is needed
41 so that ptrdiff_t * can be passed to xpalloc.
42 (struct region_cache): Similarly, for gap_start, gap_len, cache_len,
43 beg_unchanged, end_unchanged, buffer_beg, buffer_end members.
44 (pp_cache): Don't assume cache_len fits in int.
45 * region-cache.h: Adjust extern decls to match.
46
47 * search.c (scan_buffer, Freplace_match): Use ptrdiff_t, not
48 EMACS_INT, since either will do, for xpalloc.
49
50 * alloc.c: Include verify.h, and check that int fits in ptrdiff_t.
51 (xnmalloc, xnrealloc, xpalloc): New functions.
52
726e0ab1
PE
53 * bidi.c (bidi_shelve_header_size): New constant.
54 (bidi_cache_ensure_space, bidi_shelve_cache): Use it.
55 (bidi_cache_ensure_space): Avoid integer overflow when allocating.
56
57 * buffer.c (overlays_at, overlays_in, record_overlay_string)
58 (overlay_strings):
59 Don't update size of array until after memory allocation succeeds,
60 because xmalloc/xrealloc may not return.
0065d054
PE
61 (struct sortstrlist.bytes): Now ptrdiff_t, as EMACS_INT doesn't help
62 now that we have proper integer overflow checking.
63 (record_overlay_string, overlay_strings): Catch overflows when
64 calculating size of overlay_str_buf.
726e0ab1 65
0065d054
PE
66 * callproc.c (Fcall_process): Check for size overflow when
67 calculating size of args2.
68 (child_setup): Avoid overflow by using size_t rather than ptrdiff_t.
69 Normally we prefer signed values, but sticking with ptrdiff_t would
70 require adding more-complicated checks.
726e0ab1
PE
71
72 * ccl.c (Fccl_execute_on_string): Check for memory overflow.
73 Use ptrdiff_t rather than EMACS_INT where ptrdiff_t will do.
74 Redo buffer-overflow calculations to avoid integer overflow.
0065d054 75 Add a FIXME comment where memory seems to be over-allocated.
726e0ab1
PE
76
77 * character.c (Fstring): Check for size-calculation overflow.
78
79 * coding.c (produce_chars): Redo buffer-overflow calculations to avoid
80 unnecessary integer overflow. Check for size overflow.
81 (encode_coding_object): Don't update size until xmalloc succeeds.
82
83 * composite.c (get_composition_id): Check for overflow in glyph
84 length calculations.
85
86 Integer and memory overflow fixes for display code.
87 * dispextern.h (struct glyph_pool.nglyphs): Now ptrdiff_t, not int.
88 * dispnew.c (adjust_glyph_matrix, realloc_glyph_pool)
89 (scrolling_window): Check for overflow in size calculations.
90 (line_draw_cost, realloc_glyph_pool, add_row_entry):
91 Don't assume glyph table len fits in int.
92 (struct row_entry.bucket, row_entry_pool_size, row_entry_idx)
93 (row_table_size): Now ptrdiff_t, not int.
94 (scrolling_window): Avoid overflow in size calculations.
95 Don't update size until allocation succeeds.
96 * fns.c (concat): Check for overflow in size calculations.
97 (next_almost_prime): Verify NEXT_ALMOST_PRIME_LIMIT.
98 * lisp.h (RANGED_INTEGERP, TYPE_RANGED_INTEGERP): New macros.
99 (NEXT_ALMOST_PRIME_LIMIT): New constant.
100
101 * doc.c (get_doc_string_buffer_size): Now ptrdiff_t, not int.
102 (get_doc_string): Check for size calculation overflow.
103 Don't update size until allocation succeeds.
104 (get_doc_string, Fsubstitute_command_keys): Use ptrdiff_t, not
105 EMACS_INT, where ptrdiff_t will do.
106 (Fsubstitute_command_keys): Check for string overflow.
107
108 * editfns.c (set_time_zone_rule): Don't assume environment length
109 fits in int.
110 (message_length): Now ptrdiff_t, not int.
111 (Fmessage_box): Don't update size until allocation succeeds.
112 Don't assume message length fits in int.
113 (Fformat): Use ptrdiff_t, not EMACS_INT, where ptrdiff_t will do.
114
0065d054
PE
115 * emacs.c (main): Do not reallocate argv, since there is a null at
116 the end that can be overwritten, and this way there's no need to
117 worry about size-calculation overflow.
118 (sort_args): Check for size-calculation overflow.
726e0ab1
PE
119
120 * eval.c (init_eval_once, grow_specpdl): Don't update size until
121 alloc succeeds.
122 (call_debugger, grow_specpdl): Redo calculations to avoid overflow.
123
124 * frame.c (set_menu_bar_lines, x_set_frame_parameters)
125 (x_set_scroll_bar_width, x_figure_window_size):
126 Check for integer overflow.
127 (x_set_alpha): Do not assume XINT fits in int.
128
129 * frame.h (struct frame): Use int, not EMACS_INT, where int works.
130 This is for the members text_lines, text_cols, total_lines, total_cols,
131 where the system imposes an 'int' limit.
132
133 * fringe.c (Fdefine_fringe_bitmap):
134 Don't update size until alloc works.
135
136 * ftfont.c (ftfont_get_open_type_spec, setup_otf_gstring)
137 (ftfont_shape_by_flt): Check for integer overflow in size calculations.
138
139 * gtkutil.c (get_utf8_string, xg_store_widget_in_map):
140 Check for size-calculation overflow.
141 (get_utf8_string): Use ptrdiff_t, not size_t, where either will
142 do, as we prefer signed integers.
143 (id_to_widget.max_size, id_to_widget.used)
144 (xg_store_widget_in_map, xg_remove_widget_from_map)
145 (xg_get_widget_from_map, xg_get_scroll_id_for_window)
146 (xg_remove_scroll_bar, xg_update_scrollbar_pos):
147 Use and return ptrdiff_t, not int.
148 (xg_gtk_scroll_destroy): Don't assume ptrdiff_t fits in int.
149 * gtkutil.h: Change prototypes to match the above.
150
151 * image.c (RANGED_INTEGERP, TYPE_RANGED_INTEGERP): Remove; these
152 are duplicate now that they've been promoted to lisp.h.
153 (x_allocate_bitmap_record, x_alloc_image_color)
154 (make_image_cache, cache_image, xpm_load):
155 Don't update size until alloc is done.
156 (xpm_load, lookup_rgb_color, lookup_pixel_color, x_to_xcolors)
157 (x_detect_edges):
3256efce 158 Check for size calculation overflow.
726e0ab1
PE
159 (ct_colors_allocated_max): New constant.
160 (x_to_xcolors, x_detect_edges): Reorder multiplicands to avoid
161 overflow.
3256efce 162
726e0ab1
PE
163 * keyboard.c (read_char, menu_bar_items, tool_bar_items)
164 (read_char_x_menu_prompt, read_char_minibuf_menu_width)
165 (read_char_minibuf_menu_prompt, follow_key, read_key_sequence):
166 Use ptrdiff_t, not int, to count maps.
167 (read_char_minibuf_menu_prompt): Check for overflow in size
168 calculations. Don't update size until allocation succeeds. Redo
169 calculations to avoid overflow.
170 * keyboard.h: Change prototypes to match the above.
171
172 * keymap.c (cmm_size, current_minor_maps): Use ptrdiff_t, not int,
173 to count maps.
174 (current_minor_maps): Check for size calculation overflow.
175 * keymap.h: Change prototypes to match the above.
176
177 * lread.c (read1, init_obarray): Don't update size until alloc done.
178
179 * macros.c (Fstart_kbd_macro): Don't update size until alloc done.
180 (store_kbd_macro_char): Reorder multiplicands to avoid overflow.
181
726e0ab1
PE
182 * nsterm.h (struct ns_color_table.size, struct ns_color_table.avail):
183 Now ptrdiff_t, not int.
184 * nsterm.m (ns_index_color): Use ptrdiff_t, not int, for table indexes.
185 (ns_draw_fringe_bitmap): Rewrite to avoid overflow.
186
187 * process.c (Fnetwork_interface_list): Check for overflow
188 in size calculation.
189
190 * region-cache.c (move_cache_gap): Check for size calculation overflow.
191
192 * scroll.c (do_line_insertion_deletion_costs): Check for size calc
193 overflow. Don't bother calling xmalloc when xrealloc will do.
194
195 * search.c (Freplace_match): Check for size calculation overflow.
196 (Fset_match_data): Don't assume list lengths fit in 'int'.
197
198 * sysdep.c (system_process_attributes): Use ptrdiff_t, not int,
199 for command line length. Do not attempt to address one before the
200 beginning of an array, as that's not portable.
201
202 * term.c (max_frame_lines): Remove; unused.
203 (encode_terminal_src_size, encode_terminal_dst_size): Now ptrdiff_t,
204 not int.
205 (encode_terminal_code, calculate_costs): Check for size
206 calculation overflow.
207 (encode_terminal_code): Use ptrdiff_t, not int, to record glyph
208 table lengths and related sizes. Don't update size until alloc
209 done. Redo calculations to avoid overflow.
210 (calculate_costs): Don't bother calling xmalloc when xrealloc will do.
211
212 * termcap.c (tgetent): Use ptrdiff_t, not int, to record results of
213 subtracting pointers.
214 (gobble_line): Check for overflow more carefully. Don't update size
215 until alloc done.
216
217 * tparam.c (tparam1): Use ptrdiff_t, not int, for sizes.
218 Don't update size until alloc done.
219 Redo size calculations to avoid overflow.
220 Check for size calculation overflow.
0065d054 221 (main) [DEBUG]: Fix typo in invoking tparam1.
726e0ab1
PE
222
223 * xdisp.c (store_mode_line_noprop_char, x_consider_frame_title):
224 Use ptrdiff_t, not int, for sizes.
225 (store_mode_line_noprop_char): Don't update size until alloc done.
226
0065d054
PE
227 * xfaces.c (lface_id_to_name_size, Finternal_make_lisp_face):
228 Use ptrdiff_t, not int, for sizes.
229 (Finternal_make_lisp_face, cache_face):
230 Check for size calculation overflow.
231 (cache_face): Treat size calculation overflows as if they were
232 memory exhaustion (the usual treatment), rather than aborting.
726e0ab1
PE
233
234 * xfns.c (x_encode_text, x_set_name_internal)
235 (Fx_change_window_property): Use ptrdiff_t, not int, to count
236 sizes, since they can exceed INT_MAX in size. Check for size
237 calculation overflow.
238
0065d054
PE
239 * xgselect.c (gfds_size): Now ptrdiff_t, for convenience with xpalloc.
240 (xg_select): Check for size calculation overflow.
726e0ab1
PE
241 Don't update size until alloc done.
242
0065d054 243 * xrdb.c (get_environ_db): Don't assume path length fits in int,
726e0ab1 244 as sprintf is limited to int lengths.
1d526e2f 245
252c5ee1
PE
246 * xselect.c (X_LONG_SIZE, X_SHRT_MAX, X_SHRT_MIN, X_LONG_MAX)
247 (X_LONG_MIN): New macros.
864d7ce7
PE
248 Use them to make the following changes clearer.
249 (MAX_SELECTION_QUANTUM): Make the other bounds on this value clearer.
250 This change doesn't affect the value now, but it may help remind
251 future maintainers not to raise the value too much later.
252 (SELECTION_QUANTUM): Remove, replacing with ...
253 (selection_quantum): ... new function, which avoids overflow.
254 All uses changed.
255 (struct selection_data.size): Now ptrdiff_t, not int, to avoid
256 assumption that selection length fits in 'int'.
257 (x_reply_selection_request, x_handle_selection_request)
258 (x_get_window_property, receive_incremental_selection)
259 (x_get_window_property_as_lisp_data, selection_data_to_lisp_data)
260 (lisp_data_to_selection_data, clean_local_selection_data):
261 Use ptrdiff_t, not int, to record length of selection.
262 (x_reply_selection_request, x_get_window_property)
263 (receive_incremental_selection, x_property_data_to_lisp):
264 Redo calculations to avoid overflow.
265 (x_reply_selection_request): When sending hint, ceiling it at
252c5ee1 266 X_LONG_MAX rather than relying on wraparound overflow to send
864d7ce7
PE
267 something.
268 (x_get_window_property, receive_incremental_selection)
269 (lisp_data_to_selection_data, x_property_data_to_lisp):
270 Check for size-calculation overflow.
271 (x_get_window_property, receive_incremental_selection)
272 (lisp_data_to_selection_data, Fx_register_dnd_atom):
273 Don't store size until memory allocation succeeds.
274 (x_get_window_property): Plug memory leak on memory exhaustion.
275 Don't double-block input; malloc is safe here. Don't assume 2**34
276 - 4 fits in unsigned long. Add an xassert to check
277 XGetWindowProperty overflow. Be more careful about overflow
278 calculations, and distinguish size from memory overflow better.
279 (receive_incremental_selection): When tracing, don't assume
280 unsigned int is less than INT_MAX.
281 (x_selection_data_to_lisp_data): Remove unnecessary (and in theory
282 harmful) conversions of unsigned short to int.
283 (lisp_data_to_selection_data): Don't assume that integers
284 in the range -65535 through -1 fit in an X unsigned short.
285 Don't assume that ULONG_MAX == X_ULONG_MAX. Don't store into
286 result parameters unless successful. Rely on cons_to_unsigned
287 to report problems with elements; the old code wasn't right anyway.
288 (x_check_property_data): Check for int overflow; we cannot use
289 a wider type due to X limits.
290 (x_handle_dnd_message): Use unsigned int, to avoid int overflow.
291
726e0ab1 292 * xsmfns.c (smc_save_yourself_CB): Check for size calc overflow.
34db673b 293
0065d054
PE
294 * xterm.c (x_color_cells, x_send_scrollbar_event, handle_one_xevent)
295 (x_term_init): Check for size calculation overflow.
726e0ab1
PE
296 (x_color_cells): Don't store size until memory allocation succeeds.
297 (handle_one_xevent): Use ptrdiff_t, not int, for byte counts.
0065d054 298 Don't assume alloca size is less than MAX_ALLOCA.
726e0ab1
PE
299 (x_term_init): Don't assume length fits in int (sprintf is limited
300 to int size).
bc18e09d 301
ebfa62c0
PE
302 Use ptrdiff_t for composition IDs.
303 * character.c (lisp_string_width):
304 * composite.c (composition_table_size, n_compositions)
305 (get_composition_id, composition_gstring_from_id):
306 * dispextern.h (struct glyph_string.cmp_id, struct composition_it.id):
307 * xdisp.c (BUILD_COMPOSITE_GLYPH_STRING):
308 * window.c (Frecenter):
309 Use ptrdiff_t, not int, for composition IDs.
310 * composite.c (get_composition_id): Check for integer overflow.
311 * composite.h: Adjust prototypes to match the above changes.
312
d3411f89
PE
313 Use ptrdiff_t for hash table indexes.
314 * category.c (hash_get_category_set):
315 * ccl.c (ccl_driver):
316 * charset.h (struct charset.hash_index, CHECK_CHARSET_GET_ID):
317 * coding.c (coding_system_charset_list, detect_coding_system):
318 * coding.h (struct coding_system.id):
319 * composite.c (get_composition_id, gstring_lookup_cache):
320 * fns.c (hash_lookup, hash_put, Fgethash, Fputhash):
321 * image.c (xpm_get_color_table_h):
322 * lisp.h (hash_lookup, hash_put):
323 * minibuf.c (Ftest_completion):
324 Use ptrdiff_t for hash table indexes, not int (which is too
325 narrow, on 64-bit hosts) or EMACS_INT (which is too wide, on
326 32-bit --with-wide-int hosts).
327
e097a6fa
PE
328 * charset.c (Fdefine_charset_internal): Check for integer overflow.
329 Add a FIXME comment about memory leaks.
330 (syms_of_charset): Don't assume xmalloc returns.
331
5637687f
PE
332 Don't assume that stated character widths fit in int.
333 * character.c (Fchar_width, c_string_width, lisp_string_width):
334 * character.h (CHAR_WIDTH):
335 * indent.c (MULTIBYTE_BYTES_WIDTH):
336 Use sanitize_char_width to avoid undefined and/or bad behavior
337 with outlandish widths.
338 * character.h (sanitize_tab_width): Renamed from sanitize_width,
339 now that we have two such functions. All uses changed.
340 (sanitize_char_width): New inline function.
341
a2271ba2
PE
342 Don't assume that tab-width fits in int.
343 * character.h (sanitize_width): New inline function.
344 (SANE_TAB_WIDTH): New macro.
345 (ASCII_CHAR_WIDTH): Use it.
346 * indent.c (sane_tab_width): Remove. All uses replaced by
347 SANE_TAB_WIDTH (current_buffer).
348 * xdisp.c (init_iterator): Use SANE_TAB_WIDTH.
349
18c52557
PE
350 * fileio.c: Integer overflow issues with file modes.
351 (Fset_file_modes, auto_save_1): Don't assume EMACS_INT fits in int.
352
caeeedc1
PE
353 * charset.c (read_hex): New arg OVERFLOW. All uses changed.
354 Remove unreachable code.
355 (read_hex, load_charset_map_from_file): Check for integer overflow.
356
50849c52
PE
357 * xterm.c: don't go over XClientMessageEvent limit
358 (scroll_bar_windows_size): Now ptrdiff_t, as we prefer signed.
359 (x_send_scroll_bar_event): Likewise. Check that the size does not
360 exceed limits imposed by XClientMessageEvent, as well as the usual
361 ptrdiff_t and size_t limits.
362
b13995db
PE
363 * keyboard.c: Overflow, signedness and related fixes.
364 (make_lispy_movement): Use same integer type in forward decl
365 that is used in the definition.
366 (read_key_sequence, keyremap_step):
367 Change bufsize argument back to int, undoing my 2011-03-30 change.
368 We prefer signed types, and int is wide enough here.
369 (parse_tool_bar_item): Don't assume tool_bar_max_label_size is less
370 than TYPE_MAXIMUM (EMACS_INT) / 2. Don't let the label size grow
371 larger than STRING_BYTES_BOUND. Use ptrdiff_t for Emacs string
372 length, not size_t. Use ptrdiff_t for index, not int.
373 (keyremap_step, read_key_sequence): Redo bufsize check to avoid
374 possibility of integer overflow.
375
13464394
PE
376 Overflow, signedness and related fixes for images.
377
378 * dispextern.h (struct it.stack[0].u.image.image_id)
379 (struct_it.image_id, struct image.id, struct image_cache.size)
380 (struct image_cache.used, struct image_cache.ref_count):
381 * gtkutil.c (update_frame_tool_bar):
382 * image.c (x_reference_bitmap, Fimage_size, Fimage_mask_p)
383 (Fimage_metadata, free_image_cache, clear_image_cache, lookup_image)
384 (cache_image, mark_image_cache, x_kill_gs_process, Flookup_image):
385 * nsmenu.m (update_frame_tool_bar):
386 * xdisp.c (calc_pixel_width_or_height):
387 * xfns.c (image_cache_refcount):
388 Image IDs are now ptrdiff_t, not int, to avoid arbitrary limits
389 on typical 64-bit hosts.
390
391 * image.c (RANGED_INTEGERP, TYPE_RANGED_INTEGERP): New macros.
392 (x_bitmap_pixmap, x_create_x_image_and_pixmap):
393 Omit unnecessary casts to int.
394 (parse_image_spec): Check that integers fall into 'int' range
395 when the callers expect that.
396 (image_ascent): Redo ascent calculation to avoid int overflow.
397 (clear_image_cache): Avoid overflow when sqrt (INT_MAX) < nimages.
398 (lookup_image): Remove unnecessary tests.
399 (xbm_image_p): Locals are now of int, not EMACS_INT,
400 since parse_image_check makes sure they fit into int.
401 (png_load, gif_load, svg_load_image):
402 Prefer int to unsigned where either will do.
403 (tiff_handler): New function, combining the cores of the
404 old tiff_error_handler and tiff_warning_handler. This
405 function is rewritten to use vsnprintf and thereby avoid
406 stack buffer overflows. It uses only the features of vsnprintf
407 that are common to both POSIX and native Microsoft.
408 (tiff_error_handler, tiff_warning_handler): Use it.
409 (tiff_load, gif_load, imagemagick_load_image):
410 Don't assume :index value fits in 'int'.
411 (gif_load): Omit unnecessary cast to double, and avoid double-rounding.
412 (imagemagick_load_image): Check that crop parameters fit into
413 the integer types that MagickCropImage accepts. Don't assume
414 Vimagemagick_render_type has a nonnegative value. Don't assume
415 size_t fits in 'long'.
416 (gs_load): Use printmax_t to print the widest integers possible.
417 Check for integer overflow when computing image height and width.
418
b215eee5
EZ
4192011-08-16 Eli Zaretskii <eliz@gnu.org>
420
421 * xdisp.c (set_cursor_from_row): Don't accept a previous candidate
422 if it fails the cursor_row_p test. Fixes cursor positioning at ZV.
423
a4579d33
KB
4242011-08-16 Ken Brown <kbrown@cornell.edu>
425
426 Fix memory allocation problems in Cygwin build (Bug#9273).
427
428 * unexcw.c ( __malloc_initialized): Declare external variable.
429 (fixup_executable): Force the dumped emacs to reinitialize malloc.
430
431 * gmalloc.c [CYGWIN] (bss_sbrk_heapbase, bss_sbrk_heapinfo): New
432 variables.
433 (malloc_initialize_1) [CYGWIN]: Prepare for reinitializing the
434 dumped emacs.
435 (_free_internal_nolock) [CYGWIN]: Ignore requests to free storage
436 in the static heap.
437 [CYGWIN] (special_realloc): New function.
438 (_realloc_internal_nolock) [CYGWIN]: Use the new function on
439 requests to realloc storage in the static heap.
440
3ebec551
PE
4412011-08-15 Paul Eggert <eggert@cs.ucla.edu>
442
443 * bidi.c (bidi_initialize): Remove unused local.
444
9fd8be00
EZ
4452011-08-15 Eli Zaretskii <eliz@gnu.org>
446
474a8465
EZ
447 * biditype.h: File removed.
448
449 * bidimirror.h: File removed.
450
451 * deps.mk (bidi.o): Remove biditype.h and
452 bidimirror.h.
453
454 * makefile.w32-in ($(BLD)/bidi.$(O)): Remove biditype.h and
455 bidimirror.h.
456
457 * dispextern.h: Fix a typo in the comment to bidi_type_t.
458
459 * chartab.c: Improve commentary for the uniprop_table API.
460
32413314
EZ
461 * bidi.c (bidi_paragraph_init): Support zero value of
462 bidi_ignore_explicit_marks_for_paragraph_level.
474a8465
EZ
463 (bidi_initialize): Use uniprop_table instead of including
464 biditype.h and bidimirror.h.
32413314 465
9fd8be00
EZ
466 * xdisp.c (move_it_in_display_line_to): Don't reset pixel
467 coordinates of the iterator when restoring from ppos_it.
468 (Bug#9296)
469
5cf2b69b
KH
4702011-08-14 Kenichi Handa <handa@m17n.org>
471
472 * process.c (create_process): Call setup_process_coding_systems
473 after the pid of the process is set to -1.
474
daf17d00
EZ
4752011-08-14 Eli Zaretskii <eliz@gnu.org>
476
477 * xdisp.c (move_it_in_display_line_to): Don't invoke
478 IT_RESET_X_ASCENT_DESCENT when iterator position was restored from
479 ppos_it. Fixes vertical cursor motion when line beginning is
480 covered by an image. (Bug#9296)
481
08e3161a
JD
4822011-08-14 Jan Djärv <jan.h.d@swipnet.se>
483
484 * nsterm.h (ns_run_ascript): Declare.
485 (NSAPP_DATA2_RUNASSCRIPT): Define.
486
487 * nsfns.m (as_script, as_result, as_status): New static variables.
488 (ns_run_ascript): New function.
489 (Fns_do_applescript): Set variables as_*. Make an NSApplicationDefined
490 event with data2 set to NSAPP_DATA2_RUNASSCRIPT, post it and then start
491 the event loop. Get status from as_status (Bug#7276).
492
493 * nsterm.m (sendEvent): If event is NSApplicationDefined and
494 data2 is NSAPP_DATA2_RUNASSCRIPT, call ns_run_ascript and then exit
495 the event loop (Bug#7276).
496
a3720aa2
AS
4972011-08-14 Andreas Schwab <schwab@linux-m68k.org>
498
499 * gnutls.c (QCgnutls_bootprop_priority)
500 (QCgnutls_bootprop_trustfiles, QCgnutls_bootprop_keylist)
501 (QCgnutls_bootprop_crlfiles, QCgnutls_bootprop_callbacks)
502 (QCgnutls_bootprop_loglevel, QCgnutls_bootprop_hostname)
503 (QCgnutls_bootprop_min_prime_bits, QCgnutls_bootprop_verify_flags)
504 (QCgnutls_bootprop_verify_hostname_error)
505 (QCgnutls_bootprop_callbacks_verify): Rename from
506 Qgnutls_bootprop_..., all uses changed.
507
508 * xfaces.c (QCignore_defface): Rename from Qignore_defface, all
509 uses changed.
510
0a0d27fb
PE
5112011-08-14 Paul Eggert <eggert@cs.ucla.edu>
512
19d5c50c
PE
513 * xfaces.c (Qframe_set_background_mode): Now static.
514 * dispextern.h (Qframe_set_background_mode): Remove decl.
515
0a0d27fb
PE
516 * process.c (Fnetwork_interface_info): Declare local only if needed.
517
377538cb
JD
5182011-08-13 Jan Djärv <jan.h.d@swipnet.se>
519
520 * process.c: Include ifaddrs.h and net/if_dl.h if available (Bug#8477).
521 (Fnetwork_interface_list): Allocate in increments of bytes instead
522 of sizeof (struct ifreq). Iterate over ifconf.ifc_req by counting
523 bytes (Bug#8477). Count bytes correctly when ifr_addr is a struct
524 sockaddr.
525 (struct ifflag_def): notrailers is smart on OSX.
526 (Fnetwork_interface_info): Handle case when ifr_flags is negative.
527 Get hardware address with getifaddrs if available.
528
08fff70c
EZ
5292011-08-12 Eli Zaretskii <eliz@gnu.org>
530
531 * xdisp.c (iterate_out_of_display_property): xassert that
532 IT->position is set to within IT->object's boundaries. Break from
533 the loop as soon as EOB is reached; avoids infloops in redisplay
534 when IT->position is set up wrongly due to some bug. Set
535 IT->current to match the bidi iterator unconditionally.
536 (push_display_prop): Allow GET_FROM_STRING as IT->method on
537 entry. Force push_it to save on the stack the current
538 buffer/string position, to be restored by pop_it. Fix flags in
539 the iterator structure wrt the object coming from a display
540 property, as `line-prefix' and `wrap-prefix' are not ``replacing''
541 properties. (Bug#9284)
542
7be1c708 5432011-08-09 Andreas Schwab <schwab@linux-m68k.org>
aac0c6e3 544
7be1c708
CY
545 * fontset.c (fontset_get_font_group): Add proper type checks.
546 (Bug#9172)
aac0c6e3 547
7be1c708 5482011-08-09 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
aac0c6e3 549
7be1c708
CY
550 * unexmacosx.c (print_load_command_name): Add cases LC_FUNCTION_STARTS
551 and LC_VERSION_MIN_MACOSX.
552 (copy_linkedit_data) [LC_FUNCTION_STARTS]: New function.
553 (dump_it) [LC_FUNCTION_STARTS]: Use it.
aac0c6e3 554
97bb72a6
EZ
5552011-08-08 Eli Zaretskii <eliz@gnu.org>
556
557 * xdisp.c (forward_to_next_line_start): Allow to use the
757664a4
EZ
558 no-display-properties-and-no-overlays under bidi display. Set
559 disp_pos in the bidi iterator to avoid searches for display
560 properties and overlays.
97bb72a6 561
d5617611
CY
5622011-08-08 Chong Yidong <cyd@stupidchicken.com>
563
37e11a63
CY
564 * editfns.c (Fset_time_zone_rule): Document relationship with the
565 setenv function.
566
d5617611
CY
567 * ftfont.c (ftfont_pattern_entity): Copy the extras argument to
568 the font entity extracted from the cache (Bug#8109).
569
58872834
CY
5702011-08-07 Chong Yidong <cyd@stupidchicken.com>
571
572 * composite.c (autocmp_chars): Don't reset point. That is done by
573 restore_point_unwind (Bug#5984).
574
75bfc667
JL
5752011-08-07 Juri Linkov <juri@jurta.org>
576
577 * editfns.c (Fformat_time_string): Doc fix, add tag `usage:'
578 to show the arg `TIME' instead of `TIMEVAL'.
579
d1410150
EZ
5802011-08-06 Eli Zaretskii <eliz@gnu.org>
581
582 * xdisp.c (set_cursor_from_row): Fix cursor positioning when a
583 display property strides EOL and includes a newline, as in
584 longlines-mode. (Bug#9254)
75b771e4
EZ
585 (move_it_in_display_line_to): Fix vertical-motion in a buffer with
586 word-wrap under bidirectional display. (Bug#9224)
d1410150
EZ
587
588 * bidi.c (bidi_unshelve_cache): Don't reset the cache if JUST_FREE
589 is non-zero, even if the data buffer is NULL. Fixes a crash in
590 vertical-motion with longlines-mode. (Bug#9254)
591
35928349
EZ
5922011-08-05 Eli Zaretskii <eliz@gnu.org>
593
ec7cc85b
EZ
594 * bidi.c <bidi_cache_total_alloc>: Now static.
595 (bidi_initialize): Initialize bidi_cache_total_alloc.
596
35928349
EZ
597 *xdisp.c (display_line): Release buffer allocated for shelved bidi
598 cache. (Bug#9221)
599
600 * bidi.c (bidi_shelve_cache, bidi_unshelve_cache): Track total
601 amount allocated this far in `bidi_cache_total_alloc'.
602 (bidi_unshelve_cache): Accept an additional argument JUST_FREE; if
603 non-zero, only free the data buffer without restoring the cache
604 contents. All callers changed.
605
606 * dispextern.h (bidi_unshelve_cache): Update prototype.
607
608 * xdisp.c (SAVE_IT, pos_visible_p, move_it_in_display_line_to)
609 (move_it_in_display_line, move_it_to)
610 (move_it_vertically_backward, move_it_by_lines): Replace the call
611 to xfree to an equivalent call to bidi_unshelve_cache.
612 (move_it_in_display_line_to): Fix logic of returning
412b6358 613 MOVE_POS_MATCH_OR_ZV in the bidi case. (Bug#9224)
35928349 614
e2e2423b
EZ
6152011-08-05 Eli Zaretskii <eliz@gnu.org>
616
617 * xdisp.c (set_cursor_from_row): Prefer the candidate glyph that
618 came from a string character with a `cursor' property. (Bug#9229)
619
ae9e757a
JD
6202011-08-04 Jan Djärv <jan.h.d@swipnet.se>
621
622 * Makefile.in (LIB_PTHREAD): New variable.
623 (LIBES): Add LIB_PTHREAD (Bug#9216).
624
625 * alloc.c, emacs.c, gmalloc.c, gtkutil.c, keyboard.c, syssignal.h:
626 Rename HAVE_GTK_AND_PTHREAD to HAVE_PTHREAD (Bug#9216).
627
213bd7f2
AS
6282011-08-04 Andreas Schwab <schwab@linux-m68k.org>
629
630 * regex.c (re_iswctype): Remove some redundant boolean
631 conversions.
632
99aaf75f
JD
6332011-08-04 Jan Djärv <jan.h.d@swipnet.se>
634
635 * xterm.c (x_find_topmost_parent): New function.
636 (x_set_frame_alpha): Find topmost parent window with
637 x_find_topmost_parent and set the property there also (bug#9181).
638 (handle_one_xevent): Call x_set_frame_alpha on ReparentNotify.
639
c74e9d86
PE
6402011-08-04 Paul Eggert <eggert@cs.ucla.edu>
641
642 * callproc.c (Fcall_process): Avoid vfork clobbering
643 the local vars buffer, coding_systems, current_dir.
644
640c8776
SM
6452011-08-03 Stefan Monnier <monnier@iro.umontreal.ca>
646
647 * keymap.c (Fmake_composed_keymap): Move to subr.el.
648
f26d0e4c
PE
6492011-08-03 Paul Eggert <eggert@cs.ucla.edu>
650
8a10d76c
PE
651 * fontset.c (dump_fontset) [FONTSET_DEBUG]: Declare EXTERNALLY_VISIBLE
652 so that it is not optimized away.
653
f26d0e4c
PE
654 * xdisp.c (compute_display_string_pos): Remove unused local.
655
55439c61
EZ
6562011-08-02 Eli Zaretskii <eliz@gnu.org>
657
658 Fix slow cursor motion and scrolling in large buffers with
659 selective display, like Org Mode buffers. (Bug#9218)
660
661 * dispextern.h (struct bidi_it): New member disp_prop_p.
662
663 * xdisp.c: Remove one-slot cache of display string positions.
664 (compute_display_string_pos): Accept an additional argument
665 DISP_PROP_P; callers changed. Scan at most 5K characters forward
666 for a display string or property. If found, set DISP_PROP_P
667 non-zero.
668
669 * bidi.c (bidi_fetch_char): Accept an additional argument
640c8776
SM
670 DISP_PROP_P, and pass it to compute_display_string_pos.
671 Only handle text covered by a display string if DISP_PROP_P is returned
55439c61
EZ
672 non-zero. All callers of bidi_fetch_char changed.
673
fb33fa43
SM
6742011-08-02 Stefan Monnier <monnier@iro.umontreal.ca>
675
676 * keymap.c (Fdefine_key): Fix Lisp_Object/int mixup; apply some CSE.
677
b099e063
DM
6782010-12-03 Don March <don@ohspite.net>
679
680 * keymap.c (Fdefine_key): Fix non-prefix key error message when
681 last character M-[char] is translated to ESC [char] (bug#7541).
682
5cc7f7af
KH
6832011-08-02 Kenichi Handa <handa@m17n.org>
684
d0fffa3f 685 * lisp.h (uniprop_table): Extern it.
5cc7f7af
KH
686
687 * chartab.c (uniprop_table): Make it non-static.
688
525d5e6e
EZ
6892011-08-01 Eli Zaretskii <eliz@gnu.org>
690
691 * xdisp.c (forward_to_next_line_start): Accept additional argument
692 BIDI_IT_PREV, and store into it the state of the bidi iterator had
693 on the newline.
694 (reseat_at_next_visible_line_start): Use the bidi iterator state
695 returned by forward_to_next_line_start to restore the state of
696 it->bidi_it after backing up to previous newline. (Bug#9212)
697
31011111
AS
6982011-07-30 Andreas Schwab <schwab@linux-m68k.org>
699
700 * regex.c (re_comp): Protoize.
701 (re_exec): Fix return type.
702 (regexec): Fix type of `ret'. (Bug#9203)
703
e5d76069
PE
7042011-07-29 Paul Eggert <eggert@cs.ucla.edu>
705
706 * image.c (check_image_size): Use 1024x1024 if unknown frame (Bug#9189).
707 This is needed if max-image-size is a floating-point number.
708
9a79b20c
AS
7092011-07-28 Andreas Schwab <schwab@linux-m68k.org>
710
711 * print.c (print_object): Print empty symbol as ##.
712
713 * lread.c (read1): Read ## as empty symbol.
714
d8c2fa78
AA
7152011-07-28 Alp Aker <alp.tekin.aker@gmail.com>
716
717 * nsfns.m (x_set_foreground_color): Set f->foreground_pixel when
718 setting frame foreground color (Bug#9175).
719 (x_set_background_color): Likewise.
720
ffe57a7a
AA
721 * nsmenu.m (-setText): Size tooltip dimensions precisely to
722 contents (Bug#9176).
723 (EmacsTooltip -init): Remove bezels and add shadows to
724 tooltip windows.
725
bf3492a5
AA
726 * nsterm.m (ns_dumpglyphs_stretch): Avoid overwriting left fringe
727 or scroll bar (Bug#8470).
728
d55e9c53
AA
729 * nsfont.m (nsfont_open): Remove assignment to voffset and
730 unnecessary vars hshink, expand, hd, full_height, min_height.
731 (nsfont_draw): Use s->ybase as baseline for glyph drawing (Bug#8913).
732
733 * nsterm.h (nsfont_info): Remove voffset field.
734
d8c2fa78 7352011-07-28 Alp Aker <alp.tekin.aker@gmail.com>
4843aac3
AA
736
737 Implement strike-through and overline on NextStep (Bug#8863).
738
739 * nsfont.m (nsfont_open): Use underline position provided by font,
740 instead of hard-coded value of 2.
741 (nsfont_draw): Call ns_draw_text_decoration instead.
742
743 * nsterm.h: Add declaration for ns_draw_text_decoration.
744
745 * nsterm.m (ns_draw_text_decoration): New function for drawing
746 underline, overline, and strike-through.
747 (ns_dumpglyphs_image, ns_dumpglyphs_stretch): Add call to
748 ns_draw_text_decoration. Change treatment of cursor drawing to
749 accomodate underlining, etc.
750
4cc60b9b
EZ
7512011-07-28 Eli Zaretskii <eliz@gnu.org>
752
bc7ece87
EZ
753 * buffer.c (init_buffer_once): Set bidi-display-reordering to t by
754 default.
4cc60b9b 755
476371c4
PE
7562011-07-28 Paul Eggert <eggert@cs.ucla.edu>
757
66606eea
PE
758 * alloc.c (memory_full) [!SYNC_INPUT]: Fix signal-related race.
759 Without this fix, if a signal arrives just after memory fills up,
760 'malloc' might be invoked reentrantly.
761
476371c4
PE
762 * image.c (x_check_image_size) [!HAVE_X_WINDOWS]: Return 1.
763 In other words, assume that every image size is allowed, on non-X
764 hosts. This assumption is probably wrong, but it lets Emacs compile.
765
f3fcc40d
AS
7662011-07-28 Andreas Schwab <schwab@linux-m68k.org>
767
768 * regex.c (re_iswctype): Convert return values to boolean.
769
350c992f
EZ
7702011-07-28 Eli Zaretskii <eliz@fencepost.gnu.org>
771
772 * xdisp.c (compute_display_string_pos): Don't use cached display
773 string position if the buffer had its restriction changed.
774 (Bug#9184)
775
5266b4bb
PE
7762011-07-28 Paul Eggert <eggert@cs.ucla.edu>
777
778 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork clobbering.
779
2573a837 7802011-07-28 Paul Eggert <eggert@cs.ucla.edu>
ca4aa935 781
41f55ccd 782 Integer signedness and overflow and related fixes. (Bug#9079)
cf950e6b 783
39e378da
PE
784 * bidi.c: Integer size and overflow fixes.
785 (bidi_cache_size, bidi_cache_idx, bidi_cache_last_idx)
786 (bidi_cache_start, bidi_cache_fetch_state, bidi_cache_search)
787 (bidi_cache_find_level_change, bidi_cache_ensure_space)
788 (bidi_cache_iterator_state, bidi_cache_find, bidi_cache_start_stack)
789 (bidi_find_other_level_edge):
790 Use ptrdiff_t instead of EMACS_INT where either will do.
791 This works better on 32-bit hosts configured --with-wide-int.
792 (bidi_cache_ensure_space): Check for size-calculation overflow.
793 Use % rather than repeated addition, for better worst-case speed.
794 Don't set bidi_cache_size until after xrealloc returns, because it
795 might not return.
796 (bidi_dump_cached_states): Use ptrdiff_t, not int, to avoid overflow.
f0eb61e9
PE
797 (bidi_cache_ensure_space): Also check that the bidi cache size
798 does not exceed that of the largest Lisp string or buffer. See Eli
799 Zaretskii in <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=9079#29>.
39e378da 800
5e927815
PE
801 * alloc.c (__malloc_size_t): Remove.
802 All uses replaced by size_t. See Andreas Schwab's note
803 <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=9079#8>.
804
ca4aa935
PE
805 * image.c: Improve checking for integer overflow.
806 (check_image_size): Assume that f is nonnull, since
807 it is always nonnull in practice. This is one less thing to
808 worry about when checking for integer overflow later.
809 (x_check_image_size): New function, which checks for integer
810 overflow issues inside X.
811 (x_create_x_image_and_pixmap, xbm_read_bitmap_data): Use it.
812 This removes the need for a memory_full check.
813 (xbm_image_p): Rewrite to avoid integer multiplication overflow.
814 (Create_Pixmap_From_Bitmap_Data, xbm_load): Use x_check_image_size.
815 (xbm_read_bitmap_data): Change locals back to 'int', since
816 their values must fit in 'int'.
817 (xpm_load_image, png_load, tiff_load):
818 Invoke x_create_x_image_and_pixmap earlier,
819 to avoid much needless work if the image is too large.
820 (tiff_load): Treat overly large images as if
821 x_create_x_image_and_pixmap failed, not as malloc failures.
822 (gs_load): Use x_check_image_size.
823
5f8f9cc2
PE
824 * gtkutil.c: Omit integer casts.
825 (xg_get_pixbuf_from_pixmap): Remove unnecessary cast.
826 (xg_set_toolkit_scroll_bar_thumb): Rewrite to avoid need for cast.
827
5adf60bc
PE
828 * image.c (png_load): Don't assume height * row_bytes fits in 'int'.
829
c8907a93
PE
830 * xfaces.c (Fbitmap_spec_p): Fix integer overflow bug.
831 Without this fix, (bitmap-spec-p '(34359738368 1 "x"))
832 would wrongly return t on a 64-bit host.
833
e3c25c68
PE
834 * dispnew.c (init_display): Use *_RANGE_OVERFLOW macros.
835 The plain *_OVERFLOW macros run afoul of GCC bug 49705
836 <http://gcc.gnu.org/bugzilla/show_bug.cgi?id=49705>
837 and therefore cause GCC to emit a bogus diagnostic in some cases.
838
3f791afe
PE
839 * image.c: Integer signedness and overflow and related fixes.
840 This is not an exhaustive set of fixes, but it's time to
841 record what I've got.
842 (lookup_pixel_color, check_image_size): Remove redundant decls.
843 (check_image_size): Don't assume that arbitrary EMACS_INT values
844 fit in 'int', or that arbitrary 'double' values fit in 'int'.
845 (x_alloc_image_color, x_create_x_image_and_pixmap, png_load)
846 (tiff_load, imagemagick_load_image):
847 Check for overflow in size calculations.
848 (x_create_x_image_and_pixmap): Remove unnecessary test for
849 xmalloc returning NULL; that can't happen.
850 (xbm_read_bitmap_data): Don't assume sizes fit into 'int'.
851 (xpm_color_bucket): Use better integer hashing function.
852 (xpm_cache_color): Don't possibly over-allocate memory.
853 (struct png_memory_storage, tiff_memory_source, tiff_seek_in_memory)
854 (gif_memory_source):
855 Use ptrdiff_t, not int or size_t, to record sizes.
856 (png_load): Don't assume values greater than 2**31 fit in 'int'.
857 (our_stdio_fill_input_buffer): Prefer ptrdiff_t to size_t when
858 either works, as we prefer signed integers.
859 (tiff_read_from_memory, tiff_write_from_memory):
860 Return tsize_t, not size_t, since that's what the TIFF API wants.
861 (tiff_read_from_memory): Don't fail simply because the read would
862 go past EOF; instead, return a short read.
863 (tiff_load): Omit no-longer-needed casts.
864 (Fimagemagick_types): Don't assume size fits into 'int'.
865
3cc5a532
PE
866 Improve hashing quality when configured --with-wide-int.
867 * fns.c (hash_string): New function, taken from sxhash_string.
868 Do not discard information about ASCII character case; this
869 discarding is no longer needed.
870 (sxhash-string): Use it. Change sig to match it. Caller changed.
871 * lisp.h: Declare it.
872 * lread.c (hash_string): Remove, since we now use fns.c's version.
873 The fns.c version returns a wider integer if --with-wide-int is
874 specified, so this should help the quality of the hashing a bit.
875
b312a492
PE
876 * emacs.c: Integer overflow minor fix.
877 (heap_bss_diff): Now uprintmax_t, not unsigned long. All used changed.
878 Define only if GNU_LINUX.
879 (main, Fdump_emacs): Set and use heap_bss_diff only if GNU_LINUX.
880
dfd153ae
PE
881 * dispnew.c: Integer signedness and overflow fixes.
882 Remove unnecessary forward decls, that were a maintenance hassle.
883 (history_tick): Now uprintmax_t, so it's more likely to avoid overflow.
884 All uses changed.
885 (adjust_glyph_matrix, realloc_glyph_pool, adjust_frame_message_buffer)
886 (scrolling_window): Use ptrdiff_t, not int, for byte count.
887 (prepare_desired_row, line_draw_cost):
888 Use int, not unsigned, where either works.
889 (save_current_matrix, restore_current_matrix):
890 Use ptrdiff_t, not size_t, where either works.
891 (init_display): Check for overflow more accurately, and without
892 relying on undefined behavior.
893
a81d11a3
PE
894 * editfns.c (pWIDE, pWIDElen, signed_wide, unsigned_wide):
895 Remove, replacing with the new symbols in lisp.h. All uses changed.
896 * fileio.c (make_temp_name):
897 * filelock.c (lock_file_1, lock_file):
898 * xdisp.c (message_dolog):
899 Don't assume PRIdMAX etc. works; this isn't portable to pre-C99 hosts.
900 Use pMd etc. instead.
901 * lisp.h (printmax_t, uprintmax_t, pMd, pMu): New types and macros,
902 replacing the pWIDE etc. symbols removed from editfns.c.
903
3300e6fd
PE
904 * keyboard.h (num_input_events): Now uintmax_t.
905 This is (very slightly) less likely to mess up due to wraparound.
906 All uses changed.
907
fd05c7e9
PE
908 * buffer.c: Integer signedness fixes.
909 (alloc_buffer_text, enlarge_buffer_text):
910 Use ptrdiff_t rather than size_t when either will do, as we prefer
911 signed integers.
912
903fe15d
PE
913 * alloc.c: Integer signedness and overflow fixes.
914 Do not impose an arbitrary 32-bit limit on malloc sizes when debugging.
915 (__malloc_size_t): Default to size_t, not to int.
916 (pure_size, pure_bytes_used_before_overflow, stack_copy_size)
917 (Fgarbage_collect, mark_object_loop_halt, mark_object):
918 Prefer ptrdiff_t to size_t when either would do, as we prefer
919 signed integers.
920 (XMALLOC_OVERRUN_CHECK_OVERHEAD): New macro.
921 (xmalloc_overrun_check_header, xmalloc_overrun_check_trailer):
922 Now const. Initialize with values that are in range even if char
923 is signed.
924 (XMALLOC_PUT_SIZE, XMALLOC_GET_SIZE): Remove, replacing with ...
925 (xmalloc_put_size, xmalloc_get_size): New functions. All uses changed.
926 These functions do the right thing with sizes > 2**32.
927 (check_depth): Now ptrdiff_t, not int.
928 (overrun_check_malloc, overrun_check_realloc, overrun_check_free):
929 Adjust to new way of storing sizes. Check for size overflow bugs
930 in rest of code.
931 (STRING_BYTES_MAX): Adjust to new overheads. The old code was
932 slightly wrong anyway, as it missed one instance of
933 XMALLOC_OVERRUN_CHECK_OVERHEAD.
934 (refill_memory_reserve): Omit needless cast to size_t.
935 (mark_object_loop_halt): Mark as externally visible.
936
ac82cc6a
PE
937 * xselect.c: Integer signedness and overflow fixes.
938 (Fx_register_dnd_atom, x_handle_dnd_message):
939 Use ptrdiff_t, not size_t, since we prefer signed.
940 (Fx_register_dnd_atom): Check for ptrdiff_t (and size_t) overflow.
941 * xterm.h (struct x_display_info): Use ptrdiff_t, not size_t, for
942 x_dnd_atoms_size and x_dnd_atoms_length.
943
c2d1e36d
PE
944 * doprnt.c: Prefer signed to unsigned when either works.
945 * eval.c (verror):
946 * doprnt.c (doprnt):
947 * lisp.h (doprnt):
948 * xdisp.c (vmessage):
949 Use ptrdiff_t, not size_t, when using or implementing doprnt,
950 since the sizes cannot exceed ptrdiff_t bounds anyway, and we
951 prefer signed arithmetic to avoid comparison confusion.
952 * doprnt.c (doprnt): Avoid a "+ 1" that can't overflow,
953 but is a bit tricky.
954
0e926e56
PE
955 Assume freestanding C89 headers, string.h, stdlib.h.
956 * data.c, doprnt.c, floatfns.c, print.c:
957 Include float.h unconditionally.
958 * gmalloc.c: Assume C89-at-least behavior for preprocessor,
959 limits.h, stddef.h, string.h. Use memset instead of 'flood'.
960 * regex.c: Likewise for stddef.h, string.h.
961 (ISASCII): Remove; can assume it returns 1 now. All uses removed.
962 * s/aix4-2.h (HAVE_STRING_H): Remove obsolete undef.
963 * s/ms-w32.h (HAVE_LIMITS_H, HAVE_STRING_H, HAVE_STDLIB_H)
964 (STDC_HEADERS): Remove obsolete defines.
965 * sysdep.c: Include limits.h unconditionally.
966
9cfdb3ec
PE
967 Assume support for memcmp, memcpy, memmove, memset.
968 * lisp.h, sysdep.c (memcmp, memcpy, memmove, memset):
969 * regex.c (memcmp, memcpy):
970 Remove; we assume C89 now.
971
972 * gmalloc.c (memcpy, memset, memmove): Remove; we assume C89 now.
973 (__malloc_safe_bcopy): Remove; no longer needed.
974
cf950e6b 975 * lisp.h (struct vectorlike_header, struct Lisp_Subr): Signed sizes.
6089c567
PE
976 Use EMACS_INT, not EMACS_UINT, for sizes. The code works equally
977 well either way, and we prefer signed to unsigned.
978
dbf38e02
LMI
9792011-07-27 Lars Magne Ingebrigtsen <larsi@gnus.org>
980
981 * gnutls.c (emacs_gnutls_read): Don't message anything if the peer
982 closes the connection while we're reading (bug#9182).
983
d6f0886c
JD
9842011-07-25 Jan Djärv <jan.h.d@swipnet.se>
985
986 * nsmenu.m (ns_popup_dialog): Add an "ok" button if no buttons
987 are specified (Bug#9168).
988
2eb1f9e6
PE
9892011-07-25 Paul Eggert <eggert@cs.ucla.edu>
990
991 * bidi.c (bidi_dump_cached_states): Fix printf format mismatch.
992 Found by GCC static checking and --with-wide-int on a 32-bit host.
993
22381272 9942011-07-25 Eli Zaretskii <eliz@gnu.org>
7daee910
EZ
995
996 * xdisp.c (compute_display_string_pos): Fix logic of caching
997 previous display string position. Initialize cached_prev_pos to
998 -1. Fixes slow-down at the beginning of a buffer.
999
f25e39b4
EZ
10002011-07-24 Eli Zaretskii <eliz@gnu.org>
1001
1002 * xfaces.c (check_lface_attrs) [HAVE_WINDOW_SYSTEM]: Allow `nil'
1003 for attrs[LFACE_FONTSET_INDEX].
1004
04c4b52e
PE
10052011-07-23 Paul Eggert <eggert@cs.ucla.edu>
1006
1007 * xml.c (parse_region): Remove unused local
1008 that was recently introduced.
1009
c1734fbd
EZ
10102011-07-23 Eli Zaretskii <eliz@gnu.org>
1011
be18c5a5
EZ
1012 * xfns.c (unwind_create_frame) [GLYPH_DEBUG]: Adapt to changes in
1013 2008-02-22T17:42:09Z!monnier@iro.umontreal.ca.
1014
c1734fbd
EZ
1015 * xdisp.c (move_it_in_display_line_to): Record the best matching
1016 position for TO_CHARPOS while scanning the line, and restore it on
640c8776
SM
1017 exit if none of the characters scanned was an exact match.
1018 Fixes vertical-motion and pos-visible-in-window-p under bidi redisplay
a9269c18
EZ
1019 when exact match is impossible due to invisible text, and the
1020 lines are truncated.
1021
a258d627
JD
10222011-07-23 Jan Djärv <jan.h.d@swipnet.se>
1023
1024 * nsterm.m (initFrameFromEmacs): Set NSTitledWindowMask in styleMask
1025 for OSX >= 10.7.
1026
b6d5a689
EZ
10272011-07-22 Eli Zaretskii <eliz@gnu.org>
1028
0f74f785
EZ
1029 Fix a significant slow-down of cursor motion with C-n, C-p,
1030 C-f/C-b, and C-v/M-v that couldn't keep up with keyboard
1031 auto-repeat under bidi redisplay in fontified buffers.
b6d5a689 1032 * xdisp.c (compute_stop_pos_backwards): New function.
b6d5a689
EZ
1033 (next_element_from_buffer): Call compute_stop_pos_backwards to
1034 find a suitable prev_stop when we find ourselves before
0f74f785
EZ
1035 base_level_stop.
1036 (reseat): Don't look for prev_stop, as that could mean a very long
1037 run.
1038 <cached_disp_pos, cached_disp_buffer, cached_disp_modiff>
1039 <cached_disp_overlay_modiff>: Cache for last found display string
1040 position.
551918c1 1041 (compute_display_string_pos): Return the cached position if asked
0f74f785
EZ
1042 about the same buffer in the same area of character positions, and
1043 the buffer wasn't changed since the time the display string
1044 position was cached.
551918c1 1045
b2d0c91a
EZ
10462011-07-22 Eli Zaretskii <eliz@gnu.org>
1047
1048 * xdisp.c (rows_from_pos_range): Don't ignore glyphs whose object
1049 is an integer, which is important for empty lines. (Bug#9149)
1050
043604ee
CY
10512011-07-22 Chong Yidong <cyd@stupidchicken.com>
1052
1053 * frame.c (Fmodify_frame_parameters): In tty case, update the
1054 default face if necessary (Bug#4238).
1055
da4adb04
CY
10562011-07-21 Chong Yidong <cyd@stupidchicken.com>
1057
1058 * editfns.c (Fstring_to_char): No need to explain what a character
1059 is in the docstring (Bug#6576).
1060
9abd0532
LMI
10612011-07-20 Lars Magne Ingebrigtsen <larsi@gnus.org>
1062
1063 * xml.c (parse_region): Make sure we always return a tree.
1064
36881d16
HK
10652011-07-20 HAMANO Kiyoto <khiker.mail@gmail.com>
1066
1067 * xml.c (parse_region): If a document contains only comments,
1068 return that, too.
1069
1e98674d
LMI
10702011-07-20 Lars Magne Ingebrigtsen <larsi@gnus.org>
1071
1072 * xml.c (make_dom): Return comments, too.
1073
590bd467
PE
10742011-07-19 Paul Eggert <eggert@cs.ucla.edu>
1075
1076 Port to OpenBSD.
1077 See http://lists.gnu.org/archive/html/emacs-devel/2011-07/msg00688.html
1078 and the surrounding thread.
1079 * minibuf.c (read_minibuf_noninteractive): Rewrite to use getchar
1080 rather than fgets, and retry after EINTR. Otherwise, 'emacs
1081 --batch -f byte-compile-file' fails on OpenBSD if an inactivity
1082 timer goes off.
1083 * s/openbsd.h (BROKEN_SIGIO): Define.
1084 * unexelf.c (unexec) [__OpenBSD__]:
1085 Don't update the .mdebug section of the Alpha COFF symbol table.
1086
f41628b2
LMI
10872011-07-19 Lars Magne Ingebrigtsen <larsi@gnus.org>
1088
1089 * lread.c (syms_of_lread): Clarify when `lexical-binding' is used
1090 (bug#8460).
1091
b59b67c5
PE
10922011-07-18 Paul Eggert <eggert@cs.ucla.edu>
1093
15e3a074
PE
1094 * fileio.c (Fcopy_file) [!MSDOS]: Tighten created file's mask.
1095 This fixes some race conditions on the permissions of any newly
1096 created file.
1097
41bed37d
PE
1098 * alloc.c (valid_pointer_p): Use pipe, not open.
1099 This fixes some permissions issues when debugging.
1100
b59b67c5
PE
1101 * fileio.c (Fcopy_file): Adjust mode if fchown fails. (Bug#9002)
1102 If fchown fails to set both uid and gid, try to set just gid,
1103 as that is sometimes allowed. Adjust the file's mode to eliminate
1104 setuid or setgid bits that are inappropriate if fchown fails.
1105
925a6be7
SM
11062011-07-18 Stefan Monnier <monnier@iro.umontreal.ca>
1107
1108 * xdisp.c (next_element_from_string, next_element_from_buffer): Use EQ
1109 to compare Lisp_Objects.
1110 * gnutls.c (syms_of_gnutls): Rename Vgnutls_log_level to
1111 global_gnutls_log_level, don't mistake it for a Lisp_Object.
1112 (init_gnutls_functions, emacs_gnutls_handle_error): Fix up uses.
1113
52968808
AS
11142011-07-17 Andreas Schwab <schwab@linux-m68k.org>
1115
0a6a104b
AS
1116 * lread.c (read_integer): Unread even EOF character.
1117 (read1): Likewise. Properly record start position of symbol.
1118
52968808
AS
1119 * lread.c (read1): Read `#:' as empty uninterned symbol if no
1120 symbol character follows.
1121
9e381cdd
PE
11222011-07-17 Paul Eggert <eggert@cs.ucla.edu>
1123
1124 * fileio.c (Fcopy_file): Pacify gcc re fchown. (Bug#9002)
1125 This works around a problem with the previous change to Fcopy_file.
1126 Recent glibc declares fchown with __attribute__((warn_unused_result)),
1127 and without this change, GCC might complain about discarding
1128 fchown's return value.
1129
b5641435
JB
11302011-07-16 Juanma Barranquero <lekktu@gmail.com>
1131
1132 * makefile.w32-in (GLOBAL_SOURCES): Add gnutls.c (followup to bug#9059).
1133
a8031457
PE
11342011-07-16 Paul Eggert <eggert@cs.ucla.edu>
1135
1136 * fileio.c (Fcopy_file): Don't diagnose fchown failures. (Bug#9002)
1137
dd889327
LMI
11382011-07-16 Lars Magne Ingebrigtsen <larsi@gnus.org>
1139
750c33f7
LMI
1140 * gnutls.c (syms_of_gnutls): Define `gnutls-log-level' here, since
1141 it's used from the C level.
1142
dd889327
LMI
1143 * process.c: Use the same condition for POLL_FOR_INPUT in both
1144 keyboard.c and process.c (bug#1858).
1145
87e86684
LM
11462011-07-09 Lawrence Mitchell <wence@gmx.li>
1147
1148 * gnutls.c (Qgnutls_bootprop_min_prime_bits): New variable.
1149 (Fgnutls_boot): Use it.
1150
64348f40
AS
11512011-07-15 Andreas Schwab <schwab@linux-m68k.org>
1152
1153 * doc.c (Fsubstitute_command_keys): Revert last change.
1154
1d698799
LMI
11552011-07-15 Lars Magne Ingebrigtsen <larsi@gnus.org>
1156
f863868c
LMI
1157 * doc.c (Fsubstitute_command_keys): Clarify that \= really only
1158 quotes the next character, and doesn't affect other longer
1159 sequences (bug#8935).
1160
1d698799
LMI
1161 * lread.c (syms_of_lread): Clarify that is isn't only
1162 `eval-buffer' and `eval-defun' that's affected by
1163 `lexical-binding' (bug#8460).
1164
aa4b6df6
EZ
11652011-07-15 Eli Zaretskii <eliz@gnu.org>
1166
1167 * xdisp.c (move_it_in_display_line_to): Fix vertical motion with
1168 bidi redisplay when a line includes both an image and is
1169 truncated.
1170
5d856da6
PE
11712011-07-14 Paul Eggert <eggert@cs.ucla.edu>
1172
ad6042bb
PE
1173 Fix minor problems found by static checking.
1174 * bidi.c (bidi_cache_size): Now EMACS_INT, not size_t.
1175 (elsz): Now a signed constant, not a size_t var. We prefer signed
1176 types to unsigned, to avoid integer comparison confusion. Without
1177 this change, GCC 4.6.1 with -Wunsafe-loop-optimizations complains
1178 "cannot optimize loop, the loop counter may overflow", a symptom
1179 of the confusion.
f00bbb22 1180 * indent.c (Fvertical_motion): Mark locals as initialized.
5d856da6
PE
1181 * xdisp.c (reseat_to_string): Fix pointer signedness issue.
1182
6468f31c
LMI
11832011-07-14 Lars Magne Ingebrigtsen <larsi@gnus.org>
1184
49080b10
LMI
1185 * search.c (Fre_search_backward): Mention `case-fold-search' in
1186 all the re_search_* functions (bug#8138).
1187
6468f31c
LMI
1188 * keyboard.c (Fopen_dribble_file): Document when the file is
1189 closed (bug#8056).
1190
c965adc5
EZ
11912011-07-14 Eli Zaretskii <eliz@gnu.org>
1192
df9733bf
EZ
1193 * bidi.c (bidi_dump_cached_states): Fix format of displaying
1194 bidi_cache_idx.
1195
0bb23927
EZ
1196 Support bidi reordering of display and overlay strings.
1197 * xdisp.c (compute_display_string_pos)
1198 (compute_display_string_end): Accept additional argument STRING.
1199 (init_iterator, reseat_1): Initialize bidi_it->string.s to NULL.
1200 (reseat_to_string): Initialize bidi_it->string.s and
1201 bidi_it->string.schars.
1202 (Fcurrent_bidi_paragraph_direction): Initialize itb.string.s to
640c8776
SM
1203 NULL (avoids a crash in bidi_paragraph_init).
1204 Initialize itb.string.lstring.
0bb23927
EZ
1205 (init_iterator): Call bidi_init_it only of a valid
1206 buffer position was specified. Initialize paragraph_embedding to
1207 L2R.
1208 (reseat_to_string): Initialize the bidi iterator.
1209 (display_string): If we need to ignore text properties of
1210 LISP_STRING, set IT->stop_charpos to IT->end_charpos. (The
1211 original value of -1 will not work with bidi.)
1212 (compute_display_string_pos): First arg is now struct
1213 `text_pos *'; all callers changed. Support display properties on
1214 Lisp strings.
1215 (compute_display_string_end): Support display properties on Lisp
1216 strings.
1217 (init_iterator, reseat_1, reseat_to_string): Initialize the
1218 string.bufpos member to 0 (zero, for compatibility with IT_CHARPOS
1219 when iterating on a string not from display properties).
640c8776
SM
1220 (compute_display_string_pos, compute_display_string_end):
1221 Fix calculation of the object to scan. Fixes an error when using
0bb23927
EZ
1222 arrow keys.
1223 (next_element_from_buffer): Don't abort when IT_CHARPOS is before
640c8776
SM
1224 base_level_stop; instead, set base_level_stop to BEGV.
1225 Fixes crashes in vertical-motion.
0bb23927
EZ
1226 (next_element_from_buffer): Improve commentary for when
1227 the iterator is before prev_stop.
1228 (init_iterator): Initialize bidi_p from the default value of
1229 bidi-display-reordering, not from buffer-local value. Use the
1230 buffer-local value only if initializing for buffer iteration.
1231 (handle_invisible_prop): Support invisible properties on strings
1232 that are being bidi-reordered.
1233 (set_iterator_to_next): Support bidi reordering of C strings and
1234 Lisp strings.
1235 (next_element_from_string): Support bidi reordering of Lisp
1236 strings.
1237 (handle_stop_backwards): Support Lisp strings as well.
640c8776
SM
1238 (display_string): Support display of R2L glyph rows.
1239 Use IT_STRING_CHARPOS when displaying from a Lisp string.
0bb23927
EZ
1240 (init_iterator): Don't initialize it->bidi_p for strings
1241 here.
1242 (reseat_to_string): Initialize it->bidi_p for strings here.
1243 (next_element_from_string, next_element_from_c_string)
1244 (next_element_from_buffer): Add xassert's for correspondence
1245 between IT's object being iterated and it->bidi_it.string
1246 structure.
1247 (face_before_or_after_it_pos): Support bidi iteration.
1248 (next_element_from_c_string): Handle the case of the first string
1249 character that is not the first one in the visual order.
1250 (get_visually_first_element): New function, refactored from common
1251 parts of next_element_from_buffer, next_element_from_string, and
1252 next_element_from_c_string.
1253 (tool_bar_lines_needed, redisplay_tool_bar)
1254 (display_menu_bar): Force left-to-right direction. Add a FIXME
1255 comment for making that be controlled by a user option.
1256 (push_it, pop_it): Save and restore the state of the
1257 bidi iterator. Save and restore the bidi_p flag.
1258 (pop_it): Iterate out of display property for string iteration as
1259 well.
1260 (iterate_out_of_display_property): Support iteration over strings.
1261 (handle_single_display_spec): Set up it->bidi_it for iteration
1262 over a display string, and call bidi_init_it.
1263 (handle_single_display_spec, next_overlay_string)
1264 (get_overlay_strings_1, push_display_prop): Set up the bidi
1265 iterator for displaying display or overlay strings.
1266 (forward_to_next_line_start): Don't use the shortcut if
1267 bidi-iterating.
1268 (back_to_previous_visible_line_start): If handle_display_prop
1269 pushed the iterator stack, restore the internal state of the bidi
1270 iterator by calling bidi_pop_it same number of times.
1271 (reseat_at_next_visible_line_start): If ON_NEWLINE_P is non-zero,
1272 and we are bidi-iterating, don't decrement the iterator position;
1273 instead, set the first_elt flag in the bidi iterator, to produce
1274 the same effect.
1275 (reseat_1): Remove redundant setting of string_from_display_prop_p.
1276 (push_display_prop): xassert that we are iterating a buffer.
1277 (push_it, pop_it): Save and restore paragraph_embedding member.
1278 (handle_single_display_spec, next_overlay_string)
1279 (get_overlay_strings_1, reseat_1, reseat_to_string)
1280 (push_display_prop): Set up the `unibyte' member of bidi_it.string
1281 correctly. Don't assume unibyte strings are not bidi-reordered.
1282 (compute_display_string_pos)
1283 (compute_display_string_end): Fix handling the case of C string.
1284 (push_it, pop_it): Save and restore from_disp_prop_p.
1285 (handle_single_display_spec, push_display_prop): Set the
1286 from_disp_prop_p flag.
1287 (get_overlay_strings_1): Reset the from_disp_prop_p flag.
1288 (pop_it): Call iterate_out_of_display_property only if we are
1289 popping after iteration over a string that came from a display
1290 property. Fix a typo in popping stretch info. Add an assertion
1291 for verifying that the iterator position is in sync with the bidi
1292 iterator.
1293 (handle_single_display_spec, get_overlay_strings_1)
1294 (push_display_prop): Fix initialization of paragraph direction for
1295 string when that of the parent object is not yet determined.
1296 (reseat_1): Call bidi_init_it to resync the bidi
1297 iterator with IT's position. (Bug#7616)
1298 (find_row_edges): If ROW->start.pos gives position
1299 smaller than min_pos, use it as ROW->minpos. (Bug#7616)
1300 (handle_stop, back_to_previous_visible_line_start, reseat_1):
1301 Reset the from_disp_prop_p flag.
1302 (SAVE_IT, RESTORE_IT): New macros.
1303 (pos_visible_p, face_before_or_after_it_pos)
1304 (back_to_previous_visible_line_start)
1305 (move_it_in_display_line_to, move_it_in_display_line)
1306 (move_it_to, move_it_vertically_backward, move_it_by_lines)
1307 (try_scrolling, redisplay_window, display_line): Use them when
1308 saving a temporary copy of the iterator and restoring it back.
1309 (back_to_previous_visible_line_start, reseat_1)
1310 (init_iterator): Empty the bidi cache "stack".
1311 (move_it_in_display_line_to): If iterator ended up at
1312 EOL, but we never saw any buffer positions smaller than
1313 to_charpos, return MOVE_POS_MATCH_OR_ZV. Fixes vertical cursor
1314 motion in bidi-reordered lines.
1315 (move_it_in_display_line_to): Record prev_method and prev_pos
1316 immediately before the call to set_iterator_to_next. Fixes cursor
1317 motion in bidi-reordered lines with stretch glyphs and strings
1318 displayed in margins. (Bug#8133) (Bug#8867)
1319 Return MOVE_POS_MATCH_OR_ZV only if iterator position is past
1320 TO_CHARPOS.
640c8776
SM
1321 (pos_visible_p): Support positions in bidi-reordered lines.
1322 Save and restore bidi cache.
0bb23927
EZ
1323
1324 * bidi.c (bidi_level_of_next_char): clen should be EMACS_NT, not int.
1325 (bidi_paragraph_info): Delete unused struct.
1326 (bidi_cache_idx, bidi_cache_last_idx): Declare EMACS_INT.
1327 (bidi_cache_start): New variable.
1328 (bidi_cache_reset): Reset bidi_cache_idx to bidi_cache_start, not
1329 to zero.
1330 (bidi_cache_fetch_state, bidi_cache_search)
1331 (bidi_cache_find_level_change, bidi_cache_iterator_state)
1332 (bidi_cache_find, bidi_peek_at_next_level)
1333 (bidi_level_of_next_char, bidi_find_other_level_edge)
1334 (bidi_move_to_visually_next): Compare cache index with
1335 bidi_cache_start rather than with zero.
1336 (bidi_fetch_char): Accept new argument STRING; all callers
1337 changed. Support iteration over a string. Support strings with
1338 display properties. Support unibyte strings. Fix the type of
1339 `len' according to what STRING_CHAR_AND_LENGTH expects.
1340 (bidi_paragraph_init, bidi_resolve_explicit_1)
1341 (bidi_resolve_explicit, bidi_resolve_weak)
640c8776
SM
1342 (bidi_level_of_next_char, bidi_move_to_visually_next):
1343 Support iteration over a string.
0bb23927
EZ
1344 (bidi_set_sor_type, bidi_resolve_explicit_1)
1345 (bidi_resolve_explicit, bidi_type_of_next_char): ignore_bn_limit
1346 can now be zero (for strings); special values 0 and -1 were
1347 changed to -1 and -2, respectively.
1348 (bidi_char_at_pos): New function.
1349 (bidi_paragraph_init, bidi_resolve_explicit, bidi_resolve_weak):
1350 Call it instead of FETCH_MULTIBYTE_CHAR.
1351 (bidi_move_to_visually_next): Abort if charpos or bytepos were not
1352 initialized to valid values.
1353 (bidi_init_it): Don't initialize charpos and bytepos with invalid
1354 values.
1355 (bidi_level_of_next_char): Allow the sentinel "position" to pass
1356 the test for valid cached positions. Fix the logic for looking up
1357 the sentinel state in the cache. GCPRO the Lisp string we are
1358 iterating.
1359 (bidi_push_it, bidi_pop_it): New functions.
1360 (bidi_initialize): Initialize the bidi cache start stack pointer.
1361 (bidi_cache_ensure_space): New function, refactored from part of
1362 bidi_cache_iterator_state. Don't assume the required size is just
1363 one BIDI_CACHE_CHUNK away.
1364 (bidi_cache_start_stack, bidi_push_it): Use IT_STACK_SIZE.
1365 (bidi_count_bytes, bidi_char_at_pos): New functions.
1366 (bidi_cache_search): Don't assume bidi_cache_last_idx is
1367 always valid if bidi_cache_idx is valid.
1368 (bidi_cache_find_level_change): xassert that bidi_cache_last_idx
1369 is valid if it's going to be used.
1370 (bidi_shelve_cache, bidi_unshelve_cache): New functions.
1371 (bidi_cache_fetch_state, bidi_cache_search)
c965adc5
EZ
1372 (bidi_cache_find_level_change, bidi_cache_ensure_space)
1373 (bidi_cache_iterator_state, bidi_cache_find)
640c8776
SM
1374 (bidi_find_other_level_edge, bidi_cache_start_stack):
1375 All variables related to cache indices are now EMACS_INT.
c965adc5 1376
0bb23927
EZ
1377 * dispextern.h (struct bidi_string_data): New structure.
1378 (struct bidi_it): New member `string'. Make flag members be 1-bit
1379 fields, and put them last in the struct.
640c8776
SM
1380 (compute_display_string_pos, compute_display_string_end):
1381 Update prototypes.
0bb23927
EZ
1382 (bidi_push_it, bidi_pop_it): Add prototypes.
1383 (struct iterator_stack_entry): New members bidi_p,
1384 paragraph_embedding, and from_disp_prop_p.
1385 (struct it): Member bidi_p is now a bit field 1 bit wide.
640c8776
SM
1386 (bidi_shelve_cache, bidi_unshelve_cache):
1387 Declare prototypes.
0bb23927
EZ
1388
1389 * .gdbinit (xvectype, xvector, xcompiled, xchartable, xboolvector)
1390 (xpr, xfont, xbacktrace): Use "header.size" when accessing vectors
1391 and vector-like objects.
1392
1393 * dispnew.c (buffer_posn_from_coords): Save and restore the bidi
1394 cache around display iteration.
1395
1396 * window.c (Fwindow_end, window_scroll_pixel_based)
1397 (displayed_window_lines, Frecenter): Save and restore the bidi
1398 cache around display iteration.
1399
3bbd2265
LMI
14002011-07-14 Lars Magne Ingebrigtsen <larsi@gnus.org>
1401
1402 * editfns.c (Fdelete_region): Clarify the use of the named
1403 parameters (bug#6788).
1404
adc47434
MR
14052011-07-14 Martin Rudalics <rudalics@gmx.at>
1406
1407 * indent.c (Fvertical_motion): Set and restore w->pointm when
1408 saving and restoring the window's buffer (Bug#9006).
1409
837c31f8
LMI
14102011-07-13 Lars Magne Ingebrigtsen <larsi@gnus.org>
1411
1412 * editfns.c (Fstring_to_char): Clarify just what is returned
1413 (bug#6576). Text by Eli Zaretskii.
1414
ac389d0c
JB
14152011-07-13 Juanma Barranquero <lekktu@gmail.com>
1416
1417 * gnutls.c (init_gnutls_functions): Honor gnutls_log_level (bug#9059).
1418
0be0ce47
EZ
14192011-07-13 Eli Zaretskii <eliz@gnu.org>
1420
1421 * buffer.c (mmap_find): Fix a typo.
1422
cd18e7e3
JB
14232011-07-13 Johan Bockgård <bojohan@gnu.org>
1424
1425 Fix execution of x selection hooks.
1426 * xselect.c (Qx_lost_selection_functions)
1427 (Qx_sent_selection_functions): New vars.
1428 (syms_of_xselect): DEFSYM them.
1429 (x_handle_selection_request): Pass Qx_sent_selection_functions
1430 rather than Vx_sent_selection_functions to Frun_hook_with_args.
1431 (x_handle_selection_clear,x_clear_frame_selections):
1432 Pass Qx_lost_selection_functions rather than
1433 Vx_lost_selection_functions to Frun_hook_with_args.
1434
47ea7f44
PE
14352011-07-13 Paul Eggert <eggert@cs.ucla.edu>
1436
ac389d0c 1437 * buffer.c (Fget_buffer_create): Initialize inhibit_shrinking.
2941c447
PE
1438 The old code sometimes used this field without initializing it.
1439
47ea7f44
PE
1440 * alloc.c (gc_sweep): Don't read past end of array.
1441 In theory, the old code could also have corrupted Emacs internals,
1442 though it'd be very unlikely.
1443
bc985c87
AS
14442011-07-12 Andreas Schwab <schwab@linux-m68k.org>
1445
1446 * character.c (Fcharacterp): Don't advertise optional ignored
ac389d0c 1447 argument. (Bug#4026)
bc985c87 1448
0cf34688
LMI
14492011-07-12 Lars Magne Ingebrigtsen <larsi@gnus.org>
1450
b3dadd76
LMI
1451 * keymap.c (syms_of_keymap): Clarify that "modifier" is "modifier
1452 key" (bug#4257).
1453
0cf34688
LMI
1454 * window.c (Fset_window_start): Doc fix (bug#4199).
1455 (Fset_window_hscroll): Ditto.
1456
270768cd
PE
14572011-07-12 Paul Eggert <eggert@cs.ucla.edu>
1458
077e3dda 1459 Fix minor new problems caught by GCC 4.6.1.
270768cd 1460 * term.c (init_tty): Remove unused local.
490011a6 1461 * xsettings.c (store_monospaced_changed): Define this function only
077e3dda 1462 if (defined HAVE_GSETTINGS || defined HAVE_GCONF), as it's
490011a6 1463 not used otherwise.
270768cd 1464
b1f58454
CY
14652011-07-12 Chong Yidong <cyd@stupidchicken.com>
1466
1467 * xdisp.c (Vresize_mini_windows): Minor doc fix (Bug#3300).
1468
22b9578d
LMI
14692011-07-11 Lars Magne Ingebrigtsen <larsi@gnus.org>
1470
6e70ab07
LMI
1471 * xdisp.c (syms_of_xdisp): Make it explicit that the mini-windows
1472 are the mini-buffer and the echo area (bug#3320).
1473
22b9578d
LMI
1474 * term.c (init_tty): Remove support for supdup, c10 and perq
1475 terminals, which are no longer supported (bug#1482).
1476
8974cc9f
JB
14772011-07-10 Johan Bockgård <bojohan@gnu.org>
1478
1479 * xdisp.c (Ftool_bar_lines_needed): Fix WINDOWP check.
1480
a560d974
JD
14812011-07-10 Jan Djärv <jan.h.d@swipnet.se>
1482
1483 * xmenu.c (menu_highlight_callback): Only pass frame to show_help_event
1484 for non-popups (Bug#3642).
1485
1dae0f0a
AS
14862011-07-10 Andreas Schwab <schwab@linux-m68k.org>
1487
268c2c36 1488 * alloc.c (reset_malloc_hooks): Protoize.
1dae0f0a 1489 * buffer.c (mmap_init, mmap_find, mmap_free_1, mmap_enlarge)
268c2c36
AS
1490 (mmap_set_vars, mmap_alloc, mmap_free, mmap_realloc): Likewise.
1491 * cm.c (losecursor): Likewise.
1dae0f0a
AS
1492 * data.c (fmod): Likewise.
1493 * dispnew.c (swap_glyphs_in_rows): Likewise.
1494 * emacs.c (memory_warning_signal): Likewise.
1495 * floatfns.c (float_error): Likewise.
1496 * font.c (check_gstring, check_otf_features, otf_tag_symbol)
1497 (otf_open, font_otf_capability, generate_otf_features)
1498 (font_otf_DeviceTable, font_otf_ValueRecord, font_otf_Anchor):
1499 Likewise.
1500 * image.c (pbm_read_file): Likewise.
1501 * indent.c (string_display_width): Likewise.
1502 * intervals.c (check_for_interval, search_for_interval)
1503 (inc_interval_count, count_intervals, root_interval)
1504 (adjust_intervals_for_insertion, make_new_interval): Likewise.
1505 * lread.c (defalias): Likewise.
268c2c36 1506 * ralloc.c (r_alloc_check): Likewise.
1dae0f0a
AS
1507 * regex.c (set_image_of_range_1, set_image_of_range)
1508 (regex_grow_registers): Likewise.
1509 * sysdep.c (strerror): Likewise.
1510 * termcap.c (valid_filename_p, tprint, main): Likewise.
1511 * tparam.c (main): Likewise.
1512 * unexhp9k800.c (run_time_remap, save_data_space)
1513 (update_file_ptrs, read_header, write_header, calculate_checksum)
1514 (copy_file, copy_rest, display_header): Likewise.
1515 * widget.c (mark_shell_size_user_specified, create_frame_gcs):
1516 Likewise.
1517 * xdisp.c (check_it): Likewise.
1518 * xfaces.c (register_color, unregister_color, unregister_colors):
1519 Likewise.
1520 * xfns.c (print_fontset_result): Likewise.
1521 * xrdb.c (member, fatal, main): Likewise.
1522
99033785
PE
15232011-07-10 Paul Eggert <eggert@cs.ucla.edu>
1524
1525 Fix minor problems found by static checking (Bug#9031).
1526 * chartab.c (char_table_set_range, map_sub_char_table):
1527 Remove unused locals.
1528 (uniprop_table): Now static.
1529 * composite.c (_work_char): Remove unused static var.
1530
9cb2ac56
JB
15312011-07-09 Juanma Barranquero <lekktu@gmail.com>
1532
1533 * chartab.c (uniprop_table_uncompress): Remove unused local variable.
1534
f25661f0
JD
15352011-07-09 Jan Djärv <jan.h.d@swipnet.se>
1536
1537 * gtkutil.c (qttip_cb): Remove code without function.
1538
8278c4fe
EZ
15392011-07-09 Eli Zaretskii <eliz@gnu.org>
1540
1541 * w32.c (pthread_sigmask): New stub.
1542
1692ae2d 15432011-07-08 Paul Eggert <eggert@cs.ucla.edu>
123403e4 1544
8a6ebd58 1545 Use pthread_sigmask, not sigprocmask (Bug#9010).
123403e4
PE
1546 sigprocmask is portable only for single-threaded applications, and
1547 Emacs can be multi-threaded when it uses GTK.
1301ac26
PE
1548 * Makefile.in (LIB_PTHREAD_SIGMASK): New macro.
1549 (LIBES): Use it.
1550 * callproc.c (Fcall_process):
1551 * process.c (create_process):
1552 * sysdep.c (sys_sigblock, sys_sigunblock, sys_sigsetmask):
1553 Use pthread_sigmask, not sigprocmask.
123403e4 1554
1b854618
JD
15552011-07-08 Jan Djärv <jan.h.d@swipnet.se>
1556
1557 * gtkutil.c (qttip_cb): Set line wrap to FALSE for tooltip widget.
1558 (xg_prepare_tooltip): Revert text in x->ttip_lbl, margins was
1559 wrong (Bug#8591).
1560
3fe4b549
JD
15612011-07-08 Jan Djärv <jan.h.d@swipnet.se>
1562
0ce7e563
JD
1563 * gtkutil.c (xg_prepare_tooltip): Fix indentation and comment.
1564 Put text in x->ttip_lbl instead of gtk_tooltip_set_text (Bug#8591).
1565 (xg_hide_tooltip): Fix comment.
1566
3fe4b549
JD
1567 * nsterm.m (initFrameFromEmacs): Don't use ns_return_types
1568 in registerServicesMenuSendTypes.
1569 (validRequestorForSendType): Don't check ns_return_types.
1570
1571 * nsfns.m (Fx_open_connection): Put NSStringPboardType into
1572 ns_return_type.
1573
5df75e47
JR
15742011-07-08 Jason Rumney <jasonr@gnu.org>
1575
1576 * w32fns.c (w32_wnd_proc) [WM_TIMER, WM_SET_CURSOR]: Avoid using
1577 frame struct members of non-existent frames (Bug#6284).
1578
699c10bd
JD
15792011-07-08 Jan Djärv <jan.h.d@swipnet.se>
1580
4393663b
JD
1581 * nsterm.m (keyDown): Call to wantsToDelayTextChangeNotifications and
1582 variable firstTime not needed on OSX >= 10.6.
1583 (setPosition): setFloatValue:knobProportion: is deprecated on OSX
1584 >= 10.5. Use setKnobProportion, setDoubleValue.
1585
1586 * nsterm.h (MAC_OS_X_VERSION_10_3, MAC_OS_X_VERSION_10_4)
1587 (MAC_OS_X_VERSION_10_5): Define if not defined.
1588 (EmacsView, EmacsTooltip): Implements NSWindowDelegate on OSX >= 10.6.
1589 (EmacsMenu): Implements NSMenuDelegate on OSX >= 10.6.
1590 (EmacsToolbar): Implements NSToolbarDelegate on OSX >= 10.6.
1591
1592 * nsselect.m (ns_string_from_pasteboard): Don't use deprecated methods
1593 cString and lossyCString on OSX >= 10.4
1594
1595 * nsmenu.m (fillWithWidgetValue): Don't use depercated method
1596 sizeToFit on OSX >= 10.2.
1597
1598 * nsimage.m (allocInitFromFile): Don't use deprecated method
1599 bestRepresentationForDevice on OSX >= 10.6.
1600
1601 * nsfns.m (check_ns_display_info): Cast to long and use %ld in error
1602 to avoid warning.
1603
1604 * emacs.c: Declare unexec_init_emacs_zone.
1605
a63e0781
JD
1606 * nsgui.h: Fix compiler warning about gnulib redefining verify.
1607
699c10bd
JD
1608 * nsselect.m (ns_get_local_selection): Change to extern (Bug#8842).
1609
1610 * nsmenu.m (ns_update_menubar): Remove useless setDelegate call
1611 on svcsMenu (Bug#8842).
1612
1613 * nsfns.m (Fx_open_connection): Remove NSStringPboardType from
1614 ns_return_types.
1615 (Fns_list_services): Just return Qnil on 10.6, code not working there.
1616
1617 * nsterm.m (QUTF8_STRING): Declare.
1618 (initFrameFromEmacs): Call registerServicesMenuSendTypes.
1619 (validRequestorForSendType): Return type is (id).
1620 Change indexOfObjectIdenticalTo to indexOfObject.
1621 Check if we have local selection before returning self (Bug#8842).
1622 (writeSelectionToPasteboard): Put local selection into paste board
1623 if we have a local selection (Bug#8842).
1624 (syms_of_nsterm): DEFSYM QUTF8_STRING.
1625
1626 * nsterm.h (MAC_OS_X_VERSION_10_6): Define here instead of nsterm.m.
1627 (ns_get_local_selection): Declare.
1628
54e10184
LMI
16292011-07-07 Lars Magne Ingebrigtsen <larsi@gnus.org>
1630
9888ff71
LMI
1631 * keymap.c (describe_map_tree): Don't insert a double newline at
1632 the end of the buffer (bug#1169) and return whether we inserted
1633 something.
1634
54e10184
LMI
1635 * callint.c (Fcall_interactively): Change "reading args" to
1636 "providing args" to try to clarify what it does (bug#1010).
1637
15fa4783
KH
16382011-07-07 Kenichi Handa <handa@m17n.org>
1639
1640 * composite.c (composition_compute_stop_pos): Ignore a static
1641 composition starting before CHARPOS (Bug#8915).
1642
1643 * xdisp.c (handle_composition_prop): Likewise.
1644
a8815b00
EZ
16452011-07-07 Eli Zaretskii <eliz@gnu.org>
1646
1647 * term.c (produce_glyphs) <xassert>: Allow IT_GLYPHLESS in it->what.
1648 (Bug#9015)
1649
ef7b981d 16502011-07-07 Kenichi Handa <handa@m17n.org>
c805dec0
KH
1651
1652 * character.h (unicode_category_t): New enum type.
1653
1654 * chartab.c (uniprop_decoder_t, uniprop_encoder_t): New types.
1655 (Qchar_code_property_table): New variable.
1656 (UNIPROP_TABLE_P, UNIPROP_GET_DECODER)
1657 (UNIPROP_COMPRESSED_FORM_P): New macros.
1658 (char_table_ascii): Uncompress the compressed values.
1659 (sub_char_table_ref): New arg is_uniprop. Callers changed.
1660 Uncompress the compressed values.
ac389d0c 1661 (sub_char_table_ref_and_range): Likewise.
c805dec0
KH
1662 (char_table_ref_and_range): Uncompress the compressed values.
1663 (sub_char_table_set): New arg is_uniprop. Callers changed.
1664 Uncompress the compressed values.
1665 (sub_char_table_set_range): Args changed. Callers changed.
1666 (char_table_set_range): Adjuted for the above change.
1667 (map_sub_char_table): Delete args default_val and parent. Add arg
1668 top. Give decoded values to a Lisp function.
640c8776 1669 (map_char_table): Adjust for the above change. Give decoded
c805dec0
KH
1670 values to a Lisp function. Gcpro more variables.
1671 (uniprop_table_uncompress)
1672 (uniprop_decode_value_run_length): New functions.
1673 (uniprop_decoder, uniprop_decoder_count): New variables.
1674 (uniprop_get_decoder, uniprop_encode_value_character)
1675 (uniprop_encode_value_run_length, uniprop_encode_value_numeric):
1676 New functions.
1677 (uniprop_encoder, uniprop_encoder_count): New variables.
1678 (uniprop_get_encoder, uniprop_table)
1679 (Funicode_property_table_internal, Fget_unicode_property_internal)
1680 (Fput_unicode_property_internal): New functions.
1681 (syms_of_chartab): DEFSYM Qchar_code_property_table, defsubr
1682 Sunicode_property_table_internal, Sget_unicode_property_internal,
1683 and Sput_unicode_property_internal. Defvar_lisp
1684 char-code-property-alist.
1685
640c8776 1686 * composite.c (CHAR_COMPOSABLE_P): Adjust for the change of
c805dec0
KH
1687 Vunicode_category_table.
1688
640c8776 1689 * font.c (font_range): Adjust for the change of
c805dec0
KH
1690 Vunicode_category_table.
1691
76b397fb
DN
16922011-07-07 Dan Nicolaescu <dann@ics.uci.edu>
1693
1694 * m/iris4d.h: Remove file, move contents ...
1695 * s/irix6-5.h: ... here.
1696
22b4128e
PE
16972011-07-06 Paul Eggert <eggert@cs.ucla.edu>
1698
1699 Remove unportable assumption about struct layout (Bug#8884).
8a5c77bb
PE
1700 * alloc.c (mark_buffer):
1701 * buffer.c (reset_buffer_local_variables, Fbuffer_local_variables)
1702 (clone_per_buffer_values): Don't assume that
22b4128e
PE
1703 sizeof (struct buffer) is a multiple of sizeof (Lisp_Object).
1704 This isn't true in general, and it's particularly not true
1705 if Emacs is configured with --with-wide-int.
1706 * buffer.h (FIRST_FIELD_PER_BUFFER, LAST_FIELD_PER_BUFFER):
1707 New macros, used in the buffer.c change.
1708
869795d6
JD
17092011-07-05 Jan Djärv <jan.h.d@swipnet.se>
1710
1711 * xsettings.c: Use both GConf and GSettings if both are available.
1712 (store_config_changed_event): Add comment.
1713 (dpyinfo_valid, store_font_name_changed, map_tool_bar_style)
1714 (store_tool_bar_style_changed): New functions.
1715 (store_monospaced_changed): Add comment. Call dpyinfo_valid.
1716 (struct xsettings): Move font inside HAVE_XFT.
1717 (GSETTINGS_TOOL_BAR_STYLE, GSETTINGS_FONT_NAME): New defines.
640c8776 1718 (GSETTINGS_MONO_FONT): Rename from SYSTEM_MONO_FONT.
869795d6 1719 Move inside HAVE_XFT.
640c8776 1720 (something_changed_gsettingsCB): Rename from something_changedCB.
869795d6
JD
1721 Check for changes in GSETTINGS_TOOL_BAR_STYLE and GSETTINGS_FONT_NAME
1722 also.
1723 (GCONF_TOOL_BAR_STYLE, GCONF_FONT_NAME): New defines.
640c8776
SM
1724 (GCONF_MONO_FONT): Rename from SYSTEM_MONO_FONT. Move inside HAVE_XFT.
1725 (something_changed_gconfCB): Rename from something_changedCB.
869795d6
JD
1726 Check for changes in GCONF_TOOL_BAR_STYLE and GCONF_FONT_NAME also.
1727 (parse_settings): Move check for font inside HAVE_XFT.
1728 (read_settings, apply_xft_settings): Add comment.
1729 (read_and_apply_settings): Add comment. Call map_tool_bar_style and
1730 store_tool_bar_style_changed. Move check for font inside HAVE_XFT and
1731 call store_font_name_changed.
1732 (xft_settings_event): Add comment.
1733 (init_gsettings): Add comment. Get values for GSETTINGS_TOOL_BAR_STYLE
1734 and GSETTINGS_FONT_NAME. Move check for fonts within HAVE_XFT.
1735 (init_gconf): Add comment. Get values for GCONF_TOOL_BAR_STYLE
1736 and GCONF_FONT_NAME. Move check for fonts within HAVE_XFT.
1737 (xsettings_initialize): Call init_gsettings last.
640c8776
SM
1738 (xsettings_get_system_font, xsettings_get_system_normal_font):
1739 Add comment.
869795d6 1740
d8ed26bd
PE
17412011-07-05 Paul Eggert <eggert@cs.ucla.edu>
1742
1743 Random fixes. E.g., (random) never returned negative values.
1744 * fns.c (Frandom): Use GET_EMACS_TIME for random seed, and add the
1745 subseconds part to the entropy, as that's a bit more random.
1746 Prefer signed to unsigned, since the signedness doesn't matter and
1747 in general we prefer signed. When given a limit, use a
1748 denominator equal to INTMASK + 1, not to VALMASK + 1, because the
1749 latter isn't right if USE_2_TAGS_FOR_INTS.
1750 * sysdep.c (get_random): Return a value in the range 0..INTMASK,
1751 not 0..VALMASK. Don't discard "excess" bits that random () returns.
1752
cabf1cac
SM
17532011-07-04 Stefan Monnier <monnier@iro.umontreal.ca>
1754
1755 * textprop.c (text_property_stickiness):
1756 Obey Vtext_property_default_nonsticky.
1757 (syms_of_textprop): Add `display' to Vtext_property_default_nonsticky.
1758 * w32fns.c (syms_of_w32fns):
1759 * xfns.c (syms_of_xfns): Don't Add `display' since it's there by default.
1760
6e9b2be9
PE
17612011-07-04 Paul Eggert <eggert@cs.ucla.edu>
1762
1763 * fileio.c (barf_or_query_if_file_exists): Use S_ISDIR.
1764 This is more efficient than Ffile_directory_p and avoids a minor race.
1765
90186c68
LMI
17662011-07-04 Lars Magne Ingebrigtsen <larsi@gnus.org>
1767
7c301272
LMI
1768 * buffer.c (Foverlay_put): Say what the return value is
1769 (bug#7835).
1770
c4f2d8d4
LMI
1771 * fileio.c (barf_or_query_if_file_exists): Check first if the file
1772 is a directory before asking whether to use the file name
1773 (bug#7564).
ad637907
LMI
1774 (barf_or_query_if_file_exists): Make the "File is a directory"
1775 error be more correct.
c4f2d8d4 1776
90186c68
LMI
1777 * fns.c (Frequire): Remove the mention of the .gz files, since
1778 that's installation-specific, but keep the mention of
1779 `get-load-suffixes'.
1780
da64016e
PE
17812011-07-04 Paul Eggert <eggert@cs.ucla.edu>
1782
1783 * editfns.c (Fformat_time_string): Don't assume strlen fits in int.
1784 Report string overflow if the output is too long.
1785
7d47b580
JB
17862011-07-04 Juanma Barranquero <lekktu@gmail.com>
1787
a555cb87
JB
1788 * gnutls.c (Fgnutls_boot): Don't mention :verify-error.
1789 (syms_of_gnutls): Remove duplicate DEFSYM for
1790 Qgnutls_bootprop_verify_hostname_error, an error for
1791 Qgnutls_bootprop_verify_error (which is no longer used).
1792
7d47b580
JB
1793 * eval.c (find_handler_clause): Remove parameters `sig' and `data',
1794 unused since 2011-01-26T20:02:07Z!monnier@iro.umontreal.ca. All callers changed.
1795 Also (re)move comments that are misplaced or no longer relevant.
1796
1e49bfab
LMI
17972011-07-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
1798
1799 * callint.c (Finteractive): Clarify the meaning of "@" (bug#8813).
1800
1485f4c0
CY
18012011-07-03 Chong Yidong <cyd@stupidchicken.com>
1802
1803 * xfaces.c (Finternal_merge_in_global_face): Modify the foreground
1804 and background color parameters if they have been changed.
1805
a9ab721e
LMI
18062011-07-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
1807
1808 * editfns.c (Fformat): Clarify the - and 0 flags (bug#6659).
1809
cf7cff57
PE
18102011-07-03 Paul Eggert <eggert@cs.ucla.edu>
1811
2e13213d
PE
1812 * xsettings.c (SYSTEM_FONT): Define only when used.
1813 No need to define when HAVE_GSETTINGS || !HAVE_XFT.
1814
cf7cff57
PE
1815 * keymap.c (access_keymap_1): Now static.
1816
7a8e04f7
CY
18172011-07-02 Chong Yidong <cyd@stupidchicken.com>
1818
1819 * keyboard.c (command_loop_1): If a down-mouse event is unbound,
1820 leave any prefix arg for the up event (Bug#1586).
1821
61352f62
LMI
18222011-07-02 Lars Magne Ingebrigtsen <larsi@gnus.org>
1823
69bb1ef7
LMI
1824 * lread.c (syms_of_lread): Mention single symbols defined by
1825 `defvar' or `defconst' (bug#7154).
1826
61352f62 1827 * fns.c (Frequire): Mention .el.gz files (bug#7314).
7b3747f9 1828 (Frequire): Mention get-load-suffixes.
61352f62 1829
28545e04
MR
18302011-07-02 Martin Rudalics <rudalics@gmx.at>
1831
1832 * window.h (window): Remove clone_number slot.
1833 * window.c (Fwindow_clone_number, Fset_window_clone_number):
1834 Remove.
1835 (make_parent_window, make_window, saved_window)
1836 (Fset_window_configuration, save_window_save): Don't deal with
1837 clone numbers.
1838 * buffer.c (Qclone_number): Remove declaration.
1839 (sort_overlays, overlay_strings): Don't deal with clone numbers.
1840
3349e122
SM
18412011-07-02 Stefan Monnier <monnier@iro.umontreal.ca>
1842
1843 Add multiple inheritance to keymaps.
1844 * keymap.c (Fmake_composed_keymap): New function.
1845 (Fset_keymap_parent): Simplify.
1846 (fix_submap_inheritance): Remove.
1847 (access_keymap_1): New function extracted from access_keymap to handle
1848 embedded parents and handle lists of maps.
1849 (access_keymap): Use it.
1850 (Fkeymap_prompt, map_keymap_internal, map_keymap, store_in_keymap)
1851 (Fcopy_keymap): Handle embedded parents.
1852 (Fcommand_remapping, define_as_prefix): Simplify.
1853 (Fkey_binding): Simplify.
1854 (syms_of_keymap): Move minibuffer-local-completion-map,
1855 minibuffer-local-filename-completion-map,
1856 minibuffer-local-must-match-map, and
1857 minibuffer-local-filename-must-match-map to Elisp.
1858 (syms_of_keymap): Defsubr make-composed-keymap.
1859 * keyboard.c (menu_bar_items): Use map_keymap_canonical.
1860 (parse_menu_item): Trivial simplification.
1861
3279eb87
GM
18622011-07-01 Glenn Morris <rgm@gnu.org>
1863
1864 * Makefile.in (SETTINGS_LIBS): Fix typo.
1865
4550efdf
KI
18662011-07-01 Kazuhiro Ito <kzhr@d1.dion.ne.jp> (tiny patch)
1867
1868 * coding.c (Fencode_coding_string): Record the last coding system
1869 used, as the function doc string says (bug#8738).
1870
0949d2b6
JD
18712011-07-01 Jan Djärv <jan.h.d@swipnet.se>
1872
1873 * xsettings.c (store_monospaced_changed): Take new font as arg and
1874 check for change against current_mono_font.
1875 (EMACS_TYPE_SETTINGS): Remove this and related defines.
1876 (emacs_settings_constructor, emacs_settings_get_property)
1877 (emacs_settings_set_property, emacs_settings_class_init)
1878 (emacs_settings_init, gsettings_obj): Remove.
1879 (something_changedCB): New function for HAVE_GSETTINGS.
1880 (something_changedCB): HAVE_GCONF: Call store_monospaced_changed
1881 with value as argument.
1882 (init_gsettings): Check that GSETTINGS_SCHEMA exists before calling
1883 g_settings_new (Bug#8967). Do not create gsettings_obj.
9173deec 1884 Remove calls to g_settings_bind. Connect something_changedCB to
0949d2b6
JD
1885 "changed".
1886
1887 * xgselect.c: Add defined (HAVE_GSETTINGS).
1888 (xgselect_initialize): Ditto.
1889
1890 * process.c: Add defined (HAVE_GSETTINGS) for xgselect.h
1891 (wait_reading_process_output): Add defined (HAVE_GSETTINGS) for
1892 xg_select.
1893
bbc6b304
PE
18942011-07-01 Paul Eggert <eggert@cs.ucla.edu>
1895
1896 * eval.c (struct backtrace): Simplify and port the data structure.
1897 Do not assume that "int nargs : BITS_PER_INT - 2;" produces a
1898 signed bit field, as this assumption is not portable and it makes
1899 Emacs crash when compiled with Sun C 5.8 on sparc. Do not use
1900 "char debug_on_exit : 1" as this is not portable either; instead,
1901 use the portable "unsigned int debug_on_exit : 1". Remove unused
1902 member evalargs. Remove obsolete comments about cc bombing out.
1903
9851bfc5
JD
19042011-06-30 Jan Djärv <jan.h.d@swipnet.se>
1905
51bb811f 1906 * xsettings.c: Include glib-object.h, gio/gio.h if HAVE_GSETTINGS.
9851bfc5
JD
1907 Let HAVE_GSETTINGS override HAVE_GCONF.
1908 (store_monospaced_changed): New function.
1909 (EMACS_SETTINGS): A new type derived from GObject to handle
1910 GSettings notifications.
1911 (emacs_settings_constructor, emacs_settings_get_property)
1912 (emacs_settings_set_property, emacs_settings_class_init):
1913 New functions.
1914 (gsettings_client, gsettings_obj): New variables.
1915 (GSETTINGS_SCHEMA): New define.
1916 (something_changedCB): Call store_monospaced_changed.
1917 (init_gsettings): New function.
1918 (xsettings_initialize): Call init_gsettings.
1919 (syms_of_xsettings): Initialize gsettings_client, gsettings_obj
1920 to NULL.
1921
640c8776 1922 * Makefile.in (SETTINGS_CFLAGS, SETTINGS_LIBS): Rename from
9851bfc5
JD
1923 GCONF_CFLAGS/LIBS.
1924
5386012d
MR
19252011-06-29 Martin Rudalics <rudalics@gmx.at>
1926
1927 * window.c (resize_root_window, grow_mini_window)
1928 (shrink_mini_window): Rename Qresize_root_window to
1929 Qwindow_resize_root_window and Qresize_root_window_vertically to
1930 Qwindow_resize_root_window_vertically.
1931
f13e0b08
PE
19322011-06-28 Paul Eggert <eggert@cs.ucla.edu>
1933
1934 * gnutls.c (Qgnutls_bootprop_verify_error): Remove unused var.
1935
94515237
JB
19362011-06-27 Juanma Barranquero <lekktu@gmail.com>
1937
1938 * makefile.w32-in: Redesign dependencies so they reflect more
1939 clearly which files are directly included by each source file,
1940 and not through other includes.
1941
e43b6e43
MR
19422011-06-27 Martin Rudalics <rudalics@gmx.at>
1943
1944 * buffer.c (Qclone_number): Declare static and DEFSYM it.
1945 (sort_overlays, overlay_strings): When an overlay's clone number
1946 matches the window's clone number process the overlay even if
1947 the overlay's window property doesn't match the current window.
1948
d68443dc
MR
1949 * window.c (Fwindow_vchild): Rename to Fwindow_top_child.
1950 (Fwindow_hchild): Rename to Fwindow_left_child.
1951 (Fwindow_next): Rename to Fwindow_next_sibling.
1952 (Fwindow_prev): Rename to Fwindow_prev_sibling.
d615d6d2
MR
1953 (resize_window_check): Rename to window_resize_check.
1954 (resize_window_apply): Rename to window_resize_apply.
1955 (Fresize_window_apply): Rename to Fwindow_resize_apply.
1956 (Fdelete_other_windows_internal, resize_frame_windows)
1957 (Fsplit_window_internal, Fdelete_window_internal)
1958 (grow_mini_window, shrink_mini_window)
1959 (Fresize_mini_window_internal): Fix callers accordingly.
d68443dc 1960
c7e73be5
JD
19612011-06-26 Jan Djärv <jan.h.d@swipnet.se>
1962
1963 * emacsgtkfixed.h: State that this is only used with Gtk+3.
1964 (emacs_fixed_set_min_size): Remove.
1965 (emacs_fixed_new): Take frame as argument.
1966
1967 * emacsgtkfixed.c: State that this is only used with Gtk+3.
1968 (_EmacsFixedPrivate): Remove minwidth/height.
1969 Add struct frame *f.
1970 (emacs_fixed_init): Initialize priv->f.
1971 (get_parent_class, emacs_fixed_set_min_size): Remove.
1972 (emacs_fixed_new): Set priv->f to argument.
1973 (emacs_fixed_get_preferred_width)
1974 (emacs_fixed_get_preferred_height): Use min_width/height from
1975 frames size_hint to set minimum and natural (Bug#8919).
1976 (XSetWMSizeHints, XSetWMNormalHints): Override these functions
1977 and use min_width/height from frames size_hint to set
1978 min_width/height (Bug#8919).
1979
1980 * gtkutil.c (xg_create_frame_widgets): Pass f to emacs_fixed_new.
9173deec
JB
1981 (x_wm_set_size_hint): Remove call to emacs_fixed_set_min_size.
1982 Fix indentation.
c7e73be5 1983
cf99dcf8
EZ
19842011-06-26 Eli Zaretskii <eliz@gnu.org>
1985
1986 * bidi.c (bidi_paragraph_init): Test for ZV_BYTE before calling
1987 bidi_at_paragraph_end, since fast_looking_at doesn't like to be
1988 called at ZV.
1989
029529ac
CY
19902011-06-26 Chong Yidong <cyd@stupidchicken.com>
1991
1992 * process.c (wait_reading_process_output): Bypass select if
1993 waiting for a cell while ignoring keyboard input, and input is
1994 pending. Suggested by Jan Djärv (Bug#8869).
1995
7a7ef429
PE
19962011-06-25 Paul Eggert <eggert@cs.ucla.edu>
1997
1998 Use gnulib's dup2 module instead of rolling our own.
1999 * sysdep.c (dup2) [!HAVE_DUP2]: Remove; gnulib now does this.
2000
11fdef7d 20012011-06-25 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
989b42d2
YM
2002
2003 * dispnew.c (scrolling_window): Before scrolling, turn off a
2004 mouse-highlight in the window being scrolled.
2005
cd3520a4
JB
20062011-06-24 Juanma Barranquero <lekktu@gmail.com>
2007
2008 Move DEFSYM to lisp.h and use everywhere.
2009
2010 * character.h (DEFSYM): Move declaration...
2011 * lisp.h (DEFSYM): ...here.
2012
2013 * gnutls.c:
2014 * minibuf.c:
2015 * w32menu.c:
2016 * w32proc.c:
2017 * w32select.c: Don't include character.h.
2018
2019 * alloc.c (syms_of_alloc):
2020 * buffer.c (syms_of_buffer):
2021 * bytecode.c (syms_of_bytecode):
2022 * callint.c (syms_of_callint):
2023 * casefiddle.c (syms_of_casefiddle):
2024 * casetab.c (init_casetab_once):
2025 * category.c (init_category_once, syms_of_category):
2026 * ccl.c (syms_of_ccl):
2027 * cmds.c (syms_of_cmds):
2028 * composite.c (syms_of_composite):
2029 * dbusbind.c (syms_of_dbusbind):
2030 * dired.c (syms_of_dired):
2031 * dispnew.c (syms_of_display):
2032 * doc.c (syms_of_doc):
2033 * editfns.c (syms_of_editfns):
2034 * emacs.c (syms_of_emacs):
2035 * eval.c (syms_of_eval):
2036 * fileio.c (syms_of_fileio):
2037 * fns.c (syms_of_fns):
2038 * frame.c (syms_of_frame):
2039 * fringe.c (syms_of_fringe):
2040 * insdel.c (syms_of_insdel):
2041 * keymap.c (syms_of_keymap):
2042 * lread.c (init_obarray, syms_of_lread):
2043 * macros.c (syms_of_macros):
2044 * msdos.c (syms_of_msdos):
2045 * print.c (syms_of_print):
2046 * process.c (syms_of_process):
2047 * search.c (syms_of_search):
2048 * sound.c (syms_of_sound):
2049 * syntax.c (init_syntax_once, syms_of_syntax):
2050 * terminal.c (syms_of_terminal):
2051 * textprop.c (syms_of_textprop):
2052 * undo.c (syms_of_undo):
2053 * w32.c (globals_of_w32):
2054 * window.c (syms_of_window):
2055 * xdisp.c (syms_of_xdisp):
2056 * xfaces.c (syms_of_xfaces):
2057 * xfns.c (syms_of_xfns):
2058 * xmenu.c (syms_of_xmenu):
2059 * xsettings.c (syms_of_xsettings):
2060 * xterm.c (syms_of_xterm): Use DEFSYM.
2061
4228cf16
TZ
20622011-06-24 Teodor Zlatanov <tzz@lifelogs.com>
2063
cd3520a4 2064 * gnutls.c (syms_of_gnutls): Use the DEFSYM macro from character.h.
4228cf16 2065
7fcccf1e
PE
20662011-06-23 Paul Eggert <eggert@cs.ucla.edu>
2067
7efb4e0e
PE
2068 Integer and buffer overflow fixes (Bug#8873).
2069
ff5844ad
PE
2070 * print.c (printchar, strout): Check for string overflow.
2071 (PRINTPREPARE, printchar, strout):
2072 Don't set size unless allocation succeeds.
2073
90532f02
PE
2074 * minibuf.c (read_minibuf_noninteractive): Use ptrdiff_t, not int,
2075 for sizes. Check for string overflow more accurately.
2076 Simplify newline removal at end; this suppresses a GCC 4.6.0 warning.
2077
6d84508d
PE
2078 * macros.c: Integer and buffer overflow fixes.
2079 * keyboard.h (struct keyboard.kbd_macro_bufsize):
2080 * macros.c (Fstart_kbd_macro, store_kbd_macro_char):
2081 Use ptrdiff_t, not int, for sizes.
2082 Don't increment bufsize until after realloc succeeds.
2083 Check for size-calculation overflow.
2084 (Fstart_kbd_macro): Use EMACS_INT, not int, for XINT result.
2085
437b2cb4
PE
2086 * lisp.h (DEFVAR_KBOARD): Use offsetof instead of char * finagling.
2087
8b9ac8b4
PE
2088 * lread.c: Integer overflow fixes.
2089 (read_integer): Radix is now EMACS_INT, not int,
2090 to improve quality of diagnostics for out-of-range radices.
2091 Calculate buffer size correctly for out-of-range radices.
2092 (read1): Check for integer overflow in radices, and in
2093 read-circle numbers.
82cb60d3
PE
2094 (read_escape): Avoid int overflow.
2095 (Fload, openp, read_buffer_size, read1)
2096 (substitute_object_recurse, read_vector, read_list, map_obarray):
2097 Use ptrdiff_t, not int, for sizes.
2098 (read1): Use EMACS_INT, not int, for sizes.
20270765 2099 Check for size overflow.
8b9ac8b4 2100
7fcccf1e
PE
2101 * image.c (cache_image): Check for size arithmetic overflow.
2102
bfbbd7e7
PE
2103 * lread.c: Integer overflow issues.
2104 (saved_doc_string_size, saved_doc_string_length)
2105 (prev_saved_doc_string_size, prev_saved_doc_string_length):
2106 Now ptrdiff_t, not int.
2107 (read1): Don't assume doc string length fits in int. Check for
2108 out-of-range doc string lengths.
2109 (read_list): Don't assume file position fits in int.
39019e54 2110 (read_escape): Check for hex character overflow.
bfbbd7e7 2111
4e323265
LL
21122011-06-22 Leo Liu <sdl.web@gmail.com>
2113
2114 * minibuf.c (Fcompleting_read_default, Vcompleting_read_function):
2115 Move to minibuffer.el.
2116
85fece3e
PE
21172011-06-22 Paul Eggert <eggert@cs.ucla.edu>
2118
20b84ce9 2119 Fixes for GLYPH_DEBUG found by GCC 4.6.0 static checking.
85fece3e
PE
2120 The following patches are for when GLYPH_DEBUG && !XASSERT.
2121 * dispextern.h (trace_redisplay_p, dump_glyph_string):
2122 * dispnew.c (flush_stdout):
2123 * xdisp.c (dump_glyph_row, dump_glyph_matrix, dump_glyph):
2124 Mark as externally visible.
2125 * dispnew.c (check_window_matrix_pointers): Now static.
2126 * dispnew.c (window_to_frame_vpos):
2127 * xfns.c (unwind_create_frame):
2128 * xterm.c (x_check_font): Remove unused local.
2129 * scroll.c (CHECK_BOUNDS):
2130 * xfaces.c (cache_fache): Rename local to avoid shadowing.
2131 * xfns.c, w32fns.c (image_cache_refcount, dpyinfo_refcount): Now static.
2132 * xdisp.c (check_window_end): Now a no-op if !XASSERTS.
2133 (debug_first_unchanged_at_end_vpos, debug_last_unchanged_at_beg_vpos)
2134 (debug_dvpos, debug_dy, debug_delta, debug_delta_bytes, debug_end_vpos):
2135 Now static.
2136 (debug_method_add): Use va_list and vsprintf rather than relying
2137 on undefined behavior with wrong number of arguments.
2138 (dump_glyph, dump_glyph_row, Fdump_glyph_matrix):
2139 Don't assume ptrdiff_t and EMACS_INT are the same width as int.
2140 In this code, it's OK to assume C99 behavior for ptrdiff_t formats
2141 since we're not interested in debugging glyphs with old libraries.
2142 * xfaces.c (cache_face): Move debugging code earlier; this pacifies
2143 GCC 4.6.0's static checking.
2144
0766b489
PE
21452011-06-22 Paul Eggert <eggert@cs.ucla.edu>
2146
31fd4b32
PE
2147 Integer overflow and signedness fixes (Bug#8873).
2148 A few related buffer overrun fixes, too.
2149
b79e8648
PE
2150 * font.c (font_score): Use EMACS_INT, not int, to store XINT value.
2151
0766b489
PE
2152 * dispextern.h (struct face.stipple):
2153 * image.c (x_bitmap_height, x_bitmap_width, x_bitmap_pixmap)
2154 (x_bitmap_mask, x_allocate_bitmap_record)
2155 (x_create_bitmap_from_data, x_create_bitmap_from_file)
2156 (x_destroy_bitmap, x_destroy_all_bitmaps, x_create_bitmap_mask)
2157 (x_create_bitmap_from_xpm_data):
2158 * nsterm.h (struct ns_display_info.bitmaps_size, .bitmaps_last):
2159 * w32term.h (struct w32_display_info.icon_bitmap_id, .bitmaps_size)
2160 (.bitmaps_last):
2161 * xfaces.c (load_pixmap):
2162 * xterm.c (x_bitmap_icon, x_wm_set_icon_pixmap):
2163 * xterm.h (struct x_display_info.icon_bitmap_id, .bitmaps_size)
2164 (.bitmaps_last, struct x_output.icon_bitmap):
2165 Use ptrdiff_t, not int, for bitmap indexes.
2166 (x_allocate_bitmap_record): Check for size overflow.
2167 * dispextern.h, lisp.h: Adjust to API changes elsewhere.
2168
b081724f
PE
2169 Use ptrdiff_t, not int, for overlay counts.
2170 * buffer.h (overlays_at, sort_overlays, GET_OVERLAYS_AT):
2171 * editfns.c (overlays_around, get_pos_property):
2172 * textprop.c (get_char_property_and_overlay):
2173 * xdisp.c (next_overlay_change, note_mouse_highlight):
2174 * xfaces.c (face_at_buffer_position):
21514da7
PE
2175 * buffer.c (OVERLAY_COUNT_MAX): New macro.
2176 (overlays_at, overlays_in, sort_overlays, Foverlays_at)
2177 (Fnext_overlay_change, Fprevious_overlay_change)
2178 (mouse_face_overlay_overlaps, Foverlays_in):
b081724f 2179 Use ptrdiff_t, not int, for sizes.
21514da7 2180 (overlays_at, overlays_in): Check for size-calculation overflow.
b081724f 2181
3de73e5e
PE
2182 * xterm.c (xim_initialize, same_x_server): Strlen may not fit in int.
2183
2606c57b
PE
2184 * xsmfns.c (smc_save_yourself_CB, x_session_initialize): Avoid strlen.
2185 (x_session_initialize): Do not assume string length fits in int.
2186
aaafe47a
PE
2187 * xsettings.c (apply_xft_settings): Fix potential buffer overrun.
2188 This is unlikely, but can occur if DPI is outlandish.
2189
2674ddc8 2190 * xsettings.c (Ffont_get_system_normal_font, Ffont_get_system_font):
3a5077c5
PE
2191 * xselect.c (Fx_get_atom_name): Avoid need for strlen.
2192
28154962
PE
2193 * xrdb.c: Don't assume strlen fits in int; avoid some strlens.
2194 * xrdb.c (magic_file_p, search_magic_path):
2195 Omit last arg SUFFIX; it was always 0. All callers changed.
2196 (magic_file_p): Use ptrdiff_t, not int. Check for size overflow.
2197
7de51af5
PE
2198 * xfont.c (xfont_match): Avoid need for strlen.
2199
25ed6cc3
PE
2200 * xfns.c: Don't assume strlen fits in int.
2201 (xic_create_fontsetname, x_window): Use ptrdiff_t, not int.
2202
4eab31dd
PE
2203 * xdisp.c (message_log_check_duplicate): Return intmax_t,
2204 not unsigned long, as we prefer signed integers. All callers changed.
2205 Detect integer overflow in repeat count.
2206 (message_dolog): Don't assume print length fits in 39 bytes.
df1f27af 2207 (display_mode_element): Don't assume strlen fits in int.
4eab31dd 2208
171e2a58
PE
2209 * termcap.c: Don't assume sizes fit in int and never overflow.
2210 (struct termcap_buffer, tgetent): Use ptrdiff_t, not int, for sizes.
2211 (gobble_line): Check for size-calculation overflow.
2212
ad39faca 2213 * minibuf.c (Fread_buffer):
6e5bb2dc 2214 * lread.c (intern, intern_c_string):
74ca2eb3
PE
2215 * image.c (xpm_scan) [HAVE_NS && !HAVE_XPM]:
2216 Don't assume string length fits in int.
2217
52c61c22 2218 * keyboard.c (parse_tool_bar_item):
9bda3520
PE
2219 * gtkutil.c (style_changed_cb): Avoid need for strlen.
2220
b5b8c9e5
PE
2221 * font.c: Don't assume string length fits in int.
2222 (font_parse_xlfd, font_parse_fcname, font_unparse_fcname):
2223 Use ptrdiff_t, not int.
ccd6111c
PE
2224 (font_intern_prop): Don't assume string length fits in int.
2225 Don't assume integer property fits in fixnum.
2226 * font.h (font_intern_prop): 2nd arg is now ptrdiff_t, not int.
b5b8c9e5 2227
882f0d81 2228 * filelock.c: Fix some buffer overrun and integer overflow issues.
51cab52b 2229 (get_boot_time): Don't assume gzip command string fits in 100 bytes.
882f0d81
PE
2230 Reformulate so as not to need the command string.
2231 Invoke gzip -cd rather than gunzip, as it's more portable.
2232 (lock_info_type, lock_file_1, lock_file):
2233 Don't assume pid_t and time_t fit in unsigned long.
2234 (LOCK_PID_MAX): Remove; we now use more-reliable bounds.
2235 (current_lock_owner): Prefer signed type for sizes.
2236 Use memcpy, not strncpy, where memcpy is what is really wanted.
2237 Don't assume (via atoi) that time_t and pid_t fit in int.
2238 Check for time_t and/or pid_t out of range, e.g., via a network share.
2239 Don't alloca where an auto var works fine.
2240
93f4cf88
PE
2241 * fileio.c: Fix some integer overflow issues.
2242 (file_name_as_directory, Fexpand_file_name, Fsubstitute_in_file_name):
2243 Don't assume string length fits in int.
2244 (directory_file_name): Don't assume string length fits in long.
2245 (make_temp_name): Don't assume pid fits in int, or that its print
2246 length is less than 20.
2247
f3e92b69
PE
2248 * data.c (Fsubr_name): Rewrite to avoid a strlen call.
2249
1bfdaf10
PE
2250 * coding.c (make_subsidiaries): Don't assume string length fits in int.
2251
35016e9a
PE
2252 * callproc.c (child_setup): Rewrite to avoid two strlen calls.
2253
3d1e65a1
PE
2254 * process.c (Fformat_network_address): Use EMACS_INT, not EMACS_UINT.
2255 We prefer signed integers, even for size calculations.
2256
0b963a93
PE
2257 * emacs.c: Don't assume string length fits in 'int'.
2258 (DEFINE_DUMMY_FUNCTION, sort_args): Use ptrdiff_t, not int.
2259 (main): Don't invoke strlen when not needed.
2260
573f4b54
PE
2261 * dbusbind.c (XD_ERROR): Don't arbitrarily truncate string.
2262 (XD_DEBUG_MESSAGE): Don't waste a byte.
2263
989f33ba
PE
2264 * callproc.c (getenv_internal_1, getenv_internal)
2265 (Fgetenv_internal):
965d34eb
PE
2266 * buffer.c (init_buffer): Don't assume string length fits in 'int'.
2267
e4d29b33
PE
2268 * lread.c (invalid_syntax): Omit length argument.
2269 All uses changed. This doesn't fix a bug, but it simplifies the
2270 code away from its former Hollerith-constant appearance, and it's
2271 one less 'int' to worry about when looking at integer-overflow issues.
51cab52b 2272 (string_to_number): Simplify 2011-04-26 change by invoking xsignal1.
e4d29b33 2273
eb49b136
PE
2274 * lisp.h (DEFUN): Remove bogus use of sizeof (struct Lisp_Subr).
2275 This didn't break anything, but it didn't help either.
2276 It's confusing to put a bogus integer in a place where the actual
2277 value does not matter.
9f62aeb1 2278 (LIST_END_P): Remove unused macro and its bogus comment.
cbeff735 2279 (make_fixnum_or_float): Remove unnecessary cast to EMACS_INT.
eb49b136 2280
15375a22
PE
2281 * lisp.h (union Lisp_Object.i): EMACS_INT, not EMACS_UINT.
2282 This is for consistency with the ordinary, non-USE_LISP_UNION_TYPE,
2283 implementation.
b61cc01c
PE
2284 (struct Lisp_Bool_Vector.size): EMACS_INT, not EMACS_UINT.
2285 We prefer signed types, and the value cannot exceed the EMACS_INT
2286 range anyway (because otherwise the length would not be representable).
9a8e8d9b
PE
2287 (XSET) [USE_LISP_UNION_TYPE]: Use uintptr_t and intptr_t,
2288 not EMACS_UINT and EMACS_INT, when converting pointer to integer.
2289 This avoids a GCC warning when WIDE_EMACS_INT.
15375a22 2290
53b2623d
PE
2291 * indent.c (sane_tab_width): New function.
2292 (current_column, scan_for_column, Findent_to, position_indentation)
2293 (compute_motion): Use it. This is just for clarity.
8fcaf9cc 2294 (Fcompute_motion): Don't assume hscroll and tab offset fit in int.
53b2623d 2295
51cab52b 2296 * image.c (xbm_image_p): Don't assume stated width, height fit in int.
45aebb64 2297
f2ed8a70
PE
2298 * lisp.h (lint_assume): New macro.
2299 * composite.c (composition_gstring_put_cache):
2300 * ftfont.c (ftfont_shape_by_flt): Use it to pacify GCC 4.6.0.
2301
abe80cc6
PE
2302 * editfns.c, insdel.c:
2303 Omit unnecessary forward decls, to simplify future changes.
a9e860e1 2304
b02c740e
PE
2305 * ftfont.c (ftfont_shape_by_flt): Use signed integers for lengths.
2306
ebc96716
PE
2307 * font.c (Ffont_shape_gstring): Don't assume glyph len fits in 'int'.
2308
b4e50fa0 2309 * fns.c (Ffillarray): Don't assume bool vector size fits in 'int'.
f03dc6ef 2310 Use much-faster test for byte-length change.
311d5d7c 2311 Don't assume string byte-length fits in 'int'.
a4cf38e4 2312 Check that character arg fits in 'int'.
85461888 2313 (mapcar1): Declare byte as byte, for clarity.
b4e50fa0 2314
c0c1ee9f
PE
2315 * alloc.c (Fmake_bool_vector): Avoid unnecessary multiplication.
2316
a498d7f4
PE
2317 * fns.c (concat): Catch string overflow earlier.
2318 Do not rely on integer wraparound.
2319
51cab52b
PE
2320 * dispextern.h (struct it.overlay_strings_charpos)
2321 (struct it.selective): Now EMACS_INT, not int.
87830974
PE
2322 * xdisp.c (forward_to_next_line_start)
2323 (back_to_previous_visible_line_start)
2324 (reseat_at_next_visible_line_start, next_element_from_buffer):
2325 Don't arbitrarily truncate the value of 'selective' to int.
2326
76031fad
PE
2327 * xdisp.c (init_iterator): Use XINT, not XFASTINT; it might be < 0.
2328
5eb55db9
PE
2329 * composite.c: Don't truncate sizes to 'int'.
2330 (composition_gstring_p, composition_reseat_it)
2331 (composition_adjust_point): Use EMACS_INT, not int.
7d100a81
PE
2332 (get_composition_id, composition_gstring_put_cache): Use EMACS_INT,
2333 not EMACS_UINT, for indexes.
5eb55db9 2334
0703a717
PE
2335 * category.h (CATEGORY_SET_P): Remove unnecessary cast to EMACS_INT.
2336
d6202519
PE
2337 * buffer.c: Include <verify.h>.
2338 (struct sortvec.priority, struct sortstr.priority):
8961a454 2339 Now EMACS_INT, not int.
c20998a7 2340 (compare_overlays, cmp_for_strings): Avoid subtraction overflow.
67c36fce
PE
2341 (struct sortstr.size, record_overlay_string)
2342 (struct sortstrlist.size, struct sortlist.used):
2343 Don't truncate size to int.
2344 (record_overlay_string): Check for size-calculation overflow.
d6202519 2345 (init_buffer_once): Check at compile-time, not run-time.
fadf4e30 2346
d5a19415
JM
23472011-06-22 Jim Meyering <meyering@redhat.com>
2348
029529ac 2349 Don't leak an XBM-image-sized buffer
d5a19415
JM
2350 * image.c (xbm_load): Free the image buffer after using it.
2351
a9041e6c
PE
23522011-06-21 Paul Eggert <eggert@cs.ucla.edu>
2353
2354 Port to Sun C.
2355 * composite.c (find_automatic_composition): Omit needless 'return 0;'
2356 that Sun C diagnosed.
2357 * fns.c (secure_hash): Fix pointer signedness issue.
2358 * intervals.c (static_offset_intervals): New function.
2359 (offset_intervals): Use it.
2360
7f3f739f
LL
23612011-06-21 Leo Liu <sdl.web@gmail.com>
2362
2363 * deps.mk (fns.o):
2364 * makefile.w32-in ($(BLD)/fns.$(O)): Include sha256.h and
2365 sha512.h.
2366
2367 * fns.c (secure_hash): Rename from crypto_hash_function and change
2368 the first arg to accept symbols.
5b66d427 2369 (Fsecure_hash): New primitive.
7f3f739f
LL
2370 (syms_of_fns): New symbols.
2371
76147d94
DD
23722011-06-20 Deniz Dogan <deniz@dogan.se>
2373
2374 * process.c (Fset_process_buffer): Clarify return value in
2375 docstring.
2376
7d7d0045
CY
23772011-06-18 Chong Yidong <cyd@stupidchicken.com>
2378
2379 * dispnew.c (add_window_display_history): Use BVAR.
2380
2381 * xdisp.c (debug_method_add): Use BVAR.
2382 (check_window_end, dump_glyph_matrix, dump_glyph)
2383 (dump_glyph_row, dump_glyph_string): Convert arglist to ANSI C.
2384
2385 * xfaces.c (check_lface_attrs, check_lface, dump_realized_face):
2386 Likewise.
2387
2388 * xfns.c (Fx_create_frame, x_create_tip_frame): Delay image cache
2389 check till after the cache is created in init_frame_faces.
2390
ff2bc410
SM
23912011-06-17 Stefan Monnier <monnier@iro.umontreal.ca>
2392
2393 * fns.c (Fsafe_length): Yet another int/Lisp_Object mixup.
2394
28177add
PE
23952011-06-16 Paul Eggert <eggert@cs.ucla.edu>
2396
dd3482fe
PE
2397 * lisp.h: Include <limits.h>, for INT_MAX, LONG_MAX, LLONG_MAX.
2398 Without this, prin1 mishandles Lisp_Misc_Save_Value printing on
2399 hosts with pre-C99 libraries, because pD is wrongly defined to "t".
2400
393d71f3 2401 Improve buffer-overflow checking (Bug#8873).
1c8e352f
PE
2402 * fileio.c (Finsert_file_contents):
2403 * insdel.c (insert_from_buffer_1, replace_range, replace_range_2):
2404 Remove the old (too-loose) buffer overflow checks.
2405 They weren't needed, since make_gap checks for buffer overflow.
2406 * insdel.c (make_gap_larger): Catch buffer overflows that were missed.
2407 The old code merely checked for Emacs fixnum overflow, and relied
2408 on undefined (wraparound) behavior. The new code avoids undefined
2409 behavior, and also checks for ptrdiff_t and/or size_t overflow.
2410
2e6813b0 2411 * editfns.c (Finsert_char): Don't dump core with very negative counts.
21d890a4
PE
2412 Tune. Don't use wider integers than needed. Don't use alloca.
2413 Use a bigger 'string' buffer. Rewrite to avoid 'n > 0' test.
2e6813b0 2414
599a9e4f
PE
2415 * insdel.c (replace_range): Fix buf overflow when insbytes < outgoing.
2416
99561444
PE
2417 * insdel.c, lisp.h (buffer_overflow): New function.
2418 (insert_from_buffer_1, replace_range, replace_range_2):
2419 * insdel.c (make_gap_larger):
2420 * editfns.c (Finsert_char):
2421 * fileio.c (Finsert_file_contents): Use it, to normalize wording.
2422
28177add
PE
2423 * buffer.h (BUF_BYTES_MAX): Cast to ptrdiff_t so that it's signed.
2424
e69dafad
PE
24252011-06-15 Paul Eggert <eggert@cs.ucla.edu>
2426
a7af7fde 2427 Integer overflow and signedness fixes (Bug#8873).
ff672d2c 2428
b1c46f02
PE
2429 * ccl.c (ASCENDING_ORDER): New macro, to work around GCC bug 43772.
2430 (GET_CCL_RANGE, IN_INT_RANGE): Use it.
2431
e69dafad
PE
2432 * fileio.c: Don't assume EMACS_INT fits in off_t.
2433 (emacs_lseek): New static function.
2434 (Finsert_file_contents, Fwrite_region): Use it.
2435 Use SEEK_SET, SEEK_CUR, SEEK_END as appropriate.
2436
566684ea
PE
2437 * fns.c (Fload_average): Don't assume 100 * load average fits in int.
2438
e6966cd6
PE
2439 * fns.c: Don't overflow int when computing a list length.
2440 * fns.c (QUIT_COUNT_HEURISTIC): New constant.
2441 (Flength, Fsafe_length): Use EMACS_INT, not int, to avoid unwanted
2442 truncation on 64-bit hosts. Check for QUIT every
2443 QUIT_COUNT_HEURISTIC entries rather than every other entry; that's
2444 faster and is responsive enough.
2445 (Flength): Report an error instead of overflowing an integer.
2446 (Fsafe_length): Return a float if the value is not representable
2447 as a fixnum. This shouldn't happen except in contrived situations.
6346d301 2448 (Fnthcdr, Fsort): Don't assume list length fits in int.
de41a810 2449 (Fcopy_sequence): Don't assume vector length fits in int.
00c604f2 2450
dd0b0efb
PE
2451 * alloc.c: Check that resized vectors' lengths fit in fixnums.
2452 (header_size, word_size): New constants.
2453 (allocate_vectorlike): Don't check size overflow here.
2454 (allocate_vector): Check it here instead, since this is the only
2455 caller of allocate_vectorlike that could cause overflow.
2456 Check that the new vector's length is representable as a fixnum.
2457
86fe5cfe
PE
2458 * fns.c (next_almost_prime): Don't return a multiple of 3 or 5.
2459 The previous code was bogus. For example, next_almost_prime (32)
2460 returned 39, which is undesirable as it is a multiple of 3; and
2461 next_almost_prime (24) returned 25, which is a multiple of 5 so
2462 why was the code bothering to check for multiples of 7?
2463
80e88859
PE
2464 * bytecode.c (exec_byte_code): Use ptrdiff_t, not int, for vector length.
2465
4a2f0ad6
PE
2466 * eval.c, doprnt.c (SIZE_MAX): Remove; inttypes.h defines this now.
2467
f66c7cf8
PE
2468 Variadic C functions now count arguments with ptrdiff_t.
2469 This partly undoes my 2011-03-30 change, which replaced int with size_t.
2470 Back then I didn't know that the Emacs coding style prefers signed int.
2471 Also, in the meantime I found a few more instances where arguments
4a2f0ad6
PE
2472 were being counted with int, which may truncate counts on 64-bit
2473 machines, or EMACS_INT, which may be unnecessarily wide.
f66c7cf8
PE
2474 * lisp.h (struct Lisp_Subr.function.aMANY)
2475 (DEFUN_ARGS_MANY, internal_condition_case_n, safe_call):
2476 Arg counts are now ptrdiff_t, not size_t.
2477 All variadic functions and their callers changed accordingly.
2478 (struct gcpro.nvars): Now size_t, not size_t. All uses changed.
2479 * bytecode.c (exec_byte_code): Check maxdepth for overflow,
2480 to avoid potential buffer overrun. Don't assume arg counts fit in 'int'.
2481 * callint.c (Fcall_interactively): Check arg count for overflow,
2482 to avoid potential buffer overrun. Use signed char, not 'int',
2483 for 'varies' array, so that we needn't bother to check its size
2484 calculation for overflow.
2485 * editfns.c (Fformat): Use ptrdiff_t, not EMACS_INT, to count args.
2486 * eval.c (apply_lambda):
2487 * fns.c (Fmapconcat): Use XFASTINT, not XINT, to get args length.
2488 (struct textprop_rec.argnum): Now ptrdiff_t, not int. All uses changed.
2489 (mapconcat): Use ptrdiff_t, not int and EMACS_INT, to count args.
2490
a1759b76
PE
2491 * callint.c (Fcall_interactively): Don't use index var as event count.
2492
d96be9fc
PE
2493 * vm-limit.c (check_memory_limits): Fix incorrect extern function decls.
2494 * mem-limits.h (SIZE): Remove; no longer used.
2495
a690a978 2496 * xterm.c (x_alloc_nearest_color_1): Prefer int to long when int works.
5efd304b 2497
578c21e6
PE
2498 Remove unnecessary casts.
2499 * xterm.c (x_term_init):
2500 * xfns.c (x_set_border_pixel):
2501 * widget.c (create_frame_gcs): Remove casts to unsigned long etc.
2502 These aren't needed now that we assume ANSI C.
2503
96f53c6c
PE
2504 * sound.c (Fplay_sound_internal): Remove cast to unsigned long.
2505 It's more likely to cause problems (due to unsigned overflow)
2506 than to cure them.
2507
83c77d31
PE
2508 * dired.c (Ffile_attributes): Don't use 32-bit hack on 64-bit hosts.
2509
ee2079f1
PE
2510 * unexelf.c (unexec): Don't assume BSS addr fits in unsigned.
2511
6da65536
PE
2512 * xterm.c (handle_one_xevent): Omit unnecessary casts to unsigned.
2513
7147c4a4
PE
2514 * keyboard.c (modify_event_symbol): Don't limit alist len to UINT_MAX.
2515
193e32d9
PE
2516 * lisp.h (CHAR_TABLE_SET): Omit now-redundant test.
2517
e5533da6
PE
2518 * lread.c (Fload): Don't compare a possibly-garbage time_t value.
2519
9910e595
PE
2520 GLYPH_CODE_FACE returns EMACS_INT, not int.
2521 * dispextern.h (merge_faces):
2522 * xfaces.c (merge_faces):
01103c44
PE
2523 * xdisp.c (get_next_display_element, next_element_from_display_vector):
2524 Don't assume EMACS_INT fits in int.
9910e595 2525
2638320e
PE
2526 * character.h (CHAR_VALID_P): Remove unused parameter.
2527 * fontset.c, lisp.h, xdisp.c: All uses changed.
2528
045eb8d9
PE
2529 * editfns.c (Ftranslate_region_internal): Omit redundant test.
2530
c1f134b5
PE
2531 * fns.c (concat): Minor tuning based on overflow analysis.
2532 This doesn't fix any bugs. Use int to hold character, instead
2533 of constantly refetching from Emacs object. Use XFASTINT, not
2534 XINT, for value known to be a character. Don't bother comparing
2535 a single byte to 0400, as it's always less.
2536
395fcb93 2537 * floatfns.c (Fexpt):
327eeec8
PE
2538 * fileio.c (make_temp_name): Omit unnecessary cast to unsigned.
2539
abbd3d23
PE
2540 * editfns.c (Ftranslate_region_internal): Use int, not EMACS_INT
2541 for characters.
2542
684a03ef
PE
2543 * doc.c (get_doc_string): Omit (unsigned)c that mishandled negatives.
2544
0fed43f3
PE
2545 * data.c (Faset): If ARRAY is a string, check that NEWELT is a char.
2546 Without this fix, on a 64-bit host (aset S 0 4294967386) would
2547 incorrectly succeed when S was a string, because 4294967386 was
2548 truncated before it was used.
2549
8fd02eb7
PE
2550 * chartab.c (Fchar_table_range): Use CHARACTERP to check range.
2551 Otherwise, an out-of-range integer could cause undefined behavior
2552 on a 64-bit host.
2553
f8c86b69
PE
2554 * composite.c: Use int, not EMACS_INT, for characters.
2555 (fill_gstring_body, composition_compute_stop_pos): Use int, not
2556 EMACS_INT, for values that are known to be in character range.
2557 This doesn't fix any bugs but is the usual style inside Emacs and
2558 may generate better code on 32-bit machines.
2559
34206dd2
PE
2560 Make sure a 64-bit char is never passed to ENCODE_CHAR.
2561 This is for reasons similar to the recent CHAR_STRING fix.
2562 * charset.c (Fencode_char): Check that character arg is actually
2563 a character. Pass an int to ENCODE_CHAR.
2564 * charset.h (ENCODE_CHAR): Verify that the character argument is no
2565 wider than 'int', as a compile-time check to prevent future regressions
2566 in this area.
2567
c5958d4c 2568 * character.c (char_string): Remove unnecessary casts.
13bdea59
PE
2569
2570 Make sure a 64-bit char is never passed to CHAR_STRING.
2571 Otherwise, CHAR_STRING would do the wrong thing on a 64-bit platform,
2572 by silently ignoring the top 32 bits, allowing some values
2573 that were far too large to be valid characters.
2574 * character.h: Include <verify.h>.
2575 (CHAR_STRING, CHAR_STRING_ADVANCE): Verify that the character
2576 arguments are no wider than unsigned, as a compile-time check
2577 to prevent future regressions in this area.
2578 * data.c (Faset):
01103c44 2579 * editfns.c (Fchar_to_string, general_insert_function, Finsert_char)
13bdea59
PE
2580 (Fsubst_char_in_region):
2581 * fns.c (concat):
2582 * xdisp.c (decode_mode_spec_coding):
2583 Adjust to CHAR_STRING's new requirement.
2584 * editfns.c (Finsert_char, Fsubst_char_in_region):
2585 * fns.c (concat): Check that character args are actually
2586 characters. Without this test, these functions did the wrong
2587 thing with wildly out-of-range values on 64-bit hosts.
2588
d37ca623
PE
2589 Remove incorrect casts to 'unsigned' that lose info on 64-bit hosts.
2590 These casts should not be needed on 32-bit hosts, either.
2591 * keyboard.c (read_char):
2592 * lread.c (Fload): Remove casts to unsigned.
2593
ea204efb
PE
2594 * lisp.h (UNSIGNED_CMP): New macro.
2595 This fixes comparison bugs on 64-bit hosts.
2596 (ASCII_CHAR_P): Use it.
2597 * casefiddle.c (casify_object):
01103c44 2598 * character.h (ASCII_BYTE_P, CHAR_VALID_P)
ea204efb
PE
2599 (SINGLE_BYTE_CHAR_P, CHAR_STRING):
2600 * composite.h (COMPOSITION_ENCODE_RULE_VALID):
2601 * dispextern.h (FACE_FROM_ID):
2602 * keyboard.c (read_char): Use UNSIGNED_CMP.
2603
41cb286c
PE
2604 * xmenu.c (dialog_selection_callback) [!USE_GTK]: Cast to intptr_t,
2605 not to EMACS_INT, to avoid GCC warning.
2606
4a1b9832
PE
2607 * xfns.c (x_set_scroll_bar_default_width): Remove unused 'int' locals.
2608
55daad71
PE
2609 * buffer.h (PTR_BYTE_POS, BUF_PTR_BYTE_POS): Remove harmful cast.
2610 The cast incorrectly truncated 64-bit byte offsets to 32 bits, and
2611 isn't needed on 32-bit machines.
8f95c75c 2612
01103c44
PE
2613 * buffer.c (Fgenerate_new_buffer_name):
2614 Use EMACS_INT for count, not int.
0ceccced 2615 (advance_to_char_boundary): Return EMACS_INT, not int.
e762cafe
PE
2616
2617 * data.c (Qcompiled_function): Now static.
2618
c6f072e7
PE
2619 * window.c (window_body_lines): Now static.
2620
20ce5912
PE
2621 * image.c (gif_load): Rename local to avoid shadowing.
2622
9c4c5f81
PE
2623 * lisp.h (SAFE_ALLOCA_LISP): Check for integer overflow.
2624 (struct Lisp_Save_Value): Use ptrdiff_t, not int, for 'integer' member.
2625 * alloc.c (make_save_value): Integer argument is now of type
2626 ptrdiff_t, not int.
2627 (mark_object): Use ptrdiff_t, not int.
2628 * lisp.h (pD): New macro.
2629 * print.c (print_object): Use it.
2630
c0c5c8ae
PE
2631 * alloc.c: Use EMACS_INT, not int, to count objects.
2632 (total_conses, total_markers, total_symbols, total_vector_size)
2633 (total_free_conses, total_free_markers, total_free_symbols)
01103c44
PE
2634 (total_free_floats, total_floats, total_free_intervals)
2635 (total_intervals, total_strings, total_free_strings):
c0c5c8ae
PE
2636 Now EMACS_INT, not int. All uses changed.
2637 (Fgarbage_collect): Compute overall total using a double, so that
2638 integer overflow is less likely to be a problem. Check for overflow
2639 when converting back to an integer.
5a25e253
PE
2640 (n_interval_blocks, n_string_blocks, n_float_blocks, n_cons_blocks)
2641 (n_vectors, n_symbol_blocks, n_marker_blocks): Remove.
2642 These were 'int' variables that could overflow on 64-bit hosts;
2643 they were never used, so remove them instead of repairing them.
211a0b2a 2644 (nzombies, ngcs, max_live, max_zombies): Now EMACS_INT, not 'int'.
6349ae4d
PE
2645 (inhibit_garbage_collection): Set gc_cons_threshold to max value.
2646 Previously, this ceilinged at INT_MAX, but that doesn't work on
2647 64-bit machines.
e46bb31a 2648 (allocate_pseudovector): Don't use EMACS_INT when int would do.
c0c5c8ae 2649
c78baabf 2650 * alloc.c (Fmake_bool_vector): Don't assume vector size fits in int.
86f61a15 2651 (allocate_vectorlike): Check for ptrdiff_t overflow.
b6439961
PE
2652 (mark_vectorlike, mark_char_table, mark_object): Avoid EMACS_UINT
2653 when a (possibly-narrower) signed value would do just as well.
2654 We prefer using signed arithmetic, to avoid comparison confusion.
c78baabf 2655
c9d624c6
PE
2656 * alloc.c: Catch some string size overflows that we were missing.
2657 (XMALLOC_OVERRUN_CHECK_SIZE) [!XMALLOC_OVERRUN_CHECK]: Define to 0,
2658 for convenience in STRING_BYTES_MAX.
2659 (STRING_BYTES_MAX): New macro, superseding the old one in lisp.h.
2660 The definition here is exact; the one in lisp.h was approximate.
2661 (allocate_string_data): Check for string overflow. This catches
2662 some instances we weren't catching before. Also, it catches
2663 size_t overflow on (unusual) hosts where SIZE_MAX <= min
2664 (PTRDIFF_MAX, MOST_POSITIVE_FIXNUM), e.g., when size_t is 32 bits
2665 and ptrdiff_t and EMACS_INT are both 64 bits.
c78baabf 2666
c9d624c6
PE
2667 * character.c, coding.c, doprnt.c, editfns.c, eval.c:
2668 All uses of STRING_BYTES_MAX replaced by STRING_BYTES_BOUND.
640c8776 2669 * lisp.h (STRING_BYTES_BOUND): Rename from STRING_BYTES_MAX.
c9d624c6 2670
353032ce
PE
2671 * character.c (string_escape_byte8): Fix nbytes/nchars typo.
2672
2bccce07
PE
2673 * alloc.c (Fmake_string): Check for out-of-range init.
2674
0ac30604
SM
26752011-06-15 Stefan Monnier <monnier@iro.umontreal.ca>
2676
2677 * eval.c (Fdefvaralias): Also mark the target as variable-special-p.
2678
c195f2de
JD
26792011-06-14 Jan Djärv <jan.h.d@swipnet.se>
2680
2681 * xfns.c (x_set_scroll_bar_default_width): Remove argument to
2682 xg_get_default_scrollbar_width.
2683
2684 * gtkutil.c: Include emacsgtkfixed.h if HAVE_GTK3.
2685 (int_gtk_range_get_value): Move to the scroll bar part of the file.
2686 (style_changed_cb): Call update_theme_scrollbar_width and call
2687 x_set_scroll_bar_default_width and xg_frame_set_char_size for
2688 all frames (Bug#8505).
2689 (xg_create_frame_widgets): Call emacs_fixed_new if HAVE_GTK3 (Bug#8505).
2690 Call gtk_window_set_resizable if HAVE_GTK3.
2691 (x_wm_set_size_hint): Call emacs_fixed_set_min_size with min width
2692 and height if HAVE_GTK3 (Bug#8505).
2693 (scroll_bar_width_for_theme): New variable.
2694 (update_theme_scrollbar_width): New function.
2695 (xg_get_default_scrollbar_width): Move code to
2696 update_theme_scrollbar_width, just return scroll_bar_width_for_theme.
2697 (xg_initialize): Call update_theme_scrollbar_width.
2698
2699 * gtkutil.h (xg_get_default_scrollbar_width): Remove argument.
2700
2701 * emacsgtkfixed.c, emacsgtkfixed.h: New files.
2702
e10ac9f1
MR
27032011-06-12 Martin Rudalics <rudalics@gmx.at>
2704
2705 * frame.c (make_frame): Call other_buffer_safely instead of
2706 other_buffer.
2707
2708 * window.c (temp_output_buffer_show): Call display_buffer with
2709 second argument Vtemp_buffer_show_specifiers and reset latter
2710 immediately after the call.
2711 (Vtemp_buffer_show_specifiers): New variable.
2712 (auto_window_vscroll_p, next_screen_context_lines)
2713 (Vscroll_preserve_screen_position): Remove leading asterisks from
2714 doc-strings.
2715
2d3c217e 27162011-06-12 Paul Eggert <eggert@cs.ucla.edu>
4475bec4 2717
7b7f97e8 2718 Fix minor problems found by GCC 4.6.0 static checking.
4475bec4
PE
2719 * buffer.c (Qclone_number): Remove for now, as it's unused.
2720 (record_buffer, Funrecord_buffer): Rename local to avoid shadowing.
2721 (record_buffer): Remove unused local.
2722 * frame.c (other_visible_frames, frame_buffer_list): Now static.
2723 (set_frame_buffer_list): Remove; unused.
2724 * frame.h (other_visible_frames): Remove decl.
2725 * keyboard.h (menu_items_inuse): Declare only if USE_GTK || USE_MOTIF.
2726 * lisp.h (frame_buffer_list, set_frame_buffer_list): Remove decls.
2727 (add_gpm_wait_descriptor, delete_gpm_wait_descriptor): Declare only
2728 if HAVE_GPM.
2729 * menu.c (menu_items_inuse): Now static unless USE_GTK || USE_MOTIF.
2730 * process.c (add_gpm_wait_descriptor, delete_gpm_wait_descriptor):
2731 Define only if HAVE_GPM.
2732 * widget.c (EmacsFrameResize, emacsFrameClassRec): Now static.
2733 (update_hints_inhibit): Remove; never set. All uses removed.
2734 * widgetprv.h (emacsFrameClassRec): Remove decl.
2735 * window.c (delete_deletable_window): Now returns void, since it
2736 wasn't returning anything.
2737 (compare_window_configurations): Remove unused locals.
2738 * xfns.c (x_set_scroll_bar_default_width): Remove unused locals.
2739 * xmenu.c (x_menu_set_in_use): Define only if USE_GTK || USE_MOTIF.
4475bec4
PE
2740 (dialog_selection_callback) [!USE_GTK]: Prefer intptr_t for integers
2741 the same widths as pointers. This follows up on the 2011-05-06 patch.
2742 * xterm.c (x_alloc_lighter_color_for_widget): Define only if USE_LUCID.
2743 * xterm.h: Likewise.
2744 (x_menu_set_in_use): Declare only if USE_GTK || USE_MOTIF.
2745
1384b89e
JB
27462011-06-12 Juanma Barranquero <lekktu@gmail.com>
2747
2748 * makefile.w32-in: Update dependencies.
2749 (LISP_H): Add lib/intprops.h.
2750
1100a63c
CY
27512011-06-11 Chong Yidong <cyd@stupidchicken.com>
2752
2753 * image.c (gif_load): Add animation frame delay to the metadata.
2754 (syms_of_image): Use DEFSYM. New symbol `delay'.
2755
6198ccd0
MR
27562011-06-11 Martin Rudalics <rudalics@gmx.at>
2757
2758 * window.c (delete_deletable_window): Re-add.
2759 (Fset_window_configuration): Rewrite to handle dead buffers and
2760 consequently deletable windows.
2761 (window_tree, Fwindow_tree): Remove. Supply functionality in
2762 window.el.
2763 (compare_window_configurations): Simplify code.
2764
b6e3633c
AS
27652011-06-11 Andreas Schwab <schwab@linux-m68k.org>
2766
1ab0dee5
AS
2767 * image.c (imagemagick_load_image): Fix type mismatch.
2768 (Fimagemagick_types): Likewise.
2769
b6e3633c
AS
2770 * window.h (replace_buffer_in_windows): Declare.
2771
9397e56f
MR
27722011-06-11 Martin Rudalics <rudalics@gmx.at>
2773
2774 * buffer.c: New Lisp objects Qbuffer_list_update_hook and
2775 Qclone_number. Remove external declaration of Qdelete_window.
2776 (Fbuffer_list): Rewrite doc-string. Minor restructuring of
2777 code.
640c8776
SM
2778 (Fget_buffer_create, Fmake_indirect_buffer, Frename_buffer):
2779 Run Qbuffer_list_update_hook if allowed.
9397e56f
MR
2780 (Fother_buffer): Rewrite doc-string. Major rewrite for new
2781 buffer list implementation.
2782 (other_buffer_safely): New function.
2783 (Fkill_buffer): Replace call to replace_buffer_in_all_windows by
2784 calls to replace_buffer_in_windows and
2785 replace_buffer_in_windows_safely. Run Qbuffer_list_update_hook
2786 if allowed.
2787 (record_buffer): Inhibit quitting and rewrite using quittable
2788 functions. Run Qbuffer_list_update_hook if allowed.
2789 (Frecord_buffer, Funrecord_buffer): New functions.
640c8776
SM
2790 (switch_to_buffer_1, Fswitch_to_buffer): Remove.
2791 Move switch-to-buffer to window.el.
9397e56f
MR
2792 (bury-buffer): Move to window.el.
2793 (Vbuffer_list_update_hook): New variable.
2794
2795 * lisp.h (other_buffer_safely): Add prototype in buffer.c
2796 section.
2797
2798 * window.h (resize_frame_windows): Move up in code.
2799 (Fwindow_frame): Remove EXFUN.
2800 (replace_buffer_in_all_windows): Remove prototype.
2801 (replace_buffer_in_windows_safely): Add prototype.
2802
2803 * window.c: Declare Qdelete_window static again. Move down
2804 declaration of select_count.
2805 (Fnext_window, Fprevious_window): Rewrite doc-strings.
2806 (Fother_window): Move to window.el.
2807 (window_loop): Remove DELETE_BUFFER_WINDOWS and UNSHOW_BUFFER
2808 cases. Add REPLACE_BUFFER_IN_WINDOWS_SAFELY case.
2809 (Fdelete_windows_on, Freplace_buffer_in_windows): Move to
2810 window.el.
2811 (replace_buffer_in_windows): Implement by calling
2812 Qreplace_buffer_in_windows.
2813 (replace_buffer_in_all_windows): Remove with some functionality
2814 moved into replace_buffer_in_windows_safely.
2815 (replace_buffer_in_windows_safely): New function.
2816 (select_window_norecord, select_frame_norecord): Move in front
2817 of run_window_configuration_change_hook. Remove now obsolete
2818 declarations.
640c8776
SM
2819 (Fset_window_buffer): Rewrite doc-string.
2820 Call Qrecord_window_buffer.
9397e56f
MR
2821 (keys_of_window): Move binding for other-window to window.el.
2822
b50691aa
CY
28232011-06-11 Chong Yidong <cyd@stupidchicken.com>
2824
2825 * dispextern.h (struct image): Replace data member, whose int_val
2826 and ptr_val fields were not used by anything, with a single
2827 lisp_val object.
2828
2829 * image.c (Fimage_metadata, make_image, mark_image, tiff_load)
2830 (gif_clear_image, gif_load, imagemagick_load_image)
2831 (gs_clear_image, gs_load): Callers changed.
2832
3f754b86
PE
28332011-06-10 Paul Eggert <eggert@cs.ucla.edu>
2834
cca69397
PE
2835 * buffer.h: Include <time.h>, for time_t.
2836 Needed to build on FreeBSD 8.2. Problem reported by Herbert J. Skuhra.
2837
109e28d0
PE
2838 Fix minor problems found by static checking.
2839
60737f02
PE
2840 * image.c (PixelGetMagickColor): Declare if ImageMagick headers don't.
2841
4b66faf3
PE
2842 Make identifiers static if they are not used in other modules.
2843 * data.c (Qcompiled_function, Qframe, Qvector):
2844 * image.c (QimageMagick, Qsvg):
2845 * minibuf.c (Qmetadata):
2846 * window.c (resize_window_check, resize_root_window): Now static.
2847 * window.h (resize_window_check, resize_root_window): Remove decls.
2848
109e28d0
PE
2849 * window.c (window_deletion_count, delete_deletable_window):
2850 Remove; unused.
46a4ce9e
PE
2851 (window_body_lines): Now static.
2852 (Fdelete_other_windows_internal): Mark vars as initialized.
2853 Make sure 'resize_failed' is initialized.
2854 (run_window_configuration_change_hook): Rename local to avoid shadowing.
2855 (resize_window_apply): Remove unused local.
2856 * window.h (delete_deletable_window): Remove decl.
2857
109e28d0 2858 * image.c (gif_load, svg_load_image): Rename locals to avoid shadowing.
33290528
PE
2859 (imagemagick_load_image): Fix pointer signedness problem by changing
2860 last arg from unsigned char * to char *. All uses changed.
2861 Also, fix a local for similar reasons.
2862 Remove unused locals. Remove locals to avoid shadowing.
2863 (fn_rsvg_handle_free): Remove; unused.
2864 (svg_load, svg_load_image): Fix pointer signedness problem.
f7e13da3 2865 (imagemagick_load_image): Don't use garbage pointer image_wand.
33290528 2866
3f754b86
PE
2867 * ftfont.c (ftfont_get_metrics, ftfont_drive_otf): Remove unused locals.
2868
2547adb1
CY
28692011-06-10 Chong Yidong <cyd@stupidchicken.com>
2870
2871 * image.c (gif_load): Fix omitted cast error introduced by
2872 2011-06-06 change.
2873
2c8e37d4
MR
28742011-06-10 Martin Rudalics <rudalics@gmx.at>
2875
2876 * window.h (resize_proportionally, orig_total_lines)
2877 (orig_top_line): Remove from window structure.
2878 (set_window_height, set_window_width, change_window_heights)
2879 (Fdelete_window): Remove prototypes.
2880 (resize_frame_windows): Remove duplicate declaration.
2881
440a42e3
EZ
28822011-06-10 Eli Zaretskii <eliz@gnu.org>
2883
2884 * window.h (resize_frame_windows, resize_window_check)
2885 (delete_deletable_window, resize_root_window)
2886 (resize_frame_windows): Declare prototypes.
2887
2888 * window.c (resize_window_apply): Make definition be "static" to
2889 match the prototype.
2890
562dd5e9
MR
28912011-06-10 Martin Rudalics <rudalics@gmx.at>
2892
2893 * window.c: Remove declarations of Qwindow_size_fixed,
2894 window_min_size_1, window_min_size_2, window_min_size,
2895 size_window, window_fixed_size_p, enlarge_window, delete_window.
2896 Remove static from declaration of Qdelete_window, it's
2897 temporarily needed by Fbury_buffer.
2898 (replace_window): Don't assign orig_top_line and
2899 orig_total_lines.
2900 (Fdelete_window, delete_window): Remove. Window deletion is
2901 handled by window.el.
640c8776
SM
2902 (window_loop): Remove DELETE_OTHER_WINDOWS case.
2903 Replace Fdelete_window calls with calls to Qdelete_window.
562dd5e9
MR
2904 (Fdelete_other_windows): Remove. Deleting other windows is
2905 handled by window.el.
2906 (window_fixed_size_p): Remove. Fixed-sizeness of windows is
2907 handled in window.el.
2908 (window_min_size_2, window_min_size_1, window_min_size): Remove.
2909 Window minimum sizes are handled in window.el.
2910 (shrink_windows, size_window, set_window_height)
2911 (set_window_width, change_window_heights, window_height)
2912 (window_width, CURBEG, CURSIZE, enlarge_window)
2913 (adjust_window_trailing_edge, Fadjust_window_trailing_edge)
2914 (Fenlarge_window, Fshrink_window): Remove. Window resizing is
2915 handled in window.el.
2916 (make_dummy_parent): Rename to make_parent_window and give it a
2917 second argument horflag.
2918 (make_window): Don't set resize_proportionally any more.
2919 (Fsplit_window): Remove. Windows are split in window.el.
2920 (save_restore_action, save_restore_orig_size)
2921 (shrink_window_lowest_first, save_restore_orig_size): Remove.
2922 Resize mini windows in window.el.
2923 (grow_mini_window, shrink_mini_window): Implement by calling
2924 Qresize_root_window_vertically, resize_window_check and
2925 resize_window_apply.
640c8776
SM
2926 (saved_window, Fset_window_configuration, save_window_save):
2927 Do not handle orig_top_line, orig_total_lines, and
562dd5e9
MR
2928 resize_proportionally.
2929 (window_min_height, window_min_width): Move to window.el.
2930 (keys_of_window): Move bindings for delete-other-windows,
2931 split-window, delete-window and enlarge-window to window.el.
2932
2933 * buffer.c: Temporarily extern Qdelete_window.
2934 (Fbury_buffer): Temporarily call Qdelete_window instead of
2935 Fdelete_window (Fbury_buffer will move to window.el soon).
2936
2937 * frame.c (set_menu_bar_lines_1): Remove code handling
2938 orig_top_line and orig_total_lines.
2939
2940 * dispnew.c (adjust_frame_glyphs_initially): Don't use
2941 set_window_height but set heights directly.
2942 (change_frame_size_1): Use resize_frame_windows.
2943
2944 * xdisp.c (init_xdisp): Don't use set_window_height but set
2945 heights directly.
2946
640c8776
SM
2947 * xfns.c (x_set_menu_bar_lines, x_set_tool_bar_lines):
2948 Use resize_frame_windows instead of change_window_heights and run
562dd5e9
MR
2949 run_window_configuration_change_hook.
2950
2951 * w32fns.c (x_set_tool_bar_lines): Use resize_frame_windows
2952 instead of change_window_heights and run
2953 run_window_configuration_change_hook.
2954
1a13852e
MR
29552011-06-09 Martin Rudalics <rudalics@gmx.at>
2956
2957 * window.c (replace_window): Rename second argument REPLACEMENT to
2958 NEW. New third argument SETFLAG. Rewrite.
2959 (delete_window, make_dummy_parent): Call replace_window with
2960 third argument 1.
2961 (window_list_1): Move down in code.
2962 (run_window_configuration_change_hook): Move set_buffer part
2963 before select_frame_norecord part in order to unwind correctly.
2964 Rename count1 to count.
2965 (recombine_windows, delete_deletable_window, resize_root_window)
2966 (Fdelete_other_windows_internal)
2967 (Frun_window_configuration_change_hook, make_parent_window)
2968 (resize_window_check, resize_window_apply, Fresize_window_apply)
2969 (resize_frame_windows, Fsplit_window_internal)
640c8776
SM
2970 (Fdelete_window_internal, Fresize_mini_window_internal):
2971 New functions.
1a13852e
MR
2972 (syms_of_window): New variables Vwindow_splits and Vwindow_nest.
2973
f3d1777e
MR
29742011-06-08 Martin Rudalics <rudalics@gmx.at>
2975
496e208e
MR
2976 * window.h (window): Add some new members to window structure -
2977 normal_lines, normal_cols, new_total, new_normal, clone_number,
2978 splits, nest, prev_buffers, next_buffers.
2979 (WINDOW_TOTAL_SIZE): Move here from window.c.
b9e809c2 2980 (MIN_SAFE_WINDOW_WIDTH, MIN_SAFE_WINDOW_HEIGHT): Define here.
496e208e 2981
f3d1777e
MR
2982 * window.c (Fwindow_height, Fwindow_width, Fwindow_full_width_p):
2983 Remove.
496e208e
MR
2984 (make_dummy_parent): Set new members of windows structure.
2985 (make_window): Move down in code. Handle new members of window
2986 structure.
2987 (Fwindow_clone_number, Fwindow_splits, Fset_window_splits)
2988 (Fwindow_nest, Fset_window_nest, Fwindow_new_total)
2989 (Fwindow_normal_size, Fwindow_new_normal, Fwindow_prev_buffers)
2990 (Fset_window_prev_buffers, Fwindow_next_buffers)
640c8776
SM
2991 (Fset_window_next_buffers, Fset_window_clone_number):
2992 New functions.
496e208e
MR
2993 (Fwindow_hscroll, Fwindow_at, Fwindow_point, Fwindow_start)
2994 (Fwindow_end, Fwindow_line_height, Fset_window_dedicated_p):
2995 Doc-string fixes.
2996 (Fwindow_parameters, Fwindow_parameter, Fset_window_parameter):
2997 Argument WINDOW can be now internal window too.
2998 (Fwindow_use_time): Move up in code.
2999 (Fget_buffer_window): Rename argument FRAME to ALL-FRAMES.
3000 Rewrite doc-string.
3001 (Fset_window_configuration, saved_window)
3002 (Fcurrent_window_configuration, save_window_save): Handle new
3003 members of window structure.
b9e809c2
MR
3004 (WINDOW_TOTAL_SIZE, MIN_SAFE_WINDOW_WIDTH)
3005 (MIN_SAFE_WINDOW_HEIGHT): Move to window.h.
3006 (syms_of_window): New Lisp objects Qrecord_window_buffer,
3007 Qwindow_deletable_p, Qdelete_window, Qreplace_buffer_in_windows,
3008 Qget_mru_window, Qresize_root_window,
3009 Qresize_root_window_vertically, Qsafe, Qabove, Qbelow,
3010 Qauto_buffer_name; staticpro them.
f3d1777e 3011
abde8f8c
MR
30122011-06-07 Martin Rudalics <rudalics@gmx.at>
3013
3014 * window.c (Fwindow_total_size, Fwindow_left_column)
3015 (Fwindow_top_line, window_body_lines, Fwindow_body_size)
3016 (Fwindow_list_1): New functions.
3017 (window_box_text_cols): Replace with window_body_cols.
640c8776
SM
3018 (Fwindow_width, Fscroll_left, Fscroll_right):
3019 Use window_body_cols instead of window_box_text_cols.
3020 (delete_window, Fset_window_configuration):
3021 Call delete_all_subwindows with window as argument.
fa8a67e6
MR
3022 (delete_all_subwindows): Take a window as argument and not a
3023 structure. Rewrite.
190b47e6
MR
3024 (window_loop): Remove handling of GET_LRU_WINDOW and
3025 GET_LARGEST_WINDOW.
3026 (Fget_lru_window, Fget_largest_window): Move to window.el.
abde8f8c
MR
3027
3028 * window.h: Extern window_body_cols instead of
fa8a67e6
MR
3029 window_box_text_cols. delete_all_subwindows now takes a
3030 Lisp_Object as argument.
abde8f8c 3031
640c8776
SM
3032 * indent.c (compute_motion, Fcompute_motion):
3033 Use window_body_cols instead of window_box_text_cols.
abde8f8c 3034
fa8a67e6
MR
3035 * frame.c (delete_frame): Call delete_all_subwindows with root
3036 window as argument.
3037
a54e3482
DC
30382011-06-07 Daniel Colascione <dan.colascione@gmail.com>
3039
3040 * fns.c (Fputhash): Document return value.
3041
60002bf5
CY
30422011-06-06 Chong Yidong <cyd@stupidchicken.com>
3043
3044 * image.c (gif_load): Implement gif89a spec "no disposal" method.
3045
0c671da6 30462011-06-06 Paul Eggert <eggert@cs.ucla.edu>
ccd9a01a 3047
b862a52a 3048 Cons<->int and similar integer overflow fixes (Bug#8794).
77984278 3049
be44ca6c
PE
3050 Check for overflow when converting integer to cons and back.
3051 * charset.c (Fdefine_charset_internal, Fdecode_char):
3052 Use cons_to_unsigned to catch overflow.
3053 (Fencode_char): Use INTEGER_TO_CONS.
3054 * composite.h (LGLYPH_CODE): Use cons_to_unsigned.
3055 (LGLYPH_SET_CODE): Use INTEGER_TO_CONS.
3056 * data.c (long_to_cons, cons_to_long): Remove.
3057 (cons_to_unsigned, cons_to_signed): New functions.
3058 These signal an error for invalid or out-of-range values.
3059 * dired.c (Ffile_attributes): Use INTEGER_TO_CONS.
3060 * fileio.c (Fset_visited_file_modtime): Use CONS_TO_INTEGER.
3061 * font.c (Ffont_variation_glyphs):
3062 * fontset.c (Finternal_char_font): Use INTEGER_TO_CONS.
3063 * lisp.h: Include <intprops.h>.
3064 (INTEGER_TO_CONS, CONS_TO_INTEGER): New macros.
3065 (cons_to_signed, cons_to_unsigned): New decls.
3066 (long_to_cons, cons_to_long): Remove decls.
3067 * undo.c (record_first_change): Use INTEGER_TO_CONS.
3068 (Fprimitive_undo): Use CONS_TO_INTEGER.
3069 * xfns.c (Fx_window_property): Likewise.
3070 * xselect.c: Include <limits.h>.
3071 (x_own_selection, selection_data_to_lisp_data):
3072 Use INTEGER_TO_CONS.
3073 (x_handle_selection_request, x_handle_selection_clear)
3074 (x_get_foreign_selection, Fx_disown_selection_internal)
3075 (Fx_get_atom_name, x_send_client_event): Use CONS_TO_INTEGER.
3076 (lisp_data_to_selection_data): Use cons_to_unsigned.
3077 (x_fill_property_data): Use cons_to_signed.
3078 Report values out of range.
3079
d1f3d2af
PE
3080 Check for buffer and string overflow more precisely.
3081 * buffer.h (BUF_BYTES_MAX): New macro.
3082 * lisp.h (STRING_BYTES_MAX): New macro.
3083 * alloc.c (Fmake_string):
3084 * character.c (string_escape_byte8):
3085 * coding.c (coding_alloc_by_realloc):
3086 * doprnt.c (doprnt):
3087 * editfns.c (Fformat):
3088 * eval.c (verror):
3089 Use STRING_BYTES_MAX, not MOST_POSITIVE_FIXNUM,
3090 since they may not be the same number.
3091 * editfns.c (Finsert_char):
3092 * fileio.c (Finsert_file_contents):
3093 Likewise for BUF_BYTES_MAX.
3094
dd52fcea
PE
3095 * image.c: Use ptrdiff_t, not int, for sizes.
3096 (slurp_file): Switch from int to ptrdiff_t.
3097 All uses changed.
3098 (slurp_file): Check that file size fits in both size_t (for
3099 malloc) and ptrdiff_t (for sanity and safety).
3100
7f9bbdbb
PE
3101 * fileio.c (Fverify_visited_file_modtime): Avoid time overflow
3102 if b->modtime has its maximal value.
3103
dfe18f82
PE
3104 * dired.c (Ffile_attributes): Don't assume EMACS_INT has >32 bits.
3105
84acfcf0
PE
3106 Don't assume time_t can fit into int.
3107 * buffer.h (struct buffer.modtime): Now time_t, not int.
3108 * fileio.c (Fvisited_file_modtime): No need for time_t cast now.
3109 * undo.c (Fprimitive_undo): Use time_t, not int, for time_t value.
3110
ccd9a01a
PE
3111 Minor fixes for signed vs unsigned integers.
3112 * character.h (MAYBE_UNIFY_CHAR):
3113 * charset.c (maybe_unify_char):
3114 * keyboard.c (read_char, reorder_modifiers):
3115 XINT -> XFASTINT, since the integer must be nonnegative.
3116 * ftfont.c (ftfont_spec_pattern):
3117 * keymap.c (access_keymap, silly_event_symbol_error):
3118 XUINT -> XFASTINT, since the integer must be nonnegative.
3119 (Fsingle_key_description, preferred_sequence_p): XUINT -> XINT,
3120 since it makes no difference and we prefer signed.
3121 * keyboard.c (record_char): Use XUINT when all the neighbors do.
3122 (access_keymap): NATNUMP -> INTEGERP, since the integer must be
3123 nonnegative.
3124
d6d100dd
SM
31252011-06-06 Stefan Monnier <monnier@iro.umontreal.ca>
3126
3127 * window.h (Fwindow_frame): Declare.
3128
2b6148e4
PE
31292011-06-06 Paul Eggert <eggert@cs.ucla.edu>
3130
3131 * alloc.c: Simplify handling of large-request failures (Bug#8800).
3132 (SPARE_MEMORY): Always define.
3133 (LARGE_REQUEST): Remove.
3134 (memory_full): Use SPARE_MEMORY rather than LARGE_REQUEST.
3135
f230ecc9
MR
31362011-06-06 Martin Rudalics <rudalics@gmx.at>
3137
727e958e
MR
3138 * lisp.h: Move EXFUNS for Fframe_root_window,
3139 Fframe_first_window and Fset_frame_selected_window to window.h.
3140
3141 * window.h: Move EXFUNS for Fframe_root_window,
3142 Fframe_first_window and Fset_frame_selected_window here from
3143 lisp.h.
3144
3145 * frame.c (Fwindow_frame, Fframe_first_window)
3146 (Fframe_root_window, Fframe_selected_window)
3147 (Fset_frame_selected_window): Move to window.c.
3148 (Factive_minibuffer_window): Move to minibuf.c.
3149 (Fother_visible_frames_p): New function.
3150
3151 * minibuf.c (Factive_minibuffer_window): Move here from frame.c.
3152
f230ecc9
MR
3153 * window.c (decode_window, decode_any_window): Move up in code.
3154 (Fwindowp, Fwindow_live_p): Rewrite doc-strings.
3155 (inhibit_frame_unsplittable): Remove unused variable.
bf60a96b
MR
3156 (Fwindow_buffer): Move up and rewrite doc-string.
3157 (Fwindow_parent, Fwindow_vchild, Fwindow_hchild, Fwindow_next)
3158 (Fwindow_prev): New functions.
727e958e
MR
3159 (Fwindow_frame): Move here from frame.c. Accept any window as
3160 argument.
3161 (Fframe_root_window, Fframe_first_window)
3162 (Fframe_selected_window): Move here from frame.c. Accept frame
3163 or arbitrary window as argument. Update doc-strings.
3164 (Fminibuffer_window): Move up in code.
3165 (Fwindow_minibuffer_p): Move up in code and simplify.
d6d100dd
SM
3166 (Fset_frame_selected_window): Move here from frame.c.
3167 Marginal rewrite.
727e958e
MR
3168 (Fselected_window, select_window, Fselect_window): Move up in
3169 code. Minor doc-string fixes.
f230ecc9 3170
4d09bcf6
PE
31712011-06-06 Paul Eggert <eggert@cs.ucla.edu>
3172
3173 * alloc.c (memory_full) [SYSTEM_MALLOC]: Port to MacOS (Bug#8800).
3174 Do not assume that spare memory exists; that assumption is valid
3175 only if SYSTEM_MALLOC.
3176 (LARGE_REQUEST): New macro, so that the issue of large requests
3177 is separated from the issue of spare memory.
3178
810928a2
AS
31792011-06-05 Andreas Schwab <schwab@linux-m68k.org>
3180
172418ad
AS
3181 * editfns.c (Fformat): Correctly handle zero flag with hexadecimal
3182 format. (Bug#8806)
3183
43f862f7
AS
3184 * gtkutil.c (xg_get_default_scrollbar_width): Avoid warning.
3185
810928a2
AS
3186 * xfns.c (x_set_scroll_bar_default_width): Move declarations
3187 before statements.
3188
a059fe24
JD
31892011-06-05 Jan Djärv <jan.h.d@swipnet.se>
3190
3191 * gtkutil.c (xg_get_default_scrollbar_width): New function.
3192
3193 * gtkutil.h: Declare xg_get_default_scrollbar_width.
3194
3195 * xfns.c (x_set_scroll_bar_default_width): If USE_GTK, get
3196 min width by calling x_set_scroll_bar_default_width (Bug#8505).
3197
989bf368
JB
31982011-06-05 Juanma Barranquero <lekktu@gmail.com>
3199
3200 * xdisp.c (single_display_spec_intangible_p): Remove declaration.
3201
4b80f674
CY
32022011-06-04 Chong Yidong <cyd@stupidchicken.com>
3203
3204 * xselect.c (x_clipboard_manager_save): Remove redundant arg.
3205 (x_clipboard_manager_save): Add return value.
d6d100dd
SM
3206 (x_clipboard_manager_error_1, x_clipboard_manager_error_2):
3207 New error handlers.
4b80f674
CY
3208 (x_clipboard_manager_save_frame, x_clipboard_manager_save_all):
3209 Obey Vx_select_enable_clipboard_manager. Catch errors in
3210 x_clipboard_manager_save (Bug#8779).
3211 (Vx_select_enable_clipboard_manager): New variable.
de65b42c 3212 (x_get_foreign_selection): Reduce scope of x_catch_errors (Bug#8790).
4b80f674 3213
99a33b77 32142011-06-04 Dan Nicolaescu <dann@ics.uci.edu>
8b3115e7
DN
3215
3216 * emacs.c (main): Warn when starting a GTK emacs in daemon mode.
3217
99a33b77 32182011-06-04 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
14eca62f
YM
3219
3220 * fringe.c (update_window_fringes): Don't update overlay arrow bitmap
3221 in the current matrix if keep_current_p is non-zero.
3222
8264569d
EZ
32232011-06-04 Eli Zaretskii <eliz@gnu.org>
3224
3225 * bidi.c (bidi_level_of_next_char): Fix last change.
3226
57f97249
EZ
32272011-06-03 Eli Zaretskii <eliz@gnu.org>
3228
fec2107c 3229 Support bidi reordering of text covered by display properties.
57f97249 3230
fec2107c
EZ
3231 * bidi.c (bidi_copy_it): Use offsetof instead of emulating it.
3232 (bidi_fetch_char, bidi_fetch_char_advance): New functions.
3233 (bidi_cache_search, bidi_cache_iterator_state)
3234 (bidi_paragraph_init, bidi_resolve_explicit, bidi_resolve_weak)
d6d100dd
SM
3235 (bidi_level_of_next_char, bidi_move_to_visually_next):
3236 Support character positions inside a run of characters covered by a
fec2107c
EZ
3237 display string.
3238 (bidi_paragraph_init, bidi_resolve_explicit_1)
3239 (bidi_level_of_next_char): Call bidi_fetch_char and
3240 bidi_fetch_char_advance instead of FETCH_CHAR and
3241 FETCH_CHAR_ADVANCE.
3242 (bidi_init_it): Initialize new members.
3243 (LRE_CHAR, RLE_CHAR, PDF_CHAR, LRO_CHAR, RLO_CHAR): Remove macro
3244 definitions.
3245 (bidi_explicit_dir_char): Lookup character type in bidi_type_table,
3246 instead of using explicit *_CHAR codes.
d6d100dd
SM
3247 (bidi_resolve_explicit, bidi_resolve_weak):
3248 Use FETCH_MULTIBYTE_CHAR instead of FETCH_CHAR, as reordering of
fec2107c
EZ
3249 bidirectional text is supported only in multibyte buffers.
3250 (bidi_init_it): Accept additional argument FRAME_WINDOW_P and use
3251 it to initialize the frame_window_p member of struct bidi_it.
3252 (bidi_cache_iterator_state, bidi_resolve_explicit_1)
3253 (bidi_resolve_explicit, bidi_resolve_weak)
3254 (bidi_level_of_next_char, bidi_move_to_visually_next): Abort if
3255 bidi_it->nchars is non-positive.
3256 (bidi_level_of_next_char): Don't try to lookup the cache for the
3257 next/previous character if nothing is cached there yet, or if we
3258 were just reseat()'ed to a new position.
c40e2fb2 3259
0e14fe90
EZ
3260 * xdisp.c (set_cursor_from_row): Set start and stop points
3261 according to the row's direction when priming the loop that looks
3262 for the glyph on which to display cursor.
3263 (single_display_spec_intangible_p): Function deleted.
3264 (display_prop_intangible_p): Reimplement to call
3265 handle_display_spec instead of single_display_spec_intangible_p.
d6d100dd
SM
3266 Accept 3 additional arguments needed by handle_display_spec.
3267 This fixes incorrect cursor motion across display property with complex
0e14fe90
EZ
3268 values: lists, `(when COND...)' forms, etc.
3269 (single_display_spec_string_p): Support property values that are
3270 lists with the argument STRING its top-level element.
3271 (display_prop_string_p): Fix the condition for processing a
3272 property that is a list to be consistent with handle_display_spec.
fec2107c 3273 (handle_display_spec): New function, refactored from the
fc6f18ce
EZ
3274 last portion of handle_display_prop.
3275 (compute_display_string_pos): Accept additional argument
3276 FRAME_WINDOW_P. Call handle_display_spec to determine whether the
3277 value of a `display' property is a "replacing spec".
3278 (handle_single_display_spec): Accept 2 additional arguments BUFPOS
3279 and FRAME_WINDOW_P. If IT is NULL, don't set up the iterator from
3280 the display property, but just return a value indicating whether
3281 the display property will replace the characters it covers.
3282 (Fcurrent_bidi_paragraph_direction): Initialize the nchars and
3283 frame_window_p members of struct bidi_it.
d6d100dd
SM
3284 (compute_display_string_pos, compute_display_string_end):
3285 New functions.
fec2107c
EZ
3286 (push_it): Accept second argument POSITION, where pop_it should
3287 jump to continue iteration.
3288 (reseat_1): Initialize bidi_it.disp_pos.
fc6f18ce 3289
fec2107c
EZ
3290 * keyboard.c (adjust_point_for_property): Adjust the call to
3291 display_prop_intangible_p to its new signature.
fc6f18ce
EZ
3292
3293 * dispextern.h (struct bidi_it): New member frame_window_p.
fec2107c
EZ
3294 (bidi_init_it): Update prototypes.
3295 (display_prop_intangible_p): Update prototype.
d6d100dd
SM
3296 (compute_display_string_pos, compute_display_string_end):
3297 Declare prototypes.
fec2107c
EZ
3298 (struct bidi_it): New members nchars and disp_pos. ch_len is now
3299 EMACS_INT.
fc6f18ce 3300
40087514 33012011-06-02 Paul Eggert <eggert@cs.ucla.edu>
0de4bb68 3302
57f53182
PE
3303 Malloc failure behavior now depends on size of allocation.
3304 * alloc.c (buffer_memory_full, memory_full): New arg NBYTES.
3305 * lisp.h: Change signatures accordingly.
3306 * alloc.c, buffer.c, editfns.c, menu.c, minibuf.c, xterm.c:
3307 All callers changed. (Bug#8762)
3308
3309 * gnutls.c: Use Emacs's memory allocators.
3310 Without this change, the gnutls library would invoke malloc etc.
3311 directly, which causes problems on non-SYNC_INPUT hosts, and which
3312 runs afoul of improving memory_full behavior. (Bug#8761)
3313 (fn_gnutls_global_set_mem_functions): New macro or function pointer.
3314 (emacs_gnutls_global_init): Use it to specify xmalloc, xrealloc,
3315 xfree instead of the default malloc, realloc, free.
3316 (Fgnutls_boot): No need to check for memory allocation failure,
3317 since xmalloc does that for us.
3318
ac32cd99 3319 Remove arbitrary limit of 2**31 entries in hash tables. (Bug#8771)
3870d916
PE
3320 * category.c (hash_get_category_set):
3321 * ccl.c (ccl_driver):
3322 * charset.c (Fdefine_charset_internal):
3323 * charset.h (struct charset.hash_index):
3324 * composite.c (get_composition_id, gstring_lookup_cache)
3325 (composition_gstring_put_cache):
3326 * composite.h (struct composition.hash_index):
3327 * dispextern.h (struct image.hash):
3328 * fns.c (next_almost_prime, larger_vector, cmpfn_eql)
3329 (cmpfn_equal, cmpfn_user_defined, hashfn_eq, hashfn_eql)
3330 (hashfn_equal, hashfn_user_defined, make_hash_table)
3331 (maybe_resize_hash_table, hash_lookup, hash_put)
3332 (hash_remove_from_table, hash_clear, sweep_weak_table, SXHASH_COMBINE)
3333 (sxhash_string, sxhash_list, sxhash_vector, sxhash_bool_vector)
3334 (Fsxhash, Fgethash, Fputhash, Fmaphash):
3335 * image.c (make_image, search_image_cache, lookup_image)
3336 (xpm_put_color_table_h):
3337 * lisp.h (struct Lisp_Hash_Table):
0de4bb68 3338 * minibuf.c (Ftry_completion, Fall_completions, Ftest_completion):
ac389d0c 3339 * print.c (print): Use 'EMACS_UINT' and 'EMACS_INT'
3870d916 3340 for hashes and hash indexes, instead of 'unsigned' and 'int'.
40087514
PE
3341 * alloc.c (allocate_vectorlike):
3342 Check for overflow in vector size calculations.
3343 * ccl.c (ccl_driver):
3344 Check for overflow when converting EMACS_INT to int.
0de4bb68
PE
3345 * fns.c, image.c: Remove unnecessary static decls that would otherwise
3346 need to be updated by these changes.
40087514
PE
3347 * fns.c (make_hash_table, maybe_resize_hash_table):
3348 Check for integer overflow with large hash tables.
0de4bb68
PE
3349 (make_hash_table, maybe_resize_hash_table, Fmake_hash_table):
3350 Prefer the faster XFLOAT_DATA to XFLOATINT where either will do.
3351 (SXHASH_REDUCE): New macro.
3352 (sxhash_string, sxhash_list, sxhash_vector, sxhash_bool_vector):
3353 Use it instead of discarding useful hash info with large hash values.
3354 (sxhash_float): New function.
3355 (sxhash): Use it. No more need for "& INTMASK" due to above changes.
3356 * lisp.h (FIXNUM_BITS): New macro, useful for SXHASH_REDUCE etc.
40087514
PE
3357 (MOST_NEGATIVE_FIXNUM, MOST_POSITIVE_FIXNUM, INTMASK):
3358 Rewrite to use FIXNUM_BITS, as this simplifies things.
0de4bb68
PE
3359 (next_almost_prime, larger_vector, sxhash, hash_lookup, hash_put):
3360 Adjust signatures to match updated version of code.
3361 (consing_since_gc): Now EMACS_INT, since a single hash table can
3362 use more than INT_MAX bytes.
3363
698d32e2
DN
33642011-06-01 Dan Nicolaescu <dann@ics.uci.edu>
3365
3366 Make it possible to build with GCC-4.6+ -O2 -flto.
3367
3368 * emacs.c (__malloc_initialize_hook): Mark as EXTERNALLY_VISIBLE.
3369
fd6fa53f
SM
33702011-06-01 Stefan Monnier <monnier@iro.umontreal.ca>
3371
3372 * minibuf.c (get_minibuffer, read_minibuf_unwind):
3373 Call minibuffer-inactive-mode.
3374
864db017
JB
33752011-05-31 Juanma Barranquero <lekktu@gmail.com>
3376
3377 * makefile.w32-in ($(BLD)/data.$(O), $(BLD)/editfns.$(O)):
3378 Update dependencies.
3379
2ad0baf4
DN
33802011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
3381
3382 * data.c (init_data): Remove code for UTS, this system is not
3383 supported anymore.
3384
4fcc2638
DN
33852011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
3386
3387 Don't force ./temacs to start in terminal mode.
3388
3389 * frame.c (make_initial_frame): Initialize faces in all cases, not
3390 only when CANNOT_DUMP is defined.
3391 * dispnew.c (init_display): Remove CANNOT_DUMP condition.
3392
c56e0fd5
DN
33932011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
3394
3395 * dispnew.c (add_window_display_history): Use const for the string
3396 pointer. Remove declaration, not needed.
3397
333d54da 33982011-05-31 Paul Eggert <eggert@cs.ucla.edu>
9cf9f756 3399
55d4c1b2 3400 Use 'inline', not 'INLINE'.
333d54da 3401 <http://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00914.html>
55d4c1b2
PE
3402 * alloc.c, fontset.c (INLINE): Remove.
3403 * alloc.c, bidi.c, charset.c, coding.c, dispnew.c, fns.c, image.c:
3404 * intervals.c, keyboard.c, process.c, syntax.c, textprop.c, w32term.c:
3405 * xdisp.c, xfaces.c, xterm.c: Replace all uses of INLINE with inline.
3406 * gmalloc.c (register_heapinfo): Use inline unconditionally.
3407 * lisp.h (LISP_MAKE_RVALUE): Use inline, not __inline__.
3408
738db178
DN
34092011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
3410
3411 Make it possible to run ./temacs.
3412
3413 * callproc.c (set_initial_environment): Remove CANNOT_DUMP code,
3414 syms_of_callproc does the same thing. Remove test for
3415 "initialized", do it in the caller.
3416 * emacs.c (main): Avoid calling set_initial_environment when dumping.
3417
620c53a6
SM
34182011-05-31 Stefan Monnier <monnier@iro.umontreal.ca>
3419
3420 * minibuf.c (Finternal_complete_buffer): Return `category' metadata.
3421 (read_minibuf): Use get_minibuffer.
3422 (syms_of_minibuf): Use DEFSYM.
3423 (Qmetadata): New var.
3424 * data.c (Qbuffer): Don't make it static.
3425 (syms_of_data): Use DEFSYM.
3426
e003a292
PE
34272011-05-31 Paul Eggert <eggert@cs.ucla.edu>
3428
3429 * ccl.c (CCL_CODE_RANGE): Allow negative numbers. (Bug#8751)
3430 (CCL_CODE_MIN): New macro.
3431
ed008a6d
PE
34322011-05-30 Paul Eggert <eggert@cs.ucla.edu>
3433
3687c2ef
PE
3434 * alloc.c (lisp_align_malloc): Omit unnecessary val==NULL tests.
3435
ed008a6d
PE
3436 * eval.c (Qdebug): Now static.
3437 * lisp.h (Qdebug): Remove decl. This reverts a part of the
3438 2011-04-26T11:26:05Z!dan.colascione@gmail.com that inadvertently undid part of
3439 2011-04-14T06:48:41Z!eggert@cs.ucla.edu.
3440
d66c4c7c
CY
34412011-05-29 Chong Yidong <cyd@stupidchicken.com>
3442
3443 * image.c: Various fixes to ImageMagick code comments.
3444 (Fimagemagick_types): Doc fix.
3445
5fbc2025
PE
34462011-05-29 Paul Eggert <eggert@cs.ucla.edu>
3447
0196f88a
PE
3448 Minor fixes prompted by GCC 4.6.0 warnings.
3449
3450 * xselect.c (converted_selections, conversion_fail_tag): Now static.
3451
5fbc2025
PE
3452 * emacs.c [HAVE_X_WINDOWS]: Include "xterm.h".
3453 (x_clipboard_manager_save_all): Move extern decl to ...
3454 * xterm.h: ... here, so that it can be checked for consistency.
3455
1dd3c2d9
CY
34562011-05-29 Chong Yidong <cyd@stupidchicken.com>
3457
3458 * xselect.c (x_clipboard_manager_save_frame)
3459 (x_clipboard_manager_save_all): New functions.
3460 (Fx_clipboard_manager_save): Lisp function deleted.
3461
3462 * emacs.c (Fkill_emacs): Call x_clipboard_manager_save_all.
3463 * frame.c (delete_frame): Call x_clipboard_manager_save_frame.
3464
3465 * xterm.h: Update prototype.
3466
5ba6571d
WX
34672011-05-28 William Xu <william.xwl@gmail.com>
3468
3469 * nsterm.m (ns_term_shutdown): Synchronize user defaults before
3470 exiting (Bug#8239).
3471
3eaff834
JM
34722011-05-28 Jim Meyering <meyering@redhat.com>
3473
e1900994 3474 Avoid a sign-extension bug in crypto_hash_function.
3eaff834
JM
3475 * fns.c (to_uchar): Define.
3476 (crypto_hash_function): Use it to convert some newly-signed
3477 variables to unsigned, to avoid sign-extension bugs. For example,
3478 without this change, (md5 "truc") would evaluate to
3479 45723a2aff78ff4fff7fff1114760e62 rather than the expected
3480 45723a2af3788c4ff17f8d1114760e62. Reported by Antoine Levitt in
e1900994 3481 https://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00883.html.
3eaff834 3482
0f6990a7
PE
34832011-05-27 Paul Eggert <eggert@cs.ucla.edu>
3484
3485 Integer overflow fixes.
c8a9ca5a 3486
08686060
PE
3487 * dbusbind.c: Serial number integer overflow fixes.
3488 (CHECK_DBUS_SERIAL_GET_SERIAL): New macro.
08686060
PE
3489 (Fdbus_call_method_asynchronously, xd_read_message_1): Use a float
3490 to hold a serial number that is too large for a fixnum.
3491 (Fdbus_method_return_internal, Fdbus_method_error_internal):
3492 Check for serial numbers out of range. Decode any serial number
59568bf0 3493 that was so large that it became a float. (Bug#8722)
08686060 3494
2d1fc3c7
PE
3495 * dbusbind.c: Use XFASTINT rather than XUINT, and check for nonneg.
3496 (Fdbus_call_method, Fdbus_call_method_asynchronously):
3497 Use XFASTINT rather than XUINT when numbers are nonnegative.
3498 (xd_append_arg, Fdbus_method_return_internal):
3499 (Fdbus_method_error_internal): Likewise. Also, for unsigned
3500 arguments, check that Lisp number is nonnegative, rather than
59568bf0 3501 silently wrapping negative numbers around. (Bug#8722)
30217ff0 3502 (xd_read_message_1): Don't assume dbus_uint32_t can fit in int.
59568bf0 3503 (Bug#8722)
2d1fc3c7 3504
c8a9ca5a
PE
3505 * data.c (arith_driver, Flsh): Avoid unnecessary casts to EMACS_UINT.
3506
519e1d69
PE
3507 * ccl.c (ccl_driver): Redo slightly to avoid the need for 'unsigned'.
3508
30569699
PE
3509 ccl: add integer overflow checks
3510 * ccl.c (CCL_CODE_MAX, GET_CCL_RANGE, GET_CCL_CODE, GET_CCL_INT):
3511 (IN_INT_RANGE): New macros.
3512 (ccl_driver): Use them to check for integer overflow when
3513 decoding a CCL program. Many of the new checks are whether XINT (x)
3514 fits in int; it doesn't always, on 64-bit hosts. The new version
3515 doesn't catch all possible integer overflows, but it's an
847044ea 3516 improvement. (Bug#8719)
30569699 3517
c11285dc
PE
3518 * alloc.c (make_event_array): Use XINT, not XUINT.
3519 There's no need for unsigned here.
3520
fdccd48e
PE
3521 * mem-limits.h (EXCEEDS_LISP_PTR) [!USE_LSB_TAG]: EMACS_UINT -> uintptr_t
3522 This follows up to the 2011-05-06 change that substituted uintptr_t
3523 for EMACS_INT. This case wasn't caught back then.
3524
37910ab2
PE
3525 Rework Fformat to avoid integer overflow issues.
3526 * editfns.c: Include <float.h> unconditionally, as it's everywhere
3527 now (part of C89). Include <verify.h>.
3528 (MAX_10_EXP, CONVERTED_BYTE_SIZE): Remove; no longer needed.
3529 (pWIDE, pWIDElen, signed_wide, unsigned_wide): New defns.
3530 (Fformat): Avoid the prepass trying to compute sizes; it was only
3531 approximate and thus did not catch overflow reliably. Instead, walk
3532 through the format just once, formatting and computing sizes as we go,
3533 checking for integer overflow at every step, and allocating a larger
3534 buffer as needed. Keep track separately whether the format is
3535 multibyte. Keep only the most-recently calculated precision, rather
3536 than them all. Record whether each argument has been converted to
3537 string. Use EMACS_INT, not int, for byte and char and arg counts.
3538 Support field widths and precisions larger than INT_MAX. Avoid
3539 sprintf's undefined behavior with conversion specifications such as %#d
3540 and %.0c. Fix bug with strchr succeeding on '\0' when looking for
3541 flags. Fix bug with (format "%c" 256.0). Avoid integer overflow when
3542 formatting out-of-range floating point numbers with int
9173deec 3543 formats. (Bug#8668)
37910ab2 3544
2e6578fb
PE
3545 * lisp.h (FIXNUM_OVERFLOW_P): Work even if arg is a NaN.
3546
0ae6bdee
PE
3547 * data.c: Avoid integer truncation in expressions involving floats.
3548 * data.c: Include <intprops.h>.
3549 (arith_driver): When there's an integer overflow in an expression
3550 involving floating point, convert the integers to floating point
3551 so that the resulting value does not suffer from catastrophic
3552 integer truncation. For example, on a 64-bit host (* 4
3553 most-negative-fixnum 0.5) should yield about -4.6e+18, not zero.
3554 Do not rely on undefined behavior after integer overflow.
3555
de883a70
PE
3556 merge count_size_as_multibyte, parse_str_to_multibyte
3557 * character.c, character.h (count_size_as_multibyte):
fd6fa53f 3558 Rename from parse_str_to_multibyte; all uses changed.
de883a70
PE
3559 Check for integer overflow.
3560 * insdel.c, lisp.h (count_size_as_multibyte): Remove,
3561 since it's now a duplicate of the other. This is more of
3562 a character than a buffer op, so better that it's in character.c.
3563 * fns.c, print.c: Adjust to above changes.
3564
2ff916cb
PE
35652011-05-27 Stefan Monnier <monnier@iro.umontreal.ca>
3566
3567 * xselect.c (x_convert_selection): Yet another int/Lisp_Object mixup.
3568
f1b54466
PE
35692011-05-27 Paul Eggert <eggert@cs.ucla.edu>
3570
fb1ac845
PE
3571 * xselect.c: Fix minor problems prompted by GCC 4.6.0 warnings.
3572 (x_handle_selection_request, frame_for_x_selection): Remove unused vars.
3573 (x_clipboard_manager_save): Now static.
3574 (Fx_clipboard_manager_save): Rename local to avoid shadowing.
3575
f1b54466
PE
3576 * fns.c: Fix minor problems prompted by GCC 4.6.0 warnings.
3577 (crypto_hash_function): Now static.
3578 Fix pointer signedness problems. Avoid unnecessary initializations.
3579
a9f737ee
CY
35802011-05-27 Chong Yidong <cyd@stupidchicken.com>
3581
3582 * termhooks.h (Vselection_alist): Make it terminal-local.
3583
3584 * terminal.c (create_terminal): Initialize it.
3585
3586 * xselect.c: Support for clipboard managers.
3587 (Vselection_alist): Move to termhooks.h as terminal-local var.
3588 (LOCAL_SELECTION): New macro.
3589 (x_atom_to_symbol): Handle x_display_info_for_display fail case.
3590 (symbol_to_x_atom): Remove gratuitous arg.
3591 (x_handle_selection_request, lisp_data_to_selection_data)
3592 (x_get_foreign_selection, Fx_register_dnd_atom): Callers changed.
620c53a6
SM
3593 (x_own_selection, x_get_local_selection, x_convert_selection):
3594 New arg, specifying work frame. Use terminal-local Vselection_alist.
a9f737ee
CY
3595 (some_frame_on_display): Delete unused function.
3596 (Fx_own_selection_internal, Fx_get_selection_internal)
3597 (Fx_disown_selection_internal, Fx_selection_owner_p)
3598 (Fx_selection_exists_p): New optional frame arg.
3599 (frame_for_x_selection, Fx_clipboard_manager_save): New functions.
3600 (x_handle_selection_clear): Don't treat other terminals with the
3601 same keyboard specially. Use the terminal-local Vselection_alist.
3602 (x_clear_frame_selections): Use Frun_hook_with_args.
3603
3604 * xterm.c (x_term_init): Intern ATOM and CLIPBOARD_MANAGER atoms.
3605
3606 * xterm.h: Add support for those atoms.
3607
e067f0c1
CY
36082011-05-26 Chong Yidong <cyd@stupidchicken.com>
3609
3610 * xselect.c: ICCCM-compliant handling of MULTIPLE targets.
3611 (converted_selections, conversion_fail_tag): New global variables.
3612 (x_selection_request_lisp_error): Free the above.
3613 (x_get_local_selection): Remove unnecessary code.
3614 (x_reply_selection_request): Args changed; handle arbitrary array
620c53a6
SM
3615 of converted selections stored in converted_selections.
3616 Separate the XChangeProperty and SelectionNotify steps.
e067f0c1
CY
3617 (x_handle_selection_request): Rewrite to handle MULTIPLE target.
3618 (x_convert_selection): New function.
3619 (x_handle_selection_event): Simplify.
3620 (x_get_foreign_selection): Don't ignore incoming requests while
3621 waiting for an answer; this will fail when we implement
3622 SAVE_TARGETS, and seems unnecessary anyway.
3623 (selection_data_to_lisp_data): Recognize ATOM_PAIR type.
3624 (Vx_sent_selection_functions): Doc fix.
3625
0f4aebc0
LL
36262011-05-26 Leo Liu <sdl.web@gmail.com>
3627
3628 * editfns.c (Ftranspose_regions): Allow empty regions. (Bug#8699)
3629
e61124cd
YM
36302011-05-25 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
3631
3632 * dispextern.h (struct glyph_row): New member fringe_bitmap_periodic_p.
3633
3634 * dispnew.c (shift_glyph_matrix, scrolling_window): Mark scrolled row
3635 for fringe update if it has periodic bitmap.
ac389d0c 3636 (row_equal_p): Also compare left_fringe_offset, right_fringe_offset,
e61124cd
YM
3637 and fringe_bitmap_periodic_p.
3638
3639 * fringe.c (get_fringe_bitmap_data): New function.
3640 (draw_fringe_bitmap_1, update_window_fringes): Use it.
3641 (update_window_fringes): Record periodicity of fringe bitmap in glyph
3642 row. Mark glyph row for fringe update if periodicity changed.
3643
3644 * xdisp.c (try_window_reusing_current_matrix): Don't mark scrolled row
3645 for fringe update unless it has periodic bitmap.
3646
f16d9837
KH
36472011-05-25 Kenichi Handa <handa@m17n.org>
3648
3649 * xdisp.c (get_next_display_element): Set correct it->face_id for
3650 a static composition.
3651
e1b90ef6
LL
36522011-05-24 Leo Liu <sdl.web@gmail.com>
3653
3654 * deps.mk (fns.o):
3655 * makefile.w32-in ($(BLD)/fns.$(O)): Include sha1.h.
3656
3657 * fns.c (crypto_hash_function, Fsha1): New function.
3658 (Fmd5): Use crypto_hash_function.
3659 (syms_of_fns): Add Ssha1.
3660
7400048f
PE
36612011-05-22 Paul Eggert <eggert@cs.ucla.edu>
3662
3663 * gnutls.c: Remove unused macros.
3664 (fn_gnutls_transport_set_lowat, fn_gnutls_transport_set_pull_function):
3665 (fn_gnutls_transport_set_push_function) [!WINDOWSNT]:
3666 Remove macros that are defined and never used.
3667 Caught by gcc -Wunused-macros (GCC 4.6.0, Fedora 14).
3668
abb71cf4
CY
36692011-05-22 Chong Yidong <cyd@stupidchicken.com>
3670
3671 * xselect.c (syms_of_xselect): Remove unused symbol SAVE_TARGETS.
3672 (Fx_get_selection_internal): Minor cleanup.
3673 (Fx_own_selection_internal): Rename arguments for consistency with
3674 select.el.
3675
6307db39
PE
36762011-05-22 Paul Eggert <eggert@cs.ucla.edu>
3677
3678 * xselect.c (QSAVE_TARGETS): New static var, to fix build failure.
3679
f3d4e0a4
CY
36802011-05-22 Chong Yidong <cyd@stupidchicken.com>
3681
3682 * xselect.c (syms_of_xselect): Include character.h; use DEFSYM.
3683
4d8ade89
YM
36842011-05-21 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
3685
3686 * dispnew.c (scrolling_window): Don't exclude the case that the
3687 last enabled row in the desired matrix touches the bottom boundary.
3688
32078c8d
GM
36892011-05-21 Glenn Morris <rgm@gnu.org>
3690
3691 * Makefile.in ($(etc)/DOC): Make second command line even shorter.
33cf345f
GM
3692 (SOME_MACHINE_OBJECTS): Replace FONT_OBJ by its maximal expansion,
3693 and add some more files.
32078c8d 3694
7285dc67
EZ
36952011-05-20 Eli Zaretskii <eliz@gnu.org>
3696
3697 * callproc.c (Fcall_process) [MSDOS]: Fix arguments to
3698 report_file_error introduced by the change from 2011-05-07.
3699
89d1bd22
PE
37002011-05-20 Paul Eggert <eggert@cs.ucla.edu>
3701
3702 * systime.h (Time): Define only if emacs is defined.
3703 This is to allow ../lib-src/profile.c to be compiled on FreeBSD,
3704 where the include path doesn't have X11/X.h by default. See
3705 <http://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00561.html>.
3706
e23640bb 37072011-05-20 Kenichi Handa <handa@m17n.org>
31bfc35c
KH
3708
3709 * composite.c (find_automatic_composition): Fix previous change.
3710
b9704ad9
GM
37112011-05-20 Glenn Morris <rgm@gnu.org>
3712
3713 * lisp.mk: New file, split from Makefile.in.
3714 * Makefile.in (lisp): Move to separate file, inserted by @lisp_frag@.
3715 (shortlisp): Remove.
3716 ($(etc)/DOC): Edit lisp.mk rather than using $shortlisp.
3717
4a720484
GM
37182011-05-19 Glenn Morris <rgm@gnu.org>
3719
3720 * Makefile.in (MSDOS_SUPPORT_REAL, MSDOS_SUPPORT, NS_SUPPORT)
3721 (REAL_MOUSE_SUPPORT, GPM_MOUSE_SUPPORT, MOUSE_SUPPORT, TOOLTIP_SUPPORT)
3722 (BASE_WINDOW_SUPPORT, X_WINDOW_SUPPORT, WINDOW_SUPPORT): Remove.
3723 (lisp): Set the order to that of loadup.el.
3724 (shortlisp): Make it a copy of $lisp.
3725 (SOME_MACHINE_LISP): Remove.
3726 ($(etc)/DOC): Depend just on $lisp, not $SOME_MACHINE_LISP too.
3727 Use just $shortlisp, not $SOME_MACHINE_LISP too.
3728
a28d4396
KH
37292011-05-18 Kenichi Handa <handa@m17n.org>
3730
3731 * composite.c (CHAR_COMPOSABLE_P): Add more check for efficiency.
3732 (BACKWARD_CHAR): Wrap the arg STOP by parenthesis.
3733 (find_automatic_composition): Mostly rewrite for efficiency.
3734
a2b1fa8e
JB
37352011-05-18 Juanma Barranquero <lekktu@gmail.com>
3736
3737 * makefile.w32-in: Update dependencies.
3738
8e1f5610
CS
37392011-05-18 Christoph Scholtes <cschol2112@googlemail.com>
3740
3741 * menu.c: Include limits.h (fixes the MS-Windows build broken by
7d7d0045 3742 2011-06-18T18:49:19Z!cyd@stupidchicken.com).
8e1f5610 3743
7025ee00 37442011-05-18 Paul Eggert <eggert@cs.ucla.edu>
cb93f9be 3745
cdfa6eab
PE
3746 Fix some integer overflow issues, such as string length overflow.
3747
06d6db33
PE
3748 * insdel.c (count_size_as_multibyte): Check for string overflow.
3749
2b4560a8
PE
3750 * character.c (lisp_string_width): Check for string overflow.
3751 Use EMACS_INT, not int, for string indexes and lengths; in
3752 particular, 2nd arg is now EMACS_INT, not int. Do not crash if
3753 the resulting string length overflows an EMACS_INT; instead,
3754 report a string overflow if no precision given. When checking for
3755 precision exhaustion, use a check that cannot possibly have
3756 integer overflow. (Bug#8675)
3757 * character.h (lisp_string_width): Adjust to new signature.
3758
cb93f9be
PE
3759 * alloc.c (string_overflow): New function.
3760 (Fmake_string): Use it. This doesn't change behavior, but saves
3761 a few bytes and will simplify future changes.
3762 * character.c (string_escape_byte8): Likewise.
3763 * lisp.h (string_overflow): New decl.
3764
1a1f3366
PE
3765 Fixups, following up to the user-interface timestamp change.
3766 * nsterm.m (last_mouse_movement_time, ns_mouse_position): Use Time
3767 for UI timestamps, instead of unsigned long.
9fbd6841
PE
3768 * msdos.c (mouse_get_pos): Likewise.
3769 * w32inevt.c (movement_time, w32_console_mouse_position): Likewise.
1a1f3366
PE
3770 * w32gui.h (Time): Define by including "systime.h" rather than by
3771 declaring it ourselves. (Bug#8664)
3772
d4e3e4d3
PE
3773 * dispextern.h (struct image): Don't assume time_t <= unsigned long.
3774 * image.c (clear_image_cache): Likewise.
3775
f6a24d19
PE
3776 * term.c (term_mouse_position): Don't assume time_t wraparound.
3777
08dc5ae6
PE
3778 Be more systematic about user-interface timestamps.
3779 Before, the code sometimes used 'Time', sometimes 'unsigned long',
620c53a6
SM
3780 and sometimes 'EMACS_UINT', to represent these timestamps.
3781 This change causes it to use 'Time' uniformly, as that's what X uses.
08dc5ae6
PE
3782 This makes the code easier to follow, and makes it easier to catch
3783 integer overflow bugs such as Bug#8664.
3784 * frame.c (Fmouse_position, Fmouse_pixel_position):
3785 Use Time, not unsigned long, for user-interface timestamps.
3786 * keyboard.c (last_event_timestamp, kbd_buffer_get_event): Likewise.
3787 (button_down_time, make_lispy_position, make_lispy_movement): Likewise.
3788 * keyboard.h (last_event_timestamp): Likewise.
3789 * menu.c (Fx_popup_menu) [!HAVE_X_WINDOWS]: Likewise.
3790 * menu.h (xmenu_show): Likewise.
3791 * term.c (term_mouse_position): Likewise.
3792 * termhooks.h (struct input_event.timestamp): Likewise.
3793 (struct terminal.mouse_position_hook): Likewise.
3794 * xmenu.c (create_and_show_popup_menu, xmenu_show): Likewise.
3795 * xterm.c (XTmouse_position, x_scroll_bar_report_motion): Likewise.
3796 * systime.h (Time): New decl. Pull it in from <X11/X.h> if
3797 HAVE_X_WINDOWS, otherwise define it as unsigned long, which is
3798 what it was before.
3799 * menu.h, termhooks.h: Include "systime.h", for Time.
3800
8e55734a
PE
3801 * keyboard.c (make_lispy_event): Fix problem in integer overflow.
3802 Don't assume that the difference between two unsigned long values
3803 can fit into an integer. At this point, we know button_down_time
3804 <= event->timestamp, so the difference must be nonnegative, so
3805 there's no need to cast the result if double-click-time is
3806 nonnegative, as it should be; check that it's nonnegative, just in
3807 case. This bug is triggered when events are more than 2**31 ms
86db42d2 3808 apart (about 25 days). (Bug#8664)
8e55734a 3809
841f1b75 3810 * xselect.c (last_event_timestamp): Remove duplicate decl.
6434756c 3811 (x_own_selection): Remove needless cast to unsigned long.
841f1b75 3812
3e26f69c
PE
3813 * xmenu.c (set_frame_menubar): Use int, not EMACS_UINT, for indexes
3814 that always fit in int. Use a sentinel instead of a counter, to
3815 avoid a temp and to allay GCC's concerns about possible int overflow.
d230cb74
PE
3816 * frame.h (struct frame): Use int for menu_bar_items_used
3817 instead of EMACS_INT, since it always fits in int.
3e26f69c 3818
5cc152c0
PE
3819 * menu.c (grow_menu_items): Check for int overflow.
3820
d89eb65e
PE
3821 * xmenu.c (set_frame_menubar): Don't mishandle vectors with no nils.
3822
5235bd3e
PE
3823 * xterm.c: Use EMACS_INT for Emacs modifiers, and int for X modifiers.
3824 Before, the code was not consistent. These values cannot exceed
3825 2**31 - 1 so there's no need to make them unsigned.
3826 (x_x_to_emacs_modifiers): Accept int and return EMACS_INT.
3827 (x_emacs_to_x_modifiers): Accept EMACS_INT and return int.
3828 (x_x_to_emacs_modifiers, x_emacs_to_x_modifiers): Reject non-integers
3829 as modifiers.
3830 * xterm.h (x_x_to_emacs_modifiers): Adjust to signature change.
3831
bc827e23
PE
3832 * lisp.h (XINT) [USE_LISP_UNION_TYPE]: Cast to EMACS_INT.
3833 (XUINT) [USE_LISP_UNION_TYPE]: Cast to EMACS_UINT.
3834 Otherwise, GCC 4.6.0 warns about printf (pI, XINT (...)),
3835 presumably because the widths might not match.
3836
78eb494e
PE
3837 * window.c (size_window): Avoid needless test at loop start.
3838
04f2d78b
CB
38392011-05-18 Courtney Bane <emacs-bugs-7626@cbane.org> (tiny change)
3840
3841 * term.c (Fresume_tty): Restore hooks before reinitializing (bug#8687).
3842
d2fc7e3d 38432011-05-12 Drew Adams <drew.adams@oracle.com>
e531bdff
DA
3844
3845 * textprop.c (Fprevious_single_char_property_change): Doc fix (bug#8655).
3846
d2fc7e3d 38472011-05-12 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
7db47798
YM
3848
3849 * w32term.c (w32_draw_fringe_bitmap): Rename local vars `left' and
3850 `width' to `bar_area_x' and `bar_area_width', respectively.
3851 (x_scroll_run): Take account of fringe background extension.
3852
04f2d78b
CB
3853 * xterm.c (x_draw_fringe_bitmap) [USE_TOOLKIT_SCROLL_BARS]:
3854 Rename local vars `left' and `width' to `bar_area_x' and
7db47798
YM
3855 `bar_area_width', respectively.
3856 (x_scroll_run) [USE_TOOLKIT_SCROLL_BARS]: Take account of fringe
3857 background extension.
3858
79b70037
GM
38592011-05-10 Jim Meyering <meyering@redhat.com>
3860
3861 * xdisp.c (x_intersect_rectangles): Fix typo "the the -> the".
3862
2f142cc5
JB
38632011-05-10 Juanma Barranquero <lekktu@gmail.com>
3864
3865 * image.c (Finit_image_library): Return t for built-in image types,
3866 like pbm and xbm. (Bug#8640)
3867
57679c86
AS
38682011-05-09 Andreas Schwab <schwab@linux-m68k.org>
3869
3870 * w32menu.c (set_frame_menubar): Fix submenu allocation.
3871
888c9e86
EZ
38722011-05-07 Eli Zaretskii <eliz@gnu.org>
3873
b0512a1d
EZ
3874 * w32console.c (Fset_screen_color): Doc fix.
3875 (Fget_screen_color): New function.
3876 (syms_of_ntterm): Defsubr it.
3877
7285dc67
EZ
3878 * callproc.c (call_process_cleanup) [MSDOS]: Don't close and
3879 unlink the temporary file if Fcall_process didn't create it in the
3880 first place.
3881 (Fcall_process) [MSDOS]: Don't create tempfile if stdout of the
3882 child process will be redirected to a file specified with `:file'.
888c9e86
EZ
3883 Don't try to re-open tempfile in that case, and set fd[0] to -1 as
3884 cue to call_process_cleanup not to close that handle.
3885
4d3fcc8e
BK
38862011-05-07 Ben Key <bkey76@gmail.com>
3887
3888 * makefile.w32-in: The bootstrap-temacs rule now makes use of
3889 one of two shell specific rules, either bootstrap-temacs-CMD or
3890 bootstrap-temacs-SH. The bootstrap-temacs-SH rule is identical
3891 to the previous implementation of the bootstrap-temacs rule.
3892 The bootstrap-temacs-CMD rule is similar to the previous
3893 implementation of the bootstrap-temacs rule except that it
3894 makes use of the ESC_CFLAGS variable instead of the CFLAGS
3895 variable.
3896
3897 These changes, along with some changes to nt/configure.bat,
3898 nt/gmake.defs, and nt/nmake.defs, are required to extend my
3899 earlier fix to add support for --cflags and --ldflags options
3900 that include quotes so that it works whether make uses cmd or
3901 sh as the shell.
3902
b4289b64
MA
39032011-05-06 Michael Albinus <michael.albinus@gmx.de>
3904
3905 * dbusbind.c (QCdbus_type_unix_fd): Declare static.
3906 (xd_remove_watch): Don't check QCdbus_type_unix_fd for SYMBOLP, it
3907 is a constant.
3908 (Fdbus_init_bus, xd_read_queued_messages): Bus can be a symbol or
3909 a string. Handle both cases.
3910 (Fdbus_call_method_asynchronously, Fdbus_register_signal)
3911 (Fdbus_register_method): Use Qinvalid_function.
3912
af4c0e28
JB
39132011-05-06 Juanma Barranquero <lekktu@gmail.com>
3914
3915 * makefile.w32-in: Update dependencies.
3916 (LISP_H): Add inttypes.h and stdin.h.
3917 (PROCESS_H): Add unistd.h.
3918
c51453d9
EZ
39192011-05-06 Eli Zaretskii <eliz@gnu.org>
3920
3921 * lread.c: Include limits.h (fixes the MS-Windows build broken by
3922 2011-05-06T07:13:19Z!eggert@cs.ucla.edu).
3923
8ff0ac3c 39242011-05-06 Paul Eggert <eggert@cs.ucla.edu>
c032b5f8 3925
4c4b566b
PE
3926 * image.c (Finit_image_library) [!HAVE_NTGUI]: Omit unused local.
3927
aab2b9b5
PE
3928 * term.c (vfatal): Remove stray call to va_end.
3929 It's not needed and the C Standard doesn't allow it here anyway.
3930
c378da0b
PE
3931 Use C99's va_copy to avoid undefined behavior on x86-64 GNU/Linux.
3932 * eval.c (verror): doprnt a copy of ap, not the original. (Bug#8545)
3933
288b08c7
PE
3934 * eval.c (verror): OK to create a string of up to MOST_POSITIVE_FIXNUM
3935 bytes.
3936
e3601888
PE
3937 * term.c: Don't include <stdarg.h>, as <lisp.h> does that.
3938
db6c0e74
PE
3939 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork clobbering.
3940
dd5963ea
PE
3941 * process.c (Fformat_network_address): Fix typo: args2 -> *args2.
3942
88c9450f
PE
3943 * xmenu.c (set_frame_menubar): Fix typo: int * -> int (3 times).
3944
2f9442b8
PE
3945 * coding.c (detect_coding_charset): Fix typo: * 2 -> *4 (Bug#8601).
3946
c032b5f8
PE
3947 * charset.h (struct charset.code_space): Now has 15 elements, not 16.
3948 * charset.c (Fdefine_charset_internal): Don't initialize
3949 charset.code_space[15]. The value was garbage, on hosts with
2d38271b 3950 32-bit int (Bug#8600).
a108c10b
PE
3951
3952 * lread.c (read_integer): Be more consistent with string-to-number.
3953 Use string_to_number to do the actual conversion; this avoids
3954 rounding errors and fixes some other screwups. Without this fix,
3955 for example, #x1fffffffffffffff was misread as -2305843009213693952.
3956 (digit_to_number): Move earlier, for benefit of read_integer.
3957 Return -1 if the digit is out of range for the base, -2 if it is
48e400f0 3958 not a digit in any supported base. (Bug#8602)
a108c10b 3959
ad5f9eea
PE
3960 * doprnt.c (doprnt): Support arbitrary pI values, such as "I64".
3961
aec1708a
PE
3962 * dispnew.c (scrolling_window): Return 1 if we scrolled,
3963 to match comment at start of function. This also removes a
3964 GCC warning about overflow in a 32+64-bit port.
3965
47be4ab5
PE
3966 * lisp.h (EMACS_INT, EMACS_UINT, BITS_PER_EMACS_INT, pI): Simplify.
3967
371cac43
PE
3968 * dbusbind.c: Do not use XPNTR on a value that may be an integer.
3969 Reported by Stefan Monnier in
3970 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00919.html>.
04f2d78b
CB
3971 (xd_remove_watch, Fdbus_init_bus, xd_read_queued_messages):
3972 Use SYMBOLP-guarded XSYMBOL, not XPNTR.
371cac43 3973
d01a7826
PE
3974 * lisp.h (EMACS_INTPTR): Remove. All uses changed to intptr_t.
3975 (EMACS_UINTPTR): Likewise, with uintptr_t.
3976
7fd47d5c
PE
3977 * lisp.h: Prefer 64-bit EMACS_INT if available.
3978 (EMACS_INT, EMACS_UINT, BITS_PER_EMACS_INT, pI): Define to 64-bit
3979 on 32-bit hosts that have 64-bit int, so that they can access
3980 large files.
122b0c86
PE
3981 However, temporarily disable this change unless the temporary
3982 symbol WIDE_EMACS_INT is defined.
7fd47d5c 3983
8727937b
PE
3984 * lread.c, process.c: Do not include <inttypes.h>; lisp.h does it now.
3985
8ac068ac
PE
3986 Prefer intptr_t/uintptr_t for integers the same widths as pointers.
3987 This removes an assumption that EMACS_INT and long are the same
3988 width as pointers. The assumption is true for Emacs porting targets
3989 now, but we want to make other targets possible.
3990 * lisp.h: Include <inttypes.h>, for INTPTR_MAX, UINTPTR_MAX.
3991 (EMACS_INTPTR, EMACS_UINTPTR): New macros.
3992 In the rest of the code, change types of integers that hold casted
3993 pointers to EMACS_INTPTR and EMACS_UINTPTR, systematically
3994 replacing EMACS_INT, long, EMACS_UINT, and unsigned long.
3995 (XTYPE): Don't cast arg to EMACS_UINT; normally is not needed.
3996 (XSET): Cast type of XTYPE arg to EMACS_INTPTR; it is needed here.
3997 No need to cast type when ORing.
3998 (XPNTR): Return a value of type EMACS_INTPTR or EMACS_UINTPTR.
3999 * alloc.c (lisp_align_malloc): Remove a no-longer-needed cast.
4000 * doc.c (store_function_docstring): Use EMACS_INTPTR, so as not to
4001 assume EMACS_INT is the same width as char *.
4002 * gtkutil.c (xg_gtk_scroll_destroy, xg_tool_bar_button_cb):
4003 (xg_tool_bar_callback, xg_tool_bar_help_callback, xg_make_tool_item):
4004 Remove no-longer-needed casts.
4005 (xg_create_scroll_bar, xg_tool_bar_button_cb, xg_tool_bar_callback):
4006 (xg_tool_bar_help_callback, xg_make_tool_item):
4007 Use EMACS_INTPTR to hold an integer
4008 that will be cast to void *; this can avoid a GCC warning
4009 if EMACS_INT is not the same width as void *.
4010 * menu.c (find_and_call_menu_selection): Remove no-longer-needed cast.
4011 * xdisp.c (display_echo_area_1, resize_mini_window_1):
4012 (current_message_1, set_message_1):
4013 Use a local to convert to proper width without a cast.
4014 * xmenu.c (dialog_selection_callback): Likewise.
4015
ede49d71
PE
4016 * sysdep.c (get_random): Don't assume EMACS_INT is no wider than long.
4017 Also, don't assume VALBITS / RAND_BITS is less than 5,
4018 and don't rely on undefined behavior when shifting a 1 left into
4019 the sign bit.
4020 * lisp.h (get_random): Change signature to match.
4021
2f30ecd0
PE
4022 * lread.c (hash_string): Use size_t, not int, for hash computation.
4023 Normally we prefer signed values; but hashing is special, because
4024 it's better to use unsigned division on hash table sizes so that
4025 the remainder is nonnegative. Also, size_t is the natural width
4026 for hashing into memory. The previous code used 'int', which doesn't
4027 retain enough info to hash well into very large tables.
4028 (oblookup, oblookup_last_bucket_number, Funintern): Likewise.
4029
2a866e7b
PE
4030 * dbusbind.c: Don't possibly lose pointer info when converting.
4031 (xd_remove_watch, Fdbus_init_bus, xd_read_queued_messages):
4032 Use XPNTR rather than XHASH, so that the high-order bits of
4033 the pointer aren't lost when converting through void *.
4034
51639eac
PE
4035 * eval.c (Fautoload): Don't double-shift a pointer.
4036
92394119
PE
4037 * fns.c (Frandom): Let EMACS_UINT be wider than unsigned long.
4038
dbdb9a7c
JB
40392011-05-06 Juanma Barranquero <lekktu@gmail.com>
4040
4041 * gnutls.c (DEF_GNUTLS_FN):
4042 * image.c (DEF_IMGLIB_FN): Make function pointers static.
4043
db7a0b4f
AS
40442011-05-05 Andreas Schwab <schwab@linux-m68k.org>
4045
4046 * lread.c (lisp_file_lexically_bound_p): Stop scanning at end
4047 marker. (Bug#8610)
4048
f7ff1b0f 40492011-05-05 Eli Zaretskii <eliz@gnu.org>
fab624aa
EZ
4050
4051 * w32heap.c (allocate_heap) [USE_LISP_UNION_TYPE || USE_LSB_TAG]:
4052 New version that can reserve upto 2GB of heap space.
4053
f7ff1b0f 40542011-05-05 Chong Yidong <cyd@stupidchicken.com>
45cb8994
CY
4055
4056 * nsfns.m (Fns_read_file_name): Doc fix (Bug#8534).
4057
639c109b
TZ
40582011-05-05 Teodor Zlatanov <tzz@lifelogs.com>
4059
4060 * gnutls.c (fn_gnutls_certificate_set_x509_key_file): Add alias to
4061 `gnutls_certificate_set_x509_key_file'.
4062
d2127135
JB
40632011-05-05 Juanma Barranquero <lekktu@gmail.com>
4064
4065 * makefile.w32-in ($(BLD)/image.$(O), $(BLD)/process.$(O)):
4066 Update dependencies.
4067
e968f4f3
JB
40682011-05-04 Juanma Barranquero <lekktu@gmail.com>
4069
4070 * gnutls.h (emacs_gnutls_write, emacs_gnutls_read):
4071 * gnutls.c (emacs_gnutls_write, emacs_gnutls_read):
4072 Remove unused parameter `fildes'.
4073 * process.c (read_process_output, send_process): Don't pass it.
4074
84d358f0
JB
40752011-05-04 Juanma Barranquero <lekktu@gmail.com>
4076
4077 Fix previous change: the library cache is defined in w32.c.
4078 * image.c (CACHE_IMAGE_TYPE) [!HAVE_NTGUI]: Define to noop.
4079 (Finit_image_library): Wrap Vlibrary_cache on "#ifdef HAVE_NTGUI".
4080
0898ca10
JB
40812011-05-04 Juanma Barranquero <lekktu@gmail.com>
4082
4083 Implement dynamic loading of GnuTLS on Windows.
4084
4085 * gnutls.h (GNUTLS_EMACS_ERROR_NOT_LOADED): New macro.
4086 (emacs_gnutls_write, emacs_gnutls_read): Mark as extern.
4087 (emacs_gnutls_record_check_pending, emacs_gnutls_transport_set_errno):
4088 Declare.
4089
4090 * gnutls.c (Qgnutls_dll): Define.
4091 (DEF_GNUTLS_FN, LOAD_GNUTLS_FN): New macros.
4092 (gnutls_*): Declare function pointers.
4093 (init_gnutls_functions): New function to initialize function pointers.
4094 (emacs_gnutls_handshake, Fgnutls_error_string, Fgnutls_deinit)
4095 (emacs_gnutls_global_init, Fgnutls_bye): Use function pointers.
4096 (emacs_gnutls_record_check_pending, emacs_gnutls_transport_set_errno):
4097 Wrappers for gnutls_record_check_pending and gnutls_transport_set_errno.
4098 (emacs_gnutls_write, emacs_gnutls_read)
4099 (emacs_gnutls_handle_error, Fgnutls_error_fatalp)
4100 (Fgnutls_available_p): New function.
4101 (Fgnutls_boot): Call Fgnutls_available_p. Use function pointers.
4102 (syms_of_gnutls) <Qgnutls_dll>: Initialize and staticpro it.
4103 (syms_of_gnutls) <Sgnutls_available_p>: defsubr it.
4104
4105 * image.c: Include w32.h.
4106 (Vimage_type_cache): Delete.
4107 (syms_of_image) <Vimage_type_cache>: Don't initialize and staticpro it.
4108 (CACHE_IMAGE_TYPE, Finit_image_library): Use Vlibrary_cache instead.
4109 (w32_delayed_load): Move to w32.c.
4110
4111 * w32.h (VlibraryCache, QCloaded_from, w32_delayed_load): Declare.
4112
4113 * w32.c (QCloaded_from, Vlibrary_cache): Define.
4114 (w32_delayed_load): Move from image.c. When loading a library, record
4115 its filename in the :loaded-from property of the library id.
4116 (globals_of_w32) <QCloaded_from, Vlibrary_cache>:
4117 Initialize and staticpro them.
4118 (emacs_gnutls_pull, emacs_gnutls_push): Call emacs_gnutls_* functions.
4119
4120 * process.c: Include lisp.h before w32.h, not after.
4121 (wait_reading_process_output): Call emacs_gnutls_record_check_pending
4122 instead of gnutls_record_check_pending.
4123
4124 * callproc.c, emacs.c: Include lisp.h before w32.h, not after.
4125
ff4de4aa
TZ
41262011-05-04 Teodor Zlatanov <tzz@lifelogs.com>
4127
4128 * gnutls.c (Fgnutls_boot): Support :keylist and :crlfiles options
4129 instead of :keyfiles. Give GnuTLS the keylist and the CRL lists
4130 as passed in.
4131
abe95abb
JD
41322011-05-03 Jan Djärv <jan.h.d@swipnet.se>
4133
4134 * xterm.c (x_set_frame_alpha): Do not set property on anything
4135 else than FRAME_X_OUTER_WINDOW (Bug#8608).
4136
e16e55d4
JB
41372011-05-02 Juanma Barranquero <lekktu@gmail.com>
4138
4139 * sysdep.c (get_tty_size) [WINDOWSNT]: Implement. (Bug#8596)
4140
bafcf6a5
JB
41412011-05-02 Juanma Barranquero <lekktu@gmail.com>
4142
4143 * gnutls.c (Qgnutls_log_level, Qgnutls_code, Qgnutls_anon)
4144 (Qgnutls_x509pki, Qgnutls_e_interrupted, Qgnutls_e_again)
4145 (Qgnutls_e_invalid_session, Qgnutls_e_not_ready_for_handshake)
4146 (gnutls_global_initialized, Qgnutls_bootprop_priority)
4147 (Qgnutls_bootprop_trustfiles, Qgnutls_bootprop_keyfiles)
4148 (Qgnutls_bootprop_callbacks, Qgnutls_bootprop_loglevel)
4149 (Qgnutls_bootprop_hostname, Qgnutls_bootprop_verify_flags)
4150 (Qgnutls_bootprop_verify_error, Qgnutls_bootprop_verify_hostname_error)
4151 (Qgnutls_bootprop_callbacks_verify): Make static.
4152
e7a6747f
AS
41532011-05-01 Andreas Schwab <schwab@linux-m68k.org>
4154
19ed11ba
AS
4155 * callproc.c: Indentation fixup.
4156
e7a6747f 4157 * sysdep.c (wait_for_termination_1): Make static.
04f2d78b
CB
4158 (wait_for_termination, interruptible_wait_for_termination):
4159 Move after wait_for_termination_1.
e7a6747f 4160
1ef14cb4
LMI
41612011-05-01 Lars Magne Ingebrigtsen <larsi@gnus.org>
4162
4163 * sysdep.c (interruptible_wait_for_termination): New function
4164 which is like wait_for_termination, but allows keyboard
4165 interruptions.
4166
4167 * callproc.c (Fcall_process): Add (:file "file") as an option for
4168 the STDOUT buffer.
4169 (Fcall_process_region): Ditto.
4170
330d880c
EZ
41712011-04-30 Eli Zaretskii <eliz@gnu.org>
4172
8db90b73
EZ
4173 * dosfns.c (Fint86, Fdos_memget, Fdos_memput): Use `ASIZE (FOO)'
4174 rather than `XVECTOR (FOO)->size'.
4175
330d880c
EZ
4176 * process.c: Remove HAVE_INTTYPES_H condition from inclusion of
4177 inttypes.h, as a gnulib replacement is used if it not available in
4178 system headers.
4179
15cbd324
EZ
41802011-04-21 Eli Zaretskii <eliz@gnu.org>
4181
4182 Lift the MOST_POSITIVE_FIXNUM/4 limitation on visited files.
4183 * fileio.c (Finsert_file_contents): Don't limit file size to 1/4
4184 of MOST_POSITIVE_FIXNUM. (Bug#8528)
4185
4186 * coding.c (coding_alloc_by_realloc): Error out if destination
4187 will grow beyond MOST_POSITIVE_FIXNUM.
4188 (decode_coding_emacs_mule): Abort if there isn't enough place in
4189 charbuf for the composition carryover bytes. Reserve an extra
4190 space for up to 2 characters produced in a loop.
4191 (decode_coding_iso_2022): Abort if there isn't enough place in
4192 charbuf for the composition carryover bytes.
4193
41942011-04-21 Eli Zaretskii <eliz@gnu.org>
afda1437 4195
ae940cca
EZ
4196 * doprnt.c (doprnt) [!HAVE_LONG_LONG_INT]: Error out instead of
4197 aborting when %lld or %lll format is passed.
4198 [!HAVE_UNSIGNED_LONG_LONG_INT]: Error out instead of aborting when
4199 %llo or %llx format is passed. (Bug#8545)
4200
03ab8921
EZ
4201 * window.c (window_scroll_line_based): Use a marker instead of
4202 simple variables to record original value of point. (Bug#7952)
4203
afda1437
EZ
4204 * doprnt.c (doprnt): Fix the case where a multibyte sequence
4205 produced by %s or %c overflows available buffer space. (Bug#8545)
4206
f76dee0c
PE
42072011-04-28 Paul Eggert <eggert@cs.ucla.edu>
4208
4209 * doprnt.c (doprnt): Omit useless test; int overflow check (Bug#8545).
283cdbef 4210 (SIZE_MAX): Move defn after all includes, as they might #define it.
f76dee0c 4211
fdc5744d
JB
42122011-04-28 Juanma Barranquero <lekktu@gmail.com>
4213
4214 * w32.c (init_environment): Warn about defaulting HOME to C:\.
4215
638f053a
JB
42162011-04-28 Juanma Barranquero <lekktu@gmail.com>
4217
4218 * keyboard.c (Qdelayed_warnings_hook): Define.
4219 (command_loop_1): Run `delayed-warnings-hook'
4220 if Vdelayed_warnings_list is non-nil.
4221 (syms_of_keyboard) <delayed-warnings-hook>: DEFSYM it.
4222 (syms_of_keyboard) <delayed-warnings-list>: DEFVAR_LISP it.
4223
d178f871
EZ
42242011-04-28 Eli Zaretskii <eliz@gnu.org>
4225
4226 * doprnt.c (doprnt): Don't return value smaller than the buffer
4227 size if the message was truncated. (Bug#8545).
4228
b124fd93
JB
42292011-04-28 Juanma Barranquero <lekktu@gmail.com>
4230
4231 * w32fns.c (Fx_change_window_property, Fx_delete_window_property)
4232 (Fx_window_property): #if-0 the whole functions, not just the bodies.
4233
e810457d
PE
42342011-04-27 Paul Eggert <eggert@cs.ucla.edu>
4235
4236 * doprnt.c (doprnt): Support "ll" length modifier, for long long.
4237
ea51cceb
JB
42382011-04-27 Juanma Barranquero <lekktu@gmail.com>
4239
4240 * makefile.w32-in: Update dependencies.
4241
94dcfacf
EZ
42422011-04-27 Eli Zaretskii <eliz@gnu.org>
4243
4244 Improve `doprnt' and its usage. (Bug#8545)
4245 * doprnt.c (doprnt): Make sure `format' is never accessed beyond
4246 `format_end'. Remove support for %l as a conversion specifier.
4247 Don't use xrealloc. Improve diagnostics when the %l size modifier
4248 is used. Update the commentary.
4249
4250 * eval.c (verror): Simplify calculation of size_t.
4251
4252 * coding.c (Ffind_operation_coding_system): Fix diagnostic error
4253 messages.
4254
f61f41d7
PE
42552011-04-27 Yoshiaki Kasahara <kasahara@nc.kyushu-u.ac.jp> (tiny change)
4256
4257 * buffer.c (init_buffer) [USE_MMAP_FOR_BUFFERS]: Adjust to aliasing
4258 change.
4259
96fb4434
PE
42602011-04-27 Paul Eggert <eggert@cs.ucla.edu>
4261
4262 * nsmenu.m: Replace all uses of XVECTOR with ASIZE and AREF.
4263 This makes this file independent of the recent pseudovector change.
4264
671875da 42652011-04-26 Paul Eggert <eggert@cs.ucla.edu>
eab3844f 4266
69e9b5a3
PE
4267 * keyboard.c (handle_user_signal): Fix pointer signedness problem.
4268
b5f869a7 4269 * gnutls.c (emacs_gnutls_handle_error): Remove unused local.
7754e151 4270 (Fgnutls_boot): gnutls_certificate_verify_peers2 wants unsigned *.
8d4c3955 4271 Remove unused local.
c8926152 4272 (emacs_gnutls_write): Don't use uninitialized rtnval if nbyte <= 0.
080e5a8d 4273
841a1577 4274 * lisp.h: Fix a problem with aliasing and vector headers. (Bug#8546)
04f2d78b
CB
4275 GCC 4.6.0 optimizes based on type-based alias analysis.
4276 For example, if b is of type struct buffer * and v of type struct
eab3844f
PE
4277 Lisp_Vector *, then gcc -O2 was incorrectly assuming that &b->size
4278 != &v->size, and therefore "v->size = 1; b->size = 2; return
4279 v->size;" must therefore return 1. This assumption is incorrect
4280 for Emacs, since it type-puns struct Lisp_Vector * with many other
4281 types. To fix this problem, this patch adds a new type struct
f904488f 4282 vectorlike_header that documents the constraints on layout of vectors
eab3844f
PE
4283 and pseudovectors, and helps optimizing compilers not get fooled
4284 by Emacs's type punning. It also adds the macros XSETTYPED_PVECTYPE
4285 XSETTYPED_PSEUDOVECTOR, TYPED_PSEUDOVECTORP, for similar reasons.
f904488f
PE
4286 * lisp.h (XSETTYPED_PVECTYPE): New macro, specifying the name of
4287 the size member.
eab3844f
PE
4288 (XSETPVECTYPE): Rewrite in terms of new macro.
4289 (XSETPVECTYPESIZE): New macro, specifying both type and size.
4290 This is a bit clearer, and further avoids the possibility of
4291 undesirable aliasing.
4292 (XSETTYPED_PSEUDOVECTOR): New macro, specifying the size.
f904488f 4293 (XSETPSEUDOVECTOR): Rewrite in terms of XSETTYPED_PSEUDOVECTOR.
eab3844f
PE
4294 (XSETSUBR): Rewrite in terms of XSETTYPED_PSEUDOVECTOR and XSIZE,
4295 since Lisp_Subr is a special case (no "next" field).
04f2d78b
CB
4296 (ASIZE): Now uses header.size rather than size.
4297 All previous uses of XVECTOR (foo)->size replaced to use this macro,
f904488f
PE
4298 to avoid the hassle of writing XVECTOR (foo)->header.size.
4299 (struct vectorlike_header): New type.
eab3844f
PE
4300 (TYPED_PSEUDOVECTORP): New macro, also specifying the C type of the
4301 object, to help avoid aliasing.
4302 (PSEUDOVECTORP): Rewrite in terms of TYPED_PSEUDOVECTORP.
4303 (SUBRP): Likewise, since Lisp_Subr is a special case.
4304 * lisp.h (struct Lisp_Vector, struct Lisp_Char_Table):
4305 (struct Lisp_Sub_Char_Table, struct Lisp_Bool_Vector):
4306 (struct Lisp_Hash_Table): Combine first two members into a single
f904488f 4307 struct vectorlike_header member. All uses of "size" and "next" members
eab3844f
PE
4308 changed to be "header.size" and "header.next".
4309 * buffer.h (struct buffer): Likewise.
4310 * font.h (struct font_spec, struct font_entity, struct font): Likewise.
4311 * frame.h (struct frame): Likewise.
4312 * process.h (struct Lisp_Process): Likewise.
4313 * termhooks.h (struct terminal): Likewise.
4314 * window.c (struct save_window_data, struct saved_window): Likewise.
4315 * window.h (struct window): Likewise.
4316 * alloc.c (allocate_buffer, Fmake_bool_vector, allocate_pseudovector):
4317 Use XSETPVECTYPESIZE, not XSETPVECTYPE, to avoid aliasing problems.
4318 * buffer.c (init_buffer_once): Likewise.
4319 * lread.c (defsubr): Use XSETTYPED_PVECTYPE, since Lisp_Subr is a
4320 special case.
4321 * process.c (Fformat_network_address): Use local var for size,
4322 for brevity.
4323
0df1eac5
PE
4324 * bytecode.c (exec_byte_code): Don't use XVECTOR before CHECK_VECTOR.
4325
847ab9d1 4326 Make the Lisp reader and string-to-float more consistent (Bug#8525)
452f4150
PE
4327 * data.c (atof): Remove decl; no longer used or needed.
4328 (digit_to_number): Move to lread.c.
4329 (Fstring_to_number): Use new string_to_number function, to be
4330 consistent with how the Lisp reader treats infinities and NaNs.
4331 Do not assume that floating-point numbers represent EMACS_INT
4332 without losing information; this is not true on most 64-bit hosts.
4333 Avoid double-rounding errors, by insisting on integers when
4334 parsing non-base-10 numbers, as the documentation specifies.
4335 * lisp.h (string_to_number): New decl, replacing ...
4336 (isfloat_string): Remove.
bc0a5c13 4337 * lread.c: Include <inttypes.h>, for uintmax_t and strtoumax.
d78050d6 4338 (read1): Do not accept +. and -. as integers; this
452f4150
PE
4339 appears to have been a coding error. Similarly, do not accept
4340 strings like +-1e0 as floating point numbers. Do not report
4341 overflow for integer overflows unless the base is not 10 which
4342 means we have no simple and reliable way to continue.
4343 Break out the floating-point parsing into a new
4344 function string_to_number, so that Fstring_to_number parses
4345 floating point numbers consistently with the Lisp reader.
04f2d78b 4346 (digit_to_number): Move here from data.c. Make it static inline.
452f4150
PE
4347 (E_CHAR, EXP_INT): Remove, replacing with ...
4348 (E_EXP): New macro, to solve the "1.0e+" problem mentioned below.
4349 (string_to_number): New function, replacing isfloat_string.
4350 This function checks for valid syntax and produces the resulting
4351 Lisp float number too. Rework it so that string-to-number
bc0a5c13 4352 no longer mishandles examples like "1.0e+". Use strtoumax,
d78050d6
PE
4353 so that overflow for non-base-10 numbers is reported only when
4354 there's no portable and simple way to convert to floating point.
452f4150 4355
67769ffc
PE
4356 * textprop.c (set_text_properties_1): Rewrite for clarity,
4357 and to avoid GCC warning about integer overflow.
4358
c20db43f
PE
4359 * intervals.h (struct interval): Use EMACS_INT for members
4360 where EMACS_UINT might cause problems. See
4361 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00514.html>.
4362 (CHECK_TOTAL_LENGTH): Remove cast to EMACS_INT; no longer needed.
4363 * intervals.c (interval_deletion_adjustment): Now returns EMACS_INT.
4364 All uses changed.
37aa2f85
PE
4365 (offset_intervals): Tell GCC not to worry about length overflow
4366 when negating a negative length.
c20db43f 4367
2538aa2f
PE
4368 * alloc.c (overrun_check_malloc, overrun_check_realloc): Now static.
4369 (overrun_check_free): Likewise.
4370
f2d3008d
PE
4371 * alloc.c (SDATA_SIZE) [!GC_CHECK_STRING_BYTES]: Avoid runtime check
4372 in the common case where SDATA_DATA_OFFSET is a multiple of Emacs
4373 word size.
4374
ec8df744
PE
4375 * gnutls.c: Fix problems found by GCC 4.6.0 on Ubuntu 10.10.
4376 (gnutls_make_error): Rename local to avoid shadowing.
4377 (gnutls_emacs_global_deinit): ifdef out; not used.
4378 (Fgnutls_boot): Use const for pointer to readonly storage.
4379 Comment out unused local. Fix pointer signedness problems.
4380
640ee02d
PE
4381 * lread.c (openp): Don't stuff size_t into an 'int'.
4382 Use <= on length, not < on length + 1, to avoid GCC 4.6.0 warning
4383 about possible signed overflow.
4384
6048fb2a
PE
4385 * gtkutil.c: Fix problems found by GCC 4.6.0 on Ubuntu 10.10.
4386 (GDK_KEY_g): Don't define if already defined.
4387 (xg_prepare_tooltip): Avoid pointer signedness problem.
4388 (xg_set_toolkit_scroll_bar_thumb): Redo to avoid two casts.
4389
fa3c87e1
PE
4390 * process.c (Fnetwork_interface_info): Avoid left-shift undefined
4391 behavior with 1 << 31. GCC 4.6.0 warns about this on 32-bit hosts.
4392
2172544b
PE
4393 * xfns.c (Fx_window_property): Simplify a bit,
4394 to make a bit faster and to avoid GCC 4.6.0 warning.
4395 * xselect.c (x_get_window_property, x_handle_dnd_message): Likewise.
4396
9b821a21
PE
4397 * fns.c (internal_equal): Don't assume size_t fits in int.
4398
3c616cfa
PE
4399 * alloc.c (compact_small_strings): Tighten assertion a little.
4400
c2982e87
PE
4401 Replace pEd with more-general pI, and fix some printf arg casts.
4402 * lisp.h (pI): New macro, generalizing old pEd macro to other
4403 conversion specifiers. For example, use "...%"pI"d..." rather
4404 than "...%"pEd"...".
4405 (pEd): Remove. All uses replaced with similar uses of pI.
4406 * src/m/amdx86-64.h, src/m/ia64.h, src/m/ibms390x.h: Likewise.
4407 * alloc.c (check_pure_size): Don't overflow by converting size to int.
4408 * bidi.c (bidi_dump_cached_states): Use pI to avoid cast.
4409 * data.c (Fnumber_to_string): Use pI instead of if-then-else-abort.
4410 * dbusbind.c (xd_append_arg): Use pI to avoid cast.
4411 (Fdbus_method_return_internal, Fdbus_method_error_internal): Likewise.
4412 * font.c (font_unparse_xlfd): Avoid potential buffer overrun on
4413 64-bit hosts.
4414 (font_unparse_xlfd, font_unparse_fcname): Use pI to avoid casts.
4415 * keyboard.c (record_char, modify_event_symbol): Use pI to avoid casts.
4416 * print.c (safe_debug_print, print_object): Likewise.
4417 (print_object): Don't overflow by converting EMACS_INT or EMACS_UINT
4418 to int.
6f04d126
PE
4419 Use pI instead of if-then-else-abort. Use %p to avoid casts,
4420 avoiding the 0 flag, which is not portable.
c2982e87
PE
4421 * process.c (Fmake_network_process): Use pI to avoid cast.
4422 * region-cache.c (pp_cache): Likewise.
4423 * xdisp.c (decode_mode_spec): Likewise.
4424 * xrdb.c (x_load_resources) [USE_MOTIF]: Use pI to avoid undefined
4425 behavior on 64-bit hosts with printf arg.
6f04d126 4426 * xselect.c (x_queue_event): Use %p to avoid casts, avoiding 0 flag.
c2982e87
PE
4427 (x_stop_queuing_selection_requests): Likewise.
4428 (x_get_window_property): Don't truncate byte count to an 'int'
4429 when tracing.
0b432f21 4430
5e073ec7
PE
4431 * frame.c (frame_name_fnn_p): Get rid of strtol, which isn't right
4432 here, since it parses constructs like leading '-' and spaces,
4433 which are not wanted; and it overflows with large numbers.
4434 Instead, simply match F[0-9]+, which is what is wanted anyway.
4435
36372bf9
PE
4436 * alloc.c: Remove unportable assumptions about struct layout.
4437 (SDATA_SELECTOR, SDATA_DATA_OFFSET): New macros.
4438 (SDATA_OF_STRING, SDATA_SIZE, allocate_string_data):
4439 (allocate_vectorlike, make_pure_vector): Use the new macros,
4440 plus offsetof, to remove unportable assumptions about struct layout.
4441 These assumptions hold on all porting targets that I know of, but
4442 they are not guaranteed, they're easy to remove, and removing them
4443 makes further changes easier.
4444
0b432f21
PE
4445 * alloc.c (BLOCK BYTES): Fix typo by changing "ablock" to "ablocks".
4446 This doesn't fix a bug but makes the code clearer.
bfd1c781
PE
4447 (string_overrun_cookie): Now const. Use initializers that
4448 don't formally overflow signed char, to avoid warnings.
000098c1
PE
4449 (allocate_string_data) [GC_CHECK_STRING_OVERRUN]: Fix typo that
4450 can cause Emacs to crash when string overrun checking is enabled.
c7bda33c
PE
4451 (allocate_buffer): Don't assume sizeof (struct buffer) is a
4452 multiple of sizeof (EMACS_INT); it need not be, if
4453 alignof(EMACS_INT) < sizeof (EMACS_INT).
d0f4e1f5 4454 (check_sblock, check_string_bytes, check_string_free_list): Protoize.
0b432f21 4455
895009e1
JB
44562011-04-26 Juanma Barranquero <lekktu@gmail.com>
4457
4458 * keyboard.c (QCrtl): Rename from Qrtl. All uses changed.
4459
6a7a1b0b
TZ
44602011-04-26 Teodor Zlatanov <tzz@lifelogs.com>
4461
4462 * gnutls.c (emacs_gnutls_handshake): Return an error if we're not
b5f869a7 4463 supposed to be handshaking. (Bug#8556)
6a7a1b0b
TZ
4464 Reported by Paul Eggert <eggert@cs.ucla.edu>.
4465
841a1577 44662011-04-26 Daniel Colascione <dan.colascione@gmail.com>
0438ce91
DC
4467
4468 * lisp.h (Qdebug): List symbol.
895009e1 4469 * eval.c (Qdebug): Restore global linkage.
0438ce91
DC
4470 * keyboard.c (debug-on-event): New variable.
4471 (handle_user_signal): Break into debugger when debug-on-event
4472 matches the current signal symbol.
4473
f2d3ba6f
DN
44742011-04-25 Dan Nicolaescu <dann@ics.uci.edu>
4475
4476 * alloc.c (check_sblock, check_string_bytes)
4477 (check_string_free_list): Convert to standard C.
4478
42ce4c63
TZ
44792011-04-25 Teodor Zlatanov <tzz@lifelogs.com>
4480
4481 * w32.c (emacs_gnutls_push): Fix typo.
4482
825cd63c
EZ
44832011-04-25 Eli Zaretskii <eliz@gnu.org>
4484
fb11d64d
EZ
4485 * gnutls.c (emacs_gnutls_handshake): Avoid compiler warnings about
4486 "cast to pointer from integer of different size".
4487
825cd63c
EZ
4488 Improve doprnt and its use in verror. (Bug#8545)
4489 * doprnt.c (doprnt): Document the set of format control sequences
4490 supported by the function. Use SAFE_ALLOCA instead of always
4491 using `alloca'.
4492
4493 * eval.c (verror): Don't limit the buffer size at size_max-1, that
4494 is one byte too soon. Don't use xrealloc; instead xfree and
4495 xmalloc anew.
4496
e061a11b
TZ
44972011-04-24 Teodor Zlatanov <tzz@lifelogs.com>
4498
4499 * gnutls.h: Add GNUTLS_STAGE_CALLBACKS enum to denote we're in the
4500 callbacks stage.
4501
4502 * gnutls.c: Renamed global_initialized to
4503 gnutls_global_initialized. Added internals for the
4504 :verify-hostname-error, :verify-error, and :verify-flags
4505 parameters of `gnutls-boot' and documented those parameters in the
4506 docstring. Start callback support.
9173deec
JB
4507 (emacs_gnutls_handshake): Add Woe32 support. Retry handshake
4508 unless a fatal error occurred. Call gnutls_alert_send_appropriate
4509 on error. Return error code.
e061a11b
TZ
4510 (emacs_gnutls_write): Call emacs_gnutls_handle_error.
4511 (emacs_gnutls_read): Likewise.
4512 (Fgnutls_boot): Return handshake error code.
4513 (emacs_gnutls_handle_error): New function.
4514 (wsaerror_to_errno): Likewise.
4515
4516 * w32.h (emacs_gnutls_pull): Add prototype.
4517 (emacs_gnutls_push): Likewise.
4518
4519 * w32.c (emacs_gnutls_pull): New function for GnuTLS on Woe32.
4520 (emacs_gnutls_push): Likewise.
4521
45222011-04-24 Claudio Bley <claudio.bley@gmail.com> (tiny change)
4523
4524 * process.c (wait_reading_process_output): Check if GnuTLS
4525 buffered some data internally if no FDs are set for TLS
4526 connections.
4527
4528 * makefile.w32-in (OBJ2): Add gnutls.$(O).
4529 (LIBS): Link to USER_LIBS.
4530 ($(BLD)/gnutls.$(0)): New target.
4531
fa6996bc
EZ
45322011-04-24 Eli Zaretskii <eliz@gnu.org>
4533
eb35682e
EZ
4534 * xdisp.c (handle_single_display_spec): Rename the
4535 display_replaced_before_p argument into display_replaced_p, to
4536 make it consistent with the commentary. Fix typos in the
4537 commentary.
4538
e2ad650c
EZ
4539 * textprop.c (syms_of_textprop): Remove dead code.
4540 (copy_text_properties): Delete obsolete commentary about an
4541 interface that was deleted long ago. Fix typos in the description
4542 of arguments.
4543
1b2de274
EZ
4544 * msdos.c (XMenuActivate, XMenuAddSelection): Adjust argument list
4545 to changes in oldXMenu/XMenu.h from 2011-04-16.
4546 <menu_help_message, prev_menu_help_message>: Constify.
4547 (IT_menu_make_room): menu->help_text is now `const char **';
4548 adjust.
4549
4550 * msdos.h (XMenuActivate, XMenuAddSelection): Adjust prototypes
4551 to changes in oldXMenu/XMenu.h from 2011-04-16.
4552 (struct XMenu): Declare `help_text' `const char **'.
4553
4554 * xfaces.c <Qunspecified>: Make extern again.
4555
4556 * syntax.c: Include sys/types.h before including regex.h, as
4557 required by Posix.
4558
762b15be
EZ
4559 * doc.c (get_doc_string): Improve the format passed to `error'.
4560
4561 * doprnt.c (doprnt): Improve commentary.
4562
4563 * term.c (init_tty) [MSDOS]: Fix 1st argument to maybe_fatal.
4564
4565 * Makefile.in (TAGS): Depend on $(M_FILE) and $(S_FILE), and scan
4566 them with etags.
4567
f1052e5d
EZ
4568 * makefile.w32-in (globals.h): Add a dummy recipe, to make any
4569 changes in globals.h immediately force recompilation.
762b15be
EZ
4570 (TAGS): Depend on $(CURDIR)/m/intel386.h and
4571 $(CURDIR)/s/ms-w32.h.
4572 (TAGS-gmake): Scan $(CURDIR)/m/intel386.h and $(CURDIR)/s/ms-w32.h.
f1052e5d 4573
fa6996bc
EZ
4574 * character.c (Fchar_direction): Function deleted.
4575 (syms_of_character): Don't defsubr it.
4576 <char-direction-table>: Deleted.
4577
e6c3da20
EZ
45782011-04-23 Eli Zaretskii <eliz@gnu.org>
4579
4580 Fix doprnt so it could be used again safely in `verror'. (Bug#8435)
4581 * doprnt.c: Include limits.h.
4582 (SIZE_MAX): New macro.
04f2d78b
CB
4583 (doprnt): Return a size_t value. 2nd arg is now size_t.
4584 Many local variables are now size_t instead of int or unsigned.
e6c3da20
EZ
4585 Improve overflow protection. Support `l' modifier for integer
4586 conversions. Support %l conversion. Don't assume an EMACS_INT
4587 argument for integer conversions and for %c.
4588
4589 * lisp.h (doprnt): Restore prototype.
4590
4591 * makefile.w32-in ($(BLD)/callint.$(O)): Depend on
4592 $(SRC)/character.h.
4593
4594 * Makefile.in (base_obj): Add back doprnt.o.
4595
4596 * deps.mk (doprnt.o): Add back prerequisites.
4597 (callint.o): Depend on character.h.
4598
4599 * eval.c (internal_lisp_condition_case): Include the handler
4600 representation in the error message.
4601 (verror): Call doprnt instead of vsnprintf. Fix an off-by-one bug
4602 when breaking from the loop.
4603
4604 * xdisp.c (vmessage): Call doprnt instead of vsnprintf.
4605
4606 * callint.c (Fcall_interactively): When displaying error message
4607 about invalid control letter, pass the character's codepoint, not
4608 a pointer to its multibyte form. Improve display of the character
4609 in octal and display also its hex code.
4610
4611 * character.c (char_string): Use %x to display the (unsigned)
4612 codepoint of an invalid character, to avoid displaying a bogus
4613 negative value.
4614
4615 * font.c (check_otf_features): Pass SDATA of SYMBOL_NAME to
4616 `error', not SYMBOL_NAME itself.
4617
4618 * coding.c (Fencode_sjis_char, Fencode_big5_char): Use %c for
4619 character arguments to `error'.
4620
4621 * charset.c (check_iso_charset_parameter): Fix incorrect argument
4622 to `error' in error message about FINAL_CHAR argument. Make sure
4623 FINAL_CHAR is a character, and use %c when it is passed as
4624 argument to `error'.
4625
4ffd0d6b 46262011-04-23 Eli Zaretskii <eliz@gnu.org>
97a93095
EZ
4627
4628 * s/ms-w32.h (localtime): Redirect to sys_localtime.
4629
4630 * w32.c: Include <time.h>.
4631 (sys_localtime): New function.
4632
4ffd0d6b 46332011-04-23 Chong Yidong <cyd@stupidchicken.com>
c17819f4
CY
4634
4635 * xdisp.c (init_xdisp): Initialize echo_area_window (Bug#6451).
4636
4ffd0d6b 4637 * buffer.c (syms_of_buffer): Doc fix (Bug#6902).
aac0c6e3 4638
4ffd0d6b 46392011-04-23 Samuel Thibault <sthibault@debian.org> (tiny change)
aac0c6e3 4640
4ffd0d6b
GM
4641 * sysdep.c (wait_for_termination): On GNU Hurd, kill returns -1 on
4642 zombies (Bug#8467).
aac0c6e3 4643
04c56954
EZ
46442011-04-19 Eli Zaretskii <eliz@gnu.org>
4645
4646 * syntax.h (SETUP_SYNTAX_TABLE_FOR_OBJECT): Fix setting of
4647 gl_state.e_property when gl_state.object is Qt.
4648
4649 * insdel.c (make_gap_larger): Remove limitation of buffer size
4650 to <= INT_MAX.
4651
16a43933
CY
46522011-04-18 Chong Yidong <cyd@stupidchicken.com>
4653
4654 * xdisp.c (lookup_glyphless_char_display)
4655 (produce_glyphless_glyph): Handle cons cell entry in
4656 glyphless-char-display.
4657 (Vglyphless_char_display): Document it.
4658
4659 * term.c (produce_glyphless_glyph): Handle cons cell entry in
4660 glyphless-char-display.
4661
4581706e
CY
46622011-04-17 Chong Yidong <cyd@stupidchicken.com>
4663
4664 * xdisp.c (get_next_display_element): Remove unnecessary ifdefs.
4665
4666 * termhooks.h (FRAME_WINDOW_P): Remove duplicated definitions.
4667
4668 * dispextern.h (FACE_SUITABLE_FOR_ASCII_CHAR_P): Add missing
4669 definition for no-X builds.
4670
4887c6e2 46712011-04-16 Paul Eggert <eggert@cs.ucla.edu>
764430a3 4672
fd35b6f9
PE
4673 Static checks with GCC 4.6.0 and non-default toolkits.
4674
5c1ccb01
PE
4675 * s/sol2-6.h, s/unixware.h (PTY_TTY_NAME_SPRINTF): Protoize decl.
4676
006c5daa
PE
4677 * process.c (keyboard_bit_set): Define only if SIGIO.
4678 (send_process_trap): Mark it with NO_RETURN if it doesn't return.
4679 (send_process): Repair possible setjmp clobbering.
4680
efc736d3
PE
4681 * s/usg5-4-common.h (SETUP_SLAVE_PTY): Don't pass extra arg to 'fatal'.
4682
4e2fe2e6
PE
4683 * eval.c: Include <stdio.h>, for vsnprintf on non-GNU/Linux hosts.
4684
f97334a2
PE
4685 * data.c (arith_error): Mark with NO_RETURN if it doesn't return.
4686
4e75f29d
PE
4687 * alloc.c (bytes_used_when_full, SPARE_MEMORY, BYTES_USED):
4688 Define only if needed.
4689
90efadd1
PE
4690 * sysdep.c (_FILE_OFFSET_BITS): Make this hack even uglier
4691 by pacifying GCC about it. Maybe it's time to retire it?
875975e9 4692 * xfaces.c (USG, __TIMEVAL__): Likewise.
90efadd1 4693
3c647824
PE
4694 * dispextern.h (struct redisplay_interface): Rename param
4695 to avoid shadowing.
e264f262 4696 * termhooks.h (struct terminal): Likewise.
761383f4 4697 * xterm.c (xembed_send_message): Likewise.
3c647824 4698
b58c5c4a
PE
4699 * insdel.c (make_gap_smaller): Define only if
4700 USE_MMAP_FOR_BUFFERS || REL_ALLOC || DOUG_LEA_MALLOC.
4701
cad59032
PE
4702 * keyboard.c (read_char): Make a var volatile so longjmp won't clobber
4703 it.
4704
c339dc2e
PE
4705 * emacs.c (MAX_HEAP_BSS_DIFF, my_edata): Move to where they're used,
4706 so that we aren't warned about unused symbols.
4707
91a3e27b
PE
4708 * xfns.c (Fx_file_dialog): Rename local to avoid shadowing.
4709
399c71d3 4710 * xdisp.c (x_produce_glyphs): Mark var as initialized (Bug#8512).
7a3fb125 4711
8ffc96f5
PE
4712 * xfns.c (x_real_positions): Mark locals as initialized.
4713
eef9bc79
PE
4714 * xmenu.c (xmenu_show): Don't use uninitialized vars.
4715
098db9dd
PE
4716 * xterm.c: Fix problems found by static analysis with other toolkits.
4717 (toolkit_scroll_bar_interaction): Define and use only if USE_X_TOOLKIT.
dda3aedd
PE
4718 (x_dispatch_event): Declare static if USE_GTK, and
4719 define if USE_GTK || USE_X_TOOLKIT.
098db9dd 4720 (SET_SAVED_BUTTON_EVENT): Define only if USE_X_TOOLKIT || USE_GTK.
dda3aedd 4721 * xterm.h (x_dispatch_event): Extern only if USE_X_TOOLKIT.
841a1577
JB
4722 * xterm.c, xterm.h (x_mouse_leave): Bring this function back, but only
4723 if defined HAVE_MENUS && !defined USE_X_TOOLKIT && !defined USE_GTK.
098db9dd 4724
eb18f6cc
PE
4725 * xmenu.c (menu_help_callback): Pointer type fixes.
4726 Use const pointers when pointing at readonly data. Avoid pointer
4727 signedness clashes.
4728 (FALSE): Remove unused macro.
4729 (update_frame_menubar): Remove unused decl.
4730
1fe72bf8
PE
4731 * xfns.c (Fx_hide_tip): Move locals to avoid shadowing.
4732
60d9e1db
PE
4733 * menu.c (push_submenu_start, push_submenu_end): Do not define unless
4734 USE_X_TOOLKIT || USE_GTK || HAVE_NS || defined HAVE_NTGUI.
4735 (single_menu_item): Rename local to avoid shadowing.
4736
39261c26
PE
4737 * keyboard.c (make_lispy_event): Remove unused local var.
4738
018c5e19
PE
4739 * frame.c, frame.h (x_get_resource_string): Bring this back, but
4740 only if HAVE_X_WINDOWS && !USE_X_TOOLKIT.
4741
63d2b86e
PE
4742 * bitmaps: Change bitmaps from unsigned char back to the X11
4743 compatible char. Avoid the old compiler warnings about
4744 out-of-range initializers by using, for example, '\xab' rather
4745 than 0xab.
4746
aefd87e1
PE
4747 * xgselect.c (xgselect_initialize): Check vs interface
4748 even if ! (defined (USE_GTK) || defined (HAVE_GCONF)).
4749
bf501fb9
PE
4750 * xmenu.c (xmenu_show): Rename parm to avoid shadowing.
4751
e9829fdf
PE
4752 * xterm.c (x_create_toolkit_scroll_bar): Use const * for pointers
4753 to read-only memory.
4754
1086c095
PE
4755 * fns.c (vector): Remove; this old hack is no longer needed.
4756
2baccd04 4757 * xsmfns.c (create_client_leader_window): Rename shadowing arg.
401f10cb 4758 Remove unused var.
dde42981 4759 (gdk_x11_set_sm_client_id) [!USE_GTK]: Don't define.
2baccd04 4760
72391843 4761 * xrdb.c (x_load_resources): Omit unused local.
3565b346 4762
436c16df 4763 * xfns.c (free_frame_menubar, atof): Remove duplicate decls.
8a94ea33 4764 (x_window): Rename locals to avoid shadowing.
dc5ddd85 4765 (USG): Use the kludged USG macro, to pacify gcc.
436c16df 4766
92bb796d 4767 * xterm.c (x_alloc_nearest_color_for_widget): Remove; unused.
bbbef9e1 4768 (x_term_init): Remove local to avoid shadowing.
92bb796d 4769
764430a3 4770 * xfns.c, xterm.c (_XEditResCheckMessages): Protoize decl.
4887c6e2
PE
4771
4772 * xdisp.c, dispextern.h (set_vertical_scroll_bar): Now extern if
4773 USE_TOOLKIT_SCROLL_BARS && !USE_GTK, as xterm.c needs it then.
4774
d1dfb56c
EZ
47752011-04-16 Eli Zaretskii <eliz@gnu.org>
4776
c4354cb4
EZ
4777 * gnutls.c (Fgnutls_boot): Don't pass Lisp_Object to `error'.
4778
d1dfb56c
EZ
4779 Fix regex.c, syntax.c and friends for buffers > 2GB.
4780 * syntax.h (struct gl_state_s): Declare character position members
4781 EMACS_INT.
4782
4783 * syntax.c (update_syntax_table): Declare 2nd argument EMACS_INT.
4784
04f2d78b
CB
4785 * textprop.c (verify_interval_modification, interval_of):
4786 Declare arguments EMACS_INT.
d1dfb56c
EZ
4787
4788 * intervals.c (adjust_intervals_for_insertion): Declare arguments
4789 EMACS_INT.
4790
4791 * intervals.h (CHECK_TOTAL_LENGTH): Cast to EMACS_INT, not `int'.
4792
4793 * indent.c (Fvertical_motion): Local variable it_start is now
4794 EMACS_INT.
4795
4796 * regex.c (re_match, re_match_2, re_match_2_internal)
4797 (bcmp_translate, regcomp, regexec, print_double_string)
4798 (group_in_compile_stack, re_search, re_search_2, regex_compile)
4799 (re_compile_pattern, re_exec): Declare arguments and local
4800 variables `size_t' and `ssize_t' and return values `regoff_t', as
4801 appropriate.
4802 (POP_FAILURE_REG_OR_COUNT) <pfreg>: Declare `long'.
4803 (CHECK_INFINITE_LOOP) <failure>: Declare `ssize_t'.
4804 <compile_stack_type>: `size' and `avail' are now `size_t'.
4805
4806 * regex.h <regoff_t>: Use ssize_t, not int.
4807 (re_search, re_search_2, re_match, re_match_2): Arguments that
4808 specify buffer/string position and length are now ssize_t and
4809 size_t. Return type is regoff_t.
4810
613052cd
BK
48112011-04-16 Ben Key <bkey76@gmail.com>
4812
4813 * nsfont.m: Fixed bugs in ns_get_family and
4814 ns_descriptor_to_entity that were caused by using free to
4815 deallocate memory blocks that were allocated by xmalloc (via
4816 xstrdup). This caused Emacs to crash when compiled with
4817 XMALLOC_OVERRUN_CHECK defined (when Emacs was configured with
4818 --enable-checking=xmallocoverrun). xfree is now used to
4819 deallocate these memory blocks.
4820
4170f62f 48212011-04-15 Paul Eggert <eggert@cs.ucla.edu>
3e047f51 4822
71b41406
PE
4823 * sysdep.c (emacs_read): Remove unnecessary check vs MAX_RW_COUNT.
4824
9587a89d
PE
4825 emacs_write: Accept and return EMACS_INT for sizes.
4826 See http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00514.html
4827 et seq.
4828 * gnutls.c, gnutls.h (emacs_gnutls_read, emacs_gnutls_write):
4829 Accept and return EMACS_INT.
4830 (emacs_gnutls_write): Return the number of bytes written on
4831 partial writes.
4832 * sysdep.c, lisp.h (emacs_read, emacs_write): Likewise.
273a5f82
PE
4833 (emacs_read, emacs_write): Remove check for negative size, as the
4834 Emacs source code has been audited now.
9587a89d
PE
4835 * sysdep.c (MAX_RW_COUNT): New macro, to work around kernel bugs.
4836 (emacs_read, emacs_write): Use it.
273a5f82
PE
4837 * process.c (send_process): Adjust to the new signatures of
4838 emacs_write and emacs_gnutls_write. Do not attempt to store
4839 a byte offset into an 'int'; it might overflow.
9587a89d 4840 See http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00483.html
273a5f82 4841
3e047f51
PE
4842 * sound.c: Don't assume sizes fit in 'int'.
4843 (struct sound_device.period_size, alsa_period_size):
9c3c56a7 4844 Return EMACS_INT, not int.
3e047f51 4845 (struct sound_device.write, vox_write, alsa_write):
9c3c56a7
PE
4846 Accept EMACS_INT, not int.
4847 (wav_play, au_play): Use EMACS_INT to store sizes and to
3e047f51
PE
4848 record read return values.
4849
cc39a9db
BK
48502011-04-15 Ben Key <bkey76@gmail.com>
4851
c9d0ec6d
JB
4852 * keyboard.c (Qundefined): Don't declare static since it is used
4853 in nsfns.m.
4854 * xfaces.c (Qbold, Qexpanded, Qitalic, Qcondensed): Don't declare
4855 static since they are used in nsfont.m.
cc39a9db 4856
6c60eb9f
SM
48572011-04-15 Stefan Monnier <monnier@iro.umontreal.ca>
4858
4859 * process.c (Qprocessp): Don't declare static.
4860 * lisp.h (Qprocessp): Declare again.
4861
7990b61a
JB
48622011-04-15 Juanma Barranquero <lekktu@gmail.com>
4863
4864 * font.c (Qopentype): Don't make static (used from w32uniscribe.c).
4865
5d4cb038
PE
48662011-04-14 Paul Eggert <eggert@cs.ucla.edu>
4867
8bd7b830 4868 Improve C-level modularity by making more things 'static'.
cd64ea1d 4869
e3b27b31
PE
4870 Don't publish debugger-only interfaces to other modules.
4871 * lisp.h (safe_debug_print, debug_output_compilation_hack):
4872 (verify_bytepos, count_markers): Move decls to the only modules
4873 that need them.
4874 * region-cache.h (pp_cache): Likewise.
4875 * window.h (check_all_windows): Likewise.
4876 * marker.c, print.c, region-cache.c, window.c: Decls moved here.
4877
5d4cb038
PE
4878 * sysdep.c (croak): Now static, if
4879 defined TIOCNOTTY || defined USG5 || defined CYGWIN.
4880 * syssignal.h (croak): Declare only if not static.
69003fd8
PE
4881
4882 * alloc.c (refill_memory_reserve): Now static if
4883 !defined REL_ALLOC || defined SYSTEM_MALLOC.
4884 * lisp.h (refill_memory_reserve): Declare only if not static.
93ea6e8f 4885
e87b6180
PE
4886 * xsettings.c, xsettings.h (xsettings_get_system_normal_font):
4887 Define only if USE_LUCID.
4888
ac64929e
PE
4889 * xrdb.c (x_customization_string, x_rm_string): Now static.
4890
6f37259d
PE
4891 * xmenu.c (x_menu_wait_for_event): Export only if USE_MOTIF.
4892 * xterm.h (x_menu_wait_for_event): Declare only if USE_MOTIF.
4893
1683e3ab
PE
4894 * xdisp.c (draw_row_with_mouse_face): Now static.
4895 * dispextern.h (draw_row_with_mouse_fave): Remove decl.
4896
de9c2632
PE
4897 * window.h (check_all_windows): Mark externally visible.
4898
2b96acb7
PE
4899 * window.c (window_deletion_count): Now static.
4900
4901 * undo.c: Make symbols static if they're not exported.
4902 (last_undo_buffer, last_boundary_position, pending_boundary):
4903 Now static.
4904
50436f33
PE
4905 * textprop.c (interval_insert_behind_hooks): Now static.
4906 (interval_insert_in_front_hooks): Likewise.
4907
64520e5c
PE
4908 * term.c: Make symbols static if they're not exported.
4909 (tty_turn_off_highlight, get_tty_terminal, max_frame_cols):
4910 (max_frame_lines, tty_set_terminal_modes):
4911 (tty_reset_terminal_modes, tty_turn_off_highlight):
4912 (get_tty_terminal): Now static.
4913 (term_mouse_moveto): Do not define if HAVE_WINDOW_SYSTEM.
4914 * termhooks.h (term_mouse_moveto): Do not declare if
8bd7b830 4915 HAVE_WINDOW_SYSTEM.
64520e5c
PE
4916 * dispextern.h (tty_set_terminal_modes, tty_reset_terminal_modes):
4917 (tty_turn_off_highlight, get_tty_terminal): Remove decls.
4918
1fa53021
PE
4919 * sysdep.c: Make symbols static if they're not exported.
4920 (emacs_get_tty, emacs_set_tty, old_fcntl_flags, old_fcntl_owner):
4921 Now static.
4922 (sigprocmask_set, full_mask): Remove; unused.
4923 (wait_debugging): Mark as visible.
4924 * syssignal.h (SIGFULLMASK, full_mask): Remove decls.
4925 * systty.h (emacs_get_tty, emacs_set_tty): Remove decls.
4926
d4b43b22
PE
4927 * syntax.c (syntax_temp): Define only if !__GNUC__.
4928
b7c513d0
PE
4929 * sound.c (current_sound_device, current_sound): Now static.
4930
989b29ad
PE
4931 * search.c (searchbufs, searchbuf_head): Now static.
4932
13a55a78
PE
4933 * scroll.c (scroll_cost): Remove; unused.
4934 * dispextern.h (scroll_cost): Remove decl.
4935
de68a1fc
PE
4936 * region-cache.h (pp_cache): Mark as externally visible.
4937
40ccffa6
PE
4938 * process.c: Make symbols static if they're not exported.
4939 (process_tick, update_tick, create_process, chan_process):
4940 (Vprocess_alist, proc_buffered_char, datagram_access):
4941 (fd_callback_data, send_process_frame, process_sent_to): Now static.
4942 (deactivate_process): Mark defn as static, as well as decl.
4943 * lisp.h (create_process): Remove decl.
4944 * process.h (chan_process, Vprocess_alist): Remove decls.
4945
ad64fc97
PE
4946 * print.c: Make symbols static if they're not exported.
4947 (print_depth, new_backquote_output, being_printed, print_buffer):
4948 (print_buffer_size, print_buffer_pos, print_buffer_pos_byte):
4949 (print_interval, print_number_index, initial_stderr_stream):
4950 Now static.
4951 * lisp.h (Fprinc): Remove decl.
4952 (debug_output_compilation_hack): Mark as externally visible.
4953
adddb265
PE
4954 * sysdep.c (croak): Move decl from here to syssignal.h.
4955 * syssignal.h (croak): Put it here, so the API can be checked when
4956 'croak' is called from dissociate_if_controlling_tty.
4957
1717ede2
PE
4958 * minibuf.c: Make symbols static if they're not exported.
4959 (minibuf_save_list, choose_minibuf_frame): Now static.
4960 * lisp.h (choose_minibuf_frame): Remove decl.
4961
fa5fb2bc
PE
4962 * lisp.h (verify_bytepos, count_markers): Mark as externally visible.
4963
1e3890d1
PE
4964 * lread.c: Make symbols static if they're not exported.
4965 (read_objects, initial_obarray, oblookup_last_bucket_number):
4966 Now static.
4967 (make_symbol): Remove; unused.
4968 * lisp.h (initial_obarray, make_symbol): Remove decls.
4969
8a1414fa
PE
4970 * keyboard.c: Make symbols static if they're not exported.
4971 (single_kboard, recent_keys_index, total_keys, recent_keys):
4972 (this_command_key_count_reset, raw_keybuf, raw_keybuf_count):
4973 (this_single_command_key_start, echoing, last_auto_save):
4974 (read_key_sequence_cmd, dribble, recursive_edit_unwind):
4975 (command_loop, echo_now, keyboard_init_hook, help_char_p):
4976 (quit_throw_to_read_char, command_loop_2, top_level_1, poll_timer):
4977 (Vlispy_mouse_stem, double_click_count):
4978 Now static.
4979 (force_auto_save_soon): Define only if SIGDANGER.
4980 (ignore_mouse_drag_p): Now static if
4981 !defined HAVE_WINDOW_SYSTEM || defined USE_GTK || defined HAVE_NS.
4982 (print_help): Remove; unused.
4983 (stop_character, last_timer_event): Mark as externally visible.
4984 * keyboard.h (ignore_mouse_drag_p): Declare only if
4985 defined HAVE_WINDOW_SYSTEM && !defined USE_GTK && !defined HAVE_NS.
4986 (echo_now, help_char_p, quit_throw_to_read_char): Remove decls.
4987 * lisp.h (echoing): Remove decl.
4988 (force_auto_save_soon): Declare only if SIGDANGER.
4989 * xdisp.c (redisplay_window): Simplify code, to make it more
4990 obvious that ignore_mouse_drag_p is not accessed if !defined
4991 USE_GTK && !defined HAVE_NS.
4992
93ea6e8f
PE
4993 * intervals.c: Make symbols static if they're not exported.
4994 (merge_properties_sticky, merge_interval_right, delete_interval):
4995 Now static.
4996 * intervals.h (merge_interval_right, delete_interval): Remove decls.
4997
77382fcc
PE
4998 * insdel.c: Make symbols static if they're not exported.
4999 However, leave prepare_to_modify_buffer alone. It's never
5000 called from outside this function, but that appears to be a bug.
5001 (combine_after_change_list, combine_after_change_buffer):
4889fc82 5002 (adjust_after_replace, signal_before_change): Now static.
77382fcc
PE
5003 (adjust_after_replace_noundo): Remove; unused.
5004 * lisp.h (adjust_after_replace, adjust_after_replace_noundo):
4889fc82 5005 (signal_before_change): Remove decls.
77382fcc 5006
9306c32e
PE
5007 * indent.c (val_compute_motion, val_vmotion): Now static.
5008
cd44d2eb
PE
5009 * image.c: Make symbols static if they're not exported.
5010 * dispextern.h (x_create_bitmap_from_xpm_data): Do not declare
5011 if USE_GTK.
5012 * image.c (x_create_bitmap_from_xpm_data): Do not define if USE_GTK.
5013 (xpm_color_cache, ct_table, ct_colors_allocated): Now static.
5014
ad9a7a06
PE
5015 * fringe.c (standard_bitmaps): Now static.
5016 (max_used_fringe_bitmap): Now static, unless HAVE_NS.
5017
81626931
PE
5018 * frame.c: Make symbols static if they're not exported.
5019 (x_report_frame_params, make_terminal_frame): Now static.
5020 (get_frame_param): Now static, unless HAVE_NS.
5021 (x_fullscreen_adjust): Define if WINDOWSNT, not if HAVE_WINDOW_SYSTEM.
5022 (x_get_resource_string): Remove; not used.
5023 * frame.h (make_terminal_frame, x_report_frame_params):
5024 (x_get_resource_string); Remove decls.
5025 (x_fullscreen_adjust): Declare only if WINDOWSNT.
5026 * lisp.h (get_frame_param): Declare only if HAVE_NS.
5027
239f9db9
PE
5028 * font.c, fontset.c: Make symbols static if they're not exported.
5029 * dispextern.h (FACE_SUITABLE_FOR_ASCII_CHAR_P): New macro.
5030 (FACE_SUITABLE_FOR_CHAR_P): Use it.
5031 * font.c (font_close_object): Now static.
5032 * font.h (font_close_object): Remove.
5033 * fontset.c (FONTSET_OBJLIST): Remove.
5034 (free_realized_fontset) #if-0 the body, which does nothing.
5035 (face_suitable_for_char_p): #if-0, as it's never called.
5036 * fontset.h (face_suitable_for_char_p): Remove decl.
04f2d78b
CB
5037 * xfaces.c (face_at_string_position):
5038 Use FACE_SUITABLE_FOR_ASCII_CHAR_P, not FACE_SUITABLE_FOR_CHAR_P,
239f9db9
PE
5039 since 0 is always ASCII.
5040
dfcf3579
PE
5041 * fns.c (weak_hash_tables): Now static.
5042
5045092b
PE
5043 * fileio.c: Make symbols static if they're not exported.
5044 (auto_saving, auto_save_mode_bits, auto_save_error_occurred):
5045 (Vwrite_region_annotation_buffers): Now static.
5046
57a96f5c
PE
5047 * eval.c: Make symbols static if they're not exported.
5048 (backtrace_list, lisp_eval_depth, when_entered_debugger): Now static.
5049 * lisp.h (backtrace_list): Remove decl.
5050
35f08c38
PE
5051 * emacs.c: Make symbols static if they're not exported.
5052 (malloc_state_ptr, malloc_using_checking, syms_of_emacs):
5053 (fatal_error_code, fatal_error_signal_hook, standard_args):
5054 Now static.
5055 (fatal_error_signal): Now static, unless FLOAT_CATCH_SIGKILL.
5056 (DEFINE_DUMMY_FUNCTION): Mark function as externally visible.
5057 (__CTOR_LIST__, __DTOR_LIST__): Now externally visible.
5058 * lisp.h (fatal_error_signal_hook): Remove decl.
5059 (fatal_error_signal): Declare only if FLOAT_CATCH_SIGKILL.
5060
f44bd759
PE
5061 * editfns.c: Move a (normally-unused) function to its only use.
5062 * editfns.c, lisp.h (get_operating_system_release): Remove.
5063 * process.c (init_process) [DARWIN_OS]: Do it inline, as it is not
5064 worth the hassle of breaking this out.
5065
b532497d
PE
5066 * xterm.c: Make symbols static if they're not exported.
5067 (x_raise_frame, x_lower_frame, x_wm_set_window_state):
5068 (x_wm_set_icon_pixmap, x_initialize, XTread_socket_fake_io_error):
5069 (x_destroy_window, x_delete_display):
5070 Now static.
5071 (x_dispatch_event): Now static if ! (USE_MOTIF || USE_X_TOOLKIT).
5072 (x_mouse_leave): Remove; unused.
5073 * xterm.h (x_display_info_for_name, x_raise_frame, x_lower_frame):
5074 (x_destroy_window, x_wm_set_window_state, x_wm_set_icon_pixmap):
5075 (x_delete_display, x_initialize, x_set_border_pixel, x_screen_planes):
5076 Remove decls.
5077 (x_mouse_leave): Declare only if WINDOWSNT.
5078 (x_dispatch_event): Declare only if USE_MOTIF or USE_X_TOOLKIT.
5079 (xic_create_fontsetname): Declare only if HAVE_X_WINDOWS &&
5080 USE_X_TOOLKIT.
5081
1675728f
PE
5082 * ftxfont.c: Make symbols static if they're not exported.
5083 (ftxfont_driver): Export only if !defined HAVE_XFT && def8ined
5084 HAVE_FREETYPE.
5085 * font.h (ftxfont_driver): Likewise.
5086
e4cebfca
PE
5087 * xfns.c: Make symbols static if they're not exported.
5088 (x_last_font_name, x_display_info_for_name):
5089 (x_set_foreground_color, x_set_background_color, x_set_mouse_color):
5090 (x_set_cursor_color, x_set_border_pixel, x_set_border_color):
5091 (x_set_cursor_type, x_set_icon_type, x_set_icon_name):
5092 (x_set_scroll_bar_foreground, x_set_scroll_bar_background):
5093 (x_explicitly_set_name, x_set_title, xic_defaut_fontset, tip_timer):
5094 (last_show_tip_args): Now static.
5095 (xic_defaut_fontset, xic_create_fontsetname): Define only if
5096 defined HAVE_X_WINDOWS && defined USE_X_TOOLKIT
5097 (x_screen_planes): Remove; unused.
5098 * dispextern.h (x_screen_planes): Remove decl.
5099
5bf46f05
PE
5100 * dispnew.c: Make symbols static if they're not exported.
5101 * dispextern.h (redraw_garbaged_frames, scrolling):
5102 (increment_row_positions): Remove.
5103 * dispnew.c (new_glyph_matrix, increment_row_positions, scrolling):
5104 (delayed_size_change, glyph_matrix_count, glyph_pool_count):
5105 Now static.
5106 (redraw_garbaged_frames): Remove; unused.
5107
435f4c28
PE
5108 * xfaces.c: Make symbols static if they're not exported.
5109 * dispextern.h (ascii_face_of_lisp_face, free_realized_face):
5110 Remove decls.
5111 * xterm.h (defined_color): Remove decls.
5112 (x_free_dpy_colors): Declare only if USE_X_TOOLKIT.
5113 * xfaces.c (tty_suppress_bold_inverse_default_colors_p):
5114 (menu_face_changed_default, defined_color, free_realized_face):
5115 (x_free_dpy_colors): Define only if USE_X_TOOLKIT.
5116 (ascii_face_of_lisp_face): Remove; unused.
5117
8524aef3
PE
5118 * xdisp.c: Make symbols static if they're not exported.
5119 * dispextern.h (scratch_glyph_row, window_box_edges):
5120 (glyph_to_pixel_coords, set_cursor_from_row):
5121 (get_next_display_element, set_iterator_to_next):
5122 (highlight_trailing_whitespace, frame_to_window_pixel_xy):
5123 (show_mouse_face): Remove decls
5124 * frame.h (message_buf_print): Likewise.
5125 * lisp.h (pop_message, set_message, check_point_in_composition):
5126 Likewise.
5127 * xterm.h (set_vertical_scroll_bar): Likewise.
5128 * xdisp.c (list_of_error, Vmessage_stack, line_number_displayed):
5129 (message_buf_print, scratch_glyph_row, displayed_buffer):
5130 (set_iterator_to_next, pop_message, set_message, set_cursor_from_row):
5131 (get_next_display_element, show_mouse_face, window_box_edges):
5132 (frame_to_window_pixel_xy, check_point_in_composition):
5133 (set_vertical_scroll_bar, highlight_trailing_whitespace): Now static.
5134 (glyph_to_pixel_coords): Remove; unused.
5135
16390cd2
PE
5136 * dired.c (file_name_completion): Now static.
5137
5138 * dbusbind.c (xd_in_read_queued_messages): Now static.
5139
a25f4dfa
PE
5140 * lisp.h (circular_list_error, FOREACH): Remove; unused.
5141 * data.c (circular_list_error): Remove.
5142
14a9c8df
PE
5143 * commands.h (last_point_position, last_point_position_buffer):
5144 (last_point_position_window): Remove decls.
5145 * keyboard.c: Make these variables static.
5146
04f2d78b
CB
5147 * coding.h (coding, code_convert_region, encode_coding_gap):
5148 Remove decls.
74ab6df5
PE
5149 * coding.c (Vsjis_coding_system, Vbig5_coding_system):
5150 (iso_code_class, detect_coding, code_convert_region): Now static.
5151 (encode_coding_gap): Remove; unused.
5152
38dfbee1
PE
5153 * chartab.c (chartab_chars, chartab_bits): Now static.
5154
a2cb4e63
PE
5155 * charset.h (charset_iso_8859_1): Remove decl.
5156 * charset.c (charset_iso_8859_1, charset_emacs, map_charset_for_dump):
5157 Now static.
5158
127198fd
PE
5159 * ccl.h (check_ccl_update, Vccl_program_table): Remove decls.
5160 * ccl.c (Vccl_program_table): Now static.
5161 (check_ccl_update): Remove; unused.
5162
d85b608f
PE
5163 * category.c (SET_CATEGORY_SET, set_category_set): Move here.
5164 * category.h: ... from here.
5165 * category.c (check_category_table, set_category_set): Now static.
5166
31cd66f3
PE
5167 * casetab.c (Vascii_upcase_table, Vascii_eqv_table): Now static.
5168 * lisp.h: Remove these decls.
5169
c358e587
PE
5170 * buffer.c (buffer_count): Remove unused var.
5171
e78aecca
PE
5172 * bidi.c (bidi_dump_cached_states): Mark as externally visible,
5173 so that it's not optimized away.
5174 (bidi_ignore_explicit_marks_for_paragraph_level): Likewise.
5175 * dispextern.h (bidi_dump_cached_states): Remove, since it's
5176 exported only to the debugger.
5177
e192d7d3 5178 * atimer.c (alarm_signal_handler, run_all_atimers): Now static.
04f2d78b 5179 * atimer.h (run_all_atimers): Remove; not exported.
e192d7d3 5180
92470028
PE
5181 font.c: Make copy_font_spec and merge_font_spec ordinary C functions.
5182 * font.c (copy_font_spec): Rename from Fcopy_font_spec, since it
5183 was inaccessible from Lisp.
5184 (merge_font_spec): Likewise, renaming from Fmerge_font_spec.
5185 * font.c, font.h, fontset.c, xfaces.c, xfont.c: Change all uses.
5186
244ed907
PE
5187 alloc.c: Import and export fewer symbols, and remove unused items.
5188 * lisp.h (suppress_checking, die): Declare only if ENABLE_CHECKING
5189 is defined.
5190 (suppress_checking): Add EXTERNALLY_VISIBLE attribute, so that
5191 it's not optimized away by whole-program optimization.
5192 (message_enable_multibyte, free_misc): Remove.
5193 (catchlist, handlerlist, mark_backtrace):
5194 Declare only if BYTE_MARK_STACK.
5195 (mark_byte_stack): Likewise, fixing a ifdef-vs-if typo.
5196 * alloc.c (pure): Export only if VIRT_ADDR_VARIES is defined.
5197 (message_enable_multibyte): Remove decl.
5198 (free_misc, interval_free_list, float_block, float_block_index):
5199 (n_float_blocks, float_free_list, cons_block, cons_block_index):
5200 (cons_free_list, last_marked_index):
5201 Now static.
5202 (suppress_checking, die): Define only if ENABLE_CHECKING is defined.
5203 * eval.c (catchlist, handlerlist): Export only if BYTE_MARK_STACK.
5204 (mark_backtrace): Define only if BYTE_MARK_STACK.
5205 * xdisp.c (message_enable_multibyte): Now static.
5206
61c2b50e 5207 Declare Lisp_Object Q* variables to be 'static' if not exported.
955cbe7b
PE
5208 This makes it easier for human readers (and static analyzers)
5209 to see whether these variables are used from other modules.
5210 * alloc.c, buffer.c, bytecode.c, callint.c, casetab.c, category.c:
5211 * ccl.c, character.c, charset.c, cmds.c, coding.c, composite.c:
5212 * data.c, dbusbind.c, dired.c, editfns.c, eval.c, fileio.c, fns.c:
5213 * font.c, frame.c, fringe.c, ftfont.c, image.c, keyboard.c, keymap.c:
5214 * lread.c, macros.c, minibuf.c, print.c, process.c, search.c:
5215 * sound.c, syntax.c, textprop.c, window.c, xdisp.c, xfaces.c, xfns.c:
5216 * xmenu.c, xselect.c:
5217 Declare Q* vars static if they are not used in other modules.
5218 * ccl.h, character.h, charset.h, coding.h, composite.h, font.h:
5219 * frame.h, intervals.h, keyboard.h, lisp.h, process.h, syntax.h:
5220 Remove decls of unexported vars.
5221 * keyboard.h (EVENT_HEAD_UNMODIFIED): Remove now-unused macro.
5222
95c82688
PE
5223 * lisp.h (DEFINE_FUNC): Make sname 'static'.
5224
16a97296
PE
5225 Make Emacs functions such as Fatom 'static' by default.
5226 This makes it easier for human readers (and static analyzers)
5227 to see whether these functions can be called from other modules.
5228 DEFUN now defines a static function. To make the function external
5229 so that it can be used in other C modules, use the new macro DEFUE.
8bd7b830
PE
5230 * lisp.h (Funibyte_char_to_multibyte, Fsyntax_table_p):
5231 (Finit_image_library):
16a97296
PE
5232 (Feval_region, Fbacktrace, Ffetch_bytecode, Fswitch_to_buffer):
5233 (Ffile_executable_p, Fmake_symbolic_link, Fcommand_execute):
5234 (Fget_process, Fdocumentation_property, Fbyte_code, Ffile_attributes):
5235 Remove decls, since these functions are now static.
5236 (Funintern, Fget_internal_run_time): New decls, since these functions
5237 were already external.
95c82688 5238
16a97296
PE
5239 * alloc.c, buffer.c, callint.c, callproc.c, casefiddle.c, casetab.c:
5240 * ccl.c, character.c, chartab.c, cmds.c, coding.c, data.c, dispnew.c:
5241 * doc.c, editfns.c, emacs.c, eval.c, fileio.c, filelock.c, floatfns.c:
5242 * fns.c, font.c, fontset.c, frame.c, image.c, indent.c:
5243 * keyboard.c, keymap.c, lread.c:
5244 * macros.c, marker.c, menu.c, minibuf.c, print.c, process.c, search.c:
5245 * syntax.c, term.c, terminal.c, textprop.c, undo.c:
5246 * window.c, xdisp.c, xfaces.c, xfns.c, xmenu.c, xsettings.c:
5247 Mark functions with DEFUE instead of DEFUN,
5248 if they are used in other modules.
5249 * buffer.c (Fset_buffer_major_mode, Fdelete_overlay): New forward
5250 decls for now-static functions.
5251 * buffer.h (Fdelete_overlay): Remove decl.
5252 * callproc.c (Fgetenv_internal): Mark as internal.
5253 * composite.c (Fremove_list_of_text_properties): Remove decl.
5254 (Fcomposition_get_gstring): New forward static decl.
5255 * composite.h (Fcomposite_get_gstring): Remove decl.
5256 * dired.c (Ffile_attributes): New forward static decl.
5257 * doc.c (Fdocumntation_property): New forward static decl.
5258 * eval.c (Ffetch_bytecode): New forward static decl.
5259 (Funintern): Remove extern decl; now in .h file where it belongs.
5260 * fileio.c (Fmake_symbolic_link): New forward static decl.
5261 * image.c (Finit_image_library): New forward static decl.
5262 * insdel.c (Fcombine_after_change_execute): Make forward decl static.
5263 * intervals.h (Fprevious_property_change):
5264 (Fremove_list_of_text_properties): Remove decls.
5265 * keyboard.c (Fthis_command_keys): Remove decl.
5266 (Fcommand_execute): New forward static decl.
5267 * keymap.c (Flookup_key): New forward static decl.
5268 (Fcopy_keymap): Now static.
5269 * keymap.h (Flookup_key): Remove decl.
5270 * process.c (Fget_process): New forward static decl.
5271 (Fprocess_datagram_address): Mark as internal.
5272 * syntax.c (Fsyntax_table_p): New forward static decl.
5273 (skip_chars): Remove duplicate decl.
5274 * textprop.c (Fprevious_property_change): New forward static decl.
5275 * window.c (Fset_window_fringes, Fset_window_scroll_bars):
5276 Now internal.
5277 (Fset_window_margins, Fset_window_vscroll): New forward static decls.
5278 * window.h (Fset_window_vscroll, Fset_window_margins): Remove decls.
5279
785bbd42
PE
5280 * editfns.c (Fformat): Remove unreachable code.
5281
8b913b57
AS
52822011-04-14 Andreas Schwab <schwab@linux-m68k.org>
5283
5284 * fileio.c (Finsert_file_contents): Fix typo in 2005-05-13
5285 change. (Bug#8496)
5286
a6744a35
EZ
52872011-04-13 Eli Zaretskii <eliz@gnu.org>
5288
5289 * xdisp.c (handle_invisible_prop): Don't call bidi_paragraph_init
5290 when at ZV. (Bug#8487)
5291
e7974947
AS
52922011-04-12 Andreas Schwab <schwab@linux-m68k.org>
5293
baad03f0
AS
5294 * charset.c (Fclear_charset_maps): Use xfree instead of free.
5295 (Bug#8437)
5296 * keyboard.c (parse_tool_bar_item): Likewise.
5297 * sound.c (sound_cleanup, alsa_close): Likewise.
5298 * termcap.c (tgetent): Likewise.
5299 * xfns.c (x_default_font_parameter): Likewise.
5300 * xsettings.c (read_and_apply_settings): Likewise.
5301
e7974947
AS
5302 * alloc.c (overrun_check_malloc, overrun_check_realloc)
5303 (overrun_check_free): Protoize.
5304
28272684
PE
53052011-04-12 Paul Eggert <eggert@cs.ucla.edu>
5306
5307 * sysdep.c (emacs_read, emacs_write): Check for negative sizes
5308 since callers should never pass a negative size.
5309 Change the signature to match that of plain 'read' and 'write'; see
5310 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00397.html>.
5311 * lisp.h: Update prototypes of emacs_write and emacs_read.
5312
11997c76
EZ
53132011-04-11 Eli Zaretskii <eliz@gnu.org>
5314
5315 * xdisp.c (redisplay_window): Don't try to determine the character
5316 position of the scroll margin if the window start point w->startp
e896f03c 5317 is outside the buffer's accessible region. (Bug#8468)
11997c76 5318
8a2cbd72
EZ
53192011-04-10 Eli Zaretskii <eliz@gnu.org>
5320
5321 Fix write-region and its subroutines for buffers > 2GB.
5322 * fileio.c (a_write, e_write): Modify declaration of arguments and
5323 local variables to support buffers larger than 2GB.
5324 (Fcopy_file): Use EMACS_INT for return value of emacs_read.
5325
5326 * sysdep.c (emacs_write, emacs_read): Use ssize_t for last
5327 argument, local variables, and return value.
5328
5329 * lisp.h: Update prototypes of emacs_write and emacs_read.
5330
5331 * sound.c (vox_write): Use ssize_t for return value of emacs_write.
5332
4073e537 53332011-04-10 Paul Eggert <eggert@cs.ucla.edu>
eb3f1cc8 5334
1ebfdcb6
PE
5335 * xdisp.c (vmessage): Use memchr, not strnlen, which some hosts lack.
5336
b2ded58d
PE
5337 Fix more problems found by GCC 4.6.0's static checks.
5338
7d66342c
PE
5339 * xdisp.c (vmessage): Use a better test for character truncation.
5340
bbf47d44
PE
5341 * charset.c (load_charset_map): <, not <=, for optimization,
5342 and to avoid potential problems with integer overflow.
9248994d 5343 * chartab.c (sub_char_table_set_range, char_table_set_range): Likewise.
f9a68bc5 5344 * casetab.c (set_identity, shuffle): Likewise.
3ab1c7ce 5345 * editfns.c (Fformat): Likewise.
1e69125e 5346 * syntax.c (skip_chars): Likewise.
3befa583 5347
e3019616
PE
5348 * xmenu.c (set_frame_menubar): Allocate smaller local vectors.
5349 This also lets GCC 4.6.0 generate slightly better loop code.
5350
becfa255
PE
5351 * callint.c (Fcall_interactively): <, not <=, for optimization.
5352 (Fcall_interactively): Count the number of arguments produced,
5353 not the number of arguments given. This is simpler and lets GCC
5354 4.6.0 generate slightly better code.
5355
dae0cd48
PE
5356 * ftfont.c: Distingish more carefully between FcChar8 and char.
5357 The previous code passed unsigned char * to a functions like
5358 strlen and xstrcasecmp that expect char *, which does not
5359 conform to the C standard.
5360 (get_adstyle_property, ftfont_pattern_entity): Use FcChar8 for
5361 arguments to FcPatternGetString, and explicitly cast FcChar8 * to
5362 char * when the C standard requires it.
5363
76032d70
PE
5364 * keyboard.c (read_char): Remove unused var.
5365
eb3f1cc8
PE
5366 * eval.c: Port to Windows vsnprintf (Bug#8435).
5367 Include <limits.h>.
5368 (SIZE_MAX): Define if the headers do not.
5369 (verror): Do not give up if vsnprintf returns a negative count.
5370 Instead, grow the buffer. This ports to Windows vsnprintf, which
5371 does not conform to C99. Problem reported by Eli Zaretskii.
5372 Also, simplify the allocation scheme, by avoiding the need for
5373 calling realloc, and removing the ALLOCATED variable.
5374
70476b54
PE
5375 * eval.c (verror): Initial buffer size is 4000 (not 200) bytes.
5376
12020a9e
PE
5377 Remove invocations of doprnt, as Emacs now uses vsnprintf.
5378 But keep the doprint source code for now, as we might revamp it
5379 and use it again (Bug#8435).
ea6c7ae6
PE
5380 * lisp.h (doprnt): Remove.
5381 * Makefile.in (base_obj): Remove doprnt.o.
5382 * deps.mk (doprnt.o): Remove.
5383
5fdb398c
PE
5384 error: Print 32- and 64-bit integers portably (Bug#8435).
5385 Without this change, on typical 64-bit hosts error ("...%d...", N)
5386 was used to print both 32- and 64-bit integers N, which relied on
5387 undefined behavior.
5388 * lisp.h, src/m/amdx86-64.h, src/m/ia64.h, src/m/ibms390x.h (pEd):
5389 New macro.
5390 * lisp.h (error, verror): Mark as printf-like functions.
5391 * eval.c (verror): Use vsnprintf, not doprnt, to do the real work.
5392 Report overflow in size calculations when allocating printf buffer.
5393 Do not truncate output string at its first null byte.
5394 * xdisp.c (vmessage): Use vsnprintf, not doprnt, to do the real work.
5395 Truncate the output at a character boundary, since vsnprintf does not
5396 do that.
5397 * charset.c (check_iso_charset_parameter): Convert internal
5398 character to string before calling 'error', since %c now has the
5399 printf meaning.
5400 * coding.c (Fdecode_sjis_char, Fdecode_big5_char): Avoid int
5401 overflow when computing char to be passed to 'error'. Do not
5402 pass Lisp_Object to 'error'; pass the integer instead.
5403 * nsfns.m (Fns_do_applescript): Use int, not long, since it's
5404 formatted with plain %d.
5405
b189fa66
PE
5406 * eval.c (internal_lisp_condition_case): Don't pass spurious arg.
5407
bff87ef0
PE
5408 * keyboard.c (access_keymap_keyremap): Print func name, not garbage.
5409
7e2cac20
PE
5410 * coding.c (Fdecode_sjis_char): Don't assume CODE fits in int.
5411
ce4d90b5
PE
5412 * xterm.c (x_catch_errors): Remove duplicate declaration.
5413
266c9547
PE
5414 * term.c (maybe_fatal): Mark its 3rd arg as a printf format, too.
5415
79c49ad2
PE
5416 * xdisp.c, lisp.h (message_nolog): Remove; unused.
5417
368f4090
JM
54182011-04-10 Jim Meyering <meyering@redhat.com>
5419
5420 use ssize_t and size_t for read- and write-like emacs_gnutls_* functions
5421 * gnutls.c (emacs_gnutls_read): Adjust signature to be more read-like:
5422 return ssize_t not "int", and use size_t as the buffer length.
5423 (emacs_gnutls_write): Likewise, and make the buffer pointer "const".
5424 * gnutls.h: Update declarations.
5425 * process.c (read_process_output): Use ssize_t, to match.
5426 (send_process): Likewise.
5427
a32d4040
CY
54282011-04-09 Chong Yidong <cyd@stupidchicken.com>
5429
5430 * image.c (Fimagemagick_types): Doc fix, and comment cleanup.
5431
8546720e 54322011-04-09 Chong Yidong <cyd@stupidchicken.com>
aac0c6e3 5433
04f2d78b
CB
5434 * ftfont.c (get_adstyle_property, ftfont_pattern_entity):
5435 Use unsigned char, to match FcChar8 type definition.
aac0c6e3 5436
8546720e
GM
5437 * xterm.c (handle_one_xevent):
5438 * xmenu.c (create_and_show_popup_menu):
5439 * xselect.c (x_decline_selection_request)
5440 (x_reply_selection_request): Avoid type-punned deref of X events.
aac0c6e3 5441
0a2f5c1a 54422011-04-09 Eli Zaretskii <eliz@gnu.org>
a53e2e89
EZ
5443
5444 Fix some uses of `int' instead of EMACS_INT.
5445 * search.c (string_match_1, fast_string_match)
5446 (fast_c_string_match_ignore_case, fast_string_match_ignore_case)
5447 (scan_buffer, find_next_newline_no_quit)
5448 (find_before_next_newline, search_command, Freplace_match)
5449 (Fmatch_data): Make some `int' variables be EMACS_INT.
5450
5451 * xdisp.c (display_count_lines): 3rd argument and return value now
5452 EMACS_INT. All callers changed.
5453 (pint2hrstr): Last argument is now EMACS_INT.
5454
5455 * coding.c (detect_coding_utf_8, detect_coding_emacs_mule)
5456 (detect_coding_iso_2022, detect_coding_sjis, detect_coding_big5)
5457 (detect_coding_ccl, detect_coding_charset, decode_coding_utf_8)
5458 (decode_coding_utf_16, decode_coding_emacs_mule)
5459 (decode_coding_iso_2022, decode_coding_sjis, decode_coding_big5)
5460 (decode_coding_ccl, decode_coding_charset)
5461 <consumed_chars, consumed_chars_base>: Declare EMACS_INT.
5462 (decode_coding_iso_2022, decode_coding_emacs_mule)
5463 (decode_coding_sjis, decode_coding_big5, decode_coding_charset)
5464 <char_offset, last_offset>: Declare EMACS_INT.
5465 (encode_coding_utf_8, encode_coding_utf_16)
5466 (encode_coding_emacs_mule, encode_invocation_designation)
5467 (encode_designation_at_bol, encode_coding_iso_2022)
5468 (encode_coding_sjis, encode_coding_big5, encode_coding_ccl)
5469 (encode_coding_raw_text, encode_coding_charset) <produced_chars>:
5470 Declare EMACS_INT.
5471 (ASSURE_DESTINATION): Declare more_bytes EMACS_INT.
5472 (encode_invocation_designation): Last argument P_NCHARS is now
5473 EMACS_INT.
5474 (decode_eol): Declare pos_byte, pos, and pos_end EMACS_INT.
5475 (produce_chars): from_nchars and to_nchars are now EMACS_INT.
5476
5477 * coding.h (struct coding_system) <head_ascii>: Declare EMACS_INT.
5478 All users changed.
5479
5480 * ccl.c (Fccl_execute_on_string): Declare some variables
5481 EMACS_INT.
5482
8546720e 54832011-04-08 Samuel Thibault <sthibault@debian.org> (tiny change)
0080dc6b
SS
5484
5485 * term.c (init_tty): Fix incorrect ifdef placement (Bug#8450).
5486
4e19a977
CS
54872011-03-19 Christoph Scholtes <cschol2112@googlemail.com>
5488
5489 * process.c (Fformat_network_address): Doc fix.
5490
87302331
R
54912011-04-08 T.V. Raman <tv.raman.tv@gmail.com> (tiny change)
5492
5493 * xml.c (parse_region): Avoid creating spurious whiespace nodes.
5494
cbb59342
CY
54952011-04-08 Chong Yidong <cyd@stupidchicken.com>
5496
5497 * keyboard.c (read_char): Call Lisp function help-form-show,
5498 instead of using internal_with_output_to_temp_buffer.
5499 (Qhelp_form_show): New var.
e0d38eeb 5500 (syms_of_keyboard): Use DEFSYM macro.
cbb59342
CY
5501
5502 * print.c (internal_with_output_to_temp_buffer): Function deleted.
5503
5504 * lisp.h (internal_with_output_to_temp_buffer): Remove prototype.
5505
e67a13ab
CY
55062011-04-06 Chong Yidong <cyd@stupidchicken.com>
5507
04f2d78b
CB
5508 * process.c (Flist_processes): Remove to Lisp.
5509 (list_processes_1): Delete.
e67a13ab 5510
973f782d
EZ
55112011-04-06 Eli Zaretskii <eliz@gnu.org>
5512
7c106b1e
EZ
5513 * msdos.c (careadlinkat, careadlinkatcwd): MS-DOS replacements.
5514
973f782d
EZ
5515 * w32.c (careadlinkat, careadlinkatcwd): New always-fail stubs.
5516
41cf7d1a 55172011-04-06 Paul Eggert <eggert@cs.ucla.edu>
27ccc379 5518
ca23cc88
PE
5519 Fix more problems found by GCC 4.6.0's static checks.
5520
f390e2d5
PE
5521 * xmenu.c (Fx_popup_dialog): Don't assume string is free of formats.
5522
42eea0d0
PE
5523 * menu.c (Fx_popup_menu): Don't assume error_name lacks printf formats.
5524
b69769da 5525 * lisp.h (message, message_nolog, fatal): Mark as printf-like.
1e973bc7 5526
f9541e84
PE
5527 * xdisp.c (vmessage): Mark as a printf-like function.
5528
13841b55
PE
5529 * term.c (vfatal, maybe_fatal): Mark as printf-like functions.
5530
c136c10f
PE
5531 * sound.c (sound_warning): Don't crash if arg contains a printf format.
5532
5e2d4a30
PE
5533 * image.c (tiff_error_handler, tiff_warning_handler): Mark as
5534 printf-like functions.
5535 (tiff_load): Add casts to remove these marks before passing them
5536 to system-supplied API.
5537
583f48b9
PE
5538 * eval.c (Fsignal): Remove excess argument to 'fatal'.
5539
b25d760e
PE
5540 * coding.c (EMIT_ONE_BYTE, EMIT_TWO_BYTES): Use unsigned, not int.
5541 This avoids several warnings with gcc -Wstrict-overflow.
d5efd1d1
PE
5542 (DECODE_COMPOSITION_RULE): If the rule is invalid, goto invalid_code
5543 directly, rather than having caller test rule sign. This avoids
5544 some unnecessary tests.
5545 * composite.h (COMPOSITION_ENCODE_RULE_VALID): New macro.
5546 (COMPOSITION_ENCODE_RULE): Arguments now must be valid. This
5547 affects only one use, in DECODE_COMPOSITION_RULE, which is changed.
b25d760e 5548
bc7b6697 5549 * xfont.c (xfont_text_extents): Remove var that was set but not used.
625a3eb1 5550 (xfont_open): Avoid unnecessary tests.
bc7b6697 5551
27ccc379
PE
5552 * composite.c (composition_gstring_put_cache): Use unsigned integer.
5553
dcd5c89a
PE
5554 * composite.h, composite.c (composition_gstring_put_cache):
5555 Use EMACS_INT, not int, for length.
5556
b13a45c6
PE
5557 * composite.h (COMPOSITION_DECODE_REFS): New macro,
5558 breaking out part of COMPOSITION_DECODE_RULE.
5559 (COMPOSITION_DECODE_RULE): Use it.
5560 * composite.c (get_composition_id): Remove unused local vars,
5561 by using the new macro.
5562
1e792e4d
PE
5563 * textprop.c (set_text_properties_1): Change while to do-while,
5564 since the condition is always true at first.
5565
dc6c6455 5566 * intervals.c (graft_intervals_into_buffer): Mark var as used.
aa86731f
PE
5567 (interval_deletion_adjustment): Return unsigned value.
5568 All uses changed.
dc6c6455 5569
aba7731a
PE
5570 * process.c (list_processes_1, create_pty, read_process_output):
5571 (exec_sentinel): Remove vars that were set but not used.
afd4052b 5572 (create_pty): Remove unnecessary "volatile"s.
bc57d757 5573 (Fnetwork_interface_info): Avoid possibility of int overflow.
82eaa333 5574 (read_process_output): Do adaptive read buffering even if carryover.
fe07cdfa 5575 (read_process_output): Simplify nbytes computation if buffered.
aba7731a 5576
fdfc4bf3
PE
5577 * bytecode.c (exec_byte_code): Rename local to avoid shadowing.
5578
fca8fe46 5579 * syntax.c (scan_words): Remove var that was set but not used.
12cbf13f 5580 (update_syntax_table): Use unsigned instead of int.
fca8fe46 5581
06a0259a 5582 * lread.c (lisp_file_lexically_bound_p): Use ints rather than endptrs.
3c346cc3 5583 (lisp_file_lexically_bound_p, read1): Use unsigned instead of int.
e6eb4e9e 5584 (safe_to_load_p): Make the end-of-loop test the inverse of the in-loop.
06a0259a 5585
e7b9e80f
PE
5586 * print.c (print_error_message): Avoid int overflow.
5587
56201685
PE
5588 * font.c (font_list_entities): Redo for clarity,
5589 so that reader need not know FONT_DPI_INDEX + 1 == FONT_SPACING_INDEX.
5590
78834453 5591 * font.c (font_find_for_lface, Ffont_get_glyphs): Remove unused vars.
790771b1 5592 (font_score): Avoid potential overflow in diff calculation.
78834453 5593
0bc0b309 5594 * fns.c (substring_both): Remove var that is set but not used.
8cd55cb4 5595 (sxhash): Redo loop for clarity and to avoid wraparound warning.
0bc0b309 5596
e610eaca
PE
5597 * eval.c (funcall_lambda): Rename local to avoid shadowing.
5598
b895abce
PE
5599 * alloc.c (mark_object_loop_halt, mark_object): Use size_t, not int.
5600 Otherwise, GCC 4.6.0 optimizes the loop check away since the check
5601 can always succeed if overflow has undefined behavior.
5602
1f1d9321 5603 * search.c (boyer_moore, wordify): Remove vars set but not used.
6f076cc7 5604 (wordify): Omit three unnecessary tests.
1f1d9321 5605
c59478bc
PE
5606 * indent.c (MULTIBYTE_BYTES_WIDTH): Don't compute wide_column.
5607 All callers changed. This avoids the need for an unused var.
5608
79b73827
PE
5609 * casefiddle.c (casify_region): Remove var that is set but not used.
5610
a4db5dfe
PE
5611 * dired.c (file_name_completion): Remove var that is set but not used.
5612
43aae36e
PE
5613 * fileio.c (Finsert_file_contents): Make EOF condition clearer.
5614
2a47c44d 5615 * fileio.c (Finsert_file_contents): Avoid signed integer overflow.
163c5f32 5616 (Finsert_file_contents): Remove unnecessary code checking fd.
2a47c44d 5617
a37c69bf
PE
5618 * minibuf.c (read_minibuf_noninteractive): Use size_t for sizes.
5619 Check for integer overflow on size calculations.
5620
328ab8e7
PE
5621 * buffer.c (Fprevious_overlay_change): Remove var that is set
5622 but not used.
5623
e5a2a5cb
PE
5624 * keyboard.c (menu_bar_items, read_char_minibuf_menu_prompt):
5625 Remove vars that are set but not used.
8d84a6eb 5626 (timer_check_2): Don't assume timer-list and idle-timer-list are lists.
6b043475 5627 (timer_check_2): Mark vars as initialized.
e5a2a5cb 5628
a60e5f68
PE
5629 * gtkutil.c (xg_get_file_with_chooser): Mark var as initialized.
5630
f661cb61 5631 * image.c (lookup_image): Remove var that is set but not used.
35fa624f 5632 (xbm_load): Use parse_p, for gcc -Werror=unused-but-set-variable.
f661cb61 5633
f0397f5a
PE
5634 * fontset.c (Finternal_char_font, Ffontset_info): Remove vars
5635 that are set but not used.
5636
8664db06 5637 * xfns.c (make_invisible_cursor): Don't return garbage
03733ee7 5638 if XCreateBitmapFromData fails (Bug#8410).
8664db06 5639
6abdaa4a
PE
5640 * xselect.c (x_get_local_selection, x_handle_property_notify):
5641 Remove vars that are set but not used.
5642
0ce7538d 5643 * xfns.c (x_create_tip_frame): Remove var that is set but not used.
6abdaa4a 5644 (make_invisible_cursor): Initialize a possibly-uninitialized variable.
0ce7538d 5645
9ae848fc
PE
5646 * xterm.c (x_scroll_bar_to_input_event) [!USE_GTK]:
5647 Remove var that is set but not used.
0b918413
PE
5648 (scroll_bar_windows_size): Now size_t, not int.
5649 (x_send_scroll_bar_event): Use size_t, not int, for sizes.
5650 Check for overflow.
9ae848fc 5651
a5a62657
PE
5652 * xfaces.c (realize_named_face): Remove vars that are set but not used.
5653 (map_tty_color) [!defined MSDOS]: Likewise.
5654
5c5cdd39
PE
5655 * term.c (tty_write_glyphs): Use size_t; this avoids overflow warning.
5656
66ebf983
PE
5657 * coding.c: Remove vars that are set but not used.
5658 (DECODE_COMPOSITION_RULE): Remove 2nd arg, which is unused.
5659 All callers changed.
5660 (decode_coding_utf_8, decode_coding_utf_16 decode_coding_emacs_mule):
5661 (decode_coding_iso_2022, encode_coding_sjis, encode_coding_big5):
5662 (decode_coding_charset): Remove vars that are set but not used.
5663
1be4d761
PE
5664 * bytecode.c (Fbyte_code) [!defined BYTE_CODE_SAFE]: Remove var
5665 that is set but not used.
5666
47553fa8
PE
5667 * print.c (print_object): Remove var that is set but not used.
5668
1f7196bf 5669 Replace 2 copies of readlink code with 1 gnulib version (Bug#8401).
d1fdcab7
PE
5670 The gnulib version avoids calling malloc in the usual case,
5671 and on 64-bit hosts doesn't have some arbitrary 32-bit limits.
5672 * fileio.c (Ffile_symlink_p): Use emacs_readlink.
5673 * filelock.c (current_lock_owner): Likewise.
5674 * lisp.h (READLINK_BUFSIZE, emacs_readlink): New function.
5675 * sysdep.c: Include allocator.h, careadlinkat.h.
5676 (emacs_no_realloc_allocator): New static constant.
5677 (emacs_readlink): New function.
fdb61804
PE
5678 * deps.mk (sysdep.o): Depend on ../lib/allocator.h and on
5679 ../lib/careadlinkat.h.
d1fdcab7 5680
f84c17c7
SM
56812011-04-04 Stefan Monnier <monnier@iro.umontreal.ca>
5682
5683 * keyboard.c (safe_run_hook_funcall): Fix last change (don't stop at the
5684 first non-nil return value).
5685
ef3862ad
JD
56862011-04-03 Jan Djärv <jan.h.d@swipnet.se>
5687
5688 * nsterm.m (ns_update_auto_hide_menu_bar): Define MAC_OS_X_VERSION_10_6
5689 if not defined (Bug#8403).
5690
376a7006
JB
56912011-04-02 Juanma Barranquero <lekktu@gmail.com>
5692
5693 * xdisp.c (display_count_lines): Remove parameter `start',
5694 unused since 1998-01-01T02:27:27Z!rms@gnu.org. All callers changed.
5695 (get_char_face_and_encoding): Remove parameter `multibyte_p',
5696 unused since 2008-05-14T01:40:23Z!handa@m17n.org. All callers changed.
5697 (fill_stretch_glyph_string): Remove parameters `row' and `area',
5698 unused at least since Kim's GUI unification at 2003-03-16T20:45:46Z!storm@cua.dk
5699 and thereabouts. All callers changed.
5700 (get_per_char_metric): Remove parameter `f', unused since
5701 2008-05-14T01:40:23Z!handa@m17n.org. All callers changed.
5702
6ca3801d
JM
57032011-04-02 Jim Meyering <meyering@redhat.com>
5704
5705 do not dereference NULL upon failed strdup
5706 * nsfont.m (ns_descriptor_to_entity): Use xstrdup, not strdup.
5707 (ns_get_family): Likewise.
5708
d8e2b5ba
JB
57092011-04-02 Juanma Barranquero <lekktu@gmail.com>
5710
5711 * eval.c (unwind_to_catch) [DEBUG_GCPRO]: Remove redundant assignment.
5712
8c74fcbd
JD
57132011-04-02 Jan Djärv <jan.h.d@swipnet.se>
5714
5715 * nsterm.m (ns_update_auto_hide_menu_bar): Only for OSX 10.6 or
5716 later (Bug#8403).
5717
7200d79c
SM
57182011-04-01 Stefan Monnier <monnier@iro.umontreal.ca>
5719
03408648 5720 Add lexical binding.
7200d79c 5721
03408648
SM
5722 * window.c (Ftemp_output_buffer_show): New fun.
5723 (Fsave_window_excursion):
5724 * print.c (Fwith_output_to_temp_buffer): Move to subr.el.
5725
5726 * lread.c (lisp_file_lexically_bound_p): New function.
5727 (Fload): Bind Qlexical_binding.
5728 (readevalloop): Remove `evalfun' arg.
5729 Bind Qinternal_interpreter_environment.
5730 (Feval_buffer): Bind Qlexical_binding.
5731 (defvar_int, defvar_bool, defvar_lisp_nopro, defvar_kboard):
5732 Mark as dynamic.
5733 (syms_of_lread): Declare `lexical-binding'.
5734
5735 * lisp.h (struct Lisp_Symbol): New field `declared_special'.
5736
5737 * keyboard.c (eval_dyn): New fun.
5738 (menu_item_eval_property): Use it.
ca105506
SM
5739
5740 * image.c (parse_image_spec): Use Ffunctionp.
ca105506 5741
03408648
SM
5742 * fns.c (concat, mapcar1): Accept byte-code-functions.
5743
5744 * eval.c (Fsetq): Handle lexical vars.
5745 (Fdefun, Fdefmacro, Ffunction): Make closures when needed.
5746 (Fdefconst, Fdefvaralias, Fdefvar): Mark as dynamic.
5747 (FletX, Flet): Obey lexical binding.
5748 (Fcommandp): Handle closures.
5749 (Feval): New `lexical' arg.
5750 (eval_sub): New function extracted from Feval. Use it almost
5751 everywhere where Feval was used. Look up vars in lexical env.
5752 Handle closures.
5753 (Ffunctionp): Move from subr.el.
5754 (Ffuncall): Handle closures.
5755 (apply_lambda): Remove `eval_flags'.
5756 (funcall_lambda): Handle closures and new byte-code-functions.
5757 (Fspecial_variable_p): New function.
5758 (syms_of_eval): Initialize the Vinternal_interpreter_environment var,
5759 but without exporting it to Lisp.
23aba0ea 5760
23aba0ea 5761 * doc.c (Fdocumentation, store_function_docstring):
03408648 5762 * data.c (Finteractive_form): Handle closures.
23aba0ea 5763
03408648
SM
5764 * callint.c (Fcall_interactively): Preserve lexical-binding mode for
5765 interactive spec.
ba83908c 5766
04f2d78b
CB
5767 * bytecode.c (Bstack_ref, Bstack_set, Bstack_set2, BdiscardN):
5768 New byte-codes.
03408648
SM
5769 (exec_byte_code): New function extracted from Fbyte_code to handle new
5770 calling convention for byte-code-functions. Add new byte-codes.
ba83908c 5771
03408648 5772 * buffer.c (defvar_per_buffer): Set new `declared_special' field.
e2abe5a1 5773
03408648 5774 * alloc.c (Fmake_symbol): Init new `declared_special' field.
e2abe5a1 5775
e2abce01
JB
57762011-03-31 Juanma Barranquero <lekktu@gmail.com>
5777
5778 * xdisp.c (redisplay_internal): Fix prototype.
5779
63696a73 57802011-03-31 Eli Zaretskii <eliz@gnu.org>
09725d26 5781
63696a73 5782 * xdisp.c (SCROLL_LIMIT): New macro.
04f2d78b
CB
5783 (try_scrolling): Use it when setting scroll_limit.
5784 Limit scrolling to 100 screen lines.
63696a73
EZ
5785 (redisplay_window): Even when falling back on "recentering",
5786 position point in the window according to scroll-conservatively,
5787 scroll-margin, and scroll-*-aggressively variables. (Bug#6671)
5788
5789 (try_scrolling): When point is above the window, allow searching
5790 as far as scroll_max, or one screenful, to compute vertical
5791 distance from PT to the scroll margin position. This prevents
5792 try_scrolling from unnecessarily failing when
5793 scroll-conservatively is set to a value slightly larger than the
5794 window height. Clean up the case of PT below the margin at bottom
5795 of window: scroll_max can no longer be INT_MAX. When aggressive
5796 scrolling is in use, don't let point enter the opposite scroll
5797 margin as result of the scroll.
5798 (syms_of_xdisp) <scroll-conservatively>: Document the
09725d26
EZ
5799 threshold of 100 lines for never-recentering scrolling.
5800
e4cc2dfc
JB
58012011-03-31 Juanma Barranquero <lekktu@gmail.com>
5802
5803 * dispextern.h (move_it_by_lines):
5804 * xdisp.c (move_it_by_lines): Remove parameter `need_y_p', unused
5805 since 2000-12-29T14:24:09Z!gerd@gnu.org. All callers changed.
5806 (message_log_check_duplicate): Remove parameters `prev_bol' and
5807 `this_bol', unused since 1998-01-01T02:27:27Z!rms@gnu.org. All callers changed.
5808 (redisplay_internal): Remove parameter `preserve_echo_area',
5809 unused since 1999-07-21T21:43:52Z!gerd@gnu.org. All callers changed.
5810
5811 * indent.c (Fvertical_motion):
5812 * window.c (window_scroll_pixel_based, Frecenter):
5813 Don't pass `need_y_p' to `move_it_by_lines'.
5814
1c470562
SM
58152011-03-30 Stefan Monnier <monnier@iro.umontreal.ca>
5816
44f230aa
SM
5817 * eval.c (struct backtrace): Don't cheat with negative numbers, but do
5818 steal a few bits to be more compact.
5819 (interactive_p, Fbacktrace, Fbacktrace_frame, mark_backtrace):
5820 Remove unneeded casts.
5821
1c470562
SM
5822 * bytecode.c (Fbyte_code): CAR and CDR can GC.
5823
888adce9
ZK
58242011-03-30 Zachary Kanfer <zkanfer@gmail.com> (tiny change)
5825
5826 * keyboard.c (Fexecute_extended_command): Do log the "suggest key
5827 binding" message (bug#7967).
5828
f838ed7b
PE
58292011-03-30 Paul Eggert <eggert@cs.ucla.edu>
5830
77861b95
PE
5831 Fix more problems found by GCC 4.6.0's static checks.
5832
de6dbc14
PE
5833 * unexelf.c (unexec) [! (defined _SYSTYPE_SYSV || defined __sgi)]:
5834 Remove unused local var.
5835
f838ed7b
PE
5836 * editfns.c (Fmessage_box): Remove unused local var.
5837
792c7b2b
PE
5838 * xdisp.c (try_window_reusing_current_matrix, x_produce_glyphs):
5839 (note_mode_line_or_margin_highlight, note_mouse_highlight):
5840 Omit unused local vars.
c499e557 5841 * window.c (shrink_windows): Omit unused local var.
b01a1c29 5842 * menu.c (digest_single_submenu): Omit unused local var.
0bc32927
PE
5843 * dispnew.c (update_window) [PERIODIC_PREEMPTION_CHECKING]:
5844 Omit unused local var.
5845
ba0165e1
PE
5846 * keyboard.c (parse_modifiers_uncached, parse_modifiers):
5847 Don't assume string length fits in int.
32ad8845 5848 (keyremap_step, read_key_sequence): Use size_t for sizes.
48011560 5849 (read_key_sequence): Don't check last_real_key_start redundantly.
ba0165e1 5850
3c59b4c9
PE
5851 * callproc.c (Fcall_process, Fcall_process_region): Use SAFE_ALLOCA
5852 instead of alloca (Bug#8344).
5853
a3eed478 5854 * eval.c (Fbacktrace): Don't assume nargs fits in int.
5d5d959d 5855 (Fbacktrace_frame): Don't assume nframes fits in int.
a3eed478 5856
eb4d412d
PE
5857 * syntax.c (scan_sexps_forward): Avoid pointer wraparound.
5858
1658b401
PE
5859 * xterm.c (x_make_frame_visible, same_x_server): Redo to avoid overflow
5860 concerns.
5861
5862 * term.c (produce_glyphless_glyph): Remove unnecessary test.
5863
5864 * cm.c (calccost): Turn while-do into do-while, for clarity.
44f730c8 5865
9a2c6e05
PE
5866 * keyboard.c (syms_of_keyboard): Use the same style as later
5867 in this function when indexing through an array. This also
5868 works around GCC bug 48267.
5869
03d0a109
PE
5870 * image.c (tiff_load): Fix off-by-one image count (Bug#8336).
5871
44f730c8
PE
5872 * xselect.c (x_check_property_data): Return correct size (Bug#8335).
5873
fe75f926
PE
5874 * chartab.c (sub_char_table_ref_and_range): Redo for slight
5875 efficiency gain, and to bypass a gcc -Wstrict-overflow warning.
5876
ffa8c828
PE
5877 * keyboard.c, keyboard.h (num_input_events): Now size_t.
5878 This avoids undefined behavior on integer overflow, and is a bit
5879 more convenient anyway since it is compared to a size_t variable.
5880
c5101a77
PE
5881 Variadic C functions now count arguments with size_t, not int.
5882 This avoids an unnecessary limitation on 64-bit machines, which
5883 caused (substring ...) to crash on large vectors (Bug#8344).
5884 * lisp.h (struct Lisp_Subr.function.aMANY): Now takes size_t, not int.
5885 (DEFUN_ARGS_MANY, internal_condition_case_n, safe_call): Likewise.
77861b95 5886 All variadic functions and their callers changed accordingly.
c5101a77
PE
5887 (struct gcpro.nvars): Now size_t, not int. All uses changed.
5888 * data.c (arith_driver, float_arith_driver): Likewise.
5889 * editfns.c (general_insert_function): Likewise.
5890 * eval.c (struct backtrace.nargs, interactive_p)
5891 (internal_condition_case_n, run_hook_with_args, apply_lambda)
5892 (funcall_lambda, mark_backtrace): Likewise.
5893 * fns.c (concat): Likewise.
5894 * frame.c (x_set_frame_parameters): Likewise.
5895 * fns.c (get_key_arg): Now accepts and returns size_t, and returns
5896 0 if not found, not -1. All callers changed.
5897
dd3f25f7
PE
5898 * alloc.c (garbage_collect): Don't assume stack size fits in int.
5899 (stack_copy_size): Now size_t, not int.
5900 (stack_copy, stack_copy_size): Define only if MAX_SAVE_STACK > 0.
5901
461c2ab9
JB
59022011-03-28 Juanma Barranquero <lekktu@gmail.com>
5903
5904 * coding.c (encode_designation_at_bol): Remove parameter `charbuf_end',
5905 unused since 2002-03-01T01:17:24Z!handa@m17n.org and 2008-02-01T16:01:31Z!miles@gnu.org.
5906 All callers changed.
5907
5908 * lisp.h (multibyte_char_to_unibyte):
5909 * character.c (multibyte_char_to_unibyte): Remove parameter `rev_tbl',
5910 unused since 2002-03-01T01:16:34Z!handa@m17n.org and 2008-02-01T16:01:31Z!miles@gnu.org.
5911 * character.h (CHAR_TO_BYTE8):
5912 * cmds.c (internal_self_insert):
5913 * editfns.c (general_insert_function):
5914 * keymap.c (push_key_description):
5915 * search.c (Freplace_match):
5916 * xdisp.c (message_dolog, set_message_1): All callers changed.
5917
f6d62986
SM
59182011-03-28 Stefan Monnier <monnier@iro.umontreal.ca>
5919
5920 * keyboard.c (safe_run_hook_funcall): New function.
5921 (safe_run_hooks_1, safe_run_hooks_error, safe_run_hooks): On error,
5922 don't set the hook to nil, but remove the offending function instead.
5923 (Qcommand_hook_internal): Remove, unused.
5924 (syms_of_keyboard): Don't initialize Qcommand_hook_internal nor define
5925 Vcommand_hook_internal.
5926
5927 * eval.c (enum run_hooks_condition): Remove.
5928 (funcall_nil, funcall_not): New functions.
5929 (run_hook_with_args): Call each function through a `funcall' argument.
5930 Remove `cond' argument, now redundant.
5931 (Frun_hooks, Frun_hook_with_args, Frun_hook_with_args_until_success)
5932 (Frun_hook_with_args_until_failure): Adjust accordingly.
5933 (run_hook_wrapped_funcall, Frun_hook_wrapped): New functions.
5934
1db5b1ad
JB
59352011-03-28 Juanma Barranquero <lekktu@gmail.com>
5936
5937 * dispextern.h (string_buffer_position): Remove declaration.
5938
5939 * print.c (strout): Remove parameter `multibyte', unused since
5940 1999-08-21T19:30:21Z!gerd@gnu.org. All callers changed.
5941
5942 * search.c (boyer_moore): Remove parameters `len', `pos' and `lim',
5943 never used since function introduction in 1998-02-08T21:33:56Z!rms@gnu.org.
5944 All callers changed.
5945
5946 * w32.c (_wsa_errlist): Use braces for struct initializers.
5947
5948 * xdisp.c (string_buffer_position_lim): Remove parameter `w',
5949 never used since function introduction in 2001-03-09T18:41:50Z!gerd@gnu.org.
5950 All callers changed.
5951 (string_buffer_position): Likewise. Also, make static (it's never
5952 used outside xdisp.c).
5953 (cursor_row_p): Remove parameter `w', unused since
5954 2000-10-17T16:08:57Z!gerd@gnu.org. All callers changed.
5955 (decode_mode_spec): Remove parameter `precision', introduced during
5956 Gerd Moellmann's rewrite at 1999-07-21T21:43:52Z!gerd@gnu.org, but never used.
5957 All callers changed.
5958
5ffb62aa
JD
59592011-03-27 Jan Djärv <jan.h.d@swipnet.se>
5960
5961 * nsterm.m (syms_of_nsterm): Use doc: for ns-auto-hide-menu-bar.
5962
461c2ab9 59632011-03-27 Anders Lindgren <andlind@gmail.com>
f0a1382a
JD
5964
5965 * nsterm.m (ns_menu_bar_is_hidden): New variable.
5966 (ns_constrain_all_frames, ns_menu_bar_should_be_hidden)
5967 (ns_update_auto_hide_menu_bar): New functions.
5968 (ns_update_begin): Call ns_update_auto_hide_menu_bar.
5969 (applicationDidBecomeActive): Call ns_update_auto_hide_menu_bar and
5970 ns_constrain_all_frames.
5971 (constrainFrameRect): Return at once if ns_menu_bar_should_be_hidden.
5972 (syms_of_nsterm): DEFVAR ns-auto-hide-menu-bar, init to Qnil.
5973
5c380ffb
JD
59742011-03-27 Jan Djärv <jan.h.d@swipnet.se>
5975
5976 * nsmenu.m (runDialogAt): Remove argument to timer_check.
5977
9af30bdf
GM
59782011-03-27 Glenn Morris <rgm@gnu.org>
5979
5980 * syssignal.h: Replace RETSIGTYPE with void.
5981 * atimer.c, data.c, dispnew.c, emacs.c, floatfns.c, keyboard.c:
5982 * keyboard.h, lisp.h, process.c, sysdep.c, xterm.c:
5983 Replace SIGTYPE with void everywhere.
5984 * s/usg5-4-common.h (SIGTYPE): Remove definition.
5985 * s/template.h (SIGTYPE): Remove commented out definition.
5986
e2abce01
JB
59872011-03-26 Eli Zaretskii <eliz@gnu.org>
5988
5989 * xdisp.c (redisplay_window): Don't check buffer's clip_changed
5990 flag as a prerequisite for invoking try_scrolling. (Bug#6671)
5991
f868cd8a
JB
59922011-03-26 Juanma Barranquero <lekktu@gmail.com>
5993
59eb0929
JB
5994 * w32.c (read_unc_volume): Use parameter `henum', instead of
5995 global variable `wget_enum_handle'.
5996
5997 * keymap.c (describe_vector): Remove parameters `indices' and
5998 `char_table_depth', unused since 2002-03-01T01:43:26Z!handa@m17n.org.
5999 (describe_map, Fdescribe_vector): Adjust calls to `describe_vector'.
6000
f868cd8a
JB
6001 * keyboard.h (timer_check, show_help_echo): Remove unused parameters.
6002
6003 * keyboard.c (timer_check): Remove parameter `do_it_now',
6004 unused since 1996-04-12T06:01:29Z!rms@gnu.org.
6005 (show_help_echo): Remove parameter `ok_to_overwrite_keystroke_echo',
6006 unused since 2008-04-19T19:30:53Z!monnier@iro.umontreal.ca.
6007
6008 * keyboard.c (read_char):
6009 * w32menu.c (w32_menu_display_help):
6010 * xmenu.c (show_help_event, menu_help_callback):
6011 Adjust calls to `show_help_echo'.
6012
6013 * gtkutil.c (xg_maybe_add_timer):
6014 * keyboard.c (readable_events):
6015 * process.c (wait_reading_process_output):
6016 * xmenu.c (x_menu_wait_for_event): Adjust calls to `timer_check'.
6017
6018 * insdel.c (adjust_markers_gap_motion):
6019 Remove; no-op since 1998-01-02T21:29:48Z!rms@gnu.org.
6020 (gap_left, gap_right): Don't call it.
6021
2ecf6fdb
CY
60222011-03-25 Chong Yidong <cyd@stupidchicken.com>
6023
6024 * xdisp.c (handle_fontified_prop): Discard changes to clip_changed
6025 incurred during fontification.
6026
6b1f9ba4
JB
60272011-03-25 Juanma Barranquero <lekktu@gmail.com>
6028
6029 * buffer.c (defvar_per_buffer): Remove unused parameter `doc'.
6030 (DEFVAR_PER_BUFFER): Don't pass it.
6031
6032 * dispnew.c (row_equal_p, add_row_entry): Remove unused parameter `w'.
6033 (scrolling_window): Don't pass it.
6034
0f4a96b5
JB
60352011-03-25 Juanma Barranquero <lekktu@gmail.com>
6036
6037 * dispextern.h (glyph_matric): Use #if GLYPH_DEBUG, not #ifdef.
6038
6039 * fileio.c (check_executable) [DOS_NT]: Remove unused variables `len'
6040 and `suffix'.
6041 (Fset_file_selinux_context) [HAVE_LIBSELINUX]: Move here declaration
6042 of variables specific to SELinux and computation of `encoded_absname'.
6043
6044 * image.c (XPutPixel): Remove unused variable `height'.
6045
6046 * keyboard.c (make_lispy_event): Remove unused variable `hpos'.
6047
6048 * unexw32.c (get_section_info): Remove unused variable `section'.
6049
6050 * w32.c (stat): Remove unused variables `drive_root' and `devtype'.
6051 (system_process_attributes): Remove unused variable `sess'.
6052 (sys_read): Remove unused variable `err'.
6053
6054 * w32fns.c (top): Wrap variables with #if GLYPH_DEBUG, not #ifdef.
6055 (w32_wnd_proc): Remove unused variable `isdead'.
6056 (unwind_create_frame): Use #if GLYPH_DEBUG, not #ifdef.
6057 (Fx_server_max_request_size): Remove unused variable `dpyinfo'.
6058 (x_create_tip_frame): Remove unused variable `tem'.
6059
6060 * w32inevt.c (w32_console_read_socket):
6061 Remove unused variable `no_events'.
6062
6063 * w32term.c (x_draw_composite_glyph_string_foreground):
6064 Remove unused variable `width'.
6065
1149507c
JB
60662011-03-24 Juanma Barranquero <lekktu@gmail.com>
6067
6068 * w32term.c (x_set_glyph_string_clipping):
6069 Don't pass uninitialized region to CombineRgn.
6070
9c88f339
JB
60712011-03-23 Juanma Barranquero <lekktu@gmail.com>
6072
6073 * w32fns.c (x_set_menu_bar_lines): Remove unused variable `olines'.
6074 (w32_wnd_proc): Pass NULL to Windows API, not uninitialized buffer.
6075 (Fx_close_connection): Remove unused variable `i'.
6076
6077 * w32font.c (w32font_draw): Return number of glyphs.
6078 (w32font_open_internal): Remove unused variable `i'.
6079 (w32font_driver): Add missing initializer.
6080
6081 * w32menu.c (utf8to16): Remove unused variable `utf16'.
6082 (fill_in_menu): Remove unused variable `items_added'.
6083
6084 * w32term.c (last_mouse_press_frame): Remove static global variable.
6085 (w32_clip_to_row): Remove unused variable `f'.
6086 (x_delete_terminal): Remove unused variable `i'.
6087
6088 * w32uniscribe.c (uniscribe_shape): Remove unused variable `nclusters'.
6089 (NOTHING): Remove unused static global variable.
6090 (uniscribe_check_otf): Remove unused variable `table'.
6091 (uniscribe_font_driver): Add missing initializers.
6092
dee091a3
JD
60932011-03-23 Julien Danjou <julien@danjou.info>
6094
6095 * term.c (Fsuspend_tty, Fresume_tty):
6096 * minibuf.c (read_minibuf, run_exit_minibuf_hook):
6097 * window.c (temp_output_buffer_show):
6098 * insdel.c (signal_before_change):
6099 * frame.c (Fhandle_switch_frame):
6100 * fileio.c (Fdo_auto_save):
6101 * emacs.c (Fkill_emacs):
6102 * editfns.c (save_excursion_restore):
6103 * cmds.c (internal_self_insert):
6104 * callint.c (Fcall_interactively):
6105 * buffer.c (Fkill_all_local_variables):
6106 * keyboard.c (Fcommand_execute, Fsuspend_emacs, safe_run_hooks_1):
6107 Use Frun_hooks.
0f4a96b5 6108 (command_loop_1): Use Frun_hooks. Call safe_run_hooks
dee091a3
JD
6109 unconditionnaly since it does the check itself.
6110
2c520ab5 61112011-03-23 Paul Eggert <eggert@cs.ucla.edu>
f0641eff 6112
c9c49752
PE
6113 Fix more problems found by GCC 4.5.2's static checks.
6114
8abc3f12
PE
6115 * coding.c (encode_coding_raw_text): Avoid unnecessary test
6116 the first time through the loop, since we know p0 < p1 then.
6117 This also avoids a gcc -Wstrict-overflow warning.
6118
a2d26660
PE
6119 * lisp.h (SAFE_ALLOCA, SAFE_ALLOCA_LISP): Avoid 'int' overflow
6120 leading to a memory leak, possible in functions like
6121 load_charset_map_from_file that can allocate an unbounded number
b12ef411 6122 of objects (Bug#8318).
a2d26660 6123
916c72e9
PE
6124 * xmenu.c (set_frame_menubar): Use EMACS_UINT, not int, for indexes
6125 that could (at least in theory) be that large.
6126
19ab8a18
PE
6127 * xdisp.c (message_log_check_duplicate): Return unsigned long, not int.
6128 This is less likely to overflow, and avoids undefined behavior if
6129 overflow does occur. All callers changed. Use strtoul to scan
6130 for the unsigned long integer.
b7cbbd6f
PE
6131 (pint2hrstr): Simplify and tune code slightly.
6132 This also avoids a (bogus) GCC warning with gcc -Wstrict-overflow.
19ab8a18 6133
f0641eff
PE
6134 * scroll.c (do_scrolling): Work around GCC bug 48228.
6135 See <http://gcc.gnu.org/bugzilla/show_bug.cgi?id=48228>.
6136
7f650bb9
PE
6137 * frame.c (Fmodify_frame_parameters): Simplify loop counter.
6138 This also avoids a warning with gcc -Wstrict-overflow.
39f5e519
PE
6139 (validate_x_resource_name): Simplify count usage.
6140 This also avoids a warning with gcc -Wstrict-overflow.
7f650bb9 6141
37dd57d1
PE
6142 * fileio.c (Fcopy_file): Report error if fchown or fchmod
6143 fail (Bug#8306).
81e56e61 6144
699979fc 6145 * emacs.c (Fdaemon_initialized): Do not ignore I/O errors (Bug#8303).
dc1ca6a8 6146
401bf9b4
PE
6147 * process.c (Fmake_network_process): Use socklen_t, not int,
6148 where POSIX says socklen_t is required in portable programs.
6149 This fixes a porting bug on hosts like 64-bit HP-UX, where
591b2973 6150 socklen_t is wider than int (Bug#8277).
401bf9b4
PE
6151 (Fmake_network_process, server_accept_connection):
6152 (wait_reading_process_output, read_process_output):
6153 Likewise.
6154
b93aacde
PE
6155 * process.c: Rename or move locals to avoid shadowing.
6156 (list_processes_1, Fmake_network_process):
6157 (read_process_output_error_handler, exec_sentinel_error_handler):
6158 Rename or move locals.
4dc343ee 6159 (Fmake_network_process): Define label "retry_connect" only if needed.
0da49335 6160 (Fnetwork_interface_info): Fix pointer signedness.
f990b4e5 6161 (process_send_signal): Add cast to avoid pointer signedness problem.
7b808126 6162 (FIRST_PROC_DESC, IF_NON_BLOCKING_CONNECT): Remove unused macros.
c939f91b 6163 (create_process): Use 'volatile' to avoid vfork clobbering (Bug#8298).
b93aacde 6164
af8a867c 6165 Make tparam.h and terminfo.c consistent.
44f230aa
SM
6166 * cm.c (tputs, tgoto, BC, UP): Remove extern decls.
6167 Include tparam.h instead, since it declares them.
af8a867c
PE
6168 * cm.h (PC): Remove extern decl; tparam.h now does this.
6169 * deps.mk (cm.o, terminfo.o): Depend on tparam.h.
6170 * terminfo.c: Include tparam.h, to check interfaces.
6171 (tparm): Make 1st arg a const pointer in decl. Put it at top level.
6172 (tparam): Adjust signature to match interface in tparam.h;
6173 this removes some undefined behavior. Check that outstring and len
6174 are zero, which they always are with Emacs.
6175 * tparam.h (PC, BC, UP): New extern decls.
6176
0248044d 6177 * xftfont.c (xftfont_shape): Now static, and defined only if needed.
001a7ab4 6178 (xftfont_open): Rename locals to avoid shadowing.
0248044d 6179
8ff096c1 6180 * ftfont.c (ftfont_resolve_generic_family): Fix pointer signedness.
a00924bb
PE
6181 (ftfont_otf_capability, ftfont_shape): Omit decls if not needed.
6182 (OTF_TAG_SYM): Omit macro if not needed.
e932860f 6183 (ftfont_list): Remove unused local.
49eaafba
PE
6184 (get_adstyle_property, ftfont_pattern_entity):
6185 (ftfont_lookup_cache, ftfont_open, ftfont_anchor_point):
6186 Rename locals to avoid shadowing.
8ff096c1 6187
e2be39f6
PE
6188 * xfont.c (xfont_list_family): Mark var as initialized.
6189
c9735e30
PE
6190 * xml.c (make_dom): Now static.
6191
8f5201ae
PE
6192 * composite.c (composition_compute_stop_pos): Rename local to
6193 avoid shadowing.
b246f932
PE
6194 (composition_reseat_it): Remove unused locals.
6195 (find_automatic_composition, composition_adjust_point): Likewise.
80e079b2 6196 (composition_update_it): Mark var as initialized.
11b61122
PE
6197 (find_automatic_composition): Mark vars as initialized,
6198 with a FIXME (Bug#8290).
8f5201ae 6199
760fbc2c
PE
6200 character.h: Rename locals to avoid shadowing.
6201 * character.h (PREV_CHAR_BOUNDARY, FETCH_STRING_CHAR_ADVANCE):
6202 (FETCH_STRING_CHAR_AS_MULTIBYTE_ADVANCE, FETCH_CHAR_ADVANCE):
6203 (FETCH_CHAR_ADVANCE_NO_CHECK, INC_POS, DEC_POS, BUF_INC_POS):
6204 (BUF_DEC_POS): Be more systematic about renaming local temporaries
6205 to avoid shadowing.
6206
ff08eb85
PE
6207 * textprop.c (property_change_between_p): Remove; unused.
6208
fc7bf025
PE
6209 * intervals.c (interval_start_pos): Now static.
6210
235d7abc
PE
6211 * intervals.h (CHECK_TOTAL_LENGTH): Avoid empty "else".
6212
44f230aa
SM
6213 * atimer.c (start_atimer, append_atimer_lists, set_alarm):
6214 Rename locals to avoid shadowing.
3e7d6594 6215
50060332
PE
6216 * sound.c (wav_play, au_play, Fplay_sound_internal):
6217 Fix pointer signedness.
d01f234b 6218 (alsa_choose_format): Remove unused local var.
c83b8872
PE
6219 (wav_play): Initialize a variable to 0, to prevent undefined
6220 behavior (Bug#8278).
50060332 6221
c4fc4e30
PE
6222 * region-cache.c (insert_cache_boundary): Redo var to avoid shadowing.
6223
918436ed
PE
6224 * region-cache.h (pp_cache): New decl, for gcc -Wmissing-prototypes.
6225
c939f91b
PE
6226 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork
6227 clobbering (Bug#8298).
b9c7f648
PE
6228 * sysdep.c (sys_subshell): Likewise.
6229 Previously, the sys_subshell 'volatile' was incorrectly IF_LINTted out.
7e9123a2 6230
6bd8c144
PE
6231 * lisp.h (child_setup): Now NO_RETURN unless DOS_NT.
6232 This should get cleaned up, so that child_setup has the
6233 same signature on all platforms.
6234
7710357c 6235 * callproc.c (call_process_cleanup): Now static.
cb1d0ef7 6236 (relocate_fd): Rename locals to avoid shadowing.
7710357c 6237
c59da222
CY
62382011-03-22 Chong Yidong <cyd@stupidchicken.com>
6239
6240 * xterm.c (x_clear_frame): Remove XClearWindow call. This appears
6241 not to be necessary, and produces flickering.
6242
66b87493
GM
62432011-03-20 Glenn Morris <rgm@gnu.org>
6244
6245 * config.in: Remove file.
6246
45b6f6d5
JB
62472011-03-20 Juanma Barranquero <lekktu@gmail.com>
6248
6249 * minibuf.c (Vcompleting_read_function): Don't declare, global variables
6250 are now in src/globals.h.
6251 (syms_of_minibuf): Remove spurious & from previous change.
6252
3ec03f7e
LL
62532011-03-20 Leo <sdl.web@gmail.com>
6254
6255 * minibuf.c (completing-read-function): New variable.
6256 (completing-read-default): Rename from completing-read.
6257 (completing-read): Call completing-read-function.
6258
b14e3e21
CY
62592011-03-19 Juanma Barranquero <lekktu@gmail.com>
6260
6261 * xfaces.c (Fx_load_color_file):
6262 Read color file from absolute filename (bug#8250).
6263
f2b726e6
JB
62642011-03-19 Juanma Barranquero <lekktu@gmail.com>
6265
6266 * makefile.w32-in: Update dependencies.
6267
09f6ff02
EZ
62682011-03-17 Eli Zaretskii <eliz@gnu.org>
6269
6270 * makefile.w32-in ($(BLD)/unexw32.$(O)): Depend on $(SRC)/unexec.h.
6271
29a6015a
PE
62722011-03-17 Paul Eggert <eggert@cs.ucla.edu>
6273
a3a6c54e
PE
6274 Fix more problems found by GCC 4.5.2's static checks.
6275
b766f867
PE
6276 * process.c (make_serial_process_unwind, send_process_trap):
6277 (sigchld_handler): Now static.
6278
be02381c
PE
6279 * process.c (allocate_pty): Let PTY_ITERATION declare iteration vars.
6280 That way, the code declares only the vars that it needs.
6281 * s/aix4-2.h (PTY_ITERATION): Declare iteration vars.
6282 * s/cygwin.h (PTY_ITERATION): Likewise.
6283 * s/darwin.h (PTY_ITERATION): Likewise.
6284 * s/gnu-linux.h (PTY_ITERATION): Likewise.
6285
57048744
PE
6286 * s/irix6-5.h (PTY_OPEN): Declare stb, to loosen coupling.
6287 * process.c (allocate_pty): Don't declare stb unless it's needed.
6288
7914961c 6289 * bytecode.c (MAYBE_GC): Rewrite so as not to use empty "else".
615f2d59
PE
6290 (CONSTANTLIM): Remove; unused.
6291 (METER_CODE, Bscan_buffer, Bread_char, Bset_mark):
6292 Define only if needed.
7914961c 6293
b3967b18
PE
6294 * unexelf.c (unexec): Name an expression,
6295 to avoid gcc -Wbad-function-cast warning.
9ae71512
PE
6296 Use a different way to cause a compilation error if anyone uses
6297 n rather than nn, a way that does not involve shadowing.
73366a00 6298 (ELF_BSS_SECTION_NAME, OLD_PROGRAM_H): Remove; unused.
b3967b18 6299
29a6015a
PE
6300 * deps.mk (unexalpha.o): Remove; unused.
6301
43cfc33e 6302 New file unexec.h, the (simple) interface for unexec (Bug#8267).
7feda0d2 6303 * unexec.h: New file.
ce701a33
PE
6304 * deps.mk (emacs.o, unexaix.o, unexcw.o, unexcoff.o, unexelf.o):
6305 (unexhp9k800.o, unexmacosx.o, unexsol.o, unexw32.o):
6306 Depend on unexec.h.
6307 * emacs.c [!defined CANNOT_DUMP]: Include unexec.h.
6308 * unexaix.c, unexcoff.c, unexcw.c, unexelf.c, unexhp9k800.c:
6309 * unexmacosx.c, unexsol.c, unexw32.c: Include unexec.h.
381259ef 6310 Change as necessary to match prototype in unexec.h.
ce701a33 6311
01f44d5a
PE
6312 * syntax.c (Fforward_comment, scan_lists): Rename locals to avoid
6313 shadowing.
4f63c6bb 6314 (back_comment, skip_chars): Mark vars as initialized.
01f44d5a 6315
a6670b0b
PE
6316 * character.h (FETCH_STRING_CHAR_ADVANCE_NO_CHECK, BUF_INC_POS):
6317 Rename locals to avoid shadowing.
6318
cef2010d 6319 * lread.c (read1): Rewrite so as not to use empty "else".
0902fe45 6320 (Fload, readevalloop, read1): Rename locals to avoid shadowing.
cef2010d 6321
d4d7173a
PE
6322 * print.c (Fredirect_debugging_output): Fix pointer signedess.
6323
f08b802a
PE
6324 * lisp.h (debug_output_compilation_hack): Add decl here, to avoid
6325 warning when compiling print.c.
6326
3ddb0639
PE
6327 * font.c (font_unparse_fcname): Abort in an "impossible" situation
6328 instead of using an uninitialized var.
5ad03b97 6329 (font_sort_entities): Mark var as initialized.
3ddb0639 6330
170a2692
PE
6331 * character.h (FETCH_CHAR_ADVANCE): Rename locals to avoid shadowing.
6332
e663c700
PE
6333 * font.c (font_unparse_xlfd): Don't mix pointers to variables with
6334 pointers to constants.
89bc529a 6335 (font_parse_fcname): Remove unused vars.
7b81e2d0 6336 (font_delete_unmatched): Now static.
ea838e10 6337 (font_get_spec): Remove; unused.
13a547c6
PE
6338 (font_style_to_value, font_prop_validate_style, font_unparse_fcname):
6339 (font_update_drivers, Ffont_get_glyphs, font_add_log):
6340 Rename or move locals to avoid shadowing.
e663c700 6341
2a80c887 6342 * fns.c (require_nesting_list, require_unwind): Now static.
612f56df 6343 (Ffillarray): Rename locals to avoid shadowing.
2a80c887 6344
1384fa33 6345 * floatfns.c (domain_error2): Define only if needed.
a885e2ed 6346 (Ffrexp, Fldexp): Rename locals to avoid shadowing.
1384fa33 6347
8b2c52e9
PE
6348 * alloc.c (mark_backtrace): Move decl from here ...
6349 * lisp.h: ... to here, so that it can be checked.
6350
475545b5 6351 * eval.c (call_debugger, do_debug_on_call, grow_specpdl): Now static.
d28a2170 6352 (Fdefvar): Rewrite so as not to use empty "else".
cfcbfb1a
PE
6353 (lisp_indirect_variable): Name an expression,
6354 to avoid gcc -Wbad-function-cast warning.
1faed8ae 6355 (Fdefvar): Rename locals to avoid shadowing.
475545b5 6356
b1349114 6357 * callint.c (quotify_arg, quotify_args): Now static.
a3e8cbda 6358 (Fcall_interactively): Rename locals to avoid shadowing.
b0e80955 6359 Use const pointer when appropriate.
b1349114 6360
a2928364
PE
6361 * lisp.h (get_system_name, get_operating_system_release):
6362 Move decls here, to check interfaces.
6363 * process.c (get_operating_system_release): Move decl to lisp.h.
6364 * xrdb.c (get_system_name): Likewise.
63c5d10b
PE
6365 * editfns.c (init_editfns, Fuser_login_name, Fuser_uid):
6366 (Fuser_real_uid, Fuser_full_name): Remove unnecessary casts,
6367 some of which prompt warnings from gcc -Wbad-function-cast.
545b49b4
PE
6368 (Fformat_time_string, Fencode_time, Finsert_char):
6369 (Ftranslate_region_internal, Fformat):
6370 Rename or remove local vars to avoid shadowing.
9710023e 6371 (Ftranslate_region_internal): Mark var as initialized.
63c5d10b 6372
a415e694
PE
6373 * doc.c (Fdocumentation, Fsnarf_documentation): Move locals to
6374 avoid shadowing.
6375
8ef4622d
PE
6376 * lisp.h (eassert): Check that the argument compiles, even if
6377 ENABLE_CHECKING is not defined.
6378
946f9a5b
PE
6379 * data.c (Findirect_variable): Name an expression, to avoid
6380 gcc -Wbad-function-cast warning.
112396d6 6381 (default_value, arithcompare, arith_driver, arith_error): Now static.
b9b84fa9 6382 (store_symval_forwarding): Rename local to avoid shadowing.
44f230aa
SM
6383 (Fmake_variable_buffer_local, Fmake_local_variable):
6384 Mark variables as initialized.
52746918 6385 (do_blv_forwarding, do_symval_forwarding): Remove; unused.
946f9a5b 6386
e5aab7e7 6387 * alloc.c (check_cons_list): Do not define unless GC_CHECK_CONS_LIST.
ae35e756
PE
6388 (Fmake_vector, Fvector, Fmake_byte_code, Fgarbage_collect):
6389 Rename locals to avoid shadowing.
dff45157
PE
6390 (mark_stack): Move local variables into the #ifdef region where
6391 they're used.
7bc26fdb
PE
6392 (BLOCK_INPUT_ALLOC, UNBLOCK_INPUT_ALLOC): Define only if
6393 ! defined SYSTEM_MALLOC && ! defined SYNC_INPUT, as they are not
6394 needed otherwise.
6395 (CHECK_ALLOCATED): Define only if GC_CHECK_MARKED_OBJECTS.
6396 (GC_STRING_CHARS): Remove; not used.
d40d4be1 6397 (Fmemory_limit): Cast sbrk's returned value to char *.
ae35e756 6398
e5aab7e7
PE
6399 * lisp.h (check_cons_list): Declare if GC_CHECK_CONS_LIST; this
6400 avoids undefined behavior in theory.
6401
4da60324
PE
6402 * regex.c (IF_LINT): Add defn, for benefit of ../lib-src.
6403
88043301
PE
6404 Use functions, not macros, for up- and down-casing (Bug#8254).
6405 * buffer.h (DOWNCASE_TABLE, UPCASE_TABLE, DOWNCASE, UPPERCASEP):
6406 (NOCASEP, LOWERCASEP, UPCASE, UPCASE1): Remove. All callers changed
6407 to use the following functions instead of these macros.
6408 (downcase): Adjust to lack of DOWNCASE_TABLE. Return int, not
6409 EMACS_INT, since callers assume the returned value fits in int.
6410 (upcase1): Likewise, for UPCASE_TABLE.
6411 (uppercasep, lowercasep, upcase): New static inline functions.
0da09c43 6412 * editfns.c (Fchar_equal): Remove no-longer-needed workaround for
db69b0cd 6413 the race-condition problem in the old DOWNCASE.
88043301 6414
19ed5445
PE
6415 * regex.c (CHARSET_LOOKUP_RANGE_TABLE_RAW, POP_FAILURE_REG_OR_COUNT):
6416 Rename locals to avoid shadowing.
6417 (regex_compile, re_match_2_internal): Move locals to avoid shadowing.
abbd1bcf
PE
6418 (regex_compile, re_search_2, re_match_2_internal):
6419 Remove unused local vars.
952db0d7
PE
6420 (FREE_VAR): Rewrite so as not to use empty "else",
6421 which gcc can warn about.
da053e48 6422 (regex_compile, re_match_2_internal): Mark locals as initialized.
b313f9d8
PE
6423 (RETALLOC_IF): Define only if needed.
6424 (WORDCHAR_P): Likewise. This one is never needed, but is used
6425 only in a comment talking about a compiler bug, so put inside
6426 the #if 0 of that comment.
6427 (CHARSET_LOOKUP_BITMAP, FAIL_STACK_FULL, RESET_FAIL_STACK):
6428 (PUSH_FAILURE_ELT, BUF_PUSH_3, STOP_ADDR_VSTRING):
6429 Remove; unused.
19ed5445 6430
1f3561e4 6431 * search.c (boyer_moore): Rename locals to avoid shadowing.
76ef09b7
PE
6432 * character.h (FETCH_STRING_CHAR_AS_MULTIBYTE_ADVANCE):
6433 (PREV_CHAR_BOUNDARY): Likewise.
1f3561e4 6434
ded6f8f7
PE
6435 * search.c (simple_search): Remove unused var.
6436
dbd37a95
PE
6437 * dired.c (compile_pattern): Move decl from here ...
6438 * lisp.h: ... to here, so that it can be checked.
6439 (struct re_registers): New forward decl.
6440
7e47afad
PE
6441 * character.h (INC_POS, DEC_POS): Rename locals to avoid shadowing.
6442
85f24f61
PE
6443 * indent.c (MULTIBYTE_BYTES_WIDTH): New args bytes, width.
6444 All uses changed.
6445 (MULTIBYTE_BYTES_WIDTH, scan_for_column, compute_motion):
6446 Rename locals to avoid shadowing.
5671df8f 6447 (Fvertical_motion): Mark locals as initialized.
85f24f61 6448
181aa2be 6449 * casefiddle.c (casify_object, casify_region): Now static.
e45a141a 6450 (casify_region): Mark local as initialized.
181aa2be 6451
930d429c
PE
6452 * cmds.c (internal_self_insert): Rename local to avoid shadowing.
6453
7082eac6
PE
6454 * lisp.h (GCPRO2_VAR, GCPRO3_VAR, GCPRO4_VAR, GCPRO5_VAR, GCPRO6_VAR):
6455 New macros, so that the caller can use some names other than
6456 gcpro1, gcpro2, etc.
6457 (GCPRO2, GCPRO3, GCPRO4, GCPRO5, GCPRO6): Reimplement in terms
6458 of the new macros.
6459 (GCPRO1_VAR, UNGCPRO_VAR): Change the meaning of the second
6460 argument, for consistency with GCPRO2_VAR, etc: it is now the
6461 prefix of the variable, not the variable itself. All uses
6462 changed.
38b2c076
PE
6463 * dired.c (directory_files_internal, file_name_completion):
6464 Rename locals to avoid shadowing.
6465
15206ed9
PE
6466 Fix a race condition diagnosed by gcc -Wsequence-point (Bug#8254).
6467 An expression of the form (DOWNCASE (x) == DOWNCASE (y)), found in
6468 dired.c's scmp function, had undefined behavior.
6469 * lisp.h (DOWNCASE_TABLE, UPCASE_TABLE, DOWNCASE, UPPERCASEP):
6470 (NOCASEP, LOWERCASEP, UPCASE, UPCASE1): Move from here ...
6471 * buffer.h: ... to here, because these macros use current_buffer,
6472 and the new implementation with inline functions needs to have
6473 current_buffer in scope now, rather than later when the macros
6474 are used.
6475 (downcase, upcase1): New static inline functions.
6476 (DOWNCASE, UPCASE1): Reimplement using these functions.
6477 This avoids undefined behavior in expressions like
6478 DOWNCASE (x) == DOWNCASE (y), which previously suffered
6479 from race conditions in accessing the global variables
6480 case_temp1 and case_temp2.
6481 * casetab.c (case_temp1, case_temp2): Remove; no longer needed.
6482 * lisp.h (case_temp1, case_temp2): Remove their decls.
6483 * character.h (ASCII_CHAR_P): Move from here ...
6484 * lisp.h: ... to here, so that the inline functions mentioned
6485 above can use them.
6486
4a6bea26
PE
6487 * dired.c (directory_files_internal_unwind): Now static.
6488
f14b7e14
PE
6489 * fileio.c (file_name_as_directory, directory_file_name):
6490 (barf_or_query_if_file_exists, auto_save_error, auto_save_1):
6491 Now static.
2893f146
PE
6492 (file_name_as_directory): Use const pointers when appropriate.
6493 (Fexpand_file_name): Likewise. In particular, newdir might
6494 point at constant storage, so make it a const pointer.
fd4ead52 6495 (Fmake_directory_internal, Fread_file_name): Remove unused vars.
b14aac08
PE
6496 (Ffile_selinux_context, Fset_file_selinux_context): Fix pointer
6497 signedness issues.
f839df0c
PE
6498 (Fset_file_times, Finsert_file_contents, auto_save_error):
6499 Rename locals to avoid shadowing.
f14b7e14 6500
5716756e 6501 * minibuf.c (choose_minibuf_frame_1): Now static.
62137a95
PE
6502 (Ftry_completion, Fall_completions): Rename or remove locals
6503 to avoid shadowing.
5716756e 6504
b4c3046a
PE
6505 * marker.c (bytepos_to_charpos): Remove; unused.
6506
b45db522
PE
6507 * lisp.h (verify_bytepos, count_markers): New decls,
6508 so that gcc does not warn that these functions aren't declared.
6509
85876d07
PE
6510 * insdel.c (check_markers, make_gap_larger, make_gap_smaller):
6511 (reset_var_on_error, Fcombine_after_change_execute_1): Now static.
f0cb4a60 6512 (CHECK_MARKERS): Redo to avoid gcc -Wempty-body diagnostic.
40ef059e 6513 (copy_text): Remove unused local var.
85876d07 6514
03d78a21 6515 * filelock.c (within_one_second): Now static.
b3dd38ab 6516 (lock_file_1): Rename local to avoid shadowing.
03d78a21 6517
5df8f01b
PE
6518 * buffer.c (fix_overlays_before): Mark locals as initialized.
6519 (fix_start_end_in_overlays): Likewise. This function should be
6520 simplified by using pointers-to-pointers, but that's a different
6521 matter.
b1d876f1 6522 (switch_to_buffer_1): Now static.
8f54f30a
PE
6523 (Fkill_buffer, record_buffer, Fbury_buffer, Fset_buffer_multibyte):
6524 (report_overlay_modification): Rename locals to avoid shadowing.
c3bd59b5 6525
a70072c9 6526 * sysdep.c (system_process_attributes): Rename vars to avoid shadowing.
fbd02d7b 6527 Fix pointer signedness issue.
edced198
PE
6528 (sys_subshell): Mark local as volatile if checking for lint,
6529 to suppress a gcc -Wclobbered warning that does not seem to be right.
15dfd3d9 6530 (MAXPATHLEN): Define only if needed.
a70072c9 6531
a0977c44
PE
6532 * process.c (serial_open, serial_configure): Move decls from here ...
6533 * systty.h: ... to here, so that they can be checked.
6534
a884fdcc
PE
6535 * fns.c (get_random, seed_random): Move extern decls from here ...
6536 * lisp.h: ... to here, so that they can be checked.
6537
604efe86 6538 * sysdep.c (reset_io): Now static.
b8950c94 6539 (wait_for_termination_signal): Remove; unused.
604efe86 6540
38fc62d9
PE
6541 * keymap.c (keymap_parent, keymap_memberp, map_keymap_internal):
6542 (copy_keymap_item, append_key, push_text_char_description):
6543 Now static.
1004a21a 6544 (Fwhere_is_internal): Don't test CONSP (sequences) unnecessarily.
dbbb8427 6545 (DENSE_TABLE_SIZE): Remove; unused.
c1141155
PE
6546 (get_keymap, access_keymap, Fdefine_key, Fwhere_is_internal):
6547 (describe_map_tree):
6548 Rename locals to avoid shadowing.
38fc62d9 6549
2f2650da
PE
6550 * keyboard.c: Declare functions static if they are not used elsewhere.
6551 (echo_char, echo_dash, cmd_error, top_level_2):
6552 (poll_for_input, handle_async_input): Now static.
69a058fa
PE
6553 (read_char, kbd_buffer_get_event, make_lispy_position):
6554 (make_lispy_event, make_lispy_movement, apply_modifiers):
6555 (decode_keyboard_code, tty_read_avail_input, menu_bar_items):
6556 (parse_tool_bar_item, read_key_sequence, Fread_key_sequence):
6557 (Fread_key_sequence_vector): Rename locals to avoid shadowing.
c8a06054 6558 (read_key_sequence, read_char): Mark locals as initialized.
3ac94672 6559 (Fexit_recursive_edit, Fabort_recursive_edit): Mark with NO_RETURN.
2f2650da 6560
a053e86c 6561 * keyboard.h (make_ctrl_char): New decl.
da2f2dd9
PE
6562 (mark_kboards): Move decl here ...
6563 * alloc.c (mark_kboards): ... from here.
a053e86c 6564
4752793e
PE
6565 * lisp.h (force_auto_save_soon): New decl.
6566
74f10ca7 6567 * emacs.c (init_cmdargs): Rename local to avoid shadowing.
244fc23d
PE
6568 (DEFINE_DUMMY_FUNCTION): New macro.
6569 (__do_global_ctors, __do_global_ctors_aux, __do_global_dtors, __main):
6570 Use it.
c03cd23f
PE
6571 (main): Add casts to avoid warnings
6572 if GCC considers string literals to be constants.
74f10ca7 6573
022e70d4
PE
6574 * lisp.h (fatal_error_signal): Add decl, since it's exported.
6575
59d6fe83
PE
6576 * dbusbind.c: Pointer signedness fixes.
6577 (xd_signature, xd_append_arg, xd_initialize):
6578 (Fdbus_call_method, Fdbus_call_method_asynchronously):
6579 (Fdbus_method_return_internal, Fdbus_method_error_internal):
6580 (Fdbus_send_signal, xd_read_message_1, Fdbus_register_service):
6581 (Fdbus_register_signal): Use SSDATA when the context wants char *.
6582
78320123
PE
6583 * dbusbind.c (Fdbus_init_bus): Add cast to avoid warning
6584 if GCC considers string literals to be constants.
49cebcca 6585 (Fdbus_register_service, Fdbus_register_method): Remove unused vars.
78320123 6586
35ac2a97
SM
65872011-03-16 Stefan Monnier <monnier@iro.umontreal.ca>
6588
fb103ca9
SM
6589 * print.c (PRINT_CIRCLE_CANDIDATE_P): New macro.
6590 (print_preprocess, print_object): New macro to fix last change.
6591
35ac2a97
SM
6592 * print.c (print_preprocess): Don't forget font objects.
6593
62973b41
JB
65942011-03-16 Juanma Barranquero <lekktu@gmail.com>
6595
6596 * emacs.c (USAGE3): Doc fixes.
6597
0e48bb22
AS
65982011-03-15 Andreas Schwab <schwab@linux-m68k.org>
6599
6600 * coding.c (detect_coding_iso_2022): Reorganize code to clarify
6601 structure.
6602
7684e57b
JB
66032011-03-14 Juanma Barranquero <lekktu@gmail.com>
6604
6605 * lisp.h (VWindow_system, Qfile_name_history):
6606 * keyboard.h (lispy_function_keys) [WINDOWSNT]:
6607 * w32term.h (w32_system_caret_hwnd, w32_system_caret_height)
6608 (w32_system_caret_x, w32_system_caret_y): Declare extern.
6609
6610 * w32select.c: Don't #include "keyboard.h".
c96bbc66 6611 (run_protected): Add extern declaration for waiting_for_input.
7684e57b
JB
6612
6613 * w32.c (Qlocal, noninteractive1, inhibit_window_system):
6614 * w32console.c (detect_input_pending, read_input_pending)
6615 (encode_terminal_code):
6616 * w32fns.c (quit_char, lispy_function_keys, Qtooltip)
6617 (w32_system_caret_hwnd, w32_system_caret_height, w32_system_caret_x)
6618 (w32_system_caret_y, Qfile_name_history):
6619 * w32font.c (w32font_driver, QCantialias, QCotf, QClang):
6620 * w32inevt.c (reinvoke_input_signal, lispy_function_keys):
6621 * w32menu.c (Qmenu_bar, QCtoggle, QCradio, Qoverriding_local_map)
6622 (Qoverriding_terminal_local_map, Qmenu_bar_update_hook):
6623 * w32proc.c (Qlocal, report_file_error):
6624 * w32term.c (Vwindow_system, updating_frame):
6625 * w32uniscribe.c (initialized, uniscribe_font_driver):
6626 Remove unneeded extern declarations.
6627
2aa46d6c
CY
66282011-03-14 Chong Yidong <cyd@stupidchicken.com>
6629
c96bbc66 6630 * buffer.c (Fmake_indirect_buffer): Fix incorrect assertions.
2aa46d6c 6631
cffc6f3b
CY
66322011-03-13 Chong Yidong <cyd@stupidchicken.com>
6633
6634 * buffer.h (BUF_BEGV, BUF_BEGV_BYTE, BUF_ZV, BUF_ZV_BYTE, BUF_PT)
6635 (BUF_PT_BYTE): Rewrite to handle indirect buffers (Bug#8219).
6636 These macros can no longer be used for assignment.
6637
44f230aa
SM
6638 * buffer.c (Fget_buffer_create, Fmake_indirect_buffer):
6639 Assign struct members directly, instead of using BUF_BEGV etc.
cffc6f3b
CY
6640 (record_buffer_markers, fetch_buffer_markers): New functions for
6641 recording and fetching special buffer markers.
6642 (set_buffer_internal_1, set_buffer_temp): Use them.
6643
6644 * lread.c (unreadchar): Use SET_BUF_PT_BOTH.
6645
6646 * insdel.c (adjust_point): Use SET_BUF_PT_BOTH.
6647
6648 * intervals.c (temp_set_point_both): Use SET_BUF_PT_BOTH.
6649 (get_local_map): Use SET_BUF_BEGV_BOTH and SET_BUF_ZV_BOTH.
6650
6651 * xdisp.c (hscroll_window_tree):
6652 (reconsider_clip_changes): Use PT instead of BUF_PT.
6653
d251f04b
EZ
66542011-03-13 Eli Zaretskii <eliz@gnu.org>
6655
6656 * makefile.w32-in ($(BLD)/editfns.$(O)): Depend on
6657 $(EMACS_ROOT)/lib/intprops.h.
6658
f0c77cd1
PE
66592011-03-13 Paul Eggert <eggert@cs.ucla.edu>
6660
3eca4629
PE
6661 Fix more problems found by GCC 4.5.2's static checks.
6662
7c86ee98
PE
6663 * gtkutil.c (xg_get_pixbuf_from_pixmap): Add cast from char *
6664 to unsigned char * to avoid compiler diagnostic.
b0afc268
PE
6665 (xg_free_frame_widgets): Make it clear that a local variable is
6666 needed only if USE_GTK_TOOLTIP.
01e0b5ad
PE
6667 (gdk_window_get_screen): Make it clear that this macro is needed
6668 only if USE_GTK_TOOLTIP.
1e5524e7
PE
6669 (int_gtk_range_get_value): New function, which avoids a diagnostic
6670 from gcc -Wbad-function-cast.
6671 (xg_set_toolkit_scroll_bar_thumb): Use it.
6672 (xg_tool_bar_callback, xg_tool_item_stale_p): Rewrite to avoid
6673 diagnostic from gcc -Wbad-function-cast.
65dc836c
PE
6674 (get_utf8_string, xg_get_file_with_chooser):
6675 Rename locals to avoid shadowing.
6676 (create_dialog): Move locals to avoid shadowing.
7c86ee98 6677
41729b81
PE
6678 * xgselect.c (xg_select): Remove unused var.
6679
f0c77cd1
PE
6680 * image.c (four_corners_best): Mark locals as initialized.
6681 (gif_load): Initialize transparent_p to zero (Bug#8238).
6682 Mark another local as initialized.
ec6cf4c6 6683 (my_png_error, my_error_exit): Mark with NO_RETURN.
f0c77cd1 6684
ce0ad53d 6685 * image.c (clear_image_cache): Now static.
d5d5a617 6686 (DIM, HAVE_STDLIB_H_1): Remove unused macros.
e22cffbc 6687 (xpm_load): Redo to avoid "discards qualifiers" gcc warning.
77a765fd
PE
6688 (x_edge_detection): Remove unnecessary cast that
6689 gcc -Wbad-function-cast diagnoses.
2037898d 6690 (gif_load): Fix pointer signedness.
6ae141d6
PE
6691 (clear_image_cache, xbm_read_bitmap_data, x_detect_edges):
6692 (jpeg_load, gif_load): Rename locals to avoid shadowing.
ce0ad53d 6693
33383987 66942011-03-12 Paul Eggert <eggert@cs.ucla.edu>
3eca4629 6695
d32df629
PE
6696 Improve quality of tests for time stamp overflow.
6697 For example, without this patch (encode-time 0 0 0 1 1
6698 1152921504606846976) returns the obviously-bogus value (-948597
6699 62170) on my RHEL 5.5 x86-64 host. With the patch, it correctly
6700 reports time overflow. See
6701 <http://lists.gnu.org/archive/html/emacs-devel/2011-03/msg00470.html>.
b8d9bd41
PE
6702 * deps.mk (editfns.o): Depend on ../lib/intprops.h.
6703 * editfns.c: Include limits.h and intprops.h.
6704 (TIME_T_MIN, TIME_T_MAX): New macros.
6705 (time_overflow): Move earlier, to before first use.
6706 (hi_time, lo_time): New functions, for an accurate test for
6707 out-of-range times.
6708 (Fcurrent_time, Fget_internal_run_time, make_time): Use them.
6709 (Fget_internal_run_time): Don't assume time_t fits in int.
6710 (make_time): Use list2 instead of Fcons twice.
6711 (Fdecode_time): More accurate test for out-of-range times.
6712 (check_tm_member): New function.
6713 (Fencode_time): Use it, to test for out-of-range times.
d32df629
PE
6714 (lisp_time_argument): Don't rely on undefined left-shift and
6715 right-shift behavior when checking for time stamp overflow.
8be6f318 6716
fe31d94c
PE
6717 * editfns.c (time_overflow): New function, refactoring common code.
6718 (Fformat_time_string, Fdecode_time, Fencode_time):
6719 (Fcurrent_time_string): Use it.
6720
8be6f318
PE
6721 Move 'make_time' to be next to its inverse 'lisp_time_argument'.
6722 * dired.c (make_time): Move to ...
6723 * editfns.c (make_time): ... here.
6724 * systime.h: Note the move.
6725
09d9db2c 67262011-03-12 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
c47cbdfd 6727
126bc0dc
YM
6728 * fringe.c (update_window_fringes): Remove unused variables.
6729
c47cbdfd
YM
6730 * unexmacosx.c (copy_data_segment): Also copy __got section.
6731 (Bug#8223)
6732
7ac80be9
EZ
67332011-03-12 Eli Zaretskii <eliz@gnu.org>
6734
c96bbc66 6735 * termcap.c [MSDOS]: Include "msdos.h".
058e5dad
EZ
6736 (find_capability, tgetnum, tgetflag, tgetstr, tputs, tgetent):
6737 Constify `char *' arguments and their references according to
6738 prototypes in tparam.h.
6739
ecb0f94d 6740 * deps.mk (termcap.o): Depend on tparam.h and msdos.h.
058e5dad 6741
7ac80be9
EZ
6742 * msdos.c (XMenuAddPane): 3rd argument is `const char *' now.
6743 Adapt all references accordingly.
6744
6745 * msdos.h (XMenuAddPane): 3rd argument is `const char *' now.
6746
ef1fd07e
TT
67472011-03-11 Tom Tromey <tromey@redhat.com>
6748
6749 * buffer.c (syms_of_buffer): Remove obsolete comment.
6750
7ef4b50c
EZ
67512011-03-11 Eli Zaretskii <eliz@gnu.org>
6752
6753 * termhooks.h (encode_terminal_code): Declare prototype.
6754
6755 * msdos.c (encode_terminal_code): Don't declare prototype.
6756
6757 * term.c (encode_terminal_code): Now external again, used by
6758 w32console.c and msdos.c.
6759
44f230aa
SM
6760 * makefile.w32-in ($(BLD)/term.$(O), ($(BLD)/tparam.$(O)):
6761 Depend on $(SRC)/tparam.h, see 2011-03-11T07:24:21Z!eggert@cs.ucla.edu.
7ef4b50c 6762
4b1ec863 67632011-03-11 Paul Eggert <eggert@cs.ucla.edu>
f78faa98 6764
1714f52b 6765 Fix some minor problems found by GCC 4.5.2's static checks.
83316bf4 6766
4b1ec863
PE
6767 * fringe.c (update_window_fringes): Mark locals as initialized
6768 (Bug#8227).
6769 (destroy_fringe_bitmap, init_fringe_bitmap): Now static.
bf60f616 6770
524c7aa6
PE
6771 * alloc.c (mark_fringe_data): Move decl from here ...
6772 * lisp.h (mark_fringe_data) [HAVE_WINDOW_SYSTEM]: ... to here,
6773 to check its interface.
6774 (init_fringe_once): Do not declare unless HAVE_WINDOW_SYSTEM.
6775
a5c0af81 6776 * fontset.c (free_realized_fontset): Now static.
7519b8cd 6777 (Fset_fontset_font): Rename local to avoid shadowing.
cc6e5db1 6778 (fontset_font): Mark local as initialized.
a9a06e0b 6779 (FONTSET_SPEC, FONTSET_REPERTORY, RFONT_DEF_REPERTORY): Remove; unused.
a5c0af81 6780
b4716021
PE
6781 * xrdb.c: Include "xterm.h", to check x_load_resources's interface.
6782
811e9bac 6783 * xselect.c (x_disown_buffer_selections): Remove; not used.
7b83e2f1 6784 (TRACE3) [!defined TRACE_SELECTION]: Remove; not used.
aa0daa9f
PE
6785 (x_own_selection, Fx_disown_selection_internal): Rename locals
6786 to avoid shadowing.
6787 (x_handle_dnd_message): Remove local to avoid shadowing.
811e9bac 6788
7e3ab302
PE
6789 * lisp.h (GCPRO1_VAR, UNGCPRO_VAR): New macros,
6790 so that the caller can use some name other than gcpro1.
6791 (GCPRO1, UNGCPRO): Reimplement in terms of the new macros.
58d2d479
PE
6792 * xfns.c (Fx_create_frame, x_create_tip_frame, Fx_show_tip):
6793 (Fx_backspace_delete_keys_p):
6794 Use them to avoid shadowing, and rename vars to avoid shadowing.
6795 (x_decode_color, x_set_name, x_window): Now static.
6b437900 6796 (Fx_create_frame): Add braces to silence GCC warning.
c0951e53 6797 (Fx_file_dialog, Fx_select_font): Fix pointer signedness.
06b0c8a0
PE
6798 (x_real_positions, xg_set_icon_from_xpm_data, x_create_tip_frame):
6799 Remove unused locals.
7e3ab302
PE
6800 (Fx_create_frame, x_create_tip_frame, Fx_show_tip):
6801 (Fx_backspace_delete_keys_p): Rename locals to avoid shadowing.
6802 Some of these renamings use the new GCPRO1_VAR and UNGCPRO_VAR
6803 macros.
f78faa98 6804
e2b13473
PE
6805 * xterm.h (x_mouse_leave): New decl.
6806
77f23912
PE
6807 * xterm.c (x_copy_dpy_color, x_focus_on_frame, x_unfocus_frame):
6808 Remove unused functions.
cdf4ba58
PE
6809 (x_shift_glyphs_for_insert, XTflash, XTring_bell):
6810 (x_calc_absolute_position): Now static.
7411c686 6811 (XTread_socket): Don't define label "out" unless it's used.
2b07bcff 6812 Don't declare local "event" unless it's used.
ed7bf3a5
PE
6813 (x_iconify_frame, x_free_frame_resources): Don't declare locals
6814 unless they are used.
38d0b34a
PE
6815 (XEMBED_VERSION, xembed_set_info): Don't define unless needed.
6816 (x_fatal_error_signal): Remove; not used.
a6067996
PE
6817 (x_draw_image_foreground, redo_mouse_highlight, XTmouse_position):
6818 (x_scroll_bar_report_motion, handle_one_xevent, x_draw_bar_cursor):
6819 (x_error_catcher, x_connection_closed, x_error_handler):
6820 (x_error_quitter, xembed_send_message, x_iconify_frame):
6821 (my_log_handler): Rename locals to avoid shadowing.
28f1c698 6822 (x_delete_glyphs, x_ins_del_lines): Mark with NO_RETURN.
2a8fade0 6823 (x_connection_closed): Tell GCC not to suggest NO_RETURN.
77f23912 6824
44f230aa
SM
6825 * xfaces.c (clear_face_cache, Fx_list_fonts, Fface_font):
6826 Rename or move locals to avoid shadowing.
6b463e58 6827 (tty_defined_color, merge_face_heights): Now static.
5967d051 6828 (free_realized_faces_for_fontset): Remove; not used.
1e9966ea
PE
6829 (Fx_list_fonts): Mark variable that gcc -Wuninitialized
6830 does not deduce is never used uninitialized.
73719eba
PE
6831 (STRDUPA, LSTRDUPA, FONT_POINT_SIZE_QUANTUM): Remove; not used.
6832 (LFACEP): Define only if XASSERTS, as it's not needed otherwise.
071048a3 6833
426994c3 6834 * terminal.c (store_terminal_param): Now static.
5489860b 6835
032f1620 6836 * xmenu.c (menu_highlight_callback): Now static.
9d66f88e 6837 (set_frame_menubar): Remove unused local.
d4323972 6838 (xmenu_show): Rename parameter to avoid shadowing.
6d1f7fee
PE
6839 (xmenu_show, xdialog_show, xmenu_show): Make local pointers "const"
6840 since they might point to immutable storage.
281585b0
PE
6841 (next_menubar_widget_id): Declare only if USE_X_TOOLKIT,
6842 since it's unused otherwise.
032f1620 6843
367c19e5 6844 * xdisp.c (produce_glyphless_glyph): Initialize lower_xoff.
53df7c11 6845 Add a FIXME, since the code still doesn't look right. (Bug#8215)
9f36b9fd
PE
6846 (Fcurrent_bidi_paragraph_direction): Simplify slightly; this
6847 avoids a gcc -Wuninitialized diagnostic.
0e086e8f 6848 (display_line, BUILD_COMPOSITE_GLYPH_STRING, draw_glyphs):
44a3a108
PE
6849 (note_mouse_highlight): Mark variables that gcc -Wuninitialized
6850 does not deduce are never used uninitialized.
70739cbe 6851
07b48fa9
PE
6852 * lisp.h (IF_LINT): New macro, copied from ../lib-src/emacsclient.c.
6853
8868a238 6854 * xdisp.c (redisplay_window): Rename local to avoid shadowing.
4554d213
PE
6855 * window.c (window_loop, size_window):
6856 (run_window_configuration_change_hook, enlarge_window): Likewise.
8868a238 6857
7e5cf297 6858 * window.c (display_buffer): Now static.
d6550a9f
PE
6859 (size_window): Mark variables that gcc -Wuninitialized
6860 does not deduce are never used uninitialized.
a586633d
PE
6861 * window.h (check_all_windows): New decl, to forestall
6862 gcc -Wmissing-prototypes diagnostic.
5b555da1 6863 * dispextern.h (bidi_dump_cached_states): Likewise.
7e5cf297 6864
f6095868
PE
6865 * charset.h (CHECK_CHARSET_GET_CHARSET): Rename locals to avoid
6866 shadowing.
6867 * charset.c (map_charset_for_dump, Fchar_charset): Likewise.
726929c4
PE
6868 Include <limits.h>.
6869 (Fsort_charsets): Redo min/max calculation to shorten the code a bit
6870 and to avoid gcc -Wuninitialized warning.
89ef49df
PE
6871 (load_charset_map): Mark variables that gcc -Wuninitialized
6872 does not deduce are never used uninitialized.
53df7c11 6873 (load_charset): Abort instead of using uninitialized var (Bug#8229).
f6095868 6874
f38b440c
PE
6875 * coding.c (coding_set_source, coding_set_destination):
6876 Use "else { /* comment */ }" rather than "else /* comment */;"
6877 for clarity, and to avoid gcc -Wempty-body warning.
2735d060
PE
6878 (Fdefine_coding_system_internal): Don't redeclare 'i' inside
6879 a block, when the outer 'i' will do.
6880 (decode_coding_utf_8, decode_coding_utf_16, detect_coding_emacs_mule):
6881 (emacs_mule_char, decode_coding_emacs_mule, detect_coding_iso_2022):
6882 (decode_coding_iso_2022, decode_coding_sjis, decode_coding_big5):
6883 (decode_coding_raw_text, decode_coding_charset, get_translation_table):
6884 (Fdecode_sjis_char, Fdefine_coding_system_internal):
6885 Rename locals to avoid shadowing.
6886 * character.h (FETCH_STRING_CHAR_ADVANCE): Likewise.
e2f1bab9
PE
6887 * coding.c (emacs_mule_char, encode_invocation_designation):
6888 Now static, since they're not used elsewhere.
413bb2db 6889 (decode_coding_iso_2022): Add "default: abort ();" as a safety check.
c4a63b12 6890 (decode_coding_object, encode_coding_object, detect_coding_system):
ee05f961
PE
6891 (decode_coding_emacs_mule): Mark variables that gcc
6892 -Wuninitialized does not deduce are never used uninitialized.
160b01f6
PE
6893 (detect_coding_iso_2022): Initialize a local variable that might
6894 be used uninitialized. Leave a FIXME because it's not clear that
53df7c11 6895 this initialization is needed. (Bug#8211)
5f58e762
PE
6896 (ISO_CODE_LF, ISO_CODE_CR, CODING_ISO_FLAG_EUC_TW_SHIFT):
6897 (ONE_MORE_BYTE_NO_CHECK, UTF_BOM, UTF_16_INVALID_P):
6898 (SHIFT_OUT_OK, ENCODE_CONTROL_SEQUENCE_INTRODUCER):
6899 (ENCODE_DIRECTION_R2L, ENCODE_DIRECTION_L2R):
6900 Remove unused macros.
f38b440c 6901
232b38b9 6902 * category.c (hash_get_category_set): Remove unused local var.
9f3b5e69 6903 (copy_category_table): Now static, since it's not used elsewhere.
d0891610 6904 * character.c (string_count_byte8): Likewise.
232b38b9 6905
fb90da1b
PE
6906 * ccl.c (CCL_WRITE_STRING, CCL_ENCODE_CHAR, Fccl_execute_on_string):
6907 (Fregister_code_conversion_map): Rename locals to avoid shadowing.
6908
fb93dbc2
PE
6909 * chartab.c (copy_sub_char_table): Now static, since it's not used
6910 elsewhere.
5c156ace
PE
6911 (sub_char_table_ref_and_range, char_table_ref_and_range):
6912 Rename locals to avoid shadowing.
bbcd0949 6913 (ASET_RANGE, GET_SUB_CHAR_TABLE): Remove unused macros.
fb93dbc2 6914
7d3b3862 6915 * bidi.c (bidi_check_type): Now static, since it's not used elsewhere.
630d6892 6916 (BIDI_BOB): Remove unused macro.
7d3b3862 6917
6be7d3da
PE
6918 * cm.c (cmgoto): Mark variables that gcc -Wuninitialized does not
6919 deduce are never used uninitialized.
c2ed9c8b 6920 * term.c (encode_terminal_code): Likewise.
6be7d3da 6921
75f8807f 6922 * term.c (encode_terminal_code): Now static. Remove unused local.
72abad34 6923
50938595
PE
6924 * tparam.h: New file.
6925 * term.c, tparam.h: Include it.
6926 * deps.mk (term.o, tparam.o): Depend on tparam.h.
6927 * term.c (tputs, tgetent, tgetflag, tgetnum, tparam, tgetstr):
6928 Move these decls to tparam.h, and make them agree with what
6929 is actually in tparam.c. The previous trick of using incompatible
6930 decls in different modules does not conform to the C standard.
6931 All callers of tparam changed to use tparam's actual API.
6932 * tparam.c (tparam1, tparam, tgoto):
6933 Use const pointers where appropriate.
6934
fbceeba2
PE
6935 * cm.c (calccost, cmgoto): Use const pointers where appropriate.
6936 * cm.h (struct cm): Likewise.
6937 * dispextern.h (do_line_insertion_deletion_costs): Likewise.
6938 * scroll.c (ins_del_costs, do_line_insertion_deletion_costs): Likewise.
6939 * term.c (tty_ins_del_lines, calculate_costs, struct fkey_table):
6940 (term_get_fkeys_1, append_glyphless_glyph, produce_glyphless_glyph):
6941 (turn_on_face, init_tty): Likewise.
6942 * termchar.h (struct tty_display_info): Likewise.
fbceeba2 6943
7f3f1250
PE
6944 * term.c (term_mouse_position): Rename local to avoid shadowing.
6945
e6ca6543
PE
6946 * alloc.c (mark_ttys): Move decl from here ...
6947 * lisp.h (mark_ttys): ... to here, so that it's checked against defn.
6948
c40f8d15
AS
69492011-03-11 Andreas Schwab <schwab@linux-m68k.org>
6950
6951 * .gdbinit (pwinx, xbuffer): Fix access to buffer name.
6952
cfe0661d
JB
69532011-03-09 Juanma Barranquero <lekktu@gmail.com>
6954
6955 * search.c (compile_pattern_1): Remove argument regp, unused since
6956 revid:rms@gnu.org-19941211082627-3x1g1wyqkjmwloig.
6957 (compile_pattern): Don't pass it.
6958
0afb4571
J
69592011-03-08 Jan Djärv <jan.h.d@swipnet.se>
6960
6961 * xterm.h (DEFAULT_GDK_DISPLAY): New define.
6962 (GDK_WINDOW_XID, gtk_widget_get_preferred_size): New defines
6963 for ! HAVE_GTK3.
6964 (GTK_WIDGET_TO_X_WIN): Use GDK_WINDOW_XID.
6965
6966 * xmenu.c (menu_position_func): Call gtk_widget_get_preferred_size.
6967
6968 * gtkutil.c: Include gtkx.h if HAVE_GTK3. If ! HAVE_GTK3, define
6969 gdk_window_get_screen, gdk_window_get_geometry,
6970 gdk_x11_window_lookup_for_display and GDK_KEY_g.
6971 (xg_set_screen): Use DEFAULT_GDK_DISPLAY.
6972 (xg_get_pixbuf_from_pixmap): New function.
6973 (xg_get_pixbuf_from_pix_and_mask): Change parameters from GdkPixmap
6974 to Pixmap, take frame as parameter, remove GdkColormap parameter.
6975 Call xg_get_pixbuf_from_pixmap instead of
6976 gdk_pixbuf_get_from_drawable.
6977 (xg_get_image_for_pixmap): Do not make GdkPixmaps, call
6978 xg_get_pixbuf_from_pix_and_mask with Pixmap parameters instead.
6979 (xg_check_special_colors): Use GtkStyleContext and its functions
6980 for HAVE_GTK3.
6981 (xg_prepare_tooltip, xg_hide_tooltip): Call gdk_window_get_screen.
6982 (xg_prepare_tooltip, create_dialog, menubar_map_cb)
6983 (xg_update_frame_menubar, xg_tool_bar_detach_callback)
44f230aa
SM
6984 (xg_tool_bar_attach_callback, xg_update_tool_bar_sizes):
6985 Call gtk_widget_get_preferred_size.
0afb4571
J
6986 (xg_frame_resized): gdk_window_get_geometry only takes 5
6987 parameters.
44f230aa
SM
6988 (xg_win_to_widget, xg_event_is_for_menubar):
6989 Call gdk_x11_window_lookup_for_display.
0afb4571
J
6990 (xg_set_widget_bg): New function.
6991 (delete_cb): New function.
895009e1 6992 (xg_create_frame_widgets): Connect delete-event to delete_cb.
0afb4571
J
6993 Call xg_set_widget_bg. Only set backgrund pixmap for ! HAVE_GTK3
6994 (xg_set_background_color): Call xg_set_widget_bg.
6995 (xg_set_frame_icon): Call xg_get_pixbuf_from_pix_and_mask.
6996 (xg_create_scroll_bar): vadj is a GtkAdjustment for HAVE_GTK3.
6997 Only call gtk_range_set_update_policy if ! HAVE_GTK3.
6998 (xg_make_tool_item): Only connect xg_tool_bar_item_expose_callback
6999 if ! HAVE_GTK3.
7000 (update_frame_tool_bar): Call gtk_widget_hide.
7001 (xg_initialize): Use GDK_KEY_g.
7002
7003 * xsmfns.c (gdk_set_sm_client_id): Define to gdk_set_sm_client_id
7004 if ! HAVE_GTK3
7005 (x_session_initialize): Call gdk_x11_set_sm_client_id.
7006
7007 * xterm.c (XFillRectangle): Use cairo routines for HAVE_GTK3.
7008 (x_term_init): Disable Xinput(2) with GDK_CORE_DEVICE_EVENTS.
7009 Load ~/emacs.d/gtkrc only for ! HAVE_GTK3.
7010
1c2cc4ef
JB
70112011-03-08 Juanma Barranquero <lekktu@gmail.com>
7012
7013 * w32xfns.c (select_palette): Check success of RealizePalette against
7014 GDI_ERROR, not zero.
7015
33383987 7016See ChangeLog.11 for earlier changes.
aac0c6e3
MR
7017
7018;; Local Variables:
7019;; coding: utf-8
aac0c6e3
MR
7020;; End:
7021
33383987 7022 Copyright (C) 2011 Free Software Foundation, Inc.
aac0c6e3
MR
7023
7024 This file is part of GNU Emacs.
7025
7026 GNU Emacs is free software: you can redistribute it and/or modify
7027 it under the terms of the GNU General Public License as published by
7028 the Free Software Foundation, either version 3 of the License, or
7029 (at your option) any later version.
7030
7031 GNU Emacs is distributed in the hope that it will be useful,
7032 but WITHOUT ANY WARRANTY; without even the implied warranty of
7033 MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
7034 GNU General Public License for more details.
7035
7036 You should have received a copy of the GNU General Public License
7037 along with GNU Emacs. If not, see <http://www.gnu.org/licenses/>.