Remove obsolete configuration options (Windows port).
[bpt/emacs.git] / src / ChangeLog
CommitLineData
95f61aa2
JB
12012-07-04 Juanma Barranquero <lekktu@gmail.com>
2
3 * s/ms-w32.h (LISP_FLOAT_TYPE, HAVE_MEMCMP, HAVE_MEMCPY)
4 (HAVE_MEMMOVE, HAVE_MEMSET): Don't set, obsolete.
5
3884d954
DA
62012-07-04 Dmitry Antipov <dmantipov@yandex.ru>
7
d209e2fb 8 * buffer.c (init_buffer_once): Fix initialization of
3884d954
DA
9 headers for buffer_defaults and buffer_local_symbols.
10 Reported by Juanma Barranquero <lekktu@gmail.com>.
11
ee28be33
SM
122012-07-04 Stefan Monnier <monnier@iro.umontreal.ca>
13
14 Turn VECTOR_FREE_LIST_FLAG into PVEC_FREE.
15 * lisp.h (enum pvec_type): Use fewer bits.
16 (PSEUDOVECTOR_SIZE_BITS): New constant.
17 (PSEUDOVECTOR_SIZE_MASK, PVEC_TYPE_MASK): Use it.
18 (XSETPVECTYPESIZE, XSETTYPED_PSEUDOVECTOR, DEFUN): Adapt code to
19 change in pvec_type.
20 (PSEUDOVECTOR_TYPEP): New macro.
21 (TYPED_PSEUDOVECTORP): Use it.
22 * fns.c (internal_equal): Adapt code to extract pvectype.
23 * emacs.c (gdb_pvec_type): Update type.
24 * alloc.c (PSEUDOVECTOR_NBYTES): New macro.
25 (VECTOR_FREE_LIST_SIZE_MASK): Remove (=> PSEUDOVECTOR_SIZE_MASK).
26 (VECTOR_FREE_LIST_FLAG): Remove (=> PVEC_FREE).
27 (SETUP_ON_FREE_LIST): Use XSETPVECTYPESIZE.
28 (sweep_vectors): Use it. Use local var `total_bytes' instead of
29 abusing vector->header.next.nbytes.
30 (live_vector_p): Use PVEC_TYPE.
31 (mark_object): Adapt code to extract pvectype. Use switch.
32
c7f2cd7f
PE
332012-07-04 Paul Eggert <eggert@cs.ucla.edu>
34
35 * doprnt.c (doprnt): Don't assume string length fits in 'int'.
36 Tighten new eassert a bit.
37
8ce70ed2
DA
382012-07-04 Dmitry Antipov <dmantipov@yandex.ru>
39
40 Fix compilation with --enable-gcc-warnings and -O1
41 optimization level.
42 * doprnt.c (doprnt): Change type of tem to int, initialize
43 to avoid compiler warning. Add eassert.
44 * search.c (simple_search): Initialize match_byte to avoid
45 compiler warning. Add eassert.
46
dea7f1e5
PE
472012-07-04 Paul Eggert <eggert@cs.ucla.edu>
48
24a212eb
PE
49 Avoid weird behavior with large horizontal scrolls.
50 Without this change, for example, large hscroll values would
51 mess up Emacs's display on Fedora 15 x86, presumably due to
52 overflows in int calculations in the display code.
53 Also, if buffers had long lines, Emacs would freeze.
54 * window.c (HSCROLL_MAX): Reduce to 100000, and make it visible to GDB.
55 (set_window_hscroll): New function, containing the old guts of
56 Fset_window_hscroll. Return the clipped value.
57 (Fset_window_hscroll, Fscroll_left, Fscroll_right): Use it.
58 This avoids the need to check against PTRDIFF_MAX.
59
dea7f1e5
PE
60 * buffer.c (Fgenerate_new_buffer_name): Fix sprintf format mismatch.
61
76046526
DA
622012-07-04 Dmitry Antipov <dmantipov@yandex.ru>
63
64 * buffer.c (Fgenerate_new_buffer_name): Fix type mismatch.
65
39adff0d
PE
662012-07-04 Paul Eggert <eggert@cs.ucla.edu>
67
63807d47
PE
68 * regex.c: Suppress GCC warning on RHEL 6. (Bug#11207)
69 Conditionalize the pragmas on GCC 4.5 or later, not GCC 4.3 or later,
70 since GCC 4.4.6 issues a bogus warning for them.
71
39adff0d
PE
72 Fix bugs in file timestamp newness comparisons.
73 * fileio.c (Ffile_newer_than_file_p):
74 * lread.c (Fload): Use full timestamp resolution of files,
75 not just the 1-second resolution, so that files that are only
76 slightly newer still count as newer.
77 * fileio.c (Ffile_newer_than_file_p): Don't assume file
78 timestamps fit in 'int'; this fixes a Y2038 bug on most hosts.
79
dbeed9a6
PE
802012-07-03 Paul Eggert <eggert@cs.ucla.edu>
81
82 * fileio.c: Improve handling of file time marker. (Bug#11852)
83 (special_mtime): New function.
84 (Finsert_file_contents, Fverify_visited_file_modtime):
85 Use it to set special mtime values consistently.
86
636334d6
AS
872012-07-03 Andreas Schwab <schwab@linux-m68k.org>
88
89 * fileio.c (Finsert_file_contents): Properly handle st_mtime
90 marker for non-existing file. (Bug#11852)
91
e2017fe2
GM
922012-07-03 Glenn Morris <rgm@gnu.org>
93
94 * lisp.h (Fread_file_name): Restore EXFUN (it's not a normal DEFUN
95 and did not make it into globals.h).
96
404dbd37
TT
972012-07-03 Tom Tromey <tromey@redhat.com>
98
99 * window.c (Fset_window_margins, Fset_window_fringes)
100 (Fset_window_scroll_bars, Fset_window_vscroll): No longer static.
101 * textprop.c (Fprevious_property_change): No longer static.
102 * syntax.c (Fsyntax_table_p): No longer static.
103 * process.c (Fget_process, Fprocess_datagram_address): No longer
104 static.
105 * keymap.c (Flookup_key, Fcopy_keymap): No longer static.
106 * keyboard.c (Fcommand_execute): No longer static.
107 Remove EXFUN.
108 * insdel.c (Fcombine_after_change_execute): No longer static.
109 * image.c (Finit_image_library): No longer static.
110 * fileio.c (Fmake_symbolic_link): No longer static.
111 * eval.c (Ffetch_bytecode): No longer static.
112 * editfns.c (Fuser_full_name): No longer static.
d209e2fb
JB
113 * doc.c (Fdocumentation_property, Fsnarf_documentation):
114 No longer static.
404dbd37
TT
115 * buffer.c (Fset_buffer_major_mode, Fdelete_overlay): No longer
116 static.
117 * dired.c (Ffile_attributes): No longer static.
118 * composite.c (Fcomposition_get_gstring): No longer static.
119 * callproc.c (Fgetenv_internal): No longer static.
120
121 * ccl.h: Remove EXFUNs.
122 * buffer.h: Remove EXFUNs.
123 * dispextern.h: Remove EXFUNs.
124 * intervals.h: Remove EXFUNs.
125 * fontset.h: Remove EXFUN.
126 * font.h: Remove EXFUNs.
127 * dosfns.c (system_process_attributes): Remove EXFUN.
128 * keymap.h: Remove EXFUNs.
129 * lisp.h: Remove EXFUNs.
130 * w32term.h: Remove EXFUNs.
131 * window.h: Remove EXFUNs.
132 * xsettings.h: Remove EXFUN.
133 * xterm.h: Remove EXFUN.
134
8e4fd1e1
GM
1352012-07-03 Glenn Morris <rgm@gnu.org>
136
137 * lisp.h (Frandom): Make it visible to C.
138 * buffer.c (Fgenerate_new_buffer_name): Speed up finding a new
139 buffer for invisible buffers. (Bug#1229)
140
ca95b3eb
DA
1412012-07-03 Dmitry Antipov <dmantipov@yandex.ru>
142
143 Fix block vector allocation code to allow VECTOR_BLOCK_SIZE
144 values which aren't power of 2.
145 * alloc.c (VECTOR_FREE_LIST_SIZE_MASK): New macro. Verify
146 it's value and the value of VECTOR_BLOCK_SIZE. Adjust users
147 accordingly.
148
7555c33f
SM
1492012-07-03 Stefan Monnier <monnier@iro.umontreal.ca>
150
151 * lisp.h (Lisp_Misc, Lisp_Fwd): Move around to group better.
152
153 * alloc.c (mark_object): Revert part of last patch to use `switch'.
154
d12e8f5a
DA
1552012-07-03 Dmitry Antipov <dmantipov@yandex.ru>
156
157 * alloc.c (allocate_vector_block): Remove redundant
158 calls to mallopt if DOUG_LEA_MALLOC is defined.
159 (allocate_vectorlike): If DOUG_LEA_MALLOC is defined,
160 avoid calls to mallopt if zero_vector is returned.
161
296094c3
DA
1622012-07-03 Dmitry Antipov <dmantipov@yandex.ru>
163
164 * alloc.c (check_string_bytes): If GC_CHECK_STRING_BYTES
165 is enabled, avoid dereferencing NULL current_sblock if
166 running undumped.
167
36429c89
DA
1682012-07-03 Dmitry Antipov <dmantipov@yandex.ru>
169
170 Cleanup basic buffer management.
171 * buffer.h (struct buffer): Change layout to use generic vector
172 marking code. Fix some comments. Change type of 'clip_changed'
173 to bitfield. Remove unused #ifndef old.
174 (FIRST_FIELD_PER_BUFFER, LAST_FIELD_PER_BUFFER): Remove.
175 (GET_OVERLAYS_AT): Fix indentation.
176 (for_each_per_buffer_object_at): New macro.
177 * buffer.c (clone_per_buffer_values, reset_buffer_local_variables)
178 (Fbuffer_local_variables): Use it.
179 (init_buffer_once, syms_of_buffer): Remove unused #ifndef old.
180 * alloc.c (allocate_buffer): Adjust to match new layout of
181 struct buffer. Fix comment.
182 (mark_overlay): New function.
183 (mark_buffer): Use it. Use mark_vectorlike to mark normal
184 Lisp area of struct buffer.
185 (mark_object): Use it. Adjust marking of misc objects
186 and related comments.
187
3b3e4cac
PE
1882012-07-02 Paul Eggert <eggert@cs.ucla.edu>
189
190 * alloc.c (mark_object): Remove "#ifdef GC_CHECK_MARKED_OBJECTS"
191 wrapper that is not needed because the wrapped code is a no-op (zero
192 machine instructions) when GC_CHECK_MARKED_OBJECTS is not defined.
193 This avoids a -Wunused-macros diagnostic with GCC 4.7.1 x86-64.
194
cf5c0175
DA
1952012-07-02 Dmitry Antipov <dmantipov@yandex.ru>
196
197 * alloc.c (mark_buffer): Simplify. Remove prototype.
198 (mark_object): Add comment. Reorganize marking of vector-like
faf611c7 199 objects. Use CHECK_LIVE for all vector-like objects except buffers
cf5c0175
DA
200 and subroutines when GC_CHECK_MARKED_OBJECTS is defined. Avoid
201 redundant calls to mark_vectorlike for bool vectors.
202
ca26824c
GM
2032012-06-30 Glenn Morris <rgm@gnu.org>
204
2e4c5312
GM
205 * nsterm.m (ns_init_paths): Ignore site-lisp if --no-site-lisp.
206
ca26824c
GM
207 * epaths.in (PATH_SITELOADSEARCH): New.
208 * lread.c (init_lread): Use PATH_SITELOADSEARCH.
209 This is rather than relying on --enable-locallisppath elements
210 having "site-lisp" in their names. (Bug#10208#25, 11658)
211
0d23c240
EZ
2122012-06-30 Eli Zaretskii <eliz@gnu.org>
213
c9240d7a
EZ
214 * w32proc.c (sys_select): Accept and ignore one more argument.
215
216 * w32.c (emacs_gnutls_pull): Call select with one more argument.
217
0d23c240 218 * sysselect.h [DOS_NT]: Don't include sys/select.h.
9ff8f76b 219 (pselect) [!MS_DOS]: Redirect to sys_select.
0d23c240
EZ
220
221 * sysdep.c: Don't include dos.h and dosfns.h.
222
223 * process.c (sys_select):
224 * msdos.c (sys_select): Accept one more argument and ignore it.
225
226 * msdos.c (event_timestamp, sys_select): Use gnulib's gettime;
227 adapt data types and code to that.
228
229 * dosfns.c:
230 * msdos.c (gettime, settime): Define away the prototypes in dos.h,
231 which clashes with the gnulib function of the same name.
232
af5a5a98
AS
2332012-06-30 Andreas Schwab <schwab@linux-m68k.org>
234
c5e4379c
AS
235 * font.c (font_style_to_value, font_style_symbolic)
236 (font_prop_validate_style): Add type checks for values in
237 font_style_table.
238
af5a5a98
AS
239 * lisp.h (CHECK_RANGED_INTEGER): Make value to check the first
240 argument.
241 * character.c, charset.c, menu.c, process.c, window.c: Adjust all
242 uses.
243
8d38f461
EZ
2442012-06-29 Eli Zaretskii <eliz@gnu.org>
245
2e5a6631
EZ
246 * xdisp.c (try_window_id): Undo last change.
247
8d38f461
EZ
248 * w32.c (getwd): Adjust commentary about startup_dir.
249 (init_environment): Always call sys_access, even in non-MSVC
250 builds. Don't chdir to the directory of the Emacs executable.
251 This undoes code from 1997 which was justified by the need to
252 "avoid conflicts when removing and renaming directories". But its
253 downside was that every relative file name was being interpreted
254 relative to the directory of the Emacs executable, which can never
255 be TRT. In particular, it broke sys_access when called with
256 relative file names.
257 (sys_access): Map GetLastError to errno.
258
2af3565e
DA
2592012-06-29 Dmitry Antipov <dmantipov@yandex.ru>
260
261 * window.h (struct window): Change type of 'fringes_outside_margins'
262 to bitfield. Fix comment. Adjust users accordingly.
cf5c0175 263 (struct window): Change type of 'window_end_bytepos' to ptrdiff_t.
2af3565e
DA
264 Adjust comment.
265 * xdisp.c (try_window_id): Change type of 'first_vpos' and 'vpos'
266 to ptrdiff_t.
267
c8d3a25c 2682012-06-29 Andreas Schwab <schwab@linux-m68k.org>
57570cd3 269
c8d3a25c
GM
270 * gnutls.c (emacs_gnutls_handshake):
271 Add QUIT to make the loop interruptible.
57570cd3 272
c8d3a25c 2732012-06-29 Glenn Morris <rgm@gnu.org>
d01fd55f 274
c8d3a25c
GM
275 * charset.c (init_charset): Make lack of etc/charsets fatal.
276
3e984ee8
DA
2772012-06-29 Dmitry Antipov <dmantipov@yandex.ru>
278
279 * editfns.c (region_limit): Fix type mismatch.
280
ef884f23
DA
2812012-06-29 Dmitry Antipov <dmantipov@yandex.ru>
282
283 * nsfns.m: Fix GLYPH_DEBUG usage assuming that it may be
284 undefined. Convert from xassert to eassert.
285 * nsmenu.m: Convert from xassert to eassert.
286 * nsterm.m: Likewise.
287
7d7e0027
SM
2882012-06-28 Stefan Monnier <monnier@iro.umontreal.ca>
289
290 * editfns.c (region_limit): Clip to narrowing (bug#11770).
291
aa754e6a
PE
2922012-06-28 Paul Eggert <eggert@cs.ucla.edu>
293
294 Avoid integer overflow on scroll-left and scroll-right.
295 * window.c (HSCROLL_MAX): New macro.
296 (Fscroll_left, Fscroll_right): Avoid undefined behavior on integer
297 overflow when requested scroll falls outside ptrdiff_t range.
298
80b00b08
DA
2992012-06-28 Dmitry Antipov <dmantipov@yandex.ru>
300
301 * window.h (struct window): Change type of 'hscroll',
302 'min_hscroll' and 'last_point' from Lisp_Object to ptrdiff_t,
303 'last_modified' and 'last_overlay_modified' to EMACS_INT.
304 Adjust users accordingly.
305 * xdisp.c (try_cursor_movement): Replace type check with eassert.
306 * window.c (Fscroll_left, Fscroll_right): Change type of 'hscroll'
307 from EMACS_INT to ptrdiff_t.
308 (make_window): Omit redundant initialization.
309
62b2bcf6
JB
3102012-06-28 Juanma Barranquero <lekktu@gmail.com>
311
312 * makefile.w32-in ($(BLD)/regex.$(O)): Update dependencies.
313
45942c7d
DA
3142012-06-28 Dmitry Antipov <dmantipov@yandex.ru>
315
316 * window.h (struct window): Change type of 'use_time' and
317 'sequence_number' from Lisp_Object to int.
318 * frame.c (make_frame): Adjust users accordingly.
319 * print.c (print_object): Likewise.
320 * window.c (select_window, Fwindow_use_time, make_parent_window)
321 (make_window): Likewise.
322
e509cfa6
DA
3232012-06-28 Dmitry Antipov <dmantipov@yandex.ru>
324
325 * dispextern.h (GLYPH_DEBUG): Now defined in config.h if
326 enabled with --enable-checking=[all,glyphs] configure option.
327 Fix GLYPH_DEBUG usage assuming that it may be undefined,
328 adjust comments accordingly.
329 * dispnew.c: Fix GLYPH_DEBUG usage assuming that it may be
330 undefined, adjust comments accordingly.
331 * image.c: Likewise.
332 * scroll.c: Likewise.
333 * w32fns.c: Likewise.
334 * w32term.c: Likewise.
335 * xdisp.c: Likewise.
336 * xfaces.c: Likewise.
337 * xfns.c: Likewise.
338 * xterm.c: Likewise.
339
a54e2c05
DA
3402012-06-28 Dmitry Antipov <dmantipov@yandex.ru>
341
342 Generalize run-time debugging checks.
343 * dispextern.h (XASSERTS): Remove.
344 * fontset.c (xassert): Remove.
345 Convert from xassert to eassert.
346 * alloc.c: Convert from xassert to eassert.
347 * bidi.c: Likewise.
348 * dispnew.c: Likewise.
349 * fns.c: Likewise.
350 * fringe.c: Likewise.
351 * ftfont.c: Likewise.
352 * gtkutil.c: Likewise.
353 * image.c: Likewise.
354 * keyboard.c: Likewise.
355 * menu.c: Likewise.
356 * process.c: Likewise.
357 * scroll.c: Likewise.
358 * sound.c: Likewise.
359 * term.c: Likewise.
360 * w32console.c: Likewise.
361 * w32fns.c: Likewise.
362 * w32term.c: Likewise.
363 * window.c: Likewise.
364 * xdisp.c: Likewise.
365 * xfaces.c: Likewise.
366 * xfns.c: Likewise.
367 * xselect.c: Likewise.
368 * xterm.c: Likewise.
369
1ec4b7b2
SM
3702012-06-27 Stefan Monnier <monnier@iro.umontreal.ca>
371
372 * fns.c (maybe_resize_hash_table): Output message when growing the
373 purify-hashtable.
374
2014308a
DA
3752012-06-27 Dmitry Antipov <dmantipov@yandex.ru>
376
377 * alloc.c (allocate_string_data): Remove dead code.
378 * xsettings.c (XSETTINGS_FONT_NAME): Move under HAVE_XFT to
379 avoid GCC warning about unused macro.
380
246155eb
DA
3812012-06-27 Dmitry Antipov <dmantipov@yandex.ru>
382
383 * alloc.c (allocate_string): Omit intervals initialization.
384 * alloc.c (make_uninit_multibyte_string): Initialize intervals
385 as in make_pure_string and make_pure_c_string.
386
43184b7b
DA
3872012-06-27 Dmitry Antipov <dmantipov@yandex.ru>
388
d209e2fb 389 * alloc.c (allocate_string): Fix last change.
43184b7b 390
3fe6dd74
DA
3912012-06-27 Dmitry Antipov <dmantipov@yandex.ru>
392
d209e2fb 393 * alloc.c (allocate_string): Remove two redundant calls
3fe6dd74
DA
394 to memset, add explicit initialization where appropriate.
395
1ba6038a
GM
3962012-06-27 Glenn Morris <rgm@gnu.org>
397
398 * lisp.mk (lisp): Remove paths.elc.
399
c89926a5
CY
4002012-06-27 Chong Yidong <cyd@gnu.org>
401
402 * doc.c (Fsubstitute_command_keys): Fix punctuation.
403
ed6b3510
JW
4042012-06-26 John Wiegley <johnw@newartisans.com>
405
1ec4b7b2 406 * unexmacosx.c (copy_data_segment): Add two section names used
157e99e4
JW
407 on Mac OS X Lion: __mod_init_func and __mod_term_func.
408
ed6b3510
JW
409 * alloc.c (mark_memory): Do not check with -faddress-sanitizer
410 when building with Clang.
411
8edd4a2b
SM
4122012-06-26 Stefan Monnier <monnier@iro.umontreal.ca>
413
414 * eval.c (Fapply): Allow calling it with a single argument.
415
f6f62d1b
EZ
4162012-06-26 Eli Zaretskii <eliz@gnu.org>
417
418 * s/ms-w32.h (strcasecmp, strncasecmp) [_MSC_VER]: Redirect to
419 _stricmp and _strnicmp.
420 (HAVE_STRCASECMP, HAVE_STRNCASECMP): Define to 1.
421
62efea5e
DA
4222012-06-26 Dmitry Antipov <dmantipov@yandex.ru>
423
424 * alloc.c (allocate_window): Zero out non-Lisp part of newly
425 allocated window.
426 (allocate_process): Likewise for new process.
8edd4a2b 427 (allocate_terminal): Change to use offsetof.
62efea5e
DA
428 (allocate_frame): Likewise.
429 * frame.c (make_frame): Omit redundant initialization.
430 * window.c (make_parent_window): Use memset.
431 (make_window): Omit redundant initialization.
432 * process.c (make_process): Omit redundant initialization.
433 * terminal.c (create_terminal): Likewise.
434
42997f4d
DA
4352012-06-26 Dmitry Antipov <dmantipov@yandex.ru>
436
437 * term.c (delete_tty): Remove redundant call to memset.
438
1130ecfc
DA
4392012-06-26 Dmitry Antipov <dmantipov@yandex.ru>
440
441 * alloc.c: Remove build_string.
442 * lisp.h: Define build_string as static inline. This provides
443 a better opportunity to optimize away calls to strlen when the
444 function is called with compile-time constant argument.
445 * image.c (imagemagick_error): Convert to build_string.
446 * w32proc.c (sys_spawnve): Likewise.
447 * xterm.c (x_term_init): Likewise.
448
cf38a720
PE
4492012-06-26 Paul Eggert <eggert@cs.ucla.edu>
450
99027bdd
PE
451 Use sprintf return value instead of invoking strlen on result.
452 In the old days this wasn't portable, since some sprintf
453 implementations returned char *. But they died out years ago and
454 Emacs already assumes sprintf returns int.
455 Similarly for float_to_string.
456 This patch speeds up (number-to-string 1000) by 3% on Fedora 15 x86-64.
457 * ccl.c (ccl_driver):
458 * character.c (string_escape_byte8):
459 * data.c (Fnumber_to_string):
460 * doprnt.c (doprnt):
461 * print.c (print_object):
462 * xdisp.c (message_dolog):
463 * xfns.c (syms_of_xfns):
464 Use sprintf or float_to_string result to avoid need to call strlen.
465 * data.c (Fnumber_to_string):
466 Use make_unibyte_string, since the string must be ASCII.
467 * lisp.h, print.c (float_to_string): Now returns int length.
468 * term.c (produce_glyphless_glyph):
469 Use sprintf result rather than recomputing it.
470
cf38a720
PE
471 Clean out last vestiges of the old HAVE_CONFIG_H stuff.
472 * Makefile.in (ALL_CFLAGS):
473 * makefile.w32-in (LOCAL_FLAGS): Remove -DHAVE_CONFIG_H.
474 * gmalloc.c, regex.c: Include <config.h> unconditionally.
475
3511c784
DA
4762012-06-25 Dmitry Antipov <dmantipov@yandex.ru>
477
0a08eb21 478 * dispextern.h (xstrcasecmp): Define to library function
3511c784
DA
479 strcasecmp if available.
480 * xfaces.c: Do not use xstrcasecmp if strcasecmp is available.
481
fb7da12e
AS
4822012-06-25 Andreas Schwab <schwab@linux-m68k.org>
483
484 * keyboard.c (menu_bar_items, menu_bar_item, read_key_sequence):
485 Avoid comma operator.
486 * menu.c (push_submenu_start, push_submenu_end)
487 (push_left_right_boundary, push_menu_pane): Likewise.
488 * msdos.c (dos_rawgetc): Likewise.
489
afa2ffd8
DA
4902012-06-25 Dmitry Antipov <dmantipov@yandex.ru>
491
492 * xfns.c (xic_create_fontsetname): Remove redundant calls
493 to memset.
494
b3b4476b
PE
4952012-06-25 Paul Eggert <eggert@cs.ucla.edu>
496
4495ff38
PE
497 * gtkutil.c (get_utf8_string): Remove redundant assignment.
498 sprintf already null-terminates its output.
499
b3b4476b
PE
500 * xfns.c (x_window): Remove redundant cast.
501
b00876c9
DA
5022012-06-25 Dmitry Antipov <dmantipov@yandex.ru>
503
504 * xmenu.c (xmenu_show, xdialog_show): Explicit cast from
505 `const char *' to `char *' to avoid compiler warning.
506
d188e26b
PE
5072012-06-24 Paul Eggert <eggert@cs.ucla.edu>
508
885d1d74
PE
509 * xterm.c (x_term_init): Build proper-sized _XSETTINGS_Snnn string
510 instead of truncating it to 63 (admittedly a generous limit).
511
d188e26b
PE
512 * process.c: Fix spelling and caps in comments.
513
e2f560b1
DN
5142012-06-24 Dan Nicolaescu <dann@ics.uci.edu>
515
e86db54b 516 * emacs.c (setpgrp): Remove definition, unused.
e2f560b1
DN
517 * sysdep.c (setpgrp): Remove definition, not used in this file.
518
7583a3a1
JB
5192012-06-24 Juanma Barranquero <lekktu@gmail.com>
520
521 * makefile.w32-in: Update dependencies.
522
696056c2
EZ
5232012-06-24 Eli Zaretskii <eliz@gnu.org>
524
525 * makefile.w32-in (TIMESPEC_H): Remove nt/inc/sys/time.h.
526 (SYSTIME_H): Add nt/inc/sys/time.h.
527
528 * systime.h [WINDOWSNT]: Include sys/time.h.
529
530 * s/ms-w32.h (struct timespec): Definition moved from
531 nt/inc/sys/time.h. Suggested by Paul Eggert <eggert@cs.ucla.edu>.
532
845ca893
PE
5332012-06-24 Paul Eggert <eggert@cs.ucla.edu>
534
535 Switch from NO_RETURN to C11's _Noreturn (Bug#11750).
536 * buffer.h (buffer_slot_type_mismatch):
537 * data.c (arith_error) [!FORWARD_SIGNAL_TO_MAIN_THREAD]:
538 * eval.c (unwind_to_catch):
539 * image.c (my_png_error, my_error_exit):
540 * keyboard.c (quit_throw_to_read_char, user_error)
541 (Fexit_recursive_edit, Fabort_recursive_edit):
542 * lisp.h (die, args_out_of_range, args_out_of_range_3)
543 (wrong_type_argument, buffer_overflow, __executable_start)
544 (memory_full, buffer_memory_full, string_overflow, Fthrow)
545 (xsignal, xsignal0, xsignal1, xsignal2, xsignal3, signal_error)
546 (error, verror, nsberror, report_file_error, Ftop_level, Fkill_emacs)
547 (fatal):
548 (child_setup) [!DOS_NT]:
549 * lread.c (end_of_file_error, invalid_syntax):
550 * process.c (send_process_trap) [!FORWARD_SIGNAL_TO_MAIN_THREAD]:
551 * puresize.h (pure_write_error):
552 * search.c (matcher_overflow):
553 * sound.c (sound_perror, alsa_sound_perror):
554 * sysdep.c, syssignal.h (croak):
555 * term.c (maybe_fatal, vfatal):
556 * textprop.c (text_read_only):
557 * undo.c (user_error):
558 * unexmacosx.c (unexec_error):
559 * xterm.c (x_ins_del_lines, x_delete_glyphs):
560 Use _Noreturn rather than NO_RETURN.
561 No need for separate decl merely because of _Noreturn.
562 * sound.c (sound_warning, parse_sound):
563 Remove unnecessary forward decls.
564
f1dd8073
PE
5652012-06-24 Paul Eggert <eggert@cs.ucla.edu>
566
567 Fix bug when time_t is unsigned and as wide as intmax_t (Bug#9000).
568 * lisp.h (WAIT_READING_MAX): New macro.
569 * dispnew.c (Fsleep_for, sit_for):
570 * keyboard.c (kbd_buffer_get_event):
571 * process.c (Faccept_process_output):
572 Use it to avoid bogus compiler warnings with obsolescent GCC versions.
573 This improves on the previous patch, which introduced a bug
574 when time_t is unsigned and as wide as intmax_t.
575 See <http://bugs.gnu.org/9000#51>.
576
b82c1755
EZ
5772012-06-23 Eli Zaretskii <eliz@gnu.org>
578
579 * dispnew.c (sit_for, Fsleep_for):
580 * keyboard.c (kbd_buffer_get_event):
581 * process.c (Faccept_process_output): Avoid compiler warnings when
582 comparing a 32-bit time_t with a 64-bit INTMAX_MAX.
583
ca300656
JB
5842012-06-23 Juanma Barranquero <lekktu@gmail.com>
585
049ec95b
JB
586 * makefile.w32-in: Update dependencies.
587
ca300656
JB
588 * w32.c (ltime): Add return type and declare static.
589 (w32_get_internal_run_time): Remove usused variable `time_100ns'.
590
db7b8d06
PE
5912012-06-23 Paul Eggert <eggert@cs.ucla.edu>
592
593 * sysdep.c [__FreeBSD__]: Fix more recently-introduced typos.
594 Privately reported by Herbert J. Skuhra.
595 (make_lisp_timeval) [__FreeBSD__]: Rename from TIMELIST.
596 All uses changed.
597 (system_process_attributes) [__FreeBSD__]: Invoke make_lisp_time,
598 not make_lisp_timeval, when the argument is of type EMACS_TIME.
599
0bd8297f
EZ
6002012-06-23 Eli Zaretskii <eliz@gnu.org>
601
96512555
EZ
602 * w32proc.c (Fw32_get_locale_info): Fix an off-by-one error in
603 last argument of make_unibyte_string.
604
0bd8297f
EZ
605 * keyboard.c (kbd_buffer_get_event): Include the codepage and the
606 language ID in the event parameters.
607
608 * w32term.c (w32_read_socket): Put the new keyboard codepage into
609 event.code, not the obscure "character set ID".
610
63def6b6
CY
6112012-06-23 Chong Yidong <cyd@gnu.org>
612
613 * xmenu.c (x_menu_wait_for_event): Adapt GTK3 to new xg_select.
614
e8a02204
EZ
6152012-06-23 Eli Zaretskii <eliz@gnu.org>
616
388cdec0
EZ
617 Fix the MS-Windows build broken by 2012-06-22T21:17:42Z!eggert@cs.ucla.edu.
618 * w32.c (fdutimens): New function.
619
620 * w32proc.c (sys_select): Adapt to change in the EMACS_TIME type.
621
622 * s/ms-w32.h (pselect): Redirect to sys_select.
623
624 * sysselect.h [WINDOWSNT]: Don't include sys/select.h.
625
e8a02204
EZ
626 * ralloc.c (r_alloc_inhibit_buffer_relocation): Fix stupid thinko
627 in the logic of incrementing and decrementing the value of
628 use_relocatable_buffers.
629
d054f3fb
PE
6302012-06-23 Paul Eggert <eggert@cs.ucla.edu>
631
632 * sysdep.c [__FreeBSD__]: Fix recently-introduced typos.
633 Privately reported by Herbert J. Skuhra.
634 [__FreeBSD__]: Remove "*/" typo after "#include".
635 (timeval_to_EMACS_TIME) [__FreeBSD__]: New static function.
636 (TIMEVAL) [__FreeBSD__]: Now a static function rather than a macro.
637 (TIMEVAL, system_process_attributes) [__FreeBSD__]:
638 Don't assume EMACS_TIME and struct timeval are the same type.
639
d35af63c
PE
6402012-06-22 Paul Eggert <eggert@cs.ucla.edu>
641
642 Support higher-resolution time stamps (Bug#9000).
643 The time stamps are only nanosecond-resolution at the C level,
644 since that's the best that any real-world system supports now.
645 But they are picosecond-resolution at the Lisp level, as that's
646 easy, and leaves room for future OS improvements.
647
648 * Makefile.in (LIB_CLOCK_GETTIME): New macro.
649 (LIBES): Use it.
650
651 * alloc.c (Fgarbage_collect): Port to higher-res time stamps.
652 Don't get current time unless it's needed.
653
654 * atimer.c: Include <sys/time.h> unconditionally, since gnulib
655 now provides it if it's absent.
656 (start_atimer): Port to higher-res time stamps.
657 Check for time stamp overflow. Don't get current time more
658 often than is needed.
659
660 * buffer.h (struct buffer): Buffer modtime now has high resolution.
661 Include systime.h, not time.h.
662 (NONEXISTENT_MODTIME_NSECS, UNKNOWN_MODTIME_NSECS): New macros.
663
664 * dired.c: Include stat-time.h.
665 (Ffile-attributes): File times now have higher resolution.
666
667 * dispextern.h [HAVE_WINDOW_SYSTEM]: Include systime.h.
668 (struct image): Timestamp now has higher resolution.
669
670 * dispnew.c (PERIODIC_PREEMPTION_CHECKING): Remove, as Emacs always
671 has at least microseconds now. All uses removed.
672 (update_frame, update_single_window, update_window, update_frame_1)
673 (Fsleep_for, sit_for): Port to higher-resolution time stamps.
674
675 * editfns.c (time_overflow): Now extern.
676 (Fcurrent_time, Fget_internal_run_time, make_time, lisp_time_argument)
677 (float-time, Fformat_time_string, Fcurrent_time_string)
678 (Fcurrent_time_zone): Accept and generate higher-resolution
679 time stamps.
680 (make_time_tail, make_lisp_time, dissassemble_lisp_time)
681 (decode_time_components, lisp_seconds_argument): New functions.
682 (make_time): Now static.
683 (lisp_time_argument): Now returns EMACS_TIME. New arg ppsec.
684 Report an error if the time is invalid, rather than having the caller
685 do that.
686
687 * fileio.c: Include <stat-time.h>
688 (Fcopy_file): Copy higher-resolution time stamps.
689 Prefer to set the time stamp via a file descriptor if that works.
690 (Fset_file_times, Finsert_file_contents, Fwrite_region)
691 (Fverify_visited_file_modtime, Fclear_visited_file_modtime)
692 (Fvisited_file_modtime, Fset_visited_file_modtime):
693 Support higher-resolution time stamps.
694
695 * fns.c (Frandom): Use nanoseconds, not microseconds, for seed.
696
697 * gtkutil.c (xg_maybe_add_timer): Port to higher-res time stamps.
698
699 * image.c (prepare_image_for_display, clear_image_cache)
700 (lookup_image): Port to higer-resolution time stamps.
701
702 * keyboard.c (start_polling, bind_polling_period):
703 Check for time stamp overflow.
704 (read_char, kbd_buffer_get_event, timer_start_idle)
705 (timer_stop_idle, timer_resume_idle, timer_check_2, timer_check)
706 (Fcurrent_idle_time, init_keyboard, set_waiting_for_input):
707 Port to higher-resolution time stamps. Do not assume time_t is signed.
708 (decode_timer): New function. Timers are now vectors of length 9,
709 not 8, to accommodate the picosecond component.
710 (timer_check_2): Use it.
711
712 * nsterm.m (select_timeout, timeval_subtract): Remove.
713 (ns_timeout): Use Emacs's facilities for time stamp arithmetic,
714 as they're a bit more accurate and handle overflow better.
715 (ns_select): Change prototype to be compatible with pselect.
716 (ns_select, ns_term_shutdown): Port to ns-resolution time stamps.
717 * nsterm.h (ns_select): Adjust prototype.
718
719 * msdos.c (EMACS_TIME_ZERO_OR_NEG_P): Remove, as it assumes
720 us-resolution time stamps.
721 (sys_select): Use the new EMACS_TIME_SIGN macro instead.
722
723 * lread.c (read_filtered_event): Port to ns-resolution time stamps.
724
725 * lisp.h (time_overflow): New decl.
726 (wait_reading_process_output): First arg is now intmax_t, not int,
727 to accommodate larger waits.
728
729 * process.h (struct Lisp_Process.read_output_delay):
730 Now counts nanoseconds, not microseconds.
731 * process.c (ADAPTIVE_READ_BUFFERING): Don't worry about
732 EMACS_HAS_USECS.
733 (READ_OUTPUT_DELAY_INCREMENT, Faccept_process_output)
734 (wait_reading_process_output):
735 Port to ns-resolution time stamps.
736 (Faccept_process_output, wait_reading_process_output):
737 Check for time stamp overflow. Do not assume time_t is signed.
738 (select_wrapper): Remove; we now use pselect.
739 (Fprocess_attributes): Now generates ns-resolution time stamps.
740
741 * sysdep.c: Include utimens.h. Don't include utime.h
742 or worry about struct utimbuf; gnulib does that for us now.
743 (gettimeofday): Remove; gnulib provides a substitute.
744 (make_timeval): New function.
745 (set_file_times): Now sets ns-resolution time stamps.
746 New arg FD; all uses changed.
747 (time_from_jiffies, ltime_from_jiffies, get_up_time)
748 (system_process_attributes):
749 Now returns ns-resolution time stamp. All uses changed.
750 Check for time stamp overflow.
751
752 * sysselect.h: Don't depend on HAVE_SYS_SELECT_H; gnulib
753 provides a substitute now.
754
755 * systime.h: Include timespec.h rather than sys/time.h and time.h,
756 since it guarantees struct timespec.
757 (EMACS_TIME): Now struct timespec, so that we can support
758 ns-resolution time stamps.
759 (EMACS_TIME_RESOLUTION, LOG10_EMACS_TIME_RESOLUTION): New macros.
760 (EMACS_HAS_USECS): Remove; Emacs always has sub-second time stamps now.
761 (EMACS_USECS): Remove.
762 (EMACS_SET_USECS): The underlying time stamp now has ns resolution,
763 so multiply the arg by 1000 before storing it.
764 (EMACS_NSECS, EMACS_SECS_ADDR, EMACS_SET_NSECS, EMACS_SET_SECS_NSECS):
765 New macros.
766 (EMACS_GET_TIME, EMACS_ADD_TIME, EMACS_SUB_TIME):
767 Port to ns-resolution time stamps.
768 (EMACS_TIME_NEG_P): Remove; replaced by....
769 (EMACS_TIME_SIGN): New macro.
770 (EMACS_SET_INVALID_TIME, EMACS_TIME_VALID_P)
771 (EMACS_TIME_FROM_DOUBLE, EMACS_TIME_TO_DOUBLE): New macros.
772 (set_file_times, make_time, lisp_time_argument): Adjust signature.
773 (make_timeval, make_lisp_time, decode_time_components): New decls.
774 (EMACS_TIME_CMP): Remove; no longer used. Plus, it was buggy, in
775 that it mishandled time_t overflow. You can't compare by subtracting!
776 (EMACS_TIME_EQ, EMACS_TIME_NE, EMACS_TIME_GT, EMACS_TIME_GE)
777 (EMACS_TIME_LT, EMACS_TIME_LE): Rewrite in terms of timespec_cmp.
778
779 * term.c: Include <sys/time.h>.
780 (timeval_to_Time): New function, for proper overflow wraparound.
781 (term_mouse_position, term_mouse_click): Use it.
782
783 * undo.c (record_first_change): Support higher-resolution time stamps
784 in the undo buffer.
785 (Fprimitive_undo): Use them when restoring time stamps.
786
787 * w32.c (ltime, U64_TO_LISP_TIME, process_times, emacs_gnutls_pull)
788 (w32_get_internal_run_time):
789 Port to higher-resolution Emacs time stamps.
790 (ltime): Now accepts single 64-bit integer, as that's more convenient
791 for callers.
792
793 * xdisp.c (start_hourglass): Port to ns-resolution time stamps.
794
795 * xgselect.c, xgselect.h (xg_select): Add sigmask argument,
796 for compatibility with pselect. Support ns-resolution time stamps.
797
798 * xmenu.c (x_menu_wait_for_event): Support ns-resolution time stamps.
799
800 * xselect.c (wait_for_property_change, x_get_foreign_selection):
801 Check for time stamp overflow, and support ns-resolution time stamps.
802
803 * xterm.c: Don't include sys/time.h; gnulib does that for us now.
804 Don't worry about whether HAVE_TIMEVAL and HAVE_SELECT are set.
805 (timeval_subtract): Remove; no longer needed.
806 (XTflash, XTring_bell, x_wait_for_event):
807 Port to ns-resolution time stamps. Don't assume time_t is signed.
808
b6a92dfe
CY
8092012-06-22 Chong Yidong <cyd@gnu.org>
810
811 * xdisp.c (x_consider_frame_title): Revert last change.
812
d251c37c
EZ
8132012-06-22 Eli Zaretskii <eliz@gnu.org>
814
815 * alloc.c (NSTATICS): Enlarge to 0x650. Otherwise, Emacs compiled
816 with -DENABLE_CHECKING -DXASSERTS -DGLYPH_DEBUG=1 -DBYTE_CODE_METER
817 aborts in staticpro during startup. (Without -DBYTE_CODE_METER,
818 staticidx goes up to 1597 out of 1600 = 0x640.)
819
f10deafb
PE
8202012-06-20 Paul Eggert <eggert@cs.ucla.edu>
821
822 * fileio.c (Fdefault_file_modes): Block input while fiddling with umask.
823 Otherwise, the umask might be mistakenly 0 while handling input signals.
824
ec6de1e2
SM
8252012-06-19 Stefan Monnier <monnier@iro.umontreal.ca>
826
827 * minibuf.c (Fread_string): Bind minibuffer-completion-table.
828
28be1ada
DA
8292012-06-19 Dmitry Antipov <dmantipov@yandex.ru>
830
831 * alloc.c, bytecode.c, ccl.c, coding.c, composite.c, data.c, dosfns.c:
832 * font.c, image.c, keyboard.c, lread.c, menu.c, minibuf.c, msdos.c:
833 * print.c, syntax.c, window.c, xmenu.c, xselect.c: Replace direct
834 access to `contents' member of Lisp_Vector objects with AREF and ASET
835 where appropriate.
836
c6bf3022
CY
8372012-06-19 Chong Yidong <cyd@gnu.org>
838
839 * frame.c (delete_frame): When selecting a frame on a different
840 text terminal, do not alter the terminal's top-frame.
841
842 * xdisp.c (format_mode_line_unwind_data): Record the target
843 frame's selected window and its terminal's top-frame.
844 (unwind_format_mode_line): Restore them.
845 (x_consider_frame_title, display_mode_line, Fformat_mode_line):
846 Callers changed.
847 (x_consider_frame_title): Do not condition on HAVE_WINDOW_SYSTEM,
848 since tty frames can be explicitly named.
849 (prepare_menu_bars): Likewise.
850
851 * term.c (Ftty_top_frame): New function.
852
defd4196
PE
8532012-06-18 Paul Eggert <eggert@cs.ucla.edu>
854
855 Port byte-code-meter to modern targets.
856 * bytecode.c (METER_CODE) [BYTE_CODE_METER]: Don't assume
857 !CHECK_LISP_OBJECT_TYPE && !USE_LSB_TAG. Problem with
8b5257e1 858 CHECK_LISP_OBJECT_TYPE reported by Dmitry Antipov in
defd4196
PE
859 <http://lists.gnu.org/archive/html/emacs-devel/2012-06/msg00282.html>.
860 (METER_1, METER_2): Simplify.
861
1053a871
SM
8622012-06-18 Stefan Monnier <monnier@iro.umontreal.ca>
863
864 * data.c (Fdefalias): Return `symbol' (bug#11686).
865
b7e8d081
MR
8662012-06-18 Martin Rudalics <rudalics@gmx.at>
867
868 * buffer.c (Fkill_buffer): Don't throw an error when the buffer
1053a871
SM
869 gets killed during executing of this function (Bug#11665).
870 Try to always return Qt when the buffer has been actually killed.
b7e8d081
MR
871 (Vkill_buffer_query_functions): In doc-string say that functions
872 run by this hook should not change the current buffer.
873
7ea2b339
PE
8742012-06-18 Paul Eggert <eggert@cs.ucla.edu>
875
876 Fix recently-introduced process.c problems found by static checking.
877 * process.c (write_queue_push, write_queue_pop, send_process):
878 Use ptrdiff_t, not int or EMACS_INT, for buffer lengths and offsets.
879 (write_queue_pop): Fix pointer signedness problem.
880 (send_process): Remove unused local.
881
96a313a1
CY
8822012-06-17 Chong Yidong <cyd@gnu.org>
883
884 * xdisp.c (redisplay_internal): No need to redisplay terminal
885 frames that are not on top.
886
20ca2e94
TN
8872012-06-17 Troels Nielsen <bn.troels@gmail.com>
888
889 * process.c (make_process): Initialize write_queue.
890 (write_queue_push, write_queue_pop): New functions.
891 (send_process): Use them to maintain correct ordering of process
892 writes (Bug#10815).
893
9a900ca9
PE
8942012-06-17 Paul Eggert <eggert@cs.ucla.edu>
895
310fbfa8
PE
896 * lisp.h (eassert): Assume C89 or later.
897 This removes the need for CHECK.
898 (CHECK): Remove. Its comments about always evaluating its
899 argument were confusing, as 'eassert' typically does not evaluate
900 its argument.
901
27bb1ca4
PE
902 * coding.c (produce_chars): Use ptrdiff_t, not int.
903
9a900ca9
PE
904 * xterm.c (x_draw_underwave): Check for integer overflow.
905 This pacifies gcc 4.7.0 -Wunsafe-loop-optimizations on x86-64.
906
41b7f8bc 9072012-06-17 Jan Djärv <jan.h.d@swipnet.se>
50a93863
JD
908
909 * nsterm.m (x_free_frame_resources): Move xfree so freed memory isn't
910 referenced (Bug#11583).
911
9b0e3eba
AA
9122012-06-16 Aurelien Aptel <aurelien.aptel@gmail.com>
913
914 Implement wave-style variant of underlining.
915 * dispextern.h (face_underline_type): New enum.
916 (face): Add field for underline type.
917 * nsterm.m (ns_draw_underwave): New function.
918 (ns_draw_text_decoration): Use it.
919 * w32term.c (w32_restore_glyph_string_clip, w32_draw_underwave):
920 New functions.
921 (x_draw_glyph_string): Use them.
922 * xfaces.c (Qline, Qwave): New Lisp objects.
923 (check_lface_attrs, merge_face_ref)
1053a871
SM
924 (Finternal_set_lisp_face_attribute, realize_x_face):
925 Handle wave-style underline face attributes.
9b0e3eba
AA
926 * xterm.c (x_draw_underwave): New function.
927 (x_draw_glyph_string): Use it.
928
0fb52f11
JB
9292012-06-16 Juanma Barranquero <lekktu@gmail.com>
930
931 * makefile.w32-in ($(BLD)/emacs.$(O), $(BLD)/fringe.$(O))
932 ($(BLD)/xml.$(O), $(BLD)/intervals.$(O), $(BLD)/macros.$(O))
933 ($(BLD)/minibuf.$(O), $(BLD)/regex.$(O), $(BLD)/region-cache.$(O))
934 ($(BLD)/textprop.$(O), $(BLD)/undo.$(O), $(BLD)/window.$(O))
935 ($(BLD)/w32select.$(O)): Update dependencies.
936
e5560ff7
AS
9372012-06-16 Andreas Schwab <schwab@linux-m68k.org>
938
939 * buffer.h (FETCH_MULTIBYTE_CHAR): Define as inline.
940 (BUF_FETCH_MULTIBYTE_CHAR): Likewise.
941 * character.c (_fetch_multibyte_char_p): Remove.
942 * alloc.c: Include "character.h" before "buffer.h".
943 * bidi.c: Likewise.
944 * buffer.c: Likewise.
945 * bytecode.c: Likewise.
946 * callint.c: Likewise.
947 * callproc.c: Likewise.
948 * casefiddle.c: Likewise.
949 * casetab.c: Likewise.
950 * category.c: Likewise.
951 * cmds.c: Likewise.
952 * coding.c: Likewise.
953 * composite.c: Likewise.
954 * dired.c: Likewise.
955 * dispnew.c: Likewise.
956 * doc.c: Likewise.
957 * dosfns.c: Likewise.
958 * editfns.c: Likewise.
959 * emacs.c: Likewise.
960 * fileio.c: Likewise.
961 * filelock.c: Likewise.
962 * font.c: Likewise.
963 * fontset.c: Likewise.
964 * fringe.c: Likewise.
965 * indent.c: Likewise.
966 * insdel.c: Likewise.
967 * intervals.c: Likewise.
968 * keyboard.c: Likewise.
969 * keymap.c: Likewise.
970 * lread.c: Likewise.
971 * macros.c: Likewise.
972 * marker.c: Likewise.
973 * minibuf.c: Likewise.
974 * nsfns.m: Likewise.
975 * nsmenu.m: Likewise.
976 * print.c: Likewise.
977 * process.c: Likewise.
978 * regex.c: Likewise.
979 * region-cache.c: Likewise.
980 * search.c: Likewise.
981 * syntax.c: Likewise.
982 * term.c: Likewise.
983 * textprop.c: Likewise.
984 * undo.c: Likewise.
985 * unexsol.c: Likewise.
986 * w16select.c: Likewise.
987 * w32fns.c: Likewise.
988 * w32menu.c: Likewise.
989 * window.c: Likewise.
990 * xdisp.c: Likewise.
991 * xfns.c: Likewise.
992 * xmenu.c: Likewise.
993 * xml.c: Likewise.
994 * xselect.c: Likewise.
995
2f07e6af
EZ
9962012-06-16 Eli Zaretskii <eliz@gnu.org>
997
1053a871
SM
998 * xdisp.c (set_cursor_from_row): Don't dereference glyphs_end.
999 If all the glyphs of the glyph row came from strings, and we have no
2f07e6af 1000 cursor positioning clues, put the cursor on the first glyph of the
1097afe4
EZ
1001 row.
1002 (handle_face_prop): Use chunk-relative overlay string index when
1003 indexing into it->string_overlays array. (Bug#11653)
946fdb73
EZ
1004 (set_cursor_from_row): Use the leftmost glyph as GLYPH_BEFORE, not
1005 the rightmost. (Bug#11720)
2f07e6af 1006
29b83cec
AS
10072012-06-16 Andreas Schwab <schwab@linux-m68k.org>
1008
1009 * category.h (CHAR_HAS_CATEGORY): Define as inline.
1010 (CATEGORY_MEMBER): Enforce 1/0 value.
1011 * category.c (_temp_category_set): Remove.
1012
4c5501e9
EZ
10132012-06-16 Eli Zaretskii <eliz@gnu.org>
1014
1015 * window.c (Fdelete_other_windows_internal)
1016 (Fdelete_window_internal): Don't access frame's mouse highlight
1017 info of the initial frame. (Bug#11677)
1018
2b570124
PE
10192012-06-14 Paul Eggert <eggert@cs.ucla.edu>
1020
e93864f9
PE
1021 * .gdbinit (xgetint): Fix recently-introduced paren typo.
1022 Assume USE_2_TAGS_FOR_INTS.
1023 (xreload): Adjust $tagmask width to match recent lisp.h change.
1024
2b570124
PE
1025 Simplify lisp.h in minor ways that should not affect code.
1026 * lisp.h (USE_2_TAGS_FOR_INTS): Remove, as it was always defined.
1027 (LISP_INT_TAG, case_Lisp_Int, LISP_STRING_TAG, LISP_INT_TAG_P)
1028 (LISP_INT1_TAG, enum Lisp_Type, XINT, XUINT, make_number):
1029 Simplify under the assumption that USE_2_TAGS_FOR_INTS is defined.
1030 (INTTYPEBITS): New macro, for clarity.
1031 (INTMASK, MOST_POSITIVE_FIXNUM): Use it.
1053a871
SM
1032 (LISP_INT1_TAG, LISP_STRING_TAG, LISP_INT_TAG_P):
1033 Simplify now that USE_LSB_TAG is always defined.
2b570124
PE
1034 (TYPEMASK, XINT) [USE_LSB_TAG]: Remove unnecessary cast.
1035 (make_number) [!USE_LSB_TAG]: Use INTMASK; that's simpler.
1036
81755f69
JB
10372012-06-13 Juanma Barranquero <lekktu@gmail.com>
1038
1039 * makefile.w32-in ($(BLD)/data.$(O)): Update dependencies.
1040
16192a57
GM
10412012-06-13 Glenn Morris <rgm@gnu.org>
1042
1043 * s/bsd-common.h (BSD4_3):
1044 * s/usg5-4-common.h (USG5_4): No longer define; unused.
1045
646b5f55
AS
10462012-06-13 Andreas Schwab <schwab@linux-m68k.org>
1047
1048 * lisp.h (Lisp_Object) [CHECK_LISP_OBJECT_TYPE]: Define as struct
1049 instead of union.
1050 (XLI, XIL): Define.
1053a871
SM
1051 (XHASH, XTYPE, XINT, XUINT, make_number, XSET, XPNTR, XUNTAG):
1052 Use them.
1053 * emacs.c (gdb_use_struct): Rename from gdb_use_union.
646b5f55 1054 * .gdbinit: Check gdb_use_struct instead of gdb_use_union.
1053a871 1055 * alloc.c (widen_to_Lisp_Object): Remove.
646b5f55
AS
1056 (mark_memory): Use XIL instead of widen_to_Lisp_Object.
1057 * frame.c (delete_frame): Remove outdated comment.
1058 * w32fns.c (Fw32_register_hot_key): Use XLI instead of checking
1059 USE_LISP_UNION_TYPE.
1060 (Fw32_unregister_hot_key): Likewise.
1061 (Fw32_toggle_lock_key): Likewise.
1062 * w32menu.c (add_menu_item): Likewise.
1063 (w32_menu_display_help): Use XIL instead of checking
1064 USE_LISP_UNION_TYPE.
1065 * w32heap.c (allocate_heap): Don't check USE_LISP_UNION_TYPE.
1066 (init_heap): Likewise.
1067 * w32term.c (w32_read_socket): Update comment.
1068
1d3823c9
GM
10692012-06-13 Glenn Morris <rgm@gnu.org>
1070
c62ff706
GM
1071 * s/usg5-4-common.h, src/s/unixware.h:
1072 Remove define/undef of HAVE_SYSV_SIGPAUSE (not used since 2010-05-04).
1073
1d3823c9
GM
1074 * s/gnu.h (POSIX_SIGNALS): Remove (not used since 2010-05-04).
1075
bfe3e0a2
PE
10762012-06-13 Paul Eggert <eggert@cs.ucla.edu>
1077
1078 USE_LISP_UNION_TYPE + USE_LSB_TAG cleanup (Bug#11604)
1079 * alloc.c (make_number) [!defined make_number]:
1080 Remove, as lisp.h always defines this now.
1081 (mark_maybe_pointer): Simplify since USE_LSB_TAG is always defined now.
1082 (roundup_size): Verify that it is a power of 2.
1083 * data.c (Fmake_variable_buffer_local, Fmake_local_variable):
1084 * ftfont.c (ftfont_driver): Use LISP_INITIALLY_ZERO.
1085 * lisp.h (USE_LSB_TAG): Allow the builder to compile with
1086 -DUSE_LSB_TAG=0, to override the automatically-selected default.
1087 USE_LSB_TAG now is always defined to be either 0 or 1.
1088 All uses changed.
1089 (union Lisp_Object): Don't worry about WORDS_BIGENDIAN; the
1090 code works fine either way, and efficiency is not a concern here,
1091 as the union type is for debugging, not for production.
1092 (LISP_MAKE_RVALUE, make_number) [USE_LISP_UNION_TYPE]:
1093 Use an inline function on all platforms when using the union type,
1094 since this is simpler and 'static inline' can be used portably
1095 within Emacs now.
1096 (LISP_INITIALLY_ZERO): New macro.
1097 (XFASTINT, XSETFASTINT) [USE_LISP_UNION_TYPE]: Remove.
1098 (XSET) [USE_LISP_UNION_TYPE]: Don't overparenthesize.
1099
45fa9c0f
GM
11002012-06-12 Glenn Morris <rgm@gnu.org>
1101
b4492cba
GM
1102 * s/gnu-kfreebsd.h, s/hpux11.h, s/openbsd.h, s/sol2-10.h: Remove files.
1103
1104 * s/gnu-linux.h (HAVE_PROCFS): Move to configure.
0d369729 1105
45fa9c0f
GM
1106 * s/hpux10-20.h, s/openbsd.h, s/usg5-4-common.h:
1107 Move BROKEN_SIGIO to configure.
1108
1109 * s/bsd-common.h, s/darwin.h, s/gnu-kfreebsd.h, s/hpux10-20.h:
1110 Move NO_TERMIO to configure.
1111
0e25d334
CY
11122012-06-12 Chong Yidong <cyd@gnu.org>
1113
1114 * image.c (imagemagick_load_image): Use MagickFlattenImage if
1115 MagickMergeImageLayers is undefined. Use pixel pusher loop if
1116 MagickExportImagePixels is undefined.
1117
43682bb6
PE
11182012-06-12 Paul Eggert <eggert@cs.ucla.edu>
1119
1120 * image.c (imagemagick_load_image): Remove unused label.
1121
a9be7d2b
GM
11222012-06-11 Glenn Morris <rgm@gnu.org>
1123
1124 * s/aix4-2.h, s/bsd-common.h, s/cygwin.h, s/darwin.h:
1125 * s/gnu-kfreebsd.h, s/gnu-linux.h, s/gnu.h, s/hpux10-20.h:
1126 * s/irix6-5.h, s/ms-w32.h, s/msdos.h, s/template.h:
1127 * s/usg5-4-common.h: Move SYSTEM_TYPE to configure.
1128
3017f87f
SM
11292012-06-11 Stefan Monnier <monnier@iro.umontreal.ca>
1130
1131 * alloc.c (make_byte_code): New function.
1132 (Fmake_byte_code): Use it. Don't purify here.
1133 * lread.c (read1): Use it as well to avoid extra allocation.
1134
1b9b4cf4
CY
11352012-06-11 Chong Yidong <cyd@gnu.org>
1136
1137 * image.c (imagemagick_load_image): Implement transparency.
1138
95988fcf
AS
11392012-06-10 Andreas Schwab <schwab@linux-m68k.org>
1140
1141 * regex.c (at_begline_loc_p): Also recognize `(?N:' and correctly
1142 account for preceding backslashes. (Bug#11663)
1143
cd4eb164
CY
11442012-06-09 Chong Yidong <cyd@gnu.org>
1145
1146 * term.c: Support italics in capable terminals (Bug#9652).
1147 (no_color_bit): Replace unused NC_BLINK with NC_ITALIC.
1148 (turn_on_face): Output using TS_enter_italic_mode if available.
1149 Don't handle unused blinking and alt-charset cases.
1150 (turn_off_face): Handle italic case; discard unused tty_blinking_p
1151 and tty_alt_charset_p cases.
1152 (tty_capable_p, init_tty): Support italics.
1153
1154 * termchar.h (struct tty_display_info): Add field for italics.
1155 Remove unused blink field.
1156
1157 * xfaces.c (tty_supports_face_attributes_p, realize_tty_face):
1158 Handle slant.
1159
1160 * dispextern.h: Replace unused TTY_CAP_BLINK with TTY_CAP_ITALIC.
1161 (struct face): Remove unused fields tty_dim_p, tty_blinking_p, and
1162 tty_alt_charset_p. Add tty_italic_p.
1163
ff88beb8
MA
11642012-06-09 Michael Albinus <michael.albinus@gmx.de>
1165
1166 * dbusbind.c (XD_BASIC_DBUS_TYPE): Use dbus_type_is_valid and
1167 dbus_type_is_basic if available.
1168 (xd_extract_signed, xd_extract_unsigned): Rename from
1169 extract_signed and extract_unsigned, respectively. Adapt callers.
1170
44286096
CY
11712012-06-09 Chong Yidong <cyd@gnu.org>
1172
1682701f
CY
1173 * xfaces.c (face_for_overlay_string): Handle face remapping (Bug#2066).
1174
44286096
CY
1175 * fringe.c (Fset_fringe_bitmap_face): Handle the noninteractive
1176 case (Bug#9752).
1177
d86feb17
PE
11782012-06-08 Paul Eggert <eggert@cs.ucla.edu>
1179
1180 * xdisp.c (vmessage): Treat frame message as multibyte.
1181 Without this change, (let ((§ 1)) (make-variable-buffer-local '§))
1182 would generate the diagnostic "Making \302\247 buffer-local while
1183 let-bound!".
1184
d5c20fe8
EZ
11852012-06-08 Eli Zaretskii <eliz@gnu.org>
1186
1187 * dispnew.c (showing_window_margins_p): Undo last change, which
1188 was done due to an inadvertent commit.
1189 (adjust_frame_glyphs_for_frame_redisplay): Do call
1190 showing_window_margins_p.
1191
513749ee
SM
11922012-06-08 Stefan Monnier <monnier@iro.umontreal.ca>
1193
1194 * eval.c (Fmake_var_non_special): New primitive.
1195 (syms_of_eval): Defsubr it.
1196 * lread.c (syms_of_lread): Mark `values' as lexically scoped.
1197
d4a8f5c1
JB
11982012-06-08 Juanma Barranquero <lekktu@gmail.com>
1199
1200 * dispnew.c (showing_window_margins_p): Wrap in #if 0 to prevent unused
1201 function warning (the only call is inside #if 0 since 2012-06-08T08:44:45Z!eliz@gnu.org).
1202
8bbbc977
EZ
12032012-06-08 Eli Zaretskii <eliz@gnu.org>
1204
1205 * alloc.c (allocate_vectorlike): Fix last change.
1206
f3372c87
DA
12072012-06-08 Dmitry Antipov <dmantipov@yandex.ru>
1208
1209 Block-based vector allocation of small vectors.
1210 * lisp.h (struct vectorlike_header): New field `nbytes',
1211 adjust comment accordingly.
1212 * alloc.c (enum mem_type): New type `MEM_TYPE_VECTOR_BLOCK'
1213 to denote vector blocks. Adjust users (live_vector_p,
1214 mark_maybe_pointer, valid_lisp_object_p) accordingly.
1215 (COMMON_MULTIPLE): Move outside #if USE_LSB_TAG.
1216 (VECTOR_BLOCK_SIZE, vroundup, VECTOR_BLOCK_BYTES),
1217 (VBLOCK_BYTES_MIN, VBLOCK_BYTES_MAX, VECTOR_MAX_FREE_LIST_INDEX),
1218 (VECTOR_FREE_LIST_FLAG, ADVANCE, VINDEX, SETUP_ON_FREE_LIST),
1219 (VECTOR_SIZE, VECTOR_IN_BLOCK): New macros.
1220 (roundup_size): New constant.
1221 (struct vector_block): New data type.
1222 (vector_blocks, vector_free_lists, zero_vector): New variables.
513749ee 1223 (all_vectors): Rename to `large_vectors'.
f3372c87
DA
1224 (allocate_vector_from_block, init_vectors, allocate_vector_from_block)
1225 (sweep_vectors): New functions.
1226 (allocate_vectorlike): Return `zero_vector' as the only vector of
1227 0 items. Allocate new vector from block if vector size is less than
1228 or equal to VBLOCK_BYTES_MAX.
1229 (Fgarbage_collect): Move all vector sweeping code to sweep_vectors.
1230 (init_alloc_once): Add call to init_vectors.
1231
4f18a4ed
SM
12322012-06-08 Stefan Monnier <monnier@iro.umontreal.ca>
1233
1234 * eval.c (Fmacroexpand): Stop if the macro returns the same form.
1235
86f158bc
PE
12362012-06-07 Paul Eggert <eggert@cs.ucla.edu>
1237
1238 * doprnt.c (doprnt): Truncate multibyte char correctly.
1239 Without this change, doprnt (buf, 2, "%s", FORMAT_END, AP)
1240 would mishandle a string argument "Xc" if X was a multibyte
1241 character of length 2: it would truncate after X's first byte
1242 rather than including all of X.
1243
c5cfcbe0
CY
12442012-06-06 Chong Yidong <cyd@gnu.org>
1245
1246 * buffer.c (word_wrap): Doc fix.
1247
c05cf390
PE
12482012-06-04 Paul Eggert <eggert@cs.ucla.edu>
1249
1250 * xdisp.c (note_mode_line_or_margin_highlight): Pacify gcc -Wall.
1251
0c3461de
GM
12522012-06-03 Glenn Morris <rgm@gnu.org>
1253
1254 * xdisp.c (tool-bar-style): Doc fix.
1255
c71232db
UM
12562012-06-03 Ulrich Müller <ulm@gentoo.org>
1257
1258 * Makefile.in (PAXCTL): Define.
1259 (temacs$(EXEEXT)): Disable memory randomization for the temacs
1260 binary via PaX flags if the paxctl utility is available.
1261 (emacs$(EXEEXT), bootstrap-emacs$(EXEEXT)):
1262 Restore PaX flags to their default. (Bug#11398)
1263
383f7350
CY
12642012-06-03 Chong Yidong <cyd@gnu.org>
1265
1266 * xdisp.c (decode_mode_spec_coding): Display a space for a unibyte
1267 buffer (Bug#11226).
1268
5f2c76c6
CY
12692012-06-03 Chong Yidong <cyd@gnu.org>
1270
1271 * xdisp.c (calc_pixel_width_or_height): Use Fbuffer_local_value.
1272 (note_mode_line_or_margin_highlight): If there is no help echo,
1273 use mode-line-default-help-echo. Handle the case where the mouse
1274 position is past the end of the mode line string.
1275
1276 * buffer.c (buffer_local_value_1): New function, split from
1277 Fbuffer_local_value; can return Qunbound.
1278 (Fbuffer_local_value): Use it.
1279 (Vmode_line_format): Docstring tweaks.
1280
773d47f6
PE
12812012-06-02 Paul Eggert <eggert@cs.ucla.edu>
1282
1283 * sysdep.c (system_process_attributes): Improve comment.
1284
f2d6a3df
SM
12852012-06-02 Stefan Monnier <monnier@iro.umontreal.ca>
1286
1287 * keyboard.c: Export real-this-command to Elisp.
1288 (syms_of_keyboard): Rename real_this_command to Vreal_this_command
1289 and DEFVAR it. Update all users.
1290
63810350
PE
12912012-06-02 Paul Eggert <eggert@cs.ucla.edu>
1292
7bd5c1f4
PE
1293 * minibuf.c (Fassoc_string): Remove duplicate declaration.
1294
63810350
PE
1295 * sysdep.c (system_process_attributes) [SOLARIS2 && HAVE_PROCFS]:
1296 Convert pctcpu and pctmem to Lisp float properly.
1297 Let the compiler fold better, as 100.0/0x8000 is exact.
1298
a2821611
AS
12992012-06-02 Andreas Schwab <schwab@linux-m68k.org>
1300
1301 * alloc.c (CONS_BLOCK_SIZE): Account for padding at the end of
1302 cons_block.
1303
5fceba1d
PE
13042012-06-01 Paul Eggert <eggert@cs.ucla.edu>
1305
1306 * xfns.c (x_set_tool_bar_lines) [USE_GTK]: Adjust to bitfield change.
1307
c98ff5dd
DA
13082012-06-01 Dmitry Antipov <dmantipov@yandex.ru>
1309
1310 For a 'struct window', replace some Lisp_Object fields to
1311 bitfields where appropriate, remove unused fields.
1312 * window.h (struct window): Remove unused 'last_mark_x' and
1313 'last_mark_y' fields. Rename 'mini_p' field to 'mini',
1314 change it's type from Lisp_Object to bitfield.
1315 Change type of 'force_start', 'optional_new_start',
1316 'last_had_star', 'update_mode_line' and 'start_at_line_beg'
1317 fields from Lisp_Object to bitfield. Adjust users accordingly.
1318
ca34e0be
PE
13192012-05-31 Paul Eggert <eggert@cs.ucla.edu>
1320
1321 Pacify gcc -Wdouble-precision when using Xaw.
1322 * xterm.c (xaw_jump_callback, x_set_toolkit_scroll_bar_thumb)
1323 [HAVE_X_WINDOWS && USE_TOOLKIT_SCROLL_BARS && !USE_MOTIF && !USE_GTK]:
1324 Use 'float' consistently, rather than 'float' in most places
1325 and 'double' in a couple of places.
1326
efc00ab1 13272012-05-31 Eli Zaretskii <eliz@gnu.org>
d5fd2c54
EZ
1328
1329 * xdisp.c (handle_stop): Detect whether we have overlay strings
1330 loaded by testing it->current.overlay_string_index to be
1331 non-negative, instead of checking whether n_overlay_strings is
1332 positive. (Bug#11587)
1333
efc00ab1 13342012-05-31 Chong Yidong <cyd@gnu.org>
353c87f6
CY
1335
1336 * keymap.c (describe_map_tree): Revert 2011-07-07 change (Bug#1169).
1337
1338 * doc.c (Fsubstitute_command_keys): Doc fix.
1339
efc00ab1 13402012-05-31 Eli Zaretskii <eliz@gnu.org>
a02ae4e5
EZ
1341
1342 * search.c (search_buffer): Remove calls to
1343 r_alloc_inhibit_buffer_relocation, as it is now called by
1344 maybe_unify_char, which was the cause of relocation of buffer text
1345 in bug#11519.
1346
efc00ab1 13472012-05-31 Eli Zaretskii <eliz@gnu.org>
291d430f
EZ
1348
1349 * charset.c (maybe_unify_char): Inhibit relocation of buffer text
1350 for the duration of call to load_charset, to avoid problems with
1351 callers of maybe_unify_char that access buffer text through C
1352 pointers.
1353
1354 * ralloc.c (r_alloc_inhibit_buffer_relocation): Increment and
1355 decrement the inhibition flag, instead of just setting or
1356 resetting it.
1357
ba93a187
PE
13582012-05-31 Paul Eggert <eggert@cs.ucla.edu>
1359
1360 Remove obsolete '#define static' cruft.
1361 * s/hpux10-20.h (_FILE_OFFSET_BITS): Don't #undef.
1362 This #undef was "temporary" in 2000; it is no longer needed
1363 now that '#define static' has gone away.
1364 * xfns.c, xterm.h (gray_bitmap_width, gray_bitmap_height)
1365 (gray_bitmap_bits): Remove; no longer needed.
1366 All uses replaced with definiens.
1367 * xterm.c: Include "bitmaps/gray.xbm".
1368
9e4bf381
PE
13692012-05-30 Paul Eggert <eggert@cs.ucla.edu>
1370
1371 Clean up __executable_start, monstartup when --enable-profiling.
1372 The following changes affect the code only when profiling.
1373 * dispnew.c (__executable_start): Rename from safe_bcopy.
1374 Define only on platforms that need it.
1375 * emacs.c: Include <sys/gmon.h> when profiling.
1376 (_mcleanup): Remove decl, since <sys/gmon.h> does it now.
1377 (__executable_start): Remove decl, since lisp.h does it now.
1378 (safe_bcopy): Remove decl; no longer has that name.
1379 (main): Coalesce #if into single bit of code, for simplicity.
1380 Cast pointers to uintptr_t, since standard libraries want integers
1381 and not pointers.
1382 * lisp.h (__executable_start): New decl.
1383
32d72c2f
GM
13842012-05-31 Glenn Morris <rgm@gnu.org>
1385
1386 * image.c (Fimagemagick_types): Doc fix.
1387
baac5bc7
JM
13882012-05-30 Jim Meyering <meyering@redhat.com>
1389
1390 * callproc.c (Fcall_process_region): Include directory component
1391 in mkstemp error message (Bug#11586).
1392
72cb32cf
PE
13932012-05-30 Paul Eggert <eggert@cs.ucla.edu>
1394
1395 * alloc.c, lisp.h (make_pure_vector): Now static.
1396
61b108cc
SM
13972012-05-30 Stefan Monnier <monnier@iro.umontreal.ca>
1398
1399 * eval.c (Fdefun, Fdefmacro, Vmacro_declaration_function):
1400 Move to byte-run.el.
1401 (Fautoload): Do the hash-doc more carefully.
1402 * data.c (Fdefalias): Purify definition, except for keymaps.
1403 (Qdefun): Move from eval.c.
1404 * lisp.h (Qdefun): Remove.
1405 * lread.c (read1): Tiny simplification.
1406
471fe23d
TN
14072012-05-29 Troels Nielsen <bn.troels@gmail.com>
1408
934f3f58 1409 Do not create empty overlays with the evaporate property (Bug#9642).
471fe23d
TN
1410 * buffer.c (Fmove_overlay): Reinstate the earlier fix for
1411 Bug#9642, but explicitly check that the buffer the overlay would
1412 be moved to is live and rearrange lines to make sure that errors
1413 will not put the overlay in an inconsistent state.
1414 (Fdelete_overlay): Cosmetics.
1415
85d0efd1
EZ
14162012-05-28 Eli Zaretskii <eliz@gnu.org>
1417
1418 * w32term.c (my_bring_window_to_top): New function.
1419 (x_raise_frame): Use handle returned by DeferWindowPos, which
61b108cc
SM
1420 could be different from the original one.
1421 Call my_bring_window_to_top instead of my_set_foreground_window.
85d0efd1
EZ
1422 (Bug#11513)
1423
1424 * w32fns.c (w32_wnd_proc): Accept and process WM_EMACS_BRINGTOTOP
1425 by calling BringWindowToTop.
1426
1427 * w32term.h (WM_EMACS_BRINGTOTOP): New message.
1428 (WM_EMACS_END): Increase by one.
1429
da92a98c
PE
14302012-05-28 Paul Eggert <eggert@cs.ucla.edu>
1431
1432 * bidi.c (bidi_mirror_char): Put eassert before conversion to int.
1433 This avoids undefined behavior that might cause the eassert
1434 to not catch an out-of-range value.
1435
74d1f848
JB
14362012-05-28 Juanma Barranquero <lekktu@gmail.com>
1437
1438 * makefile.w32-in ($(BLD)/w32inevt.$(O), $(BLD)/w32console.$(O)):
1439 Update dependencies.
1440
9e1a06fc
EZ
14412012-05-27 Eli Zaretskii <eliz@gnu.org>
1442
1443 * bidi.c (bidi_mirror_char): Fix last change.
1444
f3dd7312
AS
14452012-05-27 Andreas Schwab <schwab@linux-m68k.org>
1446
1447 * unexmacosx.c (copy_data_segment): Truncate after 16 characters
1448 when referring to sectname field in printf format.
1449
81899c91
PE
14502012-05-27 Paul Eggert <eggert@cs.ucla.edu>
1451
57b81a9f
PE
1452 * lisp.h [REL_ALLOC]: Omit duplicate prototypes.
1453 Only r_alloc_inhibit_buffer_relocation needed to be added;
1454 the others were already declared.
1455
81899c91
PE
1456 * bidi.c (bidi_mirror_char): Don't possibly truncate the integer
1457 before checking whether it's out of range. Put the check inside
1458 eassert. See
1459 <http://lists.gnu.org/archive/html/emacs-devel/2012-05/msg00485.html>.
1460
33017faf 14612012-05-27 Ken Brown <kbrown@cornell.edu>
2f9b9adb
KB
1462
1463 * callproc.c (Fcall_process): Restore a line that was accidentally
1464 commented out in the 2011-02-13 change (bug#11547).
1465
33017faf 14662012-05-27 Eli Zaretskii <eliz@gnu.org>
52c55cc7
EZ
1467
1468 * lisp.h [REL_ALLOC]: Add prototypes for external functions
1469 defined on ralloc.c.
1470
1471 * buffer.c [REL_ALLOC]: Remove prototypes of
1472 r_alloc_reset_variable, r_alloc, r_re_alloc, and r_alloc_free,
1473 they are now on lisp.h.
1474
1475 * ralloc.c (r_alloc_inhibit_buffer_relocation): New function.
1476
1477 * search.c (search_buffer): Use it to inhibit relocation of buffer
1478 text while re_search_2 is doing its job, because re_search_2 is
1479 passed C pointers to buffer text. (Bug#11519)
1480
23415acf
EZ
1481 * msdos.c (internal_terminal_init) <Vwindow_system_version>:
1482 Update value to 24.
1483
44e27368
EZ
1484 * xdisp.c (move_it_to): Under MOVE_TO_Y, when restoring iterator
1485 state after an additional call to move_it_in_display_line_to, keep
1486 the values of it->max_ascent and it->max_descent found for the
1487 entire line.
1488 (pos_visible_p): Revert the comparison against bottom_y to what it
1489 was in revid eliz@gnu.org-20120513182235-4p6386j761ld0nwb.
1490 (Bug#11464)
1491
c1892f11
PE
14922012-05-26 Paul Eggert <eggert@cs.ucla.edu>
1493
1494 Fix coding-related core dumps with gcc -ftrapv.
1495 The code was computing A - B, where A and B are pointers, and B is
1496 random garbage. This can lead to core dumps on platforms that
1497 have special pointer registers, and it also leads to core dumps on
1498 x86-64 when compiled with gcc -ftrapv. The fix is to compute
1499 A - B only when B is initialized properly.
1500 * coding.c (coding_set_source, coding_set_destination): Return void.
1501 (coding_change_source, coding_change_destinations): New functions,
1502 with the old behaviors of coding_set_source and coding_set_destination.
1503 All callers that need an offset changed to use these new functions.
1504
eb7afdad
GM
15052012-05-26 Glenn Morris <rgm@gnu.org>
1506
1507 * nsterm.m (ns_init_paths): Don't mess with INFOPATH. (Bug#2791)
1508
f12fdf02
EZ
15092012-05-26 Eli Zaretskii <eliz@gnu.org>
1510
53a63be6 1511 Extend mouse support on W32 text-mode console.
61b108cc
SM
1512 * xdisp.c (draw_row_with_mouse_face):
1513 Call tty_draw_row_with_mouse_face for WINDOWSNT as well.
eb3f6f01 1514
eb3f6f01 1515 * w32console.c: Include window.h.
61b108cc
SM
1516 (w32con_write_glyphs_with_face, tty_draw_row_with_mouse_face):
1517 New functions.
eb3f6f01
EZ
1518 (initialize_w32_display): Initialize mouse-highlight data.
1519
53a63be6
EZ
1520 * w32inevt.c: Include termchar.h and window.h.
1521 (do_mouse_event): Support mouse-autoselect-window. When the mouse
1522 moves, call note_mouse_highlight. If help_echo changed, call
1523 gen_help_event to produce help-echo message in the echo area.
1524 Call clear_mouse_face if mouse_face_hidden is set in the mouse
1525 highlight info.
1526
4cfd81f6
PE
15272012-05-26 Paul Eggert <eggert@cs.ucla.edu>
1528
1529 * lread.c (read1): Simplify slightly to avoid an overflow warning
1530 with GCC 4.7.0 on x86-64.
1531
4446092a
EZ
15322012-05-26 Eli Zaretskii <eliz@gnu.org>
1533
1534 * bidi.c (bidi_mirror_char): Revert last change: an int is
1535 definitely wide enough here.
1536
42b2a986 15372012-05-25 Paul Eggert <eggert@cs.ucla.edu>
3164aeac 1538
42b2a986 1539 Fix integer width and related bugs (Bug#9874).
eb106a49 1540 * alloc.c (pure_bytes_used_lisp, pure_bytes_used_non_lisp):
d311d28c
PE
1541 (allocate_vectorlike, buffer_memory_full, struct sdata, SDATA_SIZE)
1542 (string_bytes, check_sblock, allocate_string_data):
1543 (compact_small_strings, Fmake_bool_vector, make_string)
1544 (make_unibyte_string, make_multibyte_string)
1545 (make_string_from_bytes, make_specified_string)
1546 (allocate_vectorlike, Fmake_vector, find_string_data_in_pure)
1547 (make_pure_string, make_pure_c_string, make_pure_vector, Fpurecopy)
1548 (mark_vectorlike):
1549 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1550 (allocate_pseudovector):
1551 Use int, not EMACS_INT, where int is wide enough.
1552 (inhibit_garbage_collection, Fgarbage_collect):
1553 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1554 * bidi.c (bidi_mirror_char): Use EMACS_INT, not int, where
1555 int might not be wide enough.
1556 (bidi_cache_search, bidi_cache_find, bidi_init_it)
1557 (bidi_count_bytes, bidi_char_at_pos, bidi_fetch_char)
1558 (bidi_at_paragraph_end, bidi_find_paragraph_start)
1559 (bidi_paragraph_init, bidi_resolve_explicit, bidi_resolve_weak)
1560 (bidi_level_of_next_char, bidi_move_to_visually_next):
1561 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1562 * buffer.c (copy_overlays, Fgenerate_new_buffer_name)
1563 (Fkill_buffer, Fset_buffer_major_mode)
1564 (advance_to_char_boundary, Fbuffer_swap_text)
1565 (Fset_buffer_multibyte, overlays_at, overlays_in)
1566 (overlay_touches_p, struct sortvec, record_overlay_string)
1567 (overlay_strings, recenter_overlay_lists)
1568 (adjust_overlays_for_insert, adjust_overlays_for_delete)
1569 (fix_start_end_in_overlays, fix_overlays_before, modify_overlay)
1570 (Fmove_overlay, Fnext_overlay_change, Fprevious_overlay_change)
1571 (Foverlay_recenter, last_overlay_modification_hooks_used)
1572 (report_overlay_modification, evaporate_overlays, enlarge_buffer_text):
1573 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
977b0e45
PE
1574 (validate_region): Omit unnecessary test for b <= e,
1575 since that's guaranteed by the previous test.
d311d28c
PE
1576 (adjust_overlays_for_delete): Avoid pos + length overflow.
1577 (Fmove_overlay, Fdelete_overlay, add_overlay_mod_hooklist)
1578 (report_overlay_modification):
1579 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1580 (Foverlays_at, Fnext_overlay_change, Fprevious_overlay_change):
1581 Omit pointer cast, which isn't needed anyway, and doesn't work
1582 after the EMACS_INT -> ptrdiff_t change.
02481186 1583 (Fmove_overlay): Clip BEG and END to ptrdiff_t to avoid overflow.
d311d28c
PE
1584 * buffer.h: Adjust decls to match defn changes elsewhere.
1585 (struct buffer_text, struct buffer):
1586 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1587 Use EMACS_INT, not int, where int might not be wide enough.
39b5db3b
PE
1588 * bytecode.c (unmark_byte_stack, exec_byte_code): Use ptrdiff_t,
1589 not int, to avoid needless 32-bit limit on 64-bit hosts.
1590 (exec_byte_code): Use tighter memory-full test, one that checks
1591 for alloca overflow. Don't compute the address of the object just
1592 before an array, as that's not portable. Use EMACS_INT, not
1593 ptrdiff_t or int, where ptrdiff_t or int might not be wide enough.
d311d28c
PE
1594 * callint.c (Fcall_interactively):
1595 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1596 * callproc.c (call_process_kill, Fcall_process):
1597 Don't assume pid_t fits into an Emacs fixnum.
1598 (call_process_cleanup, Fcall_process, child_setup):
1599 Don't assume pid_t fits into int.
1600 (call_process_cleanup, Fcall_process, delete_temp_file)
1601 (Fcall_process_region):
1602 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1603 (Fcall_process): Simplify handling of volatile integers.
1604 Use int, not EMACS_INT, where int will do.
1605 * casefiddle.c (casify_object, casify_region, operate_on_word)
1606 (Fupcase_word, Fdowncase_word, Fcapitalize_word):
1607 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1608 (casify_object): Avoid integer overflow when overallocating buffer.
1609 * casetab.c (set_identity, shuffle): Prefer int to unsigned when
45c2afd6 1610 either works. Use lint_assume to convince GCC 4.6.1 that it's OK.
d311d28c
PE
1611 * category.c (Fchar_category_set): Don't assume fixnum fits in int.
1612 * category.h (CATEGORYP): Don't assume arg is nonnegative.
1613 * ccl.c (GET_CCL_INT): Remove; no longer needed, since the
1614 integers are now checked earlier. All uses replaced with XINT.
1615 (ccl_driver):
1616 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1617 For CCL_MapSingle, check that content and value are in int range.
c801946a
PE
1618 (ccl_driver, Fregister_code_conversion_map):
1619 Check that Vcode_version_map_vector is a vector.
d311d28c
PE
1620 (resolve_symbol_ccl_program): Check that vector header is in range.
1621 Always copy the vector, so that we can check its contents reliably
1622 now rather than having to recheck each instruction as it's being
1623 executed. Check that vector words fit in 'int'.
1624 (ccl_get_compiled_code, Fregister_ccl_program)
1625 (Fregister_code_conversion_map): Use ptrdiff_t, not int, for
1626 program indexes, to avoid needless 32-bit limit on 64-bit hosts.
1627 (Fccl_execute, Fccl_execute_on_string): Check that initial reg
1628 contents are in range.
1629 (Fccl_execute_on_string): Check that status is in range.
1630 * ccl.h (struct ccl_program.idx): Now ptrdiff_t, not int.
1631 * character.c (char_resolve_modifier_mask, Fchar_resolve_modifiers):
1632 Accept and return EMACS_INT, not int, because callers can pass values
1633 out of 'int' range.
1634 (c_string_width, strwidth, lisp_string_width, chars_in_text)
1635 (multibyte_chars_in_text, parse_str_as_multibyte)
1636 (str_as_multibyte, count_size_as_multibyte, str_to_multibyte)
1637 (str_as_unibyte, str_to_unibyte, string_count_byte8)
1638 (string_escape_byte8, Fget_byte):
1639 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
a14e1568 1640 (Funibyte_string): Use CHECK_RANGED_INTEGER, not CHECK_NATNUM, to
d311d28c
PE
1641 avoid mishandling large integers.
1642 * character.h: Adjust decls to match defn changes elsewhere.
1643 * charset.c (load_charset_map_from_file, find_charsets_in_text)
1644 (Ffind_charset_region):
1645 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1646 (load_charset_map_from_file): Redo idx calculation to avoid overflow.
1647 (load_charset_map_from_vector, Fdefine_charset_internal):
3c7649c1 1648 Don't assume fixnum fits in int.
d311d28c
PE
1649 (load_charset_map_from_vector, Fmap_charset_chars):
1650 Remove now-unnecessary CHECK_NATNUMs.
1651 (Fdefine_charset_internal): Check ranges here, more carefully.
3c7649c1
PE
1652 Don't rely on undefined behavior with signed left shift overflow.
1653 Don't assume unsigned int fits into fixnum, or that fixnum fits
1654 into unsigned int. Don't require max_code to be a valid fixnum;
1655 that's not true for gb10830 4-byte on a 32-bit host. Allow
1656 invalid_code to be a cons, for the same reason. Require code_offset
1657 to be a character. Avoid int overflow if max_char is close
1658 to INT_MAX.
1659 (CODE_POINT_TO_INDEX): On 32-bit hosts, return int, not unsigned;
1660 this is intended anyway and avoids some undefined behavior.
1661 (load_charset_map): Pass unsigned, not int, as 2nd arg of
1662 INDEX_TO_CODE_POINT, as that's what it expects.
1663 (Funify_charset, encode_char): Don't stuff unsigned vals into int vars.
60ad3eab
PE
1664 * charset.h (DECODE_CHAR): Return int, not unsigned;
1665 this is what was intended anyway, and it avoids undefined behavior.
1666 (CHARSET_OFFSET): Remove unused macro, instead of fixing its
1667 integer-overflow issues.
1668 (ENCODE_CHAR): Return unsigned on all hosts, not just on 32-bit hosts.
1669 Formerly, it returned EMACS_INT on 64-bit hosts in the common case
1670 where the argument is EMACS_INT, and this behavior is not intended.
d311d28c
PE
1671 * chartab.c (Fmake_char_table, Fset_char_table_range)
1672 (uniprop_get_decoder, uniprop_get_encoder):
1673 Don't assume fixnum fits in int.
1674 * cmds.c (move_point): New function, that does the gist of
1675 Fforward_char and Fbackward_char, but does so while checking
1676 for integer overflow more accurately.
c96e5d6a 1677 (Fforward_char, Fbackward_char): Use it.
d311d28c
PE
1678 (Fforward_line, Fend_of_line, internal_self_insert)
1679 (internal_self_insert):
1680 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1681 Fix a FIXME, by checking for integer overflow when calculating
1682 target_clm and actual_clm.
1683 * coding.c (detect_coding_XXX, encode_coding_XXX, CODING_DECODE_CHAR)
8f50130c 1684 (CODING_ENCODE_CHAR, CODING_CHAR_CHARSET, CODING_CHAR_CHARSET_P)
d311d28c
PE
1685 (ASSURE_DESTINATION, coding_alloc_by_realloc)
1686 (coding_alloc_by_making_gap, alloc_destination)
1687 (detect_coding_utf_8, encode_coding_utf_8, decode_coding_utf_16)
1688 (encode_coding_utf_16, detect_coding_emacs_mule)
1689 (decode_coding_emacs_mule, encode_coding_emacs_mule)
1690 (detect_coding_iso_2022, decode_coding_iso_2022)
1691 (encode_invocation_designation, encode_designation_at_bol)
1692 (encode_coding_iso_2022, detect_coding_sjis, detect_coding_big5)
1693 (decode_coding_sjis, decode_coding_big5, encode_coding_sjis)
1694 (encode_coding_big5, detect_coding_ccl, decode_coding_ccl)
1695 (encode_coding_ccl, encode_coding_raw_text)
1696 (detect_coding_charset, decode_coding_charset)
1697 (encode_coding_charset, detect_eol, decode_eol, produce_chars)
1698 (produce_composition, produce_charset, produce_annotation)
1699 (decode_coding, handle_composition_annotation)
1700 (handle_charset_annotation, consume_chars, decode_coding_gap)
1701 (decode_coding_object, encode_coding_object, detect_coding_system)
1702 (Ffind_coding_systems_region_internal, Fcheck_coding_systems_region)
1703 (code_convert_region, code_convert_string)
8f50130c
PE
1704 (Fdefine_coding_system_internal)
1705 (coding_set_source, coding_set_destination):
d311d28c
PE
1706 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1707 (setup_iso_safe_charsets, consume_chars, Funencodable_char_position)
1708 (Fdefine_coding_system_internal):
1709 Don't assume fixnums fit in int.
1710 (decode_coding_gap, decode_coding_object, encode_coding_object)
5895d7b9 1711 (Fread_coding_system, Fdetect_coding_region)
2c6a9faa
PE
1712 (Funencodable_char_position, Fcheck_coding_systems_region)
1713 (get_translation, handle_composition_annotation, consume_chars):
d311d28c 1714 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
977b0e45 1715 (consume_chars): Rewrite to not calculate an address outside buffer.
d311d28c 1716 (Ffind_operation_coding_system): NATNUMP can eval its arg twice.
7b09a37a 1717 Don't access memory outside of the args array.
d311d28c 1718 (Fdefine_coding_system_internal): Check for charset-id overflow.
47664caa
PE
1719 (ENCODE_ISO_CHARACTER): Use unsigned, not int, to store the unsigned
1720 result of ENCODE_CHAR.
d311d28c
PE
1721 * coding.h: Adjust decls to match defn changes elsewhere.
1722 (struct coding_system):
1723 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1724 * composite.c (get_composition_id, find_composition)
1725 (run_composition_function, update_compositions)
1726 (compose_text, composition_gstring_put_cache)
1727 (composition_gstring_p, composition_gstring_width)
1728 (fill_gstring_header, fill_gstring_body, autocmp_chars)
1729 (composition_compute_stop_pos, composition_reseat_it)
1730 (composition_update_it, struct position_record)
1731 (find_automatic_composition, composition_adjust_point)
1732 (Fcomposition_get_gstring, Ffind_composition_internal):
1733 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1734 (update_compositions):
1735 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1736 * composite.h: Adjust decls to match defn changes elsewhere.
1737 (struct composition):
1738 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1739 * data.c (let_shadows_buffer_binding_p, let_shadows_global_binding_p):
1740 Do not attempt to compute the address of the object just before a
1741 buffer; this is not portable.
1742 (Faref, Faset):
1743 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1744 (Faset): Use int, not EMACS_INT, where int is wide enough.
1745 (Fstring_to_number): Don't assume fixnums fit in int.
1746 (Frem): Don't assume arg is nonnegative.
1747 * dbusbind.c (xd_append_arg): Check for integers out of range.
1748 (Fdbus_call_method): Don't overflow the timeout int.
42b2a986 1749 (extract_signed, extract_unsigned): New functions.
243e0530
PE
1750 (XD_CHECK_DBUS_SERIAL): Remove; superseded by extract_unsigned.
1751 (xd_get_connection_references): Return ptrdiff_t, not int.
1752 All uses changed.
1753 (xd_signature, xd_append_arg, xd_retrieve_arg, Fdbus_message_internal)
1754 (xd_read_message_1):
1755 Use int, not unsigned, where the dbus API uses int.
1756 (Fdbus_message_internal): Don't overflow mtype.
1757 (syms_of_dbusbind): Allocate right-sized buffer for integers.
d311d28c
PE
1758 * dired.c (directory_files_internal, file_name_completion, scmp)
1759 (file_name_completion_stat):
1760 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1761 (file_name_completion): Don't overflow matchcount.
1762 (file_name_completion_stat): Use SAFE_ALLOCA, not alloca.
1763 * dispextern.h: Adjust decls to match defn changes elsewhere.
1764 (struct text_pos, struct glyph, struct bidi_saved_info)
1765 (struct bidi_string_data, struct bidi_it, struct composition_it)
1766 (struct it):
1767 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1768 (struct display_pos, struct composition_it, struct it):
1769 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1770 * dispnew.c (increment_matrix_positions)
1771 (increment_row_positions, mode_line_string)
1772 (marginal_area_string):
1773 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
54e1617f 1774 (change_frame_size_1, Fredisplay, Fframe_or_buffer_changed_p):
d311d28c
PE
1775 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1776 (duration_to_sec_usec): New function, to check for overflow better.
1777 (Fsleep_for, sit_for): Use it.
1778 * doc.c (get_doc_string, store_function_docstring):
1779 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1780 (get_doc_string, Fsnarf_documentation):
1781 Use int, not EMACS_INT, where int is wide enough.
1782 (get_doc_string):
1783 Use SAFE_ALLOCA, not alloca.
1784 Check for overflow when converting EMACS_INT to off_t.
1785 * doprnt.c (doprnt):
1786 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1787 * editfns.c (init_editfns, Fuser_uid, Fuser_real_uid):
1788 Don't assume uid_t fits into fixnum.
1789 (buildmark, Fgoto_char, overlays_around, find_field, Fdelete_field)
1790 (Ffield_string, Ffield_string_no_properties, Ffield_beginning)
1791 (Ffield_end, Fconstrain_to_field, Fline_beginning_position)
1792 (Fline_end_position, Fprevious_char, Fchar_after, Fchar_before)
1793 (general_insert_function)
1794 (Finsert_char, make_buffer_string, make_buffer_string_both)
1795 (update_buffer_properties, Fbuffer_substring)
1796 (Fbuffer_substring_no_properties, Fcompare_buffer_substrings)
1797 (Fsubst_char_in_region, check_translation)
1798 (Ftranslate_region_internal, save_restriction_restore, Fformat)
1799 (transpose_markers, Ftranspose_regions):
1800 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1801 (clip_to_bounds): Move to lisp.h as an inline function).
1802 (Fconstrain_to_field): Don't assume integers are nonnegative.
1803 (Fline_beginning_position, Fsave_excursion, Fsave_current_buffer):
1804 (Fsubst_char_in_region, Fsave_restriction):
1805 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1806 (Femacs_pid): Don't assume pid_t fits into fixnum.
1807 (lo_time): Use int, not EMACS_INT, when int suffices.
1808 (lisp_time_argument): Check for usec out of range.
1809 (Fencode_time): Don't assume fixnum fits in int.
3f4eabd1
PE
1810 (Fuser_login_name, Fuser_full_name): Signal an error
1811 if a uid argument is out of range, rather than relying on
1812 undefined behavior.
c8d5c857
PE
1813 (Fformat_time_string): Remove now-unnecessary check.
1814 lisp_time_argument checks for out-of-range usec now.
243e0530 1815 Use ptrdiff_t, not size_t, where ptrdiff_t will do.
d311d28c
PE
1816 * emacs.c (gdb_valbits, gdb_gctypebits): Now int, not EMACS_INT.
1817 (gdb_data_seg_bits): Now uintptr_t, not EMACS_INT.
1818 (PVEC_FLAG, gdb_array_mark_flag): Now ptrdiff_t, not EMACS_INT.
1819 (init_cmdargs, Fdump_emacs):
1820 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1821 (Fkill_emacs): Don't assume fixnum fits in int; instead, take just
1822 the bottom (typically) 32 bits of the fixnum.
1823 * eval.c (specpdl_size, call_debugger):
1824 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1825 (when_entered_debugger, Fbacktrace_debug):
1826 Don't assume fixnum can fit in int.
1827 (Fdefvaralias, Fdefvar): Do not attempt to compute the address of
1828 the object just before a buffer; this is not portable.
1829 (FletX, Flet, Funwind_protect, do_autoload, Feval, funcall_lambda)
1830 (grow_specpdl, unbind_to):
1831 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1832 (Fapply, apply_lambda): Don't assume ptrdiff_t can hold fixnum.
1833 (grow_specpdl): Simplify allocation by using xpalloc.
856bbc81 1834 (Fprog1, Fprog2): Don't assume list length fits in int. Simplify.
d311d28c
PE
1835 * fileio.c (Ffind_file_name_handler, Fcopy_file, Frename_file)
1836 (Finsert_file_contents, Fwrite_region, Fdo_auto_save):
1837 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1838 (Ffind_file_name_handler, non_regular_inserted, Finsert_file_contents)
1839 (a_write, e_write):
1840 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1841 (Fcopy_file, non_regular_nbytes, read_non_regular)
1842 (Finsert_file_contents):
1843 Use int, not EMACS_INT, where int is wide enough.
1844 (READ_BUF_SIZE): Verify that it fits in int.
1845 (Finsert_file_contents): Check that counts are in proper range,
1846 rather than assuming fixnums fit into ptrdiff_t etc.
1847 Don't assume fixnums fit into int.
125b3835 1848 * floatfns.c (Fexpt): Avoid undefined signed * signed overflow.
5895d7b9
PE
1849 * fns.c (Fcompare_strings, Fstring_lessp, struct textprop_rec, concat)
1850 (string_char_byte_cache_charpos, string_char_byte_cache_bytepos)
d311d28c
PE
1851 (string_char_to_byte, string_byte_to_char)
1852 (string_make_multibyte, string_to_multibyte)
1853 (string_make_unibyte, Fstring_as_unibyte, Fstring_as_multibyte)
1854 (Fstring_to_unibyte, Fsubstring, Fsubstring_no_properties)
1855 (substring_both, Fdelete, internal_equal, Ffillarray)
1856 (Fclear_string, mapcar1)
1857 (Fbase64_encode_region, Fbase64_encode_string, base64_encode_1)
1858 (Fbase64_decode_region, Fbase64_decode_string, base64_decode_1)
1859 (larger_vector, make_hash_table, maybe_resize_hash_table)
1860 (hash_lookup, hash_remove_from_table, hash_clear, sweep_weak_table)
1861 (Fmaphash, secure_hash):
1862 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1863 (concat): Check for string index and length overflow.
1864 (Fmapconcat): Don't assume fixnums fit into ptrdiff_t.
1865 (Frequire):
1866 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1867 (larger_vector): New API (vec, incr_min, size_max) replaces old
1868 one (vec, new_size, init). This catches size overflow.
1869 INIT was removed because it was always Qnil.
1870 All callers changed.
1871 (INDEX_SIZE_BOUND): New macro, which calculates more precisely
1872 the upper bound on a hash table index size.
1873 (make_hash_table, maybe_resize_hash_table): Use it.
1874 (secure_hash): Computer start_byte and end_byte only after
1875 they're known to be in ptrdiff_t range.
1876 * font.c (font_intern_prop, font_at, font_range, Ffont_shape_gstring)
1877 (Ffont_get_glyphs, Ffont_at):
1878 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1879 (font_style_to_value, font_prop_validate_style, font_expand_wildcards)
1880 (Flist_fonts, Fopen_font):
1881 Don't assume fixnum can fit in int.
1882 (check_gstring): Don't assume index can fit in int.
1883 (font_match_p): Check that fixnum is a character, not a nonnegative
1884 fixnum, since the later code needs to stuff it into an int.
1885 (font_find_for_lface): Use SAFE_ALLOCA_LISP, not alloca.
1886 (font_fill_lglyph_metrics): Use unsigned, not EMACS_INT, to avoid
1887 conversion overflow issues.
1888 (Fopen_font): Check for integer out of range.
1889 (Ffont_get_glyphs): Don't assume index can fit in int.
1890 * font.h: Adjust decls to match defn changes elsewhere.
1891 * fontset.c (reorder_font_vector): Redo score calculation to avoid
1892 integer overflow.
1893 (num_auto_fontsets, fontset_from_font): Use ptrdiff_t, not
1894 printmax_t, where ptrdiff_t is wide enough.
1895 (Finternal_char_font):
1896 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1897 * frame.c (Fset_mouse_position, Fset_mouse_pixel_position)
1898 (Fset_frame_height, Fset_frame_width, Fset_frame_size)
1899 (Fset_frame_position, x_set_frame_parameters)
1900 (x_set_line_spacing, x_set_border_width)
1901 (x_set_internal_border_width, x_set_alpha, x_figure_window_size):
1902 Check that fixnums are in proper range for system types.
1903 (frame_name_fnn_p, Fframe_parameter, Fmodify_frame_parameters):
1904 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1905 (Fmodify_frame_parameters): Don't assume fixnum fits in int.
1906 Use SAFE_ALLOCA_LISP, not alloca.
1907 * frame.h (struct frame): Use intptr_t, not EMACS_INT, where
1908 intptr_t is wide enough.
1909 * fringe.c (lookup_fringe_bitmap, get_logical_fringe_bitmap)
1910 (Fdefine_fringe_bitmap): Don't assume fixnum fits in int.
1911 (Ffringe_bitmaps_at_pos): Don't assume index fits in int.
1912 Check for fixnum out of range.
1913 * ftfont.c (ftfont_list): Don't assume index fits in int.
1914 Check that fixnums are in proper range for system types.
1915 (ftfont_shape_by_flt):
1916 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
d311d28c
PE
1917 * gnutls.c (emacs_gnutls_write, emacs_gnutls_read):
1918 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1919 (Fgnutls_error_fatalp, Fgnutls_error_string, Fgnutls_boot):
1920 Check that fixnums are in proper range for system types.
1921 * gnutls.h: Adjust decls to match defn changes elsewhere.
1922 * gtkutil.c (xg_dialog_run):
1923 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1924 (update_frame_tool_bar):
1925 Check that fixnums are in proper range for system types.
1926 * image.c (parse_image_spec): Redo count calculation to avoid overflow.
5895d7b9 1927 (lookup_image): Check that fixnums are in range for system types.
d311d28c
PE
1928 * indent.c (last_known_column, last_known_column_point):
1929 (current_column_bol_cache):
1930 (skip_invisible, current_column, check_display_width):
1931 (check_display_width, scan_for_column, current_column_1)
1932 (Findent_to, Fcurrent_indentation, position_indentation)
1933 (indented_beyond_p, Fmove_to_column, compute_motion):
1934 (Fcompute_motion, Fvertical_motion):
1935 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1936 (last_known_column_modified): Use EMACS_INT, not int.
1937 (check_display_width):
1938 (Fcompute_motion):
1939 Check that fixnums and floats are in proper range for system types.
1940 (compute_motion): Don't assume index or fixnum fits in int.
1941 (compute_motion, Fcompute_motion):
1942 Use int, not EMACS_INT, when it is wide enough.
1943 (vmotion): Omit local var start_hpos that is always 0; that way
1944 we don't need to worry about overflow in expressions involving it.
1945 * indent.h: Adjust decls to match defn changes elsewhere.
1946 (struct position):
1947 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1948 Use int, not EMACS_INT, where int is wide enough.
1949 Remove unused members ovstring_chars_done and tab_offset;
1950 all uses removed.
1951 * insdel.c (move_gap, move_gap_both, gap_left, gap_right)
1952 (adjust_markers_for_delete, adjust_markers_for_insert, adjust_point)
1953 (adjust_markers_for_replace, make_gap_larger, make_gap_smaller)
1954 (make_gap, copy_text, insert, insert_and_inherit)
1955 (insert_before_markers, insert_before_markers_and_inherit)
1956 (insert_1, count_combining_before, count_combining_after)
1957 (insert_1_both, insert_from_string)
1958 (insert_from_string_before_markers, insert_from_string_1)
1959 (insert_from_gap, insert_from_buffer, insert_from_buffer_1)
1960 (adjust_after_replace, adjust_after_insert, replace_range)
1961 (replace_range_2, del_range, del_range_1, del_range_byte)
1962 (del_range_both, del_range_2, modify_region)
1963 (prepare_to_modify_buffer, signal_before_change)
1964 (signal_after_change, Fcombine_after_change_execute):
1965 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1966 * intervals.c (traverse_intervals, rotate_right, rotate_left)
1967 (balance_an_interval, split_interval_right, split_interval_left)
1968 (find_interval, next_interval, update_interval)
1969 (adjust_intervals_for_insertion, delete_node, delete_interval)
1970 (interval_deletion_adjustment, adjust_intervals_for_deletion)
1971 (static_offset_intervals, offset_intervals)
1972 (merge_interval_right, merge_interval_left, make_new_interval)
1973 (graft_intervals_into_buffer, temp_set_point_both)
1974 (temp_set_point, set_point, adjust_for_invis_intang)
1975 (set_point_both, move_if_not_intangible, get_property_and_range)
1976 (get_local_map, copy_intervals, copy_intervals_to_string)
1977 (compare_string_intervals, set_intervals_multibyte_1):
1978 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1979 * intervals.h: Adjust decls to match defn changes elsewhere.
1980 (struct interval):
1981 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1982 * keyboard.c (this_command_key_count, this_single_command_key_start)
1983 (before_command_key_count, before_command_echo_length, echo_now)
1984 (echo_length, recursive_edit_1, Frecursive_edit, Ftrack_mouse)
1985 (command_loop_1, safe_run_hooks, read_char, timer_check_2)
1986 (menu_item_eval_property, read_key_sequence, Fread_key_sequence)
1987 (Fread_key_sequence_vector, Fexecute_extended_command, Fsuspend_emacs):
1988 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1989 (last_non_minibuf_size, last_point_position, echo_truncate)
1990 (command_loop_1, adjust_point_for_property, read_char, gen_help_event)
1991 (make_lispy_position, make_lispy_event, parse_modifiers_uncached)
1992 (parse_modifiers, modify_event_symbol, Fexecute_extended_command)
1993 (stuff_buffered_input):
1994 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1995 (last_auto_save, command_loop_1, read_char):
1996 Use EMACS_INT, not int, to avoid integer overflow.
1997 (record_char): Avoid overflow in total_keys computation.
1998 (parse_modifiers_uncached): Redo index calculation to avoid overflow.
1999 * keyboard.h: Adjust decls to match defn changes elsewhere.
2000 * keymap.c (Fdefine_key, Fcurrent_active_maps, accessible_keymaps_1)
2001 (Fkey_description, Fdescribe_vector, Flookup_key):
2002 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2003 (click_position): New function, to check that positions are in range.
2004 (Fcurrent_active_maps):
2005 (describe_command):
2006 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2007 (Faccessible_keymaps, Fkey_description):
2008 (preferred_sequence_p):
2009 Don't assume fixnum can fit into int.
2010 (Fkey_description): Use SAFE_ALLOCA_LISP, not alloca.
2011 Check for integer overflow in size calculations.
2012 (Ftext_char_description): Use CHECK_CHARACTER, not CHECK_NUMBER, to
2013 avoid mishandling large integers.
2014 * lisp.h: Adjust decls to match defn changes elsewhere.
2015 (ARRAY_MARK_FLAG, PSEUDOVECTOR_FLAG, struct Lisp_String)
2016 (struct vectorlike_header, struct Lisp_Subr, struct Lisp_Hash_Table)
2017 (struct Lisp_Marker):
2018 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2019 (clip_to_bounds): Now an inline function, moved here from editfns.c.
d311d28c
PE
2020 (GLYPH_CODE_P): Check for overflow in system types, subsuming the
2021 need for GLYPH_CODE_CHAR_VALID_P and doing proper checking ourselves.
2022 All callers changed.
2023 (GLYPH_CODE_CHAR, GLYPH_CODE_FACE):
2024 Assume the arg has valid form, since it always does.
2025 (TYPE_RANGED_INTEGERP): Avoid bug when checking against a wide
2026 unsigned integer system type.
2027 (CHECK_RANGED_INTEGER, CHECK_TYPE_RANGED_INTEGER): New macros.
2028 (struct catchtag, specpdl_size, SPECPDL_INDEX, USE_SAFE_ALLOCA):
2029 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2030 (struct catchtag): Use EMACS_INT, not int, since it may be a fixnum.
2031 (duration_to_sec_usec): New decl.
2032 * lread.c (read_from_string_index, read_from_string_index_byte)
2033 (read_from_string_limit, readchar, unreadchar, openp)
2034 (read_internal_start, read1, oblookup):
2035 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2036 (Fload, readevalloop, Feval_buffer, Feval_region):
2037 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2038 (openp): Check for out-of-range argument to 'access'.
2039 (read1): Use int, not EMACS_INT, where int is wide enough.
2040 Don't assume fixnum fits into int.
6efdadfd 2041 Fix off-by-one error that can read outside a buffer.
1ab7b8ac
PE
2042 (read_filtered_event): Use duration_to_sec_usec
2043 to do proper overflow checking on durations.
d311d28c
PE
2044 * macros.c (Fstart_kbd_macro): Use xpalloc to check for overflow
2045 in size calculation.
2046 (Fexecute_kbd_macro):
2047 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2048 * marker.c (cached_charpos, cached_bytepos, CONSIDER)
2049 (byte_char_debug_check, buf_charpos_to_bytepos, verify_bytepos)
2050 (buf_bytepos_to_charpos, Fset_marker, set_marker_restricted)
2051 (set_marker_both, set_marker_restricted_both, marker_position)
2052 (marker_byte_position, Fbuffer_has_markers_at):
2053 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2054 (Fset_marker, set_marker_restricted): Don't assume fixnum fits in int.
61b108cc 2055 * menu.c (ensure_menu_items): Rename from grow_menu_items.
d311d28c
PE
2056 It now merely ensures that the menu is large enough, without
2057 necessarily growing it, as this avoids some integer overflow issues.
2058 All callers changed.
2059 (keymap_panes, parse_single_submenu, Fx_popup_menu):
2060 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2061 (parse_single_submenu, Fx_popup_menu): Don't assume fixnum fits in int.
2062 Use SAFE_ALLOCA_LISP, not alloca.
2063 (find_and_return_menu_selection): Avoid unnecessary casts of pointers
2064 to EMACS_INT. Check that fixnums are in proper range for system types.
2065 * minibuf.c (minibuf_prompt_width, string_to_object)
2066 (Fminibuffer_contents, Fminibuffer_contents_no_properties)
2067 (Fminibuffer_completion_contents, Ftry_completion, Fall_completions):
2068 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2069 (get_minibuffer, read_minibuf_unwind):
2070 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2071 (read_minibuf): Omit unnecessary arg BACKUP_N, which is always nil;
2072 this simplifies overflow checking. All callers changed.
2073 (read_minibuf, Fread_buffer, Ftry_completion, Fall_completions)
2074 (Ftest_completion):
2075 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2076 * nsfns.m (check_ns_display_info): Don't assume fixnum fits in long.
2077 (x_set_menu_bar_lines, x_set_tool_bar_lines, Fx_create_frame):
2078 Check that fixnums are in proper range for system types.
2079 (Fx_create_frame, Fx_show_tip):
2080 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2081 * nsfont.m (ns_findfonts, nsfont_list_family):
2082 Don't assume fixnum fits in long.
2083 * nsmenu.m (ns_update_menubar, ns_menu_show, ns_popup_dialog):
2084 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2085 (ns_update_menubar): Use intptr_t, not EMACS_INT, when intptr_t is
2086 wide enough.
17fdb222 2087 * nsselect.m (ns_get_local_selection, clean_local_selection_data):
d311d28c
PE
2088 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2089 * print.c (print_buffer_size, print_buffer_pos, print_buffer_pos_byte)
2090 (PRINTDECLARE, PRINTPREPARE):
2091 (strout, print_string):
2092 (print, print_preprocess, print_check_string_charset_prop)
2093 (print_object):
2094 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2095 (PRINTDECLARE):
2096 (temp_output_buffer_setup, Fprin1_to_string, print_object):
2097 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2098 (PRINTPREPARE): Use int, not ptrdiff_t, where int is wide enough.
d311d28c 2099 (printchar, strout): Use xpalloc to catch size calculation overflow.
0fd11aa5 2100 (Fexternal_debugging_output): Don't overflow EMACS_INT->int conversion.
d311d28c
PE
2101 (print_error_message): Use SAFE_ALLOCA, not alloca.
2102 (print_object): Use int, not EMACS_INT, where int is wide enough.
a8b7caa3
PE
2103 (print_depth, new_backquote_output, print_number_index):
2104 Use ptrdiff_t, not int, where int might not be wide enough.
d311d28c
PE
2105 * process.c (Fdelete_process): Don't assume pid fits into EMACS_INT.
2106 (Fset_process_window_size, Fformat_network_address)
2107 (get_lisp_to_sockaddr_size, set_socket_option, Fmake_network_process)
d44287d4 2108 (sigchld_handler):
d311d28c 2109 Check that fixnums are in proper range for system types.
d44287d4 2110 (Fsignal_process): Simplify by avoiding a goto.
d83cf4cc
PE
2111 Check for process-ids out of pid_t range rather than relying on
2112 undefined behavior.
e4d81efc 2113 (process_tick, update_tick): Use EMACS_INT, not int.
d311d28c
PE
2114 (Fformat_network_address, read_process_output, send_process)
2115 (Fprocess_send_region, status_notify):
2116 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2117 (Fformat_network_address, Fmake_serial_process, Fmake_network_process)
2118 (wait_reading_process_output, read_process_output, exec_sentinel):
2119 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2120 (conv_lisp_to_sockaddr): Don't assume fixnums fit into int.
2121 (Faccept_process_output): Use duration_to_sec_usec to do proper
2122 overflow checking on durations.
dde14581
PE
2123 (emacs_get_tty_pgrp, Fprocess_running_child_p, process_send_signal):
2124 Don't assume pid_t fits in int.
02481186
PE
2125 * process.h (struct Lisp_Process): Members tick and update_tick
2126 are now of type EMACS_INT, not int.
b62b53e8
PE
2127 * puresize.h (PURESIZE_RATIO): Shrink this to 8/6 on 32-bit hosts
2128 configured --with-wide-int.
d311d28c
PE
2129 * scroll.c (calculate_scrolling, calculate_direct_scrolling)
2130 (line_ins_del): Use int, not EMACS_INT, where int is wide enough.
2131 * search.c (looking_at_1, string_match_1):
2132 (fast_string_match, fast_c_string_match_ignore_case)
2133 (fast_string_match_ignore_case, fast_looking_at, scan_buffer)
2134 (scan_newline, find_before_next_newline, search_command)
2135 (trivial_regexp_p, search_buffer, simple_search, boyer_moore)
2136 (set_search_regs, wordify):
2137 (Freplace_match):
2138 (Fmatch_data):
2139 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2140 (string_match_1, search_buffer, set_search_regs):
2141 (Fmatch_data):
2142 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2143 (wordify): Check for overflow in size calculation.
2144 (Freplace_match): Avoid potential buffer overflow in search_regs.start.
2145 (Fset_match_data): Don't assume fixnum fits in ptrdiff_t.
2146 Check that fixnums are in proper range for system types.
2147 * sound.c (struct sound_device)
2148 (wav_play, au_play, vox_write, alsa_period_size, alsa_write):
2149 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2150 (Fplay_sound_internal):
2151 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
eacd378d 2152 * syntax.c (struct lisp_parse_state, find_start_modiff)
d311d28c
PE
2153 (Finternal_describe_syntax_value, scan_lists, scan_sexps_forward):
2154 (Fparse_partial_sexp):
2155 Don't assume fixnums can fit in int.
2156 (struct lisp_parse_state, find_start_pos, find_start_value)
2157 (find_start_value_byte, find_start_begv)
2158 (update_syntax_table, char_quoted, dec_bytepos)
2159 (find_defun_start, prev_char_comend_first, back_comment):
2160 (scan_words, skip_chars, skip_syntaxes, forw_comment, Fforward_comment)
2161 (scan_lists, Fbackward_prefix_chars, scan_sexps_forward):
2162 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2163 (Finternal_describe_syntax_value): Check that match_lisp is a
2164 character, not an integer, since the code stuffs it into int.
2165 (scan_words, scan_sexps_forward):
2166 Check that fixnums are in proper range for system types.
2167 (Fforward_word):
2168 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2169 (scan_sexps_forward):
2170 Use CHARACTERP, not INTEGERP, since the value must fit into int.
2171 (Fparse_partial_sexp): Fix doc; element 8 is not ignored.
2172 * syntax.h: Adjust decls to match defn changes elsewhere.
2173 (struct gl_state_s):
2174 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
e4ecdc9c
PE
2175 (SETUP_SYNTAX_TABLE_FOR_OBJECT): Use PTRDIFF_MAX, not
2176 MOST_POSITIVE_FIXNUM.
d311d28c
PE
2177 * sysdep.c (wait_for_termination_1, wait_for_termination)
2178 (interruptible_wait_for_termination, mkdir):
2179 Don't assume pid_t fits in int; on 64-bit AIX pid_t is 64-bit.
2180 (emacs_read, emacs_write):
2181 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
225a2cff
PE
2182 (system_process_attributes): Don't assume uid_t, gid_t, EMACS_INT,
2183 and double all fit in int.
d311d28c
PE
2184 * term.c (set_tty_color_mode):
2185 Check that fixnums are in proper range for system types.
2186 * termhooks.h (struct input_event):
2187 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2188 * textprop.c (validate_interval_range, interval_of)
2189 (Fadd_text_properties, set_text_properties_1)
2190 (Fremove_text_properties, Fremove_list_of_text_properties)
2191 (Ftext_property_any, Ftext_property_not_all)
2192 (copy_text_properties, text_property_list, extend_property_ranges)
2193 (verify_interval_modification):
2194 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2195 (Fnext_single_char_property_change)
2196 (Fprevious_single_char_property_change):
2197 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
5895d7b9
PE
2198 (copy_text_properties):
2199 Check for integer overflow in index calculation.
d311d28c
PE
2200 * undo.c (last_boundary_position, record_point, record_insert)
2201 (record_delete, record_marker_adjustment, record_change)
2202 (record_property_change):
2203 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2204 (truncate_undo_list, Fprimitive_undo): Don't assume fixnum fits in int.
2205 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2206 * w32fns.c (Fx_create_frame, x_create_tip_frame, Fx_show_tip)
2207 (Fx_hide_tip, Fx_file_dialog):
2208 * w32menu.c (set_frame_menubar):
2209 Use ptrdiff_t, not int, for consistency with rest of code.
2210 * window.c (window_scroll_preserve_hpos, window_scroll_preserve_vpos)
2211 (select_window, Fdelete_other_windows_internal)
2212 (window_scroll_pixel_based, window_scroll_line_based)
2213 (Frecenter, Fset_window_configuration):
2214 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2215 (Fset_window_hscroll, run_window_configuration_change_hook)
2216 (set_window_buffer, temp_output_buffer_show, scroll_command)
5895d7b9 2217 (Fscroll_other_window, Frecenter):
d311d28c
PE
2218 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2219 (Fwindow_line_height, window_scroll, Fscroll_left, Fscroll_right):
2220 Don't assume fixnum fits in int.
2221 (Fset_window_scroll_bars):
2222 Check that fixnums are in proper range for system types.
2223 * xdisp.c (help_echo_pos, pos_visible_p, string_pos_nchars_ahead)
2224 (string_pos, c_string_pos, number_of_chars, init_iterator)
2225 (in_ellipses_for_invisible_text_p, init_from_display_pos)
2226 (compute_stop_pos, next_overlay_change, compute_display_string_pos)
2227 (compute_display_string_end, handle_face_prop)
5895d7b9
PE
2228 (face_before_or_after_it_pos, handle_invisible_prop)
2229 (handle_display_prop, handle_display_spec, handle_single_display_spec)
d311d28c
PE
2230 (display_prop_intangible_p, string_buffer_position_lim)
2231 (string_buffer_position, handle_composition_prop, load_overlay_strings)
2232 (get_overlay_strings_1, get_overlay_strings)
2233 (iterate_out_of_display_property, forward_to_next_line_start)
2234 (back_to_previous_visible_line_start, reseat, reseat_to_string)
2235 (get_next_display_element, set_iterator_to_next)
2236 (get_visually_first_element, compute_stop_pos_backwards)
2237 (handle_stop_backwards, next_element_from_buffer)
2238 (move_it_in_display_line_to, move_it_in_display_line)
2239 (move_it_to, move_it_vertically_backward, move_it_by_lines)
2240 (add_to_log, message_dolog, message_log_check_duplicate)
2241 (message2, message2_nolog, message3, message3_nolog
2242 (with_echo_area_buffer, display_echo_area_1, resize_mini_window_1)
2243 (current_message_1, truncate_echo_area, truncate_message_1)
2244 (set_message, set_message_1, store_mode_line_noprop)
2245 (hscroll_window_tree, debug_delta, debug_delta_bytes, debug_end_vpos)
2246 (text_outside_line_unchanged_p, check_point_in_composition)
2247 (reconsider_clip_changes)
2248 (redisplay_internal, set_cursor_from_row, try_scrolling)
2249 (try_cursor_movement, set_vertical_scroll_bar, redisplay_window)
2250 (redisplay_window, find_last_unchanged_at_beg_row)
2251 (find_first_unchanged_at_end_row, row_containing_pos, try_window_id)
2252 (trailing_whitespace_p, find_row_edges, display_line)
2253 (RECORD_MAX_MIN_POS, Fcurrent_bidi_paragraph_direction)
2254 (display_mode_element, store_mode_line_string)
2255 (pint2str, pint2hrstr, decode_mode_spec)
2256 (display_count_lines, display_string, draw_glyphs)
2257 (x_produce_glyphs, x_insert_glyphs)
2258 (rows_from_pos_range, mouse_face_from_buffer_pos)
2259 (fast_find_string_pos, mouse_face_from_string_pos)
2260 (note_mode_line_or_margin_highlight, note_mouse_highlight):
2261 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2262 (safe_call, init_from_display_pos, handle_fontified_prop)
2263 (handle_single_display_spec, load_overlay_strings)
2264 (with_echo_area_buffer, setup_echo_area_for_printing)
2265 (display_echo_area, echo_area_display)
2266 (x_consider_frame_title, prepare_menu_bars, update_menu_bar)
2267 (update_tool_bar, hscroll_window_tree, redisplay_internal)
5895d7b9
PE
2268 (redisplay_window, dump_glyph_row, display_mode_line)
2269 (Fformat_mode_line, decode_mode_spec, on_hot_spot_p):
43ad2e9a 2270 (handle_display_spec, display_prop_string_p):
d311d28c
PE
2271 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2272 (handle_single_display_spec, build_desired_tool_bar_string)
2273 (redisplay_tool_bar, scroll_window_tree, Fdump_glyph_matrix)
2274 (get_specified_cursor_type):
2275 Check that fixnums are in proper range for system types.
2276 (struct overlay_entry, resize_mini_window, Fdump_glyph_row)
2277 (Flookup_image_map):
2278 Don't assume fixnums fit in int.
2279 (compare_overlay_entries):
2280 Avoid mishandling comparisons due to subtraction overflow.
2281 (load_overlay_strings): Use SAFE_NALLOCA, not alloca.
2282 (last_escape_glyph_face_id, last_glyphless_glyph_face_id):
2283 (handle_tool_bar_click):
2284 Use int, not unsigned, since we prefer signed and the signedness
2285 doesn't matter here.
2286 (get_next_display_element, next_element_from_display_vector):
2287 Use int, not EMACS_INT, when int is wide enough.
2288 (start_hourglass): Use duration_to_sec_usec to do proper
2289 overflow checking on durations.
2290 * xfaces.c (Fbitmap_spec_p):
2291 Check that fixnums are in proper range for system types.
2292 (compare_fonts_by_sort_order):
2293 Avoid mishandling comparisons due to subtraction overflow.
2294 (Fx_family_fonts, realize_basic_faces):
2295 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2296 (Fx_family_fonts):
2297 Don't assume fixnum fits in int.
2298 Use SAFE_ALLOCA_LISP, not alloca.
2299 (merge_face_heights): Remove unnecessary cast to EMACS_INT.
2300 (Finternal_make_lisp_face): Don't allocate more than MAX_FACE_ID.
2301 (face_at_buffer_position, face_for_overlay_string)
2302 (face_at_string_position):
2303 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2304 (merge_faces): Use int, not EMACS_INT, where int is wide enough.
2305 * xfns.c (x_set_menu_bar_lines, x_set_tool_bar_lines, x_icon_verify)
2306 (Fx_show_tip):
2307 Check that fixnums are in proper range for system types.
2308 (Fx_create_frame, x_create_tip_frame, Fx_show_tip)
2309 (Fx_hide_tip, Fx_file_dialog, Fx_select_font):
2310 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2311 (Fx_change_window_property): Don't assume fixnums fit in int.
2312 * xfont.c (xfont_chars_supported):
2313 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2314 * xmenu.c (Fx_popup_dialog, set_frame_menubar)
2315 (create_and_show_popup_menu, create_and_show_dialog, xmenu_show):
2316 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2317 * xml.c (parse_region):
2318 * xrdb.c (magic_file_p):
2319 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2320 * xselect.c (TRACE1): Don't assume pid_t promotes to int.
2321 (x_get_local_selection, x_reply_selection_request)
2322 (x_handle_selection_request, wait_for_property_change):
2323 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2324 (selection_data_to_lisp_data): Use short, not EMACS_INT, where
2325 short is wide enough.
2326 (x_send_client_event): Don't assume fixnum fits in int.
2327 * xterm.c (x_x_to_emacs_modifiers):
2328 Don't assume EMACS_INT overflows nicely into int.
2329 (x_emacs_to_x_modifiers): Use EMACS_INT, not int, because values
2330 may come from Lisp.
2331 (handle_one_xevent): NATNUMP can eval its arg twice.
2332 (x_connection_closed):
2333 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2334 * xterm.h: Adjust decls to match defn changes elsewhere.
2335 (struct scroll_bar): Use struct vectorlike_header
2336 rather than rolling our own approximation.
2337 (SCROLL_BAR_VEC_SIZE): Remove; not used.
2338
c6574eb5
GM
23392012-05-25 Glenn Morris <rgm@gnu.org>
2340
2341 * lisp.mk (lisp): Update for more files being compiled now.
2342
e8d32c7e
SM
23432012-05-25 Stefan Monnier <monnier@iro.umontreal.ca>
2344
48def666
SM
2345 * lread.c: Remove `read_pure' which makes no difference.
2346 (read_pure): Remove var.
2347 (unreadpure): Remove function.
2348 (readevalloop): Don't call read_list with -1 flag.
2349 (read1, read_vector): Don't test read_pure any more.
2350 (read_list): Simplify.
2351
e8d32c7e
SM
2352 * fileio.c, character.h: Minor style tweaks.
2353
4b2addb7
DA
23542012-05-24 Dmitry Antipov <dmantipov@yandex.ru>
2355
2356 * window.h (clip_changed): Remove useless declaration.
2357
584461b2
JB
23582012-05-22 Juanma Barranquero <lekktu@gmail.com>
2359
2360 * makefile.w32-in: Follow-up to 2012-05-22T16:20:27Z!eggert@cs.ucla.edu.
2361 (TAGS, TAGS-gmake, CONFIG_H): Remove further references to m/intel386.h.
2362
34374650
PE
23632012-05-22 Paul Eggert <eggert@cs.ucla.edu>
2364
2365 Remove src/m/*.
2366 This directory predates autoconf and is no longer needed nowadays.
2367 Move its few remaining bits of functionality to where they're needed.
2368 * m/README, m/alpha.h, m/amdx86-64.h, m/ia64.h, m/ibmrs6000.h:
2369 * m/ibms390x.h, m/intel386.h, m/m68k.h, m/macppc.h, m/sparc.h:
2370 * m/template.h: Remove.
2371 * Makefile.in (M_FILE): Remove. All uses removed.
2372 * alloc.c (POINTERS_MIGHT_HIDE_IN_OBJECTS):
2373 * lisp.h (USE_LSB_TAG):
2374 * mem-limits.h (EXCEEDS_LISP_PTR):
2375 Use VAL_MAX, not VALBITS, in #if.
2376 * lisp.h (EMACS_INT_MAX): New macro, useful in #if.
2377 (EMACS_UINT): Define unconditionally now.
2378 (BITS_PER_CHAR, BITS_PER_SHORT, BITS_PER_INT, BITS_PER_LONG)
2379 (BITS_PER_EMACS_INT): New constants, replacing
2380 what used to be in config.h, but not useful in #if.
2381 (GCTYPEBITS, VALBITS): Define unconditionally, since m/* files don't
2382 define them any more.
2383 (VAL_MAX): New macro.
2384 (VALMASK): Use it.
2385 * puresize.h (PURESIZE_RATIO): Use EMACS_INT_MAX, not
2386 BITS_PER_EMACS_INT, in #if.
2387 * s/aix4-2.h (BROKEN_FIONREAD, BROKEN_SIGAIO, BROKEN_SIGPTY)
2388 (BROKEN_SIGPOLL): Move here from m/ibmrs6000.h, which was removed.
2389 * s/gnu-linux.h (ULIMIT_BREAK_VALUE) [__i386__]:
2390 * s/ms-w32.h (DATA_START):
2391 Move here from removed file m/intel386.h.
2392 * s/gnu.h (NLIST_STRUCT): Remove undef; 'configure' does this.
2393 * s/irix6-5.h (_LP64): Remove; lisp.h no longer needs this.
2394
261cb4bb
PE
23952012-05-21 Paul Eggert <eggert@cs.ucla.edu>
2396
2397 Assume C89 or later.
2398 * alloc.c, buffer.c, lisp.h: Replace POINTER_TYPE with void.
2399 * alloc.c (overrun_check_malloc, overrun_check_realloc, xmalloc)
2400 (xrealloc):
2401 * buffer.c (mmap_free_1, mmap_enlarge): Omit needless casts.
2402 * editfns.c, fns.c, gmalloc.c, insdel.c, sysdep.c, termcap.c (NULL):
2403 * textprop.c, tparam.c (NULL): Remove.
2404 * ralloc.c, vm-limit.c (POINTER): Assume void * works.
2405 * regex.c (SIGN_EXTEND_CHAR): Assume signed char works.
2406 * regex.h (_RE_ARGS): Remove. All uses rewritten to use prototypes.
2407 * unexelf.c (ElfBitsW): Assume c89 preprocessor or better.
2408 * xterm.c (input_signal_count): Assume volatile works.
2409
ff23cd9f
KB
24102012-05-21 Ken Brown <kbrown@cornell.edu>
2411
2412 * xgselect.c (xg_select): Fix first argument in call to 'select'
2413 (bug#11508).
2414
1b170bc6
KB
24152012-05-20 Ken Brown <kbrown@cornell.edu>
2416
2417 * gmalloc.c (_free_internal_nolock, _realloc_internal_nolock)
bd7239f5 2418 [CYGWIN]: Cast ptr to (char *) before comparing to _heapbase.
1b170bc6 2419
b2f4d39f
KB
24202012-05-19 Ken Brown <kbrown@cornell.edu>
2421
2422 * xfns.c (x_in_use): Remove `static' qualifier.
2423 * xterm.h (x_in_use): Declare.
2424 * xgselect.c: Include xterm.h.
2425 (xg_select): Test `x_in_use' instead of `inhibit_window_system'
2426 and `display_arg' (bug#9754).
2427
003fdae2
PE
24282012-05-19 Paul Eggert <eggert@cs.ucla.edu>
2429
9232a6d9
PE
2430 * s/ms-w32.h (HAVE_GETDOMAINNAME): Remove; not needed.
2431
003fdae2
PE
2432 * m/vax.h: Remove; no longer needed since HAVE_FTIME is being removed.
2433 * s/ms-w32.h (HAVE_FTIME): Remove; not needed.
2434
784b56e2
EZ
24352012-05-18 Eli Zaretskii <eliz@gnu.org>
2436
2437 Fix compilation with -DGLYPH_DEBUG=1 on MS-Windows.
2438
2439 * w32term.c [GLYPH_DEBUG]: Add prototype for x_check_font.
2440 (x_check_font) [GLYPH_DEBUG]: New function, copied from xterm.c
2441
2442 * w32fns.c (unwind_create_frame) [GLYPH_DEBUG]: Fix broken
2443 reference to image_cache->refcount.
2444 (x_create_tip_frame): Fix broken use of FRAME_IMAGE_CACHE.
2445
a0a79cde
JL
24462012-05-17 Juri Linkov <juri@jurta.org>
2447
2448 * search.c (Fword_search_regexp, Fword_search_backward)
2449 (Fword_search_forward, Fword_search_backward_lax)
2450 (Fword_search_forward_lax): Move functions to isearch.el
2451 (bug#10145, bug#11381).
2452
b0572523
PE
24532012-05-16 Paul Eggert <eggert@cs.ucla.edu>
2454
2455 * xgselect.c (xg_select): Just invoke 'select' if -nw (Bug#9754).
2456
9660f5fc
SM
24572012-05-15 Stefan Monnier <monnier@iro.umontreal.ca>
2458
2459 * lread.c (init_obarray): Declare Qt and Qnil as special.
2460
4374de83
GM
24612012-05-14 Glenn Morris <rgm@gnu.org>
2462
2463 * nsterm.m (ns_init_paths): Fix typo ("libexec" not "lib-exec").
985584ae 2464 Put "libexec" before "bin", for the sake of init_callproc_1.
4374de83 2465
dc44c39a
PE
24662012-05-14 Paul Eggert <eggert@cs.ucla.edu>
2467
078c97cb
PE
2468 * keyboard.c (kbd_buffer_get_event) [!HAVE_DBUS]: Omit unused local.
2469
dc44c39a
PE
2470 * unexaix.c: Port to more-recent AIX compilers.
2471 (report_error, report_error_1, make_hdr, copy_sym)
2472 (mark_x, adjust_lnnoptrs, unrelocate_symbols):
2473 Make arguments const char *, not char *, to avoid violations of C
2474 standard and to fix some AIX warnings reported by Gilles Pion.
2475
e18afed7 24762012-05-14 Eli Zaretskii <eliz@gnu.org>
ac268e67
EZ
2477
2478 * xdisp.c (handle_stop): Don't call get_overlay_strings_1 if we
2479 already have overlays loaded.
2480 (handle_single_display_spec): Before returning without displaying
2481 fringe bitmap, synchronize the bidi iterator with the main display
2482 iterator, by calling iterate_out_of_display_property.
2483 (iterate_out_of_display_property): Detect buffer iteration by
2484 testing that it->string is a Lisp string.
2485 (get_next_display_element): When the current object is exhausted,
2486 and there's something on it->stack, call set_iterator_to_next to
2487 proceed with what's on the stack, instead of returning zero.
2488 (set_iterator_to_next): If called at the end of a Lisp string,
2489 proceed to consider_string_end without incrementing string
2490 position. Don't increment display vector index past the end of
2491 the display vector. (Bug#11417)
c8fb9dc6
EZ
2492 (pos_visible_p): Don't report a position visible when move_it_to
2493 stopped at the last line of window, which happens to be scanned
2494 backwards by the bidi iteration. (Bug#11464)
ac268e67 2495
e18afed7 24962012-05-14 Eli Zaretskii <eliz@gnu.org>
82f9b393
EZ
2497
2498 * xdisp.c (handle_single_display_spec): Return 1 for left-margin
2499 and right-margin display specs even if the spec is invalid or we
61b108cc
SM
2500 are on a TTY, and thus unable to display on the fringes.
2501 That's because the text with the property will not be displayed anyway,
82f9b393
EZ
2502 so we need to signal to the caller that this is a "replacing"
2503 display spec. This fixes display when the spec is invalid or we
2504 are on a TTY.
2505
e18afed7 25062012-05-14 Paul Eggert <eggert@cs.ucla.edu>
297834cd
PE
2507
2508 * unexaix.c (make_hdr): Fix typo in prototype.
2509 This bug broke the build on AIX. Problem reported by Gilles Pion.
2510
9d0a235a
MA
25112012-05-14 Michael Albinus <michael.albinus@gmx.de>
2512
2513 * keyboard.c (kbd_buffer_get_event): Read special events also in
2514 batch mode. (Bug#11415)
2515
9e6b06ed
GM
25162012-05-12 Glenn Morris <rgm@gnu.org>
2517
2518 * ns.mk: Update for ns_appbindir no longer having trailing "/".
2519
c1a1d7a3
EZ
25202012-05-12 Eli Zaretskii <eliz@gnu.org>
2521
2522 * lisp.mk (lisp): Add newcomment.elc.
2523
3fe7cdc8
GM
25242012-05-12 Glenn Morris <rgm@gnu.org>
2525
2526 * Makefile.in (MKDIR_P): New, set by configure.
2527 * ns.mk (${ns_appdir}, ${ns_appbindir}Emacs): Use $MKDIR_P.
2528
53f7d2c0
PE
25292012-05-11 Paul Eggert <eggert@cs.ucla.edu>
2530
2531 Remove unused function hourglass_started.
2532 * dispextern.h (hourglass_started):
2533 * w32fns.c (hourglass_started):
2534 * xdisp.c (hourglass_started): Remove.
2535
75aafb17
JB
25362012-05-10 Juanma Barranquero <lekktu@gmail.com>
2537
2538 * makefile.w32-in ($(BLD)/gmalloc.$(O), $(BLD)/w32menu.$(O)):
2539 Update dependencies.
2540
12959e8e
PE
25412012-05-10 Paul Eggert <eggert@cs.ucla.edu>
2542
97107e2e
PE
2543 * xgselect.c (xg_select): Put maxfds+1 into a var.
2544 This is slightly clearer, and pacifies Ubuntu 12.04 gcc.
2545
12959e8e
PE
2546 * sound.c (DEFAULT_ALSA_SOUND_DEVICE): Define only if HAVE_ALSA.
2547
836d29b3
DA
25482012-05-10 Dave Abrahams <dave@boostpro.com>
2549
2550 * filelock.c (syms_of_filelock): New boolean create-lockfiles.
2551 (lock_file): If create_lockfiles is 0, do nothing. (Bug#11227)
2552
5cb67954
MA
25532012-05-09 Michael Albinus <michael.albinus@gmx.de>
2554
2555 * dbusbind.c (xd_registered_buses): New internal Lisp object.
2556 Rename all occurences of Vdbus_registered_buses to xd_registered_buses.
2557 (syms_of_dbusbind): Remove declaration of Vdbus_registered_buses.
2558 Initialize xd_registered_buses.
2559
3478ec45
PE
25602012-05-09 Paul Eggert <eggert@cs.ucla.edu>
2561
b263a6b0
PE
2562 Untag more efficiently if USE_LSB_TAG.
2563 This is based on a proposal by YAMAMOTO Mitsuharu in
2564 <http://lists.gnu.org/archive/html/emacs-devel/2008-01/msg01876.html>.
2565 For an admittedly artificial (nth 8000 longlist) benchmark on
2566 Fedora 15 x86-64, this yields a 25% CPU speedup. Also, it shrinks
2567 Emacs's overall text size by 1%.
2568 * lisp.h (XUNTAG): New macro.
2569 (XCONS, XVECTOR, XSTRING, XSYMBOL, XFLOAT, XMISC, XPROCESS, XWINDOW)
2570 (XTERMINAL, XSUBR, XBUFFER, XCHAR_TABLE, XSUB_CHAR_TABLE, XBOOL_VECTOR)
2571 (XSETTYPED_PSEUDOVECTOR, XHASH_TABLE, TYPED_PSEUDOVECTORP): Use it.
2572 * eval.c (Fautoload):
2573 * font.h (XFONT_SPEC, XFONT_ENTITY, XFONT_OBJECT):
2574 * frame.h (XFRAME): Use XUNTAG.
2575
3478ec45
PE
2576 Port recent dbusbind.c changes to 32-bit --with-wide-int.
2577 * dbusbind.c (xd_append_arg, xd_retrieve_arg, Fdbus_message_internal):
2578 Remove unportable assumptions about print widths of types like
2579 dbus_uint32_t.
2580 (xd_get_connection_address, Fdbus_init_bus): Cast Emacs integer to
2581 intptr_t when converting between pointer and integer, to avoid GCC
2582 warnings about wrong width.
2583
666b903b 25842012-05-09 Eli Zaretskii <eliz@gnu.org>
0d887c7d
EZ
2585
2586 * w32proc.c (new_child): Force Windows to reserve only 64KB of
2587 stack for each reader_thread, instead of defaulting to 8MB
2588 determined by the linker. This avoids failures in creating
2589 subprocesses on Windows 7, see the discussion in this thread:
2590 http://lists.gnu.org/archive/html/emacs-devel/2012-03/msg00119.html.
2591
b120cc17
JC
25922012-05-07 Jérémy Compostella <jeremy.compostella@gmail.com>
2593
2594 Fix up display of the *Minibuf-0* buffer in the mini window.
2595 * keyboard.c (read_char): Don't clear the echo area if there's no
2596 message to clear.
2597 * xdisp.c (redisplay_internal): Redisplay the mini window (with the
2fed2689 2598 contents of *Minibuf-0*) if there's no message displayed in its stead.
b120cc17 2599
9a4b36f8
MA
26002012-05-07 Michael Albinus <michael.albinus@gmx.de>
2601
2602 * dbusbind.c (XD_DEBUG_MESSAGE): Don't print message twice in
2603 batch mode.
2604
e5f9458f
CY
26052012-05-06 Chong Yidong <cyd@gnu.org>
2606
2607 * lisp.mk (lisp): Update.
2608
eceeb5fc 26092012-05-05 Jim Meyering <meyering@redhat.com>
bf98199c
JM
2610
2611 * w32font.c (fill_in_logfont): NUL-terminate a string (Bug#11372).
2612
71873e2b
SM
26132012-05-04 Stefan Monnier <monnier@iro.umontreal.ca>
2614
2615 * data.c (PUT_ERROR): New macro.
2616 (syms_of_data): Use it. Add new error type `user-error'.
2617 * undo.c (user_error): New function.
2618 (Fprimitive_undo): Use it.
2619 * print.c (print_error_message): Adjust print style for `user-error'.
2620 * keyboard.c (user_error): New function.
2621 (Fexit_recursive_edit, Fabort_recursive_edit): Use it.
2622
ab0fa4e4
PE
26232012-05-03 Paul Eggert <eggert@cs.ucla.edu>
2624
2625 Do not limit current-time-string to years 1000..9999.
2626 * editfns.c (TM_YEAR_IN_ASCTIME_RANGE): Remove.
2627 (Fcurrent_time_string): Support any year that is supported by the
2628 underlying localtime representation. Don't use asctime, as it
2629 has undefined behavior for years outside the range -999..9999.
2630
7ed806a7
PE
26312012-05-02 Paul Eggert <eggert@cs.ucla.edu>
2632
2633 Fix race conditions involving setenv, gmtime, localtime, asctime.
2634 Without this fix, interrupts could mess up code that uses these
2635 nonreentrant functions, since setting TZ invalidates existing
2636 tm_zone or tzname values, and since most of these functions return
2637 pointers to static storage.
2638 * editfns.c (format_time_string, Fdecode_time, Fencode_time)
2639 (Fcurrent_time_string, Fcurrent_time_zone, Fset_time_zone_rule):
2640 Grow the critical sections to include not just invoking
2641 localtime/gmtime, but also accessing these functions' results
2642 including their tm_zone values if any, and any related TZ setting.
2643 (format_time_string): Last arg is now struct tm *, not struct tm **,
71873e2b
SM
2644 so that the struct tm is saved in the critical section.
2645 All callers changed. Simplify allocation of initial buffer, partly
7ed806a7
PE
2646 motivated by the fact that memory allocation needs to be outside
2647 the critical section.
2648
0c16dfed
DA
26492012-05-02 Dmitry Antipov <dmantipov@yandex.ru>
2650
2651 * intervals.c (adjust_intervals_for_insertion): Initialize `newi'
2652 with RESET_INTERVAL.
2653
2654 * buffer.c (Fget_buffer_create, Fmake_indirect_buffer):
2655 Remove duplicated buffer name initialization.
2656
3f83ace8
JM
26572012-05-02 Jim Meyering <jim@meyering.net>
2658
2659 * xterm.c (x_term_init): Use memcpy instead of strncpy (Bug#11373).
2660
c7b8541e
JM
2661 * xfns.c (x_window): Use xstrdup (Bug#11375).
2662
90207a15 26632012-05-02 Eli Zaretskii <eliz@gnu.org>
2fa85638
EZ
2664
2665 * xdisp.c (pos_visible_p): If already at a newline from the
2666 display string before the 'while' loop, don't walk back the glyphs
2667 from it3.glyph_row. Solves assertion violation when the display
2668 string begins with a newline (egg.el). (Bug#11367)
2669
b593d6a9
AH
26702012-05-01 Stefan Monnier <monnier@iro.umontreal.ca>
2671
2672 * keyboard.c (Fexecute_extended_command, Vsuggest_key_bindings):
2673 Move to simple.el.
2674
4737362e
GM
26752012-05-01 Glenn Morris <rgm@gnu.org>
2676
99cf43f9
GM
2677 * syssignal.h: Remove reference to BROKEN_SIGINFO (last used in
2678 s/ptx4.h), BROKEN_SIGTSTP (last used in m/ustation.h, m/dpx2.h),
2679 and BROKEN_SIGURG (was in s/gnu-linux.h prior to 2008-02-10).
2680 All were removed before 23.1.
2681
9311dcff
GM
2682 * dispnew.c: Remove HAVE_LIBNCURSES test;
2683 it is always true on relevant platforms.
2684
4d5c6349
GM
2685 * Makefile.in (LD_SWITCH_X_SITE_RPATH):
2686 Rename from LD_SWITCH_X_SITE_AUX_RPATH.
2687
4737362e
GM
2688 * Makefile.in (LD_SWITCH_X_SITE_AUX): Remove; no longer used.
2689
74dd3a6b
AS
26902012-04-30 Andreas Schwab <schwab@linux-m68k.org>
2691
2692 * .gdbinit (xpr): Remove checks for no longer existing misc types.
2693 (xintfwd, xboolfwd, xobjfwd, xbufobjfwd, xkbobjfwd, xbuflocal):
2694 Remove.
2695
13c379ee
PE
26962012-04-28 Paul Eggert <eggert@cs.ucla.edu>
2697
2698 Do not avoid creating empty evaporating overlays (Bug#9642).
2699 * buffer.c (Fmove_overlay): Revert the change of 2012-04-23.
2700 That is, do not delete an evaporating overlay if it becomes
2701 empty after its bounds are adjusted to fit within its buffer.
2702 This fix caused other problems, and I'm reverting it until we get
2703 to the bottom of them.
2704
a8e7d6d7 27052012-04-27 Chong Yidong <cyd@gnu.org>
9be2fd9b
CY
2706
2707 * xselect.c (x_convert_selection): Initialize a pointer (Bug#11315).
2708
a8e7d6d7 27092012-04-27 Eli Zaretskii <eliz@gnu.org>
f0ee99a0
EZ
2710
2711 * xdisp.c (pos_visible_p): If the window start position is beyond
2712 ZV, start the display from buffer beginning. Prevents assertion
2713 violation in init_iterator when the minibuffer window is scrolled
2714 via the scroll bar.
2715
2716 * window.c (window_scroll_pixel_based): Likewise.
2717
a8e7d6d7 27182012-04-27 Chong Yidong <cyd@gnu.org>
9ec7751f
CY
2719
2720 * keymap.c (where_is_internal): Doc fix (Bug#10872).
2721
a8e7d6d7 27222012-04-27 Glenn Morris <rgm@gnu.org>
24c51a09
GM
2723
2724 * fileio.c (Fcopy_file, Fset_file_selinux_context):
2725 Ignore ENOTSUP failures from setfilecon functions. (Bug#11245)
2726
a8e7d6d7 27272012-04-27 Eli Zaretskii <eliz@gnu.org>
73055685 2728
b593d6a9
AH
2729 * dispnew.c (swap_glyph_pointers, copy_row_except_pointers):
2730 Don't overrun array limits of glyph row's used[] array. (Bug#11288)
73055685 2731
1c6900d9
EZ
27322012-04-26 Eli Zaretskii <eliz@gnu.org>
2733
4c3fa1d9
EZ
2734 * xdisp.c (IT_DISPLAYING_WHITESPACE): In addition to the loaded
2735 display element, check also the underlying string or buffer
2736 character. (Bug#11341)
2737
1c6900d9
EZ
2738 * w32menu.c: Include w32heap.h.
2739 (add_menu_item): If the call to AppendMenuW (via
2740 unicode_append_menu) fails, disable Unicode menus only if we are
2741 running on Windows 9X/Me.
2742
42bf8205
AS
27432012-04-24 Andreas Schwab <schwab@linux-m68k.org>
2744
2745 * .gdbinit (xpr): Handle USE_2_TAGS_FOR_INTS.
2746 (xgetint): Add missing shift for LSB tags.
2747
b1bac16e
MR
27482012-04-24 Martin Rudalics <rudalics@gmx.at>
2749
2750 * keyboard.c (read_char): Don't wipe echo area for select window
2751 events: These might get delayed via `mouse-autoselect-window'
2752 (Bug#11304).
2753
d69621cc
JB
27542012-04-24 Juanma Barranquero <lekktu@gmail.com>
2755
2756 * gnutls.c (init_gnutls_functions): Protect against (unlikely)
2757 manipulation of :loaded-from data.
2758
02fd101b
JB
27592012-04-23 Juanma Barranquero <lekktu@gmail.com>
2760
2761 * gnutls.c (init_gnutls_functions): The value of :loaded-from is
2762 now a cons (bug#11311).
2763
888bec30
PE
27642012-04-23 Paul Eggert <eggert@cs.ucla.edu>
2765
89a438bd
PE
2766 Do not create empty overlays with the evaporate property (Bug#9642).
2767 * buffer.c (Fmove_overlay): Delete an evaporating overlay
2768 if it becomes empty after its bounds are adjusted to fit within
2769 its buffer. Without this fix, in a nonempty buffer (let ((o
2770 (make-overlay 1 2))) (overlay-put o 'evaporate t) (move-overlay o 0 1))
2771 yields an empty overlay that has the evaporate property, which is
2772 not supposed to happen.
2773
1068fe4d
PE
2774 Fix minor GTK3 problems found by static checking.
2775 * emacsgtkfixed.c (EMACS_TYPE_FIXED, EMACS_FIXED, EmacsFixed)
2776 (EmacsFixedPrivate, EmacsFixedClass, struct _EmacsFixed)
2777 (struct _EmacsFixedClass, emacs_fixed_get_type):
2778 Move decls here from emacsgtkfixed.h, since they needn't be public.
2779 (emacs_fixed_get_type): Now static.
2780 (emacs_fixed_class_init): Omit unused local.
2781 (emacs_fixed_child_type): Remove; unused.
2782 * emacsgtkfixed.h (EMACS_TYPE_FIXED, EMACS_FIXED, EmacsFixed)
2783 (EmacsFixedPrivate, EmacsFixedClass, struct _EmacsFixed)
2784 (struct _EmacsFixedClass): Move to emacsgtkfixed.c.
2785 (EMACS_FIXED_CLASS, EMACS_IS_FIXED, EMACS_IS_FIXED_CLASS)
2786 (EMACS_FIXED_GET_CLASS): Remove; unused.
2787 * gtkutil.c (xg_create_frame_widgets) [!HAVE_GTK3]: Omit unused local.
2788
888bec30
PE
2789 * keyboard.c (handle_async_input): Define only if SYNC_INPUT || SIGIO.
2790 Problem reported by Juanma Barranquero for Windows -Wunused-function.
2791
de85e130
PE
27922012-04-22 Paul Eggert <eggert@cs.ucla.edu>
2793
d0baac98 2794 Modernize and clean up gmalloc.c to assume C89 (Bug#9119).
bd7239f5 2795 * gmalloc.c (_MALLOC_INTERNAL, _MALLOC_H, _PP, __ptr_t)
d0baac98
PE
2796 (__malloc_size_t, __malloc_ptrdiff_t):
2797 Remove. All uses removed, replaced by the definiens if needed,
2798 since we can assume C89 or better now.
2799 Include <stdint.h>, for PTRDIFF_MAX, uintptr_t.
2800 (protect_malloc_state, align, get_contiguous_space)
2801 (malloc_atfork_handler_prepare, malloc_atfork_handler_parent)
2802 (malloc_atfork_handler_child, malloc_enable_thread)
2803 (malloc_initialize_1, __malloc_initialize, morecore_nolock)
2804 (_malloc_internal_nolock, _malloc_internal, malloc, _malloc)
2805 (_free, _realloc, _free_internal_nolock, _free_internal, free, cfree)
2806 (special_realloc, _realloc_internal_nolock, _realloc_internal)
2807 (realloc, calloc, __default_morecore, memalign, valloc, checkhdr)
2808 (freehook, mallochook, reallochook, mabort, mcheck, mprobe):
2809 Define using prototypes, not old style.
2810 (align, _malloc_internal_nolock, _free_internal_nolock, memalign):
2811 Don't assume ptrdiff_t and uintptr_t are no wider than unsigned long.
2812 (align): Don't assume that signed integer overflow wraps around.
2813 Omit unused local var.
2814 (malloc_initialize_1, morecore_nolock, _malloc_internal_nolock)
2815 (_free_internal_nolock, memalign, mallochook, reallochook):
2816 Omit no-longer-needed casts.
2817 (valloc): Use getpagesize, not __getpagesize.
2818 (MAGICWORD, MAGICFREE): Now randomish size_t values, not 32-bit.
2819 (struct hdr): The 'magic' member is now size_t, not unsigned long.
2820
de85e130
PE
2821 * dbusbind.c (XD_DBUS_VALIDATE_OBJECT): Define only if needed.
2822
dcbf5805
MA
28232012-04-22 Michael Albinus <michael.albinus@gmx.de>
2824
2825 Move functions from C to Lisp. Make non-blocking method calls
2826 the default. Implement further D-Bus standard interfaces.
2827
2828 * dbusbind.c (DBUS_NUM_MESSAGE_TYPES): Declare.
2829 (QCdbus_request_name_allow_replacement)
2830 (QCdbus_request_name_replace_existing)
2831 (QCdbus_request_name_do_not_queue)
2832 (QCdbus_request_name_reply_primary_owner)
2833 (QCdbus_request_name_reply_in_queue)
2834 (QCdbus_request_name_reply_exists)
2835 (QCdbus_request_name_reply_already_owner): Move to dbus.el.
2836 (QCdbus_registered_serial, QCdbus_registered_method)
2837 (QCdbus_registered_signal): New Lisp objects.
2838 (XD_DEBUG_MESSAGE): Use sizeof.
2839 (XD_MESSAGE_TYPE_TO_STRING, XD_OBJECT_TO_STRING)
2840 (XD_DBUS_VALIDATE_BUS_ADDRESS, XD_DBUS_VALIDATE_OBJECT)
2841 (XD_DBUS_VALIDATE_BUS_NAME, XD_DBUS_VALIDATE_PATH)
2842 (XD_DBUS_VALIDATE_INTERFACE, XD_DBUS_VALIDATE_MEMBER): New macros.
2843 (XD_CHECK_DBUS_SERIAL): Rename from CHECK_DBUS_SERIAL_GET_SERIAL.
2844 (xd_signature, xd_append_arg): Allow float for integer types.
2845 (xd_get_connection_references): New function.
b593d6a9
AH
2846 (xd_get_connection_address): Rename from xd_initialize.
2847 Return cached address.
dcbf5805
MA
2848 (xd_remove_watch): Do not unset $DBUS_SESSION_BUS_ADDRESS.
2849 (xd_close_bus): Rename from Fdbus_close_bus. Not needed on Lisp
2850 level.
2851 (Fdbus_init_bus): New optional arg PRIVATE. Cache address.
9a4b36f8 2852 Return number of refcounts.
dcbf5805
MA
2853 (Fdbus_get_unique_name): Make stronger parameter check.
2854 (Fdbus_message_internal): New defun.
2855 (Fdbus_call_method, Fdbus_call_method_asynchronously)
2856 (Fdbus_method_return_internal, Fdbus_method_error_internal)
2857 (Fdbus_send_signal, Fdbus_register_service)
2858 (Fdbus_register_signal, Fdbus_register_method): Move to dbus.el.
2859 (xd_read_message_1): Obey new structure of Vdbus_registered_objects.
2860 (xd_read_queued_messages): Obey new structure of Vdbus_registered_buses.
2861 (Vdbus_compiled_version, Vdbus_runtime_version)
2862 (Vdbus_message_type_invalid, Vdbus_message_type_method_call)
2863 (Vdbus_message_type_method_return, Vdbus_message_type_error)
2864 (Vdbus_message_type_signal): New defvars.
b593d6a9
AH
2865 (Vdbus_registered_buses, Vdbus_registered_objects_table):
2866 Adapt docstring.
dcbf5805 2867
52828e02
PE
28682012-04-22 Paul Eggert <eggert@cs.ucla.edu>
2869
da05bc4c
PE
2870 Fix GC_MALLOC_CHECK debugging output on 64-bit hosts.
2871 * alloc.c (emacs_blocked_malloc) [GC_MALLOC_CHECK]:
2872 Do not assume ptrdiff_t is the same width as 'int'.
2873
52828e02
PE
2874 * alloc.c: Handle unusual debugging option combinations.
2875 (GC_CHECK_MARKED_OBJECTS): Undef if ! GC_MARK_STACK,
2876 since the two debugging options are incompatible.
2877 (GC_MALLOC_CHECK): Similarly, undef if GC_CHECK_MARKED_OBJECTS
2878 is defined.
2879 (mem_init, mem_insert, mem_insert_fixup):
2880 Define if GC_MARK_STACK || GC_MALLOC_CHECK.
2881 (NEED_MEM_INSERT): Remove; no longer needed.
2882
f01769f9
LL
28832012-04-22 Leo Liu <sdl.web@gmail.com>
2884
2885 * sysdep.c (list_system_processes): Support Darwin (Bug#5725).
2886
5790543d
PE
28872012-04-22 Paul Eggert <eggert@cs.ucla.edu>
2888
2889 * sysdep.c [__FreeBSD__]: Minor cleanups.
2890 (list_system_processes, system_process_attributes) [__FreeBSD__]:
2891 Use Emacs indenting style more consistently. Avoid some casts.
2892 Use 'double' consistently rather than mixing 'float' and 'double'.
2893
b91b7e4d
EW
28942012-04-21 Eduard Wiebe <usenet@pusto.de>
2895
b593d6a9
AH
2896 * sysdep.c (list_system_processes, system_process_attributes):
2897 Add implementation for FreeBSD (Bug#5243).
b91b7e4d 2898
6114eb15
AS
28992012-04-21 Andreas Schwab <schwab@linux-m68k.org>
2900
2901 * lisp.mk (lisp): Update.
2902
2f38dff7
PE
29032012-04-20 Paul Eggert <eggert@cs.ucla.edu>
2904
2905 * keyboard.c (process_pending_signals): Define only if SYNC_INPUT.
2906 It is never used otherwise.
2907
4ae29f89
SM
29082012-04-20 Stefan Monnier <monnier@iro.umontreal.ca>
2909
2910 * print.c (print_preprocess): Only check print_depth if print-circle
2911 is nil.
2912 (print_object): Check for cycles even when print-circle is nil and
2913 print-gensym is t, but only check print_depth if print-circle is nil.
2914
f30d612a
CY
29152012-04-20 Chong Yidong <cyd@gnu.org>
2916
2917 * process.c (wait_reading_process_output): If EIO occurs on a pty,
2918 set the status to "failed" and ensure that sentinel is run.
2919
c07a4c0b 29202012-04-20 Glenn Morris <rgm@gnu.org>
016a35df
GM
2921
2922 * process.c (Fset_process_inherit_coding_system_flag)
2923 (Fset_process_query_on_exit_flag): Doc fix (mention return value).
4373fd43 2924 (Fmake_network_process, Fmake_serial_process): Doc fix.
016a35df 2925
c07a4c0b 29262012-04-20 Eli Zaretskii <eliz@gnu.org>
20a68157
EZ
2927
2928 * xdisp.c (string_buffer_position_lim): Limit starting position to
2929 BEGV.
2930 (set_cursor_from_row): If called for a mode-line or header-line
2931 row, return zero immediately.
2932 (try_cursor_movement): If inside continuation line, don't back up
4ae29f89
SM
2933 farther than the first row after the header line, if any.
2934 Don't consider the header-line row as "partially visible", even if
20a68157
EZ
2935 MATRIX_ROW_PARTIALLY_VISIBLE_P returns non-zero. (Bug#11261)
2936
c07a4c0b 29372012-04-20 Atsuo Ohki <ohki@gssm.otsuka.tsukuba.ac.jp> (tiny change)
ad3a2b41 2938
4ae29f89
SM
2939 * lread.c (lisp_file_lexically_bound_p): Fix hang at ";-*-\n"
2940 (bug#11238).
ad3a2b41 2941
c07a4c0b 29422012-04-20 Teodor Zlatanov <tzz@lifelogs.com>
6c94c34f 29432012-04-18 Paul Eggert <eggert@cs.ucla.edu>
ae6e112d
PE
2944
2945 configure: new option --enable-gcc-warnings (Bug#11207)
2946 * Makefile.in (C_WARNINGS_SWITCH): Remove.
2947 (WARN_CFLAGS, WERROR_CFLAGS): New macros.
2948 (ALL_CFLAGS): Use new macros rather than old.
2949 * process.c: Ignore -Wstrict-overflow to work around GCC bug 52904.
2950 * regex.c: Ignore -Wstrict-overflow. If !emacs, also ignore
2951 -Wunused-but-set-variable, -Wunused-function, -Wunused-macros,
2952 -Wunused-result, -Wunused-variable. This should go away once
2953 the Emacs and Gnulib regex code is merged.
2954 (xmalloc, xrealloc): Now static.
2955
aba027e8
PE
29562012-04-17 Paul Eggert <eggert@cs.ucla.edu>
2957
2958 * dired.c (Fsystem_groups): Remove unused local.
2959
e5a36063
GM
29602012-04-17 Glenn Morris <rgm@gnu.org>
2961
2962 * dired.c (Fsystem_users): Doc fix.
2963
316411f0
DA
29642012-04-17 Dmitry Antipov <dmantipov@yandex.ru>
2965
2966 * dired.c (Fsystem_users, Fsystem_groups): New functions. (Bug#7900)
2967 (syms_of_dired): Add them.
2968
9426aba4
PE
29692012-04-16 Paul Eggert <eggert@cs.ucla.edu>
2970
b62a57be
PE
2971 Fix minor alloc.c problems found by static checking.
2972 * alloc.c (_malloc_internal, _free_internal) [!DOUG_LEA_MALLOC]:
2973 New extern decls, to avoid calling undeclared functions.
2974 (dont_register_blocks): Define if ((!SYSTEM_MALLOC && !SYNC_INPUT)
2975 && GC_MALLOC_CHECK), not if ((GC_MARK_STACK || defined
2976 GC_MALLOC_CHECK) && GC_MALLOC_CHECK), to match when it's used.
2977 (NEED_MEM_INSERT): New macro.
2978 (mem_insert, mem_insert_fixup) [!NEED_MEM_INSERT]: Remove; unused.
4b5afbb0 2979 Remove one incorrect comment and fix another.
b62a57be 2980
3539f31f
PE
2981 Fix minor ralloc.c problems found by static checking.
2982 See http://lists.gnu.org/archive/html/emacs-devel/2011-12/msg00720.html
2983 * ralloc.c (ALIGNED, ROUND_TO_PAGE, HEAP_PTR_SIZE)
2984 (r_alloc_size_in_use, r_alloc_freeze, r_alloc_thaw): Remove; unused.
2985 (r_alloc_sbrk): Now static.
2986
a041960a
PE
2987 Improve ralloc.c interface checking.
2988 See http://lists.gnu.org/archive/html/emacs-devel/2011-12/msg00720.html
2989 * buffer.c (ralloc_reset_variable, r_alloc, r_re_alloc)
2990 (r_alloc_free) [REL_ALLOC]: Move decls from here ...
2991 * lisp.h (r_alloc, r_alloc_free, r_re_alloc, r_alloc_reset_variable)
2992 [REL_ALLOC]: ... to here, to check interface.
2993 * m/ia64.h (r_alloc, r_alloc_free) [REL_ALLOC && !_MALLOC_INTERNAL]:
2994 Remove decls. This fixes an "It stinks!".
2995
9426aba4
PE
2996 * alloc.c (which_symbols): Fix alignment issue / type clash.
2997
d55c12ed
AS
29982012-04-15 Andreas Schwab <schwab@linux-m68k.org>
2999
3000 * lisp.h (struct Lisp_Symbol): Remove explicit padding.
3001 (struct Lisp_Misc_Any): Likewise.
3002 (struct Lisp_Free): Likewise.
3003 * alloc.c (union aligned_Lisp_Symbol): Define.
3004 (SYMBOL_BLOCK_SIZE, struct symbol_block): Use union
3005 aligned_Lisp_Symbol instead of struct Lisp_Symbol.
3006 (union aligned_Lisp_Misc): Define.
3007 (MARKER_BLOCK_SIZE, struct marker_block): Use union
3008 aligned_Lisp_Misc instead of union Lisp_Misc.
4ae29f89 3009 (Fmake_symbol, allocate_misc, gc_sweep): Adjust.
d55c12ed 3010
b948ce8b
PE
30112012-04-14 Paul Eggert <eggert@cs.ucla.edu>
3012
3013 Make GC_MAKE_GCPROS_NOOPS the default (Bug#9926).
3014 * lisp.h (GC_MARK_STACK): Default to GC_MAKE_GCPROS_NOOPS.
3015 * s/cygwin.h, s/darwin.h, s/freebsd.h, s/gnu.h, s/irix6-5.h, s/msdos.h:
3016 * s/netbsd.h, s/sol2-6.h:
3017 Remove definition of GC_MARK_STACK, since the default now works.
3018 * s/aix4-2.h, s/hpux10-20.h, s/unixware.h:
3019 Define GC_MARK_STACK to GC_USE_GCPROS_AS_BEFORE, since that's
3020 no longer the default.
3021 * s/gnu-linux.h (GC_MARK_STACK): Adjust to change in default.
3022
35dc09a1 30232012-04-14 Atsuo Ohki <ohki@gssm.otsuka.tsukuba.ac.jp> (tiny change)
ad3a2b41 3024
35dc09a1
GM
3025 * lread.c (lisp_file_lexically_bound_p):
3026 Fix hang at ";-*-\n" (bug#11238).
ad3a2b41 3027
35dc09a1
GM
30282012-04-14 Eli Zaretskii <eliz@gnu.org>
3029
3030 * xdisp.c (find_last_unchanged_at_beg_row): Don't consider a row
3031 "unchanged" if its end.pos is beyond ZV. (Bug#11199)
3032
30332012-04-14 Jan Djärv <jan.h.d@swipnet.se>
3034
3035 * nsterm.m (constrainFrameRect): Always constrain when there is only
3036 one screen (Bug#10962).
3037
bcd86815
KB
30382012-04-13 Ken Brown <kbrown@cornell.edu>
3039
3040 * s/cygwin.h (PTY_OPEN): Don't try to close a bogus file descriptor.
3041
c25df26e
RT
30422012-04-13 Reuben Thomas <rrt@sc3d.org>
3043
3044 * indent.c (Fmove_to_column): Change interactive spec (Bug#739).
3045
0fc59f1e
DC
30462012-04-11 Daniel Colascione <dancol@dancol.org>
3047
3048 * s/cygwin.h: The vfork the #define in cygwin.h was protecting
3049 against is gone. It's better to use vfork now so that when Cygwin
3050 gains a new, working vfork, we use it automatically (bug#10398).
3051
de8c03dc
SM
30522012-04-11 Stefan Monnier <monnier@iro.umontreal.ca>
3053
3054 * window.c (save_window_save): Obey window-point-insertion-type.
3055
2f097256
GM
30562012-04-11 Glenn Morris <rgm@gnu.org>
3057
3058 * Makefile.in (GNUSTEP_CFLAGS): Rename from C_SWITCH_X_SYSTEM.
3059
453b951e
SM
30602012-04-11 Stefan Monnier <monnier@iro.umontreal.ca>
3061
3062 * alloc.c (lisp_align_malloc): Remove unneeded prototype.
3063
75f1671a 30642012-04-10 Jason S. Cornez <jcornez@ravenpack.com> (tiny change)
6bbef4e5
JC
3065
3066 * keyboard.c: Override inhibit-quit after the third C-g (bug#6585).
3067 (force_quit_count): New var.
3068 (handle_interrupt): Use it.
3069
2a8ce227
JB
30702012-04-10 Juanma Barranquero <lekktu@gmail.com>
3071
3072 * w32.c (w32_delayed_load): Record the full path of the library
3073 being loaded (bug#10424).
3074
935396c0
GM
30752012-04-09 Glenn Morris <rgm@gnu.org>
3076
05920a43
GM
3077 * doc.c (Fsnarf_documentation): Check variables, functions are bound,
3078 not just in the obarray, before snarfing them. (Bug#11036)
3079
935396c0
GM
3080 * Makefile.in ($(leimdir)/leim-list.el):
3081 Pass EMACS rather than BUILT_EMACS.
3082
a18ecafa
TZ
30832012-04-09 Teodor Zlatanov <tzz@lifelogs.com>
3084
3085 * process.c (make_process):
3086 * process.h: Add integer `gnutls_handshakes_tried' member to
3087 process struct.
3088
6bbef4e5
JC
3089 * gnutls.h: Add `GNUTLS_EMACS_HANDSHAKES_LIMIT' upper limit.
3090 Add convenience `GNUTLS_LOG2i' macro.
a18ecafa
TZ
3091
3092 * gnutls.c (gnutls_log_function2i): Convenience log function.
3093 (emacs_gnutls_read): Use new log functions,
3094 `gnutls_handshakes_tried' process member, and
3095 `GNUTLS_EMACS_HANDSHAKES_LIMIT' to limit the number of handshake
3096 attempts per process (connection).
3097
b4d3bc10
CY
30982012-04-09 Chong Yidong <cyd@gnu.org>
3099
3100 * eval.c (Fuser_variable_p, user_variable_p_eh)
3101 (lisp_indirect_variable): Functions deleted.
3102 (Fdefvar): Caller changed.
3103
3104 * callint.c (Finteractive, Fcall_interactively):
3105 * minibuf.c (Fread_variable): Callers changed.
3106
70f4d973
EZ
31072012-04-09 Eli Zaretskii <eliz@gnu.org>
3108
3109 * xdisp.c (set_cursor_from_row): If the display string appears in
3110 the buffer at position that is closer to point than the position
3111 after the display string, display the cursor on the first glyph of
3112 the display string. Fixes cursor display when a 'display' text
3113 property immediately follows invisible text. (Bug#11094)
3114
cb3c2e3e
PE
31152012-04-09 Paul Eggert <eggert@cs.ucla.edu>
3116
3117 composite.c: use 'double' consistently
3118 * composite.c (get_composition_id): Use 'double' consistently
3119 instead of converting 'float' to 'double' and vice versa; this is
3120 easier to understand and avoids a GCC warning.
3121
fd06db5d
GM
31222012-04-09 Glenn Morris <rgm@gnu.org>
3123
50fe702a
GM
3124 * Makefile.in: Generate leim-list with bootstrap-emacs, in
3125 preparation for dumping it with emacs. (Bug#4789)
3126 (leimdir): New variable.
3127 ($(leimdir)/leim-list.el): New rule.
3128 (emacs$(EXEEXT)): Depend on leim-list.el.
3129
fd06db5d
GM
3130 * buffer.c (Qucs_set_table_for_input): Remove. (Bug#9821)
3131 (Fget_buffer_create): Don't call Qucs_set_table_for_input.
3132 (init_buffer_once, syms_of_buffer): Remove Qucs_set_table_for_input.
3133
55c131ee
AS
31342012-04-08 Andreas Schwab <schwab@linux-m68k.org>
3135
3136 * lisp.h (struct Lisp_Symbol): Add explicit padding to ensure
3137 proper alignment.
3138
9209588f
JB
31392012-04-07 Juanma Barranquero <lekktu@gmail.com>
3140
3141 * xml.c (init_libxml2_functions) [WINDOWSNT]:
3142 Remove unused local variable.
3143
e3fb2efb
PE
31442012-04-07 Paul Eggert <eggert@cs.ucla.edu>
3145
3146 Avoid unnecessary pointer scanning in garbage collection (Bug#10780).
3147 * alloc.c (POINTERS_MIGHT_HIDE_IN_OBJECTS): New macro.
3148 (mark_memory): Mark Lisp_Objects only if pointers might hide in
3149 objects, as mark_maybe_pointer will catch them otherwise.
3150 (GC_LISP_OBJECT_ALIGNMENT): Remove; no longer needed.
3151 * s/gnu-linux.h (GC_LISP_OBJECT_ALIGNMENT) [__mc68000__]: Likewise.
3152
b5385551
PE
31532012-04-07 Paul Eggert <eggert@cs.ucla.edu>
3154
3155 Fix typo that broke non-Windows builds.
3156 * xml.c (libxml2_loaded_p) [!!WINDOWSNT]: 'inine' -> 'inline'.
3157
9078ead6
EZ
31582012-04-07 Eli Zaretskii <eliz@gnu.org>
3159
3160 Support building on MS-Windows with libxml2.
3161
3162 * makefile.w32-in (OBJ2): Add xml.$(O).
3163 (GLOBAL_SOURCES): Add xml.c.
3164 ($(BLD)/xml.$(O)): New dependency list.
3165
3166 * xml.c (DEF_XML2_FN, LOAD_XML2_FN) [WINDOWSNT]: New macros.
3167 (fn_htmlReadMemory, fn_xmlReadMemory, fn_xmlDocGetRootElement)
3168 (fn_xmlFreeDoc, fn_xmlCleanupParser, fn_xmlCheckVersion)
3169 [!WINDOWSNT]: New macros.
3170 (init_libxml2_functions, libxml2_loaded_p): New functions.
3171 (parse_region): Call fn_xmlCheckVersion instead of using the macro
3172 LIBXML_TEST_VERSION. Call libxml2 functions via the fn_* macros.
3173 (xml_cleanup_parser): New function, export for fn_xmlCleanupParser.
3174 Calls xmlCleanupParser only if libxml2 was loaded (or statically
3175 linked in).
6bbef4e5
JC
3176 (Flibxml_parse_html_region, Flibxml_parse_xml_region):
3177 Call init_libxml2_functions before calling libxml2 functions.
9078ead6
EZ
3178 (syms_of_xml) <Qlibxml2_dll>: DEFSYM it.
3179
3180 * emacs.c: Don't include libxml/parser.h.
3181 (shut_down_emacs): Call xml_cleanup_parser, instead of calling
3182 xmlCleanupParser directly.
3183
3184 * lisp.h [HAVE_LIBXML2]: Add prototype for xml_cleanup_parser.
3185
3811fdf3
EZ
31862012-04-07 Eli Zaretskii <eliz@gnu.org>
3187
3188 * indent.c (Fvertical_motion): If there is a display string at
3189 point, use it.vpos to compute how many lines to backtrack after
3190 move_it_to point. (Bug#11133)
3191
2f8e16b2
EZ
31922012-04-06 Eli Zaretskii <eliz@gnu.org>
3193
3194 * buffer.h (FETCH_CHAR, FETCH_MULTIBYTE_CHAR):
3195 * character.h (STRING_CHAR, STRING_CHAR_AND_LENGTH): Add comments
3196 about subtle differences between FETCH_CHAR* and STRING_CHAR*
3197 macros related to unification of CJK characters. For the details,
3198 see the discussion following the message here:
3199 http://debbugs.gnu.org/cgi/bugreport.cgi?bug=11073#14.
3200
3d439cd1
CY
32012012-04-04 Chong Yidong <cyd@gnu.org>
3202
3203 * keyboard.c (Vdelayed_warnings_list): Doc fix.
3204
8bc53d00
EZ
32052012-04-01 Eli Zaretskii <eliz@gnu.org>
3206
3207 * w32menu.c (simple_dialog_show, add_menu_item): Use SAFE_ALLOCA
3208 instead of alloca. (Bug#11138)
3209
3b0512a3
AS
32102012-04-01 Andreas Schwab <schwab@linux-m68k.org>
3211
3212 * w32menu.c (is_simple_dialog): Properly check lisp types.
3213 (Bug#11141)
3214
8427ddd2
EZ
32152012-03-31 Eli Zaretskii <eliz@gnu.org>
3216
979022ef
EZ
3217 * xdisp.c (move_it_by_lines): When DVPOS is positive, and the
3218 position we get to after a call to move_it_to fails the
3219 IS_POS_VALID_AFTER_MOVE_P test, move to the next buffer position
3220 only if we wind up in a string from display property. (Bug#11063)
3221
a6b1c7cc
EZ
3222 * window.c (Fdelete_other_windows_internal): Invalidate the row
3223 and column information about mouse highlight, so that redisplay
3224 restores it after reallocating the glyph matrices. (Bug#7464)
3225
8427ddd2
EZ
3226 * xdisp.c (set_cursor_from_row): If `cursor' property on a display
3227 string comes from a `display' text property, use the buffer
3228 position of that property as if we actually saw that position in
3229 the row's glyphs.
697ba24b
EZ
3230 (move_it_by_lines): Remove the assertion that
3231 "it->current_x == 0 && it->hpos == 0" which can be legitimately
3232 violated when there's a before-string at the beginning of a line.
3233 (Bug#11063)
8427ddd2 3234
65a0a738
EZ
32352012-03-30 Eli Zaretskii <eliz@gnu.org>
3236
3237 * xdisp.c (append_space_for_newline): If the default face was
3238 remapped, use the remapped face for the appended newline.
3239 (extend_face_to_end_of_line): Use the remapped default face for
3240 extending the face to the end of the line.
3241 (display_line): Call extend_face_to_end_of_line when the default
3242 face was remapped. (Bug#11068)
3243
581355cc
EZ
32442012-03-29 Eli Zaretskii <eliz@gnu.org>
3245
3246 * s/ms-w32.h: Discourage from defining HAVE_GETCWD.
3247
e8fc049f
SM
32482012-03-28 Stefan Monnier <monnier@iro.umontreal.ca>
3249
3250 * keyboard.c (safe_run_hooks_error): Don't unquote strings.
3251
4fb9a543
GM
32522012-03-27 Glenn Morris <rgm@gnu.org>
3253
3254 * search.c (Fword_search_backward_lax, Fword_search_forward_lax):
3255 Doc fixes.
3256
679910f1
KH
32572012-03-26 Kenichi Handa <handa@m17n.org>
3258
3259 * dispextern.h (struct glyph): Fix previous change. Change the
3260 bit length of glyphless.ch to 25 (Bug#11082).
3261
90d49b7f
CY
32622012-03-26 Chong Yidong <cyd@gnu.org>
3263
3264 * keyboard.c (Vselection_inhibit_update_commands): New variable.
3265 (command_loop_1): Use it; inhibit selection update for
3266 handle-select-window too (Bug#8996).
3267
f514f6f0
FP
32682012-03-25 Fabrice Popineau <fabrice.popineau@supelec.fr>
3269
e8fc049f 3270 * w32heap.c (_heap_init, _heap_term): Remove dead MSVC-specific code.
f514f6f0 3271
bf43fa51
KH
32722012-03-25 Kenichi Handa <handa@m17n.org>
3273
3274 * dispextern.h (struct glyph): Change the bit length of
3275 glyphless.ch to 22 to make the member glyphless fit in 32 bits.
3276
8a0c01dd
EZ
32772012-03-24 Eli Zaretskii <eliz@gnu.org>
3278
3279 * s/ms-w32.h (tzname): Include time.h before redirecting to
3280 _tzname. Fixes the MSVC build. (Bug#9960)
3281
7d1c3a76
AS
32822012-03-24 Andreas Schwab <schwab@linux-m68k.org>
3283
8ed79523
AS
3284 * xdisp.c (produce_glyphless_glyph): Limit length of acronym to 6
3285 characters.
3286
7d1c3a76
AS
3287 * xterm.c (XTread_socket): Only modify handling_signal if
3288 !SYNC_INPUT. (Bug#11080)
3289
e99a9b8b
EZ
32902012-03-23 Eli Zaretskii <eliz@gnu.org>
3291
3292 * bidi.c (bidi_fetch_char): Use STRING_CHAR_AND_LENGTH instead of
3293 FETCH_MULTIBYTE_CHAR followed by CHAR_BYTES. Prevents crashes
3294 when fetching a multibyte character consumes more bytes than
3295 CHAR_BYTES returns, due to unification of CJK characters in
3296 string_char. (Bug#11073)
3297
5063c0e1
TN
32982012-03-23 Troels Nielsen <bn.troels@gmail.com> (tiny change)
3299
3300 * process.c (wait_reading_process_output): Handle pty disconnect
3301 by refraining from sending oneself a SIGCHLD (bug#10933).
3302
9f851fbd
CY
33032012-03-22 Chong Yidong <cyd@gnu.org>
3304
3305 * dispextern.h (struct it): New member string_from_prefix_prop_p.
3306
5063c0e1 3307 * xdisp.c (push_prefix_prop): Rename from push_display_prop.
9f851fbd
CY
3308 Mark string as coming from a prefix property.
3309 (handle_face_prop): Use default face for prefix strings (Bug#4281).
3310 (pop_it, reseat_1): Save and restore string_from_prefix_prop_p.
3311
fb5b8aca
CY
33122012-03-21 Chong Yidong <cyd@gnu.org>
3313
3314 * xfaces.c (Vface_remapping_alist): Doc fix.
3315
62356a1b
EZ
33162012-03-20 Eli Zaretskii <eliz@gnu.org>
3317
3318 * w32proc.c (Fw32_set_console_codepage)
5063c0e1
TN
3319 (Fw32_set_console_output_codepage, Fw32_get_codepage_charset):
3320 Doc fixes.
62356a1b 3321
025de85b
CY
33222012-03-20 Chong Yidong <cyd@gnu.org>
3323
3324 * dispnew.c (Fredisplay, Vredisplay_preemption_period): Update doc
3325 to reflect default non-nil value of redisplay-dont-pause.
3326
4827f94e
KH
33272012-03-19 Kenichi Handa <handa@m17n.org>
3328
3329 * ftfont.c (ftfont_drive_otf): Mask bits of character code to make
3330 it fit in a valid range (Bug#11003).
3331
e50a24a2
EZ
33322012-03-18 Eli Zaretskii <eliz@gnu.org>
3333
3334 * xdisp.c (cursor_row_p): Even if the glyph row ends in a string
3335 that is not from display property, accept the row as a "cursor
3336 row" if one of the string's character has a non-nil `cursor'
3337 property. Fixes cursor positioning when there are newlines in
3338 overlay strings, e.g. in icomplete.el. (Bug#11035)
3339
9af5ed87
PE
33402012-03-12 Paul Eggert <eggert@cs.ucla.edu>
3341
3342 * buffer.c (compare_overlays): Don't assume args differ (Bug#6830).
3343
d1f55f16
CY
33442012-03-12 Chong Yidong <cyd@gnu.org>
3345
3346 * eval.c (inhibit_lisp_code): Rename from
3347 inhibit_window_configuration_change_hook; move from window.c.
3348
3349 * xfns.c (unwind_create_frame_1, Fx_create_frame):
3350 * window.c (run_window_configuration_change_hook)
3351 (syms_of_window): Callers changed.
3352
66c5eebd
CY
33532012-03-11 Chong Yidong <cyd@gnu.org>
3354
413df973
CY
3355 * keymap.c (Fkey_description): Doc fix (Bug#9700).
3356
66c5eebd
CY
3357 * editfns.c (Fconstrain_to_field): Doc fix (Bug#9452).
3358
1de11f56
CY
33592012-03-10 Chong Yidong <cyd@gnu.org>
3360
3361 * frame.c (other_visible_frames): Don't assume the selected frame
3362 is visible (Bug#10955).
3363
cae07000
SM
33642012-03-09 Stefan Monnier <monnier@iro.umontreal.ca>
3365
3366 * buffer.c (compare_overlays): Avoid qsort's instability (bug#6830).
3367
89c94350
JD
33682012-03-08 Jan Djärv <jan.h.d@swipnet.se>
3369
3370 * gtkutil.c (x_wm_set_size_hint): Use one row in call to
3371 FRAME_TEXT_LINES_TO_PIXEL_HEIGHT so base_height is greater than
3372 zero (Bug#10954).
3373
999dd333
GM
33742012-03-03 Glenn Morris <rgm@gnu.org>
3375
01a6dcc8 3376 * alloc.c (Fgarbage_collect, misc-objects-consed): Doc fixes.
999dd333 3377
de0100f2
EZ
33782012-03-02 Eli Zaretskii <eliz@gnu.org>
3379
3380 * xdisp.c (try_window_reusing_current_matrix): Don't move cursor
3381 position past the first glyph_row that ends at ZV. (Bug#10902)
b8456c5c
EZ
3382 (redisplay_window, next_element_from_string): Fix typos in
3383 comments.
3e441275
EZ
3384 (redisplay_window): Pass to move_it_vertically the margin in
3385 pixels, not in screen lines.
de0100f2 3386
96a72ee9
GM
33872012-03-02 Glenn Morris <rgm@gnu.org>
3388
3389 * buffer.c (buffer-list-update-hook): Doc fix.
3390
312508d7
EZ
33912012-02-29 Eli Zaretskii <eliz@gnu.org>
3392
3393 * xdisp.c (get_overlay_strings_1): Under bidi redisplay, call
3394 push_it before setting up the iterator for the first overlay
3395 string, even if we have an empty string loaded.
3396 (next_overlay_string): If there's an empty string on the iterator
3397 stack, pop the stack. (Bug#10903)
3398
27f3c637
PE
33992012-02-25 Paul Eggert <eggert@cs.ucla.edu>
3400
3401 Generalize fix for crash due to non-contiguous EMACS_INT (Bug#10780).
3402 Suggested by Stefan Monnier in
3403 <http://lists.gnu.org/archive/html/emacs-devel/2012-02/msg00692.html>.
3404 * alloc.c (widen_to_Lisp_Object): New static function.
3405 (mark_memory): Also mark Lisp_Objects by fetching pointer words
3406 and widening them to Lisp_Objects. This would work even if
3407 USE_LSB_TAG is defined and wide integers are used, which might
3408 happen in a future version of Emacs.
3409
3c9dfce6
CY
34102012-02-25 Chong Yidong <cyd@gnu.org>
3411
fa74b241
CY
3412 * fileio.c (Ffile_selinux_context, Fset_file_selinux_context):
3413 Doc fix.
3414
3c9dfce6
CY
3415 * xselect.c (Fx_selection_exists_p): Doc fix.
3416 (x_clipboard_manager_save_all): Print an informative message
3417 before saving to clipboard manager.
3418
9486df08
CY
34192012-02-24 Chong Yidong <cyd@gnu.org>
3420
3421 * keyboard.c (process_special_events): Handle all X selection
3422 requests in kbd_buffer, not just the next one (Bug#8869).
3423
f01d3321
CY
34242012-02-23 Chong Yidong <cyd@gnu.org>
3425
3426 * xfns.c (Fx_create_frame): Avoid window-configuration-change-hook
3427 call when setting menu-bar-lines and tool-bar-lines parameters.
3428 (unwind_create_frame_1): New helper function.
3429
3430 * window.c (inhibit_window_configuration_change_hook): New var.
3431 (run_window_configuration_change_hook): Obey it.
b2e4ca7d 3432 (syms_of_window): Initialize it.
f01d3321 3433
86b847b6
CY
34342012-02-22 Chong Yidong <cyd@gnu.org>
3435
3436 * xterm.c (x_draw_image_relief): Add missing type check for
3437 Vtool_bar_button_margin (Bug#10743).
3438
a59225b1
CY
34392012-02-21 Chong Yidong <cyd@gnu.org>
3440
3441 * fileio.c (Vfile_name_handler_alist): Doc fix.
3442
3443 * buffer.c (Fget_file_buffer): Protect against invalid file
3444 handler return value.
3445
310f5bd4
PE
34462012-02-20 Paul Eggert <eggert@cs.ucla.edu>
3447
cb3a28cc
PE
3448 * .gdbinit (xreload): Don't assume EMACS_INT fits in 'long'
3449 when computing $valmask.
3450
310f5bd4
PE
3451 Fix crash due to non-contiguous EMACS_INT (Bug#10780).
3452 * lisp.h (VALBITS): Move definition up, so that USE_LSB_TAG can use it.
3453 (USE_LSB_TAG): Do not define if UINTPTR_MAX >> VALBITS == 0.
3454 It's useless in that case, and it can cause problems on hosts
3455 that allocate halves of EMACS_INT values separately.
3456 Reported by Dan Horák. Diagnosed by Andreas Schwab in
3457 <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=10780#30>.
3458 * mem-limits.h (EXCEEDS_LISP_PTR): Define to 0 on hosts where
3459 UINTPTR_MAX >> VALBITS == 0. This is required by the above change;
3460 it avoids undefined behavior on hosts where shifting right by more
3461 than the word width has undefined behavior.
3462
2375c96a
CY
34632012-02-19 Chong Yidong <cyd@gnu.org>
3464
3465 * fileio.c (Ffile_name_directory, Ffile_name_nondirectory)
3466 (Funhandled_file_name_directory, Ffile_name_as_directory)
3467 (Fdirectory_file_name, Fexpand_file_name)
3468 (Fsubstitute_in_file_name): Protect against invalid file handler
3469 return values (Bug#10845).
3470
3eb49e71
EZ
34712012-02-18 Eli Zaretskii <eliz@gnu.org>
3472
3473 * .gdbinit (pitx): Fix incorrect references to fields of the
3474 iterator stack.
3475
7b926f3f
CY
34762012-02-17 Chong Yidong <cyd@gnu.org>
3477
3478 * syntax.c (Fscan_lists): Doc fix (Bug#10833).
3479
11273115
PE
34802012-02-15 Paul Eggert <eggert@cs.ucla.edu>
3481
3482 * image.c (MAX_IMAGE_SIZE): Increase from 6.0 to 10.0; see
3483 <http://lists.gnu.org/archive/html/emacs-devel/2012-02/msg00540.html>.
3484
c3a70e2b
CY
34852012-02-15 Chong Yidong <cyd@gnu.org>
3486
3487 * eval.c (Fdefvar, Fdefconst): Doc fix; note that the variable is
3488 marked as special. Also, starting docstrings with * is obsolete.
3489
0ca43699
AS
34902012-02-13 Andreas Schwab <schwab@linux-m68k.org>
3491
3492 * gnutls.c (emacs_gnutls_write): Fix last change.
3493
2e8f3c56
LI
34942012-02-13 Lars Ingebrigtsen <larsi@gnus.org>
3495
3496 * gnutls.c (emacs_gnutls_write): Set errno appropriately for
3497 send_process.
3498
af70074f
SM
34992012-02-13 Stefan Monnier <monnier@iro.umontreal.ca>
3500
3501 * keymap.c (Fsingle_key_description): Handle char ranges.
3502
95986d52
CY
35032012-02-12 Chong Yidong <cyd@gnu.org>
3504
afd83bd1
CY
3505 * xdisp.c (handle_stop): Avoid assigning -1 to it->face_id here,
3506 as that creates a dangerous corner case.
3507
95986d52
CY
3508 * window.c (Fdelete_window_internal): Invalidate the mouse
3509 highlight (Bug#9904).
3510
bd7da63e
GM
35112012-02-12 Glenn Morris <rgm@gnu.org>
3512
3513 * xselect.c (Fx_own_selection_internal)
3514 (Fx_get_selection_internal, Fx_disown_selection_internal)
3515 (Fx_selection_owner_p, Fx_selection_exists_p): Doc fixes.
3516 * nsselect.m (Fx_own_selection_internal)
3517 (Fx_disown_selection_internal, Fx_selection_exists_p)
3518 (Fx_selection_owner_p, Fx_get_selection_internal):
3519 Sync docs and argument specs with the xselect.c versions.
3520
77abcbc2
LI
35212012-02-11 Lars Ingebrigtsen <larsi@gnus.org>
3522
3523 * gnutls.c (emacs_gnutls_write): Don't infloop if sendto fails.
3524
90b671e2
EZ
35252012-02-11 Eli Zaretskii <eliz@gnu.org>
3526
1c0ca0b7
EZ
3527 * w32select.c (Fx_selection_exists_p): Sync doc string and
3528 argument list with xselect.c. (Bug#10783)
3529
3530 * w16select.c (Fx_selection_exists_p): Sync doc string and
3531 argument list with xselect.c. (Bug#10783)
90b671e2 3532
49241268
GM
35332012-02-10 Glenn Morris <rgm@gnu.org>
3534
3535 * fns.c (Fsecure_hash): Doc fix.
3536
f998bbe7 35372012-02-09 Kenichi Handa <handa@m17n.org>
5c1ca13d
KH
3538
3539 * coding.c (produce_chars): Fix updating of src_end (Bug#10701).
3540
0992bd9c
CY
35412012-02-07 Chong Yidong <cyd@gnu.org>
3542
3543 * buffer.c (Fbuffer_local_variables)
3544 (buffer_lisp_local_variables): Handle unbound vars correctly;
3545 don't let Qunbound leak into Lisp.
3546
af008560
GM
35472012-02-07 Glenn Morris <rgm@gnu.org>
3548
dd605cc4
GM
3549 * image.c (Fimagemagick_types): Doc fix.
3550
af008560
GM
3551 * image.c (imagemagick-render-type): Change it from a lisp object
3552 to an integer. Move the doc here from the lisp manual.
3553 Treat all values not equal to 0 the same.
3554
1449fa1d
CY
35552012-02-06 Chong Yidong <cyd@gnu.org>
3556
3557 * doc.c (store_function_docstring): Avoid applying docstring of
3558 alias to base function (Bug#2603).
3559
3723ec07
AS
35602012-02-04 Andreas Schwab <schwab@linux-m68k.org>
3561
3562 * .gdbinit (pp1, pv1): Remove redundant defines.
3563 (pr): Use pp.
3564
79c1cc1e
CY
35652012-02-04 Chong Yidong <cyd@gnu.org>
3566
3567 * nsterm.m: Declare a global (Bug#10694).
3568
d7f29f8e
EZ
35692012-02-04 Eli Zaretskii <eliz@gnu.org>
3570
cae07000
SM
3571 * w32.c (get_emacs_configuration_options):
3572 Include --enable-checking, if specified, in the return value.
d7f29f8e 3573
3b95a6f9
MR
35742012-02-04 Martin Rudalics <rudalics@gmx.at>
3575
3576 * dispnew.c (change_frame_size_1): Calculate new_frame_total_cols
3577 after rounding frame sizes. (Bug#9723)
3578
d6fa96a6
EZ
35792012-02-04 Eli Zaretskii <eliz@gnu.org>
3580
3581 * keyboard.c (adjust_point_for_property): Don't position point
3582 before BEGV. (Bug#10696)
3583
df0b2940
PE
35842012-02-03 Paul Eggert <eggert@cs.ucla.edu>
3585
3586 Handle overflow when computing char display width (Bug#9496).
3587 * character.c (char_width): Return EMACS_INT, not int.
3588 (char_width, c_string_width): Check for overflow when
3589 computing the width; this is possible now that individual
3590 characters can have unbounded width. Problem introduced
3591 by merge from Emacs 23 on 2012-01-19.
3592
6bee44d6
MA
35932012-02-02 Michael Albinus <michael.albinus@gmx.de>
3594
3595 * dbusbind.c (Fdbus_register_method): Mention the return value
3596 :ignore in the docstring.
3597
44f92739
GM
35982012-02-02 Glenn Morris <rgm@gnu.org>
3599
1b9f60cc
GM
3600 * callproc.c (Fcall_process, Fcall_process_region): Doc fix.
3601
44f92739
GM
3602 * nsterm.m (syms_of_nsterm) <x-toolkit-scroll-bars>:
3603 Unconditionally set to t. (Bug#10673)
3604 * nsterm.m (syms_of_nsterm) <x-toolkit-scroll-bars>:
3605 * w32term.c (syms_of_w32term) <x-toolkit-scroll-bars>:
3606 * xterm.c (syms_of_xterm) <x-toolkit-scroll-bars>: Doc fix.
3607
c5d3843c
KH
36082012-02-02 Kenichi Handa <handa@m17n.org>
3609
3610 (x_produce_glyphs): Cancel previous change. If cmp->glyph_len is
3611 0, do not call append_composite_glyph.
3612
159462d4 36132012-02-02 Kenichi Handa <handa@m17n.org>
d2a51fd7
KH
3614
3615 * xdisp.c (BUILD_COMPOSITE_GLYPH_STRING): Initialize first_s to
3616 NULL (Bug#6988).
3617 (x_produce_glyphs): If the component of a composition is a null
3618 string, set it->pixel_width to 1 to avoid zero-width glyph.
3619
78cef877
EZ
36202012-02-01 Eli Zaretskii <eliz@gnu.org>
3621
3622 * ralloc.c (resize_bloc, r_alloc_sbrk): Don't call memmove if its
3623 first 2 arguments are identical. This makes inserting large
3624 output from a subprocess an order of magnitude faster on
3625 MS-Windows, where all sbrk'ed memory is always contiguous.
3626
97897668
GM
36272012-01-31 Glenn Morris <rgm@gnu.org>
3628
3629 * nsterm.m (syms_of_nsterm) <x-toolkit-scroll-bars>:
c78c6e0b 3630 * w32term.c (syms_of_w32term) <x-toolkit-scroll-bars>:
97897668
GM
3631 * xterm.c (syms_of_xterm) <x-toolkit-scroll-bars>: Sync docs.
3632
31fd3586
GM
36332012-01-29 Glenn Morris <rgm@gnu.org>
3634
3635 * gnutls.c (syms_of_gnutls): More doc (from etc/NEWS).
3636
0e24a8b2
CY
36372012-01-28 Samuel Thibault <sthibault@debian.org> (tiny change)
3638
3639 * s/gnu.h: Define POSIX_SIGNALS (Bug#10552).
3640
cc0adcb0
CY
36412012-01-28 Chong Yidong <cyd@gnu.org>
3642
3643 * minibuf.c (syms_of_minibuf): Doc fix (Bug#10550).
3644
acc28cb9
CY
36452012-01-26 Chong Yidong <cyd@gnu.org>
3646
9c69cfb7
CY
3647 * keyboard.c (Vecho_keystrokes): Document zero value (Bug#10503).
3648
acc28cb9
CY
3649 * search.c (Fsearch_forward, Fsearch_backward): Document negative
3650 repeat counts (Bug#10507).
3651
48da7392
GM
36522012-01-26 Glenn Morris <rgm@gnu.org>
3653
3654 * lread.c (syms_of_lread): Doc fix.
3655
14af5f7f
CY
36562012-01-25 HIROSHI OOTA <nil@mad.dog.cx> (tiny change)
3657
3658 * coding.c (encode_designation_at_bol): Change return value to
3659 EMACS_INT.
3660
0b21c100
CY
36612012-01-25 Chong Yidong <cyd@gnu.org>
3662
3663 * eval.c (Fuser_variable_p): Doc fix; mention custom-variable-p.
3664
3c2907f7
CY
36652012-01-21 Chong Yidong <cyd@gnu.org>
3666
3667 * floatfns.c (Fcopysign): Make the second argument non-optional,
3668 since nil is not allowed anyway.
3669
959ad23f
AS
36702012-01-21 Andreas Schwab <schwab@linux-m68k.org>
3671
3672 * process.c (read_process_output): Use p instead of XPROCESS (proc).
3673 (send_process): Likewise.
3674
34a02f46
MR
36752012-01-19 Martin Rudalics <rudalics@gmx.at>
3676
3677 * window.c (save_window_save, Fcurrent_window_configuration)
cae07000
SM
3678 (Vwindow_persistent_parameters): Do not use Qstate.
3679 Rewrite doc-strings.
34a02f46 3680
1259009a 36812012-01-19 Kenichi Handa <handa@m17n.org>
25ed9e61
KH
3682
3683 * character.c (char_width): New function.
70d4fdf6
GM
3684 (Fchar_width, c_string_width, lisp_string_width):
3685 Use char_width (Bug#9496).
25ed9e61 3686
6a6ee00d
MR
36872012-01-16 Martin Rudalics <rudalics@gmx.at>
3688
3689 * window.c (Vwindow_persistent_parameters): New variable.
3690 (Fset_window_configuration, save_window_save): Handle persistent
3691 window parameters.
3692
c85efaf7
EZ
36932012-01-14 Eli Zaretskii <eliz@gnu.org>
3694
3695 * w32fns.c (signal_user_input): Don't do a QUIT, to avoid
3696 thrashing the stack of the thread. (Bug#9087)
3697
5944709e
PE
36982012-01-12 Paul Eggert <eggert@cs.ucla.edu>
3699
3700 * xdisp.c (rows_from_pos_range): Add parens as per gcc -Wparentheses.
3701
e71f5d99
EZ
37022012-01-11 Eli Zaretskii <eliz@gnu.org>
3703
3704 * xdisp.c (rows_from_pos_range): Handle the case where the
3705 highlight ends on a newline. (Bug#10464)
3706 (mouse_face_from_buffer_pos): Fix off-by-one error in calculating
3707 he end column for display of highlight that ends on a newline
3708 before a R2L line.
3709
ce316182
GM
37102012-01-11 Glenn Morris <rgm@gnu.org>
3711
3712 * lread.c (init_lread): If no-site-lisp, remove site-lisp dirs
3713 from load-path also when installation-directory is nil. (Bug#10208)
3714
5b43da69
GM
37152012-01-10 Glenn Morris <rgm@gnu.org>
3716
74cc8ff9
GM
3717 * emacs.c (syms_of_emacs) <installation-directory>: Doc fix.
3718
7d8d6e4e
GM
3719 * epaths.in (PATH_LOADSEARCH, PATH_EXEC, PATH_DATA, PATH_DOC):
3720 Update template values to be closer to their typical values these days.
5b43da69 3721
a0db8d43
EZ
37222012-01-09 Eli Zaretskii <eliz@gnu.org>
3723
3724 * xdisp.c (rows_from_pos_range): Accept additional argument
3725 DISP_STRING, and accept any glyph in a row whose object is that
3726 string as eligible for mouse highlight. Fixes mouse highlight of
3727 display strings from overlays. (Bug#10464)
3728
9a0115ab 37292012-01-07 Paul Eggert <eggert@cs.ucla.edu>
09450bae 3730
b9110d6a 3731 emacs: fix an auto-save permissions race condition (Bug#10400)
09450bae
PE
3732 * fileio.c (auto_saving_dir_umask): New static var.
3733 (Fmake_directory_internal): Use it.
3734 (do_auto_save_make_dir): Set it, instead of invoking chmod after
3735 creating the directory. The old code temporarily assigns
3736 too-generous permissions to the directory.
3737 (do_auto_save_eh): Clear it.
b9110d6a 3738 (Fdo_auto_save): Catch all errors, not just file errors, so
09450bae
PE
3739 that the var is always cleared.
3740
6c1bd3f3
EZ
37412012-01-07 Eli Zaretskii <eliz@gnu.org>
3742
3743 * search.c (scan_buffer): Pass character positions to
3744 know_region_cache, not byte positions. (Bug#6540)
3745
069d2b50
L
37462012-01-07 LynX <_LynX@bk.ru> (tiny change)
3747
3748 * w32.c (sys_rename): Report EXDEV when rename of a directory
3749 fails because the target is on another logical disk. (Bug#10284)
3750
75bf0d33
DB
37512012-01-07 David Benjamin <davidben@mit.edu> (tiny change)
3752
3753 * xterm.c (x_embed_request_focus): New function.
3754
3755 * xterm.h: Add prototype.
3756
3757 * xfns.c (Fx_focus_frame): Use it for embedded frames (Bug#9977).
3758
1c6e5a32
GM
37592012-01-05 Glenn Morris <rgm@gnu.org>
3760
3761 * emacs.c (emacs_copyright): Update short copyright year to 2012.
3762
651e947e
EZ
37632012-01-01 Eli Zaretskii <eliz@gnu.org>
3764
3765 * gnutls.c (init_gnutls_functions): Load gnutls_check_version.
3766 Load gnutls_transport_set_lowat only if GnuTLS version is below
3767 2.11.1.
3768 (emacs_gnutls_handshake): Call gnutls_transport_set_lowat only for
3769 GnuTLS versions below 2.11.1.
3770
3778cdd8
AL
37712011-12-31 Antoine Levitt <antoine.levitt@gmail.com>
3772
3773 * xdisp.c (syms_of_xdisp) <window-scroll-functions>: Add warning
3774 to the doc string advising against its use for altering the way
3775 windows are scrolled.
3776
0e5317f7
KH
37772011-12-28 Kenichi Handa <handa@m17n.org>
3778
3779 * coding.c (Fdefine_coding_system_internal): Make an utf-8 base
3780 coding-system ASCII compatible only when it does not produce BOM
3781 on encoding (Bug#10383).
3782
93d5ca1f
JD
37832011-12-26 Jan Djärv <jan.h.d@swipnet.se>
3784
3785 * xmenu.c (x_menu_wait_for_event): Use xg_select for Gtk3 so menus
3786 can scroll.
3787 (create_and_show_popup_menu): Always use menu_position_func for
3788 Gtk3 (Bug#10361).
3789
ca22b785
AS
37902011-12-24 Andreas Schwab <schwab@linux-m68k.org>
3791
3792 * callint.c (Fcall_interactively): Don't truncate prompt string.
3793
d048e1e6
EZ
37942011-12-23 Eli Zaretskii <eliz@gnu.org>
3795
3796 * xdisp.c (handle_invisible_prop): Handle correctly an invisible
3797 property that ends at ZV, so that the bidi iteration could be
3ba1a2ad 3798 resumed from there (after widening). (Bug#10360)
d048e1e6 3799
5ccaba1f
JD
38002011-12-22 Jan Djärv <jan.h.d@swipnet.se>
3801
3802 * nsfont.m (ns_spec_to_descriptor): Do not autorelease fdesc.
3803
204ee57f
JD
38042011-12-21 Jan Djärv <jan.h.d@swipnet.se>
3805
b81d40f0
JB
3806 * nsterm.m (x_free_frame_resources):
3807 Release f->output_data.ns->miniimage.
204ee57f
JD
3808 (ns_index_color): Fix indentation. Do not retain
3809 color_table->colors[i].
3810
3811 * nsmenu.m (ns_update_menubar): Call free_menubar_widget_value_tree
3812 before returning.
3813
3814 * nsfns.m (x_set_background_color): Assign return value from
3815 ns_index_color to face-background instead of NSColor*.
3816 (ns_implicitly_set_icon_type): Fix indentation.
3817 Change assignment in for loop to comparison.
3818
3819 * emacs.c (ns_pool): New variable.
3820 (main): Assign ns_pool.
3821 (Fkill_emacs): Call ns_release_autorelease_pool.
3822
3823 * nsfont.m (ns_spec_to_descriptor): Fix indentation,
3824 autorelease fdesc, release fdAttrs and tdict.
3825 (ns_get_covering_families): Release charset.
3826 (ns_findfonts): Release NSFontDescriptor created with new.
3827 (ns_uni_to_glyphs): Fix indentation.
3828 (setString): Release attrStr before assigning new value.
3829
c803b2b7
JD
38302011-12-18 Jan Djärv <jan.h.d@swipnet.se>
3831
678f4426
JD
3832 * nsmenu.m (NSMenuDidBeginTrackingNotification): Declare if OSX < 10.5
3833 and NS_IMPL_COCOA.
3834 (trackingNotification): Surround with ifdef NS_IMPL_COCOA.
3835 (syms_of_nsmenu): Set trackingMenu to 1 if not NS_IMPL_COCOA.
3836
cd394be1 38372011-12-18 David Reitter <reitter@cmu.edu>
678f4426 3838
5fecd5fc
JD
3839 * nsterm.m (ns_term_init): Subscribe for notifications
3840 NSMenuDidBeginTrackingNotification and NSMenuDidEndTrackingNotification
3841 to method trackingNotification in EmacsMenu.
3842
3843 * nsmenu.m (trackingMenu): New variable.
3771cb17 3844 (trackingNotification): New method (from Aquamacs).
5fecd5fc 3845 (menuNeedsUpdate): Expand comment and return if trackingMenu is 0,
3771cb17 3846 from Aquamacs (Bug#7030).
678f4426
JD
3847
38482011-12-18 Jan Djärv <jan.h.d@swipnet.se>
5fecd5fc 3849
c803b2b7
JD
3850 * nsselect.m (CUT_BUFFER_SUPPORT): Remove define.
3851 (symbol_to_nsstring): Fix indentation.
3852 (ns_symbol_to_pb): New function.
cae07000
SM
3853 (Fns_get_selection_internal): Rename from Fns_get_cut_buffer_internal.
3854 (Fns_rotate_cut_buffers_internal): Remove.
3855 (Fns_store_selection_internal): Rename from
c803b2b7
JD
3856 Fns_store_cut_buffer_internal.
3857 (ns_get_foreign_selection, Fx_own_selection_internal)
3858 (Fx_disown_selection_internal, Fx_selection_exists_p)
b81d40f0
JB
3859 (Fns_get_selection_internal, Fns_store_selection_internal):
3860 Use ns_symbol_to_pb and check if return value is nil.
3861 (syms_of_nsselect): Remove ifdef CUT_BUFFER_SUPPORT. Remove defsubr
3862 Sns_rotate_cut_buffers_internal. Sns_get_cut_buffer_internal
c803b2b7
JD
3863 renamed to Sns_get_selection_internal, Sns_store_cut_buffer_internal
3864 renamed to Sns_store_selection_internal.
3865 (ns_handle_selection_request): Move code to Fx_own_selection_internal
3866 and remove this function.
3867 (ns_handle_selection_clear): Remove, never used.
3868 (Fx_own_selection_internal): Move code from ns_handle_selection_request
3869 here.
3870
e1b01a3a
KB
38712011-12-17 Ken Brown <kbrown@cornell.edu>
3872
3873 * fileio.c (check_writable) [CYGWIN]: Return non-zero if UID or
3874 GID is unknown (Bug#10257).
3875
2adb6e85
PE
38762011-12-17 Paul Eggert <eggert@cs.ucla.edu>
3877
3878 * s/gnu-linux.h: Fix mark_memory typo (Bug#10286).
3879 (GC_MARK_SECONDARY_STACK): Omit removed 3rd arg to mark_memory,
3880 which caused a build failure on GNU/Linux IA-64. This problem was
3881 introduced by my 2011-10-07 patch.
3882
d1d7b339
JL
38832011-12-15 Juri Linkov <juri@jurta.org>
3884
3885 * image.c (imagemagick_error): New function. (Bug#10112)
3886 (imagemagick_load_image): Comment out `MagickSetResolution' call.
3887 Use `imagemagick_error' where ImageMagick functions return
3888 `MagickFalse'.
3889 (Fimagemagick_types): Add `Fnreverse' to return the list in the
3890 proper order.
3891
100d5755
KH
38922011-12-15 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
3893
3894 * xftfont.c (xftfont_draw): Use the font metrics of s->font to
3895 fill background (Bug#8992).
3896
454592a6
MR
38972011-12-13 Martin Rudalics <rudalics@gmx.at>
3898
3899 * window.c (Vwindow_combination_resize)
3900 (Vwindow_combination_limit): Use t instead of non-nil in
3901 doc-strings.
61d4b438
MR
3902 (Vrecenter_redisplay): Add first sentence of doc-string on
3903 separate line.
53524d93 3904 (Frecenter): Fix doc-string typo.
454592a6 3905
3633e3aa
KH
39062011-12-11 Kenichi Handa <handa@m17n.org>
3907
3908 * coding.c (Funencodable_char_position): Pay attention to the
3909 buffer text relocation (Bug#9389).
3910
7b9d523a 39112011-12-10 Jan Djärv <jan.h.d@swipnet.se>
61ccba97 3912
7b9d523a
JD
3913 * xterm.c (x_term_init): Move call to gdk_window_add_filter before
3914 gtk_init (Bug#10100).
3915
b73189c6
EZ
39162011-12-10 Eli Zaretskii <eliz@gnu.org>
3917
3918 * xdisp.c (RECORD_MAX_MIN_POS): Use IT->cmp_it.charpos only if
3919 IT->string is nil. (Bug#10263)
3920
f7dfe5d6
JD
39212011-12-10 Jan Djärv <jan.h.d@swipnet.se>
3922
83faebb4
JD
3923 * nsterm.h (x_free_frame_resources): Declare.
3924
f7dfe5d6
JD
3925 * nsfns.m (ns_get_defaults_value): New function (Bug#10103).
3926 (Fns_get_resource, x_get_string_resource): Call ns_get_defaults_value.
3927
3928 * nsterm.h (ns_get_defaults_value): Declare.
3929
3930 * nsterm.m (ns_default): Call ns_get_defaults_value.
3931
7cd4e72c
EZ
39322011-12-09 Eli Zaretskii <eliz@gnu.org>
3933
3934 * xdisp.c (try_scrolling): Don't set scroll_down_p if dy is zero.
3935 (Bug#10170)
3936
b34d7317
YM
39372011-12-09 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
3938
3939 * unexelf.c (unexec) [NS_IMPL_GNUSTEP]: Take account of the case
3940 that where the value of an _OBJC_* symbol points to is in the .bss
3941 section (Bug#10240).
3942
76470ad1
KH
39432011-12-08 Kazuhiro Ito <kzhr@d1.dion.ne.jp> (tiny change)
3944
3945 * coding.c (encode_coding_ccl): Check (charbuf < charbuf_end)
2fac8180 3946 after the loop to call ccl_driver at least once (Bug#8619).
76470ad1 3947
745fff94
KH
39482011-12-08 Kenichi Handa <handa@m17n.org>
3949
3950 * ftfont.c (get_adstyle_property): Fix previous change
3951 (Bug#10233).
3952
6e44397c
JB
39532011-12-07 Juanma Barranquero <lekktu@gmail.com>
3954
3955 * w32.c (init_environment): If no_site_lisp, remove site-lisp
3956 dirs from the default value of EMACSLOADPATH (bug#10208).
3957
7efa6272
GM
39582011-12-07 Glenn Morris <rgm@gnu.org>
3959
3960 * lread.c (init_lread): If no_site_lisp, exclude site-lisp/ in
3961 installation and source directories as well. (Bug#10208)
3962
f6fc4d87
CY
39632011-12-06 Chong Yidong <cyd@gnu.org>
3964
3965 * minibuf.c (Fread_from_minibuffer): Doc fix (Bug#10228).
3966
2bf26180
GM
39672011-12-06 Glenn Morris <rgm@gnu.org>
3968
3969 * process.c (start_process_unwind): Treat any pid <= 0, except -2,
3970 as an error, not just -1. (Bug#10217)
3971
3a6ad4f0
CY
39722011-12-05 Chong Yidong <cyd@gnu.org>
3973
3974 * keyboard.c (process_special_events): New function.
3975 (swallow_events, Finput_pending_p): Use it (Bug#10195).
3976
75a3b399
PE
39772011-12-05 Paul Eggert <eggert@cs.ucla.edu>
3978
3979 * coding.c (encode_designation_at_bol): Don't use uninitialized
3980 local variable (Bug#9318).
3981
c3c9e25e
KH
39822011-12-05 Kenichi Handa <handa@m17n.org>
3983
3984 * ftfont.c (get_adstyle_property): If the font is not BDF nor PCF,
3985 return Qnil (Bug#8046, Bug#10193).
3986
5eb05ea3
KH
39872011-12-05 Kenichi Handa <handa@m17n.org>
3988
3989 * coding.c (encode_designation_at_bol): New args charbuf_end and
3990 dst. Return the number of produced bytes. Callers changed.
a79703f5
KH
3991 (coding_set_source): Return how many bytes coding->source was
3992 relocated.
3993 (coding_set_destination): Return how many bytes
3994 coding->destination was relocated.
3995 (CODING_DECODE_CHAR, CODING_ENCODE_CHAR, CODING_CHAR_CHARSET)
cae07000 3996 (CODING_CHAR_CHARSET_P): Adjust for the avove changes.
5eb05ea3
KH
3997
39982011-12-05 Kazuhiro Ito <kzhr@d1.dion.ne.jp> (tiny change)
3999
4000 * coding.c (CODING_CHAR_CHARSET_P): New macro.
4001 (encode_coding_emacs_mule, encode_coding_iso_2022): Use the above
4002 macro (Bug#9318).
4003
40042011-12-05 Andreas Schwab <schwab@linux-m68k.org>
4005
4006 The following changes are to fix Bug#9318.
4007
a79703f5 4008 * coding.c (CODING_ENCODE_CHAR, CODING_CHAR_CHARSET): New macros.
5eb05ea3
KH
4009 (encode_coding_emacs_mule, ENCODE_ISO_CHARACTER)
4010 (encode_coding_iso_2022, encode_coding_sjis)
a79703f5 4011 (encode_coding_big5, encode_coding_charset): Use the above macros.
5eb05ea3 4012
7dbda6df
JB
40132011-12-05 Juanma Barranquero <lekktu@gmail.com>
4014
4015 * lisp.h (process_quit_flag): Fix external declaration.
4016
6d5eb5b0
SM
40172011-12-04 Stefan Monnier <monnier@iro.umontreal.ca>
4018
4019 Don't macro-inline non-performance-critical code.
4020 * eval.c (process_quit_flag): New function.
4021 * lisp.h (QUIT): Use it.
4022
a0c3fad0
JD
40232011-12-04 Jan Djärv <jan.h.d@swipnet.se>
4024
4025 * nsfns.m (get_geometry_from_preferences): New function.
4026 (Fx_create_frame): Call get_geometry_from_preferences (Bug#10103).
4027
6c07aac2
AS
40282011-12-04 Andreas Schwab <schwab@linux-m68k.org>
4029
4030 * emacs.c (Qkill_emacs): Define.
4031 (syms_of_emacs): Initialize it.
4032 * keyboard.c (interrupt_signal): Don't call Fkill_emacs here, set
4033 Qquit_flag to `kill-emacs' instead.
6d5eb5b0
SM
4034 (quit_throw_to_read_char): Add parameter `from_signal'.
4035 All callers changed. Call Fkill_emacs if requested and safe.
6c07aac2
AS
4036 * lisp.h (QUIT): Call Fkill_emacs if requested.
4037
c052ead4
JD
40382011-12-03 Jan Djärv <jan.h.d@swipnet.se>
4039
4040 * widget.c (update_wm_hints): Return if wmshell is null.
4041 (widget_update_wm_size_hints): New function.
4042
4043 * widget.h (widget_update_wm_size_hints): Declare.
4044
4045 * xterm.c (x_wm_set_size_hint): If USE_X_TOOLKIT, call
4046 widget_update_wm_size_hints (Bug#10104).
4047
9e49252b
EZ
40482011-12-03 Eli Zaretskii <eliz@gnu.org>
4049
4050 * xdisp.c (handle_invisible_prop): If the invisible text ends just
4051 before a newline, prepare the bidi iterator for consuming the
4052 newline, and keep the current paragraph direction. (Bug#10183)
e9a49426 4053 (redisplay_window): Don't let `margin' become negative. (Bug#10192)
9e49252b 4054
02b16839
JL
40552011-12-02 Juri Linkov <juri@jurta.org>
4056
4057 * search.c (Fword_search_regexp): New Lisp function created from
4058 `wordify'. Change type of arg `lax' from `int' to `Lisp_Object'.
4059 (Fword_search_backward, Fword_search_forward)
4060 (Fword_search_backward_lax, Fword_search_forward_lax):
4061 Use `Fword_search_regexp' instead of `wordify'. Doc fix.
4062 (syms_of_search): Define `Sword_search_regexp'. (Bug#10145)
4063
0068070e
SM
40642011-12-01 Stefan Monnier <monnier@iro.umontreal.ca>
4065
4066 * fileio.c (Finsert_file_contents): Move after-change-function call
4067 to before the "handled:" label, since all "goto handled" appear in
4068 cases where the *-change-functions have already been properly called
4069 (bug#10117).
4070
3360a3fc
AS
40712011-12-01 Andreas Schwab <schwab@linux-m68k.org>
4072
4073 * keyboard.c (interrupt_signal): Don't call kill-emacs when
4074 waiting for input. (Bug#10169)
4075
73d6c093
EZ
40762011-11-30 Eli Zaretskii <eliz@gnu.org>
4077
4078 * dispnew.c (adjust_glyph_matrix): Remove the assertion that
4079 verifies glyph row's hash code--we have just reallocated the
4080 glyphs, so their contents can be complete garbage. (Bug#10164)
4081
febe6bea
JB
40822011-11-30 Juanma Barranquero <lekktu@gmail.com>
4083
4084 * dispnew.c (adjust_glyph_matrix) [XASSERTS]: Add missing check.
4085
801a4313
EZ
40862011-11-30 Eli Zaretskii <eliz@gnu.org>
4087
4088 * dispnew.c (adjust_glyph_matrix) [XASSERTS]: Ensure ROW's
4089 attributes are tested _before_ calling verify_row_hash, to protect
4090 against GCC re-ordering of the tests. (Bug#10164)
4091
2b56b87e
JD
40922011-11-29 Jan Djärv <jan.h.d@swipnet.se>
4093
4094 * xterm.h (struct x_output): net_wm_state_hidden_seen is new.
4095
4096 * xterm.c (handle_one_xevent): Only set async_visible and friends
4097 if net_wm_state_hidden_seen is non-zero (Bug#10002)
7dbda6df 4098 (get_current_wm_state): Set net_wm_state_hidden_seen to 1 if
2b56b87e
JD
4099 _NET_WM_STATE_HIDDEN is in NET_WM_STATE.
4100
dbf31225
PE
41012011-11-28 Paul Eggert <eggert@cs.ucla.edu>
4102
4103 Remove GCPRO-related macros that exist only to avoid shadowing locals.
4104 * lisp.h (GCPRO1_VAR, GCPRO2_VAR, GCPRO3_VAR, GCPRO4_VAR, GCPRO5_VAR)
4105 (GCPRO6_VAR, UNGCPRO_VAR): Remove. See
4106 <http://lists.gnu.org/archive/html/emacs-diffs/2011-11/msg00265.html>.
4107 All uses changed to use GCPRO1 etc.
4108 (GCPRO1, GCPRO2, GCPRO3, GCPRO4, GCPRO5, GCPRO6, UNGCPRO):
4109 Revert to old implementation (i.e., before 2011-03-11).
4110
1305621b
YM
41112011-11-28 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
4112
4113 * dispnew.c (scrolling_window): Truncate overlaps in copy destination
4114 of scroll runs so as to avoid assigning disabled bogus rows and
4115 unnecessary graphics copy operations.
4116
8c9afb46
EZ
41172011-11-27 Eli Zaretskii <eliz@gnu.org>
4118
4119 * s/ms-w32.h (utimbuf) [_MSC_VER]: Don't define.
4120 (snprintf) [_MSC_VER]: Redirect to _snprintf.
4121 (strtoll) [_MSC_VER]: Redirect to _strtoi64.
4122 (malloc, free, realloc, calloc): Redirect to e_* only when
4123 compiling Emacs.
4124
4125 * lisp.h (GCTYPEBITS): Move before first use.
4126 (ALIGN_GCTYPEBITS) [_MSC_VER]: Define.
4127 (DECL_ALIGN) [_MSC_VER]: Use it, as MSVC doesn't like bit ops in
4128 this macro definition.
4129
4130 * s/ms-w32.h (tzname): Redirect to _tzname for all values of
4131 _MSC_VER.
4132
54e9e3bf
JD
41332011-11-27 Jan Djärv <jan.h.d@swipnet.se>
4134
6d5eb5b0
SM
4135 * gtkutil.c (xg_create_frame_widgets):
4136 Call gtk_window_set_has_resize_grip (FALSE) if that function is
54e9e3bf
JD
4137 present with Gtk+ 2.0.
4138
83aca1cb
PE
41392011-11-26 Paul Eggert <eggert@cs.ucla.edu>
4140
4141 * fileio.c (Finsert_file_contents): Undo previous change; see
4142 <http://lists.gnu.org/archive/html/emacs-diffs/2011-11/msg00265.html>.
4143
5b76caa4
PE
41442011-11-26 Paul Eggert <eggert@cs.ucla.edu>
4145
4146 Rename locals to avoid shadowing.
4147 * fileio.c (Finsert_file_contents):
4148 Rename inner 'gcpro1' to 'inner_gcpro1' to avoid shadowing.
4149 * process.c (wait_reading_process_output):
4150 Rename inner 'proc' to 'p' to avoid shadowing.
4151 Indent for consistency with usual Emacs style.
4152
8c535114
EZ
41532011-11-25 Eli Zaretskii <eliz@gnu.org>
4154
4155 * xdisp.c (redisplay_window): If cursor row is not fully visible
4156 after recentering, and scroll-conservatively is set to a large
4157 number, scroll window by a few more lines to make the cursor fully
4158 visible and out of scroll-margin. (Bug#10105)
91b4a718
EZ
4159 (start_display): Don't move to the next line if the display should
4160 start at a newline that is part of a display vector or an overlay
4161 string. (Bug#10119)
8c535114 4162
fa4fdb5c
JL
41632011-11-24 Juri Linkov <juri@jurta.org>
4164
4165 * image.c (imagemagick_load_image): Move `MagickSetResolution' down
4166 after the `MagickPingImage' call. (Bug#10112)
4167
90ec88df
CY
41682011-11-23 Chong Yidong <cyd@gnu.org>
4169
4170 * window.c (Fcoordinates_in_window_p): Accept only live windows.
4171
56e2e794
MR
41722011-11-23 Martin Rudalics <rudalics@gmx.at>
4173
4174 * buffer.c (Fkill_buffer): Run replace_buffer_in_windows before
4175 making another buffer current. (Bug#10114)
4176
b6e64c41
GM
41772011-11-23 Glenn Morris <rgm@gnu.org>
4178
4179 * font.c (font_find_for_lface) [HAVE_NS]: Ignore case. (Bug#2526)
4180
6b21de18
CY
41812011-11-23 Chong Yidong <cyd@gnu.org>
4182
4183 * xdisp.c (compute_stop_pos): Check validity of end_charpos before
4184 using it (Bug#5984).
4185
b12cd789
EZ
41862011-11-22 Eli Zaretskii <eliz@gnu.org>
4187
4188 * dispnew.c (adjust_glyph_matrix): Don't verify hash code of mode-
4189 and header-lines, as they don't have one computed for them.
4190 (Bug#10098)
4191
4192 * .gdbinit (prow): Make displayed values more self-explaining.
4193 Add row's hash code.
4194
261b6fd4
LMI
41952011-11-21 Lars Magne Ingebrigtsen <larsi@gnus.org>
4196
4197 * process.c (wait_reading_process_output): Fix asynchrounous
4198 GnuTLS socket handling on some versions of the GnuTLS library.
16c1ad08 4199 (wait_reading_process_output): Add comment and URL.
261b6fd4 4200
e7cfd277
JD
42012011-11-21 Jan Djärv <jan.h.d@swipnet.se>
4202
4203 * xterm.c (x_clear_frame): Reinstate the XClearWindow call.
4204
a9b9b7f5
CY
42052011-11-21 Chong Yidong <cyd@gnu.org>
4206
4207 * window.c (Fnext_window, Fprevious_window): Doc fix.
4208
b0d15b4f
SM
42092011-11-20 Stefan Monnier <monnier@iro.umontreal.ca>
4210
4211 * window.c (get_phys_cursor_glyph): Fix Lisp_Object/int mixup.
4212
fe7a3057
JB
42132011-11-20 Juanma Barranquero <lekktu@gmail.com>
4214
4215 * nsfont.m (syms_of_nsfont) <ns-reg-to-script>: Fix typo.
4216
d2999b1a
MR
42172011-11-20 Martin Rudalics <rudalics@gmx.at>
4218
4219 * window.c (Fset_window_combination_limit): Rename argument
4220 STATUS to LIMIT.
4221 (Vwindow_combination_limit): Remove "status" from doc-string.
4222
d5ff9cd0
AS
42232011-11-20 Andreas Schwab <schwab@linux-m68k.org>
4224
4225 * m/ibms390.h: Remove.
4226 * m/ibms390x.h: Don't include "ibms390.h".
4227
a5bb9bd3
SM
42282011-11-20 Stefan Monnier <monnier@iro.umontreal.ca>
4229
4230 * fileio.c (Finsert_file_contents): Add missing gcpro1 variable.
4231 Suggested by Dmitry Antipov <dmantipov@yandex.ru>.
4232
cd1181db
JB
42332011-11-20 Juanma Barranquero <lekktu@gmail.com>
4234
4235 * casetab.c (Fset_case_table):
4236 * charset.c (Fcharset_after): Fix typos.
4237
615a3b8d 42382011-11-20 Paul Eggert <eggert@cs.ucla.edu>
6a0bf43d 4239
17e845af
PE
4240 Standardize on VIRT_ADDR_VARIES behavior (Bug#10042).
4241 Otherwise, valgrind does not work on some platforms.
4242 Problem reported by Andreas Schwab in
6a0bf43d
PE
4243 <http://lists.gnu.org/archive/html/emacs-devel/2011-11/msg00081.html>.
4244 * puresize.h (pure, PURE_P): Always behave as if VIRT_ADDR_VARIES
4245 is set, removing the need for VIRT_ADDRESS_VARIES.
4246 (PURE_P): Use a more-efficient implementation that needs just one
4247 comparison, not two: on x86-64 with GCC 4.6.2, this cut down the
4248 number of instructions from 6 (xorl, cmpq, jge, xorl, cmpq, setge)
4249 to 4 (xorl, subq, cmpq, setbe).
4250 * alloc.c (pure): Always extern now, since that's the
4251 VIRT_ADDR_VARIES behavior.
4252 (PURE_POINTER_P): Use a single comparison, not two, for
4253 consistency with the new puresize.h.
4254 * lisp.h (PNTR_COMPARISON_TYPE): Remove; no longer needed.
4255 * m/ibms390.h, m/intel386.h, m/template.h, s/cygwin.h, s/hpux10-20.h:
4256 Remove VIRT_ADDR_VARIES no longer needed.
4257
f8fe6f96
EZ
42582011-11-19 Eli Zaretskii <eliz@gnu.org>
4259
4260 * xdisp.c (x_write_glyphs, draw_phys_cursor_glyph)
4261 (erase_phys_cursor, update_window_cursor, show_mouse_face)
4262 (cursor_in_mouse_face_p): If the cursor position is out of bounds,
4263 behave as if the cursor position were at the window margin.
4264
4265 * window.c (get_phys_cursor_glyph): If the window is hscrolled,
4266 and the cursor position is out of bounds, behave as if the cursor
4267 position were at the window margin. (Bug#10075)
4268
df05a53c
CY
42692011-11-18 Chong Yidong <cyd@gnu.org>
4270
4271 * window.c (Fwindow_combination_limit): Make first argument
4272 non-optional, since it is meaningless for live windows like the
4273 selected window.
61ccba97 4274
2071918e
DA
42752011-11-18 Dmitry Antipov <dmantipov@yandex.ru>
4276
4277 * keymap.c (Fwhere_is_internal): Add missing RETURN_UNGCPROs.
4278
b50a28de
SM
42792011-11-18 Stefan Monnier <monnier@iro.umontreal.ca>
4280
4281 * intervals.c: Fix grafting over the whole buffer (bug#10071).
4282 (graft_intervals_into_buffer): Simplify.
4283
015137db
EZ
42842011-11-18 Eli Zaretskii <eliz@gnu.org>
4285
4286 * dispnew.c (swap_glyph_pointers): Swap the used[] arrays and the
4287 hash values of the two rows.
4288 (copy_row_except_pointers): Preserve the used[] arrays and the
4289 hash values of the two rows. (Bug#10035)
68c95424 4290 (add_row_entry): Add xassert to verify that ROW's hash code is valid.
015137db
EZ
4291
4292 * xdisp.c (row_hash): New function, body extracted from
4293 compute_line_metrics.
4294 (compute_line_metrics): Call row_hash, instead of computing the
4295 hash code inline.
4296
4297 * dispnew.c (verify_row_hash): Call row_hash for computing the
4298 hash code of a row, instead of duplicating code from xdisp.c.
4299
4300 * dispextern.h (row_hash): Add prototype.
4301
a2addb04
TH
43022011-11-18 Tassilo Horn <tassilo@member.fsf.org>
4303
4304 * frame.c (delete_frame): Don't delete the terminal when the last
4305 X frame is closed if emacs is built with GTK toolkit.
4306
df85d315
JB
43072011-11-17 Juanma Barranquero <lekktu@gmail.com>
4308
4309 * window.c (syms_of_window) <window-combination-resize>: Fix typo.
4310
a0c2d0ae
MR
43112011-11-17 Martin Rudalics <rudalics@gmx.at>
4312
4313 * window.c (Vwindow_splits): Rename to
4314 Vwindow_combination_resize. Suggested by Juri Linkov.
4315 (Fsplit_window_internal): Use Vwindow_combination_resize instead
4316 of Vwindow_splits.
4317
58179cce
JB
43182011-11-16 Juanma Barranquero <lekktu@gmail.com>
4319
7877f373
JB
4320 * nsfns.m (Fns_font_name):
4321 * window.c (syms_of_window) <window-combination-limit>: Fix typos.
58179cce 4322
b6f67890
MR
43232011-11-16 Martin Rudalics <rudalics@gmx.at>
4324
4325 * window.h (window): Rename slot "nest" to "combination_limit".
4326 * window.c (Fwindow_nest): Rename to Fwindow_combination_limit.
4327 (Fset_window_nest): Rename to Fset_window_combination_limit.
4328 (Vwindow_nest): Rename to Vwindow_combination_limit.
4329 (recombine_windows, make_parent_window, make_window)
4330 (Fsplit_window_internal, saved_window)
4331 (Fset_window_configuration, save_window_save): Rename all
4332 occurrences of window_nest to window_combination_limit.
4333
c7015153
JB
43342011-11-15 Juanma Barranquero <lekktu@gmail.com>
4335
4336 * image.c (imagemagick_load_image): Fix typo.
4337
322ad6ec
EZ
43382011-11-14 Eli Zaretskii <eliz@gnu.org>
4339
4340 * xdisp.c (display_line): Move the call to
4341 highlight_trailing_whitespace before the call to
4342 compute_line_metrics, since the latter needs to see the final
6d5eb5b0
SM
4343 faces of all the glyphs to compute ROW's hash value.
4344 Fixes assertion violations in row_equal_p. (Bug#10035)
322ad6ec 4345
f067b8ec
JB
43462011-11-14 Juanma Barranquero <lekktu@gmail.com>
4347
4348 * w32proc.c (reader_thread): Don't check pending input if cp->fd < 0,
4349 just return (bug#10044).
4350
1e5b2111
EZ
43512011-11-12 Eli Zaretskii <eliz@gnu.org>
4352
7ef3cbd5
EZ
4353 * makefile.w32-in (HEAPSIZE): New variable, allows to build temacs
4354 with user-defined heap size. Bump the default size of the temacs
4355 heap to 27MB, to avoid memory warning when running temacs.
4356 ($(TEMACS)): Use HEAPSIZE instead of a hardcoded value.
4357
1e5b2111
EZ
4358 * dispnew.c (scrolling_window): Fix incorrect indices in accessing
4359 current_matrix and desired_matrix. (Bug#9990)
7a7270dd
EZ
4360 (verify_row_hash) [XASSERTS]: New function.
4361 (adjust_glyph_matrix, row_equal_p): Use it in xassert to verify
4362 that the hash value of glyph rows is correct.
1e5b2111 4363
89d61221
MR
43642011-11-12 Martin Rudalics <rudalics@gmx.at>
4365
4366 * window.h (window): Remove splits slot.
4367 * window.c (Fwindow_splits, Fset_window_splits): Remove.
4368 (Fdelete_other_windows_internal, make_parent_window)
4369 (make_window, Fsplit_window_internal, Fdelete_window_internal)
4370 (Fset_window_configuration, save_window_save): Don't deal with
4371 split status of windows.
4372 (saved_window): Remove splits slot.
4373 (Vwindow_splits): Rewrite doc-string.
4374
97f18cc8
JD
43752011-11-11 Jan Djärv <jan.h.d@swipnet.se>
4376
4377 * xfns.c (unwind_create_frame):
4378 * nsfns.m (unwind_create_frame):
4379 * w32fns.c (unwind_create_frame): Use Fmemq to check if frame is in
4380 Vframe_list (Bug#9999).
4381
22a648b4
DA
43822011-11-11 Dmitry Antipov <dmantipov@yandex.ru>
4383
0b381c7e 4384 * xdisp.c (syms_of_xdisp): Remove duplicated definition of Qtext.
22a648b4 4385
659afede
KH
43862011-11-11 Kenichi Handa <handa@m17n.org>
4387
4388 * callproc.c (Fcall_process): Set the member dst_multibyte of
4389 process_coding.
4390
9ac0394b
KH
43912011-11-11 Johan Bockgård <bojohan@gnu.org>
4392
4393 * xdisp.c (fill_composite_glyph_string): Always set s->face, to
4394 avoid a crash (bug#9496).
4395
2fbdc249
CY
43962011-11-09 Chong Yidong <cyd@gnu.org>
4397
4398 * window.c (Fwindow_inside_edges, Fwindow_inside_pixel_edges)
4399 (Fwindow_inside_absolute_pixel_edges): Only allow live windows.
4400
ac6b1f81
PE
44012011-11-08 Paul Eggert <eggert@cs.ucla.edu>
4402
4403 * s/gnu.h (GC_MARK_STACK): Define to GC_MAKE_GCPROS_NOOPS (Bug#9926).
4404
09db192c
PE
44052011-11-08 Paul Eggert <eggert@cs.ucla.edu>
4406
4407 Avoid some portability problems by eschewing 'extern inline' functions.
4408 The trivial performance wins aren't worth the portability hassles; see
4409 <http://lists.gnu.org/archive/html/emacs-devel/2011-11/msg00084.html>
4410 et seq.
4411 * dispextern.h (window_box, window_box_height, window_text_bottom_y)
4412 (window_box_width, window_box_left, window_box_left_offset)
4413 (window_box_right, window_box_right_offset): Undo previous change,
4414 by removing the "extern"s.
4415 * intervals.c (adjust_intervals_for_insertion)
4416 (adjust_intervals_for_deletion): Undo previous change,
4417 making these static again.
4418 (offset_intervals, temp_set_point_both, temp_set_point)
4419 (copy_intervals_to_string): No longer inline.
4420 * xdisp.c (window_text_bottom_y, window_box_width)
4421 (window_box_height, window_box_left_offset)
4422 (window_box_right_offset, window_box_left, window_box_right)
4423 (window_box): No longer inline.
4424
105216ed
CY
44252011-11-08 Chong Yidong <cyd@gnu.org>
4426
4427 * window.c (Fwindow_left_column, Fwindow_top_line): Doc fix.
6d5eb5b0
SM
4428 (Fwindow_body_height, Fwindow_body_width): Move from Lisp.
4429 Signal an error if not a live window.
105216ed
CY
4430 (Fwindow_total_width, Fwindow_total_height): Move from Lisp.
4431 (Fwindow_total_size, Fwindow_body_size): Move to Lisp.
4432
ae9e237f
JB
44332011-11-07 Juanma Barranquero <lekktu@gmail.com>
4434
4435 * lisp.h (syms_of_abbrev): Remove declaration.
4436 Reported by CHENG Gao <chenggao@royau.me>.
4437
c7aa8333
EZ
44382011-11-07 Eli Zaretskii <eliz@gnu.org>
4439
4440 * w32.c (check_windows_init_file): Don't look for term/w32-win.el
4441 if Vpurify_flag is non-nil. Fixes a crash when running w32 build
4442 of temacs in GUI mode.
4443
be7f5545
MR
44442011-11-07 Martin Rudalics <rudalics@gmx.at>
4445
4446 * window.h: Declare delete_all_child_windows instead of
4447 delete_all_subwindows.
4448 * window.c (Fwindow_nest, Fset_window_nest)
4449 (Fset_window_new_total, Fset_window_new_normal)
4450 (Fwindow_resize_apply): Don't use term subwindow in doc-strings.
4451 (delete_all_subwindows): Rename to delete_all_child_windows.
4452 (Fdelete_other_windows_internal, Fset_window_configuration):
4453 Call delete_all_child_windows instead of delete_all_subwindows.
4454 * frame.c (delete_frame): Call delete_all_child_windows instead
4455 of delete_all_subwindows.
4456
ca78dc43
PE
44572011-11-07 Paul Eggert <eggert@cs.ucla.edu>
4458
4459 * alloc.c (DEADP): New macro, for porting to GNU/Hurd (Bug#9926).
4460 This is also needed for porting to any host where GC_MARK_STACK is
4461 not GC_MAKE_GCPROS_NOOPS.
4462 (which_symbols): Use it.
4463
a0241d01
KH
44642011-11-07 Kenichi Handa <handa@m17n.org>
4465
4466 * coding.c (coding_set_destination): Check coding->src_pos only
4467 when coding->src_object is a buffer (bug#9910).
4468
4469 * process.c (send_process): Set the member src_multibyte of coding
4470 to 0 (bug#9911) when sending a unibyte text.
4471
4472 * callproc.c (Fcall_process): Set the member src_multibyte of
4473 process_coding to 0 (bug#9912).
4474
a64bfdfa 44752011-11-06 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
ba24cea2
YM
4476
4477 * xmenu.c (cleanup_widget_value_tree): New function.
4478 (xmenu_show, xdialog_show): Use it in record_unwind_protect instead of
4479 calling free_menubar_widget_value_tree directly (Bug#9830).
4480
cb41b32a
PE
44812011-11-06 Paul Eggert <eggert@cs.ucla.edu>
4482
4483 Fix some portability problems with 'inline'.
4484 * dispextern.h (window_box, window_box_height, window_text_bottom_y)
4485 (window_box_width, window_box_left, window_box_left_offset)
4486 (window_box_right, window_box_right_offset): Declare extern.
4487 Otherwise, these inline functions do not conform to C99 and
4488 are miscompiled by Microsoft compilers. Reported by Eli Zaretskii in
4489 <http://lists.gnu.org/archive/html/emacs-devel/2011-11/msg00084.html>.
4490 * intervals.c (adjust_intervals_for_insertion)
4491 (adjust_intervals_for_deletion): Now extern, because otherwise the
4492 extern inline functions 'offset_intervals' couldn't refer to it.
4493 (static_offset_intervals): Remove.
4494 (offset_intervals): Rewrite using the old contents of
4495 static_offset_intervals. The old version didn't conform to C99
4496 because an extern inline function contained a reference to an
4497 identifier with static linkage.
4498
b7041366
AS
44992011-11-06 Andreas Schwab <schwab@linux-m68k.org>
4500
4501 * keyboard.c (interrupt_signal): Don't call kill-emacs while in
4502 GC.
4503
88a37c4d
EZ
45042011-11-06 Eli Zaretskii <eliz@gnu.org>
4505
4506 * xdisp.c (init_iterator, reseat_to_string): Don't set the
4507 iterator's bidi_p flag if Vpurify_flag is non-nil. (Bug#9963)
4508 (Fcurrent_bidi_paragraph_direction): If Vpurify_flag is non-nil,
4509 return Qleft_to_right.
4510
49745b39
CY
45112011-11-06 Chong Yidong <cyd@gnu.org>
4512
4513 * window.c (Fwindow_live_p, Fwindow_frame, Fframe_root_window)
4514 (Fminibuffer_window, Fwindow_buffer, Fwindow_splits)
4515 (Fset_window_splits, Fwindow_nest, Fset_window_nest)
4516 (Fwindow_use_time, Fwindow_total_size, Fwindow_normal_size)
4517 (Fwindow_new_normal, Fwindow_left_column, Fwindow_top_line)
4518 (Fwindow_margins, Fwindow_fringes, Fwindow_scroll_bars)
4519 (Fwindow_vscroll): Doc fix.
4520 (Fwindow_top_child, Fwindow_left_child): Eliminate a nil default
4521 argument, since it makes no sense to pass a live window and for
4522 consistency with window-child.
4523
1f05cd82
CS
45242011-11-05 Christoph Scholtes <cschol2112@googlemail.com>
4525
4526 * makefile.w32-in ($(TEMACS), (gl-stamp)): Use $(THISDIR) to
4527 support MSVC.
4528
22610910
JR
45292011-11-05 Jason Rumney <jasonr@gnu.org>
4530
4531 * w32font.c (font_matches_spec): Filter out non-Japanese kana fonts.
4532 (add_font_entity_to_list): Filter out non-Japanese Shift-JIS
4533 fonts (Bug#6029).
4534 (add_font_entity_to_list): Fix logic errors in mixed boolean and
4535 bitwise arithmetic preventing use of unicode-sip and non-truetype
4536 opentype fonts.
4537
a06776b2
EZ
45382011-11-05 Eli Zaretskii <eliz@gnu.org>
4539
3ad924ba
EZ
4540 * s/ms-w32.h (fstat, stat, utime): Move redirections to
4541 "emacs"-only part.
4542
a06776b2
EZ
4543 * w32fns.c (x_create_tip_frame, Fx_create_frame): Rearrange
4544 initialization code to keep similarity to xfns.c after changes
4545 from 2011-11-05.
4546
c9e7db78
JD
45472011-11-05 Jan Djärv <jan.h.d@swipnet.se>
4548
a97f8f3f
JD
4549 * nsfns.m: Declare image_cache_refcount if GLYPH_DEBUG.
4550 (unwind_create_frame): New function (Bug#9943).
4551 (Fx_create_frame): Restructure code to be more similar to the one in
4552 xfns.c. Call record_unwind_protect with unwind_create_frame (Bug#9943).
4553 Initialize image_cache_refcount if GLYPH_DEBUG (Bug#9943).
4554 Move terminal->reference_count++ just before making the frame official
4555 (Bug#9943).
4556
4557 * nsterm.m (x_free_frame_resources): New function.
4558 (x_destroy_window): Move code to x_free_frame_resources.
4559
c9e7db78 4560 * xfns.c (unwind_create_frame): Fix comment.
6d5eb5b0
SM
4561 (Fx_create_frame, x_create_tip_frame):
4562 Move terminal->reference_count++ just before making the frame
75f1671a 4563 official. Move initialization of image_cache_refcount and
c9e7db78
JD
4564 dpyinfo_refcount before calling init_frame_faces (Bug#9943).
4565
a6fc3b5c
EZ
45662011-11-05 Eli Zaretskii <eliz@gnu.org>
4567
4568 Support MSVC build with newer versions of Visual Studio.
4569 * makefile.w32-in (TAGS-gmake): Don't use $(patsubst ...), as
4570 Nmake barfs on that. Use $(OBJ*_c) variables instead, defined on
4571 nt/gmake.defs.
4572
4573 * lisp.h (ENUM_BF): New macro, for enumerated types in bitfields,
4574 which are not supported by MSVC.
4575 (Lisp_Symbol, Lisp_Misc_Any, Lisp_Marker, Lisp_Misc_Overlay)
4576 (Lisp_Save_Value, Lisp_Free): Use ENUM_BF for enumerated types in
4577 bitfields.
4578 (Lisp_Object) [USE_LISP_UNION_TYPE]: Use ENUM_BF for enumerated
4579 types in bitfields.
4580 (DEFUN) [_MSC_VER]: Define in a different way for MSVC.
4581
4582 * w32fns.c [_MSC_VER]: DECLARE_HANDLE for any MSVC version.
4583
58179cce 45842011-11-05 Fabrice Popineau <fabrice.popineau@supelec.fr> (tiny change)
a6fc3b5c
EZ
4585
4586 Support MSVC build with newer versions of Visual Studio.
4587 * w32.c: Don't include w32api.h for MSVC.
4588 (init_environment) [_MSC_VER]: Call sys_access, not _access.
4589
4590 * s/ms-w32.h <sigset_t, ssize_t> [_MSC_VER]: Typedefs for MSVC.
4591 [_MSC_VER]: Include sys/timeb.h, sys/stat.h, and signal.h.
4592 (fstat, stat, utime) [_MSC_VER]: Redirect to their sys_* cousins.
4593 (malloc, free, realloc, calloc) [_MSC_VER]: Always redirect to the
4594 e_* cousins.
4595 (alloca) [_MSC_VER]: Define to _alloca.
4596
4597 * lisp.h (DECL_ALIGN) [_MSC_VER]: Define for MSVC.
4598
4599 * regex.c <re_char> [_MSC_VER]: A separate definition for MSVC.
4600
a58c13ed
EZ
46012011-11-04 Eli Zaretskii <eliz@gnu.org>
4602
4603 * xdisp.c (note_mouse_highlight): If either of
4604 previous/next-single-property-change returns nil, treat that as
4605 the beginning or the end of the buffer. (Bug#9955)
4606
fe0b6370
JD
46072011-11-04 Jan Djärv <jan.h.d@swipnet.se>
4608
a58c13ed 4609 * gtkutil.c (xg_make_tool_item): Add callbacks if one of wimage or
fe0b6370
JD
4610 label is not null (Bug#9951).
4611 (xg_tool_item_stale_p): Handle the fact that wimage and/or wlbl
4612 may be NULL.
4613
89bd5ee1
EZ
46142011-11-04 Eli Zaretskii <eliz@gnu.org>
4615
4616 * window.c (Fwindow_body_size): Mention in the doc string that the
4617 return value is in frame's canonical units. (Bug#9949)
4618
84c3edb9
EZ
46192011-11-03 Eli Zaretskii <eliz@gnu.org>
4620
4e2fb5c7
EZ
4621 * xdisp.c (note_mouse_highlight): Initialize `area'. (Bug#9947)
4622
84c3edb9 4623 * w32fns.c (unwind_create_frame): If needed, free the glyph
3ab15fd6 4624 matrices of the partially constructed frame. (Bug#9943)
2a58bbc1 4625 * xfns.c (unwind_create_frame): Likewise.
84c3edb9 4626
bc17a887
EZ
46272011-11-01 Eli Zaretskii <eliz@gnu.org>
4628
4629 * xdisp.c (mouse_face_from_buffer_pos): Fix a typo in a comment.
4630 Don't stop backward scan on the continuation glyph, even though
4631 its CHARPOS is positive.
6d5eb5b0
SM
4632 (mouse_face_from_buffer_pos, note_mouse_highlight):
4633 Rename cover_string to disp_string.
bc17a887 4634
4ee88440
MR
46352011-11-01 Martin Rudalics <rudalics@gmx.at>
4636
4637 * window.c (temp_output_buffer_show): Don't use
4638 Vtemp_buffer_show_specifiers.
4639 (Vtemp_buffer_show_specifiers): Remove unused variable.
4640
c2ff3c02
EZ
46412011-10-30 Eli Zaretskii <eliz@gnu.org>
4642
4643 * xdisp.c (try_cursor_movement): Make sure ROW isn't decremented
4644 past the beginning of the current glyph matrix.
4645
58179cce 46462011-10-30 Adam Sjøgren <asjo@koldfront.dk> (tiny change)
6e56383b
JD
4647
4648 * xterm.c: Include X11/Xproto.h if HAVE_GTK3.
4649 (x_error_handler): Ignore BadMatch for X_SetInputFocus for
4650 HAVE_GTK3 (Bug#9869).
b77a6a7f 4651
3b574623
JD
4652 * gtkutil.c (xg_win_to_widget, xg_event_is_for_menubar): Initialize
4653 type to GDK_NOTHING so valgrind does not complain (Bug#9901).
4654
b77a6a7f
JD
4655 * xterm.h (x_display_info): Add Xatom_net_wm_state_hidden (Bug#9893).
4656
4657 * xterm.c: Declare x_handle_net_wm_state to return int.
4658 (handle_one_xevent): Check if we are iconified but don't have
4659 _NET_WM_STATE_HIDDEN. If do, treat as deiconify (Bug#9893).
4660 (get_current_wm_state): Return non-zero if not hidden,
4661 check for _NET_WM_STATE_HIDDEN (Bug#9893).
4662 (do_ewmh_fullscreen): Ignore return value from get_current_wm_state.
4663 (x_handle_net_wm_state): Return what get_current_wm_state returns.
4664 (x_term_init): Initialize dpyinfo->Xatom_net_wm_state_hidden.
4665
196e41e4
PE
46662011-10-29 Paul Eggert <eggert@cs.ucla.edu>
4667
4668 * alloc.c (which_symbols): Declare EXTERNALLY_VISIBLE,
4669 so that this new function doesn't get optimized away by a
4670 whole-program optimizer. Make the 2nd arg EMACS_INT, not int.
4671
021f2e1a
AS
46722011-10-29 Andreas Schwab <schwab@linux-m68k.org>
4673
4674 * frame.h (MOUSE_HL_INFO): Remove excess parens.
4675
8b058d44
EZ
46762011-10-29 Eli Zaretskii <eliz@gnu.org>
4677
4678 Fix the `xbytecode' command.
4679 * .gdbinit (xprintbytestr): New command.
b50a28de 4680 (xwhichsymbols): Rename from `which'; all callers changed.
8b058d44
EZ
4681 (xbytecode): Print the byte-code string as well.
4682
4452fb80
EZ
46832011-10-29 Kim Storm <storm@cua.dk>
4684
8b058d44
EZ
4685 * alloc.c (which_symbols): New function.
4686
21b72067
AS
46872011-10-29 Andreas Schwab <schwab@linux-m68k.org>
4688
4689 * minibuf.c (read_minibuf_noninteractive): Allow reading empty
4690 line. (Bug#9903)
4691
83ed7b5c
GM
46922011-10-29 Glenn Morris <rgm@gnu.org>
4693
4694 * process.c (wait_reading_process_output): Revert 2009-08-30 change.
4695 Not clear what it was for, and it causes various bugs. (Bug#9839)
4696
5a7a728b
EZ
46972011-10-28 Eli Zaretskii <eliz@gnu.org>
4698
4699 * xdisp.c (note_mouse_highlight): Initialize `part', to avoid a
4700 possible random value that matches one of those tested as
4701 condition to clear the mouse face.
4702
d3d0842f
CY
47032011-10-28 Chong Yidong <cyd@gnu.org>
4704
4705 * xdisp.c (note_mouse_highlight): Fix use of uninitialized var.
4706
31b39d13
DN
47072011-10-28 Dan Nicolaescu <dann@ics.uci.edu>
4708
4709 * window.c (make_window): Initialize phys_cursor_on_p.
4710
9aba6043
SM
47112011-10-28 Stefan Monnier <monnier@iro.umontreal.ca>
4712
4713 * lisp.h (struct Lisp_Symbol): Update comments.
4714
c20992f4
JB
47152011-10-28 Juanma Barranquero <lekktu@gmail.com>
4716
4717 * w32font.c (w32_load_unicows_or_gdi32): Add missing return.
4718
db4f02f2
EZ
47192011-10-28 Eli Zaretskii <eliz@gnu.org>
4720
4721 Fix Emacs on Windows 9X (bug#8562). Thanks to oslsachem
4722 <oslsachem@gmail.com> for helping to debug this.
4723
4724 * w32font.c (g_b_init_is_w9x, g_b_init_get_outline_metrics_w)
4725 (g_b_init_get_text_metrics_w, g_b_init_get_glyph_outline_w)
4726 (g_b_init_get_glyph_outline_w): New static variables.
4727 (GetOutlineTextMetricsW_Proc, GetTextMetricsW_Proc)
4728 (GetGlyphOutlineW_Proc): New typedefs.
4729 (w32_load_unicows_or_gdi32, get_outline_metrics_w)
9aba6043
SM
4730 (get_text_metrics_w, get_glyph_outline_w, globals_of_w32font):
4731 New functions.
4732 (w32font_open_internal, compute_metrics):
4733 Call get_outline_metrics_w, get_text_metrics_w, and get_glyph_outline_w
db4f02f2
EZ
4734 instead of calling the "wide" APIs directly.
4735
4736 * emacs.c (main) [HAVE_NTGUI]: Call globals_of_w32font.
4737
4738 * w32.h (syms_of_w32font): Add prototype.
4739
87e68db4
JB
47402011-10-27 Juanma Barranquero <lekktu@gmail.com>
4741
4742 * window.c (Fframe_root_window, Fframe_first_window, Fwindow_end)
4743 (Fframe_selected_window, Ftemp_output_buffer_show, Fnext_window)
4744 (Fdelete_window_internal, Fwindow_parameters): Fix typos in docstrings.
4745 (Fmove_to_window_line): Doc fix.
4746
435c1d67
CY
47472011-10-27 Chong Yidong <cyd@gnu.org>
4748
4749 * process.c (make_process): Set gnutls_state to NULL.
4750
4751 * gnutls.c (emacs_gnutls_deinit): Deinit the gnutls_state if it is
4752 non-NULL, regardless of GNUTLS_INITSTAGE.
4753 (Fgnutls_boot): Cleanups. Call emacs_gnutls_deinit if we signal
4754 an error. Set process slots as soon as we allocate them.
4755
4756 * gnutls.h (GNUTLS_LOG, GNUTLS_LOG2): Fix macros.
4757
9c6c6f49
CY
47582011-10-27 Chong Yidong <cyd@gnu.org>
4759
9aba6043
SM
4760 * gnutls.c (emacs_gnutls_deinit): New function.
4761 Deallocate credentials structures as well as calling gnutls_deinit.
9c6c6f49
CY
4762 (Fgnutls_deinit, Fgnutls_boot): Use it.
4763
4764 * process.c (make_process): Initialize GnuTLS credentials to NULL.
4765 (deactivate_process): Call emacs_gnutls_deinit.
4766
657d08d3
JB
47672011-10-27 Juanma Barranquero <lekktu@gmail.com>
4768
4769 * image.c (x_create_x_image_and_pixmap):
4770 * w32.c (sys_rename, w32_delayed_load):
4771 * w32font.c (fill_in_logfont):
4772 * w32reg.c (x_get_string_resource): Silence compiler warnings.
4773
5430d399
JB
47742011-10-26 Juanma Barranquero <lekktu@gmail.com>
4775
4776 * w32fns.c (w32_default_color_map): New function,
4777 extracted from Fw32_default_color_map.
a7ef684b 4778 (Fw32_default_color_map, Fx_open_connection): Use it. (Bug#9785)
5430d399 4779
fe0055fa
PE
47802011-10-25 Paul Eggert <eggert@cs.ucla.edu>
4781
4782 * dispextern.h (Fcontrolling_tty_p): New decl (Bug#6649 part 2).
4783
e6346438
SM
47842011-10-25 Stefan Monnier <monnier@iro.umontreal.ca>
4785
4786 * keyboard.c (test_undefined): New function (bug#9751).
4787 (read_key_sequence): Use it to detect when a key is bound to `undefined'.
4788
e112cc37
ET
47892011-10-25 Enami Tsugutomo <tsugutomo.enami@jp.sony.com>
4790
4791 * sysdep.c (init_sys_modes): Fix the check for the controlling
4792 terminal (Bug#6649).
4793
7b5d6677
EZ
47942011-10-20 Eli Zaretskii <eliz@gnu.org>
4795
4796 * dispextern.h (struct bidi_it): New member next_en_type.
4797
4798 * bidi.c (bidi_line_init): Initialize the next_en_type member.
4799 (bidi_resolve_explicit_1): When next_en_pos is valid for the
4800 current character, check also for next_en_type being WEAK_EN.
4801 (bidi_resolve_weak): Don't enter the expensive loop if the current
4802 position is before next_en_pos. Record the bidi type of the first
4803 non-ET, non-BN character we find, in addition to its position.
4804 (bidi_level_of_next_char): Invalidate next_en_type when
4805 next_en_pos is over-stepped.
4806
7da0b018
PE
48072011-10-20 Paul Eggert <eggert@cs.ucla.edu>
4808
4809 Time zone name fixes for non-ASCII locales (Bug#641, Bug#9794)
4810 * editfns.c: Rewrite current-time-zone so that it invokes
4811 the equivalent of (format-time-string "%Z") to get the time zone name.
4812 This fixes a bug when the time zone name contains characters that
4813 need converting from the system time locale to Emacs internal format.
4814 This fixes a shortcoming that I introduced in my 1999-10-19 patch:
4815 that patch fixed format-time-string to do the conversion, but
4816 I forgot to fix current-time-zone.
4817 (format_time_string): New function, containing most of
4818 what Fformat_time_string used to contain.
4819 (Fformat_time_string): Rewrite in terms of format_time_string.
4820 This doesn't change this function's behavior.
4821 (current-time-zone): Rewrite to use format_time_string.
4822 This fixes the bug reported by Michael Schierl in
4823 <http://lists.gnu.org/archive/html/emacs-devel/2007-06/msg00334.html>.
4824 Jason Rumney's 2007-06-07 change worked around this bug, but
4825 didn't fix it.
4826 * systime.h (tzname, timezone): Remove no-longer-used declarations.
4827
8547b010
EZ
48282011-10-19 Eli Zaretskii <eliz@gnu.org>
4829
4830 * xdisp.c (start_display): If the character at POS is displayed
4831 via a display vector, reset IT->current.dpvec_index to zero.
12b32963
EZ
4832 (try_window_reusing_current_matrix): If a line ends in a display
4833 vector or the next line starts in a display vector, continue
4834 redrawing the window even though the character position of
4835 start_row was reached.
8547b010
EZ
4836 (Bug#9771, part 2)
4837
4e948d15
CY
48382011-10-18 Chong Yidong <cyd@gnu.org>
4839
4840 * xdisp.c (get_next_display_element): Handle U+2010 and U+2011
4841 with nobreak-char-display too.
4842
4787455f
EZ
48432011-10-18 Eli Zaretskii <eliz@gnu.org>
4844
4845 Fix part 3 of bug#9771.
4846 * bidi.c (bidi_line_init): Initialize next_en_pos to zero, not -1.
4847 (bidi_resolve_neutral): Don't enter the expensive loop looking for
4848 non-neutral characters if the current character is a paragraph
4849 separator (a.k.a. Newline). This avoids running the same
4850 expensive loop twice, once when we consume the preceding newline
4851 and the other time when the line actually needs to be displayed.
4852 Avoid the loop when we see neutrals on the base embedding level
4853 following a character whose directionality is the same as the
4854 paragraph's. This avoids running the expensive loop when a line
4855 ends in a long sequence of neutrals, like control characters.
4856 Add assertion against STRONG_AL type. Slightly rearrange code
4857 that determines the type of a neutral given the first non-neutral
4858 that follows it.
4859 (bidi_level_of_next_char): Set next_en_pos to zero when
4860 invalidating its info.
4861
2c91f553
EZ
48622011-10-17 Eli Zaretskii <eliz@gnu.org>
4863
4864 * xdisp.c (push_display_prop): Determine whether to record string
4865 or buffer position by IT->string, not by IT->method. Allow
4866 GET_FROM_DISPLAY_VECTOR as IT->method on entry. (Bug#9771, part 4)
f2ff9e88
EZ
4867 (move_it_vertically_backward): Don't look for character position
4868 immediately after the newline when in a continuation line.
4869 (Bug#9771, part 1)
2c91f553 4870
c7b08b0d
MR
48712011-10-15 Martin Rudalics <rudalics@gmx.at>
4872
4873 * window.c (coordinates_in_window): Rewrite and delabelize
4874 vertical border check. (Bug#5357) (Bug#9618)
4875
6b02f655
SM
48762011-10-14 Stefan Monnier <monnier@iro.umontreal.ca>
4877
4878 * xterm.c (frame_highlight, frame_unhighlight): Ignore unexplained
4879 errors in XSetWindowBorder (bug#9310).
4880
81d40c92
DA
48812011-10-13 Dmitry Antipov <dmantipov@yandex.ru>
4882
4883 * editfns.c (Fset_time_zone_rule): Replace free with xfree to
4884 avoid crash when xmalloc overrun checking is enabled.
4885
d4172c3b
EZ
48862011-10-13 Eli Zaretskii <eliz@gnu.org>
4887
4888 * xdisp.c (Fcurrent_bidi_paragraph_direction): Initialize
4889 itb.paragraph_dir to NEUTRAL_DIR. Fixes an occasional incorrect
4890 cursor motion with <left> and <right> arrow keys.
4891
4892 * bidi.c (bidi_init_it): Don't initialize paragraph_dir here, as
4893 some callers set that themselves.
4894
b00eea75
EZ
48952011-10-12 Eli Zaretskii <eliz@gnu.org>
4896
4897 * xdisp.c (find_row_edges): Handle the case where ROW comes from a
4898 display string and the previous row comes from the same string and
4899 is empty. (Bug#9739) (Bug#9738)
4900
8fe012c4
SM
49012011-10-12 Stefan Monnier <monnier@iro.umontreal.ca>
4902
4903 * doc.c (get_doc_string): Encode file name (bug#9735).
4904
0074aef2
EZ
49052011-10-12 Eli Zaretskii <eliz@gnu.org>
4906
79beb178
EZ
4907 * bidi.c (bidi_level_of_next_char):
4908 * xdisp.c (get_visually_first_element): Remove old incorrect
4909 comments regarding the Unicode Line Separator character.
4910
0074aef2
EZ
4911 * bidi.c (bidi_init_it): Initialize paragraph_dir to NEUTRAL_DIR.
4912
6e4b3fbe
DA
49132011-10-12 Dmitry Antipov <dmantipov@yandex.ru>
4914
4915 * alloc.c (Fgc_status): Do not access beyond zombies array
4916 boundary if nzombies > MAX_ZOMBIES.
4917 * alloc.c (dump_zombies): Add missing format specifier.
4918
0324f3af
PE
49192011-10-12 Paul Eggert <eggert@cs.ucla.edu>
4920
b5525cac
PE
4921 * xdisp.c (set_cursor_from_row): Simplify conditionals,
4922 to pacify GCC 4.6.1 x86-64 with -O2 -Wstrict-overflow.
4923
0324f3af
PE
4924 * lread.c (read_escape): Allow hex escapes as large as ?\xfffffff.
4925 Some packages use them to denote characters with modifiers.
4926
e9b5f888
AS
49272011-10-11 Andreas Schwab <schwab@linux-m68k.org>
4928
4929 * lisp.h (GCPRO1_VAR, GCPRO2_VAR, GCPRO3_VAR, GCPRO4_VAR)
4930 (GCPRO5_VAR, GCPRO6_VAR, UNGCPRO_VAR): Add whitespace to avoid
4931 matching a pp-number. Rename parameter var to var1.
4932
127827c0
SM
49332011-10-11 Stefan Monnier <monnier@iro.umontreal.ca>
4934
4935 * minibuf.c (Finternal_complete_buffer): Fix last change (bug#9709).
4936
c8fd3bd0
GM
49372011-10-08 Glenn Morris <rgm@gnu.org>
4938
4939 * callint.c (Fcall_interactively): Give a more explicit error for the
4940 'c' case with a non-character input. (Bug#8479)
4941
352ec8ff
EZ
49422011-10-08 Eli Zaretskii <eliz@gnu.org>
4943
03669ccb
EZ
4944 * xdisp.c (hscroll_window_tree): Support hscroll in right-to-left
4945 lines.
7061c986
EZ
4946 (set_cursor_from_row): Fix cursor positioning in mixed L2R+R2L
4947 lines that are hscrolled on the left.
03669ccb 4948
352ec8ff
EZ
4949 * dispnew.c (buffer_posn_from_coords): Account for a possible
4950 presence of header-line. (Bug#4426)
4951
a66cfb1c
SM
49522011-10-07 Stefan Monnier <monnier@iro.umontreal.ca>
4953
6b02f655
SM
4954 * buffer.c (syms_of_buffer) <enable-multibyte-characters>:
4955 Don't advertise functionality which we discourage or doesn't work.
a66cfb1c 4956
7c5ee88e
PE
49572011-10-07 Paul Eggert <eggert@cs.ucla.edu>
4958
4959 * alloc.c (GC_LISP_OBJECT_ALIGNMENT): Use offsetof, not __alignof__
4960 or sizeof. __alignof__ gives the wrong answer on Fedora x86-64
4961 with GCC 4.6.1 when configured with CC='gcc -m32' --with-wide-int;
4962 this makes Emacs dump core during garbage collection on rare
4963 occasions. sizeof is obviously inferior to offsetof here, so
4964 stick with offsetof.
4965 (GC_POINTER_ALIGNMENT): New macro.
4966 (mark_memory): Omit 3rd (offset) arg; caller changed.
4967 Don't assume EMACS_INT alignment is the same as pointer alignment.
4968
df1bbe5b
SM
49692011-10-03 Stefan Monnier <monnier@iro.umontreal.ca>
4970
4971 * keyboard.c (read_key_sequence_remapped): New var.
4972 (read_key_sequence): Compute remapping in the right buffer.
4973 (command_loop_1): Use read_key_sequence's remapping directly.
4974
51553db6
SM
49752011-10-02 Stefan Monnier <monnier@iro.umontreal.ca>
4976
32c1fffd
SM
4977 * dired.c (file_name_completion): Don't expand file name.
4978 (Ffile_name_completion, Ffile_name_all_completions): Expand file name
4979 before checking file name handler.
4980
51553db6
SM
4981 * minibuf.c (Finternal_complete_buffer): Only show internal buffers if
4982 they've been requested explicitly (bug#9591).
4983
b6bd1599 49842011-10-01 Andreas Schwab <schwab@linux-m68k.org>
fa2ec41f
AS
4985
4986 * keymap.c (Fsingle_key_description): Use make_specified_string
4987 instead of build_string to build string from push_key_description.
4988 (Bug#5193)
4989
f701dc2a
PE
49902011-09-30 Paul Eggert <eggert@cs.ucla.edu>
4991
4222c55d
PE
4992 * buffer.h (struct buffer): Use time_t, not int, for a time stamp.
4993 This fixes a Y2038 bug on 64-bit hosts.
4994 * buffer.c (reset_buffer):
4995 * fileio.c (Fdo_auto_save, Fset_buffer_auto_saved)
4996 (Fclear_buffer_auto_save_failure):
4997 Use 0, not -1, to represent an unset failure time, since time_t
4998 might not be signed.
4999
f701dc2a
PE
5000 Remove dependency on glibc malloc internals.
5001 * alloc.c (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
5002 Move back here from lisp.h, but with their new implementations.
5003 (XMALLOC_BASE_ALIGNMENT, COMMON_MULTIPLE, XMALLOC_HEADER_ALIGNMENT)
5004 (XMALLOC_OVERRUN_SIZE_SIZE): Move these new lisp.h macros here.
5005 * charset.c (charset_table_init): New static var.
5006 (syms_of_charset): Use it instead of xmalloc. This removes a
5007 dependency on glibc malloc internals. See Eli Zaretskii's comment in
5008 <http://lists.gnu.org/archive/html/emacs-devel/2011-09/msg00815.html>.
5009 * lisp.h (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
5010 Move back to alloc.c.
5011 (XMALLOC_BASE_ALIGNMENT, COMMON_MULTIPLE, XMALLOC_HEADER_ALIGNMENT)
5012 (XMALLOC_OVERRUN_SIZE_SIZE): Move to alloc.c.
5013
9ceebf39
JD
50142011-09-30 Jan Djärv <jan.h.d@swipnet.se>
5015
5016 * nsterm.m (windowDidResize): Call x_set_window_size only when
5017 ns_in_resize is true. Otherwise set pixelwidth/height and
5018 call change_frame_size (Bug#9628).
5019
cb993c58
PE
50202011-09-30 Paul Eggert <eggert@cs.ucla.edu>
5021
3930c88b
PE
5022 Port --enable-checking=all to Fedora 14 x86-64.
5023 * charset.c (syms_of_charset): Also account for glibc malloc's
5024 internal overhead when calculating the initial malloc maximum.
5025
cb993c58
PE
5026 Port --enable-checking=all to Fedora 14 x86.
5027 * alloc.c (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
5028 Move to lisp.h.
5029 (xmalloc_put_size, xmalloc_get_size, overrun_check_malloc)
5030 (overrun_check_realloc, overrun_check_free):
5031 Use XMALLOC_OVERRUN_SIZE_SIZE, not sizeof (size_t).
5032 That way, xmalloc returns a properly-aligned pointer even if
5033 XMALLOC_OVERRUN_CHECK is defined. The old debugging code happened
5034 to align OK on typical 64-bit hosts, but not on Fedora 14 x86.
5035 * charset.c (syms_of_charset): Take XMALLOC_OVERRUN_CHECK_OVERHEAD
5036 into account when calculating the initial malloc maximum.
5037 * lisp.h (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
5038 Move here from alloc.c, so that charset.c can use it too.
5039 Properly align; the old code wasn't right for common 32-bit hosts
5040 when configured with --enable-checking=all.
5041 (XMALLOC_BASE_ALIGNMENT, COMMON_MULTIPLE, XMALLOC_HEADER_ALIGNMENT)
5042 (XMALLOC_OVERRUN_SIZE_SIZE): New macros.
5043
31bed486
EZ
50442011-09-29 Eli Zaretskii <eliz@gnu.org>
5045
04c70788 5046 * sysdep.c (snprintf) [!EOVERFLOW]: If EOVERFLOW is not defined,
31bed486
EZ
5047 use EDOM.
5048
fbcaa2f3
EZ
50492011-09-28 Eli Zaretskii <eliz@gnu.org>
5050
5051 * xdisp.c (compute_display_string_end): If there's no display
5052 string at CHARPOS, return -1.
5053
5054 * bidi.c (bidi_fetch_char): When compute_display_string_end
5055 returns a negative value, treat the character as a normal
5056 character not covered by a display string. (Bug#9624)
5057
a239d4e9
JB
50582011-09-28 Juanma Barranquero <lekktu@gmail.com>
5059
5060 * lread.c (Fread_from_string): Fix typo in docstring.
5061
88652fd5
EZ
50622011-09-27 Eli Zaretskii <eliz@gnu.org>
5063
5064 * xdisp.c (handle_invisible_prop): If invisible text ends on a
5065 newline, reseat the iterator instead of bidi-iterating there one
5066 character at a time. (Bug#9610)
32c1fffd
SM
5067 (BUFFER_POS_REACHED_P, move_it_in_display_line_to): Bail when past
5068 TO_CHARPOS if the bidi iterator is at base embedding level.
88652fd5 5069
ed497dd4
AS
50702011-09-27 Andreas Schwab <schwab@linux-m68k.org>
5071
5072 * lread.c (readevalloop): Use correct code for NBSP.
5073 (read1): Likewise. (Bug#9608)
5074
b2bf61aa
MA
50752011-09-25 Michael Albinus <michael.albinus@gmx.de>
5076
5077 * dbusbind.c (Fdbus_register_signal): When service is not
5078 registered, use nil in Vdbus_registered_objects_table. (Bug#9581)
5079
32bbb17c
GM
50802011-09-25 Glenn Morris <rgm@gnu.org>
5081
5082 * buffer.c (truncate-lines): Doc fix.
5083
94e0933e
CY
50842011-09-24 Chong Yidong <cyd@stupidchicken.com>
5085
5086 * window.c (Fwindow_prev_buffers, Fset_window_prev_buffers)
5087 (Fset_window_next_buffers): Doc fix.
5088
cddde921
GM
50892011-09-24 Glenn Morris <rgm@gnu.org>
5090
5091 * minibuf.c (read_minibuf): Disable line truncation. (Bug#5715)
5092
1260aef1
PE
50932011-09-24 Paul Eggert <eggert@cs.ucla.edu>
5094
25b4bfa0
PE
5095 Fix minor problems found by static checking.
5096 * xdisp.c (string_from_display_spec): Don't assume vecsize fits in int.
1260aef1
PE
5097 * indent.c (Fvertical_motion): Fix == vs = typo.
5098
e3cbd34b
EZ
50992011-09-24 Eli Zaretskii <eliz@gnu.org>
5100
a66cfb1c
SM
5101 * dispnew.c (syms_of_display) <redisplay-dont-pause>:
5102 Default value is now t. Doc fix.
6bf7006f 5103
e3cbd34b 5104 * indent.c (Fvertical_motion): Compute and apply the overshoot
32c1fffd 5105 logic when moving up, not only when moving down. Fix the
e3cbd34b 5106 confusing name and values of the it_overshoot_expected variable;
32c1fffd 5107 logic changes accordingly. (Bug#9254) (Bug#9549)
e3cbd34b
EZ
5108
5109 * xdisp.c (pos_visible_p): Produce correct pixel coordinates when
5110 CHARPOS is covered by a display string which includes newlines.
5111 (move_it_vertically_backward): Avoid inflooping when START_CHARPOS
5112 is covered by a display string with embedded newlines.
5113
a3de0cbd
MA
51142011-09-24 Michael Albinus <michael.albinus@gmx.de>
5115
5116 * dbusbind.c (Fdbus_register_signal): Add match rule to
5117 Vdbus_registered_objects_table. (Bug#9581)
a66cfb1c
SM
5118 (Fdbus_register_method, Vdbus_registered_objects_table):
5119 Fix docstring.
a3de0cbd 5120
b260039d
JM
51212011-09-24 Jim Meyering <meyering@redhat.com>
5122
32c1fffd 5123 do not ignore write error for any output size
b260039d
JM
5124 The previous change was incomplete.
5125 While it makes emacs --batch detect the vast majority of stdout
5126 write failures, errors were still ignored whenever the output size is
5127 k * (BUFSIZ+1) - 4. E.g., on a system with BUFSIZ of 4096,
5128 $ emacs --batch --eval '(print (format "%4093d" 0))' > /dev/full \
5129 && echo FAIL: ignored write error
5130 FAIL: ignored write error
5131 $ emacs --batch --eval '(print (format "%20481d" 0))' > /dev/full \
5132 && echo FAIL: ignored write error
5133 FAIL: ignored write error
5134 * emacs.c (Fkill_emacs): Also test ferror. (Bug#9574)
5135
8eca8a7c
AS
51362011-09-23 Andreas Schwab <schwab@linux-m68k.org>
5137
5138 * emacs.c (Fkill_emacs): In noninteractive mode exit
5139 non-successfully if a write error occurred on stdout. (Bug#9574)
5140
3341db62
EZ
51412011-09-21 Eli Zaretskii <eliz@gnu.org>
5142
5143 * xdisp.c (pop_it): Allow it->object that is a cons cell to pass
5144 the xassert test.
5145
5146 * dispextern.h (struct it): Update the comment documenting what
5147 can it->OBJECT be.
5148
8c203dbf
EZ
51492011-09-20 Eli Zaretskii <eliz@gnu.org>
5150
5151 * xdisp.c (set_cursor_from_row): If the row ends in a newline from
5152 a display string, extend search for cursor position to end of row.
5153 (find_row_edges): If the row ends in a newline from a display
5154 string, increment its MATRIX_ROW_END_CHARPOS by one. (Bug#9549)
5155 Handle the case of a display string with multiple newlines.
fd317ddf
EZ
5156 (Fcurrent_bidi_paragraph_direction): Fix search for previous
5157 non-empty line. Fixes confusing cursor motion with arrow keys at
5158 the beginning of a line that starts with whitespace.
8c203dbf 5159
a4824228
LMI
51602011-09-19 Lars Magne Ingebrigtsen <larsi@gnus.org>
5161
5162 * lread.c (Fread_from_string): Document what FINAL-STRING-INDEX is
5163 (bug#9493).
5164
33ed493b
CY
51652011-09-18 Chong Yidong <cyd@stupidchicken.com>
5166
5167 * xfns.c (Fx_create_frame): Handle the bitmapIcon resource as
5168 boolean (Bug#9154).
5169
56cd55c8
EZ
51702011-09-18 Eli Zaretskii <eliz@gnu.org>
5171
5172 * xdisp.c (display_line): Record maximum and minimum buffer
5173 positions even if no glyphs were produced (e.g., by a zero-width
5174 stretch). Fixes bug#9530 on a TTY. Under word-wrap, don't record
5175 buffer positions that will be removed from the glyph row because
5176 they don't fit.
c02dcedf
EZ
5177 (produce_stretch_glyph): Fix a bug in :align-to on a TTY when the
5178 column is beyond frame width: don't subtract 1 "pixel" when
5179 computing width of the stretch.
3e62b7e0
EZ
5180 (reseat_at_next_visible_line_start): Undo the change made on
5181 2011-09-17 that saved paragraph information and restored it after
5182 the call to `reseat'. (Bug#9545)
56cd55c8 5183
5ed99d36 51842011-09-18 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
3390454c
YM
5185
5186 * xdisp.c (expose_window): Save original value of phys_cursor_on_p
5187 and turn window cursor on if cleared (Bug#9415).
5188
5ed99d36 51892011-09-18 Andreas Schwab <schwab@linux-m68k.org>
edb7b4dc
AS
5190
5191 * search.c (boyer_moore): Take unibyte characters from pattern
5192 literally. (Bug#9458)
5193
9bade7b2
EZ
51942011-09-18 Eli Zaretskii <eliz@gnu.org>
5195
5196 * xdisp.c (reseat_at_next_visible_line_start): Fix last change.
5197
e5e9d610
PE
51982011-09-18 Paul Eggert <eggert@cs.ucla.edu>
5199
87e4427a
PE
5200 Fix minor problem found by static checking.
5201 * xdisp.c (reseat_at_next_visible_line_start): Mark locals as
5202 initialized, to pacify gcc -Wuninitialized.
5203
e5e9d610
PE
5204 * fileio.c: Report proper errno when syscall falls.
5205 (Finsert_file_contents): Save and restore errno,
5206 so that report_file_error outputs the correct diagnostic.
5207 (Fwrite_region) [CLASH_DETECTION]: Likewise.
5208
a1674f0b
EZ
52092011-09-18 Eli Zaretskii <eliz@gnu.org>
5210
5211 * .gdbinit (pgx): Fix references to fields of `struct glyph'.
5212
fbfb6dd4
EZ
52132011-09-17 Eli Zaretskii <eliz@gnu.org>
5214
5215 * xdisp.c (produce_stretch_glyph): Another fix for changes made on
5216 2011-08-30T17:32:44Z!eliz@gnu.org. (Bug#9530)
5217
bb187662
EZ
52182011-09-17 Eli Zaretskii <eliz@gnu.org>
5219
1137e8b8 5220 * xdisp.c (reseat_at_next_visible_line_start): Keep information
6b02f655 5221 about the current paragraph and restore it after the call to reseat.
1137e8b8
EZ
5222
5223 * bidi.c (MAX_PARAGRAPH_SEARCH): New macro.
5224 (bidi_find_paragraph_start): Search back for paragraph beginning
5225 at most MAX_PARAGRAPH_SEARCH lines; if not found, return BEGV_BYTE.
5226 (bidi_move_to_visually_next): Only trigger paragraph-related
5227 computations when the last character is a newline or at EOB, not
5228 just any NEUTRAL_B. (Bug#9470)
5229
bb187662
EZ
5230 * xdisp.c (set_cursor_from_row): Don't invoke special treatment of
5231 truncated lines if point is covered by a display string. (Bug#9524)
5232
2e621251
PE
52332011-09-16 Paul Eggert <eggert@cs.ucla.edu>
5234
5235 * xselect.c: Relax test for outgoing X longs (Bug#9498).
5236 (cons_to_x_long): New function.
5237 (lisp_data_to_selection_data): Use it. Correct the test for
5238 short-versus-long data; it was negated. Break out of vector
5239 loop, for efficiency, when a long datum is discovered.
5240
91a15bc6
SM
52412011-09-16 Stefan Monnier <monnier@iro.umontreal.ca>
5242
5243 * eval.c (Fquote): Document its non-consing behavior (bug#9482).
5244
b41c3a35
EZ
52452011-09-16 Eli Zaretskii <eliz@gnu.org>
5246
5247 * image.c (tiff_handler): Work around a bug in MinGW GCC 3.x (see
5248 GCC PR/17406) by declaring this function with external scope.
5249
7812ba2d
PE
52502011-09-15 Paul Eggert <eggert@cs.ucla.edu>
5251
5252 * editfns.c (Fformat): Fix bug in text-property fix (Bug#9514).
5253 Don't mishandle (length (format "%%")) and (format "%4000s%%" "").
5254
cf7edc2a
AS
52552011-09-15 Andreas Schwab <schwab@linux-m68k.org>
5256
5257 * editfns.c (Fformat): Correctly handle text properties on "%%".
5258
bd01620e
EZ
52592011-09-15 Eli Zaretskii <eliz@gnu.org>
5260
5261 * xterm.c (x_draw_composite_glyph_string_foreground):
5262 * w32term.c (x_draw_composite_glyph_string_foreground):
5263 * term.c (encode_terminal_code):
5264 * composite.c (composition_update_it, get_composition_id):
5265 * xdisp.c (get_next_display_element)
5266 (fill_composite_glyph_string): Add comments about special meaning
5267 of TAB characters in a composition.
5268
a02719a3
PE
52692011-09-15 Paul Eggert <eggert@cs.ucla.edu>
5270
5271 * editfns.c (Fformat): Fix off-by-1 bug for "%%b" (Bug#9514).
4c122725
PE
5272 This occurs when processing a multibyte format.
5273 Problem reported by Wolfgang Jenker.
a02719a3 5274
72589a3c
JB
52752011-09-15 Johan Bockgård <bojohan@gnu.org>
5276
5277 * xdisp.c (try_cursor_movement): Only check for exact match if
5278 cursor hpos found by set_cursor_from_row is valid. (Bug#9495)
5279
1c14176c
PE
52802011-09-14 Paul Eggert <eggert@cs.ucla.edu>
5281
5282 Remove unused external symbols.
5283 * dispextern.h (calc_pixel_width_or_height): Remove decl.
5284 * xdisp.c (calc_pixel_width_or_height): Now static.
5285 * doprnt.c (exprintf) [! (HAVE_X_WINDOWS && USE_X_TOOLKIT)]: Remove.
5286 * indent.c (check_display_width):
5287 * w32term.c: Fix comment to match code.
5288 * xterm.c, xterm.h (x_catching_errors): Remove.
5289
d2eea5b5
PE
52902011-09-14 Paul Eggert <eggert@cs.ucla.edu>
5291
5292 * xselect.c: Use signed conversions more consistently (Bug#9498).
5293 (selection_data_to_lisp_data): Assume incoming selection data are
5294 signed integers, not unsigned. This is to be consistent with
5295 outgoing selection data, which was modified to use signed integers
5296 in as part of the fix to Bug#9196 in response to Jan D.'s comment
5297 in <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=9196#32> that X11
5298 expects long, not unsigned long.
5299
46888499
EZ
53002011-09-14 Eli Zaretskii <eliz@gnu.org>
5301
5302 * xdisp.c (try_window_reusing_current_matrix): Fix incorrect
5303 computation of loop end. Reported by Johan Bockgård
5304 <bojohan@gnu.org>.
5305
ef8ef9fb
CY
53062011-09-13 Chong Yidong <cyd@stupidchicken.com>
5307
5308 * frame.c (Fother_visible_frames_p): Function deleted.
5309
fa819fed
EZ
53102011-09-12 Eli Zaretskii <eliz@gnu.org>
5311
5312 * indent.c (compute_motion): Process display vector front to back
5313 rather than the other way around. (Bug#2496)
5314
2ba8e008
SM
53152011-09-12 Stefan Monnier <monnier@iro.umontreal.ca>
5316
5317 * fileio.c (Finsert_file_contents): Don't assume beg_offset is 0.
5318
20f53c69
CY
53192011-09-11 Chong Yidong <cyd@stupidchicken.com>
5320
5321 * minibuf.c (Fread_from_minibuffer): Doc fix.
5322
d562d7a4
EZ
53232011-09-11 Eli Zaretskii <eliz@gnu.org>
5324
5325 * xdisp.c (produce_stretch_glyph): Fix a typo made in changes from
5326 2011-08-30T17:32:44Z!eliz@gnu.org. (Bug#9475)
5327
1c4d7f3d
LMI
53282011-09-11 Lars Magne Ingebrigtsen <larsi@gnus.org>
5329
5330 * fileio.c (Fvisited_file_modtime): Document `(-1 65535)' as a
5331 value for non-existent files.
5332
b885bf36
EZ
53332011-09-11 Eli Zaretskii <eliz@gnu.org>
5334
5335 * fileio.c (Finsert_file_contents): If the file cannot be opened,
5336 set its "size" to -1. This will set the modtime_size field of
5337 the corresponding buffer to -1, which is what
5338 verify-visited-file-modtime expects for files that do not exist.
5339 (Bug#9139)
5340
6612f0bf
PE
53412011-09-11 Paul Eggert <eggert@cs.ucla.edu>
5342
5343 * keymap.h (KEY_DESCRIPTION_SIZE, push_key_description): Move decls
5344 here ...
5345 * lisp.h: ... from here. push_key_description is no longer
5346 defined in keyboard.c, so its declaration should not be in
5347 lisp.h's "Defined in keyboard.c" section, and KEY_DESCRIPTION_SIZE
5348 logically belongs with push_key_description.
5349
dfb3f755
PE
53502011-09-10 Paul Eggert <eggert@cs.ucla.edu>
5351
5352 * buffer.h: Include <sys/types.h> instead of <time.h>.
5353 Otherwise, off_t wasn't defined on FreeBSD 9.0-BETA2 i386.
5354 Problem reported by Herbert J. Skuhra.
5355
3134906c
LMI
53562011-09-10 Lars Magne Ingebrigtsen <larsi@gnus.org>
5357
5358 * xml.c (parse_region): Make the parsing work for
5359 non-comment-starting XML files again (bug#9144).
5360
8d903f4e
AS
53612011-09-10 Andreas Schwab <schwab@linux-m68k.org>
5362
5363 * image.c (gif_load): Fix calculation of bottom and right corner.
5364 (Bug#9468)
5365
80ad64f4
EZ
53662011-09-10 Eli Zaretskii <eliz@gnu.org>
5367
5368 * xdisp.c (MAX_DISP_SCAN): Decrease to 250. Prevents sluggish
5369 redisplay in small windows.
5370
208a048d
EZ
53712011-09-09 Eli Zaretskii <eliz@gnu.org>
5372
5373 * frame.c (x_report_frame_params): Cast to avoid compiler warnings.
5374
9b1c252e
MR
53752011-09-08 Martin Rudalics <rudalics@gmx.at>
5376
5377 * window.c (Fset_window_prev_buffers, Fset_window_next_buffers):
5378 Operate on live windows only.
5379
2949f33b
JB
53802011-09-08 Juanma Barranquero <lekktu@gmail.com>
5381
5382 * emacs.c (my_heap_start): #ifdef to avoid warnings when unused.
5383
e08dcafd
EZ
53842011-09-07 Eli Zaretskii <eliz@gnu.org>
5385
5386 * xdisp.c (move_it_in_display_line_to): Call RESTORE_IT on ppos_it
5387 only under bidi iteration.
5388
115b96bd
JD
53892011-09-07 Jan Djärv <jan.h.d@swipnet.se>
5390
5391 * gtkutil.c (xg_make_tool_item): Insert comment about eventbox.
5392
c8199d0f
PE
53932011-09-06 Paul Eggert <eggert@cs.ucla.edu>
5394
5395 isnan: Fix porting problem to Solaris 10 with bundled gcc.
5396 Without this fix, the command to link temacs failed due to an
5397 undefined symbol __builtin_isnan. This is because
5398 /usr/include/iso/math_c99.h #defines isnan(x) to
5399 __builtin_isnan(x), but the bundled gcc, which identifies itself
5400 as gcc 3.4.3 (csl-sol210-3_4-branch+sol_rpath), does not have
5401 a __builtin_isnan.
5402 * floatfns.c (isnan): #undef, and then #define to a clone of
5403 what's in data.c.
5404 (Fisnan): Always define, since it's always available now.
5405 (syms_of_floatfns): Always define isnan at the Lisp level.
5406
e39b275c 54072011-09-06 Paul Eggert <eggert@cs.ucla.edu>
1c262cae
PE
5408
5409 * Makefile.in (gl-stamp): move-if-change now in build-aux (Bug#9169).
5410
b2db44d9 54112011-09-06 Paul Eggert <eggert@cs.ucla.edu>
728f8f0a 5412
f4af5137 5413 * fileio.c: Fix bugs with large file offsets (Bug#9428).
728f8f0a
PE
5414 The previous code assumed that file offsets (off_t values) fit in
5415 EMACS_INT variables, which is not true on typical 32-bit hosts.
5416 The code messed up by falsely reporting buffer overflow in cases
5417 such as (insert-file-contents "big" nil 1 2) into an empty buffer
5418 when "big" contains more than 2**29 bytes, even though this
5419 inserts just one byte and does not overflow the buffer.
5420 (Finsert_file_contents): Store file offsets as off_t
5421 values, not as EMACS_INT values. Check for overflow when
5422 converting between EMACS_INT and off_t. When checking for
5423 buffer overflow or for overlap, take the offsets into account.
5424 Don't use EMACS_INT for small values where int suffices.
5425 When checking for overlap, fix a typo: ZV was used where
5426 ZV_BYTE was intended.
5427 (Fwrite_region): Don't assume off_t fits into 'long'.
5428 * buffer.h (struct buffer.modtime_size): Now off_t, not EMACS_INT.
5429
ecfc0a49
MA
54302011-09-05 Michael Albinus <michael.albinus@gmx.de>
5431
5432 * dbusbind.c (xd_signature_cat): Rename from signature_cat.
5433
6511acf2 54342011-09-04 Paul Eggert <eggert@cs.ucla.edu>
61bfeeb7 5435
0999621a 5436 sprintf-related integer and memory overflow issues (Bug#9412).
62f19c19
PE
5437
5438 * doprnt.c (doprnt): Support printing ptrdiff_t and intmax_t values.
8666506e 5439 (esprintf, exprintf, evxprintf): New functions.
62f19c19 5440 * keyboard.c (command_loop_level): Now EMACS_INT, not int.
6b02f655 5441 (cmd_error): Kbd macro iterations count is now EMACS_INT, not int.
62f19c19
PE
5442 (modify_event_symbol): Do not assume that the length of
5443 name_alist_or_stem is safe to alloca and fits in int.
5444 (Fexecute_extended_command): Likewise for function name and binding.
5445 (Frecursion_depth): Wrap around reliably on integer overflow.
5446 * keymap.c (push_key_description): First arg is now EMACS_INT, not int,
5447 since some callers pass EMACS_INT values.
5448 (Fsingle_key_description): Don't crash if symbol name contains more
5449 than MAX_ALLOCA bytes.
5450 * minibuf.c (minibuf_level): Now EMACS_INT, not int.
5451 (get_minibuffer): Arg is now EMACS_INT, not int.
5452 * lisp.h (get_minibuffer, push_key_description): Reflect API changes.
8666506e 5453 (esprintf, exprintf, evxprintf): New decls.
62f19c19
PE
5454 * window.h (command_loop_level, minibuf_level): Reflect API changes.
5455
2be7d702
PE
5456 * dbusbind.c (signature_cat): New function.
5457 (xd_signature, Fdbus_register_signal):
2ea16b89
PE
5458 Do not overrun buffer; instead, report string overflow.
5459
9d1df220
PE
5460 * dispnew.c (add_window_display_history): Don't overrun buffer.
5461 Truncate instead; this is OK since it's just a log.
5462
33ef5c64
PE
5463 * editfns.c (Fcurrent_time_zone): Don't overrun buffer
5464 even if the time zone offset is outlandishly large.
5465 Don't mishandle offset == INT_MIN.
5466
66c6fdd5
PE
5467 * emacs.c (main) [NS_IMPL_COCOA]: Don't overrun buffer
5468 when creating daemon; the previous buffer-overflow check was incorrect.
5469
d749b01b
PE
5470 * eval.c (verror): Simplify by rewriting in terms of evxprintf,
5471 which has the guts of the old verror function.
5472
b5cd1905
PE
5473 * filelock.c (lock_file_1, lock_file): Don't blindly alloca long name;
5474 use SAFE_ALLOCA instead. Use esprintf to avoid int-overflow issues.
5475
6e1a67fb
PE
5476 * font.c: Include <float.h>, for DBL_MAX_10_EXP.
5477 (font_unparse_xlfd): Don't blindly alloca long strings.
c21721cc 5478 Don't assume XINT result fits in int, or that XFLOAT_DATA * 10
8666506e 5479 fits in int, when using sprintf. Use single snprintf to count
c21721cc
PE
5480 length of string rather than counting it via multiple sprintfs;
5481 that's simpler and more reliable.
c21721cc
PE
5482 (font_unparse_fcname): Use it to avoid sprintf buffer overrun.
5483 (generate_otf_features) [0 && HAVE_LIBOTF]: Use esprintf, not
5484 sprintf, in case result does not fit in int.
5485
c57b67fc
PE
5486 * fontset.c (num_auto_fontsets): Now printmax_t, not int.
5487 (fontset_from_font): Print it.
5488
8a401434
PE
5489 * frame.c (tty_frame_count): Now printmax_t, not int.
5490 (make_terminal_frame, set_term_frame_name): Print it.
5491 (x_report_frame_params): In X, window IDs are unsigned long,
5492 not signed long, so print them as unsigned.
5493 (validate_x_resource_name): Check for implausibly long names,
5494 and don't assume name length fits in 'int'.
5495 (x_get_resource_string): Don't blindly alloca invocation name;
5496 use SAFE_ALLOCA. Use esprintf, not sprintf, in case result does
5497 not fit in int.
5498
6e1a67fb
PE
5499 * gtkutil.c: Include <float.h>, for DBL_MAX_10_EXP.
5500 (xg_check_special_colors, xg_set_geometry):
84722b3d
PE
5501 Make sprintf buffers a bit bigger, to avoid potential buffer overrun.
5502
0df02bf3
PE
5503 * lread.c (dir_warning): Don't blindly alloca buffer; use SAFE_ALLOCA.
5504 Use esprintf, not sprintf, in case result does not fit in int.
5505
48e30793
PE
5506 * macros.c (executing_kbd_macro_iterations): Now EMACS_INT, not int.
5507 (Fend_kbd_macro): Don't mishandle MOST_NEGATIVE_FIXNUM by treating
5508 it as a large positive number.
5509 (Fexecute_kbd_macro): Don't assume repeat count fits in int.
5510 * macros.h (executing_kbd_macro_iterations): Now EMACS_INT, not int.
5511
a66ff6d8
PE
5512 * nsterm.m ((NSSize)windowWillResize): Use esprintf, not sprintf,
5513 in case result does not fit in int.
5514
aca216ff
PE
5515 * print.c (float_to_string): Detect width overflow more reliably.
5516 (print_object): Make sprintf buffer a bit bigger, to avoid potential
5517 buffer overrun. Don't assume list length fits in 'int'. Treat
5518 print length of 0 as 0, not as infinity; to be consistent with other
5519 uses of print length in this function. Don't overflow print length
5520 index. Don't assume hash table size fits in 'long', or that
5521 vectorlike size fits in 'unsigned long'.
5522
31c286f7
PE
5523 * process.c (make_process): Use printmax_t, not int, to format
5524 process-name gensyms.
5525
55e5faa1
PE
5526 * sysdep.c (snprintf) [! HAVE_SNPRINTF]: New function.
5527
80f2e268
PE
5528 * term.c (produce_glyphless_glyph): Make sprintf buffer a bit bigger
5529 to avoid potential buffer overrun.
5530
670741ab
PE
5531 * xfaces.c (x_update_menu_appearance): Don't overrun buffer
5532 if X resource line is longer than 512 bytes.
5533
b7163a50
PE
5534 * xfns.c (x_window): Make sprintf buffer a bit bigger
5535 to avoid potential buffer overrun.
5536
ae58ff1f
PE
5537 * xterm.c (x_io_error_quitter): Don't overrun sprintf buffer.
5538
c43c8a6a
PE
5539 * xterm.h (x_check_errors): Add ATTRIBUTE_FORMAT_PRINTF.
5540
3f8236f4
PE
55412011-09-04 Paul Eggert <eggert@cs.ucla.edu>
5542
53e9fe90 5543 Integer overflow fixes for scrolling, etc.
6511acf2
PE
5544 Without these, Emacs silently mishandles large integers sometimes.
5545 For example, "C-u 4294967297 M-x recenter" was treated as if
53e9fe90
PE
5546 it were "C-u 1 M-x recenter" on a typical 64-bit host.
5547
6511acf2
PE
5548 * xdisp.c (try_window_id): Check Emacs fixnum range before
5549 converting to 'int'.
806add1d 5550
6511acf2 5551 * window.c (window_scroll_line_based, Frecenter):
71f02bc5
PE
5552 Check that an Emacs fixnum is in range before assigning it to 'int'.
5553 (Frecenter, Fmove_to_window_line): Use EMACS_INT, not int, for
5554 values converted from Emacs fixnums.
5555 (Frecenter): Don't wrap around a line count if it is out of 'int'
5556 range; instead, treat it as an extreme value.
5557 (Fset_window_configuration, compare_window_configurations):
5558 Use ptrdiff_t, not int, for index that might exceed 2 GiB.
5559
6511acf2
PE
5560 * search.c (Freplace_match): Use ptrdiff_t, not int, for indexes
5561 that can exceed INT_MAX. Check that EMACS_INT value is in range
5562 before assigning it to the (possibly-narrower) index.
a0efffc8
PE
5563 (match_limit): Don't assume that a fixnum can fit in 'int'.
5564
6511acf2 5565 * print.c (print_object): Use ptrdiff_t, not int, for index that can
29ebea3b
PE
5566 exceed INT_MAX.
5567
6511acf2 5568 * indent.c (position_indentation): Now takes ptrdiff_t, not int.
3f8236f4
PE
5569 (Fvertical_motion): Don't wrap around LINES values that don't fit
5570 in 'int'. Instead, treat them as extreme values. This is good
5571 enough for windows, which can't have more than INT_MAX lines anyway.
5572
fcb901a7
LMI
55732011-09-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
5574
0f2f6b6d
LMI
5575 * Require libxml/parser.h to avoid compilation warning.
5576
fcb901a7
LMI
5577 * emacs.c (shut_down_emacs): Call xmlCleanupParser on shutdown.
5578
5579 * xml.c (parse_region): Don't call xmlCleanupParser after parsing,
5580 since this reportedly can destroy thread storage.
5581
6e20a0d4
CY
55822011-08-30 Chong Yidong <cyd@stupidchicken.com>
5583
5584 * syntax.c (find_defun_start): Update all cache variables if
5585 exiting early (Bug#9401).
5586
148ae00e
EZ
55872011-08-30 Eli Zaretskii <eliz@gnu.org>
5588
f6cfbd8f
EZ
5589 * image.c (x_bitmap_pixmap): Cast to int to avoid compiler warnings.
5590
148ae00e
EZ
5591 * xdisp.c (produce_stretch_glyph): No longer static, compiled also
5592 when HAVE_WINDOW_SYSTEM is not defined. Support both GUI and TTY
5593 frames. Call tty_append_glyph in the TTY case. (Bug#9402)
5594
5595 * term.c (tty_append_glyph): New function.
5596 (produce_stretch_glyph): Static function and its prototype deleted.
5597
a66cfb1c
SM
5598 * dispextern.h (produce_stretch_glyph, tty_append_glyph):
5599 Add prototypes.
148ae00e 5600
c4a07a4c
PE
56012011-08-29 Paul Eggert <eggert@cs.ucla.edu>
5602
5603 * image.c (parse_image_spec): Check for nonnegative, not for positive,
5604 when checking :margin (Bug#9390).
5605 (IMAGE_NON_NEGATIVE_INTEGER_VALUE_OR_PAIR):
a66cfb1c 5606 Rename from IMAGE_POSITIVE_INTEGER_VALUE_OR_PAIR,
c4a07a4c
PE
5607 so that the name doesn't mislead. All uses changed.
5608
6bc8cd65
JB
56092011-08-28 Johan Bockgård <bojohan@gnu.org>
5610
5611 * term.c (init_tty) [HAVE_GPM]: Move mouse settings after
5612 set_tty_hooks.
5613
dca4927e
EZ
56142011-08-27 Eli Zaretskii <eliz@gnu.org>
5615
5616 * xdisp.c (move_it_to): Don't bail out early when reaching
5617 position beyond to_charpos, if we are scanning backwards.
5618 (move_it_vertically_backward): When DY == 0, make sure we get to
5619 the first character in the line after the newline.
5620
f2cad773
PE
56212011-08-27 Paul Eggert <eggert@cs.ucla.edu>
5622
5623 * ccl.c: Improve and simplify overflow checking (Bug#9196).
5624 (ccl_driver): Do not generate an out-of-range pointer.
5625 (Fccl_execute_on_string): Remove unnecessary check for
5626 integer overflow, noted by Stefan Monnier in
5627 <http://lists.gnu.org/archive/html/emacs-devel/2011-08/msg00979.html>.
5628 Remove a FIXME that didn't need fixing.
5629 Simplify the newly-introduced buffer reallocation code.
5630
0cae2cdb
JB
56312011-08-27 Juanma Barranquero <lekktu@gmail.com>
5632
5633 * makefile.w32-in ($(BLD)/alloc.$(O)): Depend on lib/verify.h.
5634
5fc295a4 56352011-08-26 Paul Eggert <eggert@cs.ucla.edu>
ddff3151 5636
70c60eb2 5637 Integer and memory overflow issues (Bug#9196).
726e0ab1 5638
d31850da
PE
5639 * doc.c (get_doc_string): Rework so that
5640 get_doc_string_buffer_size is the actual buffer size, rather than
5641 being 1 less than the actual buffer size; this makes xpalloc more
5642 convenient.
5643
a69fbedb
PE
5644 * image.c (x_allocate_bitmap_record, cache_image):
5645 * xselect.c (Fx_register_dnd_atom):
5646 Simplify previous changes by using xpalloc.
5647
fe5c5d37
PE
5648 * buffer.c (overlay_str_len): Now ptrdiff_t, not EMACS_INT,
5649 since either will do and ptrdiff_t is convenient with xpalloc.
5650
0065d054
PE
5651 * charset.c (charset_table_size)
5652 (struct charset_sort_data.priority): Now ptrdiff_t.
5653 (charset_compare): Don't overflow if priorities differ greatly.
5654 (Fsort_charsets): Don't assume list length fits in int.
5655 Check for size-calculation overflow when allocating sort data.
5656 (syms_of_charset): Allocate an initial charset table that is
5657 just under 64 KiB, to avoid problems with glibc malloc and mmap.
5658
5659 * cmds.c (internal_self_insert): Check for size-calculation overflow.
5660
5661 * composite.h (struct composition.glyph_len): Now int, not unsigned.
5662 The actual value is always <= INT_MAX, and leaving it unsigned made
5663 overflow checking harder.
5664
5665 * dispextern.h (struct glyph_matrix.rows_allocated)
5666 (struct face_cache.size): Now ptrdiff_t, for convenience in use
5667 with xpalloc. The values are still always <= INT_MAX.
5668
5669 * indent.c (compute_motion): Adjust to region_cache_forward sig change.
5670
5671 * lisp.h (xnmalloc, xnrealloc, xpalloc): New decls.
5672 (SAFE_NALLOCA): New macro.
5673
5674 * region-cache.c (struct boundary.pos, find_cache_boundary)
5675 (move_cache_gap, insert_cache_boundary, delete_cache_boundaries)
5676 (set_cache_region, invalidate_region_cache)
5677 (revalidate_region_cache, know_region_cache, region_cache_forward)
5678 (region_cache_backward, pp_cache):
5679 Use ptrdiff_t, not EMACS_INT, since either will do. This is needed
5680 so that ptrdiff_t * can be passed to xpalloc.
5681 (struct region_cache): Similarly, for gap_start, gap_len, cache_len,
5682 beg_unchanged, end_unchanged, buffer_beg, buffer_end members.
5683 (pp_cache): Don't assume cache_len fits in int.
5684 * region-cache.h: Adjust extern decls to match.
5685
5686 * search.c (scan_buffer, Freplace_match): Use ptrdiff_t, not
5687 EMACS_INT, since either will do, for xpalloc.
5688
5689 * alloc.c: Include verify.h, and check that int fits in ptrdiff_t.
5690 (xnmalloc, xnrealloc, xpalloc): New functions.
5691
726e0ab1
PE
5692 * bidi.c (bidi_shelve_header_size): New constant.
5693 (bidi_cache_ensure_space, bidi_shelve_cache): Use it.
5694 (bidi_cache_ensure_space): Avoid integer overflow when allocating.
5695
51f30bc5 5696 * bidi.c (bidi_cache_shrink):
726e0ab1
PE
5697 * buffer.c (overlays_at, overlays_in, record_overlay_string)
5698 (overlay_strings):
5699 Don't update size of array until after memory allocation succeeds,
5700 because xmalloc/xrealloc may not return.
0065d054
PE
5701 (struct sortstrlist.bytes): Now ptrdiff_t, as EMACS_INT doesn't help
5702 now that we have proper integer overflow checking.
5703 (record_overlay_string, overlay_strings): Catch overflows when
5704 calculating size of overlay_str_buf.
726e0ab1 5705
0065d054
PE
5706 * callproc.c (Fcall_process): Check for size overflow when
5707 calculating size of args2.
5708 (child_setup): Avoid overflow by using size_t rather than ptrdiff_t.
5709 Normally we prefer signed values, but sticking with ptrdiff_t would
5710 require adding more-complicated checks.
726e0ab1
PE
5711
5712 * ccl.c (Fccl_execute_on_string): Check for memory overflow.
5713 Use ptrdiff_t rather than EMACS_INT where ptrdiff_t will do.
5714 Redo buffer-overflow calculations to avoid integer overflow.
0065d054 5715 Add a FIXME comment where memory seems to be over-allocated.
726e0ab1
PE
5716
5717 * character.c (Fstring): Check for size-calculation overflow.
5718
5719 * coding.c (produce_chars): Redo buffer-overflow calculations to avoid
5720 unnecessary integer overflow. Check for size overflow.
5721 (encode_coding_object): Don't update size until xmalloc succeeds.
5722
5723 * composite.c (get_composition_id): Check for overflow in glyph
5724 length calculations.
5725
5726 Integer and memory overflow fixes for display code.
5727 * dispextern.h (struct glyph_pool.nglyphs): Now ptrdiff_t, not int.
5728 * dispnew.c (adjust_glyph_matrix, realloc_glyph_pool)
5729 (scrolling_window): Check for overflow in size calculations.
5730 (line_draw_cost, realloc_glyph_pool, add_row_entry):
5731 Don't assume glyph table len fits in int.
5732 (struct row_entry.bucket, row_entry_pool_size, row_entry_idx)
5733 (row_table_size): Now ptrdiff_t, not int.
5734 (scrolling_window): Avoid overflow in size calculations.
5735 Don't update size until allocation succeeds.
5736 * fns.c (concat): Check for overflow in size calculations.
5737 (next_almost_prime): Verify NEXT_ALMOST_PRIME_LIMIT.
5738 * lisp.h (RANGED_INTEGERP, TYPE_RANGED_INTEGERP): New macros.
5739 (NEXT_ALMOST_PRIME_LIMIT): New constant.
5740
5741 * doc.c (get_doc_string_buffer_size): Now ptrdiff_t, not int.
5742 (get_doc_string): Check for size calculation overflow.
5743 Don't update size until allocation succeeds.
5744 (get_doc_string, Fsubstitute_command_keys): Use ptrdiff_t, not
5745 EMACS_INT, where ptrdiff_t will do.
5746 (Fsubstitute_command_keys): Check for string overflow.
5747
5748 * editfns.c (set_time_zone_rule): Don't assume environment length
5749 fits in int.
5750 (message_length): Now ptrdiff_t, not int.
5751 (Fmessage_box): Don't update size until allocation succeeds.
5752 Don't assume message length fits in int.
5753 (Fformat): Use ptrdiff_t, not EMACS_INT, where ptrdiff_t will do.
5754
0065d054
PE
5755 * emacs.c (main): Do not reallocate argv, since there is a null at
5756 the end that can be overwritten, and this way there's no need to
5757 worry about size-calculation overflow.
5758 (sort_args): Check for size-calculation overflow.
726e0ab1
PE
5759
5760 * eval.c (init_eval_once, grow_specpdl): Don't update size until
5761 alloc succeeds.
5762 (call_debugger, grow_specpdl): Redo calculations to avoid overflow.
5763
5764 * frame.c (set_menu_bar_lines, x_set_frame_parameters)
5765 (x_set_scroll_bar_width, x_figure_window_size):
5766 Check for integer overflow.
5767 (x_set_alpha): Do not assume XINT fits in int.
5768
5769 * frame.h (struct frame): Use int, not EMACS_INT, where int works.
5770 This is for the members text_lines, text_cols, total_lines, total_cols,
5771 where the system imposes an 'int' limit.
5772
5773 * fringe.c (Fdefine_fringe_bitmap):
5774 Don't update size until alloc works.
5775
5776 * ftfont.c (ftfont_get_open_type_spec, setup_otf_gstring)
5777 (ftfont_shape_by_flt): Check for integer overflow in size calculations.
5778
5779 * gtkutil.c (get_utf8_string, xg_store_widget_in_map):
5780 Check for size-calculation overflow.
5781 (get_utf8_string): Use ptrdiff_t, not size_t, where either will
5782 do, as we prefer signed integers.
5783 (id_to_widget.max_size, id_to_widget.used)
5784 (xg_store_widget_in_map, xg_remove_widget_from_map)
5785 (xg_get_widget_from_map, xg_get_scroll_id_for_window)
5786 (xg_remove_scroll_bar, xg_update_scrollbar_pos):
5787 Use and return ptrdiff_t, not int.
5788 (xg_gtk_scroll_destroy): Don't assume ptrdiff_t fits in int.
5789 * gtkutil.h: Change prototypes to match the above.
5790
5791 * image.c (RANGED_INTEGERP, TYPE_RANGED_INTEGERP): Remove; these
5792 are duplicate now that they've been promoted to lisp.h.
5793 (x_allocate_bitmap_record, x_alloc_image_color)
5794 (make_image_cache, cache_image, xpm_load):
5795 Don't update size until alloc is done.
5796 (xpm_load, lookup_rgb_color, lookup_pixel_color, x_to_xcolors)
5797 (x_detect_edges):
3256efce 5798 Check for size calculation overflow.
726e0ab1
PE
5799 (ct_colors_allocated_max): New constant.
5800 (x_to_xcolors, x_detect_edges): Reorder multiplicands to avoid
5801 overflow.
3256efce 5802
726e0ab1
PE
5803 * keyboard.c (read_char, menu_bar_items, tool_bar_items)
5804 (read_char_x_menu_prompt, read_char_minibuf_menu_width)
5805 (read_char_minibuf_menu_prompt, follow_key, read_key_sequence):
5806 Use ptrdiff_t, not int, to count maps.
5807 (read_char_minibuf_menu_prompt): Check for overflow in size
a66cfb1c
SM
5808 calculations. Don't update size until allocation succeeds.
5809 Redo calculations to avoid overflow.
726e0ab1
PE
5810 * keyboard.h: Change prototypes to match the above.
5811
5812 * keymap.c (cmm_size, current_minor_maps): Use ptrdiff_t, not int,
5813 to count maps.
5814 (current_minor_maps): Check for size calculation overflow.
5815 * keymap.h: Change prototypes to match the above.
5816
5817 * lread.c (read1, init_obarray): Don't update size until alloc done.
5818
5819 * macros.c (Fstart_kbd_macro): Don't update size until alloc done.
5820 (store_kbd_macro_char): Reorder multiplicands to avoid overflow.
5821
726e0ab1
PE
5822 * nsterm.h (struct ns_color_table.size, struct ns_color_table.avail):
5823 Now ptrdiff_t, not int.
5824 * nsterm.m (ns_index_color): Use ptrdiff_t, not int, for table indexes.
5825 (ns_draw_fringe_bitmap): Rewrite to avoid overflow.
5826
5827 * process.c (Fnetwork_interface_list): Check for overflow
5828 in size calculation.
5829
5830 * region-cache.c (move_cache_gap): Check for size calculation overflow.
5831
5832 * scroll.c (do_line_insertion_deletion_costs): Check for size calc
5833 overflow. Don't bother calling xmalloc when xrealloc will do.
5834
5835 * search.c (Freplace_match): Check for size calculation overflow.
5836 (Fset_match_data): Don't assume list lengths fit in 'int'.
5837
5838 * sysdep.c (system_process_attributes): Use ptrdiff_t, not int,
5839 for command line length. Do not attempt to address one before the
5840 beginning of an array, as that's not portable.
5841
5842 * term.c (max_frame_lines): Remove; unused.
5843 (encode_terminal_src_size, encode_terminal_dst_size): Now ptrdiff_t,
5844 not int.
5845 (encode_terminal_code, calculate_costs): Check for size
5846 calculation overflow.
5847 (encode_terminal_code): Use ptrdiff_t, not int, to record glyph
5848 table lengths and related sizes. Don't update size until alloc
5849 done. Redo calculations to avoid overflow.
5850 (calculate_costs): Don't bother calling xmalloc when xrealloc will do.
5851
5852 * termcap.c (tgetent): Use ptrdiff_t, not int, to record results of
5853 subtracting pointers.
5854 (gobble_line): Check for overflow more carefully. Don't update size
5855 until alloc done.
5856
5857 * tparam.c (tparam1): Use ptrdiff_t, not int, for sizes.
5858 Don't update size until alloc done.
5859 Redo size calculations to avoid overflow.
5860 Check for size calculation overflow.
0065d054 5861 (main) [DEBUG]: Fix typo in invoking tparam1.
726e0ab1
PE
5862
5863 * xdisp.c (store_mode_line_noprop_char, x_consider_frame_title):
5864 Use ptrdiff_t, not int, for sizes.
5865 (store_mode_line_noprop_char): Don't update size until alloc done.
5866
0065d054
PE
5867 * xfaces.c (lface_id_to_name_size, Finternal_make_lisp_face):
5868 Use ptrdiff_t, not int, for sizes.
5869 (Finternal_make_lisp_face, cache_face):
5870 Check for size calculation overflow.
5871 (cache_face): Treat size calculation overflows as if they were
5872 memory exhaustion (the usual treatment), rather than aborting.
726e0ab1
PE
5873
5874 * xfns.c (x_encode_text, x_set_name_internal)
5875 (Fx_change_window_property): Use ptrdiff_t, not int, to count
5876 sizes, since they can exceed INT_MAX in size. Check for size
5877 calculation overflow.
5878
0065d054
PE
5879 * xgselect.c (gfds_size): Now ptrdiff_t, for convenience with xpalloc.
5880 (xg_select): Check for size calculation overflow.
726e0ab1
PE
5881 Don't update size until alloc done.
5882
0065d054 5883 * xrdb.c (get_environ_db): Don't assume path length fits in int,
726e0ab1 5884 as sprintf is limited to int lengths.
1d526e2f 5885
252c5ee1
PE
5886 * xselect.c (X_LONG_SIZE, X_SHRT_MAX, X_SHRT_MIN, X_LONG_MAX)
5887 (X_LONG_MIN): New macros.
864d7ce7
PE
5888 Use them to make the following changes clearer.
5889 (MAX_SELECTION_QUANTUM): Make the other bounds on this value clearer.
5890 This change doesn't affect the value now, but it may help remind
5891 future maintainers not to raise the value too much later.
5892 (SELECTION_QUANTUM): Remove, replacing with ...
5893 (selection_quantum): ... new function, which avoids overflow.
5894 All uses changed.
5895 (struct selection_data.size): Now ptrdiff_t, not int, to avoid
5896 assumption that selection length fits in 'int'.
5897 (x_reply_selection_request, x_handle_selection_request)
5898 (x_get_window_property, receive_incremental_selection)
5899 (x_get_window_property_as_lisp_data, selection_data_to_lisp_data)
5900 (lisp_data_to_selection_data, clean_local_selection_data):
5901 Use ptrdiff_t, not int, to record length of selection.
5902 (x_reply_selection_request, x_get_window_property)
5903 (receive_incremental_selection, x_property_data_to_lisp):
5904 Redo calculations to avoid overflow.
5905 (x_reply_selection_request): When sending hint, ceiling it at
252c5ee1 5906 X_LONG_MAX rather than relying on wraparound overflow to send
864d7ce7
PE
5907 something.
5908 (x_get_window_property, receive_incremental_selection)
5909 (lisp_data_to_selection_data, x_property_data_to_lisp):
5910 Check for size-calculation overflow.
5911 (x_get_window_property, receive_incremental_selection)
5912 (lisp_data_to_selection_data, Fx_register_dnd_atom):
5913 Don't store size until memory allocation succeeds.
5914 (x_get_window_property): Plug memory leak on memory exhaustion.
5915 Don't double-block input; malloc is safe here. Don't assume 2**34
5916 - 4 fits in unsigned long. Add an xassert to check
5917 XGetWindowProperty overflow. Be more careful about overflow
5918 calculations, and distinguish size from memory overflow better.
5919 (receive_incremental_selection): When tracing, don't assume
5920 unsigned int is less than INT_MAX.
5921 (x_selection_data_to_lisp_data): Remove unnecessary (and in theory
5922 harmful) conversions of unsigned short to int.
5923 (lisp_data_to_selection_data): Don't assume that integers
5924 in the range -65535 through -1 fit in an X unsigned short.
5925 Don't assume that ULONG_MAX == X_ULONG_MAX. Don't store into
5926 result parameters unless successful. Rely on cons_to_unsigned
5927 to report problems with elements; the old code wasn't right anyway.
5928 (x_check_property_data): Check for int overflow; we cannot use
5929 a wider type due to X limits.
5930 (x_handle_dnd_message): Use unsigned int, to avoid int overflow.
5931
726e0ab1 5932 * xsmfns.c (smc_save_yourself_CB): Check for size calc overflow.
34db673b 5933
0065d054
PE
5934 * xterm.c (x_color_cells, x_send_scrollbar_event, handle_one_xevent)
5935 (x_term_init): Check for size calculation overflow.
726e0ab1
PE
5936 (x_color_cells): Don't store size until memory allocation succeeds.
5937 (handle_one_xevent): Use ptrdiff_t, not int, for byte counts.
0065d054 5938 Don't assume alloca size is less than MAX_ALLOCA.
726e0ab1
PE
5939 (x_term_init): Don't assume length fits in int (sprintf is limited
5940 to int size).
bc18e09d 5941
ebfa62c0
PE
5942 Use ptrdiff_t for composition IDs.
5943 * character.c (lisp_string_width):
5944 * composite.c (composition_table_size, n_compositions)
5945 (get_composition_id, composition_gstring_from_id):
5946 * dispextern.h (struct glyph_string.cmp_id, struct composition_it.id):
5947 * xdisp.c (BUILD_COMPOSITE_GLYPH_STRING):
5948 * window.c (Frecenter):
5949 Use ptrdiff_t, not int, for composition IDs.
5950 * composite.c (get_composition_id): Check for integer overflow.
5951 * composite.h: Adjust prototypes to match the above changes.
5952
d3411f89
PE
5953 Use ptrdiff_t for hash table indexes.
5954 * category.c (hash_get_category_set):
5955 * ccl.c (ccl_driver):
5956 * charset.h (struct charset.hash_index, CHECK_CHARSET_GET_ID):
5957 * coding.c (coding_system_charset_list, detect_coding_system):
5958 * coding.h (struct coding_system.id):
5959 * composite.c (get_composition_id, gstring_lookup_cache):
5960 * fns.c (hash_lookup, hash_put, Fgethash, Fputhash):
5961 * image.c (xpm_get_color_table_h):
5962 * lisp.h (hash_lookup, hash_put):
5963 * minibuf.c (Ftest_completion):
5964 Use ptrdiff_t for hash table indexes, not int (which is too
5965 narrow, on 64-bit hosts) or EMACS_INT (which is too wide, on
5966 32-bit --with-wide-int hosts).
5967
e097a6fa
PE
5968 * charset.c (Fdefine_charset_internal): Check for integer overflow.
5969 Add a FIXME comment about memory leaks.
5970 (syms_of_charset): Don't assume xmalloc returns.
5971
5637687f
PE
5972 Don't assume that stated character widths fit in int.
5973 * character.c (Fchar_width, c_string_width, lisp_string_width):
5974 * character.h (CHAR_WIDTH):
5975 * indent.c (MULTIBYTE_BYTES_WIDTH):
5976 Use sanitize_char_width to avoid undefined and/or bad behavior
5977 with outlandish widths.
a66cfb1c 5978 * character.h (sanitize_tab_width): Rename from sanitize_width,
5637687f
PE
5979 now that we have two such functions. All uses changed.
5980 (sanitize_char_width): New inline function.
5981
a2271ba2
PE
5982 Don't assume that tab-width fits in int.
5983 * character.h (sanitize_width): New inline function.
5984 (SANE_TAB_WIDTH): New macro.
5985 (ASCII_CHAR_WIDTH): Use it.
5986 * indent.c (sane_tab_width): Remove. All uses replaced by
5987 SANE_TAB_WIDTH (current_buffer).
5988 * xdisp.c (init_iterator): Use SANE_TAB_WIDTH.
5989
18c52557
PE
5990 * fileio.c: Integer overflow issues with file modes.
5991 (Fset_file_modes, auto_save_1): Don't assume EMACS_INT fits in int.
5992
caeeedc1
PE
5993 * charset.c (read_hex): New arg OVERFLOW. All uses changed.
5994 Remove unreachable code.
5995 (read_hex, load_charset_map_from_file): Check for integer overflow.
5996
6df6ae42 5997 * xterm.c: Don't go over XClientMessageEvent limit.
50849c52
PE
5998 (scroll_bar_windows_size): Now ptrdiff_t, as we prefer signed.
5999 (x_send_scroll_bar_event): Likewise. Check that the size does not
6000 exceed limits imposed by XClientMessageEvent, as well as the usual
6001 ptrdiff_t and size_t limits.
6002
b13995db
PE
6003 * keyboard.c: Overflow, signedness and related fixes.
6004 (make_lispy_movement): Use same integer type in forward decl
6005 that is used in the definition.
6006 (read_key_sequence, keyremap_step):
6007 Change bufsize argument back to int, undoing my 2011-03-30 change.
6008 We prefer signed types, and int is wide enough here.
6009 (parse_tool_bar_item): Don't assume tool_bar_max_label_size is less
6010 than TYPE_MAXIMUM (EMACS_INT) / 2. Don't let the label size grow
6011 larger than STRING_BYTES_BOUND. Use ptrdiff_t for Emacs string
6012 length, not size_t. Use ptrdiff_t for index, not int.
6013 (keyremap_step, read_key_sequence): Redo bufsize check to avoid
6014 possibility of integer overflow.
6015
13464394
PE
6016 Overflow, signedness and related fixes for images.
6017
6018 * dispextern.h (struct it.stack[0].u.image.image_id)
6019 (struct_it.image_id, struct image.id, struct image_cache.size)
6020 (struct image_cache.used, struct image_cache.ref_count):
6021 * gtkutil.c (update_frame_tool_bar):
6022 * image.c (x_reference_bitmap, Fimage_size, Fimage_mask_p)
6023 (Fimage_metadata, free_image_cache, clear_image_cache, lookup_image)
6024 (cache_image, mark_image_cache, x_kill_gs_process, Flookup_image):
6025 * nsmenu.m (update_frame_tool_bar):
6026 * xdisp.c (calc_pixel_width_or_height):
6027 * xfns.c (image_cache_refcount):
6028 Image IDs are now ptrdiff_t, not int, to avoid arbitrary limits
6029 on typical 64-bit hosts.
6030
6031 * image.c (RANGED_INTEGERP, TYPE_RANGED_INTEGERP): New macros.
6032 (x_bitmap_pixmap, x_create_x_image_and_pixmap):
6033 Omit unnecessary casts to int.
6034 (parse_image_spec): Check that integers fall into 'int' range
6035 when the callers expect that.
6036 (image_ascent): Redo ascent calculation to avoid int overflow.
6037 (clear_image_cache): Avoid overflow when sqrt (INT_MAX) < nimages.
6038 (lookup_image): Remove unnecessary tests.
6039 (xbm_image_p): Locals are now of int, not EMACS_INT,
6040 since parse_image_check makes sure they fit into int.
6041 (png_load, gif_load, svg_load_image):
6042 Prefer int to unsigned where either will do.
6043 (tiff_handler): New function, combining the cores of the
a66cfb1c
SM
6044 old tiff_error_handler and tiff_warning_handler.
6045 This function is rewritten to use vsnprintf and thereby avoid
13464394
PE
6046 stack buffer overflows. It uses only the features of vsnprintf
6047 that are common to both POSIX and native Microsoft.
6048 (tiff_error_handler, tiff_warning_handler): Use it.
6049 (tiff_load, gif_load, imagemagick_load_image):
6050 Don't assume :index value fits in 'int'.
6051 (gif_load): Omit unnecessary cast to double, and avoid double-rounding.
6052 (imagemagick_load_image): Check that crop parameters fit into
6053 the integer types that MagickCropImage accepts. Don't assume
6054 Vimagemagick_render_type has a nonnegative value. Don't assume
6055 size_t fits in 'long'.
6056 (gs_load): Use printmax_t to print the widest integers possible.
6057 Check for integer overflow when computing image height and width.
6058
c11821d4
EZ
60592011-08-26 Eli Zaretskii <eliz@gnu.org>
6060
6061 * xdisp.c (redisplay_window): Don't force window start if point
6062 will be invisible in the resulting window. (Bug#9324)
6063
0c95fcf7
EZ
60642011-08-25 Eli Zaretskii <eliz@gnu.org>
6065
6066 * xdisp.c (compute_display_string_pos): Return 2 in DISP_PROP when
6067 the display spec is of the form `(space ...)'.
6068 (handle_display_spec): Return the value returned by
6069 handle_single_display_spec, not just 1 or zero.
6070 (handle_single_display_spec): If the display spec is of the form
6071 `(space ...)', and specifies display in the text area, return 2
6072 rather than 1.
fee65a97 6073 (try_cursor_movement): Check for the need to scroll more
a66cfb1c
SM
6074 accurately, and prefer exact match for point under bidi.
6075 Don't advance `row' beyond the last row of the window.
0c95fcf7
EZ
6076
6077 * dispextern.h (struct bidi_it): Rename the disp_prop_p member
6078 into disp_prop; all users changed.
6079
6080 * bidi.c (bidi_fetch_char): If compute_display_string_pos returns
6081 DISP_PROP = 2, substitute the u+2029 PARAGRAPH SEPARATOR character
6082 for the text covered by the display property.
6083
e4ed06f1
CY
60842011-08-25 Chong Yidong <cyd@stupidchicken.com>
6085
6086 * buffer.c (Fbury_buffer_internal): Rename from Funrecord_buffer.
6087 Change return value to nil.
6088 (Frecord_buffer): Delete unused function.
6089
f67cdd7f
EZ
60902011-08-24 Eli Zaretskii <eliz@gnu.org>
6091
5980d4c6
EZ
6092 * xdisp.c (Fcurrent_bidi_paragraph_direction): For unibyte
6093 buffers, return left-to-right.
8610fe8b
EZ
6094 (set_cursor_from_row): Consider candidate row a win if its glyph
6095 represents a newline and point is on that newline. Fixes cursor
6096 positioning on the newline at EOL of R2L text within L2R
6097 paragraph, and vice versa.
6098 (try_cursor_movement): Check continued rows, in addition to
6099 continuation rows. Fixes unwarranted scroll when point enters a
6100 continued line of R2L text within an L2R paragraph, or vice versa.
6101 (cursor_row_p): Consider the case of point being equal to
6102 MATRIX_ROW_END_CHARPOS. Prevents cursor being stuck when moving
6103 from the end of a short line to the beginning of a continued line
6104 of R2L text within L2R paragraph.
6105 (RECORD_MAX_MIN_POS): For max_pos, use IT_CHARPOS even for
6106 composed characters.
5980d4c6 6107
f67cdd7f
EZ
6108 * bidi.c (bidi_check_type): Use xassert.
6109 (bidi_cache_iterator_state): Update the disp_pos and disp_prop_p
6110 members.
6111
bca633fb
EZ
61122011-08-23 Eli Zaretskii <eliz@gnu.org>
6113
6114 * bidi.c (bidi_get_type): Abort if we get zero as the bidi type of
6115 a character.
6116
4a5885a7
CY
61172011-08-23 Chong Yidong <cyd@stupidchicken.com>
6118
6119 * nsfont.m (ns_otf_to_script): Fix typo.
6120
0902a04e
KH
61212011-08-22 Kenichi Handa <handa@m17n.org>
6122
6123 * chartab.c (Fset_char_table_extra_slot): Do not inhibit setting a
6124 extra slot even if the purpose is char-code-property-table.
6125
1a2e6670
EZ
61262011-08-23 Eli Zaretskii <eliz@gnu.org>
6127
8ddde651
EZ
6128 * xdisp.c (redisplay_window): When computing centering_position,
6129 account for the height of the header line. (Bug#8874)
6130
425cc014
EZ
6131 * dispnew.c (buffer_posn_from_coords): Use buf_charpos_to_bytepos
6132 instead of CHAR_TO_BYTE. Fixes a crash when a completion
6133 candidate is selected by the mouse, and that candidate has a
6134 composed character under the mouse.
6135
1a2e6670
EZ
6136 * xdisp.c (x_produce_glyphs): Set it->nglyphs to 1. Fixes pixel
6137 coordinates reported by pos-visible-in-window-p for a composed
6138 character in column zero.
6139
8b76d6f8
SM
61402011-08-23 Stefan Monnier <monnier@iro.umontreal.ca>
6141
6142 * cmds.c (Fself_insert_command): Mention post-self-insert-hook.
6143
dac347dd
EZ
61442011-08-22 Eli Zaretskii <eliz@gnu.org>
6145
6146 * xdisp.c (BUFFER_POS_REACHED_P): If this is a composition,
6147 consider it a hit if to_charpos is anywhere in the range of the
6148 composed buffer positions.
6149
e013fb34
CY
61502011-08-22 Chong Yidong <cyd@stupidchicken.com>
6151
6152 * image.c (gif_load): Don't assume that each subimage has the same
6153 dimensions as the base image. Handle disposal method that is
6154 "undefined" by the gif spec (Bug#9335).
6155
bd1ba3e8
CY
61562011-08-20 Chong Yidong <cyd@stupidchicken.com>
6157
6158 * eval.c (Fsignal): Handle `debug' symbol in error handler (Bug#9329).
024a2d76 6159 (Fcondition_case): Document `debug' symbol in error handler.
bd1ba3e8 6160
54a1215b
EZ
61612011-08-19 Eli Zaretskii <eliz@gnu.org>
6162
823564e5
EZ
6163 * xfaces.c (face_at_buffer_position): Avoid repeated evaluation of
6164 face ID by FACE_FROM_ID, and avoid a crash when mouse is moved
6165 from an Org mode buffer to a Speedbar frame.
6166
54a1215b
EZ
6167 * xdisp.c (RECORD_MAX_MIN_POS): If the display element comes from
6168 a composition, take its buffer position from IT->cmp_it.charpos.
6169 Fixes cursor positioning at the beginning of a line that begins
6170 with a composed character.
6171
9778ebcc
EZ
61722011-08-18 Eli Zaretskii <eliz@gnu.org>
6173
0be6ee06
EZ
6174 * bidi.c (bidi_get_type): If bidi_type_table reports zero as the
6175 character bidirectional type, use STRONG_L instead. Fixes crashes
6176 in a buffer produced by `describe-categories'.
6177
9778ebcc
EZ
6178 * dispextern.h (struct bidi_it): Move disp_pos and disp_prop_p
6179 members before the level stack, so they would be saved and
6180 restored when copying iterator state. Fixes incorrect reordering
6181 around TABs covered by display properties.
6182
156bffbe
AS
61832011-08-18 Andreas Schwab <schwab@linux-m68k.org>
6184
6b02f655 6185 * process.c (Fnetwork_interface_list): Correctly determine buffer size.
156bffbe 6186
72ad093b
CY
61872011-08-17 Chong Yidong <cyd@stupidchicken.com>
6188
6189 * eval.c (internal_condition_case, internal_condition_case_1)
8b76d6f8
SM
6190 (internal_condition_case_2, internal_condition_case_n):
6191 Remove unnecessary aborts (Bug#9081).
72ad093b 6192
35774242
EZ
61932011-08-17 Eli Zaretskii <eliz@gnu.org>
6194
6195 * lread.c (Fload) [DOS_NT]: If `openp' returns -2, but the file
6196 has no `load' handler, try opening the file locally. (Bug#9311)
6197
db76dd85
KB
61982011-08-16 Ken Brown <kbrown@cornell.edu>
6199
6200 * gmalloc.c: Expand comment.
6201
b215eee5
EZ
62022011-08-16 Eli Zaretskii <eliz@gnu.org>
6203
6204 * xdisp.c (set_cursor_from_row): Don't accept a previous candidate
6205 if it fails the cursor_row_p test. Fixes cursor positioning at ZV.
6206
a4579d33
KB
62072011-08-16 Ken Brown <kbrown@cornell.edu>
6208
6209 Fix memory allocation problems in Cygwin build (Bug#9273).
6210
6211 * unexcw.c ( __malloc_initialized): Declare external variable.
6212 (fixup_executable): Force the dumped emacs to reinitialize malloc.
6213
8b76d6f8
SM
6214 * gmalloc.c [CYGWIN] (bss_sbrk_heapbase, bss_sbrk_heapinfo):
6215 New variables.
a4579d33
KB
6216 (malloc_initialize_1) [CYGWIN]: Prepare for reinitializing the
6217 dumped emacs.
6218 (_free_internal_nolock) [CYGWIN]: Ignore requests to free storage
6219 in the static heap.
6220 [CYGWIN] (special_realloc): New function.
6221 (_realloc_internal_nolock) [CYGWIN]: Use the new function on
6222 requests to realloc storage in the static heap.
6223
3ebec551
PE
62242011-08-15 Paul Eggert <eggert@cs.ucla.edu>
6225
6226 * bidi.c (bidi_initialize): Remove unused local.
6227
9fd8be00
EZ
62282011-08-15 Eli Zaretskii <eliz@gnu.org>
6229
6b02f655
SM
6230 * bidimirror.h:
6231 * biditype.h: Remove file.
6232 * makefile.w32-in ($(BLD)/bidi.$(O)):
6233 * deps.mk (bidi.o): Remove biditype.h and bidimirror.h.
474a8465
EZ
6234
6235 * dispextern.h: Fix a typo in the comment to bidi_type_t.
6236
6237 * chartab.c: Improve commentary for the uniprop_table API.
6238
32413314
EZ
6239 * bidi.c (bidi_paragraph_init): Support zero value of
6240 bidi_ignore_explicit_marks_for_paragraph_level.
474a8465
EZ
6241 (bidi_initialize): Use uniprop_table instead of including
6242 biditype.h and bidimirror.h.
32413314 6243
9fd8be00
EZ
6244 * xdisp.c (move_it_in_display_line_to): Don't reset pixel
6245 coordinates of the iterator when restoring from ppos_it.
6246 (Bug#9296)
6247
5cf2b69b
KH
62482011-08-14 Kenichi Handa <handa@m17n.org>
6249
6250 * process.c (create_process): Call setup_process_coding_systems
72ad093b 6251 after the pid of the process is set to -1 (Bug#8162).
5cf2b69b 6252
daf17d00
EZ
62532011-08-14 Eli Zaretskii <eliz@gnu.org>
6254
6255 * xdisp.c (move_it_in_display_line_to): Don't invoke
6256 IT_RESET_X_ASCENT_DESCENT when iterator position was restored from
6257 ppos_it. Fixes vertical cursor motion when line beginning is
6258 covered by an image. (Bug#9296)
6259
08e3161a
JD
62602011-08-14 Jan Djärv <jan.h.d@swipnet.se>
6261
6262 * nsterm.h (ns_run_ascript): Declare.
6263 (NSAPP_DATA2_RUNASSCRIPT): Define.
6264
6265 * nsfns.m (as_script, as_result, as_status): New static variables.
6266 (ns_run_ascript): New function.
5e617bc2 6267 (Fns_do_applescript): Set variables as_*. Make an NSApplicationDefined
08e3161a
JD
6268 event with data2 set to NSAPP_DATA2_RUNASSCRIPT, post it and then start
6269 the event loop. Get status from as_status (Bug#7276).
6270
6271 * nsterm.m (sendEvent): If event is NSApplicationDefined and
6272 data2 is NSAPP_DATA2_RUNASSCRIPT, call ns_run_ascript and then exit
6273 the event loop (Bug#7276).
6274
a3720aa2
AS
62752011-08-14 Andreas Schwab <schwab@linux-m68k.org>
6276
6277 * gnutls.c (QCgnutls_bootprop_priority)
6278 (QCgnutls_bootprop_trustfiles, QCgnutls_bootprop_keylist)
6279 (QCgnutls_bootprop_crlfiles, QCgnutls_bootprop_callbacks)
6280 (QCgnutls_bootprop_loglevel, QCgnutls_bootprop_hostname)
6281 (QCgnutls_bootprop_min_prime_bits, QCgnutls_bootprop_verify_flags)
6282 (QCgnutls_bootprop_verify_hostname_error)
6283 (QCgnutls_bootprop_callbacks_verify): Rename from
6284 Qgnutls_bootprop_..., all uses changed.
6285
6286 * xfaces.c (QCignore_defface): Rename from Qignore_defface, all
6287 uses changed.
6288
0a0d27fb
PE
62892011-08-14 Paul Eggert <eggert@cs.ucla.edu>
6290
19d5c50c
PE
6291 * xfaces.c (Qframe_set_background_mode): Now static.
6292 * dispextern.h (Qframe_set_background_mode): Remove decl.
6293
0a0d27fb
PE
6294 * process.c (Fnetwork_interface_info): Declare local only if needed.
6295
377538cb
JD
62962011-08-13 Jan Djärv <jan.h.d@swipnet.se>
6297
6298 * process.c: Include ifaddrs.h and net/if_dl.h if available (Bug#8477).
6299 (Fnetwork_interface_list): Allocate in increments of bytes instead
6300 of sizeof (struct ifreq). Iterate over ifconf.ifc_req by counting
6301 bytes (Bug#8477). Count bytes correctly when ifr_addr is a struct
6302 sockaddr.
6303 (struct ifflag_def): notrailers is smart on OSX.
6304 (Fnetwork_interface_info): Handle case when ifr_flags is negative.
6305 Get hardware address with getifaddrs if available.
6306
08fff70c
EZ
63072011-08-12 Eli Zaretskii <eliz@gnu.org>
6308
6309 * xdisp.c (iterate_out_of_display_property): xassert that
6310 IT->position is set to within IT->object's boundaries. Break from
6311 the loop as soon as EOB is reached; avoids infloops in redisplay
8b76d6f8
SM
6312 when IT->position is set up wrongly due to some bug.
6313 Set IT->current to match the bidi iterator unconditionally.
08fff70c
EZ
6314 (push_display_prop): Allow GET_FROM_STRING as IT->method on
6315 entry. Force push_it to save on the stack the current
6316 buffer/string position, to be restored by pop_it. Fix flags in
6317 the iterator structure wrt the object coming from a display
6318 property, as `line-prefix' and `wrap-prefix' are not ``replacing''
6319 properties. (Bug#9284)
6320
7be1c708 63212011-08-09 Andreas Schwab <schwab@linux-m68k.org>
aac0c6e3 6322
7be1c708
CY
6323 * fontset.c (fontset_get_font_group): Add proper type checks.
6324 (Bug#9172)
aac0c6e3 6325
7be1c708 63262011-08-09 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
aac0c6e3 6327
7be1c708
CY
6328 * unexmacosx.c (print_load_command_name): Add cases LC_FUNCTION_STARTS
6329 and LC_VERSION_MIN_MACOSX.
6330 (copy_linkedit_data) [LC_FUNCTION_STARTS]: New function.
6331 (dump_it) [LC_FUNCTION_STARTS]: Use it.
aac0c6e3 6332
97bb72a6
EZ
63332011-08-08 Eli Zaretskii <eliz@gnu.org>
6334
6335 * xdisp.c (forward_to_next_line_start): Allow to use the
8b76d6f8
SM
6336 no-display-properties-and-no-overlays under bidi display.
6337 Set disp_pos in the bidi iterator to avoid searches for display
757664a4 6338 properties and overlays.
97bb72a6 6339
d5617611
CY
63402011-08-08 Chong Yidong <cyd@stupidchicken.com>
6341
37e11a63
CY
6342 * editfns.c (Fset_time_zone_rule): Document relationship with the
6343 setenv function.
6344
d5617611
CY
6345 * ftfont.c (ftfont_pattern_entity): Copy the extras argument to
6346 the font entity extracted from the cache (Bug#8109).
6347
58872834
CY
63482011-08-07 Chong Yidong <cyd@stupidchicken.com>
6349
6350 * composite.c (autocmp_chars): Don't reset point. That is done by
6351 restore_point_unwind (Bug#5984).
6352
75bfc667
JL
63532011-08-07 Juri Linkov <juri@jurta.org>
6354
6355 * editfns.c (Fformat_time_string): Doc fix, add tag `usage:'
6356 to show the arg `TIME' instead of `TIMEVAL'.
6357
d1410150
EZ
63582011-08-06 Eli Zaretskii <eliz@gnu.org>
6359
6360 * xdisp.c (set_cursor_from_row): Fix cursor positioning when a
6361 display property strides EOL and includes a newline, as in
6362 longlines-mode. (Bug#9254)
75b771e4
EZ
6363 (move_it_in_display_line_to): Fix vertical-motion in a buffer with
6364 word-wrap under bidirectional display. (Bug#9224)
d1410150
EZ
6365
6366 * bidi.c (bidi_unshelve_cache): Don't reset the cache if JUST_FREE
6367 is non-zero, even if the data buffer is NULL. Fixes a crash in
6368 vertical-motion with longlines-mode. (Bug#9254)
6369
35928349
EZ
63702011-08-05 Eli Zaretskii <eliz@gnu.org>
6371
ec7cc85b
EZ
6372 * bidi.c <bidi_cache_total_alloc>: Now static.
6373 (bidi_initialize): Initialize bidi_cache_total_alloc.
6374
8b76d6f8 6375 * xdisp.c (display_line): Release buffer allocated for shelved bidi
35928349
EZ
6376 cache. (Bug#9221)
6377
6378 * bidi.c (bidi_shelve_cache, bidi_unshelve_cache): Track total
6379 amount allocated this far in `bidi_cache_total_alloc'.
6380 (bidi_unshelve_cache): Accept an additional argument JUST_FREE; if
6381 non-zero, only free the data buffer without restoring the cache
6382 contents. All callers changed.
6383
6384 * dispextern.h (bidi_unshelve_cache): Update prototype.
6385
6386 * xdisp.c (SAVE_IT, pos_visible_p, move_it_in_display_line_to)
6387 (move_it_in_display_line, move_it_to)
6388 (move_it_vertically_backward, move_it_by_lines): Replace the call
6389 to xfree to an equivalent call to bidi_unshelve_cache.
6390 (move_it_in_display_line_to): Fix logic of returning
412b6358 6391 MOVE_POS_MATCH_OR_ZV in the bidi case. (Bug#9224)
35928349 6392
e2e2423b
EZ
63932011-08-05 Eli Zaretskii <eliz@gnu.org>
6394
6395 * xdisp.c (set_cursor_from_row): Prefer the candidate glyph that
6396 came from a string character with a `cursor' property. (Bug#9229)
6397
ae9e757a
JD
63982011-08-04 Jan Djärv <jan.h.d@swipnet.se>
6399
6400 * Makefile.in (LIB_PTHREAD): New variable.
6401 (LIBES): Add LIB_PTHREAD (Bug#9216).
6402
6403 * alloc.c, emacs.c, gmalloc.c, gtkutil.c, keyboard.c, syssignal.h:
6404 Rename HAVE_GTK_AND_PTHREAD to HAVE_PTHREAD (Bug#9216).
6405
213bd7f2
AS
64062011-08-04 Andreas Schwab <schwab@linux-m68k.org>
6407
6b02f655 6408 * regex.c (re_iswctype): Remove some redundant boolean conversions.
213bd7f2 6409
99aaf75f
JD
64102011-08-04 Jan Djärv <jan.h.d@swipnet.se>
6411
6412 * xterm.c (x_find_topmost_parent): New function.
6413 (x_set_frame_alpha): Find topmost parent window with
6414 x_find_topmost_parent and set the property there also (bug#9181).
6415 (handle_one_xevent): Call x_set_frame_alpha on ReparentNotify.
6416
c74e9d86
PE
64172011-08-04 Paul Eggert <eggert@cs.ucla.edu>
6418
6419 * callproc.c (Fcall_process): Avoid vfork clobbering
6420 the local vars buffer, coding_systems, current_dir.
6421
640c8776
SM
64222011-08-03 Stefan Monnier <monnier@iro.umontreal.ca>
6423
6424 * keymap.c (Fmake_composed_keymap): Move to subr.el.
6425
f26d0e4c
PE
64262011-08-03 Paul Eggert <eggert@cs.ucla.edu>
6427
8a10d76c
PE
6428 * fontset.c (dump_fontset) [FONTSET_DEBUG]: Declare EXTERNALLY_VISIBLE
6429 so that it is not optimized away.
6430
f26d0e4c
PE
6431 * xdisp.c (compute_display_string_pos): Remove unused local.
6432
55439c61
EZ
64332011-08-02 Eli Zaretskii <eliz@gnu.org>
6434
6435 Fix slow cursor motion and scrolling in large buffers with
6436 selective display, like Org Mode buffers. (Bug#9218)
6437
6438 * dispextern.h (struct bidi_it): New member disp_prop_p.
6439
6440 * xdisp.c: Remove one-slot cache of display string positions.
6441 (compute_display_string_pos): Accept an additional argument
5e617bc2 6442 DISP_PROP_P; callers changed. Scan at most 5K characters forward
55439c61
EZ
6443 for a display string or property. If found, set DISP_PROP_P
6444 non-zero.
6445
6446 * bidi.c (bidi_fetch_char): Accept an additional argument
640c8776
SM
6447 DISP_PROP_P, and pass it to compute_display_string_pos.
6448 Only handle text covered by a display string if DISP_PROP_P is returned
55439c61
EZ
6449 non-zero. All callers of bidi_fetch_char changed.
6450
fb33fa43
SM
64512011-08-02 Stefan Monnier <monnier@iro.umontreal.ca>
6452
6453 * keymap.c (Fdefine_key): Fix Lisp_Object/int mixup; apply some CSE.
6454
b099e063
DM
64552010-12-03 Don March <don@ohspite.net>
6456
6457 * keymap.c (Fdefine_key): Fix non-prefix key error message when
6458 last character M-[char] is translated to ESC [char] (bug#7541).
6459
5cc7f7af
KH
64602011-08-02 Kenichi Handa <handa@m17n.org>
6461
d0fffa3f 6462 * lisp.h (uniprop_table): Extern it.
5cc7f7af
KH
6463
6464 * chartab.c (uniprop_table): Make it non-static.
6465
525d5e6e
EZ
64662011-08-01 Eli Zaretskii <eliz@gnu.org>
6467
6468 * xdisp.c (forward_to_next_line_start): Accept additional argument
6469 BIDI_IT_PREV, and store into it the state of the bidi iterator had
6470 on the newline.
6471 (reseat_at_next_visible_line_start): Use the bidi iterator state
6472 returned by forward_to_next_line_start to restore the state of
6473 it->bidi_it after backing up to previous newline. (Bug#9212)
6474
31011111
AS
64752011-07-30 Andreas Schwab <schwab@linux-m68k.org>
6476
6477 * regex.c (re_comp): Protoize.
6478 (re_exec): Fix return type.
6479 (regexec): Fix type of `ret'. (Bug#9203)
6480
476371c4
PE
64812011-07-28 Paul Eggert <eggert@cs.ucla.edu>
6482
e5d76069
PE
6483 * image.c (check_image_size): Use 1024x1024 if unknown frame (Bug#9189).
6484 This is needed if max-image-size is a floating-point number.
6485
9a79b20c
AS
64862011-07-28 Andreas Schwab <schwab@linux-m68k.org>
6487
6488 * print.c (print_object): Print empty symbol as ##.
6489
6490 * lread.c (read1): Read ## as empty symbol.
6491
d8c2fa78
AA
64922011-07-28 Alp Aker <alp.tekin.aker@gmail.com>
6493
6494 * nsfns.m (x_set_foreground_color): Set f->foreground_pixel when
6495 setting frame foreground color (Bug#9175).
6496 (x_set_background_color): Likewise.
6497
ffe57a7a
AA
6498 * nsmenu.m (-setText): Size tooltip dimensions precisely to
6499 contents (Bug#9176).
6500 (EmacsTooltip -init): Remove bezels and add shadows to
6501 tooltip windows.
6502
bf3492a5
AA
6503 * nsterm.m (ns_dumpglyphs_stretch): Avoid overwriting left fringe
6504 or scroll bar (Bug#8470).
6505
d55e9c53
AA
6506 * nsfont.m (nsfont_open): Remove assignment to voffset and
6507 unnecessary vars hshink, expand, hd, full_height, min_height.
6508 (nsfont_draw): Use s->ybase as baseline for glyph drawing (Bug#8913).
6509
6510 * nsterm.h (nsfont_info): Remove voffset field.
6511
d8c2fa78 65122011-07-28 Alp Aker <alp.tekin.aker@gmail.com>
4843aac3
AA
6513
6514 Implement strike-through and overline on NextStep (Bug#8863).
6515
6516 * nsfont.m (nsfont_open): Use underline position provided by font,
6517 instead of hard-coded value of 2.
6518 (nsfont_draw): Call ns_draw_text_decoration instead.
6519
6520 * nsterm.h: Add declaration for ns_draw_text_decoration.
6521
6522 * nsterm.m (ns_draw_text_decoration): New function for drawing
6523 underline, overline, and strike-through.
6524 (ns_dumpglyphs_image, ns_dumpglyphs_stretch): Add call to
6525 ns_draw_text_decoration. Change treatment of cursor drawing to
8d5ed899 6526 accommodate underlining, etc.
4843aac3 6527
4cc60b9b
EZ
65282011-07-28 Eli Zaretskii <eliz@gnu.org>
6529
bc7ece87
EZ
6530 * buffer.c (init_buffer_once): Set bidi-display-reordering to t by
6531 default.
4cc60b9b 6532
476371c4
PE
65332011-07-28 Paul Eggert <eggert@cs.ucla.edu>
6534
66606eea
PE
6535 * alloc.c (memory_full) [!SYNC_INPUT]: Fix signal-related race.
6536 Without this fix, if a signal arrives just after memory fills up,
6537 'malloc' might be invoked reentrantly.
6538
476371c4
PE
6539 * image.c (x_check_image_size) [!HAVE_X_WINDOWS]: Return 1.
6540 In other words, assume that every image size is allowed, on non-X
6541 hosts. This assumption is probably wrong, but it lets Emacs compile.
6542
f3fcc40d
AS
65432011-07-28 Andreas Schwab <schwab@linux-m68k.org>
6544
6545 * regex.c (re_iswctype): Convert return values to boolean.
6546
350c992f
EZ
65472011-07-28 Eli Zaretskii <eliz@fencepost.gnu.org>
6548
6549 * xdisp.c (compute_display_string_pos): Don't use cached display
6550 string position if the buffer had its restriction changed.
6551 (Bug#9184)
6552
5266b4bb
PE
65532011-07-28 Paul Eggert <eggert@cs.ucla.edu>
6554
6555 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork clobbering.
6556
2573a837 65572011-07-28 Paul Eggert <eggert@cs.ucla.edu>
ca4aa935 6558
41f55ccd 6559 Integer signedness and overflow and related fixes. (Bug#9079)
cf950e6b 6560
39e378da
PE
6561 * bidi.c: Integer size and overflow fixes.
6562 (bidi_cache_size, bidi_cache_idx, bidi_cache_last_idx)
6563 (bidi_cache_start, bidi_cache_fetch_state, bidi_cache_search)
6564 (bidi_cache_find_level_change, bidi_cache_ensure_space)
6565 (bidi_cache_iterator_state, bidi_cache_find, bidi_cache_start_stack)
6566 (bidi_find_other_level_edge):
6567 Use ptrdiff_t instead of EMACS_INT where either will do.
6568 This works better on 32-bit hosts configured --with-wide-int.
6569 (bidi_cache_ensure_space): Check for size-calculation overflow.
6570 Use % rather than repeated addition, for better worst-case speed.
6571 Don't set bidi_cache_size until after xrealloc returns, because it
6572 might not return.
6573 (bidi_dump_cached_states): Use ptrdiff_t, not int, to avoid overflow.
f0eb61e9
PE
6574 (bidi_cache_ensure_space): Also check that the bidi cache size
6575 does not exceed that of the largest Lisp string or buffer. See Eli
6576 Zaretskii in <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=9079#29>.
39e378da 6577
5e927815
PE
6578 * alloc.c (__malloc_size_t): Remove.
6579 All uses replaced by size_t. See Andreas Schwab's note
6580 <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=9079#8>.
6581
ca4aa935
PE
6582 * image.c: Improve checking for integer overflow.
6583 (check_image_size): Assume that f is nonnull, since
6584 it is always nonnull in practice. This is one less thing to
6585 worry about when checking for integer overflow later.
6586 (x_check_image_size): New function, which checks for integer
6587 overflow issues inside X.
6588 (x_create_x_image_and_pixmap, xbm_read_bitmap_data): Use it.
6589 This removes the need for a memory_full check.
6590 (xbm_image_p): Rewrite to avoid integer multiplication overflow.
6591 (Create_Pixmap_From_Bitmap_Data, xbm_load): Use x_check_image_size.
6592 (xbm_read_bitmap_data): Change locals back to 'int', since
6593 their values must fit in 'int'.
6594 (xpm_load_image, png_load, tiff_load):
6595 Invoke x_create_x_image_and_pixmap earlier,
6596 to avoid much needless work if the image is too large.
6597 (tiff_load): Treat overly large images as if
6598 x_create_x_image_and_pixmap failed, not as malloc failures.
6599 (gs_load): Use x_check_image_size.
6600
5f8f9cc2
PE
6601 * gtkutil.c: Omit integer casts.
6602 (xg_get_pixbuf_from_pixmap): Remove unnecessary cast.
6603 (xg_set_toolkit_scroll_bar_thumb): Rewrite to avoid need for cast.
6604
5adf60bc
PE
6605 * image.c (png_load): Don't assume height * row_bytes fits in 'int'.
6606
c8907a93
PE
6607 * xfaces.c (Fbitmap_spec_p): Fix integer overflow bug.
6608 Without this fix, (bitmap-spec-p '(34359738368 1 "x"))
6609 would wrongly return t on a 64-bit host.
6610
e3c25c68
PE
6611 * dispnew.c (init_display): Use *_RANGE_OVERFLOW macros.
6612 The plain *_OVERFLOW macros run afoul of GCC bug 49705
6613 <http://gcc.gnu.org/bugzilla/show_bug.cgi?id=49705>
6614 and therefore cause GCC to emit a bogus diagnostic in some cases.
6615
3f791afe
PE
6616 * image.c: Integer signedness and overflow and related fixes.
6617 This is not an exhaustive set of fixes, but it's time to
6618 record what I've got.
6619 (lookup_pixel_color, check_image_size): Remove redundant decls.
6620 (check_image_size): Don't assume that arbitrary EMACS_INT values
6621 fit in 'int', or that arbitrary 'double' values fit in 'int'.
6622 (x_alloc_image_color, x_create_x_image_and_pixmap, png_load)
6623 (tiff_load, imagemagick_load_image):
6624 Check for overflow in size calculations.
6625 (x_create_x_image_and_pixmap): Remove unnecessary test for
6626 xmalloc returning NULL; that can't happen.
6627 (xbm_read_bitmap_data): Don't assume sizes fit into 'int'.
6628 (xpm_color_bucket): Use better integer hashing function.
6629 (xpm_cache_color): Don't possibly over-allocate memory.
6630 (struct png_memory_storage, tiff_memory_source, tiff_seek_in_memory)
6631 (gif_memory_source):
6632 Use ptrdiff_t, not int or size_t, to record sizes.
6633 (png_load): Don't assume values greater than 2**31 fit in 'int'.
6634 (our_stdio_fill_input_buffer): Prefer ptrdiff_t to size_t when
6635 either works, as we prefer signed integers.
6636 (tiff_read_from_memory, tiff_write_from_memory):
6637 Return tsize_t, not size_t, since that's what the TIFF API wants.
6638 (tiff_read_from_memory): Don't fail simply because the read would
6639 go past EOF; instead, return a short read.
6640 (tiff_load): Omit no-longer-needed casts.
6641 (Fimagemagick_types): Don't assume size fits into 'int'.
6642
3cc5a532
PE
6643 Improve hashing quality when configured --with-wide-int.
6644 * fns.c (hash_string): New function, taken from sxhash_string.
6645 Do not discard information about ASCII character case; this
6646 discarding is no longer needed.
6647 (sxhash-string): Use it. Change sig to match it. Caller changed.
6648 * lisp.h: Declare it.
6649 * lread.c (hash_string): Remove, since we now use fns.c's version.
6650 The fns.c version returns a wider integer if --with-wide-int is
6651 specified, so this should help the quality of the hashing a bit.
6652
b312a492
PE
6653 * emacs.c: Integer overflow minor fix.
6654 (heap_bss_diff): Now uprintmax_t, not unsigned long. All used changed.
6655 Define only if GNU_LINUX.
6656 (main, Fdump_emacs): Set and use heap_bss_diff only if GNU_LINUX.
6657
dfd153ae
PE
6658 * dispnew.c: Integer signedness and overflow fixes.
6659 Remove unnecessary forward decls, that were a maintenance hassle.
6660 (history_tick): Now uprintmax_t, so it's more likely to avoid overflow.
6661 All uses changed.
6662 (adjust_glyph_matrix, realloc_glyph_pool, adjust_frame_message_buffer)
6663 (scrolling_window): Use ptrdiff_t, not int, for byte count.
6664 (prepare_desired_row, line_draw_cost):
6665 Use int, not unsigned, where either works.
6666 (save_current_matrix, restore_current_matrix):
6667 Use ptrdiff_t, not size_t, where either works.
6668 (init_display): Check for overflow more accurately, and without
6669 relying on undefined behavior.
6670
a81d11a3
PE
6671 * editfns.c (pWIDE, pWIDElen, signed_wide, unsigned_wide):
6672 Remove, replacing with the new symbols in lisp.h. All uses changed.
6673 * fileio.c (make_temp_name):
6674 * filelock.c (lock_file_1, lock_file):
6675 * xdisp.c (message_dolog):
6676 Don't assume PRIdMAX etc. works; this isn't portable to pre-C99 hosts.
6677 Use pMd etc. instead.
6678 * lisp.h (printmax_t, uprintmax_t, pMd, pMu): New types and macros,
6679 replacing the pWIDE etc. symbols removed from editfns.c.
6680
3300e6fd
PE
6681 * keyboard.h (num_input_events): Now uintmax_t.
6682 This is (very slightly) less likely to mess up due to wraparound.
6683 All uses changed.
6684
fd05c7e9
PE
6685 * buffer.c: Integer signedness fixes.
6686 (alloc_buffer_text, enlarge_buffer_text):
6687 Use ptrdiff_t rather than size_t when either will do, as we prefer
6688 signed integers.
6689
903fe15d
PE
6690 * alloc.c: Integer signedness and overflow fixes.
6691 Do not impose an arbitrary 32-bit limit on malloc sizes when debugging.
6692 (__malloc_size_t): Default to size_t, not to int.
6693 (pure_size, pure_bytes_used_before_overflow, stack_copy_size)
6694 (Fgarbage_collect, mark_object_loop_halt, mark_object):
6695 Prefer ptrdiff_t to size_t when either would do, as we prefer
6696 signed integers.
6697 (XMALLOC_OVERRUN_CHECK_OVERHEAD): New macro.
6698 (xmalloc_overrun_check_header, xmalloc_overrun_check_trailer):
6699 Now const. Initialize with values that are in range even if char
6700 is signed.
6701 (XMALLOC_PUT_SIZE, XMALLOC_GET_SIZE): Remove, replacing with ...
6702 (xmalloc_put_size, xmalloc_get_size): New functions. All uses changed.
6703 These functions do the right thing with sizes > 2**32.
6704 (check_depth): Now ptrdiff_t, not int.
6705 (overrun_check_malloc, overrun_check_realloc, overrun_check_free):
6706 Adjust to new way of storing sizes. Check for size overflow bugs
6707 in rest of code.
6708 (STRING_BYTES_MAX): Adjust to new overheads. The old code was
6709 slightly wrong anyway, as it missed one instance of
6710 XMALLOC_OVERRUN_CHECK_OVERHEAD.
6711 (refill_memory_reserve): Omit needless cast to size_t.
6712 (mark_object_loop_halt): Mark as externally visible.
6713
ac82cc6a
PE
6714 * xselect.c: Integer signedness and overflow fixes.
6715 (Fx_register_dnd_atom, x_handle_dnd_message):
6716 Use ptrdiff_t, not size_t, since we prefer signed.
6717 (Fx_register_dnd_atom): Check for ptrdiff_t (and size_t) overflow.
6718 * xterm.h (struct x_display_info): Use ptrdiff_t, not size_t, for
6719 x_dnd_atoms_size and x_dnd_atoms_length.
6720
c2d1e36d
PE
6721 * doprnt.c: Prefer signed to unsigned when either works.
6722 * eval.c (verror):
6723 * doprnt.c (doprnt):
6724 * lisp.h (doprnt):
6725 * xdisp.c (vmessage):
6726 Use ptrdiff_t, not size_t, when using or implementing doprnt,
6727 since the sizes cannot exceed ptrdiff_t bounds anyway, and we
6728 prefer signed arithmetic to avoid comparison confusion.
6729 * doprnt.c (doprnt): Avoid a "+ 1" that can't overflow,
6730 but is a bit tricky.
6731
0e926e56
PE
6732 Assume freestanding C89 headers, string.h, stdlib.h.
6733 * data.c, doprnt.c, floatfns.c, print.c:
6734 Include float.h unconditionally.
6735 * gmalloc.c: Assume C89-at-least behavior for preprocessor,
6736 limits.h, stddef.h, string.h. Use memset instead of 'flood'.
6737 * regex.c: Likewise for stddef.h, string.h.
6738 (ISASCII): Remove; can assume it returns 1 now. All uses removed.
6739 * s/aix4-2.h (HAVE_STRING_H): Remove obsolete undef.
6740 * s/ms-w32.h (HAVE_LIMITS_H, HAVE_STRING_H, HAVE_STDLIB_H)
6741 (STDC_HEADERS): Remove obsolete defines.
6742 * sysdep.c: Include limits.h unconditionally.
6743
9cfdb3ec
PE
6744 Assume support for memcmp, memcpy, memmove, memset.
6745 * lisp.h, sysdep.c (memcmp, memcpy, memmove, memset):
6746 * regex.c (memcmp, memcpy):
6747 Remove; we assume C89 now.
6748
6749 * gmalloc.c (memcpy, memset, memmove): Remove; we assume C89 now.
6750 (__malloc_safe_bcopy): Remove; no longer needed.
6751
cf950e6b 6752 * lisp.h (struct vectorlike_header, struct Lisp_Subr): Signed sizes.
6089c567
PE
6753 Use EMACS_INT, not EMACS_UINT, for sizes. The code works equally
6754 well either way, and we prefer signed to unsigned.
6755
dbf38e02
LMI
67562011-07-27 Lars Magne Ingebrigtsen <larsi@gnus.org>
6757
6758 * gnutls.c (emacs_gnutls_read): Don't message anything if the peer
6759 closes the connection while we're reading (bug#9182).
6760
d6f0886c 67612011-07-25 Jan Djärv <jan.h.d@swipnet.se>
24e0f6b1 6762
d6f0886c
JD
6763 * nsmenu.m (ns_popup_dialog): Add an "ok" button if no buttons
6764 are specified (Bug#9168).
24e0f6b1 6765
2eb1f9e6
PE
67662011-07-25 Paul Eggert <eggert@cs.ucla.edu>
6767
6768 * bidi.c (bidi_dump_cached_states): Fix printf format mismatch.
6769 Found by GCC static checking and --with-wide-int on a 32-bit host.
6770
22381272 67712011-07-25 Eli Zaretskii <eliz@gnu.org>
7daee910
EZ
6772
6773 * xdisp.c (compute_display_string_pos): Fix logic of caching
6774 previous display string position. Initialize cached_prev_pos to
6775 -1. Fixes slow-down at the beginning of a buffer.
6776
f25e39b4
EZ
67772011-07-24 Eli Zaretskii <eliz@gnu.org>
6778
6779 * xfaces.c (check_lface_attrs) [HAVE_WINDOW_SYSTEM]: Allow `nil'
6780 for attrs[LFACE_FONTSET_INDEX].
6781
04c4b52e
PE
67822011-07-23 Paul Eggert <eggert@cs.ucla.edu>
6783
6784 * xml.c (parse_region): Remove unused local
6785 that was recently introduced.
6786
c1734fbd
EZ
67872011-07-23 Eli Zaretskii <eliz@gnu.org>
6788
be18c5a5
EZ
6789 * xfns.c (unwind_create_frame) [GLYPH_DEBUG]: Adapt to changes in
6790 2008-02-22T17:42:09Z!monnier@iro.umontreal.ca.
6791
c1734fbd
EZ
6792 * xdisp.c (move_it_in_display_line_to): Record the best matching
6793 position for TO_CHARPOS while scanning the line, and restore it on
640c8776
SM
6794 exit if none of the characters scanned was an exact match.
6795 Fixes vertical-motion and pos-visible-in-window-p under bidi redisplay
a9269c18
EZ
6796 when exact match is impossible due to invisible text, and the
6797 lines are truncated.
6798
a258d627
JD
67992011-07-23 Jan Djärv <jan.h.d@swipnet.se>
6800
6801 * nsterm.m (initFrameFromEmacs): Set NSTitledWindowMask in styleMask
6802 for OSX >= 10.7.
6803
b6d5a689
EZ
68042011-07-22 Eli Zaretskii <eliz@gnu.org>
6805
0f74f785
EZ
6806 Fix a significant slow-down of cursor motion with C-n, C-p,
6807 C-f/C-b, and C-v/M-v that couldn't keep up with keyboard
6808 auto-repeat under bidi redisplay in fontified buffers.
b6d5a689 6809 * xdisp.c (compute_stop_pos_backwards): New function.
b6d5a689
EZ
6810 (next_element_from_buffer): Call compute_stop_pos_backwards to
6811 find a suitable prev_stop when we find ourselves before
0f74f785
EZ
6812 base_level_stop.
6813 (reseat): Don't look for prev_stop, as that could mean a very long
6814 run.
6815 <cached_disp_pos, cached_disp_buffer, cached_disp_modiff>
6816 <cached_disp_overlay_modiff>: Cache for last found display string
6817 position.
551918c1 6818 (compute_display_string_pos): Return the cached position if asked
0f74f785
EZ
6819 about the same buffer in the same area of character positions, and
6820 the buffer wasn't changed since the time the display string
6821 position was cached.
551918c1 6822
b2d0c91a
EZ
68232011-07-22 Eli Zaretskii <eliz@gnu.org>
6824
6825 * xdisp.c (rows_from_pos_range): Don't ignore glyphs whose object
6826 is an integer, which is important for empty lines. (Bug#9149)
6827
043604ee
CY
68282011-07-22 Chong Yidong <cyd@stupidchicken.com>
6829
6830 * frame.c (Fmodify_frame_parameters): In tty case, update the
6831 default face if necessary (Bug#4238).
6832
da4adb04
CY
68332011-07-21 Chong Yidong <cyd@stupidchicken.com>
6834
6835 * editfns.c (Fstring_to_char): No need to explain what a character
6836 is in the docstring (Bug#6576).
6837
9abd0532
LMI
68382011-07-20 Lars Magne Ingebrigtsen <larsi@gnus.org>
6839
6840 * xml.c (parse_region): Make sure we always return a tree.
6841
36881d16
HK
68422011-07-20 HAMANO Kiyoto <khiker.mail@gmail.com>
6843
6844 * xml.c (parse_region): If a document contains only comments,
6845 return that, too.
6846
1e98674d
LMI
68472011-07-20 Lars Magne Ingebrigtsen <larsi@gnus.org>
6848
6849 * xml.c (make_dom): Return comments, too.
6850
590bd467
PE
68512011-07-19 Paul Eggert <eggert@cs.ucla.edu>
6852
6853 Port to OpenBSD.
6854 See http://lists.gnu.org/archive/html/emacs-devel/2011-07/msg00688.html
6855 and the surrounding thread.
6856 * minibuf.c (read_minibuf_noninteractive): Rewrite to use getchar
6857 rather than fgets, and retry after EINTR. Otherwise, 'emacs
6858 --batch -f byte-compile-file' fails on OpenBSD if an inactivity
6859 timer goes off.
6860 * s/openbsd.h (BROKEN_SIGIO): Define.
6861 * unexelf.c (unexec) [__OpenBSD__]:
6862 Don't update the .mdebug section of the Alpha COFF symbol table.
6863
f41628b2
LMI
68642011-07-19 Lars Magne Ingebrigtsen <larsi@gnus.org>
6865
6866 * lread.c (syms_of_lread): Clarify when `lexical-binding' is used
6867 (bug#8460).
6868
b59b67c5
PE
68692011-07-18 Paul Eggert <eggert@cs.ucla.edu>
6870
15e3a074
PE
6871 * fileio.c (Fcopy_file) [!MSDOS]: Tighten created file's mask.
6872 This fixes some race conditions on the permissions of any newly
6873 created file.
6874
41bed37d
PE
6875 * alloc.c (valid_pointer_p): Use pipe, not open.
6876 This fixes some permissions issues when debugging.
6877
b59b67c5
PE
6878 * fileio.c (Fcopy_file): Adjust mode if fchown fails. (Bug#9002)
6879 If fchown fails to set both uid and gid, try to set just gid,
6880 as that is sometimes allowed. Adjust the file's mode to eliminate
6881 setuid or setgid bits that are inappropriate if fchown fails.
6882
925a6be7
SM
68832011-07-18 Stefan Monnier <monnier@iro.umontreal.ca>
6884
6885 * xdisp.c (next_element_from_string, next_element_from_buffer): Use EQ
6886 to compare Lisp_Objects.
6887 * gnutls.c (syms_of_gnutls): Rename Vgnutls_log_level to
6888 global_gnutls_log_level, don't mistake it for a Lisp_Object.
6889 (init_gnutls_functions, emacs_gnutls_handle_error): Fix up uses.
6890
52968808
AS
68912011-07-17 Andreas Schwab <schwab@linux-m68k.org>
6892
0a6a104b
AS
6893 * lread.c (read_integer): Unread even EOF character.
6894 (read1): Likewise. Properly record start position of symbol.
6895
52968808
AS
6896 * lread.c (read1): Read `#:' as empty uninterned symbol if no
6897 symbol character follows.
6898
9e381cdd
PE
68992011-07-17 Paul Eggert <eggert@cs.ucla.edu>
6900
6901 * fileio.c (Fcopy_file): Pacify gcc re fchown. (Bug#9002)
6902 This works around a problem with the previous change to Fcopy_file.
6903 Recent glibc declares fchown with __attribute__((warn_unused_result)),
6904 and without this change, GCC might complain about discarding
6905 fchown's return value.
6906
b5641435
JB
69072011-07-16 Juanma Barranquero <lekktu@gmail.com>
6908
6909 * makefile.w32-in (GLOBAL_SOURCES): Add gnutls.c (followup to bug#9059).
6910
a8031457
PE
69112011-07-16 Paul Eggert <eggert@cs.ucla.edu>
6912
6913 * fileio.c (Fcopy_file): Don't diagnose fchown failures. (Bug#9002)
6914
dd889327
LMI
69152011-07-16 Lars Magne Ingebrigtsen <larsi@gnus.org>
6916
750c33f7
LMI
6917 * gnutls.c (syms_of_gnutls): Define `gnutls-log-level' here, since
6918 it's used from the C level.
6919
dd889327
LMI
6920 * process.c: Use the same condition for POLL_FOR_INPUT in both
6921 keyboard.c and process.c (bug#1858).
6922
87e86684
LM
69232011-07-09 Lawrence Mitchell <wence@gmx.li>
6924
6925 * gnutls.c (Qgnutls_bootprop_min_prime_bits): New variable.
6926 (Fgnutls_boot): Use it.
6927
64348f40
AS
69282011-07-15 Andreas Schwab <schwab@linux-m68k.org>
6929
6930 * doc.c (Fsubstitute_command_keys): Revert last change.
6931
1d698799
LMI
69322011-07-15 Lars Magne Ingebrigtsen <larsi@gnus.org>
6933
f863868c
LMI
6934 * doc.c (Fsubstitute_command_keys): Clarify that \= really only
6935 quotes the next character, and doesn't affect other longer
6936 sequences (bug#8935).
6937
1d698799
LMI
6938 * lread.c (syms_of_lread): Clarify that is isn't only
6939 `eval-buffer' and `eval-defun' that's affected by
6940 `lexical-binding' (bug#8460).
6941
aa4b6df6
EZ
69422011-07-15 Eli Zaretskii <eliz@gnu.org>
6943
6944 * xdisp.c (move_it_in_display_line_to): Fix vertical motion with
6b02f655 6945 bidi redisplay when a line includes both an image and is truncated.
aa4b6df6 6946
5d856da6
PE
69472011-07-14 Paul Eggert <eggert@cs.ucla.edu>
6948
ad6042bb
PE
6949 Fix minor problems found by static checking.
6950 * bidi.c (bidi_cache_size): Now EMACS_INT, not size_t.
6951 (elsz): Now a signed constant, not a size_t var. We prefer signed
6952 types to unsigned, to avoid integer comparison confusion. Without
6953 this change, GCC 4.6.1 with -Wunsafe-loop-optimizations complains
6954 "cannot optimize loop, the loop counter may overflow", a symptom
6955 of the confusion.
f00bbb22 6956 * indent.c (Fvertical_motion): Mark locals as initialized.
5d856da6
PE
6957 * xdisp.c (reseat_to_string): Fix pointer signedness issue.
6958
6468f31c
LMI
69592011-07-14 Lars Magne Ingebrigtsen <larsi@gnus.org>
6960
49080b10
LMI
6961 * search.c (Fre_search_backward): Mention `case-fold-search' in
6962 all the re_search_* functions (bug#8138).
6963
6468f31c
LMI
6964 * keyboard.c (Fopen_dribble_file): Document when the file is
6965 closed (bug#8056).
6966
c965adc5
EZ
69672011-07-14 Eli Zaretskii <eliz@gnu.org>
6968
df9733bf
EZ
6969 * bidi.c (bidi_dump_cached_states): Fix format of displaying
6970 bidi_cache_idx.
6971
0bb23927
EZ
6972 Support bidi reordering of display and overlay strings.
6973 * xdisp.c (compute_display_string_pos)
6974 (compute_display_string_end): Accept additional argument STRING.
6975 (init_iterator, reseat_1): Initialize bidi_it->string.s to NULL.
6976 (reseat_to_string): Initialize bidi_it->string.s and
6977 bidi_it->string.schars.
6978 (Fcurrent_bidi_paragraph_direction): Initialize itb.string.s to
640c8776
SM
6979 NULL (avoids a crash in bidi_paragraph_init).
6980 Initialize itb.string.lstring.
0bb23927
EZ
6981 (init_iterator): Call bidi_init_it only of a valid
6982 buffer position was specified. Initialize paragraph_embedding to
6983 L2R.
6984 (reseat_to_string): Initialize the bidi iterator.
6985 (display_string): If we need to ignore text properties of
6986 LISP_STRING, set IT->stop_charpos to IT->end_charpos. (The
6987 original value of -1 will not work with bidi.)
6988 (compute_display_string_pos): First arg is now struct
6989 `text_pos *'; all callers changed. Support display properties on
6990 Lisp strings.
6991 (compute_display_string_end): Support display properties on Lisp
6992 strings.
6993 (init_iterator, reseat_1, reseat_to_string): Initialize the
6994 string.bufpos member to 0 (zero, for compatibility with IT_CHARPOS
6995 when iterating on a string not from display properties).
640c8776
SM
6996 (compute_display_string_pos, compute_display_string_end):
6997 Fix calculation of the object to scan. Fixes an error when using
0bb23927
EZ
6998 arrow keys.
6999 (next_element_from_buffer): Don't abort when IT_CHARPOS is before
640c8776
SM
7000 base_level_stop; instead, set base_level_stop to BEGV.
7001 Fixes crashes in vertical-motion.
0bb23927
EZ
7002 (next_element_from_buffer): Improve commentary for when
7003 the iterator is before prev_stop.
7004 (init_iterator): Initialize bidi_p from the default value of
7005 bidi-display-reordering, not from buffer-local value. Use the
7006 buffer-local value only if initializing for buffer iteration.
7007 (handle_invisible_prop): Support invisible properties on strings
7008 that are being bidi-reordered.
7009 (set_iterator_to_next): Support bidi reordering of C strings and
7010 Lisp strings.
7011 (next_element_from_string): Support bidi reordering of Lisp
7012 strings.
7013 (handle_stop_backwards): Support Lisp strings as well.
640c8776
SM
7014 (display_string): Support display of R2L glyph rows.
7015 Use IT_STRING_CHARPOS when displaying from a Lisp string.
0bb23927
EZ
7016 (init_iterator): Don't initialize it->bidi_p for strings
7017 here.
7018 (reseat_to_string): Initialize it->bidi_p for strings here.
7019 (next_element_from_string, next_element_from_c_string)
7020 (next_element_from_buffer): Add xassert's for correspondence
7021 between IT's object being iterated and it->bidi_it.string
7022 structure.
7023 (face_before_or_after_it_pos): Support bidi iteration.
7024 (next_element_from_c_string): Handle the case of the first string
7025 character that is not the first one in the visual order.
7026 (get_visually_first_element): New function, refactored from common
7027 parts of next_element_from_buffer, next_element_from_string, and
7028 next_element_from_c_string.
7029 (tool_bar_lines_needed, redisplay_tool_bar)
7030 (display_menu_bar): Force left-to-right direction. Add a FIXME
7031 comment for making that be controlled by a user option.
7032 (push_it, pop_it): Save and restore the state of the
7033 bidi iterator. Save and restore the bidi_p flag.
7034 (pop_it): Iterate out of display property for string iteration as
7035 well.
7036 (iterate_out_of_display_property): Support iteration over strings.
7037 (handle_single_display_spec): Set up it->bidi_it for iteration
7038 over a display string, and call bidi_init_it.
7039 (handle_single_display_spec, next_overlay_string)
7040 (get_overlay_strings_1, push_display_prop): Set up the bidi
7041 iterator for displaying display or overlay strings.
7042 (forward_to_next_line_start): Don't use the shortcut if
7043 bidi-iterating.
7044 (back_to_previous_visible_line_start): If handle_display_prop
7045 pushed the iterator stack, restore the internal state of the bidi
7046 iterator by calling bidi_pop_it same number of times.
7047 (reseat_at_next_visible_line_start): If ON_NEWLINE_P is non-zero,
7048 and we are bidi-iterating, don't decrement the iterator position;
7049 instead, set the first_elt flag in the bidi iterator, to produce
7050 the same effect.
7051 (reseat_1): Remove redundant setting of string_from_display_prop_p.
7052 (push_display_prop): xassert that we are iterating a buffer.
7053 (push_it, pop_it): Save and restore paragraph_embedding member.
7054 (handle_single_display_spec, next_overlay_string)
7055 (get_overlay_strings_1, reseat_1, reseat_to_string)
7056 (push_display_prop): Set up the `unibyte' member of bidi_it.string
7057 correctly. Don't assume unibyte strings are not bidi-reordered.
7058 (compute_display_string_pos)
7059 (compute_display_string_end): Fix handling the case of C string.
7060 (push_it, pop_it): Save and restore from_disp_prop_p.
7061 (handle_single_display_spec, push_display_prop): Set the
7062 from_disp_prop_p flag.
7063 (get_overlay_strings_1): Reset the from_disp_prop_p flag.
7064 (pop_it): Call iterate_out_of_display_property only if we are
7065 popping after iteration over a string that came from a display
7066 property. Fix a typo in popping stretch info. Add an assertion
7067 for verifying that the iterator position is in sync with the bidi
7068 iterator.
7069 (handle_single_display_spec, get_overlay_strings_1)
7070 (push_display_prop): Fix initialization of paragraph direction for
7071 string when that of the parent object is not yet determined.
7072 (reseat_1): Call bidi_init_it to resync the bidi
7073 iterator with IT's position. (Bug#7616)
7074 (find_row_edges): If ROW->start.pos gives position
7075 smaller than min_pos, use it as ROW->minpos. (Bug#7616)
7076 (handle_stop, back_to_previous_visible_line_start, reseat_1):
7077 Reset the from_disp_prop_p flag.
7078 (SAVE_IT, RESTORE_IT): New macros.
7079 (pos_visible_p, face_before_or_after_it_pos)
7080 (back_to_previous_visible_line_start)
7081 (move_it_in_display_line_to, move_it_in_display_line)
7082 (move_it_to, move_it_vertically_backward, move_it_by_lines)
7083 (try_scrolling, redisplay_window, display_line): Use them when
7084 saving a temporary copy of the iterator and restoring it back.
7085 (back_to_previous_visible_line_start, reseat_1)
7086 (init_iterator): Empty the bidi cache "stack".
7087 (move_it_in_display_line_to): If iterator ended up at
7088 EOL, but we never saw any buffer positions smaller than
7089 to_charpos, return MOVE_POS_MATCH_OR_ZV. Fixes vertical cursor
7090 motion in bidi-reordered lines.
7091 (move_it_in_display_line_to): Record prev_method and prev_pos
7092 immediately before the call to set_iterator_to_next. Fixes cursor
7093 motion in bidi-reordered lines with stretch glyphs and strings
7094 displayed in margins. (Bug#8133) (Bug#8867)
7095 Return MOVE_POS_MATCH_OR_ZV only if iterator position is past
7096 TO_CHARPOS.
640c8776
SM
7097 (pos_visible_p): Support positions in bidi-reordered lines.
7098 Save and restore bidi cache.
0bb23927
EZ
7099
7100 * bidi.c (bidi_level_of_next_char): clen should be EMACS_NT, not int.
7101 (bidi_paragraph_info): Delete unused struct.
7102 (bidi_cache_idx, bidi_cache_last_idx): Declare EMACS_INT.
7103 (bidi_cache_start): New variable.
7104 (bidi_cache_reset): Reset bidi_cache_idx to bidi_cache_start, not
7105 to zero.
7106 (bidi_cache_fetch_state, bidi_cache_search)
7107 (bidi_cache_find_level_change, bidi_cache_iterator_state)
7108 (bidi_cache_find, bidi_peek_at_next_level)
7109 (bidi_level_of_next_char, bidi_find_other_level_edge)
7110 (bidi_move_to_visually_next): Compare cache index with
7111 bidi_cache_start rather than with zero.
7112 (bidi_fetch_char): Accept new argument STRING; all callers
7113 changed. Support iteration over a string. Support strings with
7114 display properties. Support unibyte strings. Fix the type of
7115 `len' according to what STRING_CHAR_AND_LENGTH expects.
7116 (bidi_paragraph_init, bidi_resolve_explicit_1)
7117 (bidi_resolve_explicit, bidi_resolve_weak)
640c8776
SM
7118 (bidi_level_of_next_char, bidi_move_to_visually_next):
7119 Support iteration over a string.
0bb23927
EZ
7120 (bidi_set_sor_type, bidi_resolve_explicit_1)
7121 (bidi_resolve_explicit, bidi_type_of_next_char): ignore_bn_limit
7122 can now be zero (for strings); special values 0 and -1 were
7123 changed to -1 and -2, respectively.
7124 (bidi_char_at_pos): New function.
7125 (bidi_paragraph_init, bidi_resolve_explicit, bidi_resolve_weak):
7126 Call it instead of FETCH_MULTIBYTE_CHAR.
7127 (bidi_move_to_visually_next): Abort if charpos or bytepos were not
7128 initialized to valid values.
7129 (bidi_init_it): Don't initialize charpos and bytepos with invalid
7130 values.
7131 (bidi_level_of_next_char): Allow the sentinel "position" to pass
7132 the test for valid cached positions. Fix the logic for looking up
7133 the sentinel state in the cache. GCPRO the Lisp string we are
7134 iterating.
7135 (bidi_push_it, bidi_pop_it): New functions.
7136 (bidi_initialize): Initialize the bidi cache start stack pointer.
7137 (bidi_cache_ensure_space): New function, refactored from part of
7138 bidi_cache_iterator_state. Don't assume the required size is just
7139 one BIDI_CACHE_CHUNK away.
7140 (bidi_cache_start_stack, bidi_push_it): Use IT_STACK_SIZE.
7141 (bidi_count_bytes, bidi_char_at_pos): New functions.
7142 (bidi_cache_search): Don't assume bidi_cache_last_idx is
7143 always valid if bidi_cache_idx is valid.
7144 (bidi_cache_find_level_change): xassert that bidi_cache_last_idx
7145 is valid if it's going to be used.
7146 (bidi_shelve_cache, bidi_unshelve_cache): New functions.
7147 (bidi_cache_fetch_state, bidi_cache_search)
c965adc5
EZ
7148 (bidi_cache_find_level_change, bidi_cache_ensure_space)
7149 (bidi_cache_iterator_state, bidi_cache_find)
640c8776
SM
7150 (bidi_find_other_level_edge, bidi_cache_start_stack):
7151 All variables related to cache indices are now EMACS_INT.
c965adc5 7152
0bb23927
EZ
7153 * dispextern.h (struct bidi_string_data): New structure.
7154 (struct bidi_it): New member `string'. Make flag members be 1-bit
7155 fields, and put them last in the struct.
640c8776
SM
7156 (compute_display_string_pos, compute_display_string_end):
7157 Update prototypes.
0bb23927
EZ
7158 (bidi_push_it, bidi_pop_it): Add prototypes.
7159 (struct iterator_stack_entry): New members bidi_p,
7160 paragraph_embedding, and from_disp_prop_p.
7161 (struct it): Member bidi_p is now a bit field 1 bit wide.
640c8776
SM
7162 (bidi_shelve_cache, bidi_unshelve_cache):
7163 Declare prototypes.
0bb23927
EZ
7164
7165 * .gdbinit (xvectype, xvector, xcompiled, xchartable, xboolvector)
7166 (xpr, xfont, xbacktrace): Use "header.size" when accessing vectors
7167 and vector-like objects.
7168
7169 * dispnew.c (buffer_posn_from_coords): Save and restore the bidi
7170 cache around display iteration.
7171
7172 * window.c (Fwindow_end, window_scroll_pixel_based)
7173 (displayed_window_lines, Frecenter): Save and restore the bidi
7174 cache around display iteration.
7175
3bbd2265
LMI
71762011-07-14 Lars Magne Ingebrigtsen <larsi@gnus.org>
7177
7178 * editfns.c (Fdelete_region): Clarify the use of the named
7179 parameters (bug#6788).
7180
adc47434
MR
71812011-07-14 Martin Rudalics <rudalics@gmx.at>
7182
7183 * indent.c (Fvertical_motion): Set and restore w->pointm when
7184 saving and restoring the window's buffer (Bug#9006).
7185
837c31f8
LMI
71862011-07-13 Lars Magne Ingebrigtsen <larsi@gnus.org>
7187
7188 * editfns.c (Fstring_to_char): Clarify just what is returned
7189 (bug#6576). Text by Eli Zaretskii.
7190
ac389d0c
JB
71912011-07-13 Juanma Barranquero <lekktu@gmail.com>
7192
7193 * gnutls.c (init_gnutls_functions): Honor gnutls_log_level (bug#9059).
7194
0be0ce47
EZ
71952011-07-13 Eli Zaretskii <eliz@gnu.org>
7196
7197 * buffer.c (mmap_find): Fix a typo.
7198
cd18e7e3
JB
71992011-07-13 Johan Bockgård <bojohan@gnu.org>
7200
7201 Fix execution of x selection hooks.
7202 * xselect.c (Qx_lost_selection_functions)
7203 (Qx_sent_selection_functions): New vars.
7204 (syms_of_xselect): DEFSYM them.
7205 (x_handle_selection_request): Pass Qx_sent_selection_functions
7206 rather than Vx_sent_selection_functions to Frun_hook_with_args.
7207 (x_handle_selection_clear,x_clear_frame_selections):
7208 Pass Qx_lost_selection_functions rather than
7209 Vx_lost_selection_functions to Frun_hook_with_args.
7210
47ea7f44
PE
72112011-07-13 Paul Eggert <eggert@cs.ucla.edu>
7212
ac389d0c 7213 * buffer.c (Fget_buffer_create): Initialize inhibit_shrinking.
2941c447
PE
7214 The old code sometimes used this field without initializing it.
7215
47ea7f44
PE
7216 * alloc.c (gc_sweep): Don't read past end of array.
7217 In theory, the old code could also have corrupted Emacs internals,
7218 though it'd be very unlikely.
7219
bc985c87
AS
72202011-07-12 Andreas Schwab <schwab@linux-m68k.org>
7221
7222 * character.c (Fcharacterp): Don't advertise optional ignored
ac389d0c 7223 argument. (Bug#4026)
bc985c87 7224
0cf34688
LMI
72252011-07-12 Lars Magne Ingebrigtsen <larsi@gnus.org>
7226
b3dadd76
LMI
7227 * keymap.c (syms_of_keymap): Clarify that "modifier" is "modifier
7228 key" (bug#4257).
7229
0cf34688
LMI
7230 * window.c (Fset_window_start): Doc fix (bug#4199).
7231 (Fset_window_hscroll): Ditto.
7232
270768cd
PE
72332011-07-12 Paul Eggert <eggert@cs.ucla.edu>
7234
077e3dda 7235 Fix minor new problems caught by GCC 4.6.1.
270768cd 7236 * term.c (init_tty): Remove unused local.
490011a6 7237 * xsettings.c (store_monospaced_changed): Define this function only
077e3dda 7238 if (defined HAVE_GSETTINGS || defined HAVE_GCONF), as it's
490011a6 7239 not used otherwise.
270768cd 7240
b1f58454
CY
72412011-07-12 Chong Yidong <cyd@stupidchicken.com>
7242
7243 * xdisp.c (Vresize_mini_windows): Minor doc fix (Bug#3300).
7244
22b9578d
LMI
72452011-07-11 Lars Magne Ingebrigtsen <larsi@gnus.org>
7246
6e70ab07
LMI
7247 * xdisp.c (syms_of_xdisp): Make it explicit that the mini-windows
7248 are the mini-buffer and the echo area (bug#3320).
7249
22b9578d
LMI
7250 * term.c (init_tty): Remove support for supdup, c10 and perq
7251 terminals, which are no longer supported (bug#1482).
7252
8974cc9f
JB
72532011-07-10 Johan Bockgård <bojohan@gnu.org>
7254
7255 * xdisp.c (Ftool_bar_lines_needed): Fix WINDOWP check.
7256
a560d974
JD
72572011-07-10 Jan Djärv <jan.h.d@swipnet.se>
7258
7259 * xmenu.c (menu_highlight_callback): Only pass frame to show_help_event
7260 for non-popups (Bug#3642).
7261
1dae0f0a
AS
72622011-07-10 Andreas Schwab <schwab@linux-m68k.org>
7263
268c2c36 7264 * alloc.c (reset_malloc_hooks): Protoize.
1dae0f0a 7265 * buffer.c (mmap_init, mmap_find, mmap_free_1, mmap_enlarge)
268c2c36
AS
7266 (mmap_set_vars, mmap_alloc, mmap_free, mmap_realloc): Likewise.
7267 * cm.c (losecursor): Likewise.
1dae0f0a
AS
7268 * data.c (fmod): Likewise.
7269 * dispnew.c (swap_glyphs_in_rows): Likewise.
7270 * emacs.c (memory_warning_signal): Likewise.
7271 * floatfns.c (float_error): Likewise.
7272 * font.c (check_gstring, check_otf_features, otf_tag_symbol)
7273 (otf_open, font_otf_capability, generate_otf_features)
7274 (font_otf_DeviceTable, font_otf_ValueRecord, font_otf_Anchor):
7275 Likewise.
7276 * image.c (pbm_read_file): Likewise.
7277 * indent.c (string_display_width): Likewise.
7278 * intervals.c (check_for_interval, search_for_interval)
7279 (inc_interval_count, count_intervals, root_interval)
7280 (adjust_intervals_for_insertion, make_new_interval): Likewise.
7281 * lread.c (defalias): Likewise.
268c2c36 7282 * ralloc.c (r_alloc_check): Likewise.
1dae0f0a
AS
7283 * regex.c (set_image_of_range_1, set_image_of_range)
7284 (regex_grow_registers): Likewise.
7285 * sysdep.c (strerror): Likewise.
7286 * termcap.c (valid_filename_p, tprint, main): Likewise.
7287 * tparam.c (main): Likewise.
7288 * unexhp9k800.c (run_time_remap, save_data_space)
7289 (update_file_ptrs, read_header, write_header, calculate_checksum)
7290 (copy_file, copy_rest, display_header): Likewise.
7291 * widget.c (mark_shell_size_user_specified, create_frame_gcs):
7292 Likewise.
7293 * xdisp.c (check_it): Likewise.
7294 * xfaces.c (register_color, unregister_color, unregister_colors):
7295 Likewise.
7296 * xfns.c (print_fontset_result): Likewise.
7297 * xrdb.c (member, fatal, main): Likewise.
7298
99033785
PE
72992011-07-10 Paul Eggert <eggert@cs.ucla.edu>
7300
7301 Fix minor problems found by static checking (Bug#9031).
7302 * chartab.c (char_table_set_range, map_sub_char_table):
7303 Remove unused locals.
7304 (uniprop_table): Now static.
7305 * composite.c (_work_char): Remove unused static var.
7306
9cb2ac56
JB
73072011-07-09 Juanma Barranquero <lekktu@gmail.com>
7308
7309 * chartab.c (uniprop_table_uncompress): Remove unused local variable.
7310
f25661f0
JD
73112011-07-09 Jan Djärv <jan.h.d@swipnet.se>
7312
7313 * gtkutil.c (qttip_cb): Remove code without function.
7314
8278c4fe
EZ
73152011-07-09 Eli Zaretskii <eliz@gnu.org>
7316
7317 * w32.c (pthread_sigmask): New stub.
7318
1692ae2d 73192011-07-08 Paul Eggert <eggert@cs.ucla.edu>
123403e4 7320
8a6ebd58 7321 Use pthread_sigmask, not sigprocmask (Bug#9010).
123403e4
PE
7322 sigprocmask is portable only for single-threaded applications, and
7323 Emacs can be multi-threaded when it uses GTK.
1301ac26
PE
7324 * Makefile.in (LIB_PTHREAD_SIGMASK): New macro.
7325 (LIBES): Use it.
7326 * callproc.c (Fcall_process):
7327 * process.c (create_process):
7328 * sysdep.c (sys_sigblock, sys_sigunblock, sys_sigsetmask):
7329 Use pthread_sigmask, not sigprocmask.
123403e4 7330
1b854618
JD
73312011-07-08 Jan Djärv <jan.h.d@swipnet.se>
7332
7333 * gtkutil.c (qttip_cb): Set line wrap to FALSE for tooltip widget.
7334 (xg_prepare_tooltip): Revert text in x->ttip_lbl, margins was
7335 wrong (Bug#8591).
7336
3fe4b549
JD
73372011-07-08 Jan Djärv <jan.h.d@swipnet.se>
7338
0ce7e563
JD
7339 * gtkutil.c (xg_prepare_tooltip): Fix indentation and comment.
7340 Put text in x->ttip_lbl instead of gtk_tooltip_set_text (Bug#8591).
7341 (xg_hide_tooltip): Fix comment.
7342
3fe4b549
JD
7343 * nsterm.m (initFrameFromEmacs): Don't use ns_return_types
7344 in registerServicesMenuSendTypes.
7345 (validRequestorForSendType): Don't check ns_return_types.
7346
7347 * nsfns.m (Fx_open_connection): Put NSStringPboardType into
7348 ns_return_type.
7349
5df75e47
JR
73502011-07-08 Jason Rumney <jasonr@gnu.org>
7351
22610910
JR
7352 * w32term.c (x_make_frame_visible): Use SH_SHOWNORMAL rather than
7353 SH_SHOW for hidden windows (Bug#5482).
7354
5df75e47
JR
7355 * w32fns.c (w32_wnd_proc) [WM_TIMER, WM_SET_CURSOR]: Avoid using
7356 frame struct members of non-existent frames (Bug#6284).
7357
699c10bd
JD
73582011-07-08 Jan Djärv <jan.h.d@swipnet.se>
7359
4393663b
JD
7360 * nsterm.m (keyDown): Call to wantsToDelayTextChangeNotifications and
7361 variable firstTime not needed on OSX >= 10.6.
7362 (setPosition): setFloatValue:knobProportion: is deprecated on OSX
7363 >= 10.5. Use setKnobProportion, setDoubleValue.
7364
7365 * nsterm.h (MAC_OS_X_VERSION_10_3, MAC_OS_X_VERSION_10_4)
7366 (MAC_OS_X_VERSION_10_5): Define if not defined.
7367 (EmacsView, EmacsTooltip): Implements NSWindowDelegate on OSX >= 10.6.
7368 (EmacsMenu): Implements NSMenuDelegate on OSX >= 10.6.
7369 (EmacsToolbar): Implements NSToolbarDelegate on OSX >= 10.6.
7370
7371 * nsselect.m (ns_string_from_pasteboard): Don't use deprecated methods
7372 cString and lossyCString on OSX >= 10.4
7373
58179cce 7374 * nsmenu.m (fillWithWidgetValue): Don't use deprecated method
4393663b
JD
7375 sizeToFit on OSX >= 10.2.
7376
7377 * nsimage.m (allocInitFromFile): Don't use deprecated method
7378 bestRepresentationForDevice on OSX >= 10.6.
7379
7380 * nsfns.m (check_ns_display_info): Cast to long and use %ld in error
7381 to avoid warning.
7382
7383 * emacs.c: Declare unexec_init_emacs_zone.
7384
a63e0781
JD
7385 * nsgui.h: Fix compiler warning about gnulib redefining verify.
7386
699c10bd
JD
7387 * nsselect.m (ns_get_local_selection): Change to extern (Bug#8842).
7388
7389 * nsmenu.m (ns_update_menubar): Remove useless setDelegate call
7390 on svcsMenu (Bug#8842).
7391
7392 * nsfns.m (Fx_open_connection): Remove NSStringPboardType from
7393 ns_return_types.
7394 (Fns_list_services): Just return Qnil on 10.6, code not working there.
7395
7396 * nsterm.m (QUTF8_STRING): Declare.
7397 (initFrameFromEmacs): Call registerServicesMenuSendTypes.
7398 (validRequestorForSendType): Return type is (id).
7399 Change indexOfObjectIdenticalTo to indexOfObject.
7400 Check if we have local selection before returning self (Bug#8842).
7401 (writeSelectionToPasteboard): Put local selection into paste board
7402 if we have a local selection (Bug#8842).
7403 (syms_of_nsterm): DEFSYM QUTF8_STRING.
7404
7405 * nsterm.h (MAC_OS_X_VERSION_10_6): Define here instead of nsterm.m.
7406 (ns_get_local_selection): Declare.
7407
54e10184
LMI
74082011-07-07 Lars Magne Ingebrigtsen <larsi@gnus.org>
7409
9888ff71
LMI
7410 * keymap.c (describe_map_tree): Don't insert a double newline at
7411 the end of the buffer (bug#1169) and return whether we inserted
7412 something.
7413
54e10184
LMI
7414 * callint.c (Fcall_interactively): Change "reading args" to
7415 "providing args" to try to clarify what it does (bug#1010).
7416
15fa4783
KH
74172011-07-07 Kenichi Handa <handa@m17n.org>
7418
7419 * composite.c (composition_compute_stop_pos): Ignore a static
7420 composition starting before CHARPOS (Bug#8915).
7421
7422 * xdisp.c (handle_composition_prop): Likewise.
7423
a8815b00
EZ
74242011-07-07 Eli Zaretskii <eliz@gnu.org>
7425
7426 * term.c (produce_glyphs) <xassert>: Allow IT_GLYPHLESS in it->what.
7427 (Bug#9015)
7428
ef7b981d 74292011-07-07 Kenichi Handa <handa@m17n.org>
c805dec0
KH
7430
7431 * character.h (unicode_category_t): New enum type.
7432
7433 * chartab.c (uniprop_decoder_t, uniprop_encoder_t): New types.
7434 (Qchar_code_property_table): New variable.
7435 (UNIPROP_TABLE_P, UNIPROP_GET_DECODER)
7436 (UNIPROP_COMPRESSED_FORM_P): New macros.
7437 (char_table_ascii): Uncompress the compressed values.
7438 (sub_char_table_ref): New arg is_uniprop. Callers changed.
7439 Uncompress the compressed values.
ac389d0c 7440 (sub_char_table_ref_and_range): Likewise.
c805dec0
KH
7441 (char_table_ref_and_range): Uncompress the compressed values.
7442 (sub_char_table_set): New arg is_uniprop. Callers changed.
7443 Uncompress the compressed values.
7444 (sub_char_table_set_range): Args changed. Callers changed.
7445 (char_table_set_range): Adjuted for the above change.
7446 (map_sub_char_table): Delete args default_val and parent. Add arg
7447 top. Give decoded values to a Lisp function.
640c8776 7448 (map_char_table): Adjust for the above change. Give decoded
c805dec0
KH
7449 values to a Lisp function. Gcpro more variables.
7450 (uniprop_table_uncompress)
7451 (uniprop_decode_value_run_length): New functions.
7452 (uniprop_decoder, uniprop_decoder_count): New variables.
7453 (uniprop_get_decoder, uniprop_encode_value_character)
7454 (uniprop_encode_value_run_length, uniprop_encode_value_numeric):
7455 New functions.
7456 (uniprop_encoder, uniprop_encoder_count): New variables.
7457 (uniprop_get_encoder, uniprop_table)
7458 (Funicode_property_table_internal, Fget_unicode_property_internal)
7459 (Fput_unicode_property_internal): New functions.
7460 (syms_of_chartab): DEFSYM Qchar_code_property_table, defsubr
7461 Sunicode_property_table_internal, Sget_unicode_property_internal,
5e617bc2 7462 and Sput_unicode_property_internal. Defvar_lisp
c805dec0
KH
7463 char-code-property-alist.
7464
640c8776 7465 * composite.c (CHAR_COMPOSABLE_P): Adjust for the change of
c805dec0
KH
7466 Vunicode_category_table.
7467
640c8776 7468 * font.c (font_range): Adjust for the change of
c805dec0
KH
7469 Vunicode_category_table.
7470
76b397fb
DN
74712011-07-07 Dan Nicolaescu <dann@ics.uci.edu>
7472
7473 * m/iris4d.h: Remove file, move contents ...
7474 * s/irix6-5.h: ... here.
7475
22b4128e
PE
74762011-07-06 Paul Eggert <eggert@cs.ucla.edu>
7477
7478 Remove unportable assumption about struct layout (Bug#8884).
8a5c77bb
PE
7479 * alloc.c (mark_buffer):
7480 * buffer.c (reset_buffer_local_variables, Fbuffer_local_variables)
7481 (clone_per_buffer_values): Don't assume that
22b4128e
PE
7482 sizeof (struct buffer) is a multiple of sizeof (Lisp_Object).
7483 This isn't true in general, and it's particularly not true
7484 if Emacs is configured with --with-wide-int.
7485 * buffer.h (FIRST_FIELD_PER_BUFFER, LAST_FIELD_PER_BUFFER):
7486 New macros, used in the buffer.c change.
7487
869795d6
JD
74882011-07-05 Jan Djärv <jan.h.d@swipnet.se>
7489
7490 * xsettings.c: Use both GConf and GSettings if both are available.
7491 (store_config_changed_event): Add comment.
7492 (dpyinfo_valid, store_font_name_changed, map_tool_bar_style)
7493 (store_tool_bar_style_changed): New functions.
5e617bc2 7494 (store_monospaced_changed): Add comment. Call dpyinfo_valid.
869795d6
JD
7495 (struct xsettings): Move font inside HAVE_XFT.
7496 (GSETTINGS_TOOL_BAR_STYLE, GSETTINGS_FONT_NAME): New defines.
640c8776 7497 (GSETTINGS_MONO_FONT): Rename from SYSTEM_MONO_FONT.
869795d6 7498 Move inside HAVE_XFT.
640c8776 7499 (something_changed_gsettingsCB): Rename from something_changedCB.
869795d6
JD
7500 Check for changes in GSETTINGS_TOOL_BAR_STYLE and GSETTINGS_FONT_NAME
7501 also.
7502 (GCONF_TOOL_BAR_STYLE, GCONF_FONT_NAME): New defines.
5e617bc2 7503 (GCONF_MONO_FONT): Rename from SYSTEM_MONO_FONT. Move inside HAVE_XFT.
640c8776 7504 (something_changed_gconfCB): Rename from something_changedCB.
869795d6
JD
7505 Check for changes in GCONF_TOOL_BAR_STYLE and GCONF_FONT_NAME also.
7506 (parse_settings): Move check for font inside HAVE_XFT.
7507 (read_settings, apply_xft_settings): Add comment.
7508 (read_and_apply_settings): Add comment. Call map_tool_bar_style and
7509 store_tool_bar_style_changed. Move check for font inside HAVE_XFT and
7510 call store_font_name_changed.
7511 (xft_settings_event): Add comment.
7512 (init_gsettings): Add comment. Get values for GSETTINGS_TOOL_BAR_STYLE
7513 and GSETTINGS_FONT_NAME. Move check for fonts within HAVE_XFT.
7514 (init_gconf): Add comment. Get values for GCONF_TOOL_BAR_STYLE
7515 and GCONF_FONT_NAME. Move check for fonts within HAVE_XFT.
7516 (xsettings_initialize): Call init_gsettings last.
640c8776
SM
7517 (xsettings_get_system_font, xsettings_get_system_normal_font):
7518 Add comment.
869795d6 7519
d8ed26bd
PE
75202011-07-05 Paul Eggert <eggert@cs.ucla.edu>
7521
7522 Random fixes. E.g., (random) never returned negative values.
7523 * fns.c (Frandom): Use GET_EMACS_TIME for random seed, and add the
7524 subseconds part to the entropy, as that's a bit more random.
7525 Prefer signed to unsigned, since the signedness doesn't matter and
7526 in general we prefer signed. When given a limit, use a
7527 denominator equal to INTMASK + 1, not to VALMASK + 1, because the
7528 latter isn't right if USE_2_TAGS_FOR_INTS.
7529 * sysdep.c (get_random): Return a value in the range 0..INTMASK,
7530 not 0..VALMASK. Don't discard "excess" bits that random () returns.
7531
cabf1cac
SM
75322011-07-04 Stefan Monnier <monnier@iro.umontreal.ca>
7533
7534 * textprop.c (text_property_stickiness):
7535 Obey Vtext_property_default_nonsticky.
7536 (syms_of_textprop): Add `display' to Vtext_property_default_nonsticky.
7537 * w32fns.c (syms_of_w32fns):
7538 * xfns.c (syms_of_xfns): Don't Add `display' since it's there by default.
7539
6e9b2be9
PE
75402011-07-04 Paul Eggert <eggert@cs.ucla.edu>
7541
7542 * fileio.c (barf_or_query_if_file_exists): Use S_ISDIR.
7543 This is more efficient than Ffile_directory_p and avoids a minor race.
7544
90186c68
LMI
75452011-07-04 Lars Magne Ingebrigtsen <larsi@gnus.org>
7546
7c301272
LMI
7547 * buffer.c (Foverlay_put): Say what the return value is
7548 (bug#7835).
7549
c4f2d8d4
LMI
7550 * fileio.c (barf_or_query_if_file_exists): Check first if the file
7551 is a directory before asking whether to use the file name
7552 (bug#7564).
ad637907
LMI
7553 (barf_or_query_if_file_exists): Make the "File is a directory"
7554 error be more correct.
c4f2d8d4 7555
90186c68
LMI
7556 * fns.c (Frequire): Remove the mention of the .gz files, since
7557 that's installation-specific, but keep the mention of
7558 `get-load-suffixes'.
7559
da64016e
PE
75602011-07-04 Paul Eggert <eggert@cs.ucla.edu>
7561
7562 * editfns.c (Fformat_time_string): Don't assume strlen fits in int.
7563 Report string overflow if the output is too long.
7564
7d47b580
JB
75652011-07-04 Juanma Barranquero <lekktu@gmail.com>
7566
a555cb87
JB
7567 * gnutls.c (Fgnutls_boot): Don't mention :verify-error.
7568 (syms_of_gnutls): Remove duplicate DEFSYM for
7569 Qgnutls_bootprop_verify_hostname_error, an error for
7570 Qgnutls_bootprop_verify_error (which is no longer used).
7571
7d47b580
JB
7572 * eval.c (find_handler_clause): Remove parameters `sig' and `data',
7573 unused since 2011-01-26T20:02:07Z!monnier@iro.umontreal.ca. All callers changed.
7574 Also (re)move comments that are misplaced or no longer relevant.
7575
1e49bfab
LMI
75762011-07-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
7577
7578 * callint.c (Finteractive): Clarify the meaning of "@" (bug#8813).
7579
1485f4c0
CY
75802011-07-03 Chong Yidong <cyd@stupidchicken.com>
7581
7582 * xfaces.c (Finternal_merge_in_global_face): Modify the foreground
7583 and background color parameters if they have been changed.
7584
a9ab721e
LMI
75852011-07-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
7586
7587 * editfns.c (Fformat): Clarify the - and 0 flags (bug#6659).
7588
cf7cff57
PE
75892011-07-03 Paul Eggert <eggert@cs.ucla.edu>
7590
2e13213d
PE
7591 * xsettings.c (SYSTEM_FONT): Define only when used.
7592 No need to define when HAVE_GSETTINGS || !HAVE_XFT.
7593
cf7cff57
PE
7594 * keymap.c (access_keymap_1): Now static.
7595
7a8e04f7
CY
75962011-07-02 Chong Yidong <cyd@stupidchicken.com>
7597
7598 * keyboard.c (command_loop_1): If a down-mouse event is unbound,
7599 leave any prefix arg for the up event (Bug#1586).
7600
61352f62
LMI
76012011-07-02 Lars Magne Ingebrigtsen <larsi@gnus.org>
7602
69bb1ef7
LMI
7603 * lread.c (syms_of_lread): Mention single symbols defined by
7604 `defvar' or `defconst' (bug#7154).
7605
61352f62 7606 * fns.c (Frequire): Mention .el.gz files (bug#7314).
7b3747f9 7607 (Frequire): Mention get-load-suffixes.
61352f62 7608
28545e04
MR
76092011-07-02 Martin Rudalics <rudalics@gmx.at>
7610
7611 * window.h (window): Remove clone_number slot.
7612 * window.c (Fwindow_clone_number, Fset_window_clone_number):
7613 Remove.
7614 (make_parent_window, make_window, saved_window)
7615 (Fset_window_configuration, save_window_save): Don't deal with
7616 clone numbers.
7617 * buffer.c (Qclone_number): Remove declaration.
7618 (sort_overlays, overlay_strings): Don't deal with clone numbers.
7619
3349e122
SM
76202011-07-02 Stefan Monnier <monnier@iro.umontreal.ca>
7621
7622 Add multiple inheritance to keymaps.
7623 * keymap.c (Fmake_composed_keymap): New function.
7624 (Fset_keymap_parent): Simplify.
7625 (fix_submap_inheritance): Remove.
7626 (access_keymap_1): New function extracted from access_keymap to handle
7627 embedded parents and handle lists of maps.
7628 (access_keymap): Use it.
7629 (Fkeymap_prompt, map_keymap_internal, map_keymap, store_in_keymap)
7630 (Fcopy_keymap): Handle embedded parents.
7631 (Fcommand_remapping, define_as_prefix): Simplify.
7632 (Fkey_binding): Simplify.
7633 (syms_of_keymap): Move minibuffer-local-completion-map,
7634 minibuffer-local-filename-completion-map,
7635 minibuffer-local-must-match-map, and
7636 minibuffer-local-filename-must-match-map to Elisp.
7637 (syms_of_keymap): Defsubr make-composed-keymap.
7638 * keyboard.c (menu_bar_items): Use map_keymap_canonical.
7639 (parse_menu_item): Trivial simplification.
7640
3279eb87
GM
76412011-07-01 Glenn Morris <rgm@gnu.org>
7642
7643 * Makefile.in (SETTINGS_LIBS): Fix typo.
7644
4550efdf
KI
76452011-07-01 Kazuhiro Ito <kzhr@d1.dion.ne.jp> (tiny patch)
7646
7647 * coding.c (Fencode_coding_string): Record the last coding system
7648 used, as the function doc string says (bug#8738).
7649
0949d2b6
JD
76502011-07-01 Jan Djärv <jan.h.d@swipnet.se>
7651
7652 * xsettings.c (store_monospaced_changed): Take new font as arg and
7653 check for change against current_mono_font.
7654 (EMACS_TYPE_SETTINGS): Remove this and related defines.
7655 (emacs_settings_constructor, emacs_settings_get_property)
7656 (emacs_settings_set_property, emacs_settings_class_init)
7657 (emacs_settings_init, gsettings_obj): Remove.
7658 (something_changedCB): New function for HAVE_GSETTINGS.
7659 (something_changedCB): HAVE_GCONF: Call store_monospaced_changed
7660 with value as argument.
7661 (init_gsettings): Check that GSETTINGS_SCHEMA exists before calling
7662 g_settings_new (Bug#8967). Do not create gsettings_obj.
9173deec 7663 Remove calls to g_settings_bind. Connect something_changedCB to
0949d2b6
JD
7664 "changed".
7665
7666 * xgselect.c: Add defined (HAVE_GSETTINGS).
7667 (xgselect_initialize): Ditto.
7668
7669 * process.c: Add defined (HAVE_GSETTINGS) for xgselect.h
7670 (wait_reading_process_output): Add defined (HAVE_GSETTINGS) for
7671 xg_select.
7672
bbc6b304
PE
76732011-07-01 Paul Eggert <eggert@cs.ucla.edu>
7674
7675 * eval.c (struct backtrace): Simplify and port the data structure.
7676 Do not assume that "int nargs : BITS_PER_INT - 2;" produces a
7677 signed bit field, as this assumption is not portable and it makes
7678 Emacs crash when compiled with Sun C 5.8 on sparc. Do not use
7679 "char debug_on_exit : 1" as this is not portable either; instead,
7680 use the portable "unsigned int debug_on_exit : 1". Remove unused
7681 member evalargs. Remove obsolete comments about cc bombing out.
7682
9851bfc5
JD
76832011-06-30 Jan Djärv <jan.h.d@swipnet.se>
7684
51bb811f 7685 * xsettings.c: Include glib-object.h, gio/gio.h if HAVE_GSETTINGS.
9851bfc5
JD
7686 Let HAVE_GSETTINGS override HAVE_GCONF.
7687 (store_monospaced_changed): New function.
7688 (EMACS_SETTINGS): A new type derived from GObject to handle
7689 GSettings notifications.
7690 (emacs_settings_constructor, emacs_settings_get_property)
7691 (emacs_settings_set_property, emacs_settings_class_init):
7692 New functions.
7693 (gsettings_client, gsettings_obj): New variables.
7694 (GSETTINGS_SCHEMA): New define.
7695 (something_changedCB): Call store_monospaced_changed.
7696 (init_gsettings): New function.
7697 (xsettings_initialize): Call init_gsettings.
7698 (syms_of_xsettings): Initialize gsettings_client, gsettings_obj
7699 to NULL.
7700
640c8776 7701 * Makefile.in (SETTINGS_CFLAGS, SETTINGS_LIBS): Rename from
9851bfc5
JD
7702 GCONF_CFLAGS/LIBS.
7703
5386012d
MR
77042011-06-29 Martin Rudalics <rudalics@gmx.at>
7705
7706 * window.c (resize_root_window, grow_mini_window)
7707 (shrink_mini_window): Rename Qresize_root_window to
7708 Qwindow_resize_root_window and Qresize_root_window_vertically to
7709 Qwindow_resize_root_window_vertically.
7710
f13e0b08
PE
77112011-06-28 Paul Eggert <eggert@cs.ucla.edu>
7712
7713 * gnutls.c (Qgnutls_bootprop_verify_error): Remove unused var.
7714
94515237
JB
77152011-06-27 Juanma Barranquero <lekktu@gmail.com>
7716
7717 * makefile.w32-in: Redesign dependencies so they reflect more
7718 clearly which files are directly included by each source file,
7719 and not through other includes.
7720
e43b6e43
MR
77212011-06-27 Martin Rudalics <rudalics@gmx.at>
7722
7723 * buffer.c (Qclone_number): Declare static and DEFSYM it.
7724 (sort_overlays, overlay_strings): When an overlay's clone number
7725 matches the window's clone number process the overlay even if
7726 the overlay's window property doesn't match the current window.
7727
d68443dc
MR
7728 * window.c (Fwindow_vchild): Rename to Fwindow_top_child.
7729 (Fwindow_hchild): Rename to Fwindow_left_child.
7730 (Fwindow_next): Rename to Fwindow_next_sibling.
7731 (Fwindow_prev): Rename to Fwindow_prev_sibling.
d615d6d2
MR
7732 (resize_window_check): Rename to window_resize_check.
7733 (resize_window_apply): Rename to window_resize_apply.
7734 (Fresize_window_apply): Rename to Fwindow_resize_apply.
7735 (Fdelete_other_windows_internal, resize_frame_windows)
7736 (Fsplit_window_internal, Fdelete_window_internal)
7737 (grow_mini_window, shrink_mini_window)
7738 (Fresize_mini_window_internal): Fix callers accordingly.
d68443dc 7739
c7e73be5
JD
77402011-06-26 Jan Djärv <jan.h.d@swipnet.se>
7741
7742 * emacsgtkfixed.h: State that this is only used with Gtk+3.
7743 (emacs_fixed_set_min_size): Remove.
7744 (emacs_fixed_new): Take frame as argument.
7745
7746 * emacsgtkfixed.c: State that this is only used with Gtk+3.
7747 (_EmacsFixedPrivate): Remove minwidth/height.
7748 Add struct frame *f.
7749 (emacs_fixed_init): Initialize priv->f.
7750 (get_parent_class, emacs_fixed_set_min_size): Remove.
7751 (emacs_fixed_new): Set priv->f to argument.
7752 (emacs_fixed_get_preferred_width)
7753 (emacs_fixed_get_preferred_height): Use min_width/height from
7754 frames size_hint to set minimum and natural (Bug#8919).
7755 (XSetWMSizeHints, XSetWMNormalHints): Override these functions
7756 and use min_width/height from frames size_hint to set
7757 min_width/height (Bug#8919).
7758
7759 * gtkutil.c (xg_create_frame_widgets): Pass f to emacs_fixed_new.
9173deec
JB
7760 (x_wm_set_size_hint): Remove call to emacs_fixed_set_min_size.
7761 Fix indentation.
c7e73be5 7762
cf99dcf8
EZ
77632011-06-26 Eli Zaretskii <eliz@gnu.org>
7764
7765 * bidi.c (bidi_paragraph_init): Test for ZV_BYTE before calling
7766 bidi_at_paragraph_end, since fast_looking_at doesn't like to be
7767 called at ZV.
7768
029529ac
CY
77692011-06-26 Chong Yidong <cyd@stupidchicken.com>
7770
7771 * process.c (wait_reading_process_output): Bypass select if
7772 waiting for a cell while ignoring keyboard input, and input is
7773 pending. Suggested by Jan Djärv (Bug#8869).
7774
7a7ef429
PE
77752011-06-25 Paul Eggert <eggert@cs.ucla.edu>
7776
7777 Use gnulib's dup2 module instead of rolling our own.
7778 * sysdep.c (dup2) [!HAVE_DUP2]: Remove; gnulib now does this.
7779
11fdef7d 77802011-06-25 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
989b42d2
YM
7781
7782 * dispnew.c (scrolling_window): Before scrolling, turn off a
7783 mouse-highlight in the window being scrolled.
7784
cd3520a4
JB
77852011-06-24 Juanma Barranquero <lekktu@gmail.com>
7786
7787 Move DEFSYM to lisp.h and use everywhere.
7788
7789 * character.h (DEFSYM): Move declaration...
7790 * lisp.h (DEFSYM): ...here.
7791
7792 * gnutls.c:
7793 * minibuf.c:
7794 * w32menu.c:
7795 * w32proc.c:
7796 * w32select.c: Don't include character.h.
7797
7798 * alloc.c (syms_of_alloc):
7799 * buffer.c (syms_of_buffer):
7800 * bytecode.c (syms_of_bytecode):
7801 * callint.c (syms_of_callint):
7802 * casefiddle.c (syms_of_casefiddle):
7803 * casetab.c (init_casetab_once):
7804 * category.c (init_category_once, syms_of_category):
7805 * ccl.c (syms_of_ccl):
7806 * cmds.c (syms_of_cmds):
7807 * composite.c (syms_of_composite):
7808 * dbusbind.c (syms_of_dbusbind):
7809 * dired.c (syms_of_dired):
7810 * dispnew.c (syms_of_display):
7811 * doc.c (syms_of_doc):
7812 * editfns.c (syms_of_editfns):
7813 * emacs.c (syms_of_emacs):
7814 * eval.c (syms_of_eval):
7815 * fileio.c (syms_of_fileio):
7816 * fns.c (syms_of_fns):
7817 * frame.c (syms_of_frame):
7818 * fringe.c (syms_of_fringe):
7819 * insdel.c (syms_of_insdel):
7820 * keymap.c (syms_of_keymap):
7821 * lread.c (init_obarray, syms_of_lread):
7822 * macros.c (syms_of_macros):
7823 * msdos.c (syms_of_msdos):
7824 * print.c (syms_of_print):
7825 * process.c (syms_of_process):
7826 * search.c (syms_of_search):
7827 * sound.c (syms_of_sound):
7828 * syntax.c (init_syntax_once, syms_of_syntax):
7829 * terminal.c (syms_of_terminal):
7830 * textprop.c (syms_of_textprop):
7831 * undo.c (syms_of_undo):
7832 * w32.c (globals_of_w32):
7833 * window.c (syms_of_window):
7834 * xdisp.c (syms_of_xdisp):
7835 * xfaces.c (syms_of_xfaces):
7836 * xfns.c (syms_of_xfns):
7837 * xmenu.c (syms_of_xmenu):
7838 * xsettings.c (syms_of_xsettings):
7839 * xterm.c (syms_of_xterm): Use DEFSYM.
7840
4228cf16
TZ
78412011-06-24 Teodor Zlatanov <tzz@lifelogs.com>
7842
cd3520a4 7843 * gnutls.c (syms_of_gnutls): Use the DEFSYM macro from character.h.
4228cf16 7844
7fcccf1e
PE
78452011-06-23 Paul Eggert <eggert@cs.ucla.edu>
7846
7efb4e0e
PE
7847 Integer and buffer overflow fixes (Bug#8873).
7848
ff5844ad
PE
7849 * print.c (printchar, strout): Check for string overflow.
7850 (PRINTPREPARE, printchar, strout):
7851 Don't set size unless allocation succeeds.
7852
90532f02
PE
7853 * minibuf.c (read_minibuf_noninteractive): Use ptrdiff_t, not int,
7854 for sizes. Check for string overflow more accurately.
7855 Simplify newline removal at end; this suppresses a GCC 4.6.0 warning.
7856
6d84508d
PE
7857 * macros.c: Integer and buffer overflow fixes.
7858 * keyboard.h (struct keyboard.kbd_macro_bufsize):
7859 * macros.c (Fstart_kbd_macro, store_kbd_macro_char):
7860 Use ptrdiff_t, not int, for sizes.
7861 Don't increment bufsize until after realloc succeeds.
7862 Check for size-calculation overflow.
7863 (Fstart_kbd_macro): Use EMACS_INT, not int, for XINT result.
7864
437b2cb4
PE
7865 * lisp.h (DEFVAR_KBOARD): Use offsetof instead of char * finagling.
7866
8b9ac8b4
PE
7867 * lread.c: Integer overflow fixes.
7868 (read_integer): Radix is now EMACS_INT, not int,
7869 to improve quality of diagnostics for out-of-range radices.
7870 Calculate buffer size correctly for out-of-range radices.
7871 (read1): Check for integer overflow in radices, and in
7872 read-circle numbers.
82cb60d3
PE
7873 (read_escape): Avoid int overflow.
7874 (Fload, openp, read_buffer_size, read1)
7875 (substitute_object_recurse, read_vector, read_list, map_obarray):
7876 Use ptrdiff_t, not int, for sizes.
7877 (read1): Use EMACS_INT, not int, for sizes.
20270765 7878 Check for size overflow.
8b9ac8b4 7879
7fcccf1e
PE
7880 * image.c (cache_image): Check for size arithmetic overflow.
7881
bfbbd7e7
PE
7882 * lread.c: Integer overflow issues.
7883 (saved_doc_string_size, saved_doc_string_length)
7884 (prev_saved_doc_string_size, prev_saved_doc_string_length):
7885 Now ptrdiff_t, not int.
7886 (read1): Don't assume doc string length fits in int. Check for
7887 out-of-range doc string lengths.
7888 (read_list): Don't assume file position fits in int.
39019e54 7889 (read_escape): Check for hex character overflow.
bfbbd7e7 7890
4e323265
LL
78912011-06-22 Leo Liu <sdl.web@gmail.com>
7892
7893 * minibuf.c (Fcompleting_read_default, Vcompleting_read_function):
7894 Move to minibuffer.el.
7895
85fece3e
PE
78962011-06-22 Paul Eggert <eggert@cs.ucla.edu>
7897
20b84ce9 7898 Fixes for GLYPH_DEBUG found by GCC 4.6.0 static checking.
85fece3e
PE
7899 The following patches are for when GLYPH_DEBUG && !XASSERT.
7900 * dispextern.h (trace_redisplay_p, dump_glyph_string):
7901 * dispnew.c (flush_stdout):
7902 * xdisp.c (dump_glyph_row, dump_glyph_matrix, dump_glyph):
7903 Mark as externally visible.
7904 * dispnew.c (check_window_matrix_pointers): Now static.
7905 * dispnew.c (window_to_frame_vpos):
7906 * xfns.c (unwind_create_frame):
7907 * xterm.c (x_check_font): Remove unused local.
7908 * scroll.c (CHECK_BOUNDS):
7909 * xfaces.c (cache_fache): Rename local to avoid shadowing.
7910 * xfns.c, w32fns.c (image_cache_refcount, dpyinfo_refcount): Now static.
7911 * xdisp.c (check_window_end): Now a no-op if !XASSERTS.
7912 (debug_first_unchanged_at_end_vpos, debug_last_unchanged_at_beg_vpos)
7913 (debug_dvpos, debug_dy, debug_delta, debug_delta_bytes, debug_end_vpos):
7914 Now static.
7915 (debug_method_add): Use va_list and vsprintf rather than relying
7916 on undefined behavior with wrong number of arguments.
7917 (dump_glyph, dump_glyph_row, Fdump_glyph_matrix):
7918 Don't assume ptrdiff_t and EMACS_INT are the same width as int.
7919 In this code, it's OK to assume C99 behavior for ptrdiff_t formats
7920 since we're not interested in debugging glyphs with old libraries.
7921 * xfaces.c (cache_face): Move debugging code earlier; this pacifies
7922 GCC 4.6.0's static checking.
7923
0766b489
PE
79242011-06-22 Paul Eggert <eggert@cs.ucla.edu>
7925
31fd4b32
PE
7926 Integer overflow and signedness fixes (Bug#8873).
7927 A few related buffer overrun fixes, too.
7928
b79e8648
PE
7929 * font.c (font_score): Use EMACS_INT, not int, to store XINT value.
7930
0766b489
PE
7931 * dispextern.h (struct face.stipple):
7932 * image.c (x_bitmap_height, x_bitmap_width, x_bitmap_pixmap)
7933 (x_bitmap_mask, x_allocate_bitmap_record)
7934 (x_create_bitmap_from_data, x_create_bitmap_from_file)
7935 (x_destroy_bitmap, x_destroy_all_bitmaps, x_create_bitmap_mask)
7936 (x_create_bitmap_from_xpm_data):
7937 * nsterm.h (struct ns_display_info.bitmaps_size, .bitmaps_last):
7938 * w32term.h (struct w32_display_info.icon_bitmap_id, .bitmaps_size)
7939 (.bitmaps_last):
7940 * xfaces.c (load_pixmap):
7941 * xterm.c (x_bitmap_icon, x_wm_set_icon_pixmap):
7942 * xterm.h (struct x_display_info.icon_bitmap_id, .bitmaps_size)
7943 (.bitmaps_last, struct x_output.icon_bitmap):
7944 Use ptrdiff_t, not int, for bitmap indexes.
7945 (x_allocate_bitmap_record): Check for size overflow.
7946 * dispextern.h, lisp.h: Adjust to API changes elsewhere.
7947
b081724f
PE
7948 Use ptrdiff_t, not int, for overlay counts.
7949 * buffer.h (overlays_at, sort_overlays, GET_OVERLAYS_AT):
7950 * editfns.c (overlays_around, get_pos_property):
7951 * textprop.c (get_char_property_and_overlay):
7952 * xdisp.c (next_overlay_change, note_mouse_highlight):
7953 * xfaces.c (face_at_buffer_position):
21514da7
PE
7954 * buffer.c (OVERLAY_COUNT_MAX): New macro.
7955 (overlays_at, overlays_in, sort_overlays, Foverlays_at)
7956 (Fnext_overlay_change, Fprevious_overlay_change)
7957 (mouse_face_overlay_overlaps, Foverlays_in):
b081724f 7958 Use ptrdiff_t, not int, for sizes.
21514da7 7959 (overlays_at, overlays_in): Check for size-calculation overflow.
b081724f 7960
3de73e5e
PE
7961 * xterm.c (xim_initialize, same_x_server): Strlen may not fit in int.
7962
2606c57b
PE
7963 * xsmfns.c (smc_save_yourself_CB, x_session_initialize): Avoid strlen.
7964 (x_session_initialize): Do not assume string length fits in int.
7965
aaafe47a
PE
7966 * xsettings.c (apply_xft_settings): Fix potential buffer overrun.
7967 This is unlikely, but can occur if DPI is outlandish.
7968
2674ddc8 7969 * xsettings.c (Ffont_get_system_normal_font, Ffont_get_system_font):
3a5077c5
PE
7970 * xselect.c (Fx_get_atom_name): Avoid need for strlen.
7971
28154962
PE
7972 * xrdb.c: Don't assume strlen fits in int; avoid some strlens.
7973 * xrdb.c (magic_file_p, search_magic_path):
7974 Omit last arg SUFFIX; it was always 0. All callers changed.
7975 (magic_file_p): Use ptrdiff_t, not int. Check for size overflow.
7976
7de51af5
PE
7977 * xfont.c (xfont_match): Avoid need for strlen.
7978
25ed6cc3
PE
7979 * xfns.c: Don't assume strlen fits in int.
7980 (xic_create_fontsetname, x_window): Use ptrdiff_t, not int.
7981
4eab31dd
PE
7982 * xdisp.c (message_log_check_duplicate): Return intmax_t,
7983 not unsigned long, as we prefer signed integers. All callers changed.
7984 Detect integer overflow in repeat count.
7985 (message_dolog): Don't assume print length fits in 39 bytes.
df1f27af 7986 (display_mode_element): Don't assume strlen fits in int.
4eab31dd 7987
171e2a58
PE
7988 * termcap.c: Don't assume sizes fit in int and never overflow.
7989 (struct termcap_buffer, tgetent): Use ptrdiff_t, not int, for sizes.
7990 (gobble_line): Check for size-calculation overflow.
7991
ad39faca 7992 * minibuf.c (Fread_buffer):
6e5bb2dc 7993 * lread.c (intern, intern_c_string):
74ca2eb3
PE
7994 * image.c (xpm_scan) [HAVE_NS && !HAVE_XPM]:
7995 Don't assume string length fits in int.
7996
52c61c22 7997 * keyboard.c (parse_tool_bar_item):
9bda3520
PE
7998 * gtkutil.c (style_changed_cb): Avoid need for strlen.
7999
b5b8c9e5
PE
8000 * font.c: Don't assume string length fits in int.
8001 (font_parse_xlfd, font_parse_fcname, font_unparse_fcname):
8002 Use ptrdiff_t, not int.
ccd6111c
PE
8003 (font_intern_prop): Don't assume string length fits in int.
8004 Don't assume integer property fits in fixnum.
8005 * font.h (font_intern_prop): 2nd arg is now ptrdiff_t, not int.
b5b8c9e5 8006
882f0d81 8007 * filelock.c: Fix some buffer overrun and integer overflow issues.
51cab52b 8008 (get_boot_time): Don't assume gzip command string fits in 100 bytes.
882f0d81
PE
8009 Reformulate so as not to need the command string.
8010 Invoke gzip -cd rather than gunzip, as it's more portable.
8011 (lock_info_type, lock_file_1, lock_file):
8012 Don't assume pid_t and time_t fit in unsigned long.
8013 (LOCK_PID_MAX): Remove; we now use more-reliable bounds.
8014 (current_lock_owner): Prefer signed type for sizes.
8015 Use memcpy, not strncpy, where memcpy is what is really wanted.
8016 Don't assume (via atoi) that time_t and pid_t fit in int.
8017 Check for time_t and/or pid_t out of range, e.g., via a network share.
8018 Don't alloca where an auto var works fine.
8019
93f4cf88
PE
8020 * fileio.c: Fix some integer overflow issues.
8021 (file_name_as_directory, Fexpand_file_name, Fsubstitute_in_file_name):
8022 Don't assume string length fits in int.
8023 (directory_file_name): Don't assume string length fits in long.
8024 (make_temp_name): Don't assume pid fits in int, or that its print
8025 length is less than 20.
8026
f3e92b69
PE
8027 * data.c (Fsubr_name): Rewrite to avoid a strlen call.
8028
1bfdaf10
PE
8029 * coding.c (make_subsidiaries): Don't assume string length fits in int.
8030
35016e9a
PE
8031 * callproc.c (child_setup): Rewrite to avoid two strlen calls.
8032
3d1e65a1
PE
8033 * process.c (Fformat_network_address): Use EMACS_INT, not EMACS_UINT.
8034 We prefer signed integers, even for size calculations.
8035
0b963a93
PE
8036 * emacs.c: Don't assume string length fits in 'int'.
8037 (DEFINE_DUMMY_FUNCTION, sort_args): Use ptrdiff_t, not int.
8038 (main): Don't invoke strlen when not needed.
8039
573f4b54
PE
8040 * dbusbind.c (XD_ERROR): Don't arbitrarily truncate string.
8041 (XD_DEBUG_MESSAGE): Don't waste a byte.
8042
989f33ba
PE
8043 * callproc.c (getenv_internal_1, getenv_internal)
8044 (Fgetenv_internal):
965d34eb
PE
8045 * buffer.c (init_buffer): Don't assume string length fits in 'int'.
8046
e4d29b33
PE
8047 * lread.c (invalid_syntax): Omit length argument.
8048 All uses changed. This doesn't fix a bug, but it simplifies the
8049 code away from its former Hollerith-constant appearance, and it's
8050 one less 'int' to worry about when looking at integer-overflow issues.
51cab52b 8051 (string_to_number): Simplify 2011-04-26 change by invoking xsignal1.
e4d29b33 8052
eb49b136
PE
8053 * lisp.h (DEFUN): Remove bogus use of sizeof (struct Lisp_Subr).
8054 This didn't break anything, but it didn't help either.
8055 It's confusing to put a bogus integer in a place where the actual
8056 value does not matter.
9f62aeb1 8057 (LIST_END_P): Remove unused macro and its bogus comment.
cbeff735 8058 (make_fixnum_or_float): Remove unnecessary cast to EMACS_INT.
eb49b136 8059
15375a22
PE
8060 * lisp.h (union Lisp_Object.i): EMACS_INT, not EMACS_UINT.
8061 This is for consistency with the ordinary, non-USE_LISP_UNION_TYPE,
8062 implementation.
b61cc01c
PE
8063 (struct Lisp_Bool_Vector.size): EMACS_INT, not EMACS_UINT.
8064 We prefer signed types, and the value cannot exceed the EMACS_INT
8065 range anyway (because otherwise the length would not be representable).
9a8e8d9b
PE
8066 (XSET) [USE_LISP_UNION_TYPE]: Use uintptr_t and intptr_t,
8067 not EMACS_UINT and EMACS_INT, when converting pointer to integer.
8068 This avoids a GCC warning when WIDE_EMACS_INT.
15375a22 8069
53b2623d
PE
8070 * indent.c (sane_tab_width): New function.
8071 (current_column, scan_for_column, Findent_to, position_indentation)
8072 (compute_motion): Use it. This is just for clarity.
8fcaf9cc 8073 (Fcompute_motion): Don't assume hscroll and tab offset fit in int.
53b2623d 8074
51cab52b 8075 * image.c (xbm_image_p): Don't assume stated width, height fit in int.
45aebb64 8076
f2ed8a70
PE
8077 * lisp.h (lint_assume): New macro.
8078 * composite.c (composition_gstring_put_cache):
8079 * ftfont.c (ftfont_shape_by_flt): Use it to pacify GCC 4.6.0.
8080
abe80cc6
PE
8081 * editfns.c, insdel.c:
8082 Omit unnecessary forward decls, to simplify future changes.
a9e860e1 8083
b02c740e
PE
8084 * ftfont.c (ftfont_shape_by_flt): Use signed integers for lengths.
8085
ebc96716
PE
8086 * font.c (Ffont_shape_gstring): Don't assume glyph len fits in 'int'.
8087
b4e50fa0 8088 * fns.c (Ffillarray): Don't assume bool vector size fits in 'int'.
f03dc6ef 8089 Use much-faster test for byte-length change.
311d5d7c 8090 Don't assume string byte-length fits in 'int'.
a4cf38e4 8091 Check that character arg fits in 'int'.
85461888 8092 (mapcar1): Declare byte as byte, for clarity.
b4e50fa0 8093
c0c1ee9f
PE
8094 * alloc.c (Fmake_bool_vector): Avoid unnecessary multiplication.
8095
a498d7f4
PE
8096 * fns.c (concat): Catch string overflow earlier.
8097 Do not rely on integer wraparound.
8098
51cab52b
PE
8099 * dispextern.h (struct it.overlay_strings_charpos)
8100 (struct it.selective): Now EMACS_INT, not int.
87830974
PE
8101 * xdisp.c (forward_to_next_line_start)
8102 (back_to_previous_visible_line_start)
8103 (reseat_at_next_visible_line_start, next_element_from_buffer):
8104 Don't arbitrarily truncate the value of 'selective' to int.
8105
76031fad
PE
8106 * xdisp.c (init_iterator): Use XINT, not XFASTINT; it might be < 0.
8107
5eb55db9
PE
8108 * composite.c: Don't truncate sizes to 'int'.
8109 (composition_gstring_p, composition_reseat_it)
8110 (composition_adjust_point): Use EMACS_INT, not int.
7d100a81
PE
8111 (get_composition_id, composition_gstring_put_cache): Use EMACS_INT,
8112 not EMACS_UINT, for indexes.
5eb55db9 8113
0703a717
PE
8114 * category.h (CATEGORY_SET_P): Remove unnecessary cast to EMACS_INT.
8115
d6202519
PE
8116 * buffer.c: Include <verify.h>.
8117 (struct sortvec.priority, struct sortstr.priority):
8961a454 8118 Now EMACS_INT, not int.
c20998a7 8119 (compare_overlays, cmp_for_strings): Avoid subtraction overflow.
67c36fce
PE
8120 (struct sortstr.size, record_overlay_string)
8121 (struct sortstrlist.size, struct sortlist.used):
8122 Don't truncate size to int.
8123 (record_overlay_string): Check for size-calculation overflow.
d6202519 8124 (init_buffer_once): Check at compile-time, not run-time.
fadf4e30 8125
d5a19415
JM
81262011-06-22 Jim Meyering <meyering@redhat.com>
8127
029529ac 8128 Don't leak an XBM-image-sized buffer
d5a19415
JM
8129 * image.c (xbm_load): Free the image buffer after using it.
8130
a9041e6c
PE
81312011-06-21 Paul Eggert <eggert@cs.ucla.edu>
8132
8133 Port to Sun C.
8134 * composite.c (find_automatic_composition): Omit needless 'return 0;'
8135 that Sun C diagnosed.
8136 * fns.c (secure_hash): Fix pointer signedness issue.
8137 * intervals.c (static_offset_intervals): New function.
8138 (offset_intervals): Use it.
8139
7f3f739f
LL
81402011-06-21 Leo Liu <sdl.web@gmail.com>
8141
8142 * deps.mk (fns.o):
8143 * makefile.w32-in ($(BLD)/fns.$(O)): Include sha256.h and
8144 sha512.h.
8145
8146 * fns.c (secure_hash): Rename from crypto_hash_function and change
8147 the first arg to accept symbols.
5b66d427 8148 (Fsecure_hash): New primitive.
7f3f739f
LL
8149 (syms_of_fns): New symbols.
8150
76147d94
DD
81512011-06-20 Deniz Dogan <deniz@dogan.se>
8152
8153 * process.c (Fset_process_buffer): Clarify return value in
8154 docstring.
8155
7d7d0045
CY
81562011-06-18 Chong Yidong <cyd@stupidchicken.com>
8157
8158 * dispnew.c (add_window_display_history): Use BVAR.
8159
8160 * xdisp.c (debug_method_add): Use BVAR.
8161 (check_window_end, dump_glyph_matrix, dump_glyph)
8162 (dump_glyph_row, dump_glyph_string): Convert arglist to ANSI C.
8163
8164 * xfaces.c (check_lface_attrs, check_lface, dump_realized_face):
8165 Likewise.
8166
8167 * xfns.c (Fx_create_frame, x_create_tip_frame): Delay image cache
8168 check till after the cache is created in init_frame_faces.
8169
ff2bc410
SM
81702011-06-17 Stefan Monnier <monnier@iro.umontreal.ca>
8171
8172 * fns.c (Fsafe_length): Yet another int/Lisp_Object mixup.
8173
28177add
PE
81742011-06-16 Paul Eggert <eggert@cs.ucla.edu>
8175
dd3482fe
PE
8176 * lisp.h: Include <limits.h>, for INT_MAX, LONG_MAX, LLONG_MAX.
8177 Without this, prin1 mishandles Lisp_Misc_Save_Value printing on
8178 hosts with pre-C99 libraries, because pD is wrongly defined to "t".
8179
393d71f3 8180 Improve buffer-overflow checking (Bug#8873).
1c8e352f
PE
8181 * fileio.c (Finsert_file_contents):
8182 * insdel.c (insert_from_buffer_1, replace_range, replace_range_2):
8183 Remove the old (too-loose) buffer overflow checks.
8184 They weren't needed, since make_gap checks for buffer overflow.
8185 * insdel.c (make_gap_larger): Catch buffer overflows that were missed.
8186 The old code merely checked for Emacs fixnum overflow, and relied
8187 on undefined (wraparound) behavior. The new code avoids undefined
8188 behavior, and also checks for ptrdiff_t and/or size_t overflow.
8189
2e6813b0 8190 * editfns.c (Finsert_char): Don't dump core with very negative counts.
21d890a4
PE
8191 Tune. Don't use wider integers than needed. Don't use alloca.
8192 Use a bigger 'string' buffer. Rewrite to avoid 'n > 0' test.
2e6813b0 8193
599a9e4f
PE
8194 * insdel.c (replace_range): Fix buf overflow when insbytes < outgoing.
8195
99561444
PE
8196 * insdel.c, lisp.h (buffer_overflow): New function.
8197 (insert_from_buffer_1, replace_range, replace_range_2):
8198 * insdel.c (make_gap_larger):
8199 * editfns.c (Finsert_char):
8200 * fileio.c (Finsert_file_contents): Use it, to normalize wording.
8201
28177add
PE
8202 * buffer.h (BUF_BYTES_MAX): Cast to ptrdiff_t so that it's signed.
8203
e69dafad
PE
82042011-06-15 Paul Eggert <eggert@cs.ucla.edu>
8205
4baa020d 8206 Integer overflow and signedness fixes (Bug#8873, Bug#8828).
ff672d2c 8207
b1c46f02
PE
8208 * ccl.c (ASCENDING_ORDER): New macro, to work around GCC bug 43772.
8209 (GET_CCL_RANGE, IN_INT_RANGE): Use it.
8210
e69dafad
PE
8211 * fileio.c: Don't assume EMACS_INT fits in off_t.
8212 (emacs_lseek): New static function.
8213 (Finsert_file_contents, Fwrite_region): Use it.
8214 Use SEEK_SET, SEEK_CUR, SEEK_END as appropriate.
8215
566684ea
PE
8216 * fns.c (Fload_average): Don't assume 100 * load average fits in int.
8217
e6966cd6
PE
8218 * fns.c: Don't overflow int when computing a list length.
8219 * fns.c (QUIT_COUNT_HEURISTIC): New constant.
8220 (Flength, Fsafe_length): Use EMACS_INT, not int, to avoid unwanted
8221 truncation on 64-bit hosts. Check for QUIT every
8222 QUIT_COUNT_HEURISTIC entries rather than every other entry; that's
8223 faster and is responsive enough.
8224 (Flength): Report an error instead of overflowing an integer.
8225 (Fsafe_length): Return a float if the value is not representable
8226 as a fixnum. This shouldn't happen except in contrived situations.
6346d301 8227 (Fnthcdr, Fsort): Don't assume list length fits in int.
de41a810 8228 (Fcopy_sequence): Don't assume vector length fits in int.
00c604f2 8229
dd0b0efb
PE
8230 * alloc.c: Check that resized vectors' lengths fit in fixnums.
8231 (header_size, word_size): New constants.
8232 (allocate_vectorlike): Don't check size overflow here.
8233 (allocate_vector): Check it here instead, since this is the only
8234 caller of allocate_vectorlike that could cause overflow.
8235 Check that the new vector's length is representable as a fixnum.
8236
86fe5cfe
PE
8237 * fns.c (next_almost_prime): Don't return a multiple of 3 or 5.
8238 The previous code was bogus. For example, next_almost_prime (32)
8239 returned 39, which is undesirable as it is a multiple of 3; and
8240 next_almost_prime (24) returned 25, which is a multiple of 5 so
8241 why was the code bothering to check for multiples of 7?
8242
80e88859
PE
8243 * bytecode.c (exec_byte_code): Use ptrdiff_t, not int, for vector length.
8244
4a2f0ad6
PE
8245 * eval.c, doprnt.c (SIZE_MAX): Remove; inttypes.h defines this now.
8246
f66c7cf8
PE
8247 Variadic C functions now count arguments with ptrdiff_t.
8248 This partly undoes my 2011-03-30 change, which replaced int with size_t.
8249 Back then I didn't know that the Emacs coding style prefers signed int.
8250 Also, in the meantime I found a few more instances where arguments
4a2f0ad6
PE
8251 were being counted with int, which may truncate counts on 64-bit
8252 machines, or EMACS_INT, which may be unnecessarily wide.
f66c7cf8
PE
8253 * lisp.h (struct Lisp_Subr.function.aMANY)
8254 (DEFUN_ARGS_MANY, internal_condition_case_n, safe_call):
8255 Arg counts are now ptrdiff_t, not size_t.
8256 All variadic functions and their callers changed accordingly.
8257 (struct gcpro.nvars): Now size_t, not size_t. All uses changed.
8258 * bytecode.c (exec_byte_code): Check maxdepth for overflow,
8259 to avoid potential buffer overrun. Don't assume arg counts fit in 'int'.
8260 * callint.c (Fcall_interactively): Check arg count for overflow,
8261 to avoid potential buffer overrun. Use signed char, not 'int',
8262 for 'varies' array, so that we needn't bother to check its size
8263 calculation for overflow.
8264 * editfns.c (Fformat): Use ptrdiff_t, not EMACS_INT, to count args.
8265 * eval.c (apply_lambda):
8266 * fns.c (Fmapconcat): Use XFASTINT, not XINT, to get args length.
8267 (struct textprop_rec.argnum): Now ptrdiff_t, not int. All uses changed.
8268 (mapconcat): Use ptrdiff_t, not int and EMACS_INT, to count args.
8269
a1759b76
PE
8270 * callint.c (Fcall_interactively): Don't use index var as event count.
8271
d96be9fc
PE
8272 * vm-limit.c (check_memory_limits): Fix incorrect extern function decls.
8273 * mem-limits.h (SIZE): Remove; no longer used.
8274
a690a978 8275 * xterm.c (x_alloc_nearest_color_1): Prefer int to long when int works.
5efd304b 8276
578c21e6
PE
8277 Remove unnecessary casts.
8278 * xterm.c (x_term_init):
8279 * xfns.c (x_set_border_pixel):
8280 * widget.c (create_frame_gcs): Remove casts to unsigned long etc.
8281 These aren't needed now that we assume ANSI C.
8282
96f53c6c
PE
8283 * sound.c (Fplay_sound_internal): Remove cast to unsigned long.
8284 It's more likely to cause problems (due to unsigned overflow)
8285 than to cure them.
8286
83c77d31
PE
8287 * dired.c (Ffile_attributes): Don't use 32-bit hack on 64-bit hosts.
8288
ee2079f1
PE
8289 * unexelf.c (unexec): Don't assume BSS addr fits in unsigned.
8290
6da65536
PE
8291 * xterm.c (handle_one_xevent): Omit unnecessary casts to unsigned.
8292
7147c4a4
PE
8293 * keyboard.c (modify_event_symbol): Don't limit alist len to UINT_MAX.
8294
193e32d9
PE
8295 * lisp.h (CHAR_TABLE_SET): Omit now-redundant test.
8296
e5533da6
PE
8297 * lread.c (Fload): Don't compare a possibly-garbage time_t value.
8298
9910e595
PE
8299 GLYPH_CODE_FACE returns EMACS_INT, not int.
8300 * dispextern.h (merge_faces):
8301 * xfaces.c (merge_faces):
01103c44
PE
8302 * xdisp.c (get_next_display_element, next_element_from_display_vector):
8303 Don't assume EMACS_INT fits in int.
9910e595 8304
2638320e
PE
8305 * character.h (CHAR_VALID_P): Remove unused parameter.
8306 * fontset.c, lisp.h, xdisp.c: All uses changed.
8307
045eb8d9
PE
8308 * editfns.c (Ftranslate_region_internal): Omit redundant test.
8309
c1f134b5
PE
8310 * fns.c (concat): Minor tuning based on overflow analysis.
8311 This doesn't fix any bugs. Use int to hold character, instead
8312 of constantly refetching from Emacs object. Use XFASTINT, not
8313 XINT, for value known to be a character. Don't bother comparing
8314 a single byte to 0400, as it's always less.
8315
395fcb93 8316 * floatfns.c (Fexpt):
327eeec8
PE
8317 * fileio.c (make_temp_name): Omit unnecessary cast to unsigned.
8318
abbd3d23
PE
8319 * editfns.c (Ftranslate_region_internal): Use int, not EMACS_INT
8320 for characters.
8321
684a03ef
PE
8322 * doc.c (get_doc_string): Omit (unsigned)c that mishandled negatives.
8323
0fed43f3
PE
8324 * data.c (Faset): If ARRAY is a string, check that NEWELT is a char.
8325 Without this fix, on a 64-bit host (aset S 0 4294967386) would
8326 incorrectly succeed when S was a string, because 4294967386 was
8327 truncated before it was used.
8328
8fd02eb7
PE
8329 * chartab.c (Fchar_table_range): Use CHARACTERP to check range.
8330 Otherwise, an out-of-range integer could cause undefined behavior
8331 on a 64-bit host.
8332
f8c86b69
PE
8333 * composite.c: Use int, not EMACS_INT, for characters.
8334 (fill_gstring_body, composition_compute_stop_pos): Use int, not
8335 EMACS_INT, for values that are known to be in character range.
8336 This doesn't fix any bugs but is the usual style inside Emacs and
8337 may generate better code on 32-bit machines.
8338
34206dd2
PE
8339 Make sure a 64-bit char is never passed to ENCODE_CHAR.
8340 This is for reasons similar to the recent CHAR_STRING fix.
8341 * charset.c (Fencode_char): Check that character arg is actually
8342 a character. Pass an int to ENCODE_CHAR.
8343 * charset.h (ENCODE_CHAR): Verify that the character argument is no
8344 wider than 'int', as a compile-time check to prevent future regressions
8345 in this area.
8346
c5958d4c 8347 * character.c (char_string): Remove unnecessary casts.
13bdea59
PE
8348
8349 Make sure a 64-bit char is never passed to CHAR_STRING.
8350 Otherwise, CHAR_STRING would do the wrong thing on a 64-bit platform,
8351 by silently ignoring the top 32 bits, allowing some values
8352 that were far too large to be valid characters.
8353 * character.h: Include <verify.h>.
8354 (CHAR_STRING, CHAR_STRING_ADVANCE): Verify that the character
8355 arguments are no wider than unsigned, as a compile-time check
8356 to prevent future regressions in this area.
8357 * data.c (Faset):
01103c44 8358 * editfns.c (Fchar_to_string, general_insert_function, Finsert_char)
13bdea59
PE
8359 (Fsubst_char_in_region):
8360 * fns.c (concat):
8361 * xdisp.c (decode_mode_spec_coding):
8362 Adjust to CHAR_STRING's new requirement.
8363 * editfns.c (Finsert_char, Fsubst_char_in_region):
8364 * fns.c (concat): Check that character args are actually
8365 characters. Without this test, these functions did the wrong
8366 thing with wildly out-of-range values on 64-bit hosts.
8367
d37ca623
PE
8368 Remove incorrect casts to 'unsigned' that lose info on 64-bit hosts.
8369 These casts should not be needed on 32-bit hosts, either.
8370 * keyboard.c (read_char):
8371 * lread.c (Fload): Remove casts to unsigned.
8372
ea204efb
PE
8373 * lisp.h (UNSIGNED_CMP): New macro.
8374 This fixes comparison bugs on 64-bit hosts.
8375 (ASCII_CHAR_P): Use it.
8376 * casefiddle.c (casify_object):
01103c44 8377 * character.h (ASCII_BYTE_P, CHAR_VALID_P)
ea204efb
PE
8378 (SINGLE_BYTE_CHAR_P, CHAR_STRING):
8379 * composite.h (COMPOSITION_ENCODE_RULE_VALID):
8380 * dispextern.h (FACE_FROM_ID):
8381 * keyboard.c (read_char): Use UNSIGNED_CMP.
8382
41cb286c
PE
8383 * xmenu.c (dialog_selection_callback) [!USE_GTK]: Cast to intptr_t,
8384 not to EMACS_INT, to avoid GCC warning.
8385
4a1b9832
PE
8386 * xfns.c (x_set_scroll_bar_default_width): Remove unused 'int' locals.
8387
55daad71
PE
8388 * buffer.h (PTR_BYTE_POS, BUF_PTR_BYTE_POS): Remove harmful cast.
8389 The cast incorrectly truncated 64-bit byte offsets to 32 bits, and
8390 isn't needed on 32-bit machines.
8f95c75c 8391
01103c44
PE
8392 * buffer.c (Fgenerate_new_buffer_name):
8393 Use EMACS_INT for count, not int.
0ceccced 8394 (advance_to_char_boundary): Return EMACS_INT, not int.
e762cafe
PE
8395
8396 * data.c (Qcompiled_function): Now static.
8397
c6f072e7
PE
8398 * window.c (window_body_lines): Now static.
8399
20ce5912
PE
8400 * image.c (gif_load): Rename local to avoid shadowing.
8401
9c4c5f81
PE
8402 * lisp.h (SAFE_ALLOCA_LISP): Check for integer overflow.
8403 (struct Lisp_Save_Value): Use ptrdiff_t, not int, for 'integer' member.
8404 * alloc.c (make_save_value): Integer argument is now of type
8405 ptrdiff_t, not int.
8406 (mark_object): Use ptrdiff_t, not int.
8407 * lisp.h (pD): New macro.
8408 * print.c (print_object): Use it.
8409
c0c5c8ae
PE
8410 * alloc.c: Use EMACS_INT, not int, to count objects.
8411 (total_conses, total_markers, total_symbols, total_vector_size)
8412 (total_free_conses, total_free_markers, total_free_symbols)
01103c44
PE
8413 (total_free_floats, total_floats, total_free_intervals)
8414 (total_intervals, total_strings, total_free_strings):
c0c5c8ae
PE
8415 Now EMACS_INT, not int. All uses changed.
8416 (Fgarbage_collect): Compute overall total using a double, so that
8417 integer overflow is less likely to be a problem. Check for overflow
8418 when converting back to an integer.
5a25e253
PE
8419 (n_interval_blocks, n_string_blocks, n_float_blocks, n_cons_blocks)
8420 (n_vectors, n_symbol_blocks, n_marker_blocks): Remove.
8421 These were 'int' variables that could overflow on 64-bit hosts;
8422 they were never used, so remove them instead of repairing them.
211a0b2a 8423 (nzombies, ngcs, max_live, max_zombies): Now EMACS_INT, not 'int'.
6349ae4d
PE
8424 (inhibit_garbage_collection): Set gc_cons_threshold to max value.
8425 Previously, this ceilinged at INT_MAX, but that doesn't work on
8426 64-bit machines.
e46bb31a 8427 (allocate_pseudovector): Don't use EMACS_INT when int would do.
c0c5c8ae 8428
c78baabf 8429 * alloc.c (Fmake_bool_vector): Don't assume vector size fits in int.
86f61a15 8430 (allocate_vectorlike): Check for ptrdiff_t overflow.
b6439961
PE
8431 (mark_vectorlike, mark_char_table, mark_object): Avoid EMACS_UINT
8432 when a (possibly-narrower) signed value would do just as well.
8433 We prefer using signed arithmetic, to avoid comparison confusion.
c78baabf 8434
c9d624c6
PE
8435 * alloc.c: Catch some string size overflows that we were missing.
8436 (XMALLOC_OVERRUN_CHECK_SIZE) [!XMALLOC_OVERRUN_CHECK]: Define to 0,
8437 for convenience in STRING_BYTES_MAX.
8438 (STRING_BYTES_MAX): New macro, superseding the old one in lisp.h.
8439 The definition here is exact; the one in lisp.h was approximate.
8440 (allocate_string_data): Check for string overflow. This catches
8441 some instances we weren't catching before. Also, it catches
8442 size_t overflow on (unusual) hosts where SIZE_MAX <= min
8443 (PTRDIFF_MAX, MOST_POSITIVE_FIXNUM), e.g., when size_t is 32 bits
8444 and ptrdiff_t and EMACS_INT are both 64 bits.
c78baabf 8445
c9d624c6
PE
8446 * character.c, coding.c, doprnt.c, editfns.c, eval.c:
8447 All uses of STRING_BYTES_MAX replaced by STRING_BYTES_BOUND.
640c8776 8448 * lisp.h (STRING_BYTES_BOUND): Rename from STRING_BYTES_MAX.
c9d624c6 8449
353032ce
PE
8450 * character.c (string_escape_byte8): Fix nbytes/nchars typo.
8451
2bccce07
PE
8452 * alloc.c (Fmake_string): Check for out-of-range init.
8453
0ac30604
SM
84542011-06-15 Stefan Monnier <monnier@iro.umontreal.ca>
8455
8456 * eval.c (Fdefvaralias): Also mark the target as variable-special-p.
8457
c195f2de
JD
84582011-06-14 Jan Djärv <jan.h.d@swipnet.se>
8459
8460 * xfns.c (x_set_scroll_bar_default_width): Remove argument to
8461 xg_get_default_scrollbar_width.
8462
8463 * gtkutil.c: Include emacsgtkfixed.h if HAVE_GTK3.
8464 (int_gtk_range_get_value): Move to the scroll bar part of the file.
8465 (style_changed_cb): Call update_theme_scrollbar_width and call
8466 x_set_scroll_bar_default_width and xg_frame_set_char_size for
8467 all frames (Bug#8505).
8468 (xg_create_frame_widgets): Call emacs_fixed_new if HAVE_GTK3 (Bug#8505).
8469 Call gtk_window_set_resizable if HAVE_GTK3.
8470 (x_wm_set_size_hint): Call emacs_fixed_set_min_size with min width
8471 and height if HAVE_GTK3 (Bug#8505).
8472 (scroll_bar_width_for_theme): New variable.
8473 (update_theme_scrollbar_width): New function.
8474 (xg_get_default_scrollbar_width): Move code to
8475 update_theme_scrollbar_width, just return scroll_bar_width_for_theme.
8476 (xg_initialize): Call update_theme_scrollbar_width.
8477
8478 * gtkutil.h (xg_get_default_scrollbar_width): Remove argument.
8479
8480 * emacsgtkfixed.c, emacsgtkfixed.h: New files.
8481
e10ac9f1
MR
84822011-06-12 Martin Rudalics <rudalics@gmx.at>
8483
8484 * frame.c (make_frame): Call other_buffer_safely instead of
8485 other_buffer.
8486
8487 * window.c (temp_output_buffer_show): Call display_buffer with
8488 second argument Vtemp_buffer_show_specifiers and reset latter
8489 immediately after the call.
8490 (Vtemp_buffer_show_specifiers): New variable.
8491 (auto_window_vscroll_p, next_screen_context_lines)
8492 (Vscroll_preserve_screen_position): Remove leading asterisks from
8493 doc-strings.
8494
2d3c217e 84952011-06-12 Paul Eggert <eggert@cs.ucla.edu>
4475bec4 8496
7b7f97e8 8497 Fix minor problems found by GCC 4.6.0 static checking.
4475bec4
PE
8498 * buffer.c (Qclone_number): Remove for now, as it's unused.
8499 (record_buffer, Funrecord_buffer): Rename local to avoid shadowing.
8500 (record_buffer): Remove unused local.
8501 * frame.c (other_visible_frames, frame_buffer_list): Now static.
8502 (set_frame_buffer_list): Remove; unused.
8503 * frame.h (other_visible_frames): Remove decl.
8504 * keyboard.h (menu_items_inuse): Declare only if USE_GTK || USE_MOTIF.
8505 * lisp.h (frame_buffer_list, set_frame_buffer_list): Remove decls.
8506 (add_gpm_wait_descriptor, delete_gpm_wait_descriptor): Declare only
8507 if HAVE_GPM.
8508 * menu.c (menu_items_inuse): Now static unless USE_GTK || USE_MOTIF.
8509 * process.c (add_gpm_wait_descriptor, delete_gpm_wait_descriptor):
8510 Define only if HAVE_GPM.
8511 * widget.c (EmacsFrameResize, emacsFrameClassRec): Now static.
8512 (update_hints_inhibit): Remove; never set. All uses removed.
8513 * widgetprv.h (emacsFrameClassRec): Remove decl.
8514 * window.c (delete_deletable_window): Now returns void, since it
8515 wasn't returning anything.
8516 (compare_window_configurations): Remove unused locals.
8517 * xfns.c (x_set_scroll_bar_default_width): Remove unused locals.
8518 * xmenu.c (x_menu_set_in_use): Define only if USE_GTK || USE_MOTIF.
4475bec4
PE
8519 (dialog_selection_callback) [!USE_GTK]: Prefer intptr_t for integers
8520 the same widths as pointers. This follows up on the 2011-05-06 patch.
8521 * xterm.c (x_alloc_lighter_color_for_widget): Define only if USE_LUCID.
8522 * xterm.h: Likewise.
8523 (x_menu_set_in_use): Declare only if USE_GTK || USE_MOTIF.
8524
1384b89e
JB
85252011-06-12 Juanma Barranquero <lekktu@gmail.com>
8526
8527 * makefile.w32-in: Update dependencies.
8528 (LISP_H): Add lib/intprops.h.
8529
1100a63c
CY
85302011-06-11 Chong Yidong <cyd@stupidchicken.com>
8531
8532 * image.c (gif_load): Add animation frame delay to the metadata.
8533 (syms_of_image): Use DEFSYM. New symbol `delay'.
8534
6198ccd0
MR
85352011-06-11 Martin Rudalics <rudalics@gmx.at>
8536
8537 * window.c (delete_deletable_window): Re-add.
8538 (Fset_window_configuration): Rewrite to handle dead buffers and
8539 consequently deletable windows.
8540 (window_tree, Fwindow_tree): Remove. Supply functionality in
8541 window.el.
8542 (compare_window_configurations): Simplify code.
8543
b6e3633c
AS
85442011-06-11 Andreas Schwab <schwab@linux-m68k.org>
8545
1ab0dee5
AS
8546 * image.c (imagemagick_load_image): Fix type mismatch.
8547 (Fimagemagick_types): Likewise.
8548
b6e3633c
AS
8549 * window.h (replace_buffer_in_windows): Declare.
8550
9397e56f
MR
85512011-06-11 Martin Rudalics <rudalics@gmx.at>
8552
8553 * buffer.c: New Lisp objects Qbuffer_list_update_hook and
8554 Qclone_number. Remove external declaration of Qdelete_window.
8555 (Fbuffer_list): Rewrite doc-string. Minor restructuring of
8556 code.
640c8776
SM
8557 (Fget_buffer_create, Fmake_indirect_buffer, Frename_buffer):
8558 Run Qbuffer_list_update_hook if allowed.
9397e56f
MR
8559 (Fother_buffer): Rewrite doc-string. Major rewrite for new
8560 buffer list implementation.
8561 (other_buffer_safely): New function.
8562 (Fkill_buffer): Replace call to replace_buffer_in_all_windows by
8563 calls to replace_buffer_in_windows and
8564 replace_buffer_in_windows_safely. Run Qbuffer_list_update_hook
8565 if allowed.
8566 (record_buffer): Inhibit quitting and rewrite using quittable
8567 functions. Run Qbuffer_list_update_hook if allowed.
8568 (Frecord_buffer, Funrecord_buffer): New functions.
640c8776
SM
8569 (switch_to_buffer_1, Fswitch_to_buffer): Remove.
8570 Move switch-to-buffer to window.el.
9397e56f
MR
8571 (bury-buffer): Move to window.el.
8572 (Vbuffer_list_update_hook): New variable.
8573
8574 * lisp.h (other_buffer_safely): Add prototype in buffer.c
8575 section.
8576
8577 * window.h (resize_frame_windows): Move up in code.
8578 (Fwindow_frame): Remove EXFUN.
8579 (replace_buffer_in_all_windows): Remove prototype.
8580 (replace_buffer_in_windows_safely): Add prototype.
8581
8582 * window.c: Declare Qdelete_window static again. Move down
8583 declaration of select_count.
8584 (Fnext_window, Fprevious_window): Rewrite doc-strings.
8585 (Fother_window): Move to window.el.
8586 (window_loop): Remove DELETE_BUFFER_WINDOWS and UNSHOW_BUFFER
8587 cases. Add REPLACE_BUFFER_IN_WINDOWS_SAFELY case.
8588 (Fdelete_windows_on, Freplace_buffer_in_windows): Move to
8589 window.el.
8590 (replace_buffer_in_windows): Implement by calling
8591 Qreplace_buffer_in_windows.
8592 (replace_buffer_in_all_windows): Remove with some functionality
8593 moved into replace_buffer_in_windows_safely.
8594 (replace_buffer_in_windows_safely): New function.
8595 (select_window_norecord, select_frame_norecord): Move in front
8596 of run_window_configuration_change_hook. Remove now obsolete
8597 declarations.
640c8776
SM
8598 (Fset_window_buffer): Rewrite doc-string.
8599 Call Qrecord_window_buffer.
9397e56f
MR
8600 (keys_of_window): Move binding for other-window to window.el.
8601
b50691aa
CY
86022011-06-11 Chong Yidong <cyd@stupidchicken.com>
8603
8604 * dispextern.h (struct image): Replace data member, whose int_val
8605 and ptr_val fields were not used by anything, with a single
8606 lisp_val object.
8607
8608 * image.c (Fimage_metadata, make_image, mark_image, tiff_load)
8609 (gif_clear_image, gif_load, imagemagick_load_image)
8610 (gs_clear_image, gs_load): Callers changed.
8611
3f754b86
PE
86122011-06-10 Paul Eggert <eggert@cs.ucla.edu>
8613
cca69397
PE
8614 * buffer.h: Include <time.h>, for time_t.
8615 Needed to build on FreeBSD 8.2. Problem reported by Herbert J. Skuhra.
8616
109e28d0
PE
8617 Fix minor problems found by static checking.
8618
60737f02
PE
8619 * image.c (PixelGetMagickColor): Declare if ImageMagick headers don't.
8620
4b66faf3
PE
8621 Make identifiers static if they are not used in other modules.
8622 * data.c (Qcompiled_function, Qframe, Qvector):
8623 * image.c (QimageMagick, Qsvg):
8624 * minibuf.c (Qmetadata):
8625 * window.c (resize_window_check, resize_root_window): Now static.
8626 * window.h (resize_window_check, resize_root_window): Remove decls.
8627
109e28d0
PE
8628 * window.c (window_deletion_count, delete_deletable_window):
8629 Remove; unused.
46a4ce9e
PE
8630 (window_body_lines): Now static.
8631 (Fdelete_other_windows_internal): Mark vars as initialized.
8632 Make sure 'resize_failed' is initialized.
8633 (run_window_configuration_change_hook): Rename local to avoid shadowing.
8634 (resize_window_apply): Remove unused local.
8635 * window.h (delete_deletable_window): Remove decl.
8636
109e28d0 8637 * image.c (gif_load, svg_load_image): Rename locals to avoid shadowing.
33290528
PE
8638 (imagemagick_load_image): Fix pointer signedness problem by changing
8639 last arg from unsigned char * to char *. All uses changed.
8640 Also, fix a local for similar reasons.
8641 Remove unused locals. Remove locals to avoid shadowing.
8642 (fn_rsvg_handle_free): Remove; unused.
8643 (svg_load, svg_load_image): Fix pointer signedness problem.
f7e13da3 8644 (imagemagick_load_image): Don't use garbage pointer image_wand.
33290528 8645
3f754b86
PE
8646 * ftfont.c (ftfont_get_metrics, ftfont_drive_otf): Remove unused locals.
8647
2547adb1
CY
86482011-06-10 Chong Yidong <cyd@stupidchicken.com>
8649
8650 * image.c (gif_load): Fix omitted cast error introduced by
8651 2011-06-06 change.
8652
2c8e37d4
MR
86532011-06-10 Martin Rudalics <rudalics@gmx.at>
8654
8655 * window.h (resize_proportionally, orig_total_lines)
8656 (orig_top_line): Remove from window structure.
8657 (set_window_height, set_window_width, change_window_heights)
8658 (Fdelete_window): Remove prototypes.
8659 (resize_frame_windows): Remove duplicate declaration.
8660
440a42e3
EZ
86612011-06-10 Eli Zaretskii <eliz@gnu.org>
8662
8663 * window.h (resize_frame_windows, resize_window_check)
8664 (delete_deletable_window, resize_root_window)
8665 (resize_frame_windows): Declare prototypes.
8666
8667 * window.c (resize_window_apply): Make definition be "static" to
8668 match the prototype.
8669
562dd5e9
MR
86702011-06-10 Martin Rudalics <rudalics@gmx.at>
8671
8672 * window.c: Remove declarations of Qwindow_size_fixed,
8673 window_min_size_1, window_min_size_2, window_min_size,
8674 size_window, window_fixed_size_p, enlarge_window, delete_window.
8675 Remove static from declaration of Qdelete_window, it's
8676 temporarily needed by Fbury_buffer.
8677 (replace_window): Don't assign orig_top_line and
8678 orig_total_lines.
8679 (Fdelete_window, delete_window): Remove. Window deletion is
8680 handled by window.el.
640c8776
SM
8681 (window_loop): Remove DELETE_OTHER_WINDOWS case.
8682 Replace Fdelete_window calls with calls to Qdelete_window.
562dd5e9
MR
8683 (Fdelete_other_windows): Remove. Deleting other windows is
8684 handled by window.el.
8685 (window_fixed_size_p): Remove. Fixed-sizeness of windows is
8686 handled in window.el.
8687 (window_min_size_2, window_min_size_1, window_min_size): Remove.
8688 Window minimum sizes are handled in window.el.
8689 (shrink_windows, size_window, set_window_height)
8690 (set_window_width, change_window_heights, window_height)
8691 (window_width, CURBEG, CURSIZE, enlarge_window)
8692 (adjust_window_trailing_edge, Fadjust_window_trailing_edge)
8693 (Fenlarge_window, Fshrink_window): Remove. Window resizing is
8694 handled in window.el.
8695 (make_dummy_parent): Rename to make_parent_window and give it a
8696 second argument horflag.
8697 (make_window): Don't set resize_proportionally any more.
8698 (Fsplit_window): Remove. Windows are split in window.el.
8699 (save_restore_action, save_restore_orig_size)
8700 (shrink_window_lowest_first, save_restore_orig_size): Remove.
8701 Resize mini windows in window.el.
8702 (grow_mini_window, shrink_mini_window): Implement by calling
8703 Qresize_root_window_vertically, resize_window_check and
8704 resize_window_apply.
640c8776
SM
8705 (saved_window, Fset_window_configuration, save_window_save):
8706 Do not handle orig_top_line, orig_total_lines, and
562dd5e9
MR
8707 resize_proportionally.
8708 (window_min_height, window_min_width): Move to window.el.
8709 (keys_of_window): Move bindings for delete-other-windows,
8710 split-window, delete-window and enlarge-window to window.el.
8711
8712 * buffer.c: Temporarily extern Qdelete_window.
8713 (Fbury_buffer): Temporarily call Qdelete_window instead of
8714 Fdelete_window (Fbury_buffer will move to window.el soon).
8715
8716 * frame.c (set_menu_bar_lines_1): Remove code handling
8717 orig_top_line and orig_total_lines.
8718
8719 * dispnew.c (adjust_frame_glyphs_initially): Don't use
8720 set_window_height but set heights directly.
8721 (change_frame_size_1): Use resize_frame_windows.
8722
8723 * xdisp.c (init_xdisp): Don't use set_window_height but set
8724 heights directly.
8725
640c8776
SM
8726 * xfns.c (x_set_menu_bar_lines, x_set_tool_bar_lines):
8727 Use resize_frame_windows instead of change_window_heights and run
562dd5e9
MR
8728 run_window_configuration_change_hook.
8729
8730 * w32fns.c (x_set_tool_bar_lines): Use resize_frame_windows
8731 instead of change_window_heights and run
8732 run_window_configuration_change_hook.
8733
1a13852e
MR
87342011-06-09 Martin Rudalics <rudalics@gmx.at>
8735
8736 * window.c (replace_window): Rename second argument REPLACEMENT to
8737 NEW. New third argument SETFLAG. Rewrite.
8738 (delete_window, make_dummy_parent): Call replace_window with
8739 third argument 1.
8740 (window_list_1): Move down in code.
8741 (run_window_configuration_change_hook): Move set_buffer part
8742 before select_frame_norecord part in order to unwind correctly.
8743 Rename count1 to count.
8744 (recombine_windows, delete_deletable_window, resize_root_window)
8745 (Fdelete_other_windows_internal)
8746 (Frun_window_configuration_change_hook, make_parent_window)
8747 (resize_window_check, resize_window_apply, Fresize_window_apply)
8748 (resize_frame_windows, Fsplit_window_internal)
640c8776
SM
8749 (Fdelete_window_internal, Fresize_mini_window_internal):
8750 New functions.
1a13852e
MR
8751 (syms_of_window): New variables Vwindow_splits and Vwindow_nest.
8752
f3d1777e
MR
87532011-06-08 Martin Rudalics <rudalics@gmx.at>
8754
496e208e
MR
8755 * window.h (window): Add some new members to window structure -
8756 normal_lines, normal_cols, new_total, new_normal, clone_number,
8757 splits, nest, prev_buffers, next_buffers.
8758 (WINDOW_TOTAL_SIZE): Move here from window.c.
b9e809c2 8759 (MIN_SAFE_WINDOW_WIDTH, MIN_SAFE_WINDOW_HEIGHT): Define here.
496e208e 8760
f3d1777e
MR
8761 * window.c (Fwindow_height, Fwindow_width, Fwindow_full_width_p):
8762 Remove.
496e208e
MR
8763 (make_dummy_parent): Set new members of windows structure.
8764 (make_window): Move down in code. Handle new members of window
8765 structure.
8766 (Fwindow_clone_number, Fwindow_splits, Fset_window_splits)
8767 (Fwindow_nest, Fset_window_nest, Fwindow_new_total)
8768 (Fwindow_normal_size, Fwindow_new_normal, Fwindow_prev_buffers)
8769 (Fset_window_prev_buffers, Fwindow_next_buffers)
640c8776
SM
8770 (Fset_window_next_buffers, Fset_window_clone_number):
8771 New functions.
496e208e
MR
8772 (Fwindow_hscroll, Fwindow_at, Fwindow_point, Fwindow_start)
8773 (Fwindow_end, Fwindow_line_height, Fset_window_dedicated_p):
8774 Doc-string fixes.
8775 (Fwindow_parameters, Fwindow_parameter, Fset_window_parameter):
8776 Argument WINDOW can be now internal window too.
8777 (Fwindow_use_time): Move up in code.
8778 (Fget_buffer_window): Rename argument FRAME to ALL-FRAMES.
8779 Rewrite doc-string.
8780 (Fset_window_configuration, saved_window)
8781 (Fcurrent_window_configuration, save_window_save): Handle new
8782 members of window structure.
b9e809c2
MR
8783 (WINDOW_TOTAL_SIZE, MIN_SAFE_WINDOW_WIDTH)
8784 (MIN_SAFE_WINDOW_HEIGHT): Move to window.h.
8785 (syms_of_window): New Lisp objects Qrecord_window_buffer,
8786 Qwindow_deletable_p, Qdelete_window, Qreplace_buffer_in_windows,
8787 Qget_mru_window, Qresize_root_window,
8788 Qresize_root_window_vertically, Qsafe, Qabove, Qbelow,
8789 Qauto_buffer_name; staticpro them.
f3d1777e 8790
abde8f8c
MR
87912011-06-07 Martin Rudalics <rudalics@gmx.at>
8792
8793 * window.c (Fwindow_total_size, Fwindow_left_column)
8794 (Fwindow_top_line, window_body_lines, Fwindow_body_size)
8795 (Fwindow_list_1): New functions.
8796 (window_box_text_cols): Replace with window_body_cols.
640c8776
SM
8797 (Fwindow_width, Fscroll_left, Fscroll_right):
8798 Use window_body_cols instead of window_box_text_cols.
8799 (delete_window, Fset_window_configuration):
8800 Call delete_all_subwindows with window as argument.
fa8a67e6
MR
8801 (delete_all_subwindows): Take a window as argument and not a
8802 structure. Rewrite.
190b47e6
MR
8803 (window_loop): Remove handling of GET_LRU_WINDOW and
8804 GET_LARGEST_WINDOW.
8805 (Fget_lru_window, Fget_largest_window): Move to window.el.
abde8f8c
MR
8806
8807 * window.h: Extern window_body_cols instead of
fa8a67e6
MR
8808 window_box_text_cols. delete_all_subwindows now takes a
8809 Lisp_Object as argument.
abde8f8c 8810
640c8776
SM
8811 * indent.c (compute_motion, Fcompute_motion):
8812 Use window_body_cols instead of window_box_text_cols.
abde8f8c 8813
fa8a67e6
MR
8814 * frame.c (delete_frame): Call delete_all_subwindows with root
8815 window as argument.
8816
a54e3482
DC
88172011-06-07 Daniel Colascione <dan.colascione@gmail.com>
8818
8819 * fns.c (Fputhash): Document return value.
8820
60002bf5
CY
88212011-06-06 Chong Yidong <cyd@stupidchicken.com>
8822
8823 * image.c (gif_load): Implement gif89a spec "no disposal" method.
8824
0c671da6 88252011-06-06 Paul Eggert <eggert@cs.ucla.edu>
ccd9a01a 8826
b862a52a 8827 Cons<->int and similar integer overflow fixes (Bug#8794).
77984278 8828
be44ca6c
PE
8829 Check for overflow when converting integer to cons and back.
8830 * charset.c (Fdefine_charset_internal, Fdecode_char):
8831 Use cons_to_unsigned to catch overflow.
8832 (Fencode_char): Use INTEGER_TO_CONS.
8833 * composite.h (LGLYPH_CODE): Use cons_to_unsigned.
8834 (LGLYPH_SET_CODE): Use INTEGER_TO_CONS.
8835 * data.c (long_to_cons, cons_to_long): Remove.
8836 (cons_to_unsigned, cons_to_signed): New functions.
8837 These signal an error for invalid or out-of-range values.
8838 * dired.c (Ffile_attributes): Use INTEGER_TO_CONS.
8839 * fileio.c (Fset_visited_file_modtime): Use CONS_TO_INTEGER.
8840 * font.c (Ffont_variation_glyphs):
8841 * fontset.c (Finternal_char_font): Use INTEGER_TO_CONS.
8842 * lisp.h: Include <intprops.h>.
8843 (INTEGER_TO_CONS, CONS_TO_INTEGER): New macros.
8844 (cons_to_signed, cons_to_unsigned): New decls.
8845 (long_to_cons, cons_to_long): Remove decls.
8846 * undo.c (record_first_change): Use INTEGER_TO_CONS.
8847 (Fprimitive_undo): Use CONS_TO_INTEGER.
8848 * xfns.c (Fx_window_property): Likewise.
8849 * xselect.c: Include <limits.h>.
8850 (x_own_selection, selection_data_to_lisp_data):
8851 Use INTEGER_TO_CONS.
8852 (x_handle_selection_request, x_handle_selection_clear)
8853 (x_get_foreign_selection, Fx_disown_selection_internal)
8854 (Fx_get_atom_name, x_send_client_event): Use CONS_TO_INTEGER.
8855 (lisp_data_to_selection_data): Use cons_to_unsigned.
8856 (x_fill_property_data): Use cons_to_signed.
8857 Report values out of range.
8858
d1f3d2af
PE
8859 Check for buffer and string overflow more precisely.
8860 * buffer.h (BUF_BYTES_MAX): New macro.
8861 * lisp.h (STRING_BYTES_MAX): New macro.
8862 * alloc.c (Fmake_string):
8863 * character.c (string_escape_byte8):
8864 * coding.c (coding_alloc_by_realloc):
8865 * doprnt.c (doprnt):
8866 * editfns.c (Fformat):
8867 * eval.c (verror):
8868 Use STRING_BYTES_MAX, not MOST_POSITIVE_FIXNUM,
8869 since they may not be the same number.
8870 * editfns.c (Finsert_char):
8871 * fileio.c (Finsert_file_contents):
8872 Likewise for BUF_BYTES_MAX.
8873
dd52fcea
PE
8874 * image.c: Use ptrdiff_t, not int, for sizes.
8875 (slurp_file): Switch from int to ptrdiff_t.
8876 All uses changed.
8877 (slurp_file): Check that file size fits in both size_t (for
8878 malloc) and ptrdiff_t (for sanity and safety).
8879
7f9bbdbb
PE
8880 * fileio.c (Fverify_visited_file_modtime): Avoid time overflow
8881 if b->modtime has its maximal value.
8882
dfe18f82
PE
8883 * dired.c (Ffile_attributes): Don't assume EMACS_INT has >32 bits.
8884
84acfcf0
PE
8885 Don't assume time_t can fit into int.
8886 * buffer.h (struct buffer.modtime): Now time_t, not int.
8887 * fileio.c (Fvisited_file_modtime): No need for time_t cast now.
8888 * undo.c (Fprimitive_undo): Use time_t, not int, for time_t value.
8889
ccd9a01a
PE
8890 Minor fixes for signed vs unsigned integers.
8891 * character.h (MAYBE_UNIFY_CHAR):
8892 * charset.c (maybe_unify_char):
8893 * keyboard.c (read_char, reorder_modifiers):
8894 XINT -> XFASTINT, since the integer must be nonnegative.
8895 * ftfont.c (ftfont_spec_pattern):
8896 * keymap.c (access_keymap, silly_event_symbol_error):
8897 XUINT -> XFASTINT, since the integer must be nonnegative.
8898 (Fsingle_key_description, preferred_sequence_p): XUINT -> XINT,
8899 since it makes no difference and we prefer signed.
8900 * keyboard.c (record_char): Use XUINT when all the neighbors do.
8901 (access_keymap): NATNUMP -> INTEGERP, since the integer must be
8902 nonnegative.
8903
d6d100dd
SM
89042011-06-06 Stefan Monnier <monnier@iro.umontreal.ca>
8905
8906 * window.h (Fwindow_frame): Declare.
8907
2b6148e4
PE
89082011-06-06 Paul Eggert <eggert@cs.ucla.edu>
8909
8910 * alloc.c: Simplify handling of large-request failures (Bug#8800).
8911 (SPARE_MEMORY): Always define.
8912 (LARGE_REQUEST): Remove.
8913 (memory_full): Use SPARE_MEMORY rather than LARGE_REQUEST.
8914
f230ecc9
MR
89152011-06-06 Martin Rudalics <rudalics@gmx.at>
8916
727e958e
MR
8917 * lisp.h: Move EXFUNS for Fframe_root_window,
8918 Fframe_first_window and Fset_frame_selected_window to window.h.
8919
8920 * window.h: Move EXFUNS for Fframe_root_window,
8921 Fframe_first_window and Fset_frame_selected_window here from
8922 lisp.h.
8923
8924 * frame.c (Fwindow_frame, Fframe_first_window)
8925 (Fframe_root_window, Fframe_selected_window)
8926 (Fset_frame_selected_window): Move to window.c.
8927 (Factive_minibuffer_window): Move to minibuf.c.
8928 (Fother_visible_frames_p): New function.
8929
8930 * minibuf.c (Factive_minibuffer_window): Move here from frame.c.
8931
f230ecc9
MR
8932 * window.c (decode_window, decode_any_window): Move up in code.
8933 (Fwindowp, Fwindow_live_p): Rewrite doc-strings.
8934 (inhibit_frame_unsplittable): Remove unused variable.
bf60a96b
MR
8935 (Fwindow_buffer): Move up and rewrite doc-string.
8936 (Fwindow_parent, Fwindow_vchild, Fwindow_hchild, Fwindow_next)
8937 (Fwindow_prev): New functions.
727e958e
MR
8938 (Fwindow_frame): Move here from frame.c. Accept any window as
8939 argument.
8940 (Fframe_root_window, Fframe_first_window)
8941 (Fframe_selected_window): Move here from frame.c. Accept frame
8942 or arbitrary window as argument. Update doc-strings.
8943 (Fminibuffer_window): Move up in code.
8944 (Fwindow_minibuffer_p): Move up in code and simplify.
d6d100dd
SM
8945 (Fset_frame_selected_window): Move here from frame.c.
8946 Marginal rewrite.
727e958e
MR
8947 (Fselected_window, select_window, Fselect_window): Move up in
8948 code. Minor doc-string fixes.
f230ecc9 8949
4d09bcf6
PE
89502011-06-06 Paul Eggert <eggert@cs.ucla.edu>
8951
8952 * alloc.c (memory_full) [SYSTEM_MALLOC]: Port to MacOS (Bug#8800).
8953 Do not assume that spare memory exists; that assumption is valid
8954 only if SYSTEM_MALLOC.
8955 (LARGE_REQUEST): New macro, so that the issue of large requests
8956 is separated from the issue of spare memory.
8957
810928a2
AS
89582011-06-05 Andreas Schwab <schwab@linux-m68k.org>
8959
172418ad
AS
8960 * editfns.c (Fformat): Correctly handle zero flag with hexadecimal
8961 format. (Bug#8806)
8962
43f862f7
AS
8963 * gtkutil.c (xg_get_default_scrollbar_width): Avoid warning.
8964
810928a2
AS
8965 * xfns.c (x_set_scroll_bar_default_width): Move declarations
8966 before statements.
8967
a059fe24
JD
89682011-06-05 Jan Djärv <jan.h.d@swipnet.se>
8969
8970 * gtkutil.c (xg_get_default_scrollbar_width): New function.
8971
8972 * gtkutil.h: Declare xg_get_default_scrollbar_width.
8973
8974 * xfns.c (x_set_scroll_bar_default_width): If USE_GTK, get
8975 min width by calling x_set_scroll_bar_default_width (Bug#8505).
8976
989bf368
JB
89772011-06-05 Juanma Barranquero <lekktu@gmail.com>
8978
8979 * xdisp.c (single_display_spec_intangible_p): Remove declaration.
8980
4b80f674
CY
89812011-06-04 Chong Yidong <cyd@stupidchicken.com>
8982
8983 * xselect.c (x_clipboard_manager_save): Remove redundant arg.
8984 (x_clipboard_manager_save): Add return value.
d6d100dd
SM
8985 (x_clipboard_manager_error_1, x_clipboard_manager_error_2):
8986 New error handlers.
4b80f674
CY
8987 (x_clipboard_manager_save_frame, x_clipboard_manager_save_all):
8988 Obey Vx_select_enable_clipboard_manager. Catch errors in
8989 x_clipboard_manager_save (Bug#8779).
8990 (Vx_select_enable_clipboard_manager): New variable.
de65b42c 8991 (x_get_foreign_selection): Reduce scope of x_catch_errors (Bug#8790).
4b80f674 8992
99a33b77 89932011-06-04 Dan Nicolaescu <dann@ics.uci.edu>
8b3115e7
DN
8994
8995 * emacs.c (main): Warn when starting a GTK emacs in daemon mode.
8996
99a33b77 89972011-06-04 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
14eca62f
YM
8998
8999 * fringe.c (update_window_fringes): Don't update overlay arrow bitmap
9000 in the current matrix if keep_current_p is non-zero.
9001
8264569d
EZ
90022011-06-04 Eli Zaretskii <eliz@gnu.org>
9003
9004 * bidi.c (bidi_level_of_next_char): Fix last change.
9005
57f97249
EZ
90062011-06-03 Eli Zaretskii <eliz@gnu.org>
9007
fec2107c 9008 Support bidi reordering of text covered by display properties.
57f97249 9009
fec2107c
EZ
9010 * bidi.c (bidi_copy_it): Use offsetof instead of emulating it.
9011 (bidi_fetch_char, bidi_fetch_char_advance): New functions.
9012 (bidi_cache_search, bidi_cache_iterator_state)
9013 (bidi_paragraph_init, bidi_resolve_explicit, bidi_resolve_weak)
d6d100dd
SM
9014 (bidi_level_of_next_char, bidi_move_to_visually_next):
9015 Support character positions inside a run of characters covered by a
fec2107c
EZ
9016 display string.
9017 (bidi_paragraph_init, bidi_resolve_explicit_1)
9018 (bidi_level_of_next_char): Call bidi_fetch_char and
9019 bidi_fetch_char_advance instead of FETCH_CHAR and
9020 FETCH_CHAR_ADVANCE.
9021 (bidi_init_it): Initialize new members.
9022 (LRE_CHAR, RLE_CHAR, PDF_CHAR, LRO_CHAR, RLO_CHAR): Remove macro
9023 definitions.
9024 (bidi_explicit_dir_char): Lookup character type in bidi_type_table,
9025 instead of using explicit *_CHAR codes.
d6d100dd
SM
9026 (bidi_resolve_explicit, bidi_resolve_weak):
9027 Use FETCH_MULTIBYTE_CHAR instead of FETCH_CHAR, as reordering of
fec2107c
EZ
9028 bidirectional text is supported only in multibyte buffers.
9029 (bidi_init_it): Accept additional argument FRAME_WINDOW_P and use
9030 it to initialize the frame_window_p member of struct bidi_it.
9031 (bidi_cache_iterator_state, bidi_resolve_explicit_1)
9032 (bidi_resolve_explicit, bidi_resolve_weak)
9033 (bidi_level_of_next_char, bidi_move_to_visually_next): Abort if
9034 bidi_it->nchars is non-positive.
9035 (bidi_level_of_next_char): Don't try to lookup the cache for the
9036 next/previous character if nothing is cached there yet, or if we
9037 were just reseat()'ed to a new position.
c40e2fb2 9038
0e14fe90
EZ
9039 * xdisp.c (set_cursor_from_row): Set start and stop points
9040 according to the row's direction when priming the loop that looks
9041 for the glyph on which to display cursor.
9042 (single_display_spec_intangible_p): Function deleted.
9043 (display_prop_intangible_p): Reimplement to call
9044 handle_display_spec instead of single_display_spec_intangible_p.
d6d100dd
SM
9045 Accept 3 additional arguments needed by handle_display_spec.
9046 This fixes incorrect cursor motion across display property with complex
0e14fe90
EZ
9047 values: lists, `(when COND...)' forms, etc.
9048 (single_display_spec_string_p): Support property values that are
9049 lists with the argument STRING its top-level element.
9050 (display_prop_string_p): Fix the condition for processing a
9051 property that is a list to be consistent with handle_display_spec.
fec2107c 9052 (handle_display_spec): New function, refactored from the
fc6f18ce
EZ
9053 last portion of handle_display_prop.
9054 (compute_display_string_pos): Accept additional argument
9055 FRAME_WINDOW_P. Call handle_display_spec to determine whether the
9056 value of a `display' property is a "replacing spec".
9057 (handle_single_display_spec): Accept 2 additional arguments BUFPOS
9058 and FRAME_WINDOW_P. If IT is NULL, don't set up the iterator from
9059 the display property, but just return a value indicating whether
9060 the display property will replace the characters it covers.
9061 (Fcurrent_bidi_paragraph_direction): Initialize the nchars and
9062 frame_window_p members of struct bidi_it.
d6d100dd
SM
9063 (compute_display_string_pos, compute_display_string_end):
9064 New functions.
fec2107c
EZ
9065 (push_it): Accept second argument POSITION, where pop_it should
9066 jump to continue iteration.
9067 (reseat_1): Initialize bidi_it.disp_pos.
fc6f18ce 9068
fec2107c
EZ
9069 * keyboard.c (adjust_point_for_property): Adjust the call to
9070 display_prop_intangible_p to its new signature.
fc6f18ce
EZ
9071
9072 * dispextern.h (struct bidi_it): New member frame_window_p.
fec2107c
EZ
9073 (bidi_init_it): Update prototypes.
9074 (display_prop_intangible_p): Update prototype.
d6d100dd
SM
9075 (compute_display_string_pos, compute_display_string_end):
9076 Declare prototypes.
fec2107c
EZ
9077 (struct bidi_it): New members nchars and disp_pos. ch_len is now
9078 EMACS_INT.
fc6f18ce 9079
40087514 90802011-06-02 Paul Eggert <eggert@cs.ucla.edu>
0de4bb68 9081
57f53182
PE
9082 Malloc failure behavior now depends on size of allocation.
9083 * alloc.c (buffer_memory_full, memory_full): New arg NBYTES.
9084 * lisp.h: Change signatures accordingly.
9085 * alloc.c, buffer.c, editfns.c, menu.c, minibuf.c, xterm.c:
9086 All callers changed. (Bug#8762)
9087
9088 * gnutls.c: Use Emacs's memory allocators.
9089 Without this change, the gnutls library would invoke malloc etc.
9090 directly, which causes problems on non-SYNC_INPUT hosts, and which
9091 runs afoul of improving memory_full behavior. (Bug#8761)
9092 (fn_gnutls_global_set_mem_functions): New macro or function pointer.
9093 (emacs_gnutls_global_init): Use it to specify xmalloc, xrealloc,
9094 xfree instead of the default malloc, realloc, free.
9095 (Fgnutls_boot): No need to check for memory allocation failure,
9096 since xmalloc does that for us.
9097
ac32cd99 9098 Remove arbitrary limit of 2**31 entries in hash tables. (Bug#8771)
3870d916
PE
9099 * category.c (hash_get_category_set):
9100 * ccl.c (ccl_driver):
9101 * charset.c (Fdefine_charset_internal):
9102 * charset.h (struct charset.hash_index):
9103 * composite.c (get_composition_id, gstring_lookup_cache)
9104 (composition_gstring_put_cache):
9105 * composite.h (struct composition.hash_index):
9106 * dispextern.h (struct image.hash):
9107 * fns.c (next_almost_prime, larger_vector, cmpfn_eql)
9108 (cmpfn_equal, cmpfn_user_defined, hashfn_eq, hashfn_eql)
9109 (hashfn_equal, hashfn_user_defined, make_hash_table)
9110 (maybe_resize_hash_table, hash_lookup, hash_put)
9111 (hash_remove_from_table, hash_clear, sweep_weak_table, SXHASH_COMBINE)
9112 (sxhash_string, sxhash_list, sxhash_vector, sxhash_bool_vector)
9113 (Fsxhash, Fgethash, Fputhash, Fmaphash):
9114 * image.c (make_image, search_image_cache, lookup_image)
9115 (xpm_put_color_table_h):
9116 * lisp.h (struct Lisp_Hash_Table):
0de4bb68 9117 * minibuf.c (Ftry_completion, Fall_completions, Ftest_completion):
ac389d0c 9118 * print.c (print): Use 'EMACS_UINT' and 'EMACS_INT'
3870d916 9119 for hashes and hash indexes, instead of 'unsigned' and 'int'.
40087514
PE
9120 * alloc.c (allocate_vectorlike):
9121 Check for overflow in vector size calculations.
9122 * ccl.c (ccl_driver):
9123 Check for overflow when converting EMACS_INT to int.
0de4bb68
PE
9124 * fns.c, image.c: Remove unnecessary static decls that would otherwise
9125 need to be updated by these changes.
40087514
PE
9126 * fns.c (make_hash_table, maybe_resize_hash_table):
9127 Check for integer overflow with large hash tables.
0de4bb68
PE
9128 (make_hash_table, maybe_resize_hash_table, Fmake_hash_table):
9129 Prefer the faster XFLOAT_DATA to XFLOATINT where either will do.
9130 (SXHASH_REDUCE): New macro.
9131 (sxhash_string, sxhash_list, sxhash_vector, sxhash_bool_vector):
9132 Use it instead of discarding useful hash info with large hash values.
9133 (sxhash_float): New function.
9134 (sxhash): Use it. No more need for "& INTMASK" due to above changes.
9135 * lisp.h (FIXNUM_BITS): New macro, useful for SXHASH_REDUCE etc.
40087514
PE
9136 (MOST_NEGATIVE_FIXNUM, MOST_POSITIVE_FIXNUM, INTMASK):
9137 Rewrite to use FIXNUM_BITS, as this simplifies things.
0de4bb68
PE
9138 (next_almost_prime, larger_vector, sxhash, hash_lookup, hash_put):
9139 Adjust signatures to match updated version of code.
9140 (consing_since_gc): Now EMACS_INT, since a single hash table can
9141 use more than INT_MAX bytes.
9142
698d32e2
DN
91432011-06-01 Dan Nicolaescu <dann@ics.uci.edu>
9144
9145 Make it possible to build with GCC-4.6+ -O2 -flto.
9146
9147 * emacs.c (__malloc_initialize_hook): Mark as EXTERNALLY_VISIBLE.
9148
fd6fa53f
SM
91492011-06-01 Stefan Monnier <monnier@iro.umontreal.ca>
9150
9151 * minibuf.c (get_minibuffer, read_minibuf_unwind):
9152 Call minibuffer-inactive-mode.
9153
864db017
JB
91542011-05-31 Juanma Barranquero <lekktu@gmail.com>
9155
9156 * makefile.w32-in ($(BLD)/data.$(O), $(BLD)/editfns.$(O)):
9157 Update dependencies.
9158
2ad0baf4
DN
91592011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
9160
9161 * data.c (init_data): Remove code for UTS, this system is not
9162 supported anymore.
9163
4fcc2638
DN
91642011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
9165
9166 Don't force ./temacs to start in terminal mode.
9167
9168 * frame.c (make_initial_frame): Initialize faces in all cases, not
9169 only when CANNOT_DUMP is defined.
9170 * dispnew.c (init_display): Remove CANNOT_DUMP condition.
9171
c56e0fd5
DN
91722011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
9173
9174 * dispnew.c (add_window_display_history): Use const for the string
9175 pointer. Remove declaration, not needed.
9176
333d54da 91772011-05-31 Paul Eggert <eggert@cs.ucla.edu>
9cf9f756 9178
55d4c1b2 9179 Use 'inline', not 'INLINE'.
333d54da 9180 <http://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00914.html>
55d4c1b2
PE
9181 * alloc.c, fontset.c (INLINE): Remove.
9182 * alloc.c, bidi.c, charset.c, coding.c, dispnew.c, fns.c, image.c:
9183 * intervals.c, keyboard.c, process.c, syntax.c, textprop.c, w32term.c:
9184 * xdisp.c, xfaces.c, xterm.c: Replace all uses of INLINE with inline.
9185 * gmalloc.c (register_heapinfo): Use inline unconditionally.
9186 * lisp.h (LISP_MAKE_RVALUE): Use inline, not __inline__.
9187
738db178
DN
91882011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
9189
9190 Make it possible to run ./temacs.
9191
9192 * callproc.c (set_initial_environment): Remove CANNOT_DUMP code,
9193 syms_of_callproc does the same thing. Remove test for
9194 "initialized", do it in the caller.
9195 * emacs.c (main): Avoid calling set_initial_environment when dumping.
9196
620c53a6
SM
91972011-05-31 Stefan Monnier <monnier@iro.umontreal.ca>
9198
9199 * minibuf.c (Finternal_complete_buffer): Return `category' metadata.
9200 (read_minibuf): Use get_minibuffer.
9201 (syms_of_minibuf): Use DEFSYM.
9202 (Qmetadata): New var.
9203 * data.c (Qbuffer): Don't make it static.
9204 (syms_of_data): Use DEFSYM.
9205
e003a292
PE
92062011-05-31 Paul Eggert <eggert@cs.ucla.edu>
9207
9208 * ccl.c (CCL_CODE_RANGE): Allow negative numbers. (Bug#8751)
9209 (CCL_CODE_MIN): New macro.
9210
ed008a6d
PE
92112011-05-30 Paul Eggert <eggert@cs.ucla.edu>
9212
3687c2ef
PE
9213 * alloc.c (lisp_align_malloc): Omit unnecessary val==NULL tests.
9214
ed008a6d
PE
9215 * eval.c (Qdebug): Now static.
9216 * lisp.h (Qdebug): Remove decl. This reverts a part of the
9217 2011-04-26T11:26:05Z!dan.colascione@gmail.com that inadvertently undid part of
9218 2011-04-14T06:48:41Z!eggert@cs.ucla.edu.
9219
d66c4c7c
CY
92202011-05-29 Chong Yidong <cyd@stupidchicken.com>
9221
9222 * image.c: Various fixes to ImageMagick code comments.
9223 (Fimagemagick_types): Doc fix.
9224
5fbc2025
PE
92252011-05-29 Paul Eggert <eggert@cs.ucla.edu>
9226
0196f88a
PE
9227 Minor fixes prompted by GCC 4.6.0 warnings.
9228
9229 * xselect.c (converted_selections, conversion_fail_tag): Now static.
9230
5fbc2025
PE
9231 * emacs.c [HAVE_X_WINDOWS]: Include "xterm.h".
9232 (x_clipboard_manager_save_all): Move extern decl to ...
9233 * xterm.h: ... here, so that it can be checked for consistency.
9234
1dd3c2d9
CY
92352011-05-29 Chong Yidong <cyd@stupidchicken.com>
9236
9237 * xselect.c (x_clipboard_manager_save_frame)
9238 (x_clipboard_manager_save_all): New functions.
9239 (Fx_clipboard_manager_save): Lisp function deleted.
9240
9241 * emacs.c (Fkill_emacs): Call x_clipboard_manager_save_all.
9242 * frame.c (delete_frame): Call x_clipboard_manager_save_frame.
9243
9244 * xterm.h: Update prototype.
9245
5ba6571d
WX
92462011-05-28 William Xu <william.xwl@gmail.com>
9247
9248 * nsterm.m (ns_term_shutdown): Synchronize user defaults before
9249 exiting (Bug#8239).
9250
3eaff834
JM
92512011-05-28 Jim Meyering <meyering@redhat.com>
9252
e1900994 9253 Avoid a sign-extension bug in crypto_hash_function.
3eaff834
JM
9254 * fns.c (to_uchar): Define.
9255 (crypto_hash_function): Use it to convert some newly-signed
9256 variables to unsigned, to avoid sign-extension bugs. For example,
9257 without this change, (md5 "truc") would evaluate to
9258 45723a2aff78ff4fff7fff1114760e62 rather than the expected
9259 45723a2af3788c4ff17f8d1114760e62. Reported by Antoine Levitt in
e1900994 9260 https://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00883.html.
3eaff834 9261
0f6990a7
PE
92622011-05-27 Paul Eggert <eggert@cs.ucla.edu>
9263
9264 Integer overflow fixes.
c8a9ca5a 9265
08686060
PE
9266 * dbusbind.c: Serial number integer overflow fixes.
9267 (CHECK_DBUS_SERIAL_GET_SERIAL): New macro.
08686060
PE
9268 (Fdbus_call_method_asynchronously, xd_read_message_1): Use a float
9269 to hold a serial number that is too large for a fixnum.
9270 (Fdbus_method_return_internal, Fdbus_method_error_internal):
9271 Check for serial numbers out of range. Decode any serial number
59568bf0 9272 that was so large that it became a float. (Bug#8722)
08686060 9273
2d1fc3c7
PE
9274 * dbusbind.c: Use XFASTINT rather than XUINT, and check for nonneg.
9275 (Fdbus_call_method, Fdbus_call_method_asynchronously):
9276 Use XFASTINT rather than XUINT when numbers are nonnegative.
9277 (xd_append_arg, Fdbus_method_return_internal):
9278 (Fdbus_method_error_internal): Likewise. Also, for unsigned
9279 arguments, check that Lisp number is nonnegative, rather than
59568bf0 9280 silently wrapping negative numbers around. (Bug#8722)
30217ff0 9281 (xd_read_message_1): Don't assume dbus_uint32_t can fit in int.
59568bf0 9282 (Bug#8722)
2d1fc3c7 9283
c8a9ca5a
PE
9284 * data.c (arith_driver, Flsh): Avoid unnecessary casts to EMACS_UINT.
9285
519e1d69
PE
9286 * ccl.c (ccl_driver): Redo slightly to avoid the need for 'unsigned'.
9287
6df6ae42 9288 ccl: Add integer overflow checks.
30569699
PE
9289 * ccl.c (CCL_CODE_MAX, GET_CCL_RANGE, GET_CCL_CODE, GET_CCL_INT):
9290 (IN_INT_RANGE): New macros.
9291 (ccl_driver): Use them to check for integer overflow when
9292 decoding a CCL program. Many of the new checks are whether XINT (x)
9293 fits in int; it doesn't always, on 64-bit hosts. The new version
9294 doesn't catch all possible integer overflows, but it's an
847044ea 9295 improvement. (Bug#8719)
30569699 9296
c11285dc
PE
9297 * alloc.c (make_event_array): Use XINT, not XUINT.
9298 There's no need for unsigned here.
9299
fdccd48e
PE
9300 * mem-limits.h (EXCEEDS_LISP_PTR) [!USE_LSB_TAG]: EMACS_UINT -> uintptr_t
9301 This follows up to the 2011-05-06 change that substituted uintptr_t
9302 for EMACS_INT. This case wasn't caught back then.
9303
37910ab2
PE
9304 Rework Fformat to avoid integer overflow issues.
9305 * editfns.c: Include <float.h> unconditionally, as it's everywhere
9306 now (part of C89). Include <verify.h>.
9307 (MAX_10_EXP, CONVERTED_BYTE_SIZE): Remove; no longer needed.
9308 (pWIDE, pWIDElen, signed_wide, unsigned_wide): New defns.
9309 (Fformat): Avoid the prepass trying to compute sizes; it was only
9310 approximate and thus did not catch overflow reliably. Instead, walk
9311 through the format just once, formatting and computing sizes as we go,
9312 checking for integer overflow at every step, and allocating a larger
9313 buffer as needed. Keep track separately whether the format is
9314 multibyte. Keep only the most-recently calculated precision, rather
9315 than them all. Record whether each argument has been converted to
9316 string. Use EMACS_INT, not int, for byte and char and arg counts.
9317 Support field widths and precisions larger than INT_MAX. Avoid
9318 sprintf's undefined behavior with conversion specifications such as %#d
9319 and %.0c. Fix bug with strchr succeeding on '\0' when looking for
9320 flags. Fix bug with (format "%c" 256.0). Avoid integer overflow when
9321 formatting out-of-range floating point numbers with int
9173deec 9322 formats. (Bug#8668)
37910ab2 9323
2e6578fb
PE
9324 * lisp.h (FIXNUM_OVERFLOW_P): Work even if arg is a NaN.
9325
0ae6bdee
PE
9326 * data.c: Avoid integer truncation in expressions involving floats.
9327 * data.c: Include <intprops.h>.
9328 (arith_driver): When there's an integer overflow in an expression
9329 involving floating point, convert the integers to floating point
9330 so that the resulting value does not suffer from catastrophic
9331 integer truncation. For example, on a 64-bit host (* 4
9332 most-negative-fixnum 0.5) should yield about -4.6e+18, not zero.
9333 Do not rely on undefined behavior after integer overflow.
9334
de883a70
PE
9335 merge count_size_as_multibyte, parse_str_to_multibyte
9336 * character.c, character.h (count_size_as_multibyte):
fd6fa53f 9337 Rename from parse_str_to_multibyte; all uses changed.
de883a70
PE
9338 Check for integer overflow.
9339 * insdel.c, lisp.h (count_size_as_multibyte): Remove,
9340 since it's now a duplicate of the other. This is more of
9341 a character than a buffer op, so better that it's in character.c.
9342 * fns.c, print.c: Adjust to above changes.
9343
2ff916cb
PE
93442011-05-27 Stefan Monnier <monnier@iro.umontreal.ca>
9345
9346 * xselect.c (x_convert_selection): Yet another int/Lisp_Object mixup.
9347
f1b54466
PE
93482011-05-27 Paul Eggert <eggert@cs.ucla.edu>
9349
fb1ac845
PE
9350 * xselect.c: Fix minor problems prompted by GCC 4.6.0 warnings.
9351 (x_handle_selection_request, frame_for_x_selection): Remove unused vars.
9352 (x_clipboard_manager_save): Now static.
9353 (Fx_clipboard_manager_save): Rename local to avoid shadowing.
9354
f1b54466
PE
9355 * fns.c: Fix minor problems prompted by GCC 4.6.0 warnings.
9356 (crypto_hash_function): Now static.
9357 Fix pointer signedness problems. Avoid unnecessary initializations.
9358
a9f737ee
CY
93592011-05-27 Chong Yidong <cyd@stupidchicken.com>
9360
9361 * termhooks.h (Vselection_alist): Make it terminal-local.
9362
9363 * terminal.c (create_terminal): Initialize it.
9364
9365 * xselect.c: Support for clipboard managers.
9366 (Vselection_alist): Move to termhooks.h as terminal-local var.
9367 (LOCAL_SELECTION): New macro.
9368 (x_atom_to_symbol): Handle x_display_info_for_display fail case.
9369 (symbol_to_x_atom): Remove gratuitous arg.
9370 (x_handle_selection_request, lisp_data_to_selection_data)
9371 (x_get_foreign_selection, Fx_register_dnd_atom): Callers changed.
620c53a6
SM
9372 (x_own_selection, x_get_local_selection, x_convert_selection):
9373 New arg, specifying work frame. Use terminal-local Vselection_alist.
a9f737ee
CY
9374 (some_frame_on_display): Delete unused function.
9375 (Fx_own_selection_internal, Fx_get_selection_internal)
9376 (Fx_disown_selection_internal, Fx_selection_owner_p)
9377 (Fx_selection_exists_p): New optional frame arg.
9378 (frame_for_x_selection, Fx_clipboard_manager_save): New functions.
9379 (x_handle_selection_clear): Don't treat other terminals with the
9380 same keyboard specially. Use the terminal-local Vselection_alist.
9381 (x_clear_frame_selections): Use Frun_hook_with_args.
9382
9383 * xterm.c (x_term_init): Intern ATOM and CLIPBOARD_MANAGER atoms.
9384
9385 * xterm.h: Add support for those atoms.
9386
e067f0c1
CY
93872011-05-26 Chong Yidong <cyd@stupidchicken.com>
9388
9389 * xselect.c: ICCCM-compliant handling of MULTIPLE targets.
9390 (converted_selections, conversion_fail_tag): New global variables.
9391 (x_selection_request_lisp_error): Free the above.
9392 (x_get_local_selection): Remove unnecessary code.
9393 (x_reply_selection_request): Args changed; handle arbitrary array
620c53a6
SM
9394 of converted selections stored in converted_selections.
9395 Separate the XChangeProperty and SelectionNotify steps.
e067f0c1
CY
9396 (x_handle_selection_request): Rewrite to handle MULTIPLE target.
9397 (x_convert_selection): New function.
9398 (x_handle_selection_event): Simplify.
9399 (x_get_foreign_selection): Don't ignore incoming requests while
9400 waiting for an answer; this will fail when we implement
9401 SAVE_TARGETS, and seems unnecessary anyway.
9402 (selection_data_to_lisp_data): Recognize ATOM_PAIR type.
9403 (Vx_sent_selection_functions): Doc fix.
9404
0f4aebc0
LL
94052011-05-26 Leo Liu <sdl.web@gmail.com>
9406
9407 * editfns.c (Ftranspose_regions): Allow empty regions. (Bug#8699)
9408
e61124cd
YM
94092011-05-25 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
9410
9411 * dispextern.h (struct glyph_row): New member fringe_bitmap_periodic_p.
9412
9413 * dispnew.c (shift_glyph_matrix, scrolling_window): Mark scrolled row
9414 for fringe update if it has periodic bitmap.
ac389d0c 9415 (row_equal_p): Also compare left_fringe_offset, right_fringe_offset,
e61124cd
YM
9416 and fringe_bitmap_periodic_p.
9417
9418 * fringe.c (get_fringe_bitmap_data): New function.
9419 (draw_fringe_bitmap_1, update_window_fringes): Use it.
9420 (update_window_fringes): Record periodicity of fringe bitmap in glyph
9421 row. Mark glyph row for fringe update if periodicity changed.
9422
9423 * xdisp.c (try_window_reusing_current_matrix): Don't mark scrolled row
9424 for fringe update unless it has periodic bitmap.
9425
f16d9837
KH
94262011-05-25 Kenichi Handa <handa@m17n.org>
9427
9428 * xdisp.c (get_next_display_element): Set correct it->face_id for
9429 a static composition.
9430
e1b90ef6
LL
94312011-05-24 Leo Liu <sdl.web@gmail.com>
9432
9433 * deps.mk (fns.o):
9434 * makefile.w32-in ($(BLD)/fns.$(O)): Include sha1.h.
9435
9436 * fns.c (crypto_hash_function, Fsha1): New function.
9437 (Fmd5): Use crypto_hash_function.
9438 (syms_of_fns): Add Ssha1.
9439
7400048f
PE
94402011-05-22 Paul Eggert <eggert@cs.ucla.edu>
9441
9442 * gnutls.c: Remove unused macros.
9443 (fn_gnutls_transport_set_lowat, fn_gnutls_transport_set_pull_function):
9444 (fn_gnutls_transport_set_push_function) [!WINDOWSNT]:
9445 Remove macros that are defined and never used.
9446 Caught by gcc -Wunused-macros (GCC 4.6.0, Fedora 14).
9447
abb71cf4
CY
94482011-05-22 Chong Yidong <cyd@stupidchicken.com>
9449
9450 * xselect.c (syms_of_xselect): Remove unused symbol SAVE_TARGETS.
9451 (Fx_get_selection_internal): Minor cleanup.
9452 (Fx_own_selection_internal): Rename arguments for consistency with
9453 select.el.
9454
6307db39
PE
94552011-05-22 Paul Eggert <eggert@cs.ucla.edu>
9456
9457 * xselect.c (QSAVE_TARGETS): New static var, to fix build failure.
9458
f3d4e0a4
CY
94592011-05-22 Chong Yidong <cyd@stupidchicken.com>
9460
9461 * xselect.c (syms_of_xselect): Include character.h; use DEFSYM.
9462
4d8ade89
YM
94632011-05-21 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
9464
9465 * dispnew.c (scrolling_window): Don't exclude the case that the
9466 last enabled row in the desired matrix touches the bottom boundary.
9467
32078c8d
GM
94682011-05-21 Glenn Morris <rgm@gnu.org>
9469
9470 * Makefile.in ($(etc)/DOC): Make second command line even shorter.
33cf345f
GM
9471 (SOME_MACHINE_OBJECTS): Replace FONT_OBJ by its maximal expansion,
9472 and add some more files.
32078c8d 9473
7285dc67
EZ
94742011-05-20 Eli Zaretskii <eliz@gnu.org>
9475
9476 * callproc.c (Fcall_process) [MSDOS]: Fix arguments to
9477 report_file_error introduced by the change from 2011-05-07.
9478
89d1bd22
PE
94792011-05-20 Paul Eggert <eggert@cs.ucla.edu>
9480
9481 * systime.h (Time): Define only if emacs is defined.
9482 This is to allow ../lib-src/profile.c to be compiled on FreeBSD,
9483 where the include path doesn't have X11/X.h by default. See
9484 <http://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00561.html>.
9485
cd394be1 94862011-05-20 Kenichi Handa <handa@m17n.org>
31bfc35c
KH
9487
9488 * composite.c (find_automatic_composition): Fix previous change.
9489
b9704ad9
GM
94902011-05-20 Glenn Morris <rgm@gnu.org>
9491
9492 * lisp.mk: New file, split from Makefile.in.
9493 * Makefile.in (lisp): Move to separate file, inserted by @lisp_frag@.
9494 (shortlisp): Remove.
9495 ($(etc)/DOC): Edit lisp.mk rather than using $shortlisp.
9496
4a720484
GM
94972011-05-19 Glenn Morris <rgm@gnu.org>
9498
9499 * Makefile.in (MSDOS_SUPPORT_REAL, MSDOS_SUPPORT, NS_SUPPORT)
9500 (REAL_MOUSE_SUPPORT, GPM_MOUSE_SUPPORT, MOUSE_SUPPORT, TOOLTIP_SUPPORT)
9501 (BASE_WINDOW_SUPPORT, X_WINDOW_SUPPORT, WINDOW_SUPPORT): Remove.
9502 (lisp): Set the order to that of loadup.el.
9503 (shortlisp): Make it a copy of $lisp.
9504 (SOME_MACHINE_LISP): Remove.
9505 ($(etc)/DOC): Depend just on $lisp, not $SOME_MACHINE_LISP too.
9506 Use just $shortlisp, not $SOME_MACHINE_LISP too.
9507
a28d4396
KH
95082011-05-18 Kenichi Handa <handa@m17n.org>
9509
9510 * composite.c (CHAR_COMPOSABLE_P): Add more check for efficiency.
9511 (BACKWARD_CHAR): Wrap the arg STOP by parenthesis.
9512 (find_automatic_composition): Mostly rewrite for efficiency.
9513
a2b1fa8e
JB
95142011-05-18 Juanma Barranquero <lekktu@gmail.com>
9515
9516 * makefile.w32-in: Update dependencies.
9517
8e1f5610
CS
95182011-05-18 Christoph Scholtes <cschol2112@googlemail.com>
9519
9520 * menu.c: Include limits.h (fixes the MS-Windows build broken by
7d7d0045 9521 2011-06-18T18:49:19Z!cyd@stupidchicken.com).
8e1f5610 9522
7025ee00 95232011-05-18 Paul Eggert <eggert@cs.ucla.edu>
cb93f9be 9524
cdfa6eab
PE
9525 Fix some integer overflow issues, such as string length overflow.
9526
06d6db33
PE
9527 * insdel.c (count_size_as_multibyte): Check for string overflow.
9528
2b4560a8
PE
9529 * character.c (lisp_string_width): Check for string overflow.
9530 Use EMACS_INT, not int, for string indexes and lengths; in
9531 particular, 2nd arg is now EMACS_INT, not int. Do not crash if
9532 the resulting string length overflows an EMACS_INT; instead,
9533 report a string overflow if no precision given. When checking for
9534 precision exhaustion, use a check that cannot possibly have
9535 integer overflow. (Bug#8675)
9536 * character.h (lisp_string_width): Adjust to new signature.
9537
cb93f9be
PE
9538 * alloc.c (string_overflow): New function.
9539 (Fmake_string): Use it. This doesn't change behavior, but saves
9540 a few bytes and will simplify future changes.
9541 * character.c (string_escape_byte8): Likewise.
9542 * lisp.h (string_overflow): New decl.
9543
1a1f3366
PE
9544 Fixups, following up to the user-interface timestamp change.
9545 * nsterm.m (last_mouse_movement_time, ns_mouse_position): Use Time
9546 for UI timestamps, instead of unsigned long.
9fbd6841
PE
9547 * msdos.c (mouse_get_pos): Likewise.
9548 * w32inevt.c (movement_time, w32_console_mouse_position): Likewise.
1a1f3366
PE
9549 * w32gui.h (Time): Define by including "systime.h" rather than by
9550 declaring it ourselves. (Bug#8664)
9551
d4e3e4d3
PE
9552 * dispextern.h (struct image): Don't assume time_t <= unsigned long.
9553 * image.c (clear_image_cache): Likewise.
9554
f6a24d19
PE
9555 * term.c (term_mouse_position): Don't assume time_t wraparound.
9556
08dc5ae6
PE
9557 Be more systematic about user-interface timestamps.
9558 Before, the code sometimes used 'Time', sometimes 'unsigned long',
620c53a6
SM
9559 and sometimes 'EMACS_UINT', to represent these timestamps.
9560 This change causes it to use 'Time' uniformly, as that's what X uses.
08dc5ae6
PE
9561 This makes the code easier to follow, and makes it easier to catch
9562 integer overflow bugs such as Bug#8664.
9563 * frame.c (Fmouse_position, Fmouse_pixel_position):
9564 Use Time, not unsigned long, for user-interface timestamps.
9565 * keyboard.c (last_event_timestamp, kbd_buffer_get_event): Likewise.
9566 (button_down_time, make_lispy_position, make_lispy_movement): Likewise.
9567 * keyboard.h (last_event_timestamp): Likewise.
9568 * menu.c (Fx_popup_menu) [!HAVE_X_WINDOWS]: Likewise.
9569 * menu.h (xmenu_show): Likewise.
9570 * term.c (term_mouse_position): Likewise.
9571 * termhooks.h (struct input_event.timestamp): Likewise.
9572 (struct terminal.mouse_position_hook): Likewise.
9573 * xmenu.c (create_and_show_popup_menu, xmenu_show): Likewise.
9574 * xterm.c (XTmouse_position, x_scroll_bar_report_motion): Likewise.
9575 * systime.h (Time): New decl. Pull it in from <X11/X.h> if
9576 HAVE_X_WINDOWS, otherwise define it as unsigned long, which is
9577 what it was before.
9578 * menu.h, termhooks.h: Include "systime.h", for Time.
9579
8e55734a
PE
9580 * keyboard.c (make_lispy_event): Fix problem in integer overflow.
9581 Don't assume that the difference between two unsigned long values
9582 can fit into an integer. At this point, we know button_down_time
9583 <= event->timestamp, so the difference must be nonnegative, so
9584 there's no need to cast the result if double-click-time is
9585 nonnegative, as it should be; check that it's nonnegative, just in
9586 case. This bug is triggered when events are more than 2**31 ms
86db42d2 9587 apart (about 25 days). (Bug#8664)
8e55734a 9588
841f1b75 9589 * xselect.c (last_event_timestamp): Remove duplicate decl.
6434756c 9590 (x_own_selection): Remove needless cast to unsigned long.
841f1b75 9591
3e26f69c
PE
9592 * xmenu.c (set_frame_menubar): Use int, not EMACS_UINT, for indexes
9593 that always fit in int. Use a sentinel instead of a counter, to
9594 avoid a temp and to allay GCC's concerns about possible int overflow.
d230cb74
PE
9595 * frame.h (struct frame): Use int for menu_bar_items_used
9596 instead of EMACS_INT, since it always fits in int.
3e26f69c 9597
5cc152c0
PE
9598 * menu.c (grow_menu_items): Check for int overflow.
9599
d89eb65e
PE
9600 * xmenu.c (set_frame_menubar): Don't mishandle vectors with no nils.
9601
5235bd3e
PE
9602 * xterm.c: Use EMACS_INT for Emacs modifiers, and int for X modifiers.
9603 Before, the code was not consistent. These values cannot exceed
9604 2**31 - 1 so there's no need to make them unsigned.
9605 (x_x_to_emacs_modifiers): Accept int and return EMACS_INT.
9606 (x_emacs_to_x_modifiers): Accept EMACS_INT and return int.
9607 (x_x_to_emacs_modifiers, x_emacs_to_x_modifiers): Reject non-integers
9608 as modifiers.
9609 * xterm.h (x_x_to_emacs_modifiers): Adjust to signature change.
9610
bc827e23
PE
9611 * lisp.h (XINT) [USE_LISP_UNION_TYPE]: Cast to EMACS_INT.
9612 (XUINT) [USE_LISP_UNION_TYPE]: Cast to EMACS_UINT.
9613 Otherwise, GCC 4.6.0 warns about printf (pI, XINT (...)),
9614 presumably because the widths might not match.
9615
78eb494e
PE
9616 * window.c (size_window): Avoid needless test at loop start.
9617
04f2d78b
CB
96182011-05-18 Courtney Bane <emacs-bugs-7626@cbane.org> (tiny change)
9619
9620 * term.c (Fresume_tty): Restore hooks before reinitializing (bug#8687).
9621
d2fc7e3d 96222011-05-12 Drew Adams <drew.adams@oracle.com>
e531bdff
DA
9623
9624 * textprop.c (Fprevious_single_char_property_change): Doc fix (bug#8655).
9625
d2fc7e3d 96262011-05-12 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
7db47798
YM
9627
9628 * w32term.c (w32_draw_fringe_bitmap): Rename local vars `left' and
9629 `width' to `bar_area_x' and `bar_area_width', respectively.
9630 (x_scroll_run): Take account of fringe background extension.
9631
04f2d78b
CB
9632 * xterm.c (x_draw_fringe_bitmap) [USE_TOOLKIT_SCROLL_BARS]:
9633 Rename local vars `left' and `width' to `bar_area_x' and
7db47798
YM
9634 `bar_area_width', respectively.
9635 (x_scroll_run) [USE_TOOLKIT_SCROLL_BARS]: Take account of fringe
9636 background extension.
9637
79b70037
GM
96382011-05-10 Jim Meyering <meyering@redhat.com>
9639
9640 * xdisp.c (x_intersect_rectangles): Fix typo "the the -> the".
9641
2f142cc5
JB
96422011-05-10 Juanma Barranquero <lekktu@gmail.com>
9643
9644 * image.c (Finit_image_library): Return t for built-in image types,
9645 like pbm and xbm. (Bug#8640)
9646
57679c86
AS
96472011-05-09 Andreas Schwab <schwab@linux-m68k.org>
9648
9649 * w32menu.c (set_frame_menubar): Fix submenu allocation.
9650
888c9e86
EZ
96512011-05-07 Eli Zaretskii <eliz@gnu.org>
9652
b0512a1d
EZ
9653 * w32console.c (Fset_screen_color): Doc fix.
9654 (Fget_screen_color): New function.
9655 (syms_of_ntterm): Defsubr it.
9656
7285dc67
EZ
9657 * callproc.c (call_process_cleanup) [MSDOS]: Don't close and
9658 unlink the temporary file if Fcall_process didn't create it in the
9659 first place.
9660 (Fcall_process) [MSDOS]: Don't create tempfile if stdout of the
9661 child process will be redirected to a file specified with `:file'.
888c9e86
EZ
9662 Don't try to re-open tempfile in that case, and set fd[0] to -1 as
9663 cue to call_process_cleanup not to close that handle.
9664
4d3fcc8e
BK
96652011-05-07 Ben Key <bkey76@gmail.com>
9666
9667 * makefile.w32-in: The bootstrap-temacs rule now makes use of
9668 one of two shell specific rules, either bootstrap-temacs-CMD or
9669 bootstrap-temacs-SH. The bootstrap-temacs-SH rule is identical
9670 to the previous implementation of the bootstrap-temacs rule.
9671 The bootstrap-temacs-CMD rule is similar to the previous
9672 implementation of the bootstrap-temacs rule except that it
9673 makes use of the ESC_CFLAGS variable instead of the CFLAGS
9674 variable.
9675
9676 These changes, along with some changes to nt/configure.bat,
9677 nt/gmake.defs, and nt/nmake.defs, are required to extend my
9678 earlier fix to add support for --cflags and --ldflags options
9679 that include quotes so that it works whether make uses cmd or
9680 sh as the shell.
9681
b4289b64
MA
96822011-05-06 Michael Albinus <michael.albinus@gmx.de>
9683
9684 * dbusbind.c (QCdbus_type_unix_fd): Declare static.
9685 (xd_remove_watch): Don't check QCdbus_type_unix_fd for SYMBOLP, it
9686 is a constant.
9687 (Fdbus_init_bus, xd_read_queued_messages): Bus can be a symbol or
9688 a string. Handle both cases.
9689 (Fdbus_call_method_asynchronously, Fdbus_register_signal)
9690 (Fdbus_register_method): Use Qinvalid_function.
9691
af4c0e28
JB
96922011-05-06 Juanma Barranquero <lekktu@gmail.com>
9693
9694 * makefile.w32-in: Update dependencies.
9695 (LISP_H): Add inttypes.h and stdin.h.
9696 (PROCESS_H): Add unistd.h.
9697
c51453d9
EZ
96982011-05-06 Eli Zaretskii <eliz@gnu.org>
9699
9700 * lread.c: Include limits.h (fixes the MS-Windows build broken by
9701 2011-05-06T07:13:19Z!eggert@cs.ucla.edu).
9702
8ff0ac3c 97032011-05-06 Paul Eggert <eggert@cs.ucla.edu>
c032b5f8 9704
4c4b566b
PE
9705 * image.c (Finit_image_library) [!HAVE_NTGUI]: Omit unused local.
9706
aab2b9b5
PE
9707 * term.c (vfatal): Remove stray call to va_end.
9708 It's not needed and the C Standard doesn't allow it here anyway.
9709
c378da0b
PE
9710 Use C99's va_copy to avoid undefined behavior on x86-64 GNU/Linux.
9711 * eval.c (verror): doprnt a copy of ap, not the original. (Bug#8545)
9712
288b08c7
PE
9713 * eval.c (verror): OK to create a string of up to MOST_POSITIVE_FIXNUM
9714 bytes.
9715
e3601888
PE
9716 * term.c: Don't include <stdarg.h>, as <lisp.h> does that.
9717
db6c0e74
PE
9718 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork clobbering.
9719
dd5963ea
PE
9720 * process.c (Fformat_network_address): Fix typo: args2 -> *args2.
9721
88c9450f
PE
9722 * xmenu.c (set_frame_menubar): Fix typo: int * -> int (3 times).
9723
2f9442b8
PE
9724 * coding.c (detect_coding_charset): Fix typo: * 2 -> *4 (Bug#8601).
9725
c032b5f8
PE
9726 * charset.h (struct charset.code_space): Now has 15 elements, not 16.
9727 * charset.c (Fdefine_charset_internal): Don't initialize
9728 charset.code_space[15]. The value was garbage, on hosts with
2d38271b 9729 32-bit int (Bug#8600).
a108c10b
PE
9730
9731 * lread.c (read_integer): Be more consistent with string-to-number.
9732 Use string_to_number to do the actual conversion; this avoids
9733 rounding errors and fixes some other screwups. Without this fix,
9734 for example, #x1fffffffffffffff was misread as -2305843009213693952.
9735 (digit_to_number): Move earlier, for benefit of read_integer.
9736 Return -1 if the digit is out of range for the base, -2 if it is
48e400f0 9737 not a digit in any supported base. (Bug#8602)
a108c10b 9738
ad5f9eea
PE
9739 * doprnt.c (doprnt): Support arbitrary pI values, such as "I64".
9740
aec1708a
PE
9741 * dispnew.c (scrolling_window): Return 1 if we scrolled,
9742 to match comment at start of function. This also removes a
9743 GCC warning about overflow in a 32+64-bit port.
9744
47be4ab5
PE
9745 * lisp.h (EMACS_INT, EMACS_UINT, BITS_PER_EMACS_INT, pI): Simplify.
9746
371cac43
PE
9747 * dbusbind.c: Do not use XPNTR on a value that may be an integer.
9748 Reported by Stefan Monnier in
9749 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00919.html>.
04f2d78b
CB
9750 (xd_remove_watch, Fdbus_init_bus, xd_read_queued_messages):
9751 Use SYMBOLP-guarded XSYMBOL, not XPNTR.
371cac43 9752
d01a7826
PE
9753 * lisp.h (EMACS_INTPTR): Remove. All uses changed to intptr_t.
9754 (EMACS_UINTPTR): Likewise, with uintptr_t.
9755
7fd47d5c
PE
9756 * lisp.h: Prefer 64-bit EMACS_INT if available.
9757 (EMACS_INT, EMACS_UINT, BITS_PER_EMACS_INT, pI): Define to 64-bit
9758 on 32-bit hosts that have 64-bit int, so that they can access
9759 large files.
122b0c86
PE
9760 However, temporarily disable this change unless the temporary
9761 symbol WIDE_EMACS_INT is defined.
7fd47d5c 9762
8727937b
PE
9763 * lread.c, process.c: Do not include <inttypes.h>; lisp.h does it now.
9764
8ac068ac
PE
9765 Prefer intptr_t/uintptr_t for integers the same widths as pointers.
9766 This removes an assumption that EMACS_INT and long are the same
9767 width as pointers. The assumption is true for Emacs porting targets
9768 now, but we want to make other targets possible.
9769 * lisp.h: Include <inttypes.h>, for INTPTR_MAX, UINTPTR_MAX.
9770 (EMACS_INTPTR, EMACS_UINTPTR): New macros.
9771 In the rest of the code, change types of integers that hold casted
9772 pointers to EMACS_INTPTR and EMACS_UINTPTR, systematically
9773 replacing EMACS_INT, long, EMACS_UINT, and unsigned long.
9774 (XTYPE): Don't cast arg to EMACS_UINT; normally is not needed.
9775 (XSET): Cast type of XTYPE arg to EMACS_INTPTR; it is needed here.
9776 No need to cast type when ORing.
9777 (XPNTR): Return a value of type EMACS_INTPTR or EMACS_UINTPTR.
9778 * alloc.c (lisp_align_malloc): Remove a no-longer-needed cast.
9779 * doc.c (store_function_docstring): Use EMACS_INTPTR, so as not to
9780 assume EMACS_INT is the same width as char *.
9781 * gtkutil.c (xg_gtk_scroll_destroy, xg_tool_bar_button_cb):
9782 (xg_tool_bar_callback, xg_tool_bar_help_callback, xg_make_tool_item):
9783 Remove no-longer-needed casts.
9784 (xg_create_scroll_bar, xg_tool_bar_button_cb, xg_tool_bar_callback):
9785 (xg_tool_bar_help_callback, xg_make_tool_item):
9786 Use EMACS_INTPTR to hold an integer
9787 that will be cast to void *; this can avoid a GCC warning
9788 if EMACS_INT is not the same width as void *.
9789 * menu.c (find_and_call_menu_selection): Remove no-longer-needed cast.
9790 * xdisp.c (display_echo_area_1, resize_mini_window_1):
9791 (current_message_1, set_message_1):
9792 Use a local to convert to proper width without a cast.
9793 * xmenu.c (dialog_selection_callback): Likewise.
9794
ede49d71
PE
9795 * sysdep.c (get_random): Don't assume EMACS_INT is no wider than long.
9796 Also, don't assume VALBITS / RAND_BITS is less than 5,
9797 and don't rely on undefined behavior when shifting a 1 left into
9798 the sign bit.
9799 * lisp.h (get_random): Change signature to match.
9800
2f30ecd0
PE
9801 * lread.c (hash_string): Use size_t, not int, for hash computation.
9802 Normally we prefer signed values; but hashing is special, because
9803 it's better to use unsigned division on hash table sizes so that
9804 the remainder is nonnegative. Also, size_t is the natural width
9805 for hashing into memory. The previous code used 'int', which doesn't
9806 retain enough info to hash well into very large tables.
9807 (oblookup, oblookup_last_bucket_number, Funintern): Likewise.
9808
2a866e7b
PE
9809 * dbusbind.c: Don't possibly lose pointer info when converting.
9810 (xd_remove_watch, Fdbus_init_bus, xd_read_queued_messages):
9811 Use XPNTR rather than XHASH, so that the high-order bits of
9812 the pointer aren't lost when converting through void *.
9813
51639eac
PE
9814 * eval.c (Fautoload): Don't double-shift a pointer.
9815
92394119
PE
9816 * fns.c (Frandom): Let EMACS_UINT be wider than unsigned long.
9817
dbdb9a7c
JB
98182011-05-06 Juanma Barranquero <lekktu@gmail.com>
9819
9820 * gnutls.c (DEF_GNUTLS_FN):
9821 * image.c (DEF_IMGLIB_FN): Make function pointers static.
9822
db7a0b4f
AS
98232011-05-05 Andreas Schwab <schwab@linux-m68k.org>
9824
9825 * lread.c (lisp_file_lexically_bound_p): Stop scanning at end
9826 marker. (Bug#8610)
9827
cd394be1 98282011-05-05 Eli Zaretskii <eliz@gnu.org>
fab624aa
EZ
9829
9830 * w32heap.c (allocate_heap) [USE_LISP_UNION_TYPE || USE_LSB_TAG]:
9831 New version that can reserve upto 2GB of heap space.
9832
f7ff1b0f 98332011-05-05 Chong Yidong <cyd@stupidchicken.com>
45cb8994
CY
9834
9835 * nsfns.m (Fns_read_file_name): Doc fix (Bug#8534).
9836
639c109b
TZ
98372011-05-05 Teodor Zlatanov <tzz@lifelogs.com>
9838
9839 * gnutls.c (fn_gnutls_certificate_set_x509_key_file): Add alias to
9840 `gnutls_certificate_set_x509_key_file'.
9841
d2127135
JB
98422011-05-05 Juanma Barranquero <lekktu@gmail.com>
9843
9844 * makefile.w32-in ($(BLD)/image.$(O), $(BLD)/process.$(O)):
9845 Update dependencies.
9846
e968f4f3
JB
98472011-05-04 Juanma Barranquero <lekktu@gmail.com>
9848
9849 * gnutls.h (emacs_gnutls_write, emacs_gnutls_read):
9850 * gnutls.c (emacs_gnutls_write, emacs_gnutls_read):
9851 Remove unused parameter `fildes'.
9852 * process.c (read_process_output, send_process): Don't pass it.
9853
84d358f0
JB
98542011-05-04 Juanma Barranquero <lekktu@gmail.com>
9855
9856 Fix previous change: the library cache is defined in w32.c.
9857 * image.c (CACHE_IMAGE_TYPE) [!HAVE_NTGUI]: Define to noop.
9858 (Finit_image_library): Wrap Vlibrary_cache on "#ifdef HAVE_NTGUI".
9859
0898ca10
JB
98602011-05-04 Juanma Barranquero <lekktu@gmail.com>
9861
9862 Implement dynamic loading of GnuTLS on Windows.
9863
9864 * gnutls.h (GNUTLS_EMACS_ERROR_NOT_LOADED): New macro.
9865 (emacs_gnutls_write, emacs_gnutls_read): Mark as extern.
9866 (emacs_gnutls_record_check_pending, emacs_gnutls_transport_set_errno):
9867 Declare.
9868
9869 * gnutls.c (Qgnutls_dll): Define.
9870 (DEF_GNUTLS_FN, LOAD_GNUTLS_FN): New macros.
9871 (gnutls_*): Declare function pointers.
9872 (init_gnutls_functions): New function to initialize function pointers.
9873 (emacs_gnutls_handshake, Fgnutls_error_string, Fgnutls_deinit)
9874 (emacs_gnutls_global_init, Fgnutls_bye): Use function pointers.
9875 (emacs_gnutls_record_check_pending, emacs_gnutls_transport_set_errno):
9876 Wrappers for gnutls_record_check_pending and gnutls_transport_set_errno.
9877 (emacs_gnutls_write, emacs_gnutls_read)
9878 (emacs_gnutls_handle_error, Fgnutls_error_fatalp)
9879 (Fgnutls_available_p): New function.
9880 (Fgnutls_boot): Call Fgnutls_available_p. Use function pointers.
9881 (syms_of_gnutls) <Qgnutls_dll>: Initialize and staticpro it.
9882 (syms_of_gnutls) <Sgnutls_available_p>: defsubr it.
9883
9884 * image.c: Include w32.h.
9885 (Vimage_type_cache): Delete.
9886 (syms_of_image) <Vimage_type_cache>: Don't initialize and staticpro it.
9887 (CACHE_IMAGE_TYPE, Finit_image_library): Use Vlibrary_cache instead.
9888 (w32_delayed_load): Move to w32.c.
9889
9890 * w32.h (VlibraryCache, QCloaded_from, w32_delayed_load): Declare.
9891
9892 * w32.c (QCloaded_from, Vlibrary_cache): Define.
9893 (w32_delayed_load): Move from image.c. When loading a library, record
9894 its filename in the :loaded-from property of the library id.
9895 (globals_of_w32) <QCloaded_from, Vlibrary_cache>:
9896 Initialize and staticpro them.
9897 (emacs_gnutls_pull, emacs_gnutls_push): Call emacs_gnutls_* functions.
9898
9899 * process.c: Include lisp.h before w32.h, not after.
9900 (wait_reading_process_output): Call emacs_gnutls_record_check_pending
9901 instead of gnutls_record_check_pending.
9902
9903 * callproc.c, emacs.c: Include lisp.h before w32.h, not after.
9904
ff4de4aa
TZ
99052011-05-04 Teodor Zlatanov <tzz@lifelogs.com>
9906
9907 * gnutls.c (Fgnutls_boot): Support :keylist and :crlfiles options
9908 instead of :keyfiles. Give GnuTLS the keylist and the CRL lists
9909 as passed in.
9910
abe95abb
JD
99112011-05-03 Jan Djärv <jan.h.d@swipnet.se>
9912
9913 * xterm.c (x_set_frame_alpha): Do not set property on anything
9914 else than FRAME_X_OUTER_WINDOW (Bug#8608).
9915
e16e55d4
JB
99162011-05-02 Juanma Barranquero <lekktu@gmail.com>
9917
9918 * sysdep.c (get_tty_size) [WINDOWSNT]: Implement. (Bug#8596)
9919
bafcf6a5
JB
99202011-05-02 Juanma Barranquero <lekktu@gmail.com>
9921
9922 * gnutls.c (Qgnutls_log_level, Qgnutls_code, Qgnutls_anon)
9923 (Qgnutls_x509pki, Qgnutls_e_interrupted, Qgnutls_e_again)
9924 (Qgnutls_e_invalid_session, Qgnutls_e_not_ready_for_handshake)
9925 (gnutls_global_initialized, Qgnutls_bootprop_priority)
9926 (Qgnutls_bootprop_trustfiles, Qgnutls_bootprop_keyfiles)
9927 (Qgnutls_bootprop_callbacks, Qgnutls_bootprop_loglevel)
9928 (Qgnutls_bootprop_hostname, Qgnutls_bootprop_verify_flags)
9929 (Qgnutls_bootprop_verify_error, Qgnutls_bootprop_verify_hostname_error)
9930 (Qgnutls_bootprop_callbacks_verify): Make static.
9931
e7a6747f
AS
99322011-05-01 Andreas Schwab <schwab@linux-m68k.org>
9933
19ed11ba
AS
9934 * callproc.c: Indentation fixup.
9935
e7a6747f 9936 * sysdep.c (wait_for_termination_1): Make static.
04f2d78b
CB
9937 (wait_for_termination, interruptible_wait_for_termination):
9938 Move after wait_for_termination_1.
e7a6747f 9939
1ef14cb4
LMI
99402011-05-01 Lars Magne Ingebrigtsen <larsi@gnus.org>
9941
9942 * sysdep.c (interruptible_wait_for_termination): New function
9943 which is like wait_for_termination, but allows keyboard
9944 interruptions.
9945
9946 * callproc.c (Fcall_process): Add (:file "file") as an option for
9947 the STDOUT buffer.
9948 (Fcall_process_region): Ditto.
9949
330d880c
EZ
99502011-04-30 Eli Zaretskii <eliz@gnu.org>
9951
8db90b73
EZ
9952 * dosfns.c (Fint86, Fdos_memget, Fdos_memput): Use `ASIZE (FOO)'
9953 rather than `XVECTOR (FOO)->size'.
9954
330d880c
EZ
9955 * process.c: Remove HAVE_INTTYPES_H condition from inclusion of
9956 inttypes.h, as a gnulib replacement is used if it not available in
9957 system headers.
9958
15cbd324
EZ
99592011-04-21 Eli Zaretskii <eliz@gnu.org>
9960
9961 Lift the MOST_POSITIVE_FIXNUM/4 limitation on visited files.
9962 * fileio.c (Finsert_file_contents): Don't limit file size to 1/4
9963 of MOST_POSITIVE_FIXNUM. (Bug#8528)
9964
9965 * coding.c (coding_alloc_by_realloc): Error out if destination
9966 will grow beyond MOST_POSITIVE_FIXNUM.
9967 (decode_coding_emacs_mule): Abort if there isn't enough place in
9968 charbuf for the composition carryover bytes. Reserve an extra
9969 space for up to 2 characters produced in a loop.
9970 (decode_coding_iso_2022): Abort if there isn't enough place in
9971 charbuf for the composition carryover bytes.
9972
99732011-04-21 Eli Zaretskii <eliz@gnu.org>
afda1437 9974
ae940cca
EZ
9975 * doprnt.c (doprnt) [!HAVE_LONG_LONG_INT]: Error out instead of
9976 aborting when %lld or %lll format is passed.
9977 [!HAVE_UNSIGNED_LONG_LONG_INT]: Error out instead of aborting when
9978 %llo or %llx format is passed. (Bug#8545)
9979
03ab8921
EZ
9980 * window.c (window_scroll_line_based): Use a marker instead of
9981 simple variables to record original value of point. (Bug#7952)
9982
afda1437
EZ
9983 * doprnt.c (doprnt): Fix the case where a multibyte sequence
9984 produced by %s or %c overflows available buffer space. (Bug#8545)
9985
f76dee0c
PE
99862011-04-28 Paul Eggert <eggert@cs.ucla.edu>
9987
9988 * doprnt.c (doprnt): Omit useless test; int overflow check (Bug#8545).
283cdbef 9989 (SIZE_MAX): Move defn after all includes, as they might #define it.
f76dee0c 9990
fdc5744d
JB
99912011-04-28 Juanma Barranquero <lekktu@gmail.com>
9992
9993 * w32.c (init_environment): Warn about defaulting HOME to C:\.
9994
638f053a
JB
99952011-04-28 Juanma Barranquero <lekktu@gmail.com>
9996
9997 * keyboard.c (Qdelayed_warnings_hook): Define.
9998 (command_loop_1): Run `delayed-warnings-hook'
9999 if Vdelayed_warnings_list is non-nil.
10000 (syms_of_keyboard) <delayed-warnings-hook>: DEFSYM it.
10001 (syms_of_keyboard) <delayed-warnings-list>: DEFVAR_LISP it.
10002
d178f871
EZ
100032011-04-28 Eli Zaretskii <eliz@gnu.org>
10004
10005 * doprnt.c (doprnt): Don't return value smaller than the buffer
10006 size if the message was truncated. (Bug#8545).
10007
b124fd93
JB
100082011-04-28 Juanma Barranquero <lekktu@gmail.com>
10009
10010 * w32fns.c (Fx_change_window_property, Fx_delete_window_property)
10011 (Fx_window_property): #if-0 the whole functions, not just the bodies.
10012
e810457d
PE
100132011-04-27 Paul Eggert <eggert@cs.ucla.edu>
10014
10015 * doprnt.c (doprnt): Support "ll" length modifier, for long long.
10016
ea51cceb
JB
100172011-04-27 Juanma Barranquero <lekktu@gmail.com>
10018
10019 * makefile.w32-in: Update dependencies.
10020
94dcfacf
EZ
100212011-04-27 Eli Zaretskii <eliz@gnu.org>
10022
10023 Improve `doprnt' and its usage. (Bug#8545)
10024 * doprnt.c (doprnt): Make sure `format' is never accessed beyond
10025 `format_end'. Remove support for %l as a conversion specifier.
10026 Don't use xrealloc. Improve diagnostics when the %l size modifier
10027 is used. Update the commentary.
10028
10029 * eval.c (verror): Simplify calculation of size_t.
10030
10031 * coding.c (Ffind_operation_coding_system): Fix diagnostic error
10032 messages.
10033
f61f41d7
PE
100342011-04-27 Yoshiaki Kasahara <kasahara@nc.kyushu-u.ac.jp> (tiny change)
10035
10036 * buffer.c (init_buffer) [USE_MMAP_FOR_BUFFERS]: Adjust to aliasing
10037 change.
10038
96fb4434
PE
100392011-04-27 Paul Eggert <eggert@cs.ucla.edu>
10040
10041 * nsmenu.m: Replace all uses of XVECTOR with ASIZE and AREF.
10042 This makes this file independent of the recent pseudovector change.
10043
671875da 100442011-04-26 Paul Eggert <eggert@cs.ucla.edu>
eab3844f 10045
69e9b5a3
PE
10046 * keyboard.c (handle_user_signal): Fix pointer signedness problem.
10047
b5f869a7 10048 * gnutls.c (emacs_gnutls_handle_error): Remove unused local.
7754e151 10049 (Fgnutls_boot): gnutls_certificate_verify_peers2 wants unsigned *.
8d4c3955 10050 Remove unused local.
c8926152 10051 (emacs_gnutls_write): Don't use uninitialized rtnval if nbyte <= 0.
080e5a8d 10052
841a1577 10053 * lisp.h: Fix a problem with aliasing and vector headers. (Bug#8546)
04f2d78b
CB
10054 GCC 4.6.0 optimizes based on type-based alias analysis.
10055 For example, if b is of type struct buffer * and v of type struct
eab3844f
PE
10056 Lisp_Vector *, then gcc -O2 was incorrectly assuming that &b->size
10057 != &v->size, and therefore "v->size = 1; b->size = 2; return
10058 v->size;" must therefore return 1. This assumption is incorrect
10059 for Emacs, since it type-puns struct Lisp_Vector * with many other
10060 types. To fix this problem, this patch adds a new type struct
f904488f 10061 vectorlike_header that documents the constraints on layout of vectors
eab3844f
PE
10062 and pseudovectors, and helps optimizing compilers not get fooled
10063 by Emacs's type punning. It also adds the macros XSETTYPED_PVECTYPE
10064 XSETTYPED_PSEUDOVECTOR, TYPED_PSEUDOVECTORP, for similar reasons.
f904488f
PE
10065 * lisp.h (XSETTYPED_PVECTYPE): New macro, specifying the name of
10066 the size member.
eab3844f
PE
10067 (XSETPVECTYPE): Rewrite in terms of new macro.
10068 (XSETPVECTYPESIZE): New macro, specifying both type and size.
10069 This is a bit clearer, and further avoids the possibility of
10070 undesirable aliasing.
10071 (XSETTYPED_PSEUDOVECTOR): New macro, specifying the size.
f904488f 10072 (XSETPSEUDOVECTOR): Rewrite in terms of XSETTYPED_PSEUDOVECTOR.
eab3844f
PE
10073 (XSETSUBR): Rewrite in terms of XSETTYPED_PSEUDOVECTOR and XSIZE,
10074 since Lisp_Subr is a special case (no "next" field).
04f2d78b
CB
10075 (ASIZE): Now uses header.size rather than size.
10076 All previous uses of XVECTOR (foo)->size replaced to use this macro,
f904488f
PE
10077 to avoid the hassle of writing XVECTOR (foo)->header.size.
10078 (struct vectorlike_header): New type.
eab3844f
PE
10079 (TYPED_PSEUDOVECTORP): New macro, also specifying the C type of the
10080 object, to help avoid aliasing.
10081 (PSEUDOVECTORP): Rewrite in terms of TYPED_PSEUDOVECTORP.
10082 (SUBRP): Likewise, since Lisp_Subr is a special case.
10083 * lisp.h (struct Lisp_Vector, struct Lisp_Char_Table):
10084 (struct Lisp_Sub_Char_Table, struct Lisp_Bool_Vector):
10085 (struct Lisp_Hash_Table): Combine first two members into a single
f904488f 10086 struct vectorlike_header member. All uses of "size" and "next" members
eab3844f
PE
10087 changed to be "header.size" and "header.next".
10088 * buffer.h (struct buffer): Likewise.
10089 * font.h (struct font_spec, struct font_entity, struct font): Likewise.
10090 * frame.h (struct frame): Likewise.
10091 * process.h (struct Lisp_Process): Likewise.
10092 * termhooks.h (struct terminal): Likewise.
10093 * window.c (struct save_window_data, struct saved_window): Likewise.
10094 * window.h (struct window): Likewise.
10095 * alloc.c (allocate_buffer, Fmake_bool_vector, allocate_pseudovector):
10096 Use XSETPVECTYPESIZE, not XSETPVECTYPE, to avoid aliasing problems.
10097 * buffer.c (init_buffer_once): Likewise.
10098 * lread.c (defsubr): Use XSETTYPED_PVECTYPE, since Lisp_Subr is a
10099 special case.
10100 * process.c (Fformat_network_address): Use local var for size,
10101 for brevity.
10102
0df1eac5
PE
10103 * bytecode.c (exec_byte_code): Don't use XVECTOR before CHECK_VECTOR.
10104
847ab9d1 10105 Make the Lisp reader and string-to-float more consistent (Bug#8525)
452f4150
PE
10106 * data.c (atof): Remove decl; no longer used or needed.
10107 (digit_to_number): Move to lread.c.
10108 (Fstring_to_number): Use new string_to_number function, to be
10109 consistent with how the Lisp reader treats infinities and NaNs.
10110 Do not assume that floating-point numbers represent EMACS_INT
10111 without losing information; this is not true on most 64-bit hosts.
10112 Avoid double-rounding errors, by insisting on integers when
10113 parsing non-base-10 numbers, as the documentation specifies.
10114 * lisp.h (string_to_number): New decl, replacing ...
10115 (isfloat_string): Remove.
bc0a5c13 10116 * lread.c: Include <inttypes.h>, for uintmax_t and strtoumax.
d78050d6 10117 (read1): Do not accept +. and -. as integers; this
452f4150
PE
10118 appears to have been a coding error. Similarly, do not accept
10119 strings like +-1e0 as floating point numbers. Do not report
10120 overflow for integer overflows unless the base is not 10 which
10121 means we have no simple and reliable way to continue.
10122 Break out the floating-point parsing into a new
10123 function string_to_number, so that Fstring_to_number parses
10124 floating point numbers consistently with the Lisp reader.
04f2d78b 10125 (digit_to_number): Move here from data.c. Make it static inline.
452f4150
PE
10126 (E_CHAR, EXP_INT): Remove, replacing with ...
10127 (E_EXP): New macro, to solve the "1.0e+" problem mentioned below.
10128 (string_to_number): New function, replacing isfloat_string.
10129 This function checks for valid syntax and produces the resulting
10130 Lisp float number too. Rework it so that string-to-number
bc0a5c13 10131 no longer mishandles examples like "1.0e+". Use strtoumax,
d78050d6
PE
10132 so that overflow for non-base-10 numbers is reported only when
10133 there's no portable and simple way to convert to floating point.
452f4150 10134
67769ffc
PE
10135 * textprop.c (set_text_properties_1): Rewrite for clarity,
10136 and to avoid GCC warning about integer overflow.
10137
c20db43f
PE
10138 * intervals.h (struct interval): Use EMACS_INT for members
10139 where EMACS_UINT might cause problems. See
10140 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00514.html>.
10141 (CHECK_TOTAL_LENGTH): Remove cast to EMACS_INT; no longer needed.
10142 * intervals.c (interval_deletion_adjustment): Now returns EMACS_INT.
10143 All uses changed.
37aa2f85
PE
10144 (offset_intervals): Tell GCC not to worry about length overflow
10145 when negating a negative length.
c20db43f 10146
2538aa2f
PE
10147 * alloc.c (overrun_check_malloc, overrun_check_realloc): Now static.
10148 (overrun_check_free): Likewise.
10149
f2d3008d
PE
10150 * alloc.c (SDATA_SIZE) [!GC_CHECK_STRING_BYTES]: Avoid runtime check
10151 in the common case where SDATA_DATA_OFFSET is a multiple of Emacs
10152 word size.
10153
ec8df744
PE
10154 * gnutls.c: Fix problems found by GCC 4.6.0 on Ubuntu 10.10.
10155 (gnutls_make_error): Rename local to avoid shadowing.
10156 (gnutls_emacs_global_deinit): ifdef out; not used.
10157 (Fgnutls_boot): Use const for pointer to readonly storage.
10158 Comment out unused local. Fix pointer signedness problems.
10159
640ee02d
PE
10160 * lread.c (openp): Don't stuff size_t into an 'int'.
10161 Use <= on length, not < on length + 1, to avoid GCC 4.6.0 warning
10162 about possible signed overflow.
10163
6048fb2a
PE
10164 * gtkutil.c: Fix problems found by GCC 4.6.0 on Ubuntu 10.10.
10165 (GDK_KEY_g): Don't define if already defined.
10166 (xg_prepare_tooltip): Avoid pointer signedness problem.
10167 (xg_set_toolkit_scroll_bar_thumb): Redo to avoid two casts.
10168
fa3c87e1
PE
10169 * process.c (Fnetwork_interface_info): Avoid left-shift undefined
10170 behavior with 1 << 31. GCC 4.6.0 warns about this on 32-bit hosts.
10171
2172544b
PE
10172 * xfns.c (Fx_window_property): Simplify a bit,
10173 to make a bit faster and to avoid GCC 4.6.0 warning.
10174 * xselect.c (x_get_window_property, x_handle_dnd_message): Likewise.
10175
9b821a21
PE
10176 * fns.c (internal_equal): Don't assume size_t fits in int.
10177
3c616cfa
PE
10178 * alloc.c (compact_small_strings): Tighten assertion a little.
10179
c2982e87
PE
10180 Replace pEd with more-general pI, and fix some printf arg casts.
10181 * lisp.h (pI): New macro, generalizing old pEd macro to other
10182 conversion specifiers. For example, use "...%"pI"d..." rather
10183 than "...%"pEd"...".
10184 (pEd): Remove. All uses replaced with similar uses of pI.
61bdb816 10185 * m/amdx86-64.h, m/ia64.h, m/ibms390x.h: Likewise.
c2982e87
PE
10186 * alloc.c (check_pure_size): Don't overflow by converting size to int.
10187 * bidi.c (bidi_dump_cached_states): Use pI to avoid cast.
10188 * data.c (Fnumber_to_string): Use pI instead of if-then-else-abort.
10189 * dbusbind.c (xd_append_arg): Use pI to avoid cast.
10190 (Fdbus_method_return_internal, Fdbus_method_error_internal): Likewise.
10191 * font.c (font_unparse_xlfd): Avoid potential buffer overrun on
10192 64-bit hosts.
10193 (font_unparse_xlfd, font_unparse_fcname): Use pI to avoid casts.
10194 * keyboard.c (record_char, modify_event_symbol): Use pI to avoid casts.
10195 * print.c (safe_debug_print, print_object): Likewise.
10196 (print_object): Don't overflow by converting EMACS_INT or EMACS_UINT
10197 to int.
6f04d126
PE
10198 Use pI instead of if-then-else-abort. Use %p to avoid casts,
10199 avoiding the 0 flag, which is not portable.
c2982e87
PE
10200 * process.c (Fmake_network_process): Use pI to avoid cast.
10201 * region-cache.c (pp_cache): Likewise.
10202 * xdisp.c (decode_mode_spec): Likewise.
10203 * xrdb.c (x_load_resources) [USE_MOTIF]: Use pI to avoid undefined
10204 behavior on 64-bit hosts with printf arg.
6f04d126 10205 * xselect.c (x_queue_event): Use %p to avoid casts, avoiding 0 flag.
c2982e87
PE
10206 (x_stop_queuing_selection_requests): Likewise.
10207 (x_get_window_property): Don't truncate byte count to an 'int'
10208 when tracing.
0b432f21 10209
5e073ec7
PE
10210 * frame.c (frame_name_fnn_p): Get rid of strtol, which isn't right
10211 here, since it parses constructs like leading '-' and spaces,
10212 which are not wanted; and it overflows with large numbers.
10213 Instead, simply match F[0-9]+, which is what is wanted anyway.
10214
36372bf9
PE
10215 * alloc.c: Remove unportable assumptions about struct layout.
10216 (SDATA_SELECTOR, SDATA_DATA_OFFSET): New macros.
10217 (SDATA_OF_STRING, SDATA_SIZE, allocate_string_data):
10218 (allocate_vectorlike, make_pure_vector): Use the new macros,
10219 plus offsetof, to remove unportable assumptions about struct layout.
10220 These assumptions hold on all porting targets that I know of, but
10221 they are not guaranteed, they're easy to remove, and removing them
10222 makes further changes easier.
10223
0b432f21
PE
10224 * alloc.c (BLOCK BYTES): Fix typo by changing "ablock" to "ablocks".
10225 This doesn't fix a bug but makes the code clearer.
bfd1c781
PE
10226 (string_overrun_cookie): Now const. Use initializers that
10227 don't formally overflow signed char, to avoid warnings.
000098c1
PE
10228 (allocate_string_data) [GC_CHECK_STRING_OVERRUN]: Fix typo that
10229 can cause Emacs to crash when string overrun checking is enabled.
c7bda33c
PE
10230 (allocate_buffer): Don't assume sizeof (struct buffer) is a
10231 multiple of sizeof (EMACS_INT); it need not be, if
10232 alignof(EMACS_INT) < sizeof (EMACS_INT).
d0f4e1f5 10233 (check_sblock, check_string_bytes, check_string_free_list): Protoize.
0b432f21 10234
895009e1
JB
102352011-04-26 Juanma Barranquero <lekktu@gmail.com>
10236
10237 * keyboard.c (QCrtl): Rename from Qrtl. All uses changed.
10238
6a7a1b0b
TZ
102392011-04-26 Teodor Zlatanov <tzz@lifelogs.com>
10240
10241 * gnutls.c (emacs_gnutls_handshake): Return an error if we're not
b5f869a7 10242 supposed to be handshaking. (Bug#8556)
6a7a1b0b
TZ
10243 Reported by Paul Eggert <eggert@cs.ucla.edu>.
10244
841a1577 102452011-04-26 Daniel Colascione <dan.colascione@gmail.com>
0438ce91
DC
10246
10247 * lisp.h (Qdebug): List symbol.
895009e1 10248 * eval.c (Qdebug): Restore global linkage.
0438ce91
DC
10249 * keyboard.c (debug-on-event): New variable.
10250 (handle_user_signal): Break into debugger when debug-on-event
10251 matches the current signal symbol.
10252
f2d3ba6f
DN
102532011-04-25 Dan Nicolaescu <dann@ics.uci.edu>
10254
10255 * alloc.c (check_sblock, check_string_bytes)
10256 (check_string_free_list): Convert to standard C.
10257
42ce4c63
TZ
102582011-04-25 Teodor Zlatanov <tzz@lifelogs.com>
10259
10260 * w32.c (emacs_gnutls_push): Fix typo.
10261
825cd63c
EZ
102622011-04-25 Eli Zaretskii <eliz@gnu.org>
10263
fb11d64d
EZ
10264 * gnutls.c (emacs_gnutls_handshake): Avoid compiler warnings about
10265 "cast to pointer from integer of different size".
10266
825cd63c
EZ
10267 Improve doprnt and its use in verror. (Bug#8545)
10268 * doprnt.c (doprnt): Document the set of format control sequences
10269 supported by the function. Use SAFE_ALLOCA instead of always
10270 using `alloca'.
10271
10272 * eval.c (verror): Don't limit the buffer size at size_max-1, that
10273 is one byte too soon. Don't use xrealloc; instead xfree and
10274 xmalloc anew.
10275
e061a11b
TZ
102762011-04-24 Teodor Zlatanov <tzz@lifelogs.com>
10277
10278 * gnutls.h: Add GNUTLS_STAGE_CALLBACKS enum to denote we're in the
10279 callbacks stage.
10280
10281 * gnutls.c: Renamed global_initialized to
10282 gnutls_global_initialized. Added internals for the
10283 :verify-hostname-error, :verify-error, and :verify-flags
10284 parameters of `gnutls-boot' and documented those parameters in the
10285 docstring. Start callback support.
9173deec
JB
10286 (emacs_gnutls_handshake): Add Woe32 support. Retry handshake
10287 unless a fatal error occurred. Call gnutls_alert_send_appropriate
10288 on error. Return error code.
e061a11b
TZ
10289 (emacs_gnutls_write): Call emacs_gnutls_handle_error.
10290 (emacs_gnutls_read): Likewise.
10291 (Fgnutls_boot): Return handshake error code.
10292 (emacs_gnutls_handle_error): New function.
10293 (wsaerror_to_errno): Likewise.
10294
10295 * w32.h (emacs_gnutls_pull): Add prototype.
10296 (emacs_gnutls_push): Likewise.
10297
10298 * w32.c (emacs_gnutls_pull): New function for GnuTLS on Woe32.
10299 (emacs_gnutls_push): Likewise.
10300
103012011-04-24 Claudio Bley <claudio.bley@gmail.com> (tiny change)
10302
10303 * process.c (wait_reading_process_output): Check if GnuTLS
10304 buffered some data internally if no FDs are set for TLS
10305 connections.
10306
10307 * makefile.w32-in (OBJ2): Add gnutls.$(O).
10308 (LIBS): Link to USER_LIBS.
10309 ($(BLD)/gnutls.$(0)): New target.
10310
fa6996bc
EZ
103112011-04-24 Eli Zaretskii <eliz@gnu.org>
10312
eb35682e
EZ
10313 * xdisp.c (handle_single_display_spec): Rename the
10314 display_replaced_before_p argument into display_replaced_p, to
10315 make it consistent with the commentary. Fix typos in the
10316 commentary.
10317
e2ad650c
EZ
10318 * textprop.c (syms_of_textprop): Remove dead code.
10319 (copy_text_properties): Delete obsolete commentary about an
10320 interface that was deleted long ago. Fix typos in the description
10321 of arguments.
10322
1b2de274
EZ
10323 * msdos.c (XMenuActivate, XMenuAddSelection): Adjust argument list
10324 to changes in oldXMenu/XMenu.h from 2011-04-16.
10325 <menu_help_message, prev_menu_help_message>: Constify.
10326 (IT_menu_make_room): menu->help_text is now `const char **';
10327 adjust.
10328
10329 * msdos.h (XMenuActivate, XMenuAddSelection): Adjust prototypes
10330 to changes in oldXMenu/XMenu.h from 2011-04-16.
10331 (struct XMenu): Declare `help_text' `const char **'.
10332
10333 * xfaces.c <Qunspecified>: Make extern again.
10334
10335 * syntax.c: Include sys/types.h before including regex.h, as
75f1671a 10336 required by POSIX.
1b2de274 10337
762b15be
EZ
10338 * doc.c (get_doc_string): Improve the format passed to `error'.
10339
10340 * doprnt.c (doprnt): Improve commentary.
10341
10342 * term.c (init_tty) [MSDOS]: Fix 1st argument to maybe_fatal.
10343
10344 * Makefile.in (TAGS): Depend on $(M_FILE) and $(S_FILE), and scan
10345 them with etags.
10346
f1052e5d
EZ
10347 * makefile.w32-in (globals.h): Add a dummy recipe, to make any
10348 changes in globals.h immediately force recompilation.
762b15be
EZ
10349 (TAGS): Depend on $(CURDIR)/m/intel386.h and
10350 $(CURDIR)/s/ms-w32.h.
10351 (TAGS-gmake): Scan $(CURDIR)/m/intel386.h and $(CURDIR)/s/ms-w32.h.
f1052e5d 10352
fa6996bc
EZ
10353 * character.c (Fchar_direction): Function deleted.
10354 (syms_of_character): Don't defsubr it.
10355 <char-direction-table>: Deleted.
10356
e6c3da20
EZ
103572011-04-23 Eli Zaretskii <eliz@gnu.org>
10358
10359 Fix doprnt so it could be used again safely in `verror'. (Bug#8435)
10360 * doprnt.c: Include limits.h.
10361 (SIZE_MAX): New macro.
04f2d78b
CB
10362 (doprnt): Return a size_t value. 2nd arg is now size_t.
10363 Many local variables are now size_t instead of int or unsigned.
e6c3da20
EZ
10364 Improve overflow protection. Support `l' modifier for integer
10365 conversions. Support %l conversion. Don't assume an EMACS_INT
10366 argument for integer conversions and for %c.
10367
10368 * lisp.h (doprnt): Restore prototype.
10369
10370 * makefile.w32-in ($(BLD)/callint.$(O)): Depend on
10371 $(SRC)/character.h.
10372
10373 * Makefile.in (base_obj): Add back doprnt.o.
10374
10375 * deps.mk (doprnt.o): Add back prerequisites.
10376 (callint.o): Depend on character.h.
10377
10378 * eval.c (internal_lisp_condition_case): Include the handler
10379 representation in the error message.
10380 (verror): Call doprnt instead of vsnprintf. Fix an off-by-one bug
10381 when breaking from the loop.
10382
10383 * xdisp.c (vmessage): Call doprnt instead of vsnprintf.
10384
10385 * callint.c (Fcall_interactively): When displaying error message
10386 about invalid control letter, pass the character's codepoint, not
10387 a pointer to its multibyte form. Improve display of the character
10388 in octal and display also its hex code.
10389
10390 * character.c (char_string): Use %x to display the (unsigned)
10391 codepoint of an invalid character, to avoid displaying a bogus
10392 negative value.
10393
10394 * font.c (check_otf_features): Pass SDATA of SYMBOL_NAME to
10395 `error', not SYMBOL_NAME itself.
10396
10397 * coding.c (Fencode_sjis_char, Fencode_big5_char): Use %c for
10398 character arguments to `error'.
10399
10400 * charset.c (check_iso_charset_parameter): Fix incorrect argument
10401 to `error' in error message about FINAL_CHAR argument. Make sure
10402 FINAL_CHAR is a character, and use %c when it is passed as
10403 argument to `error'.
10404
4ffd0d6b 104052011-04-23 Eli Zaretskii <eliz@gnu.org>
97a93095
EZ
10406
10407 * s/ms-w32.h (localtime): Redirect to sys_localtime.
10408
10409 * w32.c: Include <time.h>.
10410 (sys_localtime): New function.
10411
4ffd0d6b 104122011-04-23 Chong Yidong <cyd@stupidchicken.com>
c17819f4
CY
10413
10414 * xdisp.c (init_xdisp): Initialize echo_area_window (Bug#6451).
10415
4ffd0d6b 10416 * buffer.c (syms_of_buffer): Doc fix (Bug#6902).
aac0c6e3 10417
4ffd0d6b 104182011-04-23 Samuel Thibault <sthibault@debian.org> (tiny change)
aac0c6e3 10419
4ffd0d6b
GM
10420 * sysdep.c (wait_for_termination): On GNU Hurd, kill returns -1 on
10421 zombies (Bug#8467).
aac0c6e3 10422
04c56954
EZ
104232011-04-19 Eli Zaretskii <eliz@gnu.org>
10424
10425 * syntax.h (SETUP_SYNTAX_TABLE_FOR_OBJECT): Fix setting of
10426 gl_state.e_property when gl_state.object is Qt.
10427
10428 * insdel.c (make_gap_larger): Remove limitation of buffer size
10429 to <= INT_MAX.
10430
16a43933
CY
104312011-04-18 Chong Yidong <cyd@stupidchicken.com>
10432
10433 * xdisp.c (lookup_glyphless_char_display)
10434 (produce_glyphless_glyph): Handle cons cell entry in
10435 glyphless-char-display.
10436 (Vglyphless_char_display): Document it.
10437
10438 * term.c (produce_glyphless_glyph): Handle cons cell entry in
10439 glyphless-char-display.
10440
4581706e
CY
104412011-04-17 Chong Yidong <cyd@stupidchicken.com>
10442
10443 * xdisp.c (get_next_display_element): Remove unnecessary ifdefs.
10444
10445 * termhooks.h (FRAME_WINDOW_P): Remove duplicated definitions.
10446
10447 * dispextern.h (FACE_SUITABLE_FOR_ASCII_CHAR_P): Add missing
10448 definition for no-X builds.
10449
4887c6e2 104502011-04-16 Paul Eggert <eggert@cs.ucla.edu>
764430a3 10451
fd35b6f9
PE
10452 Static checks with GCC 4.6.0 and non-default toolkits.
10453
5c1ccb01
PE
10454 * s/sol2-6.h, s/unixware.h (PTY_TTY_NAME_SPRINTF): Protoize decl.
10455
006c5daa
PE
10456 * process.c (keyboard_bit_set): Define only if SIGIO.
10457 (send_process_trap): Mark it with NO_RETURN if it doesn't return.
10458 (send_process): Repair possible setjmp clobbering.
10459
efc736d3
PE
10460 * s/usg5-4-common.h (SETUP_SLAVE_PTY): Don't pass extra arg to 'fatal'.
10461
4e2fe2e6
PE
10462 * eval.c: Include <stdio.h>, for vsnprintf on non-GNU/Linux hosts.
10463
f97334a2
PE
10464 * data.c (arith_error): Mark with NO_RETURN if it doesn't return.
10465
4e75f29d
PE
10466 * alloc.c (bytes_used_when_full, SPARE_MEMORY, BYTES_USED):
10467 Define only if needed.
10468
90efadd1
PE
10469 * sysdep.c (_FILE_OFFSET_BITS): Make this hack even uglier
10470 by pacifying GCC about it. Maybe it's time to retire it?
875975e9 10471 * xfaces.c (USG, __TIMEVAL__): Likewise.
90efadd1 10472
3c647824
PE
10473 * dispextern.h (struct redisplay_interface): Rename param
10474 to avoid shadowing.
e264f262 10475 * termhooks.h (struct terminal): Likewise.
761383f4 10476 * xterm.c (xembed_send_message): Likewise.
3c647824 10477
b58c5c4a
PE
10478 * insdel.c (make_gap_smaller): Define only if
10479 USE_MMAP_FOR_BUFFERS || REL_ALLOC || DOUG_LEA_MALLOC.
10480
cad59032
PE
10481 * keyboard.c (read_char): Make a var volatile so longjmp won't clobber
10482 it.
10483
c339dc2e
PE
10484 * emacs.c (MAX_HEAP_BSS_DIFF, my_edata): Move to where they're used,
10485 so that we aren't warned about unused symbols.
10486
91a3e27b
PE
10487 * xfns.c (Fx_file_dialog): Rename local to avoid shadowing.
10488
399c71d3 10489 * xdisp.c (x_produce_glyphs): Mark var as initialized (Bug#8512).
7a3fb125 10490
8ffc96f5
PE
10491 * xfns.c (x_real_positions): Mark locals as initialized.
10492
eef9bc79
PE
10493 * xmenu.c (xmenu_show): Don't use uninitialized vars.
10494
098db9dd
PE
10495 * xterm.c: Fix problems found by static analysis with other toolkits.
10496 (toolkit_scroll_bar_interaction): Define and use only if USE_X_TOOLKIT.
dda3aedd
PE
10497 (x_dispatch_event): Declare static if USE_GTK, and
10498 define if USE_GTK || USE_X_TOOLKIT.
098db9dd 10499 (SET_SAVED_BUTTON_EVENT): Define only if USE_X_TOOLKIT || USE_GTK.
dda3aedd 10500 * xterm.h (x_dispatch_event): Extern only if USE_X_TOOLKIT.
841a1577
JB
10501 * xterm.c, xterm.h (x_mouse_leave): Bring this function back, but only
10502 if defined HAVE_MENUS && !defined USE_X_TOOLKIT && !defined USE_GTK.
098db9dd 10503
eb18f6cc
PE
10504 * xmenu.c (menu_help_callback): Pointer type fixes.
10505 Use const pointers when pointing at readonly data. Avoid pointer
10506 signedness clashes.
10507 (FALSE): Remove unused macro.
10508 (update_frame_menubar): Remove unused decl.
10509
1fe72bf8
PE
10510 * xfns.c (Fx_hide_tip): Move locals to avoid shadowing.
10511
60d9e1db
PE
10512 * menu.c (push_submenu_start, push_submenu_end): Do not define unless
10513 USE_X_TOOLKIT || USE_GTK || HAVE_NS || defined HAVE_NTGUI.
10514 (single_menu_item): Rename local to avoid shadowing.
10515
39261c26
PE
10516 * keyboard.c (make_lispy_event): Remove unused local var.
10517
018c5e19
PE
10518 * frame.c, frame.h (x_get_resource_string): Bring this back, but
10519 only if HAVE_X_WINDOWS && !USE_X_TOOLKIT.
10520
63d2b86e
PE
10521 * bitmaps: Change bitmaps from unsigned char back to the X11
10522 compatible char. Avoid the old compiler warnings about
10523 out-of-range initializers by using, for example, '\xab' rather
10524 than 0xab.
10525
aefd87e1
PE
10526 * xgselect.c (xgselect_initialize): Check vs interface
10527 even if ! (defined (USE_GTK) || defined (HAVE_GCONF)).
10528
bf501fb9
PE
10529 * xmenu.c (xmenu_show): Rename parm to avoid shadowing.
10530
e9829fdf
PE
10531 * xterm.c (x_create_toolkit_scroll_bar): Use const * for pointers
10532 to read-only memory.
10533
1086c095
PE
10534 * fns.c (vector): Remove; this old hack is no longer needed.
10535
2baccd04 10536 * xsmfns.c (create_client_leader_window): Rename shadowing arg.
401f10cb 10537 Remove unused var.
dde42981 10538 (gdk_x11_set_sm_client_id) [!USE_GTK]: Don't define.
2baccd04 10539
72391843 10540 * xrdb.c (x_load_resources): Omit unused local.
3565b346 10541
436c16df 10542 * xfns.c (free_frame_menubar, atof): Remove duplicate decls.
8a94ea33 10543 (x_window): Rename locals to avoid shadowing.
dc5ddd85 10544 (USG): Use the kludged USG macro, to pacify gcc.
436c16df 10545
92bb796d 10546 * xterm.c (x_alloc_nearest_color_for_widget): Remove; unused.
bbbef9e1 10547 (x_term_init): Remove local to avoid shadowing.
92bb796d 10548
764430a3 10549 * xfns.c, xterm.c (_XEditResCheckMessages): Protoize decl.
4887c6e2
PE
10550
10551 * xdisp.c, dispextern.h (set_vertical_scroll_bar): Now extern if
10552 USE_TOOLKIT_SCROLL_BARS && !USE_GTK, as xterm.c needs it then.
10553
d1dfb56c
EZ
105542011-04-16 Eli Zaretskii <eliz@gnu.org>
10555
c4354cb4
EZ
10556 * gnutls.c (Fgnutls_boot): Don't pass Lisp_Object to `error'.
10557
d1dfb56c
EZ
10558 Fix regex.c, syntax.c and friends for buffers > 2GB.
10559 * syntax.h (struct gl_state_s): Declare character position members
10560 EMACS_INT.
10561
10562 * syntax.c (update_syntax_table): Declare 2nd argument EMACS_INT.
10563
04f2d78b
CB
10564 * textprop.c (verify_interval_modification, interval_of):
10565 Declare arguments EMACS_INT.
d1dfb56c
EZ
10566
10567 * intervals.c (adjust_intervals_for_insertion): Declare arguments
10568 EMACS_INT.
10569
10570 * intervals.h (CHECK_TOTAL_LENGTH): Cast to EMACS_INT, not `int'.
10571
10572 * indent.c (Fvertical_motion): Local variable it_start is now
10573 EMACS_INT.
10574
10575 * regex.c (re_match, re_match_2, re_match_2_internal)
10576 (bcmp_translate, regcomp, regexec, print_double_string)
10577 (group_in_compile_stack, re_search, re_search_2, regex_compile)
10578 (re_compile_pattern, re_exec): Declare arguments and local
10579 variables `size_t' and `ssize_t' and return values `regoff_t', as
10580 appropriate.
10581 (POP_FAILURE_REG_OR_COUNT) <pfreg>: Declare `long'.
10582 (CHECK_INFINITE_LOOP) <failure>: Declare `ssize_t'.
10583 <compile_stack_type>: `size' and `avail' are now `size_t'.
10584
10585 * regex.h <regoff_t>: Use ssize_t, not int.
10586 (re_search, re_search_2, re_match, re_match_2): Arguments that
10587 specify buffer/string position and length are now ssize_t and
10588 size_t. Return type is regoff_t.
10589
613052cd
BK
105902011-04-16 Ben Key <bkey76@gmail.com>
10591
10592 * nsfont.m: Fixed bugs in ns_get_family and
10593 ns_descriptor_to_entity that were caused by using free to
10594 deallocate memory blocks that were allocated by xmalloc (via
10595 xstrdup). This caused Emacs to crash when compiled with
10596 XMALLOC_OVERRUN_CHECK defined (when Emacs was configured with
10597 --enable-checking=xmallocoverrun). xfree is now used to
10598 deallocate these memory blocks.
10599
4170f62f 106002011-04-15 Paul Eggert <eggert@cs.ucla.edu>
3e047f51 10601
71b41406
PE
10602 * sysdep.c (emacs_read): Remove unnecessary check vs MAX_RW_COUNT.
10603
9587a89d
PE
10604 emacs_write: Accept and return EMACS_INT for sizes.
10605 See http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00514.html
10606 et seq.
10607 * gnutls.c, gnutls.h (emacs_gnutls_read, emacs_gnutls_write):
10608 Accept and return EMACS_INT.
10609 (emacs_gnutls_write): Return the number of bytes written on
10610 partial writes.
10611 * sysdep.c, lisp.h (emacs_read, emacs_write): Likewise.
273a5f82
PE
10612 (emacs_read, emacs_write): Remove check for negative size, as the
10613 Emacs source code has been audited now.
9587a89d
PE
10614 * sysdep.c (MAX_RW_COUNT): New macro, to work around kernel bugs.
10615 (emacs_read, emacs_write): Use it.
273a5f82
PE
10616 * process.c (send_process): Adjust to the new signatures of
10617 emacs_write and emacs_gnutls_write. Do not attempt to store
10618 a byte offset into an 'int'; it might overflow.
9587a89d 10619 See http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00483.html
273a5f82 10620
3e047f51
PE
10621 * sound.c: Don't assume sizes fit in 'int'.
10622 (struct sound_device.period_size, alsa_period_size):
9c3c56a7 10623 Return EMACS_INT, not int.
3e047f51 10624 (struct sound_device.write, vox_write, alsa_write):
9c3c56a7
PE
10625 Accept EMACS_INT, not int.
10626 (wav_play, au_play): Use EMACS_INT to store sizes and to
3e047f51
PE
10627 record read return values.
10628
cc39a9db
BK
106292011-04-15 Ben Key <bkey76@gmail.com>
10630
c9d0ec6d
JB
10631 * keyboard.c (Qundefined): Don't declare static since it is used
10632 in nsfns.m.
10633 * xfaces.c (Qbold, Qexpanded, Qitalic, Qcondensed): Don't declare
10634 static since they are used in nsfont.m.
cc39a9db 10635
6c60eb9f
SM
106362011-04-15 Stefan Monnier <monnier@iro.umontreal.ca>
10637
10638 * process.c (Qprocessp): Don't declare static.
10639 * lisp.h (Qprocessp): Declare again.
10640
7990b61a
JB
106412011-04-15 Juanma Barranquero <lekktu@gmail.com>
10642
10643 * font.c (Qopentype): Don't make static (used from w32uniscribe.c).
10644
5d4cb038
PE
106452011-04-14 Paul Eggert <eggert@cs.ucla.edu>
10646
8bd7b830 10647 Improve C-level modularity by making more things 'static'.
cd64ea1d 10648
e3b27b31
PE
10649 Don't publish debugger-only interfaces to other modules.
10650 * lisp.h (safe_debug_print, debug_output_compilation_hack):
10651 (verify_bytepos, count_markers): Move decls to the only modules
10652 that need them.
10653 * region-cache.h (pp_cache): Likewise.
10654 * window.h (check_all_windows): Likewise.
10655 * marker.c, print.c, region-cache.c, window.c: Decls moved here.
10656
5d4cb038
PE
10657 * sysdep.c (croak): Now static, if
10658 defined TIOCNOTTY || defined USG5 || defined CYGWIN.
10659 * syssignal.h (croak): Declare only if not static.
69003fd8
PE
10660
10661 * alloc.c (refill_memory_reserve): Now static if
10662 !defined REL_ALLOC || defined SYSTEM_MALLOC.
10663 * lisp.h (refill_memory_reserve): Declare only if not static.
93ea6e8f 10664
e87b6180
PE
10665 * xsettings.c, xsettings.h (xsettings_get_system_normal_font):
10666 Define only if USE_LUCID.
10667
ac64929e
PE
10668 * xrdb.c (x_customization_string, x_rm_string): Now static.
10669
6f37259d
PE
10670 * xmenu.c (x_menu_wait_for_event): Export only if USE_MOTIF.
10671 * xterm.h (x_menu_wait_for_event): Declare only if USE_MOTIF.
10672
1683e3ab
PE
10673 * xdisp.c (draw_row_with_mouse_face): Now static.
10674 * dispextern.h (draw_row_with_mouse_fave): Remove decl.
10675
de9c2632
PE
10676 * window.h (check_all_windows): Mark externally visible.
10677
2b96acb7
PE
10678 * window.c (window_deletion_count): Now static.
10679
10680 * undo.c: Make symbols static if they're not exported.
10681 (last_undo_buffer, last_boundary_position, pending_boundary):
10682 Now static.
10683
50436f33
PE
10684 * textprop.c (interval_insert_behind_hooks): Now static.
10685 (interval_insert_in_front_hooks): Likewise.
10686
64520e5c
PE
10687 * term.c: Make symbols static if they're not exported.
10688 (tty_turn_off_highlight, get_tty_terminal, max_frame_cols):
10689 (max_frame_lines, tty_set_terminal_modes):
10690 (tty_reset_terminal_modes, tty_turn_off_highlight):
10691 (get_tty_terminal): Now static.
10692 (term_mouse_moveto): Do not define if HAVE_WINDOW_SYSTEM.
10693 * termhooks.h (term_mouse_moveto): Do not declare if
8bd7b830 10694 HAVE_WINDOW_SYSTEM.
64520e5c
PE
10695 * dispextern.h (tty_set_terminal_modes, tty_reset_terminal_modes):
10696 (tty_turn_off_highlight, get_tty_terminal): Remove decls.
10697
1fa53021
PE
10698 * sysdep.c: Make symbols static if they're not exported.
10699 (emacs_get_tty, emacs_set_tty, old_fcntl_flags, old_fcntl_owner):
10700 Now static.
10701 (sigprocmask_set, full_mask): Remove; unused.
10702 (wait_debugging): Mark as visible.
10703 * syssignal.h (SIGFULLMASK, full_mask): Remove decls.
10704 * systty.h (emacs_get_tty, emacs_set_tty): Remove decls.
10705
d4b43b22
PE
10706 * syntax.c (syntax_temp): Define only if !__GNUC__.
10707
b7c513d0
PE
10708 * sound.c (current_sound_device, current_sound): Now static.
10709
989b29ad
PE
10710 * search.c (searchbufs, searchbuf_head): Now static.
10711
13a55a78
PE
10712 * scroll.c (scroll_cost): Remove; unused.
10713 * dispextern.h (scroll_cost): Remove decl.
10714
de68a1fc
PE
10715 * region-cache.h (pp_cache): Mark as externally visible.
10716
40ccffa6
PE
10717 * process.c: Make symbols static if they're not exported.
10718 (process_tick, update_tick, create_process, chan_process):
10719 (Vprocess_alist, proc_buffered_char, datagram_access):
10720 (fd_callback_data, send_process_frame, process_sent_to): Now static.
10721 (deactivate_process): Mark defn as static, as well as decl.
10722 * lisp.h (create_process): Remove decl.
10723 * process.h (chan_process, Vprocess_alist): Remove decls.
10724
ad64fc97
PE
10725 * print.c: Make symbols static if they're not exported.
10726 (print_depth, new_backquote_output, being_printed, print_buffer):
10727 (print_buffer_size, print_buffer_pos, print_buffer_pos_byte):
10728 (print_interval, print_number_index, initial_stderr_stream):
10729 Now static.
10730 * lisp.h (Fprinc): Remove decl.
10731 (debug_output_compilation_hack): Mark as externally visible.
10732
adddb265
PE
10733 * sysdep.c (croak): Move decl from here to syssignal.h.
10734 * syssignal.h (croak): Put it here, so the API can be checked when
10735 'croak' is called from dissociate_if_controlling_tty.
10736
1717ede2
PE
10737 * minibuf.c: Make symbols static if they're not exported.
10738 (minibuf_save_list, choose_minibuf_frame): Now static.
10739 * lisp.h (choose_minibuf_frame): Remove decl.
10740
fa5fb2bc
PE
10741 * lisp.h (verify_bytepos, count_markers): Mark as externally visible.
10742
1e3890d1
PE
10743 * lread.c: Make symbols static if they're not exported.
10744 (read_objects, initial_obarray, oblookup_last_bucket_number):
10745 Now static.
10746 (make_symbol): Remove; unused.
10747 * lisp.h (initial_obarray, make_symbol): Remove decls.
10748
8a1414fa
PE
10749 * keyboard.c: Make symbols static if they're not exported.
10750 (single_kboard, recent_keys_index, total_keys, recent_keys):
10751 (this_command_key_count_reset, raw_keybuf, raw_keybuf_count):
10752 (this_single_command_key_start, echoing, last_auto_save):
10753 (read_key_sequence_cmd, dribble, recursive_edit_unwind):
10754 (command_loop, echo_now, keyboard_init_hook, help_char_p):
10755 (quit_throw_to_read_char, command_loop_2, top_level_1, poll_timer):
10756 (Vlispy_mouse_stem, double_click_count):
10757 Now static.
10758 (force_auto_save_soon): Define only if SIGDANGER.
10759 (ignore_mouse_drag_p): Now static if
10760 !defined HAVE_WINDOW_SYSTEM || defined USE_GTK || defined HAVE_NS.
10761 (print_help): Remove; unused.
10762 (stop_character, last_timer_event): Mark as externally visible.
10763 * keyboard.h (ignore_mouse_drag_p): Declare only if
10764 defined HAVE_WINDOW_SYSTEM && !defined USE_GTK && !defined HAVE_NS.
10765 (echo_now, help_char_p, quit_throw_to_read_char): Remove decls.
10766 * lisp.h (echoing): Remove decl.
10767 (force_auto_save_soon): Declare only if SIGDANGER.
10768 * xdisp.c (redisplay_window): Simplify code, to make it more
10769 obvious that ignore_mouse_drag_p is not accessed if !defined
10770 USE_GTK && !defined HAVE_NS.
10771
93ea6e8f
PE
10772 * intervals.c: Make symbols static if they're not exported.
10773 (merge_properties_sticky, merge_interval_right, delete_interval):
10774 Now static.
10775 * intervals.h (merge_interval_right, delete_interval): Remove decls.
10776
77382fcc
PE
10777 * insdel.c: Make symbols static if they're not exported.
10778 However, leave prepare_to_modify_buffer alone. It's never
10779 called from outside this function, but that appears to be a bug.
10780 (combine_after_change_list, combine_after_change_buffer):
4889fc82 10781 (adjust_after_replace, signal_before_change): Now static.
77382fcc
PE
10782 (adjust_after_replace_noundo): Remove; unused.
10783 * lisp.h (adjust_after_replace, adjust_after_replace_noundo):
4889fc82 10784 (signal_before_change): Remove decls.
77382fcc 10785
9306c32e
PE
10786 * indent.c (val_compute_motion, val_vmotion): Now static.
10787
cd44d2eb
PE
10788 * image.c: Make symbols static if they're not exported.
10789 * dispextern.h (x_create_bitmap_from_xpm_data): Do not declare
10790 if USE_GTK.
10791 * image.c (x_create_bitmap_from_xpm_data): Do not define if USE_GTK.
10792 (xpm_color_cache, ct_table, ct_colors_allocated): Now static.
10793
ad9a7a06
PE
10794 * fringe.c (standard_bitmaps): Now static.
10795 (max_used_fringe_bitmap): Now static, unless HAVE_NS.
10796
81626931
PE
10797 * frame.c: Make symbols static if they're not exported.
10798 (x_report_frame_params, make_terminal_frame): Now static.
10799 (get_frame_param): Now static, unless HAVE_NS.
10800 (x_fullscreen_adjust): Define if WINDOWSNT, not if HAVE_WINDOW_SYSTEM.
10801 (x_get_resource_string): Remove; not used.
10802 * frame.h (make_terminal_frame, x_report_frame_params):
10803 (x_get_resource_string); Remove decls.
10804 (x_fullscreen_adjust): Declare only if WINDOWSNT.
10805 * lisp.h (get_frame_param): Declare only if HAVE_NS.
10806
239f9db9
PE
10807 * font.c, fontset.c: Make symbols static if they're not exported.
10808 * dispextern.h (FACE_SUITABLE_FOR_ASCII_CHAR_P): New macro.
10809 (FACE_SUITABLE_FOR_CHAR_P): Use it.
10810 * font.c (font_close_object): Now static.
10811 * font.h (font_close_object): Remove.
10812 * fontset.c (FONTSET_OBJLIST): Remove.
10813 (free_realized_fontset) #if-0 the body, which does nothing.
10814 (face_suitable_for_char_p): #if-0, as it's never called.
10815 * fontset.h (face_suitable_for_char_p): Remove decl.
04f2d78b
CB
10816 * xfaces.c (face_at_string_position):
10817 Use FACE_SUITABLE_FOR_ASCII_CHAR_P, not FACE_SUITABLE_FOR_CHAR_P,
239f9db9
PE
10818 since 0 is always ASCII.
10819
dfcf3579
PE
10820 * fns.c (weak_hash_tables): Now static.
10821
5045092b
PE
10822 * fileio.c: Make symbols static if they're not exported.
10823 (auto_saving, auto_save_mode_bits, auto_save_error_occurred):
10824 (Vwrite_region_annotation_buffers): Now static.
10825
57a96f5c
PE
10826 * eval.c: Make symbols static if they're not exported.
10827 (backtrace_list, lisp_eval_depth, when_entered_debugger): Now static.
10828 * lisp.h (backtrace_list): Remove decl.
10829
35f08c38
PE
10830 * emacs.c: Make symbols static if they're not exported.
10831 (malloc_state_ptr, malloc_using_checking, syms_of_emacs):
10832 (fatal_error_code, fatal_error_signal_hook, standard_args):
10833 Now static.
10834 (fatal_error_signal): Now static, unless FLOAT_CATCH_SIGKILL.
10835 (DEFINE_DUMMY_FUNCTION): Mark function as externally visible.
10836 (__CTOR_LIST__, __DTOR_LIST__): Now externally visible.
10837 * lisp.h (fatal_error_signal_hook): Remove decl.
10838 (fatal_error_signal): Declare only if FLOAT_CATCH_SIGKILL.
10839
f44bd759
PE
10840 * editfns.c: Move a (normally-unused) function to its only use.
10841 * editfns.c, lisp.h (get_operating_system_release): Remove.
10842 * process.c (init_process) [DARWIN_OS]: Do it inline, as it is not
10843 worth the hassle of breaking this out.
10844
b532497d
PE
10845 * xterm.c: Make symbols static if they're not exported.
10846 (x_raise_frame, x_lower_frame, x_wm_set_window_state):
10847 (x_wm_set_icon_pixmap, x_initialize, XTread_socket_fake_io_error):
10848 (x_destroy_window, x_delete_display):
10849 Now static.
10850 (x_dispatch_event): Now static if ! (USE_MOTIF || USE_X_TOOLKIT).
10851 (x_mouse_leave): Remove; unused.
10852 * xterm.h (x_display_info_for_name, x_raise_frame, x_lower_frame):
10853 (x_destroy_window, x_wm_set_window_state, x_wm_set_icon_pixmap):
10854 (x_delete_display, x_initialize, x_set_border_pixel, x_screen_planes):
10855 Remove decls.
10856 (x_mouse_leave): Declare only if WINDOWSNT.
10857 (x_dispatch_event): Declare only if USE_MOTIF or USE_X_TOOLKIT.
10858 (xic_create_fontsetname): Declare only if HAVE_X_WINDOWS &&
10859 USE_X_TOOLKIT.
10860
1675728f
PE
10861 * ftxfont.c: Make symbols static if they're not exported.
10862 (ftxfont_driver): Export only if !defined HAVE_XFT && def8ined
10863 HAVE_FREETYPE.
10864 * font.h (ftxfont_driver): Likewise.
10865
e4cebfca
PE
10866 * xfns.c: Make symbols static if they're not exported.
10867 (x_last_font_name, x_display_info_for_name):
10868 (x_set_foreground_color, x_set_background_color, x_set_mouse_color):
10869 (x_set_cursor_color, x_set_border_pixel, x_set_border_color):
10870 (x_set_cursor_type, x_set_icon_type, x_set_icon_name):
10871 (x_set_scroll_bar_foreground, x_set_scroll_bar_background):
10872 (x_explicitly_set_name, x_set_title, xic_defaut_fontset, tip_timer):
10873 (last_show_tip_args): Now static.
10874 (xic_defaut_fontset, xic_create_fontsetname): Define only if
10875 defined HAVE_X_WINDOWS && defined USE_X_TOOLKIT
10876 (x_screen_planes): Remove; unused.
10877 * dispextern.h (x_screen_planes): Remove decl.
10878
5bf46f05
PE
10879 * dispnew.c: Make symbols static if they're not exported.
10880 * dispextern.h (redraw_garbaged_frames, scrolling):
10881 (increment_row_positions): Remove.
10882 * dispnew.c (new_glyph_matrix, increment_row_positions, scrolling):
10883 (delayed_size_change, glyph_matrix_count, glyph_pool_count):
10884 Now static.
10885 (redraw_garbaged_frames): Remove; unused.
10886
435f4c28
PE
10887 * xfaces.c: Make symbols static if they're not exported.
10888 * dispextern.h (ascii_face_of_lisp_face, free_realized_face):
10889 Remove decls.
10890 * xterm.h (defined_color): Remove decls.
10891 (x_free_dpy_colors): Declare only if USE_X_TOOLKIT.
10892 * xfaces.c (tty_suppress_bold_inverse_default_colors_p):
10893 (menu_face_changed_default, defined_color, free_realized_face):
10894 (x_free_dpy_colors): Define only if USE_X_TOOLKIT.
10895 (ascii_face_of_lisp_face): Remove; unused.
10896
8524aef3
PE
10897 * xdisp.c: Make symbols static if they're not exported.
10898 * dispextern.h (scratch_glyph_row, window_box_edges):
10899 (glyph_to_pixel_coords, set_cursor_from_row):
10900 (get_next_display_element, set_iterator_to_next):
10901 (highlight_trailing_whitespace, frame_to_window_pixel_xy):
10902 (show_mouse_face): Remove decls
10903 * frame.h (message_buf_print): Likewise.
10904 * lisp.h (pop_message, set_message, check_point_in_composition):
10905 Likewise.
10906 * xterm.h (set_vertical_scroll_bar): Likewise.
10907 * xdisp.c (list_of_error, Vmessage_stack, line_number_displayed):
10908 (message_buf_print, scratch_glyph_row, displayed_buffer):
10909 (set_iterator_to_next, pop_message, set_message, set_cursor_from_row):
10910 (get_next_display_element, show_mouse_face, window_box_edges):
10911 (frame_to_window_pixel_xy, check_point_in_composition):
10912 (set_vertical_scroll_bar, highlight_trailing_whitespace): Now static.
10913 (glyph_to_pixel_coords): Remove; unused.
10914
16390cd2
PE
10915 * dired.c (file_name_completion): Now static.
10916
10917 * dbusbind.c (xd_in_read_queued_messages): Now static.
10918
a25f4dfa
PE
10919 * lisp.h (circular_list_error, FOREACH): Remove; unused.
10920 * data.c (circular_list_error): Remove.
10921
14a9c8df
PE
10922 * commands.h (last_point_position, last_point_position_buffer):
10923 (last_point_position_window): Remove decls.
10924 * keyboard.c: Make these variables static.
10925
04f2d78b
CB
10926 * coding.h (coding, code_convert_region, encode_coding_gap):
10927 Remove decls.
74ab6df5
PE
10928 * coding.c (Vsjis_coding_system, Vbig5_coding_system):
10929 (iso_code_class, detect_coding, code_convert_region): Now static.
10930 (encode_coding_gap): Remove; unused.
10931
38dfbee1
PE
10932 * chartab.c (chartab_chars, chartab_bits): Now static.
10933
a2cb4e63
PE
10934 * charset.h (charset_iso_8859_1): Remove decl.
10935 * charset.c (charset_iso_8859_1, charset_emacs, map_charset_for_dump):
10936 Now static.
10937
127198fd
PE
10938 * ccl.h (check_ccl_update, Vccl_program_table): Remove decls.
10939 * ccl.c (Vccl_program_table): Now static.
10940 (check_ccl_update): Remove; unused.
10941
d85b608f
PE
10942 * category.c (SET_CATEGORY_SET, set_category_set): Move here.
10943 * category.h: ... from here.
10944 * category.c (check_category_table, set_category_set): Now static.
10945
31cd66f3
PE
10946 * casetab.c (Vascii_upcase_table, Vascii_eqv_table): Now static.
10947 * lisp.h: Remove these decls.
10948
c358e587
PE
10949 * buffer.c (buffer_count): Remove unused var.
10950
e78aecca
PE
10951 * bidi.c (bidi_dump_cached_states): Mark as externally visible,
10952 so that it's not optimized away.
10953 (bidi_ignore_explicit_marks_for_paragraph_level): Likewise.
10954 * dispextern.h (bidi_dump_cached_states): Remove, since it's
10955 exported only to the debugger.
10956
e192d7d3 10957 * atimer.c (alarm_signal_handler, run_all_atimers): Now static.
04f2d78b 10958 * atimer.h (run_all_atimers): Remove; not exported.
e192d7d3 10959
92470028
PE
10960 font.c: Make copy_font_spec and merge_font_spec ordinary C functions.
10961 * font.c (copy_font_spec): Rename from Fcopy_font_spec, since it
10962 was inaccessible from Lisp.
10963 (merge_font_spec): Likewise, renaming from Fmerge_font_spec.
10964 * font.c, font.h, fontset.c, xfaces.c, xfont.c: Change all uses.
10965
244ed907
PE
10966 alloc.c: Import and export fewer symbols, and remove unused items.
10967 * lisp.h (suppress_checking, die): Declare only if ENABLE_CHECKING
10968 is defined.
10969 (suppress_checking): Add EXTERNALLY_VISIBLE attribute, so that
10970 it's not optimized away by whole-program optimization.
10971 (message_enable_multibyte, free_misc): Remove.
10972 (catchlist, handlerlist, mark_backtrace):
10973 Declare only if BYTE_MARK_STACK.
10974 (mark_byte_stack): Likewise, fixing a ifdef-vs-if typo.
10975 * alloc.c (pure): Export only if VIRT_ADDR_VARIES is defined.
10976 (message_enable_multibyte): Remove decl.
10977 (free_misc, interval_free_list, float_block, float_block_index):
10978 (n_float_blocks, float_free_list, cons_block, cons_block_index):
10979 (cons_free_list, last_marked_index):
10980 Now static.
10981 (suppress_checking, die): Define only if ENABLE_CHECKING is defined.
10982 * eval.c (catchlist, handlerlist): Export only if BYTE_MARK_STACK.
10983 (mark_backtrace): Define only if BYTE_MARK_STACK.
10984 * xdisp.c (message_enable_multibyte): Now static.
10985
61c2b50e 10986 Declare Lisp_Object Q* variables to be 'static' if not exported.
955cbe7b
PE
10987 This makes it easier for human readers (and static analyzers)
10988 to see whether these variables are used from other modules.
10989 * alloc.c, buffer.c, bytecode.c, callint.c, casetab.c, category.c:
10990 * ccl.c, character.c, charset.c, cmds.c, coding.c, composite.c:
10991 * data.c, dbusbind.c, dired.c, editfns.c, eval.c, fileio.c, fns.c:
10992 * font.c, frame.c, fringe.c, ftfont.c, image.c, keyboard.c, keymap.c:
10993 * lread.c, macros.c, minibuf.c, print.c, process.c, search.c:
10994 * sound.c, syntax.c, textprop.c, window.c, xdisp.c, xfaces.c, xfns.c:
10995 * xmenu.c, xselect.c:
10996 Declare Q* vars static if they are not used in other modules.
10997 * ccl.h, character.h, charset.h, coding.h, composite.h, font.h:
10998 * frame.h, intervals.h, keyboard.h, lisp.h, process.h, syntax.h:
10999 Remove decls of unexported vars.
11000 * keyboard.h (EVENT_HEAD_UNMODIFIED): Remove now-unused macro.
11001
95c82688
PE
11002 * lisp.h (DEFINE_FUNC): Make sname 'static'.
11003
16a97296
PE
11004 Make Emacs functions such as Fatom 'static' by default.
11005 This makes it easier for human readers (and static analyzers)
11006 to see whether these functions can be called from other modules.
11007 DEFUN now defines a static function. To make the function external
11008 so that it can be used in other C modules, use the new macro DEFUE.
8bd7b830
PE
11009 * lisp.h (Funibyte_char_to_multibyte, Fsyntax_table_p):
11010 (Finit_image_library):
16a97296
PE
11011 (Feval_region, Fbacktrace, Ffetch_bytecode, Fswitch_to_buffer):
11012 (Ffile_executable_p, Fmake_symbolic_link, Fcommand_execute):
11013 (Fget_process, Fdocumentation_property, Fbyte_code, Ffile_attributes):
11014 Remove decls, since these functions are now static.
11015 (Funintern, Fget_internal_run_time): New decls, since these functions
11016 were already external.
95c82688 11017
16a97296
PE
11018 * alloc.c, buffer.c, callint.c, callproc.c, casefiddle.c, casetab.c:
11019 * ccl.c, character.c, chartab.c, cmds.c, coding.c, data.c, dispnew.c:
11020 * doc.c, editfns.c, emacs.c, eval.c, fileio.c, filelock.c, floatfns.c:
11021 * fns.c, font.c, fontset.c, frame.c, image.c, indent.c:
11022 * keyboard.c, keymap.c, lread.c:
11023 * macros.c, marker.c, menu.c, minibuf.c, print.c, process.c, search.c:
11024 * syntax.c, term.c, terminal.c, textprop.c, undo.c:
11025 * window.c, xdisp.c, xfaces.c, xfns.c, xmenu.c, xsettings.c:
11026 Mark functions with DEFUE instead of DEFUN,
11027 if they are used in other modules.
11028 * buffer.c (Fset_buffer_major_mode, Fdelete_overlay): New forward
11029 decls for now-static functions.
11030 * buffer.h (Fdelete_overlay): Remove decl.
11031 * callproc.c (Fgetenv_internal): Mark as internal.
11032 * composite.c (Fremove_list_of_text_properties): Remove decl.
11033 (Fcomposition_get_gstring): New forward static decl.
11034 * composite.h (Fcomposite_get_gstring): Remove decl.
11035 * dired.c (Ffile_attributes): New forward static decl.
11036 * doc.c (Fdocumntation_property): New forward static decl.
11037 * eval.c (Ffetch_bytecode): New forward static decl.
11038 (Funintern): Remove extern decl; now in .h file where it belongs.
11039 * fileio.c (Fmake_symbolic_link): New forward static decl.
11040 * image.c (Finit_image_library): New forward static decl.
11041 * insdel.c (Fcombine_after_change_execute): Make forward decl static.
11042 * intervals.h (Fprevious_property_change):
11043 (Fremove_list_of_text_properties): Remove decls.
11044 * keyboard.c (Fthis_command_keys): Remove decl.
11045 (Fcommand_execute): New forward static decl.
11046 * keymap.c (Flookup_key): New forward static decl.
11047 (Fcopy_keymap): Now static.
11048 * keymap.h (Flookup_key): Remove decl.
11049 * process.c (Fget_process): New forward static decl.
11050 (Fprocess_datagram_address): Mark as internal.
11051 * syntax.c (Fsyntax_table_p): New forward static decl.
11052 (skip_chars): Remove duplicate decl.
11053 * textprop.c (Fprevious_property_change): New forward static decl.
11054 * window.c (Fset_window_fringes, Fset_window_scroll_bars):
11055 Now internal.
11056 (Fset_window_margins, Fset_window_vscroll): New forward static decls.
11057 * window.h (Fset_window_vscroll, Fset_window_margins): Remove decls.
11058
785bbd42
PE
11059 * editfns.c (Fformat): Remove unreachable code.
11060
8b913b57
AS
110612011-04-14 Andreas Schwab <schwab@linux-m68k.org>
11062
11063 * fileio.c (Finsert_file_contents): Fix typo in 2005-05-13
11064 change. (Bug#8496)
11065
a6744a35
EZ
110662011-04-13 Eli Zaretskii <eliz@gnu.org>
11067
11068 * xdisp.c (handle_invisible_prop): Don't call bidi_paragraph_init
11069 when at ZV. (Bug#8487)
11070
e7974947
AS
110712011-04-12 Andreas Schwab <schwab@linux-m68k.org>
11072
baad03f0
AS
11073 * charset.c (Fclear_charset_maps): Use xfree instead of free.
11074 (Bug#8437)
11075 * keyboard.c (parse_tool_bar_item): Likewise.
11076 * sound.c (sound_cleanup, alsa_close): Likewise.
11077 * termcap.c (tgetent): Likewise.
11078 * xfns.c (x_default_font_parameter): Likewise.
11079 * xsettings.c (read_and_apply_settings): Likewise.
11080
e7974947
AS
11081 * alloc.c (overrun_check_malloc, overrun_check_realloc)
11082 (overrun_check_free): Protoize.
11083
28272684
PE
110842011-04-12 Paul Eggert <eggert@cs.ucla.edu>
11085
11086 * sysdep.c (emacs_read, emacs_write): Check for negative sizes
11087 since callers should never pass a negative size.
11088 Change the signature to match that of plain 'read' and 'write'; see
11089 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00397.html>.
11090 * lisp.h: Update prototypes of emacs_write and emacs_read.
11091
11997c76
EZ
110922011-04-11 Eli Zaretskii <eliz@gnu.org>
11093
11094 * xdisp.c (redisplay_window): Don't try to determine the character
11095 position of the scroll margin if the window start point w->startp
e896f03c 11096 is outside the buffer's accessible region. (Bug#8468)
11997c76 11097
8a2cbd72
EZ
110982011-04-10 Eli Zaretskii <eliz@gnu.org>
11099
11100 Fix write-region and its subroutines for buffers > 2GB.
11101 * fileio.c (a_write, e_write): Modify declaration of arguments and
11102 local variables to support buffers larger than 2GB.
11103 (Fcopy_file): Use EMACS_INT for return value of emacs_read.
11104
11105 * sysdep.c (emacs_write, emacs_read): Use ssize_t for last
11106 argument, local variables, and return value.
11107
11108 * lisp.h: Update prototypes of emacs_write and emacs_read.
11109
11110 * sound.c (vox_write): Use ssize_t for return value of emacs_write.
11111
4073e537 111122011-04-10 Paul Eggert <eggert@cs.ucla.edu>
eb3f1cc8 11113
1ebfdcb6
PE
11114 * xdisp.c (vmessage): Use memchr, not strnlen, which some hosts lack.
11115
b2ded58d
PE
11116 Fix more problems found by GCC 4.6.0's static checks.
11117
7d66342c
PE
11118 * xdisp.c (vmessage): Use a better test for character truncation.
11119
bbf47d44
PE
11120 * charset.c (load_charset_map): <, not <=, for optimization,
11121 and to avoid potential problems with integer overflow.
9248994d 11122 * chartab.c (sub_char_table_set_range, char_table_set_range): Likewise.
f9a68bc5 11123 * casetab.c (set_identity, shuffle): Likewise.
3ab1c7ce 11124 * editfns.c (Fformat): Likewise.
1e69125e 11125 * syntax.c (skip_chars): Likewise.
3befa583 11126
e3019616
PE
11127 * xmenu.c (set_frame_menubar): Allocate smaller local vectors.
11128 This also lets GCC 4.6.0 generate slightly better loop code.
11129
becfa255
PE
11130 * callint.c (Fcall_interactively): <, not <=, for optimization.
11131 (Fcall_interactively): Count the number of arguments produced,
11132 not the number of arguments given. This is simpler and lets GCC
11133 4.6.0 generate slightly better code.
11134
dae0cd48
PE
11135 * ftfont.c: Distingish more carefully between FcChar8 and char.
11136 The previous code passed unsigned char * to a functions like
11137 strlen and xstrcasecmp that expect char *, which does not
11138 conform to the C standard.
11139 (get_adstyle_property, ftfont_pattern_entity): Use FcChar8 for
11140 arguments to FcPatternGetString, and explicitly cast FcChar8 * to
11141 char * when the C standard requires it.
11142
76032d70
PE
11143 * keyboard.c (read_char): Remove unused var.
11144
eb3f1cc8
PE
11145 * eval.c: Port to Windows vsnprintf (Bug#8435).
11146 Include <limits.h>.
11147 (SIZE_MAX): Define if the headers do not.
11148 (verror): Do not give up if vsnprintf returns a negative count.
11149 Instead, grow the buffer. This ports to Windows vsnprintf, which
11150 does not conform to C99. Problem reported by Eli Zaretskii.
11151 Also, simplify the allocation scheme, by avoiding the need for
11152 calling realloc, and removing the ALLOCATED variable.
11153
70476b54
PE
11154 * eval.c (verror): Initial buffer size is 4000 (not 200) bytes.
11155
12020a9e
PE
11156 Remove invocations of doprnt, as Emacs now uses vsnprintf.
11157 But keep the doprint source code for now, as we might revamp it
11158 and use it again (Bug#8435).
ea6c7ae6
PE
11159 * lisp.h (doprnt): Remove.
11160 * Makefile.in (base_obj): Remove doprnt.o.
11161 * deps.mk (doprnt.o): Remove.
11162
5fdb398c
PE
11163 error: Print 32- and 64-bit integers portably (Bug#8435).
11164 Without this change, on typical 64-bit hosts error ("...%d...", N)
11165 was used to print both 32- and 64-bit integers N, which relied on
11166 undefined behavior.
61bdb816 11167 * lisp.h, m/amdx86-64.h, m/ia64.h, m/ibms390x.h (pEd): New macro.
5fdb398c
PE
11168 * lisp.h (error, verror): Mark as printf-like functions.
11169 * eval.c (verror): Use vsnprintf, not doprnt, to do the real work.
11170 Report overflow in size calculations when allocating printf buffer.
11171 Do not truncate output string at its first null byte.
11172 * xdisp.c (vmessage): Use vsnprintf, not doprnt, to do the real work.
11173 Truncate the output at a character boundary, since vsnprintf does not
11174 do that.
11175 * charset.c (check_iso_charset_parameter): Convert internal
11176 character to string before calling 'error', since %c now has the
11177 printf meaning.
11178 * coding.c (Fdecode_sjis_char, Fdecode_big5_char): Avoid int
11179 overflow when computing char to be passed to 'error'. Do not
11180 pass Lisp_Object to 'error'; pass the integer instead.
11181 * nsfns.m (Fns_do_applescript): Use int, not long, since it's
11182 formatted with plain %d.
11183
b189fa66
PE
11184 * eval.c (internal_lisp_condition_case): Don't pass spurious arg.
11185
bff87ef0
PE
11186 * keyboard.c (access_keymap_keyremap): Print func name, not garbage.
11187
7e2cac20
PE
11188 * coding.c (Fdecode_sjis_char): Don't assume CODE fits in int.
11189
ce4d90b5
PE
11190 * xterm.c (x_catch_errors): Remove duplicate declaration.
11191
266c9547
PE
11192 * term.c (maybe_fatal): Mark its 3rd arg as a printf format, too.
11193
79c49ad2
PE
11194 * xdisp.c, lisp.h (message_nolog): Remove; unused.
11195
368f4090
JM
111962011-04-10 Jim Meyering <meyering@redhat.com>
11197
11198 use ssize_t and size_t for read- and write-like emacs_gnutls_* functions
11199 * gnutls.c (emacs_gnutls_read): Adjust signature to be more read-like:
11200 return ssize_t not "int", and use size_t as the buffer length.
11201 (emacs_gnutls_write): Likewise, and make the buffer pointer "const".
11202 * gnutls.h: Update declarations.
11203 * process.c (read_process_output): Use ssize_t, to match.
11204 (send_process): Likewise.
11205
a32d4040
CY
112062011-04-09 Chong Yidong <cyd@stupidchicken.com>
11207
11208 * image.c (Fimagemagick_types): Doc fix, and comment cleanup.
11209
8546720e 112102011-04-09 Chong Yidong <cyd@stupidchicken.com>
aac0c6e3 11211
04f2d78b
CB
11212 * ftfont.c (get_adstyle_property, ftfont_pattern_entity):
11213 Use unsigned char, to match FcChar8 type definition.
aac0c6e3 11214
8546720e
GM
11215 * xterm.c (handle_one_xevent):
11216 * xmenu.c (create_and_show_popup_menu):
11217 * xselect.c (x_decline_selection_request)
11218 (x_reply_selection_request): Avoid type-punned deref of X events.
aac0c6e3 11219
0a2f5c1a 112202011-04-09 Eli Zaretskii <eliz@gnu.org>
a53e2e89
EZ
11221
11222 Fix some uses of `int' instead of EMACS_INT.
11223 * search.c (string_match_1, fast_string_match)
11224 (fast_c_string_match_ignore_case, fast_string_match_ignore_case)
11225 (scan_buffer, find_next_newline_no_quit)
11226 (find_before_next_newline, search_command, Freplace_match)
11227 (Fmatch_data): Make some `int' variables be EMACS_INT.
11228
11229 * xdisp.c (display_count_lines): 3rd argument and return value now
11230 EMACS_INT. All callers changed.
11231 (pint2hrstr): Last argument is now EMACS_INT.
11232
11233 * coding.c (detect_coding_utf_8, detect_coding_emacs_mule)
11234 (detect_coding_iso_2022, detect_coding_sjis, detect_coding_big5)
11235 (detect_coding_ccl, detect_coding_charset, decode_coding_utf_8)
11236 (decode_coding_utf_16, decode_coding_emacs_mule)
11237 (decode_coding_iso_2022, decode_coding_sjis, decode_coding_big5)
11238 (decode_coding_ccl, decode_coding_charset)
11239 <consumed_chars, consumed_chars_base>: Declare EMACS_INT.
11240 (decode_coding_iso_2022, decode_coding_emacs_mule)
11241 (decode_coding_sjis, decode_coding_big5, decode_coding_charset)
11242 <char_offset, last_offset>: Declare EMACS_INT.
11243 (encode_coding_utf_8, encode_coding_utf_16)
11244 (encode_coding_emacs_mule, encode_invocation_designation)
11245 (encode_designation_at_bol, encode_coding_iso_2022)
11246 (encode_coding_sjis, encode_coding_big5, encode_coding_ccl)
11247 (encode_coding_raw_text, encode_coding_charset) <produced_chars>:
11248 Declare EMACS_INT.
11249 (ASSURE_DESTINATION): Declare more_bytes EMACS_INT.
11250 (encode_invocation_designation): Last argument P_NCHARS is now
11251 EMACS_INT.
11252 (decode_eol): Declare pos_byte, pos, and pos_end EMACS_INT.
11253 (produce_chars): from_nchars and to_nchars are now EMACS_INT.
11254
11255 * coding.h (struct coding_system) <head_ascii>: Declare EMACS_INT.
11256 All users changed.
11257
11258 * ccl.c (Fccl_execute_on_string): Declare some variables
11259 EMACS_INT.
11260
8546720e 112612011-04-08 Samuel Thibault <sthibault@debian.org> (tiny change)
0080dc6b
SS
11262
11263 * term.c (init_tty): Fix incorrect ifdef placement (Bug#8450).
11264
4e19a977
CS
112652011-03-19 Christoph Scholtes <cschol2112@googlemail.com>
11266
11267 * process.c (Fformat_network_address): Doc fix.
11268
87302331
R
112692011-04-08 T.V. Raman <tv.raman.tv@gmail.com> (tiny change)
11270
ee7683eb 11271 * xml.c (parse_region): Avoid creating spurious whitespace nodes.
87302331 11272
cbb59342
CY
112732011-04-08 Chong Yidong <cyd@stupidchicken.com>
11274
11275 * keyboard.c (read_char): Call Lisp function help-form-show,
11276 instead of using internal_with_output_to_temp_buffer.
11277 (Qhelp_form_show): New var.
e0d38eeb 11278 (syms_of_keyboard): Use DEFSYM macro.
cbb59342
CY
11279
11280 * print.c (internal_with_output_to_temp_buffer): Function deleted.
11281
11282 * lisp.h (internal_with_output_to_temp_buffer): Remove prototype.
11283
e67a13ab
CY
112842011-04-06 Chong Yidong <cyd@stupidchicken.com>
11285
04f2d78b
CB
11286 * process.c (Flist_processes): Remove to Lisp.
11287 (list_processes_1): Delete.
e67a13ab 11288
973f782d
EZ
112892011-04-06 Eli Zaretskii <eliz@gnu.org>
11290
7c106b1e
EZ
11291 * msdos.c (careadlinkat, careadlinkatcwd): MS-DOS replacements.
11292
973f782d
EZ
11293 * w32.c (careadlinkat, careadlinkatcwd): New always-fail stubs.
11294
41cf7d1a 112952011-04-06 Paul Eggert <eggert@cs.ucla.edu>
27ccc379 11296
ca23cc88
PE
11297 Fix more problems found by GCC 4.6.0's static checks.
11298
f390e2d5
PE
11299 * xmenu.c (Fx_popup_dialog): Don't assume string is free of formats.
11300
42eea0d0
PE
11301 * menu.c (Fx_popup_menu): Don't assume error_name lacks printf formats.
11302
b69769da 11303 * lisp.h (message, message_nolog, fatal): Mark as printf-like.
1e973bc7 11304
f9541e84
PE
11305 * xdisp.c (vmessage): Mark as a printf-like function.
11306
13841b55
PE
11307 * term.c (vfatal, maybe_fatal): Mark as printf-like functions.
11308
c136c10f
PE
11309 * sound.c (sound_warning): Don't crash if arg contains a printf format.
11310
5e2d4a30
PE
11311 * image.c (tiff_error_handler, tiff_warning_handler): Mark as
11312 printf-like functions.
11313 (tiff_load): Add casts to remove these marks before passing them
11314 to system-supplied API.
11315
583f48b9
PE
11316 * eval.c (Fsignal): Remove excess argument to 'fatal'.
11317
b25d760e
PE
11318 * coding.c (EMIT_ONE_BYTE, EMIT_TWO_BYTES): Use unsigned, not int.
11319 This avoids several warnings with gcc -Wstrict-overflow.
d5efd1d1
PE
11320 (DECODE_COMPOSITION_RULE): If the rule is invalid, goto invalid_code
11321 directly, rather than having caller test rule sign. This avoids
11322 some unnecessary tests.
11323 * composite.h (COMPOSITION_ENCODE_RULE_VALID): New macro.
11324 (COMPOSITION_ENCODE_RULE): Arguments now must be valid. This
11325 affects only one use, in DECODE_COMPOSITION_RULE, which is changed.
b25d760e 11326
bc7b6697 11327 * xfont.c (xfont_text_extents): Remove var that was set but not used.
625a3eb1 11328 (xfont_open): Avoid unnecessary tests.
bc7b6697 11329
27ccc379
PE
11330 * composite.c (composition_gstring_put_cache): Use unsigned integer.
11331
dcd5c89a
PE
11332 * composite.h, composite.c (composition_gstring_put_cache):
11333 Use EMACS_INT, not int, for length.
11334
b13a45c6
PE
11335 * composite.h (COMPOSITION_DECODE_REFS): New macro,
11336 breaking out part of COMPOSITION_DECODE_RULE.
11337 (COMPOSITION_DECODE_RULE): Use it.
11338 * composite.c (get_composition_id): Remove unused local vars,
11339 by using the new macro.
11340
1e792e4d
PE
11341 * textprop.c (set_text_properties_1): Change while to do-while,
11342 since the condition is always true at first.
11343
dc6c6455 11344 * intervals.c (graft_intervals_into_buffer): Mark var as used.
aa86731f
PE
11345 (interval_deletion_adjustment): Return unsigned value.
11346 All uses changed.
dc6c6455 11347
aba7731a
PE
11348 * process.c (list_processes_1, create_pty, read_process_output):
11349 (exec_sentinel): Remove vars that were set but not used.
afd4052b 11350 (create_pty): Remove unnecessary "volatile"s.
bc57d757 11351 (Fnetwork_interface_info): Avoid possibility of int overflow.
82eaa333 11352 (read_process_output): Do adaptive read buffering even if carryover.
fe07cdfa 11353 (read_process_output): Simplify nbytes computation if buffered.
aba7731a 11354
fdfc4bf3
PE
11355 * bytecode.c (exec_byte_code): Rename local to avoid shadowing.
11356
fca8fe46 11357 * syntax.c (scan_words): Remove var that was set but not used.
12cbf13f 11358 (update_syntax_table): Use unsigned instead of int.
fca8fe46 11359
06a0259a 11360 * lread.c (lisp_file_lexically_bound_p): Use ints rather than endptrs.
3c346cc3 11361 (lisp_file_lexically_bound_p, read1): Use unsigned instead of int.
e6eb4e9e 11362 (safe_to_load_p): Make the end-of-loop test the inverse of the in-loop.
06a0259a 11363
e7b9e80f
PE
11364 * print.c (print_error_message): Avoid int overflow.
11365
56201685
PE
11366 * font.c (font_list_entities): Redo for clarity,
11367 so that reader need not know FONT_DPI_INDEX + 1 == FONT_SPACING_INDEX.
11368
78834453 11369 * font.c (font_find_for_lface, Ffont_get_glyphs): Remove unused vars.
790771b1 11370 (font_score): Avoid potential overflow in diff calculation.
78834453 11371
0bc0b309 11372 * fns.c (substring_both): Remove var that is set but not used.
8cd55cb4 11373 (sxhash): Redo loop for clarity and to avoid wraparound warning.
0bc0b309 11374
e610eaca
PE
11375 * eval.c (funcall_lambda): Rename local to avoid shadowing.
11376
b895abce
PE
11377 * alloc.c (mark_object_loop_halt, mark_object): Use size_t, not int.
11378 Otherwise, GCC 4.6.0 optimizes the loop check away since the check
11379 can always succeed if overflow has undefined behavior.
11380
1f1d9321 11381 * search.c (boyer_moore, wordify): Remove vars set but not used.
6f076cc7 11382 (wordify): Omit three unnecessary tests.
1f1d9321 11383
c59478bc
PE
11384 * indent.c (MULTIBYTE_BYTES_WIDTH): Don't compute wide_column.
11385 All callers changed. This avoids the need for an unused var.
11386
79b73827
PE
11387 * casefiddle.c (casify_region): Remove var that is set but not used.
11388
a4db5dfe
PE
11389 * dired.c (file_name_completion): Remove var that is set but not used.
11390
43aae36e
PE
11391 * fileio.c (Finsert_file_contents): Make EOF condition clearer.
11392
2a47c44d 11393 * fileio.c (Finsert_file_contents): Avoid signed integer overflow.
163c5f32 11394 (Finsert_file_contents): Remove unnecessary code checking fd.
2a47c44d 11395
a37c69bf
PE
11396 * minibuf.c (read_minibuf_noninteractive): Use size_t for sizes.
11397 Check for integer overflow on size calculations.
11398
328ab8e7
PE
11399 * buffer.c (Fprevious_overlay_change): Remove var that is set
11400 but not used.
11401
e5a2a5cb
PE
11402 * keyboard.c (menu_bar_items, read_char_minibuf_menu_prompt):
11403 Remove vars that are set but not used.
8d84a6eb 11404 (timer_check_2): Don't assume timer-list and idle-timer-list are lists.
6b043475 11405 (timer_check_2): Mark vars as initialized.
e5a2a5cb 11406
a60e5f68
PE
11407 * gtkutil.c (xg_get_file_with_chooser): Mark var as initialized.
11408
f661cb61 11409 * image.c (lookup_image): Remove var that is set but not used.
35fa624f 11410 (xbm_load): Use parse_p, for gcc -Werror=unused-but-set-variable.
f661cb61 11411
f0397f5a
PE
11412 * fontset.c (Finternal_char_font, Ffontset_info): Remove vars
11413 that are set but not used.
11414
8664db06 11415 * xfns.c (make_invisible_cursor): Don't return garbage
03733ee7 11416 if XCreateBitmapFromData fails (Bug#8410).
8664db06 11417
6abdaa4a
PE
11418 * xselect.c (x_get_local_selection, x_handle_property_notify):
11419 Remove vars that are set but not used.
11420
0ce7538d 11421 * xfns.c (x_create_tip_frame): Remove var that is set but not used.
6abdaa4a 11422 (make_invisible_cursor): Initialize a possibly-uninitialized variable.
0ce7538d 11423
9ae848fc
PE
11424 * xterm.c (x_scroll_bar_to_input_event) [!USE_GTK]:
11425 Remove var that is set but not used.
0b918413
PE
11426 (scroll_bar_windows_size): Now size_t, not int.
11427 (x_send_scroll_bar_event): Use size_t, not int, for sizes.
11428 Check for overflow.
9ae848fc 11429
a5a62657
PE
11430 * xfaces.c (realize_named_face): Remove vars that are set but not used.
11431 (map_tty_color) [!defined MSDOS]: Likewise.
11432
5c5cdd39
PE
11433 * term.c (tty_write_glyphs): Use size_t; this avoids overflow warning.
11434
66ebf983
PE
11435 * coding.c: Remove vars that are set but not used.
11436 (DECODE_COMPOSITION_RULE): Remove 2nd arg, which is unused.
11437 All callers changed.
11438 (decode_coding_utf_8, decode_coding_utf_16 decode_coding_emacs_mule):
11439 (decode_coding_iso_2022, encode_coding_sjis, encode_coding_big5):
11440 (decode_coding_charset): Remove vars that are set but not used.
11441
1be4d761
PE
11442 * bytecode.c (Fbyte_code) [!defined BYTE_CODE_SAFE]: Remove var
11443 that is set but not used.
11444
47553fa8
PE
11445 * print.c (print_object): Remove var that is set but not used.
11446
1f7196bf 11447 Replace 2 copies of readlink code with 1 gnulib version (Bug#8401).
d1fdcab7
PE
11448 The gnulib version avoids calling malloc in the usual case,
11449 and on 64-bit hosts doesn't have some arbitrary 32-bit limits.
11450 * fileio.c (Ffile_symlink_p): Use emacs_readlink.
11451 * filelock.c (current_lock_owner): Likewise.
11452 * lisp.h (READLINK_BUFSIZE, emacs_readlink): New function.
11453 * sysdep.c: Include allocator.h, careadlinkat.h.
11454 (emacs_no_realloc_allocator): New static constant.
11455 (emacs_readlink): New function.
fdb61804
PE
11456 * deps.mk (sysdep.o): Depend on ../lib/allocator.h and on
11457 ../lib/careadlinkat.h.
d1fdcab7 11458
f84c17c7
SM
114592011-04-04 Stefan Monnier <monnier@iro.umontreal.ca>
11460
11461 * keyboard.c (safe_run_hook_funcall): Fix last change (don't stop at the
11462 first non-nil return value).
11463
ef3862ad
JD
114642011-04-03 Jan Djärv <jan.h.d@swipnet.se>
11465
11466 * nsterm.m (ns_update_auto_hide_menu_bar): Define MAC_OS_X_VERSION_10_6
11467 if not defined (Bug#8403).
11468
376a7006
JB
114692011-04-02 Juanma Barranquero <lekktu@gmail.com>
11470
11471 * xdisp.c (display_count_lines): Remove parameter `start',
11472 unused since 1998-01-01T02:27:27Z!rms@gnu.org. All callers changed.
11473 (get_char_face_and_encoding): Remove parameter `multibyte_p',
11474 unused since 2008-05-14T01:40:23Z!handa@m17n.org. All callers changed.
11475 (fill_stretch_glyph_string): Remove parameters `row' and `area',
11476 unused at least since Kim's GUI unification at 2003-03-16T20:45:46Z!storm@cua.dk
11477 and thereabouts. All callers changed.
11478 (get_per_char_metric): Remove parameter `f', unused since
11479 2008-05-14T01:40:23Z!handa@m17n.org. All callers changed.
11480
6ca3801d
JM
114812011-04-02 Jim Meyering <meyering@redhat.com>
11482
11483 do not dereference NULL upon failed strdup
11484 * nsfont.m (ns_descriptor_to_entity): Use xstrdup, not strdup.
11485 (ns_get_family): Likewise.
11486
d8e2b5ba
JB
114872011-04-02 Juanma Barranquero <lekktu@gmail.com>
11488
11489 * eval.c (unwind_to_catch) [DEBUG_GCPRO]: Remove redundant assignment.
11490
8c74fcbd
JD
114912011-04-02 Jan Djärv <jan.h.d@swipnet.se>
11492
11493 * nsterm.m (ns_update_auto_hide_menu_bar): Only for OSX 10.6 or
11494 later (Bug#8403).
11495
7200d79c
SM
114962011-04-01 Stefan Monnier <monnier@iro.umontreal.ca>
11497
03408648 11498 Add lexical binding.
7200d79c 11499
03408648
SM
11500 * window.c (Ftemp_output_buffer_show): New fun.
11501 (Fsave_window_excursion):
11502 * print.c (Fwith_output_to_temp_buffer): Move to subr.el.
11503
11504 * lread.c (lisp_file_lexically_bound_p): New function.
11505 (Fload): Bind Qlexical_binding.
11506 (readevalloop): Remove `evalfun' arg.
11507 Bind Qinternal_interpreter_environment.
11508 (Feval_buffer): Bind Qlexical_binding.
11509 (defvar_int, defvar_bool, defvar_lisp_nopro, defvar_kboard):
11510 Mark as dynamic.
11511 (syms_of_lread): Declare `lexical-binding'.
11512
11513 * lisp.h (struct Lisp_Symbol): New field `declared_special'.
11514
11515 * keyboard.c (eval_dyn): New fun.
11516 (menu_item_eval_property): Use it.
ca105506
SM
11517
11518 * image.c (parse_image_spec): Use Ffunctionp.
ca105506 11519
03408648
SM
11520 * fns.c (concat, mapcar1): Accept byte-code-functions.
11521
11522 * eval.c (Fsetq): Handle lexical vars.
11523 (Fdefun, Fdefmacro, Ffunction): Make closures when needed.
11524 (Fdefconst, Fdefvaralias, Fdefvar): Mark as dynamic.
11525 (FletX, Flet): Obey lexical binding.
11526 (Fcommandp): Handle closures.
11527 (Feval): New `lexical' arg.
11528 (eval_sub): New function extracted from Feval. Use it almost
11529 everywhere where Feval was used. Look up vars in lexical env.
11530 Handle closures.
11531 (Ffunctionp): Move from subr.el.
11532 (Ffuncall): Handle closures.
11533 (apply_lambda): Remove `eval_flags'.
11534 (funcall_lambda): Handle closures and new byte-code-functions.
11535 (Fspecial_variable_p): New function.
11536 (syms_of_eval): Initialize the Vinternal_interpreter_environment var,
11537 but without exporting it to Lisp.
23aba0ea 11538
23aba0ea 11539 * doc.c (Fdocumentation, store_function_docstring):
03408648 11540 * data.c (Finteractive_form): Handle closures.
23aba0ea 11541
03408648
SM
11542 * callint.c (Fcall_interactively): Preserve lexical-binding mode for
11543 interactive spec.
ba83908c 11544
04f2d78b
CB
11545 * bytecode.c (Bstack_ref, Bstack_set, Bstack_set2, BdiscardN):
11546 New byte-codes.
03408648
SM
11547 (exec_byte_code): New function extracted from Fbyte_code to handle new
11548 calling convention for byte-code-functions. Add new byte-codes.
ba83908c 11549
03408648 11550 * buffer.c (defvar_per_buffer): Set new `declared_special' field.
e2abe5a1 11551
03408648 11552 * alloc.c (Fmake_symbol): Init new `declared_special' field.
e2abe5a1 11553
e2abce01
JB
115542011-03-31 Juanma Barranquero <lekktu@gmail.com>
11555
11556 * xdisp.c (redisplay_internal): Fix prototype.
11557
63696a73 115582011-03-31 Eli Zaretskii <eliz@gnu.org>
09725d26 11559
63696a73 11560 * xdisp.c (SCROLL_LIMIT): New macro.
04f2d78b
CB
11561 (try_scrolling): Use it when setting scroll_limit.
11562 Limit scrolling to 100 screen lines.
63696a73
EZ
11563 (redisplay_window): Even when falling back on "recentering",
11564 position point in the window according to scroll-conservatively,
11565 scroll-margin, and scroll-*-aggressively variables. (Bug#6671)
11566
11567 (try_scrolling): When point is above the window, allow searching
11568 as far as scroll_max, or one screenful, to compute vertical
11569 distance from PT to the scroll margin position. This prevents
11570 try_scrolling from unnecessarily failing when
11571 scroll-conservatively is set to a value slightly larger than the
11572 window height. Clean up the case of PT below the margin at bottom
11573 of window: scroll_max can no longer be INT_MAX. When aggressive
11574 scrolling is in use, don't let point enter the opposite scroll
11575 margin as result of the scroll.
11576 (syms_of_xdisp) <scroll-conservatively>: Document the
09725d26
EZ
11577 threshold of 100 lines for never-recentering scrolling.
11578
e4cc2dfc
JB
115792011-03-31 Juanma Barranquero <lekktu@gmail.com>
11580
11581 * dispextern.h (move_it_by_lines):
11582 * xdisp.c (move_it_by_lines): Remove parameter `need_y_p', unused
11583 since 2000-12-29T14:24:09Z!gerd@gnu.org. All callers changed.
11584 (message_log_check_duplicate): Remove parameters `prev_bol' and
11585 `this_bol', unused since 1998-01-01T02:27:27Z!rms@gnu.org. All callers changed.
11586 (redisplay_internal): Remove parameter `preserve_echo_area',
11587 unused since 1999-07-21T21:43:52Z!gerd@gnu.org. All callers changed.
11588
11589 * indent.c (Fvertical_motion):
11590 * window.c (window_scroll_pixel_based, Frecenter):
11591 Don't pass `need_y_p' to `move_it_by_lines'.
11592
1c470562
SM
115932011-03-30 Stefan Monnier <monnier@iro.umontreal.ca>
11594
44f230aa
SM
11595 * eval.c (struct backtrace): Don't cheat with negative numbers, but do
11596 steal a few bits to be more compact.
11597 (interactive_p, Fbacktrace, Fbacktrace_frame, mark_backtrace):
11598 Remove unneeded casts.
11599
1c470562
SM
11600 * bytecode.c (Fbyte_code): CAR and CDR can GC.
11601
888adce9
ZK
116022011-03-30 Zachary Kanfer <zkanfer@gmail.com> (tiny change)
11603
11604 * keyboard.c (Fexecute_extended_command): Do log the "suggest key
11605 binding" message (bug#7967).
11606
f838ed7b
PE
116072011-03-30 Paul Eggert <eggert@cs.ucla.edu>
11608
77861b95
PE
11609 Fix more problems found by GCC 4.6.0's static checks.
11610
de6dbc14
PE
11611 * unexelf.c (unexec) [! (defined _SYSTYPE_SYSV || defined __sgi)]:
11612 Remove unused local var.
11613
f838ed7b
PE
11614 * editfns.c (Fmessage_box): Remove unused local var.
11615
792c7b2b
PE
11616 * xdisp.c (try_window_reusing_current_matrix, x_produce_glyphs):
11617 (note_mode_line_or_margin_highlight, note_mouse_highlight):
11618 Omit unused local vars.
c499e557 11619 * window.c (shrink_windows): Omit unused local var.
b01a1c29 11620 * menu.c (digest_single_submenu): Omit unused local var.
0bc32927
PE
11621 * dispnew.c (update_window) [PERIODIC_PREEMPTION_CHECKING]:
11622 Omit unused local var.
11623
ba0165e1
PE
11624 * keyboard.c (parse_modifiers_uncached, parse_modifiers):
11625 Don't assume string length fits in int.
32ad8845 11626 (keyremap_step, read_key_sequence): Use size_t for sizes.
48011560 11627 (read_key_sequence): Don't check last_real_key_start redundantly.
ba0165e1 11628
3c59b4c9
PE
11629 * callproc.c (Fcall_process, Fcall_process_region): Use SAFE_ALLOCA
11630 instead of alloca (Bug#8344).
11631
a3eed478 11632 * eval.c (Fbacktrace): Don't assume nargs fits in int.
5d5d959d 11633 (Fbacktrace_frame): Don't assume nframes fits in int.
a3eed478 11634
eb4d412d
PE
11635 * syntax.c (scan_sexps_forward): Avoid pointer wraparound.
11636
1658b401
PE
11637 * xterm.c (x_make_frame_visible, same_x_server): Redo to avoid overflow
11638 concerns.
11639
11640 * term.c (produce_glyphless_glyph): Remove unnecessary test.
11641
11642 * cm.c (calccost): Turn while-do into do-while, for clarity.
44f730c8 11643
9a2c6e05
PE
11644 * keyboard.c (syms_of_keyboard): Use the same style as later
11645 in this function when indexing through an array. This also
11646 works around GCC bug 48267.
11647
03d0a109
PE
11648 * image.c (tiff_load): Fix off-by-one image count (Bug#8336).
11649
44f730c8
PE
11650 * xselect.c (x_check_property_data): Return correct size (Bug#8335).
11651
fe75f926
PE
11652 * chartab.c (sub_char_table_ref_and_range): Redo for slight
11653 efficiency gain, and to bypass a gcc -Wstrict-overflow warning.
11654
ffa8c828
PE
11655 * keyboard.c, keyboard.h (num_input_events): Now size_t.
11656 This avoids undefined behavior on integer overflow, and is a bit
11657 more convenient anyway since it is compared to a size_t variable.
11658
c5101a77
PE
11659 Variadic C functions now count arguments with size_t, not int.
11660 This avoids an unnecessary limitation on 64-bit machines, which
11661 caused (substring ...) to crash on large vectors (Bug#8344).
11662 * lisp.h (struct Lisp_Subr.function.aMANY): Now takes size_t, not int.
11663 (DEFUN_ARGS_MANY, internal_condition_case_n, safe_call): Likewise.
77861b95 11664 All variadic functions and their callers changed accordingly.
c5101a77
PE
11665 (struct gcpro.nvars): Now size_t, not int. All uses changed.
11666 * data.c (arith_driver, float_arith_driver): Likewise.
11667 * editfns.c (general_insert_function): Likewise.
11668 * eval.c (struct backtrace.nargs, interactive_p)
11669 (internal_condition_case_n, run_hook_with_args, apply_lambda)
11670 (funcall_lambda, mark_backtrace): Likewise.
11671 * fns.c (concat): Likewise.
11672 * frame.c (x_set_frame_parameters): Likewise.
11673 * fns.c (get_key_arg): Now accepts and returns size_t, and returns
11674 0 if not found, not -1. All callers changed.
11675
dd3f25f7
PE
11676 * alloc.c (garbage_collect): Don't assume stack size fits in int.
11677 (stack_copy_size): Now size_t, not int.
11678 (stack_copy, stack_copy_size): Define only if MAX_SAVE_STACK > 0.
11679
461c2ab9
JB
116802011-03-28 Juanma Barranquero <lekktu@gmail.com>
11681
11682 * coding.c (encode_designation_at_bol): Remove parameter `charbuf_end',
11683 unused since 2002-03-01T01:17:24Z!handa@m17n.org and 2008-02-01T16:01:31Z!miles@gnu.org.
11684 All callers changed.
11685
11686 * lisp.h (multibyte_char_to_unibyte):
11687 * character.c (multibyte_char_to_unibyte): Remove parameter `rev_tbl',
11688 unused since 2002-03-01T01:16:34Z!handa@m17n.org and 2008-02-01T16:01:31Z!miles@gnu.org.
11689 * character.h (CHAR_TO_BYTE8):
11690 * cmds.c (internal_self_insert):
11691 * editfns.c (general_insert_function):
11692 * keymap.c (push_key_description):
11693 * search.c (Freplace_match):
11694 * xdisp.c (message_dolog, set_message_1): All callers changed.
11695
f6d62986
SM
116962011-03-28 Stefan Monnier <monnier@iro.umontreal.ca>
11697
11698 * keyboard.c (safe_run_hook_funcall): New function.
11699 (safe_run_hooks_1, safe_run_hooks_error, safe_run_hooks): On error,
11700 don't set the hook to nil, but remove the offending function instead.
11701 (Qcommand_hook_internal): Remove, unused.
11702 (syms_of_keyboard): Don't initialize Qcommand_hook_internal nor define
11703 Vcommand_hook_internal.
11704
11705 * eval.c (enum run_hooks_condition): Remove.
11706 (funcall_nil, funcall_not): New functions.
11707 (run_hook_with_args): Call each function through a `funcall' argument.
11708 Remove `cond' argument, now redundant.
11709 (Frun_hooks, Frun_hook_with_args, Frun_hook_with_args_until_success)
11710 (Frun_hook_with_args_until_failure): Adjust accordingly.
11711 (run_hook_wrapped_funcall, Frun_hook_wrapped): New functions.
11712
1db5b1ad
JB
117132011-03-28 Juanma Barranquero <lekktu@gmail.com>
11714
11715 * dispextern.h (string_buffer_position): Remove declaration.
11716
11717 * print.c (strout): Remove parameter `multibyte', unused since
11718 1999-08-21T19:30:21Z!gerd@gnu.org. All callers changed.
11719
11720 * search.c (boyer_moore): Remove parameters `len', `pos' and `lim',
11721 never used since function introduction in 1998-02-08T21:33:56Z!rms@gnu.org.
11722 All callers changed.
11723
11724 * w32.c (_wsa_errlist): Use braces for struct initializers.
11725
11726 * xdisp.c (string_buffer_position_lim): Remove parameter `w',
11727 never used since function introduction in 2001-03-09T18:41:50Z!gerd@gnu.org.
11728 All callers changed.
11729 (string_buffer_position): Likewise. Also, make static (it's never
11730 used outside xdisp.c).
11731 (cursor_row_p): Remove parameter `w', unused since
11732 2000-10-17T16:08:57Z!gerd@gnu.org. All callers changed.
11733 (decode_mode_spec): Remove parameter `precision', introduced during
11734 Gerd Moellmann's rewrite at 1999-07-21T21:43:52Z!gerd@gnu.org, but never used.
11735 All callers changed.
11736
5ffb62aa
JD
117372011-03-27 Jan Djärv <jan.h.d@swipnet.se>
11738
11739 * nsterm.m (syms_of_nsterm): Use doc: for ns-auto-hide-menu-bar.
11740
461c2ab9 117412011-03-27 Anders Lindgren <andlind@gmail.com>
f0a1382a
JD
11742
11743 * nsterm.m (ns_menu_bar_is_hidden): New variable.
11744 (ns_constrain_all_frames, ns_menu_bar_should_be_hidden)
11745 (ns_update_auto_hide_menu_bar): New functions.
11746 (ns_update_begin): Call ns_update_auto_hide_menu_bar.
11747 (applicationDidBecomeActive): Call ns_update_auto_hide_menu_bar and
11748 ns_constrain_all_frames.
11749 (constrainFrameRect): Return at once if ns_menu_bar_should_be_hidden.
11750 (syms_of_nsterm): DEFVAR ns-auto-hide-menu-bar, init to Qnil.
11751
5c380ffb
JD
117522011-03-27 Jan Djärv <jan.h.d@swipnet.se>
11753
11754 * nsmenu.m (runDialogAt): Remove argument to timer_check.
11755
9af30bdf
GM
117562011-03-27 Glenn Morris <rgm@gnu.org>
11757
11758 * syssignal.h: Replace RETSIGTYPE with void.
11759 * atimer.c, data.c, dispnew.c, emacs.c, floatfns.c, keyboard.c:
11760 * keyboard.h, lisp.h, process.c, sysdep.c, xterm.c:
11761 Replace SIGTYPE with void everywhere.
11762 * s/usg5-4-common.h (SIGTYPE): Remove definition.
11763 * s/template.h (SIGTYPE): Remove commented out definition.
11764
e2abce01
JB
117652011-03-26 Eli Zaretskii <eliz@gnu.org>
11766
11767 * xdisp.c (redisplay_window): Don't check buffer's clip_changed
11768 flag as a prerequisite for invoking try_scrolling. (Bug#6671)
11769
f868cd8a
JB
117702011-03-26 Juanma Barranquero <lekktu@gmail.com>
11771
59eb0929
JB
11772 * w32.c (read_unc_volume): Use parameter `henum', instead of
11773 global variable `wget_enum_handle'.
11774
11775 * keymap.c (describe_vector): Remove parameters `indices' and
11776 `char_table_depth', unused since 2002-03-01T01:43:26Z!handa@m17n.org.
11777 (describe_map, Fdescribe_vector): Adjust calls to `describe_vector'.
11778
f868cd8a
JB
11779 * keyboard.h (timer_check, show_help_echo): Remove unused parameters.
11780
11781 * keyboard.c (timer_check): Remove parameter `do_it_now',
11782 unused since 1996-04-12T06:01:29Z!rms@gnu.org.
11783 (show_help_echo): Remove parameter `ok_to_overwrite_keystroke_echo',
11784 unused since 2008-04-19T19:30:53Z!monnier@iro.umontreal.ca.
11785
11786 * keyboard.c (read_char):
11787 * w32menu.c (w32_menu_display_help):
11788 * xmenu.c (show_help_event, menu_help_callback):
11789 Adjust calls to `show_help_echo'.
11790
11791 * gtkutil.c (xg_maybe_add_timer):
11792 * keyboard.c (readable_events):
11793 * process.c (wait_reading_process_output):
11794 * xmenu.c (x_menu_wait_for_event): Adjust calls to `timer_check'.
11795
11796 * insdel.c (adjust_markers_gap_motion):
11797 Remove; no-op since 1998-01-02T21:29:48Z!rms@gnu.org.
11798 (gap_left, gap_right): Don't call it.
11799
2ecf6fdb
CY
118002011-03-25 Chong Yidong <cyd@stupidchicken.com>
11801
11802 * xdisp.c (handle_fontified_prop): Discard changes to clip_changed
11803 incurred during fontification.
11804
6b1f9ba4
JB
118052011-03-25 Juanma Barranquero <lekktu@gmail.com>
11806
11807 * buffer.c (defvar_per_buffer): Remove unused parameter `doc'.
11808 (DEFVAR_PER_BUFFER): Don't pass it.
11809
11810 * dispnew.c (row_equal_p, add_row_entry): Remove unused parameter `w'.
11811 (scrolling_window): Don't pass it.
11812
0f4a96b5
JB
118132011-03-25 Juanma Barranquero <lekktu@gmail.com>
11814
11815 * dispextern.h (glyph_matric): Use #if GLYPH_DEBUG, not #ifdef.
11816
11817 * fileio.c (check_executable) [DOS_NT]: Remove unused variables `len'
11818 and `suffix'.
11819 (Fset_file_selinux_context) [HAVE_LIBSELINUX]: Move here declaration
11820 of variables specific to SELinux and computation of `encoded_absname'.
11821
11822 * image.c (XPutPixel): Remove unused variable `height'.
11823
11824 * keyboard.c (make_lispy_event): Remove unused variable `hpos'.
11825
11826 * unexw32.c (get_section_info): Remove unused variable `section'.
11827
11828 * w32.c (stat): Remove unused variables `drive_root' and `devtype'.
11829 (system_process_attributes): Remove unused variable `sess'.
11830 (sys_read): Remove unused variable `err'.
11831
11832 * w32fns.c (top): Wrap variables with #if GLYPH_DEBUG, not #ifdef.
11833 (w32_wnd_proc): Remove unused variable `isdead'.
11834 (unwind_create_frame): Use #if GLYPH_DEBUG, not #ifdef.
11835 (Fx_server_max_request_size): Remove unused variable `dpyinfo'.
11836 (x_create_tip_frame): Remove unused variable `tem'.
11837
11838 * w32inevt.c (w32_console_read_socket):
11839 Remove unused variable `no_events'.
11840
11841 * w32term.c (x_draw_composite_glyph_string_foreground):
11842 Remove unused variable `width'.
11843
1149507c
JB
118442011-03-24 Juanma Barranquero <lekktu@gmail.com>
11845
11846 * w32term.c (x_set_glyph_string_clipping):
11847 Don't pass uninitialized region to CombineRgn.
11848
9c88f339
JB
118492011-03-23 Juanma Barranquero <lekktu@gmail.com>
11850
11851 * w32fns.c (x_set_menu_bar_lines): Remove unused variable `olines'.
11852 (w32_wnd_proc): Pass NULL to Windows API, not uninitialized buffer.
11853 (Fx_close_connection): Remove unused variable `i'.
11854
11855 * w32font.c (w32font_draw): Return number of glyphs.
11856 (w32font_open_internal): Remove unused variable `i'.
11857 (w32font_driver): Add missing initializer.
11858
11859 * w32menu.c (utf8to16): Remove unused variable `utf16'.
11860 (fill_in_menu): Remove unused variable `items_added'.
11861
11862 * w32term.c (last_mouse_press_frame): Remove static global variable.
11863 (w32_clip_to_row): Remove unused variable `f'.
11864 (x_delete_terminal): Remove unused variable `i'.
11865
11866 * w32uniscribe.c (uniscribe_shape): Remove unused variable `nclusters'.
11867 (NOTHING): Remove unused static global variable.
11868 (uniscribe_check_otf): Remove unused variable `table'.
11869 (uniscribe_font_driver): Add missing initializers.
11870
dee091a3
JD
118712011-03-23 Julien Danjou <julien@danjou.info>
11872
11873 * term.c (Fsuspend_tty, Fresume_tty):
11874 * minibuf.c (read_minibuf, run_exit_minibuf_hook):
11875 * window.c (temp_output_buffer_show):
11876 * insdel.c (signal_before_change):
11877 * frame.c (Fhandle_switch_frame):
11878 * fileio.c (Fdo_auto_save):
11879 * emacs.c (Fkill_emacs):
11880 * editfns.c (save_excursion_restore):
11881 * cmds.c (internal_self_insert):
11882 * callint.c (Fcall_interactively):
11883 * buffer.c (Fkill_all_local_variables):
11884 * keyboard.c (Fcommand_execute, Fsuspend_emacs, safe_run_hooks_1):
11885 Use Frun_hooks.
0f4a96b5 11886 (command_loop_1): Use Frun_hooks. Call safe_run_hooks
e9fce1ac 11887 unconditionally since it does the check itself.
dee091a3 11888
2c520ab5 118892011-03-23 Paul Eggert <eggert@cs.ucla.edu>
f0641eff 11890
c9c49752
PE
11891 Fix more problems found by GCC 4.5.2's static checks.
11892
8abc3f12
PE
11893 * coding.c (encode_coding_raw_text): Avoid unnecessary test
11894 the first time through the loop, since we know p0 < p1 then.
11895 This also avoids a gcc -Wstrict-overflow warning.
11896
a2d26660
PE
11897 * lisp.h (SAFE_ALLOCA, SAFE_ALLOCA_LISP): Avoid 'int' overflow
11898 leading to a memory leak, possible in functions like
11899 load_charset_map_from_file that can allocate an unbounded number
b12ef411 11900 of objects (Bug#8318).
a2d26660 11901
916c72e9
PE
11902 * xmenu.c (set_frame_menubar): Use EMACS_UINT, not int, for indexes
11903 that could (at least in theory) be that large.
11904
19ab8a18
PE
11905 * xdisp.c (message_log_check_duplicate): Return unsigned long, not int.
11906 This is less likely to overflow, and avoids undefined behavior if
11907 overflow does occur. All callers changed. Use strtoul to scan
11908 for the unsigned long integer.
b7cbbd6f
PE
11909 (pint2hrstr): Simplify and tune code slightly.
11910 This also avoids a (bogus) GCC warning with gcc -Wstrict-overflow.
19ab8a18 11911
f0641eff
PE
11912 * scroll.c (do_scrolling): Work around GCC bug 48228.
11913 See <http://gcc.gnu.org/bugzilla/show_bug.cgi?id=48228>.
11914
7f650bb9
PE
11915 * frame.c (Fmodify_frame_parameters): Simplify loop counter.
11916 This also avoids a warning with gcc -Wstrict-overflow.
39f5e519
PE
11917 (validate_x_resource_name): Simplify count usage.
11918 This also avoids a warning with gcc -Wstrict-overflow.
7f650bb9 11919
37dd57d1
PE
11920 * fileio.c (Fcopy_file): Report error if fchown or fchmod
11921 fail (Bug#8306).
81e56e61 11922
699979fc 11923 * emacs.c (Fdaemon_initialized): Do not ignore I/O errors (Bug#8303).
dc1ca6a8 11924
401bf9b4
PE
11925 * process.c (Fmake_network_process): Use socklen_t, not int,
11926 where POSIX says socklen_t is required in portable programs.
11927 This fixes a porting bug on hosts like 64-bit HP-UX, where
591b2973 11928 socklen_t is wider than int (Bug#8277).
401bf9b4
PE
11929 (Fmake_network_process, server_accept_connection):
11930 (wait_reading_process_output, read_process_output):
11931 Likewise.
11932
b93aacde
PE
11933 * process.c: Rename or move locals to avoid shadowing.
11934 (list_processes_1, Fmake_network_process):
11935 (read_process_output_error_handler, exec_sentinel_error_handler):
11936 Rename or move locals.
4dc343ee 11937 (Fmake_network_process): Define label "retry_connect" only if needed.
0da49335 11938 (Fnetwork_interface_info): Fix pointer signedness.
f990b4e5 11939 (process_send_signal): Add cast to avoid pointer signedness problem.
7b808126 11940 (FIRST_PROC_DESC, IF_NON_BLOCKING_CONNECT): Remove unused macros.
c939f91b 11941 (create_process): Use 'volatile' to avoid vfork clobbering (Bug#8298).
b93aacde 11942
af8a867c 11943 Make tparam.h and terminfo.c consistent.
44f230aa
SM
11944 * cm.c (tputs, tgoto, BC, UP): Remove extern decls.
11945 Include tparam.h instead, since it declares them.
af8a867c
PE
11946 * cm.h (PC): Remove extern decl; tparam.h now does this.
11947 * deps.mk (cm.o, terminfo.o): Depend on tparam.h.
11948 * terminfo.c: Include tparam.h, to check interfaces.
11949 (tparm): Make 1st arg a const pointer in decl. Put it at top level.
11950 (tparam): Adjust signature to match interface in tparam.h;
11951 this removes some undefined behavior. Check that outstring and len
11952 are zero, which they always are with Emacs.
11953 * tparam.h (PC, BC, UP): New extern decls.
11954
0248044d 11955 * xftfont.c (xftfont_shape): Now static, and defined only if needed.
001a7ab4 11956 (xftfont_open): Rename locals to avoid shadowing.
0248044d 11957
8ff096c1 11958 * ftfont.c (ftfont_resolve_generic_family): Fix pointer signedness.
a00924bb
PE
11959 (ftfont_otf_capability, ftfont_shape): Omit decls if not needed.
11960 (OTF_TAG_SYM): Omit macro if not needed.
e932860f 11961 (ftfont_list): Remove unused local.
49eaafba
PE
11962 (get_adstyle_property, ftfont_pattern_entity):
11963 (ftfont_lookup_cache, ftfont_open, ftfont_anchor_point):
11964 Rename locals to avoid shadowing.
8ff096c1 11965
e2be39f6
PE
11966 * xfont.c (xfont_list_family): Mark var as initialized.
11967
c9735e30
PE
11968 * xml.c (make_dom): Now static.
11969
8f5201ae
PE
11970 * composite.c (composition_compute_stop_pos): Rename local to
11971 avoid shadowing.
b246f932
PE
11972 (composition_reseat_it): Remove unused locals.
11973 (find_automatic_composition, composition_adjust_point): Likewise.
80e079b2 11974 (composition_update_it): Mark var as initialized.
11b61122
PE
11975 (find_automatic_composition): Mark vars as initialized,
11976 with a FIXME (Bug#8290).
8f5201ae 11977
760fbc2c
PE
11978 character.h: Rename locals to avoid shadowing.
11979 * character.h (PREV_CHAR_BOUNDARY, FETCH_STRING_CHAR_ADVANCE):
11980 (FETCH_STRING_CHAR_AS_MULTIBYTE_ADVANCE, FETCH_CHAR_ADVANCE):
11981 (FETCH_CHAR_ADVANCE_NO_CHECK, INC_POS, DEC_POS, BUF_INC_POS):
11982 (BUF_DEC_POS): Be more systematic about renaming local temporaries
11983 to avoid shadowing.
11984
ff08eb85
PE
11985 * textprop.c (property_change_between_p): Remove; unused.
11986
fc7bf025
PE
11987 * intervals.c (interval_start_pos): Now static.
11988
235d7abc
PE
11989 * intervals.h (CHECK_TOTAL_LENGTH): Avoid empty "else".
11990
44f230aa
SM
11991 * atimer.c (start_atimer, append_atimer_lists, set_alarm):
11992 Rename locals to avoid shadowing.
3e7d6594 11993
50060332
PE
11994 * sound.c (wav_play, au_play, Fplay_sound_internal):
11995 Fix pointer signedness.
d01f234b 11996 (alsa_choose_format): Remove unused local var.
c83b8872
PE
11997 (wav_play): Initialize a variable to 0, to prevent undefined
11998 behavior (Bug#8278).
50060332 11999
c4fc4e30
PE
12000 * region-cache.c (insert_cache_boundary): Redo var to avoid shadowing.
12001
918436ed
PE
12002 * region-cache.h (pp_cache): New decl, for gcc -Wmissing-prototypes.
12003
c939f91b
PE
12004 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork
12005 clobbering (Bug#8298).
b9c7f648
PE
12006 * sysdep.c (sys_subshell): Likewise.
12007 Previously, the sys_subshell 'volatile' was incorrectly IF_LINTted out.
7e9123a2 12008
6bd8c144
PE
12009 * lisp.h (child_setup): Now NO_RETURN unless DOS_NT.
12010 This should get cleaned up, so that child_setup has the
12011 same signature on all platforms.
12012
7710357c 12013 * callproc.c (call_process_cleanup): Now static.
cb1d0ef7 12014 (relocate_fd): Rename locals to avoid shadowing.
7710357c 12015
c59da222
CY
120162011-03-22 Chong Yidong <cyd@stupidchicken.com>
12017
12018 * xterm.c (x_clear_frame): Remove XClearWindow call. This appears
12019 not to be necessary, and produces flickering.
12020
66b87493
GM
120212011-03-20 Glenn Morris <rgm@gnu.org>
12022
12023 * config.in: Remove file.
12024
45b6f6d5
JB
120252011-03-20 Juanma Barranquero <lekktu@gmail.com>
12026
12027 * minibuf.c (Vcompleting_read_function): Don't declare, global variables
12028 are now in src/globals.h.
12029 (syms_of_minibuf): Remove spurious & from previous change.
12030
cd394be1 120312011-03-20 Leo Liu <sdl.web@gmail.com>
3ec03f7e
LL
12032
12033 * minibuf.c (completing-read-function): New variable.
12034 (completing-read-default): Rename from completing-read.
12035 (completing-read): Call completing-read-function.
12036
b14e3e21
CY
120372011-03-19 Juanma Barranquero <lekktu@gmail.com>
12038
12039 * xfaces.c (Fx_load_color_file):
12040 Read color file from absolute filename (bug#8250).
12041
f2b726e6
JB
120422011-03-19 Juanma Barranquero <lekktu@gmail.com>
12043
12044 * makefile.w32-in: Update dependencies.
12045
09f6ff02
EZ
120462011-03-17 Eli Zaretskii <eliz@gnu.org>
12047
12048 * makefile.w32-in ($(BLD)/unexw32.$(O)): Depend on $(SRC)/unexec.h.
12049
29a6015a
PE
120502011-03-17 Paul Eggert <eggert@cs.ucla.edu>
12051
a3a6c54e
PE
12052 Fix more problems found by GCC 4.5.2's static checks.
12053
b766f867
PE
12054 * process.c (make_serial_process_unwind, send_process_trap):
12055 (sigchld_handler): Now static.
12056
be02381c
PE
12057 * process.c (allocate_pty): Let PTY_ITERATION declare iteration vars.
12058 That way, the code declares only the vars that it needs.
12059 * s/aix4-2.h (PTY_ITERATION): Declare iteration vars.
12060 * s/cygwin.h (PTY_ITERATION): Likewise.
12061 * s/darwin.h (PTY_ITERATION): Likewise.
12062 * s/gnu-linux.h (PTY_ITERATION): Likewise.
12063
57048744
PE
12064 * s/irix6-5.h (PTY_OPEN): Declare stb, to loosen coupling.
12065 * process.c (allocate_pty): Don't declare stb unless it's needed.
12066
7914961c 12067 * bytecode.c (MAYBE_GC): Rewrite so as not to use empty "else".
615f2d59
PE
12068 (CONSTANTLIM): Remove; unused.
12069 (METER_CODE, Bscan_buffer, Bread_char, Bset_mark):
12070 Define only if needed.
7914961c 12071
b3967b18
PE
12072 * unexelf.c (unexec): Name an expression,
12073 to avoid gcc -Wbad-function-cast warning.
9ae71512
PE
12074 Use a different way to cause a compilation error if anyone uses
12075 n rather than nn, a way that does not involve shadowing.
73366a00 12076 (ELF_BSS_SECTION_NAME, OLD_PROGRAM_H): Remove; unused.
b3967b18 12077
29a6015a
PE
12078 * deps.mk (unexalpha.o): Remove; unused.
12079
43cfc33e 12080 New file unexec.h, the (simple) interface for unexec (Bug#8267).
7feda0d2 12081 * unexec.h: New file.
ce701a33
PE
12082 * deps.mk (emacs.o, unexaix.o, unexcw.o, unexcoff.o, unexelf.o):
12083 (unexhp9k800.o, unexmacosx.o, unexsol.o, unexw32.o):
12084 Depend on unexec.h.
12085 * emacs.c [!defined CANNOT_DUMP]: Include unexec.h.
12086 * unexaix.c, unexcoff.c, unexcw.c, unexelf.c, unexhp9k800.c:
12087 * unexmacosx.c, unexsol.c, unexw32.c: Include unexec.h.
381259ef 12088 Change as necessary to match prototype in unexec.h.
ce701a33 12089
01f44d5a
PE
12090 * syntax.c (Fforward_comment, scan_lists): Rename locals to avoid
12091 shadowing.
4f63c6bb 12092 (back_comment, skip_chars): Mark vars as initialized.
01f44d5a 12093
a6670b0b
PE
12094 * character.h (FETCH_STRING_CHAR_ADVANCE_NO_CHECK, BUF_INC_POS):
12095 Rename locals to avoid shadowing.
12096
cef2010d 12097 * lread.c (read1): Rewrite so as not to use empty "else".
0902fe45 12098 (Fload, readevalloop, read1): Rename locals to avoid shadowing.
cef2010d 12099
d4d7173a
PE
12100 * print.c (Fredirect_debugging_output): Fix pointer signedess.
12101
f08b802a
PE
12102 * lisp.h (debug_output_compilation_hack): Add decl here, to avoid
12103 warning when compiling print.c.
12104
3ddb0639
PE
12105 * font.c (font_unparse_fcname): Abort in an "impossible" situation
12106 instead of using an uninitialized var.
5ad03b97 12107 (font_sort_entities): Mark var as initialized.
3ddb0639 12108
170a2692
PE
12109 * character.h (FETCH_CHAR_ADVANCE): Rename locals to avoid shadowing.
12110
e663c700
PE
12111 * font.c (font_unparse_xlfd): Don't mix pointers to variables with
12112 pointers to constants.
89bc529a 12113 (font_parse_fcname): Remove unused vars.
7b81e2d0 12114 (font_delete_unmatched): Now static.
ea838e10 12115 (font_get_spec): Remove; unused.
13a547c6
PE
12116 (font_style_to_value, font_prop_validate_style, font_unparse_fcname):
12117 (font_update_drivers, Ffont_get_glyphs, font_add_log):
12118 Rename or move locals to avoid shadowing.
e663c700 12119
2a80c887 12120 * fns.c (require_nesting_list, require_unwind): Now static.
612f56df 12121 (Ffillarray): Rename locals to avoid shadowing.
2a80c887 12122
1384fa33 12123 * floatfns.c (domain_error2): Define only if needed.
a885e2ed 12124 (Ffrexp, Fldexp): Rename locals to avoid shadowing.
1384fa33 12125
8b2c52e9
PE
12126 * alloc.c (mark_backtrace): Move decl from here ...
12127 * lisp.h: ... to here, so that it can be checked.
12128
475545b5 12129 * eval.c (call_debugger, do_debug_on_call, grow_specpdl): Now static.
d28a2170 12130 (Fdefvar): Rewrite so as not to use empty "else".
cfcbfb1a
PE
12131 (lisp_indirect_variable): Name an expression,
12132 to avoid gcc -Wbad-function-cast warning.
1faed8ae 12133 (Fdefvar): Rename locals to avoid shadowing.
475545b5 12134
b1349114 12135 * callint.c (quotify_arg, quotify_args): Now static.
a3e8cbda 12136 (Fcall_interactively): Rename locals to avoid shadowing.
b0e80955 12137 Use const pointer when appropriate.
b1349114 12138
a2928364
PE
12139 * lisp.h (get_system_name, get_operating_system_release):
12140 Move decls here, to check interfaces.
12141 * process.c (get_operating_system_release): Move decl to lisp.h.
12142 * xrdb.c (get_system_name): Likewise.
63c5d10b
PE
12143 * editfns.c (init_editfns, Fuser_login_name, Fuser_uid):
12144 (Fuser_real_uid, Fuser_full_name): Remove unnecessary casts,
12145 some of which prompt warnings from gcc -Wbad-function-cast.
545b49b4
PE
12146 (Fformat_time_string, Fencode_time, Finsert_char):
12147 (Ftranslate_region_internal, Fformat):
12148 Rename or remove local vars to avoid shadowing.
9710023e 12149 (Ftranslate_region_internal): Mark var as initialized.
63c5d10b 12150
a415e694
PE
12151 * doc.c (Fdocumentation, Fsnarf_documentation): Move locals to
12152 avoid shadowing.
12153
8ef4622d
PE
12154 * lisp.h (eassert): Check that the argument compiles, even if
12155 ENABLE_CHECKING is not defined.
12156
946f9a5b
PE
12157 * data.c (Findirect_variable): Name an expression, to avoid
12158 gcc -Wbad-function-cast warning.
112396d6 12159 (default_value, arithcompare, arith_driver, arith_error): Now static.
b9b84fa9 12160 (store_symval_forwarding): Rename local to avoid shadowing.
44f230aa
SM
12161 (Fmake_variable_buffer_local, Fmake_local_variable):
12162 Mark variables as initialized.
52746918 12163 (do_blv_forwarding, do_symval_forwarding): Remove; unused.
946f9a5b 12164
e5aab7e7 12165 * alloc.c (check_cons_list): Do not define unless GC_CHECK_CONS_LIST.
ae35e756
PE
12166 (Fmake_vector, Fvector, Fmake_byte_code, Fgarbage_collect):
12167 Rename locals to avoid shadowing.
dff45157
PE
12168 (mark_stack): Move local variables into the #ifdef region where
12169 they're used.
7bc26fdb
PE
12170 (BLOCK_INPUT_ALLOC, UNBLOCK_INPUT_ALLOC): Define only if
12171 ! defined SYSTEM_MALLOC && ! defined SYNC_INPUT, as they are not
12172 needed otherwise.
12173 (CHECK_ALLOCATED): Define only if GC_CHECK_MARKED_OBJECTS.
12174 (GC_STRING_CHARS): Remove; not used.
d40d4be1 12175 (Fmemory_limit): Cast sbrk's returned value to char *.
ae35e756 12176
e5aab7e7
PE
12177 * lisp.h (check_cons_list): Declare if GC_CHECK_CONS_LIST; this
12178 avoids undefined behavior in theory.
12179
4da60324
PE
12180 * regex.c (IF_LINT): Add defn, for benefit of ../lib-src.
12181
88043301
PE
12182 Use functions, not macros, for up- and down-casing (Bug#8254).
12183 * buffer.h (DOWNCASE_TABLE, UPCASE_TABLE, DOWNCASE, UPPERCASEP):
12184 (NOCASEP, LOWERCASEP, UPCASE, UPCASE1): Remove. All callers changed
12185 to use the following functions instead of these macros.
12186 (downcase): Adjust to lack of DOWNCASE_TABLE. Return int, not
12187 EMACS_INT, since callers assume the returned value fits in int.
12188 (upcase1): Likewise, for UPCASE_TABLE.
12189 (uppercasep, lowercasep, upcase): New static inline functions.
0da09c43 12190 * editfns.c (Fchar_equal): Remove no-longer-needed workaround for
db69b0cd 12191 the race-condition problem in the old DOWNCASE.
88043301 12192
19ed5445
PE
12193 * regex.c (CHARSET_LOOKUP_RANGE_TABLE_RAW, POP_FAILURE_REG_OR_COUNT):
12194 Rename locals to avoid shadowing.
12195 (regex_compile, re_match_2_internal): Move locals to avoid shadowing.
abbd1bcf
PE
12196 (regex_compile, re_search_2, re_match_2_internal):
12197 Remove unused local vars.
952db0d7
PE
12198 (FREE_VAR): Rewrite so as not to use empty "else",
12199 which gcc can warn about.
da053e48 12200 (regex_compile, re_match_2_internal): Mark locals as initialized.
b313f9d8
PE
12201 (RETALLOC_IF): Define only if needed.
12202 (WORDCHAR_P): Likewise. This one is never needed, but is used
12203 only in a comment talking about a compiler bug, so put inside
12204 the #if 0 of that comment.
12205 (CHARSET_LOOKUP_BITMAP, FAIL_STACK_FULL, RESET_FAIL_STACK):
12206 (PUSH_FAILURE_ELT, BUF_PUSH_3, STOP_ADDR_VSTRING):
12207 Remove; unused.
19ed5445 12208
1f3561e4 12209 * search.c (boyer_moore): Rename locals to avoid shadowing.
76ef09b7
PE
12210 * character.h (FETCH_STRING_CHAR_AS_MULTIBYTE_ADVANCE):
12211 (PREV_CHAR_BOUNDARY): Likewise.
1f3561e4 12212
ded6f8f7
PE
12213 * search.c (simple_search): Remove unused var.
12214
dbd37a95
PE
12215 * dired.c (compile_pattern): Move decl from here ...
12216 * lisp.h: ... to here, so that it can be checked.
12217 (struct re_registers): New forward decl.
12218
7e47afad
PE
12219 * character.h (INC_POS, DEC_POS): Rename locals to avoid shadowing.
12220
85f24f61
PE
12221 * indent.c (MULTIBYTE_BYTES_WIDTH): New args bytes, width.
12222 All uses changed.
12223 (MULTIBYTE_BYTES_WIDTH, scan_for_column, compute_motion):
12224 Rename locals to avoid shadowing.
5671df8f 12225 (Fvertical_motion): Mark locals as initialized.
85f24f61 12226
181aa2be 12227 * casefiddle.c (casify_object, casify_region): Now static.
e45a141a 12228 (casify_region): Mark local as initialized.
181aa2be 12229
930d429c
PE
12230 * cmds.c (internal_self_insert): Rename local to avoid shadowing.
12231
7082eac6
PE
12232 * lisp.h (GCPRO2_VAR, GCPRO3_VAR, GCPRO4_VAR, GCPRO5_VAR, GCPRO6_VAR):
12233 New macros, so that the caller can use some names other than
12234 gcpro1, gcpro2, etc.
12235 (GCPRO2, GCPRO3, GCPRO4, GCPRO5, GCPRO6): Reimplement in terms
12236 of the new macros.
12237 (GCPRO1_VAR, UNGCPRO_VAR): Change the meaning of the second
12238 argument, for consistency with GCPRO2_VAR, etc: it is now the
12239 prefix of the variable, not the variable itself. All uses
12240 changed.
38b2c076
PE
12241 * dired.c (directory_files_internal, file_name_completion):
12242 Rename locals to avoid shadowing.
12243
15206ed9
PE
12244 Fix a race condition diagnosed by gcc -Wsequence-point (Bug#8254).
12245 An expression of the form (DOWNCASE (x) == DOWNCASE (y)), found in
12246 dired.c's scmp function, had undefined behavior.
12247 * lisp.h (DOWNCASE_TABLE, UPCASE_TABLE, DOWNCASE, UPPERCASEP):
12248 (NOCASEP, LOWERCASEP, UPCASE, UPCASE1): Move from here ...
12249 * buffer.h: ... to here, because these macros use current_buffer,
12250 and the new implementation with inline functions needs to have
12251 current_buffer in scope now, rather than later when the macros
12252 are used.
12253 (downcase, upcase1): New static inline functions.
12254 (DOWNCASE, UPCASE1): Reimplement using these functions.
12255 This avoids undefined behavior in expressions like
12256 DOWNCASE (x) == DOWNCASE (y), which previously suffered
12257 from race conditions in accessing the global variables
12258 case_temp1 and case_temp2.
12259 * casetab.c (case_temp1, case_temp2): Remove; no longer needed.
12260 * lisp.h (case_temp1, case_temp2): Remove their decls.
12261 * character.h (ASCII_CHAR_P): Move from here ...
12262 * lisp.h: ... to here, so that the inline functions mentioned
12263 above can use them.
12264
4a6bea26
PE
12265 * dired.c (directory_files_internal_unwind): Now static.
12266
f14b7e14
PE
12267 * fileio.c (file_name_as_directory, directory_file_name):
12268 (barf_or_query_if_file_exists, auto_save_error, auto_save_1):
12269 Now static.
2893f146
PE
12270 (file_name_as_directory): Use const pointers when appropriate.
12271 (Fexpand_file_name): Likewise. In particular, newdir might
12272 point at constant storage, so make it a const pointer.
fd4ead52 12273 (Fmake_directory_internal, Fread_file_name): Remove unused vars.
b14aac08
PE
12274 (Ffile_selinux_context, Fset_file_selinux_context): Fix pointer
12275 signedness issues.
f839df0c
PE
12276 (Fset_file_times, Finsert_file_contents, auto_save_error):
12277 Rename locals to avoid shadowing.
f14b7e14 12278
5716756e 12279 * minibuf.c (choose_minibuf_frame_1): Now static.
62137a95
PE
12280 (Ftry_completion, Fall_completions): Rename or remove locals
12281 to avoid shadowing.
5716756e 12282
b4c3046a
PE
12283 * marker.c (bytepos_to_charpos): Remove; unused.
12284
b45db522
PE
12285 * lisp.h (verify_bytepos, count_markers): New decls,
12286 so that gcc does not warn that these functions aren't declared.
12287
85876d07
PE
12288 * insdel.c (check_markers, make_gap_larger, make_gap_smaller):
12289 (reset_var_on_error, Fcombine_after_change_execute_1): Now static.
f0cb4a60 12290 (CHECK_MARKERS): Redo to avoid gcc -Wempty-body diagnostic.
40ef059e 12291 (copy_text): Remove unused local var.
85876d07 12292
03d78a21 12293 * filelock.c (within_one_second): Now static.
b3dd38ab 12294 (lock_file_1): Rename local to avoid shadowing.
03d78a21 12295
5df8f01b
PE
12296 * buffer.c (fix_overlays_before): Mark locals as initialized.
12297 (fix_start_end_in_overlays): Likewise. This function should be
12298 simplified by using pointers-to-pointers, but that's a different
12299 matter.
b1d876f1 12300 (switch_to_buffer_1): Now static.
8f54f30a
PE
12301 (Fkill_buffer, record_buffer, Fbury_buffer, Fset_buffer_multibyte):
12302 (report_overlay_modification): Rename locals to avoid shadowing.
c3bd59b5 12303
a70072c9 12304 * sysdep.c (system_process_attributes): Rename vars to avoid shadowing.
fbd02d7b 12305 Fix pointer signedness issue.
edced198
PE
12306 (sys_subshell): Mark local as volatile if checking for lint,
12307 to suppress a gcc -Wclobbered warning that does not seem to be right.
15dfd3d9 12308 (MAXPATHLEN): Define only if needed.
a70072c9 12309
a0977c44
PE
12310 * process.c (serial_open, serial_configure): Move decls from here ...
12311 * systty.h: ... to here, so that they can be checked.
12312
a884fdcc
PE
12313 * fns.c (get_random, seed_random): Move extern decls from here ...
12314 * lisp.h: ... to here, so that they can be checked.
12315
604efe86 12316 * sysdep.c (reset_io): Now static.
b8950c94 12317 (wait_for_termination_signal): Remove; unused.
604efe86 12318
38fc62d9
PE
12319 * keymap.c (keymap_parent, keymap_memberp, map_keymap_internal):
12320 (copy_keymap_item, append_key, push_text_char_description):
12321 Now static.
1004a21a 12322 (Fwhere_is_internal): Don't test CONSP (sequences) unnecessarily.
dbbb8427 12323 (DENSE_TABLE_SIZE): Remove; unused.
c1141155
PE
12324 (get_keymap, access_keymap, Fdefine_key, Fwhere_is_internal):
12325 (describe_map_tree):
12326 Rename locals to avoid shadowing.
38fc62d9 12327
2f2650da
PE
12328 * keyboard.c: Declare functions static if they are not used elsewhere.
12329 (echo_char, echo_dash, cmd_error, top_level_2):
12330 (poll_for_input, handle_async_input): Now static.
69a058fa
PE
12331 (read_char, kbd_buffer_get_event, make_lispy_position):
12332 (make_lispy_event, make_lispy_movement, apply_modifiers):
12333 (decode_keyboard_code, tty_read_avail_input, menu_bar_items):
12334 (parse_tool_bar_item, read_key_sequence, Fread_key_sequence):
12335 (Fread_key_sequence_vector): Rename locals to avoid shadowing.
c8a06054 12336 (read_key_sequence, read_char): Mark locals as initialized.
3ac94672 12337 (Fexit_recursive_edit, Fabort_recursive_edit): Mark with NO_RETURN.
2f2650da 12338
a053e86c 12339 * keyboard.h (make_ctrl_char): New decl.
da2f2dd9
PE
12340 (mark_kboards): Move decl here ...
12341 * alloc.c (mark_kboards): ... from here.
a053e86c 12342
4752793e
PE
12343 * lisp.h (force_auto_save_soon): New decl.
12344
74f10ca7 12345 * emacs.c (init_cmdargs): Rename local to avoid shadowing.
244fc23d
PE
12346 (DEFINE_DUMMY_FUNCTION): New macro.
12347 (__do_global_ctors, __do_global_ctors_aux, __do_global_dtors, __main):
12348 Use it.
c03cd23f
PE
12349 (main): Add casts to avoid warnings
12350 if GCC considers string literals to be constants.
74f10ca7 12351
022e70d4
PE
12352 * lisp.h (fatal_error_signal): Add decl, since it's exported.
12353
59d6fe83
PE
12354 * dbusbind.c: Pointer signedness fixes.
12355 (xd_signature, xd_append_arg, xd_initialize):
12356 (Fdbus_call_method, Fdbus_call_method_asynchronously):
12357 (Fdbus_method_return_internal, Fdbus_method_error_internal):
12358 (Fdbus_send_signal, xd_read_message_1, Fdbus_register_service):
12359 (Fdbus_register_signal): Use SSDATA when the context wants char *.
12360
78320123
PE
12361 * dbusbind.c (Fdbus_init_bus): Add cast to avoid warning
12362 if GCC considers string literals to be constants.
49cebcca 12363 (Fdbus_register_service, Fdbus_register_method): Remove unused vars.
78320123 12364
35ac2a97
SM
123652011-03-16 Stefan Monnier <monnier@iro.umontreal.ca>
12366
fb103ca9
SM
12367 * print.c (PRINT_CIRCLE_CANDIDATE_P): New macro.
12368 (print_preprocess, print_object): New macro to fix last change.
12369
35ac2a97
SM
12370 * print.c (print_preprocess): Don't forget font objects.
12371
62973b41
JB
123722011-03-16 Juanma Barranquero <lekktu@gmail.com>
12373
12374 * emacs.c (USAGE3): Doc fixes.
12375
0e48bb22
AS
123762011-03-15 Andreas Schwab <schwab@linux-m68k.org>
12377
12378 * coding.c (detect_coding_iso_2022): Reorganize code to clarify
12379 structure.
12380
7684e57b
JB
123812011-03-14 Juanma Barranquero <lekktu@gmail.com>
12382
12383 * lisp.h (VWindow_system, Qfile_name_history):
12384 * keyboard.h (lispy_function_keys) [WINDOWSNT]:
12385 * w32term.h (w32_system_caret_hwnd, w32_system_caret_height)
12386 (w32_system_caret_x, w32_system_caret_y): Declare extern.
12387
12388 * w32select.c: Don't #include "keyboard.h".
c96bbc66 12389 (run_protected): Add extern declaration for waiting_for_input.
7684e57b
JB
12390
12391 * w32.c (Qlocal, noninteractive1, inhibit_window_system):
12392 * w32console.c (detect_input_pending, read_input_pending)
12393 (encode_terminal_code):
12394 * w32fns.c (quit_char, lispy_function_keys, Qtooltip)
12395 (w32_system_caret_hwnd, w32_system_caret_height, w32_system_caret_x)
12396 (w32_system_caret_y, Qfile_name_history):
12397 * w32font.c (w32font_driver, QCantialias, QCotf, QClang):
12398 * w32inevt.c (reinvoke_input_signal, lispy_function_keys):
12399 * w32menu.c (Qmenu_bar, QCtoggle, QCradio, Qoverriding_local_map)
12400 (Qoverriding_terminal_local_map, Qmenu_bar_update_hook):
12401 * w32proc.c (Qlocal, report_file_error):
12402 * w32term.c (Vwindow_system, updating_frame):
12403 * w32uniscribe.c (initialized, uniscribe_font_driver):
12404 Remove unneeded extern declarations.
12405
2aa46d6c
CY
124062011-03-14 Chong Yidong <cyd@stupidchicken.com>
12407
c96bbc66 12408 * buffer.c (Fmake_indirect_buffer): Fix incorrect assertions.
2aa46d6c 12409
cffc6f3b
CY
124102011-03-13 Chong Yidong <cyd@stupidchicken.com>
12411
12412 * buffer.h (BUF_BEGV, BUF_BEGV_BYTE, BUF_ZV, BUF_ZV_BYTE, BUF_PT)
12413 (BUF_PT_BYTE): Rewrite to handle indirect buffers (Bug#8219).
12414 These macros can no longer be used for assignment.
12415
44f230aa
SM
12416 * buffer.c (Fget_buffer_create, Fmake_indirect_buffer):
12417 Assign struct members directly, instead of using BUF_BEGV etc.
cffc6f3b
CY
12418 (record_buffer_markers, fetch_buffer_markers): New functions for
12419 recording and fetching special buffer markers.
12420 (set_buffer_internal_1, set_buffer_temp): Use them.
12421
12422 * lread.c (unreadchar): Use SET_BUF_PT_BOTH.
12423
12424 * insdel.c (adjust_point): Use SET_BUF_PT_BOTH.
12425
12426 * intervals.c (temp_set_point_both): Use SET_BUF_PT_BOTH.
12427 (get_local_map): Use SET_BUF_BEGV_BOTH and SET_BUF_ZV_BOTH.
12428
12429 * xdisp.c (hscroll_window_tree):
12430 (reconsider_clip_changes): Use PT instead of BUF_PT.
12431
d251f04b
EZ
124322011-03-13 Eli Zaretskii <eliz@gnu.org>
12433
12434 * makefile.w32-in ($(BLD)/editfns.$(O)): Depend on
12435 $(EMACS_ROOT)/lib/intprops.h.
12436
f0c77cd1
PE
124372011-03-13 Paul Eggert <eggert@cs.ucla.edu>
12438
3eca4629
PE
12439 Fix more problems found by GCC 4.5.2's static checks.
12440
7c86ee98
PE
12441 * gtkutil.c (xg_get_pixbuf_from_pixmap): Add cast from char *
12442 to unsigned char * to avoid compiler diagnostic.
b0afc268
PE
12443 (xg_free_frame_widgets): Make it clear that a local variable is
12444 needed only if USE_GTK_TOOLTIP.
01e0b5ad
PE
12445 (gdk_window_get_screen): Make it clear that this macro is needed
12446 only if USE_GTK_TOOLTIP.
1e5524e7
PE
12447 (int_gtk_range_get_value): New function, which avoids a diagnostic
12448 from gcc -Wbad-function-cast.
12449 (xg_set_toolkit_scroll_bar_thumb): Use it.
12450 (xg_tool_bar_callback, xg_tool_item_stale_p): Rewrite to avoid
12451 diagnostic from gcc -Wbad-function-cast.
65dc836c
PE
12452 (get_utf8_string, xg_get_file_with_chooser):
12453 Rename locals to avoid shadowing.
12454 (create_dialog): Move locals to avoid shadowing.
7c86ee98 12455
41729b81
PE
12456 * xgselect.c (xg_select): Remove unused var.
12457
f0c77cd1
PE
12458 * image.c (four_corners_best): Mark locals as initialized.
12459 (gif_load): Initialize transparent_p to zero (Bug#8238).
12460 Mark another local as initialized.
ec6cf4c6 12461 (my_png_error, my_error_exit): Mark with NO_RETURN.
f0c77cd1 12462
ce0ad53d 12463 * image.c (clear_image_cache): Now static.
d5d5a617 12464 (DIM, HAVE_STDLIB_H_1): Remove unused macros.
e22cffbc 12465 (xpm_load): Redo to avoid "discards qualifiers" gcc warning.
77a765fd
PE
12466 (x_edge_detection): Remove unnecessary cast that
12467 gcc -Wbad-function-cast diagnoses.
2037898d 12468 (gif_load): Fix pointer signedness.
6ae141d6
PE
12469 (clear_image_cache, xbm_read_bitmap_data, x_detect_edges):
12470 (jpeg_load, gif_load): Rename locals to avoid shadowing.
ce0ad53d 12471
33383987 124722011-03-12 Paul Eggert <eggert@cs.ucla.edu>
3eca4629 12473
d32df629
PE
12474 Improve quality of tests for time stamp overflow.
12475 For example, without this patch (encode-time 0 0 0 1 1
12476 1152921504606846976) returns the obviously-bogus value (-948597
12477 62170) on my RHEL 5.5 x86-64 host. With the patch, it correctly
12478 reports time overflow. See
12479 <http://lists.gnu.org/archive/html/emacs-devel/2011-03/msg00470.html>.
b8d9bd41
PE
12480 * deps.mk (editfns.o): Depend on ../lib/intprops.h.
12481 * editfns.c: Include limits.h and intprops.h.
12482 (TIME_T_MIN, TIME_T_MAX): New macros.
12483 (time_overflow): Move earlier, to before first use.
12484 (hi_time, lo_time): New functions, for an accurate test for
12485 out-of-range times.
12486 (Fcurrent_time, Fget_internal_run_time, make_time): Use them.
12487 (Fget_internal_run_time): Don't assume time_t fits in int.
12488 (make_time): Use list2 instead of Fcons twice.
12489 (Fdecode_time): More accurate test for out-of-range times.
12490 (check_tm_member): New function.
12491 (Fencode_time): Use it, to test for out-of-range times.
d32df629
PE
12492 (lisp_time_argument): Don't rely on undefined left-shift and
12493 right-shift behavior when checking for time stamp overflow.
8be6f318 12494
fe31d94c
PE
12495 * editfns.c (time_overflow): New function, refactoring common code.
12496 (Fformat_time_string, Fdecode_time, Fencode_time):
12497 (Fcurrent_time_string): Use it.
12498
8be6f318
PE
12499 Move 'make_time' to be next to its inverse 'lisp_time_argument'.
12500 * dired.c (make_time): Move to ...
12501 * editfns.c (make_time): ... here.
12502 * systime.h: Note the move.
12503
09d9db2c 125042011-03-12 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
c47cbdfd 12505
126bc0dc
YM
12506 * fringe.c (update_window_fringes): Remove unused variables.
12507
c47cbdfd
YM
12508 * unexmacosx.c (copy_data_segment): Also copy __got section.
12509 (Bug#8223)
12510
7ac80be9
EZ
125112011-03-12 Eli Zaretskii <eliz@gnu.org>
12512
c96bbc66 12513 * termcap.c [MSDOS]: Include "msdos.h".
058e5dad
EZ
12514 (find_capability, tgetnum, tgetflag, tgetstr, tputs, tgetent):
12515 Constify `char *' arguments and their references according to
12516 prototypes in tparam.h.
12517
ecb0f94d 12518 * deps.mk (termcap.o): Depend on tparam.h and msdos.h.
058e5dad 12519
7ac80be9
EZ
12520 * msdos.c (XMenuAddPane): 3rd argument is `const char *' now.
12521 Adapt all references accordingly.
12522
12523 * msdos.h (XMenuAddPane): 3rd argument is `const char *' now.
12524
ef1fd07e
TT
125252011-03-11 Tom Tromey <tromey@redhat.com>
12526
12527 * buffer.c (syms_of_buffer): Remove obsolete comment.
12528
7ef4b50c
EZ
125292011-03-11 Eli Zaretskii <eliz@gnu.org>
12530
12531 * termhooks.h (encode_terminal_code): Declare prototype.
12532
12533 * msdos.c (encode_terminal_code): Don't declare prototype.
12534
12535 * term.c (encode_terminal_code): Now external again, used by
12536 w32console.c and msdos.c.
12537
44f230aa
SM
12538 * makefile.w32-in ($(BLD)/term.$(O), ($(BLD)/tparam.$(O)):
12539 Depend on $(SRC)/tparam.h, see 2011-03-11T07:24:21Z!eggert@cs.ucla.edu.
7ef4b50c 12540
4b1ec863 125412011-03-11 Paul Eggert <eggert@cs.ucla.edu>
f78faa98 12542
1714f52b 12543 Fix some minor problems found by GCC 4.5.2's static checks.
83316bf4 12544
4b1ec863
PE
12545 * fringe.c (update_window_fringes): Mark locals as initialized
12546 (Bug#8227).
12547 (destroy_fringe_bitmap, init_fringe_bitmap): Now static.
bf60f616 12548
524c7aa6
PE
12549 * alloc.c (mark_fringe_data): Move decl from here ...
12550 * lisp.h (mark_fringe_data) [HAVE_WINDOW_SYSTEM]: ... to here,
12551 to check its interface.
12552 (init_fringe_once): Do not declare unless HAVE_WINDOW_SYSTEM.
12553
a5c0af81 12554 * fontset.c (free_realized_fontset): Now static.
7519b8cd 12555 (Fset_fontset_font): Rename local to avoid shadowing.
cc6e5db1 12556 (fontset_font): Mark local as initialized.
a9a06e0b 12557 (FONTSET_SPEC, FONTSET_REPERTORY, RFONT_DEF_REPERTORY): Remove; unused.
a5c0af81 12558
b4716021
PE
12559 * xrdb.c: Include "xterm.h", to check x_load_resources's interface.
12560
811e9bac 12561 * xselect.c (x_disown_buffer_selections): Remove; not used.
7b83e2f1 12562 (TRACE3) [!defined TRACE_SELECTION]: Remove; not used.
aa0daa9f
PE
12563 (x_own_selection, Fx_disown_selection_internal): Rename locals
12564 to avoid shadowing.
12565 (x_handle_dnd_message): Remove local to avoid shadowing.
811e9bac 12566
7e3ab302
PE
12567 * lisp.h (GCPRO1_VAR, UNGCPRO_VAR): New macros,
12568 so that the caller can use some name other than gcpro1.
12569 (GCPRO1, UNGCPRO): Reimplement in terms of the new macros.
58d2d479
PE
12570 * xfns.c (Fx_create_frame, x_create_tip_frame, Fx_show_tip):
12571 (Fx_backspace_delete_keys_p):
12572 Use them to avoid shadowing, and rename vars to avoid shadowing.
12573 (x_decode_color, x_set_name, x_window): Now static.
6b437900 12574 (Fx_create_frame): Add braces to silence GCC warning.
c0951e53 12575 (Fx_file_dialog, Fx_select_font): Fix pointer signedness.
06b0c8a0
PE
12576 (x_real_positions, xg_set_icon_from_xpm_data, x_create_tip_frame):
12577 Remove unused locals.
7e3ab302
PE
12578 (Fx_create_frame, x_create_tip_frame, Fx_show_tip):
12579 (Fx_backspace_delete_keys_p): Rename locals to avoid shadowing.
12580 Some of these renamings use the new GCPRO1_VAR and UNGCPRO_VAR
12581 macros.
f78faa98 12582
e2b13473
PE
12583 * xterm.h (x_mouse_leave): New decl.
12584
77f23912
PE
12585 * xterm.c (x_copy_dpy_color, x_focus_on_frame, x_unfocus_frame):
12586 Remove unused functions.
cdf4ba58
PE
12587 (x_shift_glyphs_for_insert, XTflash, XTring_bell):
12588 (x_calc_absolute_position): Now static.
7411c686 12589 (XTread_socket): Don't define label "out" unless it's used.
2b07bcff 12590 Don't declare local "event" unless it's used.
ed7bf3a5
PE
12591 (x_iconify_frame, x_free_frame_resources): Don't declare locals
12592 unless they are used.
38d0b34a
PE
12593 (XEMBED_VERSION, xembed_set_info): Don't define unless needed.
12594 (x_fatal_error_signal): Remove; not used.
a6067996
PE
12595 (x_draw_image_foreground, redo_mouse_highlight, XTmouse_position):
12596 (x_scroll_bar_report_motion, handle_one_xevent, x_draw_bar_cursor):
12597 (x_error_catcher, x_connection_closed, x_error_handler):
12598 (x_error_quitter, xembed_send_message, x_iconify_frame):
12599 (my_log_handler): Rename locals to avoid shadowing.
28f1c698 12600 (x_delete_glyphs, x_ins_del_lines): Mark with NO_RETURN.
2a8fade0 12601 (x_connection_closed): Tell GCC not to suggest NO_RETURN.
77f23912 12602
44f230aa
SM
12603 * xfaces.c (clear_face_cache, Fx_list_fonts, Fface_font):
12604 Rename or move locals to avoid shadowing.
6b463e58 12605 (tty_defined_color, merge_face_heights): Now static.
5967d051 12606 (free_realized_faces_for_fontset): Remove; not used.
1e9966ea
PE
12607 (Fx_list_fonts): Mark variable that gcc -Wuninitialized
12608 does not deduce is never used uninitialized.
73719eba
PE
12609 (STRDUPA, LSTRDUPA, FONT_POINT_SIZE_QUANTUM): Remove; not used.
12610 (LFACEP): Define only if XASSERTS, as it's not needed otherwise.
071048a3 12611
426994c3 12612 * terminal.c (store_terminal_param): Now static.
5489860b 12613
032f1620 12614 * xmenu.c (menu_highlight_callback): Now static.
9d66f88e 12615 (set_frame_menubar): Remove unused local.
d4323972 12616 (xmenu_show): Rename parameter to avoid shadowing.
6d1f7fee
PE
12617 (xmenu_show, xdialog_show, xmenu_show): Make local pointers "const"
12618 since they might point to immutable storage.
281585b0
PE
12619 (next_menubar_widget_id): Declare only if USE_X_TOOLKIT,
12620 since it's unused otherwise.
032f1620 12621
367c19e5 12622 * xdisp.c (produce_glyphless_glyph): Initialize lower_xoff.
53df7c11 12623 Add a FIXME, since the code still doesn't look right. (Bug#8215)
9f36b9fd
PE
12624 (Fcurrent_bidi_paragraph_direction): Simplify slightly; this
12625 avoids a gcc -Wuninitialized diagnostic.
0e086e8f 12626 (display_line, BUILD_COMPOSITE_GLYPH_STRING, draw_glyphs):
44a3a108
PE
12627 (note_mouse_highlight): Mark variables that gcc -Wuninitialized
12628 does not deduce are never used uninitialized.
70739cbe 12629
07b48fa9
PE
12630 * lisp.h (IF_LINT): New macro, copied from ../lib-src/emacsclient.c.
12631
8868a238 12632 * xdisp.c (redisplay_window): Rename local to avoid shadowing.
4554d213
PE
12633 * window.c (window_loop, size_window):
12634 (run_window_configuration_change_hook, enlarge_window): Likewise.
8868a238 12635
7e5cf297 12636 * window.c (display_buffer): Now static.
d6550a9f
PE
12637 (size_window): Mark variables that gcc -Wuninitialized
12638 does not deduce are never used uninitialized.
a586633d
PE
12639 * window.h (check_all_windows): New decl, to forestall
12640 gcc -Wmissing-prototypes diagnostic.
5b555da1 12641 * dispextern.h (bidi_dump_cached_states): Likewise.
7e5cf297 12642
f6095868
PE
12643 * charset.h (CHECK_CHARSET_GET_CHARSET): Rename locals to avoid
12644 shadowing.
12645 * charset.c (map_charset_for_dump, Fchar_charset): Likewise.
726929c4
PE
12646 Include <limits.h>.
12647 (Fsort_charsets): Redo min/max calculation to shorten the code a bit
12648 and to avoid gcc -Wuninitialized warning.
89ef49df
PE
12649 (load_charset_map): Mark variables that gcc -Wuninitialized
12650 does not deduce are never used uninitialized.
53df7c11 12651 (load_charset): Abort instead of using uninitialized var (Bug#8229).
f6095868 12652
f38b440c
PE
12653 * coding.c (coding_set_source, coding_set_destination):
12654 Use "else { /* comment */ }" rather than "else /* comment */;"
12655 for clarity, and to avoid gcc -Wempty-body warning.
2735d060
PE
12656 (Fdefine_coding_system_internal): Don't redeclare 'i' inside
12657 a block, when the outer 'i' will do.
12658 (decode_coding_utf_8, decode_coding_utf_16, detect_coding_emacs_mule):
12659 (emacs_mule_char, decode_coding_emacs_mule, detect_coding_iso_2022):
12660 (decode_coding_iso_2022, decode_coding_sjis, decode_coding_big5):
12661 (decode_coding_raw_text, decode_coding_charset, get_translation_table):
12662 (Fdecode_sjis_char, Fdefine_coding_system_internal):
12663 Rename locals to avoid shadowing.
12664 * character.h (FETCH_STRING_CHAR_ADVANCE): Likewise.
e2f1bab9
PE
12665 * coding.c (emacs_mule_char, encode_invocation_designation):
12666 Now static, since they're not used elsewhere.
413bb2db 12667 (decode_coding_iso_2022): Add "default: abort ();" as a safety check.
c4a63b12 12668 (decode_coding_object, encode_coding_object, detect_coding_system):
ee05f961
PE
12669 (decode_coding_emacs_mule): Mark variables that gcc
12670 -Wuninitialized does not deduce are never used uninitialized.
160b01f6
PE
12671 (detect_coding_iso_2022): Initialize a local variable that might
12672 be used uninitialized. Leave a FIXME because it's not clear that
53df7c11 12673 this initialization is needed. (Bug#8211)
5f58e762
PE
12674 (ISO_CODE_LF, ISO_CODE_CR, CODING_ISO_FLAG_EUC_TW_SHIFT):
12675 (ONE_MORE_BYTE_NO_CHECK, UTF_BOM, UTF_16_INVALID_P):
12676 (SHIFT_OUT_OK, ENCODE_CONTROL_SEQUENCE_INTRODUCER):
12677 (ENCODE_DIRECTION_R2L, ENCODE_DIRECTION_L2R):
12678 Remove unused macros.
f38b440c 12679
232b38b9 12680 * category.c (hash_get_category_set): Remove unused local var.
9f3b5e69 12681 (copy_category_table): Now static, since it's not used elsewhere.
d0891610 12682 * character.c (string_count_byte8): Likewise.
232b38b9 12683
fb90da1b
PE
12684 * ccl.c (CCL_WRITE_STRING, CCL_ENCODE_CHAR, Fccl_execute_on_string):
12685 (Fregister_code_conversion_map): Rename locals to avoid shadowing.
12686
fb93dbc2
PE
12687 * chartab.c (copy_sub_char_table): Now static, since it's not used
12688 elsewhere.
5c156ace
PE
12689 (sub_char_table_ref_and_range, char_table_ref_and_range):
12690 Rename locals to avoid shadowing.
bbcd0949 12691 (ASET_RANGE, GET_SUB_CHAR_TABLE): Remove unused macros.
fb93dbc2 12692
7d3b3862 12693 * bidi.c (bidi_check_type): Now static, since it's not used elsewhere.
630d6892 12694 (BIDI_BOB): Remove unused macro.
7d3b3862 12695
6be7d3da
PE
12696 * cm.c (cmgoto): Mark variables that gcc -Wuninitialized does not
12697 deduce are never used uninitialized.
c2ed9c8b 12698 * term.c (encode_terminal_code): Likewise.
6be7d3da 12699
75f8807f 12700 * term.c (encode_terminal_code): Now static. Remove unused local.
72abad34 12701
50938595
PE
12702 * tparam.h: New file.
12703 * term.c, tparam.h: Include it.
12704 * deps.mk (term.o, tparam.o): Depend on tparam.h.
12705 * term.c (tputs, tgetent, tgetflag, tgetnum, tparam, tgetstr):
12706 Move these decls to tparam.h, and make them agree with what
12707 is actually in tparam.c. The previous trick of using incompatible
12708 decls in different modules does not conform to the C standard.
12709 All callers of tparam changed to use tparam's actual API.
12710 * tparam.c (tparam1, tparam, tgoto):
12711 Use const pointers where appropriate.
12712
fbceeba2
PE
12713 * cm.c (calccost, cmgoto): Use const pointers where appropriate.
12714 * cm.h (struct cm): Likewise.
12715 * dispextern.h (do_line_insertion_deletion_costs): Likewise.
12716 * scroll.c (ins_del_costs, do_line_insertion_deletion_costs): Likewise.
12717 * term.c (tty_ins_del_lines, calculate_costs, struct fkey_table):
12718 (term_get_fkeys_1, append_glyphless_glyph, produce_glyphless_glyph):
12719 (turn_on_face, init_tty): Likewise.
12720 * termchar.h (struct tty_display_info): Likewise.
fbceeba2 12721
7f3f1250
PE
12722 * term.c (term_mouse_position): Rename local to avoid shadowing.
12723
e6ca6543
PE
12724 * alloc.c (mark_ttys): Move decl from here ...
12725 * lisp.h (mark_ttys): ... to here, so that it's checked against defn.
12726
c40f8d15
AS
127272011-03-11 Andreas Schwab <schwab@linux-m68k.org>
12728
12729 * .gdbinit (pwinx, xbuffer): Fix access to buffer name.
12730
cfe0661d
JB
127312011-03-09 Juanma Barranquero <lekktu@gmail.com>
12732
12733 * search.c (compile_pattern_1): Remove argument regp, unused since
12734 revid:rms@gnu.org-19941211082627-3x1g1wyqkjmwloig.
12735 (compile_pattern): Don't pass it.
12736
0afb4571
J
127372011-03-08 Jan Djärv <jan.h.d@swipnet.se>
12738
12739 * xterm.h (DEFAULT_GDK_DISPLAY): New define.
12740 (GDK_WINDOW_XID, gtk_widget_get_preferred_size): New defines
12741 for ! HAVE_GTK3.
12742 (GTK_WIDGET_TO_X_WIN): Use GDK_WINDOW_XID.
12743
12744 * xmenu.c (menu_position_func): Call gtk_widget_get_preferred_size.
12745
12746 * gtkutil.c: Include gtkx.h if HAVE_GTK3. If ! HAVE_GTK3, define
12747 gdk_window_get_screen, gdk_window_get_geometry,
12748 gdk_x11_window_lookup_for_display and GDK_KEY_g.
12749 (xg_set_screen): Use DEFAULT_GDK_DISPLAY.
12750 (xg_get_pixbuf_from_pixmap): New function.
12751 (xg_get_pixbuf_from_pix_and_mask): Change parameters from GdkPixmap
12752 to Pixmap, take frame as parameter, remove GdkColormap parameter.
12753 Call xg_get_pixbuf_from_pixmap instead of
12754 gdk_pixbuf_get_from_drawable.
12755 (xg_get_image_for_pixmap): Do not make GdkPixmaps, call
12756 xg_get_pixbuf_from_pix_and_mask with Pixmap parameters instead.
12757 (xg_check_special_colors): Use GtkStyleContext and its functions
12758 for HAVE_GTK3.
12759 (xg_prepare_tooltip, xg_hide_tooltip): Call gdk_window_get_screen.
12760 (xg_prepare_tooltip, create_dialog, menubar_map_cb)
12761 (xg_update_frame_menubar, xg_tool_bar_detach_callback)
44f230aa
SM
12762 (xg_tool_bar_attach_callback, xg_update_tool_bar_sizes):
12763 Call gtk_widget_get_preferred_size.
0afb4571
J
12764 (xg_frame_resized): gdk_window_get_geometry only takes 5
12765 parameters.
44f230aa
SM
12766 (xg_win_to_widget, xg_event_is_for_menubar):
12767 Call gdk_x11_window_lookup_for_display.
0afb4571
J
12768 (xg_set_widget_bg): New function.
12769 (delete_cb): New function.
895009e1 12770 (xg_create_frame_widgets): Connect delete-event to delete_cb.
5c32d3f2 12771 Call xg_set_widget_bg. Only set background pixmap for ! HAVE_GTK3
0afb4571
J
12772 (xg_set_background_color): Call xg_set_widget_bg.
12773 (xg_set_frame_icon): Call xg_get_pixbuf_from_pix_and_mask.
12774 (xg_create_scroll_bar): vadj is a GtkAdjustment for HAVE_GTK3.
12775 Only call gtk_range_set_update_policy if ! HAVE_GTK3.
12776 (xg_make_tool_item): Only connect xg_tool_bar_item_expose_callback
12777 if ! HAVE_GTK3.
12778 (update_frame_tool_bar): Call gtk_widget_hide.
12779 (xg_initialize): Use GDK_KEY_g.
12780
12781 * xsmfns.c (gdk_set_sm_client_id): Define to gdk_set_sm_client_id
12782 if ! HAVE_GTK3
12783 (x_session_initialize): Call gdk_x11_set_sm_client_id.
12784
12785 * xterm.c (XFillRectangle): Use cairo routines for HAVE_GTK3.
12786 (x_term_init): Disable Xinput(2) with GDK_CORE_DEVICE_EVENTS.
12787 Load ~/emacs.d/gtkrc only for ! HAVE_GTK3.
12788
1c2cc4ef
JB
127892011-03-08 Juanma Barranquero <lekktu@gmail.com>
12790
12791 * w32xfns.c (select_palette): Check success of RealizePalette against
12792 GDI_ERROR, not zero.
12793
33383987 12794See ChangeLog.11 for earlier changes.
aac0c6e3
MR
12795
12796;; Local Variables:
12797;; coding: utf-8
aac0c6e3
MR
12798;; End:
12799
2f097256 12800 Copyright (C) 2011-2012 Free Software Foundation, Inc.
aac0c6e3
MR
12801
12802 This file is part of GNU Emacs.
12803
12804 GNU Emacs is free software: you can redistribute it and/or modify
12805 it under the terms of the GNU General Public License as published by
12806 the Free Software Foundation, either version 3 of the License, or
12807 (at your option) any later version.
12808
12809 GNU Emacs is distributed in the hope that it will be useful,
12810 but WITHOUT ANY WARRANTY; without even the implied warranty of
12811 MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
12812 GNU General Public License for more details.
12813
12814 You should have received a copy of the GNU General Public License
12815 along with GNU Emacs. If not, see <http://www.gnu.org/licenses/>.