* international/mule-cmds.el (inactivate-input-method): Mark obsolete.
[bpt/emacs.git] / src / ChangeLog
CommitLineData
417a7a0e
EZ
12012-07-29 Eli Zaretskii <eliz@gnu.org>
2
3 * w32heap.h (OS_9X): Renamed from OS_WINDOWS_95.
4
5 * w32heap.c (cache_system_info):
6 * w32.c (sys_rename):
7 * w32proc.c (find_child_console, sys_kill): All users changed.
8
387d4d92
PE
92012-07-29 Paul Eggert <eggert@cs.ucla.edu>
10
11 * alloc.c (Fgarbage_collect): Indent as per usual Emacs style.
12
55a6cca6
EZ
132012-07-29 Eli Zaretskii <eliz@gnu.org>
14
15 * makefile.w32-in (LISP_H): Add $(NT_INC)/stdalign.h.
16
dbcf001c
DA
172012-07-29 Dmitry Antipov <dmantipov@yandex.ru>
18
19 Cleanup statistics calculation in Fgarbage_collect.
20 * alloc.c (Fgarbage_collect): Rename t1 to meaningful start. Fix
21 zombies percentage calculation. Simplify elapsed time calculation.
22
e2688e4a
DA
232012-07-29 Dmitry Antipov <dmantipov@yandex.ru>
24
25 Generalize marker debugging code under MARKER_DEBUG and use eassert.
26 * insdel.c (CHECK_MARKERS, check_markers_debug_flag): Remove.
27 (gap_left, gap_right, adjust_markers_for_delete, insert_1_both)
28 (insert_from_string_1, insert_from_gap, insert_from_buffer_1)
29 (replace_range, replace_range_2, del_range_2): Change to eassert.
30 * marker.c (byte_char_debug_check): Adjust style.
31
b46a6a83
PE
322012-07-29 Paul Eggert <eggert@cs.ucla.edu>
33
34 Don't use the abbreviation "win" to refer to Windows (Bug#10421).
35 * regex.c (MAX_BUF_SIZE): Remove some incorrect and
36 long-ago-commented-out code that talks about "WIN32".
37 * w32heap.h (OS_WINDOWS_95): Rename from OS_WIN95.
38 All uses changed.
39
e32a5799
PE
402012-07-28 Paul Eggert <eggert@cs.ucla.edu>
41
42 Use Gnulib stdalign module (Bug#9772, Bug#9960).
43 * alloc.c (XMALLOC_BASE_ALIGNMENT, GC_POINTER_ALIGNMENT, pure_alloc):
44 Simplify by using alignof.
45 (pure_alloc) [! USE_LSB_TAG]: Don't over-align EMACS_INT values.
46 * lisp.h: Include <stdalign.h>.
47 (GCALIGNMENT): New macro and constant.
48 (DECL_ALIGN): Remove. All uses replaced by alignas (GCALIGNMENT).
49 (USE_LSB_TAG): ifdef on alignas, not on DECL_ALIGN.
50 (stdalign): New macro, if not already defined.
51
df81cd29
EZ
522012-07-28 Eli Zaretskii <eliz@gnu.org>
53
01bd1b0d
EZ
54 Fix non-ASCII input in non-GUI frames on MS-Windows. (Bug#12055)
55 * w32inevt.c: Include w32inevt.h.
56 (w32_read_console_input): New inline function, calls either
57 ReadConsoleInputA or ReadConsoleInputW, depending on the value of
58 w32_console_unicode_input.
59 (fill_queue): Call w32_read_console_input instead of ReadConsoleInput.
60 (w32_kbd_patch_key, key_event): Use the codepage returned by
61 GetConsoleCP, rather than the ANSI codepage returned by GetLocaleInfo.
62 (key_event): use uChar.UnicodeChar only if
63 w32_console_unicode_input is non-zero.
64
65 * w32console.c: Include w32heap.h.
66 <w32_console_unicode_input>: New global variable.
67 (initialize_w32_display): Set w32_console_unicode_input to 1 on NT
68 family of Windows, zero otherwise.
69
70 * w32inevt.h: Declare w32_console_unicode_input.
71
df81cd29
EZ
72 * xdisp.c (init_iterator): Don't reference tip_frame in a build
73 --without-x. (Bug#11742)
74
c20fdd9e
PE
752012-07-27 Paul Eggert <eggert@cs.ucla.edu>
76
77 Adjust GDB to reflect pvec_type changes (Bug#12036).
78 * .gdbinit (xvectype, xpr, xbacktrace): Adjust to reflect the
79 2012-07-04 changes to pseudovector representation. Problem
80 reported by Eli Zaretskii in <http://bugs.gnu.org/12036#30>.
81
32770973 822012-07-27 Michael Albinus <michael.albinus@gmx.de>
e518bc71
MA
83
84 * dbusbind.c (XD_DBUS_VALIDATE_BUS_ADDRESS): Canonicalize session
85 bus address.
86 (xd_close_bus, Fdbus_init_bus): Handle reference counter properly.
87
3438fe21
EZ
882012-07-27 Eli Zaretskii <eliz@gnu.org>
89
bcfbc9de
EZ
90 * alloc.c (listn): Fix the order the arguments are consed onto the
91 list.
92
3438fe21
EZ
93 * lisp.h (enum constype): Use CONSTYPE_HEAP and CONSTYPE_PURE for
94 enumeration constants, as PURE and HEAP are too general, and clash
95 with other headers and sources, such as gmalloc.c and the
96 MS-Windows system headers. All users changed.
97
eeaea515
DA
982012-07-27 Dmitry Antipov <dmantipov@yandex.ru>
99
100 Revert last save_excursion_save and save_excursion_restore changes.
101 * alloc.c, editfns.c, marker.c, lisp.h: Revert.
102 Lots of crashes reported by Chong Yidong <cyd@gnu.org>.
103
073c88c2
DA
1042012-07-27 Dmitry Antipov <dmantipov@yandex.ru>
105
106 Fix recently-introduced typos in Windows port.
107 Reported by Martin Rudalics <rudalics@gmx.at>.
108 * w32.c (init_environment): Replace comma with semicolon.
eeaea515 109 * w32fns.c (syms_of_w32fns): Add missing parenthesis.
073c88c2 110
4706125e
PE
1112012-07-27 Paul Eggert <eggert@cs.ucla.edu>
112
113 Improve GDB symbol export (Bug#12036).
114 * .gdbinit (xgetptr, xgetint, xgettype): Set $bugfix in different
115 arms of an 'if', not using conditional expressions; otherwise GDB
116 complains about the types in the unevaluated arm when the argument
117 is an integer literal.
118 (xgetint): Simplify expression.
119 * alloc.c (gdb_make_enums_visible): New constant. This ports to
120 GCC 3.4.2 the export of symbols to GDB. Problem reported by Eli
121 Zaretskii in <http://bugs.gnu.org/12036#13>.
122 * lisp.h (PUBLISH_TO_GDB): Remove. All uses removed. No longer
123 needed now that we have gdb_make_enums_visible.
124 (enum CHECK_LISP_OBJECT_TYPE, enum Lisp_Bits, enum More_Lisp_Bits)
125 (enum enum_USE_LSB_TAG):
126 New enum types, packaging up enums that need to be exported to GDB.
127
694b6c97
DA
1282012-07-27 Dmitry Antipov <dmantipov@yandex.ru>
129
130 Utility function to make a list from specified amount of objects.
131 * lisp.h (enum constype): New datatype.
132 (listn): New prototype.
133 * alloc.c (listn): New function.
134 (Fmemory_use_count, syms_of_alloc): Use it.
135 * buffer.c (syms_of_buffer): Likewise.
136 * callint.c (syms_of_callint): Likewise.
137 * charset.c (define_charset_internal): Likewise.
138 * coding.c (syms_of_coding): Likewise.
139 * keymap.c (syms_of_keymap): Likewise.
140 * search.c (syms_of_search): Likewise.
141 * syntax.c (syms_of_syntax): Likewise.
142 * w32.c (init_environment): Likewise.
143 * w32fns.c (Fw32_battery_status, syms_of_w32fns): Likewise.
144 * xdisp.c (syms_of_xdisp): Likewise.
145 * xfns.c (syms_of_xfns): Likewise.
146
6195f384
DA
1472012-07-27 Dmitry Antipov <dmantipov@yandex.ru>
148
149 Fast save_excursion_save and save_excursion_restore.
150 * lisp.h (struct Lisp_Excursion): New data type.
151 (PVEC_EXCURSION): New pseudovector type.
152 (XEXCURSION, XSETEXCURSION, EXCURSIONP): Convenient macros
153 to deal with it. Adjust comments.
154 (init_marker, attach_marker): New prototype.
155 (unchain_marker): Adjust prototype.
156 * marker.c (attach_marker): Change to global.
157 (init_marker): New function.
158 * alloc.c (Fmake_marker, build_marker): Use it.
159 (build_marker): More easserts.
160 (mark_object): Handle struct Lisp_Excursion.
161 * editfns.c (save_excursion_save, save_excursion_restore):
162 Reimplement to use struct Lisp_Excursion. Add comments.
163
5eceb8fb
PE
1642012-07-26 Paul Eggert <eggert@cs.ucla.edu>
165
166 Fix export of symbols to GDB (Bug#12036).
167 * alloc.c (ARRAY_MARK_FLAG_VAL, PSEUDOVECTOR_FLAG_VAL, VALMASK_VAL)
168 (ARRAY_MARK_FLAG, PSEUDOVECTOR_FLAG, VALMASK): Move these here from
169 emacs.c, as this is a more-suitable home. Had this been done earlier
170 the fix for 12036 would have avoided some of the problems noted in
171 <http://bugs.gnu.org/12036#13> by Eli Zaretskii, as the scope problems
172 would have been more obvious.
562157c8
PE
173 * emacs.c: Do not include <verify.h>; no longer needed.
174 (gdb_CHECK_LISP_OBJECT_TYPE, gdb_DATA_SEG_BITS)
5eceb8fb
PE
175 (gdb_GCTYPEBITS, gdb_USE_LSB_TAG)
176 (CHECK_LISP_OBJECT_TYPE, DATA_SEG_BITS, GCTYPEBITS, USE_LSB_TAG):
177 Remove; now done in lisp.h.
178 * lisp.h (PUBLISH_TO_GDB): New macro.
179 (GCTYPEBITS, USE_LSB_TAG, CHECK_LISP_OBJECT_TYPE, enum pvec_type)
180 (DATA_SEG_BITS): Use it.
181 (GCTYPEBITS, USE_LSB_TAG): Now also an enum, for GDB.
182 (CHECK_LISP_OBJECT_TYPE, DATA_SEG_BITS): Now just an enum, for GDB.
183 * mem-limits.h (EXCEEDS_LISP_PTR): Redo so that DATA_SEG_BITS need
184 not be usable in #if. This simplifies things.
185
d6749401
JB
1862012-07-26 Juanma Barranquero <lekktu@gmail.com>
187
188 * makefile.w32-in ($(BLD)/emacs.$(O)): Update dependencies.
189
1781b9e9
PE
1902012-07-26 Paul Eggert <eggert@cs.ucla.edu>
191
d89518db 192 Simplify export of symbols to GDB (Bug#12036).
1781b9e9
PE
193 * .gdbinit (xgetptr, xgetint, xgettype): Don't use "set $bugfix =
194 $bugfix.i", as this doesn't work (with GDB 7.4.1, anyway).
195 (xgetptr, xgetint, xgettype, xcoding, xcharset, xprintbytestr):
196 Adjust to changes in lisp.h and emacs.c, by using
197 CHECK_LISP_OBJECT_TYPE rather than gdb_use_struct, VALMASK instead
198 of $valmask, DATA_SEG_BITS instead of gdb_data_seg_bits,
199 INTTYPEBITS instead of gdb_gctypebits - 1, USE_LSB_TAG instead of
200 gdb_use_lsb, (1 << GCTYPEBITS) - 1 instead of $tagmask, VALBITS
201 instead of gdb_valbits.
202 (xvectype, xvector, xpr, xprintstr, xbacktrace): Similarly, use
203 PSEUDOVECTOR_FLAG instead of PVEC_FLAG, and ARRAY_MARK_FLAG
204 instead of gdb_array_mark_flag.
205 (xboolvector): Get size from $->size, not $->header.size.
206 Use BOOL_VECTOR_BITS_PER_CHAR rather than mystery constants.
207 (xreload, hook-run, hookpost-run): Remove.
208 * emacs.c: Include <verify.h>.
209 (gdb_use_lsb, gdb_use_struct, gdb_valbits, gdb_gctypebits)
210 (gdb_data_seg_bits, PVEC_FLAG, gdb_array_mark_flag, gdb_pvec_type):
211 Remove.
212 (gdb_CHECK_LISP_OBJECT_TYPE, gdb_DATA_SEG_BITS, gdb_GCTYPEBITS)
213 (gdb_USE_LSB_TAG): New enum constants.
214 (CHECK_LISP_OBJECT_TYPE, DATA_SEG_BITS, GCTYPEBITS, USE_LSB_TAG):
215 Also define these as enum constants, so they're visible to GDB.
216 (ARRAY_MARK_FLAG_VAL, PSEUDOVECTOR_FLAG_VAL, VALMASK_VAL): New macros.
217 (ARRAY_MARK_FLAG, PSEUDOVECTOR_FLAG, VALMASK): Also define these
218 as constants, so they're visible to GDB.
219 * lisp.h (VALBITS, INTTYPEBITS, FIXNUM_BITS, PSEUDOVECTOR_SIZE_BITS)
220 (PSEUDOVECTOR_SIZE_MASK, PVEC_TYPE_MASK, BOOL_VECTOR_BITS_PER_CHAR):
221 Now enum constants, not macros, so they're visible to GDB.
222 (CHECK_LISP_OBJECT_TYPE, DATA_SEG_BITS): Default to 0, as this is
223 more convenient now. All uses changed.
224 (VALMASK) [USE_LSB_TAG]: Also define in this case.
225 * mem-limits.h (EXCEEDS_LISP_PTR): Adjust to DATA_SEG_BITS change.
226
3628596a
DA
2272012-07-26 Dmitry Antipov <dmantipov@yandex.ru>
228
229 Explicitly free restriction data that are not needed anymore.
230 * editfns.c (save_restriction_restore): Free restriction data.
231
7abaf5cc
SM
2322012-07-26 Stefan Monnier <monnier@iro.umontreal.ca>
233
234 * eval.c (Fautoload_do_load): Rename from do_autoload, export to Lisp,
235 add argument, tune behavior, and adjust all callers.
236
71f88e00
PE
2372012-07-25 Paul Eggert <eggert@cs.ucla.edu>
238
239 Use typedef for EMACS_INT, EMACS_UINT.
240 * lisp.h, s/ms-w32.h (EMACS_INT, EMACS_UINT): Use typedefs rather
241 than macros. This simplifies debugging in the usual case, since
242 it lets GDB show addresses as 'EMACS_INT *' rather than 'long int *'
243 and it allows expressions involving EMACS_INT casts.
244 * .gdbinit (xreload): Simplify by using EMACS_INT cast.
245
57ec3034
JD
2462012-07-25 Jan Djärv <jan.h.d@swipnet.se>
247
248 * nsterm.m (ns_read_socket): Return early if there is a modal
249 window (Bug#12043).
250
8137e7b3
MR
2512012-07-25 Martin Rudalics <rudalics@gmx.at>
252
253 * frame.c (Fredirect_frame_focus): In doc-string don't mention
254 that FOCUS-FRAME can be omitted.
255
04e9897c
DA
2562012-07-25 Dmitry Antipov <dmantipov@yandex.ru>
257
258 Adjust buffer text indirection counters at the end of Fkill_buffer.
259 * buffer.c (Fkill_buffer): Adjust indirection counters when the
260 buffer is definitely dead. This should really fix an issue reported
261 by Christoph Scholtes again. (Bug#12007).
262 (init_buffer_once): Initialize indirection counters of
263 buffer_defaults and buffer_local_symbols (for sanity and safety).
264
8a0484e1
EZ
2652012-07-24 Eli Zaretskii <eliz@gnu.org>
266
267 * xdisp.c (init_iterator): Don't compute dimensions of truncation
268 and continuation glyphs on tooltip frames, leave them at zero.
269 Avoids continued lines in tooltips. (Bug#11832)
270
fa691a83
DA
2712012-07-24 Dmitry Antipov <dmantipov@yandex.ru>
272
273 Simplify copy_overlay.
04e9897c 274 * buffer.c (copy_overlay): Simplify. Use build_marker.
fa691a83
DA
275 * lisp.h (struct Lisp_Overlay): Restore comment with minor tweaks.
276
436bc8e0
EZ
2772012-07-23 Eli Zaretskii <eliz@gnu.org>
278
279 * print.c (print_object): Don't crash when a frame's name is nil
280 or invalid. (Bug#12025)
281
282 * window.c (decode_any_window): Disable CHECK_LIVE_FRAME test, as
283 it signals an error when a tooltip frame is being created.
284
d7a7fda3
DA
2852012-07-23 Dmitry Antipov <dmantipov@yandex.ru>
286
287 Cleanup miscellaneous objects allocation and initialization.
288 * alloc.c (allocate_misc): Change to static. Add argument to
289 specify the subtype. Adjust comment and users.
290 (build_overlay): New function.
291 * buffer.c (copy_overlays, Fmake_overlay): Use it.
292 * lisp.h (struct Lisp_Overlay): Remove obsolete comment.
293 (allocate_misc): Remove prototype.
294 (build_overlay): Add prototype.
295
2962012-07-23 Dmitry Antipov <dmantipov@yandex.ru>
372f8ffc
DA
297
298 Swap buffer text indirection counters in Fbuffer_swap_text.
299 * buffer.c (Fbuffer_swap_text): Swap indirections too.
300 This avoids crash reported by Christoph Scholtes at
301 http://lists.gnu.org/archive/html/bug-gnu-emacs/2012-07/msg00785.html.
302
9d7fa573
JD
3032012-07-22 Jan Djärv <jan.h.d@swipnet.se>
304
305 * nsmenu.m (Popdown_data): New struct.
306 (pop_down_menu): p->pointer is Popdown_data. Release the pool and
307 free Popdown_data.
308 (ns_popup_dialog): Use NSAutoreleasePool and pass it to pop_down_menu.
309 (initWithContentRect): Make imgView and contentView non-static
310 and autorelease them. Also autorelease img and matrix (Bug#12005).
311 (dealloc): Remove (Bug#12005).
312
0dd6d66d
DA
3132012-07-22 Dmitry Antipov <dmantipov@yandex.ru>
314
315 Adjust consing_since_gc when objects are explicitly freed.
316 * alloc.c (GC_DEFAULT_THRESHOLD): New macro.
317 (Fgarbage_collect): Use it. Change minimum to 1/10 of default.
318 (free_cons, free_misc): Subtract object size from consing_since_gc.
319
d36d71df
DA
3202012-07-22 Dmitry Antipov <dmantipov@yandex.ru>
321
322 Simplify and cleanup markers positioning code.
323 * marker.c (attach_marker): More useful eassert.
324 (live_buffer, set_marker_internal): New function.
325 (Fset_marker, set_marker_restricted): Use set_marker_internal.
326 (set_marker_both, set_marker_restricted_both): Use live_buffer.
327
fb9ea40f
PE
3282012-07-22 Paul Eggert <eggert@cs.ucla.edu>
329
330 * buffer.h (struct buffer.indirections): Now ptrdiff_t, not int,
331 as it's limited by the amount of memory, not by INT_MAX.
332
2d5c5f7d
EZ
3332012-07-21 Eli Zaretskii <eliz@gnu.org>
334
07fb592e
EZ
335 * keyboard.c (keys_of_keyboard): Bind language-change to 'ignore'
336 in special-event-map. See the discussion at
337 http://lists.gnu.org/archive/html/emacs-devel/2012-06/msg00417.html
338 for the reasons.
339
37a9eac8 340 * w32menu.c (add_menu_item): Cast to ULONG_PTR when assigning
2d5c5f7d
EZ
341 info.dwItemData. Fixes crashes on 64-bit Windows. Suggested by
342 Fabrice Popineau <fabrice.popineau@supelec.fr>.
343
c4328746
JD
3442012-07-21 Jan Djärv <jan.h.d@swipnet.se>
345
346 * nsterm.m (accessibilityAttributeValue): New function. (Bug#11134).
4b17afa7 347 (conversationIdentifier): Return value is NSInteger.
784051c4 348 * nsterm.m (accessibilityAttributeValue): Surround with NS_IMPL_COCOA.
c4328746 349
6e5d1c12
CY
3502012-07-21 Chong Yidong <cyd@gnu.org>
351
352 * window.c (decode_any_window): Signal an error if the window is
353 on a dead frame (Bug#11984).
354
9928463d
DA
3552012-07-20 Dmitry Antipov <dmantipov@yandex.ru>
356
357 Add indirection counting to speed up Fkill_buffer.
358 * buffer.h (struct buffer): New member.
359 * buffer.c (Fget_buffer_create): Set indirection counter to 0.
360 (Fmake_indirect_buffer): Set indirection counter to -1, increment
361 base buffer indirection counter.
362 (compact_buffer): If ENABLE_CHECKING, verify indirection counters.
363 (Fkill_buffer): Adjust indirection counters as needed, don't walk
364 through buffer list if indirection counter is 0.
365
f8643a6b
DA
3662012-07-20 Dmitry Antipov <dmantipov@yandex.ru>
367
368 Extend the value returned by Fgarbage_collect with heap statistics.
369 * alloc.c (Qheap): New symbol.
370 (syms_of_alloc): DEFSYM it.
371 (Fgarbage_collect): If DOUG_LEA_MALLOC, add mallinfo data.
372 (Fmemory_free): Remove.
373 (syms_of_alloc): Don't defsubr it.
374 * buffer.c (Fcompact_buffer): Remove.
375 (syms_of_buffer): Don't defsubr it.
376
dac616ff
DA
3772012-07-20 Dmitry Antipov <dmantipov@yandex.ru>
378
379 Make maybe_gc inline.
380 Verify that inlining is always possible (GCC 4.7.1, -O3 -Winline).
381 * lisp.h (consing_since_gc, gc_relative_threshold)
382 (memory_full_cons_threshold): Revert declaration.
383 (maybe_gc): Remove prototype, define as inline.
384 * alloc.c: Remove old commented-out code.
385 (consing_since_gc, gc_relative_threshold)
386 (memory_full_cons_threshold): Revert to global.
387 (maybe_gc): Remove.
388
d7ea76b4
DA
3892012-07-20 Dmitry Antipov <dmantipov@yandex.ru>
390
391 Simple wrapper for make_unibyte_string, adjust font_open_by_name.
392 * lisp.h (build_unibyte_string): New function.
393 * dosfns.c, fileio.c, fns.c, ftfont.c, process.c:
394 * sysdep.c, w32fns.c, xfns.c: Use it.
395 * font.c (font_open_by_name): Change 2nd and 3rd args to the only arg
396 of type Lisp_Object to avoid redundant calls to make_unibyte_string.
397 Adjust users accordingly.
398 * font.h (font_open_by_name): Adjust prototype.
399
765e61e3
DA
4002012-07-20 Dmitry Antipov <dmantipov@yandex.ru>
401
402 Cleanup calls to Fgarbage_collect.
403 * lisp.h (maybe_gc): New prototype.
404 (consing_since_gc, gc_relative_threshold, memory_full_cons_threshold):
405 Remove declarations.
406 * alloc.c (maybe_gc): New function.
407 (consing_since_gc, gc_relative_threshold, memory_full_cons_threshold):
408 Make them static.
409 * bytecode.c (MAYBE_GC): Use maybe_gc.
410 * eval.c (eval_sub, Ffuncall): Likewise.
411 * keyboard.c (read_char): Likewise. Adjust call to maybe_gc
412 to avoid dependency from auto-save feature.
413
52b852c7
PE
4142012-07-19 Paul Eggert <eggert@cs.ucla.edu>
415
416 * buffer.h (FOR_EACH_BUFFER): Rename from 'for_each_buffer'.
417 (FOR_EACH_PER_BUFFER_OBJECT_AT): Rename from
418 'for_each_per_buffer_object_at'.
419 All uses changed. It's better to use upper-case for macros that
420 cannot be implemented as functions, to give the reader a clue
421 that they're special.
422
5db81e33
SM
4232012-07-19 Stefan Monnier <monnier@iro.umontreal.ca>
424
425 * alloc.c (Fgarbage_collect): Tweak docstring.
426
5b835e1d
DA
4272012-07-19 Dmitry Antipov <dmantipov@yandex.ru>
428
429 Tweak the value returned from Fgarbage_collect again.
430 * alloc.c (Fgarbage_collect): New return value, as confirmed in
431 http://lists.gnu.org/archive/html/emacs-devel/2012-07/msg00418.html.
432 Adjust documentation.
433 (total_vector_bytes): Rename to total_vector_slots, adjust
434 accounting.
435 (total_free_vector_bytes): Rename to total_free_vector_slots,
436 adjust accounting.
437 (Qstring_bytes, Qvector_slots): New symbols.
438 (syms_of_alloc): DEFSYM them.
439
9cd47b72
DA
4402012-07-19 Dmitry Antipov <dmantipov@yandex.ru>
441
442 Buffer compaction primitive which may be used from Lisp.
443 * buffer.c (compact_buffer, Fcompact_buffer): New function.
444 (syms_of_buffer): Register Fcompact_buffer.
445 * alloc.c (Fgarbage_collect): Use compact_buffer.
446 * buffer.h (compact_buffer): New prototype.
447 (struct buffer_text): New member.
448
d17337e5
DA
4492012-07-19 Dmitry Antipov <dmantipov@yandex.ru>
450
451 New macro to iterate over all buffers, miscellaneous cleanups.
452 * lisp.h (all_buffers): Remove declaration.
453 * buffer.h (all_buffers): Add declaration, with comment.
454 (for_each_buffer): New macro.
455 * alloc.c (Fgarbage_collect, mark_object): Use it.
456 * buffer.c (Fkill_buffer, Fbuffer_swap_text, Fset_buffer_multibyte)
457 (init_buffer): Likewise.
458 * data.c (Fset_default): Likewise.
459 * coding.c (code_conversion_restore): Remove redundant check
460 for dead buffer.
461 * buffer.c (Fkill_buffer): Likewise. Remove obsolete comment.
462
60cfd278
AS
4632012-07-18 Andreas Schwab <schwab@linux-m68k.org>
464
465 Fix bug that created negative-length intervals.
466 * intervals.c (merge_interval_right, merge_interval_left):
467 Do not zero out this interval if it is absorbed by its children,
468 as this interval's total length doesn't change in that case. See
469 <http://lists.gnu.org/archive/html/emacs-devel/2012-07/msg00403.html>.
470
d06714cb
PE
4712012-07-18 Paul Eggert <eggert@cs.ucla.edu>
472
83713154
PE
473 * alloc.c (Fmake_bool_vector): Fix off-by-8 bug
474 when invoking (make-bool-vector N t) and N is a positive
475 multiple of 8 -- the last 8 bits were mistakenly cleared.
476
d06714cb
PE
477 Remove some struct layout assumptions in bool vectors.
478 * alloc.c (bool_header_size): New constant.
479 (header_size, word_size): Move earlier, as they're now used earlier.
480 Use 'word_size' in a few more places, where it's appropriate.
481 (Fmake_bool_vector, sweep_vectors): Don't assume that there is no
482 padding before the data member of a bool vector.
483 (sweep_vectors): Use PSEUDOVECTOR_TYPEP, in an eassert, rather
484 than doing the check by hand with an abort ().
485
464d5a5e
SM
4862012-07-18 Stefan Monnier <monnier@iro.umontreal.ca>
487
5fbc0409
SM
488 * eval.c (Fdefvar): Don't check constants since we only set the var if
489 it's not yet defined anyway (bug#11904).
490
464d5a5e
SM
491 * lisp.h (last_undo_boundary): Declare new var.
492 * keyboard.c (command_loop_1): Set it.
493 * cmds.c (Fself_insert_command): Use it to only remove boundaries that
494 were auto-added by the command loop (bug#11774).
495
8dc2e44a
AS
4962012-07-18 Andreas Schwab <schwab@linux-m68k.org>
497
498 * w32font.c (Qsymbol): Remove local definition.
499 (syms_of_w32font): Don't DEFSYM it.
500
169925ec
DA
5012012-07-18 Dmitry Antipov <dmantipov@yandex.ru>
502
503 Fix sweep_vectors to handle large bool vectors correctly.
504 * alloc.c (sweep_vectors): Account total_vector_bytes for
505 bool vectors larger than VBLOCK_BYTES_MAX.
506
5fbfb018
CY
5072012-07-18 Chong Yidong <cyd@gnu.org>
508
509 * frame.c (x_set_frame_parameters): Revert bogus change introduced
510 in 2012-05-25 commit by Paul Eggert (Bug#11738).
511
3ab6e069
DA
5122012-07-18 Dmitry Antipov <dmantipov@yandex.ru>
513
514 Return more descriptive data from Fgarbage_collect.
515 Suggested by Stefan Monnier in
516 http://lists.gnu.org/archive/html/emacs-devel/2012-07/msg00369.html.
517 * alloc.c (bounded_number): New function.
518 (total_buffers, total_vectors): New variable.
519 (total_string_size): Rename to total_string_bytes, adjust users.
520 (total_vector_size): Rename to total_vector_bytes, adjust users.
521 (sweep_vectors): Account total_vectors and total_vector_bytes.
522 (Fgarbage_collect): New return value. Adjust documentation.
523 (gc_sweep): Account total_buffers.
524 (Fmemory_free, Fmemory_use_counts): Use bounded_number.
525 (VECTOR_SIZE): Remove.
526 * data.c (Qfloat, Qvector, Qsymbol, Qstring, Qcons): Make global.
527 (Qinterval, Qmisc): New symbols.
528 (syms_of_data): Initialize them.
529 * lisp.h (Qinterval, Qsymbol, Qstring, Qmisc, Qvector, Qfloat)
530 (Qcons, Qbuffer): New declarations.
531
6d02fe5b
PE
5322012-07-17 Paul Eggert <eggert@cs.ucla.edu>
533
534 * alloc.c (Fmemory_free): Account for memory-free's own storage.
535 Round up, not down. Improve doc.
536
b7ffe040
DA
5372012-07-17 Dmitry Antipov <dmantipov@yandex.ru>
538
539 Restore old code in allocate_string_data to avoid Faset breakage.
540 Reported by Julien Danjou <julien@danjou.info> in
541 http://lists.gnu.org/archive/html/emacs-devel/2012-07/msg00371.html.
542 * alloc.c (allocate_string_data): Restore old code with minor
543 adjustments, fix comment to explain this subtle issue.
544
4dc7c8d5
SM
5452012-07-17 Eli Zaretskii <eliz@gnu.org>
546
547 Remove FILE_SYSTEM_CASE.
548 * s/msdos.h (FILE_SYSTEM_CASE): Don't define.
549
550 * fileio.c (FILE_SYSTEM_CASE): Don't define.
551 (Ffile_name_directory, Fexpand_file_name): Don't use FILE_SYSTEM_CASE.
552 Fixes problems on MS-DOS with Vtemp_file_name_pattern when
553 call-process-region passes it through expand-file-name.
554
555 * dired.c (file_name_completion): Don't use FILE_SYSTEM_CASE.
556
5572012-07-17 Andreas Schwab <schwab@linux-m68k.org>
558
559 Fix crash when creating indirect buffer (Bug#11917)
560 * buffer.c (buffer_lisp_local_variables): Add argument CLONE.
561 Don't handle unbound variables specially if non-zero.
562 (Fbuffer_local_variables): Pass zero.
563 (clone_per_buffer_values): Pass non-zero.
564
5652012-07-17 Andreas Schwab <schwab@linux-m68k.org>
566
567 * gnutls.c (emacs_gnutls_handshake): Revert last change. Add QUIT
568 to make the loop interruptible.
569
5702012-07-17 Andreas Schwab <schwab@linux-m68k.org>
571
572 * gnutls.c (emacs_gnutls_handshake): Only retry if
573 GNUTLS_E_INTERRUPTED.
574
cce7fefc
DA
5752012-07-17 Dmitry Antipov <dmantipov@yandex.ru>
576
577 Cleanup and convert miscellaneous checks to eassert.
578 * alloc.c (mark_interval): Fix comment, partially rephrase
579 old comment from intervals.h (see below).
580 * intervals.c (find_interval, adjust_intervals_for_insertion)
581 (delete_interval, adjust_intervals_for_deletion)
582 (graft_intervals_into_buffer, temp_set_point_both, copy_intervals):
583 Convert to eassert.
584 (adjust_intervals_for_insertion, make_new_interval):
585 Remove obsolete and unused code.
586 * intervals.h (struct interval): Remove obsolete comment.
587 * textprotp.c (erase_properties): Remove unused code.
588 (Fadd_text_properties, set_text_properties_1, Fremove_text_properties)
589 (Fremove_list_of_text_properties): Convert to eassert.
590
9ea10cc3
CY
5912012-07-17 Chong Yidong <cyd@gnu.org>
592
593 * editfns.c (Finsert_char): Doc fix.
594
3900d5de
DA
5952012-07-17 Dmitry Antipov <dmantipov@yandex.ru>
596
597 Fix previous change to make Fmemory_free always accurate.
598 * alloc.c (make_interval): Update total_free_intervals.
599 (make_float): Likewise for total_free_floats.
600 (free_cons, Fcons): Likewise for total_free_conses.
601 (SETUP_ON_FREE_LIST, allocate_vector_from_block):
602 Likewise for total_free_vector_bytes.
603 (Fmake_symbol): Likewise for total_free_symbols.
604 (bytes_free): Remove.
605
7098646f
DA
6062012-07-17 Dmitry Antipov <dmantipov@yandex.ru>
607
608 Simple free memory accounting feature.
609 * alloc.c (bytes_free, total_free_vector_bytes): New variable.
610 (sweep_vectors): Accumulate size of free vectors.
611 (Fgarbage_collect): Setup bytes_free.
612 (Fmemory_free): New function.
613 (syms_of_alloc): Register it.
614
22657b40
DA
6152012-07-17 Dmitry Antipov <dmantipov@yandex.ru>
616
617 Cleanup overlays checking.
618 * buffer.h (OVERLAY_VALID): Remove as useless synonym of OVERLAYP.
619 * buffer.c (overlay_touches_p, recenter_overlay_lists): Change to
620 eassert and OVERLAYP.
621 (sort_overlays): Change to use OVERLAYP.
622
ddfc8813
RK
6232012-07-16 René Kyllingstad <Rene@Kyllingstad.com> (tiny change)
624
625 * editfns.c (Finsert_char): Make it interactive, and make the
626 second arg optional. Copy interactive spec and docstring from
627 ucs-insert.
628
7c26cf3c
PE
6292012-07-17 Paul Eggert <eggert@cs.ucla.edu>
630
631 * floatfns.c (Fabs): Do not wrap fabs inside IN_FLOAT (Bug#11913).
632 Unlike the other wrapped functions, fabs has an unspecified
633 effect on errno.
634
5d127af9
JD
6352012-07-16 Jan Djärv <jan.h.d@swipnet.se>
636
637 * nsterm.m (keyDown): Interpret flags without left/right bits
638 as the left key (Bug#11670).
639
6a0dd1d7
DA
6402012-07-16 Dmitry Antipov <dmantipov@yandex.ru>
641
642 Remove empty and useless init functions.
643 * lisp.h (init_character_once, init_fns, init_image)
644 (init_filelock, init_sound): Remove prototype.
645 * character.c (init_character_once): Remove.
646 * filelock.c (init_filelock): Likewise.
647 * fns.c (init_fns): Likewise.
648 * image.c (init_image): Likewise.
649 * sound.c (init_sound): Likewise.
650 * emacs.c (main): Adjust accordingly.
651
7a6136fd
DA
6522012-07-16 Dmitry Antipov <dmantipov@yandex.ru>
653
654 * gtkutil.h: Tiny cleanups.
655 (use_old_gtk_file_dialog): Remove useless declaration.
656 (xg_uses_old_file_dialog): Add suggested const attribute.
657
ce811ad9
EZ
6582012-07-15 Eli Zaretskii <eliz@gnu.org>
659
660 * bidi.c (MAX_STRONG_CHAR_SEARCH): New macro.
661 (bidi_paragraph_init): Use it to limit search forward for a strong
662 directional character in abnormally large paragraphs full of
663 neutral or weak characters. (Bug#11943)
664
c9adfeaa
SF
6652012-07-15 Stefano Facchini <stefano.facchini@gmail.com> (tiny change)
666
667 * gtkutil.c (xg_create_tool_bar): Apply "primary-toolbar" style to
668 the toolbar (Bug#9451).
669 (xg_make_tool_item): Give the widget event box a transparent
670 background.
671
fff62aa9
DA
6722012-07-15 Dmitry Antipov <dmantipov@yandex.ru>
673
674 Cleanup basic allocation variables and functions.
675 * alloc.c (ignore_warnings, init_intervals, init_float)
676 (init_cons, init_symbol, init_marker): Remove.
677 (interval_block_index): Initialize to INTERVAL_BLOCK_SIZE.
678 (float_block_index): Initialize to FLOAT_BLOCK_SIZE.
679 (cons_block_index): Initialize to CONS_BLOCK_SIZE.
680 (symbol_block_size): Initialize to SYMBOL_BLOCK_SIZE.
681 (marker_block_index): Initialize to MARKER_BLOCK_SIZE.
682 (staticidx, init_alloc_once, init_strings, free_ablock):
683 Remove redundant initialization.
684 * fns.c (init_weak_hash_tables): Remove.
685 * lisp.h (init_weak_hash_tables): Remove prototype.
686
9730daca
DA
6872012-07-15 Dmitry Antipov <dmantipov@yandex.ru>
688
689 Use zero_vector where appropriate.
690 * alloc.c (zero_vector): Define as Lisp_Object. Adjust users
691 accordingly.
692 * lisp.h (zero_vector): New declaration.
693 * font.c (null_vector): Remove.
694 (syms_of_font): Remove initialization and staticpro.
695 (font_list_entities, font_find_for_lface): Change to use zero_vector.
696 * keymap.c (Faccessible_keymaps): Likewise.
697
2e2d2a13
LL
6982012-07-15 Leo Liu <sdl.web@gmail.com>
699
700 * fringe.c: Fix typo in comments.
701
cd276f6e
LL
7022012-07-14 Leo Liu <sdl.web@gmail.com>
703
704 * fringe.c: Add a new bitmap exclamation-mark.
705
5a1131d9
EZ
7062012-07-14 Eli Zaretskii <eliz@gnu.org>
707
708 * gmalloc.c (GMALLOC_INHIBIT_VALLOC): Don't reference.
709
710 * s/msdos.h (BSD_SYSTEM, DATA_START, GC_SETJMP_WORKS, HAVE_MOUSE)
711 (HAVE_MENUS): Don't define, defined by editing config.in with
712 msdos/sed2v2.inp.
713 (GMALLOC_INHIBIT_VALLOC): Don't define.
714 (MODE_LINE_BINARY_TEXT): Remove, not used anymore.
715
22e983b7
JB
7162012-07-14 Juanma Barranquero <lekktu@gmail.com>
717
718 * s/ms-w32.h (GC_SETJMP_WORKS, GC_MARK_STACK): Set in nt/config.nt.
719
5b3f250f
GM
7202012-07-14 Glenn Morris <rgm@gnu.org>
721
722 * s/aix4-2.h, s/freebsd.h, s/gnu-linux.h, s/hpux10-20.h:
723 * s/irix6-5.h, s/netbsd.h, s/sol2-6.h, s/unixware.h:
724 Let configure set GC_SETJMP_WORKS, GC_MARK_STACK.
725
33d63ff4
GM
7262012-07-13 Glenn Morris <rgm@gnu.org>
727
5b633342
GM
728 * s/gnu-linux.h (GC_MARK_SECONDARY_STACK): Let configure set it.
729
33d63ff4
GM
730 * s/usg5-4-common.h (SETUP_SLAVE_PTY): Let configure set it.
731 * s/irix6-5.h (SETUP_SLAVE_PTY): No more need to unset it.
732
b55b9f85
JD
7332012-07-13 Jan Djärv <jan.h.d@swipnet.se>
734
0dc8cf50
JD
735 * nsterm.m (uRect): Only define if NS_IMPL_GNUSTEP.
736 (x_free_frame_resources): Pass x_free_frame_resources to NSTRACE.
737 (ns_lisp_to_color, ns_string_to_lispmod, ns_term_init)
738 (ns_term_shutdown, requestService, initFrameFromEmacs): Use SSDATA
739 where appropriate.
740 (ns_exec_path, ns_load_path, changeFont): Put () around assignment used
741 as boolean expression.
742 (x_set_window_size): Remove unused variable toolbar.
743 (ns_get_color_default, ns_mod_to_lisp): Remove.
744 (ns_mouse_position): Remove unused variables xchar and ychar.
745 (ns_compute_glyph_string_overhangs): Remove unused variable face.
746 (ns_set_vertical_scroll_bar): Remove unused variable count.
747 (ns_delete_terminal): Remove unused variable i.
748 (ns_term_init): Remove unused variables r, g and b.
749 (mouseDown): Remove unused variable window.
750 (windowDidResize): Move definition of theWindow inside NS_IMPL_GNUSTEP.
751 (initFrameFromEmacs): Remove unused variable vbextra.
752 (mouseEntered): Remove unused variables p and dpyinfo.
753 (mouseExited): Remove unused variables p and r.
754 (ns_define_frame_cursor, ns_clear_frame_area)
755 (ns_draw_window_cursor, ns_initialize_display_info): Make static.
756 (menuDown): Assign [sender tag] to variable and cast the variable.
757
758 * nsterm.h (menuDown): Add id as type to argument sender.
759 (ns_display_info_for_name): Add Lisp_Object argument.
760 (ns_term_init): Add Lisp_Object argument.
761 (ns_map_event_to_object): Add void argument.
762 (ns_string_from_pasteboard, ns_string_to_pasteboard): Add correct
763 prototype with arguments and only declare if __OBJC__.
764 (nxatoms_of_nsselect): Add void argument.
765 (ns_lisp_to_cursor_type): Add Lisp_Object argument.
766 (ns_alloc_autorelease_pool): Add void argument.
767 (ns_release_autorelease_pool): Add void* argument.
768 (ns_get_defaults_value): Add const char* argument.
769
770 * nsmenu.m (ns_update_menubar, ns_menu_show, process_dialog)
771 (initFromContents): Use SSDATA where appropriate.
772 (ns_update_menubar): Add braces to ambigous if-else.
773 (initWithTitle): Put () around assignment in if statement.
774 (ns_menu_show): Remove unused variables window and keymap.
775 (update_frame_tool_bar): Remove unused variable selected_p.
776 (initWithContentRect): Remove unused variable this_cmd_name.
777
778 * nsimage.m (ns_load_image, allocInitFromFile): Use SSDATA where
779 appropriate.
780 (setXBMColor): Remove unused variable len.
781 (setPixmapData): Put () around assignment in loop statement.
782
783 * nsfont.m (ns_get_family, ns_lang_to_script, ns_otf_to_script)
784 (ns_registry_to_script, ns_get_req_script, nsfont_open): Use SSDATA
785 where appropriate.
786 (ns_get_covering_families, ns_findfonts, nsfont_list_family): Put ()
787 around assignment in loop statement.
788 (nsfont_open): Remove unused variable i.
789 (nsfont_open): Remove unused variable len.
790 (nsfont_draw): Remove unused variable cs.
791
792 * nsfns.m (x_set_icon_name, ns_set_name_internal)
793 (ns_set_name_as_filename, ns_implicitly_set_icon_type)
794 (x_set_icon_type, ns_lisp_to_cursor_type, Fns_read_file_name)
795 (Fns_get_resource, Fns_set_resource, Fx_open_connection)
796 (Fns_font_name, Fns_perform_service)
797 (Fns_convert_utf8_nfd_to_nfc, ns_do_applescript)
798 (Fns_do_applescript, Fx_show_tip): Use SSDATA where appropriate.
799 (ns_set_name): Remove unused variable view.
800 (x_set_menu_bar_lines): Remove unused variable olines.
801 (x_set_tool_bar_lines): Remove unused variable root_window.
802 (Fns_list_colors): Put () around assignment in while statement.
803 (Fns_perform_service): Remove unused variable len.
804 (Fns_display_usable_bounds): Remove unused variable top.
805 (syms_of_nsfns): Remove unused variable i.
806
b55b9f85
JD
807 * nsmenu.m (ns_update_menubar): Exchange place of argument 2 and 3 to
808 memcpy (Bug#11907).
809
ed9265fc 8102012-07-13 Kalle Kankare <kalle.kankare@iki.fi> (tiny change)
2277de02
JD
811
812 * image.c (Fimagemagick_types): Initialize ex with GetExceptionInfo
813 and free it with DestroyExceptionInfo (Bug#11558).
814
ef099b57
JB
8152012-07-13 Juanma Barranquero <lekktu@gmail.com>
816
817 * s/ms-w32.h (FIRST_PTY_LETTER, HAVE_SOCKETS): Move to nt/config.nt.
818 (HAVE_ATTRIBUTE_ALIGNED, HAVE_C99_STRTOLD, HAVE___BUILTIN_UNWIND_INIT):
819 Set here, not in nt/config.nt.
820
ea814a5d
EZ
8212012-07-13 Eli Zaretskii <eliz@gnu.org>
822
823 * xdisp.c (move_it_in_display_line_to): On GUI terminals, allow
824 cursor overflow into the last glyph on display line when the right
825 fringe is off. (Bug#11832)
826
1a952767
PE
8272012-07-13 Paul Eggert <eggert@cs.ucla.edu>
828
829 * xdisp.c (produce_special_glyphs): Now static.
830 * dispextern.h (produce_special_glyphs): Remove decl.
831
983188fd
GM
8322012-07-13 Glenn Morris <rgm@gnu.org>
833
32fb4bb6
GM
834 * s/bsd-common, s/cygwin.h: Remove empty files.
835 * s/freebsd.h, s/netbsd.h: Do not include bsd-common.h.
836
983188fd
GM
837 * s/usg5-4-common.h (USG, USG5):
838 * s/template.h (USG5, USG, HPUX, BSD4_2, BSD_SYSTEM):
839 * s/sol2-6.h (SOLARIS2):
840 * s/irix6-5.h (IRIX6_5):
841 * s/hpux10-20.h (USG, USG5, HPUX):
842 * s/gnu-linux.h (USG, GNU_LINUX):
843 * s/freebsd.h (BSD_SYSTEM):
844 * s/darwin.h (BSD4_2, BSD_SYSTEM, DARWIN_OS):
845 * s/cygwin.h (CYGWIN):
846 * s/bsd-common.h (BSD_SYSTEM, BSD4_2):
847 * s/aix4-2.h (USG, USG5, _AIX): Move "system type" macros to configure.
848
d1e68667 8492012-07-13 BT Templeton <bpt@hcoop.net> (tiny change)
24ef80ae
PE
850
851 * nsfont.m (ns_charset_covers): Don't abort if no bitmap (Bug#11853).
24ef80ae 852
6de0e799
GM
8532012-07-13 Glenn Morris <rgm@gnu.org>
854
739ae010
GM
855 * s/usg5-4-common.h (NSIG_MINIMUM): Let configure set it.
856
dbee5793
GM
857 * s/gnu-linux.h, s/irix6-5.h: Let configure set ULIMIT_BREAK_VALUE.
858
6de0e799
GM
859 * process.c (init_process_emacs): Replace MIN_PTY_KERNEL_VERSION.
860 * s/darwin.h (MIN_PTY_KERNEL_VERSION): Remove single-use macro.
861
b82da769
GM
8622012-07-12 Glenn Morris <rgm@gnu.org>
863
4fae5a7a 864 * s/darwin.h (SYSTEM_PURESIZE_EXTRA): Move to configure.
b82da769
GM
865
866 * process.c (init_process_emacs): Rename from init_process.
867 The old name is also the name of a Mach system call.
868 * lisp.h, emacs.c: Update for this name change.
869 * nsgui.h, sysselect.h, s/darwin.h: Remove workaround that is no
870 longer needed.
871
5a979817
EZ
8722012-07-12 Eli Zaretskii <eliz@gnu.org>
873
874 * xdisp.c (insert_left_trunc_glyphs): Fix incorrect size in
875 memmove call that removes glyphs covered by the left truncation
876 glyph. Improve commentary.
877 (display_line): Fix display of continuation glyphs on GUI frames
878 when the right fringe is turned off and variable-size fonts are
879 used in the window. Move the code that appends a stretch glyph to
880 produce_special_glyphs, so that it could be used for truncation
881 and continuation glyphs alike.
882 (produce_special_glyphs) [HAVE_WINDOW_SYSTEM]: Produce a stretch
883 glyph of a suitably computed width, to align the special glyphs at
884 the window margin. Code moved from display_line. (Bug#11832)
885
3e91a053
GM
8862012-07-12 Glenn Morris <rgm@gnu.org>
887
ba9e4b84
GM
888 * s/aix4-2.h, s/hpux10-20.h: Let configure set NO_EDITRES.
889
890 * s/gnu-linux.h, s/hpux10-20.h:
891 Do not unconditionally define HAVE_XRMSETDATABASE.
892
3e91a053
GM
893 * s/gnu-linux.h (UNIX98_PTYS): Let configure set it.
894
b300b1f4
PE
8952012-07-12 Paul Eggert <eggert@cs.ucla.edu>
896
897 Fix typos that broke OS X build.
898 Reported by Randal L. Schwartz in
899 <http://lists.gnu.org/archive/html/emacs-devel/2012-07/msg00225.html>.
900 * nsterm.m (ns_timeout): Add missing local decl.
901 (ns_get_color): snprintf -> sprintf, to fix typo.
902
6e777848
GM
9032012-07-12 Glenn Morris <rgm@gnu.org>
904
3f922c37
GM
905 * src/s/aix4-2.h, src/s/cygwin.h, src/s/darwin.h:
906 * src/s/gnu-linux.h, src/s/hpux10-20.h, src/s/irix6-5.h:
907 * src/s/sol2-6.h, src/s/unixware.h, src/s/usg5-4-common.h:
908 Move PTY_NAME_SPRINTF, PTY_TTY_NAME_SPRINTF to configure.
909
0ab7b23a
GM
910 * s/cygwin.h, s/darwin.h, s/gnu-linux.h, s/irix6-5.h:
911 Move PTY_OPEN to configure.
912
6e777848
GM
913 * s/aix4-2.h, s/bsd-common.h, s/cygwin.h, s/darwin.h:
914 * s/gnu-linux.h, s/hpux10-20.h, s/irix6-5.h, s/template.h:
915 * s/usg5-4-common.h: Move FIRST_PTY_LETTER, PTY_ITERATION to configure.
916
4a7edc24
DA
9172012-07-12 Dmitry Antipov <dmantipov@yandex.ru>
918
919 Use empty_unibyte_string where applicable.
920 * keyboard.c (parse_tool_bar_item): Use empty_unibyte_string.
921 * lread.c (read1): Likewise.
922 * xsettings.c (syms_of_xsettings): Likewise.
923
308aab79
GM
9242012-07-12 Glenn Morris <rgm@gnu.org>
925
42bd1719
GM
926 * s/cygwin.h (G_SLICE_ALWAYS_MALLOC):
927 * s/freebsd.h (BROKEN_PTY_READ_AFTER_EAGAIN):
7ccad002
GM
928 * s/irix6-5.h (SETPGRP_RELEASES_CTTY, PREFER_VSUSP):
929 * s/hpux10-20.h (RUN_TIME_REMAP):
930 * s/bsd-common.h (TABDLY): Move to configure.
931
932 * s/hpux10-20.h, s/sol2-6.h: Move XOS_NEEDS_TIME_H to configure.
933
934 * s/bsd-common.h, s/darwin.h: Move TAB3 to configure.
935
ea0bbd17 936 * s/aix4-2.h (BROKEN_FIONREAD, BROKEN_SIGAIO, BROKEN_SIGPTY)
42bd1719 937 (BROKEN_SIGPOLL, BROKEN_GET_CURRENT_DIR_NAME): Let configure set them.
ea0bbd17
GM
938
939 * s/darwin.h (NO_ABORT, NO_MATHERR): Let configure set them.
51c3b9b4 940
308aab79
GM
941 * s/bsd-common.h, s/cygwin.h, s/gnu-linux.h, s/irix6-5.h:
942 * s/template.h: Move NARROWPROTO to configure.
943
ee1cf5cf
GM
9442012-07-11 Glenn Morris <rgm@gnu.org>
945
30fe9bf4
GM
946 * s/gnu-linux.h, s/sol2-6.h: No longer define POSIX,
947 unused since 2011-01-17 change to systty.h.
948
ee1cf5cf
GM
949 * s/aix4-2.h, s/bsd-common.h, s/cygwin.h, s/darwin.h, s/gnu-linux.h:
950 * s/hpux10-20.h, s/template.h, s/usg5-4-common.h:
951 Move HAVE_PTYS and HAVE_SOCKETS to configure.
952
63e47e07
PE
9532012-07-11 Paul Eggert <eggert@cs.ucla.edu>
954
955 * s/sol2-6.h (HAVE_LIBKSTAT): Remove. (Bug#11914)
956
c43fb4c3
GM
9572012-07-11 Glenn Morris <rgm@gnu.org>
958
959 * s/darwin.h, s/gnu-linux.h, s/template.h:
960 Move INTERRUPT_INPUT to configure.
961
e8df9267
DA
9622012-07-11 Dmitry Antipov <dmantipov@yandex.ru>
963
964 Minor adjustments to interning code.
965 * lisp.h (intern, intern_c_string): Redefine as static inline
966 wrappers for intern_1 and intern_c_string_1, respectively.
967 (intern_1, intern_c_string_1): Rename prototypes.
2bce5643
DA
968 * lread.c (intern_1, intern_c_string_1, oblookup): Simplify
969 Vobarray checking.
e8df9267
DA
970 * font.c (font_intern_prop): Likewise. Adjust comment.
971 * w32font.c (intern_font_name): Likewise.
972
34348bd4
AS
9732012-07-11 Andreas Schwab <schwab@linux-m68k.org>
974
d96a1e0c
AS
975 * gnutls.c (Fgnutls_boot): Properly parse :keylist argument.
976
34348bd4
AS
977 * coding.c (Fdefine_coding_system_internal): Use XCAR/XCDR instead
978 of Fcar/Fcdr if possible.
979 * font.c (check_otf_features): Likewise.
980 * fontset.c (Fnew_fontset): Likewise.
981 * gnutls.c (Fgnutls_boot): Likewise.
982 * minibuf.c (read_minibuf): Likewise.
983 * msdos.c (IT_set_frame_parameters): Likewise.
984 * xmenu.c (Fx_popup_dialog): Likewise.
985 * w32menu.c (Fx_popup_dialog): Likewise.
986
c8add24e
GM
9872012-07-11 Glenn Morris <rgm@gnu.org>
988
4b575b3c
GM
989 * s/bsd-common.h, s/cygwin.h: No need to undefine INTERRUPT_INPUT,
990 since nothing has defined it on these platforms.
991
09f4e3b0
GM
992 * s/aix4-2.h, s/bsd-common.h, s/cygwin.h, s/gnu-linux.h:
993 * s/irix6-5.h: Move SIGNALS_VIA_CHARACTERS to configure.
994
172bedef
GM
995 * s/aix4-2.h, s/bsd-common.h, s/cygwin.h, s/darwin.h:
996 * s/gnu-linux.h, s/hpux10-20.h, s/template.h, s/usg5-4-common.h:
997 Move CLASH_DETECTION to configure.
998
249685df
GM
999 * s/gnu.h: Remove file, which is now empty.
1000
c8add24e
GM
1001 * s/gnu.h, s/gnu-linux.h:
1002 Move GNU_LIBRARY_PENDING_OUTPUT_COUNT to configure.
1003
b41253a3
JW
10042012-07-11 John Wiegley <johnw@newartisans.com>
1005
1006 * alloc.c (mark_memory): Guard the "no_address_safety_analysis"
1007 function attribute, so we only use it if it exists in the
1008 compiler.
1009
d923b542
DA
10102012-07-11 Dmitry Antipov <dmantipov@yandex.ru>
1011
1012 Avoid call to strlen in fast_c_string_match_ignore_case.
1013 * search.c (fast_c_string_match_ignore_case): Change to use
1014 length argument. Adjust users accordingly.
1015 * lisp.h (fast_c_string_match_ignore_case): Adjust prototype.
1016
5ebbef1d
PE
10172012-07-11 Paul Eggert <eggert@cs.ucla.edu>
1018
bb352260
PE
1019 Assume mkdir, rmdir.
1020 * sysdep.c (mkdir) [!HAVE_MKDIR]: Remove.
1021 * sysdep.c (rmdir) [!HAVE_RMDIR]: Remove.
1022
57054ddd
PE
1023 Assume rename.
1024 * sysdep.c (rename) [!HAVE_RENAME]: Remove.
1025
b747d3f7
PE
1026 Assume perror.
1027 * s/hpux10-20.h (HAVE_PERROR): Remove.
1028 * sysdep.c (perror) [HPUX && !HAVE_PERROR]:
1029 Remove dummy definition, as this problem was obsolete long ago.
1030
5ebbef1d
PE
1031 Assume strerror.
1032 * sysdep.c (strerror) [!HAVE_STRERROR && !WINDOWSNT]: Remove.
1033
984e7f30
DA
10342012-07-11 Dmitry Antipov <dmantipov@yandex.ru>
1035
1036 Avoid calls to strlen in font processing functions.
1037 * font.c (font_parse_name, font_parse_xlfd, font_parse_fcname)
d923b542 1038 (font_open_by_name): Change to use length argument. Adjust
984e7f30 1039 users accordingly.
d923b542
DA
1040 * font.h (font_open_by_name, font_parse_xlfd, font_unparse_xlfd):
1041 Adjust prototypes.
1042 * xfont.c (xfont_decode_coding_xlfd, font_unparse_xlfd):
1043 Change to return ptrdiff_t.
984e7f30
DA
1044 (xfont_list_pattern, xfont_match): Use length returned by
1045 xfont_decode_coding_xlfd.
1046 * xfns.c (x_default_font_parameter): Omit useless xstrdup.
1047
20e94fdd
GM
10482012-07-11 Glenn Morris <rgm@gnu.org>
1049
9d596af3
GM
1050 * s/darwin.h, s/freebsd.h, s/netbsd.h:
1051 Move DONT_REOPEN_PTY to configure.
1052
20e94fdd
GM
1053 * sound.c (DEFAULT_SOUND_DEVICE) [!WINDOWSNT]:
1054 * s/netbsd.h (DEFAULT_SOUND_DEVICE): Let configure set it.
1055
e99a530f
PE
10562012-07-10 Paul Eggert <eggert@cs.ucla.edu>
1057
22ffb973
PE
1058 Remove "#define unix" that is no longer needed (Bug#11905).
1059 * s/aix4-2.h (unix): Remove; no longer needed.
1060
e9a9ae03
PE
1061 EMACS_TIME simplification (Bug#11875).
1062 This replaces macros (which typically do not work in GDB)
1063 with functions, typedefs and enums, making the code easier to debug.
1064 The functional style also makes code easier to read and maintain.
1065 * systime.h: Include <sys/time.h> on all hosts, not just if
1066 WINDOWSNT, since 'struct timeval' is needed in general.
1067 (EMACS_TIME): Now a typedef, not a macro.
1068 (EMACS_TIME_RESOLUTION, LOG10_EMACS_TIME_RESOLUTION): Now constants,
1069 not macros.
1070 (EMACS_SECS, EMACS_NSECS, EMACS_TIME_SIGN, EMACS_TIME_VALID_P)
1071 (EMACS_TIME_FROM_DOUBLE, EMACS_TIME_TO_DOUBLE, EMACS_TIME_EQ)
1072 (EMACS_TIME_NE, EMACS_TIME_GT, EMACS_TIME_GE, EMACS_TIME_LT)
1073 (EMACS_TIME_LE): Now functions, not macros.
1074 (EMACS_SET_SECS, EMACS_SET_NSECS, EMACS_SET_SECS_NSECS)
1075 (EMACS_SET_USECS, EMACS_SET_SECS_USECS): Remove these macros,
1076 which are not functions. All uses rewritten to use:
1077 (make_emacs_time): New function.
1078 (EMACS_SECS_ADDR, EMACS_SET_INVALID_TIME, EMACS_GET_TIME)
1079 (EMACS_ADD_TIME, EMACS_SUB_TIME): Remove these macros, which are
1080 not functions. All uses rewritten to use the following, respectively:
1081 (emacs_secs_addr, invalid_emacs_time, get_emacs_time)
1082 (add_emacs_time, sub_emacs_time): New functions.
ed9265fc 1083 * atimer.c: Don't include <sys/time.h>, as "systime.h" does this.
e9a9ae03
PE
1084 * fileio.c (Fcopy_file):
1085 * xterm.c (XTflash): Get the current time closer to when it's used.
1086 * makefile.w32-in ($(BLD)/atimer.$(O)): Update dependencies.
1087
ffacb126
PE
1088 * bytecode.c (targets): Suppress -Woverride-init warnings.
1089
e99a530f
PE
1090 Simplify by avoiding confusing use of strncpy etc.
1091 * doc.c (Fsnarf_documentation):
1092 * fileio.c (Ffile_name_directory, Fsubstitute_in_file_name):
1093 * frame.c (Fmake_terminal_frame):
1094 * gtkutil.c (get_utf8_string):
1095 * lread.c (openp):
1096 * nsmenu.m (ns_update_menubar):
1097 * regex.c (regerror):
1098 Prefer memcpy to strncpy and strncat when either will do.
1099 * fileio.c (Fsubstitute_in_file_name):
1100 * keyboard.c (MULTI_LETTER_MOD, parse_modifiers_uncached)
1101 (menu_separator_name_p):
1102 * nsmenu.m (ns_update_menubar):
1103 Prefer memcmp to strncmp when either will do.
1104 * nsterm.m: Include <ftoastr.h>.
1105 (ns_get_color):
1106 * s/gnu-linux.h, s/sol2-6.h, s/unixware.h (PTY_TTY_NAME_SPRINTF):
1107 Prefer snprintf to strncpy.
1108 * nsterm.m (ns_term_init):
1109 * widget.c (set_frame_size) [0]: Prefer xstrdup to xmalloc + strncpy.
1110 * nsterm.m (ns_term_init):
1111 Avoid the need for strncpy, by using build_string or
1112 make_unibyte_string directly. Use dtoastr, not snprintf.
1113 * process.c (Fmake_network_process): Diagnose service names that
1114 are too long, rather than silently truncating them or creating
1115 non-null-terminated names.
1116 (Fnetwork_interface_info): Likewise, for interface names.
1117 * sysdep.c (system_process_attributes) [GNU_LINUX]:
1118 Prefer sprintf to strncat.
1119 * xdisp.c (debug_method_add) [GLYPH_DEBUG]:
1120 Prefer vsnprintf to vsprintf + strncpy.
1121
c59592b3
GM
11222012-07-10 Glenn Morris <rgm@gnu.org>
1123
1124 * dispnew.c (PENDING_OUTPUT_COUNT) [!__GNU_LIBRARY__]:
1125 Clarify fallback case.
1126
7d7bbefd
DA
11272012-07-10 Dmitry Antipov <dmantipov@yandex.ru>
1128
1129 Use XCAR and XCDR instead of Fcar and Fcdr where possible.
1130 * callint.c, coding.c, doc.c, editfns.c, eval.c, font.c, fontset.c,
1131 * frame.c, gnutls.c, minibuf.c, msdos.c, textprop.c, w32fns.c,
d923b542 1132 * w32menu.c, window.c, xmenu.c: Change to use XCAR and XCDR
7d7bbefd
DA
1133 where argument type is known to be a Lisp_Cons.
1134
3a4c8000
TT
11352012-07-10 Tom Tromey <tromey@redhat.com>
1136
1137 * bytecode.c (BYTE_CODE_THREADED): New macro.
1138 (BYTE_CODES): New macro. Replaces all old byte-code defines.
1139 (enum byte_code_op): New type.
1140 (CASE, NEXT, FIRST, CASE_DEFAULT, CASE_ABORT): New macros.
1141 (exec_byte_code): Use them. Use token threading when applicable.
1142
2a0213a6
DA
11432012-07-10 Dmitry Antipov <dmantipov@yandex.ru>
1144
1145 Optimize pure C strings initialization.
1146 * lisp.h (make_pure_string): Fix prototype.
1147 (build_pure_c_string): New function, defined as static inline. This
1148 provides a better opportunity to optimize away calls to strlen when
1149 the function is called with compile-time constant argument.
1150 * alloc.c (make_pure_c_string): Fix comment. Change to add nchars
1151 argument, adjust users accordingly. Use build_pure_c_string where
1152 appropriate.
1153 * buffer.c, coding.c, data.c, dbusbind.c, fileio.c, fontset.c, frame.c,
1154 * keyboard.c, keymap.c, lread.c, search.c, syntax.c, w32fns.c, xdisp.c,
1155 * xfaces.c, xfns.c, xterm.c: Use build_pure_c_string where appropriate.
1156
cb1caeaf
DA
11572012-07-10 Dmitry Antipov <dmantipov@yandex.ru>
1158
1159 Avoid calls to strlen in miscellaneous functions.
1160 * buffer.c (init_buffer): Use precalculated len, adjust if needed.
1161 * font.c (Ffont_xlfd_name): Likewise. Change to call make_string.
1162 * lread.c (openp): Likewise.
1163
c293e30c
DA
11642012-07-10 Dmitry Antipov <dmantipov@yandex.ru>
1165
1166 Avoid calls to strlen in path processing functions.
1167 * fileio.c (file_name_as_directory): Add comment. Change to add
1168 srclen argument and return the length of result. Adjust users
1169 accordingly.
1170 (directory_file_name): Fix comment. Change to add srclen argument,
cb1caeaf 1171 swap 1st and 2nd arguments to obey the common convention. Adjust
c293e30c
DA
1172 users accordingly.
1173 * filelock.c (fill_in_lock_file_name): Avoid calls to strlen.
1174
9e059e3f
GM
11752012-07-10 Glenn Morris <rgm@gnu.org>
1176
d02eb359
GM
1177 * s/cygwin.h, s/darwin.h, s/freebsd.h, s/netbsd.h, s/unixware.h:
1178 Move PENDING_OUTPUT_COUNT definition to configure.
1179
882cf227
GM
1180 * s/irix6-5.h (DATA_START, DATA_SEG_BITS):
1181 * s/hpux10-20.h (DATA_SEG_BITS, DATA_START):
1182 * s/gnu.h (DATA_START): Move definitions to configure.
1183
af6e839f
GM
1184 * s/irix6-5.h (SETUP_SLAVE_PTY, PTY_NAME_SPRINTF): Drop ifdef guards.
1185 We include usg5-4-common.h, which defines them both.
1186
40289a12
GM
1187 * s/gnu.h: Don't include fcntl.h (every file in Emacs that uses
1188 O_RDONLY already includes it).
1189
9e059e3f
GM
1190 Stop ns builds setting the EMACSLOADPATH environment variable.
1191 * nsterm.m (ns_load_path): Rename from ns_init_paths.
1192 Now it does not set EMACSLOADPATH, just returns the load-path string.
1193 * nsterm.h: Update accordingly.
1194 * lread.c [HAVE_NS]: Include nsterm.h.
1195 (init_lread) [HAVE_NS]: Use ns_load_path.
1196 * emacs.c (main) [HAVE_NS]: No longer call ns_init_paths.
1197
7c4e8ec0
GM
11982012-07-09 Glenn Morris <rgm@gnu.org>
1199
d4f600ff
GM
1200 * s/gnu.h (SIGNALS_VIA_CHARACTERS): No need to define it here,
1201 since the included bsd-common.h does so.
1202
cbb31951
GM
1203 Stop ns builds setting the EMACSPATH environment variable.
1204 * nsterm.m (ns_exec_path): New function, split from ns_init_paths.
1205 (ns_init_paths): Do not set EMACSPATH.
1206 * nsterm.h (ns_exec_path): Add it.
1207 * callproc.c (init_callproc_1, init_callproc) [HAVE_NS]:
1208 Use ns_exec_path.
1209
7c4e8ec0
GM
1210 * nsterm.m, nsterm.h (ns_etc_directory): Fix type, empty return.
1211
26bccfae
PE
12122012-07-09 Paul Eggert <eggert@cs.ucla.edu>
1213
a0bee46f
PE
1214 * process.c (wait_reading_process_output): 'waitchannels' was unset
1215 when read_kbd || !NILP (wait_for_cell); fix this.
1216
5994c183
PE
1217 Add GCC-style 'const' attribute to functions that can use it.
1218 * character.h (char_resolve_modifier_mask):
1219 * keyboard.h (make_ctrl_char):
1220 * lisp.h (multibyte_char_to_unibyte, multibyte_char_to_unibyte_safe)
1221 (init_character_once, next_almost_prime, init_fns, init_image)
1222 (flush_pending_output, init_sound):
1223 * mem-limits.h (start_of_data):
1224 * menu.h (finish_menu_items):
1225 Add ATTRIBUTE_CONST.
1226 * emacs.c (DEFINE_DUMMY_FUNCTION):
1227 Declare the dummy function with ATTRIBUTE_CONST.
1228 * lisp.h (Fbyteorder, Fmax_char, Fidentity):
1229 Add decls with ATTRIBUTE_CONST.
1230
26bccfae
PE
1231 Minor improvements to make_formatted_string.
1232 * alloc.c (make_formatted_string): Prefer int to ptrdiff_t
1233 where int is good enough, as vsprintf returns an int.
1234 * lisp.h (make_formatted_string): Add ATTRIBUTE_FORMAT_PRINTF.
1235
a8290ec3
DA
12362012-07-09 Dmitry Antipov <dmantipov@yandex.ru>
1237
1238 Use make_formatted_string to avoid double length calculation.
1239 * lisp.h (make_formatted_string): New prototype.
1240 * alloc.c (make_formatted_string): New function.
1241 * buffer.c (Fgenerate_new_buffer_name): Use it.
1242 * dbus.c (syms_of_dbusbind): Likewise.
1243 * editfns.c (Fcurrent_time_zone): Likewise.
1244 * filelock.c (get_boot_time): Likewise.
1245 * frame.c (make_terminal_frame, set_term_frame_name)
1246 (x_report_frame_params): Likewise.
1247 * image.c (gs_load): Likewise.
1248 * minibuf.c (get_minibuffer): Likewise.
1249 * msdos.c (dos_set_window_size): Likewise.
1250 * process.c (make_process): Likewise.
1251 * xdisp.c (ensure_echo_area_buffers): Likewise.
1252 * xsettings.c (apply_xft_settings): Likewise.
1253
d01ba2f1
GM
12542012-07-09 Glenn Morris <rgm@gnu.org>
1255
1256 Stop ns builds polluting the environment with EMACSDATA, EMACSDOC.
1257 * nsterm.m (ns_etc_directory): New function, split from ns_init_paths.
1258 (ns_init_paths): Do not set EMACSDATA, EMACSDOC.
1259 * nsterm.h (ns_etc_directory): Add it.
1260 * callproc.c [HAVE_NS]: Include nsterm.h.
1261 (init_callproc_1, init_callproc) [HAVE_NS]: Use ns_etc_directory.
1262
f1f924b6
DA
12632012-07-09 Dmitry Antipov <dmantipov@yandex.ru>
1264
1265 Move marker debugging code under MARKER_DEBUG.
1266 * marker.c (MARKER_DEBUG): Move marker debugging code under
1267 #ifdef MARKER_DEBUG because byte_char_debug_check is too slow
1268 for bootstrap with --enable-checking (~3x slowdown reported
1269 by Juanma Barranquero <lekktu@gmail.com>).
1270 (verify_bytepos): Move under #ifdef MARKER_DEBUG.
1271
ab531b66
PE
12722012-07-08 Paul Eggert <eggert@cs.ucla.edu>
1273
1274 * systime.h (EMACS_SUB_TIME): Clarify behavior with unsigned time_t.
1275 See <http://bugs.gnu.org/11825#29>.
1276
c4b3bc8a
EZ
12772012-07-08 Eli Zaretskii <eliz@gnu.org>
1278
1279 * xdisp.c (fill_glyphless_glyph_string): If the face of the glyph
1280 has no font, use the frame's font. (Bug#11813)
3434fe8a
EZ
1281 (display_line): Add commentary about displaying truncation glyphs
1282 on GUI frames.
1283 (produce_special_glyphs): Move here from term.c.
1284
1285 * term.c (produce_special_glyphs): Move to xdisp.c.
1286
1287 * dispextern.h (produce_special_glyphs): Move prototype to xdisp.c
1288 section.
c4b3bc8a 1289
b676b881
AS
12902012-07-07 Andreas Schwab <schwab@linux-m68k.org>
1291
f17c5273
AS
1292 * xdisp.c (display_line): Avoid warning about implicit declaration
1293 of FRAME_FONT.
1294
298819b9
AS
1295 * frame.c (get_frame_param): Define only if HAVE_WINDOW_SYSTEM.
1296
b676b881
AS
1297 * lisp.h: Remove empty conditional.
1298
6045c4fd
PE
12992012-07-07 Paul Eggert <eggert@cs.ucla.edu>
1300
b3350bf9
PE
1301 * lread.c (load_path_check): Now static.
1302
6045c4fd
PE
1303 Fix some minor --with-ns problems found by static checking.
1304 * frame.c (Ftool_bar_pixel_width) [!FRAME_TOOLBAR_WIDTH]:
1305 (x_set_font) [!HAVE_X_WINDOWS]:
1306 * image.c (xpm_load_image) [HAVE_NS]:
1307 (x_to_xcolors) [!HAVE_X_WINDOWS && !HAVE_NTGUI]:
1308 (x_disable_image) [!HAVE_NS && !HAVE_NTGUI]:
1309 Remove unused local.
1310 (Fx_parse_geometry) [HAVE_NS]: Don't return garbage.
1311 (xpm_load_image) [HAVE_NS && !HAVE_XPM]: Remove unused label.
1312 * image.c (x_create_bitmap_from_file) [HAVE_NS]:
1313 (xpm_load_image, xpm_load) [HAVE_NS && !HAVE_XPM]:
1314 * nsselect.m (symbol_to_nsstring, ns_string_to_pasteboard_internal):
1315 * xfaces.c (Fx_load_color_file) [!HAVE_X_WINDOWS]:
1316 Fix pointer signedness problem.
1317 * xfaces.c (FRAME_X_FONT_TABLE):
1318 * xterm.h (FRAME_X_FONT_TABLE): Remove unused, incompatible macros.
1319
929e7845
GM
13202012-07-07 Glenn Morris <rgm@gnu.org>
1321
1322 * lread.c (load_path_check): New function, split from init_lread.
1323 (init_lread): Reorganize. Motivation:
1324 If EMACSLOADPATH is set, check/warn about that rather than the
1325 defaults, which we are not going to use. Hence we can remove
1326 the turn_off_warning and WINDOWSNT || HAVE_NS tests.
1327 Don't warn if site-lisp directories are missing.
1328 If not installed, start from a blank load-path, since
1329 PATH_LOADSEARCH refers to the eventual installation directories.
1330
58dd0aa4
EZ
13312012-07-07 Eli Zaretskii <eliz@gnu.org>
1332
1333 Support truncation and continuation glyphs on GUI frames, when
1334 fringes are disabled. (Bug#11832)
1335 * xdisp.c (init_iterator): Get dimensions of truncation and
1336 continuation glyphs even if on GUI frames. Adjust
1337 it->last_visible_x on GUI frames when the left or right fringes,
1338 or both, are absent.
1339 (start_display, move_it_in_display_line_to): Handle the case of a
1340 GUI frame without a fringe to display continuation or truncation
1341 glyphs.
1342 (insert_left_trunc_glyphs): Support GUI frames: make sure
1343 truncation glyphs overwrite enough glyphs from the current line to
1344 have sufficient space in pixels.
1345 (display_line): Support truncation and continuation glyphs on GUI
1346 frames. If some spare pixels are left on the line after inserting
1347 the truncation glyphs, fill that space with a stretch glyph of a
1348 suitably computed width.
1349
1350 * term.c (produce_special_glyphs): Call PRODUCE_GLYPHS, not
1351 produce_glyphs, to support GUI sessions.
1352
31571fd7
PE
13532012-07-07 Paul Eggert <eggert@cs.ucla.edu>
1354
5a16b9bc
PE
1355 * sysdep.c (ULLONG_MAX): Define if not already defined (Bug#11781).
1356
f3047c75
PE
1357 * sysdep.c (list_system_processes): Port to NetBSD-current (Bug#11797).
1358
31571fd7
PE
1359 Do not require float-time's arg to fit in time_t (Bug#11825).
1360 This works better on hosts where time_t is unsigned, and where
1361 float-time is applied to the (negative) difference between two times.
1362 * editfns.c (decode_time_components): Last arg is now double *,
1363 not int *, and means to store all the result as a double, without
1364 worrying about whether the seconds part fits in time_t.
1365 All callers changed.
1366 (lisp_time_argument): Remove last int * arg, as it's no longer needed.
1367 All callers changed.
1368 (Ffloat_time): Do not fail merely because the specified time falls
1369 outside of time_t range.
1370
4516fbef
GM
13712012-07-07 Glenn Morris <rgm@gnu.org>
1372
1373 * s/darwin.h (HAVE_RES_INIT, HAVE_LIBRESOLV):
1374 * s/hpux10-20.h (HAVE_RINT, HAVE_RANDOM):
1375 * s/unixware.h (HAVE_GETWD): Move undefs to configure (effectively).
1376
07adc2c6
JB
13772012-07-07 Juanma Barranquero <lekktu@gmail.com>
1378
1379 * makefile.w32-in (DISPEXTERN_H, $(BLD)/regex.$(O)):
1380 Update dependencies.
1381
1382 * s/ms-w32.h [_MSC_VER]: Remove strcasecmp, strncasecmp.
1383
fd573f31
PE
13842012-07-06 Paul Eggert <eggert@cs.ucla.edu>
1385
fee5959d
PE
1386 Use c_strcasecmp for ASCII case-insensitive comparison (Bug#11786).
1387 * dispextern.h, nsfns.m, nsterm.m: Include <c-strcase.h>.
1388 * dispextern.h (xstrcasecmp): Rewrite using c_strcasecmp.
1389 * nsfns.m (x_get_string_resource): Use c_strncasecmp, not strncasecmp.
1390 * nsterm.m (ns_default): Use c_strcasecmp, not strcasecmp.
1391 * xfaces.c (xstrcasecmp) [!HAVE_STRCASECMP]: Remove.
1392
fd573f31
PE
1393 * xfont.c (compare_font_names): Redo to omit the need for casts.
1394
ddadbc0e
AS
13952012-07-06 Andreas Schwab <schwab@linux-m68k.org>
1396
fca8d6b6
AS
1397 * xfns.c (Fx_change_window_property): Doc fix.
1398 * w32fns.c (Fx_change_window_property): Doc fix.
1399
ddadbc0e
AS
1400 * w32fns.c (Fx_window_property): Accept the same arguments as the
1401 X Windows version. Doc fix.
1402 * xfns.c (Fx_window_property): Doc fix. (Bug#11870)
1403
ed9265fc 14042012-07-06 Juanma Barranquero <lekktu@gmail.com>
f247498e
JB
1405 Eli Zaretskii <eliz@gnu.org>
1406
1407 * s/ms-w32.h: Settings not specific to Windows moved to nt/config.nt.
1408 Windows-specific code from nt/config.nt moved here.
1409 Obsolete settings removed.
1410
216ee680
PE
14112012-07-06 Paul Eggert <eggert@cs.ucla.edu>
1412
1413 * process.c: Avoid unnecessary calls to gettime.
1414 (wait_reading_process_output): Don't get the time of day
1415 when gobbling data immediately and not waiting, as there's no need
1416 for it in that case. This removes a FIXME.
1417
bdd091e4
JD
14182012-07-06 Jan Djärv <jan.h.d@swipnet.se>
1419
1420 * gtkutil.c (xg_event_is_for_scrollbar): Assign gwin when HAVE_GTK3
1421 is defined (Bug#11768).
1422
9d44f8ce
DA
14232012-07-06 Dmitry Antipov <dmantipov@yandex.ru>
1424
1425 Fix marker debugging code.
1426 * marker.c (byte_char_debug_check): Do not perform the check
1427 if buffer is not multibyte.
090bd7cb
JB
1428 (buf_charpos_to_bytepos, buf_bytepos_to_charpos):
1429 Call byte_char_debug_check with correct arguments.
9d44f8ce 1430
90fc4786
DA
14312012-07-06 Dmitry Antipov <dmantipov@yandex.ru>
1432
1433 Compile marker debugging code only if ENABLE_CHECKING is defined.
090bd7cb
JB
1434 * marker.c (byte_char_debug_check, count_markers):
1435 Use only if ENABLE_CHECKING is defined.
90fc4786
DA
1436 (byte_debug_flag): Remove.
1437 (CONSIDER, buf_charpos_to_bytepos, buf_bytepos_to_charpos):
1438 Always call byte_char_debug_check if ENABLE_CHECKING is defined.
1439
7b7ae965
DA
14402012-07-06 Dmitry Antipov <dmantipov@yandex.ru>
1441
4e57b342
DA
1442 Avoid code repetition in marker-related functions.
1443 * marker.c (attach_marker): New function.
1444 (Fset_marker, set_marker_restricted, set_marker_both)
1445 (set_marker_restricted_both): Use it.
1446 (Fset_marker, set_marker_restricted, Fbuffer_has_markers_at):
1447 Consistently rename charno to charpos.
1448 (marker_position): Add eassert.
1449 (marker_byte_position): Convert to eassert.
1450
14512012-07-06 Dmitry Antipov <dmantipov@yandex.ru>
1452
1453 Simplify list operations in unchain_overlay and unchain_marker.
7b7ae965 1454 * buffer.c (unchain_overlay): Simplify. Add comment.
4e57b342 1455 * marker.c (unchain_marker): Simplify. Fix comments.
7b7ae965 1456
657924ff
DA
14572012-07-06 Dmitry Antipov <dmantipov@yandex.ru>
1458
1459 Introduce fast path for the widely used marker operation.
1460 * alloc.c (build_marker): New function.
1461 * lisp.h (build_marker): New prototype.
1462 * buffer.c (clone_per_buffer_values, Fmake_indirect_buffer): Use it.
1463 * composite.c (autocmp_chars): Likewise.
1464 * editfns.c (buildmark): Remove.
1465 (Fpoint_marker, Fpoint_min_marker, Fpoint_max_marker)
1466 (save_restriction_save): Use build_marker.
1467 * marker.c (buf_charpos_to_bytepos, buf_bytepos_to_charpos): Likewise.
1468 * window.c (save_window_save): Likewise.
1469
041a49a6
DA
14702012-07-06 Dmitry Antipov <dmantipov@yandex.ru>
1471
1472 Do not use Fdelete_overlay in delete_all_overlays
1473 to avoid redundant calls to unchain_overlay.
1474 * buffer.c (drop_overlay): New function.
1475 (delete_all_overlays, Fdelete_overlay): Use it.
1476 * minibuf.c (get_minibuffer): Fix comment.
1477
7dca65a4
PE
14782012-07-06 Paul Eggert <eggert@cs.ucla.edu>
1479
1480 Port to OpenBSD 5.1 amd64.
1481 * sysdep.c [BSD_SYSTEM]: Include <sys/param.h> before <sys/sysctl.h>.
1482 This is needed for OpenBSD, and should be harmless on all BSD systems.
1483 Also, include <sys/sysctl.h>, as it should be available on all
1484 BSD_SYSTEM hosts given that we're already calling sysctl in that case.
1485 (list_system_processes) [__OpenBSD__]: Use DARWIN_OS style mib, but
1486 use p_pid member, not kp_proc.pid.
1487
8eb876e2
GM
14882012-07-06 Glenn Morris <rgm@gnu.org>
1489
1490 * Makefile.in (emacs$(EXEEXT)): Don't check for load-path shadows.
1491
38182d90
PE
14922012-07-05 Paul Eggert <eggert@cs.ucla.edu>
1493
1494 More xmalloc and related cleanup.
1495 * alloc.c, bidi.c, buffer.c, buffer.h, bytecode.c, callint.c:
1496 * callproc.c, charset.c, coding.c, composite.c, data.c, dispnew.c:
1497 * doc.c, editfns.c, emacs.c, eval.c, fileio.c, filelock.c, fns.c:
1498 * font.c, fontset.c, frame.c, fringe.c, ftfont.c, ftxfont.c, gmalloc.c:
1499 * gtkutil.c, image.c, keyboard.c, keymap.c, lread.c, macros.c, menu.c:
1500 * nsfns.m, nsfont.m, nsmenu.m, nsterm.m, print.c, process.c, ralloc.c:
1501 * regex.c, region-cache.c, scroll.c, search.c, sound.c, syntax.c:
1502 * sysdep.c, term.c, termcap.c, unexmacosx.c, window.c, xdisp.c:
1503 * xfaces.c, xfns.c, xftfont.c, xgselect.c, xmenu.c, xrdb.c, xselect.c:
1504 * xterm.c:
1505 Omit needless casts involving void * pointers and allocation.
1506 Prefer "P = xmalloc (sizeof *P)" to "P = xmalloc (sizeof (TYPE_OF_P))",
1507 as the former is more robust if P's type is changed.
1508 Prefer xzalloc to xmalloc + memset 0.
1509 Simplify malloc-or-realloc to realloc.
1510 Don't worry about xmalloc returning a null pointer.
1511 Prefer xstrdup to xmalloc + strcpy.
1512 * editfns.c (Fmessage_box): Grow message_text by at least 80 when
1513 growing it.
1514 * keyboard.c (apply_modifiers_uncached): Prefer local array to
1515 alloca of a constant.
1516
6dd5a677
EZ
15172012-07-05 Eli Zaretskii <eliz@gnu.org>
1518
1519 * xdisp.c (display_line): Fix horizontal pixel coordinates when
1520 hscroll is larger than the line width. Fixes long and futile
1521 looping inside extend_face_to_end_of_line (on a TTY) producing
1522 glyphs that are not needed and thrown away.
1523
6b312f0f
DA
15242012-07-05 Dmitry Antipov <dmantipov@yandex.ru>
1525
1526 * marker.c (set_marker_restricted_both): Simplify by using
1527 clip_to_bounds.
1528
f520ef9b
PE
15292012-07-05 Paul Eggert <eggert@cs.ucla.edu>
1530
1531 * editfns.c (region_limit): Simplify by using clip_to_bounds.
1532
383b7c95
JD
15332012-07-05 Jan Djärv <jan.h.d@swipnet.se>
1534
1535 * gtkutil.c (gtk_scrollbar_new, gtk_box_new): Define when HAVE_GTK3 is
1536 not defined (Bug#11768).
1537 (xg_create_frame_widgets): Use gtk_plug_new_for_display (Bug#11768).
1538 (xg_create_frame_widgets, create_dialog, xg_get_file_with_chooser)
1539 (make_widget_for_menu_item, xg_make_tool_item): Use gtk_box_new
1540 followed by gtk_box_set_homogeneous (Bug#11768).
1541 (xg_update_menu_item): Use GTK_IS_BOX (Bug#11768).
090bd7cb
JB
1542 (update_theme_scrollbar_width, xg_create_scroll_bar):
1543 Use gtk_scrollbar_new (Bug#11768).
383b7c95
JD
1544 (xg_event_is_for_scrollbar): Use Gdk Device functions for HAVE_GTK3.
1545 (is_box_type): New function (Bug#11768).
1546 (xg_tool_item_stale_p): Call is_box_type.
5293d758 1547 (xg_initialize): Get settings by calling gtk_settings_get_for_screen
383b7c95
JD
1548 with default display (Bug#11768).
1549
d6e7bf45
EZ
15502012-07-05 Eli Zaretskii <eliz@gnu.org>
1551
1552 * xdisp.c (window_hscroll_limited): New function.
1553 (pos_visible_p, init_iterator): Use it to avoid overflow of pixel
1554 coordinates when window's hscroll is set to insanely large
1555 values. (Bug#11857)
1556
431391ec
JB
15572012-07-05 Juanma Barranquero <lekktu@gmail.com>
1558
1559 * makefile.w32-in ($(BLD)/dired.$(O), $(BLD)/fileio.$(O)): Fix typo.
1560 ($(BLD)/terminal.$(O), $(BLD)/syntax.$(O)): Update dependencies.
1561
23f86fce
DA
15622012-07-05 Dmitry Antipov <dmantipov@yandex.ru>
1563
1564 Cleanup xmalloc.
1565 * lisp.h (xzalloc): New prototype. Omit needless casts.
1566 * alloc.c (xzalloc): New function. Omit needless casts.
1567 * charset.c: Omit needless casts. Convert all calls to
1568 xmalloc with following memset to xzalloc.
1569 * dispnew.c: Likewise.
1570 * fringe.c: Likewise.
1571 * image.c: Likewise.
1572 * sound.c: Likewise.
1573 * term.c: Likewise.
1574 * w32fns.c: Likewise.
1575 * w32font.c: Likewise.
1576 * w32term.c: Likewise.
1577 * xfaces.c: Likewise.
1578 * xfns.c: Likewise.
1579 * xterm.c: Likewise.
1580 * atimer.c: Omit needless casts.
1581 * buffer.c: Likewise.
1582 * callproc.c: Likewise.
1583 * ccl.c: Likewise.
1584 * coding.c: Likewise.
1585 * composite.c: Likewise.
1586 * doc.c: Likewise.
1587 * doprnt.c: Likewise.
1588 * editfns.c: Likewise.
1589 * emacs.c: Likewise.
1590 * eval.c: Likewise.
1591 * filelock.c: Likewise.
1592 * fns.c: Likewise.
1593 * gtkutil.c: Likewise.
1594 * keyboard.c: Likewise.
1595 * lisp.h: Likewise.
1596 * lread.c: Likewise.
1597 * minibuf.c: Likewise.
1598 * msdos.c: Likewise.
1599 * print.c: Likewise.
1600 * process.c: Likewise.
1601 * region-cache.c: Likewise.
1602 * search.c: Likewise.
1603 * sysdep.c: Likewise.
1604 * termcap.c: Likewise.
1605 * terminal.c: Likewise.
1606 * tparam.c: Likewise.
1607 * w16select.c: Likewise.
1608 * w32.c: Likewise.
1609 * w32reg.c: Likewise.
1610 * w32select.c: Likewise.
1611 * w32uniscribe.c: Likewise.
1612 * widget.c: Likewise.
1613 * xdisp.c: Likewise.
1614 * xmenu.c: Likewise.
1615 * xrdb.c: Likewise.
1616 * xselect.c: Likewise.
1617
0497dc44
PE
16182012-07-05 Paul Eggert <eggert@cs.ucla.edu>
1619
1620 * fileio.c (time_error_value): Check the right error number.
1621 Problem reported by Troels Nielsen in
1622 <http://lists.gnu.org/archive/html/emacs-devel/2012-07/msg00095.html>.
1623
356e7178
PE
16242012-07-04 Paul Eggert <eggert@cs.ucla.edu>
1625
4e71fd89
PE
1626 * window.c (set_window_hscroll): Revert the 100000 hscroll limit.
1627 This should be fixed in a better way; see Eli Zaretskii in
1628 <http://lists.gnu.org/archive/html/emacs-devel/2012-07/msg00088.html>.
1629 (HSCROLL_MAX): Remove; this is now internal to set_window_hscroll.
1630
f0941253
PE
1631 * fileio.c (time_error_value): Rename from special_mtime.
1632 The old name's problems were noted by Eli Zaretskii in
1633 <http://lists.gnu.org/archive/html/emacs-devel/2012-07/msg00087.html>.
1634
065c9eb4
PE
1635 * emacs.c (gdb_pvec_type): Change it back to enum pvec_type.
1636 This variable's comment says Emacs needs at least one GDB-visible
1637 symbol of type enum pvec_type, to work around GDB problems.
1638 The symbol's value doesn't matter.
1639
356e7178
PE
1640 * alloc.c (PSEUDOVECTOR_NBYTES): Remove stray ';'
1641 that causes compilation to fail on pre-C99 compilers.
1642
ed9265fc 16432012-07-04 Juanma Barranquero <lekktu@gmail.com>
95f61aa2
JB
1644
1645 * s/ms-w32.h (LISP_FLOAT_TYPE, HAVE_MEMCMP, HAVE_MEMCPY)
1646 (HAVE_MEMMOVE, HAVE_MEMSET): Don't set, obsolete.
1647
3884d954
DA
16482012-07-04 Dmitry Antipov <dmantipov@yandex.ru>
1649
d209e2fb 1650 * buffer.c (init_buffer_once): Fix initialization of
3884d954
DA
1651 headers for buffer_defaults and buffer_local_symbols.
1652 Reported by Juanma Barranquero <lekktu@gmail.com>.
1653
ee28be33
SM
16542012-07-04 Stefan Monnier <monnier@iro.umontreal.ca>
1655
1656 Turn VECTOR_FREE_LIST_FLAG into PVEC_FREE.
1657 * lisp.h (enum pvec_type): Use fewer bits.
1658 (PSEUDOVECTOR_SIZE_BITS): New constant.
1659 (PSEUDOVECTOR_SIZE_MASK, PVEC_TYPE_MASK): Use it.
1660 (XSETPVECTYPESIZE, XSETTYPED_PSEUDOVECTOR, DEFUN): Adapt code to
1661 change in pvec_type.
1662 (PSEUDOVECTOR_TYPEP): New macro.
1663 (TYPED_PSEUDOVECTORP): Use it.
1664 * fns.c (internal_equal): Adapt code to extract pvectype.
1665 * emacs.c (gdb_pvec_type): Update type.
1666 * alloc.c (PSEUDOVECTOR_NBYTES): New macro.
1667 (VECTOR_FREE_LIST_SIZE_MASK): Remove (=> PSEUDOVECTOR_SIZE_MASK).
1668 (VECTOR_FREE_LIST_FLAG): Remove (=> PVEC_FREE).
1669 (SETUP_ON_FREE_LIST): Use XSETPVECTYPESIZE.
1670 (sweep_vectors): Use it. Use local var `total_bytes' instead of
1671 abusing vector->header.next.nbytes.
1672 (live_vector_p): Use PVEC_TYPE.
1673 (mark_object): Adapt code to extract pvectype. Use switch.
1674
c7f2cd7f
PE
16752012-07-04 Paul Eggert <eggert@cs.ucla.edu>
1676
1677 * doprnt.c (doprnt): Don't assume string length fits in 'int'.
1678 Tighten new eassert a bit.
1679
8ce70ed2
DA
16802012-07-04 Dmitry Antipov <dmantipov@yandex.ru>
1681
1682 Fix compilation with --enable-gcc-warnings and -O1
1683 optimization level.
1684 * doprnt.c (doprnt): Change type of tem to int, initialize
1685 to avoid compiler warning. Add eassert.
1686 * search.c (simple_search): Initialize match_byte to avoid
1687 compiler warning. Add eassert.
1688
dea7f1e5
PE
16892012-07-04 Paul Eggert <eggert@cs.ucla.edu>
1690
24a212eb
PE
1691 Avoid weird behavior with large horizontal scrolls.
1692 Without this change, for example, large hscroll values would
1693 mess up Emacs's display on Fedora 15 x86, presumably due to
1694 overflows in int calculations in the display code.
1695 Also, if buffers had long lines, Emacs would freeze.
1696 * window.c (HSCROLL_MAX): Reduce to 100000, and make it visible to GDB.
1697 (set_window_hscroll): New function, containing the old guts of
1698 Fset_window_hscroll. Return the clipped value.
1699 (Fset_window_hscroll, Fscroll_left, Fscroll_right): Use it.
1700 This avoids the need to check against PTRDIFF_MAX.
1701
dea7f1e5
PE
1702 * buffer.c (Fgenerate_new_buffer_name): Fix sprintf format mismatch.
1703
76046526
DA
17042012-07-04 Dmitry Antipov <dmantipov@yandex.ru>
1705
1706 * buffer.c (Fgenerate_new_buffer_name): Fix type mismatch.
1707
39adff0d
PE
17082012-07-04 Paul Eggert <eggert@cs.ucla.edu>
1709
63807d47
PE
1710 * regex.c: Suppress GCC warning on RHEL 6. (Bug#11207)
1711 Conditionalize the pragmas on GCC 4.5 or later, not GCC 4.3 or later,
1712 since GCC 4.4.6 issues a bogus warning for them.
1713
39adff0d
PE
1714 Fix bugs in file timestamp newness comparisons.
1715 * fileio.c (Ffile_newer_than_file_p):
1716 * lread.c (Fload): Use full timestamp resolution of files,
1717 not just the 1-second resolution, so that files that are only
1718 slightly newer still count as newer.
1719 * fileio.c (Ffile_newer_than_file_p): Don't assume file
1720 timestamps fit in 'int'; this fixes a Y2038 bug on most hosts.
1721
dbeed9a6
PE
17222012-07-03 Paul Eggert <eggert@cs.ucla.edu>
1723
1724 * fileio.c: Improve handling of file time marker. (Bug#11852)
1725 (special_mtime): New function.
1726 (Finsert_file_contents, Fverify_visited_file_modtime):
1727 Use it to set special mtime values consistently.
1728
636334d6
AS
17292012-07-03 Andreas Schwab <schwab@linux-m68k.org>
1730
1731 * fileio.c (Finsert_file_contents): Properly handle st_mtime
1732 marker for non-existing file. (Bug#11852)
1733
e2017fe2
GM
17342012-07-03 Glenn Morris <rgm@gnu.org>
1735
1736 * lisp.h (Fread_file_name): Restore EXFUN (it's not a normal DEFUN
1737 and did not make it into globals.h).
1738
404dbd37
TT
17392012-07-03 Tom Tromey <tromey@redhat.com>
1740
1741 * window.c (Fset_window_margins, Fset_window_fringes)
1742 (Fset_window_scroll_bars, Fset_window_vscroll): No longer static.
1743 * textprop.c (Fprevious_property_change): No longer static.
1744 * syntax.c (Fsyntax_table_p): No longer static.
1745 * process.c (Fget_process, Fprocess_datagram_address): No longer
1746 static.
1747 * keymap.c (Flookup_key, Fcopy_keymap): No longer static.
1748 * keyboard.c (Fcommand_execute): No longer static.
1749 Remove EXFUN.
1750 * insdel.c (Fcombine_after_change_execute): No longer static.
1751 * image.c (Finit_image_library): No longer static.
1752 * fileio.c (Fmake_symbolic_link): No longer static.
1753 * eval.c (Ffetch_bytecode): No longer static.
1754 * editfns.c (Fuser_full_name): No longer static.
d209e2fb
JB
1755 * doc.c (Fdocumentation_property, Fsnarf_documentation):
1756 No longer static.
404dbd37
TT
1757 * buffer.c (Fset_buffer_major_mode, Fdelete_overlay): No longer
1758 static.
1759 * dired.c (Ffile_attributes): No longer static.
1760 * composite.c (Fcomposition_get_gstring): No longer static.
1761 * callproc.c (Fgetenv_internal): No longer static.
1762
1763 * ccl.h: Remove EXFUNs.
1764 * buffer.h: Remove EXFUNs.
1765 * dispextern.h: Remove EXFUNs.
1766 * intervals.h: Remove EXFUNs.
1767 * fontset.h: Remove EXFUN.
1768 * font.h: Remove EXFUNs.
1769 * dosfns.c (system_process_attributes): Remove EXFUN.
1770 * keymap.h: Remove EXFUNs.
1771 * lisp.h: Remove EXFUNs.
1772 * w32term.h: Remove EXFUNs.
1773 * window.h: Remove EXFUNs.
1774 * xsettings.h: Remove EXFUN.
1775 * xterm.h: Remove EXFUN.
1776
8e4fd1e1
GM
17772012-07-03 Glenn Morris <rgm@gnu.org>
1778
1779 * lisp.h (Frandom): Make it visible to C.
1780 * buffer.c (Fgenerate_new_buffer_name): Speed up finding a new
1781 buffer for invisible buffers. (Bug#1229)
1782
ca95b3eb
DA
17832012-07-03 Dmitry Antipov <dmantipov@yandex.ru>
1784
1785 Fix block vector allocation code to allow VECTOR_BLOCK_SIZE
1786 values which aren't power of 2.
1787 * alloc.c (VECTOR_FREE_LIST_SIZE_MASK): New macro. Verify
1788 it's value and the value of VECTOR_BLOCK_SIZE. Adjust users
1789 accordingly.
1790
7555c33f
SM
17912012-07-03 Stefan Monnier <monnier@iro.umontreal.ca>
1792
1793 * lisp.h (Lisp_Misc, Lisp_Fwd): Move around to group better.
1794
1795 * alloc.c (mark_object): Revert part of last patch to use `switch'.
1796
d12e8f5a
DA
17972012-07-03 Dmitry Antipov <dmantipov@yandex.ru>
1798
1799 * alloc.c (allocate_vector_block): Remove redundant
1800 calls to mallopt if DOUG_LEA_MALLOC is defined.
1801 (allocate_vectorlike): If DOUG_LEA_MALLOC is defined,
1802 avoid calls to mallopt if zero_vector is returned.
1803
296094c3
DA
18042012-07-03 Dmitry Antipov <dmantipov@yandex.ru>
1805
1806 * alloc.c (check_string_bytes): If GC_CHECK_STRING_BYTES
1807 is enabled, avoid dereferencing NULL current_sblock if
1808 running undumped.
1809
36429c89
DA
18102012-07-03 Dmitry Antipov <dmantipov@yandex.ru>
1811
1812 Cleanup basic buffer management.
1813 * buffer.h (struct buffer): Change layout to use generic vector
1814 marking code. Fix some comments. Change type of 'clip_changed'
1815 to bitfield. Remove unused #ifndef old.
1816 (FIRST_FIELD_PER_BUFFER, LAST_FIELD_PER_BUFFER): Remove.
1817 (GET_OVERLAYS_AT): Fix indentation.
1818 (for_each_per_buffer_object_at): New macro.
1819 * buffer.c (clone_per_buffer_values, reset_buffer_local_variables)
1820 (Fbuffer_local_variables): Use it.
1821 (init_buffer_once, syms_of_buffer): Remove unused #ifndef old.
1822 * alloc.c (allocate_buffer): Adjust to match new layout of
1823 struct buffer. Fix comment.
1824 (mark_overlay): New function.
1825 (mark_buffer): Use it. Use mark_vectorlike to mark normal
1826 Lisp area of struct buffer.
1827 (mark_object): Use it. Adjust marking of misc objects
1828 and related comments.
1829
3b3e4cac
PE
18302012-07-02 Paul Eggert <eggert@cs.ucla.edu>
1831
1832 * alloc.c (mark_object): Remove "#ifdef GC_CHECK_MARKED_OBJECTS"
1833 wrapper that is not needed because the wrapped code is a no-op (zero
1834 machine instructions) when GC_CHECK_MARKED_OBJECTS is not defined.
1835 This avoids a -Wunused-macros diagnostic with GCC 4.7.1 x86-64.
1836
cf5c0175
DA
18372012-07-02 Dmitry Antipov <dmantipov@yandex.ru>
1838
1839 * alloc.c (mark_buffer): Simplify. Remove prototype.
1840 (mark_object): Add comment. Reorganize marking of vector-like
faf611c7 1841 objects. Use CHECK_LIVE for all vector-like objects except buffers
cf5c0175
DA
1842 and subroutines when GC_CHECK_MARKED_OBJECTS is defined. Avoid
1843 redundant calls to mark_vectorlike for bool vectors.
1844
ca26824c
GM
18452012-06-30 Glenn Morris <rgm@gnu.org>
1846
2e4c5312
GM
1847 * nsterm.m (ns_init_paths): Ignore site-lisp if --no-site-lisp.
1848
ca26824c
GM
1849 * epaths.in (PATH_SITELOADSEARCH): New.
1850 * lread.c (init_lread): Use PATH_SITELOADSEARCH.
1851 This is rather than relying on --enable-locallisppath elements
1852 having "site-lisp" in their names. (Bug#10208#25, 11658)
1853
0d23c240
EZ
18542012-06-30 Eli Zaretskii <eliz@gnu.org>
1855
c9240d7a
EZ
1856 * w32proc.c (sys_select): Accept and ignore one more argument.
1857
1858 * w32.c (emacs_gnutls_pull): Call select with one more argument.
1859
0d23c240 1860 * sysselect.h [DOS_NT]: Don't include sys/select.h.
9ff8f76b 1861 (pselect) [!MS_DOS]: Redirect to sys_select.
0d23c240
EZ
1862
1863 * sysdep.c: Don't include dos.h and dosfns.h.
1864
1865 * process.c (sys_select):
1866 * msdos.c (sys_select): Accept one more argument and ignore it.
1867
1868 * msdos.c (event_timestamp, sys_select): Use gnulib's gettime;
1869 adapt data types and code to that.
1870
1871 * dosfns.c:
1872 * msdos.c (gettime, settime): Define away the prototypes in dos.h,
1873 which clashes with the gnulib function of the same name.
1874
af5a5a98
AS
18752012-06-30 Andreas Schwab <schwab@linux-m68k.org>
1876
c5e4379c
AS
1877 * font.c (font_style_to_value, font_style_symbolic)
1878 (font_prop_validate_style): Add type checks for values in
1879 font_style_table.
1880
af5a5a98
AS
1881 * lisp.h (CHECK_RANGED_INTEGER): Make value to check the first
1882 argument.
1883 * character.c, charset.c, menu.c, process.c, window.c: Adjust all
1884 uses.
1885
8d38f461
EZ
18862012-06-29 Eli Zaretskii <eliz@gnu.org>
1887
2e5a6631
EZ
1888 * xdisp.c (try_window_id): Undo last change.
1889
8d38f461
EZ
1890 * w32.c (getwd): Adjust commentary about startup_dir.
1891 (init_environment): Always call sys_access, even in non-MSVC
1892 builds. Don't chdir to the directory of the Emacs executable.
1893 This undoes code from 1997 which was justified by the need to
1894 "avoid conflicts when removing and renaming directories". But its
1895 downside was that every relative file name was being interpreted
1896 relative to the directory of the Emacs executable, which can never
1897 be TRT. In particular, it broke sys_access when called with
1898 relative file names.
1899 (sys_access): Map GetLastError to errno.
1900
2af3565e
DA
19012012-06-29 Dmitry Antipov <dmantipov@yandex.ru>
1902
1903 * window.h (struct window): Change type of 'fringes_outside_margins'
1904 to bitfield. Fix comment. Adjust users accordingly.
cf5c0175 1905 (struct window): Change type of 'window_end_bytepos' to ptrdiff_t.
2af3565e
DA
1906 Adjust comment.
1907 * xdisp.c (try_window_id): Change type of 'first_vpos' and 'vpos'
1908 to ptrdiff_t.
1909
c8d3a25c 19102012-06-29 Andreas Schwab <schwab@linux-m68k.org>
57570cd3 1911
c8d3a25c
GM
1912 * gnutls.c (emacs_gnutls_handshake):
1913 Add QUIT to make the loop interruptible.
57570cd3 1914
c8d3a25c 19152012-06-29 Glenn Morris <rgm@gnu.org>
d01fd55f 1916
c8d3a25c
GM
1917 * charset.c (init_charset): Make lack of etc/charsets fatal.
1918
3e984ee8
DA
19192012-06-29 Dmitry Antipov <dmantipov@yandex.ru>
1920
1921 * editfns.c (region_limit): Fix type mismatch.
1922
ef884f23
DA
19232012-06-29 Dmitry Antipov <dmantipov@yandex.ru>
1924
1925 * nsfns.m: Fix GLYPH_DEBUG usage assuming that it may be
1926 undefined. Convert from xassert to eassert.
1927 * nsmenu.m: Convert from xassert to eassert.
1928 * nsterm.m: Likewise.
1929
7d7e0027
SM
19302012-06-28 Stefan Monnier <monnier@iro.umontreal.ca>
1931
1932 * editfns.c (region_limit): Clip to narrowing (bug#11770).
1933
aa754e6a
PE
19342012-06-28 Paul Eggert <eggert@cs.ucla.edu>
1935
1936 Avoid integer overflow on scroll-left and scroll-right.
1937 * window.c (HSCROLL_MAX): New macro.
1938 (Fscroll_left, Fscroll_right): Avoid undefined behavior on integer
1939 overflow when requested scroll falls outside ptrdiff_t range.
1940
80b00b08
DA
19412012-06-28 Dmitry Antipov <dmantipov@yandex.ru>
1942
1943 * window.h (struct window): Change type of 'hscroll',
1944 'min_hscroll' and 'last_point' from Lisp_Object to ptrdiff_t,
1945 'last_modified' and 'last_overlay_modified' to EMACS_INT.
1946 Adjust users accordingly.
1947 * xdisp.c (try_cursor_movement): Replace type check with eassert.
1948 * window.c (Fscroll_left, Fscroll_right): Change type of 'hscroll'
1949 from EMACS_INT to ptrdiff_t.
1950 (make_window): Omit redundant initialization.
1951
62b2bcf6
JB
19522012-06-28 Juanma Barranquero <lekktu@gmail.com>
1953
1954 * makefile.w32-in ($(BLD)/regex.$(O)): Update dependencies.
1955
45942c7d
DA
19562012-06-28 Dmitry Antipov <dmantipov@yandex.ru>
1957
1958 * window.h (struct window): Change type of 'use_time' and
1959 'sequence_number' from Lisp_Object to int.
1960 * frame.c (make_frame): Adjust users accordingly.
1961 * print.c (print_object): Likewise.
1962 * window.c (select_window, Fwindow_use_time, make_parent_window)
1963 (make_window): Likewise.
1964
e509cfa6
DA
19652012-06-28 Dmitry Antipov <dmantipov@yandex.ru>
1966
1967 * dispextern.h (GLYPH_DEBUG): Now defined in config.h if
1968 enabled with --enable-checking=[all,glyphs] configure option.
1969 Fix GLYPH_DEBUG usage assuming that it may be undefined,
1970 adjust comments accordingly.
1971 * dispnew.c: Fix GLYPH_DEBUG usage assuming that it may be
1972 undefined, adjust comments accordingly.
1973 * image.c: Likewise.
1974 * scroll.c: Likewise.
1975 * w32fns.c: Likewise.
1976 * w32term.c: Likewise.
1977 * xdisp.c: Likewise.
1978 * xfaces.c: Likewise.
1979 * xfns.c: Likewise.
1980 * xterm.c: Likewise.
1981
a54e2c05
DA
19822012-06-28 Dmitry Antipov <dmantipov@yandex.ru>
1983
1984 Generalize run-time debugging checks.
1985 * dispextern.h (XASSERTS): Remove.
1986 * fontset.c (xassert): Remove.
1987 Convert from xassert to eassert.
1988 * alloc.c: Convert from xassert to eassert.
1989 * bidi.c: Likewise.
1990 * dispnew.c: Likewise.
1991 * fns.c: Likewise.
1992 * fringe.c: Likewise.
1993 * ftfont.c: Likewise.
1994 * gtkutil.c: Likewise.
1995 * image.c: Likewise.
1996 * keyboard.c: Likewise.
1997 * menu.c: Likewise.
1998 * process.c: Likewise.
1999 * scroll.c: Likewise.
2000 * sound.c: Likewise.
2001 * term.c: Likewise.
2002 * w32console.c: Likewise.
2003 * w32fns.c: Likewise.
2004 * w32term.c: Likewise.
2005 * window.c: Likewise.
2006 * xdisp.c: Likewise.
2007 * xfaces.c: Likewise.
2008 * xfns.c: Likewise.
2009 * xselect.c: Likewise.
2010 * xterm.c: Likewise.
2011
1ec4b7b2
SM
20122012-06-27 Stefan Monnier <monnier@iro.umontreal.ca>
2013
2014 * fns.c (maybe_resize_hash_table): Output message when growing the
2015 purify-hashtable.
2016
2014308a
DA
20172012-06-27 Dmitry Antipov <dmantipov@yandex.ru>
2018
2019 * alloc.c (allocate_string_data): Remove dead code.
2020 * xsettings.c (XSETTINGS_FONT_NAME): Move under HAVE_XFT to
2021 avoid GCC warning about unused macro.
2022
246155eb
DA
20232012-06-27 Dmitry Antipov <dmantipov@yandex.ru>
2024
2025 * alloc.c (allocate_string): Omit intervals initialization.
2026 * alloc.c (make_uninit_multibyte_string): Initialize intervals
2027 as in make_pure_string and make_pure_c_string.
2028
43184b7b
DA
20292012-06-27 Dmitry Antipov <dmantipov@yandex.ru>
2030
d209e2fb 2031 * alloc.c (allocate_string): Fix last change.
43184b7b 2032
3fe6dd74
DA
20332012-06-27 Dmitry Antipov <dmantipov@yandex.ru>
2034
d209e2fb 2035 * alloc.c (allocate_string): Remove two redundant calls
3fe6dd74
DA
2036 to memset, add explicit initialization where appropriate.
2037
1ba6038a
GM
20382012-06-27 Glenn Morris <rgm@gnu.org>
2039
2040 * lisp.mk (lisp): Remove paths.elc.
2041
c89926a5
CY
20422012-06-27 Chong Yidong <cyd@gnu.org>
2043
2044 * doc.c (Fsubstitute_command_keys): Fix punctuation.
2045
ed6b3510
JW
20462012-06-26 John Wiegley <johnw@newartisans.com>
2047
1ec4b7b2 2048 * unexmacosx.c (copy_data_segment): Add two section names used
157e99e4
JW
2049 on Mac OS X Lion: __mod_init_func and __mod_term_func.
2050
ed6b3510
JW
2051 * alloc.c (mark_memory): Do not check with -faddress-sanitizer
2052 when building with Clang.
2053
8edd4a2b
SM
20542012-06-26 Stefan Monnier <monnier@iro.umontreal.ca>
2055
2056 * eval.c (Fapply): Allow calling it with a single argument.
2057
f6f62d1b
EZ
20582012-06-26 Eli Zaretskii <eliz@gnu.org>
2059
2060 * s/ms-w32.h (strcasecmp, strncasecmp) [_MSC_VER]: Redirect to
2061 _stricmp and _strnicmp.
2062 (HAVE_STRCASECMP, HAVE_STRNCASECMP): Define to 1.
2063
62efea5e
DA
20642012-06-26 Dmitry Antipov <dmantipov@yandex.ru>
2065
2066 * alloc.c (allocate_window): Zero out non-Lisp part of newly
2067 allocated window.
2068 (allocate_process): Likewise for new process.
8edd4a2b 2069 (allocate_terminal): Change to use offsetof.
62efea5e
DA
2070 (allocate_frame): Likewise.
2071 * frame.c (make_frame): Omit redundant initialization.
2072 * window.c (make_parent_window): Use memset.
2073 (make_window): Omit redundant initialization.
2074 * process.c (make_process): Omit redundant initialization.
2075 * terminal.c (create_terminal): Likewise.
2076
42997f4d
DA
20772012-06-26 Dmitry Antipov <dmantipov@yandex.ru>
2078
2079 * term.c (delete_tty): Remove redundant call to memset.
2080
1130ecfc
DA
20812012-06-26 Dmitry Antipov <dmantipov@yandex.ru>
2082
2083 * alloc.c: Remove build_string.
2084 * lisp.h: Define build_string as static inline. This provides
2085 a better opportunity to optimize away calls to strlen when the
2086 function is called with compile-time constant argument.
2087 * image.c (imagemagick_error): Convert to build_string.
2088 * w32proc.c (sys_spawnve): Likewise.
2089 * xterm.c (x_term_init): Likewise.
2090
cf38a720
PE
20912012-06-26 Paul Eggert <eggert@cs.ucla.edu>
2092
99027bdd
PE
2093 Use sprintf return value instead of invoking strlen on result.
2094 In the old days this wasn't portable, since some sprintf
2095 implementations returned char *. But they died out years ago and
2096 Emacs already assumes sprintf returns int.
2097 Similarly for float_to_string.
2098 This patch speeds up (number-to-string 1000) by 3% on Fedora 15 x86-64.
2099 * ccl.c (ccl_driver):
2100 * character.c (string_escape_byte8):
2101 * data.c (Fnumber_to_string):
2102 * doprnt.c (doprnt):
2103 * print.c (print_object):
2104 * xdisp.c (message_dolog):
2105 * xfns.c (syms_of_xfns):
2106 Use sprintf or float_to_string result to avoid need to call strlen.
2107 * data.c (Fnumber_to_string):
2108 Use make_unibyte_string, since the string must be ASCII.
2109 * lisp.h, print.c (float_to_string): Now returns int length.
2110 * term.c (produce_glyphless_glyph):
2111 Use sprintf result rather than recomputing it.
2112
cf38a720
PE
2113 Clean out last vestiges of the old HAVE_CONFIG_H stuff.
2114 * Makefile.in (ALL_CFLAGS):
2115 * makefile.w32-in (LOCAL_FLAGS): Remove -DHAVE_CONFIG_H.
2116 * gmalloc.c, regex.c: Include <config.h> unconditionally.
2117
3511c784
DA
21182012-06-25 Dmitry Antipov <dmantipov@yandex.ru>
2119
0a08eb21 2120 * dispextern.h (xstrcasecmp): Define to library function
3511c784
DA
2121 strcasecmp if available.
2122 * xfaces.c: Do not use xstrcasecmp if strcasecmp is available.
2123
fb7da12e
AS
21242012-06-25 Andreas Schwab <schwab@linux-m68k.org>
2125
2126 * keyboard.c (menu_bar_items, menu_bar_item, read_key_sequence):
2127 Avoid comma operator.
2128 * menu.c (push_submenu_start, push_submenu_end)
2129 (push_left_right_boundary, push_menu_pane): Likewise.
2130 * msdos.c (dos_rawgetc): Likewise.
2131
afa2ffd8
DA
21322012-06-25 Dmitry Antipov <dmantipov@yandex.ru>
2133
2134 * xfns.c (xic_create_fontsetname): Remove redundant calls
2135 to memset.
2136
b3b4476b
PE
21372012-06-25 Paul Eggert <eggert@cs.ucla.edu>
2138
4495ff38
PE
2139 * gtkutil.c (get_utf8_string): Remove redundant assignment.
2140 sprintf already null-terminates its output.
2141
b3b4476b
PE
2142 * xfns.c (x_window): Remove redundant cast.
2143
b00876c9
DA
21442012-06-25 Dmitry Antipov <dmantipov@yandex.ru>
2145
2146 * xmenu.c (xmenu_show, xdialog_show): Explicit cast from
2147 `const char *' to `char *' to avoid compiler warning.
2148
d188e26b
PE
21492012-06-24 Paul Eggert <eggert@cs.ucla.edu>
2150
885d1d74
PE
2151 * xterm.c (x_term_init): Build proper-sized _XSETTINGS_Snnn string
2152 instead of truncating it to 63 (admittedly a generous limit).
2153
d188e26b
PE
2154 * process.c: Fix spelling and caps in comments.
2155
e2f560b1
DN
21562012-06-24 Dan Nicolaescu <dann@ics.uci.edu>
2157
e86db54b 2158 * emacs.c (setpgrp): Remove definition, unused.
e2f560b1
DN
2159 * sysdep.c (setpgrp): Remove definition, not used in this file.
2160
7583a3a1
JB
21612012-06-24 Juanma Barranquero <lekktu@gmail.com>
2162
2163 * makefile.w32-in: Update dependencies.
2164
696056c2
EZ
21652012-06-24 Eli Zaretskii <eliz@gnu.org>
2166
2167 * makefile.w32-in (TIMESPEC_H): Remove nt/inc/sys/time.h.
2168 (SYSTIME_H): Add nt/inc/sys/time.h.
2169
2170 * systime.h [WINDOWSNT]: Include sys/time.h.
2171
2172 * s/ms-w32.h (struct timespec): Definition moved from
2173 nt/inc/sys/time.h. Suggested by Paul Eggert <eggert@cs.ucla.edu>.
2174
845ca893
PE
21752012-06-24 Paul Eggert <eggert@cs.ucla.edu>
2176
2177 Switch from NO_RETURN to C11's _Noreturn (Bug#11750).
2178 * buffer.h (buffer_slot_type_mismatch):
2179 * data.c (arith_error) [!FORWARD_SIGNAL_TO_MAIN_THREAD]:
2180 * eval.c (unwind_to_catch):
2181 * image.c (my_png_error, my_error_exit):
2182 * keyboard.c (quit_throw_to_read_char, user_error)
2183 (Fexit_recursive_edit, Fabort_recursive_edit):
2184 * lisp.h (die, args_out_of_range, args_out_of_range_3)
2185 (wrong_type_argument, buffer_overflow, __executable_start)
2186 (memory_full, buffer_memory_full, string_overflow, Fthrow)
2187 (xsignal, xsignal0, xsignal1, xsignal2, xsignal3, signal_error)
2188 (error, verror, nsberror, report_file_error, Ftop_level, Fkill_emacs)
2189 (fatal):
2190 (child_setup) [!DOS_NT]:
2191 * lread.c (end_of_file_error, invalid_syntax):
2192 * process.c (send_process_trap) [!FORWARD_SIGNAL_TO_MAIN_THREAD]:
2193 * puresize.h (pure_write_error):
2194 * search.c (matcher_overflow):
2195 * sound.c (sound_perror, alsa_sound_perror):
2196 * sysdep.c, syssignal.h (croak):
2197 * term.c (maybe_fatal, vfatal):
2198 * textprop.c (text_read_only):
2199 * undo.c (user_error):
2200 * unexmacosx.c (unexec_error):
2201 * xterm.c (x_ins_del_lines, x_delete_glyphs):
2202 Use _Noreturn rather than NO_RETURN.
2203 No need for separate decl merely because of _Noreturn.
2204 * sound.c (sound_warning, parse_sound):
2205 Remove unnecessary forward decls.
2206
f1dd8073
PE
22072012-06-24 Paul Eggert <eggert@cs.ucla.edu>
2208
2209 Fix bug when time_t is unsigned and as wide as intmax_t (Bug#9000).
2210 * lisp.h (WAIT_READING_MAX): New macro.
2211 * dispnew.c (Fsleep_for, sit_for):
2212 * keyboard.c (kbd_buffer_get_event):
2213 * process.c (Faccept_process_output):
2214 Use it to avoid bogus compiler warnings with obsolescent GCC versions.
2215 This improves on the previous patch, which introduced a bug
2216 when time_t is unsigned and as wide as intmax_t.
2217 See <http://bugs.gnu.org/9000#51>.
2218
b82c1755
EZ
22192012-06-23 Eli Zaretskii <eliz@gnu.org>
2220
2221 * dispnew.c (sit_for, Fsleep_for):
2222 * keyboard.c (kbd_buffer_get_event):
2223 * process.c (Faccept_process_output): Avoid compiler warnings when
2224 comparing a 32-bit time_t with a 64-bit INTMAX_MAX.
2225
ca300656
JB
22262012-06-23 Juanma Barranquero <lekktu@gmail.com>
2227
049ec95b
JB
2228 * makefile.w32-in: Update dependencies.
2229
ca300656
JB
2230 * w32.c (ltime): Add return type and declare static.
2231 (w32_get_internal_run_time): Remove usused variable `time_100ns'.
2232
db7b8d06
PE
22332012-06-23 Paul Eggert <eggert@cs.ucla.edu>
2234
2235 * sysdep.c [__FreeBSD__]: Fix more recently-introduced typos.
2236 Privately reported by Herbert J. Skuhra.
2237 (make_lisp_timeval) [__FreeBSD__]: Rename from TIMELIST.
2238 All uses changed.
2239 (system_process_attributes) [__FreeBSD__]: Invoke make_lisp_time,
2240 not make_lisp_timeval, when the argument is of type EMACS_TIME.
2241
0bd8297f
EZ
22422012-06-23 Eli Zaretskii <eliz@gnu.org>
2243
96512555
EZ
2244 * w32proc.c (Fw32_get_locale_info): Fix an off-by-one error in
2245 last argument of make_unibyte_string.
2246
0bd8297f
EZ
2247 * keyboard.c (kbd_buffer_get_event): Include the codepage and the
2248 language ID in the event parameters.
2249
2250 * w32term.c (w32_read_socket): Put the new keyboard codepage into
2251 event.code, not the obscure "character set ID".
2252
63def6b6
CY
22532012-06-23 Chong Yidong <cyd@gnu.org>
2254
2255 * xmenu.c (x_menu_wait_for_event): Adapt GTK3 to new xg_select.
2256
e8a02204
EZ
22572012-06-23 Eli Zaretskii <eliz@gnu.org>
2258
388cdec0
EZ
2259 Fix the MS-Windows build broken by 2012-06-22T21:17:42Z!eggert@cs.ucla.edu.
2260 * w32.c (fdutimens): New function.
2261
2262 * w32proc.c (sys_select): Adapt to change in the EMACS_TIME type.
2263
2264 * s/ms-w32.h (pselect): Redirect to sys_select.
2265
2266 * sysselect.h [WINDOWSNT]: Don't include sys/select.h.
2267
e8a02204
EZ
2268 * ralloc.c (r_alloc_inhibit_buffer_relocation): Fix stupid thinko
2269 in the logic of incrementing and decrementing the value of
2270 use_relocatable_buffers.
2271
d054f3fb
PE
22722012-06-23 Paul Eggert <eggert@cs.ucla.edu>
2273
2274 * sysdep.c [__FreeBSD__]: Fix recently-introduced typos.
2275 Privately reported by Herbert J. Skuhra.
2276 [__FreeBSD__]: Remove "*/" typo after "#include".
2277 (timeval_to_EMACS_TIME) [__FreeBSD__]: New static function.
2278 (TIMEVAL) [__FreeBSD__]: Now a static function rather than a macro.
2279 (TIMEVAL, system_process_attributes) [__FreeBSD__]:
2280 Don't assume EMACS_TIME and struct timeval are the same type.
2281
d35af63c
PE
22822012-06-22 Paul Eggert <eggert@cs.ucla.edu>
2283
2284 Support higher-resolution time stamps (Bug#9000).
2285 The time stamps are only nanosecond-resolution at the C level,
2286 since that's the best that any real-world system supports now.
2287 But they are picosecond-resolution at the Lisp level, as that's
2288 easy, and leaves room for future OS improvements.
2289
2290 * Makefile.in (LIB_CLOCK_GETTIME): New macro.
2291 (LIBES): Use it.
2292
2293 * alloc.c (Fgarbage_collect): Port to higher-res time stamps.
2294 Don't get current time unless it's needed.
2295
2296 * atimer.c: Include <sys/time.h> unconditionally, since gnulib
2297 now provides it if it's absent.
2298 (start_atimer): Port to higher-res time stamps.
2299 Check for time stamp overflow. Don't get current time more
2300 often than is needed.
2301
2302 * buffer.h (struct buffer): Buffer modtime now has high resolution.
2303 Include systime.h, not time.h.
2304 (NONEXISTENT_MODTIME_NSECS, UNKNOWN_MODTIME_NSECS): New macros.
2305
2306 * dired.c: Include stat-time.h.
2307 (Ffile-attributes): File times now have higher resolution.
2308
2309 * dispextern.h [HAVE_WINDOW_SYSTEM]: Include systime.h.
2310 (struct image): Timestamp now has higher resolution.
2311
2312 * dispnew.c (PERIODIC_PREEMPTION_CHECKING): Remove, as Emacs always
2313 has at least microseconds now. All uses removed.
2314 (update_frame, update_single_window, update_window, update_frame_1)
2315 (Fsleep_for, sit_for): Port to higher-resolution time stamps.
2316
2317 * editfns.c (time_overflow): Now extern.
2318 (Fcurrent_time, Fget_internal_run_time, make_time, lisp_time_argument)
2319 (float-time, Fformat_time_string, Fcurrent_time_string)
2320 (Fcurrent_time_zone): Accept and generate higher-resolution
2321 time stamps.
2322 (make_time_tail, make_lisp_time, dissassemble_lisp_time)
2323 (decode_time_components, lisp_seconds_argument): New functions.
2324 (make_time): Now static.
2325 (lisp_time_argument): Now returns EMACS_TIME. New arg ppsec.
2326 Report an error if the time is invalid, rather than having the caller
2327 do that.
2328
2329 * fileio.c: Include <stat-time.h>
2330 (Fcopy_file): Copy higher-resolution time stamps.
2331 Prefer to set the time stamp via a file descriptor if that works.
2332 (Fset_file_times, Finsert_file_contents, Fwrite_region)
2333 (Fverify_visited_file_modtime, Fclear_visited_file_modtime)
2334 (Fvisited_file_modtime, Fset_visited_file_modtime):
2335 Support higher-resolution time stamps.
2336
2337 * fns.c (Frandom): Use nanoseconds, not microseconds, for seed.
2338
2339 * gtkutil.c (xg_maybe_add_timer): Port to higher-res time stamps.
2340
2341 * image.c (prepare_image_for_display, clear_image_cache)
2342 (lookup_image): Port to higer-resolution time stamps.
2343
2344 * keyboard.c (start_polling, bind_polling_period):
2345 Check for time stamp overflow.
2346 (read_char, kbd_buffer_get_event, timer_start_idle)
2347 (timer_stop_idle, timer_resume_idle, timer_check_2, timer_check)
2348 (Fcurrent_idle_time, init_keyboard, set_waiting_for_input):
2349 Port to higher-resolution time stamps. Do not assume time_t is signed.
2350 (decode_timer): New function. Timers are now vectors of length 9,
2351 not 8, to accommodate the picosecond component.
2352 (timer_check_2): Use it.
2353
2354 * nsterm.m (select_timeout, timeval_subtract): Remove.
2355 (ns_timeout): Use Emacs's facilities for time stamp arithmetic,
2356 as they're a bit more accurate and handle overflow better.
2357 (ns_select): Change prototype to be compatible with pselect.
2358 (ns_select, ns_term_shutdown): Port to ns-resolution time stamps.
2359 * nsterm.h (ns_select): Adjust prototype.
2360
2361 * msdos.c (EMACS_TIME_ZERO_OR_NEG_P): Remove, as it assumes
2362 us-resolution time stamps.
2363 (sys_select): Use the new EMACS_TIME_SIGN macro instead.
2364
2365 * lread.c (read_filtered_event): Port to ns-resolution time stamps.
2366
2367 * lisp.h (time_overflow): New decl.
2368 (wait_reading_process_output): First arg is now intmax_t, not int,
2369 to accommodate larger waits.
2370
2371 * process.h (struct Lisp_Process.read_output_delay):
2372 Now counts nanoseconds, not microseconds.
2373 * process.c (ADAPTIVE_READ_BUFFERING): Don't worry about
2374 EMACS_HAS_USECS.
2375 (READ_OUTPUT_DELAY_INCREMENT, Faccept_process_output)
2376 (wait_reading_process_output):
2377 Port to ns-resolution time stamps.
2378 (Faccept_process_output, wait_reading_process_output):
2379 Check for time stamp overflow. Do not assume time_t is signed.
2380 (select_wrapper): Remove; we now use pselect.
2381 (Fprocess_attributes): Now generates ns-resolution time stamps.
2382
2383 * sysdep.c: Include utimens.h. Don't include utime.h
2384 or worry about struct utimbuf; gnulib does that for us now.
2385 (gettimeofday): Remove; gnulib provides a substitute.
2386 (make_timeval): New function.
2387 (set_file_times): Now sets ns-resolution time stamps.
2388 New arg FD; all uses changed.
2389 (time_from_jiffies, ltime_from_jiffies, get_up_time)
2390 (system_process_attributes):
2391 Now returns ns-resolution time stamp. All uses changed.
2392 Check for time stamp overflow.
2393
2394 * sysselect.h: Don't depend on HAVE_SYS_SELECT_H; gnulib
2395 provides a substitute now.
2396
2397 * systime.h: Include timespec.h rather than sys/time.h and time.h,
2398 since it guarantees struct timespec.
2399 (EMACS_TIME): Now struct timespec, so that we can support
2400 ns-resolution time stamps.
2401 (EMACS_TIME_RESOLUTION, LOG10_EMACS_TIME_RESOLUTION): New macros.
2402 (EMACS_HAS_USECS): Remove; Emacs always has sub-second time stamps now.
2403 (EMACS_USECS): Remove.
2404 (EMACS_SET_USECS): The underlying time stamp now has ns resolution,
2405 so multiply the arg by 1000 before storing it.
2406 (EMACS_NSECS, EMACS_SECS_ADDR, EMACS_SET_NSECS, EMACS_SET_SECS_NSECS):
2407 New macros.
2408 (EMACS_GET_TIME, EMACS_ADD_TIME, EMACS_SUB_TIME):
2409 Port to ns-resolution time stamps.
2410 (EMACS_TIME_NEG_P): Remove; replaced by....
2411 (EMACS_TIME_SIGN): New macro.
2412 (EMACS_SET_INVALID_TIME, EMACS_TIME_VALID_P)
2413 (EMACS_TIME_FROM_DOUBLE, EMACS_TIME_TO_DOUBLE): New macros.
2414 (set_file_times, make_time, lisp_time_argument): Adjust signature.
2415 (make_timeval, make_lisp_time, decode_time_components): New decls.
2416 (EMACS_TIME_CMP): Remove; no longer used. Plus, it was buggy, in
2417 that it mishandled time_t overflow. You can't compare by subtracting!
2418 (EMACS_TIME_EQ, EMACS_TIME_NE, EMACS_TIME_GT, EMACS_TIME_GE)
2419 (EMACS_TIME_LT, EMACS_TIME_LE): Rewrite in terms of timespec_cmp.
2420
2421 * term.c: Include <sys/time.h>.
2422 (timeval_to_Time): New function, for proper overflow wraparound.
2423 (term_mouse_position, term_mouse_click): Use it.
2424
2425 * undo.c (record_first_change): Support higher-resolution time stamps
2426 in the undo buffer.
2427 (Fprimitive_undo): Use them when restoring time stamps.
2428
2429 * w32.c (ltime, U64_TO_LISP_TIME, process_times, emacs_gnutls_pull)
2430 (w32_get_internal_run_time):
2431 Port to higher-resolution Emacs time stamps.
2432 (ltime): Now accepts single 64-bit integer, as that's more convenient
2433 for callers.
2434
2435 * xdisp.c (start_hourglass): Port to ns-resolution time stamps.
2436
2437 * xgselect.c, xgselect.h (xg_select): Add sigmask argument,
2438 for compatibility with pselect. Support ns-resolution time stamps.
2439
2440 * xmenu.c (x_menu_wait_for_event): Support ns-resolution time stamps.
2441
2442 * xselect.c (wait_for_property_change, x_get_foreign_selection):
2443 Check for time stamp overflow, and support ns-resolution time stamps.
2444
2445 * xterm.c: Don't include sys/time.h; gnulib does that for us now.
2446 Don't worry about whether HAVE_TIMEVAL and HAVE_SELECT are set.
2447 (timeval_subtract): Remove; no longer needed.
2448 (XTflash, XTring_bell, x_wait_for_event):
2449 Port to ns-resolution time stamps. Don't assume time_t is signed.
2450
b6a92dfe
CY
24512012-06-22 Chong Yidong <cyd@gnu.org>
2452
2453 * xdisp.c (x_consider_frame_title): Revert last change.
2454
d251c37c
EZ
24552012-06-22 Eli Zaretskii <eliz@gnu.org>
2456
2457 * alloc.c (NSTATICS): Enlarge to 0x650. Otherwise, Emacs compiled
2458 with -DENABLE_CHECKING -DXASSERTS -DGLYPH_DEBUG=1 -DBYTE_CODE_METER
2459 aborts in staticpro during startup. (Without -DBYTE_CODE_METER,
2460 staticidx goes up to 1597 out of 1600 = 0x640.)
2461
f10deafb
PE
24622012-06-20 Paul Eggert <eggert@cs.ucla.edu>
2463
2464 * fileio.c (Fdefault_file_modes): Block input while fiddling with umask.
2465 Otherwise, the umask might be mistakenly 0 while handling input signals.
2466
ec6de1e2
SM
24672012-06-19 Stefan Monnier <monnier@iro.umontreal.ca>
2468
2469 * minibuf.c (Fread_string): Bind minibuffer-completion-table.
2470
28be1ada
DA
24712012-06-19 Dmitry Antipov <dmantipov@yandex.ru>
2472
2473 * alloc.c, bytecode.c, ccl.c, coding.c, composite.c, data.c, dosfns.c:
2474 * font.c, image.c, keyboard.c, lread.c, menu.c, minibuf.c, msdos.c:
2475 * print.c, syntax.c, window.c, xmenu.c, xselect.c: Replace direct
2476 access to `contents' member of Lisp_Vector objects with AREF and ASET
2477 where appropriate.
2478
c6bf3022
CY
24792012-06-19 Chong Yidong <cyd@gnu.org>
2480
2481 * frame.c (delete_frame): When selecting a frame on a different
2482 text terminal, do not alter the terminal's top-frame.
2483
2484 * xdisp.c (format_mode_line_unwind_data): Record the target
2485 frame's selected window and its terminal's top-frame.
2486 (unwind_format_mode_line): Restore them.
2487 (x_consider_frame_title, display_mode_line, Fformat_mode_line):
2488 Callers changed.
2489 (x_consider_frame_title): Do not condition on HAVE_WINDOW_SYSTEM,
2490 since tty frames can be explicitly named.
2491 (prepare_menu_bars): Likewise.
2492
2493 * term.c (Ftty_top_frame): New function.
2494
defd4196
PE
24952012-06-18 Paul Eggert <eggert@cs.ucla.edu>
2496
2497 Port byte-code-meter to modern targets.
2498 * bytecode.c (METER_CODE) [BYTE_CODE_METER]: Don't assume
2499 !CHECK_LISP_OBJECT_TYPE && !USE_LSB_TAG. Problem with
8b5257e1 2500 CHECK_LISP_OBJECT_TYPE reported by Dmitry Antipov in
defd4196
PE
2501 <http://lists.gnu.org/archive/html/emacs-devel/2012-06/msg00282.html>.
2502 (METER_1, METER_2): Simplify.
2503
1053a871
SM
25042012-06-18 Stefan Monnier <monnier@iro.umontreal.ca>
2505
2506 * data.c (Fdefalias): Return `symbol' (bug#11686).
2507
b7e8d081
MR
25082012-06-18 Martin Rudalics <rudalics@gmx.at>
2509
2510 * buffer.c (Fkill_buffer): Don't throw an error when the buffer
1053a871
SM
2511 gets killed during executing of this function (Bug#11665).
2512 Try to always return Qt when the buffer has been actually killed.
b7e8d081
MR
2513 (Vkill_buffer_query_functions): In doc-string say that functions
2514 run by this hook should not change the current buffer.
2515
7ea2b339
PE
25162012-06-18 Paul Eggert <eggert@cs.ucla.edu>
2517
2518 Fix recently-introduced process.c problems found by static checking.
2519 * process.c (write_queue_push, write_queue_pop, send_process):
2520 Use ptrdiff_t, not int or EMACS_INT, for buffer lengths and offsets.
2521 (write_queue_pop): Fix pointer signedness problem.
2522 (send_process): Remove unused local.
2523
96a313a1
CY
25242012-06-17 Chong Yidong <cyd@gnu.org>
2525
2526 * xdisp.c (redisplay_internal): No need to redisplay terminal
2527 frames that are not on top.
2528
20ca2e94
TN
25292012-06-17 Troels Nielsen <bn.troels@gmail.com>
2530
2531 * process.c (make_process): Initialize write_queue.
2532 (write_queue_push, write_queue_pop): New functions.
2533 (send_process): Use them to maintain correct ordering of process
2534 writes (Bug#10815).
2535
9a900ca9
PE
25362012-06-17 Paul Eggert <eggert@cs.ucla.edu>
2537
310fbfa8
PE
2538 * lisp.h (eassert): Assume C89 or later.
2539 This removes the need for CHECK.
2540 (CHECK): Remove. Its comments about always evaluating its
2541 argument were confusing, as 'eassert' typically does not evaluate
2542 its argument.
2543
27bb1ca4
PE
2544 * coding.c (produce_chars): Use ptrdiff_t, not int.
2545
9a900ca9
PE
2546 * xterm.c (x_draw_underwave): Check for integer overflow.
2547 This pacifies gcc 4.7.0 -Wunsafe-loop-optimizations on x86-64.
2548
41b7f8bc 25492012-06-17 Jan Djärv <jan.h.d@swipnet.se>
50a93863
JD
2550
2551 * nsterm.m (x_free_frame_resources): Move xfree so freed memory isn't
2552 referenced (Bug#11583).
2553
9b0e3eba
AA
25542012-06-16 Aurelien Aptel <aurelien.aptel@gmail.com>
2555
2556 Implement wave-style variant of underlining.
2557 * dispextern.h (face_underline_type): New enum.
2558 (face): Add field for underline type.
2559 * nsterm.m (ns_draw_underwave): New function.
2560 (ns_draw_text_decoration): Use it.
2561 * w32term.c (w32_restore_glyph_string_clip, w32_draw_underwave):
2562 New functions.
2563 (x_draw_glyph_string): Use them.
2564 * xfaces.c (Qline, Qwave): New Lisp objects.
2565 (check_lface_attrs, merge_face_ref)
1053a871
SM
2566 (Finternal_set_lisp_face_attribute, realize_x_face):
2567 Handle wave-style underline face attributes.
9b0e3eba
AA
2568 * xterm.c (x_draw_underwave): New function.
2569 (x_draw_glyph_string): Use it.
2570
0fb52f11
JB
25712012-06-16 Juanma Barranquero <lekktu@gmail.com>
2572
2573 * makefile.w32-in ($(BLD)/emacs.$(O), $(BLD)/fringe.$(O))
2574 ($(BLD)/xml.$(O), $(BLD)/intervals.$(O), $(BLD)/macros.$(O))
2575 ($(BLD)/minibuf.$(O), $(BLD)/regex.$(O), $(BLD)/region-cache.$(O))
2576 ($(BLD)/textprop.$(O), $(BLD)/undo.$(O), $(BLD)/window.$(O))
2577 ($(BLD)/w32select.$(O)): Update dependencies.
2578
e5560ff7
AS
25792012-06-16 Andreas Schwab <schwab@linux-m68k.org>
2580
2581 * buffer.h (FETCH_MULTIBYTE_CHAR): Define as inline.
2582 (BUF_FETCH_MULTIBYTE_CHAR): Likewise.
2583 * character.c (_fetch_multibyte_char_p): Remove.
2584 * alloc.c: Include "character.h" before "buffer.h".
2585 * bidi.c: Likewise.
2586 * buffer.c: Likewise.
2587 * bytecode.c: Likewise.
2588 * callint.c: Likewise.
2589 * callproc.c: Likewise.
2590 * casefiddle.c: Likewise.
2591 * casetab.c: Likewise.
2592 * category.c: Likewise.
2593 * cmds.c: Likewise.
2594 * coding.c: Likewise.
2595 * composite.c: Likewise.
2596 * dired.c: Likewise.
2597 * dispnew.c: Likewise.
2598 * doc.c: Likewise.
2599 * dosfns.c: Likewise.
2600 * editfns.c: Likewise.
2601 * emacs.c: Likewise.
2602 * fileio.c: Likewise.
2603 * filelock.c: Likewise.
2604 * font.c: Likewise.
2605 * fontset.c: Likewise.
2606 * fringe.c: Likewise.
2607 * indent.c: Likewise.
2608 * insdel.c: Likewise.
2609 * intervals.c: Likewise.
2610 * keyboard.c: Likewise.
2611 * keymap.c: Likewise.
2612 * lread.c: Likewise.
2613 * macros.c: Likewise.
2614 * marker.c: Likewise.
2615 * minibuf.c: Likewise.
2616 * nsfns.m: Likewise.
2617 * nsmenu.m: Likewise.
2618 * print.c: Likewise.
2619 * process.c: Likewise.
2620 * regex.c: Likewise.
2621 * region-cache.c: Likewise.
2622 * search.c: Likewise.
2623 * syntax.c: Likewise.
2624 * term.c: Likewise.
2625 * textprop.c: Likewise.
2626 * undo.c: Likewise.
2627 * unexsol.c: Likewise.
2628 * w16select.c: Likewise.
2629 * w32fns.c: Likewise.
2630 * w32menu.c: Likewise.
2631 * window.c: Likewise.
2632 * xdisp.c: Likewise.
2633 * xfns.c: Likewise.
2634 * xmenu.c: Likewise.
2635 * xml.c: Likewise.
2636 * xselect.c: Likewise.
2637
2f07e6af
EZ
26382012-06-16 Eli Zaretskii <eliz@gnu.org>
2639
1053a871
SM
2640 * xdisp.c (set_cursor_from_row): Don't dereference glyphs_end.
2641 If all the glyphs of the glyph row came from strings, and we have no
2f07e6af 2642 cursor positioning clues, put the cursor on the first glyph of the
1097afe4
EZ
2643 row.
2644 (handle_face_prop): Use chunk-relative overlay string index when
2645 indexing into it->string_overlays array. (Bug#11653)
946fdb73
EZ
2646 (set_cursor_from_row): Use the leftmost glyph as GLYPH_BEFORE, not
2647 the rightmost. (Bug#11720)
2f07e6af 2648
29b83cec
AS
26492012-06-16 Andreas Schwab <schwab@linux-m68k.org>
2650
2651 * category.h (CHAR_HAS_CATEGORY): Define as inline.
2652 (CATEGORY_MEMBER): Enforce 1/0 value.
2653 * category.c (_temp_category_set): Remove.
2654
4c5501e9
EZ
26552012-06-16 Eli Zaretskii <eliz@gnu.org>
2656
2657 * window.c (Fdelete_other_windows_internal)
2658 (Fdelete_window_internal): Don't access frame's mouse highlight
2659 info of the initial frame. (Bug#11677)
2660
2b570124
PE
26612012-06-14 Paul Eggert <eggert@cs.ucla.edu>
2662
e93864f9
PE
2663 * .gdbinit (xgetint): Fix recently-introduced paren typo.
2664 Assume USE_2_TAGS_FOR_INTS.
2665 (xreload): Adjust $tagmask width to match recent lisp.h change.
2666
2b570124
PE
2667 Simplify lisp.h in minor ways that should not affect code.
2668 * lisp.h (USE_2_TAGS_FOR_INTS): Remove, as it was always defined.
2669 (LISP_INT_TAG, case_Lisp_Int, LISP_STRING_TAG, LISP_INT_TAG_P)
2670 (LISP_INT1_TAG, enum Lisp_Type, XINT, XUINT, make_number):
2671 Simplify under the assumption that USE_2_TAGS_FOR_INTS is defined.
2672 (INTTYPEBITS): New macro, for clarity.
2673 (INTMASK, MOST_POSITIVE_FIXNUM): Use it.
1053a871
SM
2674 (LISP_INT1_TAG, LISP_STRING_TAG, LISP_INT_TAG_P):
2675 Simplify now that USE_LSB_TAG is always defined.
2b570124
PE
2676 (TYPEMASK, XINT) [USE_LSB_TAG]: Remove unnecessary cast.
2677 (make_number) [!USE_LSB_TAG]: Use INTMASK; that's simpler.
2678
81755f69
JB
26792012-06-13 Juanma Barranquero <lekktu@gmail.com>
2680
2681 * makefile.w32-in ($(BLD)/data.$(O)): Update dependencies.
2682
16192a57
GM
26832012-06-13 Glenn Morris <rgm@gnu.org>
2684
2685 * s/bsd-common.h (BSD4_3):
2686 * s/usg5-4-common.h (USG5_4): No longer define; unused.
2687
646b5f55
AS
26882012-06-13 Andreas Schwab <schwab@linux-m68k.org>
2689
2690 * lisp.h (Lisp_Object) [CHECK_LISP_OBJECT_TYPE]: Define as struct
2691 instead of union.
2692 (XLI, XIL): Define.
1053a871
SM
2693 (XHASH, XTYPE, XINT, XUINT, make_number, XSET, XPNTR, XUNTAG):
2694 Use them.
2695 * emacs.c (gdb_use_struct): Rename from gdb_use_union.
646b5f55 2696 * .gdbinit: Check gdb_use_struct instead of gdb_use_union.
1053a871 2697 * alloc.c (widen_to_Lisp_Object): Remove.
646b5f55
AS
2698 (mark_memory): Use XIL instead of widen_to_Lisp_Object.
2699 * frame.c (delete_frame): Remove outdated comment.
2700 * w32fns.c (Fw32_register_hot_key): Use XLI instead of checking
2701 USE_LISP_UNION_TYPE.
2702 (Fw32_unregister_hot_key): Likewise.
2703 (Fw32_toggle_lock_key): Likewise.
2704 * w32menu.c (add_menu_item): Likewise.
2705 (w32_menu_display_help): Use XIL instead of checking
2706 USE_LISP_UNION_TYPE.
2707 * w32heap.c (allocate_heap): Don't check USE_LISP_UNION_TYPE.
2708 (init_heap): Likewise.
2709 * w32term.c (w32_read_socket): Update comment.
2710
1d3823c9
GM
27112012-06-13 Glenn Morris <rgm@gnu.org>
2712
c62ff706
GM
2713 * s/usg5-4-common.h, src/s/unixware.h:
2714 Remove define/undef of HAVE_SYSV_SIGPAUSE (not used since 2010-05-04).
2715
1d3823c9
GM
2716 * s/gnu.h (POSIX_SIGNALS): Remove (not used since 2010-05-04).
2717
bfe3e0a2
PE
27182012-06-13 Paul Eggert <eggert@cs.ucla.edu>
2719
2720 USE_LISP_UNION_TYPE + USE_LSB_TAG cleanup (Bug#11604)
2721 * alloc.c (make_number) [!defined make_number]:
2722 Remove, as lisp.h always defines this now.
2723 (mark_maybe_pointer): Simplify since USE_LSB_TAG is always defined now.
2724 (roundup_size): Verify that it is a power of 2.
2725 * data.c (Fmake_variable_buffer_local, Fmake_local_variable):
2726 * ftfont.c (ftfont_driver): Use LISP_INITIALLY_ZERO.
2727 * lisp.h (USE_LSB_TAG): Allow the builder to compile with
2728 -DUSE_LSB_TAG=0, to override the automatically-selected default.
2729 USE_LSB_TAG now is always defined to be either 0 or 1.
2730 All uses changed.
2731 (union Lisp_Object): Don't worry about WORDS_BIGENDIAN; the
2732 code works fine either way, and efficiency is not a concern here,
2733 as the union type is for debugging, not for production.
2734 (LISP_MAKE_RVALUE, make_number) [USE_LISP_UNION_TYPE]:
2735 Use an inline function on all platforms when using the union type,
2736 since this is simpler and 'static inline' can be used portably
2737 within Emacs now.
2738 (LISP_INITIALLY_ZERO): New macro.
2739 (XFASTINT, XSETFASTINT) [USE_LISP_UNION_TYPE]: Remove.
2740 (XSET) [USE_LISP_UNION_TYPE]: Don't overparenthesize.
2741
45fa9c0f
GM
27422012-06-12 Glenn Morris <rgm@gnu.org>
2743
b4492cba
GM
2744 * s/gnu-kfreebsd.h, s/hpux11.h, s/openbsd.h, s/sol2-10.h: Remove files.
2745
2746 * s/gnu-linux.h (HAVE_PROCFS): Move to configure.
0d369729 2747
45fa9c0f
GM
2748 * s/hpux10-20.h, s/openbsd.h, s/usg5-4-common.h:
2749 Move BROKEN_SIGIO to configure.
2750
2751 * s/bsd-common.h, s/darwin.h, s/gnu-kfreebsd.h, s/hpux10-20.h:
2752 Move NO_TERMIO to configure.
2753
0e25d334
CY
27542012-06-12 Chong Yidong <cyd@gnu.org>
2755
2756 * image.c (imagemagick_load_image): Use MagickFlattenImage if
2757 MagickMergeImageLayers is undefined. Use pixel pusher loop if
2758 MagickExportImagePixels is undefined.
2759
43682bb6
PE
27602012-06-12 Paul Eggert <eggert@cs.ucla.edu>
2761
2762 * image.c (imagemagick_load_image): Remove unused label.
2763
a9be7d2b
GM
27642012-06-11 Glenn Morris <rgm@gnu.org>
2765
2766 * s/aix4-2.h, s/bsd-common.h, s/cygwin.h, s/darwin.h:
2767 * s/gnu-kfreebsd.h, s/gnu-linux.h, s/gnu.h, s/hpux10-20.h:
2768 * s/irix6-5.h, s/ms-w32.h, s/msdos.h, s/template.h:
2769 * s/usg5-4-common.h: Move SYSTEM_TYPE to configure.
2770
3017f87f
SM
27712012-06-11 Stefan Monnier <monnier@iro.umontreal.ca>
2772
2773 * alloc.c (make_byte_code): New function.
2774 (Fmake_byte_code): Use it. Don't purify here.
2775 * lread.c (read1): Use it as well to avoid extra allocation.
2776
1b9b4cf4
CY
27772012-06-11 Chong Yidong <cyd@gnu.org>
2778
2779 * image.c (imagemagick_load_image): Implement transparency.
2780
95988fcf
AS
27812012-06-10 Andreas Schwab <schwab@linux-m68k.org>
2782
2783 * regex.c (at_begline_loc_p): Also recognize `(?N:' and correctly
2784 account for preceding backslashes. (Bug#11663)
2785
cd4eb164
CY
27862012-06-09 Chong Yidong <cyd@gnu.org>
2787
2788 * term.c: Support italics in capable terminals (Bug#9652).
2789 (no_color_bit): Replace unused NC_BLINK with NC_ITALIC.
2790 (turn_on_face): Output using TS_enter_italic_mode if available.
2791 Don't handle unused blinking and alt-charset cases.
2792 (turn_off_face): Handle italic case; discard unused tty_blinking_p
2793 and tty_alt_charset_p cases.
2794 (tty_capable_p, init_tty): Support italics.
2795
2796 * termchar.h (struct tty_display_info): Add field for italics.
2797 Remove unused blink field.
2798
2799 * xfaces.c (tty_supports_face_attributes_p, realize_tty_face):
2800 Handle slant.
2801
2802 * dispextern.h: Replace unused TTY_CAP_BLINK with TTY_CAP_ITALIC.
2803 (struct face): Remove unused fields tty_dim_p, tty_blinking_p, and
2804 tty_alt_charset_p. Add tty_italic_p.
2805
ff88beb8
MA
28062012-06-09 Michael Albinus <michael.albinus@gmx.de>
2807
2808 * dbusbind.c (XD_BASIC_DBUS_TYPE): Use dbus_type_is_valid and
2809 dbus_type_is_basic if available.
2810 (xd_extract_signed, xd_extract_unsigned): Rename from
2811 extract_signed and extract_unsigned, respectively. Adapt callers.
2812
44286096
CY
28132012-06-09 Chong Yidong <cyd@gnu.org>
2814
1682701f
CY
2815 * xfaces.c (face_for_overlay_string): Handle face remapping (Bug#2066).
2816
44286096
CY
2817 * fringe.c (Fset_fringe_bitmap_face): Handle the noninteractive
2818 case (Bug#9752).
2819
d86feb17
PE
28202012-06-08 Paul Eggert <eggert@cs.ucla.edu>
2821
2822 * xdisp.c (vmessage): Treat frame message as multibyte.
2823 Without this change, (let ((§ 1)) (make-variable-buffer-local '§))
2824 would generate the diagnostic "Making \302\247 buffer-local while
2825 let-bound!".
2826
d5c20fe8
EZ
28272012-06-08 Eli Zaretskii <eliz@gnu.org>
2828
2829 * dispnew.c (showing_window_margins_p): Undo last change, which
2830 was done due to an inadvertent commit.
2831 (adjust_frame_glyphs_for_frame_redisplay): Do call
2832 showing_window_margins_p.
2833
513749ee
SM
28342012-06-08 Stefan Monnier <monnier@iro.umontreal.ca>
2835
2836 * eval.c (Fmake_var_non_special): New primitive.
2837 (syms_of_eval): Defsubr it.
2838 * lread.c (syms_of_lread): Mark `values' as lexically scoped.
2839
d4a8f5c1
JB
28402012-06-08 Juanma Barranquero <lekktu@gmail.com>
2841
2842 * dispnew.c (showing_window_margins_p): Wrap in #if 0 to prevent unused
2843 function warning (the only call is inside #if 0 since 2012-06-08T08:44:45Z!eliz@gnu.org).
2844
8bbbc977
EZ
28452012-06-08 Eli Zaretskii <eliz@gnu.org>
2846
2847 * alloc.c (allocate_vectorlike): Fix last change.
2848
f3372c87
DA
28492012-06-08 Dmitry Antipov <dmantipov@yandex.ru>
2850
2851 Block-based vector allocation of small vectors.
2852 * lisp.h (struct vectorlike_header): New field `nbytes',
2853 adjust comment accordingly.
2854 * alloc.c (enum mem_type): New type `MEM_TYPE_VECTOR_BLOCK'
2855 to denote vector blocks. Adjust users (live_vector_p,
2856 mark_maybe_pointer, valid_lisp_object_p) accordingly.
2857 (COMMON_MULTIPLE): Move outside #if USE_LSB_TAG.
2858 (VECTOR_BLOCK_SIZE, vroundup, VECTOR_BLOCK_BYTES),
2859 (VBLOCK_BYTES_MIN, VBLOCK_BYTES_MAX, VECTOR_MAX_FREE_LIST_INDEX),
2860 (VECTOR_FREE_LIST_FLAG, ADVANCE, VINDEX, SETUP_ON_FREE_LIST),
2861 (VECTOR_SIZE, VECTOR_IN_BLOCK): New macros.
2862 (roundup_size): New constant.
2863 (struct vector_block): New data type.
2864 (vector_blocks, vector_free_lists, zero_vector): New variables.
513749ee 2865 (all_vectors): Rename to `large_vectors'.
f3372c87
DA
2866 (allocate_vector_from_block, init_vectors, allocate_vector_from_block)
2867 (sweep_vectors): New functions.
2868 (allocate_vectorlike): Return `zero_vector' as the only vector of
2869 0 items. Allocate new vector from block if vector size is less than
2870 or equal to VBLOCK_BYTES_MAX.
2871 (Fgarbage_collect): Move all vector sweeping code to sweep_vectors.
2872 (init_alloc_once): Add call to init_vectors.
2873
4f18a4ed
SM
28742012-06-08 Stefan Monnier <monnier@iro.umontreal.ca>
2875
2876 * eval.c (Fmacroexpand): Stop if the macro returns the same form.
2877
86f158bc
PE
28782012-06-07 Paul Eggert <eggert@cs.ucla.edu>
2879
2880 * doprnt.c (doprnt): Truncate multibyte char correctly.
2881 Without this change, doprnt (buf, 2, "%s", FORMAT_END, AP)
2882 would mishandle a string argument "Xc" if X was a multibyte
2883 character of length 2: it would truncate after X's first byte
2884 rather than including all of X.
2885
c5cfcbe0
CY
28862012-06-06 Chong Yidong <cyd@gnu.org>
2887
2888 * buffer.c (word_wrap): Doc fix.
2889
c05cf390
PE
28902012-06-04 Paul Eggert <eggert@cs.ucla.edu>
2891
2892 * xdisp.c (note_mode_line_or_margin_highlight): Pacify gcc -Wall.
2893
0c3461de
GM
28942012-06-03 Glenn Morris <rgm@gnu.org>
2895
2896 * xdisp.c (tool-bar-style): Doc fix.
2897
c71232db
UM
28982012-06-03 Ulrich Müller <ulm@gentoo.org>
2899
2900 * Makefile.in (PAXCTL): Define.
2901 (temacs$(EXEEXT)): Disable memory randomization for the temacs
2902 binary via PaX flags if the paxctl utility is available.
2903 (emacs$(EXEEXT), bootstrap-emacs$(EXEEXT)):
2904 Restore PaX flags to their default. (Bug#11398)
2905
383f7350
CY
29062012-06-03 Chong Yidong <cyd@gnu.org>
2907
2908 * xdisp.c (decode_mode_spec_coding): Display a space for a unibyte
2909 buffer (Bug#11226).
2910
5f2c76c6
CY
29112012-06-03 Chong Yidong <cyd@gnu.org>
2912
2913 * xdisp.c (calc_pixel_width_or_height): Use Fbuffer_local_value.
2914 (note_mode_line_or_margin_highlight): If there is no help echo,
2915 use mode-line-default-help-echo. Handle the case where the mouse
2916 position is past the end of the mode line string.
2917
2918 * buffer.c (buffer_local_value_1): New function, split from
2919 Fbuffer_local_value; can return Qunbound.
2920 (Fbuffer_local_value): Use it.
2921 (Vmode_line_format): Docstring tweaks.
2922
773d47f6
PE
29232012-06-02 Paul Eggert <eggert@cs.ucla.edu>
2924
2925 * sysdep.c (system_process_attributes): Improve comment.
2926
f2d6a3df
SM
29272012-06-02 Stefan Monnier <monnier@iro.umontreal.ca>
2928
2929 * keyboard.c: Export real-this-command to Elisp.
2930 (syms_of_keyboard): Rename real_this_command to Vreal_this_command
2931 and DEFVAR it. Update all users.
2932
63810350
PE
29332012-06-02 Paul Eggert <eggert@cs.ucla.edu>
2934
7bd5c1f4
PE
2935 * minibuf.c (Fassoc_string): Remove duplicate declaration.
2936
63810350
PE
2937 * sysdep.c (system_process_attributes) [SOLARIS2 && HAVE_PROCFS]:
2938 Convert pctcpu and pctmem to Lisp float properly.
2939 Let the compiler fold better, as 100.0/0x8000 is exact.
2940
a2821611
AS
29412012-06-02 Andreas Schwab <schwab@linux-m68k.org>
2942
2943 * alloc.c (CONS_BLOCK_SIZE): Account for padding at the end of
2944 cons_block.
2945
5fceba1d
PE
29462012-06-01 Paul Eggert <eggert@cs.ucla.edu>
2947
2948 * xfns.c (x_set_tool_bar_lines) [USE_GTK]: Adjust to bitfield change.
2949
c98ff5dd
DA
29502012-06-01 Dmitry Antipov <dmantipov@yandex.ru>
2951
2952 For a 'struct window', replace some Lisp_Object fields to
2953 bitfields where appropriate, remove unused fields.
2954 * window.h (struct window): Remove unused 'last_mark_x' and
2955 'last_mark_y' fields. Rename 'mini_p' field to 'mini',
2956 change it's type from Lisp_Object to bitfield.
2957 Change type of 'force_start', 'optional_new_start',
2958 'last_had_star', 'update_mode_line' and 'start_at_line_beg'
2959 fields from Lisp_Object to bitfield. Adjust users accordingly.
2960
ca34e0be
PE
29612012-05-31 Paul Eggert <eggert@cs.ucla.edu>
2962
2963 Pacify gcc -Wdouble-precision when using Xaw.
2964 * xterm.c (xaw_jump_callback, x_set_toolkit_scroll_bar_thumb)
2965 [HAVE_X_WINDOWS && USE_TOOLKIT_SCROLL_BARS && !USE_MOTIF && !USE_GTK]:
2966 Use 'float' consistently, rather than 'float' in most places
2967 and 'double' in a couple of places.
2968
efc00ab1 29692012-05-31 Eli Zaretskii <eliz@gnu.org>
d5fd2c54
EZ
2970
2971 * xdisp.c (handle_stop): Detect whether we have overlay strings
2972 loaded by testing it->current.overlay_string_index to be
2973 non-negative, instead of checking whether n_overlay_strings is
2974 positive. (Bug#11587)
2975
efc00ab1 29762012-05-31 Chong Yidong <cyd@gnu.org>
353c87f6
CY
2977
2978 * keymap.c (describe_map_tree): Revert 2011-07-07 change (Bug#1169).
2979
2980 * doc.c (Fsubstitute_command_keys): Doc fix.
2981
efc00ab1 29822012-05-31 Eli Zaretskii <eliz@gnu.org>
a02ae4e5
EZ
2983
2984 * search.c (search_buffer): Remove calls to
2985 r_alloc_inhibit_buffer_relocation, as it is now called by
2986 maybe_unify_char, which was the cause of relocation of buffer text
2987 in bug#11519.
2988
efc00ab1 29892012-05-31 Eli Zaretskii <eliz@gnu.org>
291d430f
EZ
2990
2991 * charset.c (maybe_unify_char): Inhibit relocation of buffer text
2992 for the duration of call to load_charset, to avoid problems with
2993 callers of maybe_unify_char that access buffer text through C
2994 pointers.
2995
2996 * ralloc.c (r_alloc_inhibit_buffer_relocation): Increment and
2997 decrement the inhibition flag, instead of just setting or
2998 resetting it.
2999
ba93a187
PE
30002012-05-31 Paul Eggert <eggert@cs.ucla.edu>
3001
3002 Remove obsolete '#define static' cruft.
3003 * s/hpux10-20.h (_FILE_OFFSET_BITS): Don't #undef.
3004 This #undef was "temporary" in 2000; it is no longer needed
3005 now that '#define static' has gone away.
3006 * xfns.c, xterm.h (gray_bitmap_width, gray_bitmap_height)
3007 (gray_bitmap_bits): Remove; no longer needed.
3008 All uses replaced with definiens.
3009 * xterm.c: Include "bitmaps/gray.xbm".
3010
9e4bf381
PE
30112012-05-30 Paul Eggert <eggert@cs.ucla.edu>
3012
3013 Clean up __executable_start, monstartup when --enable-profiling.
3014 The following changes affect the code only when profiling.
3015 * dispnew.c (__executable_start): Rename from safe_bcopy.
3016 Define only on platforms that need it.
3017 * emacs.c: Include <sys/gmon.h> when profiling.
3018 (_mcleanup): Remove decl, since <sys/gmon.h> does it now.
3019 (__executable_start): Remove decl, since lisp.h does it now.
3020 (safe_bcopy): Remove decl; no longer has that name.
3021 (main): Coalesce #if into single bit of code, for simplicity.
3022 Cast pointers to uintptr_t, since standard libraries want integers
3023 and not pointers.
3024 * lisp.h (__executable_start): New decl.
3025
32d72c2f
GM
30262012-05-31 Glenn Morris <rgm@gnu.org>
3027
3028 * image.c (Fimagemagick_types): Doc fix.
3029
baac5bc7
JM
30302012-05-30 Jim Meyering <meyering@redhat.com>
3031
3032 * callproc.c (Fcall_process_region): Include directory component
3033 in mkstemp error message (Bug#11586).
3034
72cb32cf
PE
30352012-05-30 Paul Eggert <eggert@cs.ucla.edu>
3036
3037 * alloc.c, lisp.h (make_pure_vector): Now static.
3038
61b108cc
SM
30392012-05-30 Stefan Monnier <monnier@iro.umontreal.ca>
3040
3041 * eval.c (Fdefun, Fdefmacro, Vmacro_declaration_function):
3042 Move to byte-run.el.
3043 (Fautoload): Do the hash-doc more carefully.
3044 * data.c (Fdefalias): Purify definition, except for keymaps.
3045 (Qdefun): Move from eval.c.
3046 * lisp.h (Qdefun): Remove.
3047 * lread.c (read1): Tiny simplification.
3048
471fe23d
TN
30492012-05-29 Troels Nielsen <bn.troels@gmail.com>
3050
934f3f58 3051 Do not create empty overlays with the evaporate property (Bug#9642).
471fe23d
TN
3052 * buffer.c (Fmove_overlay): Reinstate the earlier fix for
3053 Bug#9642, but explicitly check that the buffer the overlay would
3054 be moved to is live and rearrange lines to make sure that errors
3055 will not put the overlay in an inconsistent state.
3056 (Fdelete_overlay): Cosmetics.
3057
85d0efd1
EZ
30582012-05-28 Eli Zaretskii <eliz@gnu.org>
3059
3060 * w32term.c (my_bring_window_to_top): New function.
3061 (x_raise_frame): Use handle returned by DeferWindowPos, which
61b108cc
SM
3062 could be different from the original one.
3063 Call my_bring_window_to_top instead of my_set_foreground_window.
85d0efd1
EZ
3064 (Bug#11513)
3065
3066 * w32fns.c (w32_wnd_proc): Accept and process WM_EMACS_BRINGTOTOP
3067 by calling BringWindowToTop.
3068
3069 * w32term.h (WM_EMACS_BRINGTOTOP): New message.
3070 (WM_EMACS_END): Increase by one.
3071
da92a98c
PE
30722012-05-28 Paul Eggert <eggert@cs.ucla.edu>
3073
3074 * bidi.c (bidi_mirror_char): Put eassert before conversion to int.
3075 This avoids undefined behavior that might cause the eassert
3076 to not catch an out-of-range value.
3077
74d1f848
JB
30782012-05-28 Juanma Barranquero <lekktu@gmail.com>
3079
3080 * makefile.w32-in ($(BLD)/w32inevt.$(O), $(BLD)/w32console.$(O)):
3081 Update dependencies.
3082
9e1a06fc
EZ
30832012-05-27 Eli Zaretskii <eliz@gnu.org>
3084
3085 * bidi.c (bidi_mirror_char): Fix last change.
3086
f3dd7312
AS
30872012-05-27 Andreas Schwab <schwab@linux-m68k.org>
3088
3089 * unexmacosx.c (copy_data_segment): Truncate after 16 characters
3090 when referring to sectname field in printf format.
3091
81899c91
PE
30922012-05-27 Paul Eggert <eggert@cs.ucla.edu>
3093
57b81a9f
PE
3094 * lisp.h [REL_ALLOC]: Omit duplicate prototypes.
3095 Only r_alloc_inhibit_buffer_relocation needed to be added;
3096 the others were already declared.
3097
81899c91
PE
3098 * bidi.c (bidi_mirror_char): Don't possibly truncate the integer
3099 before checking whether it's out of range. Put the check inside
3100 eassert. See
3101 <http://lists.gnu.org/archive/html/emacs-devel/2012-05/msg00485.html>.
3102
33017faf 31032012-05-27 Ken Brown <kbrown@cornell.edu>
2f9b9adb
KB
3104
3105 * callproc.c (Fcall_process): Restore a line that was accidentally
3106 commented out in the 2011-02-13 change (bug#11547).
3107
33017faf 31082012-05-27 Eli Zaretskii <eliz@gnu.org>
52c55cc7
EZ
3109
3110 * lisp.h [REL_ALLOC]: Add prototypes for external functions
3111 defined on ralloc.c.
3112
3113 * buffer.c [REL_ALLOC]: Remove prototypes of
3114 r_alloc_reset_variable, r_alloc, r_re_alloc, and r_alloc_free,
3115 they are now on lisp.h.
3116
3117 * ralloc.c (r_alloc_inhibit_buffer_relocation): New function.
3118
3119 * search.c (search_buffer): Use it to inhibit relocation of buffer
3120 text while re_search_2 is doing its job, because re_search_2 is
3121 passed C pointers to buffer text. (Bug#11519)
3122
23415acf
EZ
3123 * msdos.c (internal_terminal_init) <Vwindow_system_version>:
3124 Update value to 24.
3125
44e27368
EZ
3126 * xdisp.c (move_it_to): Under MOVE_TO_Y, when restoring iterator
3127 state after an additional call to move_it_in_display_line_to, keep
3128 the values of it->max_ascent and it->max_descent found for the
3129 entire line.
3130 (pos_visible_p): Revert the comparison against bottom_y to what it
3131 was in revid eliz@gnu.org-20120513182235-4p6386j761ld0nwb.
3132 (Bug#11464)
3133
c1892f11
PE
31342012-05-26 Paul Eggert <eggert@cs.ucla.edu>
3135
3136 Fix coding-related core dumps with gcc -ftrapv.
3137 The code was computing A - B, where A and B are pointers, and B is
3138 random garbage. This can lead to core dumps on platforms that
3139 have special pointer registers, and it also leads to core dumps on
3140 x86-64 when compiled with gcc -ftrapv. The fix is to compute
3141 A - B only when B is initialized properly.
3142 * coding.c (coding_set_source, coding_set_destination): Return void.
3143 (coding_change_source, coding_change_destinations): New functions,
3144 with the old behaviors of coding_set_source and coding_set_destination.
3145 All callers that need an offset changed to use these new functions.
3146
eb7afdad
GM
31472012-05-26 Glenn Morris <rgm@gnu.org>
3148
3149 * nsterm.m (ns_init_paths): Don't mess with INFOPATH. (Bug#2791)
3150
f12fdf02
EZ
31512012-05-26 Eli Zaretskii <eliz@gnu.org>
3152
53a63be6 3153 Extend mouse support on W32 text-mode console.
61b108cc
SM
3154 * xdisp.c (draw_row_with_mouse_face):
3155 Call tty_draw_row_with_mouse_face for WINDOWSNT as well.
eb3f6f01 3156
eb3f6f01 3157 * w32console.c: Include window.h.
61b108cc
SM
3158 (w32con_write_glyphs_with_face, tty_draw_row_with_mouse_face):
3159 New functions.
eb3f6f01
EZ
3160 (initialize_w32_display): Initialize mouse-highlight data.
3161
53a63be6
EZ
3162 * w32inevt.c: Include termchar.h and window.h.
3163 (do_mouse_event): Support mouse-autoselect-window. When the mouse
3164 moves, call note_mouse_highlight. If help_echo changed, call
3165 gen_help_event to produce help-echo message in the echo area.
3166 Call clear_mouse_face if mouse_face_hidden is set in the mouse
3167 highlight info.
3168
4cfd81f6
PE
31692012-05-26 Paul Eggert <eggert@cs.ucla.edu>
3170
3171 * lread.c (read1): Simplify slightly to avoid an overflow warning
3172 with GCC 4.7.0 on x86-64.
3173
4446092a
EZ
31742012-05-26 Eli Zaretskii <eliz@gnu.org>
3175
3176 * bidi.c (bidi_mirror_char): Revert last change: an int is
3177 definitely wide enough here.
3178
42b2a986 31792012-05-25 Paul Eggert <eggert@cs.ucla.edu>
3164aeac 3180
42b2a986 3181 Fix integer width and related bugs (Bug#9874).
eb106a49 3182 * alloc.c (pure_bytes_used_lisp, pure_bytes_used_non_lisp):
d311d28c
PE
3183 (allocate_vectorlike, buffer_memory_full, struct sdata, SDATA_SIZE)
3184 (string_bytes, check_sblock, allocate_string_data):
3185 (compact_small_strings, Fmake_bool_vector, make_string)
3186 (make_unibyte_string, make_multibyte_string)
3187 (make_string_from_bytes, make_specified_string)
3188 (allocate_vectorlike, Fmake_vector, find_string_data_in_pure)
3189 (make_pure_string, make_pure_c_string, make_pure_vector, Fpurecopy)
3190 (mark_vectorlike):
3191 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3192 (allocate_pseudovector):
3193 Use int, not EMACS_INT, where int is wide enough.
3194 (inhibit_garbage_collection, Fgarbage_collect):
3195 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3196 * bidi.c (bidi_mirror_char): Use EMACS_INT, not int, where
3197 int might not be wide enough.
3198 (bidi_cache_search, bidi_cache_find, bidi_init_it)
3199 (bidi_count_bytes, bidi_char_at_pos, bidi_fetch_char)
3200 (bidi_at_paragraph_end, bidi_find_paragraph_start)
3201 (bidi_paragraph_init, bidi_resolve_explicit, bidi_resolve_weak)
3202 (bidi_level_of_next_char, bidi_move_to_visually_next):
3203 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3204 * buffer.c (copy_overlays, Fgenerate_new_buffer_name)
3205 (Fkill_buffer, Fset_buffer_major_mode)
3206 (advance_to_char_boundary, Fbuffer_swap_text)
3207 (Fset_buffer_multibyte, overlays_at, overlays_in)
3208 (overlay_touches_p, struct sortvec, record_overlay_string)
3209 (overlay_strings, recenter_overlay_lists)
3210 (adjust_overlays_for_insert, adjust_overlays_for_delete)
3211 (fix_start_end_in_overlays, fix_overlays_before, modify_overlay)
3212 (Fmove_overlay, Fnext_overlay_change, Fprevious_overlay_change)
3213 (Foverlay_recenter, last_overlay_modification_hooks_used)
3214 (report_overlay_modification, evaporate_overlays, enlarge_buffer_text):
3215 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
977b0e45
PE
3216 (validate_region): Omit unnecessary test for b <= e,
3217 since that's guaranteed by the previous test.
d311d28c
PE
3218 (adjust_overlays_for_delete): Avoid pos + length overflow.
3219 (Fmove_overlay, Fdelete_overlay, add_overlay_mod_hooklist)
3220 (report_overlay_modification):
3221 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3222 (Foverlays_at, Fnext_overlay_change, Fprevious_overlay_change):
3223 Omit pointer cast, which isn't needed anyway, and doesn't work
3224 after the EMACS_INT -> ptrdiff_t change.
02481186 3225 (Fmove_overlay): Clip BEG and END to ptrdiff_t to avoid overflow.
d311d28c
PE
3226 * buffer.h: Adjust decls to match defn changes elsewhere.
3227 (struct buffer_text, struct buffer):
3228 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3229 Use EMACS_INT, not int, where int might not be wide enough.
39b5db3b
PE
3230 * bytecode.c (unmark_byte_stack, exec_byte_code): Use ptrdiff_t,
3231 not int, to avoid needless 32-bit limit on 64-bit hosts.
3232 (exec_byte_code): Use tighter memory-full test, one that checks
3233 for alloca overflow. Don't compute the address of the object just
3234 before an array, as that's not portable. Use EMACS_INT, not
3235 ptrdiff_t or int, where ptrdiff_t or int might not be wide enough.
d311d28c
PE
3236 * callint.c (Fcall_interactively):
3237 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3238 * callproc.c (call_process_kill, Fcall_process):
3239 Don't assume pid_t fits into an Emacs fixnum.
3240 (call_process_cleanup, Fcall_process, child_setup):
3241 Don't assume pid_t fits into int.
3242 (call_process_cleanup, Fcall_process, delete_temp_file)
3243 (Fcall_process_region):
3244 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3245 (Fcall_process): Simplify handling of volatile integers.
3246 Use int, not EMACS_INT, where int will do.
3247 * casefiddle.c (casify_object, casify_region, operate_on_word)
3248 (Fupcase_word, Fdowncase_word, Fcapitalize_word):
3249 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3250 (casify_object): Avoid integer overflow when overallocating buffer.
3251 * casetab.c (set_identity, shuffle): Prefer int to unsigned when
45c2afd6 3252 either works. Use lint_assume to convince GCC 4.6.1 that it's OK.
d311d28c
PE
3253 * category.c (Fchar_category_set): Don't assume fixnum fits in int.
3254 * category.h (CATEGORYP): Don't assume arg is nonnegative.
3255 * ccl.c (GET_CCL_INT): Remove; no longer needed, since the
3256 integers are now checked earlier. All uses replaced with XINT.
3257 (ccl_driver):
3258 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3259 For CCL_MapSingle, check that content and value are in int range.
c801946a
PE
3260 (ccl_driver, Fregister_code_conversion_map):
3261 Check that Vcode_version_map_vector is a vector.
d311d28c
PE
3262 (resolve_symbol_ccl_program): Check that vector header is in range.
3263 Always copy the vector, so that we can check its contents reliably
3264 now rather than having to recheck each instruction as it's being
3265 executed. Check that vector words fit in 'int'.
3266 (ccl_get_compiled_code, Fregister_ccl_program)
3267 (Fregister_code_conversion_map): Use ptrdiff_t, not int, for
3268 program indexes, to avoid needless 32-bit limit on 64-bit hosts.
3269 (Fccl_execute, Fccl_execute_on_string): Check that initial reg
3270 contents are in range.
3271 (Fccl_execute_on_string): Check that status is in range.
3272 * ccl.h (struct ccl_program.idx): Now ptrdiff_t, not int.
3273 * character.c (char_resolve_modifier_mask, Fchar_resolve_modifiers):
3274 Accept and return EMACS_INT, not int, because callers can pass values
3275 out of 'int' range.
3276 (c_string_width, strwidth, lisp_string_width, chars_in_text)
3277 (multibyte_chars_in_text, parse_str_as_multibyte)
3278 (str_as_multibyte, count_size_as_multibyte, str_to_multibyte)
3279 (str_as_unibyte, str_to_unibyte, string_count_byte8)
3280 (string_escape_byte8, Fget_byte):
3281 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
a14e1568 3282 (Funibyte_string): Use CHECK_RANGED_INTEGER, not CHECK_NATNUM, to
d311d28c
PE
3283 avoid mishandling large integers.
3284 * character.h: Adjust decls to match defn changes elsewhere.
3285 * charset.c (load_charset_map_from_file, find_charsets_in_text)
3286 (Ffind_charset_region):
3287 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3288 (load_charset_map_from_file): Redo idx calculation to avoid overflow.
3289 (load_charset_map_from_vector, Fdefine_charset_internal):
3c7649c1 3290 Don't assume fixnum fits in int.
d311d28c
PE
3291 (load_charset_map_from_vector, Fmap_charset_chars):
3292 Remove now-unnecessary CHECK_NATNUMs.
3293 (Fdefine_charset_internal): Check ranges here, more carefully.
3c7649c1
PE
3294 Don't rely on undefined behavior with signed left shift overflow.
3295 Don't assume unsigned int fits into fixnum, or that fixnum fits
3296 into unsigned int. Don't require max_code to be a valid fixnum;
3297 that's not true for gb10830 4-byte on a 32-bit host. Allow
3298 invalid_code to be a cons, for the same reason. Require code_offset
3299 to be a character. Avoid int overflow if max_char is close
3300 to INT_MAX.
3301 (CODE_POINT_TO_INDEX): On 32-bit hosts, return int, not unsigned;
3302 this is intended anyway and avoids some undefined behavior.
3303 (load_charset_map): Pass unsigned, not int, as 2nd arg of
3304 INDEX_TO_CODE_POINT, as that's what it expects.
3305 (Funify_charset, encode_char): Don't stuff unsigned vals into int vars.
60ad3eab
PE
3306 * charset.h (DECODE_CHAR): Return int, not unsigned;
3307 this is what was intended anyway, and it avoids undefined behavior.
3308 (CHARSET_OFFSET): Remove unused macro, instead of fixing its
3309 integer-overflow issues.
3310 (ENCODE_CHAR): Return unsigned on all hosts, not just on 32-bit hosts.
3311 Formerly, it returned EMACS_INT on 64-bit hosts in the common case
3312 where the argument is EMACS_INT, and this behavior is not intended.
d311d28c
PE
3313 * chartab.c (Fmake_char_table, Fset_char_table_range)
3314 (uniprop_get_decoder, uniprop_get_encoder):
3315 Don't assume fixnum fits in int.
3316 * cmds.c (move_point): New function, that does the gist of
3317 Fforward_char and Fbackward_char, but does so while checking
3318 for integer overflow more accurately.
c96e5d6a 3319 (Fforward_char, Fbackward_char): Use it.
d311d28c
PE
3320 (Fforward_line, Fend_of_line, internal_self_insert)
3321 (internal_self_insert):
3322 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3323 Fix a FIXME, by checking for integer overflow when calculating
3324 target_clm and actual_clm.
3325 * coding.c (detect_coding_XXX, encode_coding_XXX, CODING_DECODE_CHAR)
8f50130c 3326 (CODING_ENCODE_CHAR, CODING_CHAR_CHARSET, CODING_CHAR_CHARSET_P)
d311d28c
PE
3327 (ASSURE_DESTINATION, coding_alloc_by_realloc)
3328 (coding_alloc_by_making_gap, alloc_destination)
3329 (detect_coding_utf_8, encode_coding_utf_8, decode_coding_utf_16)
3330 (encode_coding_utf_16, detect_coding_emacs_mule)
3331 (decode_coding_emacs_mule, encode_coding_emacs_mule)
3332 (detect_coding_iso_2022, decode_coding_iso_2022)
3333 (encode_invocation_designation, encode_designation_at_bol)
3334 (encode_coding_iso_2022, detect_coding_sjis, detect_coding_big5)
3335 (decode_coding_sjis, decode_coding_big5, encode_coding_sjis)
3336 (encode_coding_big5, detect_coding_ccl, decode_coding_ccl)
3337 (encode_coding_ccl, encode_coding_raw_text)
3338 (detect_coding_charset, decode_coding_charset)
3339 (encode_coding_charset, detect_eol, decode_eol, produce_chars)
3340 (produce_composition, produce_charset, produce_annotation)
3341 (decode_coding, handle_composition_annotation)
3342 (handle_charset_annotation, consume_chars, decode_coding_gap)
3343 (decode_coding_object, encode_coding_object, detect_coding_system)
3344 (Ffind_coding_systems_region_internal, Fcheck_coding_systems_region)
3345 (code_convert_region, code_convert_string)
8f50130c
PE
3346 (Fdefine_coding_system_internal)
3347 (coding_set_source, coding_set_destination):
d311d28c
PE
3348 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3349 (setup_iso_safe_charsets, consume_chars, Funencodable_char_position)
3350 (Fdefine_coding_system_internal):
3351 Don't assume fixnums fit in int.
3352 (decode_coding_gap, decode_coding_object, encode_coding_object)
5895d7b9 3353 (Fread_coding_system, Fdetect_coding_region)
2c6a9faa
PE
3354 (Funencodable_char_position, Fcheck_coding_systems_region)
3355 (get_translation, handle_composition_annotation, consume_chars):
d311d28c 3356 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
977b0e45 3357 (consume_chars): Rewrite to not calculate an address outside buffer.
d311d28c 3358 (Ffind_operation_coding_system): NATNUMP can eval its arg twice.
7b09a37a 3359 Don't access memory outside of the args array.
d311d28c 3360 (Fdefine_coding_system_internal): Check for charset-id overflow.
47664caa
PE
3361 (ENCODE_ISO_CHARACTER): Use unsigned, not int, to store the unsigned
3362 result of ENCODE_CHAR.
d311d28c
PE
3363 * coding.h: Adjust decls to match defn changes elsewhere.
3364 (struct coding_system):
3365 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3366 * composite.c (get_composition_id, find_composition)
3367 (run_composition_function, update_compositions)
3368 (compose_text, composition_gstring_put_cache)
3369 (composition_gstring_p, composition_gstring_width)
3370 (fill_gstring_header, fill_gstring_body, autocmp_chars)
3371 (composition_compute_stop_pos, composition_reseat_it)
3372 (composition_update_it, struct position_record)
3373 (find_automatic_composition, composition_adjust_point)
3374 (Fcomposition_get_gstring, Ffind_composition_internal):
3375 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3376 (update_compositions):
3377 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3378 * composite.h: Adjust decls to match defn changes elsewhere.
3379 (struct composition):
3380 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3381 * data.c (let_shadows_buffer_binding_p, let_shadows_global_binding_p):
3382 Do not attempt to compute the address of the object just before a
3383 buffer; this is not portable.
3384 (Faref, Faset):
3385 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3386 (Faset): Use int, not EMACS_INT, where int is wide enough.
3387 (Fstring_to_number): Don't assume fixnums fit in int.
3388 (Frem): Don't assume arg is nonnegative.
3389 * dbusbind.c (xd_append_arg): Check for integers out of range.
3390 (Fdbus_call_method): Don't overflow the timeout int.
42b2a986 3391 (extract_signed, extract_unsigned): New functions.
243e0530
PE
3392 (XD_CHECK_DBUS_SERIAL): Remove; superseded by extract_unsigned.
3393 (xd_get_connection_references): Return ptrdiff_t, not int.
3394 All uses changed.
3395 (xd_signature, xd_append_arg, xd_retrieve_arg, Fdbus_message_internal)
3396 (xd_read_message_1):
3397 Use int, not unsigned, where the dbus API uses int.
3398 (Fdbus_message_internal): Don't overflow mtype.
3399 (syms_of_dbusbind): Allocate right-sized buffer for integers.
d311d28c
PE
3400 * dired.c (directory_files_internal, file_name_completion, scmp)
3401 (file_name_completion_stat):
3402 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3403 (file_name_completion): Don't overflow matchcount.
3404 (file_name_completion_stat): Use SAFE_ALLOCA, not alloca.
3405 * dispextern.h: Adjust decls to match defn changes elsewhere.
3406 (struct text_pos, struct glyph, struct bidi_saved_info)
3407 (struct bidi_string_data, struct bidi_it, struct composition_it)
3408 (struct it):
3409 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3410 (struct display_pos, struct composition_it, struct it):
3411 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3412 * dispnew.c (increment_matrix_positions)
3413 (increment_row_positions, mode_line_string)
3414 (marginal_area_string):
3415 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
54e1617f 3416 (change_frame_size_1, Fredisplay, Fframe_or_buffer_changed_p):
d311d28c
PE
3417 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3418 (duration_to_sec_usec): New function, to check for overflow better.
3419 (Fsleep_for, sit_for): Use it.
3420 * doc.c (get_doc_string, store_function_docstring):
3421 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3422 (get_doc_string, Fsnarf_documentation):
3423 Use int, not EMACS_INT, where int is wide enough.
3424 (get_doc_string):
3425 Use SAFE_ALLOCA, not alloca.
3426 Check for overflow when converting EMACS_INT to off_t.
3427 * doprnt.c (doprnt):
3428 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3429 * editfns.c (init_editfns, Fuser_uid, Fuser_real_uid):
3430 Don't assume uid_t fits into fixnum.
3431 (buildmark, Fgoto_char, overlays_around, find_field, Fdelete_field)
3432 (Ffield_string, Ffield_string_no_properties, Ffield_beginning)
3433 (Ffield_end, Fconstrain_to_field, Fline_beginning_position)
3434 (Fline_end_position, Fprevious_char, Fchar_after, Fchar_before)
3435 (general_insert_function)
3436 (Finsert_char, make_buffer_string, make_buffer_string_both)
3437 (update_buffer_properties, Fbuffer_substring)
3438 (Fbuffer_substring_no_properties, Fcompare_buffer_substrings)
3439 (Fsubst_char_in_region, check_translation)
3440 (Ftranslate_region_internal, save_restriction_restore, Fformat)
3441 (transpose_markers, Ftranspose_regions):
3442 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3443 (clip_to_bounds): Move to lisp.h as an inline function).
3444 (Fconstrain_to_field): Don't assume integers are nonnegative.
3445 (Fline_beginning_position, Fsave_excursion, Fsave_current_buffer):
3446 (Fsubst_char_in_region, Fsave_restriction):
3447 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3448 (Femacs_pid): Don't assume pid_t fits into fixnum.
3449 (lo_time): Use int, not EMACS_INT, when int suffices.
3450 (lisp_time_argument): Check for usec out of range.
3451 (Fencode_time): Don't assume fixnum fits in int.
3f4eabd1
PE
3452 (Fuser_login_name, Fuser_full_name): Signal an error
3453 if a uid argument is out of range, rather than relying on
3454 undefined behavior.
c8d5c857
PE
3455 (Fformat_time_string): Remove now-unnecessary check.
3456 lisp_time_argument checks for out-of-range usec now.
243e0530 3457 Use ptrdiff_t, not size_t, where ptrdiff_t will do.
d311d28c
PE
3458 * emacs.c (gdb_valbits, gdb_gctypebits): Now int, not EMACS_INT.
3459 (gdb_data_seg_bits): Now uintptr_t, not EMACS_INT.
3460 (PVEC_FLAG, gdb_array_mark_flag): Now ptrdiff_t, not EMACS_INT.
3461 (init_cmdargs, Fdump_emacs):
3462 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3463 (Fkill_emacs): Don't assume fixnum fits in int; instead, take just
3464 the bottom (typically) 32 bits of the fixnum.
3465 * eval.c (specpdl_size, call_debugger):
3466 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3467 (when_entered_debugger, Fbacktrace_debug):
3468 Don't assume fixnum can fit in int.
3469 (Fdefvaralias, Fdefvar): Do not attempt to compute the address of
3470 the object just before a buffer; this is not portable.
3471 (FletX, Flet, Funwind_protect, do_autoload, Feval, funcall_lambda)
3472 (grow_specpdl, unbind_to):
3473 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3474 (Fapply, apply_lambda): Don't assume ptrdiff_t can hold fixnum.
3475 (grow_specpdl): Simplify allocation by using xpalloc.
856bbc81 3476 (Fprog1, Fprog2): Don't assume list length fits in int. Simplify.
d311d28c
PE
3477 * fileio.c (Ffind_file_name_handler, Fcopy_file, Frename_file)
3478 (Finsert_file_contents, Fwrite_region, Fdo_auto_save):
3479 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3480 (Ffind_file_name_handler, non_regular_inserted, Finsert_file_contents)
3481 (a_write, e_write):
3482 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3483 (Fcopy_file, non_regular_nbytes, read_non_regular)
3484 (Finsert_file_contents):
3485 Use int, not EMACS_INT, where int is wide enough.
3486 (READ_BUF_SIZE): Verify that it fits in int.
3487 (Finsert_file_contents): Check that counts are in proper range,
3488 rather than assuming fixnums fit into ptrdiff_t etc.
3489 Don't assume fixnums fit into int.
125b3835 3490 * floatfns.c (Fexpt): Avoid undefined signed * signed overflow.
5895d7b9
PE
3491 * fns.c (Fcompare_strings, Fstring_lessp, struct textprop_rec, concat)
3492 (string_char_byte_cache_charpos, string_char_byte_cache_bytepos)
d311d28c
PE
3493 (string_char_to_byte, string_byte_to_char)
3494 (string_make_multibyte, string_to_multibyte)
3495 (string_make_unibyte, Fstring_as_unibyte, Fstring_as_multibyte)
3496 (Fstring_to_unibyte, Fsubstring, Fsubstring_no_properties)
3497 (substring_both, Fdelete, internal_equal, Ffillarray)
3498 (Fclear_string, mapcar1)
3499 (Fbase64_encode_region, Fbase64_encode_string, base64_encode_1)
3500 (Fbase64_decode_region, Fbase64_decode_string, base64_decode_1)
3501 (larger_vector, make_hash_table, maybe_resize_hash_table)
3502 (hash_lookup, hash_remove_from_table, hash_clear, sweep_weak_table)
3503 (Fmaphash, secure_hash):
3504 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3505 (concat): Check for string index and length overflow.
3506 (Fmapconcat): Don't assume fixnums fit into ptrdiff_t.
3507 (Frequire):
3508 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3509 (larger_vector): New API (vec, incr_min, size_max) replaces old
3510 one (vec, new_size, init). This catches size overflow.
3511 INIT was removed because it was always Qnil.
3512 All callers changed.
3513 (INDEX_SIZE_BOUND): New macro, which calculates more precisely
3514 the upper bound on a hash table index size.
3515 (make_hash_table, maybe_resize_hash_table): Use it.
3516 (secure_hash): Computer start_byte and end_byte only after
3517 they're known to be in ptrdiff_t range.
3518 * font.c (font_intern_prop, font_at, font_range, Ffont_shape_gstring)
3519 (Ffont_get_glyphs, Ffont_at):
3520 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3521 (font_style_to_value, font_prop_validate_style, font_expand_wildcards)
3522 (Flist_fonts, Fopen_font):
3523 Don't assume fixnum can fit in int.
3524 (check_gstring): Don't assume index can fit in int.
3525 (font_match_p): Check that fixnum is a character, not a nonnegative
3526 fixnum, since the later code needs to stuff it into an int.
3527 (font_find_for_lface): Use SAFE_ALLOCA_LISP, not alloca.
3528 (font_fill_lglyph_metrics): Use unsigned, not EMACS_INT, to avoid
3529 conversion overflow issues.
3530 (Fopen_font): Check for integer out of range.
3531 (Ffont_get_glyphs): Don't assume index can fit in int.
3532 * font.h: Adjust decls to match defn changes elsewhere.
3533 * fontset.c (reorder_font_vector): Redo score calculation to avoid
3534 integer overflow.
3535 (num_auto_fontsets, fontset_from_font): Use ptrdiff_t, not
3536 printmax_t, where ptrdiff_t is wide enough.
3537 (Finternal_char_font):
3538 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3539 * frame.c (Fset_mouse_position, Fset_mouse_pixel_position)
3540 (Fset_frame_height, Fset_frame_width, Fset_frame_size)
3541 (Fset_frame_position, x_set_frame_parameters)
3542 (x_set_line_spacing, x_set_border_width)
3543 (x_set_internal_border_width, x_set_alpha, x_figure_window_size):
3544 Check that fixnums are in proper range for system types.
3545 (frame_name_fnn_p, Fframe_parameter, Fmodify_frame_parameters):
3546 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3547 (Fmodify_frame_parameters): Don't assume fixnum fits in int.
3548 Use SAFE_ALLOCA_LISP, not alloca.
3549 * frame.h (struct frame): Use intptr_t, not EMACS_INT, where
3550 intptr_t is wide enough.
3551 * fringe.c (lookup_fringe_bitmap, get_logical_fringe_bitmap)
3552 (Fdefine_fringe_bitmap): Don't assume fixnum fits in int.
3553 (Ffringe_bitmaps_at_pos): Don't assume index fits in int.
3554 Check for fixnum out of range.
3555 * ftfont.c (ftfont_list): Don't assume index fits in int.
3556 Check that fixnums are in proper range for system types.
3557 (ftfont_shape_by_flt):
3558 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
d311d28c
PE
3559 * gnutls.c (emacs_gnutls_write, emacs_gnutls_read):
3560 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3561 (Fgnutls_error_fatalp, Fgnutls_error_string, Fgnutls_boot):
3562 Check that fixnums are in proper range for system types.
3563 * gnutls.h: Adjust decls to match defn changes elsewhere.
3564 * gtkutil.c (xg_dialog_run):
3565 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3566 (update_frame_tool_bar):
3567 Check that fixnums are in proper range for system types.
3568 * image.c (parse_image_spec): Redo count calculation to avoid overflow.
5895d7b9 3569 (lookup_image): Check that fixnums are in range for system types.
d311d28c
PE
3570 * indent.c (last_known_column, last_known_column_point):
3571 (current_column_bol_cache):
3572 (skip_invisible, current_column, check_display_width):
3573 (check_display_width, scan_for_column, current_column_1)
3574 (Findent_to, Fcurrent_indentation, position_indentation)
3575 (indented_beyond_p, Fmove_to_column, compute_motion):
3576 (Fcompute_motion, Fvertical_motion):
3577 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3578 (last_known_column_modified): Use EMACS_INT, not int.
3579 (check_display_width):
3580 (Fcompute_motion):
3581 Check that fixnums and floats are in proper range for system types.
3582 (compute_motion): Don't assume index or fixnum fits in int.
3583 (compute_motion, Fcompute_motion):
3584 Use int, not EMACS_INT, when it is wide enough.
3585 (vmotion): Omit local var start_hpos that is always 0; that way
3586 we don't need to worry about overflow in expressions involving it.
3587 * indent.h: Adjust decls to match defn changes elsewhere.
3588 (struct position):
3589 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3590 Use int, not EMACS_INT, where int is wide enough.
3591 Remove unused members ovstring_chars_done and tab_offset;
3592 all uses removed.
3593 * insdel.c (move_gap, move_gap_both, gap_left, gap_right)
3594 (adjust_markers_for_delete, adjust_markers_for_insert, adjust_point)
3595 (adjust_markers_for_replace, make_gap_larger, make_gap_smaller)
3596 (make_gap, copy_text, insert, insert_and_inherit)
3597 (insert_before_markers, insert_before_markers_and_inherit)
3598 (insert_1, count_combining_before, count_combining_after)
3599 (insert_1_both, insert_from_string)
3600 (insert_from_string_before_markers, insert_from_string_1)
3601 (insert_from_gap, insert_from_buffer, insert_from_buffer_1)
3602 (adjust_after_replace, adjust_after_insert, replace_range)
3603 (replace_range_2, del_range, del_range_1, del_range_byte)
3604 (del_range_both, del_range_2, modify_region)
3605 (prepare_to_modify_buffer, signal_before_change)
3606 (signal_after_change, Fcombine_after_change_execute):
3607 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3608 * intervals.c (traverse_intervals, rotate_right, rotate_left)
3609 (balance_an_interval, split_interval_right, split_interval_left)
3610 (find_interval, next_interval, update_interval)
3611 (adjust_intervals_for_insertion, delete_node, delete_interval)
3612 (interval_deletion_adjustment, adjust_intervals_for_deletion)
3613 (static_offset_intervals, offset_intervals)
3614 (merge_interval_right, merge_interval_left, make_new_interval)
3615 (graft_intervals_into_buffer, temp_set_point_both)
3616 (temp_set_point, set_point, adjust_for_invis_intang)
3617 (set_point_both, move_if_not_intangible, get_property_and_range)
3618 (get_local_map, copy_intervals, copy_intervals_to_string)
3619 (compare_string_intervals, set_intervals_multibyte_1):
3620 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3621 * intervals.h: Adjust decls to match defn changes elsewhere.
3622 (struct interval):
3623 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3624 * keyboard.c (this_command_key_count, this_single_command_key_start)
3625 (before_command_key_count, before_command_echo_length, echo_now)
3626 (echo_length, recursive_edit_1, Frecursive_edit, Ftrack_mouse)
3627 (command_loop_1, safe_run_hooks, read_char, timer_check_2)
3628 (menu_item_eval_property, read_key_sequence, Fread_key_sequence)
3629 (Fread_key_sequence_vector, Fexecute_extended_command, Fsuspend_emacs):
3630 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3631 (last_non_minibuf_size, last_point_position, echo_truncate)
3632 (command_loop_1, adjust_point_for_property, read_char, gen_help_event)
3633 (make_lispy_position, make_lispy_event, parse_modifiers_uncached)
3634 (parse_modifiers, modify_event_symbol, Fexecute_extended_command)
3635 (stuff_buffered_input):
3636 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3637 (last_auto_save, command_loop_1, read_char):
3638 Use EMACS_INT, not int, to avoid integer overflow.
3639 (record_char): Avoid overflow in total_keys computation.
3640 (parse_modifiers_uncached): Redo index calculation to avoid overflow.
3641 * keyboard.h: Adjust decls to match defn changes elsewhere.
3642 * keymap.c (Fdefine_key, Fcurrent_active_maps, accessible_keymaps_1)
3643 (Fkey_description, Fdescribe_vector, Flookup_key):
3644 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3645 (click_position): New function, to check that positions are in range.
3646 (Fcurrent_active_maps):
3647 (describe_command):
3648 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3649 (Faccessible_keymaps, Fkey_description):
3650 (preferred_sequence_p):
3651 Don't assume fixnum can fit into int.
3652 (Fkey_description): Use SAFE_ALLOCA_LISP, not alloca.
3653 Check for integer overflow in size calculations.
3654 (Ftext_char_description): Use CHECK_CHARACTER, not CHECK_NUMBER, to
3655 avoid mishandling large integers.
3656 * lisp.h: Adjust decls to match defn changes elsewhere.
3657 (ARRAY_MARK_FLAG, PSEUDOVECTOR_FLAG, struct Lisp_String)
3658 (struct vectorlike_header, struct Lisp_Subr, struct Lisp_Hash_Table)
3659 (struct Lisp_Marker):
3660 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3661 (clip_to_bounds): Now an inline function, moved here from editfns.c.
d311d28c
PE
3662 (GLYPH_CODE_P): Check for overflow in system types, subsuming the
3663 need for GLYPH_CODE_CHAR_VALID_P and doing proper checking ourselves.
3664 All callers changed.
3665 (GLYPH_CODE_CHAR, GLYPH_CODE_FACE):
3666 Assume the arg has valid form, since it always does.
3667 (TYPE_RANGED_INTEGERP): Avoid bug when checking against a wide
3668 unsigned integer system type.
3669 (CHECK_RANGED_INTEGER, CHECK_TYPE_RANGED_INTEGER): New macros.
3670 (struct catchtag, specpdl_size, SPECPDL_INDEX, USE_SAFE_ALLOCA):
3671 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3672 (struct catchtag): Use EMACS_INT, not int, since it may be a fixnum.
3673 (duration_to_sec_usec): New decl.
3674 * lread.c (read_from_string_index, read_from_string_index_byte)
3675 (read_from_string_limit, readchar, unreadchar, openp)
3676 (read_internal_start, read1, oblookup):
3677 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3678 (Fload, readevalloop, Feval_buffer, Feval_region):
3679 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3680 (openp): Check for out-of-range argument to 'access'.
3681 (read1): Use int, not EMACS_INT, where int is wide enough.
3682 Don't assume fixnum fits into int.
6efdadfd 3683 Fix off-by-one error that can read outside a buffer.
1ab7b8ac
PE
3684 (read_filtered_event): Use duration_to_sec_usec
3685 to do proper overflow checking on durations.
d311d28c
PE
3686 * macros.c (Fstart_kbd_macro): Use xpalloc to check for overflow
3687 in size calculation.
3688 (Fexecute_kbd_macro):
3689 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3690 * marker.c (cached_charpos, cached_bytepos, CONSIDER)
3691 (byte_char_debug_check, buf_charpos_to_bytepos, verify_bytepos)
3692 (buf_bytepos_to_charpos, Fset_marker, set_marker_restricted)
3693 (set_marker_both, set_marker_restricted_both, marker_position)
3694 (marker_byte_position, Fbuffer_has_markers_at):
3695 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3696 (Fset_marker, set_marker_restricted): Don't assume fixnum fits in int.
61b108cc 3697 * menu.c (ensure_menu_items): Rename from grow_menu_items.
d311d28c
PE
3698 It now merely ensures that the menu is large enough, without
3699 necessarily growing it, as this avoids some integer overflow issues.
3700 All callers changed.
3701 (keymap_panes, parse_single_submenu, Fx_popup_menu):
3702 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3703 (parse_single_submenu, Fx_popup_menu): Don't assume fixnum fits in int.
3704 Use SAFE_ALLOCA_LISP, not alloca.
3705 (find_and_return_menu_selection): Avoid unnecessary casts of pointers
3706 to EMACS_INT. Check that fixnums are in proper range for system types.
3707 * minibuf.c (minibuf_prompt_width, string_to_object)
3708 (Fminibuffer_contents, Fminibuffer_contents_no_properties)
3709 (Fminibuffer_completion_contents, Ftry_completion, Fall_completions):
3710 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3711 (get_minibuffer, read_minibuf_unwind):
3712 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3713 (read_minibuf): Omit unnecessary arg BACKUP_N, which is always nil;
3714 this simplifies overflow checking. All callers changed.
3715 (read_minibuf, Fread_buffer, Ftry_completion, Fall_completions)
3716 (Ftest_completion):
3717 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3718 * nsfns.m (check_ns_display_info): Don't assume fixnum fits in long.
3719 (x_set_menu_bar_lines, x_set_tool_bar_lines, Fx_create_frame):
3720 Check that fixnums are in proper range for system types.
3721 (Fx_create_frame, Fx_show_tip):
3722 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3723 * nsfont.m (ns_findfonts, nsfont_list_family):
3724 Don't assume fixnum fits in long.
3725 * nsmenu.m (ns_update_menubar, ns_menu_show, ns_popup_dialog):
3726 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3727 (ns_update_menubar): Use intptr_t, not EMACS_INT, when intptr_t is
3728 wide enough.
17fdb222 3729 * nsselect.m (ns_get_local_selection, clean_local_selection_data):
d311d28c
PE
3730 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3731 * print.c (print_buffer_size, print_buffer_pos, print_buffer_pos_byte)
3732 (PRINTDECLARE, PRINTPREPARE):
3733 (strout, print_string):
3734 (print, print_preprocess, print_check_string_charset_prop)
3735 (print_object):
3736 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3737 (PRINTDECLARE):
3738 (temp_output_buffer_setup, Fprin1_to_string, print_object):
3739 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3740 (PRINTPREPARE): Use int, not ptrdiff_t, where int is wide enough.
d311d28c 3741 (printchar, strout): Use xpalloc to catch size calculation overflow.
0fd11aa5 3742 (Fexternal_debugging_output): Don't overflow EMACS_INT->int conversion.
d311d28c
PE
3743 (print_error_message): Use SAFE_ALLOCA, not alloca.
3744 (print_object): Use int, not EMACS_INT, where int is wide enough.
a8b7caa3
PE
3745 (print_depth, new_backquote_output, print_number_index):
3746 Use ptrdiff_t, not int, where int might not be wide enough.
d311d28c
PE
3747 * process.c (Fdelete_process): Don't assume pid fits into EMACS_INT.
3748 (Fset_process_window_size, Fformat_network_address)
3749 (get_lisp_to_sockaddr_size, set_socket_option, Fmake_network_process)
d44287d4 3750 (sigchld_handler):
d311d28c 3751 Check that fixnums are in proper range for system types.
d44287d4 3752 (Fsignal_process): Simplify by avoiding a goto.
d83cf4cc
PE
3753 Check for process-ids out of pid_t range rather than relying on
3754 undefined behavior.
e4d81efc 3755 (process_tick, update_tick): Use EMACS_INT, not int.
d311d28c
PE
3756 (Fformat_network_address, read_process_output, send_process)
3757 (Fprocess_send_region, status_notify):
3758 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3759 (Fformat_network_address, Fmake_serial_process, Fmake_network_process)
3760 (wait_reading_process_output, read_process_output, exec_sentinel):
3761 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3762 (conv_lisp_to_sockaddr): Don't assume fixnums fit into int.
3763 (Faccept_process_output): Use duration_to_sec_usec to do proper
3764 overflow checking on durations.
dde14581
PE
3765 (emacs_get_tty_pgrp, Fprocess_running_child_p, process_send_signal):
3766 Don't assume pid_t fits in int.
02481186
PE
3767 * process.h (struct Lisp_Process): Members tick and update_tick
3768 are now of type EMACS_INT, not int.
b62b53e8
PE
3769 * puresize.h (PURESIZE_RATIO): Shrink this to 8/6 on 32-bit hosts
3770 configured --with-wide-int.
d311d28c
PE
3771 * scroll.c (calculate_scrolling, calculate_direct_scrolling)
3772 (line_ins_del): Use int, not EMACS_INT, where int is wide enough.
3773 * search.c (looking_at_1, string_match_1):
3774 (fast_string_match, fast_c_string_match_ignore_case)
3775 (fast_string_match_ignore_case, fast_looking_at, scan_buffer)
3776 (scan_newline, find_before_next_newline, search_command)
3777 (trivial_regexp_p, search_buffer, simple_search, boyer_moore)
3778 (set_search_regs, wordify):
3779 (Freplace_match):
3780 (Fmatch_data):
3781 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3782 (string_match_1, search_buffer, set_search_regs):
3783 (Fmatch_data):
3784 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3785 (wordify): Check for overflow in size calculation.
3786 (Freplace_match): Avoid potential buffer overflow in search_regs.start.
3787 (Fset_match_data): Don't assume fixnum fits in ptrdiff_t.
3788 Check that fixnums are in proper range for system types.
3789 * sound.c (struct sound_device)
3790 (wav_play, au_play, vox_write, alsa_period_size, alsa_write):
3791 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3792 (Fplay_sound_internal):
3793 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
eacd378d 3794 * syntax.c (struct lisp_parse_state, find_start_modiff)
d311d28c
PE
3795 (Finternal_describe_syntax_value, scan_lists, scan_sexps_forward):
3796 (Fparse_partial_sexp):
3797 Don't assume fixnums can fit in int.
3798 (struct lisp_parse_state, find_start_pos, find_start_value)
3799 (find_start_value_byte, find_start_begv)
3800 (update_syntax_table, char_quoted, dec_bytepos)
3801 (find_defun_start, prev_char_comend_first, back_comment):
3802 (scan_words, skip_chars, skip_syntaxes, forw_comment, Fforward_comment)
3803 (scan_lists, Fbackward_prefix_chars, scan_sexps_forward):
3804 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3805 (Finternal_describe_syntax_value): Check that match_lisp is a
3806 character, not an integer, since the code stuffs it into int.
3807 (scan_words, scan_sexps_forward):
3808 Check that fixnums are in proper range for system types.
3809 (Fforward_word):
3810 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3811 (scan_sexps_forward):
3812 Use CHARACTERP, not INTEGERP, since the value must fit into int.
3813 (Fparse_partial_sexp): Fix doc; element 8 is not ignored.
3814 * syntax.h: Adjust decls to match defn changes elsewhere.
3815 (struct gl_state_s):
3816 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
e4ecdc9c
PE
3817 (SETUP_SYNTAX_TABLE_FOR_OBJECT): Use PTRDIFF_MAX, not
3818 MOST_POSITIVE_FIXNUM.
d311d28c
PE
3819 * sysdep.c (wait_for_termination_1, wait_for_termination)
3820 (interruptible_wait_for_termination, mkdir):
3821 Don't assume pid_t fits in int; on 64-bit AIX pid_t is 64-bit.
3822 (emacs_read, emacs_write):
3823 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
225a2cff
PE
3824 (system_process_attributes): Don't assume uid_t, gid_t, EMACS_INT,
3825 and double all fit in int.
d311d28c
PE
3826 * term.c (set_tty_color_mode):
3827 Check that fixnums are in proper range for system types.
3828 * termhooks.h (struct input_event):
3829 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3830 * textprop.c (validate_interval_range, interval_of)
3831 (Fadd_text_properties, set_text_properties_1)
3832 (Fremove_text_properties, Fremove_list_of_text_properties)
3833 (Ftext_property_any, Ftext_property_not_all)
3834 (copy_text_properties, text_property_list, extend_property_ranges)
3835 (verify_interval_modification):
3836 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3837 (Fnext_single_char_property_change)
3838 (Fprevious_single_char_property_change):
3839 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
5895d7b9
PE
3840 (copy_text_properties):
3841 Check for integer overflow in index calculation.
d311d28c
PE
3842 * undo.c (last_boundary_position, record_point, record_insert)
3843 (record_delete, record_marker_adjustment, record_change)
3844 (record_property_change):
3845 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3846 (truncate_undo_list, Fprimitive_undo): Don't assume fixnum fits in int.
3847 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3848 * w32fns.c (Fx_create_frame, x_create_tip_frame, Fx_show_tip)
3849 (Fx_hide_tip, Fx_file_dialog):
3850 * w32menu.c (set_frame_menubar):
3851 Use ptrdiff_t, not int, for consistency with rest of code.
3852 * window.c (window_scroll_preserve_hpos, window_scroll_preserve_vpos)
3853 (select_window, Fdelete_other_windows_internal)
3854 (window_scroll_pixel_based, window_scroll_line_based)
3855 (Frecenter, Fset_window_configuration):
3856 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3857 (Fset_window_hscroll, run_window_configuration_change_hook)
3858 (set_window_buffer, temp_output_buffer_show, scroll_command)
5895d7b9 3859 (Fscroll_other_window, Frecenter):
d311d28c
PE
3860 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3861 (Fwindow_line_height, window_scroll, Fscroll_left, Fscroll_right):
3862 Don't assume fixnum fits in int.
3863 (Fset_window_scroll_bars):
3864 Check that fixnums are in proper range for system types.
3865 * xdisp.c (help_echo_pos, pos_visible_p, string_pos_nchars_ahead)
3866 (string_pos, c_string_pos, number_of_chars, init_iterator)
3867 (in_ellipses_for_invisible_text_p, init_from_display_pos)
3868 (compute_stop_pos, next_overlay_change, compute_display_string_pos)
3869 (compute_display_string_end, handle_face_prop)
5895d7b9
PE
3870 (face_before_or_after_it_pos, handle_invisible_prop)
3871 (handle_display_prop, handle_display_spec, handle_single_display_spec)
d311d28c
PE
3872 (display_prop_intangible_p, string_buffer_position_lim)
3873 (string_buffer_position, handle_composition_prop, load_overlay_strings)
3874 (get_overlay_strings_1, get_overlay_strings)
3875 (iterate_out_of_display_property, forward_to_next_line_start)
3876 (back_to_previous_visible_line_start, reseat, reseat_to_string)
3877 (get_next_display_element, set_iterator_to_next)
3878 (get_visually_first_element, compute_stop_pos_backwards)
3879 (handle_stop_backwards, next_element_from_buffer)
3880 (move_it_in_display_line_to, move_it_in_display_line)
3881 (move_it_to, move_it_vertically_backward, move_it_by_lines)
3882 (add_to_log, message_dolog, message_log_check_duplicate)
3883 (message2, message2_nolog, message3, message3_nolog
3884 (with_echo_area_buffer, display_echo_area_1, resize_mini_window_1)
3885 (current_message_1, truncate_echo_area, truncate_message_1)
3886 (set_message, set_message_1, store_mode_line_noprop)
3887 (hscroll_window_tree, debug_delta, debug_delta_bytes, debug_end_vpos)
3888 (text_outside_line_unchanged_p, check_point_in_composition)
3889 (reconsider_clip_changes)
3890 (redisplay_internal, set_cursor_from_row, try_scrolling)
3891 (try_cursor_movement, set_vertical_scroll_bar, redisplay_window)
3892 (redisplay_window, find_last_unchanged_at_beg_row)
3893 (find_first_unchanged_at_end_row, row_containing_pos, try_window_id)
3894 (trailing_whitespace_p, find_row_edges, display_line)
3895 (RECORD_MAX_MIN_POS, Fcurrent_bidi_paragraph_direction)
3896 (display_mode_element, store_mode_line_string)
3897 (pint2str, pint2hrstr, decode_mode_spec)
3898 (display_count_lines, display_string, draw_glyphs)
3899 (x_produce_glyphs, x_insert_glyphs)
3900 (rows_from_pos_range, mouse_face_from_buffer_pos)
3901 (fast_find_string_pos, mouse_face_from_string_pos)
3902 (note_mode_line_or_margin_highlight, note_mouse_highlight):
3903 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3904 (safe_call, init_from_display_pos, handle_fontified_prop)
3905 (handle_single_display_spec, load_overlay_strings)
3906 (with_echo_area_buffer, setup_echo_area_for_printing)
3907 (display_echo_area, echo_area_display)
3908 (x_consider_frame_title, prepare_menu_bars, update_menu_bar)
3909 (update_tool_bar, hscroll_window_tree, redisplay_internal)
5895d7b9
PE
3910 (redisplay_window, dump_glyph_row, display_mode_line)
3911 (Fformat_mode_line, decode_mode_spec, on_hot_spot_p):
43ad2e9a 3912 (handle_display_spec, display_prop_string_p):
d311d28c
PE
3913 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3914 (handle_single_display_spec, build_desired_tool_bar_string)
3915 (redisplay_tool_bar, scroll_window_tree, Fdump_glyph_matrix)
3916 (get_specified_cursor_type):
3917 Check that fixnums are in proper range for system types.
3918 (struct overlay_entry, resize_mini_window, Fdump_glyph_row)
3919 (Flookup_image_map):
3920 Don't assume fixnums fit in int.
3921 (compare_overlay_entries):
3922 Avoid mishandling comparisons due to subtraction overflow.
3923 (load_overlay_strings): Use SAFE_NALLOCA, not alloca.
3924 (last_escape_glyph_face_id, last_glyphless_glyph_face_id):
3925 (handle_tool_bar_click):
3926 Use int, not unsigned, since we prefer signed and the signedness
3927 doesn't matter here.
3928 (get_next_display_element, next_element_from_display_vector):
3929 Use int, not EMACS_INT, when int is wide enough.
3930 (start_hourglass): Use duration_to_sec_usec to do proper
3931 overflow checking on durations.
3932 * xfaces.c (Fbitmap_spec_p):
3933 Check that fixnums are in proper range for system types.
3934 (compare_fonts_by_sort_order):
3935 Avoid mishandling comparisons due to subtraction overflow.
3936 (Fx_family_fonts, realize_basic_faces):
3937 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3938 (Fx_family_fonts):
3939 Don't assume fixnum fits in int.
3940 Use SAFE_ALLOCA_LISP, not alloca.
3941 (merge_face_heights): Remove unnecessary cast to EMACS_INT.
3942 (Finternal_make_lisp_face): Don't allocate more than MAX_FACE_ID.
3943 (face_at_buffer_position, face_for_overlay_string)
3944 (face_at_string_position):
3945 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3946 (merge_faces): Use int, not EMACS_INT, where int is wide enough.
3947 * xfns.c (x_set_menu_bar_lines, x_set_tool_bar_lines, x_icon_verify)
3948 (Fx_show_tip):
3949 Check that fixnums are in proper range for system types.
3950 (Fx_create_frame, x_create_tip_frame, Fx_show_tip)
3951 (Fx_hide_tip, Fx_file_dialog, Fx_select_font):
3952 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3953 (Fx_change_window_property): Don't assume fixnums fit in int.
3954 * xfont.c (xfont_chars_supported):
3955 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3956 * xmenu.c (Fx_popup_dialog, set_frame_menubar)
3957 (create_and_show_popup_menu, create_and_show_dialog, xmenu_show):
3958 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3959 * xml.c (parse_region):
3960 * xrdb.c (magic_file_p):
3961 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3962 * xselect.c (TRACE1): Don't assume pid_t promotes to int.
3963 (x_get_local_selection, x_reply_selection_request)
3964 (x_handle_selection_request, wait_for_property_change):
3965 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3966 (selection_data_to_lisp_data): Use short, not EMACS_INT, where
3967 short is wide enough.
3968 (x_send_client_event): Don't assume fixnum fits in int.
3969 * xterm.c (x_x_to_emacs_modifiers):
3970 Don't assume EMACS_INT overflows nicely into int.
3971 (x_emacs_to_x_modifiers): Use EMACS_INT, not int, because values
3972 may come from Lisp.
3973 (handle_one_xevent): NATNUMP can eval its arg twice.
3974 (x_connection_closed):
3975 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3976 * xterm.h: Adjust decls to match defn changes elsewhere.
3977 (struct scroll_bar): Use struct vectorlike_header
3978 rather than rolling our own approximation.
3979 (SCROLL_BAR_VEC_SIZE): Remove; not used.
3980
c6574eb5
GM
39812012-05-25 Glenn Morris <rgm@gnu.org>
3982
3983 * lisp.mk (lisp): Update for more files being compiled now.
3984
e8d32c7e
SM
39852012-05-25 Stefan Monnier <monnier@iro.umontreal.ca>
3986
48def666
SM
3987 * lread.c: Remove `read_pure' which makes no difference.
3988 (read_pure): Remove var.
3989 (unreadpure): Remove function.
3990 (readevalloop): Don't call read_list with -1 flag.
3991 (read1, read_vector): Don't test read_pure any more.
3992 (read_list): Simplify.
3993
e8d32c7e
SM
3994 * fileio.c, character.h: Minor style tweaks.
3995
4b2addb7
DA
39962012-05-24 Dmitry Antipov <dmantipov@yandex.ru>
3997
3998 * window.h (clip_changed): Remove useless declaration.
3999
584461b2
JB
40002012-05-22 Juanma Barranquero <lekktu@gmail.com>
4001
4002 * makefile.w32-in: Follow-up to 2012-05-22T16:20:27Z!eggert@cs.ucla.edu.
4003 (TAGS, TAGS-gmake, CONFIG_H): Remove further references to m/intel386.h.
4004
34374650
PE
40052012-05-22 Paul Eggert <eggert@cs.ucla.edu>
4006
4007 Remove src/m/*.
4008 This directory predates autoconf and is no longer needed nowadays.
4009 Move its few remaining bits of functionality to where they're needed.
4010 * m/README, m/alpha.h, m/amdx86-64.h, m/ia64.h, m/ibmrs6000.h:
4011 * m/ibms390x.h, m/intel386.h, m/m68k.h, m/macppc.h, m/sparc.h:
4012 * m/template.h: Remove.
4013 * Makefile.in (M_FILE): Remove. All uses removed.
4014 * alloc.c (POINTERS_MIGHT_HIDE_IN_OBJECTS):
4015 * lisp.h (USE_LSB_TAG):
4016 * mem-limits.h (EXCEEDS_LISP_PTR):
4017 Use VAL_MAX, not VALBITS, in #if.
4018 * lisp.h (EMACS_INT_MAX): New macro, useful in #if.
4019 (EMACS_UINT): Define unconditionally now.
4020 (BITS_PER_CHAR, BITS_PER_SHORT, BITS_PER_INT, BITS_PER_LONG)
4021 (BITS_PER_EMACS_INT): New constants, replacing
4022 what used to be in config.h, but not useful in #if.
4023 (GCTYPEBITS, VALBITS): Define unconditionally, since m/* files don't
4024 define them any more.
4025 (VAL_MAX): New macro.
4026 (VALMASK): Use it.
4027 * puresize.h (PURESIZE_RATIO): Use EMACS_INT_MAX, not
4028 BITS_PER_EMACS_INT, in #if.
4029 * s/aix4-2.h (BROKEN_FIONREAD, BROKEN_SIGAIO, BROKEN_SIGPTY)
4030 (BROKEN_SIGPOLL): Move here from m/ibmrs6000.h, which was removed.
4031 * s/gnu-linux.h (ULIMIT_BREAK_VALUE) [__i386__]:
4032 * s/ms-w32.h (DATA_START):
4033 Move here from removed file m/intel386.h.
4034 * s/gnu.h (NLIST_STRUCT): Remove undef; 'configure' does this.
4035 * s/irix6-5.h (_LP64): Remove; lisp.h no longer needs this.
4036
261cb4bb
PE
40372012-05-21 Paul Eggert <eggert@cs.ucla.edu>
4038
4039 Assume C89 or later.
4040 * alloc.c, buffer.c, lisp.h: Replace POINTER_TYPE with void.
4041 * alloc.c (overrun_check_malloc, overrun_check_realloc, xmalloc)
4042 (xrealloc):
4043 * buffer.c (mmap_free_1, mmap_enlarge): Omit needless casts.
4044 * editfns.c, fns.c, gmalloc.c, insdel.c, sysdep.c, termcap.c (NULL):
4045 * textprop.c, tparam.c (NULL): Remove.
4046 * ralloc.c, vm-limit.c (POINTER): Assume void * works.
4047 * regex.c (SIGN_EXTEND_CHAR): Assume signed char works.
4048 * regex.h (_RE_ARGS): Remove. All uses rewritten to use prototypes.
4049 * unexelf.c (ElfBitsW): Assume c89 preprocessor or better.
4050 * xterm.c (input_signal_count): Assume volatile works.
4051
ff23cd9f
KB
40522012-05-21 Ken Brown <kbrown@cornell.edu>
4053
4054 * xgselect.c (xg_select): Fix first argument in call to 'select'
4055 (bug#11508).
4056
1b170bc6
KB
40572012-05-20 Ken Brown <kbrown@cornell.edu>
4058
4059 * gmalloc.c (_free_internal_nolock, _realloc_internal_nolock)
bd7239f5 4060 [CYGWIN]: Cast ptr to (char *) before comparing to _heapbase.
1b170bc6 4061
b2f4d39f
KB
40622012-05-19 Ken Brown <kbrown@cornell.edu>
4063
4064 * xfns.c (x_in_use): Remove `static' qualifier.
4065 * xterm.h (x_in_use): Declare.
4066 * xgselect.c: Include xterm.h.
4067 (xg_select): Test `x_in_use' instead of `inhibit_window_system'
4068 and `display_arg' (bug#9754).
4069
003fdae2
PE
40702012-05-19 Paul Eggert <eggert@cs.ucla.edu>
4071
9232a6d9
PE
4072 * s/ms-w32.h (HAVE_GETDOMAINNAME): Remove; not needed.
4073
003fdae2
PE
4074 * m/vax.h: Remove; no longer needed since HAVE_FTIME is being removed.
4075 * s/ms-w32.h (HAVE_FTIME): Remove; not needed.
4076
784b56e2
EZ
40772012-05-18 Eli Zaretskii <eliz@gnu.org>
4078
4079 Fix compilation with -DGLYPH_DEBUG=1 on MS-Windows.
4080
4081 * w32term.c [GLYPH_DEBUG]: Add prototype for x_check_font.
090bd7cb 4082 (x_check_font) [GLYPH_DEBUG]: New function, copied from xterm.c.
784b56e2
EZ
4083
4084 * w32fns.c (unwind_create_frame) [GLYPH_DEBUG]: Fix broken
4085 reference to image_cache->refcount.
4086 (x_create_tip_frame): Fix broken use of FRAME_IMAGE_CACHE.
4087
a0a79cde
JL
40882012-05-17 Juri Linkov <juri@jurta.org>
4089
4090 * search.c (Fword_search_regexp, Fword_search_backward)
4091 (Fword_search_forward, Fword_search_backward_lax)
4092 (Fword_search_forward_lax): Move functions to isearch.el
4093 (bug#10145, bug#11381).
4094
b0572523
PE
40952012-05-16 Paul Eggert <eggert@cs.ucla.edu>
4096
4097 * xgselect.c (xg_select): Just invoke 'select' if -nw (Bug#9754).
4098
9660f5fc
SM
40992012-05-15 Stefan Monnier <monnier@iro.umontreal.ca>
4100
4101 * lread.c (init_obarray): Declare Qt and Qnil as special.
4102
4374de83
GM
41032012-05-14 Glenn Morris <rgm@gnu.org>
4104
4105 * nsterm.m (ns_init_paths): Fix typo ("libexec" not "lib-exec").
985584ae 4106 Put "libexec" before "bin", for the sake of init_callproc_1.
4374de83 4107
dc44c39a
PE
41082012-05-14 Paul Eggert <eggert@cs.ucla.edu>
4109
078c97cb
PE
4110 * keyboard.c (kbd_buffer_get_event) [!HAVE_DBUS]: Omit unused local.
4111
dc44c39a
PE
4112 * unexaix.c: Port to more-recent AIX compilers.
4113 (report_error, report_error_1, make_hdr, copy_sym)
4114 (mark_x, adjust_lnnoptrs, unrelocate_symbols):
4115 Make arguments const char *, not char *, to avoid violations of C
4116 standard and to fix some AIX warnings reported by Gilles Pion.
4117
e18afed7 41182012-05-14 Eli Zaretskii <eliz@gnu.org>
ac268e67
EZ
4119
4120 * xdisp.c (handle_stop): Don't call get_overlay_strings_1 if we
4121 already have overlays loaded.
4122 (handle_single_display_spec): Before returning without displaying
4123 fringe bitmap, synchronize the bidi iterator with the main display
4124 iterator, by calling iterate_out_of_display_property.
4125 (iterate_out_of_display_property): Detect buffer iteration by
4126 testing that it->string is a Lisp string.
4127 (get_next_display_element): When the current object is exhausted,
4128 and there's something on it->stack, call set_iterator_to_next to
4129 proceed with what's on the stack, instead of returning zero.
4130 (set_iterator_to_next): If called at the end of a Lisp string,
4131 proceed to consider_string_end without incrementing string
4132 position. Don't increment display vector index past the end of
4133 the display vector. (Bug#11417)
c8fb9dc6
EZ
4134 (pos_visible_p): Don't report a position visible when move_it_to
4135 stopped at the last line of window, which happens to be scanned
4136 backwards by the bidi iteration. (Bug#11464)
ac268e67 4137
e18afed7 41382012-05-14 Eli Zaretskii <eliz@gnu.org>
82f9b393
EZ
4139
4140 * xdisp.c (handle_single_display_spec): Return 1 for left-margin
4141 and right-margin display specs even if the spec is invalid or we
61b108cc
SM
4142 are on a TTY, and thus unable to display on the fringes.
4143 That's because the text with the property will not be displayed anyway,
82f9b393
EZ
4144 so we need to signal to the caller that this is a "replacing"
4145 display spec. This fixes display when the spec is invalid or we
4146 are on a TTY.
4147
e18afed7 41482012-05-14 Paul Eggert <eggert@cs.ucla.edu>
297834cd
PE
4149
4150 * unexaix.c (make_hdr): Fix typo in prototype.
4151 This bug broke the build on AIX. Problem reported by Gilles Pion.
4152
9d0a235a
MA
41532012-05-14 Michael Albinus <michael.albinus@gmx.de>
4154
4155 * keyboard.c (kbd_buffer_get_event): Read special events also in
4156 batch mode. (Bug#11415)
4157
9e6b06ed
GM
41582012-05-12 Glenn Morris <rgm@gnu.org>
4159
4160 * ns.mk: Update for ns_appbindir no longer having trailing "/".
4161
c1a1d7a3
EZ
41622012-05-12 Eli Zaretskii <eliz@gnu.org>
4163
4164 * lisp.mk (lisp): Add newcomment.elc.
4165
3fe7cdc8
GM
41662012-05-12 Glenn Morris <rgm@gnu.org>
4167
4168 * Makefile.in (MKDIR_P): New, set by configure.
4169 * ns.mk (${ns_appdir}, ${ns_appbindir}Emacs): Use $MKDIR_P.
4170
53f7d2c0
PE
41712012-05-11 Paul Eggert <eggert@cs.ucla.edu>
4172
4173 Remove unused function hourglass_started.
4174 * dispextern.h (hourglass_started):
4175 * w32fns.c (hourglass_started):
4176 * xdisp.c (hourglass_started): Remove.
4177
75aafb17
JB
41782012-05-10 Juanma Barranquero <lekktu@gmail.com>
4179
4180 * makefile.w32-in ($(BLD)/gmalloc.$(O), $(BLD)/w32menu.$(O)):
4181 Update dependencies.
4182
12959e8e
PE
41832012-05-10 Paul Eggert <eggert@cs.ucla.edu>
4184
97107e2e
PE
4185 * xgselect.c (xg_select): Put maxfds+1 into a var.
4186 This is slightly clearer, and pacifies Ubuntu 12.04 gcc.
4187
12959e8e
PE
4188 * sound.c (DEFAULT_ALSA_SOUND_DEVICE): Define only if HAVE_ALSA.
4189
836d29b3
DA
41902012-05-10 Dave Abrahams <dave@boostpro.com>
4191
4192 * filelock.c (syms_of_filelock): New boolean create-lockfiles.
4193 (lock_file): If create_lockfiles is 0, do nothing. (Bug#11227)
4194
5cb67954
MA
41952012-05-09 Michael Albinus <michael.albinus@gmx.de>
4196
4197 * dbusbind.c (xd_registered_buses): New internal Lisp object.
4198 Rename all occurences of Vdbus_registered_buses to xd_registered_buses.
4199 (syms_of_dbusbind): Remove declaration of Vdbus_registered_buses.
4200 Initialize xd_registered_buses.
4201
3478ec45
PE
42022012-05-09 Paul Eggert <eggert@cs.ucla.edu>
4203
b263a6b0
PE
4204 Untag more efficiently if USE_LSB_TAG.
4205 This is based on a proposal by YAMAMOTO Mitsuharu in
4206 <http://lists.gnu.org/archive/html/emacs-devel/2008-01/msg01876.html>.
4207 For an admittedly artificial (nth 8000 longlist) benchmark on
4208 Fedora 15 x86-64, this yields a 25% CPU speedup. Also, it shrinks
4209 Emacs's overall text size by 1%.
4210 * lisp.h (XUNTAG): New macro.
4211 (XCONS, XVECTOR, XSTRING, XSYMBOL, XFLOAT, XMISC, XPROCESS, XWINDOW)
4212 (XTERMINAL, XSUBR, XBUFFER, XCHAR_TABLE, XSUB_CHAR_TABLE, XBOOL_VECTOR)
4213 (XSETTYPED_PSEUDOVECTOR, XHASH_TABLE, TYPED_PSEUDOVECTORP): Use it.
4214 * eval.c (Fautoload):
4215 * font.h (XFONT_SPEC, XFONT_ENTITY, XFONT_OBJECT):
4216 * frame.h (XFRAME): Use XUNTAG.
4217
3478ec45
PE
4218 Port recent dbusbind.c changes to 32-bit --with-wide-int.
4219 * dbusbind.c (xd_append_arg, xd_retrieve_arg, Fdbus_message_internal):
4220 Remove unportable assumptions about print widths of types like
4221 dbus_uint32_t.
4222 (xd_get_connection_address, Fdbus_init_bus): Cast Emacs integer to
4223 intptr_t when converting between pointer and integer, to avoid GCC
4224 warnings about wrong width.
4225
666b903b 42262012-05-09 Eli Zaretskii <eliz@gnu.org>
0d887c7d
EZ
4227
4228 * w32proc.c (new_child): Force Windows to reserve only 64KB of
4229 stack for each reader_thread, instead of defaulting to 8MB
4230 determined by the linker. This avoids failures in creating
4231 subprocesses on Windows 7, see the discussion in this thread:
4232 http://lists.gnu.org/archive/html/emacs-devel/2012-03/msg00119.html.
4233
b120cc17
JC
42342012-05-07 Jérémy Compostella <jeremy.compostella@gmail.com>
4235
4236 Fix up display of the *Minibuf-0* buffer in the mini window.
4237 * keyboard.c (read_char): Don't clear the echo area if there's no
4238 message to clear.
4239 * xdisp.c (redisplay_internal): Redisplay the mini window (with the
2fed2689 4240 contents of *Minibuf-0*) if there's no message displayed in its stead.
b120cc17 4241
9a4b36f8
MA
42422012-05-07 Michael Albinus <michael.albinus@gmx.de>
4243
4244 * dbusbind.c (XD_DEBUG_MESSAGE): Don't print message twice in
4245 batch mode.
4246
e5f9458f
CY
42472012-05-06 Chong Yidong <cyd@gnu.org>
4248
4249 * lisp.mk (lisp): Update.
4250
eceeb5fc 42512012-05-05 Jim Meyering <meyering@redhat.com>
bf98199c
JM
4252
4253 * w32font.c (fill_in_logfont): NUL-terminate a string (Bug#11372).
4254
71873e2b
SM
42552012-05-04 Stefan Monnier <monnier@iro.umontreal.ca>
4256
4257 * data.c (PUT_ERROR): New macro.
4258 (syms_of_data): Use it. Add new error type `user-error'.
4259 * undo.c (user_error): New function.
4260 (Fprimitive_undo): Use it.
4261 * print.c (print_error_message): Adjust print style for `user-error'.
4262 * keyboard.c (user_error): New function.
4263 (Fexit_recursive_edit, Fabort_recursive_edit): Use it.
4264
ab0fa4e4
PE
42652012-05-03 Paul Eggert <eggert@cs.ucla.edu>
4266
4267 Do not limit current-time-string to years 1000..9999.
4268 * editfns.c (TM_YEAR_IN_ASCTIME_RANGE): Remove.
4269 (Fcurrent_time_string): Support any year that is supported by the
4270 underlying localtime representation. Don't use asctime, as it
4271 has undefined behavior for years outside the range -999..9999.
4272
7ed806a7
PE
42732012-05-02 Paul Eggert <eggert@cs.ucla.edu>
4274
4275 Fix race conditions involving setenv, gmtime, localtime, asctime.
4276 Without this fix, interrupts could mess up code that uses these
4277 nonreentrant functions, since setting TZ invalidates existing
4278 tm_zone or tzname values, and since most of these functions return
4279 pointers to static storage.
4280 * editfns.c (format_time_string, Fdecode_time, Fencode_time)
4281 (Fcurrent_time_string, Fcurrent_time_zone, Fset_time_zone_rule):
4282 Grow the critical sections to include not just invoking
4283 localtime/gmtime, but also accessing these functions' results
4284 including their tm_zone values if any, and any related TZ setting.
4285 (format_time_string): Last arg is now struct tm *, not struct tm **,
71873e2b
SM
4286 so that the struct tm is saved in the critical section.
4287 All callers changed. Simplify allocation of initial buffer, partly
7ed806a7
PE
4288 motivated by the fact that memory allocation needs to be outside
4289 the critical section.
4290
0c16dfed
DA
42912012-05-02 Dmitry Antipov <dmantipov@yandex.ru>
4292
4293 * intervals.c (adjust_intervals_for_insertion): Initialize `newi'
4294 with RESET_INTERVAL.
4295
4296 * buffer.c (Fget_buffer_create, Fmake_indirect_buffer):
4297 Remove duplicated buffer name initialization.
4298
3f83ace8
JM
42992012-05-02 Jim Meyering <jim@meyering.net>
4300
4301 * xterm.c (x_term_init): Use memcpy instead of strncpy (Bug#11373).
4302
c7b8541e
JM
4303 * xfns.c (x_window): Use xstrdup (Bug#11375).
4304
90207a15 43052012-05-02 Eli Zaretskii <eliz@gnu.org>
2fa85638
EZ
4306
4307 * xdisp.c (pos_visible_p): If already at a newline from the
4308 display string before the 'while' loop, don't walk back the glyphs
4309 from it3.glyph_row. Solves assertion violation when the display
4310 string begins with a newline (egg.el). (Bug#11367)
4311
b593d6a9
AH
43122012-05-01 Stefan Monnier <monnier@iro.umontreal.ca>
4313
4314 * keyboard.c (Fexecute_extended_command, Vsuggest_key_bindings):
4315 Move to simple.el.
4316
4737362e
GM
43172012-05-01 Glenn Morris <rgm@gnu.org>
4318
99cf43f9
GM
4319 * syssignal.h: Remove reference to BROKEN_SIGINFO (last used in
4320 s/ptx4.h), BROKEN_SIGTSTP (last used in m/ustation.h, m/dpx2.h),
4321 and BROKEN_SIGURG (was in s/gnu-linux.h prior to 2008-02-10).
4322 All were removed before 23.1.
4323
9311dcff
GM
4324 * dispnew.c: Remove HAVE_LIBNCURSES test;
4325 it is always true on relevant platforms.
4326
4d5c6349
GM
4327 * Makefile.in (LD_SWITCH_X_SITE_RPATH):
4328 Rename from LD_SWITCH_X_SITE_AUX_RPATH.
4329
4737362e
GM
4330 * Makefile.in (LD_SWITCH_X_SITE_AUX): Remove; no longer used.
4331
74dd3a6b
AS
43322012-04-30 Andreas Schwab <schwab@linux-m68k.org>
4333
4334 * .gdbinit (xpr): Remove checks for no longer existing misc types.
4335 (xintfwd, xboolfwd, xobjfwd, xbufobjfwd, xkbobjfwd, xbuflocal):
4336 Remove.
4337
13c379ee
PE
43382012-04-28 Paul Eggert <eggert@cs.ucla.edu>
4339
4340 Do not avoid creating empty evaporating overlays (Bug#9642).
4341 * buffer.c (Fmove_overlay): Revert the change of 2012-04-23.
4342 That is, do not delete an evaporating overlay if it becomes
4343 empty after its bounds are adjusted to fit within its buffer.
4344 This fix caused other problems, and I'm reverting it until we get
4345 to the bottom of them.
4346
a8e7d6d7 43472012-04-27 Chong Yidong <cyd@gnu.org>
9be2fd9b
CY
4348
4349 * xselect.c (x_convert_selection): Initialize a pointer (Bug#11315).
4350
a8e7d6d7 43512012-04-27 Eli Zaretskii <eliz@gnu.org>
f0ee99a0
EZ
4352
4353 * xdisp.c (pos_visible_p): If the window start position is beyond
4354 ZV, start the display from buffer beginning. Prevents assertion
4355 violation in init_iterator when the minibuffer window is scrolled
4356 via the scroll bar.
4357
4358 * window.c (window_scroll_pixel_based): Likewise.
4359
a8e7d6d7 43602012-04-27 Chong Yidong <cyd@gnu.org>
9ec7751f
CY
4361
4362 * keymap.c (where_is_internal): Doc fix (Bug#10872).
4363
a8e7d6d7 43642012-04-27 Glenn Morris <rgm@gnu.org>
24c51a09
GM
4365
4366 * fileio.c (Fcopy_file, Fset_file_selinux_context):
4367 Ignore ENOTSUP failures from setfilecon functions. (Bug#11245)
4368
a8e7d6d7 43692012-04-27 Eli Zaretskii <eliz@gnu.org>
73055685 4370
b593d6a9
AH
4371 * dispnew.c (swap_glyph_pointers, copy_row_except_pointers):
4372 Don't overrun array limits of glyph row's used[] array. (Bug#11288)
73055685 4373
1c6900d9
EZ
43742012-04-26 Eli Zaretskii <eliz@gnu.org>
4375
4c3fa1d9
EZ
4376 * xdisp.c (IT_DISPLAYING_WHITESPACE): In addition to the loaded
4377 display element, check also the underlying string or buffer
4378 character. (Bug#11341)
4379
1c6900d9
EZ
4380 * w32menu.c: Include w32heap.h.
4381 (add_menu_item): If the call to AppendMenuW (via
4382 unicode_append_menu) fails, disable Unicode menus only if we are
4383 running on Windows 9X/Me.
4384
42bf8205
AS
43852012-04-24 Andreas Schwab <schwab@linux-m68k.org>
4386
4387 * .gdbinit (xpr): Handle USE_2_TAGS_FOR_INTS.
4388 (xgetint): Add missing shift for LSB tags.
4389
b1bac16e
MR
43902012-04-24 Martin Rudalics <rudalics@gmx.at>
4391
4392 * keyboard.c (read_char): Don't wipe echo area for select window
4393 events: These might get delayed via `mouse-autoselect-window'
4394 (Bug#11304).
4395
d69621cc
JB
43962012-04-24 Juanma Barranquero <lekktu@gmail.com>
4397
4398 * gnutls.c (init_gnutls_functions): Protect against (unlikely)
4399 manipulation of :loaded-from data.
4400
02fd101b
JB
44012012-04-23 Juanma Barranquero <lekktu@gmail.com>
4402
4403 * gnutls.c (init_gnutls_functions): The value of :loaded-from is
4404 now a cons (bug#11311).
4405
888bec30
PE
44062012-04-23 Paul Eggert <eggert@cs.ucla.edu>
4407
89a438bd
PE
4408 Do not create empty overlays with the evaporate property (Bug#9642).
4409 * buffer.c (Fmove_overlay): Delete an evaporating overlay
4410 if it becomes empty after its bounds are adjusted to fit within
4411 its buffer. Without this fix, in a nonempty buffer (let ((o
4412 (make-overlay 1 2))) (overlay-put o 'evaporate t) (move-overlay o 0 1))
4413 yields an empty overlay that has the evaporate property, which is
4414 not supposed to happen.
4415
1068fe4d
PE
4416 Fix minor GTK3 problems found by static checking.
4417 * emacsgtkfixed.c (EMACS_TYPE_FIXED, EMACS_FIXED, EmacsFixed)
4418 (EmacsFixedPrivate, EmacsFixedClass, struct _EmacsFixed)
4419 (struct _EmacsFixedClass, emacs_fixed_get_type):
4420 Move decls here from emacsgtkfixed.h, since they needn't be public.
4421 (emacs_fixed_get_type): Now static.
4422 (emacs_fixed_class_init): Omit unused local.
4423 (emacs_fixed_child_type): Remove; unused.
4424 * emacsgtkfixed.h (EMACS_TYPE_FIXED, EMACS_FIXED, EmacsFixed)
4425 (EmacsFixedPrivate, EmacsFixedClass, struct _EmacsFixed)
4426 (struct _EmacsFixedClass): Move to emacsgtkfixed.c.
4427 (EMACS_FIXED_CLASS, EMACS_IS_FIXED, EMACS_IS_FIXED_CLASS)
4428 (EMACS_FIXED_GET_CLASS): Remove; unused.
4429 * gtkutil.c (xg_create_frame_widgets) [!HAVE_GTK3]: Omit unused local.
4430
888bec30
PE
4431 * keyboard.c (handle_async_input): Define only if SYNC_INPUT || SIGIO.
4432 Problem reported by Juanma Barranquero for Windows -Wunused-function.
4433
de85e130
PE
44342012-04-22 Paul Eggert <eggert@cs.ucla.edu>
4435
d0baac98 4436 Modernize and clean up gmalloc.c to assume C89 (Bug#9119).
bd7239f5 4437 * gmalloc.c (_MALLOC_INTERNAL, _MALLOC_H, _PP, __ptr_t)
d0baac98
PE
4438 (__malloc_size_t, __malloc_ptrdiff_t):
4439 Remove. All uses removed, replaced by the definiens if needed,
4440 since we can assume C89 or better now.
4441 Include <stdint.h>, for PTRDIFF_MAX, uintptr_t.
4442 (protect_malloc_state, align, get_contiguous_space)
4443 (malloc_atfork_handler_prepare, malloc_atfork_handler_parent)
4444 (malloc_atfork_handler_child, malloc_enable_thread)
4445 (malloc_initialize_1, __malloc_initialize, morecore_nolock)
4446 (_malloc_internal_nolock, _malloc_internal, malloc, _malloc)
4447 (_free, _realloc, _free_internal_nolock, _free_internal, free, cfree)
4448 (special_realloc, _realloc_internal_nolock, _realloc_internal)
4449 (realloc, calloc, __default_morecore, memalign, valloc, checkhdr)
4450 (freehook, mallochook, reallochook, mabort, mcheck, mprobe):
4451 Define using prototypes, not old style.
4452 (align, _malloc_internal_nolock, _free_internal_nolock, memalign):
4453 Don't assume ptrdiff_t and uintptr_t are no wider than unsigned long.
4454 (align): Don't assume that signed integer overflow wraps around.
4455 Omit unused local var.
4456 (malloc_initialize_1, morecore_nolock, _malloc_internal_nolock)
4457 (_free_internal_nolock, memalign, mallochook, reallochook):
4458 Omit no-longer-needed casts.
4459 (valloc): Use getpagesize, not __getpagesize.
4460 (MAGICWORD, MAGICFREE): Now randomish size_t values, not 32-bit.
4461 (struct hdr): The 'magic' member is now size_t, not unsigned long.
4462
de85e130
PE
4463 * dbusbind.c (XD_DBUS_VALIDATE_OBJECT): Define only if needed.
4464
dcbf5805
MA
44652012-04-22 Michael Albinus <michael.albinus@gmx.de>
4466
4467 Move functions from C to Lisp. Make non-blocking method calls
4468 the default. Implement further D-Bus standard interfaces.
4469
4470 * dbusbind.c (DBUS_NUM_MESSAGE_TYPES): Declare.
4471 (QCdbus_request_name_allow_replacement)
4472 (QCdbus_request_name_replace_existing)
4473 (QCdbus_request_name_do_not_queue)
4474 (QCdbus_request_name_reply_primary_owner)
4475 (QCdbus_request_name_reply_in_queue)
4476 (QCdbus_request_name_reply_exists)
4477 (QCdbus_request_name_reply_already_owner): Move to dbus.el.
4478 (QCdbus_registered_serial, QCdbus_registered_method)
4479 (QCdbus_registered_signal): New Lisp objects.
4480 (XD_DEBUG_MESSAGE): Use sizeof.
4481 (XD_MESSAGE_TYPE_TO_STRING, XD_OBJECT_TO_STRING)
4482 (XD_DBUS_VALIDATE_BUS_ADDRESS, XD_DBUS_VALIDATE_OBJECT)
4483 (XD_DBUS_VALIDATE_BUS_NAME, XD_DBUS_VALIDATE_PATH)
4484 (XD_DBUS_VALIDATE_INTERFACE, XD_DBUS_VALIDATE_MEMBER): New macros.
4485 (XD_CHECK_DBUS_SERIAL): Rename from CHECK_DBUS_SERIAL_GET_SERIAL.
4486 (xd_signature, xd_append_arg): Allow float for integer types.
4487 (xd_get_connection_references): New function.
b593d6a9
AH
4488 (xd_get_connection_address): Rename from xd_initialize.
4489 Return cached address.
dcbf5805
MA
4490 (xd_remove_watch): Do not unset $DBUS_SESSION_BUS_ADDRESS.
4491 (xd_close_bus): Rename from Fdbus_close_bus. Not needed on Lisp
4492 level.
4493 (Fdbus_init_bus): New optional arg PRIVATE. Cache address.
9a4b36f8 4494 Return number of refcounts.
dcbf5805
MA
4495 (Fdbus_get_unique_name): Make stronger parameter check.
4496 (Fdbus_message_internal): New defun.
4497 (Fdbus_call_method, Fdbus_call_method_asynchronously)
4498 (Fdbus_method_return_internal, Fdbus_method_error_internal)
4499 (Fdbus_send_signal, Fdbus_register_service)
4500 (Fdbus_register_signal, Fdbus_register_method): Move to dbus.el.
4501 (xd_read_message_1): Obey new structure of Vdbus_registered_objects.
4502 (xd_read_queued_messages): Obey new structure of Vdbus_registered_buses.
4503 (Vdbus_compiled_version, Vdbus_runtime_version)
4504 (Vdbus_message_type_invalid, Vdbus_message_type_method_call)
4505 (Vdbus_message_type_method_return, Vdbus_message_type_error)
4506 (Vdbus_message_type_signal): New defvars.
b593d6a9
AH
4507 (Vdbus_registered_buses, Vdbus_registered_objects_table):
4508 Adapt docstring.
dcbf5805 4509
52828e02
PE
45102012-04-22 Paul Eggert <eggert@cs.ucla.edu>
4511
da05bc4c
PE
4512 Fix GC_MALLOC_CHECK debugging output on 64-bit hosts.
4513 * alloc.c (emacs_blocked_malloc) [GC_MALLOC_CHECK]:
4514 Do not assume ptrdiff_t is the same width as 'int'.
4515
52828e02
PE
4516 * alloc.c: Handle unusual debugging option combinations.
4517 (GC_CHECK_MARKED_OBJECTS): Undef if ! GC_MARK_STACK,
4518 since the two debugging options are incompatible.
4519 (GC_MALLOC_CHECK): Similarly, undef if GC_CHECK_MARKED_OBJECTS
4520 is defined.
4521 (mem_init, mem_insert, mem_insert_fixup):
4522 Define if GC_MARK_STACK || GC_MALLOC_CHECK.
4523 (NEED_MEM_INSERT): Remove; no longer needed.
4524
f01769f9
LL
45252012-04-22 Leo Liu <sdl.web@gmail.com>
4526
4527 * sysdep.c (list_system_processes): Support Darwin (Bug#5725).
4528
5790543d
PE
45292012-04-22 Paul Eggert <eggert@cs.ucla.edu>
4530
4531 * sysdep.c [__FreeBSD__]: Minor cleanups.
4532 (list_system_processes, system_process_attributes) [__FreeBSD__]:
4533 Use Emacs indenting style more consistently. Avoid some casts.
4534 Use 'double' consistently rather than mixing 'float' and 'double'.
4535
b91b7e4d
EW
45362012-04-21 Eduard Wiebe <usenet@pusto.de>
4537
b593d6a9
AH
4538 * sysdep.c (list_system_processes, system_process_attributes):
4539 Add implementation for FreeBSD (Bug#5243).
b91b7e4d 4540
6114eb15
AS
45412012-04-21 Andreas Schwab <schwab@linux-m68k.org>
4542
4543 * lisp.mk (lisp): Update.
4544
2f38dff7
PE
45452012-04-20 Paul Eggert <eggert@cs.ucla.edu>
4546
4547 * keyboard.c (process_pending_signals): Define only if SYNC_INPUT.
4548 It is never used otherwise.
4549
4ae29f89
SM
45502012-04-20 Stefan Monnier <monnier@iro.umontreal.ca>
4551
4552 * print.c (print_preprocess): Only check print_depth if print-circle
4553 is nil.
4554 (print_object): Check for cycles even when print-circle is nil and
4555 print-gensym is t, but only check print_depth if print-circle is nil.
4556
f30d612a
CY
45572012-04-20 Chong Yidong <cyd@gnu.org>
4558
4559 * process.c (wait_reading_process_output): If EIO occurs on a pty,
4560 set the status to "failed" and ensure that sentinel is run.
4561
c07a4c0b 45622012-04-20 Glenn Morris <rgm@gnu.org>
016a35df
GM
4563
4564 * process.c (Fset_process_inherit_coding_system_flag)
4565 (Fset_process_query_on_exit_flag): Doc fix (mention return value).
4373fd43 4566 (Fmake_network_process, Fmake_serial_process): Doc fix.
016a35df 4567
c07a4c0b 45682012-04-20 Eli Zaretskii <eliz@gnu.org>
20a68157
EZ
4569
4570 * xdisp.c (string_buffer_position_lim): Limit starting position to
4571 BEGV.
4572 (set_cursor_from_row): If called for a mode-line or header-line
4573 row, return zero immediately.
4574 (try_cursor_movement): If inside continuation line, don't back up
4ae29f89
SM
4575 farther than the first row after the header line, if any.
4576 Don't consider the header-line row as "partially visible", even if
20a68157
EZ
4577 MATRIX_ROW_PARTIALLY_VISIBLE_P returns non-zero. (Bug#11261)
4578
c07a4c0b 45792012-04-20 Atsuo Ohki <ohki@gssm.otsuka.tsukuba.ac.jp> (tiny change)
ad3a2b41 4580
4ae29f89
SM
4581 * lread.c (lisp_file_lexically_bound_p): Fix hang at ";-*-\n"
4582 (bug#11238).
ad3a2b41 4583
c07a4c0b 45842012-04-20 Teodor Zlatanov <tzz@lifelogs.com>
6c94c34f 45852012-04-18 Paul Eggert <eggert@cs.ucla.edu>
ae6e112d
PE
4586
4587 configure: new option --enable-gcc-warnings (Bug#11207)
4588 * Makefile.in (C_WARNINGS_SWITCH): Remove.
4589 (WARN_CFLAGS, WERROR_CFLAGS): New macros.
4590 (ALL_CFLAGS): Use new macros rather than old.
4591 * process.c: Ignore -Wstrict-overflow to work around GCC bug 52904.
4592 * regex.c: Ignore -Wstrict-overflow. If !emacs, also ignore
4593 -Wunused-but-set-variable, -Wunused-function, -Wunused-macros,
4594 -Wunused-result, -Wunused-variable. This should go away once
4595 the Emacs and Gnulib regex code is merged.
4596 (xmalloc, xrealloc): Now static.
4597
aba027e8
PE
45982012-04-17 Paul Eggert <eggert@cs.ucla.edu>
4599
4600 * dired.c (Fsystem_groups): Remove unused local.
4601
e5a36063
GM
46022012-04-17 Glenn Morris <rgm@gnu.org>
4603
4604 * dired.c (Fsystem_users): Doc fix.
4605
316411f0
DA
46062012-04-17 Dmitry Antipov <dmantipov@yandex.ru>
4607
4608 * dired.c (Fsystem_users, Fsystem_groups): New functions. (Bug#7900)
4609 (syms_of_dired): Add them.
4610
9426aba4
PE
46112012-04-16 Paul Eggert <eggert@cs.ucla.edu>
4612
b62a57be
PE
4613 Fix minor alloc.c problems found by static checking.
4614 * alloc.c (_malloc_internal, _free_internal) [!DOUG_LEA_MALLOC]:
4615 New extern decls, to avoid calling undeclared functions.
4616 (dont_register_blocks): Define if ((!SYSTEM_MALLOC && !SYNC_INPUT)
4617 && GC_MALLOC_CHECK), not if ((GC_MARK_STACK || defined
4618 GC_MALLOC_CHECK) && GC_MALLOC_CHECK), to match when it's used.
4619 (NEED_MEM_INSERT): New macro.
4620 (mem_insert, mem_insert_fixup) [!NEED_MEM_INSERT]: Remove; unused.
4b5afbb0 4621 Remove one incorrect comment and fix another.
b62a57be 4622
3539f31f
PE
4623 Fix minor ralloc.c problems found by static checking.
4624 See http://lists.gnu.org/archive/html/emacs-devel/2011-12/msg00720.html
4625 * ralloc.c (ALIGNED, ROUND_TO_PAGE, HEAP_PTR_SIZE)
4626 (r_alloc_size_in_use, r_alloc_freeze, r_alloc_thaw): Remove; unused.
4627 (r_alloc_sbrk): Now static.
4628
a041960a
PE
4629 Improve ralloc.c interface checking.
4630 See http://lists.gnu.org/archive/html/emacs-devel/2011-12/msg00720.html
4631 * buffer.c (ralloc_reset_variable, r_alloc, r_re_alloc)
4632 (r_alloc_free) [REL_ALLOC]: Move decls from here ...
4633 * lisp.h (r_alloc, r_alloc_free, r_re_alloc, r_alloc_reset_variable)
4634 [REL_ALLOC]: ... to here, to check interface.
4635 * m/ia64.h (r_alloc, r_alloc_free) [REL_ALLOC && !_MALLOC_INTERNAL]:
4636 Remove decls. This fixes an "It stinks!".
4637
9426aba4
PE
4638 * alloc.c (which_symbols): Fix alignment issue / type clash.
4639
d55c12ed
AS
46402012-04-15 Andreas Schwab <schwab@linux-m68k.org>
4641
4642 * lisp.h (struct Lisp_Symbol): Remove explicit padding.
4643 (struct Lisp_Misc_Any): Likewise.
4644 (struct Lisp_Free): Likewise.
4645 * alloc.c (union aligned_Lisp_Symbol): Define.
4646 (SYMBOL_BLOCK_SIZE, struct symbol_block): Use union
4647 aligned_Lisp_Symbol instead of struct Lisp_Symbol.
4648 (union aligned_Lisp_Misc): Define.
4649 (MARKER_BLOCK_SIZE, struct marker_block): Use union
4650 aligned_Lisp_Misc instead of union Lisp_Misc.
4ae29f89 4651 (Fmake_symbol, allocate_misc, gc_sweep): Adjust.
d55c12ed 4652
b948ce8b
PE
46532012-04-14 Paul Eggert <eggert@cs.ucla.edu>
4654
4655 Make GC_MAKE_GCPROS_NOOPS the default (Bug#9926).
4656 * lisp.h (GC_MARK_STACK): Default to GC_MAKE_GCPROS_NOOPS.
4657 * s/cygwin.h, s/darwin.h, s/freebsd.h, s/gnu.h, s/irix6-5.h, s/msdos.h:
4658 * s/netbsd.h, s/sol2-6.h:
4659 Remove definition of GC_MARK_STACK, since the default now works.
4660 * s/aix4-2.h, s/hpux10-20.h, s/unixware.h:
4661 Define GC_MARK_STACK to GC_USE_GCPROS_AS_BEFORE, since that's
4662 no longer the default.
4663 * s/gnu-linux.h (GC_MARK_STACK): Adjust to change in default.
4664
35dc09a1 46652012-04-14 Atsuo Ohki <ohki@gssm.otsuka.tsukuba.ac.jp> (tiny change)
ad3a2b41 4666
35dc09a1
GM
4667 * lread.c (lisp_file_lexically_bound_p):
4668 Fix hang at ";-*-\n" (bug#11238).
ad3a2b41 4669
35dc09a1
GM
46702012-04-14 Eli Zaretskii <eliz@gnu.org>
4671
4672 * xdisp.c (find_last_unchanged_at_beg_row): Don't consider a row
4673 "unchanged" if its end.pos is beyond ZV. (Bug#11199)
4674
46752012-04-14 Jan Djärv <jan.h.d@swipnet.se>
4676
4677 * nsterm.m (constrainFrameRect): Always constrain when there is only
4678 one screen (Bug#10962).
4679
bcd86815
KB
46802012-04-13 Ken Brown <kbrown@cornell.edu>
4681
4682 * s/cygwin.h (PTY_OPEN): Don't try to close a bogus file descriptor.
4683
c25df26e
RT
46842012-04-13 Reuben Thomas <rrt@sc3d.org>
4685
4686 * indent.c (Fmove_to_column): Change interactive spec (Bug#739).
4687
0fc59f1e
DC
46882012-04-11 Daniel Colascione <dancol@dancol.org>
4689
4690 * s/cygwin.h: The vfork the #define in cygwin.h was protecting
4691 against is gone. It's better to use vfork now so that when Cygwin
4692 gains a new, working vfork, we use it automatically (bug#10398).
4693
de8c03dc
SM
46942012-04-11 Stefan Monnier <monnier@iro.umontreal.ca>
4695
4696 * window.c (save_window_save): Obey window-point-insertion-type.
4697
2f097256
GM
46982012-04-11 Glenn Morris <rgm@gnu.org>
4699
4700 * Makefile.in (GNUSTEP_CFLAGS): Rename from C_SWITCH_X_SYSTEM.
4701
453b951e
SM
47022012-04-11 Stefan Monnier <monnier@iro.umontreal.ca>
4703
4704 * alloc.c (lisp_align_malloc): Remove unneeded prototype.
4705
75f1671a 47062012-04-10 Jason S. Cornez <jcornez@ravenpack.com> (tiny change)
6bbef4e5
JC
4707
4708 * keyboard.c: Override inhibit-quit after the third C-g (bug#6585).
4709 (force_quit_count): New var.
4710 (handle_interrupt): Use it.
4711
2a8ce227
JB
47122012-04-10 Juanma Barranquero <lekktu@gmail.com>
4713
4714 * w32.c (w32_delayed_load): Record the full path of the library
4715 being loaded (bug#10424).
4716
935396c0
GM
47172012-04-09 Glenn Morris <rgm@gnu.org>
4718
05920a43
GM
4719 * doc.c (Fsnarf_documentation): Check variables, functions are bound,
4720 not just in the obarray, before snarfing them. (Bug#11036)
4721
935396c0
GM
4722 * Makefile.in ($(leimdir)/leim-list.el):
4723 Pass EMACS rather than BUILT_EMACS.
4724
a18ecafa
TZ
47252012-04-09 Teodor Zlatanov <tzz@lifelogs.com>
4726
4727 * process.c (make_process):
4728 * process.h: Add integer `gnutls_handshakes_tried' member to
4729 process struct.
4730
6bbef4e5
JC
4731 * gnutls.h: Add `GNUTLS_EMACS_HANDSHAKES_LIMIT' upper limit.
4732 Add convenience `GNUTLS_LOG2i' macro.
a18ecafa
TZ
4733
4734 * gnutls.c (gnutls_log_function2i): Convenience log function.
4735 (emacs_gnutls_read): Use new log functions,
4736 `gnutls_handshakes_tried' process member, and
4737 `GNUTLS_EMACS_HANDSHAKES_LIMIT' to limit the number of handshake
4738 attempts per process (connection).
4739
b4d3bc10
CY
47402012-04-09 Chong Yidong <cyd@gnu.org>
4741
4742 * eval.c (Fuser_variable_p, user_variable_p_eh)
4743 (lisp_indirect_variable): Functions deleted.
4744 (Fdefvar): Caller changed.
4745
4746 * callint.c (Finteractive, Fcall_interactively):
4747 * minibuf.c (Fread_variable): Callers changed.
4748
70f4d973
EZ
47492012-04-09 Eli Zaretskii <eliz@gnu.org>
4750
4751 * xdisp.c (set_cursor_from_row): If the display string appears in
4752 the buffer at position that is closer to point than the position
4753 after the display string, display the cursor on the first glyph of
4754 the display string. Fixes cursor display when a 'display' text
4755 property immediately follows invisible text. (Bug#11094)
4756
cb3c2e3e
PE
47572012-04-09 Paul Eggert <eggert@cs.ucla.edu>
4758
4759 composite.c: use 'double' consistently
4760 * composite.c (get_composition_id): Use 'double' consistently
4761 instead of converting 'float' to 'double' and vice versa; this is
4762 easier to understand and avoids a GCC warning.
4763
fd06db5d
GM
47642012-04-09 Glenn Morris <rgm@gnu.org>
4765
50fe702a
GM
4766 * Makefile.in: Generate leim-list with bootstrap-emacs, in
4767 preparation for dumping it with emacs. (Bug#4789)
4768 (leimdir): New variable.
4769 ($(leimdir)/leim-list.el): New rule.
4770 (emacs$(EXEEXT)): Depend on leim-list.el.
4771
fd06db5d
GM
4772 * buffer.c (Qucs_set_table_for_input): Remove. (Bug#9821)
4773 (Fget_buffer_create): Don't call Qucs_set_table_for_input.
4774 (init_buffer_once, syms_of_buffer): Remove Qucs_set_table_for_input.
4775
55c131ee
AS
47762012-04-08 Andreas Schwab <schwab@linux-m68k.org>
4777
4778 * lisp.h (struct Lisp_Symbol): Add explicit padding to ensure
4779 proper alignment.
4780
9209588f
JB
47812012-04-07 Juanma Barranquero <lekktu@gmail.com>
4782
4783 * xml.c (init_libxml2_functions) [WINDOWSNT]:
4784 Remove unused local variable.
4785
e3fb2efb
PE
47862012-04-07 Paul Eggert <eggert@cs.ucla.edu>
4787
4788 Avoid unnecessary pointer scanning in garbage collection (Bug#10780).
4789 * alloc.c (POINTERS_MIGHT_HIDE_IN_OBJECTS): New macro.
4790 (mark_memory): Mark Lisp_Objects only if pointers might hide in
4791 objects, as mark_maybe_pointer will catch them otherwise.
4792 (GC_LISP_OBJECT_ALIGNMENT): Remove; no longer needed.
4793 * s/gnu-linux.h (GC_LISP_OBJECT_ALIGNMENT) [__mc68000__]: Likewise.
4794
b5385551
PE
47952012-04-07 Paul Eggert <eggert@cs.ucla.edu>
4796
4797 Fix typo that broke non-Windows builds.
4798 * xml.c (libxml2_loaded_p) [!!WINDOWSNT]: 'inine' -> 'inline'.
4799
9078ead6
EZ
48002012-04-07 Eli Zaretskii <eliz@gnu.org>
4801
4802 Support building on MS-Windows with libxml2.
4803
4804 * makefile.w32-in (OBJ2): Add xml.$(O).
4805 (GLOBAL_SOURCES): Add xml.c.
4806 ($(BLD)/xml.$(O)): New dependency list.
4807
4808 * xml.c (DEF_XML2_FN, LOAD_XML2_FN) [WINDOWSNT]: New macros.
4809 (fn_htmlReadMemory, fn_xmlReadMemory, fn_xmlDocGetRootElement)
4810 (fn_xmlFreeDoc, fn_xmlCleanupParser, fn_xmlCheckVersion)
4811 [!WINDOWSNT]: New macros.
4812 (init_libxml2_functions, libxml2_loaded_p): New functions.
4813 (parse_region): Call fn_xmlCheckVersion instead of using the macro
4814 LIBXML_TEST_VERSION. Call libxml2 functions via the fn_* macros.
4815 (xml_cleanup_parser): New function, export for fn_xmlCleanupParser.
4816 Calls xmlCleanupParser only if libxml2 was loaded (or statically
4817 linked in).
6bbef4e5
JC
4818 (Flibxml_parse_html_region, Flibxml_parse_xml_region):
4819 Call init_libxml2_functions before calling libxml2 functions.
9078ead6
EZ
4820 (syms_of_xml) <Qlibxml2_dll>: DEFSYM it.
4821
4822 * emacs.c: Don't include libxml/parser.h.
4823 (shut_down_emacs): Call xml_cleanup_parser, instead of calling
4824 xmlCleanupParser directly.
4825
4826 * lisp.h [HAVE_LIBXML2]: Add prototype for xml_cleanup_parser.
4827
3811fdf3
EZ
48282012-04-07 Eli Zaretskii <eliz@gnu.org>
4829
4830 * indent.c (Fvertical_motion): If there is a display string at
4831 point, use it.vpos to compute how many lines to backtrack after
4832 move_it_to point. (Bug#11133)
4833
2f8e16b2
EZ
48342012-04-06 Eli Zaretskii <eliz@gnu.org>
4835
4836 * buffer.h (FETCH_CHAR, FETCH_MULTIBYTE_CHAR):
4837 * character.h (STRING_CHAR, STRING_CHAR_AND_LENGTH): Add comments
4838 about subtle differences between FETCH_CHAR* and STRING_CHAR*
4839 macros related to unification of CJK characters. For the details,
4840 see the discussion following the message here:
4841 http://debbugs.gnu.org/cgi/bugreport.cgi?bug=11073#14.
4842
3d439cd1
CY
48432012-04-04 Chong Yidong <cyd@gnu.org>
4844
4845 * keyboard.c (Vdelayed_warnings_list): Doc fix.
4846
8bc53d00
EZ
48472012-04-01 Eli Zaretskii <eliz@gnu.org>
4848
4849 * w32menu.c (simple_dialog_show, add_menu_item): Use SAFE_ALLOCA
4850 instead of alloca. (Bug#11138)
4851
3b0512a3
AS
48522012-04-01 Andreas Schwab <schwab@linux-m68k.org>
4853
4854 * w32menu.c (is_simple_dialog): Properly check lisp types.
4855 (Bug#11141)
4856
8427ddd2
EZ
48572012-03-31 Eli Zaretskii <eliz@gnu.org>
4858
979022ef
EZ
4859 * xdisp.c (move_it_by_lines): When DVPOS is positive, and the
4860 position we get to after a call to move_it_to fails the
4861 IS_POS_VALID_AFTER_MOVE_P test, move to the next buffer position
4862 only if we wind up in a string from display property. (Bug#11063)
4863
a6b1c7cc
EZ
4864 * window.c (Fdelete_other_windows_internal): Invalidate the row
4865 and column information about mouse highlight, so that redisplay
4866 restores it after reallocating the glyph matrices. (Bug#7464)
4867
8427ddd2
EZ
4868 * xdisp.c (set_cursor_from_row): If `cursor' property on a display
4869 string comes from a `display' text property, use the buffer
4870 position of that property as if we actually saw that position in
4871 the row's glyphs.
697ba24b
EZ
4872 (move_it_by_lines): Remove the assertion that
4873 "it->current_x == 0 && it->hpos == 0" which can be legitimately
4874 violated when there's a before-string at the beginning of a line.
4875 (Bug#11063)
8427ddd2 4876
65a0a738
EZ
48772012-03-30 Eli Zaretskii <eliz@gnu.org>
4878
4879 * xdisp.c (append_space_for_newline): If the default face was
4880 remapped, use the remapped face for the appended newline.
4881 (extend_face_to_end_of_line): Use the remapped default face for
4882 extending the face to the end of the line.
4883 (display_line): Call extend_face_to_end_of_line when the default
4884 face was remapped. (Bug#11068)
4885
581355cc
EZ
48862012-03-29 Eli Zaretskii <eliz@gnu.org>
4887
4888 * s/ms-w32.h: Discourage from defining HAVE_GETCWD.
4889
e8fc049f
SM
48902012-03-28 Stefan Monnier <monnier@iro.umontreal.ca>
4891
4892 * keyboard.c (safe_run_hooks_error): Don't unquote strings.
4893
4fb9a543
GM
48942012-03-27 Glenn Morris <rgm@gnu.org>
4895
4896 * search.c (Fword_search_backward_lax, Fword_search_forward_lax):
4897 Doc fixes.
4898
679910f1
KH
48992012-03-26 Kenichi Handa <handa@m17n.org>
4900
4901 * dispextern.h (struct glyph): Fix previous change. Change the
4902 bit length of glyphless.ch to 25 (Bug#11082).
4903
90d49b7f
CY
49042012-03-26 Chong Yidong <cyd@gnu.org>
4905
4906 * keyboard.c (Vselection_inhibit_update_commands): New variable.
4907 (command_loop_1): Use it; inhibit selection update for
4908 handle-select-window too (Bug#8996).
4909
f514f6f0
FP
49102012-03-25 Fabrice Popineau <fabrice.popineau@supelec.fr>
4911
e8fc049f 4912 * w32heap.c (_heap_init, _heap_term): Remove dead MSVC-specific code.
f514f6f0 4913
bf43fa51
KH
49142012-03-25 Kenichi Handa <handa@m17n.org>
4915
4916 * dispextern.h (struct glyph): Change the bit length of
4917 glyphless.ch to 22 to make the member glyphless fit in 32 bits.
4918
8a0c01dd
EZ
49192012-03-24 Eli Zaretskii <eliz@gnu.org>
4920
4921 * s/ms-w32.h (tzname): Include time.h before redirecting to
4922 _tzname. Fixes the MSVC build. (Bug#9960)
4923
7d1c3a76
AS
49242012-03-24 Andreas Schwab <schwab@linux-m68k.org>
4925
8ed79523
AS
4926 * xdisp.c (produce_glyphless_glyph): Limit length of acronym to 6
4927 characters.
4928
7d1c3a76
AS
4929 * xterm.c (XTread_socket): Only modify handling_signal if
4930 !SYNC_INPUT. (Bug#11080)
4931
e99a9b8b
EZ
49322012-03-23 Eli Zaretskii <eliz@gnu.org>
4933
4934 * bidi.c (bidi_fetch_char): Use STRING_CHAR_AND_LENGTH instead of
4935 FETCH_MULTIBYTE_CHAR followed by CHAR_BYTES. Prevents crashes
4936 when fetching a multibyte character consumes more bytes than
4937 CHAR_BYTES returns, due to unification of CJK characters in
4938 string_char. (Bug#11073)
4939
5063c0e1
TN
49402012-03-23 Troels Nielsen <bn.troels@gmail.com> (tiny change)
4941
4942 * process.c (wait_reading_process_output): Handle pty disconnect
4943 by refraining from sending oneself a SIGCHLD (bug#10933).
4944
9f851fbd
CY
49452012-03-22 Chong Yidong <cyd@gnu.org>
4946
4947 * dispextern.h (struct it): New member string_from_prefix_prop_p.
4948
5063c0e1 4949 * xdisp.c (push_prefix_prop): Rename from push_display_prop.
9f851fbd
CY
4950 Mark string as coming from a prefix property.
4951 (handle_face_prop): Use default face for prefix strings (Bug#4281).
4952 (pop_it, reseat_1): Save and restore string_from_prefix_prop_p.
4953
fb5b8aca
CY
49542012-03-21 Chong Yidong <cyd@gnu.org>
4955
4956 * xfaces.c (Vface_remapping_alist): Doc fix.
4957
62356a1b
EZ
49582012-03-20 Eli Zaretskii <eliz@gnu.org>
4959
4960 * w32proc.c (Fw32_set_console_codepage)
5063c0e1
TN
4961 (Fw32_set_console_output_codepage, Fw32_get_codepage_charset):
4962 Doc fixes.
62356a1b 4963
025de85b
CY
49642012-03-20 Chong Yidong <cyd@gnu.org>
4965
4966 * dispnew.c (Fredisplay, Vredisplay_preemption_period): Update doc
4967 to reflect default non-nil value of redisplay-dont-pause.
4968
4827f94e
KH
49692012-03-19 Kenichi Handa <handa@m17n.org>
4970
4971 * ftfont.c (ftfont_drive_otf): Mask bits of character code to make
4972 it fit in a valid range (Bug#11003).
4973
e50a24a2
EZ
49742012-03-18 Eli Zaretskii <eliz@gnu.org>
4975
4976 * xdisp.c (cursor_row_p): Even if the glyph row ends in a string
4977 that is not from display property, accept the row as a "cursor
4978 row" if one of the string's character has a non-nil `cursor'
4979 property. Fixes cursor positioning when there are newlines in
4980 overlay strings, e.g. in icomplete.el. (Bug#11035)
4981
9af5ed87
PE
49822012-03-12 Paul Eggert <eggert@cs.ucla.edu>
4983
4984 * buffer.c (compare_overlays): Don't assume args differ (Bug#6830).
4985
d1f55f16
CY
49862012-03-12 Chong Yidong <cyd@gnu.org>
4987
4988 * eval.c (inhibit_lisp_code): Rename from
4989 inhibit_window_configuration_change_hook; move from window.c.
4990
4991 * xfns.c (unwind_create_frame_1, Fx_create_frame):
4992 * window.c (run_window_configuration_change_hook)
4993 (syms_of_window): Callers changed.
4994
66c5eebd
CY
49952012-03-11 Chong Yidong <cyd@gnu.org>
4996
413df973
CY
4997 * keymap.c (Fkey_description): Doc fix (Bug#9700).
4998
66c5eebd
CY
4999 * editfns.c (Fconstrain_to_field): Doc fix (Bug#9452).
5000
1de11f56
CY
50012012-03-10 Chong Yidong <cyd@gnu.org>
5002
5003 * frame.c (other_visible_frames): Don't assume the selected frame
5004 is visible (Bug#10955).
5005
cae07000
SM
50062012-03-09 Stefan Monnier <monnier@iro.umontreal.ca>
5007
5008 * buffer.c (compare_overlays): Avoid qsort's instability (bug#6830).
5009
89c94350
JD
50102012-03-08 Jan Djärv <jan.h.d@swipnet.se>
5011
5012 * gtkutil.c (x_wm_set_size_hint): Use one row in call to
5013 FRAME_TEXT_LINES_TO_PIXEL_HEIGHT so base_height is greater than
5014 zero (Bug#10954).
5015
999dd333
GM
50162012-03-03 Glenn Morris <rgm@gnu.org>
5017
01a6dcc8 5018 * alloc.c (Fgarbage_collect, misc-objects-consed): Doc fixes.
999dd333 5019
de0100f2
EZ
50202012-03-02 Eli Zaretskii <eliz@gnu.org>
5021
5022 * xdisp.c (try_window_reusing_current_matrix): Don't move cursor
5023 position past the first glyph_row that ends at ZV. (Bug#10902)
b8456c5c
EZ
5024 (redisplay_window, next_element_from_string): Fix typos in
5025 comments.
3e441275
EZ
5026 (redisplay_window): Pass to move_it_vertically the margin in
5027 pixels, not in screen lines.
de0100f2 5028
96a72ee9
GM
50292012-03-02 Glenn Morris <rgm@gnu.org>
5030
5031 * buffer.c (buffer-list-update-hook): Doc fix.
5032
312508d7
EZ
50332012-02-29 Eli Zaretskii <eliz@gnu.org>
5034
5035 * xdisp.c (get_overlay_strings_1): Under bidi redisplay, call
5036 push_it before setting up the iterator for the first overlay
5037 string, even if we have an empty string loaded.
5038 (next_overlay_string): If there's an empty string on the iterator
5039 stack, pop the stack. (Bug#10903)
5040
27f3c637
PE
50412012-02-25 Paul Eggert <eggert@cs.ucla.edu>
5042
5043 Generalize fix for crash due to non-contiguous EMACS_INT (Bug#10780).
5044 Suggested by Stefan Monnier in
5045 <http://lists.gnu.org/archive/html/emacs-devel/2012-02/msg00692.html>.
5046 * alloc.c (widen_to_Lisp_Object): New static function.
5047 (mark_memory): Also mark Lisp_Objects by fetching pointer words
5048 and widening them to Lisp_Objects. This would work even if
5049 USE_LSB_TAG is defined and wide integers are used, which might
5050 happen in a future version of Emacs.
5051
3c9dfce6
CY
50522012-02-25 Chong Yidong <cyd@gnu.org>
5053
fa74b241
CY
5054 * fileio.c (Ffile_selinux_context, Fset_file_selinux_context):
5055 Doc fix.
5056
3c9dfce6
CY
5057 * xselect.c (Fx_selection_exists_p): Doc fix.
5058 (x_clipboard_manager_save_all): Print an informative message
5059 before saving to clipboard manager.
5060
9486df08
CY
50612012-02-24 Chong Yidong <cyd@gnu.org>
5062
5063 * keyboard.c (process_special_events): Handle all X selection
5064 requests in kbd_buffer, not just the next one (Bug#8869).
5065
f01d3321
CY
50662012-02-23 Chong Yidong <cyd@gnu.org>
5067
5068 * xfns.c (Fx_create_frame): Avoid window-configuration-change-hook
5069 call when setting menu-bar-lines and tool-bar-lines parameters.
5070 (unwind_create_frame_1): New helper function.
5071
5072 * window.c (inhibit_window_configuration_change_hook): New var.
5073 (run_window_configuration_change_hook): Obey it.
b2e4ca7d 5074 (syms_of_window): Initialize it.
f01d3321 5075
86b847b6
CY
50762012-02-22 Chong Yidong <cyd@gnu.org>
5077
5078 * xterm.c (x_draw_image_relief): Add missing type check for
5079 Vtool_bar_button_margin (Bug#10743).
5080
a59225b1
CY
50812012-02-21 Chong Yidong <cyd@gnu.org>
5082
5083 * fileio.c (Vfile_name_handler_alist): Doc fix.
5084
5085 * buffer.c (Fget_file_buffer): Protect against invalid file
5086 handler return value.
5087
310f5bd4
PE
50882012-02-20 Paul Eggert <eggert@cs.ucla.edu>
5089
cb3a28cc
PE
5090 * .gdbinit (xreload): Don't assume EMACS_INT fits in 'long'
5091 when computing $valmask.
5092
310f5bd4
PE
5093 Fix crash due to non-contiguous EMACS_INT (Bug#10780).
5094 * lisp.h (VALBITS): Move definition up, so that USE_LSB_TAG can use it.
5095 (USE_LSB_TAG): Do not define if UINTPTR_MAX >> VALBITS == 0.
5096 It's useless in that case, and it can cause problems on hosts
5097 that allocate halves of EMACS_INT values separately.
5098 Reported by Dan Horák. Diagnosed by Andreas Schwab in
5099 <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=10780#30>.
5100 * mem-limits.h (EXCEEDS_LISP_PTR): Define to 0 on hosts where
5101 UINTPTR_MAX >> VALBITS == 0. This is required by the above change;
5102 it avoids undefined behavior on hosts where shifting right by more
5103 than the word width has undefined behavior.
5104
2375c96a
CY
51052012-02-19 Chong Yidong <cyd@gnu.org>
5106
5107 * fileio.c (Ffile_name_directory, Ffile_name_nondirectory)
5108 (Funhandled_file_name_directory, Ffile_name_as_directory)
5109 (Fdirectory_file_name, Fexpand_file_name)
5110 (Fsubstitute_in_file_name): Protect against invalid file handler
5111 return values (Bug#10845).
5112
3eb49e71
EZ
51132012-02-18 Eli Zaretskii <eliz@gnu.org>
5114
5115 * .gdbinit (pitx): Fix incorrect references to fields of the
5116 iterator stack.
5117
7b926f3f
CY
51182012-02-17 Chong Yidong <cyd@gnu.org>
5119
5120 * syntax.c (Fscan_lists): Doc fix (Bug#10833).
5121
11273115
PE
51222012-02-15 Paul Eggert <eggert@cs.ucla.edu>
5123
5124 * image.c (MAX_IMAGE_SIZE): Increase from 6.0 to 10.0; see
5125 <http://lists.gnu.org/archive/html/emacs-devel/2012-02/msg00540.html>.
5126
c3a70e2b
CY
51272012-02-15 Chong Yidong <cyd@gnu.org>
5128
5129 * eval.c (Fdefvar, Fdefconst): Doc fix; note that the variable is
5130 marked as special. Also, starting docstrings with * is obsolete.
5131
0ca43699
AS
51322012-02-13 Andreas Schwab <schwab@linux-m68k.org>
5133
5134 * gnutls.c (emacs_gnutls_write): Fix last change.
5135
2e8f3c56
LI
51362012-02-13 Lars Ingebrigtsen <larsi@gnus.org>
5137
5138 * gnutls.c (emacs_gnutls_write): Set errno appropriately for
5139 send_process.
5140
af70074f
SM
51412012-02-13 Stefan Monnier <monnier@iro.umontreal.ca>
5142
5143 * keymap.c (Fsingle_key_description): Handle char ranges.
5144
95986d52
CY
51452012-02-12 Chong Yidong <cyd@gnu.org>
5146
afd83bd1
CY
5147 * xdisp.c (handle_stop): Avoid assigning -1 to it->face_id here,
5148 as that creates a dangerous corner case.
5149
95986d52
CY
5150 * window.c (Fdelete_window_internal): Invalidate the mouse
5151 highlight (Bug#9904).
5152
bd7da63e
GM
51532012-02-12 Glenn Morris <rgm@gnu.org>
5154
5155 * xselect.c (Fx_own_selection_internal)
5156 (Fx_get_selection_internal, Fx_disown_selection_internal)
5157 (Fx_selection_owner_p, Fx_selection_exists_p): Doc fixes.
5158 * nsselect.m (Fx_own_selection_internal)
5159 (Fx_disown_selection_internal, Fx_selection_exists_p)
5160 (Fx_selection_owner_p, Fx_get_selection_internal):
5161 Sync docs and argument specs with the xselect.c versions.
5162
77abcbc2
LI
51632012-02-11 Lars Ingebrigtsen <larsi@gnus.org>
5164
5165 * gnutls.c (emacs_gnutls_write): Don't infloop if sendto fails.
5166
90b671e2
EZ
51672012-02-11 Eli Zaretskii <eliz@gnu.org>
5168
1c0ca0b7
EZ
5169 * w32select.c (Fx_selection_exists_p): Sync doc string and
5170 argument list with xselect.c. (Bug#10783)
5171
5172 * w16select.c (Fx_selection_exists_p): Sync doc string and
5173 argument list with xselect.c. (Bug#10783)
90b671e2 5174
49241268
GM
51752012-02-10 Glenn Morris <rgm@gnu.org>
5176
5177 * fns.c (Fsecure_hash): Doc fix.
5178
f998bbe7 51792012-02-09 Kenichi Handa <handa@m17n.org>
5c1ca13d
KH
5180
5181 * coding.c (produce_chars): Fix updating of src_end (Bug#10701).
5182
0992bd9c
CY
51832012-02-07 Chong Yidong <cyd@gnu.org>
5184
5185 * buffer.c (Fbuffer_local_variables)
5186 (buffer_lisp_local_variables): Handle unbound vars correctly;
5187 don't let Qunbound leak into Lisp.
5188
af008560
GM
51892012-02-07 Glenn Morris <rgm@gnu.org>
5190
dd605cc4
GM
5191 * image.c (Fimagemagick_types): Doc fix.
5192
af008560
GM
5193 * image.c (imagemagick-render-type): Change it from a lisp object
5194 to an integer. Move the doc here from the lisp manual.
5195 Treat all values not equal to 0 the same.
5196
1449fa1d
CY
51972012-02-06 Chong Yidong <cyd@gnu.org>
5198
5199 * doc.c (store_function_docstring): Avoid applying docstring of
5200 alias to base function (Bug#2603).
5201
3723ec07
AS
52022012-02-04 Andreas Schwab <schwab@linux-m68k.org>
5203
5204 * .gdbinit (pp1, pv1): Remove redundant defines.
5205 (pr): Use pp.
5206
79c1cc1e
CY
52072012-02-04 Chong Yidong <cyd@gnu.org>
5208
5209 * nsterm.m: Declare a global (Bug#10694).
5210
d7f29f8e
EZ
52112012-02-04 Eli Zaretskii <eliz@gnu.org>
5212
cae07000
SM
5213 * w32.c (get_emacs_configuration_options):
5214 Include --enable-checking, if specified, in the return value.
d7f29f8e 5215
3b95a6f9
MR
52162012-02-04 Martin Rudalics <rudalics@gmx.at>
5217
5218 * dispnew.c (change_frame_size_1): Calculate new_frame_total_cols
5219 after rounding frame sizes. (Bug#9723)
5220
d6fa96a6
EZ
52212012-02-04 Eli Zaretskii <eliz@gnu.org>
5222
5223 * keyboard.c (adjust_point_for_property): Don't position point
5224 before BEGV. (Bug#10696)
5225
df0b2940
PE
52262012-02-03 Paul Eggert <eggert@cs.ucla.edu>
5227
5228 Handle overflow when computing char display width (Bug#9496).
5229 * character.c (char_width): Return EMACS_INT, not int.
5230 (char_width, c_string_width): Check for overflow when
5231 computing the width; this is possible now that individual
5232 characters can have unbounded width. Problem introduced
5233 by merge from Emacs 23 on 2012-01-19.
5234
6bee44d6
MA
52352012-02-02 Michael Albinus <michael.albinus@gmx.de>
5236
5237 * dbusbind.c (Fdbus_register_method): Mention the return value
5238 :ignore in the docstring.
5239
44f92739
GM
52402012-02-02 Glenn Morris <rgm@gnu.org>
5241
1b9f60cc
GM
5242 * callproc.c (Fcall_process, Fcall_process_region): Doc fix.
5243
44f92739
GM
5244 * nsterm.m (syms_of_nsterm) <x-toolkit-scroll-bars>:
5245 Unconditionally set to t. (Bug#10673)
5246 * nsterm.m (syms_of_nsterm) <x-toolkit-scroll-bars>:
5247 * w32term.c (syms_of_w32term) <x-toolkit-scroll-bars>:
5248 * xterm.c (syms_of_xterm) <x-toolkit-scroll-bars>: Doc fix.
5249
c5d3843c
KH
52502012-02-02 Kenichi Handa <handa@m17n.org>
5251
5252 (x_produce_glyphs): Cancel previous change. If cmp->glyph_len is
5253 0, do not call append_composite_glyph.
5254
159462d4 52552012-02-02 Kenichi Handa <handa@m17n.org>
d2a51fd7
KH
5256
5257 * xdisp.c (BUILD_COMPOSITE_GLYPH_STRING): Initialize first_s to
5258 NULL (Bug#6988).
5259 (x_produce_glyphs): If the component of a composition is a null
5260 string, set it->pixel_width to 1 to avoid zero-width glyph.
5261
78cef877
EZ
52622012-02-01 Eli Zaretskii <eliz@gnu.org>
5263
5264 * ralloc.c (resize_bloc, r_alloc_sbrk): Don't call memmove if its
5265 first 2 arguments are identical. This makes inserting large
5266 output from a subprocess an order of magnitude faster on
5267 MS-Windows, where all sbrk'ed memory is always contiguous.
5268
97897668
GM
52692012-01-31 Glenn Morris <rgm@gnu.org>
5270
5271 * nsterm.m (syms_of_nsterm) <x-toolkit-scroll-bars>:
c78c6e0b 5272 * w32term.c (syms_of_w32term) <x-toolkit-scroll-bars>:
97897668
GM
5273 * xterm.c (syms_of_xterm) <x-toolkit-scroll-bars>: Sync docs.
5274
31fd3586
GM
52752012-01-29 Glenn Morris <rgm@gnu.org>
5276
5277 * gnutls.c (syms_of_gnutls): More doc (from etc/NEWS).
5278
0e24a8b2
CY
52792012-01-28 Samuel Thibault <sthibault@debian.org> (tiny change)
5280
5281 * s/gnu.h: Define POSIX_SIGNALS (Bug#10552).
5282
cc0adcb0
CY
52832012-01-28 Chong Yidong <cyd@gnu.org>
5284
5285 * minibuf.c (syms_of_minibuf): Doc fix (Bug#10550).
5286
acc28cb9
CY
52872012-01-26 Chong Yidong <cyd@gnu.org>
5288
9c69cfb7
CY
5289 * keyboard.c (Vecho_keystrokes): Document zero value (Bug#10503).
5290
acc28cb9
CY
5291 * search.c (Fsearch_forward, Fsearch_backward): Document negative
5292 repeat counts (Bug#10507).
5293
48da7392
GM
52942012-01-26 Glenn Morris <rgm@gnu.org>
5295
5296 * lread.c (syms_of_lread): Doc fix.
5297
14af5f7f
CY
52982012-01-25 HIROSHI OOTA <nil@mad.dog.cx> (tiny change)
5299
5300 * coding.c (encode_designation_at_bol): Change return value to
5301 EMACS_INT.
5302
0b21c100
CY
53032012-01-25 Chong Yidong <cyd@gnu.org>
5304
5305 * eval.c (Fuser_variable_p): Doc fix; mention custom-variable-p.
5306
3c2907f7
CY
53072012-01-21 Chong Yidong <cyd@gnu.org>
5308
5309 * floatfns.c (Fcopysign): Make the second argument non-optional,
5310 since nil is not allowed anyway.
5311
959ad23f
AS
53122012-01-21 Andreas Schwab <schwab@linux-m68k.org>
5313
5314 * process.c (read_process_output): Use p instead of XPROCESS (proc).
5315 (send_process): Likewise.
5316
34a02f46
MR
53172012-01-19 Martin Rudalics <rudalics@gmx.at>
5318
5319 * window.c (save_window_save, Fcurrent_window_configuration)
cae07000
SM
5320 (Vwindow_persistent_parameters): Do not use Qstate.
5321 Rewrite doc-strings.
34a02f46 5322
1259009a 53232012-01-19 Kenichi Handa <handa@m17n.org>
25ed9e61
KH
5324
5325 * character.c (char_width): New function.
70d4fdf6
GM
5326 (Fchar_width, c_string_width, lisp_string_width):
5327 Use char_width (Bug#9496).
25ed9e61 5328
6a6ee00d
MR
53292012-01-16 Martin Rudalics <rudalics@gmx.at>
5330
5331 * window.c (Vwindow_persistent_parameters): New variable.
5332 (Fset_window_configuration, save_window_save): Handle persistent
5333 window parameters.
5334
c85efaf7
EZ
53352012-01-14 Eli Zaretskii <eliz@gnu.org>
5336
5337 * w32fns.c (signal_user_input): Don't do a QUIT, to avoid
5338 thrashing the stack of the thread. (Bug#9087)
5339
5944709e
PE
53402012-01-12 Paul Eggert <eggert@cs.ucla.edu>
5341
5342 * xdisp.c (rows_from_pos_range): Add parens as per gcc -Wparentheses.
5343
e71f5d99
EZ
53442012-01-11 Eli Zaretskii <eliz@gnu.org>
5345
5346 * xdisp.c (rows_from_pos_range): Handle the case where the
5347 highlight ends on a newline. (Bug#10464)
5348 (mouse_face_from_buffer_pos): Fix off-by-one error in calculating
5349 he end column for display of highlight that ends on a newline
5350 before a R2L line.
5351
ce316182
GM
53522012-01-11 Glenn Morris <rgm@gnu.org>
5353
5354 * lread.c (init_lread): If no-site-lisp, remove site-lisp dirs
5355 from load-path also when installation-directory is nil. (Bug#10208)
5356
5b43da69
GM
53572012-01-10 Glenn Morris <rgm@gnu.org>
5358
74cc8ff9
GM
5359 * emacs.c (syms_of_emacs) <installation-directory>: Doc fix.
5360
7d8d6e4e
GM
5361 * epaths.in (PATH_LOADSEARCH, PATH_EXEC, PATH_DATA, PATH_DOC):
5362 Update template values to be closer to their typical values these days.
5b43da69 5363
a0db8d43
EZ
53642012-01-09 Eli Zaretskii <eliz@gnu.org>
5365
5366 * xdisp.c (rows_from_pos_range): Accept additional argument
5367 DISP_STRING, and accept any glyph in a row whose object is that
5368 string as eligible for mouse highlight. Fixes mouse highlight of
5369 display strings from overlays. (Bug#10464)
5370
9a0115ab 53712012-01-07 Paul Eggert <eggert@cs.ucla.edu>
09450bae 5372
b9110d6a 5373 emacs: fix an auto-save permissions race condition (Bug#10400)
09450bae
PE
5374 * fileio.c (auto_saving_dir_umask): New static var.
5375 (Fmake_directory_internal): Use it.
5376 (do_auto_save_make_dir): Set it, instead of invoking chmod after
5377 creating the directory. The old code temporarily assigns
5378 too-generous permissions to the directory.
5379 (do_auto_save_eh): Clear it.
b9110d6a 5380 (Fdo_auto_save): Catch all errors, not just file errors, so
09450bae
PE
5381 that the var is always cleared.
5382
6c1bd3f3
EZ
53832012-01-07 Eli Zaretskii <eliz@gnu.org>
5384
5385 * search.c (scan_buffer): Pass character positions to
5386 know_region_cache, not byte positions. (Bug#6540)
5387
069d2b50
L
53882012-01-07 LynX <_LynX@bk.ru> (tiny change)
5389
5390 * w32.c (sys_rename): Report EXDEV when rename of a directory
5391 fails because the target is on another logical disk. (Bug#10284)
5392
75bf0d33
DB
53932012-01-07 David Benjamin <davidben@mit.edu> (tiny change)
5394
5395 * xterm.c (x_embed_request_focus): New function.
5396
5397 * xterm.h: Add prototype.
5398
5399 * xfns.c (Fx_focus_frame): Use it for embedded frames (Bug#9977).
5400
1c6e5a32
GM
54012012-01-05 Glenn Morris <rgm@gnu.org>
5402
5403 * emacs.c (emacs_copyright): Update short copyright year to 2012.
5404
651e947e
EZ
54052012-01-01 Eli Zaretskii <eliz@gnu.org>
5406
5407 * gnutls.c (init_gnutls_functions): Load gnutls_check_version.
5408 Load gnutls_transport_set_lowat only if GnuTLS version is below
5409 2.11.1.
5410 (emacs_gnutls_handshake): Call gnutls_transport_set_lowat only for
5411 GnuTLS versions below 2.11.1.
5412
3778cdd8
AL
54132011-12-31 Antoine Levitt <antoine.levitt@gmail.com>
5414
5415 * xdisp.c (syms_of_xdisp) <window-scroll-functions>: Add warning
5416 to the doc string advising against its use for altering the way
5417 windows are scrolled.
5418
0e5317f7
KH
54192011-12-28 Kenichi Handa <handa@m17n.org>
5420
5421 * coding.c (Fdefine_coding_system_internal): Make an utf-8 base
5422 coding-system ASCII compatible only when it does not produce BOM
5423 on encoding (Bug#10383).
5424
93d5ca1f
JD
54252011-12-26 Jan Djärv <jan.h.d@swipnet.se>
5426
5427 * xmenu.c (x_menu_wait_for_event): Use xg_select for Gtk3 so menus
5428 can scroll.
5429 (create_and_show_popup_menu): Always use menu_position_func for
5430 Gtk3 (Bug#10361).
5431
ca22b785
AS
54322011-12-24 Andreas Schwab <schwab@linux-m68k.org>
5433
5434 * callint.c (Fcall_interactively): Don't truncate prompt string.
5435
d048e1e6
EZ
54362011-12-23 Eli Zaretskii <eliz@gnu.org>
5437
5438 * xdisp.c (handle_invisible_prop): Handle correctly an invisible
5439 property that ends at ZV, so that the bidi iteration could be
3ba1a2ad 5440 resumed from there (after widening). (Bug#10360)
d048e1e6 5441
5ccaba1f
JD
54422011-12-22 Jan Djärv <jan.h.d@swipnet.se>
5443
5444 * nsfont.m (ns_spec_to_descriptor): Do not autorelease fdesc.
5445
204ee57f
JD
54462011-12-21 Jan Djärv <jan.h.d@swipnet.se>
5447
b81d40f0
JB
5448 * nsterm.m (x_free_frame_resources):
5449 Release f->output_data.ns->miniimage.
204ee57f
JD
5450 (ns_index_color): Fix indentation. Do not retain
5451 color_table->colors[i].
5452
5453 * nsmenu.m (ns_update_menubar): Call free_menubar_widget_value_tree
5454 before returning.
5455
5456 * nsfns.m (x_set_background_color): Assign return value from
5457 ns_index_color to face-background instead of NSColor*.
5458 (ns_implicitly_set_icon_type): Fix indentation.
5459 Change assignment in for loop to comparison.
5460
5461 * emacs.c (ns_pool): New variable.
5462 (main): Assign ns_pool.
5463 (Fkill_emacs): Call ns_release_autorelease_pool.
5464
5465 * nsfont.m (ns_spec_to_descriptor): Fix indentation,
5466 autorelease fdesc, release fdAttrs and tdict.
5467 (ns_get_covering_families): Release charset.
5468 (ns_findfonts): Release NSFontDescriptor created with new.
5469 (ns_uni_to_glyphs): Fix indentation.
5470 (setString): Release attrStr before assigning new value.
5471
c803b2b7
JD
54722011-12-18 Jan Djärv <jan.h.d@swipnet.se>
5473
678f4426
JD
5474 * nsmenu.m (NSMenuDidBeginTrackingNotification): Declare if OSX < 10.5
5475 and NS_IMPL_COCOA.
5476 (trackingNotification): Surround with ifdef NS_IMPL_COCOA.
5477 (syms_of_nsmenu): Set trackingMenu to 1 if not NS_IMPL_COCOA.
5478
cd394be1 54792011-12-18 David Reitter <reitter@cmu.edu>
678f4426 5480
5fecd5fc
JD
5481 * nsterm.m (ns_term_init): Subscribe for notifications
5482 NSMenuDidBeginTrackingNotification and NSMenuDidEndTrackingNotification
5483 to method trackingNotification in EmacsMenu.
5484
5485 * nsmenu.m (trackingMenu): New variable.
3771cb17 5486 (trackingNotification): New method (from Aquamacs).
5fecd5fc 5487 (menuNeedsUpdate): Expand comment and return if trackingMenu is 0,
3771cb17 5488 from Aquamacs (Bug#7030).
678f4426
JD
5489
54902011-12-18 Jan Djärv <jan.h.d@swipnet.se>
5fecd5fc 5491
c803b2b7
JD
5492 * nsselect.m (CUT_BUFFER_SUPPORT): Remove define.
5493 (symbol_to_nsstring): Fix indentation.
5494 (ns_symbol_to_pb): New function.
cae07000
SM
5495 (Fns_get_selection_internal): Rename from Fns_get_cut_buffer_internal.
5496 (Fns_rotate_cut_buffers_internal): Remove.
5497 (Fns_store_selection_internal): Rename from
c803b2b7
JD
5498 Fns_store_cut_buffer_internal.
5499 (ns_get_foreign_selection, Fx_own_selection_internal)
5500 (Fx_disown_selection_internal, Fx_selection_exists_p)
b81d40f0
JB
5501 (Fns_get_selection_internal, Fns_store_selection_internal):
5502 Use ns_symbol_to_pb and check if return value is nil.
5503 (syms_of_nsselect): Remove ifdef CUT_BUFFER_SUPPORT. Remove defsubr
5504 Sns_rotate_cut_buffers_internal. Sns_get_cut_buffer_internal
c803b2b7
JD
5505 renamed to Sns_get_selection_internal, Sns_store_cut_buffer_internal
5506 renamed to Sns_store_selection_internal.
5507 (ns_handle_selection_request): Move code to Fx_own_selection_internal
5508 and remove this function.
5509 (ns_handle_selection_clear): Remove, never used.
5510 (Fx_own_selection_internal): Move code from ns_handle_selection_request
5511 here.
5512
e1b01a3a
KB
55132011-12-17 Ken Brown <kbrown@cornell.edu>
5514
5515 * fileio.c (check_writable) [CYGWIN]: Return non-zero if UID or
5516 GID is unknown (Bug#10257).
5517
2adb6e85
PE
55182011-12-17 Paul Eggert <eggert@cs.ucla.edu>
5519
5520 * s/gnu-linux.h: Fix mark_memory typo (Bug#10286).
5521 (GC_MARK_SECONDARY_STACK): Omit removed 3rd arg to mark_memory,
5522 which caused a build failure on GNU/Linux IA-64. This problem was
5523 introduced by my 2011-10-07 patch.
5524
d1d7b339
JL
55252011-12-15 Juri Linkov <juri@jurta.org>
5526
5527 * image.c (imagemagick_error): New function. (Bug#10112)
5528 (imagemagick_load_image): Comment out `MagickSetResolution' call.
5529 Use `imagemagick_error' where ImageMagick functions return
5530 `MagickFalse'.
5531 (Fimagemagick_types): Add `Fnreverse' to return the list in the
5532 proper order.
5533
100d5755
KH
55342011-12-15 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
5535
5536 * xftfont.c (xftfont_draw): Use the font metrics of s->font to
5537 fill background (Bug#8992).
5538
454592a6
MR
55392011-12-13 Martin Rudalics <rudalics@gmx.at>
5540
5541 * window.c (Vwindow_combination_resize)
5542 (Vwindow_combination_limit): Use t instead of non-nil in
5543 doc-strings.
61d4b438
MR
5544 (Vrecenter_redisplay): Add first sentence of doc-string on
5545 separate line.
53524d93 5546 (Frecenter): Fix doc-string typo.
454592a6 5547
3633e3aa
KH
55482011-12-11 Kenichi Handa <handa@m17n.org>
5549
5550 * coding.c (Funencodable_char_position): Pay attention to the
5551 buffer text relocation (Bug#9389).
5552
7b9d523a 55532011-12-10 Jan Djärv <jan.h.d@swipnet.se>
61ccba97 5554
7b9d523a
JD
5555 * xterm.c (x_term_init): Move call to gdk_window_add_filter before
5556 gtk_init (Bug#10100).
5557
b73189c6
EZ
55582011-12-10 Eli Zaretskii <eliz@gnu.org>
5559
5560 * xdisp.c (RECORD_MAX_MIN_POS): Use IT->cmp_it.charpos only if
5561 IT->string is nil. (Bug#10263)
5562
f7dfe5d6
JD
55632011-12-10 Jan Djärv <jan.h.d@swipnet.se>
5564
83faebb4
JD
5565 * nsterm.h (x_free_frame_resources): Declare.
5566
f7dfe5d6
JD
5567 * nsfns.m (ns_get_defaults_value): New function (Bug#10103).
5568 (Fns_get_resource, x_get_string_resource): Call ns_get_defaults_value.
5569
5570 * nsterm.h (ns_get_defaults_value): Declare.
5571
5572 * nsterm.m (ns_default): Call ns_get_defaults_value.
5573
7cd4e72c
EZ
55742011-12-09 Eli Zaretskii <eliz@gnu.org>
5575
5576 * xdisp.c (try_scrolling): Don't set scroll_down_p if dy is zero.
5577 (Bug#10170)
5578
b34d7317
YM
55792011-12-09 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
5580
5581 * unexelf.c (unexec) [NS_IMPL_GNUSTEP]: Take account of the case
5582 that where the value of an _OBJC_* symbol points to is in the .bss
5583 section (Bug#10240).
5584
76470ad1
KH
55852011-12-08 Kazuhiro Ito <kzhr@d1.dion.ne.jp> (tiny change)
5586
5587 * coding.c (encode_coding_ccl): Check (charbuf < charbuf_end)
2fac8180 5588 after the loop to call ccl_driver at least once (Bug#8619).
76470ad1 5589
745fff94
KH
55902011-12-08 Kenichi Handa <handa@m17n.org>
5591
5592 * ftfont.c (get_adstyle_property): Fix previous change
5593 (Bug#10233).
5594
6e44397c
JB
55952011-12-07 Juanma Barranquero <lekktu@gmail.com>
5596
5597 * w32.c (init_environment): If no_site_lisp, remove site-lisp
5598 dirs from the default value of EMACSLOADPATH (bug#10208).
5599
7efa6272
GM
56002011-12-07 Glenn Morris <rgm@gnu.org>
5601
5602 * lread.c (init_lread): If no_site_lisp, exclude site-lisp/ in
5603 installation and source directories as well. (Bug#10208)
5604
f6fc4d87
CY
56052011-12-06 Chong Yidong <cyd@gnu.org>
5606
5607 * minibuf.c (Fread_from_minibuffer): Doc fix (Bug#10228).
5608
2bf26180
GM
56092011-12-06 Glenn Morris <rgm@gnu.org>
5610
5611 * process.c (start_process_unwind): Treat any pid <= 0, except -2,
5612 as an error, not just -1. (Bug#10217)
5613
3a6ad4f0
CY
56142011-12-05 Chong Yidong <cyd@gnu.org>
5615
5616 * keyboard.c (process_special_events): New function.
5617 (swallow_events, Finput_pending_p): Use it (Bug#10195).
5618
75a3b399
PE
56192011-12-05 Paul Eggert <eggert@cs.ucla.edu>
5620
5621 * coding.c (encode_designation_at_bol): Don't use uninitialized
5622 local variable (Bug#9318).
5623
c3c9e25e
KH
56242011-12-05 Kenichi Handa <handa@m17n.org>
5625
5626 * ftfont.c (get_adstyle_property): If the font is not BDF nor PCF,
5627 return Qnil (Bug#8046, Bug#10193).
5628
5eb05ea3
KH
56292011-12-05 Kenichi Handa <handa@m17n.org>
5630
5631 * coding.c (encode_designation_at_bol): New args charbuf_end and
5632 dst. Return the number of produced bytes. Callers changed.
a79703f5
KH
5633 (coding_set_source): Return how many bytes coding->source was
5634 relocated.
5635 (coding_set_destination): Return how many bytes
5636 coding->destination was relocated.
5637 (CODING_DECODE_CHAR, CODING_ENCODE_CHAR, CODING_CHAR_CHARSET)
cae07000 5638 (CODING_CHAR_CHARSET_P): Adjust for the avove changes.
5eb05ea3
KH
5639
56402011-12-05 Kazuhiro Ito <kzhr@d1.dion.ne.jp> (tiny change)
5641
5642 * coding.c (CODING_CHAR_CHARSET_P): New macro.
5643 (encode_coding_emacs_mule, encode_coding_iso_2022): Use the above
5644 macro (Bug#9318).
5645
56462011-12-05 Andreas Schwab <schwab@linux-m68k.org>
5647
5648 The following changes are to fix Bug#9318.
5649
a79703f5 5650 * coding.c (CODING_ENCODE_CHAR, CODING_CHAR_CHARSET): New macros.
5eb05ea3
KH
5651 (encode_coding_emacs_mule, ENCODE_ISO_CHARACTER)
5652 (encode_coding_iso_2022, encode_coding_sjis)
a79703f5 5653 (encode_coding_big5, encode_coding_charset): Use the above macros.
5eb05ea3 5654
7dbda6df
JB
56552011-12-05 Juanma Barranquero <lekktu@gmail.com>
5656
5657 * lisp.h (process_quit_flag): Fix external declaration.
5658
6d5eb5b0
SM
56592011-12-04 Stefan Monnier <monnier@iro.umontreal.ca>
5660
5661 Don't macro-inline non-performance-critical code.
5662 * eval.c (process_quit_flag): New function.
5663 * lisp.h (QUIT): Use it.
5664
a0c3fad0
JD
56652011-12-04 Jan Djärv <jan.h.d@swipnet.se>
5666
5667 * nsfns.m (get_geometry_from_preferences): New function.
5668 (Fx_create_frame): Call get_geometry_from_preferences (Bug#10103).
5669
6c07aac2
AS
56702011-12-04 Andreas Schwab <schwab@linux-m68k.org>
5671
5672 * emacs.c (Qkill_emacs): Define.
5673 (syms_of_emacs): Initialize it.
5674 * keyboard.c (interrupt_signal): Don't call Fkill_emacs here, set
5675 Qquit_flag to `kill-emacs' instead.
6d5eb5b0
SM
5676 (quit_throw_to_read_char): Add parameter `from_signal'.
5677 All callers changed. Call Fkill_emacs if requested and safe.
6c07aac2
AS
5678 * lisp.h (QUIT): Call Fkill_emacs if requested.
5679
c052ead4
JD
56802011-12-03 Jan Djärv <jan.h.d@swipnet.se>
5681
5682 * widget.c (update_wm_hints): Return if wmshell is null.
5683 (widget_update_wm_size_hints): New function.
5684
5685 * widget.h (widget_update_wm_size_hints): Declare.
5686
5687 * xterm.c (x_wm_set_size_hint): If USE_X_TOOLKIT, call
5688 widget_update_wm_size_hints (Bug#10104).
5689
9e49252b
EZ
56902011-12-03 Eli Zaretskii <eliz@gnu.org>
5691
5692 * xdisp.c (handle_invisible_prop): If the invisible text ends just
5693 before a newline, prepare the bidi iterator for consuming the
5694 newline, and keep the current paragraph direction. (Bug#10183)
e9a49426 5695 (redisplay_window): Don't let `margin' become negative. (Bug#10192)
9e49252b 5696
02b16839
JL
56972011-12-02 Juri Linkov <juri@jurta.org>
5698
5699 * search.c (Fword_search_regexp): New Lisp function created from
5700 `wordify'. Change type of arg `lax' from `int' to `Lisp_Object'.
5701 (Fword_search_backward, Fword_search_forward)
5702 (Fword_search_backward_lax, Fword_search_forward_lax):
5703 Use `Fword_search_regexp' instead of `wordify'. Doc fix.
5704 (syms_of_search): Define `Sword_search_regexp'. (Bug#10145)
5705
0068070e
SM
57062011-12-01 Stefan Monnier <monnier@iro.umontreal.ca>
5707
5708 * fileio.c (Finsert_file_contents): Move after-change-function call
5709 to before the "handled:" label, since all "goto handled" appear in
5710 cases where the *-change-functions have already been properly called
5711 (bug#10117).
5712
3360a3fc
AS
57132011-12-01 Andreas Schwab <schwab@linux-m68k.org>
5714
5715 * keyboard.c (interrupt_signal): Don't call kill-emacs when
5716 waiting for input. (Bug#10169)
5717
73d6c093
EZ
57182011-11-30 Eli Zaretskii <eliz@gnu.org>
5719
5720 * dispnew.c (adjust_glyph_matrix): Remove the assertion that
5721 verifies glyph row's hash code--we have just reallocated the
5722 glyphs, so their contents can be complete garbage. (Bug#10164)
5723
febe6bea
JB
57242011-11-30 Juanma Barranquero <lekktu@gmail.com>
5725
5726 * dispnew.c (adjust_glyph_matrix) [XASSERTS]: Add missing check.
5727
801a4313
EZ
57282011-11-30 Eli Zaretskii <eliz@gnu.org>
5729
5730 * dispnew.c (adjust_glyph_matrix) [XASSERTS]: Ensure ROW's
5731 attributes are tested _before_ calling verify_row_hash, to protect
5732 against GCC re-ordering of the tests. (Bug#10164)
5733
2b56b87e
JD
57342011-11-29 Jan Djärv <jan.h.d@swipnet.se>
5735
5736 * xterm.h (struct x_output): net_wm_state_hidden_seen is new.
5737
5738 * xterm.c (handle_one_xevent): Only set async_visible and friends
5739 if net_wm_state_hidden_seen is non-zero (Bug#10002)
7dbda6df 5740 (get_current_wm_state): Set net_wm_state_hidden_seen to 1 if
2b56b87e
JD
5741 _NET_WM_STATE_HIDDEN is in NET_WM_STATE.
5742
dbf31225
PE
57432011-11-28 Paul Eggert <eggert@cs.ucla.edu>
5744
5745 Remove GCPRO-related macros that exist only to avoid shadowing locals.
5746 * lisp.h (GCPRO1_VAR, GCPRO2_VAR, GCPRO3_VAR, GCPRO4_VAR, GCPRO5_VAR)
5747 (GCPRO6_VAR, UNGCPRO_VAR): Remove. See
5748 <http://lists.gnu.org/archive/html/emacs-diffs/2011-11/msg00265.html>.
5749 All uses changed to use GCPRO1 etc.
5750 (GCPRO1, GCPRO2, GCPRO3, GCPRO4, GCPRO5, GCPRO6, UNGCPRO):
5751 Revert to old implementation (i.e., before 2011-03-11).
5752
1305621b
YM
57532011-11-28 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
5754
5755 * dispnew.c (scrolling_window): Truncate overlaps in copy destination
5756 of scroll runs so as to avoid assigning disabled bogus rows and
5757 unnecessary graphics copy operations.
5758
8c9afb46
EZ
57592011-11-27 Eli Zaretskii <eliz@gnu.org>
5760
5761 * s/ms-w32.h (utimbuf) [_MSC_VER]: Don't define.
5762 (snprintf) [_MSC_VER]: Redirect to _snprintf.
5763 (strtoll) [_MSC_VER]: Redirect to _strtoi64.
5764 (malloc, free, realloc, calloc): Redirect to e_* only when
5765 compiling Emacs.
5766
5767 * lisp.h (GCTYPEBITS): Move before first use.
5768 (ALIGN_GCTYPEBITS) [_MSC_VER]: Define.
5769 (DECL_ALIGN) [_MSC_VER]: Use it, as MSVC doesn't like bit ops in
5770 this macro definition.
5771
5772 * s/ms-w32.h (tzname): Redirect to _tzname for all values of
5773 _MSC_VER.
5774
54e9e3bf
JD
57752011-11-27 Jan Djärv <jan.h.d@swipnet.se>
5776
6d5eb5b0
SM
5777 * gtkutil.c (xg_create_frame_widgets):
5778 Call gtk_window_set_has_resize_grip (FALSE) if that function is
54e9e3bf
JD
5779 present with Gtk+ 2.0.
5780
83aca1cb
PE
57812011-11-26 Paul Eggert <eggert@cs.ucla.edu>
5782
5783 * fileio.c (Finsert_file_contents): Undo previous change; see
5784 <http://lists.gnu.org/archive/html/emacs-diffs/2011-11/msg00265.html>.
5785
5b76caa4
PE
57862011-11-26 Paul Eggert <eggert@cs.ucla.edu>
5787
5788 Rename locals to avoid shadowing.
5789 * fileio.c (Finsert_file_contents):
5790 Rename inner 'gcpro1' to 'inner_gcpro1' to avoid shadowing.
5791 * process.c (wait_reading_process_output):
5792 Rename inner 'proc' to 'p' to avoid shadowing.
5793 Indent for consistency with usual Emacs style.
5794
8c535114
EZ
57952011-11-25 Eli Zaretskii <eliz@gnu.org>
5796
5797 * xdisp.c (redisplay_window): If cursor row is not fully visible
5798 after recentering, and scroll-conservatively is set to a large
5799 number, scroll window by a few more lines to make the cursor fully
5800 visible and out of scroll-margin. (Bug#10105)
91b4a718
EZ
5801 (start_display): Don't move to the next line if the display should
5802 start at a newline that is part of a display vector or an overlay
5803 string. (Bug#10119)
8c535114 5804
fa4fdb5c
JL
58052011-11-24 Juri Linkov <juri@jurta.org>
5806
5807 * image.c (imagemagick_load_image): Move `MagickSetResolution' down
5808 after the `MagickPingImage' call. (Bug#10112)
5809
90ec88df
CY
58102011-11-23 Chong Yidong <cyd@gnu.org>
5811
5812 * window.c (Fcoordinates_in_window_p): Accept only live windows.
5813
56e2e794
MR
58142011-11-23 Martin Rudalics <rudalics@gmx.at>
5815
5816 * buffer.c (Fkill_buffer): Run replace_buffer_in_windows before
5817 making another buffer current. (Bug#10114)
5818
b6e64c41
GM
58192011-11-23 Glenn Morris <rgm@gnu.org>
5820
5821 * font.c (font_find_for_lface) [HAVE_NS]: Ignore case. (Bug#2526)
5822
6b21de18
CY
58232011-11-23 Chong Yidong <cyd@gnu.org>
5824
5825 * xdisp.c (compute_stop_pos): Check validity of end_charpos before
5826 using it (Bug#5984).
5827
b12cd789
EZ
58282011-11-22 Eli Zaretskii <eliz@gnu.org>
5829
5830 * dispnew.c (adjust_glyph_matrix): Don't verify hash code of mode-
5831 and header-lines, as they don't have one computed for them.
5832 (Bug#10098)
5833
5834 * .gdbinit (prow): Make displayed values more self-explaining.
5835 Add row's hash code.
5836
261b6fd4
LMI
58372011-11-21 Lars Magne Ingebrigtsen <larsi@gnus.org>
5838
5839 * process.c (wait_reading_process_output): Fix asynchrounous
5840 GnuTLS socket handling on some versions of the GnuTLS library.
16c1ad08 5841 (wait_reading_process_output): Add comment and URL.
261b6fd4 5842
e7cfd277
JD
58432011-11-21 Jan Djärv <jan.h.d@swipnet.se>
5844
5845 * xterm.c (x_clear_frame): Reinstate the XClearWindow call.
5846
a9b9b7f5
CY
58472011-11-21 Chong Yidong <cyd@gnu.org>
5848
5849 * window.c (Fnext_window, Fprevious_window): Doc fix.
5850
b0d15b4f
SM
58512011-11-20 Stefan Monnier <monnier@iro.umontreal.ca>
5852
5853 * window.c (get_phys_cursor_glyph): Fix Lisp_Object/int mixup.
5854
fe7a3057
JB
58552011-11-20 Juanma Barranquero <lekktu@gmail.com>
5856
5857 * nsfont.m (syms_of_nsfont) <ns-reg-to-script>: Fix typo.
5858
d2999b1a
MR
58592011-11-20 Martin Rudalics <rudalics@gmx.at>
5860
5861 * window.c (Fset_window_combination_limit): Rename argument
5862 STATUS to LIMIT.
5863 (Vwindow_combination_limit): Remove "status" from doc-string.
5864
d5ff9cd0
AS
58652011-11-20 Andreas Schwab <schwab@linux-m68k.org>
5866
5867 * m/ibms390.h: Remove.
5868 * m/ibms390x.h: Don't include "ibms390.h".
5869
a5bb9bd3
SM
58702011-11-20 Stefan Monnier <monnier@iro.umontreal.ca>
5871
5872 * fileio.c (Finsert_file_contents): Add missing gcpro1 variable.
5873 Suggested by Dmitry Antipov <dmantipov@yandex.ru>.
5874
cd1181db
JB
58752011-11-20 Juanma Barranquero <lekktu@gmail.com>
5876
5877 * casetab.c (Fset_case_table):
5878 * charset.c (Fcharset_after): Fix typos.
5879
615a3b8d 58802011-11-20 Paul Eggert <eggert@cs.ucla.edu>
6a0bf43d 5881
17e845af
PE
5882 Standardize on VIRT_ADDR_VARIES behavior (Bug#10042).
5883 Otherwise, valgrind does not work on some platforms.
5884 Problem reported by Andreas Schwab in
6a0bf43d
PE
5885 <http://lists.gnu.org/archive/html/emacs-devel/2011-11/msg00081.html>.
5886 * puresize.h (pure, PURE_P): Always behave as if VIRT_ADDR_VARIES
5887 is set, removing the need for VIRT_ADDRESS_VARIES.
5888 (PURE_P): Use a more-efficient implementation that needs just one
5889 comparison, not two: on x86-64 with GCC 4.6.2, this cut down the
5890 number of instructions from 6 (xorl, cmpq, jge, xorl, cmpq, setge)
5891 to 4 (xorl, subq, cmpq, setbe).
5892 * alloc.c (pure): Always extern now, since that's the
5893 VIRT_ADDR_VARIES behavior.
5894 (PURE_POINTER_P): Use a single comparison, not two, for
5895 consistency with the new puresize.h.
5896 * lisp.h (PNTR_COMPARISON_TYPE): Remove; no longer needed.
5897 * m/ibms390.h, m/intel386.h, m/template.h, s/cygwin.h, s/hpux10-20.h:
5898 Remove VIRT_ADDR_VARIES no longer needed.
5899
f8fe6f96
EZ
59002011-11-19 Eli Zaretskii <eliz@gnu.org>
5901
5902 * xdisp.c (x_write_glyphs, draw_phys_cursor_glyph)
5903 (erase_phys_cursor, update_window_cursor, show_mouse_face)
5904 (cursor_in_mouse_face_p): If the cursor position is out of bounds,
5905 behave as if the cursor position were at the window margin.
5906
5907 * window.c (get_phys_cursor_glyph): If the window is hscrolled,
5908 and the cursor position is out of bounds, behave as if the cursor
5909 position were at the window margin. (Bug#10075)
5910
df05a53c
CY
59112011-11-18 Chong Yidong <cyd@gnu.org>
5912
5913 * window.c (Fwindow_combination_limit): Make first argument
5914 non-optional, since it is meaningless for live windows like the
5915 selected window.
61ccba97 5916
2071918e
DA
59172011-11-18 Dmitry Antipov <dmantipov@yandex.ru>
5918
5919 * keymap.c (Fwhere_is_internal): Add missing RETURN_UNGCPROs.
5920
b50a28de
SM
59212011-11-18 Stefan Monnier <monnier@iro.umontreal.ca>
5922
5923 * intervals.c: Fix grafting over the whole buffer (bug#10071).
5924 (graft_intervals_into_buffer): Simplify.
5925
015137db
EZ
59262011-11-18 Eli Zaretskii <eliz@gnu.org>
5927
5928 * dispnew.c (swap_glyph_pointers): Swap the used[] arrays and the
5929 hash values of the two rows.
5930 (copy_row_except_pointers): Preserve the used[] arrays and the
5931 hash values of the two rows. (Bug#10035)
68c95424 5932 (add_row_entry): Add xassert to verify that ROW's hash code is valid.
015137db
EZ
5933
5934 * xdisp.c (row_hash): New function, body extracted from
5935 compute_line_metrics.
5936 (compute_line_metrics): Call row_hash, instead of computing the
5937 hash code inline.
5938
5939 * dispnew.c (verify_row_hash): Call row_hash for computing the
5940 hash code of a row, instead of duplicating code from xdisp.c.
5941
5942 * dispextern.h (row_hash): Add prototype.
5943
a2addb04
TH
59442011-11-18 Tassilo Horn <tassilo@member.fsf.org>
5945
5946 * frame.c (delete_frame): Don't delete the terminal when the last
5947 X frame is closed if emacs is built with GTK toolkit.
5948
df85d315
JB
59492011-11-17 Juanma Barranquero <lekktu@gmail.com>
5950
5951 * window.c (syms_of_window) <window-combination-resize>: Fix typo.
5952
a0c2d0ae
MR
59532011-11-17 Martin Rudalics <rudalics@gmx.at>
5954
5955 * window.c (Vwindow_splits): Rename to
5956 Vwindow_combination_resize. Suggested by Juri Linkov.
5957 (Fsplit_window_internal): Use Vwindow_combination_resize instead
5958 of Vwindow_splits.
5959
58179cce
JB
59602011-11-16 Juanma Barranquero <lekktu@gmail.com>
5961
7877f373
JB
5962 * nsfns.m (Fns_font_name):
5963 * window.c (syms_of_window) <window-combination-limit>: Fix typos.
58179cce 5964
b6f67890
MR
59652011-11-16 Martin Rudalics <rudalics@gmx.at>
5966
5967 * window.h (window): Rename slot "nest" to "combination_limit".
5968 * window.c (Fwindow_nest): Rename to Fwindow_combination_limit.
5969 (Fset_window_nest): Rename to Fset_window_combination_limit.
5970 (Vwindow_nest): Rename to Vwindow_combination_limit.
5971 (recombine_windows, make_parent_window, make_window)
5972 (Fsplit_window_internal, saved_window)
5973 (Fset_window_configuration, save_window_save): Rename all
5974 occurrences of window_nest to window_combination_limit.
5975
c7015153
JB
59762011-11-15 Juanma Barranquero <lekktu@gmail.com>
5977
5978 * image.c (imagemagick_load_image): Fix typo.
5979
322ad6ec
EZ
59802011-11-14 Eli Zaretskii <eliz@gnu.org>
5981
5982 * xdisp.c (display_line): Move the call to
5983 highlight_trailing_whitespace before the call to
5984 compute_line_metrics, since the latter needs to see the final
6d5eb5b0
SM
5985 faces of all the glyphs to compute ROW's hash value.
5986 Fixes assertion violations in row_equal_p. (Bug#10035)
322ad6ec 5987
f067b8ec
JB
59882011-11-14 Juanma Barranquero <lekktu@gmail.com>
5989
5990 * w32proc.c (reader_thread): Don't check pending input if cp->fd < 0,
5991 just return (bug#10044).
5992
1e5b2111
EZ
59932011-11-12 Eli Zaretskii <eliz@gnu.org>
5994
7ef3cbd5
EZ
5995 * makefile.w32-in (HEAPSIZE): New variable, allows to build temacs
5996 with user-defined heap size. Bump the default size of the temacs
5997 heap to 27MB, to avoid memory warning when running temacs.
5998 ($(TEMACS)): Use HEAPSIZE instead of a hardcoded value.
5999
1e5b2111
EZ
6000 * dispnew.c (scrolling_window): Fix incorrect indices in accessing
6001 current_matrix and desired_matrix. (Bug#9990)
7a7270dd
EZ
6002 (verify_row_hash) [XASSERTS]: New function.
6003 (adjust_glyph_matrix, row_equal_p): Use it in xassert to verify
6004 that the hash value of glyph rows is correct.
1e5b2111 6005
89d61221
MR
60062011-11-12 Martin Rudalics <rudalics@gmx.at>
6007
6008 * window.h (window): Remove splits slot.
6009 * window.c (Fwindow_splits, Fset_window_splits): Remove.
6010 (Fdelete_other_windows_internal, make_parent_window)
6011 (make_window, Fsplit_window_internal, Fdelete_window_internal)
6012 (Fset_window_configuration, save_window_save): Don't deal with
6013 split status of windows.
6014 (saved_window): Remove splits slot.
6015 (Vwindow_splits): Rewrite doc-string.
6016
97f18cc8
JD
60172011-11-11 Jan Djärv <jan.h.d@swipnet.se>
6018
6019 * xfns.c (unwind_create_frame):
6020 * nsfns.m (unwind_create_frame):
6021 * w32fns.c (unwind_create_frame): Use Fmemq to check if frame is in
6022 Vframe_list (Bug#9999).
6023
22a648b4
DA
60242011-11-11 Dmitry Antipov <dmantipov@yandex.ru>
6025
0b381c7e 6026 * xdisp.c (syms_of_xdisp): Remove duplicated definition of Qtext.
22a648b4 6027
659afede
KH
60282011-11-11 Kenichi Handa <handa@m17n.org>
6029
6030 * callproc.c (Fcall_process): Set the member dst_multibyte of
6031 process_coding.
6032
9ac0394b
KH
60332011-11-11 Johan Bockgård <bojohan@gnu.org>
6034
6035 * xdisp.c (fill_composite_glyph_string): Always set s->face, to
6036 avoid a crash (bug#9496).
6037
2fbdc249
CY
60382011-11-09 Chong Yidong <cyd@gnu.org>
6039
6040 * window.c (Fwindow_inside_edges, Fwindow_inside_pixel_edges)
6041 (Fwindow_inside_absolute_pixel_edges): Only allow live windows.
6042
ac6b1f81
PE
60432011-11-08 Paul Eggert <eggert@cs.ucla.edu>
6044
6045 * s/gnu.h (GC_MARK_STACK): Define to GC_MAKE_GCPROS_NOOPS (Bug#9926).
6046
09db192c
PE
60472011-11-08 Paul Eggert <eggert@cs.ucla.edu>
6048
6049 Avoid some portability problems by eschewing 'extern inline' functions.
6050 The trivial performance wins aren't worth the portability hassles; see
6051 <http://lists.gnu.org/archive/html/emacs-devel/2011-11/msg00084.html>
6052 et seq.
6053 * dispextern.h (window_box, window_box_height, window_text_bottom_y)
6054 (window_box_width, window_box_left, window_box_left_offset)
6055 (window_box_right, window_box_right_offset): Undo previous change,
6056 by removing the "extern"s.
6057 * intervals.c (adjust_intervals_for_insertion)
6058 (adjust_intervals_for_deletion): Undo previous change,
6059 making these static again.
6060 (offset_intervals, temp_set_point_both, temp_set_point)
6061 (copy_intervals_to_string): No longer inline.
6062 * xdisp.c (window_text_bottom_y, window_box_width)
6063 (window_box_height, window_box_left_offset)
6064 (window_box_right_offset, window_box_left, window_box_right)
6065 (window_box): No longer inline.
6066
105216ed
CY
60672011-11-08 Chong Yidong <cyd@gnu.org>
6068
6069 * window.c (Fwindow_left_column, Fwindow_top_line): Doc fix.
6d5eb5b0
SM
6070 (Fwindow_body_height, Fwindow_body_width): Move from Lisp.
6071 Signal an error if not a live window.
105216ed
CY
6072 (Fwindow_total_width, Fwindow_total_height): Move from Lisp.
6073 (Fwindow_total_size, Fwindow_body_size): Move to Lisp.
6074
ae9e237f
JB
60752011-11-07 Juanma Barranquero <lekktu@gmail.com>
6076
6077 * lisp.h (syms_of_abbrev): Remove declaration.
6078 Reported by CHENG Gao <chenggao@royau.me>.
6079
c7aa8333
EZ
60802011-11-07 Eli Zaretskii <eliz@gnu.org>
6081
6082 * w32.c (check_windows_init_file): Don't look for term/w32-win.el
6083 if Vpurify_flag is non-nil. Fixes a crash when running w32 build
6084 of temacs in GUI mode.
6085
be7f5545
MR
60862011-11-07 Martin Rudalics <rudalics@gmx.at>
6087
6088 * window.h: Declare delete_all_child_windows instead of
6089 delete_all_subwindows.
6090 * window.c (Fwindow_nest, Fset_window_nest)
6091 (Fset_window_new_total, Fset_window_new_normal)
6092 (Fwindow_resize_apply): Don't use term subwindow in doc-strings.
6093 (delete_all_subwindows): Rename to delete_all_child_windows.
6094 (Fdelete_other_windows_internal, Fset_window_configuration):
6095 Call delete_all_child_windows instead of delete_all_subwindows.
6096 * frame.c (delete_frame): Call delete_all_child_windows instead
6097 of delete_all_subwindows.
6098
ca78dc43
PE
60992011-11-07 Paul Eggert <eggert@cs.ucla.edu>
6100
6101 * alloc.c (DEADP): New macro, for porting to GNU/Hurd (Bug#9926).
6102 This is also needed for porting to any host where GC_MARK_STACK is
6103 not GC_MAKE_GCPROS_NOOPS.
6104 (which_symbols): Use it.
6105
a0241d01
KH
61062011-11-07 Kenichi Handa <handa@m17n.org>
6107
6108 * coding.c (coding_set_destination): Check coding->src_pos only
6109 when coding->src_object is a buffer (bug#9910).
6110
6111 * process.c (send_process): Set the member src_multibyte of coding
6112 to 0 (bug#9911) when sending a unibyte text.
6113
6114 * callproc.c (Fcall_process): Set the member src_multibyte of
6115 process_coding to 0 (bug#9912).
6116
a64bfdfa 61172011-11-06 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
ba24cea2
YM
6118
6119 * xmenu.c (cleanup_widget_value_tree): New function.
6120 (xmenu_show, xdialog_show): Use it in record_unwind_protect instead of
6121 calling free_menubar_widget_value_tree directly (Bug#9830).
6122
cb41b32a
PE
61232011-11-06 Paul Eggert <eggert@cs.ucla.edu>
6124
6125 Fix some portability problems with 'inline'.
6126 * dispextern.h (window_box, window_box_height, window_text_bottom_y)
6127 (window_box_width, window_box_left, window_box_left_offset)
6128 (window_box_right, window_box_right_offset): Declare extern.
6129 Otherwise, these inline functions do not conform to C99 and
6130 are miscompiled by Microsoft compilers. Reported by Eli Zaretskii in
6131 <http://lists.gnu.org/archive/html/emacs-devel/2011-11/msg00084.html>.
6132 * intervals.c (adjust_intervals_for_insertion)
6133 (adjust_intervals_for_deletion): Now extern, because otherwise the
6134 extern inline functions 'offset_intervals' couldn't refer to it.
6135 (static_offset_intervals): Remove.
6136 (offset_intervals): Rewrite using the old contents of
6137 static_offset_intervals. The old version didn't conform to C99
6138 because an extern inline function contained a reference to an
6139 identifier with static linkage.
6140
b7041366
AS
61412011-11-06 Andreas Schwab <schwab@linux-m68k.org>
6142
6143 * keyboard.c (interrupt_signal): Don't call kill-emacs while in
6144 GC.
6145
88a37c4d
EZ
61462011-11-06 Eli Zaretskii <eliz@gnu.org>
6147
6148 * xdisp.c (init_iterator, reseat_to_string): Don't set the
6149 iterator's bidi_p flag if Vpurify_flag is non-nil. (Bug#9963)
6150 (Fcurrent_bidi_paragraph_direction): If Vpurify_flag is non-nil,
6151 return Qleft_to_right.
6152
49745b39
CY
61532011-11-06 Chong Yidong <cyd@gnu.org>
6154
6155 * window.c (Fwindow_live_p, Fwindow_frame, Fframe_root_window)
6156 (Fminibuffer_window, Fwindow_buffer, Fwindow_splits)
6157 (Fset_window_splits, Fwindow_nest, Fset_window_nest)
6158 (Fwindow_use_time, Fwindow_total_size, Fwindow_normal_size)
6159 (Fwindow_new_normal, Fwindow_left_column, Fwindow_top_line)
6160 (Fwindow_margins, Fwindow_fringes, Fwindow_scroll_bars)
6161 (Fwindow_vscroll): Doc fix.
6162 (Fwindow_top_child, Fwindow_left_child): Eliminate a nil default
6163 argument, since it makes no sense to pass a live window and for
6164 consistency with window-child.
6165
1f05cd82
CS
61662011-11-05 Christoph Scholtes <cschol2112@googlemail.com>
6167
6168 * makefile.w32-in ($(TEMACS), (gl-stamp)): Use $(THISDIR) to
6169 support MSVC.
6170
22610910
JR
61712011-11-05 Jason Rumney <jasonr@gnu.org>
6172
6173 * w32font.c (font_matches_spec): Filter out non-Japanese kana fonts.
6174 (add_font_entity_to_list): Filter out non-Japanese Shift-JIS
6175 fonts (Bug#6029).
6176 (add_font_entity_to_list): Fix logic errors in mixed boolean and
6177 bitwise arithmetic preventing use of unicode-sip and non-truetype
6178 opentype fonts.
6179
a06776b2
EZ
61802011-11-05 Eli Zaretskii <eliz@gnu.org>
6181
3ad924ba
EZ
6182 * s/ms-w32.h (fstat, stat, utime): Move redirections to
6183 "emacs"-only part.
6184
a06776b2
EZ
6185 * w32fns.c (x_create_tip_frame, Fx_create_frame): Rearrange
6186 initialization code to keep similarity to xfns.c after changes
6187 from 2011-11-05.
6188
c9e7db78
JD
61892011-11-05 Jan Djärv <jan.h.d@swipnet.se>
6190
a97f8f3f
JD
6191 * nsfns.m: Declare image_cache_refcount if GLYPH_DEBUG.
6192 (unwind_create_frame): New function (Bug#9943).
6193 (Fx_create_frame): Restructure code to be more similar to the one in
6194 xfns.c. Call record_unwind_protect with unwind_create_frame (Bug#9943).
6195 Initialize image_cache_refcount if GLYPH_DEBUG (Bug#9943).
6196 Move terminal->reference_count++ just before making the frame official
6197 (Bug#9943).
6198
6199 * nsterm.m (x_free_frame_resources): New function.
6200 (x_destroy_window): Move code to x_free_frame_resources.
6201
c9e7db78 6202 * xfns.c (unwind_create_frame): Fix comment.
6d5eb5b0
SM
6203 (Fx_create_frame, x_create_tip_frame):
6204 Move terminal->reference_count++ just before making the frame
75f1671a 6205 official. Move initialization of image_cache_refcount and
c9e7db78
JD
6206 dpyinfo_refcount before calling init_frame_faces (Bug#9943).
6207
a6fc3b5c
EZ
62082011-11-05 Eli Zaretskii <eliz@gnu.org>
6209
6210 Support MSVC build with newer versions of Visual Studio.
6211 * makefile.w32-in (TAGS-gmake): Don't use $(patsubst ...), as
6212 Nmake barfs on that. Use $(OBJ*_c) variables instead, defined on
6213 nt/gmake.defs.
6214
6215 * lisp.h (ENUM_BF): New macro, for enumerated types in bitfields,
6216 which are not supported by MSVC.
6217 (Lisp_Symbol, Lisp_Misc_Any, Lisp_Marker, Lisp_Misc_Overlay)
6218 (Lisp_Save_Value, Lisp_Free): Use ENUM_BF for enumerated types in
6219 bitfields.
6220 (Lisp_Object) [USE_LISP_UNION_TYPE]: Use ENUM_BF for enumerated
6221 types in bitfields.
6222 (DEFUN) [_MSC_VER]: Define in a different way for MSVC.
6223
6224 * w32fns.c [_MSC_VER]: DECLARE_HANDLE for any MSVC version.
6225
58179cce 62262011-11-05 Fabrice Popineau <fabrice.popineau@supelec.fr> (tiny change)
a6fc3b5c
EZ
6227
6228 Support MSVC build with newer versions of Visual Studio.
6229 * w32.c: Don't include w32api.h for MSVC.
6230 (init_environment) [_MSC_VER]: Call sys_access, not _access.
6231
6232 * s/ms-w32.h <sigset_t, ssize_t> [_MSC_VER]: Typedefs for MSVC.
6233 [_MSC_VER]: Include sys/timeb.h, sys/stat.h, and signal.h.
6234 (fstat, stat, utime) [_MSC_VER]: Redirect to their sys_* cousins.
6235 (malloc, free, realloc, calloc) [_MSC_VER]: Always redirect to the
6236 e_* cousins.
6237 (alloca) [_MSC_VER]: Define to _alloca.
6238
6239 * lisp.h (DECL_ALIGN) [_MSC_VER]: Define for MSVC.
6240
6241 * regex.c <re_char> [_MSC_VER]: A separate definition for MSVC.
6242
a58c13ed
EZ
62432011-11-04 Eli Zaretskii <eliz@gnu.org>
6244
6245 * xdisp.c (note_mouse_highlight): If either of
6246 previous/next-single-property-change returns nil, treat that as
6247 the beginning or the end of the buffer. (Bug#9955)
6248
fe0b6370
JD
62492011-11-04 Jan Djärv <jan.h.d@swipnet.se>
6250
a58c13ed 6251 * gtkutil.c (xg_make_tool_item): Add callbacks if one of wimage or
fe0b6370
JD
6252 label is not null (Bug#9951).
6253 (xg_tool_item_stale_p): Handle the fact that wimage and/or wlbl
6254 may be NULL.
6255
89bd5ee1
EZ
62562011-11-04 Eli Zaretskii <eliz@gnu.org>
6257
6258 * window.c (Fwindow_body_size): Mention in the doc string that the
6259 return value is in frame's canonical units. (Bug#9949)
6260
84c3edb9
EZ
62612011-11-03 Eli Zaretskii <eliz@gnu.org>
6262
4e2fb5c7
EZ
6263 * xdisp.c (note_mouse_highlight): Initialize `area'. (Bug#9947)
6264
84c3edb9 6265 * w32fns.c (unwind_create_frame): If needed, free the glyph
3ab15fd6 6266 matrices of the partially constructed frame. (Bug#9943)
2a58bbc1 6267 * xfns.c (unwind_create_frame): Likewise.
84c3edb9 6268
bc17a887
EZ
62692011-11-01 Eli Zaretskii <eliz@gnu.org>
6270
6271 * xdisp.c (mouse_face_from_buffer_pos): Fix a typo in a comment.
6272 Don't stop backward scan on the continuation glyph, even though
6273 its CHARPOS is positive.
6d5eb5b0
SM
6274 (mouse_face_from_buffer_pos, note_mouse_highlight):
6275 Rename cover_string to disp_string.
bc17a887 6276
4ee88440
MR
62772011-11-01 Martin Rudalics <rudalics@gmx.at>
6278
6279 * window.c (temp_output_buffer_show): Don't use
6280 Vtemp_buffer_show_specifiers.
6281 (Vtemp_buffer_show_specifiers): Remove unused variable.
6282
c2ff3c02
EZ
62832011-10-30 Eli Zaretskii <eliz@gnu.org>
6284
6285 * xdisp.c (try_cursor_movement): Make sure ROW isn't decremented
6286 past the beginning of the current glyph matrix.
6287
58179cce 62882011-10-30 Adam Sjøgren <asjo@koldfront.dk> (tiny change)
6e56383b
JD
6289
6290 * xterm.c: Include X11/Xproto.h if HAVE_GTK3.
6291 (x_error_handler): Ignore BadMatch for X_SetInputFocus for
6292 HAVE_GTK3 (Bug#9869).
b77a6a7f 6293
3b574623
JD
6294 * gtkutil.c (xg_win_to_widget, xg_event_is_for_menubar): Initialize
6295 type to GDK_NOTHING so valgrind does not complain (Bug#9901).
6296
b77a6a7f
JD
6297 * xterm.h (x_display_info): Add Xatom_net_wm_state_hidden (Bug#9893).
6298
6299 * xterm.c: Declare x_handle_net_wm_state to return int.
6300 (handle_one_xevent): Check if we are iconified but don't have
6301 _NET_WM_STATE_HIDDEN. If do, treat as deiconify (Bug#9893).
6302 (get_current_wm_state): Return non-zero if not hidden,
6303 check for _NET_WM_STATE_HIDDEN (Bug#9893).
6304 (do_ewmh_fullscreen): Ignore return value from get_current_wm_state.
6305 (x_handle_net_wm_state): Return what get_current_wm_state returns.
6306 (x_term_init): Initialize dpyinfo->Xatom_net_wm_state_hidden.
6307
196e41e4
PE
63082011-10-29 Paul Eggert <eggert@cs.ucla.edu>
6309
6310 * alloc.c (which_symbols): Declare EXTERNALLY_VISIBLE,
6311 so that this new function doesn't get optimized away by a
6312 whole-program optimizer. Make the 2nd arg EMACS_INT, not int.
6313
021f2e1a
AS
63142011-10-29 Andreas Schwab <schwab@linux-m68k.org>
6315
6316 * frame.h (MOUSE_HL_INFO): Remove excess parens.
6317
8b058d44
EZ
63182011-10-29 Eli Zaretskii <eliz@gnu.org>
6319
6320 Fix the `xbytecode' command.
6321 * .gdbinit (xprintbytestr): New command.
b50a28de 6322 (xwhichsymbols): Rename from `which'; all callers changed.
8b058d44
EZ
6323 (xbytecode): Print the byte-code string as well.
6324
4452fb80
EZ
63252011-10-29 Kim Storm <storm@cua.dk>
6326
8b058d44
EZ
6327 * alloc.c (which_symbols): New function.
6328
21b72067
AS
63292011-10-29 Andreas Schwab <schwab@linux-m68k.org>
6330
6331 * minibuf.c (read_minibuf_noninteractive): Allow reading empty
6332 line. (Bug#9903)
6333
83ed7b5c
GM
63342011-10-29 Glenn Morris <rgm@gnu.org>
6335
6336 * process.c (wait_reading_process_output): Revert 2009-08-30 change.
6337 Not clear what it was for, and it causes various bugs. (Bug#9839)
6338
5a7a728b
EZ
63392011-10-28 Eli Zaretskii <eliz@gnu.org>
6340
6341 * xdisp.c (note_mouse_highlight): Initialize `part', to avoid a
6342 possible random value that matches one of those tested as
6343 condition to clear the mouse face.
6344
d3d0842f
CY
63452011-10-28 Chong Yidong <cyd@gnu.org>
6346
6347 * xdisp.c (note_mouse_highlight): Fix use of uninitialized var.
6348
31b39d13
DN
63492011-10-28 Dan Nicolaescu <dann@ics.uci.edu>
6350
6351 * window.c (make_window): Initialize phys_cursor_on_p.
6352
9aba6043
SM
63532011-10-28 Stefan Monnier <monnier@iro.umontreal.ca>
6354
6355 * lisp.h (struct Lisp_Symbol): Update comments.
6356
c20992f4
JB
63572011-10-28 Juanma Barranquero <lekktu@gmail.com>
6358
6359 * w32font.c (w32_load_unicows_or_gdi32): Add missing return.
6360
db4f02f2
EZ
63612011-10-28 Eli Zaretskii <eliz@gnu.org>
6362
6363 Fix Emacs on Windows 9X (bug#8562). Thanks to oslsachem
6364 <oslsachem@gmail.com> for helping to debug this.
6365
6366 * w32font.c (g_b_init_is_w9x, g_b_init_get_outline_metrics_w)
6367 (g_b_init_get_text_metrics_w, g_b_init_get_glyph_outline_w)
6368 (g_b_init_get_glyph_outline_w): New static variables.
6369 (GetOutlineTextMetricsW_Proc, GetTextMetricsW_Proc)
6370 (GetGlyphOutlineW_Proc): New typedefs.
6371 (w32_load_unicows_or_gdi32, get_outline_metrics_w)
9aba6043
SM
6372 (get_text_metrics_w, get_glyph_outline_w, globals_of_w32font):
6373 New functions.
6374 (w32font_open_internal, compute_metrics):
6375 Call get_outline_metrics_w, get_text_metrics_w, and get_glyph_outline_w
db4f02f2
EZ
6376 instead of calling the "wide" APIs directly.
6377
6378 * emacs.c (main) [HAVE_NTGUI]: Call globals_of_w32font.
6379
6380 * w32.h (syms_of_w32font): Add prototype.
6381
87e68db4
JB
63822011-10-27 Juanma Barranquero <lekktu@gmail.com>
6383
6384 * window.c (Fframe_root_window, Fframe_first_window, Fwindow_end)
6385 (Fframe_selected_window, Ftemp_output_buffer_show, Fnext_window)
6386 (Fdelete_window_internal, Fwindow_parameters): Fix typos in docstrings.
6387 (Fmove_to_window_line): Doc fix.
6388
435c1d67
CY
63892011-10-27 Chong Yidong <cyd@gnu.org>
6390
6391 * process.c (make_process): Set gnutls_state to NULL.
6392
6393 * gnutls.c (emacs_gnutls_deinit): Deinit the gnutls_state if it is
6394 non-NULL, regardless of GNUTLS_INITSTAGE.
6395 (Fgnutls_boot): Cleanups. Call emacs_gnutls_deinit if we signal
6396 an error. Set process slots as soon as we allocate them.
6397
6398 * gnutls.h (GNUTLS_LOG, GNUTLS_LOG2): Fix macros.
6399
9c6c6f49
CY
64002011-10-27 Chong Yidong <cyd@gnu.org>
6401
9aba6043
SM
6402 * gnutls.c (emacs_gnutls_deinit): New function.
6403 Deallocate credentials structures as well as calling gnutls_deinit.
9c6c6f49
CY
6404 (Fgnutls_deinit, Fgnutls_boot): Use it.
6405
6406 * process.c (make_process): Initialize GnuTLS credentials to NULL.
6407 (deactivate_process): Call emacs_gnutls_deinit.
6408
657d08d3
JB
64092011-10-27 Juanma Barranquero <lekktu@gmail.com>
6410
6411 * image.c (x_create_x_image_and_pixmap):
6412 * w32.c (sys_rename, w32_delayed_load):
6413 * w32font.c (fill_in_logfont):
6414 * w32reg.c (x_get_string_resource): Silence compiler warnings.
6415
5430d399
JB
64162011-10-26 Juanma Barranquero <lekktu@gmail.com>
6417
6418 * w32fns.c (w32_default_color_map): New function,
6419 extracted from Fw32_default_color_map.
a7ef684b 6420 (Fw32_default_color_map, Fx_open_connection): Use it. (Bug#9785)
5430d399 6421
fe0055fa
PE
64222011-10-25 Paul Eggert <eggert@cs.ucla.edu>
6423
6424 * dispextern.h (Fcontrolling_tty_p): New decl (Bug#6649 part 2).
6425
e6346438
SM
64262011-10-25 Stefan Monnier <monnier@iro.umontreal.ca>
6427
6428 * keyboard.c (test_undefined): New function (bug#9751).
6429 (read_key_sequence): Use it to detect when a key is bound to `undefined'.
6430
e112cc37
ET
64312011-10-25 Enami Tsugutomo <tsugutomo.enami@jp.sony.com>
6432
6433 * sysdep.c (init_sys_modes): Fix the check for the controlling
6434 terminal (Bug#6649).
6435
7b5d6677
EZ
64362011-10-20 Eli Zaretskii <eliz@gnu.org>
6437
6438 * dispextern.h (struct bidi_it): New member next_en_type.
6439
6440 * bidi.c (bidi_line_init): Initialize the next_en_type member.
6441 (bidi_resolve_explicit_1): When next_en_pos is valid for the
6442 current character, check also for next_en_type being WEAK_EN.
6443 (bidi_resolve_weak): Don't enter the expensive loop if the current
6444 position is before next_en_pos. Record the bidi type of the first
6445 non-ET, non-BN character we find, in addition to its position.
6446 (bidi_level_of_next_char): Invalidate next_en_type when
6447 next_en_pos is over-stepped.
6448
7da0b018
PE
64492011-10-20 Paul Eggert <eggert@cs.ucla.edu>
6450
6451 Time zone name fixes for non-ASCII locales (Bug#641, Bug#9794)
6452 * editfns.c: Rewrite current-time-zone so that it invokes
6453 the equivalent of (format-time-string "%Z") to get the time zone name.
6454 This fixes a bug when the time zone name contains characters that
6455 need converting from the system time locale to Emacs internal format.
6456 This fixes a shortcoming that I introduced in my 1999-10-19 patch:
6457 that patch fixed format-time-string to do the conversion, but
6458 I forgot to fix current-time-zone.
6459 (format_time_string): New function, containing most of
6460 what Fformat_time_string used to contain.
6461 (Fformat_time_string): Rewrite in terms of format_time_string.
6462 This doesn't change this function's behavior.
6463 (current-time-zone): Rewrite to use format_time_string.
6464 This fixes the bug reported by Michael Schierl in
6465 <http://lists.gnu.org/archive/html/emacs-devel/2007-06/msg00334.html>.
6466 Jason Rumney's 2007-06-07 change worked around this bug, but
6467 didn't fix it.
6468 * systime.h (tzname, timezone): Remove no-longer-used declarations.
6469
8547b010
EZ
64702011-10-19 Eli Zaretskii <eliz@gnu.org>
6471
6472 * xdisp.c (start_display): If the character at POS is displayed
6473 via a display vector, reset IT->current.dpvec_index to zero.
12b32963
EZ
6474 (try_window_reusing_current_matrix): If a line ends in a display
6475 vector or the next line starts in a display vector, continue
6476 redrawing the window even though the character position of
6477 start_row was reached.
8547b010
EZ
6478 (Bug#9771, part 2)
6479
4e948d15
CY
64802011-10-18 Chong Yidong <cyd@gnu.org>
6481
6482 * xdisp.c (get_next_display_element): Handle U+2010 and U+2011
6483 with nobreak-char-display too.
6484
4787455f
EZ
64852011-10-18 Eli Zaretskii <eliz@gnu.org>
6486
6487 Fix part 3 of bug#9771.
6488 * bidi.c (bidi_line_init): Initialize next_en_pos to zero, not -1.
6489 (bidi_resolve_neutral): Don't enter the expensive loop looking for
6490 non-neutral characters if the current character is a paragraph
6491 separator (a.k.a. Newline). This avoids running the same
6492 expensive loop twice, once when we consume the preceding newline
6493 and the other time when the line actually needs to be displayed.
6494 Avoid the loop when we see neutrals on the base embedding level
6495 following a character whose directionality is the same as the
6496 paragraph's. This avoids running the expensive loop when a line
6497 ends in a long sequence of neutrals, like control characters.
6498 Add assertion against STRONG_AL type. Slightly rearrange code
6499 that determines the type of a neutral given the first non-neutral
6500 that follows it.
6501 (bidi_level_of_next_char): Set next_en_pos to zero when
6502 invalidating its info.
6503
2c91f553
EZ
65042011-10-17 Eli Zaretskii <eliz@gnu.org>
6505
6506 * xdisp.c (push_display_prop): Determine whether to record string
6507 or buffer position by IT->string, not by IT->method. Allow
6508 GET_FROM_DISPLAY_VECTOR as IT->method on entry. (Bug#9771, part 4)
f2ff9e88
EZ
6509 (move_it_vertically_backward): Don't look for character position
6510 immediately after the newline when in a continuation line.
6511 (Bug#9771, part 1)
2c91f553 6512
c7b08b0d
MR
65132011-10-15 Martin Rudalics <rudalics@gmx.at>
6514
6515 * window.c (coordinates_in_window): Rewrite and delabelize
6516 vertical border check. (Bug#5357) (Bug#9618)
6517
6b02f655
SM
65182011-10-14 Stefan Monnier <monnier@iro.umontreal.ca>
6519
6520 * xterm.c (frame_highlight, frame_unhighlight): Ignore unexplained
6521 errors in XSetWindowBorder (bug#9310).
6522
81d40c92
DA
65232011-10-13 Dmitry Antipov <dmantipov@yandex.ru>
6524
6525 * editfns.c (Fset_time_zone_rule): Replace free with xfree to
6526 avoid crash when xmalloc overrun checking is enabled.
6527
d4172c3b
EZ
65282011-10-13 Eli Zaretskii <eliz@gnu.org>
6529
6530 * xdisp.c (Fcurrent_bidi_paragraph_direction): Initialize
6531 itb.paragraph_dir to NEUTRAL_DIR. Fixes an occasional incorrect
6532 cursor motion with <left> and <right> arrow keys.
6533
6534 * bidi.c (bidi_init_it): Don't initialize paragraph_dir here, as
6535 some callers set that themselves.
6536
b00eea75
EZ
65372011-10-12 Eli Zaretskii <eliz@gnu.org>
6538
6539 * xdisp.c (find_row_edges): Handle the case where ROW comes from a
6540 display string and the previous row comes from the same string and
6541 is empty. (Bug#9739) (Bug#9738)
6542
8fe012c4
SM
65432011-10-12 Stefan Monnier <monnier@iro.umontreal.ca>
6544
6545 * doc.c (get_doc_string): Encode file name (bug#9735).
6546
0074aef2
EZ
65472011-10-12 Eli Zaretskii <eliz@gnu.org>
6548
79beb178
EZ
6549 * bidi.c (bidi_level_of_next_char):
6550 * xdisp.c (get_visually_first_element): Remove old incorrect
6551 comments regarding the Unicode Line Separator character.
6552
0074aef2
EZ
6553 * bidi.c (bidi_init_it): Initialize paragraph_dir to NEUTRAL_DIR.
6554
6e4b3fbe
DA
65552011-10-12 Dmitry Antipov <dmantipov@yandex.ru>
6556
6557 * alloc.c (Fgc_status): Do not access beyond zombies array
6558 boundary if nzombies > MAX_ZOMBIES.
6559 * alloc.c (dump_zombies): Add missing format specifier.
6560
0324f3af
PE
65612011-10-12 Paul Eggert <eggert@cs.ucla.edu>
6562
b5525cac
PE
6563 * xdisp.c (set_cursor_from_row): Simplify conditionals,
6564 to pacify GCC 4.6.1 x86-64 with -O2 -Wstrict-overflow.
6565
0324f3af
PE
6566 * lread.c (read_escape): Allow hex escapes as large as ?\xfffffff.
6567 Some packages use them to denote characters with modifiers.
6568
e9b5f888
AS
65692011-10-11 Andreas Schwab <schwab@linux-m68k.org>
6570
6571 * lisp.h (GCPRO1_VAR, GCPRO2_VAR, GCPRO3_VAR, GCPRO4_VAR)
6572 (GCPRO5_VAR, GCPRO6_VAR, UNGCPRO_VAR): Add whitespace to avoid
6573 matching a pp-number. Rename parameter var to var1.
6574
127827c0
SM
65752011-10-11 Stefan Monnier <monnier@iro.umontreal.ca>
6576
6577 * minibuf.c (Finternal_complete_buffer): Fix last change (bug#9709).
6578
c8fd3bd0
GM
65792011-10-08 Glenn Morris <rgm@gnu.org>
6580
6581 * callint.c (Fcall_interactively): Give a more explicit error for the
6582 'c' case with a non-character input. (Bug#8479)
6583
352ec8ff
EZ
65842011-10-08 Eli Zaretskii <eliz@gnu.org>
6585
03669ccb
EZ
6586 * xdisp.c (hscroll_window_tree): Support hscroll in right-to-left
6587 lines.
7061c986
EZ
6588 (set_cursor_from_row): Fix cursor positioning in mixed L2R+R2L
6589 lines that are hscrolled on the left.
03669ccb 6590
352ec8ff
EZ
6591 * dispnew.c (buffer_posn_from_coords): Account for a possible
6592 presence of header-line. (Bug#4426)
6593
a66cfb1c
SM
65942011-10-07 Stefan Monnier <monnier@iro.umontreal.ca>
6595
6b02f655
SM
6596 * buffer.c (syms_of_buffer) <enable-multibyte-characters>:
6597 Don't advertise functionality which we discourage or doesn't work.
a66cfb1c 6598
7c5ee88e
PE
65992011-10-07 Paul Eggert <eggert@cs.ucla.edu>
6600
6601 * alloc.c (GC_LISP_OBJECT_ALIGNMENT): Use offsetof, not __alignof__
6602 or sizeof. __alignof__ gives the wrong answer on Fedora x86-64
6603 with GCC 4.6.1 when configured with CC='gcc -m32' --with-wide-int;
6604 this makes Emacs dump core during garbage collection on rare
6605 occasions. sizeof is obviously inferior to offsetof here, so
6606 stick with offsetof.
6607 (GC_POINTER_ALIGNMENT): New macro.
6608 (mark_memory): Omit 3rd (offset) arg; caller changed.
6609 Don't assume EMACS_INT alignment is the same as pointer alignment.
6610
df1bbe5b
SM
66112011-10-03 Stefan Monnier <monnier@iro.umontreal.ca>
6612
6613 * keyboard.c (read_key_sequence_remapped): New var.
6614 (read_key_sequence): Compute remapping in the right buffer.
6615 (command_loop_1): Use read_key_sequence's remapping directly.
6616
51553db6
SM
66172011-10-02 Stefan Monnier <monnier@iro.umontreal.ca>
6618
32c1fffd
SM
6619 * dired.c (file_name_completion): Don't expand file name.
6620 (Ffile_name_completion, Ffile_name_all_completions): Expand file name
6621 before checking file name handler.
6622
51553db6
SM
6623 * minibuf.c (Finternal_complete_buffer): Only show internal buffers if
6624 they've been requested explicitly (bug#9591).
6625
b6bd1599 66262011-10-01 Andreas Schwab <schwab@linux-m68k.org>
fa2ec41f
AS
6627
6628 * keymap.c (Fsingle_key_description): Use make_specified_string
6629 instead of build_string to build string from push_key_description.
6630 (Bug#5193)
6631
f701dc2a
PE
66322011-09-30 Paul Eggert <eggert@cs.ucla.edu>
6633
4222c55d
PE
6634 * buffer.h (struct buffer): Use time_t, not int, for a time stamp.
6635 This fixes a Y2038 bug on 64-bit hosts.
6636 * buffer.c (reset_buffer):
6637 * fileio.c (Fdo_auto_save, Fset_buffer_auto_saved)
6638 (Fclear_buffer_auto_save_failure):
6639 Use 0, not -1, to represent an unset failure time, since time_t
6640 might not be signed.
6641
f701dc2a
PE
6642 Remove dependency on glibc malloc internals.
6643 * alloc.c (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
6644 Move back here from lisp.h, but with their new implementations.
6645 (XMALLOC_BASE_ALIGNMENT, COMMON_MULTIPLE, XMALLOC_HEADER_ALIGNMENT)
6646 (XMALLOC_OVERRUN_SIZE_SIZE): Move these new lisp.h macros here.
6647 * charset.c (charset_table_init): New static var.
6648 (syms_of_charset): Use it instead of xmalloc. This removes a
6649 dependency on glibc malloc internals. See Eli Zaretskii's comment in
6650 <http://lists.gnu.org/archive/html/emacs-devel/2011-09/msg00815.html>.
6651 * lisp.h (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
6652 Move back to alloc.c.
6653 (XMALLOC_BASE_ALIGNMENT, COMMON_MULTIPLE, XMALLOC_HEADER_ALIGNMENT)
6654 (XMALLOC_OVERRUN_SIZE_SIZE): Move to alloc.c.
6655
9ceebf39
JD
66562011-09-30 Jan Djärv <jan.h.d@swipnet.se>
6657
6658 * nsterm.m (windowDidResize): Call x_set_window_size only when
6659 ns_in_resize is true. Otherwise set pixelwidth/height and
6660 call change_frame_size (Bug#9628).
6661
cb993c58
PE
66622011-09-30 Paul Eggert <eggert@cs.ucla.edu>
6663
3930c88b
PE
6664 Port --enable-checking=all to Fedora 14 x86-64.
6665 * charset.c (syms_of_charset): Also account for glibc malloc's
6666 internal overhead when calculating the initial malloc maximum.
6667
cb993c58
PE
6668 Port --enable-checking=all to Fedora 14 x86.
6669 * alloc.c (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
6670 Move to lisp.h.
6671 (xmalloc_put_size, xmalloc_get_size, overrun_check_malloc)
6672 (overrun_check_realloc, overrun_check_free):
6673 Use XMALLOC_OVERRUN_SIZE_SIZE, not sizeof (size_t).
6674 That way, xmalloc returns a properly-aligned pointer even if
6675 XMALLOC_OVERRUN_CHECK is defined. The old debugging code happened
6676 to align OK on typical 64-bit hosts, but not on Fedora 14 x86.
6677 * charset.c (syms_of_charset): Take XMALLOC_OVERRUN_CHECK_OVERHEAD
6678 into account when calculating the initial malloc maximum.
6679 * lisp.h (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
6680 Move here from alloc.c, so that charset.c can use it too.
6681 Properly align; the old code wasn't right for common 32-bit hosts
6682 when configured with --enable-checking=all.
6683 (XMALLOC_BASE_ALIGNMENT, COMMON_MULTIPLE, XMALLOC_HEADER_ALIGNMENT)
6684 (XMALLOC_OVERRUN_SIZE_SIZE): New macros.
6685
31bed486
EZ
66862011-09-29 Eli Zaretskii <eliz@gnu.org>
6687
04c70788 6688 * sysdep.c (snprintf) [!EOVERFLOW]: If EOVERFLOW is not defined,
31bed486
EZ
6689 use EDOM.
6690
fbcaa2f3
EZ
66912011-09-28 Eli Zaretskii <eliz@gnu.org>
6692
6693 * xdisp.c (compute_display_string_end): If there's no display
6694 string at CHARPOS, return -1.
6695
6696 * bidi.c (bidi_fetch_char): When compute_display_string_end
6697 returns a negative value, treat the character as a normal
6698 character not covered by a display string. (Bug#9624)
6699
a239d4e9
JB
67002011-09-28 Juanma Barranquero <lekktu@gmail.com>
6701
6702 * lread.c (Fread_from_string): Fix typo in docstring.
6703
88652fd5
EZ
67042011-09-27 Eli Zaretskii <eliz@gnu.org>
6705
6706 * xdisp.c (handle_invisible_prop): If invisible text ends on a
6707 newline, reseat the iterator instead of bidi-iterating there one
6708 character at a time. (Bug#9610)
32c1fffd
SM
6709 (BUFFER_POS_REACHED_P, move_it_in_display_line_to): Bail when past
6710 TO_CHARPOS if the bidi iterator is at base embedding level.
88652fd5 6711
ed497dd4
AS
67122011-09-27 Andreas Schwab <schwab@linux-m68k.org>
6713
6714 * lread.c (readevalloop): Use correct code for NBSP.
6715 (read1): Likewise. (Bug#9608)
6716
b2bf61aa
MA
67172011-09-25 Michael Albinus <michael.albinus@gmx.de>
6718
6719 * dbusbind.c (Fdbus_register_signal): When service is not
6720 registered, use nil in Vdbus_registered_objects_table. (Bug#9581)
6721
32bbb17c
GM
67222011-09-25 Glenn Morris <rgm@gnu.org>
6723
6724 * buffer.c (truncate-lines): Doc fix.
6725
94e0933e
CY
67262011-09-24 Chong Yidong <cyd@stupidchicken.com>
6727
6728 * window.c (Fwindow_prev_buffers, Fset_window_prev_buffers)
6729 (Fset_window_next_buffers): Doc fix.
6730
cddde921
GM
67312011-09-24 Glenn Morris <rgm@gnu.org>
6732
6733 * minibuf.c (read_minibuf): Disable line truncation. (Bug#5715)
6734
1260aef1
PE
67352011-09-24 Paul Eggert <eggert@cs.ucla.edu>
6736
25b4bfa0
PE
6737 Fix minor problems found by static checking.
6738 * xdisp.c (string_from_display_spec): Don't assume vecsize fits in int.
1260aef1
PE
6739 * indent.c (Fvertical_motion): Fix == vs = typo.
6740
e3cbd34b
EZ
67412011-09-24 Eli Zaretskii <eliz@gnu.org>
6742
a66cfb1c
SM
6743 * dispnew.c (syms_of_display) <redisplay-dont-pause>:
6744 Default value is now t. Doc fix.
6bf7006f 6745
e3cbd34b 6746 * indent.c (Fvertical_motion): Compute and apply the overshoot
32c1fffd 6747 logic when moving up, not only when moving down. Fix the
e3cbd34b 6748 confusing name and values of the it_overshoot_expected variable;
32c1fffd 6749 logic changes accordingly. (Bug#9254) (Bug#9549)
e3cbd34b
EZ
6750
6751 * xdisp.c (pos_visible_p): Produce correct pixel coordinates when
6752 CHARPOS is covered by a display string which includes newlines.
6753 (move_it_vertically_backward): Avoid inflooping when START_CHARPOS
6754 is covered by a display string with embedded newlines.
6755
a3de0cbd
MA
67562011-09-24 Michael Albinus <michael.albinus@gmx.de>
6757
6758 * dbusbind.c (Fdbus_register_signal): Add match rule to
6759 Vdbus_registered_objects_table. (Bug#9581)
a66cfb1c
SM
6760 (Fdbus_register_method, Vdbus_registered_objects_table):
6761 Fix docstring.
a3de0cbd 6762
b260039d
JM
67632011-09-24 Jim Meyering <meyering@redhat.com>
6764
32c1fffd 6765 do not ignore write error for any output size
b260039d
JM
6766 The previous change was incomplete.
6767 While it makes emacs --batch detect the vast majority of stdout
6768 write failures, errors were still ignored whenever the output size is
6769 k * (BUFSIZ+1) - 4. E.g., on a system with BUFSIZ of 4096,
6770 $ emacs --batch --eval '(print (format "%4093d" 0))' > /dev/full \
6771 && echo FAIL: ignored write error
6772 FAIL: ignored write error
6773 $ emacs --batch --eval '(print (format "%20481d" 0))' > /dev/full \
6774 && echo FAIL: ignored write error
6775 FAIL: ignored write error
6776 * emacs.c (Fkill_emacs): Also test ferror. (Bug#9574)
6777
8eca8a7c
AS
67782011-09-23 Andreas Schwab <schwab@linux-m68k.org>
6779
6780 * emacs.c (Fkill_emacs): In noninteractive mode exit
6781 non-successfully if a write error occurred on stdout. (Bug#9574)
6782
3341db62
EZ
67832011-09-21 Eli Zaretskii <eliz@gnu.org>
6784
6785 * xdisp.c (pop_it): Allow it->object that is a cons cell to pass
6786 the xassert test.
6787
6788 * dispextern.h (struct it): Update the comment documenting what
6789 can it->OBJECT be.
6790
8c203dbf
EZ
67912011-09-20 Eli Zaretskii <eliz@gnu.org>
6792
6793 * xdisp.c (set_cursor_from_row): If the row ends in a newline from
6794 a display string, extend search for cursor position to end of row.
6795 (find_row_edges): If the row ends in a newline from a display
6796 string, increment its MATRIX_ROW_END_CHARPOS by one. (Bug#9549)
6797 Handle the case of a display string with multiple newlines.
fd317ddf
EZ
6798 (Fcurrent_bidi_paragraph_direction): Fix search for previous
6799 non-empty line. Fixes confusing cursor motion with arrow keys at
6800 the beginning of a line that starts with whitespace.
8c203dbf 6801
a4824228
LMI
68022011-09-19 Lars Magne Ingebrigtsen <larsi@gnus.org>
6803
6804 * lread.c (Fread_from_string): Document what FINAL-STRING-INDEX is
6805 (bug#9493).
6806
33ed493b
CY
68072011-09-18 Chong Yidong <cyd@stupidchicken.com>
6808
6809 * xfns.c (Fx_create_frame): Handle the bitmapIcon resource as
6810 boolean (Bug#9154).
6811
56cd55c8
EZ
68122011-09-18 Eli Zaretskii <eliz@gnu.org>
6813
6814 * xdisp.c (display_line): Record maximum and minimum buffer
6815 positions even if no glyphs were produced (e.g., by a zero-width
6816 stretch). Fixes bug#9530 on a TTY. Under word-wrap, don't record
6817 buffer positions that will be removed from the glyph row because
6818 they don't fit.
c02dcedf
EZ
6819 (produce_stretch_glyph): Fix a bug in :align-to on a TTY when the
6820 column is beyond frame width: don't subtract 1 "pixel" when
6821 computing width of the stretch.
3e62b7e0
EZ
6822 (reseat_at_next_visible_line_start): Undo the change made on
6823 2011-09-17 that saved paragraph information and restored it after
6824 the call to `reseat'. (Bug#9545)
56cd55c8 6825
5ed99d36 68262011-09-18 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
3390454c
YM
6827
6828 * xdisp.c (expose_window): Save original value of phys_cursor_on_p
6829 and turn window cursor on if cleared (Bug#9415).
6830
5ed99d36 68312011-09-18 Andreas Schwab <schwab@linux-m68k.org>
edb7b4dc
AS
6832
6833 * search.c (boyer_moore): Take unibyte characters from pattern
6834 literally. (Bug#9458)
6835
9bade7b2
EZ
68362011-09-18 Eli Zaretskii <eliz@gnu.org>
6837
6838 * xdisp.c (reseat_at_next_visible_line_start): Fix last change.
6839
e5e9d610
PE
68402011-09-18 Paul Eggert <eggert@cs.ucla.edu>
6841
87e4427a
PE
6842 Fix minor problem found by static checking.
6843 * xdisp.c (reseat_at_next_visible_line_start): Mark locals as
6844 initialized, to pacify gcc -Wuninitialized.
6845
e5e9d610
PE
6846 * fileio.c: Report proper errno when syscall falls.
6847 (Finsert_file_contents): Save and restore errno,
6848 so that report_file_error outputs the correct diagnostic.
6849 (Fwrite_region) [CLASH_DETECTION]: Likewise.
6850
a1674f0b
EZ
68512011-09-18 Eli Zaretskii <eliz@gnu.org>
6852
6853 * .gdbinit (pgx): Fix references to fields of `struct glyph'.
6854
fbfb6dd4
EZ
68552011-09-17 Eli Zaretskii <eliz@gnu.org>
6856
6857 * xdisp.c (produce_stretch_glyph): Another fix for changes made on
6858 2011-08-30T17:32:44Z!eliz@gnu.org. (Bug#9530)
6859
bb187662
EZ
68602011-09-17 Eli Zaretskii <eliz@gnu.org>
6861
1137e8b8 6862 * xdisp.c (reseat_at_next_visible_line_start): Keep information
6b02f655 6863 about the current paragraph and restore it after the call to reseat.
1137e8b8
EZ
6864
6865 * bidi.c (MAX_PARAGRAPH_SEARCH): New macro.
6866 (bidi_find_paragraph_start): Search back for paragraph beginning
6867 at most MAX_PARAGRAPH_SEARCH lines; if not found, return BEGV_BYTE.
6868 (bidi_move_to_visually_next): Only trigger paragraph-related
6869 computations when the last character is a newline or at EOB, not
6870 just any NEUTRAL_B. (Bug#9470)
6871
bb187662
EZ
6872 * xdisp.c (set_cursor_from_row): Don't invoke special treatment of
6873 truncated lines if point is covered by a display string. (Bug#9524)
6874
2e621251
PE
68752011-09-16 Paul Eggert <eggert@cs.ucla.edu>
6876
6877 * xselect.c: Relax test for outgoing X longs (Bug#9498).
6878 (cons_to_x_long): New function.
6879 (lisp_data_to_selection_data): Use it. Correct the test for
6880 short-versus-long data; it was negated. Break out of vector
6881 loop, for efficiency, when a long datum is discovered.
6882
91a15bc6
SM
68832011-09-16 Stefan Monnier <monnier@iro.umontreal.ca>
6884
6885 * eval.c (Fquote): Document its non-consing behavior (bug#9482).
6886
b41c3a35
EZ
68872011-09-16 Eli Zaretskii <eliz@gnu.org>
6888
6889 * image.c (tiff_handler): Work around a bug in MinGW GCC 3.x (see
6890 GCC PR/17406) by declaring this function with external scope.
6891
7812ba2d
PE
68922011-09-15 Paul Eggert <eggert@cs.ucla.edu>
6893
6894 * editfns.c (Fformat): Fix bug in text-property fix (Bug#9514).
6895 Don't mishandle (length (format "%%")) and (format "%4000s%%" "").
6896
cf7edc2a
AS
68972011-09-15 Andreas Schwab <schwab@linux-m68k.org>
6898
6899 * editfns.c (Fformat): Correctly handle text properties on "%%".
6900
bd01620e
EZ
69012011-09-15 Eli Zaretskii <eliz@gnu.org>
6902
6903 * xterm.c (x_draw_composite_glyph_string_foreground):
6904 * w32term.c (x_draw_composite_glyph_string_foreground):
6905 * term.c (encode_terminal_code):
6906 * composite.c (composition_update_it, get_composition_id):
6907 * xdisp.c (get_next_display_element)
6908 (fill_composite_glyph_string): Add comments about special meaning
6909 of TAB characters in a composition.
6910
a02719a3
PE
69112011-09-15 Paul Eggert <eggert@cs.ucla.edu>
6912
6913 * editfns.c (Fformat): Fix off-by-1 bug for "%%b" (Bug#9514).
4c122725
PE
6914 This occurs when processing a multibyte format.
6915 Problem reported by Wolfgang Jenker.
a02719a3 6916
72589a3c
JB
69172011-09-15 Johan Bockgård <bojohan@gnu.org>
6918
6919 * xdisp.c (try_cursor_movement): Only check for exact match if
6920 cursor hpos found by set_cursor_from_row is valid. (Bug#9495)
6921
1c14176c
PE
69222011-09-14 Paul Eggert <eggert@cs.ucla.edu>
6923
6924 Remove unused external symbols.
6925 * dispextern.h (calc_pixel_width_or_height): Remove decl.
6926 * xdisp.c (calc_pixel_width_or_height): Now static.
6927 * doprnt.c (exprintf) [! (HAVE_X_WINDOWS && USE_X_TOOLKIT)]: Remove.
6928 * indent.c (check_display_width):
6929 * w32term.c: Fix comment to match code.
6930 * xterm.c, xterm.h (x_catching_errors): Remove.
6931
d2eea5b5
PE
69322011-09-14 Paul Eggert <eggert@cs.ucla.edu>
6933
6934 * xselect.c: Use signed conversions more consistently (Bug#9498).
6935 (selection_data_to_lisp_data): Assume incoming selection data are
6936 signed integers, not unsigned. This is to be consistent with
6937 outgoing selection data, which was modified to use signed integers
6938 in as part of the fix to Bug#9196 in response to Jan D.'s comment
6939 in <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=9196#32> that X11
6940 expects long, not unsigned long.
6941
46888499
EZ
69422011-09-14 Eli Zaretskii <eliz@gnu.org>
6943
6944 * xdisp.c (try_window_reusing_current_matrix): Fix incorrect
6945 computation of loop end. Reported by Johan Bockgård
6946 <bojohan@gnu.org>.
6947
ef8ef9fb
CY
69482011-09-13 Chong Yidong <cyd@stupidchicken.com>
6949
6950 * frame.c (Fother_visible_frames_p): Function deleted.
6951
fa819fed
EZ
69522011-09-12 Eli Zaretskii <eliz@gnu.org>
6953
6954 * indent.c (compute_motion): Process display vector front to back
6955 rather than the other way around. (Bug#2496)
6956
2ba8e008
SM
69572011-09-12 Stefan Monnier <monnier@iro.umontreal.ca>
6958
6959 * fileio.c (Finsert_file_contents): Don't assume beg_offset is 0.
6960
20f53c69
CY
69612011-09-11 Chong Yidong <cyd@stupidchicken.com>
6962
6963 * minibuf.c (Fread_from_minibuffer): Doc fix.
6964
d562d7a4
EZ
69652011-09-11 Eli Zaretskii <eliz@gnu.org>
6966
6967 * xdisp.c (produce_stretch_glyph): Fix a typo made in changes from
6968 2011-08-30T17:32:44Z!eliz@gnu.org. (Bug#9475)
6969
1c4d7f3d
LMI
69702011-09-11 Lars Magne Ingebrigtsen <larsi@gnus.org>
6971
6972 * fileio.c (Fvisited_file_modtime): Document `(-1 65535)' as a
6973 value for non-existent files.
6974
b885bf36
EZ
69752011-09-11 Eli Zaretskii <eliz@gnu.org>
6976
6977 * fileio.c (Finsert_file_contents): If the file cannot be opened,
6978 set its "size" to -1. This will set the modtime_size field of
6979 the corresponding buffer to -1, which is what
6980 verify-visited-file-modtime expects for files that do not exist.
6981 (Bug#9139)
6982
6612f0bf
PE
69832011-09-11 Paul Eggert <eggert@cs.ucla.edu>
6984
6985 * keymap.h (KEY_DESCRIPTION_SIZE, push_key_description): Move decls
6986 here ...
6987 * lisp.h: ... from here. push_key_description is no longer
6988 defined in keyboard.c, so its declaration should not be in
6989 lisp.h's "Defined in keyboard.c" section, and KEY_DESCRIPTION_SIZE
6990 logically belongs with push_key_description.
6991
dfb3f755
PE
69922011-09-10 Paul Eggert <eggert@cs.ucla.edu>
6993
6994 * buffer.h: Include <sys/types.h> instead of <time.h>.
6995 Otherwise, off_t wasn't defined on FreeBSD 9.0-BETA2 i386.
6996 Problem reported by Herbert J. Skuhra.
6997
3134906c
LMI
69982011-09-10 Lars Magne Ingebrigtsen <larsi@gnus.org>
6999
7000 * xml.c (parse_region): Make the parsing work for
7001 non-comment-starting XML files again (bug#9144).
7002
8d903f4e
AS
70032011-09-10 Andreas Schwab <schwab@linux-m68k.org>
7004
7005 * image.c (gif_load): Fix calculation of bottom and right corner.
7006 (Bug#9468)
7007
80ad64f4
EZ
70082011-09-10 Eli Zaretskii <eliz@gnu.org>
7009
7010 * xdisp.c (MAX_DISP_SCAN): Decrease to 250. Prevents sluggish
7011 redisplay in small windows.
7012
208a048d
EZ
70132011-09-09 Eli Zaretskii <eliz@gnu.org>
7014
7015 * frame.c (x_report_frame_params): Cast to avoid compiler warnings.
7016
9b1c252e
MR
70172011-09-08 Martin Rudalics <rudalics@gmx.at>
7018
7019 * window.c (Fset_window_prev_buffers, Fset_window_next_buffers):
7020 Operate on live windows only.
7021
2949f33b
JB
70222011-09-08 Juanma Barranquero <lekktu@gmail.com>
7023
7024 * emacs.c (my_heap_start): #ifdef to avoid warnings when unused.
7025
e08dcafd
EZ
70262011-09-07 Eli Zaretskii <eliz@gnu.org>
7027
7028 * xdisp.c (move_it_in_display_line_to): Call RESTORE_IT on ppos_it
7029 only under bidi iteration.
7030
115b96bd
JD
70312011-09-07 Jan Djärv <jan.h.d@swipnet.se>
7032
7033 * gtkutil.c (xg_make_tool_item): Insert comment about eventbox.
7034
c8199d0f
PE
70352011-09-06 Paul Eggert <eggert@cs.ucla.edu>
7036
7037 isnan: Fix porting problem to Solaris 10 with bundled gcc.
7038 Without this fix, the command to link temacs failed due to an
7039 undefined symbol __builtin_isnan. This is because
7040 /usr/include/iso/math_c99.h #defines isnan(x) to
7041 __builtin_isnan(x), but the bundled gcc, which identifies itself
7042 as gcc 3.4.3 (csl-sol210-3_4-branch+sol_rpath), does not have
7043 a __builtin_isnan.
7044 * floatfns.c (isnan): #undef, and then #define to a clone of
7045 what's in data.c.
7046 (Fisnan): Always define, since it's always available now.
7047 (syms_of_floatfns): Always define isnan at the Lisp level.
7048
e39b275c 70492011-09-06 Paul Eggert <eggert@cs.ucla.edu>
1c262cae
PE
7050
7051 * Makefile.in (gl-stamp): move-if-change now in build-aux (Bug#9169).
7052
b2db44d9 70532011-09-06 Paul Eggert <eggert@cs.ucla.edu>
728f8f0a 7054
f4af5137 7055 * fileio.c: Fix bugs with large file offsets (Bug#9428).
728f8f0a
PE
7056 The previous code assumed that file offsets (off_t values) fit in
7057 EMACS_INT variables, which is not true on typical 32-bit hosts.
7058 The code messed up by falsely reporting buffer overflow in cases
7059 such as (insert-file-contents "big" nil 1 2) into an empty buffer
7060 when "big" contains more than 2**29 bytes, even though this
7061 inserts just one byte and does not overflow the buffer.
7062 (Finsert_file_contents): Store file offsets as off_t
7063 values, not as EMACS_INT values. Check for overflow when
7064 converting between EMACS_INT and off_t. When checking for
7065 buffer overflow or for overlap, take the offsets into account.
7066 Don't use EMACS_INT for small values where int suffices.
7067 When checking for overlap, fix a typo: ZV was used where
7068 ZV_BYTE was intended.
7069 (Fwrite_region): Don't assume off_t fits into 'long'.
7070 * buffer.h (struct buffer.modtime_size): Now off_t, not EMACS_INT.
7071
ecfc0a49
MA
70722011-09-05 Michael Albinus <michael.albinus@gmx.de>
7073
7074 * dbusbind.c (xd_signature_cat): Rename from signature_cat.
7075
6511acf2 70762011-09-04 Paul Eggert <eggert@cs.ucla.edu>
61bfeeb7 7077
0999621a 7078 sprintf-related integer and memory overflow issues (Bug#9412).
62f19c19
PE
7079
7080 * doprnt.c (doprnt): Support printing ptrdiff_t and intmax_t values.
8666506e 7081 (esprintf, exprintf, evxprintf): New functions.
62f19c19 7082 * keyboard.c (command_loop_level): Now EMACS_INT, not int.
6b02f655 7083 (cmd_error): Kbd macro iterations count is now EMACS_INT, not int.
62f19c19
PE
7084 (modify_event_symbol): Do not assume that the length of
7085 name_alist_or_stem is safe to alloca and fits in int.
7086 (Fexecute_extended_command): Likewise for function name and binding.
7087 (Frecursion_depth): Wrap around reliably on integer overflow.
7088 * keymap.c (push_key_description): First arg is now EMACS_INT, not int,
7089 since some callers pass EMACS_INT values.
7090 (Fsingle_key_description): Don't crash if symbol name contains more
7091 than MAX_ALLOCA bytes.
7092 * minibuf.c (minibuf_level): Now EMACS_INT, not int.
7093 (get_minibuffer): Arg is now EMACS_INT, not int.
7094 * lisp.h (get_minibuffer, push_key_description): Reflect API changes.
8666506e 7095 (esprintf, exprintf, evxprintf): New decls.
62f19c19
PE
7096 * window.h (command_loop_level, minibuf_level): Reflect API changes.
7097
2be7d702
PE
7098 * dbusbind.c (signature_cat): New function.
7099 (xd_signature, Fdbus_register_signal):
2ea16b89
PE
7100 Do not overrun buffer; instead, report string overflow.
7101
9d1df220
PE
7102 * dispnew.c (add_window_display_history): Don't overrun buffer.
7103 Truncate instead; this is OK since it's just a log.
7104
33ef5c64
PE
7105 * editfns.c (Fcurrent_time_zone): Don't overrun buffer
7106 even if the time zone offset is outlandishly large.
7107 Don't mishandle offset == INT_MIN.
7108
66c6fdd5
PE
7109 * emacs.c (main) [NS_IMPL_COCOA]: Don't overrun buffer
7110 when creating daemon; the previous buffer-overflow check was incorrect.
7111
d749b01b
PE
7112 * eval.c (verror): Simplify by rewriting in terms of evxprintf,
7113 which has the guts of the old verror function.
7114
b5cd1905
PE
7115 * filelock.c (lock_file_1, lock_file): Don't blindly alloca long name;
7116 use SAFE_ALLOCA instead. Use esprintf to avoid int-overflow issues.
7117
6e1a67fb
PE
7118 * font.c: Include <float.h>, for DBL_MAX_10_EXP.
7119 (font_unparse_xlfd): Don't blindly alloca long strings.
c21721cc 7120 Don't assume XINT result fits in int, or that XFLOAT_DATA * 10
8666506e 7121 fits in int, when using sprintf. Use single snprintf to count
c21721cc
PE
7122 length of string rather than counting it via multiple sprintfs;
7123 that's simpler and more reliable.
c21721cc
PE
7124 (font_unparse_fcname): Use it to avoid sprintf buffer overrun.
7125 (generate_otf_features) [0 && HAVE_LIBOTF]: Use esprintf, not
7126 sprintf, in case result does not fit in int.
7127
c57b67fc
PE
7128 * fontset.c (num_auto_fontsets): Now printmax_t, not int.
7129 (fontset_from_font): Print it.
7130
8a401434
PE
7131 * frame.c (tty_frame_count): Now printmax_t, not int.
7132 (make_terminal_frame, set_term_frame_name): Print it.
7133 (x_report_frame_params): In X, window IDs are unsigned long,
7134 not signed long, so print them as unsigned.
7135 (validate_x_resource_name): Check for implausibly long names,
7136 and don't assume name length fits in 'int'.
7137 (x_get_resource_string): Don't blindly alloca invocation name;
7138 use SAFE_ALLOCA. Use esprintf, not sprintf, in case result does
7139 not fit in int.
7140
6e1a67fb
PE
7141 * gtkutil.c: Include <float.h>, for DBL_MAX_10_EXP.
7142 (xg_check_special_colors, xg_set_geometry):
84722b3d
PE
7143 Make sprintf buffers a bit bigger, to avoid potential buffer overrun.
7144
0df02bf3
PE
7145 * lread.c (dir_warning): Don't blindly alloca buffer; use SAFE_ALLOCA.
7146 Use esprintf, not sprintf, in case result does not fit in int.
7147
48e30793
PE
7148 * macros.c (executing_kbd_macro_iterations): Now EMACS_INT, not int.
7149 (Fend_kbd_macro): Don't mishandle MOST_NEGATIVE_FIXNUM by treating
7150 it as a large positive number.
7151 (Fexecute_kbd_macro): Don't assume repeat count fits in int.
7152 * macros.h (executing_kbd_macro_iterations): Now EMACS_INT, not int.
7153
a66ff6d8
PE
7154 * nsterm.m ((NSSize)windowWillResize): Use esprintf, not sprintf,
7155 in case result does not fit in int.
7156
aca216ff
PE
7157 * print.c (float_to_string): Detect width overflow more reliably.
7158 (print_object): Make sprintf buffer a bit bigger, to avoid potential
7159 buffer overrun. Don't assume list length fits in 'int'. Treat
7160 print length of 0 as 0, not as infinity; to be consistent with other
7161 uses of print length in this function. Don't overflow print length
7162 index. Don't assume hash table size fits in 'long', or that
7163 vectorlike size fits in 'unsigned long'.
7164
31c286f7
PE
7165 * process.c (make_process): Use printmax_t, not int, to format
7166 process-name gensyms.
7167
55e5faa1
PE
7168 * sysdep.c (snprintf) [! HAVE_SNPRINTF]: New function.
7169
80f2e268
PE
7170 * term.c (produce_glyphless_glyph): Make sprintf buffer a bit bigger
7171 to avoid potential buffer overrun.
7172
670741ab
PE
7173 * xfaces.c (x_update_menu_appearance): Don't overrun buffer
7174 if X resource line is longer than 512 bytes.
7175
b7163a50
PE
7176 * xfns.c (x_window): Make sprintf buffer a bit bigger
7177 to avoid potential buffer overrun.
7178
ae58ff1f
PE
7179 * xterm.c (x_io_error_quitter): Don't overrun sprintf buffer.
7180
c43c8a6a
PE
7181 * xterm.h (x_check_errors): Add ATTRIBUTE_FORMAT_PRINTF.
7182
3f8236f4
PE
71832011-09-04 Paul Eggert <eggert@cs.ucla.edu>
7184
53e9fe90 7185 Integer overflow fixes for scrolling, etc.
6511acf2
PE
7186 Without these, Emacs silently mishandles large integers sometimes.
7187 For example, "C-u 4294967297 M-x recenter" was treated as if
53e9fe90
PE
7188 it were "C-u 1 M-x recenter" on a typical 64-bit host.
7189
6511acf2
PE
7190 * xdisp.c (try_window_id): Check Emacs fixnum range before
7191 converting to 'int'.
806add1d 7192
6511acf2 7193 * window.c (window_scroll_line_based, Frecenter):
71f02bc5
PE
7194 Check that an Emacs fixnum is in range before assigning it to 'int'.
7195 (Frecenter, Fmove_to_window_line): Use EMACS_INT, not int, for
7196 values converted from Emacs fixnums.
7197 (Frecenter): Don't wrap around a line count if it is out of 'int'
7198 range; instead, treat it as an extreme value.
7199 (Fset_window_configuration, compare_window_configurations):
7200 Use ptrdiff_t, not int, for index that might exceed 2 GiB.
7201
6511acf2
PE
7202 * search.c (Freplace_match): Use ptrdiff_t, not int, for indexes
7203 that can exceed INT_MAX. Check that EMACS_INT value is in range
7204 before assigning it to the (possibly-narrower) index.
a0efffc8
PE
7205 (match_limit): Don't assume that a fixnum can fit in 'int'.
7206
6511acf2 7207 * print.c (print_object): Use ptrdiff_t, not int, for index that can
29ebea3b
PE
7208 exceed INT_MAX.
7209
6511acf2 7210 * indent.c (position_indentation): Now takes ptrdiff_t, not int.
3f8236f4
PE
7211 (Fvertical_motion): Don't wrap around LINES values that don't fit
7212 in 'int'. Instead, treat them as extreme values. This is good
7213 enough for windows, which can't have more than INT_MAX lines anyway.
7214
fcb901a7
LMI
72152011-09-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
7216
0f2f6b6d
LMI
7217 * Require libxml/parser.h to avoid compilation warning.
7218
fcb901a7
LMI
7219 * emacs.c (shut_down_emacs): Call xmlCleanupParser on shutdown.
7220
7221 * xml.c (parse_region): Don't call xmlCleanupParser after parsing,
7222 since this reportedly can destroy thread storage.
7223
6e20a0d4
CY
72242011-08-30 Chong Yidong <cyd@stupidchicken.com>
7225
7226 * syntax.c (find_defun_start): Update all cache variables if
7227 exiting early (Bug#9401).
7228
148ae00e
EZ
72292011-08-30 Eli Zaretskii <eliz@gnu.org>
7230
f6cfbd8f
EZ
7231 * image.c (x_bitmap_pixmap): Cast to int to avoid compiler warnings.
7232
148ae00e
EZ
7233 * xdisp.c (produce_stretch_glyph): No longer static, compiled also
7234 when HAVE_WINDOW_SYSTEM is not defined. Support both GUI and TTY
7235 frames. Call tty_append_glyph in the TTY case. (Bug#9402)
7236
7237 * term.c (tty_append_glyph): New function.
7238 (produce_stretch_glyph): Static function and its prototype deleted.
7239
a66cfb1c
SM
7240 * dispextern.h (produce_stretch_glyph, tty_append_glyph):
7241 Add prototypes.
148ae00e 7242
c4a07a4c
PE
72432011-08-29 Paul Eggert <eggert@cs.ucla.edu>
7244
7245 * image.c (parse_image_spec): Check for nonnegative, not for positive,
7246 when checking :margin (Bug#9390).
7247 (IMAGE_NON_NEGATIVE_INTEGER_VALUE_OR_PAIR):
a66cfb1c 7248 Rename from IMAGE_POSITIVE_INTEGER_VALUE_OR_PAIR,
c4a07a4c
PE
7249 so that the name doesn't mislead. All uses changed.
7250
6bc8cd65
JB
72512011-08-28 Johan Bockgård <bojohan@gnu.org>
7252
7253 * term.c (init_tty) [HAVE_GPM]: Move mouse settings after
7254 set_tty_hooks.
7255
dca4927e
EZ
72562011-08-27 Eli Zaretskii <eliz@gnu.org>
7257
7258 * xdisp.c (move_it_to): Don't bail out early when reaching
7259 position beyond to_charpos, if we are scanning backwards.
7260 (move_it_vertically_backward): When DY == 0, make sure we get to
7261 the first character in the line after the newline.
7262
f2cad773
PE
72632011-08-27 Paul Eggert <eggert@cs.ucla.edu>
7264
7265 * ccl.c: Improve and simplify overflow checking (Bug#9196).
7266 (ccl_driver): Do not generate an out-of-range pointer.
7267 (Fccl_execute_on_string): Remove unnecessary check for
7268 integer overflow, noted by Stefan Monnier in
7269 <http://lists.gnu.org/archive/html/emacs-devel/2011-08/msg00979.html>.
7270 Remove a FIXME that didn't need fixing.
7271 Simplify the newly-introduced buffer reallocation code.
7272
0cae2cdb
JB
72732011-08-27 Juanma Barranquero <lekktu@gmail.com>
7274
7275 * makefile.w32-in ($(BLD)/alloc.$(O)): Depend on lib/verify.h.
7276
5fc295a4 72772011-08-26 Paul Eggert <eggert@cs.ucla.edu>
ddff3151 7278
70c60eb2 7279 Integer and memory overflow issues (Bug#9196).
726e0ab1 7280
d31850da
PE
7281 * doc.c (get_doc_string): Rework so that
7282 get_doc_string_buffer_size is the actual buffer size, rather than
7283 being 1 less than the actual buffer size; this makes xpalloc more
7284 convenient.
7285
a69fbedb
PE
7286 * image.c (x_allocate_bitmap_record, cache_image):
7287 * xselect.c (Fx_register_dnd_atom):
7288 Simplify previous changes by using xpalloc.
7289
fe5c5d37
PE
7290 * buffer.c (overlay_str_len): Now ptrdiff_t, not EMACS_INT,
7291 since either will do and ptrdiff_t is convenient with xpalloc.
7292
0065d054
PE
7293 * charset.c (charset_table_size)
7294 (struct charset_sort_data.priority): Now ptrdiff_t.
7295 (charset_compare): Don't overflow if priorities differ greatly.
7296 (Fsort_charsets): Don't assume list length fits in int.
7297 Check for size-calculation overflow when allocating sort data.
7298 (syms_of_charset): Allocate an initial charset table that is
7299 just under 64 KiB, to avoid problems with glibc malloc and mmap.
7300
7301 * cmds.c (internal_self_insert): Check for size-calculation overflow.
7302
7303 * composite.h (struct composition.glyph_len): Now int, not unsigned.
7304 The actual value is always <= INT_MAX, and leaving it unsigned made
7305 overflow checking harder.
7306
7307 * dispextern.h (struct glyph_matrix.rows_allocated)
7308 (struct face_cache.size): Now ptrdiff_t, for convenience in use
7309 with xpalloc. The values are still always <= INT_MAX.
7310
7311 * indent.c (compute_motion): Adjust to region_cache_forward sig change.
7312
7313 * lisp.h (xnmalloc, xnrealloc, xpalloc): New decls.
7314 (SAFE_NALLOCA): New macro.
7315
7316 * region-cache.c (struct boundary.pos, find_cache_boundary)
7317 (move_cache_gap, insert_cache_boundary, delete_cache_boundaries)
7318 (set_cache_region, invalidate_region_cache)
7319 (revalidate_region_cache, know_region_cache, region_cache_forward)
7320 (region_cache_backward, pp_cache):
7321 Use ptrdiff_t, not EMACS_INT, since either will do. This is needed
7322 so that ptrdiff_t * can be passed to xpalloc.
7323 (struct region_cache): Similarly, for gap_start, gap_len, cache_len,
7324 beg_unchanged, end_unchanged, buffer_beg, buffer_end members.
7325 (pp_cache): Don't assume cache_len fits in int.
7326 * region-cache.h: Adjust extern decls to match.
7327
7328 * search.c (scan_buffer, Freplace_match): Use ptrdiff_t, not
7329 EMACS_INT, since either will do, for xpalloc.
7330
7331 * alloc.c: Include verify.h, and check that int fits in ptrdiff_t.
7332 (xnmalloc, xnrealloc, xpalloc): New functions.
7333
726e0ab1
PE
7334 * bidi.c (bidi_shelve_header_size): New constant.
7335 (bidi_cache_ensure_space, bidi_shelve_cache): Use it.
7336 (bidi_cache_ensure_space): Avoid integer overflow when allocating.
7337
51f30bc5 7338 * bidi.c (bidi_cache_shrink):
726e0ab1
PE
7339 * buffer.c (overlays_at, overlays_in, record_overlay_string)
7340 (overlay_strings):
7341 Don't update size of array until after memory allocation succeeds,
7342 because xmalloc/xrealloc may not return.
0065d054
PE
7343 (struct sortstrlist.bytes): Now ptrdiff_t, as EMACS_INT doesn't help
7344 now that we have proper integer overflow checking.
7345 (record_overlay_string, overlay_strings): Catch overflows when
7346 calculating size of overlay_str_buf.
726e0ab1 7347
0065d054
PE
7348 * callproc.c (Fcall_process): Check for size overflow when
7349 calculating size of args2.
7350 (child_setup): Avoid overflow by using size_t rather than ptrdiff_t.
7351 Normally we prefer signed values, but sticking with ptrdiff_t would
7352 require adding more-complicated checks.
726e0ab1
PE
7353
7354 * ccl.c (Fccl_execute_on_string): Check for memory overflow.
7355 Use ptrdiff_t rather than EMACS_INT where ptrdiff_t will do.
7356 Redo buffer-overflow calculations to avoid integer overflow.
0065d054 7357 Add a FIXME comment where memory seems to be over-allocated.
726e0ab1
PE
7358
7359 * character.c (Fstring): Check for size-calculation overflow.
7360
7361 * coding.c (produce_chars): Redo buffer-overflow calculations to avoid
7362 unnecessary integer overflow. Check for size overflow.
7363 (encode_coding_object): Don't update size until xmalloc succeeds.
7364
7365 * composite.c (get_composition_id): Check for overflow in glyph
7366 length calculations.
7367
7368 Integer and memory overflow fixes for display code.
7369 * dispextern.h (struct glyph_pool.nglyphs): Now ptrdiff_t, not int.
7370 * dispnew.c (adjust_glyph_matrix, realloc_glyph_pool)
7371 (scrolling_window): Check for overflow in size calculations.
7372 (line_draw_cost, realloc_glyph_pool, add_row_entry):
7373 Don't assume glyph table len fits in int.
7374 (struct row_entry.bucket, row_entry_pool_size, row_entry_idx)
7375 (row_table_size): Now ptrdiff_t, not int.
7376 (scrolling_window): Avoid overflow in size calculations.
7377 Don't update size until allocation succeeds.
7378 * fns.c (concat): Check for overflow in size calculations.
7379 (next_almost_prime): Verify NEXT_ALMOST_PRIME_LIMIT.
7380 * lisp.h (RANGED_INTEGERP, TYPE_RANGED_INTEGERP): New macros.
7381 (NEXT_ALMOST_PRIME_LIMIT): New constant.
7382
7383 * doc.c (get_doc_string_buffer_size): Now ptrdiff_t, not int.
7384 (get_doc_string): Check for size calculation overflow.
7385 Don't update size until allocation succeeds.
7386 (get_doc_string, Fsubstitute_command_keys): Use ptrdiff_t, not
7387 EMACS_INT, where ptrdiff_t will do.
7388 (Fsubstitute_command_keys): Check for string overflow.
7389
7390 * editfns.c (set_time_zone_rule): Don't assume environment length
7391 fits in int.
7392 (message_length): Now ptrdiff_t, not int.
7393 (Fmessage_box): Don't update size until allocation succeeds.
7394 Don't assume message length fits in int.
7395 (Fformat): Use ptrdiff_t, not EMACS_INT, where ptrdiff_t will do.
7396
0065d054
PE
7397 * emacs.c (main): Do not reallocate argv, since there is a null at
7398 the end that can be overwritten, and this way there's no need to
7399 worry about size-calculation overflow.
7400 (sort_args): Check for size-calculation overflow.
726e0ab1
PE
7401
7402 * eval.c (init_eval_once, grow_specpdl): Don't update size until
7403 alloc succeeds.
7404 (call_debugger, grow_specpdl): Redo calculations to avoid overflow.
7405
7406 * frame.c (set_menu_bar_lines, x_set_frame_parameters)
7407 (x_set_scroll_bar_width, x_figure_window_size):
7408 Check for integer overflow.
7409 (x_set_alpha): Do not assume XINT fits in int.
7410
7411 * frame.h (struct frame): Use int, not EMACS_INT, where int works.
7412 This is for the members text_lines, text_cols, total_lines, total_cols,
7413 where the system imposes an 'int' limit.
7414
7415 * fringe.c (Fdefine_fringe_bitmap):
7416 Don't update size until alloc works.
7417
7418 * ftfont.c (ftfont_get_open_type_spec, setup_otf_gstring)
7419 (ftfont_shape_by_flt): Check for integer overflow in size calculations.
7420
7421 * gtkutil.c (get_utf8_string, xg_store_widget_in_map):
7422 Check for size-calculation overflow.
7423 (get_utf8_string): Use ptrdiff_t, not size_t, where either will
7424 do, as we prefer signed integers.
7425 (id_to_widget.max_size, id_to_widget.used)
7426 (xg_store_widget_in_map, xg_remove_widget_from_map)
7427 (xg_get_widget_from_map, xg_get_scroll_id_for_window)
7428 (xg_remove_scroll_bar, xg_update_scrollbar_pos):
7429 Use and return ptrdiff_t, not int.
7430 (xg_gtk_scroll_destroy): Don't assume ptrdiff_t fits in int.
7431 * gtkutil.h: Change prototypes to match the above.
7432
7433 * image.c (RANGED_INTEGERP, TYPE_RANGED_INTEGERP): Remove; these
7434 are duplicate now that they've been promoted to lisp.h.
7435 (x_allocate_bitmap_record, x_alloc_image_color)
7436 (make_image_cache, cache_image, xpm_load):
7437 Don't update size until alloc is done.
7438 (xpm_load, lookup_rgb_color, lookup_pixel_color, x_to_xcolors)
7439 (x_detect_edges):
3256efce 7440 Check for size calculation overflow.
726e0ab1
PE
7441 (ct_colors_allocated_max): New constant.
7442 (x_to_xcolors, x_detect_edges): Reorder multiplicands to avoid
7443 overflow.
3256efce 7444
726e0ab1
PE
7445 * keyboard.c (read_char, menu_bar_items, tool_bar_items)
7446 (read_char_x_menu_prompt, read_char_minibuf_menu_width)
7447 (read_char_minibuf_menu_prompt, follow_key, read_key_sequence):
7448 Use ptrdiff_t, not int, to count maps.
7449 (read_char_minibuf_menu_prompt): Check for overflow in size
a66cfb1c
SM
7450 calculations. Don't update size until allocation succeeds.
7451 Redo calculations to avoid overflow.
726e0ab1
PE
7452 * keyboard.h: Change prototypes to match the above.
7453
7454 * keymap.c (cmm_size, current_minor_maps): Use ptrdiff_t, not int,
7455 to count maps.
7456 (current_minor_maps): Check for size calculation overflow.
7457 * keymap.h: Change prototypes to match the above.
7458
7459 * lread.c (read1, init_obarray): Don't update size until alloc done.
7460
7461 * macros.c (Fstart_kbd_macro): Don't update size until alloc done.
7462 (store_kbd_macro_char): Reorder multiplicands to avoid overflow.
7463
726e0ab1
PE
7464 * nsterm.h (struct ns_color_table.size, struct ns_color_table.avail):
7465 Now ptrdiff_t, not int.
7466 * nsterm.m (ns_index_color): Use ptrdiff_t, not int, for table indexes.
7467 (ns_draw_fringe_bitmap): Rewrite to avoid overflow.
7468
7469 * process.c (Fnetwork_interface_list): Check for overflow
7470 in size calculation.
7471
7472 * region-cache.c (move_cache_gap): Check for size calculation overflow.
7473
7474 * scroll.c (do_line_insertion_deletion_costs): Check for size calc
7475 overflow. Don't bother calling xmalloc when xrealloc will do.
7476
7477 * search.c (Freplace_match): Check for size calculation overflow.
7478 (Fset_match_data): Don't assume list lengths fit in 'int'.
7479
7480 * sysdep.c (system_process_attributes): Use ptrdiff_t, not int,
7481 for command line length. Do not attempt to address one before the
7482 beginning of an array, as that's not portable.
7483
7484 * term.c (max_frame_lines): Remove; unused.
7485 (encode_terminal_src_size, encode_terminal_dst_size): Now ptrdiff_t,
7486 not int.
7487 (encode_terminal_code, calculate_costs): Check for size
7488 calculation overflow.
7489 (encode_terminal_code): Use ptrdiff_t, not int, to record glyph
7490 table lengths and related sizes. Don't update size until alloc
7491 done. Redo calculations to avoid overflow.
7492 (calculate_costs): Don't bother calling xmalloc when xrealloc will do.
7493
7494 * termcap.c (tgetent): Use ptrdiff_t, not int, to record results of
7495 subtracting pointers.
7496 (gobble_line): Check for overflow more carefully. Don't update size
7497 until alloc done.
7498
7499 * tparam.c (tparam1): Use ptrdiff_t, not int, for sizes.
7500 Don't update size until alloc done.
7501 Redo size calculations to avoid overflow.
7502 Check for size calculation overflow.
0065d054 7503 (main) [DEBUG]: Fix typo in invoking tparam1.
726e0ab1
PE
7504
7505 * xdisp.c (store_mode_line_noprop_char, x_consider_frame_title):
7506 Use ptrdiff_t, not int, for sizes.
7507 (store_mode_line_noprop_char): Don't update size until alloc done.
7508
0065d054
PE
7509 * xfaces.c (lface_id_to_name_size, Finternal_make_lisp_face):
7510 Use ptrdiff_t, not int, for sizes.
7511 (Finternal_make_lisp_face, cache_face):
7512 Check for size calculation overflow.
7513 (cache_face): Treat size calculation overflows as if they were
7514 memory exhaustion (the usual treatment), rather than aborting.
726e0ab1
PE
7515
7516 * xfns.c (x_encode_text, x_set_name_internal)
7517 (Fx_change_window_property): Use ptrdiff_t, not int, to count
7518 sizes, since they can exceed INT_MAX in size. Check for size
7519 calculation overflow.
7520
0065d054
PE
7521 * xgselect.c (gfds_size): Now ptrdiff_t, for convenience with xpalloc.
7522 (xg_select): Check for size calculation overflow.
726e0ab1
PE
7523 Don't update size until alloc done.
7524
0065d054 7525 * xrdb.c (get_environ_db): Don't assume path length fits in int,
726e0ab1 7526 as sprintf is limited to int lengths.
1d526e2f 7527
252c5ee1
PE
7528 * xselect.c (X_LONG_SIZE, X_SHRT_MAX, X_SHRT_MIN, X_LONG_MAX)
7529 (X_LONG_MIN): New macros.
864d7ce7
PE
7530 Use them to make the following changes clearer.
7531 (MAX_SELECTION_QUANTUM): Make the other bounds on this value clearer.
7532 This change doesn't affect the value now, but it may help remind
7533 future maintainers not to raise the value too much later.
7534 (SELECTION_QUANTUM): Remove, replacing with ...
7535 (selection_quantum): ... new function, which avoids overflow.
7536 All uses changed.
7537 (struct selection_data.size): Now ptrdiff_t, not int, to avoid
7538 assumption that selection length fits in 'int'.
7539 (x_reply_selection_request, x_handle_selection_request)
7540 (x_get_window_property, receive_incremental_selection)
7541 (x_get_window_property_as_lisp_data, selection_data_to_lisp_data)
7542 (lisp_data_to_selection_data, clean_local_selection_data):
7543 Use ptrdiff_t, not int, to record length of selection.
7544 (x_reply_selection_request, x_get_window_property)
7545 (receive_incremental_selection, x_property_data_to_lisp):
7546 Redo calculations to avoid overflow.
7547 (x_reply_selection_request): When sending hint, ceiling it at
252c5ee1 7548 X_LONG_MAX rather than relying on wraparound overflow to send
864d7ce7
PE
7549 something.
7550 (x_get_window_property, receive_incremental_selection)
7551 (lisp_data_to_selection_data, x_property_data_to_lisp):
7552 Check for size-calculation overflow.
7553 (x_get_window_property, receive_incremental_selection)
7554 (lisp_data_to_selection_data, Fx_register_dnd_atom):
7555 Don't store size until memory allocation succeeds.
7556 (x_get_window_property): Plug memory leak on memory exhaustion.
7557 Don't double-block input; malloc is safe here. Don't assume 2**34
7558 - 4 fits in unsigned long. Add an xassert to check
7559 XGetWindowProperty overflow. Be more careful about overflow
7560 calculations, and distinguish size from memory overflow better.
7561 (receive_incremental_selection): When tracing, don't assume
7562 unsigned int is less than INT_MAX.
7563 (x_selection_data_to_lisp_data): Remove unnecessary (and in theory
7564 harmful) conversions of unsigned short to int.
7565 (lisp_data_to_selection_data): Don't assume that integers
7566 in the range -65535 through -1 fit in an X unsigned short.
7567 Don't assume that ULONG_MAX == X_ULONG_MAX. Don't store into
7568 result parameters unless successful. Rely on cons_to_unsigned
7569 to report problems with elements; the old code wasn't right anyway.
7570 (x_check_property_data): Check for int overflow; we cannot use
7571 a wider type due to X limits.
7572 (x_handle_dnd_message): Use unsigned int, to avoid int overflow.
7573
726e0ab1 7574 * xsmfns.c (smc_save_yourself_CB): Check for size calc overflow.
34db673b 7575
0065d054
PE
7576 * xterm.c (x_color_cells, x_send_scrollbar_event, handle_one_xevent)
7577 (x_term_init): Check for size calculation overflow.
726e0ab1
PE
7578 (x_color_cells): Don't store size until memory allocation succeeds.
7579 (handle_one_xevent): Use ptrdiff_t, not int, for byte counts.
0065d054 7580 Don't assume alloca size is less than MAX_ALLOCA.
726e0ab1
PE
7581 (x_term_init): Don't assume length fits in int (sprintf is limited
7582 to int size).
bc18e09d 7583
ebfa62c0
PE
7584 Use ptrdiff_t for composition IDs.
7585 * character.c (lisp_string_width):
7586 * composite.c (composition_table_size, n_compositions)
7587 (get_composition_id, composition_gstring_from_id):
7588 * dispextern.h (struct glyph_string.cmp_id, struct composition_it.id):
7589 * xdisp.c (BUILD_COMPOSITE_GLYPH_STRING):
7590 * window.c (Frecenter):
7591 Use ptrdiff_t, not int, for composition IDs.
7592 * composite.c (get_composition_id): Check for integer overflow.
7593 * composite.h: Adjust prototypes to match the above changes.
7594
d3411f89
PE
7595 Use ptrdiff_t for hash table indexes.
7596 * category.c (hash_get_category_set):
7597 * ccl.c (ccl_driver):
7598 * charset.h (struct charset.hash_index, CHECK_CHARSET_GET_ID):
7599 * coding.c (coding_system_charset_list, detect_coding_system):
7600 * coding.h (struct coding_system.id):
7601 * composite.c (get_composition_id, gstring_lookup_cache):
7602 * fns.c (hash_lookup, hash_put, Fgethash, Fputhash):
7603 * image.c (xpm_get_color_table_h):
7604 * lisp.h (hash_lookup, hash_put):
7605 * minibuf.c (Ftest_completion):
7606 Use ptrdiff_t for hash table indexes, not int (which is too
7607 narrow, on 64-bit hosts) or EMACS_INT (which is too wide, on
7608 32-bit --with-wide-int hosts).
7609
e097a6fa
PE
7610 * charset.c (Fdefine_charset_internal): Check for integer overflow.
7611 Add a FIXME comment about memory leaks.
7612 (syms_of_charset): Don't assume xmalloc returns.
7613
5637687f
PE
7614 Don't assume that stated character widths fit in int.
7615 * character.c (Fchar_width, c_string_width, lisp_string_width):
7616 * character.h (CHAR_WIDTH):
7617 * indent.c (MULTIBYTE_BYTES_WIDTH):
7618 Use sanitize_char_width to avoid undefined and/or bad behavior
7619 with outlandish widths.
a66cfb1c 7620 * character.h (sanitize_tab_width): Rename from sanitize_width,
5637687f
PE
7621 now that we have two such functions. All uses changed.
7622 (sanitize_char_width): New inline function.
7623
a2271ba2
PE
7624 Don't assume that tab-width fits in int.
7625 * character.h (sanitize_width): New inline function.
7626 (SANE_TAB_WIDTH): New macro.
7627 (ASCII_CHAR_WIDTH): Use it.
7628 * indent.c (sane_tab_width): Remove. All uses replaced by
7629 SANE_TAB_WIDTH (current_buffer).
7630 * xdisp.c (init_iterator): Use SANE_TAB_WIDTH.
7631
18c52557
PE
7632 * fileio.c: Integer overflow issues with file modes.
7633 (Fset_file_modes, auto_save_1): Don't assume EMACS_INT fits in int.
7634
caeeedc1
PE
7635 * charset.c (read_hex): New arg OVERFLOW. All uses changed.
7636 Remove unreachable code.
7637 (read_hex, load_charset_map_from_file): Check for integer overflow.
7638
6df6ae42 7639 * xterm.c: Don't go over XClientMessageEvent limit.
50849c52
PE
7640 (scroll_bar_windows_size): Now ptrdiff_t, as we prefer signed.
7641 (x_send_scroll_bar_event): Likewise. Check that the size does not
7642 exceed limits imposed by XClientMessageEvent, as well as the usual
7643 ptrdiff_t and size_t limits.
7644
b13995db
PE
7645 * keyboard.c: Overflow, signedness and related fixes.
7646 (make_lispy_movement): Use same integer type in forward decl
7647 that is used in the definition.
7648 (read_key_sequence, keyremap_step):
7649 Change bufsize argument back to int, undoing my 2011-03-30 change.
7650 We prefer signed types, and int is wide enough here.
7651 (parse_tool_bar_item): Don't assume tool_bar_max_label_size is less
7652 than TYPE_MAXIMUM (EMACS_INT) / 2. Don't let the label size grow
7653 larger than STRING_BYTES_BOUND. Use ptrdiff_t for Emacs string
7654 length, not size_t. Use ptrdiff_t for index, not int.
7655 (keyremap_step, read_key_sequence): Redo bufsize check to avoid
7656 possibility of integer overflow.
7657
13464394
PE
7658 Overflow, signedness and related fixes for images.
7659
7660 * dispextern.h (struct it.stack[0].u.image.image_id)
7661 (struct_it.image_id, struct image.id, struct image_cache.size)
7662 (struct image_cache.used, struct image_cache.ref_count):
7663 * gtkutil.c (update_frame_tool_bar):
7664 * image.c (x_reference_bitmap, Fimage_size, Fimage_mask_p)
7665 (Fimage_metadata, free_image_cache, clear_image_cache, lookup_image)
7666 (cache_image, mark_image_cache, x_kill_gs_process, Flookup_image):
7667 * nsmenu.m (update_frame_tool_bar):
7668 * xdisp.c (calc_pixel_width_or_height):
7669 * xfns.c (image_cache_refcount):
7670 Image IDs are now ptrdiff_t, not int, to avoid arbitrary limits
7671 on typical 64-bit hosts.
7672
7673 * image.c (RANGED_INTEGERP, TYPE_RANGED_INTEGERP): New macros.
7674 (x_bitmap_pixmap, x_create_x_image_and_pixmap):
7675 Omit unnecessary casts to int.
7676 (parse_image_spec): Check that integers fall into 'int' range
7677 when the callers expect that.
7678 (image_ascent): Redo ascent calculation to avoid int overflow.
7679 (clear_image_cache): Avoid overflow when sqrt (INT_MAX) < nimages.
7680 (lookup_image): Remove unnecessary tests.
7681 (xbm_image_p): Locals are now of int, not EMACS_INT,
7682 since parse_image_check makes sure they fit into int.
7683 (png_load, gif_load, svg_load_image):
7684 Prefer int to unsigned where either will do.
7685 (tiff_handler): New function, combining the cores of the
a66cfb1c
SM
7686 old tiff_error_handler and tiff_warning_handler.
7687 This function is rewritten to use vsnprintf and thereby avoid
13464394
PE
7688 stack buffer overflows. It uses only the features of vsnprintf
7689 that are common to both POSIX and native Microsoft.
7690 (tiff_error_handler, tiff_warning_handler): Use it.
7691 (tiff_load, gif_load, imagemagick_load_image):
7692 Don't assume :index value fits in 'int'.
7693 (gif_load): Omit unnecessary cast to double, and avoid double-rounding.
7694 (imagemagick_load_image): Check that crop parameters fit into
7695 the integer types that MagickCropImage accepts. Don't assume
7696 Vimagemagick_render_type has a nonnegative value. Don't assume
7697 size_t fits in 'long'.
7698 (gs_load): Use printmax_t to print the widest integers possible.
7699 Check for integer overflow when computing image height and width.
7700
c11821d4
EZ
77012011-08-26 Eli Zaretskii <eliz@gnu.org>
7702
7703 * xdisp.c (redisplay_window): Don't force window start if point
7704 will be invisible in the resulting window. (Bug#9324)
7705
0c95fcf7
EZ
77062011-08-25 Eli Zaretskii <eliz@gnu.org>
7707
7708 * xdisp.c (compute_display_string_pos): Return 2 in DISP_PROP when
7709 the display spec is of the form `(space ...)'.
7710 (handle_display_spec): Return the value returned by
7711 handle_single_display_spec, not just 1 or zero.
7712 (handle_single_display_spec): If the display spec is of the form
7713 `(space ...)', and specifies display in the text area, return 2
7714 rather than 1.
fee65a97 7715 (try_cursor_movement): Check for the need to scroll more
a66cfb1c
SM
7716 accurately, and prefer exact match for point under bidi.
7717 Don't advance `row' beyond the last row of the window.
0c95fcf7
EZ
7718
7719 * dispextern.h (struct bidi_it): Rename the disp_prop_p member
7720 into disp_prop; all users changed.
7721
7722 * bidi.c (bidi_fetch_char): If compute_display_string_pos returns
7723 DISP_PROP = 2, substitute the u+2029 PARAGRAPH SEPARATOR character
7724 for the text covered by the display property.
7725
e4ed06f1
CY
77262011-08-25 Chong Yidong <cyd@stupidchicken.com>
7727
7728 * buffer.c (Fbury_buffer_internal): Rename from Funrecord_buffer.
7729 Change return value to nil.
7730 (Frecord_buffer): Delete unused function.
7731
f67cdd7f
EZ
77322011-08-24 Eli Zaretskii <eliz@gnu.org>
7733
5980d4c6
EZ
7734 * xdisp.c (Fcurrent_bidi_paragraph_direction): For unibyte
7735 buffers, return left-to-right.
8610fe8b
EZ
7736 (set_cursor_from_row): Consider candidate row a win if its glyph
7737 represents a newline and point is on that newline. Fixes cursor
7738 positioning on the newline at EOL of R2L text within L2R
7739 paragraph, and vice versa.
7740 (try_cursor_movement): Check continued rows, in addition to
7741 continuation rows. Fixes unwarranted scroll when point enters a
7742 continued line of R2L text within an L2R paragraph, or vice versa.
7743 (cursor_row_p): Consider the case of point being equal to
7744 MATRIX_ROW_END_CHARPOS. Prevents cursor being stuck when moving
7745 from the end of a short line to the beginning of a continued line
7746 of R2L text within L2R paragraph.
7747 (RECORD_MAX_MIN_POS): For max_pos, use IT_CHARPOS even for
7748 composed characters.
5980d4c6 7749
f67cdd7f
EZ
7750 * bidi.c (bidi_check_type): Use xassert.
7751 (bidi_cache_iterator_state): Update the disp_pos and disp_prop_p
7752 members.
7753
bca633fb
EZ
77542011-08-23 Eli Zaretskii <eliz@gnu.org>
7755
7756 * bidi.c (bidi_get_type): Abort if we get zero as the bidi type of
7757 a character.
7758
4a5885a7
CY
77592011-08-23 Chong Yidong <cyd@stupidchicken.com>
7760
7761 * nsfont.m (ns_otf_to_script): Fix typo.
7762
0902a04e
KH
77632011-08-22 Kenichi Handa <handa@m17n.org>
7764
7765 * chartab.c (Fset_char_table_extra_slot): Do not inhibit setting a
7766 extra slot even if the purpose is char-code-property-table.
7767
1a2e6670
EZ
77682011-08-23 Eli Zaretskii <eliz@gnu.org>
7769
8ddde651
EZ
7770 * xdisp.c (redisplay_window): When computing centering_position,
7771 account for the height of the header line. (Bug#8874)
7772
425cc014
EZ
7773 * dispnew.c (buffer_posn_from_coords): Use buf_charpos_to_bytepos
7774 instead of CHAR_TO_BYTE. Fixes a crash when a completion
7775 candidate is selected by the mouse, and that candidate has a
7776 composed character under the mouse.
7777
1a2e6670
EZ
7778 * xdisp.c (x_produce_glyphs): Set it->nglyphs to 1. Fixes pixel
7779 coordinates reported by pos-visible-in-window-p for a composed
7780 character in column zero.
7781
8b76d6f8
SM
77822011-08-23 Stefan Monnier <monnier@iro.umontreal.ca>
7783
7784 * cmds.c (Fself_insert_command): Mention post-self-insert-hook.
7785
dac347dd
EZ
77862011-08-22 Eli Zaretskii <eliz@gnu.org>
7787
7788 * xdisp.c (BUFFER_POS_REACHED_P): If this is a composition,
7789 consider it a hit if to_charpos is anywhere in the range of the
7790 composed buffer positions.
7791
e013fb34
CY
77922011-08-22 Chong Yidong <cyd@stupidchicken.com>
7793
7794 * image.c (gif_load): Don't assume that each subimage has the same
7795 dimensions as the base image. Handle disposal method that is
7796 "undefined" by the gif spec (Bug#9335).
7797
bd1ba3e8
CY
77982011-08-20 Chong Yidong <cyd@stupidchicken.com>
7799
7800 * eval.c (Fsignal): Handle `debug' symbol in error handler (Bug#9329).
024a2d76 7801 (Fcondition_case): Document `debug' symbol in error handler.
bd1ba3e8 7802
54a1215b
EZ
78032011-08-19 Eli Zaretskii <eliz@gnu.org>
7804
823564e5
EZ
7805 * xfaces.c (face_at_buffer_position): Avoid repeated evaluation of
7806 face ID by FACE_FROM_ID, and avoid a crash when mouse is moved
7807 from an Org mode buffer to a Speedbar frame.
7808
54a1215b
EZ
7809 * xdisp.c (RECORD_MAX_MIN_POS): If the display element comes from
7810 a composition, take its buffer position from IT->cmp_it.charpos.
7811 Fixes cursor positioning at the beginning of a line that begins
7812 with a composed character.
7813
9778ebcc
EZ
78142011-08-18 Eli Zaretskii <eliz@gnu.org>
7815
0be6ee06
EZ
7816 * bidi.c (bidi_get_type): If bidi_type_table reports zero as the
7817 character bidirectional type, use STRONG_L instead. Fixes crashes
7818 in a buffer produced by `describe-categories'.
7819
9778ebcc
EZ
7820 * dispextern.h (struct bidi_it): Move disp_pos and disp_prop_p
7821 members before the level stack, so they would be saved and
7822 restored when copying iterator state. Fixes incorrect reordering
7823 around TABs covered by display properties.
7824
156bffbe
AS
78252011-08-18 Andreas Schwab <schwab@linux-m68k.org>
7826
6b02f655 7827 * process.c (Fnetwork_interface_list): Correctly determine buffer size.
156bffbe 7828
72ad093b
CY
78292011-08-17 Chong Yidong <cyd@stupidchicken.com>
7830
7831 * eval.c (internal_condition_case, internal_condition_case_1)
8b76d6f8
SM
7832 (internal_condition_case_2, internal_condition_case_n):
7833 Remove unnecessary aborts (Bug#9081).
72ad093b 7834
35774242
EZ
78352011-08-17 Eli Zaretskii <eliz@gnu.org>
7836
7837 * lread.c (Fload) [DOS_NT]: If `openp' returns -2, but the file
7838 has no `load' handler, try opening the file locally. (Bug#9311)
7839
db76dd85
KB
78402011-08-16 Ken Brown <kbrown@cornell.edu>
7841
7842 * gmalloc.c: Expand comment.
7843
b215eee5
EZ
78442011-08-16 Eli Zaretskii <eliz@gnu.org>
7845
7846 * xdisp.c (set_cursor_from_row): Don't accept a previous candidate
7847 if it fails the cursor_row_p test. Fixes cursor positioning at ZV.
7848
a4579d33
KB
78492011-08-16 Ken Brown <kbrown@cornell.edu>
7850
7851 Fix memory allocation problems in Cygwin build (Bug#9273).
7852
7853 * unexcw.c ( __malloc_initialized): Declare external variable.
7854 (fixup_executable): Force the dumped emacs to reinitialize malloc.
7855
8b76d6f8
SM
7856 * gmalloc.c [CYGWIN] (bss_sbrk_heapbase, bss_sbrk_heapinfo):
7857 New variables.
a4579d33
KB
7858 (malloc_initialize_1) [CYGWIN]: Prepare for reinitializing the
7859 dumped emacs.
7860 (_free_internal_nolock) [CYGWIN]: Ignore requests to free storage
7861 in the static heap.
7862 [CYGWIN] (special_realloc): New function.
7863 (_realloc_internal_nolock) [CYGWIN]: Use the new function on
7864 requests to realloc storage in the static heap.
7865
3ebec551
PE
78662011-08-15 Paul Eggert <eggert@cs.ucla.edu>
7867
7868 * bidi.c (bidi_initialize): Remove unused local.
7869
9fd8be00
EZ
78702011-08-15 Eli Zaretskii <eliz@gnu.org>
7871
6b02f655
SM
7872 * bidimirror.h:
7873 * biditype.h: Remove file.
7874 * makefile.w32-in ($(BLD)/bidi.$(O)):
7875 * deps.mk (bidi.o): Remove biditype.h and bidimirror.h.
474a8465
EZ
7876
7877 * dispextern.h: Fix a typo in the comment to bidi_type_t.
7878
7879 * chartab.c: Improve commentary for the uniprop_table API.
7880
32413314
EZ
7881 * bidi.c (bidi_paragraph_init): Support zero value of
7882 bidi_ignore_explicit_marks_for_paragraph_level.
474a8465
EZ
7883 (bidi_initialize): Use uniprop_table instead of including
7884 biditype.h and bidimirror.h.
32413314 7885
9fd8be00
EZ
7886 * xdisp.c (move_it_in_display_line_to): Don't reset pixel
7887 coordinates of the iterator when restoring from ppos_it.
7888 (Bug#9296)
7889
5cf2b69b
KH
78902011-08-14 Kenichi Handa <handa@m17n.org>
7891
7892 * process.c (create_process): Call setup_process_coding_systems
72ad093b 7893 after the pid of the process is set to -1 (Bug#8162).
5cf2b69b 7894
daf17d00
EZ
78952011-08-14 Eli Zaretskii <eliz@gnu.org>
7896
7897 * xdisp.c (move_it_in_display_line_to): Don't invoke
7898 IT_RESET_X_ASCENT_DESCENT when iterator position was restored from
7899 ppos_it. Fixes vertical cursor motion when line beginning is
7900 covered by an image. (Bug#9296)
7901
08e3161a
JD
79022011-08-14 Jan Djärv <jan.h.d@swipnet.se>
7903
7904 * nsterm.h (ns_run_ascript): Declare.
7905 (NSAPP_DATA2_RUNASSCRIPT): Define.
7906
7907 * nsfns.m (as_script, as_result, as_status): New static variables.
7908 (ns_run_ascript): New function.
5e617bc2 7909 (Fns_do_applescript): Set variables as_*. Make an NSApplicationDefined
08e3161a
JD
7910 event with data2 set to NSAPP_DATA2_RUNASSCRIPT, post it and then start
7911 the event loop. Get status from as_status (Bug#7276).
7912
7913 * nsterm.m (sendEvent): If event is NSApplicationDefined and
7914 data2 is NSAPP_DATA2_RUNASSCRIPT, call ns_run_ascript and then exit
7915 the event loop (Bug#7276).
7916
a3720aa2
AS
79172011-08-14 Andreas Schwab <schwab@linux-m68k.org>
7918
7919 * gnutls.c (QCgnutls_bootprop_priority)
7920 (QCgnutls_bootprop_trustfiles, QCgnutls_bootprop_keylist)
7921 (QCgnutls_bootprop_crlfiles, QCgnutls_bootprop_callbacks)
7922 (QCgnutls_bootprop_loglevel, QCgnutls_bootprop_hostname)
7923 (QCgnutls_bootprop_min_prime_bits, QCgnutls_bootprop_verify_flags)
7924 (QCgnutls_bootprop_verify_hostname_error)
7925 (QCgnutls_bootprop_callbacks_verify): Rename from
7926 Qgnutls_bootprop_..., all uses changed.
7927
7928 * xfaces.c (QCignore_defface): Rename from Qignore_defface, all
7929 uses changed.
7930
0a0d27fb
PE
79312011-08-14 Paul Eggert <eggert@cs.ucla.edu>
7932
19d5c50c
PE
7933 * xfaces.c (Qframe_set_background_mode): Now static.
7934 * dispextern.h (Qframe_set_background_mode): Remove decl.
7935
0a0d27fb
PE
7936 * process.c (Fnetwork_interface_info): Declare local only if needed.
7937
377538cb
JD
79382011-08-13 Jan Djärv <jan.h.d@swipnet.se>
7939
7940 * process.c: Include ifaddrs.h and net/if_dl.h if available (Bug#8477).
7941 (Fnetwork_interface_list): Allocate in increments of bytes instead
7942 of sizeof (struct ifreq). Iterate over ifconf.ifc_req by counting
7943 bytes (Bug#8477). Count bytes correctly when ifr_addr is a struct
7944 sockaddr.
7945 (struct ifflag_def): notrailers is smart on OSX.
7946 (Fnetwork_interface_info): Handle case when ifr_flags is negative.
7947 Get hardware address with getifaddrs if available.
7948
08fff70c
EZ
79492011-08-12 Eli Zaretskii <eliz@gnu.org>
7950
7951 * xdisp.c (iterate_out_of_display_property): xassert that
7952 IT->position is set to within IT->object's boundaries. Break from
7953 the loop as soon as EOB is reached; avoids infloops in redisplay
8b76d6f8
SM
7954 when IT->position is set up wrongly due to some bug.
7955 Set IT->current to match the bidi iterator unconditionally.
08fff70c
EZ
7956 (push_display_prop): Allow GET_FROM_STRING as IT->method on
7957 entry. Force push_it to save on the stack the current
7958 buffer/string position, to be restored by pop_it. Fix flags in
7959 the iterator structure wrt the object coming from a display
7960 property, as `line-prefix' and `wrap-prefix' are not ``replacing''
7961 properties. (Bug#9284)
7962
7be1c708 79632011-08-09 Andreas Schwab <schwab@linux-m68k.org>
aac0c6e3 7964
7be1c708
CY
7965 * fontset.c (fontset_get_font_group): Add proper type checks.
7966 (Bug#9172)
aac0c6e3 7967
7be1c708 79682011-08-09 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
aac0c6e3 7969
7be1c708
CY
7970 * unexmacosx.c (print_load_command_name): Add cases LC_FUNCTION_STARTS
7971 and LC_VERSION_MIN_MACOSX.
7972 (copy_linkedit_data) [LC_FUNCTION_STARTS]: New function.
7973 (dump_it) [LC_FUNCTION_STARTS]: Use it.
aac0c6e3 7974
97bb72a6
EZ
79752011-08-08 Eli Zaretskii <eliz@gnu.org>
7976
7977 * xdisp.c (forward_to_next_line_start): Allow to use the
8b76d6f8
SM
7978 no-display-properties-and-no-overlays under bidi display.
7979 Set disp_pos in the bidi iterator to avoid searches for display
757664a4 7980 properties and overlays.
97bb72a6 7981
d5617611
CY
79822011-08-08 Chong Yidong <cyd@stupidchicken.com>
7983
37e11a63
CY
7984 * editfns.c (Fset_time_zone_rule): Document relationship with the
7985 setenv function.
7986
d5617611
CY
7987 * ftfont.c (ftfont_pattern_entity): Copy the extras argument to
7988 the font entity extracted from the cache (Bug#8109).
7989
58872834
CY
79902011-08-07 Chong Yidong <cyd@stupidchicken.com>
7991
7992 * composite.c (autocmp_chars): Don't reset point. That is done by
7993 restore_point_unwind (Bug#5984).
7994
75bfc667
JL
79952011-08-07 Juri Linkov <juri@jurta.org>
7996
7997 * editfns.c (Fformat_time_string): Doc fix, add tag `usage:'
7998 to show the arg `TIME' instead of `TIMEVAL'.
7999
d1410150
EZ
80002011-08-06 Eli Zaretskii <eliz@gnu.org>
8001
8002 * xdisp.c (set_cursor_from_row): Fix cursor positioning when a
8003 display property strides EOL and includes a newline, as in
8004 longlines-mode. (Bug#9254)
75b771e4
EZ
8005 (move_it_in_display_line_to): Fix vertical-motion in a buffer with
8006 word-wrap under bidirectional display. (Bug#9224)
d1410150
EZ
8007
8008 * bidi.c (bidi_unshelve_cache): Don't reset the cache if JUST_FREE
8009 is non-zero, even if the data buffer is NULL. Fixes a crash in
8010 vertical-motion with longlines-mode. (Bug#9254)
8011
35928349
EZ
80122011-08-05 Eli Zaretskii <eliz@gnu.org>
8013
ec7cc85b
EZ
8014 * bidi.c <bidi_cache_total_alloc>: Now static.
8015 (bidi_initialize): Initialize bidi_cache_total_alloc.
8016
8b76d6f8 8017 * xdisp.c (display_line): Release buffer allocated for shelved bidi
35928349
EZ
8018 cache. (Bug#9221)
8019
8020 * bidi.c (bidi_shelve_cache, bidi_unshelve_cache): Track total
8021 amount allocated this far in `bidi_cache_total_alloc'.
8022 (bidi_unshelve_cache): Accept an additional argument JUST_FREE; if
8023 non-zero, only free the data buffer without restoring the cache
8024 contents. All callers changed.
8025
8026 * dispextern.h (bidi_unshelve_cache): Update prototype.
8027
8028 * xdisp.c (SAVE_IT, pos_visible_p, move_it_in_display_line_to)
8029 (move_it_in_display_line, move_it_to)
8030 (move_it_vertically_backward, move_it_by_lines): Replace the call
8031 to xfree to an equivalent call to bidi_unshelve_cache.
8032 (move_it_in_display_line_to): Fix logic of returning
412b6358 8033 MOVE_POS_MATCH_OR_ZV in the bidi case. (Bug#9224)
35928349 8034
e2e2423b
EZ
80352011-08-05 Eli Zaretskii <eliz@gnu.org>
8036
8037 * xdisp.c (set_cursor_from_row): Prefer the candidate glyph that
8038 came from a string character with a `cursor' property. (Bug#9229)
8039
ae9e757a
JD
80402011-08-04 Jan Djärv <jan.h.d@swipnet.se>
8041
8042 * Makefile.in (LIB_PTHREAD): New variable.
8043 (LIBES): Add LIB_PTHREAD (Bug#9216).
8044
8045 * alloc.c, emacs.c, gmalloc.c, gtkutil.c, keyboard.c, syssignal.h:
8046 Rename HAVE_GTK_AND_PTHREAD to HAVE_PTHREAD (Bug#9216).
8047
213bd7f2
AS
80482011-08-04 Andreas Schwab <schwab@linux-m68k.org>
8049
6b02f655 8050 * regex.c (re_iswctype): Remove some redundant boolean conversions.
213bd7f2 8051
99aaf75f
JD
80522011-08-04 Jan Djärv <jan.h.d@swipnet.se>
8053
8054 * xterm.c (x_find_topmost_parent): New function.
8055 (x_set_frame_alpha): Find topmost parent window with
8056 x_find_topmost_parent and set the property there also (bug#9181).
8057 (handle_one_xevent): Call x_set_frame_alpha on ReparentNotify.
8058
c74e9d86
PE
80592011-08-04 Paul Eggert <eggert@cs.ucla.edu>
8060
8061 * callproc.c (Fcall_process): Avoid vfork clobbering
8062 the local vars buffer, coding_systems, current_dir.
8063
640c8776
SM
80642011-08-03 Stefan Monnier <monnier@iro.umontreal.ca>
8065
8066 * keymap.c (Fmake_composed_keymap): Move to subr.el.
8067
f26d0e4c
PE
80682011-08-03 Paul Eggert <eggert@cs.ucla.edu>
8069
8a10d76c
PE
8070 * fontset.c (dump_fontset) [FONTSET_DEBUG]: Declare EXTERNALLY_VISIBLE
8071 so that it is not optimized away.
8072
f26d0e4c
PE
8073 * xdisp.c (compute_display_string_pos): Remove unused local.
8074
55439c61
EZ
80752011-08-02 Eli Zaretskii <eliz@gnu.org>
8076
8077 Fix slow cursor motion and scrolling in large buffers with
8078 selective display, like Org Mode buffers. (Bug#9218)
8079
8080 * dispextern.h (struct bidi_it): New member disp_prop_p.
8081
8082 * xdisp.c: Remove one-slot cache of display string positions.
8083 (compute_display_string_pos): Accept an additional argument
5e617bc2 8084 DISP_PROP_P; callers changed. Scan at most 5K characters forward
55439c61
EZ
8085 for a display string or property. If found, set DISP_PROP_P
8086 non-zero.
8087
8088 * bidi.c (bidi_fetch_char): Accept an additional argument
640c8776
SM
8089 DISP_PROP_P, and pass it to compute_display_string_pos.
8090 Only handle text covered by a display string if DISP_PROP_P is returned
55439c61
EZ
8091 non-zero. All callers of bidi_fetch_char changed.
8092
fb33fa43
SM
80932011-08-02 Stefan Monnier <monnier@iro.umontreal.ca>
8094
8095 * keymap.c (Fdefine_key): Fix Lisp_Object/int mixup; apply some CSE.
8096
b099e063
DM
80972010-12-03 Don March <don@ohspite.net>
8098
8099 * keymap.c (Fdefine_key): Fix non-prefix key error message when
8100 last character M-[char] is translated to ESC [char] (bug#7541).
8101
5cc7f7af
KH
81022011-08-02 Kenichi Handa <handa@m17n.org>
8103
d0fffa3f 8104 * lisp.h (uniprop_table): Extern it.
5cc7f7af
KH
8105
8106 * chartab.c (uniprop_table): Make it non-static.
8107
525d5e6e
EZ
81082011-08-01 Eli Zaretskii <eliz@gnu.org>
8109
8110 * xdisp.c (forward_to_next_line_start): Accept additional argument
8111 BIDI_IT_PREV, and store into it the state of the bidi iterator had
8112 on the newline.
8113 (reseat_at_next_visible_line_start): Use the bidi iterator state
8114 returned by forward_to_next_line_start to restore the state of
8115 it->bidi_it after backing up to previous newline. (Bug#9212)
8116
31011111
AS
81172011-07-30 Andreas Schwab <schwab@linux-m68k.org>
8118
8119 * regex.c (re_comp): Protoize.
8120 (re_exec): Fix return type.
8121 (regexec): Fix type of `ret'. (Bug#9203)
8122
476371c4
PE
81232011-07-28 Paul Eggert <eggert@cs.ucla.edu>
8124
e5d76069
PE
8125 * image.c (check_image_size): Use 1024x1024 if unknown frame (Bug#9189).
8126 This is needed if max-image-size is a floating-point number.
8127
9a79b20c
AS
81282011-07-28 Andreas Schwab <schwab@linux-m68k.org>
8129
8130 * print.c (print_object): Print empty symbol as ##.
8131
8132 * lread.c (read1): Read ## as empty symbol.
8133
d8c2fa78
AA
81342011-07-28 Alp Aker <alp.tekin.aker@gmail.com>
8135
8136 * nsfns.m (x_set_foreground_color): Set f->foreground_pixel when
8137 setting frame foreground color (Bug#9175).
8138 (x_set_background_color): Likewise.
8139
ffe57a7a
AA
8140 * nsmenu.m (-setText): Size tooltip dimensions precisely to
8141 contents (Bug#9176).
8142 (EmacsTooltip -init): Remove bezels and add shadows to
8143 tooltip windows.
8144
bf3492a5
AA
8145 * nsterm.m (ns_dumpglyphs_stretch): Avoid overwriting left fringe
8146 or scroll bar (Bug#8470).
8147
d55e9c53
AA
8148 * nsfont.m (nsfont_open): Remove assignment to voffset and
8149 unnecessary vars hshink, expand, hd, full_height, min_height.
8150 (nsfont_draw): Use s->ybase as baseline for glyph drawing (Bug#8913).
8151
8152 * nsterm.h (nsfont_info): Remove voffset field.
8153
d8c2fa78 81542011-07-28 Alp Aker <alp.tekin.aker@gmail.com>
4843aac3
AA
8155
8156 Implement strike-through and overline on NextStep (Bug#8863).
8157
8158 * nsfont.m (nsfont_open): Use underline position provided by font,
8159 instead of hard-coded value of 2.
8160 (nsfont_draw): Call ns_draw_text_decoration instead.
8161
8162 * nsterm.h: Add declaration for ns_draw_text_decoration.
8163
8164 * nsterm.m (ns_draw_text_decoration): New function for drawing
8165 underline, overline, and strike-through.
8166 (ns_dumpglyphs_image, ns_dumpglyphs_stretch): Add call to
8167 ns_draw_text_decoration. Change treatment of cursor drawing to
8d5ed899 8168 accommodate underlining, etc.
4843aac3 8169
4cc60b9b
EZ
81702011-07-28 Eli Zaretskii <eliz@gnu.org>
8171
bc7ece87
EZ
8172 * buffer.c (init_buffer_once): Set bidi-display-reordering to t by
8173 default.
4cc60b9b 8174
476371c4
PE
81752011-07-28 Paul Eggert <eggert@cs.ucla.edu>
8176
66606eea
PE
8177 * alloc.c (memory_full) [!SYNC_INPUT]: Fix signal-related race.
8178 Without this fix, if a signal arrives just after memory fills up,
8179 'malloc' might be invoked reentrantly.
8180
476371c4
PE
8181 * image.c (x_check_image_size) [!HAVE_X_WINDOWS]: Return 1.
8182 In other words, assume that every image size is allowed, on non-X
8183 hosts. This assumption is probably wrong, but it lets Emacs compile.
8184
f3fcc40d
AS
81852011-07-28 Andreas Schwab <schwab@linux-m68k.org>
8186
8187 * regex.c (re_iswctype): Convert return values to boolean.
8188
350c992f
EZ
81892011-07-28 Eli Zaretskii <eliz@fencepost.gnu.org>
8190
8191 * xdisp.c (compute_display_string_pos): Don't use cached display
8192 string position if the buffer had its restriction changed.
8193 (Bug#9184)
8194
5266b4bb
PE
81952011-07-28 Paul Eggert <eggert@cs.ucla.edu>
8196
8197 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork clobbering.
8198
2573a837 81992011-07-28 Paul Eggert <eggert@cs.ucla.edu>
ca4aa935 8200
41f55ccd 8201 Integer signedness and overflow and related fixes. (Bug#9079)
cf950e6b 8202
39e378da
PE
8203 * bidi.c: Integer size and overflow fixes.
8204 (bidi_cache_size, bidi_cache_idx, bidi_cache_last_idx)
8205 (bidi_cache_start, bidi_cache_fetch_state, bidi_cache_search)
8206 (bidi_cache_find_level_change, bidi_cache_ensure_space)
8207 (bidi_cache_iterator_state, bidi_cache_find, bidi_cache_start_stack)
8208 (bidi_find_other_level_edge):
8209 Use ptrdiff_t instead of EMACS_INT where either will do.
8210 This works better on 32-bit hosts configured --with-wide-int.
8211 (bidi_cache_ensure_space): Check for size-calculation overflow.
8212 Use % rather than repeated addition, for better worst-case speed.
8213 Don't set bidi_cache_size until after xrealloc returns, because it
8214 might not return.
8215 (bidi_dump_cached_states): Use ptrdiff_t, not int, to avoid overflow.
f0eb61e9
PE
8216 (bidi_cache_ensure_space): Also check that the bidi cache size
8217 does not exceed that of the largest Lisp string or buffer. See Eli
8218 Zaretskii in <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=9079#29>.
39e378da 8219
5e927815
PE
8220 * alloc.c (__malloc_size_t): Remove.
8221 All uses replaced by size_t. See Andreas Schwab's note
8222 <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=9079#8>.
8223
ca4aa935
PE
8224 * image.c: Improve checking for integer overflow.
8225 (check_image_size): Assume that f is nonnull, since
8226 it is always nonnull in practice. This is one less thing to
8227 worry about when checking for integer overflow later.
8228 (x_check_image_size): New function, which checks for integer
8229 overflow issues inside X.
8230 (x_create_x_image_and_pixmap, xbm_read_bitmap_data): Use it.
8231 This removes the need for a memory_full check.
8232 (xbm_image_p): Rewrite to avoid integer multiplication overflow.
8233 (Create_Pixmap_From_Bitmap_Data, xbm_load): Use x_check_image_size.
8234 (xbm_read_bitmap_data): Change locals back to 'int', since
8235 their values must fit in 'int'.
8236 (xpm_load_image, png_load, tiff_load):
8237 Invoke x_create_x_image_and_pixmap earlier,
8238 to avoid much needless work if the image is too large.
8239 (tiff_load): Treat overly large images as if
8240 x_create_x_image_and_pixmap failed, not as malloc failures.
8241 (gs_load): Use x_check_image_size.
8242
5f8f9cc2
PE
8243 * gtkutil.c: Omit integer casts.
8244 (xg_get_pixbuf_from_pixmap): Remove unnecessary cast.
8245 (xg_set_toolkit_scroll_bar_thumb): Rewrite to avoid need for cast.
8246
5adf60bc
PE
8247 * image.c (png_load): Don't assume height * row_bytes fits in 'int'.
8248
c8907a93
PE
8249 * xfaces.c (Fbitmap_spec_p): Fix integer overflow bug.
8250 Without this fix, (bitmap-spec-p '(34359738368 1 "x"))
8251 would wrongly return t on a 64-bit host.
8252
e3c25c68
PE
8253 * dispnew.c (init_display): Use *_RANGE_OVERFLOW macros.
8254 The plain *_OVERFLOW macros run afoul of GCC bug 49705
8255 <http://gcc.gnu.org/bugzilla/show_bug.cgi?id=49705>
8256 and therefore cause GCC to emit a bogus diagnostic in some cases.
8257
3f791afe
PE
8258 * image.c: Integer signedness and overflow and related fixes.
8259 This is not an exhaustive set of fixes, but it's time to
8260 record what I've got.
8261 (lookup_pixel_color, check_image_size): Remove redundant decls.
8262 (check_image_size): Don't assume that arbitrary EMACS_INT values
8263 fit in 'int', or that arbitrary 'double' values fit in 'int'.
8264 (x_alloc_image_color, x_create_x_image_and_pixmap, png_load)
8265 (tiff_load, imagemagick_load_image):
8266 Check for overflow in size calculations.
8267 (x_create_x_image_and_pixmap): Remove unnecessary test for
8268 xmalloc returning NULL; that can't happen.
8269 (xbm_read_bitmap_data): Don't assume sizes fit into 'int'.
8270 (xpm_color_bucket): Use better integer hashing function.
8271 (xpm_cache_color): Don't possibly over-allocate memory.
8272 (struct png_memory_storage, tiff_memory_source, tiff_seek_in_memory)
8273 (gif_memory_source):
8274 Use ptrdiff_t, not int or size_t, to record sizes.
8275 (png_load): Don't assume values greater than 2**31 fit in 'int'.
8276 (our_stdio_fill_input_buffer): Prefer ptrdiff_t to size_t when
8277 either works, as we prefer signed integers.
8278 (tiff_read_from_memory, tiff_write_from_memory):
8279 Return tsize_t, not size_t, since that's what the TIFF API wants.
8280 (tiff_read_from_memory): Don't fail simply because the read would
8281 go past EOF; instead, return a short read.
8282 (tiff_load): Omit no-longer-needed casts.
8283 (Fimagemagick_types): Don't assume size fits into 'int'.
8284
3cc5a532
PE
8285 Improve hashing quality when configured --with-wide-int.
8286 * fns.c (hash_string): New function, taken from sxhash_string.
8287 Do not discard information about ASCII character case; this
8288 discarding is no longer needed.
8289 (sxhash-string): Use it. Change sig to match it. Caller changed.
8290 * lisp.h: Declare it.
8291 * lread.c (hash_string): Remove, since we now use fns.c's version.
8292 The fns.c version returns a wider integer if --with-wide-int is
8293 specified, so this should help the quality of the hashing a bit.
8294
b312a492
PE
8295 * emacs.c: Integer overflow minor fix.
8296 (heap_bss_diff): Now uprintmax_t, not unsigned long. All used changed.
8297 Define only if GNU_LINUX.
8298 (main, Fdump_emacs): Set and use heap_bss_diff only if GNU_LINUX.
8299
dfd153ae
PE
8300 * dispnew.c: Integer signedness and overflow fixes.
8301 Remove unnecessary forward decls, that were a maintenance hassle.
8302 (history_tick): Now uprintmax_t, so it's more likely to avoid overflow.
8303 All uses changed.
8304 (adjust_glyph_matrix, realloc_glyph_pool, adjust_frame_message_buffer)
8305 (scrolling_window): Use ptrdiff_t, not int, for byte count.
8306 (prepare_desired_row, line_draw_cost):
8307 Use int, not unsigned, where either works.
8308 (save_current_matrix, restore_current_matrix):
8309 Use ptrdiff_t, not size_t, where either works.
8310 (init_display): Check for overflow more accurately, and without
8311 relying on undefined behavior.
8312
a81d11a3
PE
8313 * editfns.c (pWIDE, pWIDElen, signed_wide, unsigned_wide):
8314 Remove, replacing with the new symbols in lisp.h. All uses changed.
8315 * fileio.c (make_temp_name):
8316 * filelock.c (lock_file_1, lock_file):
8317 * xdisp.c (message_dolog):
8318 Don't assume PRIdMAX etc. works; this isn't portable to pre-C99 hosts.
8319 Use pMd etc. instead.
8320 * lisp.h (printmax_t, uprintmax_t, pMd, pMu): New types and macros,
8321 replacing the pWIDE etc. symbols removed from editfns.c.
8322
3300e6fd
PE
8323 * keyboard.h (num_input_events): Now uintmax_t.
8324 This is (very slightly) less likely to mess up due to wraparound.
8325 All uses changed.
8326
fd05c7e9
PE
8327 * buffer.c: Integer signedness fixes.
8328 (alloc_buffer_text, enlarge_buffer_text):
8329 Use ptrdiff_t rather than size_t when either will do, as we prefer
8330 signed integers.
8331
903fe15d
PE
8332 * alloc.c: Integer signedness and overflow fixes.
8333 Do not impose an arbitrary 32-bit limit on malloc sizes when debugging.
8334 (__malloc_size_t): Default to size_t, not to int.
8335 (pure_size, pure_bytes_used_before_overflow, stack_copy_size)
8336 (Fgarbage_collect, mark_object_loop_halt, mark_object):
8337 Prefer ptrdiff_t to size_t when either would do, as we prefer
8338 signed integers.
8339 (XMALLOC_OVERRUN_CHECK_OVERHEAD): New macro.
8340 (xmalloc_overrun_check_header, xmalloc_overrun_check_trailer):
8341 Now const. Initialize with values that are in range even if char
8342 is signed.
8343 (XMALLOC_PUT_SIZE, XMALLOC_GET_SIZE): Remove, replacing with ...
8344 (xmalloc_put_size, xmalloc_get_size): New functions. All uses changed.
8345 These functions do the right thing with sizes > 2**32.
8346 (check_depth): Now ptrdiff_t, not int.
8347 (overrun_check_malloc, overrun_check_realloc, overrun_check_free):
8348 Adjust to new way of storing sizes. Check for size overflow bugs
8349 in rest of code.
8350 (STRING_BYTES_MAX): Adjust to new overheads. The old code was
8351 slightly wrong anyway, as it missed one instance of
8352 XMALLOC_OVERRUN_CHECK_OVERHEAD.
8353 (refill_memory_reserve): Omit needless cast to size_t.
8354 (mark_object_loop_halt): Mark as externally visible.
8355
ac82cc6a
PE
8356 * xselect.c: Integer signedness and overflow fixes.
8357 (Fx_register_dnd_atom, x_handle_dnd_message):
8358 Use ptrdiff_t, not size_t, since we prefer signed.
8359 (Fx_register_dnd_atom): Check for ptrdiff_t (and size_t) overflow.
8360 * xterm.h (struct x_display_info): Use ptrdiff_t, not size_t, for
8361 x_dnd_atoms_size and x_dnd_atoms_length.
8362
c2d1e36d
PE
8363 * doprnt.c: Prefer signed to unsigned when either works.
8364 * eval.c (verror):
8365 * doprnt.c (doprnt):
8366 * lisp.h (doprnt):
8367 * xdisp.c (vmessage):
8368 Use ptrdiff_t, not size_t, when using or implementing doprnt,
8369 since the sizes cannot exceed ptrdiff_t bounds anyway, and we
8370 prefer signed arithmetic to avoid comparison confusion.
8371 * doprnt.c (doprnt): Avoid a "+ 1" that can't overflow,
8372 but is a bit tricky.
8373
0e926e56
PE
8374 Assume freestanding C89 headers, string.h, stdlib.h.
8375 * data.c, doprnt.c, floatfns.c, print.c:
8376 Include float.h unconditionally.
8377 * gmalloc.c: Assume C89-at-least behavior for preprocessor,
8378 limits.h, stddef.h, string.h. Use memset instead of 'flood'.
8379 * regex.c: Likewise for stddef.h, string.h.
8380 (ISASCII): Remove; can assume it returns 1 now. All uses removed.
8381 * s/aix4-2.h (HAVE_STRING_H): Remove obsolete undef.
8382 * s/ms-w32.h (HAVE_LIMITS_H, HAVE_STRING_H, HAVE_STDLIB_H)
8383 (STDC_HEADERS): Remove obsolete defines.
8384 * sysdep.c: Include limits.h unconditionally.
8385
9cfdb3ec
PE
8386 Assume support for memcmp, memcpy, memmove, memset.
8387 * lisp.h, sysdep.c (memcmp, memcpy, memmove, memset):
8388 * regex.c (memcmp, memcpy):
8389 Remove; we assume C89 now.
8390
8391 * gmalloc.c (memcpy, memset, memmove): Remove; we assume C89 now.
8392 (__malloc_safe_bcopy): Remove; no longer needed.
8393
cf950e6b 8394 * lisp.h (struct vectorlike_header, struct Lisp_Subr): Signed sizes.
6089c567
PE
8395 Use EMACS_INT, not EMACS_UINT, for sizes. The code works equally
8396 well either way, and we prefer signed to unsigned.
8397
dbf38e02
LMI
83982011-07-27 Lars Magne Ingebrigtsen <larsi@gnus.org>
8399
8400 * gnutls.c (emacs_gnutls_read): Don't message anything if the peer
8401 closes the connection while we're reading (bug#9182).
8402
d6f0886c 84032011-07-25 Jan Djärv <jan.h.d@swipnet.se>
24e0f6b1 8404
d6f0886c
JD
8405 * nsmenu.m (ns_popup_dialog): Add an "ok" button if no buttons
8406 are specified (Bug#9168).
24e0f6b1 8407
2eb1f9e6
PE
84082011-07-25 Paul Eggert <eggert@cs.ucla.edu>
8409
8410 * bidi.c (bidi_dump_cached_states): Fix printf format mismatch.
8411 Found by GCC static checking and --with-wide-int on a 32-bit host.
8412
22381272 84132011-07-25 Eli Zaretskii <eliz@gnu.org>
7daee910
EZ
8414
8415 * xdisp.c (compute_display_string_pos): Fix logic of caching
8416 previous display string position. Initialize cached_prev_pos to
8417 -1. Fixes slow-down at the beginning of a buffer.
8418
f25e39b4
EZ
84192011-07-24 Eli Zaretskii <eliz@gnu.org>
8420
8421 * xfaces.c (check_lface_attrs) [HAVE_WINDOW_SYSTEM]: Allow `nil'
8422 for attrs[LFACE_FONTSET_INDEX].
8423
04c4b52e
PE
84242011-07-23 Paul Eggert <eggert@cs.ucla.edu>
8425
8426 * xml.c (parse_region): Remove unused local
8427 that was recently introduced.
8428
c1734fbd
EZ
84292011-07-23 Eli Zaretskii <eliz@gnu.org>
8430
be18c5a5
EZ
8431 * xfns.c (unwind_create_frame) [GLYPH_DEBUG]: Adapt to changes in
8432 2008-02-22T17:42:09Z!monnier@iro.umontreal.ca.
8433
c1734fbd
EZ
8434 * xdisp.c (move_it_in_display_line_to): Record the best matching
8435 position for TO_CHARPOS while scanning the line, and restore it on
640c8776
SM
8436 exit if none of the characters scanned was an exact match.
8437 Fixes vertical-motion and pos-visible-in-window-p under bidi redisplay
a9269c18
EZ
8438 when exact match is impossible due to invisible text, and the
8439 lines are truncated.
8440
a258d627
JD
84412011-07-23 Jan Djärv <jan.h.d@swipnet.se>
8442
8443 * nsterm.m (initFrameFromEmacs): Set NSTitledWindowMask in styleMask
8444 for OSX >= 10.7.
8445
b6d5a689
EZ
84462011-07-22 Eli Zaretskii <eliz@gnu.org>
8447
0f74f785
EZ
8448 Fix a significant slow-down of cursor motion with C-n, C-p,
8449 C-f/C-b, and C-v/M-v that couldn't keep up with keyboard
8450 auto-repeat under bidi redisplay in fontified buffers.
b6d5a689 8451 * xdisp.c (compute_stop_pos_backwards): New function.
b6d5a689
EZ
8452 (next_element_from_buffer): Call compute_stop_pos_backwards to
8453 find a suitable prev_stop when we find ourselves before
0f74f785
EZ
8454 base_level_stop.
8455 (reseat): Don't look for prev_stop, as that could mean a very long
8456 run.
8457 <cached_disp_pos, cached_disp_buffer, cached_disp_modiff>
8458 <cached_disp_overlay_modiff>: Cache for last found display string
8459 position.
551918c1 8460 (compute_display_string_pos): Return the cached position if asked
0f74f785
EZ
8461 about the same buffer in the same area of character positions, and
8462 the buffer wasn't changed since the time the display string
8463 position was cached.
551918c1 8464
b2d0c91a
EZ
84652011-07-22 Eli Zaretskii <eliz@gnu.org>
8466
8467 * xdisp.c (rows_from_pos_range): Don't ignore glyphs whose object
8468 is an integer, which is important for empty lines. (Bug#9149)
8469
043604ee
CY
84702011-07-22 Chong Yidong <cyd@stupidchicken.com>
8471
8472 * frame.c (Fmodify_frame_parameters): In tty case, update the
8473 default face if necessary (Bug#4238).
8474
da4adb04
CY
84752011-07-21 Chong Yidong <cyd@stupidchicken.com>
8476
8477 * editfns.c (Fstring_to_char): No need to explain what a character
8478 is in the docstring (Bug#6576).
8479
9abd0532
LMI
84802011-07-20 Lars Magne Ingebrigtsen <larsi@gnus.org>
8481
8482 * xml.c (parse_region): Make sure we always return a tree.
8483
36881d16
HK
84842011-07-20 HAMANO Kiyoto <khiker.mail@gmail.com>
8485
8486 * xml.c (parse_region): If a document contains only comments,
8487 return that, too.
8488
1e98674d
LMI
84892011-07-20 Lars Magne Ingebrigtsen <larsi@gnus.org>
8490
8491 * xml.c (make_dom): Return comments, too.
8492
590bd467
PE
84932011-07-19 Paul Eggert <eggert@cs.ucla.edu>
8494
8495 Port to OpenBSD.
8496 See http://lists.gnu.org/archive/html/emacs-devel/2011-07/msg00688.html
8497 and the surrounding thread.
8498 * minibuf.c (read_minibuf_noninteractive): Rewrite to use getchar
8499 rather than fgets, and retry after EINTR. Otherwise, 'emacs
8500 --batch -f byte-compile-file' fails on OpenBSD if an inactivity
8501 timer goes off.
8502 * s/openbsd.h (BROKEN_SIGIO): Define.
8503 * unexelf.c (unexec) [__OpenBSD__]:
8504 Don't update the .mdebug section of the Alpha COFF symbol table.
8505
f41628b2
LMI
85062011-07-19 Lars Magne Ingebrigtsen <larsi@gnus.org>
8507
8508 * lread.c (syms_of_lread): Clarify when `lexical-binding' is used
8509 (bug#8460).
8510
b59b67c5
PE
85112011-07-18 Paul Eggert <eggert@cs.ucla.edu>
8512
15e3a074
PE
8513 * fileio.c (Fcopy_file) [!MSDOS]: Tighten created file's mask.
8514 This fixes some race conditions on the permissions of any newly
8515 created file.
8516
41bed37d
PE
8517 * alloc.c (valid_pointer_p): Use pipe, not open.
8518 This fixes some permissions issues when debugging.
8519
b59b67c5
PE
8520 * fileio.c (Fcopy_file): Adjust mode if fchown fails. (Bug#9002)
8521 If fchown fails to set both uid and gid, try to set just gid,
8522 as that is sometimes allowed. Adjust the file's mode to eliminate
8523 setuid or setgid bits that are inappropriate if fchown fails.
8524
925a6be7
SM
85252011-07-18 Stefan Monnier <monnier@iro.umontreal.ca>
8526
8527 * xdisp.c (next_element_from_string, next_element_from_buffer): Use EQ
8528 to compare Lisp_Objects.
8529 * gnutls.c (syms_of_gnutls): Rename Vgnutls_log_level to
8530 global_gnutls_log_level, don't mistake it for a Lisp_Object.
8531 (init_gnutls_functions, emacs_gnutls_handle_error): Fix up uses.
8532
52968808
AS
85332011-07-17 Andreas Schwab <schwab@linux-m68k.org>
8534
0a6a104b
AS
8535 * lread.c (read_integer): Unread even EOF character.
8536 (read1): Likewise. Properly record start position of symbol.
8537
52968808
AS
8538 * lread.c (read1): Read `#:' as empty uninterned symbol if no
8539 symbol character follows.
8540
9e381cdd
PE
85412011-07-17 Paul Eggert <eggert@cs.ucla.edu>
8542
8543 * fileio.c (Fcopy_file): Pacify gcc re fchown. (Bug#9002)
8544 This works around a problem with the previous change to Fcopy_file.
8545 Recent glibc declares fchown with __attribute__((warn_unused_result)),
8546 and without this change, GCC might complain about discarding
8547 fchown's return value.
8548
b5641435
JB
85492011-07-16 Juanma Barranquero <lekktu@gmail.com>
8550
8551 * makefile.w32-in (GLOBAL_SOURCES): Add gnutls.c (followup to bug#9059).
8552
a8031457
PE
85532011-07-16 Paul Eggert <eggert@cs.ucla.edu>
8554
8555 * fileio.c (Fcopy_file): Don't diagnose fchown failures. (Bug#9002)
8556
dd889327
LMI
85572011-07-16 Lars Magne Ingebrigtsen <larsi@gnus.org>
8558
750c33f7
LMI
8559 * gnutls.c (syms_of_gnutls): Define `gnutls-log-level' here, since
8560 it's used from the C level.
8561
dd889327
LMI
8562 * process.c: Use the same condition for POLL_FOR_INPUT in both
8563 keyboard.c and process.c (bug#1858).
8564
87e86684
LM
85652011-07-09 Lawrence Mitchell <wence@gmx.li>
8566
8567 * gnutls.c (Qgnutls_bootprop_min_prime_bits): New variable.
8568 (Fgnutls_boot): Use it.
8569
64348f40
AS
85702011-07-15 Andreas Schwab <schwab@linux-m68k.org>
8571
8572 * doc.c (Fsubstitute_command_keys): Revert last change.
8573
1d698799
LMI
85742011-07-15 Lars Magne Ingebrigtsen <larsi@gnus.org>
8575
f863868c
LMI
8576 * doc.c (Fsubstitute_command_keys): Clarify that \= really only
8577 quotes the next character, and doesn't affect other longer
8578 sequences (bug#8935).
8579
1d698799
LMI
8580 * lread.c (syms_of_lread): Clarify that is isn't only
8581 `eval-buffer' and `eval-defun' that's affected by
8582 `lexical-binding' (bug#8460).
8583
aa4b6df6
EZ
85842011-07-15 Eli Zaretskii <eliz@gnu.org>
8585
8586 * xdisp.c (move_it_in_display_line_to): Fix vertical motion with
6b02f655 8587 bidi redisplay when a line includes both an image and is truncated.
aa4b6df6 8588
5d856da6
PE
85892011-07-14 Paul Eggert <eggert@cs.ucla.edu>
8590
ad6042bb
PE
8591 Fix minor problems found by static checking.
8592 * bidi.c (bidi_cache_size): Now EMACS_INT, not size_t.
8593 (elsz): Now a signed constant, not a size_t var. We prefer signed
8594 types to unsigned, to avoid integer comparison confusion. Without
8595 this change, GCC 4.6.1 with -Wunsafe-loop-optimizations complains
8596 "cannot optimize loop, the loop counter may overflow", a symptom
8597 of the confusion.
f00bbb22 8598 * indent.c (Fvertical_motion): Mark locals as initialized.
5d856da6
PE
8599 * xdisp.c (reseat_to_string): Fix pointer signedness issue.
8600
6468f31c
LMI
86012011-07-14 Lars Magne Ingebrigtsen <larsi@gnus.org>
8602
49080b10
LMI
8603 * search.c (Fre_search_backward): Mention `case-fold-search' in
8604 all the re_search_* functions (bug#8138).
8605
6468f31c
LMI
8606 * keyboard.c (Fopen_dribble_file): Document when the file is
8607 closed (bug#8056).
8608
c965adc5
EZ
86092011-07-14 Eli Zaretskii <eliz@gnu.org>
8610
df9733bf
EZ
8611 * bidi.c (bidi_dump_cached_states): Fix format of displaying
8612 bidi_cache_idx.
8613
0bb23927
EZ
8614 Support bidi reordering of display and overlay strings.
8615 * xdisp.c (compute_display_string_pos)
8616 (compute_display_string_end): Accept additional argument STRING.
8617 (init_iterator, reseat_1): Initialize bidi_it->string.s to NULL.
8618 (reseat_to_string): Initialize bidi_it->string.s and
8619 bidi_it->string.schars.
8620 (Fcurrent_bidi_paragraph_direction): Initialize itb.string.s to
640c8776
SM
8621 NULL (avoids a crash in bidi_paragraph_init).
8622 Initialize itb.string.lstring.
0bb23927
EZ
8623 (init_iterator): Call bidi_init_it only of a valid
8624 buffer position was specified. Initialize paragraph_embedding to
8625 L2R.
8626 (reseat_to_string): Initialize the bidi iterator.
8627 (display_string): If we need to ignore text properties of
8628 LISP_STRING, set IT->stop_charpos to IT->end_charpos. (The
8629 original value of -1 will not work with bidi.)
8630 (compute_display_string_pos): First arg is now struct
8631 `text_pos *'; all callers changed. Support display properties on
8632 Lisp strings.
8633 (compute_display_string_end): Support display properties on Lisp
8634 strings.
8635 (init_iterator, reseat_1, reseat_to_string): Initialize the
8636 string.bufpos member to 0 (zero, for compatibility with IT_CHARPOS
8637 when iterating on a string not from display properties).
640c8776
SM
8638 (compute_display_string_pos, compute_display_string_end):
8639 Fix calculation of the object to scan. Fixes an error when using
0bb23927
EZ
8640 arrow keys.
8641 (next_element_from_buffer): Don't abort when IT_CHARPOS is before
640c8776
SM
8642 base_level_stop; instead, set base_level_stop to BEGV.
8643 Fixes crashes in vertical-motion.
0bb23927
EZ
8644 (next_element_from_buffer): Improve commentary for when
8645 the iterator is before prev_stop.
8646 (init_iterator): Initialize bidi_p from the default value of
8647 bidi-display-reordering, not from buffer-local value. Use the
8648 buffer-local value only if initializing for buffer iteration.
8649 (handle_invisible_prop): Support invisible properties on strings
8650 that are being bidi-reordered.
8651 (set_iterator_to_next): Support bidi reordering of C strings and
8652 Lisp strings.
8653 (next_element_from_string): Support bidi reordering of Lisp
8654 strings.
8655 (handle_stop_backwards): Support Lisp strings as well.
640c8776
SM
8656 (display_string): Support display of R2L glyph rows.
8657 Use IT_STRING_CHARPOS when displaying from a Lisp string.
0bb23927
EZ
8658 (init_iterator): Don't initialize it->bidi_p for strings
8659 here.
8660 (reseat_to_string): Initialize it->bidi_p for strings here.
8661 (next_element_from_string, next_element_from_c_string)
8662 (next_element_from_buffer): Add xassert's for correspondence
8663 between IT's object being iterated and it->bidi_it.string
8664 structure.
8665 (face_before_or_after_it_pos): Support bidi iteration.
8666 (next_element_from_c_string): Handle the case of the first string
8667 character that is not the first one in the visual order.
8668 (get_visually_first_element): New function, refactored from common
8669 parts of next_element_from_buffer, next_element_from_string, and
8670 next_element_from_c_string.
8671 (tool_bar_lines_needed, redisplay_tool_bar)
8672 (display_menu_bar): Force left-to-right direction. Add a FIXME
8673 comment for making that be controlled by a user option.
8674 (push_it, pop_it): Save and restore the state of the
8675 bidi iterator. Save and restore the bidi_p flag.
8676 (pop_it): Iterate out of display property for string iteration as
8677 well.
8678 (iterate_out_of_display_property): Support iteration over strings.
8679 (handle_single_display_spec): Set up it->bidi_it for iteration
8680 over a display string, and call bidi_init_it.
8681 (handle_single_display_spec, next_overlay_string)
8682 (get_overlay_strings_1, push_display_prop): Set up the bidi
8683 iterator for displaying display or overlay strings.
8684 (forward_to_next_line_start): Don't use the shortcut if
8685 bidi-iterating.
8686 (back_to_previous_visible_line_start): If handle_display_prop
8687 pushed the iterator stack, restore the internal state of the bidi
8688 iterator by calling bidi_pop_it same number of times.
8689 (reseat_at_next_visible_line_start): If ON_NEWLINE_P is non-zero,
8690 and we are bidi-iterating, don't decrement the iterator position;
8691 instead, set the first_elt flag in the bidi iterator, to produce
8692 the same effect.
8693 (reseat_1): Remove redundant setting of string_from_display_prop_p.
8694 (push_display_prop): xassert that we are iterating a buffer.
8695 (push_it, pop_it): Save and restore paragraph_embedding member.
8696 (handle_single_display_spec, next_overlay_string)
8697 (get_overlay_strings_1, reseat_1, reseat_to_string)
8698 (push_display_prop): Set up the `unibyte' member of bidi_it.string
8699 correctly. Don't assume unibyte strings are not bidi-reordered.
8700 (compute_display_string_pos)
8701 (compute_display_string_end): Fix handling the case of C string.
8702 (push_it, pop_it): Save and restore from_disp_prop_p.
8703 (handle_single_display_spec, push_display_prop): Set the
8704 from_disp_prop_p flag.
8705 (get_overlay_strings_1): Reset the from_disp_prop_p flag.
8706 (pop_it): Call iterate_out_of_display_property only if we are
8707 popping after iteration over a string that came from a display
8708 property. Fix a typo in popping stretch info. Add an assertion
8709 for verifying that the iterator position is in sync with the bidi
8710 iterator.
8711 (handle_single_display_spec, get_overlay_strings_1)
8712 (push_display_prop): Fix initialization of paragraph direction for
8713 string when that of the parent object is not yet determined.
8714 (reseat_1): Call bidi_init_it to resync the bidi
8715 iterator with IT's position. (Bug#7616)
8716 (find_row_edges): If ROW->start.pos gives position
8717 smaller than min_pos, use it as ROW->minpos. (Bug#7616)
8718 (handle_stop, back_to_previous_visible_line_start, reseat_1):
8719 Reset the from_disp_prop_p flag.
8720 (SAVE_IT, RESTORE_IT): New macros.
8721 (pos_visible_p, face_before_or_after_it_pos)
8722 (back_to_previous_visible_line_start)
8723 (move_it_in_display_line_to, move_it_in_display_line)
8724 (move_it_to, move_it_vertically_backward, move_it_by_lines)
8725 (try_scrolling, redisplay_window, display_line): Use them when
8726 saving a temporary copy of the iterator and restoring it back.
8727 (back_to_previous_visible_line_start, reseat_1)
8728 (init_iterator): Empty the bidi cache "stack".
8729 (move_it_in_display_line_to): If iterator ended up at
8730 EOL, but we never saw any buffer positions smaller than
8731 to_charpos, return MOVE_POS_MATCH_OR_ZV. Fixes vertical cursor
8732 motion in bidi-reordered lines.
8733 (move_it_in_display_line_to): Record prev_method and prev_pos
8734 immediately before the call to set_iterator_to_next. Fixes cursor
8735 motion in bidi-reordered lines with stretch glyphs and strings
8736 displayed in margins. (Bug#8133) (Bug#8867)
8737 Return MOVE_POS_MATCH_OR_ZV only if iterator position is past
8738 TO_CHARPOS.
640c8776
SM
8739 (pos_visible_p): Support positions in bidi-reordered lines.
8740 Save and restore bidi cache.
0bb23927
EZ
8741
8742 * bidi.c (bidi_level_of_next_char): clen should be EMACS_NT, not int.
8743 (bidi_paragraph_info): Delete unused struct.
8744 (bidi_cache_idx, bidi_cache_last_idx): Declare EMACS_INT.
8745 (bidi_cache_start): New variable.
8746 (bidi_cache_reset): Reset bidi_cache_idx to bidi_cache_start, not
8747 to zero.
8748 (bidi_cache_fetch_state, bidi_cache_search)
8749 (bidi_cache_find_level_change, bidi_cache_iterator_state)
8750 (bidi_cache_find, bidi_peek_at_next_level)
8751 (bidi_level_of_next_char, bidi_find_other_level_edge)
8752 (bidi_move_to_visually_next): Compare cache index with
8753 bidi_cache_start rather than with zero.
8754 (bidi_fetch_char): Accept new argument STRING; all callers
8755 changed. Support iteration over a string. Support strings with
8756 display properties. Support unibyte strings. Fix the type of
8757 `len' according to what STRING_CHAR_AND_LENGTH expects.
8758 (bidi_paragraph_init, bidi_resolve_explicit_1)
8759 (bidi_resolve_explicit, bidi_resolve_weak)
640c8776
SM
8760 (bidi_level_of_next_char, bidi_move_to_visually_next):
8761 Support iteration over a string.
0bb23927
EZ
8762 (bidi_set_sor_type, bidi_resolve_explicit_1)
8763 (bidi_resolve_explicit, bidi_type_of_next_char): ignore_bn_limit
8764 can now be zero (for strings); special values 0 and -1 were
8765 changed to -1 and -2, respectively.
8766 (bidi_char_at_pos): New function.
8767 (bidi_paragraph_init, bidi_resolve_explicit, bidi_resolve_weak):
8768 Call it instead of FETCH_MULTIBYTE_CHAR.
8769 (bidi_move_to_visually_next): Abort if charpos or bytepos were not
8770 initialized to valid values.
8771 (bidi_init_it): Don't initialize charpos and bytepos with invalid
8772 values.
8773 (bidi_level_of_next_char): Allow the sentinel "position" to pass
8774 the test for valid cached positions. Fix the logic for looking up
8775 the sentinel state in the cache. GCPRO the Lisp string we are
8776 iterating.
8777 (bidi_push_it, bidi_pop_it): New functions.
8778 (bidi_initialize): Initialize the bidi cache start stack pointer.
8779 (bidi_cache_ensure_space): New function, refactored from part of
8780 bidi_cache_iterator_state. Don't assume the required size is just
8781 one BIDI_CACHE_CHUNK away.
8782 (bidi_cache_start_stack, bidi_push_it): Use IT_STACK_SIZE.
8783 (bidi_count_bytes, bidi_char_at_pos): New functions.
8784 (bidi_cache_search): Don't assume bidi_cache_last_idx is
8785 always valid if bidi_cache_idx is valid.
8786 (bidi_cache_find_level_change): xassert that bidi_cache_last_idx
8787 is valid if it's going to be used.
8788 (bidi_shelve_cache, bidi_unshelve_cache): New functions.
8789 (bidi_cache_fetch_state, bidi_cache_search)
c965adc5
EZ
8790 (bidi_cache_find_level_change, bidi_cache_ensure_space)
8791 (bidi_cache_iterator_state, bidi_cache_find)
640c8776
SM
8792 (bidi_find_other_level_edge, bidi_cache_start_stack):
8793 All variables related to cache indices are now EMACS_INT.
c965adc5 8794
0bb23927
EZ
8795 * dispextern.h (struct bidi_string_data): New structure.
8796 (struct bidi_it): New member `string'. Make flag members be 1-bit
8797 fields, and put them last in the struct.
640c8776
SM
8798 (compute_display_string_pos, compute_display_string_end):
8799 Update prototypes.
0bb23927
EZ
8800 (bidi_push_it, bidi_pop_it): Add prototypes.
8801 (struct iterator_stack_entry): New members bidi_p,
8802 paragraph_embedding, and from_disp_prop_p.
8803 (struct it): Member bidi_p is now a bit field 1 bit wide.
640c8776
SM
8804 (bidi_shelve_cache, bidi_unshelve_cache):
8805 Declare prototypes.
0bb23927
EZ
8806
8807 * .gdbinit (xvectype, xvector, xcompiled, xchartable, xboolvector)
8808 (xpr, xfont, xbacktrace): Use "header.size" when accessing vectors
8809 and vector-like objects.
8810
8811 * dispnew.c (buffer_posn_from_coords): Save and restore the bidi
8812 cache around display iteration.
8813
8814 * window.c (Fwindow_end, window_scroll_pixel_based)
8815 (displayed_window_lines, Frecenter): Save and restore the bidi
8816 cache around display iteration.
8817
3bbd2265
LMI
88182011-07-14 Lars Magne Ingebrigtsen <larsi@gnus.org>
8819
8820 * editfns.c (Fdelete_region): Clarify the use of the named
8821 parameters (bug#6788).
8822
adc47434
MR
88232011-07-14 Martin Rudalics <rudalics@gmx.at>
8824
8825 * indent.c (Fvertical_motion): Set and restore w->pointm when
8826 saving and restoring the window's buffer (Bug#9006).
8827
837c31f8
LMI
88282011-07-13 Lars Magne Ingebrigtsen <larsi@gnus.org>
8829
8830 * editfns.c (Fstring_to_char): Clarify just what is returned
8831 (bug#6576). Text by Eli Zaretskii.
8832
ac389d0c
JB
88332011-07-13 Juanma Barranquero <lekktu@gmail.com>
8834
8835 * gnutls.c (init_gnutls_functions): Honor gnutls_log_level (bug#9059).
8836
0be0ce47
EZ
88372011-07-13 Eli Zaretskii <eliz@gnu.org>
8838
8839 * buffer.c (mmap_find): Fix a typo.
8840
cd18e7e3
JB
88412011-07-13 Johan Bockgård <bojohan@gnu.org>
8842
8843 Fix execution of x selection hooks.
8844 * xselect.c (Qx_lost_selection_functions)
8845 (Qx_sent_selection_functions): New vars.
8846 (syms_of_xselect): DEFSYM them.
8847 (x_handle_selection_request): Pass Qx_sent_selection_functions
8848 rather than Vx_sent_selection_functions to Frun_hook_with_args.
8849 (x_handle_selection_clear,x_clear_frame_selections):
8850 Pass Qx_lost_selection_functions rather than
8851 Vx_lost_selection_functions to Frun_hook_with_args.
8852
47ea7f44
PE
88532011-07-13 Paul Eggert <eggert@cs.ucla.edu>
8854
ac389d0c 8855 * buffer.c (Fget_buffer_create): Initialize inhibit_shrinking.
2941c447
PE
8856 The old code sometimes used this field without initializing it.
8857
47ea7f44
PE
8858 * alloc.c (gc_sweep): Don't read past end of array.
8859 In theory, the old code could also have corrupted Emacs internals,
8860 though it'd be very unlikely.
8861
bc985c87
AS
88622011-07-12 Andreas Schwab <schwab@linux-m68k.org>
8863
8864 * character.c (Fcharacterp): Don't advertise optional ignored
ac389d0c 8865 argument. (Bug#4026)
bc985c87 8866
0cf34688
LMI
88672011-07-12 Lars Magne Ingebrigtsen <larsi@gnus.org>
8868
b3dadd76
LMI
8869 * keymap.c (syms_of_keymap): Clarify that "modifier" is "modifier
8870 key" (bug#4257).
8871
0cf34688
LMI
8872 * window.c (Fset_window_start): Doc fix (bug#4199).
8873 (Fset_window_hscroll): Ditto.
8874
270768cd
PE
88752011-07-12 Paul Eggert <eggert@cs.ucla.edu>
8876
077e3dda 8877 Fix minor new problems caught by GCC 4.6.1.
270768cd 8878 * term.c (init_tty): Remove unused local.
490011a6 8879 * xsettings.c (store_monospaced_changed): Define this function only
077e3dda 8880 if (defined HAVE_GSETTINGS || defined HAVE_GCONF), as it's
490011a6 8881 not used otherwise.
270768cd 8882
b1f58454
CY
88832011-07-12 Chong Yidong <cyd@stupidchicken.com>
8884
8885 * xdisp.c (Vresize_mini_windows): Minor doc fix (Bug#3300).
8886
22b9578d
LMI
88872011-07-11 Lars Magne Ingebrigtsen <larsi@gnus.org>
8888
6e70ab07
LMI
8889 * xdisp.c (syms_of_xdisp): Make it explicit that the mini-windows
8890 are the mini-buffer and the echo area (bug#3320).
8891
22b9578d
LMI
8892 * term.c (init_tty): Remove support for supdup, c10 and perq
8893 terminals, which are no longer supported (bug#1482).
8894
8974cc9f
JB
88952011-07-10 Johan Bockgård <bojohan@gnu.org>
8896
8897 * xdisp.c (Ftool_bar_lines_needed): Fix WINDOWP check.
8898
a560d974
JD
88992011-07-10 Jan Djärv <jan.h.d@swipnet.se>
8900
8901 * xmenu.c (menu_highlight_callback): Only pass frame to show_help_event
8902 for non-popups (Bug#3642).
8903
1dae0f0a
AS
89042011-07-10 Andreas Schwab <schwab@linux-m68k.org>
8905
268c2c36 8906 * alloc.c (reset_malloc_hooks): Protoize.
1dae0f0a 8907 * buffer.c (mmap_init, mmap_find, mmap_free_1, mmap_enlarge)
268c2c36
AS
8908 (mmap_set_vars, mmap_alloc, mmap_free, mmap_realloc): Likewise.
8909 * cm.c (losecursor): Likewise.
1dae0f0a
AS
8910 * data.c (fmod): Likewise.
8911 * dispnew.c (swap_glyphs_in_rows): Likewise.
8912 * emacs.c (memory_warning_signal): Likewise.
8913 * floatfns.c (float_error): Likewise.
8914 * font.c (check_gstring, check_otf_features, otf_tag_symbol)
8915 (otf_open, font_otf_capability, generate_otf_features)
8916 (font_otf_DeviceTable, font_otf_ValueRecord, font_otf_Anchor):
8917 Likewise.
8918 * image.c (pbm_read_file): Likewise.
8919 * indent.c (string_display_width): Likewise.
8920 * intervals.c (check_for_interval, search_for_interval)
8921 (inc_interval_count, count_intervals, root_interval)
8922 (adjust_intervals_for_insertion, make_new_interval): Likewise.
8923 * lread.c (defalias): Likewise.
268c2c36 8924 * ralloc.c (r_alloc_check): Likewise.
1dae0f0a
AS
8925 * regex.c (set_image_of_range_1, set_image_of_range)
8926 (regex_grow_registers): Likewise.
8927 * sysdep.c (strerror): Likewise.
8928 * termcap.c (valid_filename_p, tprint, main): Likewise.
8929 * tparam.c (main): Likewise.
8930 * unexhp9k800.c (run_time_remap, save_data_space)
8931 (update_file_ptrs, read_header, write_header, calculate_checksum)
8932 (copy_file, copy_rest, display_header): Likewise.
8933 * widget.c (mark_shell_size_user_specified, create_frame_gcs):
8934 Likewise.
8935 * xdisp.c (check_it): Likewise.
8936 * xfaces.c (register_color, unregister_color, unregister_colors):
8937 Likewise.
8938 * xfns.c (print_fontset_result): Likewise.
8939 * xrdb.c (member, fatal, main): Likewise.
8940
99033785
PE
89412011-07-10 Paul Eggert <eggert@cs.ucla.edu>
8942
8943 Fix minor problems found by static checking (Bug#9031).
8944 * chartab.c (char_table_set_range, map_sub_char_table):
8945 Remove unused locals.
8946 (uniprop_table): Now static.
8947 * composite.c (_work_char): Remove unused static var.
8948
9cb2ac56
JB
89492011-07-09 Juanma Barranquero <lekktu@gmail.com>
8950
8951 * chartab.c (uniprop_table_uncompress): Remove unused local variable.
8952
f25661f0
JD
89532011-07-09 Jan Djärv <jan.h.d@swipnet.se>
8954
8955 * gtkutil.c (qttip_cb): Remove code without function.
8956
8278c4fe
EZ
89572011-07-09 Eli Zaretskii <eliz@gnu.org>
8958
8959 * w32.c (pthread_sigmask): New stub.
8960
1692ae2d 89612011-07-08 Paul Eggert <eggert@cs.ucla.edu>
123403e4 8962
8a6ebd58 8963 Use pthread_sigmask, not sigprocmask (Bug#9010).
123403e4
PE
8964 sigprocmask is portable only for single-threaded applications, and
8965 Emacs can be multi-threaded when it uses GTK.
1301ac26
PE
8966 * Makefile.in (LIB_PTHREAD_SIGMASK): New macro.
8967 (LIBES): Use it.
8968 * callproc.c (Fcall_process):
8969 * process.c (create_process):
8970 * sysdep.c (sys_sigblock, sys_sigunblock, sys_sigsetmask):
8971 Use pthread_sigmask, not sigprocmask.
123403e4 8972
1b854618
JD
89732011-07-08 Jan Djärv <jan.h.d@swipnet.se>
8974
8975 * gtkutil.c (qttip_cb): Set line wrap to FALSE for tooltip widget.
8976 (xg_prepare_tooltip): Revert text in x->ttip_lbl, margins was
8977 wrong (Bug#8591).
8978
3fe4b549
JD
89792011-07-08 Jan Djärv <jan.h.d@swipnet.se>
8980
0ce7e563
JD
8981 * gtkutil.c (xg_prepare_tooltip): Fix indentation and comment.
8982 Put text in x->ttip_lbl instead of gtk_tooltip_set_text (Bug#8591).
8983 (xg_hide_tooltip): Fix comment.
8984
3fe4b549
JD
8985 * nsterm.m (initFrameFromEmacs): Don't use ns_return_types
8986 in registerServicesMenuSendTypes.
8987 (validRequestorForSendType): Don't check ns_return_types.
8988
8989 * nsfns.m (Fx_open_connection): Put NSStringPboardType into
8990 ns_return_type.
8991
5df75e47
JR
89922011-07-08 Jason Rumney <jasonr@gnu.org>
8993
22610910
JR
8994 * w32term.c (x_make_frame_visible): Use SH_SHOWNORMAL rather than
8995 SH_SHOW for hidden windows (Bug#5482).
8996
5df75e47
JR
8997 * w32fns.c (w32_wnd_proc) [WM_TIMER, WM_SET_CURSOR]: Avoid using
8998 frame struct members of non-existent frames (Bug#6284).
8999
699c10bd
JD
90002011-07-08 Jan Djärv <jan.h.d@swipnet.se>
9001
4393663b
JD
9002 * nsterm.m (keyDown): Call to wantsToDelayTextChangeNotifications and
9003 variable firstTime not needed on OSX >= 10.6.
9004 (setPosition): setFloatValue:knobProportion: is deprecated on OSX
9005 >= 10.5. Use setKnobProportion, setDoubleValue.
9006
9007 * nsterm.h (MAC_OS_X_VERSION_10_3, MAC_OS_X_VERSION_10_4)
9008 (MAC_OS_X_VERSION_10_5): Define if not defined.
9009 (EmacsView, EmacsTooltip): Implements NSWindowDelegate on OSX >= 10.6.
9010 (EmacsMenu): Implements NSMenuDelegate on OSX >= 10.6.
9011 (EmacsToolbar): Implements NSToolbarDelegate on OSX >= 10.6.
9012
9013 * nsselect.m (ns_string_from_pasteboard): Don't use deprecated methods
090bd7cb 9014 cString and lossyCString on OSX >= 10.4.
4393663b 9015
58179cce 9016 * nsmenu.m (fillWithWidgetValue): Don't use deprecated method
4393663b
JD
9017 sizeToFit on OSX >= 10.2.
9018
9019 * nsimage.m (allocInitFromFile): Don't use deprecated method
9020 bestRepresentationForDevice on OSX >= 10.6.
9021
9022 * nsfns.m (check_ns_display_info): Cast to long and use %ld in error
9023 to avoid warning.
9024
9025 * emacs.c: Declare unexec_init_emacs_zone.
9026
a63e0781
JD
9027 * nsgui.h: Fix compiler warning about gnulib redefining verify.
9028
699c10bd
JD
9029 * nsselect.m (ns_get_local_selection): Change to extern (Bug#8842).
9030
9031 * nsmenu.m (ns_update_menubar): Remove useless setDelegate call
9032 on svcsMenu (Bug#8842).
9033
9034 * nsfns.m (Fx_open_connection): Remove NSStringPboardType from
9035 ns_return_types.
9036 (Fns_list_services): Just return Qnil on 10.6, code not working there.
9037
9038 * nsterm.m (QUTF8_STRING): Declare.
9039 (initFrameFromEmacs): Call registerServicesMenuSendTypes.
9040 (validRequestorForSendType): Return type is (id).
9041 Change indexOfObjectIdenticalTo to indexOfObject.
9042 Check if we have local selection before returning self (Bug#8842).
9043 (writeSelectionToPasteboard): Put local selection into paste board
9044 if we have a local selection (Bug#8842).
9045 (syms_of_nsterm): DEFSYM QUTF8_STRING.
9046
9047 * nsterm.h (MAC_OS_X_VERSION_10_6): Define here instead of nsterm.m.
9048 (ns_get_local_selection): Declare.
9049
54e10184
LMI
90502011-07-07 Lars Magne Ingebrigtsen <larsi@gnus.org>
9051
9888ff71
LMI
9052 * keymap.c (describe_map_tree): Don't insert a double newline at
9053 the end of the buffer (bug#1169) and return whether we inserted
9054 something.
9055
54e10184
LMI
9056 * callint.c (Fcall_interactively): Change "reading args" to
9057 "providing args" to try to clarify what it does (bug#1010).
9058
15fa4783
KH
90592011-07-07 Kenichi Handa <handa@m17n.org>
9060
9061 * composite.c (composition_compute_stop_pos): Ignore a static
9062 composition starting before CHARPOS (Bug#8915).
9063
9064 * xdisp.c (handle_composition_prop): Likewise.
9065
a8815b00
EZ
90662011-07-07 Eli Zaretskii <eliz@gnu.org>
9067
9068 * term.c (produce_glyphs) <xassert>: Allow IT_GLYPHLESS in it->what.
9069 (Bug#9015)
9070
ef7b981d 90712011-07-07 Kenichi Handa <handa@m17n.org>
c805dec0
KH
9072
9073 * character.h (unicode_category_t): New enum type.
9074
9075 * chartab.c (uniprop_decoder_t, uniprop_encoder_t): New types.
9076 (Qchar_code_property_table): New variable.
9077 (UNIPROP_TABLE_P, UNIPROP_GET_DECODER)
9078 (UNIPROP_COMPRESSED_FORM_P): New macros.
9079 (char_table_ascii): Uncompress the compressed values.
9080 (sub_char_table_ref): New arg is_uniprop. Callers changed.
9081 Uncompress the compressed values.
ac389d0c 9082 (sub_char_table_ref_and_range): Likewise.
c805dec0
KH
9083 (char_table_ref_and_range): Uncompress the compressed values.
9084 (sub_char_table_set): New arg is_uniprop. Callers changed.
9085 Uncompress the compressed values.
9086 (sub_char_table_set_range): Args changed. Callers changed.
9087 (char_table_set_range): Adjuted for the above change.
9088 (map_sub_char_table): Delete args default_val and parent. Add arg
9089 top. Give decoded values to a Lisp function.
640c8776 9090 (map_char_table): Adjust for the above change. Give decoded
c805dec0
KH
9091 values to a Lisp function. Gcpro more variables.
9092 (uniprop_table_uncompress)
9093 (uniprop_decode_value_run_length): New functions.
9094 (uniprop_decoder, uniprop_decoder_count): New variables.
9095 (uniprop_get_decoder, uniprop_encode_value_character)
9096 (uniprop_encode_value_run_length, uniprop_encode_value_numeric):
9097 New functions.
9098 (uniprop_encoder, uniprop_encoder_count): New variables.
9099 (uniprop_get_encoder, uniprop_table)
9100 (Funicode_property_table_internal, Fget_unicode_property_internal)
9101 (Fput_unicode_property_internal): New functions.
9102 (syms_of_chartab): DEFSYM Qchar_code_property_table, defsubr
9103 Sunicode_property_table_internal, Sget_unicode_property_internal,
5e617bc2 9104 and Sput_unicode_property_internal. Defvar_lisp
c805dec0
KH
9105 char-code-property-alist.
9106
640c8776 9107 * composite.c (CHAR_COMPOSABLE_P): Adjust for the change of
c805dec0
KH
9108 Vunicode_category_table.
9109
640c8776 9110 * font.c (font_range): Adjust for the change of
c805dec0
KH
9111 Vunicode_category_table.
9112
76b397fb
DN
91132011-07-07 Dan Nicolaescu <dann@ics.uci.edu>
9114
9115 * m/iris4d.h: Remove file, move contents ...
9116 * s/irix6-5.h: ... here.
9117
22b4128e
PE
91182011-07-06 Paul Eggert <eggert@cs.ucla.edu>
9119
9120 Remove unportable assumption about struct layout (Bug#8884).
8a5c77bb
PE
9121 * alloc.c (mark_buffer):
9122 * buffer.c (reset_buffer_local_variables, Fbuffer_local_variables)
9123 (clone_per_buffer_values): Don't assume that
22b4128e
PE
9124 sizeof (struct buffer) is a multiple of sizeof (Lisp_Object).
9125 This isn't true in general, and it's particularly not true
9126 if Emacs is configured with --with-wide-int.
9127 * buffer.h (FIRST_FIELD_PER_BUFFER, LAST_FIELD_PER_BUFFER):
9128 New macros, used in the buffer.c change.
9129
869795d6
JD
91302011-07-05 Jan Djärv <jan.h.d@swipnet.se>
9131
9132 * xsettings.c: Use both GConf and GSettings if both are available.
9133 (store_config_changed_event): Add comment.
9134 (dpyinfo_valid, store_font_name_changed, map_tool_bar_style)
9135 (store_tool_bar_style_changed): New functions.
5e617bc2 9136 (store_monospaced_changed): Add comment. Call dpyinfo_valid.
869795d6
JD
9137 (struct xsettings): Move font inside HAVE_XFT.
9138 (GSETTINGS_TOOL_BAR_STYLE, GSETTINGS_FONT_NAME): New defines.
640c8776 9139 (GSETTINGS_MONO_FONT): Rename from SYSTEM_MONO_FONT.
869795d6 9140 Move inside HAVE_XFT.
640c8776 9141 (something_changed_gsettingsCB): Rename from something_changedCB.
869795d6
JD
9142 Check for changes in GSETTINGS_TOOL_BAR_STYLE and GSETTINGS_FONT_NAME
9143 also.
9144 (GCONF_TOOL_BAR_STYLE, GCONF_FONT_NAME): New defines.
5e617bc2 9145 (GCONF_MONO_FONT): Rename from SYSTEM_MONO_FONT. Move inside HAVE_XFT.
640c8776 9146 (something_changed_gconfCB): Rename from something_changedCB.
869795d6
JD
9147 Check for changes in GCONF_TOOL_BAR_STYLE and GCONF_FONT_NAME also.
9148 (parse_settings): Move check for font inside HAVE_XFT.
9149 (read_settings, apply_xft_settings): Add comment.
9150 (read_and_apply_settings): Add comment. Call map_tool_bar_style and
9151 store_tool_bar_style_changed. Move check for font inside HAVE_XFT and
9152 call store_font_name_changed.
9153 (xft_settings_event): Add comment.
9154 (init_gsettings): Add comment. Get values for GSETTINGS_TOOL_BAR_STYLE
9155 and GSETTINGS_FONT_NAME. Move check for fonts within HAVE_XFT.
9156 (init_gconf): Add comment. Get values for GCONF_TOOL_BAR_STYLE
9157 and GCONF_FONT_NAME. Move check for fonts within HAVE_XFT.
9158 (xsettings_initialize): Call init_gsettings last.
640c8776
SM
9159 (xsettings_get_system_font, xsettings_get_system_normal_font):
9160 Add comment.
869795d6 9161
d8ed26bd
PE
91622011-07-05 Paul Eggert <eggert@cs.ucla.edu>
9163
9164 Random fixes. E.g., (random) never returned negative values.
9165 * fns.c (Frandom): Use GET_EMACS_TIME for random seed, and add the
9166 subseconds part to the entropy, as that's a bit more random.
9167 Prefer signed to unsigned, since the signedness doesn't matter and
9168 in general we prefer signed. When given a limit, use a
9169 denominator equal to INTMASK + 1, not to VALMASK + 1, because the
9170 latter isn't right if USE_2_TAGS_FOR_INTS.
9171 * sysdep.c (get_random): Return a value in the range 0..INTMASK,
9172 not 0..VALMASK. Don't discard "excess" bits that random () returns.
9173
cabf1cac
SM
91742011-07-04 Stefan Monnier <monnier@iro.umontreal.ca>
9175
9176 * textprop.c (text_property_stickiness):
9177 Obey Vtext_property_default_nonsticky.
9178 (syms_of_textprop): Add `display' to Vtext_property_default_nonsticky.
9179 * w32fns.c (syms_of_w32fns):
9180 * xfns.c (syms_of_xfns): Don't Add `display' since it's there by default.
9181
6e9b2be9
PE
91822011-07-04 Paul Eggert <eggert@cs.ucla.edu>
9183
9184 * fileio.c (barf_or_query_if_file_exists): Use S_ISDIR.
9185 This is more efficient than Ffile_directory_p and avoids a minor race.
9186
90186c68
LMI
91872011-07-04 Lars Magne Ingebrigtsen <larsi@gnus.org>
9188
7c301272
LMI
9189 * buffer.c (Foverlay_put): Say what the return value is
9190 (bug#7835).
9191
c4f2d8d4
LMI
9192 * fileio.c (barf_or_query_if_file_exists): Check first if the file
9193 is a directory before asking whether to use the file name
9194 (bug#7564).
ad637907
LMI
9195 (barf_or_query_if_file_exists): Make the "File is a directory"
9196 error be more correct.
c4f2d8d4 9197
90186c68
LMI
9198 * fns.c (Frequire): Remove the mention of the .gz files, since
9199 that's installation-specific, but keep the mention of
9200 `get-load-suffixes'.
9201
da64016e
PE
92022011-07-04 Paul Eggert <eggert@cs.ucla.edu>
9203
9204 * editfns.c (Fformat_time_string): Don't assume strlen fits in int.
9205 Report string overflow if the output is too long.
9206
7d47b580
JB
92072011-07-04 Juanma Barranquero <lekktu@gmail.com>
9208
a555cb87
JB
9209 * gnutls.c (Fgnutls_boot): Don't mention :verify-error.
9210 (syms_of_gnutls): Remove duplicate DEFSYM for
9211 Qgnutls_bootprop_verify_hostname_error, an error for
9212 Qgnutls_bootprop_verify_error (which is no longer used).
9213
7d47b580
JB
9214 * eval.c (find_handler_clause): Remove parameters `sig' and `data',
9215 unused since 2011-01-26T20:02:07Z!monnier@iro.umontreal.ca. All callers changed.
9216 Also (re)move comments that are misplaced or no longer relevant.
9217
1e49bfab
LMI
92182011-07-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
9219
9220 * callint.c (Finteractive): Clarify the meaning of "@" (bug#8813).
9221
1485f4c0
CY
92222011-07-03 Chong Yidong <cyd@stupidchicken.com>
9223
9224 * xfaces.c (Finternal_merge_in_global_face): Modify the foreground
9225 and background color parameters if they have been changed.
9226
a9ab721e
LMI
92272011-07-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
9228
9229 * editfns.c (Fformat): Clarify the - and 0 flags (bug#6659).
9230
cf7cff57
PE
92312011-07-03 Paul Eggert <eggert@cs.ucla.edu>
9232
2e13213d
PE
9233 * xsettings.c (SYSTEM_FONT): Define only when used.
9234 No need to define when HAVE_GSETTINGS || !HAVE_XFT.
9235
cf7cff57
PE
9236 * keymap.c (access_keymap_1): Now static.
9237
7a8e04f7
CY
92382011-07-02 Chong Yidong <cyd@stupidchicken.com>
9239
9240 * keyboard.c (command_loop_1): If a down-mouse event is unbound,
9241 leave any prefix arg for the up event (Bug#1586).
9242
61352f62
LMI
92432011-07-02 Lars Magne Ingebrigtsen <larsi@gnus.org>
9244
69bb1ef7
LMI
9245 * lread.c (syms_of_lread): Mention single symbols defined by
9246 `defvar' or `defconst' (bug#7154).
9247
61352f62 9248 * fns.c (Frequire): Mention .el.gz files (bug#7314).
7b3747f9 9249 (Frequire): Mention get-load-suffixes.
61352f62 9250
28545e04
MR
92512011-07-02 Martin Rudalics <rudalics@gmx.at>
9252
9253 * window.h (window): Remove clone_number slot.
9254 * window.c (Fwindow_clone_number, Fset_window_clone_number):
9255 Remove.
9256 (make_parent_window, make_window, saved_window)
9257 (Fset_window_configuration, save_window_save): Don't deal with
9258 clone numbers.
9259 * buffer.c (Qclone_number): Remove declaration.
9260 (sort_overlays, overlay_strings): Don't deal with clone numbers.
9261
3349e122
SM
92622011-07-02 Stefan Monnier <monnier@iro.umontreal.ca>
9263
9264 Add multiple inheritance to keymaps.
9265 * keymap.c (Fmake_composed_keymap): New function.
9266 (Fset_keymap_parent): Simplify.
9267 (fix_submap_inheritance): Remove.
9268 (access_keymap_1): New function extracted from access_keymap to handle
9269 embedded parents and handle lists of maps.
9270 (access_keymap): Use it.
9271 (Fkeymap_prompt, map_keymap_internal, map_keymap, store_in_keymap)
9272 (Fcopy_keymap): Handle embedded parents.
9273 (Fcommand_remapping, define_as_prefix): Simplify.
9274 (Fkey_binding): Simplify.
9275 (syms_of_keymap): Move minibuffer-local-completion-map,
9276 minibuffer-local-filename-completion-map,
9277 minibuffer-local-must-match-map, and
9278 minibuffer-local-filename-must-match-map to Elisp.
9279 (syms_of_keymap): Defsubr make-composed-keymap.
9280 * keyboard.c (menu_bar_items): Use map_keymap_canonical.
9281 (parse_menu_item): Trivial simplification.
9282
3279eb87
GM
92832011-07-01 Glenn Morris <rgm@gnu.org>
9284
9285 * Makefile.in (SETTINGS_LIBS): Fix typo.
9286
4550efdf
KI
92872011-07-01 Kazuhiro Ito <kzhr@d1.dion.ne.jp> (tiny patch)
9288
9289 * coding.c (Fencode_coding_string): Record the last coding system
9290 used, as the function doc string says (bug#8738).
9291
0949d2b6
JD
92922011-07-01 Jan Djärv <jan.h.d@swipnet.se>
9293
9294 * xsettings.c (store_monospaced_changed): Take new font as arg and
9295 check for change against current_mono_font.
9296 (EMACS_TYPE_SETTINGS): Remove this and related defines.
9297 (emacs_settings_constructor, emacs_settings_get_property)
9298 (emacs_settings_set_property, emacs_settings_class_init)
9299 (emacs_settings_init, gsettings_obj): Remove.
9300 (something_changedCB): New function for HAVE_GSETTINGS.
9301 (something_changedCB): HAVE_GCONF: Call store_monospaced_changed
9302 with value as argument.
9303 (init_gsettings): Check that GSETTINGS_SCHEMA exists before calling
9304 g_settings_new (Bug#8967). Do not create gsettings_obj.
9173deec 9305 Remove calls to g_settings_bind. Connect something_changedCB to
0949d2b6
JD
9306 "changed".
9307
9308 * xgselect.c: Add defined (HAVE_GSETTINGS).
9309 (xgselect_initialize): Ditto.
9310
9311 * process.c: Add defined (HAVE_GSETTINGS) for xgselect.h
9312 (wait_reading_process_output): Add defined (HAVE_GSETTINGS) for
9313 xg_select.
9314
bbc6b304
PE
93152011-07-01 Paul Eggert <eggert@cs.ucla.edu>
9316
9317 * eval.c (struct backtrace): Simplify and port the data structure.
9318 Do not assume that "int nargs : BITS_PER_INT - 2;" produces a
9319 signed bit field, as this assumption is not portable and it makes
9320 Emacs crash when compiled with Sun C 5.8 on sparc. Do not use
9321 "char debug_on_exit : 1" as this is not portable either; instead,
9322 use the portable "unsigned int debug_on_exit : 1". Remove unused
9323 member evalargs. Remove obsolete comments about cc bombing out.
9324
9851bfc5
JD
93252011-06-30 Jan Djärv <jan.h.d@swipnet.se>
9326
51bb811f 9327 * xsettings.c: Include glib-object.h, gio/gio.h if HAVE_GSETTINGS.
9851bfc5
JD
9328 Let HAVE_GSETTINGS override HAVE_GCONF.
9329 (store_monospaced_changed): New function.
9330 (EMACS_SETTINGS): A new type derived from GObject to handle
9331 GSettings notifications.
9332 (emacs_settings_constructor, emacs_settings_get_property)
9333 (emacs_settings_set_property, emacs_settings_class_init):
9334 New functions.
9335 (gsettings_client, gsettings_obj): New variables.
9336 (GSETTINGS_SCHEMA): New define.
9337 (something_changedCB): Call store_monospaced_changed.
9338 (init_gsettings): New function.
9339 (xsettings_initialize): Call init_gsettings.
9340 (syms_of_xsettings): Initialize gsettings_client, gsettings_obj
9341 to NULL.
9342
640c8776 9343 * Makefile.in (SETTINGS_CFLAGS, SETTINGS_LIBS): Rename from
9851bfc5
JD
9344 GCONF_CFLAGS/LIBS.
9345
5386012d
MR
93462011-06-29 Martin Rudalics <rudalics@gmx.at>
9347
9348 * window.c (resize_root_window, grow_mini_window)
9349 (shrink_mini_window): Rename Qresize_root_window to
9350 Qwindow_resize_root_window and Qresize_root_window_vertically to
9351 Qwindow_resize_root_window_vertically.
9352
f13e0b08
PE
93532011-06-28 Paul Eggert <eggert@cs.ucla.edu>
9354
9355 * gnutls.c (Qgnutls_bootprop_verify_error): Remove unused var.
9356
94515237
JB
93572011-06-27 Juanma Barranquero <lekktu@gmail.com>
9358
9359 * makefile.w32-in: Redesign dependencies so they reflect more
9360 clearly which files are directly included by each source file,
9361 and not through other includes.
9362
e43b6e43
MR
93632011-06-27 Martin Rudalics <rudalics@gmx.at>
9364
9365 * buffer.c (Qclone_number): Declare static and DEFSYM it.
9366 (sort_overlays, overlay_strings): When an overlay's clone number
9367 matches the window's clone number process the overlay even if
9368 the overlay's window property doesn't match the current window.
9369
d68443dc
MR
9370 * window.c (Fwindow_vchild): Rename to Fwindow_top_child.
9371 (Fwindow_hchild): Rename to Fwindow_left_child.
9372 (Fwindow_next): Rename to Fwindow_next_sibling.
9373 (Fwindow_prev): Rename to Fwindow_prev_sibling.
d615d6d2
MR
9374 (resize_window_check): Rename to window_resize_check.
9375 (resize_window_apply): Rename to window_resize_apply.
9376 (Fresize_window_apply): Rename to Fwindow_resize_apply.
9377 (Fdelete_other_windows_internal, resize_frame_windows)
9378 (Fsplit_window_internal, Fdelete_window_internal)
9379 (grow_mini_window, shrink_mini_window)
9380 (Fresize_mini_window_internal): Fix callers accordingly.
d68443dc 9381
c7e73be5
JD
93822011-06-26 Jan Djärv <jan.h.d@swipnet.se>
9383
9384 * emacsgtkfixed.h: State that this is only used with Gtk+3.
9385 (emacs_fixed_set_min_size): Remove.
9386 (emacs_fixed_new): Take frame as argument.
9387
9388 * emacsgtkfixed.c: State that this is only used with Gtk+3.
9389 (_EmacsFixedPrivate): Remove minwidth/height.
9390 Add struct frame *f.
9391 (emacs_fixed_init): Initialize priv->f.
9392 (get_parent_class, emacs_fixed_set_min_size): Remove.
9393 (emacs_fixed_new): Set priv->f to argument.
9394 (emacs_fixed_get_preferred_width)
9395 (emacs_fixed_get_preferred_height): Use min_width/height from
9396 frames size_hint to set minimum and natural (Bug#8919).
9397 (XSetWMSizeHints, XSetWMNormalHints): Override these functions
9398 and use min_width/height from frames size_hint to set
9399 min_width/height (Bug#8919).
9400
9401 * gtkutil.c (xg_create_frame_widgets): Pass f to emacs_fixed_new.
9173deec
JB
9402 (x_wm_set_size_hint): Remove call to emacs_fixed_set_min_size.
9403 Fix indentation.
c7e73be5 9404
cf99dcf8
EZ
94052011-06-26 Eli Zaretskii <eliz@gnu.org>
9406
9407 * bidi.c (bidi_paragraph_init): Test for ZV_BYTE before calling
9408 bidi_at_paragraph_end, since fast_looking_at doesn't like to be
9409 called at ZV.
9410
029529ac
CY
94112011-06-26 Chong Yidong <cyd@stupidchicken.com>
9412
9413 * process.c (wait_reading_process_output): Bypass select if
9414 waiting for a cell while ignoring keyboard input, and input is
9415 pending. Suggested by Jan Djärv (Bug#8869).
9416
7a7ef429
PE
94172011-06-25 Paul Eggert <eggert@cs.ucla.edu>
9418
9419 Use gnulib's dup2 module instead of rolling our own.
9420 * sysdep.c (dup2) [!HAVE_DUP2]: Remove; gnulib now does this.
9421
11fdef7d 94222011-06-25 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
989b42d2
YM
9423
9424 * dispnew.c (scrolling_window): Before scrolling, turn off a
9425 mouse-highlight in the window being scrolled.
9426
cd3520a4
JB
94272011-06-24 Juanma Barranquero <lekktu@gmail.com>
9428
9429 Move DEFSYM to lisp.h and use everywhere.
9430
9431 * character.h (DEFSYM): Move declaration...
9432 * lisp.h (DEFSYM): ...here.
9433
9434 * gnutls.c:
9435 * minibuf.c:
9436 * w32menu.c:
9437 * w32proc.c:
9438 * w32select.c: Don't include character.h.
9439
9440 * alloc.c (syms_of_alloc):
9441 * buffer.c (syms_of_buffer):
9442 * bytecode.c (syms_of_bytecode):
9443 * callint.c (syms_of_callint):
9444 * casefiddle.c (syms_of_casefiddle):
9445 * casetab.c (init_casetab_once):
9446 * category.c (init_category_once, syms_of_category):
9447 * ccl.c (syms_of_ccl):
9448 * cmds.c (syms_of_cmds):
9449 * composite.c (syms_of_composite):
9450 * dbusbind.c (syms_of_dbusbind):
9451 * dired.c (syms_of_dired):
9452 * dispnew.c (syms_of_display):
9453 * doc.c (syms_of_doc):
9454 * editfns.c (syms_of_editfns):
9455 * emacs.c (syms_of_emacs):
9456 * eval.c (syms_of_eval):
9457 * fileio.c (syms_of_fileio):
9458 * fns.c (syms_of_fns):
9459 * frame.c (syms_of_frame):
9460 * fringe.c (syms_of_fringe):
9461 * insdel.c (syms_of_insdel):
9462 * keymap.c (syms_of_keymap):
9463 * lread.c (init_obarray, syms_of_lread):
9464 * macros.c (syms_of_macros):
9465 * msdos.c (syms_of_msdos):
9466 * print.c (syms_of_print):
9467 * process.c (syms_of_process):
9468 * search.c (syms_of_search):
9469 * sound.c (syms_of_sound):
9470 * syntax.c (init_syntax_once, syms_of_syntax):
9471 * terminal.c (syms_of_terminal):
9472 * textprop.c (syms_of_textprop):
9473 * undo.c (syms_of_undo):
9474 * w32.c (globals_of_w32):
9475 * window.c (syms_of_window):
9476 * xdisp.c (syms_of_xdisp):
9477 * xfaces.c (syms_of_xfaces):
9478 * xfns.c (syms_of_xfns):
9479 * xmenu.c (syms_of_xmenu):
9480 * xsettings.c (syms_of_xsettings):
9481 * xterm.c (syms_of_xterm): Use DEFSYM.
9482
4228cf16
TZ
94832011-06-24 Teodor Zlatanov <tzz@lifelogs.com>
9484
cd3520a4 9485 * gnutls.c (syms_of_gnutls): Use the DEFSYM macro from character.h.
4228cf16 9486
7fcccf1e
PE
94872011-06-23 Paul Eggert <eggert@cs.ucla.edu>
9488
7efb4e0e
PE
9489 Integer and buffer overflow fixes (Bug#8873).
9490
ff5844ad
PE
9491 * print.c (printchar, strout): Check for string overflow.
9492 (PRINTPREPARE, printchar, strout):
9493 Don't set size unless allocation succeeds.
9494
90532f02
PE
9495 * minibuf.c (read_minibuf_noninteractive): Use ptrdiff_t, not int,
9496 for sizes. Check for string overflow more accurately.
9497 Simplify newline removal at end; this suppresses a GCC 4.6.0 warning.
9498
6d84508d
PE
9499 * macros.c: Integer and buffer overflow fixes.
9500 * keyboard.h (struct keyboard.kbd_macro_bufsize):
9501 * macros.c (Fstart_kbd_macro, store_kbd_macro_char):
9502 Use ptrdiff_t, not int, for sizes.
9503 Don't increment bufsize until after realloc succeeds.
9504 Check for size-calculation overflow.
9505 (Fstart_kbd_macro): Use EMACS_INT, not int, for XINT result.
9506
437b2cb4
PE
9507 * lisp.h (DEFVAR_KBOARD): Use offsetof instead of char * finagling.
9508
8b9ac8b4
PE
9509 * lread.c: Integer overflow fixes.
9510 (read_integer): Radix is now EMACS_INT, not int,
9511 to improve quality of diagnostics for out-of-range radices.
9512 Calculate buffer size correctly for out-of-range radices.
9513 (read1): Check for integer overflow in radices, and in
9514 read-circle numbers.
82cb60d3
PE
9515 (read_escape): Avoid int overflow.
9516 (Fload, openp, read_buffer_size, read1)
9517 (substitute_object_recurse, read_vector, read_list, map_obarray):
9518 Use ptrdiff_t, not int, for sizes.
9519 (read1): Use EMACS_INT, not int, for sizes.
20270765 9520 Check for size overflow.
8b9ac8b4 9521
7fcccf1e
PE
9522 * image.c (cache_image): Check for size arithmetic overflow.
9523
bfbbd7e7
PE
9524 * lread.c: Integer overflow issues.
9525 (saved_doc_string_size, saved_doc_string_length)
9526 (prev_saved_doc_string_size, prev_saved_doc_string_length):
9527 Now ptrdiff_t, not int.
9528 (read1): Don't assume doc string length fits in int. Check for
9529 out-of-range doc string lengths.
9530 (read_list): Don't assume file position fits in int.
39019e54 9531 (read_escape): Check for hex character overflow.
bfbbd7e7 9532
4e323265
LL
95332011-06-22 Leo Liu <sdl.web@gmail.com>
9534
9535 * minibuf.c (Fcompleting_read_default, Vcompleting_read_function):
9536 Move to minibuffer.el.
9537
85fece3e
PE
95382011-06-22 Paul Eggert <eggert@cs.ucla.edu>
9539
20b84ce9 9540 Fixes for GLYPH_DEBUG found by GCC 4.6.0 static checking.
85fece3e
PE
9541 The following patches are for when GLYPH_DEBUG && !XASSERT.
9542 * dispextern.h (trace_redisplay_p, dump_glyph_string):
9543 * dispnew.c (flush_stdout):
9544 * xdisp.c (dump_glyph_row, dump_glyph_matrix, dump_glyph):
9545 Mark as externally visible.
9546 * dispnew.c (check_window_matrix_pointers): Now static.
9547 * dispnew.c (window_to_frame_vpos):
9548 * xfns.c (unwind_create_frame):
9549 * xterm.c (x_check_font): Remove unused local.
9550 * scroll.c (CHECK_BOUNDS):
9551 * xfaces.c (cache_fache): Rename local to avoid shadowing.
9552 * xfns.c, w32fns.c (image_cache_refcount, dpyinfo_refcount): Now static.
9553 * xdisp.c (check_window_end): Now a no-op if !XASSERTS.
9554 (debug_first_unchanged_at_end_vpos, debug_last_unchanged_at_beg_vpos)
9555 (debug_dvpos, debug_dy, debug_delta, debug_delta_bytes, debug_end_vpos):
9556 Now static.
9557 (debug_method_add): Use va_list and vsprintf rather than relying
9558 on undefined behavior with wrong number of arguments.
9559 (dump_glyph, dump_glyph_row, Fdump_glyph_matrix):
9560 Don't assume ptrdiff_t and EMACS_INT are the same width as int.
9561 In this code, it's OK to assume C99 behavior for ptrdiff_t formats
9562 since we're not interested in debugging glyphs with old libraries.
9563 * xfaces.c (cache_face): Move debugging code earlier; this pacifies
9564 GCC 4.6.0's static checking.
9565
0766b489
PE
95662011-06-22 Paul Eggert <eggert@cs.ucla.edu>
9567
31fd4b32
PE
9568 Integer overflow and signedness fixes (Bug#8873).
9569 A few related buffer overrun fixes, too.
9570
b79e8648
PE
9571 * font.c (font_score): Use EMACS_INT, not int, to store XINT value.
9572
0766b489
PE
9573 * dispextern.h (struct face.stipple):
9574 * image.c (x_bitmap_height, x_bitmap_width, x_bitmap_pixmap)
9575 (x_bitmap_mask, x_allocate_bitmap_record)
9576 (x_create_bitmap_from_data, x_create_bitmap_from_file)
9577 (x_destroy_bitmap, x_destroy_all_bitmaps, x_create_bitmap_mask)
9578 (x_create_bitmap_from_xpm_data):
9579 * nsterm.h (struct ns_display_info.bitmaps_size, .bitmaps_last):
9580 * w32term.h (struct w32_display_info.icon_bitmap_id, .bitmaps_size)
9581 (.bitmaps_last):
9582 * xfaces.c (load_pixmap):
9583 * xterm.c (x_bitmap_icon, x_wm_set_icon_pixmap):
9584 * xterm.h (struct x_display_info.icon_bitmap_id, .bitmaps_size)
9585 (.bitmaps_last, struct x_output.icon_bitmap):
9586 Use ptrdiff_t, not int, for bitmap indexes.
9587 (x_allocate_bitmap_record): Check for size overflow.
9588 * dispextern.h, lisp.h: Adjust to API changes elsewhere.
9589
b081724f
PE
9590 Use ptrdiff_t, not int, for overlay counts.
9591 * buffer.h (overlays_at, sort_overlays, GET_OVERLAYS_AT):
9592 * editfns.c (overlays_around, get_pos_property):
9593 * textprop.c (get_char_property_and_overlay):
9594 * xdisp.c (next_overlay_change, note_mouse_highlight):
9595 * xfaces.c (face_at_buffer_position):
21514da7
PE
9596 * buffer.c (OVERLAY_COUNT_MAX): New macro.
9597 (overlays_at, overlays_in, sort_overlays, Foverlays_at)
9598 (Fnext_overlay_change, Fprevious_overlay_change)
9599 (mouse_face_overlay_overlaps, Foverlays_in):
b081724f 9600 Use ptrdiff_t, not int, for sizes.
21514da7 9601 (overlays_at, overlays_in): Check for size-calculation overflow.
b081724f 9602
3de73e5e
PE
9603 * xterm.c (xim_initialize, same_x_server): Strlen may not fit in int.
9604
2606c57b
PE
9605 * xsmfns.c (smc_save_yourself_CB, x_session_initialize): Avoid strlen.
9606 (x_session_initialize): Do not assume string length fits in int.
9607
aaafe47a
PE
9608 * xsettings.c (apply_xft_settings): Fix potential buffer overrun.
9609 This is unlikely, but can occur if DPI is outlandish.
9610
2674ddc8 9611 * xsettings.c (Ffont_get_system_normal_font, Ffont_get_system_font):
3a5077c5
PE
9612 * xselect.c (Fx_get_atom_name): Avoid need for strlen.
9613
28154962
PE
9614 * xrdb.c: Don't assume strlen fits in int; avoid some strlens.
9615 * xrdb.c (magic_file_p, search_magic_path):
9616 Omit last arg SUFFIX; it was always 0. All callers changed.
9617 (magic_file_p): Use ptrdiff_t, not int. Check for size overflow.
9618
7de51af5
PE
9619 * xfont.c (xfont_match): Avoid need for strlen.
9620
25ed6cc3
PE
9621 * xfns.c: Don't assume strlen fits in int.
9622 (xic_create_fontsetname, x_window): Use ptrdiff_t, not int.
9623
4eab31dd
PE
9624 * xdisp.c (message_log_check_duplicate): Return intmax_t,
9625 not unsigned long, as we prefer signed integers. All callers changed.
9626 Detect integer overflow in repeat count.
9627 (message_dolog): Don't assume print length fits in 39 bytes.
df1f27af 9628 (display_mode_element): Don't assume strlen fits in int.
4eab31dd 9629
171e2a58
PE
9630 * termcap.c: Don't assume sizes fit in int and never overflow.
9631 (struct termcap_buffer, tgetent): Use ptrdiff_t, not int, for sizes.
9632 (gobble_line): Check for size-calculation overflow.
9633
ad39faca 9634 * minibuf.c (Fread_buffer):
6e5bb2dc 9635 * lread.c (intern, intern_c_string):
74ca2eb3
PE
9636 * image.c (xpm_scan) [HAVE_NS && !HAVE_XPM]:
9637 Don't assume string length fits in int.
9638
52c61c22 9639 * keyboard.c (parse_tool_bar_item):
9bda3520
PE
9640 * gtkutil.c (style_changed_cb): Avoid need for strlen.
9641
b5b8c9e5
PE
9642 * font.c: Don't assume string length fits in int.
9643 (font_parse_xlfd, font_parse_fcname, font_unparse_fcname):
9644 Use ptrdiff_t, not int.
ccd6111c
PE
9645 (font_intern_prop): Don't assume string length fits in int.
9646 Don't assume integer property fits in fixnum.
9647 * font.h (font_intern_prop): 2nd arg is now ptrdiff_t, not int.
b5b8c9e5 9648
882f0d81 9649 * filelock.c: Fix some buffer overrun and integer overflow issues.
51cab52b 9650 (get_boot_time): Don't assume gzip command string fits in 100 bytes.
882f0d81
PE
9651 Reformulate so as not to need the command string.
9652 Invoke gzip -cd rather than gunzip, as it's more portable.
9653 (lock_info_type, lock_file_1, lock_file):
9654 Don't assume pid_t and time_t fit in unsigned long.
9655 (LOCK_PID_MAX): Remove; we now use more-reliable bounds.
9656 (current_lock_owner): Prefer signed type for sizes.
9657 Use memcpy, not strncpy, where memcpy is what is really wanted.
9658 Don't assume (via atoi) that time_t and pid_t fit in int.
9659 Check for time_t and/or pid_t out of range, e.g., via a network share.
9660 Don't alloca where an auto var works fine.
9661
93f4cf88
PE
9662 * fileio.c: Fix some integer overflow issues.
9663 (file_name_as_directory, Fexpand_file_name, Fsubstitute_in_file_name):
9664 Don't assume string length fits in int.
9665 (directory_file_name): Don't assume string length fits in long.
9666 (make_temp_name): Don't assume pid fits in int, or that its print
9667 length is less than 20.
9668
f3e92b69
PE
9669 * data.c (Fsubr_name): Rewrite to avoid a strlen call.
9670
1bfdaf10
PE
9671 * coding.c (make_subsidiaries): Don't assume string length fits in int.
9672
35016e9a
PE
9673 * callproc.c (child_setup): Rewrite to avoid two strlen calls.
9674
3d1e65a1
PE
9675 * process.c (Fformat_network_address): Use EMACS_INT, not EMACS_UINT.
9676 We prefer signed integers, even for size calculations.
9677
0b963a93
PE
9678 * emacs.c: Don't assume string length fits in 'int'.
9679 (DEFINE_DUMMY_FUNCTION, sort_args): Use ptrdiff_t, not int.
9680 (main): Don't invoke strlen when not needed.
9681
573f4b54
PE
9682 * dbusbind.c (XD_ERROR): Don't arbitrarily truncate string.
9683 (XD_DEBUG_MESSAGE): Don't waste a byte.
9684
989f33ba
PE
9685 * callproc.c (getenv_internal_1, getenv_internal)
9686 (Fgetenv_internal):
965d34eb
PE
9687 * buffer.c (init_buffer): Don't assume string length fits in 'int'.
9688
e4d29b33
PE
9689 * lread.c (invalid_syntax): Omit length argument.
9690 All uses changed. This doesn't fix a bug, but it simplifies the
9691 code away from its former Hollerith-constant appearance, and it's
9692 one less 'int' to worry about when looking at integer-overflow issues.
51cab52b 9693 (string_to_number): Simplify 2011-04-26 change by invoking xsignal1.
e4d29b33 9694
eb49b136
PE
9695 * lisp.h (DEFUN): Remove bogus use of sizeof (struct Lisp_Subr).
9696 This didn't break anything, but it didn't help either.
9697 It's confusing to put a bogus integer in a place where the actual
9698 value does not matter.
9f62aeb1 9699 (LIST_END_P): Remove unused macro and its bogus comment.
cbeff735 9700 (make_fixnum_or_float): Remove unnecessary cast to EMACS_INT.
eb49b136 9701
15375a22
PE
9702 * lisp.h (union Lisp_Object.i): EMACS_INT, not EMACS_UINT.
9703 This is for consistency with the ordinary, non-USE_LISP_UNION_TYPE,
9704 implementation.
b61cc01c
PE
9705 (struct Lisp_Bool_Vector.size): EMACS_INT, not EMACS_UINT.
9706 We prefer signed types, and the value cannot exceed the EMACS_INT
9707 range anyway (because otherwise the length would not be representable).
9a8e8d9b
PE
9708 (XSET) [USE_LISP_UNION_TYPE]: Use uintptr_t and intptr_t,
9709 not EMACS_UINT and EMACS_INT, when converting pointer to integer.
9710 This avoids a GCC warning when WIDE_EMACS_INT.
15375a22 9711
53b2623d
PE
9712 * indent.c (sane_tab_width): New function.
9713 (current_column, scan_for_column, Findent_to, position_indentation)
9714 (compute_motion): Use it. This is just for clarity.
8fcaf9cc 9715 (Fcompute_motion): Don't assume hscroll and tab offset fit in int.
53b2623d 9716
51cab52b 9717 * image.c (xbm_image_p): Don't assume stated width, height fit in int.
45aebb64 9718
f2ed8a70
PE
9719 * lisp.h (lint_assume): New macro.
9720 * composite.c (composition_gstring_put_cache):
9721 * ftfont.c (ftfont_shape_by_flt): Use it to pacify GCC 4.6.0.
9722
abe80cc6
PE
9723 * editfns.c, insdel.c:
9724 Omit unnecessary forward decls, to simplify future changes.
a9e860e1 9725
b02c740e
PE
9726 * ftfont.c (ftfont_shape_by_flt): Use signed integers for lengths.
9727
ebc96716
PE
9728 * font.c (Ffont_shape_gstring): Don't assume glyph len fits in 'int'.
9729
b4e50fa0 9730 * fns.c (Ffillarray): Don't assume bool vector size fits in 'int'.
f03dc6ef 9731 Use much-faster test for byte-length change.
311d5d7c 9732 Don't assume string byte-length fits in 'int'.
a4cf38e4 9733 Check that character arg fits in 'int'.
85461888 9734 (mapcar1): Declare byte as byte, for clarity.
b4e50fa0 9735
c0c1ee9f
PE
9736 * alloc.c (Fmake_bool_vector): Avoid unnecessary multiplication.
9737
a498d7f4
PE
9738 * fns.c (concat): Catch string overflow earlier.
9739 Do not rely on integer wraparound.
9740
51cab52b
PE
9741 * dispextern.h (struct it.overlay_strings_charpos)
9742 (struct it.selective): Now EMACS_INT, not int.
87830974
PE
9743 * xdisp.c (forward_to_next_line_start)
9744 (back_to_previous_visible_line_start)
9745 (reseat_at_next_visible_line_start, next_element_from_buffer):
9746 Don't arbitrarily truncate the value of 'selective' to int.
9747
76031fad
PE
9748 * xdisp.c (init_iterator): Use XINT, not XFASTINT; it might be < 0.
9749
5eb55db9
PE
9750 * composite.c: Don't truncate sizes to 'int'.
9751 (composition_gstring_p, composition_reseat_it)
9752 (composition_adjust_point): Use EMACS_INT, not int.
7d100a81
PE
9753 (get_composition_id, composition_gstring_put_cache): Use EMACS_INT,
9754 not EMACS_UINT, for indexes.
5eb55db9 9755
0703a717
PE
9756 * category.h (CATEGORY_SET_P): Remove unnecessary cast to EMACS_INT.
9757
d6202519
PE
9758 * buffer.c: Include <verify.h>.
9759 (struct sortvec.priority, struct sortstr.priority):
8961a454 9760 Now EMACS_INT, not int.
c20998a7 9761 (compare_overlays, cmp_for_strings): Avoid subtraction overflow.
67c36fce
PE
9762 (struct sortstr.size, record_overlay_string)
9763 (struct sortstrlist.size, struct sortlist.used):
9764 Don't truncate size to int.
9765 (record_overlay_string): Check for size-calculation overflow.
d6202519 9766 (init_buffer_once): Check at compile-time, not run-time.
fadf4e30 9767
d5a19415
JM
97682011-06-22 Jim Meyering <meyering@redhat.com>
9769
029529ac 9770 Don't leak an XBM-image-sized buffer
d5a19415
JM
9771 * image.c (xbm_load): Free the image buffer after using it.
9772
a9041e6c
PE
97732011-06-21 Paul Eggert <eggert@cs.ucla.edu>
9774
9775 Port to Sun C.
9776 * composite.c (find_automatic_composition): Omit needless 'return 0;'
9777 that Sun C diagnosed.
9778 * fns.c (secure_hash): Fix pointer signedness issue.
9779 * intervals.c (static_offset_intervals): New function.
9780 (offset_intervals): Use it.
9781
7f3f739f
LL
97822011-06-21 Leo Liu <sdl.web@gmail.com>
9783
9784 * deps.mk (fns.o):
9785 * makefile.w32-in ($(BLD)/fns.$(O)): Include sha256.h and
9786 sha512.h.
9787
9788 * fns.c (secure_hash): Rename from crypto_hash_function and change
9789 the first arg to accept symbols.
5b66d427 9790 (Fsecure_hash): New primitive.
7f3f739f
LL
9791 (syms_of_fns): New symbols.
9792
76147d94
DD
97932011-06-20 Deniz Dogan <deniz@dogan.se>
9794
9795 * process.c (Fset_process_buffer): Clarify return value in
9796 docstring.
9797
7d7d0045
CY
97982011-06-18 Chong Yidong <cyd@stupidchicken.com>
9799
9800 * dispnew.c (add_window_display_history): Use BVAR.
9801
9802 * xdisp.c (debug_method_add): Use BVAR.
9803 (check_window_end, dump_glyph_matrix, dump_glyph)
9804 (dump_glyph_row, dump_glyph_string): Convert arglist to ANSI C.
9805
9806 * xfaces.c (check_lface_attrs, check_lface, dump_realized_face):
9807 Likewise.
9808
9809 * xfns.c (Fx_create_frame, x_create_tip_frame): Delay image cache
9810 check till after the cache is created in init_frame_faces.
9811
ff2bc410
SM
98122011-06-17 Stefan Monnier <monnier@iro.umontreal.ca>
9813
9814 * fns.c (Fsafe_length): Yet another int/Lisp_Object mixup.
9815
28177add
PE
98162011-06-16 Paul Eggert <eggert@cs.ucla.edu>
9817
dd3482fe
PE
9818 * lisp.h: Include <limits.h>, for INT_MAX, LONG_MAX, LLONG_MAX.
9819 Without this, prin1 mishandles Lisp_Misc_Save_Value printing on
9820 hosts with pre-C99 libraries, because pD is wrongly defined to "t".
9821
393d71f3 9822 Improve buffer-overflow checking (Bug#8873).
1c8e352f
PE
9823 * fileio.c (Finsert_file_contents):
9824 * insdel.c (insert_from_buffer_1, replace_range, replace_range_2):
9825 Remove the old (too-loose) buffer overflow checks.
9826 They weren't needed, since make_gap checks for buffer overflow.
9827 * insdel.c (make_gap_larger): Catch buffer overflows that were missed.
9828 The old code merely checked for Emacs fixnum overflow, and relied
9829 on undefined (wraparound) behavior. The new code avoids undefined
9830 behavior, and also checks for ptrdiff_t and/or size_t overflow.
9831
2e6813b0 9832 * editfns.c (Finsert_char): Don't dump core with very negative counts.
21d890a4
PE
9833 Tune. Don't use wider integers than needed. Don't use alloca.
9834 Use a bigger 'string' buffer. Rewrite to avoid 'n > 0' test.
2e6813b0 9835
599a9e4f
PE
9836 * insdel.c (replace_range): Fix buf overflow when insbytes < outgoing.
9837
99561444
PE
9838 * insdel.c, lisp.h (buffer_overflow): New function.
9839 (insert_from_buffer_1, replace_range, replace_range_2):
9840 * insdel.c (make_gap_larger):
9841 * editfns.c (Finsert_char):
9842 * fileio.c (Finsert_file_contents): Use it, to normalize wording.
9843
28177add
PE
9844 * buffer.h (BUF_BYTES_MAX): Cast to ptrdiff_t so that it's signed.
9845
e69dafad
PE
98462011-06-15 Paul Eggert <eggert@cs.ucla.edu>
9847
4baa020d 9848 Integer overflow and signedness fixes (Bug#8873, Bug#8828).
ff672d2c 9849
b1c46f02
PE
9850 * ccl.c (ASCENDING_ORDER): New macro, to work around GCC bug 43772.
9851 (GET_CCL_RANGE, IN_INT_RANGE): Use it.
9852
e69dafad
PE
9853 * fileio.c: Don't assume EMACS_INT fits in off_t.
9854 (emacs_lseek): New static function.
9855 (Finsert_file_contents, Fwrite_region): Use it.
9856 Use SEEK_SET, SEEK_CUR, SEEK_END as appropriate.
9857
566684ea
PE
9858 * fns.c (Fload_average): Don't assume 100 * load average fits in int.
9859
e6966cd6
PE
9860 * fns.c: Don't overflow int when computing a list length.
9861 * fns.c (QUIT_COUNT_HEURISTIC): New constant.
9862 (Flength, Fsafe_length): Use EMACS_INT, not int, to avoid unwanted
9863 truncation on 64-bit hosts. Check for QUIT every
9864 QUIT_COUNT_HEURISTIC entries rather than every other entry; that's
9865 faster and is responsive enough.
9866 (Flength): Report an error instead of overflowing an integer.
9867 (Fsafe_length): Return a float if the value is not representable
9868 as a fixnum. This shouldn't happen except in contrived situations.
6346d301 9869 (Fnthcdr, Fsort): Don't assume list length fits in int.
de41a810 9870 (Fcopy_sequence): Don't assume vector length fits in int.
00c604f2 9871
dd0b0efb
PE
9872 * alloc.c: Check that resized vectors' lengths fit in fixnums.
9873 (header_size, word_size): New constants.
9874 (allocate_vectorlike): Don't check size overflow here.
9875 (allocate_vector): Check it here instead, since this is the only
9876 caller of allocate_vectorlike that could cause overflow.
9877 Check that the new vector's length is representable as a fixnum.
9878
86fe5cfe
PE
9879 * fns.c (next_almost_prime): Don't return a multiple of 3 or 5.
9880 The previous code was bogus. For example, next_almost_prime (32)
9881 returned 39, which is undesirable as it is a multiple of 3; and
9882 next_almost_prime (24) returned 25, which is a multiple of 5 so
9883 why was the code bothering to check for multiples of 7?
9884
80e88859
PE
9885 * bytecode.c (exec_byte_code): Use ptrdiff_t, not int, for vector length.
9886
4a2f0ad6
PE
9887 * eval.c, doprnt.c (SIZE_MAX): Remove; inttypes.h defines this now.
9888
f66c7cf8
PE
9889 Variadic C functions now count arguments with ptrdiff_t.
9890 This partly undoes my 2011-03-30 change, which replaced int with size_t.
9891 Back then I didn't know that the Emacs coding style prefers signed int.
9892 Also, in the meantime I found a few more instances where arguments
4a2f0ad6
PE
9893 were being counted with int, which may truncate counts on 64-bit
9894 machines, or EMACS_INT, which may be unnecessarily wide.
f66c7cf8
PE
9895 * lisp.h (struct Lisp_Subr.function.aMANY)
9896 (DEFUN_ARGS_MANY, internal_condition_case_n, safe_call):
9897 Arg counts are now ptrdiff_t, not size_t.
9898 All variadic functions and their callers changed accordingly.
9899 (struct gcpro.nvars): Now size_t, not size_t. All uses changed.
9900 * bytecode.c (exec_byte_code): Check maxdepth for overflow,
9901 to avoid potential buffer overrun. Don't assume arg counts fit in 'int'.
9902 * callint.c (Fcall_interactively): Check arg count for overflow,
9903 to avoid potential buffer overrun. Use signed char, not 'int',
9904 for 'varies' array, so that we needn't bother to check its size
9905 calculation for overflow.
9906 * editfns.c (Fformat): Use ptrdiff_t, not EMACS_INT, to count args.
9907 * eval.c (apply_lambda):
9908 * fns.c (Fmapconcat): Use XFASTINT, not XINT, to get args length.
9909 (struct textprop_rec.argnum): Now ptrdiff_t, not int. All uses changed.
9910 (mapconcat): Use ptrdiff_t, not int and EMACS_INT, to count args.
9911
a1759b76
PE
9912 * callint.c (Fcall_interactively): Don't use index var as event count.
9913
d96be9fc
PE
9914 * vm-limit.c (check_memory_limits): Fix incorrect extern function decls.
9915 * mem-limits.h (SIZE): Remove; no longer used.
9916
a690a978 9917 * xterm.c (x_alloc_nearest_color_1): Prefer int to long when int works.
5efd304b 9918
578c21e6
PE
9919 Remove unnecessary casts.
9920 * xterm.c (x_term_init):
9921 * xfns.c (x_set_border_pixel):
9922 * widget.c (create_frame_gcs): Remove casts to unsigned long etc.
9923 These aren't needed now that we assume ANSI C.
9924
96f53c6c
PE
9925 * sound.c (Fplay_sound_internal): Remove cast to unsigned long.
9926 It's more likely to cause problems (due to unsigned overflow)
9927 than to cure them.
9928
83c77d31
PE
9929 * dired.c (Ffile_attributes): Don't use 32-bit hack on 64-bit hosts.
9930
ee2079f1
PE
9931 * unexelf.c (unexec): Don't assume BSS addr fits in unsigned.
9932
6da65536
PE
9933 * xterm.c (handle_one_xevent): Omit unnecessary casts to unsigned.
9934
7147c4a4
PE
9935 * keyboard.c (modify_event_symbol): Don't limit alist len to UINT_MAX.
9936
193e32d9
PE
9937 * lisp.h (CHAR_TABLE_SET): Omit now-redundant test.
9938
e5533da6
PE
9939 * lread.c (Fload): Don't compare a possibly-garbage time_t value.
9940
9910e595
PE
9941 GLYPH_CODE_FACE returns EMACS_INT, not int.
9942 * dispextern.h (merge_faces):
9943 * xfaces.c (merge_faces):
01103c44
PE
9944 * xdisp.c (get_next_display_element, next_element_from_display_vector):
9945 Don't assume EMACS_INT fits in int.
9910e595 9946
2638320e
PE
9947 * character.h (CHAR_VALID_P): Remove unused parameter.
9948 * fontset.c, lisp.h, xdisp.c: All uses changed.
9949
045eb8d9
PE
9950 * editfns.c (Ftranslate_region_internal): Omit redundant test.
9951
c1f134b5
PE
9952 * fns.c (concat): Minor tuning based on overflow analysis.
9953 This doesn't fix any bugs. Use int to hold character, instead
9954 of constantly refetching from Emacs object. Use XFASTINT, not
9955 XINT, for value known to be a character. Don't bother comparing
9956 a single byte to 0400, as it's always less.
9957
395fcb93 9958 * floatfns.c (Fexpt):
327eeec8
PE
9959 * fileio.c (make_temp_name): Omit unnecessary cast to unsigned.
9960
abbd3d23
PE
9961 * editfns.c (Ftranslate_region_internal): Use int, not EMACS_INT
9962 for characters.
9963
684a03ef
PE
9964 * doc.c (get_doc_string): Omit (unsigned)c that mishandled negatives.
9965
0fed43f3
PE
9966 * data.c (Faset): If ARRAY is a string, check that NEWELT is a char.
9967 Without this fix, on a 64-bit host (aset S 0 4294967386) would
9968 incorrectly succeed when S was a string, because 4294967386 was
9969 truncated before it was used.
9970
8fd02eb7
PE
9971 * chartab.c (Fchar_table_range): Use CHARACTERP to check range.
9972 Otherwise, an out-of-range integer could cause undefined behavior
9973 on a 64-bit host.
9974
f8c86b69
PE
9975 * composite.c: Use int, not EMACS_INT, for characters.
9976 (fill_gstring_body, composition_compute_stop_pos): Use int, not
9977 EMACS_INT, for values that are known to be in character range.
9978 This doesn't fix any bugs but is the usual style inside Emacs and
9979 may generate better code on 32-bit machines.
9980
34206dd2
PE
9981 Make sure a 64-bit char is never passed to ENCODE_CHAR.
9982 This is for reasons similar to the recent CHAR_STRING fix.
9983 * charset.c (Fencode_char): Check that character arg is actually
9984 a character. Pass an int to ENCODE_CHAR.
9985 * charset.h (ENCODE_CHAR): Verify that the character argument is no
9986 wider than 'int', as a compile-time check to prevent future regressions
9987 in this area.
9988
c5958d4c 9989 * character.c (char_string): Remove unnecessary casts.
13bdea59
PE
9990
9991 Make sure a 64-bit char is never passed to CHAR_STRING.
9992 Otherwise, CHAR_STRING would do the wrong thing on a 64-bit platform,
9993 by silently ignoring the top 32 bits, allowing some values
9994 that were far too large to be valid characters.
9995 * character.h: Include <verify.h>.
9996 (CHAR_STRING, CHAR_STRING_ADVANCE): Verify that the character
9997 arguments are no wider than unsigned, as a compile-time check
9998 to prevent future regressions in this area.
9999 * data.c (Faset):
01103c44 10000 * editfns.c (Fchar_to_string, general_insert_function, Finsert_char)
13bdea59
PE
10001 (Fsubst_char_in_region):
10002 * fns.c (concat):
10003 * xdisp.c (decode_mode_spec_coding):
10004 Adjust to CHAR_STRING's new requirement.
10005 * editfns.c (Finsert_char, Fsubst_char_in_region):
10006 * fns.c (concat): Check that character args are actually
10007 characters. Without this test, these functions did the wrong
10008 thing with wildly out-of-range values on 64-bit hosts.
10009
d37ca623
PE
10010 Remove incorrect casts to 'unsigned' that lose info on 64-bit hosts.
10011 These casts should not be needed on 32-bit hosts, either.
10012 * keyboard.c (read_char):
10013 * lread.c (Fload): Remove casts to unsigned.
10014
ea204efb
PE
10015 * lisp.h (UNSIGNED_CMP): New macro.
10016 This fixes comparison bugs on 64-bit hosts.
10017 (ASCII_CHAR_P): Use it.
10018 * casefiddle.c (casify_object):
01103c44 10019 * character.h (ASCII_BYTE_P, CHAR_VALID_P)
ea204efb
PE
10020 (SINGLE_BYTE_CHAR_P, CHAR_STRING):
10021 * composite.h (COMPOSITION_ENCODE_RULE_VALID):
10022 * dispextern.h (FACE_FROM_ID):
10023 * keyboard.c (read_char): Use UNSIGNED_CMP.
10024
41cb286c
PE
10025 * xmenu.c (dialog_selection_callback) [!USE_GTK]: Cast to intptr_t,
10026 not to EMACS_INT, to avoid GCC warning.
10027
4a1b9832
PE
10028 * xfns.c (x_set_scroll_bar_default_width): Remove unused 'int' locals.
10029
55daad71
PE
10030 * buffer.h (PTR_BYTE_POS, BUF_PTR_BYTE_POS): Remove harmful cast.
10031 The cast incorrectly truncated 64-bit byte offsets to 32 bits, and
10032 isn't needed on 32-bit machines.
8f95c75c 10033
01103c44
PE
10034 * buffer.c (Fgenerate_new_buffer_name):
10035 Use EMACS_INT for count, not int.
0ceccced 10036 (advance_to_char_boundary): Return EMACS_INT, not int.
e762cafe
PE
10037
10038 * data.c (Qcompiled_function): Now static.
10039
c6f072e7
PE
10040 * window.c (window_body_lines): Now static.
10041
20ce5912
PE
10042 * image.c (gif_load): Rename local to avoid shadowing.
10043
9c4c5f81
PE
10044 * lisp.h (SAFE_ALLOCA_LISP): Check for integer overflow.
10045 (struct Lisp_Save_Value): Use ptrdiff_t, not int, for 'integer' member.
10046 * alloc.c (make_save_value): Integer argument is now of type
10047 ptrdiff_t, not int.
10048 (mark_object): Use ptrdiff_t, not int.
10049 * lisp.h (pD): New macro.
10050 * print.c (print_object): Use it.
10051
c0c5c8ae
PE
10052 * alloc.c: Use EMACS_INT, not int, to count objects.
10053 (total_conses, total_markers, total_symbols, total_vector_size)
10054 (total_free_conses, total_free_markers, total_free_symbols)
01103c44
PE
10055 (total_free_floats, total_floats, total_free_intervals)
10056 (total_intervals, total_strings, total_free_strings):
c0c5c8ae
PE
10057 Now EMACS_INT, not int. All uses changed.
10058 (Fgarbage_collect): Compute overall total using a double, so that
10059 integer overflow is less likely to be a problem. Check for overflow
10060 when converting back to an integer.
5a25e253
PE
10061 (n_interval_blocks, n_string_blocks, n_float_blocks, n_cons_blocks)
10062 (n_vectors, n_symbol_blocks, n_marker_blocks): Remove.
10063 These were 'int' variables that could overflow on 64-bit hosts;
10064 they were never used, so remove them instead of repairing them.
211a0b2a 10065 (nzombies, ngcs, max_live, max_zombies): Now EMACS_INT, not 'int'.
6349ae4d
PE
10066 (inhibit_garbage_collection): Set gc_cons_threshold to max value.
10067 Previously, this ceilinged at INT_MAX, but that doesn't work on
10068 64-bit machines.
e46bb31a 10069 (allocate_pseudovector): Don't use EMACS_INT when int would do.
c0c5c8ae 10070
c78baabf 10071 * alloc.c (Fmake_bool_vector): Don't assume vector size fits in int.
86f61a15 10072 (allocate_vectorlike): Check for ptrdiff_t overflow.
b6439961
PE
10073 (mark_vectorlike, mark_char_table, mark_object): Avoid EMACS_UINT
10074 when a (possibly-narrower) signed value would do just as well.
10075 We prefer using signed arithmetic, to avoid comparison confusion.
c78baabf 10076
c9d624c6
PE
10077 * alloc.c: Catch some string size overflows that we were missing.
10078 (XMALLOC_OVERRUN_CHECK_SIZE) [!XMALLOC_OVERRUN_CHECK]: Define to 0,
10079 for convenience in STRING_BYTES_MAX.
10080 (STRING_BYTES_MAX): New macro, superseding the old one in lisp.h.
10081 The definition here is exact; the one in lisp.h was approximate.
10082 (allocate_string_data): Check for string overflow. This catches
10083 some instances we weren't catching before. Also, it catches
10084 size_t overflow on (unusual) hosts where SIZE_MAX <= min
10085 (PTRDIFF_MAX, MOST_POSITIVE_FIXNUM), e.g., when size_t is 32 bits
10086 and ptrdiff_t and EMACS_INT are both 64 bits.
c78baabf 10087
c9d624c6
PE
10088 * character.c, coding.c, doprnt.c, editfns.c, eval.c:
10089 All uses of STRING_BYTES_MAX replaced by STRING_BYTES_BOUND.
640c8776 10090 * lisp.h (STRING_BYTES_BOUND): Rename from STRING_BYTES_MAX.
c9d624c6 10091
353032ce
PE
10092 * character.c (string_escape_byte8): Fix nbytes/nchars typo.
10093
2bccce07
PE
10094 * alloc.c (Fmake_string): Check for out-of-range init.
10095
0ac30604
SM
100962011-06-15 Stefan Monnier <monnier@iro.umontreal.ca>
10097
10098 * eval.c (Fdefvaralias): Also mark the target as variable-special-p.
10099
c195f2de
JD
101002011-06-14 Jan Djärv <jan.h.d@swipnet.se>
10101
10102 * xfns.c (x_set_scroll_bar_default_width): Remove argument to
10103 xg_get_default_scrollbar_width.
10104
10105 * gtkutil.c: Include emacsgtkfixed.h if HAVE_GTK3.
10106 (int_gtk_range_get_value): Move to the scroll bar part of the file.
10107 (style_changed_cb): Call update_theme_scrollbar_width and call
10108 x_set_scroll_bar_default_width and xg_frame_set_char_size for
10109 all frames (Bug#8505).
10110 (xg_create_frame_widgets): Call emacs_fixed_new if HAVE_GTK3 (Bug#8505).
10111 Call gtk_window_set_resizable if HAVE_GTK3.
10112 (x_wm_set_size_hint): Call emacs_fixed_set_min_size with min width
10113 and height if HAVE_GTK3 (Bug#8505).
10114 (scroll_bar_width_for_theme): New variable.
10115 (update_theme_scrollbar_width): New function.
10116 (xg_get_default_scrollbar_width): Move code to
10117 update_theme_scrollbar_width, just return scroll_bar_width_for_theme.
10118 (xg_initialize): Call update_theme_scrollbar_width.
10119
10120 * gtkutil.h (xg_get_default_scrollbar_width): Remove argument.
10121
10122 * emacsgtkfixed.c, emacsgtkfixed.h: New files.
10123
e10ac9f1
MR
101242011-06-12 Martin Rudalics <rudalics@gmx.at>
10125
10126 * frame.c (make_frame): Call other_buffer_safely instead of
10127 other_buffer.
10128
10129 * window.c (temp_output_buffer_show): Call display_buffer with
10130 second argument Vtemp_buffer_show_specifiers and reset latter
10131 immediately after the call.
10132 (Vtemp_buffer_show_specifiers): New variable.
10133 (auto_window_vscroll_p, next_screen_context_lines)
10134 (Vscroll_preserve_screen_position): Remove leading asterisks from
10135 doc-strings.
10136
2d3c217e 101372011-06-12 Paul Eggert <eggert@cs.ucla.edu>
4475bec4 10138
7b7f97e8 10139 Fix minor problems found by GCC 4.6.0 static checking.
4475bec4
PE
10140 * buffer.c (Qclone_number): Remove for now, as it's unused.
10141 (record_buffer, Funrecord_buffer): Rename local to avoid shadowing.
10142 (record_buffer): Remove unused local.
10143 * frame.c (other_visible_frames, frame_buffer_list): Now static.
10144 (set_frame_buffer_list): Remove; unused.
10145 * frame.h (other_visible_frames): Remove decl.
10146 * keyboard.h (menu_items_inuse): Declare only if USE_GTK || USE_MOTIF.
10147 * lisp.h (frame_buffer_list, set_frame_buffer_list): Remove decls.
10148 (add_gpm_wait_descriptor, delete_gpm_wait_descriptor): Declare only
10149 if HAVE_GPM.
10150 * menu.c (menu_items_inuse): Now static unless USE_GTK || USE_MOTIF.
10151 * process.c (add_gpm_wait_descriptor, delete_gpm_wait_descriptor):
10152 Define only if HAVE_GPM.
10153 * widget.c (EmacsFrameResize, emacsFrameClassRec): Now static.
10154 (update_hints_inhibit): Remove; never set. All uses removed.
10155 * widgetprv.h (emacsFrameClassRec): Remove decl.
10156 * window.c (delete_deletable_window): Now returns void, since it
10157 wasn't returning anything.
10158 (compare_window_configurations): Remove unused locals.
10159 * xfns.c (x_set_scroll_bar_default_width): Remove unused locals.
10160 * xmenu.c (x_menu_set_in_use): Define only if USE_GTK || USE_MOTIF.
4475bec4
PE
10161 (dialog_selection_callback) [!USE_GTK]: Prefer intptr_t for integers
10162 the same widths as pointers. This follows up on the 2011-05-06 patch.
10163 * xterm.c (x_alloc_lighter_color_for_widget): Define only if USE_LUCID.
10164 * xterm.h: Likewise.
10165 (x_menu_set_in_use): Declare only if USE_GTK || USE_MOTIF.
10166
1384b89e
JB
101672011-06-12 Juanma Barranquero <lekktu@gmail.com>
10168
10169 * makefile.w32-in: Update dependencies.
10170 (LISP_H): Add lib/intprops.h.
10171
1100a63c
CY
101722011-06-11 Chong Yidong <cyd@stupidchicken.com>
10173
10174 * image.c (gif_load): Add animation frame delay to the metadata.
10175 (syms_of_image): Use DEFSYM. New symbol `delay'.
10176
6198ccd0
MR
101772011-06-11 Martin Rudalics <rudalics@gmx.at>
10178
10179 * window.c (delete_deletable_window): Re-add.
10180 (Fset_window_configuration): Rewrite to handle dead buffers and
10181 consequently deletable windows.
10182 (window_tree, Fwindow_tree): Remove. Supply functionality in
10183 window.el.
10184 (compare_window_configurations): Simplify code.
10185
b6e3633c
AS
101862011-06-11 Andreas Schwab <schwab@linux-m68k.org>
10187
1ab0dee5
AS
10188 * image.c (imagemagick_load_image): Fix type mismatch.
10189 (Fimagemagick_types): Likewise.
10190
b6e3633c
AS
10191 * window.h (replace_buffer_in_windows): Declare.
10192
9397e56f
MR
101932011-06-11 Martin Rudalics <rudalics@gmx.at>
10194
10195 * buffer.c: New Lisp objects Qbuffer_list_update_hook and
10196 Qclone_number. Remove external declaration of Qdelete_window.
10197 (Fbuffer_list): Rewrite doc-string. Minor restructuring of
10198 code.
640c8776
SM
10199 (Fget_buffer_create, Fmake_indirect_buffer, Frename_buffer):
10200 Run Qbuffer_list_update_hook if allowed.
9397e56f
MR
10201 (Fother_buffer): Rewrite doc-string. Major rewrite for new
10202 buffer list implementation.
10203 (other_buffer_safely): New function.
10204 (Fkill_buffer): Replace call to replace_buffer_in_all_windows by
10205 calls to replace_buffer_in_windows and
10206 replace_buffer_in_windows_safely. Run Qbuffer_list_update_hook
10207 if allowed.
10208 (record_buffer): Inhibit quitting and rewrite using quittable
10209 functions. Run Qbuffer_list_update_hook if allowed.
10210 (Frecord_buffer, Funrecord_buffer): New functions.
640c8776
SM
10211 (switch_to_buffer_1, Fswitch_to_buffer): Remove.
10212 Move switch-to-buffer to window.el.
9397e56f
MR
10213 (bury-buffer): Move to window.el.
10214 (Vbuffer_list_update_hook): New variable.
10215
10216 * lisp.h (other_buffer_safely): Add prototype in buffer.c
10217 section.
10218
10219 * window.h (resize_frame_windows): Move up in code.
10220 (Fwindow_frame): Remove EXFUN.
10221 (replace_buffer_in_all_windows): Remove prototype.
10222 (replace_buffer_in_windows_safely): Add prototype.
10223
10224 * window.c: Declare Qdelete_window static again. Move down
10225 declaration of select_count.
10226 (Fnext_window, Fprevious_window): Rewrite doc-strings.
10227 (Fother_window): Move to window.el.
10228 (window_loop): Remove DELETE_BUFFER_WINDOWS and UNSHOW_BUFFER
10229 cases. Add REPLACE_BUFFER_IN_WINDOWS_SAFELY case.
10230 (Fdelete_windows_on, Freplace_buffer_in_windows): Move to
10231 window.el.
10232 (replace_buffer_in_windows): Implement by calling
10233 Qreplace_buffer_in_windows.
10234 (replace_buffer_in_all_windows): Remove with some functionality
10235 moved into replace_buffer_in_windows_safely.
10236 (replace_buffer_in_windows_safely): New function.
10237 (select_window_norecord, select_frame_norecord): Move in front
10238 of run_window_configuration_change_hook. Remove now obsolete
10239 declarations.
640c8776
SM
10240 (Fset_window_buffer): Rewrite doc-string.
10241 Call Qrecord_window_buffer.
9397e56f
MR
10242 (keys_of_window): Move binding for other-window to window.el.
10243
b50691aa
CY
102442011-06-11 Chong Yidong <cyd@stupidchicken.com>
10245
10246 * dispextern.h (struct image): Replace data member, whose int_val
10247 and ptr_val fields were not used by anything, with a single
10248 lisp_val object.
10249
10250 * image.c (Fimage_metadata, make_image, mark_image, tiff_load)
10251 (gif_clear_image, gif_load, imagemagick_load_image)
10252 (gs_clear_image, gs_load): Callers changed.
10253
3f754b86
PE
102542011-06-10 Paul Eggert <eggert@cs.ucla.edu>
10255
cca69397
PE
10256 * buffer.h: Include <time.h>, for time_t.
10257 Needed to build on FreeBSD 8.2. Problem reported by Herbert J. Skuhra.
10258
109e28d0
PE
10259 Fix minor problems found by static checking.
10260
60737f02
PE
10261 * image.c (PixelGetMagickColor): Declare if ImageMagick headers don't.
10262
4b66faf3
PE
10263 Make identifiers static if they are not used in other modules.
10264 * data.c (Qcompiled_function, Qframe, Qvector):
10265 * image.c (QimageMagick, Qsvg):
10266 * minibuf.c (Qmetadata):
10267 * window.c (resize_window_check, resize_root_window): Now static.
10268 * window.h (resize_window_check, resize_root_window): Remove decls.
10269
109e28d0
PE
10270 * window.c (window_deletion_count, delete_deletable_window):
10271 Remove; unused.
46a4ce9e
PE
10272 (window_body_lines): Now static.
10273 (Fdelete_other_windows_internal): Mark vars as initialized.
10274 Make sure 'resize_failed' is initialized.
10275 (run_window_configuration_change_hook): Rename local to avoid shadowing.
10276 (resize_window_apply): Remove unused local.
10277 * window.h (delete_deletable_window): Remove decl.
10278
109e28d0 10279 * image.c (gif_load, svg_load_image): Rename locals to avoid shadowing.
33290528
PE
10280 (imagemagick_load_image): Fix pointer signedness problem by changing
10281 last arg from unsigned char * to char *. All uses changed.
10282 Also, fix a local for similar reasons.
10283 Remove unused locals. Remove locals to avoid shadowing.
10284 (fn_rsvg_handle_free): Remove; unused.
10285 (svg_load, svg_load_image): Fix pointer signedness problem.
f7e13da3 10286 (imagemagick_load_image): Don't use garbage pointer image_wand.
33290528 10287
3f754b86
PE
10288 * ftfont.c (ftfont_get_metrics, ftfont_drive_otf): Remove unused locals.
10289
2547adb1
CY
102902011-06-10 Chong Yidong <cyd@stupidchicken.com>
10291
10292 * image.c (gif_load): Fix omitted cast error introduced by
10293 2011-06-06 change.
10294
2c8e37d4
MR
102952011-06-10 Martin Rudalics <rudalics@gmx.at>
10296
10297 * window.h (resize_proportionally, orig_total_lines)
10298 (orig_top_line): Remove from window structure.
10299 (set_window_height, set_window_width, change_window_heights)
10300 (Fdelete_window): Remove prototypes.
10301 (resize_frame_windows): Remove duplicate declaration.
10302
440a42e3
EZ
103032011-06-10 Eli Zaretskii <eliz@gnu.org>
10304
10305 * window.h (resize_frame_windows, resize_window_check)
10306 (delete_deletable_window, resize_root_window)
10307 (resize_frame_windows): Declare prototypes.
10308
10309 * window.c (resize_window_apply): Make definition be "static" to
10310 match the prototype.
10311
562dd5e9
MR
103122011-06-10 Martin Rudalics <rudalics@gmx.at>
10313
10314 * window.c: Remove declarations of Qwindow_size_fixed,
10315 window_min_size_1, window_min_size_2, window_min_size,
10316 size_window, window_fixed_size_p, enlarge_window, delete_window.
10317 Remove static from declaration of Qdelete_window, it's
10318 temporarily needed by Fbury_buffer.
10319 (replace_window): Don't assign orig_top_line and
10320 orig_total_lines.
10321 (Fdelete_window, delete_window): Remove. Window deletion is
10322 handled by window.el.
640c8776
SM
10323 (window_loop): Remove DELETE_OTHER_WINDOWS case.
10324 Replace Fdelete_window calls with calls to Qdelete_window.
562dd5e9
MR
10325 (Fdelete_other_windows): Remove. Deleting other windows is
10326 handled by window.el.
10327 (window_fixed_size_p): Remove. Fixed-sizeness of windows is
10328 handled in window.el.
10329 (window_min_size_2, window_min_size_1, window_min_size): Remove.
10330 Window minimum sizes are handled in window.el.
10331 (shrink_windows, size_window, set_window_height)
10332 (set_window_width, change_window_heights, window_height)
10333 (window_width, CURBEG, CURSIZE, enlarge_window)
10334 (adjust_window_trailing_edge, Fadjust_window_trailing_edge)
10335 (Fenlarge_window, Fshrink_window): Remove. Window resizing is
10336 handled in window.el.
10337 (make_dummy_parent): Rename to make_parent_window and give it a
10338 second argument horflag.
10339 (make_window): Don't set resize_proportionally any more.
10340 (Fsplit_window): Remove. Windows are split in window.el.
10341 (save_restore_action, save_restore_orig_size)
10342 (shrink_window_lowest_first, save_restore_orig_size): Remove.
10343 Resize mini windows in window.el.
10344 (grow_mini_window, shrink_mini_window): Implement by calling
10345 Qresize_root_window_vertically, resize_window_check and
10346 resize_window_apply.
640c8776
SM
10347 (saved_window, Fset_window_configuration, save_window_save):
10348 Do not handle orig_top_line, orig_total_lines, and
562dd5e9
MR
10349 resize_proportionally.
10350 (window_min_height, window_min_width): Move to window.el.
10351 (keys_of_window): Move bindings for delete-other-windows,
10352 split-window, delete-window and enlarge-window to window.el.
10353
10354 * buffer.c: Temporarily extern Qdelete_window.
10355 (Fbury_buffer): Temporarily call Qdelete_window instead of
10356 Fdelete_window (Fbury_buffer will move to window.el soon).
10357
10358 * frame.c (set_menu_bar_lines_1): Remove code handling
10359 orig_top_line and orig_total_lines.
10360
10361 * dispnew.c (adjust_frame_glyphs_initially): Don't use
10362 set_window_height but set heights directly.
10363 (change_frame_size_1): Use resize_frame_windows.
10364
10365 * xdisp.c (init_xdisp): Don't use set_window_height but set
10366 heights directly.
10367
640c8776
SM
10368 * xfns.c (x_set_menu_bar_lines, x_set_tool_bar_lines):
10369 Use resize_frame_windows instead of change_window_heights and run
562dd5e9
MR
10370 run_window_configuration_change_hook.
10371
10372 * w32fns.c (x_set_tool_bar_lines): Use resize_frame_windows
10373 instead of change_window_heights and run
10374 run_window_configuration_change_hook.
10375
1a13852e
MR
103762011-06-09 Martin Rudalics <rudalics@gmx.at>
10377
10378 * window.c (replace_window): Rename second argument REPLACEMENT to
10379 NEW. New third argument SETFLAG. Rewrite.
10380 (delete_window, make_dummy_parent): Call replace_window with
10381 third argument 1.
10382 (window_list_1): Move down in code.
10383 (run_window_configuration_change_hook): Move set_buffer part
10384 before select_frame_norecord part in order to unwind correctly.
10385 Rename count1 to count.
10386 (recombine_windows, delete_deletable_window, resize_root_window)
10387 (Fdelete_other_windows_internal)
10388 (Frun_window_configuration_change_hook, make_parent_window)
10389 (resize_window_check, resize_window_apply, Fresize_window_apply)
10390 (resize_frame_windows, Fsplit_window_internal)
640c8776
SM
10391 (Fdelete_window_internal, Fresize_mini_window_internal):
10392 New functions.
1a13852e
MR
10393 (syms_of_window): New variables Vwindow_splits and Vwindow_nest.
10394
f3d1777e
MR
103952011-06-08 Martin Rudalics <rudalics@gmx.at>
10396
496e208e
MR
10397 * window.h (window): Add some new members to window structure -
10398 normal_lines, normal_cols, new_total, new_normal, clone_number,
10399 splits, nest, prev_buffers, next_buffers.
10400 (WINDOW_TOTAL_SIZE): Move here from window.c.
b9e809c2 10401 (MIN_SAFE_WINDOW_WIDTH, MIN_SAFE_WINDOW_HEIGHT): Define here.
496e208e 10402
f3d1777e
MR
10403 * window.c (Fwindow_height, Fwindow_width, Fwindow_full_width_p):
10404 Remove.
496e208e
MR
10405 (make_dummy_parent): Set new members of windows structure.
10406 (make_window): Move down in code. Handle new members of window
10407 structure.
10408 (Fwindow_clone_number, Fwindow_splits, Fset_window_splits)
10409 (Fwindow_nest, Fset_window_nest, Fwindow_new_total)
10410 (Fwindow_normal_size, Fwindow_new_normal, Fwindow_prev_buffers)
10411 (Fset_window_prev_buffers, Fwindow_next_buffers)
640c8776
SM
10412 (Fset_window_next_buffers, Fset_window_clone_number):
10413 New functions.
496e208e
MR
10414 (Fwindow_hscroll, Fwindow_at, Fwindow_point, Fwindow_start)
10415 (Fwindow_end, Fwindow_line_height, Fset_window_dedicated_p):
10416 Doc-string fixes.
10417 (Fwindow_parameters, Fwindow_parameter, Fset_window_parameter):
10418 Argument WINDOW can be now internal window too.
10419 (Fwindow_use_time): Move up in code.
10420 (Fget_buffer_window): Rename argument FRAME to ALL-FRAMES.
10421 Rewrite doc-string.
10422 (Fset_window_configuration, saved_window)
10423 (Fcurrent_window_configuration, save_window_save): Handle new
10424 members of window structure.
b9e809c2
MR
10425 (WINDOW_TOTAL_SIZE, MIN_SAFE_WINDOW_WIDTH)
10426 (MIN_SAFE_WINDOW_HEIGHT): Move to window.h.
10427 (syms_of_window): New Lisp objects Qrecord_window_buffer,
10428 Qwindow_deletable_p, Qdelete_window, Qreplace_buffer_in_windows,
10429 Qget_mru_window, Qresize_root_window,
10430 Qresize_root_window_vertically, Qsafe, Qabove, Qbelow,
10431 Qauto_buffer_name; staticpro them.
f3d1777e 10432
abde8f8c
MR
104332011-06-07 Martin Rudalics <rudalics@gmx.at>
10434
10435 * window.c (Fwindow_total_size, Fwindow_left_column)
10436 (Fwindow_top_line, window_body_lines, Fwindow_body_size)
10437 (Fwindow_list_1): New functions.
10438 (window_box_text_cols): Replace with window_body_cols.
640c8776
SM
10439 (Fwindow_width, Fscroll_left, Fscroll_right):
10440 Use window_body_cols instead of window_box_text_cols.
10441 (delete_window, Fset_window_configuration):
10442 Call delete_all_subwindows with window as argument.
fa8a67e6
MR
10443 (delete_all_subwindows): Take a window as argument and not a
10444 structure. Rewrite.
190b47e6
MR
10445 (window_loop): Remove handling of GET_LRU_WINDOW and
10446 GET_LARGEST_WINDOW.
10447 (Fget_lru_window, Fget_largest_window): Move to window.el.
abde8f8c
MR
10448
10449 * window.h: Extern window_body_cols instead of
fa8a67e6
MR
10450 window_box_text_cols. delete_all_subwindows now takes a
10451 Lisp_Object as argument.
abde8f8c 10452
640c8776
SM
10453 * indent.c (compute_motion, Fcompute_motion):
10454 Use window_body_cols instead of window_box_text_cols.
abde8f8c 10455
fa8a67e6
MR
10456 * frame.c (delete_frame): Call delete_all_subwindows with root
10457 window as argument.
10458
a54e3482
DC
104592011-06-07 Daniel Colascione <dan.colascione@gmail.com>
10460
10461 * fns.c (Fputhash): Document return value.
10462
60002bf5
CY
104632011-06-06 Chong Yidong <cyd@stupidchicken.com>
10464
10465 * image.c (gif_load): Implement gif89a spec "no disposal" method.
10466
0c671da6 104672011-06-06 Paul Eggert <eggert@cs.ucla.edu>
ccd9a01a 10468
b862a52a 10469 Cons<->int and similar integer overflow fixes (Bug#8794).
77984278 10470
be44ca6c
PE
10471 Check for overflow when converting integer to cons and back.
10472 * charset.c (Fdefine_charset_internal, Fdecode_char):
10473 Use cons_to_unsigned to catch overflow.
10474 (Fencode_char): Use INTEGER_TO_CONS.
10475 * composite.h (LGLYPH_CODE): Use cons_to_unsigned.
10476 (LGLYPH_SET_CODE): Use INTEGER_TO_CONS.
10477 * data.c (long_to_cons, cons_to_long): Remove.
10478 (cons_to_unsigned, cons_to_signed): New functions.
10479 These signal an error for invalid or out-of-range values.
10480 * dired.c (Ffile_attributes): Use INTEGER_TO_CONS.
10481 * fileio.c (Fset_visited_file_modtime): Use CONS_TO_INTEGER.
10482 * font.c (Ffont_variation_glyphs):
10483 * fontset.c (Finternal_char_font): Use INTEGER_TO_CONS.
10484 * lisp.h: Include <intprops.h>.
10485 (INTEGER_TO_CONS, CONS_TO_INTEGER): New macros.
10486 (cons_to_signed, cons_to_unsigned): New decls.
10487 (long_to_cons, cons_to_long): Remove decls.
10488 * undo.c (record_first_change): Use INTEGER_TO_CONS.
10489 (Fprimitive_undo): Use CONS_TO_INTEGER.
10490 * xfns.c (Fx_window_property): Likewise.
10491 * xselect.c: Include <limits.h>.
10492 (x_own_selection, selection_data_to_lisp_data):
10493 Use INTEGER_TO_CONS.
10494 (x_handle_selection_request, x_handle_selection_clear)
10495 (x_get_foreign_selection, Fx_disown_selection_internal)
10496 (Fx_get_atom_name, x_send_client_event): Use CONS_TO_INTEGER.
10497 (lisp_data_to_selection_data): Use cons_to_unsigned.
10498 (x_fill_property_data): Use cons_to_signed.
10499 Report values out of range.
10500
d1f3d2af
PE
10501 Check for buffer and string overflow more precisely.
10502 * buffer.h (BUF_BYTES_MAX): New macro.
10503 * lisp.h (STRING_BYTES_MAX): New macro.
10504 * alloc.c (Fmake_string):
10505 * character.c (string_escape_byte8):
10506 * coding.c (coding_alloc_by_realloc):
10507 * doprnt.c (doprnt):
10508 * editfns.c (Fformat):
10509 * eval.c (verror):
10510 Use STRING_BYTES_MAX, not MOST_POSITIVE_FIXNUM,
10511 since they may not be the same number.
10512 * editfns.c (Finsert_char):
10513 * fileio.c (Finsert_file_contents):
10514 Likewise for BUF_BYTES_MAX.
10515
dd52fcea
PE
10516 * image.c: Use ptrdiff_t, not int, for sizes.
10517 (slurp_file): Switch from int to ptrdiff_t.
10518 All uses changed.
10519 (slurp_file): Check that file size fits in both size_t (for
10520 malloc) and ptrdiff_t (for sanity and safety).
10521
7f9bbdbb
PE
10522 * fileio.c (Fverify_visited_file_modtime): Avoid time overflow
10523 if b->modtime has its maximal value.
10524
dfe18f82
PE
10525 * dired.c (Ffile_attributes): Don't assume EMACS_INT has >32 bits.
10526
84acfcf0
PE
10527 Don't assume time_t can fit into int.
10528 * buffer.h (struct buffer.modtime): Now time_t, not int.
10529 * fileio.c (Fvisited_file_modtime): No need for time_t cast now.
10530 * undo.c (Fprimitive_undo): Use time_t, not int, for time_t value.
10531
ccd9a01a
PE
10532 Minor fixes for signed vs unsigned integers.
10533 * character.h (MAYBE_UNIFY_CHAR):
10534 * charset.c (maybe_unify_char):
10535 * keyboard.c (read_char, reorder_modifiers):
10536 XINT -> XFASTINT, since the integer must be nonnegative.
10537 * ftfont.c (ftfont_spec_pattern):
10538 * keymap.c (access_keymap, silly_event_symbol_error):
10539 XUINT -> XFASTINT, since the integer must be nonnegative.
10540 (Fsingle_key_description, preferred_sequence_p): XUINT -> XINT,
10541 since it makes no difference and we prefer signed.
10542 * keyboard.c (record_char): Use XUINT when all the neighbors do.
10543 (access_keymap): NATNUMP -> INTEGERP, since the integer must be
10544 nonnegative.
10545
d6d100dd
SM
105462011-06-06 Stefan Monnier <monnier@iro.umontreal.ca>
10547
10548 * window.h (Fwindow_frame): Declare.
10549
2b6148e4
PE
105502011-06-06 Paul Eggert <eggert@cs.ucla.edu>
10551
10552 * alloc.c: Simplify handling of large-request failures (Bug#8800).
10553 (SPARE_MEMORY): Always define.
10554 (LARGE_REQUEST): Remove.
10555 (memory_full): Use SPARE_MEMORY rather than LARGE_REQUEST.
10556
f230ecc9
MR
105572011-06-06 Martin Rudalics <rudalics@gmx.at>
10558
727e958e
MR
10559 * lisp.h: Move EXFUNS for Fframe_root_window,
10560 Fframe_first_window and Fset_frame_selected_window to window.h.
10561
10562 * window.h: Move EXFUNS for Fframe_root_window,
10563 Fframe_first_window and Fset_frame_selected_window here from
10564 lisp.h.
10565
10566 * frame.c (Fwindow_frame, Fframe_first_window)
10567 (Fframe_root_window, Fframe_selected_window)
10568 (Fset_frame_selected_window): Move to window.c.
10569 (Factive_minibuffer_window): Move to minibuf.c.
10570 (Fother_visible_frames_p): New function.
10571
10572 * minibuf.c (Factive_minibuffer_window): Move here from frame.c.
10573
f230ecc9
MR
10574 * window.c (decode_window, decode_any_window): Move up in code.
10575 (Fwindowp, Fwindow_live_p): Rewrite doc-strings.
10576 (inhibit_frame_unsplittable): Remove unused variable.
bf60a96b
MR
10577 (Fwindow_buffer): Move up and rewrite doc-string.
10578 (Fwindow_parent, Fwindow_vchild, Fwindow_hchild, Fwindow_next)
10579 (Fwindow_prev): New functions.
727e958e
MR
10580 (Fwindow_frame): Move here from frame.c. Accept any window as
10581 argument.
10582 (Fframe_root_window, Fframe_first_window)
10583 (Fframe_selected_window): Move here from frame.c. Accept frame
10584 or arbitrary window as argument. Update doc-strings.
10585 (Fminibuffer_window): Move up in code.
10586 (Fwindow_minibuffer_p): Move up in code and simplify.
d6d100dd
SM
10587 (Fset_frame_selected_window): Move here from frame.c.
10588 Marginal rewrite.
727e958e
MR
10589 (Fselected_window, select_window, Fselect_window): Move up in
10590 code. Minor doc-string fixes.
f230ecc9 10591
4d09bcf6
PE
105922011-06-06 Paul Eggert <eggert@cs.ucla.edu>
10593
10594 * alloc.c (memory_full) [SYSTEM_MALLOC]: Port to MacOS (Bug#8800).
10595 Do not assume that spare memory exists; that assumption is valid
10596 only if SYSTEM_MALLOC.
10597 (LARGE_REQUEST): New macro, so that the issue of large requests
10598 is separated from the issue of spare memory.
10599
810928a2
AS
106002011-06-05 Andreas Schwab <schwab@linux-m68k.org>
10601
172418ad
AS
10602 * editfns.c (Fformat): Correctly handle zero flag with hexadecimal
10603 format. (Bug#8806)
10604
43f862f7
AS
10605 * gtkutil.c (xg_get_default_scrollbar_width): Avoid warning.
10606
810928a2
AS
10607 * xfns.c (x_set_scroll_bar_default_width): Move declarations
10608 before statements.
10609
a059fe24
JD
106102011-06-05 Jan Djärv <jan.h.d@swipnet.se>
10611
10612 * gtkutil.c (xg_get_default_scrollbar_width): New function.
10613
10614 * gtkutil.h: Declare xg_get_default_scrollbar_width.
10615
10616 * xfns.c (x_set_scroll_bar_default_width): If USE_GTK, get
10617 min width by calling x_set_scroll_bar_default_width (Bug#8505).
10618
989bf368
JB
106192011-06-05 Juanma Barranquero <lekktu@gmail.com>
10620
10621 * xdisp.c (single_display_spec_intangible_p): Remove declaration.
10622
4b80f674
CY
106232011-06-04 Chong Yidong <cyd@stupidchicken.com>
10624
10625 * xselect.c (x_clipboard_manager_save): Remove redundant arg.
10626 (x_clipboard_manager_save): Add return value.
d6d100dd
SM
10627 (x_clipboard_manager_error_1, x_clipboard_manager_error_2):
10628 New error handlers.
4b80f674
CY
10629 (x_clipboard_manager_save_frame, x_clipboard_manager_save_all):
10630 Obey Vx_select_enable_clipboard_manager. Catch errors in
10631 x_clipboard_manager_save (Bug#8779).
10632 (Vx_select_enable_clipboard_manager): New variable.
de65b42c 10633 (x_get_foreign_selection): Reduce scope of x_catch_errors (Bug#8790).
4b80f674 10634
99a33b77 106352011-06-04 Dan Nicolaescu <dann@ics.uci.edu>
8b3115e7
DN
10636
10637 * emacs.c (main): Warn when starting a GTK emacs in daemon mode.
10638
99a33b77 106392011-06-04 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
14eca62f
YM
10640
10641 * fringe.c (update_window_fringes): Don't update overlay arrow bitmap
10642 in the current matrix if keep_current_p is non-zero.
10643
8264569d
EZ
106442011-06-04 Eli Zaretskii <eliz@gnu.org>
10645
10646 * bidi.c (bidi_level_of_next_char): Fix last change.
10647
57f97249
EZ
106482011-06-03 Eli Zaretskii <eliz@gnu.org>
10649
fec2107c 10650 Support bidi reordering of text covered by display properties.
57f97249 10651
fec2107c
EZ
10652 * bidi.c (bidi_copy_it): Use offsetof instead of emulating it.
10653 (bidi_fetch_char, bidi_fetch_char_advance): New functions.
10654 (bidi_cache_search, bidi_cache_iterator_state)
10655 (bidi_paragraph_init, bidi_resolve_explicit, bidi_resolve_weak)
d6d100dd
SM
10656 (bidi_level_of_next_char, bidi_move_to_visually_next):
10657 Support character positions inside a run of characters covered by a
fec2107c
EZ
10658 display string.
10659 (bidi_paragraph_init, bidi_resolve_explicit_1)
10660 (bidi_level_of_next_char): Call bidi_fetch_char and
10661 bidi_fetch_char_advance instead of FETCH_CHAR and
10662 FETCH_CHAR_ADVANCE.
10663 (bidi_init_it): Initialize new members.
10664 (LRE_CHAR, RLE_CHAR, PDF_CHAR, LRO_CHAR, RLO_CHAR): Remove macro
10665 definitions.
10666 (bidi_explicit_dir_char): Lookup character type in bidi_type_table,
10667 instead of using explicit *_CHAR codes.
d6d100dd
SM
10668 (bidi_resolve_explicit, bidi_resolve_weak):
10669 Use FETCH_MULTIBYTE_CHAR instead of FETCH_CHAR, as reordering of
fec2107c
EZ
10670 bidirectional text is supported only in multibyte buffers.
10671 (bidi_init_it): Accept additional argument FRAME_WINDOW_P and use
10672 it to initialize the frame_window_p member of struct bidi_it.
10673 (bidi_cache_iterator_state, bidi_resolve_explicit_1)
10674 (bidi_resolve_explicit, bidi_resolve_weak)
10675 (bidi_level_of_next_char, bidi_move_to_visually_next): Abort if
10676 bidi_it->nchars is non-positive.
10677 (bidi_level_of_next_char): Don't try to lookup the cache for the
10678 next/previous character if nothing is cached there yet, or if we
10679 were just reseat()'ed to a new position.
c40e2fb2 10680
0e14fe90
EZ
10681 * xdisp.c (set_cursor_from_row): Set start and stop points
10682 according to the row's direction when priming the loop that looks
10683 for the glyph on which to display cursor.
10684 (single_display_spec_intangible_p): Function deleted.
10685 (display_prop_intangible_p): Reimplement to call
10686 handle_display_spec instead of single_display_spec_intangible_p.
d6d100dd
SM
10687 Accept 3 additional arguments needed by handle_display_spec.
10688 This fixes incorrect cursor motion across display property with complex
0e14fe90
EZ
10689 values: lists, `(when COND...)' forms, etc.
10690 (single_display_spec_string_p): Support property values that are
10691 lists with the argument STRING its top-level element.
10692 (display_prop_string_p): Fix the condition for processing a
10693 property that is a list to be consistent with handle_display_spec.
fec2107c 10694 (handle_display_spec): New function, refactored from the
fc6f18ce
EZ
10695 last portion of handle_display_prop.
10696 (compute_display_string_pos): Accept additional argument
10697 FRAME_WINDOW_P. Call handle_display_spec to determine whether the
10698 value of a `display' property is a "replacing spec".
10699 (handle_single_display_spec): Accept 2 additional arguments BUFPOS
10700 and FRAME_WINDOW_P. If IT is NULL, don't set up the iterator from
10701 the display property, but just return a value indicating whether
10702 the display property will replace the characters it covers.
10703 (Fcurrent_bidi_paragraph_direction): Initialize the nchars and
10704 frame_window_p members of struct bidi_it.
d6d100dd
SM
10705 (compute_display_string_pos, compute_display_string_end):
10706 New functions.
fec2107c
EZ
10707 (push_it): Accept second argument POSITION, where pop_it should
10708 jump to continue iteration.
10709 (reseat_1): Initialize bidi_it.disp_pos.
fc6f18ce 10710
fec2107c
EZ
10711 * keyboard.c (adjust_point_for_property): Adjust the call to
10712 display_prop_intangible_p to its new signature.
fc6f18ce
EZ
10713
10714 * dispextern.h (struct bidi_it): New member frame_window_p.
fec2107c
EZ
10715 (bidi_init_it): Update prototypes.
10716 (display_prop_intangible_p): Update prototype.
d6d100dd
SM
10717 (compute_display_string_pos, compute_display_string_end):
10718 Declare prototypes.
fec2107c
EZ
10719 (struct bidi_it): New members nchars and disp_pos. ch_len is now
10720 EMACS_INT.
fc6f18ce 10721
40087514 107222011-06-02 Paul Eggert <eggert@cs.ucla.edu>
0de4bb68 10723
57f53182
PE
10724 Malloc failure behavior now depends on size of allocation.
10725 * alloc.c (buffer_memory_full, memory_full): New arg NBYTES.
10726 * lisp.h: Change signatures accordingly.
10727 * alloc.c, buffer.c, editfns.c, menu.c, minibuf.c, xterm.c:
10728 All callers changed. (Bug#8762)
10729
10730 * gnutls.c: Use Emacs's memory allocators.
10731 Without this change, the gnutls library would invoke malloc etc.
10732 directly, which causes problems on non-SYNC_INPUT hosts, and which
10733 runs afoul of improving memory_full behavior. (Bug#8761)
10734 (fn_gnutls_global_set_mem_functions): New macro or function pointer.
10735 (emacs_gnutls_global_init): Use it to specify xmalloc, xrealloc,
10736 xfree instead of the default malloc, realloc, free.
10737 (Fgnutls_boot): No need to check for memory allocation failure,
10738 since xmalloc does that for us.
10739
ac32cd99 10740 Remove arbitrary limit of 2**31 entries in hash tables. (Bug#8771)
3870d916
PE
10741 * category.c (hash_get_category_set):
10742 * ccl.c (ccl_driver):
10743 * charset.c (Fdefine_charset_internal):
10744 * charset.h (struct charset.hash_index):
10745 * composite.c (get_composition_id, gstring_lookup_cache)
10746 (composition_gstring_put_cache):
10747 * composite.h (struct composition.hash_index):
10748 * dispextern.h (struct image.hash):
10749 * fns.c (next_almost_prime, larger_vector, cmpfn_eql)
10750 (cmpfn_equal, cmpfn_user_defined, hashfn_eq, hashfn_eql)
10751 (hashfn_equal, hashfn_user_defined, make_hash_table)
10752 (maybe_resize_hash_table, hash_lookup, hash_put)
10753 (hash_remove_from_table, hash_clear, sweep_weak_table, SXHASH_COMBINE)
10754 (sxhash_string, sxhash_list, sxhash_vector, sxhash_bool_vector)
10755 (Fsxhash, Fgethash, Fputhash, Fmaphash):
10756 * image.c (make_image, search_image_cache, lookup_image)
10757 (xpm_put_color_table_h):
10758 * lisp.h (struct Lisp_Hash_Table):
0de4bb68 10759 * minibuf.c (Ftry_completion, Fall_completions, Ftest_completion):
ac389d0c 10760 * print.c (print): Use 'EMACS_UINT' and 'EMACS_INT'
3870d916 10761 for hashes and hash indexes, instead of 'unsigned' and 'int'.
40087514
PE
10762 * alloc.c (allocate_vectorlike):
10763 Check for overflow in vector size calculations.
10764 * ccl.c (ccl_driver):
10765 Check for overflow when converting EMACS_INT to int.
0de4bb68
PE
10766 * fns.c, image.c: Remove unnecessary static decls that would otherwise
10767 need to be updated by these changes.
40087514
PE
10768 * fns.c (make_hash_table, maybe_resize_hash_table):
10769 Check for integer overflow with large hash tables.
0de4bb68
PE
10770 (make_hash_table, maybe_resize_hash_table, Fmake_hash_table):
10771 Prefer the faster XFLOAT_DATA to XFLOATINT where either will do.
10772 (SXHASH_REDUCE): New macro.
10773 (sxhash_string, sxhash_list, sxhash_vector, sxhash_bool_vector):
10774 Use it instead of discarding useful hash info with large hash values.
10775 (sxhash_float): New function.
10776 (sxhash): Use it. No more need for "& INTMASK" due to above changes.
10777 * lisp.h (FIXNUM_BITS): New macro, useful for SXHASH_REDUCE etc.
40087514
PE
10778 (MOST_NEGATIVE_FIXNUM, MOST_POSITIVE_FIXNUM, INTMASK):
10779 Rewrite to use FIXNUM_BITS, as this simplifies things.
0de4bb68
PE
10780 (next_almost_prime, larger_vector, sxhash, hash_lookup, hash_put):
10781 Adjust signatures to match updated version of code.
10782 (consing_since_gc): Now EMACS_INT, since a single hash table can
10783 use more than INT_MAX bytes.
10784
698d32e2
DN
107852011-06-01 Dan Nicolaescu <dann@ics.uci.edu>
10786
10787 Make it possible to build with GCC-4.6+ -O2 -flto.
10788
10789 * emacs.c (__malloc_initialize_hook): Mark as EXTERNALLY_VISIBLE.
10790
fd6fa53f
SM
107912011-06-01 Stefan Monnier <monnier@iro.umontreal.ca>
10792
10793 * minibuf.c (get_minibuffer, read_minibuf_unwind):
10794 Call minibuffer-inactive-mode.
10795
864db017
JB
107962011-05-31 Juanma Barranquero <lekktu@gmail.com>
10797
10798 * makefile.w32-in ($(BLD)/data.$(O), $(BLD)/editfns.$(O)):
10799 Update dependencies.
10800
2ad0baf4
DN
108012011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
10802
10803 * data.c (init_data): Remove code for UTS, this system is not
10804 supported anymore.
10805
4fcc2638
DN
108062011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
10807
10808 Don't force ./temacs to start in terminal mode.
10809
10810 * frame.c (make_initial_frame): Initialize faces in all cases, not
10811 only when CANNOT_DUMP is defined.
10812 * dispnew.c (init_display): Remove CANNOT_DUMP condition.
10813
c56e0fd5
DN
108142011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
10815
10816 * dispnew.c (add_window_display_history): Use const for the string
10817 pointer. Remove declaration, not needed.
10818
333d54da 108192011-05-31 Paul Eggert <eggert@cs.ucla.edu>
9cf9f756 10820
55d4c1b2 10821 Use 'inline', not 'INLINE'.
333d54da 10822 <http://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00914.html>
55d4c1b2
PE
10823 * alloc.c, fontset.c (INLINE): Remove.
10824 * alloc.c, bidi.c, charset.c, coding.c, dispnew.c, fns.c, image.c:
10825 * intervals.c, keyboard.c, process.c, syntax.c, textprop.c, w32term.c:
10826 * xdisp.c, xfaces.c, xterm.c: Replace all uses of INLINE with inline.
10827 * gmalloc.c (register_heapinfo): Use inline unconditionally.
10828 * lisp.h (LISP_MAKE_RVALUE): Use inline, not __inline__.
10829
738db178
DN
108302011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
10831
10832 Make it possible to run ./temacs.
10833
10834 * callproc.c (set_initial_environment): Remove CANNOT_DUMP code,
10835 syms_of_callproc does the same thing. Remove test for
10836 "initialized", do it in the caller.
10837 * emacs.c (main): Avoid calling set_initial_environment when dumping.
10838
620c53a6
SM
108392011-05-31 Stefan Monnier <monnier@iro.umontreal.ca>
10840
10841 * minibuf.c (Finternal_complete_buffer): Return `category' metadata.
10842 (read_minibuf): Use get_minibuffer.
10843 (syms_of_minibuf): Use DEFSYM.
10844 (Qmetadata): New var.
10845 * data.c (Qbuffer): Don't make it static.
10846 (syms_of_data): Use DEFSYM.
10847
e003a292
PE
108482011-05-31 Paul Eggert <eggert@cs.ucla.edu>
10849
10850 * ccl.c (CCL_CODE_RANGE): Allow negative numbers. (Bug#8751)
10851 (CCL_CODE_MIN): New macro.
10852
ed008a6d
PE
108532011-05-30 Paul Eggert <eggert@cs.ucla.edu>
10854
3687c2ef
PE
10855 * alloc.c (lisp_align_malloc): Omit unnecessary val==NULL tests.
10856
ed008a6d
PE
10857 * eval.c (Qdebug): Now static.
10858 * lisp.h (Qdebug): Remove decl. This reverts a part of the
10859 2011-04-26T11:26:05Z!dan.colascione@gmail.com that inadvertently undid part of
10860 2011-04-14T06:48:41Z!eggert@cs.ucla.edu.
10861
d66c4c7c
CY
108622011-05-29 Chong Yidong <cyd@stupidchicken.com>
10863
10864 * image.c: Various fixes to ImageMagick code comments.
10865 (Fimagemagick_types): Doc fix.
10866
5fbc2025
PE
108672011-05-29 Paul Eggert <eggert@cs.ucla.edu>
10868
0196f88a
PE
10869 Minor fixes prompted by GCC 4.6.0 warnings.
10870
10871 * xselect.c (converted_selections, conversion_fail_tag): Now static.
10872
5fbc2025
PE
10873 * emacs.c [HAVE_X_WINDOWS]: Include "xterm.h".
10874 (x_clipboard_manager_save_all): Move extern decl to ...
10875 * xterm.h: ... here, so that it can be checked for consistency.
10876
1dd3c2d9
CY
108772011-05-29 Chong Yidong <cyd@stupidchicken.com>
10878
10879 * xselect.c (x_clipboard_manager_save_frame)
10880 (x_clipboard_manager_save_all): New functions.
10881 (Fx_clipboard_manager_save): Lisp function deleted.
10882
10883 * emacs.c (Fkill_emacs): Call x_clipboard_manager_save_all.
10884 * frame.c (delete_frame): Call x_clipboard_manager_save_frame.
10885
10886 * xterm.h: Update prototype.
10887
5ba6571d
WX
108882011-05-28 William Xu <william.xwl@gmail.com>
10889
10890 * nsterm.m (ns_term_shutdown): Synchronize user defaults before
10891 exiting (Bug#8239).
10892
3eaff834
JM
108932011-05-28 Jim Meyering <meyering@redhat.com>
10894
e1900994 10895 Avoid a sign-extension bug in crypto_hash_function.
3eaff834
JM
10896 * fns.c (to_uchar): Define.
10897 (crypto_hash_function): Use it to convert some newly-signed
10898 variables to unsigned, to avoid sign-extension bugs. For example,
10899 without this change, (md5 "truc") would evaluate to
10900 45723a2aff78ff4fff7fff1114760e62 rather than the expected
10901 45723a2af3788c4ff17f8d1114760e62. Reported by Antoine Levitt in
e1900994 10902 https://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00883.html.
3eaff834 10903
0f6990a7
PE
109042011-05-27 Paul Eggert <eggert@cs.ucla.edu>
10905
10906 Integer overflow fixes.
c8a9ca5a 10907
08686060
PE
10908 * dbusbind.c: Serial number integer overflow fixes.
10909 (CHECK_DBUS_SERIAL_GET_SERIAL): New macro.
08686060
PE
10910 (Fdbus_call_method_asynchronously, xd_read_message_1): Use a float
10911 to hold a serial number that is too large for a fixnum.
10912 (Fdbus_method_return_internal, Fdbus_method_error_internal):
10913 Check for serial numbers out of range. Decode any serial number
59568bf0 10914 that was so large that it became a float. (Bug#8722)
08686060 10915
2d1fc3c7
PE
10916 * dbusbind.c: Use XFASTINT rather than XUINT, and check for nonneg.
10917 (Fdbus_call_method, Fdbus_call_method_asynchronously):
10918 Use XFASTINT rather than XUINT when numbers are nonnegative.
10919 (xd_append_arg, Fdbus_method_return_internal):
10920 (Fdbus_method_error_internal): Likewise. Also, for unsigned
10921 arguments, check that Lisp number is nonnegative, rather than
59568bf0 10922 silently wrapping negative numbers around. (Bug#8722)
30217ff0 10923 (xd_read_message_1): Don't assume dbus_uint32_t can fit in int.
59568bf0 10924 (Bug#8722)
2d1fc3c7 10925
c8a9ca5a
PE
10926 * data.c (arith_driver, Flsh): Avoid unnecessary casts to EMACS_UINT.
10927
519e1d69
PE
10928 * ccl.c (ccl_driver): Redo slightly to avoid the need for 'unsigned'.
10929
6df6ae42 10930 ccl: Add integer overflow checks.
30569699
PE
10931 * ccl.c (CCL_CODE_MAX, GET_CCL_RANGE, GET_CCL_CODE, GET_CCL_INT):
10932 (IN_INT_RANGE): New macros.
10933 (ccl_driver): Use them to check for integer overflow when
10934 decoding a CCL program. Many of the new checks are whether XINT (x)
10935 fits in int; it doesn't always, on 64-bit hosts. The new version
10936 doesn't catch all possible integer overflows, but it's an
847044ea 10937 improvement. (Bug#8719)
30569699 10938
c11285dc
PE
10939 * alloc.c (make_event_array): Use XINT, not XUINT.
10940 There's no need for unsigned here.
10941
fdccd48e
PE
10942 * mem-limits.h (EXCEEDS_LISP_PTR) [!USE_LSB_TAG]: EMACS_UINT -> uintptr_t
10943 This follows up to the 2011-05-06 change that substituted uintptr_t
10944 for EMACS_INT. This case wasn't caught back then.
10945
37910ab2
PE
10946 Rework Fformat to avoid integer overflow issues.
10947 * editfns.c: Include <float.h> unconditionally, as it's everywhere
10948 now (part of C89). Include <verify.h>.
10949 (MAX_10_EXP, CONVERTED_BYTE_SIZE): Remove; no longer needed.
10950 (pWIDE, pWIDElen, signed_wide, unsigned_wide): New defns.
10951 (Fformat): Avoid the prepass trying to compute sizes; it was only
10952 approximate and thus did not catch overflow reliably. Instead, walk
10953 through the format just once, formatting and computing sizes as we go,
10954 checking for integer overflow at every step, and allocating a larger
10955 buffer as needed. Keep track separately whether the format is
10956 multibyte. Keep only the most-recently calculated precision, rather
10957 than them all. Record whether each argument has been converted to
10958 string. Use EMACS_INT, not int, for byte and char and arg counts.
10959 Support field widths and precisions larger than INT_MAX. Avoid
10960 sprintf's undefined behavior with conversion specifications such as %#d
10961 and %.0c. Fix bug with strchr succeeding on '\0' when looking for
10962 flags. Fix bug with (format "%c" 256.0). Avoid integer overflow when
10963 formatting out-of-range floating point numbers with int
9173deec 10964 formats. (Bug#8668)
37910ab2 10965
2e6578fb
PE
10966 * lisp.h (FIXNUM_OVERFLOW_P): Work even if arg is a NaN.
10967
0ae6bdee
PE
10968 * data.c: Avoid integer truncation in expressions involving floats.
10969 * data.c: Include <intprops.h>.
10970 (arith_driver): When there's an integer overflow in an expression
10971 involving floating point, convert the integers to floating point
10972 so that the resulting value does not suffer from catastrophic
10973 integer truncation. For example, on a 64-bit host (* 4
10974 most-negative-fixnum 0.5) should yield about -4.6e+18, not zero.
10975 Do not rely on undefined behavior after integer overflow.
10976
de883a70
PE
10977 merge count_size_as_multibyte, parse_str_to_multibyte
10978 * character.c, character.h (count_size_as_multibyte):
fd6fa53f 10979 Rename from parse_str_to_multibyte; all uses changed.
de883a70
PE
10980 Check for integer overflow.
10981 * insdel.c, lisp.h (count_size_as_multibyte): Remove,
10982 since it's now a duplicate of the other. This is more of
10983 a character than a buffer op, so better that it's in character.c.
10984 * fns.c, print.c: Adjust to above changes.
10985
2ff916cb
PE
109862011-05-27 Stefan Monnier <monnier@iro.umontreal.ca>
10987
10988 * xselect.c (x_convert_selection): Yet another int/Lisp_Object mixup.
10989
f1b54466
PE
109902011-05-27 Paul Eggert <eggert@cs.ucla.edu>
10991
fb1ac845
PE
10992 * xselect.c: Fix minor problems prompted by GCC 4.6.0 warnings.
10993 (x_handle_selection_request, frame_for_x_selection): Remove unused vars.
10994 (x_clipboard_manager_save): Now static.
10995 (Fx_clipboard_manager_save): Rename local to avoid shadowing.
10996
f1b54466
PE
10997 * fns.c: Fix minor problems prompted by GCC 4.6.0 warnings.
10998 (crypto_hash_function): Now static.
10999 Fix pointer signedness problems. Avoid unnecessary initializations.
11000
a9f737ee
CY
110012011-05-27 Chong Yidong <cyd@stupidchicken.com>
11002
11003 * termhooks.h (Vselection_alist): Make it terminal-local.
11004
11005 * terminal.c (create_terminal): Initialize it.
11006
11007 * xselect.c: Support for clipboard managers.
11008 (Vselection_alist): Move to termhooks.h as terminal-local var.
11009 (LOCAL_SELECTION): New macro.
11010 (x_atom_to_symbol): Handle x_display_info_for_display fail case.
11011 (symbol_to_x_atom): Remove gratuitous arg.
11012 (x_handle_selection_request, lisp_data_to_selection_data)
11013 (x_get_foreign_selection, Fx_register_dnd_atom): Callers changed.
620c53a6
SM
11014 (x_own_selection, x_get_local_selection, x_convert_selection):
11015 New arg, specifying work frame. Use terminal-local Vselection_alist.
a9f737ee
CY
11016 (some_frame_on_display): Delete unused function.
11017 (Fx_own_selection_internal, Fx_get_selection_internal)
11018 (Fx_disown_selection_internal, Fx_selection_owner_p)
11019 (Fx_selection_exists_p): New optional frame arg.
11020 (frame_for_x_selection, Fx_clipboard_manager_save): New functions.
11021 (x_handle_selection_clear): Don't treat other terminals with the
11022 same keyboard specially. Use the terminal-local Vselection_alist.
11023 (x_clear_frame_selections): Use Frun_hook_with_args.
11024
11025 * xterm.c (x_term_init): Intern ATOM and CLIPBOARD_MANAGER atoms.
11026
11027 * xterm.h: Add support for those atoms.
11028
e067f0c1
CY
110292011-05-26 Chong Yidong <cyd@stupidchicken.com>
11030
11031 * xselect.c: ICCCM-compliant handling of MULTIPLE targets.
11032 (converted_selections, conversion_fail_tag): New global variables.
11033 (x_selection_request_lisp_error): Free the above.
11034 (x_get_local_selection): Remove unnecessary code.
11035 (x_reply_selection_request): Args changed; handle arbitrary array
620c53a6
SM
11036 of converted selections stored in converted_selections.
11037 Separate the XChangeProperty and SelectionNotify steps.
e067f0c1
CY
11038 (x_handle_selection_request): Rewrite to handle MULTIPLE target.
11039 (x_convert_selection): New function.
11040 (x_handle_selection_event): Simplify.
11041 (x_get_foreign_selection): Don't ignore incoming requests while
11042 waiting for an answer; this will fail when we implement
11043 SAVE_TARGETS, and seems unnecessary anyway.
11044 (selection_data_to_lisp_data): Recognize ATOM_PAIR type.
11045 (Vx_sent_selection_functions): Doc fix.
11046
0f4aebc0
LL
110472011-05-26 Leo Liu <sdl.web@gmail.com>
11048
11049 * editfns.c (Ftranspose_regions): Allow empty regions. (Bug#8699)
11050
e61124cd
YM
110512011-05-25 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
11052
11053 * dispextern.h (struct glyph_row): New member fringe_bitmap_periodic_p.
11054
11055 * dispnew.c (shift_glyph_matrix, scrolling_window): Mark scrolled row
11056 for fringe update if it has periodic bitmap.
ac389d0c 11057 (row_equal_p): Also compare left_fringe_offset, right_fringe_offset,
e61124cd
YM
11058 and fringe_bitmap_periodic_p.
11059
11060 * fringe.c (get_fringe_bitmap_data): New function.
11061 (draw_fringe_bitmap_1, update_window_fringes): Use it.
11062 (update_window_fringes): Record periodicity of fringe bitmap in glyph
11063 row. Mark glyph row for fringe update if periodicity changed.
11064
11065 * xdisp.c (try_window_reusing_current_matrix): Don't mark scrolled row
11066 for fringe update unless it has periodic bitmap.
11067
f16d9837
KH
110682011-05-25 Kenichi Handa <handa@m17n.org>
11069
11070 * xdisp.c (get_next_display_element): Set correct it->face_id for
11071 a static composition.
11072
e1b90ef6
LL
110732011-05-24 Leo Liu <sdl.web@gmail.com>
11074
11075 * deps.mk (fns.o):
11076 * makefile.w32-in ($(BLD)/fns.$(O)): Include sha1.h.
11077
11078 * fns.c (crypto_hash_function, Fsha1): New function.
11079 (Fmd5): Use crypto_hash_function.
11080 (syms_of_fns): Add Ssha1.
11081
7400048f
PE
110822011-05-22 Paul Eggert <eggert@cs.ucla.edu>
11083
11084 * gnutls.c: Remove unused macros.
11085 (fn_gnutls_transport_set_lowat, fn_gnutls_transport_set_pull_function):
11086 (fn_gnutls_transport_set_push_function) [!WINDOWSNT]:
11087 Remove macros that are defined and never used.
11088 Caught by gcc -Wunused-macros (GCC 4.6.0, Fedora 14).
11089
abb71cf4
CY
110902011-05-22 Chong Yidong <cyd@stupidchicken.com>
11091
11092 * xselect.c (syms_of_xselect): Remove unused symbol SAVE_TARGETS.
11093 (Fx_get_selection_internal): Minor cleanup.
11094 (Fx_own_selection_internal): Rename arguments for consistency with
11095 select.el.
11096
6307db39
PE
110972011-05-22 Paul Eggert <eggert@cs.ucla.edu>
11098
11099 * xselect.c (QSAVE_TARGETS): New static var, to fix build failure.
11100
f3d4e0a4
CY
111012011-05-22 Chong Yidong <cyd@stupidchicken.com>
11102
11103 * xselect.c (syms_of_xselect): Include character.h; use DEFSYM.
11104
4d8ade89
YM
111052011-05-21 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
11106
11107 * dispnew.c (scrolling_window): Don't exclude the case that the
11108 last enabled row in the desired matrix touches the bottom boundary.
11109
32078c8d
GM
111102011-05-21 Glenn Morris <rgm@gnu.org>
11111
11112 * Makefile.in ($(etc)/DOC): Make second command line even shorter.
33cf345f
GM
11113 (SOME_MACHINE_OBJECTS): Replace FONT_OBJ by its maximal expansion,
11114 and add some more files.
32078c8d 11115
7285dc67
EZ
111162011-05-20 Eli Zaretskii <eliz@gnu.org>
11117
11118 * callproc.c (Fcall_process) [MSDOS]: Fix arguments to
11119 report_file_error introduced by the change from 2011-05-07.
11120
89d1bd22
PE
111212011-05-20 Paul Eggert <eggert@cs.ucla.edu>
11122
11123 * systime.h (Time): Define only if emacs is defined.
11124 This is to allow ../lib-src/profile.c to be compiled on FreeBSD,
11125 where the include path doesn't have X11/X.h by default. See
11126 <http://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00561.html>.
11127
cd394be1 111282011-05-20 Kenichi Handa <handa@m17n.org>
31bfc35c
KH
11129
11130 * composite.c (find_automatic_composition): Fix previous change.
11131
b9704ad9
GM
111322011-05-20 Glenn Morris <rgm@gnu.org>
11133
11134 * lisp.mk: New file, split from Makefile.in.
11135 * Makefile.in (lisp): Move to separate file, inserted by @lisp_frag@.
11136 (shortlisp): Remove.
11137 ($(etc)/DOC): Edit lisp.mk rather than using $shortlisp.
11138
4a720484
GM
111392011-05-19 Glenn Morris <rgm@gnu.org>
11140
11141 * Makefile.in (MSDOS_SUPPORT_REAL, MSDOS_SUPPORT, NS_SUPPORT)
11142 (REAL_MOUSE_SUPPORT, GPM_MOUSE_SUPPORT, MOUSE_SUPPORT, TOOLTIP_SUPPORT)
11143 (BASE_WINDOW_SUPPORT, X_WINDOW_SUPPORT, WINDOW_SUPPORT): Remove.
11144 (lisp): Set the order to that of loadup.el.
11145 (shortlisp): Make it a copy of $lisp.
11146 (SOME_MACHINE_LISP): Remove.
11147 ($(etc)/DOC): Depend just on $lisp, not $SOME_MACHINE_LISP too.
11148 Use just $shortlisp, not $SOME_MACHINE_LISP too.
11149
a28d4396
KH
111502011-05-18 Kenichi Handa <handa@m17n.org>
11151
11152 * composite.c (CHAR_COMPOSABLE_P): Add more check for efficiency.
11153 (BACKWARD_CHAR): Wrap the arg STOP by parenthesis.
11154 (find_automatic_composition): Mostly rewrite for efficiency.
11155
a2b1fa8e
JB
111562011-05-18 Juanma Barranquero <lekktu@gmail.com>
11157
11158 * makefile.w32-in: Update dependencies.
11159
8e1f5610
CS
111602011-05-18 Christoph Scholtes <cschol2112@googlemail.com>
11161
11162 * menu.c: Include limits.h (fixes the MS-Windows build broken by
7d7d0045 11163 2011-06-18T18:49:19Z!cyd@stupidchicken.com).
8e1f5610 11164
7025ee00 111652011-05-18 Paul Eggert <eggert@cs.ucla.edu>
cb93f9be 11166
cdfa6eab
PE
11167 Fix some integer overflow issues, such as string length overflow.
11168
06d6db33
PE
11169 * insdel.c (count_size_as_multibyte): Check for string overflow.
11170
2b4560a8
PE
11171 * character.c (lisp_string_width): Check for string overflow.
11172 Use EMACS_INT, not int, for string indexes and lengths; in
11173 particular, 2nd arg is now EMACS_INT, not int. Do not crash if
11174 the resulting string length overflows an EMACS_INT; instead,
11175 report a string overflow if no precision given. When checking for
11176 precision exhaustion, use a check that cannot possibly have
11177 integer overflow. (Bug#8675)
11178 * character.h (lisp_string_width): Adjust to new signature.
11179
cb93f9be
PE
11180 * alloc.c (string_overflow): New function.
11181 (Fmake_string): Use it. This doesn't change behavior, but saves
11182 a few bytes and will simplify future changes.
11183 * character.c (string_escape_byte8): Likewise.
11184 * lisp.h (string_overflow): New decl.
11185
1a1f3366
PE
11186 Fixups, following up to the user-interface timestamp change.
11187 * nsterm.m (last_mouse_movement_time, ns_mouse_position): Use Time
11188 for UI timestamps, instead of unsigned long.
9fbd6841
PE
11189 * msdos.c (mouse_get_pos): Likewise.
11190 * w32inevt.c (movement_time, w32_console_mouse_position): Likewise.
1a1f3366
PE
11191 * w32gui.h (Time): Define by including "systime.h" rather than by
11192 declaring it ourselves. (Bug#8664)
11193
d4e3e4d3
PE
11194 * dispextern.h (struct image): Don't assume time_t <= unsigned long.
11195 * image.c (clear_image_cache): Likewise.
11196
f6a24d19
PE
11197 * term.c (term_mouse_position): Don't assume time_t wraparound.
11198
08dc5ae6
PE
11199 Be more systematic about user-interface timestamps.
11200 Before, the code sometimes used 'Time', sometimes 'unsigned long',
620c53a6
SM
11201 and sometimes 'EMACS_UINT', to represent these timestamps.
11202 This change causes it to use 'Time' uniformly, as that's what X uses.
08dc5ae6
PE
11203 This makes the code easier to follow, and makes it easier to catch
11204 integer overflow bugs such as Bug#8664.
11205 * frame.c (Fmouse_position, Fmouse_pixel_position):
11206 Use Time, not unsigned long, for user-interface timestamps.
11207 * keyboard.c (last_event_timestamp, kbd_buffer_get_event): Likewise.
11208 (button_down_time, make_lispy_position, make_lispy_movement): Likewise.
11209 * keyboard.h (last_event_timestamp): Likewise.
11210 * menu.c (Fx_popup_menu) [!HAVE_X_WINDOWS]: Likewise.
11211 * menu.h (xmenu_show): Likewise.
11212 * term.c (term_mouse_position): Likewise.
11213 * termhooks.h (struct input_event.timestamp): Likewise.
11214 (struct terminal.mouse_position_hook): Likewise.
11215 * xmenu.c (create_and_show_popup_menu, xmenu_show): Likewise.
11216 * xterm.c (XTmouse_position, x_scroll_bar_report_motion): Likewise.
11217 * systime.h (Time): New decl. Pull it in from <X11/X.h> if
11218 HAVE_X_WINDOWS, otherwise define it as unsigned long, which is
11219 what it was before.
11220 * menu.h, termhooks.h: Include "systime.h", for Time.
11221
8e55734a
PE
11222 * keyboard.c (make_lispy_event): Fix problem in integer overflow.
11223 Don't assume that the difference between two unsigned long values
11224 can fit into an integer. At this point, we know button_down_time
11225 <= event->timestamp, so the difference must be nonnegative, so
11226 there's no need to cast the result if double-click-time is
11227 nonnegative, as it should be; check that it's nonnegative, just in
11228 case. This bug is triggered when events are more than 2**31 ms
86db42d2 11229 apart (about 25 days). (Bug#8664)
8e55734a 11230
841f1b75 11231 * xselect.c (last_event_timestamp): Remove duplicate decl.
6434756c 11232 (x_own_selection): Remove needless cast to unsigned long.
841f1b75 11233
3e26f69c
PE
11234 * xmenu.c (set_frame_menubar): Use int, not EMACS_UINT, for indexes
11235 that always fit in int. Use a sentinel instead of a counter, to
11236 avoid a temp and to allay GCC's concerns about possible int overflow.
d230cb74
PE
11237 * frame.h (struct frame): Use int for menu_bar_items_used
11238 instead of EMACS_INT, since it always fits in int.
3e26f69c 11239
5cc152c0
PE
11240 * menu.c (grow_menu_items): Check for int overflow.
11241
d89eb65e
PE
11242 * xmenu.c (set_frame_menubar): Don't mishandle vectors with no nils.
11243
5235bd3e
PE
11244 * xterm.c: Use EMACS_INT for Emacs modifiers, and int for X modifiers.
11245 Before, the code was not consistent. These values cannot exceed
11246 2**31 - 1 so there's no need to make them unsigned.
11247 (x_x_to_emacs_modifiers): Accept int and return EMACS_INT.
11248 (x_emacs_to_x_modifiers): Accept EMACS_INT and return int.
11249 (x_x_to_emacs_modifiers, x_emacs_to_x_modifiers): Reject non-integers
11250 as modifiers.
11251 * xterm.h (x_x_to_emacs_modifiers): Adjust to signature change.
11252
bc827e23
PE
11253 * lisp.h (XINT) [USE_LISP_UNION_TYPE]: Cast to EMACS_INT.
11254 (XUINT) [USE_LISP_UNION_TYPE]: Cast to EMACS_UINT.
11255 Otherwise, GCC 4.6.0 warns about printf (pI, XINT (...)),
11256 presumably because the widths might not match.
11257
78eb494e
PE
11258 * window.c (size_window): Avoid needless test at loop start.
11259
04f2d78b
CB
112602011-05-18 Courtney Bane <emacs-bugs-7626@cbane.org> (tiny change)
11261
11262 * term.c (Fresume_tty): Restore hooks before reinitializing (bug#8687).
11263
d2fc7e3d 112642011-05-12 Drew Adams <drew.adams@oracle.com>
e531bdff
DA
11265
11266 * textprop.c (Fprevious_single_char_property_change): Doc fix (bug#8655).
11267
d2fc7e3d 112682011-05-12 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
7db47798
YM
11269
11270 * w32term.c (w32_draw_fringe_bitmap): Rename local vars `left' and
11271 `width' to `bar_area_x' and `bar_area_width', respectively.
11272 (x_scroll_run): Take account of fringe background extension.
11273
04f2d78b
CB
11274 * xterm.c (x_draw_fringe_bitmap) [USE_TOOLKIT_SCROLL_BARS]:
11275 Rename local vars `left' and `width' to `bar_area_x' and
7db47798
YM
11276 `bar_area_width', respectively.
11277 (x_scroll_run) [USE_TOOLKIT_SCROLL_BARS]: Take account of fringe
11278 background extension.
11279
79b70037
GM
112802011-05-10 Jim Meyering <meyering@redhat.com>
11281
11282 * xdisp.c (x_intersect_rectangles): Fix typo "the the -> the".
11283
2f142cc5
JB
112842011-05-10 Juanma Barranquero <lekktu@gmail.com>
11285
11286 * image.c (Finit_image_library): Return t for built-in image types,
11287 like pbm and xbm. (Bug#8640)
11288
57679c86
AS
112892011-05-09 Andreas Schwab <schwab@linux-m68k.org>
11290
11291 * w32menu.c (set_frame_menubar): Fix submenu allocation.
11292
888c9e86
EZ
112932011-05-07 Eli Zaretskii <eliz@gnu.org>
11294
b0512a1d
EZ
11295 * w32console.c (Fset_screen_color): Doc fix.
11296 (Fget_screen_color): New function.
11297 (syms_of_ntterm): Defsubr it.
11298
7285dc67
EZ
11299 * callproc.c (call_process_cleanup) [MSDOS]: Don't close and
11300 unlink the temporary file if Fcall_process didn't create it in the
11301 first place.
11302 (Fcall_process) [MSDOS]: Don't create tempfile if stdout of the
11303 child process will be redirected to a file specified with `:file'.
888c9e86
EZ
11304 Don't try to re-open tempfile in that case, and set fd[0] to -1 as
11305 cue to call_process_cleanup not to close that handle.
11306
4d3fcc8e
BK
113072011-05-07 Ben Key <bkey76@gmail.com>
11308
11309 * makefile.w32-in: The bootstrap-temacs rule now makes use of
11310 one of two shell specific rules, either bootstrap-temacs-CMD or
11311 bootstrap-temacs-SH. The bootstrap-temacs-SH rule is identical
11312 to the previous implementation of the bootstrap-temacs rule.
11313 The bootstrap-temacs-CMD rule is similar to the previous
11314 implementation of the bootstrap-temacs rule except that it
11315 makes use of the ESC_CFLAGS variable instead of the CFLAGS
11316 variable.
11317
11318 These changes, along with some changes to nt/configure.bat,
11319 nt/gmake.defs, and nt/nmake.defs, are required to extend my
11320 earlier fix to add support for --cflags and --ldflags options
11321 that include quotes so that it works whether make uses cmd or
11322 sh as the shell.
11323
b4289b64
MA
113242011-05-06 Michael Albinus <michael.albinus@gmx.de>
11325
11326 * dbusbind.c (QCdbus_type_unix_fd): Declare static.
11327 (xd_remove_watch): Don't check QCdbus_type_unix_fd for SYMBOLP, it
11328 is a constant.
11329 (Fdbus_init_bus, xd_read_queued_messages): Bus can be a symbol or
11330 a string. Handle both cases.
11331 (Fdbus_call_method_asynchronously, Fdbus_register_signal)
11332 (Fdbus_register_method): Use Qinvalid_function.
11333
af4c0e28
JB
113342011-05-06 Juanma Barranquero <lekktu@gmail.com>
11335
11336 * makefile.w32-in: Update dependencies.
11337 (LISP_H): Add inttypes.h and stdin.h.
11338 (PROCESS_H): Add unistd.h.
11339
c51453d9
EZ
113402011-05-06 Eli Zaretskii <eliz@gnu.org>
11341
11342 * lread.c: Include limits.h (fixes the MS-Windows build broken by
11343 2011-05-06T07:13:19Z!eggert@cs.ucla.edu).
11344
8ff0ac3c 113452011-05-06 Paul Eggert <eggert@cs.ucla.edu>
c032b5f8 11346
4c4b566b
PE
11347 * image.c (Finit_image_library) [!HAVE_NTGUI]: Omit unused local.
11348
aab2b9b5
PE
11349 * term.c (vfatal): Remove stray call to va_end.
11350 It's not needed and the C Standard doesn't allow it here anyway.
11351
c378da0b
PE
11352 Use C99's va_copy to avoid undefined behavior on x86-64 GNU/Linux.
11353 * eval.c (verror): doprnt a copy of ap, not the original. (Bug#8545)
11354
288b08c7
PE
11355 * eval.c (verror): OK to create a string of up to MOST_POSITIVE_FIXNUM
11356 bytes.
11357
e3601888
PE
11358 * term.c: Don't include <stdarg.h>, as <lisp.h> does that.
11359
db6c0e74
PE
11360 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork clobbering.
11361
dd5963ea
PE
11362 * process.c (Fformat_network_address): Fix typo: args2 -> *args2.
11363
88c9450f
PE
11364 * xmenu.c (set_frame_menubar): Fix typo: int * -> int (3 times).
11365
2f9442b8
PE
11366 * coding.c (detect_coding_charset): Fix typo: * 2 -> *4 (Bug#8601).
11367
c032b5f8
PE
11368 * charset.h (struct charset.code_space): Now has 15 elements, not 16.
11369 * charset.c (Fdefine_charset_internal): Don't initialize
11370 charset.code_space[15]. The value was garbage, on hosts with
2d38271b 11371 32-bit int (Bug#8600).
a108c10b
PE
11372
11373 * lread.c (read_integer): Be more consistent with string-to-number.
11374 Use string_to_number to do the actual conversion; this avoids
11375 rounding errors and fixes some other screwups. Without this fix,
11376 for example, #x1fffffffffffffff was misread as -2305843009213693952.
11377 (digit_to_number): Move earlier, for benefit of read_integer.
11378 Return -1 if the digit is out of range for the base, -2 if it is
48e400f0 11379 not a digit in any supported base. (Bug#8602)
a108c10b 11380
ad5f9eea
PE
11381 * doprnt.c (doprnt): Support arbitrary pI values, such as "I64".
11382
aec1708a
PE
11383 * dispnew.c (scrolling_window): Return 1 if we scrolled,
11384 to match comment at start of function. This also removes a
11385 GCC warning about overflow in a 32+64-bit port.
11386
47be4ab5
PE
11387 * lisp.h (EMACS_INT, EMACS_UINT, BITS_PER_EMACS_INT, pI): Simplify.
11388
371cac43
PE
11389 * dbusbind.c: Do not use XPNTR on a value that may be an integer.
11390 Reported by Stefan Monnier in
11391 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00919.html>.
04f2d78b
CB
11392 (xd_remove_watch, Fdbus_init_bus, xd_read_queued_messages):
11393 Use SYMBOLP-guarded XSYMBOL, not XPNTR.
371cac43 11394
d01a7826
PE
11395 * lisp.h (EMACS_INTPTR): Remove. All uses changed to intptr_t.
11396 (EMACS_UINTPTR): Likewise, with uintptr_t.
11397
7fd47d5c
PE
11398 * lisp.h: Prefer 64-bit EMACS_INT if available.
11399 (EMACS_INT, EMACS_UINT, BITS_PER_EMACS_INT, pI): Define to 64-bit
11400 on 32-bit hosts that have 64-bit int, so that they can access
11401 large files.
122b0c86
PE
11402 However, temporarily disable this change unless the temporary
11403 symbol WIDE_EMACS_INT is defined.
7fd47d5c 11404
8727937b
PE
11405 * lread.c, process.c: Do not include <inttypes.h>; lisp.h does it now.
11406
8ac068ac
PE
11407 Prefer intptr_t/uintptr_t for integers the same widths as pointers.
11408 This removes an assumption that EMACS_INT and long are the same
11409 width as pointers. The assumption is true for Emacs porting targets
11410 now, but we want to make other targets possible.
11411 * lisp.h: Include <inttypes.h>, for INTPTR_MAX, UINTPTR_MAX.
11412 (EMACS_INTPTR, EMACS_UINTPTR): New macros.
11413 In the rest of the code, change types of integers that hold casted
11414 pointers to EMACS_INTPTR and EMACS_UINTPTR, systematically
11415 replacing EMACS_INT, long, EMACS_UINT, and unsigned long.
11416 (XTYPE): Don't cast arg to EMACS_UINT; normally is not needed.
11417 (XSET): Cast type of XTYPE arg to EMACS_INTPTR; it is needed here.
11418 No need to cast type when ORing.
11419 (XPNTR): Return a value of type EMACS_INTPTR or EMACS_UINTPTR.
11420 * alloc.c (lisp_align_malloc): Remove a no-longer-needed cast.
11421 * doc.c (store_function_docstring): Use EMACS_INTPTR, so as not to
11422 assume EMACS_INT is the same width as char *.
11423 * gtkutil.c (xg_gtk_scroll_destroy, xg_tool_bar_button_cb):
11424 (xg_tool_bar_callback, xg_tool_bar_help_callback, xg_make_tool_item):
11425 Remove no-longer-needed casts.
11426 (xg_create_scroll_bar, xg_tool_bar_button_cb, xg_tool_bar_callback):
11427 (xg_tool_bar_help_callback, xg_make_tool_item):
11428 Use EMACS_INTPTR to hold an integer
11429 that will be cast to void *; this can avoid a GCC warning
11430 if EMACS_INT is not the same width as void *.
11431 * menu.c (find_and_call_menu_selection): Remove no-longer-needed cast.
11432 * xdisp.c (display_echo_area_1, resize_mini_window_1):
11433 (current_message_1, set_message_1):
11434 Use a local to convert to proper width without a cast.
11435 * xmenu.c (dialog_selection_callback): Likewise.
11436
ede49d71
PE
11437 * sysdep.c (get_random): Don't assume EMACS_INT is no wider than long.
11438 Also, don't assume VALBITS / RAND_BITS is less than 5,
11439 and don't rely on undefined behavior when shifting a 1 left into
11440 the sign bit.
11441 * lisp.h (get_random): Change signature to match.
11442
2f30ecd0
PE
11443 * lread.c (hash_string): Use size_t, not int, for hash computation.
11444 Normally we prefer signed values; but hashing is special, because
11445 it's better to use unsigned division on hash table sizes so that
11446 the remainder is nonnegative. Also, size_t is the natural width
11447 for hashing into memory. The previous code used 'int', which doesn't
11448 retain enough info to hash well into very large tables.
11449 (oblookup, oblookup_last_bucket_number, Funintern): Likewise.
11450
2a866e7b
PE
11451 * dbusbind.c: Don't possibly lose pointer info when converting.
11452 (xd_remove_watch, Fdbus_init_bus, xd_read_queued_messages):
11453 Use XPNTR rather than XHASH, so that the high-order bits of
11454 the pointer aren't lost when converting through void *.
11455
51639eac
PE
11456 * eval.c (Fautoload): Don't double-shift a pointer.
11457
92394119
PE
11458 * fns.c (Frandom): Let EMACS_UINT be wider than unsigned long.
11459
dbdb9a7c
JB
114602011-05-06 Juanma Barranquero <lekktu@gmail.com>
11461
11462 * gnutls.c (DEF_GNUTLS_FN):
11463 * image.c (DEF_IMGLIB_FN): Make function pointers static.
11464
db7a0b4f
AS
114652011-05-05 Andreas Schwab <schwab@linux-m68k.org>
11466
11467 * lread.c (lisp_file_lexically_bound_p): Stop scanning at end
11468 marker. (Bug#8610)
11469
cd394be1 114702011-05-05 Eli Zaretskii <eliz@gnu.org>
fab624aa
EZ
11471
11472 * w32heap.c (allocate_heap) [USE_LISP_UNION_TYPE || USE_LSB_TAG]:
11473 New version that can reserve upto 2GB of heap space.
11474
f7ff1b0f 114752011-05-05 Chong Yidong <cyd@stupidchicken.com>
45cb8994
CY
11476
11477 * nsfns.m (Fns_read_file_name): Doc fix (Bug#8534).
11478
639c109b
TZ
114792011-05-05 Teodor Zlatanov <tzz@lifelogs.com>
11480
11481 * gnutls.c (fn_gnutls_certificate_set_x509_key_file): Add alias to
11482 `gnutls_certificate_set_x509_key_file'.
11483
d2127135
JB
114842011-05-05 Juanma Barranquero <lekktu@gmail.com>
11485
11486 * makefile.w32-in ($(BLD)/image.$(O), $(BLD)/process.$(O)):
11487 Update dependencies.
11488
e968f4f3
JB
114892011-05-04 Juanma Barranquero <lekktu@gmail.com>
11490
11491 * gnutls.h (emacs_gnutls_write, emacs_gnutls_read):
11492 * gnutls.c (emacs_gnutls_write, emacs_gnutls_read):
11493 Remove unused parameter `fildes'.
11494 * process.c (read_process_output, send_process): Don't pass it.
11495
84d358f0
JB
114962011-05-04 Juanma Barranquero <lekktu@gmail.com>
11497
11498 Fix previous change: the library cache is defined in w32.c.
11499 * image.c (CACHE_IMAGE_TYPE) [!HAVE_NTGUI]: Define to noop.
11500 (Finit_image_library): Wrap Vlibrary_cache on "#ifdef HAVE_NTGUI".
11501
0898ca10
JB
115022011-05-04 Juanma Barranquero <lekktu@gmail.com>
11503
11504 Implement dynamic loading of GnuTLS on Windows.
11505
11506 * gnutls.h (GNUTLS_EMACS_ERROR_NOT_LOADED): New macro.
11507 (emacs_gnutls_write, emacs_gnutls_read): Mark as extern.
11508 (emacs_gnutls_record_check_pending, emacs_gnutls_transport_set_errno):
11509 Declare.
11510
11511 * gnutls.c (Qgnutls_dll): Define.
11512 (DEF_GNUTLS_FN, LOAD_GNUTLS_FN): New macros.
11513 (gnutls_*): Declare function pointers.
11514 (init_gnutls_functions): New function to initialize function pointers.
11515 (emacs_gnutls_handshake, Fgnutls_error_string, Fgnutls_deinit)
11516 (emacs_gnutls_global_init, Fgnutls_bye): Use function pointers.
11517 (emacs_gnutls_record_check_pending, emacs_gnutls_transport_set_errno):
11518 Wrappers for gnutls_record_check_pending and gnutls_transport_set_errno.
11519 (emacs_gnutls_write, emacs_gnutls_read)
11520 (emacs_gnutls_handle_error, Fgnutls_error_fatalp)
11521 (Fgnutls_available_p): New function.
11522 (Fgnutls_boot): Call Fgnutls_available_p. Use function pointers.
11523 (syms_of_gnutls) <Qgnutls_dll>: Initialize and staticpro it.
11524 (syms_of_gnutls) <Sgnutls_available_p>: defsubr it.
11525
11526 * image.c: Include w32.h.
11527 (Vimage_type_cache): Delete.
11528 (syms_of_image) <Vimage_type_cache>: Don't initialize and staticpro it.
11529 (CACHE_IMAGE_TYPE, Finit_image_library): Use Vlibrary_cache instead.
11530 (w32_delayed_load): Move to w32.c.
11531
11532 * w32.h (VlibraryCache, QCloaded_from, w32_delayed_load): Declare.
11533
11534 * w32.c (QCloaded_from, Vlibrary_cache): Define.
11535 (w32_delayed_load): Move from image.c. When loading a library, record
11536 its filename in the :loaded-from property of the library id.
11537 (globals_of_w32) <QCloaded_from, Vlibrary_cache>:
11538 Initialize and staticpro them.
11539 (emacs_gnutls_pull, emacs_gnutls_push): Call emacs_gnutls_* functions.
11540
11541 * process.c: Include lisp.h before w32.h, not after.
11542 (wait_reading_process_output): Call emacs_gnutls_record_check_pending
11543 instead of gnutls_record_check_pending.
11544
11545 * callproc.c, emacs.c: Include lisp.h before w32.h, not after.
11546
ff4de4aa
TZ
115472011-05-04 Teodor Zlatanov <tzz@lifelogs.com>
11548
11549 * gnutls.c (Fgnutls_boot): Support :keylist and :crlfiles options
11550 instead of :keyfiles. Give GnuTLS the keylist and the CRL lists
11551 as passed in.
11552
abe95abb
JD
115532011-05-03 Jan Djärv <jan.h.d@swipnet.se>
11554
11555 * xterm.c (x_set_frame_alpha): Do not set property on anything
11556 else than FRAME_X_OUTER_WINDOW (Bug#8608).
11557
e16e55d4
JB
115582011-05-02 Juanma Barranquero <lekktu@gmail.com>
11559
11560 * sysdep.c (get_tty_size) [WINDOWSNT]: Implement. (Bug#8596)
11561
bafcf6a5
JB
115622011-05-02 Juanma Barranquero <lekktu@gmail.com>
11563
11564 * gnutls.c (Qgnutls_log_level, Qgnutls_code, Qgnutls_anon)
11565 (Qgnutls_x509pki, Qgnutls_e_interrupted, Qgnutls_e_again)
11566 (Qgnutls_e_invalid_session, Qgnutls_e_not_ready_for_handshake)
11567 (gnutls_global_initialized, Qgnutls_bootprop_priority)
11568 (Qgnutls_bootprop_trustfiles, Qgnutls_bootprop_keyfiles)
11569 (Qgnutls_bootprop_callbacks, Qgnutls_bootprop_loglevel)
11570 (Qgnutls_bootprop_hostname, Qgnutls_bootprop_verify_flags)
11571 (Qgnutls_bootprop_verify_error, Qgnutls_bootprop_verify_hostname_error)
11572 (Qgnutls_bootprop_callbacks_verify): Make static.
11573
e7a6747f
AS
115742011-05-01 Andreas Schwab <schwab@linux-m68k.org>
11575
19ed11ba
AS
11576 * callproc.c: Indentation fixup.
11577
e7a6747f 11578 * sysdep.c (wait_for_termination_1): Make static.
04f2d78b
CB
11579 (wait_for_termination, interruptible_wait_for_termination):
11580 Move after wait_for_termination_1.
e7a6747f 11581
1ef14cb4
LMI
115822011-05-01 Lars Magne Ingebrigtsen <larsi@gnus.org>
11583
11584 * sysdep.c (interruptible_wait_for_termination): New function
11585 which is like wait_for_termination, but allows keyboard
11586 interruptions.
11587
11588 * callproc.c (Fcall_process): Add (:file "file") as an option for
11589 the STDOUT buffer.
11590 (Fcall_process_region): Ditto.
11591
330d880c
EZ
115922011-04-30 Eli Zaretskii <eliz@gnu.org>
11593
8db90b73
EZ
11594 * dosfns.c (Fint86, Fdos_memget, Fdos_memput): Use `ASIZE (FOO)'
11595 rather than `XVECTOR (FOO)->size'.
11596
330d880c
EZ
11597 * process.c: Remove HAVE_INTTYPES_H condition from inclusion of
11598 inttypes.h, as a gnulib replacement is used if it not available in
11599 system headers.
11600
15cbd324
EZ
116012011-04-21 Eli Zaretskii <eliz@gnu.org>
11602
11603 Lift the MOST_POSITIVE_FIXNUM/4 limitation on visited files.
11604 * fileio.c (Finsert_file_contents): Don't limit file size to 1/4
11605 of MOST_POSITIVE_FIXNUM. (Bug#8528)
11606
11607 * coding.c (coding_alloc_by_realloc): Error out if destination
11608 will grow beyond MOST_POSITIVE_FIXNUM.
11609 (decode_coding_emacs_mule): Abort if there isn't enough place in
11610 charbuf for the composition carryover bytes. Reserve an extra
11611 space for up to 2 characters produced in a loop.
11612 (decode_coding_iso_2022): Abort if there isn't enough place in
11613 charbuf for the composition carryover bytes.
11614
116152011-04-21 Eli Zaretskii <eliz@gnu.org>
afda1437 11616
ae940cca
EZ
11617 * doprnt.c (doprnt) [!HAVE_LONG_LONG_INT]: Error out instead of
11618 aborting when %lld or %lll format is passed.
11619 [!HAVE_UNSIGNED_LONG_LONG_INT]: Error out instead of aborting when
11620 %llo or %llx format is passed. (Bug#8545)
11621
03ab8921
EZ
11622 * window.c (window_scroll_line_based): Use a marker instead of
11623 simple variables to record original value of point. (Bug#7952)
11624
afda1437
EZ
11625 * doprnt.c (doprnt): Fix the case where a multibyte sequence
11626 produced by %s or %c overflows available buffer space. (Bug#8545)
11627
f76dee0c
PE
116282011-04-28 Paul Eggert <eggert@cs.ucla.edu>
11629
11630 * doprnt.c (doprnt): Omit useless test; int overflow check (Bug#8545).
283cdbef 11631 (SIZE_MAX): Move defn after all includes, as they might #define it.
f76dee0c 11632
fdc5744d
JB
116332011-04-28 Juanma Barranquero <lekktu@gmail.com>
11634
11635 * w32.c (init_environment): Warn about defaulting HOME to C:\.
11636
638f053a
JB
116372011-04-28 Juanma Barranquero <lekktu@gmail.com>
11638
11639 * keyboard.c (Qdelayed_warnings_hook): Define.
11640 (command_loop_1): Run `delayed-warnings-hook'
11641 if Vdelayed_warnings_list is non-nil.
11642 (syms_of_keyboard) <delayed-warnings-hook>: DEFSYM it.
11643 (syms_of_keyboard) <delayed-warnings-list>: DEFVAR_LISP it.
11644
d178f871
EZ
116452011-04-28 Eli Zaretskii <eliz@gnu.org>
11646
11647 * doprnt.c (doprnt): Don't return value smaller than the buffer
11648 size if the message was truncated. (Bug#8545).
11649
b124fd93
JB
116502011-04-28 Juanma Barranquero <lekktu@gmail.com>
11651
11652 * w32fns.c (Fx_change_window_property, Fx_delete_window_property)
11653 (Fx_window_property): #if-0 the whole functions, not just the bodies.
11654
e810457d
PE
116552011-04-27 Paul Eggert <eggert@cs.ucla.edu>
11656
11657 * doprnt.c (doprnt): Support "ll" length modifier, for long long.
11658
ea51cceb
JB
116592011-04-27 Juanma Barranquero <lekktu@gmail.com>
11660
11661 * makefile.w32-in: Update dependencies.
11662
94dcfacf
EZ
116632011-04-27 Eli Zaretskii <eliz@gnu.org>
11664
11665 Improve `doprnt' and its usage. (Bug#8545)
11666 * doprnt.c (doprnt): Make sure `format' is never accessed beyond
11667 `format_end'. Remove support for %l as a conversion specifier.
11668 Don't use xrealloc. Improve diagnostics when the %l size modifier
11669 is used. Update the commentary.
11670
11671 * eval.c (verror): Simplify calculation of size_t.
11672
11673 * coding.c (Ffind_operation_coding_system): Fix diagnostic error
11674 messages.
11675
f61f41d7
PE
116762011-04-27 Yoshiaki Kasahara <kasahara@nc.kyushu-u.ac.jp> (tiny change)
11677
11678 * buffer.c (init_buffer) [USE_MMAP_FOR_BUFFERS]: Adjust to aliasing
11679 change.
11680
96fb4434
PE
116812011-04-27 Paul Eggert <eggert@cs.ucla.edu>
11682
11683 * nsmenu.m: Replace all uses of XVECTOR with ASIZE and AREF.
11684 This makes this file independent of the recent pseudovector change.
11685
671875da 116862011-04-26 Paul Eggert <eggert@cs.ucla.edu>
eab3844f 11687
69e9b5a3
PE
11688 * keyboard.c (handle_user_signal): Fix pointer signedness problem.
11689
b5f869a7 11690 * gnutls.c (emacs_gnutls_handle_error): Remove unused local.
7754e151 11691 (Fgnutls_boot): gnutls_certificate_verify_peers2 wants unsigned *.
8d4c3955 11692 Remove unused local.
c8926152 11693 (emacs_gnutls_write): Don't use uninitialized rtnval if nbyte <= 0.
080e5a8d 11694
841a1577 11695 * lisp.h: Fix a problem with aliasing and vector headers. (Bug#8546)
04f2d78b
CB
11696 GCC 4.6.0 optimizes based on type-based alias analysis.
11697 For example, if b is of type struct buffer * and v of type struct
eab3844f
PE
11698 Lisp_Vector *, then gcc -O2 was incorrectly assuming that &b->size
11699 != &v->size, and therefore "v->size = 1; b->size = 2; return
11700 v->size;" must therefore return 1. This assumption is incorrect
11701 for Emacs, since it type-puns struct Lisp_Vector * with many other
11702 types. To fix this problem, this patch adds a new type struct
f904488f 11703 vectorlike_header that documents the constraints on layout of vectors
eab3844f
PE
11704 and pseudovectors, and helps optimizing compilers not get fooled
11705 by Emacs's type punning. It also adds the macros XSETTYPED_PVECTYPE
11706 XSETTYPED_PSEUDOVECTOR, TYPED_PSEUDOVECTORP, for similar reasons.
f904488f
PE
11707 * lisp.h (XSETTYPED_PVECTYPE): New macro, specifying the name of
11708 the size member.
eab3844f
PE
11709 (XSETPVECTYPE): Rewrite in terms of new macro.
11710 (XSETPVECTYPESIZE): New macro, specifying both type and size.
11711 This is a bit clearer, and further avoids the possibility of
11712 undesirable aliasing.
11713 (XSETTYPED_PSEUDOVECTOR): New macro, specifying the size.
f904488f 11714 (XSETPSEUDOVECTOR): Rewrite in terms of XSETTYPED_PSEUDOVECTOR.
eab3844f
PE
11715 (XSETSUBR): Rewrite in terms of XSETTYPED_PSEUDOVECTOR and XSIZE,
11716 since Lisp_Subr is a special case (no "next" field).
04f2d78b
CB
11717 (ASIZE): Now uses header.size rather than size.
11718 All previous uses of XVECTOR (foo)->size replaced to use this macro,
f904488f
PE
11719 to avoid the hassle of writing XVECTOR (foo)->header.size.
11720 (struct vectorlike_header): New type.
eab3844f
PE
11721 (TYPED_PSEUDOVECTORP): New macro, also specifying the C type of the
11722 object, to help avoid aliasing.
11723 (PSEUDOVECTORP): Rewrite in terms of TYPED_PSEUDOVECTORP.
11724 (SUBRP): Likewise, since Lisp_Subr is a special case.
11725 * lisp.h (struct Lisp_Vector, struct Lisp_Char_Table):
11726 (struct Lisp_Sub_Char_Table, struct Lisp_Bool_Vector):
11727 (struct Lisp_Hash_Table): Combine first two members into a single
f904488f 11728 struct vectorlike_header member. All uses of "size" and "next" members
eab3844f
PE
11729 changed to be "header.size" and "header.next".
11730 * buffer.h (struct buffer): Likewise.
11731 * font.h (struct font_spec, struct font_entity, struct font): Likewise.
11732 * frame.h (struct frame): Likewise.
11733 * process.h (struct Lisp_Process): Likewise.
11734 * termhooks.h (struct terminal): Likewise.
11735 * window.c (struct save_window_data, struct saved_window): Likewise.
11736 * window.h (struct window): Likewise.
11737 * alloc.c (allocate_buffer, Fmake_bool_vector, allocate_pseudovector):
11738 Use XSETPVECTYPESIZE, not XSETPVECTYPE, to avoid aliasing problems.
11739 * buffer.c (init_buffer_once): Likewise.
11740 * lread.c (defsubr): Use XSETTYPED_PVECTYPE, since Lisp_Subr is a
11741 special case.
11742 * process.c (Fformat_network_address): Use local var for size,
11743 for brevity.
11744
0df1eac5
PE
11745 * bytecode.c (exec_byte_code): Don't use XVECTOR before CHECK_VECTOR.
11746
847ab9d1 11747 Make the Lisp reader and string-to-float more consistent (Bug#8525)
452f4150
PE
11748 * data.c (atof): Remove decl; no longer used or needed.
11749 (digit_to_number): Move to lread.c.
11750 (Fstring_to_number): Use new string_to_number function, to be
11751 consistent with how the Lisp reader treats infinities and NaNs.
11752 Do not assume that floating-point numbers represent EMACS_INT
11753 without losing information; this is not true on most 64-bit hosts.
11754 Avoid double-rounding errors, by insisting on integers when
11755 parsing non-base-10 numbers, as the documentation specifies.
11756 * lisp.h (string_to_number): New decl, replacing ...
11757 (isfloat_string): Remove.
bc0a5c13 11758 * lread.c: Include <inttypes.h>, for uintmax_t and strtoumax.
d78050d6 11759 (read1): Do not accept +. and -. as integers; this
452f4150
PE
11760 appears to have been a coding error. Similarly, do not accept
11761 strings like +-1e0 as floating point numbers. Do not report
11762 overflow for integer overflows unless the base is not 10 which
11763 means we have no simple and reliable way to continue.
11764 Break out the floating-point parsing into a new
11765 function string_to_number, so that Fstring_to_number parses
11766 floating point numbers consistently with the Lisp reader.
04f2d78b 11767 (digit_to_number): Move here from data.c. Make it static inline.
452f4150
PE
11768 (E_CHAR, EXP_INT): Remove, replacing with ...
11769 (E_EXP): New macro, to solve the "1.0e+" problem mentioned below.
11770 (string_to_number): New function, replacing isfloat_string.
11771 This function checks for valid syntax and produces the resulting
11772 Lisp float number too. Rework it so that string-to-number
bc0a5c13 11773 no longer mishandles examples like "1.0e+". Use strtoumax,
d78050d6
PE
11774 so that overflow for non-base-10 numbers is reported only when
11775 there's no portable and simple way to convert to floating point.
452f4150 11776
67769ffc
PE
11777 * textprop.c (set_text_properties_1): Rewrite for clarity,
11778 and to avoid GCC warning about integer overflow.
11779
c20db43f
PE
11780 * intervals.h (struct interval): Use EMACS_INT for members
11781 where EMACS_UINT might cause problems. See
11782 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00514.html>.
11783 (CHECK_TOTAL_LENGTH): Remove cast to EMACS_INT; no longer needed.
11784 * intervals.c (interval_deletion_adjustment): Now returns EMACS_INT.
11785 All uses changed.
37aa2f85
PE
11786 (offset_intervals): Tell GCC not to worry about length overflow
11787 when negating a negative length.
c20db43f 11788
2538aa2f
PE
11789 * alloc.c (overrun_check_malloc, overrun_check_realloc): Now static.
11790 (overrun_check_free): Likewise.
11791
f2d3008d
PE
11792 * alloc.c (SDATA_SIZE) [!GC_CHECK_STRING_BYTES]: Avoid runtime check
11793 in the common case where SDATA_DATA_OFFSET is a multiple of Emacs
11794 word size.
11795
ec8df744
PE
11796 * gnutls.c: Fix problems found by GCC 4.6.0 on Ubuntu 10.10.
11797 (gnutls_make_error): Rename local to avoid shadowing.
11798 (gnutls_emacs_global_deinit): ifdef out; not used.
11799 (Fgnutls_boot): Use const for pointer to readonly storage.
11800 Comment out unused local. Fix pointer signedness problems.
11801
640ee02d
PE
11802 * lread.c (openp): Don't stuff size_t into an 'int'.
11803 Use <= on length, not < on length + 1, to avoid GCC 4.6.0 warning
11804 about possible signed overflow.
11805
6048fb2a
PE
11806 * gtkutil.c: Fix problems found by GCC 4.6.0 on Ubuntu 10.10.
11807 (GDK_KEY_g): Don't define if already defined.
11808 (xg_prepare_tooltip): Avoid pointer signedness problem.
11809 (xg_set_toolkit_scroll_bar_thumb): Redo to avoid two casts.
11810
fa3c87e1
PE
11811 * process.c (Fnetwork_interface_info): Avoid left-shift undefined
11812 behavior with 1 << 31. GCC 4.6.0 warns about this on 32-bit hosts.
11813
2172544b
PE
11814 * xfns.c (Fx_window_property): Simplify a bit,
11815 to make a bit faster and to avoid GCC 4.6.0 warning.
11816 * xselect.c (x_get_window_property, x_handle_dnd_message): Likewise.
11817
9b821a21
PE
11818 * fns.c (internal_equal): Don't assume size_t fits in int.
11819
3c616cfa
PE
11820 * alloc.c (compact_small_strings): Tighten assertion a little.
11821
c2982e87
PE
11822 Replace pEd with more-general pI, and fix some printf arg casts.
11823 * lisp.h (pI): New macro, generalizing old pEd macro to other
11824 conversion specifiers. For example, use "...%"pI"d..." rather
11825 than "...%"pEd"...".
11826 (pEd): Remove. All uses replaced with similar uses of pI.
61bdb816 11827 * m/amdx86-64.h, m/ia64.h, m/ibms390x.h: Likewise.
c2982e87
PE
11828 * alloc.c (check_pure_size): Don't overflow by converting size to int.
11829 * bidi.c (bidi_dump_cached_states): Use pI to avoid cast.
11830 * data.c (Fnumber_to_string): Use pI instead of if-then-else-abort.
11831 * dbusbind.c (xd_append_arg): Use pI to avoid cast.
11832 (Fdbus_method_return_internal, Fdbus_method_error_internal): Likewise.
11833 * font.c (font_unparse_xlfd): Avoid potential buffer overrun on
11834 64-bit hosts.
11835 (font_unparse_xlfd, font_unparse_fcname): Use pI to avoid casts.
11836 * keyboard.c (record_char, modify_event_symbol): Use pI to avoid casts.
11837 * print.c (safe_debug_print, print_object): Likewise.
11838 (print_object): Don't overflow by converting EMACS_INT or EMACS_UINT
11839 to int.
6f04d126
PE
11840 Use pI instead of if-then-else-abort. Use %p to avoid casts,
11841 avoiding the 0 flag, which is not portable.
c2982e87
PE
11842 * process.c (Fmake_network_process): Use pI to avoid cast.
11843 * region-cache.c (pp_cache): Likewise.
11844 * xdisp.c (decode_mode_spec): Likewise.
11845 * xrdb.c (x_load_resources) [USE_MOTIF]: Use pI to avoid undefined
11846 behavior on 64-bit hosts with printf arg.
6f04d126 11847 * xselect.c (x_queue_event): Use %p to avoid casts, avoiding 0 flag.
c2982e87
PE
11848 (x_stop_queuing_selection_requests): Likewise.
11849 (x_get_window_property): Don't truncate byte count to an 'int'
11850 when tracing.
0b432f21 11851
5e073ec7
PE
11852 * frame.c (frame_name_fnn_p): Get rid of strtol, which isn't right
11853 here, since it parses constructs like leading '-' and spaces,
11854 which are not wanted; and it overflows with large numbers.
11855 Instead, simply match F[0-9]+, which is what is wanted anyway.
11856
36372bf9
PE
11857 * alloc.c: Remove unportable assumptions about struct layout.
11858 (SDATA_SELECTOR, SDATA_DATA_OFFSET): New macros.
11859 (SDATA_OF_STRING, SDATA_SIZE, allocate_string_data):
11860 (allocate_vectorlike, make_pure_vector): Use the new macros,
11861 plus offsetof, to remove unportable assumptions about struct layout.
11862 These assumptions hold on all porting targets that I know of, but
11863 they are not guaranteed, they're easy to remove, and removing them
11864 makes further changes easier.
11865
0b432f21
PE
11866 * alloc.c (BLOCK BYTES): Fix typo by changing "ablock" to "ablocks".
11867 This doesn't fix a bug but makes the code clearer.
bfd1c781
PE
11868 (string_overrun_cookie): Now const. Use initializers that
11869 don't formally overflow signed char, to avoid warnings.
000098c1
PE
11870 (allocate_string_data) [GC_CHECK_STRING_OVERRUN]: Fix typo that
11871 can cause Emacs to crash when string overrun checking is enabled.
c7bda33c
PE
11872 (allocate_buffer): Don't assume sizeof (struct buffer) is a
11873 multiple of sizeof (EMACS_INT); it need not be, if
11874 alignof(EMACS_INT) < sizeof (EMACS_INT).
d0f4e1f5 11875 (check_sblock, check_string_bytes, check_string_free_list): Protoize.
0b432f21 11876
895009e1
JB
118772011-04-26 Juanma Barranquero <lekktu@gmail.com>
11878
11879 * keyboard.c (QCrtl): Rename from Qrtl. All uses changed.
11880
6a7a1b0b
TZ
118812011-04-26 Teodor Zlatanov <tzz@lifelogs.com>
11882
11883 * gnutls.c (emacs_gnutls_handshake): Return an error if we're not
b5f869a7 11884 supposed to be handshaking. (Bug#8556)
6a7a1b0b
TZ
11885 Reported by Paul Eggert <eggert@cs.ucla.edu>.
11886
841a1577 118872011-04-26 Daniel Colascione <dan.colascione@gmail.com>
0438ce91
DC
11888
11889 * lisp.h (Qdebug): List symbol.
895009e1 11890 * eval.c (Qdebug): Restore global linkage.
0438ce91
DC
11891 * keyboard.c (debug-on-event): New variable.
11892 (handle_user_signal): Break into debugger when debug-on-event
11893 matches the current signal symbol.
11894
f2d3ba6f
DN
118952011-04-25 Dan Nicolaescu <dann@ics.uci.edu>
11896
11897 * alloc.c (check_sblock, check_string_bytes)
11898 (check_string_free_list): Convert to standard C.
11899
42ce4c63
TZ
119002011-04-25 Teodor Zlatanov <tzz@lifelogs.com>
11901
11902 * w32.c (emacs_gnutls_push): Fix typo.
11903
825cd63c
EZ
119042011-04-25 Eli Zaretskii <eliz@gnu.org>
11905
fb11d64d
EZ
11906 * gnutls.c (emacs_gnutls_handshake): Avoid compiler warnings about
11907 "cast to pointer from integer of different size".
11908
825cd63c
EZ
11909 Improve doprnt and its use in verror. (Bug#8545)
11910 * doprnt.c (doprnt): Document the set of format control sequences
11911 supported by the function. Use SAFE_ALLOCA instead of always
11912 using `alloca'.
11913
11914 * eval.c (verror): Don't limit the buffer size at size_max-1, that
11915 is one byte too soon. Don't use xrealloc; instead xfree and
11916 xmalloc anew.
11917
e061a11b
TZ
119182011-04-24 Teodor Zlatanov <tzz@lifelogs.com>
11919
11920 * gnutls.h: Add GNUTLS_STAGE_CALLBACKS enum to denote we're in the
11921 callbacks stage.
11922
11923 * gnutls.c: Renamed global_initialized to
11924 gnutls_global_initialized. Added internals for the
11925 :verify-hostname-error, :verify-error, and :verify-flags
11926 parameters of `gnutls-boot' and documented those parameters in the
11927 docstring. Start callback support.
9173deec
JB
11928 (emacs_gnutls_handshake): Add Woe32 support. Retry handshake
11929 unless a fatal error occurred. Call gnutls_alert_send_appropriate
11930 on error. Return error code.
e061a11b
TZ
11931 (emacs_gnutls_write): Call emacs_gnutls_handle_error.
11932 (emacs_gnutls_read): Likewise.
11933 (Fgnutls_boot): Return handshake error code.
11934 (emacs_gnutls_handle_error): New function.
11935 (wsaerror_to_errno): Likewise.
11936
11937 * w32.h (emacs_gnutls_pull): Add prototype.
11938 (emacs_gnutls_push): Likewise.
11939
11940 * w32.c (emacs_gnutls_pull): New function for GnuTLS on Woe32.
11941 (emacs_gnutls_push): Likewise.
11942
119432011-04-24 Claudio Bley <claudio.bley@gmail.com> (tiny change)
11944
11945 * process.c (wait_reading_process_output): Check if GnuTLS
11946 buffered some data internally if no FDs are set for TLS
11947 connections.
11948
11949 * makefile.w32-in (OBJ2): Add gnutls.$(O).
11950 (LIBS): Link to USER_LIBS.
11951 ($(BLD)/gnutls.$(0)): New target.
11952
fa6996bc
EZ
119532011-04-24 Eli Zaretskii <eliz@gnu.org>
11954
eb35682e
EZ
11955 * xdisp.c (handle_single_display_spec): Rename the
11956 display_replaced_before_p argument into display_replaced_p, to
11957 make it consistent with the commentary. Fix typos in the
11958 commentary.
11959
e2ad650c
EZ
11960 * textprop.c (syms_of_textprop): Remove dead code.
11961 (copy_text_properties): Delete obsolete commentary about an
11962 interface that was deleted long ago. Fix typos in the description
11963 of arguments.
11964
1b2de274
EZ
11965 * msdos.c (XMenuActivate, XMenuAddSelection): Adjust argument list
11966 to changes in oldXMenu/XMenu.h from 2011-04-16.
11967 <menu_help_message, prev_menu_help_message>: Constify.
11968 (IT_menu_make_room): menu->help_text is now `const char **';
11969 adjust.
11970
11971 * msdos.h (XMenuActivate, XMenuAddSelection): Adjust prototypes
11972 to changes in oldXMenu/XMenu.h from 2011-04-16.
11973 (struct XMenu): Declare `help_text' `const char **'.
11974
11975 * xfaces.c <Qunspecified>: Make extern again.
11976
11977 * syntax.c: Include sys/types.h before including regex.h, as
75f1671a 11978 required by POSIX.
1b2de274 11979
762b15be
EZ
11980 * doc.c (get_doc_string): Improve the format passed to `error'.
11981
11982 * doprnt.c (doprnt): Improve commentary.
11983
11984 * term.c (init_tty) [MSDOS]: Fix 1st argument to maybe_fatal.
11985
11986 * Makefile.in (TAGS): Depend on $(M_FILE) and $(S_FILE), and scan
11987 them with etags.
11988
f1052e5d
EZ
11989 * makefile.w32-in (globals.h): Add a dummy recipe, to make any
11990 changes in globals.h immediately force recompilation.
762b15be
EZ
11991 (TAGS): Depend on $(CURDIR)/m/intel386.h and
11992 $(CURDIR)/s/ms-w32.h.
11993 (TAGS-gmake): Scan $(CURDIR)/m/intel386.h and $(CURDIR)/s/ms-w32.h.
f1052e5d 11994
fa6996bc
EZ
11995 * character.c (Fchar_direction): Function deleted.
11996 (syms_of_character): Don't defsubr it.
11997 <char-direction-table>: Deleted.
11998
e6c3da20
EZ
119992011-04-23 Eli Zaretskii <eliz@gnu.org>
12000
12001 Fix doprnt so it could be used again safely in `verror'. (Bug#8435)
12002 * doprnt.c: Include limits.h.
12003 (SIZE_MAX): New macro.
04f2d78b
CB
12004 (doprnt): Return a size_t value. 2nd arg is now size_t.
12005 Many local variables are now size_t instead of int or unsigned.
e6c3da20
EZ
12006 Improve overflow protection. Support `l' modifier for integer
12007 conversions. Support %l conversion. Don't assume an EMACS_INT
12008 argument for integer conversions and for %c.
12009
12010 * lisp.h (doprnt): Restore prototype.
12011
12012 * makefile.w32-in ($(BLD)/callint.$(O)): Depend on
12013 $(SRC)/character.h.
12014
12015 * Makefile.in (base_obj): Add back doprnt.o.
12016
12017 * deps.mk (doprnt.o): Add back prerequisites.
12018 (callint.o): Depend on character.h.
12019
12020 * eval.c (internal_lisp_condition_case): Include the handler
12021 representation in the error message.
12022 (verror): Call doprnt instead of vsnprintf. Fix an off-by-one bug
12023 when breaking from the loop.
12024
12025 * xdisp.c (vmessage): Call doprnt instead of vsnprintf.
12026
12027 * callint.c (Fcall_interactively): When displaying error message
12028 about invalid control letter, pass the character's codepoint, not
12029 a pointer to its multibyte form. Improve display of the character
12030 in octal and display also its hex code.
12031
12032 * character.c (char_string): Use %x to display the (unsigned)
12033 codepoint of an invalid character, to avoid displaying a bogus
12034 negative value.
12035
12036 * font.c (check_otf_features): Pass SDATA of SYMBOL_NAME to
12037 `error', not SYMBOL_NAME itself.
12038
12039 * coding.c (Fencode_sjis_char, Fencode_big5_char): Use %c for
12040 character arguments to `error'.
12041
12042 * charset.c (check_iso_charset_parameter): Fix incorrect argument
12043 to `error' in error message about FINAL_CHAR argument. Make sure
12044 FINAL_CHAR is a character, and use %c when it is passed as
12045 argument to `error'.
12046
4ffd0d6b 120472011-04-23 Eli Zaretskii <eliz@gnu.org>
97a93095
EZ
12048
12049 * s/ms-w32.h (localtime): Redirect to sys_localtime.
12050
12051 * w32.c: Include <time.h>.
12052 (sys_localtime): New function.
12053
4ffd0d6b 120542011-04-23 Chong Yidong <cyd@stupidchicken.com>
c17819f4
CY
12055
12056 * xdisp.c (init_xdisp): Initialize echo_area_window (Bug#6451).
12057
4ffd0d6b 12058 * buffer.c (syms_of_buffer): Doc fix (Bug#6902).
aac0c6e3 12059
4ffd0d6b 120602011-04-23 Samuel Thibault <sthibault@debian.org> (tiny change)
aac0c6e3 12061
4ffd0d6b
GM
12062 * sysdep.c (wait_for_termination): On GNU Hurd, kill returns -1 on
12063 zombies (Bug#8467).
aac0c6e3 12064
04c56954
EZ
120652011-04-19 Eli Zaretskii <eliz@gnu.org>
12066
12067 * syntax.h (SETUP_SYNTAX_TABLE_FOR_OBJECT): Fix setting of
12068 gl_state.e_property when gl_state.object is Qt.
12069
12070 * insdel.c (make_gap_larger): Remove limitation of buffer size
12071 to <= INT_MAX.
12072
16a43933
CY
120732011-04-18 Chong Yidong <cyd@stupidchicken.com>
12074
12075 * xdisp.c (lookup_glyphless_char_display)
12076 (produce_glyphless_glyph): Handle cons cell entry in
12077 glyphless-char-display.
12078 (Vglyphless_char_display): Document it.
12079
12080 * term.c (produce_glyphless_glyph): Handle cons cell entry in
12081 glyphless-char-display.
12082
4581706e
CY
120832011-04-17 Chong Yidong <cyd@stupidchicken.com>
12084
12085 * xdisp.c (get_next_display_element): Remove unnecessary ifdefs.
12086
12087 * termhooks.h (FRAME_WINDOW_P): Remove duplicated definitions.
12088
12089 * dispextern.h (FACE_SUITABLE_FOR_ASCII_CHAR_P): Add missing
12090 definition for no-X builds.
12091
4887c6e2 120922011-04-16 Paul Eggert <eggert@cs.ucla.edu>
764430a3 12093
fd35b6f9
PE
12094 Static checks with GCC 4.6.0 and non-default toolkits.
12095
5c1ccb01
PE
12096 * s/sol2-6.h, s/unixware.h (PTY_TTY_NAME_SPRINTF): Protoize decl.
12097
006c5daa
PE
12098 * process.c (keyboard_bit_set): Define only if SIGIO.
12099 (send_process_trap): Mark it with NO_RETURN if it doesn't return.
12100 (send_process): Repair possible setjmp clobbering.
12101
efc736d3
PE
12102 * s/usg5-4-common.h (SETUP_SLAVE_PTY): Don't pass extra arg to 'fatal'.
12103
4e2fe2e6
PE
12104 * eval.c: Include <stdio.h>, for vsnprintf on non-GNU/Linux hosts.
12105
f97334a2
PE
12106 * data.c (arith_error): Mark with NO_RETURN if it doesn't return.
12107
4e75f29d
PE
12108 * alloc.c (bytes_used_when_full, SPARE_MEMORY, BYTES_USED):
12109 Define only if needed.
12110
90efadd1
PE
12111 * sysdep.c (_FILE_OFFSET_BITS): Make this hack even uglier
12112 by pacifying GCC about it. Maybe it's time to retire it?
875975e9 12113 * xfaces.c (USG, __TIMEVAL__): Likewise.
90efadd1 12114
3c647824
PE
12115 * dispextern.h (struct redisplay_interface): Rename param
12116 to avoid shadowing.
e264f262 12117 * termhooks.h (struct terminal): Likewise.
761383f4 12118 * xterm.c (xembed_send_message): Likewise.
3c647824 12119
b58c5c4a
PE
12120 * insdel.c (make_gap_smaller): Define only if
12121 USE_MMAP_FOR_BUFFERS || REL_ALLOC || DOUG_LEA_MALLOC.
12122
cad59032
PE
12123 * keyboard.c (read_char): Make a var volatile so longjmp won't clobber
12124 it.
12125
c339dc2e
PE
12126 * emacs.c (MAX_HEAP_BSS_DIFF, my_edata): Move to where they're used,
12127 so that we aren't warned about unused symbols.
12128
91a3e27b
PE
12129 * xfns.c (Fx_file_dialog): Rename local to avoid shadowing.
12130
399c71d3 12131 * xdisp.c (x_produce_glyphs): Mark var as initialized (Bug#8512).
7a3fb125 12132
8ffc96f5
PE
12133 * xfns.c (x_real_positions): Mark locals as initialized.
12134
eef9bc79
PE
12135 * xmenu.c (xmenu_show): Don't use uninitialized vars.
12136
098db9dd
PE
12137 * xterm.c: Fix problems found by static analysis with other toolkits.
12138 (toolkit_scroll_bar_interaction): Define and use only if USE_X_TOOLKIT.
dda3aedd
PE
12139 (x_dispatch_event): Declare static if USE_GTK, and
12140 define if USE_GTK || USE_X_TOOLKIT.
098db9dd 12141 (SET_SAVED_BUTTON_EVENT): Define only if USE_X_TOOLKIT || USE_GTK.
dda3aedd 12142 * xterm.h (x_dispatch_event): Extern only if USE_X_TOOLKIT.
841a1577
JB
12143 * xterm.c, xterm.h (x_mouse_leave): Bring this function back, but only
12144 if defined HAVE_MENUS && !defined USE_X_TOOLKIT && !defined USE_GTK.
098db9dd 12145
eb18f6cc
PE
12146 * xmenu.c (menu_help_callback): Pointer type fixes.
12147 Use const pointers when pointing at readonly data. Avoid pointer
12148 signedness clashes.
12149 (FALSE): Remove unused macro.
12150 (update_frame_menubar): Remove unused decl.
12151
1fe72bf8
PE
12152 * xfns.c (Fx_hide_tip): Move locals to avoid shadowing.
12153
60d9e1db
PE
12154 * menu.c (push_submenu_start, push_submenu_end): Do not define unless
12155 USE_X_TOOLKIT || USE_GTK || HAVE_NS || defined HAVE_NTGUI.
12156 (single_menu_item): Rename local to avoid shadowing.
12157
39261c26
PE
12158 * keyboard.c (make_lispy_event): Remove unused local var.
12159
018c5e19
PE
12160 * frame.c, frame.h (x_get_resource_string): Bring this back, but
12161 only if HAVE_X_WINDOWS && !USE_X_TOOLKIT.
12162
63d2b86e
PE
12163 * bitmaps: Change bitmaps from unsigned char back to the X11
12164 compatible char. Avoid the old compiler warnings about
12165 out-of-range initializers by using, for example, '\xab' rather
12166 than 0xab.
12167
aefd87e1
PE
12168 * xgselect.c (xgselect_initialize): Check vs interface
12169 even if ! (defined (USE_GTK) || defined (HAVE_GCONF)).
12170
bf501fb9
PE
12171 * xmenu.c (xmenu_show): Rename parm to avoid shadowing.
12172
e9829fdf
PE
12173 * xterm.c (x_create_toolkit_scroll_bar): Use const * for pointers
12174 to read-only memory.
12175
1086c095
PE
12176 * fns.c (vector): Remove; this old hack is no longer needed.
12177
2baccd04 12178 * xsmfns.c (create_client_leader_window): Rename shadowing arg.
401f10cb 12179 Remove unused var.
dde42981 12180 (gdk_x11_set_sm_client_id) [!USE_GTK]: Don't define.
2baccd04 12181
72391843 12182 * xrdb.c (x_load_resources): Omit unused local.
3565b346 12183
436c16df 12184 * xfns.c (free_frame_menubar, atof): Remove duplicate decls.
8a94ea33 12185 (x_window): Rename locals to avoid shadowing.
dc5ddd85 12186 (USG): Use the kludged USG macro, to pacify gcc.
436c16df 12187
92bb796d 12188 * xterm.c (x_alloc_nearest_color_for_widget): Remove; unused.
bbbef9e1 12189 (x_term_init): Remove local to avoid shadowing.
92bb796d 12190
764430a3 12191 * xfns.c, xterm.c (_XEditResCheckMessages): Protoize decl.
4887c6e2
PE
12192
12193 * xdisp.c, dispextern.h (set_vertical_scroll_bar): Now extern if
12194 USE_TOOLKIT_SCROLL_BARS && !USE_GTK, as xterm.c needs it then.
12195
d1dfb56c
EZ
121962011-04-16 Eli Zaretskii <eliz@gnu.org>
12197
c4354cb4
EZ
12198 * gnutls.c (Fgnutls_boot): Don't pass Lisp_Object to `error'.
12199
d1dfb56c
EZ
12200 Fix regex.c, syntax.c and friends for buffers > 2GB.
12201 * syntax.h (struct gl_state_s): Declare character position members
12202 EMACS_INT.
12203
12204 * syntax.c (update_syntax_table): Declare 2nd argument EMACS_INT.
12205
04f2d78b
CB
12206 * textprop.c (verify_interval_modification, interval_of):
12207 Declare arguments EMACS_INT.
d1dfb56c
EZ
12208
12209 * intervals.c (adjust_intervals_for_insertion): Declare arguments
12210 EMACS_INT.
12211
12212 * intervals.h (CHECK_TOTAL_LENGTH): Cast to EMACS_INT, not `int'.
12213
12214 * indent.c (Fvertical_motion): Local variable it_start is now
12215 EMACS_INT.
12216
12217 * regex.c (re_match, re_match_2, re_match_2_internal)
12218 (bcmp_translate, regcomp, regexec, print_double_string)
12219 (group_in_compile_stack, re_search, re_search_2, regex_compile)
12220 (re_compile_pattern, re_exec): Declare arguments and local
12221 variables `size_t' and `ssize_t' and return values `regoff_t', as
12222 appropriate.
12223 (POP_FAILURE_REG_OR_COUNT) <pfreg>: Declare `long'.
12224 (CHECK_INFINITE_LOOP) <failure>: Declare `ssize_t'.
12225 <compile_stack_type>: `size' and `avail' are now `size_t'.
12226
12227 * regex.h <regoff_t>: Use ssize_t, not int.
12228 (re_search, re_search_2, re_match, re_match_2): Arguments that
12229 specify buffer/string position and length are now ssize_t and
12230 size_t. Return type is regoff_t.
12231
613052cd
BK
122322011-04-16 Ben Key <bkey76@gmail.com>
12233
12234 * nsfont.m: Fixed bugs in ns_get_family and
12235 ns_descriptor_to_entity that were caused by using free to
12236 deallocate memory blocks that were allocated by xmalloc (via
12237 xstrdup). This caused Emacs to crash when compiled with
12238 XMALLOC_OVERRUN_CHECK defined (when Emacs was configured with
12239 --enable-checking=xmallocoverrun). xfree is now used to
12240 deallocate these memory blocks.
12241
4170f62f 122422011-04-15 Paul Eggert <eggert@cs.ucla.edu>
3e047f51 12243
71b41406
PE
12244 * sysdep.c (emacs_read): Remove unnecessary check vs MAX_RW_COUNT.
12245
9587a89d
PE
12246 emacs_write: Accept and return EMACS_INT for sizes.
12247 See http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00514.html
12248 et seq.
12249 * gnutls.c, gnutls.h (emacs_gnutls_read, emacs_gnutls_write):
12250 Accept and return EMACS_INT.
12251 (emacs_gnutls_write): Return the number of bytes written on
12252 partial writes.
12253 * sysdep.c, lisp.h (emacs_read, emacs_write): Likewise.
273a5f82
PE
12254 (emacs_read, emacs_write): Remove check for negative size, as the
12255 Emacs source code has been audited now.
9587a89d
PE
12256 * sysdep.c (MAX_RW_COUNT): New macro, to work around kernel bugs.
12257 (emacs_read, emacs_write): Use it.
273a5f82
PE
12258 * process.c (send_process): Adjust to the new signatures of
12259 emacs_write and emacs_gnutls_write. Do not attempt to store
12260 a byte offset into an 'int'; it might overflow.
9587a89d 12261 See http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00483.html
273a5f82 12262
3e047f51
PE
12263 * sound.c: Don't assume sizes fit in 'int'.
12264 (struct sound_device.period_size, alsa_period_size):
9c3c56a7 12265 Return EMACS_INT, not int.
3e047f51 12266 (struct sound_device.write, vox_write, alsa_write):
9c3c56a7
PE
12267 Accept EMACS_INT, not int.
12268 (wav_play, au_play): Use EMACS_INT to store sizes and to
3e047f51
PE
12269 record read return values.
12270
cc39a9db
BK
122712011-04-15 Ben Key <bkey76@gmail.com>
12272
c9d0ec6d
JB
12273 * keyboard.c (Qundefined): Don't declare static since it is used
12274 in nsfns.m.
12275 * xfaces.c (Qbold, Qexpanded, Qitalic, Qcondensed): Don't declare
12276 static since they are used in nsfont.m.
cc39a9db 12277
6c60eb9f
SM
122782011-04-15 Stefan Monnier <monnier@iro.umontreal.ca>
12279
12280 * process.c (Qprocessp): Don't declare static.
12281 * lisp.h (Qprocessp): Declare again.
12282
7990b61a
JB
122832011-04-15 Juanma Barranquero <lekktu@gmail.com>
12284
12285 * font.c (Qopentype): Don't make static (used from w32uniscribe.c).
12286
5d4cb038
PE
122872011-04-14 Paul Eggert <eggert@cs.ucla.edu>
12288
8bd7b830 12289 Improve C-level modularity by making more things 'static'.
cd64ea1d 12290
e3b27b31
PE
12291 Don't publish debugger-only interfaces to other modules.
12292 * lisp.h (safe_debug_print, debug_output_compilation_hack):
12293 (verify_bytepos, count_markers): Move decls to the only modules
12294 that need them.
12295 * region-cache.h (pp_cache): Likewise.
12296 * window.h (check_all_windows): Likewise.
12297 * marker.c, print.c, region-cache.c, window.c: Decls moved here.
12298
5d4cb038
PE
12299 * sysdep.c (croak): Now static, if
12300 defined TIOCNOTTY || defined USG5 || defined CYGWIN.
12301 * syssignal.h (croak): Declare only if not static.
69003fd8
PE
12302
12303 * alloc.c (refill_memory_reserve): Now static if
12304 !defined REL_ALLOC || defined SYSTEM_MALLOC.
12305 * lisp.h (refill_memory_reserve): Declare only if not static.
93ea6e8f 12306
e87b6180
PE
12307 * xsettings.c, xsettings.h (xsettings_get_system_normal_font):
12308 Define only if USE_LUCID.
12309
ac64929e
PE
12310 * xrdb.c (x_customization_string, x_rm_string): Now static.
12311
6f37259d
PE
12312 * xmenu.c (x_menu_wait_for_event): Export only if USE_MOTIF.
12313 * xterm.h (x_menu_wait_for_event): Declare only if USE_MOTIF.
12314
1683e3ab
PE
12315 * xdisp.c (draw_row_with_mouse_face): Now static.
12316 * dispextern.h (draw_row_with_mouse_fave): Remove decl.
12317
de9c2632
PE
12318 * window.h (check_all_windows): Mark externally visible.
12319
2b96acb7
PE
12320 * window.c (window_deletion_count): Now static.
12321
12322 * undo.c: Make symbols static if they're not exported.
12323 (last_undo_buffer, last_boundary_position, pending_boundary):
12324 Now static.
12325
50436f33
PE
12326 * textprop.c (interval_insert_behind_hooks): Now static.
12327 (interval_insert_in_front_hooks): Likewise.
12328
64520e5c
PE
12329 * term.c: Make symbols static if they're not exported.
12330 (tty_turn_off_highlight, get_tty_terminal, max_frame_cols):
12331 (max_frame_lines, tty_set_terminal_modes):
12332 (tty_reset_terminal_modes, tty_turn_off_highlight):
12333 (get_tty_terminal): Now static.
12334 (term_mouse_moveto): Do not define if HAVE_WINDOW_SYSTEM.
12335 * termhooks.h (term_mouse_moveto): Do not declare if
8bd7b830 12336 HAVE_WINDOW_SYSTEM.
64520e5c
PE
12337 * dispextern.h (tty_set_terminal_modes, tty_reset_terminal_modes):
12338 (tty_turn_off_highlight, get_tty_terminal): Remove decls.
12339
1fa53021
PE
12340 * sysdep.c: Make symbols static if they're not exported.
12341 (emacs_get_tty, emacs_set_tty, old_fcntl_flags, old_fcntl_owner):
12342 Now static.
12343 (sigprocmask_set, full_mask): Remove; unused.
12344 (wait_debugging): Mark as visible.
12345 * syssignal.h (SIGFULLMASK, full_mask): Remove decls.
12346 * systty.h (emacs_get_tty, emacs_set_tty): Remove decls.
12347
d4b43b22
PE
12348 * syntax.c (syntax_temp): Define only if !__GNUC__.
12349
b7c513d0
PE
12350 * sound.c (current_sound_device, current_sound): Now static.
12351
989b29ad
PE
12352 * search.c (searchbufs, searchbuf_head): Now static.
12353
13a55a78
PE
12354 * scroll.c (scroll_cost): Remove; unused.
12355 * dispextern.h (scroll_cost): Remove decl.
12356
de68a1fc
PE
12357 * region-cache.h (pp_cache): Mark as externally visible.
12358
40ccffa6
PE
12359 * process.c: Make symbols static if they're not exported.
12360 (process_tick, update_tick, create_process, chan_process):
12361 (Vprocess_alist, proc_buffered_char, datagram_access):
12362 (fd_callback_data, send_process_frame, process_sent_to): Now static.
12363 (deactivate_process): Mark defn as static, as well as decl.
12364 * lisp.h (create_process): Remove decl.
12365 * process.h (chan_process, Vprocess_alist): Remove decls.
12366
ad64fc97
PE
12367 * print.c: Make symbols static if they're not exported.
12368 (print_depth, new_backquote_output, being_printed, print_buffer):
12369 (print_buffer_size, print_buffer_pos, print_buffer_pos_byte):
12370 (print_interval, print_number_index, initial_stderr_stream):
12371 Now static.
12372 * lisp.h (Fprinc): Remove decl.
12373 (debug_output_compilation_hack): Mark as externally visible.
12374
adddb265
PE
12375 * sysdep.c (croak): Move decl from here to syssignal.h.
12376 * syssignal.h (croak): Put it here, so the API can be checked when
12377 'croak' is called from dissociate_if_controlling_tty.
12378
1717ede2
PE
12379 * minibuf.c: Make symbols static if they're not exported.
12380 (minibuf_save_list, choose_minibuf_frame): Now static.
12381 * lisp.h (choose_minibuf_frame): Remove decl.
12382
fa5fb2bc
PE
12383 * lisp.h (verify_bytepos, count_markers): Mark as externally visible.
12384
1e3890d1
PE
12385 * lread.c: Make symbols static if they're not exported.
12386 (read_objects, initial_obarray, oblookup_last_bucket_number):
12387 Now static.
12388 (make_symbol): Remove; unused.
12389 * lisp.h (initial_obarray, make_symbol): Remove decls.
12390
8a1414fa
PE
12391 * keyboard.c: Make symbols static if they're not exported.
12392 (single_kboard, recent_keys_index, total_keys, recent_keys):
12393 (this_command_key_count_reset, raw_keybuf, raw_keybuf_count):
12394 (this_single_command_key_start, echoing, last_auto_save):
12395 (read_key_sequence_cmd, dribble, recursive_edit_unwind):
12396 (command_loop, echo_now, keyboard_init_hook, help_char_p):
12397 (quit_throw_to_read_char, command_loop_2, top_level_1, poll_timer):
12398 (Vlispy_mouse_stem, double_click_count):
12399 Now static.
12400 (force_auto_save_soon): Define only if SIGDANGER.
12401 (ignore_mouse_drag_p): Now static if
12402 !defined HAVE_WINDOW_SYSTEM || defined USE_GTK || defined HAVE_NS.
12403 (print_help): Remove; unused.
12404 (stop_character, last_timer_event): Mark as externally visible.
12405 * keyboard.h (ignore_mouse_drag_p): Declare only if
12406 defined HAVE_WINDOW_SYSTEM && !defined USE_GTK && !defined HAVE_NS.
12407 (echo_now, help_char_p, quit_throw_to_read_char): Remove decls.
12408 * lisp.h (echoing): Remove decl.
12409 (force_auto_save_soon): Declare only if SIGDANGER.
12410 * xdisp.c (redisplay_window): Simplify code, to make it more
12411 obvious that ignore_mouse_drag_p is not accessed if !defined
12412 USE_GTK && !defined HAVE_NS.
12413
93ea6e8f
PE
12414 * intervals.c: Make symbols static if they're not exported.
12415 (merge_properties_sticky, merge_interval_right, delete_interval):
12416 Now static.
12417 * intervals.h (merge_interval_right, delete_interval): Remove decls.
12418
77382fcc
PE
12419 * insdel.c: Make symbols static if they're not exported.
12420 However, leave prepare_to_modify_buffer alone. It's never
12421 called from outside this function, but that appears to be a bug.
12422 (combine_after_change_list, combine_after_change_buffer):
4889fc82 12423 (adjust_after_replace, signal_before_change): Now static.
77382fcc
PE
12424 (adjust_after_replace_noundo): Remove; unused.
12425 * lisp.h (adjust_after_replace, adjust_after_replace_noundo):
4889fc82 12426 (signal_before_change): Remove decls.
77382fcc 12427
9306c32e
PE
12428 * indent.c (val_compute_motion, val_vmotion): Now static.
12429
cd44d2eb
PE
12430 * image.c: Make symbols static if they're not exported.
12431 * dispextern.h (x_create_bitmap_from_xpm_data): Do not declare
12432 if USE_GTK.
12433 * image.c (x_create_bitmap_from_xpm_data): Do not define if USE_GTK.
12434 (xpm_color_cache, ct_table, ct_colors_allocated): Now static.
12435
ad9a7a06
PE
12436 * fringe.c (standard_bitmaps): Now static.
12437 (max_used_fringe_bitmap): Now static, unless HAVE_NS.
12438
81626931
PE
12439 * frame.c: Make symbols static if they're not exported.
12440 (x_report_frame_params, make_terminal_frame): Now static.
12441 (get_frame_param): Now static, unless HAVE_NS.
12442 (x_fullscreen_adjust): Define if WINDOWSNT, not if HAVE_WINDOW_SYSTEM.
12443 (x_get_resource_string): Remove; not used.
12444 * frame.h (make_terminal_frame, x_report_frame_params):
12445 (x_get_resource_string); Remove decls.
12446 (x_fullscreen_adjust): Declare only if WINDOWSNT.
12447 * lisp.h (get_frame_param): Declare only if HAVE_NS.
12448
239f9db9
PE
12449 * font.c, fontset.c: Make symbols static if they're not exported.
12450 * dispextern.h (FACE_SUITABLE_FOR_ASCII_CHAR_P): New macro.
12451 (FACE_SUITABLE_FOR_CHAR_P): Use it.
12452 * font.c (font_close_object): Now static.
12453 * font.h (font_close_object): Remove.
12454 * fontset.c (FONTSET_OBJLIST): Remove.
12455 (free_realized_fontset) #if-0 the body, which does nothing.
12456 (face_suitable_for_char_p): #if-0, as it's never called.
12457 * fontset.h (face_suitable_for_char_p): Remove decl.
04f2d78b
CB
12458 * xfaces.c (face_at_string_position):
12459 Use FACE_SUITABLE_FOR_ASCII_CHAR_P, not FACE_SUITABLE_FOR_CHAR_P,
239f9db9
PE
12460 since 0 is always ASCII.
12461
dfcf3579
PE
12462 * fns.c (weak_hash_tables): Now static.
12463
5045092b
PE
12464 * fileio.c: Make symbols static if they're not exported.
12465 (auto_saving, auto_save_mode_bits, auto_save_error_occurred):
12466 (Vwrite_region_annotation_buffers): Now static.
12467
57a96f5c
PE
12468 * eval.c: Make symbols static if they're not exported.
12469 (backtrace_list, lisp_eval_depth, when_entered_debugger): Now static.
12470 * lisp.h (backtrace_list): Remove decl.
12471
35f08c38
PE
12472 * emacs.c: Make symbols static if they're not exported.
12473 (malloc_state_ptr, malloc_using_checking, syms_of_emacs):
12474 (fatal_error_code, fatal_error_signal_hook, standard_args):
12475 Now static.
12476 (fatal_error_signal): Now static, unless FLOAT_CATCH_SIGKILL.
12477 (DEFINE_DUMMY_FUNCTION): Mark function as externally visible.
12478 (__CTOR_LIST__, __DTOR_LIST__): Now externally visible.
12479 * lisp.h (fatal_error_signal_hook): Remove decl.
12480 (fatal_error_signal): Declare only if FLOAT_CATCH_SIGKILL.
12481
f44bd759
PE
12482 * editfns.c: Move a (normally-unused) function to its only use.
12483 * editfns.c, lisp.h (get_operating_system_release): Remove.
12484 * process.c (init_process) [DARWIN_OS]: Do it inline, as it is not
12485 worth the hassle of breaking this out.
12486
b532497d
PE
12487 * xterm.c: Make symbols static if they're not exported.
12488 (x_raise_frame, x_lower_frame, x_wm_set_window_state):
12489 (x_wm_set_icon_pixmap, x_initialize, XTread_socket_fake_io_error):
12490 (x_destroy_window, x_delete_display):
12491 Now static.
12492 (x_dispatch_event): Now static if ! (USE_MOTIF || USE_X_TOOLKIT).
12493 (x_mouse_leave): Remove; unused.
12494 * xterm.h (x_display_info_for_name, x_raise_frame, x_lower_frame):
12495 (x_destroy_window, x_wm_set_window_state, x_wm_set_icon_pixmap):
12496 (x_delete_display, x_initialize, x_set_border_pixel, x_screen_planes):
12497 Remove decls.
12498 (x_mouse_leave): Declare only if WINDOWSNT.
12499 (x_dispatch_event): Declare only if USE_MOTIF or USE_X_TOOLKIT.
12500 (xic_create_fontsetname): Declare only if HAVE_X_WINDOWS &&
12501 USE_X_TOOLKIT.
12502
1675728f
PE
12503 * ftxfont.c: Make symbols static if they're not exported.
12504 (ftxfont_driver): Export only if !defined HAVE_XFT && def8ined
12505 HAVE_FREETYPE.
12506 * font.h (ftxfont_driver): Likewise.
12507
e4cebfca
PE
12508 * xfns.c: Make symbols static if they're not exported.
12509 (x_last_font_name, x_display_info_for_name):
12510 (x_set_foreground_color, x_set_background_color, x_set_mouse_color):
12511 (x_set_cursor_color, x_set_border_pixel, x_set_border_color):
12512 (x_set_cursor_type, x_set_icon_type, x_set_icon_name):
12513 (x_set_scroll_bar_foreground, x_set_scroll_bar_background):
12514 (x_explicitly_set_name, x_set_title, xic_defaut_fontset, tip_timer):
12515 (last_show_tip_args): Now static.
12516 (xic_defaut_fontset, xic_create_fontsetname): Define only if
12517 defined HAVE_X_WINDOWS && defined USE_X_TOOLKIT
12518 (x_screen_planes): Remove; unused.
12519 * dispextern.h (x_screen_planes): Remove decl.
12520
5bf46f05
PE
12521 * dispnew.c: Make symbols static if they're not exported.
12522 * dispextern.h (redraw_garbaged_frames, scrolling):
12523 (increment_row_positions): Remove.
12524 * dispnew.c (new_glyph_matrix, increment_row_positions, scrolling):
12525 (delayed_size_change, glyph_matrix_count, glyph_pool_count):
12526 Now static.
12527 (redraw_garbaged_frames): Remove; unused.
12528
435f4c28
PE
12529 * xfaces.c: Make symbols static if they're not exported.
12530 * dispextern.h (ascii_face_of_lisp_face, free_realized_face):
12531 Remove decls.
12532 * xterm.h (defined_color): Remove decls.
12533 (x_free_dpy_colors): Declare only if USE_X_TOOLKIT.
12534 * xfaces.c (tty_suppress_bold_inverse_default_colors_p):
12535 (menu_face_changed_default, defined_color, free_realized_face):
12536 (x_free_dpy_colors): Define only if USE_X_TOOLKIT.
12537 (ascii_face_of_lisp_face): Remove; unused.
12538
8524aef3
PE
12539 * xdisp.c: Make symbols static if they're not exported.
12540 * dispextern.h (scratch_glyph_row, window_box_edges):
12541 (glyph_to_pixel_coords, set_cursor_from_row):
12542 (get_next_display_element, set_iterator_to_next):
12543 (highlight_trailing_whitespace, frame_to_window_pixel_xy):
12544 (show_mouse_face): Remove decls
12545 * frame.h (message_buf_print): Likewise.
12546 * lisp.h (pop_message, set_message, check_point_in_composition):
12547 Likewise.
12548 * xterm.h (set_vertical_scroll_bar): Likewise.
12549 * xdisp.c (list_of_error, Vmessage_stack, line_number_displayed):
12550 (message_buf_print, scratch_glyph_row, displayed_buffer):
12551 (set_iterator_to_next, pop_message, set_message, set_cursor_from_row):
12552 (get_next_display_element, show_mouse_face, window_box_edges):
12553 (frame_to_window_pixel_xy, check_point_in_composition):
12554 (set_vertical_scroll_bar, highlight_trailing_whitespace): Now static.
12555 (glyph_to_pixel_coords): Remove; unused.
12556
16390cd2
PE
12557 * dired.c (file_name_completion): Now static.
12558
12559 * dbusbind.c (xd_in_read_queued_messages): Now static.
12560
a25f4dfa
PE
12561 * lisp.h (circular_list_error, FOREACH): Remove; unused.
12562 * data.c (circular_list_error): Remove.
12563
14a9c8df
PE
12564 * commands.h (last_point_position, last_point_position_buffer):
12565 (last_point_position_window): Remove decls.
12566 * keyboard.c: Make these variables static.
12567
04f2d78b
CB
12568 * coding.h (coding, code_convert_region, encode_coding_gap):
12569 Remove decls.
74ab6df5
PE
12570 * coding.c (Vsjis_coding_system, Vbig5_coding_system):
12571 (iso_code_class, detect_coding, code_convert_region): Now static.
12572 (encode_coding_gap): Remove; unused.
12573
38dfbee1
PE
12574 * chartab.c (chartab_chars, chartab_bits): Now static.
12575
a2cb4e63
PE
12576 * charset.h (charset_iso_8859_1): Remove decl.
12577 * charset.c (charset_iso_8859_1, charset_emacs, map_charset_for_dump):
12578 Now static.
12579
127198fd
PE
12580 * ccl.h (check_ccl_update, Vccl_program_table): Remove decls.
12581 * ccl.c (Vccl_program_table): Now static.
12582 (check_ccl_update): Remove; unused.
12583
d85b608f
PE
12584 * category.c (SET_CATEGORY_SET, set_category_set): Move here.
12585 * category.h: ... from here.
12586 * category.c (check_category_table, set_category_set): Now static.
12587
31cd66f3
PE
12588 * casetab.c (Vascii_upcase_table, Vascii_eqv_table): Now static.
12589 * lisp.h: Remove these decls.
12590
c358e587
PE
12591 * buffer.c (buffer_count): Remove unused var.
12592
e78aecca
PE
12593 * bidi.c (bidi_dump_cached_states): Mark as externally visible,
12594 so that it's not optimized away.
12595 (bidi_ignore_explicit_marks_for_paragraph_level): Likewise.
12596 * dispextern.h (bidi_dump_cached_states): Remove, since it's
12597 exported only to the debugger.
12598
e192d7d3 12599 * atimer.c (alarm_signal_handler, run_all_atimers): Now static.
04f2d78b 12600 * atimer.h (run_all_atimers): Remove; not exported.
e192d7d3 12601
92470028
PE
12602 font.c: Make copy_font_spec and merge_font_spec ordinary C functions.
12603 * font.c (copy_font_spec): Rename from Fcopy_font_spec, since it
12604 was inaccessible from Lisp.
12605 (merge_font_spec): Likewise, renaming from Fmerge_font_spec.
12606 * font.c, font.h, fontset.c, xfaces.c, xfont.c: Change all uses.
12607
244ed907
PE
12608 alloc.c: Import and export fewer symbols, and remove unused items.
12609 * lisp.h (suppress_checking, die): Declare only if ENABLE_CHECKING
12610 is defined.
12611 (suppress_checking): Add EXTERNALLY_VISIBLE attribute, so that
12612 it's not optimized away by whole-program optimization.
12613 (message_enable_multibyte, free_misc): Remove.
12614 (catchlist, handlerlist, mark_backtrace):
12615 Declare only if BYTE_MARK_STACK.
12616 (mark_byte_stack): Likewise, fixing a ifdef-vs-if typo.
12617 * alloc.c (pure): Export only if VIRT_ADDR_VARIES is defined.
12618 (message_enable_multibyte): Remove decl.
12619 (free_misc, interval_free_list, float_block, float_block_index):
12620 (n_float_blocks, float_free_list, cons_block, cons_block_index):
12621 (cons_free_list, last_marked_index):
12622 Now static.
12623 (suppress_checking, die): Define only if ENABLE_CHECKING is defined.
12624 * eval.c (catchlist, handlerlist): Export only if BYTE_MARK_STACK.
12625 (mark_backtrace): Define only if BYTE_MARK_STACK.
12626 * xdisp.c (message_enable_multibyte): Now static.
12627
61c2b50e 12628 Declare Lisp_Object Q* variables to be 'static' if not exported.
955cbe7b
PE
12629 This makes it easier for human readers (and static analyzers)
12630 to see whether these variables are used from other modules.
12631 * alloc.c, buffer.c, bytecode.c, callint.c, casetab.c, category.c:
12632 * ccl.c, character.c, charset.c, cmds.c, coding.c, composite.c:
12633 * data.c, dbusbind.c, dired.c, editfns.c, eval.c, fileio.c, fns.c:
12634 * font.c, frame.c, fringe.c, ftfont.c, image.c, keyboard.c, keymap.c:
12635 * lread.c, macros.c, minibuf.c, print.c, process.c, search.c:
12636 * sound.c, syntax.c, textprop.c, window.c, xdisp.c, xfaces.c, xfns.c:
12637 * xmenu.c, xselect.c:
12638 Declare Q* vars static if they are not used in other modules.
12639 * ccl.h, character.h, charset.h, coding.h, composite.h, font.h:
12640 * frame.h, intervals.h, keyboard.h, lisp.h, process.h, syntax.h:
12641 Remove decls of unexported vars.
12642 * keyboard.h (EVENT_HEAD_UNMODIFIED): Remove now-unused macro.
12643
95c82688
PE
12644 * lisp.h (DEFINE_FUNC): Make sname 'static'.
12645
16a97296
PE
12646 Make Emacs functions such as Fatom 'static' by default.
12647 This makes it easier for human readers (and static analyzers)
12648 to see whether these functions can be called from other modules.
12649 DEFUN now defines a static function. To make the function external
12650 so that it can be used in other C modules, use the new macro DEFUE.
8bd7b830
PE
12651 * lisp.h (Funibyte_char_to_multibyte, Fsyntax_table_p):
12652 (Finit_image_library):
16a97296
PE
12653 (Feval_region, Fbacktrace, Ffetch_bytecode, Fswitch_to_buffer):
12654 (Ffile_executable_p, Fmake_symbolic_link, Fcommand_execute):
12655 (Fget_process, Fdocumentation_property, Fbyte_code, Ffile_attributes):
12656 Remove decls, since these functions are now static.
12657 (Funintern, Fget_internal_run_time): New decls, since these functions
12658 were already external.
95c82688 12659
16a97296
PE
12660 * alloc.c, buffer.c, callint.c, callproc.c, casefiddle.c, casetab.c:
12661 * ccl.c, character.c, chartab.c, cmds.c, coding.c, data.c, dispnew.c:
12662 * doc.c, editfns.c, emacs.c, eval.c, fileio.c, filelock.c, floatfns.c:
12663 * fns.c, font.c, fontset.c, frame.c, image.c, indent.c:
12664 * keyboard.c, keymap.c, lread.c:
12665 * macros.c, marker.c, menu.c, minibuf.c, print.c, process.c, search.c:
12666 * syntax.c, term.c, terminal.c, textprop.c, undo.c:
12667 * window.c, xdisp.c, xfaces.c, xfns.c, xmenu.c, xsettings.c:
12668 Mark functions with DEFUE instead of DEFUN,
12669 if they are used in other modules.
12670 * buffer.c (Fset_buffer_major_mode, Fdelete_overlay): New forward
12671 decls for now-static functions.
12672 * buffer.h (Fdelete_overlay): Remove decl.
12673 * callproc.c (Fgetenv_internal): Mark as internal.
12674 * composite.c (Fremove_list_of_text_properties): Remove decl.
12675 (Fcomposition_get_gstring): New forward static decl.
12676 * composite.h (Fcomposite_get_gstring): Remove decl.
12677 * dired.c (Ffile_attributes): New forward static decl.
12678 * doc.c (Fdocumntation_property): New forward static decl.
12679 * eval.c (Ffetch_bytecode): New forward static decl.
12680 (Funintern): Remove extern decl; now in .h file where it belongs.
12681 * fileio.c (Fmake_symbolic_link): New forward static decl.
12682 * image.c (Finit_image_library): New forward static decl.
12683 * insdel.c (Fcombine_after_change_execute): Make forward decl static.
12684 * intervals.h (Fprevious_property_change):
12685 (Fremove_list_of_text_properties): Remove decls.
12686 * keyboard.c (Fthis_command_keys): Remove decl.
12687 (Fcommand_execute): New forward static decl.
12688 * keymap.c (Flookup_key): New forward static decl.
12689 (Fcopy_keymap): Now static.
12690 * keymap.h (Flookup_key): Remove decl.
12691 * process.c (Fget_process): New forward static decl.
12692 (Fprocess_datagram_address): Mark as internal.
12693 * syntax.c (Fsyntax_table_p): New forward static decl.
12694 (skip_chars): Remove duplicate decl.
12695 * textprop.c (Fprevious_property_change): New forward static decl.
12696 * window.c (Fset_window_fringes, Fset_window_scroll_bars):
12697 Now internal.
12698 (Fset_window_margins, Fset_window_vscroll): New forward static decls.
12699 * window.h (Fset_window_vscroll, Fset_window_margins): Remove decls.
12700
785bbd42
PE
12701 * editfns.c (Fformat): Remove unreachable code.
12702
8b913b57
AS
127032011-04-14 Andreas Schwab <schwab@linux-m68k.org>
12704
12705 * fileio.c (Finsert_file_contents): Fix typo in 2005-05-13
12706 change. (Bug#8496)
12707
a6744a35
EZ
127082011-04-13 Eli Zaretskii <eliz@gnu.org>
12709
12710 * xdisp.c (handle_invisible_prop): Don't call bidi_paragraph_init
12711 when at ZV. (Bug#8487)
12712
e7974947
AS
127132011-04-12 Andreas Schwab <schwab@linux-m68k.org>
12714
baad03f0
AS
12715 * charset.c (Fclear_charset_maps): Use xfree instead of free.
12716 (Bug#8437)
12717 * keyboard.c (parse_tool_bar_item): Likewise.
12718 * sound.c (sound_cleanup, alsa_close): Likewise.
12719 * termcap.c (tgetent): Likewise.
12720 * xfns.c (x_default_font_parameter): Likewise.
12721 * xsettings.c (read_and_apply_settings): Likewise.
12722
e7974947
AS
12723 * alloc.c (overrun_check_malloc, overrun_check_realloc)
12724 (overrun_check_free): Protoize.
12725
28272684
PE
127262011-04-12 Paul Eggert <eggert@cs.ucla.edu>
12727
12728 * sysdep.c (emacs_read, emacs_write): Check for negative sizes
12729 since callers should never pass a negative size.
12730 Change the signature to match that of plain 'read' and 'write'; see
12731 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00397.html>.
12732 * lisp.h: Update prototypes of emacs_write and emacs_read.
12733
11997c76
EZ
127342011-04-11 Eli Zaretskii <eliz@gnu.org>
12735
12736 * xdisp.c (redisplay_window): Don't try to determine the character
12737 position of the scroll margin if the window start point w->startp
e896f03c 12738 is outside the buffer's accessible region. (Bug#8468)
11997c76 12739
8a2cbd72
EZ
127402011-04-10 Eli Zaretskii <eliz@gnu.org>
12741
12742 Fix write-region and its subroutines for buffers > 2GB.
12743 * fileio.c (a_write, e_write): Modify declaration of arguments and
12744 local variables to support buffers larger than 2GB.
12745 (Fcopy_file): Use EMACS_INT for return value of emacs_read.
12746
12747 * sysdep.c (emacs_write, emacs_read): Use ssize_t for last
12748 argument, local variables, and return value.
12749
12750 * lisp.h: Update prototypes of emacs_write and emacs_read.
12751
12752 * sound.c (vox_write): Use ssize_t for return value of emacs_write.
12753
4073e537 127542011-04-10 Paul Eggert <eggert@cs.ucla.edu>
eb3f1cc8 12755
1ebfdcb6
PE
12756 * xdisp.c (vmessage): Use memchr, not strnlen, which some hosts lack.
12757
b2ded58d
PE
12758 Fix more problems found by GCC 4.6.0's static checks.
12759
7d66342c
PE
12760 * xdisp.c (vmessage): Use a better test for character truncation.
12761
bbf47d44
PE
12762 * charset.c (load_charset_map): <, not <=, for optimization,
12763 and to avoid potential problems with integer overflow.
9248994d 12764 * chartab.c (sub_char_table_set_range, char_table_set_range): Likewise.
f9a68bc5 12765 * casetab.c (set_identity, shuffle): Likewise.
3ab1c7ce 12766 * editfns.c (Fformat): Likewise.
1e69125e 12767 * syntax.c (skip_chars): Likewise.
3befa583 12768
e3019616
PE
12769 * xmenu.c (set_frame_menubar): Allocate smaller local vectors.
12770 This also lets GCC 4.6.0 generate slightly better loop code.
12771
becfa255
PE
12772 * callint.c (Fcall_interactively): <, not <=, for optimization.
12773 (Fcall_interactively): Count the number of arguments produced,
12774 not the number of arguments given. This is simpler and lets GCC
12775 4.6.0 generate slightly better code.
12776
dae0cd48
PE
12777 * ftfont.c: Distingish more carefully between FcChar8 and char.
12778 The previous code passed unsigned char * to a functions like
12779 strlen and xstrcasecmp that expect char *, which does not
12780 conform to the C standard.
12781 (get_adstyle_property, ftfont_pattern_entity): Use FcChar8 for
12782 arguments to FcPatternGetString, and explicitly cast FcChar8 * to
12783 char * when the C standard requires it.
12784
76032d70
PE
12785 * keyboard.c (read_char): Remove unused var.
12786
eb3f1cc8
PE
12787 * eval.c: Port to Windows vsnprintf (Bug#8435).
12788 Include <limits.h>.
12789 (SIZE_MAX): Define if the headers do not.
12790 (verror): Do not give up if vsnprintf returns a negative count.
12791 Instead, grow the buffer. This ports to Windows vsnprintf, which
12792 does not conform to C99. Problem reported by Eli Zaretskii.
12793 Also, simplify the allocation scheme, by avoiding the need for
12794 calling realloc, and removing the ALLOCATED variable.
12795
70476b54
PE
12796 * eval.c (verror): Initial buffer size is 4000 (not 200) bytes.
12797
12020a9e
PE
12798 Remove invocations of doprnt, as Emacs now uses vsnprintf.
12799 But keep the doprint source code for now, as we might revamp it
12800 and use it again (Bug#8435).
ea6c7ae6
PE
12801 * lisp.h (doprnt): Remove.
12802 * Makefile.in (base_obj): Remove doprnt.o.
12803 * deps.mk (doprnt.o): Remove.
12804
5fdb398c
PE
12805 error: Print 32- and 64-bit integers portably (Bug#8435).
12806 Without this change, on typical 64-bit hosts error ("...%d...", N)
12807 was used to print both 32- and 64-bit integers N, which relied on
12808 undefined behavior.
61bdb816 12809 * lisp.h, m/amdx86-64.h, m/ia64.h, m/ibms390x.h (pEd): New macro.
5fdb398c
PE
12810 * lisp.h (error, verror): Mark as printf-like functions.
12811 * eval.c (verror): Use vsnprintf, not doprnt, to do the real work.
12812 Report overflow in size calculations when allocating printf buffer.
12813 Do not truncate output string at its first null byte.
12814 * xdisp.c (vmessage): Use vsnprintf, not doprnt, to do the real work.
12815 Truncate the output at a character boundary, since vsnprintf does not
12816 do that.
12817 * charset.c (check_iso_charset_parameter): Convert internal
12818 character to string before calling 'error', since %c now has the
12819 printf meaning.
12820 * coding.c (Fdecode_sjis_char, Fdecode_big5_char): Avoid int
12821 overflow when computing char to be passed to 'error'. Do not
12822 pass Lisp_Object to 'error'; pass the integer instead.
12823 * nsfns.m (Fns_do_applescript): Use int, not long, since it's
12824 formatted with plain %d.
12825
b189fa66
PE
12826 * eval.c (internal_lisp_condition_case): Don't pass spurious arg.
12827
bff87ef0
PE
12828 * keyboard.c (access_keymap_keyremap): Print func name, not garbage.
12829
7e2cac20
PE
12830 * coding.c (Fdecode_sjis_char): Don't assume CODE fits in int.
12831
ce4d90b5
PE
12832 * xterm.c (x_catch_errors): Remove duplicate declaration.
12833
266c9547
PE
12834 * term.c (maybe_fatal): Mark its 3rd arg as a printf format, too.
12835
79c49ad2
PE
12836 * xdisp.c, lisp.h (message_nolog): Remove; unused.
12837
368f4090
JM
128382011-04-10 Jim Meyering <meyering@redhat.com>
12839
12840 use ssize_t and size_t for read- and write-like emacs_gnutls_* functions
12841 * gnutls.c (emacs_gnutls_read): Adjust signature to be more read-like:
12842 return ssize_t not "int", and use size_t as the buffer length.
12843 (emacs_gnutls_write): Likewise, and make the buffer pointer "const".
12844 * gnutls.h: Update declarations.
12845 * process.c (read_process_output): Use ssize_t, to match.
12846 (send_process): Likewise.
12847
a32d4040
CY
128482011-04-09 Chong Yidong <cyd@stupidchicken.com>
12849
12850 * image.c (Fimagemagick_types): Doc fix, and comment cleanup.
12851
8546720e 128522011-04-09 Chong Yidong <cyd@stupidchicken.com>
aac0c6e3 12853
04f2d78b
CB
12854 * ftfont.c (get_adstyle_property, ftfont_pattern_entity):
12855 Use unsigned char, to match FcChar8 type definition.
aac0c6e3 12856
8546720e
GM
12857 * xterm.c (handle_one_xevent):
12858 * xmenu.c (create_and_show_popup_menu):
12859 * xselect.c (x_decline_selection_request)
12860 (x_reply_selection_request): Avoid type-punned deref of X events.
aac0c6e3 12861
0a2f5c1a 128622011-04-09 Eli Zaretskii <eliz@gnu.org>
a53e2e89
EZ
12863
12864 Fix some uses of `int' instead of EMACS_INT.
12865 * search.c (string_match_1, fast_string_match)
12866 (fast_c_string_match_ignore_case, fast_string_match_ignore_case)
12867 (scan_buffer, find_next_newline_no_quit)
12868 (find_before_next_newline, search_command, Freplace_match)
12869 (Fmatch_data): Make some `int' variables be EMACS_INT.
12870
12871 * xdisp.c (display_count_lines): 3rd argument and return value now
12872 EMACS_INT. All callers changed.
12873 (pint2hrstr): Last argument is now EMACS_INT.
12874
12875 * coding.c (detect_coding_utf_8, detect_coding_emacs_mule)
12876 (detect_coding_iso_2022, detect_coding_sjis, detect_coding_big5)
12877 (detect_coding_ccl, detect_coding_charset, decode_coding_utf_8)
12878 (decode_coding_utf_16, decode_coding_emacs_mule)
12879 (decode_coding_iso_2022, decode_coding_sjis, decode_coding_big5)
12880 (decode_coding_ccl, decode_coding_charset)
12881 <consumed_chars, consumed_chars_base>: Declare EMACS_INT.
12882 (decode_coding_iso_2022, decode_coding_emacs_mule)
12883 (decode_coding_sjis, decode_coding_big5, decode_coding_charset)
12884 <char_offset, last_offset>: Declare EMACS_INT.
12885 (encode_coding_utf_8, encode_coding_utf_16)
12886 (encode_coding_emacs_mule, encode_invocation_designation)
12887 (encode_designation_at_bol, encode_coding_iso_2022)
12888 (encode_coding_sjis, encode_coding_big5, encode_coding_ccl)
12889 (encode_coding_raw_text, encode_coding_charset) <produced_chars>:
12890 Declare EMACS_INT.
12891 (ASSURE_DESTINATION): Declare more_bytes EMACS_INT.
12892 (encode_invocation_designation): Last argument P_NCHARS is now
12893 EMACS_INT.
12894 (decode_eol): Declare pos_byte, pos, and pos_end EMACS_INT.
12895 (produce_chars): from_nchars and to_nchars are now EMACS_INT.
12896
12897 * coding.h (struct coding_system) <head_ascii>: Declare EMACS_INT.
12898 All users changed.
12899
12900 * ccl.c (Fccl_execute_on_string): Declare some variables
12901 EMACS_INT.
12902
8546720e 129032011-04-08 Samuel Thibault <sthibault@debian.org> (tiny change)
0080dc6b
SS
12904
12905 * term.c (init_tty): Fix incorrect ifdef placement (Bug#8450).
12906
4e19a977
CS
129072011-03-19 Christoph Scholtes <cschol2112@googlemail.com>
12908
12909 * process.c (Fformat_network_address): Doc fix.
12910
87302331
R
129112011-04-08 T.V. Raman <tv.raman.tv@gmail.com> (tiny change)
12912
ee7683eb 12913 * xml.c (parse_region): Avoid creating spurious whitespace nodes.
87302331 12914
cbb59342
CY
129152011-04-08 Chong Yidong <cyd@stupidchicken.com>
12916
12917 * keyboard.c (read_char): Call Lisp function help-form-show,
12918 instead of using internal_with_output_to_temp_buffer.
12919 (Qhelp_form_show): New var.
e0d38eeb 12920 (syms_of_keyboard): Use DEFSYM macro.
cbb59342
CY
12921
12922 * print.c (internal_with_output_to_temp_buffer): Function deleted.
12923
12924 * lisp.h (internal_with_output_to_temp_buffer): Remove prototype.
12925
e67a13ab
CY
129262011-04-06 Chong Yidong <cyd@stupidchicken.com>
12927
04f2d78b
CB
12928 * process.c (Flist_processes): Remove to Lisp.
12929 (list_processes_1): Delete.
e67a13ab 12930
973f782d
EZ
129312011-04-06 Eli Zaretskii <eliz@gnu.org>
12932
7c106b1e
EZ
12933 * msdos.c (careadlinkat, careadlinkatcwd): MS-DOS replacements.
12934
973f782d
EZ
12935 * w32.c (careadlinkat, careadlinkatcwd): New always-fail stubs.
12936
41cf7d1a 129372011-04-06 Paul Eggert <eggert@cs.ucla.edu>
27ccc379 12938
ca23cc88
PE
12939 Fix more problems found by GCC 4.6.0's static checks.
12940
f390e2d5
PE
12941 * xmenu.c (Fx_popup_dialog): Don't assume string is free of formats.
12942
42eea0d0
PE
12943 * menu.c (Fx_popup_menu): Don't assume error_name lacks printf formats.
12944
b69769da 12945 * lisp.h (message, message_nolog, fatal): Mark as printf-like.
1e973bc7 12946
f9541e84
PE
12947 * xdisp.c (vmessage): Mark as a printf-like function.
12948
13841b55
PE
12949 * term.c (vfatal, maybe_fatal): Mark as printf-like functions.
12950
c136c10f
PE
12951 * sound.c (sound_warning): Don't crash if arg contains a printf format.
12952
5e2d4a30
PE
12953 * image.c (tiff_error_handler, tiff_warning_handler): Mark as
12954 printf-like functions.
12955 (tiff_load): Add casts to remove these marks before passing them
12956 to system-supplied API.
12957
583f48b9
PE
12958 * eval.c (Fsignal): Remove excess argument to 'fatal'.
12959
b25d760e
PE
12960 * coding.c (EMIT_ONE_BYTE, EMIT_TWO_BYTES): Use unsigned, not int.
12961 This avoids several warnings with gcc -Wstrict-overflow.
d5efd1d1
PE
12962 (DECODE_COMPOSITION_RULE): If the rule is invalid, goto invalid_code
12963 directly, rather than having caller test rule sign. This avoids
12964 some unnecessary tests.
12965 * composite.h (COMPOSITION_ENCODE_RULE_VALID): New macro.
12966 (COMPOSITION_ENCODE_RULE): Arguments now must be valid. This
12967 affects only one use, in DECODE_COMPOSITION_RULE, which is changed.
b25d760e 12968
bc7b6697 12969 * xfont.c (xfont_text_extents): Remove var that was set but not used.
625a3eb1 12970 (xfont_open): Avoid unnecessary tests.
bc7b6697 12971
27ccc379
PE
12972 * composite.c (composition_gstring_put_cache): Use unsigned integer.
12973
dcd5c89a
PE
12974 * composite.h, composite.c (composition_gstring_put_cache):
12975 Use EMACS_INT, not int, for length.
12976
b13a45c6
PE
12977 * composite.h (COMPOSITION_DECODE_REFS): New macro,
12978 breaking out part of COMPOSITION_DECODE_RULE.
12979 (COMPOSITION_DECODE_RULE): Use it.
12980 * composite.c (get_composition_id): Remove unused local vars,
12981 by using the new macro.
12982
1e792e4d
PE
12983 * textprop.c (set_text_properties_1): Change while to do-while,
12984 since the condition is always true at first.
12985
dc6c6455 12986 * intervals.c (graft_intervals_into_buffer): Mark var as used.
aa86731f
PE
12987 (interval_deletion_adjustment): Return unsigned value.
12988 All uses changed.
dc6c6455 12989
aba7731a
PE
12990 * process.c (list_processes_1, create_pty, read_process_output):
12991 (exec_sentinel): Remove vars that were set but not used.
afd4052b 12992 (create_pty): Remove unnecessary "volatile"s.
bc57d757 12993 (Fnetwork_interface_info): Avoid possibility of int overflow.
82eaa333 12994 (read_process_output): Do adaptive read buffering even if carryover.
fe07cdfa 12995 (read_process_output): Simplify nbytes computation if buffered.
aba7731a 12996
fdfc4bf3
PE
12997 * bytecode.c (exec_byte_code): Rename local to avoid shadowing.
12998
fca8fe46 12999 * syntax.c (scan_words): Remove var that was set but not used.
12cbf13f 13000 (update_syntax_table): Use unsigned instead of int.
fca8fe46 13001
06a0259a 13002 * lread.c (lisp_file_lexically_bound_p): Use ints rather than endptrs.
3c346cc3 13003 (lisp_file_lexically_bound_p, read1): Use unsigned instead of int.
e6eb4e9e 13004 (safe_to_load_p): Make the end-of-loop test the inverse of the in-loop.
06a0259a 13005
e7b9e80f
PE
13006 * print.c (print_error_message): Avoid int overflow.
13007
56201685
PE
13008 * font.c (font_list_entities): Redo for clarity,
13009 so that reader need not know FONT_DPI_INDEX + 1 == FONT_SPACING_INDEX.
13010
78834453 13011 * font.c (font_find_for_lface, Ffont_get_glyphs): Remove unused vars.
790771b1 13012 (font_score): Avoid potential overflow in diff calculation.
78834453 13013
0bc0b309 13014 * fns.c (substring_both): Remove var that is set but not used.
8cd55cb4 13015 (sxhash): Redo loop for clarity and to avoid wraparound warning.
0bc0b309 13016
e610eaca
PE
13017 * eval.c (funcall_lambda): Rename local to avoid shadowing.
13018
b895abce
PE
13019 * alloc.c (mark_object_loop_halt, mark_object): Use size_t, not int.
13020 Otherwise, GCC 4.6.0 optimizes the loop check away since the check
13021 can always succeed if overflow has undefined behavior.
13022
1f1d9321 13023 * search.c (boyer_moore, wordify): Remove vars set but not used.
6f076cc7 13024 (wordify): Omit three unnecessary tests.
1f1d9321 13025
c59478bc
PE
13026 * indent.c (MULTIBYTE_BYTES_WIDTH): Don't compute wide_column.
13027 All callers changed. This avoids the need for an unused var.
13028
79b73827
PE
13029 * casefiddle.c (casify_region): Remove var that is set but not used.
13030
a4db5dfe
PE
13031 * dired.c (file_name_completion): Remove var that is set but not used.
13032
43aae36e
PE
13033 * fileio.c (Finsert_file_contents): Make EOF condition clearer.
13034
2a47c44d 13035 * fileio.c (Finsert_file_contents): Avoid signed integer overflow.
163c5f32 13036 (Finsert_file_contents): Remove unnecessary code checking fd.
2a47c44d 13037
a37c69bf
PE
13038 * minibuf.c (read_minibuf_noninteractive): Use size_t for sizes.
13039 Check for integer overflow on size calculations.
13040
328ab8e7
PE
13041 * buffer.c (Fprevious_overlay_change): Remove var that is set
13042 but not used.
13043
e5a2a5cb
PE
13044 * keyboard.c (menu_bar_items, read_char_minibuf_menu_prompt):
13045 Remove vars that are set but not used.
8d84a6eb 13046 (timer_check_2): Don't assume timer-list and idle-timer-list are lists.
6b043475 13047 (timer_check_2): Mark vars as initialized.
e5a2a5cb 13048
a60e5f68
PE
13049 * gtkutil.c (xg_get_file_with_chooser): Mark var as initialized.
13050
f661cb61 13051 * image.c (lookup_image): Remove var that is set but not used.
35fa624f 13052 (xbm_load): Use parse_p, for gcc -Werror=unused-but-set-variable.
f661cb61 13053
f0397f5a
PE
13054 * fontset.c (Finternal_char_font, Ffontset_info): Remove vars
13055 that are set but not used.
13056
8664db06 13057 * xfns.c (make_invisible_cursor): Don't return garbage
03733ee7 13058 if XCreateBitmapFromData fails (Bug#8410).
8664db06 13059
6abdaa4a
PE
13060 * xselect.c (x_get_local_selection, x_handle_property_notify):
13061 Remove vars that are set but not used.
13062
0ce7538d 13063 * xfns.c (x_create_tip_frame): Remove var that is set but not used.
6abdaa4a 13064 (make_invisible_cursor): Initialize a possibly-uninitialized variable.
0ce7538d 13065
9ae848fc
PE
13066 * xterm.c (x_scroll_bar_to_input_event) [!USE_GTK]:
13067 Remove var that is set but not used.
0b918413
PE
13068 (scroll_bar_windows_size): Now size_t, not int.
13069 (x_send_scroll_bar_event): Use size_t, not int, for sizes.
13070 Check for overflow.
9ae848fc 13071
a5a62657
PE
13072 * xfaces.c (realize_named_face): Remove vars that are set but not used.
13073 (map_tty_color) [!defined MSDOS]: Likewise.
13074
5c5cdd39
PE
13075 * term.c (tty_write_glyphs): Use size_t; this avoids overflow warning.
13076
66ebf983
PE
13077 * coding.c: Remove vars that are set but not used.
13078 (DECODE_COMPOSITION_RULE): Remove 2nd arg, which is unused.
13079 All callers changed.
13080 (decode_coding_utf_8, decode_coding_utf_16 decode_coding_emacs_mule):
13081 (decode_coding_iso_2022, encode_coding_sjis, encode_coding_big5):
13082 (decode_coding_charset): Remove vars that are set but not used.
13083
1be4d761
PE
13084 * bytecode.c (Fbyte_code) [!defined BYTE_CODE_SAFE]: Remove var
13085 that is set but not used.
13086
47553fa8
PE
13087 * print.c (print_object): Remove var that is set but not used.
13088
1f7196bf 13089 Replace 2 copies of readlink code with 1 gnulib version (Bug#8401).
d1fdcab7
PE
13090 The gnulib version avoids calling malloc in the usual case,
13091 and on 64-bit hosts doesn't have some arbitrary 32-bit limits.
13092 * fileio.c (Ffile_symlink_p): Use emacs_readlink.
13093 * filelock.c (current_lock_owner): Likewise.
13094 * lisp.h (READLINK_BUFSIZE, emacs_readlink): New function.
13095 * sysdep.c: Include allocator.h, careadlinkat.h.
13096 (emacs_no_realloc_allocator): New static constant.
13097 (emacs_readlink): New function.
fdb61804
PE
13098 * deps.mk (sysdep.o): Depend on ../lib/allocator.h and on
13099 ../lib/careadlinkat.h.
d1fdcab7 13100
f84c17c7
SM
131012011-04-04 Stefan Monnier <monnier@iro.umontreal.ca>
13102
13103 * keyboard.c (safe_run_hook_funcall): Fix last change (don't stop at the
13104 first non-nil return value).
13105
ef3862ad
JD
131062011-04-03 Jan Djärv <jan.h.d@swipnet.se>
13107
13108 * nsterm.m (ns_update_auto_hide_menu_bar): Define MAC_OS_X_VERSION_10_6
13109 if not defined (Bug#8403).
13110
376a7006
JB
131112011-04-02 Juanma Barranquero <lekktu@gmail.com>
13112
13113 * xdisp.c (display_count_lines): Remove parameter `start',
13114 unused since 1998-01-01T02:27:27Z!rms@gnu.org. All callers changed.
13115 (get_char_face_and_encoding): Remove parameter `multibyte_p',
13116 unused since 2008-05-14T01:40:23Z!handa@m17n.org. All callers changed.
13117 (fill_stretch_glyph_string): Remove parameters `row' and `area',
13118 unused at least since Kim's GUI unification at 2003-03-16T20:45:46Z!storm@cua.dk
13119 and thereabouts. All callers changed.
13120 (get_per_char_metric): Remove parameter `f', unused since
13121 2008-05-14T01:40:23Z!handa@m17n.org. All callers changed.
13122
6ca3801d
JM
131232011-04-02 Jim Meyering <meyering@redhat.com>
13124
13125 do not dereference NULL upon failed strdup
13126 * nsfont.m (ns_descriptor_to_entity): Use xstrdup, not strdup.
13127 (ns_get_family): Likewise.
13128
d8e2b5ba
JB
131292011-04-02 Juanma Barranquero <lekktu@gmail.com>
13130
13131 * eval.c (unwind_to_catch) [DEBUG_GCPRO]: Remove redundant assignment.
13132
8c74fcbd
JD
131332011-04-02 Jan Djärv <jan.h.d@swipnet.se>
13134
13135 * nsterm.m (ns_update_auto_hide_menu_bar): Only for OSX 10.6 or
13136 later (Bug#8403).
13137
7200d79c
SM
131382011-04-01 Stefan Monnier <monnier@iro.umontreal.ca>
13139
03408648 13140 Add lexical binding.
7200d79c 13141
03408648
SM
13142 * window.c (Ftemp_output_buffer_show): New fun.
13143 (Fsave_window_excursion):
13144 * print.c (Fwith_output_to_temp_buffer): Move to subr.el.
13145
13146 * lread.c (lisp_file_lexically_bound_p): New function.
13147 (Fload): Bind Qlexical_binding.
13148 (readevalloop): Remove `evalfun' arg.
13149 Bind Qinternal_interpreter_environment.
13150 (Feval_buffer): Bind Qlexical_binding.
13151 (defvar_int, defvar_bool, defvar_lisp_nopro, defvar_kboard):
13152 Mark as dynamic.
13153 (syms_of_lread): Declare `lexical-binding'.
13154
13155 * lisp.h (struct Lisp_Symbol): New field `declared_special'.
13156
13157 * keyboard.c (eval_dyn): New fun.
13158 (menu_item_eval_property): Use it.
ca105506
SM
13159
13160 * image.c (parse_image_spec): Use Ffunctionp.
ca105506 13161
03408648
SM
13162 * fns.c (concat, mapcar1): Accept byte-code-functions.
13163
13164 * eval.c (Fsetq): Handle lexical vars.
13165 (Fdefun, Fdefmacro, Ffunction): Make closures when needed.
13166 (Fdefconst, Fdefvaralias, Fdefvar): Mark as dynamic.
13167 (FletX, Flet): Obey lexical binding.
13168 (Fcommandp): Handle closures.
13169 (Feval): New `lexical' arg.
13170 (eval_sub): New function extracted from Feval. Use it almost
13171 everywhere where Feval was used. Look up vars in lexical env.
13172 Handle closures.
13173 (Ffunctionp): Move from subr.el.
13174 (Ffuncall): Handle closures.
13175 (apply_lambda): Remove `eval_flags'.
13176 (funcall_lambda): Handle closures and new byte-code-functions.
13177 (Fspecial_variable_p): New function.
13178 (syms_of_eval): Initialize the Vinternal_interpreter_environment var,
13179 but without exporting it to Lisp.
23aba0ea 13180
23aba0ea 13181 * doc.c (Fdocumentation, store_function_docstring):
03408648 13182 * data.c (Finteractive_form): Handle closures.
23aba0ea 13183
03408648
SM
13184 * callint.c (Fcall_interactively): Preserve lexical-binding mode for
13185 interactive spec.
ba83908c 13186
04f2d78b
CB
13187 * bytecode.c (Bstack_ref, Bstack_set, Bstack_set2, BdiscardN):
13188 New byte-codes.
03408648
SM
13189 (exec_byte_code): New function extracted from Fbyte_code to handle new
13190 calling convention for byte-code-functions. Add new byte-codes.
ba83908c 13191
03408648 13192 * buffer.c (defvar_per_buffer): Set new `declared_special' field.
e2abe5a1 13193
03408648 13194 * alloc.c (Fmake_symbol): Init new `declared_special' field.
e2abe5a1 13195
e2abce01
JB
131962011-03-31 Juanma Barranquero <lekktu@gmail.com>
13197
13198 * xdisp.c (redisplay_internal): Fix prototype.
13199
63696a73 132002011-03-31 Eli Zaretskii <eliz@gnu.org>
09725d26 13201
63696a73 13202 * xdisp.c (SCROLL_LIMIT): New macro.
04f2d78b
CB
13203 (try_scrolling): Use it when setting scroll_limit.
13204 Limit scrolling to 100 screen lines.
63696a73
EZ
13205 (redisplay_window): Even when falling back on "recentering",
13206 position point in the window according to scroll-conservatively,
13207 scroll-margin, and scroll-*-aggressively variables. (Bug#6671)
13208
13209 (try_scrolling): When point is above the window, allow searching
13210 as far as scroll_max, or one screenful, to compute vertical
13211 distance from PT to the scroll margin position. This prevents
13212 try_scrolling from unnecessarily failing when
13213 scroll-conservatively is set to a value slightly larger than the
13214 window height. Clean up the case of PT below the margin at bottom
13215 of window: scroll_max can no longer be INT_MAX. When aggressive
13216 scrolling is in use, don't let point enter the opposite scroll
13217 margin as result of the scroll.
13218 (syms_of_xdisp) <scroll-conservatively>: Document the
09725d26
EZ
13219 threshold of 100 lines for never-recentering scrolling.
13220
e4cc2dfc
JB
132212011-03-31 Juanma Barranquero <lekktu@gmail.com>
13222
13223 * dispextern.h (move_it_by_lines):
13224 * xdisp.c (move_it_by_lines): Remove parameter `need_y_p', unused
13225 since 2000-12-29T14:24:09Z!gerd@gnu.org. All callers changed.
13226 (message_log_check_duplicate): Remove parameters `prev_bol' and
13227 `this_bol', unused since 1998-01-01T02:27:27Z!rms@gnu.org. All callers changed.
13228 (redisplay_internal): Remove parameter `preserve_echo_area',
13229 unused since 1999-07-21T21:43:52Z!gerd@gnu.org. All callers changed.
13230
13231 * indent.c (Fvertical_motion):
13232 * window.c (window_scroll_pixel_based, Frecenter):
13233 Don't pass `need_y_p' to `move_it_by_lines'.
13234
1c470562
SM
132352011-03-30 Stefan Monnier <monnier@iro.umontreal.ca>
13236
44f230aa
SM
13237 * eval.c (struct backtrace): Don't cheat with negative numbers, but do
13238 steal a few bits to be more compact.
13239 (interactive_p, Fbacktrace, Fbacktrace_frame, mark_backtrace):
13240 Remove unneeded casts.
13241
1c470562
SM
13242 * bytecode.c (Fbyte_code): CAR and CDR can GC.
13243
888adce9
ZK
132442011-03-30 Zachary Kanfer <zkanfer@gmail.com> (tiny change)
13245
13246 * keyboard.c (Fexecute_extended_command): Do log the "suggest key
13247 binding" message (bug#7967).
13248
f838ed7b
PE
132492011-03-30 Paul Eggert <eggert@cs.ucla.edu>
13250
77861b95
PE
13251 Fix more problems found by GCC 4.6.0's static checks.
13252
de6dbc14
PE
13253 * unexelf.c (unexec) [! (defined _SYSTYPE_SYSV || defined __sgi)]:
13254 Remove unused local var.
13255
f838ed7b
PE
13256 * editfns.c (Fmessage_box): Remove unused local var.
13257
792c7b2b
PE
13258 * xdisp.c (try_window_reusing_current_matrix, x_produce_glyphs):
13259 (note_mode_line_or_margin_highlight, note_mouse_highlight):
13260 Omit unused local vars.
c499e557 13261 * window.c (shrink_windows): Omit unused local var.
b01a1c29 13262 * menu.c (digest_single_submenu): Omit unused local var.
0bc32927
PE
13263 * dispnew.c (update_window) [PERIODIC_PREEMPTION_CHECKING]:
13264 Omit unused local var.
13265
ba0165e1
PE
13266 * keyboard.c (parse_modifiers_uncached, parse_modifiers):
13267 Don't assume string length fits in int.
32ad8845 13268 (keyremap_step, read_key_sequence): Use size_t for sizes.
48011560 13269 (read_key_sequence): Don't check last_real_key_start redundantly.
ba0165e1 13270
3c59b4c9
PE
13271 * callproc.c (Fcall_process, Fcall_process_region): Use SAFE_ALLOCA
13272 instead of alloca (Bug#8344).
13273
a3eed478 13274 * eval.c (Fbacktrace): Don't assume nargs fits in int.
5d5d959d 13275 (Fbacktrace_frame): Don't assume nframes fits in int.
a3eed478 13276
eb4d412d
PE
13277 * syntax.c (scan_sexps_forward): Avoid pointer wraparound.
13278
1658b401
PE
13279 * xterm.c (x_make_frame_visible, same_x_server): Redo to avoid overflow
13280 concerns.
13281
13282 * term.c (produce_glyphless_glyph): Remove unnecessary test.
13283
13284 * cm.c (calccost): Turn while-do into do-while, for clarity.
44f730c8 13285
9a2c6e05
PE
13286 * keyboard.c (syms_of_keyboard): Use the same style as later
13287 in this function when indexing through an array. This also
13288 works around GCC bug 48267.
13289
03d0a109
PE
13290 * image.c (tiff_load): Fix off-by-one image count (Bug#8336).
13291
44f730c8
PE
13292 * xselect.c (x_check_property_data): Return correct size (Bug#8335).
13293
fe75f926
PE
13294 * chartab.c (sub_char_table_ref_and_range): Redo for slight
13295 efficiency gain, and to bypass a gcc -Wstrict-overflow warning.
13296
ffa8c828
PE
13297 * keyboard.c, keyboard.h (num_input_events): Now size_t.
13298 This avoids undefined behavior on integer overflow, and is a bit
13299 more convenient anyway since it is compared to a size_t variable.
13300
c5101a77
PE
13301 Variadic C functions now count arguments with size_t, not int.
13302 This avoids an unnecessary limitation on 64-bit machines, which
13303 caused (substring ...) to crash on large vectors (Bug#8344).
13304 * lisp.h (struct Lisp_Subr.function.aMANY): Now takes size_t, not int.
13305 (DEFUN_ARGS_MANY, internal_condition_case_n, safe_call): Likewise.
77861b95 13306 All variadic functions and their callers changed accordingly.
c5101a77
PE
13307 (struct gcpro.nvars): Now size_t, not int. All uses changed.
13308 * data.c (arith_driver, float_arith_driver): Likewise.
13309 * editfns.c (general_insert_function): Likewise.
13310 * eval.c (struct backtrace.nargs, interactive_p)
13311 (internal_condition_case_n, run_hook_with_args, apply_lambda)
13312 (funcall_lambda, mark_backtrace): Likewise.
13313 * fns.c (concat): Likewise.
13314 * frame.c (x_set_frame_parameters): Likewise.
13315 * fns.c (get_key_arg): Now accepts and returns size_t, and returns
13316 0 if not found, not -1. All callers changed.
13317
dd3f25f7
PE
13318 * alloc.c (garbage_collect): Don't assume stack size fits in int.
13319 (stack_copy_size): Now size_t, not int.
13320 (stack_copy, stack_copy_size): Define only if MAX_SAVE_STACK > 0.
13321
461c2ab9
JB
133222011-03-28 Juanma Barranquero <lekktu@gmail.com>
13323
13324 * coding.c (encode_designation_at_bol): Remove parameter `charbuf_end',
13325 unused since 2002-03-01T01:17:24Z!handa@m17n.org and 2008-02-01T16:01:31Z!miles@gnu.org.
13326 All callers changed.
13327
13328 * lisp.h (multibyte_char_to_unibyte):
13329 * character.c (multibyte_char_to_unibyte): Remove parameter `rev_tbl',
13330 unused since 2002-03-01T01:16:34Z!handa@m17n.org and 2008-02-01T16:01:31Z!miles@gnu.org.
13331 * character.h (CHAR_TO_BYTE8):
13332 * cmds.c (internal_self_insert):
13333 * editfns.c (general_insert_function):
13334 * keymap.c (push_key_description):
13335 * search.c (Freplace_match):
13336 * xdisp.c (message_dolog, set_message_1): All callers changed.
13337
f6d62986
SM
133382011-03-28 Stefan Monnier <monnier@iro.umontreal.ca>
13339
13340 * keyboard.c (safe_run_hook_funcall): New function.
13341 (safe_run_hooks_1, safe_run_hooks_error, safe_run_hooks): On error,
13342 don't set the hook to nil, but remove the offending function instead.
13343 (Qcommand_hook_internal): Remove, unused.
13344 (syms_of_keyboard): Don't initialize Qcommand_hook_internal nor define
13345 Vcommand_hook_internal.
13346
13347 * eval.c (enum run_hooks_condition): Remove.
13348 (funcall_nil, funcall_not): New functions.
13349 (run_hook_with_args): Call each function through a `funcall' argument.
13350 Remove `cond' argument, now redundant.
13351 (Frun_hooks, Frun_hook_with_args, Frun_hook_with_args_until_success)
13352 (Frun_hook_with_args_until_failure): Adjust accordingly.
13353 (run_hook_wrapped_funcall, Frun_hook_wrapped): New functions.
13354
1db5b1ad
JB
133552011-03-28 Juanma Barranquero <lekktu@gmail.com>
13356
13357 * dispextern.h (string_buffer_position): Remove declaration.
13358
13359 * print.c (strout): Remove parameter `multibyte', unused since
13360 1999-08-21T19:30:21Z!gerd@gnu.org. All callers changed.
13361
13362 * search.c (boyer_moore): Remove parameters `len', `pos' and `lim',
13363 never used since function introduction in 1998-02-08T21:33:56Z!rms@gnu.org.
13364 All callers changed.
13365
13366 * w32.c (_wsa_errlist): Use braces for struct initializers.
13367
13368 * xdisp.c (string_buffer_position_lim): Remove parameter `w',
13369 never used since function introduction in 2001-03-09T18:41:50Z!gerd@gnu.org.
13370 All callers changed.
13371 (string_buffer_position): Likewise. Also, make static (it's never
13372 used outside xdisp.c).
13373 (cursor_row_p): Remove parameter `w', unused since
13374 2000-10-17T16:08:57Z!gerd@gnu.org. All callers changed.
13375 (decode_mode_spec): Remove parameter `precision', introduced during
13376 Gerd Moellmann's rewrite at 1999-07-21T21:43:52Z!gerd@gnu.org, but never used.
13377 All callers changed.
13378
5ffb62aa
JD
133792011-03-27 Jan Djärv <jan.h.d@swipnet.se>
13380
13381 * nsterm.m (syms_of_nsterm): Use doc: for ns-auto-hide-menu-bar.
13382
461c2ab9 133832011-03-27 Anders Lindgren <andlind@gmail.com>
f0a1382a
JD
13384
13385 * nsterm.m (ns_menu_bar_is_hidden): New variable.
13386 (ns_constrain_all_frames, ns_menu_bar_should_be_hidden)
13387 (ns_update_auto_hide_menu_bar): New functions.
13388 (ns_update_begin): Call ns_update_auto_hide_menu_bar.
13389 (applicationDidBecomeActive): Call ns_update_auto_hide_menu_bar and
13390 ns_constrain_all_frames.
13391 (constrainFrameRect): Return at once if ns_menu_bar_should_be_hidden.
13392 (syms_of_nsterm): DEFVAR ns-auto-hide-menu-bar, init to Qnil.
13393
5c380ffb
JD
133942011-03-27 Jan Djärv <jan.h.d@swipnet.se>
13395
13396 * nsmenu.m (runDialogAt): Remove argument to timer_check.
13397
9af30bdf
GM
133982011-03-27 Glenn Morris <rgm@gnu.org>
13399
13400 * syssignal.h: Replace RETSIGTYPE with void.
13401 * atimer.c, data.c, dispnew.c, emacs.c, floatfns.c, keyboard.c:
13402 * keyboard.h, lisp.h, process.c, sysdep.c, xterm.c:
13403 Replace SIGTYPE with void everywhere.
13404 * s/usg5-4-common.h (SIGTYPE): Remove definition.
13405 * s/template.h (SIGTYPE): Remove commented out definition.
13406
e2abce01
JB
134072011-03-26 Eli Zaretskii <eliz@gnu.org>
13408
13409 * xdisp.c (redisplay_window): Don't check buffer's clip_changed
13410 flag as a prerequisite for invoking try_scrolling. (Bug#6671)
13411
f868cd8a
JB
134122011-03-26 Juanma Barranquero <lekktu@gmail.com>
13413
59eb0929
JB
13414 * w32.c (read_unc_volume): Use parameter `henum', instead of
13415 global variable `wget_enum_handle'.
13416
13417 * keymap.c (describe_vector): Remove parameters `indices' and
13418 `char_table_depth', unused since 2002-03-01T01:43:26Z!handa@m17n.org.
13419 (describe_map, Fdescribe_vector): Adjust calls to `describe_vector'.
13420
f868cd8a
JB
13421 * keyboard.h (timer_check, show_help_echo): Remove unused parameters.
13422
13423 * keyboard.c (timer_check): Remove parameter `do_it_now',
13424 unused since 1996-04-12T06:01:29Z!rms@gnu.org.
13425 (show_help_echo): Remove parameter `ok_to_overwrite_keystroke_echo',
13426 unused since 2008-04-19T19:30:53Z!monnier@iro.umontreal.ca.
13427
13428 * keyboard.c (read_char):
13429 * w32menu.c (w32_menu_display_help):
13430 * xmenu.c (show_help_event, menu_help_callback):
13431 Adjust calls to `show_help_echo'.
13432
13433 * gtkutil.c (xg_maybe_add_timer):
13434 * keyboard.c (readable_events):
13435 * process.c (wait_reading_process_output):
13436 * xmenu.c (x_menu_wait_for_event): Adjust calls to `timer_check'.
13437
13438 * insdel.c (adjust_markers_gap_motion):
13439 Remove; no-op since 1998-01-02T21:29:48Z!rms@gnu.org.
13440 (gap_left, gap_right): Don't call it.
13441
2ecf6fdb
CY
134422011-03-25 Chong Yidong <cyd@stupidchicken.com>
13443
13444 * xdisp.c (handle_fontified_prop): Discard changes to clip_changed
13445 incurred during fontification.
13446
6b1f9ba4
JB
134472011-03-25 Juanma Barranquero <lekktu@gmail.com>
13448
13449 * buffer.c (defvar_per_buffer): Remove unused parameter `doc'.
13450 (DEFVAR_PER_BUFFER): Don't pass it.
13451
13452 * dispnew.c (row_equal_p, add_row_entry): Remove unused parameter `w'.
13453 (scrolling_window): Don't pass it.
13454
0f4a96b5
JB
134552011-03-25 Juanma Barranquero <lekktu@gmail.com>
13456
13457 * dispextern.h (glyph_matric): Use #if GLYPH_DEBUG, not #ifdef.
13458
13459 * fileio.c (check_executable) [DOS_NT]: Remove unused variables `len'
13460 and `suffix'.
13461 (Fset_file_selinux_context) [HAVE_LIBSELINUX]: Move here declaration
13462 of variables specific to SELinux and computation of `encoded_absname'.
13463
13464 * image.c (XPutPixel): Remove unused variable `height'.
13465
13466 * keyboard.c (make_lispy_event): Remove unused variable `hpos'.
13467
13468 * unexw32.c (get_section_info): Remove unused variable `section'.
13469
13470 * w32.c (stat): Remove unused variables `drive_root' and `devtype'.
13471 (system_process_attributes): Remove unused variable `sess'.
13472 (sys_read): Remove unused variable `err'.
13473
13474 * w32fns.c (top): Wrap variables with #if GLYPH_DEBUG, not #ifdef.
13475 (w32_wnd_proc): Remove unused variable `isdead'.
13476 (unwind_create_frame): Use #if GLYPH_DEBUG, not #ifdef.
13477 (Fx_server_max_request_size): Remove unused variable `dpyinfo'.
13478 (x_create_tip_frame): Remove unused variable `tem'.
13479
13480 * w32inevt.c (w32_console_read_socket):
13481 Remove unused variable `no_events'.
13482
13483 * w32term.c (x_draw_composite_glyph_string_foreground):
13484 Remove unused variable `width'.
13485
1149507c
JB
134862011-03-24 Juanma Barranquero <lekktu@gmail.com>
13487
13488 * w32term.c (x_set_glyph_string_clipping):
13489 Don't pass uninitialized region to CombineRgn.
13490
9c88f339
JB
134912011-03-23 Juanma Barranquero <lekktu@gmail.com>
13492
13493 * w32fns.c (x_set_menu_bar_lines): Remove unused variable `olines'.
13494 (w32_wnd_proc): Pass NULL to Windows API, not uninitialized buffer.
13495 (Fx_close_connection): Remove unused variable `i'.
13496
13497 * w32font.c (w32font_draw): Return number of glyphs.
13498 (w32font_open_internal): Remove unused variable `i'.
13499 (w32font_driver): Add missing initializer.
13500
13501 * w32menu.c (utf8to16): Remove unused variable `utf16'.
13502 (fill_in_menu): Remove unused variable `items_added'.
13503
13504 * w32term.c (last_mouse_press_frame): Remove static global variable.
13505 (w32_clip_to_row): Remove unused variable `f'.
13506 (x_delete_terminal): Remove unused variable `i'.
13507
13508 * w32uniscribe.c (uniscribe_shape): Remove unused variable `nclusters'.
13509 (NOTHING): Remove unused static global variable.
13510 (uniscribe_check_otf): Remove unused variable `table'.
13511 (uniscribe_font_driver): Add missing initializers.
13512
dee091a3
JD
135132011-03-23 Julien Danjou <julien@danjou.info>
13514
13515 * term.c (Fsuspend_tty, Fresume_tty):
13516 * minibuf.c (read_minibuf, run_exit_minibuf_hook):
13517 * window.c (temp_output_buffer_show):
13518 * insdel.c (signal_before_change):
13519 * frame.c (Fhandle_switch_frame):
13520 * fileio.c (Fdo_auto_save):
13521 * emacs.c (Fkill_emacs):
13522 * editfns.c (save_excursion_restore):
13523 * cmds.c (internal_self_insert):
13524 * callint.c (Fcall_interactively):
13525 * buffer.c (Fkill_all_local_variables):
13526 * keyboard.c (Fcommand_execute, Fsuspend_emacs, safe_run_hooks_1):
13527 Use Frun_hooks.
0f4a96b5 13528 (command_loop_1): Use Frun_hooks. Call safe_run_hooks
e9fce1ac 13529 unconditionally since it does the check itself.
dee091a3 13530
2c520ab5 135312011-03-23 Paul Eggert <eggert@cs.ucla.edu>
f0641eff 13532
c9c49752
PE
13533 Fix more problems found by GCC 4.5.2's static checks.
13534
8abc3f12
PE
13535 * coding.c (encode_coding_raw_text): Avoid unnecessary test
13536 the first time through the loop, since we know p0 < p1 then.
13537 This also avoids a gcc -Wstrict-overflow warning.
13538
a2d26660
PE
13539 * lisp.h (SAFE_ALLOCA, SAFE_ALLOCA_LISP): Avoid 'int' overflow
13540 leading to a memory leak, possible in functions like
13541 load_charset_map_from_file that can allocate an unbounded number
b12ef411 13542 of objects (Bug#8318).
a2d26660 13543
916c72e9
PE
13544 * xmenu.c (set_frame_menubar): Use EMACS_UINT, not int, for indexes
13545 that could (at least in theory) be that large.
13546
19ab8a18
PE
13547 * xdisp.c (message_log_check_duplicate): Return unsigned long, not int.
13548 This is less likely to overflow, and avoids undefined behavior if
13549 overflow does occur. All callers changed. Use strtoul to scan
13550 for the unsigned long integer.
b7cbbd6f
PE
13551 (pint2hrstr): Simplify and tune code slightly.
13552 This also avoids a (bogus) GCC warning with gcc -Wstrict-overflow.
19ab8a18 13553
f0641eff
PE
13554 * scroll.c (do_scrolling): Work around GCC bug 48228.
13555 See <http://gcc.gnu.org/bugzilla/show_bug.cgi?id=48228>.
13556
7f650bb9
PE
13557 * frame.c (Fmodify_frame_parameters): Simplify loop counter.
13558 This also avoids a warning with gcc -Wstrict-overflow.
39f5e519
PE
13559 (validate_x_resource_name): Simplify count usage.
13560 This also avoids a warning with gcc -Wstrict-overflow.
7f650bb9 13561
37dd57d1
PE
13562 * fileio.c (Fcopy_file): Report error if fchown or fchmod
13563 fail (Bug#8306).
81e56e61 13564
699979fc 13565 * emacs.c (Fdaemon_initialized): Do not ignore I/O errors (Bug#8303).
dc1ca6a8 13566
401bf9b4
PE
13567 * process.c (Fmake_network_process): Use socklen_t, not int,
13568 where POSIX says socklen_t is required in portable programs.
13569 This fixes a porting bug on hosts like 64-bit HP-UX, where
591b2973 13570 socklen_t is wider than int (Bug#8277).
401bf9b4
PE
13571 (Fmake_network_process, server_accept_connection):
13572 (wait_reading_process_output, read_process_output):
13573 Likewise.
13574
b93aacde
PE
13575 * process.c: Rename or move locals to avoid shadowing.
13576 (list_processes_1, Fmake_network_process):
13577 (read_process_output_error_handler, exec_sentinel_error_handler):
13578 Rename or move locals.
4dc343ee 13579 (Fmake_network_process): Define label "retry_connect" only if needed.
0da49335 13580 (Fnetwork_interface_info): Fix pointer signedness.
f990b4e5 13581 (process_send_signal): Add cast to avoid pointer signedness problem.
7b808126 13582 (FIRST_PROC_DESC, IF_NON_BLOCKING_CONNECT): Remove unused macros.
c939f91b 13583 (create_process): Use 'volatile' to avoid vfork clobbering (Bug#8298).
b93aacde 13584
af8a867c 13585 Make tparam.h and terminfo.c consistent.
44f230aa
SM
13586 * cm.c (tputs, tgoto, BC, UP): Remove extern decls.
13587 Include tparam.h instead, since it declares them.
af8a867c
PE
13588 * cm.h (PC): Remove extern decl; tparam.h now does this.
13589 * deps.mk (cm.o, terminfo.o): Depend on tparam.h.
13590 * terminfo.c: Include tparam.h, to check interfaces.
13591 (tparm): Make 1st arg a const pointer in decl. Put it at top level.
13592 (tparam): Adjust signature to match interface in tparam.h;
13593 this removes some undefined behavior. Check that outstring and len
13594 are zero, which they always are with Emacs.
13595 * tparam.h (PC, BC, UP): New extern decls.
13596
0248044d 13597 * xftfont.c (xftfont_shape): Now static, and defined only if needed.
001a7ab4 13598 (xftfont_open): Rename locals to avoid shadowing.
0248044d 13599
8ff096c1 13600 * ftfont.c (ftfont_resolve_generic_family): Fix pointer signedness.
a00924bb
PE
13601 (ftfont_otf_capability, ftfont_shape): Omit decls if not needed.
13602 (OTF_TAG_SYM): Omit macro if not needed.
e932860f 13603 (ftfont_list): Remove unused local.
49eaafba
PE
13604 (get_adstyle_property, ftfont_pattern_entity):
13605 (ftfont_lookup_cache, ftfont_open, ftfont_anchor_point):
13606 Rename locals to avoid shadowing.
8ff096c1 13607
e2be39f6
PE
13608 * xfont.c (xfont_list_family): Mark var as initialized.
13609
c9735e30
PE
13610 * xml.c (make_dom): Now static.
13611
8f5201ae
PE
13612 * composite.c (composition_compute_stop_pos): Rename local to
13613 avoid shadowing.
b246f932
PE
13614 (composition_reseat_it): Remove unused locals.
13615 (find_automatic_composition, composition_adjust_point): Likewise.
80e079b2 13616 (composition_update_it): Mark var as initialized.
11b61122
PE
13617 (find_automatic_composition): Mark vars as initialized,
13618 with a FIXME (Bug#8290).
8f5201ae 13619
760fbc2c
PE
13620 character.h: Rename locals to avoid shadowing.
13621 * character.h (PREV_CHAR_BOUNDARY, FETCH_STRING_CHAR_ADVANCE):
13622 (FETCH_STRING_CHAR_AS_MULTIBYTE_ADVANCE, FETCH_CHAR_ADVANCE):
13623 (FETCH_CHAR_ADVANCE_NO_CHECK, INC_POS, DEC_POS, BUF_INC_POS):
13624 (BUF_DEC_POS): Be more systematic about renaming local temporaries
13625 to avoid shadowing.
13626
ff08eb85
PE
13627 * textprop.c (property_change_between_p): Remove; unused.
13628
fc7bf025
PE
13629 * intervals.c (interval_start_pos): Now static.
13630
235d7abc
PE
13631 * intervals.h (CHECK_TOTAL_LENGTH): Avoid empty "else".
13632
44f230aa
SM
13633 * atimer.c (start_atimer, append_atimer_lists, set_alarm):
13634 Rename locals to avoid shadowing.
3e7d6594 13635
50060332
PE
13636 * sound.c (wav_play, au_play, Fplay_sound_internal):
13637 Fix pointer signedness.
d01f234b 13638 (alsa_choose_format): Remove unused local var.
c83b8872
PE
13639 (wav_play): Initialize a variable to 0, to prevent undefined
13640 behavior (Bug#8278).
50060332 13641
c4fc4e30
PE
13642 * region-cache.c (insert_cache_boundary): Redo var to avoid shadowing.
13643
918436ed
PE
13644 * region-cache.h (pp_cache): New decl, for gcc -Wmissing-prototypes.
13645
c939f91b
PE
13646 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork
13647 clobbering (Bug#8298).
b9c7f648
PE
13648 * sysdep.c (sys_subshell): Likewise.
13649 Previously, the sys_subshell 'volatile' was incorrectly IF_LINTted out.
7e9123a2 13650
6bd8c144
PE
13651 * lisp.h (child_setup): Now NO_RETURN unless DOS_NT.
13652 This should get cleaned up, so that child_setup has the
13653 same signature on all platforms.
13654
7710357c 13655 * callproc.c (call_process_cleanup): Now static.
cb1d0ef7 13656 (relocate_fd): Rename locals to avoid shadowing.
7710357c 13657
c59da222
CY
136582011-03-22 Chong Yidong <cyd@stupidchicken.com>
13659
13660 * xterm.c (x_clear_frame): Remove XClearWindow call. This appears
13661 not to be necessary, and produces flickering.
13662
66b87493
GM
136632011-03-20 Glenn Morris <rgm@gnu.org>
13664
13665 * config.in: Remove file.
13666
45b6f6d5
JB
136672011-03-20 Juanma Barranquero <lekktu@gmail.com>
13668
13669 * minibuf.c (Vcompleting_read_function): Don't declare, global variables
13670 are now in src/globals.h.
13671 (syms_of_minibuf): Remove spurious & from previous change.
13672
cd394be1 136732011-03-20 Leo Liu <sdl.web@gmail.com>
3ec03f7e
LL
13674
13675 * minibuf.c (completing-read-function): New variable.
13676 (completing-read-default): Rename from completing-read.
13677 (completing-read): Call completing-read-function.
13678
b14e3e21
CY
136792011-03-19 Juanma Barranquero <lekktu@gmail.com>
13680
13681 * xfaces.c (Fx_load_color_file):
13682 Read color file from absolute filename (bug#8250).
13683
f2b726e6
JB
136842011-03-19 Juanma Barranquero <lekktu@gmail.com>
13685
13686 * makefile.w32-in: Update dependencies.
13687
09f6ff02
EZ
136882011-03-17 Eli Zaretskii <eliz@gnu.org>
13689
13690 * makefile.w32-in ($(BLD)/unexw32.$(O)): Depend on $(SRC)/unexec.h.
13691
29a6015a
PE
136922011-03-17 Paul Eggert <eggert@cs.ucla.edu>
13693
a3a6c54e
PE
13694 Fix more problems found by GCC 4.5.2's static checks.
13695
b766f867
PE
13696 * process.c (make_serial_process_unwind, send_process_trap):
13697 (sigchld_handler): Now static.
13698
be02381c
PE
13699 * process.c (allocate_pty): Let PTY_ITERATION declare iteration vars.
13700 That way, the code declares only the vars that it needs.
13701 * s/aix4-2.h (PTY_ITERATION): Declare iteration vars.
13702 * s/cygwin.h (PTY_ITERATION): Likewise.
13703 * s/darwin.h (PTY_ITERATION): Likewise.
13704 * s/gnu-linux.h (PTY_ITERATION): Likewise.
13705
57048744
PE
13706 * s/irix6-5.h (PTY_OPEN): Declare stb, to loosen coupling.
13707 * process.c (allocate_pty): Don't declare stb unless it's needed.
13708
7914961c 13709 * bytecode.c (MAYBE_GC): Rewrite so as not to use empty "else".
615f2d59
PE
13710 (CONSTANTLIM): Remove; unused.
13711 (METER_CODE, Bscan_buffer, Bread_char, Bset_mark):
13712 Define only if needed.
7914961c 13713
b3967b18
PE
13714 * unexelf.c (unexec): Name an expression,
13715 to avoid gcc -Wbad-function-cast warning.
9ae71512
PE
13716 Use a different way to cause a compilation error if anyone uses
13717 n rather than nn, a way that does not involve shadowing.
73366a00 13718 (ELF_BSS_SECTION_NAME, OLD_PROGRAM_H): Remove; unused.
b3967b18 13719
29a6015a
PE
13720 * deps.mk (unexalpha.o): Remove; unused.
13721
43cfc33e 13722 New file unexec.h, the (simple) interface for unexec (Bug#8267).
7feda0d2 13723 * unexec.h: New file.
ce701a33
PE
13724 * deps.mk (emacs.o, unexaix.o, unexcw.o, unexcoff.o, unexelf.o):
13725 (unexhp9k800.o, unexmacosx.o, unexsol.o, unexw32.o):
13726 Depend on unexec.h.
13727 * emacs.c [!defined CANNOT_DUMP]: Include unexec.h.
13728 * unexaix.c, unexcoff.c, unexcw.c, unexelf.c, unexhp9k800.c:
13729 * unexmacosx.c, unexsol.c, unexw32.c: Include unexec.h.
381259ef 13730 Change as necessary to match prototype in unexec.h.
ce701a33 13731
01f44d5a
PE
13732 * syntax.c (Fforward_comment, scan_lists): Rename locals to avoid
13733 shadowing.
4f63c6bb 13734 (back_comment, skip_chars): Mark vars as initialized.
01f44d5a 13735
a6670b0b
PE
13736 * character.h (FETCH_STRING_CHAR_ADVANCE_NO_CHECK, BUF_INC_POS):
13737 Rename locals to avoid shadowing.
13738
cef2010d 13739 * lread.c (read1): Rewrite so as not to use empty "else".
0902fe45 13740 (Fload, readevalloop, read1): Rename locals to avoid shadowing.
cef2010d 13741
d4d7173a
PE
13742 * print.c (Fredirect_debugging_output): Fix pointer signedess.
13743
f08b802a
PE
13744 * lisp.h (debug_output_compilation_hack): Add decl here, to avoid
13745 warning when compiling print.c.
13746
3ddb0639
PE
13747 * font.c (font_unparse_fcname): Abort in an "impossible" situation
13748 instead of using an uninitialized var.
5ad03b97 13749 (font_sort_entities): Mark var as initialized.
3ddb0639 13750
170a2692
PE
13751 * character.h (FETCH_CHAR_ADVANCE): Rename locals to avoid shadowing.
13752
e663c700
PE
13753 * font.c (font_unparse_xlfd): Don't mix pointers to variables with
13754 pointers to constants.
89bc529a 13755 (font_parse_fcname): Remove unused vars.
7b81e2d0 13756 (font_delete_unmatched): Now static.
ea838e10 13757 (font_get_spec): Remove; unused.
13a547c6
PE
13758 (font_style_to_value, font_prop_validate_style, font_unparse_fcname):
13759 (font_update_drivers, Ffont_get_glyphs, font_add_log):
13760 Rename or move locals to avoid shadowing.
e663c700 13761
2a80c887 13762 * fns.c (require_nesting_list, require_unwind): Now static.
612f56df 13763 (Ffillarray): Rename locals to avoid shadowing.
2a80c887 13764
1384fa33 13765 * floatfns.c (domain_error2): Define only if needed.
a885e2ed 13766 (Ffrexp, Fldexp): Rename locals to avoid shadowing.
1384fa33 13767
8b2c52e9
PE
13768 * alloc.c (mark_backtrace): Move decl from here ...
13769 * lisp.h: ... to here, so that it can be checked.
13770
475545b5 13771 * eval.c (call_debugger, do_debug_on_call, grow_specpdl): Now static.
d28a2170 13772 (Fdefvar): Rewrite so as not to use empty "else".
cfcbfb1a
PE
13773 (lisp_indirect_variable): Name an expression,
13774 to avoid gcc -Wbad-function-cast warning.
1faed8ae 13775 (Fdefvar): Rename locals to avoid shadowing.
475545b5 13776
b1349114 13777 * callint.c (quotify_arg, quotify_args): Now static.
a3e8cbda 13778 (Fcall_interactively): Rename locals to avoid shadowing.
b0e80955 13779 Use const pointer when appropriate.
b1349114 13780
a2928364
PE
13781 * lisp.h (get_system_name, get_operating_system_release):
13782 Move decls here, to check interfaces.
13783 * process.c (get_operating_system_release): Move decl to lisp.h.
13784 * xrdb.c (get_system_name): Likewise.
63c5d10b
PE
13785 * editfns.c (init_editfns, Fuser_login_name, Fuser_uid):
13786 (Fuser_real_uid, Fuser_full_name): Remove unnecessary casts,
13787 some of which prompt warnings from gcc -Wbad-function-cast.
545b49b4
PE
13788 (Fformat_time_string, Fencode_time, Finsert_char):
13789 (Ftranslate_region_internal, Fformat):
13790 Rename or remove local vars to avoid shadowing.
9710023e 13791 (Ftranslate_region_internal): Mark var as initialized.
63c5d10b 13792
a415e694
PE
13793 * doc.c (Fdocumentation, Fsnarf_documentation): Move locals to
13794 avoid shadowing.
13795
8ef4622d
PE
13796 * lisp.h (eassert): Check that the argument compiles, even if
13797 ENABLE_CHECKING is not defined.
13798
946f9a5b
PE
13799 * data.c (Findirect_variable): Name an expression, to avoid
13800 gcc -Wbad-function-cast warning.
112396d6 13801 (default_value, arithcompare, arith_driver, arith_error): Now static.
b9b84fa9 13802 (store_symval_forwarding): Rename local to avoid shadowing.
44f230aa
SM
13803 (Fmake_variable_buffer_local, Fmake_local_variable):
13804 Mark variables as initialized.
52746918 13805 (do_blv_forwarding, do_symval_forwarding): Remove; unused.
946f9a5b 13806
e5aab7e7 13807 * alloc.c (check_cons_list): Do not define unless GC_CHECK_CONS_LIST.
ae35e756
PE
13808 (Fmake_vector, Fvector, Fmake_byte_code, Fgarbage_collect):
13809 Rename locals to avoid shadowing.
dff45157
PE
13810 (mark_stack): Move local variables into the #ifdef region where
13811 they're used.
7bc26fdb
PE
13812 (BLOCK_INPUT_ALLOC, UNBLOCK_INPUT_ALLOC): Define only if
13813 ! defined SYSTEM_MALLOC && ! defined SYNC_INPUT, as they are not
13814 needed otherwise.
13815 (CHECK_ALLOCATED): Define only if GC_CHECK_MARKED_OBJECTS.
13816 (GC_STRING_CHARS): Remove; not used.
d40d4be1 13817 (Fmemory_limit): Cast sbrk's returned value to char *.
ae35e756 13818
e5aab7e7
PE
13819 * lisp.h (check_cons_list): Declare if GC_CHECK_CONS_LIST; this
13820 avoids undefined behavior in theory.
13821
4da60324
PE
13822 * regex.c (IF_LINT): Add defn, for benefit of ../lib-src.
13823
88043301
PE
13824 Use functions, not macros, for up- and down-casing (Bug#8254).
13825 * buffer.h (DOWNCASE_TABLE, UPCASE_TABLE, DOWNCASE, UPPERCASEP):
13826 (NOCASEP, LOWERCASEP, UPCASE, UPCASE1): Remove. All callers changed
13827 to use the following functions instead of these macros.
13828 (downcase): Adjust to lack of DOWNCASE_TABLE. Return int, not
13829 EMACS_INT, since callers assume the returned value fits in int.
13830 (upcase1): Likewise, for UPCASE_TABLE.
13831 (uppercasep, lowercasep, upcase): New static inline functions.
0da09c43 13832 * editfns.c (Fchar_equal): Remove no-longer-needed workaround for
db69b0cd 13833 the race-condition problem in the old DOWNCASE.
88043301 13834
19ed5445
PE
13835 * regex.c (CHARSET_LOOKUP_RANGE_TABLE_RAW, POP_FAILURE_REG_OR_COUNT):
13836 Rename locals to avoid shadowing.
13837 (regex_compile, re_match_2_internal): Move locals to avoid shadowing.
abbd1bcf
PE
13838 (regex_compile, re_search_2, re_match_2_internal):
13839 Remove unused local vars.
952db0d7
PE
13840 (FREE_VAR): Rewrite so as not to use empty "else",
13841 which gcc can warn about.
da053e48 13842 (regex_compile, re_match_2_internal): Mark locals as initialized.
b313f9d8
PE
13843 (RETALLOC_IF): Define only if needed.
13844 (WORDCHAR_P): Likewise. This one is never needed, but is used
13845 only in a comment talking about a compiler bug, so put inside
13846 the #if 0 of that comment.
13847 (CHARSET_LOOKUP_BITMAP, FAIL_STACK_FULL, RESET_FAIL_STACK):
13848 (PUSH_FAILURE_ELT, BUF_PUSH_3, STOP_ADDR_VSTRING):
13849 Remove; unused.
19ed5445 13850
1f3561e4 13851 * search.c (boyer_moore): Rename locals to avoid shadowing.
76ef09b7
PE
13852 * character.h (FETCH_STRING_CHAR_AS_MULTIBYTE_ADVANCE):
13853 (PREV_CHAR_BOUNDARY): Likewise.
1f3561e4 13854
ded6f8f7
PE
13855 * search.c (simple_search): Remove unused var.
13856
dbd37a95
PE
13857 * dired.c (compile_pattern): Move decl from here ...
13858 * lisp.h: ... to here, so that it can be checked.
13859 (struct re_registers): New forward decl.
13860
7e47afad
PE
13861 * character.h (INC_POS, DEC_POS): Rename locals to avoid shadowing.
13862
85f24f61
PE
13863 * indent.c (MULTIBYTE_BYTES_WIDTH): New args bytes, width.
13864 All uses changed.
13865 (MULTIBYTE_BYTES_WIDTH, scan_for_column, compute_motion):
13866 Rename locals to avoid shadowing.
5671df8f 13867 (Fvertical_motion): Mark locals as initialized.
85f24f61 13868
181aa2be 13869 * casefiddle.c (casify_object, casify_region): Now static.
e45a141a 13870 (casify_region): Mark local as initialized.
181aa2be 13871
930d429c
PE
13872 * cmds.c (internal_self_insert): Rename local to avoid shadowing.
13873
7082eac6
PE
13874 * lisp.h (GCPRO2_VAR, GCPRO3_VAR, GCPRO4_VAR, GCPRO5_VAR, GCPRO6_VAR):
13875 New macros, so that the caller can use some names other than
13876 gcpro1, gcpro2, etc.
13877 (GCPRO2, GCPRO3, GCPRO4, GCPRO5, GCPRO6): Reimplement in terms
13878 of the new macros.
13879 (GCPRO1_VAR, UNGCPRO_VAR): Change the meaning of the second
13880 argument, for consistency with GCPRO2_VAR, etc: it is now the
13881 prefix of the variable, not the variable itself. All uses
13882 changed.
38b2c076
PE
13883 * dired.c (directory_files_internal, file_name_completion):
13884 Rename locals to avoid shadowing.
13885
15206ed9
PE
13886 Fix a race condition diagnosed by gcc -Wsequence-point (Bug#8254).
13887 An expression of the form (DOWNCASE (x) == DOWNCASE (y)), found in
13888 dired.c's scmp function, had undefined behavior.
13889 * lisp.h (DOWNCASE_TABLE, UPCASE_TABLE, DOWNCASE, UPPERCASEP):
13890 (NOCASEP, LOWERCASEP, UPCASE, UPCASE1): Move from here ...
13891 * buffer.h: ... to here, because these macros use current_buffer,
13892 and the new implementation with inline functions needs to have
13893 current_buffer in scope now, rather than later when the macros
13894 are used.
13895 (downcase, upcase1): New static inline functions.
13896 (DOWNCASE, UPCASE1): Reimplement using these functions.
13897 This avoids undefined behavior in expressions like
13898 DOWNCASE (x) == DOWNCASE (y), which previously suffered
13899 from race conditions in accessing the global variables
13900 case_temp1 and case_temp2.
13901 * casetab.c (case_temp1, case_temp2): Remove; no longer needed.
13902 * lisp.h (case_temp1, case_temp2): Remove their decls.
13903 * character.h (ASCII_CHAR_P): Move from here ...
13904 * lisp.h: ... to here, so that the inline functions mentioned
13905 above can use them.
13906
4a6bea26
PE
13907 * dired.c (directory_files_internal_unwind): Now static.
13908
f14b7e14
PE
13909 * fileio.c (file_name_as_directory, directory_file_name):
13910 (barf_or_query_if_file_exists, auto_save_error, auto_save_1):
13911 Now static.
2893f146
PE
13912 (file_name_as_directory): Use const pointers when appropriate.
13913 (Fexpand_file_name): Likewise. In particular, newdir might
13914 point at constant storage, so make it a const pointer.
fd4ead52 13915 (Fmake_directory_internal, Fread_file_name): Remove unused vars.
b14aac08
PE
13916 (Ffile_selinux_context, Fset_file_selinux_context): Fix pointer
13917 signedness issues.
f839df0c
PE
13918 (Fset_file_times, Finsert_file_contents, auto_save_error):
13919 Rename locals to avoid shadowing.
f14b7e14 13920
5716756e 13921 * minibuf.c (choose_minibuf_frame_1): Now static.
62137a95
PE
13922 (Ftry_completion, Fall_completions): Rename or remove locals
13923 to avoid shadowing.
5716756e 13924
b4c3046a
PE
13925 * marker.c (bytepos_to_charpos): Remove; unused.
13926
b45db522
PE
13927 * lisp.h (verify_bytepos, count_markers): New decls,
13928 so that gcc does not warn that these functions aren't declared.
13929
85876d07
PE
13930 * insdel.c (check_markers, make_gap_larger, make_gap_smaller):
13931 (reset_var_on_error, Fcombine_after_change_execute_1): Now static.
f0cb4a60 13932 (CHECK_MARKERS): Redo to avoid gcc -Wempty-body diagnostic.
40ef059e 13933 (copy_text): Remove unused local var.
85876d07 13934
03d78a21 13935 * filelock.c (within_one_second): Now static.
b3dd38ab 13936 (lock_file_1): Rename local to avoid shadowing.
03d78a21 13937
5df8f01b
PE
13938 * buffer.c (fix_overlays_before): Mark locals as initialized.
13939 (fix_start_end_in_overlays): Likewise. This function should be
13940 simplified by using pointers-to-pointers, but that's a different
13941 matter.
b1d876f1 13942 (switch_to_buffer_1): Now static.
8f54f30a
PE
13943 (Fkill_buffer, record_buffer, Fbury_buffer, Fset_buffer_multibyte):
13944 (report_overlay_modification): Rename locals to avoid shadowing.
c3bd59b5 13945
a70072c9 13946 * sysdep.c (system_process_attributes): Rename vars to avoid shadowing.
fbd02d7b 13947 Fix pointer signedness issue.
edced198
PE
13948 (sys_subshell): Mark local as volatile if checking for lint,
13949 to suppress a gcc -Wclobbered warning that does not seem to be right.
15dfd3d9 13950 (MAXPATHLEN): Define only if needed.
a70072c9 13951
a0977c44
PE
13952 * process.c (serial_open, serial_configure): Move decls from here ...
13953 * systty.h: ... to here, so that they can be checked.
13954
a884fdcc
PE
13955 * fns.c (get_random, seed_random): Move extern decls from here ...
13956 * lisp.h: ... to here, so that they can be checked.
13957
604efe86 13958 * sysdep.c (reset_io): Now static.
b8950c94 13959 (wait_for_termination_signal): Remove; unused.
604efe86 13960
38fc62d9
PE
13961 * keymap.c (keymap_parent, keymap_memberp, map_keymap_internal):
13962 (copy_keymap_item, append_key, push_text_char_description):
13963 Now static.
1004a21a 13964 (Fwhere_is_internal): Don't test CONSP (sequences) unnecessarily.
dbbb8427 13965 (DENSE_TABLE_SIZE): Remove; unused.
c1141155
PE
13966 (get_keymap, access_keymap, Fdefine_key, Fwhere_is_internal):
13967 (describe_map_tree):
13968 Rename locals to avoid shadowing.
38fc62d9 13969
2f2650da
PE
13970 * keyboard.c: Declare functions static if they are not used elsewhere.
13971 (echo_char, echo_dash, cmd_error, top_level_2):
13972 (poll_for_input, handle_async_input): Now static.
69a058fa
PE
13973 (read_char, kbd_buffer_get_event, make_lispy_position):
13974 (make_lispy_event, make_lispy_movement, apply_modifiers):
13975 (decode_keyboard_code, tty_read_avail_input, menu_bar_items):
13976 (parse_tool_bar_item, read_key_sequence, Fread_key_sequence):
13977 (Fread_key_sequence_vector): Rename locals to avoid shadowing.
c8a06054 13978 (read_key_sequence, read_char): Mark locals as initialized.
3ac94672 13979 (Fexit_recursive_edit, Fabort_recursive_edit): Mark with NO_RETURN.
2f2650da 13980
a053e86c 13981 * keyboard.h (make_ctrl_char): New decl.
da2f2dd9
PE
13982 (mark_kboards): Move decl here ...
13983 * alloc.c (mark_kboards): ... from here.
a053e86c 13984
4752793e
PE
13985 * lisp.h (force_auto_save_soon): New decl.
13986
74f10ca7 13987 * emacs.c (init_cmdargs): Rename local to avoid shadowing.
244fc23d
PE
13988 (DEFINE_DUMMY_FUNCTION): New macro.
13989 (__do_global_ctors, __do_global_ctors_aux, __do_global_dtors, __main):
13990 Use it.
c03cd23f
PE
13991 (main): Add casts to avoid warnings
13992 if GCC considers string literals to be constants.
74f10ca7 13993
022e70d4
PE
13994 * lisp.h (fatal_error_signal): Add decl, since it's exported.
13995
59d6fe83
PE
13996 * dbusbind.c: Pointer signedness fixes.
13997 (xd_signature, xd_append_arg, xd_initialize):
13998 (Fdbus_call_method, Fdbus_call_method_asynchronously):
13999 (Fdbus_method_return_internal, Fdbus_method_error_internal):
14000 (Fdbus_send_signal, xd_read_message_1, Fdbus_register_service):
14001 (Fdbus_register_signal): Use SSDATA when the context wants char *.
14002
78320123
PE
14003 * dbusbind.c (Fdbus_init_bus): Add cast to avoid warning
14004 if GCC considers string literals to be constants.
49cebcca 14005 (Fdbus_register_service, Fdbus_register_method): Remove unused vars.
78320123 14006
35ac2a97
SM
140072011-03-16 Stefan Monnier <monnier@iro.umontreal.ca>
14008
fb103ca9
SM
14009 * print.c (PRINT_CIRCLE_CANDIDATE_P): New macro.
14010 (print_preprocess, print_object): New macro to fix last change.
14011
35ac2a97
SM
14012 * print.c (print_preprocess): Don't forget font objects.
14013
62973b41
JB
140142011-03-16 Juanma Barranquero <lekktu@gmail.com>
14015
14016 * emacs.c (USAGE3): Doc fixes.
14017
0e48bb22
AS
140182011-03-15 Andreas Schwab <schwab@linux-m68k.org>
14019
14020 * coding.c (detect_coding_iso_2022): Reorganize code to clarify
14021 structure.
14022
7684e57b
JB
140232011-03-14 Juanma Barranquero <lekktu@gmail.com>
14024
14025 * lisp.h (VWindow_system, Qfile_name_history):
14026 * keyboard.h (lispy_function_keys) [WINDOWSNT]:
14027 * w32term.h (w32_system_caret_hwnd, w32_system_caret_height)
14028 (w32_system_caret_x, w32_system_caret_y): Declare extern.
14029
14030 * w32select.c: Don't #include "keyboard.h".
c96bbc66 14031 (run_protected): Add extern declaration for waiting_for_input.
7684e57b
JB
14032
14033 * w32.c (Qlocal, noninteractive1, inhibit_window_system):
14034 * w32console.c (detect_input_pending, read_input_pending)
14035 (encode_terminal_code):
14036 * w32fns.c (quit_char, lispy_function_keys, Qtooltip)
14037 (w32_system_caret_hwnd, w32_system_caret_height, w32_system_caret_x)
14038 (w32_system_caret_y, Qfile_name_history):
14039 * w32font.c (w32font_driver, QCantialias, QCotf, QClang):
14040 * w32inevt.c (reinvoke_input_signal, lispy_function_keys):
14041 * w32menu.c (Qmenu_bar, QCtoggle, QCradio, Qoverriding_local_map)
14042 (Qoverriding_terminal_local_map, Qmenu_bar_update_hook):
14043 * w32proc.c (Qlocal, report_file_error):
14044 * w32term.c (Vwindow_system, updating_frame):
14045 * w32uniscribe.c (initialized, uniscribe_font_driver):
14046 Remove unneeded extern declarations.
14047
2aa46d6c
CY
140482011-03-14 Chong Yidong <cyd@stupidchicken.com>
14049
c96bbc66 14050 * buffer.c (Fmake_indirect_buffer): Fix incorrect assertions.
2aa46d6c 14051
cffc6f3b
CY
140522011-03-13 Chong Yidong <cyd@stupidchicken.com>
14053
14054 * buffer.h (BUF_BEGV, BUF_BEGV_BYTE, BUF_ZV, BUF_ZV_BYTE, BUF_PT)
14055 (BUF_PT_BYTE): Rewrite to handle indirect buffers (Bug#8219).
14056 These macros can no longer be used for assignment.
14057
44f230aa
SM
14058 * buffer.c (Fget_buffer_create, Fmake_indirect_buffer):
14059 Assign struct members directly, instead of using BUF_BEGV etc.
cffc6f3b
CY
14060 (record_buffer_markers, fetch_buffer_markers): New functions for
14061 recording and fetching special buffer markers.
14062 (set_buffer_internal_1, set_buffer_temp): Use them.
14063
14064 * lread.c (unreadchar): Use SET_BUF_PT_BOTH.
14065
14066 * insdel.c (adjust_point): Use SET_BUF_PT_BOTH.
14067
14068 * intervals.c (temp_set_point_both): Use SET_BUF_PT_BOTH.
14069 (get_local_map): Use SET_BUF_BEGV_BOTH and SET_BUF_ZV_BOTH.
14070
14071 * xdisp.c (hscroll_window_tree):
14072 (reconsider_clip_changes): Use PT instead of BUF_PT.
14073
d251f04b
EZ
140742011-03-13 Eli Zaretskii <eliz@gnu.org>
14075
14076 * makefile.w32-in ($(BLD)/editfns.$(O)): Depend on
14077 $(EMACS_ROOT)/lib/intprops.h.
14078
f0c77cd1
PE
140792011-03-13 Paul Eggert <eggert@cs.ucla.edu>
14080
3eca4629
PE
14081 Fix more problems found by GCC 4.5.2's static checks.
14082
7c86ee98
PE
14083 * gtkutil.c (xg_get_pixbuf_from_pixmap): Add cast from char *
14084 to unsigned char * to avoid compiler diagnostic.
b0afc268
PE
14085 (xg_free_frame_widgets): Make it clear that a local variable is
14086 needed only if USE_GTK_TOOLTIP.
01e0b5ad
PE
14087 (gdk_window_get_screen): Make it clear that this macro is needed
14088 only if USE_GTK_TOOLTIP.
1e5524e7
PE
14089 (int_gtk_range_get_value): New function, which avoids a diagnostic
14090 from gcc -Wbad-function-cast.
14091 (xg_set_toolkit_scroll_bar_thumb): Use it.
14092 (xg_tool_bar_callback, xg_tool_item_stale_p): Rewrite to avoid
14093 diagnostic from gcc -Wbad-function-cast.
65dc836c
PE
14094 (get_utf8_string, xg_get_file_with_chooser):
14095 Rename locals to avoid shadowing.
14096 (create_dialog): Move locals to avoid shadowing.
7c86ee98 14097
41729b81
PE
14098 * xgselect.c (xg_select): Remove unused var.
14099
f0c77cd1
PE
14100 * image.c (four_corners_best): Mark locals as initialized.
14101 (gif_load): Initialize transparent_p to zero (Bug#8238).
14102 Mark another local as initialized.
ec6cf4c6 14103 (my_png_error, my_error_exit): Mark with NO_RETURN.
f0c77cd1 14104
ce0ad53d 14105 * image.c (clear_image_cache): Now static.
d5d5a617 14106 (DIM, HAVE_STDLIB_H_1): Remove unused macros.
e22cffbc 14107 (xpm_load): Redo to avoid "discards qualifiers" gcc warning.
77a765fd
PE
14108 (x_edge_detection): Remove unnecessary cast that
14109 gcc -Wbad-function-cast diagnoses.
2037898d 14110 (gif_load): Fix pointer signedness.
6ae141d6
PE
14111 (clear_image_cache, xbm_read_bitmap_data, x_detect_edges):
14112 (jpeg_load, gif_load): Rename locals to avoid shadowing.
ce0ad53d 14113
33383987 141142011-03-12 Paul Eggert <eggert@cs.ucla.edu>
3eca4629 14115
d32df629
PE
14116 Improve quality of tests for time stamp overflow.
14117 For example, without this patch (encode-time 0 0 0 1 1
14118 1152921504606846976) returns the obviously-bogus value (-948597
14119 62170) on my RHEL 5.5 x86-64 host. With the patch, it correctly
14120 reports time overflow. See
14121 <http://lists.gnu.org/archive/html/emacs-devel/2011-03/msg00470.html>.
b8d9bd41
PE
14122 * deps.mk (editfns.o): Depend on ../lib/intprops.h.
14123 * editfns.c: Include limits.h and intprops.h.
14124 (TIME_T_MIN, TIME_T_MAX): New macros.
14125 (time_overflow): Move earlier, to before first use.
14126 (hi_time, lo_time): New functions, for an accurate test for
14127 out-of-range times.
14128 (Fcurrent_time, Fget_internal_run_time, make_time): Use them.
14129 (Fget_internal_run_time): Don't assume time_t fits in int.
14130 (make_time): Use list2 instead of Fcons twice.
14131 (Fdecode_time): More accurate test for out-of-range times.
14132 (check_tm_member): New function.
14133 (Fencode_time): Use it, to test for out-of-range times.
d32df629
PE
14134 (lisp_time_argument): Don't rely on undefined left-shift and
14135 right-shift behavior when checking for time stamp overflow.
8be6f318 14136
fe31d94c
PE
14137 * editfns.c (time_overflow): New function, refactoring common code.
14138 (Fformat_time_string, Fdecode_time, Fencode_time):
14139 (Fcurrent_time_string): Use it.
14140
8be6f318
PE
14141 Move 'make_time' to be next to its inverse 'lisp_time_argument'.
14142 * dired.c (make_time): Move to ...
14143 * editfns.c (make_time): ... here.
14144 * systime.h: Note the move.
14145
09d9db2c 141462011-03-12 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
c47cbdfd 14147
126bc0dc
YM
14148 * fringe.c (update_window_fringes): Remove unused variables.
14149
c47cbdfd
YM
14150 * unexmacosx.c (copy_data_segment): Also copy __got section.
14151 (Bug#8223)
14152
7ac80be9
EZ
141532011-03-12 Eli Zaretskii <eliz@gnu.org>
14154
c96bbc66 14155 * termcap.c [MSDOS]: Include "msdos.h".
058e5dad
EZ
14156 (find_capability, tgetnum, tgetflag, tgetstr, tputs, tgetent):
14157 Constify `char *' arguments and their references according to
14158 prototypes in tparam.h.
14159
ecb0f94d 14160 * deps.mk (termcap.o): Depend on tparam.h and msdos.h.
058e5dad 14161
7ac80be9
EZ
14162 * msdos.c (XMenuAddPane): 3rd argument is `const char *' now.
14163 Adapt all references accordingly.
14164
14165 * msdos.h (XMenuAddPane): 3rd argument is `const char *' now.
14166
ef1fd07e
TT
141672011-03-11 Tom Tromey <tromey@redhat.com>
14168
14169 * buffer.c (syms_of_buffer): Remove obsolete comment.
14170
7ef4b50c
EZ
141712011-03-11 Eli Zaretskii <eliz@gnu.org>
14172
14173 * termhooks.h (encode_terminal_code): Declare prototype.
14174
14175 * msdos.c (encode_terminal_code): Don't declare prototype.
14176
14177 * term.c (encode_terminal_code): Now external again, used by
14178 w32console.c and msdos.c.
14179
44f230aa
SM
14180 * makefile.w32-in ($(BLD)/term.$(O), ($(BLD)/tparam.$(O)):
14181 Depend on $(SRC)/tparam.h, see 2011-03-11T07:24:21Z!eggert@cs.ucla.edu.
7ef4b50c 14182
4b1ec863 141832011-03-11 Paul Eggert <eggert@cs.ucla.edu>
f78faa98 14184
1714f52b 14185 Fix some minor problems found by GCC 4.5.2's static checks.
83316bf4 14186
4b1ec863
PE
14187 * fringe.c (update_window_fringes): Mark locals as initialized
14188 (Bug#8227).
14189 (destroy_fringe_bitmap, init_fringe_bitmap): Now static.
bf60f616 14190
524c7aa6
PE
14191 * alloc.c (mark_fringe_data): Move decl from here ...
14192 * lisp.h (mark_fringe_data) [HAVE_WINDOW_SYSTEM]: ... to here,
14193 to check its interface.
14194 (init_fringe_once): Do not declare unless HAVE_WINDOW_SYSTEM.
14195
a5c0af81 14196 * fontset.c (free_realized_fontset): Now static.
7519b8cd 14197 (Fset_fontset_font): Rename local to avoid shadowing.
cc6e5db1 14198 (fontset_font): Mark local as initialized.
a9a06e0b 14199 (FONTSET_SPEC, FONTSET_REPERTORY, RFONT_DEF_REPERTORY): Remove; unused.
a5c0af81 14200
b4716021
PE
14201 * xrdb.c: Include "xterm.h", to check x_load_resources's interface.
14202
811e9bac 14203 * xselect.c (x_disown_buffer_selections): Remove; not used.
7b83e2f1 14204 (TRACE3) [!defined TRACE_SELECTION]: Remove; not used.
aa0daa9f
PE
14205 (x_own_selection, Fx_disown_selection_internal): Rename locals
14206 to avoid shadowing.
14207 (x_handle_dnd_message): Remove local to avoid shadowing.
811e9bac 14208
7e3ab302
PE
14209 * lisp.h (GCPRO1_VAR, UNGCPRO_VAR): New macros,
14210 so that the caller can use some name other than gcpro1.
14211 (GCPRO1, UNGCPRO): Reimplement in terms of the new macros.
58d2d479
PE
14212 * xfns.c (Fx_create_frame, x_create_tip_frame, Fx_show_tip):
14213 (Fx_backspace_delete_keys_p):
14214 Use them to avoid shadowing, and rename vars to avoid shadowing.
14215 (x_decode_color, x_set_name, x_window): Now static.
6b437900 14216 (Fx_create_frame): Add braces to silence GCC warning.
c0951e53 14217 (Fx_file_dialog, Fx_select_font): Fix pointer signedness.
06b0c8a0
PE
14218 (x_real_positions, xg_set_icon_from_xpm_data, x_create_tip_frame):
14219 Remove unused locals.
7e3ab302
PE
14220 (Fx_create_frame, x_create_tip_frame, Fx_show_tip):
14221 (Fx_backspace_delete_keys_p): Rename locals to avoid shadowing.
14222 Some of these renamings use the new GCPRO1_VAR and UNGCPRO_VAR
14223 macros.
f78faa98 14224
e2b13473
PE
14225 * xterm.h (x_mouse_leave): New decl.
14226
77f23912
PE
14227 * xterm.c (x_copy_dpy_color, x_focus_on_frame, x_unfocus_frame):
14228 Remove unused functions.
cdf4ba58
PE
14229 (x_shift_glyphs_for_insert, XTflash, XTring_bell):
14230 (x_calc_absolute_position): Now static.
7411c686 14231 (XTread_socket): Don't define label "out" unless it's used.
2b07bcff 14232 Don't declare local "event" unless it's used.
ed7bf3a5
PE
14233 (x_iconify_frame, x_free_frame_resources): Don't declare locals
14234 unless they are used.
38d0b34a
PE
14235 (XEMBED_VERSION, xembed_set_info): Don't define unless needed.
14236 (x_fatal_error_signal): Remove; not used.
a6067996
PE
14237 (x_draw_image_foreground, redo_mouse_highlight, XTmouse_position):
14238 (x_scroll_bar_report_motion, handle_one_xevent, x_draw_bar_cursor):
14239 (x_error_catcher, x_connection_closed, x_error_handler):
14240 (x_error_quitter, xembed_send_message, x_iconify_frame):
14241 (my_log_handler): Rename locals to avoid shadowing.
28f1c698 14242 (x_delete_glyphs, x_ins_del_lines): Mark with NO_RETURN.
2a8fade0 14243 (x_connection_closed): Tell GCC not to suggest NO_RETURN.
77f23912 14244
44f230aa
SM
14245 * xfaces.c (clear_face_cache, Fx_list_fonts, Fface_font):
14246 Rename or move locals to avoid shadowing.
6b463e58 14247 (tty_defined_color, merge_face_heights): Now static.
5967d051 14248 (free_realized_faces_for_fontset): Remove; not used.
1e9966ea
PE
14249 (Fx_list_fonts): Mark variable that gcc -Wuninitialized
14250 does not deduce is never used uninitialized.
73719eba
PE
14251 (STRDUPA, LSTRDUPA, FONT_POINT_SIZE_QUANTUM): Remove; not used.
14252 (LFACEP): Define only if XASSERTS, as it's not needed otherwise.
071048a3 14253
426994c3 14254 * terminal.c (store_terminal_param): Now static.
5489860b 14255
032f1620 14256 * xmenu.c (menu_highlight_callback): Now static.
9d66f88e 14257 (set_frame_menubar): Remove unused local.
d4323972 14258 (xmenu_show): Rename parameter to avoid shadowing.
6d1f7fee
PE
14259 (xmenu_show, xdialog_show, xmenu_show): Make local pointers "const"
14260 since they might point to immutable storage.
281585b0
PE
14261 (next_menubar_widget_id): Declare only if USE_X_TOOLKIT,
14262 since it's unused otherwise.
032f1620 14263
367c19e5 14264 * xdisp.c (produce_glyphless_glyph): Initialize lower_xoff.
53df7c11 14265 Add a FIXME, since the code still doesn't look right. (Bug#8215)
9f36b9fd
PE
14266 (Fcurrent_bidi_paragraph_direction): Simplify slightly; this
14267 avoids a gcc -Wuninitialized diagnostic.
0e086e8f 14268 (display_line, BUILD_COMPOSITE_GLYPH_STRING, draw_glyphs):
44a3a108
PE
14269 (note_mouse_highlight): Mark variables that gcc -Wuninitialized
14270 does not deduce are never used uninitialized.
70739cbe 14271
07b48fa9
PE
14272 * lisp.h (IF_LINT): New macro, copied from ../lib-src/emacsclient.c.
14273
8868a238 14274 * xdisp.c (redisplay_window): Rename local to avoid shadowing.
4554d213
PE
14275 * window.c (window_loop, size_window):
14276 (run_window_configuration_change_hook, enlarge_window): Likewise.
8868a238 14277
7e5cf297 14278 * window.c (display_buffer): Now static.
d6550a9f
PE
14279 (size_window): Mark variables that gcc -Wuninitialized
14280 does not deduce are never used uninitialized.
a586633d
PE
14281 * window.h (check_all_windows): New decl, to forestall
14282 gcc -Wmissing-prototypes diagnostic.
5b555da1 14283 * dispextern.h (bidi_dump_cached_states): Likewise.
7e5cf297 14284
f6095868
PE
14285 * charset.h (CHECK_CHARSET_GET_CHARSET): Rename locals to avoid
14286 shadowing.
14287 * charset.c (map_charset_for_dump, Fchar_charset): Likewise.
726929c4
PE
14288 Include <limits.h>.
14289 (Fsort_charsets): Redo min/max calculation to shorten the code a bit
14290 and to avoid gcc -Wuninitialized warning.
89ef49df
PE
14291 (load_charset_map): Mark variables that gcc -Wuninitialized
14292 does not deduce are never used uninitialized.
53df7c11 14293 (load_charset): Abort instead of using uninitialized var (Bug#8229).
f6095868 14294
f38b440c
PE
14295 * coding.c (coding_set_source, coding_set_destination):
14296 Use "else { /* comment */ }" rather than "else /* comment */;"
14297 for clarity, and to avoid gcc -Wempty-body warning.
2735d060
PE
14298 (Fdefine_coding_system_internal): Don't redeclare 'i' inside
14299 a block, when the outer 'i' will do.
14300 (decode_coding_utf_8, decode_coding_utf_16, detect_coding_emacs_mule):
14301 (emacs_mule_char, decode_coding_emacs_mule, detect_coding_iso_2022):
14302 (decode_coding_iso_2022, decode_coding_sjis, decode_coding_big5):
14303 (decode_coding_raw_text, decode_coding_charset, get_translation_table):
14304 (Fdecode_sjis_char, Fdefine_coding_system_internal):
14305 Rename locals to avoid shadowing.
14306 * character.h (FETCH_STRING_CHAR_ADVANCE): Likewise.
e2f1bab9
PE
14307 * coding.c (emacs_mule_char, encode_invocation_designation):
14308 Now static, since they're not used elsewhere.
413bb2db 14309 (decode_coding_iso_2022): Add "default: abort ();" as a safety check.
c4a63b12 14310 (decode_coding_object, encode_coding_object, detect_coding_system):
ee05f961
PE
14311 (decode_coding_emacs_mule): Mark variables that gcc
14312 -Wuninitialized does not deduce are never used uninitialized.
160b01f6
PE
14313 (detect_coding_iso_2022): Initialize a local variable that might
14314 be used uninitialized. Leave a FIXME because it's not clear that
53df7c11 14315 this initialization is needed. (Bug#8211)
5f58e762
PE
14316 (ISO_CODE_LF, ISO_CODE_CR, CODING_ISO_FLAG_EUC_TW_SHIFT):
14317 (ONE_MORE_BYTE_NO_CHECK, UTF_BOM, UTF_16_INVALID_P):
14318 (SHIFT_OUT_OK, ENCODE_CONTROL_SEQUENCE_INTRODUCER):
14319 (ENCODE_DIRECTION_R2L, ENCODE_DIRECTION_L2R):
14320 Remove unused macros.
f38b440c 14321
232b38b9 14322 * category.c (hash_get_category_set): Remove unused local var.
9f3b5e69 14323 (copy_category_table): Now static, since it's not used elsewhere.
d0891610 14324 * character.c (string_count_byte8): Likewise.
232b38b9 14325
fb90da1b
PE
14326 * ccl.c (CCL_WRITE_STRING, CCL_ENCODE_CHAR, Fccl_execute_on_string):
14327 (Fregister_code_conversion_map): Rename locals to avoid shadowing.
14328
fb93dbc2
PE
14329 * chartab.c (copy_sub_char_table): Now static, since it's not used
14330 elsewhere.
5c156ace
PE
14331 (sub_char_table_ref_and_range, char_table_ref_and_range):
14332 Rename locals to avoid shadowing.
bbcd0949 14333 (ASET_RANGE, GET_SUB_CHAR_TABLE): Remove unused macros.
fb93dbc2 14334
7d3b3862 14335 * bidi.c (bidi_check_type): Now static, since it's not used elsewhere.
630d6892 14336 (BIDI_BOB): Remove unused macro.
7d3b3862 14337
6be7d3da
PE
14338 * cm.c (cmgoto): Mark variables that gcc -Wuninitialized does not
14339 deduce are never used uninitialized.
c2ed9c8b 14340 * term.c (encode_terminal_code): Likewise.
6be7d3da 14341
75f8807f 14342 * term.c (encode_terminal_code): Now static. Remove unused local.
72abad34 14343
50938595
PE
14344 * tparam.h: New file.
14345 * term.c, tparam.h: Include it.
14346 * deps.mk (term.o, tparam.o): Depend on tparam.h.
14347 * term.c (tputs, tgetent, tgetflag, tgetnum, tparam, tgetstr):
14348 Move these decls to tparam.h, and make them agree with what
14349 is actually in tparam.c. The previous trick of using incompatible
14350 decls in different modules does not conform to the C standard.
14351 All callers of tparam changed to use tparam's actual API.
14352 * tparam.c (tparam1, tparam, tgoto):
14353 Use const pointers where appropriate.
14354
fbceeba2
PE
14355 * cm.c (calccost, cmgoto): Use const pointers where appropriate.
14356 * cm.h (struct cm): Likewise.
14357 * dispextern.h (do_line_insertion_deletion_costs): Likewise.
14358 * scroll.c (ins_del_costs, do_line_insertion_deletion_costs): Likewise.
14359 * term.c (tty_ins_del_lines, calculate_costs, struct fkey_table):
14360 (term_get_fkeys_1, append_glyphless_glyph, produce_glyphless_glyph):
14361 (turn_on_face, init_tty): Likewise.
14362 * termchar.h (struct tty_display_info): Likewise.
fbceeba2 14363
7f3f1250
PE
14364 * term.c (term_mouse_position): Rename local to avoid shadowing.
14365
e6ca6543
PE
14366 * alloc.c (mark_ttys): Move decl from here ...
14367 * lisp.h (mark_ttys): ... to here, so that it's checked against defn.
14368
c40f8d15
AS
143692011-03-11 Andreas Schwab <schwab@linux-m68k.org>
14370
14371 * .gdbinit (pwinx, xbuffer): Fix access to buffer name.
14372
cfe0661d
JB
143732011-03-09 Juanma Barranquero <lekktu@gmail.com>
14374
14375 * search.c (compile_pattern_1): Remove argument regp, unused since
14376 revid:rms@gnu.org-19941211082627-3x1g1wyqkjmwloig.
14377 (compile_pattern): Don't pass it.
14378
0afb4571
J
143792011-03-08 Jan Djärv <jan.h.d@swipnet.se>
14380
14381 * xterm.h (DEFAULT_GDK_DISPLAY): New define.
14382 (GDK_WINDOW_XID, gtk_widget_get_preferred_size): New defines
14383 for ! HAVE_GTK3.
14384 (GTK_WIDGET_TO_X_WIN): Use GDK_WINDOW_XID.
14385
14386 * xmenu.c (menu_position_func): Call gtk_widget_get_preferred_size.
14387
14388 * gtkutil.c: Include gtkx.h if HAVE_GTK3. If ! HAVE_GTK3, define
14389 gdk_window_get_screen, gdk_window_get_geometry,
14390 gdk_x11_window_lookup_for_display and GDK_KEY_g.
14391 (xg_set_screen): Use DEFAULT_GDK_DISPLAY.
14392 (xg_get_pixbuf_from_pixmap): New function.
14393 (xg_get_pixbuf_from_pix_and_mask): Change parameters from GdkPixmap
14394 to Pixmap, take frame as parameter, remove GdkColormap parameter.
14395 Call xg_get_pixbuf_from_pixmap instead of
14396 gdk_pixbuf_get_from_drawable.
14397 (xg_get_image_for_pixmap): Do not make GdkPixmaps, call
14398 xg_get_pixbuf_from_pix_and_mask with Pixmap parameters instead.
14399 (xg_check_special_colors): Use GtkStyleContext and its functions
14400 for HAVE_GTK3.
14401 (xg_prepare_tooltip, xg_hide_tooltip): Call gdk_window_get_screen.
14402 (xg_prepare_tooltip, create_dialog, menubar_map_cb)
14403 (xg_update_frame_menubar, xg_tool_bar_detach_callback)
44f230aa
SM
14404 (xg_tool_bar_attach_callback, xg_update_tool_bar_sizes):
14405 Call gtk_widget_get_preferred_size.
0afb4571
J
14406 (xg_frame_resized): gdk_window_get_geometry only takes 5
14407 parameters.
44f230aa
SM
14408 (xg_win_to_widget, xg_event_is_for_menubar):
14409 Call gdk_x11_window_lookup_for_display.
0afb4571
J
14410 (xg_set_widget_bg): New function.
14411 (delete_cb): New function.
895009e1 14412 (xg_create_frame_widgets): Connect delete-event to delete_cb.
5c32d3f2 14413 Call xg_set_widget_bg. Only set background pixmap for ! HAVE_GTK3
0afb4571
J
14414 (xg_set_background_color): Call xg_set_widget_bg.
14415 (xg_set_frame_icon): Call xg_get_pixbuf_from_pix_and_mask.
14416 (xg_create_scroll_bar): vadj is a GtkAdjustment for HAVE_GTK3.
14417 Only call gtk_range_set_update_policy if ! HAVE_GTK3.
14418 (xg_make_tool_item): Only connect xg_tool_bar_item_expose_callback
14419 if ! HAVE_GTK3.
14420 (update_frame_tool_bar): Call gtk_widget_hide.
14421 (xg_initialize): Use GDK_KEY_g.
14422
14423 * xsmfns.c (gdk_set_sm_client_id): Define to gdk_set_sm_client_id
14424 if ! HAVE_GTK3
14425 (x_session_initialize): Call gdk_x11_set_sm_client_id.
14426
14427 * xterm.c (XFillRectangle): Use cairo routines for HAVE_GTK3.
14428 (x_term_init): Disable Xinput(2) with GDK_CORE_DEVICE_EVENTS.
14429 Load ~/emacs.d/gtkrc only for ! HAVE_GTK3.
14430
1c2cc4ef
JB
144312011-03-08 Juanma Barranquero <lekktu@gmail.com>
14432
14433 * w32xfns.c (select_palette): Check success of RealizePalette against
14434 GDI_ERROR, not zero.
14435
33383987 14436See ChangeLog.11 for earlier changes.
aac0c6e3
MR
14437
14438;; Local Variables:
14439;; coding: utf-8
aac0c6e3
MR
14440;; End:
14441
2f097256 14442 Copyright (C) 2011-2012 Free Software Foundation, Inc.
aac0c6e3
MR
14443
14444 This file is part of GNU Emacs.
14445
14446 GNU Emacs is free software: you can redistribute it and/or modify
14447 it under the terms of the GNU General Public License as published by
14448 the Free Software Foundation, either version 3 of the License, or
14449 (at your option) any later version.
14450
14451 GNU Emacs is distributed in the hope that it will be useful,
14452 but WITHOUT ANY WARRANTY; without even the implied warranty of
14453 MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
14454 GNU General Public License for more details.
14455
14456 You should have received a copy of the GNU General Public License
14457 along with GNU Emacs. If not, see <http://www.gnu.org/licenses/>.