* lisp.h: Prefer 64-bit EMACS_INT if available.
[bpt/emacs.git] / src / ChangeLog
CommitLineData
8ac068ac
PE
12011-04-29 Paul Eggert <eggert@cs.ucla.edu>
2
7fd47d5c
PE
3 * lisp.h: Prefer 64-bit EMACS_INT if available.
4 (EMACS_INT, EMACS_UINT, BITS_PER_EMACS_INT, pI): Define to 64-bit
5 on 32-bit hosts that have 64-bit int, so that they can access
6 large files.
7
8727937b
PE
8 * lread.c, process.c: Do not include <inttypes.h>; lisp.h does it now.
9
8ac068ac
PE
10 Prefer intptr_t/uintptr_t for integers the same widths as pointers.
11 This removes an assumption that EMACS_INT and long are the same
12 width as pointers. The assumption is true for Emacs porting targets
13 now, but we want to make other targets possible.
14 * lisp.h: Include <inttypes.h>, for INTPTR_MAX, UINTPTR_MAX.
15 (EMACS_INTPTR, EMACS_UINTPTR): New macros.
16 In the rest of the code, change types of integers that hold casted
17 pointers to EMACS_INTPTR and EMACS_UINTPTR, systematically
18 replacing EMACS_INT, long, EMACS_UINT, and unsigned long.
19 (XTYPE): Don't cast arg to EMACS_UINT; normally is not needed.
20 (XSET): Cast type of XTYPE arg to EMACS_INTPTR; it is needed here.
21 No need to cast type when ORing.
22 (XPNTR): Return a value of type EMACS_INTPTR or EMACS_UINTPTR.
23 * alloc.c (lisp_align_malloc): Remove a no-longer-needed cast.
24 * doc.c (store_function_docstring): Use EMACS_INTPTR, so as not to
25 assume EMACS_INT is the same width as char *.
26 * gtkutil.c (xg_gtk_scroll_destroy, xg_tool_bar_button_cb):
27 (xg_tool_bar_callback, xg_tool_bar_help_callback, xg_make_tool_item):
28 Remove no-longer-needed casts.
29 (xg_create_scroll_bar, xg_tool_bar_button_cb, xg_tool_bar_callback):
30 (xg_tool_bar_help_callback, xg_make_tool_item):
31 Use EMACS_INTPTR to hold an integer
32 that will be cast to void *; this can avoid a GCC warning
33 if EMACS_INT is not the same width as void *.
34 * menu.c (find_and_call_menu_selection): Remove no-longer-needed cast.
35 * xdisp.c (display_echo_area_1, resize_mini_window_1):
36 (current_message_1, set_message_1):
37 Use a local to convert to proper width without a cast.
38 * xmenu.c (dialog_selection_callback): Likewise.
39
92394119
PE
402011-04-28 Paul Eggert <eggert@cs.ucla.edu>
41
ede49d71
PE
42 * sysdep.c (get_random): Don't assume EMACS_INT is no wider than long.
43 Also, don't assume VALBITS / RAND_BITS is less than 5,
44 and don't rely on undefined behavior when shifting a 1 left into
45 the sign bit.
46 * lisp.h (get_random): Change signature to match.
47
2f30ecd0
PE
48 * lread.c (hash_string): Use size_t, not int, for hash computation.
49 Normally we prefer signed values; but hashing is special, because
50 it's better to use unsigned division on hash table sizes so that
51 the remainder is nonnegative. Also, size_t is the natural width
52 for hashing into memory. The previous code used 'int', which doesn't
53 retain enough info to hash well into very large tables.
54 (oblookup, oblookup_last_bucket_number, Funintern): Likewise.
55
2a866e7b
PE
56 * dbusbind.c: Don't possibly lose pointer info when converting.
57 (xd_remove_watch, Fdbus_init_bus, xd_read_queued_messages):
58 Use XPNTR rather than XHASH, so that the high-order bits of
59 the pointer aren't lost when converting through void *.
60
51639eac
PE
61 * eval.c (Fautoload): Don't double-shift a pointer.
62
92394119
PE
63 * fns.c (Frandom): Let EMACS_UINT be wider than unsigned long.
64
f76dee0c
PE
652011-04-28 Paul Eggert <eggert@cs.ucla.edu>
66
67 * doprnt.c (doprnt): Omit useless test; int overflow check (Bug#8545).
283cdbef 68 (SIZE_MAX): Move defn after all includes, as they might #define it.
f76dee0c 69
fdc5744d
JB
702011-04-28 Juanma Barranquero <lekktu@gmail.com>
71
72 * w32.c (init_environment): Warn about defaulting HOME to C:\.
73
638f053a
JB
742011-04-28 Juanma Barranquero <lekktu@gmail.com>
75
76 * keyboard.c (Qdelayed_warnings_hook): Define.
77 (command_loop_1): Run `delayed-warnings-hook'
78 if Vdelayed_warnings_list is non-nil.
79 (syms_of_keyboard) <delayed-warnings-hook>: DEFSYM it.
80 (syms_of_keyboard) <delayed-warnings-list>: DEFVAR_LISP it.
81
d178f871
EZ
822011-04-28 Eli Zaretskii <eliz@gnu.org>
83
84 * doprnt.c (doprnt): Don't return value smaller than the buffer
85 size if the message was truncated. (Bug#8545).
86
b124fd93
JB
872011-04-28 Juanma Barranquero <lekktu@gmail.com>
88
89 * w32fns.c (Fx_change_window_property, Fx_delete_window_property)
90 (Fx_window_property): #if-0 the whole functions, not just the bodies.
91
e810457d
PE
922011-04-27 Paul Eggert <eggert@cs.ucla.edu>
93
94 * doprnt.c (doprnt): Support "ll" length modifier, for long long.
95
ea51cceb
JB
962011-04-27 Juanma Barranquero <lekktu@gmail.com>
97
98 * makefile.w32-in: Update dependencies.
99
94dcfacf
EZ
1002011-04-27 Eli Zaretskii <eliz@gnu.org>
101
102 Improve `doprnt' and its usage. (Bug#8545)
103 * doprnt.c (doprnt): Make sure `format' is never accessed beyond
104 `format_end'. Remove support for %l as a conversion specifier.
105 Don't use xrealloc. Improve diagnostics when the %l size modifier
106 is used. Update the commentary.
107
108 * eval.c (verror): Simplify calculation of size_t.
109
110 * coding.c (Ffind_operation_coding_system): Fix diagnostic error
111 messages.
112
f61f41d7
PE
1132011-04-27 Yoshiaki Kasahara <kasahara@nc.kyushu-u.ac.jp> (tiny change)
114
115 * buffer.c (init_buffer) [USE_MMAP_FOR_BUFFERS]: Adjust to aliasing
116 change.
117
96fb4434
PE
1182011-04-27 Paul Eggert <eggert@cs.ucla.edu>
119
120 * nsmenu.m: Replace all uses of XVECTOR with ASIZE and AREF.
121 This makes this file independent of the recent pseudovector change.
122
671875da 1232011-04-26 Paul Eggert <eggert@cs.ucla.edu>
eab3844f 124
69e9b5a3
PE
125 * keyboard.c (handle_user_signal): Fix pointer signedness problem.
126
b5f869a7 127 * gnutls.c (emacs_gnutls_handle_error): Remove unused local.
7754e151 128 (Fgnutls_boot): gnutls_certificate_verify_peers2 wants unsigned *.
8d4c3955 129 Remove unused local.
c8926152 130 (emacs_gnutls_write): Don't use uninitialized rtnval if nbyte <= 0.
080e5a8d 131
841a1577 132 * lisp.h: Fix a problem with aliasing and vector headers. (Bug#8546)
eab3844f
PE
133 GCC 4.6.0 optimizes based on type-based alias analysis. For
134 example, if b is of type struct buffer * and v of type struct
135 Lisp_Vector *, then gcc -O2 was incorrectly assuming that &b->size
136 != &v->size, and therefore "v->size = 1; b->size = 2; return
137 v->size;" must therefore return 1. This assumption is incorrect
138 for Emacs, since it type-puns struct Lisp_Vector * with many other
139 types. To fix this problem, this patch adds a new type struct
f904488f 140 vectorlike_header that documents the constraints on layout of vectors
eab3844f
PE
141 and pseudovectors, and helps optimizing compilers not get fooled
142 by Emacs's type punning. It also adds the macros XSETTYPED_PVECTYPE
143 XSETTYPED_PSEUDOVECTOR, TYPED_PSEUDOVECTORP, for similar reasons.
f904488f
PE
144 * lisp.h (XSETTYPED_PVECTYPE): New macro, specifying the name of
145 the size member.
eab3844f
PE
146 (XSETPVECTYPE): Rewrite in terms of new macro.
147 (XSETPVECTYPESIZE): New macro, specifying both type and size.
148 This is a bit clearer, and further avoids the possibility of
149 undesirable aliasing.
150 (XSETTYPED_PSEUDOVECTOR): New macro, specifying the size.
f904488f 151 (XSETPSEUDOVECTOR): Rewrite in terms of XSETTYPED_PSEUDOVECTOR.
eab3844f
PE
152 (XSETSUBR): Rewrite in terms of XSETTYPED_PSEUDOVECTOR and XSIZE,
153 since Lisp_Subr is a special case (no "next" field).
f904488f
PE
154 (ASIZE): Now uses header.size rather than size. All
155 previous uses of XVECTOR (foo)->size replaced to use this macro,
156 to avoid the hassle of writing XVECTOR (foo)->header.size.
157 (struct vectorlike_header): New type.
eab3844f
PE
158 (TYPED_PSEUDOVECTORP): New macro, also specifying the C type of the
159 object, to help avoid aliasing.
160 (PSEUDOVECTORP): Rewrite in terms of TYPED_PSEUDOVECTORP.
161 (SUBRP): Likewise, since Lisp_Subr is a special case.
162 * lisp.h (struct Lisp_Vector, struct Lisp_Char_Table):
163 (struct Lisp_Sub_Char_Table, struct Lisp_Bool_Vector):
164 (struct Lisp_Hash_Table): Combine first two members into a single
f904488f 165 struct vectorlike_header member. All uses of "size" and "next" members
eab3844f
PE
166 changed to be "header.size" and "header.next".
167 * buffer.h (struct buffer): Likewise.
168 * font.h (struct font_spec, struct font_entity, struct font): Likewise.
169 * frame.h (struct frame): Likewise.
170 * process.h (struct Lisp_Process): Likewise.
171 * termhooks.h (struct terminal): Likewise.
172 * window.c (struct save_window_data, struct saved_window): Likewise.
173 * window.h (struct window): Likewise.
174 * alloc.c (allocate_buffer, Fmake_bool_vector, allocate_pseudovector):
175 Use XSETPVECTYPESIZE, not XSETPVECTYPE, to avoid aliasing problems.
176 * buffer.c (init_buffer_once): Likewise.
177 * lread.c (defsubr): Use XSETTYPED_PVECTYPE, since Lisp_Subr is a
178 special case.
179 * process.c (Fformat_network_address): Use local var for size,
180 for brevity.
181
0df1eac5
PE
182 * bytecode.c (exec_byte_code): Don't use XVECTOR before CHECK_VECTOR.
183
847ab9d1 184 Make the Lisp reader and string-to-float more consistent (Bug#8525)
452f4150
PE
185 * data.c (atof): Remove decl; no longer used or needed.
186 (digit_to_number): Move to lread.c.
187 (Fstring_to_number): Use new string_to_number function, to be
188 consistent with how the Lisp reader treats infinities and NaNs.
189 Do not assume that floating-point numbers represent EMACS_INT
190 without losing information; this is not true on most 64-bit hosts.
191 Avoid double-rounding errors, by insisting on integers when
192 parsing non-base-10 numbers, as the documentation specifies.
193 * lisp.h (string_to_number): New decl, replacing ...
194 (isfloat_string): Remove.
bc0a5c13 195 * lread.c: Include <inttypes.h>, for uintmax_t and strtoumax.
d78050d6 196 (read1): Do not accept +. and -. as integers; this
452f4150
PE
197 appears to have been a coding error. Similarly, do not accept
198 strings like +-1e0 as floating point numbers. Do not report
199 overflow for integer overflows unless the base is not 10 which
200 means we have no simple and reliable way to continue.
201 Break out the floating-point parsing into a new
202 function string_to_number, so that Fstring_to_number parses
203 floating point numbers consistently with the Lisp reader.
204 (digit_to_number): Moved here from data.c. Make it static inline.
205 (E_CHAR, EXP_INT): Remove, replacing with ...
206 (E_EXP): New macro, to solve the "1.0e+" problem mentioned below.
207 (string_to_number): New function, replacing isfloat_string.
208 This function checks for valid syntax and produces the resulting
209 Lisp float number too. Rework it so that string-to-number
bc0a5c13 210 no longer mishandles examples like "1.0e+". Use strtoumax,
d78050d6
PE
211 so that overflow for non-base-10 numbers is reported only when
212 there's no portable and simple way to convert to floating point.
452f4150 213
67769ffc
PE
214 * textprop.c (set_text_properties_1): Rewrite for clarity,
215 and to avoid GCC warning about integer overflow.
216
c20db43f
PE
217 * intervals.h (struct interval): Use EMACS_INT for members
218 where EMACS_UINT might cause problems. See
219 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00514.html>.
220 (CHECK_TOTAL_LENGTH): Remove cast to EMACS_INT; no longer needed.
221 * intervals.c (interval_deletion_adjustment): Now returns EMACS_INT.
222 All uses changed.
37aa2f85
PE
223 (offset_intervals): Tell GCC not to worry about length overflow
224 when negating a negative length.
c20db43f 225
2538aa2f
PE
226 * alloc.c (overrun_check_malloc, overrun_check_realloc): Now static.
227 (overrun_check_free): Likewise.
228
f2d3008d
PE
229 * alloc.c (SDATA_SIZE) [!GC_CHECK_STRING_BYTES]: Avoid runtime check
230 in the common case where SDATA_DATA_OFFSET is a multiple of Emacs
231 word size.
232
ec8df744
PE
233 * gnutls.c: Fix problems found by GCC 4.6.0 on Ubuntu 10.10.
234 (gnutls_make_error): Rename local to avoid shadowing.
235 (gnutls_emacs_global_deinit): ifdef out; not used.
236 (Fgnutls_boot): Use const for pointer to readonly storage.
237 Comment out unused local. Fix pointer signedness problems.
238
640ee02d
PE
239 * lread.c (openp): Don't stuff size_t into an 'int'.
240 Use <= on length, not < on length + 1, to avoid GCC 4.6.0 warning
241 about possible signed overflow.
242
6048fb2a
PE
243 * gtkutil.c: Fix problems found by GCC 4.6.0 on Ubuntu 10.10.
244 (GDK_KEY_g): Don't define if already defined.
245 (xg_prepare_tooltip): Avoid pointer signedness problem.
246 (xg_set_toolkit_scroll_bar_thumb): Redo to avoid two casts.
247
fa3c87e1
PE
248 * process.c (Fnetwork_interface_info): Avoid left-shift undefined
249 behavior with 1 << 31. GCC 4.6.0 warns about this on 32-bit hosts.
250
2172544b
PE
251 * xfns.c (Fx_window_property): Simplify a bit,
252 to make a bit faster and to avoid GCC 4.6.0 warning.
253 * xselect.c (x_get_window_property, x_handle_dnd_message): Likewise.
254
9b821a21
PE
255 * fns.c (internal_equal): Don't assume size_t fits in int.
256
3c616cfa
PE
257 * alloc.c (compact_small_strings): Tighten assertion a little.
258
c2982e87
PE
259 Replace pEd with more-general pI, and fix some printf arg casts.
260 * lisp.h (pI): New macro, generalizing old pEd macro to other
261 conversion specifiers. For example, use "...%"pI"d..." rather
262 than "...%"pEd"...".
263 (pEd): Remove. All uses replaced with similar uses of pI.
264 * src/m/amdx86-64.h, src/m/ia64.h, src/m/ibms390x.h: Likewise.
265 * alloc.c (check_pure_size): Don't overflow by converting size to int.
266 * bidi.c (bidi_dump_cached_states): Use pI to avoid cast.
267 * data.c (Fnumber_to_string): Use pI instead of if-then-else-abort.
268 * dbusbind.c (xd_append_arg): Use pI to avoid cast.
269 (Fdbus_method_return_internal, Fdbus_method_error_internal): Likewise.
270 * font.c (font_unparse_xlfd): Avoid potential buffer overrun on
271 64-bit hosts.
272 (font_unparse_xlfd, font_unparse_fcname): Use pI to avoid casts.
273 * keyboard.c (record_char, modify_event_symbol): Use pI to avoid casts.
274 * print.c (safe_debug_print, print_object): Likewise.
275 (print_object): Don't overflow by converting EMACS_INT or EMACS_UINT
276 to int.
6f04d126
PE
277 Use pI instead of if-then-else-abort. Use %p to avoid casts,
278 avoiding the 0 flag, which is not portable.
c2982e87
PE
279 * process.c (Fmake_network_process): Use pI to avoid cast.
280 * region-cache.c (pp_cache): Likewise.
281 * xdisp.c (decode_mode_spec): Likewise.
282 * xrdb.c (x_load_resources) [USE_MOTIF]: Use pI to avoid undefined
283 behavior on 64-bit hosts with printf arg.
6f04d126 284 * xselect.c (x_queue_event): Use %p to avoid casts, avoiding 0 flag.
c2982e87
PE
285 (x_stop_queuing_selection_requests): Likewise.
286 (x_get_window_property): Don't truncate byte count to an 'int'
287 when tracing.
0b432f21 288
5e073ec7
PE
289 * frame.c (frame_name_fnn_p): Get rid of strtol, which isn't right
290 here, since it parses constructs like leading '-' and spaces,
291 which are not wanted; and it overflows with large numbers.
292 Instead, simply match F[0-9]+, which is what is wanted anyway.
293
36372bf9
PE
294 * alloc.c: Remove unportable assumptions about struct layout.
295 (SDATA_SELECTOR, SDATA_DATA_OFFSET): New macros.
296 (SDATA_OF_STRING, SDATA_SIZE, allocate_string_data):
297 (allocate_vectorlike, make_pure_vector): Use the new macros,
298 plus offsetof, to remove unportable assumptions about struct layout.
299 These assumptions hold on all porting targets that I know of, but
300 they are not guaranteed, they're easy to remove, and removing them
301 makes further changes easier.
302
0b432f21
PE
303 * alloc.c (BLOCK BYTES): Fix typo by changing "ablock" to "ablocks".
304 This doesn't fix a bug but makes the code clearer.
bfd1c781
PE
305 (string_overrun_cookie): Now const. Use initializers that
306 don't formally overflow signed char, to avoid warnings.
000098c1
PE
307 (allocate_string_data) [GC_CHECK_STRING_OVERRUN]: Fix typo that
308 can cause Emacs to crash when string overrun checking is enabled.
c7bda33c
PE
309 (allocate_buffer): Don't assume sizeof (struct buffer) is a
310 multiple of sizeof (EMACS_INT); it need not be, if
311 alignof(EMACS_INT) < sizeof (EMACS_INT).
d0f4e1f5 312 (check_sblock, check_string_bytes, check_string_free_list): Protoize.
0b432f21 313
895009e1
JB
3142011-04-26 Juanma Barranquero <lekktu@gmail.com>
315
316 * keyboard.c (QCrtl): Rename from Qrtl. All uses changed.
317
6a7a1b0b
TZ
3182011-04-26 Teodor Zlatanov <tzz@lifelogs.com>
319
320 * gnutls.c (emacs_gnutls_handshake): Return an error if we're not
b5f869a7 321 supposed to be handshaking. (Bug#8556)
6a7a1b0b
TZ
322 Reported by Paul Eggert <eggert@cs.ucla.edu>.
323
841a1577 3242011-04-26 Daniel Colascione <dan.colascione@gmail.com>
0438ce91
DC
325
326 * lisp.h (Qdebug): List symbol.
895009e1 327 * eval.c (Qdebug): Restore global linkage.
0438ce91
DC
328 * keyboard.c (debug-on-event): New variable.
329 (handle_user_signal): Break into debugger when debug-on-event
330 matches the current signal symbol.
331
f2d3ba6f
DN
3322011-04-25 Dan Nicolaescu <dann@ics.uci.edu>
333
334 * alloc.c (check_sblock, check_string_bytes)
335 (check_string_free_list): Convert to standard C.
336
42ce4c63
TZ
3372011-04-25 Teodor Zlatanov <tzz@lifelogs.com>
338
339 * w32.c (emacs_gnutls_push): Fix typo.
340
825cd63c
EZ
3412011-04-25 Eli Zaretskii <eliz@gnu.org>
342
fb11d64d
EZ
343 * gnutls.c (emacs_gnutls_handshake): Avoid compiler warnings about
344 "cast to pointer from integer of different size".
345
825cd63c
EZ
346 Improve doprnt and its use in verror. (Bug#8545)
347 * doprnt.c (doprnt): Document the set of format control sequences
348 supported by the function. Use SAFE_ALLOCA instead of always
349 using `alloca'.
350
351 * eval.c (verror): Don't limit the buffer size at size_max-1, that
352 is one byte too soon. Don't use xrealloc; instead xfree and
353 xmalloc anew.
354
e061a11b
TZ
3552011-04-24 Teodor Zlatanov <tzz@lifelogs.com>
356
357 * gnutls.h: Add GNUTLS_STAGE_CALLBACKS enum to denote we're in the
358 callbacks stage.
359
360 * gnutls.c: Renamed global_initialized to
361 gnutls_global_initialized. Added internals for the
362 :verify-hostname-error, :verify-error, and :verify-flags
363 parameters of `gnutls-boot' and documented those parameters in the
364 docstring. Start callback support.
365 (emacs_gnutls_handshake): Add Woe32 support. Retry handshake
366 unless a fatal error occured. Call gnutls_alert_send_appropriate
367 on error. Return error code.
368 (emacs_gnutls_write): Call emacs_gnutls_handle_error.
369 (emacs_gnutls_read): Likewise.
370 (Fgnutls_boot): Return handshake error code.
371 (emacs_gnutls_handle_error): New function.
372 (wsaerror_to_errno): Likewise.
373
374 * w32.h (emacs_gnutls_pull): Add prototype.
375 (emacs_gnutls_push): Likewise.
376
377 * w32.c (emacs_gnutls_pull): New function for GnuTLS on Woe32.
378 (emacs_gnutls_push): Likewise.
379
3802011-04-24 Claudio Bley <claudio.bley@gmail.com> (tiny change)
381
382 * process.c (wait_reading_process_output): Check if GnuTLS
383 buffered some data internally if no FDs are set for TLS
384 connections.
385
386 * makefile.w32-in (OBJ2): Add gnutls.$(O).
387 (LIBS): Link to USER_LIBS.
388 ($(BLD)/gnutls.$(0)): New target.
389
fa6996bc
EZ
3902011-04-24 Eli Zaretskii <eliz@gnu.org>
391
eb35682e
EZ
392 * xdisp.c (handle_single_display_spec): Rename the
393 display_replaced_before_p argument into display_replaced_p, to
394 make it consistent with the commentary. Fix typos in the
395 commentary.
396
e2ad650c
EZ
397 * textprop.c (syms_of_textprop): Remove dead code.
398 (copy_text_properties): Delete obsolete commentary about an
399 interface that was deleted long ago. Fix typos in the description
400 of arguments.
401
1b2de274
EZ
402 * msdos.c (XMenuActivate, XMenuAddSelection): Adjust argument list
403 to changes in oldXMenu/XMenu.h from 2011-04-16.
404 <menu_help_message, prev_menu_help_message>: Constify.
405 (IT_menu_make_room): menu->help_text is now `const char **';
406 adjust.
407
408 * msdos.h (XMenuActivate, XMenuAddSelection): Adjust prototypes
409 to changes in oldXMenu/XMenu.h from 2011-04-16.
410 (struct XMenu): Declare `help_text' `const char **'.
411
412 * xfaces.c <Qunspecified>: Make extern again.
413
414 * syntax.c: Include sys/types.h before including regex.h, as
415 required by Posix.
416
762b15be
EZ
417 * doc.c (get_doc_string): Improve the format passed to `error'.
418
419 * doprnt.c (doprnt): Improve commentary.
420
421 * term.c (init_tty) [MSDOS]: Fix 1st argument to maybe_fatal.
422
423 * Makefile.in (TAGS): Depend on $(M_FILE) and $(S_FILE), and scan
424 them with etags.
425
f1052e5d
EZ
426 * makefile.w32-in (globals.h): Add a dummy recipe, to make any
427 changes in globals.h immediately force recompilation.
762b15be
EZ
428 (TAGS): Depend on $(CURDIR)/m/intel386.h and
429 $(CURDIR)/s/ms-w32.h.
430 (TAGS-gmake): Scan $(CURDIR)/m/intel386.h and $(CURDIR)/s/ms-w32.h.
f1052e5d 431
fa6996bc
EZ
432 * character.c (Fchar_direction): Function deleted.
433 (syms_of_character): Don't defsubr it.
434 <char-direction-table>: Deleted.
435
e6c3da20
EZ
4362011-04-23 Eli Zaretskii <eliz@gnu.org>
437
438 Fix doprnt so it could be used again safely in `verror'. (Bug#8435)
439 * doprnt.c: Include limits.h.
440 (SIZE_MAX): New macro.
441 (doprnt): Return a size_t value. 2nd arg is now size_t. Many
442 local variables are now size_t instead of int or unsigned.
443 Improve overflow protection. Support `l' modifier for integer
444 conversions. Support %l conversion. Don't assume an EMACS_INT
445 argument for integer conversions and for %c.
446
447 * lisp.h (doprnt): Restore prototype.
448
449 * makefile.w32-in ($(BLD)/callint.$(O)): Depend on
450 $(SRC)/character.h.
451
452 * Makefile.in (base_obj): Add back doprnt.o.
453
454 * deps.mk (doprnt.o): Add back prerequisites.
455 (callint.o): Depend on character.h.
456
457 * eval.c (internal_lisp_condition_case): Include the handler
458 representation in the error message.
459 (verror): Call doprnt instead of vsnprintf. Fix an off-by-one bug
460 when breaking from the loop.
461
462 * xdisp.c (vmessage): Call doprnt instead of vsnprintf.
463
464 * callint.c (Fcall_interactively): When displaying error message
465 about invalid control letter, pass the character's codepoint, not
466 a pointer to its multibyte form. Improve display of the character
467 in octal and display also its hex code.
468
469 * character.c (char_string): Use %x to display the (unsigned)
470 codepoint of an invalid character, to avoid displaying a bogus
471 negative value.
472
473 * font.c (check_otf_features): Pass SDATA of SYMBOL_NAME to
474 `error', not SYMBOL_NAME itself.
475
476 * coding.c (Fencode_sjis_char, Fencode_big5_char): Use %c for
477 character arguments to `error'.
478
479 * charset.c (check_iso_charset_parameter): Fix incorrect argument
480 to `error' in error message about FINAL_CHAR argument. Make sure
481 FINAL_CHAR is a character, and use %c when it is passed as
482 argument to `error'.
483
4ffd0d6b 4842011-04-23 Eli Zaretskii <eliz@gnu.org>
97a93095
EZ
485
486 * s/ms-w32.h (localtime): Redirect to sys_localtime.
487
488 * w32.c: Include <time.h>.
489 (sys_localtime): New function.
490
4ffd0d6b 4912011-04-23 Chong Yidong <cyd@stupidchicken.com>
c17819f4
CY
492
493 * xdisp.c (init_xdisp): Initialize echo_area_window (Bug#6451).
494
4ffd0d6b 495 * buffer.c (syms_of_buffer): Doc fix (Bug#6902).
aac0c6e3 496
4ffd0d6b 4972011-04-23 Samuel Thibault <sthibault@debian.org> (tiny change)
aac0c6e3 498
4ffd0d6b
GM
499 * sysdep.c (wait_for_termination): On GNU Hurd, kill returns -1 on
500 zombies (Bug#8467).
aac0c6e3 501
04c56954
EZ
5022011-04-19 Eli Zaretskii <eliz@gnu.org>
503
504 * syntax.h (SETUP_SYNTAX_TABLE_FOR_OBJECT): Fix setting of
505 gl_state.e_property when gl_state.object is Qt.
506
507 * insdel.c (make_gap_larger): Remove limitation of buffer size
508 to <= INT_MAX.
509
16a43933
CY
5102011-04-18 Chong Yidong <cyd@stupidchicken.com>
511
512 * xdisp.c (lookup_glyphless_char_display)
513 (produce_glyphless_glyph): Handle cons cell entry in
514 glyphless-char-display.
515 (Vglyphless_char_display): Document it.
516
517 * term.c (produce_glyphless_glyph): Handle cons cell entry in
518 glyphless-char-display.
519
4581706e
CY
5202011-04-17 Chong Yidong <cyd@stupidchicken.com>
521
522 * xdisp.c (get_next_display_element): Remove unnecessary ifdefs.
523
524 * termhooks.h (FRAME_WINDOW_P): Remove duplicated definitions.
525
526 * dispextern.h (FACE_SUITABLE_FOR_ASCII_CHAR_P): Add missing
527 definition for no-X builds.
528
4887c6e2 5292011-04-16 Paul Eggert <eggert@cs.ucla.edu>
764430a3 530
fd35b6f9
PE
531 Static checks with GCC 4.6.0 and non-default toolkits.
532
5c1ccb01
PE
533 * s/sol2-6.h, s/unixware.h (PTY_TTY_NAME_SPRINTF): Protoize decl.
534
006c5daa
PE
535 * process.c (keyboard_bit_set): Define only if SIGIO.
536 (send_process_trap): Mark it with NO_RETURN if it doesn't return.
537 (send_process): Repair possible setjmp clobbering.
538
efc736d3
PE
539 * s/usg5-4-common.h (SETUP_SLAVE_PTY): Don't pass extra arg to 'fatal'.
540
4e2fe2e6
PE
541 * eval.c: Include <stdio.h>, for vsnprintf on non-GNU/Linux hosts.
542
f97334a2
PE
543 * data.c (arith_error): Mark with NO_RETURN if it doesn't return.
544
4e75f29d
PE
545 * alloc.c (bytes_used_when_full, SPARE_MEMORY, BYTES_USED):
546 Define only if needed.
547
90efadd1
PE
548 * sysdep.c (_FILE_OFFSET_BITS): Make this hack even uglier
549 by pacifying GCC about it. Maybe it's time to retire it?
875975e9 550 * xfaces.c (USG, __TIMEVAL__): Likewise.
90efadd1 551
3c647824
PE
552 * dispextern.h (struct redisplay_interface): Rename param
553 to avoid shadowing.
e264f262 554 * termhooks.h (struct terminal): Likewise.
761383f4 555 * xterm.c (xembed_send_message): Likewise.
3c647824 556
b58c5c4a
PE
557 * insdel.c (make_gap_smaller): Define only if
558 USE_MMAP_FOR_BUFFERS || REL_ALLOC || DOUG_LEA_MALLOC.
559
cad59032
PE
560 * keyboard.c (read_char): Make a var volatile so longjmp won't clobber
561 it.
562
c339dc2e
PE
563 * emacs.c (MAX_HEAP_BSS_DIFF, my_edata): Move to where they're used,
564 so that we aren't warned about unused symbols.
565
91a3e27b
PE
566 * xfns.c (Fx_file_dialog): Rename local to avoid shadowing.
567
399c71d3 568 * xdisp.c (x_produce_glyphs): Mark var as initialized (Bug#8512).
7a3fb125 569
8ffc96f5
PE
570 * xfns.c (x_real_positions): Mark locals as initialized.
571
eef9bc79
PE
572 * xmenu.c (xmenu_show): Don't use uninitialized vars.
573
098db9dd
PE
574 * xterm.c: Fix problems found by static analysis with other toolkits.
575 (toolkit_scroll_bar_interaction): Define and use only if USE_X_TOOLKIT.
dda3aedd
PE
576 (x_dispatch_event): Declare static if USE_GTK, and
577 define if USE_GTK || USE_X_TOOLKIT.
098db9dd 578 (SET_SAVED_BUTTON_EVENT): Define only if USE_X_TOOLKIT || USE_GTK.
dda3aedd 579 * xterm.h (x_dispatch_event): Extern only if USE_X_TOOLKIT.
841a1577
JB
580 * xterm.c, xterm.h (x_mouse_leave): Bring this function back, but only
581 if defined HAVE_MENUS && !defined USE_X_TOOLKIT && !defined USE_GTK.
098db9dd 582
eb18f6cc
PE
583 * xmenu.c (menu_help_callback): Pointer type fixes.
584 Use const pointers when pointing at readonly data. Avoid pointer
585 signedness clashes.
586 (FALSE): Remove unused macro.
587 (update_frame_menubar): Remove unused decl.
588
1fe72bf8
PE
589 * xfns.c (Fx_hide_tip): Move locals to avoid shadowing.
590
60d9e1db
PE
591 * menu.c (push_submenu_start, push_submenu_end): Do not define unless
592 USE_X_TOOLKIT || USE_GTK || HAVE_NS || defined HAVE_NTGUI.
593 (single_menu_item): Rename local to avoid shadowing.
594
39261c26
PE
595 * keyboard.c (make_lispy_event): Remove unused local var.
596
018c5e19
PE
597 * frame.c, frame.h (x_get_resource_string): Bring this back, but
598 only if HAVE_X_WINDOWS && !USE_X_TOOLKIT.
599
63d2b86e
PE
600 * bitmaps: Change bitmaps from unsigned char back to the X11
601 compatible char. Avoid the old compiler warnings about
602 out-of-range initializers by using, for example, '\xab' rather
603 than 0xab.
604
aefd87e1
PE
605 * xgselect.c (xgselect_initialize): Check vs interface
606 even if ! (defined (USE_GTK) || defined (HAVE_GCONF)).
607
bf501fb9
PE
608 * xmenu.c (xmenu_show): Rename parm to avoid shadowing.
609
e9829fdf
PE
610 * xterm.c (x_create_toolkit_scroll_bar): Use const * for pointers
611 to read-only memory.
612
1086c095
PE
613 * fns.c (vector): Remove; this old hack is no longer needed.
614
2baccd04 615 * xsmfns.c (create_client_leader_window): Rename shadowing arg.
401f10cb 616 Remove unused var.
dde42981 617 (gdk_x11_set_sm_client_id) [!USE_GTK]: Don't define.
2baccd04 618
72391843 619 * xrdb.c (x_load_resources): Omit unused local.
3565b346 620
436c16df 621 * xfns.c (free_frame_menubar, atof): Remove duplicate decls.
8a94ea33 622 (x_window): Rename locals to avoid shadowing.
dc5ddd85 623 (USG): Use the kludged USG macro, to pacify gcc.
436c16df 624
92bb796d 625 * xterm.c (x_alloc_nearest_color_for_widget): Remove; unused.
bbbef9e1 626 (x_term_init): Remove local to avoid shadowing.
92bb796d 627
764430a3 628 * xfns.c, xterm.c (_XEditResCheckMessages): Protoize decl.
4887c6e2
PE
629
630 * xdisp.c, dispextern.h (set_vertical_scroll_bar): Now extern if
631 USE_TOOLKIT_SCROLL_BARS && !USE_GTK, as xterm.c needs it then.
632
d1dfb56c
EZ
6332011-04-16 Eli Zaretskii <eliz@gnu.org>
634
c4354cb4
EZ
635 * gnutls.c (Fgnutls_boot): Don't pass Lisp_Object to `error'.
636
d1dfb56c
EZ
637 Fix regex.c, syntax.c and friends for buffers > 2GB.
638 * syntax.h (struct gl_state_s): Declare character position members
639 EMACS_INT.
640
641 * syntax.c (update_syntax_table): Declare 2nd argument EMACS_INT.
642
643 * textprop.c (verify_interval_modification, interval_of): Declare
644 arguments EMACS_INT.
645
646 * intervals.c (adjust_intervals_for_insertion): Declare arguments
647 EMACS_INT.
648
649 * intervals.h (CHECK_TOTAL_LENGTH): Cast to EMACS_INT, not `int'.
650
651 * indent.c (Fvertical_motion): Local variable it_start is now
652 EMACS_INT.
653
654 * regex.c (re_match, re_match_2, re_match_2_internal)
655 (bcmp_translate, regcomp, regexec, print_double_string)
656 (group_in_compile_stack, re_search, re_search_2, regex_compile)
657 (re_compile_pattern, re_exec): Declare arguments and local
658 variables `size_t' and `ssize_t' and return values `regoff_t', as
659 appropriate.
660 (POP_FAILURE_REG_OR_COUNT) <pfreg>: Declare `long'.
661 (CHECK_INFINITE_LOOP) <failure>: Declare `ssize_t'.
662 <compile_stack_type>: `size' and `avail' are now `size_t'.
663
664 * regex.h <regoff_t>: Use ssize_t, not int.
665 (re_search, re_search_2, re_match, re_match_2): Arguments that
666 specify buffer/string position and length are now ssize_t and
667 size_t. Return type is regoff_t.
668
613052cd
BK
6692011-04-16 Ben Key <bkey76@gmail.com>
670
671 * nsfont.m: Fixed bugs in ns_get_family and
672 ns_descriptor_to_entity that were caused by using free to
673 deallocate memory blocks that were allocated by xmalloc (via
674 xstrdup). This caused Emacs to crash when compiled with
675 XMALLOC_OVERRUN_CHECK defined (when Emacs was configured with
676 --enable-checking=xmallocoverrun). xfree is now used to
677 deallocate these memory blocks.
678
4170f62f 6792011-04-15 Paul Eggert <eggert@cs.ucla.edu>
3e047f51 680
71b41406
PE
681 * sysdep.c (emacs_read): Remove unnecessary check vs MAX_RW_COUNT.
682
9587a89d
PE
683 emacs_write: Accept and return EMACS_INT for sizes.
684 See http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00514.html
685 et seq.
686 * gnutls.c, gnutls.h (emacs_gnutls_read, emacs_gnutls_write):
687 Accept and return EMACS_INT.
688 (emacs_gnutls_write): Return the number of bytes written on
689 partial writes.
690 * sysdep.c, lisp.h (emacs_read, emacs_write): Likewise.
273a5f82
PE
691 (emacs_read, emacs_write): Remove check for negative size, as the
692 Emacs source code has been audited now.
9587a89d
PE
693 * sysdep.c (MAX_RW_COUNT): New macro, to work around kernel bugs.
694 (emacs_read, emacs_write): Use it.
273a5f82
PE
695 * process.c (send_process): Adjust to the new signatures of
696 emacs_write and emacs_gnutls_write. Do not attempt to store
697 a byte offset into an 'int'; it might overflow.
9587a89d 698 See http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00483.html
273a5f82 699
3e047f51
PE
700 * sound.c: Don't assume sizes fit in 'int'.
701 (struct sound_device.period_size, alsa_period_size):
9c3c56a7 702 Return EMACS_INT, not int.
3e047f51 703 (struct sound_device.write, vox_write, alsa_write):
9c3c56a7
PE
704 Accept EMACS_INT, not int.
705 (wav_play, au_play): Use EMACS_INT to store sizes and to
3e047f51
PE
706 record read return values.
707
cc39a9db
BK
7082011-04-15 Ben Key <bkey76@gmail.com>
709
c9d0ec6d
JB
710 * keyboard.c (Qundefined): Don't declare static since it is used
711 in nsfns.m.
712 * xfaces.c (Qbold, Qexpanded, Qitalic, Qcondensed): Don't declare
713 static since they are used in nsfont.m.
cc39a9db 714
6c60eb9f
SM
7152011-04-15 Stefan Monnier <monnier@iro.umontreal.ca>
716
717 * process.c (Qprocessp): Don't declare static.
718 * lisp.h (Qprocessp): Declare again.
719
7990b61a
JB
7202011-04-15 Juanma Barranquero <lekktu@gmail.com>
721
722 * font.c (Qopentype): Don't make static (used from w32uniscribe.c).
723
5d4cb038
PE
7242011-04-14 Paul Eggert <eggert@cs.ucla.edu>
725
8bd7b830 726 Improve C-level modularity by making more things 'static'.
cd64ea1d 727
e3b27b31
PE
728 Don't publish debugger-only interfaces to other modules.
729 * lisp.h (safe_debug_print, debug_output_compilation_hack):
730 (verify_bytepos, count_markers): Move decls to the only modules
731 that need them.
732 * region-cache.h (pp_cache): Likewise.
733 * window.h (check_all_windows): Likewise.
734 * marker.c, print.c, region-cache.c, window.c: Decls moved here.
735
5d4cb038
PE
736 * sysdep.c (croak): Now static, if
737 defined TIOCNOTTY || defined USG5 || defined CYGWIN.
738 * syssignal.h (croak): Declare only if not static.
69003fd8
PE
739
740 * alloc.c (refill_memory_reserve): Now static if
741 !defined REL_ALLOC || defined SYSTEM_MALLOC.
742 * lisp.h (refill_memory_reserve): Declare only if not static.
93ea6e8f 743
e87b6180
PE
744 * xsettings.c, xsettings.h (xsettings_get_system_normal_font):
745 Define only if USE_LUCID.
746
ac64929e
PE
747 * xrdb.c (x_customization_string, x_rm_string): Now static.
748
6f37259d
PE
749 * xmenu.c (x_menu_wait_for_event): Export only if USE_MOTIF.
750 * xterm.h (x_menu_wait_for_event): Declare only if USE_MOTIF.
751
1683e3ab
PE
752 * xdisp.c (draw_row_with_mouse_face): Now static.
753 * dispextern.h (draw_row_with_mouse_fave): Remove decl.
754
de9c2632
PE
755 * window.h (check_all_windows): Mark externally visible.
756
2b96acb7
PE
757 * window.c (window_deletion_count): Now static.
758
759 * undo.c: Make symbols static if they're not exported.
760 (last_undo_buffer, last_boundary_position, pending_boundary):
761 Now static.
762
50436f33
PE
763 * textprop.c (interval_insert_behind_hooks): Now static.
764 (interval_insert_in_front_hooks): Likewise.
765
64520e5c
PE
766 * term.c: Make symbols static if they're not exported.
767 (tty_turn_off_highlight, get_tty_terminal, max_frame_cols):
768 (max_frame_lines, tty_set_terminal_modes):
769 (tty_reset_terminal_modes, tty_turn_off_highlight):
770 (get_tty_terminal): Now static.
771 (term_mouse_moveto): Do not define if HAVE_WINDOW_SYSTEM.
772 * termhooks.h (term_mouse_moveto): Do not declare if
8bd7b830 773 HAVE_WINDOW_SYSTEM.
64520e5c
PE
774 * dispextern.h (tty_set_terminal_modes, tty_reset_terminal_modes):
775 (tty_turn_off_highlight, get_tty_terminal): Remove decls.
776
1fa53021
PE
777 * sysdep.c: Make symbols static if they're not exported.
778 (emacs_get_tty, emacs_set_tty, old_fcntl_flags, old_fcntl_owner):
779 Now static.
780 (sigprocmask_set, full_mask): Remove; unused.
781 (wait_debugging): Mark as visible.
782 * syssignal.h (SIGFULLMASK, full_mask): Remove decls.
783 * systty.h (emacs_get_tty, emacs_set_tty): Remove decls.
784
d4b43b22
PE
785 * syntax.c (syntax_temp): Define only if !__GNUC__.
786
b7c513d0
PE
787 * sound.c (current_sound_device, current_sound): Now static.
788
989b29ad
PE
789 * search.c (searchbufs, searchbuf_head): Now static.
790
13a55a78
PE
791 * scroll.c (scroll_cost): Remove; unused.
792 * dispextern.h (scroll_cost): Remove decl.
793
de68a1fc
PE
794 * region-cache.h (pp_cache): Mark as externally visible.
795
40ccffa6
PE
796 * process.c: Make symbols static if they're not exported.
797 (process_tick, update_tick, create_process, chan_process):
798 (Vprocess_alist, proc_buffered_char, datagram_access):
799 (fd_callback_data, send_process_frame, process_sent_to): Now static.
800 (deactivate_process): Mark defn as static, as well as decl.
801 * lisp.h (create_process): Remove decl.
802 * process.h (chan_process, Vprocess_alist): Remove decls.
803
ad64fc97
PE
804 * print.c: Make symbols static if they're not exported.
805 (print_depth, new_backquote_output, being_printed, print_buffer):
806 (print_buffer_size, print_buffer_pos, print_buffer_pos_byte):
807 (print_interval, print_number_index, initial_stderr_stream):
808 Now static.
809 * lisp.h (Fprinc): Remove decl.
810 (debug_output_compilation_hack): Mark as externally visible.
811
adddb265
PE
812 * sysdep.c (croak): Move decl from here to syssignal.h.
813 * syssignal.h (croak): Put it here, so the API can be checked when
814 'croak' is called from dissociate_if_controlling_tty.
815
1717ede2
PE
816 * minibuf.c: Make symbols static if they're not exported.
817 (minibuf_save_list, choose_minibuf_frame): Now static.
818 * lisp.h (choose_minibuf_frame): Remove decl.
819
fa5fb2bc
PE
820 * lisp.h (verify_bytepos, count_markers): Mark as externally visible.
821
1e3890d1
PE
822 * lread.c: Make symbols static if they're not exported.
823 (read_objects, initial_obarray, oblookup_last_bucket_number):
824 Now static.
825 (make_symbol): Remove; unused.
826 * lisp.h (initial_obarray, make_symbol): Remove decls.
827
8a1414fa
PE
828 * keyboard.c: Make symbols static if they're not exported.
829 (single_kboard, recent_keys_index, total_keys, recent_keys):
830 (this_command_key_count_reset, raw_keybuf, raw_keybuf_count):
831 (this_single_command_key_start, echoing, last_auto_save):
832 (read_key_sequence_cmd, dribble, recursive_edit_unwind):
833 (command_loop, echo_now, keyboard_init_hook, help_char_p):
834 (quit_throw_to_read_char, command_loop_2, top_level_1, poll_timer):
835 (Vlispy_mouse_stem, double_click_count):
836 Now static.
837 (force_auto_save_soon): Define only if SIGDANGER.
838 (ignore_mouse_drag_p): Now static if
839 !defined HAVE_WINDOW_SYSTEM || defined USE_GTK || defined HAVE_NS.
840 (print_help): Remove; unused.
841 (stop_character, last_timer_event): Mark as externally visible.
842 * keyboard.h (ignore_mouse_drag_p): Declare only if
843 defined HAVE_WINDOW_SYSTEM && !defined USE_GTK && !defined HAVE_NS.
844 (echo_now, help_char_p, quit_throw_to_read_char): Remove decls.
845 * lisp.h (echoing): Remove decl.
846 (force_auto_save_soon): Declare only if SIGDANGER.
847 * xdisp.c (redisplay_window): Simplify code, to make it more
848 obvious that ignore_mouse_drag_p is not accessed if !defined
849 USE_GTK && !defined HAVE_NS.
850
93ea6e8f
PE
851 * intervals.c: Make symbols static if they're not exported.
852 (merge_properties_sticky, merge_interval_right, delete_interval):
853 Now static.
854 * intervals.h (merge_interval_right, delete_interval): Remove decls.
855
77382fcc
PE
856 * insdel.c: Make symbols static if they're not exported.
857 However, leave prepare_to_modify_buffer alone. It's never
858 called from outside this function, but that appears to be a bug.
859 (combine_after_change_list, combine_after_change_buffer):
4889fc82 860 (adjust_after_replace, signal_before_change): Now static.
77382fcc
PE
861 (adjust_after_replace_noundo): Remove; unused.
862 * lisp.h (adjust_after_replace, adjust_after_replace_noundo):
4889fc82 863 (signal_before_change): Remove decls.
77382fcc 864
9306c32e
PE
865 * indent.c (val_compute_motion, val_vmotion): Now static.
866
cd44d2eb
PE
867 * image.c: Make symbols static if they're not exported.
868 * dispextern.h (x_create_bitmap_from_xpm_data): Do not declare
869 if USE_GTK.
870 * image.c (x_create_bitmap_from_xpm_data): Do not define if USE_GTK.
871 (xpm_color_cache, ct_table, ct_colors_allocated): Now static.
872
ad9a7a06
PE
873 * fringe.c (standard_bitmaps): Now static.
874 (max_used_fringe_bitmap): Now static, unless HAVE_NS.
875
81626931
PE
876 * frame.c: Make symbols static if they're not exported.
877 (x_report_frame_params, make_terminal_frame): Now static.
878 (get_frame_param): Now static, unless HAVE_NS.
879 (x_fullscreen_adjust): Define if WINDOWSNT, not if HAVE_WINDOW_SYSTEM.
880 (x_get_resource_string): Remove; not used.
881 * frame.h (make_terminal_frame, x_report_frame_params):
882 (x_get_resource_string); Remove decls.
883 (x_fullscreen_adjust): Declare only if WINDOWSNT.
884 * lisp.h (get_frame_param): Declare only if HAVE_NS.
885
239f9db9
PE
886 * font.c, fontset.c: Make symbols static if they're not exported.
887 * dispextern.h (FACE_SUITABLE_FOR_ASCII_CHAR_P): New macro.
888 (FACE_SUITABLE_FOR_CHAR_P): Use it.
889 * font.c (font_close_object): Now static.
890 * font.h (font_close_object): Remove.
891 * fontset.c (FONTSET_OBJLIST): Remove.
892 (free_realized_fontset) #if-0 the body, which does nothing.
893 (face_suitable_for_char_p): #if-0, as it's never called.
894 * fontset.h (face_suitable_for_char_p): Remove decl.
895 * xfaces.c (face_at_string_position): Use
896 FACE_SUITABLE_FOR_ASCII_CHAR_P, not FACE_SUITABLE_FOR_CHAR_P,
897 since 0 is always ASCII.
898
dfcf3579
PE
899 * fns.c (weak_hash_tables): Now static.
900
5045092b
PE
901 * fileio.c: Make symbols static if they're not exported.
902 (auto_saving, auto_save_mode_bits, auto_save_error_occurred):
903 (Vwrite_region_annotation_buffers): Now static.
904
57a96f5c
PE
905 * eval.c: Make symbols static if they're not exported.
906 (backtrace_list, lisp_eval_depth, when_entered_debugger): Now static.
907 * lisp.h (backtrace_list): Remove decl.
908
35f08c38
PE
909 * emacs.c: Make symbols static if they're not exported.
910 (malloc_state_ptr, malloc_using_checking, syms_of_emacs):
911 (fatal_error_code, fatal_error_signal_hook, standard_args):
912 Now static.
913 (fatal_error_signal): Now static, unless FLOAT_CATCH_SIGKILL.
914 (DEFINE_DUMMY_FUNCTION): Mark function as externally visible.
915 (__CTOR_LIST__, __DTOR_LIST__): Now externally visible.
916 * lisp.h (fatal_error_signal_hook): Remove decl.
917 (fatal_error_signal): Declare only if FLOAT_CATCH_SIGKILL.
918
f44bd759
PE
919 * editfns.c: Move a (normally-unused) function to its only use.
920 * editfns.c, lisp.h (get_operating_system_release): Remove.
921 * process.c (init_process) [DARWIN_OS]: Do it inline, as it is not
922 worth the hassle of breaking this out.
923
b532497d
PE
924 * xterm.c: Make symbols static if they're not exported.
925 (x_raise_frame, x_lower_frame, x_wm_set_window_state):
926 (x_wm_set_icon_pixmap, x_initialize, XTread_socket_fake_io_error):
927 (x_destroy_window, x_delete_display):
928 Now static.
929 (x_dispatch_event): Now static if ! (USE_MOTIF || USE_X_TOOLKIT).
930 (x_mouse_leave): Remove; unused.
931 * xterm.h (x_display_info_for_name, x_raise_frame, x_lower_frame):
932 (x_destroy_window, x_wm_set_window_state, x_wm_set_icon_pixmap):
933 (x_delete_display, x_initialize, x_set_border_pixel, x_screen_planes):
934 Remove decls.
935 (x_mouse_leave): Declare only if WINDOWSNT.
936 (x_dispatch_event): Declare only if USE_MOTIF or USE_X_TOOLKIT.
937 (xic_create_fontsetname): Declare only if HAVE_X_WINDOWS &&
938 USE_X_TOOLKIT.
939
1675728f
PE
940 * ftxfont.c: Make symbols static if they're not exported.
941 (ftxfont_driver): Export only if !defined HAVE_XFT && def8ined
942 HAVE_FREETYPE.
943 * font.h (ftxfont_driver): Likewise.
944
e4cebfca
PE
945 * xfns.c: Make symbols static if they're not exported.
946 (x_last_font_name, x_display_info_for_name):
947 (x_set_foreground_color, x_set_background_color, x_set_mouse_color):
948 (x_set_cursor_color, x_set_border_pixel, x_set_border_color):
949 (x_set_cursor_type, x_set_icon_type, x_set_icon_name):
950 (x_set_scroll_bar_foreground, x_set_scroll_bar_background):
951 (x_explicitly_set_name, x_set_title, xic_defaut_fontset, tip_timer):
952 (last_show_tip_args): Now static.
953 (xic_defaut_fontset, xic_create_fontsetname): Define only if
954 defined HAVE_X_WINDOWS && defined USE_X_TOOLKIT
955 (x_screen_planes): Remove; unused.
956 * dispextern.h (x_screen_planes): Remove decl.
957
5bf46f05
PE
958 * dispnew.c: Make symbols static if they're not exported.
959 * dispextern.h (redraw_garbaged_frames, scrolling):
960 (increment_row_positions): Remove.
961 * dispnew.c (new_glyph_matrix, increment_row_positions, scrolling):
962 (delayed_size_change, glyph_matrix_count, glyph_pool_count):
963 Now static.
964 (redraw_garbaged_frames): Remove; unused.
965
435f4c28
PE
966 * xfaces.c: Make symbols static if they're not exported.
967 * dispextern.h (ascii_face_of_lisp_face, free_realized_face):
968 Remove decls.
969 * xterm.h (defined_color): Remove decls.
970 (x_free_dpy_colors): Declare only if USE_X_TOOLKIT.
971 * xfaces.c (tty_suppress_bold_inverse_default_colors_p):
972 (menu_face_changed_default, defined_color, free_realized_face):
973 (x_free_dpy_colors): Define only if USE_X_TOOLKIT.
974 (ascii_face_of_lisp_face): Remove; unused.
975
8524aef3
PE
976 * xdisp.c: Make symbols static if they're not exported.
977 * dispextern.h (scratch_glyph_row, window_box_edges):
978 (glyph_to_pixel_coords, set_cursor_from_row):
979 (get_next_display_element, set_iterator_to_next):
980 (highlight_trailing_whitespace, frame_to_window_pixel_xy):
981 (show_mouse_face): Remove decls
982 * frame.h (message_buf_print): Likewise.
983 * lisp.h (pop_message, set_message, check_point_in_composition):
984 Likewise.
985 * xterm.h (set_vertical_scroll_bar): Likewise.
986 * xdisp.c (list_of_error, Vmessage_stack, line_number_displayed):
987 (message_buf_print, scratch_glyph_row, displayed_buffer):
988 (set_iterator_to_next, pop_message, set_message, set_cursor_from_row):
989 (get_next_display_element, show_mouse_face, window_box_edges):
990 (frame_to_window_pixel_xy, check_point_in_composition):
991 (set_vertical_scroll_bar, highlight_trailing_whitespace): Now static.
992 (glyph_to_pixel_coords): Remove; unused.
993
16390cd2
PE
994 * dired.c (file_name_completion): Now static.
995
996 * dbusbind.c (xd_in_read_queued_messages): Now static.
997
a25f4dfa
PE
998 * lisp.h (circular_list_error, FOREACH): Remove; unused.
999 * data.c (circular_list_error): Remove.
1000
14a9c8df
PE
1001 * commands.h (last_point_position, last_point_position_buffer):
1002 (last_point_position_window): Remove decls.
1003 * keyboard.c: Make these variables static.
1004
74ab6df5
PE
1005 * coding.h (coding, code_convert_region, encode_coding_gap): Remove
1006 decls.
1007 * coding.c (Vsjis_coding_system, Vbig5_coding_system):
1008 (iso_code_class, detect_coding, code_convert_region): Now static.
1009 (encode_coding_gap): Remove; unused.
1010
38dfbee1
PE
1011 * chartab.c (chartab_chars, chartab_bits): Now static.
1012
a2cb4e63
PE
1013 * charset.h (charset_iso_8859_1): Remove decl.
1014 * charset.c (charset_iso_8859_1, charset_emacs, map_charset_for_dump):
1015 Now static.
1016
127198fd
PE
1017 * ccl.h (check_ccl_update, Vccl_program_table): Remove decls.
1018 * ccl.c (Vccl_program_table): Now static.
1019 (check_ccl_update): Remove; unused.
1020
d85b608f
PE
1021 * category.c (SET_CATEGORY_SET, set_category_set): Move here.
1022 * category.h: ... from here.
1023 * category.c (check_category_table, set_category_set): Now static.
1024
31cd66f3
PE
1025 * casetab.c (Vascii_upcase_table, Vascii_eqv_table): Now static.
1026 * lisp.h: Remove these decls.
1027
c358e587
PE
1028 * buffer.c (buffer_count): Remove unused var.
1029
e78aecca
PE
1030 * bidi.c (bidi_dump_cached_states): Mark as externally visible,
1031 so that it's not optimized away.
1032 (bidi_ignore_explicit_marks_for_paragraph_level): Likewise.
1033 * dispextern.h (bidi_dump_cached_states): Remove, since it's
1034 exported only to the debugger.
1035
e192d7d3
PE
1036 * atimer.c (alarm_signal_handler, run_all_atimers): Now static.
1037 * atimer.h (run_all_atimers): Removed; not exported.
1038
92470028
PE
1039 font.c: Make copy_font_spec and merge_font_spec ordinary C functions.
1040 * font.c (copy_font_spec): Rename from Fcopy_font_spec, since it
1041 was inaccessible from Lisp.
1042 (merge_font_spec): Likewise, renaming from Fmerge_font_spec.
1043 * font.c, font.h, fontset.c, xfaces.c, xfont.c: Change all uses.
1044
244ed907
PE
1045 alloc.c: Import and export fewer symbols, and remove unused items.
1046 * lisp.h (suppress_checking, die): Declare only if ENABLE_CHECKING
1047 is defined.
1048 (suppress_checking): Add EXTERNALLY_VISIBLE attribute, so that
1049 it's not optimized away by whole-program optimization.
1050 (message_enable_multibyte, free_misc): Remove.
1051 (catchlist, handlerlist, mark_backtrace):
1052 Declare only if BYTE_MARK_STACK.
1053 (mark_byte_stack): Likewise, fixing a ifdef-vs-if typo.
1054 * alloc.c (pure): Export only if VIRT_ADDR_VARIES is defined.
1055 (message_enable_multibyte): Remove decl.
1056 (free_misc, interval_free_list, float_block, float_block_index):
1057 (n_float_blocks, float_free_list, cons_block, cons_block_index):
1058 (cons_free_list, last_marked_index):
1059 Now static.
1060 (suppress_checking, die): Define only if ENABLE_CHECKING is defined.
1061 * eval.c (catchlist, handlerlist): Export only if BYTE_MARK_STACK.
1062 (mark_backtrace): Define only if BYTE_MARK_STACK.
1063 * xdisp.c (message_enable_multibyte): Now static.
1064
61c2b50e 1065 Declare Lisp_Object Q* variables to be 'static' if not exported.
955cbe7b
PE
1066 This makes it easier for human readers (and static analyzers)
1067 to see whether these variables are used from other modules.
1068 * alloc.c, buffer.c, bytecode.c, callint.c, casetab.c, category.c:
1069 * ccl.c, character.c, charset.c, cmds.c, coding.c, composite.c:
1070 * data.c, dbusbind.c, dired.c, editfns.c, eval.c, fileio.c, fns.c:
1071 * font.c, frame.c, fringe.c, ftfont.c, image.c, keyboard.c, keymap.c:
1072 * lread.c, macros.c, minibuf.c, print.c, process.c, search.c:
1073 * sound.c, syntax.c, textprop.c, window.c, xdisp.c, xfaces.c, xfns.c:
1074 * xmenu.c, xselect.c:
1075 Declare Q* vars static if they are not used in other modules.
1076 * ccl.h, character.h, charset.h, coding.h, composite.h, font.h:
1077 * frame.h, intervals.h, keyboard.h, lisp.h, process.h, syntax.h:
1078 Remove decls of unexported vars.
1079 * keyboard.h (EVENT_HEAD_UNMODIFIED): Remove now-unused macro.
1080
95c82688
PE
1081 * lisp.h (DEFINE_FUNC): Make sname 'static'.
1082
16a97296
PE
1083 Make Emacs functions such as Fatom 'static' by default.
1084 This makes it easier for human readers (and static analyzers)
1085 to see whether these functions can be called from other modules.
1086 DEFUN now defines a static function. To make the function external
1087 so that it can be used in other C modules, use the new macro DEFUE.
8bd7b830
PE
1088 * lisp.h (Funibyte_char_to_multibyte, Fsyntax_table_p):
1089 (Finit_image_library):
16a97296
PE
1090 (Feval_region, Fbacktrace, Ffetch_bytecode, Fswitch_to_buffer):
1091 (Ffile_executable_p, Fmake_symbolic_link, Fcommand_execute):
1092 (Fget_process, Fdocumentation_property, Fbyte_code, Ffile_attributes):
1093 Remove decls, since these functions are now static.
1094 (Funintern, Fget_internal_run_time): New decls, since these functions
1095 were already external.
95c82688 1096
16a97296
PE
1097 * alloc.c, buffer.c, callint.c, callproc.c, casefiddle.c, casetab.c:
1098 * ccl.c, character.c, chartab.c, cmds.c, coding.c, data.c, dispnew.c:
1099 * doc.c, editfns.c, emacs.c, eval.c, fileio.c, filelock.c, floatfns.c:
1100 * fns.c, font.c, fontset.c, frame.c, image.c, indent.c:
1101 * keyboard.c, keymap.c, lread.c:
1102 * macros.c, marker.c, menu.c, minibuf.c, print.c, process.c, search.c:
1103 * syntax.c, term.c, terminal.c, textprop.c, undo.c:
1104 * window.c, xdisp.c, xfaces.c, xfns.c, xmenu.c, xsettings.c:
1105 Mark functions with DEFUE instead of DEFUN,
1106 if they are used in other modules.
1107 * buffer.c (Fset_buffer_major_mode, Fdelete_overlay): New forward
1108 decls for now-static functions.
1109 * buffer.h (Fdelete_overlay): Remove decl.
1110 * callproc.c (Fgetenv_internal): Mark as internal.
1111 * composite.c (Fremove_list_of_text_properties): Remove decl.
1112 (Fcomposition_get_gstring): New forward static decl.
1113 * composite.h (Fcomposite_get_gstring): Remove decl.
1114 * dired.c (Ffile_attributes): New forward static decl.
1115 * doc.c (Fdocumntation_property): New forward static decl.
1116 * eval.c (Ffetch_bytecode): New forward static decl.
1117 (Funintern): Remove extern decl; now in .h file where it belongs.
1118 * fileio.c (Fmake_symbolic_link): New forward static decl.
1119 * image.c (Finit_image_library): New forward static decl.
1120 * insdel.c (Fcombine_after_change_execute): Make forward decl static.
1121 * intervals.h (Fprevious_property_change):
1122 (Fremove_list_of_text_properties): Remove decls.
1123 * keyboard.c (Fthis_command_keys): Remove decl.
1124 (Fcommand_execute): New forward static decl.
1125 * keymap.c (Flookup_key): New forward static decl.
1126 (Fcopy_keymap): Now static.
1127 * keymap.h (Flookup_key): Remove decl.
1128 * process.c (Fget_process): New forward static decl.
1129 (Fprocess_datagram_address): Mark as internal.
1130 * syntax.c (Fsyntax_table_p): New forward static decl.
1131 (skip_chars): Remove duplicate decl.
1132 * textprop.c (Fprevious_property_change): New forward static decl.
1133 * window.c (Fset_window_fringes, Fset_window_scroll_bars):
1134 Now internal.
1135 (Fset_window_margins, Fset_window_vscroll): New forward static decls.
1136 * window.h (Fset_window_vscroll, Fset_window_margins): Remove decls.
1137
785bbd42
PE
1138 * editfns.c (Fformat): Remove unreachable code.
1139
8b913b57
AS
11402011-04-14 Andreas Schwab <schwab@linux-m68k.org>
1141
1142 * fileio.c (Finsert_file_contents): Fix typo in 2005-05-13
1143 change. (Bug#8496)
1144
a6744a35
EZ
11452011-04-13 Eli Zaretskii <eliz@gnu.org>
1146
1147 * xdisp.c (handle_invisible_prop): Don't call bidi_paragraph_init
1148 when at ZV. (Bug#8487)
1149
e7974947
AS
11502011-04-12 Andreas Schwab <schwab@linux-m68k.org>
1151
baad03f0
AS
1152 * charset.c (Fclear_charset_maps): Use xfree instead of free.
1153 (Bug#8437)
1154 * keyboard.c (parse_tool_bar_item): Likewise.
1155 * sound.c (sound_cleanup, alsa_close): Likewise.
1156 * termcap.c (tgetent): Likewise.
1157 * xfns.c (x_default_font_parameter): Likewise.
1158 * xsettings.c (read_and_apply_settings): Likewise.
1159
e7974947
AS
1160 * alloc.c (overrun_check_malloc, overrun_check_realloc)
1161 (overrun_check_free): Protoize.
1162
28272684
PE
11632011-04-12 Paul Eggert <eggert@cs.ucla.edu>
1164
1165 * sysdep.c (emacs_read, emacs_write): Check for negative sizes
1166 since callers should never pass a negative size.
1167 Change the signature to match that of plain 'read' and 'write'; see
1168 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00397.html>.
1169 * lisp.h: Update prototypes of emacs_write and emacs_read.
1170
11997c76
EZ
11712011-04-11 Eli Zaretskii <eliz@gnu.org>
1172
1173 * xdisp.c (redisplay_window): Don't try to determine the character
1174 position of the scroll margin if the window start point w->startp
e896f03c 1175 is outside the buffer's accessible region. (Bug#8468)
11997c76 1176
8a2cbd72
EZ
11772011-04-10 Eli Zaretskii <eliz@gnu.org>
1178
1179 Fix write-region and its subroutines for buffers > 2GB.
1180 * fileio.c (a_write, e_write): Modify declaration of arguments and
1181 local variables to support buffers larger than 2GB.
1182 (Fcopy_file): Use EMACS_INT for return value of emacs_read.
1183
1184 * sysdep.c (emacs_write, emacs_read): Use ssize_t for last
1185 argument, local variables, and return value.
1186
1187 * lisp.h: Update prototypes of emacs_write and emacs_read.
1188
1189 * sound.c (vox_write): Use ssize_t for return value of emacs_write.
1190
4073e537 11912011-04-10 Paul Eggert <eggert@cs.ucla.edu>
eb3f1cc8 1192
1ebfdcb6
PE
1193 * xdisp.c (vmessage): Use memchr, not strnlen, which some hosts lack.
1194
b2ded58d
PE
1195 Fix more problems found by GCC 4.6.0's static checks.
1196
7d66342c
PE
1197 * xdisp.c (vmessage): Use a better test for character truncation.
1198
bbf47d44
PE
1199 * charset.c (load_charset_map): <, not <=, for optimization,
1200 and to avoid potential problems with integer overflow.
9248994d 1201 * chartab.c (sub_char_table_set_range, char_table_set_range): Likewise.
f9a68bc5 1202 * casetab.c (set_identity, shuffle): Likewise.
3ab1c7ce 1203 * editfns.c (Fformat): Likewise.
1e69125e 1204 * syntax.c (skip_chars): Likewise.
3befa583 1205
e3019616
PE
1206 * xmenu.c (set_frame_menubar): Allocate smaller local vectors.
1207 This also lets GCC 4.6.0 generate slightly better loop code.
1208
becfa255
PE
1209 * callint.c (Fcall_interactively): <, not <=, for optimization.
1210 (Fcall_interactively): Count the number of arguments produced,
1211 not the number of arguments given. This is simpler and lets GCC
1212 4.6.0 generate slightly better code.
1213
dae0cd48
PE
1214 * ftfont.c: Distingish more carefully between FcChar8 and char.
1215 The previous code passed unsigned char * to a functions like
1216 strlen and xstrcasecmp that expect char *, which does not
1217 conform to the C standard.
1218 (get_adstyle_property, ftfont_pattern_entity): Use FcChar8 for
1219 arguments to FcPatternGetString, and explicitly cast FcChar8 * to
1220 char * when the C standard requires it.
1221
76032d70
PE
1222 * keyboard.c (read_char): Remove unused var.
1223
eb3f1cc8
PE
1224 * eval.c: Port to Windows vsnprintf (Bug#8435).
1225 Include <limits.h>.
1226 (SIZE_MAX): Define if the headers do not.
1227 (verror): Do not give up if vsnprintf returns a negative count.
1228 Instead, grow the buffer. This ports to Windows vsnprintf, which
1229 does not conform to C99. Problem reported by Eli Zaretskii.
1230 Also, simplify the allocation scheme, by avoiding the need for
1231 calling realloc, and removing the ALLOCATED variable.
1232
70476b54
PE
1233 * eval.c (verror): Initial buffer size is 4000 (not 200) bytes.
1234
12020a9e
PE
1235 Remove invocations of doprnt, as Emacs now uses vsnprintf.
1236 But keep the doprint source code for now, as we might revamp it
1237 and use it again (Bug#8435).
ea6c7ae6
PE
1238 * lisp.h (doprnt): Remove.
1239 * Makefile.in (base_obj): Remove doprnt.o.
1240 * deps.mk (doprnt.o): Remove.
1241
5fdb398c
PE
1242 error: Print 32- and 64-bit integers portably (Bug#8435).
1243 Without this change, on typical 64-bit hosts error ("...%d...", N)
1244 was used to print both 32- and 64-bit integers N, which relied on
1245 undefined behavior.
1246 * lisp.h, src/m/amdx86-64.h, src/m/ia64.h, src/m/ibms390x.h (pEd):
1247 New macro.
1248 * lisp.h (error, verror): Mark as printf-like functions.
1249 * eval.c (verror): Use vsnprintf, not doprnt, to do the real work.
1250 Report overflow in size calculations when allocating printf buffer.
1251 Do not truncate output string at its first null byte.
1252 * xdisp.c (vmessage): Use vsnprintf, not doprnt, to do the real work.
1253 Truncate the output at a character boundary, since vsnprintf does not
1254 do that.
1255 * charset.c (check_iso_charset_parameter): Convert internal
1256 character to string before calling 'error', since %c now has the
1257 printf meaning.
1258 * coding.c (Fdecode_sjis_char, Fdecode_big5_char): Avoid int
1259 overflow when computing char to be passed to 'error'. Do not
1260 pass Lisp_Object to 'error'; pass the integer instead.
1261 * nsfns.m (Fns_do_applescript): Use int, not long, since it's
1262 formatted with plain %d.
1263
b189fa66
PE
1264 * eval.c (internal_lisp_condition_case): Don't pass spurious arg.
1265
bff87ef0
PE
1266 * keyboard.c (access_keymap_keyremap): Print func name, not garbage.
1267
7e2cac20
PE
1268 * coding.c (Fdecode_sjis_char): Don't assume CODE fits in int.
1269
ce4d90b5
PE
1270 * xterm.c (x_catch_errors): Remove duplicate declaration.
1271
266c9547
PE
1272 * term.c (maybe_fatal): Mark its 3rd arg as a printf format, too.
1273
79c49ad2
PE
1274 * xdisp.c, lisp.h (message_nolog): Remove; unused.
1275
368f4090
JM
12762011-04-10 Jim Meyering <meyering@redhat.com>
1277
1278 use ssize_t and size_t for read- and write-like emacs_gnutls_* functions
1279 * gnutls.c (emacs_gnutls_read): Adjust signature to be more read-like:
1280 return ssize_t not "int", and use size_t as the buffer length.
1281 (emacs_gnutls_write): Likewise, and make the buffer pointer "const".
1282 * gnutls.h: Update declarations.
1283 * process.c (read_process_output): Use ssize_t, to match.
1284 (send_process): Likewise.
1285
a32d4040
CY
12862011-04-09 Chong Yidong <cyd@stupidchicken.com>
1287
1288 * image.c (Fimagemagick_types): Doc fix, and comment cleanup.
1289
8546720e 12902011-04-09 Chong Yidong <cyd@stupidchicken.com>
aac0c6e3 1291
8546720e
GM
1292 * ftfont.c (get_adstyle_property, ftfont_pattern_entity): Use
1293 unsigned char, to match FcChar8 type definition.
aac0c6e3 1294
8546720e
GM
1295 * xterm.c (handle_one_xevent):
1296 * xmenu.c (create_and_show_popup_menu):
1297 * xselect.c (x_decline_selection_request)
1298 (x_reply_selection_request): Avoid type-punned deref of X events.
aac0c6e3 1299
0a2f5c1a 13002011-04-09 Eli Zaretskii <eliz@gnu.org>
a53e2e89
EZ
1301
1302 Fix some uses of `int' instead of EMACS_INT.
1303 * search.c (string_match_1, fast_string_match)
1304 (fast_c_string_match_ignore_case, fast_string_match_ignore_case)
1305 (scan_buffer, find_next_newline_no_quit)
1306 (find_before_next_newline, search_command, Freplace_match)
1307 (Fmatch_data): Make some `int' variables be EMACS_INT.
1308
1309 * xdisp.c (display_count_lines): 3rd argument and return value now
1310 EMACS_INT. All callers changed.
1311 (pint2hrstr): Last argument is now EMACS_INT.
1312
1313 * coding.c (detect_coding_utf_8, detect_coding_emacs_mule)
1314 (detect_coding_iso_2022, detect_coding_sjis, detect_coding_big5)
1315 (detect_coding_ccl, detect_coding_charset, decode_coding_utf_8)
1316 (decode_coding_utf_16, decode_coding_emacs_mule)
1317 (decode_coding_iso_2022, decode_coding_sjis, decode_coding_big5)
1318 (decode_coding_ccl, decode_coding_charset)
1319 <consumed_chars, consumed_chars_base>: Declare EMACS_INT.
1320 (decode_coding_iso_2022, decode_coding_emacs_mule)
1321 (decode_coding_sjis, decode_coding_big5, decode_coding_charset)
1322 <char_offset, last_offset>: Declare EMACS_INT.
1323 (encode_coding_utf_8, encode_coding_utf_16)
1324 (encode_coding_emacs_mule, encode_invocation_designation)
1325 (encode_designation_at_bol, encode_coding_iso_2022)
1326 (encode_coding_sjis, encode_coding_big5, encode_coding_ccl)
1327 (encode_coding_raw_text, encode_coding_charset) <produced_chars>:
1328 Declare EMACS_INT.
1329 (ASSURE_DESTINATION): Declare more_bytes EMACS_INT.
1330 (encode_invocation_designation): Last argument P_NCHARS is now
1331 EMACS_INT.
1332 (decode_eol): Declare pos_byte, pos, and pos_end EMACS_INT.
1333 (produce_chars): from_nchars and to_nchars are now EMACS_INT.
1334
1335 * coding.h (struct coding_system) <head_ascii>: Declare EMACS_INT.
1336 All users changed.
1337
1338 * ccl.c (Fccl_execute_on_string): Declare some variables
1339 EMACS_INT.
1340
8546720e 13412011-04-08 Samuel Thibault <sthibault@debian.org> (tiny change)
0080dc6b
SS
1342
1343 * term.c (init_tty): Fix incorrect ifdef placement (Bug#8450).
1344
4e19a977
CS
13452011-03-19 Christoph Scholtes <cschol2112@googlemail.com>
1346
1347 * process.c (Fformat_network_address): Doc fix.
1348
87302331
R
13492011-04-08 T.V. Raman <tv.raman.tv@gmail.com> (tiny change)
1350
1351 * xml.c (parse_region): Avoid creating spurious whiespace nodes.
1352
cbb59342
CY
13532011-04-08 Chong Yidong <cyd@stupidchicken.com>
1354
1355 * keyboard.c (read_char): Call Lisp function help-form-show,
1356 instead of using internal_with_output_to_temp_buffer.
1357 (Qhelp_form_show): New var.
e0d38eeb 1358 (syms_of_keyboard): Use DEFSYM macro.
cbb59342
CY
1359
1360 * print.c (internal_with_output_to_temp_buffer): Function deleted.
1361
1362 * lisp.h (internal_with_output_to_temp_buffer): Remove prototype.
1363
e67a13ab
CY
13642011-04-06 Chong Yidong <cyd@stupidchicken.com>
1365
1366 * process.c (Flist_processes): Removed to Lisp.
1367 (list_processes_1): Deleted.
1368
973f782d
EZ
13692011-04-06 Eli Zaretskii <eliz@gnu.org>
1370
7c106b1e
EZ
1371 * msdos.c (careadlinkat, careadlinkatcwd): MS-DOS replacements.
1372
973f782d
EZ
1373 * w32.c (careadlinkat, careadlinkatcwd): New always-fail stubs.
1374
41cf7d1a 13752011-04-06 Paul Eggert <eggert@cs.ucla.edu>
27ccc379 1376
ca23cc88
PE
1377 Fix more problems found by GCC 4.6.0's static checks.
1378
f390e2d5
PE
1379 * xmenu.c (Fx_popup_dialog): Don't assume string is free of formats.
1380
42eea0d0
PE
1381 * menu.c (Fx_popup_menu): Don't assume error_name lacks printf formats.
1382
b69769da 1383 * lisp.h (message, message_nolog, fatal): Mark as printf-like.
1e973bc7 1384
f9541e84
PE
1385 * xdisp.c (vmessage): Mark as a printf-like function.
1386
13841b55
PE
1387 * term.c (vfatal, maybe_fatal): Mark as printf-like functions.
1388
c136c10f
PE
1389 * sound.c (sound_warning): Don't crash if arg contains a printf format.
1390
5e2d4a30
PE
1391 * image.c (tiff_error_handler, tiff_warning_handler): Mark as
1392 printf-like functions.
1393 (tiff_load): Add casts to remove these marks before passing them
1394 to system-supplied API.
1395
583f48b9
PE
1396 * eval.c (Fsignal): Remove excess argument to 'fatal'.
1397
b25d760e
PE
1398 * coding.c (EMIT_ONE_BYTE, EMIT_TWO_BYTES): Use unsigned, not int.
1399 This avoids several warnings with gcc -Wstrict-overflow.
d5efd1d1
PE
1400 (DECODE_COMPOSITION_RULE): If the rule is invalid, goto invalid_code
1401 directly, rather than having caller test rule sign. This avoids
1402 some unnecessary tests.
1403 * composite.h (COMPOSITION_ENCODE_RULE_VALID): New macro.
1404 (COMPOSITION_ENCODE_RULE): Arguments now must be valid. This
1405 affects only one use, in DECODE_COMPOSITION_RULE, which is changed.
b25d760e 1406
bc7b6697 1407 * xfont.c (xfont_text_extents): Remove var that was set but not used.
625a3eb1 1408 (xfont_open): Avoid unnecessary tests.
bc7b6697 1409
27ccc379
PE
1410 * composite.c (composition_gstring_put_cache): Use unsigned integer.
1411
dcd5c89a
PE
1412 * composite.h, composite.c (composition_gstring_put_cache):
1413 Use EMACS_INT, not int, for length.
1414
b13a45c6
PE
1415 * composite.h (COMPOSITION_DECODE_REFS): New macro,
1416 breaking out part of COMPOSITION_DECODE_RULE.
1417 (COMPOSITION_DECODE_RULE): Use it.
1418 * composite.c (get_composition_id): Remove unused local vars,
1419 by using the new macro.
1420
1e792e4d
PE
1421 * textprop.c (set_text_properties_1): Change while to do-while,
1422 since the condition is always true at first.
1423
dc6c6455 1424 * intervals.c (graft_intervals_into_buffer): Mark var as used.
aa86731f
PE
1425 (interval_deletion_adjustment): Return unsigned value.
1426 All uses changed.
dc6c6455 1427
aba7731a
PE
1428 * process.c (list_processes_1, create_pty, read_process_output):
1429 (exec_sentinel): Remove vars that were set but not used.
afd4052b 1430 (create_pty): Remove unnecessary "volatile"s.
bc57d757 1431 (Fnetwork_interface_info): Avoid possibility of int overflow.
82eaa333 1432 (read_process_output): Do adaptive read buffering even if carryover.
fe07cdfa 1433 (read_process_output): Simplify nbytes computation if buffered.
aba7731a 1434
fdfc4bf3
PE
1435 * bytecode.c (exec_byte_code): Rename local to avoid shadowing.
1436
fca8fe46 1437 * syntax.c (scan_words): Remove var that was set but not used.
12cbf13f 1438 (update_syntax_table): Use unsigned instead of int.
fca8fe46 1439
06a0259a 1440 * lread.c (lisp_file_lexically_bound_p): Use ints rather than endptrs.
3c346cc3 1441 (lisp_file_lexically_bound_p, read1): Use unsigned instead of int.
e6eb4e9e 1442 (safe_to_load_p): Make the end-of-loop test the inverse of the in-loop.
06a0259a 1443
e7b9e80f
PE
1444 * print.c (print_error_message): Avoid int overflow.
1445
56201685
PE
1446 * font.c (font_list_entities): Redo for clarity,
1447 so that reader need not know FONT_DPI_INDEX + 1 == FONT_SPACING_INDEX.
1448
78834453 1449 * font.c (font_find_for_lface, Ffont_get_glyphs): Remove unused vars.
790771b1 1450 (font_score): Avoid potential overflow in diff calculation.
78834453 1451
0bc0b309 1452 * fns.c (substring_both): Remove var that is set but not used.
8cd55cb4 1453 (sxhash): Redo loop for clarity and to avoid wraparound warning.
0bc0b309 1454
e610eaca
PE
1455 * eval.c (funcall_lambda): Rename local to avoid shadowing.
1456
b895abce
PE
1457 * alloc.c (mark_object_loop_halt, mark_object): Use size_t, not int.
1458 Otherwise, GCC 4.6.0 optimizes the loop check away since the check
1459 can always succeed if overflow has undefined behavior.
1460
1f1d9321 1461 * search.c (boyer_moore, wordify): Remove vars set but not used.
6f076cc7 1462 (wordify): Omit three unnecessary tests.
1f1d9321 1463
c59478bc
PE
1464 * indent.c (MULTIBYTE_BYTES_WIDTH): Don't compute wide_column.
1465 All callers changed. This avoids the need for an unused var.
1466
79b73827
PE
1467 * casefiddle.c (casify_region): Remove var that is set but not used.
1468
a4db5dfe
PE
1469 * dired.c (file_name_completion): Remove var that is set but not used.
1470
43aae36e
PE
1471 * fileio.c (Finsert_file_contents): Make EOF condition clearer.
1472
2a47c44d 1473 * fileio.c (Finsert_file_contents): Avoid signed integer overflow.
163c5f32 1474 (Finsert_file_contents): Remove unnecessary code checking fd.
2a47c44d 1475
a37c69bf
PE
1476 * minibuf.c (read_minibuf_noninteractive): Use size_t for sizes.
1477 Check for integer overflow on size calculations.
1478
328ab8e7
PE
1479 * buffer.c (Fprevious_overlay_change): Remove var that is set
1480 but not used.
1481
e5a2a5cb
PE
1482 * keyboard.c (menu_bar_items, read_char_minibuf_menu_prompt):
1483 Remove vars that are set but not used.
8d84a6eb 1484 (timer_check_2): Don't assume timer-list and idle-timer-list are lists.
6b043475 1485 (timer_check_2): Mark vars as initialized.
e5a2a5cb 1486
a60e5f68
PE
1487 * gtkutil.c (xg_get_file_with_chooser): Mark var as initialized.
1488
f661cb61 1489 * image.c (lookup_image): Remove var that is set but not used.
35fa624f 1490 (xbm_load): Use parse_p, for gcc -Werror=unused-but-set-variable.
f661cb61 1491
f0397f5a
PE
1492 * fontset.c (Finternal_char_font, Ffontset_info): Remove vars
1493 that are set but not used.
1494
8664db06 1495 * xfns.c (make_invisible_cursor): Don't return garbage
03733ee7 1496 if XCreateBitmapFromData fails (Bug#8410).
8664db06 1497
6abdaa4a
PE
1498 * xselect.c (x_get_local_selection, x_handle_property_notify):
1499 Remove vars that are set but not used.
1500
0ce7538d 1501 * xfns.c (x_create_tip_frame): Remove var that is set but not used.
6abdaa4a 1502 (make_invisible_cursor): Initialize a possibly-uninitialized variable.
0ce7538d 1503
9ae848fc
PE
1504 * xterm.c (x_scroll_bar_to_input_event) [!USE_GTK]:
1505 Remove var that is set but not used.
0b918413
PE
1506 (scroll_bar_windows_size): Now size_t, not int.
1507 (x_send_scroll_bar_event): Use size_t, not int, for sizes.
1508 Check for overflow.
9ae848fc 1509
a5a62657
PE
1510 * xfaces.c (realize_named_face): Remove vars that are set but not used.
1511 (map_tty_color) [!defined MSDOS]: Likewise.
1512
5c5cdd39
PE
1513 * term.c (tty_write_glyphs): Use size_t; this avoids overflow warning.
1514
66ebf983
PE
1515 * coding.c: Remove vars that are set but not used.
1516 (DECODE_COMPOSITION_RULE): Remove 2nd arg, which is unused.
1517 All callers changed.
1518 (decode_coding_utf_8, decode_coding_utf_16 decode_coding_emacs_mule):
1519 (decode_coding_iso_2022, encode_coding_sjis, encode_coding_big5):
1520 (decode_coding_charset): Remove vars that are set but not used.
1521
1be4d761
PE
1522 * bytecode.c (Fbyte_code) [!defined BYTE_CODE_SAFE]: Remove var
1523 that is set but not used.
1524
47553fa8
PE
1525 * print.c (print_object): Remove var that is set but not used.
1526
1f7196bf 1527 Replace 2 copies of readlink code with 1 gnulib version (Bug#8401).
d1fdcab7
PE
1528 The gnulib version avoids calling malloc in the usual case,
1529 and on 64-bit hosts doesn't have some arbitrary 32-bit limits.
1530 * fileio.c (Ffile_symlink_p): Use emacs_readlink.
1531 * filelock.c (current_lock_owner): Likewise.
1532 * lisp.h (READLINK_BUFSIZE, emacs_readlink): New function.
1533 * sysdep.c: Include allocator.h, careadlinkat.h.
1534 (emacs_no_realloc_allocator): New static constant.
1535 (emacs_readlink): New function.
fdb61804
PE
1536 * deps.mk (sysdep.o): Depend on ../lib/allocator.h and on
1537 ../lib/careadlinkat.h.
d1fdcab7 1538
f84c17c7
SM
15392011-04-04 Stefan Monnier <monnier@iro.umontreal.ca>
1540
1541 * keyboard.c (safe_run_hook_funcall): Fix last change (don't stop at the
1542 first non-nil return value).
1543
ef3862ad
JD
15442011-04-03 Jan Djärv <jan.h.d@swipnet.se>
1545
1546 * nsterm.m (ns_update_auto_hide_menu_bar): Define MAC_OS_X_VERSION_10_6
1547 if not defined (Bug#8403).
1548
376a7006
JB
15492011-04-02 Juanma Barranquero <lekktu@gmail.com>
1550
1551 * xdisp.c (display_count_lines): Remove parameter `start',
1552 unused since 1998-01-01T02:27:27Z!rms@gnu.org. All callers changed.
1553 (get_char_face_and_encoding): Remove parameter `multibyte_p',
1554 unused since 2008-05-14T01:40:23Z!handa@m17n.org. All callers changed.
1555 (fill_stretch_glyph_string): Remove parameters `row' and `area',
1556 unused at least since Kim's GUI unification at 2003-03-16T20:45:46Z!storm@cua.dk
1557 and thereabouts. All callers changed.
1558 (get_per_char_metric): Remove parameter `f', unused since
1559 2008-05-14T01:40:23Z!handa@m17n.org. All callers changed.
1560
6ca3801d
JM
15612011-04-02 Jim Meyering <meyering@redhat.com>
1562
1563 do not dereference NULL upon failed strdup
1564 * nsfont.m (ns_descriptor_to_entity): Use xstrdup, not strdup.
1565 (ns_get_family): Likewise.
1566
d8e2b5ba
JB
15672011-04-02 Juanma Barranquero <lekktu@gmail.com>
1568
1569 * eval.c (unwind_to_catch) [DEBUG_GCPRO]: Remove redundant assignment.
1570
8c74fcbd
JD
15712011-04-02 Jan Djärv <jan.h.d@swipnet.se>
1572
1573 * nsterm.m (ns_update_auto_hide_menu_bar): Only for OSX 10.6 or
1574 later (Bug#8403).
1575
7200d79c
SM
15762011-04-01 Stefan Monnier <monnier@iro.umontreal.ca>
1577
03408648 1578 Add lexical binding.
7200d79c 1579
03408648
SM
1580 * window.c (Ftemp_output_buffer_show): New fun.
1581 (Fsave_window_excursion):
1582 * print.c (Fwith_output_to_temp_buffer): Move to subr.el.
1583
1584 * lread.c (lisp_file_lexically_bound_p): New function.
1585 (Fload): Bind Qlexical_binding.
1586 (readevalloop): Remove `evalfun' arg.
1587 Bind Qinternal_interpreter_environment.
1588 (Feval_buffer): Bind Qlexical_binding.
1589 (defvar_int, defvar_bool, defvar_lisp_nopro, defvar_kboard):
1590 Mark as dynamic.
1591 (syms_of_lread): Declare `lexical-binding'.
1592
1593 * lisp.h (struct Lisp_Symbol): New field `declared_special'.
1594
1595 * keyboard.c (eval_dyn): New fun.
1596 (menu_item_eval_property): Use it.
ca105506
SM
1597
1598 * image.c (parse_image_spec): Use Ffunctionp.
ca105506 1599
03408648
SM
1600 * fns.c (concat, mapcar1): Accept byte-code-functions.
1601
1602 * eval.c (Fsetq): Handle lexical vars.
1603 (Fdefun, Fdefmacro, Ffunction): Make closures when needed.
1604 (Fdefconst, Fdefvaralias, Fdefvar): Mark as dynamic.
1605 (FletX, Flet): Obey lexical binding.
1606 (Fcommandp): Handle closures.
1607 (Feval): New `lexical' arg.
1608 (eval_sub): New function extracted from Feval. Use it almost
1609 everywhere where Feval was used. Look up vars in lexical env.
1610 Handle closures.
1611 (Ffunctionp): Move from subr.el.
1612 (Ffuncall): Handle closures.
1613 (apply_lambda): Remove `eval_flags'.
1614 (funcall_lambda): Handle closures and new byte-code-functions.
1615 (Fspecial_variable_p): New function.
1616 (syms_of_eval): Initialize the Vinternal_interpreter_environment var,
1617 but without exporting it to Lisp.
23aba0ea 1618
23aba0ea 1619 * doc.c (Fdocumentation, store_function_docstring):
03408648 1620 * data.c (Finteractive_form): Handle closures.
23aba0ea 1621
03408648
SM
1622 * callint.c (Fcall_interactively): Preserve lexical-binding mode for
1623 interactive spec.
ba83908c 1624
03408648
SM
1625 * bytecode.c (Bstack_ref, Bstack_set, Bstack_set2, BdiscardN): New
1626 byte-codes.
1627 (exec_byte_code): New function extracted from Fbyte_code to handle new
1628 calling convention for byte-code-functions. Add new byte-codes.
ba83908c 1629
03408648 1630 * buffer.c (defvar_per_buffer): Set new `declared_special' field.
e2abe5a1 1631
03408648 1632 * alloc.c (Fmake_symbol): Init new `declared_special' field.
e2abe5a1 1633
e2abce01
JB
16342011-03-31 Juanma Barranquero <lekktu@gmail.com>
1635
1636 * xdisp.c (redisplay_internal): Fix prototype.
1637
63696a73 16382011-03-31 Eli Zaretskii <eliz@gnu.org>
09725d26 1639
63696a73
EZ
1640 * xdisp.c (SCROLL_LIMIT): New macro.
1641 (try_scrolling): Use it when setting scroll_limit. Limit
1642 scrolling to 100 screen lines.
1643 (redisplay_window): Even when falling back on "recentering",
1644 position point in the window according to scroll-conservatively,
1645 scroll-margin, and scroll-*-aggressively variables. (Bug#6671)
1646
1647 (try_scrolling): When point is above the window, allow searching
1648 as far as scroll_max, or one screenful, to compute vertical
1649 distance from PT to the scroll margin position. This prevents
1650 try_scrolling from unnecessarily failing when
1651 scroll-conservatively is set to a value slightly larger than the
1652 window height. Clean up the case of PT below the margin at bottom
1653 of window: scroll_max can no longer be INT_MAX. When aggressive
1654 scrolling is in use, don't let point enter the opposite scroll
1655 margin as result of the scroll.
1656 (syms_of_xdisp) <scroll-conservatively>: Document the
09725d26
EZ
1657 threshold of 100 lines for never-recentering scrolling.
1658
e4cc2dfc
JB
16592011-03-31 Juanma Barranquero <lekktu@gmail.com>
1660
1661 * dispextern.h (move_it_by_lines):
1662 * xdisp.c (move_it_by_lines): Remove parameter `need_y_p', unused
1663 since 2000-12-29T14:24:09Z!gerd@gnu.org. All callers changed.
1664 (message_log_check_duplicate): Remove parameters `prev_bol' and
1665 `this_bol', unused since 1998-01-01T02:27:27Z!rms@gnu.org. All callers changed.
1666 (redisplay_internal): Remove parameter `preserve_echo_area',
1667 unused since 1999-07-21T21:43:52Z!gerd@gnu.org. All callers changed.
1668
1669 * indent.c (Fvertical_motion):
1670 * window.c (window_scroll_pixel_based, Frecenter):
1671 Don't pass `need_y_p' to `move_it_by_lines'.
1672
1c470562
SM
16732011-03-30 Stefan Monnier <monnier@iro.umontreal.ca>
1674
44f230aa
SM
1675 * eval.c (struct backtrace): Don't cheat with negative numbers, but do
1676 steal a few bits to be more compact.
1677 (interactive_p, Fbacktrace, Fbacktrace_frame, mark_backtrace):
1678 Remove unneeded casts.
1679
1c470562
SM
1680 * bytecode.c (Fbyte_code): CAR and CDR can GC.
1681
888adce9
ZK
16822011-03-30 Zachary Kanfer <zkanfer@gmail.com> (tiny change)
1683
1684 * keyboard.c (Fexecute_extended_command): Do log the "suggest key
1685 binding" message (bug#7967).
1686
f838ed7b
PE
16872011-03-30 Paul Eggert <eggert@cs.ucla.edu>
1688
77861b95
PE
1689 Fix more problems found by GCC 4.6.0's static checks.
1690
de6dbc14
PE
1691 * unexelf.c (unexec) [! (defined _SYSTYPE_SYSV || defined __sgi)]:
1692 Remove unused local var.
1693
f838ed7b
PE
1694 * editfns.c (Fmessage_box): Remove unused local var.
1695
792c7b2b
PE
1696 * xdisp.c (try_window_reusing_current_matrix, x_produce_glyphs):
1697 (note_mode_line_or_margin_highlight, note_mouse_highlight):
1698 Omit unused local vars.
c499e557 1699 * window.c (shrink_windows): Omit unused local var.
b01a1c29 1700 * menu.c (digest_single_submenu): Omit unused local var.
0bc32927
PE
1701 * dispnew.c (update_window) [PERIODIC_PREEMPTION_CHECKING]:
1702 Omit unused local var.
1703
ba0165e1
PE
1704 * keyboard.c (parse_modifiers_uncached, parse_modifiers):
1705 Don't assume string length fits in int.
32ad8845 1706 (keyremap_step, read_key_sequence): Use size_t for sizes.
48011560 1707 (read_key_sequence): Don't check last_real_key_start redundantly.
ba0165e1 1708
3c59b4c9
PE
1709 * callproc.c (Fcall_process, Fcall_process_region): Use SAFE_ALLOCA
1710 instead of alloca (Bug#8344).
1711
a3eed478 1712 * eval.c (Fbacktrace): Don't assume nargs fits in int.
5d5d959d 1713 (Fbacktrace_frame): Don't assume nframes fits in int.
a3eed478 1714
eb4d412d
PE
1715 * syntax.c (scan_sexps_forward): Avoid pointer wraparound.
1716
1658b401
PE
1717 * xterm.c (x_make_frame_visible, same_x_server): Redo to avoid overflow
1718 concerns.
1719
1720 * term.c (produce_glyphless_glyph): Remove unnecessary test.
1721
1722 * cm.c (calccost): Turn while-do into do-while, for clarity.
44f730c8 1723
9a2c6e05
PE
1724 * keyboard.c (syms_of_keyboard): Use the same style as later
1725 in this function when indexing through an array. This also
1726 works around GCC bug 48267.
1727
03d0a109
PE
1728 * image.c (tiff_load): Fix off-by-one image count (Bug#8336).
1729
44f730c8
PE
1730 * xselect.c (x_check_property_data): Return correct size (Bug#8335).
1731
fe75f926
PE
1732 * chartab.c (sub_char_table_ref_and_range): Redo for slight
1733 efficiency gain, and to bypass a gcc -Wstrict-overflow warning.
1734
ffa8c828
PE
1735 * keyboard.c, keyboard.h (num_input_events): Now size_t.
1736 This avoids undefined behavior on integer overflow, and is a bit
1737 more convenient anyway since it is compared to a size_t variable.
1738
c5101a77
PE
1739 Variadic C functions now count arguments with size_t, not int.
1740 This avoids an unnecessary limitation on 64-bit machines, which
1741 caused (substring ...) to crash on large vectors (Bug#8344).
1742 * lisp.h (struct Lisp_Subr.function.aMANY): Now takes size_t, not int.
1743 (DEFUN_ARGS_MANY, internal_condition_case_n, safe_call): Likewise.
77861b95 1744 All variadic functions and their callers changed accordingly.
c5101a77
PE
1745 (struct gcpro.nvars): Now size_t, not int. All uses changed.
1746 * data.c (arith_driver, float_arith_driver): Likewise.
1747 * editfns.c (general_insert_function): Likewise.
1748 * eval.c (struct backtrace.nargs, interactive_p)
1749 (internal_condition_case_n, run_hook_with_args, apply_lambda)
1750 (funcall_lambda, mark_backtrace): Likewise.
1751 * fns.c (concat): Likewise.
1752 * frame.c (x_set_frame_parameters): Likewise.
1753 * fns.c (get_key_arg): Now accepts and returns size_t, and returns
1754 0 if not found, not -1. All callers changed.
1755
dd3f25f7
PE
1756 * alloc.c (garbage_collect): Don't assume stack size fits in int.
1757 (stack_copy_size): Now size_t, not int.
1758 (stack_copy, stack_copy_size): Define only if MAX_SAVE_STACK > 0.
1759
461c2ab9
JB
17602011-03-28 Juanma Barranquero <lekktu@gmail.com>
1761
1762 * coding.c (encode_designation_at_bol): Remove parameter `charbuf_end',
1763 unused since 2002-03-01T01:17:24Z!handa@m17n.org and 2008-02-01T16:01:31Z!miles@gnu.org.
1764 All callers changed.
1765
1766 * lisp.h (multibyte_char_to_unibyte):
1767 * character.c (multibyte_char_to_unibyte): Remove parameter `rev_tbl',
1768 unused since 2002-03-01T01:16:34Z!handa@m17n.org and 2008-02-01T16:01:31Z!miles@gnu.org.
1769 * character.h (CHAR_TO_BYTE8):
1770 * cmds.c (internal_self_insert):
1771 * editfns.c (general_insert_function):
1772 * keymap.c (push_key_description):
1773 * search.c (Freplace_match):
1774 * xdisp.c (message_dolog, set_message_1): All callers changed.
1775
f6d62986
SM
17762011-03-28 Stefan Monnier <monnier@iro.umontreal.ca>
1777
1778 * keyboard.c (safe_run_hook_funcall): New function.
1779 (safe_run_hooks_1, safe_run_hooks_error, safe_run_hooks): On error,
1780 don't set the hook to nil, but remove the offending function instead.
1781 (Qcommand_hook_internal): Remove, unused.
1782 (syms_of_keyboard): Don't initialize Qcommand_hook_internal nor define
1783 Vcommand_hook_internal.
1784
1785 * eval.c (enum run_hooks_condition): Remove.
1786 (funcall_nil, funcall_not): New functions.
1787 (run_hook_with_args): Call each function through a `funcall' argument.
1788 Remove `cond' argument, now redundant.
1789 (Frun_hooks, Frun_hook_with_args, Frun_hook_with_args_until_success)
1790 (Frun_hook_with_args_until_failure): Adjust accordingly.
1791 (run_hook_wrapped_funcall, Frun_hook_wrapped): New functions.
1792
1db5b1ad
JB
17932011-03-28 Juanma Barranquero <lekktu@gmail.com>
1794
1795 * dispextern.h (string_buffer_position): Remove declaration.
1796
1797 * print.c (strout): Remove parameter `multibyte', unused since
1798 1999-08-21T19:30:21Z!gerd@gnu.org. All callers changed.
1799
1800 * search.c (boyer_moore): Remove parameters `len', `pos' and `lim',
1801 never used since function introduction in 1998-02-08T21:33:56Z!rms@gnu.org.
1802 All callers changed.
1803
1804 * w32.c (_wsa_errlist): Use braces for struct initializers.
1805
1806 * xdisp.c (string_buffer_position_lim): Remove parameter `w',
1807 never used since function introduction in 2001-03-09T18:41:50Z!gerd@gnu.org.
1808 All callers changed.
1809 (string_buffer_position): Likewise. Also, make static (it's never
1810 used outside xdisp.c).
1811 (cursor_row_p): Remove parameter `w', unused since
1812 2000-10-17T16:08:57Z!gerd@gnu.org. All callers changed.
1813 (decode_mode_spec): Remove parameter `precision', introduced during
1814 Gerd Moellmann's rewrite at 1999-07-21T21:43:52Z!gerd@gnu.org, but never used.
1815 All callers changed.
1816
5ffb62aa
JD
18172011-03-27 Jan Djärv <jan.h.d@swipnet.se>
1818
1819 * nsterm.m (syms_of_nsterm): Use doc: for ns-auto-hide-menu-bar.
1820
461c2ab9 18212011-03-27 Anders Lindgren <andlind@gmail.com>
f0a1382a
JD
1822
1823 * nsterm.m (ns_menu_bar_is_hidden): New variable.
1824 (ns_constrain_all_frames, ns_menu_bar_should_be_hidden)
1825 (ns_update_auto_hide_menu_bar): New functions.
1826 (ns_update_begin): Call ns_update_auto_hide_menu_bar.
1827 (applicationDidBecomeActive): Call ns_update_auto_hide_menu_bar and
1828 ns_constrain_all_frames.
1829 (constrainFrameRect): Return at once if ns_menu_bar_should_be_hidden.
1830 (syms_of_nsterm): DEFVAR ns-auto-hide-menu-bar, init to Qnil.
1831
5c380ffb
JD
18322011-03-27 Jan Djärv <jan.h.d@swipnet.se>
1833
1834 * nsmenu.m (runDialogAt): Remove argument to timer_check.
1835
9af30bdf
GM
18362011-03-27 Glenn Morris <rgm@gnu.org>
1837
1838 * syssignal.h: Replace RETSIGTYPE with void.
1839 * atimer.c, data.c, dispnew.c, emacs.c, floatfns.c, keyboard.c:
1840 * keyboard.h, lisp.h, process.c, sysdep.c, xterm.c:
1841 Replace SIGTYPE with void everywhere.
1842 * s/usg5-4-common.h (SIGTYPE): Remove definition.
1843 * s/template.h (SIGTYPE): Remove commented out definition.
1844
e2abce01
JB
18452011-03-26 Eli Zaretskii <eliz@gnu.org>
1846
1847 * xdisp.c (redisplay_window): Don't check buffer's clip_changed
1848 flag as a prerequisite for invoking try_scrolling. (Bug#6671)
1849
f868cd8a
JB
18502011-03-26 Juanma Barranquero <lekktu@gmail.com>
1851
59eb0929
JB
1852 * w32.c (read_unc_volume): Use parameter `henum', instead of
1853 global variable `wget_enum_handle'.
1854
1855 * keymap.c (describe_vector): Remove parameters `indices' and
1856 `char_table_depth', unused since 2002-03-01T01:43:26Z!handa@m17n.org.
1857 (describe_map, Fdescribe_vector): Adjust calls to `describe_vector'.
1858
f868cd8a
JB
1859 * keyboard.h (timer_check, show_help_echo): Remove unused parameters.
1860
1861 * keyboard.c (timer_check): Remove parameter `do_it_now',
1862 unused since 1996-04-12T06:01:29Z!rms@gnu.org.
1863 (show_help_echo): Remove parameter `ok_to_overwrite_keystroke_echo',
1864 unused since 2008-04-19T19:30:53Z!monnier@iro.umontreal.ca.
1865
1866 * keyboard.c (read_char):
1867 * w32menu.c (w32_menu_display_help):
1868 * xmenu.c (show_help_event, menu_help_callback):
1869 Adjust calls to `show_help_echo'.
1870
1871 * gtkutil.c (xg_maybe_add_timer):
1872 * keyboard.c (readable_events):
1873 * process.c (wait_reading_process_output):
1874 * xmenu.c (x_menu_wait_for_event): Adjust calls to `timer_check'.
1875
1876 * insdel.c (adjust_markers_gap_motion):
1877 Remove; no-op since 1998-01-02T21:29:48Z!rms@gnu.org.
1878 (gap_left, gap_right): Don't call it.
1879
2ecf6fdb
CY
18802011-03-25 Chong Yidong <cyd@stupidchicken.com>
1881
1882 * xdisp.c (handle_fontified_prop): Discard changes to clip_changed
1883 incurred during fontification.
1884
6b1f9ba4
JB
18852011-03-25 Juanma Barranquero <lekktu@gmail.com>
1886
1887 * buffer.c (defvar_per_buffer): Remove unused parameter `doc'.
1888 (DEFVAR_PER_BUFFER): Don't pass it.
1889
1890 * dispnew.c (row_equal_p, add_row_entry): Remove unused parameter `w'.
1891 (scrolling_window): Don't pass it.
1892
0f4a96b5
JB
18932011-03-25 Juanma Barranquero <lekktu@gmail.com>
1894
1895 * dispextern.h (glyph_matric): Use #if GLYPH_DEBUG, not #ifdef.
1896
1897 * fileio.c (check_executable) [DOS_NT]: Remove unused variables `len'
1898 and `suffix'.
1899 (Fset_file_selinux_context) [HAVE_LIBSELINUX]: Move here declaration
1900 of variables specific to SELinux and computation of `encoded_absname'.
1901
1902 * image.c (XPutPixel): Remove unused variable `height'.
1903
1904 * keyboard.c (make_lispy_event): Remove unused variable `hpos'.
1905
1906 * unexw32.c (get_section_info): Remove unused variable `section'.
1907
1908 * w32.c (stat): Remove unused variables `drive_root' and `devtype'.
1909 (system_process_attributes): Remove unused variable `sess'.
1910 (sys_read): Remove unused variable `err'.
1911
1912 * w32fns.c (top): Wrap variables with #if GLYPH_DEBUG, not #ifdef.
1913 (w32_wnd_proc): Remove unused variable `isdead'.
1914 (unwind_create_frame): Use #if GLYPH_DEBUG, not #ifdef.
1915 (Fx_server_max_request_size): Remove unused variable `dpyinfo'.
1916 (x_create_tip_frame): Remove unused variable `tem'.
1917
1918 * w32inevt.c (w32_console_read_socket):
1919 Remove unused variable `no_events'.
1920
1921 * w32term.c (x_draw_composite_glyph_string_foreground):
1922 Remove unused variable `width'.
1923
1149507c
JB
19242011-03-24 Juanma Barranquero <lekktu@gmail.com>
1925
1926 * w32term.c (x_set_glyph_string_clipping):
1927 Don't pass uninitialized region to CombineRgn.
1928
9c88f339
JB
19292011-03-23 Juanma Barranquero <lekktu@gmail.com>
1930
1931 * w32fns.c (x_set_menu_bar_lines): Remove unused variable `olines'.
1932 (w32_wnd_proc): Pass NULL to Windows API, not uninitialized buffer.
1933 (Fx_close_connection): Remove unused variable `i'.
1934
1935 * w32font.c (w32font_draw): Return number of glyphs.
1936 (w32font_open_internal): Remove unused variable `i'.
1937 (w32font_driver): Add missing initializer.
1938
1939 * w32menu.c (utf8to16): Remove unused variable `utf16'.
1940 (fill_in_menu): Remove unused variable `items_added'.
1941
1942 * w32term.c (last_mouse_press_frame): Remove static global variable.
1943 (w32_clip_to_row): Remove unused variable `f'.
1944 (x_delete_terminal): Remove unused variable `i'.
1945
1946 * w32uniscribe.c (uniscribe_shape): Remove unused variable `nclusters'.
1947 (NOTHING): Remove unused static global variable.
1948 (uniscribe_check_otf): Remove unused variable `table'.
1949 (uniscribe_font_driver): Add missing initializers.
1950
dee091a3
JD
19512011-03-23 Julien Danjou <julien@danjou.info>
1952
1953 * term.c (Fsuspend_tty, Fresume_tty):
1954 * minibuf.c (read_minibuf, run_exit_minibuf_hook):
1955 * window.c (temp_output_buffer_show):
1956 * insdel.c (signal_before_change):
1957 * frame.c (Fhandle_switch_frame):
1958 * fileio.c (Fdo_auto_save):
1959 * emacs.c (Fkill_emacs):
1960 * editfns.c (save_excursion_restore):
1961 * cmds.c (internal_self_insert):
1962 * callint.c (Fcall_interactively):
1963 * buffer.c (Fkill_all_local_variables):
1964 * keyboard.c (Fcommand_execute, Fsuspend_emacs, safe_run_hooks_1):
1965 Use Frun_hooks.
0f4a96b5 1966 (command_loop_1): Use Frun_hooks. Call safe_run_hooks
dee091a3
JD
1967 unconditionnaly since it does the check itself.
1968
2c520ab5 19692011-03-23 Paul Eggert <eggert@cs.ucla.edu>
f0641eff 1970
c9c49752
PE
1971 Fix more problems found by GCC 4.5.2's static checks.
1972
8abc3f12
PE
1973 * coding.c (encode_coding_raw_text): Avoid unnecessary test
1974 the first time through the loop, since we know p0 < p1 then.
1975 This also avoids a gcc -Wstrict-overflow warning.
1976
a2d26660
PE
1977 * lisp.h (SAFE_ALLOCA, SAFE_ALLOCA_LISP): Avoid 'int' overflow
1978 leading to a memory leak, possible in functions like
1979 load_charset_map_from_file that can allocate an unbounded number
b12ef411 1980 of objects (Bug#8318).
a2d26660 1981
916c72e9
PE
1982 * xmenu.c (set_frame_menubar): Use EMACS_UINT, not int, for indexes
1983 that could (at least in theory) be that large.
1984
19ab8a18
PE
1985 * xdisp.c (message_log_check_duplicate): Return unsigned long, not int.
1986 This is less likely to overflow, and avoids undefined behavior if
1987 overflow does occur. All callers changed. Use strtoul to scan
1988 for the unsigned long integer.
b7cbbd6f
PE
1989 (pint2hrstr): Simplify and tune code slightly.
1990 This also avoids a (bogus) GCC warning with gcc -Wstrict-overflow.
19ab8a18 1991
f0641eff
PE
1992 * scroll.c (do_scrolling): Work around GCC bug 48228.
1993 See <http://gcc.gnu.org/bugzilla/show_bug.cgi?id=48228>.
1994
7f650bb9
PE
1995 * frame.c (Fmodify_frame_parameters): Simplify loop counter.
1996 This also avoids a warning with gcc -Wstrict-overflow.
39f5e519
PE
1997 (validate_x_resource_name): Simplify count usage.
1998 This also avoids a warning with gcc -Wstrict-overflow.
7f650bb9 1999
37dd57d1
PE
2000 * fileio.c (Fcopy_file): Report error if fchown or fchmod
2001 fail (Bug#8306).
81e56e61 2002
699979fc 2003 * emacs.c (Fdaemon_initialized): Do not ignore I/O errors (Bug#8303).
dc1ca6a8 2004
401bf9b4
PE
2005 * process.c (Fmake_network_process): Use socklen_t, not int,
2006 where POSIX says socklen_t is required in portable programs.
2007 This fixes a porting bug on hosts like 64-bit HP-UX, where
591b2973 2008 socklen_t is wider than int (Bug#8277).
401bf9b4
PE
2009 (Fmake_network_process, server_accept_connection):
2010 (wait_reading_process_output, read_process_output):
2011 Likewise.
2012
b93aacde
PE
2013 * process.c: Rename or move locals to avoid shadowing.
2014 (list_processes_1, Fmake_network_process):
2015 (read_process_output_error_handler, exec_sentinel_error_handler):
2016 Rename or move locals.
4dc343ee 2017 (Fmake_network_process): Define label "retry_connect" only if needed.
0da49335 2018 (Fnetwork_interface_info): Fix pointer signedness.
f990b4e5 2019 (process_send_signal): Add cast to avoid pointer signedness problem.
7b808126 2020 (FIRST_PROC_DESC, IF_NON_BLOCKING_CONNECT): Remove unused macros.
c939f91b 2021 (create_process): Use 'volatile' to avoid vfork clobbering (Bug#8298).
b93aacde 2022
af8a867c 2023 Make tparam.h and terminfo.c consistent.
44f230aa
SM
2024 * cm.c (tputs, tgoto, BC, UP): Remove extern decls.
2025 Include tparam.h instead, since it declares them.
af8a867c
PE
2026 * cm.h (PC): Remove extern decl; tparam.h now does this.
2027 * deps.mk (cm.o, terminfo.o): Depend on tparam.h.
2028 * terminfo.c: Include tparam.h, to check interfaces.
2029 (tparm): Make 1st arg a const pointer in decl. Put it at top level.
2030 (tparam): Adjust signature to match interface in tparam.h;
2031 this removes some undefined behavior. Check that outstring and len
2032 are zero, which they always are with Emacs.
2033 * tparam.h (PC, BC, UP): New extern decls.
2034
0248044d 2035 * xftfont.c (xftfont_shape): Now static, and defined only if needed.
001a7ab4 2036 (xftfont_open): Rename locals to avoid shadowing.
0248044d 2037
8ff096c1 2038 * ftfont.c (ftfont_resolve_generic_family): Fix pointer signedness.
a00924bb
PE
2039 (ftfont_otf_capability, ftfont_shape): Omit decls if not needed.
2040 (OTF_TAG_SYM): Omit macro if not needed.
e932860f 2041 (ftfont_list): Remove unused local.
49eaafba
PE
2042 (get_adstyle_property, ftfont_pattern_entity):
2043 (ftfont_lookup_cache, ftfont_open, ftfont_anchor_point):
2044 Rename locals to avoid shadowing.
8ff096c1 2045
e2be39f6
PE
2046 * xfont.c (xfont_list_family): Mark var as initialized.
2047
c9735e30
PE
2048 * xml.c (make_dom): Now static.
2049
8f5201ae
PE
2050 * composite.c (composition_compute_stop_pos): Rename local to
2051 avoid shadowing.
b246f932
PE
2052 (composition_reseat_it): Remove unused locals.
2053 (find_automatic_composition, composition_adjust_point): Likewise.
80e079b2 2054 (composition_update_it): Mark var as initialized.
11b61122
PE
2055 (find_automatic_composition): Mark vars as initialized,
2056 with a FIXME (Bug#8290).
8f5201ae 2057
760fbc2c
PE
2058 character.h: Rename locals to avoid shadowing.
2059 * character.h (PREV_CHAR_BOUNDARY, FETCH_STRING_CHAR_ADVANCE):
2060 (FETCH_STRING_CHAR_AS_MULTIBYTE_ADVANCE, FETCH_CHAR_ADVANCE):
2061 (FETCH_CHAR_ADVANCE_NO_CHECK, INC_POS, DEC_POS, BUF_INC_POS):
2062 (BUF_DEC_POS): Be more systematic about renaming local temporaries
2063 to avoid shadowing.
2064
ff08eb85
PE
2065 * textprop.c (property_change_between_p): Remove; unused.
2066
fc7bf025
PE
2067 * intervals.c (interval_start_pos): Now static.
2068
235d7abc
PE
2069 * intervals.h (CHECK_TOTAL_LENGTH): Avoid empty "else".
2070
44f230aa
SM
2071 * atimer.c (start_atimer, append_atimer_lists, set_alarm):
2072 Rename locals to avoid shadowing.
3e7d6594 2073
50060332
PE
2074 * sound.c (wav_play, au_play, Fplay_sound_internal):
2075 Fix pointer signedness.
d01f234b 2076 (alsa_choose_format): Remove unused local var.
c83b8872
PE
2077 (wav_play): Initialize a variable to 0, to prevent undefined
2078 behavior (Bug#8278).
50060332 2079
c4fc4e30
PE
2080 * region-cache.c (insert_cache_boundary): Redo var to avoid shadowing.
2081
918436ed
PE
2082 * region-cache.h (pp_cache): New decl, for gcc -Wmissing-prototypes.
2083
c939f91b
PE
2084 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork
2085 clobbering (Bug#8298).
b9c7f648
PE
2086 * sysdep.c (sys_subshell): Likewise.
2087 Previously, the sys_subshell 'volatile' was incorrectly IF_LINTted out.
7e9123a2 2088
6bd8c144
PE
2089 * lisp.h (child_setup): Now NO_RETURN unless DOS_NT.
2090 This should get cleaned up, so that child_setup has the
2091 same signature on all platforms.
2092
7710357c 2093 * callproc.c (call_process_cleanup): Now static.
cb1d0ef7 2094 (relocate_fd): Rename locals to avoid shadowing.
7710357c 2095
c59da222
CY
20962011-03-22 Chong Yidong <cyd@stupidchicken.com>
2097
2098 * xterm.c (x_clear_frame): Remove XClearWindow call. This appears
2099 not to be necessary, and produces flickering.
2100
66b87493
GM
21012011-03-20 Glenn Morris <rgm@gnu.org>
2102
2103 * config.in: Remove file.
2104
45b6f6d5
JB
21052011-03-20 Juanma Barranquero <lekktu@gmail.com>
2106
2107 * minibuf.c (Vcompleting_read_function): Don't declare, global variables
2108 are now in src/globals.h.
2109 (syms_of_minibuf): Remove spurious & from previous change.
2110
3ec03f7e
LL
21112011-03-20 Leo <sdl.web@gmail.com>
2112
2113 * minibuf.c (completing-read-function): New variable.
2114 (completing-read-default): Rename from completing-read.
2115 (completing-read): Call completing-read-function.
2116
b14e3e21
CY
21172011-03-19 Juanma Barranquero <lekktu@gmail.com>
2118
2119 * xfaces.c (Fx_load_color_file):
2120 Read color file from absolute filename (bug#8250).
2121
f2b726e6
JB
21222011-03-19 Juanma Barranquero <lekktu@gmail.com>
2123
2124 * makefile.w32-in: Update dependencies.
2125
09f6ff02
EZ
21262011-03-17 Eli Zaretskii <eliz@gnu.org>
2127
2128 * makefile.w32-in ($(BLD)/unexw32.$(O)): Depend on $(SRC)/unexec.h.
2129
29a6015a
PE
21302011-03-17 Paul Eggert <eggert@cs.ucla.edu>
2131
a3a6c54e
PE
2132 Fix more problems found by GCC 4.5.2's static checks.
2133
b766f867
PE
2134 * process.c (make_serial_process_unwind, send_process_trap):
2135 (sigchld_handler): Now static.
2136
be02381c
PE
2137 * process.c (allocate_pty): Let PTY_ITERATION declare iteration vars.
2138 That way, the code declares only the vars that it needs.
2139 * s/aix4-2.h (PTY_ITERATION): Declare iteration vars.
2140 * s/cygwin.h (PTY_ITERATION): Likewise.
2141 * s/darwin.h (PTY_ITERATION): Likewise.
2142 * s/gnu-linux.h (PTY_ITERATION): Likewise.
2143
57048744
PE
2144 * s/irix6-5.h (PTY_OPEN): Declare stb, to loosen coupling.
2145 * process.c (allocate_pty): Don't declare stb unless it's needed.
2146
7914961c 2147 * bytecode.c (MAYBE_GC): Rewrite so as not to use empty "else".
615f2d59
PE
2148 (CONSTANTLIM): Remove; unused.
2149 (METER_CODE, Bscan_buffer, Bread_char, Bset_mark):
2150 Define only if needed.
7914961c 2151
b3967b18
PE
2152 * unexelf.c (unexec): Name an expression,
2153 to avoid gcc -Wbad-function-cast warning.
9ae71512
PE
2154 Use a different way to cause a compilation error if anyone uses
2155 n rather than nn, a way that does not involve shadowing.
73366a00 2156 (ELF_BSS_SECTION_NAME, OLD_PROGRAM_H): Remove; unused.
b3967b18 2157
29a6015a
PE
2158 * deps.mk (unexalpha.o): Remove; unused.
2159
43cfc33e 2160 New file unexec.h, the (simple) interface for unexec (Bug#8267).
7feda0d2 2161 * unexec.h: New file.
ce701a33
PE
2162 * deps.mk (emacs.o, unexaix.o, unexcw.o, unexcoff.o, unexelf.o):
2163 (unexhp9k800.o, unexmacosx.o, unexsol.o, unexw32.o):
2164 Depend on unexec.h.
2165 * emacs.c [!defined CANNOT_DUMP]: Include unexec.h.
2166 * unexaix.c, unexcoff.c, unexcw.c, unexelf.c, unexhp9k800.c:
2167 * unexmacosx.c, unexsol.c, unexw32.c: Include unexec.h.
381259ef 2168 Change as necessary to match prototype in unexec.h.
ce701a33 2169
01f44d5a
PE
2170 * syntax.c (Fforward_comment, scan_lists): Rename locals to avoid
2171 shadowing.
4f63c6bb 2172 (back_comment, skip_chars): Mark vars as initialized.
01f44d5a 2173
a6670b0b
PE
2174 * character.h (FETCH_STRING_CHAR_ADVANCE_NO_CHECK, BUF_INC_POS):
2175 Rename locals to avoid shadowing.
2176
cef2010d 2177 * lread.c (read1): Rewrite so as not to use empty "else".
0902fe45 2178 (Fload, readevalloop, read1): Rename locals to avoid shadowing.
cef2010d 2179
d4d7173a
PE
2180 * print.c (Fredirect_debugging_output): Fix pointer signedess.
2181
f08b802a
PE
2182 * lisp.h (debug_output_compilation_hack): Add decl here, to avoid
2183 warning when compiling print.c.
2184
3ddb0639
PE
2185 * font.c (font_unparse_fcname): Abort in an "impossible" situation
2186 instead of using an uninitialized var.
5ad03b97 2187 (font_sort_entities): Mark var as initialized.
3ddb0639 2188
170a2692
PE
2189 * character.h (FETCH_CHAR_ADVANCE): Rename locals to avoid shadowing.
2190
e663c700
PE
2191 * font.c (font_unparse_xlfd): Don't mix pointers to variables with
2192 pointers to constants.
89bc529a 2193 (font_parse_fcname): Remove unused vars.
7b81e2d0 2194 (font_delete_unmatched): Now static.
ea838e10 2195 (font_get_spec): Remove; unused.
13a547c6
PE
2196 (font_style_to_value, font_prop_validate_style, font_unparse_fcname):
2197 (font_update_drivers, Ffont_get_glyphs, font_add_log):
2198 Rename or move locals to avoid shadowing.
e663c700 2199
2a80c887 2200 * fns.c (require_nesting_list, require_unwind): Now static.
612f56df 2201 (Ffillarray): Rename locals to avoid shadowing.
2a80c887 2202
1384fa33 2203 * floatfns.c (domain_error2): Define only if needed.
a885e2ed 2204 (Ffrexp, Fldexp): Rename locals to avoid shadowing.
1384fa33 2205
8b2c52e9
PE
2206 * alloc.c (mark_backtrace): Move decl from here ...
2207 * lisp.h: ... to here, so that it can be checked.
2208
475545b5 2209 * eval.c (call_debugger, do_debug_on_call, grow_specpdl): Now static.
d28a2170 2210 (Fdefvar): Rewrite so as not to use empty "else".
cfcbfb1a
PE
2211 (lisp_indirect_variable): Name an expression,
2212 to avoid gcc -Wbad-function-cast warning.
1faed8ae 2213 (Fdefvar): Rename locals to avoid shadowing.
475545b5 2214
b1349114 2215 * callint.c (quotify_arg, quotify_args): Now static.
a3e8cbda 2216 (Fcall_interactively): Rename locals to avoid shadowing.
b0e80955 2217 Use const pointer when appropriate.
b1349114 2218
a2928364
PE
2219 * lisp.h (get_system_name, get_operating_system_release):
2220 Move decls here, to check interfaces.
2221 * process.c (get_operating_system_release): Move decl to lisp.h.
2222 * xrdb.c (get_system_name): Likewise.
63c5d10b
PE
2223 * editfns.c (init_editfns, Fuser_login_name, Fuser_uid):
2224 (Fuser_real_uid, Fuser_full_name): Remove unnecessary casts,
2225 some of which prompt warnings from gcc -Wbad-function-cast.
545b49b4
PE
2226 (Fformat_time_string, Fencode_time, Finsert_char):
2227 (Ftranslate_region_internal, Fformat):
2228 Rename or remove local vars to avoid shadowing.
9710023e 2229 (Ftranslate_region_internal): Mark var as initialized.
63c5d10b 2230
a415e694
PE
2231 * doc.c (Fdocumentation, Fsnarf_documentation): Move locals to
2232 avoid shadowing.
2233
8ef4622d
PE
2234 * lisp.h (eassert): Check that the argument compiles, even if
2235 ENABLE_CHECKING is not defined.
2236
946f9a5b
PE
2237 * data.c (Findirect_variable): Name an expression, to avoid
2238 gcc -Wbad-function-cast warning.
112396d6 2239 (default_value, arithcompare, arith_driver, arith_error): Now static.
b9b84fa9 2240 (store_symval_forwarding): Rename local to avoid shadowing.
44f230aa
SM
2241 (Fmake_variable_buffer_local, Fmake_local_variable):
2242 Mark variables as initialized.
52746918 2243 (do_blv_forwarding, do_symval_forwarding): Remove; unused.
946f9a5b 2244
e5aab7e7 2245 * alloc.c (check_cons_list): Do not define unless GC_CHECK_CONS_LIST.
ae35e756
PE
2246 (Fmake_vector, Fvector, Fmake_byte_code, Fgarbage_collect):
2247 Rename locals to avoid shadowing.
dff45157
PE
2248 (mark_stack): Move local variables into the #ifdef region where
2249 they're used.
7bc26fdb
PE
2250 (BLOCK_INPUT_ALLOC, UNBLOCK_INPUT_ALLOC): Define only if
2251 ! defined SYSTEM_MALLOC && ! defined SYNC_INPUT, as they are not
2252 needed otherwise.
2253 (CHECK_ALLOCATED): Define only if GC_CHECK_MARKED_OBJECTS.
2254 (GC_STRING_CHARS): Remove; not used.
d40d4be1 2255 (Fmemory_limit): Cast sbrk's returned value to char *.
ae35e756 2256
e5aab7e7
PE
2257 * lisp.h (check_cons_list): Declare if GC_CHECK_CONS_LIST; this
2258 avoids undefined behavior in theory.
2259
4da60324
PE
2260 * regex.c (IF_LINT): Add defn, for benefit of ../lib-src.
2261
88043301
PE
2262 Use functions, not macros, for up- and down-casing (Bug#8254).
2263 * buffer.h (DOWNCASE_TABLE, UPCASE_TABLE, DOWNCASE, UPPERCASEP):
2264 (NOCASEP, LOWERCASEP, UPCASE, UPCASE1): Remove. All callers changed
2265 to use the following functions instead of these macros.
2266 (downcase): Adjust to lack of DOWNCASE_TABLE. Return int, not
2267 EMACS_INT, since callers assume the returned value fits in int.
2268 (upcase1): Likewise, for UPCASE_TABLE.
2269 (uppercasep, lowercasep, upcase): New static inline functions.
0da09c43 2270 * editfns.c (Fchar_equal): Remove no-longer-needed workaround for
db69b0cd 2271 the race-condition problem in the old DOWNCASE.
88043301 2272
19ed5445
PE
2273 * regex.c (CHARSET_LOOKUP_RANGE_TABLE_RAW, POP_FAILURE_REG_OR_COUNT):
2274 Rename locals to avoid shadowing.
2275 (regex_compile, re_match_2_internal): Move locals to avoid shadowing.
abbd1bcf
PE
2276 (regex_compile, re_search_2, re_match_2_internal):
2277 Remove unused local vars.
952db0d7
PE
2278 (FREE_VAR): Rewrite so as not to use empty "else",
2279 which gcc can warn about.
da053e48 2280 (regex_compile, re_match_2_internal): Mark locals as initialized.
b313f9d8
PE
2281 (RETALLOC_IF): Define only if needed.
2282 (WORDCHAR_P): Likewise. This one is never needed, but is used
2283 only in a comment talking about a compiler bug, so put inside
2284 the #if 0 of that comment.
2285 (CHARSET_LOOKUP_BITMAP, FAIL_STACK_FULL, RESET_FAIL_STACK):
2286 (PUSH_FAILURE_ELT, BUF_PUSH_3, STOP_ADDR_VSTRING):
2287 Remove; unused.
19ed5445 2288
1f3561e4 2289 * search.c (boyer_moore): Rename locals to avoid shadowing.
76ef09b7
PE
2290 * character.h (FETCH_STRING_CHAR_AS_MULTIBYTE_ADVANCE):
2291 (PREV_CHAR_BOUNDARY): Likewise.
1f3561e4 2292
ded6f8f7
PE
2293 * search.c (simple_search): Remove unused var.
2294
dbd37a95
PE
2295 * dired.c (compile_pattern): Move decl from here ...
2296 * lisp.h: ... to here, so that it can be checked.
2297 (struct re_registers): New forward decl.
2298
7e47afad
PE
2299 * character.h (INC_POS, DEC_POS): Rename locals to avoid shadowing.
2300
85f24f61
PE
2301 * indent.c (MULTIBYTE_BYTES_WIDTH): New args bytes, width.
2302 All uses changed.
2303 (MULTIBYTE_BYTES_WIDTH, scan_for_column, compute_motion):
2304 Rename locals to avoid shadowing.
5671df8f 2305 (Fvertical_motion): Mark locals as initialized.
85f24f61 2306
181aa2be 2307 * casefiddle.c (casify_object, casify_region): Now static.
e45a141a 2308 (casify_region): Mark local as initialized.
181aa2be 2309
930d429c
PE
2310 * cmds.c (internal_self_insert): Rename local to avoid shadowing.
2311
7082eac6
PE
2312 * lisp.h (GCPRO2_VAR, GCPRO3_VAR, GCPRO4_VAR, GCPRO5_VAR, GCPRO6_VAR):
2313 New macros, so that the caller can use some names other than
2314 gcpro1, gcpro2, etc.
2315 (GCPRO2, GCPRO3, GCPRO4, GCPRO5, GCPRO6): Reimplement in terms
2316 of the new macros.
2317 (GCPRO1_VAR, UNGCPRO_VAR): Change the meaning of the second
2318 argument, for consistency with GCPRO2_VAR, etc: it is now the
2319 prefix of the variable, not the variable itself. All uses
2320 changed.
38b2c076
PE
2321 * dired.c (directory_files_internal, file_name_completion):
2322 Rename locals to avoid shadowing.
2323
15206ed9
PE
2324 Fix a race condition diagnosed by gcc -Wsequence-point (Bug#8254).
2325 An expression of the form (DOWNCASE (x) == DOWNCASE (y)), found in
2326 dired.c's scmp function, had undefined behavior.
2327 * lisp.h (DOWNCASE_TABLE, UPCASE_TABLE, DOWNCASE, UPPERCASEP):
2328 (NOCASEP, LOWERCASEP, UPCASE, UPCASE1): Move from here ...
2329 * buffer.h: ... to here, because these macros use current_buffer,
2330 and the new implementation with inline functions needs to have
2331 current_buffer in scope now, rather than later when the macros
2332 are used.
2333 (downcase, upcase1): New static inline functions.
2334 (DOWNCASE, UPCASE1): Reimplement using these functions.
2335 This avoids undefined behavior in expressions like
2336 DOWNCASE (x) == DOWNCASE (y), which previously suffered
2337 from race conditions in accessing the global variables
2338 case_temp1 and case_temp2.
2339 * casetab.c (case_temp1, case_temp2): Remove; no longer needed.
2340 * lisp.h (case_temp1, case_temp2): Remove their decls.
2341 * character.h (ASCII_CHAR_P): Move from here ...
2342 * lisp.h: ... to here, so that the inline functions mentioned
2343 above can use them.
2344
4a6bea26
PE
2345 * dired.c (directory_files_internal_unwind): Now static.
2346
f14b7e14
PE
2347 * fileio.c (file_name_as_directory, directory_file_name):
2348 (barf_or_query_if_file_exists, auto_save_error, auto_save_1):
2349 Now static.
2893f146
PE
2350 (file_name_as_directory): Use const pointers when appropriate.
2351 (Fexpand_file_name): Likewise. In particular, newdir might
2352 point at constant storage, so make it a const pointer.
fd4ead52 2353 (Fmake_directory_internal, Fread_file_name): Remove unused vars.
b14aac08
PE
2354 (Ffile_selinux_context, Fset_file_selinux_context): Fix pointer
2355 signedness issues.
f839df0c
PE
2356 (Fset_file_times, Finsert_file_contents, auto_save_error):
2357 Rename locals to avoid shadowing.
f14b7e14 2358
5716756e 2359 * minibuf.c (choose_minibuf_frame_1): Now static.
62137a95
PE
2360 (Ftry_completion, Fall_completions): Rename or remove locals
2361 to avoid shadowing.
5716756e 2362
b4c3046a
PE
2363 * marker.c (bytepos_to_charpos): Remove; unused.
2364
b45db522
PE
2365 * lisp.h (verify_bytepos, count_markers): New decls,
2366 so that gcc does not warn that these functions aren't declared.
2367
85876d07
PE
2368 * insdel.c (check_markers, make_gap_larger, make_gap_smaller):
2369 (reset_var_on_error, Fcombine_after_change_execute_1): Now static.
f0cb4a60 2370 (CHECK_MARKERS): Redo to avoid gcc -Wempty-body diagnostic.
40ef059e 2371 (copy_text): Remove unused local var.
85876d07 2372
03d78a21 2373 * filelock.c (within_one_second): Now static.
b3dd38ab 2374 (lock_file_1): Rename local to avoid shadowing.
03d78a21 2375
5df8f01b
PE
2376 * buffer.c (fix_overlays_before): Mark locals as initialized.
2377 (fix_start_end_in_overlays): Likewise. This function should be
2378 simplified by using pointers-to-pointers, but that's a different
2379 matter.
b1d876f1 2380 (switch_to_buffer_1): Now static.
8f54f30a
PE
2381 (Fkill_buffer, record_buffer, Fbury_buffer, Fset_buffer_multibyte):
2382 (report_overlay_modification): Rename locals to avoid shadowing.
c3bd59b5 2383
a70072c9 2384 * sysdep.c (system_process_attributes): Rename vars to avoid shadowing.
fbd02d7b 2385 Fix pointer signedness issue.
edced198
PE
2386 (sys_subshell): Mark local as volatile if checking for lint,
2387 to suppress a gcc -Wclobbered warning that does not seem to be right.
15dfd3d9 2388 (MAXPATHLEN): Define only if needed.
a70072c9 2389
a0977c44
PE
2390 * process.c (serial_open, serial_configure): Move decls from here ...
2391 * systty.h: ... to here, so that they can be checked.
2392
a884fdcc
PE
2393 * fns.c (get_random, seed_random): Move extern decls from here ...
2394 * lisp.h: ... to here, so that they can be checked.
2395
604efe86 2396 * sysdep.c (reset_io): Now static.
b8950c94 2397 (wait_for_termination_signal): Remove; unused.
604efe86 2398
38fc62d9
PE
2399 * keymap.c (keymap_parent, keymap_memberp, map_keymap_internal):
2400 (copy_keymap_item, append_key, push_text_char_description):
2401 Now static.
1004a21a 2402 (Fwhere_is_internal): Don't test CONSP (sequences) unnecessarily.
dbbb8427 2403 (DENSE_TABLE_SIZE): Remove; unused.
c1141155
PE
2404 (get_keymap, access_keymap, Fdefine_key, Fwhere_is_internal):
2405 (describe_map_tree):
2406 Rename locals to avoid shadowing.
38fc62d9 2407
2f2650da
PE
2408 * keyboard.c: Declare functions static if they are not used elsewhere.
2409 (echo_char, echo_dash, cmd_error, top_level_2):
2410 (poll_for_input, handle_async_input): Now static.
69a058fa
PE
2411 (read_char, kbd_buffer_get_event, make_lispy_position):
2412 (make_lispy_event, make_lispy_movement, apply_modifiers):
2413 (decode_keyboard_code, tty_read_avail_input, menu_bar_items):
2414 (parse_tool_bar_item, read_key_sequence, Fread_key_sequence):
2415 (Fread_key_sequence_vector): Rename locals to avoid shadowing.
c8a06054 2416 (read_key_sequence, read_char): Mark locals as initialized.
3ac94672 2417 (Fexit_recursive_edit, Fabort_recursive_edit): Mark with NO_RETURN.
2f2650da 2418
a053e86c 2419 * keyboard.h (make_ctrl_char): New decl.
da2f2dd9
PE
2420 (mark_kboards): Move decl here ...
2421 * alloc.c (mark_kboards): ... from here.
a053e86c 2422
4752793e
PE
2423 * lisp.h (force_auto_save_soon): New decl.
2424
74f10ca7 2425 * emacs.c (init_cmdargs): Rename local to avoid shadowing.
244fc23d
PE
2426 (DEFINE_DUMMY_FUNCTION): New macro.
2427 (__do_global_ctors, __do_global_ctors_aux, __do_global_dtors, __main):
2428 Use it.
c03cd23f
PE
2429 (main): Add casts to avoid warnings
2430 if GCC considers string literals to be constants.
74f10ca7 2431
022e70d4
PE
2432 * lisp.h (fatal_error_signal): Add decl, since it's exported.
2433
59d6fe83
PE
2434 * dbusbind.c: Pointer signedness fixes.
2435 (xd_signature, xd_append_arg, xd_initialize):
2436 (Fdbus_call_method, Fdbus_call_method_asynchronously):
2437 (Fdbus_method_return_internal, Fdbus_method_error_internal):
2438 (Fdbus_send_signal, xd_read_message_1, Fdbus_register_service):
2439 (Fdbus_register_signal): Use SSDATA when the context wants char *.
2440
78320123
PE
2441 * dbusbind.c (Fdbus_init_bus): Add cast to avoid warning
2442 if GCC considers string literals to be constants.
49cebcca 2443 (Fdbus_register_service, Fdbus_register_method): Remove unused vars.
78320123 2444
35ac2a97
SM
24452011-03-16 Stefan Monnier <monnier@iro.umontreal.ca>
2446
fb103ca9
SM
2447 * print.c (PRINT_CIRCLE_CANDIDATE_P): New macro.
2448 (print_preprocess, print_object): New macro to fix last change.
2449
35ac2a97
SM
2450 * print.c (print_preprocess): Don't forget font objects.
2451
62973b41
JB
24522011-03-16 Juanma Barranquero <lekktu@gmail.com>
2453
2454 * emacs.c (USAGE3): Doc fixes.
2455
0e48bb22
AS
24562011-03-15 Andreas Schwab <schwab@linux-m68k.org>
2457
2458 * coding.c (detect_coding_iso_2022): Reorganize code to clarify
2459 structure.
2460
7684e57b
JB
24612011-03-14 Juanma Barranquero <lekktu@gmail.com>
2462
2463 * lisp.h (VWindow_system, Qfile_name_history):
2464 * keyboard.h (lispy_function_keys) [WINDOWSNT]:
2465 * w32term.h (w32_system_caret_hwnd, w32_system_caret_height)
2466 (w32_system_caret_x, w32_system_caret_y): Declare extern.
2467
2468 * w32select.c: Don't #include "keyboard.h".
c96bbc66 2469 (run_protected): Add extern declaration for waiting_for_input.
7684e57b
JB
2470
2471 * w32.c (Qlocal, noninteractive1, inhibit_window_system):
2472 * w32console.c (detect_input_pending, read_input_pending)
2473 (encode_terminal_code):
2474 * w32fns.c (quit_char, lispy_function_keys, Qtooltip)
2475 (w32_system_caret_hwnd, w32_system_caret_height, w32_system_caret_x)
2476 (w32_system_caret_y, Qfile_name_history):
2477 * w32font.c (w32font_driver, QCantialias, QCotf, QClang):
2478 * w32inevt.c (reinvoke_input_signal, lispy_function_keys):
2479 * w32menu.c (Qmenu_bar, QCtoggle, QCradio, Qoverriding_local_map)
2480 (Qoverriding_terminal_local_map, Qmenu_bar_update_hook):
2481 * w32proc.c (Qlocal, report_file_error):
2482 * w32term.c (Vwindow_system, updating_frame):
2483 * w32uniscribe.c (initialized, uniscribe_font_driver):
2484 Remove unneeded extern declarations.
2485
2aa46d6c
CY
24862011-03-14 Chong Yidong <cyd@stupidchicken.com>
2487
c96bbc66 2488 * buffer.c (Fmake_indirect_buffer): Fix incorrect assertions.
2aa46d6c 2489
cffc6f3b
CY
24902011-03-13 Chong Yidong <cyd@stupidchicken.com>
2491
2492 * buffer.h (BUF_BEGV, BUF_BEGV_BYTE, BUF_ZV, BUF_ZV_BYTE, BUF_PT)
2493 (BUF_PT_BYTE): Rewrite to handle indirect buffers (Bug#8219).
2494 These macros can no longer be used for assignment.
2495
44f230aa
SM
2496 * buffer.c (Fget_buffer_create, Fmake_indirect_buffer):
2497 Assign struct members directly, instead of using BUF_BEGV etc.
cffc6f3b
CY
2498 (record_buffer_markers, fetch_buffer_markers): New functions for
2499 recording and fetching special buffer markers.
2500 (set_buffer_internal_1, set_buffer_temp): Use them.
2501
2502 * lread.c (unreadchar): Use SET_BUF_PT_BOTH.
2503
2504 * insdel.c (adjust_point): Use SET_BUF_PT_BOTH.
2505
2506 * intervals.c (temp_set_point_both): Use SET_BUF_PT_BOTH.
2507 (get_local_map): Use SET_BUF_BEGV_BOTH and SET_BUF_ZV_BOTH.
2508
2509 * xdisp.c (hscroll_window_tree):
2510 (reconsider_clip_changes): Use PT instead of BUF_PT.
2511
d251f04b
EZ
25122011-03-13 Eli Zaretskii <eliz@gnu.org>
2513
2514 * makefile.w32-in ($(BLD)/editfns.$(O)): Depend on
2515 $(EMACS_ROOT)/lib/intprops.h.
2516
f0c77cd1
PE
25172011-03-13 Paul Eggert <eggert@cs.ucla.edu>
2518
3eca4629
PE
2519 Fix more problems found by GCC 4.5.2's static checks.
2520
7c86ee98
PE
2521 * gtkutil.c (xg_get_pixbuf_from_pixmap): Add cast from char *
2522 to unsigned char * to avoid compiler diagnostic.
b0afc268
PE
2523 (xg_free_frame_widgets): Make it clear that a local variable is
2524 needed only if USE_GTK_TOOLTIP.
01e0b5ad
PE
2525 (gdk_window_get_screen): Make it clear that this macro is needed
2526 only if USE_GTK_TOOLTIP.
1e5524e7
PE
2527 (int_gtk_range_get_value): New function, which avoids a diagnostic
2528 from gcc -Wbad-function-cast.
2529 (xg_set_toolkit_scroll_bar_thumb): Use it.
2530 (xg_tool_bar_callback, xg_tool_item_stale_p): Rewrite to avoid
2531 diagnostic from gcc -Wbad-function-cast.
65dc836c
PE
2532 (get_utf8_string, xg_get_file_with_chooser):
2533 Rename locals to avoid shadowing.
2534 (create_dialog): Move locals to avoid shadowing.
7c86ee98 2535
41729b81
PE
2536 * xgselect.c (xg_select): Remove unused var.
2537
f0c77cd1
PE
2538 * image.c (four_corners_best): Mark locals as initialized.
2539 (gif_load): Initialize transparent_p to zero (Bug#8238).
2540 Mark another local as initialized.
ec6cf4c6 2541 (my_png_error, my_error_exit): Mark with NO_RETURN.
f0c77cd1 2542
ce0ad53d 2543 * image.c (clear_image_cache): Now static.
d5d5a617 2544 (DIM, HAVE_STDLIB_H_1): Remove unused macros.
e22cffbc 2545 (xpm_load): Redo to avoid "discards qualifiers" gcc warning.
77a765fd
PE
2546 (x_edge_detection): Remove unnecessary cast that
2547 gcc -Wbad-function-cast diagnoses.
2037898d 2548 (gif_load): Fix pointer signedness.
6ae141d6
PE
2549 (clear_image_cache, xbm_read_bitmap_data, x_detect_edges):
2550 (jpeg_load, gif_load): Rename locals to avoid shadowing.
ce0ad53d 2551
33383987 25522011-03-12 Paul Eggert <eggert@cs.ucla.edu>
3eca4629 2553
d32df629
PE
2554 Improve quality of tests for time stamp overflow.
2555 For example, without this patch (encode-time 0 0 0 1 1
2556 1152921504606846976) returns the obviously-bogus value (-948597
2557 62170) on my RHEL 5.5 x86-64 host. With the patch, it correctly
2558 reports time overflow. See
2559 <http://lists.gnu.org/archive/html/emacs-devel/2011-03/msg00470.html>.
b8d9bd41
PE
2560 * deps.mk (editfns.o): Depend on ../lib/intprops.h.
2561 * editfns.c: Include limits.h and intprops.h.
2562 (TIME_T_MIN, TIME_T_MAX): New macros.
2563 (time_overflow): Move earlier, to before first use.
2564 (hi_time, lo_time): New functions, for an accurate test for
2565 out-of-range times.
2566 (Fcurrent_time, Fget_internal_run_time, make_time): Use them.
2567 (Fget_internal_run_time): Don't assume time_t fits in int.
2568 (make_time): Use list2 instead of Fcons twice.
2569 (Fdecode_time): More accurate test for out-of-range times.
2570 (check_tm_member): New function.
2571 (Fencode_time): Use it, to test for out-of-range times.
d32df629
PE
2572 (lisp_time_argument): Don't rely on undefined left-shift and
2573 right-shift behavior when checking for time stamp overflow.
8be6f318 2574
fe31d94c
PE
2575 * editfns.c (time_overflow): New function, refactoring common code.
2576 (Fformat_time_string, Fdecode_time, Fencode_time):
2577 (Fcurrent_time_string): Use it.
2578
8be6f318
PE
2579 Move 'make_time' to be next to its inverse 'lisp_time_argument'.
2580 * dired.c (make_time): Move to ...
2581 * editfns.c (make_time): ... here.
2582 * systime.h: Note the move.
2583
09d9db2c 25842011-03-12 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
c47cbdfd 2585
126bc0dc
YM
2586 * fringe.c (update_window_fringes): Remove unused variables.
2587
c47cbdfd
YM
2588 * unexmacosx.c (copy_data_segment): Also copy __got section.
2589 (Bug#8223)
2590
7ac80be9
EZ
25912011-03-12 Eli Zaretskii <eliz@gnu.org>
2592
c96bbc66 2593 * termcap.c [MSDOS]: Include "msdos.h".
058e5dad
EZ
2594 (find_capability, tgetnum, tgetflag, tgetstr, tputs, tgetent):
2595 Constify `char *' arguments and their references according to
2596 prototypes in tparam.h.
2597
ecb0f94d 2598 * deps.mk (termcap.o): Depend on tparam.h and msdos.h.
058e5dad 2599
7ac80be9
EZ
2600 * msdos.c (XMenuAddPane): 3rd argument is `const char *' now.
2601 Adapt all references accordingly.
2602
2603 * msdos.h (XMenuAddPane): 3rd argument is `const char *' now.
2604
ef1fd07e
TT
26052011-03-11 Tom Tromey <tromey@redhat.com>
2606
2607 * buffer.c (syms_of_buffer): Remove obsolete comment.
2608
7ef4b50c
EZ
26092011-03-11 Eli Zaretskii <eliz@gnu.org>
2610
2611 * termhooks.h (encode_terminal_code): Declare prototype.
2612
2613 * msdos.c (encode_terminal_code): Don't declare prototype.
2614
2615 * term.c (encode_terminal_code): Now external again, used by
2616 w32console.c and msdos.c.
2617
44f230aa
SM
2618 * makefile.w32-in ($(BLD)/term.$(O), ($(BLD)/tparam.$(O)):
2619 Depend on $(SRC)/tparam.h, see 2011-03-11T07:24:21Z!eggert@cs.ucla.edu.
7ef4b50c 2620
4b1ec863 26212011-03-11 Paul Eggert <eggert@cs.ucla.edu>
f78faa98 2622
1714f52b 2623 Fix some minor problems found by GCC 4.5.2's static checks.
83316bf4 2624
4b1ec863
PE
2625 * fringe.c (update_window_fringes): Mark locals as initialized
2626 (Bug#8227).
2627 (destroy_fringe_bitmap, init_fringe_bitmap): Now static.
bf60f616 2628
524c7aa6
PE
2629 * alloc.c (mark_fringe_data): Move decl from here ...
2630 * lisp.h (mark_fringe_data) [HAVE_WINDOW_SYSTEM]: ... to here,
2631 to check its interface.
2632 (init_fringe_once): Do not declare unless HAVE_WINDOW_SYSTEM.
2633
a5c0af81 2634 * fontset.c (free_realized_fontset): Now static.
7519b8cd 2635 (Fset_fontset_font): Rename local to avoid shadowing.
cc6e5db1 2636 (fontset_font): Mark local as initialized.
a9a06e0b 2637 (FONTSET_SPEC, FONTSET_REPERTORY, RFONT_DEF_REPERTORY): Remove; unused.
a5c0af81 2638
b4716021
PE
2639 * xrdb.c: Include "xterm.h", to check x_load_resources's interface.
2640
811e9bac 2641 * xselect.c (x_disown_buffer_selections): Remove; not used.
7b83e2f1 2642 (TRACE3) [!defined TRACE_SELECTION]: Remove; not used.
aa0daa9f
PE
2643 (x_own_selection, Fx_disown_selection_internal): Rename locals
2644 to avoid shadowing.
2645 (x_handle_dnd_message): Remove local to avoid shadowing.
811e9bac 2646
7e3ab302
PE
2647 * lisp.h (GCPRO1_VAR, UNGCPRO_VAR): New macros,
2648 so that the caller can use some name other than gcpro1.
2649 (GCPRO1, UNGCPRO): Reimplement in terms of the new macros.
58d2d479
PE
2650 * xfns.c (Fx_create_frame, x_create_tip_frame, Fx_show_tip):
2651 (Fx_backspace_delete_keys_p):
2652 Use them to avoid shadowing, and rename vars to avoid shadowing.
2653 (x_decode_color, x_set_name, x_window): Now static.
6b437900 2654 (Fx_create_frame): Add braces to silence GCC warning.
c0951e53 2655 (Fx_file_dialog, Fx_select_font): Fix pointer signedness.
06b0c8a0
PE
2656 (x_real_positions, xg_set_icon_from_xpm_data, x_create_tip_frame):
2657 Remove unused locals.
7e3ab302
PE
2658 (Fx_create_frame, x_create_tip_frame, Fx_show_tip):
2659 (Fx_backspace_delete_keys_p): Rename locals to avoid shadowing.
2660 Some of these renamings use the new GCPRO1_VAR and UNGCPRO_VAR
2661 macros.
f78faa98 2662
e2b13473
PE
2663 * xterm.h (x_mouse_leave): New decl.
2664
77f23912
PE
2665 * xterm.c (x_copy_dpy_color, x_focus_on_frame, x_unfocus_frame):
2666 Remove unused functions.
cdf4ba58
PE
2667 (x_shift_glyphs_for_insert, XTflash, XTring_bell):
2668 (x_calc_absolute_position): Now static.
7411c686 2669 (XTread_socket): Don't define label "out" unless it's used.
2b07bcff 2670 Don't declare local "event" unless it's used.
ed7bf3a5
PE
2671 (x_iconify_frame, x_free_frame_resources): Don't declare locals
2672 unless they are used.
38d0b34a
PE
2673 (XEMBED_VERSION, xembed_set_info): Don't define unless needed.
2674 (x_fatal_error_signal): Remove; not used.
a6067996
PE
2675 (x_draw_image_foreground, redo_mouse_highlight, XTmouse_position):
2676 (x_scroll_bar_report_motion, handle_one_xevent, x_draw_bar_cursor):
2677 (x_error_catcher, x_connection_closed, x_error_handler):
2678 (x_error_quitter, xembed_send_message, x_iconify_frame):
2679 (my_log_handler): Rename locals to avoid shadowing.
28f1c698 2680 (x_delete_glyphs, x_ins_del_lines): Mark with NO_RETURN.
2a8fade0 2681 (x_connection_closed): Tell GCC not to suggest NO_RETURN.
77f23912 2682
44f230aa
SM
2683 * xfaces.c (clear_face_cache, Fx_list_fonts, Fface_font):
2684 Rename or move locals to avoid shadowing.
6b463e58 2685 (tty_defined_color, merge_face_heights): Now static.
5967d051 2686 (free_realized_faces_for_fontset): Remove; not used.
1e9966ea
PE
2687 (Fx_list_fonts): Mark variable that gcc -Wuninitialized
2688 does not deduce is never used uninitialized.
73719eba
PE
2689 (STRDUPA, LSTRDUPA, FONT_POINT_SIZE_QUANTUM): Remove; not used.
2690 (LFACEP): Define only if XASSERTS, as it's not needed otherwise.
071048a3 2691
426994c3 2692 * terminal.c (store_terminal_param): Now static.
5489860b 2693
032f1620 2694 * xmenu.c (menu_highlight_callback): Now static.
9d66f88e 2695 (set_frame_menubar): Remove unused local.
d4323972 2696 (xmenu_show): Rename parameter to avoid shadowing.
6d1f7fee
PE
2697 (xmenu_show, xdialog_show, xmenu_show): Make local pointers "const"
2698 since they might point to immutable storage.
281585b0
PE
2699 (next_menubar_widget_id): Declare only if USE_X_TOOLKIT,
2700 since it's unused otherwise.
032f1620 2701
367c19e5 2702 * xdisp.c (produce_glyphless_glyph): Initialize lower_xoff.
53df7c11 2703 Add a FIXME, since the code still doesn't look right. (Bug#8215)
9f36b9fd
PE
2704 (Fcurrent_bidi_paragraph_direction): Simplify slightly; this
2705 avoids a gcc -Wuninitialized diagnostic.
0e086e8f 2706 (display_line, BUILD_COMPOSITE_GLYPH_STRING, draw_glyphs):
44a3a108
PE
2707 (note_mouse_highlight): Mark variables that gcc -Wuninitialized
2708 does not deduce are never used uninitialized.
70739cbe 2709
07b48fa9
PE
2710 * lisp.h (IF_LINT): New macro, copied from ../lib-src/emacsclient.c.
2711
8868a238 2712 * xdisp.c (redisplay_window): Rename local to avoid shadowing.
4554d213
PE
2713 * window.c (window_loop, size_window):
2714 (run_window_configuration_change_hook, enlarge_window): Likewise.
8868a238 2715
7e5cf297 2716 * window.c (display_buffer): Now static.
d6550a9f
PE
2717 (size_window): Mark variables that gcc -Wuninitialized
2718 does not deduce are never used uninitialized.
a586633d
PE
2719 * window.h (check_all_windows): New decl, to forestall
2720 gcc -Wmissing-prototypes diagnostic.
5b555da1 2721 * dispextern.h (bidi_dump_cached_states): Likewise.
7e5cf297 2722
f6095868
PE
2723 * charset.h (CHECK_CHARSET_GET_CHARSET): Rename locals to avoid
2724 shadowing.
2725 * charset.c (map_charset_for_dump, Fchar_charset): Likewise.
726929c4
PE
2726 Include <limits.h>.
2727 (Fsort_charsets): Redo min/max calculation to shorten the code a bit
2728 and to avoid gcc -Wuninitialized warning.
89ef49df
PE
2729 (load_charset_map): Mark variables that gcc -Wuninitialized
2730 does not deduce are never used uninitialized.
53df7c11 2731 (load_charset): Abort instead of using uninitialized var (Bug#8229).
f6095868 2732
f38b440c
PE
2733 * coding.c (coding_set_source, coding_set_destination):
2734 Use "else { /* comment */ }" rather than "else /* comment */;"
2735 for clarity, and to avoid gcc -Wempty-body warning.
2735d060
PE
2736 (Fdefine_coding_system_internal): Don't redeclare 'i' inside
2737 a block, when the outer 'i' will do.
2738 (decode_coding_utf_8, decode_coding_utf_16, detect_coding_emacs_mule):
2739 (emacs_mule_char, decode_coding_emacs_mule, detect_coding_iso_2022):
2740 (decode_coding_iso_2022, decode_coding_sjis, decode_coding_big5):
2741 (decode_coding_raw_text, decode_coding_charset, get_translation_table):
2742 (Fdecode_sjis_char, Fdefine_coding_system_internal):
2743 Rename locals to avoid shadowing.
2744 * character.h (FETCH_STRING_CHAR_ADVANCE): Likewise.
e2f1bab9
PE
2745 * coding.c (emacs_mule_char, encode_invocation_designation):
2746 Now static, since they're not used elsewhere.
413bb2db 2747 (decode_coding_iso_2022): Add "default: abort ();" as a safety check.
c4a63b12 2748 (decode_coding_object, encode_coding_object, detect_coding_system):
ee05f961
PE
2749 (decode_coding_emacs_mule): Mark variables that gcc
2750 -Wuninitialized does not deduce are never used uninitialized.
160b01f6
PE
2751 (detect_coding_iso_2022): Initialize a local variable that might
2752 be used uninitialized. Leave a FIXME because it's not clear that
53df7c11 2753 this initialization is needed. (Bug#8211)
5f58e762
PE
2754 (ISO_CODE_LF, ISO_CODE_CR, CODING_ISO_FLAG_EUC_TW_SHIFT):
2755 (ONE_MORE_BYTE_NO_CHECK, UTF_BOM, UTF_16_INVALID_P):
2756 (SHIFT_OUT_OK, ENCODE_CONTROL_SEQUENCE_INTRODUCER):
2757 (ENCODE_DIRECTION_R2L, ENCODE_DIRECTION_L2R):
2758 Remove unused macros.
f38b440c 2759
232b38b9 2760 * category.c (hash_get_category_set): Remove unused local var.
9f3b5e69 2761 (copy_category_table): Now static, since it's not used elsewhere.
d0891610 2762 * character.c (string_count_byte8): Likewise.
232b38b9 2763
fb90da1b
PE
2764 * ccl.c (CCL_WRITE_STRING, CCL_ENCODE_CHAR, Fccl_execute_on_string):
2765 (Fregister_code_conversion_map): Rename locals to avoid shadowing.
2766
fb93dbc2
PE
2767 * chartab.c (copy_sub_char_table): Now static, since it's not used
2768 elsewhere.
5c156ace
PE
2769 (sub_char_table_ref_and_range, char_table_ref_and_range):
2770 Rename locals to avoid shadowing.
bbcd0949 2771 (ASET_RANGE, GET_SUB_CHAR_TABLE): Remove unused macros.
fb93dbc2 2772
7d3b3862 2773 * bidi.c (bidi_check_type): Now static, since it's not used elsewhere.
630d6892 2774 (BIDI_BOB): Remove unused macro.
7d3b3862 2775
6be7d3da
PE
2776 * cm.c (cmgoto): Mark variables that gcc -Wuninitialized does not
2777 deduce are never used uninitialized.
c2ed9c8b 2778 * term.c (encode_terminal_code): Likewise.
6be7d3da 2779
75f8807f 2780 * term.c (encode_terminal_code): Now static. Remove unused local.
72abad34 2781
50938595
PE
2782 * tparam.h: New file.
2783 * term.c, tparam.h: Include it.
2784 * deps.mk (term.o, tparam.o): Depend on tparam.h.
2785 * term.c (tputs, tgetent, tgetflag, tgetnum, tparam, tgetstr):
2786 Move these decls to tparam.h, and make them agree with what
2787 is actually in tparam.c. The previous trick of using incompatible
2788 decls in different modules does not conform to the C standard.
2789 All callers of tparam changed to use tparam's actual API.
2790 * tparam.c (tparam1, tparam, tgoto):
2791 Use const pointers where appropriate.
2792
fbceeba2
PE
2793 * cm.c (calccost, cmgoto): Use const pointers where appropriate.
2794 * cm.h (struct cm): Likewise.
2795 * dispextern.h (do_line_insertion_deletion_costs): Likewise.
2796 * scroll.c (ins_del_costs, do_line_insertion_deletion_costs): Likewise.
2797 * term.c (tty_ins_del_lines, calculate_costs, struct fkey_table):
2798 (term_get_fkeys_1, append_glyphless_glyph, produce_glyphless_glyph):
2799 (turn_on_face, init_tty): Likewise.
2800 * termchar.h (struct tty_display_info): Likewise.
fbceeba2 2801
7f3f1250
PE
2802 * term.c (term_mouse_position): Rename local to avoid shadowing.
2803
e6ca6543
PE
2804 * alloc.c (mark_ttys): Move decl from here ...
2805 * lisp.h (mark_ttys): ... to here, so that it's checked against defn.
2806
c40f8d15
AS
28072011-03-11 Andreas Schwab <schwab@linux-m68k.org>
2808
2809 * .gdbinit (pwinx, xbuffer): Fix access to buffer name.
2810
cfe0661d
JB
28112011-03-09 Juanma Barranquero <lekktu@gmail.com>
2812
2813 * search.c (compile_pattern_1): Remove argument regp, unused since
2814 revid:rms@gnu.org-19941211082627-3x1g1wyqkjmwloig.
2815 (compile_pattern): Don't pass it.
2816
0afb4571
J
28172011-03-08 Jan Djärv <jan.h.d@swipnet.se>
2818
2819 * xterm.h (DEFAULT_GDK_DISPLAY): New define.
2820 (GDK_WINDOW_XID, gtk_widget_get_preferred_size): New defines
2821 for ! HAVE_GTK3.
2822 (GTK_WIDGET_TO_X_WIN): Use GDK_WINDOW_XID.
2823
2824 * xmenu.c (menu_position_func): Call gtk_widget_get_preferred_size.
2825
2826 * gtkutil.c: Include gtkx.h if HAVE_GTK3. If ! HAVE_GTK3, define
2827 gdk_window_get_screen, gdk_window_get_geometry,
2828 gdk_x11_window_lookup_for_display and GDK_KEY_g.
2829 (xg_set_screen): Use DEFAULT_GDK_DISPLAY.
2830 (xg_get_pixbuf_from_pixmap): New function.
2831 (xg_get_pixbuf_from_pix_and_mask): Change parameters from GdkPixmap
2832 to Pixmap, take frame as parameter, remove GdkColormap parameter.
2833 Call xg_get_pixbuf_from_pixmap instead of
2834 gdk_pixbuf_get_from_drawable.
2835 (xg_get_image_for_pixmap): Do not make GdkPixmaps, call
2836 xg_get_pixbuf_from_pix_and_mask with Pixmap parameters instead.
2837 (xg_check_special_colors): Use GtkStyleContext and its functions
2838 for HAVE_GTK3.
2839 (xg_prepare_tooltip, xg_hide_tooltip): Call gdk_window_get_screen.
2840 (xg_prepare_tooltip, create_dialog, menubar_map_cb)
2841 (xg_update_frame_menubar, xg_tool_bar_detach_callback)
44f230aa
SM
2842 (xg_tool_bar_attach_callback, xg_update_tool_bar_sizes):
2843 Call gtk_widget_get_preferred_size.
0afb4571
J
2844 (xg_frame_resized): gdk_window_get_geometry only takes 5
2845 parameters.
44f230aa
SM
2846 (xg_win_to_widget, xg_event_is_for_menubar):
2847 Call gdk_x11_window_lookup_for_display.
0afb4571
J
2848 (xg_set_widget_bg): New function.
2849 (delete_cb): New function.
895009e1 2850 (xg_create_frame_widgets): Connect delete-event to delete_cb.
0afb4571
J
2851 Call xg_set_widget_bg. Only set backgrund pixmap for ! HAVE_GTK3
2852 (xg_set_background_color): Call xg_set_widget_bg.
2853 (xg_set_frame_icon): Call xg_get_pixbuf_from_pix_and_mask.
2854 (xg_create_scroll_bar): vadj is a GtkAdjustment for HAVE_GTK3.
2855 Only call gtk_range_set_update_policy if ! HAVE_GTK3.
2856 (xg_make_tool_item): Only connect xg_tool_bar_item_expose_callback
2857 if ! HAVE_GTK3.
2858 (update_frame_tool_bar): Call gtk_widget_hide.
2859 (xg_initialize): Use GDK_KEY_g.
2860
2861 * xsmfns.c (gdk_set_sm_client_id): Define to gdk_set_sm_client_id
2862 if ! HAVE_GTK3
2863 (x_session_initialize): Call gdk_x11_set_sm_client_id.
2864
2865 * xterm.c (XFillRectangle): Use cairo routines for HAVE_GTK3.
2866 (x_term_init): Disable Xinput(2) with GDK_CORE_DEVICE_EVENTS.
2867 Load ~/emacs.d/gtkrc only for ! HAVE_GTK3.
2868
1c2cc4ef
JB
28692011-03-08 Juanma Barranquero <lekktu@gmail.com>
2870
2871 * w32xfns.c (select_palette): Check success of RealizePalette against
2872 GDI_ERROR, not zero.
2873
33383987 2874See ChangeLog.11 for earlier changes.
aac0c6e3
MR
2875
2876;; Local Variables:
2877;; coding: utf-8
aac0c6e3
MR
2878;; End:
2879
33383987 2880 Copyright (C) 2011 Free Software Foundation, Inc.
aac0c6e3
MR
2881
2882 This file is part of GNU Emacs.
2883
2884 GNU Emacs is free software: you can redistribute it and/or modify
2885 it under the terms of the GNU General Public License as published by
2886 the Free Software Foundation, either version 3 of the License, or
2887 (at your option) any later version.
2888
2889 GNU Emacs is distributed in the hope that it will be useful,
2890 but WITHOUT ANY WARRANTY; without even the implied warranty of
2891 MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
2892 GNU General Public License for more details.
2893
2894 You should have received a copy of the GNU General Public License
2895 along with GNU Emacs. If not, see <http://www.gnu.org/licenses/>.