* src/sysdep.c (wait_for_termination_1): Make static.
[bpt/emacs.git] / src / ChangeLog
CommitLineData
e7a6747f
AS
12011-05-01 Andreas Schwab <schwab@linux-m68k.org>
2
3 * sysdep.c (wait_for_termination_1): Make static.
4 (wait_for_termination, interruptible_wait_for_termination): Move
5 after wait_for_termination_1.
6
1ef14cb4
LMI
72011-05-01 Lars Magne Ingebrigtsen <larsi@gnus.org>
8
9 * sysdep.c (interruptible_wait_for_termination): New function
10 which is like wait_for_termination, but allows keyboard
11 interruptions.
12
13 * callproc.c (Fcall_process): Add (:file "file") as an option for
14 the STDOUT buffer.
15 (Fcall_process_region): Ditto.
16
330d880c
EZ
172011-04-30 Eli Zaretskii <eliz@gnu.org>
18
8db90b73
EZ
19 * dosfns.c (Fint86, Fdos_memget, Fdos_memput): Use `ASIZE (FOO)'
20 rather than `XVECTOR (FOO)->size'.
21
330d880c
EZ
22 * process.c: Remove HAVE_INTTYPES_H condition from inclusion of
23 inttypes.h, as a gnulib replacement is used if it not available in
24 system headers.
25
15cbd324
EZ
262011-04-21 Eli Zaretskii <eliz@gnu.org>
27
28 Lift the MOST_POSITIVE_FIXNUM/4 limitation on visited files.
29 * fileio.c (Finsert_file_contents): Don't limit file size to 1/4
30 of MOST_POSITIVE_FIXNUM. (Bug#8528)
31
32 * coding.c (coding_alloc_by_realloc): Error out if destination
33 will grow beyond MOST_POSITIVE_FIXNUM.
34 (decode_coding_emacs_mule): Abort if there isn't enough place in
35 charbuf for the composition carryover bytes. Reserve an extra
36 space for up to 2 characters produced in a loop.
37 (decode_coding_iso_2022): Abort if there isn't enough place in
38 charbuf for the composition carryover bytes.
39
402011-04-21 Eli Zaretskii <eliz@gnu.org>
afda1437 41
ae940cca
EZ
42 * doprnt.c (doprnt) [!HAVE_LONG_LONG_INT]: Error out instead of
43 aborting when %lld or %lll format is passed.
44 [!HAVE_UNSIGNED_LONG_LONG_INT]: Error out instead of aborting when
45 %llo or %llx format is passed. (Bug#8545)
46
03ab8921
EZ
47 * window.c (window_scroll_line_based): Use a marker instead of
48 simple variables to record original value of point. (Bug#7952)
49
afda1437
EZ
50 * doprnt.c (doprnt): Fix the case where a multibyte sequence
51 produced by %s or %c overflows available buffer space. (Bug#8545)
52
f76dee0c
PE
532011-04-28 Paul Eggert <eggert@cs.ucla.edu>
54
55 * doprnt.c (doprnt): Omit useless test; int overflow check (Bug#8545).
283cdbef 56 (SIZE_MAX): Move defn after all includes, as they might #define it.
f76dee0c 57
fdc5744d
JB
582011-04-28 Juanma Barranquero <lekktu@gmail.com>
59
60 * w32.c (init_environment): Warn about defaulting HOME to C:\.
61
638f053a
JB
622011-04-28 Juanma Barranquero <lekktu@gmail.com>
63
64 * keyboard.c (Qdelayed_warnings_hook): Define.
65 (command_loop_1): Run `delayed-warnings-hook'
66 if Vdelayed_warnings_list is non-nil.
67 (syms_of_keyboard) <delayed-warnings-hook>: DEFSYM it.
68 (syms_of_keyboard) <delayed-warnings-list>: DEFVAR_LISP it.
69
d178f871
EZ
702011-04-28 Eli Zaretskii <eliz@gnu.org>
71
72 * doprnt.c (doprnt): Don't return value smaller than the buffer
73 size if the message was truncated. (Bug#8545).
74
b124fd93
JB
752011-04-28 Juanma Barranquero <lekktu@gmail.com>
76
77 * w32fns.c (Fx_change_window_property, Fx_delete_window_property)
78 (Fx_window_property): #if-0 the whole functions, not just the bodies.
79
e810457d
PE
802011-04-27 Paul Eggert <eggert@cs.ucla.edu>
81
82 * doprnt.c (doprnt): Support "ll" length modifier, for long long.
83
ea51cceb
JB
842011-04-27 Juanma Barranquero <lekktu@gmail.com>
85
86 * makefile.w32-in: Update dependencies.
87
94dcfacf
EZ
882011-04-27 Eli Zaretskii <eliz@gnu.org>
89
90 Improve `doprnt' and its usage. (Bug#8545)
91 * doprnt.c (doprnt): Make sure `format' is never accessed beyond
92 `format_end'. Remove support for %l as a conversion specifier.
93 Don't use xrealloc. Improve diagnostics when the %l size modifier
94 is used. Update the commentary.
95
96 * eval.c (verror): Simplify calculation of size_t.
97
98 * coding.c (Ffind_operation_coding_system): Fix diagnostic error
99 messages.
100
f61f41d7
PE
1012011-04-27 Yoshiaki Kasahara <kasahara@nc.kyushu-u.ac.jp> (tiny change)
102
103 * buffer.c (init_buffer) [USE_MMAP_FOR_BUFFERS]: Adjust to aliasing
104 change.
105
96fb4434
PE
1062011-04-27 Paul Eggert <eggert@cs.ucla.edu>
107
108 * nsmenu.m: Replace all uses of XVECTOR with ASIZE and AREF.
109 This makes this file independent of the recent pseudovector change.
110
671875da 1112011-04-26 Paul Eggert <eggert@cs.ucla.edu>
eab3844f 112
69e9b5a3
PE
113 * keyboard.c (handle_user_signal): Fix pointer signedness problem.
114
b5f869a7 115 * gnutls.c (emacs_gnutls_handle_error): Remove unused local.
7754e151 116 (Fgnutls_boot): gnutls_certificate_verify_peers2 wants unsigned *.
8d4c3955 117 Remove unused local.
c8926152 118 (emacs_gnutls_write): Don't use uninitialized rtnval if nbyte <= 0.
080e5a8d 119
841a1577 120 * lisp.h: Fix a problem with aliasing and vector headers. (Bug#8546)
eab3844f
PE
121 GCC 4.6.0 optimizes based on type-based alias analysis. For
122 example, if b is of type struct buffer * and v of type struct
123 Lisp_Vector *, then gcc -O2 was incorrectly assuming that &b->size
124 != &v->size, and therefore "v->size = 1; b->size = 2; return
125 v->size;" must therefore return 1. This assumption is incorrect
126 for Emacs, since it type-puns struct Lisp_Vector * with many other
127 types. To fix this problem, this patch adds a new type struct
f904488f 128 vectorlike_header that documents the constraints on layout of vectors
eab3844f
PE
129 and pseudovectors, and helps optimizing compilers not get fooled
130 by Emacs's type punning. It also adds the macros XSETTYPED_PVECTYPE
131 XSETTYPED_PSEUDOVECTOR, TYPED_PSEUDOVECTORP, for similar reasons.
f904488f
PE
132 * lisp.h (XSETTYPED_PVECTYPE): New macro, specifying the name of
133 the size member.
eab3844f
PE
134 (XSETPVECTYPE): Rewrite in terms of new macro.
135 (XSETPVECTYPESIZE): New macro, specifying both type and size.
136 This is a bit clearer, and further avoids the possibility of
137 undesirable aliasing.
138 (XSETTYPED_PSEUDOVECTOR): New macro, specifying the size.
f904488f 139 (XSETPSEUDOVECTOR): Rewrite in terms of XSETTYPED_PSEUDOVECTOR.
eab3844f
PE
140 (XSETSUBR): Rewrite in terms of XSETTYPED_PSEUDOVECTOR and XSIZE,
141 since Lisp_Subr is a special case (no "next" field).
f904488f
PE
142 (ASIZE): Now uses header.size rather than size. All
143 previous uses of XVECTOR (foo)->size replaced to use this macro,
144 to avoid the hassle of writing XVECTOR (foo)->header.size.
145 (struct vectorlike_header): New type.
eab3844f
PE
146 (TYPED_PSEUDOVECTORP): New macro, also specifying the C type of the
147 object, to help avoid aliasing.
148 (PSEUDOVECTORP): Rewrite in terms of TYPED_PSEUDOVECTORP.
149 (SUBRP): Likewise, since Lisp_Subr is a special case.
150 * lisp.h (struct Lisp_Vector, struct Lisp_Char_Table):
151 (struct Lisp_Sub_Char_Table, struct Lisp_Bool_Vector):
152 (struct Lisp_Hash_Table): Combine first two members into a single
f904488f 153 struct vectorlike_header member. All uses of "size" and "next" members
eab3844f
PE
154 changed to be "header.size" and "header.next".
155 * buffer.h (struct buffer): Likewise.
156 * font.h (struct font_spec, struct font_entity, struct font): Likewise.
157 * frame.h (struct frame): Likewise.
158 * process.h (struct Lisp_Process): Likewise.
159 * termhooks.h (struct terminal): Likewise.
160 * window.c (struct save_window_data, struct saved_window): Likewise.
161 * window.h (struct window): Likewise.
162 * alloc.c (allocate_buffer, Fmake_bool_vector, allocate_pseudovector):
163 Use XSETPVECTYPESIZE, not XSETPVECTYPE, to avoid aliasing problems.
164 * buffer.c (init_buffer_once): Likewise.
165 * lread.c (defsubr): Use XSETTYPED_PVECTYPE, since Lisp_Subr is a
166 special case.
167 * process.c (Fformat_network_address): Use local var for size,
168 for brevity.
169
0df1eac5
PE
170 * bytecode.c (exec_byte_code): Don't use XVECTOR before CHECK_VECTOR.
171
847ab9d1 172 Make the Lisp reader and string-to-float more consistent (Bug#8525)
452f4150
PE
173 * data.c (atof): Remove decl; no longer used or needed.
174 (digit_to_number): Move to lread.c.
175 (Fstring_to_number): Use new string_to_number function, to be
176 consistent with how the Lisp reader treats infinities and NaNs.
177 Do not assume that floating-point numbers represent EMACS_INT
178 without losing information; this is not true on most 64-bit hosts.
179 Avoid double-rounding errors, by insisting on integers when
180 parsing non-base-10 numbers, as the documentation specifies.
181 * lisp.h (string_to_number): New decl, replacing ...
182 (isfloat_string): Remove.
bc0a5c13 183 * lread.c: Include <inttypes.h>, for uintmax_t and strtoumax.
d78050d6 184 (read1): Do not accept +. and -. as integers; this
452f4150
PE
185 appears to have been a coding error. Similarly, do not accept
186 strings like +-1e0 as floating point numbers. Do not report
187 overflow for integer overflows unless the base is not 10 which
188 means we have no simple and reliable way to continue.
189 Break out the floating-point parsing into a new
190 function string_to_number, so that Fstring_to_number parses
191 floating point numbers consistently with the Lisp reader.
192 (digit_to_number): Moved here from data.c. Make it static inline.
193 (E_CHAR, EXP_INT): Remove, replacing with ...
194 (E_EXP): New macro, to solve the "1.0e+" problem mentioned below.
195 (string_to_number): New function, replacing isfloat_string.
196 This function checks for valid syntax and produces the resulting
197 Lisp float number too. Rework it so that string-to-number
bc0a5c13 198 no longer mishandles examples like "1.0e+". Use strtoumax,
d78050d6
PE
199 so that overflow for non-base-10 numbers is reported only when
200 there's no portable and simple way to convert to floating point.
452f4150 201
67769ffc
PE
202 * textprop.c (set_text_properties_1): Rewrite for clarity,
203 and to avoid GCC warning about integer overflow.
204
c20db43f
PE
205 * intervals.h (struct interval): Use EMACS_INT for members
206 where EMACS_UINT might cause problems. See
207 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00514.html>.
208 (CHECK_TOTAL_LENGTH): Remove cast to EMACS_INT; no longer needed.
209 * intervals.c (interval_deletion_adjustment): Now returns EMACS_INT.
210 All uses changed.
37aa2f85
PE
211 (offset_intervals): Tell GCC not to worry about length overflow
212 when negating a negative length.
c20db43f 213
2538aa2f
PE
214 * alloc.c (overrun_check_malloc, overrun_check_realloc): Now static.
215 (overrun_check_free): Likewise.
216
f2d3008d
PE
217 * alloc.c (SDATA_SIZE) [!GC_CHECK_STRING_BYTES]: Avoid runtime check
218 in the common case where SDATA_DATA_OFFSET is a multiple of Emacs
219 word size.
220
ec8df744
PE
221 * gnutls.c: Fix problems found by GCC 4.6.0 on Ubuntu 10.10.
222 (gnutls_make_error): Rename local to avoid shadowing.
223 (gnutls_emacs_global_deinit): ifdef out; not used.
224 (Fgnutls_boot): Use const for pointer to readonly storage.
225 Comment out unused local. Fix pointer signedness problems.
226
640ee02d
PE
227 * lread.c (openp): Don't stuff size_t into an 'int'.
228 Use <= on length, not < on length + 1, to avoid GCC 4.6.0 warning
229 about possible signed overflow.
230
6048fb2a
PE
231 * gtkutil.c: Fix problems found by GCC 4.6.0 on Ubuntu 10.10.
232 (GDK_KEY_g): Don't define if already defined.
233 (xg_prepare_tooltip): Avoid pointer signedness problem.
234 (xg_set_toolkit_scroll_bar_thumb): Redo to avoid two casts.
235
fa3c87e1
PE
236 * process.c (Fnetwork_interface_info): Avoid left-shift undefined
237 behavior with 1 << 31. GCC 4.6.0 warns about this on 32-bit hosts.
238
2172544b
PE
239 * xfns.c (Fx_window_property): Simplify a bit,
240 to make a bit faster and to avoid GCC 4.6.0 warning.
241 * xselect.c (x_get_window_property, x_handle_dnd_message): Likewise.
242
9b821a21
PE
243 * fns.c (internal_equal): Don't assume size_t fits in int.
244
3c616cfa
PE
245 * alloc.c (compact_small_strings): Tighten assertion a little.
246
c2982e87
PE
247 Replace pEd with more-general pI, and fix some printf arg casts.
248 * lisp.h (pI): New macro, generalizing old pEd macro to other
249 conversion specifiers. For example, use "...%"pI"d..." rather
250 than "...%"pEd"...".
251 (pEd): Remove. All uses replaced with similar uses of pI.
252 * src/m/amdx86-64.h, src/m/ia64.h, src/m/ibms390x.h: Likewise.
253 * alloc.c (check_pure_size): Don't overflow by converting size to int.
254 * bidi.c (bidi_dump_cached_states): Use pI to avoid cast.
255 * data.c (Fnumber_to_string): Use pI instead of if-then-else-abort.
256 * dbusbind.c (xd_append_arg): Use pI to avoid cast.
257 (Fdbus_method_return_internal, Fdbus_method_error_internal): Likewise.
258 * font.c (font_unparse_xlfd): Avoid potential buffer overrun on
259 64-bit hosts.
260 (font_unparse_xlfd, font_unparse_fcname): Use pI to avoid casts.
261 * keyboard.c (record_char, modify_event_symbol): Use pI to avoid casts.
262 * print.c (safe_debug_print, print_object): Likewise.
263 (print_object): Don't overflow by converting EMACS_INT or EMACS_UINT
264 to int.
6f04d126
PE
265 Use pI instead of if-then-else-abort. Use %p to avoid casts,
266 avoiding the 0 flag, which is not portable.
c2982e87
PE
267 * process.c (Fmake_network_process): Use pI to avoid cast.
268 * region-cache.c (pp_cache): Likewise.
269 * xdisp.c (decode_mode_spec): Likewise.
270 * xrdb.c (x_load_resources) [USE_MOTIF]: Use pI to avoid undefined
271 behavior on 64-bit hosts with printf arg.
6f04d126 272 * xselect.c (x_queue_event): Use %p to avoid casts, avoiding 0 flag.
c2982e87
PE
273 (x_stop_queuing_selection_requests): Likewise.
274 (x_get_window_property): Don't truncate byte count to an 'int'
275 when tracing.
0b432f21 276
5e073ec7
PE
277 * frame.c (frame_name_fnn_p): Get rid of strtol, which isn't right
278 here, since it parses constructs like leading '-' and spaces,
279 which are not wanted; and it overflows with large numbers.
280 Instead, simply match F[0-9]+, which is what is wanted anyway.
281
36372bf9
PE
282 * alloc.c: Remove unportable assumptions about struct layout.
283 (SDATA_SELECTOR, SDATA_DATA_OFFSET): New macros.
284 (SDATA_OF_STRING, SDATA_SIZE, allocate_string_data):
285 (allocate_vectorlike, make_pure_vector): Use the new macros,
286 plus offsetof, to remove unportable assumptions about struct layout.
287 These assumptions hold on all porting targets that I know of, but
288 they are not guaranteed, they're easy to remove, and removing them
289 makes further changes easier.
290
0b432f21
PE
291 * alloc.c (BLOCK BYTES): Fix typo by changing "ablock" to "ablocks".
292 This doesn't fix a bug but makes the code clearer.
bfd1c781
PE
293 (string_overrun_cookie): Now const. Use initializers that
294 don't formally overflow signed char, to avoid warnings.
000098c1
PE
295 (allocate_string_data) [GC_CHECK_STRING_OVERRUN]: Fix typo that
296 can cause Emacs to crash when string overrun checking is enabled.
c7bda33c
PE
297 (allocate_buffer): Don't assume sizeof (struct buffer) is a
298 multiple of sizeof (EMACS_INT); it need not be, if
299 alignof(EMACS_INT) < sizeof (EMACS_INT).
d0f4e1f5 300 (check_sblock, check_string_bytes, check_string_free_list): Protoize.
0b432f21 301
895009e1
JB
3022011-04-26 Juanma Barranquero <lekktu@gmail.com>
303
304 * keyboard.c (QCrtl): Rename from Qrtl. All uses changed.
305
6a7a1b0b
TZ
3062011-04-26 Teodor Zlatanov <tzz@lifelogs.com>
307
308 * gnutls.c (emacs_gnutls_handshake): Return an error if we're not
b5f869a7 309 supposed to be handshaking. (Bug#8556)
6a7a1b0b
TZ
310 Reported by Paul Eggert <eggert@cs.ucla.edu>.
311
841a1577 3122011-04-26 Daniel Colascione <dan.colascione@gmail.com>
0438ce91
DC
313
314 * lisp.h (Qdebug): List symbol.
895009e1 315 * eval.c (Qdebug): Restore global linkage.
0438ce91
DC
316 * keyboard.c (debug-on-event): New variable.
317 (handle_user_signal): Break into debugger when debug-on-event
318 matches the current signal symbol.
319
f2d3ba6f
DN
3202011-04-25 Dan Nicolaescu <dann@ics.uci.edu>
321
322 * alloc.c (check_sblock, check_string_bytes)
323 (check_string_free_list): Convert to standard C.
324
42ce4c63
TZ
3252011-04-25 Teodor Zlatanov <tzz@lifelogs.com>
326
327 * w32.c (emacs_gnutls_push): Fix typo.
328
825cd63c
EZ
3292011-04-25 Eli Zaretskii <eliz@gnu.org>
330
fb11d64d
EZ
331 * gnutls.c (emacs_gnutls_handshake): Avoid compiler warnings about
332 "cast to pointer from integer of different size".
333
825cd63c
EZ
334 Improve doprnt and its use in verror. (Bug#8545)
335 * doprnt.c (doprnt): Document the set of format control sequences
336 supported by the function. Use SAFE_ALLOCA instead of always
337 using `alloca'.
338
339 * eval.c (verror): Don't limit the buffer size at size_max-1, that
340 is one byte too soon. Don't use xrealloc; instead xfree and
341 xmalloc anew.
342
e061a11b
TZ
3432011-04-24 Teodor Zlatanov <tzz@lifelogs.com>
344
345 * gnutls.h: Add GNUTLS_STAGE_CALLBACKS enum to denote we're in the
346 callbacks stage.
347
348 * gnutls.c: Renamed global_initialized to
349 gnutls_global_initialized. Added internals for the
350 :verify-hostname-error, :verify-error, and :verify-flags
351 parameters of `gnutls-boot' and documented those parameters in the
352 docstring. Start callback support.
353 (emacs_gnutls_handshake): Add Woe32 support. Retry handshake
354 unless a fatal error occured. Call gnutls_alert_send_appropriate
355 on error. Return error code.
356 (emacs_gnutls_write): Call emacs_gnutls_handle_error.
357 (emacs_gnutls_read): Likewise.
358 (Fgnutls_boot): Return handshake error code.
359 (emacs_gnutls_handle_error): New function.
360 (wsaerror_to_errno): Likewise.
361
362 * w32.h (emacs_gnutls_pull): Add prototype.
363 (emacs_gnutls_push): Likewise.
364
365 * w32.c (emacs_gnutls_pull): New function for GnuTLS on Woe32.
366 (emacs_gnutls_push): Likewise.
367
3682011-04-24 Claudio Bley <claudio.bley@gmail.com> (tiny change)
369
370 * process.c (wait_reading_process_output): Check if GnuTLS
371 buffered some data internally if no FDs are set for TLS
372 connections.
373
374 * makefile.w32-in (OBJ2): Add gnutls.$(O).
375 (LIBS): Link to USER_LIBS.
376 ($(BLD)/gnutls.$(0)): New target.
377
fa6996bc
EZ
3782011-04-24 Eli Zaretskii <eliz@gnu.org>
379
eb35682e
EZ
380 * xdisp.c (handle_single_display_spec): Rename the
381 display_replaced_before_p argument into display_replaced_p, to
382 make it consistent with the commentary. Fix typos in the
383 commentary.
384
e2ad650c
EZ
385 * textprop.c (syms_of_textprop): Remove dead code.
386 (copy_text_properties): Delete obsolete commentary about an
387 interface that was deleted long ago. Fix typos in the description
388 of arguments.
389
1b2de274
EZ
390 * msdos.c (XMenuActivate, XMenuAddSelection): Adjust argument list
391 to changes in oldXMenu/XMenu.h from 2011-04-16.
392 <menu_help_message, prev_menu_help_message>: Constify.
393 (IT_menu_make_room): menu->help_text is now `const char **';
394 adjust.
395
396 * msdos.h (XMenuActivate, XMenuAddSelection): Adjust prototypes
397 to changes in oldXMenu/XMenu.h from 2011-04-16.
398 (struct XMenu): Declare `help_text' `const char **'.
399
400 * xfaces.c <Qunspecified>: Make extern again.
401
402 * syntax.c: Include sys/types.h before including regex.h, as
403 required by Posix.
404
762b15be
EZ
405 * doc.c (get_doc_string): Improve the format passed to `error'.
406
407 * doprnt.c (doprnt): Improve commentary.
408
409 * term.c (init_tty) [MSDOS]: Fix 1st argument to maybe_fatal.
410
411 * Makefile.in (TAGS): Depend on $(M_FILE) and $(S_FILE), and scan
412 them with etags.
413
f1052e5d
EZ
414 * makefile.w32-in (globals.h): Add a dummy recipe, to make any
415 changes in globals.h immediately force recompilation.
762b15be
EZ
416 (TAGS): Depend on $(CURDIR)/m/intel386.h and
417 $(CURDIR)/s/ms-w32.h.
418 (TAGS-gmake): Scan $(CURDIR)/m/intel386.h and $(CURDIR)/s/ms-w32.h.
f1052e5d 419
fa6996bc
EZ
420 * character.c (Fchar_direction): Function deleted.
421 (syms_of_character): Don't defsubr it.
422 <char-direction-table>: Deleted.
423
e6c3da20
EZ
4242011-04-23 Eli Zaretskii <eliz@gnu.org>
425
426 Fix doprnt so it could be used again safely in `verror'. (Bug#8435)
427 * doprnt.c: Include limits.h.
428 (SIZE_MAX): New macro.
429 (doprnt): Return a size_t value. 2nd arg is now size_t. Many
430 local variables are now size_t instead of int or unsigned.
431 Improve overflow protection. Support `l' modifier for integer
432 conversions. Support %l conversion. Don't assume an EMACS_INT
433 argument for integer conversions and for %c.
434
435 * lisp.h (doprnt): Restore prototype.
436
437 * makefile.w32-in ($(BLD)/callint.$(O)): Depend on
438 $(SRC)/character.h.
439
440 * Makefile.in (base_obj): Add back doprnt.o.
441
442 * deps.mk (doprnt.o): Add back prerequisites.
443 (callint.o): Depend on character.h.
444
445 * eval.c (internal_lisp_condition_case): Include the handler
446 representation in the error message.
447 (verror): Call doprnt instead of vsnprintf. Fix an off-by-one bug
448 when breaking from the loop.
449
450 * xdisp.c (vmessage): Call doprnt instead of vsnprintf.
451
452 * callint.c (Fcall_interactively): When displaying error message
453 about invalid control letter, pass the character's codepoint, not
454 a pointer to its multibyte form. Improve display of the character
455 in octal and display also its hex code.
456
457 * character.c (char_string): Use %x to display the (unsigned)
458 codepoint of an invalid character, to avoid displaying a bogus
459 negative value.
460
461 * font.c (check_otf_features): Pass SDATA of SYMBOL_NAME to
462 `error', not SYMBOL_NAME itself.
463
464 * coding.c (Fencode_sjis_char, Fencode_big5_char): Use %c for
465 character arguments to `error'.
466
467 * charset.c (check_iso_charset_parameter): Fix incorrect argument
468 to `error' in error message about FINAL_CHAR argument. Make sure
469 FINAL_CHAR is a character, and use %c when it is passed as
470 argument to `error'.
471
4ffd0d6b 4722011-04-23 Eli Zaretskii <eliz@gnu.org>
97a93095
EZ
473
474 * s/ms-w32.h (localtime): Redirect to sys_localtime.
475
476 * w32.c: Include <time.h>.
477 (sys_localtime): New function.
478
4ffd0d6b 4792011-04-23 Chong Yidong <cyd@stupidchicken.com>
c17819f4
CY
480
481 * xdisp.c (init_xdisp): Initialize echo_area_window (Bug#6451).
482
4ffd0d6b 483 * buffer.c (syms_of_buffer): Doc fix (Bug#6902).
aac0c6e3 484
4ffd0d6b 4852011-04-23 Samuel Thibault <sthibault@debian.org> (tiny change)
aac0c6e3 486
4ffd0d6b
GM
487 * sysdep.c (wait_for_termination): On GNU Hurd, kill returns -1 on
488 zombies (Bug#8467).
aac0c6e3 489
04c56954
EZ
4902011-04-19 Eli Zaretskii <eliz@gnu.org>
491
492 * syntax.h (SETUP_SYNTAX_TABLE_FOR_OBJECT): Fix setting of
493 gl_state.e_property when gl_state.object is Qt.
494
495 * insdel.c (make_gap_larger): Remove limitation of buffer size
496 to <= INT_MAX.
497
16a43933
CY
4982011-04-18 Chong Yidong <cyd@stupidchicken.com>
499
500 * xdisp.c (lookup_glyphless_char_display)
501 (produce_glyphless_glyph): Handle cons cell entry in
502 glyphless-char-display.
503 (Vglyphless_char_display): Document it.
504
505 * term.c (produce_glyphless_glyph): Handle cons cell entry in
506 glyphless-char-display.
507
4581706e
CY
5082011-04-17 Chong Yidong <cyd@stupidchicken.com>
509
510 * xdisp.c (get_next_display_element): Remove unnecessary ifdefs.
511
512 * termhooks.h (FRAME_WINDOW_P): Remove duplicated definitions.
513
514 * dispextern.h (FACE_SUITABLE_FOR_ASCII_CHAR_P): Add missing
515 definition for no-X builds.
516
4887c6e2 5172011-04-16 Paul Eggert <eggert@cs.ucla.edu>
764430a3 518
fd35b6f9
PE
519 Static checks with GCC 4.6.0 and non-default toolkits.
520
5c1ccb01
PE
521 * s/sol2-6.h, s/unixware.h (PTY_TTY_NAME_SPRINTF): Protoize decl.
522
006c5daa
PE
523 * process.c (keyboard_bit_set): Define only if SIGIO.
524 (send_process_trap): Mark it with NO_RETURN if it doesn't return.
525 (send_process): Repair possible setjmp clobbering.
526
efc736d3
PE
527 * s/usg5-4-common.h (SETUP_SLAVE_PTY): Don't pass extra arg to 'fatal'.
528
4e2fe2e6
PE
529 * eval.c: Include <stdio.h>, for vsnprintf on non-GNU/Linux hosts.
530
f97334a2
PE
531 * data.c (arith_error): Mark with NO_RETURN if it doesn't return.
532
4e75f29d
PE
533 * alloc.c (bytes_used_when_full, SPARE_MEMORY, BYTES_USED):
534 Define only if needed.
535
90efadd1
PE
536 * sysdep.c (_FILE_OFFSET_BITS): Make this hack even uglier
537 by pacifying GCC about it. Maybe it's time to retire it?
875975e9 538 * xfaces.c (USG, __TIMEVAL__): Likewise.
90efadd1 539
3c647824
PE
540 * dispextern.h (struct redisplay_interface): Rename param
541 to avoid shadowing.
e264f262 542 * termhooks.h (struct terminal): Likewise.
761383f4 543 * xterm.c (xembed_send_message): Likewise.
3c647824 544
b58c5c4a
PE
545 * insdel.c (make_gap_smaller): Define only if
546 USE_MMAP_FOR_BUFFERS || REL_ALLOC || DOUG_LEA_MALLOC.
547
cad59032
PE
548 * keyboard.c (read_char): Make a var volatile so longjmp won't clobber
549 it.
550
c339dc2e
PE
551 * emacs.c (MAX_HEAP_BSS_DIFF, my_edata): Move to where they're used,
552 so that we aren't warned about unused symbols.
553
91a3e27b
PE
554 * xfns.c (Fx_file_dialog): Rename local to avoid shadowing.
555
399c71d3 556 * xdisp.c (x_produce_glyphs): Mark var as initialized (Bug#8512).
7a3fb125 557
8ffc96f5
PE
558 * xfns.c (x_real_positions): Mark locals as initialized.
559
eef9bc79
PE
560 * xmenu.c (xmenu_show): Don't use uninitialized vars.
561
098db9dd
PE
562 * xterm.c: Fix problems found by static analysis with other toolkits.
563 (toolkit_scroll_bar_interaction): Define and use only if USE_X_TOOLKIT.
dda3aedd
PE
564 (x_dispatch_event): Declare static if USE_GTK, and
565 define if USE_GTK || USE_X_TOOLKIT.
098db9dd 566 (SET_SAVED_BUTTON_EVENT): Define only if USE_X_TOOLKIT || USE_GTK.
dda3aedd 567 * xterm.h (x_dispatch_event): Extern only if USE_X_TOOLKIT.
841a1577
JB
568 * xterm.c, xterm.h (x_mouse_leave): Bring this function back, but only
569 if defined HAVE_MENUS && !defined USE_X_TOOLKIT && !defined USE_GTK.
098db9dd 570
eb18f6cc
PE
571 * xmenu.c (menu_help_callback): Pointer type fixes.
572 Use const pointers when pointing at readonly data. Avoid pointer
573 signedness clashes.
574 (FALSE): Remove unused macro.
575 (update_frame_menubar): Remove unused decl.
576
1fe72bf8
PE
577 * xfns.c (Fx_hide_tip): Move locals to avoid shadowing.
578
60d9e1db
PE
579 * menu.c (push_submenu_start, push_submenu_end): Do not define unless
580 USE_X_TOOLKIT || USE_GTK || HAVE_NS || defined HAVE_NTGUI.
581 (single_menu_item): Rename local to avoid shadowing.
582
39261c26
PE
583 * keyboard.c (make_lispy_event): Remove unused local var.
584
018c5e19
PE
585 * frame.c, frame.h (x_get_resource_string): Bring this back, but
586 only if HAVE_X_WINDOWS && !USE_X_TOOLKIT.
587
63d2b86e
PE
588 * bitmaps: Change bitmaps from unsigned char back to the X11
589 compatible char. Avoid the old compiler warnings about
590 out-of-range initializers by using, for example, '\xab' rather
591 than 0xab.
592
aefd87e1
PE
593 * xgselect.c (xgselect_initialize): Check vs interface
594 even if ! (defined (USE_GTK) || defined (HAVE_GCONF)).
595
bf501fb9
PE
596 * xmenu.c (xmenu_show): Rename parm to avoid shadowing.
597
e9829fdf
PE
598 * xterm.c (x_create_toolkit_scroll_bar): Use const * for pointers
599 to read-only memory.
600
1086c095
PE
601 * fns.c (vector): Remove; this old hack is no longer needed.
602
2baccd04 603 * xsmfns.c (create_client_leader_window): Rename shadowing arg.
401f10cb 604 Remove unused var.
dde42981 605 (gdk_x11_set_sm_client_id) [!USE_GTK]: Don't define.
2baccd04 606
72391843 607 * xrdb.c (x_load_resources): Omit unused local.
3565b346 608
436c16df 609 * xfns.c (free_frame_menubar, atof): Remove duplicate decls.
8a94ea33 610 (x_window): Rename locals to avoid shadowing.
dc5ddd85 611 (USG): Use the kludged USG macro, to pacify gcc.
436c16df 612
92bb796d 613 * xterm.c (x_alloc_nearest_color_for_widget): Remove; unused.
bbbef9e1 614 (x_term_init): Remove local to avoid shadowing.
92bb796d 615
764430a3 616 * xfns.c, xterm.c (_XEditResCheckMessages): Protoize decl.
4887c6e2
PE
617
618 * xdisp.c, dispextern.h (set_vertical_scroll_bar): Now extern if
619 USE_TOOLKIT_SCROLL_BARS && !USE_GTK, as xterm.c needs it then.
620
d1dfb56c
EZ
6212011-04-16 Eli Zaretskii <eliz@gnu.org>
622
c4354cb4
EZ
623 * gnutls.c (Fgnutls_boot): Don't pass Lisp_Object to `error'.
624
d1dfb56c
EZ
625 Fix regex.c, syntax.c and friends for buffers > 2GB.
626 * syntax.h (struct gl_state_s): Declare character position members
627 EMACS_INT.
628
629 * syntax.c (update_syntax_table): Declare 2nd argument EMACS_INT.
630
631 * textprop.c (verify_interval_modification, interval_of): Declare
632 arguments EMACS_INT.
633
634 * intervals.c (adjust_intervals_for_insertion): Declare arguments
635 EMACS_INT.
636
637 * intervals.h (CHECK_TOTAL_LENGTH): Cast to EMACS_INT, not `int'.
638
639 * indent.c (Fvertical_motion): Local variable it_start is now
640 EMACS_INT.
641
642 * regex.c (re_match, re_match_2, re_match_2_internal)
643 (bcmp_translate, regcomp, regexec, print_double_string)
644 (group_in_compile_stack, re_search, re_search_2, regex_compile)
645 (re_compile_pattern, re_exec): Declare arguments and local
646 variables `size_t' and `ssize_t' and return values `regoff_t', as
647 appropriate.
648 (POP_FAILURE_REG_OR_COUNT) <pfreg>: Declare `long'.
649 (CHECK_INFINITE_LOOP) <failure>: Declare `ssize_t'.
650 <compile_stack_type>: `size' and `avail' are now `size_t'.
651
652 * regex.h <regoff_t>: Use ssize_t, not int.
653 (re_search, re_search_2, re_match, re_match_2): Arguments that
654 specify buffer/string position and length are now ssize_t and
655 size_t. Return type is regoff_t.
656
613052cd
BK
6572011-04-16 Ben Key <bkey76@gmail.com>
658
659 * nsfont.m: Fixed bugs in ns_get_family and
660 ns_descriptor_to_entity that were caused by using free to
661 deallocate memory blocks that were allocated by xmalloc (via
662 xstrdup). This caused Emacs to crash when compiled with
663 XMALLOC_OVERRUN_CHECK defined (when Emacs was configured with
664 --enable-checking=xmallocoverrun). xfree is now used to
665 deallocate these memory blocks.
666
4170f62f 6672011-04-15 Paul Eggert <eggert@cs.ucla.edu>
3e047f51 668
71b41406
PE
669 * sysdep.c (emacs_read): Remove unnecessary check vs MAX_RW_COUNT.
670
9587a89d
PE
671 emacs_write: Accept and return EMACS_INT for sizes.
672 See http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00514.html
673 et seq.
674 * gnutls.c, gnutls.h (emacs_gnutls_read, emacs_gnutls_write):
675 Accept and return EMACS_INT.
676 (emacs_gnutls_write): Return the number of bytes written on
677 partial writes.
678 * sysdep.c, lisp.h (emacs_read, emacs_write): Likewise.
273a5f82
PE
679 (emacs_read, emacs_write): Remove check for negative size, as the
680 Emacs source code has been audited now.
9587a89d
PE
681 * sysdep.c (MAX_RW_COUNT): New macro, to work around kernel bugs.
682 (emacs_read, emacs_write): Use it.
273a5f82
PE
683 * process.c (send_process): Adjust to the new signatures of
684 emacs_write and emacs_gnutls_write. Do not attempt to store
685 a byte offset into an 'int'; it might overflow.
9587a89d 686 See http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00483.html
273a5f82 687
3e047f51
PE
688 * sound.c: Don't assume sizes fit in 'int'.
689 (struct sound_device.period_size, alsa_period_size):
9c3c56a7 690 Return EMACS_INT, not int.
3e047f51 691 (struct sound_device.write, vox_write, alsa_write):
9c3c56a7
PE
692 Accept EMACS_INT, not int.
693 (wav_play, au_play): Use EMACS_INT to store sizes and to
3e047f51
PE
694 record read return values.
695
cc39a9db
BK
6962011-04-15 Ben Key <bkey76@gmail.com>
697
c9d0ec6d
JB
698 * keyboard.c (Qundefined): Don't declare static since it is used
699 in nsfns.m.
700 * xfaces.c (Qbold, Qexpanded, Qitalic, Qcondensed): Don't declare
701 static since they are used in nsfont.m.
cc39a9db 702
6c60eb9f
SM
7032011-04-15 Stefan Monnier <monnier@iro.umontreal.ca>
704
705 * process.c (Qprocessp): Don't declare static.
706 * lisp.h (Qprocessp): Declare again.
707
7990b61a
JB
7082011-04-15 Juanma Barranquero <lekktu@gmail.com>
709
710 * font.c (Qopentype): Don't make static (used from w32uniscribe.c).
711
5d4cb038
PE
7122011-04-14 Paul Eggert <eggert@cs.ucla.edu>
713
8bd7b830 714 Improve C-level modularity by making more things 'static'.
cd64ea1d 715
e3b27b31
PE
716 Don't publish debugger-only interfaces to other modules.
717 * lisp.h (safe_debug_print, debug_output_compilation_hack):
718 (verify_bytepos, count_markers): Move decls to the only modules
719 that need them.
720 * region-cache.h (pp_cache): Likewise.
721 * window.h (check_all_windows): Likewise.
722 * marker.c, print.c, region-cache.c, window.c: Decls moved here.
723
5d4cb038
PE
724 * sysdep.c (croak): Now static, if
725 defined TIOCNOTTY || defined USG5 || defined CYGWIN.
726 * syssignal.h (croak): Declare only if not static.
69003fd8
PE
727
728 * alloc.c (refill_memory_reserve): Now static if
729 !defined REL_ALLOC || defined SYSTEM_MALLOC.
730 * lisp.h (refill_memory_reserve): Declare only if not static.
93ea6e8f 731
e87b6180
PE
732 * xsettings.c, xsettings.h (xsettings_get_system_normal_font):
733 Define only if USE_LUCID.
734
ac64929e
PE
735 * xrdb.c (x_customization_string, x_rm_string): Now static.
736
6f37259d
PE
737 * xmenu.c (x_menu_wait_for_event): Export only if USE_MOTIF.
738 * xterm.h (x_menu_wait_for_event): Declare only if USE_MOTIF.
739
1683e3ab
PE
740 * xdisp.c (draw_row_with_mouse_face): Now static.
741 * dispextern.h (draw_row_with_mouse_fave): Remove decl.
742
de9c2632
PE
743 * window.h (check_all_windows): Mark externally visible.
744
2b96acb7
PE
745 * window.c (window_deletion_count): Now static.
746
747 * undo.c: Make symbols static if they're not exported.
748 (last_undo_buffer, last_boundary_position, pending_boundary):
749 Now static.
750
50436f33
PE
751 * textprop.c (interval_insert_behind_hooks): Now static.
752 (interval_insert_in_front_hooks): Likewise.
753
64520e5c
PE
754 * term.c: Make symbols static if they're not exported.
755 (tty_turn_off_highlight, get_tty_terminal, max_frame_cols):
756 (max_frame_lines, tty_set_terminal_modes):
757 (tty_reset_terminal_modes, tty_turn_off_highlight):
758 (get_tty_terminal): Now static.
759 (term_mouse_moveto): Do not define if HAVE_WINDOW_SYSTEM.
760 * termhooks.h (term_mouse_moveto): Do not declare if
8bd7b830 761 HAVE_WINDOW_SYSTEM.
64520e5c
PE
762 * dispextern.h (tty_set_terminal_modes, tty_reset_terminal_modes):
763 (tty_turn_off_highlight, get_tty_terminal): Remove decls.
764
1fa53021
PE
765 * sysdep.c: Make symbols static if they're not exported.
766 (emacs_get_tty, emacs_set_tty, old_fcntl_flags, old_fcntl_owner):
767 Now static.
768 (sigprocmask_set, full_mask): Remove; unused.
769 (wait_debugging): Mark as visible.
770 * syssignal.h (SIGFULLMASK, full_mask): Remove decls.
771 * systty.h (emacs_get_tty, emacs_set_tty): Remove decls.
772
d4b43b22
PE
773 * syntax.c (syntax_temp): Define only if !__GNUC__.
774
b7c513d0
PE
775 * sound.c (current_sound_device, current_sound): Now static.
776
989b29ad
PE
777 * search.c (searchbufs, searchbuf_head): Now static.
778
13a55a78
PE
779 * scroll.c (scroll_cost): Remove; unused.
780 * dispextern.h (scroll_cost): Remove decl.
781
de68a1fc
PE
782 * region-cache.h (pp_cache): Mark as externally visible.
783
40ccffa6
PE
784 * process.c: Make symbols static if they're not exported.
785 (process_tick, update_tick, create_process, chan_process):
786 (Vprocess_alist, proc_buffered_char, datagram_access):
787 (fd_callback_data, send_process_frame, process_sent_to): Now static.
788 (deactivate_process): Mark defn as static, as well as decl.
789 * lisp.h (create_process): Remove decl.
790 * process.h (chan_process, Vprocess_alist): Remove decls.
791
ad64fc97
PE
792 * print.c: Make symbols static if they're not exported.
793 (print_depth, new_backquote_output, being_printed, print_buffer):
794 (print_buffer_size, print_buffer_pos, print_buffer_pos_byte):
795 (print_interval, print_number_index, initial_stderr_stream):
796 Now static.
797 * lisp.h (Fprinc): Remove decl.
798 (debug_output_compilation_hack): Mark as externally visible.
799
adddb265
PE
800 * sysdep.c (croak): Move decl from here to syssignal.h.
801 * syssignal.h (croak): Put it here, so the API can be checked when
802 'croak' is called from dissociate_if_controlling_tty.
803
1717ede2
PE
804 * minibuf.c: Make symbols static if they're not exported.
805 (minibuf_save_list, choose_minibuf_frame): Now static.
806 * lisp.h (choose_minibuf_frame): Remove decl.
807
fa5fb2bc
PE
808 * lisp.h (verify_bytepos, count_markers): Mark as externally visible.
809
1e3890d1
PE
810 * lread.c: Make symbols static if they're not exported.
811 (read_objects, initial_obarray, oblookup_last_bucket_number):
812 Now static.
813 (make_symbol): Remove; unused.
814 * lisp.h (initial_obarray, make_symbol): Remove decls.
815
8a1414fa
PE
816 * keyboard.c: Make symbols static if they're not exported.
817 (single_kboard, recent_keys_index, total_keys, recent_keys):
818 (this_command_key_count_reset, raw_keybuf, raw_keybuf_count):
819 (this_single_command_key_start, echoing, last_auto_save):
820 (read_key_sequence_cmd, dribble, recursive_edit_unwind):
821 (command_loop, echo_now, keyboard_init_hook, help_char_p):
822 (quit_throw_to_read_char, command_loop_2, top_level_1, poll_timer):
823 (Vlispy_mouse_stem, double_click_count):
824 Now static.
825 (force_auto_save_soon): Define only if SIGDANGER.
826 (ignore_mouse_drag_p): Now static if
827 !defined HAVE_WINDOW_SYSTEM || defined USE_GTK || defined HAVE_NS.
828 (print_help): Remove; unused.
829 (stop_character, last_timer_event): Mark as externally visible.
830 * keyboard.h (ignore_mouse_drag_p): Declare only if
831 defined HAVE_WINDOW_SYSTEM && !defined USE_GTK && !defined HAVE_NS.
832 (echo_now, help_char_p, quit_throw_to_read_char): Remove decls.
833 * lisp.h (echoing): Remove decl.
834 (force_auto_save_soon): Declare only if SIGDANGER.
835 * xdisp.c (redisplay_window): Simplify code, to make it more
836 obvious that ignore_mouse_drag_p is not accessed if !defined
837 USE_GTK && !defined HAVE_NS.
838
93ea6e8f
PE
839 * intervals.c: Make symbols static if they're not exported.
840 (merge_properties_sticky, merge_interval_right, delete_interval):
841 Now static.
842 * intervals.h (merge_interval_right, delete_interval): Remove decls.
843
77382fcc
PE
844 * insdel.c: Make symbols static if they're not exported.
845 However, leave prepare_to_modify_buffer alone. It's never
846 called from outside this function, but that appears to be a bug.
847 (combine_after_change_list, combine_after_change_buffer):
4889fc82 848 (adjust_after_replace, signal_before_change): Now static.
77382fcc
PE
849 (adjust_after_replace_noundo): Remove; unused.
850 * lisp.h (adjust_after_replace, adjust_after_replace_noundo):
4889fc82 851 (signal_before_change): Remove decls.
77382fcc 852
9306c32e
PE
853 * indent.c (val_compute_motion, val_vmotion): Now static.
854
cd44d2eb
PE
855 * image.c: Make symbols static if they're not exported.
856 * dispextern.h (x_create_bitmap_from_xpm_data): Do not declare
857 if USE_GTK.
858 * image.c (x_create_bitmap_from_xpm_data): Do not define if USE_GTK.
859 (xpm_color_cache, ct_table, ct_colors_allocated): Now static.
860
ad9a7a06
PE
861 * fringe.c (standard_bitmaps): Now static.
862 (max_used_fringe_bitmap): Now static, unless HAVE_NS.
863
81626931
PE
864 * frame.c: Make symbols static if they're not exported.
865 (x_report_frame_params, make_terminal_frame): Now static.
866 (get_frame_param): Now static, unless HAVE_NS.
867 (x_fullscreen_adjust): Define if WINDOWSNT, not if HAVE_WINDOW_SYSTEM.
868 (x_get_resource_string): Remove; not used.
869 * frame.h (make_terminal_frame, x_report_frame_params):
870 (x_get_resource_string); Remove decls.
871 (x_fullscreen_adjust): Declare only if WINDOWSNT.
872 * lisp.h (get_frame_param): Declare only if HAVE_NS.
873
239f9db9
PE
874 * font.c, fontset.c: Make symbols static if they're not exported.
875 * dispextern.h (FACE_SUITABLE_FOR_ASCII_CHAR_P): New macro.
876 (FACE_SUITABLE_FOR_CHAR_P): Use it.
877 * font.c (font_close_object): Now static.
878 * font.h (font_close_object): Remove.
879 * fontset.c (FONTSET_OBJLIST): Remove.
880 (free_realized_fontset) #if-0 the body, which does nothing.
881 (face_suitable_for_char_p): #if-0, as it's never called.
882 * fontset.h (face_suitable_for_char_p): Remove decl.
883 * xfaces.c (face_at_string_position): Use
884 FACE_SUITABLE_FOR_ASCII_CHAR_P, not FACE_SUITABLE_FOR_CHAR_P,
885 since 0 is always ASCII.
886
dfcf3579
PE
887 * fns.c (weak_hash_tables): Now static.
888
5045092b
PE
889 * fileio.c: Make symbols static if they're not exported.
890 (auto_saving, auto_save_mode_bits, auto_save_error_occurred):
891 (Vwrite_region_annotation_buffers): Now static.
892
57a96f5c
PE
893 * eval.c: Make symbols static if they're not exported.
894 (backtrace_list, lisp_eval_depth, when_entered_debugger): Now static.
895 * lisp.h (backtrace_list): Remove decl.
896
35f08c38
PE
897 * emacs.c: Make symbols static if they're not exported.
898 (malloc_state_ptr, malloc_using_checking, syms_of_emacs):
899 (fatal_error_code, fatal_error_signal_hook, standard_args):
900 Now static.
901 (fatal_error_signal): Now static, unless FLOAT_CATCH_SIGKILL.
902 (DEFINE_DUMMY_FUNCTION): Mark function as externally visible.
903 (__CTOR_LIST__, __DTOR_LIST__): Now externally visible.
904 * lisp.h (fatal_error_signal_hook): Remove decl.
905 (fatal_error_signal): Declare only if FLOAT_CATCH_SIGKILL.
906
f44bd759
PE
907 * editfns.c: Move a (normally-unused) function to its only use.
908 * editfns.c, lisp.h (get_operating_system_release): Remove.
909 * process.c (init_process) [DARWIN_OS]: Do it inline, as it is not
910 worth the hassle of breaking this out.
911
b532497d
PE
912 * xterm.c: Make symbols static if they're not exported.
913 (x_raise_frame, x_lower_frame, x_wm_set_window_state):
914 (x_wm_set_icon_pixmap, x_initialize, XTread_socket_fake_io_error):
915 (x_destroy_window, x_delete_display):
916 Now static.
917 (x_dispatch_event): Now static if ! (USE_MOTIF || USE_X_TOOLKIT).
918 (x_mouse_leave): Remove; unused.
919 * xterm.h (x_display_info_for_name, x_raise_frame, x_lower_frame):
920 (x_destroy_window, x_wm_set_window_state, x_wm_set_icon_pixmap):
921 (x_delete_display, x_initialize, x_set_border_pixel, x_screen_planes):
922 Remove decls.
923 (x_mouse_leave): Declare only if WINDOWSNT.
924 (x_dispatch_event): Declare only if USE_MOTIF or USE_X_TOOLKIT.
925 (xic_create_fontsetname): Declare only if HAVE_X_WINDOWS &&
926 USE_X_TOOLKIT.
927
1675728f
PE
928 * ftxfont.c: Make symbols static if they're not exported.
929 (ftxfont_driver): Export only if !defined HAVE_XFT && def8ined
930 HAVE_FREETYPE.
931 * font.h (ftxfont_driver): Likewise.
932
e4cebfca
PE
933 * xfns.c: Make symbols static if they're not exported.
934 (x_last_font_name, x_display_info_for_name):
935 (x_set_foreground_color, x_set_background_color, x_set_mouse_color):
936 (x_set_cursor_color, x_set_border_pixel, x_set_border_color):
937 (x_set_cursor_type, x_set_icon_type, x_set_icon_name):
938 (x_set_scroll_bar_foreground, x_set_scroll_bar_background):
939 (x_explicitly_set_name, x_set_title, xic_defaut_fontset, tip_timer):
940 (last_show_tip_args): Now static.
941 (xic_defaut_fontset, xic_create_fontsetname): Define only if
942 defined HAVE_X_WINDOWS && defined USE_X_TOOLKIT
943 (x_screen_planes): Remove; unused.
944 * dispextern.h (x_screen_planes): Remove decl.
945
5bf46f05
PE
946 * dispnew.c: Make symbols static if they're not exported.
947 * dispextern.h (redraw_garbaged_frames, scrolling):
948 (increment_row_positions): Remove.
949 * dispnew.c (new_glyph_matrix, increment_row_positions, scrolling):
950 (delayed_size_change, glyph_matrix_count, glyph_pool_count):
951 Now static.
952 (redraw_garbaged_frames): Remove; unused.
953
435f4c28
PE
954 * xfaces.c: Make symbols static if they're not exported.
955 * dispextern.h (ascii_face_of_lisp_face, free_realized_face):
956 Remove decls.
957 * xterm.h (defined_color): Remove decls.
958 (x_free_dpy_colors): Declare only if USE_X_TOOLKIT.
959 * xfaces.c (tty_suppress_bold_inverse_default_colors_p):
960 (menu_face_changed_default, defined_color, free_realized_face):
961 (x_free_dpy_colors): Define only if USE_X_TOOLKIT.
962 (ascii_face_of_lisp_face): Remove; unused.
963
8524aef3
PE
964 * xdisp.c: Make symbols static if they're not exported.
965 * dispextern.h (scratch_glyph_row, window_box_edges):
966 (glyph_to_pixel_coords, set_cursor_from_row):
967 (get_next_display_element, set_iterator_to_next):
968 (highlight_trailing_whitespace, frame_to_window_pixel_xy):
969 (show_mouse_face): Remove decls
970 * frame.h (message_buf_print): Likewise.
971 * lisp.h (pop_message, set_message, check_point_in_composition):
972 Likewise.
973 * xterm.h (set_vertical_scroll_bar): Likewise.
974 * xdisp.c (list_of_error, Vmessage_stack, line_number_displayed):
975 (message_buf_print, scratch_glyph_row, displayed_buffer):
976 (set_iterator_to_next, pop_message, set_message, set_cursor_from_row):
977 (get_next_display_element, show_mouse_face, window_box_edges):
978 (frame_to_window_pixel_xy, check_point_in_composition):
979 (set_vertical_scroll_bar, highlight_trailing_whitespace): Now static.
980 (glyph_to_pixel_coords): Remove; unused.
981
16390cd2
PE
982 * dired.c (file_name_completion): Now static.
983
984 * dbusbind.c (xd_in_read_queued_messages): Now static.
985
a25f4dfa
PE
986 * lisp.h (circular_list_error, FOREACH): Remove; unused.
987 * data.c (circular_list_error): Remove.
988
14a9c8df
PE
989 * commands.h (last_point_position, last_point_position_buffer):
990 (last_point_position_window): Remove decls.
991 * keyboard.c: Make these variables static.
992
74ab6df5
PE
993 * coding.h (coding, code_convert_region, encode_coding_gap): Remove
994 decls.
995 * coding.c (Vsjis_coding_system, Vbig5_coding_system):
996 (iso_code_class, detect_coding, code_convert_region): Now static.
997 (encode_coding_gap): Remove; unused.
998
38dfbee1
PE
999 * chartab.c (chartab_chars, chartab_bits): Now static.
1000
a2cb4e63
PE
1001 * charset.h (charset_iso_8859_1): Remove decl.
1002 * charset.c (charset_iso_8859_1, charset_emacs, map_charset_for_dump):
1003 Now static.
1004
127198fd
PE
1005 * ccl.h (check_ccl_update, Vccl_program_table): Remove decls.
1006 * ccl.c (Vccl_program_table): Now static.
1007 (check_ccl_update): Remove; unused.
1008
d85b608f
PE
1009 * category.c (SET_CATEGORY_SET, set_category_set): Move here.
1010 * category.h: ... from here.
1011 * category.c (check_category_table, set_category_set): Now static.
1012
31cd66f3
PE
1013 * casetab.c (Vascii_upcase_table, Vascii_eqv_table): Now static.
1014 * lisp.h: Remove these decls.
1015
c358e587
PE
1016 * buffer.c (buffer_count): Remove unused var.
1017
e78aecca
PE
1018 * bidi.c (bidi_dump_cached_states): Mark as externally visible,
1019 so that it's not optimized away.
1020 (bidi_ignore_explicit_marks_for_paragraph_level): Likewise.
1021 * dispextern.h (bidi_dump_cached_states): Remove, since it's
1022 exported only to the debugger.
1023
e192d7d3
PE
1024 * atimer.c (alarm_signal_handler, run_all_atimers): Now static.
1025 * atimer.h (run_all_atimers): Removed; not exported.
1026
92470028
PE
1027 font.c: Make copy_font_spec and merge_font_spec ordinary C functions.
1028 * font.c (copy_font_spec): Rename from Fcopy_font_spec, since it
1029 was inaccessible from Lisp.
1030 (merge_font_spec): Likewise, renaming from Fmerge_font_spec.
1031 * font.c, font.h, fontset.c, xfaces.c, xfont.c: Change all uses.
1032
244ed907
PE
1033 alloc.c: Import and export fewer symbols, and remove unused items.
1034 * lisp.h (suppress_checking, die): Declare only if ENABLE_CHECKING
1035 is defined.
1036 (suppress_checking): Add EXTERNALLY_VISIBLE attribute, so that
1037 it's not optimized away by whole-program optimization.
1038 (message_enable_multibyte, free_misc): Remove.
1039 (catchlist, handlerlist, mark_backtrace):
1040 Declare only if BYTE_MARK_STACK.
1041 (mark_byte_stack): Likewise, fixing a ifdef-vs-if typo.
1042 * alloc.c (pure): Export only if VIRT_ADDR_VARIES is defined.
1043 (message_enable_multibyte): Remove decl.
1044 (free_misc, interval_free_list, float_block, float_block_index):
1045 (n_float_blocks, float_free_list, cons_block, cons_block_index):
1046 (cons_free_list, last_marked_index):
1047 Now static.
1048 (suppress_checking, die): Define only if ENABLE_CHECKING is defined.
1049 * eval.c (catchlist, handlerlist): Export only if BYTE_MARK_STACK.
1050 (mark_backtrace): Define only if BYTE_MARK_STACK.
1051 * xdisp.c (message_enable_multibyte): Now static.
1052
61c2b50e 1053 Declare Lisp_Object Q* variables to be 'static' if not exported.
955cbe7b
PE
1054 This makes it easier for human readers (and static analyzers)
1055 to see whether these variables are used from other modules.
1056 * alloc.c, buffer.c, bytecode.c, callint.c, casetab.c, category.c:
1057 * ccl.c, character.c, charset.c, cmds.c, coding.c, composite.c:
1058 * data.c, dbusbind.c, dired.c, editfns.c, eval.c, fileio.c, fns.c:
1059 * font.c, frame.c, fringe.c, ftfont.c, image.c, keyboard.c, keymap.c:
1060 * lread.c, macros.c, minibuf.c, print.c, process.c, search.c:
1061 * sound.c, syntax.c, textprop.c, window.c, xdisp.c, xfaces.c, xfns.c:
1062 * xmenu.c, xselect.c:
1063 Declare Q* vars static if they are not used in other modules.
1064 * ccl.h, character.h, charset.h, coding.h, composite.h, font.h:
1065 * frame.h, intervals.h, keyboard.h, lisp.h, process.h, syntax.h:
1066 Remove decls of unexported vars.
1067 * keyboard.h (EVENT_HEAD_UNMODIFIED): Remove now-unused macro.
1068
95c82688
PE
1069 * lisp.h (DEFINE_FUNC): Make sname 'static'.
1070
16a97296
PE
1071 Make Emacs functions such as Fatom 'static' by default.
1072 This makes it easier for human readers (and static analyzers)
1073 to see whether these functions can be called from other modules.
1074 DEFUN now defines a static function. To make the function external
1075 so that it can be used in other C modules, use the new macro DEFUE.
8bd7b830
PE
1076 * lisp.h (Funibyte_char_to_multibyte, Fsyntax_table_p):
1077 (Finit_image_library):
16a97296
PE
1078 (Feval_region, Fbacktrace, Ffetch_bytecode, Fswitch_to_buffer):
1079 (Ffile_executable_p, Fmake_symbolic_link, Fcommand_execute):
1080 (Fget_process, Fdocumentation_property, Fbyte_code, Ffile_attributes):
1081 Remove decls, since these functions are now static.
1082 (Funintern, Fget_internal_run_time): New decls, since these functions
1083 were already external.
95c82688 1084
16a97296
PE
1085 * alloc.c, buffer.c, callint.c, callproc.c, casefiddle.c, casetab.c:
1086 * ccl.c, character.c, chartab.c, cmds.c, coding.c, data.c, dispnew.c:
1087 * doc.c, editfns.c, emacs.c, eval.c, fileio.c, filelock.c, floatfns.c:
1088 * fns.c, font.c, fontset.c, frame.c, image.c, indent.c:
1089 * keyboard.c, keymap.c, lread.c:
1090 * macros.c, marker.c, menu.c, minibuf.c, print.c, process.c, search.c:
1091 * syntax.c, term.c, terminal.c, textprop.c, undo.c:
1092 * window.c, xdisp.c, xfaces.c, xfns.c, xmenu.c, xsettings.c:
1093 Mark functions with DEFUE instead of DEFUN,
1094 if they are used in other modules.
1095 * buffer.c (Fset_buffer_major_mode, Fdelete_overlay): New forward
1096 decls for now-static functions.
1097 * buffer.h (Fdelete_overlay): Remove decl.
1098 * callproc.c (Fgetenv_internal): Mark as internal.
1099 * composite.c (Fremove_list_of_text_properties): Remove decl.
1100 (Fcomposition_get_gstring): New forward static decl.
1101 * composite.h (Fcomposite_get_gstring): Remove decl.
1102 * dired.c (Ffile_attributes): New forward static decl.
1103 * doc.c (Fdocumntation_property): New forward static decl.
1104 * eval.c (Ffetch_bytecode): New forward static decl.
1105 (Funintern): Remove extern decl; now in .h file where it belongs.
1106 * fileio.c (Fmake_symbolic_link): New forward static decl.
1107 * image.c (Finit_image_library): New forward static decl.
1108 * insdel.c (Fcombine_after_change_execute): Make forward decl static.
1109 * intervals.h (Fprevious_property_change):
1110 (Fremove_list_of_text_properties): Remove decls.
1111 * keyboard.c (Fthis_command_keys): Remove decl.
1112 (Fcommand_execute): New forward static decl.
1113 * keymap.c (Flookup_key): New forward static decl.
1114 (Fcopy_keymap): Now static.
1115 * keymap.h (Flookup_key): Remove decl.
1116 * process.c (Fget_process): New forward static decl.
1117 (Fprocess_datagram_address): Mark as internal.
1118 * syntax.c (Fsyntax_table_p): New forward static decl.
1119 (skip_chars): Remove duplicate decl.
1120 * textprop.c (Fprevious_property_change): New forward static decl.
1121 * window.c (Fset_window_fringes, Fset_window_scroll_bars):
1122 Now internal.
1123 (Fset_window_margins, Fset_window_vscroll): New forward static decls.
1124 * window.h (Fset_window_vscroll, Fset_window_margins): Remove decls.
1125
785bbd42
PE
1126 * editfns.c (Fformat): Remove unreachable code.
1127
8b913b57
AS
11282011-04-14 Andreas Schwab <schwab@linux-m68k.org>
1129
1130 * fileio.c (Finsert_file_contents): Fix typo in 2005-05-13
1131 change. (Bug#8496)
1132
a6744a35
EZ
11332011-04-13 Eli Zaretskii <eliz@gnu.org>
1134
1135 * xdisp.c (handle_invisible_prop): Don't call bidi_paragraph_init
1136 when at ZV. (Bug#8487)
1137
e7974947
AS
11382011-04-12 Andreas Schwab <schwab@linux-m68k.org>
1139
baad03f0
AS
1140 * charset.c (Fclear_charset_maps): Use xfree instead of free.
1141 (Bug#8437)
1142 * keyboard.c (parse_tool_bar_item): Likewise.
1143 * sound.c (sound_cleanup, alsa_close): Likewise.
1144 * termcap.c (tgetent): Likewise.
1145 * xfns.c (x_default_font_parameter): Likewise.
1146 * xsettings.c (read_and_apply_settings): Likewise.
1147
e7974947
AS
1148 * alloc.c (overrun_check_malloc, overrun_check_realloc)
1149 (overrun_check_free): Protoize.
1150
28272684
PE
11512011-04-12 Paul Eggert <eggert@cs.ucla.edu>
1152
1153 * sysdep.c (emacs_read, emacs_write): Check for negative sizes
1154 since callers should never pass a negative size.
1155 Change the signature to match that of plain 'read' and 'write'; see
1156 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00397.html>.
1157 * lisp.h: Update prototypes of emacs_write and emacs_read.
1158
11997c76
EZ
11592011-04-11 Eli Zaretskii <eliz@gnu.org>
1160
1161 * xdisp.c (redisplay_window): Don't try to determine the character
1162 position of the scroll margin if the window start point w->startp
e896f03c 1163 is outside the buffer's accessible region. (Bug#8468)
11997c76 1164
8a2cbd72
EZ
11652011-04-10 Eli Zaretskii <eliz@gnu.org>
1166
1167 Fix write-region and its subroutines for buffers > 2GB.
1168 * fileio.c (a_write, e_write): Modify declaration of arguments and
1169 local variables to support buffers larger than 2GB.
1170 (Fcopy_file): Use EMACS_INT for return value of emacs_read.
1171
1172 * sysdep.c (emacs_write, emacs_read): Use ssize_t for last
1173 argument, local variables, and return value.
1174
1175 * lisp.h: Update prototypes of emacs_write and emacs_read.
1176
1177 * sound.c (vox_write): Use ssize_t for return value of emacs_write.
1178
4073e537 11792011-04-10 Paul Eggert <eggert@cs.ucla.edu>
eb3f1cc8 1180
1ebfdcb6
PE
1181 * xdisp.c (vmessage): Use memchr, not strnlen, which some hosts lack.
1182
b2ded58d
PE
1183 Fix more problems found by GCC 4.6.0's static checks.
1184
7d66342c
PE
1185 * xdisp.c (vmessage): Use a better test for character truncation.
1186
bbf47d44
PE
1187 * charset.c (load_charset_map): <, not <=, for optimization,
1188 and to avoid potential problems with integer overflow.
9248994d 1189 * chartab.c (sub_char_table_set_range, char_table_set_range): Likewise.
f9a68bc5 1190 * casetab.c (set_identity, shuffle): Likewise.
3ab1c7ce 1191 * editfns.c (Fformat): Likewise.
1e69125e 1192 * syntax.c (skip_chars): Likewise.
3befa583 1193
e3019616
PE
1194 * xmenu.c (set_frame_menubar): Allocate smaller local vectors.
1195 This also lets GCC 4.6.0 generate slightly better loop code.
1196
becfa255
PE
1197 * callint.c (Fcall_interactively): <, not <=, for optimization.
1198 (Fcall_interactively): Count the number of arguments produced,
1199 not the number of arguments given. This is simpler and lets GCC
1200 4.6.0 generate slightly better code.
1201
dae0cd48
PE
1202 * ftfont.c: Distingish more carefully between FcChar8 and char.
1203 The previous code passed unsigned char * to a functions like
1204 strlen and xstrcasecmp that expect char *, which does not
1205 conform to the C standard.
1206 (get_adstyle_property, ftfont_pattern_entity): Use FcChar8 for
1207 arguments to FcPatternGetString, and explicitly cast FcChar8 * to
1208 char * when the C standard requires it.
1209
76032d70
PE
1210 * keyboard.c (read_char): Remove unused var.
1211
eb3f1cc8
PE
1212 * eval.c: Port to Windows vsnprintf (Bug#8435).
1213 Include <limits.h>.
1214 (SIZE_MAX): Define if the headers do not.
1215 (verror): Do not give up if vsnprintf returns a negative count.
1216 Instead, grow the buffer. This ports to Windows vsnprintf, which
1217 does not conform to C99. Problem reported by Eli Zaretskii.
1218 Also, simplify the allocation scheme, by avoiding the need for
1219 calling realloc, and removing the ALLOCATED variable.
1220
70476b54
PE
1221 * eval.c (verror): Initial buffer size is 4000 (not 200) bytes.
1222
12020a9e
PE
1223 Remove invocations of doprnt, as Emacs now uses vsnprintf.
1224 But keep the doprint source code for now, as we might revamp it
1225 and use it again (Bug#8435).
ea6c7ae6
PE
1226 * lisp.h (doprnt): Remove.
1227 * Makefile.in (base_obj): Remove doprnt.o.
1228 * deps.mk (doprnt.o): Remove.
1229
5fdb398c
PE
1230 error: Print 32- and 64-bit integers portably (Bug#8435).
1231 Without this change, on typical 64-bit hosts error ("...%d...", N)
1232 was used to print both 32- and 64-bit integers N, which relied on
1233 undefined behavior.
1234 * lisp.h, src/m/amdx86-64.h, src/m/ia64.h, src/m/ibms390x.h (pEd):
1235 New macro.
1236 * lisp.h (error, verror): Mark as printf-like functions.
1237 * eval.c (verror): Use vsnprintf, not doprnt, to do the real work.
1238 Report overflow in size calculations when allocating printf buffer.
1239 Do not truncate output string at its first null byte.
1240 * xdisp.c (vmessage): Use vsnprintf, not doprnt, to do the real work.
1241 Truncate the output at a character boundary, since vsnprintf does not
1242 do that.
1243 * charset.c (check_iso_charset_parameter): Convert internal
1244 character to string before calling 'error', since %c now has the
1245 printf meaning.
1246 * coding.c (Fdecode_sjis_char, Fdecode_big5_char): Avoid int
1247 overflow when computing char to be passed to 'error'. Do not
1248 pass Lisp_Object to 'error'; pass the integer instead.
1249 * nsfns.m (Fns_do_applescript): Use int, not long, since it's
1250 formatted with plain %d.
1251
b189fa66
PE
1252 * eval.c (internal_lisp_condition_case): Don't pass spurious arg.
1253
bff87ef0
PE
1254 * keyboard.c (access_keymap_keyremap): Print func name, not garbage.
1255
7e2cac20
PE
1256 * coding.c (Fdecode_sjis_char): Don't assume CODE fits in int.
1257
ce4d90b5
PE
1258 * xterm.c (x_catch_errors): Remove duplicate declaration.
1259
266c9547
PE
1260 * term.c (maybe_fatal): Mark its 3rd arg as a printf format, too.
1261
79c49ad2
PE
1262 * xdisp.c, lisp.h (message_nolog): Remove; unused.
1263
368f4090
JM
12642011-04-10 Jim Meyering <meyering@redhat.com>
1265
1266 use ssize_t and size_t for read- and write-like emacs_gnutls_* functions
1267 * gnutls.c (emacs_gnutls_read): Adjust signature to be more read-like:
1268 return ssize_t not "int", and use size_t as the buffer length.
1269 (emacs_gnutls_write): Likewise, and make the buffer pointer "const".
1270 * gnutls.h: Update declarations.
1271 * process.c (read_process_output): Use ssize_t, to match.
1272 (send_process): Likewise.
1273
a32d4040
CY
12742011-04-09 Chong Yidong <cyd@stupidchicken.com>
1275
1276 * image.c (Fimagemagick_types): Doc fix, and comment cleanup.
1277
8546720e 12782011-04-09 Chong Yidong <cyd@stupidchicken.com>
aac0c6e3 1279
8546720e
GM
1280 * ftfont.c (get_adstyle_property, ftfont_pattern_entity): Use
1281 unsigned char, to match FcChar8 type definition.
aac0c6e3 1282
8546720e
GM
1283 * xterm.c (handle_one_xevent):
1284 * xmenu.c (create_and_show_popup_menu):
1285 * xselect.c (x_decline_selection_request)
1286 (x_reply_selection_request): Avoid type-punned deref of X events.
aac0c6e3 1287
0a2f5c1a 12882011-04-09 Eli Zaretskii <eliz@gnu.org>
a53e2e89
EZ
1289
1290 Fix some uses of `int' instead of EMACS_INT.
1291 * search.c (string_match_1, fast_string_match)
1292 (fast_c_string_match_ignore_case, fast_string_match_ignore_case)
1293 (scan_buffer, find_next_newline_no_quit)
1294 (find_before_next_newline, search_command, Freplace_match)
1295 (Fmatch_data): Make some `int' variables be EMACS_INT.
1296
1297 * xdisp.c (display_count_lines): 3rd argument and return value now
1298 EMACS_INT. All callers changed.
1299 (pint2hrstr): Last argument is now EMACS_INT.
1300
1301 * coding.c (detect_coding_utf_8, detect_coding_emacs_mule)
1302 (detect_coding_iso_2022, detect_coding_sjis, detect_coding_big5)
1303 (detect_coding_ccl, detect_coding_charset, decode_coding_utf_8)
1304 (decode_coding_utf_16, decode_coding_emacs_mule)
1305 (decode_coding_iso_2022, decode_coding_sjis, decode_coding_big5)
1306 (decode_coding_ccl, decode_coding_charset)
1307 <consumed_chars, consumed_chars_base>: Declare EMACS_INT.
1308 (decode_coding_iso_2022, decode_coding_emacs_mule)
1309 (decode_coding_sjis, decode_coding_big5, decode_coding_charset)
1310 <char_offset, last_offset>: Declare EMACS_INT.
1311 (encode_coding_utf_8, encode_coding_utf_16)
1312 (encode_coding_emacs_mule, encode_invocation_designation)
1313 (encode_designation_at_bol, encode_coding_iso_2022)
1314 (encode_coding_sjis, encode_coding_big5, encode_coding_ccl)
1315 (encode_coding_raw_text, encode_coding_charset) <produced_chars>:
1316 Declare EMACS_INT.
1317 (ASSURE_DESTINATION): Declare more_bytes EMACS_INT.
1318 (encode_invocation_designation): Last argument P_NCHARS is now
1319 EMACS_INT.
1320 (decode_eol): Declare pos_byte, pos, and pos_end EMACS_INT.
1321 (produce_chars): from_nchars and to_nchars are now EMACS_INT.
1322
1323 * coding.h (struct coding_system) <head_ascii>: Declare EMACS_INT.
1324 All users changed.
1325
1326 * ccl.c (Fccl_execute_on_string): Declare some variables
1327 EMACS_INT.
1328
8546720e 13292011-04-08 Samuel Thibault <sthibault@debian.org> (tiny change)
0080dc6b
SS
1330
1331 * term.c (init_tty): Fix incorrect ifdef placement (Bug#8450).
1332
4e19a977
CS
13332011-03-19 Christoph Scholtes <cschol2112@googlemail.com>
1334
1335 * process.c (Fformat_network_address): Doc fix.
1336
87302331
R
13372011-04-08 T.V. Raman <tv.raman.tv@gmail.com> (tiny change)
1338
1339 * xml.c (parse_region): Avoid creating spurious whiespace nodes.
1340
cbb59342
CY
13412011-04-08 Chong Yidong <cyd@stupidchicken.com>
1342
1343 * keyboard.c (read_char): Call Lisp function help-form-show,
1344 instead of using internal_with_output_to_temp_buffer.
1345 (Qhelp_form_show): New var.
e0d38eeb 1346 (syms_of_keyboard): Use DEFSYM macro.
cbb59342
CY
1347
1348 * print.c (internal_with_output_to_temp_buffer): Function deleted.
1349
1350 * lisp.h (internal_with_output_to_temp_buffer): Remove prototype.
1351
e67a13ab
CY
13522011-04-06 Chong Yidong <cyd@stupidchicken.com>
1353
1354 * process.c (Flist_processes): Removed to Lisp.
1355 (list_processes_1): Deleted.
1356
973f782d
EZ
13572011-04-06 Eli Zaretskii <eliz@gnu.org>
1358
7c106b1e
EZ
1359 * msdos.c (careadlinkat, careadlinkatcwd): MS-DOS replacements.
1360
973f782d
EZ
1361 * w32.c (careadlinkat, careadlinkatcwd): New always-fail stubs.
1362
41cf7d1a 13632011-04-06 Paul Eggert <eggert@cs.ucla.edu>
27ccc379 1364
ca23cc88
PE
1365 Fix more problems found by GCC 4.6.0's static checks.
1366
f390e2d5
PE
1367 * xmenu.c (Fx_popup_dialog): Don't assume string is free of formats.
1368
42eea0d0
PE
1369 * menu.c (Fx_popup_menu): Don't assume error_name lacks printf formats.
1370
b69769da 1371 * lisp.h (message, message_nolog, fatal): Mark as printf-like.
1e973bc7 1372
f9541e84
PE
1373 * xdisp.c (vmessage): Mark as a printf-like function.
1374
13841b55
PE
1375 * term.c (vfatal, maybe_fatal): Mark as printf-like functions.
1376
c136c10f
PE
1377 * sound.c (sound_warning): Don't crash if arg contains a printf format.
1378
5e2d4a30
PE
1379 * image.c (tiff_error_handler, tiff_warning_handler): Mark as
1380 printf-like functions.
1381 (tiff_load): Add casts to remove these marks before passing them
1382 to system-supplied API.
1383
583f48b9
PE
1384 * eval.c (Fsignal): Remove excess argument to 'fatal'.
1385
b25d760e
PE
1386 * coding.c (EMIT_ONE_BYTE, EMIT_TWO_BYTES): Use unsigned, not int.
1387 This avoids several warnings with gcc -Wstrict-overflow.
d5efd1d1
PE
1388 (DECODE_COMPOSITION_RULE): If the rule is invalid, goto invalid_code
1389 directly, rather than having caller test rule sign. This avoids
1390 some unnecessary tests.
1391 * composite.h (COMPOSITION_ENCODE_RULE_VALID): New macro.
1392 (COMPOSITION_ENCODE_RULE): Arguments now must be valid. This
1393 affects only one use, in DECODE_COMPOSITION_RULE, which is changed.
b25d760e 1394
bc7b6697 1395 * xfont.c (xfont_text_extents): Remove var that was set but not used.
625a3eb1 1396 (xfont_open): Avoid unnecessary tests.
bc7b6697 1397
27ccc379
PE
1398 * composite.c (composition_gstring_put_cache): Use unsigned integer.
1399
dcd5c89a
PE
1400 * composite.h, composite.c (composition_gstring_put_cache):
1401 Use EMACS_INT, not int, for length.
1402
b13a45c6
PE
1403 * composite.h (COMPOSITION_DECODE_REFS): New macro,
1404 breaking out part of COMPOSITION_DECODE_RULE.
1405 (COMPOSITION_DECODE_RULE): Use it.
1406 * composite.c (get_composition_id): Remove unused local vars,
1407 by using the new macro.
1408
1e792e4d
PE
1409 * textprop.c (set_text_properties_1): Change while to do-while,
1410 since the condition is always true at first.
1411
dc6c6455 1412 * intervals.c (graft_intervals_into_buffer): Mark var as used.
aa86731f
PE
1413 (interval_deletion_adjustment): Return unsigned value.
1414 All uses changed.
dc6c6455 1415
aba7731a
PE
1416 * process.c (list_processes_1, create_pty, read_process_output):
1417 (exec_sentinel): Remove vars that were set but not used.
afd4052b 1418 (create_pty): Remove unnecessary "volatile"s.
bc57d757 1419 (Fnetwork_interface_info): Avoid possibility of int overflow.
82eaa333 1420 (read_process_output): Do adaptive read buffering even if carryover.
fe07cdfa 1421 (read_process_output): Simplify nbytes computation if buffered.
aba7731a 1422
fdfc4bf3
PE
1423 * bytecode.c (exec_byte_code): Rename local to avoid shadowing.
1424
fca8fe46 1425 * syntax.c (scan_words): Remove var that was set but not used.
12cbf13f 1426 (update_syntax_table): Use unsigned instead of int.
fca8fe46 1427
06a0259a 1428 * lread.c (lisp_file_lexically_bound_p): Use ints rather than endptrs.
3c346cc3 1429 (lisp_file_lexically_bound_p, read1): Use unsigned instead of int.
e6eb4e9e 1430 (safe_to_load_p): Make the end-of-loop test the inverse of the in-loop.
06a0259a 1431
e7b9e80f
PE
1432 * print.c (print_error_message): Avoid int overflow.
1433
56201685
PE
1434 * font.c (font_list_entities): Redo for clarity,
1435 so that reader need not know FONT_DPI_INDEX + 1 == FONT_SPACING_INDEX.
1436
78834453 1437 * font.c (font_find_for_lface, Ffont_get_glyphs): Remove unused vars.
790771b1 1438 (font_score): Avoid potential overflow in diff calculation.
78834453 1439
0bc0b309 1440 * fns.c (substring_both): Remove var that is set but not used.
8cd55cb4 1441 (sxhash): Redo loop for clarity and to avoid wraparound warning.
0bc0b309 1442
e610eaca
PE
1443 * eval.c (funcall_lambda): Rename local to avoid shadowing.
1444
b895abce
PE
1445 * alloc.c (mark_object_loop_halt, mark_object): Use size_t, not int.
1446 Otherwise, GCC 4.6.0 optimizes the loop check away since the check
1447 can always succeed if overflow has undefined behavior.
1448
1f1d9321 1449 * search.c (boyer_moore, wordify): Remove vars set but not used.
6f076cc7 1450 (wordify): Omit three unnecessary tests.
1f1d9321 1451
c59478bc
PE
1452 * indent.c (MULTIBYTE_BYTES_WIDTH): Don't compute wide_column.
1453 All callers changed. This avoids the need for an unused var.
1454
79b73827
PE
1455 * casefiddle.c (casify_region): Remove var that is set but not used.
1456
a4db5dfe
PE
1457 * dired.c (file_name_completion): Remove var that is set but not used.
1458
43aae36e
PE
1459 * fileio.c (Finsert_file_contents): Make EOF condition clearer.
1460
2a47c44d 1461 * fileio.c (Finsert_file_contents): Avoid signed integer overflow.
163c5f32 1462 (Finsert_file_contents): Remove unnecessary code checking fd.
2a47c44d 1463
a37c69bf
PE
1464 * minibuf.c (read_minibuf_noninteractive): Use size_t for sizes.
1465 Check for integer overflow on size calculations.
1466
328ab8e7
PE
1467 * buffer.c (Fprevious_overlay_change): Remove var that is set
1468 but not used.
1469
e5a2a5cb
PE
1470 * keyboard.c (menu_bar_items, read_char_minibuf_menu_prompt):
1471 Remove vars that are set but not used.
8d84a6eb 1472 (timer_check_2): Don't assume timer-list and idle-timer-list are lists.
6b043475 1473 (timer_check_2): Mark vars as initialized.
e5a2a5cb 1474
a60e5f68
PE
1475 * gtkutil.c (xg_get_file_with_chooser): Mark var as initialized.
1476
f661cb61 1477 * image.c (lookup_image): Remove var that is set but not used.
35fa624f 1478 (xbm_load): Use parse_p, for gcc -Werror=unused-but-set-variable.
f661cb61 1479
f0397f5a
PE
1480 * fontset.c (Finternal_char_font, Ffontset_info): Remove vars
1481 that are set but not used.
1482
8664db06 1483 * xfns.c (make_invisible_cursor): Don't return garbage
03733ee7 1484 if XCreateBitmapFromData fails (Bug#8410).
8664db06 1485
6abdaa4a
PE
1486 * xselect.c (x_get_local_selection, x_handle_property_notify):
1487 Remove vars that are set but not used.
1488
0ce7538d 1489 * xfns.c (x_create_tip_frame): Remove var that is set but not used.
6abdaa4a 1490 (make_invisible_cursor): Initialize a possibly-uninitialized variable.
0ce7538d 1491
9ae848fc
PE
1492 * xterm.c (x_scroll_bar_to_input_event) [!USE_GTK]:
1493 Remove var that is set but not used.
0b918413
PE
1494 (scroll_bar_windows_size): Now size_t, not int.
1495 (x_send_scroll_bar_event): Use size_t, not int, for sizes.
1496 Check for overflow.
9ae848fc 1497
a5a62657
PE
1498 * xfaces.c (realize_named_face): Remove vars that are set but not used.
1499 (map_tty_color) [!defined MSDOS]: Likewise.
1500
5c5cdd39
PE
1501 * term.c (tty_write_glyphs): Use size_t; this avoids overflow warning.
1502
66ebf983
PE
1503 * coding.c: Remove vars that are set but not used.
1504 (DECODE_COMPOSITION_RULE): Remove 2nd arg, which is unused.
1505 All callers changed.
1506 (decode_coding_utf_8, decode_coding_utf_16 decode_coding_emacs_mule):
1507 (decode_coding_iso_2022, encode_coding_sjis, encode_coding_big5):
1508 (decode_coding_charset): Remove vars that are set but not used.
1509
1be4d761
PE
1510 * bytecode.c (Fbyte_code) [!defined BYTE_CODE_SAFE]: Remove var
1511 that is set but not used.
1512
47553fa8
PE
1513 * print.c (print_object): Remove var that is set but not used.
1514
1f7196bf 1515 Replace 2 copies of readlink code with 1 gnulib version (Bug#8401).
d1fdcab7
PE
1516 The gnulib version avoids calling malloc in the usual case,
1517 and on 64-bit hosts doesn't have some arbitrary 32-bit limits.
1518 * fileio.c (Ffile_symlink_p): Use emacs_readlink.
1519 * filelock.c (current_lock_owner): Likewise.
1520 * lisp.h (READLINK_BUFSIZE, emacs_readlink): New function.
1521 * sysdep.c: Include allocator.h, careadlinkat.h.
1522 (emacs_no_realloc_allocator): New static constant.
1523 (emacs_readlink): New function.
fdb61804
PE
1524 * deps.mk (sysdep.o): Depend on ../lib/allocator.h and on
1525 ../lib/careadlinkat.h.
d1fdcab7 1526
f84c17c7
SM
15272011-04-04 Stefan Monnier <monnier@iro.umontreal.ca>
1528
1529 * keyboard.c (safe_run_hook_funcall): Fix last change (don't stop at the
1530 first non-nil return value).
1531
ef3862ad
JD
15322011-04-03 Jan Djärv <jan.h.d@swipnet.se>
1533
1534 * nsterm.m (ns_update_auto_hide_menu_bar): Define MAC_OS_X_VERSION_10_6
1535 if not defined (Bug#8403).
1536
376a7006
JB
15372011-04-02 Juanma Barranquero <lekktu@gmail.com>
1538
1539 * xdisp.c (display_count_lines): Remove parameter `start',
1540 unused since 1998-01-01T02:27:27Z!rms@gnu.org. All callers changed.
1541 (get_char_face_and_encoding): Remove parameter `multibyte_p',
1542 unused since 2008-05-14T01:40:23Z!handa@m17n.org. All callers changed.
1543 (fill_stretch_glyph_string): Remove parameters `row' and `area',
1544 unused at least since Kim's GUI unification at 2003-03-16T20:45:46Z!storm@cua.dk
1545 and thereabouts. All callers changed.
1546 (get_per_char_metric): Remove parameter `f', unused since
1547 2008-05-14T01:40:23Z!handa@m17n.org. All callers changed.
1548
6ca3801d
JM
15492011-04-02 Jim Meyering <meyering@redhat.com>
1550
1551 do not dereference NULL upon failed strdup
1552 * nsfont.m (ns_descriptor_to_entity): Use xstrdup, not strdup.
1553 (ns_get_family): Likewise.
1554
d8e2b5ba
JB
15552011-04-02 Juanma Barranquero <lekktu@gmail.com>
1556
1557 * eval.c (unwind_to_catch) [DEBUG_GCPRO]: Remove redundant assignment.
1558
8c74fcbd
JD
15592011-04-02 Jan Djärv <jan.h.d@swipnet.se>
1560
1561 * nsterm.m (ns_update_auto_hide_menu_bar): Only for OSX 10.6 or
1562 later (Bug#8403).
1563
7200d79c
SM
15642011-04-01 Stefan Monnier <monnier@iro.umontreal.ca>
1565
03408648 1566 Add lexical binding.
7200d79c 1567
03408648
SM
1568 * window.c (Ftemp_output_buffer_show): New fun.
1569 (Fsave_window_excursion):
1570 * print.c (Fwith_output_to_temp_buffer): Move to subr.el.
1571
1572 * lread.c (lisp_file_lexically_bound_p): New function.
1573 (Fload): Bind Qlexical_binding.
1574 (readevalloop): Remove `evalfun' arg.
1575 Bind Qinternal_interpreter_environment.
1576 (Feval_buffer): Bind Qlexical_binding.
1577 (defvar_int, defvar_bool, defvar_lisp_nopro, defvar_kboard):
1578 Mark as dynamic.
1579 (syms_of_lread): Declare `lexical-binding'.
1580
1581 * lisp.h (struct Lisp_Symbol): New field `declared_special'.
1582
1583 * keyboard.c (eval_dyn): New fun.
1584 (menu_item_eval_property): Use it.
ca105506
SM
1585
1586 * image.c (parse_image_spec): Use Ffunctionp.
ca105506 1587
03408648
SM
1588 * fns.c (concat, mapcar1): Accept byte-code-functions.
1589
1590 * eval.c (Fsetq): Handle lexical vars.
1591 (Fdefun, Fdefmacro, Ffunction): Make closures when needed.
1592 (Fdefconst, Fdefvaralias, Fdefvar): Mark as dynamic.
1593 (FletX, Flet): Obey lexical binding.
1594 (Fcommandp): Handle closures.
1595 (Feval): New `lexical' arg.
1596 (eval_sub): New function extracted from Feval. Use it almost
1597 everywhere where Feval was used. Look up vars in lexical env.
1598 Handle closures.
1599 (Ffunctionp): Move from subr.el.
1600 (Ffuncall): Handle closures.
1601 (apply_lambda): Remove `eval_flags'.
1602 (funcall_lambda): Handle closures and new byte-code-functions.
1603 (Fspecial_variable_p): New function.
1604 (syms_of_eval): Initialize the Vinternal_interpreter_environment var,
1605 but without exporting it to Lisp.
23aba0ea 1606
23aba0ea 1607 * doc.c (Fdocumentation, store_function_docstring):
03408648 1608 * data.c (Finteractive_form): Handle closures.
23aba0ea 1609
03408648
SM
1610 * callint.c (Fcall_interactively): Preserve lexical-binding mode for
1611 interactive spec.
ba83908c 1612
03408648
SM
1613 * bytecode.c (Bstack_ref, Bstack_set, Bstack_set2, BdiscardN): New
1614 byte-codes.
1615 (exec_byte_code): New function extracted from Fbyte_code to handle new
1616 calling convention for byte-code-functions. Add new byte-codes.
ba83908c 1617
03408648 1618 * buffer.c (defvar_per_buffer): Set new `declared_special' field.
e2abe5a1 1619
03408648 1620 * alloc.c (Fmake_symbol): Init new `declared_special' field.
e2abe5a1 1621
e2abce01
JB
16222011-03-31 Juanma Barranquero <lekktu@gmail.com>
1623
1624 * xdisp.c (redisplay_internal): Fix prototype.
1625
63696a73 16262011-03-31 Eli Zaretskii <eliz@gnu.org>
09725d26 1627
63696a73
EZ
1628 * xdisp.c (SCROLL_LIMIT): New macro.
1629 (try_scrolling): Use it when setting scroll_limit. Limit
1630 scrolling to 100 screen lines.
1631 (redisplay_window): Even when falling back on "recentering",
1632 position point in the window according to scroll-conservatively,
1633 scroll-margin, and scroll-*-aggressively variables. (Bug#6671)
1634
1635 (try_scrolling): When point is above the window, allow searching
1636 as far as scroll_max, or one screenful, to compute vertical
1637 distance from PT to the scroll margin position. This prevents
1638 try_scrolling from unnecessarily failing when
1639 scroll-conservatively is set to a value slightly larger than the
1640 window height. Clean up the case of PT below the margin at bottom
1641 of window: scroll_max can no longer be INT_MAX. When aggressive
1642 scrolling is in use, don't let point enter the opposite scroll
1643 margin as result of the scroll.
1644 (syms_of_xdisp) <scroll-conservatively>: Document the
09725d26
EZ
1645 threshold of 100 lines for never-recentering scrolling.
1646
e4cc2dfc
JB
16472011-03-31 Juanma Barranquero <lekktu@gmail.com>
1648
1649 * dispextern.h (move_it_by_lines):
1650 * xdisp.c (move_it_by_lines): Remove parameter `need_y_p', unused
1651 since 2000-12-29T14:24:09Z!gerd@gnu.org. All callers changed.
1652 (message_log_check_duplicate): Remove parameters `prev_bol' and
1653 `this_bol', unused since 1998-01-01T02:27:27Z!rms@gnu.org. All callers changed.
1654 (redisplay_internal): Remove parameter `preserve_echo_area',
1655 unused since 1999-07-21T21:43:52Z!gerd@gnu.org. All callers changed.
1656
1657 * indent.c (Fvertical_motion):
1658 * window.c (window_scroll_pixel_based, Frecenter):
1659 Don't pass `need_y_p' to `move_it_by_lines'.
1660
1c470562
SM
16612011-03-30 Stefan Monnier <monnier@iro.umontreal.ca>
1662
44f230aa
SM
1663 * eval.c (struct backtrace): Don't cheat with negative numbers, but do
1664 steal a few bits to be more compact.
1665 (interactive_p, Fbacktrace, Fbacktrace_frame, mark_backtrace):
1666 Remove unneeded casts.
1667
1c470562
SM
1668 * bytecode.c (Fbyte_code): CAR and CDR can GC.
1669
888adce9
ZK
16702011-03-30 Zachary Kanfer <zkanfer@gmail.com> (tiny change)
1671
1672 * keyboard.c (Fexecute_extended_command): Do log the "suggest key
1673 binding" message (bug#7967).
1674
f838ed7b
PE
16752011-03-30 Paul Eggert <eggert@cs.ucla.edu>
1676
77861b95
PE
1677 Fix more problems found by GCC 4.6.0's static checks.
1678
de6dbc14
PE
1679 * unexelf.c (unexec) [! (defined _SYSTYPE_SYSV || defined __sgi)]:
1680 Remove unused local var.
1681
f838ed7b
PE
1682 * editfns.c (Fmessage_box): Remove unused local var.
1683
792c7b2b
PE
1684 * xdisp.c (try_window_reusing_current_matrix, x_produce_glyphs):
1685 (note_mode_line_or_margin_highlight, note_mouse_highlight):
1686 Omit unused local vars.
c499e557 1687 * window.c (shrink_windows): Omit unused local var.
b01a1c29 1688 * menu.c (digest_single_submenu): Omit unused local var.
0bc32927
PE
1689 * dispnew.c (update_window) [PERIODIC_PREEMPTION_CHECKING]:
1690 Omit unused local var.
1691
ba0165e1
PE
1692 * keyboard.c (parse_modifiers_uncached, parse_modifiers):
1693 Don't assume string length fits in int.
32ad8845 1694 (keyremap_step, read_key_sequence): Use size_t for sizes.
48011560 1695 (read_key_sequence): Don't check last_real_key_start redundantly.
ba0165e1 1696
3c59b4c9
PE
1697 * callproc.c (Fcall_process, Fcall_process_region): Use SAFE_ALLOCA
1698 instead of alloca (Bug#8344).
1699
a3eed478 1700 * eval.c (Fbacktrace): Don't assume nargs fits in int.
5d5d959d 1701 (Fbacktrace_frame): Don't assume nframes fits in int.
a3eed478 1702
eb4d412d
PE
1703 * syntax.c (scan_sexps_forward): Avoid pointer wraparound.
1704
1658b401
PE
1705 * xterm.c (x_make_frame_visible, same_x_server): Redo to avoid overflow
1706 concerns.
1707
1708 * term.c (produce_glyphless_glyph): Remove unnecessary test.
1709
1710 * cm.c (calccost): Turn while-do into do-while, for clarity.
44f730c8 1711
9a2c6e05
PE
1712 * keyboard.c (syms_of_keyboard): Use the same style as later
1713 in this function when indexing through an array. This also
1714 works around GCC bug 48267.
1715
03d0a109
PE
1716 * image.c (tiff_load): Fix off-by-one image count (Bug#8336).
1717
44f730c8
PE
1718 * xselect.c (x_check_property_data): Return correct size (Bug#8335).
1719
fe75f926
PE
1720 * chartab.c (sub_char_table_ref_and_range): Redo for slight
1721 efficiency gain, and to bypass a gcc -Wstrict-overflow warning.
1722
ffa8c828
PE
1723 * keyboard.c, keyboard.h (num_input_events): Now size_t.
1724 This avoids undefined behavior on integer overflow, and is a bit
1725 more convenient anyway since it is compared to a size_t variable.
1726
c5101a77
PE
1727 Variadic C functions now count arguments with size_t, not int.
1728 This avoids an unnecessary limitation on 64-bit machines, which
1729 caused (substring ...) to crash on large vectors (Bug#8344).
1730 * lisp.h (struct Lisp_Subr.function.aMANY): Now takes size_t, not int.
1731 (DEFUN_ARGS_MANY, internal_condition_case_n, safe_call): Likewise.
77861b95 1732 All variadic functions and their callers changed accordingly.
c5101a77
PE
1733 (struct gcpro.nvars): Now size_t, not int. All uses changed.
1734 * data.c (arith_driver, float_arith_driver): Likewise.
1735 * editfns.c (general_insert_function): Likewise.
1736 * eval.c (struct backtrace.nargs, interactive_p)
1737 (internal_condition_case_n, run_hook_with_args, apply_lambda)
1738 (funcall_lambda, mark_backtrace): Likewise.
1739 * fns.c (concat): Likewise.
1740 * frame.c (x_set_frame_parameters): Likewise.
1741 * fns.c (get_key_arg): Now accepts and returns size_t, and returns
1742 0 if not found, not -1. All callers changed.
1743
dd3f25f7
PE
1744 * alloc.c (garbage_collect): Don't assume stack size fits in int.
1745 (stack_copy_size): Now size_t, not int.
1746 (stack_copy, stack_copy_size): Define only if MAX_SAVE_STACK > 0.
1747
461c2ab9
JB
17482011-03-28 Juanma Barranquero <lekktu@gmail.com>
1749
1750 * coding.c (encode_designation_at_bol): Remove parameter `charbuf_end',
1751 unused since 2002-03-01T01:17:24Z!handa@m17n.org and 2008-02-01T16:01:31Z!miles@gnu.org.
1752 All callers changed.
1753
1754 * lisp.h (multibyte_char_to_unibyte):
1755 * character.c (multibyte_char_to_unibyte): Remove parameter `rev_tbl',
1756 unused since 2002-03-01T01:16:34Z!handa@m17n.org and 2008-02-01T16:01:31Z!miles@gnu.org.
1757 * character.h (CHAR_TO_BYTE8):
1758 * cmds.c (internal_self_insert):
1759 * editfns.c (general_insert_function):
1760 * keymap.c (push_key_description):
1761 * search.c (Freplace_match):
1762 * xdisp.c (message_dolog, set_message_1): All callers changed.
1763
f6d62986
SM
17642011-03-28 Stefan Monnier <monnier@iro.umontreal.ca>
1765
1766 * keyboard.c (safe_run_hook_funcall): New function.
1767 (safe_run_hooks_1, safe_run_hooks_error, safe_run_hooks): On error,
1768 don't set the hook to nil, but remove the offending function instead.
1769 (Qcommand_hook_internal): Remove, unused.
1770 (syms_of_keyboard): Don't initialize Qcommand_hook_internal nor define
1771 Vcommand_hook_internal.
1772
1773 * eval.c (enum run_hooks_condition): Remove.
1774 (funcall_nil, funcall_not): New functions.
1775 (run_hook_with_args): Call each function through a `funcall' argument.
1776 Remove `cond' argument, now redundant.
1777 (Frun_hooks, Frun_hook_with_args, Frun_hook_with_args_until_success)
1778 (Frun_hook_with_args_until_failure): Adjust accordingly.
1779 (run_hook_wrapped_funcall, Frun_hook_wrapped): New functions.
1780
1db5b1ad
JB
17812011-03-28 Juanma Barranquero <lekktu@gmail.com>
1782
1783 * dispextern.h (string_buffer_position): Remove declaration.
1784
1785 * print.c (strout): Remove parameter `multibyte', unused since
1786 1999-08-21T19:30:21Z!gerd@gnu.org. All callers changed.
1787
1788 * search.c (boyer_moore): Remove parameters `len', `pos' and `lim',
1789 never used since function introduction in 1998-02-08T21:33:56Z!rms@gnu.org.
1790 All callers changed.
1791
1792 * w32.c (_wsa_errlist): Use braces for struct initializers.
1793
1794 * xdisp.c (string_buffer_position_lim): Remove parameter `w',
1795 never used since function introduction in 2001-03-09T18:41:50Z!gerd@gnu.org.
1796 All callers changed.
1797 (string_buffer_position): Likewise. Also, make static (it's never
1798 used outside xdisp.c).
1799 (cursor_row_p): Remove parameter `w', unused since
1800 2000-10-17T16:08:57Z!gerd@gnu.org. All callers changed.
1801 (decode_mode_spec): Remove parameter `precision', introduced during
1802 Gerd Moellmann's rewrite at 1999-07-21T21:43:52Z!gerd@gnu.org, but never used.
1803 All callers changed.
1804
5ffb62aa
JD
18052011-03-27 Jan Djärv <jan.h.d@swipnet.se>
1806
1807 * nsterm.m (syms_of_nsterm): Use doc: for ns-auto-hide-menu-bar.
1808
461c2ab9 18092011-03-27 Anders Lindgren <andlind@gmail.com>
f0a1382a
JD
1810
1811 * nsterm.m (ns_menu_bar_is_hidden): New variable.
1812 (ns_constrain_all_frames, ns_menu_bar_should_be_hidden)
1813 (ns_update_auto_hide_menu_bar): New functions.
1814 (ns_update_begin): Call ns_update_auto_hide_menu_bar.
1815 (applicationDidBecomeActive): Call ns_update_auto_hide_menu_bar and
1816 ns_constrain_all_frames.
1817 (constrainFrameRect): Return at once if ns_menu_bar_should_be_hidden.
1818 (syms_of_nsterm): DEFVAR ns-auto-hide-menu-bar, init to Qnil.
1819
5c380ffb
JD
18202011-03-27 Jan Djärv <jan.h.d@swipnet.se>
1821
1822 * nsmenu.m (runDialogAt): Remove argument to timer_check.
1823
9af30bdf
GM
18242011-03-27 Glenn Morris <rgm@gnu.org>
1825
1826 * syssignal.h: Replace RETSIGTYPE with void.
1827 * atimer.c, data.c, dispnew.c, emacs.c, floatfns.c, keyboard.c:
1828 * keyboard.h, lisp.h, process.c, sysdep.c, xterm.c:
1829 Replace SIGTYPE with void everywhere.
1830 * s/usg5-4-common.h (SIGTYPE): Remove definition.
1831 * s/template.h (SIGTYPE): Remove commented out definition.
1832
e2abce01
JB
18332011-03-26 Eli Zaretskii <eliz@gnu.org>
1834
1835 * xdisp.c (redisplay_window): Don't check buffer's clip_changed
1836 flag as a prerequisite for invoking try_scrolling. (Bug#6671)
1837
f868cd8a
JB
18382011-03-26 Juanma Barranquero <lekktu@gmail.com>
1839
59eb0929
JB
1840 * w32.c (read_unc_volume): Use parameter `henum', instead of
1841 global variable `wget_enum_handle'.
1842
1843 * keymap.c (describe_vector): Remove parameters `indices' and
1844 `char_table_depth', unused since 2002-03-01T01:43:26Z!handa@m17n.org.
1845 (describe_map, Fdescribe_vector): Adjust calls to `describe_vector'.
1846
f868cd8a
JB
1847 * keyboard.h (timer_check, show_help_echo): Remove unused parameters.
1848
1849 * keyboard.c (timer_check): Remove parameter `do_it_now',
1850 unused since 1996-04-12T06:01:29Z!rms@gnu.org.
1851 (show_help_echo): Remove parameter `ok_to_overwrite_keystroke_echo',
1852 unused since 2008-04-19T19:30:53Z!monnier@iro.umontreal.ca.
1853
1854 * keyboard.c (read_char):
1855 * w32menu.c (w32_menu_display_help):
1856 * xmenu.c (show_help_event, menu_help_callback):
1857 Adjust calls to `show_help_echo'.
1858
1859 * gtkutil.c (xg_maybe_add_timer):
1860 * keyboard.c (readable_events):
1861 * process.c (wait_reading_process_output):
1862 * xmenu.c (x_menu_wait_for_event): Adjust calls to `timer_check'.
1863
1864 * insdel.c (adjust_markers_gap_motion):
1865 Remove; no-op since 1998-01-02T21:29:48Z!rms@gnu.org.
1866 (gap_left, gap_right): Don't call it.
1867
2ecf6fdb
CY
18682011-03-25 Chong Yidong <cyd@stupidchicken.com>
1869
1870 * xdisp.c (handle_fontified_prop): Discard changes to clip_changed
1871 incurred during fontification.
1872
6b1f9ba4
JB
18732011-03-25 Juanma Barranquero <lekktu@gmail.com>
1874
1875 * buffer.c (defvar_per_buffer): Remove unused parameter `doc'.
1876 (DEFVAR_PER_BUFFER): Don't pass it.
1877
1878 * dispnew.c (row_equal_p, add_row_entry): Remove unused parameter `w'.
1879 (scrolling_window): Don't pass it.
1880
0f4a96b5
JB
18812011-03-25 Juanma Barranquero <lekktu@gmail.com>
1882
1883 * dispextern.h (glyph_matric): Use #if GLYPH_DEBUG, not #ifdef.
1884
1885 * fileio.c (check_executable) [DOS_NT]: Remove unused variables `len'
1886 and `suffix'.
1887 (Fset_file_selinux_context) [HAVE_LIBSELINUX]: Move here declaration
1888 of variables specific to SELinux and computation of `encoded_absname'.
1889
1890 * image.c (XPutPixel): Remove unused variable `height'.
1891
1892 * keyboard.c (make_lispy_event): Remove unused variable `hpos'.
1893
1894 * unexw32.c (get_section_info): Remove unused variable `section'.
1895
1896 * w32.c (stat): Remove unused variables `drive_root' and `devtype'.
1897 (system_process_attributes): Remove unused variable `sess'.
1898 (sys_read): Remove unused variable `err'.
1899
1900 * w32fns.c (top): Wrap variables with #if GLYPH_DEBUG, not #ifdef.
1901 (w32_wnd_proc): Remove unused variable `isdead'.
1902 (unwind_create_frame): Use #if GLYPH_DEBUG, not #ifdef.
1903 (Fx_server_max_request_size): Remove unused variable `dpyinfo'.
1904 (x_create_tip_frame): Remove unused variable `tem'.
1905
1906 * w32inevt.c (w32_console_read_socket):
1907 Remove unused variable `no_events'.
1908
1909 * w32term.c (x_draw_composite_glyph_string_foreground):
1910 Remove unused variable `width'.
1911
1149507c
JB
19122011-03-24 Juanma Barranquero <lekktu@gmail.com>
1913
1914 * w32term.c (x_set_glyph_string_clipping):
1915 Don't pass uninitialized region to CombineRgn.
1916
9c88f339
JB
19172011-03-23 Juanma Barranquero <lekktu@gmail.com>
1918
1919 * w32fns.c (x_set_menu_bar_lines): Remove unused variable `olines'.
1920 (w32_wnd_proc): Pass NULL to Windows API, not uninitialized buffer.
1921 (Fx_close_connection): Remove unused variable `i'.
1922
1923 * w32font.c (w32font_draw): Return number of glyphs.
1924 (w32font_open_internal): Remove unused variable `i'.
1925 (w32font_driver): Add missing initializer.
1926
1927 * w32menu.c (utf8to16): Remove unused variable `utf16'.
1928 (fill_in_menu): Remove unused variable `items_added'.
1929
1930 * w32term.c (last_mouse_press_frame): Remove static global variable.
1931 (w32_clip_to_row): Remove unused variable `f'.
1932 (x_delete_terminal): Remove unused variable `i'.
1933
1934 * w32uniscribe.c (uniscribe_shape): Remove unused variable `nclusters'.
1935 (NOTHING): Remove unused static global variable.
1936 (uniscribe_check_otf): Remove unused variable `table'.
1937 (uniscribe_font_driver): Add missing initializers.
1938
dee091a3
JD
19392011-03-23 Julien Danjou <julien@danjou.info>
1940
1941 * term.c (Fsuspend_tty, Fresume_tty):
1942 * minibuf.c (read_minibuf, run_exit_minibuf_hook):
1943 * window.c (temp_output_buffer_show):
1944 * insdel.c (signal_before_change):
1945 * frame.c (Fhandle_switch_frame):
1946 * fileio.c (Fdo_auto_save):
1947 * emacs.c (Fkill_emacs):
1948 * editfns.c (save_excursion_restore):
1949 * cmds.c (internal_self_insert):
1950 * callint.c (Fcall_interactively):
1951 * buffer.c (Fkill_all_local_variables):
1952 * keyboard.c (Fcommand_execute, Fsuspend_emacs, safe_run_hooks_1):
1953 Use Frun_hooks.
0f4a96b5 1954 (command_loop_1): Use Frun_hooks. Call safe_run_hooks
dee091a3
JD
1955 unconditionnaly since it does the check itself.
1956
2c520ab5 19572011-03-23 Paul Eggert <eggert@cs.ucla.edu>
f0641eff 1958
c9c49752
PE
1959 Fix more problems found by GCC 4.5.2's static checks.
1960
8abc3f12
PE
1961 * coding.c (encode_coding_raw_text): Avoid unnecessary test
1962 the first time through the loop, since we know p0 < p1 then.
1963 This also avoids a gcc -Wstrict-overflow warning.
1964
a2d26660
PE
1965 * lisp.h (SAFE_ALLOCA, SAFE_ALLOCA_LISP): Avoid 'int' overflow
1966 leading to a memory leak, possible in functions like
1967 load_charset_map_from_file that can allocate an unbounded number
b12ef411 1968 of objects (Bug#8318).
a2d26660 1969
916c72e9
PE
1970 * xmenu.c (set_frame_menubar): Use EMACS_UINT, not int, for indexes
1971 that could (at least in theory) be that large.
1972
19ab8a18
PE
1973 * xdisp.c (message_log_check_duplicate): Return unsigned long, not int.
1974 This is less likely to overflow, and avoids undefined behavior if
1975 overflow does occur. All callers changed. Use strtoul to scan
1976 for the unsigned long integer.
b7cbbd6f
PE
1977 (pint2hrstr): Simplify and tune code slightly.
1978 This also avoids a (bogus) GCC warning with gcc -Wstrict-overflow.
19ab8a18 1979
f0641eff
PE
1980 * scroll.c (do_scrolling): Work around GCC bug 48228.
1981 See <http://gcc.gnu.org/bugzilla/show_bug.cgi?id=48228>.
1982
7f650bb9
PE
1983 * frame.c (Fmodify_frame_parameters): Simplify loop counter.
1984 This also avoids a warning with gcc -Wstrict-overflow.
39f5e519
PE
1985 (validate_x_resource_name): Simplify count usage.
1986 This also avoids a warning with gcc -Wstrict-overflow.
7f650bb9 1987
37dd57d1
PE
1988 * fileio.c (Fcopy_file): Report error if fchown or fchmod
1989 fail (Bug#8306).
81e56e61 1990
699979fc 1991 * emacs.c (Fdaemon_initialized): Do not ignore I/O errors (Bug#8303).
dc1ca6a8 1992
401bf9b4
PE
1993 * process.c (Fmake_network_process): Use socklen_t, not int,
1994 where POSIX says socklen_t is required in portable programs.
1995 This fixes a porting bug on hosts like 64-bit HP-UX, where
591b2973 1996 socklen_t is wider than int (Bug#8277).
401bf9b4
PE
1997 (Fmake_network_process, server_accept_connection):
1998 (wait_reading_process_output, read_process_output):
1999 Likewise.
2000
b93aacde
PE
2001 * process.c: Rename or move locals to avoid shadowing.
2002 (list_processes_1, Fmake_network_process):
2003 (read_process_output_error_handler, exec_sentinel_error_handler):
2004 Rename or move locals.
4dc343ee 2005 (Fmake_network_process): Define label "retry_connect" only if needed.
0da49335 2006 (Fnetwork_interface_info): Fix pointer signedness.
f990b4e5 2007 (process_send_signal): Add cast to avoid pointer signedness problem.
7b808126 2008 (FIRST_PROC_DESC, IF_NON_BLOCKING_CONNECT): Remove unused macros.
c939f91b 2009 (create_process): Use 'volatile' to avoid vfork clobbering (Bug#8298).
b93aacde 2010
af8a867c 2011 Make tparam.h and terminfo.c consistent.
44f230aa
SM
2012 * cm.c (tputs, tgoto, BC, UP): Remove extern decls.
2013 Include tparam.h instead, since it declares them.
af8a867c
PE
2014 * cm.h (PC): Remove extern decl; tparam.h now does this.
2015 * deps.mk (cm.o, terminfo.o): Depend on tparam.h.
2016 * terminfo.c: Include tparam.h, to check interfaces.
2017 (tparm): Make 1st arg a const pointer in decl. Put it at top level.
2018 (tparam): Adjust signature to match interface in tparam.h;
2019 this removes some undefined behavior. Check that outstring and len
2020 are zero, which they always are with Emacs.
2021 * tparam.h (PC, BC, UP): New extern decls.
2022
0248044d 2023 * xftfont.c (xftfont_shape): Now static, and defined only if needed.
001a7ab4 2024 (xftfont_open): Rename locals to avoid shadowing.
0248044d 2025
8ff096c1 2026 * ftfont.c (ftfont_resolve_generic_family): Fix pointer signedness.
a00924bb
PE
2027 (ftfont_otf_capability, ftfont_shape): Omit decls if not needed.
2028 (OTF_TAG_SYM): Omit macro if not needed.
e932860f 2029 (ftfont_list): Remove unused local.
49eaafba
PE
2030 (get_adstyle_property, ftfont_pattern_entity):
2031 (ftfont_lookup_cache, ftfont_open, ftfont_anchor_point):
2032 Rename locals to avoid shadowing.
8ff096c1 2033
e2be39f6
PE
2034 * xfont.c (xfont_list_family): Mark var as initialized.
2035
c9735e30
PE
2036 * xml.c (make_dom): Now static.
2037
8f5201ae
PE
2038 * composite.c (composition_compute_stop_pos): Rename local to
2039 avoid shadowing.
b246f932
PE
2040 (composition_reseat_it): Remove unused locals.
2041 (find_automatic_composition, composition_adjust_point): Likewise.
80e079b2 2042 (composition_update_it): Mark var as initialized.
11b61122
PE
2043 (find_automatic_composition): Mark vars as initialized,
2044 with a FIXME (Bug#8290).
8f5201ae 2045
760fbc2c
PE
2046 character.h: Rename locals to avoid shadowing.
2047 * character.h (PREV_CHAR_BOUNDARY, FETCH_STRING_CHAR_ADVANCE):
2048 (FETCH_STRING_CHAR_AS_MULTIBYTE_ADVANCE, FETCH_CHAR_ADVANCE):
2049 (FETCH_CHAR_ADVANCE_NO_CHECK, INC_POS, DEC_POS, BUF_INC_POS):
2050 (BUF_DEC_POS): Be more systematic about renaming local temporaries
2051 to avoid shadowing.
2052
ff08eb85
PE
2053 * textprop.c (property_change_between_p): Remove; unused.
2054
fc7bf025
PE
2055 * intervals.c (interval_start_pos): Now static.
2056
235d7abc
PE
2057 * intervals.h (CHECK_TOTAL_LENGTH): Avoid empty "else".
2058
44f230aa
SM
2059 * atimer.c (start_atimer, append_atimer_lists, set_alarm):
2060 Rename locals to avoid shadowing.
3e7d6594 2061
50060332
PE
2062 * sound.c (wav_play, au_play, Fplay_sound_internal):
2063 Fix pointer signedness.
d01f234b 2064 (alsa_choose_format): Remove unused local var.
c83b8872
PE
2065 (wav_play): Initialize a variable to 0, to prevent undefined
2066 behavior (Bug#8278).
50060332 2067
c4fc4e30
PE
2068 * region-cache.c (insert_cache_boundary): Redo var to avoid shadowing.
2069
918436ed
PE
2070 * region-cache.h (pp_cache): New decl, for gcc -Wmissing-prototypes.
2071
c939f91b
PE
2072 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork
2073 clobbering (Bug#8298).
b9c7f648
PE
2074 * sysdep.c (sys_subshell): Likewise.
2075 Previously, the sys_subshell 'volatile' was incorrectly IF_LINTted out.
7e9123a2 2076
6bd8c144
PE
2077 * lisp.h (child_setup): Now NO_RETURN unless DOS_NT.
2078 This should get cleaned up, so that child_setup has the
2079 same signature on all platforms.
2080
7710357c 2081 * callproc.c (call_process_cleanup): Now static.
cb1d0ef7 2082 (relocate_fd): Rename locals to avoid shadowing.
7710357c 2083
c59da222
CY
20842011-03-22 Chong Yidong <cyd@stupidchicken.com>
2085
2086 * xterm.c (x_clear_frame): Remove XClearWindow call. This appears
2087 not to be necessary, and produces flickering.
2088
66b87493
GM
20892011-03-20 Glenn Morris <rgm@gnu.org>
2090
2091 * config.in: Remove file.
2092
45b6f6d5
JB
20932011-03-20 Juanma Barranquero <lekktu@gmail.com>
2094
2095 * minibuf.c (Vcompleting_read_function): Don't declare, global variables
2096 are now in src/globals.h.
2097 (syms_of_minibuf): Remove spurious & from previous change.
2098
3ec03f7e
LL
20992011-03-20 Leo <sdl.web@gmail.com>
2100
2101 * minibuf.c (completing-read-function): New variable.
2102 (completing-read-default): Rename from completing-read.
2103 (completing-read): Call completing-read-function.
2104
b14e3e21
CY
21052011-03-19 Juanma Barranquero <lekktu@gmail.com>
2106
2107 * xfaces.c (Fx_load_color_file):
2108 Read color file from absolute filename (bug#8250).
2109
f2b726e6
JB
21102011-03-19 Juanma Barranquero <lekktu@gmail.com>
2111
2112 * makefile.w32-in: Update dependencies.
2113
09f6ff02
EZ
21142011-03-17 Eli Zaretskii <eliz@gnu.org>
2115
2116 * makefile.w32-in ($(BLD)/unexw32.$(O)): Depend on $(SRC)/unexec.h.
2117
29a6015a
PE
21182011-03-17 Paul Eggert <eggert@cs.ucla.edu>
2119
a3a6c54e
PE
2120 Fix more problems found by GCC 4.5.2's static checks.
2121
b766f867
PE
2122 * process.c (make_serial_process_unwind, send_process_trap):
2123 (sigchld_handler): Now static.
2124
be02381c
PE
2125 * process.c (allocate_pty): Let PTY_ITERATION declare iteration vars.
2126 That way, the code declares only the vars that it needs.
2127 * s/aix4-2.h (PTY_ITERATION): Declare iteration vars.
2128 * s/cygwin.h (PTY_ITERATION): Likewise.
2129 * s/darwin.h (PTY_ITERATION): Likewise.
2130 * s/gnu-linux.h (PTY_ITERATION): Likewise.
2131
57048744
PE
2132 * s/irix6-5.h (PTY_OPEN): Declare stb, to loosen coupling.
2133 * process.c (allocate_pty): Don't declare stb unless it's needed.
2134
7914961c 2135 * bytecode.c (MAYBE_GC): Rewrite so as not to use empty "else".
615f2d59
PE
2136 (CONSTANTLIM): Remove; unused.
2137 (METER_CODE, Bscan_buffer, Bread_char, Bset_mark):
2138 Define only if needed.
7914961c 2139
b3967b18
PE
2140 * unexelf.c (unexec): Name an expression,
2141 to avoid gcc -Wbad-function-cast warning.
9ae71512
PE
2142 Use a different way to cause a compilation error if anyone uses
2143 n rather than nn, a way that does not involve shadowing.
73366a00 2144 (ELF_BSS_SECTION_NAME, OLD_PROGRAM_H): Remove; unused.
b3967b18 2145
29a6015a
PE
2146 * deps.mk (unexalpha.o): Remove; unused.
2147
43cfc33e 2148 New file unexec.h, the (simple) interface for unexec (Bug#8267).
7feda0d2 2149 * unexec.h: New file.
ce701a33
PE
2150 * deps.mk (emacs.o, unexaix.o, unexcw.o, unexcoff.o, unexelf.o):
2151 (unexhp9k800.o, unexmacosx.o, unexsol.o, unexw32.o):
2152 Depend on unexec.h.
2153 * emacs.c [!defined CANNOT_DUMP]: Include unexec.h.
2154 * unexaix.c, unexcoff.c, unexcw.c, unexelf.c, unexhp9k800.c:
2155 * unexmacosx.c, unexsol.c, unexw32.c: Include unexec.h.
381259ef 2156 Change as necessary to match prototype in unexec.h.
ce701a33 2157
01f44d5a
PE
2158 * syntax.c (Fforward_comment, scan_lists): Rename locals to avoid
2159 shadowing.
4f63c6bb 2160 (back_comment, skip_chars): Mark vars as initialized.
01f44d5a 2161
a6670b0b
PE
2162 * character.h (FETCH_STRING_CHAR_ADVANCE_NO_CHECK, BUF_INC_POS):
2163 Rename locals to avoid shadowing.
2164
cef2010d 2165 * lread.c (read1): Rewrite so as not to use empty "else".
0902fe45 2166 (Fload, readevalloop, read1): Rename locals to avoid shadowing.
cef2010d 2167
d4d7173a
PE
2168 * print.c (Fredirect_debugging_output): Fix pointer signedess.
2169
f08b802a
PE
2170 * lisp.h (debug_output_compilation_hack): Add decl here, to avoid
2171 warning when compiling print.c.
2172
3ddb0639
PE
2173 * font.c (font_unparse_fcname): Abort in an "impossible" situation
2174 instead of using an uninitialized var.
5ad03b97 2175 (font_sort_entities): Mark var as initialized.
3ddb0639 2176
170a2692
PE
2177 * character.h (FETCH_CHAR_ADVANCE): Rename locals to avoid shadowing.
2178
e663c700
PE
2179 * font.c (font_unparse_xlfd): Don't mix pointers to variables with
2180 pointers to constants.
89bc529a 2181 (font_parse_fcname): Remove unused vars.
7b81e2d0 2182 (font_delete_unmatched): Now static.
ea838e10 2183 (font_get_spec): Remove; unused.
13a547c6
PE
2184 (font_style_to_value, font_prop_validate_style, font_unparse_fcname):
2185 (font_update_drivers, Ffont_get_glyphs, font_add_log):
2186 Rename or move locals to avoid shadowing.
e663c700 2187
2a80c887 2188 * fns.c (require_nesting_list, require_unwind): Now static.
612f56df 2189 (Ffillarray): Rename locals to avoid shadowing.
2a80c887 2190
1384fa33 2191 * floatfns.c (domain_error2): Define only if needed.
a885e2ed 2192 (Ffrexp, Fldexp): Rename locals to avoid shadowing.
1384fa33 2193
8b2c52e9
PE
2194 * alloc.c (mark_backtrace): Move decl from here ...
2195 * lisp.h: ... to here, so that it can be checked.
2196
475545b5 2197 * eval.c (call_debugger, do_debug_on_call, grow_specpdl): Now static.
d28a2170 2198 (Fdefvar): Rewrite so as not to use empty "else".
cfcbfb1a
PE
2199 (lisp_indirect_variable): Name an expression,
2200 to avoid gcc -Wbad-function-cast warning.
1faed8ae 2201 (Fdefvar): Rename locals to avoid shadowing.
475545b5 2202
b1349114 2203 * callint.c (quotify_arg, quotify_args): Now static.
a3e8cbda 2204 (Fcall_interactively): Rename locals to avoid shadowing.
b0e80955 2205 Use const pointer when appropriate.
b1349114 2206
a2928364
PE
2207 * lisp.h (get_system_name, get_operating_system_release):
2208 Move decls here, to check interfaces.
2209 * process.c (get_operating_system_release): Move decl to lisp.h.
2210 * xrdb.c (get_system_name): Likewise.
63c5d10b
PE
2211 * editfns.c (init_editfns, Fuser_login_name, Fuser_uid):
2212 (Fuser_real_uid, Fuser_full_name): Remove unnecessary casts,
2213 some of which prompt warnings from gcc -Wbad-function-cast.
545b49b4
PE
2214 (Fformat_time_string, Fencode_time, Finsert_char):
2215 (Ftranslate_region_internal, Fformat):
2216 Rename or remove local vars to avoid shadowing.
9710023e 2217 (Ftranslate_region_internal): Mark var as initialized.
63c5d10b 2218
a415e694
PE
2219 * doc.c (Fdocumentation, Fsnarf_documentation): Move locals to
2220 avoid shadowing.
2221
8ef4622d
PE
2222 * lisp.h (eassert): Check that the argument compiles, even if
2223 ENABLE_CHECKING is not defined.
2224
946f9a5b
PE
2225 * data.c (Findirect_variable): Name an expression, to avoid
2226 gcc -Wbad-function-cast warning.
112396d6 2227 (default_value, arithcompare, arith_driver, arith_error): Now static.
b9b84fa9 2228 (store_symval_forwarding): Rename local to avoid shadowing.
44f230aa
SM
2229 (Fmake_variable_buffer_local, Fmake_local_variable):
2230 Mark variables as initialized.
52746918 2231 (do_blv_forwarding, do_symval_forwarding): Remove; unused.
946f9a5b 2232
e5aab7e7 2233 * alloc.c (check_cons_list): Do not define unless GC_CHECK_CONS_LIST.
ae35e756
PE
2234 (Fmake_vector, Fvector, Fmake_byte_code, Fgarbage_collect):
2235 Rename locals to avoid shadowing.
dff45157
PE
2236 (mark_stack): Move local variables into the #ifdef region where
2237 they're used.
7bc26fdb
PE
2238 (BLOCK_INPUT_ALLOC, UNBLOCK_INPUT_ALLOC): Define only if
2239 ! defined SYSTEM_MALLOC && ! defined SYNC_INPUT, as they are not
2240 needed otherwise.
2241 (CHECK_ALLOCATED): Define only if GC_CHECK_MARKED_OBJECTS.
2242 (GC_STRING_CHARS): Remove; not used.
d40d4be1 2243 (Fmemory_limit): Cast sbrk's returned value to char *.
ae35e756 2244
e5aab7e7
PE
2245 * lisp.h (check_cons_list): Declare if GC_CHECK_CONS_LIST; this
2246 avoids undefined behavior in theory.
2247
4da60324
PE
2248 * regex.c (IF_LINT): Add defn, for benefit of ../lib-src.
2249
88043301
PE
2250 Use functions, not macros, for up- and down-casing (Bug#8254).
2251 * buffer.h (DOWNCASE_TABLE, UPCASE_TABLE, DOWNCASE, UPPERCASEP):
2252 (NOCASEP, LOWERCASEP, UPCASE, UPCASE1): Remove. All callers changed
2253 to use the following functions instead of these macros.
2254 (downcase): Adjust to lack of DOWNCASE_TABLE. Return int, not
2255 EMACS_INT, since callers assume the returned value fits in int.
2256 (upcase1): Likewise, for UPCASE_TABLE.
2257 (uppercasep, lowercasep, upcase): New static inline functions.
0da09c43 2258 * editfns.c (Fchar_equal): Remove no-longer-needed workaround for
db69b0cd 2259 the race-condition problem in the old DOWNCASE.
88043301 2260
19ed5445
PE
2261 * regex.c (CHARSET_LOOKUP_RANGE_TABLE_RAW, POP_FAILURE_REG_OR_COUNT):
2262 Rename locals to avoid shadowing.
2263 (regex_compile, re_match_2_internal): Move locals to avoid shadowing.
abbd1bcf
PE
2264 (regex_compile, re_search_2, re_match_2_internal):
2265 Remove unused local vars.
952db0d7
PE
2266 (FREE_VAR): Rewrite so as not to use empty "else",
2267 which gcc can warn about.
da053e48 2268 (regex_compile, re_match_2_internal): Mark locals as initialized.
b313f9d8
PE
2269 (RETALLOC_IF): Define only if needed.
2270 (WORDCHAR_P): Likewise. This one is never needed, but is used
2271 only in a comment talking about a compiler bug, so put inside
2272 the #if 0 of that comment.
2273 (CHARSET_LOOKUP_BITMAP, FAIL_STACK_FULL, RESET_FAIL_STACK):
2274 (PUSH_FAILURE_ELT, BUF_PUSH_3, STOP_ADDR_VSTRING):
2275 Remove; unused.
19ed5445 2276
1f3561e4 2277 * search.c (boyer_moore): Rename locals to avoid shadowing.
76ef09b7
PE
2278 * character.h (FETCH_STRING_CHAR_AS_MULTIBYTE_ADVANCE):
2279 (PREV_CHAR_BOUNDARY): Likewise.
1f3561e4 2280
ded6f8f7
PE
2281 * search.c (simple_search): Remove unused var.
2282
dbd37a95
PE
2283 * dired.c (compile_pattern): Move decl from here ...
2284 * lisp.h: ... to here, so that it can be checked.
2285 (struct re_registers): New forward decl.
2286
7e47afad
PE
2287 * character.h (INC_POS, DEC_POS): Rename locals to avoid shadowing.
2288
85f24f61
PE
2289 * indent.c (MULTIBYTE_BYTES_WIDTH): New args bytes, width.
2290 All uses changed.
2291 (MULTIBYTE_BYTES_WIDTH, scan_for_column, compute_motion):
2292 Rename locals to avoid shadowing.
5671df8f 2293 (Fvertical_motion): Mark locals as initialized.
85f24f61 2294
181aa2be 2295 * casefiddle.c (casify_object, casify_region): Now static.
e45a141a 2296 (casify_region): Mark local as initialized.
181aa2be 2297
930d429c
PE
2298 * cmds.c (internal_self_insert): Rename local to avoid shadowing.
2299
7082eac6
PE
2300 * lisp.h (GCPRO2_VAR, GCPRO3_VAR, GCPRO4_VAR, GCPRO5_VAR, GCPRO6_VAR):
2301 New macros, so that the caller can use some names other than
2302 gcpro1, gcpro2, etc.
2303 (GCPRO2, GCPRO3, GCPRO4, GCPRO5, GCPRO6): Reimplement in terms
2304 of the new macros.
2305 (GCPRO1_VAR, UNGCPRO_VAR): Change the meaning of the second
2306 argument, for consistency with GCPRO2_VAR, etc: it is now the
2307 prefix of the variable, not the variable itself. All uses
2308 changed.
38b2c076
PE
2309 * dired.c (directory_files_internal, file_name_completion):
2310 Rename locals to avoid shadowing.
2311
15206ed9
PE
2312 Fix a race condition diagnosed by gcc -Wsequence-point (Bug#8254).
2313 An expression of the form (DOWNCASE (x) == DOWNCASE (y)), found in
2314 dired.c's scmp function, had undefined behavior.
2315 * lisp.h (DOWNCASE_TABLE, UPCASE_TABLE, DOWNCASE, UPPERCASEP):
2316 (NOCASEP, LOWERCASEP, UPCASE, UPCASE1): Move from here ...
2317 * buffer.h: ... to here, because these macros use current_buffer,
2318 and the new implementation with inline functions needs to have
2319 current_buffer in scope now, rather than later when the macros
2320 are used.
2321 (downcase, upcase1): New static inline functions.
2322 (DOWNCASE, UPCASE1): Reimplement using these functions.
2323 This avoids undefined behavior in expressions like
2324 DOWNCASE (x) == DOWNCASE (y), which previously suffered
2325 from race conditions in accessing the global variables
2326 case_temp1 and case_temp2.
2327 * casetab.c (case_temp1, case_temp2): Remove; no longer needed.
2328 * lisp.h (case_temp1, case_temp2): Remove their decls.
2329 * character.h (ASCII_CHAR_P): Move from here ...
2330 * lisp.h: ... to here, so that the inline functions mentioned
2331 above can use them.
2332
4a6bea26
PE
2333 * dired.c (directory_files_internal_unwind): Now static.
2334
f14b7e14
PE
2335 * fileio.c (file_name_as_directory, directory_file_name):
2336 (barf_or_query_if_file_exists, auto_save_error, auto_save_1):
2337 Now static.
2893f146
PE
2338 (file_name_as_directory): Use const pointers when appropriate.
2339 (Fexpand_file_name): Likewise. In particular, newdir might
2340 point at constant storage, so make it a const pointer.
fd4ead52 2341 (Fmake_directory_internal, Fread_file_name): Remove unused vars.
b14aac08
PE
2342 (Ffile_selinux_context, Fset_file_selinux_context): Fix pointer
2343 signedness issues.
f839df0c
PE
2344 (Fset_file_times, Finsert_file_contents, auto_save_error):
2345 Rename locals to avoid shadowing.
f14b7e14 2346
5716756e 2347 * minibuf.c (choose_minibuf_frame_1): Now static.
62137a95
PE
2348 (Ftry_completion, Fall_completions): Rename or remove locals
2349 to avoid shadowing.
5716756e 2350
b4c3046a
PE
2351 * marker.c (bytepos_to_charpos): Remove; unused.
2352
b45db522
PE
2353 * lisp.h (verify_bytepos, count_markers): New decls,
2354 so that gcc does not warn that these functions aren't declared.
2355
85876d07
PE
2356 * insdel.c (check_markers, make_gap_larger, make_gap_smaller):
2357 (reset_var_on_error, Fcombine_after_change_execute_1): Now static.
f0cb4a60 2358 (CHECK_MARKERS): Redo to avoid gcc -Wempty-body diagnostic.
40ef059e 2359 (copy_text): Remove unused local var.
85876d07 2360
03d78a21 2361 * filelock.c (within_one_second): Now static.
b3dd38ab 2362 (lock_file_1): Rename local to avoid shadowing.
03d78a21 2363
5df8f01b
PE
2364 * buffer.c (fix_overlays_before): Mark locals as initialized.
2365 (fix_start_end_in_overlays): Likewise. This function should be
2366 simplified by using pointers-to-pointers, but that's a different
2367 matter.
b1d876f1 2368 (switch_to_buffer_1): Now static.
8f54f30a
PE
2369 (Fkill_buffer, record_buffer, Fbury_buffer, Fset_buffer_multibyte):
2370 (report_overlay_modification): Rename locals to avoid shadowing.
c3bd59b5 2371
a70072c9 2372 * sysdep.c (system_process_attributes): Rename vars to avoid shadowing.
fbd02d7b 2373 Fix pointer signedness issue.
edced198
PE
2374 (sys_subshell): Mark local as volatile if checking for lint,
2375 to suppress a gcc -Wclobbered warning that does not seem to be right.
15dfd3d9 2376 (MAXPATHLEN): Define only if needed.
a70072c9 2377
a0977c44
PE
2378 * process.c (serial_open, serial_configure): Move decls from here ...
2379 * systty.h: ... to here, so that they can be checked.
2380
a884fdcc
PE
2381 * fns.c (get_random, seed_random): Move extern decls from here ...
2382 * lisp.h: ... to here, so that they can be checked.
2383
604efe86 2384 * sysdep.c (reset_io): Now static.
b8950c94 2385 (wait_for_termination_signal): Remove; unused.
604efe86 2386
38fc62d9
PE
2387 * keymap.c (keymap_parent, keymap_memberp, map_keymap_internal):
2388 (copy_keymap_item, append_key, push_text_char_description):
2389 Now static.
1004a21a 2390 (Fwhere_is_internal): Don't test CONSP (sequences) unnecessarily.
dbbb8427 2391 (DENSE_TABLE_SIZE): Remove; unused.
c1141155
PE
2392 (get_keymap, access_keymap, Fdefine_key, Fwhere_is_internal):
2393 (describe_map_tree):
2394 Rename locals to avoid shadowing.
38fc62d9 2395
2f2650da
PE
2396 * keyboard.c: Declare functions static if they are not used elsewhere.
2397 (echo_char, echo_dash, cmd_error, top_level_2):
2398 (poll_for_input, handle_async_input): Now static.
69a058fa
PE
2399 (read_char, kbd_buffer_get_event, make_lispy_position):
2400 (make_lispy_event, make_lispy_movement, apply_modifiers):
2401 (decode_keyboard_code, tty_read_avail_input, menu_bar_items):
2402 (parse_tool_bar_item, read_key_sequence, Fread_key_sequence):
2403 (Fread_key_sequence_vector): Rename locals to avoid shadowing.
c8a06054 2404 (read_key_sequence, read_char): Mark locals as initialized.
3ac94672 2405 (Fexit_recursive_edit, Fabort_recursive_edit): Mark with NO_RETURN.
2f2650da 2406
a053e86c 2407 * keyboard.h (make_ctrl_char): New decl.
da2f2dd9
PE
2408 (mark_kboards): Move decl here ...
2409 * alloc.c (mark_kboards): ... from here.
a053e86c 2410
4752793e
PE
2411 * lisp.h (force_auto_save_soon): New decl.
2412
74f10ca7 2413 * emacs.c (init_cmdargs): Rename local to avoid shadowing.
244fc23d
PE
2414 (DEFINE_DUMMY_FUNCTION): New macro.
2415 (__do_global_ctors, __do_global_ctors_aux, __do_global_dtors, __main):
2416 Use it.
c03cd23f
PE
2417 (main): Add casts to avoid warnings
2418 if GCC considers string literals to be constants.
74f10ca7 2419
022e70d4
PE
2420 * lisp.h (fatal_error_signal): Add decl, since it's exported.
2421
59d6fe83
PE
2422 * dbusbind.c: Pointer signedness fixes.
2423 (xd_signature, xd_append_arg, xd_initialize):
2424 (Fdbus_call_method, Fdbus_call_method_asynchronously):
2425 (Fdbus_method_return_internal, Fdbus_method_error_internal):
2426 (Fdbus_send_signal, xd_read_message_1, Fdbus_register_service):
2427 (Fdbus_register_signal): Use SSDATA when the context wants char *.
2428
78320123
PE
2429 * dbusbind.c (Fdbus_init_bus): Add cast to avoid warning
2430 if GCC considers string literals to be constants.
49cebcca 2431 (Fdbus_register_service, Fdbus_register_method): Remove unused vars.
78320123 2432
35ac2a97
SM
24332011-03-16 Stefan Monnier <monnier@iro.umontreal.ca>
2434
fb103ca9
SM
2435 * print.c (PRINT_CIRCLE_CANDIDATE_P): New macro.
2436 (print_preprocess, print_object): New macro to fix last change.
2437
35ac2a97
SM
2438 * print.c (print_preprocess): Don't forget font objects.
2439
62973b41
JB
24402011-03-16 Juanma Barranquero <lekktu@gmail.com>
2441
2442 * emacs.c (USAGE3): Doc fixes.
2443
0e48bb22
AS
24442011-03-15 Andreas Schwab <schwab@linux-m68k.org>
2445
2446 * coding.c (detect_coding_iso_2022): Reorganize code to clarify
2447 structure.
2448
7684e57b
JB
24492011-03-14 Juanma Barranquero <lekktu@gmail.com>
2450
2451 * lisp.h (VWindow_system, Qfile_name_history):
2452 * keyboard.h (lispy_function_keys) [WINDOWSNT]:
2453 * w32term.h (w32_system_caret_hwnd, w32_system_caret_height)
2454 (w32_system_caret_x, w32_system_caret_y): Declare extern.
2455
2456 * w32select.c: Don't #include "keyboard.h".
c96bbc66 2457 (run_protected): Add extern declaration for waiting_for_input.
7684e57b
JB
2458
2459 * w32.c (Qlocal, noninteractive1, inhibit_window_system):
2460 * w32console.c (detect_input_pending, read_input_pending)
2461 (encode_terminal_code):
2462 * w32fns.c (quit_char, lispy_function_keys, Qtooltip)
2463 (w32_system_caret_hwnd, w32_system_caret_height, w32_system_caret_x)
2464 (w32_system_caret_y, Qfile_name_history):
2465 * w32font.c (w32font_driver, QCantialias, QCotf, QClang):
2466 * w32inevt.c (reinvoke_input_signal, lispy_function_keys):
2467 * w32menu.c (Qmenu_bar, QCtoggle, QCradio, Qoverriding_local_map)
2468 (Qoverriding_terminal_local_map, Qmenu_bar_update_hook):
2469 * w32proc.c (Qlocal, report_file_error):
2470 * w32term.c (Vwindow_system, updating_frame):
2471 * w32uniscribe.c (initialized, uniscribe_font_driver):
2472 Remove unneeded extern declarations.
2473
2aa46d6c
CY
24742011-03-14 Chong Yidong <cyd@stupidchicken.com>
2475
c96bbc66 2476 * buffer.c (Fmake_indirect_buffer): Fix incorrect assertions.
2aa46d6c 2477
cffc6f3b
CY
24782011-03-13 Chong Yidong <cyd@stupidchicken.com>
2479
2480 * buffer.h (BUF_BEGV, BUF_BEGV_BYTE, BUF_ZV, BUF_ZV_BYTE, BUF_PT)
2481 (BUF_PT_BYTE): Rewrite to handle indirect buffers (Bug#8219).
2482 These macros can no longer be used for assignment.
2483
44f230aa
SM
2484 * buffer.c (Fget_buffer_create, Fmake_indirect_buffer):
2485 Assign struct members directly, instead of using BUF_BEGV etc.
cffc6f3b
CY
2486 (record_buffer_markers, fetch_buffer_markers): New functions for
2487 recording and fetching special buffer markers.
2488 (set_buffer_internal_1, set_buffer_temp): Use them.
2489
2490 * lread.c (unreadchar): Use SET_BUF_PT_BOTH.
2491
2492 * insdel.c (adjust_point): Use SET_BUF_PT_BOTH.
2493
2494 * intervals.c (temp_set_point_both): Use SET_BUF_PT_BOTH.
2495 (get_local_map): Use SET_BUF_BEGV_BOTH and SET_BUF_ZV_BOTH.
2496
2497 * xdisp.c (hscroll_window_tree):
2498 (reconsider_clip_changes): Use PT instead of BUF_PT.
2499
d251f04b
EZ
25002011-03-13 Eli Zaretskii <eliz@gnu.org>
2501
2502 * makefile.w32-in ($(BLD)/editfns.$(O)): Depend on
2503 $(EMACS_ROOT)/lib/intprops.h.
2504
f0c77cd1
PE
25052011-03-13 Paul Eggert <eggert@cs.ucla.edu>
2506
3eca4629
PE
2507 Fix more problems found by GCC 4.5.2's static checks.
2508
7c86ee98
PE
2509 * gtkutil.c (xg_get_pixbuf_from_pixmap): Add cast from char *
2510 to unsigned char * to avoid compiler diagnostic.
b0afc268
PE
2511 (xg_free_frame_widgets): Make it clear that a local variable is
2512 needed only if USE_GTK_TOOLTIP.
01e0b5ad
PE
2513 (gdk_window_get_screen): Make it clear that this macro is needed
2514 only if USE_GTK_TOOLTIP.
1e5524e7
PE
2515 (int_gtk_range_get_value): New function, which avoids a diagnostic
2516 from gcc -Wbad-function-cast.
2517 (xg_set_toolkit_scroll_bar_thumb): Use it.
2518 (xg_tool_bar_callback, xg_tool_item_stale_p): Rewrite to avoid
2519 diagnostic from gcc -Wbad-function-cast.
65dc836c
PE
2520 (get_utf8_string, xg_get_file_with_chooser):
2521 Rename locals to avoid shadowing.
2522 (create_dialog): Move locals to avoid shadowing.
7c86ee98 2523
41729b81
PE
2524 * xgselect.c (xg_select): Remove unused var.
2525
f0c77cd1
PE
2526 * image.c (four_corners_best): Mark locals as initialized.
2527 (gif_load): Initialize transparent_p to zero (Bug#8238).
2528 Mark another local as initialized.
ec6cf4c6 2529 (my_png_error, my_error_exit): Mark with NO_RETURN.
f0c77cd1 2530
ce0ad53d 2531 * image.c (clear_image_cache): Now static.
d5d5a617 2532 (DIM, HAVE_STDLIB_H_1): Remove unused macros.
e22cffbc 2533 (xpm_load): Redo to avoid "discards qualifiers" gcc warning.
77a765fd
PE
2534 (x_edge_detection): Remove unnecessary cast that
2535 gcc -Wbad-function-cast diagnoses.
2037898d 2536 (gif_load): Fix pointer signedness.
6ae141d6
PE
2537 (clear_image_cache, xbm_read_bitmap_data, x_detect_edges):
2538 (jpeg_load, gif_load): Rename locals to avoid shadowing.
ce0ad53d 2539
33383987 25402011-03-12 Paul Eggert <eggert@cs.ucla.edu>
3eca4629 2541
d32df629
PE
2542 Improve quality of tests for time stamp overflow.
2543 For example, without this patch (encode-time 0 0 0 1 1
2544 1152921504606846976) returns the obviously-bogus value (-948597
2545 62170) on my RHEL 5.5 x86-64 host. With the patch, it correctly
2546 reports time overflow. See
2547 <http://lists.gnu.org/archive/html/emacs-devel/2011-03/msg00470.html>.
b8d9bd41
PE
2548 * deps.mk (editfns.o): Depend on ../lib/intprops.h.
2549 * editfns.c: Include limits.h and intprops.h.
2550 (TIME_T_MIN, TIME_T_MAX): New macros.
2551 (time_overflow): Move earlier, to before first use.
2552 (hi_time, lo_time): New functions, for an accurate test for
2553 out-of-range times.
2554 (Fcurrent_time, Fget_internal_run_time, make_time): Use them.
2555 (Fget_internal_run_time): Don't assume time_t fits in int.
2556 (make_time): Use list2 instead of Fcons twice.
2557 (Fdecode_time): More accurate test for out-of-range times.
2558 (check_tm_member): New function.
2559 (Fencode_time): Use it, to test for out-of-range times.
d32df629
PE
2560 (lisp_time_argument): Don't rely on undefined left-shift and
2561 right-shift behavior when checking for time stamp overflow.
8be6f318 2562
fe31d94c
PE
2563 * editfns.c (time_overflow): New function, refactoring common code.
2564 (Fformat_time_string, Fdecode_time, Fencode_time):
2565 (Fcurrent_time_string): Use it.
2566
8be6f318
PE
2567 Move 'make_time' to be next to its inverse 'lisp_time_argument'.
2568 * dired.c (make_time): Move to ...
2569 * editfns.c (make_time): ... here.
2570 * systime.h: Note the move.
2571
09d9db2c 25722011-03-12 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
c47cbdfd 2573
126bc0dc
YM
2574 * fringe.c (update_window_fringes): Remove unused variables.
2575
c47cbdfd
YM
2576 * unexmacosx.c (copy_data_segment): Also copy __got section.
2577 (Bug#8223)
2578
7ac80be9
EZ
25792011-03-12 Eli Zaretskii <eliz@gnu.org>
2580
c96bbc66 2581 * termcap.c [MSDOS]: Include "msdos.h".
058e5dad
EZ
2582 (find_capability, tgetnum, tgetflag, tgetstr, tputs, tgetent):
2583 Constify `char *' arguments and their references according to
2584 prototypes in tparam.h.
2585
ecb0f94d 2586 * deps.mk (termcap.o): Depend on tparam.h and msdos.h.
058e5dad 2587
7ac80be9
EZ
2588 * msdos.c (XMenuAddPane): 3rd argument is `const char *' now.
2589 Adapt all references accordingly.
2590
2591 * msdos.h (XMenuAddPane): 3rd argument is `const char *' now.
2592
ef1fd07e
TT
25932011-03-11 Tom Tromey <tromey@redhat.com>
2594
2595 * buffer.c (syms_of_buffer): Remove obsolete comment.
2596
7ef4b50c
EZ
25972011-03-11 Eli Zaretskii <eliz@gnu.org>
2598
2599 * termhooks.h (encode_terminal_code): Declare prototype.
2600
2601 * msdos.c (encode_terminal_code): Don't declare prototype.
2602
2603 * term.c (encode_terminal_code): Now external again, used by
2604 w32console.c and msdos.c.
2605
44f230aa
SM
2606 * makefile.w32-in ($(BLD)/term.$(O), ($(BLD)/tparam.$(O)):
2607 Depend on $(SRC)/tparam.h, see 2011-03-11T07:24:21Z!eggert@cs.ucla.edu.
7ef4b50c 2608
4b1ec863 26092011-03-11 Paul Eggert <eggert@cs.ucla.edu>
f78faa98 2610
1714f52b 2611 Fix some minor problems found by GCC 4.5.2's static checks.
83316bf4 2612
4b1ec863
PE
2613 * fringe.c (update_window_fringes): Mark locals as initialized
2614 (Bug#8227).
2615 (destroy_fringe_bitmap, init_fringe_bitmap): Now static.
bf60f616 2616
524c7aa6
PE
2617 * alloc.c (mark_fringe_data): Move decl from here ...
2618 * lisp.h (mark_fringe_data) [HAVE_WINDOW_SYSTEM]: ... to here,
2619 to check its interface.
2620 (init_fringe_once): Do not declare unless HAVE_WINDOW_SYSTEM.
2621
a5c0af81 2622 * fontset.c (free_realized_fontset): Now static.
7519b8cd 2623 (Fset_fontset_font): Rename local to avoid shadowing.
cc6e5db1 2624 (fontset_font): Mark local as initialized.
a9a06e0b 2625 (FONTSET_SPEC, FONTSET_REPERTORY, RFONT_DEF_REPERTORY): Remove; unused.
a5c0af81 2626
b4716021
PE
2627 * xrdb.c: Include "xterm.h", to check x_load_resources's interface.
2628
811e9bac 2629 * xselect.c (x_disown_buffer_selections): Remove; not used.
7b83e2f1 2630 (TRACE3) [!defined TRACE_SELECTION]: Remove; not used.
aa0daa9f
PE
2631 (x_own_selection, Fx_disown_selection_internal): Rename locals
2632 to avoid shadowing.
2633 (x_handle_dnd_message): Remove local to avoid shadowing.
811e9bac 2634
7e3ab302
PE
2635 * lisp.h (GCPRO1_VAR, UNGCPRO_VAR): New macros,
2636 so that the caller can use some name other than gcpro1.
2637 (GCPRO1, UNGCPRO): Reimplement in terms of the new macros.
58d2d479
PE
2638 * xfns.c (Fx_create_frame, x_create_tip_frame, Fx_show_tip):
2639 (Fx_backspace_delete_keys_p):
2640 Use them to avoid shadowing, and rename vars to avoid shadowing.
2641 (x_decode_color, x_set_name, x_window): Now static.
6b437900 2642 (Fx_create_frame): Add braces to silence GCC warning.
c0951e53 2643 (Fx_file_dialog, Fx_select_font): Fix pointer signedness.
06b0c8a0
PE
2644 (x_real_positions, xg_set_icon_from_xpm_data, x_create_tip_frame):
2645 Remove unused locals.
7e3ab302
PE
2646 (Fx_create_frame, x_create_tip_frame, Fx_show_tip):
2647 (Fx_backspace_delete_keys_p): Rename locals to avoid shadowing.
2648 Some of these renamings use the new GCPRO1_VAR and UNGCPRO_VAR
2649 macros.
f78faa98 2650
e2b13473
PE
2651 * xterm.h (x_mouse_leave): New decl.
2652
77f23912
PE
2653 * xterm.c (x_copy_dpy_color, x_focus_on_frame, x_unfocus_frame):
2654 Remove unused functions.
cdf4ba58
PE
2655 (x_shift_glyphs_for_insert, XTflash, XTring_bell):
2656 (x_calc_absolute_position): Now static.
7411c686 2657 (XTread_socket): Don't define label "out" unless it's used.
2b07bcff 2658 Don't declare local "event" unless it's used.
ed7bf3a5
PE
2659 (x_iconify_frame, x_free_frame_resources): Don't declare locals
2660 unless they are used.
38d0b34a
PE
2661 (XEMBED_VERSION, xembed_set_info): Don't define unless needed.
2662 (x_fatal_error_signal): Remove; not used.
a6067996
PE
2663 (x_draw_image_foreground, redo_mouse_highlight, XTmouse_position):
2664 (x_scroll_bar_report_motion, handle_one_xevent, x_draw_bar_cursor):
2665 (x_error_catcher, x_connection_closed, x_error_handler):
2666 (x_error_quitter, xembed_send_message, x_iconify_frame):
2667 (my_log_handler): Rename locals to avoid shadowing.
28f1c698 2668 (x_delete_glyphs, x_ins_del_lines): Mark with NO_RETURN.
2a8fade0 2669 (x_connection_closed): Tell GCC not to suggest NO_RETURN.
77f23912 2670
44f230aa
SM
2671 * xfaces.c (clear_face_cache, Fx_list_fonts, Fface_font):
2672 Rename or move locals to avoid shadowing.
6b463e58 2673 (tty_defined_color, merge_face_heights): Now static.
5967d051 2674 (free_realized_faces_for_fontset): Remove; not used.
1e9966ea
PE
2675 (Fx_list_fonts): Mark variable that gcc -Wuninitialized
2676 does not deduce is never used uninitialized.
73719eba
PE
2677 (STRDUPA, LSTRDUPA, FONT_POINT_SIZE_QUANTUM): Remove; not used.
2678 (LFACEP): Define only if XASSERTS, as it's not needed otherwise.
071048a3 2679
426994c3 2680 * terminal.c (store_terminal_param): Now static.
5489860b 2681
032f1620 2682 * xmenu.c (menu_highlight_callback): Now static.
9d66f88e 2683 (set_frame_menubar): Remove unused local.
d4323972 2684 (xmenu_show): Rename parameter to avoid shadowing.
6d1f7fee
PE
2685 (xmenu_show, xdialog_show, xmenu_show): Make local pointers "const"
2686 since they might point to immutable storage.
281585b0
PE
2687 (next_menubar_widget_id): Declare only if USE_X_TOOLKIT,
2688 since it's unused otherwise.
032f1620 2689
367c19e5 2690 * xdisp.c (produce_glyphless_glyph): Initialize lower_xoff.
53df7c11 2691 Add a FIXME, since the code still doesn't look right. (Bug#8215)
9f36b9fd
PE
2692 (Fcurrent_bidi_paragraph_direction): Simplify slightly; this
2693 avoids a gcc -Wuninitialized diagnostic.
0e086e8f 2694 (display_line, BUILD_COMPOSITE_GLYPH_STRING, draw_glyphs):
44a3a108
PE
2695 (note_mouse_highlight): Mark variables that gcc -Wuninitialized
2696 does not deduce are never used uninitialized.
70739cbe 2697
07b48fa9
PE
2698 * lisp.h (IF_LINT): New macro, copied from ../lib-src/emacsclient.c.
2699
8868a238 2700 * xdisp.c (redisplay_window): Rename local to avoid shadowing.
4554d213
PE
2701 * window.c (window_loop, size_window):
2702 (run_window_configuration_change_hook, enlarge_window): Likewise.
8868a238 2703
7e5cf297 2704 * window.c (display_buffer): Now static.
d6550a9f
PE
2705 (size_window): Mark variables that gcc -Wuninitialized
2706 does not deduce are never used uninitialized.
a586633d
PE
2707 * window.h (check_all_windows): New decl, to forestall
2708 gcc -Wmissing-prototypes diagnostic.
5b555da1 2709 * dispextern.h (bidi_dump_cached_states): Likewise.
7e5cf297 2710
f6095868
PE
2711 * charset.h (CHECK_CHARSET_GET_CHARSET): Rename locals to avoid
2712 shadowing.
2713 * charset.c (map_charset_for_dump, Fchar_charset): Likewise.
726929c4
PE
2714 Include <limits.h>.
2715 (Fsort_charsets): Redo min/max calculation to shorten the code a bit
2716 and to avoid gcc -Wuninitialized warning.
89ef49df
PE
2717 (load_charset_map): Mark variables that gcc -Wuninitialized
2718 does not deduce are never used uninitialized.
53df7c11 2719 (load_charset): Abort instead of using uninitialized var (Bug#8229).
f6095868 2720
f38b440c
PE
2721 * coding.c (coding_set_source, coding_set_destination):
2722 Use "else { /* comment */ }" rather than "else /* comment */;"
2723 for clarity, and to avoid gcc -Wempty-body warning.
2735d060
PE
2724 (Fdefine_coding_system_internal): Don't redeclare 'i' inside
2725 a block, when the outer 'i' will do.
2726 (decode_coding_utf_8, decode_coding_utf_16, detect_coding_emacs_mule):
2727 (emacs_mule_char, decode_coding_emacs_mule, detect_coding_iso_2022):
2728 (decode_coding_iso_2022, decode_coding_sjis, decode_coding_big5):
2729 (decode_coding_raw_text, decode_coding_charset, get_translation_table):
2730 (Fdecode_sjis_char, Fdefine_coding_system_internal):
2731 Rename locals to avoid shadowing.
2732 * character.h (FETCH_STRING_CHAR_ADVANCE): Likewise.
e2f1bab9
PE
2733 * coding.c (emacs_mule_char, encode_invocation_designation):
2734 Now static, since they're not used elsewhere.
413bb2db 2735 (decode_coding_iso_2022): Add "default: abort ();" as a safety check.
c4a63b12 2736 (decode_coding_object, encode_coding_object, detect_coding_system):
ee05f961
PE
2737 (decode_coding_emacs_mule): Mark variables that gcc
2738 -Wuninitialized does not deduce are never used uninitialized.
160b01f6
PE
2739 (detect_coding_iso_2022): Initialize a local variable that might
2740 be used uninitialized. Leave a FIXME because it's not clear that
53df7c11 2741 this initialization is needed. (Bug#8211)
5f58e762
PE
2742 (ISO_CODE_LF, ISO_CODE_CR, CODING_ISO_FLAG_EUC_TW_SHIFT):
2743 (ONE_MORE_BYTE_NO_CHECK, UTF_BOM, UTF_16_INVALID_P):
2744 (SHIFT_OUT_OK, ENCODE_CONTROL_SEQUENCE_INTRODUCER):
2745 (ENCODE_DIRECTION_R2L, ENCODE_DIRECTION_L2R):
2746 Remove unused macros.
f38b440c 2747
232b38b9 2748 * category.c (hash_get_category_set): Remove unused local var.
9f3b5e69 2749 (copy_category_table): Now static, since it's not used elsewhere.
d0891610 2750 * character.c (string_count_byte8): Likewise.
232b38b9 2751
fb90da1b
PE
2752 * ccl.c (CCL_WRITE_STRING, CCL_ENCODE_CHAR, Fccl_execute_on_string):
2753 (Fregister_code_conversion_map): Rename locals to avoid shadowing.
2754
fb93dbc2
PE
2755 * chartab.c (copy_sub_char_table): Now static, since it's not used
2756 elsewhere.
5c156ace
PE
2757 (sub_char_table_ref_and_range, char_table_ref_and_range):
2758 Rename locals to avoid shadowing.
bbcd0949 2759 (ASET_RANGE, GET_SUB_CHAR_TABLE): Remove unused macros.
fb93dbc2 2760
7d3b3862 2761 * bidi.c (bidi_check_type): Now static, since it's not used elsewhere.
630d6892 2762 (BIDI_BOB): Remove unused macro.
7d3b3862 2763
6be7d3da
PE
2764 * cm.c (cmgoto): Mark variables that gcc -Wuninitialized does not
2765 deduce are never used uninitialized.
c2ed9c8b 2766 * term.c (encode_terminal_code): Likewise.
6be7d3da 2767
75f8807f 2768 * term.c (encode_terminal_code): Now static. Remove unused local.
72abad34 2769
50938595
PE
2770 * tparam.h: New file.
2771 * term.c, tparam.h: Include it.
2772 * deps.mk (term.o, tparam.o): Depend on tparam.h.
2773 * term.c (tputs, tgetent, tgetflag, tgetnum, tparam, tgetstr):
2774 Move these decls to tparam.h, and make them agree with what
2775 is actually in tparam.c. The previous trick of using incompatible
2776 decls in different modules does not conform to the C standard.
2777 All callers of tparam changed to use tparam's actual API.
2778 * tparam.c (tparam1, tparam, tgoto):
2779 Use const pointers where appropriate.
2780
fbceeba2
PE
2781 * cm.c (calccost, cmgoto): Use const pointers where appropriate.
2782 * cm.h (struct cm): Likewise.
2783 * dispextern.h (do_line_insertion_deletion_costs): Likewise.
2784 * scroll.c (ins_del_costs, do_line_insertion_deletion_costs): Likewise.
2785 * term.c (tty_ins_del_lines, calculate_costs, struct fkey_table):
2786 (term_get_fkeys_1, append_glyphless_glyph, produce_glyphless_glyph):
2787 (turn_on_face, init_tty): Likewise.
2788 * termchar.h (struct tty_display_info): Likewise.
fbceeba2 2789
7f3f1250
PE
2790 * term.c (term_mouse_position): Rename local to avoid shadowing.
2791
e6ca6543
PE
2792 * alloc.c (mark_ttys): Move decl from here ...
2793 * lisp.h (mark_ttys): ... to here, so that it's checked against defn.
2794
c40f8d15
AS
27952011-03-11 Andreas Schwab <schwab@linux-m68k.org>
2796
2797 * .gdbinit (pwinx, xbuffer): Fix access to buffer name.
2798
cfe0661d
JB
27992011-03-09 Juanma Barranquero <lekktu@gmail.com>
2800
2801 * search.c (compile_pattern_1): Remove argument regp, unused since
2802 revid:rms@gnu.org-19941211082627-3x1g1wyqkjmwloig.
2803 (compile_pattern): Don't pass it.
2804
0afb4571
J
28052011-03-08 Jan Djärv <jan.h.d@swipnet.se>
2806
2807 * xterm.h (DEFAULT_GDK_DISPLAY): New define.
2808 (GDK_WINDOW_XID, gtk_widget_get_preferred_size): New defines
2809 for ! HAVE_GTK3.
2810 (GTK_WIDGET_TO_X_WIN): Use GDK_WINDOW_XID.
2811
2812 * xmenu.c (menu_position_func): Call gtk_widget_get_preferred_size.
2813
2814 * gtkutil.c: Include gtkx.h if HAVE_GTK3. If ! HAVE_GTK3, define
2815 gdk_window_get_screen, gdk_window_get_geometry,
2816 gdk_x11_window_lookup_for_display and GDK_KEY_g.
2817 (xg_set_screen): Use DEFAULT_GDK_DISPLAY.
2818 (xg_get_pixbuf_from_pixmap): New function.
2819 (xg_get_pixbuf_from_pix_and_mask): Change parameters from GdkPixmap
2820 to Pixmap, take frame as parameter, remove GdkColormap parameter.
2821 Call xg_get_pixbuf_from_pixmap instead of
2822 gdk_pixbuf_get_from_drawable.
2823 (xg_get_image_for_pixmap): Do not make GdkPixmaps, call
2824 xg_get_pixbuf_from_pix_and_mask with Pixmap parameters instead.
2825 (xg_check_special_colors): Use GtkStyleContext and its functions
2826 for HAVE_GTK3.
2827 (xg_prepare_tooltip, xg_hide_tooltip): Call gdk_window_get_screen.
2828 (xg_prepare_tooltip, create_dialog, menubar_map_cb)
2829 (xg_update_frame_menubar, xg_tool_bar_detach_callback)
44f230aa
SM
2830 (xg_tool_bar_attach_callback, xg_update_tool_bar_sizes):
2831 Call gtk_widget_get_preferred_size.
0afb4571
J
2832 (xg_frame_resized): gdk_window_get_geometry only takes 5
2833 parameters.
44f230aa
SM
2834 (xg_win_to_widget, xg_event_is_for_menubar):
2835 Call gdk_x11_window_lookup_for_display.
0afb4571
J
2836 (xg_set_widget_bg): New function.
2837 (delete_cb): New function.
895009e1 2838 (xg_create_frame_widgets): Connect delete-event to delete_cb.
0afb4571
J
2839 Call xg_set_widget_bg. Only set backgrund pixmap for ! HAVE_GTK3
2840 (xg_set_background_color): Call xg_set_widget_bg.
2841 (xg_set_frame_icon): Call xg_get_pixbuf_from_pix_and_mask.
2842 (xg_create_scroll_bar): vadj is a GtkAdjustment for HAVE_GTK3.
2843 Only call gtk_range_set_update_policy if ! HAVE_GTK3.
2844 (xg_make_tool_item): Only connect xg_tool_bar_item_expose_callback
2845 if ! HAVE_GTK3.
2846 (update_frame_tool_bar): Call gtk_widget_hide.
2847 (xg_initialize): Use GDK_KEY_g.
2848
2849 * xsmfns.c (gdk_set_sm_client_id): Define to gdk_set_sm_client_id
2850 if ! HAVE_GTK3
2851 (x_session_initialize): Call gdk_x11_set_sm_client_id.
2852
2853 * xterm.c (XFillRectangle): Use cairo routines for HAVE_GTK3.
2854 (x_term_init): Disable Xinput(2) with GDK_CORE_DEVICE_EVENTS.
2855 Load ~/emacs.d/gtkrc only for ! HAVE_GTK3.
2856
1c2cc4ef
JB
28572011-03-08 Juanma Barranquero <lekktu@gmail.com>
2858
2859 * w32xfns.c (select_palette): Check success of RealizePalette against
2860 GDI_ERROR, not zero.
2861
33383987 2862See ChangeLog.11 for earlier changes.
aac0c6e3
MR
2863
2864;; Local Variables:
2865;; coding: utf-8
aac0c6e3
MR
2866;; End:
2867
33383987 2868 Copyright (C) 2011 Free Software Foundation, Inc.
aac0c6e3
MR
2869
2870 This file is part of GNU Emacs.
2871
2872 GNU Emacs is free software: you can redistribute it and/or modify
2873 it under the terms of the GNU General Public License as published by
2874 the Free Software Foundation, either version 3 of the License, or
2875 (at your option) any later version.
2876
2877 GNU Emacs is distributed in the hope that it will be useful,
2878 but WITHOUT ANY WARRANTY; without even the implied warranty of
2879 MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
2880 GNU General Public License for more details.
2881
2882 You should have received a copy of the GNU General Public License
2883 along with GNU Emacs. If not, see <http://www.gnu.org/licenses/>.