* s/aix4-2.h (sigmask): No need to undefine it.
[bpt/emacs.git] / src / ChangeLog
CommitLineData
d34d6ffc
GM
12012-07-30 Glenn Morris <rgm@gnu.org>
2
7b8a48e4
GM
3 * s/aix4-2.h (sigmask): No need to undefine it, since syssignal.h
4 does that unconditionally.
5
d34d6ffc
GM
6 * s/freebsd.h, s/gnu-linux.h, s/sol2-6.h, s/unixware.h:
7 Remove empty files.
8
03a660a6
PE
92012-07-30 Paul Eggert <eggert@cs.ucla.edu>
10
11 Export to GDB most of lisp.h's remaining object-like macros.
12 * lisp.h (min, max): Move earlier, because they're used earlier now.
13 (INTMASK, ARRAY_MARK_FLAG, PSEUDOVECTOR_FLAG, VALMASK)
14 (CHAR_TABLE_STANDARD_SLOTS, CHARTAB_SIZE_BITS_0)
15 (CHARTAB_SIZE_BITS_1, CHARTAB_SIZE_BITS_2, CHARTAB_SIZE_BITS_3)
16 (DEFAULT_HASH_SIZE, COMPILED_ARGLIST, COMPILED_BYTECODE)
17 (COMPILED_CONSTANTS, COMPILED_STACK_DEPTH, COMPILED_DOC_STRING)
18 (COMPILED_INTERACTIVE, CHAR_ALT, CHAR_SUPER, CHAR_HYPER, CHAR_SHIFT)
19 (CHAR_CTL, CHAR_META, CHAR_MODIFIER_MASK, CHARACTERBITS)
20 (MANY, UNEVALLED, FLOAT_TO_STRING_BUFSIZE, MAX_ALLOCA):
21 Now constants, for GDB. They need not be macros.
22 (MOST_POSITIVE_FIXNUM, MOST_NEGATIVE_FIXNUM, STRING_BYTES_BOUND):
23 Now constants, for GDB, as well as macros, for static initializers.
24 (CHAR_TABLE_STANDARD_SLOTS, CHAR_TABLE_EXTRA_SLOTS):
25 Move to after the definition of struct Lisp_Char_Table,
26 since the former now needs that type defined.
27 (enum CHARTAB_SIZE_BITS, enum CHAR_TABLE_STANDARD_SLOTS)
28 (enum DEFAULT_HASH_SIZE, enum Lisp_Compiled, enum char_bits)
29 (enum maxargs, enum FLOAT_TO_STRING_BUFSIZE, enum MAX_ALLOCA):
30 New enums, for gdb_make_enums_visible.
31 (GLYPH_MODE_LINE_FACE): Remove; unused.
32 * alloc.c (STRING_BYTES_MAX): Now a constant, now a macro.
33 (gdb_make_enums_visible): Add enum CHARTAB_SIZE_BITS, enum
34 CHAR_TABLE_STANDARD_SLOTS, enum char_bits, enum DEFAULT_HASH_SIZE,
35 enum FLOAT_TO_STRING_BUFSIZE, enum Lisp_Bits, enum Lisp_Compiled,
36 enum maxargs, enum MAX_ALLOCA.
37 (ARRAY_MARK_FLAG_VAL, PSEUDOVECTOR_FLAG_VAL, VALMASK_VAL): Remove.
38 (ARRAY_MARK_FLAG, PSEUDOVECTOR_FLAG, VALMASK): Remove;
39 no longer needed, now that they are done in lisp.h.
40
e499d0ee
DA
412012-07-30 Dmitry Antipov <dmantipov@yandex.ru>
42
43 Cleanup string bytes checking.
44 * alloc.c (GC_STRING_BYTES, CHECK_STRING_BYTES): Remove. Convert
45 all users to STRING_BYTES or string_bytes if GC_CHECK_STRING_BYTES.
46 (check_string_bytes): Define to empty if not GC_CHECK_STRING_BYTES.
47 (check_sblock, compact_small_strings): Simplify.
48
d5040d2d
PE
492012-07-29 Paul Eggert <eggert@cs.ucla.edu>
50
51 * lisp.h (LISP_INT_TAG, LISP_INT1_TAG, LISP_STRING_TAG): Remove.
52 These macros are confusing and no longer need to be defined, as
53 the enum values now suffice. All uses replaced with definiens.
54 (Lisp_Int1, Lisp_String): Define directly; this is clearer.
55
7f259ae6
JB
562012-07-29 Juanma Barranquero <lekktu@gmail.com>
57
58 * makefile.w32-in (LISP_H, $(BLD)/emacs.$(O), $(BLD)/w32inevt.$(O))
59 ($(BLD)/w32console.$(O)): Update dependencies.
60
7e63e0c3
DA
612012-07-29 Dmitry Antipov <dmantipov@yandex.ru>
62
63 Remove HIDE_LISP_IMPLEMENTATION and cleanup cons free list check.
64 * lisp.h (HIDE_LISP_IMPLEMENTATION): Remove as useless for a long
65 time. Adjust users.
66 (CHECK_CONS_LIST): Remove. Convert all users to check_cons_list.
67
ffd817eb
JD
682012-07-29 Jan Djärv <jan.h.d@swipnet.se>
69
70 * lread.c (init_lread): Remove if-statement in ifdef HAVE_NS before
71 setting sitelisp (Bug#12010).
72
417a7a0e
EZ
732012-07-29 Eli Zaretskii <eliz@gnu.org>
74
75 * w32heap.h (OS_9X): Renamed from OS_WINDOWS_95.
76
77 * w32heap.c (cache_system_info):
78 * w32.c (sys_rename):
79 * w32proc.c (find_child_console, sys_kill): All users changed.
80
387d4d92
PE
812012-07-29 Paul Eggert <eggert@cs.ucla.edu>
82
83 * alloc.c (Fgarbage_collect): Indent as per usual Emacs style.
84
55a6cca6
EZ
852012-07-29 Eli Zaretskii <eliz@gnu.org>
86
87 * makefile.w32-in (LISP_H): Add $(NT_INC)/stdalign.h.
88
dbcf001c
DA
892012-07-29 Dmitry Antipov <dmantipov@yandex.ru>
90
91 Cleanup statistics calculation in Fgarbage_collect.
92 * alloc.c (Fgarbage_collect): Rename t1 to meaningful start. Fix
93 zombies percentage calculation. Simplify elapsed time calculation.
94
e2688e4a
DA
952012-07-29 Dmitry Antipov <dmantipov@yandex.ru>
96
97 Generalize marker debugging code under MARKER_DEBUG and use eassert.
98 * insdel.c (CHECK_MARKERS, check_markers_debug_flag): Remove.
99 (gap_left, gap_right, adjust_markers_for_delete, insert_1_both)
100 (insert_from_string_1, insert_from_gap, insert_from_buffer_1)
101 (replace_range, replace_range_2, del_range_2): Change to eassert.
102 * marker.c (byte_char_debug_check): Adjust style.
103
b46a6a83
PE
1042012-07-29 Paul Eggert <eggert@cs.ucla.edu>
105
106 Don't use the abbreviation "win" to refer to Windows (Bug#10421).
107 * regex.c (MAX_BUF_SIZE): Remove some incorrect and
108 long-ago-commented-out code that talks about "WIN32".
109 * w32heap.h (OS_WINDOWS_95): Rename from OS_WIN95.
110 All uses changed.
111
e32a5799
PE
1122012-07-28 Paul Eggert <eggert@cs.ucla.edu>
113
114 Use Gnulib stdalign module (Bug#9772, Bug#9960).
115 * alloc.c (XMALLOC_BASE_ALIGNMENT, GC_POINTER_ALIGNMENT, pure_alloc):
116 Simplify by using alignof.
117 (pure_alloc) [! USE_LSB_TAG]: Don't over-align EMACS_INT values.
118 * lisp.h: Include <stdalign.h>.
119 (GCALIGNMENT): New macro and constant.
120 (DECL_ALIGN): Remove. All uses replaced by alignas (GCALIGNMENT).
121 (USE_LSB_TAG): ifdef on alignas, not on DECL_ALIGN.
122 (stdalign): New macro, if not already defined.
123
df81cd29
EZ
1242012-07-28 Eli Zaretskii <eliz@gnu.org>
125
01bd1b0d
EZ
126 Fix non-ASCII input in non-GUI frames on MS-Windows. (Bug#12055)
127 * w32inevt.c: Include w32inevt.h.
128 (w32_read_console_input): New inline function, calls either
129 ReadConsoleInputA or ReadConsoleInputW, depending on the value of
130 w32_console_unicode_input.
131 (fill_queue): Call w32_read_console_input instead of ReadConsoleInput.
132 (w32_kbd_patch_key, key_event): Use the codepage returned by
133 GetConsoleCP, rather than the ANSI codepage returned by GetLocaleInfo.
134 (key_event): use uChar.UnicodeChar only if
135 w32_console_unicode_input is non-zero.
136
137 * w32console.c: Include w32heap.h.
138 <w32_console_unicode_input>: New global variable.
139 (initialize_w32_display): Set w32_console_unicode_input to 1 on NT
140 family of Windows, zero otherwise.
141
142 * w32inevt.h: Declare w32_console_unicode_input.
143
df81cd29
EZ
144 * xdisp.c (init_iterator): Don't reference tip_frame in a build
145 --without-x. (Bug#11742)
146
c20fdd9e
PE
1472012-07-27 Paul Eggert <eggert@cs.ucla.edu>
148
149 Adjust GDB to reflect pvec_type changes (Bug#12036).
150 * .gdbinit (xvectype, xpr, xbacktrace): Adjust to reflect the
151 2012-07-04 changes to pseudovector representation. Problem
152 reported by Eli Zaretskii in <http://bugs.gnu.org/12036#30>.
153
32770973 1542012-07-27 Michael Albinus <michael.albinus@gmx.de>
e518bc71
MA
155
156 * dbusbind.c (XD_DBUS_VALIDATE_BUS_ADDRESS): Canonicalize session
157 bus address.
158 (xd_close_bus, Fdbus_init_bus): Handle reference counter properly.
159
3438fe21
EZ
1602012-07-27 Eli Zaretskii <eliz@gnu.org>
161
bcfbc9de
EZ
162 * alloc.c (listn): Fix the order the arguments are consed onto the
163 list.
164
3438fe21
EZ
165 * lisp.h (enum constype): Use CONSTYPE_HEAP and CONSTYPE_PURE for
166 enumeration constants, as PURE and HEAP are too general, and clash
167 with other headers and sources, such as gmalloc.c and the
168 MS-Windows system headers. All users changed.
169
eeaea515
DA
1702012-07-27 Dmitry Antipov <dmantipov@yandex.ru>
171
172 Revert last save_excursion_save and save_excursion_restore changes.
173 * alloc.c, editfns.c, marker.c, lisp.h: Revert.
174 Lots of crashes reported by Chong Yidong <cyd@gnu.org>.
175
073c88c2
DA
1762012-07-27 Dmitry Antipov <dmantipov@yandex.ru>
177
178 Fix recently-introduced typos in Windows port.
179 Reported by Martin Rudalics <rudalics@gmx.at>.
180 * w32.c (init_environment): Replace comma with semicolon.
eeaea515 181 * w32fns.c (syms_of_w32fns): Add missing parenthesis.
073c88c2 182
4706125e
PE
1832012-07-27 Paul Eggert <eggert@cs.ucla.edu>
184
185 Improve GDB symbol export (Bug#12036).
186 * .gdbinit (xgetptr, xgetint, xgettype): Set $bugfix in different
187 arms of an 'if', not using conditional expressions; otherwise GDB
188 complains about the types in the unevaluated arm when the argument
189 is an integer literal.
190 (xgetint): Simplify expression.
191 * alloc.c (gdb_make_enums_visible): New constant. This ports to
192 GCC 3.4.2 the export of symbols to GDB. Problem reported by Eli
193 Zaretskii in <http://bugs.gnu.org/12036#13>.
194 * lisp.h (PUBLISH_TO_GDB): Remove. All uses removed. No longer
195 needed now that we have gdb_make_enums_visible.
196 (enum CHECK_LISP_OBJECT_TYPE, enum Lisp_Bits, enum More_Lisp_Bits)
197 (enum enum_USE_LSB_TAG):
198 New enum types, packaging up enums that need to be exported to GDB.
199
694b6c97
DA
2002012-07-27 Dmitry Antipov <dmantipov@yandex.ru>
201
202 Utility function to make a list from specified amount of objects.
203 * lisp.h (enum constype): New datatype.
204 (listn): New prototype.
205 * alloc.c (listn): New function.
206 (Fmemory_use_count, syms_of_alloc): Use it.
207 * buffer.c (syms_of_buffer): Likewise.
208 * callint.c (syms_of_callint): Likewise.
209 * charset.c (define_charset_internal): Likewise.
210 * coding.c (syms_of_coding): Likewise.
211 * keymap.c (syms_of_keymap): Likewise.
212 * search.c (syms_of_search): Likewise.
213 * syntax.c (syms_of_syntax): Likewise.
214 * w32.c (init_environment): Likewise.
215 * w32fns.c (Fw32_battery_status, syms_of_w32fns): Likewise.
216 * xdisp.c (syms_of_xdisp): Likewise.
217 * xfns.c (syms_of_xfns): Likewise.
218
6195f384
DA
2192012-07-27 Dmitry Antipov <dmantipov@yandex.ru>
220
221 Fast save_excursion_save and save_excursion_restore.
222 * lisp.h (struct Lisp_Excursion): New data type.
223 (PVEC_EXCURSION): New pseudovector type.
224 (XEXCURSION, XSETEXCURSION, EXCURSIONP): Convenient macros
225 to deal with it. Adjust comments.
226 (init_marker, attach_marker): New prototype.
227 (unchain_marker): Adjust prototype.
228 * marker.c (attach_marker): Change to global.
229 (init_marker): New function.
230 * alloc.c (Fmake_marker, build_marker): Use it.
231 (build_marker): More easserts.
232 (mark_object): Handle struct Lisp_Excursion.
233 * editfns.c (save_excursion_save, save_excursion_restore):
234 Reimplement to use struct Lisp_Excursion. Add comments.
235
5eceb8fb
PE
2362012-07-26 Paul Eggert <eggert@cs.ucla.edu>
237
238 Fix export of symbols to GDB (Bug#12036).
239 * alloc.c (ARRAY_MARK_FLAG_VAL, PSEUDOVECTOR_FLAG_VAL, VALMASK_VAL)
240 (ARRAY_MARK_FLAG, PSEUDOVECTOR_FLAG, VALMASK): Move these here from
241 emacs.c, as this is a more-suitable home. Had this been done earlier
242 the fix for 12036 would have avoided some of the problems noted in
243 <http://bugs.gnu.org/12036#13> by Eli Zaretskii, as the scope problems
244 would have been more obvious.
562157c8
PE
245 * emacs.c: Do not include <verify.h>; no longer needed.
246 (gdb_CHECK_LISP_OBJECT_TYPE, gdb_DATA_SEG_BITS)
5eceb8fb
PE
247 (gdb_GCTYPEBITS, gdb_USE_LSB_TAG)
248 (CHECK_LISP_OBJECT_TYPE, DATA_SEG_BITS, GCTYPEBITS, USE_LSB_TAG):
249 Remove; now done in lisp.h.
250 * lisp.h (PUBLISH_TO_GDB): New macro.
251 (GCTYPEBITS, USE_LSB_TAG, CHECK_LISP_OBJECT_TYPE, enum pvec_type)
252 (DATA_SEG_BITS): Use it.
253 (GCTYPEBITS, USE_LSB_TAG): Now also an enum, for GDB.
254 (CHECK_LISP_OBJECT_TYPE, DATA_SEG_BITS): Now just an enum, for GDB.
255 * mem-limits.h (EXCEEDS_LISP_PTR): Redo so that DATA_SEG_BITS need
256 not be usable in #if. This simplifies things.
257
d6749401
JB
2582012-07-26 Juanma Barranquero <lekktu@gmail.com>
259
260 * makefile.w32-in ($(BLD)/emacs.$(O)): Update dependencies.
261
1781b9e9
PE
2622012-07-26 Paul Eggert <eggert@cs.ucla.edu>
263
d89518db 264 Simplify export of symbols to GDB (Bug#12036).
1781b9e9
PE
265 * .gdbinit (xgetptr, xgetint, xgettype): Don't use "set $bugfix =
266 $bugfix.i", as this doesn't work (with GDB 7.4.1, anyway).
267 (xgetptr, xgetint, xgettype, xcoding, xcharset, xprintbytestr):
268 Adjust to changes in lisp.h and emacs.c, by using
269 CHECK_LISP_OBJECT_TYPE rather than gdb_use_struct, VALMASK instead
270 of $valmask, DATA_SEG_BITS instead of gdb_data_seg_bits,
271 INTTYPEBITS instead of gdb_gctypebits - 1, USE_LSB_TAG instead of
272 gdb_use_lsb, (1 << GCTYPEBITS) - 1 instead of $tagmask, VALBITS
273 instead of gdb_valbits.
274 (xvectype, xvector, xpr, xprintstr, xbacktrace): Similarly, use
275 PSEUDOVECTOR_FLAG instead of PVEC_FLAG, and ARRAY_MARK_FLAG
276 instead of gdb_array_mark_flag.
277 (xboolvector): Get size from $->size, not $->header.size.
278 Use BOOL_VECTOR_BITS_PER_CHAR rather than mystery constants.
279 (xreload, hook-run, hookpost-run): Remove.
280 * emacs.c: Include <verify.h>.
281 (gdb_use_lsb, gdb_use_struct, gdb_valbits, gdb_gctypebits)
282 (gdb_data_seg_bits, PVEC_FLAG, gdb_array_mark_flag, gdb_pvec_type):
283 Remove.
284 (gdb_CHECK_LISP_OBJECT_TYPE, gdb_DATA_SEG_BITS, gdb_GCTYPEBITS)
285 (gdb_USE_LSB_TAG): New enum constants.
286 (CHECK_LISP_OBJECT_TYPE, DATA_SEG_BITS, GCTYPEBITS, USE_LSB_TAG):
287 Also define these as enum constants, so they're visible to GDB.
288 (ARRAY_MARK_FLAG_VAL, PSEUDOVECTOR_FLAG_VAL, VALMASK_VAL): New macros.
289 (ARRAY_MARK_FLAG, PSEUDOVECTOR_FLAG, VALMASK): Also define these
290 as constants, so they're visible to GDB.
291 * lisp.h (VALBITS, INTTYPEBITS, FIXNUM_BITS, PSEUDOVECTOR_SIZE_BITS)
292 (PSEUDOVECTOR_SIZE_MASK, PVEC_TYPE_MASK, BOOL_VECTOR_BITS_PER_CHAR):
293 Now enum constants, not macros, so they're visible to GDB.
294 (CHECK_LISP_OBJECT_TYPE, DATA_SEG_BITS): Default to 0, as this is
295 more convenient now. All uses changed.
296 (VALMASK) [USE_LSB_TAG]: Also define in this case.
297 * mem-limits.h (EXCEEDS_LISP_PTR): Adjust to DATA_SEG_BITS change.
298
3628596a
DA
2992012-07-26 Dmitry Antipov <dmantipov@yandex.ru>
300
301 Explicitly free restriction data that are not needed anymore.
302 * editfns.c (save_restriction_restore): Free restriction data.
303
7abaf5cc
SM
3042012-07-26 Stefan Monnier <monnier@iro.umontreal.ca>
305
306 * eval.c (Fautoload_do_load): Rename from do_autoload, export to Lisp,
307 add argument, tune behavior, and adjust all callers.
308
71f88e00
PE
3092012-07-25 Paul Eggert <eggert@cs.ucla.edu>
310
311 Use typedef for EMACS_INT, EMACS_UINT.
312 * lisp.h, s/ms-w32.h (EMACS_INT, EMACS_UINT): Use typedefs rather
313 than macros. This simplifies debugging in the usual case, since
314 it lets GDB show addresses as 'EMACS_INT *' rather than 'long int *'
315 and it allows expressions involving EMACS_INT casts.
316 * .gdbinit (xreload): Simplify by using EMACS_INT cast.
317
57ec3034
JD
3182012-07-25 Jan Djärv <jan.h.d@swipnet.se>
319
320 * nsterm.m (ns_read_socket): Return early if there is a modal
321 window (Bug#12043).
322
8137e7b3
MR
3232012-07-25 Martin Rudalics <rudalics@gmx.at>
324
325 * frame.c (Fredirect_frame_focus): In doc-string don't mention
326 that FOCUS-FRAME can be omitted.
327
04e9897c
DA
3282012-07-25 Dmitry Antipov <dmantipov@yandex.ru>
329
330 Adjust buffer text indirection counters at the end of Fkill_buffer.
331 * buffer.c (Fkill_buffer): Adjust indirection counters when the
332 buffer is definitely dead. This should really fix an issue reported
333 by Christoph Scholtes again. (Bug#12007).
334 (init_buffer_once): Initialize indirection counters of
335 buffer_defaults and buffer_local_symbols (for sanity and safety).
336
8a0484e1
EZ
3372012-07-24 Eli Zaretskii <eliz@gnu.org>
338
339 * xdisp.c (init_iterator): Don't compute dimensions of truncation
340 and continuation glyphs on tooltip frames, leave them at zero.
341 Avoids continued lines in tooltips. (Bug#11832)
342
fa691a83
DA
3432012-07-24 Dmitry Antipov <dmantipov@yandex.ru>
344
345 Simplify copy_overlay.
04e9897c 346 * buffer.c (copy_overlay): Simplify. Use build_marker.
fa691a83
DA
347 * lisp.h (struct Lisp_Overlay): Restore comment with minor tweaks.
348
436bc8e0
EZ
3492012-07-23 Eli Zaretskii <eliz@gnu.org>
350
351 * print.c (print_object): Don't crash when a frame's name is nil
352 or invalid. (Bug#12025)
353
354 * window.c (decode_any_window): Disable CHECK_LIVE_FRAME test, as
355 it signals an error when a tooltip frame is being created.
356
d7a7fda3
DA
3572012-07-23 Dmitry Antipov <dmantipov@yandex.ru>
358
359 Cleanup miscellaneous objects allocation and initialization.
360 * alloc.c (allocate_misc): Change to static. Add argument to
361 specify the subtype. Adjust comment and users.
362 (build_overlay): New function.
363 * buffer.c (copy_overlays, Fmake_overlay): Use it.
364 * lisp.h (struct Lisp_Overlay): Remove obsolete comment.
365 (allocate_misc): Remove prototype.
366 (build_overlay): Add prototype.
367
3682012-07-23 Dmitry Antipov <dmantipov@yandex.ru>
372f8ffc
DA
369
370 Swap buffer text indirection counters in Fbuffer_swap_text.
371 * buffer.c (Fbuffer_swap_text): Swap indirections too.
372 This avoids crash reported by Christoph Scholtes at
373 http://lists.gnu.org/archive/html/bug-gnu-emacs/2012-07/msg00785.html.
374
9d7fa573
JD
3752012-07-22 Jan Djärv <jan.h.d@swipnet.se>
376
377 * nsmenu.m (Popdown_data): New struct.
378 (pop_down_menu): p->pointer is Popdown_data. Release the pool and
379 free Popdown_data.
380 (ns_popup_dialog): Use NSAutoreleasePool and pass it to pop_down_menu.
381 (initWithContentRect): Make imgView and contentView non-static
382 and autorelease them. Also autorelease img and matrix (Bug#12005).
383 (dealloc): Remove (Bug#12005).
384
0dd6d66d
DA
3852012-07-22 Dmitry Antipov <dmantipov@yandex.ru>
386
387 Adjust consing_since_gc when objects are explicitly freed.
388 * alloc.c (GC_DEFAULT_THRESHOLD): New macro.
389 (Fgarbage_collect): Use it. Change minimum to 1/10 of default.
390 (free_cons, free_misc): Subtract object size from consing_since_gc.
391
d36d71df
DA
3922012-07-22 Dmitry Antipov <dmantipov@yandex.ru>
393
394 Simplify and cleanup markers positioning code.
395 * marker.c (attach_marker): More useful eassert.
396 (live_buffer, set_marker_internal): New function.
397 (Fset_marker, set_marker_restricted): Use set_marker_internal.
398 (set_marker_both, set_marker_restricted_both): Use live_buffer.
399
fb9ea40f
PE
4002012-07-22 Paul Eggert <eggert@cs.ucla.edu>
401
402 * buffer.h (struct buffer.indirections): Now ptrdiff_t, not int,
403 as it's limited by the amount of memory, not by INT_MAX.
404
2d5c5f7d
EZ
4052012-07-21 Eli Zaretskii <eliz@gnu.org>
406
07fb592e
EZ
407 * keyboard.c (keys_of_keyboard): Bind language-change to 'ignore'
408 in special-event-map. See the discussion at
409 http://lists.gnu.org/archive/html/emacs-devel/2012-06/msg00417.html
410 for the reasons.
411
37a9eac8 412 * w32menu.c (add_menu_item): Cast to ULONG_PTR when assigning
2d5c5f7d
EZ
413 info.dwItemData. Fixes crashes on 64-bit Windows. Suggested by
414 Fabrice Popineau <fabrice.popineau@supelec.fr>.
415
c4328746
JD
4162012-07-21 Jan Djärv <jan.h.d@swipnet.se>
417
418 * nsterm.m (accessibilityAttributeValue): New function. (Bug#11134).
4b17afa7 419 (conversationIdentifier): Return value is NSInteger.
784051c4 420 * nsterm.m (accessibilityAttributeValue): Surround with NS_IMPL_COCOA.
c4328746 421
6e5d1c12
CY
4222012-07-21 Chong Yidong <cyd@gnu.org>
423
424 * window.c (decode_any_window): Signal an error if the window is
425 on a dead frame (Bug#11984).
426
9928463d
DA
4272012-07-20 Dmitry Antipov <dmantipov@yandex.ru>
428
429 Add indirection counting to speed up Fkill_buffer.
430 * buffer.h (struct buffer): New member.
431 * buffer.c (Fget_buffer_create): Set indirection counter to 0.
432 (Fmake_indirect_buffer): Set indirection counter to -1, increment
433 base buffer indirection counter.
434 (compact_buffer): If ENABLE_CHECKING, verify indirection counters.
435 (Fkill_buffer): Adjust indirection counters as needed, don't walk
436 through buffer list if indirection counter is 0.
437
f8643a6b
DA
4382012-07-20 Dmitry Antipov <dmantipov@yandex.ru>
439
440 Extend the value returned by Fgarbage_collect with heap statistics.
441 * alloc.c (Qheap): New symbol.
442 (syms_of_alloc): DEFSYM it.
443 (Fgarbage_collect): If DOUG_LEA_MALLOC, add mallinfo data.
444 (Fmemory_free): Remove.
445 (syms_of_alloc): Don't defsubr it.
446 * buffer.c (Fcompact_buffer): Remove.
447 (syms_of_buffer): Don't defsubr it.
448
dac616ff
DA
4492012-07-20 Dmitry Antipov <dmantipov@yandex.ru>
450
451 Make maybe_gc inline.
452 Verify that inlining is always possible (GCC 4.7.1, -O3 -Winline).
453 * lisp.h (consing_since_gc, gc_relative_threshold)
454 (memory_full_cons_threshold): Revert declaration.
455 (maybe_gc): Remove prototype, define as inline.
456 * alloc.c: Remove old commented-out code.
457 (consing_since_gc, gc_relative_threshold)
458 (memory_full_cons_threshold): Revert to global.
459 (maybe_gc): Remove.
460
d7ea76b4
DA
4612012-07-20 Dmitry Antipov <dmantipov@yandex.ru>
462
463 Simple wrapper for make_unibyte_string, adjust font_open_by_name.
464 * lisp.h (build_unibyte_string): New function.
465 * dosfns.c, fileio.c, fns.c, ftfont.c, process.c:
466 * sysdep.c, w32fns.c, xfns.c: Use it.
467 * font.c (font_open_by_name): Change 2nd and 3rd args to the only arg
468 of type Lisp_Object to avoid redundant calls to make_unibyte_string.
469 Adjust users accordingly.
470 * font.h (font_open_by_name): Adjust prototype.
471
765e61e3
DA
4722012-07-20 Dmitry Antipov <dmantipov@yandex.ru>
473
474 Cleanup calls to Fgarbage_collect.
475 * lisp.h (maybe_gc): New prototype.
476 (consing_since_gc, gc_relative_threshold, memory_full_cons_threshold):
477 Remove declarations.
478 * alloc.c (maybe_gc): New function.
479 (consing_since_gc, gc_relative_threshold, memory_full_cons_threshold):
480 Make them static.
481 * bytecode.c (MAYBE_GC): Use maybe_gc.
482 * eval.c (eval_sub, Ffuncall): Likewise.
483 * keyboard.c (read_char): Likewise. Adjust call to maybe_gc
484 to avoid dependency from auto-save feature.
485
52b852c7
PE
4862012-07-19 Paul Eggert <eggert@cs.ucla.edu>
487
488 * buffer.h (FOR_EACH_BUFFER): Rename from 'for_each_buffer'.
489 (FOR_EACH_PER_BUFFER_OBJECT_AT): Rename from
490 'for_each_per_buffer_object_at'.
491 All uses changed. It's better to use upper-case for macros that
492 cannot be implemented as functions, to give the reader a clue
493 that they're special.
494
5db81e33
SM
4952012-07-19 Stefan Monnier <monnier@iro.umontreal.ca>
496
497 * alloc.c (Fgarbage_collect): Tweak docstring.
498
5b835e1d
DA
4992012-07-19 Dmitry Antipov <dmantipov@yandex.ru>
500
501 Tweak the value returned from Fgarbage_collect again.
502 * alloc.c (Fgarbage_collect): New return value, as confirmed in
503 http://lists.gnu.org/archive/html/emacs-devel/2012-07/msg00418.html.
504 Adjust documentation.
505 (total_vector_bytes): Rename to total_vector_slots, adjust
506 accounting.
507 (total_free_vector_bytes): Rename to total_free_vector_slots,
508 adjust accounting.
509 (Qstring_bytes, Qvector_slots): New symbols.
510 (syms_of_alloc): DEFSYM them.
511
9cd47b72
DA
5122012-07-19 Dmitry Antipov <dmantipov@yandex.ru>
513
514 Buffer compaction primitive which may be used from Lisp.
515 * buffer.c (compact_buffer, Fcompact_buffer): New function.
516 (syms_of_buffer): Register Fcompact_buffer.
517 * alloc.c (Fgarbage_collect): Use compact_buffer.
518 * buffer.h (compact_buffer): New prototype.
519 (struct buffer_text): New member.
520
d17337e5
DA
5212012-07-19 Dmitry Antipov <dmantipov@yandex.ru>
522
523 New macro to iterate over all buffers, miscellaneous cleanups.
524 * lisp.h (all_buffers): Remove declaration.
525 * buffer.h (all_buffers): Add declaration, with comment.
526 (for_each_buffer): New macro.
527 * alloc.c (Fgarbage_collect, mark_object): Use it.
528 * buffer.c (Fkill_buffer, Fbuffer_swap_text, Fset_buffer_multibyte)
529 (init_buffer): Likewise.
530 * data.c (Fset_default): Likewise.
531 * coding.c (code_conversion_restore): Remove redundant check
532 for dead buffer.
533 * buffer.c (Fkill_buffer): Likewise. Remove obsolete comment.
534
60cfd278
AS
5352012-07-18 Andreas Schwab <schwab@linux-m68k.org>
536
537 Fix bug that created negative-length intervals.
538 * intervals.c (merge_interval_right, merge_interval_left):
539 Do not zero out this interval if it is absorbed by its children,
540 as this interval's total length doesn't change in that case. See
541 <http://lists.gnu.org/archive/html/emacs-devel/2012-07/msg00403.html>.
542
d06714cb
PE
5432012-07-18 Paul Eggert <eggert@cs.ucla.edu>
544
83713154
PE
545 * alloc.c (Fmake_bool_vector): Fix off-by-8 bug
546 when invoking (make-bool-vector N t) and N is a positive
547 multiple of 8 -- the last 8 bits were mistakenly cleared.
548
d06714cb
PE
549 Remove some struct layout assumptions in bool vectors.
550 * alloc.c (bool_header_size): New constant.
551 (header_size, word_size): Move earlier, as they're now used earlier.
552 Use 'word_size' in a few more places, where it's appropriate.
553 (Fmake_bool_vector, sweep_vectors): Don't assume that there is no
554 padding before the data member of a bool vector.
555 (sweep_vectors): Use PSEUDOVECTOR_TYPEP, in an eassert, rather
556 than doing the check by hand with an abort ().
557
464d5a5e
SM
5582012-07-18 Stefan Monnier <monnier@iro.umontreal.ca>
559
5fbc0409
SM
560 * eval.c (Fdefvar): Don't check constants since we only set the var if
561 it's not yet defined anyway (bug#11904).
562
464d5a5e
SM
563 * lisp.h (last_undo_boundary): Declare new var.
564 * keyboard.c (command_loop_1): Set it.
565 * cmds.c (Fself_insert_command): Use it to only remove boundaries that
566 were auto-added by the command loop (bug#11774).
567
8dc2e44a
AS
5682012-07-18 Andreas Schwab <schwab@linux-m68k.org>
569
570 * w32font.c (Qsymbol): Remove local definition.
571 (syms_of_w32font): Don't DEFSYM it.
572
169925ec
DA
5732012-07-18 Dmitry Antipov <dmantipov@yandex.ru>
574
575 Fix sweep_vectors to handle large bool vectors correctly.
576 * alloc.c (sweep_vectors): Account total_vector_bytes for
577 bool vectors larger than VBLOCK_BYTES_MAX.
578
5fbfb018
CY
5792012-07-18 Chong Yidong <cyd@gnu.org>
580
581 * frame.c (x_set_frame_parameters): Revert bogus change introduced
582 in 2012-05-25 commit by Paul Eggert (Bug#11738).
583
3ab6e069
DA
5842012-07-18 Dmitry Antipov <dmantipov@yandex.ru>
585
586 Return more descriptive data from Fgarbage_collect.
587 Suggested by Stefan Monnier in
588 http://lists.gnu.org/archive/html/emacs-devel/2012-07/msg00369.html.
589 * alloc.c (bounded_number): New function.
590 (total_buffers, total_vectors): New variable.
591 (total_string_size): Rename to total_string_bytes, adjust users.
592 (total_vector_size): Rename to total_vector_bytes, adjust users.
593 (sweep_vectors): Account total_vectors and total_vector_bytes.
594 (Fgarbage_collect): New return value. Adjust documentation.
595 (gc_sweep): Account total_buffers.
596 (Fmemory_free, Fmemory_use_counts): Use bounded_number.
597 (VECTOR_SIZE): Remove.
598 * data.c (Qfloat, Qvector, Qsymbol, Qstring, Qcons): Make global.
599 (Qinterval, Qmisc): New symbols.
600 (syms_of_data): Initialize them.
601 * lisp.h (Qinterval, Qsymbol, Qstring, Qmisc, Qvector, Qfloat)
602 (Qcons, Qbuffer): New declarations.
603
6d02fe5b
PE
6042012-07-17 Paul Eggert <eggert@cs.ucla.edu>
605
606 * alloc.c (Fmemory_free): Account for memory-free's own storage.
607 Round up, not down. Improve doc.
608
b7ffe040
DA
6092012-07-17 Dmitry Antipov <dmantipov@yandex.ru>
610
611 Restore old code in allocate_string_data to avoid Faset breakage.
612 Reported by Julien Danjou <julien@danjou.info> in
613 http://lists.gnu.org/archive/html/emacs-devel/2012-07/msg00371.html.
614 * alloc.c (allocate_string_data): Restore old code with minor
615 adjustments, fix comment to explain this subtle issue.
616
4dc7c8d5
SM
6172012-07-17 Eli Zaretskii <eliz@gnu.org>
618
619 Remove FILE_SYSTEM_CASE.
620 * s/msdos.h (FILE_SYSTEM_CASE): Don't define.
621
622 * fileio.c (FILE_SYSTEM_CASE): Don't define.
623 (Ffile_name_directory, Fexpand_file_name): Don't use FILE_SYSTEM_CASE.
624 Fixes problems on MS-DOS with Vtemp_file_name_pattern when
625 call-process-region passes it through expand-file-name.
626
627 * dired.c (file_name_completion): Don't use FILE_SYSTEM_CASE.
628
6292012-07-17 Andreas Schwab <schwab@linux-m68k.org>
630
631 Fix crash when creating indirect buffer (Bug#11917)
632 * buffer.c (buffer_lisp_local_variables): Add argument CLONE.
633 Don't handle unbound variables specially if non-zero.
634 (Fbuffer_local_variables): Pass zero.
635 (clone_per_buffer_values): Pass non-zero.
636
6372012-07-17 Andreas Schwab <schwab@linux-m68k.org>
638
639 * gnutls.c (emacs_gnutls_handshake): Revert last change. Add QUIT
640 to make the loop interruptible.
641
6422012-07-17 Andreas Schwab <schwab@linux-m68k.org>
643
644 * gnutls.c (emacs_gnutls_handshake): Only retry if
645 GNUTLS_E_INTERRUPTED.
646
cce7fefc
DA
6472012-07-17 Dmitry Antipov <dmantipov@yandex.ru>
648
649 Cleanup and convert miscellaneous checks to eassert.
650 * alloc.c (mark_interval): Fix comment, partially rephrase
651 old comment from intervals.h (see below).
652 * intervals.c (find_interval, adjust_intervals_for_insertion)
653 (delete_interval, adjust_intervals_for_deletion)
654 (graft_intervals_into_buffer, temp_set_point_both, copy_intervals):
655 Convert to eassert.
656 (adjust_intervals_for_insertion, make_new_interval):
657 Remove obsolete and unused code.
658 * intervals.h (struct interval): Remove obsolete comment.
659 * textprotp.c (erase_properties): Remove unused code.
660 (Fadd_text_properties, set_text_properties_1, Fremove_text_properties)
661 (Fremove_list_of_text_properties): Convert to eassert.
662
9ea10cc3
CY
6632012-07-17 Chong Yidong <cyd@gnu.org>
664
665 * editfns.c (Finsert_char): Doc fix.
666
3900d5de
DA
6672012-07-17 Dmitry Antipov <dmantipov@yandex.ru>
668
669 Fix previous change to make Fmemory_free always accurate.
670 * alloc.c (make_interval): Update total_free_intervals.
671 (make_float): Likewise for total_free_floats.
672 (free_cons, Fcons): Likewise for total_free_conses.
673 (SETUP_ON_FREE_LIST, allocate_vector_from_block):
674 Likewise for total_free_vector_bytes.
675 (Fmake_symbol): Likewise for total_free_symbols.
676 (bytes_free): Remove.
677
7098646f
DA
6782012-07-17 Dmitry Antipov <dmantipov@yandex.ru>
679
680 Simple free memory accounting feature.
681 * alloc.c (bytes_free, total_free_vector_bytes): New variable.
682 (sweep_vectors): Accumulate size of free vectors.
683 (Fgarbage_collect): Setup bytes_free.
684 (Fmemory_free): New function.
685 (syms_of_alloc): Register it.
686
22657b40
DA
6872012-07-17 Dmitry Antipov <dmantipov@yandex.ru>
688
689 Cleanup overlays checking.
690 * buffer.h (OVERLAY_VALID): Remove as useless synonym of OVERLAYP.
691 * buffer.c (overlay_touches_p, recenter_overlay_lists): Change to
692 eassert and OVERLAYP.
693 (sort_overlays): Change to use OVERLAYP.
694
ddfc8813
RK
6952012-07-16 René Kyllingstad <Rene@Kyllingstad.com> (tiny change)
696
697 * editfns.c (Finsert_char): Make it interactive, and make the
698 second arg optional. Copy interactive spec and docstring from
699 ucs-insert.
700
7c26cf3c
PE
7012012-07-17 Paul Eggert <eggert@cs.ucla.edu>
702
703 * floatfns.c (Fabs): Do not wrap fabs inside IN_FLOAT (Bug#11913).
704 Unlike the other wrapped functions, fabs has an unspecified
705 effect on errno.
706
5d127af9
JD
7072012-07-16 Jan Djärv <jan.h.d@swipnet.se>
708
709 * nsterm.m (keyDown): Interpret flags without left/right bits
710 as the left key (Bug#11670).
711
6a0dd1d7
DA
7122012-07-16 Dmitry Antipov <dmantipov@yandex.ru>
713
714 Remove empty and useless init functions.
715 * lisp.h (init_character_once, init_fns, init_image)
716 (init_filelock, init_sound): Remove prototype.
717 * character.c (init_character_once): Remove.
718 * filelock.c (init_filelock): Likewise.
719 * fns.c (init_fns): Likewise.
720 * image.c (init_image): Likewise.
721 * sound.c (init_sound): Likewise.
722 * emacs.c (main): Adjust accordingly.
723
7a6136fd
DA
7242012-07-16 Dmitry Antipov <dmantipov@yandex.ru>
725
726 * gtkutil.h: Tiny cleanups.
727 (use_old_gtk_file_dialog): Remove useless declaration.
728 (xg_uses_old_file_dialog): Add suggested const attribute.
729
ce811ad9
EZ
7302012-07-15 Eli Zaretskii <eliz@gnu.org>
731
732 * bidi.c (MAX_STRONG_CHAR_SEARCH): New macro.
733 (bidi_paragraph_init): Use it to limit search forward for a strong
734 directional character in abnormally large paragraphs full of
735 neutral or weak characters. (Bug#11943)
736
c9adfeaa
SF
7372012-07-15 Stefano Facchini <stefano.facchini@gmail.com> (tiny change)
738
739 * gtkutil.c (xg_create_tool_bar): Apply "primary-toolbar" style to
740 the toolbar (Bug#9451).
741 (xg_make_tool_item): Give the widget event box a transparent
742 background.
743
fff62aa9
DA
7442012-07-15 Dmitry Antipov <dmantipov@yandex.ru>
745
746 Cleanup basic allocation variables and functions.
747 * alloc.c (ignore_warnings, init_intervals, init_float)
748 (init_cons, init_symbol, init_marker): Remove.
749 (interval_block_index): Initialize to INTERVAL_BLOCK_SIZE.
750 (float_block_index): Initialize to FLOAT_BLOCK_SIZE.
751 (cons_block_index): Initialize to CONS_BLOCK_SIZE.
752 (symbol_block_size): Initialize to SYMBOL_BLOCK_SIZE.
753 (marker_block_index): Initialize to MARKER_BLOCK_SIZE.
754 (staticidx, init_alloc_once, init_strings, free_ablock):
755 Remove redundant initialization.
756 * fns.c (init_weak_hash_tables): Remove.
757 * lisp.h (init_weak_hash_tables): Remove prototype.
758
9730daca
DA
7592012-07-15 Dmitry Antipov <dmantipov@yandex.ru>
760
761 Use zero_vector where appropriate.
762 * alloc.c (zero_vector): Define as Lisp_Object. Adjust users
763 accordingly.
764 * lisp.h (zero_vector): New declaration.
765 * font.c (null_vector): Remove.
766 (syms_of_font): Remove initialization and staticpro.
767 (font_list_entities, font_find_for_lface): Change to use zero_vector.
768 * keymap.c (Faccessible_keymaps): Likewise.
769
2e2d2a13
LL
7702012-07-15 Leo Liu <sdl.web@gmail.com>
771
772 * fringe.c: Fix typo in comments.
773
cd276f6e
LL
7742012-07-14 Leo Liu <sdl.web@gmail.com>
775
776 * fringe.c: Add a new bitmap exclamation-mark.
777
5a1131d9
EZ
7782012-07-14 Eli Zaretskii <eliz@gnu.org>
779
780 * gmalloc.c (GMALLOC_INHIBIT_VALLOC): Don't reference.
781
782 * s/msdos.h (BSD_SYSTEM, DATA_START, GC_SETJMP_WORKS, HAVE_MOUSE)
783 (HAVE_MENUS): Don't define, defined by editing config.in with
784 msdos/sed2v2.inp.
785 (GMALLOC_INHIBIT_VALLOC): Don't define.
786 (MODE_LINE_BINARY_TEXT): Remove, not used anymore.
787
22e983b7
JB
7882012-07-14 Juanma Barranquero <lekktu@gmail.com>
789
790 * s/ms-w32.h (GC_SETJMP_WORKS, GC_MARK_STACK): Set in nt/config.nt.
791
5b3f250f
GM
7922012-07-14 Glenn Morris <rgm@gnu.org>
793
794 * s/aix4-2.h, s/freebsd.h, s/gnu-linux.h, s/hpux10-20.h:
795 * s/irix6-5.h, s/netbsd.h, s/sol2-6.h, s/unixware.h:
796 Let configure set GC_SETJMP_WORKS, GC_MARK_STACK.
797
33d63ff4
GM
7982012-07-13 Glenn Morris <rgm@gnu.org>
799
5b633342
GM
800 * s/gnu-linux.h (GC_MARK_SECONDARY_STACK): Let configure set it.
801
33d63ff4
GM
802 * s/usg5-4-common.h (SETUP_SLAVE_PTY): Let configure set it.
803 * s/irix6-5.h (SETUP_SLAVE_PTY): No more need to unset it.
804
b55b9f85
JD
8052012-07-13 Jan Djärv <jan.h.d@swipnet.se>
806
0dc8cf50
JD
807 * nsterm.m (uRect): Only define if NS_IMPL_GNUSTEP.
808 (x_free_frame_resources): Pass x_free_frame_resources to NSTRACE.
809 (ns_lisp_to_color, ns_string_to_lispmod, ns_term_init)
810 (ns_term_shutdown, requestService, initFrameFromEmacs): Use SSDATA
811 where appropriate.
812 (ns_exec_path, ns_load_path, changeFont): Put () around assignment used
813 as boolean expression.
814 (x_set_window_size): Remove unused variable toolbar.
815 (ns_get_color_default, ns_mod_to_lisp): Remove.
816 (ns_mouse_position): Remove unused variables xchar and ychar.
817 (ns_compute_glyph_string_overhangs): Remove unused variable face.
818 (ns_set_vertical_scroll_bar): Remove unused variable count.
819 (ns_delete_terminal): Remove unused variable i.
820 (ns_term_init): Remove unused variables r, g and b.
821 (mouseDown): Remove unused variable window.
822 (windowDidResize): Move definition of theWindow inside NS_IMPL_GNUSTEP.
823 (initFrameFromEmacs): Remove unused variable vbextra.
824 (mouseEntered): Remove unused variables p and dpyinfo.
825 (mouseExited): Remove unused variables p and r.
826 (ns_define_frame_cursor, ns_clear_frame_area)
827 (ns_draw_window_cursor, ns_initialize_display_info): Make static.
828 (menuDown): Assign [sender tag] to variable and cast the variable.
829
830 * nsterm.h (menuDown): Add id as type to argument sender.
831 (ns_display_info_for_name): Add Lisp_Object argument.
832 (ns_term_init): Add Lisp_Object argument.
833 (ns_map_event_to_object): Add void argument.
834 (ns_string_from_pasteboard, ns_string_to_pasteboard): Add correct
835 prototype with arguments and only declare if __OBJC__.
836 (nxatoms_of_nsselect): Add void argument.
837 (ns_lisp_to_cursor_type): Add Lisp_Object argument.
838 (ns_alloc_autorelease_pool): Add void argument.
839 (ns_release_autorelease_pool): Add void* argument.
840 (ns_get_defaults_value): Add const char* argument.
841
842 * nsmenu.m (ns_update_menubar, ns_menu_show, process_dialog)
843 (initFromContents): Use SSDATA where appropriate.
844 (ns_update_menubar): Add braces to ambigous if-else.
845 (initWithTitle): Put () around assignment in if statement.
846 (ns_menu_show): Remove unused variables window and keymap.
847 (update_frame_tool_bar): Remove unused variable selected_p.
848 (initWithContentRect): Remove unused variable this_cmd_name.
849
850 * nsimage.m (ns_load_image, allocInitFromFile): Use SSDATA where
851 appropriate.
852 (setXBMColor): Remove unused variable len.
853 (setPixmapData): Put () around assignment in loop statement.
854
855 * nsfont.m (ns_get_family, ns_lang_to_script, ns_otf_to_script)
856 (ns_registry_to_script, ns_get_req_script, nsfont_open): Use SSDATA
857 where appropriate.
858 (ns_get_covering_families, ns_findfonts, nsfont_list_family): Put ()
859 around assignment in loop statement.
860 (nsfont_open): Remove unused variable i.
861 (nsfont_open): Remove unused variable len.
862 (nsfont_draw): Remove unused variable cs.
863
864 * nsfns.m (x_set_icon_name, ns_set_name_internal)
865 (ns_set_name_as_filename, ns_implicitly_set_icon_type)
866 (x_set_icon_type, ns_lisp_to_cursor_type, Fns_read_file_name)
867 (Fns_get_resource, Fns_set_resource, Fx_open_connection)
868 (Fns_font_name, Fns_perform_service)
869 (Fns_convert_utf8_nfd_to_nfc, ns_do_applescript)
870 (Fns_do_applescript, Fx_show_tip): Use SSDATA where appropriate.
871 (ns_set_name): Remove unused variable view.
872 (x_set_menu_bar_lines): Remove unused variable olines.
873 (x_set_tool_bar_lines): Remove unused variable root_window.
874 (Fns_list_colors): Put () around assignment in while statement.
875 (Fns_perform_service): Remove unused variable len.
876 (Fns_display_usable_bounds): Remove unused variable top.
877 (syms_of_nsfns): Remove unused variable i.
878
b55b9f85
JD
879 * nsmenu.m (ns_update_menubar): Exchange place of argument 2 and 3 to
880 memcpy (Bug#11907).
881
ed9265fc 8822012-07-13 Kalle Kankare <kalle.kankare@iki.fi> (tiny change)
2277de02
JD
883
884 * image.c (Fimagemagick_types): Initialize ex with GetExceptionInfo
885 and free it with DestroyExceptionInfo (Bug#11558).
886
ef099b57
JB
8872012-07-13 Juanma Barranquero <lekktu@gmail.com>
888
889 * s/ms-w32.h (FIRST_PTY_LETTER, HAVE_SOCKETS): Move to nt/config.nt.
890 (HAVE_ATTRIBUTE_ALIGNED, HAVE_C99_STRTOLD, HAVE___BUILTIN_UNWIND_INIT):
891 Set here, not in nt/config.nt.
892
ea814a5d
EZ
8932012-07-13 Eli Zaretskii <eliz@gnu.org>
894
895 * xdisp.c (move_it_in_display_line_to): On GUI terminals, allow
896 cursor overflow into the last glyph on display line when the right
897 fringe is off. (Bug#11832)
898
1a952767
PE
8992012-07-13 Paul Eggert <eggert@cs.ucla.edu>
900
901 * xdisp.c (produce_special_glyphs): Now static.
902 * dispextern.h (produce_special_glyphs): Remove decl.
903
983188fd
GM
9042012-07-13 Glenn Morris <rgm@gnu.org>
905
32fb4bb6
GM
906 * s/bsd-common, s/cygwin.h: Remove empty files.
907 * s/freebsd.h, s/netbsd.h: Do not include bsd-common.h.
908
983188fd
GM
909 * s/usg5-4-common.h (USG, USG5):
910 * s/template.h (USG5, USG, HPUX, BSD4_2, BSD_SYSTEM):
911 * s/sol2-6.h (SOLARIS2):
912 * s/irix6-5.h (IRIX6_5):
913 * s/hpux10-20.h (USG, USG5, HPUX):
914 * s/gnu-linux.h (USG, GNU_LINUX):
915 * s/freebsd.h (BSD_SYSTEM):
916 * s/darwin.h (BSD4_2, BSD_SYSTEM, DARWIN_OS):
917 * s/cygwin.h (CYGWIN):
918 * s/bsd-common.h (BSD_SYSTEM, BSD4_2):
919 * s/aix4-2.h (USG, USG5, _AIX): Move "system type" macros to configure.
920
d1e68667 9212012-07-13 BT Templeton <bpt@hcoop.net> (tiny change)
24ef80ae
PE
922
923 * nsfont.m (ns_charset_covers): Don't abort if no bitmap (Bug#11853).
24ef80ae 924
6de0e799
GM
9252012-07-13 Glenn Morris <rgm@gnu.org>
926
739ae010
GM
927 * s/usg5-4-common.h (NSIG_MINIMUM): Let configure set it.
928
dbee5793
GM
929 * s/gnu-linux.h, s/irix6-5.h: Let configure set ULIMIT_BREAK_VALUE.
930
6de0e799
GM
931 * process.c (init_process_emacs): Replace MIN_PTY_KERNEL_VERSION.
932 * s/darwin.h (MIN_PTY_KERNEL_VERSION): Remove single-use macro.
933
b82da769
GM
9342012-07-12 Glenn Morris <rgm@gnu.org>
935
4fae5a7a 936 * s/darwin.h (SYSTEM_PURESIZE_EXTRA): Move to configure.
b82da769
GM
937
938 * process.c (init_process_emacs): Rename from init_process.
939 The old name is also the name of a Mach system call.
940 * lisp.h, emacs.c: Update for this name change.
941 * nsgui.h, sysselect.h, s/darwin.h: Remove workaround that is no
942 longer needed.
943
5a979817
EZ
9442012-07-12 Eli Zaretskii <eliz@gnu.org>
945
946 * xdisp.c (insert_left_trunc_glyphs): Fix incorrect size in
947 memmove call that removes glyphs covered by the left truncation
948 glyph. Improve commentary.
949 (display_line): Fix display of continuation glyphs on GUI frames
950 when the right fringe is turned off and variable-size fonts are
951 used in the window. Move the code that appends a stretch glyph to
952 produce_special_glyphs, so that it could be used for truncation
953 and continuation glyphs alike.
954 (produce_special_glyphs) [HAVE_WINDOW_SYSTEM]: Produce a stretch
955 glyph of a suitably computed width, to align the special glyphs at
956 the window margin. Code moved from display_line. (Bug#11832)
957
3e91a053
GM
9582012-07-12 Glenn Morris <rgm@gnu.org>
959
ba9e4b84
GM
960 * s/aix4-2.h, s/hpux10-20.h: Let configure set NO_EDITRES.
961
962 * s/gnu-linux.h, s/hpux10-20.h:
963 Do not unconditionally define HAVE_XRMSETDATABASE.
964
3e91a053
GM
965 * s/gnu-linux.h (UNIX98_PTYS): Let configure set it.
966
b300b1f4
PE
9672012-07-12 Paul Eggert <eggert@cs.ucla.edu>
968
969 Fix typos that broke OS X build.
970 Reported by Randal L. Schwartz in
971 <http://lists.gnu.org/archive/html/emacs-devel/2012-07/msg00225.html>.
972 * nsterm.m (ns_timeout): Add missing local decl.
973 (ns_get_color): snprintf -> sprintf, to fix typo.
974
6e777848
GM
9752012-07-12 Glenn Morris <rgm@gnu.org>
976
3f922c37
GM
977 * src/s/aix4-2.h, src/s/cygwin.h, src/s/darwin.h:
978 * src/s/gnu-linux.h, src/s/hpux10-20.h, src/s/irix6-5.h:
979 * src/s/sol2-6.h, src/s/unixware.h, src/s/usg5-4-common.h:
980 Move PTY_NAME_SPRINTF, PTY_TTY_NAME_SPRINTF to configure.
981
0ab7b23a
GM
982 * s/cygwin.h, s/darwin.h, s/gnu-linux.h, s/irix6-5.h:
983 Move PTY_OPEN to configure.
984
6e777848
GM
985 * s/aix4-2.h, s/bsd-common.h, s/cygwin.h, s/darwin.h:
986 * s/gnu-linux.h, s/hpux10-20.h, s/irix6-5.h, s/template.h:
987 * s/usg5-4-common.h: Move FIRST_PTY_LETTER, PTY_ITERATION to configure.
988
4a7edc24
DA
9892012-07-12 Dmitry Antipov <dmantipov@yandex.ru>
990
991 Use empty_unibyte_string where applicable.
992 * keyboard.c (parse_tool_bar_item): Use empty_unibyte_string.
993 * lread.c (read1): Likewise.
994 * xsettings.c (syms_of_xsettings): Likewise.
995
308aab79
GM
9962012-07-12 Glenn Morris <rgm@gnu.org>
997
42bd1719
GM
998 * s/cygwin.h (G_SLICE_ALWAYS_MALLOC):
999 * s/freebsd.h (BROKEN_PTY_READ_AFTER_EAGAIN):
7ccad002
GM
1000 * s/irix6-5.h (SETPGRP_RELEASES_CTTY, PREFER_VSUSP):
1001 * s/hpux10-20.h (RUN_TIME_REMAP):
1002 * s/bsd-common.h (TABDLY): Move to configure.
1003
1004 * s/hpux10-20.h, s/sol2-6.h: Move XOS_NEEDS_TIME_H to configure.
1005
1006 * s/bsd-common.h, s/darwin.h: Move TAB3 to configure.
1007
ea0bbd17 1008 * s/aix4-2.h (BROKEN_FIONREAD, BROKEN_SIGAIO, BROKEN_SIGPTY)
42bd1719 1009 (BROKEN_SIGPOLL, BROKEN_GET_CURRENT_DIR_NAME): Let configure set them.
ea0bbd17
GM
1010
1011 * s/darwin.h (NO_ABORT, NO_MATHERR): Let configure set them.
51c3b9b4 1012
308aab79
GM
1013 * s/bsd-common.h, s/cygwin.h, s/gnu-linux.h, s/irix6-5.h:
1014 * s/template.h: Move NARROWPROTO to configure.
1015
ee1cf5cf
GM
10162012-07-11 Glenn Morris <rgm@gnu.org>
1017
30fe9bf4
GM
1018 * s/gnu-linux.h, s/sol2-6.h: No longer define POSIX,
1019 unused since 2011-01-17 change to systty.h.
1020
ee1cf5cf
GM
1021 * s/aix4-2.h, s/bsd-common.h, s/cygwin.h, s/darwin.h, s/gnu-linux.h:
1022 * s/hpux10-20.h, s/template.h, s/usg5-4-common.h:
1023 Move HAVE_PTYS and HAVE_SOCKETS to configure.
1024
63e47e07
PE
10252012-07-11 Paul Eggert <eggert@cs.ucla.edu>
1026
1027 * s/sol2-6.h (HAVE_LIBKSTAT): Remove. (Bug#11914)
1028
c43fb4c3
GM
10292012-07-11 Glenn Morris <rgm@gnu.org>
1030
1031 * s/darwin.h, s/gnu-linux.h, s/template.h:
1032 Move INTERRUPT_INPUT to configure.
1033
e8df9267
DA
10342012-07-11 Dmitry Antipov <dmantipov@yandex.ru>
1035
1036 Minor adjustments to interning code.
1037 * lisp.h (intern, intern_c_string): Redefine as static inline
1038 wrappers for intern_1 and intern_c_string_1, respectively.
1039 (intern_1, intern_c_string_1): Rename prototypes.
2bce5643
DA
1040 * lread.c (intern_1, intern_c_string_1, oblookup): Simplify
1041 Vobarray checking.
e8df9267
DA
1042 * font.c (font_intern_prop): Likewise. Adjust comment.
1043 * w32font.c (intern_font_name): Likewise.
1044
34348bd4
AS
10452012-07-11 Andreas Schwab <schwab@linux-m68k.org>
1046
d96a1e0c
AS
1047 * gnutls.c (Fgnutls_boot): Properly parse :keylist argument.
1048
34348bd4
AS
1049 * coding.c (Fdefine_coding_system_internal): Use XCAR/XCDR instead
1050 of Fcar/Fcdr if possible.
1051 * font.c (check_otf_features): Likewise.
1052 * fontset.c (Fnew_fontset): Likewise.
1053 * gnutls.c (Fgnutls_boot): Likewise.
1054 * minibuf.c (read_minibuf): Likewise.
1055 * msdos.c (IT_set_frame_parameters): Likewise.
1056 * xmenu.c (Fx_popup_dialog): Likewise.
1057 * w32menu.c (Fx_popup_dialog): Likewise.
1058
c8add24e
GM
10592012-07-11 Glenn Morris <rgm@gnu.org>
1060
4b575b3c
GM
1061 * s/bsd-common.h, s/cygwin.h: No need to undefine INTERRUPT_INPUT,
1062 since nothing has defined it on these platforms.
1063
09f4e3b0
GM
1064 * s/aix4-2.h, s/bsd-common.h, s/cygwin.h, s/gnu-linux.h:
1065 * s/irix6-5.h: Move SIGNALS_VIA_CHARACTERS to configure.
1066
172bedef
GM
1067 * s/aix4-2.h, s/bsd-common.h, s/cygwin.h, s/darwin.h:
1068 * s/gnu-linux.h, s/hpux10-20.h, s/template.h, s/usg5-4-common.h:
1069 Move CLASH_DETECTION to configure.
1070
249685df
GM
1071 * s/gnu.h: Remove file, which is now empty.
1072
c8add24e
GM
1073 * s/gnu.h, s/gnu-linux.h:
1074 Move GNU_LIBRARY_PENDING_OUTPUT_COUNT to configure.
1075
b41253a3
JW
10762012-07-11 John Wiegley <johnw@newartisans.com>
1077
1078 * alloc.c (mark_memory): Guard the "no_address_safety_analysis"
1079 function attribute, so we only use it if it exists in the
1080 compiler.
1081
d923b542
DA
10822012-07-11 Dmitry Antipov <dmantipov@yandex.ru>
1083
1084 Avoid call to strlen in fast_c_string_match_ignore_case.
1085 * search.c (fast_c_string_match_ignore_case): Change to use
1086 length argument. Adjust users accordingly.
1087 * lisp.h (fast_c_string_match_ignore_case): Adjust prototype.
1088
5ebbef1d
PE
10892012-07-11 Paul Eggert <eggert@cs.ucla.edu>
1090
bb352260
PE
1091 Assume mkdir, rmdir.
1092 * sysdep.c (mkdir) [!HAVE_MKDIR]: Remove.
1093 * sysdep.c (rmdir) [!HAVE_RMDIR]: Remove.
1094
57054ddd
PE
1095 Assume rename.
1096 * sysdep.c (rename) [!HAVE_RENAME]: Remove.
1097
b747d3f7
PE
1098 Assume perror.
1099 * s/hpux10-20.h (HAVE_PERROR): Remove.
1100 * sysdep.c (perror) [HPUX && !HAVE_PERROR]:
1101 Remove dummy definition, as this problem was obsolete long ago.
1102
5ebbef1d
PE
1103 Assume strerror.
1104 * sysdep.c (strerror) [!HAVE_STRERROR && !WINDOWSNT]: Remove.
1105
984e7f30
DA
11062012-07-11 Dmitry Antipov <dmantipov@yandex.ru>
1107
1108 Avoid calls to strlen in font processing functions.
1109 * font.c (font_parse_name, font_parse_xlfd, font_parse_fcname)
d923b542 1110 (font_open_by_name): Change to use length argument. Adjust
984e7f30 1111 users accordingly.
d923b542
DA
1112 * font.h (font_open_by_name, font_parse_xlfd, font_unparse_xlfd):
1113 Adjust prototypes.
1114 * xfont.c (xfont_decode_coding_xlfd, font_unparse_xlfd):
1115 Change to return ptrdiff_t.
984e7f30
DA
1116 (xfont_list_pattern, xfont_match): Use length returned by
1117 xfont_decode_coding_xlfd.
1118 * xfns.c (x_default_font_parameter): Omit useless xstrdup.
1119
20e94fdd
GM
11202012-07-11 Glenn Morris <rgm@gnu.org>
1121
9d596af3
GM
1122 * s/darwin.h, s/freebsd.h, s/netbsd.h:
1123 Move DONT_REOPEN_PTY to configure.
1124
20e94fdd
GM
1125 * sound.c (DEFAULT_SOUND_DEVICE) [!WINDOWSNT]:
1126 * s/netbsd.h (DEFAULT_SOUND_DEVICE): Let configure set it.
1127
e99a530f
PE
11282012-07-10 Paul Eggert <eggert@cs.ucla.edu>
1129
22ffb973
PE
1130 Remove "#define unix" that is no longer needed (Bug#11905).
1131 * s/aix4-2.h (unix): Remove; no longer needed.
1132
e9a9ae03
PE
1133 EMACS_TIME simplification (Bug#11875).
1134 This replaces macros (which typically do not work in GDB)
1135 with functions, typedefs and enums, making the code easier to debug.
1136 The functional style also makes code easier to read and maintain.
1137 * systime.h: Include <sys/time.h> on all hosts, not just if
1138 WINDOWSNT, since 'struct timeval' is needed in general.
1139 (EMACS_TIME): Now a typedef, not a macro.
1140 (EMACS_TIME_RESOLUTION, LOG10_EMACS_TIME_RESOLUTION): Now constants,
1141 not macros.
1142 (EMACS_SECS, EMACS_NSECS, EMACS_TIME_SIGN, EMACS_TIME_VALID_P)
1143 (EMACS_TIME_FROM_DOUBLE, EMACS_TIME_TO_DOUBLE, EMACS_TIME_EQ)
1144 (EMACS_TIME_NE, EMACS_TIME_GT, EMACS_TIME_GE, EMACS_TIME_LT)
1145 (EMACS_TIME_LE): Now functions, not macros.
1146 (EMACS_SET_SECS, EMACS_SET_NSECS, EMACS_SET_SECS_NSECS)
1147 (EMACS_SET_USECS, EMACS_SET_SECS_USECS): Remove these macros,
1148 which are not functions. All uses rewritten to use:
1149 (make_emacs_time): New function.
1150 (EMACS_SECS_ADDR, EMACS_SET_INVALID_TIME, EMACS_GET_TIME)
1151 (EMACS_ADD_TIME, EMACS_SUB_TIME): Remove these macros, which are
1152 not functions. All uses rewritten to use the following, respectively:
1153 (emacs_secs_addr, invalid_emacs_time, get_emacs_time)
1154 (add_emacs_time, sub_emacs_time): New functions.
ed9265fc 1155 * atimer.c: Don't include <sys/time.h>, as "systime.h" does this.
e9a9ae03
PE
1156 * fileio.c (Fcopy_file):
1157 * xterm.c (XTflash): Get the current time closer to when it's used.
1158 * makefile.w32-in ($(BLD)/atimer.$(O)): Update dependencies.
1159
ffacb126
PE
1160 * bytecode.c (targets): Suppress -Woverride-init warnings.
1161
e99a530f
PE
1162 Simplify by avoiding confusing use of strncpy etc.
1163 * doc.c (Fsnarf_documentation):
1164 * fileio.c (Ffile_name_directory, Fsubstitute_in_file_name):
1165 * frame.c (Fmake_terminal_frame):
1166 * gtkutil.c (get_utf8_string):
1167 * lread.c (openp):
1168 * nsmenu.m (ns_update_menubar):
1169 * regex.c (regerror):
1170 Prefer memcpy to strncpy and strncat when either will do.
1171 * fileio.c (Fsubstitute_in_file_name):
1172 * keyboard.c (MULTI_LETTER_MOD, parse_modifiers_uncached)
1173 (menu_separator_name_p):
1174 * nsmenu.m (ns_update_menubar):
1175 Prefer memcmp to strncmp when either will do.
1176 * nsterm.m: Include <ftoastr.h>.
1177 (ns_get_color):
1178 * s/gnu-linux.h, s/sol2-6.h, s/unixware.h (PTY_TTY_NAME_SPRINTF):
1179 Prefer snprintf to strncpy.
1180 * nsterm.m (ns_term_init):
1181 * widget.c (set_frame_size) [0]: Prefer xstrdup to xmalloc + strncpy.
1182 * nsterm.m (ns_term_init):
1183 Avoid the need for strncpy, by using build_string or
1184 make_unibyte_string directly. Use dtoastr, not snprintf.
1185 * process.c (Fmake_network_process): Diagnose service names that
1186 are too long, rather than silently truncating them or creating
1187 non-null-terminated names.
1188 (Fnetwork_interface_info): Likewise, for interface names.
1189 * sysdep.c (system_process_attributes) [GNU_LINUX]:
1190 Prefer sprintf to strncat.
1191 * xdisp.c (debug_method_add) [GLYPH_DEBUG]:
1192 Prefer vsnprintf to vsprintf + strncpy.
1193
c59592b3
GM
11942012-07-10 Glenn Morris <rgm@gnu.org>
1195
1196 * dispnew.c (PENDING_OUTPUT_COUNT) [!__GNU_LIBRARY__]:
1197 Clarify fallback case.
1198
7d7bbefd
DA
11992012-07-10 Dmitry Antipov <dmantipov@yandex.ru>
1200
1201 Use XCAR and XCDR instead of Fcar and Fcdr where possible.
1202 * callint.c, coding.c, doc.c, editfns.c, eval.c, font.c, fontset.c,
1203 * frame.c, gnutls.c, minibuf.c, msdos.c, textprop.c, w32fns.c,
d923b542 1204 * w32menu.c, window.c, xmenu.c: Change to use XCAR and XCDR
7d7bbefd
DA
1205 where argument type is known to be a Lisp_Cons.
1206
3a4c8000
TT
12072012-07-10 Tom Tromey <tromey@redhat.com>
1208
1209 * bytecode.c (BYTE_CODE_THREADED): New macro.
1210 (BYTE_CODES): New macro. Replaces all old byte-code defines.
1211 (enum byte_code_op): New type.
1212 (CASE, NEXT, FIRST, CASE_DEFAULT, CASE_ABORT): New macros.
1213 (exec_byte_code): Use them. Use token threading when applicable.
1214
2a0213a6
DA
12152012-07-10 Dmitry Antipov <dmantipov@yandex.ru>
1216
1217 Optimize pure C strings initialization.
1218 * lisp.h (make_pure_string): Fix prototype.
1219 (build_pure_c_string): New function, defined as static inline. This
1220 provides a better opportunity to optimize away calls to strlen when
1221 the function is called with compile-time constant argument.
1222 * alloc.c (make_pure_c_string): Fix comment. Change to add nchars
1223 argument, adjust users accordingly. Use build_pure_c_string where
1224 appropriate.
1225 * buffer.c, coding.c, data.c, dbusbind.c, fileio.c, fontset.c, frame.c,
1226 * keyboard.c, keymap.c, lread.c, search.c, syntax.c, w32fns.c, xdisp.c,
1227 * xfaces.c, xfns.c, xterm.c: Use build_pure_c_string where appropriate.
1228
cb1caeaf
DA
12292012-07-10 Dmitry Antipov <dmantipov@yandex.ru>
1230
1231 Avoid calls to strlen in miscellaneous functions.
1232 * buffer.c (init_buffer): Use precalculated len, adjust if needed.
1233 * font.c (Ffont_xlfd_name): Likewise. Change to call make_string.
1234 * lread.c (openp): Likewise.
1235
c293e30c
DA
12362012-07-10 Dmitry Antipov <dmantipov@yandex.ru>
1237
1238 Avoid calls to strlen in path processing functions.
1239 * fileio.c (file_name_as_directory): Add comment. Change to add
1240 srclen argument and return the length of result. Adjust users
1241 accordingly.
1242 (directory_file_name): Fix comment. Change to add srclen argument,
cb1caeaf 1243 swap 1st and 2nd arguments to obey the common convention. Adjust
c293e30c
DA
1244 users accordingly.
1245 * filelock.c (fill_in_lock_file_name): Avoid calls to strlen.
1246
9e059e3f
GM
12472012-07-10 Glenn Morris <rgm@gnu.org>
1248
d02eb359
GM
1249 * s/cygwin.h, s/darwin.h, s/freebsd.h, s/netbsd.h, s/unixware.h:
1250 Move PENDING_OUTPUT_COUNT definition to configure.
1251
882cf227
GM
1252 * s/irix6-5.h (DATA_START, DATA_SEG_BITS):
1253 * s/hpux10-20.h (DATA_SEG_BITS, DATA_START):
1254 * s/gnu.h (DATA_START): Move definitions to configure.
1255
af6e839f
GM
1256 * s/irix6-5.h (SETUP_SLAVE_PTY, PTY_NAME_SPRINTF): Drop ifdef guards.
1257 We include usg5-4-common.h, which defines them both.
1258
40289a12
GM
1259 * s/gnu.h: Don't include fcntl.h (every file in Emacs that uses
1260 O_RDONLY already includes it).
1261
9e059e3f
GM
1262 Stop ns builds setting the EMACSLOADPATH environment variable.
1263 * nsterm.m (ns_load_path): Rename from ns_init_paths.
1264 Now it does not set EMACSLOADPATH, just returns the load-path string.
1265 * nsterm.h: Update accordingly.
1266 * lread.c [HAVE_NS]: Include nsterm.h.
1267 (init_lread) [HAVE_NS]: Use ns_load_path.
1268 * emacs.c (main) [HAVE_NS]: No longer call ns_init_paths.
1269
7c4e8ec0
GM
12702012-07-09 Glenn Morris <rgm@gnu.org>
1271
d4f600ff
GM
1272 * s/gnu.h (SIGNALS_VIA_CHARACTERS): No need to define it here,
1273 since the included bsd-common.h does so.
1274
cbb31951
GM
1275 Stop ns builds setting the EMACSPATH environment variable.
1276 * nsterm.m (ns_exec_path): New function, split from ns_init_paths.
1277 (ns_init_paths): Do not set EMACSPATH.
1278 * nsterm.h (ns_exec_path): Add it.
1279 * callproc.c (init_callproc_1, init_callproc) [HAVE_NS]:
1280 Use ns_exec_path.
1281
7c4e8ec0
GM
1282 * nsterm.m, nsterm.h (ns_etc_directory): Fix type, empty return.
1283
26bccfae
PE
12842012-07-09 Paul Eggert <eggert@cs.ucla.edu>
1285
a0bee46f
PE
1286 * process.c (wait_reading_process_output): 'waitchannels' was unset
1287 when read_kbd || !NILP (wait_for_cell); fix this.
1288
5994c183
PE
1289 Add GCC-style 'const' attribute to functions that can use it.
1290 * character.h (char_resolve_modifier_mask):
1291 * keyboard.h (make_ctrl_char):
1292 * lisp.h (multibyte_char_to_unibyte, multibyte_char_to_unibyte_safe)
1293 (init_character_once, next_almost_prime, init_fns, init_image)
1294 (flush_pending_output, init_sound):
1295 * mem-limits.h (start_of_data):
1296 * menu.h (finish_menu_items):
1297 Add ATTRIBUTE_CONST.
1298 * emacs.c (DEFINE_DUMMY_FUNCTION):
1299 Declare the dummy function with ATTRIBUTE_CONST.
1300 * lisp.h (Fbyteorder, Fmax_char, Fidentity):
1301 Add decls with ATTRIBUTE_CONST.
1302
26bccfae
PE
1303 Minor improvements to make_formatted_string.
1304 * alloc.c (make_formatted_string): Prefer int to ptrdiff_t
1305 where int is good enough, as vsprintf returns an int.
1306 * lisp.h (make_formatted_string): Add ATTRIBUTE_FORMAT_PRINTF.
1307
a8290ec3
DA
13082012-07-09 Dmitry Antipov <dmantipov@yandex.ru>
1309
1310 Use make_formatted_string to avoid double length calculation.
1311 * lisp.h (make_formatted_string): New prototype.
1312 * alloc.c (make_formatted_string): New function.
1313 * buffer.c (Fgenerate_new_buffer_name): Use it.
1314 * dbus.c (syms_of_dbusbind): Likewise.
1315 * editfns.c (Fcurrent_time_zone): Likewise.
1316 * filelock.c (get_boot_time): Likewise.
1317 * frame.c (make_terminal_frame, set_term_frame_name)
1318 (x_report_frame_params): Likewise.
1319 * image.c (gs_load): Likewise.
1320 * minibuf.c (get_minibuffer): Likewise.
1321 * msdos.c (dos_set_window_size): Likewise.
1322 * process.c (make_process): Likewise.
1323 * xdisp.c (ensure_echo_area_buffers): Likewise.
1324 * xsettings.c (apply_xft_settings): Likewise.
1325
d01ba2f1
GM
13262012-07-09 Glenn Morris <rgm@gnu.org>
1327
1328 Stop ns builds polluting the environment with EMACSDATA, EMACSDOC.
1329 * nsterm.m (ns_etc_directory): New function, split from ns_init_paths.
1330 (ns_init_paths): Do not set EMACSDATA, EMACSDOC.
1331 * nsterm.h (ns_etc_directory): Add it.
1332 * callproc.c [HAVE_NS]: Include nsterm.h.
1333 (init_callproc_1, init_callproc) [HAVE_NS]: Use ns_etc_directory.
1334
f1f924b6
DA
13352012-07-09 Dmitry Antipov <dmantipov@yandex.ru>
1336
1337 Move marker debugging code under MARKER_DEBUG.
1338 * marker.c (MARKER_DEBUG): Move marker debugging code under
1339 #ifdef MARKER_DEBUG because byte_char_debug_check is too slow
1340 for bootstrap with --enable-checking (~3x slowdown reported
1341 by Juanma Barranquero <lekktu@gmail.com>).
1342 (verify_bytepos): Move under #ifdef MARKER_DEBUG.
1343
ab531b66
PE
13442012-07-08 Paul Eggert <eggert@cs.ucla.edu>
1345
1346 * systime.h (EMACS_SUB_TIME): Clarify behavior with unsigned time_t.
1347 See <http://bugs.gnu.org/11825#29>.
1348
c4b3bc8a
EZ
13492012-07-08 Eli Zaretskii <eliz@gnu.org>
1350
1351 * xdisp.c (fill_glyphless_glyph_string): If the face of the glyph
1352 has no font, use the frame's font. (Bug#11813)
3434fe8a
EZ
1353 (display_line): Add commentary about displaying truncation glyphs
1354 on GUI frames.
1355 (produce_special_glyphs): Move here from term.c.
1356
1357 * term.c (produce_special_glyphs): Move to xdisp.c.
1358
1359 * dispextern.h (produce_special_glyphs): Move prototype to xdisp.c
1360 section.
c4b3bc8a 1361
b676b881
AS
13622012-07-07 Andreas Schwab <schwab@linux-m68k.org>
1363
f17c5273
AS
1364 * xdisp.c (display_line): Avoid warning about implicit declaration
1365 of FRAME_FONT.
1366
298819b9
AS
1367 * frame.c (get_frame_param): Define only if HAVE_WINDOW_SYSTEM.
1368
b676b881
AS
1369 * lisp.h: Remove empty conditional.
1370
6045c4fd
PE
13712012-07-07 Paul Eggert <eggert@cs.ucla.edu>
1372
b3350bf9
PE
1373 * lread.c (load_path_check): Now static.
1374
6045c4fd
PE
1375 Fix some minor --with-ns problems found by static checking.
1376 * frame.c (Ftool_bar_pixel_width) [!FRAME_TOOLBAR_WIDTH]:
1377 (x_set_font) [!HAVE_X_WINDOWS]:
1378 * image.c (xpm_load_image) [HAVE_NS]:
1379 (x_to_xcolors) [!HAVE_X_WINDOWS && !HAVE_NTGUI]:
1380 (x_disable_image) [!HAVE_NS && !HAVE_NTGUI]:
1381 Remove unused local.
1382 (Fx_parse_geometry) [HAVE_NS]: Don't return garbage.
1383 (xpm_load_image) [HAVE_NS && !HAVE_XPM]: Remove unused label.
1384 * image.c (x_create_bitmap_from_file) [HAVE_NS]:
1385 (xpm_load_image, xpm_load) [HAVE_NS && !HAVE_XPM]:
1386 * nsselect.m (symbol_to_nsstring, ns_string_to_pasteboard_internal):
1387 * xfaces.c (Fx_load_color_file) [!HAVE_X_WINDOWS]:
1388 Fix pointer signedness problem.
1389 * xfaces.c (FRAME_X_FONT_TABLE):
1390 * xterm.h (FRAME_X_FONT_TABLE): Remove unused, incompatible macros.
1391
929e7845
GM
13922012-07-07 Glenn Morris <rgm@gnu.org>
1393
1394 * lread.c (load_path_check): New function, split from init_lread.
1395 (init_lread): Reorganize. Motivation:
1396 If EMACSLOADPATH is set, check/warn about that rather than the
1397 defaults, which we are not going to use. Hence we can remove
1398 the turn_off_warning and WINDOWSNT || HAVE_NS tests.
1399 Don't warn if site-lisp directories are missing.
1400 If not installed, start from a blank load-path, since
1401 PATH_LOADSEARCH refers to the eventual installation directories.
1402
58dd0aa4
EZ
14032012-07-07 Eli Zaretskii <eliz@gnu.org>
1404
1405 Support truncation and continuation glyphs on GUI frames, when
1406 fringes are disabled. (Bug#11832)
1407 * xdisp.c (init_iterator): Get dimensions of truncation and
1408 continuation glyphs even if on GUI frames. Adjust
1409 it->last_visible_x on GUI frames when the left or right fringes,
1410 or both, are absent.
1411 (start_display, move_it_in_display_line_to): Handle the case of a
1412 GUI frame without a fringe to display continuation or truncation
1413 glyphs.
1414 (insert_left_trunc_glyphs): Support GUI frames: make sure
1415 truncation glyphs overwrite enough glyphs from the current line to
1416 have sufficient space in pixels.
1417 (display_line): Support truncation and continuation glyphs on GUI
1418 frames. If some spare pixels are left on the line after inserting
1419 the truncation glyphs, fill that space with a stretch glyph of a
1420 suitably computed width.
1421
1422 * term.c (produce_special_glyphs): Call PRODUCE_GLYPHS, not
1423 produce_glyphs, to support GUI sessions.
1424
31571fd7
PE
14252012-07-07 Paul Eggert <eggert@cs.ucla.edu>
1426
5a16b9bc
PE
1427 * sysdep.c (ULLONG_MAX): Define if not already defined (Bug#11781).
1428
f3047c75
PE
1429 * sysdep.c (list_system_processes): Port to NetBSD-current (Bug#11797).
1430
31571fd7
PE
1431 Do not require float-time's arg to fit in time_t (Bug#11825).
1432 This works better on hosts where time_t is unsigned, and where
1433 float-time is applied to the (negative) difference between two times.
1434 * editfns.c (decode_time_components): Last arg is now double *,
1435 not int *, and means to store all the result as a double, without
1436 worrying about whether the seconds part fits in time_t.
1437 All callers changed.
1438 (lisp_time_argument): Remove last int * arg, as it's no longer needed.
1439 All callers changed.
1440 (Ffloat_time): Do not fail merely because the specified time falls
1441 outside of time_t range.
1442
4516fbef
GM
14432012-07-07 Glenn Morris <rgm@gnu.org>
1444
1445 * s/darwin.h (HAVE_RES_INIT, HAVE_LIBRESOLV):
1446 * s/hpux10-20.h (HAVE_RINT, HAVE_RANDOM):
1447 * s/unixware.h (HAVE_GETWD): Move undefs to configure (effectively).
1448
07adc2c6
JB
14492012-07-07 Juanma Barranquero <lekktu@gmail.com>
1450
1451 * makefile.w32-in (DISPEXTERN_H, $(BLD)/regex.$(O)):
1452 Update dependencies.
1453
1454 * s/ms-w32.h [_MSC_VER]: Remove strcasecmp, strncasecmp.
1455
fd573f31
PE
14562012-07-06 Paul Eggert <eggert@cs.ucla.edu>
1457
fee5959d
PE
1458 Use c_strcasecmp for ASCII case-insensitive comparison (Bug#11786).
1459 * dispextern.h, nsfns.m, nsterm.m: Include <c-strcase.h>.
1460 * dispextern.h (xstrcasecmp): Rewrite using c_strcasecmp.
1461 * nsfns.m (x_get_string_resource): Use c_strncasecmp, not strncasecmp.
1462 * nsterm.m (ns_default): Use c_strcasecmp, not strcasecmp.
1463 * xfaces.c (xstrcasecmp) [!HAVE_STRCASECMP]: Remove.
1464
fd573f31
PE
1465 * xfont.c (compare_font_names): Redo to omit the need for casts.
1466
ddadbc0e
AS
14672012-07-06 Andreas Schwab <schwab@linux-m68k.org>
1468
fca8d6b6
AS
1469 * xfns.c (Fx_change_window_property): Doc fix.
1470 * w32fns.c (Fx_change_window_property): Doc fix.
1471
ddadbc0e
AS
1472 * w32fns.c (Fx_window_property): Accept the same arguments as the
1473 X Windows version. Doc fix.
1474 * xfns.c (Fx_window_property): Doc fix. (Bug#11870)
1475
ed9265fc 14762012-07-06 Juanma Barranquero <lekktu@gmail.com>
f247498e
JB
1477 Eli Zaretskii <eliz@gnu.org>
1478
1479 * s/ms-w32.h: Settings not specific to Windows moved to nt/config.nt.
1480 Windows-specific code from nt/config.nt moved here.
1481 Obsolete settings removed.
1482
216ee680
PE
14832012-07-06 Paul Eggert <eggert@cs.ucla.edu>
1484
1485 * process.c: Avoid unnecessary calls to gettime.
1486 (wait_reading_process_output): Don't get the time of day
1487 when gobbling data immediately and not waiting, as there's no need
1488 for it in that case. This removes a FIXME.
1489
bdd091e4
JD
14902012-07-06 Jan Djärv <jan.h.d@swipnet.se>
1491
1492 * gtkutil.c (xg_event_is_for_scrollbar): Assign gwin when HAVE_GTK3
1493 is defined (Bug#11768).
1494
9d44f8ce
DA
14952012-07-06 Dmitry Antipov <dmantipov@yandex.ru>
1496
1497 Fix marker debugging code.
1498 * marker.c (byte_char_debug_check): Do not perform the check
1499 if buffer is not multibyte.
090bd7cb
JB
1500 (buf_charpos_to_bytepos, buf_bytepos_to_charpos):
1501 Call byte_char_debug_check with correct arguments.
9d44f8ce 1502
90fc4786
DA
15032012-07-06 Dmitry Antipov <dmantipov@yandex.ru>
1504
1505 Compile marker debugging code only if ENABLE_CHECKING is defined.
090bd7cb
JB
1506 * marker.c (byte_char_debug_check, count_markers):
1507 Use only if ENABLE_CHECKING is defined.
90fc4786
DA
1508 (byte_debug_flag): Remove.
1509 (CONSIDER, buf_charpos_to_bytepos, buf_bytepos_to_charpos):
1510 Always call byte_char_debug_check if ENABLE_CHECKING is defined.
1511
7b7ae965
DA
15122012-07-06 Dmitry Antipov <dmantipov@yandex.ru>
1513
4e57b342
DA
1514 Avoid code repetition in marker-related functions.
1515 * marker.c (attach_marker): New function.
1516 (Fset_marker, set_marker_restricted, set_marker_both)
1517 (set_marker_restricted_both): Use it.
1518 (Fset_marker, set_marker_restricted, Fbuffer_has_markers_at):
1519 Consistently rename charno to charpos.
1520 (marker_position): Add eassert.
1521 (marker_byte_position): Convert to eassert.
1522
15232012-07-06 Dmitry Antipov <dmantipov@yandex.ru>
1524
1525 Simplify list operations in unchain_overlay and unchain_marker.
7b7ae965 1526 * buffer.c (unchain_overlay): Simplify. Add comment.
4e57b342 1527 * marker.c (unchain_marker): Simplify. Fix comments.
7b7ae965 1528
657924ff
DA
15292012-07-06 Dmitry Antipov <dmantipov@yandex.ru>
1530
1531 Introduce fast path for the widely used marker operation.
1532 * alloc.c (build_marker): New function.
1533 * lisp.h (build_marker): New prototype.
1534 * buffer.c (clone_per_buffer_values, Fmake_indirect_buffer): Use it.
1535 * composite.c (autocmp_chars): Likewise.
1536 * editfns.c (buildmark): Remove.
1537 (Fpoint_marker, Fpoint_min_marker, Fpoint_max_marker)
1538 (save_restriction_save): Use build_marker.
1539 * marker.c (buf_charpos_to_bytepos, buf_bytepos_to_charpos): Likewise.
1540 * window.c (save_window_save): Likewise.
1541
041a49a6
DA
15422012-07-06 Dmitry Antipov <dmantipov@yandex.ru>
1543
1544 Do not use Fdelete_overlay in delete_all_overlays
1545 to avoid redundant calls to unchain_overlay.
1546 * buffer.c (drop_overlay): New function.
1547 (delete_all_overlays, Fdelete_overlay): Use it.
1548 * minibuf.c (get_minibuffer): Fix comment.
1549
7dca65a4
PE
15502012-07-06 Paul Eggert <eggert@cs.ucla.edu>
1551
1552 Port to OpenBSD 5.1 amd64.
1553 * sysdep.c [BSD_SYSTEM]: Include <sys/param.h> before <sys/sysctl.h>.
1554 This is needed for OpenBSD, and should be harmless on all BSD systems.
1555 Also, include <sys/sysctl.h>, as it should be available on all
1556 BSD_SYSTEM hosts given that we're already calling sysctl in that case.
1557 (list_system_processes) [__OpenBSD__]: Use DARWIN_OS style mib, but
1558 use p_pid member, not kp_proc.pid.
1559
8eb876e2
GM
15602012-07-06 Glenn Morris <rgm@gnu.org>
1561
1562 * Makefile.in (emacs$(EXEEXT)): Don't check for load-path shadows.
1563
38182d90
PE
15642012-07-05 Paul Eggert <eggert@cs.ucla.edu>
1565
1566 More xmalloc and related cleanup.
1567 * alloc.c, bidi.c, buffer.c, buffer.h, bytecode.c, callint.c:
1568 * callproc.c, charset.c, coding.c, composite.c, data.c, dispnew.c:
1569 * doc.c, editfns.c, emacs.c, eval.c, fileio.c, filelock.c, fns.c:
1570 * font.c, fontset.c, frame.c, fringe.c, ftfont.c, ftxfont.c, gmalloc.c:
1571 * gtkutil.c, image.c, keyboard.c, keymap.c, lread.c, macros.c, menu.c:
1572 * nsfns.m, nsfont.m, nsmenu.m, nsterm.m, print.c, process.c, ralloc.c:
1573 * regex.c, region-cache.c, scroll.c, search.c, sound.c, syntax.c:
1574 * sysdep.c, term.c, termcap.c, unexmacosx.c, window.c, xdisp.c:
1575 * xfaces.c, xfns.c, xftfont.c, xgselect.c, xmenu.c, xrdb.c, xselect.c:
1576 * xterm.c:
1577 Omit needless casts involving void * pointers and allocation.
1578 Prefer "P = xmalloc (sizeof *P)" to "P = xmalloc (sizeof (TYPE_OF_P))",
1579 as the former is more robust if P's type is changed.
1580 Prefer xzalloc to xmalloc + memset 0.
1581 Simplify malloc-or-realloc to realloc.
1582 Don't worry about xmalloc returning a null pointer.
1583 Prefer xstrdup to xmalloc + strcpy.
1584 * editfns.c (Fmessage_box): Grow message_text by at least 80 when
1585 growing it.
1586 * keyboard.c (apply_modifiers_uncached): Prefer local array to
1587 alloca of a constant.
1588
6dd5a677
EZ
15892012-07-05 Eli Zaretskii <eliz@gnu.org>
1590
1591 * xdisp.c (display_line): Fix horizontal pixel coordinates when
1592 hscroll is larger than the line width. Fixes long and futile
1593 looping inside extend_face_to_end_of_line (on a TTY) producing
1594 glyphs that are not needed and thrown away.
1595
6b312f0f
DA
15962012-07-05 Dmitry Antipov <dmantipov@yandex.ru>
1597
1598 * marker.c (set_marker_restricted_both): Simplify by using
1599 clip_to_bounds.
1600
f520ef9b
PE
16012012-07-05 Paul Eggert <eggert@cs.ucla.edu>
1602
1603 * editfns.c (region_limit): Simplify by using clip_to_bounds.
1604
383b7c95
JD
16052012-07-05 Jan Djärv <jan.h.d@swipnet.se>
1606
1607 * gtkutil.c (gtk_scrollbar_new, gtk_box_new): Define when HAVE_GTK3 is
1608 not defined (Bug#11768).
1609 (xg_create_frame_widgets): Use gtk_plug_new_for_display (Bug#11768).
1610 (xg_create_frame_widgets, create_dialog, xg_get_file_with_chooser)
1611 (make_widget_for_menu_item, xg_make_tool_item): Use gtk_box_new
1612 followed by gtk_box_set_homogeneous (Bug#11768).
1613 (xg_update_menu_item): Use GTK_IS_BOX (Bug#11768).
090bd7cb
JB
1614 (update_theme_scrollbar_width, xg_create_scroll_bar):
1615 Use gtk_scrollbar_new (Bug#11768).
383b7c95
JD
1616 (xg_event_is_for_scrollbar): Use Gdk Device functions for HAVE_GTK3.
1617 (is_box_type): New function (Bug#11768).
1618 (xg_tool_item_stale_p): Call is_box_type.
5293d758 1619 (xg_initialize): Get settings by calling gtk_settings_get_for_screen
383b7c95
JD
1620 with default display (Bug#11768).
1621
d6e7bf45
EZ
16222012-07-05 Eli Zaretskii <eliz@gnu.org>
1623
1624 * xdisp.c (window_hscroll_limited): New function.
1625 (pos_visible_p, init_iterator): Use it to avoid overflow of pixel
1626 coordinates when window's hscroll is set to insanely large
1627 values. (Bug#11857)
1628
431391ec
JB
16292012-07-05 Juanma Barranquero <lekktu@gmail.com>
1630
1631 * makefile.w32-in ($(BLD)/dired.$(O), $(BLD)/fileio.$(O)): Fix typo.
1632 ($(BLD)/terminal.$(O), $(BLD)/syntax.$(O)): Update dependencies.
1633
23f86fce
DA
16342012-07-05 Dmitry Antipov <dmantipov@yandex.ru>
1635
1636 Cleanup xmalloc.
1637 * lisp.h (xzalloc): New prototype. Omit needless casts.
1638 * alloc.c (xzalloc): New function. Omit needless casts.
1639 * charset.c: Omit needless casts. Convert all calls to
1640 xmalloc with following memset to xzalloc.
1641 * dispnew.c: Likewise.
1642 * fringe.c: Likewise.
1643 * image.c: Likewise.
1644 * sound.c: Likewise.
1645 * term.c: Likewise.
1646 * w32fns.c: Likewise.
1647 * w32font.c: Likewise.
1648 * w32term.c: Likewise.
1649 * xfaces.c: Likewise.
1650 * xfns.c: Likewise.
1651 * xterm.c: Likewise.
1652 * atimer.c: Omit needless casts.
1653 * buffer.c: Likewise.
1654 * callproc.c: Likewise.
1655 * ccl.c: Likewise.
1656 * coding.c: Likewise.
1657 * composite.c: Likewise.
1658 * doc.c: Likewise.
1659 * doprnt.c: Likewise.
1660 * editfns.c: Likewise.
1661 * emacs.c: Likewise.
1662 * eval.c: Likewise.
1663 * filelock.c: Likewise.
1664 * fns.c: Likewise.
1665 * gtkutil.c: Likewise.
1666 * keyboard.c: Likewise.
1667 * lisp.h: Likewise.
1668 * lread.c: Likewise.
1669 * minibuf.c: Likewise.
1670 * msdos.c: Likewise.
1671 * print.c: Likewise.
1672 * process.c: Likewise.
1673 * region-cache.c: Likewise.
1674 * search.c: Likewise.
1675 * sysdep.c: Likewise.
1676 * termcap.c: Likewise.
1677 * terminal.c: Likewise.
1678 * tparam.c: Likewise.
1679 * w16select.c: Likewise.
1680 * w32.c: Likewise.
1681 * w32reg.c: Likewise.
1682 * w32select.c: Likewise.
1683 * w32uniscribe.c: Likewise.
1684 * widget.c: Likewise.
1685 * xdisp.c: Likewise.
1686 * xmenu.c: Likewise.
1687 * xrdb.c: Likewise.
1688 * xselect.c: Likewise.
1689
0497dc44
PE
16902012-07-05 Paul Eggert <eggert@cs.ucla.edu>
1691
1692 * fileio.c (time_error_value): Check the right error number.
1693 Problem reported by Troels Nielsen in
1694 <http://lists.gnu.org/archive/html/emacs-devel/2012-07/msg00095.html>.
1695
356e7178
PE
16962012-07-04 Paul Eggert <eggert@cs.ucla.edu>
1697
4e71fd89
PE
1698 * window.c (set_window_hscroll): Revert the 100000 hscroll limit.
1699 This should be fixed in a better way; see Eli Zaretskii in
1700 <http://lists.gnu.org/archive/html/emacs-devel/2012-07/msg00088.html>.
1701 (HSCROLL_MAX): Remove; this is now internal to set_window_hscroll.
1702
f0941253
PE
1703 * fileio.c (time_error_value): Rename from special_mtime.
1704 The old name's problems were noted by Eli Zaretskii in
1705 <http://lists.gnu.org/archive/html/emacs-devel/2012-07/msg00087.html>.
1706
065c9eb4
PE
1707 * emacs.c (gdb_pvec_type): Change it back to enum pvec_type.
1708 This variable's comment says Emacs needs at least one GDB-visible
1709 symbol of type enum pvec_type, to work around GDB problems.
1710 The symbol's value doesn't matter.
1711
356e7178
PE
1712 * alloc.c (PSEUDOVECTOR_NBYTES): Remove stray ';'
1713 that causes compilation to fail on pre-C99 compilers.
1714
ed9265fc 17152012-07-04 Juanma Barranquero <lekktu@gmail.com>
95f61aa2
JB
1716
1717 * s/ms-w32.h (LISP_FLOAT_TYPE, HAVE_MEMCMP, HAVE_MEMCPY)
1718 (HAVE_MEMMOVE, HAVE_MEMSET): Don't set, obsolete.
1719
3884d954
DA
17202012-07-04 Dmitry Antipov <dmantipov@yandex.ru>
1721
d209e2fb 1722 * buffer.c (init_buffer_once): Fix initialization of
3884d954
DA
1723 headers for buffer_defaults and buffer_local_symbols.
1724 Reported by Juanma Barranquero <lekktu@gmail.com>.
1725
ee28be33
SM
17262012-07-04 Stefan Monnier <monnier@iro.umontreal.ca>
1727
1728 Turn VECTOR_FREE_LIST_FLAG into PVEC_FREE.
1729 * lisp.h (enum pvec_type): Use fewer bits.
1730 (PSEUDOVECTOR_SIZE_BITS): New constant.
1731 (PSEUDOVECTOR_SIZE_MASK, PVEC_TYPE_MASK): Use it.
1732 (XSETPVECTYPESIZE, XSETTYPED_PSEUDOVECTOR, DEFUN): Adapt code to
1733 change in pvec_type.
1734 (PSEUDOVECTOR_TYPEP): New macro.
1735 (TYPED_PSEUDOVECTORP): Use it.
1736 * fns.c (internal_equal): Adapt code to extract pvectype.
1737 * emacs.c (gdb_pvec_type): Update type.
1738 * alloc.c (PSEUDOVECTOR_NBYTES): New macro.
1739 (VECTOR_FREE_LIST_SIZE_MASK): Remove (=> PSEUDOVECTOR_SIZE_MASK).
1740 (VECTOR_FREE_LIST_FLAG): Remove (=> PVEC_FREE).
1741 (SETUP_ON_FREE_LIST): Use XSETPVECTYPESIZE.
1742 (sweep_vectors): Use it. Use local var `total_bytes' instead of
1743 abusing vector->header.next.nbytes.
1744 (live_vector_p): Use PVEC_TYPE.
1745 (mark_object): Adapt code to extract pvectype. Use switch.
1746
c7f2cd7f
PE
17472012-07-04 Paul Eggert <eggert@cs.ucla.edu>
1748
1749 * doprnt.c (doprnt): Don't assume string length fits in 'int'.
1750 Tighten new eassert a bit.
1751
8ce70ed2
DA
17522012-07-04 Dmitry Antipov <dmantipov@yandex.ru>
1753
1754 Fix compilation with --enable-gcc-warnings and -O1
1755 optimization level.
1756 * doprnt.c (doprnt): Change type of tem to int, initialize
1757 to avoid compiler warning. Add eassert.
1758 * search.c (simple_search): Initialize match_byte to avoid
1759 compiler warning. Add eassert.
1760
dea7f1e5
PE
17612012-07-04 Paul Eggert <eggert@cs.ucla.edu>
1762
24a212eb
PE
1763 Avoid weird behavior with large horizontal scrolls.
1764 Without this change, for example, large hscroll values would
1765 mess up Emacs's display on Fedora 15 x86, presumably due to
1766 overflows in int calculations in the display code.
1767 Also, if buffers had long lines, Emacs would freeze.
1768 * window.c (HSCROLL_MAX): Reduce to 100000, and make it visible to GDB.
1769 (set_window_hscroll): New function, containing the old guts of
1770 Fset_window_hscroll. Return the clipped value.
1771 (Fset_window_hscroll, Fscroll_left, Fscroll_right): Use it.
1772 This avoids the need to check against PTRDIFF_MAX.
1773
dea7f1e5
PE
1774 * buffer.c (Fgenerate_new_buffer_name): Fix sprintf format mismatch.
1775
76046526
DA
17762012-07-04 Dmitry Antipov <dmantipov@yandex.ru>
1777
1778 * buffer.c (Fgenerate_new_buffer_name): Fix type mismatch.
1779
39adff0d
PE
17802012-07-04 Paul Eggert <eggert@cs.ucla.edu>
1781
63807d47
PE
1782 * regex.c: Suppress GCC warning on RHEL 6. (Bug#11207)
1783 Conditionalize the pragmas on GCC 4.5 or later, not GCC 4.3 or later,
1784 since GCC 4.4.6 issues a bogus warning for them.
1785
39adff0d
PE
1786 Fix bugs in file timestamp newness comparisons.
1787 * fileio.c (Ffile_newer_than_file_p):
1788 * lread.c (Fload): Use full timestamp resolution of files,
1789 not just the 1-second resolution, so that files that are only
1790 slightly newer still count as newer.
1791 * fileio.c (Ffile_newer_than_file_p): Don't assume file
1792 timestamps fit in 'int'; this fixes a Y2038 bug on most hosts.
1793
dbeed9a6
PE
17942012-07-03 Paul Eggert <eggert@cs.ucla.edu>
1795
1796 * fileio.c: Improve handling of file time marker. (Bug#11852)
1797 (special_mtime): New function.
1798 (Finsert_file_contents, Fverify_visited_file_modtime):
1799 Use it to set special mtime values consistently.
1800
636334d6
AS
18012012-07-03 Andreas Schwab <schwab@linux-m68k.org>
1802
1803 * fileio.c (Finsert_file_contents): Properly handle st_mtime
1804 marker for non-existing file. (Bug#11852)
1805
e2017fe2
GM
18062012-07-03 Glenn Morris <rgm@gnu.org>
1807
1808 * lisp.h (Fread_file_name): Restore EXFUN (it's not a normal DEFUN
1809 and did not make it into globals.h).
1810
404dbd37
TT
18112012-07-03 Tom Tromey <tromey@redhat.com>
1812
1813 * window.c (Fset_window_margins, Fset_window_fringes)
1814 (Fset_window_scroll_bars, Fset_window_vscroll): No longer static.
1815 * textprop.c (Fprevious_property_change): No longer static.
1816 * syntax.c (Fsyntax_table_p): No longer static.
1817 * process.c (Fget_process, Fprocess_datagram_address): No longer
1818 static.
1819 * keymap.c (Flookup_key, Fcopy_keymap): No longer static.
1820 * keyboard.c (Fcommand_execute): No longer static.
1821 Remove EXFUN.
1822 * insdel.c (Fcombine_after_change_execute): No longer static.
1823 * image.c (Finit_image_library): No longer static.
1824 * fileio.c (Fmake_symbolic_link): No longer static.
1825 * eval.c (Ffetch_bytecode): No longer static.
1826 * editfns.c (Fuser_full_name): No longer static.
d209e2fb
JB
1827 * doc.c (Fdocumentation_property, Fsnarf_documentation):
1828 No longer static.
404dbd37
TT
1829 * buffer.c (Fset_buffer_major_mode, Fdelete_overlay): No longer
1830 static.
1831 * dired.c (Ffile_attributes): No longer static.
1832 * composite.c (Fcomposition_get_gstring): No longer static.
1833 * callproc.c (Fgetenv_internal): No longer static.
1834
1835 * ccl.h: Remove EXFUNs.
1836 * buffer.h: Remove EXFUNs.
1837 * dispextern.h: Remove EXFUNs.
1838 * intervals.h: Remove EXFUNs.
1839 * fontset.h: Remove EXFUN.
1840 * font.h: Remove EXFUNs.
1841 * dosfns.c (system_process_attributes): Remove EXFUN.
1842 * keymap.h: Remove EXFUNs.
1843 * lisp.h: Remove EXFUNs.
1844 * w32term.h: Remove EXFUNs.
1845 * window.h: Remove EXFUNs.
1846 * xsettings.h: Remove EXFUN.
1847 * xterm.h: Remove EXFUN.
1848
8e4fd1e1
GM
18492012-07-03 Glenn Morris <rgm@gnu.org>
1850
1851 * lisp.h (Frandom): Make it visible to C.
1852 * buffer.c (Fgenerate_new_buffer_name): Speed up finding a new
1853 buffer for invisible buffers. (Bug#1229)
1854
ca95b3eb
DA
18552012-07-03 Dmitry Antipov <dmantipov@yandex.ru>
1856
1857 Fix block vector allocation code to allow VECTOR_BLOCK_SIZE
1858 values which aren't power of 2.
1859 * alloc.c (VECTOR_FREE_LIST_SIZE_MASK): New macro. Verify
1860 it's value and the value of VECTOR_BLOCK_SIZE. Adjust users
1861 accordingly.
1862
7555c33f
SM
18632012-07-03 Stefan Monnier <monnier@iro.umontreal.ca>
1864
1865 * lisp.h (Lisp_Misc, Lisp_Fwd): Move around to group better.
1866
1867 * alloc.c (mark_object): Revert part of last patch to use `switch'.
1868
d12e8f5a
DA
18692012-07-03 Dmitry Antipov <dmantipov@yandex.ru>
1870
1871 * alloc.c (allocate_vector_block): Remove redundant
1872 calls to mallopt if DOUG_LEA_MALLOC is defined.
1873 (allocate_vectorlike): If DOUG_LEA_MALLOC is defined,
1874 avoid calls to mallopt if zero_vector is returned.
1875
296094c3
DA
18762012-07-03 Dmitry Antipov <dmantipov@yandex.ru>
1877
1878 * alloc.c (check_string_bytes): If GC_CHECK_STRING_BYTES
1879 is enabled, avoid dereferencing NULL current_sblock if
1880 running undumped.
1881
36429c89
DA
18822012-07-03 Dmitry Antipov <dmantipov@yandex.ru>
1883
1884 Cleanup basic buffer management.
1885 * buffer.h (struct buffer): Change layout to use generic vector
1886 marking code. Fix some comments. Change type of 'clip_changed'
1887 to bitfield. Remove unused #ifndef old.
1888 (FIRST_FIELD_PER_BUFFER, LAST_FIELD_PER_BUFFER): Remove.
1889 (GET_OVERLAYS_AT): Fix indentation.
1890 (for_each_per_buffer_object_at): New macro.
1891 * buffer.c (clone_per_buffer_values, reset_buffer_local_variables)
1892 (Fbuffer_local_variables): Use it.
1893 (init_buffer_once, syms_of_buffer): Remove unused #ifndef old.
1894 * alloc.c (allocate_buffer): Adjust to match new layout of
1895 struct buffer. Fix comment.
1896 (mark_overlay): New function.
1897 (mark_buffer): Use it. Use mark_vectorlike to mark normal
1898 Lisp area of struct buffer.
1899 (mark_object): Use it. Adjust marking of misc objects
1900 and related comments.
1901
3b3e4cac
PE
19022012-07-02 Paul Eggert <eggert@cs.ucla.edu>
1903
1904 * alloc.c (mark_object): Remove "#ifdef GC_CHECK_MARKED_OBJECTS"
1905 wrapper that is not needed because the wrapped code is a no-op (zero
1906 machine instructions) when GC_CHECK_MARKED_OBJECTS is not defined.
1907 This avoids a -Wunused-macros diagnostic with GCC 4.7.1 x86-64.
1908
cf5c0175
DA
19092012-07-02 Dmitry Antipov <dmantipov@yandex.ru>
1910
1911 * alloc.c (mark_buffer): Simplify. Remove prototype.
1912 (mark_object): Add comment. Reorganize marking of vector-like
faf611c7 1913 objects. Use CHECK_LIVE for all vector-like objects except buffers
cf5c0175
DA
1914 and subroutines when GC_CHECK_MARKED_OBJECTS is defined. Avoid
1915 redundant calls to mark_vectorlike for bool vectors.
1916
ca26824c
GM
19172012-06-30 Glenn Morris <rgm@gnu.org>
1918
2e4c5312
GM
1919 * nsterm.m (ns_init_paths): Ignore site-lisp if --no-site-lisp.
1920
ca26824c
GM
1921 * epaths.in (PATH_SITELOADSEARCH): New.
1922 * lread.c (init_lread): Use PATH_SITELOADSEARCH.
1923 This is rather than relying on --enable-locallisppath elements
1924 having "site-lisp" in their names. (Bug#10208#25, 11658)
1925
0d23c240
EZ
19262012-06-30 Eli Zaretskii <eliz@gnu.org>
1927
c9240d7a
EZ
1928 * w32proc.c (sys_select): Accept and ignore one more argument.
1929
1930 * w32.c (emacs_gnutls_pull): Call select with one more argument.
1931
0d23c240 1932 * sysselect.h [DOS_NT]: Don't include sys/select.h.
9ff8f76b 1933 (pselect) [!MS_DOS]: Redirect to sys_select.
0d23c240
EZ
1934
1935 * sysdep.c: Don't include dos.h and dosfns.h.
1936
1937 * process.c (sys_select):
1938 * msdos.c (sys_select): Accept one more argument and ignore it.
1939
1940 * msdos.c (event_timestamp, sys_select): Use gnulib's gettime;
1941 adapt data types and code to that.
1942
1943 * dosfns.c:
1944 * msdos.c (gettime, settime): Define away the prototypes in dos.h,
1945 which clashes with the gnulib function of the same name.
1946
af5a5a98
AS
19472012-06-30 Andreas Schwab <schwab@linux-m68k.org>
1948
c5e4379c
AS
1949 * font.c (font_style_to_value, font_style_symbolic)
1950 (font_prop_validate_style): Add type checks for values in
1951 font_style_table.
1952
af5a5a98
AS
1953 * lisp.h (CHECK_RANGED_INTEGER): Make value to check the first
1954 argument.
1955 * character.c, charset.c, menu.c, process.c, window.c: Adjust all
1956 uses.
1957
8d38f461
EZ
19582012-06-29 Eli Zaretskii <eliz@gnu.org>
1959
2e5a6631
EZ
1960 * xdisp.c (try_window_id): Undo last change.
1961
8d38f461
EZ
1962 * w32.c (getwd): Adjust commentary about startup_dir.
1963 (init_environment): Always call sys_access, even in non-MSVC
1964 builds. Don't chdir to the directory of the Emacs executable.
1965 This undoes code from 1997 which was justified by the need to
1966 "avoid conflicts when removing and renaming directories". But its
1967 downside was that every relative file name was being interpreted
1968 relative to the directory of the Emacs executable, which can never
1969 be TRT. In particular, it broke sys_access when called with
1970 relative file names.
1971 (sys_access): Map GetLastError to errno.
1972
2af3565e
DA
19732012-06-29 Dmitry Antipov <dmantipov@yandex.ru>
1974
1975 * window.h (struct window): Change type of 'fringes_outside_margins'
1976 to bitfield. Fix comment. Adjust users accordingly.
cf5c0175 1977 (struct window): Change type of 'window_end_bytepos' to ptrdiff_t.
2af3565e
DA
1978 Adjust comment.
1979 * xdisp.c (try_window_id): Change type of 'first_vpos' and 'vpos'
1980 to ptrdiff_t.
1981
c8d3a25c 19822012-06-29 Andreas Schwab <schwab@linux-m68k.org>
57570cd3 1983
c8d3a25c
GM
1984 * gnutls.c (emacs_gnutls_handshake):
1985 Add QUIT to make the loop interruptible.
57570cd3 1986
c8d3a25c 19872012-06-29 Glenn Morris <rgm@gnu.org>
d01fd55f 1988
c8d3a25c
GM
1989 * charset.c (init_charset): Make lack of etc/charsets fatal.
1990
3e984ee8
DA
19912012-06-29 Dmitry Antipov <dmantipov@yandex.ru>
1992
1993 * editfns.c (region_limit): Fix type mismatch.
1994
ef884f23
DA
19952012-06-29 Dmitry Antipov <dmantipov@yandex.ru>
1996
1997 * nsfns.m: Fix GLYPH_DEBUG usage assuming that it may be
1998 undefined. Convert from xassert to eassert.
1999 * nsmenu.m: Convert from xassert to eassert.
2000 * nsterm.m: Likewise.
2001
7d7e0027
SM
20022012-06-28 Stefan Monnier <monnier@iro.umontreal.ca>
2003
2004 * editfns.c (region_limit): Clip to narrowing (bug#11770).
2005
aa754e6a
PE
20062012-06-28 Paul Eggert <eggert@cs.ucla.edu>
2007
2008 Avoid integer overflow on scroll-left and scroll-right.
2009 * window.c (HSCROLL_MAX): New macro.
2010 (Fscroll_left, Fscroll_right): Avoid undefined behavior on integer
2011 overflow when requested scroll falls outside ptrdiff_t range.
2012
80b00b08
DA
20132012-06-28 Dmitry Antipov <dmantipov@yandex.ru>
2014
2015 * window.h (struct window): Change type of 'hscroll',
2016 'min_hscroll' and 'last_point' from Lisp_Object to ptrdiff_t,
2017 'last_modified' and 'last_overlay_modified' to EMACS_INT.
2018 Adjust users accordingly.
2019 * xdisp.c (try_cursor_movement): Replace type check with eassert.
2020 * window.c (Fscroll_left, Fscroll_right): Change type of 'hscroll'
2021 from EMACS_INT to ptrdiff_t.
2022 (make_window): Omit redundant initialization.
2023
62b2bcf6
JB
20242012-06-28 Juanma Barranquero <lekktu@gmail.com>
2025
2026 * makefile.w32-in ($(BLD)/regex.$(O)): Update dependencies.
2027
45942c7d
DA
20282012-06-28 Dmitry Antipov <dmantipov@yandex.ru>
2029
2030 * window.h (struct window): Change type of 'use_time' and
2031 'sequence_number' from Lisp_Object to int.
2032 * frame.c (make_frame): Adjust users accordingly.
2033 * print.c (print_object): Likewise.
2034 * window.c (select_window, Fwindow_use_time, make_parent_window)
2035 (make_window): Likewise.
2036
e509cfa6
DA
20372012-06-28 Dmitry Antipov <dmantipov@yandex.ru>
2038
2039 * dispextern.h (GLYPH_DEBUG): Now defined in config.h if
2040 enabled with --enable-checking=[all,glyphs] configure option.
2041 Fix GLYPH_DEBUG usage assuming that it may be undefined,
2042 adjust comments accordingly.
2043 * dispnew.c: Fix GLYPH_DEBUG usage assuming that it may be
2044 undefined, adjust comments accordingly.
2045 * image.c: Likewise.
2046 * scroll.c: Likewise.
2047 * w32fns.c: Likewise.
2048 * w32term.c: Likewise.
2049 * xdisp.c: Likewise.
2050 * xfaces.c: Likewise.
2051 * xfns.c: Likewise.
2052 * xterm.c: Likewise.
2053
a54e2c05
DA
20542012-06-28 Dmitry Antipov <dmantipov@yandex.ru>
2055
2056 Generalize run-time debugging checks.
2057 * dispextern.h (XASSERTS): Remove.
2058 * fontset.c (xassert): Remove.
2059 Convert from xassert to eassert.
2060 * alloc.c: Convert from xassert to eassert.
2061 * bidi.c: Likewise.
2062 * dispnew.c: Likewise.
2063 * fns.c: Likewise.
2064 * fringe.c: Likewise.
2065 * ftfont.c: Likewise.
2066 * gtkutil.c: Likewise.
2067 * image.c: Likewise.
2068 * keyboard.c: Likewise.
2069 * menu.c: Likewise.
2070 * process.c: Likewise.
2071 * scroll.c: Likewise.
2072 * sound.c: Likewise.
2073 * term.c: Likewise.
2074 * w32console.c: Likewise.
2075 * w32fns.c: Likewise.
2076 * w32term.c: Likewise.
2077 * window.c: Likewise.
2078 * xdisp.c: Likewise.
2079 * xfaces.c: Likewise.
2080 * xfns.c: Likewise.
2081 * xselect.c: Likewise.
2082 * xterm.c: Likewise.
2083
1ec4b7b2
SM
20842012-06-27 Stefan Monnier <monnier@iro.umontreal.ca>
2085
2086 * fns.c (maybe_resize_hash_table): Output message when growing the
2087 purify-hashtable.
2088
2014308a
DA
20892012-06-27 Dmitry Antipov <dmantipov@yandex.ru>
2090
2091 * alloc.c (allocate_string_data): Remove dead code.
2092 * xsettings.c (XSETTINGS_FONT_NAME): Move under HAVE_XFT to
2093 avoid GCC warning about unused macro.
2094
246155eb
DA
20952012-06-27 Dmitry Antipov <dmantipov@yandex.ru>
2096
2097 * alloc.c (allocate_string): Omit intervals initialization.
2098 * alloc.c (make_uninit_multibyte_string): Initialize intervals
2099 as in make_pure_string and make_pure_c_string.
2100
43184b7b
DA
21012012-06-27 Dmitry Antipov <dmantipov@yandex.ru>
2102
d209e2fb 2103 * alloc.c (allocate_string): Fix last change.
43184b7b 2104
3fe6dd74
DA
21052012-06-27 Dmitry Antipov <dmantipov@yandex.ru>
2106
d209e2fb 2107 * alloc.c (allocate_string): Remove two redundant calls
3fe6dd74
DA
2108 to memset, add explicit initialization where appropriate.
2109
1ba6038a
GM
21102012-06-27 Glenn Morris <rgm@gnu.org>
2111
2112 * lisp.mk (lisp): Remove paths.elc.
2113
c89926a5
CY
21142012-06-27 Chong Yidong <cyd@gnu.org>
2115
2116 * doc.c (Fsubstitute_command_keys): Fix punctuation.
2117
ed6b3510
JW
21182012-06-26 John Wiegley <johnw@newartisans.com>
2119
1ec4b7b2 2120 * unexmacosx.c (copy_data_segment): Add two section names used
157e99e4
JW
2121 on Mac OS X Lion: __mod_init_func and __mod_term_func.
2122
ed6b3510
JW
2123 * alloc.c (mark_memory): Do not check with -faddress-sanitizer
2124 when building with Clang.
2125
8edd4a2b
SM
21262012-06-26 Stefan Monnier <monnier@iro.umontreal.ca>
2127
2128 * eval.c (Fapply): Allow calling it with a single argument.
2129
f6f62d1b
EZ
21302012-06-26 Eli Zaretskii <eliz@gnu.org>
2131
2132 * s/ms-w32.h (strcasecmp, strncasecmp) [_MSC_VER]: Redirect to
2133 _stricmp and _strnicmp.
2134 (HAVE_STRCASECMP, HAVE_STRNCASECMP): Define to 1.
2135
62efea5e
DA
21362012-06-26 Dmitry Antipov <dmantipov@yandex.ru>
2137
2138 * alloc.c (allocate_window): Zero out non-Lisp part of newly
2139 allocated window.
2140 (allocate_process): Likewise for new process.
8edd4a2b 2141 (allocate_terminal): Change to use offsetof.
62efea5e
DA
2142 (allocate_frame): Likewise.
2143 * frame.c (make_frame): Omit redundant initialization.
2144 * window.c (make_parent_window): Use memset.
2145 (make_window): Omit redundant initialization.
2146 * process.c (make_process): Omit redundant initialization.
2147 * terminal.c (create_terminal): Likewise.
2148
42997f4d
DA
21492012-06-26 Dmitry Antipov <dmantipov@yandex.ru>
2150
2151 * term.c (delete_tty): Remove redundant call to memset.
2152
1130ecfc
DA
21532012-06-26 Dmitry Antipov <dmantipov@yandex.ru>
2154
2155 * alloc.c: Remove build_string.
2156 * lisp.h: Define build_string as static inline. This provides
2157 a better opportunity to optimize away calls to strlen when the
2158 function is called with compile-time constant argument.
2159 * image.c (imagemagick_error): Convert to build_string.
2160 * w32proc.c (sys_spawnve): Likewise.
2161 * xterm.c (x_term_init): Likewise.
2162
cf38a720
PE
21632012-06-26 Paul Eggert <eggert@cs.ucla.edu>
2164
99027bdd
PE
2165 Use sprintf return value instead of invoking strlen on result.
2166 In the old days this wasn't portable, since some sprintf
2167 implementations returned char *. But they died out years ago and
2168 Emacs already assumes sprintf returns int.
2169 Similarly for float_to_string.
2170 This patch speeds up (number-to-string 1000) by 3% on Fedora 15 x86-64.
2171 * ccl.c (ccl_driver):
2172 * character.c (string_escape_byte8):
2173 * data.c (Fnumber_to_string):
2174 * doprnt.c (doprnt):
2175 * print.c (print_object):
2176 * xdisp.c (message_dolog):
2177 * xfns.c (syms_of_xfns):
2178 Use sprintf or float_to_string result to avoid need to call strlen.
2179 * data.c (Fnumber_to_string):
2180 Use make_unibyte_string, since the string must be ASCII.
2181 * lisp.h, print.c (float_to_string): Now returns int length.
2182 * term.c (produce_glyphless_glyph):
2183 Use sprintf result rather than recomputing it.
2184
cf38a720
PE
2185 Clean out last vestiges of the old HAVE_CONFIG_H stuff.
2186 * Makefile.in (ALL_CFLAGS):
2187 * makefile.w32-in (LOCAL_FLAGS): Remove -DHAVE_CONFIG_H.
2188 * gmalloc.c, regex.c: Include <config.h> unconditionally.
2189
3511c784
DA
21902012-06-25 Dmitry Antipov <dmantipov@yandex.ru>
2191
0a08eb21 2192 * dispextern.h (xstrcasecmp): Define to library function
3511c784
DA
2193 strcasecmp if available.
2194 * xfaces.c: Do not use xstrcasecmp if strcasecmp is available.
2195
fb7da12e
AS
21962012-06-25 Andreas Schwab <schwab@linux-m68k.org>
2197
2198 * keyboard.c (menu_bar_items, menu_bar_item, read_key_sequence):
2199 Avoid comma operator.
2200 * menu.c (push_submenu_start, push_submenu_end)
2201 (push_left_right_boundary, push_menu_pane): Likewise.
2202 * msdos.c (dos_rawgetc): Likewise.
2203
afa2ffd8
DA
22042012-06-25 Dmitry Antipov <dmantipov@yandex.ru>
2205
2206 * xfns.c (xic_create_fontsetname): Remove redundant calls
2207 to memset.
2208
b3b4476b
PE
22092012-06-25 Paul Eggert <eggert@cs.ucla.edu>
2210
4495ff38
PE
2211 * gtkutil.c (get_utf8_string): Remove redundant assignment.
2212 sprintf already null-terminates its output.
2213
b3b4476b
PE
2214 * xfns.c (x_window): Remove redundant cast.
2215
b00876c9
DA
22162012-06-25 Dmitry Antipov <dmantipov@yandex.ru>
2217
2218 * xmenu.c (xmenu_show, xdialog_show): Explicit cast from
2219 `const char *' to `char *' to avoid compiler warning.
2220
d188e26b
PE
22212012-06-24 Paul Eggert <eggert@cs.ucla.edu>
2222
885d1d74
PE
2223 * xterm.c (x_term_init): Build proper-sized _XSETTINGS_Snnn string
2224 instead of truncating it to 63 (admittedly a generous limit).
2225
d188e26b
PE
2226 * process.c: Fix spelling and caps in comments.
2227
e2f560b1
DN
22282012-06-24 Dan Nicolaescu <dann@ics.uci.edu>
2229
e86db54b 2230 * emacs.c (setpgrp): Remove definition, unused.
e2f560b1
DN
2231 * sysdep.c (setpgrp): Remove definition, not used in this file.
2232
7583a3a1
JB
22332012-06-24 Juanma Barranquero <lekktu@gmail.com>
2234
2235 * makefile.w32-in: Update dependencies.
2236
696056c2
EZ
22372012-06-24 Eli Zaretskii <eliz@gnu.org>
2238
2239 * makefile.w32-in (TIMESPEC_H): Remove nt/inc/sys/time.h.
2240 (SYSTIME_H): Add nt/inc/sys/time.h.
2241
2242 * systime.h [WINDOWSNT]: Include sys/time.h.
2243
2244 * s/ms-w32.h (struct timespec): Definition moved from
2245 nt/inc/sys/time.h. Suggested by Paul Eggert <eggert@cs.ucla.edu>.
2246
845ca893
PE
22472012-06-24 Paul Eggert <eggert@cs.ucla.edu>
2248
2249 Switch from NO_RETURN to C11's _Noreturn (Bug#11750).
2250 * buffer.h (buffer_slot_type_mismatch):
2251 * data.c (arith_error) [!FORWARD_SIGNAL_TO_MAIN_THREAD]:
2252 * eval.c (unwind_to_catch):
2253 * image.c (my_png_error, my_error_exit):
2254 * keyboard.c (quit_throw_to_read_char, user_error)
2255 (Fexit_recursive_edit, Fabort_recursive_edit):
2256 * lisp.h (die, args_out_of_range, args_out_of_range_3)
2257 (wrong_type_argument, buffer_overflow, __executable_start)
2258 (memory_full, buffer_memory_full, string_overflow, Fthrow)
2259 (xsignal, xsignal0, xsignal1, xsignal2, xsignal3, signal_error)
2260 (error, verror, nsberror, report_file_error, Ftop_level, Fkill_emacs)
2261 (fatal):
2262 (child_setup) [!DOS_NT]:
2263 * lread.c (end_of_file_error, invalid_syntax):
2264 * process.c (send_process_trap) [!FORWARD_SIGNAL_TO_MAIN_THREAD]:
2265 * puresize.h (pure_write_error):
2266 * search.c (matcher_overflow):
2267 * sound.c (sound_perror, alsa_sound_perror):
2268 * sysdep.c, syssignal.h (croak):
2269 * term.c (maybe_fatal, vfatal):
2270 * textprop.c (text_read_only):
2271 * undo.c (user_error):
2272 * unexmacosx.c (unexec_error):
2273 * xterm.c (x_ins_del_lines, x_delete_glyphs):
2274 Use _Noreturn rather than NO_RETURN.
2275 No need for separate decl merely because of _Noreturn.
2276 * sound.c (sound_warning, parse_sound):
2277 Remove unnecessary forward decls.
2278
f1dd8073
PE
22792012-06-24 Paul Eggert <eggert@cs.ucla.edu>
2280
2281 Fix bug when time_t is unsigned and as wide as intmax_t (Bug#9000).
2282 * lisp.h (WAIT_READING_MAX): New macro.
2283 * dispnew.c (Fsleep_for, sit_for):
2284 * keyboard.c (kbd_buffer_get_event):
2285 * process.c (Faccept_process_output):
2286 Use it to avoid bogus compiler warnings with obsolescent GCC versions.
2287 This improves on the previous patch, which introduced a bug
2288 when time_t is unsigned and as wide as intmax_t.
2289 See <http://bugs.gnu.org/9000#51>.
2290
b82c1755
EZ
22912012-06-23 Eli Zaretskii <eliz@gnu.org>
2292
2293 * dispnew.c (sit_for, Fsleep_for):
2294 * keyboard.c (kbd_buffer_get_event):
2295 * process.c (Faccept_process_output): Avoid compiler warnings when
2296 comparing a 32-bit time_t with a 64-bit INTMAX_MAX.
2297
ca300656
JB
22982012-06-23 Juanma Barranquero <lekktu@gmail.com>
2299
049ec95b
JB
2300 * makefile.w32-in: Update dependencies.
2301
ca300656
JB
2302 * w32.c (ltime): Add return type and declare static.
2303 (w32_get_internal_run_time): Remove usused variable `time_100ns'.
2304
db7b8d06
PE
23052012-06-23 Paul Eggert <eggert@cs.ucla.edu>
2306
2307 * sysdep.c [__FreeBSD__]: Fix more recently-introduced typos.
2308 Privately reported by Herbert J. Skuhra.
2309 (make_lisp_timeval) [__FreeBSD__]: Rename from TIMELIST.
2310 All uses changed.
2311 (system_process_attributes) [__FreeBSD__]: Invoke make_lisp_time,
2312 not make_lisp_timeval, when the argument is of type EMACS_TIME.
2313
0bd8297f
EZ
23142012-06-23 Eli Zaretskii <eliz@gnu.org>
2315
96512555
EZ
2316 * w32proc.c (Fw32_get_locale_info): Fix an off-by-one error in
2317 last argument of make_unibyte_string.
2318
0bd8297f
EZ
2319 * keyboard.c (kbd_buffer_get_event): Include the codepage and the
2320 language ID in the event parameters.
2321
2322 * w32term.c (w32_read_socket): Put the new keyboard codepage into
2323 event.code, not the obscure "character set ID".
2324
63def6b6
CY
23252012-06-23 Chong Yidong <cyd@gnu.org>
2326
2327 * xmenu.c (x_menu_wait_for_event): Adapt GTK3 to new xg_select.
2328
e8a02204
EZ
23292012-06-23 Eli Zaretskii <eliz@gnu.org>
2330
388cdec0
EZ
2331 Fix the MS-Windows build broken by 2012-06-22T21:17:42Z!eggert@cs.ucla.edu.
2332 * w32.c (fdutimens): New function.
2333
2334 * w32proc.c (sys_select): Adapt to change in the EMACS_TIME type.
2335
2336 * s/ms-w32.h (pselect): Redirect to sys_select.
2337
2338 * sysselect.h [WINDOWSNT]: Don't include sys/select.h.
2339
e8a02204
EZ
2340 * ralloc.c (r_alloc_inhibit_buffer_relocation): Fix stupid thinko
2341 in the logic of incrementing and decrementing the value of
2342 use_relocatable_buffers.
2343
d054f3fb
PE
23442012-06-23 Paul Eggert <eggert@cs.ucla.edu>
2345
2346 * sysdep.c [__FreeBSD__]: Fix recently-introduced typos.
2347 Privately reported by Herbert J. Skuhra.
2348 [__FreeBSD__]: Remove "*/" typo after "#include".
2349 (timeval_to_EMACS_TIME) [__FreeBSD__]: New static function.
2350 (TIMEVAL) [__FreeBSD__]: Now a static function rather than a macro.
2351 (TIMEVAL, system_process_attributes) [__FreeBSD__]:
2352 Don't assume EMACS_TIME and struct timeval are the same type.
2353
d35af63c
PE
23542012-06-22 Paul Eggert <eggert@cs.ucla.edu>
2355
2356 Support higher-resolution time stamps (Bug#9000).
2357 The time stamps are only nanosecond-resolution at the C level,
2358 since that's the best that any real-world system supports now.
2359 But they are picosecond-resolution at the Lisp level, as that's
2360 easy, and leaves room for future OS improvements.
2361
2362 * Makefile.in (LIB_CLOCK_GETTIME): New macro.
2363 (LIBES): Use it.
2364
2365 * alloc.c (Fgarbage_collect): Port to higher-res time stamps.
2366 Don't get current time unless it's needed.
2367
2368 * atimer.c: Include <sys/time.h> unconditionally, since gnulib
2369 now provides it if it's absent.
2370 (start_atimer): Port to higher-res time stamps.
2371 Check for time stamp overflow. Don't get current time more
2372 often than is needed.
2373
2374 * buffer.h (struct buffer): Buffer modtime now has high resolution.
2375 Include systime.h, not time.h.
2376 (NONEXISTENT_MODTIME_NSECS, UNKNOWN_MODTIME_NSECS): New macros.
2377
2378 * dired.c: Include stat-time.h.
2379 (Ffile-attributes): File times now have higher resolution.
2380
2381 * dispextern.h [HAVE_WINDOW_SYSTEM]: Include systime.h.
2382 (struct image): Timestamp now has higher resolution.
2383
2384 * dispnew.c (PERIODIC_PREEMPTION_CHECKING): Remove, as Emacs always
2385 has at least microseconds now. All uses removed.
2386 (update_frame, update_single_window, update_window, update_frame_1)
2387 (Fsleep_for, sit_for): Port to higher-resolution time stamps.
2388
2389 * editfns.c (time_overflow): Now extern.
2390 (Fcurrent_time, Fget_internal_run_time, make_time, lisp_time_argument)
2391 (float-time, Fformat_time_string, Fcurrent_time_string)
2392 (Fcurrent_time_zone): Accept and generate higher-resolution
2393 time stamps.
2394 (make_time_tail, make_lisp_time, dissassemble_lisp_time)
2395 (decode_time_components, lisp_seconds_argument): New functions.
2396 (make_time): Now static.
2397 (lisp_time_argument): Now returns EMACS_TIME. New arg ppsec.
2398 Report an error if the time is invalid, rather than having the caller
2399 do that.
2400
2401 * fileio.c: Include <stat-time.h>
2402 (Fcopy_file): Copy higher-resolution time stamps.
2403 Prefer to set the time stamp via a file descriptor if that works.
2404 (Fset_file_times, Finsert_file_contents, Fwrite_region)
2405 (Fverify_visited_file_modtime, Fclear_visited_file_modtime)
2406 (Fvisited_file_modtime, Fset_visited_file_modtime):
2407 Support higher-resolution time stamps.
2408
2409 * fns.c (Frandom): Use nanoseconds, not microseconds, for seed.
2410
2411 * gtkutil.c (xg_maybe_add_timer): Port to higher-res time stamps.
2412
2413 * image.c (prepare_image_for_display, clear_image_cache)
2414 (lookup_image): Port to higer-resolution time stamps.
2415
2416 * keyboard.c (start_polling, bind_polling_period):
2417 Check for time stamp overflow.
2418 (read_char, kbd_buffer_get_event, timer_start_idle)
2419 (timer_stop_idle, timer_resume_idle, timer_check_2, timer_check)
2420 (Fcurrent_idle_time, init_keyboard, set_waiting_for_input):
2421 Port to higher-resolution time stamps. Do not assume time_t is signed.
2422 (decode_timer): New function. Timers are now vectors of length 9,
2423 not 8, to accommodate the picosecond component.
2424 (timer_check_2): Use it.
2425
2426 * nsterm.m (select_timeout, timeval_subtract): Remove.
2427 (ns_timeout): Use Emacs's facilities for time stamp arithmetic,
2428 as they're a bit more accurate and handle overflow better.
2429 (ns_select): Change prototype to be compatible with pselect.
2430 (ns_select, ns_term_shutdown): Port to ns-resolution time stamps.
2431 * nsterm.h (ns_select): Adjust prototype.
2432
2433 * msdos.c (EMACS_TIME_ZERO_OR_NEG_P): Remove, as it assumes
2434 us-resolution time stamps.
2435 (sys_select): Use the new EMACS_TIME_SIGN macro instead.
2436
2437 * lread.c (read_filtered_event): Port to ns-resolution time stamps.
2438
2439 * lisp.h (time_overflow): New decl.
2440 (wait_reading_process_output): First arg is now intmax_t, not int,
2441 to accommodate larger waits.
2442
2443 * process.h (struct Lisp_Process.read_output_delay):
2444 Now counts nanoseconds, not microseconds.
2445 * process.c (ADAPTIVE_READ_BUFFERING): Don't worry about
2446 EMACS_HAS_USECS.
2447 (READ_OUTPUT_DELAY_INCREMENT, Faccept_process_output)
2448 (wait_reading_process_output):
2449 Port to ns-resolution time stamps.
2450 (Faccept_process_output, wait_reading_process_output):
2451 Check for time stamp overflow. Do not assume time_t is signed.
2452 (select_wrapper): Remove; we now use pselect.
2453 (Fprocess_attributes): Now generates ns-resolution time stamps.
2454
2455 * sysdep.c: Include utimens.h. Don't include utime.h
2456 or worry about struct utimbuf; gnulib does that for us now.
2457 (gettimeofday): Remove; gnulib provides a substitute.
2458 (make_timeval): New function.
2459 (set_file_times): Now sets ns-resolution time stamps.
2460 New arg FD; all uses changed.
2461 (time_from_jiffies, ltime_from_jiffies, get_up_time)
2462 (system_process_attributes):
2463 Now returns ns-resolution time stamp. All uses changed.
2464 Check for time stamp overflow.
2465
2466 * sysselect.h: Don't depend on HAVE_SYS_SELECT_H; gnulib
2467 provides a substitute now.
2468
2469 * systime.h: Include timespec.h rather than sys/time.h and time.h,
2470 since it guarantees struct timespec.
2471 (EMACS_TIME): Now struct timespec, so that we can support
2472 ns-resolution time stamps.
2473 (EMACS_TIME_RESOLUTION, LOG10_EMACS_TIME_RESOLUTION): New macros.
2474 (EMACS_HAS_USECS): Remove; Emacs always has sub-second time stamps now.
2475 (EMACS_USECS): Remove.
2476 (EMACS_SET_USECS): The underlying time stamp now has ns resolution,
2477 so multiply the arg by 1000 before storing it.
2478 (EMACS_NSECS, EMACS_SECS_ADDR, EMACS_SET_NSECS, EMACS_SET_SECS_NSECS):
2479 New macros.
2480 (EMACS_GET_TIME, EMACS_ADD_TIME, EMACS_SUB_TIME):
2481 Port to ns-resolution time stamps.
2482 (EMACS_TIME_NEG_P): Remove; replaced by....
2483 (EMACS_TIME_SIGN): New macro.
2484 (EMACS_SET_INVALID_TIME, EMACS_TIME_VALID_P)
2485 (EMACS_TIME_FROM_DOUBLE, EMACS_TIME_TO_DOUBLE): New macros.
2486 (set_file_times, make_time, lisp_time_argument): Adjust signature.
2487 (make_timeval, make_lisp_time, decode_time_components): New decls.
2488 (EMACS_TIME_CMP): Remove; no longer used. Plus, it was buggy, in
2489 that it mishandled time_t overflow. You can't compare by subtracting!
2490 (EMACS_TIME_EQ, EMACS_TIME_NE, EMACS_TIME_GT, EMACS_TIME_GE)
2491 (EMACS_TIME_LT, EMACS_TIME_LE): Rewrite in terms of timespec_cmp.
2492
2493 * term.c: Include <sys/time.h>.
2494 (timeval_to_Time): New function, for proper overflow wraparound.
2495 (term_mouse_position, term_mouse_click): Use it.
2496
2497 * undo.c (record_first_change): Support higher-resolution time stamps
2498 in the undo buffer.
2499 (Fprimitive_undo): Use them when restoring time stamps.
2500
2501 * w32.c (ltime, U64_TO_LISP_TIME, process_times, emacs_gnutls_pull)
2502 (w32_get_internal_run_time):
2503 Port to higher-resolution Emacs time stamps.
2504 (ltime): Now accepts single 64-bit integer, as that's more convenient
2505 for callers.
2506
2507 * xdisp.c (start_hourglass): Port to ns-resolution time stamps.
2508
2509 * xgselect.c, xgselect.h (xg_select): Add sigmask argument,
2510 for compatibility with pselect. Support ns-resolution time stamps.
2511
2512 * xmenu.c (x_menu_wait_for_event): Support ns-resolution time stamps.
2513
2514 * xselect.c (wait_for_property_change, x_get_foreign_selection):
2515 Check for time stamp overflow, and support ns-resolution time stamps.
2516
2517 * xterm.c: Don't include sys/time.h; gnulib does that for us now.
2518 Don't worry about whether HAVE_TIMEVAL and HAVE_SELECT are set.
2519 (timeval_subtract): Remove; no longer needed.
2520 (XTflash, XTring_bell, x_wait_for_event):
2521 Port to ns-resolution time stamps. Don't assume time_t is signed.
2522
b6a92dfe
CY
25232012-06-22 Chong Yidong <cyd@gnu.org>
2524
2525 * xdisp.c (x_consider_frame_title): Revert last change.
2526
d251c37c
EZ
25272012-06-22 Eli Zaretskii <eliz@gnu.org>
2528
2529 * alloc.c (NSTATICS): Enlarge to 0x650. Otherwise, Emacs compiled
2530 with -DENABLE_CHECKING -DXASSERTS -DGLYPH_DEBUG=1 -DBYTE_CODE_METER
2531 aborts in staticpro during startup. (Without -DBYTE_CODE_METER,
2532 staticidx goes up to 1597 out of 1600 = 0x640.)
2533
f10deafb
PE
25342012-06-20 Paul Eggert <eggert@cs.ucla.edu>
2535
2536 * fileio.c (Fdefault_file_modes): Block input while fiddling with umask.
2537 Otherwise, the umask might be mistakenly 0 while handling input signals.
2538
ec6de1e2
SM
25392012-06-19 Stefan Monnier <monnier@iro.umontreal.ca>
2540
2541 * minibuf.c (Fread_string): Bind minibuffer-completion-table.
2542
28be1ada
DA
25432012-06-19 Dmitry Antipov <dmantipov@yandex.ru>
2544
2545 * alloc.c, bytecode.c, ccl.c, coding.c, composite.c, data.c, dosfns.c:
2546 * font.c, image.c, keyboard.c, lread.c, menu.c, minibuf.c, msdos.c:
2547 * print.c, syntax.c, window.c, xmenu.c, xselect.c: Replace direct
2548 access to `contents' member of Lisp_Vector objects with AREF and ASET
2549 where appropriate.
2550
c6bf3022
CY
25512012-06-19 Chong Yidong <cyd@gnu.org>
2552
2553 * frame.c (delete_frame): When selecting a frame on a different
2554 text terminal, do not alter the terminal's top-frame.
2555
2556 * xdisp.c (format_mode_line_unwind_data): Record the target
2557 frame's selected window and its terminal's top-frame.
2558 (unwind_format_mode_line): Restore them.
2559 (x_consider_frame_title, display_mode_line, Fformat_mode_line):
2560 Callers changed.
2561 (x_consider_frame_title): Do not condition on HAVE_WINDOW_SYSTEM,
2562 since tty frames can be explicitly named.
2563 (prepare_menu_bars): Likewise.
2564
2565 * term.c (Ftty_top_frame): New function.
2566
defd4196
PE
25672012-06-18 Paul Eggert <eggert@cs.ucla.edu>
2568
2569 Port byte-code-meter to modern targets.
2570 * bytecode.c (METER_CODE) [BYTE_CODE_METER]: Don't assume
2571 !CHECK_LISP_OBJECT_TYPE && !USE_LSB_TAG. Problem with
8b5257e1 2572 CHECK_LISP_OBJECT_TYPE reported by Dmitry Antipov in
defd4196
PE
2573 <http://lists.gnu.org/archive/html/emacs-devel/2012-06/msg00282.html>.
2574 (METER_1, METER_2): Simplify.
2575
1053a871
SM
25762012-06-18 Stefan Monnier <monnier@iro.umontreal.ca>
2577
2578 * data.c (Fdefalias): Return `symbol' (bug#11686).
2579
b7e8d081
MR
25802012-06-18 Martin Rudalics <rudalics@gmx.at>
2581
2582 * buffer.c (Fkill_buffer): Don't throw an error when the buffer
1053a871
SM
2583 gets killed during executing of this function (Bug#11665).
2584 Try to always return Qt when the buffer has been actually killed.
b7e8d081
MR
2585 (Vkill_buffer_query_functions): In doc-string say that functions
2586 run by this hook should not change the current buffer.
2587
7ea2b339
PE
25882012-06-18 Paul Eggert <eggert@cs.ucla.edu>
2589
2590 Fix recently-introduced process.c problems found by static checking.
2591 * process.c (write_queue_push, write_queue_pop, send_process):
2592 Use ptrdiff_t, not int or EMACS_INT, for buffer lengths and offsets.
2593 (write_queue_pop): Fix pointer signedness problem.
2594 (send_process): Remove unused local.
2595
96a313a1
CY
25962012-06-17 Chong Yidong <cyd@gnu.org>
2597
2598 * xdisp.c (redisplay_internal): No need to redisplay terminal
2599 frames that are not on top.
2600
20ca2e94
TN
26012012-06-17 Troels Nielsen <bn.troels@gmail.com>
2602
2603 * process.c (make_process): Initialize write_queue.
2604 (write_queue_push, write_queue_pop): New functions.
2605 (send_process): Use them to maintain correct ordering of process
2606 writes (Bug#10815).
2607
9a900ca9
PE
26082012-06-17 Paul Eggert <eggert@cs.ucla.edu>
2609
310fbfa8
PE
2610 * lisp.h (eassert): Assume C89 or later.
2611 This removes the need for CHECK.
2612 (CHECK): Remove. Its comments about always evaluating its
2613 argument were confusing, as 'eassert' typically does not evaluate
2614 its argument.
2615
27bb1ca4
PE
2616 * coding.c (produce_chars): Use ptrdiff_t, not int.
2617
9a900ca9
PE
2618 * xterm.c (x_draw_underwave): Check for integer overflow.
2619 This pacifies gcc 4.7.0 -Wunsafe-loop-optimizations on x86-64.
2620
41b7f8bc 26212012-06-17 Jan Djärv <jan.h.d@swipnet.se>
50a93863
JD
2622
2623 * nsterm.m (x_free_frame_resources): Move xfree so freed memory isn't
2624 referenced (Bug#11583).
2625
9b0e3eba
AA
26262012-06-16 Aurelien Aptel <aurelien.aptel@gmail.com>
2627
2628 Implement wave-style variant of underlining.
2629 * dispextern.h (face_underline_type): New enum.
2630 (face): Add field for underline type.
2631 * nsterm.m (ns_draw_underwave): New function.
2632 (ns_draw_text_decoration): Use it.
2633 * w32term.c (w32_restore_glyph_string_clip, w32_draw_underwave):
2634 New functions.
2635 (x_draw_glyph_string): Use them.
2636 * xfaces.c (Qline, Qwave): New Lisp objects.
2637 (check_lface_attrs, merge_face_ref)
1053a871
SM
2638 (Finternal_set_lisp_face_attribute, realize_x_face):
2639 Handle wave-style underline face attributes.
9b0e3eba
AA
2640 * xterm.c (x_draw_underwave): New function.
2641 (x_draw_glyph_string): Use it.
2642
0fb52f11
JB
26432012-06-16 Juanma Barranquero <lekktu@gmail.com>
2644
2645 * makefile.w32-in ($(BLD)/emacs.$(O), $(BLD)/fringe.$(O))
2646 ($(BLD)/xml.$(O), $(BLD)/intervals.$(O), $(BLD)/macros.$(O))
2647 ($(BLD)/minibuf.$(O), $(BLD)/regex.$(O), $(BLD)/region-cache.$(O))
2648 ($(BLD)/textprop.$(O), $(BLD)/undo.$(O), $(BLD)/window.$(O))
2649 ($(BLD)/w32select.$(O)): Update dependencies.
2650
e5560ff7
AS
26512012-06-16 Andreas Schwab <schwab@linux-m68k.org>
2652
2653 * buffer.h (FETCH_MULTIBYTE_CHAR): Define as inline.
2654 (BUF_FETCH_MULTIBYTE_CHAR): Likewise.
2655 * character.c (_fetch_multibyte_char_p): Remove.
2656 * alloc.c: Include "character.h" before "buffer.h".
2657 * bidi.c: Likewise.
2658 * buffer.c: Likewise.
2659 * bytecode.c: Likewise.
2660 * callint.c: Likewise.
2661 * callproc.c: Likewise.
2662 * casefiddle.c: Likewise.
2663 * casetab.c: Likewise.
2664 * category.c: Likewise.
2665 * cmds.c: Likewise.
2666 * coding.c: Likewise.
2667 * composite.c: Likewise.
2668 * dired.c: Likewise.
2669 * dispnew.c: Likewise.
2670 * doc.c: Likewise.
2671 * dosfns.c: Likewise.
2672 * editfns.c: Likewise.
2673 * emacs.c: Likewise.
2674 * fileio.c: Likewise.
2675 * filelock.c: Likewise.
2676 * font.c: Likewise.
2677 * fontset.c: Likewise.
2678 * fringe.c: Likewise.
2679 * indent.c: Likewise.
2680 * insdel.c: Likewise.
2681 * intervals.c: Likewise.
2682 * keyboard.c: Likewise.
2683 * keymap.c: Likewise.
2684 * lread.c: Likewise.
2685 * macros.c: Likewise.
2686 * marker.c: Likewise.
2687 * minibuf.c: Likewise.
2688 * nsfns.m: Likewise.
2689 * nsmenu.m: Likewise.
2690 * print.c: Likewise.
2691 * process.c: Likewise.
2692 * regex.c: Likewise.
2693 * region-cache.c: Likewise.
2694 * search.c: Likewise.
2695 * syntax.c: Likewise.
2696 * term.c: Likewise.
2697 * textprop.c: Likewise.
2698 * undo.c: Likewise.
2699 * unexsol.c: Likewise.
2700 * w16select.c: Likewise.
2701 * w32fns.c: Likewise.
2702 * w32menu.c: Likewise.
2703 * window.c: Likewise.
2704 * xdisp.c: Likewise.
2705 * xfns.c: Likewise.
2706 * xmenu.c: Likewise.
2707 * xml.c: Likewise.
2708 * xselect.c: Likewise.
2709
2f07e6af
EZ
27102012-06-16 Eli Zaretskii <eliz@gnu.org>
2711
1053a871
SM
2712 * xdisp.c (set_cursor_from_row): Don't dereference glyphs_end.
2713 If all the glyphs of the glyph row came from strings, and we have no
2f07e6af 2714 cursor positioning clues, put the cursor on the first glyph of the
1097afe4
EZ
2715 row.
2716 (handle_face_prop): Use chunk-relative overlay string index when
2717 indexing into it->string_overlays array. (Bug#11653)
946fdb73
EZ
2718 (set_cursor_from_row): Use the leftmost glyph as GLYPH_BEFORE, not
2719 the rightmost. (Bug#11720)
2f07e6af 2720
29b83cec
AS
27212012-06-16 Andreas Schwab <schwab@linux-m68k.org>
2722
2723 * category.h (CHAR_HAS_CATEGORY): Define as inline.
2724 (CATEGORY_MEMBER): Enforce 1/0 value.
2725 * category.c (_temp_category_set): Remove.
2726
4c5501e9
EZ
27272012-06-16 Eli Zaretskii <eliz@gnu.org>
2728
2729 * window.c (Fdelete_other_windows_internal)
2730 (Fdelete_window_internal): Don't access frame's mouse highlight
2731 info of the initial frame. (Bug#11677)
2732
2b570124
PE
27332012-06-14 Paul Eggert <eggert@cs.ucla.edu>
2734
e93864f9
PE
2735 * .gdbinit (xgetint): Fix recently-introduced paren typo.
2736 Assume USE_2_TAGS_FOR_INTS.
2737 (xreload): Adjust $tagmask width to match recent lisp.h change.
2738
2b570124
PE
2739 Simplify lisp.h in minor ways that should not affect code.
2740 * lisp.h (USE_2_TAGS_FOR_INTS): Remove, as it was always defined.
2741 (LISP_INT_TAG, case_Lisp_Int, LISP_STRING_TAG, LISP_INT_TAG_P)
2742 (LISP_INT1_TAG, enum Lisp_Type, XINT, XUINT, make_number):
2743 Simplify under the assumption that USE_2_TAGS_FOR_INTS is defined.
2744 (INTTYPEBITS): New macro, for clarity.
2745 (INTMASK, MOST_POSITIVE_FIXNUM): Use it.
1053a871
SM
2746 (LISP_INT1_TAG, LISP_STRING_TAG, LISP_INT_TAG_P):
2747 Simplify now that USE_LSB_TAG is always defined.
2b570124
PE
2748 (TYPEMASK, XINT) [USE_LSB_TAG]: Remove unnecessary cast.
2749 (make_number) [!USE_LSB_TAG]: Use INTMASK; that's simpler.
2750
81755f69
JB
27512012-06-13 Juanma Barranquero <lekktu@gmail.com>
2752
2753 * makefile.w32-in ($(BLD)/data.$(O)): Update dependencies.
2754
16192a57
GM
27552012-06-13 Glenn Morris <rgm@gnu.org>
2756
2757 * s/bsd-common.h (BSD4_3):
2758 * s/usg5-4-common.h (USG5_4): No longer define; unused.
2759
646b5f55
AS
27602012-06-13 Andreas Schwab <schwab@linux-m68k.org>
2761
2762 * lisp.h (Lisp_Object) [CHECK_LISP_OBJECT_TYPE]: Define as struct
2763 instead of union.
2764 (XLI, XIL): Define.
1053a871
SM
2765 (XHASH, XTYPE, XINT, XUINT, make_number, XSET, XPNTR, XUNTAG):
2766 Use them.
2767 * emacs.c (gdb_use_struct): Rename from gdb_use_union.
646b5f55 2768 * .gdbinit: Check gdb_use_struct instead of gdb_use_union.
1053a871 2769 * alloc.c (widen_to_Lisp_Object): Remove.
646b5f55
AS
2770 (mark_memory): Use XIL instead of widen_to_Lisp_Object.
2771 * frame.c (delete_frame): Remove outdated comment.
2772 * w32fns.c (Fw32_register_hot_key): Use XLI instead of checking
2773 USE_LISP_UNION_TYPE.
2774 (Fw32_unregister_hot_key): Likewise.
2775 (Fw32_toggle_lock_key): Likewise.
2776 * w32menu.c (add_menu_item): Likewise.
2777 (w32_menu_display_help): Use XIL instead of checking
2778 USE_LISP_UNION_TYPE.
2779 * w32heap.c (allocate_heap): Don't check USE_LISP_UNION_TYPE.
2780 (init_heap): Likewise.
2781 * w32term.c (w32_read_socket): Update comment.
2782
1d3823c9
GM
27832012-06-13 Glenn Morris <rgm@gnu.org>
2784
c62ff706
GM
2785 * s/usg5-4-common.h, src/s/unixware.h:
2786 Remove define/undef of HAVE_SYSV_SIGPAUSE (not used since 2010-05-04).
2787
1d3823c9
GM
2788 * s/gnu.h (POSIX_SIGNALS): Remove (not used since 2010-05-04).
2789
bfe3e0a2
PE
27902012-06-13 Paul Eggert <eggert@cs.ucla.edu>
2791
2792 USE_LISP_UNION_TYPE + USE_LSB_TAG cleanup (Bug#11604)
2793 * alloc.c (make_number) [!defined make_number]:
2794 Remove, as lisp.h always defines this now.
2795 (mark_maybe_pointer): Simplify since USE_LSB_TAG is always defined now.
2796 (roundup_size): Verify that it is a power of 2.
2797 * data.c (Fmake_variable_buffer_local, Fmake_local_variable):
2798 * ftfont.c (ftfont_driver): Use LISP_INITIALLY_ZERO.
2799 * lisp.h (USE_LSB_TAG): Allow the builder to compile with
2800 -DUSE_LSB_TAG=0, to override the automatically-selected default.
2801 USE_LSB_TAG now is always defined to be either 0 or 1.
2802 All uses changed.
2803 (union Lisp_Object): Don't worry about WORDS_BIGENDIAN; the
2804 code works fine either way, and efficiency is not a concern here,
2805 as the union type is for debugging, not for production.
2806 (LISP_MAKE_RVALUE, make_number) [USE_LISP_UNION_TYPE]:
2807 Use an inline function on all platforms when using the union type,
2808 since this is simpler and 'static inline' can be used portably
2809 within Emacs now.
2810 (LISP_INITIALLY_ZERO): New macro.
2811 (XFASTINT, XSETFASTINT) [USE_LISP_UNION_TYPE]: Remove.
2812 (XSET) [USE_LISP_UNION_TYPE]: Don't overparenthesize.
2813
45fa9c0f
GM
28142012-06-12 Glenn Morris <rgm@gnu.org>
2815
b4492cba
GM
2816 * s/gnu-kfreebsd.h, s/hpux11.h, s/openbsd.h, s/sol2-10.h: Remove files.
2817
2818 * s/gnu-linux.h (HAVE_PROCFS): Move to configure.
0d369729 2819
45fa9c0f
GM
2820 * s/hpux10-20.h, s/openbsd.h, s/usg5-4-common.h:
2821 Move BROKEN_SIGIO to configure.
2822
2823 * s/bsd-common.h, s/darwin.h, s/gnu-kfreebsd.h, s/hpux10-20.h:
2824 Move NO_TERMIO to configure.
2825
0e25d334
CY
28262012-06-12 Chong Yidong <cyd@gnu.org>
2827
2828 * image.c (imagemagick_load_image): Use MagickFlattenImage if
2829 MagickMergeImageLayers is undefined. Use pixel pusher loop if
2830 MagickExportImagePixels is undefined.
2831
43682bb6
PE
28322012-06-12 Paul Eggert <eggert@cs.ucla.edu>
2833
2834 * image.c (imagemagick_load_image): Remove unused label.
2835
a9be7d2b
GM
28362012-06-11 Glenn Morris <rgm@gnu.org>
2837
2838 * s/aix4-2.h, s/bsd-common.h, s/cygwin.h, s/darwin.h:
2839 * s/gnu-kfreebsd.h, s/gnu-linux.h, s/gnu.h, s/hpux10-20.h:
2840 * s/irix6-5.h, s/ms-w32.h, s/msdos.h, s/template.h:
2841 * s/usg5-4-common.h: Move SYSTEM_TYPE to configure.
2842
3017f87f
SM
28432012-06-11 Stefan Monnier <monnier@iro.umontreal.ca>
2844
2845 * alloc.c (make_byte_code): New function.
2846 (Fmake_byte_code): Use it. Don't purify here.
2847 * lread.c (read1): Use it as well to avoid extra allocation.
2848
1b9b4cf4
CY
28492012-06-11 Chong Yidong <cyd@gnu.org>
2850
2851 * image.c (imagemagick_load_image): Implement transparency.
2852
95988fcf
AS
28532012-06-10 Andreas Schwab <schwab@linux-m68k.org>
2854
2855 * regex.c (at_begline_loc_p): Also recognize `(?N:' and correctly
2856 account for preceding backslashes. (Bug#11663)
2857
cd4eb164
CY
28582012-06-09 Chong Yidong <cyd@gnu.org>
2859
2860 * term.c: Support italics in capable terminals (Bug#9652).
2861 (no_color_bit): Replace unused NC_BLINK with NC_ITALIC.
2862 (turn_on_face): Output using TS_enter_italic_mode if available.
2863 Don't handle unused blinking and alt-charset cases.
2864 (turn_off_face): Handle italic case; discard unused tty_blinking_p
2865 and tty_alt_charset_p cases.
2866 (tty_capable_p, init_tty): Support italics.
2867
2868 * termchar.h (struct tty_display_info): Add field for italics.
2869 Remove unused blink field.
2870
2871 * xfaces.c (tty_supports_face_attributes_p, realize_tty_face):
2872 Handle slant.
2873
2874 * dispextern.h: Replace unused TTY_CAP_BLINK with TTY_CAP_ITALIC.
2875 (struct face): Remove unused fields tty_dim_p, tty_blinking_p, and
2876 tty_alt_charset_p. Add tty_italic_p.
2877
ff88beb8
MA
28782012-06-09 Michael Albinus <michael.albinus@gmx.de>
2879
2880 * dbusbind.c (XD_BASIC_DBUS_TYPE): Use dbus_type_is_valid and
2881 dbus_type_is_basic if available.
2882 (xd_extract_signed, xd_extract_unsigned): Rename from
2883 extract_signed and extract_unsigned, respectively. Adapt callers.
2884
44286096
CY
28852012-06-09 Chong Yidong <cyd@gnu.org>
2886
1682701f
CY
2887 * xfaces.c (face_for_overlay_string): Handle face remapping (Bug#2066).
2888
44286096
CY
2889 * fringe.c (Fset_fringe_bitmap_face): Handle the noninteractive
2890 case (Bug#9752).
2891
d86feb17
PE
28922012-06-08 Paul Eggert <eggert@cs.ucla.edu>
2893
2894 * xdisp.c (vmessage): Treat frame message as multibyte.
2895 Without this change, (let ((§ 1)) (make-variable-buffer-local '§))
2896 would generate the diagnostic "Making \302\247 buffer-local while
2897 let-bound!".
2898
d5c20fe8
EZ
28992012-06-08 Eli Zaretskii <eliz@gnu.org>
2900
2901 * dispnew.c (showing_window_margins_p): Undo last change, which
2902 was done due to an inadvertent commit.
2903 (adjust_frame_glyphs_for_frame_redisplay): Do call
2904 showing_window_margins_p.
2905
513749ee
SM
29062012-06-08 Stefan Monnier <monnier@iro.umontreal.ca>
2907
2908 * eval.c (Fmake_var_non_special): New primitive.
2909 (syms_of_eval): Defsubr it.
2910 * lread.c (syms_of_lread): Mark `values' as lexically scoped.
2911
d4a8f5c1
JB
29122012-06-08 Juanma Barranquero <lekktu@gmail.com>
2913
2914 * dispnew.c (showing_window_margins_p): Wrap in #if 0 to prevent unused
2915 function warning (the only call is inside #if 0 since 2012-06-08T08:44:45Z!eliz@gnu.org).
2916
8bbbc977
EZ
29172012-06-08 Eli Zaretskii <eliz@gnu.org>
2918
2919 * alloc.c (allocate_vectorlike): Fix last change.
2920
f3372c87
DA
29212012-06-08 Dmitry Antipov <dmantipov@yandex.ru>
2922
2923 Block-based vector allocation of small vectors.
2924 * lisp.h (struct vectorlike_header): New field `nbytes',
2925 adjust comment accordingly.
2926 * alloc.c (enum mem_type): New type `MEM_TYPE_VECTOR_BLOCK'
2927 to denote vector blocks. Adjust users (live_vector_p,
2928 mark_maybe_pointer, valid_lisp_object_p) accordingly.
2929 (COMMON_MULTIPLE): Move outside #if USE_LSB_TAG.
2930 (VECTOR_BLOCK_SIZE, vroundup, VECTOR_BLOCK_BYTES),
2931 (VBLOCK_BYTES_MIN, VBLOCK_BYTES_MAX, VECTOR_MAX_FREE_LIST_INDEX),
2932 (VECTOR_FREE_LIST_FLAG, ADVANCE, VINDEX, SETUP_ON_FREE_LIST),
2933 (VECTOR_SIZE, VECTOR_IN_BLOCK): New macros.
2934 (roundup_size): New constant.
2935 (struct vector_block): New data type.
2936 (vector_blocks, vector_free_lists, zero_vector): New variables.
513749ee 2937 (all_vectors): Rename to `large_vectors'.
f3372c87
DA
2938 (allocate_vector_from_block, init_vectors, allocate_vector_from_block)
2939 (sweep_vectors): New functions.
2940 (allocate_vectorlike): Return `zero_vector' as the only vector of
2941 0 items. Allocate new vector from block if vector size is less than
2942 or equal to VBLOCK_BYTES_MAX.
2943 (Fgarbage_collect): Move all vector sweeping code to sweep_vectors.
2944 (init_alloc_once): Add call to init_vectors.
2945
4f18a4ed
SM
29462012-06-08 Stefan Monnier <monnier@iro.umontreal.ca>
2947
2948 * eval.c (Fmacroexpand): Stop if the macro returns the same form.
2949
86f158bc
PE
29502012-06-07 Paul Eggert <eggert@cs.ucla.edu>
2951
2952 * doprnt.c (doprnt): Truncate multibyte char correctly.
2953 Without this change, doprnt (buf, 2, "%s", FORMAT_END, AP)
2954 would mishandle a string argument "Xc" if X was a multibyte
2955 character of length 2: it would truncate after X's first byte
2956 rather than including all of X.
2957
c5cfcbe0
CY
29582012-06-06 Chong Yidong <cyd@gnu.org>
2959
2960 * buffer.c (word_wrap): Doc fix.
2961
c05cf390
PE
29622012-06-04 Paul Eggert <eggert@cs.ucla.edu>
2963
2964 * xdisp.c (note_mode_line_or_margin_highlight): Pacify gcc -Wall.
2965
0c3461de
GM
29662012-06-03 Glenn Morris <rgm@gnu.org>
2967
2968 * xdisp.c (tool-bar-style): Doc fix.
2969
c71232db
UM
29702012-06-03 Ulrich Müller <ulm@gentoo.org>
2971
2972 * Makefile.in (PAXCTL): Define.
2973 (temacs$(EXEEXT)): Disable memory randomization for the temacs
2974 binary via PaX flags if the paxctl utility is available.
2975 (emacs$(EXEEXT), bootstrap-emacs$(EXEEXT)):
2976 Restore PaX flags to their default. (Bug#11398)
2977
383f7350
CY
29782012-06-03 Chong Yidong <cyd@gnu.org>
2979
2980 * xdisp.c (decode_mode_spec_coding): Display a space for a unibyte
2981 buffer (Bug#11226).
2982
5f2c76c6
CY
29832012-06-03 Chong Yidong <cyd@gnu.org>
2984
2985 * xdisp.c (calc_pixel_width_or_height): Use Fbuffer_local_value.
2986 (note_mode_line_or_margin_highlight): If there is no help echo,
2987 use mode-line-default-help-echo. Handle the case where the mouse
2988 position is past the end of the mode line string.
2989
2990 * buffer.c (buffer_local_value_1): New function, split from
2991 Fbuffer_local_value; can return Qunbound.
2992 (Fbuffer_local_value): Use it.
2993 (Vmode_line_format): Docstring tweaks.
2994
773d47f6
PE
29952012-06-02 Paul Eggert <eggert@cs.ucla.edu>
2996
2997 * sysdep.c (system_process_attributes): Improve comment.
2998
f2d6a3df
SM
29992012-06-02 Stefan Monnier <monnier@iro.umontreal.ca>
3000
3001 * keyboard.c: Export real-this-command to Elisp.
3002 (syms_of_keyboard): Rename real_this_command to Vreal_this_command
3003 and DEFVAR it. Update all users.
3004
63810350
PE
30052012-06-02 Paul Eggert <eggert@cs.ucla.edu>
3006
7bd5c1f4
PE
3007 * minibuf.c (Fassoc_string): Remove duplicate declaration.
3008
63810350
PE
3009 * sysdep.c (system_process_attributes) [SOLARIS2 && HAVE_PROCFS]:
3010 Convert pctcpu and pctmem to Lisp float properly.
3011 Let the compiler fold better, as 100.0/0x8000 is exact.
3012
a2821611
AS
30132012-06-02 Andreas Schwab <schwab@linux-m68k.org>
3014
3015 * alloc.c (CONS_BLOCK_SIZE): Account for padding at the end of
3016 cons_block.
3017
5fceba1d
PE
30182012-06-01 Paul Eggert <eggert@cs.ucla.edu>
3019
3020 * xfns.c (x_set_tool_bar_lines) [USE_GTK]: Adjust to bitfield change.
3021
c98ff5dd
DA
30222012-06-01 Dmitry Antipov <dmantipov@yandex.ru>
3023
3024 For a 'struct window', replace some Lisp_Object fields to
3025 bitfields where appropriate, remove unused fields.
3026 * window.h (struct window): Remove unused 'last_mark_x' and
3027 'last_mark_y' fields. Rename 'mini_p' field to 'mini',
3028 change it's type from Lisp_Object to bitfield.
3029 Change type of 'force_start', 'optional_new_start',
3030 'last_had_star', 'update_mode_line' and 'start_at_line_beg'
3031 fields from Lisp_Object to bitfield. Adjust users accordingly.
3032
ca34e0be
PE
30332012-05-31 Paul Eggert <eggert@cs.ucla.edu>
3034
3035 Pacify gcc -Wdouble-precision when using Xaw.
3036 * xterm.c (xaw_jump_callback, x_set_toolkit_scroll_bar_thumb)
3037 [HAVE_X_WINDOWS && USE_TOOLKIT_SCROLL_BARS && !USE_MOTIF && !USE_GTK]:
3038 Use 'float' consistently, rather than 'float' in most places
3039 and 'double' in a couple of places.
3040
efc00ab1 30412012-05-31 Eli Zaretskii <eliz@gnu.org>
d5fd2c54
EZ
3042
3043 * xdisp.c (handle_stop): Detect whether we have overlay strings
3044 loaded by testing it->current.overlay_string_index to be
3045 non-negative, instead of checking whether n_overlay_strings is
3046 positive. (Bug#11587)
3047
efc00ab1 30482012-05-31 Chong Yidong <cyd@gnu.org>
353c87f6
CY
3049
3050 * keymap.c (describe_map_tree): Revert 2011-07-07 change (Bug#1169).
3051
3052 * doc.c (Fsubstitute_command_keys): Doc fix.
3053
efc00ab1 30542012-05-31 Eli Zaretskii <eliz@gnu.org>
a02ae4e5
EZ
3055
3056 * search.c (search_buffer): Remove calls to
3057 r_alloc_inhibit_buffer_relocation, as it is now called by
3058 maybe_unify_char, which was the cause of relocation of buffer text
3059 in bug#11519.
3060
efc00ab1 30612012-05-31 Eli Zaretskii <eliz@gnu.org>
291d430f
EZ
3062
3063 * charset.c (maybe_unify_char): Inhibit relocation of buffer text
3064 for the duration of call to load_charset, to avoid problems with
3065 callers of maybe_unify_char that access buffer text through C
3066 pointers.
3067
3068 * ralloc.c (r_alloc_inhibit_buffer_relocation): Increment and
3069 decrement the inhibition flag, instead of just setting or
3070 resetting it.
3071
ba93a187
PE
30722012-05-31 Paul Eggert <eggert@cs.ucla.edu>
3073
3074 Remove obsolete '#define static' cruft.
3075 * s/hpux10-20.h (_FILE_OFFSET_BITS): Don't #undef.
3076 This #undef was "temporary" in 2000; it is no longer needed
3077 now that '#define static' has gone away.
3078 * xfns.c, xterm.h (gray_bitmap_width, gray_bitmap_height)
3079 (gray_bitmap_bits): Remove; no longer needed.
3080 All uses replaced with definiens.
3081 * xterm.c: Include "bitmaps/gray.xbm".
3082
9e4bf381
PE
30832012-05-30 Paul Eggert <eggert@cs.ucla.edu>
3084
3085 Clean up __executable_start, monstartup when --enable-profiling.
3086 The following changes affect the code only when profiling.
3087 * dispnew.c (__executable_start): Rename from safe_bcopy.
3088 Define only on platforms that need it.
3089 * emacs.c: Include <sys/gmon.h> when profiling.
3090 (_mcleanup): Remove decl, since <sys/gmon.h> does it now.
3091 (__executable_start): Remove decl, since lisp.h does it now.
3092 (safe_bcopy): Remove decl; no longer has that name.
3093 (main): Coalesce #if into single bit of code, for simplicity.
3094 Cast pointers to uintptr_t, since standard libraries want integers
3095 and not pointers.
3096 * lisp.h (__executable_start): New decl.
3097
32d72c2f
GM
30982012-05-31 Glenn Morris <rgm@gnu.org>
3099
3100 * image.c (Fimagemagick_types): Doc fix.
3101
baac5bc7
JM
31022012-05-30 Jim Meyering <meyering@redhat.com>
3103
3104 * callproc.c (Fcall_process_region): Include directory component
3105 in mkstemp error message (Bug#11586).
3106
72cb32cf
PE
31072012-05-30 Paul Eggert <eggert@cs.ucla.edu>
3108
3109 * alloc.c, lisp.h (make_pure_vector): Now static.
3110
61b108cc
SM
31112012-05-30 Stefan Monnier <monnier@iro.umontreal.ca>
3112
3113 * eval.c (Fdefun, Fdefmacro, Vmacro_declaration_function):
3114 Move to byte-run.el.
3115 (Fautoload): Do the hash-doc more carefully.
3116 * data.c (Fdefalias): Purify definition, except for keymaps.
3117 (Qdefun): Move from eval.c.
3118 * lisp.h (Qdefun): Remove.
3119 * lread.c (read1): Tiny simplification.
3120
471fe23d
TN
31212012-05-29 Troels Nielsen <bn.troels@gmail.com>
3122
934f3f58 3123 Do not create empty overlays with the evaporate property (Bug#9642).
471fe23d
TN
3124 * buffer.c (Fmove_overlay): Reinstate the earlier fix for
3125 Bug#9642, but explicitly check that the buffer the overlay would
3126 be moved to is live and rearrange lines to make sure that errors
3127 will not put the overlay in an inconsistent state.
3128 (Fdelete_overlay): Cosmetics.
3129
85d0efd1
EZ
31302012-05-28 Eli Zaretskii <eliz@gnu.org>
3131
3132 * w32term.c (my_bring_window_to_top): New function.
3133 (x_raise_frame): Use handle returned by DeferWindowPos, which
61b108cc
SM
3134 could be different from the original one.
3135 Call my_bring_window_to_top instead of my_set_foreground_window.
85d0efd1
EZ
3136 (Bug#11513)
3137
3138 * w32fns.c (w32_wnd_proc): Accept and process WM_EMACS_BRINGTOTOP
3139 by calling BringWindowToTop.
3140
3141 * w32term.h (WM_EMACS_BRINGTOTOP): New message.
3142 (WM_EMACS_END): Increase by one.
3143
da92a98c
PE
31442012-05-28 Paul Eggert <eggert@cs.ucla.edu>
3145
3146 * bidi.c (bidi_mirror_char): Put eassert before conversion to int.
3147 This avoids undefined behavior that might cause the eassert
3148 to not catch an out-of-range value.
3149
74d1f848
JB
31502012-05-28 Juanma Barranquero <lekktu@gmail.com>
3151
3152 * makefile.w32-in ($(BLD)/w32inevt.$(O), $(BLD)/w32console.$(O)):
3153 Update dependencies.
3154
9e1a06fc
EZ
31552012-05-27 Eli Zaretskii <eliz@gnu.org>
3156
3157 * bidi.c (bidi_mirror_char): Fix last change.
3158
f3dd7312
AS
31592012-05-27 Andreas Schwab <schwab@linux-m68k.org>
3160
3161 * unexmacosx.c (copy_data_segment): Truncate after 16 characters
3162 when referring to sectname field in printf format.
3163
81899c91
PE
31642012-05-27 Paul Eggert <eggert@cs.ucla.edu>
3165
57b81a9f
PE
3166 * lisp.h [REL_ALLOC]: Omit duplicate prototypes.
3167 Only r_alloc_inhibit_buffer_relocation needed to be added;
3168 the others were already declared.
3169
81899c91
PE
3170 * bidi.c (bidi_mirror_char): Don't possibly truncate the integer
3171 before checking whether it's out of range. Put the check inside
3172 eassert. See
3173 <http://lists.gnu.org/archive/html/emacs-devel/2012-05/msg00485.html>.
3174
33017faf 31752012-05-27 Ken Brown <kbrown@cornell.edu>
2f9b9adb
KB
3176
3177 * callproc.c (Fcall_process): Restore a line that was accidentally
3178 commented out in the 2011-02-13 change (bug#11547).
3179
33017faf 31802012-05-27 Eli Zaretskii <eliz@gnu.org>
52c55cc7
EZ
3181
3182 * lisp.h [REL_ALLOC]: Add prototypes for external functions
3183 defined on ralloc.c.
3184
3185 * buffer.c [REL_ALLOC]: Remove prototypes of
3186 r_alloc_reset_variable, r_alloc, r_re_alloc, and r_alloc_free,
3187 they are now on lisp.h.
3188
3189 * ralloc.c (r_alloc_inhibit_buffer_relocation): New function.
3190
3191 * search.c (search_buffer): Use it to inhibit relocation of buffer
3192 text while re_search_2 is doing its job, because re_search_2 is
3193 passed C pointers to buffer text. (Bug#11519)
3194
23415acf
EZ
3195 * msdos.c (internal_terminal_init) <Vwindow_system_version>:
3196 Update value to 24.
3197
44e27368
EZ
3198 * xdisp.c (move_it_to): Under MOVE_TO_Y, when restoring iterator
3199 state after an additional call to move_it_in_display_line_to, keep
3200 the values of it->max_ascent and it->max_descent found for the
3201 entire line.
3202 (pos_visible_p): Revert the comparison against bottom_y to what it
3203 was in revid eliz@gnu.org-20120513182235-4p6386j761ld0nwb.
3204 (Bug#11464)
3205
c1892f11
PE
32062012-05-26 Paul Eggert <eggert@cs.ucla.edu>
3207
3208 Fix coding-related core dumps with gcc -ftrapv.
3209 The code was computing A - B, where A and B are pointers, and B is
3210 random garbage. This can lead to core dumps on platforms that
3211 have special pointer registers, and it also leads to core dumps on
3212 x86-64 when compiled with gcc -ftrapv. The fix is to compute
3213 A - B only when B is initialized properly.
3214 * coding.c (coding_set_source, coding_set_destination): Return void.
3215 (coding_change_source, coding_change_destinations): New functions,
3216 with the old behaviors of coding_set_source and coding_set_destination.
3217 All callers that need an offset changed to use these new functions.
3218
eb7afdad
GM
32192012-05-26 Glenn Morris <rgm@gnu.org>
3220
3221 * nsterm.m (ns_init_paths): Don't mess with INFOPATH. (Bug#2791)
3222
f12fdf02
EZ
32232012-05-26 Eli Zaretskii <eliz@gnu.org>
3224
53a63be6 3225 Extend mouse support on W32 text-mode console.
61b108cc
SM
3226 * xdisp.c (draw_row_with_mouse_face):
3227 Call tty_draw_row_with_mouse_face for WINDOWSNT as well.
eb3f6f01 3228
eb3f6f01 3229 * w32console.c: Include window.h.
61b108cc
SM
3230 (w32con_write_glyphs_with_face, tty_draw_row_with_mouse_face):
3231 New functions.
eb3f6f01
EZ
3232 (initialize_w32_display): Initialize mouse-highlight data.
3233
53a63be6
EZ
3234 * w32inevt.c: Include termchar.h and window.h.
3235 (do_mouse_event): Support mouse-autoselect-window. When the mouse
3236 moves, call note_mouse_highlight. If help_echo changed, call
3237 gen_help_event to produce help-echo message in the echo area.
3238 Call clear_mouse_face if mouse_face_hidden is set in the mouse
3239 highlight info.
3240
4cfd81f6
PE
32412012-05-26 Paul Eggert <eggert@cs.ucla.edu>
3242
3243 * lread.c (read1): Simplify slightly to avoid an overflow warning
3244 with GCC 4.7.0 on x86-64.
3245
4446092a
EZ
32462012-05-26 Eli Zaretskii <eliz@gnu.org>
3247
3248 * bidi.c (bidi_mirror_char): Revert last change: an int is
3249 definitely wide enough here.
3250
42b2a986 32512012-05-25 Paul Eggert <eggert@cs.ucla.edu>
3164aeac 3252
42b2a986 3253 Fix integer width and related bugs (Bug#9874).
eb106a49 3254 * alloc.c (pure_bytes_used_lisp, pure_bytes_used_non_lisp):
d311d28c
PE
3255 (allocate_vectorlike, buffer_memory_full, struct sdata, SDATA_SIZE)
3256 (string_bytes, check_sblock, allocate_string_data):
3257 (compact_small_strings, Fmake_bool_vector, make_string)
3258 (make_unibyte_string, make_multibyte_string)
3259 (make_string_from_bytes, make_specified_string)
3260 (allocate_vectorlike, Fmake_vector, find_string_data_in_pure)
3261 (make_pure_string, make_pure_c_string, make_pure_vector, Fpurecopy)
3262 (mark_vectorlike):
3263 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3264 (allocate_pseudovector):
3265 Use int, not EMACS_INT, where int is wide enough.
3266 (inhibit_garbage_collection, Fgarbage_collect):
3267 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3268 * bidi.c (bidi_mirror_char): Use EMACS_INT, not int, where
3269 int might not be wide enough.
3270 (bidi_cache_search, bidi_cache_find, bidi_init_it)
3271 (bidi_count_bytes, bidi_char_at_pos, bidi_fetch_char)
3272 (bidi_at_paragraph_end, bidi_find_paragraph_start)
3273 (bidi_paragraph_init, bidi_resolve_explicit, bidi_resolve_weak)
3274 (bidi_level_of_next_char, bidi_move_to_visually_next):
3275 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3276 * buffer.c (copy_overlays, Fgenerate_new_buffer_name)
3277 (Fkill_buffer, Fset_buffer_major_mode)
3278 (advance_to_char_boundary, Fbuffer_swap_text)
3279 (Fset_buffer_multibyte, overlays_at, overlays_in)
3280 (overlay_touches_p, struct sortvec, record_overlay_string)
3281 (overlay_strings, recenter_overlay_lists)
3282 (adjust_overlays_for_insert, adjust_overlays_for_delete)
3283 (fix_start_end_in_overlays, fix_overlays_before, modify_overlay)
3284 (Fmove_overlay, Fnext_overlay_change, Fprevious_overlay_change)
3285 (Foverlay_recenter, last_overlay_modification_hooks_used)
3286 (report_overlay_modification, evaporate_overlays, enlarge_buffer_text):
3287 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
977b0e45
PE
3288 (validate_region): Omit unnecessary test for b <= e,
3289 since that's guaranteed by the previous test.
d311d28c
PE
3290 (adjust_overlays_for_delete): Avoid pos + length overflow.
3291 (Fmove_overlay, Fdelete_overlay, add_overlay_mod_hooklist)
3292 (report_overlay_modification):
3293 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3294 (Foverlays_at, Fnext_overlay_change, Fprevious_overlay_change):
3295 Omit pointer cast, which isn't needed anyway, and doesn't work
3296 after the EMACS_INT -> ptrdiff_t change.
02481186 3297 (Fmove_overlay): Clip BEG and END to ptrdiff_t to avoid overflow.
d311d28c
PE
3298 * buffer.h: Adjust decls to match defn changes elsewhere.
3299 (struct buffer_text, struct buffer):
3300 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3301 Use EMACS_INT, not int, where int might not be wide enough.
39b5db3b
PE
3302 * bytecode.c (unmark_byte_stack, exec_byte_code): Use ptrdiff_t,
3303 not int, to avoid needless 32-bit limit on 64-bit hosts.
3304 (exec_byte_code): Use tighter memory-full test, one that checks
3305 for alloca overflow. Don't compute the address of the object just
3306 before an array, as that's not portable. Use EMACS_INT, not
3307 ptrdiff_t or int, where ptrdiff_t or int might not be wide enough.
d311d28c
PE
3308 * callint.c (Fcall_interactively):
3309 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3310 * callproc.c (call_process_kill, Fcall_process):
3311 Don't assume pid_t fits into an Emacs fixnum.
3312 (call_process_cleanup, Fcall_process, child_setup):
3313 Don't assume pid_t fits into int.
3314 (call_process_cleanup, Fcall_process, delete_temp_file)
3315 (Fcall_process_region):
3316 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3317 (Fcall_process): Simplify handling of volatile integers.
3318 Use int, not EMACS_INT, where int will do.
3319 * casefiddle.c (casify_object, casify_region, operate_on_word)
3320 (Fupcase_word, Fdowncase_word, Fcapitalize_word):
3321 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3322 (casify_object): Avoid integer overflow when overallocating buffer.
3323 * casetab.c (set_identity, shuffle): Prefer int to unsigned when
45c2afd6 3324 either works. Use lint_assume to convince GCC 4.6.1 that it's OK.
d311d28c
PE
3325 * category.c (Fchar_category_set): Don't assume fixnum fits in int.
3326 * category.h (CATEGORYP): Don't assume arg is nonnegative.
3327 * ccl.c (GET_CCL_INT): Remove; no longer needed, since the
3328 integers are now checked earlier. All uses replaced with XINT.
3329 (ccl_driver):
3330 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3331 For CCL_MapSingle, check that content and value are in int range.
c801946a
PE
3332 (ccl_driver, Fregister_code_conversion_map):
3333 Check that Vcode_version_map_vector is a vector.
d311d28c
PE
3334 (resolve_symbol_ccl_program): Check that vector header is in range.
3335 Always copy the vector, so that we can check its contents reliably
3336 now rather than having to recheck each instruction as it's being
3337 executed. Check that vector words fit in 'int'.
3338 (ccl_get_compiled_code, Fregister_ccl_program)
3339 (Fregister_code_conversion_map): Use ptrdiff_t, not int, for
3340 program indexes, to avoid needless 32-bit limit on 64-bit hosts.
3341 (Fccl_execute, Fccl_execute_on_string): Check that initial reg
3342 contents are in range.
3343 (Fccl_execute_on_string): Check that status is in range.
3344 * ccl.h (struct ccl_program.idx): Now ptrdiff_t, not int.
3345 * character.c (char_resolve_modifier_mask, Fchar_resolve_modifiers):
3346 Accept and return EMACS_INT, not int, because callers can pass values
3347 out of 'int' range.
3348 (c_string_width, strwidth, lisp_string_width, chars_in_text)
3349 (multibyte_chars_in_text, parse_str_as_multibyte)
3350 (str_as_multibyte, count_size_as_multibyte, str_to_multibyte)
3351 (str_as_unibyte, str_to_unibyte, string_count_byte8)
3352 (string_escape_byte8, Fget_byte):
3353 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
a14e1568 3354 (Funibyte_string): Use CHECK_RANGED_INTEGER, not CHECK_NATNUM, to
d311d28c
PE
3355 avoid mishandling large integers.
3356 * character.h: Adjust decls to match defn changes elsewhere.
3357 * charset.c (load_charset_map_from_file, find_charsets_in_text)
3358 (Ffind_charset_region):
3359 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3360 (load_charset_map_from_file): Redo idx calculation to avoid overflow.
3361 (load_charset_map_from_vector, Fdefine_charset_internal):
3c7649c1 3362 Don't assume fixnum fits in int.
d311d28c
PE
3363 (load_charset_map_from_vector, Fmap_charset_chars):
3364 Remove now-unnecessary CHECK_NATNUMs.
3365 (Fdefine_charset_internal): Check ranges here, more carefully.
3c7649c1
PE
3366 Don't rely on undefined behavior with signed left shift overflow.
3367 Don't assume unsigned int fits into fixnum, or that fixnum fits
3368 into unsigned int. Don't require max_code to be a valid fixnum;
3369 that's not true for gb10830 4-byte on a 32-bit host. Allow
3370 invalid_code to be a cons, for the same reason. Require code_offset
3371 to be a character. Avoid int overflow if max_char is close
3372 to INT_MAX.
3373 (CODE_POINT_TO_INDEX): On 32-bit hosts, return int, not unsigned;
3374 this is intended anyway and avoids some undefined behavior.
3375 (load_charset_map): Pass unsigned, not int, as 2nd arg of
3376 INDEX_TO_CODE_POINT, as that's what it expects.
3377 (Funify_charset, encode_char): Don't stuff unsigned vals into int vars.
60ad3eab
PE
3378 * charset.h (DECODE_CHAR): Return int, not unsigned;
3379 this is what was intended anyway, and it avoids undefined behavior.
3380 (CHARSET_OFFSET): Remove unused macro, instead of fixing its
3381 integer-overflow issues.
3382 (ENCODE_CHAR): Return unsigned on all hosts, not just on 32-bit hosts.
3383 Formerly, it returned EMACS_INT on 64-bit hosts in the common case
3384 where the argument is EMACS_INT, and this behavior is not intended.
d311d28c
PE
3385 * chartab.c (Fmake_char_table, Fset_char_table_range)
3386 (uniprop_get_decoder, uniprop_get_encoder):
3387 Don't assume fixnum fits in int.
3388 * cmds.c (move_point): New function, that does the gist of
3389 Fforward_char and Fbackward_char, but does so while checking
3390 for integer overflow more accurately.
c96e5d6a 3391 (Fforward_char, Fbackward_char): Use it.
d311d28c
PE
3392 (Fforward_line, Fend_of_line, internal_self_insert)
3393 (internal_self_insert):
3394 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3395 Fix a FIXME, by checking for integer overflow when calculating
3396 target_clm and actual_clm.
3397 * coding.c (detect_coding_XXX, encode_coding_XXX, CODING_DECODE_CHAR)
8f50130c 3398 (CODING_ENCODE_CHAR, CODING_CHAR_CHARSET, CODING_CHAR_CHARSET_P)
d311d28c
PE
3399 (ASSURE_DESTINATION, coding_alloc_by_realloc)
3400 (coding_alloc_by_making_gap, alloc_destination)
3401 (detect_coding_utf_8, encode_coding_utf_8, decode_coding_utf_16)
3402 (encode_coding_utf_16, detect_coding_emacs_mule)
3403 (decode_coding_emacs_mule, encode_coding_emacs_mule)
3404 (detect_coding_iso_2022, decode_coding_iso_2022)
3405 (encode_invocation_designation, encode_designation_at_bol)
3406 (encode_coding_iso_2022, detect_coding_sjis, detect_coding_big5)
3407 (decode_coding_sjis, decode_coding_big5, encode_coding_sjis)
3408 (encode_coding_big5, detect_coding_ccl, decode_coding_ccl)
3409 (encode_coding_ccl, encode_coding_raw_text)
3410 (detect_coding_charset, decode_coding_charset)
3411 (encode_coding_charset, detect_eol, decode_eol, produce_chars)
3412 (produce_composition, produce_charset, produce_annotation)
3413 (decode_coding, handle_composition_annotation)
3414 (handle_charset_annotation, consume_chars, decode_coding_gap)
3415 (decode_coding_object, encode_coding_object, detect_coding_system)
3416 (Ffind_coding_systems_region_internal, Fcheck_coding_systems_region)
3417 (code_convert_region, code_convert_string)
8f50130c
PE
3418 (Fdefine_coding_system_internal)
3419 (coding_set_source, coding_set_destination):
d311d28c
PE
3420 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3421 (setup_iso_safe_charsets, consume_chars, Funencodable_char_position)
3422 (Fdefine_coding_system_internal):
3423 Don't assume fixnums fit in int.
3424 (decode_coding_gap, decode_coding_object, encode_coding_object)
5895d7b9 3425 (Fread_coding_system, Fdetect_coding_region)
2c6a9faa
PE
3426 (Funencodable_char_position, Fcheck_coding_systems_region)
3427 (get_translation, handle_composition_annotation, consume_chars):
d311d28c 3428 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
977b0e45 3429 (consume_chars): Rewrite to not calculate an address outside buffer.
d311d28c 3430 (Ffind_operation_coding_system): NATNUMP can eval its arg twice.
7b09a37a 3431 Don't access memory outside of the args array.
d311d28c 3432 (Fdefine_coding_system_internal): Check for charset-id overflow.
47664caa
PE
3433 (ENCODE_ISO_CHARACTER): Use unsigned, not int, to store the unsigned
3434 result of ENCODE_CHAR.
d311d28c
PE
3435 * coding.h: Adjust decls to match defn changes elsewhere.
3436 (struct coding_system):
3437 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3438 * composite.c (get_composition_id, find_composition)
3439 (run_composition_function, update_compositions)
3440 (compose_text, composition_gstring_put_cache)
3441 (composition_gstring_p, composition_gstring_width)
3442 (fill_gstring_header, fill_gstring_body, autocmp_chars)
3443 (composition_compute_stop_pos, composition_reseat_it)
3444 (composition_update_it, struct position_record)
3445 (find_automatic_composition, composition_adjust_point)
3446 (Fcomposition_get_gstring, Ffind_composition_internal):
3447 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3448 (update_compositions):
3449 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3450 * composite.h: Adjust decls to match defn changes elsewhere.
3451 (struct composition):
3452 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3453 * data.c (let_shadows_buffer_binding_p, let_shadows_global_binding_p):
3454 Do not attempt to compute the address of the object just before a
3455 buffer; this is not portable.
3456 (Faref, Faset):
3457 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3458 (Faset): Use int, not EMACS_INT, where int is wide enough.
3459 (Fstring_to_number): Don't assume fixnums fit in int.
3460 (Frem): Don't assume arg is nonnegative.
3461 * dbusbind.c (xd_append_arg): Check for integers out of range.
3462 (Fdbus_call_method): Don't overflow the timeout int.
42b2a986 3463 (extract_signed, extract_unsigned): New functions.
243e0530
PE
3464 (XD_CHECK_DBUS_SERIAL): Remove; superseded by extract_unsigned.
3465 (xd_get_connection_references): Return ptrdiff_t, not int.
3466 All uses changed.
3467 (xd_signature, xd_append_arg, xd_retrieve_arg, Fdbus_message_internal)
3468 (xd_read_message_1):
3469 Use int, not unsigned, where the dbus API uses int.
3470 (Fdbus_message_internal): Don't overflow mtype.
3471 (syms_of_dbusbind): Allocate right-sized buffer for integers.
d311d28c
PE
3472 * dired.c (directory_files_internal, file_name_completion, scmp)
3473 (file_name_completion_stat):
3474 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3475 (file_name_completion): Don't overflow matchcount.
3476 (file_name_completion_stat): Use SAFE_ALLOCA, not alloca.
3477 * dispextern.h: Adjust decls to match defn changes elsewhere.
3478 (struct text_pos, struct glyph, struct bidi_saved_info)
3479 (struct bidi_string_data, struct bidi_it, struct composition_it)
3480 (struct it):
3481 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3482 (struct display_pos, struct composition_it, struct it):
3483 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3484 * dispnew.c (increment_matrix_positions)
3485 (increment_row_positions, mode_line_string)
3486 (marginal_area_string):
3487 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
54e1617f 3488 (change_frame_size_1, Fredisplay, Fframe_or_buffer_changed_p):
d311d28c
PE
3489 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3490 (duration_to_sec_usec): New function, to check for overflow better.
3491 (Fsleep_for, sit_for): Use it.
3492 * doc.c (get_doc_string, store_function_docstring):
3493 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3494 (get_doc_string, Fsnarf_documentation):
3495 Use int, not EMACS_INT, where int is wide enough.
3496 (get_doc_string):
3497 Use SAFE_ALLOCA, not alloca.
3498 Check for overflow when converting EMACS_INT to off_t.
3499 * doprnt.c (doprnt):
3500 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3501 * editfns.c (init_editfns, Fuser_uid, Fuser_real_uid):
3502 Don't assume uid_t fits into fixnum.
3503 (buildmark, Fgoto_char, overlays_around, find_field, Fdelete_field)
3504 (Ffield_string, Ffield_string_no_properties, Ffield_beginning)
3505 (Ffield_end, Fconstrain_to_field, Fline_beginning_position)
3506 (Fline_end_position, Fprevious_char, Fchar_after, Fchar_before)
3507 (general_insert_function)
3508 (Finsert_char, make_buffer_string, make_buffer_string_both)
3509 (update_buffer_properties, Fbuffer_substring)
3510 (Fbuffer_substring_no_properties, Fcompare_buffer_substrings)
3511 (Fsubst_char_in_region, check_translation)
3512 (Ftranslate_region_internal, save_restriction_restore, Fformat)
3513 (transpose_markers, Ftranspose_regions):
3514 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3515 (clip_to_bounds): Move to lisp.h as an inline function).
3516 (Fconstrain_to_field): Don't assume integers are nonnegative.
3517 (Fline_beginning_position, Fsave_excursion, Fsave_current_buffer):
3518 (Fsubst_char_in_region, Fsave_restriction):
3519 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3520 (Femacs_pid): Don't assume pid_t fits into fixnum.
3521 (lo_time): Use int, not EMACS_INT, when int suffices.
3522 (lisp_time_argument): Check for usec out of range.
3523 (Fencode_time): Don't assume fixnum fits in int.
3f4eabd1
PE
3524 (Fuser_login_name, Fuser_full_name): Signal an error
3525 if a uid argument is out of range, rather than relying on
3526 undefined behavior.
c8d5c857
PE
3527 (Fformat_time_string): Remove now-unnecessary check.
3528 lisp_time_argument checks for out-of-range usec now.
243e0530 3529 Use ptrdiff_t, not size_t, where ptrdiff_t will do.
d311d28c
PE
3530 * emacs.c (gdb_valbits, gdb_gctypebits): Now int, not EMACS_INT.
3531 (gdb_data_seg_bits): Now uintptr_t, not EMACS_INT.
3532 (PVEC_FLAG, gdb_array_mark_flag): Now ptrdiff_t, not EMACS_INT.
3533 (init_cmdargs, Fdump_emacs):
3534 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3535 (Fkill_emacs): Don't assume fixnum fits in int; instead, take just
3536 the bottom (typically) 32 bits of the fixnum.
3537 * eval.c (specpdl_size, call_debugger):
3538 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3539 (when_entered_debugger, Fbacktrace_debug):
3540 Don't assume fixnum can fit in int.
3541 (Fdefvaralias, Fdefvar): Do not attempt to compute the address of
3542 the object just before a buffer; this is not portable.
3543 (FletX, Flet, Funwind_protect, do_autoload, Feval, funcall_lambda)
3544 (grow_specpdl, unbind_to):
3545 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3546 (Fapply, apply_lambda): Don't assume ptrdiff_t can hold fixnum.
3547 (grow_specpdl): Simplify allocation by using xpalloc.
856bbc81 3548 (Fprog1, Fprog2): Don't assume list length fits in int. Simplify.
d311d28c
PE
3549 * fileio.c (Ffind_file_name_handler, Fcopy_file, Frename_file)
3550 (Finsert_file_contents, Fwrite_region, Fdo_auto_save):
3551 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3552 (Ffind_file_name_handler, non_regular_inserted, Finsert_file_contents)
3553 (a_write, e_write):
3554 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3555 (Fcopy_file, non_regular_nbytes, read_non_regular)
3556 (Finsert_file_contents):
3557 Use int, not EMACS_INT, where int is wide enough.
3558 (READ_BUF_SIZE): Verify that it fits in int.
3559 (Finsert_file_contents): Check that counts are in proper range,
3560 rather than assuming fixnums fit into ptrdiff_t etc.
3561 Don't assume fixnums fit into int.
125b3835 3562 * floatfns.c (Fexpt): Avoid undefined signed * signed overflow.
5895d7b9
PE
3563 * fns.c (Fcompare_strings, Fstring_lessp, struct textprop_rec, concat)
3564 (string_char_byte_cache_charpos, string_char_byte_cache_bytepos)
d311d28c
PE
3565 (string_char_to_byte, string_byte_to_char)
3566 (string_make_multibyte, string_to_multibyte)
3567 (string_make_unibyte, Fstring_as_unibyte, Fstring_as_multibyte)
3568 (Fstring_to_unibyte, Fsubstring, Fsubstring_no_properties)
3569 (substring_both, Fdelete, internal_equal, Ffillarray)
3570 (Fclear_string, mapcar1)
3571 (Fbase64_encode_region, Fbase64_encode_string, base64_encode_1)
3572 (Fbase64_decode_region, Fbase64_decode_string, base64_decode_1)
3573 (larger_vector, make_hash_table, maybe_resize_hash_table)
3574 (hash_lookup, hash_remove_from_table, hash_clear, sweep_weak_table)
3575 (Fmaphash, secure_hash):
3576 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3577 (concat): Check for string index and length overflow.
3578 (Fmapconcat): Don't assume fixnums fit into ptrdiff_t.
3579 (Frequire):
3580 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3581 (larger_vector): New API (vec, incr_min, size_max) replaces old
3582 one (vec, new_size, init). This catches size overflow.
3583 INIT was removed because it was always Qnil.
3584 All callers changed.
3585 (INDEX_SIZE_BOUND): New macro, which calculates more precisely
3586 the upper bound on a hash table index size.
3587 (make_hash_table, maybe_resize_hash_table): Use it.
3588 (secure_hash): Computer start_byte and end_byte only after
3589 they're known to be in ptrdiff_t range.
3590 * font.c (font_intern_prop, font_at, font_range, Ffont_shape_gstring)
3591 (Ffont_get_glyphs, Ffont_at):
3592 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3593 (font_style_to_value, font_prop_validate_style, font_expand_wildcards)
3594 (Flist_fonts, Fopen_font):
3595 Don't assume fixnum can fit in int.
3596 (check_gstring): Don't assume index can fit in int.
3597 (font_match_p): Check that fixnum is a character, not a nonnegative
3598 fixnum, since the later code needs to stuff it into an int.
3599 (font_find_for_lface): Use SAFE_ALLOCA_LISP, not alloca.
3600 (font_fill_lglyph_metrics): Use unsigned, not EMACS_INT, to avoid
3601 conversion overflow issues.
3602 (Fopen_font): Check for integer out of range.
3603 (Ffont_get_glyphs): Don't assume index can fit in int.
3604 * font.h: Adjust decls to match defn changes elsewhere.
3605 * fontset.c (reorder_font_vector): Redo score calculation to avoid
3606 integer overflow.
3607 (num_auto_fontsets, fontset_from_font): Use ptrdiff_t, not
3608 printmax_t, where ptrdiff_t is wide enough.
3609 (Finternal_char_font):
3610 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3611 * frame.c (Fset_mouse_position, Fset_mouse_pixel_position)
3612 (Fset_frame_height, Fset_frame_width, Fset_frame_size)
3613 (Fset_frame_position, x_set_frame_parameters)
3614 (x_set_line_spacing, x_set_border_width)
3615 (x_set_internal_border_width, x_set_alpha, x_figure_window_size):
3616 Check that fixnums are in proper range for system types.
3617 (frame_name_fnn_p, Fframe_parameter, Fmodify_frame_parameters):
3618 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3619 (Fmodify_frame_parameters): Don't assume fixnum fits in int.
3620 Use SAFE_ALLOCA_LISP, not alloca.
3621 * frame.h (struct frame): Use intptr_t, not EMACS_INT, where
3622 intptr_t is wide enough.
3623 * fringe.c (lookup_fringe_bitmap, get_logical_fringe_bitmap)
3624 (Fdefine_fringe_bitmap): Don't assume fixnum fits in int.
3625 (Ffringe_bitmaps_at_pos): Don't assume index fits in int.
3626 Check for fixnum out of range.
3627 * ftfont.c (ftfont_list): Don't assume index fits in int.
3628 Check that fixnums are in proper range for system types.
3629 (ftfont_shape_by_flt):
3630 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
d311d28c
PE
3631 * gnutls.c (emacs_gnutls_write, emacs_gnutls_read):
3632 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3633 (Fgnutls_error_fatalp, Fgnutls_error_string, Fgnutls_boot):
3634 Check that fixnums are in proper range for system types.
3635 * gnutls.h: Adjust decls to match defn changes elsewhere.
3636 * gtkutil.c (xg_dialog_run):
3637 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3638 (update_frame_tool_bar):
3639 Check that fixnums are in proper range for system types.
3640 * image.c (parse_image_spec): Redo count calculation to avoid overflow.
5895d7b9 3641 (lookup_image): Check that fixnums are in range for system types.
d311d28c
PE
3642 * indent.c (last_known_column, last_known_column_point):
3643 (current_column_bol_cache):
3644 (skip_invisible, current_column, check_display_width):
3645 (check_display_width, scan_for_column, current_column_1)
3646 (Findent_to, Fcurrent_indentation, position_indentation)
3647 (indented_beyond_p, Fmove_to_column, compute_motion):
3648 (Fcompute_motion, Fvertical_motion):
3649 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3650 (last_known_column_modified): Use EMACS_INT, not int.
3651 (check_display_width):
3652 (Fcompute_motion):
3653 Check that fixnums and floats are in proper range for system types.
3654 (compute_motion): Don't assume index or fixnum fits in int.
3655 (compute_motion, Fcompute_motion):
3656 Use int, not EMACS_INT, when it is wide enough.
3657 (vmotion): Omit local var start_hpos that is always 0; that way
3658 we don't need to worry about overflow in expressions involving it.
3659 * indent.h: Adjust decls to match defn changes elsewhere.
3660 (struct position):
3661 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3662 Use int, not EMACS_INT, where int is wide enough.
3663 Remove unused members ovstring_chars_done and tab_offset;
3664 all uses removed.
3665 * insdel.c (move_gap, move_gap_both, gap_left, gap_right)
3666 (adjust_markers_for_delete, adjust_markers_for_insert, adjust_point)
3667 (adjust_markers_for_replace, make_gap_larger, make_gap_smaller)
3668 (make_gap, copy_text, insert, insert_and_inherit)
3669 (insert_before_markers, insert_before_markers_and_inherit)
3670 (insert_1, count_combining_before, count_combining_after)
3671 (insert_1_both, insert_from_string)
3672 (insert_from_string_before_markers, insert_from_string_1)
3673 (insert_from_gap, insert_from_buffer, insert_from_buffer_1)
3674 (adjust_after_replace, adjust_after_insert, replace_range)
3675 (replace_range_2, del_range, del_range_1, del_range_byte)
3676 (del_range_both, del_range_2, modify_region)
3677 (prepare_to_modify_buffer, signal_before_change)
3678 (signal_after_change, Fcombine_after_change_execute):
3679 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3680 * intervals.c (traverse_intervals, rotate_right, rotate_left)
3681 (balance_an_interval, split_interval_right, split_interval_left)
3682 (find_interval, next_interval, update_interval)
3683 (adjust_intervals_for_insertion, delete_node, delete_interval)
3684 (interval_deletion_adjustment, adjust_intervals_for_deletion)
3685 (static_offset_intervals, offset_intervals)
3686 (merge_interval_right, merge_interval_left, make_new_interval)
3687 (graft_intervals_into_buffer, temp_set_point_both)
3688 (temp_set_point, set_point, adjust_for_invis_intang)
3689 (set_point_both, move_if_not_intangible, get_property_and_range)
3690 (get_local_map, copy_intervals, copy_intervals_to_string)
3691 (compare_string_intervals, set_intervals_multibyte_1):
3692 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3693 * intervals.h: Adjust decls to match defn changes elsewhere.
3694 (struct interval):
3695 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3696 * keyboard.c (this_command_key_count, this_single_command_key_start)
3697 (before_command_key_count, before_command_echo_length, echo_now)
3698 (echo_length, recursive_edit_1, Frecursive_edit, Ftrack_mouse)
3699 (command_loop_1, safe_run_hooks, read_char, timer_check_2)
3700 (menu_item_eval_property, read_key_sequence, Fread_key_sequence)
3701 (Fread_key_sequence_vector, Fexecute_extended_command, Fsuspend_emacs):
3702 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3703 (last_non_minibuf_size, last_point_position, echo_truncate)
3704 (command_loop_1, adjust_point_for_property, read_char, gen_help_event)
3705 (make_lispy_position, make_lispy_event, parse_modifiers_uncached)
3706 (parse_modifiers, modify_event_symbol, Fexecute_extended_command)
3707 (stuff_buffered_input):
3708 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3709 (last_auto_save, command_loop_1, read_char):
3710 Use EMACS_INT, not int, to avoid integer overflow.
3711 (record_char): Avoid overflow in total_keys computation.
3712 (parse_modifiers_uncached): Redo index calculation to avoid overflow.
3713 * keyboard.h: Adjust decls to match defn changes elsewhere.
3714 * keymap.c (Fdefine_key, Fcurrent_active_maps, accessible_keymaps_1)
3715 (Fkey_description, Fdescribe_vector, Flookup_key):
3716 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3717 (click_position): New function, to check that positions are in range.
3718 (Fcurrent_active_maps):
3719 (describe_command):
3720 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3721 (Faccessible_keymaps, Fkey_description):
3722 (preferred_sequence_p):
3723 Don't assume fixnum can fit into int.
3724 (Fkey_description): Use SAFE_ALLOCA_LISP, not alloca.
3725 Check for integer overflow in size calculations.
3726 (Ftext_char_description): Use CHECK_CHARACTER, not CHECK_NUMBER, to
3727 avoid mishandling large integers.
3728 * lisp.h: Adjust decls to match defn changes elsewhere.
3729 (ARRAY_MARK_FLAG, PSEUDOVECTOR_FLAG, struct Lisp_String)
3730 (struct vectorlike_header, struct Lisp_Subr, struct Lisp_Hash_Table)
3731 (struct Lisp_Marker):
3732 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3733 (clip_to_bounds): Now an inline function, moved here from editfns.c.
d311d28c
PE
3734 (GLYPH_CODE_P): Check for overflow in system types, subsuming the
3735 need for GLYPH_CODE_CHAR_VALID_P and doing proper checking ourselves.
3736 All callers changed.
3737 (GLYPH_CODE_CHAR, GLYPH_CODE_FACE):
3738 Assume the arg has valid form, since it always does.
3739 (TYPE_RANGED_INTEGERP): Avoid bug when checking against a wide
3740 unsigned integer system type.
3741 (CHECK_RANGED_INTEGER, CHECK_TYPE_RANGED_INTEGER): New macros.
3742 (struct catchtag, specpdl_size, SPECPDL_INDEX, USE_SAFE_ALLOCA):
3743 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3744 (struct catchtag): Use EMACS_INT, not int, since it may be a fixnum.
3745 (duration_to_sec_usec): New decl.
3746 * lread.c (read_from_string_index, read_from_string_index_byte)
3747 (read_from_string_limit, readchar, unreadchar, openp)
3748 (read_internal_start, read1, oblookup):
3749 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3750 (Fload, readevalloop, Feval_buffer, Feval_region):
3751 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3752 (openp): Check for out-of-range argument to 'access'.
3753 (read1): Use int, not EMACS_INT, where int is wide enough.
3754 Don't assume fixnum fits into int.
6efdadfd 3755 Fix off-by-one error that can read outside a buffer.
1ab7b8ac
PE
3756 (read_filtered_event): Use duration_to_sec_usec
3757 to do proper overflow checking on durations.
d311d28c
PE
3758 * macros.c (Fstart_kbd_macro): Use xpalloc to check for overflow
3759 in size calculation.
3760 (Fexecute_kbd_macro):
3761 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3762 * marker.c (cached_charpos, cached_bytepos, CONSIDER)
3763 (byte_char_debug_check, buf_charpos_to_bytepos, verify_bytepos)
3764 (buf_bytepos_to_charpos, Fset_marker, set_marker_restricted)
3765 (set_marker_both, set_marker_restricted_both, marker_position)
3766 (marker_byte_position, Fbuffer_has_markers_at):
3767 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3768 (Fset_marker, set_marker_restricted): Don't assume fixnum fits in int.
61b108cc 3769 * menu.c (ensure_menu_items): Rename from grow_menu_items.
d311d28c
PE
3770 It now merely ensures that the menu is large enough, without
3771 necessarily growing it, as this avoids some integer overflow issues.
3772 All callers changed.
3773 (keymap_panes, parse_single_submenu, Fx_popup_menu):
3774 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3775 (parse_single_submenu, Fx_popup_menu): Don't assume fixnum fits in int.
3776 Use SAFE_ALLOCA_LISP, not alloca.
3777 (find_and_return_menu_selection): Avoid unnecessary casts of pointers
3778 to EMACS_INT. Check that fixnums are in proper range for system types.
3779 * minibuf.c (minibuf_prompt_width, string_to_object)
3780 (Fminibuffer_contents, Fminibuffer_contents_no_properties)
3781 (Fminibuffer_completion_contents, Ftry_completion, Fall_completions):
3782 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3783 (get_minibuffer, read_minibuf_unwind):
3784 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3785 (read_minibuf): Omit unnecessary arg BACKUP_N, which is always nil;
3786 this simplifies overflow checking. All callers changed.
3787 (read_minibuf, Fread_buffer, Ftry_completion, Fall_completions)
3788 (Ftest_completion):
3789 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3790 * nsfns.m (check_ns_display_info): Don't assume fixnum fits in long.
3791 (x_set_menu_bar_lines, x_set_tool_bar_lines, Fx_create_frame):
3792 Check that fixnums are in proper range for system types.
3793 (Fx_create_frame, Fx_show_tip):
3794 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3795 * nsfont.m (ns_findfonts, nsfont_list_family):
3796 Don't assume fixnum fits in long.
3797 * nsmenu.m (ns_update_menubar, ns_menu_show, ns_popup_dialog):
3798 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3799 (ns_update_menubar): Use intptr_t, not EMACS_INT, when intptr_t is
3800 wide enough.
17fdb222 3801 * nsselect.m (ns_get_local_selection, clean_local_selection_data):
d311d28c
PE
3802 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3803 * print.c (print_buffer_size, print_buffer_pos, print_buffer_pos_byte)
3804 (PRINTDECLARE, PRINTPREPARE):
3805 (strout, print_string):
3806 (print, print_preprocess, print_check_string_charset_prop)
3807 (print_object):
3808 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3809 (PRINTDECLARE):
3810 (temp_output_buffer_setup, Fprin1_to_string, print_object):
3811 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3812 (PRINTPREPARE): Use int, not ptrdiff_t, where int is wide enough.
d311d28c 3813 (printchar, strout): Use xpalloc to catch size calculation overflow.
0fd11aa5 3814 (Fexternal_debugging_output): Don't overflow EMACS_INT->int conversion.
d311d28c
PE
3815 (print_error_message): Use SAFE_ALLOCA, not alloca.
3816 (print_object): Use int, not EMACS_INT, where int is wide enough.
a8b7caa3
PE
3817 (print_depth, new_backquote_output, print_number_index):
3818 Use ptrdiff_t, not int, where int might not be wide enough.
d311d28c
PE
3819 * process.c (Fdelete_process): Don't assume pid fits into EMACS_INT.
3820 (Fset_process_window_size, Fformat_network_address)
3821 (get_lisp_to_sockaddr_size, set_socket_option, Fmake_network_process)
d44287d4 3822 (sigchld_handler):
d311d28c 3823 Check that fixnums are in proper range for system types.
d44287d4 3824 (Fsignal_process): Simplify by avoiding a goto.
d83cf4cc
PE
3825 Check for process-ids out of pid_t range rather than relying on
3826 undefined behavior.
e4d81efc 3827 (process_tick, update_tick): Use EMACS_INT, not int.
d311d28c
PE
3828 (Fformat_network_address, read_process_output, send_process)
3829 (Fprocess_send_region, status_notify):
3830 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3831 (Fformat_network_address, Fmake_serial_process, Fmake_network_process)
3832 (wait_reading_process_output, read_process_output, exec_sentinel):
3833 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3834 (conv_lisp_to_sockaddr): Don't assume fixnums fit into int.
3835 (Faccept_process_output): Use duration_to_sec_usec to do proper
3836 overflow checking on durations.
dde14581
PE
3837 (emacs_get_tty_pgrp, Fprocess_running_child_p, process_send_signal):
3838 Don't assume pid_t fits in int.
02481186
PE
3839 * process.h (struct Lisp_Process): Members tick and update_tick
3840 are now of type EMACS_INT, not int.
b62b53e8
PE
3841 * puresize.h (PURESIZE_RATIO): Shrink this to 8/6 on 32-bit hosts
3842 configured --with-wide-int.
d311d28c
PE
3843 * scroll.c (calculate_scrolling, calculate_direct_scrolling)
3844 (line_ins_del): Use int, not EMACS_INT, where int is wide enough.
3845 * search.c (looking_at_1, string_match_1):
3846 (fast_string_match, fast_c_string_match_ignore_case)
3847 (fast_string_match_ignore_case, fast_looking_at, scan_buffer)
3848 (scan_newline, find_before_next_newline, search_command)
3849 (trivial_regexp_p, search_buffer, simple_search, boyer_moore)
3850 (set_search_regs, wordify):
3851 (Freplace_match):
3852 (Fmatch_data):
3853 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3854 (string_match_1, search_buffer, set_search_regs):
3855 (Fmatch_data):
3856 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3857 (wordify): Check for overflow in size calculation.
3858 (Freplace_match): Avoid potential buffer overflow in search_regs.start.
3859 (Fset_match_data): Don't assume fixnum fits in ptrdiff_t.
3860 Check that fixnums are in proper range for system types.
3861 * sound.c (struct sound_device)
3862 (wav_play, au_play, vox_write, alsa_period_size, alsa_write):
3863 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3864 (Fplay_sound_internal):
3865 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
eacd378d 3866 * syntax.c (struct lisp_parse_state, find_start_modiff)
d311d28c
PE
3867 (Finternal_describe_syntax_value, scan_lists, scan_sexps_forward):
3868 (Fparse_partial_sexp):
3869 Don't assume fixnums can fit in int.
3870 (struct lisp_parse_state, find_start_pos, find_start_value)
3871 (find_start_value_byte, find_start_begv)
3872 (update_syntax_table, char_quoted, dec_bytepos)
3873 (find_defun_start, prev_char_comend_first, back_comment):
3874 (scan_words, skip_chars, skip_syntaxes, forw_comment, Fforward_comment)
3875 (scan_lists, Fbackward_prefix_chars, scan_sexps_forward):
3876 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3877 (Finternal_describe_syntax_value): Check that match_lisp is a
3878 character, not an integer, since the code stuffs it into int.
3879 (scan_words, scan_sexps_forward):
3880 Check that fixnums are in proper range for system types.
3881 (Fforward_word):
3882 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3883 (scan_sexps_forward):
3884 Use CHARACTERP, not INTEGERP, since the value must fit into int.
3885 (Fparse_partial_sexp): Fix doc; element 8 is not ignored.
3886 * syntax.h: Adjust decls to match defn changes elsewhere.
3887 (struct gl_state_s):
3888 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
e4ecdc9c
PE
3889 (SETUP_SYNTAX_TABLE_FOR_OBJECT): Use PTRDIFF_MAX, not
3890 MOST_POSITIVE_FIXNUM.
d311d28c
PE
3891 * sysdep.c (wait_for_termination_1, wait_for_termination)
3892 (interruptible_wait_for_termination, mkdir):
3893 Don't assume pid_t fits in int; on 64-bit AIX pid_t is 64-bit.
3894 (emacs_read, emacs_write):
3895 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
225a2cff
PE
3896 (system_process_attributes): Don't assume uid_t, gid_t, EMACS_INT,
3897 and double all fit in int.
d311d28c
PE
3898 * term.c (set_tty_color_mode):
3899 Check that fixnums are in proper range for system types.
3900 * termhooks.h (struct input_event):
3901 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3902 * textprop.c (validate_interval_range, interval_of)
3903 (Fadd_text_properties, set_text_properties_1)
3904 (Fremove_text_properties, Fremove_list_of_text_properties)
3905 (Ftext_property_any, Ftext_property_not_all)
3906 (copy_text_properties, text_property_list, extend_property_ranges)
3907 (verify_interval_modification):
3908 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3909 (Fnext_single_char_property_change)
3910 (Fprevious_single_char_property_change):
3911 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
5895d7b9
PE
3912 (copy_text_properties):
3913 Check for integer overflow in index calculation.
d311d28c
PE
3914 * undo.c (last_boundary_position, record_point, record_insert)
3915 (record_delete, record_marker_adjustment, record_change)
3916 (record_property_change):
3917 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3918 (truncate_undo_list, Fprimitive_undo): Don't assume fixnum fits in int.
3919 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3920 * w32fns.c (Fx_create_frame, x_create_tip_frame, Fx_show_tip)
3921 (Fx_hide_tip, Fx_file_dialog):
3922 * w32menu.c (set_frame_menubar):
3923 Use ptrdiff_t, not int, for consistency with rest of code.
3924 * window.c (window_scroll_preserve_hpos, window_scroll_preserve_vpos)
3925 (select_window, Fdelete_other_windows_internal)
3926 (window_scroll_pixel_based, window_scroll_line_based)
3927 (Frecenter, Fset_window_configuration):
3928 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3929 (Fset_window_hscroll, run_window_configuration_change_hook)
3930 (set_window_buffer, temp_output_buffer_show, scroll_command)
5895d7b9 3931 (Fscroll_other_window, Frecenter):
d311d28c
PE
3932 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3933 (Fwindow_line_height, window_scroll, Fscroll_left, Fscroll_right):
3934 Don't assume fixnum fits in int.
3935 (Fset_window_scroll_bars):
3936 Check that fixnums are in proper range for system types.
3937 * xdisp.c (help_echo_pos, pos_visible_p, string_pos_nchars_ahead)
3938 (string_pos, c_string_pos, number_of_chars, init_iterator)
3939 (in_ellipses_for_invisible_text_p, init_from_display_pos)
3940 (compute_stop_pos, next_overlay_change, compute_display_string_pos)
3941 (compute_display_string_end, handle_face_prop)
5895d7b9
PE
3942 (face_before_or_after_it_pos, handle_invisible_prop)
3943 (handle_display_prop, handle_display_spec, handle_single_display_spec)
d311d28c
PE
3944 (display_prop_intangible_p, string_buffer_position_lim)
3945 (string_buffer_position, handle_composition_prop, load_overlay_strings)
3946 (get_overlay_strings_1, get_overlay_strings)
3947 (iterate_out_of_display_property, forward_to_next_line_start)
3948 (back_to_previous_visible_line_start, reseat, reseat_to_string)
3949 (get_next_display_element, set_iterator_to_next)
3950 (get_visually_first_element, compute_stop_pos_backwards)
3951 (handle_stop_backwards, next_element_from_buffer)
3952 (move_it_in_display_line_to, move_it_in_display_line)
3953 (move_it_to, move_it_vertically_backward, move_it_by_lines)
3954 (add_to_log, message_dolog, message_log_check_duplicate)
3955 (message2, message2_nolog, message3, message3_nolog
3956 (with_echo_area_buffer, display_echo_area_1, resize_mini_window_1)
3957 (current_message_1, truncate_echo_area, truncate_message_1)
3958 (set_message, set_message_1, store_mode_line_noprop)
3959 (hscroll_window_tree, debug_delta, debug_delta_bytes, debug_end_vpos)
3960 (text_outside_line_unchanged_p, check_point_in_composition)
3961 (reconsider_clip_changes)
3962 (redisplay_internal, set_cursor_from_row, try_scrolling)
3963 (try_cursor_movement, set_vertical_scroll_bar, redisplay_window)
3964 (redisplay_window, find_last_unchanged_at_beg_row)
3965 (find_first_unchanged_at_end_row, row_containing_pos, try_window_id)
3966 (trailing_whitespace_p, find_row_edges, display_line)
3967 (RECORD_MAX_MIN_POS, Fcurrent_bidi_paragraph_direction)
3968 (display_mode_element, store_mode_line_string)
3969 (pint2str, pint2hrstr, decode_mode_spec)
3970 (display_count_lines, display_string, draw_glyphs)
3971 (x_produce_glyphs, x_insert_glyphs)
3972 (rows_from_pos_range, mouse_face_from_buffer_pos)
3973 (fast_find_string_pos, mouse_face_from_string_pos)
3974 (note_mode_line_or_margin_highlight, note_mouse_highlight):
3975 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3976 (safe_call, init_from_display_pos, handle_fontified_prop)
3977 (handle_single_display_spec, load_overlay_strings)
3978 (with_echo_area_buffer, setup_echo_area_for_printing)
3979 (display_echo_area, echo_area_display)
3980 (x_consider_frame_title, prepare_menu_bars, update_menu_bar)
3981 (update_tool_bar, hscroll_window_tree, redisplay_internal)
5895d7b9
PE
3982 (redisplay_window, dump_glyph_row, display_mode_line)
3983 (Fformat_mode_line, decode_mode_spec, on_hot_spot_p):
43ad2e9a 3984 (handle_display_spec, display_prop_string_p):
d311d28c
PE
3985 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3986 (handle_single_display_spec, build_desired_tool_bar_string)
3987 (redisplay_tool_bar, scroll_window_tree, Fdump_glyph_matrix)
3988 (get_specified_cursor_type):
3989 Check that fixnums are in proper range for system types.
3990 (struct overlay_entry, resize_mini_window, Fdump_glyph_row)
3991 (Flookup_image_map):
3992 Don't assume fixnums fit in int.
3993 (compare_overlay_entries):
3994 Avoid mishandling comparisons due to subtraction overflow.
3995 (load_overlay_strings): Use SAFE_NALLOCA, not alloca.
3996 (last_escape_glyph_face_id, last_glyphless_glyph_face_id):
3997 (handle_tool_bar_click):
3998 Use int, not unsigned, since we prefer signed and the signedness
3999 doesn't matter here.
4000 (get_next_display_element, next_element_from_display_vector):
4001 Use int, not EMACS_INT, when int is wide enough.
4002 (start_hourglass): Use duration_to_sec_usec to do proper
4003 overflow checking on durations.
4004 * xfaces.c (Fbitmap_spec_p):
4005 Check that fixnums are in proper range for system types.
4006 (compare_fonts_by_sort_order):
4007 Avoid mishandling comparisons due to subtraction overflow.
4008 (Fx_family_fonts, realize_basic_faces):
4009 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
4010 (Fx_family_fonts):
4011 Don't assume fixnum fits in int.
4012 Use SAFE_ALLOCA_LISP, not alloca.
4013 (merge_face_heights): Remove unnecessary cast to EMACS_INT.
4014 (Finternal_make_lisp_face): Don't allocate more than MAX_FACE_ID.
4015 (face_at_buffer_position, face_for_overlay_string)
4016 (face_at_string_position):
4017 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
4018 (merge_faces): Use int, not EMACS_INT, where int is wide enough.
4019 * xfns.c (x_set_menu_bar_lines, x_set_tool_bar_lines, x_icon_verify)
4020 (Fx_show_tip):
4021 Check that fixnums are in proper range for system types.
4022 (Fx_create_frame, x_create_tip_frame, Fx_show_tip)
4023 (Fx_hide_tip, Fx_file_dialog, Fx_select_font):
4024 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
4025 (Fx_change_window_property): Don't assume fixnums fit in int.
4026 * xfont.c (xfont_chars_supported):
4027 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
4028 * xmenu.c (Fx_popup_dialog, set_frame_menubar)
4029 (create_and_show_popup_menu, create_and_show_dialog, xmenu_show):
4030 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
4031 * xml.c (parse_region):
4032 * xrdb.c (magic_file_p):
4033 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
4034 * xselect.c (TRACE1): Don't assume pid_t promotes to int.
4035 (x_get_local_selection, x_reply_selection_request)
4036 (x_handle_selection_request, wait_for_property_change):
4037 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
4038 (selection_data_to_lisp_data): Use short, not EMACS_INT, where
4039 short is wide enough.
4040 (x_send_client_event): Don't assume fixnum fits in int.
4041 * xterm.c (x_x_to_emacs_modifiers):
4042 Don't assume EMACS_INT overflows nicely into int.
4043 (x_emacs_to_x_modifiers): Use EMACS_INT, not int, because values
4044 may come from Lisp.
4045 (handle_one_xevent): NATNUMP can eval its arg twice.
4046 (x_connection_closed):
4047 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
4048 * xterm.h: Adjust decls to match defn changes elsewhere.
4049 (struct scroll_bar): Use struct vectorlike_header
4050 rather than rolling our own approximation.
4051 (SCROLL_BAR_VEC_SIZE): Remove; not used.
4052
c6574eb5
GM
40532012-05-25 Glenn Morris <rgm@gnu.org>
4054
4055 * lisp.mk (lisp): Update for more files being compiled now.
4056
e8d32c7e
SM
40572012-05-25 Stefan Monnier <monnier@iro.umontreal.ca>
4058
48def666
SM
4059 * lread.c: Remove `read_pure' which makes no difference.
4060 (read_pure): Remove var.
4061 (unreadpure): Remove function.
4062 (readevalloop): Don't call read_list with -1 flag.
4063 (read1, read_vector): Don't test read_pure any more.
4064 (read_list): Simplify.
4065
e8d32c7e
SM
4066 * fileio.c, character.h: Minor style tweaks.
4067
4b2addb7
DA
40682012-05-24 Dmitry Antipov <dmantipov@yandex.ru>
4069
4070 * window.h (clip_changed): Remove useless declaration.
4071
584461b2
JB
40722012-05-22 Juanma Barranquero <lekktu@gmail.com>
4073
4074 * makefile.w32-in: Follow-up to 2012-05-22T16:20:27Z!eggert@cs.ucla.edu.
4075 (TAGS, TAGS-gmake, CONFIG_H): Remove further references to m/intel386.h.
4076
34374650
PE
40772012-05-22 Paul Eggert <eggert@cs.ucla.edu>
4078
4079 Remove src/m/*.
4080 This directory predates autoconf and is no longer needed nowadays.
4081 Move its few remaining bits of functionality to where they're needed.
4082 * m/README, m/alpha.h, m/amdx86-64.h, m/ia64.h, m/ibmrs6000.h:
4083 * m/ibms390x.h, m/intel386.h, m/m68k.h, m/macppc.h, m/sparc.h:
4084 * m/template.h: Remove.
4085 * Makefile.in (M_FILE): Remove. All uses removed.
4086 * alloc.c (POINTERS_MIGHT_HIDE_IN_OBJECTS):
4087 * lisp.h (USE_LSB_TAG):
4088 * mem-limits.h (EXCEEDS_LISP_PTR):
4089 Use VAL_MAX, not VALBITS, in #if.
4090 * lisp.h (EMACS_INT_MAX): New macro, useful in #if.
4091 (EMACS_UINT): Define unconditionally now.
4092 (BITS_PER_CHAR, BITS_PER_SHORT, BITS_PER_INT, BITS_PER_LONG)
4093 (BITS_PER_EMACS_INT): New constants, replacing
4094 what used to be in config.h, but not useful in #if.
4095 (GCTYPEBITS, VALBITS): Define unconditionally, since m/* files don't
4096 define them any more.
4097 (VAL_MAX): New macro.
4098 (VALMASK): Use it.
4099 * puresize.h (PURESIZE_RATIO): Use EMACS_INT_MAX, not
4100 BITS_PER_EMACS_INT, in #if.
4101 * s/aix4-2.h (BROKEN_FIONREAD, BROKEN_SIGAIO, BROKEN_SIGPTY)
4102 (BROKEN_SIGPOLL): Move here from m/ibmrs6000.h, which was removed.
4103 * s/gnu-linux.h (ULIMIT_BREAK_VALUE) [__i386__]:
4104 * s/ms-w32.h (DATA_START):
4105 Move here from removed file m/intel386.h.
4106 * s/gnu.h (NLIST_STRUCT): Remove undef; 'configure' does this.
4107 * s/irix6-5.h (_LP64): Remove; lisp.h no longer needs this.
4108
261cb4bb
PE
41092012-05-21 Paul Eggert <eggert@cs.ucla.edu>
4110
4111 Assume C89 or later.
4112 * alloc.c, buffer.c, lisp.h: Replace POINTER_TYPE with void.
4113 * alloc.c (overrun_check_malloc, overrun_check_realloc, xmalloc)
4114 (xrealloc):
4115 * buffer.c (mmap_free_1, mmap_enlarge): Omit needless casts.
4116 * editfns.c, fns.c, gmalloc.c, insdel.c, sysdep.c, termcap.c (NULL):
4117 * textprop.c, tparam.c (NULL): Remove.
4118 * ralloc.c, vm-limit.c (POINTER): Assume void * works.
4119 * regex.c (SIGN_EXTEND_CHAR): Assume signed char works.
4120 * regex.h (_RE_ARGS): Remove. All uses rewritten to use prototypes.
4121 * unexelf.c (ElfBitsW): Assume c89 preprocessor or better.
4122 * xterm.c (input_signal_count): Assume volatile works.
4123
ff23cd9f
KB
41242012-05-21 Ken Brown <kbrown@cornell.edu>
4125
4126 * xgselect.c (xg_select): Fix first argument in call to 'select'
4127 (bug#11508).
4128
1b170bc6
KB
41292012-05-20 Ken Brown <kbrown@cornell.edu>
4130
4131 * gmalloc.c (_free_internal_nolock, _realloc_internal_nolock)
bd7239f5 4132 [CYGWIN]: Cast ptr to (char *) before comparing to _heapbase.
1b170bc6 4133
b2f4d39f
KB
41342012-05-19 Ken Brown <kbrown@cornell.edu>
4135
4136 * xfns.c (x_in_use): Remove `static' qualifier.
4137 * xterm.h (x_in_use): Declare.
4138 * xgselect.c: Include xterm.h.
4139 (xg_select): Test `x_in_use' instead of `inhibit_window_system'
4140 and `display_arg' (bug#9754).
4141
003fdae2
PE
41422012-05-19 Paul Eggert <eggert@cs.ucla.edu>
4143
9232a6d9
PE
4144 * s/ms-w32.h (HAVE_GETDOMAINNAME): Remove; not needed.
4145
003fdae2
PE
4146 * m/vax.h: Remove; no longer needed since HAVE_FTIME is being removed.
4147 * s/ms-w32.h (HAVE_FTIME): Remove; not needed.
4148
784b56e2
EZ
41492012-05-18 Eli Zaretskii <eliz@gnu.org>
4150
4151 Fix compilation with -DGLYPH_DEBUG=1 on MS-Windows.
4152
4153 * w32term.c [GLYPH_DEBUG]: Add prototype for x_check_font.
090bd7cb 4154 (x_check_font) [GLYPH_DEBUG]: New function, copied from xterm.c.
784b56e2
EZ
4155
4156 * w32fns.c (unwind_create_frame) [GLYPH_DEBUG]: Fix broken
4157 reference to image_cache->refcount.
4158 (x_create_tip_frame): Fix broken use of FRAME_IMAGE_CACHE.
4159
a0a79cde
JL
41602012-05-17 Juri Linkov <juri@jurta.org>
4161
4162 * search.c (Fword_search_regexp, Fword_search_backward)
4163 (Fword_search_forward, Fword_search_backward_lax)
4164 (Fword_search_forward_lax): Move functions to isearch.el
4165 (bug#10145, bug#11381).
4166
b0572523
PE
41672012-05-16 Paul Eggert <eggert@cs.ucla.edu>
4168
4169 * xgselect.c (xg_select): Just invoke 'select' if -nw (Bug#9754).
4170
9660f5fc
SM
41712012-05-15 Stefan Monnier <monnier@iro.umontreal.ca>
4172
4173 * lread.c (init_obarray): Declare Qt and Qnil as special.
4174
4374de83
GM
41752012-05-14 Glenn Morris <rgm@gnu.org>
4176
4177 * nsterm.m (ns_init_paths): Fix typo ("libexec" not "lib-exec").
985584ae 4178 Put "libexec" before "bin", for the sake of init_callproc_1.
4374de83 4179
dc44c39a
PE
41802012-05-14 Paul Eggert <eggert@cs.ucla.edu>
4181
078c97cb
PE
4182 * keyboard.c (kbd_buffer_get_event) [!HAVE_DBUS]: Omit unused local.
4183
dc44c39a
PE
4184 * unexaix.c: Port to more-recent AIX compilers.
4185 (report_error, report_error_1, make_hdr, copy_sym)
4186 (mark_x, adjust_lnnoptrs, unrelocate_symbols):
4187 Make arguments const char *, not char *, to avoid violations of C
4188 standard and to fix some AIX warnings reported by Gilles Pion.
4189
e18afed7 41902012-05-14 Eli Zaretskii <eliz@gnu.org>
ac268e67
EZ
4191
4192 * xdisp.c (handle_stop): Don't call get_overlay_strings_1 if we
4193 already have overlays loaded.
4194 (handle_single_display_spec): Before returning without displaying
4195 fringe bitmap, synchronize the bidi iterator with the main display
4196 iterator, by calling iterate_out_of_display_property.
4197 (iterate_out_of_display_property): Detect buffer iteration by
4198 testing that it->string is a Lisp string.
4199 (get_next_display_element): When the current object is exhausted,
4200 and there's something on it->stack, call set_iterator_to_next to
4201 proceed with what's on the stack, instead of returning zero.
4202 (set_iterator_to_next): If called at the end of a Lisp string,
4203 proceed to consider_string_end without incrementing string
4204 position. Don't increment display vector index past the end of
4205 the display vector. (Bug#11417)
c8fb9dc6
EZ
4206 (pos_visible_p): Don't report a position visible when move_it_to
4207 stopped at the last line of window, which happens to be scanned
4208 backwards by the bidi iteration. (Bug#11464)
ac268e67 4209
e18afed7 42102012-05-14 Eli Zaretskii <eliz@gnu.org>
82f9b393
EZ
4211
4212 * xdisp.c (handle_single_display_spec): Return 1 for left-margin
4213 and right-margin display specs even if the spec is invalid or we
61b108cc
SM
4214 are on a TTY, and thus unable to display on the fringes.
4215 That's because the text with the property will not be displayed anyway,
82f9b393
EZ
4216 so we need to signal to the caller that this is a "replacing"
4217 display spec. This fixes display when the spec is invalid or we
4218 are on a TTY.
4219
e18afed7 42202012-05-14 Paul Eggert <eggert@cs.ucla.edu>
297834cd
PE
4221
4222 * unexaix.c (make_hdr): Fix typo in prototype.
4223 This bug broke the build on AIX. Problem reported by Gilles Pion.
4224
9d0a235a
MA
42252012-05-14 Michael Albinus <michael.albinus@gmx.de>
4226
4227 * keyboard.c (kbd_buffer_get_event): Read special events also in
4228 batch mode. (Bug#11415)
4229
9e6b06ed
GM
42302012-05-12 Glenn Morris <rgm@gnu.org>
4231
4232 * ns.mk: Update for ns_appbindir no longer having trailing "/".
4233
c1a1d7a3
EZ
42342012-05-12 Eli Zaretskii <eliz@gnu.org>
4235
4236 * lisp.mk (lisp): Add newcomment.elc.
4237
3fe7cdc8
GM
42382012-05-12 Glenn Morris <rgm@gnu.org>
4239
4240 * Makefile.in (MKDIR_P): New, set by configure.
4241 * ns.mk (${ns_appdir}, ${ns_appbindir}Emacs): Use $MKDIR_P.
4242
53f7d2c0
PE
42432012-05-11 Paul Eggert <eggert@cs.ucla.edu>
4244
4245 Remove unused function hourglass_started.
4246 * dispextern.h (hourglass_started):
4247 * w32fns.c (hourglass_started):
4248 * xdisp.c (hourglass_started): Remove.
4249
75aafb17
JB
42502012-05-10 Juanma Barranquero <lekktu@gmail.com>
4251
4252 * makefile.w32-in ($(BLD)/gmalloc.$(O), $(BLD)/w32menu.$(O)):
4253 Update dependencies.
4254
12959e8e
PE
42552012-05-10 Paul Eggert <eggert@cs.ucla.edu>
4256
97107e2e
PE
4257 * xgselect.c (xg_select): Put maxfds+1 into a var.
4258 This is slightly clearer, and pacifies Ubuntu 12.04 gcc.
4259
12959e8e
PE
4260 * sound.c (DEFAULT_ALSA_SOUND_DEVICE): Define only if HAVE_ALSA.
4261
836d29b3
DA
42622012-05-10 Dave Abrahams <dave@boostpro.com>
4263
4264 * filelock.c (syms_of_filelock): New boolean create-lockfiles.
4265 (lock_file): If create_lockfiles is 0, do nothing. (Bug#11227)
4266
5cb67954
MA
42672012-05-09 Michael Albinus <michael.albinus@gmx.de>
4268
4269 * dbusbind.c (xd_registered_buses): New internal Lisp object.
4270 Rename all occurences of Vdbus_registered_buses to xd_registered_buses.
4271 (syms_of_dbusbind): Remove declaration of Vdbus_registered_buses.
4272 Initialize xd_registered_buses.
4273
3478ec45
PE
42742012-05-09 Paul Eggert <eggert@cs.ucla.edu>
4275
b263a6b0
PE
4276 Untag more efficiently if USE_LSB_TAG.
4277 This is based on a proposal by YAMAMOTO Mitsuharu in
4278 <http://lists.gnu.org/archive/html/emacs-devel/2008-01/msg01876.html>.
4279 For an admittedly artificial (nth 8000 longlist) benchmark on
4280 Fedora 15 x86-64, this yields a 25% CPU speedup. Also, it shrinks
4281 Emacs's overall text size by 1%.
4282 * lisp.h (XUNTAG): New macro.
4283 (XCONS, XVECTOR, XSTRING, XSYMBOL, XFLOAT, XMISC, XPROCESS, XWINDOW)
4284 (XTERMINAL, XSUBR, XBUFFER, XCHAR_TABLE, XSUB_CHAR_TABLE, XBOOL_VECTOR)
4285 (XSETTYPED_PSEUDOVECTOR, XHASH_TABLE, TYPED_PSEUDOVECTORP): Use it.
4286 * eval.c (Fautoload):
4287 * font.h (XFONT_SPEC, XFONT_ENTITY, XFONT_OBJECT):
4288 * frame.h (XFRAME): Use XUNTAG.
4289
3478ec45
PE
4290 Port recent dbusbind.c changes to 32-bit --with-wide-int.
4291 * dbusbind.c (xd_append_arg, xd_retrieve_arg, Fdbus_message_internal):
4292 Remove unportable assumptions about print widths of types like
4293 dbus_uint32_t.
4294 (xd_get_connection_address, Fdbus_init_bus): Cast Emacs integer to
4295 intptr_t when converting between pointer and integer, to avoid GCC
4296 warnings about wrong width.
4297
666b903b 42982012-05-09 Eli Zaretskii <eliz@gnu.org>
0d887c7d
EZ
4299
4300 * w32proc.c (new_child): Force Windows to reserve only 64KB of
4301 stack for each reader_thread, instead of defaulting to 8MB
4302 determined by the linker. This avoids failures in creating
4303 subprocesses on Windows 7, see the discussion in this thread:
4304 http://lists.gnu.org/archive/html/emacs-devel/2012-03/msg00119.html.
4305
b120cc17
JC
43062012-05-07 Jérémy Compostella <jeremy.compostella@gmail.com>
4307
4308 Fix up display of the *Minibuf-0* buffer in the mini window.
4309 * keyboard.c (read_char): Don't clear the echo area if there's no
4310 message to clear.
4311 * xdisp.c (redisplay_internal): Redisplay the mini window (with the
2fed2689 4312 contents of *Minibuf-0*) if there's no message displayed in its stead.
b120cc17 4313
9a4b36f8
MA
43142012-05-07 Michael Albinus <michael.albinus@gmx.de>
4315
4316 * dbusbind.c (XD_DEBUG_MESSAGE): Don't print message twice in
4317 batch mode.
4318
e5f9458f
CY
43192012-05-06 Chong Yidong <cyd@gnu.org>
4320
4321 * lisp.mk (lisp): Update.
4322
eceeb5fc 43232012-05-05 Jim Meyering <meyering@redhat.com>
bf98199c
JM
4324
4325 * w32font.c (fill_in_logfont): NUL-terminate a string (Bug#11372).
4326
71873e2b
SM
43272012-05-04 Stefan Monnier <monnier@iro.umontreal.ca>
4328
4329 * data.c (PUT_ERROR): New macro.
4330 (syms_of_data): Use it. Add new error type `user-error'.
4331 * undo.c (user_error): New function.
4332 (Fprimitive_undo): Use it.
4333 * print.c (print_error_message): Adjust print style for `user-error'.
4334 * keyboard.c (user_error): New function.
4335 (Fexit_recursive_edit, Fabort_recursive_edit): Use it.
4336
ab0fa4e4
PE
43372012-05-03 Paul Eggert <eggert@cs.ucla.edu>
4338
4339 Do not limit current-time-string to years 1000..9999.
4340 * editfns.c (TM_YEAR_IN_ASCTIME_RANGE): Remove.
4341 (Fcurrent_time_string): Support any year that is supported by the
4342 underlying localtime representation. Don't use asctime, as it
4343 has undefined behavior for years outside the range -999..9999.
4344
7ed806a7
PE
43452012-05-02 Paul Eggert <eggert@cs.ucla.edu>
4346
4347 Fix race conditions involving setenv, gmtime, localtime, asctime.
4348 Without this fix, interrupts could mess up code that uses these
4349 nonreentrant functions, since setting TZ invalidates existing
4350 tm_zone or tzname values, and since most of these functions return
4351 pointers to static storage.
4352 * editfns.c (format_time_string, Fdecode_time, Fencode_time)
4353 (Fcurrent_time_string, Fcurrent_time_zone, Fset_time_zone_rule):
4354 Grow the critical sections to include not just invoking
4355 localtime/gmtime, but also accessing these functions' results
4356 including their tm_zone values if any, and any related TZ setting.
4357 (format_time_string): Last arg is now struct tm *, not struct tm **,
71873e2b
SM
4358 so that the struct tm is saved in the critical section.
4359 All callers changed. Simplify allocation of initial buffer, partly
7ed806a7
PE
4360 motivated by the fact that memory allocation needs to be outside
4361 the critical section.
4362
0c16dfed
DA
43632012-05-02 Dmitry Antipov <dmantipov@yandex.ru>
4364
4365 * intervals.c (adjust_intervals_for_insertion): Initialize `newi'
4366 with RESET_INTERVAL.
4367
4368 * buffer.c (Fget_buffer_create, Fmake_indirect_buffer):
4369 Remove duplicated buffer name initialization.
4370
3f83ace8
JM
43712012-05-02 Jim Meyering <jim@meyering.net>
4372
4373 * xterm.c (x_term_init): Use memcpy instead of strncpy (Bug#11373).
4374
c7b8541e
JM
4375 * xfns.c (x_window): Use xstrdup (Bug#11375).
4376
90207a15 43772012-05-02 Eli Zaretskii <eliz@gnu.org>
2fa85638
EZ
4378
4379 * xdisp.c (pos_visible_p): If already at a newline from the
4380 display string before the 'while' loop, don't walk back the glyphs
4381 from it3.glyph_row. Solves assertion violation when the display
4382 string begins with a newline (egg.el). (Bug#11367)
4383
b593d6a9
AH
43842012-05-01 Stefan Monnier <monnier@iro.umontreal.ca>
4385
4386 * keyboard.c (Fexecute_extended_command, Vsuggest_key_bindings):
4387 Move to simple.el.
4388
4737362e
GM
43892012-05-01 Glenn Morris <rgm@gnu.org>
4390
99cf43f9
GM
4391 * syssignal.h: Remove reference to BROKEN_SIGINFO (last used in
4392 s/ptx4.h), BROKEN_SIGTSTP (last used in m/ustation.h, m/dpx2.h),
4393 and BROKEN_SIGURG (was in s/gnu-linux.h prior to 2008-02-10).
4394 All were removed before 23.1.
4395
9311dcff
GM
4396 * dispnew.c: Remove HAVE_LIBNCURSES test;
4397 it is always true on relevant platforms.
4398
4d5c6349
GM
4399 * Makefile.in (LD_SWITCH_X_SITE_RPATH):
4400 Rename from LD_SWITCH_X_SITE_AUX_RPATH.
4401
4737362e
GM
4402 * Makefile.in (LD_SWITCH_X_SITE_AUX): Remove; no longer used.
4403
74dd3a6b
AS
44042012-04-30 Andreas Schwab <schwab@linux-m68k.org>
4405
4406 * .gdbinit (xpr): Remove checks for no longer existing misc types.
4407 (xintfwd, xboolfwd, xobjfwd, xbufobjfwd, xkbobjfwd, xbuflocal):
4408 Remove.
4409
13c379ee
PE
44102012-04-28 Paul Eggert <eggert@cs.ucla.edu>
4411
4412 Do not avoid creating empty evaporating overlays (Bug#9642).
4413 * buffer.c (Fmove_overlay): Revert the change of 2012-04-23.
4414 That is, do not delete an evaporating overlay if it becomes
4415 empty after its bounds are adjusted to fit within its buffer.
4416 This fix caused other problems, and I'm reverting it until we get
4417 to the bottom of them.
4418
a8e7d6d7 44192012-04-27 Chong Yidong <cyd@gnu.org>
9be2fd9b
CY
4420
4421 * xselect.c (x_convert_selection): Initialize a pointer (Bug#11315).
4422
a8e7d6d7 44232012-04-27 Eli Zaretskii <eliz@gnu.org>
f0ee99a0
EZ
4424
4425 * xdisp.c (pos_visible_p): If the window start position is beyond
4426 ZV, start the display from buffer beginning. Prevents assertion
4427 violation in init_iterator when the minibuffer window is scrolled
4428 via the scroll bar.
4429
4430 * window.c (window_scroll_pixel_based): Likewise.
4431
a8e7d6d7 44322012-04-27 Chong Yidong <cyd@gnu.org>
9ec7751f
CY
4433
4434 * keymap.c (where_is_internal): Doc fix (Bug#10872).
4435
a8e7d6d7 44362012-04-27 Glenn Morris <rgm@gnu.org>
24c51a09
GM
4437
4438 * fileio.c (Fcopy_file, Fset_file_selinux_context):
4439 Ignore ENOTSUP failures from setfilecon functions. (Bug#11245)
4440
a8e7d6d7 44412012-04-27 Eli Zaretskii <eliz@gnu.org>
73055685 4442
b593d6a9
AH
4443 * dispnew.c (swap_glyph_pointers, copy_row_except_pointers):
4444 Don't overrun array limits of glyph row's used[] array. (Bug#11288)
73055685 4445
1c6900d9
EZ
44462012-04-26 Eli Zaretskii <eliz@gnu.org>
4447
4c3fa1d9
EZ
4448 * xdisp.c (IT_DISPLAYING_WHITESPACE): In addition to the loaded
4449 display element, check also the underlying string or buffer
4450 character. (Bug#11341)
4451
1c6900d9
EZ
4452 * w32menu.c: Include w32heap.h.
4453 (add_menu_item): If the call to AppendMenuW (via
4454 unicode_append_menu) fails, disable Unicode menus only if we are
4455 running on Windows 9X/Me.
4456
42bf8205
AS
44572012-04-24 Andreas Schwab <schwab@linux-m68k.org>
4458
4459 * .gdbinit (xpr): Handle USE_2_TAGS_FOR_INTS.
4460 (xgetint): Add missing shift for LSB tags.
4461
b1bac16e
MR
44622012-04-24 Martin Rudalics <rudalics@gmx.at>
4463
4464 * keyboard.c (read_char): Don't wipe echo area for select window
4465 events: These might get delayed via `mouse-autoselect-window'
4466 (Bug#11304).
4467
d69621cc
JB
44682012-04-24 Juanma Barranquero <lekktu@gmail.com>
4469
4470 * gnutls.c (init_gnutls_functions): Protect against (unlikely)
4471 manipulation of :loaded-from data.
4472
02fd101b
JB
44732012-04-23 Juanma Barranquero <lekktu@gmail.com>
4474
4475 * gnutls.c (init_gnutls_functions): The value of :loaded-from is
4476 now a cons (bug#11311).
4477
888bec30
PE
44782012-04-23 Paul Eggert <eggert@cs.ucla.edu>
4479
89a438bd
PE
4480 Do not create empty overlays with the evaporate property (Bug#9642).
4481 * buffer.c (Fmove_overlay): Delete an evaporating overlay
4482 if it becomes empty after its bounds are adjusted to fit within
4483 its buffer. Without this fix, in a nonempty buffer (let ((o
4484 (make-overlay 1 2))) (overlay-put o 'evaporate t) (move-overlay o 0 1))
4485 yields an empty overlay that has the evaporate property, which is
4486 not supposed to happen.
4487
1068fe4d
PE
4488 Fix minor GTK3 problems found by static checking.
4489 * emacsgtkfixed.c (EMACS_TYPE_FIXED, EMACS_FIXED, EmacsFixed)
4490 (EmacsFixedPrivate, EmacsFixedClass, struct _EmacsFixed)
4491 (struct _EmacsFixedClass, emacs_fixed_get_type):
4492 Move decls here from emacsgtkfixed.h, since they needn't be public.
4493 (emacs_fixed_get_type): Now static.
4494 (emacs_fixed_class_init): Omit unused local.
4495 (emacs_fixed_child_type): Remove; unused.
4496 * emacsgtkfixed.h (EMACS_TYPE_FIXED, EMACS_FIXED, EmacsFixed)
4497 (EmacsFixedPrivate, EmacsFixedClass, struct _EmacsFixed)
4498 (struct _EmacsFixedClass): Move to emacsgtkfixed.c.
4499 (EMACS_FIXED_CLASS, EMACS_IS_FIXED, EMACS_IS_FIXED_CLASS)
4500 (EMACS_FIXED_GET_CLASS): Remove; unused.
4501 * gtkutil.c (xg_create_frame_widgets) [!HAVE_GTK3]: Omit unused local.
4502
888bec30
PE
4503 * keyboard.c (handle_async_input): Define only if SYNC_INPUT || SIGIO.
4504 Problem reported by Juanma Barranquero for Windows -Wunused-function.
4505
de85e130
PE
45062012-04-22 Paul Eggert <eggert@cs.ucla.edu>
4507
d0baac98 4508 Modernize and clean up gmalloc.c to assume C89 (Bug#9119).
bd7239f5 4509 * gmalloc.c (_MALLOC_INTERNAL, _MALLOC_H, _PP, __ptr_t)
d0baac98
PE
4510 (__malloc_size_t, __malloc_ptrdiff_t):
4511 Remove. All uses removed, replaced by the definiens if needed,
4512 since we can assume C89 or better now.
4513 Include <stdint.h>, for PTRDIFF_MAX, uintptr_t.
4514 (protect_malloc_state, align, get_contiguous_space)
4515 (malloc_atfork_handler_prepare, malloc_atfork_handler_parent)
4516 (malloc_atfork_handler_child, malloc_enable_thread)
4517 (malloc_initialize_1, __malloc_initialize, morecore_nolock)
4518 (_malloc_internal_nolock, _malloc_internal, malloc, _malloc)
4519 (_free, _realloc, _free_internal_nolock, _free_internal, free, cfree)
4520 (special_realloc, _realloc_internal_nolock, _realloc_internal)
4521 (realloc, calloc, __default_morecore, memalign, valloc, checkhdr)
4522 (freehook, mallochook, reallochook, mabort, mcheck, mprobe):
4523 Define using prototypes, not old style.
4524 (align, _malloc_internal_nolock, _free_internal_nolock, memalign):
4525 Don't assume ptrdiff_t and uintptr_t are no wider than unsigned long.
4526 (align): Don't assume that signed integer overflow wraps around.
4527 Omit unused local var.
4528 (malloc_initialize_1, morecore_nolock, _malloc_internal_nolock)
4529 (_free_internal_nolock, memalign, mallochook, reallochook):
4530 Omit no-longer-needed casts.
4531 (valloc): Use getpagesize, not __getpagesize.
4532 (MAGICWORD, MAGICFREE): Now randomish size_t values, not 32-bit.
4533 (struct hdr): The 'magic' member is now size_t, not unsigned long.
4534
de85e130
PE
4535 * dbusbind.c (XD_DBUS_VALIDATE_OBJECT): Define only if needed.
4536
dcbf5805
MA
45372012-04-22 Michael Albinus <michael.albinus@gmx.de>
4538
4539 Move functions from C to Lisp. Make non-blocking method calls
4540 the default. Implement further D-Bus standard interfaces.
4541
4542 * dbusbind.c (DBUS_NUM_MESSAGE_TYPES): Declare.
4543 (QCdbus_request_name_allow_replacement)
4544 (QCdbus_request_name_replace_existing)
4545 (QCdbus_request_name_do_not_queue)
4546 (QCdbus_request_name_reply_primary_owner)
4547 (QCdbus_request_name_reply_in_queue)
4548 (QCdbus_request_name_reply_exists)
4549 (QCdbus_request_name_reply_already_owner): Move to dbus.el.
4550 (QCdbus_registered_serial, QCdbus_registered_method)
4551 (QCdbus_registered_signal): New Lisp objects.
4552 (XD_DEBUG_MESSAGE): Use sizeof.
4553 (XD_MESSAGE_TYPE_TO_STRING, XD_OBJECT_TO_STRING)
4554 (XD_DBUS_VALIDATE_BUS_ADDRESS, XD_DBUS_VALIDATE_OBJECT)
4555 (XD_DBUS_VALIDATE_BUS_NAME, XD_DBUS_VALIDATE_PATH)
4556 (XD_DBUS_VALIDATE_INTERFACE, XD_DBUS_VALIDATE_MEMBER): New macros.
4557 (XD_CHECK_DBUS_SERIAL): Rename from CHECK_DBUS_SERIAL_GET_SERIAL.
4558 (xd_signature, xd_append_arg): Allow float for integer types.
4559 (xd_get_connection_references): New function.
b593d6a9
AH
4560 (xd_get_connection_address): Rename from xd_initialize.
4561 Return cached address.
dcbf5805
MA
4562 (xd_remove_watch): Do not unset $DBUS_SESSION_BUS_ADDRESS.
4563 (xd_close_bus): Rename from Fdbus_close_bus. Not needed on Lisp
4564 level.
4565 (Fdbus_init_bus): New optional arg PRIVATE. Cache address.
9a4b36f8 4566 Return number of refcounts.
dcbf5805
MA
4567 (Fdbus_get_unique_name): Make stronger parameter check.
4568 (Fdbus_message_internal): New defun.
4569 (Fdbus_call_method, Fdbus_call_method_asynchronously)
4570 (Fdbus_method_return_internal, Fdbus_method_error_internal)
4571 (Fdbus_send_signal, Fdbus_register_service)
4572 (Fdbus_register_signal, Fdbus_register_method): Move to dbus.el.
4573 (xd_read_message_1): Obey new structure of Vdbus_registered_objects.
4574 (xd_read_queued_messages): Obey new structure of Vdbus_registered_buses.
4575 (Vdbus_compiled_version, Vdbus_runtime_version)
4576 (Vdbus_message_type_invalid, Vdbus_message_type_method_call)
4577 (Vdbus_message_type_method_return, Vdbus_message_type_error)
4578 (Vdbus_message_type_signal): New defvars.
b593d6a9
AH
4579 (Vdbus_registered_buses, Vdbus_registered_objects_table):
4580 Adapt docstring.
dcbf5805 4581
52828e02
PE
45822012-04-22 Paul Eggert <eggert@cs.ucla.edu>
4583
da05bc4c
PE
4584 Fix GC_MALLOC_CHECK debugging output on 64-bit hosts.
4585 * alloc.c (emacs_blocked_malloc) [GC_MALLOC_CHECK]:
4586 Do not assume ptrdiff_t is the same width as 'int'.
4587
52828e02
PE
4588 * alloc.c: Handle unusual debugging option combinations.
4589 (GC_CHECK_MARKED_OBJECTS): Undef if ! GC_MARK_STACK,
4590 since the two debugging options are incompatible.
4591 (GC_MALLOC_CHECK): Similarly, undef if GC_CHECK_MARKED_OBJECTS
4592 is defined.
4593 (mem_init, mem_insert, mem_insert_fixup):
4594 Define if GC_MARK_STACK || GC_MALLOC_CHECK.
4595 (NEED_MEM_INSERT): Remove; no longer needed.
4596
f01769f9
LL
45972012-04-22 Leo Liu <sdl.web@gmail.com>
4598
4599 * sysdep.c (list_system_processes): Support Darwin (Bug#5725).
4600
5790543d
PE
46012012-04-22 Paul Eggert <eggert@cs.ucla.edu>
4602
4603 * sysdep.c [__FreeBSD__]: Minor cleanups.
4604 (list_system_processes, system_process_attributes) [__FreeBSD__]:
4605 Use Emacs indenting style more consistently. Avoid some casts.
4606 Use 'double' consistently rather than mixing 'float' and 'double'.
4607
b91b7e4d
EW
46082012-04-21 Eduard Wiebe <usenet@pusto.de>
4609
b593d6a9
AH
4610 * sysdep.c (list_system_processes, system_process_attributes):
4611 Add implementation for FreeBSD (Bug#5243).
b91b7e4d 4612
6114eb15
AS
46132012-04-21 Andreas Schwab <schwab@linux-m68k.org>
4614
4615 * lisp.mk (lisp): Update.
4616
2f38dff7
PE
46172012-04-20 Paul Eggert <eggert@cs.ucla.edu>
4618
4619 * keyboard.c (process_pending_signals): Define only if SYNC_INPUT.
4620 It is never used otherwise.
4621
4ae29f89
SM
46222012-04-20 Stefan Monnier <monnier@iro.umontreal.ca>
4623
4624 * print.c (print_preprocess): Only check print_depth if print-circle
4625 is nil.
4626 (print_object): Check for cycles even when print-circle is nil and
4627 print-gensym is t, but only check print_depth if print-circle is nil.
4628
f30d612a
CY
46292012-04-20 Chong Yidong <cyd@gnu.org>
4630
4631 * process.c (wait_reading_process_output): If EIO occurs on a pty,
4632 set the status to "failed" and ensure that sentinel is run.
4633
c07a4c0b 46342012-04-20 Glenn Morris <rgm@gnu.org>
016a35df
GM
4635
4636 * process.c (Fset_process_inherit_coding_system_flag)
4637 (Fset_process_query_on_exit_flag): Doc fix (mention return value).
4373fd43 4638 (Fmake_network_process, Fmake_serial_process): Doc fix.
016a35df 4639
c07a4c0b 46402012-04-20 Eli Zaretskii <eliz@gnu.org>
20a68157
EZ
4641
4642 * xdisp.c (string_buffer_position_lim): Limit starting position to
4643 BEGV.
4644 (set_cursor_from_row): If called for a mode-line or header-line
4645 row, return zero immediately.
4646 (try_cursor_movement): If inside continuation line, don't back up
4ae29f89
SM
4647 farther than the first row after the header line, if any.
4648 Don't consider the header-line row as "partially visible", even if
20a68157
EZ
4649 MATRIX_ROW_PARTIALLY_VISIBLE_P returns non-zero. (Bug#11261)
4650
c07a4c0b 46512012-04-20 Atsuo Ohki <ohki@gssm.otsuka.tsukuba.ac.jp> (tiny change)
ad3a2b41 4652
4ae29f89
SM
4653 * lread.c (lisp_file_lexically_bound_p): Fix hang at ";-*-\n"
4654 (bug#11238).
ad3a2b41 4655
c07a4c0b 46562012-04-20 Teodor Zlatanov <tzz@lifelogs.com>
6c94c34f 46572012-04-18 Paul Eggert <eggert@cs.ucla.edu>
ae6e112d
PE
4658
4659 configure: new option --enable-gcc-warnings (Bug#11207)
4660 * Makefile.in (C_WARNINGS_SWITCH): Remove.
4661 (WARN_CFLAGS, WERROR_CFLAGS): New macros.
4662 (ALL_CFLAGS): Use new macros rather than old.
4663 * process.c: Ignore -Wstrict-overflow to work around GCC bug 52904.
4664 * regex.c: Ignore -Wstrict-overflow. If !emacs, also ignore
4665 -Wunused-but-set-variable, -Wunused-function, -Wunused-macros,
4666 -Wunused-result, -Wunused-variable. This should go away once
4667 the Emacs and Gnulib regex code is merged.
4668 (xmalloc, xrealloc): Now static.
4669
aba027e8
PE
46702012-04-17 Paul Eggert <eggert@cs.ucla.edu>
4671
4672 * dired.c (Fsystem_groups): Remove unused local.
4673
e5a36063
GM
46742012-04-17 Glenn Morris <rgm@gnu.org>
4675
4676 * dired.c (Fsystem_users): Doc fix.
4677
316411f0
DA
46782012-04-17 Dmitry Antipov <dmantipov@yandex.ru>
4679
4680 * dired.c (Fsystem_users, Fsystem_groups): New functions. (Bug#7900)
4681 (syms_of_dired): Add them.
4682
9426aba4
PE
46832012-04-16 Paul Eggert <eggert@cs.ucla.edu>
4684
b62a57be
PE
4685 Fix minor alloc.c problems found by static checking.
4686 * alloc.c (_malloc_internal, _free_internal) [!DOUG_LEA_MALLOC]:
4687 New extern decls, to avoid calling undeclared functions.
4688 (dont_register_blocks): Define if ((!SYSTEM_MALLOC && !SYNC_INPUT)
4689 && GC_MALLOC_CHECK), not if ((GC_MARK_STACK || defined
4690 GC_MALLOC_CHECK) && GC_MALLOC_CHECK), to match when it's used.
4691 (NEED_MEM_INSERT): New macro.
4692 (mem_insert, mem_insert_fixup) [!NEED_MEM_INSERT]: Remove; unused.
4b5afbb0 4693 Remove one incorrect comment and fix another.
b62a57be 4694
3539f31f
PE
4695 Fix minor ralloc.c problems found by static checking.
4696 See http://lists.gnu.org/archive/html/emacs-devel/2011-12/msg00720.html
4697 * ralloc.c (ALIGNED, ROUND_TO_PAGE, HEAP_PTR_SIZE)
4698 (r_alloc_size_in_use, r_alloc_freeze, r_alloc_thaw): Remove; unused.
4699 (r_alloc_sbrk): Now static.
4700
a041960a
PE
4701 Improve ralloc.c interface checking.
4702 See http://lists.gnu.org/archive/html/emacs-devel/2011-12/msg00720.html
4703 * buffer.c (ralloc_reset_variable, r_alloc, r_re_alloc)
4704 (r_alloc_free) [REL_ALLOC]: Move decls from here ...
4705 * lisp.h (r_alloc, r_alloc_free, r_re_alloc, r_alloc_reset_variable)
4706 [REL_ALLOC]: ... to here, to check interface.
4707 * m/ia64.h (r_alloc, r_alloc_free) [REL_ALLOC && !_MALLOC_INTERNAL]:
4708 Remove decls. This fixes an "It stinks!".
4709
9426aba4
PE
4710 * alloc.c (which_symbols): Fix alignment issue / type clash.
4711
d55c12ed
AS
47122012-04-15 Andreas Schwab <schwab@linux-m68k.org>
4713
4714 * lisp.h (struct Lisp_Symbol): Remove explicit padding.
4715 (struct Lisp_Misc_Any): Likewise.
4716 (struct Lisp_Free): Likewise.
4717 * alloc.c (union aligned_Lisp_Symbol): Define.
4718 (SYMBOL_BLOCK_SIZE, struct symbol_block): Use union
4719 aligned_Lisp_Symbol instead of struct Lisp_Symbol.
4720 (union aligned_Lisp_Misc): Define.
4721 (MARKER_BLOCK_SIZE, struct marker_block): Use union
4722 aligned_Lisp_Misc instead of union Lisp_Misc.
4ae29f89 4723 (Fmake_symbol, allocate_misc, gc_sweep): Adjust.
d55c12ed 4724
b948ce8b
PE
47252012-04-14 Paul Eggert <eggert@cs.ucla.edu>
4726
4727 Make GC_MAKE_GCPROS_NOOPS the default (Bug#9926).
4728 * lisp.h (GC_MARK_STACK): Default to GC_MAKE_GCPROS_NOOPS.
4729 * s/cygwin.h, s/darwin.h, s/freebsd.h, s/gnu.h, s/irix6-5.h, s/msdos.h:
4730 * s/netbsd.h, s/sol2-6.h:
4731 Remove definition of GC_MARK_STACK, since the default now works.
4732 * s/aix4-2.h, s/hpux10-20.h, s/unixware.h:
4733 Define GC_MARK_STACK to GC_USE_GCPROS_AS_BEFORE, since that's
4734 no longer the default.
4735 * s/gnu-linux.h (GC_MARK_STACK): Adjust to change in default.
4736
35dc09a1 47372012-04-14 Atsuo Ohki <ohki@gssm.otsuka.tsukuba.ac.jp> (tiny change)
ad3a2b41 4738
35dc09a1
GM
4739 * lread.c (lisp_file_lexically_bound_p):
4740 Fix hang at ";-*-\n" (bug#11238).
ad3a2b41 4741
35dc09a1
GM
47422012-04-14 Eli Zaretskii <eliz@gnu.org>
4743
4744 * xdisp.c (find_last_unchanged_at_beg_row): Don't consider a row
4745 "unchanged" if its end.pos is beyond ZV. (Bug#11199)
4746
47472012-04-14 Jan Djärv <jan.h.d@swipnet.se>
4748
4749 * nsterm.m (constrainFrameRect): Always constrain when there is only
4750 one screen (Bug#10962).
4751
bcd86815
KB
47522012-04-13 Ken Brown <kbrown@cornell.edu>
4753
4754 * s/cygwin.h (PTY_OPEN): Don't try to close a bogus file descriptor.
4755
c25df26e
RT
47562012-04-13 Reuben Thomas <rrt@sc3d.org>
4757
4758 * indent.c (Fmove_to_column): Change interactive spec (Bug#739).
4759
0fc59f1e
DC
47602012-04-11 Daniel Colascione <dancol@dancol.org>
4761
4762 * s/cygwin.h: The vfork the #define in cygwin.h was protecting
4763 against is gone. It's better to use vfork now so that when Cygwin
4764 gains a new, working vfork, we use it automatically (bug#10398).
4765
de8c03dc
SM
47662012-04-11 Stefan Monnier <monnier@iro.umontreal.ca>
4767
4768 * window.c (save_window_save): Obey window-point-insertion-type.
4769
2f097256
GM
47702012-04-11 Glenn Morris <rgm@gnu.org>
4771
4772 * Makefile.in (GNUSTEP_CFLAGS): Rename from C_SWITCH_X_SYSTEM.
4773
453b951e
SM
47742012-04-11 Stefan Monnier <monnier@iro.umontreal.ca>
4775
4776 * alloc.c (lisp_align_malloc): Remove unneeded prototype.
4777
75f1671a 47782012-04-10 Jason S. Cornez <jcornez@ravenpack.com> (tiny change)
6bbef4e5
JC
4779
4780 * keyboard.c: Override inhibit-quit after the third C-g (bug#6585).
4781 (force_quit_count): New var.
4782 (handle_interrupt): Use it.
4783
2a8ce227
JB
47842012-04-10 Juanma Barranquero <lekktu@gmail.com>
4785
4786 * w32.c (w32_delayed_load): Record the full path of the library
4787 being loaded (bug#10424).
4788
935396c0
GM
47892012-04-09 Glenn Morris <rgm@gnu.org>
4790
05920a43
GM
4791 * doc.c (Fsnarf_documentation): Check variables, functions are bound,
4792 not just in the obarray, before snarfing them. (Bug#11036)
4793
935396c0
GM
4794 * Makefile.in ($(leimdir)/leim-list.el):
4795 Pass EMACS rather than BUILT_EMACS.
4796
a18ecafa
TZ
47972012-04-09 Teodor Zlatanov <tzz@lifelogs.com>
4798
4799 * process.c (make_process):
4800 * process.h: Add integer `gnutls_handshakes_tried' member to
4801 process struct.
4802
6bbef4e5
JC
4803 * gnutls.h: Add `GNUTLS_EMACS_HANDSHAKES_LIMIT' upper limit.
4804 Add convenience `GNUTLS_LOG2i' macro.
a18ecafa
TZ
4805
4806 * gnutls.c (gnutls_log_function2i): Convenience log function.
4807 (emacs_gnutls_read): Use new log functions,
4808 `gnutls_handshakes_tried' process member, and
4809 `GNUTLS_EMACS_HANDSHAKES_LIMIT' to limit the number of handshake
4810 attempts per process (connection).
4811
b4d3bc10
CY
48122012-04-09 Chong Yidong <cyd@gnu.org>
4813
4814 * eval.c (Fuser_variable_p, user_variable_p_eh)
4815 (lisp_indirect_variable): Functions deleted.
4816 (Fdefvar): Caller changed.
4817
4818 * callint.c (Finteractive, Fcall_interactively):
4819 * minibuf.c (Fread_variable): Callers changed.
4820
70f4d973
EZ
48212012-04-09 Eli Zaretskii <eliz@gnu.org>
4822
4823 * xdisp.c (set_cursor_from_row): If the display string appears in
4824 the buffer at position that is closer to point than the position
4825 after the display string, display the cursor on the first glyph of
4826 the display string. Fixes cursor display when a 'display' text
4827 property immediately follows invisible text. (Bug#11094)
4828
cb3c2e3e
PE
48292012-04-09 Paul Eggert <eggert@cs.ucla.edu>
4830
4831 composite.c: use 'double' consistently
4832 * composite.c (get_composition_id): Use 'double' consistently
4833 instead of converting 'float' to 'double' and vice versa; this is
4834 easier to understand and avoids a GCC warning.
4835
fd06db5d
GM
48362012-04-09 Glenn Morris <rgm@gnu.org>
4837
50fe702a
GM
4838 * Makefile.in: Generate leim-list with bootstrap-emacs, in
4839 preparation for dumping it with emacs. (Bug#4789)
4840 (leimdir): New variable.
4841 ($(leimdir)/leim-list.el): New rule.
4842 (emacs$(EXEEXT)): Depend on leim-list.el.
4843
fd06db5d
GM
4844 * buffer.c (Qucs_set_table_for_input): Remove. (Bug#9821)
4845 (Fget_buffer_create): Don't call Qucs_set_table_for_input.
4846 (init_buffer_once, syms_of_buffer): Remove Qucs_set_table_for_input.
4847
55c131ee
AS
48482012-04-08 Andreas Schwab <schwab@linux-m68k.org>
4849
4850 * lisp.h (struct Lisp_Symbol): Add explicit padding to ensure
4851 proper alignment.
4852
9209588f
JB
48532012-04-07 Juanma Barranquero <lekktu@gmail.com>
4854
4855 * xml.c (init_libxml2_functions) [WINDOWSNT]:
4856 Remove unused local variable.
4857
e3fb2efb
PE
48582012-04-07 Paul Eggert <eggert@cs.ucla.edu>
4859
4860 Avoid unnecessary pointer scanning in garbage collection (Bug#10780).
4861 * alloc.c (POINTERS_MIGHT_HIDE_IN_OBJECTS): New macro.
4862 (mark_memory): Mark Lisp_Objects only if pointers might hide in
4863 objects, as mark_maybe_pointer will catch them otherwise.
4864 (GC_LISP_OBJECT_ALIGNMENT): Remove; no longer needed.
4865 * s/gnu-linux.h (GC_LISP_OBJECT_ALIGNMENT) [__mc68000__]: Likewise.
4866
b5385551
PE
48672012-04-07 Paul Eggert <eggert@cs.ucla.edu>
4868
4869 Fix typo that broke non-Windows builds.
4870 * xml.c (libxml2_loaded_p) [!!WINDOWSNT]: 'inine' -> 'inline'.
4871
9078ead6
EZ
48722012-04-07 Eli Zaretskii <eliz@gnu.org>
4873
4874 Support building on MS-Windows with libxml2.
4875
4876 * makefile.w32-in (OBJ2): Add xml.$(O).
4877 (GLOBAL_SOURCES): Add xml.c.
4878 ($(BLD)/xml.$(O)): New dependency list.
4879
4880 * xml.c (DEF_XML2_FN, LOAD_XML2_FN) [WINDOWSNT]: New macros.
4881 (fn_htmlReadMemory, fn_xmlReadMemory, fn_xmlDocGetRootElement)
4882 (fn_xmlFreeDoc, fn_xmlCleanupParser, fn_xmlCheckVersion)
4883 [!WINDOWSNT]: New macros.
4884 (init_libxml2_functions, libxml2_loaded_p): New functions.
4885 (parse_region): Call fn_xmlCheckVersion instead of using the macro
4886 LIBXML_TEST_VERSION. Call libxml2 functions via the fn_* macros.
4887 (xml_cleanup_parser): New function, export for fn_xmlCleanupParser.
4888 Calls xmlCleanupParser only if libxml2 was loaded (or statically
4889 linked in).
6bbef4e5
JC
4890 (Flibxml_parse_html_region, Flibxml_parse_xml_region):
4891 Call init_libxml2_functions before calling libxml2 functions.
9078ead6
EZ
4892 (syms_of_xml) <Qlibxml2_dll>: DEFSYM it.
4893
4894 * emacs.c: Don't include libxml/parser.h.
4895 (shut_down_emacs): Call xml_cleanup_parser, instead of calling
4896 xmlCleanupParser directly.
4897
4898 * lisp.h [HAVE_LIBXML2]: Add prototype for xml_cleanup_parser.
4899
3811fdf3
EZ
49002012-04-07 Eli Zaretskii <eliz@gnu.org>
4901
4902 * indent.c (Fvertical_motion): If there is a display string at
4903 point, use it.vpos to compute how many lines to backtrack after
4904 move_it_to point. (Bug#11133)
4905
2f8e16b2
EZ
49062012-04-06 Eli Zaretskii <eliz@gnu.org>
4907
4908 * buffer.h (FETCH_CHAR, FETCH_MULTIBYTE_CHAR):
4909 * character.h (STRING_CHAR, STRING_CHAR_AND_LENGTH): Add comments
4910 about subtle differences between FETCH_CHAR* and STRING_CHAR*
4911 macros related to unification of CJK characters. For the details,
4912 see the discussion following the message here:
4913 http://debbugs.gnu.org/cgi/bugreport.cgi?bug=11073#14.
4914
3d439cd1
CY
49152012-04-04 Chong Yidong <cyd@gnu.org>
4916
4917 * keyboard.c (Vdelayed_warnings_list): Doc fix.
4918
8bc53d00
EZ
49192012-04-01 Eli Zaretskii <eliz@gnu.org>
4920
4921 * w32menu.c (simple_dialog_show, add_menu_item): Use SAFE_ALLOCA
4922 instead of alloca. (Bug#11138)
4923
3b0512a3
AS
49242012-04-01 Andreas Schwab <schwab@linux-m68k.org>
4925
4926 * w32menu.c (is_simple_dialog): Properly check lisp types.
4927 (Bug#11141)
4928
8427ddd2
EZ
49292012-03-31 Eli Zaretskii <eliz@gnu.org>
4930
979022ef
EZ
4931 * xdisp.c (move_it_by_lines): When DVPOS is positive, and the
4932 position we get to after a call to move_it_to fails the
4933 IS_POS_VALID_AFTER_MOVE_P test, move to the next buffer position
4934 only if we wind up in a string from display property. (Bug#11063)
4935
a6b1c7cc
EZ
4936 * window.c (Fdelete_other_windows_internal): Invalidate the row
4937 and column information about mouse highlight, so that redisplay
4938 restores it after reallocating the glyph matrices. (Bug#7464)
4939
8427ddd2
EZ
4940 * xdisp.c (set_cursor_from_row): If `cursor' property on a display
4941 string comes from a `display' text property, use the buffer
4942 position of that property as if we actually saw that position in
4943 the row's glyphs.
697ba24b
EZ
4944 (move_it_by_lines): Remove the assertion that
4945 "it->current_x == 0 && it->hpos == 0" which can be legitimately
4946 violated when there's a before-string at the beginning of a line.
4947 (Bug#11063)
8427ddd2 4948
65a0a738
EZ
49492012-03-30 Eli Zaretskii <eliz@gnu.org>
4950
4951 * xdisp.c (append_space_for_newline): If the default face was
4952 remapped, use the remapped face for the appended newline.
4953 (extend_face_to_end_of_line): Use the remapped default face for
4954 extending the face to the end of the line.
4955 (display_line): Call extend_face_to_end_of_line when the default
4956 face was remapped. (Bug#11068)
4957
581355cc
EZ
49582012-03-29 Eli Zaretskii <eliz@gnu.org>
4959
4960 * s/ms-w32.h: Discourage from defining HAVE_GETCWD.
4961
e8fc049f
SM
49622012-03-28 Stefan Monnier <monnier@iro.umontreal.ca>
4963
4964 * keyboard.c (safe_run_hooks_error): Don't unquote strings.
4965
4fb9a543
GM
49662012-03-27 Glenn Morris <rgm@gnu.org>
4967
4968 * search.c (Fword_search_backward_lax, Fword_search_forward_lax):
4969 Doc fixes.
4970
679910f1
KH
49712012-03-26 Kenichi Handa <handa@m17n.org>
4972
4973 * dispextern.h (struct glyph): Fix previous change. Change the
4974 bit length of glyphless.ch to 25 (Bug#11082).
4975
90d49b7f
CY
49762012-03-26 Chong Yidong <cyd@gnu.org>
4977
4978 * keyboard.c (Vselection_inhibit_update_commands): New variable.
4979 (command_loop_1): Use it; inhibit selection update for
4980 handle-select-window too (Bug#8996).
4981
f514f6f0
FP
49822012-03-25 Fabrice Popineau <fabrice.popineau@supelec.fr>
4983
e8fc049f 4984 * w32heap.c (_heap_init, _heap_term): Remove dead MSVC-specific code.
f514f6f0 4985
bf43fa51
KH
49862012-03-25 Kenichi Handa <handa@m17n.org>
4987
4988 * dispextern.h (struct glyph): Change the bit length of
4989 glyphless.ch to 22 to make the member glyphless fit in 32 bits.
4990
8a0c01dd
EZ
49912012-03-24 Eli Zaretskii <eliz@gnu.org>
4992
4993 * s/ms-w32.h (tzname): Include time.h before redirecting to
4994 _tzname. Fixes the MSVC build. (Bug#9960)
4995
7d1c3a76
AS
49962012-03-24 Andreas Schwab <schwab@linux-m68k.org>
4997
8ed79523
AS
4998 * xdisp.c (produce_glyphless_glyph): Limit length of acronym to 6
4999 characters.
5000
7d1c3a76
AS
5001 * xterm.c (XTread_socket): Only modify handling_signal if
5002 !SYNC_INPUT. (Bug#11080)
5003
e99a9b8b
EZ
50042012-03-23 Eli Zaretskii <eliz@gnu.org>
5005
5006 * bidi.c (bidi_fetch_char): Use STRING_CHAR_AND_LENGTH instead of
5007 FETCH_MULTIBYTE_CHAR followed by CHAR_BYTES. Prevents crashes
5008 when fetching a multibyte character consumes more bytes than
5009 CHAR_BYTES returns, due to unification of CJK characters in
5010 string_char. (Bug#11073)
5011
5063c0e1
TN
50122012-03-23 Troels Nielsen <bn.troels@gmail.com> (tiny change)
5013
5014 * process.c (wait_reading_process_output): Handle pty disconnect
5015 by refraining from sending oneself a SIGCHLD (bug#10933).
5016
9f851fbd
CY
50172012-03-22 Chong Yidong <cyd@gnu.org>
5018
5019 * dispextern.h (struct it): New member string_from_prefix_prop_p.
5020
5063c0e1 5021 * xdisp.c (push_prefix_prop): Rename from push_display_prop.
9f851fbd
CY
5022 Mark string as coming from a prefix property.
5023 (handle_face_prop): Use default face for prefix strings (Bug#4281).
5024 (pop_it, reseat_1): Save and restore string_from_prefix_prop_p.
5025
fb5b8aca
CY
50262012-03-21 Chong Yidong <cyd@gnu.org>
5027
5028 * xfaces.c (Vface_remapping_alist): Doc fix.
5029
62356a1b
EZ
50302012-03-20 Eli Zaretskii <eliz@gnu.org>
5031
5032 * w32proc.c (Fw32_set_console_codepage)
5063c0e1
TN
5033 (Fw32_set_console_output_codepage, Fw32_get_codepage_charset):
5034 Doc fixes.
62356a1b 5035
025de85b
CY
50362012-03-20 Chong Yidong <cyd@gnu.org>
5037
5038 * dispnew.c (Fredisplay, Vredisplay_preemption_period): Update doc
5039 to reflect default non-nil value of redisplay-dont-pause.
5040
4827f94e
KH
50412012-03-19 Kenichi Handa <handa@m17n.org>
5042
5043 * ftfont.c (ftfont_drive_otf): Mask bits of character code to make
5044 it fit in a valid range (Bug#11003).
5045
e50a24a2
EZ
50462012-03-18 Eli Zaretskii <eliz@gnu.org>
5047
5048 * xdisp.c (cursor_row_p): Even if the glyph row ends in a string
5049 that is not from display property, accept the row as a "cursor
5050 row" if one of the string's character has a non-nil `cursor'
5051 property. Fixes cursor positioning when there are newlines in
5052 overlay strings, e.g. in icomplete.el. (Bug#11035)
5053
9af5ed87
PE
50542012-03-12 Paul Eggert <eggert@cs.ucla.edu>
5055
5056 * buffer.c (compare_overlays): Don't assume args differ (Bug#6830).
5057
d1f55f16
CY
50582012-03-12 Chong Yidong <cyd@gnu.org>
5059
5060 * eval.c (inhibit_lisp_code): Rename from
5061 inhibit_window_configuration_change_hook; move from window.c.
5062
5063 * xfns.c (unwind_create_frame_1, Fx_create_frame):
5064 * window.c (run_window_configuration_change_hook)
5065 (syms_of_window): Callers changed.
5066
66c5eebd
CY
50672012-03-11 Chong Yidong <cyd@gnu.org>
5068
413df973
CY
5069 * keymap.c (Fkey_description): Doc fix (Bug#9700).
5070
66c5eebd
CY
5071 * editfns.c (Fconstrain_to_field): Doc fix (Bug#9452).
5072
1de11f56
CY
50732012-03-10 Chong Yidong <cyd@gnu.org>
5074
5075 * frame.c (other_visible_frames): Don't assume the selected frame
5076 is visible (Bug#10955).
5077
cae07000
SM
50782012-03-09 Stefan Monnier <monnier@iro.umontreal.ca>
5079
5080 * buffer.c (compare_overlays): Avoid qsort's instability (bug#6830).
5081
89c94350
JD
50822012-03-08 Jan Djärv <jan.h.d@swipnet.se>
5083
5084 * gtkutil.c (x_wm_set_size_hint): Use one row in call to
5085 FRAME_TEXT_LINES_TO_PIXEL_HEIGHT so base_height is greater than
5086 zero (Bug#10954).
5087
999dd333
GM
50882012-03-03 Glenn Morris <rgm@gnu.org>
5089
01a6dcc8 5090 * alloc.c (Fgarbage_collect, misc-objects-consed): Doc fixes.
999dd333 5091
de0100f2
EZ
50922012-03-02 Eli Zaretskii <eliz@gnu.org>
5093
5094 * xdisp.c (try_window_reusing_current_matrix): Don't move cursor
5095 position past the first glyph_row that ends at ZV. (Bug#10902)
b8456c5c
EZ
5096 (redisplay_window, next_element_from_string): Fix typos in
5097 comments.
3e441275
EZ
5098 (redisplay_window): Pass to move_it_vertically the margin in
5099 pixels, not in screen lines.
de0100f2 5100
96a72ee9
GM
51012012-03-02 Glenn Morris <rgm@gnu.org>
5102
5103 * buffer.c (buffer-list-update-hook): Doc fix.
5104
312508d7
EZ
51052012-02-29 Eli Zaretskii <eliz@gnu.org>
5106
5107 * xdisp.c (get_overlay_strings_1): Under bidi redisplay, call
5108 push_it before setting up the iterator for the first overlay
5109 string, even if we have an empty string loaded.
5110 (next_overlay_string): If there's an empty string on the iterator
5111 stack, pop the stack. (Bug#10903)
5112
27f3c637
PE
51132012-02-25 Paul Eggert <eggert@cs.ucla.edu>
5114
5115 Generalize fix for crash due to non-contiguous EMACS_INT (Bug#10780).
5116 Suggested by Stefan Monnier in
5117 <http://lists.gnu.org/archive/html/emacs-devel/2012-02/msg00692.html>.
5118 * alloc.c (widen_to_Lisp_Object): New static function.
5119 (mark_memory): Also mark Lisp_Objects by fetching pointer words
5120 and widening them to Lisp_Objects. This would work even if
5121 USE_LSB_TAG is defined and wide integers are used, which might
5122 happen in a future version of Emacs.
5123
3c9dfce6
CY
51242012-02-25 Chong Yidong <cyd@gnu.org>
5125
fa74b241
CY
5126 * fileio.c (Ffile_selinux_context, Fset_file_selinux_context):
5127 Doc fix.
5128
3c9dfce6
CY
5129 * xselect.c (Fx_selection_exists_p): Doc fix.
5130 (x_clipboard_manager_save_all): Print an informative message
5131 before saving to clipboard manager.
5132
9486df08
CY
51332012-02-24 Chong Yidong <cyd@gnu.org>
5134
5135 * keyboard.c (process_special_events): Handle all X selection
5136 requests in kbd_buffer, not just the next one (Bug#8869).
5137
f01d3321
CY
51382012-02-23 Chong Yidong <cyd@gnu.org>
5139
5140 * xfns.c (Fx_create_frame): Avoid window-configuration-change-hook
5141 call when setting menu-bar-lines and tool-bar-lines parameters.
5142 (unwind_create_frame_1): New helper function.
5143
5144 * window.c (inhibit_window_configuration_change_hook): New var.
5145 (run_window_configuration_change_hook): Obey it.
b2e4ca7d 5146 (syms_of_window): Initialize it.
f01d3321 5147
86b847b6
CY
51482012-02-22 Chong Yidong <cyd@gnu.org>
5149
5150 * xterm.c (x_draw_image_relief): Add missing type check for
5151 Vtool_bar_button_margin (Bug#10743).
5152
a59225b1
CY
51532012-02-21 Chong Yidong <cyd@gnu.org>
5154
5155 * fileio.c (Vfile_name_handler_alist): Doc fix.
5156
5157 * buffer.c (Fget_file_buffer): Protect against invalid file
5158 handler return value.
5159
310f5bd4
PE
51602012-02-20 Paul Eggert <eggert@cs.ucla.edu>
5161
cb3a28cc
PE
5162 * .gdbinit (xreload): Don't assume EMACS_INT fits in 'long'
5163 when computing $valmask.
5164
310f5bd4
PE
5165 Fix crash due to non-contiguous EMACS_INT (Bug#10780).
5166 * lisp.h (VALBITS): Move definition up, so that USE_LSB_TAG can use it.
5167 (USE_LSB_TAG): Do not define if UINTPTR_MAX >> VALBITS == 0.
5168 It's useless in that case, and it can cause problems on hosts
5169 that allocate halves of EMACS_INT values separately.
5170 Reported by Dan Horák. Diagnosed by Andreas Schwab in
5171 <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=10780#30>.
5172 * mem-limits.h (EXCEEDS_LISP_PTR): Define to 0 on hosts where
5173 UINTPTR_MAX >> VALBITS == 0. This is required by the above change;
5174 it avoids undefined behavior on hosts where shifting right by more
5175 than the word width has undefined behavior.
5176
2375c96a
CY
51772012-02-19 Chong Yidong <cyd@gnu.org>
5178
5179 * fileio.c (Ffile_name_directory, Ffile_name_nondirectory)
5180 (Funhandled_file_name_directory, Ffile_name_as_directory)
5181 (Fdirectory_file_name, Fexpand_file_name)
5182 (Fsubstitute_in_file_name): Protect against invalid file handler
5183 return values (Bug#10845).
5184
3eb49e71
EZ
51852012-02-18 Eli Zaretskii <eliz@gnu.org>
5186
5187 * .gdbinit (pitx): Fix incorrect references to fields of the
5188 iterator stack.
5189
7b926f3f
CY
51902012-02-17 Chong Yidong <cyd@gnu.org>
5191
5192 * syntax.c (Fscan_lists): Doc fix (Bug#10833).
5193
11273115
PE
51942012-02-15 Paul Eggert <eggert@cs.ucla.edu>
5195
5196 * image.c (MAX_IMAGE_SIZE): Increase from 6.0 to 10.0; see
5197 <http://lists.gnu.org/archive/html/emacs-devel/2012-02/msg00540.html>.
5198
c3a70e2b
CY
51992012-02-15 Chong Yidong <cyd@gnu.org>
5200
5201 * eval.c (Fdefvar, Fdefconst): Doc fix; note that the variable is
5202 marked as special. Also, starting docstrings with * is obsolete.
5203
0ca43699
AS
52042012-02-13 Andreas Schwab <schwab@linux-m68k.org>
5205
5206 * gnutls.c (emacs_gnutls_write): Fix last change.
5207
2e8f3c56
LI
52082012-02-13 Lars Ingebrigtsen <larsi@gnus.org>
5209
5210 * gnutls.c (emacs_gnutls_write): Set errno appropriately for
5211 send_process.
5212
af70074f
SM
52132012-02-13 Stefan Monnier <monnier@iro.umontreal.ca>
5214
5215 * keymap.c (Fsingle_key_description): Handle char ranges.
5216
95986d52
CY
52172012-02-12 Chong Yidong <cyd@gnu.org>
5218
afd83bd1
CY
5219 * xdisp.c (handle_stop): Avoid assigning -1 to it->face_id here,
5220 as that creates a dangerous corner case.
5221
95986d52
CY
5222 * window.c (Fdelete_window_internal): Invalidate the mouse
5223 highlight (Bug#9904).
5224
bd7da63e
GM
52252012-02-12 Glenn Morris <rgm@gnu.org>
5226
5227 * xselect.c (Fx_own_selection_internal)
5228 (Fx_get_selection_internal, Fx_disown_selection_internal)
5229 (Fx_selection_owner_p, Fx_selection_exists_p): Doc fixes.
5230 * nsselect.m (Fx_own_selection_internal)
5231 (Fx_disown_selection_internal, Fx_selection_exists_p)
5232 (Fx_selection_owner_p, Fx_get_selection_internal):
5233 Sync docs and argument specs with the xselect.c versions.
5234
77abcbc2
LI
52352012-02-11 Lars Ingebrigtsen <larsi@gnus.org>
5236
5237 * gnutls.c (emacs_gnutls_write): Don't infloop if sendto fails.
5238
90b671e2
EZ
52392012-02-11 Eli Zaretskii <eliz@gnu.org>
5240
1c0ca0b7
EZ
5241 * w32select.c (Fx_selection_exists_p): Sync doc string and
5242 argument list with xselect.c. (Bug#10783)
5243
5244 * w16select.c (Fx_selection_exists_p): Sync doc string and
5245 argument list with xselect.c. (Bug#10783)
90b671e2 5246
49241268
GM
52472012-02-10 Glenn Morris <rgm@gnu.org>
5248
5249 * fns.c (Fsecure_hash): Doc fix.
5250
f998bbe7 52512012-02-09 Kenichi Handa <handa@m17n.org>
5c1ca13d
KH
5252
5253 * coding.c (produce_chars): Fix updating of src_end (Bug#10701).
5254
0992bd9c
CY
52552012-02-07 Chong Yidong <cyd@gnu.org>
5256
5257 * buffer.c (Fbuffer_local_variables)
5258 (buffer_lisp_local_variables): Handle unbound vars correctly;
5259 don't let Qunbound leak into Lisp.
5260
af008560
GM
52612012-02-07 Glenn Morris <rgm@gnu.org>
5262
dd605cc4
GM
5263 * image.c (Fimagemagick_types): Doc fix.
5264
af008560
GM
5265 * image.c (imagemagick-render-type): Change it from a lisp object
5266 to an integer. Move the doc here from the lisp manual.
5267 Treat all values not equal to 0 the same.
5268
1449fa1d
CY
52692012-02-06 Chong Yidong <cyd@gnu.org>
5270
5271 * doc.c (store_function_docstring): Avoid applying docstring of
5272 alias to base function (Bug#2603).
5273
3723ec07
AS
52742012-02-04 Andreas Schwab <schwab@linux-m68k.org>
5275
5276 * .gdbinit (pp1, pv1): Remove redundant defines.
5277 (pr): Use pp.
5278
79c1cc1e
CY
52792012-02-04 Chong Yidong <cyd@gnu.org>
5280
5281 * nsterm.m: Declare a global (Bug#10694).
5282
d7f29f8e
EZ
52832012-02-04 Eli Zaretskii <eliz@gnu.org>
5284
cae07000
SM
5285 * w32.c (get_emacs_configuration_options):
5286 Include --enable-checking, if specified, in the return value.
d7f29f8e 5287
3b95a6f9
MR
52882012-02-04 Martin Rudalics <rudalics@gmx.at>
5289
5290 * dispnew.c (change_frame_size_1): Calculate new_frame_total_cols
5291 after rounding frame sizes. (Bug#9723)
5292
d6fa96a6
EZ
52932012-02-04 Eli Zaretskii <eliz@gnu.org>
5294
5295 * keyboard.c (adjust_point_for_property): Don't position point
5296 before BEGV. (Bug#10696)
5297
df0b2940
PE
52982012-02-03 Paul Eggert <eggert@cs.ucla.edu>
5299
5300 Handle overflow when computing char display width (Bug#9496).
5301 * character.c (char_width): Return EMACS_INT, not int.
5302 (char_width, c_string_width): Check for overflow when
5303 computing the width; this is possible now that individual
5304 characters can have unbounded width. Problem introduced
5305 by merge from Emacs 23 on 2012-01-19.
5306
6bee44d6
MA
53072012-02-02 Michael Albinus <michael.albinus@gmx.de>
5308
5309 * dbusbind.c (Fdbus_register_method): Mention the return value
5310 :ignore in the docstring.
5311
44f92739
GM
53122012-02-02 Glenn Morris <rgm@gnu.org>
5313
1b9f60cc
GM
5314 * callproc.c (Fcall_process, Fcall_process_region): Doc fix.
5315
44f92739
GM
5316 * nsterm.m (syms_of_nsterm) <x-toolkit-scroll-bars>:
5317 Unconditionally set to t. (Bug#10673)
5318 * nsterm.m (syms_of_nsterm) <x-toolkit-scroll-bars>:
5319 * w32term.c (syms_of_w32term) <x-toolkit-scroll-bars>:
5320 * xterm.c (syms_of_xterm) <x-toolkit-scroll-bars>: Doc fix.
5321
c5d3843c
KH
53222012-02-02 Kenichi Handa <handa@m17n.org>
5323
5324 (x_produce_glyphs): Cancel previous change. If cmp->glyph_len is
5325 0, do not call append_composite_glyph.
5326
159462d4 53272012-02-02 Kenichi Handa <handa@m17n.org>
d2a51fd7
KH
5328
5329 * xdisp.c (BUILD_COMPOSITE_GLYPH_STRING): Initialize first_s to
5330 NULL (Bug#6988).
5331 (x_produce_glyphs): If the component of a composition is a null
5332 string, set it->pixel_width to 1 to avoid zero-width glyph.
5333
78cef877
EZ
53342012-02-01 Eli Zaretskii <eliz@gnu.org>
5335
5336 * ralloc.c (resize_bloc, r_alloc_sbrk): Don't call memmove if its
5337 first 2 arguments are identical. This makes inserting large
5338 output from a subprocess an order of magnitude faster on
5339 MS-Windows, where all sbrk'ed memory is always contiguous.
5340
97897668
GM
53412012-01-31 Glenn Morris <rgm@gnu.org>
5342
5343 * nsterm.m (syms_of_nsterm) <x-toolkit-scroll-bars>:
c78c6e0b 5344 * w32term.c (syms_of_w32term) <x-toolkit-scroll-bars>:
97897668
GM
5345 * xterm.c (syms_of_xterm) <x-toolkit-scroll-bars>: Sync docs.
5346
31fd3586
GM
53472012-01-29 Glenn Morris <rgm@gnu.org>
5348
5349 * gnutls.c (syms_of_gnutls): More doc (from etc/NEWS).
5350
0e24a8b2
CY
53512012-01-28 Samuel Thibault <sthibault@debian.org> (tiny change)
5352
5353 * s/gnu.h: Define POSIX_SIGNALS (Bug#10552).
5354
cc0adcb0
CY
53552012-01-28 Chong Yidong <cyd@gnu.org>
5356
5357 * minibuf.c (syms_of_minibuf): Doc fix (Bug#10550).
5358
acc28cb9
CY
53592012-01-26 Chong Yidong <cyd@gnu.org>
5360
9c69cfb7
CY
5361 * keyboard.c (Vecho_keystrokes): Document zero value (Bug#10503).
5362
acc28cb9
CY
5363 * search.c (Fsearch_forward, Fsearch_backward): Document negative
5364 repeat counts (Bug#10507).
5365
48da7392
GM
53662012-01-26 Glenn Morris <rgm@gnu.org>
5367
5368 * lread.c (syms_of_lread): Doc fix.
5369
14af5f7f
CY
53702012-01-25 HIROSHI OOTA <nil@mad.dog.cx> (tiny change)
5371
5372 * coding.c (encode_designation_at_bol): Change return value to
5373 EMACS_INT.
5374
0b21c100
CY
53752012-01-25 Chong Yidong <cyd@gnu.org>
5376
5377 * eval.c (Fuser_variable_p): Doc fix; mention custom-variable-p.
5378
3c2907f7
CY
53792012-01-21 Chong Yidong <cyd@gnu.org>
5380
5381 * floatfns.c (Fcopysign): Make the second argument non-optional,
5382 since nil is not allowed anyway.
5383
959ad23f
AS
53842012-01-21 Andreas Schwab <schwab@linux-m68k.org>
5385
5386 * process.c (read_process_output): Use p instead of XPROCESS (proc).
5387 (send_process): Likewise.
5388
34a02f46
MR
53892012-01-19 Martin Rudalics <rudalics@gmx.at>
5390
5391 * window.c (save_window_save, Fcurrent_window_configuration)
cae07000
SM
5392 (Vwindow_persistent_parameters): Do not use Qstate.
5393 Rewrite doc-strings.
34a02f46 5394
1259009a 53952012-01-19 Kenichi Handa <handa@m17n.org>
25ed9e61
KH
5396
5397 * character.c (char_width): New function.
70d4fdf6
GM
5398 (Fchar_width, c_string_width, lisp_string_width):
5399 Use char_width (Bug#9496).
25ed9e61 5400
6a6ee00d
MR
54012012-01-16 Martin Rudalics <rudalics@gmx.at>
5402
5403 * window.c (Vwindow_persistent_parameters): New variable.
5404 (Fset_window_configuration, save_window_save): Handle persistent
5405 window parameters.
5406
c85efaf7
EZ
54072012-01-14 Eli Zaretskii <eliz@gnu.org>
5408
5409 * w32fns.c (signal_user_input): Don't do a QUIT, to avoid
5410 thrashing the stack of the thread. (Bug#9087)
5411
5944709e
PE
54122012-01-12 Paul Eggert <eggert@cs.ucla.edu>
5413
5414 * xdisp.c (rows_from_pos_range): Add parens as per gcc -Wparentheses.
5415
e71f5d99
EZ
54162012-01-11 Eli Zaretskii <eliz@gnu.org>
5417
5418 * xdisp.c (rows_from_pos_range): Handle the case where the
5419 highlight ends on a newline. (Bug#10464)
5420 (mouse_face_from_buffer_pos): Fix off-by-one error in calculating
5421 he end column for display of highlight that ends on a newline
5422 before a R2L line.
5423
ce316182
GM
54242012-01-11 Glenn Morris <rgm@gnu.org>
5425
5426 * lread.c (init_lread): If no-site-lisp, remove site-lisp dirs
5427 from load-path also when installation-directory is nil. (Bug#10208)
5428
5b43da69
GM
54292012-01-10 Glenn Morris <rgm@gnu.org>
5430
74cc8ff9
GM
5431 * emacs.c (syms_of_emacs) <installation-directory>: Doc fix.
5432
7d8d6e4e
GM
5433 * epaths.in (PATH_LOADSEARCH, PATH_EXEC, PATH_DATA, PATH_DOC):
5434 Update template values to be closer to their typical values these days.
5b43da69 5435
a0db8d43
EZ
54362012-01-09 Eli Zaretskii <eliz@gnu.org>
5437
5438 * xdisp.c (rows_from_pos_range): Accept additional argument
5439 DISP_STRING, and accept any glyph in a row whose object is that
5440 string as eligible for mouse highlight. Fixes mouse highlight of
5441 display strings from overlays. (Bug#10464)
5442
9a0115ab 54432012-01-07 Paul Eggert <eggert@cs.ucla.edu>
09450bae 5444
b9110d6a 5445 emacs: fix an auto-save permissions race condition (Bug#10400)
09450bae
PE
5446 * fileio.c (auto_saving_dir_umask): New static var.
5447 (Fmake_directory_internal): Use it.
5448 (do_auto_save_make_dir): Set it, instead of invoking chmod after
5449 creating the directory. The old code temporarily assigns
5450 too-generous permissions to the directory.
5451 (do_auto_save_eh): Clear it.
b9110d6a 5452 (Fdo_auto_save): Catch all errors, not just file errors, so
09450bae
PE
5453 that the var is always cleared.
5454
6c1bd3f3
EZ
54552012-01-07 Eli Zaretskii <eliz@gnu.org>
5456
5457 * search.c (scan_buffer): Pass character positions to
5458 know_region_cache, not byte positions. (Bug#6540)
5459
069d2b50
L
54602012-01-07 LynX <_LynX@bk.ru> (tiny change)
5461
5462 * w32.c (sys_rename): Report EXDEV when rename of a directory
5463 fails because the target is on another logical disk. (Bug#10284)
5464
75bf0d33
DB
54652012-01-07 David Benjamin <davidben@mit.edu> (tiny change)
5466
5467 * xterm.c (x_embed_request_focus): New function.
5468
5469 * xterm.h: Add prototype.
5470
5471 * xfns.c (Fx_focus_frame): Use it for embedded frames (Bug#9977).
5472
1c6e5a32
GM
54732012-01-05 Glenn Morris <rgm@gnu.org>
5474
5475 * emacs.c (emacs_copyright): Update short copyright year to 2012.
5476
651e947e
EZ
54772012-01-01 Eli Zaretskii <eliz@gnu.org>
5478
5479 * gnutls.c (init_gnutls_functions): Load gnutls_check_version.
5480 Load gnutls_transport_set_lowat only if GnuTLS version is below
5481 2.11.1.
5482 (emacs_gnutls_handshake): Call gnutls_transport_set_lowat only for
5483 GnuTLS versions below 2.11.1.
5484
3778cdd8
AL
54852011-12-31 Antoine Levitt <antoine.levitt@gmail.com>
5486
5487 * xdisp.c (syms_of_xdisp) <window-scroll-functions>: Add warning
5488 to the doc string advising against its use for altering the way
5489 windows are scrolled.
5490
0e5317f7
KH
54912011-12-28 Kenichi Handa <handa@m17n.org>
5492
5493 * coding.c (Fdefine_coding_system_internal): Make an utf-8 base
5494 coding-system ASCII compatible only when it does not produce BOM
5495 on encoding (Bug#10383).
5496
93d5ca1f
JD
54972011-12-26 Jan Djärv <jan.h.d@swipnet.se>
5498
5499 * xmenu.c (x_menu_wait_for_event): Use xg_select for Gtk3 so menus
5500 can scroll.
5501 (create_and_show_popup_menu): Always use menu_position_func for
5502 Gtk3 (Bug#10361).
5503
ca22b785
AS
55042011-12-24 Andreas Schwab <schwab@linux-m68k.org>
5505
5506 * callint.c (Fcall_interactively): Don't truncate prompt string.
5507
d048e1e6
EZ
55082011-12-23 Eli Zaretskii <eliz@gnu.org>
5509
5510 * xdisp.c (handle_invisible_prop): Handle correctly an invisible
5511 property that ends at ZV, so that the bidi iteration could be
3ba1a2ad 5512 resumed from there (after widening). (Bug#10360)
d048e1e6 5513
5ccaba1f
JD
55142011-12-22 Jan Djärv <jan.h.d@swipnet.se>
5515
5516 * nsfont.m (ns_spec_to_descriptor): Do not autorelease fdesc.
5517
204ee57f
JD
55182011-12-21 Jan Djärv <jan.h.d@swipnet.se>
5519
b81d40f0
JB
5520 * nsterm.m (x_free_frame_resources):
5521 Release f->output_data.ns->miniimage.
204ee57f
JD
5522 (ns_index_color): Fix indentation. Do not retain
5523 color_table->colors[i].
5524
5525 * nsmenu.m (ns_update_menubar): Call free_menubar_widget_value_tree
5526 before returning.
5527
5528 * nsfns.m (x_set_background_color): Assign return value from
5529 ns_index_color to face-background instead of NSColor*.
5530 (ns_implicitly_set_icon_type): Fix indentation.
5531 Change assignment in for loop to comparison.
5532
5533 * emacs.c (ns_pool): New variable.
5534 (main): Assign ns_pool.
5535 (Fkill_emacs): Call ns_release_autorelease_pool.
5536
5537 * nsfont.m (ns_spec_to_descriptor): Fix indentation,
5538 autorelease fdesc, release fdAttrs and tdict.
5539 (ns_get_covering_families): Release charset.
5540 (ns_findfonts): Release NSFontDescriptor created with new.
5541 (ns_uni_to_glyphs): Fix indentation.
5542 (setString): Release attrStr before assigning new value.
5543
c803b2b7
JD
55442011-12-18 Jan Djärv <jan.h.d@swipnet.se>
5545
678f4426
JD
5546 * nsmenu.m (NSMenuDidBeginTrackingNotification): Declare if OSX < 10.5
5547 and NS_IMPL_COCOA.
5548 (trackingNotification): Surround with ifdef NS_IMPL_COCOA.
5549 (syms_of_nsmenu): Set trackingMenu to 1 if not NS_IMPL_COCOA.
5550
cd394be1 55512011-12-18 David Reitter <reitter@cmu.edu>
678f4426 5552
5fecd5fc
JD
5553 * nsterm.m (ns_term_init): Subscribe for notifications
5554 NSMenuDidBeginTrackingNotification and NSMenuDidEndTrackingNotification
5555 to method trackingNotification in EmacsMenu.
5556
5557 * nsmenu.m (trackingMenu): New variable.
3771cb17 5558 (trackingNotification): New method (from Aquamacs).
5fecd5fc 5559 (menuNeedsUpdate): Expand comment and return if trackingMenu is 0,
3771cb17 5560 from Aquamacs (Bug#7030).
678f4426
JD
5561
55622011-12-18 Jan Djärv <jan.h.d@swipnet.se>
5fecd5fc 5563
c803b2b7
JD
5564 * nsselect.m (CUT_BUFFER_SUPPORT): Remove define.
5565 (symbol_to_nsstring): Fix indentation.
5566 (ns_symbol_to_pb): New function.
cae07000
SM
5567 (Fns_get_selection_internal): Rename from Fns_get_cut_buffer_internal.
5568 (Fns_rotate_cut_buffers_internal): Remove.
5569 (Fns_store_selection_internal): Rename from
c803b2b7
JD
5570 Fns_store_cut_buffer_internal.
5571 (ns_get_foreign_selection, Fx_own_selection_internal)
5572 (Fx_disown_selection_internal, Fx_selection_exists_p)
b81d40f0
JB
5573 (Fns_get_selection_internal, Fns_store_selection_internal):
5574 Use ns_symbol_to_pb and check if return value is nil.
5575 (syms_of_nsselect): Remove ifdef CUT_BUFFER_SUPPORT. Remove defsubr
5576 Sns_rotate_cut_buffers_internal. Sns_get_cut_buffer_internal
c803b2b7
JD
5577 renamed to Sns_get_selection_internal, Sns_store_cut_buffer_internal
5578 renamed to Sns_store_selection_internal.
5579 (ns_handle_selection_request): Move code to Fx_own_selection_internal
5580 and remove this function.
5581 (ns_handle_selection_clear): Remove, never used.
5582 (Fx_own_selection_internal): Move code from ns_handle_selection_request
5583 here.
5584
e1b01a3a
KB
55852011-12-17 Ken Brown <kbrown@cornell.edu>
5586
5587 * fileio.c (check_writable) [CYGWIN]: Return non-zero if UID or
5588 GID is unknown (Bug#10257).
5589
2adb6e85
PE
55902011-12-17 Paul Eggert <eggert@cs.ucla.edu>
5591
5592 * s/gnu-linux.h: Fix mark_memory typo (Bug#10286).
5593 (GC_MARK_SECONDARY_STACK): Omit removed 3rd arg to mark_memory,
5594 which caused a build failure on GNU/Linux IA-64. This problem was
5595 introduced by my 2011-10-07 patch.
5596
d1d7b339
JL
55972011-12-15 Juri Linkov <juri@jurta.org>
5598
5599 * image.c (imagemagick_error): New function. (Bug#10112)
5600 (imagemagick_load_image): Comment out `MagickSetResolution' call.
5601 Use `imagemagick_error' where ImageMagick functions return
5602 `MagickFalse'.
5603 (Fimagemagick_types): Add `Fnreverse' to return the list in the
5604 proper order.
5605
100d5755
KH
56062011-12-15 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
5607
5608 * xftfont.c (xftfont_draw): Use the font metrics of s->font to
5609 fill background (Bug#8992).
5610
454592a6
MR
56112011-12-13 Martin Rudalics <rudalics@gmx.at>
5612
5613 * window.c (Vwindow_combination_resize)
5614 (Vwindow_combination_limit): Use t instead of non-nil in
5615 doc-strings.
61d4b438
MR
5616 (Vrecenter_redisplay): Add first sentence of doc-string on
5617 separate line.
53524d93 5618 (Frecenter): Fix doc-string typo.
454592a6 5619
3633e3aa
KH
56202011-12-11 Kenichi Handa <handa@m17n.org>
5621
5622 * coding.c (Funencodable_char_position): Pay attention to the
5623 buffer text relocation (Bug#9389).
5624
7b9d523a 56252011-12-10 Jan Djärv <jan.h.d@swipnet.se>
61ccba97 5626
7b9d523a
JD
5627 * xterm.c (x_term_init): Move call to gdk_window_add_filter before
5628 gtk_init (Bug#10100).
5629
b73189c6
EZ
56302011-12-10 Eli Zaretskii <eliz@gnu.org>
5631
5632 * xdisp.c (RECORD_MAX_MIN_POS): Use IT->cmp_it.charpos only if
5633 IT->string is nil. (Bug#10263)
5634
f7dfe5d6
JD
56352011-12-10 Jan Djärv <jan.h.d@swipnet.se>
5636
83faebb4
JD
5637 * nsterm.h (x_free_frame_resources): Declare.
5638
f7dfe5d6
JD
5639 * nsfns.m (ns_get_defaults_value): New function (Bug#10103).
5640 (Fns_get_resource, x_get_string_resource): Call ns_get_defaults_value.
5641
5642 * nsterm.h (ns_get_defaults_value): Declare.
5643
5644 * nsterm.m (ns_default): Call ns_get_defaults_value.
5645
7cd4e72c
EZ
56462011-12-09 Eli Zaretskii <eliz@gnu.org>
5647
5648 * xdisp.c (try_scrolling): Don't set scroll_down_p if dy is zero.
5649 (Bug#10170)
5650
b34d7317
YM
56512011-12-09 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
5652
5653 * unexelf.c (unexec) [NS_IMPL_GNUSTEP]: Take account of the case
5654 that where the value of an _OBJC_* symbol points to is in the .bss
5655 section (Bug#10240).
5656
76470ad1
KH
56572011-12-08 Kazuhiro Ito <kzhr@d1.dion.ne.jp> (tiny change)
5658
5659 * coding.c (encode_coding_ccl): Check (charbuf < charbuf_end)
2fac8180 5660 after the loop to call ccl_driver at least once (Bug#8619).
76470ad1 5661
745fff94
KH
56622011-12-08 Kenichi Handa <handa@m17n.org>
5663
5664 * ftfont.c (get_adstyle_property): Fix previous change
5665 (Bug#10233).
5666
6e44397c
JB
56672011-12-07 Juanma Barranquero <lekktu@gmail.com>
5668
5669 * w32.c (init_environment): If no_site_lisp, remove site-lisp
5670 dirs from the default value of EMACSLOADPATH (bug#10208).
5671
7efa6272
GM
56722011-12-07 Glenn Morris <rgm@gnu.org>
5673
5674 * lread.c (init_lread): If no_site_lisp, exclude site-lisp/ in
5675 installation and source directories as well. (Bug#10208)
5676
f6fc4d87
CY
56772011-12-06 Chong Yidong <cyd@gnu.org>
5678
5679 * minibuf.c (Fread_from_minibuffer): Doc fix (Bug#10228).
5680
2bf26180
GM
56812011-12-06 Glenn Morris <rgm@gnu.org>
5682
5683 * process.c (start_process_unwind): Treat any pid <= 0, except -2,
5684 as an error, not just -1. (Bug#10217)
5685
3a6ad4f0
CY
56862011-12-05 Chong Yidong <cyd@gnu.org>
5687
5688 * keyboard.c (process_special_events): New function.
5689 (swallow_events, Finput_pending_p): Use it (Bug#10195).
5690
75a3b399
PE
56912011-12-05 Paul Eggert <eggert@cs.ucla.edu>
5692
5693 * coding.c (encode_designation_at_bol): Don't use uninitialized
5694 local variable (Bug#9318).
5695
c3c9e25e
KH
56962011-12-05 Kenichi Handa <handa@m17n.org>
5697
5698 * ftfont.c (get_adstyle_property): If the font is not BDF nor PCF,
5699 return Qnil (Bug#8046, Bug#10193).
5700
5eb05ea3
KH
57012011-12-05 Kenichi Handa <handa@m17n.org>
5702
5703 * coding.c (encode_designation_at_bol): New args charbuf_end and
5704 dst. Return the number of produced bytes. Callers changed.
a79703f5
KH
5705 (coding_set_source): Return how many bytes coding->source was
5706 relocated.
5707 (coding_set_destination): Return how many bytes
5708 coding->destination was relocated.
5709 (CODING_DECODE_CHAR, CODING_ENCODE_CHAR, CODING_CHAR_CHARSET)
cae07000 5710 (CODING_CHAR_CHARSET_P): Adjust for the avove changes.
5eb05ea3
KH
5711
57122011-12-05 Kazuhiro Ito <kzhr@d1.dion.ne.jp> (tiny change)
5713
5714 * coding.c (CODING_CHAR_CHARSET_P): New macro.
5715 (encode_coding_emacs_mule, encode_coding_iso_2022): Use the above
5716 macro (Bug#9318).
5717
57182011-12-05 Andreas Schwab <schwab@linux-m68k.org>
5719
5720 The following changes are to fix Bug#9318.
5721
a79703f5 5722 * coding.c (CODING_ENCODE_CHAR, CODING_CHAR_CHARSET): New macros.
5eb05ea3
KH
5723 (encode_coding_emacs_mule, ENCODE_ISO_CHARACTER)
5724 (encode_coding_iso_2022, encode_coding_sjis)
a79703f5 5725 (encode_coding_big5, encode_coding_charset): Use the above macros.
5eb05ea3 5726
7dbda6df
JB
57272011-12-05 Juanma Barranquero <lekktu@gmail.com>
5728
5729 * lisp.h (process_quit_flag): Fix external declaration.
5730
6d5eb5b0
SM
57312011-12-04 Stefan Monnier <monnier@iro.umontreal.ca>
5732
5733 Don't macro-inline non-performance-critical code.
5734 * eval.c (process_quit_flag): New function.
5735 * lisp.h (QUIT): Use it.
5736
a0c3fad0
JD
57372011-12-04 Jan Djärv <jan.h.d@swipnet.se>
5738
5739 * nsfns.m (get_geometry_from_preferences): New function.
5740 (Fx_create_frame): Call get_geometry_from_preferences (Bug#10103).
5741
6c07aac2
AS
57422011-12-04 Andreas Schwab <schwab@linux-m68k.org>
5743
5744 * emacs.c (Qkill_emacs): Define.
5745 (syms_of_emacs): Initialize it.
5746 * keyboard.c (interrupt_signal): Don't call Fkill_emacs here, set
5747 Qquit_flag to `kill-emacs' instead.
6d5eb5b0
SM
5748 (quit_throw_to_read_char): Add parameter `from_signal'.
5749 All callers changed. Call Fkill_emacs if requested and safe.
6c07aac2
AS
5750 * lisp.h (QUIT): Call Fkill_emacs if requested.
5751
c052ead4
JD
57522011-12-03 Jan Djärv <jan.h.d@swipnet.se>
5753
5754 * widget.c (update_wm_hints): Return if wmshell is null.
5755 (widget_update_wm_size_hints): New function.
5756
5757 * widget.h (widget_update_wm_size_hints): Declare.
5758
5759 * xterm.c (x_wm_set_size_hint): If USE_X_TOOLKIT, call
5760 widget_update_wm_size_hints (Bug#10104).
5761
9e49252b
EZ
57622011-12-03 Eli Zaretskii <eliz@gnu.org>
5763
5764 * xdisp.c (handle_invisible_prop): If the invisible text ends just
5765 before a newline, prepare the bidi iterator for consuming the
5766 newline, and keep the current paragraph direction. (Bug#10183)
e9a49426 5767 (redisplay_window): Don't let `margin' become negative. (Bug#10192)
9e49252b 5768
02b16839
JL
57692011-12-02 Juri Linkov <juri@jurta.org>
5770
5771 * search.c (Fword_search_regexp): New Lisp function created from
5772 `wordify'. Change type of arg `lax' from `int' to `Lisp_Object'.
5773 (Fword_search_backward, Fword_search_forward)
5774 (Fword_search_backward_lax, Fword_search_forward_lax):
5775 Use `Fword_search_regexp' instead of `wordify'. Doc fix.
5776 (syms_of_search): Define `Sword_search_regexp'. (Bug#10145)
5777
0068070e
SM
57782011-12-01 Stefan Monnier <monnier@iro.umontreal.ca>
5779
5780 * fileio.c (Finsert_file_contents): Move after-change-function call
5781 to before the "handled:" label, since all "goto handled" appear in
5782 cases where the *-change-functions have already been properly called
5783 (bug#10117).
5784
3360a3fc
AS
57852011-12-01 Andreas Schwab <schwab@linux-m68k.org>
5786
5787 * keyboard.c (interrupt_signal): Don't call kill-emacs when
5788 waiting for input. (Bug#10169)
5789
73d6c093
EZ
57902011-11-30 Eli Zaretskii <eliz@gnu.org>
5791
5792 * dispnew.c (adjust_glyph_matrix): Remove the assertion that
5793 verifies glyph row's hash code--we have just reallocated the
5794 glyphs, so their contents can be complete garbage. (Bug#10164)
5795
febe6bea
JB
57962011-11-30 Juanma Barranquero <lekktu@gmail.com>
5797
5798 * dispnew.c (adjust_glyph_matrix) [XASSERTS]: Add missing check.
5799
801a4313
EZ
58002011-11-30 Eli Zaretskii <eliz@gnu.org>
5801
5802 * dispnew.c (adjust_glyph_matrix) [XASSERTS]: Ensure ROW's
5803 attributes are tested _before_ calling verify_row_hash, to protect
5804 against GCC re-ordering of the tests. (Bug#10164)
5805
2b56b87e
JD
58062011-11-29 Jan Djärv <jan.h.d@swipnet.se>
5807
5808 * xterm.h (struct x_output): net_wm_state_hidden_seen is new.
5809
5810 * xterm.c (handle_one_xevent): Only set async_visible and friends
5811 if net_wm_state_hidden_seen is non-zero (Bug#10002)
7dbda6df 5812 (get_current_wm_state): Set net_wm_state_hidden_seen to 1 if
2b56b87e
JD
5813 _NET_WM_STATE_HIDDEN is in NET_WM_STATE.
5814
dbf31225
PE
58152011-11-28 Paul Eggert <eggert@cs.ucla.edu>
5816
5817 Remove GCPRO-related macros that exist only to avoid shadowing locals.
5818 * lisp.h (GCPRO1_VAR, GCPRO2_VAR, GCPRO3_VAR, GCPRO4_VAR, GCPRO5_VAR)
5819 (GCPRO6_VAR, UNGCPRO_VAR): Remove. See
5820 <http://lists.gnu.org/archive/html/emacs-diffs/2011-11/msg00265.html>.
5821 All uses changed to use GCPRO1 etc.
5822 (GCPRO1, GCPRO2, GCPRO3, GCPRO4, GCPRO5, GCPRO6, UNGCPRO):
5823 Revert to old implementation (i.e., before 2011-03-11).
5824
1305621b
YM
58252011-11-28 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
5826
5827 * dispnew.c (scrolling_window): Truncate overlaps in copy destination
5828 of scroll runs so as to avoid assigning disabled bogus rows and
5829 unnecessary graphics copy operations.
5830
8c9afb46
EZ
58312011-11-27 Eli Zaretskii <eliz@gnu.org>
5832
5833 * s/ms-w32.h (utimbuf) [_MSC_VER]: Don't define.
5834 (snprintf) [_MSC_VER]: Redirect to _snprintf.
5835 (strtoll) [_MSC_VER]: Redirect to _strtoi64.
5836 (malloc, free, realloc, calloc): Redirect to e_* only when
5837 compiling Emacs.
5838
5839 * lisp.h (GCTYPEBITS): Move before first use.
5840 (ALIGN_GCTYPEBITS) [_MSC_VER]: Define.
5841 (DECL_ALIGN) [_MSC_VER]: Use it, as MSVC doesn't like bit ops in
5842 this macro definition.
5843
5844 * s/ms-w32.h (tzname): Redirect to _tzname for all values of
5845 _MSC_VER.
5846
54e9e3bf
JD
58472011-11-27 Jan Djärv <jan.h.d@swipnet.se>
5848
6d5eb5b0
SM
5849 * gtkutil.c (xg_create_frame_widgets):
5850 Call gtk_window_set_has_resize_grip (FALSE) if that function is
54e9e3bf
JD
5851 present with Gtk+ 2.0.
5852
83aca1cb
PE
58532011-11-26 Paul Eggert <eggert@cs.ucla.edu>
5854
5855 * fileio.c (Finsert_file_contents): Undo previous change; see
5856 <http://lists.gnu.org/archive/html/emacs-diffs/2011-11/msg00265.html>.
5857
5b76caa4
PE
58582011-11-26 Paul Eggert <eggert@cs.ucla.edu>
5859
5860 Rename locals to avoid shadowing.
5861 * fileio.c (Finsert_file_contents):
5862 Rename inner 'gcpro1' to 'inner_gcpro1' to avoid shadowing.
5863 * process.c (wait_reading_process_output):
5864 Rename inner 'proc' to 'p' to avoid shadowing.
5865 Indent for consistency with usual Emacs style.
5866
8c535114
EZ
58672011-11-25 Eli Zaretskii <eliz@gnu.org>
5868
5869 * xdisp.c (redisplay_window): If cursor row is not fully visible
5870 after recentering, and scroll-conservatively is set to a large
5871 number, scroll window by a few more lines to make the cursor fully
5872 visible and out of scroll-margin. (Bug#10105)
91b4a718
EZ
5873 (start_display): Don't move to the next line if the display should
5874 start at a newline that is part of a display vector or an overlay
5875 string. (Bug#10119)
8c535114 5876
fa4fdb5c
JL
58772011-11-24 Juri Linkov <juri@jurta.org>
5878
5879 * image.c (imagemagick_load_image): Move `MagickSetResolution' down
5880 after the `MagickPingImage' call. (Bug#10112)
5881
90ec88df
CY
58822011-11-23 Chong Yidong <cyd@gnu.org>
5883
5884 * window.c (Fcoordinates_in_window_p): Accept only live windows.
5885
56e2e794
MR
58862011-11-23 Martin Rudalics <rudalics@gmx.at>
5887
5888 * buffer.c (Fkill_buffer): Run replace_buffer_in_windows before
5889 making another buffer current. (Bug#10114)
5890
b6e64c41
GM
58912011-11-23 Glenn Morris <rgm@gnu.org>
5892
5893 * font.c (font_find_for_lface) [HAVE_NS]: Ignore case. (Bug#2526)
5894
6b21de18
CY
58952011-11-23 Chong Yidong <cyd@gnu.org>
5896
5897 * xdisp.c (compute_stop_pos): Check validity of end_charpos before
5898 using it (Bug#5984).
5899
b12cd789
EZ
59002011-11-22 Eli Zaretskii <eliz@gnu.org>
5901
5902 * dispnew.c (adjust_glyph_matrix): Don't verify hash code of mode-
5903 and header-lines, as they don't have one computed for them.
5904 (Bug#10098)
5905
5906 * .gdbinit (prow): Make displayed values more self-explaining.
5907 Add row's hash code.
5908
261b6fd4
LMI
59092011-11-21 Lars Magne Ingebrigtsen <larsi@gnus.org>
5910
5911 * process.c (wait_reading_process_output): Fix asynchrounous
5912 GnuTLS socket handling on some versions of the GnuTLS library.
16c1ad08 5913 (wait_reading_process_output): Add comment and URL.
261b6fd4 5914
e7cfd277
JD
59152011-11-21 Jan Djärv <jan.h.d@swipnet.se>
5916
5917 * xterm.c (x_clear_frame): Reinstate the XClearWindow call.
5918
a9b9b7f5
CY
59192011-11-21 Chong Yidong <cyd@gnu.org>
5920
5921 * window.c (Fnext_window, Fprevious_window): Doc fix.
5922
b0d15b4f
SM
59232011-11-20 Stefan Monnier <monnier@iro.umontreal.ca>
5924
5925 * window.c (get_phys_cursor_glyph): Fix Lisp_Object/int mixup.
5926
fe7a3057
JB
59272011-11-20 Juanma Barranquero <lekktu@gmail.com>
5928
5929 * nsfont.m (syms_of_nsfont) <ns-reg-to-script>: Fix typo.
5930
d2999b1a
MR
59312011-11-20 Martin Rudalics <rudalics@gmx.at>
5932
5933 * window.c (Fset_window_combination_limit): Rename argument
5934 STATUS to LIMIT.
5935 (Vwindow_combination_limit): Remove "status" from doc-string.
5936
d5ff9cd0
AS
59372011-11-20 Andreas Schwab <schwab@linux-m68k.org>
5938
5939 * m/ibms390.h: Remove.
5940 * m/ibms390x.h: Don't include "ibms390.h".
5941
a5bb9bd3
SM
59422011-11-20 Stefan Monnier <monnier@iro.umontreal.ca>
5943
5944 * fileio.c (Finsert_file_contents): Add missing gcpro1 variable.
5945 Suggested by Dmitry Antipov <dmantipov@yandex.ru>.
5946
cd1181db
JB
59472011-11-20 Juanma Barranquero <lekktu@gmail.com>
5948
5949 * casetab.c (Fset_case_table):
5950 * charset.c (Fcharset_after): Fix typos.
5951
615a3b8d 59522011-11-20 Paul Eggert <eggert@cs.ucla.edu>
6a0bf43d 5953
17e845af
PE
5954 Standardize on VIRT_ADDR_VARIES behavior (Bug#10042).
5955 Otherwise, valgrind does not work on some platforms.
5956 Problem reported by Andreas Schwab in
6a0bf43d
PE
5957 <http://lists.gnu.org/archive/html/emacs-devel/2011-11/msg00081.html>.
5958 * puresize.h (pure, PURE_P): Always behave as if VIRT_ADDR_VARIES
5959 is set, removing the need for VIRT_ADDRESS_VARIES.
5960 (PURE_P): Use a more-efficient implementation that needs just one
5961 comparison, not two: on x86-64 with GCC 4.6.2, this cut down the
5962 number of instructions from 6 (xorl, cmpq, jge, xorl, cmpq, setge)
5963 to 4 (xorl, subq, cmpq, setbe).
5964 * alloc.c (pure): Always extern now, since that's the
5965 VIRT_ADDR_VARIES behavior.
5966 (PURE_POINTER_P): Use a single comparison, not two, for
5967 consistency with the new puresize.h.
5968 * lisp.h (PNTR_COMPARISON_TYPE): Remove; no longer needed.
5969 * m/ibms390.h, m/intel386.h, m/template.h, s/cygwin.h, s/hpux10-20.h:
5970 Remove VIRT_ADDR_VARIES no longer needed.
5971
f8fe6f96
EZ
59722011-11-19 Eli Zaretskii <eliz@gnu.org>
5973
5974 * xdisp.c (x_write_glyphs, draw_phys_cursor_glyph)
5975 (erase_phys_cursor, update_window_cursor, show_mouse_face)
5976 (cursor_in_mouse_face_p): If the cursor position is out of bounds,
5977 behave as if the cursor position were at the window margin.
5978
5979 * window.c (get_phys_cursor_glyph): If the window is hscrolled,
5980 and the cursor position is out of bounds, behave as if the cursor
5981 position were at the window margin. (Bug#10075)
5982
df05a53c
CY
59832011-11-18 Chong Yidong <cyd@gnu.org>
5984
5985 * window.c (Fwindow_combination_limit): Make first argument
5986 non-optional, since it is meaningless for live windows like the
5987 selected window.
61ccba97 5988
2071918e
DA
59892011-11-18 Dmitry Antipov <dmantipov@yandex.ru>
5990
5991 * keymap.c (Fwhere_is_internal): Add missing RETURN_UNGCPROs.
5992
b50a28de
SM
59932011-11-18 Stefan Monnier <monnier@iro.umontreal.ca>
5994
5995 * intervals.c: Fix grafting over the whole buffer (bug#10071).
5996 (graft_intervals_into_buffer): Simplify.
5997
015137db
EZ
59982011-11-18 Eli Zaretskii <eliz@gnu.org>
5999
6000 * dispnew.c (swap_glyph_pointers): Swap the used[] arrays and the
6001 hash values of the two rows.
6002 (copy_row_except_pointers): Preserve the used[] arrays and the
6003 hash values of the two rows. (Bug#10035)
68c95424 6004 (add_row_entry): Add xassert to verify that ROW's hash code is valid.
015137db
EZ
6005
6006 * xdisp.c (row_hash): New function, body extracted from
6007 compute_line_metrics.
6008 (compute_line_metrics): Call row_hash, instead of computing the
6009 hash code inline.
6010
6011 * dispnew.c (verify_row_hash): Call row_hash for computing the
6012 hash code of a row, instead of duplicating code from xdisp.c.
6013
6014 * dispextern.h (row_hash): Add prototype.
6015
a2addb04
TH
60162011-11-18 Tassilo Horn <tassilo@member.fsf.org>
6017
6018 * frame.c (delete_frame): Don't delete the terminal when the last
6019 X frame is closed if emacs is built with GTK toolkit.
6020
df85d315
JB
60212011-11-17 Juanma Barranquero <lekktu@gmail.com>
6022
6023 * window.c (syms_of_window) <window-combination-resize>: Fix typo.
6024
a0c2d0ae
MR
60252011-11-17 Martin Rudalics <rudalics@gmx.at>
6026
6027 * window.c (Vwindow_splits): Rename to
6028 Vwindow_combination_resize. Suggested by Juri Linkov.
6029 (Fsplit_window_internal): Use Vwindow_combination_resize instead
6030 of Vwindow_splits.
6031
58179cce
JB
60322011-11-16 Juanma Barranquero <lekktu@gmail.com>
6033
7877f373
JB
6034 * nsfns.m (Fns_font_name):
6035 * window.c (syms_of_window) <window-combination-limit>: Fix typos.
58179cce 6036
b6f67890
MR
60372011-11-16 Martin Rudalics <rudalics@gmx.at>
6038
6039 * window.h (window): Rename slot "nest" to "combination_limit".
6040 * window.c (Fwindow_nest): Rename to Fwindow_combination_limit.
6041 (Fset_window_nest): Rename to Fset_window_combination_limit.
6042 (Vwindow_nest): Rename to Vwindow_combination_limit.
6043 (recombine_windows, make_parent_window, make_window)
6044 (Fsplit_window_internal, saved_window)
6045 (Fset_window_configuration, save_window_save): Rename all
6046 occurrences of window_nest to window_combination_limit.
6047
c7015153
JB
60482011-11-15 Juanma Barranquero <lekktu@gmail.com>
6049
6050 * image.c (imagemagick_load_image): Fix typo.
6051
322ad6ec
EZ
60522011-11-14 Eli Zaretskii <eliz@gnu.org>
6053
6054 * xdisp.c (display_line): Move the call to
6055 highlight_trailing_whitespace before the call to
6056 compute_line_metrics, since the latter needs to see the final
6d5eb5b0
SM
6057 faces of all the glyphs to compute ROW's hash value.
6058 Fixes assertion violations in row_equal_p. (Bug#10035)
322ad6ec 6059
f067b8ec
JB
60602011-11-14 Juanma Barranquero <lekktu@gmail.com>
6061
6062 * w32proc.c (reader_thread): Don't check pending input if cp->fd < 0,
6063 just return (bug#10044).
6064
1e5b2111
EZ
60652011-11-12 Eli Zaretskii <eliz@gnu.org>
6066
7ef3cbd5
EZ
6067 * makefile.w32-in (HEAPSIZE): New variable, allows to build temacs
6068 with user-defined heap size. Bump the default size of the temacs
6069 heap to 27MB, to avoid memory warning when running temacs.
6070 ($(TEMACS)): Use HEAPSIZE instead of a hardcoded value.
6071
1e5b2111
EZ
6072 * dispnew.c (scrolling_window): Fix incorrect indices in accessing
6073 current_matrix and desired_matrix. (Bug#9990)
7a7270dd
EZ
6074 (verify_row_hash) [XASSERTS]: New function.
6075 (adjust_glyph_matrix, row_equal_p): Use it in xassert to verify
6076 that the hash value of glyph rows is correct.
1e5b2111 6077
89d61221
MR
60782011-11-12 Martin Rudalics <rudalics@gmx.at>
6079
6080 * window.h (window): Remove splits slot.
6081 * window.c (Fwindow_splits, Fset_window_splits): Remove.
6082 (Fdelete_other_windows_internal, make_parent_window)
6083 (make_window, Fsplit_window_internal, Fdelete_window_internal)
6084 (Fset_window_configuration, save_window_save): Don't deal with
6085 split status of windows.
6086 (saved_window): Remove splits slot.
6087 (Vwindow_splits): Rewrite doc-string.
6088
97f18cc8
JD
60892011-11-11 Jan Djärv <jan.h.d@swipnet.se>
6090
6091 * xfns.c (unwind_create_frame):
6092 * nsfns.m (unwind_create_frame):
6093 * w32fns.c (unwind_create_frame): Use Fmemq to check if frame is in
6094 Vframe_list (Bug#9999).
6095
22a648b4
DA
60962011-11-11 Dmitry Antipov <dmantipov@yandex.ru>
6097
0b381c7e 6098 * xdisp.c (syms_of_xdisp): Remove duplicated definition of Qtext.
22a648b4 6099
659afede
KH
61002011-11-11 Kenichi Handa <handa@m17n.org>
6101
6102 * callproc.c (Fcall_process): Set the member dst_multibyte of
6103 process_coding.
6104
9ac0394b
KH
61052011-11-11 Johan Bockgård <bojohan@gnu.org>
6106
6107 * xdisp.c (fill_composite_glyph_string): Always set s->face, to
6108 avoid a crash (bug#9496).
6109
2fbdc249
CY
61102011-11-09 Chong Yidong <cyd@gnu.org>
6111
6112 * window.c (Fwindow_inside_edges, Fwindow_inside_pixel_edges)
6113 (Fwindow_inside_absolute_pixel_edges): Only allow live windows.
6114
ac6b1f81
PE
61152011-11-08 Paul Eggert <eggert@cs.ucla.edu>
6116
6117 * s/gnu.h (GC_MARK_STACK): Define to GC_MAKE_GCPROS_NOOPS (Bug#9926).
6118
09db192c
PE
61192011-11-08 Paul Eggert <eggert@cs.ucla.edu>
6120
6121 Avoid some portability problems by eschewing 'extern inline' functions.
6122 The trivial performance wins aren't worth the portability hassles; see
6123 <http://lists.gnu.org/archive/html/emacs-devel/2011-11/msg00084.html>
6124 et seq.
6125 * dispextern.h (window_box, window_box_height, window_text_bottom_y)
6126 (window_box_width, window_box_left, window_box_left_offset)
6127 (window_box_right, window_box_right_offset): Undo previous change,
6128 by removing the "extern"s.
6129 * intervals.c (adjust_intervals_for_insertion)
6130 (adjust_intervals_for_deletion): Undo previous change,
6131 making these static again.
6132 (offset_intervals, temp_set_point_both, temp_set_point)
6133 (copy_intervals_to_string): No longer inline.
6134 * xdisp.c (window_text_bottom_y, window_box_width)
6135 (window_box_height, window_box_left_offset)
6136 (window_box_right_offset, window_box_left, window_box_right)
6137 (window_box): No longer inline.
6138
105216ed
CY
61392011-11-08 Chong Yidong <cyd@gnu.org>
6140
6141 * window.c (Fwindow_left_column, Fwindow_top_line): Doc fix.
6d5eb5b0
SM
6142 (Fwindow_body_height, Fwindow_body_width): Move from Lisp.
6143 Signal an error if not a live window.
105216ed
CY
6144 (Fwindow_total_width, Fwindow_total_height): Move from Lisp.
6145 (Fwindow_total_size, Fwindow_body_size): Move to Lisp.
6146
ae9e237f
JB
61472011-11-07 Juanma Barranquero <lekktu@gmail.com>
6148
6149 * lisp.h (syms_of_abbrev): Remove declaration.
6150 Reported by CHENG Gao <chenggao@royau.me>.
6151
c7aa8333
EZ
61522011-11-07 Eli Zaretskii <eliz@gnu.org>
6153
6154 * w32.c (check_windows_init_file): Don't look for term/w32-win.el
6155 if Vpurify_flag is non-nil. Fixes a crash when running w32 build
6156 of temacs in GUI mode.
6157
be7f5545
MR
61582011-11-07 Martin Rudalics <rudalics@gmx.at>
6159
6160 * window.h: Declare delete_all_child_windows instead of
6161 delete_all_subwindows.
6162 * window.c (Fwindow_nest, Fset_window_nest)
6163 (Fset_window_new_total, Fset_window_new_normal)
6164 (Fwindow_resize_apply): Don't use term subwindow in doc-strings.
6165 (delete_all_subwindows): Rename to delete_all_child_windows.
6166 (Fdelete_other_windows_internal, Fset_window_configuration):
6167 Call delete_all_child_windows instead of delete_all_subwindows.
6168 * frame.c (delete_frame): Call delete_all_child_windows instead
6169 of delete_all_subwindows.
6170
ca78dc43
PE
61712011-11-07 Paul Eggert <eggert@cs.ucla.edu>
6172
6173 * alloc.c (DEADP): New macro, for porting to GNU/Hurd (Bug#9926).
6174 This is also needed for porting to any host where GC_MARK_STACK is
6175 not GC_MAKE_GCPROS_NOOPS.
6176 (which_symbols): Use it.
6177
a0241d01
KH
61782011-11-07 Kenichi Handa <handa@m17n.org>
6179
6180 * coding.c (coding_set_destination): Check coding->src_pos only
6181 when coding->src_object is a buffer (bug#9910).
6182
6183 * process.c (send_process): Set the member src_multibyte of coding
6184 to 0 (bug#9911) when sending a unibyte text.
6185
6186 * callproc.c (Fcall_process): Set the member src_multibyte of
6187 process_coding to 0 (bug#9912).
6188
a64bfdfa 61892011-11-06 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
ba24cea2
YM
6190
6191 * xmenu.c (cleanup_widget_value_tree): New function.
6192 (xmenu_show, xdialog_show): Use it in record_unwind_protect instead of
6193 calling free_menubar_widget_value_tree directly (Bug#9830).
6194
cb41b32a
PE
61952011-11-06 Paul Eggert <eggert@cs.ucla.edu>
6196
6197 Fix some portability problems with 'inline'.
6198 * dispextern.h (window_box, window_box_height, window_text_bottom_y)
6199 (window_box_width, window_box_left, window_box_left_offset)
6200 (window_box_right, window_box_right_offset): Declare extern.
6201 Otherwise, these inline functions do not conform to C99 and
6202 are miscompiled by Microsoft compilers. Reported by Eli Zaretskii in
6203 <http://lists.gnu.org/archive/html/emacs-devel/2011-11/msg00084.html>.
6204 * intervals.c (adjust_intervals_for_insertion)
6205 (adjust_intervals_for_deletion): Now extern, because otherwise the
6206 extern inline functions 'offset_intervals' couldn't refer to it.
6207 (static_offset_intervals): Remove.
6208 (offset_intervals): Rewrite using the old contents of
6209 static_offset_intervals. The old version didn't conform to C99
6210 because an extern inline function contained a reference to an
6211 identifier with static linkage.
6212
b7041366
AS
62132011-11-06 Andreas Schwab <schwab@linux-m68k.org>
6214
6215 * keyboard.c (interrupt_signal): Don't call kill-emacs while in
6216 GC.
6217
88a37c4d
EZ
62182011-11-06 Eli Zaretskii <eliz@gnu.org>
6219
6220 * xdisp.c (init_iterator, reseat_to_string): Don't set the
6221 iterator's bidi_p flag if Vpurify_flag is non-nil. (Bug#9963)
6222 (Fcurrent_bidi_paragraph_direction): If Vpurify_flag is non-nil,
6223 return Qleft_to_right.
6224
49745b39
CY
62252011-11-06 Chong Yidong <cyd@gnu.org>
6226
6227 * window.c (Fwindow_live_p, Fwindow_frame, Fframe_root_window)
6228 (Fminibuffer_window, Fwindow_buffer, Fwindow_splits)
6229 (Fset_window_splits, Fwindow_nest, Fset_window_nest)
6230 (Fwindow_use_time, Fwindow_total_size, Fwindow_normal_size)
6231 (Fwindow_new_normal, Fwindow_left_column, Fwindow_top_line)
6232 (Fwindow_margins, Fwindow_fringes, Fwindow_scroll_bars)
6233 (Fwindow_vscroll): Doc fix.
6234 (Fwindow_top_child, Fwindow_left_child): Eliminate a nil default
6235 argument, since it makes no sense to pass a live window and for
6236 consistency with window-child.
6237
1f05cd82
CS
62382011-11-05 Christoph Scholtes <cschol2112@googlemail.com>
6239
6240 * makefile.w32-in ($(TEMACS), (gl-stamp)): Use $(THISDIR) to
6241 support MSVC.
6242
22610910
JR
62432011-11-05 Jason Rumney <jasonr@gnu.org>
6244
6245 * w32font.c (font_matches_spec): Filter out non-Japanese kana fonts.
6246 (add_font_entity_to_list): Filter out non-Japanese Shift-JIS
6247 fonts (Bug#6029).
6248 (add_font_entity_to_list): Fix logic errors in mixed boolean and
6249 bitwise arithmetic preventing use of unicode-sip and non-truetype
6250 opentype fonts.
6251
a06776b2
EZ
62522011-11-05 Eli Zaretskii <eliz@gnu.org>
6253
3ad924ba
EZ
6254 * s/ms-w32.h (fstat, stat, utime): Move redirections to
6255 "emacs"-only part.
6256
a06776b2
EZ
6257 * w32fns.c (x_create_tip_frame, Fx_create_frame): Rearrange
6258 initialization code to keep similarity to xfns.c after changes
6259 from 2011-11-05.
6260
c9e7db78
JD
62612011-11-05 Jan Djärv <jan.h.d@swipnet.se>
6262
a97f8f3f
JD
6263 * nsfns.m: Declare image_cache_refcount if GLYPH_DEBUG.
6264 (unwind_create_frame): New function (Bug#9943).
6265 (Fx_create_frame): Restructure code to be more similar to the one in
6266 xfns.c. Call record_unwind_protect with unwind_create_frame (Bug#9943).
6267 Initialize image_cache_refcount if GLYPH_DEBUG (Bug#9943).
6268 Move terminal->reference_count++ just before making the frame official
6269 (Bug#9943).
6270
6271 * nsterm.m (x_free_frame_resources): New function.
6272 (x_destroy_window): Move code to x_free_frame_resources.
6273
c9e7db78 6274 * xfns.c (unwind_create_frame): Fix comment.
6d5eb5b0
SM
6275 (Fx_create_frame, x_create_tip_frame):
6276 Move terminal->reference_count++ just before making the frame
75f1671a 6277 official. Move initialization of image_cache_refcount and
c9e7db78
JD
6278 dpyinfo_refcount before calling init_frame_faces (Bug#9943).
6279
a6fc3b5c
EZ
62802011-11-05 Eli Zaretskii <eliz@gnu.org>
6281
6282 Support MSVC build with newer versions of Visual Studio.
6283 * makefile.w32-in (TAGS-gmake): Don't use $(patsubst ...), as
6284 Nmake barfs on that. Use $(OBJ*_c) variables instead, defined on
6285 nt/gmake.defs.
6286
6287 * lisp.h (ENUM_BF): New macro, for enumerated types in bitfields,
6288 which are not supported by MSVC.
6289 (Lisp_Symbol, Lisp_Misc_Any, Lisp_Marker, Lisp_Misc_Overlay)
6290 (Lisp_Save_Value, Lisp_Free): Use ENUM_BF for enumerated types in
6291 bitfields.
6292 (Lisp_Object) [USE_LISP_UNION_TYPE]: Use ENUM_BF for enumerated
6293 types in bitfields.
6294 (DEFUN) [_MSC_VER]: Define in a different way for MSVC.
6295
6296 * w32fns.c [_MSC_VER]: DECLARE_HANDLE for any MSVC version.
6297
58179cce 62982011-11-05 Fabrice Popineau <fabrice.popineau@supelec.fr> (tiny change)
a6fc3b5c
EZ
6299
6300 Support MSVC build with newer versions of Visual Studio.
6301 * w32.c: Don't include w32api.h for MSVC.
6302 (init_environment) [_MSC_VER]: Call sys_access, not _access.
6303
6304 * s/ms-w32.h <sigset_t, ssize_t> [_MSC_VER]: Typedefs for MSVC.
6305 [_MSC_VER]: Include sys/timeb.h, sys/stat.h, and signal.h.
6306 (fstat, stat, utime) [_MSC_VER]: Redirect to their sys_* cousins.
6307 (malloc, free, realloc, calloc) [_MSC_VER]: Always redirect to the
6308 e_* cousins.
6309 (alloca) [_MSC_VER]: Define to _alloca.
6310
6311 * lisp.h (DECL_ALIGN) [_MSC_VER]: Define for MSVC.
6312
6313 * regex.c <re_char> [_MSC_VER]: A separate definition for MSVC.
6314
a58c13ed
EZ
63152011-11-04 Eli Zaretskii <eliz@gnu.org>
6316
6317 * xdisp.c (note_mouse_highlight): If either of
6318 previous/next-single-property-change returns nil, treat that as
6319 the beginning or the end of the buffer. (Bug#9955)
6320
fe0b6370
JD
63212011-11-04 Jan Djärv <jan.h.d@swipnet.se>
6322
a58c13ed 6323 * gtkutil.c (xg_make_tool_item): Add callbacks if one of wimage or
fe0b6370
JD
6324 label is not null (Bug#9951).
6325 (xg_tool_item_stale_p): Handle the fact that wimage and/or wlbl
6326 may be NULL.
6327
89bd5ee1
EZ
63282011-11-04 Eli Zaretskii <eliz@gnu.org>
6329
6330 * window.c (Fwindow_body_size): Mention in the doc string that the
6331 return value is in frame's canonical units. (Bug#9949)
6332
84c3edb9
EZ
63332011-11-03 Eli Zaretskii <eliz@gnu.org>
6334
4e2fb5c7
EZ
6335 * xdisp.c (note_mouse_highlight): Initialize `area'. (Bug#9947)
6336
84c3edb9 6337 * w32fns.c (unwind_create_frame): If needed, free the glyph
3ab15fd6 6338 matrices of the partially constructed frame. (Bug#9943)
2a58bbc1 6339 * xfns.c (unwind_create_frame): Likewise.
84c3edb9 6340
bc17a887
EZ
63412011-11-01 Eli Zaretskii <eliz@gnu.org>
6342
6343 * xdisp.c (mouse_face_from_buffer_pos): Fix a typo in a comment.
6344 Don't stop backward scan on the continuation glyph, even though
6345 its CHARPOS is positive.
6d5eb5b0
SM
6346 (mouse_face_from_buffer_pos, note_mouse_highlight):
6347 Rename cover_string to disp_string.
bc17a887 6348
4ee88440
MR
63492011-11-01 Martin Rudalics <rudalics@gmx.at>
6350
6351 * window.c (temp_output_buffer_show): Don't use
6352 Vtemp_buffer_show_specifiers.
6353 (Vtemp_buffer_show_specifiers): Remove unused variable.
6354
c2ff3c02
EZ
63552011-10-30 Eli Zaretskii <eliz@gnu.org>
6356
6357 * xdisp.c (try_cursor_movement): Make sure ROW isn't decremented
6358 past the beginning of the current glyph matrix.
6359
58179cce 63602011-10-30 Adam Sjøgren <asjo@koldfront.dk> (tiny change)
6e56383b
JD
6361
6362 * xterm.c: Include X11/Xproto.h if HAVE_GTK3.
6363 (x_error_handler): Ignore BadMatch for X_SetInputFocus for
6364 HAVE_GTK3 (Bug#9869).
b77a6a7f 6365
3b574623
JD
6366 * gtkutil.c (xg_win_to_widget, xg_event_is_for_menubar): Initialize
6367 type to GDK_NOTHING so valgrind does not complain (Bug#9901).
6368
b77a6a7f
JD
6369 * xterm.h (x_display_info): Add Xatom_net_wm_state_hidden (Bug#9893).
6370
6371 * xterm.c: Declare x_handle_net_wm_state to return int.
6372 (handle_one_xevent): Check if we are iconified but don't have
6373 _NET_WM_STATE_HIDDEN. If do, treat as deiconify (Bug#9893).
6374 (get_current_wm_state): Return non-zero if not hidden,
6375 check for _NET_WM_STATE_HIDDEN (Bug#9893).
6376 (do_ewmh_fullscreen): Ignore return value from get_current_wm_state.
6377 (x_handle_net_wm_state): Return what get_current_wm_state returns.
6378 (x_term_init): Initialize dpyinfo->Xatom_net_wm_state_hidden.
6379
196e41e4
PE
63802011-10-29 Paul Eggert <eggert@cs.ucla.edu>
6381
6382 * alloc.c (which_symbols): Declare EXTERNALLY_VISIBLE,
6383 so that this new function doesn't get optimized away by a
6384 whole-program optimizer. Make the 2nd arg EMACS_INT, not int.
6385
021f2e1a
AS
63862011-10-29 Andreas Schwab <schwab@linux-m68k.org>
6387
6388 * frame.h (MOUSE_HL_INFO): Remove excess parens.
6389
8b058d44
EZ
63902011-10-29 Eli Zaretskii <eliz@gnu.org>
6391
6392 Fix the `xbytecode' command.
6393 * .gdbinit (xprintbytestr): New command.
b50a28de 6394 (xwhichsymbols): Rename from `which'; all callers changed.
8b058d44
EZ
6395 (xbytecode): Print the byte-code string as well.
6396
4452fb80
EZ
63972011-10-29 Kim Storm <storm@cua.dk>
6398
8b058d44
EZ
6399 * alloc.c (which_symbols): New function.
6400
21b72067
AS
64012011-10-29 Andreas Schwab <schwab@linux-m68k.org>
6402
6403 * minibuf.c (read_minibuf_noninteractive): Allow reading empty
6404 line. (Bug#9903)
6405
83ed7b5c
GM
64062011-10-29 Glenn Morris <rgm@gnu.org>
6407
6408 * process.c (wait_reading_process_output): Revert 2009-08-30 change.
6409 Not clear what it was for, and it causes various bugs. (Bug#9839)
6410
5a7a728b
EZ
64112011-10-28 Eli Zaretskii <eliz@gnu.org>
6412
6413 * xdisp.c (note_mouse_highlight): Initialize `part', to avoid a
6414 possible random value that matches one of those tested as
6415 condition to clear the mouse face.
6416
d3d0842f
CY
64172011-10-28 Chong Yidong <cyd@gnu.org>
6418
6419 * xdisp.c (note_mouse_highlight): Fix use of uninitialized var.
6420
31b39d13
DN
64212011-10-28 Dan Nicolaescu <dann@ics.uci.edu>
6422
6423 * window.c (make_window): Initialize phys_cursor_on_p.
6424
9aba6043
SM
64252011-10-28 Stefan Monnier <monnier@iro.umontreal.ca>
6426
6427 * lisp.h (struct Lisp_Symbol): Update comments.
6428
c20992f4
JB
64292011-10-28 Juanma Barranquero <lekktu@gmail.com>
6430
6431 * w32font.c (w32_load_unicows_or_gdi32): Add missing return.
6432
db4f02f2
EZ
64332011-10-28 Eli Zaretskii <eliz@gnu.org>
6434
6435 Fix Emacs on Windows 9X (bug#8562). Thanks to oslsachem
6436 <oslsachem@gmail.com> for helping to debug this.
6437
6438 * w32font.c (g_b_init_is_w9x, g_b_init_get_outline_metrics_w)
6439 (g_b_init_get_text_metrics_w, g_b_init_get_glyph_outline_w)
6440 (g_b_init_get_glyph_outline_w): New static variables.
6441 (GetOutlineTextMetricsW_Proc, GetTextMetricsW_Proc)
6442 (GetGlyphOutlineW_Proc): New typedefs.
6443 (w32_load_unicows_or_gdi32, get_outline_metrics_w)
9aba6043
SM
6444 (get_text_metrics_w, get_glyph_outline_w, globals_of_w32font):
6445 New functions.
6446 (w32font_open_internal, compute_metrics):
6447 Call get_outline_metrics_w, get_text_metrics_w, and get_glyph_outline_w
db4f02f2
EZ
6448 instead of calling the "wide" APIs directly.
6449
6450 * emacs.c (main) [HAVE_NTGUI]: Call globals_of_w32font.
6451
6452 * w32.h (syms_of_w32font): Add prototype.
6453
87e68db4
JB
64542011-10-27 Juanma Barranquero <lekktu@gmail.com>
6455
6456 * window.c (Fframe_root_window, Fframe_first_window, Fwindow_end)
6457 (Fframe_selected_window, Ftemp_output_buffer_show, Fnext_window)
6458 (Fdelete_window_internal, Fwindow_parameters): Fix typos in docstrings.
6459 (Fmove_to_window_line): Doc fix.
6460
435c1d67
CY
64612011-10-27 Chong Yidong <cyd@gnu.org>
6462
6463 * process.c (make_process): Set gnutls_state to NULL.
6464
6465 * gnutls.c (emacs_gnutls_deinit): Deinit the gnutls_state if it is
6466 non-NULL, regardless of GNUTLS_INITSTAGE.
6467 (Fgnutls_boot): Cleanups. Call emacs_gnutls_deinit if we signal
6468 an error. Set process slots as soon as we allocate them.
6469
6470 * gnutls.h (GNUTLS_LOG, GNUTLS_LOG2): Fix macros.
6471
9c6c6f49
CY
64722011-10-27 Chong Yidong <cyd@gnu.org>
6473
9aba6043
SM
6474 * gnutls.c (emacs_gnutls_deinit): New function.
6475 Deallocate credentials structures as well as calling gnutls_deinit.
9c6c6f49
CY
6476 (Fgnutls_deinit, Fgnutls_boot): Use it.
6477
6478 * process.c (make_process): Initialize GnuTLS credentials to NULL.
6479 (deactivate_process): Call emacs_gnutls_deinit.
6480
657d08d3
JB
64812011-10-27 Juanma Barranquero <lekktu@gmail.com>
6482
6483 * image.c (x_create_x_image_and_pixmap):
6484 * w32.c (sys_rename, w32_delayed_load):
6485 * w32font.c (fill_in_logfont):
6486 * w32reg.c (x_get_string_resource): Silence compiler warnings.
6487
5430d399
JB
64882011-10-26 Juanma Barranquero <lekktu@gmail.com>
6489
6490 * w32fns.c (w32_default_color_map): New function,
6491 extracted from Fw32_default_color_map.
a7ef684b 6492 (Fw32_default_color_map, Fx_open_connection): Use it. (Bug#9785)
5430d399 6493
fe0055fa
PE
64942011-10-25 Paul Eggert <eggert@cs.ucla.edu>
6495
6496 * dispextern.h (Fcontrolling_tty_p): New decl (Bug#6649 part 2).
6497
e6346438
SM
64982011-10-25 Stefan Monnier <monnier@iro.umontreal.ca>
6499
6500 * keyboard.c (test_undefined): New function (bug#9751).
6501 (read_key_sequence): Use it to detect when a key is bound to `undefined'.
6502
e112cc37
ET
65032011-10-25 Enami Tsugutomo <tsugutomo.enami@jp.sony.com>
6504
6505 * sysdep.c (init_sys_modes): Fix the check for the controlling
6506 terminal (Bug#6649).
6507
7b5d6677
EZ
65082011-10-20 Eli Zaretskii <eliz@gnu.org>
6509
6510 * dispextern.h (struct bidi_it): New member next_en_type.
6511
6512 * bidi.c (bidi_line_init): Initialize the next_en_type member.
6513 (bidi_resolve_explicit_1): When next_en_pos is valid for the
6514 current character, check also for next_en_type being WEAK_EN.
6515 (bidi_resolve_weak): Don't enter the expensive loop if the current
6516 position is before next_en_pos. Record the bidi type of the first
6517 non-ET, non-BN character we find, in addition to its position.
6518 (bidi_level_of_next_char): Invalidate next_en_type when
6519 next_en_pos is over-stepped.
6520
7da0b018
PE
65212011-10-20 Paul Eggert <eggert@cs.ucla.edu>
6522
6523 Time zone name fixes for non-ASCII locales (Bug#641, Bug#9794)
6524 * editfns.c: Rewrite current-time-zone so that it invokes
6525 the equivalent of (format-time-string "%Z") to get the time zone name.
6526 This fixes a bug when the time zone name contains characters that
6527 need converting from the system time locale to Emacs internal format.
6528 This fixes a shortcoming that I introduced in my 1999-10-19 patch:
6529 that patch fixed format-time-string to do the conversion, but
6530 I forgot to fix current-time-zone.
6531 (format_time_string): New function, containing most of
6532 what Fformat_time_string used to contain.
6533 (Fformat_time_string): Rewrite in terms of format_time_string.
6534 This doesn't change this function's behavior.
6535 (current-time-zone): Rewrite to use format_time_string.
6536 This fixes the bug reported by Michael Schierl in
6537 <http://lists.gnu.org/archive/html/emacs-devel/2007-06/msg00334.html>.
6538 Jason Rumney's 2007-06-07 change worked around this bug, but
6539 didn't fix it.
6540 * systime.h (tzname, timezone): Remove no-longer-used declarations.
6541
8547b010
EZ
65422011-10-19 Eli Zaretskii <eliz@gnu.org>
6543
6544 * xdisp.c (start_display): If the character at POS is displayed
6545 via a display vector, reset IT->current.dpvec_index to zero.
12b32963
EZ
6546 (try_window_reusing_current_matrix): If a line ends in a display
6547 vector or the next line starts in a display vector, continue
6548 redrawing the window even though the character position of
6549 start_row was reached.
8547b010
EZ
6550 (Bug#9771, part 2)
6551
4e948d15
CY
65522011-10-18 Chong Yidong <cyd@gnu.org>
6553
6554 * xdisp.c (get_next_display_element): Handle U+2010 and U+2011
6555 with nobreak-char-display too.
6556
4787455f
EZ
65572011-10-18 Eli Zaretskii <eliz@gnu.org>
6558
6559 Fix part 3 of bug#9771.
6560 * bidi.c (bidi_line_init): Initialize next_en_pos to zero, not -1.
6561 (bidi_resolve_neutral): Don't enter the expensive loop looking for
6562 non-neutral characters if the current character is a paragraph
6563 separator (a.k.a. Newline). This avoids running the same
6564 expensive loop twice, once when we consume the preceding newline
6565 and the other time when the line actually needs to be displayed.
6566 Avoid the loop when we see neutrals on the base embedding level
6567 following a character whose directionality is the same as the
6568 paragraph's. This avoids running the expensive loop when a line
6569 ends in a long sequence of neutrals, like control characters.
6570 Add assertion against STRONG_AL type. Slightly rearrange code
6571 that determines the type of a neutral given the first non-neutral
6572 that follows it.
6573 (bidi_level_of_next_char): Set next_en_pos to zero when
6574 invalidating its info.
6575
2c91f553
EZ
65762011-10-17 Eli Zaretskii <eliz@gnu.org>
6577
6578 * xdisp.c (push_display_prop): Determine whether to record string
6579 or buffer position by IT->string, not by IT->method. Allow
6580 GET_FROM_DISPLAY_VECTOR as IT->method on entry. (Bug#9771, part 4)
f2ff9e88
EZ
6581 (move_it_vertically_backward): Don't look for character position
6582 immediately after the newline when in a continuation line.
6583 (Bug#9771, part 1)
2c91f553 6584
c7b08b0d
MR
65852011-10-15 Martin Rudalics <rudalics@gmx.at>
6586
6587 * window.c (coordinates_in_window): Rewrite and delabelize
6588 vertical border check. (Bug#5357) (Bug#9618)
6589
6b02f655
SM
65902011-10-14 Stefan Monnier <monnier@iro.umontreal.ca>
6591
6592 * xterm.c (frame_highlight, frame_unhighlight): Ignore unexplained
6593 errors in XSetWindowBorder (bug#9310).
6594
81d40c92
DA
65952011-10-13 Dmitry Antipov <dmantipov@yandex.ru>
6596
6597 * editfns.c (Fset_time_zone_rule): Replace free with xfree to
6598 avoid crash when xmalloc overrun checking is enabled.
6599
d4172c3b
EZ
66002011-10-13 Eli Zaretskii <eliz@gnu.org>
6601
6602 * xdisp.c (Fcurrent_bidi_paragraph_direction): Initialize
6603 itb.paragraph_dir to NEUTRAL_DIR. Fixes an occasional incorrect
6604 cursor motion with <left> and <right> arrow keys.
6605
6606 * bidi.c (bidi_init_it): Don't initialize paragraph_dir here, as
6607 some callers set that themselves.
6608
b00eea75
EZ
66092011-10-12 Eli Zaretskii <eliz@gnu.org>
6610
6611 * xdisp.c (find_row_edges): Handle the case where ROW comes from a
6612 display string and the previous row comes from the same string and
6613 is empty. (Bug#9739) (Bug#9738)
6614
8fe012c4
SM
66152011-10-12 Stefan Monnier <monnier@iro.umontreal.ca>
6616
6617 * doc.c (get_doc_string): Encode file name (bug#9735).
6618
0074aef2
EZ
66192011-10-12 Eli Zaretskii <eliz@gnu.org>
6620
79beb178
EZ
6621 * bidi.c (bidi_level_of_next_char):
6622 * xdisp.c (get_visually_first_element): Remove old incorrect
6623 comments regarding the Unicode Line Separator character.
6624
0074aef2
EZ
6625 * bidi.c (bidi_init_it): Initialize paragraph_dir to NEUTRAL_DIR.
6626
6e4b3fbe
DA
66272011-10-12 Dmitry Antipov <dmantipov@yandex.ru>
6628
6629 * alloc.c (Fgc_status): Do not access beyond zombies array
6630 boundary if nzombies > MAX_ZOMBIES.
6631 * alloc.c (dump_zombies): Add missing format specifier.
6632
0324f3af
PE
66332011-10-12 Paul Eggert <eggert@cs.ucla.edu>
6634
b5525cac
PE
6635 * xdisp.c (set_cursor_from_row): Simplify conditionals,
6636 to pacify GCC 4.6.1 x86-64 with -O2 -Wstrict-overflow.
6637
0324f3af
PE
6638 * lread.c (read_escape): Allow hex escapes as large as ?\xfffffff.
6639 Some packages use them to denote characters with modifiers.
6640
e9b5f888
AS
66412011-10-11 Andreas Schwab <schwab@linux-m68k.org>
6642
6643 * lisp.h (GCPRO1_VAR, GCPRO2_VAR, GCPRO3_VAR, GCPRO4_VAR)
6644 (GCPRO5_VAR, GCPRO6_VAR, UNGCPRO_VAR): Add whitespace to avoid
6645 matching a pp-number. Rename parameter var to var1.
6646
127827c0
SM
66472011-10-11 Stefan Monnier <monnier@iro.umontreal.ca>
6648
6649 * minibuf.c (Finternal_complete_buffer): Fix last change (bug#9709).
6650
c8fd3bd0
GM
66512011-10-08 Glenn Morris <rgm@gnu.org>
6652
6653 * callint.c (Fcall_interactively): Give a more explicit error for the
6654 'c' case with a non-character input. (Bug#8479)
6655
352ec8ff
EZ
66562011-10-08 Eli Zaretskii <eliz@gnu.org>
6657
03669ccb
EZ
6658 * xdisp.c (hscroll_window_tree): Support hscroll in right-to-left
6659 lines.
7061c986
EZ
6660 (set_cursor_from_row): Fix cursor positioning in mixed L2R+R2L
6661 lines that are hscrolled on the left.
03669ccb 6662
352ec8ff
EZ
6663 * dispnew.c (buffer_posn_from_coords): Account for a possible
6664 presence of header-line. (Bug#4426)
6665
a66cfb1c
SM
66662011-10-07 Stefan Monnier <monnier@iro.umontreal.ca>
6667
6b02f655
SM
6668 * buffer.c (syms_of_buffer) <enable-multibyte-characters>:
6669 Don't advertise functionality which we discourage or doesn't work.
a66cfb1c 6670
7c5ee88e
PE
66712011-10-07 Paul Eggert <eggert@cs.ucla.edu>
6672
6673 * alloc.c (GC_LISP_OBJECT_ALIGNMENT): Use offsetof, not __alignof__
6674 or sizeof. __alignof__ gives the wrong answer on Fedora x86-64
6675 with GCC 4.6.1 when configured with CC='gcc -m32' --with-wide-int;
6676 this makes Emacs dump core during garbage collection on rare
6677 occasions. sizeof is obviously inferior to offsetof here, so
6678 stick with offsetof.
6679 (GC_POINTER_ALIGNMENT): New macro.
6680 (mark_memory): Omit 3rd (offset) arg; caller changed.
6681 Don't assume EMACS_INT alignment is the same as pointer alignment.
6682
df1bbe5b
SM
66832011-10-03 Stefan Monnier <monnier@iro.umontreal.ca>
6684
6685 * keyboard.c (read_key_sequence_remapped): New var.
6686 (read_key_sequence): Compute remapping in the right buffer.
6687 (command_loop_1): Use read_key_sequence's remapping directly.
6688
51553db6
SM
66892011-10-02 Stefan Monnier <monnier@iro.umontreal.ca>
6690
32c1fffd
SM
6691 * dired.c (file_name_completion): Don't expand file name.
6692 (Ffile_name_completion, Ffile_name_all_completions): Expand file name
6693 before checking file name handler.
6694
51553db6
SM
6695 * minibuf.c (Finternal_complete_buffer): Only show internal buffers if
6696 they've been requested explicitly (bug#9591).
6697
b6bd1599 66982011-10-01 Andreas Schwab <schwab@linux-m68k.org>
fa2ec41f
AS
6699
6700 * keymap.c (Fsingle_key_description): Use make_specified_string
6701 instead of build_string to build string from push_key_description.
6702 (Bug#5193)
6703
f701dc2a
PE
67042011-09-30 Paul Eggert <eggert@cs.ucla.edu>
6705
4222c55d
PE
6706 * buffer.h (struct buffer): Use time_t, not int, for a time stamp.
6707 This fixes a Y2038 bug on 64-bit hosts.
6708 * buffer.c (reset_buffer):
6709 * fileio.c (Fdo_auto_save, Fset_buffer_auto_saved)
6710 (Fclear_buffer_auto_save_failure):
6711 Use 0, not -1, to represent an unset failure time, since time_t
6712 might not be signed.
6713
f701dc2a
PE
6714 Remove dependency on glibc malloc internals.
6715 * alloc.c (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
6716 Move back here from lisp.h, but with their new implementations.
6717 (XMALLOC_BASE_ALIGNMENT, COMMON_MULTIPLE, XMALLOC_HEADER_ALIGNMENT)
6718 (XMALLOC_OVERRUN_SIZE_SIZE): Move these new lisp.h macros here.
6719 * charset.c (charset_table_init): New static var.
6720 (syms_of_charset): Use it instead of xmalloc. This removes a
6721 dependency on glibc malloc internals. See Eli Zaretskii's comment in
6722 <http://lists.gnu.org/archive/html/emacs-devel/2011-09/msg00815.html>.
6723 * lisp.h (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
6724 Move back to alloc.c.
6725 (XMALLOC_BASE_ALIGNMENT, COMMON_MULTIPLE, XMALLOC_HEADER_ALIGNMENT)
6726 (XMALLOC_OVERRUN_SIZE_SIZE): Move to alloc.c.
6727
9ceebf39
JD
67282011-09-30 Jan Djärv <jan.h.d@swipnet.se>
6729
6730 * nsterm.m (windowDidResize): Call x_set_window_size only when
6731 ns_in_resize is true. Otherwise set pixelwidth/height and
6732 call change_frame_size (Bug#9628).
6733
cb993c58
PE
67342011-09-30 Paul Eggert <eggert@cs.ucla.edu>
6735
3930c88b
PE
6736 Port --enable-checking=all to Fedora 14 x86-64.
6737 * charset.c (syms_of_charset): Also account for glibc malloc's
6738 internal overhead when calculating the initial malloc maximum.
6739
cb993c58
PE
6740 Port --enable-checking=all to Fedora 14 x86.
6741 * alloc.c (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
6742 Move to lisp.h.
6743 (xmalloc_put_size, xmalloc_get_size, overrun_check_malloc)
6744 (overrun_check_realloc, overrun_check_free):
6745 Use XMALLOC_OVERRUN_SIZE_SIZE, not sizeof (size_t).
6746 That way, xmalloc returns a properly-aligned pointer even if
6747 XMALLOC_OVERRUN_CHECK is defined. The old debugging code happened
6748 to align OK on typical 64-bit hosts, but not on Fedora 14 x86.
6749 * charset.c (syms_of_charset): Take XMALLOC_OVERRUN_CHECK_OVERHEAD
6750 into account when calculating the initial malloc maximum.
6751 * lisp.h (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
6752 Move here from alloc.c, so that charset.c can use it too.
6753 Properly align; the old code wasn't right for common 32-bit hosts
6754 when configured with --enable-checking=all.
6755 (XMALLOC_BASE_ALIGNMENT, COMMON_MULTIPLE, XMALLOC_HEADER_ALIGNMENT)
6756 (XMALLOC_OVERRUN_SIZE_SIZE): New macros.
6757
31bed486
EZ
67582011-09-29 Eli Zaretskii <eliz@gnu.org>
6759
04c70788 6760 * sysdep.c (snprintf) [!EOVERFLOW]: If EOVERFLOW is not defined,
31bed486
EZ
6761 use EDOM.
6762
fbcaa2f3
EZ
67632011-09-28 Eli Zaretskii <eliz@gnu.org>
6764
6765 * xdisp.c (compute_display_string_end): If there's no display
6766 string at CHARPOS, return -1.
6767
6768 * bidi.c (bidi_fetch_char): When compute_display_string_end
6769 returns a negative value, treat the character as a normal
6770 character not covered by a display string. (Bug#9624)
6771
a239d4e9
JB
67722011-09-28 Juanma Barranquero <lekktu@gmail.com>
6773
6774 * lread.c (Fread_from_string): Fix typo in docstring.
6775
88652fd5
EZ
67762011-09-27 Eli Zaretskii <eliz@gnu.org>
6777
6778 * xdisp.c (handle_invisible_prop): If invisible text ends on a
6779 newline, reseat the iterator instead of bidi-iterating there one
6780 character at a time. (Bug#9610)
32c1fffd
SM
6781 (BUFFER_POS_REACHED_P, move_it_in_display_line_to): Bail when past
6782 TO_CHARPOS if the bidi iterator is at base embedding level.
88652fd5 6783
ed497dd4
AS
67842011-09-27 Andreas Schwab <schwab@linux-m68k.org>
6785
6786 * lread.c (readevalloop): Use correct code for NBSP.
6787 (read1): Likewise. (Bug#9608)
6788
b2bf61aa
MA
67892011-09-25 Michael Albinus <michael.albinus@gmx.de>
6790
6791 * dbusbind.c (Fdbus_register_signal): When service is not
6792 registered, use nil in Vdbus_registered_objects_table. (Bug#9581)
6793
32bbb17c
GM
67942011-09-25 Glenn Morris <rgm@gnu.org>
6795
6796 * buffer.c (truncate-lines): Doc fix.
6797
94e0933e
CY
67982011-09-24 Chong Yidong <cyd@stupidchicken.com>
6799
6800 * window.c (Fwindow_prev_buffers, Fset_window_prev_buffers)
6801 (Fset_window_next_buffers): Doc fix.
6802
cddde921
GM
68032011-09-24 Glenn Morris <rgm@gnu.org>
6804
6805 * minibuf.c (read_minibuf): Disable line truncation. (Bug#5715)
6806
1260aef1
PE
68072011-09-24 Paul Eggert <eggert@cs.ucla.edu>
6808
25b4bfa0
PE
6809 Fix minor problems found by static checking.
6810 * xdisp.c (string_from_display_spec): Don't assume vecsize fits in int.
1260aef1
PE
6811 * indent.c (Fvertical_motion): Fix == vs = typo.
6812
e3cbd34b
EZ
68132011-09-24 Eli Zaretskii <eliz@gnu.org>
6814
a66cfb1c
SM
6815 * dispnew.c (syms_of_display) <redisplay-dont-pause>:
6816 Default value is now t. Doc fix.
6bf7006f 6817
e3cbd34b 6818 * indent.c (Fvertical_motion): Compute and apply the overshoot
32c1fffd 6819 logic when moving up, not only when moving down. Fix the
e3cbd34b 6820 confusing name and values of the it_overshoot_expected variable;
32c1fffd 6821 logic changes accordingly. (Bug#9254) (Bug#9549)
e3cbd34b
EZ
6822
6823 * xdisp.c (pos_visible_p): Produce correct pixel coordinates when
6824 CHARPOS is covered by a display string which includes newlines.
6825 (move_it_vertically_backward): Avoid inflooping when START_CHARPOS
6826 is covered by a display string with embedded newlines.
6827
a3de0cbd
MA
68282011-09-24 Michael Albinus <michael.albinus@gmx.de>
6829
6830 * dbusbind.c (Fdbus_register_signal): Add match rule to
6831 Vdbus_registered_objects_table. (Bug#9581)
a66cfb1c
SM
6832 (Fdbus_register_method, Vdbus_registered_objects_table):
6833 Fix docstring.
a3de0cbd 6834
b260039d
JM
68352011-09-24 Jim Meyering <meyering@redhat.com>
6836
32c1fffd 6837 do not ignore write error for any output size
b260039d
JM
6838 The previous change was incomplete.
6839 While it makes emacs --batch detect the vast majority of stdout
6840 write failures, errors were still ignored whenever the output size is
6841 k * (BUFSIZ+1) - 4. E.g., on a system with BUFSIZ of 4096,
6842 $ emacs --batch --eval '(print (format "%4093d" 0))' > /dev/full \
6843 && echo FAIL: ignored write error
6844 FAIL: ignored write error
6845 $ emacs --batch --eval '(print (format "%20481d" 0))' > /dev/full \
6846 && echo FAIL: ignored write error
6847 FAIL: ignored write error
6848 * emacs.c (Fkill_emacs): Also test ferror. (Bug#9574)
6849
8eca8a7c
AS
68502011-09-23 Andreas Schwab <schwab@linux-m68k.org>
6851
6852 * emacs.c (Fkill_emacs): In noninteractive mode exit
6853 non-successfully if a write error occurred on stdout. (Bug#9574)
6854
3341db62
EZ
68552011-09-21 Eli Zaretskii <eliz@gnu.org>
6856
6857 * xdisp.c (pop_it): Allow it->object that is a cons cell to pass
6858 the xassert test.
6859
6860 * dispextern.h (struct it): Update the comment documenting what
6861 can it->OBJECT be.
6862
8c203dbf
EZ
68632011-09-20 Eli Zaretskii <eliz@gnu.org>
6864
6865 * xdisp.c (set_cursor_from_row): If the row ends in a newline from
6866 a display string, extend search for cursor position to end of row.
6867 (find_row_edges): If the row ends in a newline from a display
6868 string, increment its MATRIX_ROW_END_CHARPOS by one. (Bug#9549)
6869 Handle the case of a display string with multiple newlines.
fd317ddf
EZ
6870 (Fcurrent_bidi_paragraph_direction): Fix search for previous
6871 non-empty line. Fixes confusing cursor motion with arrow keys at
6872 the beginning of a line that starts with whitespace.
8c203dbf 6873
a4824228
LMI
68742011-09-19 Lars Magne Ingebrigtsen <larsi@gnus.org>
6875
6876 * lread.c (Fread_from_string): Document what FINAL-STRING-INDEX is
6877 (bug#9493).
6878
33ed493b
CY
68792011-09-18 Chong Yidong <cyd@stupidchicken.com>
6880
6881 * xfns.c (Fx_create_frame): Handle the bitmapIcon resource as
6882 boolean (Bug#9154).
6883
56cd55c8
EZ
68842011-09-18 Eli Zaretskii <eliz@gnu.org>
6885
6886 * xdisp.c (display_line): Record maximum and minimum buffer
6887 positions even if no glyphs were produced (e.g., by a zero-width
6888 stretch). Fixes bug#9530 on a TTY. Under word-wrap, don't record
6889 buffer positions that will be removed from the glyph row because
6890 they don't fit.
c02dcedf
EZ
6891 (produce_stretch_glyph): Fix a bug in :align-to on a TTY when the
6892 column is beyond frame width: don't subtract 1 "pixel" when
6893 computing width of the stretch.
3e62b7e0
EZ
6894 (reseat_at_next_visible_line_start): Undo the change made on
6895 2011-09-17 that saved paragraph information and restored it after
6896 the call to `reseat'. (Bug#9545)
56cd55c8 6897
5ed99d36 68982011-09-18 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
3390454c
YM
6899
6900 * xdisp.c (expose_window): Save original value of phys_cursor_on_p
6901 and turn window cursor on if cleared (Bug#9415).
6902
5ed99d36 69032011-09-18 Andreas Schwab <schwab@linux-m68k.org>
edb7b4dc
AS
6904
6905 * search.c (boyer_moore): Take unibyte characters from pattern
6906 literally. (Bug#9458)
6907
9bade7b2
EZ
69082011-09-18 Eli Zaretskii <eliz@gnu.org>
6909
6910 * xdisp.c (reseat_at_next_visible_line_start): Fix last change.
6911
e5e9d610
PE
69122011-09-18 Paul Eggert <eggert@cs.ucla.edu>
6913
87e4427a
PE
6914 Fix minor problem found by static checking.
6915 * xdisp.c (reseat_at_next_visible_line_start): Mark locals as
6916 initialized, to pacify gcc -Wuninitialized.
6917
e5e9d610
PE
6918 * fileio.c: Report proper errno when syscall falls.
6919 (Finsert_file_contents): Save and restore errno,
6920 so that report_file_error outputs the correct diagnostic.
6921 (Fwrite_region) [CLASH_DETECTION]: Likewise.
6922
a1674f0b
EZ
69232011-09-18 Eli Zaretskii <eliz@gnu.org>
6924
6925 * .gdbinit (pgx): Fix references to fields of `struct glyph'.
6926
fbfb6dd4
EZ
69272011-09-17 Eli Zaretskii <eliz@gnu.org>
6928
6929 * xdisp.c (produce_stretch_glyph): Another fix for changes made on
6930 2011-08-30T17:32:44Z!eliz@gnu.org. (Bug#9530)
6931
bb187662
EZ
69322011-09-17 Eli Zaretskii <eliz@gnu.org>
6933
1137e8b8 6934 * xdisp.c (reseat_at_next_visible_line_start): Keep information
6b02f655 6935 about the current paragraph and restore it after the call to reseat.
1137e8b8
EZ
6936
6937 * bidi.c (MAX_PARAGRAPH_SEARCH): New macro.
6938 (bidi_find_paragraph_start): Search back for paragraph beginning
6939 at most MAX_PARAGRAPH_SEARCH lines; if not found, return BEGV_BYTE.
6940 (bidi_move_to_visually_next): Only trigger paragraph-related
6941 computations when the last character is a newline or at EOB, not
6942 just any NEUTRAL_B. (Bug#9470)
6943
bb187662
EZ
6944 * xdisp.c (set_cursor_from_row): Don't invoke special treatment of
6945 truncated lines if point is covered by a display string. (Bug#9524)
6946
2e621251
PE
69472011-09-16 Paul Eggert <eggert@cs.ucla.edu>
6948
6949 * xselect.c: Relax test for outgoing X longs (Bug#9498).
6950 (cons_to_x_long): New function.
6951 (lisp_data_to_selection_data): Use it. Correct the test for
6952 short-versus-long data; it was negated. Break out of vector
6953 loop, for efficiency, when a long datum is discovered.
6954
91a15bc6
SM
69552011-09-16 Stefan Monnier <monnier@iro.umontreal.ca>
6956
6957 * eval.c (Fquote): Document its non-consing behavior (bug#9482).
6958
b41c3a35
EZ
69592011-09-16 Eli Zaretskii <eliz@gnu.org>
6960
6961 * image.c (tiff_handler): Work around a bug in MinGW GCC 3.x (see
6962 GCC PR/17406) by declaring this function with external scope.
6963
7812ba2d
PE
69642011-09-15 Paul Eggert <eggert@cs.ucla.edu>
6965
6966 * editfns.c (Fformat): Fix bug in text-property fix (Bug#9514).
6967 Don't mishandle (length (format "%%")) and (format "%4000s%%" "").
6968
cf7edc2a
AS
69692011-09-15 Andreas Schwab <schwab@linux-m68k.org>
6970
6971 * editfns.c (Fformat): Correctly handle text properties on "%%".
6972
bd01620e
EZ
69732011-09-15 Eli Zaretskii <eliz@gnu.org>
6974
6975 * xterm.c (x_draw_composite_glyph_string_foreground):
6976 * w32term.c (x_draw_composite_glyph_string_foreground):
6977 * term.c (encode_terminal_code):
6978 * composite.c (composition_update_it, get_composition_id):
6979 * xdisp.c (get_next_display_element)
6980 (fill_composite_glyph_string): Add comments about special meaning
6981 of TAB characters in a composition.
6982
a02719a3
PE
69832011-09-15 Paul Eggert <eggert@cs.ucla.edu>
6984
6985 * editfns.c (Fformat): Fix off-by-1 bug for "%%b" (Bug#9514).
4c122725
PE
6986 This occurs when processing a multibyte format.
6987 Problem reported by Wolfgang Jenker.
a02719a3 6988
72589a3c
JB
69892011-09-15 Johan Bockgård <bojohan@gnu.org>
6990
6991 * xdisp.c (try_cursor_movement): Only check for exact match if
6992 cursor hpos found by set_cursor_from_row is valid. (Bug#9495)
6993
1c14176c
PE
69942011-09-14 Paul Eggert <eggert@cs.ucla.edu>
6995
6996 Remove unused external symbols.
6997 * dispextern.h (calc_pixel_width_or_height): Remove decl.
6998 * xdisp.c (calc_pixel_width_or_height): Now static.
6999 * doprnt.c (exprintf) [! (HAVE_X_WINDOWS && USE_X_TOOLKIT)]: Remove.
7000 * indent.c (check_display_width):
7001 * w32term.c: Fix comment to match code.
7002 * xterm.c, xterm.h (x_catching_errors): Remove.
7003
d2eea5b5
PE
70042011-09-14 Paul Eggert <eggert@cs.ucla.edu>
7005
7006 * xselect.c: Use signed conversions more consistently (Bug#9498).
7007 (selection_data_to_lisp_data): Assume incoming selection data are
7008 signed integers, not unsigned. This is to be consistent with
7009 outgoing selection data, which was modified to use signed integers
7010 in as part of the fix to Bug#9196 in response to Jan D.'s comment
7011 in <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=9196#32> that X11
7012 expects long, not unsigned long.
7013
46888499
EZ
70142011-09-14 Eli Zaretskii <eliz@gnu.org>
7015
7016 * xdisp.c (try_window_reusing_current_matrix): Fix incorrect
7017 computation of loop end. Reported by Johan Bockgård
7018 <bojohan@gnu.org>.
7019
ef8ef9fb
CY
70202011-09-13 Chong Yidong <cyd@stupidchicken.com>
7021
7022 * frame.c (Fother_visible_frames_p): Function deleted.
7023
fa819fed
EZ
70242011-09-12 Eli Zaretskii <eliz@gnu.org>
7025
7026 * indent.c (compute_motion): Process display vector front to back
7027 rather than the other way around. (Bug#2496)
7028
2ba8e008
SM
70292011-09-12 Stefan Monnier <monnier@iro.umontreal.ca>
7030
7031 * fileio.c (Finsert_file_contents): Don't assume beg_offset is 0.
7032
20f53c69
CY
70332011-09-11 Chong Yidong <cyd@stupidchicken.com>
7034
7035 * minibuf.c (Fread_from_minibuffer): Doc fix.
7036
d562d7a4
EZ
70372011-09-11 Eli Zaretskii <eliz@gnu.org>
7038
7039 * xdisp.c (produce_stretch_glyph): Fix a typo made in changes from
7040 2011-08-30T17:32:44Z!eliz@gnu.org. (Bug#9475)
7041
1c4d7f3d
LMI
70422011-09-11 Lars Magne Ingebrigtsen <larsi@gnus.org>
7043
7044 * fileio.c (Fvisited_file_modtime): Document `(-1 65535)' as a
7045 value for non-existent files.
7046
b885bf36
EZ
70472011-09-11 Eli Zaretskii <eliz@gnu.org>
7048
7049 * fileio.c (Finsert_file_contents): If the file cannot be opened,
7050 set its "size" to -1. This will set the modtime_size field of
7051 the corresponding buffer to -1, which is what
7052 verify-visited-file-modtime expects for files that do not exist.
7053 (Bug#9139)
7054
6612f0bf
PE
70552011-09-11 Paul Eggert <eggert@cs.ucla.edu>
7056
7057 * keymap.h (KEY_DESCRIPTION_SIZE, push_key_description): Move decls
7058 here ...
7059 * lisp.h: ... from here. push_key_description is no longer
7060 defined in keyboard.c, so its declaration should not be in
7061 lisp.h's "Defined in keyboard.c" section, and KEY_DESCRIPTION_SIZE
7062 logically belongs with push_key_description.
7063
dfb3f755
PE
70642011-09-10 Paul Eggert <eggert@cs.ucla.edu>
7065
7066 * buffer.h: Include <sys/types.h> instead of <time.h>.
7067 Otherwise, off_t wasn't defined on FreeBSD 9.0-BETA2 i386.
7068 Problem reported by Herbert J. Skuhra.
7069
3134906c
LMI
70702011-09-10 Lars Magne Ingebrigtsen <larsi@gnus.org>
7071
7072 * xml.c (parse_region): Make the parsing work for
7073 non-comment-starting XML files again (bug#9144).
7074
8d903f4e
AS
70752011-09-10 Andreas Schwab <schwab@linux-m68k.org>
7076
7077 * image.c (gif_load): Fix calculation of bottom and right corner.
7078 (Bug#9468)
7079
80ad64f4
EZ
70802011-09-10 Eli Zaretskii <eliz@gnu.org>
7081
7082 * xdisp.c (MAX_DISP_SCAN): Decrease to 250. Prevents sluggish
7083 redisplay in small windows.
7084
208a048d
EZ
70852011-09-09 Eli Zaretskii <eliz@gnu.org>
7086
7087 * frame.c (x_report_frame_params): Cast to avoid compiler warnings.
7088
9b1c252e
MR
70892011-09-08 Martin Rudalics <rudalics@gmx.at>
7090
7091 * window.c (Fset_window_prev_buffers, Fset_window_next_buffers):
7092 Operate on live windows only.
7093
2949f33b
JB
70942011-09-08 Juanma Barranquero <lekktu@gmail.com>
7095
7096 * emacs.c (my_heap_start): #ifdef to avoid warnings when unused.
7097
e08dcafd
EZ
70982011-09-07 Eli Zaretskii <eliz@gnu.org>
7099
7100 * xdisp.c (move_it_in_display_line_to): Call RESTORE_IT on ppos_it
7101 only under bidi iteration.
7102
115b96bd
JD
71032011-09-07 Jan Djärv <jan.h.d@swipnet.se>
7104
7105 * gtkutil.c (xg_make_tool_item): Insert comment about eventbox.
7106
c8199d0f
PE
71072011-09-06 Paul Eggert <eggert@cs.ucla.edu>
7108
7109 isnan: Fix porting problem to Solaris 10 with bundled gcc.
7110 Without this fix, the command to link temacs failed due to an
7111 undefined symbol __builtin_isnan. This is because
7112 /usr/include/iso/math_c99.h #defines isnan(x) to
7113 __builtin_isnan(x), but the bundled gcc, which identifies itself
7114 as gcc 3.4.3 (csl-sol210-3_4-branch+sol_rpath), does not have
7115 a __builtin_isnan.
7116 * floatfns.c (isnan): #undef, and then #define to a clone of
7117 what's in data.c.
7118 (Fisnan): Always define, since it's always available now.
7119 (syms_of_floatfns): Always define isnan at the Lisp level.
7120
e39b275c 71212011-09-06 Paul Eggert <eggert@cs.ucla.edu>
1c262cae
PE
7122
7123 * Makefile.in (gl-stamp): move-if-change now in build-aux (Bug#9169).
7124
b2db44d9 71252011-09-06 Paul Eggert <eggert@cs.ucla.edu>
728f8f0a 7126
f4af5137 7127 * fileio.c: Fix bugs with large file offsets (Bug#9428).
728f8f0a
PE
7128 The previous code assumed that file offsets (off_t values) fit in
7129 EMACS_INT variables, which is not true on typical 32-bit hosts.
7130 The code messed up by falsely reporting buffer overflow in cases
7131 such as (insert-file-contents "big" nil 1 2) into an empty buffer
7132 when "big" contains more than 2**29 bytes, even though this
7133 inserts just one byte and does not overflow the buffer.
7134 (Finsert_file_contents): Store file offsets as off_t
7135 values, not as EMACS_INT values. Check for overflow when
7136 converting between EMACS_INT and off_t. When checking for
7137 buffer overflow or for overlap, take the offsets into account.
7138 Don't use EMACS_INT for small values where int suffices.
7139 When checking for overlap, fix a typo: ZV was used where
7140 ZV_BYTE was intended.
7141 (Fwrite_region): Don't assume off_t fits into 'long'.
7142 * buffer.h (struct buffer.modtime_size): Now off_t, not EMACS_INT.
7143
ecfc0a49
MA
71442011-09-05 Michael Albinus <michael.albinus@gmx.de>
7145
7146 * dbusbind.c (xd_signature_cat): Rename from signature_cat.
7147
6511acf2 71482011-09-04 Paul Eggert <eggert@cs.ucla.edu>
61bfeeb7 7149
0999621a 7150 sprintf-related integer and memory overflow issues (Bug#9412).
62f19c19
PE
7151
7152 * doprnt.c (doprnt): Support printing ptrdiff_t and intmax_t values.
8666506e 7153 (esprintf, exprintf, evxprintf): New functions.
62f19c19 7154 * keyboard.c (command_loop_level): Now EMACS_INT, not int.
6b02f655 7155 (cmd_error): Kbd macro iterations count is now EMACS_INT, not int.
62f19c19
PE
7156 (modify_event_symbol): Do not assume that the length of
7157 name_alist_or_stem is safe to alloca and fits in int.
7158 (Fexecute_extended_command): Likewise for function name and binding.
7159 (Frecursion_depth): Wrap around reliably on integer overflow.
7160 * keymap.c (push_key_description): First arg is now EMACS_INT, not int,
7161 since some callers pass EMACS_INT values.
7162 (Fsingle_key_description): Don't crash if symbol name contains more
7163 than MAX_ALLOCA bytes.
7164 * minibuf.c (minibuf_level): Now EMACS_INT, not int.
7165 (get_minibuffer): Arg is now EMACS_INT, not int.
7166 * lisp.h (get_minibuffer, push_key_description): Reflect API changes.
8666506e 7167 (esprintf, exprintf, evxprintf): New decls.
62f19c19
PE
7168 * window.h (command_loop_level, minibuf_level): Reflect API changes.
7169
2be7d702
PE
7170 * dbusbind.c (signature_cat): New function.
7171 (xd_signature, Fdbus_register_signal):
2ea16b89
PE
7172 Do not overrun buffer; instead, report string overflow.
7173
9d1df220
PE
7174 * dispnew.c (add_window_display_history): Don't overrun buffer.
7175 Truncate instead; this is OK since it's just a log.
7176
33ef5c64
PE
7177 * editfns.c (Fcurrent_time_zone): Don't overrun buffer
7178 even if the time zone offset is outlandishly large.
7179 Don't mishandle offset == INT_MIN.
7180
66c6fdd5
PE
7181 * emacs.c (main) [NS_IMPL_COCOA]: Don't overrun buffer
7182 when creating daemon; the previous buffer-overflow check was incorrect.
7183
d749b01b
PE
7184 * eval.c (verror): Simplify by rewriting in terms of evxprintf,
7185 which has the guts of the old verror function.
7186
b5cd1905
PE
7187 * filelock.c (lock_file_1, lock_file): Don't blindly alloca long name;
7188 use SAFE_ALLOCA instead. Use esprintf to avoid int-overflow issues.
7189
6e1a67fb
PE
7190 * font.c: Include <float.h>, for DBL_MAX_10_EXP.
7191 (font_unparse_xlfd): Don't blindly alloca long strings.
c21721cc 7192 Don't assume XINT result fits in int, or that XFLOAT_DATA * 10
8666506e 7193 fits in int, when using sprintf. Use single snprintf to count
c21721cc
PE
7194 length of string rather than counting it via multiple sprintfs;
7195 that's simpler and more reliable.
c21721cc
PE
7196 (font_unparse_fcname): Use it to avoid sprintf buffer overrun.
7197 (generate_otf_features) [0 && HAVE_LIBOTF]: Use esprintf, not
7198 sprintf, in case result does not fit in int.
7199
c57b67fc
PE
7200 * fontset.c (num_auto_fontsets): Now printmax_t, not int.
7201 (fontset_from_font): Print it.
7202
8a401434
PE
7203 * frame.c (tty_frame_count): Now printmax_t, not int.
7204 (make_terminal_frame, set_term_frame_name): Print it.
7205 (x_report_frame_params): In X, window IDs are unsigned long,
7206 not signed long, so print them as unsigned.
7207 (validate_x_resource_name): Check for implausibly long names,
7208 and don't assume name length fits in 'int'.
7209 (x_get_resource_string): Don't blindly alloca invocation name;
7210 use SAFE_ALLOCA. Use esprintf, not sprintf, in case result does
7211 not fit in int.
7212
6e1a67fb
PE
7213 * gtkutil.c: Include <float.h>, for DBL_MAX_10_EXP.
7214 (xg_check_special_colors, xg_set_geometry):
84722b3d
PE
7215 Make sprintf buffers a bit bigger, to avoid potential buffer overrun.
7216
0df02bf3
PE
7217 * lread.c (dir_warning): Don't blindly alloca buffer; use SAFE_ALLOCA.
7218 Use esprintf, not sprintf, in case result does not fit in int.
7219
48e30793
PE
7220 * macros.c (executing_kbd_macro_iterations): Now EMACS_INT, not int.
7221 (Fend_kbd_macro): Don't mishandle MOST_NEGATIVE_FIXNUM by treating
7222 it as a large positive number.
7223 (Fexecute_kbd_macro): Don't assume repeat count fits in int.
7224 * macros.h (executing_kbd_macro_iterations): Now EMACS_INT, not int.
7225
a66ff6d8
PE
7226 * nsterm.m ((NSSize)windowWillResize): Use esprintf, not sprintf,
7227 in case result does not fit in int.
7228
aca216ff
PE
7229 * print.c (float_to_string): Detect width overflow more reliably.
7230 (print_object): Make sprintf buffer a bit bigger, to avoid potential
7231 buffer overrun. Don't assume list length fits in 'int'. Treat
7232 print length of 0 as 0, not as infinity; to be consistent with other
7233 uses of print length in this function. Don't overflow print length
7234 index. Don't assume hash table size fits in 'long', or that
7235 vectorlike size fits in 'unsigned long'.
7236
31c286f7
PE
7237 * process.c (make_process): Use printmax_t, not int, to format
7238 process-name gensyms.
7239
55e5faa1
PE
7240 * sysdep.c (snprintf) [! HAVE_SNPRINTF]: New function.
7241
80f2e268
PE
7242 * term.c (produce_glyphless_glyph): Make sprintf buffer a bit bigger
7243 to avoid potential buffer overrun.
7244
670741ab
PE
7245 * xfaces.c (x_update_menu_appearance): Don't overrun buffer
7246 if X resource line is longer than 512 bytes.
7247
b7163a50
PE
7248 * xfns.c (x_window): Make sprintf buffer a bit bigger
7249 to avoid potential buffer overrun.
7250
ae58ff1f
PE
7251 * xterm.c (x_io_error_quitter): Don't overrun sprintf buffer.
7252
c43c8a6a
PE
7253 * xterm.h (x_check_errors): Add ATTRIBUTE_FORMAT_PRINTF.
7254
3f8236f4
PE
72552011-09-04 Paul Eggert <eggert@cs.ucla.edu>
7256
53e9fe90 7257 Integer overflow fixes for scrolling, etc.
6511acf2
PE
7258 Without these, Emacs silently mishandles large integers sometimes.
7259 For example, "C-u 4294967297 M-x recenter" was treated as if
53e9fe90
PE
7260 it were "C-u 1 M-x recenter" on a typical 64-bit host.
7261
6511acf2
PE
7262 * xdisp.c (try_window_id): Check Emacs fixnum range before
7263 converting to 'int'.
806add1d 7264
6511acf2 7265 * window.c (window_scroll_line_based, Frecenter):
71f02bc5
PE
7266 Check that an Emacs fixnum is in range before assigning it to 'int'.
7267 (Frecenter, Fmove_to_window_line): Use EMACS_INT, not int, for
7268 values converted from Emacs fixnums.
7269 (Frecenter): Don't wrap around a line count if it is out of 'int'
7270 range; instead, treat it as an extreme value.
7271 (Fset_window_configuration, compare_window_configurations):
7272 Use ptrdiff_t, not int, for index that might exceed 2 GiB.
7273
6511acf2
PE
7274 * search.c (Freplace_match): Use ptrdiff_t, not int, for indexes
7275 that can exceed INT_MAX. Check that EMACS_INT value is in range
7276 before assigning it to the (possibly-narrower) index.
a0efffc8
PE
7277 (match_limit): Don't assume that a fixnum can fit in 'int'.
7278
6511acf2 7279 * print.c (print_object): Use ptrdiff_t, not int, for index that can
29ebea3b
PE
7280 exceed INT_MAX.
7281
6511acf2 7282 * indent.c (position_indentation): Now takes ptrdiff_t, not int.
3f8236f4
PE
7283 (Fvertical_motion): Don't wrap around LINES values that don't fit
7284 in 'int'. Instead, treat them as extreme values. This is good
7285 enough for windows, which can't have more than INT_MAX lines anyway.
7286
fcb901a7
LMI
72872011-09-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
7288
0f2f6b6d
LMI
7289 * Require libxml/parser.h to avoid compilation warning.
7290
fcb901a7
LMI
7291 * emacs.c (shut_down_emacs): Call xmlCleanupParser on shutdown.
7292
7293 * xml.c (parse_region): Don't call xmlCleanupParser after parsing,
7294 since this reportedly can destroy thread storage.
7295
6e20a0d4
CY
72962011-08-30 Chong Yidong <cyd@stupidchicken.com>
7297
7298 * syntax.c (find_defun_start): Update all cache variables if
7299 exiting early (Bug#9401).
7300
148ae00e
EZ
73012011-08-30 Eli Zaretskii <eliz@gnu.org>
7302
f6cfbd8f
EZ
7303 * image.c (x_bitmap_pixmap): Cast to int to avoid compiler warnings.
7304
148ae00e
EZ
7305 * xdisp.c (produce_stretch_glyph): No longer static, compiled also
7306 when HAVE_WINDOW_SYSTEM is not defined. Support both GUI and TTY
7307 frames. Call tty_append_glyph in the TTY case. (Bug#9402)
7308
7309 * term.c (tty_append_glyph): New function.
7310 (produce_stretch_glyph): Static function and its prototype deleted.
7311
a66cfb1c
SM
7312 * dispextern.h (produce_stretch_glyph, tty_append_glyph):
7313 Add prototypes.
148ae00e 7314
c4a07a4c
PE
73152011-08-29 Paul Eggert <eggert@cs.ucla.edu>
7316
7317 * image.c (parse_image_spec): Check for nonnegative, not for positive,
7318 when checking :margin (Bug#9390).
7319 (IMAGE_NON_NEGATIVE_INTEGER_VALUE_OR_PAIR):
a66cfb1c 7320 Rename from IMAGE_POSITIVE_INTEGER_VALUE_OR_PAIR,
c4a07a4c
PE
7321 so that the name doesn't mislead. All uses changed.
7322
6bc8cd65
JB
73232011-08-28 Johan Bockgård <bojohan@gnu.org>
7324
7325 * term.c (init_tty) [HAVE_GPM]: Move mouse settings after
7326 set_tty_hooks.
7327
dca4927e
EZ
73282011-08-27 Eli Zaretskii <eliz@gnu.org>
7329
7330 * xdisp.c (move_it_to): Don't bail out early when reaching
7331 position beyond to_charpos, if we are scanning backwards.
7332 (move_it_vertically_backward): When DY == 0, make sure we get to
7333 the first character in the line after the newline.
7334
f2cad773
PE
73352011-08-27 Paul Eggert <eggert@cs.ucla.edu>
7336
7337 * ccl.c: Improve and simplify overflow checking (Bug#9196).
7338 (ccl_driver): Do not generate an out-of-range pointer.
7339 (Fccl_execute_on_string): Remove unnecessary check for
7340 integer overflow, noted by Stefan Monnier in
7341 <http://lists.gnu.org/archive/html/emacs-devel/2011-08/msg00979.html>.
7342 Remove a FIXME that didn't need fixing.
7343 Simplify the newly-introduced buffer reallocation code.
7344
0cae2cdb
JB
73452011-08-27 Juanma Barranquero <lekktu@gmail.com>
7346
7347 * makefile.w32-in ($(BLD)/alloc.$(O)): Depend on lib/verify.h.
7348
5fc295a4 73492011-08-26 Paul Eggert <eggert@cs.ucla.edu>
ddff3151 7350
70c60eb2 7351 Integer and memory overflow issues (Bug#9196).
726e0ab1 7352
d31850da
PE
7353 * doc.c (get_doc_string): Rework so that
7354 get_doc_string_buffer_size is the actual buffer size, rather than
7355 being 1 less than the actual buffer size; this makes xpalloc more
7356 convenient.
7357
a69fbedb
PE
7358 * image.c (x_allocate_bitmap_record, cache_image):
7359 * xselect.c (Fx_register_dnd_atom):
7360 Simplify previous changes by using xpalloc.
7361
fe5c5d37
PE
7362 * buffer.c (overlay_str_len): Now ptrdiff_t, not EMACS_INT,
7363 since either will do and ptrdiff_t is convenient with xpalloc.
7364
0065d054
PE
7365 * charset.c (charset_table_size)
7366 (struct charset_sort_data.priority): Now ptrdiff_t.
7367 (charset_compare): Don't overflow if priorities differ greatly.
7368 (Fsort_charsets): Don't assume list length fits in int.
7369 Check for size-calculation overflow when allocating sort data.
7370 (syms_of_charset): Allocate an initial charset table that is
7371 just under 64 KiB, to avoid problems with glibc malloc and mmap.
7372
7373 * cmds.c (internal_self_insert): Check for size-calculation overflow.
7374
7375 * composite.h (struct composition.glyph_len): Now int, not unsigned.
7376 The actual value is always <= INT_MAX, and leaving it unsigned made
7377 overflow checking harder.
7378
7379 * dispextern.h (struct glyph_matrix.rows_allocated)
7380 (struct face_cache.size): Now ptrdiff_t, for convenience in use
7381 with xpalloc. The values are still always <= INT_MAX.
7382
7383 * indent.c (compute_motion): Adjust to region_cache_forward sig change.
7384
7385 * lisp.h (xnmalloc, xnrealloc, xpalloc): New decls.
7386 (SAFE_NALLOCA): New macro.
7387
7388 * region-cache.c (struct boundary.pos, find_cache_boundary)
7389 (move_cache_gap, insert_cache_boundary, delete_cache_boundaries)
7390 (set_cache_region, invalidate_region_cache)
7391 (revalidate_region_cache, know_region_cache, region_cache_forward)
7392 (region_cache_backward, pp_cache):
7393 Use ptrdiff_t, not EMACS_INT, since either will do. This is needed
7394 so that ptrdiff_t * can be passed to xpalloc.
7395 (struct region_cache): Similarly, for gap_start, gap_len, cache_len,
7396 beg_unchanged, end_unchanged, buffer_beg, buffer_end members.
7397 (pp_cache): Don't assume cache_len fits in int.
7398 * region-cache.h: Adjust extern decls to match.
7399
7400 * search.c (scan_buffer, Freplace_match): Use ptrdiff_t, not
7401 EMACS_INT, since either will do, for xpalloc.
7402
7403 * alloc.c: Include verify.h, and check that int fits in ptrdiff_t.
7404 (xnmalloc, xnrealloc, xpalloc): New functions.
7405
726e0ab1
PE
7406 * bidi.c (bidi_shelve_header_size): New constant.
7407 (bidi_cache_ensure_space, bidi_shelve_cache): Use it.
7408 (bidi_cache_ensure_space): Avoid integer overflow when allocating.
7409
51f30bc5 7410 * bidi.c (bidi_cache_shrink):
726e0ab1
PE
7411 * buffer.c (overlays_at, overlays_in, record_overlay_string)
7412 (overlay_strings):
7413 Don't update size of array until after memory allocation succeeds,
7414 because xmalloc/xrealloc may not return.
0065d054
PE
7415 (struct sortstrlist.bytes): Now ptrdiff_t, as EMACS_INT doesn't help
7416 now that we have proper integer overflow checking.
7417 (record_overlay_string, overlay_strings): Catch overflows when
7418 calculating size of overlay_str_buf.
726e0ab1 7419
0065d054
PE
7420 * callproc.c (Fcall_process): Check for size overflow when
7421 calculating size of args2.
7422 (child_setup): Avoid overflow by using size_t rather than ptrdiff_t.
7423 Normally we prefer signed values, but sticking with ptrdiff_t would
7424 require adding more-complicated checks.
726e0ab1
PE
7425
7426 * ccl.c (Fccl_execute_on_string): Check for memory overflow.
7427 Use ptrdiff_t rather than EMACS_INT where ptrdiff_t will do.
7428 Redo buffer-overflow calculations to avoid integer overflow.
0065d054 7429 Add a FIXME comment where memory seems to be over-allocated.
726e0ab1
PE
7430
7431 * character.c (Fstring): Check for size-calculation overflow.
7432
7433 * coding.c (produce_chars): Redo buffer-overflow calculations to avoid
7434 unnecessary integer overflow. Check for size overflow.
7435 (encode_coding_object): Don't update size until xmalloc succeeds.
7436
7437 * composite.c (get_composition_id): Check for overflow in glyph
7438 length calculations.
7439
7440 Integer and memory overflow fixes for display code.
7441 * dispextern.h (struct glyph_pool.nglyphs): Now ptrdiff_t, not int.
7442 * dispnew.c (adjust_glyph_matrix, realloc_glyph_pool)
7443 (scrolling_window): Check for overflow in size calculations.
7444 (line_draw_cost, realloc_glyph_pool, add_row_entry):
7445 Don't assume glyph table len fits in int.
7446 (struct row_entry.bucket, row_entry_pool_size, row_entry_idx)
7447 (row_table_size): Now ptrdiff_t, not int.
7448 (scrolling_window): Avoid overflow in size calculations.
7449 Don't update size until allocation succeeds.
7450 * fns.c (concat): Check for overflow in size calculations.
7451 (next_almost_prime): Verify NEXT_ALMOST_PRIME_LIMIT.
7452 * lisp.h (RANGED_INTEGERP, TYPE_RANGED_INTEGERP): New macros.
7453 (NEXT_ALMOST_PRIME_LIMIT): New constant.
7454
7455 * doc.c (get_doc_string_buffer_size): Now ptrdiff_t, not int.
7456 (get_doc_string): Check for size calculation overflow.
7457 Don't update size until allocation succeeds.
7458 (get_doc_string, Fsubstitute_command_keys): Use ptrdiff_t, not
7459 EMACS_INT, where ptrdiff_t will do.
7460 (Fsubstitute_command_keys): Check for string overflow.
7461
7462 * editfns.c (set_time_zone_rule): Don't assume environment length
7463 fits in int.
7464 (message_length): Now ptrdiff_t, not int.
7465 (Fmessage_box): Don't update size until allocation succeeds.
7466 Don't assume message length fits in int.
7467 (Fformat): Use ptrdiff_t, not EMACS_INT, where ptrdiff_t will do.
7468
0065d054
PE
7469 * emacs.c (main): Do not reallocate argv, since there is a null at
7470 the end that can be overwritten, and this way there's no need to
7471 worry about size-calculation overflow.
7472 (sort_args): Check for size-calculation overflow.
726e0ab1
PE
7473
7474 * eval.c (init_eval_once, grow_specpdl): Don't update size until
7475 alloc succeeds.
7476 (call_debugger, grow_specpdl): Redo calculations to avoid overflow.
7477
7478 * frame.c (set_menu_bar_lines, x_set_frame_parameters)
7479 (x_set_scroll_bar_width, x_figure_window_size):
7480 Check for integer overflow.
7481 (x_set_alpha): Do not assume XINT fits in int.
7482
7483 * frame.h (struct frame): Use int, not EMACS_INT, where int works.
7484 This is for the members text_lines, text_cols, total_lines, total_cols,
7485 where the system imposes an 'int' limit.
7486
7487 * fringe.c (Fdefine_fringe_bitmap):
7488 Don't update size until alloc works.
7489
7490 * ftfont.c (ftfont_get_open_type_spec, setup_otf_gstring)
7491 (ftfont_shape_by_flt): Check for integer overflow in size calculations.
7492
7493 * gtkutil.c (get_utf8_string, xg_store_widget_in_map):
7494 Check for size-calculation overflow.
7495 (get_utf8_string): Use ptrdiff_t, not size_t, where either will
7496 do, as we prefer signed integers.
7497 (id_to_widget.max_size, id_to_widget.used)
7498 (xg_store_widget_in_map, xg_remove_widget_from_map)
7499 (xg_get_widget_from_map, xg_get_scroll_id_for_window)
7500 (xg_remove_scroll_bar, xg_update_scrollbar_pos):
7501 Use and return ptrdiff_t, not int.
7502 (xg_gtk_scroll_destroy): Don't assume ptrdiff_t fits in int.
7503 * gtkutil.h: Change prototypes to match the above.
7504
7505 * image.c (RANGED_INTEGERP, TYPE_RANGED_INTEGERP): Remove; these
7506 are duplicate now that they've been promoted to lisp.h.
7507 (x_allocate_bitmap_record, x_alloc_image_color)
7508 (make_image_cache, cache_image, xpm_load):
7509 Don't update size until alloc is done.
7510 (xpm_load, lookup_rgb_color, lookup_pixel_color, x_to_xcolors)
7511 (x_detect_edges):
3256efce 7512 Check for size calculation overflow.
726e0ab1
PE
7513 (ct_colors_allocated_max): New constant.
7514 (x_to_xcolors, x_detect_edges): Reorder multiplicands to avoid
7515 overflow.
3256efce 7516
726e0ab1
PE
7517 * keyboard.c (read_char, menu_bar_items, tool_bar_items)
7518 (read_char_x_menu_prompt, read_char_minibuf_menu_width)
7519 (read_char_minibuf_menu_prompt, follow_key, read_key_sequence):
7520 Use ptrdiff_t, not int, to count maps.
7521 (read_char_minibuf_menu_prompt): Check for overflow in size
a66cfb1c
SM
7522 calculations. Don't update size until allocation succeeds.
7523 Redo calculations to avoid overflow.
726e0ab1
PE
7524 * keyboard.h: Change prototypes to match the above.
7525
7526 * keymap.c (cmm_size, current_minor_maps): Use ptrdiff_t, not int,
7527 to count maps.
7528 (current_minor_maps): Check for size calculation overflow.
7529 * keymap.h: Change prototypes to match the above.
7530
7531 * lread.c (read1, init_obarray): Don't update size until alloc done.
7532
7533 * macros.c (Fstart_kbd_macro): Don't update size until alloc done.
7534 (store_kbd_macro_char): Reorder multiplicands to avoid overflow.
7535
726e0ab1
PE
7536 * nsterm.h (struct ns_color_table.size, struct ns_color_table.avail):
7537 Now ptrdiff_t, not int.
7538 * nsterm.m (ns_index_color): Use ptrdiff_t, not int, for table indexes.
7539 (ns_draw_fringe_bitmap): Rewrite to avoid overflow.
7540
7541 * process.c (Fnetwork_interface_list): Check for overflow
7542 in size calculation.
7543
7544 * region-cache.c (move_cache_gap): Check for size calculation overflow.
7545
7546 * scroll.c (do_line_insertion_deletion_costs): Check for size calc
7547 overflow. Don't bother calling xmalloc when xrealloc will do.
7548
7549 * search.c (Freplace_match): Check for size calculation overflow.
7550 (Fset_match_data): Don't assume list lengths fit in 'int'.
7551
7552 * sysdep.c (system_process_attributes): Use ptrdiff_t, not int,
7553 for command line length. Do not attempt to address one before the
7554 beginning of an array, as that's not portable.
7555
7556 * term.c (max_frame_lines): Remove; unused.
7557 (encode_terminal_src_size, encode_terminal_dst_size): Now ptrdiff_t,
7558 not int.
7559 (encode_terminal_code, calculate_costs): Check for size
7560 calculation overflow.
7561 (encode_terminal_code): Use ptrdiff_t, not int, to record glyph
7562 table lengths and related sizes. Don't update size until alloc
7563 done. Redo calculations to avoid overflow.
7564 (calculate_costs): Don't bother calling xmalloc when xrealloc will do.
7565
7566 * termcap.c (tgetent): Use ptrdiff_t, not int, to record results of
7567 subtracting pointers.
7568 (gobble_line): Check for overflow more carefully. Don't update size
7569 until alloc done.
7570
7571 * tparam.c (tparam1): Use ptrdiff_t, not int, for sizes.
7572 Don't update size until alloc done.
7573 Redo size calculations to avoid overflow.
7574 Check for size calculation overflow.
0065d054 7575 (main) [DEBUG]: Fix typo in invoking tparam1.
726e0ab1
PE
7576
7577 * xdisp.c (store_mode_line_noprop_char, x_consider_frame_title):
7578 Use ptrdiff_t, not int, for sizes.
7579 (store_mode_line_noprop_char): Don't update size until alloc done.
7580
0065d054
PE
7581 * xfaces.c (lface_id_to_name_size, Finternal_make_lisp_face):
7582 Use ptrdiff_t, not int, for sizes.
7583 (Finternal_make_lisp_face, cache_face):
7584 Check for size calculation overflow.
7585 (cache_face): Treat size calculation overflows as if they were
7586 memory exhaustion (the usual treatment), rather than aborting.
726e0ab1
PE
7587
7588 * xfns.c (x_encode_text, x_set_name_internal)
7589 (Fx_change_window_property): Use ptrdiff_t, not int, to count
7590 sizes, since they can exceed INT_MAX in size. Check for size
7591 calculation overflow.
7592
0065d054
PE
7593 * xgselect.c (gfds_size): Now ptrdiff_t, for convenience with xpalloc.
7594 (xg_select): Check for size calculation overflow.
726e0ab1
PE
7595 Don't update size until alloc done.
7596
0065d054 7597 * xrdb.c (get_environ_db): Don't assume path length fits in int,
726e0ab1 7598 as sprintf is limited to int lengths.
1d526e2f 7599
252c5ee1
PE
7600 * xselect.c (X_LONG_SIZE, X_SHRT_MAX, X_SHRT_MIN, X_LONG_MAX)
7601 (X_LONG_MIN): New macros.
864d7ce7
PE
7602 Use them to make the following changes clearer.
7603 (MAX_SELECTION_QUANTUM): Make the other bounds on this value clearer.
7604 This change doesn't affect the value now, but it may help remind
7605 future maintainers not to raise the value too much later.
7606 (SELECTION_QUANTUM): Remove, replacing with ...
7607 (selection_quantum): ... new function, which avoids overflow.
7608 All uses changed.
7609 (struct selection_data.size): Now ptrdiff_t, not int, to avoid
7610 assumption that selection length fits in 'int'.
7611 (x_reply_selection_request, x_handle_selection_request)
7612 (x_get_window_property, receive_incremental_selection)
7613 (x_get_window_property_as_lisp_data, selection_data_to_lisp_data)
7614 (lisp_data_to_selection_data, clean_local_selection_data):
7615 Use ptrdiff_t, not int, to record length of selection.
7616 (x_reply_selection_request, x_get_window_property)
7617 (receive_incremental_selection, x_property_data_to_lisp):
7618 Redo calculations to avoid overflow.
7619 (x_reply_selection_request): When sending hint, ceiling it at
252c5ee1 7620 X_LONG_MAX rather than relying on wraparound overflow to send
864d7ce7
PE
7621 something.
7622 (x_get_window_property, receive_incremental_selection)
7623 (lisp_data_to_selection_data, x_property_data_to_lisp):
7624 Check for size-calculation overflow.
7625 (x_get_window_property, receive_incremental_selection)
7626 (lisp_data_to_selection_data, Fx_register_dnd_atom):
7627 Don't store size until memory allocation succeeds.
7628 (x_get_window_property): Plug memory leak on memory exhaustion.
7629 Don't double-block input; malloc is safe here. Don't assume 2**34
7630 - 4 fits in unsigned long. Add an xassert to check
7631 XGetWindowProperty overflow. Be more careful about overflow
7632 calculations, and distinguish size from memory overflow better.
7633 (receive_incremental_selection): When tracing, don't assume
7634 unsigned int is less than INT_MAX.
7635 (x_selection_data_to_lisp_data): Remove unnecessary (and in theory
7636 harmful) conversions of unsigned short to int.
7637 (lisp_data_to_selection_data): Don't assume that integers
7638 in the range -65535 through -1 fit in an X unsigned short.
7639 Don't assume that ULONG_MAX == X_ULONG_MAX. Don't store into
7640 result parameters unless successful. Rely on cons_to_unsigned
7641 to report problems with elements; the old code wasn't right anyway.
7642 (x_check_property_data): Check for int overflow; we cannot use
7643 a wider type due to X limits.
7644 (x_handle_dnd_message): Use unsigned int, to avoid int overflow.
7645
726e0ab1 7646 * xsmfns.c (smc_save_yourself_CB): Check for size calc overflow.
34db673b 7647
0065d054
PE
7648 * xterm.c (x_color_cells, x_send_scrollbar_event, handle_one_xevent)
7649 (x_term_init): Check for size calculation overflow.
726e0ab1
PE
7650 (x_color_cells): Don't store size until memory allocation succeeds.
7651 (handle_one_xevent): Use ptrdiff_t, not int, for byte counts.
0065d054 7652 Don't assume alloca size is less than MAX_ALLOCA.
726e0ab1
PE
7653 (x_term_init): Don't assume length fits in int (sprintf is limited
7654 to int size).
bc18e09d 7655
ebfa62c0
PE
7656 Use ptrdiff_t for composition IDs.
7657 * character.c (lisp_string_width):
7658 * composite.c (composition_table_size, n_compositions)
7659 (get_composition_id, composition_gstring_from_id):
7660 * dispextern.h (struct glyph_string.cmp_id, struct composition_it.id):
7661 * xdisp.c (BUILD_COMPOSITE_GLYPH_STRING):
7662 * window.c (Frecenter):
7663 Use ptrdiff_t, not int, for composition IDs.
7664 * composite.c (get_composition_id): Check for integer overflow.
7665 * composite.h: Adjust prototypes to match the above changes.
7666
d3411f89
PE
7667 Use ptrdiff_t for hash table indexes.
7668 * category.c (hash_get_category_set):
7669 * ccl.c (ccl_driver):
7670 * charset.h (struct charset.hash_index, CHECK_CHARSET_GET_ID):
7671 * coding.c (coding_system_charset_list, detect_coding_system):
7672 * coding.h (struct coding_system.id):
7673 * composite.c (get_composition_id, gstring_lookup_cache):
7674 * fns.c (hash_lookup, hash_put, Fgethash, Fputhash):
7675 * image.c (xpm_get_color_table_h):
7676 * lisp.h (hash_lookup, hash_put):
7677 * minibuf.c (Ftest_completion):
7678 Use ptrdiff_t for hash table indexes, not int (which is too
7679 narrow, on 64-bit hosts) or EMACS_INT (which is too wide, on
7680 32-bit --with-wide-int hosts).
7681
e097a6fa
PE
7682 * charset.c (Fdefine_charset_internal): Check for integer overflow.
7683 Add a FIXME comment about memory leaks.
7684 (syms_of_charset): Don't assume xmalloc returns.
7685
5637687f
PE
7686 Don't assume that stated character widths fit in int.
7687 * character.c (Fchar_width, c_string_width, lisp_string_width):
7688 * character.h (CHAR_WIDTH):
7689 * indent.c (MULTIBYTE_BYTES_WIDTH):
7690 Use sanitize_char_width to avoid undefined and/or bad behavior
7691 with outlandish widths.
a66cfb1c 7692 * character.h (sanitize_tab_width): Rename from sanitize_width,
5637687f
PE
7693 now that we have two such functions. All uses changed.
7694 (sanitize_char_width): New inline function.
7695
a2271ba2
PE
7696 Don't assume that tab-width fits in int.
7697 * character.h (sanitize_width): New inline function.
7698 (SANE_TAB_WIDTH): New macro.
7699 (ASCII_CHAR_WIDTH): Use it.
7700 * indent.c (sane_tab_width): Remove. All uses replaced by
7701 SANE_TAB_WIDTH (current_buffer).
7702 * xdisp.c (init_iterator): Use SANE_TAB_WIDTH.
7703
18c52557
PE
7704 * fileio.c: Integer overflow issues with file modes.
7705 (Fset_file_modes, auto_save_1): Don't assume EMACS_INT fits in int.
7706
caeeedc1
PE
7707 * charset.c (read_hex): New arg OVERFLOW. All uses changed.
7708 Remove unreachable code.
7709 (read_hex, load_charset_map_from_file): Check for integer overflow.
7710
6df6ae42 7711 * xterm.c: Don't go over XClientMessageEvent limit.
50849c52
PE
7712 (scroll_bar_windows_size): Now ptrdiff_t, as we prefer signed.
7713 (x_send_scroll_bar_event): Likewise. Check that the size does not
7714 exceed limits imposed by XClientMessageEvent, as well as the usual
7715 ptrdiff_t and size_t limits.
7716
b13995db
PE
7717 * keyboard.c: Overflow, signedness and related fixes.
7718 (make_lispy_movement): Use same integer type in forward decl
7719 that is used in the definition.
7720 (read_key_sequence, keyremap_step):
7721 Change bufsize argument back to int, undoing my 2011-03-30 change.
7722 We prefer signed types, and int is wide enough here.
7723 (parse_tool_bar_item): Don't assume tool_bar_max_label_size is less
7724 than TYPE_MAXIMUM (EMACS_INT) / 2. Don't let the label size grow
7725 larger than STRING_BYTES_BOUND. Use ptrdiff_t for Emacs string
7726 length, not size_t. Use ptrdiff_t for index, not int.
7727 (keyremap_step, read_key_sequence): Redo bufsize check to avoid
7728 possibility of integer overflow.
7729
13464394
PE
7730 Overflow, signedness and related fixes for images.
7731
7732 * dispextern.h (struct it.stack[0].u.image.image_id)
7733 (struct_it.image_id, struct image.id, struct image_cache.size)
7734 (struct image_cache.used, struct image_cache.ref_count):
7735 * gtkutil.c (update_frame_tool_bar):
7736 * image.c (x_reference_bitmap, Fimage_size, Fimage_mask_p)
7737 (Fimage_metadata, free_image_cache, clear_image_cache, lookup_image)
7738 (cache_image, mark_image_cache, x_kill_gs_process, Flookup_image):
7739 * nsmenu.m (update_frame_tool_bar):
7740 * xdisp.c (calc_pixel_width_or_height):
7741 * xfns.c (image_cache_refcount):
7742 Image IDs are now ptrdiff_t, not int, to avoid arbitrary limits
7743 on typical 64-bit hosts.
7744
7745 * image.c (RANGED_INTEGERP, TYPE_RANGED_INTEGERP): New macros.
7746 (x_bitmap_pixmap, x_create_x_image_and_pixmap):
7747 Omit unnecessary casts to int.
7748 (parse_image_spec): Check that integers fall into 'int' range
7749 when the callers expect that.
7750 (image_ascent): Redo ascent calculation to avoid int overflow.
7751 (clear_image_cache): Avoid overflow when sqrt (INT_MAX) < nimages.
7752 (lookup_image): Remove unnecessary tests.
7753 (xbm_image_p): Locals are now of int, not EMACS_INT,
7754 since parse_image_check makes sure they fit into int.
7755 (png_load, gif_load, svg_load_image):
7756 Prefer int to unsigned where either will do.
7757 (tiff_handler): New function, combining the cores of the
a66cfb1c
SM
7758 old tiff_error_handler and tiff_warning_handler.
7759 This function is rewritten to use vsnprintf and thereby avoid
13464394
PE
7760 stack buffer overflows. It uses only the features of vsnprintf
7761 that are common to both POSIX and native Microsoft.
7762 (tiff_error_handler, tiff_warning_handler): Use it.
7763 (tiff_load, gif_load, imagemagick_load_image):
7764 Don't assume :index value fits in 'int'.
7765 (gif_load): Omit unnecessary cast to double, and avoid double-rounding.
7766 (imagemagick_load_image): Check that crop parameters fit into
7767 the integer types that MagickCropImage accepts. Don't assume
7768 Vimagemagick_render_type has a nonnegative value. Don't assume
7769 size_t fits in 'long'.
7770 (gs_load): Use printmax_t to print the widest integers possible.
7771 Check for integer overflow when computing image height and width.
7772
c11821d4
EZ
77732011-08-26 Eli Zaretskii <eliz@gnu.org>
7774
7775 * xdisp.c (redisplay_window): Don't force window start if point
7776 will be invisible in the resulting window. (Bug#9324)
7777
0c95fcf7
EZ
77782011-08-25 Eli Zaretskii <eliz@gnu.org>
7779
7780 * xdisp.c (compute_display_string_pos): Return 2 in DISP_PROP when
7781 the display spec is of the form `(space ...)'.
7782 (handle_display_spec): Return the value returned by
7783 handle_single_display_spec, not just 1 or zero.
7784 (handle_single_display_spec): If the display spec is of the form
7785 `(space ...)', and specifies display in the text area, return 2
7786 rather than 1.
fee65a97 7787 (try_cursor_movement): Check for the need to scroll more
a66cfb1c
SM
7788 accurately, and prefer exact match for point under bidi.
7789 Don't advance `row' beyond the last row of the window.
0c95fcf7
EZ
7790
7791 * dispextern.h (struct bidi_it): Rename the disp_prop_p member
7792 into disp_prop; all users changed.
7793
7794 * bidi.c (bidi_fetch_char): If compute_display_string_pos returns
7795 DISP_PROP = 2, substitute the u+2029 PARAGRAPH SEPARATOR character
7796 for the text covered by the display property.
7797
e4ed06f1
CY
77982011-08-25 Chong Yidong <cyd@stupidchicken.com>
7799
7800 * buffer.c (Fbury_buffer_internal): Rename from Funrecord_buffer.
7801 Change return value to nil.
7802 (Frecord_buffer): Delete unused function.
7803
f67cdd7f
EZ
78042011-08-24 Eli Zaretskii <eliz@gnu.org>
7805
5980d4c6
EZ
7806 * xdisp.c (Fcurrent_bidi_paragraph_direction): For unibyte
7807 buffers, return left-to-right.
8610fe8b
EZ
7808 (set_cursor_from_row): Consider candidate row a win if its glyph
7809 represents a newline and point is on that newline. Fixes cursor
7810 positioning on the newline at EOL of R2L text within L2R
7811 paragraph, and vice versa.
7812 (try_cursor_movement): Check continued rows, in addition to
7813 continuation rows. Fixes unwarranted scroll when point enters a
7814 continued line of R2L text within an L2R paragraph, or vice versa.
7815 (cursor_row_p): Consider the case of point being equal to
7816 MATRIX_ROW_END_CHARPOS. Prevents cursor being stuck when moving
7817 from the end of a short line to the beginning of a continued line
7818 of R2L text within L2R paragraph.
7819 (RECORD_MAX_MIN_POS): For max_pos, use IT_CHARPOS even for
7820 composed characters.
5980d4c6 7821
f67cdd7f
EZ
7822 * bidi.c (bidi_check_type): Use xassert.
7823 (bidi_cache_iterator_state): Update the disp_pos and disp_prop_p
7824 members.
7825
bca633fb
EZ
78262011-08-23 Eli Zaretskii <eliz@gnu.org>
7827
7828 * bidi.c (bidi_get_type): Abort if we get zero as the bidi type of
7829 a character.
7830
4a5885a7
CY
78312011-08-23 Chong Yidong <cyd@stupidchicken.com>
7832
7833 * nsfont.m (ns_otf_to_script): Fix typo.
7834
0902a04e
KH
78352011-08-22 Kenichi Handa <handa@m17n.org>
7836
7837 * chartab.c (Fset_char_table_extra_slot): Do not inhibit setting a
7838 extra slot even if the purpose is char-code-property-table.
7839
1a2e6670
EZ
78402011-08-23 Eli Zaretskii <eliz@gnu.org>
7841
8ddde651
EZ
7842 * xdisp.c (redisplay_window): When computing centering_position,
7843 account for the height of the header line. (Bug#8874)
7844
425cc014
EZ
7845 * dispnew.c (buffer_posn_from_coords): Use buf_charpos_to_bytepos
7846 instead of CHAR_TO_BYTE. Fixes a crash when a completion
7847 candidate is selected by the mouse, and that candidate has a
7848 composed character under the mouse.
7849
1a2e6670
EZ
7850 * xdisp.c (x_produce_glyphs): Set it->nglyphs to 1. Fixes pixel
7851 coordinates reported by pos-visible-in-window-p for a composed
7852 character in column zero.
7853
8b76d6f8
SM
78542011-08-23 Stefan Monnier <monnier@iro.umontreal.ca>
7855
7856 * cmds.c (Fself_insert_command): Mention post-self-insert-hook.
7857
dac347dd
EZ
78582011-08-22 Eli Zaretskii <eliz@gnu.org>
7859
7860 * xdisp.c (BUFFER_POS_REACHED_P): If this is a composition,
7861 consider it a hit if to_charpos is anywhere in the range of the
7862 composed buffer positions.
7863
e013fb34
CY
78642011-08-22 Chong Yidong <cyd@stupidchicken.com>
7865
7866 * image.c (gif_load): Don't assume that each subimage has the same
7867 dimensions as the base image. Handle disposal method that is
7868 "undefined" by the gif spec (Bug#9335).
7869
bd1ba3e8
CY
78702011-08-20 Chong Yidong <cyd@stupidchicken.com>
7871
7872 * eval.c (Fsignal): Handle `debug' symbol in error handler (Bug#9329).
024a2d76 7873 (Fcondition_case): Document `debug' symbol in error handler.
bd1ba3e8 7874
54a1215b
EZ
78752011-08-19 Eli Zaretskii <eliz@gnu.org>
7876
823564e5
EZ
7877 * xfaces.c (face_at_buffer_position): Avoid repeated evaluation of
7878 face ID by FACE_FROM_ID, and avoid a crash when mouse is moved
7879 from an Org mode buffer to a Speedbar frame.
7880
54a1215b
EZ
7881 * xdisp.c (RECORD_MAX_MIN_POS): If the display element comes from
7882 a composition, take its buffer position from IT->cmp_it.charpos.
7883 Fixes cursor positioning at the beginning of a line that begins
7884 with a composed character.
7885
9778ebcc
EZ
78862011-08-18 Eli Zaretskii <eliz@gnu.org>
7887
0be6ee06
EZ
7888 * bidi.c (bidi_get_type): If bidi_type_table reports zero as the
7889 character bidirectional type, use STRONG_L instead. Fixes crashes
7890 in a buffer produced by `describe-categories'.
7891
9778ebcc
EZ
7892 * dispextern.h (struct bidi_it): Move disp_pos and disp_prop_p
7893 members before the level stack, so they would be saved and
7894 restored when copying iterator state. Fixes incorrect reordering
7895 around TABs covered by display properties.
7896
156bffbe
AS
78972011-08-18 Andreas Schwab <schwab@linux-m68k.org>
7898
6b02f655 7899 * process.c (Fnetwork_interface_list): Correctly determine buffer size.
156bffbe 7900
72ad093b
CY
79012011-08-17 Chong Yidong <cyd@stupidchicken.com>
7902
7903 * eval.c (internal_condition_case, internal_condition_case_1)
8b76d6f8
SM
7904 (internal_condition_case_2, internal_condition_case_n):
7905 Remove unnecessary aborts (Bug#9081).
72ad093b 7906
35774242
EZ
79072011-08-17 Eli Zaretskii <eliz@gnu.org>
7908
7909 * lread.c (Fload) [DOS_NT]: If `openp' returns -2, but the file
7910 has no `load' handler, try opening the file locally. (Bug#9311)
7911
db76dd85
KB
79122011-08-16 Ken Brown <kbrown@cornell.edu>
7913
7914 * gmalloc.c: Expand comment.
7915
b215eee5
EZ
79162011-08-16 Eli Zaretskii <eliz@gnu.org>
7917
7918 * xdisp.c (set_cursor_from_row): Don't accept a previous candidate
7919 if it fails the cursor_row_p test. Fixes cursor positioning at ZV.
7920
a4579d33
KB
79212011-08-16 Ken Brown <kbrown@cornell.edu>
7922
7923 Fix memory allocation problems in Cygwin build (Bug#9273).
7924
7925 * unexcw.c ( __malloc_initialized): Declare external variable.
7926 (fixup_executable): Force the dumped emacs to reinitialize malloc.
7927
8b76d6f8
SM
7928 * gmalloc.c [CYGWIN] (bss_sbrk_heapbase, bss_sbrk_heapinfo):
7929 New variables.
a4579d33
KB
7930 (malloc_initialize_1) [CYGWIN]: Prepare for reinitializing the
7931 dumped emacs.
7932 (_free_internal_nolock) [CYGWIN]: Ignore requests to free storage
7933 in the static heap.
7934 [CYGWIN] (special_realloc): New function.
7935 (_realloc_internal_nolock) [CYGWIN]: Use the new function on
7936 requests to realloc storage in the static heap.
7937
3ebec551
PE
79382011-08-15 Paul Eggert <eggert@cs.ucla.edu>
7939
7940 * bidi.c (bidi_initialize): Remove unused local.
7941
9fd8be00
EZ
79422011-08-15 Eli Zaretskii <eliz@gnu.org>
7943
6b02f655
SM
7944 * bidimirror.h:
7945 * biditype.h: Remove file.
7946 * makefile.w32-in ($(BLD)/bidi.$(O)):
7947 * deps.mk (bidi.o): Remove biditype.h and bidimirror.h.
474a8465
EZ
7948
7949 * dispextern.h: Fix a typo in the comment to bidi_type_t.
7950
7951 * chartab.c: Improve commentary for the uniprop_table API.
7952
32413314
EZ
7953 * bidi.c (bidi_paragraph_init): Support zero value of
7954 bidi_ignore_explicit_marks_for_paragraph_level.
474a8465
EZ
7955 (bidi_initialize): Use uniprop_table instead of including
7956 biditype.h and bidimirror.h.
32413314 7957
9fd8be00
EZ
7958 * xdisp.c (move_it_in_display_line_to): Don't reset pixel
7959 coordinates of the iterator when restoring from ppos_it.
7960 (Bug#9296)
7961
5cf2b69b
KH
79622011-08-14 Kenichi Handa <handa@m17n.org>
7963
7964 * process.c (create_process): Call setup_process_coding_systems
72ad093b 7965 after the pid of the process is set to -1 (Bug#8162).
5cf2b69b 7966
daf17d00
EZ
79672011-08-14 Eli Zaretskii <eliz@gnu.org>
7968
7969 * xdisp.c (move_it_in_display_line_to): Don't invoke
7970 IT_RESET_X_ASCENT_DESCENT when iterator position was restored from
7971 ppos_it. Fixes vertical cursor motion when line beginning is
7972 covered by an image. (Bug#9296)
7973
08e3161a
JD
79742011-08-14 Jan Djärv <jan.h.d@swipnet.se>
7975
7976 * nsterm.h (ns_run_ascript): Declare.
7977 (NSAPP_DATA2_RUNASSCRIPT): Define.
7978
7979 * nsfns.m (as_script, as_result, as_status): New static variables.
7980 (ns_run_ascript): New function.
5e617bc2 7981 (Fns_do_applescript): Set variables as_*. Make an NSApplicationDefined
08e3161a
JD
7982 event with data2 set to NSAPP_DATA2_RUNASSCRIPT, post it and then start
7983 the event loop. Get status from as_status (Bug#7276).
7984
7985 * nsterm.m (sendEvent): If event is NSApplicationDefined and
7986 data2 is NSAPP_DATA2_RUNASSCRIPT, call ns_run_ascript and then exit
7987 the event loop (Bug#7276).
7988
a3720aa2
AS
79892011-08-14 Andreas Schwab <schwab@linux-m68k.org>
7990
7991 * gnutls.c (QCgnutls_bootprop_priority)
7992 (QCgnutls_bootprop_trustfiles, QCgnutls_bootprop_keylist)
7993 (QCgnutls_bootprop_crlfiles, QCgnutls_bootprop_callbacks)
7994 (QCgnutls_bootprop_loglevel, QCgnutls_bootprop_hostname)
7995 (QCgnutls_bootprop_min_prime_bits, QCgnutls_bootprop_verify_flags)
7996 (QCgnutls_bootprop_verify_hostname_error)
7997 (QCgnutls_bootprop_callbacks_verify): Rename from
7998 Qgnutls_bootprop_..., all uses changed.
7999
8000 * xfaces.c (QCignore_defface): Rename from Qignore_defface, all
8001 uses changed.
8002
0a0d27fb
PE
80032011-08-14 Paul Eggert <eggert@cs.ucla.edu>
8004
19d5c50c
PE
8005 * xfaces.c (Qframe_set_background_mode): Now static.
8006 * dispextern.h (Qframe_set_background_mode): Remove decl.
8007
0a0d27fb
PE
8008 * process.c (Fnetwork_interface_info): Declare local only if needed.
8009
377538cb
JD
80102011-08-13 Jan Djärv <jan.h.d@swipnet.se>
8011
8012 * process.c: Include ifaddrs.h and net/if_dl.h if available (Bug#8477).
8013 (Fnetwork_interface_list): Allocate in increments of bytes instead
8014 of sizeof (struct ifreq). Iterate over ifconf.ifc_req by counting
8015 bytes (Bug#8477). Count bytes correctly when ifr_addr is a struct
8016 sockaddr.
8017 (struct ifflag_def): notrailers is smart on OSX.
8018 (Fnetwork_interface_info): Handle case when ifr_flags is negative.
8019 Get hardware address with getifaddrs if available.
8020
08fff70c
EZ
80212011-08-12 Eli Zaretskii <eliz@gnu.org>
8022
8023 * xdisp.c (iterate_out_of_display_property): xassert that
8024 IT->position is set to within IT->object's boundaries. Break from
8025 the loop as soon as EOB is reached; avoids infloops in redisplay
8b76d6f8
SM
8026 when IT->position is set up wrongly due to some bug.
8027 Set IT->current to match the bidi iterator unconditionally.
08fff70c
EZ
8028 (push_display_prop): Allow GET_FROM_STRING as IT->method on
8029 entry. Force push_it to save on the stack the current
8030 buffer/string position, to be restored by pop_it. Fix flags in
8031 the iterator structure wrt the object coming from a display
8032 property, as `line-prefix' and `wrap-prefix' are not ``replacing''
8033 properties. (Bug#9284)
8034
7be1c708 80352011-08-09 Andreas Schwab <schwab@linux-m68k.org>
aac0c6e3 8036
7be1c708
CY
8037 * fontset.c (fontset_get_font_group): Add proper type checks.
8038 (Bug#9172)
aac0c6e3 8039
7be1c708 80402011-08-09 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
aac0c6e3 8041
7be1c708
CY
8042 * unexmacosx.c (print_load_command_name): Add cases LC_FUNCTION_STARTS
8043 and LC_VERSION_MIN_MACOSX.
8044 (copy_linkedit_data) [LC_FUNCTION_STARTS]: New function.
8045 (dump_it) [LC_FUNCTION_STARTS]: Use it.
aac0c6e3 8046
97bb72a6
EZ
80472011-08-08 Eli Zaretskii <eliz@gnu.org>
8048
8049 * xdisp.c (forward_to_next_line_start): Allow to use the
8b76d6f8
SM
8050 no-display-properties-and-no-overlays under bidi display.
8051 Set disp_pos in the bidi iterator to avoid searches for display
757664a4 8052 properties and overlays.
97bb72a6 8053
d5617611
CY
80542011-08-08 Chong Yidong <cyd@stupidchicken.com>
8055
37e11a63
CY
8056 * editfns.c (Fset_time_zone_rule): Document relationship with the
8057 setenv function.
8058
d5617611
CY
8059 * ftfont.c (ftfont_pattern_entity): Copy the extras argument to
8060 the font entity extracted from the cache (Bug#8109).
8061
58872834
CY
80622011-08-07 Chong Yidong <cyd@stupidchicken.com>
8063
8064 * composite.c (autocmp_chars): Don't reset point. That is done by
8065 restore_point_unwind (Bug#5984).
8066
75bfc667
JL
80672011-08-07 Juri Linkov <juri@jurta.org>
8068
8069 * editfns.c (Fformat_time_string): Doc fix, add tag `usage:'
8070 to show the arg `TIME' instead of `TIMEVAL'.
8071
d1410150
EZ
80722011-08-06 Eli Zaretskii <eliz@gnu.org>
8073
8074 * xdisp.c (set_cursor_from_row): Fix cursor positioning when a
8075 display property strides EOL and includes a newline, as in
8076 longlines-mode. (Bug#9254)
75b771e4
EZ
8077 (move_it_in_display_line_to): Fix vertical-motion in a buffer with
8078 word-wrap under bidirectional display. (Bug#9224)
d1410150
EZ
8079
8080 * bidi.c (bidi_unshelve_cache): Don't reset the cache if JUST_FREE
8081 is non-zero, even if the data buffer is NULL. Fixes a crash in
8082 vertical-motion with longlines-mode. (Bug#9254)
8083
35928349
EZ
80842011-08-05 Eli Zaretskii <eliz@gnu.org>
8085
ec7cc85b
EZ
8086 * bidi.c <bidi_cache_total_alloc>: Now static.
8087 (bidi_initialize): Initialize bidi_cache_total_alloc.
8088
8b76d6f8 8089 * xdisp.c (display_line): Release buffer allocated for shelved bidi
35928349
EZ
8090 cache. (Bug#9221)
8091
8092 * bidi.c (bidi_shelve_cache, bidi_unshelve_cache): Track total
8093 amount allocated this far in `bidi_cache_total_alloc'.
8094 (bidi_unshelve_cache): Accept an additional argument JUST_FREE; if
8095 non-zero, only free the data buffer without restoring the cache
8096 contents. All callers changed.
8097
8098 * dispextern.h (bidi_unshelve_cache): Update prototype.
8099
8100 * xdisp.c (SAVE_IT, pos_visible_p, move_it_in_display_line_to)
8101 (move_it_in_display_line, move_it_to)
8102 (move_it_vertically_backward, move_it_by_lines): Replace the call
8103 to xfree to an equivalent call to bidi_unshelve_cache.
8104 (move_it_in_display_line_to): Fix logic of returning
412b6358 8105 MOVE_POS_MATCH_OR_ZV in the bidi case. (Bug#9224)
35928349 8106
e2e2423b
EZ
81072011-08-05 Eli Zaretskii <eliz@gnu.org>
8108
8109 * xdisp.c (set_cursor_from_row): Prefer the candidate glyph that
8110 came from a string character with a `cursor' property. (Bug#9229)
8111
ae9e757a
JD
81122011-08-04 Jan Djärv <jan.h.d@swipnet.se>
8113
8114 * Makefile.in (LIB_PTHREAD): New variable.
8115 (LIBES): Add LIB_PTHREAD (Bug#9216).
8116
8117 * alloc.c, emacs.c, gmalloc.c, gtkutil.c, keyboard.c, syssignal.h:
8118 Rename HAVE_GTK_AND_PTHREAD to HAVE_PTHREAD (Bug#9216).
8119
213bd7f2
AS
81202011-08-04 Andreas Schwab <schwab@linux-m68k.org>
8121
6b02f655 8122 * regex.c (re_iswctype): Remove some redundant boolean conversions.
213bd7f2 8123
99aaf75f
JD
81242011-08-04 Jan Djärv <jan.h.d@swipnet.se>
8125
8126 * xterm.c (x_find_topmost_parent): New function.
8127 (x_set_frame_alpha): Find topmost parent window with
8128 x_find_topmost_parent and set the property there also (bug#9181).
8129 (handle_one_xevent): Call x_set_frame_alpha on ReparentNotify.
8130
c74e9d86
PE
81312011-08-04 Paul Eggert <eggert@cs.ucla.edu>
8132
8133 * callproc.c (Fcall_process): Avoid vfork clobbering
8134 the local vars buffer, coding_systems, current_dir.
8135
640c8776
SM
81362011-08-03 Stefan Monnier <monnier@iro.umontreal.ca>
8137
8138 * keymap.c (Fmake_composed_keymap): Move to subr.el.
8139
f26d0e4c
PE
81402011-08-03 Paul Eggert <eggert@cs.ucla.edu>
8141
8a10d76c
PE
8142 * fontset.c (dump_fontset) [FONTSET_DEBUG]: Declare EXTERNALLY_VISIBLE
8143 so that it is not optimized away.
8144
f26d0e4c
PE
8145 * xdisp.c (compute_display_string_pos): Remove unused local.
8146
55439c61
EZ
81472011-08-02 Eli Zaretskii <eliz@gnu.org>
8148
8149 Fix slow cursor motion and scrolling in large buffers with
8150 selective display, like Org Mode buffers. (Bug#9218)
8151
8152 * dispextern.h (struct bidi_it): New member disp_prop_p.
8153
8154 * xdisp.c: Remove one-slot cache of display string positions.
8155 (compute_display_string_pos): Accept an additional argument
5e617bc2 8156 DISP_PROP_P; callers changed. Scan at most 5K characters forward
55439c61
EZ
8157 for a display string or property. If found, set DISP_PROP_P
8158 non-zero.
8159
8160 * bidi.c (bidi_fetch_char): Accept an additional argument
640c8776
SM
8161 DISP_PROP_P, and pass it to compute_display_string_pos.
8162 Only handle text covered by a display string if DISP_PROP_P is returned
55439c61
EZ
8163 non-zero. All callers of bidi_fetch_char changed.
8164
fb33fa43
SM
81652011-08-02 Stefan Monnier <monnier@iro.umontreal.ca>
8166
8167 * keymap.c (Fdefine_key): Fix Lisp_Object/int mixup; apply some CSE.
8168
b099e063
DM
81692010-12-03 Don March <don@ohspite.net>
8170
8171 * keymap.c (Fdefine_key): Fix non-prefix key error message when
8172 last character M-[char] is translated to ESC [char] (bug#7541).
8173
5cc7f7af
KH
81742011-08-02 Kenichi Handa <handa@m17n.org>
8175
d0fffa3f 8176 * lisp.h (uniprop_table): Extern it.
5cc7f7af
KH
8177
8178 * chartab.c (uniprop_table): Make it non-static.
8179
525d5e6e
EZ
81802011-08-01 Eli Zaretskii <eliz@gnu.org>
8181
8182 * xdisp.c (forward_to_next_line_start): Accept additional argument
8183 BIDI_IT_PREV, and store into it the state of the bidi iterator had
8184 on the newline.
8185 (reseat_at_next_visible_line_start): Use the bidi iterator state
8186 returned by forward_to_next_line_start to restore the state of
8187 it->bidi_it after backing up to previous newline. (Bug#9212)
8188
31011111
AS
81892011-07-30 Andreas Schwab <schwab@linux-m68k.org>
8190
8191 * regex.c (re_comp): Protoize.
8192 (re_exec): Fix return type.
8193 (regexec): Fix type of `ret'. (Bug#9203)
8194
476371c4
PE
81952011-07-28 Paul Eggert <eggert@cs.ucla.edu>
8196
e5d76069
PE
8197 * image.c (check_image_size): Use 1024x1024 if unknown frame (Bug#9189).
8198 This is needed if max-image-size is a floating-point number.
8199
9a79b20c
AS
82002011-07-28 Andreas Schwab <schwab@linux-m68k.org>
8201
8202 * print.c (print_object): Print empty symbol as ##.
8203
8204 * lread.c (read1): Read ## as empty symbol.
8205
d8c2fa78
AA
82062011-07-28 Alp Aker <alp.tekin.aker@gmail.com>
8207
8208 * nsfns.m (x_set_foreground_color): Set f->foreground_pixel when
8209 setting frame foreground color (Bug#9175).
8210 (x_set_background_color): Likewise.
8211
ffe57a7a
AA
8212 * nsmenu.m (-setText): Size tooltip dimensions precisely to
8213 contents (Bug#9176).
8214 (EmacsTooltip -init): Remove bezels and add shadows to
8215 tooltip windows.
8216
bf3492a5
AA
8217 * nsterm.m (ns_dumpglyphs_stretch): Avoid overwriting left fringe
8218 or scroll bar (Bug#8470).
8219
d55e9c53
AA
8220 * nsfont.m (nsfont_open): Remove assignment to voffset and
8221 unnecessary vars hshink, expand, hd, full_height, min_height.
8222 (nsfont_draw): Use s->ybase as baseline for glyph drawing (Bug#8913).
8223
8224 * nsterm.h (nsfont_info): Remove voffset field.
8225
d8c2fa78 82262011-07-28 Alp Aker <alp.tekin.aker@gmail.com>
4843aac3
AA
8227
8228 Implement strike-through and overline on NextStep (Bug#8863).
8229
8230 * nsfont.m (nsfont_open): Use underline position provided by font,
8231 instead of hard-coded value of 2.
8232 (nsfont_draw): Call ns_draw_text_decoration instead.
8233
8234 * nsterm.h: Add declaration for ns_draw_text_decoration.
8235
8236 * nsterm.m (ns_draw_text_decoration): New function for drawing
8237 underline, overline, and strike-through.
8238 (ns_dumpglyphs_image, ns_dumpglyphs_stretch): Add call to
8239 ns_draw_text_decoration. Change treatment of cursor drawing to
8d5ed899 8240 accommodate underlining, etc.
4843aac3 8241
4cc60b9b
EZ
82422011-07-28 Eli Zaretskii <eliz@gnu.org>
8243
bc7ece87
EZ
8244 * buffer.c (init_buffer_once): Set bidi-display-reordering to t by
8245 default.
4cc60b9b 8246
476371c4
PE
82472011-07-28 Paul Eggert <eggert@cs.ucla.edu>
8248
66606eea
PE
8249 * alloc.c (memory_full) [!SYNC_INPUT]: Fix signal-related race.
8250 Without this fix, if a signal arrives just after memory fills up,
8251 'malloc' might be invoked reentrantly.
8252
476371c4
PE
8253 * image.c (x_check_image_size) [!HAVE_X_WINDOWS]: Return 1.
8254 In other words, assume that every image size is allowed, on non-X
8255 hosts. This assumption is probably wrong, but it lets Emacs compile.
8256
f3fcc40d
AS
82572011-07-28 Andreas Schwab <schwab@linux-m68k.org>
8258
8259 * regex.c (re_iswctype): Convert return values to boolean.
8260
350c992f
EZ
82612011-07-28 Eli Zaretskii <eliz@fencepost.gnu.org>
8262
8263 * xdisp.c (compute_display_string_pos): Don't use cached display
8264 string position if the buffer had its restriction changed.
8265 (Bug#9184)
8266
5266b4bb
PE
82672011-07-28 Paul Eggert <eggert@cs.ucla.edu>
8268
8269 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork clobbering.
8270
2573a837 82712011-07-28 Paul Eggert <eggert@cs.ucla.edu>
ca4aa935 8272
41f55ccd 8273 Integer signedness and overflow and related fixes. (Bug#9079)
cf950e6b 8274
39e378da
PE
8275 * bidi.c: Integer size and overflow fixes.
8276 (bidi_cache_size, bidi_cache_idx, bidi_cache_last_idx)
8277 (bidi_cache_start, bidi_cache_fetch_state, bidi_cache_search)
8278 (bidi_cache_find_level_change, bidi_cache_ensure_space)
8279 (bidi_cache_iterator_state, bidi_cache_find, bidi_cache_start_stack)
8280 (bidi_find_other_level_edge):
8281 Use ptrdiff_t instead of EMACS_INT where either will do.
8282 This works better on 32-bit hosts configured --with-wide-int.
8283 (bidi_cache_ensure_space): Check for size-calculation overflow.
8284 Use % rather than repeated addition, for better worst-case speed.
8285 Don't set bidi_cache_size until after xrealloc returns, because it
8286 might not return.
8287 (bidi_dump_cached_states): Use ptrdiff_t, not int, to avoid overflow.
f0eb61e9
PE
8288 (bidi_cache_ensure_space): Also check that the bidi cache size
8289 does not exceed that of the largest Lisp string or buffer. See Eli
8290 Zaretskii in <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=9079#29>.
39e378da 8291
5e927815
PE
8292 * alloc.c (__malloc_size_t): Remove.
8293 All uses replaced by size_t. See Andreas Schwab's note
8294 <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=9079#8>.
8295
ca4aa935
PE
8296 * image.c: Improve checking for integer overflow.
8297 (check_image_size): Assume that f is nonnull, since
8298 it is always nonnull in practice. This is one less thing to
8299 worry about when checking for integer overflow later.
8300 (x_check_image_size): New function, which checks for integer
8301 overflow issues inside X.
8302 (x_create_x_image_and_pixmap, xbm_read_bitmap_data): Use it.
8303 This removes the need for a memory_full check.
8304 (xbm_image_p): Rewrite to avoid integer multiplication overflow.
8305 (Create_Pixmap_From_Bitmap_Data, xbm_load): Use x_check_image_size.
8306 (xbm_read_bitmap_data): Change locals back to 'int', since
8307 their values must fit in 'int'.
8308 (xpm_load_image, png_load, tiff_load):
8309 Invoke x_create_x_image_and_pixmap earlier,
8310 to avoid much needless work if the image is too large.
8311 (tiff_load): Treat overly large images as if
8312 x_create_x_image_and_pixmap failed, not as malloc failures.
8313 (gs_load): Use x_check_image_size.
8314
5f8f9cc2
PE
8315 * gtkutil.c: Omit integer casts.
8316 (xg_get_pixbuf_from_pixmap): Remove unnecessary cast.
8317 (xg_set_toolkit_scroll_bar_thumb): Rewrite to avoid need for cast.
8318
5adf60bc
PE
8319 * image.c (png_load): Don't assume height * row_bytes fits in 'int'.
8320
c8907a93
PE
8321 * xfaces.c (Fbitmap_spec_p): Fix integer overflow bug.
8322 Without this fix, (bitmap-spec-p '(34359738368 1 "x"))
8323 would wrongly return t on a 64-bit host.
8324
e3c25c68
PE
8325 * dispnew.c (init_display): Use *_RANGE_OVERFLOW macros.
8326 The plain *_OVERFLOW macros run afoul of GCC bug 49705
8327 <http://gcc.gnu.org/bugzilla/show_bug.cgi?id=49705>
8328 and therefore cause GCC to emit a bogus diagnostic in some cases.
8329
3f791afe
PE
8330 * image.c: Integer signedness and overflow and related fixes.
8331 This is not an exhaustive set of fixes, but it's time to
8332 record what I've got.
8333 (lookup_pixel_color, check_image_size): Remove redundant decls.
8334 (check_image_size): Don't assume that arbitrary EMACS_INT values
8335 fit in 'int', or that arbitrary 'double' values fit in 'int'.
8336 (x_alloc_image_color, x_create_x_image_and_pixmap, png_load)
8337 (tiff_load, imagemagick_load_image):
8338 Check for overflow in size calculations.
8339 (x_create_x_image_and_pixmap): Remove unnecessary test for
8340 xmalloc returning NULL; that can't happen.
8341 (xbm_read_bitmap_data): Don't assume sizes fit into 'int'.
8342 (xpm_color_bucket): Use better integer hashing function.
8343 (xpm_cache_color): Don't possibly over-allocate memory.
8344 (struct png_memory_storage, tiff_memory_source, tiff_seek_in_memory)
8345 (gif_memory_source):
8346 Use ptrdiff_t, not int or size_t, to record sizes.
8347 (png_load): Don't assume values greater than 2**31 fit in 'int'.
8348 (our_stdio_fill_input_buffer): Prefer ptrdiff_t to size_t when
8349 either works, as we prefer signed integers.
8350 (tiff_read_from_memory, tiff_write_from_memory):
8351 Return tsize_t, not size_t, since that's what the TIFF API wants.
8352 (tiff_read_from_memory): Don't fail simply because the read would
8353 go past EOF; instead, return a short read.
8354 (tiff_load): Omit no-longer-needed casts.
8355 (Fimagemagick_types): Don't assume size fits into 'int'.
8356
3cc5a532
PE
8357 Improve hashing quality when configured --with-wide-int.
8358 * fns.c (hash_string): New function, taken from sxhash_string.
8359 Do not discard information about ASCII character case; this
8360 discarding is no longer needed.
8361 (sxhash-string): Use it. Change sig to match it. Caller changed.
8362 * lisp.h: Declare it.
8363 * lread.c (hash_string): Remove, since we now use fns.c's version.
8364 The fns.c version returns a wider integer if --with-wide-int is
8365 specified, so this should help the quality of the hashing a bit.
8366
b312a492
PE
8367 * emacs.c: Integer overflow minor fix.
8368 (heap_bss_diff): Now uprintmax_t, not unsigned long. All used changed.
8369 Define only if GNU_LINUX.
8370 (main, Fdump_emacs): Set and use heap_bss_diff only if GNU_LINUX.
8371
dfd153ae
PE
8372 * dispnew.c: Integer signedness and overflow fixes.
8373 Remove unnecessary forward decls, that were a maintenance hassle.
8374 (history_tick): Now uprintmax_t, so it's more likely to avoid overflow.
8375 All uses changed.
8376 (adjust_glyph_matrix, realloc_glyph_pool, adjust_frame_message_buffer)
8377 (scrolling_window): Use ptrdiff_t, not int, for byte count.
8378 (prepare_desired_row, line_draw_cost):
8379 Use int, not unsigned, where either works.
8380 (save_current_matrix, restore_current_matrix):
8381 Use ptrdiff_t, not size_t, where either works.
8382 (init_display): Check for overflow more accurately, and without
8383 relying on undefined behavior.
8384
a81d11a3
PE
8385 * editfns.c (pWIDE, pWIDElen, signed_wide, unsigned_wide):
8386 Remove, replacing with the new symbols in lisp.h. All uses changed.
8387 * fileio.c (make_temp_name):
8388 * filelock.c (lock_file_1, lock_file):
8389 * xdisp.c (message_dolog):
8390 Don't assume PRIdMAX etc. works; this isn't portable to pre-C99 hosts.
8391 Use pMd etc. instead.
8392 * lisp.h (printmax_t, uprintmax_t, pMd, pMu): New types and macros,
8393 replacing the pWIDE etc. symbols removed from editfns.c.
8394
3300e6fd
PE
8395 * keyboard.h (num_input_events): Now uintmax_t.
8396 This is (very slightly) less likely to mess up due to wraparound.
8397 All uses changed.
8398
fd05c7e9
PE
8399 * buffer.c: Integer signedness fixes.
8400 (alloc_buffer_text, enlarge_buffer_text):
8401 Use ptrdiff_t rather than size_t when either will do, as we prefer
8402 signed integers.
8403
903fe15d
PE
8404 * alloc.c: Integer signedness and overflow fixes.
8405 Do not impose an arbitrary 32-bit limit on malloc sizes when debugging.
8406 (__malloc_size_t): Default to size_t, not to int.
8407 (pure_size, pure_bytes_used_before_overflow, stack_copy_size)
8408 (Fgarbage_collect, mark_object_loop_halt, mark_object):
8409 Prefer ptrdiff_t to size_t when either would do, as we prefer
8410 signed integers.
8411 (XMALLOC_OVERRUN_CHECK_OVERHEAD): New macro.
8412 (xmalloc_overrun_check_header, xmalloc_overrun_check_trailer):
8413 Now const. Initialize with values that are in range even if char
8414 is signed.
8415 (XMALLOC_PUT_SIZE, XMALLOC_GET_SIZE): Remove, replacing with ...
8416 (xmalloc_put_size, xmalloc_get_size): New functions. All uses changed.
8417 These functions do the right thing with sizes > 2**32.
8418 (check_depth): Now ptrdiff_t, not int.
8419 (overrun_check_malloc, overrun_check_realloc, overrun_check_free):
8420 Adjust to new way of storing sizes. Check for size overflow bugs
8421 in rest of code.
8422 (STRING_BYTES_MAX): Adjust to new overheads. The old code was
8423 slightly wrong anyway, as it missed one instance of
8424 XMALLOC_OVERRUN_CHECK_OVERHEAD.
8425 (refill_memory_reserve): Omit needless cast to size_t.
8426 (mark_object_loop_halt): Mark as externally visible.
8427
ac82cc6a
PE
8428 * xselect.c: Integer signedness and overflow fixes.
8429 (Fx_register_dnd_atom, x_handle_dnd_message):
8430 Use ptrdiff_t, not size_t, since we prefer signed.
8431 (Fx_register_dnd_atom): Check for ptrdiff_t (and size_t) overflow.
8432 * xterm.h (struct x_display_info): Use ptrdiff_t, not size_t, for
8433 x_dnd_atoms_size and x_dnd_atoms_length.
8434
c2d1e36d
PE
8435 * doprnt.c: Prefer signed to unsigned when either works.
8436 * eval.c (verror):
8437 * doprnt.c (doprnt):
8438 * lisp.h (doprnt):
8439 * xdisp.c (vmessage):
8440 Use ptrdiff_t, not size_t, when using or implementing doprnt,
8441 since the sizes cannot exceed ptrdiff_t bounds anyway, and we
8442 prefer signed arithmetic to avoid comparison confusion.
8443 * doprnt.c (doprnt): Avoid a "+ 1" that can't overflow,
8444 but is a bit tricky.
8445
0e926e56
PE
8446 Assume freestanding C89 headers, string.h, stdlib.h.
8447 * data.c, doprnt.c, floatfns.c, print.c:
8448 Include float.h unconditionally.
8449 * gmalloc.c: Assume C89-at-least behavior for preprocessor,
8450 limits.h, stddef.h, string.h. Use memset instead of 'flood'.
8451 * regex.c: Likewise for stddef.h, string.h.
8452 (ISASCII): Remove; can assume it returns 1 now. All uses removed.
8453 * s/aix4-2.h (HAVE_STRING_H): Remove obsolete undef.
8454 * s/ms-w32.h (HAVE_LIMITS_H, HAVE_STRING_H, HAVE_STDLIB_H)
8455 (STDC_HEADERS): Remove obsolete defines.
8456 * sysdep.c: Include limits.h unconditionally.
8457
9cfdb3ec
PE
8458 Assume support for memcmp, memcpy, memmove, memset.
8459 * lisp.h, sysdep.c (memcmp, memcpy, memmove, memset):
8460 * regex.c (memcmp, memcpy):
8461 Remove; we assume C89 now.
8462
8463 * gmalloc.c (memcpy, memset, memmove): Remove; we assume C89 now.
8464 (__malloc_safe_bcopy): Remove; no longer needed.
8465
cf950e6b 8466 * lisp.h (struct vectorlike_header, struct Lisp_Subr): Signed sizes.
6089c567
PE
8467 Use EMACS_INT, not EMACS_UINT, for sizes. The code works equally
8468 well either way, and we prefer signed to unsigned.
8469
dbf38e02
LMI
84702011-07-27 Lars Magne Ingebrigtsen <larsi@gnus.org>
8471
8472 * gnutls.c (emacs_gnutls_read): Don't message anything if the peer
8473 closes the connection while we're reading (bug#9182).
8474
d6f0886c 84752011-07-25 Jan Djärv <jan.h.d@swipnet.se>
24e0f6b1 8476
d6f0886c
JD
8477 * nsmenu.m (ns_popup_dialog): Add an "ok" button if no buttons
8478 are specified (Bug#9168).
24e0f6b1 8479
2eb1f9e6
PE
84802011-07-25 Paul Eggert <eggert@cs.ucla.edu>
8481
8482 * bidi.c (bidi_dump_cached_states): Fix printf format mismatch.
8483 Found by GCC static checking and --with-wide-int on a 32-bit host.
8484
22381272 84852011-07-25 Eli Zaretskii <eliz@gnu.org>
7daee910
EZ
8486
8487 * xdisp.c (compute_display_string_pos): Fix logic of caching
8488 previous display string position. Initialize cached_prev_pos to
8489 -1. Fixes slow-down at the beginning of a buffer.
8490
f25e39b4
EZ
84912011-07-24 Eli Zaretskii <eliz@gnu.org>
8492
8493 * xfaces.c (check_lface_attrs) [HAVE_WINDOW_SYSTEM]: Allow `nil'
8494 for attrs[LFACE_FONTSET_INDEX].
8495
04c4b52e
PE
84962011-07-23 Paul Eggert <eggert@cs.ucla.edu>
8497
8498 * xml.c (parse_region): Remove unused local
8499 that was recently introduced.
8500
c1734fbd
EZ
85012011-07-23 Eli Zaretskii <eliz@gnu.org>
8502
be18c5a5
EZ
8503 * xfns.c (unwind_create_frame) [GLYPH_DEBUG]: Adapt to changes in
8504 2008-02-22T17:42:09Z!monnier@iro.umontreal.ca.
8505
c1734fbd
EZ
8506 * xdisp.c (move_it_in_display_line_to): Record the best matching
8507 position for TO_CHARPOS while scanning the line, and restore it on
640c8776
SM
8508 exit if none of the characters scanned was an exact match.
8509 Fixes vertical-motion and pos-visible-in-window-p under bidi redisplay
a9269c18
EZ
8510 when exact match is impossible due to invisible text, and the
8511 lines are truncated.
8512
a258d627
JD
85132011-07-23 Jan Djärv <jan.h.d@swipnet.se>
8514
8515 * nsterm.m (initFrameFromEmacs): Set NSTitledWindowMask in styleMask
8516 for OSX >= 10.7.
8517
b6d5a689
EZ
85182011-07-22 Eli Zaretskii <eliz@gnu.org>
8519
0f74f785
EZ
8520 Fix a significant slow-down of cursor motion with C-n, C-p,
8521 C-f/C-b, and C-v/M-v that couldn't keep up with keyboard
8522 auto-repeat under bidi redisplay in fontified buffers.
b6d5a689 8523 * xdisp.c (compute_stop_pos_backwards): New function.
b6d5a689
EZ
8524 (next_element_from_buffer): Call compute_stop_pos_backwards to
8525 find a suitable prev_stop when we find ourselves before
0f74f785
EZ
8526 base_level_stop.
8527 (reseat): Don't look for prev_stop, as that could mean a very long
8528 run.
8529 <cached_disp_pos, cached_disp_buffer, cached_disp_modiff>
8530 <cached_disp_overlay_modiff>: Cache for last found display string
8531 position.
551918c1 8532 (compute_display_string_pos): Return the cached position if asked
0f74f785
EZ
8533 about the same buffer in the same area of character positions, and
8534 the buffer wasn't changed since the time the display string
8535 position was cached.
551918c1 8536
b2d0c91a
EZ
85372011-07-22 Eli Zaretskii <eliz@gnu.org>
8538
8539 * xdisp.c (rows_from_pos_range): Don't ignore glyphs whose object
8540 is an integer, which is important for empty lines. (Bug#9149)
8541
043604ee
CY
85422011-07-22 Chong Yidong <cyd@stupidchicken.com>
8543
8544 * frame.c (Fmodify_frame_parameters): In tty case, update the
8545 default face if necessary (Bug#4238).
8546
da4adb04
CY
85472011-07-21 Chong Yidong <cyd@stupidchicken.com>
8548
8549 * editfns.c (Fstring_to_char): No need to explain what a character
8550 is in the docstring (Bug#6576).
8551
9abd0532
LMI
85522011-07-20 Lars Magne Ingebrigtsen <larsi@gnus.org>
8553
8554 * xml.c (parse_region): Make sure we always return a tree.
8555
36881d16
HK
85562011-07-20 HAMANO Kiyoto <khiker.mail@gmail.com>
8557
8558 * xml.c (parse_region): If a document contains only comments,
8559 return that, too.
8560
1e98674d
LMI
85612011-07-20 Lars Magne Ingebrigtsen <larsi@gnus.org>
8562
8563 * xml.c (make_dom): Return comments, too.
8564
590bd467
PE
85652011-07-19 Paul Eggert <eggert@cs.ucla.edu>
8566
8567 Port to OpenBSD.
8568 See http://lists.gnu.org/archive/html/emacs-devel/2011-07/msg00688.html
8569 and the surrounding thread.
8570 * minibuf.c (read_minibuf_noninteractive): Rewrite to use getchar
8571 rather than fgets, and retry after EINTR. Otherwise, 'emacs
8572 --batch -f byte-compile-file' fails on OpenBSD if an inactivity
8573 timer goes off.
8574 * s/openbsd.h (BROKEN_SIGIO): Define.
8575 * unexelf.c (unexec) [__OpenBSD__]:
8576 Don't update the .mdebug section of the Alpha COFF symbol table.
8577
f41628b2
LMI
85782011-07-19 Lars Magne Ingebrigtsen <larsi@gnus.org>
8579
8580 * lread.c (syms_of_lread): Clarify when `lexical-binding' is used
8581 (bug#8460).
8582
b59b67c5
PE
85832011-07-18 Paul Eggert <eggert@cs.ucla.edu>
8584
15e3a074
PE
8585 * fileio.c (Fcopy_file) [!MSDOS]: Tighten created file's mask.
8586 This fixes some race conditions on the permissions of any newly
8587 created file.
8588
41bed37d
PE
8589 * alloc.c (valid_pointer_p): Use pipe, not open.
8590 This fixes some permissions issues when debugging.
8591
b59b67c5
PE
8592 * fileio.c (Fcopy_file): Adjust mode if fchown fails. (Bug#9002)
8593 If fchown fails to set both uid and gid, try to set just gid,
8594 as that is sometimes allowed. Adjust the file's mode to eliminate
8595 setuid or setgid bits that are inappropriate if fchown fails.
8596
925a6be7
SM
85972011-07-18 Stefan Monnier <monnier@iro.umontreal.ca>
8598
8599 * xdisp.c (next_element_from_string, next_element_from_buffer): Use EQ
8600 to compare Lisp_Objects.
8601 * gnutls.c (syms_of_gnutls): Rename Vgnutls_log_level to
8602 global_gnutls_log_level, don't mistake it for a Lisp_Object.
8603 (init_gnutls_functions, emacs_gnutls_handle_error): Fix up uses.
8604
52968808
AS
86052011-07-17 Andreas Schwab <schwab@linux-m68k.org>
8606
0a6a104b
AS
8607 * lread.c (read_integer): Unread even EOF character.
8608 (read1): Likewise. Properly record start position of symbol.
8609
52968808
AS
8610 * lread.c (read1): Read `#:' as empty uninterned symbol if no
8611 symbol character follows.
8612
9e381cdd
PE
86132011-07-17 Paul Eggert <eggert@cs.ucla.edu>
8614
8615 * fileio.c (Fcopy_file): Pacify gcc re fchown. (Bug#9002)
8616 This works around a problem with the previous change to Fcopy_file.
8617 Recent glibc declares fchown with __attribute__((warn_unused_result)),
8618 and without this change, GCC might complain about discarding
8619 fchown's return value.
8620
b5641435
JB
86212011-07-16 Juanma Barranquero <lekktu@gmail.com>
8622
8623 * makefile.w32-in (GLOBAL_SOURCES): Add gnutls.c (followup to bug#9059).
8624
a8031457
PE
86252011-07-16 Paul Eggert <eggert@cs.ucla.edu>
8626
8627 * fileio.c (Fcopy_file): Don't diagnose fchown failures. (Bug#9002)
8628
dd889327
LMI
86292011-07-16 Lars Magne Ingebrigtsen <larsi@gnus.org>
8630
750c33f7
LMI
8631 * gnutls.c (syms_of_gnutls): Define `gnutls-log-level' here, since
8632 it's used from the C level.
8633
dd889327
LMI
8634 * process.c: Use the same condition for POLL_FOR_INPUT in both
8635 keyboard.c and process.c (bug#1858).
8636
87e86684
LM
86372011-07-09 Lawrence Mitchell <wence@gmx.li>
8638
8639 * gnutls.c (Qgnutls_bootprop_min_prime_bits): New variable.
8640 (Fgnutls_boot): Use it.
8641
64348f40
AS
86422011-07-15 Andreas Schwab <schwab@linux-m68k.org>
8643
8644 * doc.c (Fsubstitute_command_keys): Revert last change.
8645
1d698799
LMI
86462011-07-15 Lars Magne Ingebrigtsen <larsi@gnus.org>
8647
f863868c
LMI
8648 * doc.c (Fsubstitute_command_keys): Clarify that \= really only
8649 quotes the next character, and doesn't affect other longer
8650 sequences (bug#8935).
8651
1d698799
LMI
8652 * lread.c (syms_of_lread): Clarify that is isn't only
8653 `eval-buffer' and `eval-defun' that's affected by
8654 `lexical-binding' (bug#8460).
8655
aa4b6df6
EZ
86562011-07-15 Eli Zaretskii <eliz@gnu.org>
8657
8658 * xdisp.c (move_it_in_display_line_to): Fix vertical motion with
6b02f655 8659 bidi redisplay when a line includes both an image and is truncated.
aa4b6df6 8660
5d856da6
PE
86612011-07-14 Paul Eggert <eggert@cs.ucla.edu>
8662
ad6042bb
PE
8663 Fix minor problems found by static checking.
8664 * bidi.c (bidi_cache_size): Now EMACS_INT, not size_t.
8665 (elsz): Now a signed constant, not a size_t var. We prefer signed
8666 types to unsigned, to avoid integer comparison confusion. Without
8667 this change, GCC 4.6.1 with -Wunsafe-loop-optimizations complains
8668 "cannot optimize loop, the loop counter may overflow", a symptom
8669 of the confusion.
f00bbb22 8670 * indent.c (Fvertical_motion): Mark locals as initialized.
5d856da6
PE
8671 * xdisp.c (reseat_to_string): Fix pointer signedness issue.
8672
6468f31c
LMI
86732011-07-14 Lars Magne Ingebrigtsen <larsi@gnus.org>
8674
49080b10
LMI
8675 * search.c (Fre_search_backward): Mention `case-fold-search' in
8676 all the re_search_* functions (bug#8138).
8677
6468f31c
LMI
8678 * keyboard.c (Fopen_dribble_file): Document when the file is
8679 closed (bug#8056).
8680
c965adc5
EZ
86812011-07-14 Eli Zaretskii <eliz@gnu.org>
8682
df9733bf
EZ
8683 * bidi.c (bidi_dump_cached_states): Fix format of displaying
8684 bidi_cache_idx.
8685
0bb23927
EZ
8686 Support bidi reordering of display and overlay strings.
8687 * xdisp.c (compute_display_string_pos)
8688 (compute_display_string_end): Accept additional argument STRING.
8689 (init_iterator, reseat_1): Initialize bidi_it->string.s to NULL.
8690 (reseat_to_string): Initialize bidi_it->string.s and
8691 bidi_it->string.schars.
8692 (Fcurrent_bidi_paragraph_direction): Initialize itb.string.s to
640c8776
SM
8693 NULL (avoids a crash in bidi_paragraph_init).
8694 Initialize itb.string.lstring.
0bb23927
EZ
8695 (init_iterator): Call bidi_init_it only of a valid
8696 buffer position was specified. Initialize paragraph_embedding to
8697 L2R.
8698 (reseat_to_string): Initialize the bidi iterator.
8699 (display_string): If we need to ignore text properties of
8700 LISP_STRING, set IT->stop_charpos to IT->end_charpos. (The
8701 original value of -1 will not work with bidi.)
8702 (compute_display_string_pos): First arg is now struct
8703 `text_pos *'; all callers changed. Support display properties on
8704 Lisp strings.
8705 (compute_display_string_end): Support display properties on Lisp
8706 strings.
8707 (init_iterator, reseat_1, reseat_to_string): Initialize the
8708 string.bufpos member to 0 (zero, for compatibility with IT_CHARPOS
8709 when iterating on a string not from display properties).
640c8776
SM
8710 (compute_display_string_pos, compute_display_string_end):
8711 Fix calculation of the object to scan. Fixes an error when using
0bb23927
EZ
8712 arrow keys.
8713 (next_element_from_buffer): Don't abort when IT_CHARPOS is before
640c8776
SM
8714 base_level_stop; instead, set base_level_stop to BEGV.
8715 Fixes crashes in vertical-motion.
0bb23927
EZ
8716 (next_element_from_buffer): Improve commentary for when
8717 the iterator is before prev_stop.
8718 (init_iterator): Initialize bidi_p from the default value of
8719 bidi-display-reordering, not from buffer-local value. Use the
8720 buffer-local value only if initializing for buffer iteration.
8721 (handle_invisible_prop): Support invisible properties on strings
8722 that are being bidi-reordered.
8723 (set_iterator_to_next): Support bidi reordering of C strings and
8724 Lisp strings.
8725 (next_element_from_string): Support bidi reordering of Lisp
8726 strings.
8727 (handle_stop_backwards): Support Lisp strings as well.
640c8776
SM
8728 (display_string): Support display of R2L glyph rows.
8729 Use IT_STRING_CHARPOS when displaying from a Lisp string.
0bb23927
EZ
8730 (init_iterator): Don't initialize it->bidi_p for strings
8731 here.
8732 (reseat_to_string): Initialize it->bidi_p for strings here.
8733 (next_element_from_string, next_element_from_c_string)
8734 (next_element_from_buffer): Add xassert's for correspondence
8735 between IT's object being iterated and it->bidi_it.string
8736 structure.
8737 (face_before_or_after_it_pos): Support bidi iteration.
8738 (next_element_from_c_string): Handle the case of the first string
8739 character that is not the first one in the visual order.
8740 (get_visually_first_element): New function, refactored from common
8741 parts of next_element_from_buffer, next_element_from_string, and
8742 next_element_from_c_string.
8743 (tool_bar_lines_needed, redisplay_tool_bar)
8744 (display_menu_bar): Force left-to-right direction. Add a FIXME
8745 comment for making that be controlled by a user option.
8746 (push_it, pop_it): Save and restore the state of the
8747 bidi iterator. Save and restore the bidi_p flag.
8748 (pop_it): Iterate out of display property for string iteration as
8749 well.
8750 (iterate_out_of_display_property): Support iteration over strings.
8751 (handle_single_display_spec): Set up it->bidi_it for iteration
8752 over a display string, and call bidi_init_it.
8753 (handle_single_display_spec, next_overlay_string)
8754 (get_overlay_strings_1, push_display_prop): Set up the bidi
8755 iterator for displaying display or overlay strings.
8756 (forward_to_next_line_start): Don't use the shortcut if
8757 bidi-iterating.
8758 (back_to_previous_visible_line_start): If handle_display_prop
8759 pushed the iterator stack, restore the internal state of the bidi
8760 iterator by calling bidi_pop_it same number of times.
8761 (reseat_at_next_visible_line_start): If ON_NEWLINE_P is non-zero,
8762 and we are bidi-iterating, don't decrement the iterator position;
8763 instead, set the first_elt flag in the bidi iterator, to produce
8764 the same effect.
8765 (reseat_1): Remove redundant setting of string_from_display_prop_p.
8766 (push_display_prop): xassert that we are iterating a buffer.
8767 (push_it, pop_it): Save and restore paragraph_embedding member.
8768 (handle_single_display_spec, next_overlay_string)
8769 (get_overlay_strings_1, reseat_1, reseat_to_string)
8770 (push_display_prop): Set up the `unibyte' member of bidi_it.string
8771 correctly. Don't assume unibyte strings are not bidi-reordered.
8772 (compute_display_string_pos)
8773 (compute_display_string_end): Fix handling the case of C string.
8774 (push_it, pop_it): Save and restore from_disp_prop_p.
8775 (handle_single_display_spec, push_display_prop): Set the
8776 from_disp_prop_p flag.
8777 (get_overlay_strings_1): Reset the from_disp_prop_p flag.
8778 (pop_it): Call iterate_out_of_display_property only if we are
8779 popping after iteration over a string that came from a display
8780 property. Fix a typo in popping stretch info. Add an assertion
8781 for verifying that the iterator position is in sync with the bidi
8782 iterator.
8783 (handle_single_display_spec, get_overlay_strings_1)
8784 (push_display_prop): Fix initialization of paragraph direction for
8785 string when that of the parent object is not yet determined.
8786 (reseat_1): Call bidi_init_it to resync the bidi
8787 iterator with IT's position. (Bug#7616)
8788 (find_row_edges): If ROW->start.pos gives position
8789 smaller than min_pos, use it as ROW->minpos. (Bug#7616)
8790 (handle_stop, back_to_previous_visible_line_start, reseat_1):
8791 Reset the from_disp_prop_p flag.
8792 (SAVE_IT, RESTORE_IT): New macros.
8793 (pos_visible_p, face_before_or_after_it_pos)
8794 (back_to_previous_visible_line_start)
8795 (move_it_in_display_line_to, move_it_in_display_line)
8796 (move_it_to, move_it_vertically_backward, move_it_by_lines)
8797 (try_scrolling, redisplay_window, display_line): Use them when
8798 saving a temporary copy of the iterator and restoring it back.
8799 (back_to_previous_visible_line_start, reseat_1)
8800 (init_iterator): Empty the bidi cache "stack".
8801 (move_it_in_display_line_to): If iterator ended up at
8802 EOL, but we never saw any buffer positions smaller than
8803 to_charpos, return MOVE_POS_MATCH_OR_ZV. Fixes vertical cursor
8804 motion in bidi-reordered lines.
8805 (move_it_in_display_line_to): Record prev_method and prev_pos
8806 immediately before the call to set_iterator_to_next. Fixes cursor
8807 motion in bidi-reordered lines with stretch glyphs and strings
8808 displayed in margins. (Bug#8133) (Bug#8867)
8809 Return MOVE_POS_MATCH_OR_ZV only if iterator position is past
8810 TO_CHARPOS.
640c8776
SM
8811 (pos_visible_p): Support positions in bidi-reordered lines.
8812 Save and restore bidi cache.
0bb23927
EZ
8813
8814 * bidi.c (bidi_level_of_next_char): clen should be EMACS_NT, not int.
8815 (bidi_paragraph_info): Delete unused struct.
8816 (bidi_cache_idx, bidi_cache_last_idx): Declare EMACS_INT.
8817 (bidi_cache_start): New variable.
8818 (bidi_cache_reset): Reset bidi_cache_idx to bidi_cache_start, not
8819 to zero.
8820 (bidi_cache_fetch_state, bidi_cache_search)
8821 (bidi_cache_find_level_change, bidi_cache_iterator_state)
8822 (bidi_cache_find, bidi_peek_at_next_level)
8823 (bidi_level_of_next_char, bidi_find_other_level_edge)
8824 (bidi_move_to_visually_next): Compare cache index with
8825 bidi_cache_start rather than with zero.
8826 (bidi_fetch_char): Accept new argument STRING; all callers
8827 changed. Support iteration over a string. Support strings with
8828 display properties. Support unibyte strings. Fix the type of
8829 `len' according to what STRING_CHAR_AND_LENGTH expects.
8830 (bidi_paragraph_init, bidi_resolve_explicit_1)
8831 (bidi_resolve_explicit, bidi_resolve_weak)
640c8776
SM
8832 (bidi_level_of_next_char, bidi_move_to_visually_next):
8833 Support iteration over a string.
0bb23927
EZ
8834 (bidi_set_sor_type, bidi_resolve_explicit_1)
8835 (bidi_resolve_explicit, bidi_type_of_next_char): ignore_bn_limit
8836 can now be zero (for strings); special values 0 and -1 were
8837 changed to -1 and -2, respectively.
8838 (bidi_char_at_pos): New function.
8839 (bidi_paragraph_init, bidi_resolve_explicit, bidi_resolve_weak):
8840 Call it instead of FETCH_MULTIBYTE_CHAR.
8841 (bidi_move_to_visually_next): Abort if charpos or bytepos were not
8842 initialized to valid values.
8843 (bidi_init_it): Don't initialize charpos and bytepos with invalid
8844 values.
8845 (bidi_level_of_next_char): Allow the sentinel "position" to pass
8846 the test for valid cached positions. Fix the logic for looking up
8847 the sentinel state in the cache. GCPRO the Lisp string we are
8848 iterating.
8849 (bidi_push_it, bidi_pop_it): New functions.
8850 (bidi_initialize): Initialize the bidi cache start stack pointer.
8851 (bidi_cache_ensure_space): New function, refactored from part of
8852 bidi_cache_iterator_state. Don't assume the required size is just
8853 one BIDI_CACHE_CHUNK away.
8854 (bidi_cache_start_stack, bidi_push_it): Use IT_STACK_SIZE.
8855 (bidi_count_bytes, bidi_char_at_pos): New functions.
8856 (bidi_cache_search): Don't assume bidi_cache_last_idx is
8857 always valid if bidi_cache_idx is valid.
8858 (bidi_cache_find_level_change): xassert that bidi_cache_last_idx
8859 is valid if it's going to be used.
8860 (bidi_shelve_cache, bidi_unshelve_cache): New functions.
8861 (bidi_cache_fetch_state, bidi_cache_search)
c965adc5
EZ
8862 (bidi_cache_find_level_change, bidi_cache_ensure_space)
8863 (bidi_cache_iterator_state, bidi_cache_find)
640c8776
SM
8864 (bidi_find_other_level_edge, bidi_cache_start_stack):
8865 All variables related to cache indices are now EMACS_INT.
c965adc5 8866
0bb23927
EZ
8867 * dispextern.h (struct bidi_string_data): New structure.
8868 (struct bidi_it): New member `string'. Make flag members be 1-bit
8869 fields, and put them last in the struct.
640c8776
SM
8870 (compute_display_string_pos, compute_display_string_end):
8871 Update prototypes.
0bb23927
EZ
8872 (bidi_push_it, bidi_pop_it): Add prototypes.
8873 (struct iterator_stack_entry): New members bidi_p,
8874 paragraph_embedding, and from_disp_prop_p.
8875 (struct it): Member bidi_p is now a bit field 1 bit wide.
640c8776
SM
8876 (bidi_shelve_cache, bidi_unshelve_cache):
8877 Declare prototypes.
0bb23927
EZ
8878
8879 * .gdbinit (xvectype, xvector, xcompiled, xchartable, xboolvector)
8880 (xpr, xfont, xbacktrace): Use "header.size" when accessing vectors
8881 and vector-like objects.
8882
8883 * dispnew.c (buffer_posn_from_coords): Save and restore the bidi
8884 cache around display iteration.
8885
8886 * window.c (Fwindow_end, window_scroll_pixel_based)
8887 (displayed_window_lines, Frecenter): Save and restore the bidi
8888 cache around display iteration.
8889
3bbd2265
LMI
88902011-07-14 Lars Magne Ingebrigtsen <larsi@gnus.org>
8891
8892 * editfns.c (Fdelete_region): Clarify the use of the named
8893 parameters (bug#6788).
8894
adc47434
MR
88952011-07-14 Martin Rudalics <rudalics@gmx.at>
8896
8897 * indent.c (Fvertical_motion): Set and restore w->pointm when
8898 saving and restoring the window's buffer (Bug#9006).
8899
837c31f8
LMI
89002011-07-13 Lars Magne Ingebrigtsen <larsi@gnus.org>
8901
8902 * editfns.c (Fstring_to_char): Clarify just what is returned
8903 (bug#6576). Text by Eli Zaretskii.
8904
ac389d0c
JB
89052011-07-13 Juanma Barranquero <lekktu@gmail.com>
8906
8907 * gnutls.c (init_gnutls_functions): Honor gnutls_log_level (bug#9059).
8908
0be0ce47
EZ
89092011-07-13 Eli Zaretskii <eliz@gnu.org>
8910
8911 * buffer.c (mmap_find): Fix a typo.
8912
cd18e7e3
JB
89132011-07-13 Johan Bockgård <bojohan@gnu.org>
8914
8915 Fix execution of x selection hooks.
8916 * xselect.c (Qx_lost_selection_functions)
8917 (Qx_sent_selection_functions): New vars.
8918 (syms_of_xselect): DEFSYM them.
8919 (x_handle_selection_request): Pass Qx_sent_selection_functions
8920 rather than Vx_sent_selection_functions to Frun_hook_with_args.
8921 (x_handle_selection_clear,x_clear_frame_selections):
8922 Pass Qx_lost_selection_functions rather than
8923 Vx_lost_selection_functions to Frun_hook_with_args.
8924
47ea7f44
PE
89252011-07-13 Paul Eggert <eggert@cs.ucla.edu>
8926
ac389d0c 8927 * buffer.c (Fget_buffer_create): Initialize inhibit_shrinking.
2941c447
PE
8928 The old code sometimes used this field without initializing it.
8929
47ea7f44
PE
8930 * alloc.c (gc_sweep): Don't read past end of array.
8931 In theory, the old code could also have corrupted Emacs internals,
8932 though it'd be very unlikely.
8933
bc985c87
AS
89342011-07-12 Andreas Schwab <schwab@linux-m68k.org>
8935
8936 * character.c (Fcharacterp): Don't advertise optional ignored
ac389d0c 8937 argument. (Bug#4026)
bc985c87 8938
0cf34688
LMI
89392011-07-12 Lars Magne Ingebrigtsen <larsi@gnus.org>
8940
b3dadd76
LMI
8941 * keymap.c (syms_of_keymap): Clarify that "modifier" is "modifier
8942 key" (bug#4257).
8943
0cf34688
LMI
8944 * window.c (Fset_window_start): Doc fix (bug#4199).
8945 (Fset_window_hscroll): Ditto.
8946
270768cd
PE
89472011-07-12 Paul Eggert <eggert@cs.ucla.edu>
8948
077e3dda 8949 Fix minor new problems caught by GCC 4.6.1.
270768cd 8950 * term.c (init_tty): Remove unused local.
490011a6 8951 * xsettings.c (store_monospaced_changed): Define this function only
077e3dda 8952 if (defined HAVE_GSETTINGS || defined HAVE_GCONF), as it's
490011a6 8953 not used otherwise.
270768cd 8954
b1f58454
CY
89552011-07-12 Chong Yidong <cyd@stupidchicken.com>
8956
8957 * xdisp.c (Vresize_mini_windows): Minor doc fix (Bug#3300).
8958
22b9578d
LMI
89592011-07-11 Lars Magne Ingebrigtsen <larsi@gnus.org>
8960
6e70ab07
LMI
8961 * xdisp.c (syms_of_xdisp): Make it explicit that the mini-windows
8962 are the mini-buffer and the echo area (bug#3320).
8963
22b9578d
LMI
8964 * term.c (init_tty): Remove support for supdup, c10 and perq
8965 terminals, which are no longer supported (bug#1482).
8966
8974cc9f
JB
89672011-07-10 Johan Bockgård <bojohan@gnu.org>
8968
8969 * xdisp.c (Ftool_bar_lines_needed): Fix WINDOWP check.
8970
a560d974
JD
89712011-07-10 Jan Djärv <jan.h.d@swipnet.se>
8972
8973 * xmenu.c (menu_highlight_callback): Only pass frame to show_help_event
8974 for non-popups (Bug#3642).
8975
1dae0f0a
AS
89762011-07-10 Andreas Schwab <schwab@linux-m68k.org>
8977
268c2c36 8978 * alloc.c (reset_malloc_hooks): Protoize.
1dae0f0a 8979 * buffer.c (mmap_init, mmap_find, mmap_free_1, mmap_enlarge)
268c2c36
AS
8980 (mmap_set_vars, mmap_alloc, mmap_free, mmap_realloc): Likewise.
8981 * cm.c (losecursor): Likewise.
1dae0f0a
AS
8982 * data.c (fmod): Likewise.
8983 * dispnew.c (swap_glyphs_in_rows): Likewise.
8984 * emacs.c (memory_warning_signal): Likewise.
8985 * floatfns.c (float_error): Likewise.
8986 * font.c (check_gstring, check_otf_features, otf_tag_symbol)
8987 (otf_open, font_otf_capability, generate_otf_features)
8988 (font_otf_DeviceTable, font_otf_ValueRecord, font_otf_Anchor):
8989 Likewise.
8990 * image.c (pbm_read_file): Likewise.
8991 * indent.c (string_display_width): Likewise.
8992 * intervals.c (check_for_interval, search_for_interval)
8993 (inc_interval_count, count_intervals, root_interval)
8994 (adjust_intervals_for_insertion, make_new_interval): Likewise.
8995 * lread.c (defalias): Likewise.
268c2c36 8996 * ralloc.c (r_alloc_check): Likewise.
1dae0f0a
AS
8997 * regex.c (set_image_of_range_1, set_image_of_range)
8998 (regex_grow_registers): Likewise.
8999 * sysdep.c (strerror): Likewise.
9000 * termcap.c (valid_filename_p, tprint, main): Likewise.
9001 * tparam.c (main): Likewise.
9002 * unexhp9k800.c (run_time_remap, save_data_space)
9003 (update_file_ptrs, read_header, write_header, calculate_checksum)
9004 (copy_file, copy_rest, display_header): Likewise.
9005 * widget.c (mark_shell_size_user_specified, create_frame_gcs):
9006 Likewise.
9007 * xdisp.c (check_it): Likewise.
9008 * xfaces.c (register_color, unregister_color, unregister_colors):
9009 Likewise.
9010 * xfns.c (print_fontset_result): Likewise.
9011 * xrdb.c (member, fatal, main): Likewise.
9012
99033785
PE
90132011-07-10 Paul Eggert <eggert@cs.ucla.edu>
9014
9015 Fix minor problems found by static checking (Bug#9031).
9016 * chartab.c (char_table_set_range, map_sub_char_table):
9017 Remove unused locals.
9018 (uniprop_table): Now static.
9019 * composite.c (_work_char): Remove unused static var.
9020
9cb2ac56
JB
90212011-07-09 Juanma Barranquero <lekktu@gmail.com>
9022
9023 * chartab.c (uniprop_table_uncompress): Remove unused local variable.
9024
f25661f0
JD
90252011-07-09 Jan Djärv <jan.h.d@swipnet.se>
9026
9027 * gtkutil.c (qttip_cb): Remove code without function.
9028
8278c4fe
EZ
90292011-07-09 Eli Zaretskii <eliz@gnu.org>
9030
9031 * w32.c (pthread_sigmask): New stub.
9032
1692ae2d 90332011-07-08 Paul Eggert <eggert@cs.ucla.edu>
123403e4 9034
8a6ebd58 9035 Use pthread_sigmask, not sigprocmask (Bug#9010).
123403e4
PE
9036 sigprocmask is portable only for single-threaded applications, and
9037 Emacs can be multi-threaded when it uses GTK.
1301ac26
PE
9038 * Makefile.in (LIB_PTHREAD_SIGMASK): New macro.
9039 (LIBES): Use it.
9040 * callproc.c (Fcall_process):
9041 * process.c (create_process):
9042 * sysdep.c (sys_sigblock, sys_sigunblock, sys_sigsetmask):
9043 Use pthread_sigmask, not sigprocmask.
123403e4 9044
1b854618
JD
90452011-07-08 Jan Djärv <jan.h.d@swipnet.se>
9046
9047 * gtkutil.c (qttip_cb): Set line wrap to FALSE for tooltip widget.
9048 (xg_prepare_tooltip): Revert text in x->ttip_lbl, margins was
9049 wrong (Bug#8591).
9050
3fe4b549
JD
90512011-07-08 Jan Djärv <jan.h.d@swipnet.se>
9052
0ce7e563
JD
9053 * gtkutil.c (xg_prepare_tooltip): Fix indentation and comment.
9054 Put text in x->ttip_lbl instead of gtk_tooltip_set_text (Bug#8591).
9055 (xg_hide_tooltip): Fix comment.
9056
3fe4b549
JD
9057 * nsterm.m (initFrameFromEmacs): Don't use ns_return_types
9058 in registerServicesMenuSendTypes.
9059 (validRequestorForSendType): Don't check ns_return_types.
9060
9061 * nsfns.m (Fx_open_connection): Put NSStringPboardType into
9062 ns_return_type.
9063
5df75e47
JR
90642011-07-08 Jason Rumney <jasonr@gnu.org>
9065
22610910
JR
9066 * w32term.c (x_make_frame_visible): Use SH_SHOWNORMAL rather than
9067 SH_SHOW for hidden windows (Bug#5482).
9068
5df75e47
JR
9069 * w32fns.c (w32_wnd_proc) [WM_TIMER, WM_SET_CURSOR]: Avoid using
9070 frame struct members of non-existent frames (Bug#6284).
9071
699c10bd
JD
90722011-07-08 Jan Djärv <jan.h.d@swipnet.se>
9073
4393663b
JD
9074 * nsterm.m (keyDown): Call to wantsToDelayTextChangeNotifications and
9075 variable firstTime not needed on OSX >= 10.6.
9076 (setPosition): setFloatValue:knobProportion: is deprecated on OSX
9077 >= 10.5. Use setKnobProportion, setDoubleValue.
9078
9079 * nsterm.h (MAC_OS_X_VERSION_10_3, MAC_OS_X_VERSION_10_4)
9080 (MAC_OS_X_VERSION_10_5): Define if not defined.
9081 (EmacsView, EmacsTooltip): Implements NSWindowDelegate on OSX >= 10.6.
9082 (EmacsMenu): Implements NSMenuDelegate on OSX >= 10.6.
9083 (EmacsToolbar): Implements NSToolbarDelegate on OSX >= 10.6.
9084
9085 * nsselect.m (ns_string_from_pasteboard): Don't use deprecated methods
090bd7cb 9086 cString and lossyCString on OSX >= 10.4.
4393663b 9087
58179cce 9088 * nsmenu.m (fillWithWidgetValue): Don't use deprecated method
4393663b
JD
9089 sizeToFit on OSX >= 10.2.
9090
9091 * nsimage.m (allocInitFromFile): Don't use deprecated method
9092 bestRepresentationForDevice on OSX >= 10.6.
9093
9094 * nsfns.m (check_ns_display_info): Cast to long and use %ld in error
9095 to avoid warning.
9096
9097 * emacs.c: Declare unexec_init_emacs_zone.
9098
a63e0781
JD
9099 * nsgui.h: Fix compiler warning about gnulib redefining verify.
9100
699c10bd
JD
9101 * nsselect.m (ns_get_local_selection): Change to extern (Bug#8842).
9102
9103 * nsmenu.m (ns_update_menubar): Remove useless setDelegate call
9104 on svcsMenu (Bug#8842).
9105
9106 * nsfns.m (Fx_open_connection): Remove NSStringPboardType from
9107 ns_return_types.
9108 (Fns_list_services): Just return Qnil on 10.6, code not working there.
9109
9110 * nsterm.m (QUTF8_STRING): Declare.
9111 (initFrameFromEmacs): Call registerServicesMenuSendTypes.
9112 (validRequestorForSendType): Return type is (id).
9113 Change indexOfObjectIdenticalTo to indexOfObject.
9114 Check if we have local selection before returning self (Bug#8842).
9115 (writeSelectionToPasteboard): Put local selection into paste board
9116 if we have a local selection (Bug#8842).
9117 (syms_of_nsterm): DEFSYM QUTF8_STRING.
9118
9119 * nsterm.h (MAC_OS_X_VERSION_10_6): Define here instead of nsterm.m.
9120 (ns_get_local_selection): Declare.
9121
54e10184
LMI
91222011-07-07 Lars Magne Ingebrigtsen <larsi@gnus.org>
9123
9888ff71
LMI
9124 * keymap.c (describe_map_tree): Don't insert a double newline at
9125 the end of the buffer (bug#1169) and return whether we inserted
9126 something.
9127
54e10184
LMI
9128 * callint.c (Fcall_interactively): Change "reading args" to
9129 "providing args" to try to clarify what it does (bug#1010).
9130
15fa4783
KH
91312011-07-07 Kenichi Handa <handa@m17n.org>
9132
9133 * composite.c (composition_compute_stop_pos): Ignore a static
9134 composition starting before CHARPOS (Bug#8915).
9135
9136 * xdisp.c (handle_composition_prop): Likewise.
9137
a8815b00
EZ
91382011-07-07 Eli Zaretskii <eliz@gnu.org>
9139
9140 * term.c (produce_glyphs) <xassert>: Allow IT_GLYPHLESS in it->what.
9141 (Bug#9015)
9142
ef7b981d 91432011-07-07 Kenichi Handa <handa@m17n.org>
c805dec0
KH
9144
9145 * character.h (unicode_category_t): New enum type.
9146
9147 * chartab.c (uniprop_decoder_t, uniprop_encoder_t): New types.
9148 (Qchar_code_property_table): New variable.
9149 (UNIPROP_TABLE_P, UNIPROP_GET_DECODER)
9150 (UNIPROP_COMPRESSED_FORM_P): New macros.
9151 (char_table_ascii): Uncompress the compressed values.
9152 (sub_char_table_ref): New arg is_uniprop. Callers changed.
9153 Uncompress the compressed values.
ac389d0c 9154 (sub_char_table_ref_and_range): Likewise.
c805dec0
KH
9155 (char_table_ref_and_range): Uncompress the compressed values.
9156 (sub_char_table_set): New arg is_uniprop. Callers changed.
9157 Uncompress the compressed values.
9158 (sub_char_table_set_range): Args changed. Callers changed.
9159 (char_table_set_range): Adjuted for the above change.
9160 (map_sub_char_table): Delete args default_val and parent. Add arg
9161 top. Give decoded values to a Lisp function.
640c8776 9162 (map_char_table): Adjust for the above change. Give decoded
c805dec0
KH
9163 values to a Lisp function. Gcpro more variables.
9164 (uniprop_table_uncompress)
9165 (uniprop_decode_value_run_length): New functions.
9166 (uniprop_decoder, uniprop_decoder_count): New variables.
9167 (uniprop_get_decoder, uniprop_encode_value_character)
9168 (uniprop_encode_value_run_length, uniprop_encode_value_numeric):
9169 New functions.
9170 (uniprop_encoder, uniprop_encoder_count): New variables.
9171 (uniprop_get_encoder, uniprop_table)
9172 (Funicode_property_table_internal, Fget_unicode_property_internal)
9173 (Fput_unicode_property_internal): New functions.
9174 (syms_of_chartab): DEFSYM Qchar_code_property_table, defsubr
9175 Sunicode_property_table_internal, Sget_unicode_property_internal,
5e617bc2 9176 and Sput_unicode_property_internal. Defvar_lisp
c805dec0
KH
9177 char-code-property-alist.
9178
640c8776 9179 * composite.c (CHAR_COMPOSABLE_P): Adjust for the change of
c805dec0
KH
9180 Vunicode_category_table.
9181
640c8776 9182 * font.c (font_range): Adjust for the change of
c805dec0
KH
9183 Vunicode_category_table.
9184
76b397fb
DN
91852011-07-07 Dan Nicolaescu <dann@ics.uci.edu>
9186
9187 * m/iris4d.h: Remove file, move contents ...
9188 * s/irix6-5.h: ... here.
9189
22b4128e
PE
91902011-07-06 Paul Eggert <eggert@cs.ucla.edu>
9191
9192 Remove unportable assumption about struct layout (Bug#8884).
8a5c77bb
PE
9193 * alloc.c (mark_buffer):
9194 * buffer.c (reset_buffer_local_variables, Fbuffer_local_variables)
9195 (clone_per_buffer_values): Don't assume that
22b4128e
PE
9196 sizeof (struct buffer) is a multiple of sizeof (Lisp_Object).
9197 This isn't true in general, and it's particularly not true
9198 if Emacs is configured with --with-wide-int.
9199 * buffer.h (FIRST_FIELD_PER_BUFFER, LAST_FIELD_PER_BUFFER):
9200 New macros, used in the buffer.c change.
9201
869795d6
JD
92022011-07-05 Jan Djärv <jan.h.d@swipnet.se>
9203
9204 * xsettings.c: Use both GConf and GSettings if both are available.
9205 (store_config_changed_event): Add comment.
9206 (dpyinfo_valid, store_font_name_changed, map_tool_bar_style)
9207 (store_tool_bar_style_changed): New functions.
5e617bc2 9208 (store_monospaced_changed): Add comment. Call dpyinfo_valid.
869795d6
JD
9209 (struct xsettings): Move font inside HAVE_XFT.
9210 (GSETTINGS_TOOL_BAR_STYLE, GSETTINGS_FONT_NAME): New defines.
640c8776 9211 (GSETTINGS_MONO_FONT): Rename from SYSTEM_MONO_FONT.
869795d6 9212 Move inside HAVE_XFT.
640c8776 9213 (something_changed_gsettingsCB): Rename from something_changedCB.
869795d6
JD
9214 Check for changes in GSETTINGS_TOOL_BAR_STYLE and GSETTINGS_FONT_NAME
9215 also.
9216 (GCONF_TOOL_BAR_STYLE, GCONF_FONT_NAME): New defines.
5e617bc2 9217 (GCONF_MONO_FONT): Rename from SYSTEM_MONO_FONT. Move inside HAVE_XFT.
640c8776 9218 (something_changed_gconfCB): Rename from something_changedCB.
869795d6
JD
9219 Check for changes in GCONF_TOOL_BAR_STYLE and GCONF_FONT_NAME also.
9220 (parse_settings): Move check for font inside HAVE_XFT.
9221 (read_settings, apply_xft_settings): Add comment.
9222 (read_and_apply_settings): Add comment. Call map_tool_bar_style and
9223 store_tool_bar_style_changed. Move check for font inside HAVE_XFT and
9224 call store_font_name_changed.
9225 (xft_settings_event): Add comment.
9226 (init_gsettings): Add comment. Get values for GSETTINGS_TOOL_BAR_STYLE
9227 and GSETTINGS_FONT_NAME. Move check for fonts within HAVE_XFT.
9228 (init_gconf): Add comment. Get values for GCONF_TOOL_BAR_STYLE
9229 and GCONF_FONT_NAME. Move check for fonts within HAVE_XFT.
9230 (xsettings_initialize): Call init_gsettings last.
640c8776
SM
9231 (xsettings_get_system_font, xsettings_get_system_normal_font):
9232 Add comment.
869795d6 9233
d8ed26bd
PE
92342011-07-05 Paul Eggert <eggert@cs.ucla.edu>
9235
9236 Random fixes. E.g., (random) never returned negative values.
9237 * fns.c (Frandom): Use GET_EMACS_TIME for random seed, and add the
9238 subseconds part to the entropy, as that's a bit more random.
9239 Prefer signed to unsigned, since the signedness doesn't matter and
9240 in general we prefer signed. When given a limit, use a
9241 denominator equal to INTMASK + 1, not to VALMASK + 1, because the
9242 latter isn't right if USE_2_TAGS_FOR_INTS.
9243 * sysdep.c (get_random): Return a value in the range 0..INTMASK,
9244 not 0..VALMASK. Don't discard "excess" bits that random () returns.
9245
cabf1cac
SM
92462011-07-04 Stefan Monnier <monnier@iro.umontreal.ca>
9247
9248 * textprop.c (text_property_stickiness):
9249 Obey Vtext_property_default_nonsticky.
9250 (syms_of_textprop): Add `display' to Vtext_property_default_nonsticky.
9251 * w32fns.c (syms_of_w32fns):
9252 * xfns.c (syms_of_xfns): Don't Add `display' since it's there by default.
9253
6e9b2be9
PE
92542011-07-04 Paul Eggert <eggert@cs.ucla.edu>
9255
9256 * fileio.c (barf_or_query_if_file_exists): Use S_ISDIR.
9257 This is more efficient than Ffile_directory_p and avoids a minor race.
9258
90186c68
LMI
92592011-07-04 Lars Magne Ingebrigtsen <larsi@gnus.org>
9260
7c301272
LMI
9261 * buffer.c (Foverlay_put): Say what the return value is
9262 (bug#7835).
9263
c4f2d8d4
LMI
9264 * fileio.c (barf_or_query_if_file_exists): Check first if the file
9265 is a directory before asking whether to use the file name
9266 (bug#7564).
ad637907
LMI
9267 (barf_or_query_if_file_exists): Make the "File is a directory"
9268 error be more correct.
c4f2d8d4 9269
90186c68
LMI
9270 * fns.c (Frequire): Remove the mention of the .gz files, since
9271 that's installation-specific, but keep the mention of
9272 `get-load-suffixes'.
9273
da64016e
PE
92742011-07-04 Paul Eggert <eggert@cs.ucla.edu>
9275
9276 * editfns.c (Fformat_time_string): Don't assume strlen fits in int.
9277 Report string overflow if the output is too long.
9278
7d47b580
JB
92792011-07-04 Juanma Barranquero <lekktu@gmail.com>
9280
a555cb87
JB
9281 * gnutls.c (Fgnutls_boot): Don't mention :verify-error.
9282 (syms_of_gnutls): Remove duplicate DEFSYM for
9283 Qgnutls_bootprop_verify_hostname_error, an error for
9284 Qgnutls_bootprop_verify_error (which is no longer used).
9285
7d47b580
JB
9286 * eval.c (find_handler_clause): Remove parameters `sig' and `data',
9287 unused since 2011-01-26T20:02:07Z!monnier@iro.umontreal.ca. All callers changed.
9288 Also (re)move comments that are misplaced or no longer relevant.
9289
1e49bfab
LMI
92902011-07-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
9291
9292 * callint.c (Finteractive): Clarify the meaning of "@" (bug#8813).
9293
1485f4c0
CY
92942011-07-03 Chong Yidong <cyd@stupidchicken.com>
9295
9296 * xfaces.c (Finternal_merge_in_global_face): Modify the foreground
9297 and background color parameters if they have been changed.
9298
a9ab721e
LMI
92992011-07-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
9300
9301 * editfns.c (Fformat): Clarify the - and 0 flags (bug#6659).
9302
cf7cff57
PE
93032011-07-03 Paul Eggert <eggert@cs.ucla.edu>
9304
2e13213d
PE
9305 * xsettings.c (SYSTEM_FONT): Define only when used.
9306 No need to define when HAVE_GSETTINGS || !HAVE_XFT.
9307
cf7cff57
PE
9308 * keymap.c (access_keymap_1): Now static.
9309
7a8e04f7
CY
93102011-07-02 Chong Yidong <cyd@stupidchicken.com>
9311
9312 * keyboard.c (command_loop_1): If a down-mouse event is unbound,
9313 leave any prefix arg for the up event (Bug#1586).
9314
61352f62
LMI
93152011-07-02 Lars Magne Ingebrigtsen <larsi@gnus.org>
9316
69bb1ef7
LMI
9317 * lread.c (syms_of_lread): Mention single symbols defined by
9318 `defvar' or `defconst' (bug#7154).
9319
61352f62 9320 * fns.c (Frequire): Mention .el.gz files (bug#7314).
7b3747f9 9321 (Frequire): Mention get-load-suffixes.
61352f62 9322
28545e04
MR
93232011-07-02 Martin Rudalics <rudalics@gmx.at>
9324
9325 * window.h (window): Remove clone_number slot.
9326 * window.c (Fwindow_clone_number, Fset_window_clone_number):
9327 Remove.
9328 (make_parent_window, make_window, saved_window)
9329 (Fset_window_configuration, save_window_save): Don't deal with
9330 clone numbers.
9331 * buffer.c (Qclone_number): Remove declaration.
9332 (sort_overlays, overlay_strings): Don't deal with clone numbers.
9333
3349e122
SM
93342011-07-02 Stefan Monnier <monnier@iro.umontreal.ca>
9335
9336 Add multiple inheritance to keymaps.
9337 * keymap.c (Fmake_composed_keymap): New function.
9338 (Fset_keymap_parent): Simplify.
9339 (fix_submap_inheritance): Remove.
9340 (access_keymap_1): New function extracted from access_keymap to handle
9341 embedded parents and handle lists of maps.
9342 (access_keymap): Use it.
9343 (Fkeymap_prompt, map_keymap_internal, map_keymap, store_in_keymap)
9344 (Fcopy_keymap): Handle embedded parents.
9345 (Fcommand_remapping, define_as_prefix): Simplify.
9346 (Fkey_binding): Simplify.
9347 (syms_of_keymap): Move minibuffer-local-completion-map,
9348 minibuffer-local-filename-completion-map,
9349 minibuffer-local-must-match-map, and
9350 minibuffer-local-filename-must-match-map to Elisp.
9351 (syms_of_keymap): Defsubr make-composed-keymap.
9352 * keyboard.c (menu_bar_items): Use map_keymap_canonical.
9353 (parse_menu_item): Trivial simplification.
9354
3279eb87
GM
93552011-07-01 Glenn Morris <rgm@gnu.org>
9356
9357 * Makefile.in (SETTINGS_LIBS): Fix typo.
9358
4550efdf
KI
93592011-07-01 Kazuhiro Ito <kzhr@d1.dion.ne.jp> (tiny patch)
9360
9361 * coding.c (Fencode_coding_string): Record the last coding system
9362 used, as the function doc string says (bug#8738).
9363
0949d2b6
JD
93642011-07-01 Jan Djärv <jan.h.d@swipnet.se>
9365
9366 * xsettings.c (store_monospaced_changed): Take new font as arg and
9367 check for change against current_mono_font.
9368 (EMACS_TYPE_SETTINGS): Remove this and related defines.
9369 (emacs_settings_constructor, emacs_settings_get_property)
9370 (emacs_settings_set_property, emacs_settings_class_init)
9371 (emacs_settings_init, gsettings_obj): Remove.
9372 (something_changedCB): New function for HAVE_GSETTINGS.
9373 (something_changedCB): HAVE_GCONF: Call store_monospaced_changed
9374 with value as argument.
9375 (init_gsettings): Check that GSETTINGS_SCHEMA exists before calling
9376 g_settings_new (Bug#8967). Do not create gsettings_obj.
9173deec 9377 Remove calls to g_settings_bind. Connect something_changedCB to
0949d2b6
JD
9378 "changed".
9379
9380 * xgselect.c: Add defined (HAVE_GSETTINGS).
9381 (xgselect_initialize): Ditto.
9382
9383 * process.c: Add defined (HAVE_GSETTINGS) for xgselect.h
9384 (wait_reading_process_output): Add defined (HAVE_GSETTINGS) for
9385 xg_select.
9386
bbc6b304
PE
93872011-07-01 Paul Eggert <eggert@cs.ucla.edu>
9388
9389 * eval.c (struct backtrace): Simplify and port the data structure.
9390 Do not assume that "int nargs : BITS_PER_INT - 2;" produces a
9391 signed bit field, as this assumption is not portable and it makes
9392 Emacs crash when compiled with Sun C 5.8 on sparc. Do not use
9393 "char debug_on_exit : 1" as this is not portable either; instead,
9394 use the portable "unsigned int debug_on_exit : 1". Remove unused
9395 member evalargs. Remove obsolete comments about cc bombing out.
9396
9851bfc5
JD
93972011-06-30 Jan Djärv <jan.h.d@swipnet.se>
9398
51bb811f 9399 * xsettings.c: Include glib-object.h, gio/gio.h if HAVE_GSETTINGS.
9851bfc5
JD
9400 Let HAVE_GSETTINGS override HAVE_GCONF.
9401 (store_monospaced_changed): New function.
9402 (EMACS_SETTINGS): A new type derived from GObject to handle
9403 GSettings notifications.
9404 (emacs_settings_constructor, emacs_settings_get_property)
9405 (emacs_settings_set_property, emacs_settings_class_init):
9406 New functions.
9407 (gsettings_client, gsettings_obj): New variables.
9408 (GSETTINGS_SCHEMA): New define.
9409 (something_changedCB): Call store_monospaced_changed.
9410 (init_gsettings): New function.
9411 (xsettings_initialize): Call init_gsettings.
9412 (syms_of_xsettings): Initialize gsettings_client, gsettings_obj
9413 to NULL.
9414
640c8776 9415 * Makefile.in (SETTINGS_CFLAGS, SETTINGS_LIBS): Rename from
9851bfc5
JD
9416 GCONF_CFLAGS/LIBS.
9417
5386012d
MR
94182011-06-29 Martin Rudalics <rudalics@gmx.at>
9419
9420 * window.c (resize_root_window, grow_mini_window)
9421 (shrink_mini_window): Rename Qresize_root_window to
9422 Qwindow_resize_root_window and Qresize_root_window_vertically to
9423 Qwindow_resize_root_window_vertically.
9424
f13e0b08
PE
94252011-06-28 Paul Eggert <eggert@cs.ucla.edu>
9426
9427 * gnutls.c (Qgnutls_bootprop_verify_error): Remove unused var.
9428
94515237
JB
94292011-06-27 Juanma Barranquero <lekktu@gmail.com>
9430
9431 * makefile.w32-in: Redesign dependencies so they reflect more
9432 clearly which files are directly included by each source file,
9433 and not through other includes.
9434
e43b6e43
MR
94352011-06-27 Martin Rudalics <rudalics@gmx.at>
9436
9437 * buffer.c (Qclone_number): Declare static and DEFSYM it.
9438 (sort_overlays, overlay_strings): When an overlay's clone number
9439 matches the window's clone number process the overlay even if
9440 the overlay's window property doesn't match the current window.
9441
d68443dc
MR
9442 * window.c (Fwindow_vchild): Rename to Fwindow_top_child.
9443 (Fwindow_hchild): Rename to Fwindow_left_child.
9444 (Fwindow_next): Rename to Fwindow_next_sibling.
9445 (Fwindow_prev): Rename to Fwindow_prev_sibling.
d615d6d2
MR
9446 (resize_window_check): Rename to window_resize_check.
9447 (resize_window_apply): Rename to window_resize_apply.
9448 (Fresize_window_apply): Rename to Fwindow_resize_apply.
9449 (Fdelete_other_windows_internal, resize_frame_windows)
9450 (Fsplit_window_internal, Fdelete_window_internal)
9451 (grow_mini_window, shrink_mini_window)
9452 (Fresize_mini_window_internal): Fix callers accordingly.
d68443dc 9453
c7e73be5
JD
94542011-06-26 Jan Djärv <jan.h.d@swipnet.se>
9455
9456 * emacsgtkfixed.h: State that this is only used with Gtk+3.
9457 (emacs_fixed_set_min_size): Remove.
9458 (emacs_fixed_new): Take frame as argument.
9459
9460 * emacsgtkfixed.c: State that this is only used with Gtk+3.
9461 (_EmacsFixedPrivate): Remove minwidth/height.
9462 Add struct frame *f.
9463 (emacs_fixed_init): Initialize priv->f.
9464 (get_parent_class, emacs_fixed_set_min_size): Remove.
9465 (emacs_fixed_new): Set priv->f to argument.
9466 (emacs_fixed_get_preferred_width)
9467 (emacs_fixed_get_preferred_height): Use min_width/height from
9468 frames size_hint to set minimum and natural (Bug#8919).
9469 (XSetWMSizeHints, XSetWMNormalHints): Override these functions
9470 and use min_width/height from frames size_hint to set
9471 min_width/height (Bug#8919).
9472
9473 * gtkutil.c (xg_create_frame_widgets): Pass f to emacs_fixed_new.
9173deec
JB
9474 (x_wm_set_size_hint): Remove call to emacs_fixed_set_min_size.
9475 Fix indentation.
c7e73be5 9476
cf99dcf8
EZ
94772011-06-26 Eli Zaretskii <eliz@gnu.org>
9478
9479 * bidi.c (bidi_paragraph_init): Test for ZV_BYTE before calling
9480 bidi_at_paragraph_end, since fast_looking_at doesn't like to be
9481 called at ZV.
9482
029529ac
CY
94832011-06-26 Chong Yidong <cyd@stupidchicken.com>
9484
9485 * process.c (wait_reading_process_output): Bypass select if
9486 waiting for a cell while ignoring keyboard input, and input is
9487 pending. Suggested by Jan Djärv (Bug#8869).
9488
7a7ef429
PE
94892011-06-25 Paul Eggert <eggert@cs.ucla.edu>
9490
9491 Use gnulib's dup2 module instead of rolling our own.
9492 * sysdep.c (dup2) [!HAVE_DUP2]: Remove; gnulib now does this.
9493
11fdef7d 94942011-06-25 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
989b42d2
YM
9495
9496 * dispnew.c (scrolling_window): Before scrolling, turn off a
9497 mouse-highlight in the window being scrolled.
9498
cd3520a4
JB
94992011-06-24 Juanma Barranquero <lekktu@gmail.com>
9500
9501 Move DEFSYM to lisp.h and use everywhere.
9502
9503 * character.h (DEFSYM): Move declaration...
9504 * lisp.h (DEFSYM): ...here.
9505
9506 * gnutls.c:
9507 * minibuf.c:
9508 * w32menu.c:
9509 * w32proc.c:
9510 * w32select.c: Don't include character.h.
9511
9512 * alloc.c (syms_of_alloc):
9513 * buffer.c (syms_of_buffer):
9514 * bytecode.c (syms_of_bytecode):
9515 * callint.c (syms_of_callint):
9516 * casefiddle.c (syms_of_casefiddle):
9517 * casetab.c (init_casetab_once):
9518 * category.c (init_category_once, syms_of_category):
9519 * ccl.c (syms_of_ccl):
9520 * cmds.c (syms_of_cmds):
9521 * composite.c (syms_of_composite):
9522 * dbusbind.c (syms_of_dbusbind):
9523 * dired.c (syms_of_dired):
9524 * dispnew.c (syms_of_display):
9525 * doc.c (syms_of_doc):
9526 * editfns.c (syms_of_editfns):
9527 * emacs.c (syms_of_emacs):
9528 * eval.c (syms_of_eval):
9529 * fileio.c (syms_of_fileio):
9530 * fns.c (syms_of_fns):
9531 * frame.c (syms_of_frame):
9532 * fringe.c (syms_of_fringe):
9533 * insdel.c (syms_of_insdel):
9534 * keymap.c (syms_of_keymap):
9535 * lread.c (init_obarray, syms_of_lread):
9536 * macros.c (syms_of_macros):
9537 * msdos.c (syms_of_msdos):
9538 * print.c (syms_of_print):
9539 * process.c (syms_of_process):
9540 * search.c (syms_of_search):
9541 * sound.c (syms_of_sound):
9542 * syntax.c (init_syntax_once, syms_of_syntax):
9543 * terminal.c (syms_of_terminal):
9544 * textprop.c (syms_of_textprop):
9545 * undo.c (syms_of_undo):
9546 * w32.c (globals_of_w32):
9547 * window.c (syms_of_window):
9548 * xdisp.c (syms_of_xdisp):
9549 * xfaces.c (syms_of_xfaces):
9550 * xfns.c (syms_of_xfns):
9551 * xmenu.c (syms_of_xmenu):
9552 * xsettings.c (syms_of_xsettings):
9553 * xterm.c (syms_of_xterm): Use DEFSYM.
9554
4228cf16
TZ
95552011-06-24 Teodor Zlatanov <tzz@lifelogs.com>
9556
cd3520a4 9557 * gnutls.c (syms_of_gnutls): Use the DEFSYM macro from character.h.
4228cf16 9558
7fcccf1e
PE
95592011-06-23 Paul Eggert <eggert@cs.ucla.edu>
9560
7efb4e0e
PE
9561 Integer and buffer overflow fixes (Bug#8873).
9562
ff5844ad
PE
9563 * print.c (printchar, strout): Check for string overflow.
9564 (PRINTPREPARE, printchar, strout):
9565 Don't set size unless allocation succeeds.
9566
90532f02
PE
9567 * minibuf.c (read_minibuf_noninteractive): Use ptrdiff_t, not int,
9568 for sizes. Check for string overflow more accurately.
9569 Simplify newline removal at end; this suppresses a GCC 4.6.0 warning.
9570
6d84508d
PE
9571 * macros.c: Integer and buffer overflow fixes.
9572 * keyboard.h (struct keyboard.kbd_macro_bufsize):
9573 * macros.c (Fstart_kbd_macro, store_kbd_macro_char):
9574 Use ptrdiff_t, not int, for sizes.
9575 Don't increment bufsize until after realloc succeeds.
9576 Check for size-calculation overflow.
9577 (Fstart_kbd_macro): Use EMACS_INT, not int, for XINT result.
9578
437b2cb4
PE
9579 * lisp.h (DEFVAR_KBOARD): Use offsetof instead of char * finagling.
9580
8b9ac8b4
PE
9581 * lread.c: Integer overflow fixes.
9582 (read_integer): Radix is now EMACS_INT, not int,
9583 to improve quality of diagnostics for out-of-range radices.
9584 Calculate buffer size correctly for out-of-range radices.
9585 (read1): Check for integer overflow in radices, and in
9586 read-circle numbers.
82cb60d3
PE
9587 (read_escape): Avoid int overflow.
9588 (Fload, openp, read_buffer_size, read1)
9589 (substitute_object_recurse, read_vector, read_list, map_obarray):
9590 Use ptrdiff_t, not int, for sizes.
9591 (read1): Use EMACS_INT, not int, for sizes.
20270765 9592 Check for size overflow.
8b9ac8b4 9593
7fcccf1e
PE
9594 * image.c (cache_image): Check for size arithmetic overflow.
9595
bfbbd7e7
PE
9596 * lread.c: Integer overflow issues.
9597 (saved_doc_string_size, saved_doc_string_length)
9598 (prev_saved_doc_string_size, prev_saved_doc_string_length):
9599 Now ptrdiff_t, not int.
9600 (read1): Don't assume doc string length fits in int. Check for
9601 out-of-range doc string lengths.
9602 (read_list): Don't assume file position fits in int.
39019e54 9603 (read_escape): Check for hex character overflow.
bfbbd7e7 9604
4e323265
LL
96052011-06-22 Leo Liu <sdl.web@gmail.com>
9606
9607 * minibuf.c (Fcompleting_read_default, Vcompleting_read_function):
9608 Move to minibuffer.el.
9609
85fece3e
PE
96102011-06-22 Paul Eggert <eggert@cs.ucla.edu>
9611
20b84ce9 9612 Fixes for GLYPH_DEBUG found by GCC 4.6.0 static checking.
85fece3e
PE
9613 The following patches are for when GLYPH_DEBUG && !XASSERT.
9614 * dispextern.h (trace_redisplay_p, dump_glyph_string):
9615 * dispnew.c (flush_stdout):
9616 * xdisp.c (dump_glyph_row, dump_glyph_matrix, dump_glyph):
9617 Mark as externally visible.
9618 * dispnew.c (check_window_matrix_pointers): Now static.
9619 * dispnew.c (window_to_frame_vpos):
9620 * xfns.c (unwind_create_frame):
9621 * xterm.c (x_check_font): Remove unused local.
9622 * scroll.c (CHECK_BOUNDS):
9623 * xfaces.c (cache_fache): Rename local to avoid shadowing.
9624 * xfns.c, w32fns.c (image_cache_refcount, dpyinfo_refcount): Now static.
9625 * xdisp.c (check_window_end): Now a no-op if !XASSERTS.
9626 (debug_first_unchanged_at_end_vpos, debug_last_unchanged_at_beg_vpos)
9627 (debug_dvpos, debug_dy, debug_delta, debug_delta_bytes, debug_end_vpos):
9628 Now static.
9629 (debug_method_add): Use va_list and vsprintf rather than relying
9630 on undefined behavior with wrong number of arguments.
9631 (dump_glyph, dump_glyph_row, Fdump_glyph_matrix):
9632 Don't assume ptrdiff_t and EMACS_INT are the same width as int.
9633 In this code, it's OK to assume C99 behavior for ptrdiff_t formats
9634 since we're not interested in debugging glyphs with old libraries.
9635 * xfaces.c (cache_face): Move debugging code earlier; this pacifies
9636 GCC 4.6.0's static checking.
9637
0766b489
PE
96382011-06-22 Paul Eggert <eggert@cs.ucla.edu>
9639
31fd4b32
PE
9640 Integer overflow and signedness fixes (Bug#8873).
9641 A few related buffer overrun fixes, too.
9642
b79e8648
PE
9643 * font.c (font_score): Use EMACS_INT, not int, to store XINT value.
9644
0766b489
PE
9645 * dispextern.h (struct face.stipple):
9646 * image.c (x_bitmap_height, x_bitmap_width, x_bitmap_pixmap)
9647 (x_bitmap_mask, x_allocate_bitmap_record)
9648 (x_create_bitmap_from_data, x_create_bitmap_from_file)
9649 (x_destroy_bitmap, x_destroy_all_bitmaps, x_create_bitmap_mask)
9650 (x_create_bitmap_from_xpm_data):
9651 * nsterm.h (struct ns_display_info.bitmaps_size, .bitmaps_last):
9652 * w32term.h (struct w32_display_info.icon_bitmap_id, .bitmaps_size)
9653 (.bitmaps_last):
9654 * xfaces.c (load_pixmap):
9655 * xterm.c (x_bitmap_icon, x_wm_set_icon_pixmap):
9656 * xterm.h (struct x_display_info.icon_bitmap_id, .bitmaps_size)
9657 (.bitmaps_last, struct x_output.icon_bitmap):
9658 Use ptrdiff_t, not int, for bitmap indexes.
9659 (x_allocate_bitmap_record): Check for size overflow.
9660 * dispextern.h, lisp.h: Adjust to API changes elsewhere.
9661
b081724f
PE
9662 Use ptrdiff_t, not int, for overlay counts.
9663 * buffer.h (overlays_at, sort_overlays, GET_OVERLAYS_AT):
9664 * editfns.c (overlays_around, get_pos_property):
9665 * textprop.c (get_char_property_and_overlay):
9666 * xdisp.c (next_overlay_change, note_mouse_highlight):
9667 * xfaces.c (face_at_buffer_position):
21514da7
PE
9668 * buffer.c (OVERLAY_COUNT_MAX): New macro.
9669 (overlays_at, overlays_in, sort_overlays, Foverlays_at)
9670 (Fnext_overlay_change, Fprevious_overlay_change)
9671 (mouse_face_overlay_overlaps, Foverlays_in):
b081724f 9672 Use ptrdiff_t, not int, for sizes.
21514da7 9673 (overlays_at, overlays_in): Check for size-calculation overflow.
b081724f 9674
3de73e5e
PE
9675 * xterm.c (xim_initialize, same_x_server): Strlen may not fit in int.
9676
2606c57b
PE
9677 * xsmfns.c (smc_save_yourself_CB, x_session_initialize): Avoid strlen.
9678 (x_session_initialize): Do not assume string length fits in int.
9679
aaafe47a
PE
9680 * xsettings.c (apply_xft_settings): Fix potential buffer overrun.
9681 This is unlikely, but can occur if DPI is outlandish.
9682
2674ddc8 9683 * xsettings.c (Ffont_get_system_normal_font, Ffont_get_system_font):
3a5077c5
PE
9684 * xselect.c (Fx_get_atom_name): Avoid need for strlen.
9685
28154962
PE
9686 * xrdb.c: Don't assume strlen fits in int; avoid some strlens.
9687 * xrdb.c (magic_file_p, search_magic_path):
9688 Omit last arg SUFFIX; it was always 0. All callers changed.
9689 (magic_file_p): Use ptrdiff_t, not int. Check for size overflow.
9690
7de51af5
PE
9691 * xfont.c (xfont_match): Avoid need for strlen.
9692
25ed6cc3
PE
9693 * xfns.c: Don't assume strlen fits in int.
9694 (xic_create_fontsetname, x_window): Use ptrdiff_t, not int.
9695
4eab31dd
PE
9696 * xdisp.c (message_log_check_duplicate): Return intmax_t,
9697 not unsigned long, as we prefer signed integers. All callers changed.
9698 Detect integer overflow in repeat count.
9699 (message_dolog): Don't assume print length fits in 39 bytes.
df1f27af 9700 (display_mode_element): Don't assume strlen fits in int.
4eab31dd 9701
171e2a58
PE
9702 * termcap.c: Don't assume sizes fit in int and never overflow.
9703 (struct termcap_buffer, tgetent): Use ptrdiff_t, not int, for sizes.
9704 (gobble_line): Check for size-calculation overflow.
9705
ad39faca 9706 * minibuf.c (Fread_buffer):
6e5bb2dc 9707 * lread.c (intern, intern_c_string):
74ca2eb3
PE
9708 * image.c (xpm_scan) [HAVE_NS && !HAVE_XPM]:
9709 Don't assume string length fits in int.
9710
52c61c22 9711 * keyboard.c (parse_tool_bar_item):
9bda3520
PE
9712 * gtkutil.c (style_changed_cb): Avoid need for strlen.
9713
b5b8c9e5
PE
9714 * font.c: Don't assume string length fits in int.
9715 (font_parse_xlfd, font_parse_fcname, font_unparse_fcname):
9716 Use ptrdiff_t, not int.
ccd6111c
PE
9717 (font_intern_prop): Don't assume string length fits in int.
9718 Don't assume integer property fits in fixnum.
9719 * font.h (font_intern_prop): 2nd arg is now ptrdiff_t, not int.
b5b8c9e5 9720
882f0d81 9721 * filelock.c: Fix some buffer overrun and integer overflow issues.
51cab52b 9722 (get_boot_time): Don't assume gzip command string fits in 100 bytes.
882f0d81
PE
9723 Reformulate so as not to need the command string.
9724 Invoke gzip -cd rather than gunzip, as it's more portable.
9725 (lock_info_type, lock_file_1, lock_file):
9726 Don't assume pid_t and time_t fit in unsigned long.
9727 (LOCK_PID_MAX): Remove; we now use more-reliable bounds.
9728 (current_lock_owner): Prefer signed type for sizes.
9729 Use memcpy, not strncpy, where memcpy is what is really wanted.
9730 Don't assume (via atoi) that time_t and pid_t fit in int.
9731 Check for time_t and/or pid_t out of range, e.g., via a network share.
9732 Don't alloca where an auto var works fine.
9733
93f4cf88
PE
9734 * fileio.c: Fix some integer overflow issues.
9735 (file_name_as_directory, Fexpand_file_name, Fsubstitute_in_file_name):
9736 Don't assume string length fits in int.
9737 (directory_file_name): Don't assume string length fits in long.
9738 (make_temp_name): Don't assume pid fits in int, or that its print
9739 length is less than 20.
9740
f3e92b69
PE
9741 * data.c (Fsubr_name): Rewrite to avoid a strlen call.
9742
1bfdaf10
PE
9743 * coding.c (make_subsidiaries): Don't assume string length fits in int.
9744
35016e9a
PE
9745 * callproc.c (child_setup): Rewrite to avoid two strlen calls.
9746
3d1e65a1
PE
9747 * process.c (Fformat_network_address): Use EMACS_INT, not EMACS_UINT.
9748 We prefer signed integers, even for size calculations.
9749
0b963a93
PE
9750 * emacs.c: Don't assume string length fits in 'int'.
9751 (DEFINE_DUMMY_FUNCTION, sort_args): Use ptrdiff_t, not int.
9752 (main): Don't invoke strlen when not needed.
9753
573f4b54
PE
9754 * dbusbind.c (XD_ERROR): Don't arbitrarily truncate string.
9755 (XD_DEBUG_MESSAGE): Don't waste a byte.
9756
989f33ba
PE
9757 * callproc.c (getenv_internal_1, getenv_internal)
9758 (Fgetenv_internal):
965d34eb
PE
9759 * buffer.c (init_buffer): Don't assume string length fits in 'int'.
9760
e4d29b33
PE
9761 * lread.c (invalid_syntax): Omit length argument.
9762 All uses changed. This doesn't fix a bug, but it simplifies the
9763 code away from its former Hollerith-constant appearance, and it's
9764 one less 'int' to worry about when looking at integer-overflow issues.
51cab52b 9765 (string_to_number): Simplify 2011-04-26 change by invoking xsignal1.
e4d29b33 9766
eb49b136
PE
9767 * lisp.h (DEFUN): Remove bogus use of sizeof (struct Lisp_Subr).
9768 This didn't break anything, but it didn't help either.
9769 It's confusing to put a bogus integer in a place where the actual
9770 value does not matter.
9f62aeb1 9771 (LIST_END_P): Remove unused macro and its bogus comment.
cbeff735 9772 (make_fixnum_or_float): Remove unnecessary cast to EMACS_INT.
eb49b136 9773
15375a22
PE
9774 * lisp.h (union Lisp_Object.i): EMACS_INT, not EMACS_UINT.
9775 This is for consistency with the ordinary, non-USE_LISP_UNION_TYPE,
9776 implementation.
b61cc01c
PE
9777 (struct Lisp_Bool_Vector.size): EMACS_INT, not EMACS_UINT.
9778 We prefer signed types, and the value cannot exceed the EMACS_INT
9779 range anyway (because otherwise the length would not be representable).
9a8e8d9b
PE
9780 (XSET) [USE_LISP_UNION_TYPE]: Use uintptr_t and intptr_t,
9781 not EMACS_UINT and EMACS_INT, when converting pointer to integer.
9782 This avoids a GCC warning when WIDE_EMACS_INT.
15375a22 9783
53b2623d
PE
9784 * indent.c (sane_tab_width): New function.
9785 (current_column, scan_for_column, Findent_to, position_indentation)
9786 (compute_motion): Use it. This is just for clarity.
8fcaf9cc 9787 (Fcompute_motion): Don't assume hscroll and tab offset fit in int.
53b2623d 9788
51cab52b 9789 * image.c (xbm_image_p): Don't assume stated width, height fit in int.
45aebb64 9790
f2ed8a70
PE
9791 * lisp.h (lint_assume): New macro.
9792 * composite.c (composition_gstring_put_cache):
9793 * ftfont.c (ftfont_shape_by_flt): Use it to pacify GCC 4.6.0.
9794
abe80cc6
PE
9795 * editfns.c, insdel.c:
9796 Omit unnecessary forward decls, to simplify future changes.
a9e860e1 9797
b02c740e
PE
9798 * ftfont.c (ftfont_shape_by_flt): Use signed integers for lengths.
9799
ebc96716
PE
9800 * font.c (Ffont_shape_gstring): Don't assume glyph len fits in 'int'.
9801
b4e50fa0 9802 * fns.c (Ffillarray): Don't assume bool vector size fits in 'int'.
f03dc6ef 9803 Use much-faster test for byte-length change.
311d5d7c 9804 Don't assume string byte-length fits in 'int'.
a4cf38e4 9805 Check that character arg fits in 'int'.
85461888 9806 (mapcar1): Declare byte as byte, for clarity.
b4e50fa0 9807
c0c1ee9f
PE
9808 * alloc.c (Fmake_bool_vector): Avoid unnecessary multiplication.
9809
a498d7f4
PE
9810 * fns.c (concat): Catch string overflow earlier.
9811 Do not rely on integer wraparound.
9812
51cab52b
PE
9813 * dispextern.h (struct it.overlay_strings_charpos)
9814 (struct it.selective): Now EMACS_INT, not int.
87830974
PE
9815 * xdisp.c (forward_to_next_line_start)
9816 (back_to_previous_visible_line_start)
9817 (reseat_at_next_visible_line_start, next_element_from_buffer):
9818 Don't arbitrarily truncate the value of 'selective' to int.
9819
76031fad
PE
9820 * xdisp.c (init_iterator): Use XINT, not XFASTINT; it might be < 0.
9821
5eb55db9
PE
9822 * composite.c: Don't truncate sizes to 'int'.
9823 (composition_gstring_p, composition_reseat_it)
9824 (composition_adjust_point): Use EMACS_INT, not int.
7d100a81
PE
9825 (get_composition_id, composition_gstring_put_cache): Use EMACS_INT,
9826 not EMACS_UINT, for indexes.
5eb55db9 9827
0703a717
PE
9828 * category.h (CATEGORY_SET_P): Remove unnecessary cast to EMACS_INT.
9829
d6202519
PE
9830 * buffer.c: Include <verify.h>.
9831 (struct sortvec.priority, struct sortstr.priority):
8961a454 9832 Now EMACS_INT, not int.
c20998a7 9833 (compare_overlays, cmp_for_strings): Avoid subtraction overflow.
67c36fce
PE
9834 (struct sortstr.size, record_overlay_string)
9835 (struct sortstrlist.size, struct sortlist.used):
9836 Don't truncate size to int.
9837 (record_overlay_string): Check for size-calculation overflow.
d6202519 9838 (init_buffer_once): Check at compile-time, not run-time.
fadf4e30 9839
d5a19415
JM
98402011-06-22 Jim Meyering <meyering@redhat.com>
9841
029529ac 9842 Don't leak an XBM-image-sized buffer
d5a19415
JM
9843 * image.c (xbm_load): Free the image buffer after using it.
9844
a9041e6c
PE
98452011-06-21 Paul Eggert <eggert@cs.ucla.edu>
9846
9847 Port to Sun C.
9848 * composite.c (find_automatic_composition): Omit needless 'return 0;'
9849 that Sun C diagnosed.
9850 * fns.c (secure_hash): Fix pointer signedness issue.
9851 * intervals.c (static_offset_intervals): New function.
9852 (offset_intervals): Use it.
9853
7f3f739f
LL
98542011-06-21 Leo Liu <sdl.web@gmail.com>
9855
9856 * deps.mk (fns.o):
9857 * makefile.w32-in ($(BLD)/fns.$(O)): Include sha256.h and
9858 sha512.h.
9859
9860 * fns.c (secure_hash): Rename from crypto_hash_function and change
9861 the first arg to accept symbols.
5b66d427 9862 (Fsecure_hash): New primitive.
7f3f739f
LL
9863 (syms_of_fns): New symbols.
9864
76147d94
DD
98652011-06-20 Deniz Dogan <deniz@dogan.se>
9866
9867 * process.c (Fset_process_buffer): Clarify return value in
9868 docstring.
9869
7d7d0045
CY
98702011-06-18 Chong Yidong <cyd@stupidchicken.com>
9871
9872 * dispnew.c (add_window_display_history): Use BVAR.
9873
9874 * xdisp.c (debug_method_add): Use BVAR.
9875 (check_window_end, dump_glyph_matrix, dump_glyph)
9876 (dump_glyph_row, dump_glyph_string): Convert arglist to ANSI C.
9877
9878 * xfaces.c (check_lface_attrs, check_lface, dump_realized_face):
9879 Likewise.
9880
9881 * xfns.c (Fx_create_frame, x_create_tip_frame): Delay image cache
9882 check till after the cache is created in init_frame_faces.
9883
ff2bc410
SM
98842011-06-17 Stefan Monnier <monnier@iro.umontreal.ca>
9885
9886 * fns.c (Fsafe_length): Yet another int/Lisp_Object mixup.
9887
28177add
PE
98882011-06-16 Paul Eggert <eggert@cs.ucla.edu>
9889
dd3482fe
PE
9890 * lisp.h: Include <limits.h>, for INT_MAX, LONG_MAX, LLONG_MAX.
9891 Without this, prin1 mishandles Lisp_Misc_Save_Value printing on
9892 hosts with pre-C99 libraries, because pD is wrongly defined to "t".
9893
393d71f3 9894 Improve buffer-overflow checking (Bug#8873).
1c8e352f
PE
9895 * fileio.c (Finsert_file_contents):
9896 * insdel.c (insert_from_buffer_1, replace_range, replace_range_2):
9897 Remove the old (too-loose) buffer overflow checks.
9898 They weren't needed, since make_gap checks for buffer overflow.
9899 * insdel.c (make_gap_larger): Catch buffer overflows that were missed.
9900 The old code merely checked for Emacs fixnum overflow, and relied
9901 on undefined (wraparound) behavior. The new code avoids undefined
9902 behavior, and also checks for ptrdiff_t and/or size_t overflow.
9903
2e6813b0 9904 * editfns.c (Finsert_char): Don't dump core with very negative counts.
21d890a4
PE
9905 Tune. Don't use wider integers than needed. Don't use alloca.
9906 Use a bigger 'string' buffer. Rewrite to avoid 'n > 0' test.
2e6813b0 9907
599a9e4f
PE
9908 * insdel.c (replace_range): Fix buf overflow when insbytes < outgoing.
9909
99561444
PE
9910 * insdel.c, lisp.h (buffer_overflow): New function.
9911 (insert_from_buffer_1, replace_range, replace_range_2):
9912 * insdel.c (make_gap_larger):
9913 * editfns.c (Finsert_char):
9914 * fileio.c (Finsert_file_contents): Use it, to normalize wording.
9915
28177add
PE
9916 * buffer.h (BUF_BYTES_MAX): Cast to ptrdiff_t so that it's signed.
9917
e69dafad
PE
99182011-06-15 Paul Eggert <eggert@cs.ucla.edu>
9919
4baa020d 9920 Integer overflow and signedness fixes (Bug#8873, Bug#8828).
ff672d2c 9921
b1c46f02
PE
9922 * ccl.c (ASCENDING_ORDER): New macro, to work around GCC bug 43772.
9923 (GET_CCL_RANGE, IN_INT_RANGE): Use it.
9924
e69dafad
PE
9925 * fileio.c: Don't assume EMACS_INT fits in off_t.
9926 (emacs_lseek): New static function.
9927 (Finsert_file_contents, Fwrite_region): Use it.
9928 Use SEEK_SET, SEEK_CUR, SEEK_END as appropriate.
9929
566684ea
PE
9930 * fns.c (Fload_average): Don't assume 100 * load average fits in int.
9931
e6966cd6
PE
9932 * fns.c: Don't overflow int when computing a list length.
9933 * fns.c (QUIT_COUNT_HEURISTIC): New constant.
9934 (Flength, Fsafe_length): Use EMACS_INT, not int, to avoid unwanted
9935 truncation on 64-bit hosts. Check for QUIT every
9936 QUIT_COUNT_HEURISTIC entries rather than every other entry; that's
9937 faster and is responsive enough.
9938 (Flength): Report an error instead of overflowing an integer.
9939 (Fsafe_length): Return a float if the value is not representable
9940 as a fixnum. This shouldn't happen except in contrived situations.
6346d301 9941 (Fnthcdr, Fsort): Don't assume list length fits in int.
de41a810 9942 (Fcopy_sequence): Don't assume vector length fits in int.
00c604f2 9943
dd0b0efb
PE
9944 * alloc.c: Check that resized vectors' lengths fit in fixnums.
9945 (header_size, word_size): New constants.
9946 (allocate_vectorlike): Don't check size overflow here.
9947 (allocate_vector): Check it here instead, since this is the only
9948 caller of allocate_vectorlike that could cause overflow.
9949 Check that the new vector's length is representable as a fixnum.
9950
86fe5cfe
PE
9951 * fns.c (next_almost_prime): Don't return a multiple of 3 or 5.
9952 The previous code was bogus. For example, next_almost_prime (32)
9953 returned 39, which is undesirable as it is a multiple of 3; and
9954 next_almost_prime (24) returned 25, which is a multiple of 5 so
9955 why was the code bothering to check for multiples of 7?
9956
80e88859
PE
9957 * bytecode.c (exec_byte_code): Use ptrdiff_t, not int, for vector length.
9958
4a2f0ad6
PE
9959 * eval.c, doprnt.c (SIZE_MAX): Remove; inttypes.h defines this now.
9960
f66c7cf8
PE
9961 Variadic C functions now count arguments with ptrdiff_t.
9962 This partly undoes my 2011-03-30 change, which replaced int with size_t.
9963 Back then I didn't know that the Emacs coding style prefers signed int.
9964 Also, in the meantime I found a few more instances where arguments
4a2f0ad6
PE
9965 were being counted with int, which may truncate counts on 64-bit
9966 machines, or EMACS_INT, which may be unnecessarily wide.
f66c7cf8
PE
9967 * lisp.h (struct Lisp_Subr.function.aMANY)
9968 (DEFUN_ARGS_MANY, internal_condition_case_n, safe_call):
9969 Arg counts are now ptrdiff_t, not size_t.
9970 All variadic functions and their callers changed accordingly.
9971 (struct gcpro.nvars): Now size_t, not size_t. All uses changed.
9972 * bytecode.c (exec_byte_code): Check maxdepth for overflow,
9973 to avoid potential buffer overrun. Don't assume arg counts fit in 'int'.
9974 * callint.c (Fcall_interactively): Check arg count for overflow,
9975 to avoid potential buffer overrun. Use signed char, not 'int',
9976 for 'varies' array, so that we needn't bother to check its size
9977 calculation for overflow.
9978 * editfns.c (Fformat): Use ptrdiff_t, not EMACS_INT, to count args.
9979 * eval.c (apply_lambda):
9980 * fns.c (Fmapconcat): Use XFASTINT, not XINT, to get args length.
9981 (struct textprop_rec.argnum): Now ptrdiff_t, not int. All uses changed.
9982 (mapconcat): Use ptrdiff_t, not int and EMACS_INT, to count args.
9983
a1759b76
PE
9984 * callint.c (Fcall_interactively): Don't use index var as event count.
9985
d96be9fc
PE
9986 * vm-limit.c (check_memory_limits): Fix incorrect extern function decls.
9987 * mem-limits.h (SIZE): Remove; no longer used.
9988
a690a978 9989 * xterm.c (x_alloc_nearest_color_1): Prefer int to long when int works.
5efd304b 9990
578c21e6
PE
9991 Remove unnecessary casts.
9992 * xterm.c (x_term_init):
9993 * xfns.c (x_set_border_pixel):
9994 * widget.c (create_frame_gcs): Remove casts to unsigned long etc.
9995 These aren't needed now that we assume ANSI C.
9996
96f53c6c
PE
9997 * sound.c (Fplay_sound_internal): Remove cast to unsigned long.
9998 It's more likely to cause problems (due to unsigned overflow)
9999 than to cure them.
10000
83c77d31
PE
10001 * dired.c (Ffile_attributes): Don't use 32-bit hack on 64-bit hosts.
10002
ee2079f1
PE
10003 * unexelf.c (unexec): Don't assume BSS addr fits in unsigned.
10004
6da65536
PE
10005 * xterm.c (handle_one_xevent): Omit unnecessary casts to unsigned.
10006
7147c4a4
PE
10007 * keyboard.c (modify_event_symbol): Don't limit alist len to UINT_MAX.
10008
193e32d9
PE
10009 * lisp.h (CHAR_TABLE_SET): Omit now-redundant test.
10010
e5533da6
PE
10011 * lread.c (Fload): Don't compare a possibly-garbage time_t value.
10012
9910e595
PE
10013 GLYPH_CODE_FACE returns EMACS_INT, not int.
10014 * dispextern.h (merge_faces):
10015 * xfaces.c (merge_faces):
01103c44
PE
10016 * xdisp.c (get_next_display_element, next_element_from_display_vector):
10017 Don't assume EMACS_INT fits in int.
9910e595 10018
2638320e
PE
10019 * character.h (CHAR_VALID_P): Remove unused parameter.
10020 * fontset.c, lisp.h, xdisp.c: All uses changed.
10021
045eb8d9
PE
10022 * editfns.c (Ftranslate_region_internal): Omit redundant test.
10023
c1f134b5
PE
10024 * fns.c (concat): Minor tuning based on overflow analysis.
10025 This doesn't fix any bugs. Use int to hold character, instead
10026 of constantly refetching from Emacs object. Use XFASTINT, not
10027 XINT, for value known to be a character. Don't bother comparing
10028 a single byte to 0400, as it's always less.
10029
395fcb93 10030 * floatfns.c (Fexpt):
327eeec8
PE
10031 * fileio.c (make_temp_name): Omit unnecessary cast to unsigned.
10032
abbd3d23
PE
10033 * editfns.c (Ftranslate_region_internal): Use int, not EMACS_INT
10034 for characters.
10035
684a03ef
PE
10036 * doc.c (get_doc_string): Omit (unsigned)c that mishandled negatives.
10037
0fed43f3
PE
10038 * data.c (Faset): If ARRAY is a string, check that NEWELT is a char.
10039 Without this fix, on a 64-bit host (aset S 0 4294967386) would
10040 incorrectly succeed when S was a string, because 4294967386 was
10041 truncated before it was used.
10042
8fd02eb7
PE
10043 * chartab.c (Fchar_table_range): Use CHARACTERP to check range.
10044 Otherwise, an out-of-range integer could cause undefined behavior
10045 on a 64-bit host.
10046
f8c86b69
PE
10047 * composite.c: Use int, not EMACS_INT, for characters.
10048 (fill_gstring_body, composition_compute_stop_pos): Use int, not
10049 EMACS_INT, for values that are known to be in character range.
10050 This doesn't fix any bugs but is the usual style inside Emacs and
10051 may generate better code on 32-bit machines.
10052
34206dd2
PE
10053 Make sure a 64-bit char is never passed to ENCODE_CHAR.
10054 This is for reasons similar to the recent CHAR_STRING fix.
10055 * charset.c (Fencode_char): Check that character arg is actually
10056 a character. Pass an int to ENCODE_CHAR.
10057 * charset.h (ENCODE_CHAR): Verify that the character argument is no
10058 wider than 'int', as a compile-time check to prevent future regressions
10059 in this area.
10060
c5958d4c 10061 * character.c (char_string): Remove unnecessary casts.
13bdea59
PE
10062
10063 Make sure a 64-bit char is never passed to CHAR_STRING.
10064 Otherwise, CHAR_STRING would do the wrong thing on a 64-bit platform,
10065 by silently ignoring the top 32 bits, allowing some values
10066 that were far too large to be valid characters.
10067 * character.h: Include <verify.h>.
10068 (CHAR_STRING, CHAR_STRING_ADVANCE): Verify that the character
10069 arguments are no wider than unsigned, as a compile-time check
10070 to prevent future regressions in this area.
10071 * data.c (Faset):
01103c44 10072 * editfns.c (Fchar_to_string, general_insert_function, Finsert_char)
13bdea59
PE
10073 (Fsubst_char_in_region):
10074 * fns.c (concat):
10075 * xdisp.c (decode_mode_spec_coding):
10076 Adjust to CHAR_STRING's new requirement.
10077 * editfns.c (Finsert_char, Fsubst_char_in_region):
10078 * fns.c (concat): Check that character args are actually
10079 characters. Without this test, these functions did the wrong
10080 thing with wildly out-of-range values on 64-bit hosts.
10081
d37ca623
PE
10082 Remove incorrect casts to 'unsigned' that lose info on 64-bit hosts.
10083 These casts should not be needed on 32-bit hosts, either.
10084 * keyboard.c (read_char):
10085 * lread.c (Fload): Remove casts to unsigned.
10086
ea204efb
PE
10087 * lisp.h (UNSIGNED_CMP): New macro.
10088 This fixes comparison bugs on 64-bit hosts.
10089 (ASCII_CHAR_P): Use it.
10090 * casefiddle.c (casify_object):
01103c44 10091 * character.h (ASCII_BYTE_P, CHAR_VALID_P)
ea204efb
PE
10092 (SINGLE_BYTE_CHAR_P, CHAR_STRING):
10093 * composite.h (COMPOSITION_ENCODE_RULE_VALID):
10094 * dispextern.h (FACE_FROM_ID):
10095 * keyboard.c (read_char): Use UNSIGNED_CMP.
10096
41cb286c
PE
10097 * xmenu.c (dialog_selection_callback) [!USE_GTK]: Cast to intptr_t,
10098 not to EMACS_INT, to avoid GCC warning.
10099
4a1b9832
PE
10100 * xfns.c (x_set_scroll_bar_default_width): Remove unused 'int' locals.
10101
55daad71
PE
10102 * buffer.h (PTR_BYTE_POS, BUF_PTR_BYTE_POS): Remove harmful cast.
10103 The cast incorrectly truncated 64-bit byte offsets to 32 bits, and
10104 isn't needed on 32-bit machines.
8f95c75c 10105
01103c44
PE
10106 * buffer.c (Fgenerate_new_buffer_name):
10107 Use EMACS_INT for count, not int.
0ceccced 10108 (advance_to_char_boundary): Return EMACS_INT, not int.
e762cafe
PE
10109
10110 * data.c (Qcompiled_function): Now static.
10111
c6f072e7
PE
10112 * window.c (window_body_lines): Now static.
10113
20ce5912
PE
10114 * image.c (gif_load): Rename local to avoid shadowing.
10115
9c4c5f81
PE
10116 * lisp.h (SAFE_ALLOCA_LISP): Check for integer overflow.
10117 (struct Lisp_Save_Value): Use ptrdiff_t, not int, for 'integer' member.
10118 * alloc.c (make_save_value): Integer argument is now of type
10119 ptrdiff_t, not int.
10120 (mark_object): Use ptrdiff_t, not int.
10121 * lisp.h (pD): New macro.
10122 * print.c (print_object): Use it.
10123
c0c5c8ae
PE
10124 * alloc.c: Use EMACS_INT, not int, to count objects.
10125 (total_conses, total_markers, total_symbols, total_vector_size)
10126 (total_free_conses, total_free_markers, total_free_symbols)
01103c44
PE
10127 (total_free_floats, total_floats, total_free_intervals)
10128 (total_intervals, total_strings, total_free_strings):
c0c5c8ae
PE
10129 Now EMACS_INT, not int. All uses changed.
10130 (Fgarbage_collect): Compute overall total using a double, so that
10131 integer overflow is less likely to be a problem. Check for overflow
10132 when converting back to an integer.
5a25e253
PE
10133 (n_interval_blocks, n_string_blocks, n_float_blocks, n_cons_blocks)
10134 (n_vectors, n_symbol_blocks, n_marker_blocks): Remove.
10135 These were 'int' variables that could overflow on 64-bit hosts;
10136 they were never used, so remove them instead of repairing them.
211a0b2a 10137 (nzombies, ngcs, max_live, max_zombies): Now EMACS_INT, not 'int'.
6349ae4d
PE
10138 (inhibit_garbage_collection): Set gc_cons_threshold to max value.
10139 Previously, this ceilinged at INT_MAX, but that doesn't work on
10140 64-bit machines.
e46bb31a 10141 (allocate_pseudovector): Don't use EMACS_INT when int would do.
c0c5c8ae 10142
c78baabf 10143 * alloc.c (Fmake_bool_vector): Don't assume vector size fits in int.
86f61a15 10144 (allocate_vectorlike): Check for ptrdiff_t overflow.
b6439961
PE
10145 (mark_vectorlike, mark_char_table, mark_object): Avoid EMACS_UINT
10146 when a (possibly-narrower) signed value would do just as well.
10147 We prefer using signed arithmetic, to avoid comparison confusion.
c78baabf 10148
c9d624c6
PE
10149 * alloc.c: Catch some string size overflows that we were missing.
10150 (XMALLOC_OVERRUN_CHECK_SIZE) [!XMALLOC_OVERRUN_CHECK]: Define to 0,
10151 for convenience in STRING_BYTES_MAX.
10152 (STRING_BYTES_MAX): New macro, superseding the old one in lisp.h.
10153 The definition here is exact; the one in lisp.h was approximate.
10154 (allocate_string_data): Check for string overflow. This catches
10155 some instances we weren't catching before. Also, it catches
10156 size_t overflow on (unusual) hosts where SIZE_MAX <= min
10157 (PTRDIFF_MAX, MOST_POSITIVE_FIXNUM), e.g., when size_t is 32 bits
10158 and ptrdiff_t and EMACS_INT are both 64 bits.
c78baabf 10159
c9d624c6
PE
10160 * character.c, coding.c, doprnt.c, editfns.c, eval.c:
10161 All uses of STRING_BYTES_MAX replaced by STRING_BYTES_BOUND.
640c8776 10162 * lisp.h (STRING_BYTES_BOUND): Rename from STRING_BYTES_MAX.
c9d624c6 10163
353032ce
PE
10164 * character.c (string_escape_byte8): Fix nbytes/nchars typo.
10165
2bccce07
PE
10166 * alloc.c (Fmake_string): Check for out-of-range init.
10167
0ac30604
SM
101682011-06-15 Stefan Monnier <monnier@iro.umontreal.ca>
10169
10170 * eval.c (Fdefvaralias): Also mark the target as variable-special-p.
10171
c195f2de
JD
101722011-06-14 Jan Djärv <jan.h.d@swipnet.se>
10173
10174 * xfns.c (x_set_scroll_bar_default_width): Remove argument to
10175 xg_get_default_scrollbar_width.
10176
10177 * gtkutil.c: Include emacsgtkfixed.h if HAVE_GTK3.
10178 (int_gtk_range_get_value): Move to the scroll bar part of the file.
10179 (style_changed_cb): Call update_theme_scrollbar_width and call
10180 x_set_scroll_bar_default_width and xg_frame_set_char_size for
10181 all frames (Bug#8505).
10182 (xg_create_frame_widgets): Call emacs_fixed_new if HAVE_GTK3 (Bug#8505).
10183 Call gtk_window_set_resizable if HAVE_GTK3.
10184 (x_wm_set_size_hint): Call emacs_fixed_set_min_size with min width
10185 and height if HAVE_GTK3 (Bug#8505).
10186 (scroll_bar_width_for_theme): New variable.
10187 (update_theme_scrollbar_width): New function.
10188 (xg_get_default_scrollbar_width): Move code to
10189 update_theme_scrollbar_width, just return scroll_bar_width_for_theme.
10190 (xg_initialize): Call update_theme_scrollbar_width.
10191
10192 * gtkutil.h (xg_get_default_scrollbar_width): Remove argument.
10193
10194 * emacsgtkfixed.c, emacsgtkfixed.h: New files.
10195
e10ac9f1
MR
101962011-06-12 Martin Rudalics <rudalics@gmx.at>
10197
10198 * frame.c (make_frame): Call other_buffer_safely instead of
10199 other_buffer.
10200
10201 * window.c (temp_output_buffer_show): Call display_buffer with
10202 second argument Vtemp_buffer_show_specifiers and reset latter
10203 immediately after the call.
10204 (Vtemp_buffer_show_specifiers): New variable.
10205 (auto_window_vscroll_p, next_screen_context_lines)
10206 (Vscroll_preserve_screen_position): Remove leading asterisks from
10207 doc-strings.
10208
2d3c217e 102092011-06-12 Paul Eggert <eggert@cs.ucla.edu>
4475bec4 10210
7b7f97e8 10211 Fix minor problems found by GCC 4.6.0 static checking.
4475bec4
PE
10212 * buffer.c (Qclone_number): Remove for now, as it's unused.
10213 (record_buffer, Funrecord_buffer): Rename local to avoid shadowing.
10214 (record_buffer): Remove unused local.
10215 * frame.c (other_visible_frames, frame_buffer_list): Now static.
10216 (set_frame_buffer_list): Remove; unused.
10217 * frame.h (other_visible_frames): Remove decl.
10218 * keyboard.h (menu_items_inuse): Declare only if USE_GTK || USE_MOTIF.
10219 * lisp.h (frame_buffer_list, set_frame_buffer_list): Remove decls.
10220 (add_gpm_wait_descriptor, delete_gpm_wait_descriptor): Declare only
10221 if HAVE_GPM.
10222 * menu.c (menu_items_inuse): Now static unless USE_GTK || USE_MOTIF.
10223 * process.c (add_gpm_wait_descriptor, delete_gpm_wait_descriptor):
10224 Define only if HAVE_GPM.
10225 * widget.c (EmacsFrameResize, emacsFrameClassRec): Now static.
10226 (update_hints_inhibit): Remove; never set. All uses removed.
10227 * widgetprv.h (emacsFrameClassRec): Remove decl.
10228 * window.c (delete_deletable_window): Now returns void, since it
10229 wasn't returning anything.
10230 (compare_window_configurations): Remove unused locals.
10231 * xfns.c (x_set_scroll_bar_default_width): Remove unused locals.
10232 * xmenu.c (x_menu_set_in_use): Define only if USE_GTK || USE_MOTIF.
4475bec4
PE
10233 (dialog_selection_callback) [!USE_GTK]: Prefer intptr_t for integers
10234 the same widths as pointers. This follows up on the 2011-05-06 patch.
10235 * xterm.c (x_alloc_lighter_color_for_widget): Define only if USE_LUCID.
10236 * xterm.h: Likewise.
10237 (x_menu_set_in_use): Declare only if USE_GTK || USE_MOTIF.
10238
1384b89e
JB
102392011-06-12 Juanma Barranquero <lekktu@gmail.com>
10240
10241 * makefile.w32-in: Update dependencies.
10242 (LISP_H): Add lib/intprops.h.
10243
1100a63c
CY
102442011-06-11 Chong Yidong <cyd@stupidchicken.com>
10245
10246 * image.c (gif_load): Add animation frame delay to the metadata.
10247 (syms_of_image): Use DEFSYM. New symbol `delay'.
10248
6198ccd0
MR
102492011-06-11 Martin Rudalics <rudalics@gmx.at>
10250
10251 * window.c (delete_deletable_window): Re-add.
10252 (Fset_window_configuration): Rewrite to handle dead buffers and
10253 consequently deletable windows.
10254 (window_tree, Fwindow_tree): Remove. Supply functionality in
10255 window.el.
10256 (compare_window_configurations): Simplify code.
10257
b6e3633c
AS
102582011-06-11 Andreas Schwab <schwab@linux-m68k.org>
10259
1ab0dee5
AS
10260 * image.c (imagemagick_load_image): Fix type mismatch.
10261 (Fimagemagick_types): Likewise.
10262
b6e3633c
AS
10263 * window.h (replace_buffer_in_windows): Declare.
10264
9397e56f
MR
102652011-06-11 Martin Rudalics <rudalics@gmx.at>
10266
10267 * buffer.c: New Lisp objects Qbuffer_list_update_hook and
10268 Qclone_number. Remove external declaration of Qdelete_window.
10269 (Fbuffer_list): Rewrite doc-string. Minor restructuring of
10270 code.
640c8776
SM
10271 (Fget_buffer_create, Fmake_indirect_buffer, Frename_buffer):
10272 Run Qbuffer_list_update_hook if allowed.
9397e56f
MR
10273 (Fother_buffer): Rewrite doc-string. Major rewrite for new
10274 buffer list implementation.
10275 (other_buffer_safely): New function.
10276 (Fkill_buffer): Replace call to replace_buffer_in_all_windows by
10277 calls to replace_buffer_in_windows and
10278 replace_buffer_in_windows_safely. Run Qbuffer_list_update_hook
10279 if allowed.
10280 (record_buffer): Inhibit quitting and rewrite using quittable
10281 functions. Run Qbuffer_list_update_hook if allowed.
10282 (Frecord_buffer, Funrecord_buffer): New functions.
640c8776
SM
10283 (switch_to_buffer_1, Fswitch_to_buffer): Remove.
10284 Move switch-to-buffer to window.el.
9397e56f
MR
10285 (bury-buffer): Move to window.el.
10286 (Vbuffer_list_update_hook): New variable.
10287
10288 * lisp.h (other_buffer_safely): Add prototype in buffer.c
10289 section.
10290
10291 * window.h (resize_frame_windows): Move up in code.
10292 (Fwindow_frame): Remove EXFUN.
10293 (replace_buffer_in_all_windows): Remove prototype.
10294 (replace_buffer_in_windows_safely): Add prototype.
10295
10296 * window.c: Declare Qdelete_window static again. Move down
10297 declaration of select_count.
10298 (Fnext_window, Fprevious_window): Rewrite doc-strings.
10299 (Fother_window): Move to window.el.
10300 (window_loop): Remove DELETE_BUFFER_WINDOWS and UNSHOW_BUFFER
10301 cases. Add REPLACE_BUFFER_IN_WINDOWS_SAFELY case.
10302 (Fdelete_windows_on, Freplace_buffer_in_windows): Move to
10303 window.el.
10304 (replace_buffer_in_windows): Implement by calling
10305 Qreplace_buffer_in_windows.
10306 (replace_buffer_in_all_windows): Remove with some functionality
10307 moved into replace_buffer_in_windows_safely.
10308 (replace_buffer_in_windows_safely): New function.
10309 (select_window_norecord, select_frame_norecord): Move in front
10310 of run_window_configuration_change_hook. Remove now obsolete
10311 declarations.
640c8776
SM
10312 (Fset_window_buffer): Rewrite doc-string.
10313 Call Qrecord_window_buffer.
9397e56f
MR
10314 (keys_of_window): Move binding for other-window to window.el.
10315
b50691aa
CY
103162011-06-11 Chong Yidong <cyd@stupidchicken.com>
10317
10318 * dispextern.h (struct image): Replace data member, whose int_val
10319 and ptr_val fields were not used by anything, with a single
10320 lisp_val object.
10321
10322 * image.c (Fimage_metadata, make_image, mark_image, tiff_load)
10323 (gif_clear_image, gif_load, imagemagick_load_image)
10324 (gs_clear_image, gs_load): Callers changed.
10325
3f754b86
PE
103262011-06-10 Paul Eggert <eggert@cs.ucla.edu>
10327
cca69397
PE
10328 * buffer.h: Include <time.h>, for time_t.
10329 Needed to build on FreeBSD 8.2. Problem reported by Herbert J. Skuhra.
10330
109e28d0
PE
10331 Fix minor problems found by static checking.
10332
60737f02
PE
10333 * image.c (PixelGetMagickColor): Declare if ImageMagick headers don't.
10334
4b66faf3
PE
10335 Make identifiers static if they are not used in other modules.
10336 * data.c (Qcompiled_function, Qframe, Qvector):
10337 * image.c (QimageMagick, Qsvg):
10338 * minibuf.c (Qmetadata):
10339 * window.c (resize_window_check, resize_root_window): Now static.
10340 * window.h (resize_window_check, resize_root_window): Remove decls.
10341
109e28d0
PE
10342 * window.c (window_deletion_count, delete_deletable_window):
10343 Remove; unused.
46a4ce9e
PE
10344 (window_body_lines): Now static.
10345 (Fdelete_other_windows_internal): Mark vars as initialized.
10346 Make sure 'resize_failed' is initialized.
10347 (run_window_configuration_change_hook): Rename local to avoid shadowing.
10348 (resize_window_apply): Remove unused local.
10349 * window.h (delete_deletable_window): Remove decl.
10350
109e28d0 10351 * image.c (gif_load, svg_load_image): Rename locals to avoid shadowing.
33290528
PE
10352 (imagemagick_load_image): Fix pointer signedness problem by changing
10353 last arg from unsigned char * to char *. All uses changed.
10354 Also, fix a local for similar reasons.
10355 Remove unused locals. Remove locals to avoid shadowing.
10356 (fn_rsvg_handle_free): Remove; unused.
10357 (svg_load, svg_load_image): Fix pointer signedness problem.
f7e13da3 10358 (imagemagick_load_image): Don't use garbage pointer image_wand.
33290528 10359
3f754b86
PE
10360 * ftfont.c (ftfont_get_metrics, ftfont_drive_otf): Remove unused locals.
10361
2547adb1
CY
103622011-06-10 Chong Yidong <cyd@stupidchicken.com>
10363
10364 * image.c (gif_load): Fix omitted cast error introduced by
10365 2011-06-06 change.
10366
2c8e37d4
MR
103672011-06-10 Martin Rudalics <rudalics@gmx.at>
10368
10369 * window.h (resize_proportionally, orig_total_lines)
10370 (orig_top_line): Remove from window structure.
10371 (set_window_height, set_window_width, change_window_heights)
10372 (Fdelete_window): Remove prototypes.
10373 (resize_frame_windows): Remove duplicate declaration.
10374
440a42e3
EZ
103752011-06-10 Eli Zaretskii <eliz@gnu.org>
10376
10377 * window.h (resize_frame_windows, resize_window_check)
10378 (delete_deletable_window, resize_root_window)
10379 (resize_frame_windows): Declare prototypes.
10380
10381 * window.c (resize_window_apply): Make definition be "static" to
10382 match the prototype.
10383
562dd5e9
MR
103842011-06-10 Martin Rudalics <rudalics@gmx.at>
10385
10386 * window.c: Remove declarations of Qwindow_size_fixed,
10387 window_min_size_1, window_min_size_2, window_min_size,
10388 size_window, window_fixed_size_p, enlarge_window, delete_window.
10389 Remove static from declaration of Qdelete_window, it's
10390 temporarily needed by Fbury_buffer.
10391 (replace_window): Don't assign orig_top_line and
10392 orig_total_lines.
10393 (Fdelete_window, delete_window): Remove. Window deletion is
10394 handled by window.el.
640c8776
SM
10395 (window_loop): Remove DELETE_OTHER_WINDOWS case.
10396 Replace Fdelete_window calls with calls to Qdelete_window.
562dd5e9
MR
10397 (Fdelete_other_windows): Remove. Deleting other windows is
10398 handled by window.el.
10399 (window_fixed_size_p): Remove. Fixed-sizeness of windows is
10400 handled in window.el.
10401 (window_min_size_2, window_min_size_1, window_min_size): Remove.
10402 Window minimum sizes are handled in window.el.
10403 (shrink_windows, size_window, set_window_height)
10404 (set_window_width, change_window_heights, window_height)
10405 (window_width, CURBEG, CURSIZE, enlarge_window)
10406 (adjust_window_trailing_edge, Fadjust_window_trailing_edge)
10407 (Fenlarge_window, Fshrink_window): Remove. Window resizing is
10408 handled in window.el.
10409 (make_dummy_parent): Rename to make_parent_window and give it a
10410 second argument horflag.
10411 (make_window): Don't set resize_proportionally any more.
10412 (Fsplit_window): Remove. Windows are split in window.el.
10413 (save_restore_action, save_restore_orig_size)
10414 (shrink_window_lowest_first, save_restore_orig_size): Remove.
10415 Resize mini windows in window.el.
10416 (grow_mini_window, shrink_mini_window): Implement by calling
10417 Qresize_root_window_vertically, resize_window_check and
10418 resize_window_apply.
640c8776
SM
10419 (saved_window, Fset_window_configuration, save_window_save):
10420 Do not handle orig_top_line, orig_total_lines, and
562dd5e9
MR
10421 resize_proportionally.
10422 (window_min_height, window_min_width): Move to window.el.
10423 (keys_of_window): Move bindings for delete-other-windows,
10424 split-window, delete-window and enlarge-window to window.el.
10425
10426 * buffer.c: Temporarily extern Qdelete_window.
10427 (Fbury_buffer): Temporarily call Qdelete_window instead of
10428 Fdelete_window (Fbury_buffer will move to window.el soon).
10429
10430 * frame.c (set_menu_bar_lines_1): Remove code handling
10431 orig_top_line and orig_total_lines.
10432
10433 * dispnew.c (adjust_frame_glyphs_initially): Don't use
10434 set_window_height but set heights directly.
10435 (change_frame_size_1): Use resize_frame_windows.
10436
10437 * xdisp.c (init_xdisp): Don't use set_window_height but set
10438 heights directly.
10439
640c8776
SM
10440 * xfns.c (x_set_menu_bar_lines, x_set_tool_bar_lines):
10441 Use resize_frame_windows instead of change_window_heights and run
562dd5e9
MR
10442 run_window_configuration_change_hook.
10443
10444 * w32fns.c (x_set_tool_bar_lines): Use resize_frame_windows
10445 instead of change_window_heights and run
10446 run_window_configuration_change_hook.
10447
1a13852e
MR
104482011-06-09 Martin Rudalics <rudalics@gmx.at>
10449
10450 * window.c (replace_window): Rename second argument REPLACEMENT to
10451 NEW. New third argument SETFLAG. Rewrite.
10452 (delete_window, make_dummy_parent): Call replace_window with
10453 third argument 1.
10454 (window_list_1): Move down in code.
10455 (run_window_configuration_change_hook): Move set_buffer part
10456 before select_frame_norecord part in order to unwind correctly.
10457 Rename count1 to count.
10458 (recombine_windows, delete_deletable_window, resize_root_window)
10459 (Fdelete_other_windows_internal)
10460 (Frun_window_configuration_change_hook, make_parent_window)
10461 (resize_window_check, resize_window_apply, Fresize_window_apply)
10462 (resize_frame_windows, Fsplit_window_internal)
640c8776
SM
10463 (Fdelete_window_internal, Fresize_mini_window_internal):
10464 New functions.
1a13852e
MR
10465 (syms_of_window): New variables Vwindow_splits and Vwindow_nest.
10466
f3d1777e
MR
104672011-06-08 Martin Rudalics <rudalics@gmx.at>
10468
496e208e
MR
10469 * window.h (window): Add some new members to window structure -
10470 normal_lines, normal_cols, new_total, new_normal, clone_number,
10471 splits, nest, prev_buffers, next_buffers.
10472 (WINDOW_TOTAL_SIZE): Move here from window.c.
b9e809c2 10473 (MIN_SAFE_WINDOW_WIDTH, MIN_SAFE_WINDOW_HEIGHT): Define here.
496e208e 10474
f3d1777e
MR
10475 * window.c (Fwindow_height, Fwindow_width, Fwindow_full_width_p):
10476 Remove.
496e208e
MR
10477 (make_dummy_parent): Set new members of windows structure.
10478 (make_window): Move down in code. Handle new members of window
10479 structure.
10480 (Fwindow_clone_number, Fwindow_splits, Fset_window_splits)
10481 (Fwindow_nest, Fset_window_nest, Fwindow_new_total)
10482 (Fwindow_normal_size, Fwindow_new_normal, Fwindow_prev_buffers)
10483 (Fset_window_prev_buffers, Fwindow_next_buffers)
640c8776
SM
10484 (Fset_window_next_buffers, Fset_window_clone_number):
10485 New functions.
496e208e
MR
10486 (Fwindow_hscroll, Fwindow_at, Fwindow_point, Fwindow_start)
10487 (Fwindow_end, Fwindow_line_height, Fset_window_dedicated_p):
10488 Doc-string fixes.
10489 (Fwindow_parameters, Fwindow_parameter, Fset_window_parameter):
10490 Argument WINDOW can be now internal window too.
10491 (Fwindow_use_time): Move up in code.
10492 (Fget_buffer_window): Rename argument FRAME to ALL-FRAMES.
10493 Rewrite doc-string.
10494 (Fset_window_configuration, saved_window)
10495 (Fcurrent_window_configuration, save_window_save): Handle new
10496 members of window structure.
b9e809c2
MR
10497 (WINDOW_TOTAL_SIZE, MIN_SAFE_WINDOW_WIDTH)
10498 (MIN_SAFE_WINDOW_HEIGHT): Move to window.h.
10499 (syms_of_window): New Lisp objects Qrecord_window_buffer,
10500 Qwindow_deletable_p, Qdelete_window, Qreplace_buffer_in_windows,
10501 Qget_mru_window, Qresize_root_window,
10502 Qresize_root_window_vertically, Qsafe, Qabove, Qbelow,
10503 Qauto_buffer_name; staticpro them.
f3d1777e 10504
abde8f8c
MR
105052011-06-07 Martin Rudalics <rudalics@gmx.at>
10506
10507 * window.c (Fwindow_total_size, Fwindow_left_column)
10508 (Fwindow_top_line, window_body_lines, Fwindow_body_size)
10509 (Fwindow_list_1): New functions.
10510 (window_box_text_cols): Replace with window_body_cols.
640c8776
SM
10511 (Fwindow_width, Fscroll_left, Fscroll_right):
10512 Use window_body_cols instead of window_box_text_cols.
10513 (delete_window, Fset_window_configuration):
10514 Call delete_all_subwindows with window as argument.
fa8a67e6
MR
10515 (delete_all_subwindows): Take a window as argument and not a
10516 structure. Rewrite.
190b47e6
MR
10517 (window_loop): Remove handling of GET_LRU_WINDOW and
10518 GET_LARGEST_WINDOW.
10519 (Fget_lru_window, Fget_largest_window): Move to window.el.
abde8f8c
MR
10520
10521 * window.h: Extern window_body_cols instead of
fa8a67e6
MR
10522 window_box_text_cols. delete_all_subwindows now takes a
10523 Lisp_Object as argument.
abde8f8c 10524
640c8776
SM
10525 * indent.c (compute_motion, Fcompute_motion):
10526 Use window_body_cols instead of window_box_text_cols.
abde8f8c 10527
fa8a67e6
MR
10528 * frame.c (delete_frame): Call delete_all_subwindows with root
10529 window as argument.
10530
a54e3482
DC
105312011-06-07 Daniel Colascione <dan.colascione@gmail.com>
10532
10533 * fns.c (Fputhash): Document return value.
10534
60002bf5
CY
105352011-06-06 Chong Yidong <cyd@stupidchicken.com>
10536
10537 * image.c (gif_load): Implement gif89a spec "no disposal" method.
10538
0c671da6 105392011-06-06 Paul Eggert <eggert@cs.ucla.edu>
ccd9a01a 10540
b862a52a 10541 Cons<->int and similar integer overflow fixes (Bug#8794).
77984278 10542
be44ca6c
PE
10543 Check for overflow when converting integer to cons and back.
10544 * charset.c (Fdefine_charset_internal, Fdecode_char):
10545 Use cons_to_unsigned to catch overflow.
10546 (Fencode_char): Use INTEGER_TO_CONS.
10547 * composite.h (LGLYPH_CODE): Use cons_to_unsigned.
10548 (LGLYPH_SET_CODE): Use INTEGER_TO_CONS.
10549 * data.c (long_to_cons, cons_to_long): Remove.
10550 (cons_to_unsigned, cons_to_signed): New functions.
10551 These signal an error for invalid or out-of-range values.
10552 * dired.c (Ffile_attributes): Use INTEGER_TO_CONS.
10553 * fileio.c (Fset_visited_file_modtime): Use CONS_TO_INTEGER.
10554 * font.c (Ffont_variation_glyphs):
10555 * fontset.c (Finternal_char_font): Use INTEGER_TO_CONS.
10556 * lisp.h: Include <intprops.h>.
10557 (INTEGER_TO_CONS, CONS_TO_INTEGER): New macros.
10558 (cons_to_signed, cons_to_unsigned): New decls.
10559 (long_to_cons, cons_to_long): Remove decls.
10560 * undo.c (record_first_change): Use INTEGER_TO_CONS.
10561 (Fprimitive_undo): Use CONS_TO_INTEGER.
10562 * xfns.c (Fx_window_property): Likewise.
10563 * xselect.c: Include <limits.h>.
10564 (x_own_selection, selection_data_to_lisp_data):
10565 Use INTEGER_TO_CONS.
10566 (x_handle_selection_request, x_handle_selection_clear)
10567 (x_get_foreign_selection, Fx_disown_selection_internal)
10568 (Fx_get_atom_name, x_send_client_event): Use CONS_TO_INTEGER.
10569 (lisp_data_to_selection_data): Use cons_to_unsigned.
10570 (x_fill_property_data): Use cons_to_signed.
10571 Report values out of range.
10572
d1f3d2af
PE
10573 Check for buffer and string overflow more precisely.
10574 * buffer.h (BUF_BYTES_MAX): New macro.
10575 * lisp.h (STRING_BYTES_MAX): New macro.
10576 * alloc.c (Fmake_string):
10577 * character.c (string_escape_byte8):
10578 * coding.c (coding_alloc_by_realloc):
10579 * doprnt.c (doprnt):
10580 * editfns.c (Fformat):
10581 * eval.c (verror):
10582 Use STRING_BYTES_MAX, not MOST_POSITIVE_FIXNUM,
10583 since they may not be the same number.
10584 * editfns.c (Finsert_char):
10585 * fileio.c (Finsert_file_contents):
10586 Likewise for BUF_BYTES_MAX.
10587
dd52fcea
PE
10588 * image.c: Use ptrdiff_t, not int, for sizes.
10589 (slurp_file): Switch from int to ptrdiff_t.
10590 All uses changed.
10591 (slurp_file): Check that file size fits in both size_t (for
10592 malloc) and ptrdiff_t (for sanity and safety).
10593
7f9bbdbb
PE
10594 * fileio.c (Fverify_visited_file_modtime): Avoid time overflow
10595 if b->modtime has its maximal value.
10596
dfe18f82
PE
10597 * dired.c (Ffile_attributes): Don't assume EMACS_INT has >32 bits.
10598
84acfcf0
PE
10599 Don't assume time_t can fit into int.
10600 * buffer.h (struct buffer.modtime): Now time_t, not int.
10601 * fileio.c (Fvisited_file_modtime): No need for time_t cast now.
10602 * undo.c (Fprimitive_undo): Use time_t, not int, for time_t value.
10603
ccd9a01a
PE
10604 Minor fixes for signed vs unsigned integers.
10605 * character.h (MAYBE_UNIFY_CHAR):
10606 * charset.c (maybe_unify_char):
10607 * keyboard.c (read_char, reorder_modifiers):
10608 XINT -> XFASTINT, since the integer must be nonnegative.
10609 * ftfont.c (ftfont_spec_pattern):
10610 * keymap.c (access_keymap, silly_event_symbol_error):
10611 XUINT -> XFASTINT, since the integer must be nonnegative.
10612 (Fsingle_key_description, preferred_sequence_p): XUINT -> XINT,
10613 since it makes no difference and we prefer signed.
10614 * keyboard.c (record_char): Use XUINT when all the neighbors do.
10615 (access_keymap): NATNUMP -> INTEGERP, since the integer must be
10616 nonnegative.
10617
d6d100dd
SM
106182011-06-06 Stefan Monnier <monnier@iro.umontreal.ca>
10619
10620 * window.h (Fwindow_frame): Declare.
10621
2b6148e4
PE
106222011-06-06 Paul Eggert <eggert@cs.ucla.edu>
10623
10624 * alloc.c: Simplify handling of large-request failures (Bug#8800).
10625 (SPARE_MEMORY): Always define.
10626 (LARGE_REQUEST): Remove.
10627 (memory_full): Use SPARE_MEMORY rather than LARGE_REQUEST.
10628
f230ecc9
MR
106292011-06-06 Martin Rudalics <rudalics@gmx.at>
10630
727e958e
MR
10631 * lisp.h: Move EXFUNS for Fframe_root_window,
10632 Fframe_first_window and Fset_frame_selected_window to window.h.
10633
10634 * window.h: Move EXFUNS for Fframe_root_window,
10635 Fframe_first_window and Fset_frame_selected_window here from
10636 lisp.h.
10637
10638 * frame.c (Fwindow_frame, Fframe_first_window)
10639 (Fframe_root_window, Fframe_selected_window)
10640 (Fset_frame_selected_window): Move to window.c.
10641 (Factive_minibuffer_window): Move to minibuf.c.
10642 (Fother_visible_frames_p): New function.
10643
10644 * minibuf.c (Factive_minibuffer_window): Move here from frame.c.
10645
f230ecc9
MR
10646 * window.c (decode_window, decode_any_window): Move up in code.
10647 (Fwindowp, Fwindow_live_p): Rewrite doc-strings.
10648 (inhibit_frame_unsplittable): Remove unused variable.
bf60a96b
MR
10649 (Fwindow_buffer): Move up and rewrite doc-string.
10650 (Fwindow_parent, Fwindow_vchild, Fwindow_hchild, Fwindow_next)
10651 (Fwindow_prev): New functions.
727e958e
MR
10652 (Fwindow_frame): Move here from frame.c. Accept any window as
10653 argument.
10654 (Fframe_root_window, Fframe_first_window)
10655 (Fframe_selected_window): Move here from frame.c. Accept frame
10656 or arbitrary window as argument. Update doc-strings.
10657 (Fminibuffer_window): Move up in code.
10658 (Fwindow_minibuffer_p): Move up in code and simplify.
d6d100dd
SM
10659 (Fset_frame_selected_window): Move here from frame.c.
10660 Marginal rewrite.
727e958e
MR
10661 (Fselected_window, select_window, Fselect_window): Move up in
10662 code. Minor doc-string fixes.
f230ecc9 10663
4d09bcf6
PE
106642011-06-06 Paul Eggert <eggert@cs.ucla.edu>
10665
10666 * alloc.c (memory_full) [SYSTEM_MALLOC]: Port to MacOS (Bug#8800).
10667 Do not assume that spare memory exists; that assumption is valid
10668 only if SYSTEM_MALLOC.
10669 (LARGE_REQUEST): New macro, so that the issue of large requests
10670 is separated from the issue of spare memory.
10671
810928a2
AS
106722011-06-05 Andreas Schwab <schwab@linux-m68k.org>
10673
172418ad
AS
10674 * editfns.c (Fformat): Correctly handle zero flag with hexadecimal
10675 format. (Bug#8806)
10676
43f862f7
AS
10677 * gtkutil.c (xg_get_default_scrollbar_width): Avoid warning.
10678
810928a2
AS
10679 * xfns.c (x_set_scroll_bar_default_width): Move declarations
10680 before statements.
10681
a059fe24
JD
106822011-06-05 Jan Djärv <jan.h.d@swipnet.se>
10683
10684 * gtkutil.c (xg_get_default_scrollbar_width): New function.
10685
10686 * gtkutil.h: Declare xg_get_default_scrollbar_width.
10687
10688 * xfns.c (x_set_scroll_bar_default_width): If USE_GTK, get
10689 min width by calling x_set_scroll_bar_default_width (Bug#8505).
10690
989bf368
JB
106912011-06-05 Juanma Barranquero <lekktu@gmail.com>
10692
10693 * xdisp.c (single_display_spec_intangible_p): Remove declaration.
10694
4b80f674
CY
106952011-06-04 Chong Yidong <cyd@stupidchicken.com>
10696
10697 * xselect.c (x_clipboard_manager_save): Remove redundant arg.
10698 (x_clipboard_manager_save): Add return value.
d6d100dd
SM
10699 (x_clipboard_manager_error_1, x_clipboard_manager_error_2):
10700 New error handlers.
4b80f674
CY
10701 (x_clipboard_manager_save_frame, x_clipboard_manager_save_all):
10702 Obey Vx_select_enable_clipboard_manager. Catch errors in
10703 x_clipboard_manager_save (Bug#8779).
10704 (Vx_select_enable_clipboard_manager): New variable.
de65b42c 10705 (x_get_foreign_selection): Reduce scope of x_catch_errors (Bug#8790).
4b80f674 10706
99a33b77 107072011-06-04 Dan Nicolaescu <dann@ics.uci.edu>
8b3115e7
DN
10708
10709 * emacs.c (main): Warn when starting a GTK emacs in daemon mode.
10710
99a33b77 107112011-06-04 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
14eca62f
YM
10712
10713 * fringe.c (update_window_fringes): Don't update overlay arrow bitmap
10714 in the current matrix if keep_current_p is non-zero.
10715
8264569d
EZ
107162011-06-04 Eli Zaretskii <eliz@gnu.org>
10717
10718 * bidi.c (bidi_level_of_next_char): Fix last change.
10719
57f97249
EZ
107202011-06-03 Eli Zaretskii <eliz@gnu.org>
10721
fec2107c 10722 Support bidi reordering of text covered by display properties.
57f97249 10723
fec2107c
EZ
10724 * bidi.c (bidi_copy_it): Use offsetof instead of emulating it.
10725 (bidi_fetch_char, bidi_fetch_char_advance): New functions.
10726 (bidi_cache_search, bidi_cache_iterator_state)
10727 (bidi_paragraph_init, bidi_resolve_explicit, bidi_resolve_weak)
d6d100dd
SM
10728 (bidi_level_of_next_char, bidi_move_to_visually_next):
10729 Support character positions inside a run of characters covered by a
fec2107c
EZ
10730 display string.
10731 (bidi_paragraph_init, bidi_resolve_explicit_1)
10732 (bidi_level_of_next_char): Call bidi_fetch_char and
10733 bidi_fetch_char_advance instead of FETCH_CHAR and
10734 FETCH_CHAR_ADVANCE.
10735 (bidi_init_it): Initialize new members.
10736 (LRE_CHAR, RLE_CHAR, PDF_CHAR, LRO_CHAR, RLO_CHAR): Remove macro
10737 definitions.
10738 (bidi_explicit_dir_char): Lookup character type in bidi_type_table,
10739 instead of using explicit *_CHAR codes.
d6d100dd
SM
10740 (bidi_resolve_explicit, bidi_resolve_weak):
10741 Use FETCH_MULTIBYTE_CHAR instead of FETCH_CHAR, as reordering of
fec2107c
EZ
10742 bidirectional text is supported only in multibyte buffers.
10743 (bidi_init_it): Accept additional argument FRAME_WINDOW_P and use
10744 it to initialize the frame_window_p member of struct bidi_it.
10745 (bidi_cache_iterator_state, bidi_resolve_explicit_1)
10746 (bidi_resolve_explicit, bidi_resolve_weak)
10747 (bidi_level_of_next_char, bidi_move_to_visually_next): Abort if
10748 bidi_it->nchars is non-positive.
10749 (bidi_level_of_next_char): Don't try to lookup the cache for the
10750 next/previous character if nothing is cached there yet, or if we
10751 were just reseat()'ed to a new position.
c40e2fb2 10752
0e14fe90
EZ
10753 * xdisp.c (set_cursor_from_row): Set start and stop points
10754 according to the row's direction when priming the loop that looks
10755 for the glyph on which to display cursor.
10756 (single_display_spec_intangible_p): Function deleted.
10757 (display_prop_intangible_p): Reimplement to call
10758 handle_display_spec instead of single_display_spec_intangible_p.
d6d100dd
SM
10759 Accept 3 additional arguments needed by handle_display_spec.
10760 This fixes incorrect cursor motion across display property with complex
0e14fe90
EZ
10761 values: lists, `(when COND...)' forms, etc.
10762 (single_display_spec_string_p): Support property values that are
10763 lists with the argument STRING its top-level element.
10764 (display_prop_string_p): Fix the condition for processing a
10765 property that is a list to be consistent with handle_display_spec.
fec2107c 10766 (handle_display_spec): New function, refactored from the
fc6f18ce
EZ
10767 last portion of handle_display_prop.
10768 (compute_display_string_pos): Accept additional argument
10769 FRAME_WINDOW_P. Call handle_display_spec to determine whether the
10770 value of a `display' property is a "replacing spec".
10771 (handle_single_display_spec): Accept 2 additional arguments BUFPOS
10772 and FRAME_WINDOW_P. If IT is NULL, don't set up the iterator from
10773 the display property, but just return a value indicating whether
10774 the display property will replace the characters it covers.
10775 (Fcurrent_bidi_paragraph_direction): Initialize the nchars and
10776 frame_window_p members of struct bidi_it.
d6d100dd
SM
10777 (compute_display_string_pos, compute_display_string_end):
10778 New functions.
fec2107c
EZ
10779 (push_it): Accept second argument POSITION, where pop_it should
10780 jump to continue iteration.
10781 (reseat_1): Initialize bidi_it.disp_pos.
fc6f18ce 10782
fec2107c
EZ
10783 * keyboard.c (adjust_point_for_property): Adjust the call to
10784 display_prop_intangible_p to its new signature.
fc6f18ce
EZ
10785
10786 * dispextern.h (struct bidi_it): New member frame_window_p.
fec2107c
EZ
10787 (bidi_init_it): Update prototypes.
10788 (display_prop_intangible_p): Update prototype.
d6d100dd
SM
10789 (compute_display_string_pos, compute_display_string_end):
10790 Declare prototypes.
fec2107c
EZ
10791 (struct bidi_it): New members nchars and disp_pos. ch_len is now
10792 EMACS_INT.
fc6f18ce 10793
40087514 107942011-06-02 Paul Eggert <eggert@cs.ucla.edu>
0de4bb68 10795
57f53182
PE
10796 Malloc failure behavior now depends on size of allocation.
10797 * alloc.c (buffer_memory_full, memory_full): New arg NBYTES.
10798 * lisp.h: Change signatures accordingly.
10799 * alloc.c, buffer.c, editfns.c, menu.c, minibuf.c, xterm.c:
10800 All callers changed. (Bug#8762)
10801
10802 * gnutls.c: Use Emacs's memory allocators.
10803 Without this change, the gnutls library would invoke malloc etc.
10804 directly, which causes problems on non-SYNC_INPUT hosts, and which
10805 runs afoul of improving memory_full behavior. (Bug#8761)
10806 (fn_gnutls_global_set_mem_functions): New macro or function pointer.
10807 (emacs_gnutls_global_init): Use it to specify xmalloc, xrealloc,
10808 xfree instead of the default malloc, realloc, free.
10809 (Fgnutls_boot): No need to check for memory allocation failure,
10810 since xmalloc does that for us.
10811
ac32cd99 10812 Remove arbitrary limit of 2**31 entries in hash tables. (Bug#8771)
3870d916
PE
10813 * category.c (hash_get_category_set):
10814 * ccl.c (ccl_driver):
10815 * charset.c (Fdefine_charset_internal):
10816 * charset.h (struct charset.hash_index):
10817 * composite.c (get_composition_id, gstring_lookup_cache)
10818 (composition_gstring_put_cache):
10819 * composite.h (struct composition.hash_index):
10820 * dispextern.h (struct image.hash):
10821 * fns.c (next_almost_prime, larger_vector, cmpfn_eql)
10822 (cmpfn_equal, cmpfn_user_defined, hashfn_eq, hashfn_eql)
10823 (hashfn_equal, hashfn_user_defined, make_hash_table)
10824 (maybe_resize_hash_table, hash_lookup, hash_put)
10825 (hash_remove_from_table, hash_clear, sweep_weak_table, SXHASH_COMBINE)
10826 (sxhash_string, sxhash_list, sxhash_vector, sxhash_bool_vector)
10827 (Fsxhash, Fgethash, Fputhash, Fmaphash):
10828 * image.c (make_image, search_image_cache, lookup_image)
10829 (xpm_put_color_table_h):
10830 * lisp.h (struct Lisp_Hash_Table):
0de4bb68 10831 * minibuf.c (Ftry_completion, Fall_completions, Ftest_completion):
ac389d0c 10832 * print.c (print): Use 'EMACS_UINT' and 'EMACS_INT'
3870d916 10833 for hashes and hash indexes, instead of 'unsigned' and 'int'.
40087514
PE
10834 * alloc.c (allocate_vectorlike):
10835 Check for overflow in vector size calculations.
10836 * ccl.c (ccl_driver):
10837 Check for overflow when converting EMACS_INT to int.
0de4bb68
PE
10838 * fns.c, image.c: Remove unnecessary static decls that would otherwise
10839 need to be updated by these changes.
40087514
PE
10840 * fns.c (make_hash_table, maybe_resize_hash_table):
10841 Check for integer overflow with large hash tables.
0de4bb68
PE
10842 (make_hash_table, maybe_resize_hash_table, Fmake_hash_table):
10843 Prefer the faster XFLOAT_DATA to XFLOATINT where either will do.
10844 (SXHASH_REDUCE): New macro.
10845 (sxhash_string, sxhash_list, sxhash_vector, sxhash_bool_vector):
10846 Use it instead of discarding useful hash info with large hash values.
10847 (sxhash_float): New function.
10848 (sxhash): Use it. No more need for "& INTMASK" due to above changes.
10849 * lisp.h (FIXNUM_BITS): New macro, useful for SXHASH_REDUCE etc.
40087514
PE
10850 (MOST_NEGATIVE_FIXNUM, MOST_POSITIVE_FIXNUM, INTMASK):
10851 Rewrite to use FIXNUM_BITS, as this simplifies things.
0de4bb68
PE
10852 (next_almost_prime, larger_vector, sxhash, hash_lookup, hash_put):
10853 Adjust signatures to match updated version of code.
10854 (consing_since_gc): Now EMACS_INT, since a single hash table can
10855 use more than INT_MAX bytes.
10856
698d32e2
DN
108572011-06-01 Dan Nicolaescu <dann@ics.uci.edu>
10858
10859 Make it possible to build with GCC-4.6+ -O2 -flto.
10860
10861 * emacs.c (__malloc_initialize_hook): Mark as EXTERNALLY_VISIBLE.
10862
fd6fa53f
SM
108632011-06-01 Stefan Monnier <monnier@iro.umontreal.ca>
10864
10865 * minibuf.c (get_minibuffer, read_minibuf_unwind):
10866 Call minibuffer-inactive-mode.
10867
864db017
JB
108682011-05-31 Juanma Barranquero <lekktu@gmail.com>
10869
10870 * makefile.w32-in ($(BLD)/data.$(O), $(BLD)/editfns.$(O)):
10871 Update dependencies.
10872
2ad0baf4
DN
108732011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
10874
10875 * data.c (init_data): Remove code for UTS, this system is not
10876 supported anymore.
10877
4fcc2638
DN
108782011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
10879
10880 Don't force ./temacs to start in terminal mode.
10881
10882 * frame.c (make_initial_frame): Initialize faces in all cases, not
10883 only when CANNOT_DUMP is defined.
10884 * dispnew.c (init_display): Remove CANNOT_DUMP condition.
10885
c56e0fd5
DN
108862011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
10887
10888 * dispnew.c (add_window_display_history): Use const for the string
10889 pointer. Remove declaration, not needed.
10890
333d54da 108912011-05-31 Paul Eggert <eggert@cs.ucla.edu>
9cf9f756 10892
55d4c1b2 10893 Use 'inline', not 'INLINE'.
333d54da 10894 <http://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00914.html>
55d4c1b2
PE
10895 * alloc.c, fontset.c (INLINE): Remove.
10896 * alloc.c, bidi.c, charset.c, coding.c, dispnew.c, fns.c, image.c:
10897 * intervals.c, keyboard.c, process.c, syntax.c, textprop.c, w32term.c:
10898 * xdisp.c, xfaces.c, xterm.c: Replace all uses of INLINE with inline.
10899 * gmalloc.c (register_heapinfo): Use inline unconditionally.
10900 * lisp.h (LISP_MAKE_RVALUE): Use inline, not __inline__.
10901
738db178
DN
109022011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
10903
10904 Make it possible to run ./temacs.
10905
10906 * callproc.c (set_initial_environment): Remove CANNOT_DUMP code,
10907 syms_of_callproc does the same thing. Remove test for
10908 "initialized", do it in the caller.
10909 * emacs.c (main): Avoid calling set_initial_environment when dumping.
10910
620c53a6
SM
109112011-05-31 Stefan Monnier <monnier@iro.umontreal.ca>
10912
10913 * minibuf.c (Finternal_complete_buffer): Return `category' metadata.
10914 (read_minibuf): Use get_minibuffer.
10915 (syms_of_minibuf): Use DEFSYM.
10916 (Qmetadata): New var.
10917 * data.c (Qbuffer): Don't make it static.
10918 (syms_of_data): Use DEFSYM.
10919
e003a292
PE
109202011-05-31 Paul Eggert <eggert@cs.ucla.edu>
10921
10922 * ccl.c (CCL_CODE_RANGE): Allow negative numbers. (Bug#8751)
10923 (CCL_CODE_MIN): New macro.
10924
ed008a6d
PE
109252011-05-30 Paul Eggert <eggert@cs.ucla.edu>
10926
3687c2ef
PE
10927 * alloc.c (lisp_align_malloc): Omit unnecessary val==NULL tests.
10928
ed008a6d
PE
10929 * eval.c (Qdebug): Now static.
10930 * lisp.h (Qdebug): Remove decl. This reverts a part of the
10931 2011-04-26T11:26:05Z!dan.colascione@gmail.com that inadvertently undid part of
10932 2011-04-14T06:48:41Z!eggert@cs.ucla.edu.
10933
d66c4c7c
CY
109342011-05-29 Chong Yidong <cyd@stupidchicken.com>
10935
10936 * image.c: Various fixes to ImageMagick code comments.
10937 (Fimagemagick_types): Doc fix.
10938
5fbc2025
PE
109392011-05-29 Paul Eggert <eggert@cs.ucla.edu>
10940
0196f88a
PE
10941 Minor fixes prompted by GCC 4.6.0 warnings.
10942
10943 * xselect.c (converted_selections, conversion_fail_tag): Now static.
10944
5fbc2025
PE
10945 * emacs.c [HAVE_X_WINDOWS]: Include "xterm.h".
10946 (x_clipboard_manager_save_all): Move extern decl to ...
10947 * xterm.h: ... here, so that it can be checked for consistency.
10948
1dd3c2d9
CY
109492011-05-29 Chong Yidong <cyd@stupidchicken.com>
10950
10951 * xselect.c (x_clipboard_manager_save_frame)
10952 (x_clipboard_manager_save_all): New functions.
10953 (Fx_clipboard_manager_save): Lisp function deleted.
10954
10955 * emacs.c (Fkill_emacs): Call x_clipboard_manager_save_all.
10956 * frame.c (delete_frame): Call x_clipboard_manager_save_frame.
10957
10958 * xterm.h: Update prototype.
10959
5ba6571d
WX
109602011-05-28 William Xu <william.xwl@gmail.com>
10961
10962 * nsterm.m (ns_term_shutdown): Synchronize user defaults before
10963 exiting (Bug#8239).
10964
3eaff834
JM
109652011-05-28 Jim Meyering <meyering@redhat.com>
10966
e1900994 10967 Avoid a sign-extension bug in crypto_hash_function.
3eaff834
JM
10968 * fns.c (to_uchar): Define.
10969 (crypto_hash_function): Use it to convert some newly-signed
10970 variables to unsigned, to avoid sign-extension bugs. For example,
10971 without this change, (md5 "truc") would evaluate to
10972 45723a2aff78ff4fff7fff1114760e62 rather than the expected
10973 45723a2af3788c4ff17f8d1114760e62. Reported by Antoine Levitt in
e1900994 10974 https://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00883.html.
3eaff834 10975
0f6990a7
PE
109762011-05-27 Paul Eggert <eggert@cs.ucla.edu>
10977
10978 Integer overflow fixes.
c8a9ca5a 10979
08686060
PE
10980 * dbusbind.c: Serial number integer overflow fixes.
10981 (CHECK_DBUS_SERIAL_GET_SERIAL): New macro.
08686060
PE
10982 (Fdbus_call_method_asynchronously, xd_read_message_1): Use a float
10983 to hold a serial number that is too large for a fixnum.
10984 (Fdbus_method_return_internal, Fdbus_method_error_internal):
10985 Check for serial numbers out of range. Decode any serial number
59568bf0 10986 that was so large that it became a float. (Bug#8722)
08686060 10987
2d1fc3c7
PE
10988 * dbusbind.c: Use XFASTINT rather than XUINT, and check for nonneg.
10989 (Fdbus_call_method, Fdbus_call_method_asynchronously):
10990 Use XFASTINT rather than XUINT when numbers are nonnegative.
10991 (xd_append_arg, Fdbus_method_return_internal):
10992 (Fdbus_method_error_internal): Likewise. Also, for unsigned
10993 arguments, check that Lisp number is nonnegative, rather than
59568bf0 10994 silently wrapping negative numbers around. (Bug#8722)
30217ff0 10995 (xd_read_message_1): Don't assume dbus_uint32_t can fit in int.
59568bf0 10996 (Bug#8722)
2d1fc3c7 10997
c8a9ca5a
PE
10998 * data.c (arith_driver, Flsh): Avoid unnecessary casts to EMACS_UINT.
10999
519e1d69
PE
11000 * ccl.c (ccl_driver): Redo slightly to avoid the need for 'unsigned'.
11001
6df6ae42 11002 ccl: Add integer overflow checks.
30569699
PE
11003 * ccl.c (CCL_CODE_MAX, GET_CCL_RANGE, GET_CCL_CODE, GET_CCL_INT):
11004 (IN_INT_RANGE): New macros.
11005 (ccl_driver): Use them to check for integer overflow when
11006 decoding a CCL program. Many of the new checks are whether XINT (x)
11007 fits in int; it doesn't always, on 64-bit hosts. The new version
11008 doesn't catch all possible integer overflows, but it's an
847044ea 11009 improvement. (Bug#8719)
30569699 11010
c11285dc
PE
11011 * alloc.c (make_event_array): Use XINT, not XUINT.
11012 There's no need for unsigned here.
11013
fdccd48e
PE
11014 * mem-limits.h (EXCEEDS_LISP_PTR) [!USE_LSB_TAG]: EMACS_UINT -> uintptr_t
11015 This follows up to the 2011-05-06 change that substituted uintptr_t
11016 for EMACS_INT. This case wasn't caught back then.
11017
37910ab2
PE
11018 Rework Fformat to avoid integer overflow issues.
11019 * editfns.c: Include <float.h> unconditionally, as it's everywhere
11020 now (part of C89). Include <verify.h>.
11021 (MAX_10_EXP, CONVERTED_BYTE_SIZE): Remove; no longer needed.
11022 (pWIDE, pWIDElen, signed_wide, unsigned_wide): New defns.
11023 (Fformat): Avoid the prepass trying to compute sizes; it was only
11024 approximate and thus did not catch overflow reliably. Instead, walk
11025 through the format just once, formatting and computing sizes as we go,
11026 checking for integer overflow at every step, and allocating a larger
11027 buffer as needed. Keep track separately whether the format is
11028 multibyte. Keep only the most-recently calculated precision, rather
11029 than them all. Record whether each argument has been converted to
11030 string. Use EMACS_INT, not int, for byte and char and arg counts.
11031 Support field widths and precisions larger than INT_MAX. Avoid
11032 sprintf's undefined behavior with conversion specifications such as %#d
11033 and %.0c. Fix bug with strchr succeeding on '\0' when looking for
11034 flags. Fix bug with (format "%c" 256.0). Avoid integer overflow when
11035 formatting out-of-range floating point numbers with int
9173deec 11036 formats. (Bug#8668)
37910ab2 11037
2e6578fb
PE
11038 * lisp.h (FIXNUM_OVERFLOW_P): Work even if arg is a NaN.
11039
0ae6bdee
PE
11040 * data.c: Avoid integer truncation in expressions involving floats.
11041 * data.c: Include <intprops.h>.
11042 (arith_driver): When there's an integer overflow in an expression
11043 involving floating point, convert the integers to floating point
11044 so that the resulting value does not suffer from catastrophic
11045 integer truncation. For example, on a 64-bit host (* 4
11046 most-negative-fixnum 0.5) should yield about -4.6e+18, not zero.
11047 Do not rely on undefined behavior after integer overflow.
11048
de883a70
PE
11049 merge count_size_as_multibyte, parse_str_to_multibyte
11050 * character.c, character.h (count_size_as_multibyte):
fd6fa53f 11051 Rename from parse_str_to_multibyte; all uses changed.
de883a70
PE
11052 Check for integer overflow.
11053 * insdel.c, lisp.h (count_size_as_multibyte): Remove,
11054 since it's now a duplicate of the other. This is more of
11055 a character than a buffer op, so better that it's in character.c.
11056 * fns.c, print.c: Adjust to above changes.
11057
2ff916cb
PE
110582011-05-27 Stefan Monnier <monnier@iro.umontreal.ca>
11059
11060 * xselect.c (x_convert_selection): Yet another int/Lisp_Object mixup.
11061
f1b54466
PE
110622011-05-27 Paul Eggert <eggert@cs.ucla.edu>
11063
fb1ac845
PE
11064 * xselect.c: Fix minor problems prompted by GCC 4.6.0 warnings.
11065 (x_handle_selection_request, frame_for_x_selection): Remove unused vars.
11066 (x_clipboard_manager_save): Now static.
11067 (Fx_clipboard_manager_save): Rename local to avoid shadowing.
11068
f1b54466
PE
11069 * fns.c: Fix minor problems prompted by GCC 4.6.0 warnings.
11070 (crypto_hash_function): Now static.
11071 Fix pointer signedness problems. Avoid unnecessary initializations.
11072
a9f737ee
CY
110732011-05-27 Chong Yidong <cyd@stupidchicken.com>
11074
11075 * termhooks.h (Vselection_alist): Make it terminal-local.
11076
11077 * terminal.c (create_terminal): Initialize it.
11078
11079 * xselect.c: Support for clipboard managers.
11080 (Vselection_alist): Move to termhooks.h as terminal-local var.
11081 (LOCAL_SELECTION): New macro.
11082 (x_atom_to_symbol): Handle x_display_info_for_display fail case.
11083 (symbol_to_x_atom): Remove gratuitous arg.
11084 (x_handle_selection_request, lisp_data_to_selection_data)
11085 (x_get_foreign_selection, Fx_register_dnd_atom): Callers changed.
620c53a6
SM
11086 (x_own_selection, x_get_local_selection, x_convert_selection):
11087 New arg, specifying work frame. Use terminal-local Vselection_alist.
a9f737ee
CY
11088 (some_frame_on_display): Delete unused function.
11089 (Fx_own_selection_internal, Fx_get_selection_internal)
11090 (Fx_disown_selection_internal, Fx_selection_owner_p)
11091 (Fx_selection_exists_p): New optional frame arg.
11092 (frame_for_x_selection, Fx_clipboard_manager_save): New functions.
11093 (x_handle_selection_clear): Don't treat other terminals with the
11094 same keyboard specially. Use the terminal-local Vselection_alist.
11095 (x_clear_frame_selections): Use Frun_hook_with_args.
11096
11097 * xterm.c (x_term_init): Intern ATOM and CLIPBOARD_MANAGER atoms.
11098
11099 * xterm.h: Add support for those atoms.
11100
e067f0c1
CY
111012011-05-26 Chong Yidong <cyd@stupidchicken.com>
11102
11103 * xselect.c: ICCCM-compliant handling of MULTIPLE targets.
11104 (converted_selections, conversion_fail_tag): New global variables.
11105 (x_selection_request_lisp_error): Free the above.
11106 (x_get_local_selection): Remove unnecessary code.
11107 (x_reply_selection_request): Args changed; handle arbitrary array
620c53a6
SM
11108 of converted selections stored in converted_selections.
11109 Separate the XChangeProperty and SelectionNotify steps.
e067f0c1
CY
11110 (x_handle_selection_request): Rewrite to handle MULTIPLE target.
11111 (x_convert_selection): New function.
11112 (x_handle_selection_event): Simplify.
11113 (x_get_foreign_selection): Don't ignore incoming requests while
11114 waiting for an answer; this will fail when we implement
11115 SAVE_TARGETS, and seems unnecessary anyway.
11116 (selection_data_to_lisp_data): Recognize ATOM_PAIR type.
11117 (Vx_sent_selection_functions): Doc fix.
11118
0f4aebc0
LL
111192011-05-26 Leo Liu <sdl.web@gmail.com>
11120
11121 * editfns.c (Ftranspose_regions): Allow empty regions. (Bug#8699)
11122
e61124cd
YM
111232011-05-25 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
11124
11125 * dispextern.h (struct glyph_row): New member fringe_bitmap_periodic_p.
11126
11127 * dispnew.c (shift_glyph_matrix, scrolling_window): Mark scrolled row
11128 for fringe update if it has periodic bitmap.
ac389d0c 11129 (row_equal_p): Also compare left_fringe_offset, right_fringe_offset,
e61124cd
YM
11130 and fringe_bitmap_periodic_p.
11131
11132 * fringe.c (get_fringe_bitmap_data): New function.
11133 (draw_fringe_bitmap_1, update_window_fringes): Use it.
11134 (update_window_fringes): Record periodicity of fringe bitmap in glyph
11135 row. Mark glyph row for fringe update if periodicity changed.
11136
11137 * xdisp.c (try_window_reusing_current_matrix): Don't mark scrolled row
11138 for fringe update unless it has periodic bitmap.
11139
f16d9837
KH
111402011-05-25 Kenichi Handa <handa@m17n.org>
11141
11142 * xdisp.c (get_next_display_element): Set correct it->face_id for
11143 a static composition.
11144
e1b90ef6
LL
111452011-05-24 Leo Liu <sdl.web@gmail.com>
11146
11147 * deps.mk (fns.o):
11148 * makefile.w32-in ($(BLD)/fns.$(O)): Include sha1.h.
11149
11150 * fns.c (crypto_hash_function, Fsha1): New function.
11151 (Fmd5): Use crypto_hash_function.
11152 (syms_of_fns): Add Ssha1.
11153
7400048f
PE
111542011-05-22 Paul Eggert <eggert@cs.ucla.edu>
11155
11156 * gnutls.c: Remove unused macros.
11157 (fn_gnutls_transport_set_lowat, fn_gnutls_transport_set_pull_function):
11158 (fn_gnutls_transport_set_push_function) [!WINDOWSNT]:
11159 Remove macros that are defined and never used.
11160 Caught by gcc -Wunused-macros (GCC 4.6.0, Fedora 14).
11161
abb71cf4
CY
111622011-05-22 Chong Yidong <cyd@stupidchicken.com>
11163
11164 * xselect.c (syms_of_xselect): Remove unused symbol SAVE_TARGETS.
11165 (Fx_get_selection_internal): Minor cleanup.
11166 (Fx_own_selection_internal): Rename arguments for consistency with
11167 select.el.
11168
6307db39
PE
111692011-05-22 Paul Eggert <eggert@cs.ucla.edu>
11170
11171 * xselect.c (QSAVE_TARGETS): New static var, to fix build failure.
11172
f3d4e0a4
CY
111732011-05-22 Chong Yidong <cyd@stupidchicken.com>
11174
11175 * xselect.c (syms_of_xselect): Include character.h; use DEFSYM.
11176
4d8ade89
YM
111772011-05-21 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
11178
11179 * dispnew.c (scrolling_window): Don't exclude the case that the
11180 last enabled row in the desired matrix touches the bottom boundary.
11181
32078c8d
GM
111822011-05-21 Glenn Morris <rgm@gnu.org>
11183
11184 * Makefile.in ($(etc)/DOC): Make second command line even shorter.
33cf345f
GM
11185 (SOME_MACHINE_OBJECTS): Replace FONT_OBJ by its maximal expansion,
11186 and add some more files.
32078c8d 11187
7285dc67
EZ
111882011-05-20 Eli Zaretskii <eliz@gnu.org>
11189
11190 * callproc.c (Fcall_process) [MSDOS]: Fix arguments to
11191 report_file_error introduced by the change from 2011-05-07.
11192
89d1bd22
PE
111932011-05-20 Paul Eggert <eggert@cs.ucla.edu>
11194
11195 * systime.h (Time): Define only if emacs is defined.
11196 This is to allow ../lib-src/profile.c to be compiled on FreeBSD,
11197 where the include path doesn't have X11/X.h by default. See
11198 <http://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00561.html>.
11199
cd394be1 112002011-05-20 Kenichi Handa <handa@m17n.org>
31bfc35c
KH
11201
11202 * composite.c (find_automatic_composition): Fix previous change.
11203
b9704ad9
GM
112042011-05-20 Glenn Morris <rgm@gnu.org>
11205
11206 * lisp.mk: New file, split from Makefile.in.
11207 * Makefile.in (lisp): Move to separate file, inserted by @lisp_frag@.
11208 (shortlisp): Remove.
11209 ($(etc)/DOC): Edit lisp.mk rather than using $shortlisp.
11210
4a720484
GM
112112011-05-19 Glenn Morris <rgm@gnu.org>
11212
11213 * Makefile.in (MSDOS_SUPPORT_REAL, MSDOS_SUPPORT, NS_SUPPORT)
11214 (REAL_MOUSE_SUPPORT, GPM_MOUSE_SUPPORT, MOUSE_SUPPORT, TOOLTIP_SUPPORT)
11215 (BASE_WINDOW_SUPPORT, X_WINDOW_SUPPORT, WINDOW_SUPPORT): Remove.
11216 (lisp): Set the order to that of loadup.el.
11217 (shortlisp): Make it a copy of $lisp.
11218 (SOME_MACHINE_LISP): Remove.
11219 ($(etc)/DOC): Depend just on $lisp, not $SOME_MACHINE_LISP too.
11220 Use just $shortlisp, not $SOME_MACHINE_LISP too.
11221
a28d4396
KH
112222011-05-18 Kenichi Handa <handa@m17n.org>
11223
11224 * composite.c (CHAR_COMPOSABLE_P): Add more check for efficiency.
11225 (BACKWARD_CHAR): Wrap the arg STOP by parenthesis.
11226 (find_automatic_composition): Mostly rewrite for efficiency.
11227
a2b1fa8e
JB
112282011-05-18 Juanma Barranquero <lekktu@gmail.com>
11229
11230 * makefile.w32-in: Update dependencies.
11231
8e1f5610
CS
112322011-05-18 Christoph Scholtes <cschol2112@googlemail.com>
11233
11234 * menu.c: Include limits.h (fixes the MS-Windows build broken by
7d7d0045 11235 2011-06-18T18:49:19Z!cyd@stupidchicken.com).
8e1f5610 11236
7025ee00 112372011-05-18 Paul Eggert <eggert@cs.ucla.edu>
cb93f9be 11238
cdfa6eab
PE
11239 Fix some integer overflow issues, such as string length overflow.
11240
06d6db33
PE
11241 * insdel.c (count_size_as_multibyte): Check for string overflow.
11242
2b4560a8
PE
11243 * character.c (lisp_string_width): Check for string overflow.
11244 Use EMACS_INT, not int, for string indexes and lengths; in
11245 particular, 2nd arg is now EMACS_INT, not int. Do not crash if
11246 the resulting string length overflows an EMACS_INT; instead,
11247 report a string overflow if no precision given. When checking for
11248 precision exhaustion, use a check that cannot possibly have
11249 integer overflow. (Bug#8675)
11250 * character.h (lisp_string_width): Adjust to new signature.
11251
cb93f9be
PE
11252 * alloc.c (string_overflow): New function.
11253 (Fmake_string): Use it. This doesn't change behavior, but saves
11254 a few bytes and will simplify future changes.
11255 * character.c (string_escape_byte8): Likewise.
11256 * lisp.h (string_overflow): New decl.
11257
1a1f3366
PE
11258 Fixups, following up to the user-interface timestamp change.
11259 * nsterm.m (last_mouse_movement_time, ns_mouse_position): Use Time
11260 for UI timestamps, instead of unsigned long.
9fbd6841
PE
11261 * msdos.c (mouse_get_pos): Likewise.
11262 * w32inevt.c (movement_time, w32_console_mouse_position): Likewise.
1a1f3366
PE
11263 * w32gui.h (Time): Define by including "systime.h" rather than by
11264 declaring it ourselves. (Bug#8664)
11265
d4e3e4d3
PE
11266 * dispextern.h (struct image): Don't assume time_t <= unsigned long.
11267 * image.c (clear_image_cache): Likewise.
11268
f6a24d19
PE
11269 * term.c (term_mouse_position): Don't assume time_t wraparound.
11270
08dc5ae6
PE
11271 Be more systematic about user-interface timestamps.
11272 Before, the code sometimes used 'Time', sometimes 'unsigned long',
620c53a6
SM
11273 and sometimes 'EMACS_UINT', to represent these timestamps.
11274 This change causes it to use 'Time' uniformly, as that's what X uses.
08dc5ae6
PE
11275 This makes the code easier to follow, and makes it easier to catch
11276 integer overflow bugs such as Bug#8664.
11277 * frame.c (Fmouse_position, Fmouse_pixel_position):
11278 Use Time, not unsigned long, for user-interface timestamps.
11279 * keyboard.c (last_event_timestamp, kbd_buffer_get_event): Likewise.
11280 (button_down_time, make_lispy_position, make_lispy_movement): Likewise.
11281 * keyboard.h (last_event_timestamp): Likewise.
11282 * menu.c (Fx_popup_menu) [!HAVE_X_WINDOWS]: Likewise.
11283 * menu.h (xmenu_show): Likewise.
11284 * term.c (term_mouse_position): Likewise.
11285 * termhooks.h (struct input_event.timestamp): Likewise.
11286 (struct terminal.mouse_position_hook): Likewise.
11287 * xmenu.c (create_and_show_popup_menu, xmenu_show): Likewise.
11288 * xterm.c (XTmouse_position, x_scroll_bar_report_motion): Likewise.
11289 * systime.h (Time): New decl. Pull it in from <X11/X.h> if
11290 HAVE_X_WINDOWS, otherwise define it as unsigned long, which is
11291 what it was before.
11292 * menu.h, termhooks.h: Include "systime.h", for Time.
11293
8e55734a
PE
11294 * keyboard.c (make_lispy_event): Fix problem in integer overflow.
11295 Don't assume that the difference between two unsigned long values
11296 can fit into an integer. At this point, we know button_down_time
11297 <= event->timestamp, so the difference must be nonnegative, so
11298 there's no need to cast the result if double-click-time is
11299 nonnegative, as it should be; check that it's nonnegative, just in
11300 case. This bug is triggered when events are more than 2**31 ms
86db42d2 11301 apart (about 25 days). (Bug#8664)
8e55734a 11302
841f1b75 11303 * xselect.c (last_event_timestamp): Remove duplicate decl.
6434756c 11304 (x_own_selection): Remove needless cast to unsigned long.
841f1b75 11305
3e26f69c
PE
11306 * xmenu.c (set_frame_menubar): Use int, not EMACS_UINT, for indexes
11307 that always fit in int. Use a sentinel instead of a counter, to
11308 avoid a temp and to allay GCC's concerns about possible int overflow.
d230cb74
PE
11309 * frame.h (struct frame): Use int for menu_bar_items_used
11310 instead of EMACS_INT, since it always fits in int.
3e26f69c 11311
5cc152c0
PE
11312 * menu.c (grow_menu_items): Check for int overflow.
11313
d89eb65e
PE
11314 * xmenu.c (set_frame_menubar): Don't mishandle vectors with no nils.
11315
5235bd3e
PE
11316 * xterm.c: Use EMACS_INT for Emacs modifiers, and int for X modifiers.
11317 Before, the code was not consistent. These values cannot exceed
11318 2**31 - 1 so there's no need to make them unsigned.
11319 (x_x_to_emacs_modifiers): Accept int and return EMACS_INT.
11320 (x_emacs_to_x_modifiers): Accept EMACS_INT and return int.
11321 (x_x_to_emacs_modifiers, x_emacs_to_x_modifiers): Reject non-integers
11322 as modifiers.
11323 * xterm.h (x_x_to_emacs_modifiers): Adjust to signature change.
11324
bc827e23
PE
11325 * lisp.h (XINT) [USE_LISP_UNION_TYPE]: Cast to EMACS_INT.
11326 (XUINT) [USE_LISP_UNION_TYPE]: Cast to EMACS_UINT.
11327 Otherwise, GCC 4.6.0 warns about printf (pI, XINT (...)),
11328 presumably because the widths might not match.
11329
78eb494e
PE
11330 * window.c (size_window): Avoid needless test at loop start.
11331
04f2d78b
CB
113322011-05-18 Courtney Bane <emacs-bugs-7626@cbane.org> (tiny change)
11333
11334 * term.c (Fresume_tty): Restore hooks before reinitializing (bug#8687).
11335
d2fc7e3d 113362011-05-12 Drew Adams <drew.adams@oracle.com>
e531bdff
DA
11337
11338 * textprop.c (Fprevious_single_char_property_change): Doc fix (bug#8655).
11339
d2fc7e3d 113402011-05-12 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
7db47798
YM
11341
11342 * w32term.c (w32_draw_fringe_bitmap): Rename local vars `left' and
11343 `width' to `bar_area_x' and `bar_area_width', respectively.
11344 (x_scroll_run): Take account of fringe background extension.
11345
04f2d78b
CB
11346 * xterm.c (x_draw_fringe_bitmap) [USE_TOOLKIT_SCROLL_BARS]:
11347 Rename local vars `left' and `width' to `bar_area_x' and
7db47798
YM
11348 `bar_area_width', respectively.
11349 (x_scroll_run) [USE_TOOLKIT_SCROLL_BARS]: Take account of fringe
11350 background extension.
11351
79b70037
GM
113522011-05-10 Jim Meyering <meyering@redhat.com>
11353
11354 * xdisp.c (x_intersect_rectangles): Fix typo "the the -> the".
11355
2f142cc5
JB
113562011-05-10 Juanma Barranquero <lekktu@gmail.com>
11357
11358 * image.c (Finit_image_library): Return t for built-in image types,
11359 like pbm and xbm. (Bug#8640)
11360
57679c86
AS
113612011-05-09 Andreas Schwab <schwab@linux-m68k.org>
11362
11363 * w32menu.c (set_frame_menubar): Fix submenu allocation.
11364
888c9e86
EZ
113652011-05-07 Eli Zaretskii <eliz@gnu.org>
11366
b0512a1d
EZ
11367 * w32console.c (Fset_screen_color): Doc fix.
11368 (Fget_screen_color): New function.
11369 (syms_of_ntterm): Defsubr it.
11370
7285dc67
EZ
11371 * callproc.c (call_process_cleanup) [MSDOS]: Don't close and
11372 unlink the temporary file if Fcall_process didn't create it in the
11373 first place.
11374 (Fcall_process) [MSDOS]: Don't create tempfile if stdout of the
11375 child process will be redirected to a file specified with `:file'.
888c9e86
EZ
11376 Don't try to re-open tempfile in that case, and set fd[0] to -1 as
11377 cue to call_process_cleanup not to close that handle.
11378
4d3fcc8e
BK
113792011-05-07 Ben Key <bkey76@gmail.com>
11380
11381 * makefile.w32-in: The bootstrap-temacs rule now makes use of
11382 one of two shell specific rules, either bootstrap-temacs-CMD or
11383 bootstrap-temacs-SH. The bootstrap-temacs-SH rule is identical
11384 to the previous implementation of the bootstrap-temacs rule.
11385 The bootstrap-temacs-CMD rule is similar to the previous
11386 implementation of the bootstrap-temacs rule except that it
11387 makes use of the ESC_CFLAGS variable instead of the CFLAGS
11388 variable.
11389
11390 These changes, along with some changes to nt/configure.bat,
11391 nt/gmake.defs, and nt/nmake.defs, are required to extend my
11392 earlier fix to add support for --cflags and --ldflags options
11393 that include quotes so that it works whether make uses cmd or
11394 sh as the shell.
11395
b4289b64
MA
113962011-05-06 Michael Albinus <michael.albinus@gmx.de>
11397
11398 * dbusbind.c (QCdbus_type_unix_fd): Declare static.
11399 (xd_remove_watch): Don't check QCdbus_type_unix_fd for SYMBOLP, it
11400 is a constant.
11401 (Fdbus_init_bus, xd_read_queued_messages): Bus can be a symbol or
11402 a string. Handle both cases.
11403 (Fdbus_call_method_asynchronously, Fdbus_register_signal)
11404 (Fdbus_register_method): Use Qinvalid_function.
11405
af4c0e28
JB
114062011-05-06 Juanma Barranquero <lekktu@gmail.com>
11407
11408 * makefile.w32-in: Update dependencies.
11409 (LISP_H): Add inttypes.h and stdin.h.
11410 (PROCESS_H): Add unistd.h.
11411
c51453d9
EZ
114122011-05-06 Eli Zaretskii <eliz@gnu.org>
11413
11414 * lread.c: Include limits.h (fixes the MS-Windows build broken by
11415 2011-05-06T07:13:19Z!eggert@cs.ucla.edu).
11416
8ff0ac3c 114172011-05-06 Paul Eggert <eggert@cs.ucla.edu>
c032b5f8 11418
4c4b566b
PE
11419 * image.c (Finit_image_library) [!HAVE_NTGUI]: Omit unused local.
11420
aab2b9b5
PE
11421 * term.c (vfatal): Remove stray call to va_end.
11422 It's not needed and the C Standard doesn't allow it here anyway.
11423
c378da0b
PE
11424 Use C99's va_copy to avoid undefined behavior on x86-64 GNU/Linux.
11425 * eval.c (verror): doprnt a copy of ap, not the original. (Bug#8545)
11426
288b08c7
PE
11427 * eval.c (verror): OK to create a string of up to MOST_POSITIVE_FIXNUM
11428 bytes.
11429
e3601888
PE
11430 * term.c: Don't include <stdarg.h>, as <lisp.h> does that.
11431
db6c0e74
PE
11432 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork clobbering.
11433
dd5963ea
PE
11434 * process.c (Fformat_network_address): Fix typo: args2 -> *args2.
11435
88c9450f
PE
11436 * xmenu.c (set_frame_menubar): Fix typo: int * -> int (3 times).
11437
2f9442b8
PE
11438 * coding.c (detect_coding_charset): Fix typo: * 2 -> *4 (Bug#8601).
11439
c032b5f8
PE
11440 * charset.h (struct charset.code_space): Now has 15 elements, not 16.
11441 * charset.c (Fdefine_charset_internal): Don't initialize
11442 charset.code_space[15]. The value was garbage, on hosts with
2d38271b 11443 32-bit int (Bug#8600).
a108c10b
PE
11444
11445 * lread.c (read_integer): Be more consistent with string-to-number.
11446 Use string_to_number to do the actual conversion; this avoids
11447 rounding errors and fixes some other screwups. Without this fix,
11448 for example, #x1fffffffffffffff was misread as -2305843009213693952.
11449 (digit_to_number): Move earlier, for benefit of read_integer.
11450 Return -1 if the digit is out of range for the base, -2 if it is
48e400f0 11451 not a digit in any supported base. (Bug#8602)
a108c10b 11452
ad5f9eea
PE
11453 * doprnt.c (doprnt): Support arbitrary pI values, such as "I64".
11454
aec1708a
PE
11455 * dispnew.c (scrolling_window): Return 1 if we scrolled,
11456 to match comment at start of function. This also removes a
11457 GCC warning about overflow in a 32+64-bit port.
11458
47be4ab5
PE
11459 * lisp.h (EMACS_INT, EMACS_UINT, BITS_PER_EMACS_INT, pI): Simplify.
11460
371cac43
PE
11461 * dbusbind.c: Do not use XPNTR on a value that may be an integer.
11462 Reported by Stefan Monnier in
11463 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00919.html>.
04f2d78b
CB
11464 (xd_remove_watch, Fdbus_init_bus, xd_read_queued_messages):
11465 Use SYMBOLP-guarded XSYMBOL, not XPNTR.
371cac43 11466
d01a7826
PE
11467 * lisp.h (EMACS_INTPTR): Remove. All uses changed to intptr_t.
11468 (EMACS_UINTPTR): Likewise, with uintptr_t.
11469
7fd47d5c
PE
11470 * lisp.h: Prefer 64-bit EMACS_INT if available.
11471 (EMACS_INT, EMACS_UINT, BITS_PER_EMACS_INT, pI): Define to 64-bit
11472 on 32-bit hosts that have 64-bit int, so that they can access
11473 large files.
122b0c86
PE
11474 However, temporarily disable this change unless the temporary
11475 symbol WIDE_EMACS_INT is defined.
7fd47d5c 11476
8727937b
PE
11477 * lread.c, process.c: Do not include <inttypes.h>; lisp.h does it now.
11478
8ac068ac
PE
11479 Prefer intptr_t/uintptr_t for integers the same widths as pointers.
11480 This removes an assumption that EMACS_INT and long are the same
11481 width as pointers. The assumption is true for Emacs porting targets
11482 now, but we want to make other targets possible.
11483 * lisp.h: Include <inttypes.h>, for INTPTR_MAX, UINTPTR_MAX.
11484 (EMACS_INTPTR, EMACS_UINTPTR): New macros.
11485 In the rest of the code, change types of integers that hold casted
11486 pointers to EMACS_INTPTR and EMACS_UINTPTR, systematically
11487 replacing EMACS_INT, long, EMACS_UINT, and unsigned long.
11488 (XTYPE): Don't cast arg to EMACS_UINT; normally is not needed.
11489 (XSET): Cast type of XTYPE arg to EMACS_INTPTR; it is needed here.
11490 No need to cast type when ORing.
11491 (XPNTR): Return a value of type EMACS_INTPTR or EMACS_UINTPTR.
11492 * alloc.c (lisp_align_malloc): Remove a no-longer-needed cast.
11493 * doc.c (store_function_docstring): Use EMACS_INTPTR, so as not to
11494 assume EMACS_INT is the same width as char *.
11495 * gtkutil.c (xg_gtk_scroll_destroy, xg_tool_bar_button_cb):
11496 (xg_tool_bar_callback, xg_tool_bar_help_callback, xg_make_tool_item):
11497 Remove no-longer-needed casts.
11498 (xg_create_scroll_bar, xg_tool_bar_button_cb, xg_tool_bar_callback):
11499 (xg_tool_bar_help_callback, xg_make_tool_item):
11500 Use EMACS_INTPTR to hold an integer
11501 that will be cast to void *; this can avoid a GCC warning
11502 if EMACS_INT is not the same width as void *.
11503 * menu.c (find_and_call_menu_selection): Remove no-longer-needed cast.
11504 * xdisp.c (display_echo_area_1, resize_mini_window_1):
11505 (current_message_1, set_message_1):
11506 Use a local to convert to proper width without a cast.
11507 * xmenu.c (dialog_selection_callback): Likewise.
11508
ede49d71
PE
11509 * sysdep.c (get_random): Don't assume EMACS_INT is no wider than long.
11510 Also, don't assume VALBITS / RAND_BITS is less than 5,
11511 and don't rely on undefined behavior when shifting a 1 left into
11512 the sign bit.
11513 * lisp.h (get_random): Change signature to match.
11514
2f30ecd0
PE
11515 * lread.c (hash_string): Use size_t, not int, for hash computation.
11516 Normally we prefer signed values; but hashing is special, because
11517 it's better to use unsigned division on hash table sizes so that
11518 the remainder is nonnegative. Also, size_t is the natural width
11519 for hashing into memory. The previous code used 'int', which doesn't
11520 retain enough info to hash well into very large tables.
11521 (oblookup, oblookup_last_bucket_number, Funintern): Likewise.
11522
2a866e7b
PE
11523 * dbusbind.c: Don't possibly lose pointer info when converting.
11524 (xd_remove_watch, Fdbus_init_bus, xd_read_queued_messages):
11525 Use XPNTR rather than XHASH, so that the high-order bits of
11526 the pointer aren't lost when converting through void *.
11527
51639eac
PE
11528 * eval.c (Fautoload): Don't double-shift a pointer.
11529
92394119
PE
11530 * fns.c (Frandom): Let EMACS_UINT be wider than unsigned long.
11531
dbdb9a7c
JB
115322011-05-06 Juanma Barranquero <lekktu@gmail.com>
11533
11534 * gnutls.c (DEF_GNUTLS_FN):
11535 * image.c (DEF_IMGLIB_FN): Make function pointers static.
11536
db7a0b4f
AS
115372011-05-05 Andreas Schwab <schwab@linux-m68k.org>
11538
11539 * lread.c (lisp_file_lexically_bound_p): Stop scanning at end
11540 marker. (Bug#8610)
11541
cd394be1 115422011-05-05 Eli Zaretskii <eliz@gnu.org>
fab624aa
EZ
11543
11544 * w32heap.c (allocate_heap) [USE_LISP_UNION_TYPE || USE_LSB_TAG]:
11545 New version that can reserve upto 2GB of heap space.
11546
f7ff1b0f 115472011-05-05 Chong Yidong <cyd@stupidchicken.com>
45cb8994
CY
11548
11549 * nsfns.m (Fns_read_file_name): Doc fix (Bug#8534).
11550
639c109b
TZ
115512011-05-05 Teodor Zlatanov <tzz@lifelogs.com>
11552
11553 * gnutls.c (fn_gnutls_certificate_set_x509_key_file): Add alias to
11554 `gnutls_certificate_set_x509_key_file'.
11555
d2127135
JB
115562011-05-05 Juanma Barranquero <lekktu@gmail.com>
11557
11558 * makefile.w32-in ($(BLD)/image.$(O), $(BLD)/process.$(O)):
11559 Update dependencies.
11560
e968f4f3
JB
115612011-05-04 Juanma Barranquero <lekktu@gmail.com>
11562
11563 * gnutls.h (emacs_gnutls_write, emacs_gnutls_read):
11564 * gnutls.c (emacs_gnutls_write, emacs_gnutls_read):
11565 Remove unused parameter `fildes'.
11566 * process.c (read_process_output, send_process): Don't pass it.
11567
84d358f0
JB
115682011-05-04 Juanma Barranquero <lekktu@gmail.com>
11569
11570 Fix previous change: the library cache is defined in w32.c.
11571 * image.c (CACHE_IMAGE_TYPE) [!HAVE_NTGUI]: Define to noop.
11572 (Finit_image_library): Wrap Vlibrary_cache on "#ifdef HAVE_NTGUI".
11573
0898ca10
JB
115742011-05-04 Juanma Barranquero <lekktu@gmail.com>
11575
11576 Implement dynamic loading of GnuTLS on Windows.
11577
11578 * gnutls.h (GNUTLS_EMACS_ERROR_NOT_LOADED): New macro.
11579 (emacs_gnutls_write, emacs_gnutls_read): Mark as extern.
11580 (emacs_gnutls_record_check_pending, emacs_gnutls_transport_set_errno):
11581 Declare.
11582
11583 * gnutls.c (Qgnutls_dll): Define.
11584 (DEF_GNUTLS_FN, LOAD_GNUTLS_FN): New macros.
11585 (gnutls_*): Declare function pointers.
11586 (init_gnutls_functions): New function to initialize function pointers.
11587 (emacs_gnutls_handshake, Fgnutls_error_string, Fgnutls_deinit)
11588 (emacs_gnutls_global_init, Fgnutls_bye): Use function pointers.
11589 (emacs_gnutls_record_check_pending, emacs_gnutls_transport_set_errno):
11590 Wrappers for gnutls_record_check_pending and gnutls_transport_set_errno.
11591 (emacs_gnutls_write, emacs_gnutls_read)
11592 (emacs_gnutls_handle_error, Fgnutls_error_fatalp)
11593 (Fgnutls_available_p): New function.
11594 (Fgnutls_boot): Call Fgnutls_available_p. Use function pointers.
11595 (syms_of_gnutls) <Qgnutls_dll>: Initialize and staticpro it.
11596 (syms_of_gnutls) <Sgnutls_available_p>: defsubr it.
11597
11598 * image.c: Include w32.h.
11599 (Vimage_type_cache): Delete.
11600 (syms_of_image) <Vimage_type_cache>: Don't initialize and staticpro it.
11601 (CACHE_IMAGE_TYPE, Finit_image_library): Use Vlibrary_cache instead.
11602 (w32_delayed_load): Move to w32.c.
11603
11604 * w32.h (VlibraryCache, QCloaded_from, w32_delayed_load): Declare.
11605
11606 * w32.c (QCloaded_from, Vlibrary_cache): Define.
11607 (w32_delayed_load): Move from image.c. When loading a library, record
11608 its filename in the :loaded-from property of the library id.
11609 (globals_of_w32) <QCloaded_from, Vlibrary_cache>:
11610 Initialize and staticpro them.
11611 (emacs_gnutls_pull, emacs_gnutls_push): Call emacs_gnutls_* functions.
11612
11613 * process.c: Include lisp.h before w32.h, not after.
11614 (wait_reading_process_output): Call emacs_gnutls_record_check_pending
11615 instead of gnutls_record_check_pending.
11616
11617 * callproc.c, emacs.c: Include lisp.h before w32.h, not after.
11618
ff4de4aa
TZ
116192011-05-04 Teodor Zlatanov <tzz@lifelogs.com>
11620
11621 * gnutls.c (Fgnutls_boot): Support :keylist and :crlfiles options
11622 instead of :keyfiles. Give GnuTLS the keylist and the CRL lists
11623 as passed in.
11624
abe95abb
JD
116252011-05-03 Jan Djärv <jan.h.d@swipnet.se>
11626
11627 * xterm.c (x_set_frame_alpha): Do not set property on anything
11628 else than FRAME_X_OUTER_WINDOW (Bug#8608).
11629
e16e55d4
JB
116302011-05-02 Juanma Barranquero <lekktu@gmail.com>
11631
11632 * sysdep.c (get_tty_size) [WINDOWSNT]: Implement. (Bug#8596)
11633
bafcf6a5
JB
116342011-05-02 Juanma Barranquero <lekktu@gmail.com>
11635
11636 * gnutls.c (Qgnutls_log_level, Qgnutls_code, Qgnutls_anon)
11637 (Qgnutls_x509pki, Qgnutls_e_interrupted, Qgnutls_e_again)
11638 (Qgnutls_e_invalid_session, Qgnutls_e_not_ready_for_handshake)
11639 (gnutls_global_initialized, Qgnutls_bootprop_priority)
11640 (Qgnutls_bootprop_trustfiles, Qgnutls_bootprop_keyfiles)
11641 (Qgnutls_bootprop_callbacks, Qgnutls_bootprop_loglevel)
11642 (Qgnutls_bootprop_hostname, Qgnutls_bootprop_verify_flags)
11643 (Qgnutls_bootprop_verify_error, Qgnutls_bootprop_verify_hostname_error)
11644 (Qgnutls_bootprop_callbacks_verify): Make static.
11645
e7a6747f
AS
116462011-05-01 Andreas Schwab <schwab@linux-m68k.org>
11647
19ed11ba
AS
11648 * callproc.c: Indentation fixup.
11649
e7a6747f 11650 * sysdep.c (wait_for_termination_1): Make static.
04f2d78b
CB
11651 (wait_for_termination, interruptible_wait_for_termination):
11652 Move after wait_for_termination_1.
e7a6747f 11653
1ef14cb4
LMI
116542011-05-01 Lars Magne Ingebrigtsen <larsi@gnus.org>
11655
11656 * sysdep.c (interruptible_wait_for_termination): New function
11657 which is like wait_for_termination, but allows keyboard
11658 interruptions.
11659
11660 * callproc.c (Fcall_process): Add (:file "file") as an option for
11661 the STDOUT buffer.
11662 (Fcall_process_region): Ditto.
11663
330d880c
EZ
116642011-04-30 Eli Zaretskii <eliz@gnu.org>
11665
8db90b73
EZ
11666 * dosfns.c (Fint86, Fdos_memget, Fdos_memput): Use `ASIZE (FOO)'
11667 rather than `XVECTOR (FOO)->size'.
11668
330d880c
EZ
11669 * process.c: Remove HAVE_INTTYPES_H condition from inclusion of
11670 inttypes.h, as a gnulib replacement is used if it not available in
11671 system headers.
11672
15cbd324
EZ
116732011-04-21 Eli Zaretskii <eliz@gnu.org>
11674
11675 Lift the MOST_POSITIVE_FIXNUM/4 limitation on visited files.
11676 * fileio.c (Finsert_file_contents): Don't limit file size to 1/4
11677 of MOST_POSITIVE_FIXNUM. (Bug#8528)
11678
11679 * coding.c (coding_alloc_by_realloc): Error out if destination
11680 will grow beyond MOST_POSITIVE_FIXNUM.
11681 (decode_coding_emacs_mule): Abort if there isn't enough place in
11682 charbuf for the composition carryover bytes. Reserve an extra
11683 space for up to 2 characters produced in a loop.
11684 (decode_coding_iso_2022): Abort if there isn't enough place in
11685 charbuf for the composition carryover bytes.
11686
116872011-04-21 Eli Zaretskii <eliz@gnu.org>
afda1437 11688
ae940cca
EZ
11689 * doprnt.c (doprnt) [!HAVE_LONG_LONG_INT]: Error out instead of
11690 aborting when %lld or %lll format is passed.
11691 [!HAVE_UNSIGNED_LONG_LONG_INT]: Error out instead of aborting when
11692 %llo or %llx format is passed. (Bug#8545)
11693
03ab8921
EZ
11694 * window.c (window_scroll_line_based): Use a marker instead of
11695 simple variables to record original value of point. (Bug#7952)
11696
afda1437
EZ
11697 * doprnt.c (doprnt): Fix the case where a multibyte sequence
11698 produced by %s or %c overflows available buffer space. (Bug#8545)
11699
f76dee0c
PE
117002011-04-28 Paul Eggert <eggert@cs.ucla.edu>
11701
11702 * doprnt.c (doprnt): Omit useless test; int overflow check (Bug#8545).
283cdbef 11703 (SIZE_MAX): Move defn after all includes, as they might #define it.
f76dee0c 11704
fdc5744d
JB
117052011-04-28 Juanma Barranquero <lekktu@gmail.com>
11706
11707 * w32.c (init_environment): Warn about defaulting HOME to C:\.
11708
638f053a
JB
117092011-04-28 Juanma Barranquero <lekktu@gmail.com>
11710
11711 * keyboard.c (Qdelayed_warnings_hook): Define.
11712 (command_loop_1): Run `delayed-warnings-hook'
11713 if Vdelayed_warnings_list is non-nil.
11714 (syms_of_keyboard) <delayed-warnings-hook>: DEFSYM it.
11715 (syms_of_keyboard) <delayed-warnings-list>: DEFVAR_LISP it.
11716
d178f871
EZ
117172011-04-28 Eli Zaretskii <eliz@gnu.org>
11718
11719 * doprnt.c (doprnt): Don't return value smaller than the buffer
11720 size if the message was truncated. (Bug#8545).
11721
b124fd93
JB
117222011-04-28 Juanma Barranquero <lekktu@gmail.com>
11723
11724 * w32fns.c (Fx_change_window_property, Fx_delete_window_property)
11725 (Fx_window_property): #if-0 the whole functions, not just the bodies.
11726
e810457d
PE
117272011-04-27 Paul Eggert <eggert@cs.ucla.edu>
11728
11729 * doprnt.c (doprnt): Support "ll" length modifier, for long long.
11730
ea51cceb
JB
117312011-04-27 Juanma Barranquero <lekktu@gmail.com>
11732
11733 * makefile.w32-in: Update dependencies.
11734
94dcfacf
EZ
117352011-04-27 Eli Zaretskii <eliz@gnu.org>
11736
11737 Improve `doprnt' and its usage. (Bug#8545)
11738 * doprnt.c (doprnt): Make sure `format' is never accessed beyond
11739 `format_end'. Remove support for %l as a conversion specifier.
11740 Don't use xrealloc. Improve diagnostics when the %l size modifier
11741 is used. Update the commentary.
11742
11743 * eval.c (verror): Simplify calculation of size_t.
11744
11745 * coding.c (Ffind_operation_coding_system): Fix diagnostic error
11746 messages.
11747
f61f41d7
PE
117482011-04-27 Yoshiaki Kasahara <kasahara@nc.kyushu-u.ac.jp> (tiny change)
11749
11750 * buffer.c (init_buffer) [USE_MMAP_FOR_BUFFERS]: Adjust to aliasing
11751 change.
11752
96fb4434
PE
117532011-04-27 Paul Eggert <eggert@cs.ucla.edu>
11754
11755 * nsmenu.m: Replace all uses of XVECTOR with ASIZE and AREF.
11756 This makes this file independent of the recent pseudovector change.
11757
671875da 117582011-04-26 Paul Eggert <eggert@cs.ucla.edu>
eab3844f 11759
69e9b5a3
PE
11760 * keyboard.c (handle_user_signal): Fix pointer signedness problem.
11761
b5f869a7 11762 * gnutls.c (emacs_gnutls_handle_error): Remove unused local.
7754e151 11763 (Fgnutls_boot): gnutls_certificate_verify_peers2 wants unsigned *.
8d4c3955 11764 Remove unused local.
c8926152 11765 (emacs_gnutls_write): Don't use uninitialized rtnval if nbyte <= 0.
080e5a8d 11766
841a1577 11767 * lisp.h: Fix a problem with aliasing and vector headers. (Bug#8546)
04f2d78b
CB
11768 GCC 4.6.0 optimizes based on type-based alias analysis.
11769 For example, if b is of type struct buffer * and v of type struct
eab3844f
PE
11770 Lisp_Vector *, then gcc -O2 was incorrectly assuming that &b->size
11771 != &v->size, and therefore "v->size = 1; b->size = 2; return
11772 v->size;" must therefore return 1. This assumption is incorrect
11773 for Emacs, since it type-puns struct Lisp_Vector * with many other
11774 types. To fix this problem, this patch adds a new type struct
f904488f 11775 vectorlike_header that documents the constraints on layout of vectors
eab3844f
PE
11776 and pseudovectors, and helps optimizing compilers not get fooled
11777 by Emacs's type punning. It also adds the macros XSETTYPED_PVECTYPE
11778 XSETTYPED_PSEUDOVECTOR, TYPED_PSEUDOVECTORP, for similar reasons.
f904488f
PE
11779 * lisp.h (XSETTYPED_PVECTYPE): New macro, specifying the name of
11780 the size member.
eab3844f
PE
11781 (XSETPVECTYPE): Rewrite in terms of new macro.
11782 (XSETPVECTYPESIZE): New macro, specifying both type and size.
11783 This is a bit clearer, and further avoids the possibility of
11784 undesirable aliasing.
11785 (XSETTYPED_PSEUDOVECTOR): New macro, specifying the size.
f904488f 11786 (XSETPSEUDOVECTOR): Rewrite in terms of XSETTYPED_PSEUDOVECTOR.
eab3844f
PE
11787 (XSETSUBR): Rewrite in terms of XSETTYPED_PSEUDOVECTOR and XSIZE,
11788 since Lisp_Subr is a special case (no "next" field).
04f2d78b
CB
11789 (ASIZE): Now uses header.size rather than size.
11790 All previous uses of XVECTOR (foo)->size replaced to use this macro,
f904488f
PE
11791 to avoid the hassle of writing XVECTOR (foo)->header.size.
11792 (struct vectorlike_header): New type.
eab3844f
PE
11793 (TYPED_PSEUDOVECTORP): New macro, also specifying the C type of the
11794 object, to help avoid aliasing.
11795 (PSEUDOVECTORP): Rewrite in terms of TYPED_PSEUDOVECTORP.
11796 (SUBRP): Likewise, since Lisp_Subr is a special case.
11797 * lisp.h (struct Lisp_Vector, struct Lisp_Char_Table):
11798 (struct Lisp_Sub_Char_Table, struct Lisp_Bool_Vector):
11799 (struct Lisp_Hash_Table): Combine first two members into a single
f904488f 11800 struct vectorlike_header member. All uses of "size" and "next" members
eab3844f
PE
11801 changed to be "header.size" and "header.next".
11802 * buffer.h (struct buffer): Likewise.
11803 * font.h (struct font_spec, struct font_entity, struct font): Likewise.
11804 * frame.h (struct frame): Likewise.
11805 * process.h (struct Lisp_Process): Likewise.
11806 * termhooks.h (struct terminal): Likewise.
11807 * window.c (struct save_window_data, struct saved_window): Likewise.
11808 * window.h (struct window): Likewise.
11809 * alloc.c (allocate_buffer, Fmake_bool_vector, allocate_pseudovector):
11810 Use XSETPVECTYPESIZE, not XSETPVECTYPE, to avoid aliasing problems.
11811 * buffer.c (init_buffer_once): Likewise.
11812 * lread.c (defsubr): Use XSETTYPED_PVECTYPE, since Lisp_Subr is a
11813 special case.
11814 * process.c (Fformat_network_address): Use local var for size,
11815 for brevity.
11816
0df1eac5
PE
11817 * bytecode.c (exec_byte_code): Don't use XVECTOR before CHECK_VECTOR.
11818
847ab9d1 11819 Make the Lisp reader and string-to-float more consistent (Bug#8525)
452f4150
PE
11820 * data.c (atof): Remove decl; no longer used or needed.
11821 (digit_to_number): Move to lread.c.
11822 (Fstring_to_number): Use new string_to_number function, to be
11823 consistent with how the Lisp reader treats infinities and NaNs.
11824 Do not assume that floating-point numbers represent EMACS_INT
11825 without losing information; this is not true on most 64-bit hosts.
11826 Avoid double-rounding errors, by insisting on integers when
11827 parsing non-base-10 numbers, as the documentation specifies.
11828 * lisp.h (string_to_number): New decl, replacing ...
11829 (isfloat_string): Remove.
bc0a5c13 11830 * lread.c: Include <inttypes.h>, for uintmax_t and strtoumax.
d78050d6 11831 (read1): Do not accept +. and -. as integers; this
452f4150
PE
11832 appears to have been a coding error. Similarly, do not accept
11833 strings like +-1e0 as floating point numbers. Do not report
11834 overflow for integer overflows unless the base is not 10 which
11835 means we have no simple and reliable way to continue.
11836 Break out the floating-point parsing into a new
11837 function string_to_number, so that Fstring_to_number parses
11838 floating point numbers consistently with the Lisp reader.
04f2d78b 11839 (digit_to_number): Move here from data.c. Make it static inline.
452f4150
PE
11840 (E_CHAR, EXP_INT): Remove, replacing with ...
11841 (E_EXP): New macro, to solve the "1.0e+" problem mentioned below.
11842 (string_to_number): New function, replacing isfloat_string.
11843 This function checks for valid syntax and produces the resulting
11844 Lisp float number too. Rework it so that string-to-number
bc0a5c13 11845 no longer mishandles examples like "1.0e+". Use strtoumax,
d78050d6
PE
11846 so that overflow for non-base-10 numbers is reported only when
11847 there's no portable and simple way to convert to floating point.
452f4150 11848
67769ffc
PE
11849 * textprop.c (set_text_properties_1): Rewrite for clarity,
11850 and to avoid GCC warning about integer overflow.
11851
c20db43f
PE
11852 * intervals.h (struct interval): Use EMACS_INT for members
11853 where EMACS_UINT might cause problems. See
11854 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00514.html>.
11855 (CHECK_TOTAL_LENGTH): Remove cast to EMACS_INT; no longer needed.
11856 * intervals.c (interval_deletion_adjustment): Now returns EMACS_INT.
11857 All uses changed.
37aa2f85
PE
11858 (offset_intervals): Tell GCC not to worry about length overflow
11859 when negating a negative length.
c20db43f 11860
2538aa2f
PE
11861 * alloc.c (overrun_check_malloc, overrun_check_realloc): Now static.
11862 (overrun_check_free): Likewise.
11863
f2d3008d
PE
11864 * alloc.c (SDATA_SIZE) [!GC_CHECK_STRING_BYTES]: Avoid runtime check
11865 in the common case where SDATA_DATA_OFFSET is a multiple of Emacs
11866 word size.
11867
ec8df744
PE
11868 * gnutls.c: Fix problems found by GCC 4.6.0 on Ubuntu 10.10.
11869 (gnutls_make_error): Rename local to avoid shadowing.
11870 (gnutls_emacs_global_deinit): ifdef out; not used.
11871 (Fgnutls_boot): Use const for pointer to readonly storage.
11872 Comment out unused local. Fix pointer signedness problems.
11873
640ee02d
PE
11874 * lread.c (openp): Don't stuff size_t into an 'int'.
11875 Use <= on length, not < on length + 1, to avoid GCC 4.6.0 warning
11876 about possible signed overflow.
11877
6048fb2a
PE
11878 * gtkutil.c: Fix problems found by GCC 4.6.0 on Ubuntu 10.10.
11879 (GDK_KEY_g): Don't define if already defined.
11880 (xg_prepare_tooltip): Avoid pointer signedness problem.
11881 (xg_set_toolkit_scroll_bar_thumb): Redo to avoid two casts.
11882
fa3c87e1
PE
11883 * process.c (Fnetwork_interface_info): Avoid left-shift undefined
11884 behavior with 1 << 31. GCC 4.6.0 warns about this on 32-bit hosts.
11885
2172544b
PE
11886 * xfns.c (Fx_window_property): Simplify a bit,
11887 to make a bit faster and to avoid GCC 4.6.0 warning.
11888 * xselect.c (x_get_window_property, x_handle_dnd_message): Likewise.
11889
9b821a21
PE
11890 * fns.c (internal_equal): Don't assume size_t fits in int.
11891
3c616cfa
PE
11892 * alloc.c (compact_small_strings): Tighten assertion a little.
11893
c2982e87
PE
11894 Replace pEd with more-general pI, and fix some printf arg casts.
11895 * lisp.h (pI): New macro, generalizing old pEd macro to other
11896 conversion specifiers. For example, use "...%"pI"d..." rather
11897 than "...%"pEd"...".
11898 (pEd): Remove. All uses replaced with similar uses of pI.
61bdb816 11899 * m/amdx86-64.h, m/ia64.h, m/ibms390x.h: Likewise.
c2982e87
PE
11900 * alloc.c (check_pure_size): Don't overflow by converting size to int.
11901 * bidi.c (bidi_dump_cached_states): Use pI to avoid cast.
11902 * data.c (Fnumber_to_string): Use pI instead of if-then-else-abort.
11903 * dbusbind.c (xd_append_arg): Use pI to avoid cast.
11904 (Fdbus_method_return_internal, Fdbus_method_error_internal): Likewise.
11905 * font.c (font_unparse_xlfd): Avoid potential buffer overrun on
11906 64-bit hosts.
11907 (font_unparse_xlfd, font_unparse_fcname): Use pI to avoid casts.
11908 * keyboard.c (record_char, modify_event_symbol): Use pI to avoid casts.
11909 * print.c (safe_debug_print, print_object): Likewise.
11910 (print_object): Don't overflow by converting EMACS_INT or EMACS_UINT
11911 to int.
6f04d126
PE
11912 Use pI instead of if-then-else-abort. Use %p to avoid casts,
11913 avoiding the 0 flag, which is not portable.
c2982e87
PE
11914 * process.c (Fmake_network_process): Use pI to avoid cast.
11915 * region-cache.c (pp_cache): Likewise.
11916 * xdisp.c (decode_mode_spec): Likewise.
11917 * xrdb.c (x_load_resources) [USE_MOTIF]: Use pI to avoid undefined
11918 behavior on 64-bit hosts with printf arg.
6f04d126 11919 * xselect.c (x_queue_event): Use %p to avoid casts, avoiding 0 flag.
c2982e87
PE
11920 (x_stop_queuing_selection_requests): Likewise.
11921 (x_get_window_property): Don't truncate byte count to an 'int'
11922 when tracing.
0b432f21 11923
5e073ec7
PE
11924 * frame.c (frame_name_fnn_p): Get rid of strtol, which isn't right
11925 here, since it parses constructs like leading '-' and spaces,
11926 which are not wanted; and it overflows with large numbers.
11927 Instead, simply match F[0-9]+, which is what is wanted anyway.
11928
36372bf9
PE
11929 * alloc.c: Remove unportable assumptions about struct layout.
11930 (SDATA_SELECTOR, SDATA_DATA_OFFSET): New macros.
11931 (SDATA_OF_STRING, SDATA_SIZE, allocate_string_data):
11932 (allocate_vectorlike, make_pure_vector): Use the new macros,
11933 plus offsetof, to remove unportable assumptions about struct layout.
11934 These assumptions hold on all porting targets that I know of, but
11935 they are not guaranteed, they're easy to remove, and removing them
11936 makes further changes easier.
11937
0b432f21
PE
11938 * alloc.c (BLOCK BYTES): Fix typo by changing "ablock" to "ablocks".
11939 This doesn't fix a bug but makes the code clearer.
bfd1c781
PE
11940 (string_overrun_cookie): Now const. Use initializers that
11941 don't formally overflow signed char, to avoid warnings.
000098c1
PE
11942 (allocate_string_data) [GC_CHECK_STRING_OVERRUN]: Fix typo that
11943 can cause Emacs to crash when string overrun checking is enabled.
c7bda33c
PE
11944 (allocate_buffer): Don't assume sizeof (struct buffer) is a
11945 multiple of sizeof (EMACS_INT); it need not be, if
11946 alignof(EMACS_INT) < sizeof (EMACS_INT).
d0f4e1f5 11947 (check_sblock, check_string_bytes, check_string_free_list): Protoize.
0b432f21 11948
895009e1
JB
119492011-04-26 Juanma Barranquero <lekktu@gmail.com>
11950
11951 * keyboard.c (QCrtl): Rename from Qrtl. All uses changed.
11952
6a7a1b0b
TZ
119532011-04-26 Teodor Zlatanov <tzz@lifelogs.com>
11954
11955 * gnutls.c (emacs_gnutls_handshake): Return an error if we're not
b5f869a7 11956 supposed to be handshaking. (Bug#8556)
6a7a1b0b
TZ
11957 Reported by Paul Eggert <eggert@cs.ucla.edu>.
11958
841a1577 119592011-04-26 Daniel Colascione <dan.colascione@gmail.com>
0438ce91
DC
11960
11961 * lisp.h (Qdebug): List symbol.
895009e1 11962 * eval.c (Qdebug): Restore global linkage.
0438ce91
DC
11963 * keyboard.c (debug-on-event): New variable.
11964 (handle_user_signal): Break into debugger when debug-on-event
11965 matches the current signal symbol.
11966
f2d3ba6f
DN
119672011-04-25 Dan Nicolaescu <dann@ics.uci.edu>
11968
11969 * alloc.c (check_sblock, check_string_bytes)
11970 (check_string_free_list): Convert to standard C.
11971
42ce4c63
TZ
119722011-04-25 Teodor Zlatanov <tzz@lifelogs.com>
11973
11974 * w32.c (emacs_gnutls_push): Fix typo.
11975
825cd63c
EZ
119762011-04-25 Eli Zaretskii <eliz@gnu.org>
11977
fb11d64d
EZ
11978 * gnutls.c (emacs_gnutls_handshake): Avoid compiler warnings about
11979 "cast to pointer from integer of different size".
11980
825cd63c
EZ
11981 Improve doprnt and its use in verror. (Bug#8545)
11982 * doprnt.c (doprnt): Document the set of format control sequences
11983 supported by the function. Use SAFE_ALLOCA instead of always
11984 using `alloca'.
11985
11986 * eval.c (verror): Don't limit the buffer size at size_max-1, that
11987 is one byte too soon. Don't use xrealloc; instead xfree and
11988 xmalloc anew.
11989
e061a11b
TZ
119902011-04-24 Teodor Zlatanov <tzz@lifelogs.com>
11991
11992 * gnutls.h: Add GNUTLS_STAGE_CALLBACKS enum to denote we're in the
11993 callbacks stage.
11994
11995 * gnutls.c: Renamed global_initialized to
11996 gnutls_global_initialized. Added internals for the
11997 :verify-hostname-error, :verify-error, and :verify-flags
11998 parameters of `gnutls-boot' and documented those parameters in the
11999 docstring. Start callback support.
9173deec
JB
12000 (emacs_gnutls_handshake): Add Woe32 support. Retry handshake
12001 unless a fatal error occurred. Call gnutls_alert_send_appropriate
12002 on error. Return error code.
e061a11b
TZ
12003 (emacs_gnutls_write): Call emacs_gnutls_handle_error.
12004 (emacs_gnutls_read): Likewise.
12005 (Fgnutls_boot): Return handshake error code.
12006 (emacs_gnutls_handle_error): New function.
12007 (wsaerror_to_errno): Likewise.
12008
12009 * w32.h (emacs_gnutls_pull): Add prototype.
12010 (emacs_gnutls_push): Likewise.
12011
12012 * w32.c (emacs_gnutls_pull): New function for GnuTLS on Woe32.
12013 (emacs_gnutls_push): Likewise.
12014
120152011-04-24 Claudio Bley <claudio.bley@gmail.com> (tiny change)
12016
12017 * process.c (wait_reading_process_output): Check if GnuTLS
12018 buffered some data internally if no FDs are set for TLS
12019 connections.
12020
12021 * makefile.w32-in (OBJ2): Add gnutls.$(O).
12022 (LIBS): Link to USER_LIBS.
12023 ($(BLD)/gnutls.$(0)): New target.
12024
fa6996bc
EZ
120252011-04-24 Eli Zaretskii <eliz@gnu.org>
12026
eb35682e
EZ
12027 * xdisp.c (handle_single_display_spec): Rename the
12028 display_replaced_before_p argument into display_replaced_p, to
12029 make it consistent with the commentary. Fix typos in the
12030 commentary.
12031
e2ad650c
EZ
12032 * textprop.c (syms_of_textprop): Remove dead code.
12033 (copy_text_properties): Delete obsolete commentary about an
12034 interface that was deleted long ago. Fix typos in the description
12035 of arguments.
12036
1b2de274
EZ
12037 * msdos.c (XMenuActivate, XMenuAddSelection): Adjust argument list
12038 to changes in oldXMenu/XMenu.h from 2011-04-16.
12039 <menu_help_message, prev_menu_help_message>: Constify.
12040 (IT_menu_make_room): menu->help_text is now `const char **';
12041 adjust.
12042
12043 * msdos.h (XMenuActivate, XMenuAddSelection): Adjust prototypes
12044 to changes in oldXMenu/XMenu.h from 2011-04-16.
12045 (struct XMenu): Declare `help_text' `const char **'.
12046
12047 * xfaces.c <Qunspecified>: Make extern again.
12048
12049 * syntax.c: Include sys/types.h before including regex.h, as
75f1671a 12050 required by POSIX.
1b2de274 12051
762b15be
EZ
12052 * doc.c (get_doc_string): Improve the format passed to `error'.
12053
12054 * doprnt.c (doprnt): Improve commentary.
12055
12056 * term.c (init_tty) [MSDOS]: Fix 1st argument to maybe_fatal.
12057
12058 * Makefile.in (TAGS): Depend on $(M_FILE) and $(S_FILE), and scan
12059 them with etags.
12060
f1052e5d
EZ
12061 * makefile.w32-in (globals.h): Add a dummy recipe, to make any
12062 changes in globals.h immediately force recompilation.
762b15be
EZ
12063 (TAGS): Depend on $(CURDIR)/m/intel386.h and
12064 $(CURDIR)/s/ms-w32.h.
12065 (TAGS-gmake): Scan $(CURDIR)/m/intel386.h and $(CURDIR)/s/ms-w32.h.
f1052e5d 12066
fa6996bc
EZ
12067 * character.c (Fchar_direction): Function deleted.
12068 (syms_of_character): Don't defsubr it.
12069 <char-direction-table>: Deleted.
12070
e6c3da20
EZ
120712011-04-23 Eli Zaretskii <eliz@gnu.org>
12072
12073 Fix doprnt so it could be used again safely in `verror'. (Bug#8435)
12074 * doprnt.c: Include limits.h.
12075 (SIZE_MAX): New macro.
04f2d78b
CB
12076 (doprnt): Return a size_t value. 2nd arg is now size_t.
12077 Many local variables are now size_t instead of int or unsigned.
e6c3da20
EZ
12078 Improve overflow protection. Support `l' modifier for integer
12079 conversions. Support %l conversion. Don't assume an EMACS_INT
12080 argument for integer conversions and for %c.
12081
12082 * lisp.h (doprnt): Restore prototype.
12083
12084 * makefile.w32-in ($(BLD)/callint.$(O)): Depend on
12085 $(SRC)/character.h.
12086
12087 * Makefile.in (base_obj): Add back doprnt.o.
12088
12089 * deps.mk (doprnt.o): Add back prerequisites.
12090 (callint.o): Depend on character.h.
12091
12092 * eval.c (internal_lisp_condition_case): Include the handler
12093 representation in the error message.
12094 (verror): Call doprnt instead of vsnprintf. Fix an off-by-one bug
12095 when breaking from the loop.
12096
12097 * xdisp.c (vmessage): Call doprnt instead of vsnprintf.
12098
12099 * callint.c (Fcall_interactively): When displaying error message
12100 about invalid control letter, pass the character's codepoint, not
12101 a pointer to its multibyte form. Improve display of the character
12102 in octal and display also its hex code.
12103
12104 * character.c (char_string): Use %x to display the (unsigned)
12105 codepoint of an invalid character, to avoid displaying a bogus
12106 negative value.
12107
12108 * font.c (check_otf_features): Pass SDATA of SYMBOL_NAME to
12109 `error', not SYMBOL_NAME itself.
12110
12111 * coding.c (Fencode_sjis_char, Fencode_big5_char): Use %c for
12112 character arguments to `error'.
12113
12114 * charset.c (check_iso_charset_parameter): Fix incorrect argument
12115 to `error' in error message about FINAL_CHAR argument. Make sure
12116 FINAL_CHAR is a character, and use %c when it is passed as
12117 argument to `error'.
12118
4ffd0d6b 121192011-04-23 Eli Zaretskii <eliz@gnu.org>
97a93095
EZ
12120
12121 * s/ms-w32.h (localtime): Redirect to sys_localtime.
12122
12123 * w32.c: Include <time.h>.
12124 (sys_localtime): New function.
12125
4ffd0d6b 121262011-04-23 Chong Yidong <cyd@stupidchicken.com>
c17819f4
CY
12127
12128 * xdisp.c (init_xdisp): Initialize echo_area_window (Bug#6451).
12129
4ffd0d6b 12130 * buffer.c (syms_of_buffer): Doc fix (Bug#6902).
aac0c6e3 12131
4ffd0d6b 121322011-04-23 Samuel Thibault <sthibault@debian.org> (tiny change)
aac0c6e3 12133
4ffd0d6b
GM
12134 * sysdep.c (wait_for_termination): On GNU Hurd, kill returns -1 on
12135 zombies (Bug#8467).
aac0c6e3 12136
04c56954
EZ
121372011-04-19 Eli Zaretskii <eliz@gnu.org>
12138
12139 * syntax.h (SETUP_SYNTAX_TABLE_FOR_OBJECT): Fix setting of
12140 gl_state.e_property when gl_state.object is Qt.
12141
12142 * insdel.c (make_gap_larger): Remove limitation of buffer size
12143 to <= INT_MAX.
12144
16a43933
CY
121452011-04-18 Chong Yidong <cyd@stupidchicken.com>
12146
12147 * xdisp.c (lookup_glyphless_char_display)
12148 (produce_glyphless_glyph): Handle cons cell entry in
12149 glyphless-char-display.
12150 (Vglyphless_char_display): Document it.
12151
12152 * term.c (produce_glyphless_glyph): Handle cons cell entry in
12153 glyphless-char-display.
12154
4581706e
CY
121552011-04-17 Chong Yidong <cyd@stupidchicken.com>
12156
12157 * xdisp.c (get_next_display_element): Remove unnecessary ifdefs.
12158
12159 * termhooks.h (FRAME_WINDOW_P): Remove duplicated definitions.
12160
12161 * dispextern.h (FACE_SUITABLE_FOR_ASCII_CHAR_P): Add missing
12162 definition for no-X builds.
12163
4887c6e2 121642011-04-16 Paul Eggert <eggert@cs.ucla.edu>
764430a3 12165
fd35b6f9
PE
12166 Static checks with GCC 4.6.0 and non-default toolkits.
12167
5c1ccb01
PE
12168 * s/sol2-6.h, s/unixware.h (PTY_TTY_NAME_SPRINTF): Protoize decl.
12169
006c5daa
PE
12170 * process.c (keyboard_bit_set): Define only if SIGIO.
12171 (send_process_trap): Mark it with NO_RETURN if it doesn't return.
12172 (send_process): Repair possible setjmp clobbering.
12173
efc736d3
PE
12174 * s/usg5-4-common.h (SETUP_SLAVE_PTY): Don't pass extra arg to 'fatal'.
12175
4e2fe2e6
PE
12176 * eval.c: Include <stdio.h>, for vsnprintf on non-GNU/Linux hosts.
12177
f97334a2
PE
12178 * data.c (arith_error): Mark with NO_RETURN if it doesn't return.
12179
4e75f29d
PE
12180 * alloc.c (bytes_used_when_full, SPARE_MEMORY, BYTES_USED):
12181 Define only if needed.
12182
90efadd1
PE
12183 * sysdep.c (_FILE_OFFSET_BITS): Make this hack even uglier
12184 by pacifying GCC about it. Maybe it's time to retire it?
875975e9 12185 * xfaces.c (USG, __TIMEVAL__): Likewise.
90efadd1 12186
3c647824
PE
12187 * dispextern.h (struct redisplay_interface): Rename param
12188 to avoid shadowing.
e264f262 12189 * termhooks.h (struct terminal): Likewise.
761383f4 12190 * xterm.c (xembed_send_message): Likewise.
3c647824 12191
b58c5c4a
PE
12192 * insdel.c (make_gap_smaller): Define only if
12193 USE_MMAP_FOR_BUFFERS || REL_ALLOC || DOUG_LEA_MALLOC.
12194
cad59032
PE
12195 * keyboard.c (read_char): Make a var volatile so longjmp won't clobber
12196 it.
12197
c339dc2e
PE
12198 * emacs.c (MAX_HEAP_BSS_DIFF, my_edata): Move to where they're used,
12199 so that we aren't warned about unused symbols.
12200
91a3e27b
PE
12201 * xfns.c (Fx_file_dialog): Rename local to avoid shadowing.
12202
399c71d3 12203 * xdisp.c (x_produce_glyphs): Mark var as initialized (Bug#8512).
7a3fb125 12204
8ffc96f5
PE
12205 * xfns.c (x_real_positions): Mark locals as initialized.
12206
eef9bc79
PE
12207 * xmenu.c (xmenu_show): Don't use uninitialized vars.
12208
098db9dd
PE
12209 * xterm.c: Fix problems found by static analysis with other toolkits.
12210 (toolkit_scroll_bar_interaction): Define and use only if USE_X_TOOLKIT.
dda3aedd
PE
12211 (x_dispatch_event): Declare static if USE_GTK, and
12212 define if USE_GTK || USE_X_TOOLKIT.
098db9dd 12213 (SET_SAVED_BUTTON_EVENT): Define only if USE_X_TOOLKIT || USE_GTK.
dda3aedd 12214 * xterm.h (x_dispatch_event): Extern only if USE_X_TOOLKIT.
841a1577
JB
12215 * xterm.c, xterm.h (x_mouse_leave): Bring this function back, but only
12216 if defined HAVE_MENUS && !defined USE_X_TOOLKIT && !defined USE_GTK.
098db9dd 12217
eb18f6cc
PE
12218 * xmenu.c (menu_help_callback): Pointer type fixes.
12219 Use const pointers when pointing at readonly data. Avoid pointer
12220 signedness clashes.
12221 (FALSE): Remove unused macro.
12222 (update_frame_menubar): Remove unused decl.
12223
1fe72bf8
PE
12224 * xfns.c (Fx_hide_tip): Move locals to avoid shadowing.
12225
60d9e1db
PE
12226 * menu.c (push_submenu_start, push_submenu_end): Do not define unless
12227 USE_X_TOOLKIT || USE_GTK || HAVE_NS || defined HAVE_NTGUI.
12228 (single_menu_item): Rename local to avoid shadowing.
12229
39261c26
PE
12230 * keyboard.c (make_lispy_event): Remove unused local var.
12231
018c5e19
PE
12232 * frame.c, frame.h (x_get_resource_string): Bring this back, but
12233 only if HAVE_X_WINDOWS && !USE_X_TOOLKIT.
12234
63d2b86e
PE
12235 * bitmaps: Change bitmaps from unsigned char back to the X11
12236 compatible char. Avoid the old compiler warnings about
12237 out-of-range initializers by using, for example, '\xab' rather
12238 than 0xab.
12239
aefd87e1
PE
12240 * xgselect.c (xgselect_initialize): Check vs interface
12241 even if ! (defined (USE_GTK) || defined (HAVE_GCONF)).
12242
bf501fb9
PE
12243 * xmenu.c (xmenu_show): Rename parm to avoid shadowing.
12244
e9829fdf
PE
12245 * xterm.c (x_create_toolkit_scroll_bar): Use const * for pointers
12246 to read-only memory.
12247
1086c095
PE
12248 * fns.c (vector): Remove; this old hack is no longer needed.
12249
2baccd04 12250 * xsmfns.c (create_client_leader_window): Rename shadowing arg.
401f10cb 12251 Remove unused var.
dde42981 12252 (gdk_x11_set_sm_client_id) [!USE_GTK]: Don't define.
2baccd04 12253
72391843 12254 * xrdb.c (x_load_resources): Omit unused local.
3565b346 12255
436c16df 12256 * xfns.c (free_frame_menubar, atof): Remove duplicate decls.
8a94ea33 12257 (x_window): Rename locals to avoid shadowing.
dc5ddd85 12258 (USG): Use the kludged USG macro, to pacify gcc.
436c16df 12259
92bb796d 12260 * xterm.c (x_alloc_nearest_color_for_widget): Remove; unused.
bbbef9e1 12261 (x_term_init): Remove local to avoid shadowing.
92bb796d 12262
764430a3 12263 * xfns.c, xterm.c (_XEditResCheckMessages): Protoize decl.
4887c6e2
PE
12264
12265 * xdisp.c, dispextern.h (set_vertical_scroll_bar): Now extern if
12266 USE_TOOLKIT_SCROLL_BARS && !USE_GTK, as xterm.c needs it then.
12267
d1dfb56c
EZ
122682011-04-16 Eli Zaretskii <eliz@gnu.org>
12269
c4354cb4
EZ
12270 * gnutls.c (Fgnutls_boot): Don't pass Lisp_Object to `error'.
12271
d1dfb56c
EZ
12272 Fix regex.c, syntax.c and friends for buffers > 2GB.
12273 * syntax.h (struct gl_state_s): Declare character position members
12274 EMACS_INT.
12275
12276 * syntax.c (update_syntax_table): Declare 2nd argument EMACS_INT.
12277
04f2d78b
CB
12278 * textprop.c (verify_interval_modification, interval_of):
12279 Declare arguments EMACS_INT.
d1dfb56c
EZ
12280
12281 * intervals.c (adjust_intervals_for_insertion): Declare arguments
12282 EMACS_INT.
12283
12284 * intervals.h (CHECK_TOTAL_LENGTH): Cast to EMACS_INT, not `int'.
12285
12286 * indent.c (Fvertical_motion): Local variable it_start is now
12287 EMACS_INT.
12288
12289 * regex.c (re_match, re_match_2, re_match_2_internal)
12290 (bcmp_translate, regcomp, regexec, print_double_string)
12291 (group_in_compile_stack, re_search, re_search_2, regex_compile)
12292 (re_compile_pattern, re_exec): Declare arguments and local
12293 variables `size_t' and `ssize_t' and return values `regoff_t', as
12294 appropriate.
12295 (POP_FAILURE_REG_OR_COUNT) <pfreg>: Declare `long'.
12296 (CHECK_INFINITE_LOOP) <failure>: Declare `ssize_t'.
12297 <compile_stack_type>: `size' and `avail' are now `size_t'.
12298
12299 * regex.h <regoff_t>: Use ssize_t, not int.
12300 (re_search, re_search_2, re_match, re_match_2): Arguments that
12301 specify buffer/string position and length are now ssize_t and
12302 size_t. Return type is regoff_t.
12303
613052cd
BK
123042011-04-16 Ben Key <bkey76@gmail.com>
12305
12306 * nsfont.m: Fixed bugs in ns_get_family and
12307 ns_descriptor_to_entity that were caused by using free to
12308 deallocate memory blocks that were allocated by xmalloc (via
12309 xstrdup). This caused Emacs to crash when compiled with
12310 XMALLOC_OVERRUN_CHECK defined (when Emacs was configured with
12311 --enable-checking=xmallocoverrun). xfree is now used to
12312 deallocate these memory blocks.
12313
4170f62f 123142011-04-15 Paul Eggert <eggert@cs.ucla.edu>
3e047f51 12315
71b41406
PE
12316 * sysdep.c (emacs_read): Remove unnecessary check vs MAX_RW_COUNT.
12317
9587a89d
PE
12318 emacs_write: Accept and return EMACS_INT for sizes.
12319 See http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00514.html
12320 et seq.
12321 * gnutls.c, gnutls.h (emacs_gnutls_read, emacs_gnutls_write):
12322 Accept and return EMACS_INT.
12323 (emacs_gnutls_write): Return the number of bytes written on
12324 partial writes.
12325 * sysdep.c, lisp.h (emacs_read, emacs_write): Likewise.
273a5f82
PE
12326 (emacs_read, emacs_write): Remove check for negative size, as the
12327 Emacs source code has been audited now.
9587a89d
PE
12328 * sysdep.c (MAX_RW_COUNT): New macro, to work around kernel bugs.
12329 (emacs_read, emacs_write): Use it.
273a5f82
PE
12330 * process.c (send_process): Adjust to the new signatures of
12331 emacs_write and emacs_gnutls_write. Do not attempt to store
12332 a byte offset into an 'int'; it might overflow.
9587a89d 12333 See http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00483.html
273a5f82 12334
3e047f51
PE
12335 * sound.c: Don't assume sizes fit in 'int'.
12336 (struct sound_device.period_size, alsa_period_size):
9c3c56a7 12337 Return EMACS_INT, not int.
3e047f51 12338 (struct sound_device.write, vox_write, alsa_write):
9c3c56a7
PE
12339 Accept EMACS_INT, not int.
12340 (wav_play, au_play): Use EMACS_INT to store sizes and to
3e047f51
PE
12341 record read return values.
12342
cc39a9db
BK
123432011-04-15 Ben Key <bkey76@gmail.com>
12344
c9d0ec6d
JB
12345 * keyboard.c (Qundefined): Don't declare static since it is used
12346 in nsfns.m.
12347 * xfaces.c (Qbold, Qexpanded, Qitalic, Qcondensed): Don't declare
12348 static since they are used in nsfont.m.
cc39a9db 12349
6c60eb9f
SM
123502011-04-15 Stefan Monnier <monnier@iro.umontreal.ca>
12351
12352 * process.c (Qprocessp): Don't declare static.
12353 * lisp.h (Qprocessp): Declare again.
12354
7990b61a
JB
123552011-04-15 Juanma Barranquero <lekktu@gmail.com>
12356
12357 * font.c (Qopentype): Don't make static (used from w32uniscribe.c).
12358
5d4cb038
PE
123592011-04-14 Paul Eggert <eggert@cs.ucla.edu>
12360
8bd7b830 12361 Improve C-level modularity by making more things 'static'.
cd64ea1d 12362
e3b27b31
PE
12363 Don't publish debugger-only interfaces to other modules.
12364 * lisp.h (safe_debug_print, debug_output_compilation_hack):
12365 (verify_bytepos, count_markers): Move decls to the only modules
12366 that need them.
12367 * region-cache.h (pp_cache): Likewise.
12368 * window.h (check_all_windows): Likewise.
12369 * marker.c, print.c, region-cache.c, window.c: Decls moved here.
12370
5d4cb038
PE
12371 * sysdep.c (croak): Now static, if
12372 defined TIOCNOTTY || defined USG5 || defined CYGWIN.
12373 * syssignal.h (croak): Declare only if not static.
69003fd8
PE
12374
12375 * alloc.c (refill_memory_reserve): Now static if
12376 !defined REL_ALLOC || defined SYSTEM_MALLOC.
12377 * lisp.h (refill_memory_reserve): Declare only if not static.
93ea6e8f 12378
e87b6180
PE
12379 * xsettings.c, xsettings.h (xsettings_get_system_normal_font):
12380 Define only if USE_LUCID.
12381
ac64929e
PE
12382 * xrdb.c (x_customization_string, x_rm_string): Now static.
12383
6f37259d
PE
12384 * xmenu.c (x_menu_wait_for_event): Export only if USE_MOTIF.
12385 * xterm.h (x_menu_wait_for_event): Declare only if USE_MOTIF.
12386
1683e3ab
PE
12387 * xdisp.c (draw_row_with_mouse_face): Now static.
12388 * dispextern.h (draw_row_with_mouse_fave): Remove decl.
12389
de9c2632
PE
12390 * window.h (check_all_windows): Mark externally visible.
12391
2b96acb7
PE
12392 * window.c (window_deletion_count): Now static.
12393
12394 * undo.c: Make symbols static if they're not exported.
12395 (last_undo_buffer, last_boundary_position, pending_boundary):
12396 Now static.
12397
50436f33
PE
12398 * textprop.c (interval_insert_behind_hooks): Now static.
12399 (interval_insert_in_front_hooks): Likewise.
12400
64520e5c
PE
12401 * term.c: Make symbols static if they're not exported.
12402 (tty_turn_off_highlight, get_tty_terminal, max_frame_cols):
12403 (max_frame_lines, tty_set_terminal_modes):
12404 (tty_reset_terminal_modes, tty_turn_off_highlight):
12405 (get_tty_terminal): Now static.
12406 (term_mouse_moveto): Do not define if HAVE_WINDOW_SYSTEM.
12407 * termhooks.h (term_mouse_moveto): Do not declare if
8bd7b830 12408 HAVE_WINDOW_SYSTEM.
64520e5c
PE
12409 * dispextern.h (tty_set_terminal_modes, tty_reset_terminal_modes):
12410 (tty_turn_off_highlight, get_tty_terminal): Remove decls.
12411
1fa53021
PE
12412 * sysdep.c: Make symbols static if they're not exported.
12413 (emacs_get_tty, emacs_set_tty, old_fcntl_flags, old_fcntl_owner):
12414 Now static.
12415 (sigprocmask_set, full_mask): Remove; unused.
12416 (wait_debugging): Mark as visible.
12417 * syssignal.h (SIGFULLMASK, full_mask): Remove decls.
12418 * systty.h (emacs_get_tty, emacs_set_tty): Remove decls.
12419
d4b43b22
PE
12420 * syntax.c (syntax_temp): Define only if !__GNUC__.
12421
b7c513d0
PE
12422 * sound.c (current_sound_device, current_sound): Now static.
12423
989b29ad
PE
12424 * search.c (searchbufs, searchbuf_head): Now static.
12425
13a55a78
PE
12426 * scroll.c (scroll_cost): Remove; unused.
12427 * dispextern.h (scroll_cost): Remove decl.
12428
de68a1fc
PE
12429 * region-cache.h (pp_cache): Mark as externally visible.
12430
40ccffa6
PE
12431 * process.c: Make symbols static if they're not exported.
12432 (process_tick, update_tick, create_process, chan_process):
12433 (Vprocess_alist, proc_buffered_char, datagram_access):
12434 (fd_callback_data, send_process_frame, process_sent_to): Now static.
12435 (deactivate_process): Mark defn as static, as well as decl.
12436 * lisp.h (create_process): Remove decl.
12437 * process.h (chan_process, Vprocess_alist): Remove decls.
12438
ad64fc97
PE
12439 * print.c: Make symbols static if they're not exported.
12440 (print_depth, new_backquote_output, being_printed, print_buffer):
12441 (print_buffer_size, print_buffer_pos, print_buffer_pos_byte):
12442 (print_interval, print_number_index, initial_stderr_stream):
12443 Now static.
12444 * lisp.h (Fprinc): Remove decl.
12445 (debug_output_compilation_hack): Mark as externally visible.
12446
adddb265
PE
12447 * sysdep.c (croak): Move decl from here to syssignal.h.
12448 * syssignal.h (croak): Put it here, so the API can be checked when
12449 'croak' is called from dissociate_if_controlling_tty.
12450
1717ede2
PE
12451 * minibuf.c: Make symbols static if they're not exported.
12452 (minibuf_save_list, choose_minibuf_frame): Now static.
12453 * lisp.h (choose_minibuf_frame): Remove decl.
12454
fa5fb2bc
PE
12455 * lisp.h (verify_bytepos, count_markers): Mark as externally visible.
12456
1e3890d1
PE
12457 * lread.c: Make symbols static if they're not exported.
12458 (read_objects, initial_obarray, oblookup_last_bucket_number):
12459 Now static.
12460 (make_symbol): Remove; unused.
12461 * lisp.h (initial_obarray, make_symbol): Remove decls.
12462
8a1414fa
PE
12463 * keyboard.c: Make symbols static if they're not exported.
12464 (single_kboard, recent_keys_index, total_keys, recent_keys):
12465 (this_command_key_count_reset, raw_keybuf, raw_keybuf_count):
12466 (this_single_command_key_start, echoing, last_auto_save):
12467 (read_key_sequence_cmd, dribble, recursive_edit_unwind):
12468 (command_loop, echo_now, keyboard_init_hook, help_char_p):
12469 (quit_throw_to_read_char, command_loop_2, top_level_1, poll_timer):
12470 (Vlispy_mouse_stem, double_click_count):
12471 Now static.
12472 (force_auto_save_soon): Define only if SIGDANGER.
12473 (ignore_mouse_drag_p): Now static if
12474 !defined HAVE_WINDOW_SYSTEM || defined USE_GTK || defined HAVE_NS.
12475 (print_help): Remove; unused.
12476 (stop_character, last_timer_event): Mark as externally visible.
12477 * keyboard.h (ignore_mouse_drag_p): Declare only if
12478 defined HAVE_WINDOW_SYSTEM && !defined USE_GTK && !defined HAVE_NS.
12479 (echo_now, help_char_p, quit_throw_to_read_char): Remove decls.
12480 * lisp.h (echoing): Remove decl.
12481 (force_auto_save_soon): Declare only if SIGDANGER.
12482 * xdisp.c (redisplay_window): Simplify code, to make it more
12483 obvious that ignore_mouse_drag_p is not accessed if !defined
12484 USE_GTK && !defined HAVE_NS.
12485
93ea6e8f
PE
12486 * intervals.c: Make symbols static if they're not exported.
12487 (merge_properties_sticky, merge_interval_right, delete_interval):
12488 Now static.
12489 * intervals.h (merge_interval_right, delete_interval): Remove decls.
12490
77382fcc
PE
12491 * insdel.c: Make symbols static if they're not exported.
12492 However, leave prepare_to_modify_buffer alone. It's never
12493 called from outside this function, but that appears to be a bug.
12494 (combine_after_change_list, combine_after_change_buffer):
4889fc82 12495 (adjust_after_replace, signal_before_change): Now static.
77382fcc
PE
12496 (adjust_after_replace_noundo): Remove; unused.
12497 * lisp.h (adjust_after_replace, adjust_after_replace_noundo):
4889fc82 12498 (signal_before_change): Remove decls.
77382fcc 12499
9306c32e
PE
12500 * indent.c (val_compute_motion, val_vmotion): Now static.
12501
cd44d2eb
PE
12502 * image.c: Make symbols static if they're not exported.
12503 * dispextern.h (x_create_bitmap_from_xpm_data): Do not declare
12504 if USE_GTK.
12505 * image.c (x_create_bitmap_from_xpm_data): Do not define if USE_GTK.
12506 (xpm_color_cache, ct_table, ct_colors_allocated): Now static.
12507
ad9a7a06
PE
12508 * fringe.c (standard_bitmaps): Now static.
12509 (max_used_fringe_bitmap): Now static, unless HAVE_NS.
12510
81626931
PE
12511 * frame.c: Make symbols static if they're not exported.
12512 (x_report_frame_params, make_terminal_frame): Now static.
12513 (get_frame_param): Now static, unless HAVE_NS.
12514 (x_fullscreen_adjust): Define if WINDOWSNT, not if HAVE_WINDOW_SYSTEM.
12515 (x_get_resource_string): Remove; not used.
12516 * frame.h (make_terminal_frame, x_report_frame_params):
12517 (x_get_resource_string); Remove decls.
12518 (x_fullscreen_adjust): Declare only if WINDOWSNT.
12519 * lisp.h (get_frame_param): Declare only if HAVE_NS.
12520
239f9db9
PE
12521 * font.c, fontset.c: Make symbols static if they're not exported.
12522 * dispextern.h (FACE_SUITABLE_FOR_ASCII_CHAR_P): New macro.
12523 (FACE_SUITABLE_FOR_CHAR_P): Use it.
12524 * font.c (font_close_object): Now static.
12525 * font.h (font_close_object): Remove.
12526 * fontset.c (FONTSET_OBJLIST): Remove.
12527 (free_realized_fontset) #if-0 the body, which does nothing.
12528 (face_suitable_for_char_p): #if-0, as it's never called.
12529 * fontset.h (face_suitable_for_char_p): Remove decl.
04f2d78b
CB
12530 * xfaces.c (face_at_string_position):
12531 Use FACE_SUITABLE_FOR_ASCII_CHAR_P, not FACE_SUITABLE_FOR_CHAR_P,
239f9db9
PE
12532 since 0 is always ASCII.
12533
dfcf3579
PE
12534 * fns.c (weak_hash_tables): Now static.
12535
5045092b
PE
12536 * fileio.c: Make symbols static if they're not exported.
12537 (auto_saving, auto_save_mode_bits, auto_save_error_occurred):
12538 (Vwrite_region_annotation_buffers): Now static.
12539
57a96f5c
PE
12540 * eval.c: Make symbols static if they're not exported.
12541 (backtrace_list, lisp_eval_depth, when_entered_debugger): Now static.
12542 * lisp.h (backtrace_list): Remove decl.
12543
35f08c38
PE
12544 * emacs.c: Make symbols static if they're not exported.
12545 (malloc_state_ptr, malloc_using_checking, syms_of_emacs):
12546 (fatal_error_code, fatal_error_signal_hook, standard_args):
12547 Now static.
12548 (fatal_error_signal): Now static, unless FLOAT_CATCH_SIGKILL.
12549 (DEFINE_DUMMY_FUNCTION): Mark function as externally visible.
12550 (__CTOR_LIST__, __DTOR_LIST__): Now externally visible.
12551 * lisp.h (fatal_error_signal_hook): Remove decl.
12552 (fatal_error_signal): Declare only if FLOAT_CATCH_SIGKILL.
12553
f44bd759
PE
12554 * editfns.c: Move a (normally-unused) function to its only use.
12555 * editfns.c, lisp.h (get_operating_system_release): Remove.
12556 * process.c (init_process) [DARWIN_OS]: Do it inline, as it is not
12557 worth the hassle of breaking this out.
12558
b532497d
PE
12559 * xterm.c: Make symbols static if they're not exported.
12560 (x_raise_frame, x_lower_frame, x_wm_set_window_state):
12561 (x_wm_set_icon_pixmap, x_initialize, XTread_socket_fake_io_error):
12562 (x_destroy_window, x_delete_display):
12563 Now static.
12564 (x_dispatch_event): Now static if ! (USE_MOTIF || USE_X_TOOLKIT).
12565 (x_mouse_leave): Remove; unused.
12566 * xterm.h (x_display_info_for_name, x_raise_frame, x_lower_frame):
12567 (x_destroy_window, x_wm_set_window_state, x_wm_set_icon_pixmap):
12568 (x_delete_display, x_initialize, x_set_border_pixel, x_screen_planes):
12569 Remove decls.
12570 (x_mouse_leave): Declare only if WINDOWSNT.
12571 (x_dispatch_event): Declare only if USE_MOTIF or USE_X_TOOLKIT.
12572 (xic_create_fontsetname): Declare only if HAVE_X_WINDOWS &&
12573 USE_X_TOOLKIT.
12574
1675728f
PE
12575 * ftxfont.c: Make symbols static if they're not exported.
12576 (ftxfont_driver): Export only if !defined HAVE_XFT && def8ined
12577 HAVE_FREETYPE.
12578 * font.h (ftxfont_driver): Likewise.
12579
e4cebfca
PE
12580 * xfns.c: Make symbols static if they're not exported.
12581 (x_last_font_name, x_display_info_for_name):
12582 (x_set_foreground_color, x_set_background_color, x_set_mouse_color):
12583 (x_set_cursor_color, x_set_border_pixel, x_set_border_color):
12584 (x_set_cursor_type, x_set_icon_type, x_set_icon_name):
12585 (x_set_scroll_bar_foreground, x_set_scroll_bar_background):
12586 (x_explicitly_set_name, x_set_title, xic_defaut_fontset, tip_timer):
12587 (last_show_tip_args): Now static.
12588 (xic_defaut_fontset, xic_create_fontsetname): Define only if
12589 defined HAVE_X_WINDOWS && defined USE_X_TOOLKIT
12590 (x_screen_planes): Remove; unused.
12591 * dispextern.h (x_screen_planes): Remove decl.
12592
5bf46f05
PE
12593 * dispnew.c: Make symbols static if they're not exported.
12594 * dispextern.h (redraw_garbaged_frames, scrolling):
12595 (increment_row_positions): Remove.
12596 * dispnew.c (new_glyph_matrix, increment_row_positions, scrolling):
12597 (delayed_size_change, glyph_matrix_count, glyph_pool_count):
12598 Now static.
12599 (redraw_garbaged_frames): Remove; unused.
12600
435f4c28
PE
12601 * xfaces.c: Make symbols static if they're not exported.
12602 * dispextern.h (ascii_face_of_lisp_face, free_realized_face):
12603 Remove decls.
12604 * xterm.h (defined_color): Remove decls.
12605 (x_free_dpy_colors): Declare only if USE_X_TOOLKIT.
12606 * xfaces.c (tty_suppress_bold_inverse_default_colors_p):
12607 (menu_face_changed_default, defined_color, free_realized_face):
12608 (x_free_dpy_colors): Define only if USE_X_TOOLKIT.
12609 (ascii_face_of_lisp_face): Remove; unused.
12610
8524aef3
PE
12611 * xdisp.c: Make symbols static if they're not exported.
12612 * dispextern.h (scratch_glyph_row, window_box_edges):
12613 (glyph_to_pixel_coords, set_cursor_from_row):
12614 (get_next_display_element, set_iterator_to_next):
12615 (highlight_trailing_whitespace, frame_to_window_pixel_xy):
12616 (show_mouse_face): Remove decls
12617 * frame.h (message_buf_print): Likewise.
12618 * lisp.h (pop_message, set_message, check_point_in_composition):
12619 Likewise.
12620 * xterm.h (set_vertical_scroll_bar): Likewise.
12621 * xdisp.c (list_of_error, Vmessage_stack, line_number_displayed):
12622 (message_buf_print, scratch_glyph_row, displayed_buffer):
12623 (set_iterator_to_next, pop_message, set_message, set_cursor_from_row):
12624 (get_next_display_element, show_mouse_face, window_box_edges):
12625 (frame_to_window_pixel_xy, check_point_in_composition):
12626 (set_vertical_scroll_bar, highlight_trailing_whitespace): Now static.
12627 (glyph_to_pixel_coords): Remove; unused.
12628
16390cd2
PE
12629 * dired.c (file_name_completion): Now static.
12630
12631 * dbusbind.c (xd_in_read_queued_messages): Now static.
12632
a25f4dfa
PE
12633 * lisp.h (circular_list_error, FOREACH): Remove; unused.
12634 * data.c (circular_list_error): Remove.
12635
14a9c8df
PE
12636 * commands.h (last_point_position, last_point_position_buffer):
12637 (last_point_position_window): Remove decls.
12638 * keyboard.c: Make these variables static.
12639
04f2d78b
CB
12640 * coding.h (coding, code_convert_region, encode_coding_gap):
12641 Remove decls.
74ab6df5
PE
12642 * coding.c (Vsjis_coding_system, Vbig5_coding_system):
12643 (iso_code_class, detect_coding, code_convert_region): Now static.
12644 (encode_coding_gap): Remove; unused.
12645
38dfbee1
PE
12646 * chartab.c (chartab_chars, chartab_bits): Now static.
12647
a2cb4e63
PE
12648 * charset.h (charset_iso_8859_1): Remove decl.
12649 * charset.c (charset_iso_8859_1, charset_emacs, map_charset_for_dump):
12650 Now static.
12651
127198fd
PE
12652 * ccl.h (check_ccl_update, Vccl_program_table): Remove decls.
12653 * ccl.c (Vccl_program_table): Now static.
12654 (check_ccl_update): Remove; unused.
12655
d85b608f
PE
12656 * category.c (SET_CATEGORY_SET, set_category_set): Move here.
12657 * category.h: ... from here.
12658 * category.c (check_category_table, set_category_set): Now static.
12659
31cd66f3
PE
12660 * casetab.c (Vascii_upcase_table, Vascii_eqv_table): Now static.
12661 * lisp.h: Remove these decls.
12662
c358e587
PE
12663 * buffer.c (buffer_count): Remove unused var.
12664
e78aecca
PE
12665 * bidi.c (bidi_dump_cached_states): Mark as externally visible,
12666 so that it's not optimized away.
12667 (bidi_ignore_explicit_marks_for_paragraph_level): Likewise.
12668 * dispextern.h (bidi_dump_cached_states): Remove, since it's
12669 exported only to the debugger.
12670
e192d7d3 12671 * atimer.c (alarm_signal_handler, run_all_atimers): Now static.
04f2d78b 12672 * atimer.h (run_all_atimers): Remove; not exported.
e192d7d3 12673
92470028
PE
12674 font.c: Make copy_font_spec and merge_font_spec ordinary C functions.
12675 * font.c (copy_font_spec): Rename from Fcopy_font_spec, since it
12676 was inaccessible from Lisp.
12677 (merge_font_spec): Likewise, renaming from Fmerge_font_spec.
12678 * font.c, font.h, fontset.c, xfaces.c, xfont.c: Change all uses.
12679
244ed907
PE
12680 alloc.c: Import and export fewer symbols, and remove unused items.
12681 * lisp.h (suppress_checking, die): Declare only if ENABLE_CHECKING
12682 is defined.
12683 (suppress_checking): Add EXTERNALLY_VISIBLE attribute, so that
12684 it's not optimized away by whole-program optimization.
12685 (message_enable_multibyte, free_misc): Remove.
12686 (catchlist, handlerlist, mark_backtrace):
12687 Declare only if BYTE_MARK_STACK.
12688 (mark_byte_stack): Likewise, fixing a ifdef-vs-if typo.
12689 * alloc.c (pure): Export only if VIRT_ADDR_VARIES is defined.
12690 (message_enable_multibyte): Remove decl.
12691 (free_misc, interval_free_list, float_block, float_block_index):
12692 (n_float_blocks, float_free_list, cons_block, cons_block_index):
12693 (cons_free_list, last_marked_index):
12694 Now static.
12695 (suppress_checking, die): Define only if ENABLE_CHECKING is defined.
12696 * eval.c (catchlist, handlerlist): Export only if BYTE_MARK_STACK.
12697 (mark_backtrace): Define only if BYTE_MARK_STACK.
12698 * xdisp.c (message_enable_multibyte): Now static.
12699
61c2b50e 12700 Declare Lisp_Object Q* variables to be 'static' if not exported.
955cbe7b
PE
12701 This makes it easier for human readers (and static analyzers)
12702 to see whether these variables are used from other modules.
12703 * alloc.c, buffer.c, bytecode.c, callint.c, casetab.c, category.c:
12704 * ccl.c, character.c, charset.c, cmds.c, coding.c, composite.c:
12705 * data.c, dbusbind.c, dired.c, editfns.c, eval.c, fileio.c, fns.c:
12706 * font.c, frame.c, fringe.c, ftfont.c, image.c, keyboard.c, keymap.c:
12707 * lread.c, macros.c, minibuf.c, print.c, process.c, search.c:
12708 * sound.c, syntax.c, textprop.c, window.c, xdisp.c, xfaces.c, xfns.c:
12709 * xmenu.c, xselect.c:
12710 Declare Q* vars static if they are not used in other modules.
12711 * ccl.h, character.h, charset.h, coding.h, composite.h, font.h:
12712 * frame.h, intervals.h, keyboard.h, lisp.h, process.h, syntax.h:
12713 Remove decls of unexported vars.
12714 * keyboard.h (EVENT_HEAD_UNMODIFIED): Remove now-unused macro.
12715
95c82688
PE
12716 * lisp.h (DEFINE_FUNC): Make sname 'static'.
12717
16a97296
PE
12718 Make Emacs functions such as Fatom 'static' by default.
12719 This makes it easier for human readers (and static analyzers)
12720 to see whether these functions can be called from other modules.
12721 DEFUN now defines a static function. To make the function external
12722 so that it can be used in other C modules, use the new macro DEFUE.
8bd7b830
PE
12723 * lisp.h (Funibyte_char_to_multibyte, Fsyntax_table_p):
12724 (Finit_image_library):
16a97296
PE
12725 (Feval_region, Fbacktrace, Ffetch_bytecode, Fswitch_to_buffer):
12726 (Ffile_executable_p, Fmake_symbolic_link, Fcommand_execute):
12727 (Fget_process, Fdocumentation_property, Fbyte_code, Ffile_attributes):
12728 Remove decls, since these functions are now static.
12729 (Funintern, Fget_internal_run_time): New decls, since these functions
12730 were already external.
95c82688 12731
16a97296
PE
12732 * alloc.c, buffer.c, callint.c, callproc.c, casefiddle.c, casetab.c:
12733 * ccl.c, character.c, chartab.c, cmds.c, coding.c, data.c, dispnew.c:
12734 * doc.c, editfns.c, emacs.c, eval.c, fileio.c, filelock.c, floatfns.c:
12735 * fns.c, font.c, fontset.c, frame.c, image.c, indent.c:
12736 * keyboard.c, keymap.c, lread.c:
12737 * macros.c, marker.c, menu.c, minibuf.c, print.c, process.c, search.c:
12738 * syntax.c, term.c, terminal.c, textprop.c, undo.c:
12739 * window.c, xdisp.c, xfaces.c, xfns.c, xmenu.c, xsettings.c:
12740 Mark functions with DEFUE instead of DEFUN,
12741 if they are used in other modules.
12742 * buffer.c (Fset_buffer_major_mode, Fdelete_overlay): New forward
12743 decls for now-static functions.
12744 * buffer.h (Fdelete_overlay): Remove decl.
12745 * callproc.c (Fgetenv_internal): Mark as internal.
12746 * composite.c (Fremove_list_of_text_properties): Remove decl.
12747 (Fcomposition_get_gstring): New forward static decl.
12748 * composite.h (Fcomposite_get_gstring): Remove decl.
12749 * dired.c (Ffile_attributes): New forward static decl.
12750 * doc.c (Fdocumntation_property): New forward static decl.
12751 * eval.c (Ffetch_bytecode): New forward static decl.
12752 (Funintern): Remove extern decl; now in .h file where it belongs.
12753 * fileio.c (Fmake_symbolic_link): New forward static decl.
12754 * image.c (Finit_image_library): New forward static decl.
12755 * insdel.c (Fcombine_after_change_execute): Make forward decl static.
12756 * intervals.h (Fprevious_property_change):
12757 (Fremove_list_of_text_properties): Remove decls.
12758 * keyboard.c (Fthis_command_keys): Remove decl.
12759 (Fcommand_execute): New forward static decl.
12760 * keymap.c (Flookup_key): New forward static decl.
12761 (Fcopy_keymap): Now static.
12762 * keymap.h (Flookup_key): Remove decl.
12763 * process.c (Fget_process): New forward static decl.
12764 (Fprocess_datagram_address): Mark as internal.
12765 * syntax.c (Fsyntax_table_p): New forward static decl.
12766 (skip_chars): Remove duplicate decl.
12767 * textprop.c (Fprevious_property_change): New forward static decl.
12768 * window.c (Fset_window_fringes, Fset_window_scroll_bars):
12769 Now internal.
12770 (Fset_window_margins, Fset_window_vscroll): New forward static decls.
12771 * window.h (Fset_window_vscroll, Fset_window_margins): Remove decls.
12772
785bbd42
PE
12773 * editfns.c (Fformat): Remove unreachable code.
12774
8b913b57
AS
127752011-04-14 Andreas Schwab <schwab@linux-m68k.org>
12776
12777 * fileio.c (Finsert_file_contents): Fix typo in 2005-05-13
12778 change. (Bug#8496)
12779
a6744a35
EZ
127802011-04-13 Eli Zaretskii <eliz@gnu.org>
12781
12782 * xdisp.c (handle_invisible_prop): Don't call bidi_paragraph_init
12783 when at ZV. (Bug#8487)
12784
e7974947
AS
127852011-04-12 Andreas Schwab <schwab@linux-m68k.org>
12786
baad03f0
AS
12787 * charset.c (Fclear_charset_maps): Use xfree instead of free.
12788 (Bug#8437)
12789 * keyboard.c (parse_tool_bar_item): Likewise.
12790 * sound.c (sound_cleanup, alsa_close): Likewise.
12791 * termcap.c (tgetent): Likewise.
12792 * xfns.c (x_default_font_parameter): Likewise.
12793 * xsettings.c (read_and_apply_settings): Likewise.
12794
e7974947
AS
12795 * alloc.c (overrun_check_malloc, overrun_check_realloc)
12796 (overrun_check_free): Protoize.
12797
28272684
PE
127982011-04-12 Paul Eggert <eggert@cs.ucla.edu>
12799
12800 * sysdep.c (emacs_read, emacs_write): Check for negative sizes
12801 since callers should never pass a negative size.
12802 Change the signature to match that of plain 'read' and 'write'; see
12803 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00397.html>.
12804 * lisp.h: Update prototypes of emacs_write and emacs_read.
12805
11997c76
EZ
128062011-04-11 Eli Zaretskii <eliz@gnu.org>
12807
12808 * xdisp.c (redisplay_window): Don't try to determine the character
12809 position of the scroll margin if the window start point w->startp
e896f03c 12810 is outside the buffer's accessible region. (Bug#8468)
11997c76 12811
8a2cbd72
EZ
128122011-04-10 Eli Zaretskii <eliz@gnu.org>
12813
12814 Fix write-region and its subroutines for buffers > 2GB.
12815 * fileio.c (a_write, e_write): Modify declaration of arguments and
12816 local variables to support buffers larger than 2GB.
12817 (Fcopy_file): Use EMACS_INT for return value of emacs_read.
12818
12819 * sysdep.c (emacs_write, emacs_read): Use ssize_t for last
12820 argument, local variables, and return value.
12821
12822 * lisp.h: Update prototypes of emacs_write and emacs_read.
12823
12824 * sound.c (vox_write): Use ssize_t for return value of emacs_write.
12825
4073e537 128262011-04-10 Paul Eggert <eggert@cs.ucla.edu>
eb3f1cc8 12827
1ebfdcb6
PE
12828 * xdisp.c (vmessage): Use memchr, not strnlen, which some hosts lack.
12829
b2ded58d
PE
12830 Fix more problems found by GCC 4.6.0's static checks.
12831
7d66342c
PE
12832 * xdisp.c (vmessage): Use a better test for character truncation.
12833
bbf47d44
PE
12834 * charset.c (load_charset_map): <, not <=, for optimization,
12835 and to avoid potential problems with integer overflow.
9248994d 12836 * chartab.c (sub_char_table_set_range, char_table_set_range): Likewise.
f9a68bc5 12837 * casetab.c (set_identity, shuffle): Likewise.
3ab1c7ce 12838 * editfns.c (Fformat): Likewise.
1e69125e 12839 * syntax.c (skip_chars): Likewise.
3befa583 12840
e3019616
PE
12841 * xmenu.c (set_frame_menubar): Allocate smaller local vectors.
12842 This also lets GCC 4.6.0 generate slightly better loop code.
12843
becfa255
PE
12844 * callint.c (Fcall_interactively): <, not <=, for optimization.
12845 (Fcall_interactively): Count the number of arguments produced,
12846 not the number of arguments given. This is simpler and lets GCC
12847 4.6.0 generate slightly better code.
12848
dae0cd48
PE
12849 * ftfont.c: Distingish more carefully between FcChar8 and char.
12850 The previous code passed unsigned char * to a functions like
12851 strlen and xstrcasecmp that expect char *, which does not
12852 conform to the C standard.
12853 (get_adstyle_property, ftfont_pattern_entity): Use FcChar8 for
12854 arguments to FcPatternGetString, and explicitly cast FcChar8 * to
12855 char * when the C standard requires it.
12856
76032d70
PE
12857 * keyboard.c (read_char): Remove unused var.
12858
eb3f1cc8
PE
12859 * eval.c: Port to Windows vsnprintf (Bug#8435).
12860 Include <limits.h>.
12861 (SIZE_MAX): Define if the headers do not.
12862 (verror): Do not give up if vsnprintf returns a negative count.
12863 Instead, grow the buffer. This ports to Windows vsnprintf, which
12864 does not conform to C99. Problem reported by Eli Zaretskii.
12865 Also, simplify the allocation scheme, by avoiding the need for
12866 calling realloc, and removing the ALLOCATED variable.
12867
70476b54
PE
12868 * eval.c (verror): Initial buffer size is 4000 (not 200) bytes.
12869
12020a9e
PE
12870 Remove invocations of doprnt, as Emacs now uses vsnprintf.
12871 But keep the doprint source code for now, as we might revamp it
12872 and use it again (Bug#8435).
ea6c7ae6
PE
12873 * lisp.h (doprnt): Remove.
12874 * Makefile.in (base_obj): Remove doprnt.o.
12875 * deps.mk (doprnt.o): Remove.
12876
5fdb398c
PE
12877 error: Print 32- and 64-bit integers portably (Bug#8435).
12878 Without this change, on typical 64-bit hosts error ("...%d...", N)
12879 was used to print both 32- and 64-bit integers N, which relied on
12880 undefined behavior.
61bdb816 12881 * lisp.h, m/amdx86-64.h, m/ia64.h, m/ibms390x.h (pEd): New macro.
5fdb398c
PE
12882 * lisp.h (error, verror): Mark as printf-like functions.
12883 * eval.c (verror): Use vsnprintf, not doprnt, to do the real work.
12884 Report overflow in size calculations when allocating printf buffer.
12885 Do not truncate output string at its first null byte.
12886 * xdisp.c (vmessage): Use vsnprintf, not doprnt, to do the real work.
12887 Truncate the output at a character boundary, since vsnprintf does not
12888 do that.
12889 * charset.c (check_iso_charset_parameter): Convert internal
12890 character to string before calling 'error', since %c now has the
12891 printf meaning.
12892 * coding.c (Fdecode_sjis_char, Fdecode_big5_char): Avoid int
12893 overflow when computing char to be passed to 'error'. Do not
12894 pass Lisp_Object to 'error'; pass the integer instead.
12895 * nsfns.m (Fns_do_applescript): Use int, not long, since it's
12896 formatted with plain %d.
12897
b189fa66
PE
12898 * eval.c (internal_lisp_condition_case): Don't pass spurious arg.
12899
bff87ef0
PE
12900 * keyboard.c (access_keymap_keyremap): Print func name, not garbage.
12901
7e2cac20
PE
12902 * coding.c (Fdecode_sjis_char): Don't assume CODE fits in int.
12903
ce4d90b5
PE
12904 * xterm.c (x_catch_errors): Remove duplicate declaration.
12905
266c9547
PE
12906 * term.c (maybe_fatal): Mark its 3rd arg as a printf format, too.
12907
79c49ad2
PE
12908 * xdisp.c, lisp.h (message_nolog): Remove; unused.
12909
368f4090
JM
129102011-04-10 Jim Meyering <meyering@redhat.com>
12911
12912 use ssize_t and size_t for read- and write-like emacs_gnutls_* functions
12913 * gnutls.c (emacs_gnutls_read): Adjust signature to be more read-like:
12914 return ssize_t not "int", and use size_t as the buffer length.
12915 (emacs_gnutls_write): Likewise, and make the buffer pointer "const".
12916 * gnutls.h: Update declarations.
12917 * process.c (read_process_output): Use ssize_t, to match.
12918 (send_process): Likewise.
12919
a32d4040
CY
129202011-04-09 Chong Yidong <cyd@stupidchicken.com>
12921
12922 * image.c (Fimagemagick_types): Doc fix, and comment cleanup.
12923
8546720e 129242011-04-09 Chong Yidong <cyd@stupidchicken.com>
aac0c6e3 12925
04f2d78b
CB
12926 * ftfont.c (get_adstyle_property, ftfont_pattern_entity):
12927 Use unsigned char, to match FcChar8 type definition.
aac0c6e3 12928
8546720e
GM
12929 * xterm.c (handle_one_xevent):
12930 * xmenu.c (create_and_show_popup_menu):
12931 * xselect.c (x_decline_selection_request)
12932 (x_reply_selection_request): Avoid type-punned deref of X events.
aac0c6e3 12933
0a2f5c1a 129342011-04-09 Eli Zaretskii <eliz@gnu.org>
a53e2e89
EZ
12935
12936 Fix some uses of `int' instead of EMACS_INT.
12937 * search.c (string_match_1, fast_string_match)
12938 (fast_c_string_match_ignore_case, fast_string_match_ignore_case)
12939 (scan_buffer, find_next_newline_no_quit)
12940 (find_before_next_newline, search_command, Freplace_match)
12941 (Fmatch_data): Make some `int' variables be EMACS_INT.
12942
12943 * xdisp.c (display_count_lines): 3rd argument and return value now
12944 EMACS_INT. All callers changed.
12945 (pint2hrstr): Last argument is now EMACS_INT.
12946
12947 * coding.c (detect_coding_utf_8, detect_coding_emacs_mule)
12948 (detect_coding_iso_2022, detect_coding_sjis, detect_coding_big5)
12949 (detect_coding_ccl, detect_coding_charset, decode_coding_utf_8)
12950 (decode_coding_utf_16, decode_coding_emacs_mule)
12951 (decode_coding_iso_2022, decode_coding_sjis, decode_coding_big5)
12952 (decode_coding_ccl, decode_coding_charset)
12953 <consumed_chars, consumed_chars_base>: Declare EMACS_INT.
12954 (decode_coding_iso_2022, decode_coding_emacs_mule)
12955 (decode_coding_sjis, decode_coding_big5, decode_coding_charset)
12956 <char_offset, last_offset>: Declare EMACS_INT.
12957 (encode_coding_utf_8, encode_coding_utf_16)
12958 (encode_coding_emacs_mule, encode_invocation_designation)
12959 (encode_designation_at_bol, encode_coding_iso_2022)
12960 (encode_coding_sjis, encode_coding_big5, encode_coding_ccl)
12961 (encode_coding_raw_text, encode_coding_charset) <produced_chars>:
12962 Declare EMACS_INT.
12963 (ASSURE_DESTINATION): Declare more_bytes EMACS_INT.
12964 (encode_invocation_designation): Last argument P_NCHARS is now
12965 EMACS_INT.
12966 (decode_eol): Declare pos_byte, pos, and pos_end EMACS_INT.
12967 (produce_chars): from_nchars and to_nchars are now EMACS_INT.
12968
12969 * coding.h (struct coding_system) <head_ascii>: Declare EMACS_INT.
12970 All users changed.
12971
12972 * ccl.c (Fccl_execute_on_string): Declare some variables
12973 EMACS_INT.
12974
8546720e 129752011-04-08 Samuel Thibault <sthibault@debian.org> (tiny change)
0080dc6b
SS
12976
12977 * term.c (init_tty): Fix incorrect ifdef placement (Bug#8450).
12978
4e19a977
CS
129792011-03-19 Christoph Scholtes <cschol2112@googlemail.com>
12980
12981 * process.c (Fformat_network_address): Doc fix.
12982
87302331
R
129832011-04-08 T.V. Raman <tv.raman.tv@gmail.com> (tiny change)
12984
ee7683eb 12985 * xml.c (parse_region): Avoid creating spurious whitespace nodes.
87302331 12986
cbb59342
CY
129872011-04-08 Chong Yidong <cyd@stupidchicken.com>
12988
12989 * keyboard.c (read_char): Call Lisp function help-form-show,
12990 instead of using internal_with_output_to_temp_buffer.
12991 (Qhelp_form_show): New var.
e0d38eeb 12992 (syms_of_keyboard): Use DEFSYM macro.
cbb59342
CY
12993
12994 * print.c (internal_with_output_to_temp_buffer): Function deleted.
12995
12996 * lisp.h (internal_with_output_to_temp_buffer): Remove prototype.
12997
e67a13ab
CY
129982011-04-06 Chong Yidong <cyd@stupidchicken.com>
12999
04f2d78b
CB
13000 * process.c (Flist_processes): Remove to Lisp.
13001 (list_processes_1): Delete.
e67a13ab 13002
973f782d
EZ
130032011-04-06 Eli Zaretskii <eliz@gnu.org>
13004
7c106b1e
EZ
13005 * msdos.c (careadlinkat, careadlinkatcwd): MS-DOS replacements.
13006
973f782d
EZ
13007 * w32.c (careadlinkat, careadlinkatcwd): New always-fail stubs.
13008
41cf7d1a 130092011-04-06 Paul Eggert <eggert@cs.ucla.edu>
27ccc379 13010
ca23cc88
PE
13011 Fix more problems found by GCC 4.6.0's static checks.
13012
f390e2d5
PE
13013 * xmenu.c (Fx_popup_dialog): Don't assume string is free of formats.
13014
42eea0d0
PE
13015 * menu.c (Fx_popup_menu): Don't assume error_name lacks printf formats.
13016
b69769da 13017 * lisp.h (message, message_nolog, fatal): Mark as printf-like.
1e973bc7 13018
f9541e84
PE
13019 * xdisp.c (vmessage): Mark as a printf-like function.
13020
13841b55
PE
13021 * term.c (vfatal, maybe_fatal): Mark as printf-like functions.
13022
c136c10f
PE
13023 * sound.c (sound_warning): Don't crash if arg contains a printf format.
13024
5e2d4a30
PE
13025 * image.c (tiff_error_handler, tiff_warning_handler): Mark as
13026 printf-like functions.
13027 (tiff_load): Add casts to remove these marks before passing them
13028 to system-supplied API.
13029
583f48b9
PE
13030 * eval.c (Fsignal): Remove excess argument to 'fatal'.
13031
b25d760e
PE
13032 * coding.c (EMIT_ONE_BYTE, EMIT_TWO_BYTES): Use unsigned, not int.
13033 This avoids several warnings with gcc -Wstrict-overflow.
d5efd1d1
PE
13034 (DECODE_COMPOSITION_RULE): If the rule is invalid, goto invalid_code
13035 directly, rather than having caller test rule sign. This avoids
13036 some unnecessary tests.
13037 * composite.h (COMPOSITION_ENCODE_RULE_VALID): New macro.
13038 (COMPOSITION_ENCODE_RULE): Arguments now must be valid. This
13039 affects only one use, in DECODE_COMPOSITION_RULE, which is changed.
b25d760e 13040
bc7b6697 13041 * xfont.c (xfont_text_extents): Remove var that was set but not used.
625a3eb1 13042 (xfont_open): Avoid unnecessary tests.
bc7b6697 13043
27ccc379
PE
13044 * composite.c (composition_gstring_put_cache): Use unsigned integer.
13045
dcd5c89a
PE
13046 * composite.h, composite.c (composition_gstring_put_cache):
13047 Use EMACS_INT, not int, for length.
13048
b13a45c6
PE
13049 * composite.h (COMPOSITION_DECODE_REFS): New macro,
13050 breaking out part of COMPOSITION_DECODE_RULE.
13051 (COMPOSITION_DECODE_RULE): Use it.
13052 * composite.c (get_composition_id): Remove unused local vars,
13053 by using the new macro.
13054
1e792e4d
PE
13055 * textprop.c (set_text_properties_1): Change while to do-while,
13056 since the condition is always true at first.
13057
dc6c6455 13058 * intervals.c (graft_intervals_into_buffer): Mark var as used.
aa86731f
PE
13059 (interval_deletion_adjustment): Return unsigned value.
13060 All uses changed.
dc6c6455 13061
aba7731a
PE
13062 * process.c (list_processes_1, create_pty, read_process_output):
13063 (exec_sentinel): Remove vars that were set but not used.
afd4052b 13064 (create_pty): Remove unnecessary "volatile"s.
bc57d757 13065 (Fnetwork_interface_info): Avoid possibility of int overflow.
82eaa333 13066 (read_process_output): Do adaptive read buffering even if carryover.
fe07cdfa 13067 (read_process_output): Simplify nbytes computation if buffered.
aba7731a 13068
fdfc4bf3
PE
13069 * bytecode.c (exec_byte_code): Rename local to avoid shadowing.
13070
fca8fe46 13071 * syntax.c (scan_words): Remove var that was set but not used.
12cbf13f 13072 (update_syntax_table): Use unsigned instead of int.
fca8fe46 13073
06a0259a 13074 * lread.c (lisp_file_lexically_bound_p): Use ints rather than endptrs.
3c346cc3 13075 (lisp_file_lexically_bound_p, read1): Use unsigned instead of int.
e6eb4e9e 13076 (safe_to_load_p): Make the end-of-loop test the inverse of the in-loop.
06a0259a 13077
e7b9e80f
PE
13078 * print.c (print_error_message): Avoid int overflow.
13079
56201685
PE
13080 * font.c (font_list_entities): Redo for clarity,
13081 so that reader need not know FONT_DPI_INDEX + 1 == FONT_SPACING_INDEX.
13082
78834453 13083 * font.c (font_find_for_lface, Ffont_get_glyphs): Remove unused vars.
790771b1 13084 (font_score): Avoid potential overflow in diff calculation.
78834453 13085
0bc0b309 13086 * fns.c (substring_both): Remove var that is set but not used.
8cd55cb4 13087 (sxhash): Redo loop for clarity and to avoid wraparound warning.
0bc0b309 13088
e610eaca
PE
13089 * eval.c (funcall_lambda): Rename local to avoid shadowing.
13090
b895abce
PE
13091 * alloc.c (mark_object_loop_halt, mark_object): Use size_t, not int.
13092 Otherwise, GCC 4.6.0 optimizes the loop check away since the check
13093 can always succeed if overflow has undefined behavior.
13094
1f1d9321 13095 * search.c (boyer_moore, wordify): Remove vars set but not used.
6f076cc7 13096 (wordify): Omit three unnecessary tests.
1f1d9321 13097
c59478bc
PE
13098 * indent.c (MULTIBYTE_BYTES_WIDTH): Don't compute wide_column.
13099 All callers changed. This avoids the need for an unused var.
13100
79b73827
PE
13101 * casefiddle.c (casify_region): Remove var that is set but not used.
13102
a4db5dfe
PE
13103 * dired.c (file_name_completion): Remove var that is set but not used.
13104
43aae36e
PE
13105 * fileio.c (Finsert_file_contents): Make EOF condition clearer.
13106
2a47c44d 13107 * fileio.c (Finsert_file_contents): Avoid signed integer overflow.
163c5f32 13108 (Finsert_file_contents): Remove unnecessary code checking fd.
2a47c44d 13109
a37c69bf
PE
13110 * minibuf.c (read_minibuf_noninteractive): Use size_t for sizes.
13111 Check for integer overflow on size calculations.
13112
328ab8e7
PE
13113 * buffer.c (Fprevious_overlay_change): Remove var that is set
13114 but not used.
13115
e5a2a5cb
PE
13116 * keyboard.c (menu_bar_items, read_char_minibuf_menu_prompt):
13117 Remove vars that are set but not used.
8d84a6eb 13118 (timer_check_2): Don't assume timer-list and idle-timer-list are lists.
6b043475 13119 (timer_check_2): Mark vars as initialized.
e5a2a5cb 13120
a60e5f68
PE
13121 * gtkutil.c (xg_get_file_with_chooser): Mark var as initialized.
13122
f661cb61 13123 * image.c (lookup_image): Remove var that is set but not used.
35fa624f 13124 (xbm_load): Use parse_p, for gcc -Werror=unused-but-set-variable.
f661cb61 13125
f0397f5a
PE
13126 * fontset.c (Finternal_char_font, Ffontset_info): Remove vars
13127 that are set but not used.
13128
8664db06 13129 * xfns.c (make_invisible_cursor): Don't return garbage
03733ee7 13130 if XCreateBitmapFromData fails (Bug#8410).
8664db06 13131
6abdaa4a
PE
13132 * xselect.c (x_get_local_selection, x_handle_property_notify):
13133 Remove vars that are set but not used.
13134
0ce7538d 13135 * xfns.c (x_create_tip_frame): Remove var that is set but not used.
6abdaa4a 13136 (make_invisible_cursor): Initialize a possibly-uninitialized variable.
0ce7538d 13137
9ae848fc
PE
13138 * xterm.c (x_scroll_bar_to_input_event) [!USE_GTK]:
13139 Remove var that is set but not used.
0b918413
PE
13140 (scroll_bar_windows_size): Now size_t, not int.
13141 (x_send_scroll_bar_event): Use size_t, not int, for sizes.
13142 Check for overflow.
9ae848fc 13143
a5a62657
PE
13144 * xfaces.c (realize_named_face): Remove vars that are set but not used.
13145 (map_tty_color) [!defined MSDOS]: Likewise.
13146
5c5cdd39
PE
13147 * term.c (tty_write_glyphs): Use size_t; this avoids overflow warning.
13148
66ebf983
PE
13149 * coding.c: Remove vars that are set but not used.
13150 (DECODE_COMPOSITION_RULE): Remove 2nd arg, which is unused.
13151 All callers changed.
13152 (decode_coding_utf_8, decode_coding_utf_16 decode_coding_emacs_mule):
13153 (decode_coding_iso_2022, encode_coding_sjis, encode_coding_big5):
13154 (decode_coding_charset): Remove vars that are set but not used.
13155
1be4d761
PE
13156 * bytecode.c (Fbyte_code) [!defined BYTE_CODE_SAFE]: Remove var
13157 that is set but not used.
13158
47553fa8
PE
13159 * print.c (print_object): Remove var that is set but not used.
13160
1f7196bf 13161 Replace 2 copies of readlink code with 1 gnulib version (Bug#8401).
d1fdcab7
PE
13162 The gnulib version avoids calling malloc in the usual case,
13163 and on 64-bit hosts doesn't have some arbitrary 32-bit limits.
13164 * fileio.c (Ffile_symlink_p): Use emacs_readlink.
13165 * filelock.c (current_lock_owner): Likewise.
13166 * lisp.h (READLINK_BUFSIZE, emacs_readlink): New function.
13167 * sysdep.c: Include allocator.h, careadlinkat.h.
13168 (emacs_no_realloc_allocator): New static constant.
13169 (emacs_readlink): New function.
fdb61804
PE
13170 * deps.mk (sysdep.o): Depend on ../lib/allocator.h and on
13171 ../lib/careadlinkat.h.
d1fdcab7 13172
f84c17c7
SM
131732011-04-04 Stefan Monnier <monnier@iro.umontreal.ca>
13174
13175 * keyboard.c (safe_run_hook_funcall): Fix last change (don't stop at the
13176 first non-nil return value).
13177
ef3862ad
JD
131782011-04-03 Jan Djärv <jan.h.d@swipnet.se>
13179
13180 * nsterm.m (ns_update_auto_hide_menu_bar): Define MAC_OS_X_VERSION_10_6
13181 if not defined (Bug#8403).
13182
376a7006
JB
131832011-04-02 Juanma Barranquero <lekktu@gmail.com>
13184
13185 * xdisp.c (display_count_lines): Remove parameter `start',
13186 unused since 1998-01-01T02:27:27Z!rms@gnu.org. All callers changed.
13187 (get_char_face_and_encoding): Remove parameter `multibyte_p',
13188 unused since 2008-05-14T01:40:23Z!handa@m17n.org. All callers changed.
13189 (fill_stretch_glyph_string): Remove parameters `row' and `area',
13190 unused at least since Kim's GUI unification at 2003-03-16T20:45:46Z!storm@cua.dk
13191 and thereabouts. All callers changed.
13192 (get_per_char_metric): Remove parameter `f', unused since
13193 2008-05-14T01:40:23Z!handa@m17n.org. All callers changed.
13194
6ca3801d
JM
131952011-04-02 Jim Meyering <meyering@redhat.com>
13196
13197 do not dereference NULL upon failed strdup
13198 * nsfont.m (ns_descriptor_to_entity): Use xstrdup, not strdup.
13199 (ns_get_family): Likewise.
13200
d8e2b5ba
JB
132012011-04-02 Juanma Barranquero <lekktu@gmail.com>
13202
13203 * eval.c (unwind_to_catch) [DEBUG_GCPRO]: Remove redundant assignment.
13204
8c74fcbd
JD
132052011-04-02 Jan Djärv <jan.h.d@swipnet.se>
13206
13207 * nsterm.m (ns_update_auto_hide_menu_bar): Only for OSX 10.6 or
13208 later (Bug#8403).
13209
7200d79c
SM
132102011-04-01 Stefan Monnier <monnier@iro.umontreal.ca>
13211
03408648 13212 Add lexical binding.
7200d79c 13213
03408648
SM
13214 * window.c (Ftemp_output_buffer_show): New fun.
13215 (Fsave_window_excursion):
13216 * print.c (Fwith_output_to_temp_buffer): Move to subr.el.
13217
13218 * lread.c (lisp_file_lexically_bound_p): New function.
13219 (Fload): Bind Qlexical_binding.
13220 (readevalloop): Remove `evalfun' arg.
13221 Bind Qinternal_interpreter_environment.
13222 (Feval_buffer): Bind Qlexical_binding.
13223 (defvar_int, defvar_bool, defvar_lisp_nopro, defvar_kboard):
13224 Mark as dynamic.
13225 (syms_of_lread): Declare `lexical-binding'.
13226
13227 * lisp.h (struct Lisp_Symbol): New field `declared_special'.
13228
13229 * keyboard.c (eval_dyn): New fun.
13230 (menu_item_eval_property): Use it.
ca105506
SM
13231
13232 * image.c (parse_image_spec): Use Ffunctionp.
ca105506 13233
03408648
SM
13234 * fns.c (concat, mapcar1): Accept byte-code-functions.
13235
13236 * eval.c (Fsetq): Handle lexical vars.
13237 (Fdefun, Fdefmacro, Ffunction): Make closures when needed.
13238 (Fdefconst, Fdefvaralias, Fdefvar): Mark as dynamic.
13239 (FletX, Flet): Obey lexical binding.
13240 (Fcommandp): Handle closures.
13241 (Feval): New `lexical' arg.
13242 (eval_sub): New function extracted from Feval. Use it almost
13243 everywhere where Feval was used. Look up vars in lexical env.
13244 Handle closures.
13245 (Ffunctionp): Move from subr.el.
13246 (Ffuncall): Handle closures.
13247 (apply_lambda): Remove `eval_flags'.
13248 (funcall_lambda): Handle closures and new byte-code-functions.
13249 (Fspecial_variable_p): New function.
13250 (syms_of_eval): Initialize the Vinternal_interpreter_environment var,
13251 but without exporting it to Lisp.
23aba0ea 13252
23aba0ea 13253 * doc.c (Fdocumentation, store_function_docstring):
03408648 13254 * data.c (Finteractive_form): Handle closures.
23aba0ea 13255
03408648
SM
13256 * callint.c (Fcall_interactively): Preserve lexical-binding mode for
13257 interactive spec.
ba83908c 13258
04f2d78b
CB
13259 * bytecode.c (Bstack_ref, Bstack_set, Bstack_set2, BdiscardN):
13260 New byte-codes.
03408648
SM
13261 (exec_byte_code): New function extracted from Fbyte_code to handle new
13262 calling convention for byte-code-functions. Add new byte-codes.
ba83908c 13263
03408648 13264 * buffer.c (defvar_per_buffer): Set new `declared_special' field.
e2abe5a1 13265
03408648 13266 * alloc.c (Fmake_symbol): Init new `declared_special' field.
e2abe5a1 13267
e2abce01
JB
132682011-03-31 Juanma Barranquero <lekktu@gmail.com>
13269
13270 * xdisp.c (redisplay_internal): Fix prototype.
13271
63696a73 132722011-03-31 Eli Zaretskii <eliz@gnu.org>
09725d26 13273
63696a73 13274 * xdisp.c (SCROLL_LIMIT): New macro.
04f2d78b
CB
13275 (try_scrolling): Use it when setting scroll_limit.
13276 Limit scrolling to 100 screen lines.
63696a73
EZ
13277 (redisplay_window): Even when falling back on "recentering",
13278 position point in the window according to scroll-conservatively,
13279 scroll-margin, and scroll-*-aggressively variables. (Bug#6671)
13280
13281 (try_scrolling): When point is above the window, allow searching
13282 as far as scroll_max, or one screenful, to compute vertical
13283 distance from PT to the scroll margin position. This prevents
13284 try_scrolling from unnecessarily failing when
13285 scroll-conservatively is set to a value slightly larger than the
13286 window height. Clean up the case of PT below the margin at bottom
13287 of window: scroll_max can no longer be INT_MAX. When aggressive
13288 scrolling is in use, don't let point enter the opposite scroll
13289 margin as result of the scroll.
13290 (syms_of_xdisp) <scroll-conservatively>: Document the
09725d26
EZ
13291 threshold of 100 lines for never-recentering scrolling.
13292
e4cc2dfc
JB
132932011-03-31 Juanma Barranquero <lekktu@gmail.com>
13294
13295 * dispextern.h (move_it_by_lines):
13296 * xdisp.c (move_it_by_lines): Remove parameter `need_y_p', unused
13297 since 2000-12-29T14:24:09Z!gerd@gnu.org. All callers changed.
13298 (message_log_check_duplicate): Remove parameters `prev_bol' and
13299 `this_bol', unused since 1998-01-01T02:27:27Z!rms@gnu.org. All callers changed.
13300 (redisplay_internal): Remove parameter `preserve_echo_area',
13301 unused since 1999-07-21T21:43:52Z!gerd@gnu.org. All callers changed.
13302
13303 * indent.c (Fvertical_motion):
13304 * window.c (window_scroll_pixel_based, Frecenter):
13305 Don't pass `need_y_p' to `move_it_by_lines'.
13306
1c470562
SM
133072011-03-30 Stefan Monnier <monnier@iro.umontreal.ca>
13308
44f230aa
SM
13309 * eval.c (struct backtrace): Don't cheat with negative numbers, but do
13310 steal a few bits to be more compact.
13311 (interactive_p, Fbacktrace, Fbacktrace_frame, mark_backtrace):
13312 Remove unneeded casts.
13313
1c470562
SM
13314 * bytecode.c (Fbyte_code): CAR and CDR can GC.
13315
888adce9
ZK
133162011-03-30 Zachary Kanfer <zkanfer@gmail.com> (tiny change)
13317
13318 * keyboard.c (Fexecute_extended_command): Do log the "suggest key
13319 binding" message (bug#7967).
13320
f838ed7b
PE
133212011-03-30 Paul Eggert <eggert@cs.ucla.edu>
13322
77861b95
PE
13323 Fix more problems found by GCC 4.6.0's static checks.
13324
de6dbc14
PE
13325 * unexelf.c (unexec) [! (defined _SYSTYPE_SYSV || defined __sgi)]:
13326 Remove unused local var.
13327
f838ed7b
PE
13328 * editfns.c (Fmessage_box): Remove unused local var.
13329
792c7b2b
PE
13330 * xdisp.c (try_window_reusing_current_matrix, x_produce_glyphs):
13331 (note_mode_line_or_margin_highlight, note_mouse_highlight):
13332 Omit unused local vars.
c499e557 13333 * window.c (shrink_windows): Omit unused local var.
b01a1c29 13334 * menu.c (digest_single_submenu): Omit unused local var.
0bc32927
PE
13335 * dispnew.c (update_window) [PERIODIC_PREEMPTION_CHECKING]:
13336 Omit unused local var.
13337
ba0165e1
PE
13338 * keyboard.c (parse_modifiers_uncached, parse_modifiers):
13339 Don't assume string length fits in int.
32ad8845 13340 (keyremap_step, read_key_sequence): Use size_t for sizes.
48011560 13341 (read_key_sequence): Don't check last_real_key_start redundantly.
ba0165e1 13342
3c59b4c9
PE
13343 * callproc.c (Fcall_process, Fcall_process_region): Use SAFE_ALLOCA
13344 instead of alloca (Bug#8344).
13345
a3eed478 13346 * eval.c (Fbacktrace): Don't assume nargs fits in int.
5d5d959d 13347 (Fbacktrace_frame): Don't assume nframes fits in int.
a3eed478 13348
eb4d412d
PE
13349 * syntax.c (scan_sexps_forward): Avoid pointer wraparound.
13350
1658b401
PE
13351 * xterm.c (x_make_frame_visible, same_x_server): Redo to avoid overflow
13352 concerns.
13353
13354 * term.c (produce_glyphless_glyph): Remove unnecessary test.
13355
13356 * cm.c (calccost): Turn while-do into do-while, for clarity.
44f730c8 13357
9a2c6e05
PE
13358 * keyboard.c (syms_of_keyboard): Use the same style as later
13359 in this function when indexing through an array. This also
13360 works around GCC bug 48267.
13361
03d0a109
PE
13362 * image.c (tiff_load): Fix off-by-one image count (Bug#8336).
13363
44f730c8
PE
13364 * xselect.c (x_check_property_data): Return correct size (Bug#8335).
13365
fe75f926
PE
13366 * chartab.c (sub_char_table_ref_and_range): Redo for slight
13367 efficiency gain, and to bypass a gcc -Wstrict-overflow warning.
13368
ffa8c828
PE
13369 * keyboard.c, keyboard.h (num_input_events): Now size_t.
13370 This avoids undefined behavior on integer overflow, and is a bit
13371 more convenient anyway since it is compared to a size_t variable.
13372
c5101a77
PE
13373 Variadic C functions now count arguments with size_t, not int.
13374 This avoids an unnecessary limitation on 64-bit machines, which
13375 caused (substring ...) to crash on large vectors (Bug#8344).
13376 * lisp.h (struct Lisp_Subr.function.aMANY): Now takes size_t, not int.
13377 (DEFUN_ARGS_MANY, internal_condition_case_n, safe_call): Likewise.
77861b95 13378 All variadic functions and their callers changed accordingly.
c5101a77
PE
13379 (struct gcpro.nvars): Now size_t, not int. All uses changed.
13380 * data.c (arith_driver, float_arith_driver): Likewise.
13381 * editfns.c (general_insert_function): Likewise.
13382 * eval.c (struct backtrace.nargs, interactive_p)
13383 (internal_condition_case_n, run_hook_with_args, apply_lambda)
13384 (funcall_lambda, mark_backtrace): Likewise.
13385 * fns.c (concat): Likewise.
13386 * frame.c (x_set_frame_parameters): Likewise.
13387 * fns.c (get_key_arg): Now accepts and returns size_t, and returns
13388 0 if not found, not -1. All callers changed.
13389
dd3f25f7
PE
13390 * alloc.c (garbage_collect): Don't assume stack size fits in int.
13391 (stack_copy_size): Now size_t, not int.
13392 (stack_copy, stack_copy_size): Define only if MAX_SAVE_STACK > 0.
13393
461c2ab9
JB
133942011-03-28 Juanma Barranquero <lekktu@gmail.com>
13395
13396 * coding.c (encode_designation_at_bol): Remove parameter `charbuf_end',
13397 unused since 2002-03-01T01:17:24Z!handa@m17n.org and 2008-02-01T16:01:31Z!miles@gnu.org.
13398 All callers changed.
13399
13400 * lisp.h (multibyte_char_to_unibyte):
13401 * character.c (multibyte_char_to_unibyte): Remove parameter `rev_tbl',
13402 unused since 2002-03-01T01:16:34Z!handa@m17n.org and 2008-02-01T16:01:31Z!miles@gnu.org.
13403 * character.h (CHAR_TO_BYTE8):
13404 * cmds.c (internal_self_insert):
13405 * editfns.c (general_insert_function):
13406 * keymap.c (push_key_description):
13407 * search.c (Freplace_match):
13408 * xdisp.c (message_dolog, set_message_1): All callers changed.
13409
f6d62986
SM
134102011-03-28 Stefan Monnier <monnier@iro.umontreal.ca>
13411
13412 * keyboard.c (safe_run_hook_funcall): New function.
13413 (safe_run_hooks_1, safe_run_hooks_error, safe_run_hooks): On error,
13414 don't set the hook to nil, but remove the offending function instead.
13415 (Qcommand_hook_internal): Remove, unused.
13416 (syms_of_keyboard): Don't initialize Qcommand_hook_internal nor define
13417 Vcommand_hook_internal.
13418
13419 * eval.c (enum run_hooks_condition): Remove.
13420 (funcall_nil, funcall_not): New functions.
13421 (run_hook_with_args): Call each function through a `funcall' argument.
13422 Remove `cond' argument, now redundant.
13423 (Frun_hooks, Frun_hook_with_args, Frun_hook_with_args_until_success)
13424 (Frun_hook_with_args_until_failure): Adjust accordingly.
13425 (run_hook_wrapped_funcall, Frun_hook_wrapped): New functions.
13426
1db5b1ad
JB
134272011-03-28 Juanma Barranquero <lekktu@gmail.com>
13428
13429 * dispextern.h (string_buffer_position): Remove declaration.
13430
13431 * print.c (strout): Remove parameter `multibyte', unused since
13432 1999-08-21T19:30:21Z!gerd@gnu.org. All callers changed.
13433
13434 * search.c (boyer_moore): Remove parameters `len', `pos' and `lim',
13435 never used since function introduction in 1998-02-08T21:33:56Z!rms@gnu.org.
13436 All callers changed.
13437
13438 * w32.c (_wsa_errlist): Use braces for struct initializers.
13439
13440 * xdisp.c (string_buffer_position_lim): Remove parameter `w',
13441 never used since function introduction in 2001-03-09T18:41:50Z!gerd@gnu.org.
13442 All callers changed.
13443 (string_buffer_position): Likewise. Also, make static (it's never
13444 used outside xdisp.c).
13445 (cursor_row_p): Remove parameter `w', unused since
13446 2000-10-17T16:08:57Z!gerd@gnu.org. All callers changed.
13447 (decode_mode_spec): Remove parameter `precision', introduced during
13448 Gerd Moellmann's rewrite at 1999-07-21T21:43:52Z!gerd@gnu.org, but never used.
13449 All callers changed.
13450
5ffb62aa
JD
134512011-03-27 Jan Djärv <jan.h.d@swipnet.se>
13452
13453 * nsterm.m (syms_of_nsterm): Use doc: for ns-auto-hide-menu-bar.
13454
461c2ab9 134552011-03-27 Anders Lindgren <andlind@gmail.com>
f0a1382a
JD
13456
13457 * nsterm.m (ns_menu_bar_is_hidden): New variable.
13458 (ns_constrain_all_frames, ns_menu_bar_should_be_hidden)
13459 (ns_update_auto_hide_menu_bar): New functions.
13460 (ns_update_begin): Call ns_update_auto_hide_menu_bar.
13461 (applicationDidBecomeActive): Call ns_update_auto_hide_menu_bar and
13462 ns_constrain_all_frames.
13463 (constrainFrameRect): Return at once if ns_menu_bar_should_be_hidden.
13464 (syms_of_nsterm): DEFVAR ns-auto-hide-menu-bar, init to Qnil.
13465
5c380ffb
JD
134662011-03-27 Jan Djärv <jan.h.d@swipnet.se>
13467
13468 * nsmenu.m (runDialogAt): Remove argument to timer_check.
13469
9af30bdf
GM
134702011-03-27 Glenn Morris <rgm@gnu.org>
13471
13472 * syssignal.h: Replace RETSIGTYPE with void.
13473 * atimer.c, data.c, dispnew.c, emacs.c, floatfns.c, keyboard.c:
13474 * keyboard.h, lisp.h, process.c, sysdep.c, xterm.c:
13475 Replace SIGTYPE with void everywhere.
13476 * s/usg5-4-common.h (SIGTYPE): Remove definition.
13477 * s/template.h (SIGTYPE): Remove commented out definition.
13478
e2abce01
JB
134792011-03-26 Eli Zaretskii <eliz@gnu.org>
13480
13481 * xdisp.c (redisplay_window): Don't check buffer's clip_changed
13482 flag as a prerequisite for invoking try_scrolling. (Bug#6671)
13483
f868cd8a
JB
134842011-03-26 Juanma Barranquero <lekktu@gmail.com>
13485
59eb0929
JB
13486 * w32.c (read_unc_volume): Use parameter `henum', instead of
13487 global variable `wget_enum_handle'.
13488
13489 * keymap.c (describe_vector): Remove parameters `indices' and
13490 `char_table_depth', unused since 2002-03-01T01:43:26Z!handa@m17n.org.
13491 (describe_map, Fdescribe_vector): Adjust calls to `describe_vector'.
13492
f868cd8a
JB
13493 * keyboard.h (timer_check, show_help_echo): Remove unused parameters.
13494
13495 * keyboard.c (timer_check): Remove parameter `do_it_now',
13496 unused since 1996-04-12T06:01:29Z!rms@gnu.org.
13497 (show_help_echo): Remove parameter `ok_to_overwrite_keystroke_echo',
13498 unused since 2008-04-19T19:30:53Z!monnier@iro.umontreal.ca.
13499
13500 * keyboard.c (read_char):
13501 * w32menu.c (w32_menu_display_help):
13502 * xmenu.c (show_help_event, menu_help_callback):
13503 Adjust calls to `show_help_echo'.
13504
13505 * gtkutil.c (xg_maybe_add_timer):
13506 * keyboard.c (readable_events):
13507 * process.c (wait_reading_process_output):
13508 * xmenu.c (x_menu_wait_for_event): Adjust calls to `timer_check'.
13509
13510 * insdel.c (adjust_markers_gap_motion):
13511 Remove; no-op since 1998-01-02T21:29:48Z!rms@gnu.org.
13512 (gap_left, gap_right): Don't call it.
13513
2ecf6fdb
CY
135142011-03-25 Chong Yidong <cyd@stupidchicken.com>
13515
13516 * xdisp.c (handle_fontified_prop): Discard changes to clip_changed
13517 incurred during fontification.
13518
6b1f9ba4
JB
135192011-03-25 Juanma Barranquero <lekktu@gmail.com>
13520
13521 * buffer.c (defvar_per_buffer): Remove unused parameter `doc'.
13522 (DEFVAR_PER_BUFFER): Don't pass it.
13523
13524 * dispnew.c (row_equal_p, add_row_entry): Remove unused parameter `w'.
13525 (scrolling_window): Don't pass it.
13526
0f4a96b5
JB
135272011-03-25 Juanma Barranquero <lekktu@gmail.com>
13528
13529 * dispextern.h (glyph_matric): Use #if GLYPH_DEBUG, not #ifdef.
13530
13531 * fileio.c (check_executable) [DOS_NT]: Remove unused variables `len'
13532 and `suffix'.
13533 (Fset_file_selinux_context) [HAVE_LIBSELINUX]: Move here declaration
13534 of variables specific to SELinux and computation of `encoded_absname'.
13535
13536 * image.c (XPutPixel): Remove unused variable `height'.
13537
13538 * keyboard.c (make_lispy_event): Remove unused variable `hpos'.
13539
13540 * unexw32.c (get_section_info): Remove unused variable `section'.
13541
13542 * w32.c (stat): Remove unused variables `drive_root' and `devtype'.
13543 (system_process_attributes): Remove unused variable `sess'.
13544 (sys_read): Remove unused variable `err'.
13545
13546 * w32fns.c (top): Wrap variables with #if GLYPH_DEBUG, not #ifdef.
13547 (w32_wnd_proc): Remove unused variable `isdead'.
13548 (unwind_create_frame): Use #if GLYPH_DEBUG, not #ifdef.
13549 (Fx_server_max_request_size): Remove unused variable `dpyinfo'.
13550 (x_create_tip_frame): Remove unused variable `tem'.
13551
13552 * w32inevt.c (w32_console_read_socket):
13553 Remove unused variable `no_events'.
13554
13555 * w32term.c (x_draw_composite_glyph_string_foreground):
13556 Remove unused variable `width'.
13557
1149507c
JB
135582011-03-24 Juanma Barranquero <lekktu@gmail.com>
13559
13560 * w32term.c (x_set_glyph_string_clipping):
13561 Don't pass uninitialized region to CombineRgn.
13562
9c88f339
JB
135632011-03-23 Juanma Barranquero <lekktu@gmail.com>
13564
13565 * w32fns.c (x_set_menu_bar_lines): Remove unused variable `olines'.
13566 (w32_wnd_proc): Pass NULL to Windows API, not uninitialized buffer.
13567 (Fx_close_connection): Remove unused variable `i'.
13568
13569 * w32font.c (w32font_draw): Return number of glyphs.
13570 (w32font_open_internal): Remove unused variable `i'.
13571 (w32font_driver): Add missing initializer.
13572
13573 * w32menu.c (utf8to16): Remove unused variable `utf16'.
13574 (fill_in_menu): Remove unused variable `items_added'.
13575
13576 * w32term.c (last_mouse_press_frame): Remove static global variable.
13577 (w32_clip_to_row): Remove unused variable `f'.
13578 (x_delete_terminal): Remove unused variable `i'.
13579
13580 * w32uniscribe.c (uniscribe_shape): Remove unused variable `nclusters'.
13581 (NOTHING): Remove unused static global variable.
13582 (uniscribe_check_otf): Remove unused variable `table'.
13583 (uniscribe_font_driver): Add missing initializers.
13584
dee091a3
JD
135852011-03-23 Julien Danjou <julien@danjou.info>
13586
13587 * term.c (Fsuspend_tty, Fresume_tty):
13588 * minibuf.c (read_minibuf, run_exit_minibuf_hook):
13589 * window.c (temp_output_buffer_show):
13590 * insdel.c (signal_before_change):
13591 * frame.c (Fhandle_switch_frame):
13592 * fileio.c (Fdo_auto_save):
13593 * emacs.c (Fkill_emacs):
13594 * editfns.c (save_excursion_restore):
13595 * cmds.c (internal_self_insert):
13596 * callint.c (Fcall_interactively):
13597 * buffer.c (Fkill_all_local_variables):
13598 * keyboard.c (Fcommand_execute, Fsuspend_emacs, safe_run_hooks_1):
13599 Use Frun_hooks.
0f4a96b5 13600 (command_loop_1): Use Frun_hooks. Call safe_run_hooks
e9fce1ac 13601 unconditionally since it does the check itself.
dee091a3 13602
2c520ab5 136032011-03-23 Paul Eggert <eggert@cs.ucla.edu>
f0641eff 13604
c9c49752
PE
13605 Fix more problems found by GCC 4.5.2's static checks.
13606
8abc3f12
PE
13607 * coding.c (encode_coding_raw_text): Avoid unnecessary test
13608 the first time through the loop, since we know p0 < p1 then.
13609 This also avoids a gcc -Wstrict-overflow warning.
13610
a2d26660
PE
13611 * lisp.h (SAFE_ALLOCA, SAFE_ALLOCA_LISP): Avoid 'int' overflow
13612 leading to a memory leak, possible in functions like
13613 load_charset_map_from_file that can allocate an unbounded number
b12ef411 13614 of objects (Bug#8318).
a2d26660 13615
916c72e9
PE
13616 * xmenu.c (set_frame_menubar): Use EMACS_UINT, not int, for indexes
13617 that could (at least in theory) be that large.
13618
19ab8a18
PE
13619 * xdisp.c (message_log_check_duplicate): Return unsigned long, not int.
13620 This is less likely to overflow, and avoids undefined behavior if
13621 overflow does occur. All callers changed. Use strtoul to scan
13622 for the unsigned long integer.
b7cbbd6f
PE
13623 (pint2hrstr): Simplify and tune code slightly.
13624 This also avoids a (bogus) GCC warning with gcc -Wstrict-overflow.
19ab8a18 13625
f0641eff
PE
13626 * scroll.c (do_scrolling): Work around GCC bug 48228.
13627 See <http://gcc.gnu.org/bugzilla/show_bug.cgi?id=48228>.
13628
7f650bb9
PE
13629 * frame.c (Fmodify_frame_parameters): Simplify loop counter.
13630 This also avoids a warning with gcc -Wstrict-overflow.
39f5e519
PE
13631 (validate_x_resource_name): Simplify count usage.
13632 This also avoids a warning with gcc -Wstrict-overflow.
7f650bb9 13633
37dd57d1
PE
13634 * fileio.c (Fcopy_file): Report error if fchown or fchmod
13635 fail (Bug#8306).
81e56e61 13636
699979fc 13637 * emacs.c (Fdaemon_initialized): Do not ignore I/O errors (Bug#8303).
dc1ca6a8 13638
401bf9b4
PE
13639 * process.c (Fmake_network_process): Use socklen_t, not int,
13640 where POSIX says socklen_t is required in portable programs.
13641 This fixes a porting bug on hosts like 64-bit HP-UX, where
591b2973 13642 socklen_t is wider than int (Bug#8277).
401bf9b4
PE
13643 (Fmake_network_process, server_accept_connection):
13644 (wait_reading_process_output, read_process_output):
13645 Likewise.
13646
b93aacde
PE
13647 * process.c: Rename or move locals to avoid shadowing.
13648 (list_processes_1, Fmake_network_process):
13649 (read_process_output_error_handler, exec_sentinel_error_handler):
13650 Rename or move locals.
4dc343ee 13651 (Fmake_network_process): Define label "retry_connect" only if needed.
0da49335 13652 (Fnetwork_interface_info): Fix pointer signedness.
f990b4e5 13653 (process_send_signal): Add cast to avoid pointer signedness problem.
7b808126 13654 (FIRST_PROC_DESC, IF_NON_BLOCKING_CONNECT): Remove unused macros.
c939f91b 13655 (create_process): Use 'volatile' to avoid vfork clobbering (Bug#8298).
b93aacde 13656
af8a867c 13657 Make tparam.h and terminfo.c consistent.
44f230aa
SM
13658 * cm.c (tputs, tgoto, BC, UP): Remove extern decls.
13659 Include tparam.h instead, since it declares them.
af8a867c
PE
13660 * cm.h (PC): Remove extern decl; tparam.h now does this.
13661 * deps.mk (cm.o, terminfo.o): Depend on tparam.h.
13662 * terminfo.c: Include tparam.h, to check interfaces.
13663 (tparm): Make 1st arg a const pointer in decl. Put it at top level.
13664 (tparam): Adjust signature to match interface in tparam.h;
13665 this removes some undefined behavior. Check that outstring and len
13666 are zero, which they always are with Emacs.
13667 * tparam.h (PC, BC, UP): New extern decls.
13668
0248044d 13669 * xftfont.c (xftfont_shape): Now static, and defined only if needed.
001a7ab4 13670 (xftfont_open): Rename locals to avoid shadowing.
0248044d 13671
8ff096c1 13672 * ftfont.c (ftfont_resolve_generic_family): Fix pointer signedness.
a00924bb
PE
13673 (ftfont_otf_capability, ftfont_shape): Omit decls if not needed.
13674 (OTF_TAG_SYM): Omit macro if not needed.
e932860f 13675 (ftfont_list): Remove unused local.
49eaafba
PE
13676 (get_adstyle_property, ftfont_pattern_entity):
13677 (ftfont_lookup_cache, ftfont_open, ftfont_anchor_point):
13678 Rename locals to avoid shadowing.
8ff096c1 13679
e2be39f6
PE
13680 * xfont.c (xfont_list_family): Mark var as initialized.
13681
c9735e30
PE
13682 * xml.c (make_dom): Now static.
13683
8f5201ae
PE
13684 * composite.c (composition_compute_stop_pos): Rename local to
13685 avoid shadowing.
b246f932
PE
13686 (composition_reseat_it): Remove unused locals.
13687 (find_automatic_composition, composition_adjust_point): Likewise.
80e079b2 13688 (composition_update_it): Mark var as initialized.
11b61122
PE
13689 (find_automatic_composition): Mark vars as initialized,
13690 with a FIXME (Bug#8290).
8f5201ae 13691
760fbc2c
PE
13692 character.h: Rename locals to avoid shadowing.
13693 * character.h (PREV_CHAR_BOUNDARY, FETCH_STRING_CHAR_ADVANCE):
13694 (FETCH_STRING_CHAR_AS_MULTIBYTE_ADVANCE, FETCH_CHAR_ADVANCE):
13695 (FETCH_CHAR_ADVANCE_NO_CHECK, INC_POS, DEC_POS, BUF_INC_POS):
13696 (BUF_DEC_POS): Be more systematic about renaming local temporaries
13697 to avoid shadowing.
13698
ff08eb85
PE
13699 * textprop.c (property_change_between_p): Remove; unused.
13700
fc7bf025
PE
13701 * intervals.c (interval_start_pos): Now static.
13702
235d7abc
PE
13703 * intervals.h (CHECK_TOTAL_LENGTH): Avoid empty "else".
13704
44f230aa
SM
13705 * atimer.c (start_atimer, append_atimer_lists, set_alarm):
13706 Rename locals to avoid shadowing.
3e7d6594 13707
50060332
PE
13708 * sound.c (wav_play, au_play, Fplay_sound_internal):
13709 Fix pointer signedness.
d01f234b 13710 (alsa_choose_format): Remove unused local var.
c83b8872
PE
13711 (wav_play): Initialize a variable to 0, to prevent undefined
13712 behavior (Bug#8278).
50060332 13713
c4fc4e30
PE
13714 * region-cache.c (insert_cache_boundary): Redo var to avoid shadowing.
13715
918436ed
PE
13716 * region-cache.h (pp_cache): New decl, for gcc -Wmissing-prototypes.
13717
c939f91b
PE
13718 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork
13719 clobbering (Bug#8298).
b9c7f648
PE
13720 * sysdep.c (sys_subshell): Likewise.
13721 Previously, the sys_subshell 'volatile' was incorrectly IF_LINTted out.
7e9123a2 13722
6bd8c144
PE
13723 * lisp.h (child_setup): Now NO_RETURN unless DOS_NT.
13724 This should get cleaned up, so that child_setup has the
13725 same signature on all platforms.
13726
7710357c 13727 * callproc.c (call_process_cleanup): Now static.
cb1d0ef7 13728 (relocate_fd): Rename locals to avoid shadowing.
7710357c 13729
c59da222
CY
137302011-03-22 Chong Yidong <cyd@stupidchicken.com>
13731
13732 * xterm.c (x_clear_frame): Remove XClearWindow call. This appears
13733 not to be necessary, and produces flickering.
13734
66b87493
GM
137352011-03-20 Glenn Morris <rgm@gnu.org>
13736
13737 * config.in: Remove file.
13738
45b6f6d5
JB
137392011-03-20 Juanma Barranquero <lekktu@gmail.com>
13740
13741 * minibuf.c (Vcompleting_read_function): Don't declare, global variables
13742 are now in src/globals.h.
13743 (syms_of_minibuf): Remove spurious & from previous change.
13744
cd394be1 137452011-03-20 Leo Liu <sdl.web@gmail.com>
3ec03f7e
LL
13746
13747 * minibuf.c (completing-read-function): New variable.
13748 (completing-read-default): Rename from completing-read.
13749 (completing-read): Call completing-read-function.
13750
b14e3e21
CY
137512011-03-19 Juanma Barranquero <lekktu@gmail.com>
13752
13753 * xfaces.c (Fx_load_color_file):
13754 Read color file from absolute filename (bug#8250).
13755
f2b726e6
JB
137562011-03-19 Juanma Barranquero <lekktu@gmail.com>
13757
13758 * makefile.w32-in: Update dependencies.
13759
09f6ff02
EZ
137602011-03-17 Eli Zaretskii <eliz@gnu.org>
13761
13762 * makefile.w32-in ($(BLD)/unexw32.$(O)): Depend on $(SRC)/unexec.h.
13763
29a6015a
PE
137642011-03-17 Paul Eggert <eggert@cs.ucla.edu>
13765
a3a6c54e
PE
13766 Fix more problems found by GCC 4.5.2's static checks.
13767
b766f867
PE
13768 * process.c (make_serial_process_unwind, send_process_trap):
13769 (sigchld_handler): Now static.
13770
be02381c
PE
13771 * process.c (allocate_pty): Let PTY_ITERATION declare iteration vars.
13772 That way, the code declares only the vars that it needs.
13773 * s/aix4-2.h (PTY_ITERATION): Declare iteration vars.
13774 * s/cygwin.h (PTY_ITERATION): Likewise.
13775 * s/darwin.h (PTY_ITERATION): Likewise.
13776 * s/gnu-linux.h (PTY_ITERATION): Likewise.
13777
57048744
PE
13778 * s/irix6-5.h (PTY_OPEN): Declare stb, to loosen coupling.
13779 * process.c (allocate_pty): Don't declare stb unless it's needed.
13780
7914961c 13781 * bytecode.c (MAYBE_GC): Rewrite so as not to use empty "else".
615f2d59
PE
13782 (CONSTANTLIM): Remove; unused.
13783 (METER_CODE, Bscan_buffer, Bread_char, Bset_mark):
13784 Define only if needed.
7914961c 13785
b3967b18
PE
13786 * unexelf.c (unexec): Name an expression,
13787 to avoid gcc -Wbad-function-cast warning.
9ae71512
PE
13788 Use a different way to cause a compilation error if anyone uses
13789 n rather than nn, a way that does not involve shadowing.
73366a00 13790 (ELF_BSS_SECTION_NAME, OLD_PROGRAM_H): Remove; unused.
b3967b18 13791
29a6015a
PE
13792 * deps.mk (unexalpha.o): Remove; unused.
13793
43cfc33e 13794 New file unexec.h, the (simple) interface for unexec (Bug#8267).
7feda0d2 13795 * unexec.h: New file.
ce701a33
PE
13796 * deps.mk (emacs.o, unexaix.o, unexcw.o, unexcoff.o, unexelf.o):
13797 (unexhp9k800.o, unexmacosx.o, unexsol.o, unexw32.o):
13798 Depend on unexec.h.
13799 * emacs.c [!defined CANNOT_DUMP]: Include unexec.h.
13800 * unexaix.c, unexcoff.c, unexcw.c, unexelf.c, unexhp9k800.c:
13801 * unexmacosx.c, unexsol.c, unexw32.c: Include unexec.h.
381259ef 13802 Change as necessary to match prototype in unexec.h.
ce701a33 13803
01f44d5a
PE
13804 * syntax.c (Fforward_comment, scan_lists): Rename locals to avoid
13805 shadowing.
4f63c6bb 13806 (back_comment, skip_chars): Mark vars as initialized.
01f44d5a 13807
a6670b0b
PE
13808 * character.h (FETCH_STRING_CHAR_ADVANCE_NO_CHECK, BUF_INC_POS):
13809 Rename locals to avoid shadowing.
13810
cef2010d 13811 * lread.c (read1): Rewrite so as not to use empty "else".
0902fe45 13812 (Fload, readevalloop, read1): Rename locals to avoid shadowing.
cef2010d 13813
d4d7173a
PE
13814 * print.c (Fredirect_debugging_output): Fix pointer signedess.
13815
f08b802a
PE
13816 * lisp.h (debug_output_compilation_hack): Add decl here, to avoid
13817 warning when compiling print.c.
13818
3ddb0639
PE
13819 * font.c (font_unparse_fcname): Abort in an "impossible" situation
13820 instead of using an uninitialized var.
5ad03b97 13821 (font_sort_entities): Mark var as initialized.
3ddb0639 13822
170a2692
PE
13823 * character.h (FETCH_CHAR_ADVANCE): Rename locals to avoid shadowing.
13824
e663c700
PE
13825 * font.c (font_unparse_xlfd): Don't mix pointers to variables with
13826 pointers to constants.
89bc529a 13827 (font_parse_fcname): Remove unused vars.
7b81e2d0 13828 (font_delete_unmatched): Now static.
ea838e10 13829 (font_get_spec): Remove; unused.
13a547c6
PE
13830 (font_style_to_value, font_prop_validate_style, font_unparse_fcname):
13831 (font_update_drivers, Ffont_get_glyphs, font_add_log):
13832 Rename or move locals to avoid shadowing.
e663c700 13833
2a80c887 13834 * fns.c (require_nesting_list, require_unwind): Now static.
612f56df 13835 (Ffillarray): Rename locals to avoid shadowing.
2a80c887 13836
1384fa33 13837 * floatfns.c (domain_error2): Define only if needed.
a885e2ed 13838 (Ffrexp, Fldexp): Rename locals to avoid shadowing.
1384fa33 13839
8b2c52e9
PE
13840 * alloc.c (mark_backtrace): Move decl from here ...
13841 * lisp.h: ... to here, so that it can be checked.
13842
475545b5 13843 * eval.c (call_debugger, do_debug_on_call, grow_specpdl): Now static.
d28a2170 13844 (Fdefvar): Rewrite so as not to use empty "else".
cfcbfb1a
PE
13845 (lisp_indirect_variable): Name an expression,
13846 to avoid gcc -Wbad-function-cast warning.
1faed8ae 13847 (Fdefvar): Rename locals to avoid shadowing.
475545b5 13848
b1349114 13849 * callint.c (quotify_arg, quotify_args): Now static.
a3e8cbda 13850 (Fcall_interactively): Rename locals to avoid shadowing.
b0e80955 13851 Use const pointer when appropriate.
b1349114 13852
a2928364
PE
13853 * lisp.h (get_system_name, get_operating_system_release):
13854 Move decls here, to check interfaces.
13855 * process.c (get_operating_system_release): Move decl to lisp.h.
13856 * xrdb.c (get_system_name): Likewise.
63c5d10b
PE
13857 * editfns.c (init_editfns, Fuser_login_name, Fuser_uid):
13858 (Fuser_real_uid, Fuser_full_name): Remove unnecessary casts,
13859 some of which prompt warnings from gcc -Wbad-function-cast.
545b49b4
PE
13860 (Fformat_time_string, Fencode_time, Finsert_char):
13861 (Ftranslate_region_internal, Fformat):
13862 Rename or remove local vars to avoid shadowing.
9710023e 13863 (Ftranslate_region_internal): Mark var as initialized.
63c5d10b 13864
a415e694
PE
13865 * doc.c (Fdocumentation, Fsnarf_documentation): Move locals to
13866 avoid shadowing.
13867
8ef4622d
PE
13868 * lisp.h (eassert): Check that the argument compiles, even if
13869 ENABLE_CHECKING is not defined.
13870
946f9a5b
PE
13871 * data.c (Findirect_variable): Name an expression, to avoid
13872 gcc -Wbad-function-cast warning.
112396d6 13873 (default_value, arithcompare, arith_driver, arith_error): Now static.
b9b84fa9 13874 (store_symval_forwarding): Rename local to avoid shadowing.
44f230aa
SM
13875 (Fmake_variable_buffer_local, Fmake_local_variable):
13876 Mark variables as initialized.
52746918 13877 (do_blv_forwarding, do_symval_forwarding): Remove; unused.
946f9a5b 13878
e5aab7e7 13879 * alloc.c (check_cons_list): Do not define unless GC_CHECK_CONS_LIST.
ae35e756
PE
13880 (Fmake_vector, Fvector, Fmake_byte_code, Fgarbage_collect):
13881 Rename locals to avoid shadowing.
dff45157
PE
13882 (mark_stack): Move local variables into the #ifdef region where
13883 they're used.
7bc26fdb
PE
13884 (BLOCK_INPUT_ALLOC, UNBLOCK_INPUT_ALLOC): Define only if
13885 ! defined SYSTEM_MALLOC && ! defined SYNC_INPUT, as they are not
13886 needed otherwise.
13887 (CHECK_ALLOCATED): Define only if GC_CHECK_MARKED_OBJECTS.
13888 (GC_STRING_CHARS): Remove; not used.
d40d4be1 13889 (Fmemory_limit): Cast sbrk's returned value to char *.
ae35e756 13890
e5aab7e7
PE
13891 * lisp.h (check_cons_list): Declare if GC_CHECK_CONS_LIST; this
13892 avoids undefined behavior in theory.
13893
4da60324
PE
13894 * regex.c (IF_LINT): Add defn, for benefit of ../lib-src.
13895
88043301
PE
13896 Use functions, not macros, for up- and down-casing (Bug#8254).
13897 * buffer.h (DOWNCASE_TABLE, UPCASE_TABLE, DOWNCASE, UPPERCASEP):
13898 (NOCASEP, LOWERCASEP, UPCASE, UPCASE1): Remove. All callers changed
13899 to use the following functions instead of these macros.
13900 (downcase): Adjust to lack of DOWNCASE_TABLE. Return int, not
13901 EMACS_INT, since callers assume the returned value fits in int.
13902 (upcase1): Likewise, for UPCASE_TABLE.
13903 (uppercasep, lowercasep, upcase): New static inline functions.
0da09c43 13904 * editfns.c (Fchar_equal): Remove no-longer-needed workaround for
db69b0cd 13905 the race-condition problem in the old DOWNCASE.
88043301 13906
19ed5445
PE
13907 * regex.c (CHARSET_LOOKUP_RANGE_TABLE_RAW, POP_FAILURE_REG_OR_COUNT):
13908 Rename locals to avoid shadowing.
13909 (regex_compile, re_match_2_internal): Move locals to avoid shadowing.
abbd1bcf
PE
13910 (regex_compile, re_search_2, re_match_2_internal):
13911 Remove unused local vars.
952db0d7
PE
13912 (FREE_VAR): Rewrite so as not to use empty "else",
13913 which gcc can warn about.
da053e48 13914 (regex_compile, re_match_2_internal): Mark locals as initialized.
b313f9d8
PE
13915 (RETALLOC_IF): Define only if needed.
13916 (WORDCHAR_P): Likewise. This one is never needed, but is used
13917 only in a comment talking about a compiler bug, so put inside
13918 the #if 0 of that comment.
13919 (CHARSET_LOOKUP_BITMAP, FAIL_STACK_FULL, RESET_FAIL_STACK):
13920 (PUSH_FAILURE_ELT, BUF_PUSH_3, STOP_ADDR_VSTRING):
13921 Remove; unused.
19ed5445 13922
1f3561e4 13923 * search.c (boyer_moore): Rename locals to avoid shadowing.
76ef09b7
PE
13924 * character.h (FETCH_STRING_CHAR_AS_MULTIBYTE_ADVANCE):
13925 (PREV_CHAR_BOUNDARY): Likewise.
1f3561e4 13926
ded6f8f7
PE
13927 * search.c (simple_search): Remove unused var.
13928
dbd37a95
PE
13929 * dired.c (compile_pattern): Move decl from here ...
13930 * lisp.h: ... to here, so that it can be checked.
13931 (struct re_registers): New forward decl.
13932
7e47afad
PE
13933 * character.h (INC_POS, DEC_POS): Rename locals to avoid shadowing.
13934
85f24f61
PE
13935 * indent.c (MULTIBYTE_BYTES_WIDTH): New args bytes, width.
13936 All uses changed.
13937 (MULTIBYTE_BYTES_WIDTH, scan_for_column, compute_motion):
13938 Rename locals to avoid shadowing.
5671df8f 13939 (Fvertical_motion): Mark locals as initialized.
85f24f61 13940
181aa2be 13941 * casefiddle.c (casify_object, casify_region): Now static.
e45a141a 13942 (casify_region): Mark local as initialized.
181aa2be 13943
930d429c
PE
13944 * cmds.c (internal_self_insert): Rename local to avoid shadowing.
13945
7082eac6
PE
13946 * lisp.h (GCPRO2_VAR, GCPRO3_VAR, GCPRO4_VAR, GCPRO5_VAR, GCPRO6_VAR):
13947 New macros, so that the caller can use some names other than
13948 gcpro1, gcpro2, etc.
13949 (GCPRO2, GCPRO3, GCPRO4, GCPRO5, GCPRO6): Reimplement in terms
13950 of the new macros.
13951 (GCPRO1_VAR, UNGCPRO_VAR): Change the meaning of the second
13952 argument, for consistency with GCPRO2_VAR, etc: it is now the
13953 prefix of the variable, not the variable itself. All uses
13954 changed.
38b2c076
PE
13955 * dired.c (directory_files_internal, file_name_completion):
13956 Rename locals to avoid shadowing.
13957
15206ed9
PE
13958 Fix a race condition diagnosed by gcc -Wsequence-point (Bug#8254).
13959 An expression of the form (DOWNCASE (x) == DOWNCASE (y)), found in
13960 dired.c's scmp function, had undefined behavior.
13961 * lisp.h (DOWNCASE_TABLE, UPCASE_TABLE, DOWNCASE, UPPERCASEP):
13962 (NOCASEP, LOWERCASEP, UPCASE, UPCASE1): Move from here ...
13963 * buffer.h: ... to here, because these macros use current_buffer,
13964 and the new implementation with inline functions needs to have
13965 current_buffer in scope now, rather than later when the macros
13966 are used.
13967 (downcase, upcase1): New static inline functions.
13968 (DOWNCASE, UPCASE1): Reimplement using these functions.
13969 This avoids undefined behavior in expressions like
13970 DOWNCASE (x) == DOWNCASE (y), which previously suffered
13971 from race conditions in accessing the global variables
13972 case_temp1 and case_temp2.
13973 * casetab.c (case_temp1, case_temp2): Remove; no longer needed.
13974 * lisp.h (case_temp1, case_temp2): Remove their decls.
13975 * character.h (ASCII_CHAR_P): Move from here ...
13976 * lisp.h: ... to here, so that the inline functions mentioned
13977 above can use them.
13978
4a6bea26
PE
13979 * dired.c (directory_files_internal_unwind): Now static.
13980
f14b7e14
PE
13981 * fileio.c (file_name_as_directory, directory_file_name):
13982 (barf_or_query_if_file_exists, auto_save_error, auto_save_1):
13983 Now static.
2893f146
PE
13984 (file_name_as_directory): Use const pointers when appropriate.
13985 (Fexpand_file_name): Likewise. In particular, newdir might
13986 point at constant storage, so make it a const pointer.
fd4ead52 13987 (Fmake_directory_internal, Fread_file_name): Remove unused vars.
b14aac08
PE
13988 (Ffile_selinux_context, Fset_file_selinux_context): Fix pointer
13989 signedness issues.
f839df0c
PE
13990 (Fset_file_times, Finsert_file_contents, auto_save_error):
13991 Rename locals to avoid shadowing.
f14b7e14 13992
5716756e 13993 * minibuf.c (choose_minibuf_frame_1): Now static.
62137a95
PE
13994 (Ftry_completion, Fall_completions): Rename or remove locals
13995 to avoid shadowing.
5716756e 13996
b4c3046a
PE
13997 * marker.c (bytepos_to_charpos): Remove; unused.
13998
b45db522
PE
13999 * lisp.h (verify_bytepos, count_markers): New decls,
14000 so that gcc does not warn that these functions aren't declared.
14001
85876d07
PE
14002 * insdel.c (check_markers, make_gap_larger, make_gap_smaller):
14003 (reset_var_on_error, Fcombine_after_change_execute_1): Now static.
f0cb4a60 14004 (CHECK_MARKERS): Redo to avoid gcc -Wempty-body diagnostic.
40ef059e 14005 (copy_text): Remove unused local var.
85876d07 14006
03d78a21 14007 * filelock.c (within_one_second): Now static.
b3dd38ab 14008 (lock_file_1): Rename local to avoid shadowing.
03d78a21 14009
5df8f01b
PE
14010 * buffer.c (fix_overlays_before): Mark locals as initialized.
14011 (fix_start_end_in_overlays): Likewise. This function should be
14012 simplified by using pointers-to-pointers, but that's a different
14013 matter.
b1d876f1 14014 (switch_to_buffer_1): Now static.
8f54f30a
PE
14015 (Fkill_buffer, record_buffer, Fbury_buffer, Fset_buffer_multibyte):
14016 (report_overlay_modification): Rename locals to avoid shadowing.
c3bd59b5 14017
a70072c9 14018 * sysdep.c (system_process_attributes): Rename vars to avoid shadowing.
fbd02d7b 14019 Fix pointer signedness issue.
edced198
PE
14020 (sys_subshell): Mark local as volatile if checking for lint,
14021 to suppress a gcc -Wclobbered warning that does not seem to be right.
15dfd3d9 14022 (MAXPATHLEN): Define only if needed.
a70072c9 14023
a0977c44
PE
14024 * process.c (serial_open, serial_configure): Move decls from here ...
14025 * systty.h: ... to here, so that they can be checked.
14026
a884fdcc
PE
14027 * fns.c (get_random, seed_random): Move extern decls from here ...
14028 * lisp.h: ... to here, so that they can be checked.
14029
604efe86 14030 * sysdep.c (reset_io): Now static.
b8950c94 14031 (wait_for_termination_signal): Remove; unused.
604efe86 14032
38fc62d9
PE
14033 * keymap.c (keymap_parent, keymap_memberp, map_keymap_internal):
14034 (copy_keymap_item, append_key, push_text_char_description):
14035 Now static.
1004a21a 14036 (Fwhere_is_internal): Don't test CONSP (sequences) unnecessarily.
dbbb8427 14037 (DENSE_TABLE_SIZE): Remove; unused.
c1141155
PE
14038 (get_keymap, access_keymap, Fdefine_key, Fwhere_is_internal):
14039 (describe_map_tree):
14040 Rename locals to avoid shadowing.
38fc62d9 14041
2f2650da
PE
14042 * keyboard.c: Declare functions static if they are not used elsewhere.
14043 (echo_char, echo_dash, cmd_error, top_level_2):
14044 (poll_for_input, handle_async_input): Now static.
69a058fa
PE
14045 (read_char, kbd_buffer_get_event, make_lispy_position):
14046 (make_lispy_event, make_lispy_movement, apply_modifiers):
14047 (decode_keyboard_code, tty_read_avail_input, menu_bar_items):
14048 (parse_tool_bar_item, read_key_sequence, Fread_key_sequence):
14049 (Fread_key_sequence_vector): Rename locals to avoid shadowing.
c8a06054 14050 (read_key_sequence, read_char): Mark locals as initialized.
3ac94672 14051 (Fexit_recursive_edit, Fabort_recursive_edit): Mark with NO_RETURN.
2f2650da 14052
a053e86c 14053 * keyboard.h (make_ctrl_char): New decl.
da2f2dd9
PE
14054 (mark_kboards): Move decl here ...
14055 * alloc.c (mark_kboards): ... from here.
a053e86c 14056
4752793e
PE
14057 * lisp.h (force_auto_save_soon): New decl.
14058
74f10ca7 14059 * emacs.c (init_cmdargs): Rename local to avoid shadowing.
244fc23d
PE
14060 (DEFINE_DUMMY_FUNCTION): New macro.
14061 (__do_global_ctors, __do_global_ctors_aux, __do_global_dtors, __main):
14062 Use it.
c03cd23f
PE
14063 (main): Add casts to avoid warnings
14064 if GCC considers string literals to be constants.
74f10ca7 14065
022e70d4
PE
14066 * lisp.h (fatal_error_signal): Add decl, since it's exported.
14067
59d6fe83
PE
14068 * dbusbind.c: Pointer signedness fixes.
14069 (xd_signature, xd_append_arg, xd_initialize):
14070 (Fdbus_call_method, Fdbus_call_method_asynchronously):
14071 (Fdbus_method_return_internal, Fdbus_method_error_internal):
14072 (Fdbus_send_signal, xd_read_message_1, Fdbus_register_service):
14073 (Fdbus_register_signal): Use SSDATA when the context wants char *.
14074
78320123
PE
14075 * dbusbind.c (Fdbus_init_bus): Add cast to avoid warning
14076 if GCC considers string literals to be constants.
49cebcca 14077 (Fdbus_register_service, Fdbus_register_method): Remove unused vars.
78320123 14078
35ac2a97
SM
140792011-03-16 Stefan Monnier <monnier@iro.umontreal.ca>
14080
fb103ca9
SM
14081 * print.c (PRINT_CIRCLE_CANDIDATE_P): New macro.
14082 (print_preprocess, print_object): New macro to fix last change.
14083
35ac2a97
SM
14084 * print.c (print_preprocess): Don't forget font objects.
14085
62973b41
JB
140862011-03-16 Juanma Barranquero <lekktu@gmail.com>
14087
14088 * emacs.c (USAGE3): Doc fixes.
14089
0e48bb22
AS
140902011-03-15 Andreas Schwab <schwab@linux-m68k.org>
14091
14092 * coding.c (detect_coding_iso_2022): Reorganize code to clarify
14093 structure.
14094
7684e57b
JB
140952011-03-14 Juanma Barranquero <lekktu@gmail.com>
14096
14097 * lisp.h (VWindow_system, Qfile_name_history):
14098 * keyboard.h (lispy_function_keys) [WINDOWSNT]:
14099 * w32term.h (w32_system_caret_hwnd, w32_system_caret_height)
14100 (w32_system_caret_x, w32_system_caret_y): Declare extern.
14101
14102 * w32select.c: Don't #include "keyboard.h".
c96bbc66 14103 (run_protected): Add extern declaration for waiting_for_input.
7684e57b
JB
14104
14105 * w32.c (Qlocal, noninteractive1, inhibit_window_system):
14106 * w32console.c (detect_input_pending, read_input_pending)
14107 (encode_terminal_code):
14108 * w32fns.c (quit_char, lispy_function_keys, Qtooltip)
14109 (w32_system_caret_hwnd, w32_system_caret_height, w32_system_caret_x)
14110 (w32_system_caret_y, Qfile_name_history):
14111 * w32font.c (w32font_driver, QCantialias, QCotf, QClang):
14112 * w32inevt.c (reinvoke_input_signal, lispy_function_keys):
14113 * w32menu.c (Qmenu_bar, QCtoggle, QCradio, Qoverriding_local_map)
14114 (Qoverriding_terminal_local_map, Qmenu_bar_update_hook):
14115 * w32proc.c (Qlocal, report_file_error):
14116 * w32term.c (Vwindow_system, updating_frame):
14117 * w32uniscribe.c (initialized, uniscribe_font_driver):
14118 Remove unneeded extern declarations.
14119
2aa46d6c
CY
141202011-03-14 Chong Yidong <cyd@stupidchicken.com>
14121
c96bbc66 14122 * buffer.c (Fmake_indirect_buffer): Fix incorrect assertions.
2aa46d6c 14123
cffc6f3b
CY
141242011-03-13 Chong Yidong <cyd@stupidchicken.com>
14125
14126 * buffer.h (BUF_BEGV, BUF_BEGV_BYTE, BUF_ZV, BUF_ZV_BYTE, BUF_PT)
14127 (BUF_PT_BYTE): Rewrite to handle indirect buffers (Bug#8219).
14128 These macros can no longer be used for assignment.
14129
44f230aa
SM
14130 * buffer.c (Fget_buffer_create, Fmake_indirect_buffer):
14131 Assign struct members directly, instead of using BUF_BEGV etc.
cffc6f3b
CY
14132 (record_buffer_markers, fetch_buffer_markers): New functions for
14133 recording and fetching special buffer markers.
14134 (set_buffer_internal_1, set_buffer_temp): Use them.
14135
14136 * lread.c (unreadchar): Use SET_BUF_PT_BOTH.
14137
14138 * insdel.c (adjust_point): Use SET_BUF_PT_BOTH.
14139
14140 * intervals.c (temp_set_point_both): Use SET_BUF_PT_BOTH.
14141 (get_local_map): Use SET_BUF_BEGV_BOTH and SET_BUF_ZV_BOTH.
14142
14143 * xdisp.c (hscroll_window_tree):
14144 (reconsider_clip_changes): Use PT instead of BUF_PT.
14145
d251f04b
EZ
141462011-03-13 Eli Zaretskii <eliz@gnu.org>
14147
14148 * makefile.w32-in ($(BLD)/editfns.$(O)): Depend on
14149 $(EMACS_ROOT)/lib/intprops.h.
14150
f0c77cd1
PE
141512011-03-13 Paul Eggert <eggert@cs.ucla.edu>
14152
3eca4629
PE
14153 Fix more problems found by GCC 4.5.2's static checks.
14154
7c86ee98
PE
14155 * gtkutil.c (xg_get_pixbuf_from_pixmap): Add cast from char *
14156 to unsigned char * to avoid compiler diagnostic.
b0afc268
PE
14157 (xg_free_frame_widgets): Make it clear that a local variable is
14158 needed only if USE_GTK_TOOLTIP.
01e0b5ad
PE
14159 (gdk_window_get_screen): Make it clear that this macro is needed
14160 only if USE_GTK_TOOLTIP.
1e5524e7
PE
14161 (int_gtk_range_get_value): New function, which avoids a diagnostic
14162 from gcc -Wbad-function-cast.
14163 (xg_set_toolkit_scroll_bar_thumb): Use it.
14164 (xg_tool_bar_callback, xg_tool_item_stale_p): Rewrite to avoid
14165 diagnostic from gcc -Wbad-function-cast.
65dc836c
PE
14166 (get_utf8_string, xg_get_file_with_chooser):
14167 Rename locals to avoid shadowing.
14168 (create_dialog): Move locals to avoid shadowing.
7c86ee98 14169
41729b81
PE
14170 * xgselect.c (xg_select): Remove unused var.
14171
f0c77cd1
PE
14172 * image.c (four_corners_best): Mark locals as initialized.
14173 (gif_load): Initialize transparent_p to zero (Bug#8238).
14174 Mark another local as initialized.
ec6cf4c6 14175 (my_png_error, my_error_exit): Mark with NO_RETURN.
f0c77cd1 14176
ce0ad53d 14177 * image.c (clear_image_cache): Now static.
d5d5a617 14178 (DIM, HAVE_STDLIB_H_1): Remove unused macros.
e22cffbc 14179 (xpm_load): Redo to avoid "discards qualifiers" gcc warning.
77a765fd
PE
14180 (x_edge_detection): Remove unnecessary cast that
14181 gcc -Wbad-function-cast diagnoses.
2037898d 14182 (gif_load): Fix pointer signedness.
6ae141d6
PE
14183 (clear_image_cache, xbm_read_bitmap_data, x_detect_edges):
14184 (jpeg_load, gif_load): Rename locals to avoid shadowing.
ce0ad53d 14185
33383987 141862011-03-12 Paul Eggert <eggert@cs.ucla.edu>
3eca4629 14187
d32df629
PE
14188 Improve quality of tests for time stamp overflow.
14189 For example, without this patch (encode-time 0 0 0 1 1
14190 1152921504606846976) returns the obviously-bogus value (-948597
14191 62170) on my RHEL 5.5 x86-64 host. With the patch, it correctly
14192 reports time overflow. See
14193 <http://lists.gnu.org/archive/html/emacs-devel/2011-03/msg00470.html>.
b8d9bd41
PE
14194 * deps.mk (editfns.o): Depend on ../lib/intprops.h.
14195 * editfns.c: Include limits.h and intprops.h.
14196 (TIME_T_MIN, TIME_T_MAX): New macros.
14197 (time_overflow): Move earlier, to before first use.
14198 (hi_time, lo_time): New functions, for an accurate test for
14199 out-of-range times.
14200 (Fcurrent_time, Fget_internal_run_time, make_time): Use them.
14201 (Fget_internal_run_time): Don't assume time_t fits in int.
14202 (make_time): Use list2 instead of Fcons twice.
14203 (Fdecode_time): More accurate test for out-of-range times.
14204 (check_tm_member): New function.
14205 (Fencode_time): Use it, to test for out-of-range times.
d32df629
PE
14206 (lisp_time_argument): Don't rely on undefined left-shift and
14207 right-shift behavior when checking for time stamp overflow.
8be6f318 14208
fe31d94c
PE
14209 * editfns.c (time_overflow): New function, refactoring common code.
14210 (Fformat_time_string, Fdecode_time, Fencode_time):
14211 (Fcurrent_time_string): Use it.
14212
8be6f318
PE
14213 Move 'make_time' to be next to its inverse 'lisp_time_argument'.
14214 * dired.c (make_time): Move to ...
14215 * editfns.c (make_time): ... here.
14216 * systime.h: Note the move.
14217
09d9db2c 142182011-03-12 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
c47cbdfd 14219
126bc0dc
YM
14220 * fringe.c (update_window_fringes): Remove unused variables.
14221
c47cbdfd
YM
14222 * unexmacosx.c (copy_data_segment): Also copy __got section.
14223 (Bug#8223)
14224
7ac80be9
EZ
142252011-03-12 Eli Zaretskii <eliz@gnu.org>
14226
c96bbc66 14227 * termcap.c [MSDOS]: Include "msdos.h".
058e5dad
EZ
14228 (find_capability, tgetnum, tgetflag, tgetstr, tputs, tgetent):
14229 Constify `char *' arguments and their references according to
14230 prototypes in tparam.h.
14231
ecb0f94d 14232 * deps.mk (termcap.o): Depend on tparam.h and msdos.h.
058e5dad 14233
7ac80be9
EZ
14234 * msdos.c (XMenuAddPane): 3rd argument is `const char *' now.
14235 Adapt all references accordingly.
14236
14237 * msdos.h (XMenuAddPane): 3rd argument is `const char *' now.
14238
ef1fd07e
TT
142392011-03-11 Tom Tromey <tromey@redhat.com>
14240
14241 * buffer.c (syms_of_buffer): Remove obsolete comment.
14242
7ef4b50c
EZ
142432011-03-11 Eli Zaretskii <eliz@gnu.org>
14244
14245 * termhooks.h (encode_terminal_code): Declare prototype.
14246
14247 * msdos.c (encode_terminal_code): Don't declare prototype.
14248
14249 * term.c (encode_terminal_code): Now external again, used by
14250 w32console.c and msdos.c.
14251
44f230aa
SM
14252 * makefile.w32-in ($(BLD)/term.$(O), ($(BLD)/tparam.$(O)):
14253 Depend on $(SRC)/tparam.h, see 2011-03-11T07:24:21Z!eggert@cs.ucla.edu.
7ef4b50c 14254
4b1ec863 142552011-03-11 Paul Eggert <eggert@cs.ucla.edu>
f78faa98 14256
1714f52b 14257 Fix some minor problems found by GCC 4.5.2's static checks.
83316bf4 14258
4b1ec863
PE
14259 * fringe.c (update_window_fringes): Mark locals as initialized
14260 (Bug#8227).
14261 (destroy_fringe_bitmap, init_fringe_bitmap): Now static.
bf60f616 14262
524c7aa6
PE
14263 * alloc.c (mark_fringe_data): Move decl from here ...
14264 * lisp.h (mark_fringe_data) [HAVE_WINDOW_SYSTEM]: ... to here,
14265 to check its interface.
14266 (init_fringe_once): Do not declare unless HAVE_WINDOW_SYSTEM.
14267
a5c0af81 14268 * fontset.c (free_realized_fontset): Now static.
7519b8cd 14269 (Fset_fontset_font): Rename local to avoid shadowing.
cc6e5db1 14270 (fontset_font): Mark local as initialized.
a9a06e0b 14271 (FONTSET_SPEC, FONTSET_REPERTORY, RFONT_DEF_REPERTORY): Remove; unused.
a5c0af81 14272
b4716021
PE
14273 * xrdb.c: Include "xterm.h", to check x_load_resources's interface.
14274
811e9bac 14275 * xselect.c (x_disown_buffer_selections): Remove; not used.
7b83e2f1 14276 (TRACE3) [!defined TRACE_SELECTION]: Remove; not used.
aa0daa9f
PE
14277 (x_own_selection, Fx_disown_selection_internal): Rename locals
14278 to avoid shadowing.
14279 (x_handle_dnd_message): Remove local to avoid shadowing.
811e9bac 14280
7e3ab302
PE
14281 * lisp.h (GCPRO1_VAR, UNGCPRO_VAR): New macros,
14282 so that the caller can use some name other than gcpro1.
14283 (GCPRO1, UNGCPRO): Reimplement in terms of the new macros.
58d2d479
PE
14284 * xfns.c (Fx_create_frame, x_create_tip_frame, Fx_show_tip):
14285 (Fx_backspace_delete_keys_p):
14286 Use them to avoid shadowing, and rename vars to avoid shadowing.
14287 (x_decode_color, x_set_name, x_window): Now static.
6b437900 14288 (Fx_create_frame): Add braces to silence GCC warning.
c0951e53 14289 (Fx_file_dialog, Fx_select_font): Fix pointer signedness.
06b0c8a0
PE
14290 (x_real_positions, xg_set_icon_from_xpm_data, x_create_tip_frame):
14291 Remove unused locals.
7e3ab302
PE
14292 (Fx_create_frame, x_create_tip_frame, Fx_show_tip):
14293 (Fx_backspace_delete_keys_p): Rename locals to avoid shadowing.
14294 Some of these renamings use the new GCPRO1_VAR and UNGCPRO_VAR
14295 macros.
f78faa98 14296
e2b13473
PE
14297 * xterm.h (x_mouse_leave): New decl.
14298
77f23912
PE
14299 * xterm.c (x_copy_dpy_color, x_focus_on_frame, x_unfocus_frame):
14300 Remove unused functions.
cdf4ba58
PE
14301 (x_shift_glyphs_for_insert, XTflash, XTring_bell):
14302 (x_calc_absolute_position): Now static.
7411c686 14303 (XTread_socket): Don't define label "out" unless it's used.
2b07bcff 14304 Don't declare local "event" unless it's used.
ed7bf3a5
PE
14305 (x_iconify_frame, x_free_frame_resources): Don't declare locals
14306 unless they are used.
38d0b34a
PE
14307 (XEMBED_VERSION, xembed_set_info): Don't define unless needed.
14308 (x_fatal_error_signal): Remove; not used.
a6067996
PE
14309 (x_draw_image_foreground, redo_mouse_highlight, XTmouse_position):
14310 (x_scroll_bar_report_motion, handle_one_xevent, x_draw_bar_cursor):
14311 (x_error_catcher, x_connection_closed, x_error_handler):
14312 (x_error_quitter, xembed_send_message, x_iconify_frame):
14313 (my_log_handler): Rename locals to avoid shadowing.
28f1c698 14314 (x_delete_glyphs, x_ins_del_lines): Mark with NO_RETURN.
2a8fade0 14315 (x_connection_closed): Tell GCC not to suggest NO_RETURN.
77f23912 14316
44f230aa
SM
14317 * xfaces.c (clear_face_cache, Fx_list_fonts, Fface_font):
14318 Rename or move locals to avoid shadowing.
6b463e58 14319 (tty_defined_color, merge_face_heights): Now static.
5967d051 14320 (free_realized_faces_for_fontset): Remove; not used.
1e9966ea
PE
14321 (Fx_list_fonts): Mark variable that gcc -Wuninitialized
14322 does not deduce is never used uninitialized.
73719eba
PE
14323 (STRDUPA, LSTRDUPA, FONT_POINT_SIZE_QUANTUM): Remove; not used.
14324 (LFACEP): Define only if XASSERTS, as it's not needed otherwise.
071048a3 14325
426994c3 14326 * terminal.c (store_terminal_param): Now static.
5489860b 14327
032f1620 14328 * xmenu.c (menu_highlight_callback): Now static.
9d66f88e 14329 (set_frame_menubar): Remove unused local.
d4323972 14330 (xmenu_show): Rename parameter to avoid shadowing.
6d1f7fee
PE
14331 (xmenu_show, xdialog_show, xmenu_show): Make local pointers "const"
14332 since they might point to immutable storage.
281585b0
PE
14333 (next_menubar_widget_id): Declare only if USE_X_TOOLKIT,
14334 since it's unused otherwise.
032f1620 14335
367c19e5 14336 * xdisp.c (produce_glyphless_glyph): Initialize lower_xoff.
53df7c11 14337 Add a FIXME, since the code still doesn't look right. (Bug#8215)
9f36b9fd
PE
14338 (Fcurrent_bidi_paragraph_direction): Simplify slightly; this
14339 avoids a gcc -Wuninitialized diagnostic.
0e086e8f 14340 (display_line, BUILD_COMPOSITE_GLYPH_STRING, draw_glyphs):
44a3a108
PE
14341 (note_mouse_highlight): Mark variables that gcc -Wuninitialized
14342 does not deduce are never used uninitialized.
70739cbe 14343
07b48fa9
PE
14344 * lisp.h (IF_LINT): New macro, copied from ../lib-src/emacsclient.c.
14345
8868a238 14346 * xdisp.c (redisplay_window): Rename local to avoid shadowing.
4554d213
PE
14347 * window.c (window_loop, size_window):
14348 (run_window_configuration_change_hook, enlarge_window): Likewise.
8868a238 14349
7e5cf297 14350 * window.c (display_buffer): Now static.
d6550a9f
PE
14351 (size_window): Mark variables that gcc -Wuninitialized
14352 does not deduce are never used uninitialized.
a586633d
PE
14353 * window.h (check_all_windows): New decl, to forestall
14354 gcc -Wmissing-prototypes diagnostic.
5b555da1 14355 * dispextern.h (bidi_dump_cached_states): Likewise.
7e5cf297 14356
f6095868
PE
14357 * charset.h (CHECK_CHARSET_GET_CHARSET): Rename locals to avoid
14358 shadowing.
14359 * charset.c (map_charset_for_dump, Fchar_charset): Likewise.
726929c4
PE
14360 Include <limits.h>.
14361 (Fsort_charsets): Redo min/max calculation to shorten the code a bit
14362 and to avoid gcc -Wuninitialized warning.
89ef49df
PE
14363 (load_charset_map): Mark variables that gcc -Wuninitialized
14364 does not deduce are never used uninitialized.
53df7c11 14365 (load_charset): Abort instead of using uninitialized var (Bug#8229).
f6095868 14366
f38b440c
PE
14367 * coding.c (coding_set_source, coding_set_destination):
14368 Use "else { /* comment */ }" rather than "else /* comment */;"
14369 for clarity, and to avoid gcc -Wempty-body warning.
2735d060
PE
14370 (Fdefine_coding_system_internal): Don't redeclare 'i' inside
14371 a block, when the outer 'i' will do.
14372 (decode_coding_utf_8, decode_coding_utf_16, detect_coding_emacs_mule):
14373 (emacs_mule_char, decode_coding_emacs_mule, detect_coding_iso_2022):
14374 (decode_coding_iso_2022, decode_coding_sjis, decode_coding_big5):
14375 (decode_coding_raw_text, decode_coding_charset, get_translation_table):
14376 (Fdecode_sjis_char, Fdefine_coding_system_internal):
14377 Rename locals to avoid shadowing.
14378 * character.h (FETCH_STRING_CHAR_ADVANCE): Likewise.
e2f1bab9
PE
14379 * coding.c (emacs_mule_char, encode_invocation_designation):
14380 Now static, since they're not used elsewhere.
413bb2db 14381 (decode_coding_iso_2022): Add "default: abort ();" as a safety check.
c4a63b12 14382 (decode_coding_object, encode_coding_object, detect_coding_system):
ee05f961
PE
14383 (decode_coding_emacs_mule): Mark variables that gcc
14384 -Wuninitialized does not deduce are never used uninitialized.
160b01f6
PE
14385 (detect_coding_iso_2022): Initialize a local variable that might
14386 be used uninitialized. Leave a FIXME because it's not clear that
53df7c11 14387 this initialization is needed. (Bug#8211)
5f58e762
PE
14388 (ISO_CODE_LF, ISO_CODE_CR, CODING_ISO_FLAG_EUC_TW_SHIFT):
14389 (ONE_MORE_BYTE_NO_CHECK, UTF_BOM, UTF_16_INVALID_P):
14390 (SHIFT_OUT_OK, ENCODE_CONTROL_SEQUENCE_INTRODUCER):
14391 (ENCODE_DIRECTION_R2L, ENCODE_DIRECTION_L2R):
14392 Remove unused macros.
f38b440c 14393
232b38b9 14394 * category.c (hash_get_category_set): Remove unused local var.
9f3b5e69 14395 (copy_category_table): Now static, since it's not used elsewhere.
d0891610 14396 * character.c (string_count_byte8): Likewise.
232b38b9 14397
fb90da1b
PE
14398 * ccl.c (CCL_WRITE_STRING, CCL_ENCODE_CHAR, Fccl_execute_on_string):
14399 (Fregister_code_conversion_map): Rename locals to avoid shadowing.
14400
fb93dbc2
PE
14401 * chartab.c (copy_sub_char_table): Now static, since it's not used
14402 elsewhere.
5c156ace
PE
14403 (sub_char_table_ref_and_range, char_table_ref_and_range):
14404 Rename locals to avoid shadowing.
bbcd0949 14405 (ASET_RANGE, GET_SUB_CHAR_TABLE): Remove unused macros.
fb93dbc2 14406
7d3b3862 14407 * bidi.c (bidi_check_type): Now static, since it's not used elsewhere.
630d6892 14408 (BIDI_BOB): Remove unused macro.
7d3b3862 14409
6be7d3da
PE
14410 * cm.c (cmgoto): Mark variables that gcc -Wuninitialized does not
14411 deduce are never used uninitialized.
c2ed9c8b 14412 * term.c (encode_terminal_code): Likewise.
6be7d3da 14413
75f8807f 14414 * term.c (encode_terminal_code): Now static. Remove unused local.
72abad34 14415
50938595
PE
14416 * tparam.h: New file.
14417 * term.c, tparam.h: Include it.
14418 * deps.mk (term.o, tparam.o): Depend on tparam.h.
14419 * term.c (tputs, tgetent, tgetflag, tgetnum, tparam, tgetstr):
14420 Move these decls to tparam.h, and make them agree with what
14421 is actually in tparam.c. The previous trick of using incompatible
14422 decls in different modules does not conform to the C standard.
14423 All callers of tparam changed to use tparam's actual API.
14424 * tparam.c (tparam1, tparam, tgoto):
14425 Use const pointers where appropriate.
14426
fbceeba2
PE
14427 * cm.c (calccost, cmgoto): Use const pointers where appropriate.
14428 * cm.h (struct cm): Likewise.
14429 * dispextern.h (do_line_insertion_deletion_costs): Likewise.
14430 * scroll.c (ins_del_costs, do_line_insertion_deletion_costs): Likewise.
14431 * term.c (tty_ins_del_lines, calculate_costs, struct fkey_table):
14432 (term_get_fkeys_1, append_glyphless_glyph, produce_glyphless_glyph):
14433 (turn_on_face, init_tty): Likewise.
14434 * termchar.h (struct tty_display_info): Likewise.
fbceeba2 14435
7f3f1250
PE
14436 * term.c (term_mouse_position): Rename local to avoid shadowing.
14437
e6ca6543
PE
14438 * alloc.c (mark_ttys): Move decl from here ...
14439 * lisp.h (mark_ttys): ... to here, so that it's checked against defn.
14440
c40f8d15
AS
144412011-03-11 Andreas Schwab <schwab@linux-m68k.org>
14442
14443 * .gdbinit (pwinx, xbuffer): Fix access to buffer name.
14444
cfe0661d
JB
144452011-03-09 Juanma Barranquero <lekktu@gmail.com>
14446
14447 * search.c (compile_pattern_1): Remove argument regp, unused since
14448 revid:rms@gnu.org-19941211082627-3x1g1wyqkjmwloig.
14449 (compile_pattern): Don't pass it.
14450
0afb4571
J
144512011-03-08 Jan Djärv <jan.h.d@swipnet.se>
14452
14453 * xterm.h (DEFAULT_GDK_DISPLAY): New define.
14454 (GDK_WINDOW_XID, gtk_widget_get_preferred_size): New defines
14455 for ! HAVE_GTK3.
14456 (GTK_WIDGET_TO_X_WIN): Use GDK_WINDOW_XID.
14457
14458 * xmenu.c (menu_position_func): Call gtk_widget_get_preferred_size.
14459
14460 * gtkutil.c: Include gtkx.h if HAVE_GTK3. If ! HAVE_GTK3, define
14461 gdk_window_get_screen, gdk_window_get_geometry,
14462 gdk_x11_window_lookup_for_display and GDK_KEY_g.
14463 (xg_set_screen): Use DEFAULT_GDK_DISPLAY.
14464 (xg_get_pixbuf_from_pixmap): New function.
14465 (xg_get_pixbuf_from_pix_and_mask): Change parameters from GdkPixmap
14466 to Pixmap, take frame as parameter, remove GdkColormap parameter.
14467 Call xg_get_pixbuf_from_pixmap instead of
14468 gdk_pixbuf_get_from_drawable.
14469 (xg_get_image_for_pixmap): Do not make GdkPixmaps, call
14470 xg_get_pixbuf_from_pix_and_mask with Pixmap parameters instead.
14471 (xg_check_special_colors): Use GtkStyleContext and its functions
14472 for HAVE_GTK3.
14473 (xg_prepare_tooltip, xg_hide_tooltip): Call gdk_window_get_screen.
14474 (xg_prepare_tooltip, create_dialog, menubar_map_cb)
14475 (xg_update_frame_menubar, xg_tool_bar_detach_callback)
44f230aa
SM
14476 (xg_tool_bar_attach_callback, xg_update_tool_bar_sizes):
14477 Call gtk_widget_get_preferred_size.
0afb4571
J
14478 (xg_frame_resized): gdk_window_get_geometry only takes 5
14479 parameters.
44f230aa
SM
14480 (xg_win_to_widget, xg_event_is_for_menubar):
14481 Call gdk_x11_window_lookup_for_display.
0afb4571
J
14482 (xg_set_widget_bg): New function.
14483 (delete_cb): New function.
895009e1 14484 (xg_create_frame_widgets): Connect delete-event to delete_cb.
5c32d3f2 14485 Call xg_set_widget_bg. Only set background pixmap for ! HAVE_GTK3
0afb4571
J
14486 (xg_set_background_color): Call xg_set_widget_bg.
14487 (xg_set_frame_icon): Call xg_get_pixbuf_from_pix_and_mask.
14488 (xg_create_scroll_bar): vadj is a GtkAdjustment for HAVE_GTK3.
14489 Only call gtk_range_set_update_policy if ! HAVE_GTK3.
14490 (xg_make_tool_item): Only connect xg_tool_bar_item_expose_callback
14491 if ! HAVE_GTK3.
14492 (update_frame_tool_bar): Call gtk_widget_hide.
14493 (xg_initialize): Use GDK_KEY_g.
14494
14495 * xsmfns.c (gdk_set_sm_client_id): Define to gdk_set_sm_client_id
14496 if ! HAVE_GTK3
14497 (x_session_initialize): Call gdk_x11_set_sm_client_id.
14498
14499 * xterm.c (XFillRectangle): Use cairo routines for HAVE_GTK3.
14500 (x_term_init): Disable Xinput(2) with GDK_CORE_DEVICE_EVENTS.
14501 Load ~/emacs.d/gtkrc only for ! HAVE_GTK3.
14502
1c2cc4ef
JB
145032011-03-08 Juanma Barranquero <lekktu@gmail.com>
14504
14505 * w32xfns.c (select_palette): Check success of RealizePalette against
14506 GDI_ERROR, not zero.
14507
33383987 14508See ChangeLog.11 for earlier changes.
aac0c6e3
MR
14509
14510;; Local Variables:
14511;; coding: utf-8
aac0c6e3
MR
14512;; End:
14513
2f097256 14514 Copyright (C) 2011-2012 Free Software Foundation, Inc.
aac0c6e3
MR
14515
14516 This file is part of GNU Emacs.
14517
14518 GNU Emacs is free software: you can redistribute it and/or modify
14519 it under the terms of the GNU General Public License as published by
14520 the Free Software Foundation, either version 3 of the License, or
14521 (at your option) any later version.
14522
14523 GNU Emacs is distributed in the hope that it will be useful,
14524 but WITHOUT ANY WARRANTY; without even the implied warranty of
14525 MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
14526 GNU General Public License for more details.
14527
14528 You should have received a copy of the GNU General Public License
14529 along with GNU Emacs. If not, see <http://www.gnu.org/licenses/>.