Fix parallel bootstrap on MS-Windows in lib/ and lisp/.
[bpt/emacs.git] / src / ChangeLog
CommitLineData
62efea5e
DA
12012-06-26 Dmitry Antipov <dmantipov@yandex.ru>
2
3 * alloc.c (allocate_window): Zero out non-Lisp part of newly
4 allocated window.
5 (allocate_process): Likewise for new process.
6 (allocate_terminal): Changed to use offsetof.
7 (allocate_frame): Likewise.
8 * frame.c (make_frame): Omit redundant initialization.
9 * window.c (make_parent_window): Use memset.
10 (make_window): Omit redundant initialization.
11 * process.c (make_process): Omit redundant initialization.
12 * terminal.c (create_terminal): Likewise.
13
42997f4d
DA
142012-06-26 Dmitry Antipov <dmantipov@yandex.ru>
15
16 * term.c (delete_tty): Remove redundant call to memset.
17
1130ecfc
DA
182012-06-26 Dmitry Antipov <dmantipov@yandex.ru>
19
20 * alloc.c: Remove build_string.
21 * lisp.h: Define build_string as static inline. This provides
22 a better opportunity to optimize away calls to strlen when the
23 function is called with compile-time constant argument.
24 * image.c (imagemagick_error): Convert to build_string.
25 * w32proc.c (sys_spawnve): Likewise.
26 * xterm.c (x_term_init): Likewise.
27
cf38a720
PE
282012-06-26 Paul Eggert <eggert@cs.ucla.edu>
29
99027bdd
PE
30 Use sprintf return value instead of invoking strlen on result.
31 In the old days this wasn't portable, since some sprintf
32 implementations returned char *. But they died out years ago and
33 Emacs already assumes sprintf returns int.
34 Similarly for float_to_string.
35 This patch speeds up (number-to-string 1000) by 3% on Fedora 15 x86-64.
36 * ccl.c (ccl_driver):
37 * character.c (string_escape_byte8):
38 * data.c (Fnumber_to_string):
39 * doprnt.c (doprnt):
40 * print.c (print_object):
41 * xdisp.c (message_dolog):
42 * xfns.c (syms_of_xfns):
43 Use sprintf or float_to_string result to avoid need to call strlen.
44 * data.c (Fnumber_to_string):
45 Use make_unibyte_string, since the string must be ASCII.
46 * lisp.h, print.c (float_to_string): Now returns int length.
47 * term.c (produce_glyphless_glyph):
48 Use sprintf result rather than recomputing it.
49
cf38a720
PE
50 Clean out last vestiges of the old HAVE_CONFIG_H stuff.
51 * Makefile.in (ALL_CFLAGS):
52 * makefile.w32-in (LOCAL_FLAGS): Remove -DHAVE_CONFIG_H.
53 * gmalloc.c, regex.c: Include <config.h> unconditionally.
54
3511c784
DA
552012-06-25 Dmitry Antipov <dmantipov@yandex.ru>
56
0a08eb21 57 * dispextern.h (xstrcasecmp): Define to library function
3511c784
DA
58 strcasecmp if available.
59 * xfaces.c: Do not use xstrcasecmp if strcasecmp is available.
60
fb7da12e
AS
612012-06-25 Andreas Schwab <schwab@linux-m68k.org>
62
63 * keyboard.c (menu_bar_items, menu_bar_item, read_key_sequence):
64 Avoid comma operator.
65 * menu.c (push_submenu_start, push_submenu_end)
66 (push_left_right_boundary, push_menu_pane): Likewise.
67 * msdos.c (dos_rawgetc): Likewise.
68
afa2ffd8
DA
692012-06-25 Dmitry Antipov <dmantipov@yandex.ru>
70
71 * xfns.c (xic_create_fontsetname): Remove redundant calls
72 to memset.
73
b3b4476b
PE
742012-06-25 Paul Eggert <eggert@cs.ucla.edu>
75
4495ff38
PE
76 * gtkutil.c (get_utf8_string): Remove redundant assignment.
77 sprintf already null-terminates its output.
78
b3b4476b
PE
79 * xfns.c (x_window): Remove redundant cast.
80
b00876c9
DA
812012-06-25 Dmitry Antipov <dmantipov@yandex.ru>
82
83 * xmenu.c (xmenu_show, xdialog_show): Explicit cast from
84 `const char *' to `char *' to avoid compiler warning.
85
d188e26b
PE
862012-06-24 Paul Eggert <eggert@cs.ucla.edu>
87
885d1d74
PE
88 * xterm.c (x_term_init): Build proper-sized _XSETTINGS_Snnn string
89 instead of truncating it to 63 (admittedly a generous limit).
90
d188e26b
PE
91 * process.c: Fix spelling and caps in comments.
92
e2f560b1
DN
932012-06-24 Dan Nicolaescu <dann@ics.uci.edu>
94
e86db54b 95 * emacs.c (setpgrp): Remove definition, unused.
e2f560b1
DN
96 * sysdep.c (setpgrp): Remove definition, not used in this file.
97
7583a3a1
JB
982012-06-24 Juanma Barranquero <lekktu@gmail.com>
99
100 * makefile.w32-in: Update dependencies.
101
696056c2
EZ
1022012-06-24 Eli Zaretskii <eliz@gnu.org>
103
104 * makefile.w32-in (TIMESPEC_H): Remove nt/inc/sys/time.h.
105 (SYSTIME_H): Add nt/inc/sys/time.h.
106
107 * systime.h [WINDOWSNT]: Include sys/time.h.
108
109 * s/ms-w32.h (struct timespec): Definition moved from
110 nt/inc/sys/time.h. Suggested by Paul Eggert <eggert@cs.ucla.edu>.
111
845ca893
PE
1122012-06-24 Paul Eggert <eggert@cs.ucla.edu>
113
114 Switch from NO_RETURN to C11's _Noreturn (Bug#11750).
115 * buffer.h (buffer_slot_type_mismatch):
116 * data.c (arith_error) [!FORWARD_SIGNAL_TO_MAIN_THREAD]:
117 * eval.c (unwind_to_catch):
118 * image.c (my_png_error, my_error_exit):
119 * keyboard.c (quit_throw_to_read_char, user_error)
120 (Fexit_recursive_edit, Fabort_recursive_edit):
121 * lisp.h (die, args_out_of_range, args_out_of_range_3)
122 (wrong_type_argument, buffer_overflow, __executable_start)
123 (memory_full, buffer_memory_full, string_overflow, Fthrow)
124 (xsignal, xsignal0, xsignal1, xsignal2, xsignal3, signal_error)
125 (error, verror, nsberror, report_file_error, Ftop_level, Fkill_emacs)
126 (fatal):
127 (child_setup) [!DOS_NT]:
128 * lread.c (end_of_file_error, invalid_syntax):
129 * process.c (send_process_trap) [!FORWARD_SIGNAL_TO_MAIN_THREAD]:
130 * puresize.h (pure_write_error):
131 * search.c (matcher_overflow):
132 * sound.c (sound_perror, alsa_sound_perror):
133 * sysdep.c, syssignal.h (croak):
134 * term.c (maybe_fatal, vfatal):
135 * textprop.c (text_read_only):
136 * undo.c (user_error):
137 * unexmacosx.c (unexec_error):
138 * xterm.c (x_ins_del_lines, x_delete_glyphs):
139 Use _Noreturn rather than NO_RETURN.
140 No need for separate decl merely because of _Noreturn.
141 * sound.c (sound_warning, parse_sound):
142 Remove unnecessary forward decls.
143
f1dd8073
PE
1442012-06-24 Paul Eggert <eggert@cs.ucla.edu>
145
146 Fix bug when time_t is unsigned and as wide as intmax_t (Bug#9000).
147 * lisp.h (WAIT_READING_MAX): New macro.
148 * dispnew.c (Fsleep_for, sit_for):
149 * keyboard.c (kbd_buffer_get_event):
150 * process.c (Faccept_process_output):
151 Use it to avoid bogus compiler warnings with obsolescent GCC versions.
152 This improves on the previous patch, which introduced a bug
153 when time_t is unsigned and as wide as intmax_t.
154 See <http://bugs.gnu.org/9000#51>.
155
b82c1755
EZ
1562012-06-23 Eli Zaretskii <eliz@gnu.org>
157
158 * dispnew.c (sit_for, Fsleep_for):
159 * keyboard.c (kbd_buffer_get_event):
160 * process.c (Faccept_process_output): Avoid compiler warnings when
161 comparing a 32-bit time_t with a 64-bit INTMAX_MAX.
162
ca300656
JB
1632012-06-23 Juanma Barranquero <lekktu@gmail.com>
164
049ec95b
JB
165 * makefile.w32-in: Update dependencies.
166
ca300656
JB
167 * w32.c (ltime): Add return type and declare static.
168 (w32_get_internal_run_time): Remove usused variable `time_100ns'.
169
db7b8d06
PE
1702012-06-23 Paul Eggert <eggert@cs.ucla.edu>
171
172 * sysdep.c [__FreeBSD__]: Fix more recently-introduced typos.
173 Privately reported by Herbert J. Skuhra.
174 (make_lisp_timeval) [__FreeBSD__]: Rename from TIMELIST.
175 All uses changed.
176 (system_process_attributes) [__FreeBSD__]: Invoke make_lisp_time,
177 not make_lisp_timeval, when the argument is of type EMACS_TIME.
178
0bd8297f
EZ
1792012-06-23 Eli Zaretskii <eliz@gnu.org>
180
96512555
EZ
181 * w32proc.c (Fw32_get_locale_info): Fix an off-by-one error in
182 last argument of make_unibyte_string.
183
0bd8297f
EZ
184 * keyboard.c (kbd_buffer_get_event): Include the codepage and the
185 language ID in the event parameters.
186
187 * w32term.c (w32_read_socket): Put the new keyboard codepage into
188 event.code, not the obscure "character set ID".
189
63def6b6
CY
1902012-06-23 Chong Yidong <cyd@gnu.org>
191
192 * xmenu.c (x_menu_wait_for_event): Adapt GTK3 to new xg_select.
193
e8a02204
EZ
1942012-06-23 Eli Zaretskii <eliz@gnu.org>
195
388cdec0
EZ
196 Fix the MS-Windows build broken by 2012-06-22T21:17:42Z!eggert@cs.ucla.edu.
197 * w32.c (fdutimens): New function.
198
199 * w32proc.c (sys_select): Adapt to change in the EMACS_TIME type.
200
201 * s/ms-w32.h (pselect): Redirect to sys_select.
202
203 * sysselect.h [WINDOWSNT]: Don't include sys/select.h.
204
e8a02204
EZ
205 * ralloc.c (r_alloc_inhibit_buffer_relocation): Fix stupid thinko
206 in the logic of incrementing and decrementing the value of
207 use_relocatable_buffers.
208
d054f3fb
PE
2092012-06-23 Paul Eggert <eggert@cs.ucla.edu>
210
211 * sysdep.c [__FreeBSD__]: Fix recently-introduced typos.
212 Privately reported by Herbert J. Skuhra.
213 [__FreeBSD__]: Remove "*/" typo after "#include".
214 (timeval_to_EMACS_TIME) [__FreeBSD__]: New static function.
215 (TIMEVAL) [__FreeBSD__]: Now a static function rather than a macro.
216 (TIMEVAL, system_process_attributes) [__FreeBSD__]:
217 Don't assume EMACS_TIME and struct timeval are the same type.
218
d35af63c
PE
2192012-06-22 Paul Eggert <eggert@cs.ucla.edu>
220
221 Support higher-resolution time stamps (Bug#9000).
222 The time stamps are only nanosecond-resolution at the C level,
223 since that's the best that any real-world system supports now.
224 But they are picosecond-resolution at the Lisp level, as that's
225 easy, and leaves room for future OS improvements.
226
227 * Makefile.in (LIB_CLOCK_GETTIME): New macro.
228 (LIBES): Use it.
229
230 * alloc.c (Fgarbage_collect): Port to higher-res time stamps.
231 Don't get current time unless it's needed.
232
233 * atimer.c: Include <sys/time.h> unconditionally, since gnulib
234 now provides it if it's absent.
235 (start_atimer): Port to higher-res time stamps.
236 Check for time stamp overflow. Don't get current time more
237 often than is needed.
238
239 * buffer.h (struct buffer): Buffer modtime now has high resolution.
240 Include systime.h, not time.h.
241 (NONEXISTENT_MODTIME_NSECS, UNKNOWN_MODTIME_NSECS): New macros.
242
243 * dired.c: Include stat-time.h.
244 (Ffile-attributes): File times now have higher resolution.
245
246 * dispextern.h [HAVE_WINDOW_SYSTEM]: Include systime.h.
247 (struct image): Timestamp now has higher resolution.
248
249 * dispnew.c (PERIODIC_PREEMPTION_CHECKING): Remove, as Emacs always
250 has at least microseconds now. All uses removed.
251 (update_frame, update_single_window, update_window, update_frame_1)
252 (Fsleep_for, sit_for): Port to higher-resolution time stamps.
253
254 * editfns.c (time_overflow): Now extern.
255 (Fcurrent_time, Fget_internal_run_time, make_time, lisp_time_argument)
256 (float-time, Fformat_time_string, Fcurrent_time_string)
257 (Fcurrent_time_zone): Accept and generate higher-resolution
258 time stamps.
259 (make_time_tail, make_lisp_time, dissassemble_lisp_time)
260 (decode_time_components, lisp_seconds_argument): New functions.
261 (make_time): Now static.
262 (lisp_time_argument): Now returns EMACS_TIME. New arg ppsec.
263 Report an error if the time is invalid, rather than having the caller
264 do that.
265
266 * fileio.c: Include <stat-time.h>
267 (Fcopy_file): Copy higher-resolution time stamps.
268 Prefer to set the time stamp via a file descriptor if that works.
269 (Fset_file_times, Finsert_file_contents, Fwrite_region)
270 (Fverify_visited_file_modtime, Fclear_visited_file_modtime)
271 (Fvisited_file_modtime, Fset_visited_file_modtime):
272 Support higher-resolution time stamps.
273
274 * fns.c (Frandom): Use nanoseconds, not microseconds, for seed.
275
276 * gtkutil.c (xg_maybe_add_timer): Port to higher-res time stamps.
277
278 * image.c (prepare_image_for_display, clear_image_cache)
279 (lookup_image): Port to higer-resolution time stamps.
280
281 * keyboard.c (start_polling, bind_polling_period):
282 Check for time stamp overflow.
283 (read_char, kbd_buffer_get_event, timer_start_idle)
284 (timer_stop_idle, timer_resume_idle, timer_check_2, timer_check)
285 (Fcurrent_idle_time, init_keyboard, set_waiting_for_input):
286 Port to higher-resolution time stamps. Do not assume time_t is signed.
287 (decode_timer): New function. Timers are now vectors of length 9,
288 not 8, to accommodate the picosecond component.
289 (timer_check_2): Use it.
290
291 * nsterm.m (select_timeout, timeval_subtract): Remove.
292 (ns_timeout): Use Emacs's facilities for time stamp arithmetic,
293 as they're a bit more accurate and handle overflow better.
294 (ns_select): Change prototype to be compatible with pselect.
295 (ns_select, ns_term_shutdown): Port to ns-resolution time stamps.
296 * nsterm.h (ns_select): Adjust prototype.
297
298 * msdos.c (EMACS_TIME_ZERO_OR_NEG_P): Remove, as it assumes
299 us-resolution time stamps.
300 (sys_select): Use the new EMACS_TIME_SIGN macro instead.
301
302 * lread.c (read_filtered_event): Port to ns-resolution time stamps.
303
304 * lisp.h (time_overflow): New decl.
305 (wait_reading_process_output): First arg is now intmax_t, not int,
306 to accommodate larger waits.
307
308 * process.h (struct Lisp_Process.read_output_delay):
309 Now counts nanoseconds, not microseconds.
310 * process.c (ADAPTIVE_READ_BUFFERING): Don't worry about
311 EMACS_HAS_USECS.
312 (READ_OUTPUT_DELAY_INCREMENT, Faccept_process_output)
313 (wait_reading_process_output):
314 Port to ns-resolution time stamps.
315 (Faccept_process_output, wait_reading_process_output):
316 Check for time stamp overflow. Do not assume time_t is signed.
317 (select_wrapper): Remove; we now use pselect.
318 (Fprocess_attributes): Now generates ns-resolution time stamps.
319
320 * sysdep.c: Include utimens.h. Don't include utime.h
321 or worry about struct utimbuf; gnulib does that for us now.
322 (gettimeofday): Remove; gnulib provides a substitute.
323 (make_timeval): New function.
324 (set_file_times): Now sets ns-resolution time stamps.
325 New arg FD; all uses changed.
326 (time_from_jiffies, ltime_from_jiffies, get_up_time)
327 (system_process_attributes):
328 Now returns ns-resolution time stamp. All uses changed.
329 Check for time stamp overflow.
330
331 * sysselect.h: Don't depend on HAVE_SYS_SELECT_H; gnulib
332 provides a substitute now.
333
334 * systime.h: Include timespec.h rather than sys/time.h and time.h,
335 since it guarantees struct timespec.
336 (EMACS_TIME): Now struct timespec, so that we can support
337 ns-resolution time stamps.
338 (EMACS_TIME_RESOLUTION, LOG10_EMACS_TIME_RESOLUTION): New macros.
339 (EMACS_HAS_USECS): Remove; Emacs always has sub-second time stamps now.
340 (EMACS_USECS): Remove.
341 (EMACS_SET_USECS): The underlying time stamp now has ns resolution,
342 so multiply the arg by 1000 before storing it.
343 (EMACS_NSECS, EMACS_SECS_ADDR, EMACS_SET_NSECS, EMACS_SET_SECS_NSECS):
344 New macros.
345 (EMACS_GET_TIME, EMACS_ADD_TIME, EMACS_SUB_TIME):
346 Port to ns-resolution time stamps.
347 (EMACS_TIME_NEG_P): Remove; replaced by....
348 (EMACS_TIME_SIGN): New macro.
349 (EMACS_SET_INVALID_TIME, EMACS_TIME_VALID_P)
350 (EMACS_TIME_FROM_DOUBLE, EMACS_TIME_TO_DOUBLE): New macros.
351 (set_file_times, make_time, lisp_time_argument): Adjust signature.
352 (make_timeval, make_lisp_time, decode_time_components): New decls.
353 (EMACS_TIME_CMP): Remove; no longer used. Plus, it was buggy, in
354 that it mishandled time_t overflow. You can't compare by subtracting!
355 (EMACS_TIME_EQ, EMACS_TIME_NE, EMACS_TIME_GT, EMACS_TIME_GE)
356 (EMACS_TIME_LT, EMACS_TIME_LE): Rewrite in terms of timespec_cmp.
357
358 * term.c: Include <sys/time.h>.
359 (timeval_to_Time): New function, for proper overflow wraparound.
360 (term_mouse_position, term_mouse_click): Use it.
361
362 * undo.c (record_first_change): Support higher-resolution time stamps
363 in the undo buffer.
364 (Fprimitive_undo): Use them when restoring time stamps.
365
366 * w32.c (ltime, U64_TO_LISP_TIME, process_times, emacs_gnutls_pull)
367 (w32_get_internal_run_time):
368 Port to higher-resolution Emacs time stamps.
369 (ltime): Now accepts single 64-bit integer, as that's more convenient
370 for callers.
371
372 * xdisp.c (start_hourglass): Port to ns-resolution time stamps.
373
374 * xgselect.c, xgselect.h (xg_select): Add sigmask argument,
375 for compatibility with pselect. Support ns-resolution time stamps.
376
377 * xmenu.c (x_menu_wait_for_event): Support ns-resolution time stamps.
378
379 * xselect.c (wait_for_property_change, x_get_foreign_selection):
380 Check for time stamp overflow, and support ns-resolution time stamps.
381
382 * xterm.c: Don't include sys/time.h; gnulib does that for us now.
383 Don't worry about whether HAVE_TIMEVAL and HAVE_SELECT are set.
384 (timeval_subtract): Remove; no longer needed.
385 (XTflash, XTring_bell, x_wait_for_event):
386 Port to ns-resolution time stamps. Don't assume time_t is signed.
387
b6a92dfe
CY
3882012-06-22 Chong Yidong <cyd@gnu.org>
389
390 * xdisp.c (x_consider_frame_title): Revert last change.
391
d251c37c
EZ
3922012-06-22 Eli Zaretskii <eliz@gnu.org>
393
394 * alloc.c (NSTATICS): Enlarge to 0x650. Otherwise, Emacs compiled
395 with -DENABLE_CHECKING -DXASSERTS -DGLYPH_DEBUG=1 -DBYTE_CODE_METER
396 aborts in staticpro during startup. (Without -DBYTE_CODE_METER,
397 staticidx goes up to 1597 out of 1600 = 0x640.)
398
f10deafb
PE
3992012-06-20 Paul Eggert <eggert@cs.ucla.edu>
400
401 * fileio.c (Fdefault_file_modes): Block input while fiddling with umask.
402 Otherwise, the umask might be mistakenly 0 while handling input signals.
403
ec6de1e2
SM
4042012-06-19 Stefan Monnier <monnier@iro.umontreal.ca>
405
406 * minibuf.c (Fread_string): Bind minibuffer-completion-table.
407
28be1ada
DA
4082012-06-19 Dmitry Antipov <dmantipov@yandex.ru>
409
410 * alloc.c, bytecode.c, ccl.c, coding.c, composite.c, data.c, dosfns.c:
411 * font.c, image.c, keyboard.c, lread.c, menu.c, minibuf.c, msdos.c:
412 * print.c, syntax.c, window.c, xmenu.c, xselect.c: Replace direct
413 access to `contents' member of Lisp_Vector objects with AREF and ASET
414 where appropriate.
415
c6bf3022
CY
4162012-06-19 Chong Yidong <cyd@gnu.org>
417
418 * frame.c (delete_frame): When selecting a frame on a different
419 text terminal, do not alter the terminal's top-frame.
420
421 * xdisp.c (format_mode_line_unwind_data): Record the target
422 frame's selected window and its terminal's top-frame.
423 (unwind_format_mode_line): Restore them.
424 (x_consider_frame_title, display_mode_line, Fformat_mode_line):
425 Callers changed.
426 (x_consider_frame_title): Do not condition on HAVE_WINDOW_SYSTEM,
427 since tty frames can be explicitly named.
428 (prepare_menu_bars): Likewise.
429
430 * term.c (Ftty_top_frame): New function.
431
defd4196
PE
4322012-06-18 Paul Eggert <eggert@cs.ucla.edu>
433
434 Port byte-code-meter to modern targets.
435 * bytecode.c (METER_CODE) [BYTE_CODE_METER]: Don't assume
436 !CHECK_LISP_OBJECT_TYPE && !USE_LSB_TAG. Problem with
8b5257e1 437 CHECK_LISP_OBJECT_TYPE reported by Dmitry Antipov in
defd4196
PE
438 <http://lists.gnu.org/archive/html/emacs-devel/2012-06/msg00282.html>.
439 (METER_1, METER_2): Simplify.
440
1053a871
SM
4412012-06-18 Stefan Monnier <monnier@iro.umontreal.ca>
442
443 * data.c (Fdefalias): Return `symbol' (bug#11686).
444
b7e8d081
MR
4452012-06-18 Martin Rudalics <rudalics@gmx.at>
446
447 * buffer.c (Fkill_buffer): Don't throw an error when the buffer
1053a871
SM
448 gets killed during executing of this function (Bug#11665).
449 Try to always return Qt when the buffer has been actually killed.
b7e8d081
MR
450 (Vkill_buffer_query_functions): In doc-string say that functions
451 run by this hook should not change the current buffer.
452
7ea2b339
PE
4532012-06-18 Paul Eggert <eggert@cs.ucla.edu>
454
455 Fix recently-introduced process.c problems found by static checking.
456 * process.c (write_queue_push, write_queue_pop, send_process):
457 Use ptrdiff_t, not int or EMACS_INT, for buffer lengths and offsets.
458 (write_queue_pop): Fix pointer signedness problem.
459 (send_process): Remove unused local.
460
96a313a1
CY
4612012-06-17 Chong Yidong <cyd@gnu.org>
462
463 * xdisp.c (redisplay_internal): No need to redisplay terminal
464 frames that are not on top.
465
20ca2e94
TN
4662012-06-17 Troels Nielsen <bn.troels@gmail.com>
467
468 * process.c (make_process): Initialize write_queue.
469 (write_queue_push, write_queue_pop): New functions.
470 (send_process): Use them to maintain correct ordering of process
471 writes (Bug#10815).
472
9a900ca9
PE
4732012-06-17 Paul Eggert <eggert@cs.ucla.edu>
474
310fbfa8
PE
475 * lisp.h (eassert): Assume C89 or later.
476 This removes the need for CHECK.
477 (CHECK): Remove. Its comments about always evaluating its
478 argument were confusing, as 'eassert' typically does not evaluate
479 its argument.
480
27bb1ca4
PE
481 * coding.c (produce_chars): Use ptrdiff_t, not int.
482
9a900ca9
PE
483 * xterm.c (x_draw_underwave): Check for integer overflow.
484 This pacifies gcc 4.7.0 -Wunsafe-loop-optimizations on x86-64.
485
41b7f8bc 4862012-06-17 Jan Djärv <jan.h.d@swipnet.se>
50a93863
JD
487
488 * nsterm.m (x_free_frame_resources): Move xfree so freed memory isn't
489 referenced (Bug#11583).
490
9b0e3eba
AA
4912012-06-16 Aurelien Aptel <aurelien.aptel@gmail.com>
492
493 Implement wave-style variant of underlining.
494 * dispextern.h (face_underline_type): New enum.
495 (face): Add field for underline type.
496 * nsterm.m (ns_draw_underwave): New function.
497 (ns_draw_text_decoration): Use it.
498 * w32term.c (w32_restore_glyph_string_clip, w32_draw_underwave):
499 New functions.
500 (x_draw_glyph_string): Use them.
501 * xfaces.c (Qline, Qwave): New Lisp objects.
502 (check_lface_attrs, merge_face_ref)
1053a871
SM
503 (Finternal_set_lisp_face_attribute, realize_x_face):
504 Handle wave-style underline face attributes.
9b0e3eba
AA
505 * xterm.c (x_draw_underwave): New function.
506 (x_draw_glyph_string): Use it.
507
0fb52f11
JB
5082012-06-16 Juanma Barranquero <lekktu@gmail.com>
509
510 * makefile.w32-in ($(BLD)/emacs.$(O), $(BLD)/fringe.$(O))
511 ($(BLD)/xml.$(O), $(BLD)/intervals.$(O), $(BLD)/macros.$(O))
512 ($(BLD)/minibuf.$(O), $(BLD)/regex.$(O), $(BLD)/region-cache.$(O))
513 ($(BLD)/textprop.$(O), $(BLD)/undo.$(O), $(BLD)/window.$(O))
514 ($(BLD)/w32select.$(O)): Update dependencies.
515
e5560ff7
AS
5162012-06-16 Andreas Schwab <schwab@linux-m68k.org>
517
518 * buffer.h (FETCH_MULTIBYTE_CHAR): Define as inline.
519 (BUF_FETCH_MULTIBYTE_CHAR): Likewise.
520 * character.c (_fetch_multibyte_char_p): Remove.
521 * alloc.c: Include "character.h" before "buffer.h".
522 * bidi.c: Likewise.
523 * buffer.c: Likewise.
524 * bytecode.c: Likewise.
525 * callint.c: Likewise.
526 * callproc.c: Likewise.
527 * casefiddle.c: Likewise.
528 * casetab.c: Likewise.
529 * category.c: Likewise.
530 * cmds.c: Likewise.
531 * coding.c: Likewise.
532 * composite.c: Likewise.
533 * dired.c: Likewise.
534 * dispnew.c: Likewise.
535 * doc.c: Likewise.
536 * dosfns.c: Likewise.
537 * editfns.c: Likewise.
538 * emacs.c: Likewise.
539 * fileio.c: Likewise.
540 * filelock.c: Likewise.
541 * font.c: Likewise.
542 * fontset.c: Likewise.
543 * fringe.c: Likewise.
544 * indent.c: Likewise.
545 * insdel.c: Likewise.
546 * intervals.c: Likewise.
547 * keyboard.c: Likewise.
548 * keymap.c: Likewise.
549 * lread.c: Likewise.
550 * macros.c: Likewise.
551 * marker.c: Likewise.
552 * minibuf.c: Likewise.
553 * nsfns.m: Likewise.
554 * nsmenu.m: Likewise.
555 * print.c: Likewise.
556 * process.c: Likewise.
557 * regex.c: Likewise.
558 * region-cache.c: Likewise.
559 * search.c: Likewise.
560 * syntax.c: Likewise.
561 * term.c: Likewise.
562 * textprop.c: Likewise.
563 * undo.c: Likewise.
564 * unexsol.c: Likewise.
565 * w16select.c: Likewise.
566 * w32fns.c: Likewise.
567 * w32menu.c: Likewise.
568 * window.c: Likewise.
569 * xdisp.c: Likewise.
570 * xfns.c: Likewise.
571 * xmenu.c: Likewise.
572 * xml.c: Likewise.
573 * xselect.c: Likewise.
574
2f07e6af
EZ
5752012-06-16 Eli Zaretskii <eliz@gnu.org>
576
1053a871
SM
577 * xdisp.c (set_cursor_from_row): Don't dereference glyphs_end.
578 If all the glyphs of the glyph row came from strings, and we have no
2f07e6af 579 cursor positioning clues, put the cursor on the first glyph of the
1097afe4
EZ
580 row.
581 (handle_face_prop): Use chunk-relative overlay string index when
582 indexing into it->string_overlays array. (Bug#11653)
946fdb73
EZ
583 (set_cursor_from_row): Use the leftmost glyph as GLYPH_BEFORE, not
584 the rightmost. (Bug#11720)
2f07e6af 585
29b83cec
AS
5862012-06-16 Andreas Schwab <schwab@linux-m68k.org>
587
588 * category.h (CHAR_HAS_CATEGORY): Define as inline.
589 (CATEGORY_MEMBER): Enforce 1/0 value.
590 * category.c (_temp_category_set): Remove.
591
4c5501e9
EZ
5922012-06-16 Eli Zaretskii <eliz@gnu.org>
593
594 * window.c (Fdelete_other_windows_internal)
595 (Fdelete_window_internal): Don't access frame's mouse highlight
596 info of the initial frame. (Bug#11677)
597
2b570124
PE
5982012-06-14 Paul Eggert <eggert@cs.ucla.edu>
599
e93864f9
PE
600 * .gdbinit (xgetint): Fix recently-introduced paren typo.
601 Assume USE_2_TAGS_FOR_INTS.
602 (xreload): Adjust $tagmask width to match recent lisp.h change.
603
2b570124
PE
604 Simplify lisp.h in minor ways that should not affect code.
605 * lisp.h (USE_2_TAGS_FOR_INTS): Remove, as it was always defined.
606 (LISP_INT_TAG, case_Lisp_Int, LISP_STRING_TAG, LISP_INT_TAG_P)
607 (LISP_INT1_TAG, enum Lisp_Type, XINT, XUINT, make_number):
608 Simplify under the assumption that USE_2_TAGS_FOR_INTS is defined.
609 (INTTYPEBITS): New macro, for clarity.
610 (INTMASK, MOST_POSITIVE_FIXNUM): Use it.
1053a871
SM
611 (LISP_INT1_TAG, LISP_STRING_TAG, LISP_INT_TAG_P):
612 Simplify now that USE_LSB_TAG is always defined.
2b570124
PE
613 (TYPEMASK, XINT) [USE_LSB_TAG]: Remove unnecessary cast.
614 (make_number) [!USE_LSB_TAG]: Use INTMASK; that's simpler.
615
81755f69
JB
6162012-06-13 Juanma Barranquero <lekktu@gmail.com>
617
618 * makefile.w32-in ($(BLD)/data.$(O)): Update dependencies.
619
16192a57
GM
6202012-06-13 Glenn Morris <rgm@gnu.org>
621
622 * s/bsd-common.h (BSD4_3):
623 * s/usg5-4-common.h (USG5_4): No longer define; unused.
624
646b5f55
AS
6252012-06-13 Andreas Schwab <schwab@linux-m68k.org>
626
627 * lisp.h (Lisp_Object) [CHECK_LISP_OBJECT_TYPE]: Define as struct
628 instead of union.
629 (XLI, XIL): Define.
1053a871
SM
630 (XHASH, XTYPE, XINT, XUINT, make_number, XSET, XPNTR, XUNTAG):
631 Use them.
632 * emacs.c (gdb_use_struct): Rename from gdb_use_union.
646b5f55 633 * .gdbinit: Check gdb_use_struct instead of gdb_use_union.
1053a871 634 * alloc.c (widen_to_Lisp_Object): Remove.
646b5f55
AS
635 (mark_memory): Use XIL instead of widen_to_Lisp_Object.
636 * frame.c (delete_frame): Remove outdated comment.
637 * w32fns.c (Fw32_register_hot_key): Use XLI instead of checking
638 USE_LISP_UNION_TYPE.
639 (Fw32_unregister_hot_key): Likewise.
640 (Fw32_toggle_lock_key): Likewise.
641 * w32menu.c (add_menu_item): Likewise.
642 (w32_menu_display_help): Use XIL instead of checking
643 USE_LISP_UNION_TYPE.
644 * w32heap.c (allocate_heap): Don't check USE_LISP_UNION_TYPE.
645 (init_heap): Likewise.
646 * w32term.c (w32_read_socket): Update comment.
647
1d3823c9
GM
6482012-06-13 Glenn Morris <rgm@gnu.org>
649
c62ff706
GM
650 * s/usg5-4-common.h, src/s/unixware.h:
651 Remove define/undef of HAVE_SYSV_SIGPAUSE (not used since 2010-05-04).
652
1d3823c9
GM
653 * s/gnu.h (POSIX_SIGNALS): Remove (not used since 2010-05-04).
654
bfe3e0a2
PE
6552012-06-13 Paul Eggert <eggert@cs.ucla.edu>
656
657 USE_LISP_UNION_TYPE + USE_LSB_TAG cleanup (Bug#11604)
658 * alloc.c (make_number) [!defined make_number]:
659 Remove, as lisp.h always defines this now.
660 (mark_maybe_pointer): Simplify since USE_LSB_TAG is always defined now.
661 (roundup_size): Verify that it is a power of 2.
662 * data.c (Fmake_variable_buffer_local, Fmake_local_variable):
663 * ftfont.c (ftfont_driver): Use LISP_INITIALLY_ZERO.
664 * lisp.h (USE_LSB_TAG): Allow the builder to compile with
665 -DUSE_LSB_TAG=0, to override the automatically-selected default.
666 USE_LSB_TAG now is always defined to be either 0 or 1.
667 All uses changed.
668 (union Lisp_Object): Don't worry about WORDS_BIGENDIAN; the
669 code works fine either way, and efficiency is not a concern here,
670 as the union type is for debugging, not for production.
671 (LISP_MAKE_RVALUE, make_number) [USE_LISP_UNION_TYPE]:
672 Use an inline function on all platforms when using the union type,
673 since this is simpler and 'static inline' can be used portably
674 within Emacs now.
675 (LISP_INITIALLY_ZERO): New macro.
676 (XFASTINT, XSETFASTINT) [USE_LISP_UNION_TYPE]: Remove.
677 (XSET) [USE_LISP_UNION_TYPE]: Don't overparenthesize.
678
45fa9c0f
GM
6792012-06-12 Glenn Morris <rgm@gnu.org>
680
b4492cba
GM
681 * s/gnu-kfreebsd.h, s/hpux11.h, s/openbsd.h, s/sol2-10.h: Remove files.
682
683 * s/gnu-linux.h (HAVE_PROCFS): Move to configure.
0d369729 684
45fa9c0f
GM
685 * s/hpux10-20.h, s/openbsd.h, s/usg5-4-common.h:
686 Move BROKEN_SIGIO to configure.
687
688 * s/bsd-common.h, s/darwin.h, s/gnu-kfreebsd.h, s/hpux10-20.h:
689 Move NO_TERMIO to configure.
690
0e25d334
CY
6912012-06-12 Chong Yidong <cyd@gnu.org>
692
693 * image.c (imagemagick_load_image): Use MagickFlattenImage if
694 MagickMergeImageLayers is undefined. Use pixel pusher loop if
695 MagickExportImagePixels is undefined.
696
43682bb6
PE
6972012-06-12 Paul Eggert <eggert@cs.ucla.edu>
698
699 * image.c (imagemagick_load_image): Remove unused label.
700
a9be7d2b
GM
7012012-06-11 Glenn Morris <rgm@gnu.org>
702
703 * s/aix4-2.h, s/bsd-common.h, s/cygwin.h, s/darwin.h:
704 * s/gnu-kfreebsd.h, s/gnu-linux.h, s/gnu.h, s/hpux10-20.h:
705 * s/irix6-5.h, s/ms-w32.h, s/msdos.h, s/template.h:
706 * s/usg5-4-common.h: Move SYSTEM_TYPE to configure.
707
3017f87f
SM
7082012-06-11 Stefan Monnier <monnier@iro.umontreal.ca>
709
710 * alloc.c (make_byte_code): New function.
711 (Fmake_byte_code): Use it. Don't purify here.
712 * lread.c (read1): Use it as well to avoid extra allocation.
713
1b9b4cf4
CY
7142012-06-11 Chong Yidong <cyd@gnu.org>
715
716 * image.c (imagemagick_load_image): Implement transparency.
717
95988fcf
AS
7182012-06-10 Andreas Schwab <schwab@linux-m68k.org>
719
720 * regex.c (at_begline_loc_p): Also recognize `(?N:' and correctly
721 account for preceding backslashes. (Bug#11663)
722
cd4eb164
CY
7232012-06-09 Chong Yidong <cyd@gnu.org>
724
725 * term.c: Support italics in capable terminals (Bug#9652).
726 (no_color_bit): Replace unused NC_BLINK with NC_ITALIC.
727 (turn_on_face): Output using TS_enter_italic_mode if available.
728 Don't handle unused blinking and alt-charset cases.
729 (turn_off_face): Handle italic case; discard unused tty_blinking_p
730 and tty_alt_charset_p cases.
731 (tty_capable_p, init_tty): Support italics.
732
733 * termchar.h (struct tty_display_info): Add field for italics.
734 Remove unused blink field.
735
736 * xfaces.c (tty_supports_face_attributes_p, realize_tty_face):
737 Handle slant.
738
739 * dispextern.h: Replace unused TTY_CAP_BLINK with TTY_CAP_ITALIC.
740 (struct face): Remove unused fields tty_dim_p, tty_blinking_p, and
741 tty_alt_charset_p. Add tty_italic_p.
742
ff88beb8
MA
7432012-06-09 Michael Albinus <michael.albinus@gmx.de>
744
745 * dbusbind.c (XD_BASIC_DBUS_TYPE): Use dbus_type_is_valid and
746 dbus_type_is_basic if available.
747 (xd_extract_signed, xd_extract_unsigned): Rename from
748 extract_signed and extract_unsigned, respectively. Adapt callers.
749
44286096
CY
7502012-06-09 Chong Yidong <cyd@gnu.org>
751
1682701f
CY
752 * xfaces.c (face_for_overlay_string): Handle face remapping (Bug#2066).
753
44286096
CY
754 * fringe.c (Fset_fringe_bitmap_face): Handle the noninteractive
755 case (Bug#9752).
756
d86feb17
PE
7572012-06-08 Paul Eggert <eggert@cs.ucla.edu>
758
759 * xdisp.c (vmessage): Treat frame message as multibyte.
760 Without this change, (let ((§ 1)) (make-variable-buffer-local '§))
761 would generate the diagnostic "Making \302\247 buffer-local while
762 let-bound!".
763
d5c20fe8
EZ
7642012-06-08 Eli Zaretskii <eliz@gnu.org>
765
766 * dispnew.c (showing_window_margins_p): Undo last change, which
767 was done due to an inadvertent commit.
768 (adjust_frame_glyphs_for_frame_redisplay): Do call
769 showing_window_margins_p.
770
513749ee
SM
7712012-06-08 Stefan Monnier <monnier@iro.umontreal.ca>
772
773 * eval.c (Fmake_var_non_special): New primitive.
774 (syms_of_eval): Defsubr it.
775 * lread.c (syms_of_lread): Mark `values' as lexically scoped.
776
d4a8f5c1
JB
7772012-06-08 Juanma Barranquero <lekktu@gmail.com>
778
779 * dispnew.c (showing_window_margins_p): Wrap in #if 0 to prevent unused
780 function warning (the only call is inside #if 0 since 2012-06-08T08:44:45Z!eliz@gnu.org).
781
8bbbc977
EZ
7822012-06-08 Eli Zaretskii <eliz@gnu.org>
783
784 * alloc.c (allocate_vectorlike): Fix last change.
785
f3372c87
DA
7862012-06-08 Dmitry Antipov <dmantipov@yandex.ru>
787
788 Block-based vector allocation of small vectors.
789 * lisp.h (struct vectorlike_header): New field `nbytes',
790 adjust comment accordingly.
791 * alloc.c (enum mem_type): New type `MEM_TYPE_VECTOR_BLOCK'
792 to denote vector blocks. Adjust users (live_vector_p,
793 mark_maybe_pointer, valid_lisp_object_p) accordingly.
794 (COMMON_MULTIPLE): Move outside #if USE_LSB_TAG.
795 (VECTOR_BLOCK_SIZE, vroundup, VECTOR_BLOCK_BYTES),
796 (VBLOCK_BYTES_MIN, VBLOCK_BYTES_MAX, VECTOR_MAX_FREE_LIST_INDEX),
797 (VECTOR_FREE_LIST_FLAG, ADVANCE, VINDEX, SETUP_ON_FREE_LIST),
798 (VECTOR_SIZE, VECTOR_IN_BLOCK): New macros.
799 (roundup_size): New constant.
800 (struct vector_block): New data type.
801 (vector_blocks, vector_free_lists, zero_vector): New variables.
513749ee 802 (all_vectors): Rename to `large_vectors'.
f3372c87
DA
803 (allocate_vector_from_block, init_vectors, allocate_vector_from_block)
804 (sweep_vectors): New functions.
805 (allocate_vectorlike): Return `zero_vector' as the only vector of
806 0 items. Allocate new vector from block if vector size is less than
807 or equal to VBLOCK_BYTES_MAX.
808 (Fgarbage_collect): Move all vector sweeping code to sweep_vectors.
809 (init_alloc_once): Add call to init_vectors.
810
4f18a4ed
SM
8112012-06-08 Stefan Monnier <monnier@iro.umontreal.ca>
812
813 * eval.c (Fmacroexpand): Stop if the macro returns the same form.
814
86f158bc
PE
8152012-06-07 Paul Eggert <eggert@cs.ucla.edu>
816
817 * doprnt.c (doprnt): Truncate multibyte char correctly.
818 Without this change, doprnt (buf, 2, "%s", FORMAT_END, AP)
819 would mishandle a string argument "Xc" if X was a multibyte
820 character of length 2: it would truncate after X's first byte
821 rather than including all of X.
822
c5cfcbe0
CY
8232012-06-06 Chong Yidong <cyd@gnu.org>
824
825 * buffer.c (word_wrap): Doc fix.
826
c05cf390
PE
8272012-06-04 Paul Eggert <eggert@cs.ucla.edu>
828
829 * xdisp.c (note_mode_line_or_margin_highlight): Pacify gcc -Wall.
830
0c3461de
GM
8312012-06-03 Glenn Morris <rgm@gnu.org>
832
833 * xdisp.c (tool-bar-style): Doc fix.
834
c71232db
UM
8352012-06-03 Ulrich Müller <ulm@gentoo.org>
836
837 * Makefile.in (PAXCTL): Define.
838 (temacs$(EXEEXT)): Disable memory randomization for the temacs
839 binary via PaX flags if the paxctl utility is available.
840 (emacs$(EXEEXT), bootstrap-emacs$(EXEEXT)):
841 Restore PaX flags to their default. (Bug#11398)
842
383f7350
CY
8432012-06-03 Chong Yidong <cyd@gnu.org>
844
845 * xdisp.c (decode_mode_spec_coding): Display a space for a unibyte
846 buffer (Bug#11226).
847
5f2c76c6
CY
8482012-06-03 Chong Yidong <cyd@gnu.org>
849
850 * xdisp.c (calc_pixel_width_or_height): Use Fbuffer_local_value.
851 (note_mode_line_or_margin_highlight): If there is no help echo,
852 use mode-line-default-help-echo. Handle the case where the mouse
853 position is past the end of the mode line string.
854
855 * buffer.c (buffer_local_value_1): New function, split from
856 Fbuffer_local_value; can return Qunbound.
857 (Fbuffer_local_value): Use it.
858 (Vmode_line_format): Docstring tweaks.
859
773d47f6
PE
8602012-06-02 Paul Eggert <eggert@cs.ucla.edu>
861
862 * sysdep.c (system_process_attributes): Improve comment.
863
f2d6a3df
SM
8642012-06-02 Stefan Monnier <monnier@iro.umontreal.ca>
865
866 * keyboard.c: Export real-this-command to Elisp.
867 (syms_of_keyboard): Rename real_this_command to Vreal_this_command
868 and DEFVAR it. Update all users.
869
63810350
PE
8702012-06-02 Paul Eggert <eggert@cs.ucla.edu>
871
7bd5c1f4
PE
872 * minibuf.c (Fassoc_string): Remove duplicate declaration.
873
63810350
PE
874 * sysdep.c (system_process_attributes) [SOLARIS2 && HAVE_PROCFS]:
875 Convert pctcpu and pctmem to Lisp float properly.
876 Let the compiler fold better, as 100.0/0x8000 is exact.
877
a2821611
AS
8782012-06-02 Andreas Schwab <schwab@linux-m68k.org>
879
880 * alloc.c (CONS_BLOCK_SIZE): Account for padding at the end of
881 cons_block.
882
5fceba1d
PE
8832012-06-01 Paul Eggert <eggert@cs.ucla.edu>
884
885 * xfns.c (x_set_tool_bar_lines) [USE_GTK]: Adjust to bitfield change.
886
c98ff5dd
DA
8872012-06-01 Dmitry Antipov <dmantipov@yandex.ru>
888
889 For a 'struct window', replace some Lisp_Object fields to
890 bitfields where appropriate, remove unused fields.
891 * window.h (struct window): Remove unused 'last_mark_x' and
892 'last_mark_y' fields. Rename 'mini_p' field to 'mini',
893 change it's type from Lisp_Object to bitfield.
894 Change type of 'force_start', 'optional_new_start',
895 'last_had_star', 'update_mode_line' and 'start_at_line_beg'
896 fields from Lisp_Object to bitfield. Adjust users accordingly.
897
ca34e0be
PE
8982012-05-31 Paul Eggert <eggert@cs.ucla.edu>
899
900 Pacify gcc -Wdouble-precision when using Xaw.
901 * xterm.c (xaw_jump_callback, x_set_toolkit_scroll_bar_thumb)
902 [HAVE_X_WINDOWS && USE_TOOLKIT_SCROLL_BARS && !USE_MOTIF && !USE_GTK]:
903 Use 'float' consistently, rather than 'float' in most places
904 and 'double' in a couple of places.
905
efc00ab1 9062012-05-31 Eli Zaretskii <eliz@gnu.org>
d5fd2c54
EZ
907
908 * xdisp.c (handle_stop): Detect whether we have overlay strings
909 loaded by testing it->current.overlay_string_index to be
910 non-negative, instead of checking whether n_overlay_strings is
911 positive. (Bug#11587)
912
efc00ab1 9132012-05-31 Chong Yidong <cyd@gnu.org>
353c87f6
CY
914
915 * keymap.c (describe_map_tree): Revert 2011-07-07 change (Bug#1169).
916
917 * doc.c (Fsubstitute_command_keys): Doc fix.
918
efc00ab1 9192012-05-31 Eli Zaretskii <eliz@gnu.org>
a02ae4e5
EZ
920
921 * search.c (search_buffer): Remove calls to
922 r_alloc_inhibit_buffer_relocation, as it is now called by
923 maybe_unify_char, which was the cause of relocation of buffer text
924 in bug#11519.
925
efc00ab1 9262012-05-31 Eli Zaretskii <eliz@gnu.org>
291d430f
EZ
927
928 * charset.c (maybe_unify_char): Inhibit relocation of buffer text
929 for the duration of call to load_charset, to avoid problems with
930 callers of maybe_unify_char that access buffer text through C
931 pointers.
932
933 * ralloc.c (r_alloc_inhibit_buffer_relocation): Increment and
934 decrement the inhibition flag, instead of just setting or
935 resetting it.
936
ba93a187
PE
9372012-05-31 Paul Eggert <eggert@cs.ucla.edu>
938
939 Remove obsolete '#define static' cruft.
940 * s/hpux10-20.h (_FILE_OFFSET_BITS): Don't #undef.
941 This #undef was "temporary" in 2000; it is no longer needed
942 now that '#define static' has gone away.
943 * xfns.c, xterm.h (gray_bitmap_width, gray_bitmap_height)
944 (gray_bitmap_bits): Remove; no longer needed.
945 All uses replaced with definiens.
946 * xterm.c: Include "bitmaps/gray.xbm".
947
9e4bf381
PE
9482012-05-30 Paul Eggert <eggert@cs.ucla.edu>
949
950 Clean up __executable_start, monstartup when --enable-profiling.
951 The following changes affect the code only when profiling.
952 * dispnew.c (__executable_start): Rename from safe_bcopy.
953 Define only on platforms that need it.
954 * emacs.c: Include <sys/gmon.h> when profiling.
955 (_mcleanup): Remove decl, since <sys/gmon.h> does it now.
956 (__executable_start): Remove decl, since lisp.h does it now.
957 (safe_bcopy): Remove decl; no longer has that name.
958 (main): Coalesce #if into single bit of code, for simplicity.
959 Cast pointers to uintptr_t, since standard libraries want integers
960 and not pointers.
961 * lisp.h (__executable_start): New decl.
962
32d72c2f
GM
9632012-05-31 Glenn Morris <rgm@gnu.org>
964
965 * image.c (Fimagemagick_types): Doc fix.
966
baac5bc7
JM
9672012-05-30 Jim Meyering <meyering@redhat.com>
968
969 * callproc.c (Fcall_process_region): Include directory component
970 in mkstemp error message (Bug#11586).
971
72cb32cf
PE
9722012-05-30 Paul Eggert <eggert@cs.ucla.edu>
973
974 * alloc.c, lisp.h (make_pure_vector): Now static.
975
61b108cc
SM
9762012-05-30 Stefan Monnier <monnier@iro.umontreal.ca>
977
978 * eval.c (Fdefun, Fdefmacro, Vmacro_declaration_function):
979 Move to byte-run.el.
980 (Fautoload): Do the hash-doc more carefully.
981 * data.c (Fdefalias): Purify definition, except for keymaps.
982 (Qdefun): Move from eval.c.
983 * lisp.h (Qdefun): Remove.
984 * lread.c (read1): Tiny simplification.
985
471fe23d
TN
9862012-05-29 Troels Nielsen <bn.troels@gmail.com>
987
934f3f58 988 Do not create empty overlays with the evaporate property (Bug#9642).
471fe23d
TN
989 * buffer.c (Fmove_overlay): Reinstate the earlier fix for
990 Bug#9642, but explicitly check that the buffer the overlay would
991 be moved to is live and rearrange lines to make sure that errors
992 will not put the overlay in an inconsistent state.
993 (Fdelete_overlay): Cosmetics.
994
85d0efd1
EZ
9952012-05-28 Eli Zaretskii <eliz@gnu.org>
996
997 * w32term.c (my_bring_window_to_top): New function.
998 (x_raise_frame): Use handle returned by DeferWindowPos, which
61b108cc
SM
999 could be different from the original one.
1000 Call my_bring_window_to_top instead of my_set_foreground_window.
85d0efd1
EZ
1001 (Bug#11513)
1002
1003 * w32fns.c (w32_wnd_proc): Accept and process WM_EMACS_BRINGTOTOP
1004 by calling BringWindowToTop.
1005
1006 * w32term.h (WM_EMACS_BRINGTOTOP): New message.
1007 (WM_EMACS_END): Increase by one.
1008
da92a98c
PE
10092012-05-28 Paul Eggert <eggert@cs.ucla.edu>
1010
1011 * bidi.c (bidi_mirror_char): Put eassert before conversion to int.
1012 This avoids undefined behavior that might cause the eassert
1013 to not catch an out-of-range value.
1014
74d1f848
JB
10152012-05-28 Juanma Barranquero <lekktu@gmail.com>
1016
1017 * makefile.w32-in ($(BLD)/w32inevt.$(O), $(BLD)/w32console.$(O)):
1018 Update dependencies.
1019
9e1a06fc
EZ
10202012-05-27 Eli Zaretskii <eliz@gnu.org>
1021
1022 * bidi.c (bidi_mirror_char): Fix last change.
1023
f3dd7312
AS
10242012-05-27 Andreas Schwab <schwab@linux-m68k.org>
1025
1026 * unexmacosx.c (copy_data_segment): Truncate after 16 characters
1027 when referring to sectname field in printf format.
1028
81899c91
PE
10292012-05-27 Paul Eggert <eggert@cs.ucla.edu>
1030
57b81a9f
PE
1031 * lisp.h [REL_ALLOC]: Omit duplicate prototypes.
1032 Only r_alloc_inhibit_buffer_relocation needed to be added;
1033 the others were already declared.
1034
81899c91
PE
1035 * bidi.c (bidi_mirror_char): Don't possibly truncate the integer
1036 before checking whether it's out of range. Put the check inside
1037 eassert. See
1038 <http://lists.gnu.org/archive/html/emacs-devel/2012-05/msg00485.html>.
1039
33017faf 10402012-05-27 Ken Brown <kbrown@cornell.edu>
2f9b9adb
KB
1041
1042 * callproc.c (Fcall_process): Restore a line that was accidentally
1043 commented out in the 2011-02-13 change (bug#11547).
1044
33017faf 10452012-05-27 Eli Zaretskii <eliz@gnu.org>
52c55cc7
EZ
1046
1047 * lisp.h [REL_ALLOC]: Add prototypes for external functions
1048 defined on ralloc.c.
1049
1050 * buffer.c [REL_ALLOC]: Remove prototypes of
1051 r_alloc_reset_variable, r_alloc, r_re_alloc, and r_alloc_free,
1052 they are now on lisp.h.
1053
1054 * ralloc.c (r_alloc_inhibit_buffer_relocation): New function.
1055
1056 * search.c (search_buffer): Use it to inhibit relocation of buffer
1057 text while re_search_2 is doing its job, because re_search_2 is
1058 passed C pointers to buffer text. (Bug#11519)
1059
23415acf
EZ
1060 * msdos.c (internal_terminal_init) <Vwindow_system_version>:
1061 Update value to 24.
1062
44e27368
EZ
1063 * xdisp.c (move_it_to): Under MOVE_TO_Y, when restoring iterator
1064 state after an additional call to move_it_in_display_line_to, keep
1065 the values of it->max_ascent and it->max_descent found for the
1066 entire line.
1067 (pos_visible_p): Revert the comparison against bottom_y to what it
1068 was in revid eliz@gnu.org-20120513182235-4p6386j761ld0nwb.
1069 (Bug#11464)
1070
c1892f11
PE
10712012-05-26 Paul Eggert <eggert@cs.ucla.edu>
1072
1073 Fix coding-related core dumps with gcc -ftrapv.
1074 The code was computing A - B, where A and B are pointers, and B is
1075 random garbage. This can lead to core dumps on platforms that
1076 have special pointer registers, and it also leads to core dumps on
1077 x86-64 when compiled with gcc -ftrapv. The fix is to compute
1078 A - B only when B is initialized properly.
1079 * coding.c (coding_set_source, coding_set_destination): Return void.
1080 (coding_change_source, coding_change_destinations): New functions,
1081 with the old behaviors of coding_set_source and coding_set_destination.
1082 All callers that need an offset changed to use these new functions.
1083
eb7afdad
GM
10842012-05-26 Glenn Morris <rgm@gnu.org>
1085
1086 * nsterm.m (ns_init_paths): Don't mess with INFOPATH. (Bug#2791)
1087
f12fdf02
EZ
10882012-05-26 Eli Zaretskii <eliz@gnu.org>
1089
53a63be6 1090 Extend mouse support on W32 text-mode console.
61b108cc
SM
1091 * xdisp.c (draw_row_with_mouse_face):
1092 Call tty_draw_row_with_mouse_face for WINDOWSNT as well.
eb3f6f01 1093
eb3f6f01 1094 * w32console.c: Include window.h.
61b108cc
SM
1095 (w32con_write_glyphs_with_face, tty_draw_row_with_mouse_face):
1096 New functions.
eb3f6f01
EZ
1097 (initialize_w32_display): Initialize mouse-highlight data.
1098
53a63be6
EZ
1099 * w32inevt.c: Include termchar.h and window.h.
1100 (do_mouse_event): Support mouse-autoselect-window. When the mouse
1101 moves, call note_mouse_highlight. If help_echo changed, call
1102 gen_help_event to produce help-echo message in the echo area.
1103 Call clear_mouse_face if mouse_face_hidden is set in the mouse
1104 highlight info.
1105
4cfd81f6
PE
11062012-05-26 Paul Eggert <eggert@cs.ucla.edu>
1107
1108 * lread.c (read1): Simplify slightly to avoid an overflow warning
1109 with GCC 4.7.0 on x86-64.
1110
4446092a
EZ
11112012-05-26 Eli Zaretskii <eliz@gnu.org>
1112
1113 * bidi.c (bidi_mirror_char): Revert last change: an int is
1114 definitely wide enough here.
1115
42b2a986 11162012-05-25 Paul Eggert <eggert@cs.ucla.edu>
3164aeac 1117
42b2a986 1118 Fix integer width and related bugs (Bug#9874).
eb106a49 1119 * alloc.c (pure_bytes_used_lisp, pure_bytes_used_non_lisp):
d311d28c
PE
1120 (allocate_vectorlike, buffer_memory_full, struct sdata, SDATA_SIZE)
1121 (string_bytes, check_sblock, allocate_string_data):
1122 (compact_small_strings, Fmake_bool_vector, make_string)
1123 (make_unibyte_string, make_multibyte_string)
1124 (make_string_from_bytes, make_specified_string)
1125 (allocate_vectorlike, Fmake_vector, find_string_data_in_pure)
1126 (make_pure_string, make_pure_c_string, make_pure_vector, Fpurecopy)
1127 (mark_vectorlike):
1128 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1129 (allocate_pseudovector):
1130 Use int, not EMACS_INT, where int is wide enough.
1131 (inhibit_garbage_collection, Fgarbage_collect):
1132 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1133 * bidi.c (bidi_mirror_char): Use EMACS_INT, not int, where
1134 int might not be wide enough.
1135 (bidi_cache_search, bidi_cache_find, bidi_init_it)
1136 (bidi_count_bytes, bidi_char_at_pos, bidi_fetch_char)
1137 (bidi_at_paragraph_end, bidi_find_paragraph_start)
1138 (bidi_paragraph_init, bidi_resolve_explicit, bidi_resolve_weak)
1139 (bidi_level_of_next_char, bidi_move_to_visually_next):
1140 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1141 * buffer.c (copy_overlays, Fgenerate_new_buffer_name)
1142 (Fkill_buffer, Fset_buffer_major_mode)
1143 (advance_to_char_boundary, Fbuffer_swap_text)
1144 (Fset_buffer_multibyte, overlays_at, overlays_in)
1145 (overlay_touches_p, struct sortvec, record_overlay_string)
1146 (overlay_strings, recenter_overlay_lists)
1147 (adjust_overlays_for_insert, adjust_overlays_for_delete)
1148 (fix_start_end_in_overlays, fix_overlays_before, modify_overlay)
1149 (Fmove_overlay, Fnext_overlay_change, Fprevious_overlay_change)
1150 (Foverlay_recenter, last_overlay_modification_hooks_used)
1151 (report_overlay_modification, evaporate_overlays, enlarge_buffer_text):
1152 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
977b0e45
PE
1153 (validate_region): Omit unnecessary test for b <= e,
1154 since that's guaranteed by the previous test.
d311d28c
PE
1155 (adjust_overlays_for_delete): Avoid pos + length overflow.
1156 (Fmove_overlay, Fdelete_overlay, add_overlay_mod_hooklist)
1157 (report_overlay_modification):
1158 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1159 (Foverlays_at, Fnext_overlay_change, Fprevious_overlay_change):
1160 Omit pointer cast, which isn't needed anyway, and doesn't work
1161 after the EMACS_INT -> ptrdiff_t change.
02481186 1162 (Fmove_overlay): Clip BEG and END to ptrdiff_t to avoid overflow.
d311d28c
PE
1163 * buffer.h: Adjust decls to match defn changes elsewhere.
1164 (struct buffer_text, struct buffer):
1165 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1166 Use EMACS_INT, not int, where int might not be wide enough.
39b5db3b
PE
1167 * bytecode.c (unmark_byte_stack, exec_byte_code): Use ptrdiff_t,
1168 not int, to avoid needless 32-bit limit on 64-bit hosts.
1169 (exec_byte_code): Use tighter memory-full test, one that checks
1170 for alloca overflow. Don't compute the address of the object just
1171 before an array, as that's not portable. Use EMACS_INT, not
1172 ptrdiff_t or int, where ptrdiff_t or int might not be wide enough.
d311d28c
PE
1173 * callint.c (Fcall_interactively):
1174 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1175 * callproc.c (call_process_kill, Fcall_process):
1176 Don't assume pid_t fits into an Emacs fixnum.
1177 (call_process_cleanup, Fcall_process, child_setup):
1178 Don't assume pid_t fits into int.
1179 (call_process_cleanup, Fcall_process, delete_temp_file)
1180 (Fcall_process_region):
1181 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1182 (Fcall_process): Simplify handling of volatile integers.
1183 Use int, not EMACS_INT, where int will do.
1184 * casefiddle.c (casify_object, casify_region, operate_on_word)
1185 (Fupcase_word, Fdowncase_word, Fcapitalize_word):
1186 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1187 (casify_object): Avoid integer overflow when overallocating buffer.
1188 * casetab.c (set_identity, shuffle): Prefer int to unsigned when
45c2afd6 1189 either works. Use lint_assume to convince GCC 4.6.1 that it's OK.
d311d28c
PE
1190 * category.c (Fchar_category_set): Don't assume fixnum fits in int.
1191 * category.h (CATEGORYP): Don't assume arg is nonnegative.
1192 * ccl.c (GET_CCL_INT): Remove; no longer needed, since the
1193 integers are now checked earlier. All uses replaced with XINT.
1194 (ccl_driver):
1195 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1196 For CCL_MapSingle, check that content and value are in int range.
c801946a
PE
1197 (ccl_driver, Fregister_code_conversion_map):
1198 Check that Vcode_version_map_vector is a vector.
d311d28c
PE
1199 (resolve_symbol_ccl_program): Check that vector header is in range.
1200 Always copy the vector, so that we can check its contents reliably
1201 now rather than having to recheck each instruction as it's being
1202 executed. Check that vector words fit in 'int'.
1203 (ccl_get_compiled_code, Fregister_ccl_program)
1204 (Fregister_code_conversion_map): Use ptrdiff_t, not int, for
1205 program indexes, to avoid needless 32-bit limit on 64-bit hosts.
1206 (Fccl_execute, Fccl_execute_on_string): Check that initial reg
1207 contents are in range.
1208 (Fccl_execute_on_string): Check that status is in range.
1209 * ccl.h (struct ccl_program.idx): Now ptrdiff_t, not int.
1210 * character.c (char_resolve_modifier_mask, Fchar_resolve_modifiers):
1211 Accept and return EMACS_INT, not int, because callers can pass values
1212 out of 'int' range.
1213 (c_string_width, strwidth, lisp_string_width, chars_in_text)
1214 (multibyte_chars_in_text, parse_str_as_multibyte)
1215 (str_as_multibyte, count_size_as_multibyte, str_to_multibyte)
1216 (str_as_unibyte, str_to_unibyte, string_count_byte8)
1217 (string_escape_byte8, Fget_byte):
1218 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
a14e1568 1219 (Funibyte_string): Use CHECK_RANGED_INTEGER, not CHECK_NATNUM, to
d311d28c
PE
1220 avoid mishandling large integers.
1221 * character.h: Adjust decls to match defn changes elsewhere.
1222 * charset.c (load_charset_map_from_file, find_charsets_in_text)
1223 (Ffind_charset_region):
1224 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1225 (load_charset_map_from_file): Redo idx calculation to avoid overflow.
1226 (load_charset_map_from_vector, Fdefine_charset_internal):
3c7649c1 1227 Don't assume fixnum fits in int.
d311d28c
PE
1228 (load_charset_map_from_vector, Fmap_charset_chars):
1229 Remove now-unnecessary CHECK_NATNUMs.
1230 (Fdefine_charset_internal): Check ranges here, more carefully.
3c7649c1
PE
1231 Don't rely on undefined behavior with signed left shift overflow.
1232 Don't assume unsigned int fits into fixnum, or that fixnum fits
1233 into unsigned int. Don't require max_code to be a valid fixnum;
1234 that's not true for gb10830 4-byte on a 32-bit host. Allow
1235 invalid_code to be a cons, for the same reason. Require code_offset
1236 to be a character. Avoid int overflow if max_char is close
1237 to INT_MAX.
1238 (CODE_POINT_TO_INDEX): On 32-bit hosts, return int, not unsigned;
1239 this is intended anyway and avoids some undefined behavior.
1240 (load_charset_map): Pass unsigned, not int, as 2nd arg of
1241 INDEX_TO_CODE_POINT, as that's what it expects.
1242 (Funify_charset, encode_char): Don't stuff unsigned vals into int vars.
60ad3eab
PE
1243 * charset.h (DECODE_CHAR): Return int, not unsigned;
1244 this is what was intended anyway, and it avoids undefined behavior.
1245 (CHARSET_OFFSET): Remove unused macro, instead of fixing its
1246 integer-overflow issues.
1247 (ENCODE_CHAR): Return unsigned on all hosts, not just on 32-bit hosts.
1248 Formerly, it returned EMACS_INT on 64-bit hosts in the common case
1249 where the argument is EMACS_INT, and this behavior is not intended.
d311d28c
PE
1250 * chartab.c (Fmake_char_table, Fset_char_table_range)
1251 (uniprop_get_decoder, uniprop_get_encoder):
1252 Don't assume fixnum fits in int.
1253 * cmds.c (move_point): New function, that does the gist of
1254 Fforward_char and Fbackward_char, but does so while checking
1255 for integer overflow more accurately.
c96e5d6a 1256 (Fforward_char, Fbackward_char): Use it.
d311d28c
PE
1257 (Fforward_line, Fend_of_line, internal_self_insert)
1258 (internal_self_insert):
1259 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1260 Fix a FIXME, by checking for integer overflow when calculating
1261 target_clm and actual_clm.
1262 * coding.c (detect_coding_XXX, encode_coding_XXX, CODING_DECODE_CHAR)
8f50130c 1263 (CODING_ENCODE_CHAR, CODING_CHAR_CHARSET, CODING_CHAR_CHARSET_P)
d311d28c
PE
1264 (ASSURE_DESTINATION, coding_alloc_by_realloc)
1265 (coding_alloc_by_making_gap, alloc_destination)
1266 (detect_coding_utf_8, encode_coding_utf_8, decode_coding_utf_16)
1267 (encode_coding_utf_16, detect_coding_emacs_mule)
1268 (decode_coding_emacs_mule, encode_coding_emacs_mule)
1269 (detect_coding_iso_2022, decode_coding_iso_2022)
1270 (encode_invocation_designation, encode_designation_at_bol)
1271 (encode_coding_iso_2022, detect_coding_sjis, detect_coding_big5)
1272 (decode_coding_sjis, decode_coding_big5, encode_coding_sjis)
1273 (encode_coding_big5, detect_coding_ccl, decode_coding_ccl)
1274 (encode_coding_ccl, encode_coding_raw_text)
1275 (detect_coding_charset, decode_coding_charset)
1276 (encode_coding_charset, detect_eol, decode_eol, produce_chars)
1277 (produce_composition, produce_charset, produce_annotation)
1278 (decode_coding, handle_composition_annotation)
1279 (handle_charset_annotation, consume_chars, decode_coding_gap)
1280 (decode_coding_object, encode_coding_object, detect_coding_system)
1281 (Ffind_coding_systems_region_internal, Fcheck_coding_systems_region)
1282 (code_convert_region, code_convert_string)
8f50130c
PE
1283 (Fdefine_coding_system_internal)
1284 (coding_set_source, coding_set_destination):
d311d28c
PE
1285 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1286 (setup_iso_safe_charsets, consume_chars, Funencodable_char_position)
1287 (Fdefine_coding_system_internal):
1288 Don't assume fixnums fit in int.
1289 (decode_coding_gap, decode_coding_object, encode_coding_object)
5895d7b9 1290 (Fread_coding_system, Fdetect_coding_region)
2c6a9faa
PE
1291 (Funencodable_char_position, Fcheck_coding_systems_region)
1292 (get_translation, handle_composition_annotation, consume_chars):
d311d28c 1293 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
977b0e45 1294 (consume_chars): Rewrite to not calculate an address outside buffer.
d311d28c 1295 (Ffind_operation_coding_system): NATNUMP can eval its arg twice.
7b09a37a 1296 Don't access memory outside of the args array.
d311d28c 1297 (Fdefine_coding_system_internal): Check for charset-id overflow.
47664caa
PE
1298 (ENCODE_ISO_CHARACTER): Use unsigned, not int, to store the unsigned
1299 result of ENCODE_CHAR.
d311d28c
PE
1300 * coding.h: Adjust decls to match defn changes elsewhere.
1301 (struct coding_system):
1302 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1303 * composite.c (get_composition_id, find_composition)
1304 (run_composition_function, update_compositions)
1305 (compose_text, composition_gstring_put_cache)
1306 (composition_gstring_p, composition_gstring_width)
1307 (fill_gstring_header, fill_gstring_body, autocmp_chars)
1308 (composition_compute_stop_pos, composition_reseat_it)
1309 (composition_update_it, struct position_record)
1310 (find_automatic_composition, composition_adjust_point)
1311 (Fcomposition_get_gstring, Ffind_composition_internal):
1312 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1313 (update_compositions):
1314 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1315 * composite.h: Adjust decls to match defn changes elsewhere.
1316 (struct composition):
1317 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1318 * data.c (let_shadows_buffer_binding_p, let_shadows_global_binding_p):
1319 Do not attempt to compute the address of the object just before a
1320 buffer; this is not portable.
1321 (Faref, Faset):
1322 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1323 (Faset): Use int, not EMACS_INT, where int is wide enough.
1324 (Fstring_to_number): Don't assume fixnums fit in int.
1325 (Frem): Don't assume arg is nonnegative.
1326 * dbusbind.c (xd_append_arg): Check for integers out of range.
1327 (Fdbus_call_method): Don't overflow the timeout int.
42b2a986 1328 (extract_signed, extract_unsigned): New functions.
243e0530
PE
1329 (XD_CHECK_DBUS_SERIAL): Remove; superseded by extract_unsigned.
1330 (xd_get_connection_references): Return ptrdiff_t, not int.
1331 All uses changed.
1332 (xd_signature, xd_append_arg, xd_retrieve_arg, Fdbus_message_internal)
1333 (xd_read_message_1):
1334 Use int, not unsigned, where the dbus API uses int.
1335 (Fdbus_message_internal): Don't overflow mtype.
1336 (syms_of_dbusbind): Allocate right-sized buffer for integers.
d311d28c
PE
1337 * dired.c (directory_files_internal, file_name_completion, scmp)
1338 (file_name_completion_stat):
1339 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1340 (file_name_completion): Don't overflow matchcount.
1341 (file_name_completion_stat): Use SAFE_ALLOCA, not alloca.
1342 * dispextern.h: Adjust decls to match defn changes elsewhere.
1343 (struct text_pos, struct glyph, struct bidi_saved_info)
1344 (struct bidi_string_data, struct bidi_it, struct composition_it)
1345 (struct it):
1346 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1347 (struct display_pos, struct composition_it, struct it):
1348 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1349 * dispnew.c (increment_matrix_positions)
1350 (increment_row_positions, mode_line_string)
1351 (marginal_area_string):
1352 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
54e1617f 1353 (change_frame_size_1, Fredisplay, Fframe_or_buffer_changed_p):
d311d28c
PE
1354 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1355 (duration_to_sec_usec): New function, to check for overflow better.
1356 (Fsleep_for, sit_for): Use it.
1357 * doc.c (get_doc_string, store_function_docstring):
1358 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1359 (get_doc_string, Fsnarf_documentation):
1360 Use int, not EMACS_INT, where int is wide enough.
1361 (get_doc_string):
1362 Use SAFE_ALLOCA, not alloca.
1363 Check for overflow when converting EMACS_INT to off_t.
1364 * doprnt.c (doprnt):
1365 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1366 * editfns.c (init_editfns, Fuser_uid, Fuser_real_uid):
1367 Don't assume uid_t fits into fixnum.
1368 (buildmark, Fgoto_char, overlays_around, find_field, Fdelete_field)
1369 (Ffield_string, Ffield_string_no_properties, Ffield_beginning)
1370 (Ffield_end, Fconstrain_to_field, Fline_beginning_position)
1371 (Fline_end_position, Fprevious_char, Fchar_after, Fchar_before)
1372 (general_insert_function)
1373 (Finsert_char, make_buffer_string, make_buffer_string_both)
1374 (update_buffer_properties, Fbuffer_substring)
1375 (Fbuffer_substring_no_properties, Fcompare_buffer_substrings)
1376 (Fsubst_char_in_region, check_translation)
1377 (Ftranslate_region_internal, save_restriction_restore, Fformat)
1378 (transpose_markers, Ftranspose_regions):
1379 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1380 (clip_to_bounds): Move to lisp.h as an inline function).
1381 (Fconstrain_to_field): Don't assume integers are nonnegative.
1382 (Fline_beginning_position, Fsave_excursion, Fsave_current_buffer):
1383 (Fsubst_char_in_region, Fsave_restriction):
1384 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1385 (Femacs_pid): Don't assume pid_t fits into fixnum.
1386 (lo_time): Use int, not EMACS_INT, when int suffices.
1387 (lisp_time_argument): Check for usec out of range.
1388 (Fencode_time): Don't assume fixnum fits in int.
3f4eabd1
PE
1389 (Fuser_login_name, Fuser_full_name): Signal an error
1390 if a uid argument is out of range, rather than relying on
1391 undefined behavior.
c8d5c857
PE
1392 (Fformat_time_string): Remove now-unnecessary check.
1393 lisp_time_argument checks for out-of-range usec now.
243e0530 1394 Use ptrdiff_t, not size_t, where ptrdiff_t will do.
d311d28c
PE
1395 * emacs.c (gdb_valbits, gdb_gctypebits): Now int, not EMACS_INT.
1396 (gdb_data_seg_bits): Now uintptr_t, not EMACS_INT.
1397 (PVEC_FLAG, gdb_array_mark_flag): Now ptrdiff_t, not EMACS_INT.
1398 (init_cmdargs, Fdump_emacs):
1399 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1400 (Fkill_emacs): Don't assume fixnum fits in int; instead, take just
1401 the bottom (typically) 32 bits of the fixnum.
1402 * eval.c (specpdl_size, call_debugger):
1403 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1404 (when_entered_debugger, Fbacktrace_debug):
1405 Don't assume fixnum can fit in int.
1406 (Fdefvaralias, Fdefvar): Do not attempt to compute the address of
1407 the object just before a buffer; this is not portable.
1408 (FletX, Flet, Funwind_protect, do_autoload, Feval, funcall_lambda)
1409 (grow_specpdl, unbind_to):
1410 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1411 (Fapply, apply_lambda): Don't assume ptrdiff_t can hold fixnum.
1412 (grow_specpdl): Simplify allocation by using xpalloc.
856bbc81 1413 (Fprog1, Fprog2): Don't assume list length fits in int. Simplify.
d311d28c
PE
1414 * fileio.c (Ffind_file_name_handler, Fcopy_file, Frename_file)
1415 (Finsert_file_contents, Fwrite_region, Fdo_auto_save):
1416 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1417 (Ffind_file_name_handler, non_regular_inserted, Finsert_file_contents)
1418 (a_write, e_write):
1419 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1420 (Fcopy_file, non_regular_nbytes, read_non_regular)
1421 (Finsert_file_contents):
1422 Use int, not EMACS_INT, where int is wide enough.
1423 (READ_BUF_SIZE): Verify that it fits in int.
1424 (Finsert_file_contents): Check that counts are in proper range,
1425 rather than assuming fixnums fit into ptrdiff_t etc.
1426 Don't assume fixnums fit into int.
125b3835 1427 * floatfns.c (Fexpt): Avoid undefined signed * signed overflow.
5895d7b9
PE
1428 * fns.c (Fcompare_strings, Fstring_lessp, struct textprop_rec, concat)
1429 (string_char_byte_cache_charpos, string_char_byte_cache_bytepos)
d311d28c
PE
1430 (string_char_to_byte, string_byte_to_char)
1431 (string_make_multibyte, string_to_multibyte)
1432 (string_make_unibyte, Fstring_as_unibyte, Fstring_as_multibyte)
1433 (Fstring_to_unibyte, Fsubstring, Fsubstring_no_properties)
1434 (substring_both, Fdelete, internal_equal, Ffillarray)
1435 (Fclear_string, mapcar1)
1436 (Fbase64_encode_region, Fbase64_encode_string, base64_encode_1)
1437 (Fbase64_decode_region, Fbase64_decode_string, base64_decode_1)
1438 (larger_vector, make_hash_table, maybe_resize_hash_table)
1439 (hash_lookup, hash_remove_from_table, hash_clear, sweep_weak_table)
1440 (Fmaphash, secure_hash):
1441 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1442 (concat): Check for string index and length overflow.
1443 (Fmapconcat): Don't assume fixnums fit into ptrdiff_t.
1444 (Frequire):
1445 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1446 (larger_vector): New API (vec, incr_min, size_max) replaces old
1447 one (vec, new_size, init). This catches size overflow.
1448 INIT was removed because it was always Qnil.
1449 All callers changed.
1450 (INDEX_SIZE_BOUND): New macro, which calculates more precisely
1451 the upper bound on a hash table index size.
1452 (make_hash_table, maybe_resize_hash_table): Use it.
1453 (secure_hash): Computer start_byte and end_byte only after
1454 they're known to be in ptrdiff_t range.
1455 * font.c (font_intern_prop, font_at, font_range, Ffont_shape_gstring)
1456 (Ffont_get_glyphs, Ffont_at):
1457 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1458 (font_style_to_value, font_prop_validate_style, font_expand_wildcards)
1459 (Flist_fonts, Fopen_font):
1460 Don't assume fixnum can fit in int.
1461 (check_gstring): Don't assume index can fit in int.
1462 (font_match_p): Check that fixnum is a character, not a nonnegative
1463 fixnum, since the later code needs to stuff it into an int.
1464 (font_find_for_lface): Use SAFE_ALLOCA_LISP, not alloca.
1465 (font_fill_lglyph_metrics): Use unsigned, not EMACS_INT, to avoid
1466 conversion overflow issues.
1467 (Fopen_font): Check for integer out of range.
1468 (Ffont_get_glyphs): Don't assume index can fit in int.
1469 * font.h: Adjust decls to match defn changes elsewhere.
1470 * fontset.c (reorder_font_vector): Redo score calculation to avoid
1471 integer overflow.
1472 (num_auto_fontsets, fontset_from_font): Use ptrdiff_t, not
1473 printmax_t, where ptrdiff_t is wide enough.
1474 (Finternal_char_font):
1475 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1476 * frame.c (Fset_mouse_position, Fset_mouse_pixel_position)
1477 (Fset_frame_height, Fset_frame_width, Fset_frame_size)
1478 (Fset_frame_position, x_set_frame_parameters)
1479 (x_set_line_spacing, x_set_border_width)
1480 (x_set_internal_border_width, x_set_alpha, x_figure_window_size):
1481 Check that fixnums are in proper range for system types.
1482 (frame_name_fnn_p, Fframe_parameter, Fmodify_frame_parameters):
1483 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1484 (Fmodify_frame_parameters): Don't assume fixnum fits in int.
1485 Use SAFE_ALLOCA_LISP, not alloca.
1486 * frame.h (struct frame): Use intptr_t, not EMACS_INT, where
1487 intptr_t is wide enough.
1488 * fringe.c (lookup_fringe_bitmap, get_logical_fringe_bitmap)
1489 (Fdefine_fringe_bitmap): Don't assume fixnum fits in int.
1490 (Ffringe_bitmaps_at_pos): Don't assume index fits in int.
1491 Check for fixnum out of range.
1492 * ftfont.c (ftfont_list): Don't assume index fits in int.
1493 Check that fixnums are in proper range for system types.
1494 (ftfont_shape_by_flt):
1495 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
d311d28c
PE
1496 * gnutls.c (emacs_gnutls_write, emacs_gnutls_read):
1497 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1498 (Fgnutls_error_fatalp, Fgnutls_error_string, Fgnutls_boot):
1499 Check that fixnums are in proper range for system types.
1500 * gnutls.h: Adjust decls to match defn changes elsewhere.
1501 * gtkutil.c (xg_dialog_run):
1502 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1503 (update_frame_tool_bar):
1504 Check that fixnums are in proper range for system types.
1505 * image.c (parse_image_spec): Redo count calculation to avoid overflow.
5895d7b9 1506 (lookup_image): Check that fixnums are in range for system types.
d311d28c
PE
1507 * indent.c (last_known_column, last_known_column_point):
1508 (current_column_bol_cache):
1509 (skip_invisible, current_column, check_display_width):
1510 (check_display_width, scan_for_column, current_column_1)
1511 (Findent_to, Fcurrent_indentation, position_indentation)
1512 (indented_beyond_p, Fmove_to_column, compute_motion):
1513 (Fcompute_motion, Fvertical_motion):
1514 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1515 (last_known_column_modified): Use EMACS_INT, not int.
1516 (check_display_width):
1517 (Fcompute_motion):
1518 Check that fixnums and floats are in proper range for system types.
1519 (compute_motion): Don't assume index or fixnum fits in int.
1520 (compute_motion, Fcompute_motion):
1521 Use int, not EMACS_INT, when it is wide enough.
1522 (vmotion): Omit local var start_hpos that is always 0; that way
1523 we don't need to worry about overflow in expressions involving it.
1524 * indent.h: Adjust decls to match defn changes elsewhere.
1525 (struct position):
1526 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1527 Use int, not EMACS_INT, where int is wide enough.
1528 Remove unused members ovstring_chars_done and tab_offset;
1529 all uses removed.
1530 * insdel.c (move_gap, move_gap_both, gap_left, gap_right)
1531 (adjust_markers_for_delete, adjust_markers_for_insert, adjust_point)
1532 (adjust_markers_for_replace, make_gap_larger, make_gap_smaller)
1533 (make_gap, copy_text, insert, insert_and_inherit)
1534 (insert_before_markers, insert_before_markers_and_inherit)
1535 (insert_1, count_combining_before, count_combining_after)
1536 (insert_1_both, insert_from_string)
1537 (insert_from_string_before_markers, insert_from_string_1)
1538 (insert_from_gap, insert_from_buffer, insert_from_buffer_1)
1539 (adjust_after_replace, adjust_after_insert, replace_range)
1540 (replace_range_2, del_range, del_range_1, del_range_byte)
1541 (del_range_both, del_range_2, modify_region)
1542 (prepare_to_modify_buffer, signal_before_change)
1543 (signal_after_change, Fcombine_after_change_execute):
1544 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1545 * intervals.c (traverse_intervals, rotate_right, rotate_left)
1546 (balance_an_interval, split_interval_right, split_interval_left)
1547 (find_interval, next_interval, update_interval)
1548 (adjust_intervals_for_insertion, delete_node, delete_interval)
1549 (interval_deletion_adjustment, adjust_intervals_for_deletion)
1550 (static_offset_intervals, offset_intervals)
1551 (merge_interval_right, merge_interval_left, make_new_interval)
1552 (graft_intervals_into_buffer, temp_set_point_both)
1553 (temp_set_point, set_point, adjust_for_invis_intang)
1554 (set_point_both, move_if_not_intangible, get_property_and_range)
1555 (get_local_map, copy_intervals, copy_intervals_to_string)
1556 (compare_string_intervals, set_intervals_multibyte_1):
1557 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1558 * intervals.h: Adjust decls to match defn changes elsewhere.
1559 (struct interval):
1560 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1561 * keyboard.c (this_command_key_count, this_single_command_key_start)
1562 (before_command_key_count, before_command_echo_length, echo_now)
1563 (echo_length, recursive_edit_1, Frecursive_edit, Ftrack_mouse)
1564 (command_loop_1, safe_run_hooks, read_char, timer_check_2)
1565 (menu_item_eval_property, read_key_sequence, Fread_key_sequence)
1566 (Fread_key_sequence_vector, Fexecute_extended_command, Fsuspend_emacs):
1567 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1568 (last_non_minibuf_size, last_point_position, echo_truncate)
1569 (command_loop_1, adjust_point_for_property, read_char, gen_help_event)
1570 (make_lispy_position, make_lispy_event, parse_modifiers_uncached)
1571 (parse_modifiers, modify_event_symbol, Fexecute_extended_command)
1572 (stuff_buffered_input):
1573 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1574 (last_auto_save, command_loop_1, read_char):
1575 Use EMACS_INT, not int, to avoid integer overflow.
1576 (record_char): Avoid overflow in total_keys computation.
1577 (parse_modifiers_uncached): Redo index calculation to avoid overflow.
1578 * keyboard.h: Adjust decls to match defn changes elsewhere.
1579 * keymap.c (Fdefine_key, Fcurrent_active_maps, accessible_keymaps_1)
1580 (Fkey_description, Fdescribe_vector, Flookup_key):
1581 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1582 (click_position): New function, to check that positions are in range.
1583 (Fcurrent_active_maps):
1584 (describe_command):
1585 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1586 (Faccessible_keymaps, Fkey_description):
1587 (preferred_sequence_p):
1588 Don't assume fixnum can fit into int.
1589 (Fkey_description): Use SAFE_ALLOCA_LISP, not alloca.
1590 Check for integer overflow in size calculations.
1591 (Ftext_char_description): Use CHECK_CHARACTER, not CHECK_NUMBER, to
1592 avoid mishandling large integers.
1593 * lisp.h: Adjust decls to match defn changes elsewhere.
1594 (ARRAY_MARK_FLAG, PSEUDOVECTOR_FLAG, struct Lisp_String)
1595 (struct vectorlike_header, struct Lisp_Subr, struct Lisp_Hash_Table)
1596 (struct Lisp_Marker):
1597 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1598 (clip_to_bounds): Now an inline function, moved here from editfns.c.
d311d28c
PE
1599 (GLYPH_CODE_P): Check for overflow in system types, subsuming the
1600 need for GLYPH_CODE_CHAR_VALID_P and doing proper checking ourselves.
1601 All callers changed.
1602 (GLYPH_CODE_CHAR, GLYPH_CODE_FACE):
1603 Assume the arg has valid form, since it always does.
1604 (TYPE_RANGED_INTEGERP): Avoid bug when checking against a wide
1605 unsigned integer system type.
1606 (CHECK_RANGED_INTEGER, CHECK_TYPE_RANGED_INTEGER): New macros.
1607 (struct catchtag, specpdl_size, SPECPDL_INDEX, USE_SAFE_ALLOCA):
1608 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1609 (struct catchtag): Use EMACS_INT, not int, since it may be a fixnum.
1610 (duration_to_sec_usec): New decl.
1611 * lread.c (read_from_string_index, read_from_string_index_byte)
1612 (read_from_string_limit, readchar, unreadchar, openp)
1613 (read_internal_start, read1, oblookup):
1614 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1615 (Fload, readevalloop, Feval_buffer, Feval_region):
1616 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1617 (openp): Check for out-of-range argument to 'access'.
1618 (read1): Use int, not EMACS_INT, where int is wide enough.
1619 Don't assume fixnum fits into int.
6efdadfd 1620 Fix off-by-one error that can read outside a buffer.
1ab7b8ac
PE
1621 (read_filtered_event): Use duration_to_sec_usec
1622 to do proper overflow checking on durations.
d311d28c
PE
1623 * macros.c (Fstart_kbd_macro): Use xpalloc to check for overflow
1624 in size calculation.
1625 (Fexecute_kbd_macro):
1626 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1627 * marker.c (cached_charpos, cached_bytepos, CONSIDER)
1628 (byte_char_debug_check, buf_charpos_to_bytepos, verify_bytepos)
1629 (buf_bytepos_to_charpos, Fset_marker, set_marker_restricted)
1630 (set_marker_both, set_marker_restricted_both, marker_position)
1631 (marker_byte_position, Fbuffer_has_markers_at):
1632 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1633 (Fset_marker, set_marker_restricted): Don't assume fixnum fits in int.
61b108cc 1634 * menu.c (ensure_menu_items): Rename from grow_menu_items.
d311d28c
PE
1635 It now merely ensures that the menu is large enough, without
1636 necessarily growing it, as this avoids some integer overflow issues.
1637 All callers changed.
1638 (keymap_panes, parse_single_submenu, Fx_popup_menu):
1639 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1640 (parse_single_submenu, Fx_popup_menu): Don't assume fixnum fits in int.
1641 Use SAFE_ALLOCA_LISP, not alloca.
1642 (find_and_return_menu_selection): Avoid unnecessary casts of pointers
1643 to EMACS_INT. Check that fixnums are in proper range for system types.
1644 * minibuf.c (minibuf_prompt_width, string_to_object)
1645 (Fminibuffer_contents, Fminibuffer_contents_no_properties)
1646 (Fminibuffer_completion_contents, Ftry_completion, Fall_completions):
1647 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1648 (get_minibuffer, read_minibuf_unwind):
1649 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1650 (read_minibuf): Omit unnecessary arg BACKUP_N, which is always nil;
1651 this simplifies overflow checking. All callers changed.
1652 (read_minibuf, Fread_buffer, Ftry_completion, Fall_completions)
1653 (Ftest_completion):
1654 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1655 * nsfns.m (check_ns_display_info): Don't assume fixnum fits in long.
1656 (x_set_menu_bar_lines, x_set_tool_bar_lines, Fx_create_frame):
1657 Check that fixnums are in proper range for system types.
1658 (Fx_create_frame, Fx_show_tip):
1659 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1660 * nsfont.m (ns_findfonts, nsfont_list_family):
1661 Don't assume fixnum fits in long.
1662 * nsmenu.m (ns_update_menubar, ns_menu_show, ns_popup_dialog):
1663 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1664 (ns_update_menubar): Use intptr_t, not EMACS_INT, when intptr_t is
1665 wide enough.
17fdb222 1666 * nsselect.m (ns_get_local_selection, clean_local_selection_data):
d311d28c
PE
1667 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1668 * print.c (print_buffer_size, print_buffer_pos, print_buffer_pos_byte)
1669 (PRINTDECLARE, PRINTPREPARE):
1670 (strout, print_string):
1671 (print, print_preprocess, print_check_string_charset_prop)
1672 (print_object):
1673 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1674 (PRINTDECLARE):
1675 (temp_output_buffer_setup, Fprin1_to_string, print_object):
1676 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1677 (PRINTPREPARE): Use int, not ptrdiff_t, where int is wide enough.
d311d28c 1678 (printchar, strout): Use xpalloc to catch size calculation overflow.
0fd11aa5 1679 (Fexternal_debugging_output): Don't overflow EMACS_INT->int conversion.
d311d28c
PE
1680 (print_error_message): Use SAFE_ALLOCA, not alloca.
1681 (print_object): Use int, not EMACS_INT, where int is wide enough.
a8b7caa3
PE
1682 (print_depth, new_backquote_output, print_number_index):
1683 Use ptrdiff_t, not int, where int might not be wide enough.
d311d28c
PE
1684 * process.c (Fdelete_process): Don't assume pid fits into EMACS_INT.
1685 (Fset_process_window_size, Fformat_network_address)
1686 (get_lisp_to_sockaddr_size, set_socket_option, Fmake_network_process)
d44287d4 1687 (sigchld_handler):
d311d28c 1688 Check that fixnums are in proper range for system types.
d44287d4 1689 (Fsignal_process): Simplify by avoiding a goto.
d83cf4cc
PE
1690 Check for process-ids out of pid_t range rather than relying on
1691 undefined behavior.
e4d81efc 1692 (process_tick, update_tick): Use EMACS_INT, not int.
d311d28c
PE
1693 (Fformat_network_address, read_process_output, send_process)
1694 (Fprocess_send_region, status_notify):
1695 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1696 (Fformat_network_address, Fmake_serial_process, Fmake_network_process)
1697 (wait_reading_process_output, read_process_output, exec_sentinel):
1698 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1699 (conv_lisp_to_sockaddr): Don't assume fixnums fit into int.
1700 (Faccept_process_output): Use duration_to_sec_usec to do proper
1701 overflow checking on durations.
dde14581
PE
1702 (emacs_get_tty_pgrp, Fprocess_running_child_p, process_send_signal):
1703 Don't assume pid_t fits in int.
02481186
PE
1704 * process.h (struct Lisp_Process): Members tick and update_tick
1705 are now of type EMACS_INT, not int.
b62b53e8
PE
1706 * puresize.h (PURESIZE_RATIO): Shrink this to 8/6 on 32-bit hosts
1707 configured --with-wide-int.
d311d28c
PE
1708 * scroll.c (calculate_scrolling, calculate_direct_scrolling)
1709 (line_ins_del): Use int, not EMACS_INT, where int is wide enough.
1710 * search.c (looking_at_1, string_match_1):
1711 (fast_string_match, fast_c_string_match_ignore_case)
1712 (fast_string_match_ignore_case, fast_looking_at, scan_buffer)
1713 (scan_newline, find_before_next_newline, search_command)
1714 (trivial_regexp_p, search_buffer, simple_search, boyer_moore)
1715 (set_search_regs, wordify):
1716 (Freplace_match):
1717 (Fmatch_data):
1718 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1719 (string_match_1, search_buffer, set_search_regs):
1720 (Fmatch_data):
1721 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1722 (wordify): Check for overflow in size calculation.
1723 (Freplace_match): Avoid potential buffer overflow in search_regs.start.
1724 (Fset_match_data): Don't assume fixnum fits in ptrdiff_t.
1725 Check that fixnums are in proper range for system types.
1726 * sound.c (struct sound_device)
1727 (wav_play, au_play, vox_write, alsa_period_size, alsa_write):
1728 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1729 (Fplay_sound_internal):
1730 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
eacd378d 1731 * syntax.c (struct lisp_parse_state, find_start_modiff)
d311d28c
PE
1732 (Finternal_describe_syntax_value, scan_lists, scan_sexps_forward):
1733 (Fparse_partial_sexp):
1734 Don't assume fixnums can fit in int.
1735 (struct lisp_parse_state, find_start_pos, find_start_value)
1736 (find_start_value_byte, find_start_begv)
1737 (update_syntax_table, char_quoted, dec_bytepos)
1738 (find_defun_start, prev_char_comend_first, back_comment):
1739 (scan_words, skip_chars, skip_syntaxes, forw_comment, Fforward_comment)
1740 (scan_lists, Fbackward_prefix_chars, scan_sexps_forward):
1741 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1742 (Finternal_describe_syntax_value): Check that match_lisp is a
1743 character, not an integer, since the code stuffs it into int.
1744 (scan_words, scan_sexps_forward):
1745 Check that fixnums are in proper range for system types.
1746 (Fforward_word):
1747 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1748 (scan_sexps_forward):
1749 Use CHARACTERP, not INTEGERP, since the value must fit into int.
1750 (Fparse_partial_sexp): Fix doc; element 8 is not ignored.
1751 * syntax.h: Adjust decls to match defn changes elsewhere.
1752 (struct gl_state_s):
1753 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
e4ecdc9c
PE
1754 (SETUP_SYNTAX_TABLE_FOR_OBJECT): Use PTRDIFF_MAX, not
1755 MOST_POSITIVE_FIXNUM.
d311d28c
PE
1756 * sysdep.c (wait_for_termination_1, wait_for_termination)
1757 (interruptible_wait_for_termination, mkdir):
1758 Don't assume pid_t fits in int; on 64-bit AIX pid_t is 64-bit.
1759 (emacs_read, emacs_write):
1760 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
225a2cff
PE
1761 (system_process_attributes): Don't assume uid_t, gid_t, EMACS_INT,
1762 and double all fit in int.
d311d28c
PE
1763 * term.c (set_tty_color_mode):
1764 Check that fixnums are in proper range for system types.
1765 * termhooks.h (struct input_event):
1766 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1767 * textprop.c (validate_interval_range, interval_of)
1768 (Fadd_text_properties, set_text_properties_1)
1769 (Fremove_text_properties, Fremove_list_of_text_properties)
1770 (Ftext_property_any, Ftext_property_not_all)
1771 (copy_text_properties, text_property_list, extend_property_ranges)
1772 (verify_interval_modification):
1773 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1774 (Fnext_single_char_property_change)
1775 (Fprevious_single_char_property_change):
1776 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
5895d7b9
PE
1777 (copy_text_properties):
1778 Check for integer overflow in index calculation.
d311d28c
PE
1779 * undo.c (last_boundary_position, record_point, record_insert)
1780 (record_delete, record_marker_adjustment, record_change)
1781 (record_property_change):
1782 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1783 (truncate_undo_list, Fprimitive_undo): Don't assume fixnum fits in int.
1784 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1785 * w32fns.c (Fx_create_frame, x_create_tip_frame, Fx_show_tip)
1786 (Fx_hide_tip, Fx_file_dialog):
1787 * w32menu.c (set_frame_menubar):
1788 Use ptrdiff_t, not int, for consistency with rest of code.
1789 * window.c (window_scroll_preserve_hpos, window_scroll_preserve_vpos)
1790 (select_window, Fdelete_other_windows_internal)
1791 (window_scroll_pixel_based, window_scroll_line_based)
1792 (Frecenter, Fset_window_configuration):
1793 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1794 (Fset_window_hscroll, run_window_configuration_change_hook)
1795 (set_window_buffer, temp_output_buffer_show, scroll_command)
5895d7b9 1796 (Fscroll_other_window, Frecenter):
d311d28c
PE
1797 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1798 (Fwindow_line_height, window_scroll, Fscroll_left, Fscroll_right):
1799 Don't assume fixnum fits in int.
1800 (Fset_window_scroll_bars):
1801 Check that fixnums are in proper range for system types.
1802 * xdisp.c (help_echo_pos, pos_visible_p, string_pos_nchars_ahead)
1803 (string_pos, c_string_pos, number_of_chars, init_iterator)
1804 (in_ellipses_for_invisible_text_p, init_from_display_pos)
1805 (compute_stop_pos, next_overlay_change, compute_display_string_pos)
1806 (compute_display_string_end, handle_face_prop)
5895d7b9
PE
1807 (face_before_or_after_it_pos, handle_invisible_prop)
1808 (handle_display_prop, handle_display_spec, handle_single_display_spec)
d311d28c
PE
1809 (display_prop_intangible_p, string_buffer_position_lim)
1810 (string_buffer_position, handle_composition_prop, load_overlay_strings)
1811 (get_overlay_strings_1, get_overlay_strings)
1812 (iterate_out_of_display_property, forward_to_next_line_start)
1813 (back_to_previous_visible_line_start, reseat, reseat_to_string)
1814 (get_next_display_element, set_iterator_to_next)
1815 (get_visually_first_element, compute_stop_pos_backwards)
1816 (handle_stop_backwards, next_element_from_buffer)
1817 (move_it_in_display_line_to, move_it_in_display_line)
1818 (move_it_to, move_it_vertically_backward, move_it_by_lines)
1819 (add_to_log, message_dolog, message_log_check_duplicate)
1820 (message2, message2_nolog, message3, message3_nolog
1821 (with_echo_area_buffer, display_echo_area_1, resize_mini_window_1)
1822 (current_message_1, truncate_echo_area, truncate_message_1)
1823 (set_message, set_message_1, store_mode_line_noprop)
1824 (hscroll_window_tree, debug_delta, debug_delta_bytes, debug_end_vpos)
1825 (text_outside_line_unchanged_p, check_point_in_composition)
1826 (reconsider_clip_changes)
1827 (redisplay_internal, set_cursor_from_row, try_scrolling)
1828 (try_cursor_movement, set_vertical_scroll_bar, redisplay_window)
1829 (redisplay_window, find_last_unchanged_at_beg_row)
1830 (find_first_unchanged_at_end_row, row_containing_pos, try_window_id)
1831 (trailing_whitespace_p, find_row_edges, display_line)
1832 (RECORD_MAX_MIN_POS, Fcurrent_bidi_paragraph_direction)
1833 (display_mode_element, store_mode_line_string)
1834 (pint2str, pint2hrstr, decode_mode_spec)
1835 (display_count_lines, display_string, draw_glyphs)
1836 (x_produce_glyphs, x_insert_glyphs)
1837 (rows_from_pos_range, mouse_face_from_buffer_pos)
1838 (fast_find_string_pos, mouse_face_from_string_pos)
1839 (note_mode_line_or_margin_highlight, note_mouse_highlight):
1840 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1841 (safe_call, init_from_display_pos, handle_fontified_prop)
1842 (handle_single_display_spec, load_overlay_strings)
1843 (with_echo_area_buffer, setup_echo_area_for_printing)
1844 (display_echo_area, echo_area_display)
1845 (x_consider_frame_title, prepare_menu_bars, update_menu_bar)
1846 (update_tool_bar, hscroll_window_tree, redisplay_internal)
5895d7b9
PE
1847 (redisplay_window, dump_glyph_row, display_mode_line)
1848 (Fformat_mode_line, decode_mode_spec, on_hot_spot_p):
43ad2e9a 1849 (handle_display_spec, display_prop_string_p):
d311d28c
PE
1850 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1851 (handle_single_display_spec, build_desired_tool_bar_string)
1852 (redisplay_tool_bar, scroll_window_tree, Fdump_glyph_matrix)
1853 (get_specified_cursor_type):
1854 Check that fixnums are in proper range for system types.
1855 (struct overlay_entry, resize_mini_window, Fdump_glyph_row)
1856 (Flookup_image_map):
1857 Don't assume fixnums fit in int.
1858 (compare_overlay_entries):
1859 Avoid mishandling comparisons due to subtraction overflow.
1860 (load_overlay_strings): Use SAFE_NALLOCA, not alloca.
1861 (last_escape_glyph_face_id, last_glyphless_glyph_face_id):
1862 (handle_tool_bar_click):
1863 Use int, not unsigned, since we prefer signed and the signedness
1864 doesn't matter here.
1865 (get_next_display_element, next_element_from_display_vector):
1866 Use int, not EMACS_INT, when int is wide enough.
1867 (start_hourglass): Use duration_to_sec_usec to do proper
1868 overflow checking on durations.
1869 * xfaces.c (Fbitmap_spec_p):
1870 Check that fixnums are in proper range for system types.
1871 (compare_fonts_by_sort_order):
1872 Avoid mishandling comparisons due to subtraction overflow.
1873 (Fx_family_fonts, realize_basic_faces):
1874 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1875 (Fx_family_fonts):
1876 Don't assume fixnum fits in int.
1877 Use SAFE_ALLOCA_LISP, not alloca.
1878 (merge_face_heights): Remove unnecessary cast to EMACS_INT.
1879 (Finternal_make_lisp_face): Don't allocate more than MAX_FACE_ID.
1880 (face_at_buffer_position, face_for_overlay_string)
1881 (face_at_string_position):
1882 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1883 (merge_faces): Use int, not EMACS_INT, where int is wide enough.
1884 * xfns.c (x_set_menu_bar_lines, x_set_tool_bar_lines, x_icon_verify)
1885 (Fx_show_tip):
1886 Check that fixnums are in proper range for system types.
1887 (Fx_create_frame, x_create_tip_frame, Fx_show_tip)
1888 (Fx_hide_tip, Fx_file_dialog, Fx_select_font):
1889 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1890 (Fx_change_window_property): Don't assume fixnums fit in int.
1891 * xfont.c (xfont_chars_supported):
1892 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1893 * xmenu.c (Fx_popup_dialog, set_frame_menubar)
1894 (create_and_show_popup_menu, create_and_show_dialog, xmenu_show):
1895 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1896 * xml.c (parse_region):
1897 * xrdb.c (magic_file_p):
1898 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1899 * xselect.c (TRACE1): Don't assume pid_t promotes to int.
1900 (x_get_local_selection, x_reply_selection_request)
1901 (x_handle_selection_request, wait_for_property_change):
1902 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1903 (selection_data_to_lisp_data): Use short, not EMACS_INT, where
1904 short is wide enough.
1905 (x_send_client_event): Don't assume fixnum fits in int.
1906 * xterm.c (x_x_to_emacs_modifiers):
1907 Don't assume EMACS_INT overflows nicely into int.
1908 (x_emacs_to_x_modifiers): Use EMACS_INT, not int, because values
1909 may come from Lisp.
1910 (handle_one_xevent): NATNUMP can eval its arg twice.
1911 (x_connection_closed):
1912 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1913 * xterm.h: Adjust decls to match defn changes elsewhere.
1914 (struct scroll_bar): Use struct vectorlike_header
1915 rather than rolling our own approximation.
1916 (SCROLL_BAR_VEC_SIZE): Remove; not used.
1917
c6574eb5
GM
19182012-05-25 Glenn Morris <rgm@gnu.org>
1919
1920 * lisp.mk (lisp): Update for more files being compiled now.
1921
e8d32c7e
SM
19222012-05-25 Stefan Monnier <monnier@iro.umontreal.ca>
1923
48def666
SM
1924 * lread.c: Remove `read_pure' which makes no difference.
1925 (read_pure): Remove var.
1926 (unreadpure): Remove function.
1927 (readevalloop): Don't call read_list with -1 flag.
1928 (read1, read_vector): Don't test read_pure any more.
1929 (read_list): Simplify.
1930
e8d32c7e
SM
1931 * fileio.c, character.h: Minor style tweaks.
1932
4b2addb7
DA
19332012-05-24 Dmitry Antipov <dmantipov@yandex.ru>
1934
1935 * window.h (clip_changed): Remove useless declaration.
1936
584461b2
JB
19372012-05-22 Juanma Barranquero <lekktu@gmail.com>
1938
1939 * makefile.w32-in: Follow-up to 2012-05-22T16:20:27Z!eggert@cs.ucla.edu.
1940 (TAGS, TAGS-gmake, CONFIG_H): Remove further references to m/intel386.h.
1941
34374650
PE
19422012-05-22 Paul Eggert <eggert@cs.ucla.edu>
1943
1944 Remove src/m/*.
1945 This directory predates autoconf and is no longer needed nowadays.
1946 Move its few remaining bits of functionality to where they're needed.
1947 * m/README, m/alpha.h, m/amdx86-64.h, m/ia64.h, m/ibmrs6000.h:
1948 * m/ibms390x.h, m/intel386.h, m/m68k.h, m/macppc.h, m/sparc.h:
1949 * m/template.h: Remove.
1950 * Makefile.in (M_FILE): Remove. All uses removed.
1951 * alloc.c (POINTERS_MIGHT_HIDE_IN_OBJECTS):
1952 * lisp.h (USE_LSB_TAG):
1953 * mem-limits.h (EXCEEDS_LISP_PTR):
1954 Use VAL_MAX, not VALBITS, in #if.
1955 * lisp.h (EMACS_INT_MAX): New macro, useful in #if.
1956 (EMACS_UINT): Define unconditionally now.
1957 (BITS_PER_CHAR, BITS_PER_SHORT, BITS_PER_INT, BITS_PER_LONG)
1958 (BITS_PER_EMACS_INT): New constants, replacing
1959 what used to be in config.h, but not useful in #if.
1960 (GCTYPEBITS, VALBITS): Define unconditionally, since m/* files don't
1961 define them any more.
1962 (VAL_MAX): New macro.
1963 (VALMASK): Use it.
1964 * puresize.h (PURESIZE_RATIO): Use EMACS_INT_MAX, not
1965 BITS_PER_EMACS_INT, in #if.
1966 * s/aix4-2.h (BROKEN_FIONREAD, BROKEN_SIGAIO, BROKEN_SIGPTY)
1967 (BROKEN_SIGPOLL): Move here from m/ibmrs6000.h, which was removed.
1968 * s/gnu-linux.h (ULIMIT_BREAK_VALUE) [__i386__]:
1969 * s/ms-w32.h (DATA_START):
1970 Move here from removed file m/intel386.h.
1971 * s/gnu.h (NLIST_STRUCT): Remove undef; 'configure' does this.
1972 * s/irix6-5.h (_LP64): Remove; lisp.h no longer needs this.
1973
261cb4bb
PE
19742012-05-21 Paul Eggert <eggert@cs.ucla.edu>
1975
1976 Assume C89 or later.
1977 * alloc.c, buffer.c, lisp.h: Replace POINTER_TYPE with void.
1978 * alloc.c (overrun_check_malloc, overrun_check_realloc, xmalloc)
1979 (xrealloc):
1980 * buffer.c (mmap_free_1, mmap_enlarge): Omit needless casts.
1981 * editfns.c, fns.c, gmalloc.c, insdel.c, sysdep.c, termcap.c (NULL):
1982 * textprop.c, tparam.c (NULL): Remove.
1983 * ralloc.c, vm-limit.c (POINTER): Assume void * works.
1984 * regex.c (SIGN_EXTEND_CHAR): Assume signed char works.
1985 * regex.h (_RE_ARGS): Remove. All uses rewritten to use prototypes.
1986 * unexelf.c (ElfBitsW): Assume c89 preprocessor or better.
1987 * xterm.c (input_signal_count): Assume volatile works.
1988
ff23cd9f
KB
19892012-05-21 Ken Brown <kbrown@cornell.edu>
1990
1991 * xgselect.c (xg_select): Fix first argument in call to 'select'
1992 (bug#11508).
1993
1b170bc6
KB
19942012-05-20 Ken Brown <kbrown@cornell.edu>
1995
1996 * gmalloc.c (_free_internal_nolock, _realloc_internal_nolock)
bd7239f5 1997 [CYGWIN]: Cast ptr to (char *) before comparing to _heapbase.
1b170bc6 1998
b2f4d39f
KB
19992012-05-19 Ken Brown <kbrown@cornell.edu>
2000
2001 * xfns.c (x_in_use): Remove `static' qualifier.
2002 * xterm.h (x_in_use): Declare.
2003 * xgselect.c: Include xterm.h.
2004 (xg_select): Test `x_in_use' instead of `inhibit_window_system'
2005 and `display_arg' (bug#9754).
2006
003fdae2
PE
20072012-05-19 Paul Eggert <eggert@cs.ucla.edu>
2008
9232a6d9
PE
2009 * s/ms-w32.h (HAVE_GETDOMAINNAME): Remove; not needed.
2010
003fdae2
PE
2011 * m/vax.h: Remove; no longer needed since HAVE_FTIME is being removed.
2012 * s/ms-w32.h (HAVE_FTIME): Remove; not needed.
2013
784b56e2
EZ
20142012-05-18 Eli Zaretskii <eliz@gnu.org>
2015
2016 Fix compilation with -DGLYPH_DEBUG=1 on MS-Windows.
2017
2018 * w32term.c [GLYPH_DEBUG]: Add prototype for x_check_font.
2019 (x_check_font) [GLYPH_DEBUG]: New function, copied from xterm.c
2020
2021 * w32fns.c (unwind_create_frame) [GLYPH_DEBUG]: Fix broken
2022 reference to image_cache->refcount.
2023 (x_create_tip_frame): Fix broken use of FRAME_IMAGE_CACHE.
2024
a0a79cde
JL
20252012-05-17 Juri Linkov <juri@jurta.org>
2026
2027 * search.c (Fword_search_regexp, Fword_search_backward)
2028 (Fword_search_forward, Fword_search_backward_lax)
2029 (Fword_search_forward_lax): Move functions to isearch.el
2030 (bug#10145, bug#11381).
2031
b0572523
PE
20322012-05-16 Paul Eggert <eggert@cs.ucla.edu>
2033
2034 * xgselect.c (xg_select): Just invoke 'select' if -nw (Bug#9754).
2035
9660f5fc
SM
20362012-05-15 Stefan Monnier <monnier@iro.umontreal.ca>
2037
2038 * lread.c (init_obarray): Declare Qt and Qnil as special.
2039
4374de83
GM
20402012-05-14 Glenn Morris <rgm@gnu.org>
2041
2042 * nsterm.m (ns_init_paths): Fix typo ("libexec" not "lib-exec").
985584ae 2043 Put "libexec" before "bin", for the sake of init_callproc_1.
4374de83 2044
dc44c39a
PE
20452012-05-14 Paul Eggert <eggert@cs.ucla.edu>
2046
078c97cb
PE
2047 * keyboard.c (kbd_buffer_get_event) [!HAVE_DBUS]: Omit unused local.
2048
dc44c39a
PE
2049 * unexaix.c: Port to more-recent AIX compilers.
2050 (report_error, report_error_1, make_hdr, copy_sym)
2051 (mark_x, adjust_lnnoptrs, unrelocate_symbols):
2052 Make arguments const char *, not char *, to avoid violations of C
2053 standard and to fix some AIX warnings reported by Gilles Pion.
2054
e18afed7 20552012-05-14 Eli Zaretskii <eliz@gnu.org>
ac268e67
EZ
2056
2057 * xdisp.c (handle_stop): Don't call get_overlay_strings_1 if we
2058 already have overlays loaded.
2059 (handle_single_display_spec): Before returning without displaying
2060 fringe bitmap, synchronize the bidi iterator with the main display
2061 iterator, by calling iterate_out_of_display_property.
2062 (iterate_out_of_display_property): Detect buffer iteration by
2063 testing that it->string is a Lisp string.
2064 (get_next_display_element): When the current object is exhausted,
2065 and there's something on it->stack, call set_iterator_to_next to
2066 proceed with what's on the stack, instead of returning zero.
2067 (set_iterator_to_next): If called at the end of a Lisp string,
2068 proceed to consider_string_end without incrementing string
2069 position. Don't increment display vector index past the end of
2070 the display vector. (Bug#11417)
c8fb9dc6
EZ
2071 (pos_visible_p): Don't report a position visible when move_it_to
2072 stopped at the last line of window, which happens to be scanned
2073 backwards by the bidi iteration. (Bug#11464)
ac268e67 2074
e18afed7 20752012-05-14 Eli Zaretskii <eliz@gnu.org>
82f9b393
EZ
2076
2077 * xdisp.c (handle_single_display_spec): Return 1 for left-margin
2078 and right-margin display specs even if the spec is invalid or we
61b108cc
SM
2079 are on a TTY, and thus unable to display on the fringes.
2080 That's because the text with the property will not be displayed anyway,
82f9b393
EZ
2081 so we need to signal to the caller that this is a "replacing"
2082 display spec. This fixes display when the spec is invalid or we
2083 are on a TTY.
2084
e18afed7 20852012-05-14 Paul Eggert <eggert@cs.ucla.edu>
297834cd
PE
2086
2087 * unexaix.c (make_hdr): Fix typo in prototype.
2088 This bug broke the build on AIX. Problem reported by Gilles Pion.
2089
9d0a235a
MA
20902012-05-14 Michael Albinus <michael.albinus@gmx.de>
2091
2092 * keyboard.c (kbd_buffer_get_event): Read special events also in
2093 batch mode. (Bug#11415)
2094
9e6b06ed
GM
20952012-05-12 Glenn Morris <rgm@gnu.org>
2096
2097 * ns.mk: Update for ns_appbindir no longer having trailing "/".
2098
c1a1d7a3
EZ
20992012-05-12 Eli Zaretskii <eliz@gnu.org>
2100
2101 * lisp.mk (lisp): Add newcomment.elc.
2102
3fe7cdc8
GM
21032012-05-12 Glenn Morris <rgm@gnu.org>
2104
2105 * Makefile.in (MKDIR_P): New, set by configure.
2106 * ns.mk (${ns_appdir}, ${ns_appbindir}Emacs): Use $MKDIR_P.
2107
53f7d2c0
PE
21082012-05-11 Paul Eggert <eggert@cs.ucla.edu>
2109
2110 Remove unused function hourglass_started.
2111 * dispextern.h (hourglass_started):
2112 * w32fns.c (hourglass_started):
2113 * xdisp.c (hourglass_started): Remove.
2114
75aafb17
JB
21152012-05-10 Juanma Barranquero <lekktu@gmail.com>
2116
2117 * makefile.w32-in ($(BLD)/gmalloc.$(O), $(BLD)/w32menu.$(O)):
2118 Update dependencies.
2119
12959e8e
PE
21202012-05-10 Paul Eggert <eggert@cs.ucla.edu>
2121
97107e2e
PE
2122 * xgselect.c (xg_select): Put maxfds+1 into a var.
2123 This is slightly clearer, and pacifies Ubuntu 12.04 gcc.
2124
12959e8e
PE
2125 * sound.c (DEFAULT_ALSA_SOUND_DEVICE): Define only if HAVE_ALSA.
2126
836d29b3
DA
21272012-05-10 Dave Abrahams <dave@boostpro.com>
2128
2129 * filelock.c (syms_of_filelock): New boolean create-lockfiles.
2130 (lock_file): If create_lockfiles is 0, do nothing. (Bug#11227)
2131
5cb67954
MA
21322012-05-09 Michael Albinus <michael.albinus@gmx.de>
2133
2134 * dbusbind.c (xd_registered_buses): New internal Lisp object.
2135 Rename all occurences of Vdbus_registered_buses to xd_registered_buses.
2136 (syms_of_dbusbind): Remove declaration of Vdbus_registered_buses.
2137 Initialize xd_registered_buses.
2138
3478ec45
PE
21392012-05-09 Paul Eggert <eggert@cs.ucla.edu>
2140
b263a6b0
PE
2141 Untag more efficiently if USE_LSB_TAG.
2142 This is based on a proposal by YAMAMOTO Mitsuharu in
2143 <http://lists.gnu.org/archive/html/emacs-devel/2008-01/msg01876.html>.
2144 For an admittedly artificial (nth 8000 longlist) benchmark on
2145 Fedora 15 x86-64, this yields a 25% CPU speedup. Also, it shrinks
2146 Emacs's overall text size by 1%.
2147 * lisp.h (XUNTAG): New macro.
2148 (XCONS, XVECTOR, XSTRING, XSYMBOL, XFLOAT, XMISC, XPROCESS, XWINDOW)
2149 (XTERMINAL, XSUBR, XBUFFER, XCHAR_TABLE, XSUB_CHAR_TABLE, XBOOL_VECTOR)
2150 (XSETTYPED_PSEUDOVECTOR, XHASH_TABLE, TYPED_PSEUDOVECTORP): Use it.
2151 * eval.c (Fautoload):
2152 * font.h (XFONT_SPEC, XFONT_ENTITY, XFONT_OBJECT):
2153 * frame.h (XFRAME): Use XUNTAG.
2154
3478ec45
PE
2155 Port recent dbusbind.c changes to 32-bit --with-wide-int.
2156 * dbusbind.c (xd_append_arg, xd_retrieve_arg, Fdbus_message_internal):
2157 Remove unportable assumptions about print widths of types like
2158 dbus_uint32_t.
2159 (xd_get_connection_address, Fdbus_init_bus): Cast Emacs integer to
2160 intptr_t when converting between pointer and integer, to avoid GCC
2161 warnings about wrong width.
2162
666b903b 21632012-05-09 Eli Zaretskii <eliz@gnu.org>
0d887c7d
EZ
2164
2165 * w32proc.c (new_child): Force Windows to reserve only 64KB of
2166 stack for each reader_thread, instead of defaulting to 8MB
2167 determined by the linker. This avoids failures in creating
2168 subprocesses on Windows 7, see the discussion in this thread:
2169 http://lists.gnu.org/archive/html/emacs-devel/2012-03/msg00119.html.
2170
b120cc17
JC
21712012-05-07 Jérémy Compostella <jeremy.compostella@gmail.com>
2172
2173 Fix up display of the *Minibuf-0* buffer in the mini window.
2174 * keyboard.c (read_char): Don't clear the echo area if there's no
2175 message to clear.
2176 * xdisp.c (redisplay_internal): Redisplay the mini window (with the
2fed2689 2177 contents of *Minibuf-0*) if there's no message displayed in its stead.
b120cc17 2178
9a4b36f8
MA
21792012-05-07 Michael Albinus <michael.albinus@gmx.de>
2180
2181 * dbusbind.c (XD_DEBUG_MESSAGE): Don't print message twice in
2182 batch mode.
2183
e5f9458f
CY
21842012-05-06 Chong Yidong <cyd@gnu.org>
2185
2186 * lisp.mk (lisp): Update.
2187
eceeb5fc 21882012-05-05 Jim Meyering <meyering@redhat.com>
bf98199c
JM
2189
2190 * w32font.c (fill_in_logfont): NUL-terminate a string (Bug#11372).
2191
71873e2b
SM
21922012-05-04 Stefan Monnier <monnier@iro.umontreal.ca>
2193
2194 * data.c (PUT_ERROR): New macro.
2195 (syms_of_data): Use it. Add new error type `user-error'.
2196 * undo.c (user_error): New function.
2197 (Fprimitive_undo): Use it.
2198 * print.c (print_error_message): Adjust print style for `user-error'.
2199 * keyboard.c (user_error): New function.
2200 (Fexit_recursive_edit, Fabort_recursive_edit): Use it.
2201
ab0fa4e4
PE
22022012-05-03 Paul Eggert <eggert@cs.ucla.edu>
2203
2204 Do not limit current-time-string to years 1000..9999.
2205 * editfns.c (TM_YEAR_IN_ASCTIME_RANGE): Remove.
2206 (Fcurrent_time_string): Support any year that is supported by the
2207 underlying localtime representation. Don't use asctime, as it
2208 has undefined behavior for years outside the range -999..9999.
2209
7ed806a7
PE
22102012-05-02 Paul Eggert <eggert@cs.ucla.edu>
2211
2212 Fix race conditions involving setenv, gmtime, localtime, asctime.
2213 Without this fix, interrupts could mess up code that uses these
2214 nonreentrant functions, since setting TZ invalidates existing
2215 tm_zone or tzname values, and since most of these functions return
2216 pointers to static storage.
2217 * editfns.c (format_time_string, Fdecode_time, Fencode_time)
2218 (Fcurrent_time_string, Fcurrent_time_zone, Fset_time_zone_rule):
2219 Grow the critical sections to include not just invoking
2220 localtime/gmtime, but also accessing these functions' results
2221 including their tm_zone values if any, and any related TZ setting.
2222 (format_time_string): Last arg is now struct tm *, not struct tm **,
71873e2b
SM
2223 so that the struct tm is saved in the critical section.
2224 All callers changed. Simplify allocation of initial buffer, partly
7ed806a7
PE
2225 motivated by the fact that memory allocation needs to be outside
2226 the critical section.
2227
0c16dfed
DA
22282012-05-02 Dmitry Antipov <dmantipov@yandex.ru>
2229
2230 * intervals.c (adjust_intervals_for_insertion): Initialize `newi'
2231 with RESET_INTERVAL.
2232
2233 * buffer.c (Fget_buffer_create, Fmake_indirect_buffer):
2234 Remove duplicated buffer name initialization.
2235
3f83ace8
JM
22362012-05-02 Jim Meyering <jim@meyering.net>
2237
2238 * xterm.c (x_term_init): Use memcpy instead of strncpy (Bug#11373).
2239
c7b8541e
JM
2240 * xfns.c (x_window): Use xstrdup (Bug#11375).
2241
90207a15 22422012-05-02 Eli Zaretskii <eliz@gnu.org>
2fa85638
EZ
2243
2244 * xdisp.c (pos_visible_p): If already at a newline from the
2245 display string before the 'while' loop, don't walk back the glyphs
2246 from it3.glyph_row. Solves assertion violation when the display
2247 string begins with a newline (egg.el). (Bug#11367)
2248
b593d6a9
AH
22492012-05-01 Stefan Monnier <monnier@iro.umontreal.ca>
2250
2251 * keyboard.c (Fexecute_extended_command, Vsuggest_key_bindings):
2252 Move to simple.el.
2253
4737362e
GM
22542012-05-01 Glenn Morris <rgm@gnu.org>
2255
99cf43f9
GM
2256 * syssignal.h: Remove reference to BROKEN_SIGINFO (last used in
2257 s/ptx4.h), BROKEN_SIGTSTP (last used in m/ustation.h, m/dpx2.h),
2258 and BROKEN_SIGURG (was in s/gnu-linux.h prior to 2008-02-10).
2259 All were removed before 23.1.
2260
9311dcff
GM
2261 * dispnew.c: Remove HAVE_LIBNCURSES test;
2262 it is always true on relevant platforms.
2263
4d5c6349
GM
2264 * Makefile.in (LD_SWITCH_X_SITE_RPATH):
2265 Rename from LD_SWITCH_X_SITE_AUX_RPATH.
2266
4737362e
GM
2267 * Makefile.in (LD_SWITCH_X_SITE_AUX): Remove; no longer used.
2268
74dd3a6b
AS
22692012-04-30 Andreas Schwab <schwab@linux-m68k.org>
2270
2271 * .gdbinit (xpr): Remove checks for no longer existing misc types.
2272 (xintfwd, xboolfwd, xobjfwd, xbufobjfwd, xkbobjfwd, xbuflocal):
2273 Remove.
2274
13c379ee
PE
22752012-04-28 Paul Eggert <eggert@cs.ucla.edu>
2276
2277 Do not avoid creating empty evaporating overlays (Bug#9642).
2278 * buffer.c (Fmove_overlay): Revert the change of 2012-04-23.
2279 That is, do not delete an evaporating overlay if it becomes
2280 empty after its bounds are adjusted to fit within its buffer.
2281 This fix caused other problems, and I'm reverting it until we get
2282 to the bottom of them.
2283
a8e7d6d7 22842012-04-27 Chong Yidong <cyd@gnu.org>
9be2fd9b
CY
2285
2286 * xselect.c (x_convert_selection): Initialize a pointer (Bug#11315).
2287
a8e7d6d7 22882012-04-27 Eli Zaretskii <eliz@gnu.org>
f0ee99a0
EZ
2289
2290 * xdisp.c (pos_visible_p): If the window start position is beyond
2291 ZV, start the display from buffer beginning. Prevents assertion
2292 violation in init_iterator when the minibuffer window is scrolled
2293 via the scroll bar.
2294
2295 * window.c (window_scroll_pixel_based): Likewise.
2296
a8e7d6d7 22972012-04-27 Chong Yidong <cyd@gnu.org>
9ec7751f
CY
2298
2299 * keymap.c (where_is_internal): Doc fix (Bug#10872).
2300
a8e7d6d7 23012012-04-27 Glenn Morris <rgm@gnu.org>
24c51a09
GM
2302
2303 * fileio.c (Fcopy_file, Fset_file_selinux_context):
2304 Ignore ENOTSUP failures from setfilecon functions. (Bug#11245)
2305
a8e7d6d7 23062012-04-27 Eli Zaretskii <eliz@gnu.org>
73055685 2307
b593d6a9
AH
2308 * dispnew.c (swap_glyph_pointers, copy_row_except_pointers):
2309 Don't overrun array limits of glyph row's used[] array. (Bug#11288)
73055685 2310
1c6900d9
EZ
23112012-04-26 Eli Zaretskii <eliz@gnu.org>
2312
4c3fa1d9
EZ
2313 * xdisp.c (IT_DISPLAYING_WHITESPACE): In addition to the loaded
2314 display element, check also the underlying string or buffer
2315 character. (Bug#11341)
2316
1c6900d9
EZ
2317 * w32menu.c: Include w32heap.h.
2318 (add_menu_item): If the call to AppendMenuW (via
2319 unicode_append_menu) fails, disable Unicode menus only if we are
2320 running on Windows 9X/Me.
2321
42bf8205
AS
23222012-04-24 Andreas Schwab <schwab@linux-m68k.org>
2323
2324 * .gdbinit (xpr): Handle USE_2_TAGS_FOR_INTS.
2325 (xgetint): Add missing shift for LSB tags.
2326
b1bac16e
MR
23272012-04-24 Martin Rudalics <rudalics@gmx.at>
2328
2329 * keyboard.c (read_char): Don't wipe echo area for select window
2330 events: These might get delayed via `mouse-autoselect-window'
2331 (Bug#11304).
2332
d69621cc
JB
23332012-04-24 Juanma Barranquero <lekktu@gmail.com>
2334
2335 * gnutls.c (init_gnutls_functions): Protect against (unlikely)
2336 manipulation of :loaded-from data.
2337
02fd101b
JB
23382012-04-23 Juanma Barranquero <lekktu@gmail.com>
2339
2340 * gnutls.c (init_gnutls_functions): The value of :loaded-from is
2341 now a cons (bug#11311).
2342
888bec30
PE
23432012-04-23 Paul Eggert <eggert@cs.ucla.edu>
2344
89a438bd
PE
2345 Do not create empty overlays with the evaporate property (Bug#9642).
2346 * buffer.c (Fmove_overlay): Delete an evaporating overlay
2347 if it becomes empty after its bounds are adjusted to fit within
2348 its buffer. Without this fix, in a nonempty buffer (let ((o
2349 (make-overlay 1 2))) (overlay-put o 'evaporate t) (move-overlay o 0 1))
2350 yields an empty overlay that has the evaporate property, which is
2351 not supposed to happen.
2352
1068fe4d
PE
2353 Fix minor GTK3 problems found by static checking.
2354 * emacsgtkfixed.c (EMACS_TYPE_FIXED, EMACS_FIXED, EmacsFixed)
2355 (EmacsFixedPrivate, EmacsFixedClass, struct _EmacsFixed)
2356 (struct _EmacsFixedClass, emacs_fixed_get_type):
2357 Move decls here from emacsgtkfixed.h, since they needn't be public.
2358 (emacs_fixed_get_type): Now static.
2359 (emacs_fixed_class_init): Omit unused local.
2360 (emacs_fixed_child_type): Remove; unused.
2361 * emacsgtkfixed.h (EMACS_TYPE_FIXED, EMACS_FIXED, EmacsFixed)
2362 (EmacsFixedPrivate, EmacsFixedClass, struct _EmacsFixed)
2363 (struct _EmacsFixedClass): Move to emacsgtkfixed.c.
2364 (EMACS_FIXED_CLASS, EMACS_IS_FIXED, EMACS_IS_FIXED_CLASS)
2365 (EMACS_FIXED_GET_CLASS): Remove; unused.
2366 * gtkutil.c (xg_create_frame_widgets) [!HAVE_GTK3]: Omit unused local.
2367
888bec30
PE
2368 * keyboard.c (handle_async_input): Define only if SYNC_INPUT || SIGIO.
2369 Problem reported by Juanma Barranquero for Windows -Wunused-function.
2370
de85e130
PE
23712012-04-22 Paul Eggert <eggert@cs.ucla.edu>
2372
d0baac98 2373 Modernize and clean up gmalloc.c to assume C89 (Bug#9119).
bd7239f5 2374 * gmalloc.c (_MALLOC_INTERNAL, _MALLOC_H, _PP, __ptr_t)
d0baac98
PE
2375 (__malloc_size_t, __malloc_ptrdiff_t):
2376 Remove. All uses removed, replaced by the definiens if needed,
2377 since we can assume C89 or better now.
2378 Include <stdint.h>, for PTRDIFF_MAX, uintptr_t.
2379 (protect_malloc_state, align, get_contiguous_space)
2380 (malloc_atfork_handler_prepare, malloc_atfork_handler_parent)
2381 (malloc_atfork_handler_child, malloc_enable_thread)
2382 (malloc_initialize_1, __malloc_initialize, morecore_nolock)
2383 (_malloc_internal_nolock, _malloc_internal, malloc, _malloc)
2384 (_free, _realloc, _free_internal_nolock, _free_internal, free, cfree)
2385 (special_realloc, _realloc_internal_nolock, _realloc_internal)
2386 (realloc, calloc, __default_morecore, memalign, valloc, checkhdr)
2387 (freehook, mallochook, reallochook, mabort, mcheck, mprobe):
2388 Define using prototypes, not old style.
2389 (align, _malloc_internal_nolock, _free_internal_nolock, memalign):
2390 Don't assume ptrdiff_t and uintptr_t are no wider than unsigned long.
2391 (align): Don't assume that signed integer overflow wraps around.
2392 Omit unused local var.
2393 (malloc_initialize_1, morecore_nolock, _malloc_internal_nolock)
2394 (_free_internal_nolock, memalign, mallochook, reallochook):
2395 Omit no-longer-needed casts.
2396 (valloc): Use getpagesize, not __getpagesize.
2397 (MAGICWORD, MAGICFREE): Now randomish size_t values, not 32-bit.
2398 (struct hdr): The 'magic' member is now size_t, not unsigned long.
2399
de85e130
PE
2400 * dbusbind.c (XD_DBUS_VALIDATE_OBJECT): Define only if needed.
2401
dcbf5805
MA
24022012-04-22 Michael Albinus <michael.albinus@gmx.de>
2403
2404 Move functions from C to Lisp. Make non-blocking method calls
2405 the default. Implement further D-Bus standard interfaces.
2406
2407 * dbusbind.c (DBUS_NUM_MESSAGE_TYPES): Declare.
2408 (QCdbus_request_name_allow_replacement)
2409 (QCdbus_request_name_replace_existing)
2410 (QCdbus_request_name_do_not_queue)
2411 (QCdbus_request_name_reply_primary_owner)
2412 (QCdbus_request_name_reply_in_queue)
2413 (QCdbus_request_name_reply_exists)
2414 (QCdbus_request_name_reply_already_owner): Move to dbus.el.
2415 (QCdbus_registered_serial, QCdbus_registered_method)
2416 (QCdbus_registered_signal): New Lisp objects.
2417 (XD_DEBUG_MESSAGE): Use sizeof.
2418 (XD_MESSAGE_TYPE_TO_STRING, XD_OBJECT_TO_STRING)
2419 (XD_DBUS_VALIDATE_BUS_ADDRESS, XD_DBUS_VALIDATE_OBJECT)
2420 (XD_DBUS_VALIDATE_BUS_NAME, XD_DBUS_VALIDATE_PATH)
2421 (XD_DBUS_VALIDATE_INTERFACE, XD_DBUS_VALIDATE_MEMBER): New macros.
2422 (XD_CHECK_DBUS_SERIAL): Rename from CHECK_DBUS_SERIAL_GET_SERIAL.
2423 (xd_signature, xd_append_arg): Allow float for integer types.
2424 (xd_get_connection_references): New function.
b593d6a9
AH
2425 (xd_get_connection_address): Rename from xd_initialize.
2426 Return cached address.
dcbf5805
MA
2427 (xd_remove_watch): Do not unset $DBUS_SESSION_BUS_ADDRESS.
2428 (xd_close_bus): Rename from Fdbus_close_bus. Not needed on Lisp
2429 level.
2430 (Fdbus_init_bus): New optional arg PRIVATE. Cache address.
9a4b36f8 2431 Return number of refcounts.
dcbf5805
MA
2432 (Fdbus_get_unique_name): Make stronger parameter check.
2433 (Fdbus_message_internal): New defun.
2434 (Fdbus_call_method, Fdbus_call_method_asynchronously)
2435 (Fdbus_method_return_internal, Fdbus_method_error_internal)
2436 (Fdbus_send_signal, Fdbus_register_service)
2437 (Fdbus_register_signal, Fdbus_register_method): Move to dbus.el.
2438 (xd_read_message_1): Obey new structure of Vdbus_registered_objects.
2439 (xd_read_queued_messages): Obey new structure of Vdbus_registered_buses.
2440 (Vdbus_compiled_version, Vdbus_runtime_version)
2441 (Vdbus_message_type_invalid, Vdbus_message_type_method_call)
2442 (Vdbus_message_type_method_return, Vdbus_message_type_error)
2443 (Vdbus_message_type_signal): New defvars.
b593d6a9
AH
2444 (Vdbus_registered_buses, Vdbus_registered_objects_table):
2445 Adapt docstring.
dcbf5805 2446
52828e02
PE
24472012-04-22 Paul Eggert <eggert@cs.ucla.edu>
2448
da05bc4c
PE
2449 Fix GC_MALLOC_CHECK debugging output on 64-bit hosts.
2450 * alloc.c (emacs_blocked_malloc) [GC_MALLOC_CHECK]:
2451 Do not assume ptrdiff_t is the same width as 'int'.
2452
52828e02
PE
2453 * alloc.c: Handle unusual debugging option combinations.
2454 (GC_CHECK_MARKED_OBJECTS): Undef if ! GC_MARK_STACK,
2455 since the two debugging options are incompatible.
2456 (GC_MALLOC_CHECK): Similarly, undef if GC_CHECK_MARKED_OBJECTS
2457 is defined.
2458 (mem_init, mem_insert, mem_insert_fixup):
2459 Define if GC_MARK_STACK || GC_MALLOC_CHECK.
2460 (NEED_MEM_INSERT): Remove; no longer needed.
2461
f01769f9
LL
24622012-04-22 Leo Liu <sdl.web@gmail.com>
2463
2464 * sysdep.c (list_system_processes): Support Darwin (Bug#5725).
2465
5790543d
PE
24662012-04-22 Paul Eggert <eggert@cs.ucla.edu>
2467
2468 * sysdep.c [__FreeBSD__]: Minor cleanups.
2469 (list_system_processes, system_process_attributes) [__FreeBSD__]:
2470 Use Emacs indenting style more consistently. Avoid some casts.
2471 Use 'double' consistently rather than mixing 'float' and 'double'.
2472
b91b7e4d
EW
24732012-04-21 Eduard Wiebe <usenet@pusto.de>
2474
b593d6a9
AH
2475 * sysdep.c (list_system_processes, system_process_attributes):
2476 Add implementation for FreeBSD (Bug#5243).
b91b7e4d 2477
6114eb15
AS
24782012-04-21 Andreas Schwab <schwab@linux-m68k.org>
2479
2480 * lisp.mk (lisp): Update.
2481
2f38dff7
PE
24822012-04-20 Paul Eggert <eggert@cs.ucla.edu>
2483
2484 * keyboard.c (process_pending_signals): Define only if SYNC_INPUT.
2485 It is never used otherwise.
2486
4ae29f89
SM
24872012-04-20 Stefan Monnier <monnier@iro.umontreal.ca>
2488
2489 * print.c (print_preprocess): Only check print_depth if print-circle
2490 is nil.
2491 (print_object): Check for cycles even when print-circle is nil and
2492 print-gensym is t, but only check print_depth if print-circle is nil.
2493
f30d612a
CY
24942012-04-20 Chong Yidong <cyd@gnu.org>
2495
2496 * process.c (wait_reading_process_output): If EIO occurs on a pty,
2497 set the status to "failed" and ensure that sentinel is run.
2498
c07a4c0b 24992012-04-20 Glenn Morris <rgm@gnu.org>
016a35df
GM
2500
2501 * process.c (Fset_process_inherit_coding_system_flag)
2502 (Fset_process_query_on_exit_flag): Doc fix (mention return value).
4373fd43 2503 (Fmake_network_process, Fmake_serial_process): Doc fix.
016a35df 2504
c07a4c0b 25052012-04-20 Eli Zaretskii <eliz@gnu.org>
20a68157
EZ
2506
2507 * xdisp.c (string_buffer_position_lim): Limit starting position to
2508 BEGV.
2509 (set_cursor_from_row): If called for a mode-line or header-line
2510 row, return zero immediately.
2511 (try_cursor_movement): If inside continuation line, don't back up
4ae29f89
SM
2512 farther than the first row after the header line, if any.
2513 Don't consider the header-line row as "partially visible", even if
20a68157
EZ
2514 MATRIX_ROW_PARTIALLY_VISIBLE_P returns non-zero. (Bug#11261)
2515
c07a4c0b 25162012-04-20 Atsuo Ohki <ohki@gssm.otsuka.tsukuba.ac.jp> (tiny change)
ad3a2b41 2517
4ae29f89
SM
2518 * lread.c (lisp_file_lexically_bound_p): Fix hang at ";-*-\n"
2519 (bug#11238).
ad3a2b41 2520
c07a4c0b 25212012-04-20 Teodor Zlatanov <tzz@lifelogs.com>
6c94c34f 25222012-04-18 Paul Eggert <eggert@cs.ucla.edu>
ae6e112d
PE
2523
2524 configure: new option --enable-gcc-warnings (Bug#11207)
2525 * Makefile.in (C_WARNINGS_SWITCH): Remove.
2526 (WARN_CFLAGS, WERROR_CFLAGS): New macros.
2527 (ALL_CFLAGS): Use new macros rather than old.
2528 * process.c: Ignore -Wstrict-overflow to work around GCC bug 52904.
2529 * regex.c: Ignore -Wstrict-overflow. If !emacs, also ignore
2530 -Wunused-but-set-variable, -Wunused-function, -Wunused-macros,
2531 -Wunused-result, -Wunused-variable. This should go away once
2532 the Emacs and Gnulib regex code is merged.
2533 (xmalloc, xrealloc): Now static.
2534
aba027e8
PE
25352012-04-17 Paul Eggert <eggert@cs.ucla.edu>
2536
2537 * dired.c (Fsystem_groups): Remove unused local.
2538
e5a36063
GM
25392012-04-17 Glenn Morris <rgm@gnu.org>
2540
2541 * dired.c (Fsystem_users): Doc fix.
2542
316411f0
DA
25432012-04-17 Dmitry Antipov <dmantipov@yandex.ru>
2544
2545 * dired.c (Fsystem_users, Fsystem_groups): New functions. (Bug#7900)
2546 (syms_of_dired): Add them.
2547
9426aba4
PE
25482012-04-16 Paul Eggert <eggert@cs.ucla.edu>
2549
b62a57be
PE
2550 Fix minor alloc.c problems found by static checking.
2551 * alloc.c (_malloc_internal, _free_internal) [!DOUG_LEA_MALLOC]:
2552 New extern decls, to avoid calling undeclared functions.
2553 (dont_register_blocks): Define if ((!SYSTEM_MALLOC && !SYNC_INPUT)
2554 && GC_MALLOC_CHECK), not if ((GC_MARK_STACK || defined
2555 GC_MALLOC_CHECK) && GC_MALLOC_CHECK), to match when it's used.
2556 (NEED_MEM_INSERT): New macro.
2557 (mem_insert, mem_insert_fixup) [!NEED_MEM_INSERT]: Remove; unused.
4b5afbb0 2558 Remove one incorrect comment and fix another.
b62a57be 2559
3539f31f
PE
2560 Fix minor ralloc.c problems found by static checking.
2561 See http://lists.gnu.org/archive/html/emacs-devel/2011-12/msg00720.html
2562 * ralloc.c (ALIGNED, ROUND_TO_PAGE, HEAP_PTR_SIZE)
2563 (r_alloc_size_in_use, r_alloc_freeze, r_alloc_thaw): Remove; unused.
2564 (r_alloc_sbrk): Now static.
2565
a041960a
PE
2566 Improve ralloc.c interface checking.
2567 See http://lists.gnu.org/archive/html/emacs-devel/2011-12/msg00720.html
2568 * buffer.c (ralloc_reset_variable, r_alloc, r_re_alloc)
2569 (r_alloc_free) [REL_ALLOC]: Move decls from here ...
2570 * lisp.h (r_alloc, r_alloc_free, r_re_alloc, r_alloc_reset_variable)
2571 [REL_ALLOC]: ... to here, to check interface.
2572 * m/ia64.h (r_alloc, r_alloc_free) [REL_ALLOC && !_MALLOC_INTERNAL]:
2573 Remove decls. This fixes an "It stinks!".
2574
9426aba4
PE
2575 * alloc.c (which_symbols): Fix alignment issue / type clash.
2576
d55c12ed
AS
25772012-04-15 Andreas Schwab <schwab@linux-m68k.org>
2578
2579 * lisp.h (struct Lisp_Symbol): Remove explicit padding.
2580 (struct Lisp_Misc_Any): Likewise.
2581 (struct Lisp_Free): Likewise.
2582 * alloc.c (union aligned_Lisp_Symbol): Define.
2583 (SYMBOL_BLOCK_SIZE, struct symbol_block): Use union
2584 aligned_Lisp_Symbol instead of struct Lisp_Symbol.
2585 (union aligned_Lisp_Misc): Define.
2586 (MARKER_BLOCK_SIZE, struct marker_block): Use union
2587 aligned_Lisp_Misc instead of union Lisp_Misc.
4ae29f89 2588 (Fmake_symbol, allocate_misc, gc_sweep): Adjust.
d55c12ed 2589
b948ce8b
PE
25902012-04-14 Paul Eggert <eggert@cs.ucla.edu>
2591
2592 Make GC_MAKE_GCPROS_NOOPS the default (Bug#9926).
2593 * lisp.h (GC_MARK_STACK): Default to GC_MAKE_GCPROS_NOOPS.
2594 * s/cygwin.h, s/darwin.h, s/freebsd.h, s/gnu.h, s/irix6-5.h, s/msdos.h:
2595 * s/netbsd.h, s/sol2-6.h:
2596 Remove definition of GC_MARK_STACK, since the default now works.
2597 * s/aix4-2.h, s/hpux10-20.h, s/unixware.h:
2598 Define GC_MARK_STACK to GC_USE_GCPROS_AS_BEFORE, since that's
2599 no longer the default.
2600 * s/gnu-linux.h (GC_MARK_STACK): Adjust to change in default.
2601
35dc09a1 26022012-04-14 Atsuo Ohki <ohki@gssm.otsuka.tsukuba.ac.jp> (tiny change)
ad3a2b41 2603
35dc09a1
GM
2604 * lread.c (lisp_file_lexically_bound_p):
2605 Fix hang at ";-*-\n" (bug#11238).
ad3a2b41 2606
35dc09a1
GM
26072012-04-14 Eli Zaretskii <eliz@gnu.org>
2608
2609 * xdisp.c (find_last_unchanged_at_beg_row): Don't consider a row
2610 "unchanged" if its end.pos is beyond ZV. (Bug#11199)
2611
26122012-04-14 Jan Djärv <jan.h.d@swipnet.se>
2613
2614 * nsterm.m (constrainFrameRect): Always constrain when there is only
2615 one screen (Bug#10962).
2616
bcd86815
KB
26172012-04-13 Ken Brown <kbrown@cornell.edu>
2618
2619 * s/cygwin.h (PTY_OPEN): Don't try to close a bogus file descriptor.
2620
c25df26e
RT
26212012-04-13 Reuben Thomas <rrt@sc3d.org>
2622
2623 * indent.c (Fmove_to_column): Change interactive spec (Bug#739).
2624
0fc59f1e
DC
26252012-04-11 Daniel Colascione <dancol@dancol.org>
2626
2627 * s/cygwin.h: The vfork the #define in cygwin.h was protecting
2628 against is gone. It's better to use vfork now so that when Cygwin
2629 gains a new, working vfork, we use it automatically (bug#10398).
2630
de8c03dc
SM
26312012-04-11 Stefan Monnier <monnier@iro.umontreal.ca>
2632
2633 * window.c (save_window_save): Obey window-point-insertion-type.
2634
2f097256
GM
26352012-04-11 Glenn Morris <rgm@gnu.org>
2636
2637 * Makefile.in (GNUSTEP_CFLAGS): Rename from C_SWITCH_X_SYSTEM.
2638
453b951e
SM
26392012-04-11 Stefan Monnier <monnier@iro.umontreal.ca>
2640
2641 * alloc.c (lisp_align_malloc): Remove unneeded prototype.
2642
75f1671a 26432012-04-10 Jason S. Cornez <jcornez@ravenpack.com> (tiny change)
6bbef4e5
JC
2644
2645 * keyboard.c: Override inhibit-quit after the third C-g (bug#6585).
2646 (force_quit_count): New var.
2647 (handle_interrupt): Use it.
2648
2a8ce227
JB
26492012-04-10 Juanma Barranquero <lekktu@gmail.com>
2650
2651 * w32.c (w32_delayed_load): Record the full path of the library
2652 being loaded (bug#10424).
2653
935396c0
GM
26542012-04-09 Glenn Morris <rgm@gnu.org>
2655
05920a43
GM
2656 * doc.c (Fsnarf_documentation): Check variables, functions are bound,
2657 not just in the obarray, before snarfing them. (Bug#11036)
2658
935396c0
GM
2659 * Makefile.in ($(leimdir)/leim-list.el):
2660 Pass EMACS rather than BUILT_EMACS.
2661
a18ecafa
TZ
26622012-04-09 Teodor Zlatanov <tzz@lifelogs.com>
2663
2664 * process.c (make_process):
2665 * process.h: Add integer `gnutls_handshakes_tried' member to
2666 process struct.
2667
6bbef4e5
JC
2668 * gnutls.h: Add `GNUTLS_EMACS_HANDSHAKES_LIMIT' upper limit.
2669 Add convenience `GNUTLS_LOG2i' macro.
a18ecafa
TZ
2670
2671 * gnutls.c (gnutls_log_function2i): Convenience log function.
2672 (emacs_gnutls_read): Use new log functions,
2673 `gnutls_handshakes_tried' process member, and
2674 `GNUTLS_EMACS_HANDSHAKES_LIMIT' to limit the number of handshake
2675 attempts per process (connection).
2676
b4d3bc10
CY
26772012-04-09 Chong Yidong <cyd@gnu.org>
2678
2679 * eval.c (Fuser_variable_p, user_variable_p_eh)
2680 (lisp_indirect_variable): Functions deleted.
2681 (Fdefvar): Caller changed.
2682
2683 * callint.c (Finteractive, Fcall_interactively):
2684 * minibuf.c (Fread_variable): Callers changed.
2685
70f4d973
EZ
26862012-04-09 Eli Zaretskii <eliz@gnu.org>
2687
2688 * xdisp.c (set_cursor_from_row): If the display string appears in
2689 the buffer at position that is closer to point than the position
2690 after the display string, display the cursor on the first glyph of
2691 the display string. Fixes cursor display when a 'display' text
2692 property immediately follows invisible text. (Bug#11094)
2693
cb3c2e3e
PE
26942012-04-09 Paul Eggert <eggert@cs.ucla.edu>
2695
2696 composite.c: use 'double' consistently
2697 * composite.c (get_composition_id): Use 'double' consistently
2698 instead of converting 'float' to 'double' and vice versa; this is
2699 easier to understand and avoids a GCC warning.
2700
fd06db5d
GM
27012012-04-09 Glenn Morris <rgm@gnu.org>
2702
50fe702a
GM
2703 * Makefile.in: Generate leim-list with bootstrap-emacs, in
2704 preparation for dumping it with emacs. (Bug#4789)
2705 (leimdir): New variable.
2706 ($(leimdir)/leim-list.el): New rule.
2707 (emacs$(EXEEXT)): Depend on leim-list.el.
2708
fd06db5d
GM
2709 * buffer.c (Qucs_set_table_for_input): Remove. (Bug#9821)
2710 (Fget_buffer_create): Don't call Qucs_set_table_for_input.
2711 (init_buffer_once, syms_of_buffer): Remove Qucs_set_table_for_input.
2712
55c131ee
AS
27132012-04-08 Andreas Schwab <schwab@linux-m68k.org>
2714
2715 * lisp.h (struct Lisp_Symbol): Add explicit padding to ensure
2716 proper alignment.
2717
9209588f
JB
27182012-04-07 Juanma Barranquero <lekktu@gmail.com>
2719
2720 * xml.c (init_libxml2_functions) [WINDOWSNT]:
2721 Remove unused local variable.
2722
e3fb2efb
PE
27232012-04-07 Paul Eggert <eggert@cs.ucla.edu>
2724
2725 Avoid unnecessary pointer scanning in garbage collection (Bug#10780).
2726 * alloc.c (POINTERS_MIGHT_HIDE_IN_OBJECTS): New macro.
2727 (mark_memory): Mark Lisp_Objects only if pointers might hide in
2728 objects, as mark_maybe_pointer will catch them otherwise.
2729 (GC_LISP_OBJECT_ALIGNMENT): Remove; no longer needed.
2730 * s/gnu-linux.h (GC_LISP_OBJECT_ALIGNMENT) [__mc68000__]: Likewise.
2731
b5385551
PE
27322012-04-07 Paul Eggert <eggert@cs.ucla.edu>
2733
2734 Fix typo that broke non-Windows builds.
2735 * xml.c (libxml2_loaded_p) [!!WINDOWSNT]: 'inine' -> 'inline'.
2736
9078ead6
EZ
27372012-04-07 Eli Zaretskii <eliz@gnu.org>
2738
2739 Support building on MS-Windows with libxml2.
2740
2741 * makefile.w32-in (OBJ2): Add xml.$(O).
2742 (GLOBAL_SOURCES): Add xml.c.
2743 ($(BLD)/xml.$(O)): New dependency list.
2744
2745 * xml.c (DEF_XML2_FN, LOAD_XML2_FN) [WINDOWSNT]: New macros.
2746 (fn_htmlReadMemory, fn_xmlReadMemory, fn_xmlDocGetRootElement)
2747 (fn_xmlFreeDoc, fn_xmlCleanupParser, fn_xmlCheckVersion)
2748 [!WINDOWSNT]: New macros.
2749 (init_libxml2_functions, libxml2_loaded_p): New functions.
2750 (parse_region): Call fn_xmlCheckVersion instead of using the macro
2751 LIBXML_TEST_VERSION. Call libxml2 functions via the fn_* macros.
2752 (xml_cleanup_parser): New function, export for fn_xmlCleanupParser.
2753 Calls xmlCleanupParser only if libxml2 was loaded (or statically
2754 linked in).
6bbef4e5
JC
2755 (Flibxml_parse_html_region, Flibxml_parse_xml_region):
2756 Call init_libxml2_functions before calling libxml2 functions.
9078ead6
EZ
2757 (syms_of_xml) <Qlibxml2_dll>: DEFSYM it.
2758
2759 * emacs.c: Don't include libxml/parser.h.
2760 (shut_down_emacs): Call xml_cleanup_parser, instead of calling
2761 xmlCleanupParser directly.
2762
2763 * lisp.h [HAVE_LIBXML2]: Add prototype for xml_cleanup_parser.
2764
3811fdf3
EZ
27652012-04-07 Eli Zaretskii <eliz@gnu.org>
2766
2767 * indent.c (Fvertical_motion): If there is a display string at
2768 point, use it.vpos to compute how many lines to backtrack after
2769 move_it_to point. (Bug#11133)
2770
2f8e16b2
EZ
27712012-04-06 Eli Zaretskii <eliz@gnu.org>
2772
2773 * buffer.h (FETCH_CHAR, FETCH_MULTIBYTE_CHAR):
2774 * character.h (STRING_CHAR, STRING_CHAR_AND_LENGTH): Add comments
2775 about subtle differences between FETCH_CHAR* and STRING_CHAR*
2776 macros related to unification of CJK characters. For the details,
2777 see the discussion following the message here:
2778 http://debbugs.gnu.org/cgi/bugreport.cgi?bug=11073#14.
2779
3d439cd1
CY
27802012-04-04 Chong Yidong <cyd@gnu.org>
2781
2782 * keyboard.c (Vdelayed_warnings_list): Doc fix.
2783
8bc53d00
EZ
27842012-04-01 Eli Zaretskii <eliz@gnu.org>
2785
2786 * w32menu.c (simple_dialog_show, add_menu_item): Use SAFE_ALLOCA
2787 instead of alloca. (Bug#11138)
2788
3b0512a3
AS
27892012-04-01 Andreas Schwab <schwab@linux-m68k.org>
2790
2791 * w32menu.c (is_simple_dialog): Properly check lisp types.
2792 (Bug#11141)
2793
8427ddd2
EZ
27942012-03-31 Eli Zaretskii <eliz@gnu.org>
2795
979022ef
EZ
2796 * xdisp.c (move_it_by_lines): When DVPOS is positive, and the
2797 position we get to after a call to move_it_to fails the
2798 IS_POS_VALID_AFTER_MOVE_P test, move to the next buffer position
2799 only if we wind up in a string from display property. (Bug#11063)
2800
a6b1c7cc
EZ
2801 * window.c (Fdelete_other_windows_internal): Invalidate the row
2802 and column information about mouse highlight, so that redisplay
2803 restores it after reallocating the glyph matrices. (Bug#7464)
2804
8427ddd2
EZ
2805 * xdisp.c (set_cursor_from_row): If `cursor' property on a display
2806 string comes from a `display' text property, use the buffer
2807 position of that property as if we actually saw that position in
2808 the row's glyphs.
697ba24b
EZ
2809 (move_it_by_lines): Remove the assertion that
2810 "it->current_x == 0 && it->hpos == 0" which can be legitimately
2811 violated when there's a before-string at the beginning of a line.
2812 (Bug#11063)
8427ddd2 2813
65a0a738
EZ
28142012-03-30 Eli Zaretskii <eliz@gnu.org>
2815
2816 * xdisp.c (append_space_for_newline): If the default face was
2817 remapped, use the remapped face for the appended newline.
2818 (extend_face_to_end_of_line): Use the remapped default face for
2819 extending the face to the end of the line.
2820 (display_line): Call extend_face_to_end_of_line when the default
2821 face was remapped. (Bug#11068)
2822
581355cc
EZ
28232012-03-29 Eli Zaretskii <eliz@gnu.org>
2824
2825 * s/ms-w32.h: Discourage from defining HAVE_GETCWD.
2826
e8fc049f
SM
28272012-03-28 Stefan Monnier <monnier@iro.umontreal.ca>
2828
2829 * keyboard.c (safe_run_hooks_error): Don't unquote strings.
2830
4fb9a543
GM
28312012-03-27 Glenn Morris <rgm@gnu.org>
2832
2833 * search.c (Fword_search_backward_lax, Fword_search_forward_lax):
2834 Doc fixes.
2835
679910f1
KH
28362012-03-26 Kenichi Handa <handa@m17n.org>
2837
2838 * dispextern.h (struct glyph): Fix previous change. Change the
2839 bit length of glyphless.ch to 25 (Bug#11082).
2840
90d49b7f
CY
28412012-03-26 Chong Yidong <cyd@gnu.org>
2842
2843 * keyboard.c (Vselection_inhibit_update_commands): New variable.
2844 (command_loop_1): Use it; inhibit selection update for
2845 handle-select-window too (Bug#8996).
2846
f514f6f0
FP
28472012-03-25 Fabrice Popineau <fabrice.popineau@supelec.fr>
2848
e8fc049f 2849 * w32heap.c (_heap_init, _heap_term): Remove dead MSVC-specific code.
f514f6f0 2850
bf43fa51
KH
28512012-03-25 Kenichi Handa <handa@m17n.org>
2852
2853 * dispextern.h (struct glyph): Change the bit length of
2854 glyphless.ch to 22 to make the member glyphless fit in 32 bits.
2855
8a0c01dd
EZ
28562012-03-24 Eli Zaretskii <eliz@gnu.org>
2857
2858 * s/ms-w32.h (tzname): Include time.h before redirecting to
2859 _tzname. Fixes the MSVC build. (Bug#9960)
2860
7d1c3a76
AS
28612012-03-24 Andreas Schwab <schwab@linux-m68k.org>
2862
8ed79523
AS
2863 * xdisp.c (produce_glyphless_glyph): Limit length of acronym to 6
2864 characters.
2865
7d1c3a76
AS
2866 * xterm.c (XTread_socket): Only modify handling_signal if
2867 !SYNC_INPUT. (Bug#11080)
2868
e99a9b8b
EZ
28692012-03-23 Eli Zaretskii <eliz@gnu.org>
2870
2871 * bidi.c (bidi_fetch_char): Use STRING_CHAR_AND_LENGTH instead of
2872 FETCH_MULTIBYTE_CHAR followed by CHAR_BYTES. Prevents crashes
2873 when fetching a multibyte character consumes more bytes than
2874 CHAR_BYTES returns, due to unification of CJK characters in
2875 string_char. (Bug#11073)
2876
5063c0e1
TN
28772012-03-23 Troels Nielsen <bn.troels@gmail.com> (tiny change)
2878
2879 * process.c (wait_reading_process_output): Handle pty disconnect
2880 by refraining from sending oneself a SIGCHLD (bug#10933).
2881
9f851fbd
CY
28822012-03-22 Chong Yidong <cyd@gnu.org>
2883
2884 * dispextern.h (struct it): New member string_from_prefix_prop_p.
2885
5063c0e1 2886 * xdisp.c (push_prefix_prop): Rename from push_display_prop.
9f851fbd
CY
2887 Mark string as coming from a prefix property.
2888 (handle_face_prop): Use default face for prefix strings (Bug#4281).
2889 (pop_it, reseat_1): Save and restore string_from_prefix_prop_p.
2890
fb5b8aca
CY
28912012-03-21 Chong Yidong <cyd@gnu.org>
2892
2893 * xfaces.c (Vface_remapping_alist): Doc fix.
2894
62356a1b
EZ
28952012-03-20 Eli Zaretskii <eliz@gnu.org>
2896
2897 * w32proc.c (Fw32_set_console_codepage)
5063c0e1
TN
2898 (Fw32_set_console_output_codepage, Fw32_get_codepage_charset):
2899 Doc fixes.
62356a1b 2900
025de85b
CY
29012012-03-20 Chong Yidong <cyd@gnu.org>
2902
2903 * dispnew.c (Fredisplay, Vredisplay_preemption_period): Update doc
2904 to reflect default non-nil value of redisplay-dont-pause.
2905
4827f94e
KH
29062012-03-19 Kenichi Handa <handa@m17n.org>
2907
2908 * ftfont.c (ftfont_drive_otf): Mask bits of character code to make
2909 it fit in a valid range (Bug#11003).
2910
e50a24a2
EZ
29112012-03-18 Eli Zaretskii <eliz@gnu.org>
2912
2913 * xdisp.c (cursor_row_p): Even if the glyph row ends in a string
2914 that is not from display property, accept the row as a "cursor
2915 row" if one of the string's character has a non-nil `cursor'
2916 property. Fixes cursor positioning when there are newlines in
2917 overlay strings, e.g. in icomplete.el. (Bug#11035)
2918
9af5ed87
PE
29192012-03-12 Paul Eggert <eggert@cs.ucla.edu>
2920
2921 * buffer.c (compare_overlays): Don't assume args differ (Bug#6830).
2922
d1f55f16
CY
29232012-03-12 Chong Yidong <cyd@gnu.org>
2924
2925 * eval.c (inhibit_lisp_code): Rename from
2926 inhibit_window_configuration_change_hook; move from window.c.
2927
2928 * xfns.c (unwind_create_frame_1, Fx_create_frame):
2929 * window.c (run_window_configuration_change_hook)
2930 (syms_of_window): Callers changed.
2931
66c5eebd
CY
29322012-03-11 Chong Yidong <cyd@gnu.org>
2933
413df973
CY
2934 * keymap.c (Fkey_description): Doc fix (Bug#9700).
2935
66c5eebd
CY
2936 * editfns.c (Fconstrain_to_field): Doc fix (Bug#9452).
2937
1de11f56
CY
29382012-03-10 Chong Yidong <cyd@gnu.org>
2939
2940 * frame.c (other_visible_frames): Don't assume the selected frame
2941 is visible (Bug#10955).
2942
cae07000
SM
29432012-03-09 Stefan Monnier <monnier@iro.umontreal.ca>
2944
2945 * buffer.c (compare_overlays): Avoid qsort's instability (bug#6830).
2946
89c94350
JD
29472012-03-08 Jan Djärv <jan.h.d@swipnet.se>
2948
2949 * gtkutil.c (x_wm_set_size_hint): Use one row in call to
2950 FRAME_TEXT_LINES_TO_PIXEL_HEIGHT so base_height is greater than
2951 zero (Bug#10954).
2952
999dd333
GM
29532012-03-03 Glenn Morris <rgm@gnu.org>
2954
01a6dcc8 2955 * alloc.c (Fgarbage_collect, misc-objects-consed): Doc fixes.
999dd333 2956
de0100f2
EZ
29572012-03-02 Eli Zaretskii <eliz@gnu.org>
2958
2959 * xdisp.c (try_window_reusing_current_matrix): Don't move cursor
2960 position past the first glyph_row that ends at ZV. (Bug#10902)
b8456c5c
EZ
2961 (redisplay_window, next_element_from_string): Fix typos in
2962 comments.
3e441275
EZ
2963 (redisplay_window): Pass to move_it_vertically the margin in
2964 pixels, not in screen lines.
de0100f2 2965
96a72ee9
GM
29662012-03-02 Glenn Morris <rgm@gnu.org>
2967
2968 * buffer.c (buffer-list-update-hook): Doc fix.
2969
312508d7
EZ
29702012-02-29 Eli Zaretskii <eliz@gnu.org>
2971
2972 * xdisp.c (get_overlay_strings_1): Under bidi redisplay, call
2973 push_it before setting up the iterator for the first overlay
2974 string, even if we have an empty string loaded.
2975 (next_overlay_string): If there's an empty string on the iterator
2976 stack, pop the stack. (Bug#10903)
2977
27f3c637
PE
29782012-02-25 Paul Eggert <eggert@cs.ucla.edu>
2979
2980 Generalize fix for crash due to non-contiguous EMACS_INT (Bug#10780).
2981 Suggested by Stefan Monnier in
2982 <http://lists.gnu.org/archive/html/emacs-devel/2012-02/msg00692.html>.
2983 * alloc.c (widen_to_Lisp_Object): New static function.
2984 (mark_memory): Also mark Lisp_Objects by fetching pointer words
2985 and widening them to Lisp_Objects. This would work even if
2986 USE_LSB_TAG is defined and wide integers are used, which might
2987 happen in a future version of Emacs.
2988
3c9dfce6
CY
29892012-02-25 Chong Yidong <cyd@gnu.org>
2990
fa74b241
CY
2991 * fileio.c (Ffile_selinux_context, Fset_file_selinux_context):
2992 Doc fix.
2993
3c9dfce6
CY
2994 * xselect.c (Fx_selection_exists_p): Doc fix.
2995 (x_clipboard_manager_save_all): Print an informative message
2996 before saving to clipboard manager.
2997
9486df08
CY
29982012-02-24 Chong Yidong <cyd@gnu.org>
2999
3000 * keyboard.c (process_special_events): Handle all X selection
3001 requests in kbd_buffer, not just the next one (Bug#8869).
3002
f01d3321
CY
30032012-02-23 Chong Yidong <cyd@gnu.org>
3004
3005 * xfns.c (Fx_create_frame): Avoid window-configuration-change-hook
3006 call when setting menu-bar-lines and tool-bar-lines parameters.
3007 (unwind_create_frame_1): New helper function.
3008
3009 * window.c (inhibit_window_configuration_change_hook): New var.
3010 (run_window_configuration_change_hook): Obey it.
b2e4ca7d 3011 (syms_of_window): Initialize it.
f01d3321 3012
86b847b6
CY
30132012-02-22 Chong Yidong <cyd@gnu.org>
3014
3015 * xterm.c (x_draw_image_relief): Add missing type check for
3016 Vtool_bar_button_margin (Bug#10743).
3017
a59225b1
CY
30182012-02-21 Chong Yidong <cyd@gnu.org>
3019
3020 * fileio.c (Vfile_name_handler_alist): Doc fix.
3021
3022 * buffer.c (Fget_file_buffer): Protect against invalid file
3023 handler return value.
3024
310f5bd4
PE
30252012-02-20 Paul Eggert <eggert@cs.ucla.edu>
3026
cb3a28cc
PE
3027 * .gdbinit (xreload): Don't assume EMACS_INT fits in 'long'
3028 when computing $valmask.
3029
310f5bd4
PE
3030 Fix crash due to non-contiguous EMACS_INT (Bug#10780).
3031 * lisp.h (VALBITS): Move definition up, so that USE_LSB_TAG can use it.
3032 (USE_LSB_TAG): Do not define if UINTPTR_MAX >> VALBITS == 0.
3033 It's useless in that case, and it can cause problems on hosts
3034 that allocate halves of EMACS_INT values separately.
3035 Reported by Dan Horák. Diagnosed by Andreas Schwab in
3036 <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=10780#30>.
3037 * mem-limits.h (EXCEEDS_LISP_PTR): Define to 0 on hosts where
3038 UINTPTR_MAX >> VALBITS == 0. This is required by the above change;
3039 it avoids undefined behavior on hosts where shifting right by more
3040 than the word width has undefined behavior.
3041
2375c96a
CY
30422012-02-19 Chong Yidong <cyd@gnu.org>
3043
3044 * fileio.c (Ffile_name_directory, Ffile_name_nondirectory)
3045 (Funhandled_file_name_directory, Ffile_name_as_directory)
3046 (Fdirectory_file_name, Fexpand_file_name)
3047 (Fsubstitute_in_file_name): Protect against invalid file handler
3048 return values (Bug#10845).
3049
3eb49e71
EZ
30502012-02-18 Eli Zaretskii <eliz@gnu.org>
3051
3052 * .gdbinit (pitx): Fix incorrect references to fields of the
3053 iterator stack.
3054
7b926f3f
CY
30552012-02-17 Chong Yidong <cyd@gnu.org>
3056
3057 * syntax.c (Fscan_lists): Doc fix (Bug#10833).
3058
11273115
PE
30592012-02-15 Paul Eggert <eggert@cs.ucla.edu>
3060
3061 * image.c (MAX_IMAGE_SIZE): Increase from 6.0 to 10.0; see
3062 <http://lists.gnu.org/archive/html/emacs-devel/2012-02/msg00540.html>.
3063
c3a70e2b
CY
30642012-02-15 Chong Yidong <cyd@gnu.org>
3065
3066 * eval.c (Fdefvar, Fdefconst): Doc fix; note that the variable is
3067 marked as special. Also, starting docstrings with * is obsolete.
3068
0ca43699
AS
30692012-02-13 Andreas Schwab <schwab@linux-m68k.org>
3070
3071 * gnutls.c (emacs_gnutls_write): Fix last change.
3072
2e8f3c56
LI
30732012-02-13 Lars Ingebrigtsen <larsi@gnus.org>
3074
3075 * gnutls.c (emacs_gnutls_write): Set errno appropriately for
3076 send_process.
3077
af70074f
SM
30782012-02-13 Stefan Monnier <monnier@iro.umontreal.ca>
3079
3080 * keymap.c (Fsingle_key_description): Handle char ranges.
3081
95986d52
CY
30822012-02-12 Chong Yidong <cyd@gnu.org>
3083
afd83bd1
CY
3084 * xdisp.c (handle_stop): Avoid assigning -1 to it->face_id here,
3085 as that creates a dangerous corner case.
3086
95986d52
CY
3087 * window.c (Fdelete_window_internal): Invalidate the mouse
3088 highlight (Bug#9904).
3089
bd7da63e
GM
30902012-02-12 Glenn Morris <rgm@gnu.org>
3091
3092 * xselect.c (Fx_own_selection_internal)
3093 (Fx_get_selection_internal, Fx_disown_selection_internal)
3094 (Fx_selection_owner_p, Fx_selection_exists_p): Doc fixes.
3095 * nsselect.m (Fx_own_selection_internal)
3096 (Fx_disown_selection_internal, Fx_selection_exists_p)
3097 (Fx_selection_owner_p, Fx_get_selection_internal):
3098 Sync docs and argument specs with the xselect.c versions.
3099
77abcbc2
LI
31002012-02-11 Lars Ingebrigtsen <larsi@gnus.org>
3101
3102 * gnutls.c (emacs_gnutls_write): Don't infloop if sendto fails.
3103
90b671e2
EZ
31042012-02-11 Eli Zaretskii <eliz@gnu.org>
3105
1c0ca0b7
EZ
3106 * w32select.c (Fx_selection_exists_p): Sync doc string and
3107 argument list with xselect.c. (Bug#10783)
3108
3109 * w16select.c (Fx_selection_exists_p): Sync doc string and
3110 argument list with xselect.c. (Bug#10783)
90b671e2 3111
49241268
GM
31122012-02-10 Glenn Morris <rgm@gnu.org>
3113
3114 * fns.c (Fsecure_hash): Doc fix.
3115
f998bbe7 31162012-02-09 Kenichi Handa <handa@m17n.org>
5c1ca13d
KH
3117
3118 * coding.c (produce_chars): Fix updating of src_end (Bug#10701).
3119
0992bd9c
CY
31202012-02-07 Chong Yidong <cyd@gnu.org>
3121
3122 * buffer.c (Fbuffer_local_variables)
3123 (buffer_lisp_local_variables): Handle unbound vars correctly;
3124 don't let Qunbound leak into Lisp.
3125
af008560
GM
31262012-02-07 Glenn Morris <rgm@gnu.org>
3127
dd605cc4
GM
3128 * image.c (Fimagemagick_types): Doc fix.
3129
af008560
GM
3130 * image.c (imagemagick-render-type): Change it from a lisp object
3131 to an integer. Move the doc here from the lisp manual.
3132 Treat all values not equal to 0 the same.
3133
1449fa1d
CY
31342012-02-06 Chong Yidong <cyd@gnu.org>
3135
3136 * doc.c (store_function_docstring): Avoid applying docstring of
3137 alias to base function (Bug#2603).
3138
3723ec07
AS
31392012-02-04 Andreas Schwab <schwab@linux-m68k.org>
3140
3141 * .gdbinit (pp1, pv1): Remove redundant defines.
3142 (pr): Use pp.
3143
79c1cc1e
CY
31442012-02-04 Chong Yidong <cyd@gnu.org>
3145
3146 * nsterm.m: Declare a global (Bug#10694).
3147
d7f29f8e
EZ
31482012-02-04 Eli Zaretskii <eliz@gnu.org>
3149
cae07000
SM
3150 * w32.c (get_emacs_configuration_options):
3151 Include --enable-checking, if specified, in the return value.
d7f29f8e 3152
3b95a6f9
MR
31532012-02-04 Martin Rudalics <rudalics@gmx.at>
3154
3155 * dispnew.c (change_frame_size_1): Calculate new_frame_total_cols
3156 after rounding frame sizes. (Bug#9723)
3157
d6fa96a6
EZ
31582012-02-04 Eli Zaretskii <eliz@gnu.org>
3159
3160 * keyboard.c (adjust_point_for_property): Don't position point
3161 before BEGV. (Bug#10696)
3162
df0b2940
PE
31632012-02-03 Paul Eggert <eggert@cs.ucla.edu>
3164
3165 Handle overflow when computing char display width (Bug#9496).
3166 * character.c (char_width): Return EMACS_INT, not int.
3167 (char_width, c_string_width): Check for overflow when
3168 computing the width; this is possible now that individual
3169 characters can have unbounded width. Problem introduced
3170 by merge from Emacs 23 on 2012-01-19.
3171
6bee44d6
MA
31722012-02-02 Michael Albinus <michael.albinus@gmx.de>
3173
3174 * dbusbind.c (Fdbus_register_method): Mention the return value
3175 :ignore in the docstring.
3176
44f92739
GM
31772012-02-02 Glenn Morris <rgm@gnu.org>
3178
1b9f60cc
GM
3179 * callproc.c (Fcall_process, Fcall_process_region): Doc fix.
3180
44f92739
GM
3181 * nsterm.m (syms_of_nsterm) <x-toolkit-scroll-bars>:
3182 Unconditionally set to t. (Bug#10673)
3183 * nsterm.m (syms_of_nsterm) <x-toolkit-scroll-bars>:
3184 * w32term.c (syms_of_w32term) <x-toolkit-scroll-bars>:
3185 * xterm.c (syms_of_xterm) <x-toolkit-scroll-bars>: Doc fix.
3186
c5d3843c
KH
31872012-02-02 Kenichi Handa <handa@m17n.org>
3188
3189 (x_produce_glyphs): Cancel previous change. If cmp->glyph_len is
3190 0, do not call append_composite_glyph.
3191
159462d4 31922012-02-02 Kenichi Handa <handa@m17n.org>
d2a51fd7
KH
3193
3194 * xdisp.c (BUILD_COMPOSITE_GLYPH_STRING): Initialize first_s to
3195 NULL (Bug#6988).
3196 (x_produce_glyphs): If the component of a composition is a null
3197 string, set it->pixel_width to 1 to avoid zero-width glyph.
3198
78cef877
EZ
31992012-02-01 Eli Zaretskii <eliz@gnu.org>
3200
3201 * ralloc.c (resize_bloc, r_alloc_sbrk): Don't call memmove if its
3202 first 2 arguments are identical. This makes inserting large
3203 output from a subprocess an order of magnitude faster on
3204 MS-Windows, where all sbrk'ed memory is always contiguous.
3205
97897668
GM
32062012-01-31 Glenn Morris <rgm@gnu.org>
3207
3208 * nsterm.m (syms_of_nsterm) <x-toolkit-scroll-bars>:
c78c6e0b 3209 * w32term.c (syms_of_w32term) <x-toolkit-scroll-bars>:
97897668
GM
3210 * xterm.c (syms_of_xterm) <x-toolkit-scroll-bars>: Sync docs.
3211
31fd3586
GM
32122012-01-29 Glenn Morris <rgm@gnu.org>
3213
3214 * gnutls.c (syms_of_gnutls): More doc (from etc/NEWS).
3215
0e24a8b2
CY
32162012-01-28 Samuel Thibault <sthibault@debian.org> (tiny change)
3217
3218 * s/gnu.h: Define POSIX_SIGNALS (Bug#10552).
3219
cc0adcb0
CY
32202012-01-28 Chong Yidong <cyd@gnu.org>
3221
3222 * minibuf.c (syms_of_minibuf): Doc fix (Bug#10550).
3223
acc28cb9
CY
32242012-01-26 Chong Yidong <cyd@gnu.org>
3225
9c69cfb7
CY
3226 * keyboard.c (Vecho_keystrokes): Document zero value (Bug#10503).
3227
acc28cb9
CY
3228 * search.c (Fsearch_forward, Fsearch_backward): Document negative
3229 repeat counts (Bug#10507).
3230
48da7392
GM
32312012-01-26 Glenn Morris <rgm@gnu.org>
3232
3233 * lread.c (syms_of_lread): Doc fix.
3234
14af5f7f
CY
32352012-01-25 HIROSHI OOTA <nil@mad.dog.cx> (tiny change)
3236
3237 * coding.c (encode_designation_at_bol): Change return value to
3238 EMACS_INT.
3239
0b21c100
CY
32402012-01-25 Chong Yidong <cyd@gnu.org>
3241
3242 * eval.c (Fuser_variable_p): Doc fix; mention custom-variable-p.
3243
3c2907f7
CY
32442012-01-21 Chong Yidong <cyd@gnu.org>
3245
3246 * floatfns.c (Fcopysign): Make the second argument non-optional,
3247 since nil is not allowed anyway.
3248
959ad23f
AS
32492012-01-21 Andreas Schwab <schwab@linux-m68k.org>
3250
3251 * process.c (read_process_output): Use p instead of XPROCESS (proc).
3252 (send_process): Likewise.
3253
34a02f46
MR
32542012-01-19 Martin Rudalics <rudalics@gmx.at>
3255
3256 * window.c (save_window_save, Fcurrent_window_configuration)
cae07000
SM
3257 (Vwindow_persistent_parameters): Do not use Qstate.
3258 Rewrite doc-strings.
34a02f46 3259
1259009a 32602012-01-19 Kenichi Handa <handa@m17n.org>
25ed9e61
KH
3261
3262 * character.c (char_width): New function.
70d4fdf6
GM
3263 (Fchar_width, c_string_width, lisp_string_width):
3264 Use char_width (Bug#9496).
25ed9e61 3265
6a6ee00d
MR
32662012-01-16 Martin Rudalics <rudalics@gmx.at>
3267
3268 * window.c (Vwindow_persistent_parameters): New variable.
3269 (Fset_window_configuration, save_window_save): Handle persistent
3270 window parameters.
3271
c85efaf7
EZ
32722012-01-14 Eli Zaretskii <eliz@gnu.org>
3273
3274 * w32fns.c (signal_user_input): Don't do a QUIT, to avoid
3275 thrashing the stack of the thread. (Bug#9087)
3276
5944709e
PE
32772012-01-12 Paul Eggert <eggert@cs.ucla.edu>
3278
3279 * xdisp.c (rows_from_pos_range): Add parens as per gcc -Wparentheses.
3280
e71f5d99
EZ
32812012-01-11 Eli Zaretskii <eliz@gnu.org>
3282
3283 * xdisp.c (rows_from_pos_range): Handle the case where the
3284 highlight ends on a newline. (Bug#10464)
3285 (mouse_face_from_buffer_pos): Fix off-by-one error in calculating
3286 he end column for display of highlight that ends on a newline
3287 before a R2L line.
3288
ce316182
GM
32892012-01-11 Glenn Morris <rgm@gnu.org>
3290
3291 * lread.c (init_lread): If no-site-lisp, remove site-lisp dirs
3292 from load-path also when installation-directory is nil. (Bug#10208)
3293
5b43da69
GM
32942012-01-10 Glenn Morris <rgm@gnu.org>
3295
74cc8ff9
GM
3296 * emacs.c (syms_of_emacs) <installation-directory>: Doc fix.
3297
7d8d6e4e
GM
3298 * epaths.in (PATH_LOADSEARCH, PATH_EXEC, PATH_DATA, PATH_DOC):
3299 Update template values to be closer to their typical values these days.
5b43da69 3300
a0db8d43
EZ
33012012-01-09 Eli Zaretskii <eliz@gnu.org>
3302
3303 * xdisp.c (rows_from_pos_range): Accept additional argument
3304 DISP_STRING, and accept any glyph in a row whose object is that
3305 string as eligible for mouse highlight. Fixes mouse highlight of
3306 display strings from overlays. (Bug#10464)
3307
9a0115ab 33082012-01-07 Paul Eggert <eggert@cs.ucla.edu>
09450bae 3309
b9110d6a 3310 emacs: fix an auto-save permissions race condition (Bug#10400)
09450bae
PE
3311 * fileio.c (auto_saving_dir_umask): New static var.
3312 (Fmake_directory_internal): Use it.
3313 (do_auto_save_make_dir): Set it, instead of invoking chmod after
3314 creating the directory. The old code temporarily assigns
3315 too-generous permissions to the directory.
3316 (do_auto_save_eh): Clear it.
b9110d6a 3317 (Fdo_auto_save): Catch all errors, not just file errors, so
09450bae
PE
3318 that the var is always cleared.
3319
6c1bd3f3
EZ
33202012-01-07 Eli Zaretskii <eliz@gnu.org>
3321
3322 * search.c (scan_buffer): Pass character positions to
3323 know_region_cache, not byte positions. (Bug#6540)
3324
069d2b50
L
33252012-01-07 LynX <_LynX@bk.ru> (tiny change)
3326
3327 * w32.c (sys_rename): Report EXDEV when rename of a directory
3328 fails because the target is on another logical disk. (Bug#10284)
3329
75bf0d33
DB
33302012-01-07 David Benjamin <davidben@mit.edu> (tiny change)
3331
3332 * xterm.c (x_embed_request_focus): New function.
3333
3334 * xterm.h: Add prototype.
3335
3336 * xfns.c (Fx_focus_frame): Use it for embedded frames (Bug#9977).
3337
1c6e5a32
GM
33382012-01-05 Glenn Morris <rgm@gnu.org>
3339
3340 * emacs.c (emacs_copyright): Update short copyright year to 2012.
3341
651e947e
EZ
33422012-01-01 Eli Zaretskii <eliz@gnu.org>
3343
3344 * gnutls.c (init_gnutls_functions): Load gnutls_check_version.
3345 Load gnutls_transport_set_lowat only if GnuTLS version is below
3346 2.11.1.
3347 (emacs_gnutls_handshake): Call gnutls_transport_set_lowat only for
3348 GnuTLS versions below 2.11.1.
3349
3778cdd8
AL
33502011-12-31 Antoine Levitt <antoine.levitt@gmail.com>
3351
3352 * xdisp.c (syms_of_xdisp) <window-scroll-functions>: Add warning
3353 to the doc string advising against its use for altering the way
3354 windows are scrolled.
3355
0e5317f7
KH
33562011-12-28 Kenichi Handa <handa@m17n.org>
3357
3358 * coding.c (Fdefine_coding_system_internal): Make an utf-8 base
3359 coding-system ASCII compatible only when it does not produce BOM
3360 on encoding (Bug#10383).
3361
93d5ca1f
JD
33622011-12-26 Jan Djärv <jan.h.d@swipnet.se>
3363
3364 * xmenu.c (x_menu_wait_for_event): Use xg_select for Gtk3 so menus
3365 can scroll.
3366 (create_and_show_popup_menu): Always use menu_position_func for
3367 Gtk3 (Bug#10361).
3368
ca22b785
AS
33692011-12-24 Andreas Schwab <schwab@linux-m68k.org>
3370
3371 * callint.c (Fcall_interactively): Don't truncate prompt string.
3372
d048e1e6
EZ
33732011-12-23 Eli Zaretskii <eliz@gnu.org>
3374
3375 * xdisp.c (handle_invisible_prop): Handle correctly an invisible
3376 property that ends at ZV, so that the bidi iteration could be
3ba1a2ad 3377 resumed from there (after widening). (Bug#10360)
d048e1e6 3378
5ccaba1f
JD
33792011-12-22 Jan Djärv <jan.h.d@swipnet.se>
3380
3381 * nsfont.m (ns_spec_to_descriptor): Do not autorelease fdesc.
3382
204ee57f
JD
33832011-12-21 Jan Djärv <jan.h.d@swipnet.se>
3384
b81d40f0
JB
3385 * nsterm.m (x_free_frame_resources):
3386 Release f->output_data.ns->miniimage.
204ee57f
JD
3387 (ns_index_color): Fix indentation. Do not retain
3388 color_table->colors[i].
3389
3390 * nsmenu.m (ns_update_menubar): Call free_menubar_widget_value_tree
3391 before returning.
3392
3393 * nsfns.m (x_set_background_color): Assign return value from
3394 ns_index_color to face-background instead of NSColor*.
3395 (ns_implicitly_set_icon_type): Fix indentation.
3396 Change assignment in for loop to comparison.
3397
3398 * emacs.c (ns_pool): New variable.
3399 (main): Assign ns_pool.
3400 (Fkill_emacs): Call ns_release_autorelease_pool.
3401
3402 * nsfont.m (ns_spec_to_descriptor): Fix indentation,
3403 autorelease fdesc, release fdAttrs and tdict.
3404 (ns_get_covering_families): Release charset.
3405 (ns_findfonts): Release NSFontDescriptor created with new.
3406 (ns_uni_to_glyphs): Fix indentation.
3407 (setString): Release attrStr before assigning new value.
3408
c803b2b7
JD
34092011-12-18 Jan Djärv <jan.h.d@swipnet.se>
3410
678f4426
JD
3411 * nsmenu.m (NSMenuDidBeginTrackingNotification): Declare if OSX < 10.5
3412 and NS_IMPL_COCOA.
3413 (trackingNotification): Surround with ifdef NS_IMPL_COCOA.
3414 (syms_of_nsmenu): Set trackingMenu to 1 if not NS_IMPL_COCOA.
3415
cd394be1 34162011-12-18 David Reitter <reitter@cmu.edu>
678f4426 3417
5fecd5fc
JD
3418 * nsterm.m (ns_term_init): Subscribe for notifications
3419 NSMenuDidBeginTrackingNotification and NSMenuDidEndTrackingNotification
3420 to method trackingNotification in EmacsMenu.
3421
3422 * nsmenu.m (trackingMenu): New variable.
3771cb17 3423 (trackingNotification): New method (from Aquamacs).
5fecd5fc 3424 (menuNeedsUpdate): Expand comment and return if trackingMenu is 0,
3771cb17 3425 from Aquamacs (Bug#7030).
678f4426
JD
3426
34272011-12-18 Jan Djärv <jan.h.d@swipnet.se>
5fecd5fc 3428
c803b2b7
JD
3429 * nsselect.m (CUT_BUFFER_SUPPORT): Remove define.
3430 (symbol_to_nsstring): Fix indentation.
3431 (ns_symbol_to_pb): New function.
cae07000
SM
3432 (Fns_get_selection_internal): Rename from Fns_get_cut_buffer_internal.
3433 (Fns_rotate_cut_buffers_internal): Remove.
3434 (Fns_store_selection_internal): Rename from
c803b2b7
JD
3435 Fns_store_cut_buffer_internal.
3436 (ns_get_foreign_selection, Fx_own_selection_internal)
3437 (Fx_disown_selection_internal, Fx_selection_exists_p)
b81d40f0
JB
3438 (Fns_get_selection_internal, Fns_store_selection_internal):
3439 Use ns_symbol_to_pb and check if return value is nil.
3440 (syms_of_nsselect): Remove ifdef CUT_BUFFER_SUPPORT. Remove defsubr
3441 Sns_rotate_cut_buffers_internal. Sns_get_cut_buffer_internal
c803b2b7
JD
3442 renamed to Sns_get_selection_internal, Sns_store_cut_buffer_internal
3443 renamed to Sns_store_selection_internal.
3444 (ns_handle_selection_request): Move code to Fx_own_selection_internal
3445 and remove this function.
3446 (ns_handle_selection_clear): Remove, never used.
3447 (Fx_own_selection_internal): Move code from ns_handle_selection_request
3448 here.
3449
e1b01a3a
KB
34502011-12-17 Ken Brown <kbrown@cornell.edu>
3451
3452 * fileio.c (check_writable) [CYGWIN]: Return non-zero if UID or
3453 GID is unknown (Bug#10257).
3454
2adb6e85
PE
34552011-12-17 Paul Eggert <eggert@cs.ucla.edu>
3456
3457 * s/gnu-linux.h: Fix mark_memory typo (Bug#10286).
3458 (GC_MARK_SECONDARY_STACK): Omit removed 3rd arg to mark_memory,
3459 which caused a build failure on GNU/Linux IA-64. This problem was
3460 introduced by my 2011-10-07 patch.
3461
d1d7b339
JL
34622011-12-15 Juri Linkov <juri@jurta.org>
3463
3464 * image.c (imagemagick_error): New function. (Bug#10112)
3465 (imagemagick_load_image): Comment out `MagickSetResolution' call.
3466 Use `imagemagick_error' where ImageMagick functions return
3467 `MagickFalse'.
3468 (Fimagemagick_types): Add `Fnreverse' to return the list in the
3469 proper order.
3470
100d5755
KH
34712011-12-15 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
3472
3473 * xftfont.c (xftfont_draw): Use the font metrics of s->font to
3474 fill background (Bug#8992).
3475
454592a6
MR
34762011-12-13 Martin Rudalics <rudalics@gmx.at>
3477
3478 * window.c (Vwindow_combination_resize)
3479 (Vwindow_combination_limit): Use t instead of non-nil in
3480 doc-strings.
61d4b438
MR
3481 (Vrecenter_redisplay): Add first sentence of doc-string on
3482 separate line.
53524d93 3483 (Frecenter): Fix doc-string typo.
454592a6 3484
3633e3aa
KH
34852011-12-11 Kenichi Handa <handa@m17n.org>
3486
3487 * coding.c (Funencodable_char_position): Pay attention to the
3488 buffer text relocation (Bug#9389).
3489
7b9d523a 34902011-12-10 Jan Djärv <jan.h.d@swipnet.se>
61ccba97 3491
7b9d523a
JD
3492 * xterm.c (x_term_init): Move call to gdk_window_add_filter before
3493 gtk_init (Bug#10100).
3494
b73189c6
EZ
34952011-12-10 Eli Zaretskii <eliz@gnu.org>
3496
3497 * xdisp.c (RECORD_MAX_MIN_POS): Use IT->cmp_it.charpos only if
3498 IT->string is nil. (Bug#10263)
3499
f7dfe5d6
JD
35002011-12-10 Jan Djärv <jan.h.d@swipnet.se>
3501
83faebb4
JD
3502 * nsterm.h (x_free_frame_resources): Declare.
3503
f7dfe5d6
JD
3504 * nsfns.m (ns_get_defaults_value): New function (Bug#10103).
3505 (Fns_get_resource, x_get_string_resource): Call ns_get_defaults_value.
3506
3507 * nsterm.h (ns_get_defaults_value): Declare.
3508
3509 * nsterm.m (ns_default): Call ns_get_defaults_value.
3510
7cd4e72c
EZ
35112011-12-09 Eli Zaretskii <eliz@gnu.org>
3512
3513 * xdisp.c (try_scrolling): Don't set scroll_down_p if dy is zero.
3514 (Bug#10170)
3515
b34d7317
YM
35162011-12-09 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
3517
3518 * unexelf.c (unexec) [NS_IMPL_GNUSTEP]: Take account of the case
3519 that where the value of an _OBJC_* symbol points to is in the .bss
3520 section (Bug#10240).
3521
76470ad1
KH
35222011-12-08 Kazuhiro Ito <kzhr@d1.dion.ne.jp> (tiny change)
3523
3524 * coding.c (encode_coding_ccl): Check (charbuf < charbuf_end)
2fac8180 3525 after the loop to call ccl_driver at least once (Bug#8619).
76470ad1 3526
745fff94
KH
35272011-12-08 Kenichi Handa <handa@m17n.org>
3528
3529 * ftfont.c (get_adstyle_property): Fix previous change
3530 (Bug#10233).
3531
6e44397c
JB
35322011-12-07 Juanma Barranquero <lekktu@gmail.com>
3533
3534 * w32.c (init_environment): If no_site_lisp, remove site-lisp
3535 dirs from the default value of EMACSLOADPATH (bug#10208).
3536
7efa6272
GM
35372011-12-07 Glenn Morris <rgm@gnu.org>
3538
3539 * lread.c (init_lread): If no_site_lisp, exclude site-lisp/ in
3540 installation and source directories as well. (Bug#10208)
3541
f6fc4d87
CY
35422011-12-06 Chong Yidong <cyd@gnu.org>
3543
3544 * minibuf.c (Fread_from_minibuffer): Doc fix (Bug#10228).
3545
2bf26180
GM
35462011-12-06 Glenn Morris <rgm@gnu.org>
3547
3548 * process.c (start_process_unwind): Treat any pid <= 0, except -2,
3549 as an error, not just -1. (Bug#10217)
3550
3a6ad4f0
CY
35512011-12-05 Chong Yidong <cyd@gnu.org>
3552
3553 * keyboard.c (process_special_events): New function.
3554 (swallow_events, Finput_pending_p): Use it (Bug#10195).
3555
75a3b399
PE
35562011-12-05 Paul Eggert <eggert@cs.ucla.edu>
3557
3558 * coding.c (encode_designation_at_bol): Don't use uninitialized
3559 local variable (Bug#9318).
3560
c3c9e25e
KH
35612011-12-05 Kenichi Handa <handa@m17n.org>
3562
3563 * ftfont.c (get_adstyle_property): If the font is not BDF nor PCF,
3564 return Qnil (Bug#8046, Bug#10193).
3565
5eb05ea3
KH
35662011-12-05 Kenichi Handa <handa@m17n.org>
3567
3568 * coding.c (encode_designation_at_bol): New args charbuf_end and
3569 dst. Return the number of produced bytes. Callers changed.
a79703f5
KH
3570 (coding_set_source): Return how many bytes coding->source was
3571 relocated.
3572 (coding_set_destination): Return how many bytes
3573 coding->destination was relocated.
3574 (CODING_DECODE_CHAR, CODING_ENCODE_CHAR, CODING_CHAR_CHARSET)
cae07000 3575 (CODING_CHAR_CHARSET_P): Adjust for the avove changes.
5eb05ea3
KH
3576
35772011-12-05 Kazuhiro Ito <kzhr@d1.dion.ne.jp> (tiny change)
3578
3579 * coding.c (CODING_CHAR_CHARSET_P): New macro.
3580 (encode_coding_emacs_mule, encode_coding_iso_2022): Use the above
3581 macro (Bug#9318).
3582
35832011-12-05 Andreas Schwab <schwab@linux-m68k.org>
3584
3585 The following changes are to fix Bug#9318.
3586
a79703f5 3587 * coding.c (CODING_ENCODE_CHAR, CODING_CHAR_CHARSET): New macros.
5eb05ea3
KH
3588 (encode_coding_emacs_mule, ENCODE_ISO_CHARACTER)
3589 (encode_coding_iso_2022, encode_coding_sjis)
a79703f5 3590 (encode_coding_big5, encode_coding_charset): Use the above macros.
5eb05ea3 3591
7dbda6df
JB
35922011-12-05 Juanma Barranquero <lekktu@gmail.com>
3593
3594 * lisp.h (process_quit_flag): Fix external declaration.
3595
6d5eb5b0
SM
35962011-12-04 Stefan Monnier <monnier@iro.umontreal.ca>
3597
3598 Don't macro-inline non-performance-critical code.
3599 * eval.c (process_quit_flag): New function.
3600 * lisp.h (QUIT): Use it.
3601
a0c3fad0
JD
36022011-12-04 Jan Djärv <jan.h.d@swipnet.se>
3603
3604 * nsfns.m (get_geometry_from_preferences): New function.
3605 (Fx_create_frame): Call get_geometry_from_preferences (Bug#10103).
3606
6c07aac2
AS
36072011-12-04 Andreas Schwab <schwab@linux-m68k.org>
3608
3609 * emacs.c (Qkill_emacs): Define.
3610 (syms_of_emacs): Initialize it.
3611 * keyboard.c (interrupt_signal): Don't call Fkill_emacs here, set
3612 Qquit_flag to `kill-emacs' instead.
6d5eb5b0
SM
3613 (quit_throw_to_read_char): Add parameter `from_signal'.
3614 All callers changed. Call Fkill_emacs if requested and safe.
6c07aac2
AS
3615 * lisp.h (QUIT): Call Fkill_emacs if requested.
3616
c052ead4
JD
36172011-12-03 Jan Djärv <jan.h.d@swipnet.se>
3618
3619 * widget.c (update_wm_hints): Return if wmshell is null.
3620 (widget_update_wm_size_hints): New function.
3621
3622 * widget.h (widget_update_wm_size_hints): Declare.
3623
3624 * xterm.c (x_wm_set_size_hint): If USE_X_TOOLKIT, call
3625 widget_update_wm_size_hints (Bug#10104).
3626
9e49252b
EZ
36272011-12-03 Eli Zaretskii <eliz@gnu.org>
3628
3629 * xdisp.c (handle_invisible_prop): If the invisible text ends just
3630 before a newline, prepare the bidi iterator for consuming the
3631 newline, and keep the current paragraph direction. (Bug#10183)
e9a49426 3632 (redisplay_window): Don't let `margin' become negative. (Bug#10192)
9e49252b 3633
02b16839
JL
36342011-12-02 Juri Linkov <juri@jurta.org>
3635
3636 * search.c (Fword_search_regexp): New Lisp function created from
3637 `wordify'. Change type of arg `lax' from `int' to `Lisp_Object'.
3638 (Fword_search_backward, Fword_search_forward)
3639 (Fword_search_backward_lax, Fword_search_forward_lax):
3640 Use `Fword_search_regexp' instead of `wordify'. Doc fix.
3641 (syms_of_search): Define `Sword_search_regexp'. (Bug#10145)
3642
0068070e
SM
36432011-12-01 Stefan Monnier <monnier@iro.umontreal.ca>
3644
3645 * fileio.c (Finsert_file_contents): Move after-change-function call
3646 to before the "handled:" label, since all "goto handled" appear in
3647 cases where the *-change-functions have already been properly called
3648 (bug#10117).
3649
3360a3fc
AS
36502011-12-01 Andreas Schwab <schwab@linux-m68k.org>
3651
3652 * keyboard.c (interrupt_signal): Don't call kill-emacs when
3653 waiting for input. (Bug#10169)
3654
73d6c093
EZ
36552011-11-30 Eli Zaretskii <eliz@gnu.org>
3656
3657 * dispnew.c (adjust_glyph_matrix): Remove the assertion that
3658 verifies glyph row's hash code--we have just reallocated the
3659 glyphs, so their contents can be complete garbage. (Bug#10164)
3660
febe6bea
JB
36612011-11-30 Juanma Barranquero <lekktu@gmail.com>
3662
3663 * dispnew.c (adjust_glyph_matrix) [XASSERTS]: Add missing check.
3664
801a4313
EZ
36652011-11-30 Eli Zaretskii <eliz@gnu.org>
3666
3667 * dispnew.c (adjust_glyph_matrix) [XASSERTS]: Ensure ROW's
3668 attributes are tested _before_ calling verify_row_hash, to protect
3669 against GCC re-ordering of the tests. (Bug#10164)
3670
2b56b87e
JD
36712011-11-29 Jan Djärv <jan.h.d@swipnet.se>
3672
3673 * xterm.h (struct x_output): net_wm_state_hidden_seen is new.
3674
3675 * xterm.c (handle_one_xevent): Only set async_visible and friends
3676 if net_wm_state_hidden_seen is non-zero (Bug#10002)
7dbda6df 3677 (get_current_wm_state): Set net_wm_state_hidden_seen to 1 if
2b56b87e
JD
3678 _NET_WM_STATE_HIDDEN is in NET_WM_STATE.
3679
dbf31225
PE
36802011-11-28 Paul Eggert <eggert@cs.ucla.edu>
3681
3682 Remove GCPRO-related macros that exist only to avoid shadowing locals.
3683 * lisp.h (GCPRO1_VAR, GCPRO2_VAR, GCPRO3_VAR, GCPRO4_VAR, GCPRO5_VAR)
3684 (GCPRO6_VAR, UNGCPRO_VAR): Remove. See
3685 <http://lists.gnu.org/archive/html/emacs-diffs/2011-11/msg00265.html>.
3686 All uses changed to use GCPRO1 etc.
3687 (GCPRO1, GCPRO2, GCPRO3, GCPRO4, GCPRO5, GCPRO6, UNGCPRO):
3688 Revert to old implementation (i.e., before 2011-03-11).
3689
1305621b
YM
36902011-11-28 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
3691
3692 * dispnew.c (scrolling_window): Truncate overlaps in copy destination
3693 of scroll runs so as to avoid assigning disabled bogus rows and
3694 unnecessary graphics copy operations.
3695
8c9afb46
EZ
36962011-11-27 Eli Zaretskii <eliz@gnu.org>
3697
3698 * s/ms-w32.h (utimbuf) [_MSC_VER]: Don't define.
3699 (snprintf) [_MSC_VER]: Redirect to _snprintf.
3700 (strtoll) [_MSC_VER]: Redirect to _strtoi64.
3701 (malloc, free, realloc, calloc): Redirect to e_* only when
3702 compiling Emacs.
3703
3704 * lisp.h (GCTYPEBITS): Move before first use.
3705 (ALIGN_GCTYPEBITS) [_MSC_VER]: Define.
3706 (DECL_ALIGN) [_MSC_VER]: Use it, as MSVC doesn't like bit ops in
3707 this macro definition.
3708
3709 * s/ms-w32.h (tzname): Redirect to _tzname for all values of
3710 _MSC_VER.
3711
54e9e3bf
JD
37122011-11-27 Jan Djärv <jan.h.d@swipnet.se>
3713
6d5eb5b0
SM
3714 * gtkutil.c (xg_create_frame_widgets):
3715 Call gtk_window_set_has_resize_grip (FALSE) if that function is
54e9e3bf
JD
3716 present with Gtk+ 2.0.
3717
83aca1cb
PE
37182011-11-26 Paul Eggert <eggert@cs.ucla.edu>
3719
3720 * fileio.c (Finsert_file_contents): Undo previous change; see
3721 <http://lists.gnu.org/archive/html/emacs-diffs/2011-11/msg00265.html>.
3722
5b76caa4
PE
37232011-11-26 Paul Eggert <eggert@cs.ucla.edu>
3724
3725 Rename locals to avoid shadowing.
3726 * fileio.c (Finsert_file_contents):
3727 Rename inner 'gcpro1' to 'inner_gcpro1' to avoid shadowing.
3728 * process.c (wait_reading_process_output):
3729 Rename inner 'proc' to 'p' to avoid shadowing.
3730 Indent for consistency with usual Emacs style.
3731
8c535114
EZ
37322011-11-25 Eli Zaretskii <eliz@gnu.org>
3733
3734 * xdisp.c (redisplay_window): If cursor row is not fully visible
3735 after recentering, and scroll-conservatively is set to a large
3736 number, scroll window by a few more lines to make the cursor fully
3737 visible and out of scroll-margin. (Bug#10105)
91b4a718
EZ
3738 (start_display): Don't move to the next line if the display should
3739 start at a newline that is part of a display vector or an overlay
3740 string. (Bug#10119)
8c535114 3741
fa4fdb5c
JL
37422011-11-24 Juri Linkov <juri@jurta.org>
3743
3744 * image.c (imagemagick_load_image): Move `MagickSetResolution' down
3745 after the `MagickPingImage' call. (Bug#10112)
3746
90ec88df
CY
37472011-11-23 Chong Yidong <cyd@gnu.org>
3748
3749 * window.c (Fcoordinates_in_window_p): Accept only live windows.
3750
56e2e794
MR
37512011-11-23 Martin Rudalics <rudalics@gmx.at>
3752
3753 * buffer.c (Fkill_buffer): Run replace_buffer_in_windows before
3754 making another buffer current. (Bug#10114)
3755
b6e64c41
GM
37562011-11-23 Glenn Morris <rgm@gnu.org>
3757
3758 * font.c (font_find_for_lface) [HAVE_NS]: Ignore case. (Bug#2526)
3759
6b21de18
CY
37602011-11-23 Chong Yidong <cyd@gnu.org>
3761
3762 * xdisp.c (compute_stop_pos): Check validity of end_charpos before
3763 using it (Bug#5984).
3764
b12cd789
EZ
37652011-11-22 Eli Zaretskii <eliz@gnu.org>
3766
3767 * dispnew.c (adjust_glyph_matrix): Don't verify hash code of mode-
3768 and header-lines, as they don't have one computed for them.
3769 (Bug#10098)
3770
3771 * .gdbinit (prow): Make displayed values more self-explaining.
3772 Add row's hash code.
3773
261b6fd4
LMI
37742011-11-21 Lars Magne Ingebrigtsen <larsi@gnus.org>
3775
3776 * process.c (wait_reading_process_output): Fix asynchrounous
3777 GnuTLS socket handling on some versions of the GnuTLS library.
16c1ad08 3778 (wait_reading_process_output): Add comment and URL.
261b6fd4 3779
e7cfd277
JD
37802011-11-21 Jan Djärv <jan.h.d@swipnet.se>
3781
3782 * xterm.c (x_clear_frame): Reinstate the XClearWindow call.
3783
a9b9b7f5
CY
37842011-11-21 Chong Yidong <cyd@gnu.org>
3785
3786 * window.c (Fnext_window, Fprevious_window): Doc fix.
3787
b0d15b4f
SM
37882011-11-20 Stefan Monnier <monnier@iro.umontreal.ca>
3789
3790 * window.c (get_phys_cursor_glyph): Fix Lisp_Object/int mixup.
3791
fe7a3057
JB
37922011-11-20 Juanma Barranquero <lekktu@gmail.com>
3793
3794 * nsfont.m (syms_of_nsfont) <ns-reg-to-script>: Fix typo.
3795
d2999b1a
MR
37962011-11-20 Martin Rudalics <rudalics@gmx.at>
3797
3798 * window.c (Fset_window_combination_limit): Rename argument
3799 STATUS to LIMIT.
3800 (Vwindow_combination_limit): Remove "status" from doc-string.
3801
d5ff9cd0
AS
38022011-11-20 Andreas Schwab <schwab@linux-m68k.org>
3803
3804 * m/ibms390.h: Remove.
3805 * m/ibms390x.h: Don't include "ibms390.h".
3806
a5bb9bd3
SM
38072011-11-20 Stefan Monnier <monnier@iro.umontreal.ca>
3808
3809 * fileio.c (Finsert_file_contents): Add missing gcpro1 variable.
3810 Suggested by Dmitry Antipov <dmantipov@yandex.ru>.
3811
cd1181db
JB
38122011-11-20 Juanma Barranquero <lekktu@gmail.com>
3813
3814 * casetab.c (Fset_case_table):
3815 * charset.c (Fcharset_after): Fix typos.
3816
615a3b8d 38172011-11-20 Paul Eggert <eggert@cs.ucla.edu>
6a0bf43d 3818
17e845af
PE
3819 Standardize on VIRT_ADDR_VARIES behavior (Bug#10042).
3820 Otherwise, valgrind does not work on some platforms.
3821 Problem reported by Andreas Schwab in
6a0bf43d
PE
3822 <http://lists.gnu.org/archive/html/emacs-devel/2011-11/msg00081.html>.
3823 * puresize.h (pure, PURE_P): Always behave as if VIRT_ADDR_VARIES
3824 is set, removing the need for VIRT_ADDRESS_VARIES.
3825 (PURE_P): Use a more-efficient implementation that needs just one
3826 comparison, not two: on x86-64 with GCC 4.6.2, this cut down the
3827 number of instructions from 6 (xorl, cmpq, jge, xorl, cmpq, setge)
3828 to 4 (xorl, subq, cmpq, setbe).
3829 * alloc.c (pure): Always extern now, since that's the
3830 VIRT_ADDR_VARIES behavior.
3831 (PURE_POINTER_P): Use a single comparison, not two, for
3832 consistency with the new puresize.h.
3833 * lisp.h (PNTR_COMPARISON_TYPE): Remove; no longer needed.
3834 * m/ibms390.h, m/intel386.h, m/template.h, s/cygwin.h, s/hpux10-20.h:
3835 Remove VIRT_ADDR_VARIES no longer needed.
3836
f8fe6f96
EZ
38372011-11-19 Eli Zaretskii <eliz@gnu.org>
3838
3839 * xdisp.c (x_write_glyphs, draw_phys_cursor_glyph)
3840 (erase_phys_cursor, update_window_cursor, show_mouse_face)
3841 (cursor_in_mouse_face_p): If the cursor position is out of bounds,
3842 behave as if the cursor position were at the window margin.
3843
3844 * window.c (get_phys_cursor_glyph): If the window is hscrolled,
3845 and the cursor position is out of bounds, behave as if the cursor
3846 position were at the window margin. (Bug#10075)
3847
df05a53c
CY
38482011-11-18 Chong Yidong <cyd@gnu.org>
3849
3850 * window.c (Fwindow_combination_limit): Make first argument
3851 non-optional, since it is meaningless for live windows like the
3852 selected window.
61ccba97 3853
2071918e
DA
38542011-11-18 Dmitry Antipov <dmantipov@yandex.ru>
3855
3856 * keymap.c (Fwhere_is_internal): Add missing RETURN_UNGCPROs.
3857
b50a28de
SM
38582011-11-18 Stefan Monnier <monnier@iro.umontreal.ca>
3859
3860 * intervals.c: Fix grafting over the whole buffer (bug#10071).
3861 (graft_intervals_into_buffer): Simplify.
3862
015137db
EZ
38632011-11-18 Eli Zaretskii <eliz@gnu.org>
3864
3865 * dispnew.c (swap_glyph_pointers): Swap the used[] arrays and the
3866 hash values of the two rows.
3867 (copy_row_except_pointers): Preserve the used[] arrays and the
3868 hash values of the two rows. (Bug#10035)
68c95424 3869 (add_row_entry): Add xassert to verify that ROW's hash code is valid.
015137db
EZ
3870
3871 * xdisp.c (row_hash): New function, body extracted from
3872 compute_line_metrics.
3873 (compute_line_metrics): Call row_hash, instead of computing the
3874 hash code inline.
3875
3876 * dispnew.c (verify_row_hash): Call row_hash for computing the
3877 hash code of a row, instead of duplicating code from xdisp.c.
3878
3879 * dispextern.h (row_hash): Add prototype.
3880
a2addb04
TH
38812011-11-18 Tassilo Horn <tassilo@member.fsf.org>
3882
3883 * frame.c (delete_frame): Don't delete the terminal when the last
3884 X frame is closed if emacs is built with GTK toolkit.
3885
df85d315
JB
38862011-11-17 Juanma Barranquero <lekktu@gmail.com>
3887
3888 * window.c (syms_of_window) <window-combination-resize>: Fix typo.
3889
a0c2d0ae
MR
38902011-11-17 Martin Rudalics <rudalics@gmx.at>
3891
3892 * window.c (Vwindow_splits): Rename to
3893 Vwindow_combination_resize. Suggested by Juri Linkov.
3894 (Fsplit_window_internal): Use Vwindow_combination_resize instead
3895 of Vwindow_splits.
3896
58179cce
JB
38972011-11-16 Juanma Barranquero <lekktu@gmail.com>
3898
7877f373
JB
3899 * nsfns.m (Fns_font_name):
3900 * window.c (syms_of_window) <window-combination-limit>: Fix typos.
58179cce 3901
b6f67890
MR
39022011-11-16 Martin Rudalics <rudalics@gmx.at>
3903
3904 * window.h (window): Rename slot "nest" to "combination_limit".
3905 * window.c (Fwindow_nest): Rename to Fwindow_combination_limit.
3906 (Fset_window_nest): Rename to Fset_window_combination_limit.
3907 (Vwindow_nest): Rename to Vwindow_combination_limit.
3908 (recombine_windows, make_parent_window, make_window)
3909 (Fsplit_window_internal, saved_window)
3910 (Fset_window_configuration, save_window_save): Rename all
3911 occurrences of window_nest to window_combination_limit.
3912
c7015153
JB
39132011-11-15 Juanma Barranquero <lekktu@gmail.com>
3914
3915 * image.c (imagemagick_load_image): Fix typo.
3916
322ad6ec
EZ
39172011-11-14 Eli Zaretskii <eliz@gnu.org>
3918
3919 * xdisp.c (display_line): Move the call to
3920 highlight_trailing_whitespace before the call to
3921 compute_line_metrics, since the latter needs to see the final
6d5eb5b0
SM
3922 faces of all the glyphs to compute ROW's hash value.
3923 Fixes assertion violations in row_equal_p. (Bug#10035)
322ad6ec 3924
f067b8ec
JB
39252011-11-14 Juanma Barranquero <lekktu@gmail.com>
3926
3927 * w32proc.c (reader_thread): Don't check pending input if cp->fd < 0,
3928 just return (bug#10044).
3929
1e5b2111
EZ
39302011-11-12 Eli Zaretskii <eliz@gnu.org>
3931
7ef3cbd5
EZ
3932 * makefile.w32-in (HEAPSIZE): New variable, allows to build temacs
3933 with user-defined heap size. Bump the default size of the temacs
3934 heap to 27MB, to avoid memory warning when running temacs.
3935 ($(TEMACS)): Use HEAPSIZE instead of a hardcoded value.
3936
1e5b2111
EZ
3937 * dispnew.c (scrolling_window): Fix incorrect indices in accessing
3938 current_matrix and desired_matrix. (Bug#9990)
7a7270dd
EZ
3939 (verify_row_hash) [XASSERTS]: New function.
3940 (adjust_glyph_matrix, row_equal_p): Use it in xassert to verify
3941 that the hash value of glyph rows is correct.
1e5b2111 3942
89d61221
MR
39432011-11-12 Martin Rudalics <rudalics@gmx.at>
3944
3945 * window.h (window): Remove splits slot.
3946 * window.c (Fwindow_splits, Fset_window_splits): Remove.
3947 (Fdelete_other_windows_internal, make_parent_window)
3948 (make_window, Fsplit_window_internal, Fdelete_window_internal)
3949 (Fset_window_configuration, save_window_save): Don't deal with
3950 split status of windows.
3951 (saved_window): Remove splits slot.
3952 (Vwindow_splits): Rewrite doc-string.
3953
97f18cc8
JD
39542011-11-11 Jan Djärv <jan.h.d@swipnet.se>
3955
3956 * xfns.c (unwind_create_frame):
3957 * nsfns.m (unwind_create_frame):
3958 * w32fns.c (unwind_create_frame): Use Fmemq to check if frame is in
3959 Vframe_list (Bug#9999).
3960
22a648b4
DA
39612011-11-11 Dmitry Antipov <dmantipov@yandex.ru>
3962
0b381c7e 3963 * xdisp.c (syms_of_xdisp): Remove duplicated definition of Qtext.
22a648b4 3964
659afede
KH
39652011-11-11 Kenichi Handa <handa@m17n.org>
3966
3967 * callproc.c (Fcall_process): Set the member dst_multibyte of
3968 process_coding.
3969
9ac0394b
KH
39702011-11-11 Johan Bockgård <bojohan@gnu.org>
3971
3972 * xdisp.c (fill_composite_glyph_string): Always set s->face, to
3973 avoid a crash (bug#9496).
3974
2fbdc249
CY
39752011-11-09 Chong Yidong <cyd@gnu.org>
3976
3977 * window.c (Fwindow_inside_edges, Fwindow_inside_pixel_edges)
3978 (Fwindow_inside_absolute_pixel_edges): Only allow live windows.
3979
ac6b1f81
PE
39802011-11-08 Paul Eggert <eggert@cs.ucla.edu>
3981
3982 * s/gnu.h (GC_MARK_STACK): Define to GC_MAKE_GCPROS_NOOPS (Bug#9926).
3983
09db192c
PE
39842011-11-08 Paul Eggert <eggert@cs.ucla.edu>
3985
3986 Avoid some portability problems by eschewing 'extern inline' functions.
3987 The trivial performance wins aren't worth the portability hassles; see
3988 <http://lists.gnu.org/archive/html/emacs-devel/2011-11/msg00084.html>
3989 et seq.
3990 * dispextern.h (window_box, window_box_height, window_text_bottom_y)
3991 (window_box_width, window_box_left, window_box_left_offset)
3992 (window_box_right, window_box_right_offset): Undo previous change,
3993 by removing the "extern"s.
3994 * intervals.c (adjust_intervals_for_insertion)
3995 (adjust_intervals_for_deletion): Undo previous change,
3996 making these static again.
3997 (offset_intervals, temp_set_point_both, temp_set_point)
3998 (copy_intervals_to_string): No longer inline.
3999 * xdisp.c (window_text_bottom_y, window_box_width)
4000 (window_box_height, window_box_left_offset)
4001 (window_box_right_offset, window_box_left, window_box_right)
4002 (window_box): No longer inline.
4003
105216ed
CY
40042011-11-08 Chong Yidong <cyd@gnu.org>
4005
4006 * window.c (Fwindow_left_column, Fwindow_top_line): Doc fix.
6d5eb5b0
SM
4007 (Fwindow_body_height, Fwindow_body_width): Move from Lisp.
4008 Signal an error if not a live window.
105216ed
CY
4009 (Fwindow_total_width, Fwindow_total_height): Move from Lisp.
4010 (Fwindow_total_size, Fwindow_body_size): Move to Lisp.
4011
ae9e237f
JB
40122011-11-07 Juanma Barranquero <lekktu@gmail.com>
4013
4014 * lisp.h (syms_of_abbrev): Remove declaration.
4015 Reported by CHENG Gao <chenggao@royau.me>.
4016
c7aa8333
EZ
40172011-11-07 Eli Zaretskii <eliz@gnu.org>
4018
4019 * w32.c (check_windows_init_file): Don't look for term/w32-win.el
4020 if Vpurify_flag is non-nil. Fixes a crash when running w32 build
4021 of temacs in GUI mode.
4022
be7f5545
MR
40232011-11-07 Martin Rudalics <rudalics@gmx.at>
4024
4025 * window.h: Declare delete_all_child_windows instead of
4026 delete_all_subwindows.
4027 * window.c (Fwindow_nest, Fset_window_nest)
4028 (Fset_window_new_total, Fset_window_new_normal)
4029 (Fwindow_resize_apply): Don't use term subwindow in doc-strings.
4030 (delete_all_subwindows): Rename to delete_all_child_windows.
4031 (Fdelete_other_windows_internal, Fset_window_configuration):
4032 Call delete_all_child_windows instead of delete_all_subwindows.
4033 * frame.c (delete_frame): Call delete_all_child_windows instead
4034 of delete_all_subwindows.
4035
ca78dc43
PE
40362011-11-07 Paul Eggert <eggert@cs.ucla.edu>
4037
4038 * alloc.c (DEADP): New macro, for porting to GNU/Hurd (Bug#9926).
4039 This is also needed for porting to any host where GC_MARK_STACK is
4040 not GC_MAKE_GCPROS_NOOPS.
4041 (which_symbols): Use it.
4042
a0241d01
KH
40432011-11-07 Kenichi Handa <handa@m17n.org>
4044
4045 * coding.c (coding_set_destination): Check coding->src_pos only
4046 when coding->src_object is a buffer (bug#9910).
4047
4048 * process.c (send_process): Set the member src_multibyte of coding
4049 to 0 (bug#9911) when sending a unibyte text.
4050
4051 * callproc.c (Fcall_process): Set the member src_multibyte of
4052 process_coding to 0 (bug#9912).
4053
a64bfdfa 40542011-11-06 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
ba24cea2
YM
4055
4056 * xmenu.c (cleanup_widget_value_tree): New function.
4057 (xmenu_show, xdialog_show): Use it in record_unwind_protect instead of
4058 calling free_menubar_widget_value_tree directly (Bug#9830).
4059
cb41b32a
PE
40602011-11-06 Paul Eggert <eggert@cs.ucla.edu>
4061
4062 Fix some portability problems with 'inline'.
4063 * dispextern.h (window_box, window_box_height, window_text_bottom_y)
4064 (window_box_width, window_box_left, window_box_left_offset)
4065 (window_box_right, window_box_right_offset): Declare extern.
4066 Otherwise, these inline functions do not conform to C99 and
4067 are miscompiled by Microsoft compilers. Reported by Eli Zaretskii in
4068 <http://lists.gnu.org/archive/html/emacs-devel/2011-11/msg00084.html>.
4069 * intervals.c (adjust_intervals_for_insertion)
4070 (adjust_intervals_for_deletion): Now extern, because otherwise the
4071 extern inline functions 'offset_intervals' couldn't refer to it.
4072 (static_offset_intervals): Remove.
4073 (offset_intervals): Rewrite using the old contents of
4074 static_offset_intervals. The old version didn't conform to C99
4075 because an extern inline function contained a reference to an
4076 identifier with static linkage.
4077
b7041366
AS
40782011-11-06 Andreas Schwab <schwab@linux-m68k.org>
4079
4080 * keyboard.c (interrupt_signal): Don't call kill-emacs while in
4081 GC.
4082
88a37c4d
EZ
40832011-11-06 Eli Zaretskii <eliz@gnu.org>
4084
4085 * xdisp.c (init_iterator, reseat_to_string): Don't set the
4086 iterator's bidi_p flag if Vpurify_flag is non-nil. (Bug#9963)
4087 (Fcurrent_bidi_paragraph_direction): If Vpurify_flag is non-nil,
4088 return Qleft_to_right.
4089
49745b39
CY
40902011-11-06 Chong Yidong <cyd@gnu.org>
4091
4092 * window.c (Fwindow_live_p, Fwindow_frame, Fframe_root_window)
4093 (Fminibuffer_window, Fwindow_buffer, Fwindow_splits)
4094 (Fset_window_splits, Fwindow_nest, Fset_window_nest)
4095 (Fwindow_use_time, Fwindow_total_size, Fwindow_normal_size)
4096 (Fwindow_new_normal, Fwindow_left_column, Fwindow_top_line)
4097 (Fwindow_margins, Fwindow_fringes, Fwindow_scroll_bars)
4098 (Fwindow_vscroll): Doc fix.
4099 (Fwindow_top_child, Fwindow_left_child): Eliminate a nil default
4100 argument, since it makes no sense to pass a live window and for
4101 consistency with window-child.
4102
1f05cd82
CS
41032011-11-05 Christoph Scholtes <cschol2112@googlemail.com>
4104
4105 * makefile.w32-in ($(TEMACS), (gl-stamp)): Use $(THISDIR) to
4106 support MSVC.
4107
22610910
JR
41082011-11-05 Jason Rumney <jasonr@gnu.org>
4109
4110 * w32font.c (font_matches_spec): Filter out non-Japanese kana fonts.
4111 (add_font_entity_to_list): Filter out non-Japanese Shift-JIS
4112 fonts (Bug#6029).
4113 (add_font_entity_to_list): Fix logic errors in mixed boolean and
4114 bitwise arithmetic preventing use of unicode-sip and non-truetype
4115 opentype fonts.
4116
a06776b2
EZ
41172011-11-05 Eli Zaretskii <eliz@gnu.org>
4118
3ad924ba
EZ
4119 * s/ms-w32.h (fstat, stat, utime): Move redirections to
4120 "emacs"-only part.
4121
a06776b2
EZ
4122 * w32fns.c (x_create_tip_frame, Fx_create_frame): Rearrange
4123 initialization code to keep similarity to xfns.c after changes
4124 from 2011-11-05.
4125
c9e7db78
JD
41262011-11-05 Jan Djärv <jan.h.d@swipnet.se>
4127
a97f8f3f
JD
4128 * nsfns.m: Declare image_cache_refcount if GLYPH_DEBUG.
4129 (unwind_create_frame): New function (Bug#9943).
4130 (Fx_create_frame): Restructure code to be more similar to the one in
4131 xfns.c. Call record_unwind_protect with unwind_create_frame (Bug#9943).
4132 Initialize image_cache_refcount if GLYPH_DEBUG (Bug#9943).
4133 Move terminal->reference_count++ just before making the frame official
4134 (Bug#9943).
4135
4136 * nsterm.m (x_free_frame_resources): New function.
4137 (x_destroy_window): Move code to x_free_frame_resources.
4138
c9e7db78 4139 * xfns.c (unwind_create_frame): Fix comment.
6d5eb5b0
SM
4140 (Fx_create_frame, x_create_tip_frame):
4141 Move terminal->reference_count++ just before making the frame
75f1671a 4142 official. Move initialization of image_cache_refcount and
c9e7db78
JD
4143 dpyinfo_refcount before calling init_frame_faces (Bug#9943).
4144
a6fc3b5c
EZ
41452011-11-05 Eli Zaretskii <eliz@gnu.org>
4146
4147 Support MSVC build with newer versions of Visual Studio.
4148 * makefile.w32-in (TAGS-gmake): Don't use $(patsubst ...), as
4149 Nmake barfs on that. Use $(OBJ*_c) variables instead, defined on
4150 nt/gmake.defs.
4151
4152 * lisp.h (ENUM_BF): New macro, for enumerated types in bitfields,
4153 which are not supported by MSVC.
4154 (Lisp_Symbol, Lisp_Misc_Any, Lisp_Marker, Lisp_Misc_Overlay)
4155 (Lisp_Save_Value, Lisp_Free): Use ENUM_BF for enumerated types in
4156 bitfields.
4157 (Lisp_Object) [USE_LISP_UNION_TYPE]: Use ENUM_BF for enumerated
4158 types in bitfields.
4159 (DEFUN) [_MSC_VER]: Define in a different way for MSVC.
4160
4161 * w32fns.c [_MSC_VER]: DECLARE_HANDLE for any MSVC version.
4162
58179cce 41632011-11-05 Fabrice Popineau <fabrice.popineau@supelec.fr> (tiny change)
a6fc3b5c
EZ
4164
4165 Support MSVC build with newer versions of Visual Studio.
4166 * w32.c: Don't include w32api.h for MSVC.
4167 (init_environment) [_MSC_VER]: Call sys_access, not _access.
4168
4169 * s/ms-w32.h <sigset_t, ssize_t> [_MSC_VER]: Typedefs for MSVC.
4170 [_MSC_VER]: Include sys/timeb.h, sys/stat.h, and signal.h.
4171 (fstat, stat, utime) [_MSC_VER]: Redirect to their sys_* cousins.
4172 (malloc, free, realloc, calloc) [_MSC_VER]: Always redirect to the
4173 e_* cousins.
4174 (alloca) [_MSC_VER]: Define to _alloca.
4175
4176 * lisp.h (DECL_ALIGN) [_MSC_VER]: Define for MSVC.
4177
4178 * regex.c <re_char> [_MSC_VER]: A separate definition for MSVC.
4179
a58c13ed
EZ
41802011-11-04 Eli Zaretskii <eliz@gnu.org>
4181
4182 * xdisp.c (note_mouse_highlight): If either of
4183 previous/next-single-property-change returns nil, treat that as
4184 the beginning or the end of the buffer. (Bug#9955)
4185
fe0b6370
JD
41862011-11-04 Jan Djärv <jan.h.d@swipnet.se>
4187
a58c13ed 4188 * gtkutil.c (xg_make_tool_item): Add callbacks if one of wimage or
fe0b6370
JD
4189 label is not null (Bug#9951).
4190 (xg_tool_item_stale_p): Handle the fact that wimage and/or wlbl
4191 may be NULL.
4192
89bd5ee1
EZ
41932011-11-04 Eli Zaretskii <eliz@gnu.org>
4194
4195 * window.c (Fwindow_body_size): Mention in the doc string that the
4196 return value is in frame's canonical units. (Bug#9949)
4197
84c3edb9
EZ
41982011-11-03 Eli Zaretskii <eliz@gnu.org>
4199
4e2fb5c7
EZ
4200 * xdisp.c (note_mouse_highlight): Initialize `area'. (Bug#9947)
4201
84c3edb9 4202 * w32fns.c (unwind_create_frame): If needed, free the glyph
3ab15fd6 4203 matrices of the partially constructed frame. (Bug#9943)
2a58bbc1 4204 * xfns.c (unwind_create_frame): Likewise.
84c3edb9 4205
bc17a887
EZ
42062011-11-01 Eli Zaretskii <eliz@gnu.org>
4207
4208 * xdisp.c (mouse_face_from_buffer_pos): Fix a typo in a comment.
4209 Don't stop backward scan on the continuation glyph, even though
4210 its CHARPOS is positive.
6d5eb5b0
SM
4211 (mouse_face_from_buffer_pos, note_mouse_highlight):
4212 Rename cover_string to disp_string.
bc17a887 4213
4ee88440
MR
42142011-11-01 Martin Rudalics <rudalics@gmx.at>
4215
4216 * window.c (temp_output_buffer_show): Don't use
4217 Vtemp_buffer_show_specifiers.
4218 (Vtemp_buffer_show_specifiers): Remove unused variable.
4219
c2ff3c02
EZ
42202011-10-30 Eli Zaretskii <eliz@gnu.org>
4221
4222 * xdisp.c (try_cursor_movement): Make sure ROW isn't decremented
4223 past the beginning of the current glyph matrix.
4224
58179cce 42252011-10-30 Adam Sjøgren <asjo@koldfront.dk> (tiny change)
6e56383b
JD
4226
4227 * xterm.c: Include X11/Xproto.h if HAVE_GTK3.
4228 (x_error_handler): Ignore BadMatch for X_SetInputFocus for
4229 HAVE_GTK3 (Bug#9869).
b77a6a7f 4230
3b574623
JD
4231 * gtkutil.c (xg_win_to_widget, xg_event_is_for_menubar): Initialize
4232 type to GDK_NOTHING so valgrind does not complain (Bug#9901).
4233
b77a6a7f
JD
4234 * xterm.h (x_display_info): Add Xatom_net_wm_state_hidden (Bug#9893).
4235
4236 * xterm.c: Declare x_handle_net_wm_state to return int.
4237 (handle_one_xevent): Check if we are iconified but don't have
4238 _NET_WM_STATE_HIDDEN. If do, treat as deiconify (Bug#9893).
4239 (get_current_wm_state): Return non-zero if not hidden,
4240 check for _NET_WM_STATE_HIDDEN (Bug#9893).
4241 (do_ewmh_fullscreen): Ignore return value from get_current_wm_state.
4242 (x_handle_net_wm_state): Return what get_current_wm_state returns.
4243 (x_term_init): Initialize dpyinfo->Xatom_net_wm_state_hidden.
4244
196e41e4
PE
42452011-10-29 Paul Eggert <eggert@cs.ucla.edu>
4246
4247 * alloc.c (which_symbols): Declare EXTERNALLY_VISIBLE,
4248 so that this new function doesn't get optimized away by a
4249 whole-program optimizer. Make the 2nd arg EMACS_INT, not int.
4250
021f2e1a
AS
42512011-10-29 Andreas Schwab <schwab@linux-m68k.org>
4252
4253 * frame.h (MOUSE_HL_INFO): Remove excess parens.
4254
8b058d44
EZ
42552011-10-29 Eli Zaretskii <eliz@gnu.org>
4256
4257 Fix the `xbytecode' command.
4258 * .gdbinit (xprintbytestr): New command.
b50a28de 4259 (xwhichsymbols): Rename from `which'; all callers changed.
8b058d44
EZ
4260 (xbytecode): Print the byte-code string as well.
4261
4452fb80
EZ
42622011-10-29 Kim Storm <storm@cua.dk>
4263
8b058d44
EZ
4264 * alloc.c (which_symbols): New function.
4265
21b72067
AS
42662011-10-29 Andreas Schwab <schwab@linux-m68k.org>
4267
4268 * minibuf.c (read_minibuf_noninteractive): Allow reading empty
4269 line. (Bug#9903)
4270
83ed7b5c
GM
42712011-10-29 Glenn Morris <rgm@gnu.org>
4272
4273 * process.c (wait_reading_process_output): Revert 2009-08-30 change.
4274 Not clear what it was for, and it causes various bugs. (Bug#9839)
4275
5a7a728b
EZ
42762011-10-28 Eli Zaretskii <eliz@gnu.org>
4277
4278 * xdisp.c (note_mouse_highlight): Initialize `part', to avoid a
4279 possible random value that matches one of those tested as
4280 condition to clear the mouse face.
4281
d3d0842f
CY
42822011-10-28 Chong Yidong <cyd@gnu.org>
4283
4284 * xdisp.c (note_mouse_highlight): Fix use of uninitialized var.
4285
31b39d13
DN
42862011-10-28 Dan Nicolaescu <dann@ics.uci.edu>
4287
4288 * window.c (make_window): Initialize phys_cursor_on_p.
4289
9aba6043
SM
42902011-10-28 Stefan Monnier <monnier@iro.umontreal.ca>
4291
4292 * lisp.h (struct Lisp_Symbol): Update comments.
4293
c20992f4
JB
42942011-10-28 Juanma Barranquero <lekktu@gmail.com>
4295
4296 * w32font.c (w32_load_unicows_or_gdi32): Add missing return.
4297
db4f02f2
EZ
42982011-10-28 Eli Zaretskii <eliz@gnu.org>
4299
4300 Fix Emacs on Windows 9X (bug#8562). Thanks to oslsachem
4301 <oslsachem@gmail.com> for helping to debug this.
4302
4303 * w32font.c (g_b_init_is_w9x, g_b_init_get_outline_metrics_w)
4304 (g_b_init_get_text_metrics_w, g_b_init_get_glyph_outline_w)
4305 (g_b_init_get_glyph_outline_w): New static variables.
4306 (GetOutlineTextMetricsW_Proc, GetTextMetricsW_Proc)
4307 (GetGlyphOutlineW_Proc): New typedefs.
4308 (w32_load_unicows_or_gdi32, get_outline_metrics_w)
9aba6043
SM
4309 (get_text_metrics_w, get_glyph_outline_w, globals_of_w32font):
4310 New functions.
4311 (w32font_open_internal, compute_metrics):
4312 Call get_outline_metrics_w, get_text_metrics_w, and get_glyph_outline_w
db4f02f2
EZ
4313 instead of calling the "wide" APIs directly.
4314
4315 * emacs.c (main) [HAVE_NTGUI]: Call globals_of_w32font.
4316
4317 * w32.h (syms_of_w32font): Add prototype.
4318
87e68db4
JB
43192011-10-27 Juanma Barranquero <lekktu@gmail.com>
4320
4321 * window.c (Fframe_root_window, Fframe_first_window, Fwindow_end)
4322 (Fframe_selected_window, Ftemp_output_buffer_show, Fnext_window)
4323 (Fdelete_window_internal, Fwindow_parameters): Fix typos in docstrings.
4324 (Fmove_to_window_line): Doc fix.
4325
435c1d67
CY
43262011-10-27 Chong Yidong <cyd@gnu.org>
4327
4328 * process.c (make_process): Set gnutls_state to NULL.
4329
4330 * gnutls.c (emacs_gnutls_deinit): Deinit the gnutls_state if it is
4331 non-NULL, regardless of GNUTLS_INITSTAGE.
4332 (Fgnutls_boot): Cleanups. Call emacs_gnutls_deinit if we signal
4333 an error. Set process slots as soon as we allocate them.
4334
4335 * gnutls.h (GNUTLS_LOG, GNUTLS_LOG2): Fix macros.
4336
9c6c6f49
CY
43372011-10-27 Chong Yidong <cyd@gnu.org>
4338
9aba6043
SM
4339 * gnutls.c (emacs_gnutls_deinit): New function.
4340 Deallocate credentials structures as well as calling gnutls_deinit.
9c6c6f49
CY
4341 (Fgnutls_deinit, Fgnutls_boot): Use it.
4342
4343 * process.c (make_process): Initialize GnuTLS credentials to NULL.
4344 (deactivate_process): Call emacs_gnutls_deinit.
4345
657d08d3
JB
43462011-10-27 Juanma Barranquero <lekktu@gmail.com>
4347
4348 * image.c (x_create_x_image_and_pixmap):
4349 * w32.c (sys_rename, w32_delayed_load):
4350 * w32font.c (fill_in_logfont):
4351 * w32reg.c (x_get_string_resource): Silence compiler warnings.
4352
5430d399
JB
43532011-10-26 Juanma Barranquero <lekktu@gmail.com>
4354
4355 * w32fns.c (w32_default_color_map): New function,
4356 extracted from Fw32_default_color_map.
a7ef684b 4357 (Fw32_default_color_map, Fx_open_connection): Use it. (Bug#9785)
5430d399 4358
fe0055fa
PE
43592011-10-25 Paul Eggert <eggert@cs.ucla.edu>
4360
4361 * dispextern.h (Fcontrolling_tty_p): New decl (Bug#6649 part 2).
4362
e6346438
SM
43632011-10-25 Stefan Monnier <monnier@iro.umontreal.ca>
4364
4365 * keyboard.c (test_undefined): New function (bug#9751).
4366 (read_key_sequence): Use it to detect when a key is bound to `undefined'.
4367
e112cc37
ET
43682011-10-25 Enami Tsugutomo <tsugutomo.enami@jp.sony.com>
4369
4370 * sysdep.c (init_sys_modes): Fix the check for the controlling
4371 terminal (Bug#6649).
4372
7b5d6677
EZ
43732011-10-20 Eli Zaretskii <eliz@gnu.org>
4374
4375 * dispextern.h (struct bidi_it): New member next_en_type.
4376
4377 * bidi.c (bidi_line_init): Initialize the next_en_type member.
4378 (bidi_resolve_explicit_1): When next_en_pos is valid for the
4379 current character, check also for next_en_type being WEAK_EN.
4380 (bidi_resolve_weak): Don't enter the expensive loop if the current
4381 position is before next_en_pos. Record the bidi type of the first
4382 non-ET, non-BN character we find, in addition to its position.
4383 (bidi_level_of_next_char): Invalidate next_en_type when
4384 next_en_pos is over-stepped.
4385
7da0b018
PE
43862011-10-20 Paul Eggert <eggert@cs.ucla.edu>
4387
4388 Time zone name fixes for non-ASCII locales (Bug#641, Bug#9794)
4389 * editfns.c: Rewrite current-time-zone so that it invokes
4390 the equivalent of (format-time-string "%Z") to get the time zone name.
4391 This fixes a bug when the time zone name contains characters that
4392 need converting from the system time locale to Emacs internal format.
4393 This fixes a shortcoming that I introduced in my 1999-10-19 patch:
4394 that patch fixed format-time-string to do the conversion, but
4395 I forgot to fix current-time-zone.
4396 (format_time_string): New function, containing most of
4397 what Fformat_time_string used to contain.
4398 (Fformat_time_string): Rewrite in terms of format_time_string.
4399 This doesn't change this function's behavior.
4400 (current-time-zone): Rewrite to use format_time_string.
4401 This fixes the bug reported by Michael Schierl in
4402 <http://lists.gnu.org/archive/html/emacs-devel/2007-06/msg00334.html>.
4403 Jason Rumney's 2007-06-07 change worked around this bug, but
4404 didn't fix it.
4405 * systime.h (tzname, timezone): Remove no-longer-used declarations.
4406
8547b010
EZ
44072011-10-19 Eli Zaretskii <eliz@gnu.org>
4408
4409 * xdisp.c (start_display): If the character at POS is displayed
4410 via a display vector, reset IT->current.dpvec_index to zero.
12b32963
EZ
4411 (try_window_reusing_current_matrix): If a line ends in a display
4412 vector or the next line starts in a display vector, continue
4413 redrawing the window even though the character position of
4414 start_row was reached.
8547b010
EZ
4415 (Bug#9771, part 2)
4416
4e948d15
CY
44172011-10-18 Chong Yidong <cyd@gnu.org>
4418
4419 * xdisp.c (get_next_display_element): Handle U+2010 and U+2011
4420 with nobreak-char-display too.
4421
4787455f
EZ
44222011-10-18 Eli Zaretskii <eliz@gnu.org>
4423
4424 Fix part 3 of bug#9771.
4425 * bidi.c (bidi_line_init): Initialize next_en_pos to zero, not -1.
4426 (bidi_resolve_neutral): Don't enter the expensive loop looking for
4427 non-neutral characters if the current character is a paragraph
4428 separator (a.k.a. Newline). This avoids running the same
4429 expensive loop twice, once when we consume the preceding newline
4430 and the other time when the line actually needs to be displayed.
4431 Avoid the loop when we see neutrals on the base embedding level
4432 following a character whose directionality is the same as the
4433 paragraph's. This avoids running the expensive loop when a line
4434 ends in a long sequence of neutrals, like control characters.
4435 Add assertion against STRONG_AL type. Slightly rearrange code
4436 that determines the type of a neutral given the first non-neutral
4437 that follows it.
4438 (bidi_level_of_next_char): Set next_en_pos to zero when
4439 invalidating its info.
4440
2c91f553
EZ
44412011-10-17 Eli Zaretskii <eliz@gnu.org>
4442
4443 * xdisp.c (push_display_prop): Determine whether to record string
4444 or buffer position by IT->string, not by IT->method. Allow
4445 GET_FROM_DISPLAY_VECTOR as IT->method on entry. (Bug#9771, part 4)
f2ff9e88
EZ
4446 (move_it_vertically_backward): Don't look for character position
4447 immediately after the newline when in a continuation line.
4448 (Bug#9771, part 1)
2c91f553 4449
c7b08b0d
MR
44502011-10-15 Martin Rudalics <rudalics@gmx.at>
4451
4452 * window.c (coordinates_in_window): Rewrite and delabelize
4453 vertical border check. (Bug#5357) (Bug#9618)
4454
6b02f655
SM
44552011-10-14 Stefan Monnier <monnier@iro.umontreal.ca>
4456
4457 * xterm.c (frame_highlight, frame_unhighlight): Ignore unexplained
4458 errors in XSetWindowBorder (bug#9310).
4459
81d40c92
DA
44602011-10-13 Dmitry Antipov <dmantipov@yandex.ru>
4461
4462 * editfns.c (Fset_time_zone_rule): Replace free with xfree to
4463 avoid crash when xmalloc overrun checking is enabled.
4464
d4172c3b
EZ
44652011-10-13 Eli Zaretskii <eliz@gnu.org>
4466
4467 * xdisp.c (Fcurrent_bidi_paragraph_direction): Initialize
4468 itb.paragraph_dir to NEUTRAL_DIR. Fixes an occasional incorrect
4469 cursor motion with <left> and <right> arrow keys.
4470
4471 * bidi.c (bidi_init_it): Don't initialize paragraph_dir here, as
4472 some callers set that themselves.
4473
b00eea75
EZ
44742011-10-12 Eli Zaretskii <eliz@gnu.org>
4475
4476 * xdisp.c (find_row_edges): Handle the case where ROW comes from a
4477 display string and the previous row comes from the same string and
4478 is empty. (Bug#9739) (Bug#9738)
4479
8fe012c4
SM
44802011-10-12 Stefan Monnier <monnier@iro.umontreal.ca>
4481
4482 * doc.c (get_doc_string): Encode file name (bug#9735).
4483
0074aef2
EZ
44842011-10-12 Eli Zaretskii <eliz@gnu.org>
4485
79beb178
EZ
4486 * bidi.c (bidi_level_of_next_char):
4487 * xdisp.c (get_visually_first_element): Remove old incorrect
4488 comments regarding the Unicode Line Separator character.
4489
0074aef2
EZ
4490 * bidi.c (bidi_init_it): Initialize paragraph_dir to NEUTRAL_DIR.
4491
6e4b3fbe
DA
44922011-10-12 Dmitry Antipov <dmantipov@yandex.ru>
4493
4494 * alloc.c (Fgc_status): Do not access beyond zombies array
4495 boundary if nzombies > MAX_ZOMBIES.
4496 * alloc.c (dump_zombies): Add missing format specifier.
4497
0324f3af
PE
44982011-10-12 Paul Eggert <eggert@cs.ucla.edu>
4499
b5525cac
PE
4500 * xdisp.c (set_cursor_from_row): Simplify conditionals,
4501 to pacify GCC 4.6.1 x86-64 with -O2 -Wstrict-overflow.
4502
0324f3af
PE
4503 * lread.c (read_escape): Allow hex escapes as large as ?\xfffffff.
4504 Some packages use them to denote characters with modifiers.
4505
e9b5f888
AS
45062011-10-11 Andreas Schwab <schwab@linux-m68k.org>
4507
4508 * lisp.h (GCPRO1_VAR, GCPRO2_VAR, GCPRO3_VAR, GCPRO4_VAR)
4509 (GCPRO5_VAR, GCPRO6_VAR, UNGCPRO_VAR): Add whitespace to avoid
4510 matching a pp-number. Rename parameter var to var1.
4511
127827c0
SM
45122011-10-11 Stefan Monnier <monnier@iro.umontreal.ca>
4513
4514 * minibuf.c (Finternal_complete_buffer): Fix last change (bug#9709).
4515
c8fd3bd0
GM
45162011-10-08 Glenn Morris <rgm@gnu.org>
4517
4518 * callint.c (Fcall_interactively): Give a more explicit error for the
4519 'c' case with a non-character input. (Bug#8479)
4520
352ec8ff
EZ
45212011-10-08 Eli Zaretskii <eliz@gnu.org>
4522
03669ccb
EZ
4523 * xdisp.c (hscroll_window_tree): Support hscroll in right-to-left
4524 lines.
7061c986
EZ
4525 (set_cursor_from_row): Fix cursor positioning in mixed L2R+R2L
4526 lines that are hscrolled on the left.
03669ccb 4527
352ec8ff
EZ
4528 * dispnew.c (buffer_posn_from_coords): Account for a possible
4529 presence of header-line. (Bug#4426)
4530
a66cfb1c
SM
45312011-10-07 Stefan Monnier <monnier@iro.umontreal.ca>
4532
6b02f655
SM
4533 * buffer.c (syms_of_buffer) <enable-multibyte-characters>:
4534 Don't advertise functionality which we discourage or doesn't work.
a66cfb1c 4535
7c5ee88e
PE
45362011-10-07 Paul Eggert <eggert@cs.ucla.edu>
4537
4538 * alloc.c (GC_LISP_OBJECT_ALIGNMENT): Use offsetof, not __alignof__
4539 or sizeof. __alignof__ gives the wrong answer on Fedora x86-64
4540 with GCC 4.6.1 when configured with CC='gcc -m32' --with-wide-int;
4541 this makes Emacs dump core during garbage collection on rare
4542 occasions. sizeof is obviously inferior to offsetof here, so
4543 stick with offsetof.
4544 (GC_POINTER_ALIGNMENT): New macro.
4545 (mark_memory): Omit 3rd (offset) arg; caller changed.
4546 Don't assume EMACS_INT alignment is the same as pointer alignment.
4547
df1bbe5b
SM
45482011-10-03 Stefan Monnier <monnier@iro.umontreal.ca>
4549
4550 * keyboard.c (read_key_sequence_remapped): New var.
4551 (read_key_sequence): Compute remapping in the right buffer.
4552 (command_loop_1): Use read_key_sequence's remapping directly.
4553
51553db6
SM
45542011-10-02 Stefan Monnier <monnier@iro.umontreal.ca>
4555
32c1fffd
SM
4556 * dired.c (file_name_completion): Don't expand file name.
4557 (Ffile_name_completion, Ffile_name_all_completions): Expand file name
4558 before checking file name handler.
4559
51553db6
SM
4560 * minibuf.c (Finternal_complete_buffer): Only show internal buffers if
4561 they've been requested explicitly (bug#9591).
4562
b6bd1599 45632011-10-01 Andreas Schwab <schwab@linux-m68k.org>
fa2ec41f
AS
4564
4565 * keymap.c (Fsingle_key_description): Use make_specified_string
4566 instead of build_string to build string from push_key_description.
4567 (Bug#5193)
4568
f701dc2a
PE
45692011-09-30 Paul Eggert <eggert@cs.ucla.edu>
4570
4222c55d
PE
4571 * buffer.h (struct buffer): Use time_t, not int, for a time stamp.
4572 This fixes a Y2038 bug on 64-bit hosts.
4573 * buffer.c (reset_buffer):
4574 * fileio.c (Fdo_auto_save, Fset_buffer_auto_saved)
4575 (Fclear_buffer_auto_save_failure):
4576 Use 0, not -1, to represent an unset failure time, since time_t
4577 might not be signed.
4578
f701dc2a
PE
4579 Remove dependency on glibc malloc internals.
4580 * alloc.c (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
4581 Move back here from lisp.h, but with their new implementations.
4582 (XMALLOC_BASE_ALIGNMENT, COMMON_MULTIPLE, XMALLOC_HEADER_ALIGNMENT)
4583 (XMALLOC_OVERRUN_SIZE_SIZE): Move these new lisp.h macros here.
4584 * charset.c (charset_table_init): New static var.
4585 (syms_of_charset): Use it instead of xmalloc. This removes a
4586 dependency on glibc malloc internals. See Eli Zaretskii's comment in
4587 <http://lists.gnu.org/archive/html/emacs-devel/2011-09/msg00815.html>.
4588 * lisp.h (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
4589 Move back to alloc.c.
4590 (XMALLOC_BASE_ALIGNMENT, COMMON_MULTIPLE, XMALLOC_HEADER_ALIGNMENT)
4591 (XMALLOC_OVERRUN_SIZE_SIZE): Move to alloc.c.
4592
9ceebf39
JD
45932011-09-30 Jan Djärv <jan.h.d@swipnet.se>
4594
4595 * nsterm.m (windowDidResize): Call x_set_window_size only when
4596 ns_in_resize is true. Otherwise set pixelwidth/height and
4597 call change_frame_size (Bug#9628).
4598
cb993c58
PE
45992011-09-30 Paul Eggert <eggert@cs.ucla.edu>
4600
3930c88b
PE
4601 Port --enable-checking=all to Fedora 14 x86-64.
4602 * charset.c (syms_of_charset): Also account for glibc malloc's
4603 internal overhead when calculating the initial malloc maximum.
4604
cb993c58
PE
4605 Port --enable-checking=all to Fedora 14 x86.
4606 * alloc.c (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
4607 Move to lisp.h.
4608 (xmalloc_put_size, xmalloc_get_size, overrun_check_malloc)
4609 (overrun_check_realloc, overrun_check_free):
4610 Use XMALLOC_OVERRUN_SIZE_SIZE, not sizeof (size_t).
4611 That way, xmalloc returns a properly-aligned pointer even if
4612 XMALLOC_OVERRUN_CHECK is defined. The old debugging code happened
4613 to align OK on typical 64-bit hosts, but not on Fedora 14 x86.
4614 * charset.c (syms_of_charset): Take XMALLOC_OVERRUN_CHECK_OVERHEAD
4615 into account when calculating the initial malloc maximum.
4616 * lisp.h (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
4617 Move here from alloc.c, so that charset.c can use it too.
4618 Properly align; the old code wasn't right for common 32-bit hosts
4619 when configured with --enable-checking=all.
4620 (XMALLOC_BASE_ALIGNMENT, COMMON_MULTIPLE, XMALLOC_HEADER_ALIGNMENT)
4621 (XMALLOC_OVERRUN_SIZE_SIZE): New macros.
4622
31bed486
EZ
46232011-09-29 Eli Zaretskii <eliz@gnu.org>
4624
04c70788 4625 * sysdep.c (snprintf) [!EOVERFLOW]: If EOVERFLOW is not defined,
31bed486
EZ
4626 use EDOM.
4627
fbcaa2f3
EZ
46282011-09-28 Eli Zaretskii <eliz@gnu.org>
4629
4630 * xdisp.c (compute_display_string_end): If there's no display
4631 string at CHARPOS, return -1.
4632
4633 * bidi.c (bidi_fetch_char): When compute_display_string_end
4634 returns a negative value, treat the character as a normal
4635 character not covered by a display string. (Bug#9624)
4636
a239d4e9
JB
46372011-09-28 Juanma Barranquero <lekktu@gmail.com>
4638
4639 * lread.c (Fread_from_string): Fix typo in docstring.
4640
88652fd5
EZ
46412011-09-27 Eli Zaretskii <eliz@gnu.org>
4642
4643 * xdisp.c (handle_invisible_prop): If invisible text ends on a
4644 newline, reseat the iterator instead of bidi-iterating there one
4645 character at a time. (Bug#9610)
32c1fffd
SM
4646 (BUFFER_POS_REACHED_P, move_it_in_display_line_to): Bail when past
4647 TO_CHARPOS if the bidi iterator is at base embedding level.
88652fd5 4648
ed497dd4
AS
46492011-09-27 Andreas Schwab <schwab@linux-m68k.org>
4650
4651 * lread.c (readevalloop): Use correct code for NBSP.
4652 (read1): Likewise. (Bug#9608)
4653
b2bf61aa
MA
46542011-09-25 Michael Albinus <michael.albinus@gmx.de>
4655
4656 * dbusbind.c (Fdbus_register_signal): When service is not
4657 registered, use nil in Vdbus_registered_objects_table. (Bug#9581)
4658
32bbb17c
GM
46592011-09-25 Glenn Morris <rgm@gnu.org>
4660
4661 * buffer.c (truncate-lines): Doc fix.
4662
94e0933e
CY
46632011-09-24 Chong Yidong <cyd@stupidchicken.com>
4664
4665 * window.c (Fwindow_prev_buffers, Fset_window_prev_buffers)
4666 (Fset_window_next_buffers): Doc fix.
4667
cddde921
GM
46682011-09-24 Glenn Morris <rgm@gnu.org>
4669
4670 * minibuf.c (read_minibuf): Disable line truncation. (Bug#5715)
4671
1260aef1
PE
46722011-09-24 Paul Eggert <eggert@cs.ucla.edu>
4673
25b4bfa0
PE
4674 Fix minor problems found by static checking.
4675 * xdisp.c (string_from_display_spec): Don't assume vecsize fits in int.
1260aef1
PE
4676 * indent.c (Fvertical_motion): Fix == vs = typo.
4677
e3cbd34b
EZ
46782011-09-24 Eli Zaretskii <eliz@gnu.org>
4679
a66cfb1c
SM
4680 * dispnew.c (syms_of_display) <redisplay-dont-pause>:
4681 Default value is now t. Doc fix.
6bf7006f 4682
e3cbd34b 4683 * indent.c (Fvertical_motion): Compute and apply the overshoot
32c1fffd 4684 logic when moving up, not only when moving down. Fix the
e3cbd34b 4685 confusing name and values of the it_overshoot_expected variable;
32c1fffd 4686 logic changes accordingly. (Bug#9254) (Bug#9549)
e3cbd34b
EZ
4687
4688 * xdisp.c (pos_visible_p): Produce correct pixel coordinates when
4689 CHARPOS is covered by a display string which includes newlines.
4690 (move_it_vertically_backward): Avoid inflooping when START_CHARPOS
4691 is covered by a display string with embedded newlines.
4692
a3de0cbd
MA
46932011-09-24 Michael Albinus <michael.albinus@gmx.de>
4694
4695 * dbusbind.c (Fdbus_register_signal): Add match rule to
4696 Vdbus_registered_objects_table. (Bug#9581)
a66cfb1c
SM
4697 (Fdbus_register_method, Vdbus_registered_objects_table):
4698 Fix docstring.
a3de0cbd 4699
b260039d
JM
47002011-09-24 Jim Meyering <meyering@redhat.com>
4701
32c1fffd 4702 do not ignore write error for any output size
b260039d
JM
4703 The previous change was incomplete.
4704 While it makes emacs --batch detect the vast majority of stdout
4705 write failures, errors were still ignored whenever the output size is
4706 k * (BUFSIZ+1) - 4. E.g., on a system with BUFSIZ of 4096,
4707 $ emacs --batch --eval '(print (format "%4093d" 0))' > /dev/full \
4708 && echo FAIL: ignored write error
4709 FAIL: ignored write error
4710 $ emacs --batch --eval '(print (format "%20481d" 0))' > /dev/full \
4711 && echo FAIL: ignored write error
4712 FAIL: ignored write error
4713 * emacs.c (Fkill_emacs): Also test ferror. (Bug#9574)
4714
8eca8a7c
AS
47152011-09-23 Andreas Schwab <schwab@linux-m68k.org>
4716
4717 * emacs.c (Fkill_emacs): In noninteractive mode exit
4718 non-successfully if a write error occurred on stdout. (Bug#9574)
4719
3341db62
EZ
47202011-09-21 Eli Zaretskii <eliz@gnu.org>
4721
4722 * xdisp.c (pop_it): Allow it->object that is a cons cell to pass
4723 the xassert test.
4724
4725 * dispextern.h (struct it): Update the comment documenting what
4726 can it->OBJECT be.
4727
8c203dbf
EZ
47282011-09-20 Eli Zaretskii <eliz@gnu.org>
4729
4730 * xdisp.c (set_cursor_from_row): If the row ends in a newline from
4731 a display string, extend search for cursor position to end of row.
4732 (find_row_edges): If the row ends in a newline from a display
4733 string, increment its MATRIX_ROW_END_CHARPOS by one. (Bug#9549)
4734 Handle the case of a display string with multiple newlines.
fd317ddf
EZ
4735 (Fcurrent_bidi_paragraph_direction): Fix search for previous
4736 non-empty line. Fixes confusing cursor motion with arrow keys at
4737 the beginning of a line that starts with whitespace.
8c203dbf 4738
a4824228
LMI
47392011-09-19 Lars Magne Ingebrigtsen <larsi@gnus.org>
4740
4741 * lread.c (Fread_from_string): Document what FINAL-STRING-INDEX is
4742 (bug#9493).
4743
33ed493b
CY
47442011-09-18 Chong Yidong <cyd@stupidchicken.com>
4745
4746 * xfns.c (Fx_create_frame): Handle the bitmapIcon resource as
4747 boolean (Bug#9154).
4748
56cd55c8
EZ
47492011-09-18 Eli Zaretskii <eliz@gnu.org>
4750
4751 * xdisp.c (display_line): Record maximum and minimum buffer
4752 positions even if no glyphs were produced (e.g., by a zero-width
4753 stretch). Fixes bug#9530 on a TTY. Under word-wrap, don't record
4754 buffer positions that will be removed from the glyph row because
4755 they don't fit.
c02dcedf
EZ
4756 (produce_stretch_glyph): Fix a bug in :align-to on a TTY when the
4757 column is beyond frame width: don't subtract 1 "pixel" when
4758 computing width of the stretch.
3e62b7e0
EZ
4759 (reseat_at_next_visible_line_start): Undo the change made on
4760 2011-09-17 that saved paragraph information and restored it after
4761 the call to `reseat'. (Bug#9545)
56cd55c8 4762
5ed99d36 47632011-09-18 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
3390454c
YM
4764
4765 * xdisp.c (expose_window): Save original value of phys_cursor_on_p
4766 and turn window cursor on if cleared (Bug#9415).
4767
5ed99d36 47682011-09-18 Andreas Schwab <schwab@linux-m68k.org>
edb7b4dc
AS
4769
4770 * search.c (boyer_moore): Take unibyte characters from pattern
4771 literally. (Bug#9458)
4772
9bade7b2
EZ
47732011-09-18 Eli Zaretskii <eliz@gnu.org>
4774
4775 * xdisp.c (reseat_at_next_visible_line_start): Fix last change.
4776
e5e9d610
PE
47772011-09-18 Paul Eggert <eggert@cs.ucla.edu>
4778
87e4427a
PE
4779 Fix minor problem found by static checking.
4780 * xdisp.c (reseat_at_next_visible_line_start): Mark locals as
4781 initialized, to pacify gcc -Wuninitialized.
4782
e5e9d610
PE
4783 * fileio.c: Report proper errno when syscall falls.
4784 (Finsert_file_contents): Save and restore errno,
4785 so that report_file_error outputs the correct diagnostic.
4786 (Fwrite_region) [CLASH_DETECTION]: Likewise.
4787
a1674f0b
EZ
47882011-09-18 Eli Zaretskii <eliz@gnu.org>
4789
4790 * .gdbinit (pgx): Fix references to fields of `struct glyph'.
4791
fbfb6dd4
EZ
47922011-09-17 Eli Zaretskii <eliz@gnu.org>
4793
4794 * xdisp.c (produce_stretch_glyph): Another fix for changes made on
4795 2011-08-30T17:32:44Z!eliz@gnu.org. (Bug#9530)
4796
bb187662
EZ
47972011-09-17 Eli Zaretskii <eliz@gnu.org>
4798
1137e8b8 4799 * xdisp.c (reseat_at_next_visible_line_start): Keep information
6b02f655 4800 about the current paragraph and restore it after the call to reseat.
1137e8b8
EZ
4801
4802 * bidi.c (MAX_PARAGRAPH_SEARCH): New macro.
4803 (bidi_find_paragraph_start): Search back for paragraph beginning
4804 at most MAX_PARAGRAPH_SEARCH lines; if not found, return BEGV_BYTE.
4805 (bidi_move_to_visually_next): Only trigger paragraph-related
4806 computations when the last character is a newline or at EOB, not
4807 just any NEUTRAL_B. (Bug#9470)
4808
bb187662
EZ
4809 * xdisp.c (set_cursor_from_row): Don't invoke special treatment of
4810 truncated lines if point is covered by a display string. (Bug#9524)
4811
2e621251
PE
48122011-09-16 Paul Eggert <eggert@cs.ucla.edu>
4813
4814 * xselect.c: Relax test for outgoing X longs (Bug#9498).
4815 (cons_to_x_long): New function.
4816 (lisp_data_to_selection_data): Use it. Correct the test for
4817 short-versus-long data; it was negated. Break out of vector
4818 loop, for efficiency, when a long datum is discovered.
4819
91a15bc6
SM
48202011-09-16 Stefan Monnier <monnier@iro.umontreal.ca>
4821
4822 * eval.c (Fquote): Document its non-consing behavior (bug#9482).
4823
b41c3a35
EZ
48242011-09-16 Eli Zaretskii <eliz@gnu.org>
4825
4826 * image.c (tiff_handler): Work around a bug in MinGW GCC 3.x (see
4827 GCC PR/17406) by declaring this function with external scope.
4828
7812ba2d
PE
48292011-09-15 Paul Eggert <eggert@cs.ucla.edu>
4830
4831 * editfns.c (Fformat): Fix bug in text-property fix (Bug#9514).
4832 Don't mishandle (length (format "%%")) and (format "%4000s%%" "").
4833
cf7edc2a
AS
48342011-09-15 Andreas Schwab <schwab@linux-m68k.org>
4835
4836 * editfns.c (Fformat): Correctly handle text properties on "%%".
4837
bd01620e
EZ
48382011-09-15 Eli Zaretskii <eliz@gnu.org>
4839
4840 * xterm.c (x_draw_composite_glyph_string_foreground):
4841 * w32term.c (x_draw_composite_glyph_string_foreground):
4842 * term.c (encode_terminal_code):
4843 * composite.c (composition_update_it, get_composition_id):
4844 * xdisp.c (get_next_display_element)
4845 (fill_composite_glyph_string): Add comments about special meaning
4846 of TAB characters in a composition.
4847
a02719a3
PE
48482011-09-15 Paul Eggert <eggert@cs.ucla.edu>
4849
4850 * editfns.c (Fformat): Fix off-by-1 bug for "%%b" (Bug#9514).
4c122725
PE
4851 This occurs when processing a multibyte format.
4852 Problem reported by Wolfgang Jenker.
a02719a3 4853
72589a3c
JB
48542011-09-15 Johan Bockgård <bojohan@gnu.org>
4855
4856 * xdisp.c (try_cursor_movement): Only check for exact match if
4857 cursor hpos found by set_cursor_from_row is valid. (Bug#9495)
4858
1c14176c
PE
48592011-09-14 Paul Eggert <eggert@cs.ucla.edu>
4860
4861 Remove unused external symbols.
4862 * dispextern.h (calc_pixel_width_or_height): Remove decl.
4863 * xdisp.c (calc_pixel_width_or_height): Now static.
4864 * doprnt.c (exprintf) [! (HAVE_X_WINDOWS && USE_X_TOOLKIT)]: Remove.
4865 * indent.c (check_display_width):
4866 * w32term.c: Fix comment to match code.
4867 * xterm.c, xterm.h (x_catching_errors): Remove.
4868
d2eea5b5
PE
48692011-09-14 Paul Eggert <eggert@cs.ucla.edu>
4870
4871 * xselect.c: Use signed conversions more consistently (Bug#9498).
4872 (selection_data_to_lisp_data): Assume incoming selection data are
4873 signed integers, not unsigned. This is to be consistent with
4874 outgoing selection data, which was modified to use signed integers
4875 in as part of the fix to Bug#9196 in response to Jan D.'s comment
4876 in <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=9196#32> that X11
4877 expects long, not unsigned long.
4878
46888499
EZ
48792011-09-14 Eli Zaretskii <eliz@gnu.org>
4880
4881 * xdisp.c (try_window_reusing_current_matrix): Fix incorrect
4882 computation of loop end. Reported by Johan Bockgård
4883 <bojohan@gnu.org>.
4884
ef8ef9fb
CY
48852011-09-13 Chong Yidong <cyd@stupidchicken.com>
4886
4887 * frame.c (Fother_visible_frames_p): Function deleted.
4888
fa819fed
EZ
48892011-09-12 Eli Zaretskii <eliz@gnu.org>
4890
4891 * indent.c (compute_motion): Process display vector front to back
4892 rather than the other way around. (Bug#2496)
4893
2ba8e008
SM
48942011-09-12 Stefan Monnier <monnier@iro.umontreal.ca>
4895
4896 * fileio.c (Finsert_file_contents): Don't assume beg_offset is 0.
4897
20f53c69
CY
48982011-09-11 Chong Yidong <cyd@stupidchicken.com>
4899
4900 * minibuf.c (Fread_from_minibuffer): Doc fix.
4901
d562d7a4
EZ
49022011-09-11 Eli Zaretskii <eliz@gnu.org>
4903
4904 * xdisp.c (produce_stretch_glyph): Fix a typo made in changes from
4905 2011-08-30T17:32:44Z!eliz@gnu.org. (Bug#9475)
4906
1c4d7f3d
LMI
49072011-09-11 Lars Magne Ingebrigtsen <larsi@gnus.org>
4908
4909 * fileio.c (Fvisited_file_modtime): Document `(-1 65535)' as a
4910 value for non-existent files.
4911
b885bf36
EZ
49122011-09-11 Eli Zaretskii <eliz@gnu.org>
4913
4914 * fileio.c (Finsert_file_contents): If the file cannot be opened,
4915 set its "size" to -1. This will set the modtime_size field of
4916 the corresponding buffer to -1, which is what
4917 verify-visited-file-modtime expects for files that do not exist.
4918 (Bug#9139)
4919
6612f0bf
PE
49202011-09-11 Paul Eggert <eggert@cs.ucla.edu>
4921
4922 * keymap.h (KEY_DESCRIPTION_SIZE, push_key_description): Move decls
4923 here ...
4924 * lisp.h: ... from here. push_key_description is no longer
4925 defined in keyboard.c, so its declaration should not be in
4926 lisp.h's "Defined in keyboard.c" section, and KEY_DESCRIPTION_SIZE
4927 logically belongs with push_key_description.
4928
dfb3f755
PE
49292011-09-10 Paul Eggert <eggert@cs.ucla.edu>
4930
4931 * buffer.h: Include <sys/types.h> instead of <time.h>.
4932 Otherwise, off_t wasn't defined on FreeBSD 9.0-BETA2 i386.
4933 Problem reported by Herbert J. Skuhra.
4934
3134906c
LMI
49352011-09-10 Lars Magne Ingebrigtsen <larsi@gnus.org>
4936
4937 * xml.c (parse_region): Make the parsing work for
4938 non-comment-starting XML files again (bug#9144).
4939
8d903f4e
AS
49402011-09-10 Andreas Schwab <schwab@linux-m68k.org>
4941
4942 * image.c (gif_load): Fix calculation of bottom and right corner.
4943 (Bug#9468)
4944
80ad64f4
EZ
49452011-09-10 Eli Zaretskii <eliz@gnu.org>
4946
4947 * xdisp.c (MAX_DISP_SCAN): Decrease to 250. Prevents sluggish
4948 redisplay in small windows.
4949
208a048d
EZ
49502011-09-09 Eli Zaretskii <eliz@gnu.org>
4951
4952 * frame.c (x_report_frame_params): Cast to avoid compiler warnings.
4953
9b1c252e
MR
49542011-09-08 Martin Rudalics <rudalics@gmx.at>
4955
4956 * window.c (Fset_window_prev_buffers, Fset_window_next_buffers):
4957 Operate on live windows only.
4958
2949f33b
JB
49592011-09-08 Juanma Barranquero <lekktu@gmail.com>
4960
4961 * emacs.c (my_heap_start): #ifdef to avoid warnings when unused.
4962
e08dcafd
EZ
49632011-09-07 Eli Zaretskii <eliz@gnu.org>
4964
4965 * xdisp.c (move_it_in_display_line_to): Call RESTORE_IT on ppos_it
4966 only under bidi iteration.
4967
115b96bd
JD
49682011-09-07 Jan Djärv <jan.h.d@swipnet.se>
4969
4970 * gtkutil.c (xg_make_tool_item): Insert comment about eventbox.
4971
c8199d0f
PE
49722011-09-06 Paul Eggert <eggert@cs.ucla.edu>
4973
4974 isnan: Fix porting problem to Solaris 10 with bundled gcc.
4975 Without this fix, the command to link temacs failed due to an
4976 undefined symbol __builtin_isnan. This is because
4977 /usr/include/iso/math_c99.h #defines isnan(x) to
4978 __builtin_isnan(x), but the bundled gcc, which identifies itself
4979 as gcc 3.4.3 (csl-sol210-3_4-branch+sol_rpath), does not have
4980 a __builtin_isnan.
4981 * floatfns.c (isnan): #undef, and then #define to a clone of
4982 what's in data.c.
4983 (Fisnan): Always define, since it's always available now.
4984 (syms_of_floatfns): Always define isnan at the Lisp level.
4985
e39b275c 49862011-09-06 Paul Eggert <eggert@cs.ucla.edu>
1c262cae
PE
4987
4988 * Makefile.in (gl-stamp): move-if-change now in build-aux (Bug#9169).
4989
b2db44d9 49902011-09-06 Paul Eggert <eggert@cs.ucla.edu>
728f8f0a 4991
f4af5137 4992 * fileio.c: Fix bugs with large file offsets (Bug#9428).
728f8f0a
PE
4993 The previous code assumed that file offsets (off_t values) fit in
4994 EMACS_INT variables, which is not true on typical 32-bit hosts.
4995 The code messed up by falsely reporting buffer overflow in cases
4996 such as (insert-file-contents "big" nil 1 2) into an empty buffer
4997 when "big" contains more than 2**29 bytes, even though this
4998 inserts just one byte and does not overflow the buffer.
4999 (Finsert_file_contents): Store file offsets as off_t
5000 values, not as EMACS_INT values. Check for overflow when
5001 converting between EMACS_INT and off_t. When checking for
5002 buffer overflow or for overlap, take the offsets into account.
5003 Don't use EMACS_INT for small values where int suffices.
5004 When checking for overlap, fix a typo: ZV was used where
5005 ZV_BYTE was intended.
5006 (Fwrite_region): Don't assume off_t fits into 'long'.
5007 * buffer.h (struct buffer.modtime_size): Now off_t, not EMACS_INT.
5008
ecfc0a49
MA
50092011-09-05 Michael Albinus <michael.albinus@gmx.de>
5010
5011 * dbusbind.c (xd_signature_cat): Rename from signature_cat.
5012
6511acf2 50132011-09-04 Paul Eggert <eggert@cs.ucla.edu>
61bfeeb7 5014
0999621a 5015 sprintf-related integer and memory overflow issues (Bug#9412).
62f19c19
PE
5016
5017 * doprnt.c (doprnt): Support printing ptrdiff_t and intmax_t values.
8666506e 5018 (esprintf, exprintf, evxprintf): New functions.
62f19c19 5019 * keyboard.c (command_loop_level): Now EMACS_INT, not int.
6b02f655 5020 (cmd_error): Kbd macro iterations count is now EMACS_INT, not int.
62f19c19
PE
5021 (modify_event_symbol): Do not assume that the length of
5022 name_alist_or_stem is safe to alloca and fits in int.
5023 (Fexecute_extended_command): Likewise for function name and binding.
5024 (Frecursion_depth): Wrap around reliably on integer overflow.
5025 * keymap.c (push_key_description): First arg is now EMACS_INT, not int,
5026 since some callers pass EMACS_INT values.
5027 (Fsingle_key_description): Don't crash if symbol name contains more
5028 than MAX_ALLOCA bytes.
5029 * minibuf.c (minibuf_level): Now EMACS_INT, not int.
5030 (get_minibuffer): Arg is now EMACS_INT, not int.
5031 * lisp.h (get_minibuffer, push_key_description): Reflect API changes.
8666506e 5032 (esprintf, exprintf, evxprintf): New decls.
62f19c19
PE
5033 * window.h (command_loop_level, minibuf_level): Reflect API changes.
5034
2be7d702
PE
5035 * dbusbind.c (signature_cat): New function.
5036 (xd_signature, Fdbus_register_signal):
2ea16b89
PE
5037 Do not overrun buffer; instead, report string overflow.
5038
9d1df220
PE
5039 * dispnew.c (add_window_display_history): Don't overrun buffer.
5040 Truncate instead; this is OK since it's just a log.
5041
33ef5c64
PE
5042 * editfns.c (Fcurrent_time_zone): Don't overrun buffer
5043 even if the time zone offset is outlandishly large.
5044 Don't mishandle offset == INT_MIN.
5045
66c6fdd5
PE
5046 * emacs.c (main) [NS_IMPL_COCOA]: Don't overrun buffer
5047 when creating daemon; the previous buffer-overflow check was incorrect.
5048
d749b01b
PE
5049 * eval.c (verror): Simplify by rewriting in terms of evxprintf,
5050 which has the guts of the old verror function.
5051
b5cd1905
PE
5052 * filelock.c (lock_file_1, lock_file): Don't blindly alloca long name;
5053 use SAFE_ALLOCA instead. Use esprintf to avoid int-overflow issues.
5054
6e1a67fb
PE
5055 * font.c: Include <float.h>, for DBL_MAX_10_EXP.
5056 (font_unparse_xlfd): Don't blindly alloca long strings.
c21721cc 5057 Don't assume XINT result fits in int, or that XFLOAT_DATA * 10
8666506e 5058 fits in int, when using sprintf. Use single snprintf to count
c21721cc
PE
5059 length of string rather than counting it via multiple sprintfs;
5060 that's simpler and more reliable.
c21721cc
PE
5061 (font_unparse_fcname): Use it to avoid sprintf buffer overrun.
5062 (generate_otf_features) [0 && HAVE_LIBOTF]: Use esprintf, not
5063 sprintf, in case result does not fit in int.
5064
c57b67fc
PE
5065 * fontset.c (num_auto_fontsets): Now printmax_t, not int.
5066 (fontset_from_font): Print it.
5067
8a401434
PE
5068 * frame.c (tty_frame_count): Now printmax_t, not int.
5069 (make_terminal_frame, set_term_frame_name): Print it.
5070 (x_report_frame_params): In X, window IDs are unsigned long,
5071 not signed long, so print them as unsigned.
5072 (validate_x_resource_name): Check for implausibly long names,
5073 and don't assume name length fits in 'int'.
5074 (x_get_resource_string): Don't blindly alloca invocation name;
5075 use SAFE_ALLOCA. Use esprintf, not sprintf, in case result does
5076 not fit in int.
5077
6e1a67fb
PE
5078 * gtkutil.c: Include <float.h>, for DBL_MAX_10_EXP.
5079 (xg_check_special_colors, xg_set_geometry):
84722b3d
PE
5080 Make sprintf buffers a bit bigger, to avoid potential buffer overrun.
5081
0df02bf3
PE
5082 * lread.c (dir_warning): Don't blindly alloca buffer; use SAFE_ALLOCA.
5083 Use esprintf, not sprintf, in case result does not fit in int.
5084
48e30793
PE
5085 * macros.c (executing_kbd_macro_iterations): Now EMACS_INT, not int.
5086 (Fend_kbd_macro): Don't mishandle MOST_NEGATIVE_FIXNUM by treating
5087 it as a large positive number.
5088 (Fexecute_kbd_macro): Don't assume repeat count fits in int.
5089 * macros.h (executing_kbd_macro_iterations): Now EMACS_INT, not int.
5090
a66ff6d8
PE
5091 * nsterm.m ((NSSize)windowWillResize): Use esprintf, not sprintf,
5092 in case result does not fit in int.
5093
aca216ff
PE
5094 * print.c (float_to_string): Detect width overflow more reliably.
5095 (print_object): Make sprintf buffer a bit bigger, to avoid potential
5096 buffer overrun. Don't assume list length fits in 'int'. Treat
5097 print length of 0 as 0, not as infinity; to be consistent with other
5098 uses of print length in this function. Don't overflow print length
5099 index. Don't assume hash table size fits in 'long', or that
5100 vectorlike size fits in 'unsigned long'.
5101
31c286f7
PE
5102 * process.c (make_process): Use printmax_t, not int, to format
5103 process-name gensyms.
5104
55e5faa1
PE
5105 * sysdep.c (snprintf) [! HAVE_SNPRINTF]: New function.
5106
80f2e268
PE
5107 * term.c (produce_glyphless_glyph): Make sprintf buffer a bit bigger
5108 to avoid potential buffer overrun.
5109
670741ab
PE
5110 * xfaces.c (x_update_menu_appearance): Don't overrun buffer
5111 if X resource line is longer than 512 bytes.
5112
b7163a50
PE
5113 * xfns.c (x_window): Make sprintf buffer a bit bigger
5114 to avoid potential buffer overrun.
5115
ae58ff1f
PE
5116 * xterm.c (x_io_error_quitter): Don't overrun sprintf buffer.
5117
c43c8a6a
PE
5118 * xterm.h (x_check_errors): Add ATTRIBUTE_FORMAT_PRINTF.
5119
3f8236f4
PE
51202011-09-04 Paul Eggert <eggert@cs.ucla.edu>
5121
53e9fe90 5122 Integer overflow fixes for scrolling, etc.
6511acf2
PE
5123 Without these, Emacs silently mishandles large integers sometimes.
5124 For example, "C-u 4294967297 M-x recenter" was treated as if
53e9fe90
PE
5125 it were "C-u 1 M-x recenter" on a typical 64-bit host.
5126
6511acf2
PE
5127 * xdisp.c (try_window_id): Check Emacs fixnum range before
5128 converting to 'int'.
806add1d 5129
6511acf2 5130 * window.c (window_scroll_line_based, Frecenter):
71f02bc5
PE
5131 Check that an Emacs fixnum is in range before assigning it to 'int'.
5132 (Frecenter, Fmove_to_window_line): Use EMACS_INT, not int, for
5133 values converted from Emacs fixnums.
5134 (Frecenter): Don't wrap around a line count if it is out of 'int'
5135 range; instead, treat it as an extreme value.
5136 (Fset_window_configuration, compare_window_configurations):
5137 Use ptrdiff_t, not int, for index that might exceed 2 GiB.
5138
6511acf2
PE
5139 * search.c (Freplace_match): Use ptrdiff_t, not int, for indexes
5140 that can exceed INT_MAX. Check that EMACS_INT value is in range
5141 before assigning it to the (possibly-narrower) index.
a0efffc8
PE
5142 (match_limit): Don't assume that a fixnum can fit in 'int'.
5143
6511acf2 5144 * print.c (print_object): Use ptrdiff_t, not int, for index that can
29ebea3b
PE
5145 exceed INT_MAX.
5146
6511acf2 5147 * indent.c (position_indentation): Now takes ptrdiff_t, not int.
3f8236f4
PE
5148 (Fvertical_motion): Don't wrap around LINES values that don't fit
5149 in 'int'. Instead, treat them as extreme values. This is good
5150 enough for windows, which can't have more than INT_MAX lines anyway.
5151
fcb901a7
LMI
51522011-09-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
5153
0f2f6b6d
LMI
5154 * Require libxml/parser.h to avoid compilation warning.
5155
fcb901a7
LMI
5156 * emacs.c (shut_down_emacs): Call xmlCleanupParser on shutdown.
5157
5158 * xml.c (parse_region): Don't call xmlCleanupParser after parsing,
5159 since this reportedly can destroy thread storage.
5160
6e20a0d4
CY
51612011-08-30 Chong Yidong <cyd@stupidchicken.com>
5162
5163 * syntax.c (find_defun_start): Update all cache variables if
5164 exiting early (Bug#9401).
5165
148ae00e
EZ
51662011-08-30 Eli Zaretskii <eliz@gnu.org>
5167
f6cfbd8f
EZ
5168 * image.c (x_bitmap_pixmap): Cast to int to avoid compiler warnings.
5169
148ae00e
EZ
5170 * xdisp.c (produce_stretch_glyph): No longer static, compiled also
5171 when HAVE_WINDOW_SYSTEM is not defined. Support both GUI and TTY
5172 frames. Call tty_append_glyph in the TTY case. (Bug#9402)
5173
5174 * term.c (tty_append_glyph): New function.
5175 (produce_stretch_glyph): Static function and its prototype deleted.
5176
a66cfb1c
SM
5177 * dispextern.h (produce_stretch_glyph, tty_append_glyph):
5178 Add prototypes.
148ae00e 5179
c4a07a4c
PE
51802011-08-29 Paul Eggert <eggert@cs.ucla.edu>
5181
5182 * image.c (parse_image_spec): Check for nonnegative, not for positive,
5183 when checking :margin (Bug#9390).
5184 (IMAGE_NON_NEGATIVE_INTEGER_VALUE_OR_PAIR):
a66cfb1c 5185 Rename from IMAGE_POSITIVE_INTEGER_VALUE_OR_PAIR,
c4a07a4c
PE
5186 so that the name doesn't mislead. All uses changed.
5187
6bc8cd65
JB
51882011-08-28 Johan Bockgård <bojohan@gnu.org>
5189
5190 * term.c (init_tty) [HAVE_GPM]: Move mouse settings after
5191 set_tty_hooks.
5192
dca4927e
EZ
51932011-08-27 Eli Zaretskii <eliz@gnu.org>
5194
5195 * xdisp.c (move_it_to): Don't bail out early when reaching
5196 position beyond to_charpos, if we are scanning backwards.
5197 (move_it_vertically_backward): When DY == 0, make sure we get to
5198 the first character in the line after the newline.
5199
f2cad773
PE
52002011-08-27 Paul Eggert <eggert@cs.ucla.edu>
5201
5202 * ccl.c: Improve and simplify overflow checking (Bug#9196).
5203 (ccl_driver): Do not generate an out-of-range pointer.
5204 (Fccl_execute_on_string): Remove unnecessary check for
5205 integer overflow, noted by Stefan Monnier in
5206 <http://lists.gnu.org/archive/html/emacs-devel/2011-08/msg00979.html>.
5207 Remove a FIXME that didn't need fixing.
5208 Simplify the newly-introduced buffer reallocation code.
5209
0cae2cdb
JB
52102011-08-27 Juanma Barranquero <lekktu@gmail.com>
5211
5212 * makefile.w32-in ($(BLD)/alloc.$(O)): Depend on lib/verify.h.
5213
5fc295a4 52142011-08-26 Paul Eggert <eggert@cs.ucla.edu>
ddff3151 5215
70c60eb2 5216 Integer and memory overflow issues (Bug#9196).
726e0ab1 5217
d31850da
PE
5218 * doc.c (get_doc_string): Rework so that
5219 get_doc_string_buffer_size is the actual buffer size, rather than
5220 being 1 less than the actual buffer size; this makes xpalloc more
5221 convenient.
5222
a69fbedb
PE
5223 * image.c (x_allocate_bitmap_record, cache_image):
5224 * xselect.c (Fx_register_dnd_atom):
5225 Simplify previous changes by using xpalloc.
5226
fe5c5d37
PE
5227 * buffer.c (overlay_str_len): Now ptrdiff_t, not EMACS_INT,
5228 since either will do and ptrdiff_t is convenient with xpalloc.
5229
0065d054
PE
5230 * charset.c (charset_table_size)
5231 (struct charset_sort_data.priority): Now ptrdiff_t.
5232 (charset_compare): Don't overflow if priorities differ greatly.
5233 (Fsort_charsets): Don't assume list length fits in int.
5234 Check for size-calculation overflow when allocating sort data.
5235 (syms_of_charset): Allocate an initial charset table that is
5236 just under 64 KiB, to avoid problems with glibc malloc and mmap.
5237
5238 * cmds.c (internal_self_insert): Check for size-calculation overflow.
5239
5240 * composite.h (struct composition.glyph_len): Now int, not unsigned.
5241 The actual value is always <= INT_MAX, and leaving it unsigned made
5242 overflow checking harder.
5243
5244 * dispextern.h (struct glyph_matrix.rows_allocated)
5245 (struct face_cache.size): Now ptrdiff_t, for convenience in use
5246 with xpalloc. The values are still always <= INT_MAX.
5247
5248 * indent.c (compute_motion): Adjust to region_cache_forward sig change.
5249
5250 * lisp.h (xnmalloc, xnrealloc, xpalloc): New decls.
5251 (SAFE_NALLOCA): New macro.
5252
5253 * region-cache.c (struct boundary.pos, find_cache_boundary)
5254 (move_cache_gap, insert_cache_boundary, delete_cache_boundaries)
5255 (set_cache_region, invalidate_region_cache)
5256 (revalidate_region_cache, know_region_cache, region_cache_forward)
5257 (region_cache_backward, pp_cache):
5258 Use ptrdiff_t, not EMACS_INT, since either will do. This is needed
5259 so that ptrdiff_t * can be passed to xpalloc.
5260 (struct region_cache): Similarly, for gap_start, gap_len, cache_len,
5261 beg_unchanged, end_unchanged, buffer_beg, buffer_end members.
5262 (pp_cache): Don't assume cache_len fits in int.
5263 * region-cache.h: Adjust extern decls to match.
5264
5265 * search.c (scan_buffer, Freplace_match): Use ptrdiff_t, not
5266 EMACS_INT, since either will do, for xpalloc.
5267
5268 * alloc.c: Include verify.h, and check that int fits in ptrdiff_t.
5269 (xnmalloc, xnrealloc, xpalloc): New functions.
5270
726e0ab1
PE
5271 * bidi.c (bidi_shelve_header_size): New constant.
5272 (bidi_cache_ensure_space, bidi_shelve_cache): Use it.
5273 (bidi_cache_ensure_space): Avoid integer overflow when allocating.
5274
51f30bc5 5275 * bidi.c (bidi_cache_shrink):
726e0ab1
PE
5276 * buffer.c (overlays_at, overlays_in, record_overlay_string)
5277 (overlay_strings):
5278 Don't update size of array until after memory allocation succeeds,
5279 because xmalloc/xrealloc may not return.
0065d054
PE
5280 (struct sortstrlist.bytes): Now ptrdiff_t, as EMACS_INT doesn't help
5281 now that we have proper integer overflow checking.
5282 (record_overlay_string, overlay_strings): Catch overflows when
5283 calculating size of overlay_str_buf.
726e0ab1 5284
0065d054
PE
5285 * callproc.c (Fcall_process): Check for size overflow when
5286 calculating size of args2.
5287 (child_setup): Avoid overflow by using size_t rather than ptrdiff_t.
5288 Normally we prefer signed values, but sticking with ptrdiff_t would
5289 require adding more-complicated checks.
726e0ab1
PE
5290
5291 * ccl.c (Fccl_execute_on_string): Check for memory overflow.
5292 Use ptrdiff_t rather than EMACS_INT where ptrdiff_t will do.
5293 Redo buffer-overflow calculations to avoid integer overflow.
0065d054 5294 Add a FIXME comment where memory seems to be over-allocated.
726e0ab1
PE
5295
5296 * character.c (Fstring): Check for size-calculation overflow.
5297
5298 * coding.c (produce_chars): Redo buffer-overflow calculations to avoid
5299 unnecessary integer overflow. Check for size overflow.
5300 (encode_coding_object): Don't update size until xmalloc succeeds.
5301
5302 * composite.c (get_composition_id): Check for overflow in glyph
5303 length calculations.
5304
5305 Integer and memory overflow fixes for display code.
5306 * dispextern.h (struct glyph_pool.nglyphs): Now ptrdiff_t, not int.
5307 * dispnew.c (adjust_glyph_matrix, realloc_glyph_pool)
5308 (scrolling_window): Check for overflow in size calculations.
5309 (line_draw_cost, realloc_glyph_pool, add_row_entry):
5310 Don't assume glyph table len fits in int.
5311 (struct row_entry.bucket, row_entry_pool_size, row_entry_idx)
5312 (row_table_size): Now ptrdiff_t, not int.
5313 (scrolling_window): Avoid overflow in size calculations.
5314 Don't update size until allocation succeeds.
5315 * fns.c (concat): Check for overflow in size calculations.
5316 (next_almost_prime): Verify NEXT_ALMOST_PRIME_LIMIT.
5317 * lisp.h (RANGED_INTEGERP, TYPE_RANGED_INTEGERP): New macros.
5318 (NEXT_ALMOST_PRIME_LIMIT): New constant.
5319
5320 * doc.c (get_doc_string_buffer_size): Now ptrdiff_t, not int.
5321 (get_doc_string): Check for size calculation overflow.
5322 Don't update size until allocation succeeds.
5323 (get_doc_string, Fsubstitute_command_keys): Use ptrdiff_t, not
5324 EMACS_INT, where ptrdiff_t will do.
5325 (Fsubstitute_command_keys): Check for string overflow.
5326
5327 * editfns.c (set_time_zone_rule): Don't assume environment length
5328 fits in int.
5329 (message_length): Now ptrdiff_t, not int.
5330 (Fmessage_box): Don't update size until allocation succeeds.
5331 Don't assume message length fits in int.
5332 (Fformat): Use ptrdiff_t, not EMACS_INT, where ptrdiff_t will do.
5333
0065d054
PE
5334 * emacs.c (main): Do not reallocate argv, since there is a null at
5335 the end that can be overwritten, and this way there's no need to
5336 worry about size-calculation overflow.
5337 (sort_args): Check for size-calculation overflow.
726e0ab1
PE
5338
5339 * eval.c (init_eval_once, grow_specpdl): Don't update size until
5340 alloc succeeds.
5341 (call_debugger, grow_specpdl): Redo calculations to avoid overflow.
5342
5343 * frame.c (set_menu_bar_lines, x_set_frame_parameters)
5344 (x_set_scroll_bar_width, x_figure_window_size):
5345 Check for integer overflow.
5346 (x_set_alpha): Do not assume XINT fits in int.
5347
5348 * frame.h (struct frame): Use int, not EMACS_INT, where int works.
5349 This is for the members text_lines, text_cols, total_lines, total_cols,
5350 where the system imposes an 'int' limit.
5351
5352 * fringe.c (Fdefine_fringe_bitmap):
5353 Don't update size until alloc works.
5354
5355 * ftfont.c (ftfont_get_open_type_spec, setup_otf_gstring)
5356 (ftfont_shape_by_flt): Check for integer overflow in size calculations.
5357
5358 * gtkutil.c (get_utf8_string, xg_store_widget_in_map):
5359 Check for size-calculation overflow.
5360 (get_utf8_string): Use ptrdiff_t, not size_t, where either will
5361 do, as we prefer signed integers.
5362 (id_to_widget.max_size, id_to_widget.used)
5363 (xg_store_widget_in_map, xg_remove_widget_from_map)
5364 (xg_get_widget_from_map, xg_get_scroll_id_for_window)
5365 (xg_remove_scroll_bar, xg_update_scrollbar_pos):
5366 Use and return ptrdiff_t, not int.
5367 (xg_gtk_scroll_destroy): Don't assume ptrdiff_t fits in int.
5368 * gtkutil.h: Change prototypes to match the above.
5369
5370 * image.c (RANGED_INTEGERP, TYPE_RANGED_INTEGERP): Remove; these
5371 are duplicate now that they've been promoted to lisp.h.
5372 (x_allocate_bitmap_record, x_alloc_image_color)
5373 (make_image_cache, cache_image, xpm_load):
5374 Don't update size until alloc is done.
5375 (xpm_load, lookup_rgb_color, lookup_pixel_color, x_to_xcolors)
5376 (x_detect_edges):
3256efce 5377 Check for size calculation overflow.
726e0ab1
PE
5378 (ct_colors_allocated_max): New constant.
5379 (x_to_xcolors, x_detect_edges): Reorder multiplicands to avoid
5380 overflow.
3256efce 5381
726e0ab1
PE
5382 * keyboard.c (read_char, menu_bar_items, tool_bar_items)
5383 (read_char_x_menu_prompt, read_char_minibuf_menu_width)
5384 (read_char_minibuf_menu_prompt, follow_key, read_key_sequence):
5385 Use ptrdiff_t, not int, to count maps.
5386 (read_char_minibuf_menu_prompt): Check for overflow in size
a66cfb1c
SM
5387 calculations. Don't update size until allocation succeeds.
5388 Redo calculations to avoid overflow.
726e0ab1
PE
5389 * keyboard.h: Change prototypes to match the above.
5390
5391 * keymap.c (cmm_size, current_minor_maps): Use ptrdiff_t, not int,
5392 to count maps.
5393 (current_minor_maps): Check for size calculation overflow.
5394 * keymap.h: Change prototypes to match the above.
5395
5396 * lread.c (read1, init_obarray): Don't update size until alloc done.
5397
5398 * macros.c (Fstart_kbd_macro): Don't update size until alloc done.
5399 (store_kbd_macro_char): Reorder multiplicands to avoid overflow.
5400
726e0ab1
PE
5401 * nsterm.h (struct ns_color_table.size, struct ns_color_table.avail):
5402 Now ptrdiff_t, not int.
5403 * nsterm.m (ns_index_color): Use ptrdiff_t, not int, for table indexes.
5404 (ns_draw_fringe_bitmap): Rewrite to avoid overflow.
5405
5406 * process.c (Fnetwork_interface_list): Check for overflow
5407 in size calculation.
5408
5409 * region-cache.c (move_cache_gap): Check for size calculation overflow.
5410
5411 * scroll.c (do_line_insertion_deletion_costs): Check for size calc
5412 overflow. Don't bother calling xmalloc when xrealloc will do.
5413
5414 * search.c (Freplace_match): Check for size calculation overflow.
5415 (Fset_match_data): Don't assume list lengths fit in 'int'.
5416
5417 * sysdep.c (system_process_attributes): Use ptrdiff_t, not int,
5418 for command line length. Do not attempt to address one before the
5419 beginning of an array, as that's not portable.
5420
5421 * term.c (max_frame_lines): Remove; unused.
5422 (encode_terminal_src_size, encode_terminal_dst_size): Now ptrdiff_t,
5423 not int.
5424 (encode_terminal_code, calculate_costs): Check for size
5425 calculation overflow.
5426 (encode_terminal_code): Use ptrdiff_t, not int, to record glyph
5427 table lengths and related sizes. Don't update size until alloc
5428 done. Redo calculations to avoid overflow.
5429 (calculate_costs): Don't bother calling xmalloc when xrealloc will do.
5430
5431 * termcap.c (tgetent): Use ptrdiff_t, not int, to record results of
5432 subtracting pointers.
5433 (gobble_line): Check for overflow more carefully. Don't update size
5434 until alloc done.
5435
5436 * tparam.c (tparam1): Use ptrdiff_t, not int, for sizes.
5437 Don't update size until alloc done.
5438 Redo size calculations to avoid overflow.
5439 Check for size calculation overflow.
0065d054 5440 (main) [DEBUG]: Fix typo in invoking tparam1.
726e0ab1
PE
5441
5442 * xdisp.c (store_mode_line_noprop_char, x_consider_frame_title):
5443 Use ptrdiff_t, not int, for sizes.
5444 (store_mode_line_noprop_char): Don't update size until alloc done.
5445
0065d054
PE
5446 * xfaces.c (lface_id_to_name_size, Finternal_make_lisp_face):
5447 Use ptrdiff_t, not int, for sizes.
5448 (Finternal_make_lisp_face, cache_face):
5449 Check for size calculation overflow.
5450 (cache_face): Treat size calculation overflows as if they were
5451 memory exhaustion (the usual treatment), rather than aborting.
726e0ab1
PE
5452
5453 * xfns.c (x_encode_text, x_set_name_internal)
5454 (Fx_change_window_property): Use ptrdiff_t, not int, to count
5455 sizes, since they can exceed INT_MAX in size. Check for size
5456 calculation overflow.
5457
0065d054
PE
5458 * xgselect.c (gfds_size): Now ptrdiff_t, for convenience with xpalloc.
5459 (xg_select): Check for size calculation overflow.
726e0ab1
PE
5460 Don't update size until alloc done.
5461
0065d054 5462 * xrdb.c (get_environ_db): Don't assume path length fits in int,
726e0ab1 5463 as sprintf is limited to int lengths.
1d526e2f 5464
252c5ee1
PE
5465 * xselect.c (X_LONG_SIZE, X_SHRT_MAX, X_SHRT_MIN, X_LONG_MAX)
5466 (X_LONG_MIN): New macros.
864d7ce7
PE
5467 Use them to make the following changes clearer.
5468 (MAX_SELECTION_QUANTUM): Make the other bounds on this value clearer.
5469 This change doesn't affect the value now, but it may help remind
5470 future maintainers not to raise the value too much later.
5471 (SELECTION_QUANTUM): Remove, replacing with ...
5472 (selection_quantum): ... new function, which avoids overflow.
5473 All uses changed.
5474 (struct selection_data.size): Now ptrdiff_t, not int, to avoid
5475 assumption that selection length fits in 'int'.
5476 (x_reply_selection_request, x_handle_selection_request)
5477 (x_get_window_property, receive_incremental_selection)
5478 (x_get_window_property_as_lisp_data, selection_data_to_lisp_data)
5479 (lisp_data_to_selection_data, clean_local_selection_data):
5480 Use ptrdiff_t, not int, to record length of selection.
5481 (x_reply_selection_request, x_get_window_property)
5482 (receive_incremental_selection, x_property_data_to_lisp):
5483 Redo calculations to avoid overflow.
5484 (x_reply_selection_request): When sending hint, ceiling it at
252c5ee1 5485 X_LONG_MAX rather than relying on wraparound overflow to send
864d7ce7
PE
5486 something.
5487 (x_get_window_property, receive_incremental_selection)
5488 (lisp_data_to_selection_data, x_property_data_to_lisp):
5489 Check for size-calculation overflow.
5490 (x_get_window_property, receive_incremental_selection)
5491 (lisp_data_to_selection_data, Fx_register_dnd_atom):
5492 Don't store size until memory allocation succeeds.
5493 (x_get_window_property): Plug memory leak on memory exhaustion.
5494 Don't double-block input; malloc is safe here. Don't assume 2**34
5495 - 4 fits in unsigned long. Add an xassert to check
5496 XGetWindowProperty overflow. Be more careful about overflow
5497 calculations, and distinguish size from memory overflow better.
5498 (receive_incremental_selection): When tracing, don't assume
5499 unsigned int is less than INT_MAX.
5500 (x_selection_data_to_lisp_data): Remove unnecessary (and in theory
5501 harmful) conversions of unsigned short to int.
5502 (lisp_data_to_selection_data): Don't assume that integers
5503 in the range -65535 through -1 fit in an X unsigned short.
5504 Don't assume that ULONG_MAX == X_ULONG_MAX. Don't store into
5505 result parameters unless successful. Rely on cons_to_unsigned
5506 to report problems with elements; the old code wasn't right anyway.
5507 (x_check_property_data): Check for int overflow; we cannot use
5508 a wider type due to X limits.
5509 (x_handle_dnd_message): Use unsigned int, to avoid int overflow.
5510
726e0ab1 5511 * xsmfns.c (smc_save_yourself_CB): Check for size calc overflow.
34db673b 5512
0065d054
PE
5513 * xterm.c (x_color_cells, x_send_scrollbar_event, handle_one_xevent)
5514 (x_term_init): Check for size calculation overflow.
726e0ab1
PE
5515 (x_color_cells): Don't store size until memory allocation succeeds.
5516 (handle_one_xevent): Use ptrdiff_t, not int, for byte counts.
0065d054 5517 Don't assume alloca size is less than MAX_ALLOCA.
726e0ab1
PE
5518 (x_term_init): Don't assume length fits in int (sprintf is limited
5519 to int size).
bc18e09d 5520
ebfa62c0
PE
5521 Use ptrdiff_t for composition IDs.
5522 * character.c (lisp_string_width):
5523 * composite.c (composition_table_size, n_compositions)
5524 (get_composition_id, composition_gstring_from_id):
5525 * dispextern.h (struct glyph_string.cmp_id, struct composition_it.id):
5526 * xdisp.c (BUILD_COMPOSITE_GLYPH_STRING):
5527 * window.c (Frecenter):
5528 Use ptrdiff_t, not int, for composition IDs.
5529 * composite.c (get_composition_id): Check for integer overflow.
5530 * composite.h: Adjust prototypes to match the above changes.
5531
d3411f89
PE
5532 Use ptrdiff_t for hash table indexes.
5533 * category.c (hash_get_category_set):
5534 * ccl.c (ccl_driver):
5535 * charset.h (struct charset.hash_index, CHECK_CHARSET_GET_ID):
5536 * coding.c (coding_system_charset_list, detect_coding_system):
5537 * coding.h (struct coding_system.id):
5538 * composite.c (get_composition_id, gstring_lookup_cache):
5539 * fns.c (hash_lookup, hash_put, Fgethash, Fputhash):
5540 * image.c (xpm_get_color_table_h):
5541 * lisp.h (hash_lookup, hash_put):
5542 * minibuf.c (Ftest_completion):
5543 Use ptrdiff_t for hash table indexes, not int (which is too
5544 narrow, on 64-bit hosts) or EMACS_INT (which is too wide, on
5545 32-bit --with-wide-int hosts).
5546
e097a6fa
PE
5547 * charset.c (Fdefine_charset_internal): Check for integer overflow.
5548 Add a FIXME comment about memory leaks.
5549 (syms_of_charset): Don't assume xmalloc returns.
5550
5637687f
PE
5551 Don't assume that stated character widths fit in int.
5552 * character.c (Fchar_width, c_string_width, lisp_string_width):
5553 * character.h (CHAR_WIDTH):
5554 * indent.c (MULTIBYTE_BYTES_WIDTH):
5555 Use sanitize_char_width to avoid undefined and/or bad behavior
5556 with outlandish widths.
a66cfb1c 5557 * character.h (sanitize_tab_width): Rename from sanitize_width,
5637687f
PE
5558 now that we have two such functions. All uses changed.
5559 (sanitize_char_width): New inline function.
5560
a2271ba2
PE
5561 Don't assume that tab-width fits in int.
5562 * character.h (sanitize_width): New inline function.
5563 (SANE_TAB_WIDTH): New macro.
5564 (ASCII_CHAR_WIDTH): Use it.
5565 * indent.c (sane_tab_width): Remove. All uses replaced by
5566 SANE_TAB_WIDTH (current_buffer).
5567 * xdisp.c (init_iterator): Use SANE_TAB_WIDTH.
5568
18c52557
PE
5569 * fileio.c: Integer overflow issues with file modes.
5570 (Fset_file_modes, auto_save_1): Don't assume EMACS_INT fits in int.
5571
caeeedc1
PE
5572 * charset.c (read_hex): New arg OVERFLOW. All uses changed.
5573 Remove unreachable code.
5574 (read_hex, load_charset_map_from_file): Check for integer overflow.
5575
6df6ae42 5576 * xterm.c: Don't go over XClientMessageEvent limit.
50849c52
PE
5577 (scroll_bar_windows_size): Now ptrdiff_t, as we prefer signed.
5578 (x_send_scroll_bar_event): Likewise. Check that the size does not
5579 exceed limits imposed by XClientMessageEvent, as well as the usual
5580 ptrdiff_t and size_t limits.
5581
b13995db
PE
5582 * keyboard.c: Overflow, signedness and related fixes.
5583 (make_lispy_movement): Use same integer type in forward decl
5584 that is used in the definition.
5585 (read_key_sequence, keyremap_step):
5586 Change bufsize argument back to int, undoing my 2011-03-30 change.
5587 We prefer signed types, and int is wide enough here.
5588 (parse_tool_bar_item): Don't assume tool_bar_max_label_size is less
5589 than TYPE_MAXIMUM (EMACS_INT) / 2. Don't let the label size grow
5590 larger than STRING_BYTES_BOUND. Use ptrdiff_t for Emacs string
5591 length, not size_t. Use ptrdiff_t for index, not int.
5592 (keyremap_step, read_key_sequence): Redo bufsize check to avoid
5593 possibility of integer overflow.
5594
13464394
PE
5595 Overflow, signedness and related fixes for images.
5596
5597 * dispextern.h (struct it.stack[0].u.image.image_id)
5598 (struct_it.image_id, struct image.id, struct image_cache.size)
5599 (struct image_cache.used, struct image_cache.ref_count):
5600 * gtkutil.c (update_frame_tool_bar):
5601 * image.c (x_reference_bitmap, Fimage_size, Fimage_mask_p)
5602 (Fimage_metadata, free_image_cache, clear_image_cache, lookup_image)
5603 (cache_image, mark_image_cache, x_kill_gs_process, Flookup_image):
5604 * nsmenu.m (update_frame_tool_bar):
5605 * xdisp.c (calc_pixel_width_or_height):
5606 * xfns.c (image_cache_refcount):
5607 Image IDs are now ptrdiff_t, not int, to avoid arbitrary limits
5608 on typical 64-bit hosts.
5609
5610 * image.c (RANGED_INTEGERP, TYPE_RANGED_INTEGERP): New macros.
5611 (x_bitmap_pixmap, x_create_x_image_and_pixmap):
5612 Omit unnecessary casts to int.
5613 (parse_image_spec): Check that integers fall into 'int' range
5614 when the callers expect that.
5615 (image_ascent): Redo ascent calculation to avoid int overflow.
5616 (clear_image_cache): Avoid overflow when sqrt (INT_MAX) < nimages.
5617 (lookup_image): Remove unnecessary tests.
5618 (xbm_image_p): Locals are now of int, not EMACS_INT,
5619 since parse_image_check makes sure they fit into int.
5620 (png_load, gif_load, svg_load_image):
5621 Prefer int to unsigned where either will do.
5622 (tiff_handler): New function, combining the cores of the
a66cfb1c
SM
5623 old tiff_error_handler and tiff_warning_handler.
5624 This function is rewritten to use vsnprintf and thereby avoid
13464394
PE
5625 stack buffer overflows. It uses only the features of vsnprintf
5626 that are common to both POSIX and native Microsoft.
5627 (tiff_error_handler, tiff_warning_handler): Use it.
5628 (tiff_load, gif_load, imagemagick_load_image):
5629 Don't assume :index value fits in 'int'.
5630 (gif_load): Omit unnecessary cast to double, and avoid double-rounding.
5631 (imagemagick_load_image): Check that crop parameters fit into
5632 the integer types that MagickCropImage accepts. Don't assume
5633 Vimagemagick_render_type has a nonnegative value. Don't assume
5634 size_t fits in 'long'.
5635 (gs_load): Use printmax_t to print the widest integers possible.
5636 Check for integer overflow when computing image height and width.
5637
c11821d4
EZ
56382011-08-26 Eli Zaretskii <eliz@gnu.org>
5639
5640 * xdisp.c (redisplay_window): Don't force window start if point
5641 will be invisible in the resulting window. (Bug#9324)
5642
0c95fcf7
EZ
56432011-08-25 Eli Zaretskii <eliz@gnu.org>
5644
5645 * xdisp.c (compute_display_string_pos): Return 2 in DISP_PROP when
5646 the display spec is of the form `(space ...)'.
5647 (handle_display_spec): Return the value returned by
5648 handle_single_display_spec, not just 1 or zero.
5649 (handle_single_display_spec): If the display spec is of the form
5650 `(space ...)', and specifies display in the text area, return 2
5651 rather than 1.
fee65a97 5652 (try_cursor_movement): Check for the need to scroll more
a66cfb1c
SM
5653 accurately, and prefer exact match for point under bidi.
5654 Don't advance `row' beyond the last row of the window.
0c95fcf7
EZ
5655
5656 * dispextern.h (struct bidi_it): Rename the disp_prop_p member
5657 into disp_prop; all users changed.
5658
5659 * bidi.c (bidi_fetch_char): If compute_display_string_pos returns
5660 DISP_PROP = 2, substitute the u+2029 PARAGRAPH SEPARATOR character
5661 for the text covered by the display property.
5662
e4ed06f1
CY
56632011-08-25 Chong Yidong <cyd@stupidchicken.com>
5664
5665 * buffer.c (Fbury_buffer_internal): Rename from Funrecord_buffer.
5666 Change return value to nil.
5667 (Frecord_buffer): Delete unused function.
5668
f67cdd7f
EZ
56692011-08-24 Eli Zaretskii <eliz@gnu.org>
5670
5980d4c6
EZ
5671 * xdisp.c (Fcurrent_bidi_paragraph_direction): For unibyte
5672 buffers, return left-to-right.
8610fe8b
EZ
5673 (set_cursor_from_row): Consider candidate row a win if its glyph
5674 represents a newline and point is on that newline. Fixes cursor
5675 positioning on the newline at EOL of R2L text within L2R
5676 paragraph, and vice versa.
5677 (try_cursor_movement): Check continued rows, in addition to
5678 continuation rows. Fixes unwarranted scroll when point enters a
5679 continued line of R2L text within an L2R paragraph, or vice versa.
5680 (cursor_row_p): Consider the case of point being equal to
5681 MATRIX_ROW_END_CHARPOS. Prevents cursor being stuck when moving
5682 from the end of a short line to the beginning of a continued line
5683 of R2L text within L2R paragraph.
5684 (RECORD_MAX_MIN_POS): For max_pos, use IT_CHARPOS even for
5685 composed characters.
5980d4c6 5686
f67cdd7f
EZ
5687 * bidi.c (bidi_check_type): Use xassert.
5688 (bidi_cache_iterator_state): Update the disp_pos and disp_prop_p
5689 members.
5690
bca633fb
EZ
56912011-08-23 Eli Zaretskii <eliz@gnu.org>
5692
5693 * bidi.c (bidi_get_type): Abort if we get zero as the bidi type of
5694 a character.
5695
4a5885a7
CY
56962011-08-23 Chong Yidong <cyd@stupidchicken.com>
5697
5698 * nsfont.m (ns_otf_to_script): Fix typo.
5699
0902a04e
KH
57002011-08-22 Kenichi Handa <handa@m17n.org>
5701
5702 * chartab.c (Fset_char_table_extra_slot): Do not inhibit setting a
5703 extra slot even if the purpose is char-code-property-table.
5704
1a2e6670
EZ
57052011-08-23 Eli Zaretskii <eliz@gnu.org>
5706
8ddde651
EZ
5707 * xdisp.c (redisplay_window): When computing centering_position,
5708 account for the height of the header line. (Bug#8874)
5709
425cc014
EZ
5710 * dispnew.c (buffer_posn_from_coords): Use buf_charpos_to_bytepos
5711 instead of CHAR_TO_BYTE. Fixes a crash when a completion
5712 candidate is selected by the mouse, and that candidate has a
5713 composed character under the mouse.
5714
1a2e6670
EZ
5715 * xdisp.c (x_produce_glyphs): Set it->nglyphs to 1. Fixes pixel
5716 coordinates reported by pos-visible-in-window-p for a composed
5717 character in column zero.
5718
8b76d6f8
SM
57192011-08-23 Stefan Monnier <monnier@iro.umontreal.ca>
5720
5721 * cmds.c (Fself_insert_command): Mention post-self-insert-hook.
5722
dac347dd
EZ
57232011-08-22 Eli Zaretskii <eliz@gnu.org>
5724
5725 * xdisp.c (BUFFER_POS_REACHED_P): If this is a composition,
5726 consider it a hit if to_charpos is anywhere in the range of the
5727 composed buffer positions.
5728
e013fb34
CY
57292011-08-22 Chong Yidong <cyd@stupidchicken.com>
5730
5731 * image.c (gif_load): Don't assume that each subimage has the same
5732 dimensions as the base image. Handle disposal method that is
5733 "undefined" by the gif spec (Bug#9335).
5734
bd1ba3e8
CY
57352011-08-20 Chong Yidong <cyd@stupidchicken.com>
5736
5737 * eval.c (Fsignal): Handle `debug' symbol in error handler (Bug#9329).
024a2d76 5738 (Fcondition_case): Document `debug' symbol in error handler.
bd1ba3e8 5739
54a1215b
EZ
57402011-08-19 Eli Zaretskii <eliz@gnu.org>
5741
823564e5
EZ
5742 * xfaces.c (face_at_buffer_position): Avoid repeated evaluation of
5743 face ID by FACE_FROM_ID, and avoid a crash when mouse is moved
5744 from an Org mode buffer to a Speedbar frame.
5745
54a1215b
EZ
5746 * xdisp.c (RECORD_MAX_MIN_POS): If the display element comes from
5747 a composition, take its buffer position from IT->cmp_it.charpos.
5748 Fixes cursor positioning at the beginning of a line that begins
5749 with a composed character.
5750
9778ebcc
EZ
57512011-08-18 Eli Zaretskii <eliz@gnu.org>
5752
0be6ee06
EZ
5753 * bidi.c (bidi_get_type): If bidi_type_table reports zero as the
5754 character bidirectional type, use STRONG_L instead. Fixes crashes
5755 in a buffer produced by `describe-categories'.
5756
9778ebcc
EZ
5757 * dispextern.h (struct bidi_it): Move disp_pos and disp_prop_p
5758 members before the level stack, so they would be saved and
5759 restored when copying iterator state. Fixes incorrect reordering
5760 around TABs covered by display properties.
5761
156bffbe
AS
57622011-08-18 Andreas Schwab <schwab@linux-m68k.org>
5763
6b02f655 5764 * process.c (Fnetwork_interface_list): Correctly determine buffer size.
156bffbe 5765
72ad093b
CY
57662011-08-17 Chong Yidong <cyd@stupidchicken.com>
5767
5768 * eval.c (internal_condition_case, internal_condition_case_1)
8b76d6f8
SM
5769 (internal_condition_case_2, internal_condition_case_n):
5770 Remove unnecessary aborts (Bug#9081).
72ad093b 5771
35774242
EZ
57722011-08-17 Eli Zaretskii <eliz@gnu.org>
5773
5774 * lread.c (Fload) [DOS_NT]: If `openp' returns -2, but the file
5775 has no `load' handler, try opening the file locally. (Bug#9311)
5776
db76dd85
KB
57772011-08-16 Ken Brown <kbrown@cornell.edu>
5778
5779 * gmalloc.c: Expand comment.
5780
b215eee5
EZ
57812011-08-16 Eli Zaretskii <eliz@gnu.org>
5782
5783 * xdisp.c (set_cursor_from_row): Don't accept a previous candidate
5784 if it fails the cursor_row_p test. Fixes cursor positioning at ZV.
5785
a4579d33
KB
57862011-08-16 Ken Brown <kbrown@cornell.edu>
5787
5788 Fix memory allocation problems in Cygwin build (Bug#9273).
5789
5790 * unexcw.c ( __malloc_initialized): Declare external variable.
5791 (fixup_executable): Force the dumped emacs to reinitialize malloc.
5792
8b76d6f8
SM
5793 * gmalloc.c [CYGWIN] (bss_sbrk_heapbase, bss_sbrk_heapinfo):
5794 New variables.
a4579d33
KB
5795 (malloc_initialize_1) [CYGWIN]: Prepare for reinitializing the
5796 dumped emacs.
5797 (_free_internal_nolock) [CYGWIN]: Ignore requests to free storage
5798 in the static heap.
5799 [CYGWIN] (special_realloc): New function.
5800 (_realloc_internal_nolock) [CYGWIN]: Use the new function on
5801 requests to realloc storage in the static heap.
5802
3ebec551
PE
58032011-08-15 Paul Eggert <eggert@cs.ucla.edu>
5804
5805 * bidi.c (bidi_initialize): Remove unused local.
5806
9fd8be00
EZ
58072011-08-15 Eli Zaretskii <eliz@gnu.org>
5808
6b02f655
SM
5809 * bidimirror.h:
5810 * biditype.h: Remove file.
5811 * makefile.w32-in ($(BLD)/bidi.$(O)):
5812 * deps.mk (bidi.o): Remove biditype.h and bidimirror.h.
474a8465
EZ
5813
5814 * dispextern.h: Fix a typo in the comment to bidi_type_t.
5815
5816 * chartab.c: Improve commentary for the uniprop_table API.
5817
32413314
EZ
5818 * bidi.c (bidi_paragraph_init): Support zero value of
5819 bidi_ignore_explicit_marks_for_paragraph_level.
474a8465
EZ
5820 (bidi_initialize): Use uniprop_table instead of including
5821 biditype.h and bidimirror.h.
32413314 5822
9fd8be00
EZ
5823 * xdisp.c (move_it_in_display_line_to): Don't reset pixel
5824 coordinates of the iterator when restoring from ppos_it.
5825 (Bug#9296)
5826
5cf2b69b
KH
58272011-08-14 Kenichi Handa <handa@m17n.org>
5828
5829 * process.c (create_process): Call setup_process_coding_systems
72ad093b 5830 after the pid of the process is set to -1 (Bug#8162).
5cf2b69b 5831
daf17d00
EZ
58322011-08-14 Eli Zaretskii <eliz@gnu.org>
5833
5834 * xdisp.c (move_it_in_display_line_to): Don't invoke
5835 IT_RESET_X_ASCENT_DESCENT when iterator position was restored from
5836 ppos_it. Fixes vertical cursor motion when line beginning is
5837 covered by an image. (Bug#9296)
5838
08e3161a
JD
58392011-08-14 Jan Djärv <jan.h.d@swipnet.se>
5840
5841 * nsterm.h (ns_run_ascript): Declare.
5842 (NSAPP_DATA2_RUNASSCRIPT): Define.
5843
5844 * nsfns.m (as_script, as_result, as_status): New static variables.
5845 (ns_run_ascript): New function.
5e617bc2 5846 (Fns_do_applescript): Set variables as_*. Make an NSApplicationDefined
08e3161a
JD
5847 event with data2 set to NSAPP_DATA2_RUNASSCRIPT, post it and then start
5848 the event loop. Get status from as_status (Bug#7276).
5849
5850 * nsterm.m (sendEvent): If event is NSApplicationDefined and
5851 data2 is NSAPP_DATA2_RUNASSCRIPT, call ns_run_ascript and then exit
5852 the event loop (Bug#7276).
5853
a3720aa2
AS
58542011-08-14 Andreas Schwab <schwab@linux-m68k.org>
5855
5856 * gnutls.c (QCgnutls_bootprop_priority)
5857 (QCgnutls_bootprop_trustfiles, QCgnutls_bootprop_keylist)
5858 (QCgnutls_bootprop_crlfiles, QCgnutls_bootprop_callbacks)
5859 (QCgnutls_bootprop_loglevel, QCgnutls_bootprop_hostname)
5860 (QCgnutls_bootprop_min_prime_bits, QCgnutls_bootprop_verify_flags)
5861 (QCgnutls_bootprop_verify_hostname_error)
5862 (QCgnutls_bootprop_callbacks_verify): Rename from
5863 Qgnutls_bootprop_..., all uses changed.
5864
5865 * xfaces.c (QCignore_defface): Rename from Qignore_defface, all
5866 uses changed.
5867
0a0d27fb
PE
58682011-08-14 Paul Eggert <eggert@cs.ucla.edu>
5869
19d5c50c
PE
5870 * xfaces.c (Qframe_set_background_mode): Now static.
5871 * dispextern.h (Qframe_set_background_mode): Remove decl.
5872
0a0d27fb
PE
5873 * process.c (Fnetwork_interface_info): Declare local only if needed.
5874
377538cb
JD
58752011-08-13 Jan Djärv <jan.h.d@swipnet.se>
5876
5877 * process.c: Include ifaddrs.h and net/if_dl.h if available (Bug#8477).
5878 (Fnetwork_interface_list): Allocate in increments of bytes instead
5879 of sizeof (struct ifreq). Iterate over ifconf.ifc_req by counting
5880 bytes (Bug#8477). Count bytes correctly when ifr_addr is a struct
5881 sockaddr.
5882 (struct ifflag_def): notrailers is smart on OSX.
5883 (Fnetwork_interface_info): Handle case when ifr_flags is negative.
5884 Get hardware address with getifaddrs if available.
5885
08fff70c
EZ
58862011-08-12 Eli Zaretskii <eliz@gnu.org>
5887
5888 * xdisp.c (iterate_out_of_display_property): xassert that
5889 IT->position is set to within IT->object's boundaries. Break from
5890 the loop as soon as EOB is reached; avoids infloops in redisplay
8b76d6f8
SM
5891 when IT->position is set up wrongly due to some bug.
5892 Set IT->current to match the bidi iterator unconditionally.
08fff70c
EZ
5893 (push_display_prop): Allow GET_FROM_STRING as IT->method on
5894 entry. Force push_it to save on the stack the current
5895 buffer/string position, to be restored by pop_it. Fix flags in
5896 the iterator structure wrt the object coming from a display
5897 property, as `line-prefix' and `wrap-prefix' are not ``replacing''
5898 properties. (Bug#9284)
5899
7be1c708 59002011-08-09 Andreas Schwab <schwab@linux-m68k.org>
aac0c6e3 5901
7be1c708
CY
5902 * fontset.c (fontset_get_font_group): Add proper type checks.
5903 (Bug#9172)
aac0c6e3 5904
7be1c708 59052011-08-09 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
aac0c6e3 5906
7be1c708
CY
5907 * unexmacosx.c (print_load_command_name): Add cases LC_FUNCTION_STARTS
5908 and LC_VERSION_MIN_MACOSX.
5909 (copy_linkedit_data) [LC_FUNCTION_STARTS]: New function.
5910 (dump_it) [LC_FUNCTION_STARTS]: Use it.
aac0c6e3 5911
97bb72a6
EZ
59122011-08-08 Eli Zaretskii <eliz@gnu.org>
5913
5914 * xdisp.c (forward_to_next_line_start): Allow to use the
8b76d6f8
SM
5915 no-display-properties-and-no-overlays under bidi display.
5916 Set disp_pos in the bidi iterator to avoid searches for display
757664a4 5917 properties and overlays.
97bb72a6 5918
d5617611
CY
59192011-08-08 Chong Yidong <cyd@stupidchicken.com>
5920
37e11a63
CY
5921 * editfns.c (Fset_time_zone_rule): Document relationship with the
5922 setenv function.
5923
d5617611
CY
5924 * ftfont.c (ftfont_pattern_entity): Copy the extras argument to
5925 the font entity extracted from the cache (Bug#8109).
5926
58872834
CY
59272011-08-07 Chong Yidong <cyd@stupidchicken.com>
5928
5929 * composite.c (autocmp_chars): Don't reset point. That is done by
5930 restore_point_unwind (Bug#5984).
5931
75bfc667
JL
59322011-08-07 Juri Linkov <juri@jurta.org>
5933
5934 * editfns.c (Fformat_time_string): Doc fix, add tag `usage:'
5935 to show the arg `TIME' instead of `TIMEVAL'.
5936
d1410150
EZ
59372011-08-06 Eli Zaretskii <eliz@gnu.org>
5938
5939 * xdisp.c (set_cursor_from_row): Fix cursor positioning when a
5940 display property strides EOL and includes a newline, as in
5941 longlines-mode. (Bug#9254)
75b771e4
EZ
5942 (move_it_in_display_line_to): Fix vertical-motion in a buffer with
5943 word-wrap under bidirectional display. (Bug#9224)
d1410150
EZ
5944
5945 * bidi.c (bidi_unshelve_cache): Don't reset the cache if JUST_FREE
5946 is non-zero, even if the data buffer is NULL. Fixes a crash in
5947 vertical-motion with longlines-mode. (Bug#9254)
5948
35928349
EZ
59492011-08-05 Eli Zaretskii <eliz@gnu.org>
5950
ec7cc85b
EZ
5951 * bidi.c <bidi_cache_total_alloc>: Now static.
5952 (bidi_initialize): Initialize bidi_cache_total_alloc.
5953
8b76d6f8 5954 * xdisp.c (display_line): Release buffer allocated for shelved bidi
35928349
EZ
5955 cache. (Bug#9221)
5956
5957 * bidi.c (bidi_shelve_cache, bidi_unshelve_cache): Track total
5958 amount allocated this far in `bidi_cache_total_alloc'.
5959 (bidi_unshelve_cache): Accept an additional argument JUST_FREE; if
5960 non-zero, only free the data buffer without restoring the cache
5961 contents. All callers changed.
5962
5963 * dispextern.h (bidi_unshelve_cache): Update prototype.
5964
5965 * xdisp.c (SAVE_IT, pos_visible_p, move_it_in_display_line_to)
5966 (move_it_in_display_line, move_it_to)
5967 (move_it_vertically_backward, move_it_by_lines): Replace the call
5968 to xfree to an equivalent call to bidi_unshelve_cache.
5969 (move_it_in_display_line_to): Fix logic of returning
412b6358 5970 MOVE_POS_MATCH_OR_ZV in the bidi case. (Bug#9224)
35928349 5971
e2e2423b
EZ
59722011-08-05 Eli Zaretskii <eliz@gnu.org>
5973
5974 * xdisp.c (set_cursor_from_row): Prefer the candidate glyph that
5975 came from a string character with a `cursor' property. (Bug#9229)
5976
ae9e757a
JD
59772011-08-04 Jan Djärv <jan.h.d@swipnet.se>
5978
5979 * Makefile.in (LIB_PTHREAD): New variable.
5980 (LIBES): Add LIB_PTHREAD (Bug#9216).
5981
5982 * alloc.c, emacs.c, gmalloc.c, gtkutil.c, keyboard.c, syssignal.h:
5983 Rename HAVE_GTK_AND_PTHREAD to HAVE_PTHREAD (Bug#9216).
5984
213bd7f2
AS
59852011-08-04 Andreas Schwab <schwab@linux-m68k.org>
5986
6b02f655 5987 * regex.c (re_iswctype): Remove some redundant boolean conversions.
213bd7f2 5988
99aaf75f
JD
59892011-08-04 Jan Djärv <jan.h.d@swipnet.se>
5990
5991 * xterm.c (x_find_topmost_parent): New function.
5992 (x_set_frame_alpha): Find topmost parent window with
5993 x_find_topmost_parent and set the property there also (bug#9181).
5994 (handle_one_xevent): Call x_set_frame_alpha on ReparentNotify.
5995
c74e9d86
PE
59962011-08-04 Paul Eggert <eggert@cs.ucla.edu>
5997
5998 * callproc.c (Fcall_process): Avoid vfork clobbering
5999 the local vars buffer, coding_systems, current_dir.
6000
640c8776
SM
60012011-08-03 Stefan Monnier <monnier@iro.umontreal.ca>
6002
6003 * keymap.c (Fmake_composed_keymap): Move to subr.el.
6004
f26d0e4c
PE
60052011-08-03 Paul Eggert <eggert@cs.ucla.edu>
6006
8a10d76c
PE
6007 * fontset.c (dump_fontset) [FONTSET_DEBUG]: Declare EXTERNALLY_VISIBLE
6008 so that it is not optimized away.
6009
f26d0e4c
PE
6010 * xdisp.c (compute_display_string_pos): Remove unused local.
6011
55439c61
EZ
60122011-08-02 Eli Zaretskii <eliz@gnu.org>
6013
6014 Fix slow cursor motion and scrolling in large buffers with
6015 selective display, like Org Mode buffers. (Bug#9218)
6016
6017 * dispextern.h (struct bidi_it): New member disp_prop_p.
6018
6019 * xdisp.c: Remove one-slot cache of display string positions.
6020 (compute_display_string_pos): Accept an additional argument
5e617bc2 6021 DISP_PROP_P; callers changed. Scan at most 5K characters forward
55439c61
EZ
6022 for a display string or property. If found, set DISP_PROP_P
6023 non-zero.
6024
6025 * bidi.c (bidi_fetch_char): Accept an additional argument
640c8776
SM
6026 DISP_PROP_P, and pass it to compute_display_string_pos.
6027 Only handle text covered by a display string if DISP_PROP_P is returned
55439c61
EZ
6028 non-zero. All callers of bidi_fetch_char changed.
6029
fb33fa43
SM
60302011-08-02 Stefan Monnier <monnier@iro.umontreal.ca>
6031
6032 * keymap.c (Fdefine_key): Fix Lisp_Object/int mixup; apply some CSE.
6033
b099e063
DM
60342010-12-03 Don March <don@ohspite.net>
6035
6036 * keymap.c (Fdefine_key): Fix non-prefix key error message when
6037 last character M-[char] is translated to ESC [char] (bug#7541).
6038
5cc7f7af
KH
60392011-08-02 Kenichi Handa <handa@m17n.org>
6040
d0fffa3f 6041 * lisp.h (uniprop_table): Extern it.
5cc7f7af
KH
6042
6043 * chartab.c (uniprop_table): Make it non-static.
6044
525d5e6e
EZ
60452011-08-01 Eli Zaretskii <eliz@gnu.org>
6046
6047 * xdisp.c (forward_to_next_line_start): Accept additional argument
6048 BIDI_IT_PREV, and store into it the state of the bidi iterator had
6049 on the newline.
6050 (reseat_at_next_visible_line_start): Use the bidi iterator state
6051 returned by forward_to_next_line_start to restore the state of
6052 it->bidi_it after backing up to previous newline. (Bug#9212)
6053
31011111
AS
60542011-07-30 Andreas Schwab <schwab@linux-m68k.org>
6055
6056 * regex.c (re_comp): Protoize.
6057 (re_exec): Fix return type.
6058 (regexec): Fix type of `ret'. (Bug#9203)
6059
476371c4
PE
60602011-07-28 Paul Eggert <eggert@cs.ucla.edu>
6061
e5d76069
PE
6062 * image.c (check_image_size): Use 1024x1024 if unknown frame (Bug#9189).
6063 This is needed if max-image-size is a floating-point number.
6064
9a79b20c
AS
60652011-07-28 Andreas Schwab <schwab@linux-m68k.org>
6066
6067 * print.c (print_object): Print empty symbol as ##.
6068
6069 * lread.c (read1): Read ## as empty symbol.
6070
d8c2fa78
AA
60712011-07-28 Alp Aker <alp.tekin.aker@gmail.com>
6072
6073 * nsfns.m (x_set_foreground_color): Set f->foreground_pixel when
6074 setting frame foreground color (Bug#9175).
6075 (x_set_background_color): Likewise.
6076
ffe57a7a
AA
6077 * nsmenu.m (-setText): Size tooltip dimensions precisely to
6078 contents (Bug#9176).
6079 (EmacsTooltip -init): Remove bezels and add shadows to
6080 tooltip windows.
6081
bf3492a5
AA
6082 * nsterm.m (ns_dumpglyphs_stretch): Avoid overwriting left fringe
6083 or scroll bar (Bug#8470).
6084
d55e9c53
AA
6085 * nsfont.m (nsfont_open): Remove assignment to voffset and
6086 unnecessary vars hshink, expand, hd, full_height, min_height.
6087 (nsfont_draw): Use s->ybase as baseline for glyph drawing (Bug#8913).
6088
6089 * nsterm.h (nsfont_info): Remove voffset field.
6090
d8c2fa78 60912011-07-28 Alp Aker <alp.tekin.aker@gmail.com>
4843aac3
AA
6092
6093 Implement strike-through and overline on NextStep (Bug#8863).
6094
6095 * nsfont.m (nsfont_open): Use underline position provided by font,
6096 instead of hard-coded value of 2.
6097 (nsfont_draw): Call ns_draw_text_decoration instead.
6098
6099 * nsterm.h: Add declaration for ns_draw_text_decoration.
6100
6101 * nsterm.m (ns_draw_text_decoration): New function for drawing
6102 underline, overline, and strike-through.
6103 (ns_dumpglyphs_image, ns_dumpglyphs_stretch): Add call to
6104 ns_draw_text_decoration. Change treatment of cursor drawing to
8d5ed899 6105 accommodate underlining, etc.
4843aac3 6106
4cc60b9b
EZ
61072011-07-28 Eli Zaretskii <eliz@gnu.org>
6108
bc7ece87
EZ
6109 * buffer.c (init_buffer_once): Set bidi-display-reordering to t by
6110 default.
4cc60b9b 6111
476371c4
PE
61122011-07-28 Paul Eggert <eggert@cs.ucla.edu>
6113
66606eea
PE
6114 * alloc.c (memory_full) [!SYNC_INPUT]: Fix signal-related race.
6115 Without this fix, if a signal arrives just after memory fills up,
6116 'malloc' might be invoked reentrantly.
6117
476371c4
PE
6118 * image.c (x_check_image_size) [!HAVE_X_WINDOWS]: Return 1.
6119 In other words, assume that every image size is allowed, on non-X
6120 hosts. This assumption is probably wrong, but it lets Emacs compile.
6121
f3fcc40d
AS
61222011-07-28 Andreas Schwab <schwab@linux-m68k.org>
6123
6124 * regex.c (re_iswctype): Convert return values to boolean.
6125
350c992f
EZ
61262011-07-28 Eli Zaretskii <eliz@fencepost.gnu.org>
6127
6128 * xdisp.c (compute_display_string_pos): Don't use cached display
6129 string position if the buffer had its restriction changed.
6130 (Bug#9184)
6131
5266b4bb
PE
61322011-07-28 Paul Eggert <eggert@cs.ucla.edu>
6133
6134 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork clobbering.
6135
2573a837 61362011-07-28 Paul Eggert <eggert@cs.ucla.edu>
ca4aa935 6137
41f55ccd 6138 Integer signedness and overflow and related fixes. (Bug#9079)
cf950e6b 6139
39e378da
PE
6140 * bidi.c: Integer size and overflow fixes.
6141 (bidi_cache_size, bidi_cache_idx, bidi_cache_last_idx)
6142 (bidi_cache_start, bidi_cache_fetch_state, bidi_cache_search)
6143 (bidi_cache_find_level_change, bidi_cache_ensure_space)
6144 (bidi_cache_iterator_state, bidi_cache_find, bidi_cache_start_stack)
6145 (bidi_find_other_level_edge):
6146 Use ptrdiff_t instead of EMACS_INT where either will do.
6147 This works better on 32-bit hosts configured --with-wide-int.
6148 (bidi_cache_ensure_space): Check for size-calculation overflow.
6149 Use % rather than repeated addition, for better worst-case speed.
6150 Don't set bidi_cache_size until after xrealloc returns, because it
6151 might not return.
6152 (bidi_dump_cached_states): Use ptrdiff_t, not int, to avoid overflow.
f0eb61e9
PE
6153 (bidi_cache_ensure_space): Also check that the bidi cache size
6154 does not exceed that of the largest Lisp string or buffer. See Eli
6155 Zaretskii in <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=9079#29>.
39e378da 6156
5e927815
PE
6157 * alloc.c (__malloc_size_t): Remove.
6158 All uses replaced by size_t. See Andreas Schwab's note
6159 <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=9079#8>.
6160
ca4aa935
PE
6161 * image.c: Improve checking for integer overflow.
6162 (check_image_size): Assume that f is nonnull, since
6163 it is always nonnull in practice. This is one less thing to
6164 worry about when checking for integer overflow later.
6165 (x_check_image_size): New function, which checks for integer
6166 overflow issues inside X.
6167 (x_create_x_image_and_pixmap, xbm_read_bitmap_data): Use it.
6168 This removes the need for a memory_full check.
6169 (xbm_image_p): Rewrite to avoid integer multiplication overflow.
6170 (Create_Pixmap_From_Bitmap_Data, xbm_load): Use x_check_image_size.
6171 (xbm_read_bitmap_data): Change locals back to 'int', since
6172 their values must fit in 'int'.
6173 (xpm_load_image, png_load, tiff_load):
6174 Invoke x_create_x_image_and_pixmap earlier,
6175 to avoid much needless work if the image is too large.
6176 (tiff_load): Treat overly large images as if
6177 x_create_x_image_and_pixmap failed, not as malloc failures.
6178 (gs_load): Use x_check_image_size.
6179
5f8f9cc2
PE
6180 * gtkutil.c: Omit integer casts.
6181 (xg_get_pixbuf_from_pixmap): Remove unnecessary cast.
6182 (xg_set_toolkit_scroll_bar_thumb): Rewrite to avoid need for cast.
6183
5adf60bc
PE
6184 * image.c (png_load): Don't assume height * row_bytes fits in 'int'.
6185
c8907a93
PE
6186 * xfaces.c (Fbitmap_spec_p): Fix integer overflow bug.
6187 Without this fix, (bitmap-spec-p '(34359738368 1 "x"))
6188 would wrongly return t on a 64-bit host.
6189
e3c25c68
PE
6190 * dispnew.c (init_display): Use *_RANGE_OVERFLOW macros.
6191 The plain *_OVERFLOW macros run afoul of GCC bug 49705
6192 <http://gcc.gnu.org/bugzilla/show_bug.cgi?id=49705>
6193 and therefore cause GCC to emit a bogus diagnostic in some cases.
6194
3f791afe
PE
6195 * image.c: Integer signedness and overflow and related fixes.
6196 This is not an exhaustive set of fixes, but it's time to
6197 record what I've got.
6198 (lookup_pixel_color, check_image_size): Remove redundant decls.
6199 (check_image_size): Don't assume that arbitrary EMACS_INT values
6200 fit in 'int', or that arbitrary 'double' values fit in 'int'.
6201 (x_alloc_image_color, x_create_x_image_and_pixmap, png_load)
6202 (tiff_load, imagemagick_load_image):
6203 Check for overflow in size calculations.
6204 (x_create_x_image_and_pixmap): Remove unnecessary test for
6205 xmalloc returning NULL; that can't happen.
6206 (xbm_read_bitmap_data): Don't assume sizes fit into 'int'.
6207 (xpm_color_bucket): Use better integer hashing function.
6208 (xpm_cache_color): Don't possibly over-allocate memory.
6209 (struct png_memory_storage, tiff_memory_source, tiff_seek_in_memory)
6210 (gif_memory_source):
6211 Use ptrdiff_t, not int or size_t, to record sizes.
6212 (png_load): Don't assume values greater than 2**31 fit in 'int'.
6213 (our_stdio_fill_input_buffer): Prefer ptrdiff_t to size_t when
6214 either works, as we prefer signed integers.
6215 (tiff_read_from_memory, tiff_write_from_memory):
6216 Return tsize_t, not size_t, since that's what the TIFF API wants.
6217 (tiff_read_from_memory): Don't fail simply because the read would
6218 go past EOF; instead, return a short read.
6219 (tiff_load): Omit no-longer-needed casts.
6220 (Fimagemagick_types): Don't assume size fits into 'int'.
6221
3cc5a532
PE
6222 Improve hashing quality when configured --with-wide-int.
6223 * fns.c (hash_string): New function, taken from sxhash_string.
6224 Do not discard information about ASCII character case; this
6225 discarding is no longer needed.
6226 (sxhash-string): Use it. Change sig to match it. Caller changed.
6227 * lisp.h: Declare it.
6228 * lread.c (hash_string): Remove, since we now use fns.c's version.
6229 The fns.c version returns a wider integer if --with-wide-int is
6230 specified, so this should help the quality of the hashing a bit.
6231
b312a492
PE
6232 * emacs.c: Integer overflow minor fix.
6233 (heap_bss_diff): Now uprintmax_t, not unsigned long. All used changed.
6234 Define only if GNU_LINUX.
6235 (main, Fdump_emacs): Set and use heap_bss_diff only if GNU_LINUX.
6236
dfd153ae
PE
6237 * dispnew.c: Integer signedness and overflow fixes.
6238 Remove unnecessary forward decls, that were a maintenance hassle.
6239 (history_tick): Now uprintmax_t, so it's more likely to avoid overflow.
6240 All uses changed.
6241 (adjust_glyph_matrix, realloc_glyph_pool, adjust_frame_message_buffer)
6242 (scrolling_window): Use ptrdiff_t, not int, for byte count.
6243 (prepare_desired_row, line_draw_cost):
6244 Use int, not unsigned, where either works.
6245 (save_current_matrix, restore_current_matrix):
6246 Use ptrdiff_t, not size_t, where either works.
6247 (init_display): Check for overflow more accurately, and without
6248 relying on undefined behavior.
6249
a81d11a3
PE
6250 * editfns.c (pWIDE, pWIDElen, signed_wide, unsigned_wide):
6251 Remove, replacing with the new symbols in lisp.h. All uses changed.
6252 * fileio.c (make_temp_name):
6253 * filelock.c (lock_file_1, lock_file):
6254 * xdisp.c (message_dolog):
6255 Don't assume PRIdMAX etc. works; this isn't portable to pre-C99 hosts.
6256 Use pMd etc. instead.
6257 * lisp.h (printmax_t, uprintmax_t, pMd, pMu): New types and macros,
6258 replacing the pWIDE etc. symbols removed from editfns.c.
6259
3300e6fd
PE
6260 * keyboard.h (num_input_events): Now uintmax_t.
6261 This is (very slightly) less likely to mess up due to wraparound.
6262 All uses changed.
6263
fd05c7e9
PE
6264 * buffer.c: Integer signedness fixes.
6265 (alloc_buffer_text, enlarge_buffer_text):
6266 Use ptrdiff_t rather than size_t when either will do, as we prefer
6267 signed integers.
6268
903fe15d
PE
6269 * alloc.c: Integer signedness and overflow fixes.
6270 Do not impose an arbitrary 32-bit limit on malloc sizes when debugging.
6271 (__malloc_size_t): Default to size_t, not to int.
6272 (pure_size, pure_bytes_used_before_overflow, stack_copy_size)
6273 (Fgarbage_collect, mark_object_loop_halt, mark_object):
6274 Prefer ptrdiff_t to size_t when either would do, as we prefer
6275 signed integers.
6276 (XMALLOC_OVERRUN_CHECK_OVERHEAD): New macro.
6277 (xmalloc_overrun_check_header, xmalloc_overrun_check_trailer):
6278 Now const. Initialize with values that are in range even if char
6279 is signed.
6280 (XMALLOC_PUT_SIZE, XMALLOC_GET_SIZE): Remove, replacing with ...
6281 (xmalloc_put_size, xmalloc_get_size): New functions. All uses changed.
6282 These functions do the right thing with sizes > 2**32.
6283 (check_depth): Now ptrdiff_t, not int.
6284 (overrun_check_malloc, overrun_check_realloc, overrun_check_free):
6285 Adjust to new way of storing sizes. Check for size overflow bugs
6286 in rest of code.
6287 (STRING_BYTES_MAX): Adjust to new overheads. The old code was
6288 slightly wrong anyway, as it missed one instance of
6289 XMALLOC_OVERRUN_CHECK_OVERHEAD.
6290 (refill_memory_reserve): Omit needless cast to size_t.
6291 (mark_object_loop_halt): Mark as externally visible.
6292
ac82cc6a
PE
6293 * xselect.c: Integer signedness and overflow fixes.
6294 (Fx_register_dnd_atom, x_handle_dnd_message):
6295 Use ptrdiff_t, not size_t, since we prefer signed.
6296 (Fx_register_dnd_atom): Check for ptrdiff_t (and size_t) overflow.
6297 * xterm.h (struct x_display_info): Use ptrdiff_t, not size_t, for
6298 x_dnd_atoms_size and x_dnd_atoms_length.
6299
c2d1e36d
PE
6300 * doprnt.c: Prefer signed to unsigned when either works.
6301 * eval.c (verror):
6302 * doprnt.c (doprnt):
6303 * lisp.h (doprnt):
6304 * xdisp.c (vmessage):
6305 Use ptrdiff_t, not size_t, when using or implementing doprnt,
6306 since the sizes cannot exceed ptrdiff_t bounds anyway, and we
6307 prefer signed arithmetic to avoid comparison confusion.
6308 * doprnt.c (doprnt): Avoid a "+ 1" that can't overflow,
6309 but is a bit tricky.
6310
0e926e56
PE
6311 Assume freestanding C89 headers, string.h, stdlib.h.
6312 * data.c, doprnt.c, floatfns.c, print.c:
6313 Include float.h unconditionally.
6314 * gmalloc.c: Assume C89-at-least behavior for preprocessor,
6315 limits.h, stddef.h, string.h. Use memset instead of 'flood'.
6316 * regex.c: Likewise for stddef.h, string.h.
6317 (ISASCII): Remove; can assume it returns 1 now. All uses removed.
6318 * s/aix4-2.h (HAVE_STRING_H): Remove obsolete undef.
6319 * s/ms-w32.h (HAVE_LIMITS_H, HAVE_STRING_H, HAVE_STDLIB_H)
6320 (STDC_HEADERS): Remove obsolete defines.
6321 * sysdep.c: Include limits.h unconditionally.
6322
9cfdb3ec
PE
6323 Assume support for memcmp, memcpy, memmove, memset.
6324 * lisp.h, sysdep.c (memcmp, memcpy, memmove, memset):
6325 * regex.c (memcmp, memcpy):
6326 Remove; we assume C89 now.
6327
6328 * gmalloc.c (memcpy, memset, memmove): Remove; we assume C89 now.
6329 (__malloc_safe_bcopy): Remove; no longer needed.
6330
cf950e6b 6331 * lisp.h (struct vectorlike_header, struct Lisp_Subr): Signed sizes.
6089c567
PE
6332 Use EMACS_INT, not EMACS_UINT, for sizes. The code works equally
6333 well either way, and we prefer signed to unsigned.
6334
dbf38e02
LMI
63352011-07-27 Lars Magne Ingebrigtsen <larsi@gnus.org>
6336
6337 * gnutls.c (emacs_gnutls_read): Don't message anything if the peer
6338 closes the connection while we're reading (bug#9182).
6339
d6f0886c 63402011-07-25 Jan Djärv <jan.h.d@swipnet.se>
24e0f6b1 6341
d6f0886c
JD
6342 * nsmenu.m (ns_popup_dialog): Add an "ok" button if no buttons
6343 are specified (Bug#9168).
24e0f6b1 6344
2eb1f9e6
PE
63452011-07-25 Paul Eggert <eggert@cs.ucla.edu>
6346
6347 * bidi.c (bidi_dump_cached_states): Fix printf format mismatch.
6348 Found by GCC static checking and --with-wide-int on a 32-bit host.
6349
22381272 63502011-07-25 Eli Zaretskii <eliz@gnu.org>
7daee910
EZ
6351
6352 * xdisp.c (compute_display_string_pos): Fix logic of caching
6353 previous display string position. Initialize cached_prev_pos to
6354 -1. Fixes slow-down at the beginning of a buffer.
6355
f25e39b4
EZ
63562011-07-24 Eli Zaretskii <eliz@gnu.org>
6357
6358 * xfaces.c (check_lface_attrs) [HAVE_WINDOW_SYSTEM]: Allow `nil'
6359 for attrs[LFACE_FONTSET_INDEX].
6360
04c4b52e
PE
63612011-07-23 Paul Eggert <eggert@cs.ucla.edu>
6362
6363 * xml.c (parse_region): Remove unused local
6364 that was recently introduced.
6365
c1734fbd
EZ
63662011-07-23 Eli Zaretskii <eliz@gnu.org>
6367
be18c5a5
EZ
6368 * xfns.c (unwind_create_frame) [GLYPH_DEBUG]: Adapt to changes in
6369 2008-02-22T17:42:09Z!monnier@iro.umontreal.ca.
6370
c1734fbd
EZ
6371 * xdisp.c (move_it_in_display_line_to): Record the best matching
6372 position for TO_CHARPOS while scanning the line, and restore it on
640c8776
SM
6373 exit if none of the characters scanned was an exact match.
6374 Fixes vertical-motion and pos-visible-in-window-p under bidi redisplay
a9269c18
EZ
6375 when exact match is impossible due to invisible text, and the
6376 lines are truncated.
6377
a258d627
JD
63782011-07-23 Jan Djärv <jan.h.d@swipnet.se>
6379
6380 * nsterm.m (initFrameFromEmacs): Set NSTitledWindowMask in styleMask
6381 for OSX >= 10.7.
6382
b6d5a689
EZ
63832011-07-22 Eli Zaretskii <eliz@gnu.org>
6384
0f74f785
EZ
6385 Fix a significant slow-down of cursor motion with C-n, C-p,
6386 C-f/C-b, and C-v/M-v that couldn't keep up with keyboard
6387 auto-repeat under bidi redisplay in fontified buffers.
b6d5a689 6388 * xdisp.c (compute_stop_pos_backwards): New function.
b6d5a689
EZ
6389 (next_element_from_buffer): Call compute_stop_pos_backwards to
6390 find a suitable prev_stop when we find ourselves before
0f74f785
EZ
6391 base_level_stop.
6392 (reseat): Don't look for prev_stop, as that could mean a very long
6393 run.
6394 <cached_disp_pos, cached_disp_buffer, cached_disp_modiff>
6395 <cached_disp_overlay_modiff>: Cache for last found display string
6396 position.
551918c1 6397 (compute_display_string_pos): Return the cached position if asked
0f74f785
EZ
6398 about the same buffer in the same area of character positions, and
6399 the buffer wasn't changed since the time the display string
6400 position was cached.
551918c1 6401
b2d0c91a
EZ
64022011-07-22 Eli Zaretskii <eliz@gnu.org>
6403
6404 * xdisp.c (rows_from_pos_range): Don't ignore glyphs whose object
6405 is an integer, which is important for empty lines. (Bug#9149)
6406
043604ee
CY
64072011-07-22 Chong Yidong <cyd@stupidchicken.com>
6408
6409 * frame.c (Fmodify_frame_parameters): In tty case, update the
6410 default face if necessary (Bug#4238).
6411
da4adb04
CY
64122011-07-21 Chong Yidong <cyd@stupidchicken.com>
6413
6414 * editfns.c (Fstring_to_char): No need to explain what a character
6415 is in the docstring (Bug#6576).
6416
9abd0532
LMI
64172011-07-20 Lars Magne Ingebrigtsen <larsi@gnus.org>
6418
6419 * xml.c (parse_region): Make sure we always return a tree.
6420
36881d16
HK
64212011-07-20 HAMANO Kiyoto <khiker.mail@gmail.com>
6422
6423 * xml.c (parse_region): If a document contains only comments,
6424 return that, too.
6425
1e98674d
LMI
64262011-07-20 Lars Magne Ingebrigtsen <larsi@gnus.org>
6427
6428 * xml.c (make_dom): Return comments, too.
6429
590bd467
PE
64302011-07-19 Paul Eggert <eggert@cs.ucla.edu>
6431
6432 Port to OpenBSD.
6433 See http://lists.gnu.org/archive/html/emacs-devel/2011-07/msg00688.html
6434 and the surrounding thread.
6435 * minibuf.c (read_minibuf_noninteractive): Rewrite to use getchar
6436 rather than fgets, and retry after EINTR. Otherwise, 'emacs
6437 --batch -f byte-compile-file' fails on OpenBSD if an inactivity
6438 timer goes off.
6439 * s/openbsd.h (BROKEN_SIGIO): Define.
6440 * unexelf.c (unexec) [__OpenBSD__]:
6441 Don't update the .mdebug section of the Alpha COFF symbol table.
6442
f41628b2
LMI
64432011-07-19 Lars Magne Ingebrigtsen <larsi@gnus.org>
6444
6445 * lread.c (syms_of_lread): Clarify when `lexical-binding' is used
6446 (bug#8460).
6447
b59b67c5
PE
64482011-07-18 Paul Eggert <eggert@cs.ucla.edu>
6449
15e3a074
PE
6450 * fileio.c (Fcopy_file) [!MSDOS]: Tighten created file's mask.
6451 This fixes some race conditions on the permissions of any newly
6452 created file.
6453
41bed37d
PE
6454 * alloc.c (valid_pointer_p): Use pipe, not open.
6455 This fixes some permissions issues when debugging.
6456
b59b67c5
PE
6457 * fileio.c (Fcopy_file): Adjust mode if fchown fails. (Bug#9002)
6458 If fchown fails to set both uid and gid, try to set just gid,
6459 as that is sometimes allowed. Adjust the file's mode to eliminate
6460 setuid or setgid bits that are inappropriate if fchown fails.
6461
925a6be7
SM
64622011-07-18 Stefan Monnier <monnier@iro.umontreal.ca>
6463
6464 * xdisp.c (next_element_from_string, next_element_from_buffer): Use EQ
6465 to compare Lisp_Objects.
6466 * gnutls.c (syms_of_gnutls): Rename Vgnutls_log_level to
6467 global_gnutls_log_level, don't mistake it for a Lisp_Object.
6468 (init_gnutls_functions, emacs_gnutls_handle_error): Fix up uses.
6469
52968808
AS
64702011-07-17 Andreas Schwab <schwab@linux-m68k.org>
6471
0a6a104b
AS
6472 * lread.c (read_integer): Unread even EOF character.
6473 (read1): Likewise. Properly record start position of symbol.
6474
52968808
AS
6475 * lread.c (read1): Read `#:' as empty uninterned symbol if no
6476 symbol character follows.
6477
9e381cdd
PE
64782011-07-17 Paul Eggert <eggert@cs.ucla.edu>
6479
6480 * fileio.c (Fcopy_file): Pacify gcc re fchown. (Bug#9002)
6481 This works around a problem with the previous change to Fcopy_file.
6482 Recent glibc declares fchown with __attribute__((warn_unused_result)),
6483 and without this change, GCC might complain about discarding
6484 fchown's return value.
6485
b5641435
JB
64862011-07-16 Juanma Barranquero <lekktu@gmail.com>
6487
6488 * makefile.w32-in (GLOBAL_SOURCES): Add gnutls.c (followup to bug#9059).
6489
a8031457
PE
64902011-07-16 Paul Eggert <eggert@cs.ucla.edu>
6491
6492 * fileio.c (Fcopy_file): Don't diagnose fchown failures. (Bug#9002)
6493
dd889327
LMI
64942011-07-16 Lars Magne Ingebrigtsen <larsi@gnus.org>
6495
750c33f7
LMI
6496 * gnutls.c (syms_of_gnutls): Define `gnutls-log-level' here, since
6497 it's used from the C level.
6498
dd889327
LMI
6499 * process.c: Use the same condition for POLL_FOR_INPUT in both
6500 keyboard.c and process.c (bug#1858).
6501
87e86684
LM
65022011-07-09 Lawrence Mitchell <wence@gmx.li>
6503
6504 * gnutls.c (Qgnutls_bootprop_min_prime_bits): New variable.
6505 (Fgnutls_boot): Use it.
6506
64348f40
AS
65072011-07-15 Andreas Schwab <schwab@linux-m68k.org>
6508
6509 * doc.c (Fsubstitute_command_keys): Revert last change.
6510
1d698799
LMI
65112011-07-15 Lars Magne Ingebrigtsen <larsi@gnus.org>
6512
f863868c
LMI
6513 * doc.c (Fsubstitute_command_keys): Clarify that \= really only
6514 quotes the next character, and doesn't affect other longer
6515 sequences (bug#8935).
6516
1d698799
LMI
6517 * lread.c (syms_of_lread): Clarify that is isn't only
6518 `eval-buffer' and `eval-defun' that's affected by
6519 `lexical-binding' (bug#8460).
6520
aa4b6df6
EZ
65212011-07-15 Eli Zaretskii <eliz@gnu.org>
6522
6523 * xdisp.c (move_it_in_display_line_to): Fix vertical motion with
6b02f655 6524 bidi redisplay when a line includes both an image and is truncated.
aa4b6df6 6525
5d856da6
PE
65262011-07-14 Paul Eggert <eggert@cs.ucla.edu>
6527
ad6042bb
PE
6528 Fix minor problems found by static checking.
6529 * bidi.c (bidi_cache_size): Now EMACS_INT, not size_t.
6530 (elsz): Now a signed constant, not a size_t var. We prefer signed
6531 types to unsigned, to avoid integer comparison confusion. Without
6532 this change, GCC 4.6.1 with -Wunsafe-loop-optimizations complains
6533 "cannot optimize loop, the loop counter may overflow", a symptom
6534 of the confusion.
f00bbb22 6535 * indent.c (Fvertical_motion): Mark locals as initialized.
5d856da6
PE
6536 * xdisp.c (reseat_to_string): Fix pointer signedness issue.
6537
6468f31c
LMI
65382011-07-14 Lars Magne Ingebrigtsen <larsi@gnus.org>
6539
49080b10
LMI
6540 * search.c (Fre_search_backward): Mention `case-fold-search' in
6541 all the re_search_* functions (bug#8138).
6542
6468f31c
LMI
6543 * keyboard.c (Fopen_dribble_file): Document when the file is
6544 closed (bug#8056).
6545
c965adc5
EZ
65462011-07-14 Eli Zaretskii <eliz@gnu.org>
6547
df9733bf
EZ
6548 * bidi.c (bidi_dump_cached_states): Fix format of displaying
6549 bidi_cache_idx.
6550
0bb23927
EZ
6551 Support bidi reordering of display and overlay strings.
6552 * xdisp.c (compute_display_string_pos)
6553 (compute_display_string_end): Accept additional argument STRING.
6554 (init_iterator, reseat_1): Initialize bidi_it->string.s to NULL.
6555 (reseat_to_string): Initialize bidi_it->string.s and
6556 bidi_it->string.schars.
6557 (Fcurrent_bidi_paragraph_direction): Initialize itb.string.s to
640c8776
SM
6558 NULL (avoids a crash in bidi_paragraph_init).
6559 Initialize itb.string.lstring.
0bb23927
EZ
6560 (init_iterator): Call bidi_init_it only of a valid
6561 buffer position was specified. Initialize paragraph_embedding to
6562 L2R.
6563 (reseat_to_string): Initialize the bidi iterator.
6564 (display_string): If we need to ignore text properties of
6565 LISP_STRING, set IT->stop_charpos to IT->end_charpos. (The
6566 original value of -1 will not work with bidi.)
6567 (compute_display_string_pos): First arg is now struct
6568 `text_pos *'; all callers changed. Support display properties on
6569 Lisp strings.
6570 (compute_display_string_end): Support display properties on Lisp
6571 strings.
6572 (init_iterator, reseat_1, reseat_to_string): Initialize the
6573 string.bufpos member to 0 (zero, for compatibility with IT_CHARPOS
6574 when iterating on a string not from display properties).
640c8776
SM
6575 (compute_display_string_pos, compute_display_string_end):
6576 Fix calculation of the object to scan. Fixes an error when using
0bb23927
EZ
6577 arrow keys.
6578 (next_element_from_buffer): Don't abort when IT_CHARPOS is before
640c8776
SM
6579 base_level_stop; instead, set base_level_stop to BEGV.
6580 Fixes crashes in vertical-motion.
0bb23927
EZ
6581 (next_element_from_buffer): Improve commentary for when
6582 the iterator is before prev_stop.
6583 (init_iterator): Initialize bidi_p from the default value of
6584 bidi-display-reordering, not from buffer-local value. Use the
6585 buffer-local value only if initializing for buffer iteration.
6586 (handle_invisible_prop): Support invisible properties on strings
6587 that are being bidi-reordered.
6588 (set_iterator_to_next): Support bidi reordering of C strings and
6589 Lisp strings.
6590 (next_element_from_string): Support bidi reordering of Lisp
6591 strings.
6592 (handle_stop_backwards): Support Lisp strings as well.
640c8776
SM
6593 (display_string): Support display of R2L glyph rows.
6594 Use IT_STRING_CHARPOS when displaying from a Lisp string.
0bb23927
EZ
6595 (init_iterator): Don't initialize it->bidi_p for strings
6596 here.
6597 (reseat_to_string): Initialize it->bidi_p for strings here.
6598 (next_element_from_string, next_element_from_c_string)
6599 (next_element_from_buffer): Add xassert's for correspondence
6600 between IT's object being iterated and it->bidi_it.string
6601 structure.
6602 (face_before_or_after_it_pos): Support bidi iteration.
6603 (next_element_from_c_string): Handle the case of the first string
6604 character that is not the first one in the visual order.
6605 (get_visually_first_element): New function, refactored from common
6606 parts of next_element_from_buffer, next_element_from_string, and
6607 next_element_from_c_string.
6608 (tool_bar_lines_needed, redisplay_tool_bar)
6609 (display_menu_bar): Force left-to-right direction. Add a FIXME
6610 comment for making that be controlled by a user option.
6611 (push_it, pop_it): Save and restore the state of the
6612 bidi iterator. Save and restore the bidi_p flag.
6613 (pop_it): Iterate out of display property for string iteration as
6614 well.
6615 (iterate_out_of_display_property): Support iteration over strings.
6616 (handle_single_display_spec): Set up it->bidi_it for iteration
6617 over a display string, and call bidi_init_it.
6618 (handle_single_display_spec, next_overlay_string)
6619 (get_overlay_strings_1, push_display_prop): Set up the bidi
6620 iterator for displaying display or overlay strings.
6621 (forward_to_next_line_start): Don't use the shortcut if
6622 bidi-iterating.
6623 (back_to_previous_visible_line_start): If handle_display_prop
6624 pushed the iterator stack, restore the internal state of the bidi
6625 iterator by calling bidi_pop_it same number of times.
6626 (reseat_at_next_visible_line_start): If ON_NEWLINE_P is non-zero,
6627 and we are bidi-iterating, don't decrement the iterator position;
6628 instead, set the first_elt flag in the bidi iterator, to produce
6629 the same effect.
6630 (reseat_1): Remove redundant setting of string_from_display_prop_p.
6631 (push_display_prop): xassert that we are iterating a buffer.
6632 (push_it, pop_it): Save and restore paragraph_embedding member.
6633 (handle_single_display_spec, next_overlay_string)
6634 (get_overlay_strings_1, reseat_1, reseat_to_string)
6635 (push_display_prop): Set up the `unibyte' member of bidi_it.string
6636 correctly. Don't assume unibyte strings are not bidi-reordered.
6637 (compute_display_string_pos)
6638 (compute_display_string_end): Fix handling the case of C string.
6639 (push_it, pop_it): Save and restore from_disp_prop_p.
6640 (handle_single_display_spec, push_display_prop): Set the
6641 from_disp_prop_p flag.
6642 (get_overlay_strings_1): Reset the from_disp_prop_p flag.
6643 (pop_it): Call iterate_out_of_display_property only if we are
6644 popping after iteration over a string that came from a display
6645 property. Fix a typo in popping stretch info. Add an assertion
6646 for verifying that the iterator position is in sync with the bidi
6647 iterator.
6648 (handle_single_display_spec, get_overlay_strings_1)
6649 (push_display_prop): Fix initialization of paragraph direction for
6650 string when that of the parent object is not yet determined.
6651 (reseat_1): Call bidi_init_it to resync the bidi
6652 iterator with IT's position. (Bug#7616)
6653 (find_row_edges): If ROW->start.pos gives position
6654 smaller than min_pos, use it as ROW->minpos. (Bug#7616)
6655 (handle_stop, back_to_previous_visible_line_start, reseat_1):
6656 Reset the from_disp_prop_p flag.
6657 (SAVE_IT, RESTORE_IT): New macros.
6658 (pos_visible_p, face_before_or_after_it_pos)
6659 (back_to_previous_visible_line_start)
6660 (move_it_in_display_line_to, move_it_in_display_line)
6661 (move_it_to, move_it_vertically_backward, move_it_by_lines)
6662 (try_scrolling, redisplay_window, display_line): Use them when
6663 saving a temporary copy of the iterator and restoring it back.
6664 (back_to_previous_visible_line_start, reseat_1)
6665 (init_iterator): Empty the bidi cache "stack".
6666 (move_it_in_display_line_to): If iterator ended up at
6667 EOL, but we never saw any buffer positions smaller than
6668 to_charpos, return MOVE_POS_MATCH_OR_ZV. Fixes vertical cursor
6669 motion in bidi-reordered lines.
6670 (move_it_in_display_line_to): Record prev_method and prev_pos
6671 immediately before the call to set_iterator_to_next. Fixes cursor
6672 motion in bidi-reordered lines with stretch glyphs and strings
6673 displayed in margins. (Bug#8133) (Bug#8867)
6674 Return MOVE_POS_MATCH_OR_ZV only if iterator position is past
6675 TO_CHARPOS.
640c8776
SM
6676 (pos_visible_p): Support positions in bidi-reordered lines.
6677 Save and restore bidi cache.
0bb23927
EZ
6678
6679 * bidi.c (bidi_level_of_next_char): clen should be EMACS_NT, not int.
6680 (bidi_paragraph_info): Delete unused struct.
6681 (bidi_cache_idx, bidi_cache_last_idx): Declare EMACS_INT.
6682 (bidi_cache_start): New variable.
6683 (bidi_cache_reset): Reset bidi_cache_idx to bidi_cache_start, not
6684 to zero.
6685 (bidi_cache_fetch_state, bidi_cache_search)
6686 (bidi_cache_find_level_change, bidi_cache_iterator_state)
6687 (bidi_cache_find, bidi_peek_at_next_level)
6688 (bidi_level_of_next_char, bidi_find_other_level_edge)
6689 (bidi_move_to_visually_next): Compare cache index with
6690 bidi_cache_start rather than with zero.
6691 (bidi_fetch_char): Accept new argument STRING; all callers
6692 changed. Support iteration over a string. Support strings with
6693 display properties. Support unibyte strings. Fix the type of
6694 `len' according to what STRING_CHAR_AND_LENGTH expects.
6695 (bidi_paragraph_init, bidi_resolve_explicit_1)
6696 (bidi_resolve_explicit, bidi_resolve_weak)
640c8776
SM
6697 (bidi_level_of_next_char, bidi_move_to_visually_next):
6698 Support iteration over a string.
0bb23927
EZ
6699 (bidi_set_sor_type, bidi_resolve_explicit_1)
6700 (bidi_resolve_explicit, bidi_type_of_next_char): ignore_bn_limit
6701 can now be zero (for strings); special values 0 and -1 were
6702 changed to -1 and -2, respectively.
6703 (bidi_char_at_pos): New function.
6704 (bidi_paragraph_init, bidi_resolve_explicit, bidi_resolve_weak):
6705 Call it instead of FETCH_MULTIBYTE_CHAR.
6706 (bidi_move_to_visually_next): Abort if charpos or bytepos were not
6707 initialized to valid values.
6708 (bidi_init_it): Don't initialize charpos and bytepos with invalid
6709 values.
6710 (bidi_level_of_next_char): Allow the sentinel "position" to pass
6711 the test for valid cached positions. Fix the logic for looking up
6712 the sentinel state in the cache. GCPRO the Lisp string we are
6713 iterating.
6714 (bidi_push_it, bidi_pop_it): New functions.
6715 (bidi_initialize): Initialize the bidi cache start stack pointer.
6716 (bidi_cache_ensure_space): New function, refactored from part of
6717 bidi_cache_iterator_state. Don't assume the required size is just
6718 one BIDI_CACHE_CHUNK away.
6719 (bidi_cache_start_stack, bidi_push_it): Use IT_STACK_SIZE.
6720 (bidi_count_bytes, bidi_char_at_pos): New functions.
6721 (bidi_cache_search): Don't assume bidi_cache_last_idx is
6722 always valid if bidi_cache_idx is valid.
6723 (bidi_cache_find_level_change): xassert that bidi_cache_last_idx
6724 is valid if it's going to be used.
6725 (bidi_shelve_cache, bidi_unshelve_cache): New functions.
6726 (bidi_cache_fetch_state, bidi_cache_search)
c965adc5
EZ
6727 (bidi_cache_find_level_change, bidi_cache_ensure_space)
6728 (bidi_cache_iterator_state, bidi_cache_find)
640c8776
SM
6729 (bidi_find_other_level_edge, bidi_cache_start_stack):
6730 All variables related to cache indices are now EMACS_INT.
c965adc5 6731
0bb23927
EZ
6732 * dispextern.h (struct bidi_string_data): New structure.
6733 (struct bidi_it): New member `string'. Make flag members be 1-bit
6734 fields, and put them last in the struct.
640c8776
SM
6735 (compute_display_string_pos, compute_display_string_end):
6736 Update prototypes.
0bb23927
EZ
6737 (bidi_push_it, bidi_pop_it): Add prototypes.
6738 (struct iterator_stack_entry): New members bidi_p,
6739 paragraph_embedding, and from_disp_prop_p.
6740 (struct it): Member bidi_p is now a bit field 1 bit wide.
640c8776
SM
6741 (bidi_shelve_cache, bidi_unshelve_cache):
6742 Declare prototypes.
0bb23927
EZ
6743
6744 * .gdbinit (xvectype, xvector, xcompiled, xchartable, xboolvector)
6745 (xpr, xfont, xbacktrace): Use "header.size" when accessing vectors
6746 and vector-like objects.
6747
6748 * dispnew.c (buffer_posn_from_coords): Save and restore the bidi
6749 cache around display iteration.
6750
6751 * window.c (Fwindow_end, window_scroll_pixel_based)
6752 (displayed_window_lines, Frecenter): Save and restore the bidi
6753 cache around display iteration.
6754
3bbd2265
LMI
67552011-07-14 Lars Magne Ingebrigtsen <larsi@gnus.org>
6756
6757 * editfns.c (Fdelete_region): Clarify the use of the named
6758 parameters (bug#6788).
6759
adc47434
MR
67602011-07-14 Martin Rudalics <rudalics@gmx.at>
6761
6762 * indent.c (Fvertical_motion): Set and restore w->pointm when
6763 saving and restoring the window's buffer (Bug#9006).
6764
837c31f8
LMI
67652011-07-13 Lars Magne Ingebrigtsen <larsi@gnus.org>
6766
6767 * editfns.c (Fstring_to_char): Clarify just what is returned
6768 (bug#6576). Text by Eli Zaretskii.
6769
ac389d0c
JB
67702011-07-13 Juanma Barranquero <lekktu@gmail.com>
6771
6772 * gnutls.c (init_gnutls_functions): Honor gnutls_log_level (bug#9059).
6773
0be0ce47
EZ
67742011-07-13 Eli Zaretskii <eliz@gnu.org>
6775
6776 * buffer.c (mmap_find): Fix a typo.
6777
cd18e7e3
JB
67782011-07-13 Johan Bockgård <bojohan@gnu.org>
6779
6780 Fix execution of x selection hooks.
6781 * xselect.c (Qx_lost_selection_functions)
6782 (Qx_sent_selection_functions): New vars.
6783 (syms_of_xselect): DEFSYM them.
6784 (x_handle_selection_request): Pass Qx_sent_selection_functions
6785 rather than Vx_sent_selection_functions to Frun_hook_with_args.
6786 (x_handle_selection_clear,x_clear_frame_selections):
6787 Pass Qx_lost_selection_functions rather than
6788 Vx_lost_selection_functions to Frun_hook_with_args.
6789
47ea7f44
PE
67902011-07-13 Paul Eggert <eggert@cs.ucla.edu>
6791
ac389d0c 6792 * buffer.c (Fget_buffer_create): Initialize inhibit_shrinking.
2941c447
PE
6793 The old code sometimes used this field without initializing it.
6794
47ea7f44
PE
6795 * alloc.c (gc_sweep): Don't read past end of array.
6796 In theory, the old code could also have corrupted Emacs internals,
6797 though it'd be very unlikely.
6798
bc985c87
AS
67992011-07-12 Andreas Schwab <schwab@linux-m68k.org>
6800
6801 * character.c (Fcharacterp): Don't advertise optional ignored
ac389d0c 6802 argument. (Bug#4026)
bc985c87 6803
0cf34688
LMI
68042011-07-12 Lars Magne Ingebrigtsen <larsi@gnus.org>
6805
b3dadd76
LMI
6806 * keymap.c (syms_of_keymap): Clarify that "modifier" is "modifier
6807 key" (bug#4257).
6808
0cf34688
LMI
6809 * window.c (Fset_window_start): Doc fix (bug#4199).
6810 (Fset_window_hscroll): Ditto.
6811
270768cd
PE
68122011-07-12 Paul Eggert <eggert@cs.ucla.edu>
6813
077e3dda 6814 Fix minor new problems caught by GCC 4.6.1.
270768cd 6815 * term.c (init_tty): Remove unused local.
490011a6 6816 * xsettings.c (store_monospaced_changed): Define this function only
077e3dda 6817 if (defined HAVE_GSETTINGS || defined HAVE_GCONF), as it's
490011a6 6818 not used otherwise.
270768cd 6819
b1f58454
CY
68202011-07-12 Chong Yidong <cyd@stupidchicken.com>
6821
6822 * xdisp.c (Vresize_mini_windows): Minor doc fix (Bug#3300).
6823
22b9578d
LMI
68242011-07-11 Lars Magne Ingebrigtsen <larsi@gnus.org>
6825
6e70ab07
LMI
6826 * xdisp.c (syms_of_xdisp): Make it explicit that the mini-windows
6827 are the mini-buffer and the echo area (bug#3320).
6828
22b9578d
LMI
6829 * term.c (init_tty): Remove support for supdup, c10 and perq
6830 terminals, which are no longer supported (bug#1482).
6831
8974cc9f
JB
68322011-07-10 Johan Bockgård <bojohan@gnu.org>
6833
6834 * xdisp.c (Ftool_bar_lines_needed): Fix WINDOWP check.
6835
a560d974
JD
68362011-07-10 Jan Djärv <jan.h.d@swipnet.se>
6837
6838 * xmenu.c (menu_highlight_callback): Only pass frame to show_help_event
6839 for non-popups (Bug#3642).
6840
1dae0f0a
AS
68412011-07-10 Andreas Schwab <schwab@linux-m68k.org>
6842
268c2c36 6843 * alloc.c (reset_malloc_hooks): Protoize.
1dae0f0a 6844 * buffer.c (mmap_init, mmap_find, mmap_free_1, mmap_enlarge)
268c2c36
AS
6845 (mmap_set_vars, mmap_alloc, mmap_free, mmap_realloc): Likewise.
6846 * cm.c (losecursor): Likewise.
1dae0f0a
AS
6847 * data.c (fmod): Likewise.
6848 * dispnew.c (swap_glyphs_in_rows): Likewise.
6849 * emacs.c (memory_warning_signal): Likewise.
6850 * floatfns.c (float_error): Likewise.
6851 * font.c (check_gstring, check_otf_features, otf_tag_symbol)
6852 (otf_open, font_otf_capability, generate_otf_features)
6853 (font_otf_DeviceTable, font_otf_ValueRecord, font_otf_Anchor):
6854 Likewise.
6855 * image.c (pbm_read_file): Likewise.
6856 * indent.c (string_display_width): Likewise.
6857 * intervals.c (check_for_interval, search_for_interval)
6858 (inc_interval_count, count_intervals, root_interval)
6859 (adjust_intervals_for_insertion, make_new_interval): Likewise.
6860 * lread.c (defalias): Likewise.
268c2c36 6861 * ralloc.c (r_alloc_check): Likewise.
1dae0f0a
AS
6862 * regex.c (set_image_of_range_1, set_image_of_range)
6863 (regex_grow_registers): Likewise.
6864 * sysdep.c (strerror): Likewise.
6865 * termcap.c (valid_filename_p, tprint, main): Likewise.
6866 * tparam.c (main): Likewise.
6867 * unexhp9k800.c (run_time_remap, save_data_space)
6868 (update_file_ptrs, read_header, write_header, calculate_checksum)
6869 (copy_file, copy_rest, display_header): Likewise.
6870 * widget.c (mark_shell_size_user_specified, create_frame_gcs):
6871 Likewise.
6872 * xdisp.c (check_it): Likewise.
6873 * xfaces.c (register_color, unregister_color, unregister_colors):
6874 Likewise.
6875 * xfns.c (print_fontset_result): Likewise.
6876 * xrdb.c (member, fatal, main): Likewise.
6877
99033785
PE
68782011-07-10 Paul Eggert <eggert@cs.ucla.edu>
6879
6880 Fix minor problems found by static checking (Bug#9031).
6881 * chartab.c (char_table_set_range, map_sub_char_table):
6882 Remove unused locals.
6883 (uniprop_table): Now static.
6884 * composite.c (_work_char): Remove unused static var.
6885
9cb2ac56
JB
68862011-07-09 Juanma Barranquero <lekktu@gmail.com>
6887
6888 * chartab.c (uniprop_table_uncompress): Remove unused local variable.
6889
f25661f0
JD
68902011-07-09 Jan Djärv <jan.h.d@swipnet.se>
6891
6892 * gtkutil.c (qttip_cb): Remove code without function.
6893
8278c4fe
EZ
68942011-07-09 Eli Zaretskii <eliz@gnu.org>
6895
6896 * w32.c (pthread_sigmask): New stub.
6897
1692ae2d 68982011-07-08 Paul Eggert <eggert@cs.ucla.edu>
123403e4 6899
8a6ebd58 6900 Use pthread_sigmask, not sigprocmask (Bug#9010).
123403e4
PE
6901 sigprocmask is portable only for single-threaded applications, and
6902 Emacs can be multi-threaded when it uses GTK.
1301ac26
PE
6903 * Makefile.in (LIB_PTHREAD_SIGMASK): New macro.
6904 (LIBES): Use it.
6905 * callproc.c (Fcall_process):
6906 * process.c (create_process):
6907 * sysdep.c (sys_sigblock, sys_sigunblock, sys_sigsetmask):
6908 Use pthread_sigmask, not sigprocmask.
123403e4 6909
1b854618
JD
69102011-07-08 Jan Djärv <jan.h.d@swipnet.se>
6911
6912 * gtkutil.c (qttip_cb): Set line wrap to FALSE for tooltip widget.
6913 (xg_prepare_tooltip): Revert text in x->ttip_lbl, margins was
6914 wrong (Bug#8591).
6915
3fe4b549
JD
69162011-07-08 Jan Djärv <jan.h.d@swipnet.se>
6917
0ce7e563
JD
6918 * gtkutil.c (xg_prepare_tooltip): Fix indentation and comment.
6919 Put text in x->ttip_lbl instead of gtk_tooltip_set_text (Bug#8591).
6920 (xg_hide_tooltip): Fix comment.
6921
3fe4b549
JD
6922 * nsterm.m (initFrameFromEmacs): Don't use ns_return_types
6923 in registerServicesMenuSendTypes.
6924 (validRequestorForSendType): Don't check ns_return_types.
6925
6926 * nsfns.m (Fx_open_connection): Put NSStringPboardType into
6927 ns_return_type.
6928
5df75e47
JR
69292011-07-08 Jason Rumney <jasonr@gnu.org>
6930
22610910
JR
6931 * w32term.c (x_make_frame_visible): Use SH_SHOWNORMAL rather than
6932 SH_SHOW for hidden windows (Bug#5482).
6933
5df75e47
JR
6934 * w32fns.c (w32_wnd_proc) [WM_TIMER, WM_SET_CURSOR]: Avoid using
6935 frame struct members of non-existent frames (Bug#6284).
6936
699c10bd
JD
69372011-07-08 Jan Djärv <jan.h.d@swipnet.se>
6938
4393663b
JD
6939 * nsterm.m (keyDown): Call to wantsToDelayTextChangeNotifications and
6940 variable firstTime not needed on OSX >= 10.6.
6941 (setPosition): setFloatValue:knobProportion: is deprecated on OSX
6942 >= 10.5. Use setKnobProportion, setDoubleValue.
6943
6944 * nsterm.h (MAC_OS_X_VERSION_10_3, MAC_OS_X_VERSION_10_4)
6945 (MAC_OS_X_VERSION_10_5): Define if not defined.
6946 (EmacsView, EmacsTooltip): Implements NSWindowDelegate on OSX >= 10.6.
6947 (EmacsMenu): Implements NSMenuDelegate on OSX >= 10.6.
6948 (EmacsToolbar): Implements NSToolbarDelegate on OSX >= 10.6.
6949
6950 * nsselect.m (ns_string_from_pasteboard): Don't use deprecated methods
6951 cString and lossyCString on OSX >= 10.4
6952
58179cce 6953 * nsmenu.m (fillWithWidgetValue): Don't use deprecated method
4393663b
JD
6954 sizeToFit on OSX >= 10.2.
6955
6956 * nsimage.m (allocInitFromFile): Don't use deprecated method
6957 bestRepresentationForDevice on OSX >= 10.6.
6958
6959 * nsfns.m (check_ns_display_info): Cast to long and use %ld in error
6960 to avoid warning.
6961
6962 * emacs.c: Declare unexec_init_emacs_zone.
6963
a63e0781
JD
6964 * nsgui.h: Fix compiler warning about gnulib redefining verify.
6965
699c10bd
JD
6966 * nsselect.m (ns_get_local_selection): Change to extern (Bug#8842).
6967
6968 * nsmenu.m (ns_update_menubar): Remove useless setDelegate call
6969 on svcsMenu (Bug#8842).
6970
6971 * nsfns.m (Fx_open_connection): Remove NSStringPboardType from
6972 ns_return_types.
6973 (Fns_list_services): Just return Qnil on 10.6, code not working there.
6974
6975 * nsterm.m (QUTF8_STRING): Declare.
6976 (initFrameFromEmacs): Call registerServicesMenuSendTypes.
6977 (validRequestorForSendType): Return type is (id).
6978 Change indexOfObjectIdenticalTo to indexOfObject.
6979 Check if we have local selection before returning self (Bug#8842).
6980 (writeSelectionToPasteboard): Put local selection into paste board
6981 if we have a local selection (Bug#8842).
6982 (syms_of_nsterm): DEFSYM QUTF8_STRING.
6983
6984 * nsterm.h (MAC_OS_X_VERSION_10_6): Define here instead of nsterm.m.
6985 (ns_get_local_selection): Declare.
6986
54e10184
LMI
69872011-07-07 Lars Magne Ingebrigtsen <larsi@gnus.org>
6988
9888ff71
LMI
6989 * keymap.c (describe_map_tree): Don't insert a double newline at
6990 the end of the buffer (bug#1169) and return whether we inserted
6991 something.
6992
54e10184
LMI
6993 * callint.c (Fcall_interactively): Change "reading args" to
6994 "providing args" to try to clarify what it does (bug#1010).
6995
15fa4783
KH
69962011-07-07 Kenichi Handa <handa@m17n.org>
6997
6998 * composite.c (composition_compute_stop_pos): Ignore a static
6999 composition starting before CHARPOS (Bug#8915).
7000
7001 * xdisp.c (handle_composition_prop): Likewise.
7002
a8815b00
EZ
70032011-07-07 Eli Zaretskii <eliz@gnu.org>
7004
7005 * term.c (produce_glyphs) <xassert>: Allow IT_GLYPHLESS in it->what.
7006 (Bug#9015)
7007
ef7b981d 70082011-07-07 Kenichi Handa <handa@m17n.org>
c805dec0
KH
7009
7010 * character.h (unicode_category_t): New enum type.
7011
7012 * chartab.c (uniprop_decoder_t, uniprop_encoder_t): New types.
7013 (Qchar_code_property_table): New variable.
7014 (UNIPROP_TABLE_P, UNIPROP_GET_DECODER)
7015 (UNIPROP_COMPRESSED_FORM_P): New macros.
7016 (char_table_ascii): Uncompress the compressed values.
7017 (sub_char_table_ref): New arg is_uniprop. Callers changed.
7018 Uncompress the compressed values.
ac389d0c 7019 (sub_char_table_ref_and_range): Likewise.
c805dec0
KH
7020 (char_table_ref_and_range): Uncompress the compressed values.
7021 (sub_char_table_set): New arg is_uniprop. Callers changed.
7022 Uncompress the compressed values.
7023 (sub_char_table_set_range): Args changed. Callers changed.
7024 (char_table_set_range): Adjuted for the above change.
7025 (map_sub_char_table): Delete args default_val and parent. Add arg
7026 top. Give decoded values to a Lisp function.
640c8776 7027 (map_char_table): Adjust for the above change. Give decoded
c805dec0
KH
7028 values to a Lisp function. Gcpro more variables.
7029 (uniprop_table_uncompress)
7030 (uniprop_decode_value_run_length): New functions.
7031 (uniprop_decoder, uniprop_decoder_count): New variables.
7032 (uniprop_get_decoder, uniprop_encode_value_character)
7033 (uniprop_encode_value_run_length, uniprop_encode_value_numeric):
7034 New functions.
7035 (uniprop_encoder, uniprop_encoder_count): New variables.
7036 (uniprop_get_encoder, uniprop_table)
7037 (Funicode_property_table_internal, Fget_unicode_property_internal)
7038 (Fput_unicode_property_internal): New functions.
7039 (syms_of_chartab): DEFSYM Qchar_code_property_table, defsubr
7040 Sunicode_property_table_internal, Sget_unicode_property_internal,
5e617bc2 7041 and Sput_unicode_property_internal. Defvar_lisp
c805dec0
KH
7042 char-code-property-alist.
7043
640c8776 7044 * composite.c (CHAR_COMPOSABLE_P): Adjust for the change of
c805dec0
KH
7045 Vunicode_category_table.
7046
640c8776 7047 * font.c (font_range): Adjust for the change of
c805dec0
KH
7048 Vunicode_category_table.
7049
76b397fb
DN
70502011-07-07 Dan Nicolaescu <dann@ics.uci.edu>
7051
7052 * m/iris4d.h: Remove file, move contents ...
7053 * s/irix6-5.h: ... here.
7054
22b4128e
PE
70552011-07-06 Paul Eggert <eggert@cs.ucla.edu>
7056
7057 Remove unportable assumption about struct layout (Bug#8884).
8a5c77bb
PE
7058 * alloc.c (mark_buffer):
7059 * buffer.c (reset_buffer_local_variables, Fbuffer_local_variables)
7060 (clone_per_buffer_values): Don't assume that
22b4128e
PE
7061 sizeof (struct buffer) is a multiple of sizeof (Lisp_Object).
7062 This isn't true in general, and it's particularly not true
7063 if Emacs is configured with --with-wide-int.
7064 * buffer.h (FIRST_FIELD_PER_BUFFER, LAST_FIELD_PER_BUFFER):
7065 New macros, used in the buffer.c change.
7066
869795d6
JD
70672011-07-05 Jan Djärv <jan.h.d@swipnet.se>
7068
7069 * xsettings.c: Use both GConf and GSettings if both are available.
7070 (store_config_changed_event): Add comment.
7071 (dpyinfo_valid, store_font_name_changed, map_tool_bar_style)
7072 (store_tool_bar_style_changed): New functions.
5e617bc2 7073 (store_monospaced_changed): Add comment. Call dpyinfo_valid.
869795d6
JD
7074 (struct xsettings): Move font inside HAVE_XFT.
7075 (GSETTINGS_TOOL_BAR_STYLE, GSETTINGS_FONT_NAME): New defines.
640c8776 7076 (GSETTINGS_MONO_FONT): Rename from SYSTEM_MONO_FONT.
869795d6 7077 Move inside HAVE_XFT.
640c8776 7078 (something_changed_gsettingsCB): Rename from something_changedCB.
869795d6
JD
7079 Check for changes in GSETTINGS_TOOL_BAR_STYLE and GSETTINGS_FONT_NAME
7080 also.
7081 (GCONF_TOOL_BAR_STYLE, GCONF_FONT_NAME): New defines.
5e617bc2 7082 (GCONF_MONO_FONT): Rename from SYSTEM_MONO_FONT. Move inside HAVE_XFT.
640c8776 7083 (something_changed_gconfCB): Rename from something_changedCB.
869795d6
JD
7084 Check for changes in GCONF_TOOL_BAR_STYLE and GCONF_FONT_NAME also.
7085 (parse_settings): Move check for font inside HAVE_XFT.
7086 (read_settings, apply_xft_settings): Add comment.
7087 (read_and_apply_settings): Add comment. Call map_tool_bar_style and
7088 store_tool_bar_style_changed. Move check for font inside HAVE_XFT and
7089 call store_font_name_changed.
7090 (xft_settings_event): Add comment.
7091 (init_gsettings): Add comment. Get values for GSETTINGS_TOOL_BAR_STYLE
7092 and GSETTINGS_FONT_NAME. Move check for fonts within HAVE_XFT.
7093 (init_gconf): Add comment. Get values for GCONF_TOOL_BAR_STYLE
7094 and GCONF_FONT_NAME. Move check for fonts within HAVE_XFT.
7095 (xsettings_initialize): Call init_gsettings last.
640c8776
SM
7096 (xsettings_get_system_font, xsettings_get_system_normal_font):
7097 Add comment.
869795d6 7098
d8ed26bd
PE
70992011-07-05 Paul Eggert <eggert@cs.ucla.edu>
7100
7101 Random fixes. E.g., (random) never returned negative values.
7102 * fns.c (Frandom): Use GET_EMACS_TIME for random seed, and add the
7103 subseconds part to the entropy, as that's a bit more random.
7104 Prefer signed to unsigned, since the signedness doesn't matter and
7105 in general we prefer signed. When given a limit, use a
7106 denominator equal to INTMASK + 1, not to VALMASK + 1, because the
7107 latter isn't right if USE_2_TAGS_FOR_INTS.
7108 * sysdep.c (get_random): Return a value in the range 0..INTMASK,
7109 not 0..VALMASK. Don't discard "excess" bits that random () returns.
7110
cabf1cac
SM
71112011-07-04 Stefan Monnier <monnier@iro.umontreal.ca>
7112
7113 * textprop.c (text_property_stickiness):
7114 Obey Vtext_property_default_nonsticky.
7115 (syms_of_textprop): Add `display' to Vtext_property_default_nonsticky.
7116 * w32fns.c (syms_of_w32fns):
7117 * xfns.c (syms_of_xfns): Don't Add `display' since it's there by default.
7118
6e9b2be9
PE
71192011-07-04 Paul Eggert <eggert@cs.ucla.edu>
7120
7121 * fileio.c (barf_or_query_if_file_exists): Use S_ISDIR.
7122 This is more efficient than Ffile_directory_p and avoids a minor race.
7123
90186c68
LMI
71242011-07-04 Lars Magne Ingebrigtsen <larsi@gnus.org>
7125
7c301272
LMI
7126 * buffer.c (Foverlay_put): Say what the return value is
7127 (bug#7835).
7128
c4f2d8d4
LMI
7129 * fileio.c (barf_or_query_if_file_exists): Check first if the file
7130 is a directory before asking whether to use the file name
7131 (bug#7564).
ad637907
LMI
7132 (barf_or_query_if_file_exists): Make the "File is a directory"
7133 error be more correct.
c4f2d8d4 7134
90186c68
LMI
7135 * fns.c (Frequire): Remove the mention of the .gz files, since
7136 that's installation-specific, but keep the mention of
7137 `get-load-suffixes'.
7138
da64016e
PE
71392011-07-04 Paul Eggert <eggert@cs.ucla.edu>
7140
7141 * editfns.c (Fformat_time_string): Don't assume strlen fits in int.
7142 Report string overflow if the output is too long.
7143
7d47b580
JB
71442011-07-04 Juanma Barranquero <lekktu@gmail.com>
7145
a555cb87
JB
7146 * gnutls.c (Fgnutls_boot): Don't mention :verify-error.
7147 (syms_of_gnutls): Remove duplicate DEFSYM for
7148 Qgnutls_bootprop_verify_hostname_error, an error for
7149 Qgnutls_bootprop_verify_error (which is no longer used).
7150
7d47b580
JB
7151 * eval.c (find_handler_clause): Remove parameters `sig' and `data',
7152 unused since 2011-01-26T20:02:07Z!monnier@iro.umontreal.ca. All callers changed.
7153 Also (re)move comments that are misplaced or no longer relevant.
7154
1e49bfab
LMI
71552011-07-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
7156
7157 * callint.c (Finteractive): Clarify the meaning of "@" (bug#8813).
7158
1485f4c0
CY
71592011-07-03 Chong Yidong <cyd@stupidchicken.com>
7160
7161 * xfaces.c (Finternal_merge_in_global_face): Modify the foreground
7162 and background color parameters if they have been changed.
7163
a9ab721e
LMI
71642011-07-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
7165
7166 * editfns.c (Fformat): Clarify the - and 0 flags (bug#6659).
7167
cf7cff57
PE
71682011-07-03 Paul Eggert <eggert@cs.ucla.edu>
7169
2e13213d
PE
7170 * xsettings.c (SYSTEM_FONT): Define only when used.
7171 No need to define when HAVE_GSETTINGS || !HAVE_XFT.
7172
cf7cff57
PE
7173 * keymap.c (access_keymap_1): Now static.
7174
7a8e04f7
CY
71752011-07-02 Chong Yidong <cyd@stupidchicken.com>
7176
7177 * keyboard.c (command_loop_1): If a down-mouse event is unbound,
7178 leave any prefix arg for the up event (Bug#1586).
7179
61352f62
LMI
71802011-07-02 Lars Magne Ingebrigtsen <larsi@gnus.org>
7181
69bb1ef7
LMI
7182 * lread.c (syms_of_lread): Mention single symbols defined by
7183 `defvar' or `defconst' (bug#7154).
7184
61352f62 7185 * fns.c (Frequire): Mention .el.gz files (bug#7314).
7b3747f9 7186 (Frequire): Mention get-load-suffixes.
61352f62 7187
28545e04
MR
71882011-07-02 Martin Rudalics <rudalics@gmx.at>
7189
7190 * window.h (window): Remove clone_number slot.
7191 * window.c (Fwindow_clone_number, Fset_window_clone_number):
7192 Remove.
7193 (make_parent_window, make_window, saved_window)
7194 (Fset_window_configuration, save_window_save): Don't deal with
7195 clone numbers.
7196 * buffer.c (Qclone_number): Remove declaration.
7197 (sort_overlays, overlay_strings): Don't deal with clone numbers.
7198
3349e122
SM
71992011-07-02 Stefan Monnier <monnier@iro.umontreal.ca>
7200
7201 Add multiple inheritance to keymaps.
7202 * keymap.c (Fmake_composed_keymap): New function.
7203 (Fset_keymap_parent): Simplify.
7204 (fix_submap_inheritance): Remove.
7205 (access_keymap_1): New function extracted from access_keymap to handle
7206 embedded parents and handle lists of maps.
7207 (access_keymap): Use it.
7208 (Fkeymap_prompt, map_keymap_internal, map_keymap, store_in_keymap)
7209 (Fcopy_keymap): Handle embedded parents.
7210 (Fcommand_remapping, define_as_prefix): Simplify.
7211 (Fkey_binding): Simplify.
7212 (syms_of_keymap): Move minibuffer-local-completion-map,
7213 minibuffer-local-filename-completion-map,
7214 minibuffer-local-must-match-map, and
7215 minibuffer-local-filename-must-match-map to Elisp.
7216 (syms_of_keymap): Defsubr make-composed-keymap.
7217 * keyboard.c (menu_bar_items): Use map_keymap_canonical.
7218 (parse_menu_item): Trivial simplification.
7219
3279eb87
GM
72202011-07-01 Glenn Morris <rgm@gnu.org>
7221
7222 * Makefile.in (SETTINGS_LIBS): Fix typo.
7223
4550efdf
KI
72242011-07-01 Kazuhiro Ito <kzhr@d1.dion.ne.jp> (tiny patch)
7225
7226 * coding.c (Fencode_coding_string): Record the last coding system
7227 used, as the function doc string says (bug#8738).
7228
0949d2b6
JD
72292011-07-01 Jan Djärv <jan.h.d@swipnet.se>
7230
7231 * xsettings.c (store_monospaced_changed): Take new font as arg and
7232 check for change against current_mono_font.
7233 (EMACS_TYPE_SETTINGS): Remove this and related defines.
7234 (emacs_settings_constructor, emacs_settings_get_property)
7235 (emacs_settings_set_property, emacs_settings_class_init)
7236 (emacs_settings_init, gsettings_obj): Remove.
7237 (something_changedCB): New function for HAVE_GSETTINGS.
7238 (something_changedCB): HAVE_GCONF: Call store_monospaced_changed
7239 with value as argument.
7240 (init_gsettings): Check that GSETTINGS_SCHEMA exists before calling
7241 g_settings_new (Bug#8967). Do not create gsettings_obj.
9173deec 7242 Remove calls to g_settings_bind. Connect something_changedCB to
0949d2b6
JD
7243 "changed".
7244
7245 * xgselect.c: Add defined (HAVE_GSETTINGS).
7246 (xgselect_initialize): Ditto.
7247
7248 * process.c: Add defined (HAVE_GSETTINGS) for xgselect.h
7249 (wait_reading_process_output): Add defined (HAVE_GSETTINGS) for
7250 xg_select.
7251
bbc6b304
PE
72522011-07-01 Paul Eggert <eggert@cs.ucla.edu>
7253
7254 * eval.c (struct backtrace): Simplify and port the data structure.
7255 Do not assume that "int nargs : BITS_PER_INT - 2;" produces a
7256 signed bit field, as this assumption is not portable and it makes
7257 Emacs crash when compiled with Sun C 5.8 on sparc. Do not use
7258 "char debug_on_exit : 1" as this is not portable either; instead,
7259 use the portable "unsigned int debug_on_exit : 1". Remove unused
7260 member evalargs. Remove obsolete comments about cc bombing out.
7261
9851bfc5
JD
72622011-06-30 Jan Djärv <jan.h.d@swipnet.se>
7263
51bb811f 7264 * xsettings.c: Include glib-object.h, gio/gio.h if HAVE_GSETTINGS.
9851bfc5
JD
7265 Let HAVE_GSETTINGS override HAVE_GCONF.
7266 (store_monospaced_changed): New function.
7267 (EMACS_SETTINGS): A new type derived from GObject to handle
7268 GSettings notifications.
7269 (emacs_settings_constructor, emacs_settings_get_property)
7270 (emacs_settings_set_property, emacs_settings_class_init):
7271 New functions.
7272 (gsettings_client, gsettings_obj): New variables.
7273 (GSETTINGS_SCHEMA): New define.
7274 (something_changedCB): Call store_monospaced_changed.
7275 (init_gsettings): New function.
7276 (xsettings_initialize): Call init_gsettings.
7277 (syms_of_xsettings): Initialize gsettings_client, gsettings_obj
7278 to NULL.
7279
640c8776 7280 * Makefile.in (SETTINGS_CFLAGS, SETTINGS_LIBS): Rename from
9851bfc5
JD
7281 GCONF_CFLAGS/LIBS.
7282
5386012d
MR
72832011-06-29 Martin Rudalics <rudalics@gmx.at>
7284
7285 * window.c (resize_root_window, grow_mini_window)
7286 (shrink_mini_window): Rename Qresize_root_window to
7287 Qwindow_resize_root_window and Qresize_root_window_vertically to
7288 Qwindow_resize_root_window_vertically.
7289
f13e0b08
PE
72902011-06-28 Paul Eggert <eggert@cs.ucla.edu>
7291
7292 * gnutls.c (Qgnutls_bootprop_verify_error): Remove unused var.
7293
94515237
JB
72942011-06-27 Juanma Barranquero <lekktu@gmail.com>
7295
7296 * makefile.w32-in: Redesign dependencies so they reflect more
7297 clearly which files are directly included by each source file,
7298 and not through other includes.
7299
e43b6e43
MR
73002011-06-27 Martin Rudalics <rudalics@gmx.at>
7301
7302 * buffer.c (Qclone_number): Declare static and DEFSYM it.
7303 (sort_overlays, overlay_strings): When an overlay's clone number
7304 matches the window's clone number process the overlay even if
7305 the overlay's window property doesn't match the current window.
7306
d68443dc
MR
7307 * window.c (Fwindow_vchild): Rename to Fwindow_top_child.
7308 (Fwindow_hchild): Rename to Fwindow_left_child.
7309 (Fwindow_next): Rename to Fwindow_next_sibling.
7310 (Fwindow_prev): Rename to Fwindow_prev_sibling.
d615d6d2
MR
7311 (resize_window_check): Rename to window_resize_check.
7312 (resize_window_apply): Rename to window_resize_apply.
7313 (Fresize_window_apply): Rename to Fwindow_resize_apply.
7314 (Fdelete_other_windows_internal, resize_frame_windows)
7315 (Fsplit_window_internal, Fdelete_window_internal)
7316 (grow_mini_window, shrink_mini_window)
7317 (Fresize_mini_window_internal): Fix callers accordingly.
d68443dc 7318
c7e73be5
JD
73192011-06-26 Jan Djärv <jan.h.d@swipnet.se>
7320
7321 * emacsgtkfixed.h: State that this is only used with Gtk+3.
7322 (emacs_fixed_set_min_size): Remove.
7323 (emacs_fixed_new): Take frame as argument.
7324
7325 * emacsgtkfixed.c: State that this is only used with Gtk+3.
7326 (_EmacsFixedPrivate): Remove minwidth/height.
7327 Add struct frame *f.
7328 (emacs_fixed_init): Initialize priv->f.
7329 (get_parent_class, emacs_fixed_set_min_size): Remove.
7330 (emacs_fixed_new): Set priv->f to argument.
7331 (emacs_fixed_get_preferred_width)
7332 (emacs_fixed_get_preferred_height): Use min_width/height from
7333 frames size_hint to set minimum and natural (Bug#8919).
7334 (XSetWMSizeHints, XSetWMNormalHints): Override these functions
7335 and use min_width/height from frames size_hint to set
7336 min_width/height (Bug#8919).
7337
7338 * gtkutil.c (xg_create_frame_widgets): Pass f to emacs_fixed_new.
9173deec
JB
7339 (x_wm_set_size_hint): Remove call to emacs_fixed_set_min_size.
7340 Fix indentation.
c7e73be5 7341
cf99dcf8
EZ
73422011-06-26 Eli Zaretskii <eliz@gnu.org>
7343
7344 * bidi.c (bidi_paragraph_init): Test for ZV_BYTE before calling
7345 bidi_at_paragraph_end, since fast_looking_at doesn't like to be
7346 called at ZV.
7347
029529ac
CY
73482011-06-26 Chong Yidong <cyd@stupidchicken.com>
7349
7350 * process.c (wait_reading_process_output): Bypass select if
7351 waiting for a cell while ignoring keyboard input, and input is
7352 pending. Suggested by Jan Djärv (Bug#8869).
7353
7a7ef429
PE
73542011-06-25 Paul Eggert <eggert@cs.ucla.edu>
7355
7356 Use gnulib's dup2 module instead of rolling our own.
7357 * sysdep.c (dup2) [!HAVE_DUP2]: Remove; gnulib now does this.
7358
11fdef7d 73592011-06-25 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
989b42d2
YM
7360
7361 * dispnew.c (scrolling_window): Before scrolling, turn off a
7362 mouse-highlight in the window being scrolled.
7363
cd3520a4
JB
73642011-06-24 Juanma Barranquero <lekktu@gmail.com>
7365
7366 Move DEFSYM to lisp.h and use everywhere.
7367
7368 * character.h (DEFSYM): Move declaration...
7369 * lisp.h (DEFSYM): ...here.
7370
7371 * gnutls.c:
7372 * minibuf.c:
7373 * w32menu.c:
7374 * w32proc.c:
7375 * w32select.c: Don't include character.h.
7376
7377 * alloc.c (syms_of_alloc):
7378 * buffer.c (syms_of_buffer):
7379 * bytecode.c (syms_of_bytecode):
7380 * callint.c (syms_of_callint):
7381 * casefiddle.c (syms_of_casefiddle):
7382 * casetab.c (init_casetab_once):
7383 * category.c (init_category_once, syms_of_category):
7384 * ccl.c (syms_of_ccl):
7385 * cmds.c (syms_of_cmds):
7386 * composite.c (syms_of_composite):
7387 * dbusbind.c (syms_of_dbusbind):
7388 * dired.c (syms_of_dired):
7389 * dispnew.c (syms_of_display):
7390 * doc.c (syms_of_doc):
7391 * editfns.c (syms_of_editfns):
7392 * emacs.c (syms_of_emacs):
7393 * eval.c (syms_of_eval):
7394 * fileio.c (syms_of_fileio):
7395 * fns.c (syms_of_fns):
7396 * frame.c (syms_of_frame):
7397 * fringe.c (syms_of_fringe):
7398 * insdel.c (syms_of_insdel):
7399 * keymap.c (syms_of_keymap):
7400 * lread.c (init_obarray, syms_of_lread):
7401 * macros.c (syms_of_macros):
7402 * msdos.c (syms_of_msdos):
7403 * print.c (syms_of_print):
7404 * process.c (syms_of_process):
7405 * search.c (syms_of_search):
7406 * sound.c (syms_of_sound):
7407 * syntax.c (init_syntax_once, syms_of_syntax):
7408 * terminal.c (syms_of_terminal):
7409 * textprop.c (syms_of_textprop):
7410 * undo.c (syms_of_undo):
7411 * w32.c (globals_of_w32):
7412 * window.c (syms_of_window):
7413 * xdisp.c (syms_of_xdisp):
7414 * xfaces.c (syms_of_xfaces):
7415 * xfns.c (syms_of_xfns):
7416 * xmenu.c (syms_of_xmenu):
7417 * xsettings.c (syms_of_xsettings):
7418 * xterm.c (syms_of_xterm): Use DEFSYM.
7419
4228cf16
TZ
74202011-06-24 Teodor Zlatanov <tzz@lifelogs.com>
7421
cd3520a4 7422 * gnutls.c (syms_of_gnutls): Use the DEFSYM macro from character.h.
4228cf16 7423
7fcccf1e
PE
74242011-06-23 Paul Eggert <eggert@cs.ucla.edu>
7425
7efb4e0e
PE
7426 Integer and buffer overflow fixes (Bug#8873).
7427
ff5844ad
PE
7428 * print.c (printchar, strout): Check for string overflow.
7429 (PRINTPREPARE, printchar, strout):
7430 Don't set size unless allocation succeeds.
7431
90532f02
PE
7432 * minibuf.c (read_minibuf_noninteractive): Use ptrdiff_t, not int,
7433 for sizes. Check for string overflow more accurately.
7434 Simplify newline removal at end; this suppresses a GCC 4.6.0 warning.
7435
6d84508d
PE
7436 * macros.c: Integer and buffer overflow fixes.
7437 * keyboard.h (struct keyboard.kbd_macro_bufsize):
7438 * macros.c (Fstart_kbd_macro, store_kbd_macro_char):
7439 Use ptrdiff_t, not int, for sizes.
7440 Don't increment bufsize until after realloc succeeds.
7441 Check for size-calculation overflow.
7442 (Fstart_kbd_macro): Use EMACS_INT, not int, for XINT result.
7443
437b2cb4
PE
7444 * lisp.h (DEFVAR_KBOARD): Use offsetof instead of char * finagling.
7445
8b9ac8b4
PE
7446 * lread.c: Integer overflow fixes.
7447 (read_integer): Radix is now EMACS_INT, not int,
7448 to improve quality of diagnostics for out-of-range radices.
7449 Calculate buffer size correctly for out-of-range radices.
7450 (read1): Check for integer overflow in radices, and in
7451 read-circle numbers.
82cb60d3
PE
7452 (read_escape): Avoid int overflow.
7453 (Fload, openp, read_buffer_size, read1)
7454 (substitute_object_recurse, read_vector, read_list, map_obarray):
7455 Use ptrdiff_t, not int, for sizes.
7456 (read1): Use EMACS_INT, not int, for sizes.
20270765 7457 Check for size overflow.
8b9ac8b4 7458
7fcccf1e
PE
7459 * image.c (cache_image): Check for size arithmetic overflow.
7460
bfbbd7e7
PE
7461 * lread.c: Integer overflow issues.
7462 (saved_doc_string_size, saved_doc_string_length)
7463 (prev_saved_doc_string_size, prev_saved_doc_string_length):
7464 Now ptrdiff_t, not int.
7465 (read1): Don't assume doc string length fits in int. Check for
7466 out-of-range doc string lengths.
7467 (read_list): Don't assume file position fits in int.
39019e54 7468 (read_escape): Check for hex character overflow.
bfbbd7e7 7469
4e323265
LL
74702011-06-22 Leo Liu <sdl.web@gmail.com>
7471
7472 * minibuf.c (Fcompleting_read_default, Vcompleting_read_function):
7473 Move to minibuffer.el.
7474
85fece3e
PE
74752011-06-22 Paul Eggert <eggert@cs.ucla.edu>
7476
20b84ce9 7477 Fixes for GLYPH_DEBUG found by GCC 4.6.0 static checking.
85fece3e
PE
7478 The following patches are for when GLYPH_DEBUG && !XASSERT.
7479 * dispextern.h (trace_redisplay_p, dump_glyph_string):
7480 * dispnew.c (flush_stdout):
7481 * xdisp.c (dump_glyph_row, dump_glyph_matrix, dump_glyph):
7482 Mark as externally visible.
7483 * dispnew.c (check_window_matrix_pointers): Now static.
7484 * dispnew.c (window_to_frame_vpos):
7485 * xfns.c (unwind_create_frame):
7486 * xterm.c (x_check_font): Remove unused local.
7487 * scroll.c (CHECK_BOUNDS):
7488 * xfaces.c (cache_fache): Rename local to avoid shadowing.
7489 * xfns.c, w32fns.c (image_cache_refcount, dpyinfo_refcount): Now static.
7490 * xdisp.c (check_window_end): Now a no-op if !XASSERTS.
7491 (debug_first_unchanged_at_end_vpos, debug_last_unchanged_at_beg_vpos)
7492 (debug_dvpos, debug_dy, debug_delta, debug_delta_bytes, debug_end_vpos):
7493 Now static.
7494 (debug_method_add): Use va_list and vsprintf rather than relying
7495 on undefined behavior with wrong number of arguments.
7496 (dump_glyph, dump_glyph_row, Fdump_glyph_matrix):
7497 Don't assume ptrdiff_t and EMACS_INT are the same width as int.
7498 In this code, it's OK to assume C99 behavior for ptrdiff_t formats
7499 since we're not interested in debugging glyphs with old libraries.
7500 * xfaces.c (cache_face): Move debugging code earlier; this pacifies
7501 GCC 4.6.0's static checking.
7502
0766b489
PE
75032011-06-22 Paul Eggert <eggert@cs.ucla.edu>
7504
31fd4b32
PE
7505 Integer overflow and signedness fixes (Bug#8873).
7506 A few related buffer overrun fixes, too.
7507
b79e8648
PE
7508 * font.c (font_score): Use EMACS_INT, not int, to store XINT value.
7509
0766b489
PE
7510 * dispextern.h (struct face.stipple):
7511 * image.c (x_bitmap_height, x_bitmap_width, x_bitmap_pixmap)
7512 (x_bitmap_mask, x_allocate_bitmap_record)
7513 (x_create_bitmap_from_data, x_create_bitmap_from_file)
7514 (x_destroy_bitmap, x_destroy_all_bitmaps, x_create_bitmap_mask)
7515 (x_create_bitmap_from_xpm_data):
7516 * nsterm.h (struct ns_display_info.bitmaps_size, .bitmaps_last):
7517 * w32term.h (struct w32_display_info.icon_bitmap_id, .bitmaps_size)
7518 (.bitmaps_last):
7519 * xfaces.c (load_pixmap):
7520 * xterm.c (x_bitmap_icon, x_wm_set_icon_pixmap):
7521 * xterm.h (struct x_display_info.icon_bitmap_id, .bitmaps_size)
7522 (.bitmaps_last, struct x_output.icon_bitmap):
7523 Use ptrdiff_t, not int, for bitmap indexes.
7524 (x_allocate_bitmap_record): Check for size overflow.
7525 * dispextern.h, lisp.h: Adjust to API changes elsewhere.
7526
b081724f
PE
7527 Use ptrdiff_t, not int, for overlay counts.
7528 * buffer.h (overlays_at, sort_overlays, GET_OVERLAYS_AT):
7529 * editfns.c (overlays_around, get_pos_property):
7530 * textprop.c (get_char_property_and_overlay):
7531 * xdisp.c (next_overlay_change, note_mouse_highlight):
7532 * xfaces.c (face_at_buffer_position):
21514da7
PE
7533 * buffer.c (OVERLAY_COUNT_MAX): New macro.
7534 (overlays_at, overlays_in, sort_overlays, Foverlays_at)
7535 (Fnext_overlay_change, Fprevious_overlay_change)
7536 (mouse_face_overlay_overlaps, Foverlays_in):
b081724f 7537 Use ptrdiff_t, not int, for sizes.
21514da7 7538 (overlays_at, overlays_in): Check for size-calculation overflow.
b081724f 7539
3de73e5e
PE
7540 * xterm.c (xim_initialize, same_x_server): Strlen may not fit in int.
7541
2606c57b
PE
7542 * xsmfns.c (smc_save_yourself_CB, x_session_initialize): Avoid strlen.
7543 (x_session_initialize): Do not assume string length fits in int.
7544
aaafe47a
PE
7545 * xsettings.c (apply_xft_settings): Fix potential buffer overrun.
7546 This is unlikely, but can occur if DPI is outlandish.
7547
2674ddc8 7548 * xsettings.c (Ffont_get_system_normal_font, Ffont_get_system_font):
3a5077c5
PE
7549 * xselect.c (Fx_get_atom_name): Avoid need for strlen.
7550
28154962
PE
7551 * xrdb.c: Don't assume strlen fits in int; avoid some strlens.
7552 * xrdb.c (magic_file_p, search_magic_path):
7553 Omit last arg SUFFIX; it was always 0. All callers changed.
7554 (magic_file_p): Use ptrdiff_t, not int. Check for size overflow.
7555
7de51af5
PE
7556 * xfont.c (xfont_match): Avoid need for strlen.
7557
25ed6cc3
PE
7558 * xfns.c: Don't assume strlen fits in int.
7559 (xic_create_fontsetname, x_window): Use ptrdiff_t, not int.
7560
4eab31dd
PE
7561 * xdisp.c (message_log_check_duplicate): Return intmax_t,
7562 not unsigned long, as we prefer signed integers. All callers changed.
7563 Detect integer overflow in repeat count.
7564 (message_dolog): Don't assume print length fits in 39 bytes.
df1f27af 7565 (display_mode_element): Don't assume strlen fits in int.
4eab31dd 7566
171e2a58
PE
7567 * termcap.c: Don't assume sizes fit in int and never overflow.
7568 (struct termcap_buffer, tgetent): Use ptrdiff_t, not int, for sizes.
7569 (gobble_line): Check for size-calculation overflow.
7570
ad39faca 7571 * minibuf.c (Fread_buffer):
6e5bb2dc 7572 * lread.c (intern, intern_c_string):
74ca2eb3
PE
7573 * image.c (xpm_scan) [HAVE_NS && !HAVE_XPM]:
7574 Don't assume string length fits in int.
7575
52c61c22 7576 * keyboard.c (parse_tool_bar_item):
9bda3520
PE
7577 * gtkutil.c (style_changed_cb): Avoid need for strlen.
7578
b5b8c9e5
PE
7579 * font.c: Don't assume string length fits in int.
7580 (font_parse_xlfd, font_parse_fcname, font_unparse_fcname):
7581 Use ptrdiff_t, not int.
ccd6111c
PE
7582 (font_intern_prop): Don't assume string length fits in int.
7583 Don't assume integer property fits in fixnum.
7584 * font.h (font_intern_prop): 2nd arg is now ptrdiff_t, not int.
b5b8c9e5 7585
882f0d81 7586 * filelock.c: Fix some buffer overrun and integer overflow issues.
51cab52b 7587 (get_boot_time): Don't assume gzip command string fits in 100 bytes.
882f0d81
PE
7588 Reformulate so as not to need the command string.
7589 Invoke gzip -cd rather than gunzip, as it's more portable.
7590 (lock_info_type, lock_file_1, lock_file):
7591 Don't assume pid_t and time_t fit in unsigned long.
7592 (LOCK_PID_MAX): Remove; we now use more-reliable bounds.
7593 (current_lock_owner): Prefer signed type for sizes.
7594 Use memcpy, not strncpy, where memcpy is what is really wanted.
7595 Don't assume (via atoi) that time_t and pid_t fit in int.
7596 Check for time_t and/or pid_t out of range, e.g., via a network share.
7597 Don't alloca where an auto var works fine.
7598
93f4cf88
PE
7599 * fileio.c: Fix some integer overflow issues.
7600 (file_name_as_directory, Fexpand_file_name, Fsubstitute_in_file_name):
7601 Don't assume string length fits in int.
7602 (directory_file_name): Don't assume string length fits in long.
7603 (make_temp_name): Don't assume pid fits in int, or that its print
7604 length is less than 20.
7605
f3e92b69
PE
7606 * data.c (Fsubr_name): Rewrite to avoid a strlen call.
7607
1bfdaf10
PE
7608 * coding.c (make_subsidiaries): Don't assume string length fits in int.
7609
35016e9a
PE
7610 * callproc.c (child_setup): Rewrite to avoid two strlen calls.
7611
3d1e65a1
PE
7612 * process.c (Fformat_network_address): Use EMACS_INT, not EMACS_UINT.
7613 We prefer signed integers, even for size calculations.
7614
0b963a93
PE
7615 * emacs.c: Don't assume string length fits in 'int'.
7616 (DEFINE_DUMMY_FUNCTION, sort_args): Use ptrdiff_t, not int.
7617 (main): Don't invoke strlen when not needed.
7618
573f4b54
PE
7619 * dbusbind.c (XD_ERROR): Don't arbitrarily truncate string.
7620 (XD_DEBUG_MESSAGE): Don't waste a byte.
7621
989f33ba
PE
7622 * callproc.c (getenv_internal_1, getenv_internal)
7623 (Fgetenv_internal):
965d34eb
PE
7624 * buffer.c (init_buffer): Don't assume string length fits in 'int'.
7625
e4d29b33
PE
7626 * lread.c (invalid_syntax): Omit length argument.
7627 All uses changed. This doesn't fix a bug, but it simplifies the
7628 code away from its former Hollerith-constant appearance, and it's
7629 one less 'int' to worry about when looking at integer-overflow issues.
51cab52b 7630 (string_to_number): Simplify 2011-04-26 change by invoking xsignal1.
e4d29b33 7631
eb49b136
PE
7632 * lisp.h (DEFUN): Remove bogus use of sizeof (struct Lisp_Subr).
7633 This didn't break anything, but it didn't help either.
7634 It's confusing to put a bogus integer in a place where the actual
7635 value does not matter.
9f62aeb1 7636 (LIST_END_P): Remove unused macro and its bogus comment.
cbeff735 7637 (make_fixnum_or_float): Remove unnecessary cast to EMACS_INT.
eb49b136 7638
15375a22
PE
7639 * lisp.h (union Lisp_Object.i): EMACS_INT, not EMACS_UINT.
7640 This is for consistency with the ordinary, non-USE_LISP_UNION_TYPE,
7641 implementation.
b61cc01c
PE
7642 (struct Lisp_Bool_Vector.size): EMACS_INT, not EMACS_UINT.
7643 We prefer signed types, and the value cannot exceed the EMACS_INT
7644 range anyway (because otherwise the length would not be representable).
9a8e8d9b
PE
7645 (XSET) [USE_LISP_UNION_TYPE]: Use uintptr_t and intptr_t,
7646 not EMACS_UINT and EMACS_INT, when converting pointer to integer.
7647 This avoids a GCC warning when WIDE_EMACS_INT.
15375a22 7648
53b2623d
PE
7649 * indent.c (sane_tab_width): New function.
7650 (current_column, scan_for_column, Findent_to, position_indentation)
7651 (compute_motion): Use it. This is just for clarity.
8fcaf9cc 7652 (Fcompute_motion): Don't assume hscroll and tab offset fit in int.
53b2623d 7653
51cab52b 7654 * image.c (xbm_image_p): Don't assume stated width, height fit in int.
45aebb64 7655
f2ed8a70
PE
7656 * lisp.h (lint_assume): New macro.
7657 * composite.c (composition_gstring_put_cache):
7658 * ftfont.c (ftfont_shape_by_flt): Use it to pacify GCC 4.6.0.
7659
abe80cc6
PE
7660 * editfns.c, insdel.c:
7661 Omit unnecessary forward decls, to simplify future changes.
a9e860e1 7662
b02c740e
PE
7663 * ftfont.c (ftfont_shape_by_flt): Use signed integers for lengths.
7664
ebc96716
PE
7665 * font.c (Ffont_shape_gstring): Don't assume glyph len fits in 'int'.
7666
b4e50fa0 7667 * fns.c (Ffillarray): Don't assume bool vector size fits in 'int'.
f03dc6ef 7668 Use much-faster test for byte-length change.
311d5d7c 7669 Don't assume string byte-length fits in 'int'.
a4cf38e4 7670 Check that character arg fits in 'int'.
85461888 7671 (mapcar1): Declare byte as byte, for clarity.
b4e50fa0 7672
c0c1ee9f
PE
7673 * alloc.c (Fmake_bool_vector): Avoid unnecessary multiplication.
7674
a498d7f4
PE
7675 * fns.c (concat): Catch string overflow earlier.
7676 Do not rely on integer wraparound.
7677
51cab52b
PE
7678 * dispextern.h (struct it.overlay_strings_charpos)
7679 (struct it.selective): Now EMACS_INT, not int.
87830974
PE
7680 * xdisp.c (forward_to_next_line_start)
7681 (back_to_previous_visible_line_start)
7682 (reseat_at_next_visible_line_start, next_element_from_buffer):
7683 Don't arbitrarily truncate the value of 'selective' to int.
7684
76031fad
PE
7685 * xdisp.c (init_iterator): Use XINT, not XFASTINT; it might be < 0.
7686
5eb55db9
PE
7687 * composite.c: Don't truncate sizes to 'int'.
7688 (composition_gstring_p, composition_reseat_it)
7689 (composition_adjust_point): Use EMACS_INT, not int.
7d100a81
PE
7690 (get_composition_id, composition_gstring_put_cache): Use EMACS_INT,
7691 not EMACS_UINT, for indexes.
5eb55db9 7692
0703a717
PE
7693 * category.h (CATEGORY_SET_P): Remove unnecessary cast to EMACS_INT.
7694
d6202519
PE
7695 * buffer.c: Include <verify.h>.
7696 (struct sortvec.priority, struct sortstr.priority):
8961a454 7697 Now EMACS_INT, not int.
c20998a7 7698 (compare_overlays, cmp_for_strings): Avoid subtraction overflow.
67c36fce
PE
7699 (struct sortstr.size, record_overlay_string)
7700 (struct sortstrlist.size, struct sortlist.used):
7701 Don't truncate size to int.
7702 (record_overlay_string): Check for size-calculation overflow.
d6202519 7703 (init_buffer_once): Check at compile-time, not run-time.
fadf4e30 7704
d5a19415
JM
77052011-06-22 Jim Meyering <meyering@redhat.com>
7706
029529ac 7707 Don't leak an XBM-image-sized buffer
d5a19415
JM
7708 * image.c (xbm_load): Free the image buffer after using it.
7709
a9041e6c
PE
77102011-06-21 Paul Eggert <eggert@cs.ucla.edu>
7711
7712 Port to Sun C.
7713 * composite.c (find_automatic_composition): Omit needless 'return 0;'
7714 that Sun C diagnosed.
7715 * fns.c (secure_hash): Fix pointer signedness issue.
7716 * intervals.c (static_offset_intervals): New function.
7717 (offset_intervals): Use it.
7718
7f3f739f
LL
77192011-06-21 Leo Liu <sdl.web@gmail.com>
7720
7721 * deps.mk (fns.o):
7722 * makefile.w32-in ($(BLD)/fns.$(O)): Include sha256.h and
7723 sha512.h.
7724
7725 * fns.c (secure_hash): Rename from crypto_hash_function and change
7726 the first arg to accept symbols.
5b66d427 7727 (Fsecure_hash): New primitive.
7f3f739f
LL
7728 (syms_of_fns): New symbols.
7729
76147d94
DD
77302011-06-20 Deniz Dogan <deniz@dogan.se>
7731
7732 * process.c (Fset_process_buffer): Clarify return value in
7733 docstring.
7734
7d7d0045
CY
77352011-06-18 Chong Yidong <cyd@stupidchicken.com>
7736
7737 * dispnew.c (add_window_display_history): Use BVAR.
7738
7739 * xdisp.c (debug_method_add): Use BVAR.
7740 (check_window_end, dump_glyph_matrix, dump_glyph)
7741 (dump_glyph_row, dump_glyph_string): Convert arglist to ANSI C.
7742
7743 * xfaces.c (check_lface_attrs, check_lface, dump_realized_face):
7744 Likewise.
7745
7746 * xfns.c (Fx_create_frame, x_create_tip_frame): Delay image cache
7747 check till after the cache is created in init_frame_faces.
7748
ff2bc410
SM
77492011-06-17 Stefan Monnier <monnier@iro.umontreal.ca>
7750
7751 * fns.c (Fsafe_length): Yet another int/Lisp_Object mixup.
7752
28177add
PE
77532011-06-16 Paul Eggert <eggert@cs.ucla.edu>
7754
dd3482fe
PE
7755 * lisp.h: Include <limits.h>, for INT_MAX, LONG_MAX, LLONG_MAX.
7756 Without this, prin1 mishandles Lisp_Misc_Save_Value printing on
7757 hosts with pre-C99 libraries, because pD is wrongly defined to "t".
7758
393d71f3 7759 Improve buffer-overflow checking (Bug#8873).
1c8e352f
PE
7760 * fileio.c (Finsert_file_contents):
7761 * insdel.c (insert_from_buffer_1, replace_range, replace_range_2):
7762 Remove the old (too-loose) buffer overflow checks.
7763 They weren't needed, since make_gap checks for buffer overflow.
7764 * insdel.c (make_gap_larger): Catch buffer overflows that were missed.
7765 The old code merely checked for Emacs fixnum overflow, and relied
7766 on undefined (wraparound) behavior. The new code avoids undefined
7767 behavior, and also checks for ptrdiff_t and/or size_t overflow.
7768
2e6813b0 7769 * editfns.c (Finsert_char): Don't dump core with very negative counts.
21d890a4
PE
7770 Tune. Don't use wider integers than needed. Don't use alloca.
7771 Use a bigger 'string' buffer. Rewrite to avoid 'n > 0' test.
2e6813b0 7772
599a9e4f
PE
7773 * insdel.c (replace_range): Fix buf overflow when insbytes < outgoing.
7774
99561444
PE
7775 * insdel.c, lisp.h (buffer_overflow): New function.
7776 (insert_from_buffer_1, replace_range, replace_range_2):
7777 * insdel.c (make_gap_larger):
7778 * editfns.c (Finsert_char):
7779 * fileio.c (Finsert_file_contents): Use it, to normalize wording.
7780
28177add
PE
7781 * buffer.h (BUF_BYTES_MAX): Cast to ptrdiff_t so that it's signed.
7782
e69dafad
PE
77832011-06-15 Paul Eggert <eggert@cs.ucla.edu>
7784
4baa020d 7785 Integer overflow and signedness fixes (Bug#8873, Bug#8828).
ff672d2c 7786
b1c46f02
PE
7787 * ccl.c (ASCENDING_ORDER): New macro, to work around GCC bug 43772.
7788 (GET_CCL_RANGE, IN_INT_RANGE): Use it.
7789
e69dafad
PE
7790 * fileio.c: Don't assume EMACS_INT fits in off_t.
7791 (emacs_lseek): New static function.
7792 (Finsert_file_contents, Fwrite_region): Use it.
7793 Use SEEK_SET, SEEK_CUR, SEEK_END as appropriate.
7794
566684ea
PE
7795 * fns.c (Fload_average): Don't assume 100 * load average fits in int.
7796
e6966cd6
PE
7797 * fns.c: Don't overflow int when computing a list length.
7798 * fns.c (QUIT_COUNT_HEURISTIC): New constant.
7799 (Flength, Fsafe_length): Use EMACS_INT, not int, to avoid unwanted
7800 truncation on 64-bit hosts. Check for QUIT every
7801 QUIT_COUNT_HEURISTIC entries rather than every other entry; that's
7802 faster and is responsive enough.
7803 (Flength): Report an error instead of overflowing an integer.
7804 (Fsafe_length): Return a float if the value is not representable
7805 as a fixnum. This shouldn't happen except in contrived situations.
6346d301 7806 (Fnthcdr, Fsort): Don't assume list length fits in int.
de41a810 7807 (Fcopy_sequence): Don't assume vector length fits in int.
00c604f2 7808
dd0b0efb
PE
7809 * alloc.c: Check that resized vectors' lengths fit in fixnums.
7810 (header_size, word_size): New constants.
7811 (allocate_vectorlike): Don't check size overflow here.
7812 (allocate_vector): Check it here instead, since this is the only
7813 caller of allocate_vectorlike that could cause overflow.
7814 Check that the new vector's length is representable as a fixnum.
7815
86fe5cfe
PE
7816 * fns.c (next_almost_prime): Don't return a multiple of 3 or 5.
7817 The previous code was bogus. For example, next_almost_prime (32)
7818 returned 39, which is undesirable as it is a multiple of 3; and
7819 next_almost_prime (24) returned 25, which is a multiple of 5 so
7820 why was the code bothering to check for multiples of 7?
7821
80e88859
PE
7822 * bytecode.c (exec_byte_code): Use ptrdiff_t, not int, for vector length.
7823
4a2f0ad6
PE
7824 * eval.c, doprnt.c (SIZE_MAX): Remove; inttypes.h defines this now.
7825
f66c7cf8
PE
7826 Variadic C functions now count arguments with ptrdiff_t.
7827 This partly undoes my 2011-03-30 change, which replaced int with size_t.
7828 Back then I didn't know that the Emacs coding style prefers signed int.
7829 Also, in the meantime I found a few more instances where arguments
4a2f0ad6
PE
7830 were being counted with int, which may truncate counts on 64-bit
7831 machines, or EMACS_INT, which may be unnecessarily wide.
f66c7cf8
PE
7832 * lisp.h (struct Lisp_Subr.function.aMANY)
7833 (DEFUN_ARGS_MANY, internal_condition_case_n, safe_call):
7834 Arg counts are now ptrdiff_t, not size_t.
7835 All variadic functions and their callers changed accordingly.
7836 (struct gcpro.nvars): Now size_t, not size_t. All uses changed.
7837 * bytecode.c (exec_byte_code): Check maxdepth for overflow,
7838 to avoid potential buffer overrun. Don't assume arg counts fit in 'int'.
7839 * callint.c (Fcall_interactively): Check arg count for overflow,
7840 to avoid potential buffer overrun. Use signed char, not 'int',
7841 for 'varies' array, so that we needn't bother to check its size
7842 calculation for overflow.
7843 * editfns.c (Fformat): Use ptrdiff_t, not EMACS_INT, to count args.
7844 * eval.c (apply_lambda):
7845 * fns.c (Fmapconcat): Use XFASTINT, not XINT, to get args length.
7846 (struct textprop_rec.argnum): Now ptrdiff_t, not int. All uses changed.
7847 (mapconcat): Use ptrdiff_t, not int and EMACS_INT, to count args.
7848
a1759b76
PE
7849 * callint.c (Fcall_interactively): Don't use index var as event count.
7850
d96be9fc
PE
7851 * vm-limit.c (check_memory_limits): Fix incorrect extern function decls.
7852 * mem-limits.h (SIZE): Remove; no longer used.
7853
a690a978 7854 * xterm.c (x_alloc_nearest_color_1): Prefer int to long when int works.
5efd304b 7855
578c21e6
PE
7856 Remove unnecessary casts.
7857 * xterm.c (x_term_init):
7858 * xfns.c (x_set_border_pixel):
7859 * widget.c (create_frame_gcs): Remove casts to unsigned long etc.
7860 These aren't needed now that we assume ANSI C.
7861
96f53c6c
PE
7862 * sound.c (Fplay_sound_internal): Remove cast to unsigned long.
7863 It's more likely to cause problems (due to unsigned overflow)
7864 than to cure them.
7865
83c77d31
PE
7866 * dired.c (Ffile_attributes): Don't use 32-bit hack on 64-bit hosts.
7867
ee2079f1
PE
7868 * unexelf.c (unexec): Don't assume BSS addr fits in unsigned.
7869
6da65536
PE
7870 * xterm.c (handle_one_xevent): Omit unnecessary casts to unsigned.
7871
7147c4a4
PE
7872 * keyboard.c (modify_event_symbol): Don't limit alist len to UINT_MAX.
7873
193e32d9
PE
7874 * lisp.h (CHAR_TABLE_SET): Omit now-redundant test.
7875
e5533da6
PE
7876 * lread.c (Fload): Don't compare a possibly-garbage time_t value.
7877
9910e595
PE
7878 GLYPH_CODE_FACE returns EMACS_INT, not int.
7879 * dispextern.h (merge_faces):
7880 * xfaces.c (merge_faces):
01103c44
PE
7881 * xdisp.c (get_next_display_element, next_element_from_display_vector):
7882 Don't assume EMACS_INT fits in int.
9910e595 7883
2638320e
PE
7884 * character.h (CHAR_VALID_P): Remove unused parameter.
7885 * fontset.c, lisp.h, xdisp.c: All uses changed.
7886
045eb8d9
PE
7887 * editfns.c (Ftranslate_region_internal): Omit redundant test.
7888
c1f134b5
PE
7889 * fns.c (concat): Minor tuning based on overflow analysis.
7890 This doesn't fix any bugs. Use int to hold character, instead
7891 of constantly refetching from Emacs object. Use XFASTINT, not
7892 XINT, for value known to be a character. Don't bother comparing
7893 a single byte to 0400, as it's always less.
7894
395fcb93 7895 * floatfns.c (Fexpt):
327eeec8
PE
7896 * fileio.c (make_temp_name): Omit unnecessary cast to unsigned.
7897
abbd3d23
PE
7898 * editfns.c (Ftranslate_region_internal): Use int, not EMACS_INT
7899 for characters.
7900
684a03ef
PE
7901 * doc.c (get_doc_string): Omit (unsigned)c that mishandled negatives.
7902
0fed43f3
PE
7903 * data.c (Faset): If ARRAY is a string, check that NEWELT is a char.
7904 Without this fix, on a 64-bit host (aset S 0 4294967386) would
7905 incorrectly succeed when S was a string, because 4294967386 was
7906 truncated before it was used.
7907
8fd02eb7
PE
7908 * chartab.c (Fchar_table_range): Use CHARACTERP to check range.
7909 Otherwise, an out-of-range integer could cause undefined behavior
7910 on a 64-bit host.
7911
f8c86b69
PE
7912 * composite.c: Use int, not EMACS_INT, for characters.
7913 (fill_gstring_body, composition_compute_stop_pos): Use int, not
7914 EMACS_INT, for values that are known to be in character range.
7915 This doesn't fix any bugs but is the usual style inside Emacs and
7916 may generate better code on 32-bit machines.
7917
34206dd2
PE
7918 Make sure a 64-bit char is never passed to ENCODE_CHAR.
7919 This is for reasons similar to the recent CHAR_STRING fix.
7920 * charset.c (Fencode_char): Check that character arg is actually
7921 a character. Pass an int to ENCODE_CHAR.
7922 * charset.h (ENCODE_CHAR): Verify that the character argument is no
7923 wider than 'int', as a compile-time check to prevent future regressions
7924 in this area.
7925
c5958d4c 7926 * character.c (char_string): Remove unnecessary casts.
13bdea59
PE
7927
7928 Make sure a 64-bit char is never passed to CHAR_STRING.
7929 Otherwise, CHAR_STRING would do the wrong thing on a 64-bit platform,
7930 by silently ignoring the top 32 bits, allowing some values
7931 that were far too large to be valid characters.
7932 * character.h: Include <verify.h>.
7933 (CHAR_STRING, CHAR_STRING_ADVANCE): Verify that the character
7934 arguments are no wider than unsigned, as a compile-time check
7935 to prevent future regressions in this area.
7936 * data.c (Faset):
01103c44 7937 * editfns.c (Fchar_to_string, general_insert_function, Finsert_char)
13bdea59
PE
7938 (Fsubst_char_in_region):
7939 * fns.c (concat):
7940 * xdisp.c (decode_mode_spec_coding):
7941 Adjust to CHAR_STRING's new requirement.
7942 * editfns.c (Finsert_char, Fsubst_char_in_region):
7943 * fns.c (concat): Check that character args are actually
7944 characters. Without this test, these functions did the wrong
7945 thing with wildly out-of-range values on 64-bit hosts.
7946
d37ca623
PE
7947 Remove incorrect casts to 'unsigned' that lose info on 64-bit hosts.
7948 These casts should not be needed on 32-bit hosts, either.
7949 * keyboard.c (read_char):
7950 * lread.c (Fload): Remove casts to unsigned.
7951
ea204efb
PE
7952 * lisp.h (UNSIGNED_CMP): New macro.
7953 This fixes comparison bugs on 64-bit hosts.
7954 (ASCII_CHAR_P): Use it.
7955 * casefiddle.c (casify_object):
01103c44 7956 * character.h (ASCII_BYTE_P, CHAR_VALID_P)
ea204efb
PE
7957 (SINGLE_BYTE_CHAR_P, CHAR_STRING):
7958 * composite.h (COMPOSITION_ENCODE_RULE_VALID):
7959 * dispextern.h (FACE_FROM_ID):
7960 * keyboard.c (read_char): Use UNSIGNED_CMP.
7961
41cb286c
PE
7962 * xmenu.c (dialog_selection_callback) [!USE_GTK]: Cast to intptr_t,
7963 not to EMACS_INT, to avoid GCC warning.
7964
4a1b9832
PE
7965 * xfns.c (x_set_scroll_bar_default_width): Remove unused 'int' locals.
7966
55daad71
PE
7967 * buffer.h (PTR_BYTE_POS, BUF_PTR_BYTE_POS): Remove harmful cast.
7968 The cast incorrectly truncated 64-bit byte offsets to 32 bits, and
7969 isn't needed on 32-bit machines.
8f95c75c 7970
01103c44
PE
7971 * buffer.c (Fgenerate_new_buffer_name):
7972 Use EMACS_INT for count, not int.
0ceccced 7973 (advance_to_char_boundary): Return EMACS_INT, not int.
e762cafe
PE
7974
7975 * data.c (Qcompiled_function): Now static.
7976
c6f072e7
PE
7977 * window.c (window_body_lines): Now static.
7978
20ce5912
PE
7979 * image.c (gif_load): Rename local to avoid shadowing.
7980
9c4c5f81
PE
7981 * lisp.h (SAFE_ALLOCA_LISP): Check for integer overflow.
7982 (struct Lisp_Save_Value): Use ptrdiff_t, not int, for 'integer' member.
7983 * alloc.c (make_save_value): Integer argument is now of type
7984 ptrdiff_t, not int.
7985 (mark_object): Use ptrdiff_t, not int.
7986 * lisp.h (pD): New macro.
7987 * print.c (print_object): Use it.
7988
c0c5c8ae
PE
7989 * alloc.c: Use EMACS_INT, not int, to count objects.
7990 (total_conses, total_markers, total_symbols, total_vector_size)
7991 (total_free_conses, total_free_markers, total_free_symbols)
01103c44
PE
7992 (total_free_floats, total_floats, total_free_intervals)
7993 (total_intervals, total_strings, total_free_strings):
c0c5c8ae
PE
7994 Now EMACS_INT, not int. All uses changed.
7995 (Fgarbage_collect): Compute overall total using a double, so that
7996 integer overflow is less likely to be a problem. Check for overflow
7997 when converting back to an integer.
5a25e253
PE
7998 (n_interval_blocks, n_string_blocks, n_float_blocks, n_cons_blocks)
7999 (n_vectors, n_symbol_blocks, n_marker_blocks): Remove.
8000 These were 'int' variables that could overflow on 64-bit hosts;
8001 they were never used, so remove them instead of repairing them.
211a0b2a 8002 (nzombies, ngcs, max_live, max_zombies): Now EMACS_INT, not 'int'.
6349ae4d
PE
8003 (inhibit_garbage_collection): Set gc_cons_threshold to max value.
8004 Previously, this ceilinged at INT_MAX, but that doesn't work on
8005 64-bit machines.
e46bb31a 8006 (allocate_pseudovector): Don't use EMACS_INT when int would do.
c0c5c8ae 8007
c78baabf 8008 * alloc.c (Fmake_bool_vector): Don't assume vector size fits in int.
86f61a15 8009 (allocate_vectorlike): Check for ptrdiff_t overflow.
b6439961
PE
8010 (mark_vectorlike, mark_char_table, mark_object): Avoid EMACS_UINT
8011 when a (possibly-narrower) signed value would do just as well.
8012 We prefer using signed arithmetic, to avoid comparison confusion.
c78baabf 8013
c9d624c6
PE
8014 * alloc.c: Catch some string size overflows that we were missing.
8015 (XMALLOC_OVERRUN_CHECK_SIZE) [!XMALLOC_OVERRUN_CHECK]: Define to 0,
8016 for convenience in STRING_BYTES_MAX.
8017 (STRING_BYTES_MAX): New macro, superseding the old one in lisp.h.
8018 The definition here is exact; the one in lisp.h was approximate.
8019 (allocate_string_data): Check for string overflow. This catches
8020 some instances we weren't catching before. Also, it catches
8021 size_t overflow on (unusual) hosts where SIZE_MAX <= min
8022 (PTRDIFF_MAX, MOST_POSITIVE_FIXNUM), e.g., when size_t is 32 bits
8023 and ptrdiff_t and EMACS_INT are both 64 bits.
c78baabf 8024
c9d624c6
PE
8025 * character.c, coding.c, doprnt.c, editfns.c, eval.c:
8026 All uses of STRING_BYTES_MAX replaced by STRING_BYTES_BOUND.
640c8776 8027 * lisp.h (STRING_BYTES_BOUND): Rename from STRING_BYTES_MAX.
c9d624c6 8028
353032ce
PE
8029 * character.c (string_escape_byte8): Fix nbytes/nchars typo.
8030
2bccce07
PE
8031 * alloc.c (Fmake_string): Check for out-of-range init.
8032
0ac30604
SM
80332011-06-15 Stefan Monnier <monnier@iro.umontreal.ca>
8034
8035 * eval.c (Fdefvaralias): Also mark the target as variable-special-p.
8036
c195f2de
JD
80372011-06-14 Jan Djärv <jan.h.d@swipnet.se>
8038
8039 * xfns.c (x_set_scroll_bar_default_width): Remove argument to
8040 xg_get_default_scrollbar_width.
8041
8042 * gtkutil.c: Include emacsgtkfixed.h if HAVE_GTK3.
8043 (int_gtk_range_get_value): Move to the scroll bar part of the file.
8044 (style_changed_cb): Call update_theme_scrollbar_width and call
8045 x_set_scroll_bar_default_width and xg_frame_set_char_size for
8046 all frames (Bug#8505).
8047 (xg_create_frame_widgets): Call emacs_fixed_new if HAVE_GTK3 (Bug#8505).
8048 Call gtk_window_set_resizable if HAVE_GTK3.
8049 (x_wm_set_size_hint): Call emacs_fixed_set_min_size with min width
8050 and height if HAVE_GTK3 (Bug#8505).
8051 (scroll_bar_width_for_theme): New variable.
8052 (update_theme_scrollbar_width): New function.
8053 (xg_get_default_scrollbar_width): Move code to
8054 update_theme_scrollbar_width, just return scroll_bar_width_for_theme.
8055 (xg_initialize): Call update_theme_scrollbar_width.
8056
8057 * gtkutil.h (xg_get_default_scrollbar_width): Remove argument.
8058
8059 * emacsgtkfixed.c, emacsgtkfixed.h: New files.
8060
e10ac9f1
MR
80612011-06-12 Martin Rudalics <rudalics@gmx.at>
8062
8063 * frame.c (make_frame): Call other_buffer_safely instead of
8064 other_buffer.
8065
8066 * window.c (temp_output_buffer_show): Call display_buffer with
8067 second argument Vtemp_buffer_show_specifiers and reset latter
8068 immediately after the call.
8069 (Vtemp_buffer_show_specifiers): New variable.
8070 (auto_window_vscroll_p, next_screen_context_lines)
8071 (Vscroll_preserve_screen_position): Remove leading asterisks from
8072 doc-strings.
8073
2d3c217e 80742011-06-12 Paul Eggert <eggert@cs.ucla.edu>
4475bec4 8075
7b7f97e8 8076 Fix minor problems found by GCC 4.6.0 static checking.
4475bec4
PE
8077 * buffer.c (Qclone_number): Remove for now, as it's unused.
8078 (record_buffer, Funrecord_buffer): Rename local to avoid shadowing.
8079 (record_buffer): Remove unused local.
8080 * frame.c (other_visible_frames, frame_buffer_list): Now static.
8081 (set_frame_buffer_list): Remove; unused.
8082 * frame.h (other_visible_frames): Remove decl.
8083 * keyboard.h (menu_items_inuse): Declare only if USE_GTK || USE_MOTIF.
8084 * lisp.h (frame_buffer_list, set_frame_buffer_list): Remove decls.
8085 (add_gpm_wait_descriptor, delete_gpm_wait_descriptor): Declare only
8086 if HAVE_GPM.
8087 * menu.c (menu_items_inuse): Now static unless USE_GTK || USE_MOTIF.
8088 * process.c (add_gpm_wait_descriptor, delete_gpm_wait_descriptor):
8089 Define only if HAVE_GPM.
8090 * widget.c (EmacsFrameResize, emacsFrameClassRec): Now static.
8091 (update_hints_inhibit): Remove; never set. All uses removed.
8092 * widgetprv.h (emacsFrameClassRec): Remove decl.
8093 * window.c (delete_deletable_window): Now returns void, since it
8094 wasn't returning anything.
8095 (compare_window_configurations): Remove unused locals.
8096 * xfns.c (x_set_scroll_bar_default_width): Remove unused locals.
8097 * xmenu.c (x_menu_set_in_use): Define only if USE_GTK || USE_MOTIF.
4475bec4
PE
8098 (dialog_selection_callback) [!USE_GTK]: Prefer intptr_t for integers
8099 the same widths as pointers. This follows up on the 2011-05-06 patch.
8100 * xterm.c (x_alloc_lighter_color_for_widget): Define only if USE_LUCID.
8101 * xterm.h: Likewise.
8102 (x_menu_set_in_use): Declare only if USE_GTK || USE_MOTIF.
8103
1384b89e
JB
81042011-06-12 Juanma Barranquero <lekktu@gmail.com>
8105
8106 * makefile.w32-in: Update dependencies.
8107 (LISP_H): Add lib/intprops.h.
8108
1100a63c
CY
81092011-06-11 Chong Yidong <cyd@stupidchicken.com>
8110
8111 * image.c (gif_load): Add animation frame delay to the metadata.
8112 (syms_of_image): Use DEFSYM. New symbol `delay'.
8113
6198ccd0
MR
81142011-06-11 Martin Rudalics <rudalics@gmx.at>
8115
8116 * window.c (delete_deletable_window): Re-add.
8117 (Fset_window_configuration): Rewrite to handle dead buffers and
8118 consequently deletable windows.
8119 (window_tree, Fwindow_tree): Remove. Supply functionality in
8120 window.el.
8121 (compare_window_configurations): Simplify code.
8122
b6e3633c
AS
81232011-06-11 Andreas Schwab <schwab@linux-m68k.org>
8124
1ab0dee5
AS
8125 * image.c (imagemagick_load_image): Fix type mismatch.
8126 (Fimagemagick_types): Likewise.
8127
b6e3633c
AS
8128 * window.h (replace_buffer_in_windows): Declare.
8129
9397e56f
MR
81302011-06-11 Martin Rudalics <rudalics@gmx.at>
8131
8132 * buffer.c: New Lisp objects Qbuffer_list_update_hook and
8133 Qclone_number. Remove external declaration of Qdelete_window.
8134 (Fbuffer_list): Rewrite doc-string. Minor restructuring of
8135 code.
640c8776
SM
8136 (Fget_buffer_create, Fmake_indirect_buffer, Frename_buffer):
8137 Run Qbuffer_list_update_hook if allowed.
9397e56f
MR
8138 (Fother_buffer): Rewrite doc-string. Major rewrite for new
8139 buffer list implementation.
8140 (other_buffer_safely): New function.
8141 (Fkill_buffer): Replace call to replace_buffer_in_all_windows by
8142 calls to replace_buffer_in_windows and
8143 replace_buffer_in_windows_safely. Run Qbuffer_list_update_hook
8144 if allowed.
8145 (record_buffer): Inhibit quitting and rewrite using quittable
8146 functions. Run Qbuffer_list_update_hook if allowed.
8147 (Frecord_buffer, Funrecord_buffer): New functions.
640c8776
SM
8148 (switch_to_buffer_1, Fswitch_to_buffer): Remove.
8149 Move switch-to-buffer to window.el.
9397e56f
MR
8150 (bury-buffer): Move to window.el.
8151 (Vbuffer_list_update_hook): New variable.
8152
8153 * lisp.h (other_buffer_safely): Add prototype in buffer.c
8154 section.
8155
8156 * window.h (resize_frame_windows): Move up in code.
8157 (Fwindow_frame): Remove EXFUN.
8158 (replace_buffer_in_all_windows): Remove prototype.
8159 (replace_buffer_in_windows_safely): Add prototype.
8160
8161 * window.c: Declare Qdelete_window static again. Move down
8162 declaration of select_count.
8163 (Fnext_window, Fprevious_window): Rewrite doc-strings.
8164 (Fother_window): Move to window.el.
8165 (window_loop): Remove DELETE_BUFFER_WINDOWS and UNSHOW_BUFFER
8166 cases. Add REPLACE_BUFFER_IN_WINDOWS_SAFELY case.
8167 (Fdelete_windows_on, Freplace_buffer_in_windows): Move to
8168 window.el.
8169 (replace_buffer_in_windows): Implement by calling
8170 Qreplace_buffer_in_windows.
8171 (replace_buffer_in_all_windows): Remove with some functionality
8172 moved into replace_buffer_in_windows_safely.
8173 (replace_buffer_in_windows_safely): New function.
8174 (select_window_norecord, select_frame_norecord): Move in front
8175 of run_window_configuration_change_hook. Remove now obsolete
8176 declarations.
640c8776
SM
8177 (Fset_window_buffer): Rewrite doc-string.
8178 Call Qrecord_window_buffer.
9397e56f
MR
8179 (keys_of_window): Move binding for other-window to window.el.
8180
b50691aa
CY
81812011-06-11 Chong Yidong <cyd@stupidchicken.com>
8182
8183 * dispextern.h (struct image): Replace data member, whose int_val
8184 and ptr_val fields were not used by anything, with a single
8185 lisp_val object.
8186
8187 * image.c (Fimage_metadata, make_image, mark_image, tiff_load)
8188 (gif_clear_image, gif_load, imagemagick_load_image)
8189 (gs_clear_image, gs_load): Callers changed.
8190
3f754b86
PE
81912011-06-10 Paul Eggert <eggert@cs.ucla.edu>
8192
cca69397
PE
8193 * buffer.h: Include <time.h>, for time_t.
8194 Needed to build on FreeBSD 8.2. Problem reported by Herbert J. Skuhra.
8195
109e28d0
PE
8196 Fix minor problems found by static checking.
8197
60737f02
PE
8198 * image.c (PixelGetMagickColor): Declare if ImageMagick headers don't.
8199
4b66faf3
PE
8200 Make identifiers static if they are not used in other modules.
8201 * data.c (Qcompiled_function, Qframe, Qvector):
8202 * image.c (QimageMagick, Qsvg):
8203 * minibuf.c (Qmetadata):
8204 * window.c (resize_window_check, resize_root_window): Now static.
8205 * window.h (resize_window_check, resize_root_window): Remove decls.
8206
109e28d0
PE
8207 * window.c (window_deletion_count, delete_deletable_window):
8208 Remove; unused.
46a4ce9e
PE
8209 (window_body_lines): Now static.
8210 (Fdelete_other_windows_internal): Mark vars as initialized.
8211 Make sure 'resize_failed' is initialized.
8212 (run_window_configuration_change_hook): Rename local to avoid shadowing.
8213 (resize_window_apply): Remove unused local.
8214 * window.h (delete_deletable_window): Remove decl.
8215
109e28d0 8216 * image.c (gif_load, svg_load_image): Rename locals to avoid shadowing.
33290528
PE
8217 (imagemagick_load_image): Fix pointer signedness problem by changing
8218 last arg from unsigned char * to char *. All uses changed.
8219 Also, fix a local for similar reasons.
8220 Remove unused locals. Remove locals to avoid shadowing.
8221 (fn_rsvg_handle_free): Remove; unused.
8222 (svg_load, svg_load_image): Fix pointer signedness problem.
f7e13da3 8223 (imagemagick_load_image): Don't use garbage pointer image_wand.
33290528 8224
3f754b86
PE
8225 * ftfont.c (ftfont_get_metrics, ftfont_drive_otf): Remove unused locals.
8226
2547adb1
CY
82272011-06-10 Chong Yidong <cyd@stupidchicken.com>
8228
8229 * image.c (gif_load): Fix omitted cast error introduced by
8230 2011-06-06 change.
8231
2c8e37d4
MR
82322011-06-10 Martin Rudalics <rudalics@gmx.at>
8233
8234 * window.h (resize_proportionally, orig_total_lines)
8235 (orig_top_line): Remove from window structure.
8236 (set_window_height, set_window_width, change_window_heights)
8237 (Fdelete_window): Remove prototypes.
8238 (resize_frame_windows): Remove duplicate declaration.
8239
440a42e3
EZ
82402011-06-10 Eli Zaretskii <eliz@gnu.org>
8241
8242 * window.h (resize_frame_windows, resize_window_check)
8243 (delete_deletable_window, resize_root_window)
8244 (resize_frame_windows): Declare prototypes.
8245
8246 * window.c (resize_window_apply): Make definition be "static" to
8247 match the prototype.
8248
562dd5e9
MR
82492011-06-10 Martin Rudalics <rudalics@gmx.at>
8250
8251 * window.c: Remove declarations of Qwindow_size_fixed,
8252 window_min_size_1, window_min_size_2, window_min_size,
8253 size_window, window_fixed_size_p, enlarge_window, delete_window.
8254 Remove static from declaration of Qdelete_window, it's
8255 temporarily needed by Fbury_buffer.
8256 (replace_window): Don't assign orig_top_line and
8257 orig_total_lines.
8258 (Fdelete_window, delete_window): Remove. Window deletion is
8259 handled by window.el.
640c8776
SM
8260 (window_loop): Remove DELETE_OTHER_WINDOWS case.
8261 Replace Fdelete_window calls with calls to Qdelete_window.
562dd5e9
MR
8262 (Fdelete_other_windows): Remove. Deleting other windows is
8263 handled by window.el.
8264 (window_fixed_size_p): Remove. Fixed-sizeness of windows is
8265 handled in window.el.
8266 (window_min_size_2, window_min_size_1, window_min_size): Remove.
8267 Window minimum sizes are handled in window.el.
8268 (shrink_windows, size_window, set_window_height)
8269 (set_window_width, change_window_heights, window_height)
8270 (window_width, CURBEG, CURSIZE, enlarge_window)
8271 (adjust_window_trailing_edge, Fadjust_window_trailing_edge)
8272 (Fenlarge_window, Fshrink_window): Remove. Window resizing is
8273 handled in window.el.
8274 (make_dummy_parent): Rename to make_parent_window and give it a
8275 second argument horflag.
8276 (make_window): Don't set resize_proportionally any more.
8277 (Fsplit_window): Remove. Windows are split in window.el.
8278 (save_restore_action, save_restore_orig_size)
8279 (shrink_window_lowest_first, save_restore_orig_size): Remove.
8280 Resize mini windows in window.el.
8281 (grow_mini_window, shrink_mini_window): Implement by calling
8282 Qresize_root_window_vertically, resize_window_check and
8283 resize_window_apply.
640c8776
SM
8284 (saved_window, Fset_window_configuration, save_window_save):
8285 Do not handle orig_top_line, orig_total_lines, and
562dd5e9
MR
8286 resize_proportionally.
8287 (window_min_height, window_min_width): Move to window.el.
8288 (keys_of_window): Move bindings for delete-other-windows,
8289 split-window, delete-window and enlarge-window to window.el.
8290
8291 * buffer.c: Temporarily extern Qdelete_window.
8292 (Fbury_buffer): Temporarily call Qdelete_window instead of
8293 Fdelete_window (Fbury_buffer will move to window.el soon).
8294
8295 * frame.c (set_menu_bar_lines_1): Remove code handling
8296 orig_top_line and orig_total_lines.
8297
8298 * dispnew.c (adjust_frame_glyphs_initially): Don't use
8299 set_window_height but set heights directly.
8300 (change_frame_size_1): Use resize_frame_windows.
8301
8302 * xdisp.c (init_xdisp): Don't use set_window_height but set
8303 heights directly.
8304
640c8776
SM
8305 * xfns.c (x_set_menu_bar_lines, x_set_tool_bar_lines):
8306 Use resize_frame_windows instead of change_window_heights and run
562dd5e9
MR
8307 run_window_configuration_change_hook.
8308
8309 * w32fns.c (x_set_tool_bar_lines): Use resize_frame_windows
8310 instead of change_window_heights and run
8311 run_window_configuration_change_hook.
8312
1a13852e
MR
83132011-06-09 Martin Rudalics <rudalics@gmx.at>
8314
8315 * window.c (replace_window): Rename second argument REPLACEMENT to
8316 NEW. New third argument SETFLAG. Rewrite.
8317 (delete_window, make_dummy_parent): Call replace_window with
8318 third argument 1.
8319 (window_list_1): Move down in code.
8320 (run_window_configuration_change_hook): Move set_buffer part
8321 before select_frame_norecord part in order to unwind correctly.
8322 Rename count1 to count.
8323 (recombine_windows, delete_deletable_window, resize_root_window)
8324 (Fdelete_other_windows_internal)
8325 (Frun_window_configuration_change_hook, make_parent_window)
8326 (resize_window_check, resize_window_apply, Fresize_window_apply)
8327 (resize_frame_windows, Fsplit_window_internal)
640c8776
SM
8328 (Fdelete_window_internal, Fresize_mini_window_internal):
8329 New functions.
1a13852e
MR
8330 (syms_of_window): New variables Vwindow_splits and Vwindow_nest.
8331
f3d1777e
MR
83322011-06-08 Martin Rudalics <rudalics@gmx.at>
8333
496e208e
MR
8334 * window.h (window): Add some new members to window structure -
8335 normal_lines, normal_cols, new_total, new_normal, clone_number,
8336 splits, nest, prev_buffers, next_buffers.
8337 (WINDOW_TOTAL_SIZE): Move here from window.c.
b9e809c2 8338 (MIN_SAFE_WINDOW_WIDTH, MIN_SAFE_WINDOW_HEIGHT): Define here.
496e208e 8339
f3d1777e
MR
8340 * window.c (Fwindow_height, Fwindow_width, Fwindow_full_width_p):
8341 Remove.
496e208e
MR
8342 (make_dummy_parent): Set new members of windows structure.
8343 (make_window): Move down in code. Handle new members of window
8344 structure.
8345 (Fwindow_clone_number, Fwindow_splits, Fset_window_splits)
8346 (Fwindow_nest, Fset_window_nest, Fwindow_new_total)
8347 (Fwindow_normal_size, Fwindow_new_normal, Fwindow_prev_buffers)
8348 (Fset_window_prev_buffers, Fwindow_next_buffers)
640c8776
SM
8349 (Fset_window_next_buffers, Fset_window_clone_number):
8350 New functions.
496e208e
MR
8351 (Fwindow_hscroll, Fwindow_at, Fwindow_point, Fwindow_start)
8352 (Fwindow_end, Fwindow_line_height, Fset_window_dedicated_p):
8353 Doc-string fixes.
8354 (Fwindow_parameters, Fwindow_parameter, Fset_window_parameter):
8355 Argument WINDOW can be now internal window too.
8356 (Fwindow_use_time): Move up in code.
8357 (Fget_buffer_window): Rename argument FRAME to ALL-FRAMES.
8358 Rewrite doc-string.
8359 (Fset_window_configuration, saved_window)
8360 (Fcurrent_window_configuration, save_window_save): Handle new
8361 members of window structure.
b9e809c2
MR
8362 (WINDOW_TOTAL_SIZE, MIN_SAFE_WINDOW_WIDTH)
8363 (MIN_SAFE_WINDOW_HEIGHT): Move to window.h.
8364 (syms_of_window): New Lisp objects Qrecord_window_buffer,
8365 Qwindow_deletable_p, Qdelete_window, Qreplace_buffer_in_windows,
8366 Qget_mru_window, Qresize_root_window,
8367 Qresize_root_window_vertically, Qsafe, Qabove, Qbelow,
8368 Qauto_buffer_name; staticpro them.
f3d1777e 8369
abde8f8c
MR
83702011-06-07 Martin Rudalics <rudalics@gmx.at>
8371
8372 * window.c (Fwindow_total_size, Fwindow_left_column)
8373 (Fwindow_top_line, window_body_lines, Fwindow_body_size)
8374 (Fwindow_list_1): New functions.
8375 (window_box_text_cols): Replace with window_body_cols.
640c8776
SM
8376 (Fwindow_width, Fscroll_left, Fscroll_right):
8377 Use window_body_cols instead of window_box_text_cols.
8378 (delete_window, Fset_window_configuration):
8379 Call delete_all_subwindows with window as argument.
fa8a67e6
MR
8380 (delete_all_subwindows): Take a window as argument and not a
8381 structure. Rewrite.
190b47e6
MR
8382 (window_loop): Remove handling of GET_LRU_WINDOW and
8383 GET_LARGEST_WINDOW.
8384 (Fget_lru_window, Fget_largest_window): Move to window.el.
abde8f8c
MR
8385
8386 * window.h: Extern window_body_cols instead of
fa8a67e6
MR
8387 window_box_text_cols. delete_all_subwindows now takes a
8388 Lisp_Object as argument.
abde8f8c 8389
640c8776
SM
8390 * indent.c (compute_motion, Fcompute_motion):
8391 Use window_body_cols instead of window_box_text_cols.
abde8f8c 8392
fa8a67e6
MR
8393 * frame.c (delete_frame): Call delete_all_subwindows with root
8394 window as argument.
8395
a54e3482
DC
83962011-06-07 Daniel Colascione <dan.colascione@gmail.com>
8397
8398 * fns.c (Fputhash): Document return value.
8399
60002bf5
CY
84002011-06-06 Chong Yidong <cyd@stupidchicken.com>
8401
8402 * image.c (gif_load): Implement gif89a spec "no disposal" method.
8403
0c671da6 84042011-06-06 Paul Eggert <eggert@cs.ucla.edu>
ccd9a01a 8405
b862a52a 8406 Cons<->int and similar integer overflow fixes (Bug#8794).
77984278 8407
be44ca6c
PE
8408 Check for overflow when converting integer to cons and back.
8409 * charset.c (Fdefine_charset_internal, Fdecode_char):
8410 Use cons_to_unsigned to catch overflow.
8411 (Fencode_char): Use INTEGER_TO_CONS.
8412 * composite.h (LGLYPH_CODE): Use cons_to_unsigned.
8413 (LGLYPH_SET_CODE): Use INTEGER_TO_CONS.
8414 * data.c (long_to_cons, cons_to_long): Remove.
8415 (cons_to_unsigned, cons_to_signed): New functions.
8416 These signal an error for invalid or out-of-range values.
8417 * dired.c (Ffile_attributes): Use INTEGER_TO_CONS.
8418 * fileio.c (Fset_visited_file_modtime): Use CONS_TO_INTEGER.
8419 * font.c (Ffont_variation_glyphs):
8420 * fontset.c (Finternal_char_font): Use INTEGER_TO_CONS.
8421 * lisp.h: Include <intprops.h>.
8422 (INTEGER_TO_CONS, CONS_TO_INTEGER): New macros.
8423 (cons_to_signed, cons_to_unsigned): New decls.
8424 (long_to_cons, cons_to_long): Remove decls.
8425 * undo.c (record_first_change): Use INTEGER_TO_CONS.
8426 (Fprimitive_undo): Use CONS_TO_INTEGER.
8427 * xfns.c (Fx_window_property): Likewise.
8428 * xselect.c: Include <limits.h>.
8429 (x_own_selection, selection_data_to_lisp_data):
8430 Use INTEGER_TO_CONS.
8431 (x_handle_selection_request, x_handle_selection_clear)
8432 (x_get_foreign_selection, Fx_disown_selection_internal)
8433 (Fx_get_atom_name, x_send_client_event): Use CONS_TO_INTEGER.
8434 (lisp_data_to_selection_data): Use cons_to_unsigned.
8435 (x_fill_property_data): Use cons_to_signed.
8436 Report values out of range.
8437
d1f3d2af
PE
8438 Check for buffer and string overflow more precisely.
8439 * buffer.h (BUF_BYTES_MAX): New macro.
8440 * lisp.h (STRING_BYTES_MAX): New macro.
8441 * alloc.c (Fmake_string):
8442 * character.c (string_escape_byte8):
8443 * coding.c (coding_alloc_by_realloc):
8444 * doprnt.c (doprnt):
8445 * editfns.c (Fformat):
8446 * eval.c (verror):
8447 Use STRING_BYTES_MAX, not MOST_POSITIVE_FIXNUM,
8448 since they may not be the same number.
8449 * editfns.c (Finsert_char):
8450 * fileio.c (Finsert_file_contents):
8451 Likewise for BUF_BYTES_MAX.
8452
dd52fcea
PE
8453 * image.c: Use ptrdiff_t, not int, for sizes.
8454 (slurp_file): Switch from int to ptrdiff_t.
8455 All uses changed.
8456 (slurp_file): Check that file size fits in both size_t (for
8457 malloc) and ptrdiff_t (for sanity and safety).
8458
7f9bbdbb
PE
8459 * fileio.c (Fverify_visited_file_modtime): Avoid time overflow
8460 if b->modtime has its maximal value.
8461
dfe18f82
PE
8462 * dired.c (Ffile_attributes): Don't assume EMACS_INT has >32 bits.
8463
84acfcf0
PE
8464 Don't assume time_t can fit into int.
8465 * buffer.h (struct buffer.modtime): Now time_t, not int.
8466 * fileio.c (Fvisited_file_modtime): No need for time_t cast now.
8467 * undo.c (Fprimitive_undo): Use time_t, not int, for time_t value.
8468
ccd9a01a
PE
8469 Minor fixes for signed vs unsigned integers.
8470 * character.h (MAYBE_UNIFY_CHAR):
8471 * charset.c (maybe_unify_char):
8472 * keyboard.c (read_char, reorder_modifiers):
8473 XINT -> XFASTINT, since the integer must be nonnegative.
8474 * ftfont.c (ftfont_spec_pattern):
8475 * keymap.c (access_keymap, silly_event_symbol_error):
8476 XUINT -> XFASTINT, since the integer must be nonnegative.
8477 (Fsingle_key_description, preferred_sequence_p): XUINT -> XINT,
8478 since it makes no difference and we prefer signed.
8479 * keyboard.c (record_char): Use XUINT when all the neighbors do.
8480 (access_keymap): NATNUMP -> INTEGERP, since the integer must be
8481 nonnegative.
8482
d6d100dd
SM
84832011-06-06 Stefan Monnier <monnier@iro.umontreal.ca>
8484
8485 * window.h (Fwindow_frame): Declare.
8486
2b6148e4
PE
84872011-06-06 Paul Eggert <eggert@cs.ucla.edu>
8488
8489 * alloc.c: Simplify handling of large-request failures (Bug#8800).
8490 (SPARE_MEMORY): Always define.
8491 (LARGE_REQUEST): Remove.
8492 (memory_full): Use SPARE_MEMORY rather than LARGE_REQUEST.
8493
f230ecc9
MR
84942011-06-06 Martin Rudalics <rudalics@gmx.at>
8495
727e958e
MR
8496 * lisp.h: Move EXFUNS for Fframe_root_window,
8497 Fframe_first_window and Fset_frame_selected_window to window.h.
8498
8499 * window.h: Move EXFUNS for Fframe_root_window,
8500 Fframe_first_window and Fset_frame_selected_window here from
8501 lisp.h.
8502
8503 * frame.c (Fwindow_frame, Fframe_first_window)
8504 (Fframe_root_window, Fframe_selected_window)
8505 (Fset_frame_selected_window): Move to window.c.
8506 (Factive_minibuffer_window): Move to minibuf.c.
8507 (Fother_visible_frames_p): New function.
8508
8509 * minibuf.c (Factive_minibuffer_window): Move here from frame.c.
8510
f230ecc9
MR
8511 * window.c (decode_window, decode_any_window): Move up in code.
8512 (Fwindowp, Fwindow_live_p): Rewrite doc-strings.
8513 (inhibit_frame_unsplittable): Remove unused variable.
bf60a96b
MR
8514 (Fwindow_buffer): Move up and rewrite doc-string.
8515 (Fwindow_parent, Fwindow_vchild, Fwindow_hchild, Fwindow_next)
8516 (Fwindow_prev): New functions.
727e958e
MR
8517 (Fwindow_frame): Move here from frame.c. Accept any window as
8518 argument.
8519 (Fframe_root_window, Fframe_first_window)
8520 (Fframe_selected_window): Move here from frame.c. Accept frame
8521 or arbitrary window as argument. Update doc-strings.
8522 (Fminibuffer_window): Move up in code.
8523 (Fwindow_minibuffer_p): Move up in code and simplify.
d6d100dd
SM
8524 (Fset_frame_selected_window): Move here from frame.c.
8525 Marginal rewrite.
727e958e
MR
8526 (Fselected_window, select_window, Fselect_window): Move up in
8527 code. Minor doc-string fixes.
f230ecc9 8528
4d09bcf6
PE
85292011-06-06 Paul Eggert <eggert@cs.ucla.edu>
8530
8531 * alloc.c (memory_full) [SYSTEM_MALLOC]: Port to MacOS (Bug#8800).
8532 Do not assume that spare memory exists; that assumption is valid
8533 only if SYSTEM_MALLOC.
8534 (LARGE_REQUEST): New macro, so that the issue of large requests
8535 is separated from the issue of spare memory.
8536
810928a2
AS
85372011-06-05 Andreas Schwab <schwab@linux-m68k.org>
8538
172418ad
AS
8539 * editfns.c (Fformat): Correctly handle zero flag with hexadecimal
8540 format. (Bug#8806)
8541
43f862f7
AS
8542 * gtkutil.c (xg_get_default_scrollbar_width): Avoid warning.
8543
810928a2
AS
8544 * xfns.c (x_set_scroll_bar_default_width): Move declarations
8545 before statements.
8546
a059fe24
JD
85472011-06-05 Jan Djärv <jan.h.d@swipnet.se>
8548
8549 * gtkutil.c (xg_get_default_scrollbar_width): New function.
8550
8551 * gtkutil.h: Declare xg_get_default_scrollbar_width.
8552
8553 * xfns.c (x_set_scroll_bar_default_width): If USE_GTK, get
8554 min width by calling x_set_scroll_bar_default_width (Bug#8505).
8555
989bf368
JB
85562011-06-05 Juanma Barranquero <lekktu@gmail.com>
8557
8558 * xdisp.c (single_display_spec_intangible_p): Remove declaration.
8559
4b80f674
CY
85602011-06-04 Chong Yidong <cyd@stupidchicken.com>
8561
8562 * xselect.c (x_clipboard_manager_save): Remove redundant arg.
8563 (x_clipboard_manager_save): Add return value.
d6d100dd
SM
8564 (x_clipboard_manager_error_1, x_clipboard_manager_error_2):
8565 New error handlers.
4b80f674
CY
8566 (x_clipboard_manager_save_frame, x_clipboard_manager_save_all):
8567 Obey Vx_select_enable_clipboard_manager. Catch errors in
8568 x_clipboard_manager_save (Bug#8779).
8569 (Vx_select_enable_clipboard_manager): New variable.
de65b42c 8570 (x_get_foreign_selection): Reduce scope of x_catch_errors (Bug#8790).
4b80f674 8571
99a33b77 85722011-06-04 Dan Nicolaescu <dann@ics.uci.edu>
8b3115e7
DN
8573
8574 * emacs.c (main): Warn when starting a GTK emacs in daemon mode.
8575
99a33b77 85762011-06-04 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
14eca62f
YM
8577
8578 * fringe.c (update_window_fringes): Don't update overlay arrow bitmap
8579 in the current matrix if keep_current_p is non-zero.
8580
8264569d
EZ
85812011-06-04 Eli Zaretskii <eliz@gnu.org>
8582
8583 * bidi.c (bidi_level_of_next_char): Fix last change.
8584
57f97249
EZ
85852011-06-03 Eli Zaretskii <eliz@gnu.org>
8586
fec2107c 8587 Support bidi reordering of text covered by display properties.
57f97249 8588
fec2107c
EZ
8589 * bidi.c (bidi_copy_it): Use offsetof instead of emulating it.
8590 (bidi_fetch_char, bidi_fetch_char_advance): New functions.
8591 (bidi_cache_search, bidi_cache_iterator_state)
8592 (bidi_paragraph_init, bidi_resolve_explicit, bidi_resolve_weak)
d6d100dd
SM
8593 (bidi_level_of_next_char, bidi_move_to_visually_next):
8594 Support character positions inside a run of characters covered by a
fec2107c
EZ
8595 display string.
8596 (bidi_paragraph_init, bidi_resolve_explicit_1)
8597 (bidi_level_of_next_char): Call bidi_fetch_char and
8598 bidi_fetch_char_advance instead of FETCH_CHAR and
8599 FETCH_CHAR_ADVANCE.
8600 (bidi_init_it): Initialize new members.
8601 (LRE_CHAR, RLE_CHAR, PDF_CHAR, LRO_CHAR, RLO_CHAR): Remove macro
8602 definitions.
8603 (bidi_explicit_dir_char): Lookup character type in bidi_type_table,
8604 instead of using explicit *_CHAR codes.
d6d100dd
SM
8605 (bidi_resolve_explicit, bidi_resolve_weak):
8606 Use FETCH_MULTIBYTE_CHAR instead of FETCH_CHAR, as reordering of
fec2107c
EZ
8607 bidirectional text is supported only in multibyte buffers.
8608 (bidi_init_it): Accept additional argument FRAME_WINDOW_P and use
8609 it to initialize the frame_window_p member of struct bidi_it.
8610 (bidi_cache_iterator_state, bidi_resolve_explicit_1)
8611 (bidi_resolve_explicit, bidi_resolve_weak)
8612 (bidi_level_of_next_char, bidi_move_to_visually_next): Abort if
8613 bidi_it->nchars is non-positive.
8614 (bidi_level_of_next_char): Don't try to lookup the cache for the
8615 next/previous character if nothing is cached there yet, or if we
8616 were just reseat()'ed to a new position.
c40e2fb2 8617
0e14fe90
EZ
8618 * xdisp.c (set_cursor_from_row): Set start and stop points
8619 according to the row's direction when priming the loop that looks
8620 for the glyph on which to display cursor.
8621 (single_display_spec_intangible_p): Function deleted.
8622 (display_prop_intangible_p): Reimplement to call
8623 handle_display_spec instead of single_display_spec_intangible_p.
d6d100dd
SM
8624 Accept 3 additional arguments needed by handle_display_spec.
8625 This fixes incorrect cursor motion across display property with complex
0e14fe90
EZ
8626 values: lists, `(when COND...)' forms, etc.
8627 (single_display_spec_string_p): Support property values that are
8628 lists with the argument STRING its top-level element.
8629 (display_prop_string_p): Fix the condition for processing a
8630 property that is a list to be consistent with handle_display_spec.
fec2107c 8631 (handle_display_spec): New function, refactored from the
fc6f18ce
EZ
8632 last portion of handle_display_prop.
8633 (compute_display_string_pos): Accept additional argument
8634 FRAME_WINDOW_P. Call handle_display_spec to determine whether the
8635 value of a `display' property is a "replacing spec".
8636 (handle_single_display_spec): Accept 2 additional arguments BUFPOS
8637 and FRAME_WINDOW_P. If IT is NULL, don't set up the iterator from
8638 the display property, but just return a value indicating whether
8639 the display property will replace the characters it covers.
8640 (Fcurrent_bidi_paragraph_direction): Initialize the nchars and
8641 frame_window_p members of struct bidi_it.
d6d100dd
SM
8642 (compute_display_string_pos, compute_display_string_end):
8643 New functions.
fec2107c
EZ
8644 (push_it): Accept second argument POSITION, where pop_it should
8645 jump to continue iteration.
8646 (reseat_1): Initialize bidi_it.disp_pos.
fc6f18ce 8647
fec2107c
EZ
8648 * keyboard.c (adjust_point_for_property): Adjust the call to
8649 display_prop_intangible_p to its new signature.
fc6f18ce
EZ
8650
8651 * dispextern.h (struct bidi_it): New member frame_window_p.
fec2107c
EZ
8652 (bidi_init_it): Update prototypes.
8653 (display_prop_intangible_p): Update prototype.
d6d100dd
SM
8654 (compute_display_string_pos, compute_display_string_end):
8655 Declare prototypes.
fec2107c
EZ
8656 (struct bidi_it): New members nchars and disp_pos. ch_len is now
8657 EMACS_INT.
fc6f18ce 8658
40087514 86592011-06-02 Paul Eggert <eggert@cs.ucla.edu>
0de4bb68 8660
57f53182
PE
8661 Malloc failure behavior now depends on size of allocation.
8662 * alloc.c (buffer_memory_full, memory_full): New arg NBYTES.
8663 * lisp.h: Change signatures accordingly.
8664 * alloc.c, buffer.c, editfns.c, menu.c, minibuf.c, xterm.c:
8665 All callers changed. (Bug#8762)
8666
8667 * gnutls.c: Use Emacs's memory allocators.
8668 Without this change, the gnutls library would invoke malloc etc.
8669 directly, which causes problems on non-SYNC_INPUT hosts, and which
8670 runs afoul of improving memory_full behavior. (Bug#8761)
8671 (fn_gnutls_global_set_mem_functions): New macro or function pointer.
8672 (emacs_gnutls_global_init): Use it to specify xmalloc, xrealloc,
8673 xfree instead of the default malloc, realloc, free.
8674 (Fgnutls_boot): No need to check for memory allocation failure,
8675 since xmalloc does that for us.
8676
ac32cd99 8677 Remove arbitrary limit of 2**31 entries in hash tables. (Bug#8771)
3870d916
PE
8678 * category.c (hash_get_category_set):
8679 * ccl.c (ccl_driver):
8680 * charset.c (Fdefine_charset_internal):
8681 * charset.h (struct charset.hash_index):
8682 * composite.c (get_composition_id, gstring_lookup_cache)
8683 (composition_gstring_put_cache):
8684 * composite.h (struct composition.hash_index):
8685 * dispextern.h (struct image.hash):
8686 * fns.c (next_almost_prime, larger_vector, cmpfn_eql)
8687 (cmpfn_equal, cmpfn_user_defined, hashfn_eq, hashfn_eql)
8688 (hashfn_equal, hashfn_user_defined, make_hash_table)
8689 (maybe_resize_hash_table, hash_lookup, hash_put)
8690 (hash_remove_from_table, hash_clear, sweep_weak_table, SXHASH_COMBINE)
8691 (sxhash_string, sxhash_list, sxhash_vector, sxhash_bool_vector)
8692 (Fsxhash, Fgethash, Fputhash, Fmaphash):
8693 * image.c (make_image, search_image_cache, lookup_image)
8694 (xpm_put_color_table_h):
8695 * lisp.h (struct Lisp_Hash_Table):
0de4bb68 8696 * minibuf.c (Ftry_completion, Fall_completions, Ftest_completion):
ac389d0c 8697 * print.c (print): Use 'EMACS_UINT' and 'EMACS_INT'
3870d916 8698 for hashes and hash indexes, instead of 'unsigned' and 'int'.
40087514
PE
8699 * alloc.c (allocate_vectorlike):
8700 Check for overflow in vector size calculations.
8701 * ccl.c (ccl_driver):
8702 Check for overflow when converting EMACS_INT to int.
0de4bb68
PE
8703 * fns.c, image.c: Remove unnecessary static decls that would otherwise
8704 need to be updated by these changes.
40087514
PE
8705 * fns.c (make_hash_table, maybe_resize_hash_table):
8706 Check for integer overflow with large hash tables.
0de4bb68
PE
8707 (make_hash_table, maybe_resize_hash_table, Fmake_hash_table):
8708 Prefer the faster XFLOAT_DATA to XFLOATINT where either will do.
8709 (SXHASH_REDUCE): New macro.
8710 (sxhash_string, sxhash_list, sxhash_vector, sxhash_bool_vector):
8711 Use it instead of discarding useful hash info with large hash values.
8712 (sxhash_float): New function.
8713 (sxhash): Use it. No more need for "& INTMASK" due to above changes.
8714 * lisp.h (FIXNUM_BITS): New macro, useful for SXHASH_REDUCE etc.
40087514
PE
8715 (MOST_NEGATIVE_FIXNUM, MOST_POSITIVE_FIXNUM, INTMASK):
8716 Rewrite to use FIXNUM_BITS, as this simplifies things.
0de4bb68
PE
8717 (next_almost_prime, larger_vector, sxhash, hash_lookup, hash_put):
8718 Adjust signatures to match updated version of code.
8719 (consing_since_gc): Now EMACS_INT, since a single hash table can
8720 use more than INT_MAX bytes.
8721
698d32e2
DN
87222011-06-01 Dan Nicolaescu <dann@ics.uci.edu>
8723
8724 Make it possible to build with GCC-4.6+ -O2 -flto.
8725
8726 * emacs.c (__malloc_initialize_hook): Mark as EXTERNALLY_VISIBLE.
8727
fd6fa53f
SM
87282011-06-01 Stefan Monnier <monnier@iro.umontreal.ca>
8729
8730 * minibuf.c (get_minibuffer, read_minibuf_unwind):
8731 Call minibuffer-inactive-mode.
8732
864db017
JB
87332011-05-31 Juanma Barranquero <lekktu@gmail.com>
8734
8735 * makefile.w32-in ($(BLD)/data.$(O), $(BLD)/editfns.$(O)):
8736 Update dependencies.
8737
2ad0baf4
DN
87382011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
8739
8740 * data.c (init_data): Remove code for UTS, this system is not
8741 supported anymore.
8742
4fcc2638
DN
87432011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
8744
8745 Don't force ./temacs to start in terminal mode.
8746
8747 * frame.c (make_initial_frame): Initialize faces in all cases, not
8748 only when CANNOT_DUMP is defined.
8749 * dispnew.c (init_display): Remove CANNOT_DUMP condition.
8750
c56e0fd5
DN
87512011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
8752
8753 * dispnew.c (add_window_display_history): Use const for the string
8754 pointer. Remove declaration, not needed.
8755
333d54da 87562011-05-31 Paul Eggert <eggert@cs.ucla.edu>
9cf9f756 8757
55d4c1b2 8758 Use 'inline', not 'INLINE'.
333d54da 8759 <http://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00914.html>
55d4c1b2
PE
8760 * alloc.c, fontset.c (INLINE): Remove.
8761 * alloc.c, bidi.c, charset.c, coding.c, dispnew.c, fns.c, image.c:
8762 * intervals.c, keyboard.c, process.c, syntax.c, textprop.c, w32term.c:
8763 * xdisp.c, xfaces.c, xterm.c: Replace all uses of INLINE with inline.
8764 * gmalloc.c (register_heapinfo): Use inline unconditionally.
8765 * lisp.h (LISP_MAKE_RVALUE): Use inline, not __inline__.
8766
738db178
DN
87672011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
8768
8769 Make it possible to run ./temacs.
8770
8771 * callproc.c (set_initial_environment): Remove CANNOT_DUMP code,
8772 syms_of_callproc does the same thing. Remove test for
8773 "initialized", do it in the caller.
8774 * emacs.c (main): Avoid calling set_initial_environment when dumping.
8775
620c53a6
SM
87762011-05-31 Stefan Monnier <monnier@iro.umontreal.ca>
8777
8778 * minibuf.c (Finternal_complete_buffer): Return `category' metadata.
8779 (read_minibuf): Use get_minibuffer.
8780 (syms_of_minibuf): Use DEFSYM.
8781 (Qmetadata): New var.
8782 * data.c (Qbuffer): Don't make it static.
8783 (syms_of_data): Use DEFSYM.
8784
e003a292
PE
87852011-05-31 Paul Eggert <eggert@cs.ucla.edu>
8786
8787 * ccl.c (CCL_CODE_RANGE): Allow negative numbers. (Bug#8751)
8788 (CCL_CODE_MIN): New macro.
8789
ed008a6d
PE
87902011-05-30 Paul Eggert <eggert@cs.ucla.edu>
8791
3687c2ef
PE
8792 * alloc.c (lisp_align_malloc): Omit unnecessary val==NULL tests.
8793
ed008a6d
PE
8794 * eval.c (Qdebug): Now static.
8795 * lisp.h (Qdebug): Remove decl. This reverts a part of the
8796 2011-04-26T11:26:05Z!dan.colascione@gmail.com that inadvertently undid part of
8797 2011-04-14T06:48:41Z!eggert@cs.ucla.edu.
8798
d66c4c7c
CY
87992011-05-29 Chong Yidong <cyd@stupidchicken.com>
8800
8801 * image.c: Various fixes to ImageMagick code comments.
8802 (Fimagemagick_types): Doc fix.
8803
5fbc2025
PE
88042011-05-29 Paul Eggert <eggert@cs.ucla.edu>
8805
0196f88a
PE
8806 Minor fixes prompted by GCC 4.6.0 warnings.
8807
8808 * xselect.c (converted_selections, conversion_fail_tag): Now static.
8809
5fbc2025
PE
8810 * emacs.c [HAVE_X_WINDOWS]: Include "xterm.h".
8811 (x_clipboard_manager_save_all): Move extern decl to ...
8812 * xterm.h: ... here, so that it can be checked for consistency.
8813
1dd3c2d9
CY
88142011-05-29 Chong Yidong <cyd@stupidchicken.com>
8815
8816 * xselect.c (x_clipboard_manager_save_frame)
8817 (x_clipboard_manager_save_all): New functions.
8818 (Fx_clipboard_manager_save): Lisp function deleted.
8819
8820 * emacs.c (Fkill_emacs): Call x_clipboard_manager_save_all.
8821 * frame.c (delete_frame): Call x_clipboard_manager_save_frame.
8822
8823 * xterm.h: Update prototype.
8824
5ba6571d
WX
88252011-05-28 William Xu <william.xwl@gmail.com>
8826
8827 * nsterm.m (ns_term_shutdown): Synchronize user defaults before
8828 exiting (Bug#8239).
8829
3eaff834
JM
88302011-05-28 Jim Meyering <meyering@redhat.com>
8831
e1900994 8832 Avoid a sign-extension bug in crypto_hash_function.
3eaff834
JM
8833 * fns.c (to_uchar): Define.
8834 (crypto_hash_function): Use it to convert some newly-signed
8835 variables to unsigned, to avoid sign-extension bugs. For example,
8836 without this change, (md5 "truc") would evaluate to
8837 45723a2aff78ff4fff7fff1114760e62 rather than the expected
8838 45723a2af3788c4ff17f8d1114760e62. Reported by Antoine Levitt in
e1900994 8839 https://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00883.html.
3eaff834 8840
0f6990a7
PE
88412011-05-27 Paul Eggert <eggert@cs.ucla.edu>
8842
8843 Integer overflow fixes.
c8a9ca5a 8844
08686060
PE
8845 * dbusbind.c: Serial number integer overflow fixes.
8846 (CHECK_DBUS_SERIAL_GET_SERIAL): New macro.
08686060
PE
8847 (Fdbus_call_method_asynchronously, xd_read_message_1): Use a float
8848 to hold a serial number that is too large for a fixnum.
8849 (Fdbus_method_return_internal, Fdbus_method_error_internal):
8850 Check for serial numbers out of range. Decode any serial number
59568bf0 8851 that was so large that it became a float. (Bug#8722)
08686060 8852
2d1fc3c7
PE
8853 * dbusbind.c: Use XFASTINT rather than XUINT, and check for nonneg.
8854 (Fdbus_call_method, Fdbus_call_method_asynchronously):
8855 Use XFASTINT rather than XUINT when numbers are nonnegative.
8856 (xd_append_arg, Fdbus_method_return_internal):
8857 (Fdbus_method_error_internal): Likewise. Also, for unsigned
8858 arguments, check that Lisp number is nonnegative, rather than
59568bf0 8859 silently wrapping negative numbers around. (Bug#8722)
30217ff0 8860 (xd_read_message_1): Don't assume dbus_uint32_t can fit in int.
59568bf0 8861 (Bug#8722)
2d1fc3c7 8862
c8a9ca5a
PE
8863 * data.c (arith_driver, Flsh): Avoid unnecessary casts to EMACS_UINT.
8864
519e1d69
PE
8865 * ccl.c (ccl_driver): Redo slightly to avoid the need for 'unsigned'.
8866
6df6ae42 8867 ccl: Add integer overflow checks.
30569699
PE
8868 * ccl.c (CCL_CODE_MAX, GET_CCL_RANGE, GET_CCL_CODE, GET_CCL_INT):
8869 (IN_INT_RANGE): New macros.
8870 (ccl_driver): Use them to check for integer overflow when
8871 decoding a CCL program. Many of the new checks are whether XINT (x)
8872 fits in int; it doesn't always, on 64-bit hosts. The new version
8873 doesn't catch all possible integer overflows, but it's an
847044ea 8874 improvement. (Bug#8719)
30569699 8875
c11285dc
PE
8876 * alloc.c (make_event_array): Use XINT, not XUINT.
8877 There's no need for unsigned here.
8878
fdccd48e
PE
8879 * mem-limits.h (EXCEEDS_LISP_PTR) [!USE_LSB_TAG]: EMACS_UINT -> uintptr_t
8880 This follows up to the 2011-05-06 change that substituted uintptr_t
8881 for EMACS_INT. This case wasn't caught back then.
8882
37910ab2
PE
8883 Rework Fformat to avoid integer overflow issues.
8884 * editfns.c: Include <float.h> unconditionally, as it's everywhere
8885 now (part of C89). Include <verify.h>.
8886 (MAX_10_EXP, CONVERTED_BYTE_SIZE): Remove; no longer needed.
8887 (pWIDE, pWIDElen, signed_wide, unsigned_wide): New defns.
8888 (Fformat): Avoid the prepass trying to compute sizes; it was only
8889 approximate and thus did not catch overflow reliably. Instead, walk
8890 through the format just once, formatting and computing sizes as we go,
8891 checking for integer overflow at every step, and allocating a larger
8892 buffer as needed. Keep track separately whether the format is
8893 multibyte. Keep only the most-recently calculated precision, rather
8894 than them all. Record whether each argument has been converted to
8895 string. Use EMACS_INT, not int, for byte and char and arg counts.
8896 Support field widths and precisions larger than INT_MAX. Avoid
8897 sprintf's undefined behavior with conversion specifications such as %#d
8898 and %.0c. Fix bug with strchr succeeding on '\0' when looking for
8899 flags. Fix bug with (format "%c" 256.0). Avoid integer overflow when
8900 formatting out-of-range floating point numbers with int
9173deec 8901 formats. (Bug#8668)
37910ab2 8902
2e6578fb
PE
8903 * lisp.h (FIXNUM_OVERFLOW_P): Work even if arg is a NaN.
8904
0ae6bdee
PE
8905 * data.c: Avoid integer truncation in expressions involving floats.
8906 * data.c: Include <intprops.h>.
8907 (arith_driver): When there's an integer overflow in an expression
8908 involving floating point, convert the integers to floating point
8909 so that the resulting value does not suffer from catastrophic
8910 integer truncation. For example, on a 64-bit host (* 4
8911 most-negative-fixnum 0.5) should yield about -4.6e+18, not zero.
8912 Do not rely on undefined behavior after integer overflow.
8913
de883a70
PE
8914 merge count_size_as_multibyte, parse_str_to_multibyte
8915 * character.c, character.h (count_size_as_multibyte):
fd6fa53f 8916 Rename from parse_str_to_multibyte; all uses changed.
de883a70
PE
8917 Check for integer overflow.
8918 * insdel.c, lisp.h (count_size_as_multibyte): Remove,
8919 since it's now a duplicate of the other. This is more of
8920 a character than a buffer op, so better that it's in character.c.
8921 * fns.c, print.c: Adjust to above changes.
8922
2ff916cb
PE
89232011-05-27 Stefan Monnier <monnier@iro.umontreal.ca>
8924
8925 * xselect.c (x_convert_selection): Yet another int/Lisp_Object mixup.
8926
f1b54466
PE
89272011-05-27 Paul Eggert <eggert@cs.ucla.edu>
8928
fb1ac845
PE
8929 * xselect.c: Fix minor problems prompted by GCC 4.6.0 warnings.
8930 (x_handle_selection_request, frame_for_x_selection): Remove unused vars.
8931 (x_clipboard_manager_save): Now static.
8932 (Fx_clipboard_manager_save): Rename local to avoid shadowing.
8933
f1b54466
PE
8934 * fns.c: Fix minor problems prompted by GCC 4.6.0 warnings.
8935 (crypto_hash_function): Now static.
8936 Fix pointer signedness problems. Avoid unnecessary initializations.
8937
a9f737ee
CY
89382011-05-27 Chong Yidong <cyd@stupidchicken.com>
8939
8940 * termhooks.h (Vselection_alist): Make it terminal-local.
8941
8942 * terminal.c (create_terminal): Initialize it.
8943
8944 * xselect.c: Support for clipboard managers.
8945 (Vselection_alist): Move to termhooks.h as terminal-local var.
8946 (LOCAL_SELECTION): New macro.
8947 (x_atom_to_symbol): Handle x_display_info_for_display fail case.
8948 (symbol_to_x_atom): Remove gratuitous arg.
8949 (x_handle_selection_request, lisp_data_to_selection_data)
8950 (x_get_foreign_selection, Fx_register_dnd_atom): Callers changed.
620c53a6
SM
8951 (x_own_selection, x_get_local_selection, x_convert_selection):
8952 New arg, specifying work frame. Use terminal-local Vselection_alist.
a9f737ee
CY
8953 (some_frame_on_display): Delete unused function.
8954 (Fx_own_selection_internal, Fx_get_selection_internal)
8955 (Fx_disown_selection_internal, Fx_selection_owner_p)
8956 (Fx_selection_exists_p): New optional frame arg.
8957 (frame_for_x_selection, Fx_clipboard_manager_save): New functions.
8958 (x_handle_selection_clear): Don't treat other terminals with the
8959 same keyboard specially. Use the terminal-local Vselection_alist.
8960 (x_clear_frame_selections): Use Frun_hook_with_args.
8961
8962 * xterm.c (x_term_init): Intern ATOM and CLIPBOARD_MANAGER atoms.
8963
8964 * xterm.h: Add support for those atoms.
8965
e067f0c1
CY
89662011-05-26 Chong Yidong <cyd@stupidchicken.com>
8967
8968 * xselect.c: ICCCM-compliant handling of MULTIPLE targets.
8969 (converted_selections, conversion_fail_tag): New global variables.
8970 (x_selection_request_lisp_error): Free the above.
8971 (x_get_local_selection): Remove unnecessary code.
8972 (x_reply_selection_request): Args changed; handle arbitrary array
620c53a6
SM
8973 of converted selections stored in converted_selections.
8974 Separate the XChangeProperty and SelectionNotify steps.
e067f0c1
CY
8975 (x_handle_selection_request): Rewrite to handle MULTIPLE target.
8976 (x_convert_selection): New function.
8977 (x_handle_selection_event): Simplify.
8978 (x_get_foreign_selection): Don't ignore incoming requests while
8979 waiting for an answer; this will fail when we implement
8980 SAVE_TARGETS, and seems unnecessary anyway.
8981 (selection_data_to_lisp_data): Recognize ATOM_PAIR type.
8982 (Vx_sent_selection_functions): Doc fix.
8983
0f4aebc0
LL
89842011-05-26 Leo Liu <sdl.web@gmail.com>
8985
8986 * editfns.c (Ftranspose_regions): Allow empty regions. (Bug#8699)
8987
e61124cd
YM
89882011-05-25 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
8989
8990 * dispextern.h (struct glyph_row): New member fringe_bitmap_periodic_p.
8991
8992 * dispnew.c (shift_glyph_matrix, scrolling_window): Mark scrolled row
8993 for fringe update if it has periodic bitmap.
ac389d0c 8994 (row_equal_p): Also compare left_fringe_offset, right_fringe_offset,
e61124cd
YM
8995 and fringe_bitmap_periodic_p.
8996
8997 * fringe.c (get_fringe_bitmap_data): New function.
8998 (draw_fringe_bitmap_1, update_window_fringes): Use it.
8999 (update_window_fringes): Record periodicity of fringe bitmap in glyph
9000 row. Mark glyph row for fringe update if periodicity changed.
9001
9002 * xdisp.c (try_window_reusing_current_matrix): Don't mark scrolled row
9003 for fringe update unless it has periodic bitmap.
9004
f16d9837
KH
90052011-05-25 Kenichi Handa <handa@m17n.org>
9006
9007 * xdisp.c (get_next_display_element): Set correct it->face_id for
9008 a static composition.
9009
e1b90ef6
LL
90102011-05-24 Leo Liu <sdl.web@gmail.com>
9011
9012 * deps.mk (fns.o):
9013 * makefile.w32-in ($(BLD)/fns.$(O)): Include sha1.h.
9014
9015 * fns.c (crypto_hash_function, Fsha1): New function.
9016 (Fmd5): Use crypto_hash_function.
9017 (syms_of_fns): Add Ssha1.
9018
7400048f
PE
90192011-05-22 Paul Eggert <eggert@cs.ucla.edu>
9020
9021 * gnutls.c: Remove unused macros.
9022 (fn_gnutls_transport_set_lowat, fn_gnutls_transport_set_pull_function):
9023 (fn_gnutls_transport_set_push_function) [!WINDOWSNT]:
9024 Remove macros that are defined and never used.
9025 Caught by gcc -Wunused-macros (GCC 4.6.0, Fedora 14).
9026
abb71cf4
CY
90272011-05-22 Chong Yidong <cyd@stupidchicken.com>
9028
9029 * xselect.c (syms_of_xselect): Remove unused symbol SAVE_TARGETS.
9030 (Fx_get_selection_internal): Minor cleanup.
9031 (Fx_own_selection_internal): Rename arguments for consistency with
9032 select.el.
9033
6307db39
PE
90342011-05-22 Paul Eggert <eggert@cs.ucla.edu>
9035
9036 * xselect.c (QSAVE_TARGETS): New static var, to fix build failure.
9037
f3d4e0a4
CY
90382011-05-22 Chong Yidong <cyd@stupidchicken.com>
9039
9040 * xselect.c (syms_of_xselect): Include character.h; use DEFSYM.
9041
4d8ade89
YM
90422011-05-21 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
9043
9044 * dispnew.c (scrolling_window): Don't exclude the case that the
9045 last enabled row in the desired matrix touches the bottom boundary.
9046
32078c8d
GM
90472011-05-21 Glenn Morris <rgm@gnu.org>
9048
9049 * Makefile.in ($(etc)/DOC): Make second command line even shorter.
33cf345f
GM
9050 (SOME_MACHINE_OBJECTS): Replace FONT_OBJ by its maximal expansion,
9051 and add some more files.
32078c8d 9052
7285dc67
EZ
90532011-05-20 Eli Zaretskii <eliz@gnu.org>
9054
9055 * callproc.c (Fcall_process) [MSDOS]: Fix arguments to
9056 report_file_error introduced by the change from 2011-05-07.
9057
89d1bd22
PE
90582011-05-20 Paul Eggert <eggert@cs.ucla.edu>
9059
9060 * systime.h (Time): Define only if emacs is defined.
9061 This is to allow ../lib-src/profile.c to be compiled on FreeBSD,
9062 where the include path doesn't have X11/X.h by default. See
9063 <http://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00561.html>.
9064
cd394be1 90652011-05-20 Kenichi Handa <handa@m17n.org>
31bfc35c
KH
9066
9067 * composite.c (find_automatic_composition): Fix previous change.
9068
b9704ad9
GM
90692011-05-20 Glenn Morris <rgm@gnu.org>
9070
9071 * lisp.mk: New file, split from Makefile.in.
9072 * Makefile.in (lisp): Move to separate file, inserted by @lisp_frag@.
9073 (shortlisp): Remove.
9074 ($(etc)/DOC): Edit lisp.mk rather than using $shortlisp.
9075
4a720484
GM
90762011-05-19 Glenn Morris <rgm@gnu.org>
9077
9078 * Makefile.in (MSDOS_SUPPORT_REAL, MSDOS_SUPPORT, NS_SUPPORT)
9079 (REAL_MOUSE_SUPPORT, GPM_MOUSE_SUPPORT, MOUSE_SUPPORT, TOOLTIP_SUPPORT)
9080 (BASE_WINDOW_SUPPORT, X_WINDOW_SUPPORT, WINDOW_SUPPORT): Remove.
9081 (lisp): Set the order to that of loadup.el.
9082 (shortlisp): Make it a copy of $lisp.
9083 (SOME_MACHINE_LISP): Remove.
9084 ($(etc)/DOC): Depend just on $lisp, not $SOME_MACHINE_LISP too.
9085 Use just $shortlisp, not $SOME_MACHINE_LISP too.
9086
a28d4396
KH
90872011-05-18 Kenichi Handa <handa@m17n.org>
9088
9089 * composite.c (CHAR_COMPOSABLE_P): Add more check for efficiency.
9090 (BACKWARD_CHAR): Wrap the arg STOP by parenthesis.
9091 (find_automatic_composition): Mostly rewrite for efficiency.
9092
a2b1fa8e
JB
90932011-05-18 Juanma Barranquero <lekktu@gmail.com>
9094
9095 * makefile.w32-in: Update dependencies.
9096
8e1f5610
CS
90972011-05-18 Christoph Scholtes <cschol2112@googlemail.com>
9098
9099 * menu.c: Include limits.h (fixes the MS-Windows build broken by
7d7d0045 9100 2011-06-18T18:49:19Z!cyd@stupidchicken.com).
8e1f5610 9101
7025ee00 91022011-05-18 Paul Eggert <eggert@cs.ucla.edu>
cb93f9be 9103
cdfa6eab
PE
9104 Fix some integer overflow issues, such as string length overflow.
9105
06d6db33
PE
9106 * insdel.c (count_size_as_multibyte): Check for string overflow.
9107
2b4560a8
PE
9108 * character.c (lisp_string_width): Check for string overflow.
9109 Use EMACS_INT, not int, for string indexes and lengths; in
9110 particular, 2nd arg is now EMACS_INT, not int. Do not crash if
9111 the resulting string length overflows an EMACS_INT; instead,
9112 report a string overflow if no precision given. When checking for
9113 precision exhaustion, use a check that cannot possibly have
9114 integer overflow. (Bug#8675)
9115 * character.h (lisp_string_width): Adjust to new signature.
9116
cb93f9be
PE
9117 * alloc.c (string_overflow): New function.
9118 (Fmake_string): Use it. This doesn't change behavior, but saves
9119 a few bytes and will simplify future changes.
9120 * character.c (string_escape_byte8): Likewise.
9121 * lisp.h (string_overflow): New decl.
9122
1a1f3366
PE
9123 Fixups, following up to the user-interface timestamp change.
9124 * nsterm.m (last_mouse_movement_time, ns_mouse_position): Use Time
9125 for UI timestamps, instead of unsigned long.
9fbd6841
PE
9126 * msdos.c (mouse_get_pos): Likewise.
9127 * w32inevt.c (movement_time, w32_console_mouse_position): Likewise.
1a1f3366
PE
9128 * w32gui.h (Time): Define by including "systime.h" rather than by
9129 declaring it ourselves. (Bug#8664)
9130
d4e3e4d3
PE
9131 * dispextern.h (struct image): Don't assume time_t <= unsigned long.
9132 * image.c (clear_image_cache): Likewise.
9133
f6a24d19
PE
9134 * term.c (term_mouse_position): Don't assume time_t wraparound.
9135
08dc5ae6
PE
9136 Be more systematic about user-interface timestamps.
9137 Before, the code sometimes used 'Time', sometimes 'unsigned long',
620c53a6
SM
9138 and sometimes 'EMACS_UINT', to represent these timestamps.
9139 This change causes it to use 'Time' uniformly, as that's what X uses.
08dc5ae6
PE
9140 This makes the code easier to follow, and makes it easier to catch
9141 integer overflow bugs such as Bug#8664.
9142 * frame.c (Fmouse_position, Fmouse_pixel_position):
9143 Use Time, not unsigned long, for user-interface timestamps.
9144 * keyboard.c (last_event_timestamp, kbd_buffer_get_event): Likewise.
9145 (button_down_time, make_lispy_position, make_lispy_movement): Likewise.
9146 * keyboard.h (last_event_timestamp): Likewise.
9147 * menu.c (Fx_popup_menu) [!HAVE_X_WINDOWS]: Likewise.
9148 * menu.h (xmenu_show): Likewise.
9149 * term.c (term_mouse_position): Likewise.
9150 * termhooks.h (struct input_event.timestamp): Likewise.
9151 (struct terminal.mouse_position_hook): Likewise.
9152 * xmenu.c (create_and_show_popup_menu, xmenu_show): Likewise.
9153 * xterm.c (XTmouse_position, x_scroll_bar_report_motion): Likewise.
9154 * systime.h (Time): New decl. Pull it in from <X11/X.h> if
9155 HAVE_X_WINDOWS, otherwise define it as unsigned long, which is
9156 what it was before.
9157 * menu.h, termhooks.h: Include "systime.h", for Time.
9158
8e55734a
PE
9159 * keyboard.c (make_lispy_event): Fix problem in integer overflow.
9160 Don't assume that the difference between two unsigned long values
9161 can fit into an integer. At this point, we know button_down_time
9162 <= event->timestamp, so the difference must be nonnegative, so
9163 there's no need to cast the result if double-click-time is
9164 nonnegative, as it should be; check that it's nonnegative, just in
9165 case. This bug is triggered when events are more than 2**31 ms
86db42d2 9166 apart (about 25 days). (Bug#8664)
8e55734a 9167
841f1b75 9168 * xselect.c (last_event_timestamp): Remove duplicate decl.
6434756c 9169 (x_own_selection): Remove needless cast to unsigned long.
841f1b75 9170
3e26f69c
PE
9171 * xmenu.c (set_frame_menubar): Use int, not EMACS_UINT, for indexes
9172 that always fit in int. Use a sentinel instead of a counter, to
9173 avoid a temp and to allay GCC's concerns about possible int overflow.
d230cb74
PE
9174 * frame.h (struct frame): Use int for menu_bar_items_used
9175 instead of EMACS_INT, since it always fits in int.
3e26f69c 9176
5cc152c0
PE
9177 * menu.c (grow_menu_items): Check for int overflow.
9178
d89eb65e
PE
9179 * xmenu.c (set_frame_menubar): Don't mishandle vectors with no nils.
9180
5235bd3e
PE
9181 * xterm.c: Use EMACS_INT for Emacs modifiers, and int for X modifiers.
9182 Before, the code was not consistent. These values cannot exceed
9183 2**31 - 1 so there's no need to make them unsigned.
9184 (x_x_to_emacs_modifiers): Accept int and return EMACS_INT.
9185 (x_emacs_to_x_modifiers): Accept EMACS_INT and return int.
9186 (x_x_to_emacs_modifiers, x_emacs_to_x_modifiers): Reject non-integers
9187 as modifiers.
9188 * xterm.h (x_x_to_emacs_modifiers): Adjust to signature change.
9189
bc827e23
PE
9190 * lisp.h (XINT) [USE_LISP_UNION_TYPE]: Cast to EMACS_INT.
9191 (XUINT) [USE_LISP_UNION_TYPE]: Cast to EMACS_UINT.
9192 Otherwise, GCC 4.6.0 warns about printf (pI, XINT (...)),
9193 presumably because the widths might not match.
9194
78eb494e
PE
9195 * window.c (size_window): Avoid needless test at loop start.
9196
04f2d78b
CB
91972011-05-18 Courtney Bane <emacs-bugs-7626@cbane.org> (tiny change)
9198
9199 * term.c (Fresume_tty): Restore hooks before reinitializing (bug#8687).
9200
d2fc7e3d 92012011-05-12 Drew Adams <drew.adams@oracle.com>
e531bdff
DA
9202
9203 * textprop.c (Fprevious_single_char_property_change): Doc fix (bug#8655).
9204
d2fc7e3d 92052011-05-12 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
7db47798
YM
9206
9207 * w32term.c (w32_draw_fringe_bitmap): Rename local vars `left' and
9208 `width' to `bar_area_x' and `bar_area_width', respectively.
9209 (x_scroll_run): Take account of fringe background extension.
9210
04f2d78b
CB
9211 * xterm.c (x_draw_fringe_bitmap) [USE_TOOLKIT_SCROLL_BARS]:
9212 Rename local vars `left' and `width' to `bar_area_x' and
7db47798
YM
9213 `bar_area_width', respectively.
9214 (x_scroll_run) [USE_TOOLKIT_SCROLL_BARS]: Take account of fringe
9215 background extension.
9216
79b70037
GM
92172011-05-10 Jim Meyering <meyering@redhat.com>
9218
9219 * xdisp.c (x_intersect_rectangles): Fix typo "the the -> the".
9220
2f142cc5
JB
92212011-05-10 Juanma Barranquero <lekktu@gmail.com>
9222
9223 * image.c (Finit_image_library): Return t for built-in image types,
9224 like pbm and xbm. (Bug#8640)
9225
57679c86
AS
92262011-05-09 Andreas Schwab <schwab@linux-m68k.org>
9227
9228 * w32menu.c (set_frame_menubar): Fix submenu allocation.
9229
888c9e86
EZ
92302011-05-07 Eli Zaretskii <eliz@gnu.org>
9231
b0512a1d
EZ
9232 * w32console.c (Fset_screen_color): Doc fix.
9233 (Fget_screen_color): New function.
9234 (syms_of_ntterm): Defsubr it.
9235
7285dc67
EZ
9236 * callproc.c (call_process_cleanup) [MSDOS]: Don't close and
9237 unlink the temporary file if Fcall_process didn't create it in the
9238 first place.
9239 (Fcall_process) [MSDOS]: Don't create tempfile if stdout of the
9240 child process will be redirected to a file specified with `:file'.
888c9e86
EZ
9241 Don't try to re-open tempfile in that case, and set fd[0] to -1 as
9242 cue to call_process_cleanup not to close that handle.
9243
4d3fcc8e
BK
92442011-05-07 Ben Key <bkey76@gmail.com>
9245
9246 * makefile.w32-in: The bootstrap-temacs rule now makes use of
9247 one of two shell specific rules, either bootstrap-temacs-CMD or
9248 bootstrap-temacs-SH. The bootstrap-temacs-SH rule is identical
9249 to the previous implementation of the bootstrap-temacs rule.
9250 The bootstrap-temacs-CMD rule is similar to the previous
9251 implementation of the bootstrap-temacs rule except that it
9252 makes use of the ESC_CFLAGS variable instead of the CFLAGS
9253 variable.
9254
9255 These changes, along with some changes to nt/configure.bat,
9256 nt/gmake.defs, and nt/nmake.defs, are required to extend my
9257 earlier fix to add support for --cflags and --ldflags options
9258 that include quotes so that it works whether make uses cmd or
9259 sh as the shell.
9260
b4289b64
MA
92612011-05-06 Michael Albinus <michael.albinus@gmx.de>
9262
9263 * dbusbind.c (QCdbus_type_unix_fd): Declare static.
9264 (xd_remove_watch): Don't check QCdbus_type_unix_fd for SYMBOLP, it
9265 is a constant.
9266 (Fdbus_init_bus, xd_read_queued_messages): Bus can be a symbol or
9267 a string. Handle both cases.
9268 (Fdbus_call_method_asynchronously, Fdbus_register_signal)
9269 (Fdbus_register_method): Use Qinvalid_function.
9270
af4c0e28
JB
92712011-05-06 Juanma Barranquero <lekktu@gmail.com>
9272
9273 * makefile.w32-in: Update dependencies.
9274 (LISP_H): Add inttypes.h and stdin.h.
9275 (PROCESS_H): Add unistd.h.
9276
c51453d9
EZ
92772011-05-06 Eli Zaretskii <eliz@gnu.org>
9278
9279 * lread.c: Include limits.h (fixes the MS-Windows build broken by
9280 2011-05-06T07:13:19Z!eggert@cs.ucla.edu).
9281
8ff0ac3c 92822011-05-06 Paul Eggert <eggert@cs.ucla.edu>
c032b5f8 9283
4c4b566b
PE
9284 * image.c (Finit_image_library) [!HAVE_NTGUI]: Omit unused local.
9285
aab2b9b5
PE
9286 * term.c (vfatal): Remove stray call to va_end.
9287 It's not needed and the C Standard doesn't allow it here anyway.
9288
c378da0b
PE
9289 Use C99's va_copy to avoid undefined behavior on x86-64 GNU/Linux.
9290 * eval.c (verror): doprnt a copy of ap, not the original. (Bug#8545)
9291
288b08c7
PE
9292 * eval.c (verror): OK to create a string of up to MOST_POSITIVE_FIXNUM
9293 bytes.
9294
e3601888
PE
9295 * term.c: Don't include <stdarg.h>, as <lisp.h> does that.
9296
db6c0e74
PE
9297 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork clobbering.
9298
dd5963ea
PE
9299 * process.c (Fformat_network_address): Fix typo: args2 -> *args2.
9300
88c9450f
PE
9301 * xmenu.c (set_frame_menubar): Fix typo: int * -> int (3 times).
9302
2f9442b8
PE
9303 * coding.c (detect_coding_charset): Fix typo: * 2 -> *4 (Bug#8601).
9304
c032b5f8
PE
9305 * charset.h (struct charset.code_space): Now has 15 elements, not 16.
9306 * charset.c (Fdefine_charset_internal): Don't initialize
9307 charset.code_space[15]. The value was garbage, on hosts with
2d38271b 9308 32-bit int (Bug#8600).
a108c10b
PE
9309
9310 * lread.c (read_integer): Be more consistent with string-to-number.
9311 Use string_to_number to do the actual conversion; this avoids
9312 rounding errors and fixes some other screwups. Without this fix,
9313 for example, #x1fffffffffffffff was misread as -2305843009213693952.
9314 (digit_to_number): Move earlier, for benefit of read_integer.
9315 Return -1 if the digit is out of range for the base, -2 if it is
48e400f0 9316 not a digit in any supported base. (Bug#8602)
a108c10b 9317
ad5f9eea
PE
9318 * doprnt.c (doprnt): Support arbitrary pI values, such as "I64".
9319
aec1708a
PE
9320 * dispnew.c (scrolling_window): Return 1 if we scrolled,
9321 to match comment at start of function. This also removes a
9322 GCC warning about overflow in a 32+64-bit port.
9323
47be4ab5
PE
9324 * lisp.h (EMACS_INT, EMACS_UINT, BITS_PER_EMACS_INT, pI): Simplify.
9325
371cac43
PE
9326 * dbusbind.c: Do not use XPNTR on a value that may be an integer.
9327 Reported by Stefan Monnier in
9328 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00919.html>.
04f2d78b
CB
9329 (xd_remove_watch, Fdbus_init_bus, xd_read_queued_messages):
9330 Use SYMBOLP-guarded XSYMBOL, not XPNTR.
371cac43 9331
d01a7826
PE
9332 * lisp.h (EMACS_INTPTR): Remove. All uses changed to intptr_t.
9333 (EMACS_UINTPTR): Likewise, with uintptr_t.
9334
7fd47d5c
PE
9335 * lisp.h: Prefer 64-bit EMACS_INT if available.
9336 (EMACS_INT, EMACS_UINT, BITS_PER_EMACS_INT, pI): Define to 64-bit
9337 on 32-bit hosts that have 64-bit int, so that they can access
9338 large files.
122b0c86
PE
9339 However, temporarily disable this change unless the temporary
9340 symbol WIDE_EMACS_INT is defined.
7fd47d5c 9341
8727937b
PE
9342 * lread.c, process.c: Do not include <inttypes.h>; lisp.h does it now.
9343
8ac068ac
PE
9344 Prefer intptr_t/uintptr_t for integers the same widths as pointers.
9345 This removes an assumption that EMACS_INT and long are the same
9346 width as pointers. The assumption is true for Emacs porting targets
9347 now, but we want to make other targets possible.
9348 * lisp.h: Include <inttypes.h>, for INTPTR_MAX, UINTPTR_MAX.
9349 (EMACS_INTPTR, EMACS_UINTPTR): New macros.
9350 In the rest of the code, change types of integers that hold casted
9351 pointers to EMACS_INTPTR and EMACS_UINTPTR, systematically
9352 replacing EMACS_INT, long, EMACS_UINT, and unsigned long.
9353 (XTYPE): Don't cast arg to EMACS_UINT; normally is not needed.
9354 (XSET): Cast type of XTYPE arg to EMACS_INTPTR; it is needed here.
9355 No need to cast type when ORing.
9356 (XPNTR): Return a value of type EMACS_INTPTR or EMACS_UINTPTR.
9357 * alloc.c (lisp_align_malloc): Remove a no-longer-needed cast.
9358 * doc.c (store_function_docstring): Use EMACS_INTPTR, so as not to
9359 assume EMACS_INT is the same width as char *.
9360 * gtkutil.c (xg_gtk_scroll_destroy, xg_tool_bar_button_cb):
9361 (xg_tool_bar_callback, xg_tool_bar_help_callback, xg_make_tool_item):
9362 Remove no-longer-needed casts.
9363 (xg_create_scroll_bar, xg_tool_bar_button_cb, xg_tool_bar_callback):
9364 (xg_tool_bar_help_callback, xg_make_tool_item):
9365 Use EMACS_INTPTR to hold an integer
9366 that will be cast to void *; this can avoid a GCC warning
9367 if EMACS_INT is not the same width as void *.
9368 * menu.c (find_and_call_menu_selection): Remove no-longer-needed cast.
9369 * xdisp.c (display_echo_area_1, resize_mini_window_1):
9370 (current_message_1, set_message_1):
9371 Use a local to convert to proper width without a cast.
9372 * xmenu.c (dialog_selection_callback): Likewise.
9373
ede49d71
PE
9374 * sysdep.c (get_random): Don't assume EMACS_INT is no wider than long.
9375 Also, don't assume VALBITS / RAND_BITS is less than 5,
9376 and don't rely on undefined behavior when shifting a 1 left into
9377 the sign bit.
9378 * lisp.h (get_random): Change signature to match.
9379
2f30ecd0
PE
9380 * lread.c (hash_string): Use size_t, not int, for hash computation.
9381 Normally we prefer signed values; but hashing is special, because
9382 it's better to use unsigned division on hash table sizes so that
9383 the remainder is nonnegative. Also, size_t is the natural width
9384 for hashing into memory. The previous code used 'int', which doesn't
9385 retain enough info to hash well into very large tables.
9386 (oblookup, oblookup_last_bucket_number, Funintern): Likewise.
9387
2a866e7b
PE
9388 * dbusbind.c: Don't possibly lose pointer info when converting.
9389 (xd_remove_watch, Fdbus_init_bus, xd_read_queued_messages):
9390 Use XPNTR rather than XHASH, so that the high-order bits of
9391 the pointer aren't lost when converting through void *.
9392
51639eac
PE
9393 * eval.c (Fautoload): Don't double-shift a pointer.
9394
92394119
PE
9395 * fns.c (Frandom): Let EMACS_UINT be wider than unsigned long.
9396
dbdb9a7c
JB
93972011-05-06 Juanma Barranquero <lekktu@gmail.com>
9398
9399 * gnutls.c (DEF_GNUTLS_FN):
9400 * image.c (DEF_IMGLIB_FN): Make function pointers static.
9401
db7a0b4f
AS
94022011-05-05 Andreas Schwab <schwab@linux-m68k.org>
9403
9404 * lread.c (lisp_file_lexically_bound_p): Stop scanning at end
9405 marker. (Bug#8610)
9406
cd394be1 94072011-05-05 Eli Zaretskii <eliz@gnu.org>
fab624aa
EZ
9408
9409 * w32heap.c (allocate_heap) [USE_LISP_UNION_TYPE || USE_LSB_TAG]:
9410 New version that can reserve upto 2GB of heap space.
9411
f7ff1b0f 94122011-05-05 Chong Yidong <cyd@stupidchicken.com>
45cb8994
CY
9413
9414 * nsfns.m (Fns_read_file_name): Doc fix (Bug#8534).
9415
639c109b
TZ
94162011-05-05 Teodor Zlatanov <tzz@lifelogs.com>
9417
9418 * gnutls.c (fn_gnutls_certificate_set_x509_key_file): Add alias to
9419 `gnutls_certificate_set_x509_key_file'.
9420
d2127135
JB
94212011-05-05 Juanma Barranquero <lekktu@gmail.com>
9422
9423 * makefile.w32-in ($(BLD)/image.$(O), $(BLD)/process.$(O)):
9424 Update dependencies.
9425
e968f4f3
JB
94262011-05-04 Juanma Barranquero <lekktu@gmail.com>
9427
9428 * gnutls.h (emacs_gnutls_write, emacs_gnutls_read):
9429 * gnutls.c (emacs_gnutls_write, emacs_gnutls_read):
9430 Remove unused parameter `fildes'.
9431 * process.c (read_process_output, send_process): Don't pass it.
9432
84d358f0
JB
94332011-05-04 Juanma Barranquero <lekktu@gmail.com>
9434
9435 Fix previous change: the library cache is defined in w32.c.
9436 * image.c (CACHE_IMAGE_TYPE) [!HAVE_NTGUI]: Define to noop.
9437 (Finit_image_library): Wrap Vlibrary_cache on "#ifdef HAVE_NTGUI".
9438
0898ca10
JB
94392011-05-04 Juanma Barranquero <lekktu@gmail.com>
9440
9441 Implement dynamic loading of GnuTLS on Windows.
9442
9443 * gnutls.h (GNUTLS_EMACS_ERROR_NOT_LOADED): New macro.
9444 (emacs_gnutls_write, emacs_gnutls_read): Mark as extern.
9445 (emacs_gnutls_record_check_pending, emacs_gnutls_transport_set_errno):
9446 Declare.
9447
9448 * gnutls.c (Qgnutls_dll): Define.
9449 (DEF_GNUTLS_FN, LOAD_GNUTLS_FN): New macros.
9450 (gnutls_*): Declare function pointers.
9451 (init_gnutls_functions): New function to initialize function pointers.
9452 (emacs_gnutls_handshake, Fgnutls_error_string, Fgnutls_deinit)
9453 (emacs_gnutls_global_init, Fgnutls_bye): Use function pointers.
9454 (emacs_gnutls_record_check_pending, emacs_gnutls_transport_set_errno):
9455 Wrappers for gnutls_record_check_pending and gnutls_transport_set_errno.
9456 (emacs_gnutls_write, emacs_gnutls_read)
9457 (emacs_gnutls_handle_error, Fgnutls_error_fatalp)
9458 (Fgnutls_available_p): New function.
9459 (Fgnutls_boot): Call Fgnutls_available_p. Use function pointers.
9460 (syms_of_gnutls) <Qgnutls_dll>: Initialize and staticpro it.
9461 (syms_of_gnutls) <Sgnutls_available_p>: defsubr it.
9462
9463 * image.c: Include w32.h.
9464 (Vimage_type_cache): Delete.
9465 (syms_of_image) <Vimage_type_cache>: Don't initialize and staticpro it.
9466 (CACHE_IMAGE_TYPE, Finit_image_library): Use Vlibrary_cache instead.
9467 (w32_delayed_load): Move to w32.c.
9468
9469 * w32.h (VlibraryCache, QCloaded_from, w32_delayed_load): Declare.
9470
9471 * w32.c (QCloaded_from, Vlibrary_cache): Define.
9472 (w32_delayed_load): Move from image.c. When loading a library, record
9473 its filename in the :loaded-from property of the library id.
9474 (globals_of_w32) <QCloaded_from, Vlibrary_cache>:
9475 Initialize and staticpro them.
9476 (emacs_gnutls_pull, emacs_gnutls_push): Call emacs_gnutls_* functions.
9477
9478 * process.c: Include lisp.h before w32.h, not after.
9479 (wait_reading_process_output): Call emacs_gnutls_record_check_pending
9480 instead of gnutls_record_check_pending.
9481
9482 * callproc.c, emacs.c: Include lisp.h before w32.h, not after.
9483
ff4de4aa
TZ
94842011-05-04 Teodor Zlatanov <tzz@lifelogs.com>
9485
9486 * gnutls.c (Fgnutls_boot): Support :keylist and :crlfiles options
9487 instead of :keyfiles. Give GnuTLS the keylist and the CRL lists
9488 as passed in.
9489
abe95abb
JD
94902011-05-03 Jan Djärv <jan.h.d@swipnet.se>
9491
9492 * xterm.c (x_set_frame_alpha): Do not set property on anything
9493 else than FRAME_X_OUTER_WINDOW (Bug#8608).
9494
e16e55d4
JB
94952011-05-02 Juanma Barranquero <lekktu@gmail.com>
9496
9497 * sysdep.c (get_tty_size) [WINDOWSNT]: Implement. (Bug#8596)
9498
bafcf6a5
JB
94992011-05-02 Juanma Barranquero <lekktu@gmail.com>
9500
9501 * gnutls.c (Qgnutls_log_level, Qgnutls_code, Qgnutls_anon)
9502 (Qgnutls_x509pki, Qgnutls_e_interrupted, Qgnutls_e_again)
9503 (Qgnutls_e_invalid_session, Qgnutls_e_not_ready_for_handshake)
9504 (gnutls_global_initialized, Qgnutls_bootprop_priority)
9505 (Qgnutls_bootprop_trustfiles, Qgnutls_bootprop_keyfiles)
9506 (Qgnutls_bootprop_callbacks, Qgnutls_bootprop_loglevel)
9507 (Qgnutls_bootprop_hostname, Qgnutls_bootprop_verify_flags)
9508 (Qgnutls_bootprop_verify_error, Qgnutls_bootprop_verify_hostname_error)
9509 (Qgnutls_bootprop_callbacks_verify): Make static.
9510
e7a6747f
AS
95112011-05-01 Andreas Schwab <schwab@linux-m68k.org>
9512
19ed11ba
AS
9513 * callproc.c: Indentation fixup.
9514
e7a6747f 9515 * sysdep.c (wait_for_termination_1): Make static.
04f2d78b
CB
9516 (wait_for_termination, interruptible_wait_for_termination):
9517 Move after wait_for_termination_1.
e7a6747f 9518
1ef14cb4
LMI
95192011-05-01 Lars Magne Ingebrigtsen <larsi@gnus.org>
9520
9521 * sysdep.c (interruptible_wait_for_termination): New function
9522 which is like wait_for_termination, but allows keyboard
9523 interruptions.
9524
9525 * callproc.c (Fcall_process): Add (:file "file") as an option for
9526 the STDOUT buffer.
9527 (Fcall_process_region): Ditto.
9528
330d880c
EZ
95292011-04-30 Eli Zaretskii <eliz@gnu.org>
9530
8db90b73
EZ
9531 * dosfns.c (Fint86, Fdos_memget, Fdos_memput): Use `ASIZE (FOO)'
9532 rather than `XVECTOR (FOO)->size'.
9533
330d880c
EZ
9534 * process.c: Remove HAVE_INTTYPES_H condition from inclusion of
9535 inttypes.h, as a gnulib replacement is used if it not available in
9536 system headers.
9537
15cbd324
EZ
95382011-04-21 Eli Zaretskii <eliz@gnu.org>
9539
9540 Lift the MOST_POSITIVE_FIXNUM/4 limitation on visited files.
9541 * fileio.c (Finsert_file_contents): Don't limit file size to 1/4
9542 of MOST_POSITIVE_FIXNUM. (Bug#8528)
9543
9544 * coding.c (coding_alloc_by_realloc): Error out if destination
9545 will grow beyond MOST_POSITIVE_FIXNUM.
9546 (decode_coding_emacs_mule): Abort if there isn't enough place in
9547 charbuf for the composition carryover bytes. Reserve an extra
9548 space for up to 2 characters produced in a loop.
9549 (decode_coding_iso_2022): Abort if there isn't enough place in
9550 charbuf for the composition carryover bytes.
9551
95522011-04-21 Eli Zaretskii <eliz@gnu.org>
afda1437 9553
ae940cca
EZ
9554 * doprnt.c (doprnt) [!HAVE_LONG_LONG_INT]: Error out instead of
9555 aborting when %lld or %lll format is passed.
9556 [!HAVE_UNSIGNED_LONG_LONG_INT]: Error out instead of aborting when
9557 %llo or %llx format is passed. (Bug#8545)
9558
03ab8921
EZ
9559 * window.c (window_scroll_line_based): Use a marker instead of
9560 simple variables to record original value of point. (Bug#7952)
9561
afda1437
EZ
9562 * doprnt.c (doprnt): Fix the case where a multibyte sequence
9563 produced by %s or %c overflows available buffer space. (Bug#8545)
9564
f76dee0c
PE
95652011-04-28 Paul Eggert <eggert@cs.ucla.edu>
9566
9567 * doprnt.c (doprnt): Omit useless test; int overflow check (Bug#8545).
283cdbef 9568 (SIZE_MAX): Move defn after all includes, as they might #define it.
f76dee0c 9569
fdc5744d
JB
95702011-04-28 Juanma Barranquero <lekktu@gmail.com>
9571
9572 * w32.c (init_environment): Warn about defaulting HOME to C:\.
9573
638f053a
JB
95742011-04-28 Juanma Barranquero <lekktu@gmail.com>
9575
9576 * keyboard.c (Qdelayed_warnings_hook): Define.
9577 (command_loop_1): Run `delayed-warnings-hook'
9578 if Vdelayed_warnings_list is non-nil.
9579 (syms_of_keyboard) <delayed-warnings-hook>: DEFSYM it.
9580 (syms_of_keyboard) <delayed-warnings-list>: DEFVAR_LISP it.
9581
d178f871
EZ
95822011-04-28 Eli Zaretskii <eliz@gnu.org>
9583
9584 * doprnt.c (doprnt): Don't return value smaller than the buffer
9585 size if the message was truncated. (Bug#8545).
9586
b124fd93
JB
95872011-04-28 Juanma Barranquero <lekktu@gmail.com>
9588
9589 * w32fns.c (Fx_change_window_property, Fx_delete_window_property)
9590 (Fx_window_property): #if-0 the whole functions, not just the bodies.
9591
e810457d
PE
95922011-04-27 Paul Eggert <eggert@cs.ucla.edu>
9593
9594 * doprnt.c (doprnt): Support "ll" length modifier, for long long.
9595
ea51cceb
JB
95962011-04-27 Juanma Barranquero <lekktu@gmail.com>
9597
9598 * makefile.w32-in: Update dependencies.
9599
94dcfacf
EZ
96002011-04-27 Eli Zaretskii <eliz@gnu.org>
9601
9602 Improve `doprnt' and its usage. (Bug#8545)
9603 * doprnt.c (doprnt): Make sure `format' is never accessed beyond
9604 `format_end'. Remove support for %l as a conversion specifier.
9605 Don't use xrealloc. Improve diagnostics when the %l size modifier
9606 is used. Update the commentary.
9607
9608 * eval.c (verror): Simplify calculation of size_t.
9609
9610 * coding.c (Ffind_operation_coding_system): Fix diagnostic error
9611 messages.
9612
f61f41d7
PE
96132011-04-27 Yoshiaki Kasahara <kasahara@nc.kyushu-u.ac.jp> (tiny change)
9614
9615 * buffer.c (init_buffer) [USE_MMAP_FOR_BUFFERS]: Adjust to aliasing
9616 change.
9617
96fb4434
PE
96182011-04-27 Paul Eggert <eggert@cs.ucla.edu>
9619
9620 * nsmenu.m: Replace all uses of XVECTOR with ASIZE and AREF.
9621 This makes this file independent of the recent pseudovector change.
9622
671875da 96232011-04-26 Paul Eggert <eggert@cs.ucla.edu>
eab3844f 9624
69e9b5a3
PE
9625 * keyboard.c (handle_user_signal): Fix pointer signedness problem.
9626
b5f869a7 9627 * gnutls.c (emacs_gnutls_handle_error): Remove unused local.
7754e151 9628 (Fgnutls_boot): gnutls_certificate_verify_peers2 wants unsigned *.
8d4c3955 9629 Remove unused local.
c8926152 9630 (emacs_gnutls_write): Don't use uninitialized rtnval if nbyte <= 0.
080e5a8d 9631
841a1577 9632 * lisp.h: Fix a problem with aliasing and vector headers. (Bug#8546)
04f2d78b
CB
9633 GCC 4.6.0 optimizes based on type-based alias analysis.
9634 For example, if b is of type struct buffer * and v of type struct
eab3844f
PE
9635 Lisp_Vector *, then gcc -O2 was incorrectly assuming that &b->size
9636 != &v->size, and therefore "v->size = 1; b->size = 2; return
9637 v->size;" must therefore return 1. This assumption is incorrect
9638 for Emacs, since it type-puns struct Lisp_Vector * with many other
9639 types. To fix this problem, this patch adds a new type struct
f904488f 9640 vectorlike_header that documents the constraints on layout of vectors
eab3844f
PE
9641 and pseudovectors, and helps optimizing compilers not get fooled
9642 by Emacs's type punning. It also adds the macros XSETTYPED_PVECTYPE
9643 XSETTYPED_PSEUDOVECTOR, TYPED_PSEUDOVECTORP, for similar reasons.
f904488f
PE
9644 * lisp.h (XSETTYPED_PVECTYPE): New macro, specifying the name of
9645 the size member.
eab3844f
PE
9646 (XSETPVECTYPE): Rewrite in terms of new macro.
9647 (XSETPVECTYPESIZE): New macro, specifying both type and size.
9648 This is a bit clearer, and further avoids the possibility of
9649 undesirable aliasing.
9650 (XSETTYPED_PSEUDOVECTOR): New macro, specifying the size.
f904488f 9651 (XSETPSEUDOVECTOR): Rewrite in terms of XSETTYPED_PSEUDOVECTOR.
eab3844f
PE
9652 (XSETSUBR): Rewrite in terms of XSETTYPED_PSEUDOVECTOR and XSIZE,
9653 since Lisp_Subr is a special case (no "next" field).
04f2d78b
CB
9654 (ASIZE): Now uses header.size rather than size.
9655 All previous uses of XVECTOR (foo)->size replaced to use this macro,
f904488f
PE
9656 to avoid the hassle of writing XVECTOR (foo)->header.size.
9657 (struct vectorlike_header): New type.
eab3844f
PE
9658 (TYPED_PSEUDOVECTORP): New macro, also specifying the C type of the
9659 object, to help avoid aliasing.
9660 (PSEUDOVECTORP): Rewrite in terms of TYPED_PSEUDOVECTORP.
9661 (SUBRP): Likewise, since Lisp_Subr is a special case.
9662 * lisp.h (struct Lisp_Vector, struct Lisp_Char_Table):
9663 (struct Lisp_Sub_Char_Table, struct Lisp_Bool_Vector):
9664 (struct Lisp_Hash_Table): Combine first two members into a single
f904488f 9665 struct vectorlike_header member. All uses of "size" and "next" members
eab3844f
PE
9666 changed to be "header.size" and "header.next".
9667 * buffer.h (struct buffer): Likewise.
9668 * font.h (struct font_spec, struct font_entity, struct font): Likewise.
9669 * frame.h (struct frame): Likewise.
9670 * process.h (struct Lisp_Process): Likewise.
9671 * termhooks.h (struct terminal): Likewise.
9672 * window.c (struct save_window_data, struct saved_window): Likewise.
9673 * window.h (struct window): Likewise.
9674 * alloc.c (allocate_buffer, Fmake_bool_vector, allocate_pseudovector):
9675 Use XSETPVECTYPESIZE, not XSETPVECTYPE, to avoid aliasing problems.
9676 * buffer.c (init_buffer_once): Likewise.
9677 * lread.c (defsubr): Use XSETTYPED_PVECTYPE, since Lisp_Subr is a
9678 special case.
9679 * process.c (Fformat_network_address): Use local var for size,
9680 for brevity.
9681
0df1eac5
PE
9682 * bytecode.c (exec_byte_code): Don't use XVECTOR before CHECK_VECTOR.
9683
847ab9d1 9684 Make the Lisp reader and string-to-float more consistent (Bug#8525)
452f4150
PE
9685 * data.c (atof): Remove decl; no longer used or needed.
9686 (digit_to_number): Move to lread.c.
9687 (Fstring_to_number): Use new string_to_number function, to be
9688 consistent with how the Lisp reader treats infinities and NaNs.
9689 Do not assume that floating-point numbers represent EMACS_INT
9690 without losing information; this is not true on most 64-bit hosts.
9691 Avoid double-rounding errors, by insisting on integers when
9692 parsing non-base-10 numbers, as the documentation specifies.
9693 * lisp.h (string_to_number): New decl, replacing ...
9694 (isfloat_string): Remove.
bc0a5c13 9695 * lread.c: Include <inttypes.h>, for uintmax_t and strtoumax.
d78050d6 9696 (read1): Do not accept +. and -. as integers; this
452f4150
PE
9697 appears to have been a coding error. Similarly, do not accept
9698 strings like +-1e0 as floating point numbers. Do not report
9699 overflow for integer overflows unless the base is not 10 which
9700 means we have no simple and reliable way to continue.
9701 Break out the floating-point parsing into a new
9702 function string_to_number, so that Fstring_to_number parses
9703 floating point numbers consistently with the Lisp reader.
04f2d78b 9704 (digit_to_number): Move here from data.c. Make it static inline.
452f4150
PE
9705 (E_CHAR, EXP_INT): Remove, replacing with ...
9706 (E_EXP): New macro, to solve the "1.0e+" problem mentioned below.
9707 (string_to_number): New function, replacing isfloat_string.
9708 This function checks for valid syntax and produces the resulting
9709 Lisp float number too. Rework it so that string-to-number
bc0a5c13 9710 no longer mishandles examples like "1.0e+". Use strtoumax,
d78050d6
PE
9711 so that overflow for non-base-10 numbers is reported only when
9712 there's no portable and simple way to convert to floating point.
452f4150 9713
67769ffc
PE
9714 * textprop.c (set_text_properties_1): Rewrite for clarity,
9715 and to avoid GCC warning about integer overflow.
9716
c20db43f
PE
9717 * intervals.h (struct interval): Use EMACS_INT for members
9718 where EMACS_UINT might cause problems. See
9719 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00514.html>.
9720 (CHECK_TOTAL_LENGTH): Remove cast to EMACS_INT; no longer needed.
9721 * intervals.c (interval_deletion_adjustment): Now returns EMACS_INT.
9722 All uses changed.
37aa2f85
PE
9723 (offset_intervals): Tell GCC not to worry about length overflow
9724 when negating a negative length.
c20db43f 9725
2538aa2f
PE
9726 * alloc.c (overrun_check_malloc, overrun_check_realloc): Now static.
9727 (overrun_check_free): Likewise.
9728
f2d3008d
PE
9729 * alloc.c (SDATA_SIZE) [!GC_CHECK_STRING_BYTES]: Avoid runtime check
9730 in the common case where SDATA_DATA_OFFSET is a multiple of Emacs
9731 word size.
9732
ec8df744
PE
9733 * gnutls.c: Fix problems found by GCC 4.6.0 on Ubuntu 10.10.
9734 (gnutls_make_error): Rename local to avoid shadowing.
9735 (gnutls_emacs_global_deinit): ifdef out; not used.
9736 (Fgnutls_boot): Use const for pointer to readonly storage.
9737 Comment out unused local. Fix pointer signedness problems.
9738
640ee02d
PE
9739 * lread.c (openp): Don't stuff size_t into an 'int'.
9740 Use <= on length, not < on length + 1, to avoid GCC 4.6.0 warning
9741 about possible signed overflow.
9742
6048fb2a
PE
9743 * gtkutil.c: Fix problems found by GCC 4.6.0 on Ubuntu 10.10.
9744 (GDK_KEY_g): Don't define if already defined.
9745 (xg_prepare_tooltip): Avoid pointer signedness problem.
9746 (xg_set_toolkit_scroll_bar_thumb): Redo to avoid two casts.
9747
fa3c87e1
PE
9748 * process.c (Fnetwork_interface_info): Avoid left-shift undefined
9749 behavior with 1 << 31. GCC 4.6.0 warns about this on 32-bit hosts.
9750
2172544b
PE
9751 * xfns.c (Fx_window_property): Simplify a bit,
9752 to make a bit faster and to avoid GCC 4.6.0 warning.
9753 * xselect.c (x_get_window_property, x_handle_dnd_message): Likewise.
9754
9b821a21
PE
9755 * fns.c (internal_equal): Don't assume size_t fits in int.
9756
3c616cfa
PE
9757 * alloc.c (compact_small_strings): Tighten assertion a little.
9758
c2982e87
PE
9759 Replace pEd with more-general pI, and fix some printf arg casts.
9760 * lisp.h (pI): New macro, generalizing old pEd macro to other
9761 conversion specifiers. For example, use "...%"pI"d..." rather
9762 than "...%"pEd"...".
9763 (pEd): Remove. All uses replaced with similar uses of pI.
61bdb816 9764 * m/amdx86-64.h, m/ia64.h, m/ibms390x.h: Likewise.
c2982e87
PE
9765 * alloc.c (check_pure_size): Don't overflow by converting size to int.
9766 * bidi.c (bidi_dump_cached_states): Use pI to avoid cast.
9767 * data.c (Fnumber_to_string): Use pI instead of if-then-else-abort.
9768 * dbusbind.c (xd_append_arg): Use pI to avoid cast.
9769 (Fdbus_method_return_internal, Fdbus_method_error_internal): Likewise.
9770 * font.c (font_unparse_xlfd): Avoid potential buffer overrun on
9771 64-bit hosts.
9772 (font_unparse_xlfd, font_unparse_fcname): Use pI to avoid casts.
9773 * keyboard.c (record_char, modify_event_symbol): Use pI to avoid casts.
9774 * print.c (safe_debug_print, print_object): Likewise.
9775 (print_object): Don't overflow by converting EMACS_INT or EMACS_UINT
9776 to int.
6f04d126
PE
9777 Use pI instead of if-then-else-abort. Use %p to avoid casts,
9778 avoiding the 0 flag, which is not portable.
c2982e87
PE
9779 * process.c (Fmake_network_process): Use pI to avoid cast.
9780 * region-cache.c (pp_cache): Likewise.
9781 * xdisp.c (decode_mode_spec): Likewise.
9782 * xrdb.c (x_load_resources) [USE_MOTIF]: Use pI to avoid undefined
9783 behavior on 64-bit hosts with printf arg.
6f04d126 9784 * xselect.c (x_queue_event): Use %p to avoid casts, avoiding 0 flag.
c2982e87
PE
9785 (x_stop_queuing_selection_requests): Likewise.
9786 (x_get_window_property): Don't truncate byte count to an 'int'
9787 when tracing.
0b432f21 9788
5e073ec7
PE
9789 * frame.c (frame_name_fnn_p): Get rid of strtol, which isn't right
9790 here, since it parses constructs like leading '-' and spaces,
9791 which are not wanted; and it overflows with large numbers.
9792 Instead, simply match F[0-9]+, which is what is wanted anyway.
9793
36372bf9
PE
9794 * alloc.c: Remove unportable assumptions about struct layout.
9795 (SDATA_SELECTOR, SDATA_DATA_OFFSET): New macros.
9796 (SDATA_OF_STRING, SDATA_SIZE, allocate_string_data):
9797 (allocate_vectorlike, make_pure_vector): Use the new macros,
9798 plus offsetof, to remove unportable assumptions about struct layout.
9799 These assumptions hold on all porting targets that I know of, but
9800 they are not guaranteed, they're easy to remove, and removing them
9801 makes further changes easier.
9802
0b432f21
PE
9803 * alloc.c (BLOCK BYTES): Fix typo by changing "ablock" to "ablocks".
9804 This doesn't fix a bug but makes the code clearer.
bfd1c781
PE
9805 (string_overrun_cookie): Now const. Use initializers that
9806 don't formally overflow signed char, to avoid warnings.
000098c1
PE
9807 (allocate_string_data) [GC_CHECK_STRING_OVERRUN]: Fix typo that
9808 can cause Emacs to crash when string overrun checking is enabled.
c7bda33c
PE
9809 (allocate_buffer): Don't assume sizeof (struct buffer) is a
9810 multiple of sizeof (EMACS_INT); it need not be, if
9811 alignof(EMACS_INT) < sizeof (EMACS_INT).
d0f4e1f5 9812 (check_sblock, check_string_bytes, check_string_free_list): Protoize.
0b432f21 9813
895009e1
JB
98142011-04-26 Juanma Barranquero <lekktu@gmail.com>
9815
9816 * keyboard.c (QCrtl): Rename from Qrtl. All uses changed.
9817
6a7a1b0b
TZ
98182011-04-26 Teodor Zlatanov <tzz@lifelogs.com>
9819
9820 * gnutls.c (emacs_gnutls_handshake): Return an error if we're not
b5f869a7 9821 supposed to be handshaking. (Bug#8556)
6a7a1b0b
TZ
9822 Reported by Paul Eggert <eggert@cs.ucla.edu>.
9823
841a1577 98242011-04-26 Daniel Colascione <dan.colascione@gmail.com>
0438ce91
DC
9825
9826 * lisp.h (Qdebug): List symbol.
895009e1 9827 * eval.c (Qdebug): Restore global linkage.
0438ce91
DC
9828 * keyboard.c (debug-on-event): New variable.
9829 (handle_user_signal): Break into debugger when debug-on-event
9830 matches the current signal symbol.
9831
f2d3ba6f
DN
98322011-04-25 Dan Nicolaescu <dann@ics.uci.edu>
9833
9834 * alloc.c (check_sblock, check_string_bytes)
9835 (check_string_free_list): Convert to standard C.
9836
42ce4c63
TZ
98372011-04-25 Teodor Zlatanov <tzz@lifelogs.com>
9838
9839 * w32.c (emacs_gnutls_push): Fix typo.
9840
825cd63c
EZ
98412011-04-25 Eli Zaretskii <eliz@gnu.org>
9842
fb11d64d
EZ
9843 * gnutls.c (emacs_gnutls_handshake): Avoid compiler warnings about
9844 "cast to pointer from integer of different size".
9845
825cd63c
EZ
9846 Improve doprnt and its use in verror. (Bug#8545)
9847 * doprnt.c (doprnt): Document the set of format control sequences
9848 supported by the function. Use SAFE_ALLOCA instead of always
9849 using `alloca'.
9850
9851 * eval.c (verror): Don't limit the buffer size at size_max-1, that
9852 is one byte too soon. Don't use xrealloc; instead xfree and
9853 xmalloc anew.
9854
e061a11b
TZ
98552011-04-24 Teodor Zlatanov <tzz@lifelogs.com>
9856
9857 * gnutls.h: Add GNUTLS_STAGE_CALLBACKS enum to denote we're in the
9858 callbacks stage.
9859
9860 * gnutls.c: Renamed global_initialized to
9861 gnutls_global_initialized. Added internals for the
9862 :verify-hostname-error, :verify-error, and :verify-flags
9863 parameters of `gnutls-boot' and documented those parameters in the
9864 docstring. Start callback support.
9173deec
JB
9865 (emacs_gnutls_handshake): Add Woe32 support. Retry handshake
9866 unless a fatal error occurred. Call gnutls_alert_send_appropriate
9867 on error. Return error code.
e061a11b
TZ
9868 (emacs_gnutls_write): Call emacs_gnutls_handle_error.
9869 (emacs_gnutls_read): Likewise.
9870 (Fgnutls_boot): Return handshake error code.
9871 (emacs_gnutls_handle_error): New function.
9872 (wsaerror_to_errno): Likewise.
9873
9874 * w32.h (emacs_gnutls_pull): Add prototype.
9875 (emacs_gnutls_push): Likewise.
9876
9877 * w32.c (emacs_gnutls_pull): New function for GnuTLS on Woe32.
9878 (emacs_gnutls_push): Likewise.
9879
98802011-04-24 Claudio Bley <claudio.bley@gmail.com> (tiny change)
9881
9882 * process.c (wait_reading_process_output): Check if GnuTLS
9883 buffered some data internally if no FDs are set for TLS
9884 connections.
9885
9886 * makefile.w32-in (OBJ2): Add gnutls.$(O).
9887 (LIBS): Link to USER_LIBS.
9888 ($(BLD)/gnutls.$(0)): New target.
9889
fa6996bc
EZ
98902011-04-24 Eli Zaretskii <eliz@gnu.org>
9891
eb35682e
EZ
9892 * xdisp.c (handle_single_display_spec): Rename the
9893 display_replaced_before_p argument into display_replaced_p, to
9894 make it consistent with the commentary. Fix typos in the
9895 commentary.
9896
e2ad650c
EZ
9897 * textprop.c (syms_of_textprop): Remove dead code.
9898 (copy_text_properties): Delete obsolete commentary about an
9899 interface that was deleted long ago. Fix typos in the description
9900 of arguments.
9901
1b2de274
EZ
9902 * msdos.c (XMenuActivate, XMenuAddSelection): Adjust argument list
9903 to changes in oldXMenu/XMenu.h from 2011-04-16.
9904 <menu_help_message, prev_menu_help_message>: Constify.
9905 (IT_menu_make_room): menu->help_text is now `const char **';
9906 adjust.
9907
9908 * msdos.h (XMenuActivate, XMenuAddSelection): Adjust prototypes
9909 to changes in oldXMenu/XMenu.h from 2011-04-16.
9910 (struct XMenu): Declare `help_text' `const char **'.
9911
9912 * xfaces.c <Qunspecified>: Make extern again.
9913
9914 * syntax.c: Include sys/types.h before including regex.h, as
75f1671a 9915 required by POSIX.
1b2de274 9916
762b15be
EZ
9917 * doc.c (get_doc_string): Improve the format passed to `error'.
9918
9919 * doprnt.c (doprnt): Improve commentary.
9920
9921 * term.c (init_tty) [MSDOS]: Fix 1st argument to maybe_fatal.
9922
9923 * Makefile.in (TAGS): Depend on $(M_FILE) and $(S_FILE), and scan
9924 them with etags.
9925
f1052e5d
EZ
9926 * makefile.w32-in (globals.h): Add a dummy recipe, to make any
9927 changes in globals.h immediately force recompilation.
762b15be
EZ
9928 (TAGS): Depend on $(CURDIR)/m/intel386.h and
9929 $(CURDIR)/s/ms-w32.h.
9930 (TAGS-gmake): Scan $(CURDIR)/m/intel386.h and $(CURDIR)/s/ms-w32.h.
f1052e5d 9931
fa6996bc
EZ
9932 * character.c (Fchar_direction): Function deleted.
9933 (syms_of_character): Don't defsubr it.
9934 <char-direction-table>: Deleted.
9935
e6c3da20
EZ
99362011-04-23 Eli Zaretskii <eliz@gnu.org>
9937
9938 Fix doprnt so it could be used again safely in `verror'. (Bug#8435)
9939 * doprnt.c: Include limits.h.
9940 (SIZE_MAX): New macro.
04f2d78b
CB
9941 (doprnt): Return a size_t value. 2nd arg is now size_t.
9942 Many local variables are now size_t instead of int or unsigned.
e6c3da20
EZ
9943 Improve overflow protection. Support `l' modifier for integer
9944 conversions. Support %l conversion. Don't assume an EMACS_INT
9945 argument for integer conversions and for %c.
9946
9947 * lisp.h (doprnt): Restore prototype.
9948
9949 * makefile.w32-in ($(BLD)/callint.$(O)): Depend on
9950 $(SRC)/character.h.
9951
9952 * Makefile.in (base_obj): Add back doprnt.o.
9953
9954 * deps.mk (doprnt.o): Add back prerequisites.
9955 (callint.o): Depend on character.h.
9956
9957 * eval.c (internal_lisp_condition_case): Include the handler
9958 representation in the error message.
9959 (verror): Call doprnt instead of vsnprintf. Fix an off-by-one bug
9960 when breaking from the loop.
9961
9962 * xdisp.c (vmessage): Call doprnt instead of vsnprintf.
9963
9964 * callint.c (Fcall_interactively): When displaying error message
9965 about invalid control letter, pass the character's codepoint, not
9966 a pointer to its multibyte form. Improve display of the character
9967 in octal and display also its hex code.
9968
9969 * character.c (char_string): Use %x to display the (unsigned)
9970 codepoint of an invalid character, to avoid displaying a bogus
9971 negative value.
9972
9973 * font.c (check_otf_features): Pass SDATA of SYMBOL_NAME to
9974 `error', not SYMBOL_NAME itself.
9975
9976 * coding.c (Fencode_sjis_char, Fencode_big5_char): Use %c for
9977 character arguments to `error'.
9978
9979 * charset.c (check_iso_charset_parameter): Fix incorrect argument
9980 to `error' in error message about FINAL_CHAR argument. Make sure
9981 FINAL_CHAR is a character, and use %c when it is passed as
9982 argument to `error'.
9983
4ffd0d6b 99842011-04-23 Eli Zaretskii <eliz@gnu.org>
97a93095
EZ
9985
9986 * s/ms-w32.h (localtime): Redirect to sys_localtime.
9987
9988 * w32.c: Include <time.h>.
9989 (sys_localtime): New function.
9990
4ffd0d6b 99912011-04-23 Chong Yidong <cyd@stupidchicken.com>
c17819f4
CY
9992
9993 * xdisp.c (init_xdisp): Initialize echo_area_window (Bug#6451).
9994
4ffd0d6b 9995 * buffer.c (syms_of_buffer): Doc fix (Bug#6902).
aac0c6e3 9996
4ffd0d6b 99972011-04-23 Samuel Thibault <sthibault@debian.org> (tiny change)
aac0c6e3 9998
4ffd0d6b
GM
9999 * sysdep.c (wait_for_termination): On GNU Hurd, kill returns -1 on
10000 zombies (Bug#8467).
aac0c6e3 10001
04c56954
EZ
100022011-04-19 Eli Zaretskii <eliz@gnu.org>
10003
10004 * syntax.h (SETUP_SYNTAX_TABLE_FOR_OBJECT): Fix setting of
10005 gl_state.e_property when gl_state.object is Qt.
10006
10007 * insdel.c (make_gap_larger): Remove limitation of buffer size
10008 to <= INT_MAX.
10009
16a43933
CY
100102011-04-18 Chong Yidong <cyd@stupidchicken.com>
10011
10012 * xdisp.c (lookup_glyphless_char_display)
10013 (produce_glyphless_glyph): Handle cons cell entry in
10014 glyphless-char-display.
10015 (Vglyphless_char_display): Document it.
10016
10017 * term.c (produce_glyphless_glyph): Handle cons cell entry in
10018 glyphless-char-display.
10019
4581706e
CY
100202011-04-17 Chong Yidong <cyd@stupidchicken.com>
10021
10022 * xdisp.c (get_next_display_element): Remove unnecessary ifdefs.
10023
10024 * termhooks.h (FRAME_WINDOW_P): Remove duplicated definitions.
10025
10026 * dispextern.h (FACE_SUITABLE_FOR_ASCII_CHAR_P): Add missing
10027 definition for no-X builds.
10028
4887c6e2 100292011-04-16 Paul Eggert <eggert@cs.ucla.edu>
764430a3 10030
fd35b6f9
PE
10031 Static checks with GCC 4.6.0 and non-default toolkits.
10032
5c1ccb01
PE
10033 * s/sol2-6.h, s/unixware.h (PTY_TTY_NAME_SPRINTF): Protoize decl.
10034
006c5daa
PE
10035 * process.c (keyboard_bit_set): Define only if SIGIO.
10036 (send_process_trap): Mark it with NO_RETURN if it doesn't return.
10037 (send_process): Repair possible setjmp clobbering.
10038
efc736d3
PE
10039 * s/usg5-4-common.h (SETUP_SLAVE_PTY): Don't pass extra arg to 'fatal'.
10040
4e2fe2e6
PE
10041 * eval.c: Include <stdio.h>, for vsnprintf on non-GNU/Linux hosts.
10042
f97334a2
PE
10043 * data.c (arith_error): Mark with NO_RETURN if it doesn't return.
10044
4e75f29d
PE
10045 * alloc.c (bytes_used_when_full, SPARE_MEMORY, BYTES_USED):
10046 Define only if needed.
10047
90efadd1
PE
10048 * sysdep.c (_FILE_OFFSET_BITS): Make this hack even uglier
10049 by pacifying GCC about it. Maybe it's time to retire it?
875975e9 10050 * xfaces.c (USG, __TIMEVAL__): Likewise.
90efadd1 10051
3c647824
PE
10052 * dispextern.h (struct redisplay_interface): Rename param
10053 to avoid shadowing.
e264f262 10054 * termhooks.h (struct terminal): Likewise.
761383f4 10055 * xterm.c (xembed_send_message): Likewise.
3c647824 10056
b58c5c4a
PE
10057 * insdel.c (make_gap_smaller): Define only if
10058 USE_MMAP_FOR_BUFFERS || REL_ALLOC || DOUG_LEA_MALLOC.
10059
cad59032
PE
10060 * keyboard.c (read_char): Make a var volatile so longjmp won't clobber
10061 it.
10062
c339dc2e
PE
10063 * emacs.c (MAX_HEAP_BSS_DIFF, my_edata): Move to where they're used,
10064 so that we aren't warned about unused symbols.
10065
91a3e27b
PE
10066 * xfns.c (Fx_file_dialog): Rename local to avoid shadowing.
10067
399c71d3 10068 * xdisp.c (x_produce_glyphs): Mark var as initialized (Bug#8512).
7a3fb125 10069
8ffc96f5
PE
10070 * xfns.c (x_real_positions): Mark locals as initialized.
10071
eef9bc79
PE
10072 * xmenu.c (xmenu_show): Don't use uninitialized vars.
10073
098db9dd
PE
10074 * xterm.c: Fix problems found by static analysis with other toolkits.
10075 (toolkit_scroll_bar_interaction): Define and use only if USE_X_TOOLKIT.
dda3aedd
PE
10076 (x_dispatch_event): Declare static if USE_GTK, and
10077 define if USE_GTK || USE_X_TOOLKIT.
098db9dd 10078 (SET_SAVED_BUTTON_EVENT): Define only if USE_X_TOOLKIT || USE_GTK.
dda3aedd 10079 * xterm.h (x_dispatch_event): Extern only if USE_X_TOOLKIT.
841a1577
JB
10080 * xterm.c, xterm.h (x_mouse_leave): Bring this function back, but only
10081 if defined HAVE_MENUS && !defined USE_X_TOOLKIT && !defined USE_GTK.
098db9dd 10082
eb18f6cc
PE
10083 * xmenu.c (menu_help_callback): Pointer type fixes.
10084 Use const pointers when pointing at readonly data. Avoid pointer
10085 signedness clashes.
10086 (FALSE): Remove unused macro.
10087 (update_frame_menubar): Remove unused decl.
10088
1fe72bf8
PE
10089 * xfns.c (Fx_hide_tip): Move locals to avoid shadowing.
10090
60d9e1db
PE
10091 * menu.c (push_submenu_start, push_submenu_end): Do not define unless
10092 USE_X_TOOLKIT || USE_GTK || HAVE_NS || defined HAVE_NTGUI.
10093 (single_menu_item): Rename local to avoid shadowing.
10094
39261c26
PE
10095 * keyboard.c (make_lispy_event): Remove unused local var.
10096
018c5e19
PE
10097 * frame.c, frame.h (x_get_resource_string): Bring this back, but
10098 only if HAVE_X_WINDOWS && !USE_X_TOOLKIT.
10099
63d2b86e
PE
10100 * bitmaps: Change bitmaps from unsigned char back to the X11
10101 compatible char. Avoid the old compiler warnings about
10102 out-of-range initializers by using, for example, '\xab' rather
10103 than 0xab.
10104
aefd87e1
PE
10105 * xgselect.c (xgselect_initialize): Check vs interface
10106 even if ! (defined (USE_GTK) || defined (HAVE_GCONF)).
10107
bf501fb9
PE
10108 * xmenu.c (xmenu_show): Rename parm to avoid shadowing.
10109
e9829fdf
PE
10110 * xterm.c (x_create_toolkit_scroll_bar): Use const * for pointers
10111 to read-only memory.
10112
1086c095
PE
10113 * fns.c (vector): Remove; this old hack is no longer needed.
10114
2baccd04 10115 * xsmfns.c (create_client_leader_window): Rename shadowing arg.
401f10cb 10116 Remove unused var.
dde42981 10117 (gdk_x11_set_sm_client_id) [!USE_GTK]: Don't define.
2baccd04 10118
72391843 10119 * xrdb.c (x_load_resources): Omit unused local.
3565b346 10120
436c16df 10121 * xfns.c (free_frame_menubar, atof): Remove duplicate decls.
8a94ea33 10122 (x_window): Rename locals to avoid shadowing.
dc5ddd85 10123 (USG): Use the kludged USG macro, to pacify gcc.
436c16df 10124
92bb796d 10125 * xterm.c (x_alloc_nearest_color_for_widget): Remove; unused.
bbbef9e1 10126 (x_term_init): Remove local to avoid shadowing.
92bb796d 10127
764430a3 10128 * xfns.c, xterm.c (_XEditResCheckMessages): Protoize decl.
4887c6e2
PE
10129
10130 * xdisp.c, dispextern.h (set_vertical_scroll_bar): Now extern if
10131 USE_TOOLKIT_SCROLL_BARS && !USE_GTK, as xterm.c needs it then.
10132
d1dfb56c
EZ
101332011-04-16 Eli Zaretskii <eliz@gnu.org>
10134
c4354cb4
EZ
10135 * gnutls.c (Fgnutls_boot): Don't pass Lisp_Object to `error'.
10136
d1dfb56c
EZ
10137 Fix regex.c, syntax.c and friends for buffers > 2GB.
10138 * syntax.h (struct gl_state_s): Declare character position members
10139 EMACS_INT.
10140
10141 * syntax.c (update_syntax_table): Declare 2nd argument EMACS_INT.
10142
04f2d78b
CB
10143 * textprop.c (verify_interval_modification, interval_of):
10144 Declare arguments EMACS_INT.
d1dfb56c
EZ
10145
10146 * intervals.c (adjust_intervals_for_insertion): Declare arguments
10147 EMACS_INT.
10148
10149 * intervals.h (CHECK_TOTAL_LENGTH): Cast to EMACS_INT, not `int'.
10150
10151 * indent.c (Fvertical_motion): Local variable it_start is now
10152 EMACS_INT.
10153
10154 * regex.c (re_match, re_match_2, re_match_2_internal)
10155 (bcmp_translate, regcomp, regexec, print_double_string)
10156 (group_in_compile_stack, re_search, re_search_2, regex_compile)
10157 (re_compile_pattern, re_exec): Declare arguments and local
10158 variables `size_t' and `ssize_t' and return values `regoff_t', as
10159 appropriate.
10160 (POP_FAILURE_REG_OR_COUNT) <pfreg>: Declare `long'.
10161 (CHECK_INFINITE_LOOP) <failure>: Declare `ssize_t'.
10162 <compile_stack_type>: `size' and `avail' are now `size_t'.
10163
10164 * regex.h <regoff_t>: Use ssize_t, not int.
10165 (re_search, re_search_2, re_match, re_match_2): Arguments that
10166 specify buffer/string position and length are now ssize_t and
10167 size_t. Return type is regoff_t.
10168
613052cd
BK
101692011-04-16 Ben Key <bkey76@gmail.com>
10170
10171 * nsfont.m: Fixed bugs in ns_get_family and
10172 ns_descriptor_to_entity that were caused by using free to
10173 deallocate memory blocks that were allocated by xmalloc (via
10174 xstrdup). This caused Emacs to crash when compiled with
10175 XMALLOC_OVERRUN_CHECK defined (when Emacs was configured with
10176 --enable-checking=xmallocoverrun). xfree is now used to
10177 deallocate these memory blocks.
10178
4170f62f 101792011-04-15 Paul Eggert <eggert@cs.ucla.edu>
3e047f51 10180
71b41406
PE
10181 * sysdep.c (emacs_read): Remove unnecessary check vs MAX_RW_COUNT.
10182
9587a89d
PE
10183 emacs_write: Accept and return EMACS_INT for sizes.
10184 See http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00514.html
10185 et seq.
10186 * gnutls.c, gnutls.h (emacs_gnutls_read, emacs_gnutls_write):
10187 Accept and return EMACS_INT.
10188 (emacs_gnutls_write): Return the number of bytes written on
10189 partial writes.
10190 * sysdep.c, lisp.h (emacs_read, emacs_write): Likewise.
273a5f82
PE
10191 (emacs_read, emacs_write): Remove check for negative size, as the
10192 Emacs source code has been audited now.
9587a89d
PE
10193 * sysdep.c (MAX_RW_COUNT): New macro, to work around kernel bugs.
10194 (emacs_read, emacs_write): Use it.
273a5f82
PE
10195 * process.c (send_process): Adjust to the new signatures of
10196 emacs_write and emacs_gnutls_write. Do not attempt to store
10197 a byte offset into an 'int'; it might overflow.
9587a89d 10198 See http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00483.html
273a5f82 10199
3e047f51
PE
10200 * sound.c: Don't assume sizes fit in 'int'.
10201 (struct sound_device.period_size, alsa_period_size):
9c3c56a7 10202 Return EMACS_INT, not int.
3e047f51 10203 (struct sound_device.write, vox_write, alsa_write):
9c3c56a7
PE
10204 Accept EMACS_INT, not int.
10205 (wav_play, au_play): Use EMACS_INT to store sizes and to
3e047f51
PE
10206 record read return values.
10207
cc39a9db
BK
102082011-04-15 Ben Key <bkey76@gmail.com>
10209
c9d0ec6d
JB
10210 * keyboard.c (Qundefined): Don't declare static since it is used
10211 in nsfns.m.
10212 * xfaces.c (Qbold, Qexpanded, Qitalic, Qcondensed): Don't declare
10213 static since they are used in nsfont.m.
cc39a9db 10214
6c60eb9f
SM
102152011-04-15 Stefan Monnier <monnier@iro.umontreal.ca>
10216
10217 * process.c (Qprocessp): Don't declare static.
10218 * lisp.h (Qprocessp): Declare again.
10219
7990b61a
JB
102202011-04-15 Juanma Barranquero <lekktu@gmail.com>
10221
10222 * font.c (Qopentype): Don't make static (used from w32uniscribe.c).
10223
5d4cb038
PE
102242011-04-14 Paul Eggert <eggert@cs.ucla.edu>
10225
8bd7b830 10226 Improve C-level modularity by making more things 'static'.
cd64ea1d 10227
e3b27b31
PE
10228 Don't publish debugger-only interfaces to other modules.
10229 * lisp.h (safe_debug_print, debug_output_compilation_hack):
10230 (verify_bytepos, count_markers): Move decls to the only modules
10231 that need them.
10232 * region-cache.h (pp_cache): Likewise.
10233 * window.h (check_all_windows): Likewise.
10234 * marker.c, print.c, region-cache.c, window.c: Decls moved here.
10235
5d4cb038
PE
10236 * sysdep.c (croak): Now static, if
10237 defined TIOCNOTTY || defined USG5 || defined CYGWIN.
10238 * syssignal.h (croak): Declare only if not static.
69003fd8
PE
10239
10240 * alloc.c (refill_memory_reserve): Now static if
10241 !defined REL_ALLOC || defined SYSTEM_MALLOC.
10242 * lisp.h (refill_memory_reserve): Declare only if not static.
93ea6e8f 10243
e87b6180
PE
10244 * xsettings.c, xsettings.h (xsettings_get_system_normal_font):
10245 Define only if USE_LUCID.
10246
ac64929e
PE
10247 * xrdb.c (x_customization_string, x_rm_string): Now static.
10248
6f37259d
PE
10249 * xmenu.c (x_menu_wait_for_event): Export only if USE_MOTIF.
10250 * xterm.h (x_menu_wait_for_event): Declare only if USE_MOTIF.
10251
1683e3ab
PE
10252 * xdisp.c (draw_row_with_mouse_face): Now static.
10253 * dispextern.h (draw_row_with_mouse_fave): Remove decl.
10254
de9c2632
PE
10255 * window.h (check_all_windows): Mark externally visible.
10256
2b96acb7
PE
10257 * window.c (window_deletion_count): Now static.
10258
10259 * undo.c: Make symbols static if they're not exported.
10260 (last_undo_buffer, last_boundary_position, pending_boundary):
10261 Now static.
10262
50436f33
PE
10263 * textprop.c (interval_insert_behind_hooks): Now static.
10264 (interval_insert_in_front_hooks): Likewise.
10265
64520e5c
PE
10266 * term.c: Make symbols static if they're not exported.
10267 (tty_turn_off_highlight, get_tty_terminal, max_frame_cols):
10268 (max_frame_lines, tty_set_terminal_modes):
10269 (tty_reset_terminal_modes, tty_turn_off_highlight):
10270 (get_tty_terminal): Now static.
10271 (term_mouse_moveto): Do not define if HAVE_WINDOW_SYSTEM.
10272 * termhooks.h (term_mouse_moveto): Do not declare if
8bd7b830 10273 HAVE_WINDOW_SYSTEM.
64520e5c
PE
10274 * dispextern.h (tty_set_terminal_modes, tty_reset_terminal_modes):
10275 (tty_turn_off_highlight, get_tty_terminal): Remove decls.
10276
1fa53021
PE
10277 * sysdep.c: Make symbols static if they're not exported.
10278 (emacs_get_tty, emacs_set_tty, old_fcntl_flags, old_fcntl_owner):
10279 Now static.
10280 (sigprocmask_set, full_mask): Remove; unused.
10281 (wait_debugging): Mark as visible.
10282 * syssignal.h (SIGFULLMASK, full_mask): Remove decls.
10283 * systty.h (emacs_get_tty, emacs_set_tty): Remove decls.
10284
d4b43b22
PE
10285 * syntax.c (syntax_temp): Define only if !__GNUC__.
10286
b7c513d0
PE
10287 * sound.c (current_sound_device, current_sound): Now static.
10288
989b29ad
PE
10289 * search.c (searchbufs, searchbuf_head): Now static.
10290
13a55a78
PE
10291 * scroll.c (scroll_cost): Remove; unused.
10292 * dispextern.h (scroll_cost): Remove decl.
10293
de68a1fc
PE
10294 * region-cache.h (pp_cache): Mark as externally visible.
10295
40ccffa6
PE
10296 * process.c: Make symbols static if they're not exported.
10297 (process_tick, update_tick, create_process, chan_process):
10298 (Vprocess_alist, proc_buffered_char, datagram_access):
10299 (fd_callback_data, send_process_frame, process_sent_to): Now static.
10300 (deactivate_process): Mark defn as static, as well as decl.
10301 * lisp.h (create_process): Remove decl.
10302 * process.h (chan_process, Vprocess_alist): Remove decls.
10303
ad64fc97
PE
10304 * print.c: Make symbols static if they're not exported.
10305 (print_depth, new_backquote_output, being_printed, print_buffer):
10306 (print_buffer_size, print_buffer_pos, print_buffer_pos_byte):
10307 (print_interval, print_number_index, initial_stderr_stream):
10308 Now static.
10309 * lisp.h (Fprinc): Remove decl.
10310 (debug_output_compilation_hack): Mark as externally visible.
10311
adddb265
PE
10312 * sysdep.c (croak): Move decl from here to syssignal.h.
10313 * syssignal.h (croak): Put it here, so the API can be checked when
10314 'croak' is called from dissociate_if_controlling_tty.
10315
1717ede2
PE
10316 * minibuf.c: Make symbols static if they're not exported.
10317 (minibuf_save_list, choose_minibuf_frame): Now static.
10318 * lisp.h (choose_minibuf_frame): Remove decl.
10319
fa5fb2bc
PE
10320 * lisp.h (verify_bytepos, count_markers): Mark as externally visible.
10321
1e3890d1
PE
10322 * lread.c: Make symbols static if they're not exported.
10323 (read_objects, initial_obarray, oblookup_last_bucket_number):
10324 Now static.
10325 (make_symbol): Remove; unused.
10326 * lisp.h (initial_obarray, make_symbol): Remove decls.
10327
8a1414fa
PE
10328 * keyboard.c: Make symbols static if they're not exported.
10329 (single_kboard, recent_keys_index, total_keys, recent_keys):
10330 (this_command_key_count_reset, raw_keybuf, raw_keybuf_count):
10331 (this_single_command_key_start, echoing, last_auto_save):
10332 (read_key_sequence_cmd, dribble, recursive_edit_unwind):
10333 (command_loop, echo_now, keyboard_init_hook, help_char_p):
10334 (quit_throw_to_read_char, command_loop_2, top_level_1, poll_timer):
10335 (Vlispy_mouse_stem, double_click_count):
10336 Now static.
10337 (force_auto_save_soon): Define only if SIGDANGER.
10338 (ignore_mouse_drag_p): Now static if
10339 !defined HAVE_WINDOW_SYSTEM || defined USE_GTK || defined HAVE_NS.
10340 (print_help): Remove; unused.
10341 (stop_character, last_timer_event): Mark as externally visible.
10342 * keyboard.h (ignore_mouse_drag_p): Declare only if
10343 defined HAVE_WINDOW_SYSTEM && !defined USE_GTK && !defined HAVE_NS.
10344 (echo_now, help_char_p, quit_throw_to_read_char): Remove decls.
10345 * lisp.h (echoing): Remove decl.
10346 (force_auto_save_soon): Declare only if SIGDANGER.
10347 * xdisp.c (redisplay_window): Simplify code, to make it more
10348 obvious that ignore_mouse_drag_p is not accessed if !defined
10349 USE_GTK && !defined HAVE_NS.
10350
93ea6e8f
PE
10351 * intervals.c: Make symbols static if they're not exported.
10352 (merge_properties_sticky, merge_interval_right, delete_interval):
10353 Now static.
10354 * intervals.h (merge_interval_right, delete_interval): Remove decls.
10355
77382fcc
PE
10356 * insdel.c: Make symbols static if they're not exported.
10357 However, leave prepare_to_modify_buffer alone. It's never
10358 called from outside this function, but that appears to be a bug.
10359 (combine_after_change_list, combine_after_change_buffer):
4889fc82 10360 (adjust_after_replace, signal_before_change): Now static.
77382fcc
PE
10361 (adjust_after_replace_noundo): Remove; unused.
10362 * lisp.h (adjust_after_replace, adjust_after_replace_noundo):
4889fc82 10363 (signal_before_change): Remove decls.
77382fcc 10364
9306c32e
PE
10365 * indent.c (val_compute_motion, val_vmotion): Now static.
10366
cd44d2eb
PE
10367 * image.c: Make symbols static if they're not exported.
10368 * dispextern.h (x_create_bitmap_from_xpm_data): Do not declare
10369 if USE_GTK.
10370 * image.c (x_create_bitmap_from_xpm_data): Do not define if USE_GTK.
10371 (xpm_color_cache, ct_table, ct_colors_allocated): Now static.
10372
ad9a7a06
PE
10373 * fringe.c (standard_bitmaps): Now static.
10374 (max_used_fringe_bitmap): Now static, unless HAVE_NS.
10375
81626931
PE
10376 * frame.c: Make symbols static if they're not exported.
10377 (x_report_frame_params, make_terminal_frame): Now static.
10378 (get_frame_param): Now static, unless HAVE_NS.
10379 (x_fullscreen_adjust): Define if WINDOWSNT, not if HAVE_WINDOW_SYSTEM.
10380 (x_get_resource_string): Remove; not used.
10381 * frame.h (make_terminal_frame, x_report_frame_params):
10382 (x_get_resource_string); Remove decls.
10383 (x_fullscreen_adjust): Declare only if WINDOWSNT.
10384 * lisp.h (get_frame_param): Declare only if HAVE_NS.
10385
239f9db9
PE
10386 * font.c, fontset.c: Make symbols static if they're not exported.
10387 * dispextern.h (FACE_SUITABLE_FOR_ASCII_CHAR_P): New macro.
10388 (FACE_SUITABLE_FOR_CHAR_P): Use it.
10389 * font.c (font_close_object): Now static.
10390 * font.h (font_close_object): Remove.
10391 * fontset.c (FONTSET_OBJLIST): Remove.
10392 (free_realized_fontset) #if-0 the body, which does nothing.
10393 (face_suitable_for_char_p): #if-0, as it's never called.
10394 * fontset.h (face_suitable_for_char_p): Remove decl.
04f2d78b
CB
10395 * xfaces.c (face_at_string_position):
10396 Use FACE_SUITABLE_FOR_ASCII_CHAR_P, not FACE_SUITABLE_FOR_CHAR_P,
239f9db9
PE
10397 since 0 is always ASCII.
10398
dfcf3579
PE
10399 * fns.c (weak_hash_tables): Now static.
10400
5045092b
PE
10401 * fileio.c: Make symbols static if they're not exported.
10402 (auto_saving, auto_save_mode_bits, auto_save_error_occurred):
10403 (Vwrite_region_annotation_buffers): Now static.
10404
57a96f5c
PE
10405 * eval.c: Make symbols static if they're not exported.
10406 (backtrace_list, lisp_eval_depth, when_entered_debugger): Now static.
10407 * lisp.h (backtrace_list): Remove decl.
10408
35f08c38
PE
10409 * emacs.c: Make symbols static if they're not exported.
10410 (malloc_state_ptr, malloc_using_checking, syms_of_emacs):
10411 (fatal_error_code, fatal_error_signal_hook, standard_args):
10412 Now static.
10413 (fatal_error_signal): Now static, unless FLOAT_CATCH_SIGKILL.
10414 (DEFINE_DUMMY_FUNCTION): Mark function as externally visible.
10415 (__CTOR_LIST__, __DTOR_LIST__): Now externally visible.
10416 * lisp.h (fatal_error_signal_hook): Remove decl.
10417 (fatal_error_signal): Declare only if FLOAT_CATCH_SIGKILL.
10418
f44bd759
PE
10419 * editfns.c: Move a (normally-unused) function to its only use.
10420 * editfns.c, lisp.h (get_operating_system_release): Remove.
10421 * process.c (init_process) [DARWIN_OS]: Do it inline, as it is not
10422 worth the hassle of breaking this out.
10423
b532497d
PE
10424 * xterm.c: Make symbols static if they're not exported.
10425 (x_raise_frame, x_lower_frame, x_wm_set_window_state):
10426 (x_wm_set_icon_pixmap, x_initialize, XTread_socket_fake_io_error):
10427 (x_destroy_window, x_delete_display):
10428 Now static.
10429 (x_dispatch_event): Now static if ! (USE_MOTIF || USE_X_TOOLKIT).
10430 (x_mouse_leave): Remove; unused.
10431 * xterm.h (x_display_info_for_name, x_raise_frame, x_lower_frame):
10432 (x_destroy_window, x_wm_set_window_state, x_wm_set_icon_pixmap):
10433 (x_delete_display, x_initialize, x_set_border_pixel, x_screen_planes):
10434 Remove decls.
10435 (x_mouse_leave): Declare only if WINDOWSNT.
10436 (x_dispatch_event): Declare only if USE_MOTIF or USE_X_TOOLKIT.
10437 (xic_create_fontsetname): Declare only if HAVE_X_WINDOWS &&
10438 USE_X_TOOLKIT.
10439
1675728f
PE
10440 * ftxfont.c: Make symbols static if they're not exported.
10441 (ftxfont_driver): Export only if !defined HAVE_XFT && def8ined
10442 HAVE_FREETYPE.
10443 * font.h (ftxfont_driver): Likewise.
10444
e4cebfca
PE
10445 * xfns.c: Make symbols static if they're not exported.
10446 (x_last_font_name, x_display_info_for_name):
10447 (x_set_foreground_color, x_set_background_color, x_set_mouse_color):
10448 (x_set_cursor_color, x_set_border_pixel, x_set_border_color):
10449 (x_set_cursor_type, x_set_icon_type, x_set_icon_name):
10450 (x_set_scroll_bar_foreground, x_set_scroll_bar_background):
10451 (x_explicitly_set_name, x_set_title, xic_defaut_fontset, tip_timer):
10452 (last_show_tip_args): Now static.
10453 (xic_defaut_fontset, xic_create_fontsetname): Define only if
10454 defined HAVE_X_WINDOWS && defined USE_X_TOOLKIT
10455 (x_screen_planes): Remove; unused.
10456 * dispextern.h (x_screen_planes): Remove decl.
10457
5bf46f05
PE
10458 * dispnew.c: Make symbols static if they're not exported.
10459 * dispextern.h (redraw_garbaged_frames, scrolling):
10460 (increment_row_positions): Remove.
10461 * dispnew.c (new_glyph_matrix, increment_row_positions, scrolling):
10462 (delayed_size_change, glyph_matrix_count, glyph_pool_count):
10463 Now static.
10464 (redraw_garbaged_frames): Remove; unused.
10465
435f4c28
PE
10466 * xfaces.c: Make symbols static if they're not exported.
10467 * dispextern.h (ascii_face_of_lisp_face, free_realized_face):
10468 Remove decls.
10469 * xterm.h (defined_color): Remove decls.
10470 (x_free_dpy_colors): Declare only if USE_X_TOOLKIT.
10471 * xfaces.c (tty_suppress_bold_inverse_default_colors_p):
10472 (menu_face_changed_default, defined_color, free_realized_face):
10473 (x_free_dpy_colors): Define only if USE_X_TOOLKIT.
10474 (ascii_face_of_lisp_face): Remove; unused.
10475
8524aef3
PE
10476 * xdisp.c: Make symbols static if they're not exported.
10477 * dispextern.h (scratch_glyph_row, window_box_edges):
10478 (glyph_to_pixel_coords, set_cursor_from_row):
10479 (get_next_display_element, set_iterator_to_next):
10480 (highlight_trailing_whitespace, frame_to_window_pixel_xy):
10481 (show_mouse_face): Remove decls
10482 * frame.h (message_buf_print): Likewise.
10483 * lisp.h (pop_message, set_message, check_point_in_composition):
10484 Likewise.
10485 * xterm.h (set_vertical_scroll_bar): Likewise.
10486 * xdisp.c (list_of_error, Vmessage_stack, line_number_displayed):
10487 (message_buf_print, scratch_glyph_row, displayed_buffer):
10488 (set_iterator_to_next, pop_message, set_message, set_cursor_from_row):
10489 (get_next_display_element, show_mouse_face, window_box_edges):
10490 (frame_to_window_pixel_xy, check_point_in_composition):
10491 (set_vertical_scroll_bar, highlight_trailing_whitespace): Now static.
10492 (glyph_to_pixel_coords): Remove; unused.
10493
16390cd2
PE
10494 * dired.c (file_name_completion): Now static.
10495
10496 * dbusbind.c (xd_in_read_queued_messages): Now static.
10497
a25f4dfa
PE
10498 * lisp.h (circular_list_error, FOREACH): Remove; unused.
10499 * data.c (circular_list_error): Remove.
10500
14a9c8df
PE
10501 * commands.h (last_point_position, last_point_position_buffer):
10502 (last_point_position_window): Remove decls.
10503 * keyboard.c: Make these variables static.
10504
04f2d78b
CB
10505 * coding.h (coding, code_convert_region, encode_coding_gap):
10506 Remove decls.
74ab6df5
PE
10507 * coding.c (Vsjis_coding_system, Vbig5_coding_system):
10508 (iso_code_class, detect_coding, code_convert_region): Now static.
10509 (encode_coding_gap): Remove; unused.
10510
38dfbee1
PE
10511 * chartab.c (chartab_chars, chartab_bits): Now static.
10512
a2cb4e63
PE
10513 * charset.h (charset_iso_8859_1): Remove decl.
10514 * charset.c (charset_iso_8859_1, charset_emacs, map_charset_for_dump):
10515 Now static.
10516
127198fd
PE
10517 * ccl.h (check_ccl_update, Vccl_program_table): Remove decls.
10518 * ccl.c (Vccl_program_table): Now static.
10519 (check_ccl_update): Remove; unused.
10520
d85b608f
PE
10521 * category.c (SET_CATEGORY_SET, set_category_set): Move here.
10522 * category.h: ... from here.
10523 * category.c (check_category_table, set_category_set): Now static.
10524
31cd66f3
PE
10525 * casetab.c (Vascii_upcase_table, Vascii_eqv_table): Now static.
10526 * lisp.h: Remove these decls.
10527
c358e587
PE
10528 * buffer.c (buffer_count): Remove unused var.
10529
e78aecca
PE
10530 * bidi.c (bidi_dump_cached_states): Mark as externally visible,
10531 so that it's not optimized away.
10532 (bidi_ignore_explicit_marks_for_paragraph_level): Likewise.
10533 * dispextern.h (bidi_dump_cached_states): Remove, since it's
10534 exported only to the debugger.
10535
e192d7d3 10536 * atimer.c (alarm_signal_handler, run_all_atimers): Now static.
04f2d78b 10537 * atimer.h (run_all_atimers): Remove; not exported.
e192d7d3 10538
92470028
PE
10539 font.c: Make copy_font_spec and merge_font_spec ordinary C functions.
10540 * font.c (copy_font_spec): Rename from Fcopy_font_spec, since it
10541 was inaccessible from Lisp.
10542 (merge_font_spec): Likewise, renaming from Fmerge_font_spec.
10543 * font.c, font.h, fontset.c, xfaces.c, xfont.c: Change all uses.
10544
244ed907
PE
10545 alloc.c: Import and export fewer symbols, and remove unused items.
10546 * lisp.h (suppress_checking, die): Declare only if ENABLE_CHECKING
10547 is defined.
10548 (suppress_checking): Add EXTERNALLY_VISIBLE attribute, so that
10549 it's not optimized away by whole-program optimization.
10550 (message_enable_multibyte, free_misc): Remove.
10551 (catchlist, handlerlist, mark_backtrace):
10552 Declare only if BYTE_MARK_STACK.
10553 (mark_byte_stack): Likewise, fixing a ifdef-vs-if typo.
10554 * alloc.c (pure): Export only if VIRT_ADDR_VARIES is defined.
10555 (message_enable_multibyte): Remove decl.
10556 (free_misc, interval_free_list, float_block, float_block_index):
10557 (n_float_blocks, float_free_list, cons_block, cons_block_index):
10558 (cons_free_list, last_marked_index):
10559 Now static.
10560 (suppress_checking, die): Define only if ENABLE_CHECKING is defined.
10561 * eval.c (catchlist, handlerlist): Export only if BYTE_MARK_STACK.
10562 (mark_backtrace): Define only if BYTE_MARK_STACK.
10563 * xdisp.c (message_enable_multibyte): Now static.
10564
61c2b50e 10565 Declare Lisp_Object Q* variables to be 'static' if not exported.
955cbe7b
PE
10566 This makes it easier for human readers (and static analyzers)
10567 to see whether these variables are used from other modules.
10568 * alloc.c, buffer.c, bytecode.c, callint.c, casetab.c, category.c:
10569 * ccl.c, character.c, charset.c, cmds.c, coding.c, composite.c:
10570 * data.c, dbusbind.c, dired.c, editfns.c, eval.c, fileio.c, fns.c:
10571 * font.c, frame.c, fringe.c, ftfont.c, image.c, keyboard.c, keymap.c:
10572 * lread.c, macros.c, minibuf.c, print.c, process.c, search.c:
10573 * sound.c, syntax.c, textprop.c, window.c, xdisp.c, xfaces.c, xfns.c:
10574 * xmenu.c, xselect.c:
10575 Declare Q* vars static if they are not used in other modules.
10576 * ccl.h, character.h, charset.h, coding.h, composite.h, font.h:
10577 * frame.h, intervals.h, keyboard.h, lisp.h, process.h, syntax.h:
10578 Remove decls of unexported vars.
10579 * keyboard.h (EVENT_HEAD_UNMODIFIED): Remove now-unused macro.
10580
95c82688
PE
10581 * lisp.h (DEFINE_FUNC): Make sname 'static'.
10582
16a97296
PE
10583 Make Emacs functions such as Fatom 'static' by default.
10584 This makes it easier for human readers (and static analyzers)
10585 to see whether these functions can be called from other modules.
10586 DEFUN now defines a static function. To make the function external
10587 so that it can be used in other C modules, use the new macro DEFUE.
8bd7b830
PE
10588 * lisp.h (Funibyte_char_to_multibyte, Fsyntax_table_p):
10589 (Finit_image_library):
16a97296
PE
10590 (Feval_region, Fbacktrace, Ffetch_bytecode, Fswitch_to_buffer):
10591 (Ffile_executable_p, Fmake_symbolic_link, Fcommand_execute):
10592 (Fget_process, Fdocumentation_property, Fbyte_code, Ffile_attributes):
10593 Remove decls, since these functions are now static.
10594 (Funintern, Fget_internal_run_time): New decls, since these functions
10595 were already external.
95c82688 10596
16a97296
PE
10597 * alloc.c, buffer.c, callint.c, callproc.c, casefiddle.c, casetab.c:
10598 * ccl.c, character.c, chartab.c, cmds.c, coding.c, data.c, dispnew.c:
10599 * doc.c, editfns.c, emacs.c, eval.c, fileio.c, filelock.c, floatfns.c:
10600 * fns.c, font.c, fontset.c, frame.c, image.c, indent.c:
10601 * keyboard.c, keymap.c, lread.c:
10602 * macros.c, marker.c, menu.c, minibuf.c, print.c, process.c, search.c:
10603 * syntax.c, term.c, terminal.c, textprop.c, undo.c:
10604 * window.c, xdisp.c, xfaces.c, xfns.c, xmenu.c, xsettings.c:
10605 Mark functions with DEFUE instead of DEFUN,
10606 if they are used in other modules.
10607 * buffer.c (Fset_buffer_major_mode, Fdelete_overlay): New forward
10608 decls for now-static functions.
10609 * buffer.h (Fdelete_overlay): Remove decl.
10610 * callproc.c (Fgetenv_internal): Mark as internal.
10611 * composite.c (Fremove_list_of_text_properties): Remove decl.
10612 (Fcomposition_get_gstring): New forward static decl.
10613 * composite.h (Fcomposite_get_gstring): Remove decl.
10614 * dired.c (Ffile_attributes): New forward static decl.
10615 * doc.c (Fdocumntation_property): New forward static decl.
10616 * eval.c (Ffetch_bytecode): New forward static decl.
10617 (Funintern): Remove extern decl; now in .h file where it belongs.
10618 * fileio.c (Fmake_symbolic_link): New forward static decl.
10619 * image.c (Finit_image_library): New forward static decl.
10620 * insdel.c (Fcombine_after_change_execute): Make forward decl static.
10621 * intervals.h (Fprevious_property_change):
10622 (Fremove_list_of_text_properties): Remove decls.
10623 * keyboard.c (Fthis_command_keys): Remove decl.
10624 (Fcommand_execute): New forward static decl.
10625 * keymap.c (Flookup_key): New forward static decl.
10626 (Fcopy_keymap): Now static.
10627 * keymap.h (Flookup_key): Remove decl.
10628 * process.c (Fget_process): New forward static decl.
10629 (Fprocess_datagram_address): Mark as internal.
10630 * syntax.c (Fsyntax_table_p): New forward static decl.
10631 (skip_chars): Remove duplicate decl.
10632 * textprop.c (Fprevious_property_change): New forward static decl.
10633 * window.c (Fset_window_fringes, Fset_window_scroll_bars):
10634 Now internal.
10635 (Fset_window_margins, Fset_window_vscroll): New forward static decls.
10636 * window.h (Fset_window_vscroll, Fset_window_margins): Remove decls.
10637
785bbd42
PE
10638 * editfns.c (Fformat): Remove unreachable code.
10639
8b913b57
AS
106402011-04-14 Andreas Schwab <schwab@linux-m68k.org>
10641
10642 * fileio.c (Finsert_file_contents): Fix typo in 2005-05-13
10643 change. (Bug#8496)
10644
a6744a35
EZ
106452011-04-13 Eli Zaretskii <eliz@gnu.org>
10646
10647 * xdisp.c (handle_invisible_prop): Don't call bidi_paragraph_init
10648 when at ZV. (Bug#8487)
10649
e7974947
AS
106502011-04-12 Andreas Schwab <schwab@linux-m68k.org>
10651
baad03f0
AS
10652 * charset.c (Fclear_charset_maps): Use xfree instead of free.
10653 (Bug#8437)
10654 * keyboard.c (parse_tool_bar_item): Likewise.
10655 * sound.c (sound_cleanup, alsa_close): Likewise.
10656 * termcap.c (tgetent): Likewise.
10657 * xfns.c (x_default_font_parameter): Likewise.
10658 * xsettings.c (read_and_apply_settings): Likewise.
10659
e7974947
AS
10660 * alloc.c (overrun_check_malloc, overrun_check_realloc)
10661 (overrun_check_free): Protoize.
10662
28272684
PE
106632011-04-12 Paul Eggert <eggert@cs.ucla.edu>
10664
10665 * sysdep.c (emacs_read, emacs_write): Check for negative sizes
10666 since callers should never pass a negative size.
10667 Change the signature to match that of plain 'read' and 'write'; see
10668 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00397.html>.
10669 * lisp.h: Update prototypes of emacs_write and emacs_read.
10670
11997c76
EZ
106712011-04-11 Eli Zaretskii <eliz@gnu.org>
10672
10673 * xdisp.c (redisplay_window): Don't try to determine the character
10674 position of the scroll margin if the window start point w->startp
e896f03c 10675 is outside the buffer's accessible region. (Bug#8468)
11997c76 10676
8a2cbd72
EZ
106772011-04-10 Eli Zaretskii <eliz@gnu.org>
10678
10679 Fix write-region and its subroutines for buffers > 2GB.
10680 * fileio.c (a_write, e_write): Modify declaration of arguments and
10681 local variables to support buffers larger than 2GB.
10682 (Fcopy_file): Use EMACS_INT for return value of emacs_read.
10683
10684 * sysdep.c (emacs_write, emacs_read): Use ssize_t for last
10685 argument, local variables, and return value.
10686
10687 * lisp.h: Update prototypes of emacs_write and emacs_read.
10688
10689 * sound.c (vox_write): Use ssize_t for return value of emacs_write.
10690
4073e537 106912011-04-10 Paul Eggert <eggert@cs.ucla.edu>
eb3f1cc8 10692
1ebfdcb6
PE
10693 * xdisp.c (vmessage): Use memchr, not strnlen, which some hosts lack.
10694
b2ded58d
PE
10695 Fix more problems found by GCC 4.6.0's static checks.
10696
7d66342c
PE
10697 * xdisp.c (vmessage): Use a better test for character truncation.
10698
bbf47d44
PE
10699 * charset.c (load_charset_map): <, not <=, for optimization,
10700 and to avoid potential problems with integer overflow.
9248994d 10701 * chartab.c (sub_char_table_set_range, char_table_set_range): Likewise.
f9a68bc5 10702 * casetab.c (set_identity, shuffle): Likewise.
3ab1c7ce 10703 * editfns.c (Fformat): Likewise.
1e69125e 10704 * syntax.c (skip_chars): Likewise.
3befa583 10705
e3019616
PE
10706 * xmenu.c (set_frame_menubar): Allocate smaller local vectors.
10707 This also lets GCC 4.6.0 generate slightly better loop code.
10708
becfa255
PE
10709 * callint.c (Fcall_interactively): <, not <=, for optimization.
10710 (Fcall_interactively): Count the number of arguments produced,
10711 not the number of arguments given. This is simpler and lets GCC
10712 4.6.0 generate slightly better code.
10713
dae0cd48
PE
10714 * ftfont.c: Distingish more carefully between FcChar8 and char.
10715 The previous code passed unsigned char * to a functions like
10716 strlen and xstrcasecmp that expect char *, which does not
10717 conform to the C standard.
10718 (get_adstyle_property, ftfont_pattern_entity): Use FcChar8 for
10719 arguments to FcPatternGetString, and explicitly cast FcChar8 * to
10720 char * when the C standard requires it.
10721
76032d70
PE
10722 * keyboard.c (read_char): Remove unused var.
10723
eb3f1cc8
PE
10724 * eval.c: Port to Windows vsnprintf (Bug#8435).
10725 Include <limits.h>.
10726 (SIZE_MAX): Define if the headers do not.
10727 (verror): Do not give up if vsnprintf returns a negative count.
10728 Instead, grow the buffer. This ports to Windows vsnprintf, which
10729 does not conform to C99. Problem reported by Eli Zaretskii.
10730 Also, simplify the allocation scheme, by avoiding the need for
10731 calling realloc, and removing the ALLOCATED variable.
10732
70476b54
PE
10733 * eval.c (verror): Initial buffer size is 4000 (not 200) bytes.
10734
12020a9e
PE
10735 Remove invocations of doprnt, as Emacs now uses vsnprintf.
10736 But keep the doprint source code for now, as we might revamp it
10737 and use it again (Bug#8435).
ea6c7ae6
PE
10738 * lisp.h (doprnt): Remove.
10739 * Makefile.in (base_obj): Remove doprnt.o.
10740 * deps.mk (doprnt.o): Remove.
10741
5fdb398c
PE
10742 error: Print 32- and 64-bit integers portably (Bug#8435).
10743 Without this change, on typical 64-bit hosts error ("...%d...", N)
10744 was used to print both 32- and 64-bit integers N, which relied on
10745 undefined behavior.
61bdb816 10746 * lisp.h, m/amdx86-64.h, m/ia64.h, m/ibms390x.h (pEd): New macro.
5fdb398c
PE
10747 * lisp.h (error, verror): Mark as printf-like functions.
10748 * eval.c (verror): Use vsnprintf, not doprnt, to do the real work.
10749 Report overflow in size calculations when allocating printf buffer.
10750 Do not truncate output string at its first null byte.
10751 * xdisp.c (vmessage): Use vsnprintf, not doprnt, to do the real work.
10752 Truncate the output at a character boundary, since vsnprintf does not
10753 do that.
10754 * charset.c (check_iso_charset_parameter): Convert internal
10755 character to string before calling 'error', since %c now has the
10756 printf meaning.
10757 * coding.c (Fdecode_sjis_char, Fdecode_big5_char): Avoid int
10758 overflow when computing char to be passed to 'error'. Do not
10759 pass Lisp_Object to 'error'; pass the integer instead.
10760 * nsfns.m (Fns_do_applescript): Use int, not long, since it's
10761 formatted with plain %d.
10762
b189fa66
PE
10763 * eval.c (internal_lisp_condition_case): Don't pass spurious arg.
10764
bff87ef0
PE
10765 * keyboard.c (access_keymap_keyremap): Print func name, not garbage.
10766
7e2cac20
PE
10767 * coding.c (Fdecode_sjis_char): Don't assume CODE fits in int.
10768
ce4d90b5
PE
10769 * xterm.c (x_catch_errors): Remove duplicate declaration.
10770
266c9547
PE
10771 * term.c (maybe_fatal): Mark its 3rd arg as a printf format, too.
10772
79c49ad2
PE
10773 * xdisp.c, lisp.h (message_nolog): Remove; unused.
10774
368f4090
JM
107752011-04-10 Jim Meyering <meyering@redhat.com>
10776
10777 use ssize_t and size_t for read- and write-like emacs_gnutls_* functions
10778 * gnutls.c (emacs_gnutls_read): Adjust signature to be more read-like:
10779 return ssize_t not "int", and use size_t as the buffer length.
10780 (emacs_gnutls_write): Likewise, and make the buffer pointer "const".
10781 * gnutls.h: Update declarations.
10782 * process.c (read_process_output): Use ssize_t, to match.
10783 (send_process): Likewise.
10784
a32d4040
CY
107852011-04-09 Chong Yidong <cyd@stupidchicken.com>
10786
10787 * image.c (Fimagemagick_types): Doc fix, and comment cleanup.
10788
8546720e 107892011-04-09 Chong Yidong <cyd@stupidchicken.com>
aac0c6e3 10790
04f2d78b
CB
10791 * ftfont.c (get_adstyle_property, ftfont_pattern_entity):
10792 Use unsigned char, to match FcChar8 type definition.
aac0c6e3 10793
8546720e
GM
10794 * xterm.c (handle_one_xevent):
10795 * xmenu.c (create_and_show_popup_menu):
10796 * xselect.c (x_decline_selection_request)
10797 (x_reply_selection_request): Avoid type-punned deref of X events.
aac0c6e3 10798
0a2f5c1a 107992011-04-09 Eli Zaretskii <eliz@gnu.org>
a53e2e89
EZ
10800
10801 Fix some uses of `int' instead of EMACS_INT.
10802 * search.c (string_match_1, fast_string_match)
10803 (fast_c_string_match_ignore_case, fast_string_match_ignore_case)
10804 (scan_buffer, find_next_newline_no_quit)
10805 (find_before_next_newline, search_command, Freplace_match)
10806 (Fmatch_data): Make some `int' variables be EMACS_INT.
10807
10808 * xdisp.c (display_count_lines): 3rd argument and return value now
10809 EMACS_INT. All callers changed.
10810 (pint2hrstr): Last argument is now EMACS_INT.
10811
10812 * coding.c (detect_coding_utf_8, detect_coding_emacs_mule)
10813 (detect_coding_iso_2022, detect_coding_sjis, detect_coding_big5)
10814 (detect_coding_ccl, detect_coding_charset, decode_coding_utf_8)
10815 (decode_coding_utf_16, decode_coding_emacs_mule)
10816 (decode_coding_iso_2022, decode_coding_sjis, decode_coding_big5)
10817 (decode_coding_ccl, decode_coding_charset)
10818 <consumed_chars, consumed_chars_base>: Declare EMACS_INT.
10819 (decode_coding_iso_2022, decode_coding_emacs_mule)
10820 (decode_coding_sjis, decode_coding_big5, decode_coding_charset)
10821 <char_offset, last_offset>: Declare EMACS_INT.
10822 (encode_coding_utf_8, encode_coding_utf_16)
10823 (encode_coding_emacs_mule, encode_invocation_designation)
10824 (encode_designation_at_bol, encode_coding_iso_2022)
10825 (encode_coding_sjis, encode_coding_big5, encode_coding_ccl)
10826 (encode_coding_raw_text, encode_coding_charset) <produced_chars>:
10827 Declare EMACS_INT.
10828 (ASSURE_DESTINATION): Declare more_bytes EMACS_INT.
10829 (encode_invocation_designation): Last argument P_NCHARS is now
10830 EMACS_INT.
10831 (decode_eol): Declare pos_byte, pos, and pos_end EMACS_INT.
10832 (produce_chars): from_nchars and to_nchars are now EMACS_INT.
10833
10834 * coding.h (struct coding_system) <head_ascii>: Declare EMACS_INT.
10835 All users changed.
10836
10837 * ccl.c (Fccl_execute_on_string): Declare some variables
10838 EMACS_INT.
10839
8546720e 108402011-04-08 Samuel Thibault <sthibault@debian.org> (tiny change)
0080dc6b
SS
10841
10842 * term.c (init_tty): Fix incorrect ifdef placement (Bug#8450).
10843
4e19a977
CS
108442011-03-19 Christoph Scholtes <cschol2112@googlemail.com>
10845
10846 * process.c (Fformat_network_address): Doc fix.
10847
87302331
R
108482011-04-08 T.V. Raman <tv.raman.tv@gmail.com> (tiny change)
10849
ee7683eb 10850 * xml.c (parse_region): Avoid creating spurious whitespace nodes.
87302331 10851
cbb59342
CY
108522011-04-08 Chong Yidong <cyd@stupidchicken.com>
10853
10854 * keyboard.c (read_char): Call Lisp function help-form-show,
10855 instead of using internal_with_output_to_temp_buffer.
10856 (Qhelp_form_show): New var.
e0d38eeb 10857 (syms_of_keyboard): Use DEFSYM macro.
cbb59342
CY
10858
10859 * print.c (internal_with_output_to_temp_buffer): Function deleted.
10860
10861 * lisp.h (internal_with_output_to_temp_buffer): Remove prototype.
10862
e67a13ab
CY
108632011-04-06 Chong Yidong <cyd@stupidchicken.com>
10864
04f2d78b
CB
10865 * process.c (Flist_processes): Remove to Lisp.
10866 (list_processes_1): Delete.
e67a13ab 10867
973f782d
EZ
108682011-04-06 Eli Zaretskii <eliz@gnu.org>
10869
7c106b1e
EZ
10870 * msdos.c (careadlinkat, careadlinkatcwd): MS-DOS replacements.
10871
973f782d
EZ
10872 * w32.c (careadlinkat, careadlinkatcwd): New always-fail stubs.
10873
41cf7d1a 108742011-04-06 Paul Eggert <eggert@cs.ucla.edu>
27ccc379 10875
ca23cc88
PE
10876 Fix more problems found by GCC 4.6.0's static checks.
10877
f390e2d5
PE
10878 * xmenu.c (Fx_popup_dialog): Don't assume string is free of formats.
10879
42eea0d0
PE
10880 * menu.c (Fx_popup_menu): Don't assume error_name lacks printf formats.
10881
b69769da 10882 * lisp.h (message, message_nolog, fatal): Mark as printf-like.
1e973bc7 10883
f9541e84
PE
10884 * xdisp.c (vmessage): Mark as a printf-like function.
10885
13841b55
PE
10886 * term.c (vfatal, maybe_fatal): Mark as printf-like functions.
10887
c136c10f
PE
10888 * sound.c (sound_warning): Don't crash if arg contains a printf format.
10889
5e2d4a30
PE
10890 * image.c (tiff_error_handler, tiff_warning_handler): Mark as
10891 printf-like functions.
10892 (tiff_load): Add casts to remove these marks before passing them
10893 to system-supplied API.
10894
583f48b9
PE
10895 * eval.c (Fsignal): Remove excess argument to 'fatal'.
10896
b25d760e
PE
10897 * coding.c (EMIT_ONE_BYTE, EMIT_TWO_BYTES): Use unsigned, not int.
10898 This avoids several warnings with gcc -Wstrict-overflow.
d5efd1d1
PE
10899 (DECODE_COMPOSITION_RULE): If the rule is invalid, goto invalid_code
10900 directly, rather than having caller test rule sign. This avoids
10901 some unnecessary tests.
10902 * composite.h (COMPOSITION_ENCODE_RULE_VALID): New macro.
10903 (COMPOSITION_ENCODE_RULE): Arguments now must be valid. This
10904 affects only one use, in DECODE_COMPOSITION_RULE, which is changed.
b25d760e 10905
bc7b6697 10906 * xfont.c (xfont_text_extents): Remove var that was set but not used.
625a3eb1 10907 (xfont_open): Avoid unnecessary tests.
bc7b6697 10908
27ccc379
PE
10909 * composite.c (composition_gstring_put_cache): Use unsigned integer.
10910
dcd5c89a
PE
10911 * composite.h, composite.c (composition_gstring_put_cache):
10912 Use EMACS_INT, not int, for length.
10913
b13a45c6
PE
10914 * composite.h (COMPOSITION_DECODE_REFS): New macro,
10915 breaking out part of COMPOSITION_DECODE_RULE.
10916 (COMPOSITION_DECODE_RULE): Use it.
10917 * composite.c (get_composition_id): Remove unused local vars,
10918 by using the new macro.
10919
1e792e4d
PE
10920 * textprop.c (set_text_properties_1): Change while to do-while,
10921 since the condition is always true at first.
10922
dc6c6455 10923 * intervals.c (graft_intervals_into_buffer): Mark var as used.
aa86731f
PE
10924 (interval_deletion_adjustment): Return unsigned value.
10925 All uses changed.
dc6c6455 10926
aba7731a
PE
10927 * process.c (list_processes_1, create_pty, read_process_output):
10928 (exec_sentinel): Remove vars that were set but not used.
afd4052b 10929 (create_pty): Remove unnecessary "volatile"s.
bc57d757 10930 (Fnetwork_interface_info): Avoid possibility of int overflow.
82eaa333 10931 (read_process_output): Do adaptive read buffering even if carryover.
fe07cdfa 10932 (read_process_output): Simplify nbytes computation if buffered.
aba7731a 10933
fdfc4bf3
PE
10934 * bytecode.c (exec_byte_code): Rename local to avoid shadowing.
10935
fca8fe46 10936 * syntax.c (scan_words): Remove var that was set but not used.
12cbf13f 10937 (update_syntax_table): Use unsigned instead of int.
fca8fe46 10938
06a0259a 10939 * lread.c (lisp_file_lexically_bound_p): Use ints rather than endptrs.
3c346cc3 10940 (lisp_file_lexically_bound_p, read1): Use unsigned instead of int.
e6eb4e9e 10941 (safe_to_load_p): Make the end-of-loop test the inverse of the in-loop.
06a0259a 10942
e7b9e80f
PE
10943 * print.c (print_error_message): Avoid int overflow.
10944
56201685
PE
10945 * font.c (font_list_entities): Redo for clarity,
10946 so that reader need not know FONT_DPI_INDEX + 1 == FONT_SPACING_INDEX.
10947
78834453 10948 * font.c (font_find_for_lface, Ffont_get_glyphs): Remove unused vars.
790771b1 10949 (font_score): Avoid potential overflow in diff calculation.
78834453 10950
0bc0b309 10951 * fns.c (substring_both): Remove var that is set but not used.
8cd55cb4 10952 (sxhash): Redo loop for clarity and to avoid wraparound warning.
0bc0b309 10953
e610eaca
PE
10954 * eval.c (funcall_lambda): Rename local to avoid shadowing.
10955
b895abce
PE
10956 * alloc.c (mark_object_loop_halt, mark_object): Use size_t, not int.
10957 Otherwise, GCC 4.6.0 optimizes the loop check away since the check
10958 can always succeed if overflow has undefined behavior.
10959
1f1d9321 10960 * search.c (boyer_moore, wordify): Remove vars set but not used.
6f076cc7 10961 (wordify): Omit three unnecessary tests.
1f1d9321 10962
c59478bc
PE
10963 * indent.c (MULTIBYTE_BYTES_WIDTH): Don't compute wide_column.
10964 All callers changed. This avoids the need for an unused var.
10965
79b73827
PE
10966 * casefiddle.c (casify_region): Remove var that is set but not used.
10967
a4db5dfe
PE
10968 * dired.c (file_name_completion): Remove var that is set but not used.
10969
43aae36e
PE
10970 * fileio.c (Finsert_file_contents): Make EOF condition clearer.
10971
2a47c44d 10972 * fileio.c (Finsert_file_contents): Avoid signed integer overflow.
163c5f32 10973 (Finsert_file_contents): Remove unnecessary code checking fd.
2a47c44d 10974
a37c69bf
PE
10975 * minibuf.c (read_minibuf_noninteractive): Use size_t for sizes.
10976 Check for integer overflow on size calculations.
10977
328ab8e7
PE
10978 * buffer.c (Fprevious_overlay_change): Remove var that is set
10979 but not used.
10980
e5a2a5cb
PE
10981 * keyboard.c (menu_bar_items, read_char_minibuf_menu_prompt):
10982 Remove vars that are set but not used.
8d84a6eb 10983 (timer_check_2): Don't assume timer-list and idle-timer-list are lists.
6b043475 10984 (timer_check_2): Mark vars as initialized.
e5a2a5cb 10985
a60e5f68
PE
10986 * gtkutil.c (xg_get_file_with_chooser): Mark var as initialized.
10987
f661cb61 10988 * image.c (lookup_image): Remove var that is set but not used.
35fa624f 10989 (xbm_load): Use parse_p, for gcc -Werror=unused-but-set-variable.
f661cb61 10990
f0397f5a
PE
10991 * fontset.c (Finternal_char_font, Ffontset_info): Remove vars
10992 that are set but not used.
10993
8664db06 10994 * xfns.c (make_invisible_cursor): Don't return garbage
03733ee7 10995 if XCreateBitmapFromData fails (Bug#8410).
8664db06 10996
6abdaa4a
PE
10997 * xselect.c (x_get_local_selection, x_handle_property_notify):
10998 Remove vars that are set but not used.
10999
0ce7538d 11000 * xfns.c (x_create_tip_frame): Remove var that is set but not used.
6abdaa4a 11001 (make_invisible_cursor): Initialize a possibly-uninitialized variable.
0ce7538d 11002
9ae848fc
PE
11003 * xterm.c (x_scroll_bar_to_input_event) [!USE_GTK]:
11004 Remove var that is set but not used.
0b918413
PE
11005 (scroll_bar_windows_size): Now size_t, not int.
11006 (x_send_scroll_bar_event): Use size_t, not int, for sizes.
11007 Check for overflow.
9ae848fc 11008
a5a62657
PE
11009 * xfaces.c (realize_named_face): Remove vars that are set but not used.
11010 (map_tty_color) [!defined MSDOS]: Likewise.
11011
5c5cdd39
PE
11012 * term.c (tty_write_glyphs): Use size_t; this avoids overflow warning.
11013
66ebf983
PE
11014 * coding.c: Remove vars that are set but not used.
11015 (DECODE_COMPOSITION_RULE): Remove 2nd arg, which is unused.
11016 All callers changed.
11017 (decode_coding_utf_8, decode_coding_utf_16 decode_coding_emacs_mule):
11018 (decode_coding_iso_2022, encode_coding_sjis, encode_coding_big5):
11019 (decode_coding_charset): Remove vars that are set but not used.
11020
1be4d761
PE
11021 * bytecode.c (Fbyte_code) [!defined BYTE_CODE_SAFE]: Remove var
11022 that is set but not used.
11023
47553fa8
PE
11024 * print.c (print_object): Remove var that is set but not used.
11025
1f7196bf 11026 Replace 2 copies of readlink code with 1 gnulib version (Bug#8401).
d1fdcab7
PE
11027 The gnulib version avoids calling malloc in the usual case,
11028 and on 64-bit hosts doesn't have some arbitrary 32-bit limits.
11029 * fileio.c (Ffile_symlink_p): Use emacs_readlink.
11030 * filelock.c (current_lock_owner): Likewise.
11031 * lisp.h (READLINK_BUFSIZE, emacs_readlink): New function.
11032 * sysdep.c: Include allocator.h, careadlinkat.h.
11033 (emacs_no_realloc_allocator): New static constant.
11034 (emacs_readlink): New function.
fdb61804
PE
11035 * deps.mk (sysdep.o): Depend on ../lib/allocator.h and on
11036 ../lib/careadlinkat.h.
d1fdcab7 11037
f84c17c7
SM
110382011-04-04 Stefan Monnier <monnier@iro.umontreal.ca>
11039
11040 * keyboard.c (safe_run_hook_funcall): Fix last change (don't stop at the
11041 first non-nil return value).
11042
ef3862ad
JD
110432011-04-03 Jan Djärv <jan.h.d@swipnet.se>
11044
11045 * nsterm.m (ns_update_auto_hide_menu_bar): Define MAC_OS_X_VERSION_10_6
11046 if not defined (Bug#8403).
11047
376a7006
JB
110482011-04-02 Juanma Barranquero <lekktu@gmail.com>
11049
11050 * xdisp.c (display_count_lines): Remove parameter `start',
11051 unused since 1998-01-01T02:27:27Z!rms@gnu.org. All callers changed.
11052 (get_char_face_and_encoding): Remove parameter `multibyte_p',
11053 unused since 2008-05-14T01:40:23Z!handa@m17n.org. All callers changed.
11054 (fill_stretch_glyph_string): Remove parameters `row' and `area',
11055 unused at least since Kim's GUI unification at 2003-03-16T20:45:46Z!storm@cua.dk
11056 and thereabouts. All callers changed.
11057 (get_per_char_metric): Remove parameter `f', unused since
11058 2008-05-14T01:40:23Z!handa@m17n.org. All callers changed.
11059
6ca3801d
JM
110602011-04-02 Jim Meyering <meyering@redhat.com>
11061
11062 do not dereference NULL upon failed strdup
11063 * nsfont.m (ns_descriptor_to_entity): Use xstrdup, not strdup.
11064 (ns_get_family): Likewise.
11065
d8e2b5ba
JB
110662011-04-02 Juanma Barranquero <lekktu@gmail.com>
11067
11068 * eval.c (unwind_to_catch) [DEBUG_GCPRO]: Remove redundant assignment.
11069
8c74fcbd
JD
110702011-04-02 Jan Djärv <jan.h.d@swipnet.se>
11071
11072 * nsterm.m (ns_update_auto_hide_menu_bar): Only for OSX 10.6 or
11073 later (Bug#8403).
11074
7200d79c
SM
110752011-04-01 Stefan Monnier <monnier@iro.umontreal.ca>
11076
03408648 11077 Add lexical binding.
7200d79c 11078
03408648
SM
11079 * window.c (Ftemp_output_buffer_show): New fun.
11080 (Fsave_window_excursion):
11081 * print.c (Fwith_output_to_temp_buffer): Move to subr.el.
11082
11083 * lread.c (lisp_file_lexically_bound_p): New function.
11084 (Fload): Bind Qlexical_binding.
11085 (readevalloop): Remove `evalfun' arg.
11086 Bind Qinternal_interpreter_environment.
11087 (Feval_buffer): Bind Qlexical_binding.
11088 (defvar_int, defvar_bool, defvar_lisp_nopro, defvar_kboard):
11089 Mark as dynamic.
11090 (syms_of_lread): Declare `lexical-binding'.
11091
11092 * lisp.h (struct Lisp_Symbol): New field `declared_special'.
11093
11094 * keyboard.c (eval_dyn): New fun.
11095 (menu_item_eval_property): Use it.
ca105506
SM
11096
11097 * image.c (parse_image_spec): Use Ffunctionp.
ca105506 11098
03408648
SM
11099 * fns.c (concat, mapcar1): Accept byte-code-functions.
11100
11101 * eval.c (Fsetq): Handle lexical vars.
11102 (Fdefun, Fdefmacro, Ffunction): Make closures when needed.
11103 (Fdefconst, Fdefvaralias, Fdefvar): Mark as dynamic.
11104 (FletX, Flet): Obey lexical binding.
11105 (Fcommandp): Handle closures.
11106 (Feval): New `lexical' arg.
11107 (eval_sub): New function extracted from Feval. Use it almost
11108 everywhere where Feval was used. Look up vars in lexical env.
11109 Handle closures.
11110 (Ffunctionp): Move from subr.el.
11111 (Ffuncall): Handle closures.
11112 (apply_lambda): Remove `eval_flags'.
11113 (funcall_lambda): Handle closures and new byte-code-functions.
11114 (Fspecial_variable_p): New function.
11115 (syms_of_eval): Initialize the Vinternal_interpreter_environment var,
11116 but without exporting it to Lisp.
23aba0ea 11117
23aba0ea 11118 * doc.c (Fdocumentation, store_function_docstring):
03408648 11119 * data.c (Finteractive_form): Handle closures.
23aba0ea 11120
03408648
SM
11121 * callint.c (Fcall_interactively): Preserve lexical-binding mode for
11122 interactive spec.
ba83908c 11123
04f2d78b
CB
11124 * bytecode.c (Bstack_ref, Bstack_set, Bstack_set2, BdiscardN):
11125 New byte-codes.
03408648
SM
11126 (exec_byte_code): New function extracted from Fbyte_code to handle new
11127 calling convention for byte-code-functions. Add new byte-codes.
ba83908c 11128
03408648 11129 * buffer.c (defvar_per_buffer): Set new `declared_special' field.
e2abe5a1 11130
03408648 11131 * alloc.c (Fmake_symbol): Init new `declared_special' field.
e2abe5a1 11132
e2abce01
JB
111332011-03-31 Juanma Barranquero <lekktu@gmail.com>
11134
11135 * xdisp.c (redisplay_internal): Fix prototype.
11136
63696a73 111372011-03-31 Eli Zaretskii <eliz@gnu.org>
09725d26 11138
63696a73 11139 * xdisp.c (SCROLL_LIMIT): New macro.
04f2d78b
CB
11140 (try_scrolling): Use it when setting scroll_limit.
11141 Limit scrolling to 100 screen lines.
63696a73
EZ
11142 (redisplay_window): Even when falling back on "recentering",
11143 position point in the window according to scroll-conservatively,
11144 scroll-margin, and scroll-*-aggressively variables. (Bug#6671)
11145
11146 (try_scrolling): When point is above the window, allow searching
11147 as far as scroll_max, or one screenful, to compute vertical
11148 distance from PT to the scroll margin position. This prevents
11149 try_scrolling from unnecessarily failing when
11150 scroll-conservatively is set to a value slightly larger than the
11151 window height. Clean up the case of PT below the margin at bottom
11152 of window: scroll_max can no longer be INT_MAX. When aggressive
11153 scrolling is in use, don't let point enter the opposite scroll
11154 margin as result of the scroll.
11155 (syms_of_xdisp) <scroll-conservatively>: Document the
09725d26
EZ
11156 threshold of 100 lines for never-recentering scrolling.
11157
e4cc2dfc
JB
111582011-03-31 Juanma Barranquero <lekktu@gmail.com>
11159
11160 * dispextern.h (move_it_by_lines):
11161 * xdisp.c (move_it_by_lines): Remove parameter `need_y_p', unused
11162 since 2000-12-29T14:24:09Z!gerd@gnu.org. All callers changed.
11163 (message_log_check_duplicate): Remove parameters `prev_bol' and
11164 `this_bol', unused since 1998-01-01T02:27:27Z!rms@gnu.org. All callers changed.
11165 (redisplay_internal): Remove parameter `preserve_echo_area',
11166 unused since 1999-07-21T21:43:52Z!gerd@gnu.org. All callers changed.
11167
11168 * indent.c (Fvertical_motion):
11169 * window.c (window_scroll_pixel_based, Frecenter):
11170 Don't pass `need_y_p' to `move_it_by_lines'.
11171
1c470562
SM
111722011-03-30 Stefan Monnier <monnier@iro.umontreal.ca>
11173
44f230aa
SM
11174 * eval.c (struct backtrace): Don't cheat with negative numbers, but do
11175 steal a few bits to be more compact.
11176 (interactive_p, Fbacktrace, Fbacktrace_frame, mark_backtrace):
11177 Remove unneeded casts.
11178
1c470562
SM
11179 * bytecode.c (Fbyte_code): CAR and CDR can GC.
11180
888adce9
ZK
111812011-03-30 Zachary Kanfer <zkanfer@gmail.com> (tiny change)
11182
11183 * keyboard.c (Fexecute_extended_command): Do log the "suggest key
11184 binding" message (bug#7967).
11185
f838ed7b
PE
111862011-03-30 Paul Eggert <eggert@cs.ucla.edu>
11187
77861b95
PE
11188 Fix more problems found by GCC 4.6.0's static checks.
11189
de6dbc14
PE
11190 * unexelf.c (unexec) [! (defined _SYSTYPE_SYSV || defined __sgi)]:
11191 Remove unused local var.
11192
f838ed7b
PE
11193 * editfns.c (Fmessage_box): Remove unused local var.
11194
792c7b2b
PE
11195 * xdisp.c (try_window_reusing_current_matrix, x_produce_glyphs):
11196 (note_mode_line_or_margin_highlight, note_mouse_highlight):
11197 Omit unused local vars.
c499e557 11198 * window.c (shrink_windows): Omit unused local var.
b01a1c29 11199 * menu.c (digest_single_submenu): Omit unused local var.
0bc32927
PE
11200 * dispnew.c (update_window) [PERIODIC_PREEMPTION_CHECKING]:
11201 Omit unused local var.
11202
ba0165e1
PE
11203 * keyboard.c (parse_modifiers_uncached, parse_modifiers):
11204 Don't assume string length fits in int.
32ad8845 11205 (keyremap_step, read_key_sequence): Use size_t for sizes.
48011560 11206 (read_key_sequence): Don't check last_real_key_start redundantly.
ba0165e1 11207
3c59b4c9
PE
11208 * callproc.c (Fcall_process, Fcall_process_region): Use SAFE_ALLOCA
11209 instead of alloca (Bug#8344).
11210
a3eed478 11211 * eval.c (Fbacktrace): Don't assume nargs fits in int.
5d5d959d 11212 (Fbacktrace_frame): Don't assume nframes fits in int.
a3eed478 11213
eb4d412d
PE
11214 * syntax.c (scan_sexps_forward): Avoid pointer wraparound.
11215
1658b401
PE
11216 * xterm.c (x_make_frame_visible, same_x_server): Redo to avoid overflow
11217 concerns.
11218
11219 * term.c (produce_glyphless_glyph): Remove unnecessary test.
11220
11221 * cm.c (calccost): Turn while-do into do-while, for clarity.
44f730c8 11222
9a2c6e05
PE
11223 * keyboard.c (syms_of_keyboard): Use the same style as later
11224 in this function when indexing through an array. This also
11225 works around GCC bug 48267.
11226
03d0a109
PE
11227 * image.c (tiff_load): Fix off-by-one image count (Bug#8336).
11228
44f730c8
PE
11229 * xselect.c (x_check_property_data): Return correct size (Bug#8335).
11230
fe75f926
PE
11231 * chartab.c (sub_char_table_ref_and_range): Redo for slight
11232 efficiency gain, and to bypass a gcc -Wstrict-overflow warning.
11233
ffa8c828
PE
11234 * keyboard.c, keyboard.h (num_input_events): Now size_t.
11235 This avoids undefined behavior on integer overflow, and is a bit
11236 more convenient anyway since it is compared to a size_t variable.
11237
c5101a77
PE
11238 Variadic C functions now count arguments with size_t, not int.
11239 This avoids an unnecessary limitation on 64-bit machines, which
11240 caused (substring ...) to crash on large vectors (Bug#8344).
11241 * lisp.h (struct Lisp_Subr.function.aMANY): Now takes size_t, not int.
11242 (DEFUN_ARGS_MANY, internal_condition_case_n, safe_call): Likewise.
77861b95 11243 All variadic functions and their callers changed accordingly.
c5101a77
PE
11244 (struct gcpro.nvars): Now size_t, not int. All uses changed.
11245 * data.c (arith_driver, float_arith_driver): Likewise.
11246 * editfns.c (general_insert_function): Likewise.
11247 * eval.c (struct backtrace.nargs, interactive_p)
11248 (internal_condition_case_n, run_hook_with_args, apply_lambda)
11249 (funcall_lambda, mark_backtrace): Likewise.
11250 * fns.c (concat): Likewise.
11251 * frame.c (x_set_frame_parameters): Likewise.
11252 * fns.c (get_key_arg): Now accepts and returns size_t, and returns
11253 0 if not found, not -1. All callers changed.
11254
dd3f25f7
PE
11255 * alloc.c (garbage_collect): Don't assume stack size fits in int.
11256 (stack_copy_size): Now size_t, not int.
11257 (stack_copy, stack_copy_size): Define only if MAX_SAVE_STACK > 0.
11258
461c2ab9
JB
112592011-03-28 Juanma Barranquero <lekktu@gmail.com>
11260
11261 * coding.c (encode_designation_at_bol): Remove parameter `charbuf_end',
11262 unused since 2002-03-01T01:17:24Z!handa@m17n.org and 2008-02-01T16:01:31Z!miles@gnu.org.
11263 All callers changed.
11264
11265 * lisp.h (multibyte_char_to_unibyte):
11266 * character.c (multibyte_char_to_unibyte): Remove parameter `rev_tbl',
11267 unused since 2002-03-01T01:16:34Z!handa@m17n.org and 2008-02-01T16:01:31Z!miles@gnu.org.
11268 * character.h (CHAR_TO_BYTE8):
11269 * cmds.c (internal_self_insert):
11270 * editfns.c (general_insert_function):
11271 * keymap.c (push_key_description):
11272 * search.c (Freplace_match):
11273 * xdisp.c (message_dolog, set_message_1): All callers changed.
11274
f6d62986
SM
112752011-03-28 Stefan Monnier <monnier@iro.umontreal.ca>
11276
11277 * keyboard.c (safe_run_hook_funcall): New function.
11278 (safe_run_hooks_1, safe_run_hooks_error, safe_run_hooks): On error,
11279 don't set the hook to nil, but remove the offending function instead.
11280 (Qcommand_hook_internal): Remove, unused.
11281 (syms_of_keyboard): Don't initialize Qcommand_hook_internal nor define
11282 Vcommand_hook_internal.
11283
11284 * eval.c (enum run_hooks_condition): Remove.
11285 (funcall_nil, funcall_not): New functions.
11286 (run_hook_with_args): Call each function through a `funcall' argument.
11287 Remove `cond' argument, now redundant.
11288 (Frun_hooks, Frun_hook_with_args, Frun_hook_with_args_until_success)
11289 (Frun_hook_with_args_until_failure): Adjust accordingly.
11290 (run_hook_wrapped_funcall, Frun_hook_wrapped): New functions.
11291
1db5b1ad
JB
112922011-03-28 Juanma Barranquero <lekktu@gmail.com>
11293
11294 * dispextern.h (string_buffer_position): Remove declaration.
11295
11296 * print.c (strout): Remove parameter `multibyte', unused since
11297 1999-08-21T19:30:21Z!gerd@gnu.org. All callers changed.
11298
11299 * search.c (boyer_moore): Remove parameters `len', `pos' and `lim',
11300 never used since function introduction in 1998-02-08T21:33:56Z!rms@gnu.org.
11301 All callers changed.
11302
11303 * w32.c (_wsa_errlist): Use braces for struct initializers.
11304
11305 * xdisp.c (string_buffer_position_lim): Remove parameter `w',
11306 never used since function introduction in 2001-03-09T18:41:50Z!gerd@gnu.org.
11307 All callers changed.
11308 (string_buffer_position): Likewise. Also, make static (it's never
11309 used outside xdisp.c).
11310 (cursor_row_p): Remove parameter `w', unused since
11311 2000-10-17T16:08:57Z!gerd@gnu.org. All callers changed.
11312 (decode_mode_spec): Remove parameter `precision', introduced during
11313 Gerd Moellmann's rewrite at 1999-07-21T21:43:52Z!gerd@gnu.org, but never used.
11314 All callers changed.
11315
5ffb62aa
JD
113162011-03-27 Jan Djärv <jan.h.d@swipnet.se>
11317
11318 * nsterm.m (syms_of_nsterm): Use doc: for ns-auto-hide-menu-bar.
11319
461c2ab9 113202011-03-27 Anders Lindgren <andlind@gmail.com>
f0a1382a
JD
11321
11322 * nsterm.m (ns_menu_bar_is_hidden): New variable.
11323 (ns_constrain_all_frames, ns_menu_bar_should_be_hidden)
11324 (ns_update_auto_hide_menu_bar): New functions.
11325 (ns_update_begin): Call ns_update_auto_hide_menu_bar.
11326 (applicationDidBecomeActive): Call ns_update_auto_hide_menu_bar and
11327 ns_constrain_all_frames.
11328 (constrainFrameRect): Return at once if ns_menu_bar_should_be_hidden.
11329 (syms_of_nsterm): DEFVAR ns-auto-hide-menu-bar, init to Qnil.
11330
5c380ffb
JD
113312011-03-27 Jan Djärv <jan.h.d@swipnet.se>
11332
11333 * nsmenu.m (runDialogAt): Remove argument to timer_check.
11334
9af30bdf
GM
113352011-03-27 Glenn Morris <rgm@gnu.org>
11336
11337 * syssignal.h: Replace RETSIGTYPE with void.
11338 * atimer.c, data.c, dispnew.c, emacs.c, floatfns.c, keyboard.c:
11339 * keyboard.h, lisp.h, process.c, sysdep.c, xterm.c:
11340 Replace SIGTYPE with void everywhere.
11341 * s/usg5-4-common.h (SIGTYPE): Remove definition.
11342 * s/template.h (SIGTYPE): Remove commented out definition.
11343
e2abce01
JB
113442011-03-26 Eli Zaretskii <eliz@gnu.org>
11345
11346 * xdisp.c (redisplay_window): Don't check buffer's clip_changed
11347 flag as a prerequisite for invoking try_scrolling. (Bug#6671)
11348
f868cd8a
JB
113492011-03-26 Juanma Barranquero <lekktu@gmail.com>
11350
59eb0929
JB
11351 * w32.c (read_unc_volume): Use parameter `henum', instead of
11352 global variable `wget_enum_handle'.
11353
11354 * keymap.c (describe_vector): Remove parameters `indices' and
11355 `char_table_depth', unused since 2002-03-01T01:43:26Z!handa@m17n.org.
11356 (describe_map, Fdescribe_vector): Adjust calls to `describe_vector'.
11357
f868cd8a
JB
11358 * keyboard.h (timer_check, show_help_echo): Remove unused parameters.
11359
11360 * keyboard.c (timer_check): Remove parameter `do_it_now',
11361 unused since 1996-04-12T06:01:29Z!rms@gnu.org.
11362 (show_help_echo): Remove parameter `ok_to_overwrite_keystroke_echo',
11363 unused since 2008-04-19T19:30:53Z!monnier@iro.umontreal.ca.
11364
11365 * keyboard.c (read_char):
11366 * w32menu.c (w32_menu_display_help):
11367 * xmenu.c (show_help_event, menu_help_callback):
11368 Adjust calls to `show_help_echo'.
11369
11370 * gtkutil.c (xg_maybe_add_timer):
11371 * keyboard.c (readable_events):
11372 * process.c (wait_reading_process_output):
11373 * xmenu.c (x_menu_wait_for_event): Adjust calls to `timer_check'.
11374
11375 * insdel.c (adjust_markers_gap_motion):
11376 Remove; no-op since 1998-01-02T21:29:48Z!rms@gnu.org.
11377 (gap_left, gap_right): Don't call it.
11378
2ecf6fdb
CY
113792011-03-25 Chong Yidong <cyd@stupidchicken.com>
11380
11381 * xdisp.c (handle_fontified_prop): Discard changes to clip_changed
11382 incurred during fontification.
11383
6b1f9ba4
JB
113842011-03-25 Juanma Barranquero <lekktu@gmail.com>
11385
11386 * buffer.c (defvar_per_buffer): Remove unused parameter `doc'.
11387 (DEFVAR_PER_BUFFER): Don't pass it.
11388
11389 * dispnew.c (row_equal_p, add_row_entry): Remove unused parameter `w'.
11390 (scrolling_window): Don't pass it.
11391
0f4a96b5
JB
113922011-03-25 Juanma Barranquero <lekktu@gmail.com>
11393
11394 * dispextern.h (glyph_matric): Use #if GLYPH_DEBUG, not #ifdef.
11395
11396 * fileio.c (check_executable) [DOS_NT]: Remove unused variables `len'
11397 and `suffix'.
11398 (Fset_file_selinux_context) [HAVE_LIBSELINUX]: Move here declaration
11399 of variables specific to SELinux and computation of `encoded_absname'.
11400
11401 * image.c (XPutPixel): Remove unused variable `height'.
11402
11403 * keyboard.c (make_lispy_event): Remove unused variable `hpos'.
11404
11405 * unexw32.c (get_section_info): Remove unused variable `section'.
11406
11407 * w32.c (stat): Remove unused variables `drive_root' and `devtype'.
11408 (system_process_attributes): Remove unused variable `sess'.
11409 (sys_read): Remove unused variable `err'.
11410
11411 * w32fns.c (top): Wrap variables with #if GLYPH_DEBUG, not #ifdef.
11412 (w32_wnd_proc): Remove unused variable `isdead'.
11413 (unwind_create_frame): Use #if GLYPH_DEBUG, not #ifdef.
11414 (Fx_server_max_request_size): Remove unused variable `dpyinfo'.
11415 (x_create_tip_frame): Remove unused variable `tem'.
11416
11417 * w32inevt.c (w32_console_read_socket):
11418 Remove unused variable `no_events'.
11419
11420 * w32term.c (x_draw_composite_glyph_string_foreground):
11421 Remove unused variable `width'.
11422
1149507c
JB
114232011-03-24 Juanma Barranquero <lekktu@gmail.com>
11424
11425 * w32term.c (x_set_glyph_string_clipping):
11426 Don't pass uninitialized region to CombineRgn.
11427
9c88f339
JB
114282011-03-23 Juanma Barranquero <lekktu@gmail.com>
11429
11430 * w32fns.c (x_set_menu_bar_lines): Remove unused variable `olines'.
11431 (w32_wnd_proc): Pass NULL to Windows API, not uninitialized buffer.
11432 (Fx_close_connection): Remove unused variable `i'.
11433
11434 * w32font.c (w32font_draw): Return number of glyphs.
11435 (w32font_open_internal): Remove unused variable `i'.
11436 (w32font_driver): Add missing initializer.
11437
11438 * w32menu.c (utf8to16): Remove unused variable `utf16'.
11439 (fill_in_menu): Remove unused variable `items_added'.
11440
11441 * w32term.c (last_mouse_press_frame): Remove static global variable.
11442 (w32_clip_to_row): Remove unused variable `f'.
11443 (x_delete_terminal): Remove unused variable `i'.
11444
11445 * w32uniscribe.c (uniscribe_shape): Remove unused variable `nclusters'.
11446 (NOTHING): Remove unused static global variable.
11447 (uniscribe_check_otf): Remove unused variable `table'.
11448 (uniscribe_font_driver): Add missing initializers.
11449
dee091a3
JD
114502011-03-23 Julien Danjou <julien@danjou.info>
11451
11452 * term.c (Fsuspend_tty, Fresume_tty):
11453 * minibuf.c (read_minibuf, run_exit_minibuf_hook):
11454 * window.c (temp_output_buffer_show):
11455 * insdel.c (signal_before_change):
11456 * frame.c (Fhandle_switch_frame):
11457 * fileio.c (Fdo_auto_save):
11458 * emacs.c (Fkill_emacs):
11459 * editfns.c (save_excursion_restore):
11460 * cmds.c (internal_self_insert):
11461 * callint.c (Fcall_interactively):
11462 * buffer.c (Fkill_all_local_variables):
11463 * keyboard.c (Fcommand_execute, Fsuspend_emacs, safe_run_hooks_1):
11464 Use Frun_hooks.
0f4a96b5 11465 (command_loop_1): Use Frun_hooks. Call safe_run_hooks
e9fce1ac 11466 unconditionally since it does the check itself.
dee091a3 11467
2c520ab5 114682011-03-23 Paul Eggert <eggert@cs.ucla.edu>
f0641eff 11469
c9c49752
PE
11470 Fix more problems found by GCC 4.5.2's static checks.
11471
8abc3f12
PE
11472 * coding.c (encode_coding_raw_text): Avoid unnecessary test
11473 the first time through the loop, since we know p0 < p1 then.
11474 This also avoids a gcc -Wstrict-overflow warning.
11475
a2d26660
PE
11476 * lisp.h (SAFE_ALLOCA, SAFE_ALLOCA_LISP): Avoid 'int' overflow
11477 leading to a memory leak, possible in functions like
11478 load_charset_map_from_file that can allocate an unbounded number
b12ef411 11479 of objects (Bug#8318).
a2d26660 11480
916c72e9
PE
11481 * xmenu.c (set_frame_menubar): Use EMACS_UINT, not int, for indexes
11482 that could (at least in theory) be that large.
11483
19ab8a18
PE
11484 * xdisp.c (message_log_check_duplicate): Return unsigned long, not int.
11485 This is less likely to overflow, and avoids undefined behavior if
11486 overflow does occur. All callers changed. Use strtoul to scan
11487 for the unsigned long integer.
b7cbbd6f
PE
11488 (pint2hrstr): Simplify and tune code slightly.
11489 This also avoids a (bogus) GCC warning with gcc -Wstrict-overflow.
19ab8a18 11490
f0641eff
PE
11491 * scroll.c (do_scrolling): Work around GCC bug 48228.
11492 See <http://gcc.gnu.org/bugzilla/show_bug.cgi?id=48228>.
11493
7f650bb9
PE
11494 * frame.c (Fmodify_frame_parameters): Simplify loop counter.
11495 This also avoids a warning with gcc -Wstrict-overflow.
39f5e519
PE
11496 (validate_x_resource_name): Simplify count usage.
11497 This also avoids a warning with gcc -Wstrict-overflow.
7f650bb9 11498
37dd57d1
PE
11499 * fileio.c (Fcopy_file): Report error if fchown or fchmod
11500 fail (Bug#8306).
81e56e61 11501
699979fc 11502 * emacs.c (Fdaemon_initialized): Do not ignore I/O errors (Bug#8303).
dc1ca6a8 11503
401bf9b4
PE
11504 * process.c (Fmake_network_process): Use socklen_t, not int,
11505 where POSIX says socklen_t is required in portable programs.
11506 This fixes a porting bug on hosts like 64-bit HP-UX, where
591b2973 11507 socklen_t is wider than int (Bug#8277).
401bf9b4
PE
11508 (Fmake_network_process, server_accept_connection):
11509 (wait_reading_process_output, read_process_output):
11510 Likewise.
11511
b93aacde
PE
11512 * process.c: Rename or move locals to avoid shadowing.
11513 (list_processes_1, Fmake_network_process):
11514 (read_process_output_error_handler, exec_sentinel_error_handler):
11515 Rename or move locals.
4dc343ee 11516 (Fmake_network_process): Define label "retry_connect" only if needed.
0da49335 11517 (Fnetwork_interface_info): Fix pointer signedness.
f990b4e5 11518 (process_send_signal): Add cast to avoid pointer signedness problem.
7b808126 11519 (FIRST_PROC_DESC, IF_NON_BLOCKING_CONNECT): Remove unused macros.
c939f91b 11520 (create_process): Use 'volatile' to avoid vfork clobbering (Bug#8298).
b93aacde 11521
af8a867c 11522 Make tparam.h and terminfo.c consistent.
44f230aa
SM
11523 * cm.c (tputs, tgoto, BC, UP): Remove extern decls.
11524 Include tparam.h instead, since it declares them.
af8a867c
PE
11525 * cm.h (PC): Remove extern decl; tparam.h now does this.
11526 * deps.mk (cm.o, terminfo.o): Depend on tparam.h.
11527 * terminfo.c: Include tparam.h, to check interfaces.
11528 (tparm): Make 1st arg a const pointer in decl. Put it at top level.
11529 (tparam): Adjust signature to match interface in tparam.h;
11530 this removes some undefined behavior. Check that outstring and len
11531 are zero, which they always are with Emacs.
11532 * tparam.h (PC, BC, UP): New extern decls.
11533
0248044d 11534 * xftfont.c (xftfont_shape): Now static, and defined only if needed.
001a7ab4 11535 (xftfont_open): Rename locals to avoid shadowing.
0248044d 11536
8ff096c1 11537 * ftfont.c (ftfont_resolve_generic_family): Fix pointer signedness.
a00924bb
PE
11538 (ftfont_otf_capability, ftfont_shape): Omit decls if not needed.
11539 (OTF_TAG_SYM): Omit macro if not needed.
e932860f 11540 (ftfont_list): Remove unused local.
49eaafba
PE
11541 (get_adstyle_property, ftfont_pattern_entity):
11542 (ftfont_lookup_cache, ftfont_open, ftfont_anchor_point):
11543 Rename locals to avoid shadowing.
8ff096c1 11544
e2be39f6
PE
11545 * xfont.c (xfont_list_family): Mark var as initialized.
11546
c9735e30
PE
11547 * xml.c (make_dom): Now static.
11548
8f5201ae
PE
11549 * composite.c (composition_compute_stop_pos): Rename local to
11550 avoid shadowing.
b246f932
PE
11551 (composition_reseat_it): Remove unused locals.
11552 (find_automatic_composition, composition_adjust_point): Likewise.
80e079b2 11553 (composition_update_it): Mark var as initialized.
11b61122
PE
11554 (find_automatic_composition): Mark vars as initialized,
11555 with a FIXME (Bug#8290).
8f5201ae 11556
760fbc2c
PE
11557 character.h: Rename locals to avoid shadowing.
11558 * character.h (PREV_CHAR_BOUNDARY, FETCH_STRING_CHAR_ADVANCE):
11559 (FETCH_STRING_CHAR_AS_MULTIBYTE_ADVANCE, FETCH_CHAR_ADVANCE):
11560 (FETCH_CHAR_ADVANCE_NO_CHECK, INC_POS, DEC_POS, BUF_INC_POS):
11561 (BUF_DEC_POS): Be more systematic about renaming local temporaries
11562 to avoid shadowing.
11563
ff08eb85
PE
11564 * textprop.c (property_change_between_p): Remove; unused.
11565
fc7bf025
PE
11566 * intervals.c (interval_start_pos): Now static.
11567
235d7abc
PE
11568 * intervals.h (CHECK_TOTAL_LENGTH): Avoid empty "else".
11569
44f230aa
SM
11570 * atimer.c (start_atimer, append_atimer_lists, set_alarm):
11571 Rename locals to avoid shadowing.
3e7d6594 11572
50060332
PE
11573 * sound.c (wav_play, au_play, Fplay_sound_internal):
11574 Fix pointer signedness.
d01f234b 11575 (alsa_choose_format): Remove unused local var.
c83b8872
PE
11576 (wav_play): Initialize a variable to 0, to prevent undefined
11577 behavior (Bug#8278).
50060332 11578
c4fc4e30
PE
11579 * region-cache.c (insert_cache_boundary): Redo var to avoid shadowing.
11580
918436ed
PE
11581 * region-cache.h (pp_cache): New decl, for gcc -Wmissing-prototypes.
11582
c939f91b
PE
11583 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork
11584 clobbering (Bug#8298).
b9c7f648
PE
11585 * sysdep.c (sys_subshell): Likewise.
11586 Previously, the sys_subshell 'volatile' was incorrectly IF_LINTted out.
7e9123a2 11587
6bd8c144
PE
11588 * lisp.h (child_setup): Now NO_RETURN unless DOS_NT.
11589 This should get cleaned up, so that child_setup has the
11590 same signature on all platforms.
11591
7710357c 11592 * callproc.c (call_process_cleanup): Now static.
cb1d0ef7 11593 (relocate_fd): Rename locals to avoid shadowing.
7710357c 11594
c59da222
CY
115952011-03-22 Chong Yidong <cyd@stupidchicken.com>
11596
11597 * xterm.c (x_clear_frame): Remove XClearWindow call. This appears
11598 not to be necessary, and produces flickering.
11599
66b87493
GM
116002011-03-20 Glenn Morris <rgm@gnu.org>
11601
11602 * config.in: Remove file.
11603
45b6f6d5
JB
116042011-03-20 Juanma Barranquero <lekktu@gmail.com>
11605
11606 * minibuf.c (Vcompleting_read_function): Don't declare, global variables
11607 are now in src/globals.h.
11608 (syms_of_minibuf): Remove spurious & from previous change.
11609
cd394be1 116102011-03-20 Leo Liu <sdl.web@gmail.com>
3ec03f7e
LL
11611
11612 * minibuf.c (completing-read-function): New variable.
11613 (completing-read-default): Rename from completing-read.
11614 (completing-read): Call completing-read-function.
11615
b14e3e21
CY
116162011-03-19 Juanma Barranquero <lekktu@gmail.com>
11617
11618 * xfaces.c (Fx_load_color_file):
11619 Read color file from absolute filename (bug#8250).
11620
f2b726e6
JB
116212011-03-19 Juanma Barranquero <lekktu@gmail.com>
11622
11623 * makefile.w32-in: Update dependencies.
11624
09f6ff02
EZ
116252011-03-17 Eli Zaretskii <eliz@gnu.org>
11626
11627 * makefile.w32-in ($(BLD)/unexw32.$(O)): Depend on $(SRC)/unexec.h.
11628
29a6015a
PE
116292011-03-17 Paul Eggert <eggert@cs.ucla.edu>
11630
a3a6c54e
PE
11631 Fix more problems found by GCC 4.5.2's static checks.
11632
b766f867
PE
11633 * process.c (make_serial_process_unwind, send_process_trap):
11634 (sigchld_handler): Now static.
11635
be02381c
PE
11636 * process.c (allocate_pty): Let PTY_ITERATION declare iteration vars.
11637 That way, the code declares only the vars that it needs.
11638 * s/aix4-2.h (PTY_ITERATION): Declare iteration vars.
11639 * s/cygwin.h (PTY_ITERATION): Likewise.
11640 * s/darwin.h (PTY_ITERATION): Likewise.
11641 * s/gnu-linux.h (PTY_ITERATION): Likewise.
11642
57048744
PE
11643 * s/irix6-5.h (PTY_OPEN): Declare stb, to loosen coupling.
11644 * process.c (allocate_pty): Don't declare stb unless it's needed.
11645
7914961c 11646 * bytecode.c (MAYBE_GC): Rewrite so as not to use empty "else".
615f2d59
PE
11647 (CONSTANTLIM): Remove; unused.
11648 (METER_CODE, Bscan_buffer, Bread_char, Bset_mark):
11649 Define only if needed.
7914961c 11650
b3967b18
PE
11651 * unexelf.c (unexec): Name an expression,
11652 to avoid gcc -Wbad-function-cast warning.
9ae71512
PE
11653 Use a different way to cause a compilation error if anyone uses
11654 n rather than nn, a way that does not involve shadowing.
73366a00 11655 (ELF_BSS_SECTION_NAME, OLD_PROGRAM_H): Remove; unused.
b3967b18 11656
29a6015a
PE
11657 * deps.mk (unexalpha.o): Remove; unused.
11658
43cfc33e 11659 New file unexec.h, the (simple) interface for unexec (Bug#8267).
7feda0d2 11660 * unexec.h: New file.
ce701a33
PE
11661 * deps.mk (emacs.o, unexaix.o, unexcw.o, unexcoff.o, unexelf.o):
11662 (unexhp9k800.o, unexmacosx.o, unexsol.o, unexw32.o):
11663 Depend on unexec.h.
11664 * emacs.c [!defined CANNOT_DUMP]: Include unexec.h.
11665 * unexaix.c, unexcoff.c, unexcw.c, unexelf.c, unexhp9k800.c:
11666 * unexmacosx.c, unexsol.c, unexw32.c: Include unexec.h.
381259ef 11667 Change as necessary to match prototype in unexec.h.
ce701a33 11668
01f44d5a
PE
11669 * syntax.c (Fforward_comment, scan_lists): Rename locals to avoid
11670 shadowing.
4f63c6bb 11671 (back_comment, skip_chars): Mark vars as initialized.
01f44d5a 11672
a6670b0b
PE
11673 * character.h (FETCH_STRING_CHAR_ADVANCE_NO_CHECK, BUF_INC_POS):
11674 Rename locals to avoid shadowing.
11675
cef2010d 11676 * lread.c (read1): Rewrite so as not to use empty "else".
0902fe45 11677 (Fload, readevalloop, read1): Rename locals to avoid shadowing.
cef2010d 11678
d4d7173a
PE
11679 * print.c (Fredirect_debugging_output): Fix pointer signedess.
11680
f08b802a
PE
11681 * lisp.h (debug_output_compilation_hack): Add decl here, to avoid
11682 warning when compiling print.c.
11683
3ddb0639
PE
11684 * font.c (font_unparse_fcname): Abort in an "impossible" situation
11685 instead of using an uninitialized var.
5ad03b97 11686 (font_sort_entities): Mark var as initialized.
3ddb0639 11687
170a2692
PE
11688 * character.h (FETCH_CHAR_ADVANCE): Rename locals to avoid shadowing.
11689
e663c700
PE
11690 * font.c (font_unparse_xlfd): Don't mix pointers to variables with
11691 pointers to constants.
89bc529a 11692 (font_parse_fcname): Remove unused vars.
7b81e2d0 11693 (font_delete_unmatched): Now static.
ea838e10 11694 (font_get_spec): Remove; unused.
13a547c6
PE
11695 (font_style_to_value, font_prop_validate_style, font_unparse_fcname):
11696 (font_update_drivers, Ffont_get_glyphs, font_add_log):
11697 Rename or move locals to avoid shadowing.
e663c700 11698
2a80c887 11699 * fns.c (require_nesting_list, require_unwind): Now static.
612f56df 11700 (Ffillarray): Rename locals to avoid shadowing.
2a80c887 11701
1384fa33 11702 * floatfns.c (domain_error2): Define only if needed.
a885e2ed 11703 (Ffrexp, Fldexp): Rename locals to avoid shadowing.
1384fa33 11704
8b2c52e9
PE
11705 * alloc.c (mark_backtrace): Move decl from here ...
11706 * lisp.h: ... to here, so that it can be checked.
11707
475545b5 11708 * eval.c (call_debugger, do_debug_on_call, grow_specpdl): Now static.
d28a2170 11709 (Fdefvar): Rewrite so as not to use empty "else".
cfcbfb1a
PE
11710 (lisp_indirect_variable): Name an expression,
11711 to avoid gcc -Wbad-function-cast warning.
1faed8ae 11712 (Fdefvar): Rename locals to avoid shadowing.
475545b5 11713
b1349114 11714 * callint.c (quotify_arg, quotify_args): Now static.
a3e8cbda 11715 (Fcall_interactively): Rename locals to avoid shadowing.
b0e80955 11716 Use const pointer when appropriate.
b1349114 11717
a2928364
PE
11718 * lisp.h (get_system_name, get_operating_system_release):
11719 Move decls here, to check interfaces.
11720 * process.c (get_operating_system_release): Move decl to lisp.h.
11721 * xrdb.c (get_system_name): Likewise.
63c5d10b
PE
11722 * editfns.c (init_editfns, Fuser_login_name, Fuser_uid):
11723 (Fuser_real_uid, Fuser_full_name): Remove unnecessary casts,
11724 some of which prompt warnings from gcc -Wbad-function-cast.
545b49b4
PE
11725 (Fformat_time_string, Fencode_time, Finsert_char):
11726 (Ftranslate_region_internal, Fformat):
11727 Rename or remove local vars to avoid shadowing.
9710023e 11728 (Ftranslate_region_internal): Mark var as initialized.
63c5d10b 11729
a415e694
PE
11730 * doc.c (Fdocumentation, Fsnarf_documentation): Move locals to
11731 avoid shadowing.
11732
8ef4622d
PE
11733 * lisp.h (eassert): Check that the argument compiles, even if
11734 ENABLE_CHECKING is not defined.
11735
946f9a5b
PE
11736 * data.c (Findirect_variable): Name an expression, to avoid
11737 gcc -Wbad-function-cast warning.
112396d6 11738 (default_value, arithcompare, arith_driver, arith_error): Now static.
b9b84fa9 11739 (store_symval_forwarding): Rename local to avoid shadowing.
44f230aa
SM
11740 (Fmake_variable_buffer_local, Fmake_local_variable):
11741 Mark variables as initialized.
52746918 11742 (do_blv_forwarding, do_symval_forwarding): Remove; unused.
946f9a5b 11743
e5aab7e7 11744 * alloc.c (check_cons_list): Do not define unless GC_CHECK_CONS_LIST.
ae35e756
PE
11745 (Fmake_vector, Fvector, Fmake_byte_code, Fgarbage_collect):
11746 Rename locals to avoid shadowing.
dff45157
PE
11747 (mark_stack): Move local variables into the #ifdef region where
11748 they're used.
7bc26fdb
PE
11749 (BLOCK_INPUT_ALLOC, UNBLOCK_INPUT_ALLOC): Define only if
11750 ! defined SYSTEM_MALLOC && ! defined SYNC_INPUT, as they are not
11751 needed otherwise.
11752 (CHECK_ALLOCATED): Define only if GC_CHECK_MARKED_OBJECTS.
11753 (GC_STRING_CHARS): Remove; not used.
d40d4be1 11754 (Fmemory_limit): Cast sbrk's returned value to char *.
ae35e756 11755
e5aab7e7
PE
11756 * lisp.h (check_cons_list): Declare if GC_CHECK_CONS_LIST; this
11757 avoids undefined behavior in theory.
11758
4da60324
PE
11759 * regex.c (IF_LINT): Add defn, for benefit of ../lib-src.
11760
88043301
PE
11761 Use functions, not macros, for up- and down-casing (Bug#8254).
11762 * buffer.h (DOWNCASE_TABLE, UPCASE_TABLE, DOWNCASE, UPPERCASEP):
11763 (NOCASEP, LOWERCASEP, UPCASE, UPCASE1): Remove. All callers changed
11764 to use the following functions instead of these macros.
11765 (downcase): Adjust to lack of DOWNCASE_TABLE. Return int, not
11766 EMACS_INT, since callers assume the returned value fits in int.
11767 (upcase1): Likewise, for UPCASE_TABLE.
11768 (uppercasep, lowercasep, upcase): New static inline functions.
0da09c43 11769 * editfns.c (Fchar_equal): Remove no-longer-needed workaround for
db69b0cd 11770 the race-condition problem in the old DOWNCASE.
88043301 11771
19ed5445
PE
11772 * regex.c (CHARSET_LOOKUP_RANGE_TABLE_RAW, POP_FAILURE_REG_OR_COUNT):
11773 Rename locals to avoid shadowing.
11774 (regex_compile, re_match_2_internal): Move locals to avoid shadowing.
abbd1bcf
PE
11775 (regex_compile, re_search_2, re_match_2_internal):
11776 Remove unused local vars.
952db0d7
PE
11777 (FREE_VAR): Rewrite so as not to use empty "else",
11778 which gcc can warn about.
da053e48 11779 (regex_compile, re_match_2_internal): Mark locals as initialized.
b313f9d8
PE
11780 (RETALLOC_IF): Define only if needed.
11781 (WORDCHAR_P): Likewise. This one is never needed, but is used
11782 only in a comment talking about a compiler bug, so put inside
11783 the #if 0 of that comment.
11784 (CHARSET_LOOKUP_BITMAP, FAIL_STACK_FULL, RESET_FAIL_STACK):
11785 (PUSH_FAILURE_ELT, BUF_PUSH_3, STOP_ADDR_VSTRING):
11786 Remove; unused.
19ed5445 11787
1f3561e4 11788 * search.c (boyer_moore): Rename locals to avoid shadowing.
76ef09b7
PE
11789 * character.h (FETCH_STRING_CHAR_AS_MULTIBYTE_ADVANCE):
11790 (PREV_CHAR_BOUNDARY): Likewise.
1f3561e4 11791
ded6f8f7
PE
11792 * search.c (simple_search): Remove unused var.
11793
dbd37a95
PE
11794 * dired.c (compile_pattern): Move decl from here ...
11795 * lisp.h: ... to here, so that it can be checked.
11796 (struct re_registers): New forward decl.
11797
7e47afad
PE
11798 * character.h (INC_POS, DEC_POS): Rename locals to avoid shadowing.
11799
85f24f61
PE
11800 * indent.c (MULTIBYTE_BYTES_WIDTH): New args bytes, width.
11801 All uses changed.
11802 (MULTIBYTE_BYTES_WIDTH, scan_for_column, compute_motion):
11803 Rename locals to avoid shadowing.
5671df8f 11804 (Fvertical_motion): Mark locals as initialized.
85f24f61 11805
181aa2be 11806 * casefiddle.c (casify_object, casify_region): Now static.
e45a141a 11807 (casify_region): Mark local as initialized.
181aa2be 11808
930d429c
PE
11809 * cmds.c (internal_self_insert): Rename local to avoid shadowing.
11810
7082eac6
PE
11811 * lisp.h (GCPRO2_VAR, GCPRO3_VAR, GCPRO4_VAR, GCPRO5_VAR, GCPRO6_VAR):
11812 New macros, so that the caller can use some names other than
11813 gcpro1, gcpro2, etc.
11814 (GCPRO2, GCPRO3, GCPRO4, GCPRO5, GCPRO6): Reimplement in terms
11815 of the new macros.
11816 (GCPRO1_VAR, UNGCPRO_VAR): Change the meaning of the second
11817 argument, for consistency with GCPRO2_VAR, etc: it is now the
11818 prefix of the variable, not the variable itself. All uses
11819 changed.
38b2c076
PE
11820 * dired.c (directory_files_internal, file_name_completion):
11821 Rename locals to avoid shadowing.
11822
15206ed9
PE
11823 Fix a race condition diagnosed by gcc -Wsequence-point (Bug#8254).
11824 An expression of the form (DOWNCASE (x) == DOWNCASE (y)), found in
11825 dired.c's scmp function, had undefined behavior.
11826 * lisp.h (DOWNCASE_TABLE, UPCASE_TABLE, DOWNCASE, UPPERCASEP):
11827 (NOCASEP, LOWERCASEP, UPCASE, UPCASE1): Move from here ...
11828 * buffer.h: ... to here, because these macros use current_buffer,
11829 and the new implementation with inline functions needs to have
11830 current_buffer in scope now, rather than later when the macros
11831 are used.
11832 (downcase, upcase1): New static inline functions.
11833 (DOWNCASE, UPCASE1): Reimplement using these functions.
11834 This avoids undefined behavior in expressions like
11835 DOWNCASE (x) == DOWNCASE (y), which previously suffered
11836 from race conditions in accessing the global variables
11837 case_temp1 and case_temp2.
11838 * casetab.c (case_temp1, case_temp2): Remove; no longer needed.
11839 * lisp.h (case_temp1, case_temp2): Remove their decls.
11840 * character.h (ASCII_CHAR_P): Move from here ...
11841 * lisp.h: ... to here, so that the inline functions mentioned
11842 above can use them.
11843
4a6bea26
PE
11844 * dired.c (directory_files_internal_unwind): Now static.
11845
f14b7e14
PE
11846 * fileio.c (file_name_as_directory, directory_file_name):
11847 (barf_or_query_if_file_exists, auto_save_error, auto_save_1):
11848 Now static.
2893f146
PE
11849 (file_name_as_directory): Use const pointers when appropriate.
11850 (Fexpand_file_name): Likewise. In particular, newdir might
11851 point at constant storage, so make it a const pointer.
fd4ead52 11852 (Fmake_directory_internal, Fread_file_name): Remove unused vars.
b14aac08
PE
11853 (Ffile_selinux_context, Fset_file_selinux_context): Fix pointer
11854 signedness issues.
f839df0c
PE
11855 (Fset_file_times, Finsert_file_contents, auto_save_error):
11856 Rename locals to avoid shadowing.
f14b7e14 11857
5716756e 11858 * minibuf.c (choose_minibuf_frame_1): Now static.
62137a95
PE
11859 (Ftry_completion, Fall_completions): Rename or remove locals
11860 to avoid shadowing.
5716756e 11861
b4c3046a
PE
11862 * marker.c (bytepos_to_charpos): Remove; unused.
11863
b45db522
PE
11864 * lisp.h (verify_bytepos, count_markers): New decls,
11865 so that gcc does not warn that these functions aren't declared.
11866
85876d07
PE
11867 * insdel.c (check_markers, make_gap_larger, make_gap_smaller):
11868 (reset_var_on_error, Fcombine_after_change_execute_1): Now static.
f0cb4a60 11869 (CHECK_MARKERS): Redo to avoid gcc -Wempty-body diagnostic.
40ef059e 11870 (copy_text): Remove unused local var.
85876d07 11871
03d78a21 11872 * filelock.c (within_one_second): Now static.
b3dd38ab 11873 (lock_file_1): Rename local to avoid shadowing.
03d78a21 11874
5df8f01b
PE
11875 * buffer.c (fix_overlays_before): Mark locals as initialized.
11876 (fix_start_end_in_overlays): Likewise. This function should be
11877 simplified by using pointers-to-pointers, but that's a different
11878 matter.
b1d876f1 11879 (switch_to_buffer_1): Now static.
8f54f30a
PE
11880 (Fkill_buffer, record_buffer, Fbury_buffer, Fset_buffer_multibyte):
11881 (report_overlay_modification): Rename locals to avoid shadowing.
c3bd59b5 11882
a70072c9 11883 * sysdep.c (system_process_attributes): Rename vars to avoid shadowing.
fbd02d7b 11884 Fix pointer signedness issue.
edced198
PE
11885 (sys_subshell): Mark local as volatile if checking for lint,
11886 to suppress a gcc -Wclobbered warning that does not seem to be right.
15dfd3d9 11887 (MAXPATHLEN): Define only if needed.
a70072c9 11888
a0977c44
PE
11889 * process.c (serial_open, serial_configure): Move decls from here ...
11890 * systty.h: ... to here, so that they can be checked.
11891
a884fdcc
PE
11892 * fns.c (get_random, seed_random): Move extern decls from here ...
11893 * lisp.h: ... to here, so that they can be checked.
11894
604efe86 11895 * sysdep.c (reset_io): Now static.
b8950c94 11896 (wait_for_termination_signal): Remove; unused.
604efe86 11897
38fc62d9
PE
11898 * keymap.c (keymap_parent, keymap_memberp, map_keymap_internal):
11899 (copy_keymap_item, append_key, push_text_char_description):
11900 Now static.
1004a21a 11901 (Fwhere_is_internal): Don't test CONSP (sequences) unnecessarily.
dbbb8427 11902 (DENSE_TABLE_SIZE): Remove; unused.
c1141155
PE
11903 (get_keymap, access_keymap, Fdefine_key, Fwhere_is_internal):
11904 (describe_map_tree):
11905 Rename locals to avoid shadowing.
38fc62d9 11906
2f2650da
PE
11907 * keyboard.c: Declare functions static if they are not used elsewhere.
11908 (echo_char, echo_dash, cmd_error, top_level_2):
11909 (poll_for_input, handle_async_input): Now static.
69a058fa
PE
11910 (read_char, kbd_buffer_get_event, make_lispy_position):
11911 (make_lispy_event, make_lispy_movement, apply_modifiers):
11912 (decode_keyboard_code, tty_read_avail_input, menu_bar_items):
11913 (parse_tool_bar_item, read_key_sequence, Fread_key_sequence):
11914 (Fread_key_sequence_vector): Rename locals to avoid shadowing.
c8a06054 11915 (read_key_sequence, read_char): Mark locals as initialized.
3ac94672 11916 (Fexit_recursive_edit, Fabort_recursive_edit): Mark with NO_RETURN.
2f2650da 11917
a053e86c 11918 * keyboard.h (make_ctrl_char): New decl.
da2f2dd9
PE
11919 (mark_kboards): Move decl here ...
11920 * alloc.c (mark_kboards): ... from here.
a053e86c 11921
4752793e
PE
11922 * lisp.h (force_auto_save_soon): New decl.
11923
74f10ca7 11924 * emacs.c (init_cmdargs): Rename local to avoid shadowing.
244fc23d
PE
11925 (DEFINE_DUMMY_FUNCTION): New macro.
11926 (__do_global_ctors, __do_global_ctors_aux, __do_global_dtors, __main):
11927 Use it.
c03cd23f
PE
11928 (main): Add casts to avoid warnings
11929 if GCC considers string literals to be constants.
74f10ca7 11930
022e70d4
PE
11931 * lisp.h (fatal_error_signal): Add decl, since it's exported.
11932
59d6fe83
PE
11933 * dbusbind.c: Pointer signedness fixes.
11934 (xd_signature, xd_append_arg, xd_initialize):
11935 (Fdbus_call_method, Fdbus_call_method_asynchronously):
11936 (Fdbus_method_return_internal, Fdbus_method_error_internal):
11937 (Fdbus_send_signal, xd_read_message_1, Fdbus_register_service):
11938 (Fdbus_register_signal): Use SSDATA when the context wants char *.
11939
78320123
PE
11940 * dbusbind.c (Fdbus_init_bus): Add cast to avoid warning
11941 if GCC considers string literals to be constants.
49cebcca 11942 (Fdbus_register_service, Fdbus_register_method): Remove unused vars.
78320123 11943
35ac2a97
SM
119442011-03-16 Stefan Monnier <monnier@iro.umontreal.ca>
11945
fb103ca9
SM
11946 * print.c (PRINT_CIRCLE_CANDIDATE_P): New macro.
11947 (print_preprocess, print_object): New macro to fix last change.
11948
35ac2a97
SM
11949 * print.c (print_preprocess): Don't forget font objects.
11950
62973b41
JB
119512011-03-16 Juanma Barranquero <lekktu@gmail.com>
11952
11953 * emacs.c (USAGE3): Doc fixes.
11954
0e48bb22
AS
119552011-03-15 Andreas Schwab <schwab@linux-m68k.org>
11956
11957 * coding.c (detect_coding_iso_2022): Reorganize code to clarify
11958 structure.
11959
7684e57b
JB
119602011-03-14 Juanma Barranquero <lekktu@gmail.com>
11961
11962 * lisp.h (VWindow_system, Qfile_name_history):
11963 * keyboard.h (lispy_function_keys) [WINDOWSNT]:
11964 * w32term.h (w32_system_caret_hwnd, w32_system_caret_height)
11965 (w32_system_caret_x, w32_system_caret_y): Declare extern.
11966
11967 * w32select.c: Don't #include "keyboard.h".
c96bbc66 11968 (run_protected): Add extern declaration for waiting_for_input.
7684e57b
JB
11969
11970 * w32.c (Qlocal, noninteractive1, inhibit_window_system):
11971 * w32console.c (detect_input_pending, read_input_pending)
11972 (encode_terminal_code):
11973 * w32fns.c (quit_char, lispy_function_keys, Qtooltip)
11974 (w32_system_caret_hwnd, w32_system_caret_height, w32_system_caret_x)
11975 (w32_system_caret_y, Qfile_name_history):
11976 * w32font.c (w32font_driver, QCantialias, QCotf, QClang):
11977 * w32inevt.c (reinvoke_input_signal, lispy_function_keys):
11978 * w32menu.c (Qmenu_bar, QCtoggle, QCradio, Qoverriding_local_map)
11979 (Qoverriding_terminal_local_map, Qmenu_bar_update_hook):
11980 * w32proc.c (Qlocal, report_file_error):
11981 * w32term.c (Vwindow_system, updating_frame):
11982 * w32uniscribe.c (initialized, uniscribe_font_driver):
11983 Remove unneeded extern declarations.
11984
2aa46d6c
CY
119852011-03-14 Chong Yidong <cyd@stupidchicken.com>
11986
c96bbc66 11987 * buffer.c (Fmake_indirect_buffer): Fix incorrect assertions.
2aa46d6c 11988
cffc6f3b
CY
119892011-03-13 Chong Yidong <cyd@stupidchicken.com>
11990
11991 * buffer.h (BUF_BEGV, BUF_BEGV_BYTE, BUF_ZV, BUF_ZV_BYTE, BUF_PT)
11992 (BUF_PT_BYTE): Rewrite to handle indirect buffers (Bug#8219).
11993 These macros can no longer be used for assignment.
11994
44f230aa
SM
11995 * buffer.c (Fget_buffer_create, Fmake_indirect_buffer):
11996 Assign struct members directly, instead of using BUF_BEGV etc.
cffc6f3b
CY
11997 (record_buffer_markers, fetch_buffer_markers): New functions for
11998 recording and fetching special buffer markers.
11999 (set_buffer_internal_1, set_buffer_temp): Use them.
12000
12001 * lread.c (unreadchar): Use SET_BUF_PT_BOTH.
12002
12003 * insdel.c (adjust_point): Use SET_BUF_PT_BOTH.
12004
12005 * intervals.c (temp_set_point_both): Use SET_BUF_PT_BOTH.
12006 (get_local_map): Use SET_BUF_BEGV_BOTH and SET_BUF_ZV_BOTH.
12007
12008 * xdisp.c (hscroll_window_tree):
12009 (reconsider_clip_changes): Use PT instead of BUF_PT.
12010
d251f04b
EZ
120112011-03-13 Eli Zaretskii <eliz@gnu.org>
12012
12013 * makefile.w32-in ($(BLD)/editfns.$(O)): Depend on
12014 $(EMACS_ROOT)/lib/intprops.h.
12015
f0c77cd1
PE
120162011-03-13 Paul Eggert <eggert@cs.ucla.edu>
12017
3eca4629
PE
12018 Fix more problems found by GCC 4.5.2's static checks.
12019
7c86ee98
PE
12020 * gtkutil.c (xg_get_pixbuf_from_pixmap): Add cast from char *
12021 to unsigned char * to avoid compiler diagnostic.
b0afc268
PE
12022 (xg_free_frame_widgets): Make it clear that a local variable is
12023 needed only if USE_GTK_TOOLTIP.
01e0b5ad
PE
12024 (gdk_window_get_screen): Make it clear that this macro is needed
12025 only if USE_GTK_TOOLTIP.
1e5524e7
PE
12026 (int_gtk_range_get_value): New function, which avoids a diagnostic
12027 from gcc -Wbad-function-cast.
12028 (xg_set_toolkit_scroll_bar_thumb): Use it.
12029 (xg_tool_bar_callback, xg_tool_item_stale_p): Rewrite to avoid
12030 diagnostic from gcc -Wbad-function-cast.
65dc836c
PE
12031 (get_utf8_string, xg_get_file_with_chooser):
12032 Rename locals to avoid shadowing.
12033 (create_dialog): Move locals to avoid shadowing.
7c86ee98 12034
41729b81
PE
12035 * xgselect.c (xg_select): Remove unused var.
12036
f0c77cd1
PE
12037 * image.c (four_corners_best): Mark locals as initialized.
12038 (gif_load): Initialize transparent_p to zero (Bug#8238).
12039 Mark another local as initialized.
ec6cf4c6 12040 (my_png_error, my_error_exit): Mark with NO_RETURN.
f0c77cd1 12041
ce0ad53d 12042 * image.c (clear_image_cache): Now static.
d5d5a617 12043 (DIM, HAVE_STDLIB_H_1): Remove unused macros.
e22cffbc 12044 (xpm_load): Redo to avoid "discards qualifiers" gcc warning.
77a765fd
PE
12045 (x_edge_detection): Remove unnecessary cast that
12046 gcc -Wbad-function-cast diagnoses.
2037898d 12047 (gif_load): Fix pointer signedness.
6ae141d6
PE
12048 (clear_image_cache, xbm_read_bitmap_data, x_detect_edges):
12049 (jpeg_load, gif_load): Rename locals to avoid shadowing.
ce0ad53d 12050
33383987 120512011-03-12 Paul Eggert <eggert@cs.ucla.edu>
3eca4629 12052
d32df629
PE
12053 Improve quality of tests for time stamp overflow.
12054 For example, without this patch (encode-time 0 0 0 1 1
12055 1152921504606846976) returns the obviously-bogus value (-948597
12056 62170) on my RHEL 5.5 x86-64 host. With the patch, it correctly
12057 reports time overflow. See
12058 <http://lists.gnu.org/archive/html/emacs-devel/2011-03/msg00470.html>.
b8d9bd41
PE
12059 * deps.mk (editfns.o): Depend on ../lib/intprops.h.
12060 * editfns.c: Include limits.h and intprops.h.
12061 (TIME_T_MIN, TIME_T_MAX): New macros.
12062 (time_overflow): Move earlier, to before first use.
12063 (hi_time, lo_time): New functions, for an accurate test for
12064 out-of-range times.
12065 (Fcurrent_time, Fget_internal_run_time, make_time): Use them.
12066 (Fget_internal_run_time): Don't assume time_t fits in int.
12067 (make_time): Use list2 instead of Fcons twice.
12068 (Fdecode_time): More accurate test for out-of-range times.
12069 (check_tm_member): New function.
12070 (Fencode_time): Use it, to test for out-of-range times.
d32df629
PE
12071 (lisp_time_argument): Don't rely on undefined left-shift and
12072 right-shift behavior when checking for time stamp overflow.
8be6f318 12073
fe31d94c
PE
12074 * editfns.c (time_overflow): New function, refactoring common code.
12075 (Fformat_time_string, Fdecode_time, Fencode_time):
12076 (Fcurrent_time_string): Use it.
12077
8be6f318
PE
12078 Move 'make_time' to be next to its inverse 'lisp_time_argument'.
12079 * dired.c (make_time): Move to ...
12080 * editfns.c (make_time): ... here.
12081 * systime.h: Note the move.
12082
09d9db2c 120832011-03-12 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
c47cbdfd 12084
126bc0dc
YM
12085 * fringe.c (update_window_fringes): Remove unused variables.
12086
c47cbdfd
YM
12087 * unexmacosx.c (copy_data_segment): Also copy __got section.
12088 (Bug#8223)
12089
7ac80be9
EZ
120902011-03-12 Eli Zaretskii <eliz@gnu.org>
12091
c96bbc66 12092 * termcap.c [MSDOS]: Include "msdos.h".
058e5dad
EZ
12093 (find_capability, tgetnum, tgetflag, tgetstr, tputs, tgetent):
12094 Constify `char *' arguments and their references according to
12095 prototypes in tparam.h.
12096
ecb0f94d 12097 * deps.mk (termcap.o): Depend on tparam.h and msdos.h.
058e5dad 12098
7ac80be9
EZ
12099 * msdos.c (XMenuAddPane): 3rd argument is `const char *' now.
12100 Adapt all references accordingly.
12101
12102 * msdos.h (XMenuAddPane): 3rd argument is `const char *' now.
12103
ef1fd07e
TT
121042011-03-11 Tom Tromey <tromey@redhat.com>
12105
12106 * buffer.c (syms_of_buffer): Remove obsolete comment.
12107
7ef4b50c
EZ
121082011-03-11 Eli Zaretskii <eliz@gnu.org>
12109
12110 * termhooks.h (encode_terminal_code): Declare prototype.
12111
12112 * msdos.c (encode_terminal_code): Don't declare prototype.
12113
12114 * term.c (encode_terminal_code): Now external again, used by
12115 w32console.c and msdos.c.
12116
44f230aa
SM
12117 * makefile.w32-in ($(BLD)/term.$(O), ($(BLD)/tparam.$(O)):
12118 Depend on $(SRC)/tparam.h, see 2011-03-11T07:24:21Z!eggert@cs.ucla.edu.
7ef4b50c 12119
4b1ec863 121202011-03-11 Paul Eggert <eggert@cs.ucla.edu>
f78faa98 12121
1714f52b 12122 Fix some minor problems found by GCC 4.5.2's static checks.
83316bf4 12123
4b1ec863
PE
12124 * fringe.c (update_window_fringes): Mark locals as initialized
12125 (Bug#8227).
12126 (destroy_fringe_bitmap, init_fringe_bitmap): Now static.
bf60f616 12127
524c7aa6
PE
12128 * alloc.c (mark_fringe_data): Move decl from here ...
12129 * lisp.h (mark_fringe_data) [HAVE_WINDOW_SYSTEM]: ... to here,
12130 to check its interface.
12131 (init_fringe_once): Do not declare unless HAVE_WINDOW_SYSTEM.
12132
a5c0af81 12133 * fontset.c (free_realized_fontset): Now static.
7519b8cd 12134 (Fset_fontset_font): Rename local to avoid shadowing.
cc6e5db1 12135 (fontset_font): Mark local as initialized.
a9a06e0b 12136 (FONTSET_SPEC, FONTSET_REPERTORY, RFONT_DEF_REPERTORY): Remove; unused.
a5c0af81 12137
b4716021
PE
12138 * xrdb.c: Include "xterm.h", to check x_load_resources's interface.
12139
811e9bac 12140 * xselect.c (x_disown_buffer_selections): Remove; not used.
7b83e2f1 12141 (TRACE3) [!defined TRACE_SELECTION]: Remove; not used.
aa0daa9f
PE
12142 (x_own_selection, Fx_disown_selection_internal): Rename locals
12143 to avoid shadowing.
12144 (x_handle_dnd_message): Remove local to avoid shadowing.
811e9bac 12145
7e3ab302
PE
12146 * lisp.h (GCPRO1_VAR, UNGCPRO_VAR): New macros,
12147 so that the caller can use some name other than gcpro1.
12148 (GCPRO1, UNGCPRO): Reimplement in terms of the new macros.
58d2d479
PE
12149 * xfns.c (Fx_create_frame, x_create_tip_frame, Fx_show_tip):
12150 (Fx_backspace_delete_keys_p):
12151 Use them to avoid shadowing, and rename vars to avoid shadowing.
12152 (x_decode_color, x_set_name, x_window): Now static.
6b437900 12153 (Fx_create_frame): Add braces to silence GCC warning.
c0951e53 12154 (Fx_file_dialog, Fx_select_font): Fix pointer signedness.
06b0c8a0
PE
12155 (x_real_positions, xg_set_icon_from_xpm_data, x_create_tip_frame):
12156 Remove unused locals.
7e3ab302
PE
12157 (Fx_create_frame, x_create_tip_frame, Fx_show_tip):
12158 (Fx_backspace_delete_keys_p): Rename locals to avoid shadowing.
12159 Some of these renamings use the new GCPRO1_VAR and UNGCPRO_VAR
12160 macros.
f78faa98 12161
e2b13473
PE
12162 * xterm.h (x_mouse_leave): New decl.
12163
77f23912
PE
12164 * xterm.c (x_copy_dpy_color, x_focus_on_frame, x_unfocus_frame):
12165 Remove unused functions.
cdf4ba58
PE
12166 (x_shift_glyphs_for_insert, XTflash, XTring_bell):
12167 (x_calc_absolute_position): Now static.
7411c686 12168 (XTread_socket): Don't define label "out" unless it's used.
2b07bcff 12169 Don't declare local "event" unless it's used.
ed7bf3a5
PE
12170 (x_iconify_frame, x_free_frame_resources): Don't declare locals
12171 unless they are used.
38d0b34a
PE
12172 (XEMBED_VERSION, xembed_set_info): Don't define unless needed.
12173 (x_fatal_error_signal): Remove; not used.
a6067996
PE
12174 (x_draw_image_foreground, redo_mouse_highlight, XTmouse_position):
12175 (x_scroll_bar_report_motion, handle_one_xevent, x_draw_bar_cursor):
12176 (x_error_catcher, x_connection_closed, x_error_handler):
12177 (x_error_quitter, xembed_send_message, x_iconify_frame):
12178 (my_log_handler): Rename locals to avoid shadowing.
28f1c698 12179 (x_delete_glyphs, x_ins_del_lines): Mark with NO_RETURN.
2a8fade0 12180 (x_connection_closed): Tell GCC not to suggest NO_RETURN.
77f23912 12181
44f230aa
SM
12182 * xfaces.c (clear_face_cache, Fx_list_fonts, Fface_font):
12183 Rename or move locals to avoid shadowing.
6b463e58 12184 (tty_defined_color, merge_face_heights): Now static.
5967d051 12185 (free_realized_faces_for_fontset): Remove; not used.
1e9966ea
PE
12186 (Fx_list_fonts): Mark variable that gcc -Wuninitialized
12187 does not deduce is never used uninitialized.
73719eba
PE
12188 (STRDUPA, LSTRDUPA, FONT_POINT_SIZE_QUANTUM): Remove; not used.
12189 (LFACEP): Define only if XASSERTS, as it's not needed otherwise.
071048a3 12190
426994c3 12191 * terminal.c (store_terminal_param): Now static.
5489860b 12192
032f1620 12193 * xmenu.c (menu_highlight_callback): Now static.
9d66f88e 12194 (set_frame_menubar): Remove unused local.
d4323972 12195 (xmenu_show): Rename parameter to avoid shadowing.
6d1f7fee
PE
12196 (xmenu_show, xdialog_show, xmenu_show): Make local pointers "const"
12197 since they might point to immutable storage.
281585b0
PE
12198 (next_menubar_widget_id): Declare only if USE_X_TOOLKIT,
12199 since it's unused otherwise.
032f1620 12200
367c19e5 12201 * xdisp.c (produce_glyphless_glyph): Initialize lower_xoff.
53df7c11 12202 Add a FIXME, since the code still doesn't look right. (Bug#8215)
9f36b9fd
PE
12203 (Fcurrent_bidi_paragraph_direction): Simplify slightly; this
12204 avoids a gcc -Wuninitialized diagnostic.
0e086e8f 12205 (display_line, BUILD_COMPOSITE_GLYPH_STRING, draw_glyphs):
44a3a108
PE
12206 (note_mouse_highlight): Mark variables that gcc -Wuninitialized
12207 does not deduce are never used uninitialized.
70739cbe 12208
07b48fa9
PE
12209 * lisp.h (IF_LINT): New macro, copied from ../lib-src/emacsclient.c.
12210
8868a238 12211 * xdisp.c (redisplay_window): Rename local to avoid shadowing.
4554d213
PE
12212 * window.c (window_loop, size_window):
12213 (run_window_configuration_change_hook, enlarge_window): Likewise.
8868a238 12214
7e5cf297 12215 * window.c (display_buffer): Now static.
d6550a9f
PE
12216 (size_window): Mark variables that gcc -Wuninitialized
12217 does not deduce are never used uninitialized.
a586633d
PE
12218 * window.h (check_all_windows): New decl, to forestall
12219 gcc -Wmissing-prototypes diagnostic.
5b555da1 12220 * dispextern.h (bidi_dump_cached_states): Likewise.
7e5cf297 12221
f6095868
PE
12222 * charset.h (CHECK_CHARSET_GET_CHARSET): Rename locals to avoid
12223 shadowing.
12224 * charset.c (map_charset_for_dump, Fchar_charset): Likewise.
726929c4
PE
12225 Include <limits.h>.
12226 (Fsort_charsets): Redo min/max calculation to shorten the code a bit
12227 and to avoid gcc -Wuninitialized warning.
89ef49df
PE
12228 (load_charset_map): Mark variables that gcc -Wuninitialized
12229 does not deduce are never used uninitialized.
53df7c11 12230 (load_charset): Abort instead of using uninitialized var (Bug#8229).
f6095868 12231
f38b440c
PE
12232 * coding.c (coding_set_source, coding_set_destination):
12233 Use "else { /* comment */ }" rather than "else /* comment */;"
12234 for clarity, and to avoid gcc -Wempty-body warning.
2735d060
PE
12235 (Fdefine_coding_system_internal): Don't redeclare 'i' inside
12236 a block, when the outer 'i' will do.
12237 (decode_coding_utf_8, decode_coding_utf_16, detect_coding_emacs_mule):
12238 (emacs_mule_char, decode_coding_emacs_mule, detect_coding_iso_2022):
12239 (decode_coding_iso_2022, decode_coding_sjis, decode_coding_big5):
12240 (decode_coding_raw_text, decode_coding_charset, get_translation_table):
12241 (Fdecode_sjis_char, Fdefine_coding_system_internal):
12242 Rename locals to avoid shadowing.
12243 * character.h (FETCH_STRING_CHAR_ADVANCE): Likewise.
e2f1bab9
PE
12244 * coding.c (emacs_mule_char, encode_invocation_designation):
12245 Now static, since they're not used elsewhere.
413bb2db 12246 (decode_coding_iso_2022): Add "default: abort ();" as a safety check.
c4a63b12 12247 (decode_coding_object, encode_coding_object, detect_coding_system):
ee05f961
PE
12248 (decode_coding_emacs_mule): Mark variables that gcc
12249 -Wuninitialized does not deduce are never used uninitialized.
160b01f6
PE
12250 (detect_coding_iso_2022): Initialize a local variable that might
12251 be used uninitialized. Leave a FIXME because it's not clear that
53df7c11 12252 this initialization is needed. (Bug#8211)
5f58e762
PE
12253 (ISO_CODE_LF, ISO_CODE_CR, CODING_ISO_FLAG_EUC_TW_SHIFT):
12254 (ONE_MORE_BYTE_NO_CHECK, UTF_BOM, UTF_16_INVALID_P):
12255 (SHIFT_OUT_OK, ENCODE_CONTROL_SEQUENCE_INTRODUCER):
12256 (ENCODE_DIRECTION_R2L, ENCODE_DIRECTION_L2R):
12257 Remove unused macros.
f38b440c 12258
232b38b9 12259 * category.c (hash_get_category_set): Remove unused local var.
9f3b5e69 12260 (copy_category_table): Now static, since it's not used elsewhere.
d0891610 12261 * character.c (string_count_byte8): Likewise.
232b38b9 12262
fb90da1b
PE
12263 * ccl.c (CCL_WRITE_STRING, CCL_ENCODE_CHAR, Fccl_execute_on_string):
12264 (Fregister_code_conversion_map): Rename locals to avoid shadowing.
12265
fb93dbc2
PE
12266 * chartab.c (copy_sub_char_table): Now static, since it's not used
12267 elsewhere.
5c156ace
PE
12268 (sub_char_table_ref_and_range, char_table_ref_and_range):
12269 Rename locals to avoid shadowing.
bbcd0949 12270 (ASET_RANGE, GET_SUB_CHAR_TABLE): Remove unused macros.
fb93dbc2 12271
7d3b3862 12272 * bidi.c (bidi_check_type): Now static, since it's not used elsewhere.
630d6892 12273 (BIDI_BOB): Remove unused macro.
7d3b3862 12274
6be7d3da
PE
12275 * cm.c (cmgoto): Mark variables that gcc -Wuninitialized does not
12276 deduce are never used uninitialized.
c2ed9c8b 12277 * term.c (encode_terminal_code): Likewise.
6be7d3da 12278
75f8807f 12279 * term.c (encode_terminal_code): Now static. Remove unused local.
72abad34 12280
50938595
PE
12281 * tparam.h: New file.
12282 * term.c, tparam.h: Include it.
12283 * deps.mk (term.o, tparam.o): Depend on tparam.h.
12284 * term.c (tputs, tgetent, tgetflag, tgetnum, tparam, tgetstr):
12285 Move these decls to tparam.h, and make them agree with what
12286 is actually in tparam.c. The previous trick of using incompatible
12287 decls in different modules does not conform to the C standard.
12288 All callers of tparam changed to use tparam's actual API.
12289 * tparam.c (tparam1, tparam, tgoto):
12290 Use const pointers where appropriate.
12291
fbceeba2
PE
12292 * cm.c (calccost, cmgoto): Use const pointers where appropriate.
12293 * cm.h (struct cm): Likewise.
12294 * dispextern.h (do_line_insertion_deletion_costs): Likewise.
12295 * scroll.c (ins_del_costs, do_line_insertion_deletion_costs): Likewise.
12296 * term.c (tty_ins_del_lines, calculate_costs, struct fkey_table):
12297 (term_get_fkeys_1, append_glyphless_glyph, produce_glyphless_glyph):
12298 (turn_on_face, init_tty): Likewise.
12299 * termchar.h (struct tty_display_info): Likewise.
fbceeba2 12300
7f3f1250
PE
12301 * term.c (term_mouse_position): Rename local to avoid shadowing.
12302
e6ca6543
PE
12303 * alloc.c (mark_ttys): Move decl from here ...
12304 * lisp.h (mark_ttys): ... to here, so that it's checked against defn.
12305
c40f8d15
AS
123062011-03-11 Andreas Schwab <schwab@linux-m68k.org>
12307
12308 * .gdbinit (pwinx, xbuffer): Fix access to buffer name.
12309
cfe0661d
JB
123102011-03-09 Juanma Barranquero <lekktu@gmail.com>
12311
12312 * search.c (compile_pattern_1): Remove argument regp, unused since
12313 revid:rms@gnu.org-19941211082627-3x1g1wyqkjmwloig.
12314 (compile_pattern): Don't pass it.
12315
0afb4571
J
123162011-03-08 Jan Djärv <jan.h.d@swipnet.se>
12317
12318 * xterm.h (DEFAULT_GDK_DISPLAY): New define.
12319 (GDK_WINDOW_XID, gtk_widget_get_preferred_size): New defines
12320 for ! HAVE_GTK3.
12321 (GTK_WIDGET_TO_X_WIN): Use GDK_WINDOW_XID.
12322
12323 * xmenu.c (menu_position_func): Call gtk_widget_get_preferred_size.
12324
12325 * gtkutil.c: Include gtkx.h if HAVE_GTK3. If ! HAVE_GTK3, define
12326 gdk_window_get_screen, gdk_window_get_geometry,
12327 gdk_x11_window_lookup_for_display and GDK_KEY_g.
12328 (xg_set_screen): Use DEFAULT_GDK_DISPLAY.
12329 (xg_get_pixbuf_from_pixmap): New function.
12330 (xg_get_pixbuf_from_pix_and_mask): Change parameters from GdkPixmap
12331 to Pixmap, take frame as parameter, remove GdkColormap parameter.
12332 Call xg_get_pixbuf_from_pixmap instead of
12333 gdk_pixbuf_get_from_drawable.
12334 (xg_get_image_for_pixmap): Do not make GdkPixmaps, call
12335 xg_get_pixbuf_from_pix_and_mask with Pixmap parameters instead.
12336 (xg_check_special_colors): Use GtkStyleContext and its functions
12337 for HAVE_GTK3.
12338 (xg_prepare_tooltip, xg_hide_tooltip): Call gdk_window_get_screen.
12339 (xg_prepare_tooltip, create_dialog, menubar_map_cb)
12340 (xg_update_frame_menubar, xg_tool_bar_detach_callback)
44f230aa
SM
12341 (xg_tool_bar_attach_callback, xg_update_tool_bar_sizes):
12342 Call gtk_widget_get_preferred_size.
0afb4571
J
12343 (xg_frame_resized): gdk_window_get_geometry only takes 5
12344 parameters.
44f230aa
SM
12345 (xg_win_to_widget, xg_event_is_for_menubar):
12346 Call gdk_x11_window_lookup_for_display.
0afb4571
J
12347 (xg_set_widget_bg): New function.
12348 (delete_cb): New function.
895009e1 12349 (xg_create_frame_widgets): Connect delete-event to delete_cb.
5c32d3f2 12350 Call xg_set_widget_bg. Only set background pixmap for ! HAVE_GTK3
0afb4571
J
12351 (xg_set_background_color): Call xg_set_widget_bg.
12352 (xg_set_frame_icon): Call xg_get_pixbuf_from_pix_and_mask.
12353 (xg_create_scroll_bar): vadj is a GtkAdjustment for HAVE_GTK3.
12354 Only call gtk_range_set_update_policy if ! HAVE_GTK3.
12355 (xg_make_tool_item): Only connect xg_tool_bar_item_expose_callback
12356 if ! HAVE_GTK3.
12357 (update_frame_tool_bar): Call gtk_widget_hide.
12358 (xg_initialize): Use GDK_KEY_g.
12359
12360 * xsmfns.c (gdk_set_sm_client_id): Define to gdk_set_sm_client_id
12361 if ! HAVE_GTK3
12362 (x_session_initialize): Call gdk_x11_set_sm_client_id.
12363
12364 * xterm.c (XFillRectangle): Use cairo routines for HAVE_GTK3.
12365 (x_term_init): Disable Xinput(2) with GDK_CORE_DEVICE_EVENTS.
12366 Load ~/emacs.d/gtkrc only for ! HAVE_GTK3.
12367
1c2cc4ef
JB
123682011-03-08 Juanma Barranquero <lekktu@gmail.com>
12369
12370 * w32xfns.c (select_palette): Check success of RealizePalette against
12371 GDI_ERROR, not zero.
12372
33383987 12373See ChangeLog.11 for earlier changes.
aac0c6e3
MR
12374
12375;; Local Variables:
12376;; coding: utf-8
aac0c6e3
MR
12377;; End:
12378
2f097256 12379 Copyright (C) 2011-2012 Free Software Foundation, Inc.
aac0c6e3
MR
12380
12381 This file is part of GNU Emacs.
12382
12383 GNU Emacs is free software: you can redistribute it and/or modify
12384 it under the terms of the GNU General Public License as published by
12385 the Free Software Foundation, either version 3 of the License, or
12386 (at your option) any later version.
12387
12388 GNU Emacs is distributed in the hope that it will be useful,
12389 but WITHOUT ANY WARRANTY; without even the implied warranty of
12390 MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
12391 GNU General Public License for more details.
12392
12393 You should have received a copy of the GNU General Public License
12394 along with GNU Emacs. If not, see <http://www.gnu.org/licenses/>.