Allow use of vc-root-* commands in *vc-log* buffers.
[bpt/emacs.git] / src / ChangeLog
CommitLineData
984e7f30
DA
12012-07-11 Dmitry Antipov <dmantipov@yandex.ru>
2
3 Avoid calls to strlen in font processing functions.
4 * font.c (font_parse_name, font_parse_xlfd, font_parse_fcname)
5 (font_open_by_name): Changed to use length argument. Adjust
6 users accordingly.
7 * font.h (font_open_by_name, font_parse_xlfd): Adjust prototypes.
8 * xfont.c (xfont_decode_coding_xlfd): Changed to return ptrdiff_t.
9 (xfont_list_pattern, xfont_match): Use length returned by
10 xfont_decode_coding_xlfd.
11 * xfns.c (x_default_font_parameter): Omit useless xstrdup.
12
20e94fdd
GM
132012-07-11 Glenn Morris <rgm@gnu.org>
14
9d596af3
GM
15 * s/darwin.h, s/freebsd.h, s/netbsd.h:
16 Move DONT_REOPEN_PTY to configure.
17
20e94fdd
GM
18 * sound.c (DEFAULT_SOUND_DEVICE) [!WINDOWSNT]:
19 * s/netbsd.h (DEFAULT_SOUND_DEVICE): Let configure set it.
20
e99a530f
PE
212012-07-10 Paul Eggert <eggert@cs.ucla.edu>
22
22ffb973
PE
23 Remove "#define unix" that is no longer needed (Bug#11905).
24 * s/aix4-2.h (unix): Remove; no longer needed.
25
e9a9ae03
PE
26 EMACS_TIME simplification (Bug#11875).
27 This replaces macros (which typically do not work in GDB)
28 with functions, typedefs and enums, making the code easier to debug.
29 The functional style also makes code easier to read and maintain.
30 * systime.h: Include <sys/time.h> on all hosts, not just if
31 WINDOWSNT, since 'struct timeval' is needed in general.
32 (EMACS_TIME): Now a typedef, not a macro.
33 (EMACS_TIME_RESOLUTION, LOG10_EMACS_TIME_RESOLUTION): Now constants,
34 not macros.
35 (EMACS_SECS, EMACS_NSECS, EMACS_TIME_SIGN, EMACS_TIME_VALID_P)
36 (EMACS_TIME_FROM_DOUBLE, EMACS_TIME_TO_DOUBLE, EMACS_TIME_EQ)
37 (EMACS_TIME_NE, EMACS_TIME_GT, EMACS_TIME_GE, EMACS_TIME_LT)
38 (EMACS_TIME_LE): Now functions, not macros.
39 (EMACS_SET_SECS, EMACS_SET_NSECS, EMACS_SET_SECS_NSECS)
40 (EMACS_SET_USECS, EMACS_SET_SECS_USECS): Remove these macros,
41 which are not functions. All uses rewritten to use:
42 (make_emacs_time): New function.
43 (EMACS_SECS_ADDR, EMACS_SET_INVALID_TIME, EMACS_GET_TIME)
44 (EMACS_ADD_TIME, EMACS_SUB_TIME): Remove these macros, which are
45 not functions. All uses rewritten to use the following, respectively:
46 (emacs_secs_addr, invalid_emacs_time, get_emacs_time)
47 (add_emacs_time, sub_emacs_time): New functions.
48 * atimer.c: Don't include <sys/time.h>, as "systime.h" does this.
49 * fileio.c (Fcopy_file):
50 * xterm.c (XTflash): Get the current time closer to when it's used.
51 * makefile.w32-in ($(BLD)/atimer.$(O)): Update dependencies.
52
ffacb126
PE
53 * bytecode.c (targets): Suppress -Woverride-init warnings.
54
e99a530f
PE
55 Simplify by avoiding confusing use of strncpy etc.
56 * doc.c (Fsnarf_documentation):
57 * fileio.c (Ffile_name_directory, Fsubstitute_in_file_name):
58 * frame.c (Fmake_terminal_frame):
59 * gtkutil.c (get_utf8_string):
60 * lread.c (openp):
61 * nsmenu.m (ns_update_menubar):
62 * regex.c (regerror):
63 Prefer memcpy to strncpy and strncat when either will do.
64 * fileio.c (Fsubstitute_in_file_name):
65 * keyboard.c (MULTI_LETTER_MOD, parse_modifiers_uncached)
66 (menu_separator_name_p):
67 * nsmenu.m (ns_update_menubar):
68 Prefer memcmp to strncmp when either will do.
69 * nsterm.m: Include <ftoastr.h>.
70 (ns_get_color):
71 * s/gnu-linux.h, s/sol2-6.h, s/unixware.h (PTY_TTY_NAME_SPRINTF):
72 Prefer snprintf to strncpy.
73 * nsterm.m (ns_term_init):
74 * widget.c (set_frame_size) [0]: Prefer xstrdup to xmalloc + strncpy.
75 * nsterm.m (ns_term_init):
76 Avoid the need for strncpy, by using build_string or
77 make_unibyte_string directly. Use dtoastr, not snprintf.
78 * process.c (Fmake_network_process): Diagnose service names that
79 are too long, rather than silently truncating them or creating
80 non-null-terminated names.
81 (Fnetwork_interface_info): Likewise, for interface names.
82 * sysdep.c (system_process_attributes) [GNU_LINUX]:
83 Prefer sprintf to strncat.
84 * xdisp.c (debug_method_add) [GLYPH_DEBUG]:
85 Prefer vsnprintf to vsprintf + strncpy.
86
c59592b3
GM
872012-07-10 Glenn Morris <rgm@gnu.org>
88
89 * dispnew.c (PENDING_OUTPUT_COUNT) [!__GNU_LIBRARY__]:
90 Clarify fallback case.
91
7d7bbefd
DA
922012-07-10 Dmitry Antipov <dmantipov@yandex.ru>
93
94 Use XCAR and XCDR instead of Fcar and Fcdr where possible.
95 * callint.c, coding.c, doc.c, editfns.c, eval.c, font.c, fontset.c,
96 * frame.c, gnutls.c, minibuf.c, msdos.c, textprop.c, w32fns.c,
97 * w32menu.c, window.c, xmenu.c: Changed to use XCAR and XCDR
98 where argument type is known to be a Lisp_Cons.
99
3a4c8000
TT
1002012-07-10 Tom Tromey <tromey@redhat.com>
101
102 * bytecode.c (BYTE_CODE_THREADED): New macro.
103 (BYTE_CODES): New macro. Replaces all old byte-code defines.
104 (enum byte_code_op): New type.
105 (CASE, NEXT, FIRST, CASE_DEFAULT, CASE_ABORT): New macros.
106 (exec_byte_code): Use them. Use token threading when applicable.
107
2a0213a6
DA
1082012-07-10 Dmitry Antipov <dmantipov@yandex.ru>
109
110 Optimize pure C strings initialization.
111 * lisp.h (make_pure_string): Fix prototype.
112 (build_pure_c_string): New function, defined as static inline. This
113 provides a better opportunity to optimize away calls to strlen when
114 the function is called with compile-time constant argument.
115 * alloc.c (make_pure_c_string): Fix comment. Change to add nchars
116 argument, adjust users accordingly. Use build_pure_c_string where
117 appropriate.
118 * buffer.c, coding.c, data.c, dbusbind.c, fileio.c, fontset.c, frame.c,
119 * keyboard.c, keymap.c, lread.c, search.c, syntax.c, w32fns.c, xdisp.c,
120 * xfaces.c, xfns.c, xterm.c: Use build_pure_c_string where appropriate.
121
cb1caeaf
DA
1222012-07-10 Dmitry Antipov <dmantipov@yandex.ru>
123
124 Avoid calls to strlen in miscellaneous functions.
125 * buffer.c (init_buffer): Use precalculated len, adjust if needed.
126 * font.c (Ffont_xlfd_name): Likewise. Change to call make_string.
127 * lread.c (openp): Likewise.
128
c293e30c
DA
1292012-07-10 Dmitry Antipov <dmantipov@yandex.ru>
130
131 Avoid calls to strlen in path processing functions.
132 * fileio.c (file_name_as_directory): Add comment. Change to add
133 srclen argument and return the length of result. Adjust users
134 accordingly.
135 (directory_file_name): Fix comment. Change to add srclen argument,
cb1caeaf 136 swap 1st and 2nd arguments to obey the common convention. Adjust
c293e30c
DA
137 users accordingly.
138 * filelock.c (fill_in_lock_file_name): Avoid calls to strlen.
139
9e059e3f
GM
1402012-07-10 Glenn Morris <rgm@gnu.org>
141
d02eb359
GM
142 * s/cygwin.h, s/darwin.h, s/freebsd.h, s/netbsd.h, s/unixware.h:
143 Move PENDING_OUTPUT_COUNT definition to configure.
144
882cf227
GM
145 * s/irix6-5.h (DATA_START, DATA_SEG_BITS):
146 * s/hpux10-20.h (DATA_SEG_BITS, DATA_START):
147 * s/gnu.h (DATA_START): Move definitions to configure.
148
af6e839f
GM
149 * s/irix6-5.h (SETUP_SLAVE_PTY, PTY_NAME_SPRINTF): Drop ifdef guards.
150 We include usg5-4-common.h, which defines them both.
151
40289a12
GM
152 * s/gnu.h: Don't include fcntl.h (every file in Emacs that uses
153 O_RDONLY already includes it).
154
9e059e3f
GM
155 Stop ns builds setting the EMACSLOADPATH environment variable.
156 * nsterm.m (ns_load_path): Rename from ns_init_paths.
157 Now it does not set EMACSLOADPATH, just returns the load-path string.
158 * nsterm.h: Update accordingly.
159 * lread.c [HAVE_NS]: Include nsterm.h.
160 (init_lread) [HAVE_NS]: Use ns_load_path.
161 * emacs.c (main) [HAVE_NS]: No longer call ns_init_paths.
162
7c4e8ec0
GM
1632012-07-09 Glenn Morris <rgm@gnu.org>
164
d4f600ff
GM
165 * s/gnu.h (SIGNALS_VIA_CHARACTERS): No need to define it here,
166 since the included bsd-common.h does so.
167
cbb31951
GM
168 Stop ns builds setting the EMACSPATH environment variable.
169 * nsterm.m (ns_exec_path): New function, split from ns_init_paths.
170 (ns_init_paths): Do not set EMACSPATH.
171 * nsterm.h (ns_exec_path): Add it.
172 * callproc.c (init_callproc_1, init_callproc) [HAVE_NS]:
173 Use ns_exec_path.
174
7c4e8ec0
GM
175 * nsterm.m, nsterm.h (ns_etc_directory): Fix type, empty return.
176
26bccfae
PE
1772012-07-09 Paul Eggert <eggert@cs.ucla.edu>
178
a0bee46f
PE
179 * process.c (wait_reading_process_output): 'waitchannels' was unset
180 when read_kbd || !NILP (wait_for_cell); fix this.
181
5994c183
PE
182 Add GCC-style 'const' attribute to functions that can use it.
183 * character.h (char_resolve_modifier_mask):
184 * keyboard.h (make_ctrl_char):
185 * lisp.h (multibyte_char_to_unibyte, multibyte_char_to_unibyte_safe)
186 (init_character_once, next_almost_prime, init_fns, init_image)
187 (flush_pending_output, init_sound):
188 * mem-limits.h (start_of_data):
189 * menu.h (finish_menu_items):
190 Add ATTRIBUTE_CONST.
191 * emacs.c (DEFINE_DUMMY_FUNCTION):
192 Declare the dummy function with ATTRIBUTE_CONST.
193 * lisp.h (Fbyteorder, Fmax_char, Fidentity):
194 Add decls with ATTRIBUTE_CONST.
195
26bccfae
PE
196 Minor improvements to make_formatted_string.
197 * alloc.c (make_formatted_string): Prefer int to ptrdiff_t
198 where int is good enough, as vsprintf returns an int.
199 * lisp.h (make_formatted_string): Add ATTRIBUTE_FORMAT_PRINTF.
200
a8290ec3
DA
2012012-07-09 Dmitry Antipov <dmantipov@yandex.ru>
202
203 Use make_formatted_string to avoid double length calculation.
204 * lisp.h (make_formatted_string): New prototype.
205 * alloc.c (make_formatted_string): New function.
206 * buffer.c (Fgenerate_new_buffer_name): Use it.
207 * dbus.c (syms_of_dbusbind): Likewise.
208 * editfns.c (Fcurrent_time_zone): Likewise.
209 * filelock.c (get_boot_time): Likewise.
210 * frame.c (make_terminal_frame, set_term_frame_name)
211 (x_report_frame_params): Likewise.
212 * image.c (gs_load): Likewise.
213 * minibuf.c (get_minibuffer): Likewise.
214 * msdos.c (dos_set_window_size): Likewise.
215 * process.c (make_process): Likewise.
216 * xdisp.c (ensure_echo_area_buffers): Likewise.
217 * xsettings.c (apply_xft_settings): Likewise.
218
d01ba2f1
GM
2192012-07-09 Glenn Morris <rgm@gnu.org>
220
221 Stop ns builds polluting the environment with EMACSDATA, EMACSDOC.
222 * nsterm.m (ns_etc_directory): New function, split from ns_init_paths.
223 (ns_init_paths): Do not set EMACSDATA, EMACSDOC.
224 * nsterm.h (ns_etc_directory): Add it.
225 * callproc.c [HAVE_NS]: Include nsterm.h.
226 (init_callproc_1, init_callproc) [HAVE_NS]: Use ns_etc_directory.
227
f1f924b6
DA
2282012-07-09 Dmitry Antipov <dmantipov@yandex.ru>
229
230 Move marker debugging code under MARKER_DEBUG.
231 * marker.c (MARKER_DEBUG): Move marker debugging code under
232 #ifdef MARKER_DEBUG because byte_char_debug_check is too slow
233 for bootstrap with --enable-checking (~3x slowdown reported
234 by Juanma Barranquero <lekktu@gmail.com>).
235 (verify_bytepos): Move under #ifdef MARKER_DEBUG.
236
ab531b66
PE
2372012-07-08 Paul Eggert <eggert@cs.ucla.edu>
238
239 * systime.h (EMACS_SUB_TIME): Clarify behavior with unsigned time_t.
240 See <http://bugs.gnu.org/11825#29>.
241
c4b3bc8a
EZ
2422012-07-08 Eli Zaretskii <eliz@gnu.org>
243
244 * xdisp.c (fill_glyphless_glyph_string): If the face of the glyph
245 has no font, use the frame's font. (Bug#11813)
3434fe8a
EZ
246 (display_line): Add commentary about displaying truncation glyphs
247 on GUI frames.
248 (produce_special_glyphs): Move here from term.c.
249
250 * term.c (produce_special_glyphs): Move to xdisp.c.
251
252 * dispextern.h (produce_special_glyphs): Move prototype to xdisp.c
253 section.
c4b3bc8a 254
b676b881
AS
2552012-07-07 Andreas Schwab <schwab@linux-m68k.org>
256
f17c5273
AS
257 * xdisp.c (display_line): Avoid warning about implicit declaration
258 of FRAME_FONT.
259
298819b9
AS
260 * frame.c (get_frame_param): Define only if HAVE_WINDOW_SYSTEM.
261
b676b881
AS
262 * lisp.h: Remove empty conditional.
263
6045c4fd
PE
2642012-07-07 Paul Eggert <eggert@cs.ucla.edu>
265
b3350bf9
PE
266 * lread.c (load_path_check): Now static.
267
6045c4fd
PE
268 Fix some minor --with-ns problems found by static checking.
269 * frame.c (Ftool_bar_pixel_width) [!FRAME_TOOLBAR_WIDTH]:
270 (x_set_font) [!HAVE_X_WINDOWS]:
271 * image.c (xpm_load_image) [HAVE_NS]:
272 (x_to_xcolors) [!HAVE_X_WINDOWS && !HAVE_NTGUI]:
273 (x_disable_image) [!HAVE_NS && !HAVE_NTGUI]:
274 Remove unused local.
275 (Fx_parse_geometry) [HAVE_NS]: Don't return garbage.
276 (xpm_load_image) [HAVE_NS && !HAVE_XPM]: Remove unused label.
277 * image.c (x_create_bitmap_from_file) [HAVE_NS]:
278 (xpm_load_image, xpm_load) [HAVE_NS && !HAVE_XPM]:
279 * nsselect.m (symbol_to_nsstring, ns_string_to_pasteboard_internal):
280 * xfaces.c (Fx_load_color_file) [!HAVE_X_WINDOWS]:
281 Fix pointer signedness problem.
282 * xfaces.c (FRAME_X_FONT_TABLE):
283 * xterm.h (FRAME_X_FONT_TABLE): Remove unused, incompatible macros.
284
929e7845
GM
2852012-07-07 Glenn Morris <rgm@gnu.org>
286
287 * lread.c (load_path_check): New function, split from init_lread.
288 (init_lread): Reorganize. Motivation:
289 If EMACSLOADPATH is set, check/warn about that rather than the
290 defaults, which we are not going to use. Hence we can remove
291 the turn_off_warning and WINDOWSNT || HAVE_NS tests.
292 Don't warn if site-lisp directories are missing.
293 If not installed, start from a blank load-path, since
294 PATH_LOADSEARCH refers to the eventual installation directories.
295
58dd0aa4
EZ
2962012-07-07 Eli Zaretskii <eliz@gnu.org>
297
298 Support truncation and continuation glyphs on GUI frames, when
299 fringes are disabled. (Bug#11832)
300 * xdisp.c (init_iterator): Get dimensions of truncation and
301 continuation glyphs even if on GUI frames. Adjust
302 it->last_visible_x on GUI frames when the left or right fringes,
303 or both, are absent.
304 (start_display, move_it_in_display_line_to): Handle the case of a
305 GUI frame without a fringe to display continuation or truncation
306 glyphs.
307 (insert_left_trunc_glyphs): Support GUI frames: make sure
308 truncation glyphs overwrite enough glyphs from the current line to
309 have sufficient space in pixels.
310 (display_line): Support truncation and continuation glyphs on GUI
311 frames. If some spare pixels are left on the line after inserting
312 the truncation glyphs, fill that space with a stretch glyph of a
313 suitably computed width.
314
315 * term.c (produce_special_glyphs): Call PRODUCE_GLYPHS, not
316 produce_glyphs, to support GUI sessions.
317
31571fd7
PE
3182012-07-07 Paul Eggert <eggert@cs.ucla.edu>
319
5a16b9bc
PE
320 * sysdep.c (ULLONG_MAX): Define if not already defined (Bug#11781).
321
f3047c75
PE
322 * sysdep.c (list_system_processes): Port to NetBSD-current (Bug#11797).
323
31571fd7
PE
324 Do not require float-time's arg to fit in time_t (Bug#11825).
325 This works better on hosts where time_t is unsigned, and where
326 float-time is applied to the (negative) difference between two times.
327 * editfns.c (decode_time_components): Last arg is now double *,
328 not int *, and means to store all the result as a double, without
329 worrying about whether the seconds part fits in time_t.
330 All callers changed.
331 (lisp_time_argument): Remove last int * arg, as it's no longer needed.
332 All callers changed.
333 (Ffloat_time): Do not fail merely because the specified time falls
334 outside of time_t range.
335
4516fbef
GM
3362012-07-07 Glenn Morris <rgm@gnu.org>
337
338 * s/darwin.h (HAVE_RES_INIT, HAVE_LIBRESOLV):
339 * s/hpux10-20.h (HAVE_RINT, HAVE_RANDOM):
340 * s/unixware.h (HAVE_GETWD): Move undefs to configure (effectively).
341
07adc2c6
JB
3422012-07-07 Juanma Barranquero <lekktu@gmail.com>
343
344 * makefile.w32-in (DISPEXTERN_H, $(BLD)/regex.$(O)):
345 Update dependencies.
346
347 * s/ms-w32.h [_MSC_VER]: Remove strcasecmp, strncasecmp.
348
fd573f31
PE
3492012-07-06 Paul Eggert <eggert@cs.ucla.edu>
350
fee5959d
PE
351 Use c_strcasecmp for ASCII case-insensitive comparison (Bug#11786).
352 * dispextern.h, nsfns.m, nsterm.m: Include <c-strcase.h>.
353 * dispextern.h (xstrcasecmp): Rewrite using c_strcasecmp.
354 * nsfns.m (x_get_string_resource): Use c_strncasecmp, not strncasecmp.
355 * nsterm.m (ns_default): Use c_strcasecmp, not strcasecmp.
356 * xfaces.c (xstrcasecmp) [!HAVE_STRCASECMP]: Remove.
357
fd573f31
PE
358 * xfont.c (compare_font_names): Redo to omit the need for casts.
359
ddadbc0e
AS
3602012-07-06 Andreas Schwab <schwab@linux-m68k.org>
361
fca8d6b6
AS
362 * xfns.c (Fx_change_window_property): Doc fix.
363 * w32fns.c (Fx_change_window_property): Doc fix.
364
ddadbc0e
AS
365 * w32fns.c (Fx_window_property): Accept the same arguments as the
366 X Windows version. Doc fix.
367 * xfns.c (Fx_window_property): Doc fix. (Bug#11870)
368
f247498e
JB
3692012-07-06 Juanma Barranquero <lekktu@gmail.com>
370 Eli Zaretskii <eliz@gnu.org>
371
372 * s/ms-w32.h: Settings not specific to Windows moved to nt/config.nt.
373 Windows-specific code from nt/config.nt moved here.
374 Obsolete settings removed.
375
216ee680
PE
3762012-07-06 Paul Eggert <eggert@cs.ucla.edu>
377
378 * process.c: Avoid unnecessary calls to gettime.
379 (wait_reading_process_output): Don't get the time of day
380 when gobbling data immediately and not waiting, as there's no need
381 for it in that case. This removes a FIXME.
382
bdd091e4
JD
3832012-07-06 Jan Djärv <jan.h.d@swipnet.se>
384
385 * gtkutil.c (xg_event_is_for_scrollbar): Assign gwin when HAVE_GTK3
386 is defined (Bug#11768).
387
9d44f8ce
DA
3882012-07-06 Dmitry Antipov <dmantipov@yandex.ru>
389
390 Fix marker debugging code.
391 * marker.c (byte_char_debug_check): Do not perform the check
392 if buffer is not multibyte.
090bd7cb
JB
393 (buf_charpos_to_bytepos, buf_bytepos_to_charpos):
394 Call byte_char_debug_check with correct arguments.
9d44f8ce 395
90fc4786
DA
3962012-07-06 Dmitry Antipov <dmantipov@yandex.ru>
397
398 Compile marker debugging code only if ENABLE_CHECKING is defined.
090bd7cb
JB
399 * marker.c (byte_char_debug_check, count_markers):
400 Use only if ENABLE_CHECKING is defined.
90fc4786
DA
401 (byte_debug_flag): Remove.
402 (CONSIDER, buf_charpos_to_bytepos, buf_bytepos_to_charpos):
403 Always call byte_char_debug_check if ENABLE_CHECKING is defined.
404
7b7ae965
DA
4052012-07-06 Dmitry Antipov <dmantipov@yandex.ru>
406
4e57b342
DA
407 Avoid code repetition in marker-related functions.
408 * marker.c (attach_marker): New function.
409 (Fset_marker, set_marker_restricted, set_marker_both)
410 (set_marker_restricted_both): Use it.
411 (Fset_marker, set_marker_restricted, Fbuffer_has_markers_at):
412 Consistently rename charno to charpos.
413 (marker_position): Add eassert.
414 (marker_byte_position): Convert to eassert.
415
4162012-07-06 Dmitry Antipov <dmantipov@yandex.ru>
417
418 Simplify list operations in unchain_overlay and unchain_marker.
7b7ae965 419 * buffer.c (unchain_overlay): Simplify. Add comment.
4e57b342 420 * marker.c (unchain_marker): Simplify. Fix comments.
7b7ae965 421
657924ff
DA
4222012-07-06 Dmitry Antipov <dmantipov@yandex.ru>
423
424 Introduce fast path for the widely used marker operation.
425 * alloc.c (build_marker): New function.
426 * lisp.h (build_marker): New prototype.
427 * buffer.c (clone_per_buffer_values, Fmake_indirect_buffer): Use it.
428 * composite.c (autocmp_chars): Likewise.
429 * editfns.c (buildmark): Remove.
430 (Fpoint_marker, Fpoint_min_marker, Fpoint_max_marker)
431 (save_restriction_save): Use build_marker.
432 * marker.c (buf_charpos_to_bytepos, buf_bytepos_to_charpos): Likewise.
433 * window.c (save_window_save): Likewise.
434
041a49a6
DA
4352012-07-06 Dmitry Antipov <dmantipov@yandex.ru>
436
437 Do not use Fdelete_overlay in delete_all_overlays
438 to avoid redundant calls to unchain_overlay.
439 * buffer.c (drop_overlay): New function.
440 (delete_all_overlays, Fdelete_overlay): Use it.
441 * minibuf.c (get_minibuffer): Fix comment.
442
7dca65a4
PE
4432012-07-06 Paul Eggert <eggert@cs.ucla.edu>
444
445 Port to OpenBSD 5.1 amd64.
446 * sysdep.c [BSD_SYSTEM]: Include <sys/param.h> before <sys/sysctl.h>.
447 This is needed for OpenBSD, and should be harmless on all BSD systems.
448 Also, include <sys/sysctl.h>, as it should be available on all
449 BSD_SYSTEM hosts given that we're already calling sysctl in that case.
450 (list_system_processes) [__OpenBSD__]: Use DARWIN_OS style mib, but
451 use p_pid member, not kp_proc.pid.
452
8eb876e2
GM
4532012-07-06 Glenn Morris <rgm@gnu.org>
454
455 * Makefile.in (emacs$(EXEEXT)): Don't check for load-path shadows.
456
38182d90
PE
4572012-07-05 Paul Eggert <eggert@cs.ucla.edu>
458
459 More xmalloc and related cleanup.
460 * alloc.c, bidi.c, buffer.c, buffer.h, bytecode.c, callint.c:
461 * callproc.c, charset.c, coding.c, composite.c, data.c, dispnew.c:
462 * doc.c, editfns.c, emacs.c, eval.c, fileio.c, filelock.c, fns.c:
463 * font.c, fontset.c, frame.c, fringe.c, ftfont.c, ftxfont.c, gmalloc.c:
464 * gtkutil.c, image.c, keyboard.c, keymap.c, lread.c, macros.c, menu.c:
465 * nsfns.m, nsfont.m, nsmenu.m, nsterm.m, print.c, process.c, ralloc.c:
466 * regex.c, region-cache.c, scroll.c, search.c, sound.c, syntax.c:
467 * sysdep.c, term.c, termcap.c, unexmacosx.c, window.c, xdisp.c:
468 * xfaces.c, xfns.c, xftfont.c, xgselect.c, xmenu.c, xrdb.c, xselect.c:
469 * xterm.c:
470 Omit needless casts involving void * pointers and allocation.
471 Prefer "P = xmalloc (sizeof *P)" to "P = xmalloc (sizeof (TYPE_OF_P))",
472 as the former is more robust if P's type is changed.
473 Prefer xzalloc to xmalloc + memset 0.
474 Simplify malloc-or-realloc to realloc.
475 Don't worry about xmalloc returning a null pointer.
476 Prefer xstrdup to xmalloc + strcpy.
477 * editfns.c (Fmessage_box): Grow message_text by at least 80 when
478 growing it.
479 * keyboard.c (apply_modifiers_uncached): Prefer local array to
480 alloca of a constant.
481
6dd5a677
EZ
4822012-07-05 Eli Zaretskii <eliz@gnu.org>
483
484 * xdisp.c (display_line): Fix horizontal pixel coordinates when
485 hscroll is larger than the line width. Fixes long and futile
486 looping inside extend_face_to_end_of_line (on a TTY) producing
487 glyphs that are not needed and thrown away.
488
6b312f0f
DA
4892012-07-05 Dmitry Antipov <dmantipov@yandex.ru>
490
491 * marker.c (set_marker_restricted_both): Simplify by using
492 clip_to_bounds.
493
f520ef9b
PE
4942012-07-05 Paul Eggert <eggert@cs.ucla.edu>
495
496 * editfns.c (region_limit): Simplify by using clip_to_bounds.
497
383b7c95
JD
4982012-07-05 Jan Djärv <jan.h.d@swipnet.se>
499
500 * gtkutil.c (gtk_scrollbar_new, gtk_box_new): Define when HAVE_GTK3 is
501 not defined (Bug#11768).
502 (xg_create_frame_widgets): Use gtk_plug_new_for_display (Bug#11768).
503 (xg_create_frame_widgets, create_dialog, xg_get_file_with_chooser)
504 (make_widget_for_menu_item, xg_make_tool_item): Use gtk_box_new
505 followed by gtk_box_set_homogeneous (Bug#11768).
506 (xg_update_menu_item): Use GTK_IS_BOX (Bug#11768).
090bd7cb
JB
507 (update_theme_scrollbar_width, xg_create_scroll_bar):
508 Use gtk_scrollbar_new (Bug#11768).
383b7c95
JD
509 (xg_event_is_for_scrollbar): Use Gdk Device functions for HAVE_GTK3.
510 (is_box_type): New function (Bug#11768).
511 (xg_tool_item_stale_p): Call is_box_type.
5293d758 512 (xg_initialize): Get settings by calling gtk_settings_get_for_screen
383b7c95
JD
513 with default display (Bug#11768).
514
d6e7bf45
EZ
5152012-07-05 Eli Zaretskii <eliz@gnu.org>
516
517 * xdisp.c (window_hscroll_limited): New function.
518 (pos_visible_p, init_iterator): Use it to avoid overflow of pixel
519 coordinates when window's hscroll is set to insanely large
520 values. (Bug#11857)
521
431391ec
JB
5222012-07-05 Juanma Barranquero <lekktu@gmail.com>
523
524 * makefile.w32-in ($(BLD)/dired.$(O), $(BLD)/fileio.$(O)): Fix typo.
525 ($(BLD)/terminal.$(O), $(BLD)/syntax.$(O)): Update dependencies.
526
23f86fce
DA
5272012-07-05 Dmitry Antipov <dmantipov@yandex.ru>
528
529 Cleanup xmalloc.
530 * lisp.h (xzalloc): New prototype. Omit needless casts.
531 * alloc.c (xzalloc): New function. Omit needless casts.
532 * charset.c: Omit needless casts. Convert all calls to
533 xmalloc with following memset to xzalloc.
534 * dispnew.c: Likewise.
535 * fringe.c: Likewise.
536 * image.c: Likewise.
537 * sound.c: Likewise.
538 * term.c: Likewise.
539 * w32fns.c: Likewise.
540 * w32font.c: Likewise.
541 * w32term.c: Likewise.
542 * xfaces.c: Likewise.
543 * xfns.c: Likewise.
544 * xterm.c: Likewise.
545 * atimer.c: Omit needless casts.
546 * buffer.c: Likewise.
547 * callproc.c: Likewise.
548 * ccl.c: Likewise.
549 * coding.c: Likewise.
550 * composite.c: Likewise.
551 * doc.c: Likewise.
552 * doprnt.c: Likewise.
553 * editfns.c: Likewise.
554 * emacs.c: Likewise.
555 * eval.c: Likewise.
556 * filelock.c: Likewise.
557 * fns.c: Likewise.
558 * gtkutil.c: Likewise.
559 * keyboard.c: Likewise.
560 * lisp.h: Likewise.
561 * lread.c: Likewise.
562 * minibuf.c: Likewise.
563 * msdos.c: Likewise.
564 * print.c: Likewise.
565 * process.c: Likewise.
566 * region-cache.c: Likewise.
567 * search.c: Likewise.
568 * sysdep.c: Likewise.
569 * termcap.c: Likewise.
570 * terminal.c: Likewise.
571 * tparam.c: Likewise.
572 * w16select.c: Likewise.
573 * w32.c: Likewise.
574 * w32reg.c: Likewise.
575 * w32select.c: Likewise.
576 * w32uniscribe.c: Likewise.
577 * widget.c: Likewise.
578 * xdisp.c: Likewise.
579 * xmenu.c: Likewise.
580 * xrdb.c: Likewise.
581 * xselect.c: Likewise.
582
0497dc44
PE
5832012-07-05 Paul Eggert <eggert@cs.ucla.edu>
584
585 * fileio.c (time_error_value): Check the right error number.
586 Problem reported by Troels Nielsen in
587 <http://lists.gnu.org/archive/html/emacs-devel/2012-07/msg00095.html>.
588
356e7178
PE
5892012-07-04 Paul Eggert <eggert@cs.ucla.edu>
590
4e71fd89
PE
591 * window.c (set_window_hscroll): Revert the 100000 hscroll limit.
592 This should be fixed in a better way; see Eli Zaretskii in
593 <http://lists.gnu.org/archive/html/emacs-devel/2012-07/msg00088.html>.
594 (HSCROLL_MAX): Remove; this is now internal to set_window_hscroll.
595
f0941253
PE
596 * fileio.c (time_error_value): Rename from special_mtime.
597 The old name's problems were noted by Eli Zaretskii in
598 <http://lists.gnu.org/archive/html/emacs-devel/2012-07/msg00087.html>.
599
065c9eb4
PE
600 * emacs.c (gdb_pvec_type): Change it back to enum pvec_type.
601 This variable's comment says Emacs needs at least one GDB-visible
602 symbol of type enum pvec_type, to work around GDB problems.
603 The symbol's value doesn't matter.
604
356e7178
PE
605 * alloc.c (PSEUDOVECTOR_NBYTES): Remove stray ';'
606 that causes compilation to fail on pre-C99 compilers.
607
95f61aa2
JB
6082012-07-04 Juanma Barranquero <lekktu@gmail.com>
609
610 * s/ms-w32.h (LISP_FLOAT_TYPE, HAVE_MEMCMP, HAVE_MEMCPY)
611 (HAVE_MEMMOVE, HAVE_MEMSET): Don't set, obsolete.
612
3884d954
DA
6132012-07-04 Dmitry Antipov <dmantipov@yandex.ru>
614
d209e2fb 615 * buffer.c (init_buffer_once): Fix initialization of
3884d954
DA
616 headers for buffer_defaults and buffer_local_symbols.
617 Reported by Juanma Barranquero <lekktu@gmail.com>.
618
ee28be33
SM
6192012-07-04 Stefan Monnier <monnier@iro.umontreal.ca>
620
621 Turn VECTOR_FREE_LIST_FLAG into PVEC_FREE.
622 * lisp.h (enum pvec_type): Use fewer bits.
623 (PSEUDOVECTOR_SIZE_BITS): New constant.
624 (PSEUDOVECTOR_SIZE_MASK, PVEC_TYPE_MASK): Use it.
625 (XSETPVECTYPESIZE, XSETTYPED_PSEUDOVECTOR, DEFUN): Adapt code to
626 change in pvec_type.
627 (PSEUDOVECTOR_TYPEP): New macro.
628 (TYPED_PSEUDOVECTORP): Use it.
629 * fns.c (internal_equal): Adapt code to extract pvectype.
630 * emacs.c (gdb_pvec_type): Update type.
631 * alloc.c (PSEUDOVECTOR_NBYTES): New macro.
632 (VECTOR_FREE_LIST_SIZE_MASK): Remove (=> PSEUDOVECTOR_SIZE_MASK).
633 (VECTOR_FREE_LIST_FLAG): Remove (=> PVEC_FREE).
634 (SETUP_ON_FREE_LIST): Use XSETPVECTYPESIZE.
635 (sweep_vectors): Use it. Use local var `total_bytes' instead of
636 abusing vector->header.next.nbytes.
637 (live_vector_p): Use PVEC_TYPE.
638 (mark_object): Adapt code to extract pvectype. Use switch.
639
c7f2cd7f
PE
6402012-07-04 Paul Eggert <eggert@cs.ucla.edu>
641
642 * doprnt.c (doprnt): Don't assume string length fits in 'int'.
643 Tighten new eassert a bit.
644
8ce70ed2
DA
6452012-07-04 Dmitry Antipov <dmantipov@yandex.ru>
646
647 Fix compilation with --enable-gcc-warnings and -O1
648 optimization level.
649 * doprnt.c (doprnt): Change type of tem to int, initialize
650 to avoid compiler warning. Add eassert.
651 * search.c (simple_search): Initialize match_byte to avoid
652 compiler warning. Add eassert.
653
dea7f1e5
PE
6542012-07-04 Paul Eggert <eggert@cs.ucla.edu>
655
24a212eb
PE
656 Avoid weird behavior with large horizontal scrolls.
657 Without this change, for example, large hscroll values would
658 mess up Emacs's display on Fedora 15 x86, presumably due to
659 overflows in int calculations in the display code.
660 Also, if buffers had long lines, Emacs would freeze.
661 * window.c (HSCROLL_MAX): Reduce to 100000, and make it visible to GDB.
662 (set_window_hscroll): New function, containing the old guts of
663 Fset_window_hscroll. Return the clipped value.
664 (Fset_window_hscroll, Fscroll_left, Fscroll_right): Use it.
665 This avoids the need to check against PTRDIFF_MAX.
666
dea7f1e5
PE
667 * buffer.c (Fgenerate_new_buffer_name): Fix sprintf format mismatch.
668
76046526
DA
6692012-07-04 Dmitry Antipov <dmantipov@yandex.ru>
670
671 * buffer.c (Fgenerate_new_buffer_name): Fix type mismatch.
672
39adff0d
PE
6732012-07-04 Paul Eggert <eggert@cs.ucla.edu>
674
63807d47
PE
675 * regex.c: Suppress GCC warning on RHEL 6. (Bug#11207)
676 Conditionalize the pragmas on GCC 4.5 or later, not GCC 4.3 or later,
677 since GCC 4.4.6 issues a bogus warning for them.
678
39adff0d
PE
679 Fix bugs in file timestamp newness comparisons.
680 * fileio.c (Ffile_newer_than_file_p):
681 * lread.c (Fload): Use full timestamp resolution of files,
682 not just the 1-second resolution, so that files that are only
683 slightly newer still count as newer.
684 * fileio.c (Ffile_newer_than_file_p): Don't assume file
685 timestamps fit in 'int'; this fixes a Y2038 bug on most hosts.
686
dbeed9a6
PE
6872012-07-03 Paul Eggert <eggert@cs.ucla.edu>
688
689 * fileio.c: Improve handling of file time marker. (Bug#11852)
690 (special_mtime): New function.
691 (Finsert_file_contents, Fverify_visited_file_modtime):
692 Use it to set special mtime values consistently.
693
636334d6
AS
6942012-07-03 Andreas Schwab <schwab@linux-m68k.org>
695
696 * fileio.c (Finsert_file_contents): Properly handle st_mtime
697 marker for non-existing file. (Bug#11852)
698
e2017fe2
GM
6992012-07-03 Glenn Morris <rgm@gnu.org>
700
701 * lisp.h (Fread_file_name): Restore EXFUN (it's not a normal DEFUN
702 and did not make it into globals.h).
703
404dbd37
TT
7042012-07-03 Tom Tromey <tromey@redhat.com>
705
706 * window.c (Fset_window_margins, Fset_window_fringes)
707 (Fset_window_scroll_bars, Fset_window_vscroll): No longer static.
708 * textprop.c (Fprevious_property_change): No longer static.
709 * syntax.c (Fsyntax_table_p): No longer static.
710 * process.c (Fget_process, Fprocess_datagram_address): No longer
711 static.
712 * keymap.c (Flookup_key, Fcopy_keymap): No longer static.
713 * keyboard.c (Fcommand_execute): No longer static.
714 Remove EXFUN.
715 * insdel.c (Fcombine_after_change_execute): No longer static.
716 * image.c (Finit_image_library): No longer static.
717 * fileio.c (Fmake_symbolic_link): No longer static.
718 * eval.c (Ffetch_bytecode): No longer static.
719 * editfns.c (Fuser_full_name): No longer static.
d209e2fb
JB
720 * doc.c (Fdocumentation_property, Fsnarf_documentation):
721 No longer static.
404dbd37
TT
722 * buffer.c (Fset_buffer_major_mode, Fdelete_overlay): No longer
723 static.
724 * dired.c (Ffile_attributes): No longer static.
725 * composite.c (Fcomposition_get_gstring): No longer static.
726 * callproc.c (Fgetenv_internal): No longer static.
727
728 * ccl.h: Remove EXFUNs.
729 * buffer.h: Remove EXFUNs.
730 * dispextern.h: Remove EXFUNs.
731 * intervals.h: Remove EXFUNs.
732 * fontset.h: Remove EXFUN.
733 * font.h: Remove EXFUNs.
734 * dosfns.c (system_process_attributes): Remove EXFUN.
735 * keymap.h: Remove EXFUNs.
736 * lisp.h: Remove EXFUNs.
737 * w32term.h: Remove EXFUNs.
738 * window.h: Remove EXFUNs.
739 * xsettings.h: Remove EXFUN.
740 * xterm.h: Remove EXFUN.
741
8e4fd1e1
GM
7422012-07-03 Glenn Morris <rgm@gnu.org>
743
744 * lisp.h (Frandom): Make it visible to C.
745 * buffer.c (Fgenerate_new_buffer_name): Speed up finding a new
746 buffer for invisible buffers. (Bug#1229)
747
ca95b3eb
DA
7482012-07-03 Dmitry Antipov <dmantipov@yandex.ru>
749
750 Fix block vector allocation code to allow VECTOR_BLOCK_SIZE
751 values which aren't power of 2.
752 * alloc.c (VECTOR_FREE_LIST_SIZE_MASK): New macro. Verify
753 it's value and the value of VECTOR_BLOCK_SIZE. Adjust users
754 accordingly.
755
7555c33f
SM
7562012-07-03 Stefan Monnier <monnier@iro.umontreal.ca>
757
758 * lisp.h (Lisp_Misc, Lisp_Fwd): Move around to group better.
759
760 * alloc.c (mark_object): Revert part of last patch to use `switch'.
761
d12e8f5a
DA
7622012-07-03 Dmitry Antipov <dmantipov@yandex.ru>
763
764 * alloc.c (allocate_vector_block): Remove redundant
765 calls to mallopt if DOUG_LEA_MALLOC is defined.
766 (allocate_vectorlike): If DOUG_LEA_MALLOC is defined,
767 avoid calls to mallopt if zero_vector is returned.
768
296094c3
DA
7692012-07-03 Dmitry Antipov <dmantipov@yandex.ru>
770
771 * alloc.c (check_string_bytes): If GC_CHECK_STRING_BYTES
772 is enabled, avoid dereferencing NULL current_sblock if
773 running undumped.
774
36429c89
DA
7752012-07-03 Dmitry Antipov <dmantipov@yandex.ru>
776
777 Cleanup basic buffer management.
778 * buffer.h (struct buffer): Change layout to use generic vector
779 marking code. Fix some comments. Change type of 'clip_changed'
780 to bitfield. Remove unused #ifndef old.
781 (FIRST_FIELD_PER_BUFFER, LAST_FIELD_PER_BUFFER): Remove.
782 (GET_OVERLAYS_AT): Fix indentation.
783 (for_each_per_buffer_object_at): New macro.
784 * buffer.c (clone_per_buffer_values, reset_buffer_local_variables)
785 (Fbuffer_local_variables): Use it.
786 (init_buffer_once, syms_of_buffer): Remove unused #ifndef old.
787 * alloc.c (allocate_buffer): Adjust to match new layout of
788 struct buffer. Fix comment.
789 (mark_overlay): New function.
790 (mark_buffer): Use it. Use mark_vectorlike to mark normal
791 Lisp area of struct buffer.
792 (mark_object): Use it. Adjust marking of misc objects
793 and related comments.
794
3b3e4cac
PE
7952012-07-02 Paul Eggert <eggert@cs.ucla.edu>
796
797 * alloc.c (mark_object): Remove "#ifdef GC_CHECK_MARKED_OBJECTS"
798 wrapper that is not needed because the wrapped code is a no-op (zero
799 machine instructions) when GC_CHECK_MARKED_OBJECTS is not defined.
800 This avoids a -Wunused-macros diagnostic with GCC 4.7.1 x86-64.
801
cf5c0175
DA
8022012-07-02 Dmitry Antipov <dmantipov@yandex.ru>
803
804 * alloc.c (mark_buffer): Simplify. Remove prototype.
805 (mark_object): Add comment. Reorganize marking of vector-like
faf611c7 806 objects. Use CHECK_LIVE for all vector-like objects except buffers
cf5c0175
DA
807 and subroutines when GC_CHECK_MARKED_OBJECTS is defined. Avoid
808 redundant calls to mark_vectorlike for bool vectors.
809
ca26824c
GM
8102012-06-30 Glenn Morris <rgm@gnu.org>
811
2e4c5312
GM
812 * nsterm.m (ns_init_paths): Ignore site-lisp if --no-site-lisp.
813
ca26824c
GM
814 * epaths.in (PATH_SITELOADSEARCH): New.
815 * lread.c (init_lread): Use PATH_SITELOADSEARCH.
816 This is rather than relying on --enable-locallisppath elements
817 having "site-lisp" in their names. (Bug#10208#25, 11658)
818
0d23c240
EZ
8192012-06-30 Eli Zaretskii <eliz@gnu.org>
820
c9240d7a
EZ
821 * w32proc.c (sys_select): Accept and ignore one more argument.
822
823 * w32.c (emacs_gnutls_pull): Call select with one more argument.
824
0d23c240 825 * sysselect.h [DOS_NT]: Don't include sys/select.h.
9ff8f76b 826 (pselect) [!MS_DOS]: Redirect to sys_select.
0d23c240
EZ
827
828 * sysdep.c: Don't include dos.h and dosfns.h.
829
830 * process.c (sys_select):
831 * msdos.c (sys_select): Accept one more argument and ignore it.
832
833 * msdos.c (event_timestamp, sys_select): Use gnulib's gettime;
834 adapt data types and code to that.
835
836 * dosfns.c:
837 * msdos.c (gettime, settime): Define away the prototypes in dos.h,
838 which clashes with the gnulib function of the same name.
839
af5a5a98
AS
8402012-06-30 Andreas Schwab <schwab@linux-m68k.org>
841
c5e4379c
AS
842 * font.c (font_style_to_value, font_style_symbolic)
843 (font_prop_validate_style): Add type checks for values in
844 font_style_table.
845
af5a5a98
AS
846 * lisp.h (CHECK_RANGED_INTEGER): Make value to check the first
847 argument.
848 * character.c, charset.c, menu.c, process.c, window.c: Adjust all
849 uses.
850
8d38f461
EZ
8512012-06-29 Eli Zaretskii <eliz@gnu.org>
852
2e5a6631
EZ
853 * xdisp.c (try_window_id): Undo last change.
854
8d38f461
EZ
855 * w32.c (getwd): Adjust commentary about startup_dir.
856 (init_environment): Always call sys_access, even in non-MSVC
857 builds. Don't chdir to the directory of the Emacs executable.
858 This undoes code from 1997 which was justified by the need to
859 "avoid conflicts when removing and renaming directories". But its
860 downside was that every relative file name was being interpreted
861 relative to the directory of the Emacs executable, which can never
862 be TRT. In particular, it broke sys_access when called with
863 relative file names.
864 (sys_access): Map GetLastError to errno.
865
2af3565e
DA
8662012-06-29 Dmitry Antipov <dmantipov@yandex.ru>
867
868 * window.h (struct window): Change type of 'fringes_outside_margins'
869 to bitfield. Fix comment. Adjust users accordingly.
cf5c0175 870 (struct window): Change type of 'window_end_bytepos' to ptrdiff_t.
2af3565e
DA
871 Adjust comment.
872 * xdisp.c (try_window_id): Change type of 'first_vpos' and 'vpos'
873 to ptrdiff_t.
874
c8d3a25c 8752012-06-29 Andreas Schwab <schwab@linux-m68k.org>
57570cd3 876
c8d3a25c
GM
877 * gnutls.c (emacs_gnutls_handshake):
878 Add QUIT to make the loop interruptible.
57570cd3 879
c8d3a25c 8802012-06-29 Glenn Morris <rgm@gnu.org>
d01fd55f 881
c8d3a25c
GM
882 * charset.c (init_charset): Make lack of etc/charsets fatal.
883
3e984ee8
DA
8842012-06-29 Dmitry Antipov <dmantipov@yandex.ru>
885
886 * editfns.c (region_limit): Fix type mismatch.
887
ef884f23
DA
8882012-06-29 Dmitry Antipov <dmantipov@yandex.ru>
889
890 * nsfns.m: Fix GLYPH_DEBUG usage assuming that it may be
891 undefined. Convert from xassert to eassert.
892 * nsmenu.m: Convert from xassert to eassert.
893 * nsterm.m: Likewise.
894
7d7e0027
SM
8952012-06-28 Stefan Monnier <monnier@iro.umontreal.ca>
896
897 * editfns.c (region_limit): Clip to narrowing (bug#11770).
898
aa754e6a
PE
8992012-06-28 Paul Eggert <eggert@cs.ucla.edu>
900
901 Avoid integer overflow on scroll-left and scroll-right.
902 * window.c (HSCROLL_MAX): New macro.
903 (Fscroll_left, Fscroll_right): Avoid undefined behavior on integer
904 overflow when requested scroll falls outside ptrdiff_t range.
905
80b00b08
DA
9062012-06-28 Dmitry Antipov <dmantipov@yandex.ru>
907
908 * window.h (struct window): Change type of 'hscroll',
909 'min_hscroll' and 'last_point' from Lisp_Object to ptrdiff_t,
910 'last_modified' and 'last_overlay_modified' to EMACS_INT.
911 Adjust users accordingly.
912 * xdisp.c (try_cursor_movement): Replace type check with eassert.
913 * window.c (Fscroll_left, Fscroll_right): Change type of 'hscroll'
914 from EMACS_INT to ptrdiff_t.
915 (make_window): Omit redundant initialization.
916
62b2bcf6
JB
9172012-06-28 Juanma Barranquero <lekktu@gmail.com>
918
919 * makefile.w32-in ($(BLD)/regex.$(O)): Update dependencies.
920
45942c7d
DA
9212012-06-28 Dmitry Antipov <dmantipov@yandex.ru>
922
923 * window.h (struct window): Change type of 'use_time' and
924 'sequence_number' from Lisp_Object to int.
925 * frame.c (make_frame): Adjust users accordingly.
926 * print.c (print_object): Likewise.
927 * window.c (select_window, Fwindow_use_time, make_parent_window)
928 (make_window): Likewise.
929
e509cfa6
DA
9302012-06-28 Dmitry Antipov <dmantipov@yandex.ru>
931
932 * dispextern.h (GLYPH_DEBUG): Now defined in config.h if
933 enabled with --enable-checking=[all,glyphs] configure option.
934 Fix GLYPH_DEBUG usage assuming that it may be undefined,
935 adjust comments accordingly.
936 * dispnew.c: Fix GLYPH_DEBUG usage assuming that it may be
937 undefined, adjust comments accordingly.
938 * image.c: Likewise.
939 * scroll.c: Likewise.
940 * w32fns.c: Likewise.
941 * w32term.c: Likewise.
942 * xdisp.c: Likewise.
943 * xfaces.c: Likewise.
944 * xfns.c: Likewise.
945 * xterm.c: Likewise.
946
a54e2c05
DA
9472012-06-28 Dmitry Antipov <dmantipov@yandex.ru>
948
949 Generalize run-time debugging checks.
950 * dispextern.h (XASSERTS): Remove.
951 * fontset.c (xassert): Remove.
952 Convert from xassert to eassert.
953 * alloc.c: Convert from xassert to eassert.
954 * bidi.c: Likewise.
955 * dispnew.c: Likewise.
956 * fns.c: Likewise.
957 * fringe.c: Likewise.
958 * ftfont.c: Likewise.
959 * gtkutil.c: Likewise.
960 * image.c: Likewise.
961 * keyboard.c: Likewise.
962 * menu.c: Likewise.
963 * process.c: Likewise.
964 * scroll.c: Likewise.
965 * sound.c: Likewise.
966 * term.c: Likewise.
967 * w32console.c: Likewise.
968 * w32fns.c: Likewise.
969 * w32term.c: Likewise.
970 * window.c: Likewise.
971 * xdisp.c: Likewise.
972 * xfaces.c: Likewise.
973 * xfns.c: Likewise.
974 * xselect.c: Likewise.
975 * xterm.c: Likewise.
976
1ec4b7b2
SM
9772012-06-27 Stefan Monnier <monnier@iro.umontreal.ca>
978
979 * fns.c (maybe_resize_hash_table): Output message when growing the
980 purify-hashtable.
981
2014308a
DA
9822012-06-27 Dmitry Antipov <dmantipov@yandex.ru>
983
984 * alloc.c (allocate_string_data): Remove dead code.
985 * xsettings.c (XSETTINGS_FONT_NAME): Move under HAVE_XFT to
986 avoid GCC warning about unused macro.
987
246155eb
DA
9882012-06-27 Dmitry Antipov <dmantipov@yandex.ru>
989
990 * alloc.c (allocate_string): Omit intervals initialization.
991 * alloc.c (make_uninit_multibyte_string): Initialize intervals
992 as in make_pure_string and make_pure_c_string.
993
43184b7b
DA
9942012-06-27 Dmitry Antipov <dmantipov@yandex.ru>
995
d209e2fb 996 * alloc.c (allocate_string): Fix last change.
43184b7b 997
3fe6dd74
DA
9982012-06-27 Dmitry Antipov <dmantipov@yandex.ru>
999
d209e2fb 1000 * alloc.c (allocate_string): Remove two redundant calls
3fe6dd74
DA
1001 to memset, add explicit initialization where appropriate.
1002
1ba6038a
GM
10032012-06-27 Glenn Morris <rgm@gnu.org>
1004
1005 * lisp.mk (lisp): Remove paths.elc.
1006
c89926a5
CY
10072012-06-27 Chong Yidong <cyd@gnu.org>
1008
1009 * doc.c (Fsubstitute_command_keys): Fix punctuation.
1010
ed6b3510
JW
10112012-06-26 John Wiegley <johnw@newartisans.com>
1012
1ec4b7b2 1013 * unexmacosx.c (copy_data_segment): Add two section names used
157e99e4
JW
1014 on Mac OS X Lion: __mod_init_func and __mod_term_func.
1015
ed6b3510
JW
1016 * alloc.c (mark_memory): Do not check with -faddress-sanitizer
1017 when building with Clang.
1018
8edd4a2b
SM
10192012-06-26 Stefan Monnier <monnier@iro.umontreal.ca>
1020
1021 * eval.c (Fapply): Allow calling it with a single argument.
1022
f6f62d1b
EZ
10232012-06-26 Eli Zaretskii <eliz@gnu.org>
1024
1025 * s/ms-w32.h (strcasecmp, strncasecmp) [_MSC_VER]: Redirect to
1026 _stricmp and _strnicmp.
1027 (HAVE_STRCASECMP, HAVE_STRNCASECMP): Define to 1.
1028
62efea5e
DA
10292012-06-26 Dmitry Antipov <dmantipov@yandex.ru>
1030
1031 * alloc.c (allocate_window): Zero out non-Lisp part of newly
1032 allocated window.
1033 (allocate_process): Likewise for new process.
8edd4a2b 1034 (allocate_terminal): Change to use offsetof.
62efea5e
DA
1035 (allocate_frame): Likewise.
1036 * frame.c (make_frame): Omit redundant initialization.
1037 * window.c (make_parent_window): Use memset.
1038 (make_window): Omit redundant initialization.
1039 * process.c (make_process): Omit redundant initialization.
1040 * terminal.c (create_terminal): Likewise.
1041
42997f4d
DA
10422012-06-26 Dmitry Antipov <dmantipov@yandex.ru>
1043
1044 * term.c (delete_tty): Remove redundant call to memset.
1045
1130ecfc
DA
10462012-06-26 Dmitry Antipov <dmantipov@yandex.ru>
1047
1048 * alloc.c: Remove build_string.
1049 * lisp.h: Define build_string as static inline. This provides
1050 a better opportunity to optimize away calls to strlen when the
1051 function is called with compile-time constant argument.
1052 * image.c (imagemagick_error): Convert to build_string.
1053 * w32proc.c (sys_spawnve): Likewise.
1054 * xterm.c (x_term_init): Likewise.
1055
cf38a720
PE
10562012-06-26 Paul Eggert <eggert@cs.ucla.edu>
1057
99027bdd
PE
1058 Use sprintf return value instead of invoking strlen on result.
1059 In the old days this wasn't portable, since some sprintf
1060 implementations returned char *. But they died out years ago and
1061 Emacs already assumes sprintf returns int.
1062 Similarly for float_to_string.
1063 This patch speeds up (number-to-string 1000) by 3% on Fedora 15 x86-64.
1064 * ccl.c (ccl_driver):
1065 * character.c (string_escape_byte8):
1066 * data.c (Fnumber_to_string):
1067 * doprnt.c (doprnt):
1068 * print.c (print_object):
1069 * xdisp.c (message_dolog):
1070 * xfns.c (syms_of_xfns):
1071 Use sprintf or float_to_string result to avoid need to call strlen.
1072 * data.c (Fnumber_to_string):
1073 Use make_unibyte_string, since the string must be ASCII.
1074 * lisp.h, print.c (float_to_string): Now returns int length.
1075 * term.c (produce_glyphless_glyph):
1076 Use sprintf result rather than recomputing it.
1077
cf38a720
PE
1078 Clean out last vestiges of the old HAVE_CONFIG_H stuff.
1079 * Makefile.in (ALL_CFLAGS):
1080 * makefile.w32-in (LOCAL_FLAGS): Remove -DHAVE_CONFIG_H.
1081 * gmalloc.c, regex.c: Include <config.h> unconditionally.
1082
3511c784
DA
10832012-06-25 Dmitry Antipov <dmantipov@yandex.ru>
1084
0a08eb21 1085 * dispextern.h (xstrcasecmp): Define to library function
3511c784
DA
1086 strcasecmp if available.
1087 * xfaces.c: Do not use xstrcasecmp if strcasecmp is available.
1088
fb7da12e
AS
10892012-06-25 Andreas Schwab <schwab@linux-m68k.org>
1090
1091 * keyboard.c (menu_bar_items, menu_bar_item, read_key_sequence):
1092 Avoid comma operator.
1093 * menu.c (push_submenu_start, push_submenu_end)
1094 (push_left_right_boundary, push_menu_pane): Likewise.
1095 * msdos.c (dos_rawgetc): Likewise.
1096
afa2ffd8
DA
10972012-06-25 Dmitry Antipov <dmantipov@yandex.ru>
1098
1099 * xfns.c (xic_create_fontsetname): Remove redundant calls
1100 to memset.
1101
b3b4476b
PE
11022012-06-25 Paul Eggert <eggert@cs.ucla.edu>
1103
4495ff38
PE
1104 * gtkutil.c (get_utf8_string): Remove redundant assignment.
1105 sprintf already null-terminates its output.
1106
b3b4476b
PE
1107 * xfns.c (x_window): Remove redundant cast.
1108
b00876c9
DA
11092012-06-25 Dmitry Antipov <dmantipov@yandex.ru>
1110
1111 * xmenu.c (xmenu_show, xdialog_show): Explicit cast from
1112 `const char *' to `char *' to avoid compiler warning.
1113
d188e26b
PE
11142012-06-24 Paul Eggert <eggert@cs.ucla.edu>
1115
885d1d74
PE
1116 * xterm.c (x_term_init): Build proper-sized _XSETTINGS_Snnn string
1117 instead of truncating it to 63 (admittedly a generous limit).
1118
d188e26b
PE
1119 * process.c: Fix spelling and caps in comments.
1120
e2f560b1
DN
11212012-06-24 Dan Nicolaescu <dann@ics.uci.edu>
1122
e86db54b 1123 * emacs.c (setpgrp): Remove definition, unused.
e2f560b1
DN
1124 * sysdep.c (setpgrp): Remove definition, not used in this file.
1125
7583a3a1
JB
11262012-06-24 Juanma Barranquero <lekktu@gmail.com>
1127
1128 * makefile.w32-in: Update dependencies.
1129
696056c2
EZ
11302012-06-24 Eli Zaretskii <eliz@gnu.org>
1131
1132 * makefile.w32-in (TIMESPEC_H): Remove nt/inc/sys/time.h.
1133 (SYSTIME_H): Add nt/inc/sys/time.h.
1134
1135 * systime.h [WINDOWSNT]: Include sys/time.h.
1136
1137 * s/ms-w32.h (struct timespec): Definition moved from
1138 nt/inc/sys/time.h. Suggested by Paul Eggert <eggert@cs.ucla.edu>.
1139
845ca893
PE
11402012-06-24 Paul Eggert <eggert@cs.ucla.edu>
1141
1142 Switch from NO_RETURN to C11's _Noreturn (Bug#11750).
1143 * buffer.h (buffer_slot_type_mismatch):
1144 * data.c (arith_error) [!FORWARD_SIGNAL_TO_MAIN_THREAD]:
1145 * eval.c (unwind_to_catch):
1146 * image.c (my_png_error, my_error_exit):
1147 * keyboard.c (quit_throw_to_read_char, user_error)
1148 (Fexit_recursive_edit, Fabort_recursive_edit):
1149 * lisp.h (die, args_out_of_range, args_out_of_range_3)
1150 (wrong_type_argument, buffer_overflow, __executable_start)
1151 (memory_full, buffer_memory_full, string_overflow, Fthrow)
1152 (xsignal, xsignal0, xsignal1, xsignal2, xsignal3, signal_error)
1153 (error, verror, nsberror, report_file_error, Ftop_level, Fkill_emacs)
1154 (fatal):
1155 (child_setup) [!DOS_NT]:
1156 * lread.c (end_of_file_error, invalid_syntax):
1157 * process.c (send_process_trap) [!FORWARD_SIGNAL_TO_MAIN_THREAD]:
1158 * puresize.h (pure_write_error):
1159 * search.c (matcher_overflow):
1160 * sound.c (sound_perror, alsa_sound_perror):
1161 * sysdep.c, syssignal.h (croak):
1162 * term.c (maybe_fatal, vfatal):
1163 * textprop.c (text_read_only):
1164 * undo.c (user_error):
1165 * unexmacosx.c (unexec_error):
1166 * xterm.c (x_ins_del_lines, x_delete_glyphs):
1167 Use _Noreturn rather than NO_RETURN.
1168 No need for separate decl merely because of _Noreturn.
1169 * sound.c (sound_warning, parse_sound):
1170 Remove unnecessary forward decls.
1171
f1dd8073
PE
11722012-06-24 Paul Eggert <eggert@cs.ucla.edu>
1173
1174 Fix bug when time_t is unsigned and as wide as intmax_t (Bug#9000).
1175 * lisp.h (WAIT_READING_MAX): New macro.
1176 * dispnew.c (Fsleep_for, sit_for):
1177 * keyboard.c (kbd_buffer_get_event):
1178 * process.c (Faccept_process_output):
1179 Use it to avoid bogus compiler warnings with obsolescent GCC versions.
1180 This improves on the previous patch, which introduced a bug
1181 when time_t is unsigned and as wide as intmax_t.
1182 See <http://bugs.gnu.org/9000#51>.
1183
b82c1755
EZ
11842012-06-23 Eli Zaretskii <eliz@gnu.org>
1185
1186 * dispnew.c (sit_for, Fsleep_for):
1187 * keyboard.c (kbd_buffer_get_event):
1188 * process.c (Faccept_process_output): Avoid compiler warnings when
1189 comparing a 32-bit time_t with a 64-bit INTMAX_MAX.
1190
ca300656
JB
11912012-06-23 Juanma Barranquero <lekktu@gmail.com>
1192
049ec95b
JB
1193 * makefile.w32-in: Update dependencies.
1194
ca300656
JB
1195 * w32.c (ltime): Add return type and declare static.
1196 (w32_get_internal_run_time): Remove usused variable `time_100ns'.
1197
db7b8d06
PE
11982012-06-23 Paul Eggert <eggert@cs.ucla.edu>
1199
1200 * sysdep.c [__FreeBSD__]: Fix more recently-introduced typos.
1201 Privately reported by Herbert J. Skuhra.
1202 (make_lisp_timeval) [__FreeBSD__]: Rename from TIMELIST.
1203 All uses changed.
1204 (system_process_attributes) [__FreeBSD__]: Invoke make_lisp_time,
1205 not make_lisp_timeval, when the argument is of type EMACS_TIME.
1206
0bd8297f
EZ
12072012-06-23 Eli Zaretskii <eliz@gnu.org>
1208
96512555
EZ
1209 * w32proc.c (Fw32_get_locale_info): Fix an off-by-one error in
1210 last argument of make_unibyte_string.
1211
0bd8297f
EZ
1212 * keyboard.c (kbd_buffer_get_event): Include the codepage and the
1213 language ID in the event parameters.
1214
1215 * w32term.c (w32_read_socket): Put the new keyboard codepage into
1216 event.code, not the obscure "character set ID".
1217
63def6b6
CY
12182012-06-23 Chong Yidong <cyd@gnu.org>
1219
1220 * xmenu.c (x_menu_wait_for_event): Adapt GTK3 to new xg_select.
1221
e8a02204
EZ
12222012-06-23 Eli Zaretskii <eliz@gnu.org>
1223
388cdec0
EZ
1224 Fix the MS-Windows build broken by 2012-06-22T21:17:42Z!eggert@cs.ucla.edu.
1225 * w32.c (fdutimens): New function.
1226
1227 * w32proc.c (sys_select): Adapt to change in the EMACS_TIME type.
1228
1229 * s/ms-w32.h (pselect): Redirect to sys_select.
1230
1231 * sysselect.h [WINDOWSNT]: Don't include sys/select.h.
1232
e8a02204
EZ
1233 * ralloc.c (r_alloc_inhibit_buffer_relocation): Fix stupid thinko
1234 in the logic of incrementing and decrementing the value of
1235 use_relocatable_buffers.
1236
d054f3fb
PE
12372012-06-23 Paul Eggert <eggert@cs.ucla.edu>
1238
1239 * sysdep.c [__FreeBSD__]: Fix recently-introduced typos.
1240 Privately reported by Herbert J. Skuhra.
1241 [__FreeBSD__]: Remove "*/" typo after "#include".
1242 (timeval_to_EMACS_TIME) [__FreeBSD__]: New static function.
1243 (TIMEVAL) [__FreeBSD__]: Now a static function rather than a macro.
1244 (TIMEVAL, system_process_attributes) [__FreeBSD__]:
1245 Don't assume EMACS_TIME and struct timeval are the same type.
1246
d35af63c
PE
12472012-06-22 Paul Eggert <eggert@cs.ucla.edu>
1248
1249 Support higher-resolution time stamps (Bug#9000).
1250 The time stamps are only nanosecond-resolution at the C level,
1251 since that's the best that any real-world system supports now.
1252 But they are picosecond-resolution at the Lisp level, as that's
1253 easy, and leaves room for future OS improvements.
1254
1255 * Makefile.in (LIB_CLOCK_GETTIME): New macro.
1256 (LIBES): Use it.
1257
1258 * alloc.c (Fgarbage_collect): Port to higher-res time stamps.
1259 Don't get current time unless it's needed.
1260
1261 * atimer.c: Include <sys/time.h> unconditionally, since gnulib
1262 now provides it if it's absent.
1263 (start_atimer): Port to higher-res time stamps.
1264 Check for time stamp overflow. Don't get current time more
1265 often than is needed.
1266
1267 * buffer.h (struct buffer): Buffer modtime now has high resolution.
1268 Include systime.h, not time.h.
1269 (NONEXISTENT_MODTIME_NSECS, UNKNOWN_MODTIME_NSECS): New macros.
1270
1271 * dired.c: Include stat-time.h.
1272 (Ffile-attributes): File times now have higher resolution.
1273
1274 * dispextern.h [HAVE_WINDOW_SYSTEM]: Include systime.h.
1275 (struct image): Timestamp now has higher resolution.
1276
1277 * dispnew.c (PERIODIC_PREEMPTION_CHECKING): Remove, as Emacs always
1278 has at least microseconds now. All uses removed.
1279 (update_frame, update_single_window, update_window, update_frame_1)
1280 (Fsleep_for, sit_for): Port to higher-resolution time stamps.
1281
1282 * editfns.c (time_overflow): Now extern.
1283 (Fcurrent_time, Fget_internal_run_time, make_time, lisp_time_argument)
1284 (float-time, Fformat_time_string, Fcurrent_time_string)
1285 (Fcurrent_time_zone): Accept and generate higher-resolution
1286 time stamps.
1287 (make_time_tail, make_lisp_time, dissassemble_lisp_time)
1288 (decode_time_components, lisp_seconds_argument): New functions.
1289 (make_time): Now static.
1290 (lisp_time_argument): Now returns EMACS_TIME. New arg ppsec.
1291 Report an error if the time is invalid, rather than having the caller
1292 do that.
1293
1294 * fileio.c: Include <stat-time.h>
1295 (Fcopy_file): Copy higher-resolution time stamps.
1296 Prefer to set the time stamp via a file descriptor if that works.
1297 (Fset_file_times, Finsert_file_contents, Fwrite_region)
1298 (Fverify_visited_file_modtime, Fclear_visited_file_modtime)
1299 (Fvisited_file_modtime, Fset_visited_file_modtime):
1300 Support higher-resolution time stamps.
1301
1302 * fns.c (Frandom): Use nanoseconds, not microseconds, for seed.
1303
1304 * gtkutil.c (xg_maybe_add_timer): Port to higher-res time stamps.
1305
1306 * image.c (prepare_image_for_display, clear_image_cache)
1307 (lookup_image): Port to higer-resolution time stamps.
1308
1309 * keyboard.c (start_polling, bind_polling_period):
1310 Check for time stamp overflow.
1311 (read_char, kbd_buffer_get_event, timer_start_idle)
1312 (timer_stop_idle, timer_resume_idle, timer_check_2, timer_check)
1313 (Fcurrent_idle_time, init_keyboard, set_waiting_for_input):
1314 Port to higher-resolution time stamps. Do not assume time_t is signed.
1315 (decode_timer): New function. Timers are now vectors of length 9,
1316 not 8, to accommodate the picosecond component.
1317 (timer_check_2): Use it.
1318
1319 * nsterm.m (select_timeout, timeval_subtract): Remove.
1320 (ns_timeout): Use Emacs's facilities for time stamp arithmetic,
1321 as they're a bit more accurate and handle overflow better.
1322 (ns_select): Change prototype to be compatible with pselect.
1323 (ns_select, ns_term_shutdown): Port to ns-resolution time stamps.
1324 * nsterm.h (ns_select): Adjust prototype.
1325
1326 * msdos.c (EMACS_TIME_ZERO_OR_NEG_P): Remove, as it assumes
1327 us-resolution time stamps.
1328 (sys_select): Use the new EMACS_TIME_SIGN macro instead.
1329
1330 * lread.c (read_filtered_event): Port to ns-resolution time stamps.
1331
1332 * lisp.h (time_overflow): New decl.
1333 (wait_reading_process_output): First arg is now intmax_t, not int,
1334 to accommodate larger waits.
1335
1336 * process.h (struct Lisp_Process.read_output_delay):
1337 Now counts nanoseconds, not microseconds.
1338 * process.c (ADAPTIVE_READ_BUFFERING): Don't worry about
1339 EMACS_HAS_USECS.
1340 (READ_OUTPUT_DELAY_INCREMENT, Faccept_process_output)
1341 (wait_reading_process_output):
1342 Port to ns-resolution time stamps.
1343 (Faccept_process_output, wait_reading_process_output):
1344 Check for time stamp overflow. Do not assume time_t is signed.
1345 (select_wrapper): Remove; we now use pselect.
1346 (Fprocess_attributes): Now generates ns-resolution time stamps.
1347
1348 * sysdep.c: Include utimens.h. Don't include utime.h
1349 or worry about struct utimbuf; gnulib does that for us now.
1350 (gettimeofday): Remove; gnulib provides a substitute.
1351 (make_timeval): New function.
1352 (set_file_times): Now sets ns-resolution time stamps.
1353 New arg FD; all uses changed.
1354 (time_from_jiffies, ltime_from_jiffies, get_up_time)
1355 (system_process_attributes):
1356 Now returns ns-resolution time stamp. All uses changed.
1357 Check for time stamp overflow.
1358
1359 * sysselect.h: Don't depend on HAVE_SYS_SELECT_H; gnulib
1360 provides a substitute now.
1361
1362 * systime.h: Include timespec.h rather than sys/time.h and time.h,
1363 since it guarantees struct timespec.
1364 (EMACS_TIME): Now struct timespec, so that we can support
1365 ns-resolution time stamps.
1366 (EMACS_TIME_RESOLUTION, LOG10_EMACS_TIME_RESOLUTION): New macros.
1367 (EMACS_HAS_USECS): Remove; Emacs always has sub-second time stamps now.
1368 (EMACS_USECS): Remove.
1369 (EMACS_SET_USECS): The underlying time stamp now has ns resolution,
1370 so multiply the arg by 1000 before storing it.
1371 (EMACS_NSECS, EMACS_SECS_ADDR, EMACS_SET_NSECS, EMACS_SET_SECS_NSECS):
1372 New macros.
1373 (EMACS_GET_TIME, EMACS_ADD_TIME, EMACS_SUB_TIME):
1374 Port to ns-resolution time stamps.
1375 (EMACS_TIME_NEG_P): Remove; replaced by....
1376 (EMACS_TIME_SIGN): New macro.
1377 (EMACS_SET_INVALID_TIME, EMACS_TIME_VALID_P)
1378 (EMACS_TIME_FROM_DOUBLE, EMACS_TIME_TO_DOUBLE): New macros.
1379 (set_file_times, make_time, lisp_time_argument): Adjust signature.
1380 (make_timeval, make_lisp_time, decode_time_components): New decls.
1381 (EMACS_TIME_CMP): Remove; no longer used. Plus, it was buggy, in
1382 that it mishandled time_t overflow. You can't compare by subtracting!
1383 (EMACS_TIME_EQ, EMACS_TIME_NE, EMACS_TIME_GT, EMACS_TIME_GE)
1384 (EMACS_TIME_LT, EMACS_TIME_LE): Rewrite in terms of timespec_cmp.
1385
1386 * term.c: Include <sys/time.h>.
1387 (timeval_to_Time): New function, for proper overflow wraparound.
1388 (term_mouse_position, term_mouse_click): Use it.
1389
1390 * undo.c (record_first_change): Support higher-resolution time stamps
1391 in the undo buffer.
1392 (Fprimitive_undo): Use them when restoring time stamps.
1393
1394 * w32.c (ltime, U64_TO_LISP_TIME, process_times, emacs_gnutls_pull)
1395 (w32_get_internal_run_time):
1396 Port to higher-resolution Emacs time stamps.
1397 (ltime): Now accepts single 64-bit integer, as that's more convenient
1398 for callers.
1399
1400 * xdisp.c (start_hourglass): Port to ns-resolution time stamps.
1401
1402 * xgselect.c, xgselect.h (xg_select): Add sigmask argument,
1403 for compatibility with pselect. Support ns-resolution time stamps.
1404
1405 * xmenu.c (x_menu_wait_for_event): Support ns-resolution time stamps.
1406
1407 * xselect.c (wait_for_property_change, x_get_foreign_selection):
1408 Check for time stamp overflow, and support ns-resolution time stamps.
1409
1410 * xterm.c: Don't include sys/time.h; gnulib does that for us now.
1411 Don't worry about whether HAVE_TIMEVAL and HAVE_SELECT are set.
1412 (timeval_subtract): Remove; no longer needed.
1413 (XTflash, XTring_bell, x_wait_for_event):
1414 Port to ns-resolution time stamps. Don't assume time_t is signed.
1415
b6a92dfe
CY
14162012-06-22 Chong Yidong <cyd@gnu.org>
1417
1418 * xdisp.c (x_consider_frame_title): Revert last change.
1419
d251c37c
EZ
14202012-06-22 Eli Zaretskii <eliz@gnu.org>
1421
1422 * alloc.c (NSTATICS): Enlarge to 0x650. Otherwise, Emacs compiled
1423 with -DENABLE_CHECKING -DXASSERTS -DGLYPH_DEBUG=1 -DBYTE_CODE_METER
1424 aborts in staticpro during startup. (Without -DBYTE_CODE_METER,
1425 staticidx goes up to 1597 out of 1600 = 0x640.)
1426
f10deafb
PE
14272012-06-20 Paul Eggert <eggert@cs.ucla.edu>
1428
1429 * fileio.c (Fdefault_file_modes): Block input while fiddling with umask.
1430 Otherwise, the umask might be mistakenly 0 while handling input signals.
1431
ec6de1e2
SM
14322012-06-19 Stefan Monnier <monnier@iro.umontreal.ca>
1433
1434 * minibuf.c (Fread_string): Bind minibuffer-completion-table.
1435
28be1ada
DA
14362012-06-19 Dmitry Antipov <dmantipov@yandex.ru>
1437
1438 * alloc.c, bytecode.c, ccl.c, coding.c, composite.c, data.c, dosfns.c:
1439 * font.c, image.c, keyboard.c, lread.c, menu.c, minibuf.c, msdos.c:
1440 * print.c, syntax.c, window.c, xmenu.c, xselect.c: Replace direct
1441 access to `contents' member of Lisp_Vector objects with AREF and ASET
1442 where appropriate.
1443
c6bf3022
CY
14442012-06-19 Chong Yidong <cyd@gnu.org>
1445
1446 * frame.c (delete_frame): When selecting a frame on a different
1447 text terminal, do not alter the terminal's top-frame.
1448
1449 * xdisp.c (format_mode_line_unwind_data): Record the target
1450 frame's selected window and its terminal's top-frame.
1451 (unwind_format_mode_line): Restore them.
1452 (x_consider_frame_title, display_mode_line, Fformat_mode_line):
1453 Callers changed.
1454 (x_consider_frame_title): Do not condition on HAVE_WINDOW_SYSTEM,
1455 since tty frames can be explicitly named.
1456 (prepare_menu_bars): Likewise.
1457
1458 * term.c (Ftty_top_frame): New function.
1459
defd4196
PE
14602012-06-18 Paul Eggert <eggert@cs.ucla.edu>
1461
1462 Port byte-code-meter to modern targets.
1463 * bytecode.c (METER_CODE) [BYTE_CODE_METER]: Don't assume
1464 !CHECK_LISP_OBJECT_TYPE && !USE_LSB_TAG. Problem with
8b5257e1 1465 CHECK_LISP_OBJECT_TYPE reported by Dmitry Antipov in
defd4196
PE
1466 <http://lists.gnu.org/archive/html/emacs-devel/2012-06/msg00282.html>.
1467 (METER_1, METER_2): Simplify.
1468
1053a871
SM
14692012-06-18 Stefan Monnier <monnier@iro.umontreal.ca>
1470
1471 * data.c (Fdefalias): Return `symbol' (bug#11686).
1472
b7e8d081
MR
14732012-06-18 Martin Rudalics <rudalics@gmx.at>
1474
1475 * buffer.c (Fkill_buffer): Don't throw an error when the buffer
1053a871
SM
1476 gets killed during executing of this function (Bug#11665).
1477 Try to always return Qt when the buffer has been actually killed.
b7e8d081
MR
1478 (Vkill_buffer_query_functions): In doc-string say that functions
1479 run by this hook should not change the current buffer.
1480
7ea2b339
PE
14812012-06-18 Paul Eggert <eggert@cs.ucla.edu>
1482
1483 Fix recently-introduced process.c problems found by static checking.
1484 * process.c (write_queue_push, write_queue_pop, send_process):
1485 Use ptrdiff_t, not int or EMACS_INT, for buffer lengths and offsets.
1486 (write_queue_pop): Fix pointer signedness problem.
1487 (send_process): Remove unused local.
1488
96a313a1
CY
14892012-06-17 Chong Yidong <cyd@gnu.org>
1490
1491 * xdisp.c (redisplay_internal): No need to redisplay terminal
1492 frames that are not on top.
1493
20ca2e94
TN
14942012-06-17 Troels Nielsen <bn.troels@gmail.com>
1495
1496 * process.c (make_process): Initialize write_queue.
1497 (write_queue_push, write_queue_pop): New functions.
1498 (send_process): Use them to maintain correct ordering of process
1499 writes (Bug#10815).
1500
9a900ca9
PE
15012012-06-17 Paul Eggert <eggert@cs.ucla.edu>
1502
310fbfa8
PE
1503 * lisp.h (eassert): Assume C89 or later.
1504 This removes the need for CHECK.
1505 (CHECK): Remove. Its comments about always evaluating its
1506 argument were confusing, as 'eassert' typically does not evaluate
1507 its argument.
1508
27bb1ca4
PE
1509 * coding.c (produce_chars): Use ptrdiff_t, not int.
1510
9a900ca9
PE
1511 * xterm.c (x_draw_underwave): Check for integer overflow.
1512 This pacifies gcc 4.7.0 -Wunsafe-loop-optimizations on x86-64.
1513
41b7f8bc 15142012-06-17 Jan Djärv <jan.h.d@swipnet.se>
50a93863
JD
1515
1516 * nsterm.m (x_free_frame_resources): Move xfree so freed memory isn't
1517 referenced (Bug#11583).
1518
9b0e3eba
AA
15192012-06-16 Aurelien Aptel <aurelien.aptel@gmail.com>
1520
1521 Implement wave-style variant of underlining.
1522 * dispextern.h (face_underline_type): New enum.
1523 (face): Add field for underline type.
1524 * nsterm.m (ns_draw_underwave): New function.
1525 (ns_draw_text_decoration): Use it.
1526 * w32term.c (w32_restore_glyph_string_clip, w32_draw_underwave):
1527 New functions.
1528 (x_draw_glyph_string): Use them.
1529 * xfaces.c (Qline, Qwave): New Lisp objects.
1530 (check_lface_attrs, merge_face_ref)
1053a871
SM
1531 (Finternal_set_lisp_face_attribute, realize_x_face):
1532 Handle wave-style underline face attributes.
9b0e3eba
AA
1533 * xterm.c (x_draw_underwave): New function.
1534 (x_draw_glyph_string): Use it.
1535
0fb52f11
JB
15362012-06-16 Juanma Barranquero <lekktu@gmail.com>
1537
1538 * makefile.w32-in ($(BLD)/emacs.$(O), $(BLD)/fringe.$(O))
1539 ($(BLD)/xml.$(O), $(BLD)/intervals.$(O), $(BLD)/macros.$(O))
1540 ($(BLD)/minibuf.$(O), $(BLD)/regex.$(O), $(BLD)/region-cache.$(O))
1541 ($(BLD)/textprop.$(O), $(BLD)/undo.$(O), $(BLD)/window.$(O))
1542 ($(BLD)/w32select.$(O)): Update dependencies.
1543
e5560ff7
AS
15442012-06-16 Andreas Schwab <schwab@linux-m68k.org>
1545
1546 * buffer.h (FETCH_MULTIBYTE_CHAR): Define as inline.
1547 (BUF_FETCH_MULTIBYTE_CHAR): Likewise.
1548 * character.c (_fetch_multibyte_char_p): Remove.
1549 * alloc.c: Include "character.h" before "buffer.h".
1550 * bidi.c: Likewise.
1551 * buffer.c: Likewise.
1552 * bytecode.c: Likewise.
1553 * callint.c: Likewise.
1554 * callproc.c: Likewise.
1555 * casefiddle.c: Likewise.
1556 * casetab.c: Likewise.
1557 * category.c: Likewise.
1558 * cmds.c: Likewise.
1559 * coding.c: Likewise.
1560 * composite.c: Likewise.
1561 * dired.c: Likewise.
1562 * dispnew.c: Likewise.
1563 * doc.c: Likewise.
1564 * dosfns.c: Likewise.
1565 * editfns.c: Likewise.
1566 * emacs.c: Likewise.
1567 * fileio.c: Likewise.
1568 * filelock.c: Likewise.
1569 * font.c: Likewise.
1570 * fontset.c: Likewise.
1571 * fringe.c: Likewise.
1572 * indent.c: Likewise.
1573 * insdel.c: Likewise.
1574 * intervals.c: Likewise.
1575 * keyboard.c: Likewise.
1576 * keymap.c: Likewise.
1577 * lread.c: Likewise.
1578 * macros.c: Likewise.
1579 * marker.c: Likewise.
1580 * minibuf.c: Likewise.
1581 * nsfns.m: Likewise.
1582 * nsmenu.m: Likewise.
1583 * print.c: Likewise.
1584 * process.c: Likewise.
1585 * regex.c: Likewise.
1586 * region-cache.c: Likewise.
1587 * search.c: Likewise.
1588 * syntax.c: Likewise.
1589 * term.c: Likewise.
1590 * textprop.c: Likewise.
1591 * undo.c: Likewise.
1592 * unexsol.c: Likewise.
1593 * w16select.c: Likewise.
1594 * w32fns.c: Likewise.
1595 * w32menu.c: Likewise.
1596 * window.c: Likewise.
1597 * xdisp.c: Likewise.
1598 * xfns.c: Likewise.
1599 * xmenu.c: Likewise.
1600 * xml.c: Likewise.
1601 * xselect.c: Likewise.
1602
2f07e6af
EZ
16032012-06-16 Eli Zaretskii <eliz@gnu.org>
1604
1053a871
SM
1605 * xdisp.c (set_cursor_from_row): Don't dereference glyphs_end.
1606 If all the glyphs of the glyph row came from strings, and we have no
2f07e6af 1607 cursor positioning clues, put the cursor on the first glyph of the
1097afe4
EZ
1608 row.
1609 (handle_face_prop): Use chunk-relative overlay string index when
1610 indexing into it->string_overlays array. (Bug#11653)
946fdb73
EZ
1611 (set_cursor_from_row): Use the leftmost glyph as GLYPH_BEFORE, not
1612 the rightmost. (Bug#11720)
2f07e6af 1613
29b83cec
AS
16142012-06-16 Andreas Schwab <schwab@linux-m68k.org>
1615
1616 * category.h (CHAR_HAS_CATEGORY): Define as inline.
1617 (CATEGORY_MEMBER): Enforce 1/0 value.
1618 * category.c (_temp_category_set): Remove.
1619
4c5501e9
EZ
16202012-06-16 Eli Zaretskii <eliz@gnu.org>
1621
1622 * window.c (Fdelete_other_windows_internal)
1623 (Fdelete_window_internal): Don't access frame's mouse highlight
1624 info of the initial frame. (Bug#11677)
1625
2b570124
PE
16262012-06-14 Paul Eggert <eggert@cs.ucla.edu>
1627
e93864f9
PE
1628 * .gdbinit (xgetint): Fix recently-introduced paren typo.
1629 Assume USE_2_TAGS_FOR_INTS.
1630 (xreload): Adjust $tagmask width to match recent lisp.h change.
1631
2b570124
PE
1632 Simplify lisp.h in minor ways that should not affect code.
1633 * lisp.h (USE_2_TAGS_FOR_INTS): Remove, as it was always defined.
1634 (LISP_INT_TAG, case_Lisp_Int, LISP_STRING_TAG, LISP_INT_TAG_P)
1635 (LISP_INT1_TAG, enum Lisp_Type, XINT, XUINT, make_number):
1636 Simplify under the assumption that USE_2_TAGS_FOR_INTS is defined.
1637 (INTTYPEBITS): New macro, for clarity.
1638 (INTMASK, MOST_POSITIVE_FIXNUM): Use it.
1053a871
SM
1639 (LISP_INT1_TAG, LISP_STRING_TAG, LISP_INT_TAG_P):
1640 Simplify now that USE_LSB_TAG is always defined.
2b570124
PE
1641 (TYPEMASK, XINT) [USE_LSB_TAG]: Remove unnecessary cast.
1642 (make_number) [!USE_LSB_TAG]: Use INTMASK; that's simpler.
1643
81755f69
JB
16442012-06-13 Juanma Barranquero <lekktu@gmail.com>
1645
1646 * makefile.w32-in ($(BLD)/data.$(O)): Update dependencies.
1647
16192a57
GM
16482012-06-13 Glenn Morris <rgm@gnu.org>
1649
1650 * s/bsd-common.h (BSD4_3):
1651 * s/usg5-4-common.h (USG5_4): No longer define; unused.
1652
646b5f55
AS
16532012-06-13 Andreas Schwab <schwab@linux-m68k.org>
1654
1655 * lisp.h (Lisp_Object) [CHECK_LISP_OBJECT_TYPE]: Define as struct
1656 instead of union.
1657 (XLI, XIL): Define.
1053a871
SM
1658 (XHASH, XTYPE, XINT, XUINT, make_number, XSET, XPNTR, XUNTAG):
1659 Use them.
1660 * emacs.c (gdb_use_struct): Rename from gdb_use_union.
646b5f55 1661 * .gdbinit: Check gdb_use_struct instead of gdb_use_union.
1053a871 1662 * alloc.c (widen_to_Lisp_Object): Remove.
646b5f55
AS
1663 (mark_memory): Use XIL instead of widen_to_Lisp_Object.
1664 * frame.c (delete_frame): Remove outdated comment.
1665 * w32fns.c (Fw32_register_hot_key): Use XLI instead of checking
1666 USE_LISP_UNION_TYPE.
1667 (Fw32_unregister_hot_key): Likewise.
1668 (Fw32_toggle_lock_key): Likewise.
1669 * w32menu.c (add_menu_item): Likewise.
1670 (w32_menu_display_help): Use XIL instead of checking
1671 USE_LISP_UNION_TYPE.
1672 * w32heap.c (allocate_heap): Don't check USE_LISP_UNION_TYPE.
1673 (init_heap): Likewise.
1674 * w32term.c (w32_read_socket): Update comment.
1675
1d3823c9
GM
16762012-06-13 Glenn Morris <rgm@gnu.org>
1677
c62ff706
GM
1678 * s/usg5-4-common.h, src/s/unixware.h:
1679 Remove define/undef of HAVE_SYSV_SIGPAUSE (not used since 2010-05-04).
1680
1d3823c9
GM
1681 * s/gnu.h (POSIX_SIGNALS): Remove (not used since 2010-05-04).
1682
bfe3e0a2
PE
16832012-06-13 Paul Eggert <eggert@cs.ucla.edu>
1684
1685 USE_LISP_UNION_TYPE + USE_LSB_TAG cleanup (Bug#11604)
1686 * alloc.c (make_number) [!defined make_number]:
1687 Remove, as lisp.h always defines this now.
1688 (mark_maybe_pointer): Simplify since USE_LSB_TAG is always defined now.
1689 (roundup_size): Verify that it is a power of 2.
1690 * data.c (Fmake_variable_buffer_local, Fmake_local_variable):
1691 * ftfont.c (ftfont_driver): Use LISP_INITIALLY_ZERO.
1692 * lisp.h (USE_LSB_TAG): Allow the builder to compile with
1693 -DUSE_LSB_TAG=0, to override the automatically-selected default.
1694 USE_LSB_TAG now is always defined to be either 0 or 1.
1695 All uses changed.
1696 (union Lisp_Object): Don't worry about WORDS_BIGENDIAN; the
1697 code works fine either way, and efficiency is not a concern here,
1698 as the union type is for debugging, not for production.
1699 (LISP_MAKE_RVALUE, make_number) [USE_LISP_UNION_TYPE]:
1700 Use an inline function on all platforms when using the union type,
1701 since this is simpler and 'static inline' can be used portably
1702 within Emacs now.
1703 (LISP_INITIALLY_ZERO): New macro.
1704 (XFASTINT, XSETFASTINT) [USE_LISP_UNION_TYPE]: Remove.
1705 (XSET) [USE_LISP_UNION_TYPE]: Don't overparenthesize.
1706
45fa9c0f
GM
17072012-06-12 Glenn Morris <rgm@gnu.org>
1708
b4492cba
GM
1709 * s/gnu-kfreebsd.h, s/hpux11.h, s/openbsd.h, s/sol2-10.h: Remove files.
1710
1711 * s/gnu-linux.h (HAVE_PROCFS): Move to configure.
0d369729 1712
45fa9c0f
GM
1713 * s/hpux10-20.h, s/openbsd.h, s/usg5-4-common.h:
1714 Move BROKEN_SIGIO to configure.
1715
1716 * s/bsd-common.h, s/darwin.h, s/gnu-kfreebsd.h, s/hpux10-20.h:
1717 Move NO_TERMIO to configure.
1718
0e25d334
CY
17192012-06-12 Chong Yidong <cyd@gnu.org>
1720
1721 * image.c (imagemagick_load_image): Use MagickFlattenImage if
1722 MagickMergeImageLayers is undefined. Use pixel pusher loop if
1723 MagickExportImagePixels is undefined.
1724
43682bb6
PE
17252012-06-12 Paul Eggert <eggert@cs.ucla.edu>
1726
1727 * image.c (imagemagick_load_image): Remove unused label.
1728
a9be7d2b
GM
17292012-06-11 Glenn Morris <rgm@gnu.org>
1730
1731 * s/aix4-2.h, s/bsd-common.h, s/cygwin.h, s/darwin.h:
1732 * s/gnu-kfreebsd.h, s/gnu-linux.h, s/gnu.h, s/hpux10-20.h:
1733 * s/irix6-5.h, s/ms-w32.h, s/msdos.h, s/template.h:
1734 * s/usg5-4-common.h: Move SYSTEM_TYPE to configure.
1735
3017f87f
SM
17362012-06-11 Stefan Monnier <monnier@iro.umontreal.ca>
1737
1738 * alloc.c (make_byte_code): New function.
1739 (Fmake_byte_code): Use it. Don't purify here.
1740 * lread.c (read1): Use it as well to avoid extra allocation.
1741
1b9b4cf4
CY
17422012-06-11 Chong Yidong <cyd@gnu.org>
1743
1744 * image.c (imagemagick_load_image): Implement transparency.
1745
95988fcf
AS
17462012-06-10 Andreas Schwab <schwab@linux-m68k.org>
1747
1748 * regex.c (at_begline_loc_p): Also recognize `(?N:' and correctly
1749 account for preceding backslashes. (Bug#11663)
1750
cd4eb164
CY
17512012-06-09 Chong Yidong <cyd@gnu.org>
1752
1753 * term.c: Support italics in capable terminals (Bug#9652).
1754 (no_color_bit): Replace unused NC_BLINK with NC_ITALIC.
1755 (turn_on_face): Output using TS_enter_italic_mode if available.
1756 Don't handle unused blinking and alt-charset cases.
1757 (turn_off_face): Handle italic case; discard unused tty_blinking_p
1758 and tty_alt_charset_p cases.
1759 (tty_capable_p, init_tty): Support italics.
1760
1761 * termchar.h (struct tty_display_info): Add field for italics.
1762 Remove unused blink field.
1763
1764 * xfaces.c (tty_supports_face_attributes_p, realize_tty_face):
1765 Handle slant.
1766
1767 * dispextern.h: Replace unused TTY_CAP_BLINK with TTY_CAP_ITALIC.
1768 (struct face): Remove unused fields tty_dim_p, tty_blinking_p, and
1769 tty_alt_charset_p. Add tty_italic_p.
1770
ff88beb8
MA
17712012-06-09 Michael Albinus <michael.albinus@gmx.de>
1772
1773 * dbusbind.c (XD_BASIC_DBUS_TYPE): Use dbus_type_is_valid and
1774 dbus_type_is_basic if available.
1775 (xd_extract_signed, xd_extract_unsigned): Rename from
1776 extract_signed and extract_unsigned, respectively. Adapt callers.
1777
44286096
CY
17782012-06-09 Chong Yidong <cyd@gnu.org>
1779
1682701f
CY
1780 * xfaces.c (face_for_overlay_string): Handle face remapping (Bug#2066).
1781
44286096
CY
1782 * fringe.c (Fset_fringe_bitmap_face): Handle the noninteractive
1783 case (Bug#9752).
1784
d86feb17
PE
17852012-06-08 Paul Eggert <eggert@cs.ucla.edu>
1786
1787 * xdisp.c (vmessage): Treat frame message as multibyte.
1788 Without this change, (let ((§ 1)) (make-variable-buffer-local '§))
1789 would generate the diagnostic "Making \302\247 buffer-local while
1790 let-bound!".
1791
d5c20fe8
EZ
17922012-06-08 Eli Zaretskii <eliz@gnu.org>
1793
1794 * dispnew.c (showing_window_margins_p): Undo last change, which
1795 was done due to an inadvertent commit.
1796 (adjust_frame_glyphs_for_frame_redisplay): Do call
1797 showing_window_margins_p.
1798
513749ee
SM
17992012-06-08 Stefan Monnier <monnier@iro.umontreal.ca>
1800
1801 * eval.c (Fmake_var_non_special): New primitive.
1802 (syms_of_eval): Defsubr it.
1803 * lread.c (syms_of_lread): Mark `values' as lexically scoped.
1804
d4a8f5c1
JB
18052012-06-08 Juanma Barranquero <lekktu@gmail.com>
1806
1807 * dispnew.c (showing_window_margins_p): Wrap in #if 0 to prevent unused
1808 function warning (the only call is inside #if 0 since 2012-06-08T08:44:45Z!eliz@gnu.org).
1809
8bbbc977
EZ
18102012-06-08 Eli Zaretskii <eliz@gnu.org>
1811
1812 * alloc.c (allocate_vectorlike): Fix last change.
1813
f3372c87
DA
18142012-06-08 Dmitry Antipov <dmantipov@yandex.ru>
1815
1816 Block-based vector allocation of small vectors.
1817 * lisp.h (struct vectorlike_header): New field `nbytes',
1818 adjust comment accordingly.
1819 * alloc.c (enum mem_type): New type `MEM_TYPE_VECTOR_BLOCK'
1820 to denote vector blocks. Adjust users (live_vector_p,
1821 mark_maybe_pointer, valid_lisp_object_p) accordingly.
1822 (COMMON_MULTIPLE): Move outside #if USE_LSB_TAG.
1823 (VECTOR_BLOCK_SIZE, vroundup, VECTOR_BLOCK_BYTES),
1824 (VBLOCK_BYTES_MIN, VBLOCK_BYTES_MAX, VECTOR_MAX_FREE_LIST_INDEX),
1825 (VECTOR_FREE_LIST_FLAG, ADVANCE, VINDEX, SETUP_ON_FREE_LIST),
1826 (VECTOR_SIZE, VECTOR_IN_BLOCK): New macros.
1827 (roundup_size): New constant.
1828 (struct vector_block): New data type.
1829 (vector_blocks, vector_free_lists, zero_vector): New variables.
513749ee 1830 (all_vectors): Rename to `large_vectors'.
f3372c87
DA
1831 (allocate_vector_from_block, init_vectors, allocate_vector_from_block)
1832 (sweep_vectors): New functions.
1833 (allocate_vectorlike): Return `zero_vector' as the only vector of
1834 0 items. Allocate new vector from block if vector size is less than
1835 or equal to VBLOCK_BYTES_MAX.
1836 (Fgarbage_collect): Move all vector sweeping code to sweep_vectors.
1837 (init_alloc_once): Add call to init_vectors.
1838
4f18a4ed
SM
18392012-06-08 Stefan Monnier <monnier@iro.umontreal.ca>
1840
1841 * eval.c (Fmacroexpand): Stop if the macro returns the same form.
1842
86f158bc
PE
18432012-06-07 Paul Eggert <eggert@cs.ucla.edu>
1844
1845 * doprnt.c (doprnt): Truncate multibyte char correctly.
1846 Without this change, doprnt (buf, 2, "%s", FORMAT_END, AP)
1847 would mishandle a string argument "Xc" if X was a multibyte
1848 character of length 2: it would truncate after X's first byte
1849 rather than including all of X.
1850
c5cfcbe0
CY
18512012-06-06 Chong Yidong <cyd@gnu.org>
1852
1853 * buffer.c (word_wrap): Doc fix.
1854
c05cf390
PE
18552012-06-04 Paul Eggert <eggert@cs.ucla.edu>
1856
1857 * xdisp.c (note_mode_line_or_margin_highlight): Pacify gcc -Wall.
1858
0c3461de
GM
18592012-06-03 Glenn Morris <rgm@gnu.org>
1860
1861 * xdisp.c (tool-bar-style): Doc fix.
1862
c71232db
UM
18632012-06-03 Ulrich Müller <ulm@gentoo.org>
1864
1865 * Makefile.in (PAXCTL): Define.
1866 (temacs$(EXEEXT)): Disable memory randomization for the temacs
1867 binary via PaX flags if the paxctl utility is available.
1868 (emacs$(EXEEXT), bootstrap-emacs$(EXEEXT)):
1869 Restore PaX flags to their default. (Bug#11398)
1870
383f7350
CY
18712012-06-03 Chong Yidong <cyd@gnu.org>
1872
1873 * xdisp.c (decode_mode_spec_coding): Display a space for a unibyte
1874 buffer (Bug#11226).
1875
5f2c76c6
CY
18762012-06-03 Chong Yidong <cyd@gnu.org>
1877
1878 * xdisp.c (calc_pixel_width_or_height): Use Fbuffer_local_value.
1879 (note_mode_line_or_margin_highlight): If there is no help echo,
1880 use mode-line-default-help-echo. Handle the case where the mouse
1881 position is past the end of the mode line string.
1882
1883 * buffer.c (buffer_local_value_1): New function, split from
1884 Fbuffer_local_value; can return Qunbound.
1885 (Fbuffer_local_value): Use it.
1886 (Vmode_line_format): Docstring tweaks.
1887
773d47f6
PE
18882012-06-02 Paul Eggert <eggert@cs.ucla.edu>
1889
1890 * sysdep.c (system_process_attributes): Improve comment.
1891
f2d6a3df
SM
18922012-06-02 Stefan Monnier <monnier@iro.umontreal.ca>
1893
1894 * keyboard.c: Export real-this-command to Elisp.
1895 (syms_of_keyboard): Rename real_this_command to Vreal_this_command
1896 and DEFVAR it. Update all users.
1897
63810350
PE
18982012-06-02 Paul Eggert <eggert@cs.ucla.edu>
1899
7bd5c1f4
PE
1900 * minibuf.c (Fassoc_string): Remove duplicate declaration.
1901
63810350
PE
1902 * sysdep.c (system_process_attributes) [SOLARIS2 && HAVE_PROCFS]:
1903 Convert pctcpu and pctmem to Lisp float properly.
1904 Let the compiler fold better, as 100.0/0x8000 is exact.
1905
a2821611
AS
19062012-06-02 Andreas Schwab <schwab@linux-m68k.org>
1907
1908 * alloc.c (CONS_BLOCK_SIZE): Account for padding at the end of
1909 cons_block.
1910
5fceba1d
PE
19112012-06-01 Paul Eggert <eggert@cs.ucla.edu>
1912
1913 * xfns.c (x_set_tool_bar_lines) [USE_GTK]: Adjust to bitfield change.
1914
c98ff5dd
DA
19152012-06-01 Dmitry Antipov <dmantipov@yandex.ru>
1916
1917 For a 'struct window', replace some Lisp_Object fields to
1918 bitfields where appropriate, remove unused fields.
1919 * window.h (struct window): Remove unused 'last_mark_x' and
1920 'last_mark_y' fields. Rename 'mini_p' field to 'mini',
1921 change it's type from Lisp_Object to bitfield.
1922 Change type of 'force_start', 'optional_new_start',
1923 'last_had_star', 'update_mode_line' and 'start_at_line_beg'
1924 fields from Lisp_Object to bitfield. Adjust users accordingly.
1925
ca34e0be
PE
19262012-05-31 Paul Eggert <eggert@cs.ucla.edu>
1927
1928 Pacify gcc -Wdouble-precision when using Xaw.
1929 * xterm.c (xaw_jump_callback, x_set_toolkit_scroll_bar_thumb)
1930 [HAVE_X_WINDOWS && USE_TOOLKIT_SCROLL_BARS && !USE_MOTIF && !USE_GTK]:
1931 Use 'float' consistently, rather than 'float' in most places
1932 and 'double' in a couple of places.
1933
efc00ab1 19342012-05-31 Eli Zaretskii <eliz@gnu.org>
d5fd2c54
EZ
1935
1936 * xdisp.c (handle_stop): Detect whether we have overlay strings
1937 loaded by testing it->current.overlay_string_index to be
1938 non-negative, instead of checking whether n_overlay_strings is
1939 positive. (Bug#11587)
1940
efc00ab1 19412012-05-31 Chong Yidong <cyd@gnu.org>
353c87f6
CY
1942
1943 * keymap.c (describe_map_tree): Revert 2011-07-07 change (Bug#1169).
1944
1945 * doc.c (Fsubstitute_command_keys): Doc fix.
1946
efc00ab1 19472012-05-31 Eli Zaretskii <eliz@gnu.org>
a02ae4e5
EZ
1948
1949 * search.c (search_buffer): Remove calls to
1950 r_alloc_inhibit_buffer_relocation, as it is now called by
1951 maybe_unify_char, which was the cause of relocation of buffer text
1952 in bug#11519.
1953
efc00ab1 19542012-05-31 Eli Zaretskii <eliz@gnu.org>
291d430f
EZ
1955
1956 * charset.c (maybe_unify_char): Inhibit relocation of buffer text
1957 for the duration of call to load_charset, to avoid problems with
1958 callers of maybe_unify_char that access buffer text through C
1959 pointers.
1960
1961 * ralloc.c (r_alloc_inhibit_buffer_relocation): Increment and
1962 decrement the inhibition flag, instead of just setting or
1963 resetting it.
1964
ba93a187
PE
19652012-05-31 Paul Eggert <eggert@cs.ucla.edu>
1966
1967 Remove obsolete '#define static' cruft.
1968 * s/hpux10-20.h (_FILE_OFFSET_BITS): Don't #undef.
1969 This #undef was "temporary" in 2000; it is no longer needed
1970 now that '#define static' has gone away.
1971 * xfns.c, xterm.h (gray_bitmap_width, gray_bitmap_height)
1972 (gray_bitmap_bits): Remove; no longer needed.
1973 All uses replaced with definiens.
1974 * xterm.c: Include "bitmaps/gray.xbm".
1975
9e4bf381
PE
19762012-05-30 Paul Eggert <eggert@cs.ucla.edu>
1977
1978 Clean up __executable_start, monstartup when --enable-profiling.
1979 The following changes affect the code only when profiling.
1980 * dispnew.c (__executable_start): Rename from safe_bcopy.
1981 Define only on platforms that need it.
1982 * emacs.c: Include <sys/gmon.h> when profiling.
1983 (_mcleanup): Remove decl, since <sys/gmon.h> does it now.
1984 (__executable_start): Remove decl, since lisp.h does it now.
1985 (safe_bcopy): Remove decl; no longer has that name.
1986 (main): Coalesce #if into single bit of code, for simplicity.
1987 Cast pointers to uintptr_t, since standard libraries want integers
1988 and not pointers.
1989 * lisp.h (__executable_start): New decl.
1990
32d72c2f
GM
19912012-05-31 Glenn Morris <rgm@gnu.org>
1992
1993 * image.c (Fimagemagick_types): Doc fix.
1994
baac5bc7
JM
19952012-05-30 Jim Meyering <meyering@redhat.com>
1996
1997 * callproc.c (Fcall_process_region): Include directory component
1998 in mkstemp error message (Bug#11586).
1999
72cb32cf
PE
20002012-05-30 Paul Eggert <eggert@cs.ucla.edu>
2001
2002 * alloc.c, lisp.h (make_pure_vector): Now static.
2003
61b108cc
SM
20042012-05-30 Stefan Monnier <monnier@iro.umontreal.ca>
2005
2006 * eval.c (Fdefun, Fdefmacro, Vmacro_declaration_function):
2007 Move to byte-run.el.
2008 (Fautoload): Do the hash-doc more carefully.
2009 * data.c (Fdefalias): Purify definition, except for keymaps.
2010 (Qdefun): Move from eval.c.
2011 * lisp.h (Qdefun): Remove.
2012 * lread.c (read1): Tiny simplification.
2013
471fe23d
TN
20142012-05-29 Troels Nielsen <bn.troels@gmail.com>
2015
934f3f58 2016 Do not create empty overlays with the evaporate property (Bug#9642).
471fe23d
TN
2017 * buffer.c (Fmove_overlay): Reinstate the earlier fix for
2018 Bug#9642, but explicitly check that the buffer the overlay would
2019 be moved to is live and rearrange lines to make sure that errors
2020 will not put the overlay in an inconsistent state.
2021 (Fdelete_overlay): Cosmetics.
2022
85d0efd1
EZ
20232012-05-28 Eli Zaretskii <eliz@gnu.org>
2024
2025 * w32term.c (my_bring_window_to_top): New function.
2026 (x_raise_frame): Use handle returned by DeferWindowPos, which
61b108cc
SM
2027 could be different from the original one.
2028 Call my_bring_window_to_top instead of my_set_foreground_window.
85d0efd1
EZ
2029 (Bug#11513)
2030
2031 * w32fns.c (w32_wnd_proc): Accept and process WM_EMACS_BRINGTOTOP
2032 by calling BringWindowToTop.
2033
2034 * w32term.h (WM_EMACS_BRINGTOTOP): New message.
2035 (WM_EMACS_END): Increase by one.
2036
da92a98c
PE
20372012-05-28 Paul Eggert <eggert@cs.ucla.edu>
2038
2039 * bidi.c (bidi_mirror_char): Put eassert before conversion to int.
2040 This avoids undefined behavior that might cause the eassert
2041 to not catch an out-of-range value.
2042
74d1f848
JB
20432012-05-28 Juanma Barranquero <lekktu@gmail.com>
2044
2045 * makefile.w32-in ($(BLD)/w32inevt.$(O), $(BLD)/w32console.$(O)):
2046 Update dependencies.
2047
9e1a06fc
EZ
20482012-05-27 Eli Zaretskii <eliz@gnu.org>
2049
2050 * bidi.c (bidi_mirror_char): Fix last change.
2051
f3dd7312
AS
20522012-05-27 Andreas Schwab <schwab@linux-m68k.org>
2053
2054 * unexmacosx.c (copy_data_segment): Truncate after 16 characters
2055 when referring to sectname field in printf format.
2056
81899c91
PE
20572012-05-27 Paul Eggert <eggert@cs.ucla.edu>
2058
57b81a9f
PE
2059 * lisp.h [REL_ALLOC]: Omit duplicate prototypes.
2060 Only r_alloc_inhibit_buffer_relocation needed to be added;
2061 the others were already declared.
2062
81899c91
PE
2063 * bidi.c (bidi_mirror_char): Don't possibly truncate the integer
2064 before checking whether it's out of range. Put the check inside
2065 eassert. See
2066 <http://lists.gnu.org/archive/html/emacs-devel/2012-05/msg00485.html>.
2067
33017faf 20682012-05-27 Ken Brown <kbrown@cornell.edu>
2f9b9adb
KB
2069
2070 * callproc.c (Fcall_process): Restore a line that was accidentally
2071 commented out in the 2011-02-13 change (bug#11547).
2072
33017faf 20732012-05-27 Eli Zaretskii <eliz@gnu.org>
52c55cc7
EZ
2074
2075 * lisp.h [REL_ALLOC]: Add prototypes for external functions
2076 defined on ralloc.c.
2077
2078 * buffer.c [REL_ALLOC]: Remove prototypes of
2079 r_alloc_reset_variable, r_alloc, r_re_alloc, and r_alloc_free,
2080 they are now on lisp.h.
2081
2082 * ralloc.c (r_alloc_inhibit_buffer_relocation): New function.
2083
2084 * search.c (search_buffer): Use it to inhibit relocation of buffer
2085 text while re_search_2 is doing its job, because re_search_2 is
2086 passed C pointers to buffer text. (Bug#11519)
2087
23415acf
EZ
2088 * msdos.c (internal_terminal_init) <Vwindow_system_version>:
2089 Update value to 24.
2090
44e27368
EZ
2091 * xdisp.c (move_it_to): Under MOVE_TO_Y, when restoring iterator
2092 state after an additional call to move_it_in_display_line_to, keep
2093 the values of it->max_ascent and it->max_descent found for the
2094 entire line.
2095 (pos_visible_p): Revert the comparison against bottom_y to what it
2096 was in revid eliz@gnu.org-20120513182235-4p6386j761ld0nwb.
2097 (Bug#11464)
2098
c1892f11
PE
20992012-05-26 Paul Eggert <eggert@cs.ucla.edu>
2100
2101 Fix coding-related core dumps with gcc -ftrapv.
2102 The code was computing A - B, where A and B are pointers, and B is
2103 random garbage. This can lead to core dumps on platforms that
2104 have special pointer registers, and it also leads to core dumps on
2105 x86-64 when compiled with gcc -ftrapv. The fix is to compute
2106 A - B only when B is initialized properly.
2107 * coding.c (coding_set_source, coding_set_destination): Return void.
2108 (coding_change_source, coding_change_destinations): New functions,
2109 with the old behaviors of coding_set_source and coding_set_destination.
2110 All callers that need an offset changed to use these new functions.
2111
eb7afdad
GM
21122012-05-26 Glenn Morris <rgm@gnu.org>
2113
2114 * nsterm.m (ns_init_paths): Don't mess with INFOPATH. (Bug#2791)
2115
f12fdf02
EZ
21162012-05-26 Eli Zaretskii <eliz@gnu.org>
2117
53a63be6 2118 Extend mouse support on W32 text-mode console.
61b108cc
SM
2119 * xdisp.c (draw_row_with_mouse_face):
2120 Call tty_draw_row_with_mouse_face for WINDOWSNT as well.
eb3f6f01 2121
eb3f6f01 2122 * w32console.c: Include window.h.
61b108cc
SM
2123 (w32con_write_glyphs_with_face, tty_draw_row_with_mouse_face):
2124 New functions.
eb3f6f01
EZ
2125 (initialize_w32_display): Initialize mouse-highlight data.
2126
53a63be6
EZ
2127 * w32inevt.c: Include termchar.h and window.h.
2128 (do_mouse_event): Support mouse-autoselect-window. When the mouse
2129 moves, call note_mouse_highlight. If help_echo changed, call
2130 gen_help_event to produce help-echo message in the echo area.
2131 Call clear_mouse_face if mouse_face_hidden is set in the mouse
2132 highlight info.
2133
4cfd81f6
PE
21342012-05-26 Paul Eggert <eggert@cs.ucla.edu>
2135
2136 * lread.c (read1): Simplify slightly to avoid an overflow warning
2137 with GCC 4.7.0 on x86-64.
2138
4446092a
EZ
21392012-05-26 Eli Zaretskii <eliz@gnu.org>
2140
2141 * bidi.c (bidi_mirror_char): Revert last change: an int is
2142 definitely wide enough here.
2143
42b2a986 21442012-05-25 Paul Eggert <eggert@cs.ucla.edu>
3164aeac 2145
42b2a986 2146 Fix integer width and related bugs (Bug#9874).
eb106a49 2147 * alloc.c (pure_bytes_used_lisp, pure_bytes_used_non_lisp):
d311d28c
PE
2148 (allocate_vectorlike, buffer_memory_full, struct sdata, SDATA_SIZE)
2149 (string_bytes, check_sblock, allocate_string_data):
2150 (compact_small_strings, Fmake_bool_vector, make_string)
2151 (make_unibyte_string, make_multibyte_string)
2152 (make_string_from_bytes, make_specified_string)
2153 (allocate_vectorlike, Fmake_vector, find_string_data_in_pure)
2154 (make_pure_string, make_pure_c_string, make_pure_vector, Fpurecopy)
2155 (mark_vectorlike):
2156 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2157 (allocate_pseudovector):
2158 Use int, not EMACS_INT, where int is wide enough.
2159 (inhibit_garbage_collection, Fgarbage_collect):
2160 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2161 * bidi.c (bidi_mirror_char): Use EMACS_INT, not int, where
2162 int might not be wide enough.
2163 (bidi_cache_search, bidi_cache_find, bidi_init_it)
2164 (bidi_count_bytes, bidi_char_at_pos, bidi_fetch_char)
2165 (bidi_at_paragraph_end, bidi_find_paragraph_start)
2166 (bidi_paragraph_init, bidi_resolve_explicit, bidi_resolve_weak)
2167 (bidi_level_of_next_char, bidi_move_to_visually_next):
2168 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2169 * buffer.c (copy_overlays, Fgenerate_new_buffer_name)
2170 (Fkill_buffer, Fset_buffer_major_mode)
2171 (advance_to_char_boundary, Fbuffer_swap_text)
2172 (Fset_buffer_multibyte, overlays_at, overlays_in)
2173 (overlay_touches_p, struct sortvec, record_overlay_string)
2174 (overlay_strings, recenter_overlay_lists)
2175 (adjust_overlays_for_insert, adjust_overlays_for_delete)
2176 (fix_start_end_in_overlays, fix_overlays_before, modify_overlay)
2177 (Fmove_overlay, Fnext_overlay_change, Fprevious_overlay_change)
2178 (Foverlay_recenter, last_overlay_modification_hooks_used)
2179 (report_overlay_modification, evaporate_overlays, enlarge_buffer_text):
2180 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
977b0e45
PE
2181 (validate_region): Omit unnecessary test for b <= e,
2182 since that's guaranteed by the previous test.
d311d28c
PE
2183 (adjust_overlays_for_delete): Avoid pos + length overflow.
2184 (Fmove_overlay, Fdelete_overlay, add_overlay_mod_hooklist)
2185 (report_overlay_modification):
2186 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2187 (Foverlays_at, Fnext_overlay_change, Fprevious_overlay_change):
2188 Omit pointer cast, which isn't needed anyway, and doesn't work
2189 after the EMACS_INT -> ptrdiff_t change.
02481186 2190 (Fmove_overlay): Clip BEG and END to ptrdiff_t to avoid overflow.
d311d28c
PE
2191 * buffer.h: Adjust decls to match defn changes elsewhere.
2192 (struct buffer_text, struct buffer):
2193 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2194 Use EMACS_INT, not int, where int might not be wide enough.
39b5db3b
PE
2195 * bytecode.c (unmark_byte_stack, exec_byte_code): Use ptrdiff_t,
2196 not int, to avoid needless 32-bit limit on 64-bit hosts.
2197 (exec_byte_code): Use tighter memory-full test, one that checks
2198 for alloca overflow. Don't compute the address of the object just
2199 before an array, as that's not portable. Use EMACS_INT, not
2200 ptrdiff_t or int, where ptrdiff_t or int might not be wide enough.
d311d28c
PE
2201 * callint.c (Fcall_interactively):
2202 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2203 * callproc.c (call_process_kill, Fcall_process):
2204 Don't assume pid_t fits into an Emacs fixnum.
2205 (call_process_cleanup, Fcall_process, child_setup):
2206 Don't assume pid_t fits into int.
2207 (call_process_cleanup, Fcall_process, delete_temp_file)
2208 (Fcall_process_region):
2209 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2210 (Fcall_process): Simplify handling of volatile integers.
2211 Use int, not EMACS_INT, where int will do.
2212 * casefiddle.c (casify_object, casify_region, operate_on_word)
2213 (Fupcase_word, Fdowncase_word, Fcapitalize_word):
2214 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2215 (casify_object): Avoid integer overflow when overallocating buffer.
2216 * casetab.c (set_identity, shuffle): Prefer int to unsigned when
45c2afd6 2217 either works. Use lint_assume to convince GCC 4.6.1 that it's OK.
d311d28c
PE
2218 * category.c (Fchar_category_set): Don't assume fixnum fits in int.
2219 * category.h (CATEGORYP): Don't assume arg is nonnegative.
2220 * ccl.c (GET_CCL_INT): Remove; no longer needed, since the
2221 integers are now checked earlier. All uses replaced with XINT.
2222 (ccl_driver):
2223 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2224 For CCL_MapSingle, check that content and value are in int range.
c801946a
PE
2225 (ccl_driver, Fregister_code_conversion_map):
2226 Check that Vcode_version_map_vector is a vector.
d311d28c
PE
2227 (resolve_symbol_ccl_program): Check that vector header is in range.
2228 Always copy the vector, so that we can check its contents reliably
2229 now rather than having to recheck each instruction as it's being
2230 executed. Check that vector words fit in 'int'.
2231 (ccl_get_compiled_code, Fregister_ccl_program)
2232 (Fregister_code_conversion_map): Use ptrdiff_t, not int, for
2233 program indexes, to avoid needless 32-bit limit on 64-bit hosts.
2234 (Fccl_execute, Fccl_execute_on_string): Check that initial reg
2235 contents are in range.
2236 (Fccl_execute_on_string): Check that status is in range.
2237 * ccl.h (struct ccl_program.idx): Now ptrdiff_t, not int.
2238 * character.c (char_resolve_modifier_mask, Fchar_resolve_modifiers):
2239 Accept and return EMACS_INT, not int, because callers can pass values
2240 out of 'int' range.
2241 (c_string_width, strwidth, lisp_string_width, chars_in_text)
2242 (multibyte_chars_in_text, parse_str_as_multibyte)
2243 (str_as_multibyte, count_size_as_multibyte, str_to_multibyte)
2244 (str_as_unibyte, str_to_unibyte, string_count_byte8)
2245 (string_escape_byte8, Fget_byte):
2246 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
a14e1568 2247 (Funibyte_string): Use CHECK_RANGED_INTEGER, not CHECK_NATNUM, to
d311d28c
PE
2248 avoid mishandling large integers.
2249 * character.h: Adjust decls to match defn changes elsewhere.
2250 * charset.c (load_charset_map_from_file, find_charsets_in_text)
2251 (Ffind_charset_region):
2252 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2253 (load_charset_map_from_file): Redo idx calculation to avoid overflow.
2254 (load_charset_map_from_vector, Fdefine_charset_internal):
3c7649c1 2255 Don't assume fixnum fits in int.
d311d28c
PE
2256 (load_charset_map_from_vector, Fmap_charset_chars):
2257 Remove now-unnecessary CHECK_NATNUMs.
2258 (Fdefine_charset_internal): Check ranges here, more carefully.
3c7649c1
PE
2259 Don't rely on undefined behavior with signed left shift overflow.
2260 Don't assume unsigned int fits into fixnum, or that fixnum fits
2261 into unsigned int. Don't require max_code to be a valid fixnum;
2262 that's not true for gb10830 4-byte on a 32-bit host. Allow
2263 invalid_code to be a cons, for the same reason. Require code_offset
2264 to be a character. Avoid int overflow if max_char is close
2265 to INT_MAX.
2266 (CODE_POINT_TO_INDEX): On 32-bit hosts, return int, not unsigned;
2267 this is intended anyway and avoids some undefined behavior.
2268 (load_charset_map): Pass unsigned, not int, as 2nd arg of
2269 INDEX_TO_CODE_POINT, as that's what it expects.
2270 (Funify_charset, encode_char): Don't stuff unsigned vals into int vars.
60ad3eab
PE
2271 * charset.h (DECODE_CHAR): Return int, not unsigned;
2272 this is what was intended anyway, and it avoids undefined behavior.
2273 (CHARSET_OFFSET): Remove unused macro, instead of fixing its
2274 integer-overflow issues.
2275 (ENCODE_CHAR): Return unsigned on all hosts, not just on 32-bit hosts.
2276 Formerly, it returned EMACS_INT on 64-bit hosts in the common case
2277 where the argument is EMACS_INT, and this behavior is not intended.
d311d28c
PE
2278 * chartab.c (Fmake_char_table, Fset_char_table_range)
2279 (uniprop_get_decoder, uniprop_get_encoder):
2280 Don't assume fixnum fits in int.
2281 * cmds.c (move_point): New function, that does the gist of
2282 Fforward_char and Fbackward_char, but does so while checking
2283 for integer overflow more accurately.
c96e5d6a 2284 (Fforward_char, Fbackward_char): Use it.
d311d28c
PE
2285 (Fforward_line, Fend_of_line, internal_self_insert)
2286 (internal_self_insert):
2287 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2288 Fix a FIXME, by checking for integer overflow when calculating
2289 target_clm and actual_clm.
2290 * coding.c (detect_coding_XXX, encode_coding_XXX, CODING_DECODE_CHAR)
8f50130c 2291 (CODING_ENCODE_CHAR, CODING_CHAR_CHARSET, CODING_CHAR_CHARSET_P)
d311d28c
PE
2292 (ASSURE_DESTINATION, coding_alloc_by_realloc)
2293 (coding_alloc_by_making_gap, alloc_destination)
2294 (detect_coding_utf_8, encode_coding_utf_8, decode_coding_utf_16)
2295 (encode_coding_utf_16, detect_coding_emacs_mule)
2296 (decode_coding_emacs_mule, encode_coding_emacs_mule)
2297 (detect_coding_iso_2022, decode_coding_iso_2022)
2298 (encode_invocation_designation, encode_designation_at_bol)
2299 (encode_coding_iso_2022, detect_coding_sjis, detect_coding_big5)
2300 (decode_coding_sjis, decode_coding_big5, encode_coding_sjis)
2301 (encode_coding_big5, detect_coding_ccl, decode_coding_ccl)
2302 (encode_coding_ccl, encode_coding_raw_text)
2303 (detect_coding_charset, decode_coding_charset)
2304 (encode_coding_charset, detect_eol, decode_eol, produce_chars)
2305 (produce_composition, produce_charset, produce_annotation)
2306 (decode_coding, handle_composition_annotation)
2307 (handle_charset_annotation, consume_chars, decode_coding_gap)
2308 (decode_coding_object, encode_coding_object, detect_coding_system)
2309 (Ffind_coding_systems_region_internal, Fcheck_coding_systems_region)
2310 (code_convert_region, code_convert_string)
8f50130c
PE
2311 (Fdefine_coding_system_internal)
2312 (coding_set_source, coding_set_destination):
d311d28c
PE
2313 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2314 (setup_iso_safe_charsets, consume_chars, Funencodable_char_position)
2315 (Fdefine_coding_system_internal):
2316 Don't assume fixnums fit in int.
2317 (decode_coding_gap, decode_coding_object, encode_coding_object)
5895d7b9 2318 (Fread_coding_system, Fdetect_coding_region)
2c6a9faa
PE
2319 (Funencodable_char_position, Fcheck_coding_systems_region)
2320 (get_translation, handle_composition_annotation, consume_chars):
d311d28c 2321 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
977b0e45 2322 (consume_chars): Rewrite to not calculate an address outside buffer.
d311d28c 2323 (Ffind_operation_coding_system): NATNUMP can eval its arg twice.
7b09a37a 2324 Don't access memory outside of the args array.
d311d28c 2325 (Fdefine_coding_system_internal): Check for charset-id overflow.
47664caa
PE
2326 (ENCODE_ISO_CHARACTER): Use unsigned, not int, to store the unsigned
2327 result of ENCODE_CHAR.
d311d28c
PE
2328 * coding.h: Adjust decls to match defn changes elsewhere.
2329 (struct coding_system):
2330 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2331 * composite.c (get_composition_id, find_composition)
2332 (run_composition_function, update_compositions)
2333 (compose_text, composition_gstring_put_cache)
2334 (composition_gstring_p, composition_gstring_width)
2335 (fill_gstring_header, fill_gstring_body, autocmp_chars)
2336 (composition_compute_stop_pos, composition_reseat_it)
2337 (composition_update_it, struct position_record)
2338 (find_automatic_composition, composition_adjust_point)
2339 (Fcomposition_get_gstring, Ffind_composition_internal):
2340 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2341 (update_compositions):
2342 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2343 * composite.h: Adjust decls to match defn changes elsewhere.
2344 (struct composition):
2345 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2346 * data.c (let_shadows_buffer_binding_p, let_shadows_global_binding_p):
2347 Do not attempt to compute the address of the object just before a
2348 buffer; this is not portable.
2349 (Faref, Faset):
2350 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2351 (Faset): Use int, not EMACS_INT, where int is wide enough.
2352 (Fstring_to_number): Don't assume fixnums fit in int.
2353 (Frem): Don't assume arg is nonnegative.
2354 * dbusbind.c (xd_append_arg): Check for integers out of range.
2355 (Fdbus_call_method): Don't overflow the timeout int.
42b2a986 2356 (extract_signed, extract_unsigned): New functions.
243e0530
PE
2357 (XD_CHECK_DBUS_SERIAL): Remove; superseded by extract_unsigned.
2358 (xd_get_connection_references): Return ptrdiff_t, not int.
2359 All uses changed.
2360 (xd_signature, xd_append_arg, xd_retrieve_arg, Fdbus_message_internal)
2361 (xd_read_message_1):
2362 Use int, not unsigned, where the dbus API uses int.
2363 (Fdbus_message_internal): Don't overflow mtype.
2364 (syms_of_dbusbind): Allocate right-sized buffer for integers.
d311d28c
PE
2365 * dired.c (directory_files_internal, file_name_completion, scmp)
2366 (file_name_completion_stat):
2367 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2368 (file_name_completion): Don't overflow matchcount.
2369 (file_name_completion_stat): Use SAFE_ALLOCA, not alloca.
2370 * dispextern.h: Adjust decls to match defn changes elsewhere.
2371 (struct text_pos, struct glyph, struct bidi_saved_info)
2372 (struct bidi_string_data, struct bidi_it, struct composition_it)
2373 (struct it):
2374 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2375 (struct display_pos, struct composition_it, struct it):
2376 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2377 * dispnew.c (increment_matrix_positions)
2378 (increment_row_positions, mode_line_string)
2379 (marginal_area_string):
2380 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
54e1617f 2381 (change_frame_size_1, Fredisplay, Fframe_or_buffer_changed_p):
d311d28c
PE
2382 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2383 (duration_to_sec_usec): New function, to check for overflow better.
2384 (Fsleep_for, sit_for): Use it.
2385 * doc.c (get_doc_string, store_function_docstring):
2386 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2387 (get_doc_string, Fsnarf_documentation):
2388 Use int, not EMACS_INT, where int is wide enough.
2389 (get_doc_string):
2390 Use SAFE_ALLOCA, not alloca.
2391 Check for overflow when converting EMACS_INT to off_t.
2392 * doprnt.c (doprnt):
2393 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2394 * editfns.c (init_editfns, Fuser_uid, Fuser_real_uid):
2395 Don't assume uid_t fits into fixnum.
2396 (buildmark, Fgoto_char, overlays_around, find_field, Fdelete_field)
2397 (Ffield_string, Ffield_string_no_properties, Ffield_beginning)
2398 (Ffield_end, Fconstrain_to_field, Fline_beginning_position)
2399 (Fline_end_position, Fprevious_char, Fchar_after, Fchar_before)
2400 (general_insert_function)
2401 (Finsert_char, make_buffer_string, make_buffer_string_both)
2402 (update_buffer_properties, Fbuffer_substring)
2403 (Fbuffer_substring_no_properties, Fcompare_buffer_substrings)
2404 (Fsubst_char_in_region, check_translation)
2405 (Ftranslate_region_internal, save_restriction_restore, Fformat)
2406 (transpose_markers, Ftranspose_regions):
2407 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2408 (clip_to_bounds): Move to lisp.h as an inline function).
2409 (Fconstrain_to_field): Don't assume integers are nonnegative.
2410 (Fline_beginning_position, Fsave_excursion, Fsave_current_buffer):
2411 (Fsubst_char_in_region, Fsave_restriction):
2412 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2413 (Femacs_pid): Don't assume pid_t fits into fixnum.
2414 (lo_time): Use int, not EMACS_INT, when int suffices.
2415 (lisp_time_argument): Check for usec out of range.
2416 (Fencode_time): Don't assume fixnum fits in int.
3f4eabd1
PE
2417 (Fuser_login_name, Fuser_full_name): Signal an error
2418 if a uid argument is out of range, rather than relying on
2419 undefined behavior.
c8d5c857
PE
2420 (Fformat_time_string): Remove now-unnecessary check.
2421 lisp_time_argument checks for out-of-range usec now.
243e0530 2422 Use ptrdiff_t, not size_t, where ptrdiff_t will do.
d311d28c
PE
2423 * emacs.c (gdb_valbits, gdb_gctypebits): Now int, not EMACS_INT.
2424 (gdb_data_seg_bits): Now uintptr_t, not EMACS_INT.
2425 (PVEC_FLAG, gdb_array_mark_flag): Now ptrdiff_t, not EMACS_INT.
2426 (init_cmdargs, Fdump_emacs):
2427 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2428 (Fkill_emacs): Don't assume fixnum fits in int; instead, take just
2429 the bottom (typically) 32 bits of the fixnum.
2430 * eval.c (specpdl_size, call_debugger):
2431 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2432 (when_entered_debugger, Fbacktrace_debug):
2433 Don't assume fixnum can fit in int.
2434 (Fdefvaralias, Fdefvar): Do not attempt to compute the address of
2435 the object just before a buffer; this is not portable.
2436 (FletX, Flet, Funwind_protect, do_autoload, Feval, funcall_lambda)
2437 (grow_specpdl, unbind_to):
2438 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2439 (Fapply, apply_lambda): Don't assume ptrdiff_t can hold fixnum.
2440 (grow_specpdl): Simplify allocation by using xpalloc.
856bbc81 2441 (Fprog1, Fprog2): Don't assume list length fits in int. Simplify.
d311d28c
PE
2442 * fileio.c (Ffind_file_name_handler, Fcopy_file, Frename_file)
2443 (Finsert_file_contents, Fwrite_region, Fdo_auto_save):
2444 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2445 (Ffind_file_name_handler, non_regular_inserted, Finsert_file_contents)
2446 (a_write, e_write):
2447 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2448 (Fcopy_file, non_regular_nbytes, read_non_regular)
2449 (Finsert_file_contents):
2450 Use int, not EMACS_INT, where int is wide enough.
2451 (READ_BUF_SIZE): Verify that it fits in int.
2452 (Finsert_file_contents): Check that counts are in proper range,
2453 rather than assuming fixnums fit into ptrdiff_t etc.
2454 Don't assume fixnums fit into int.
125b3835 2455 * floatfns.c (Fexpt): Avoid undefined signed * signed overflow.
5895d7b9
PE
2456 * fns.c (Fcompare_strings, Fstring_lessp, struct textprop_rec, concat)
2457 (string_char_byte_cache_charpos, string_char_byte_cache_bytepos)
d311d28c
PE
2458 (string_char_to_byte, string_byte_to_char)
2459 (string_make_multibyte, string_to_multibyte)
2460 (string_make_unibyte, Fstring_as_unibyte, Fstring_as_multibyte)
2461 (Fstring_to_unibyte, Fsubstring, Fsubstring_no_properties)
2462 (substring_both, Fdelete, internal_equal, Ffillarray)
2463 (Fclear_string, mapcar1)
2464 (Fbase64_encode_region, Fbase64_encode_string, base64_encode_1)
2465 (Fbase64_decode_region, Fbase64_decode_string, base64_decode_1)
2466 (larger_vector, make_hash_table, maybe_resize_hash_table)
2467 (hash_lookup, hash_remove_from_table, hash_clear, sweep_weak_table)
2468 (Fmaphash, secure_hash):
2469 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2470 (concat): Check for string index and length overflow.
2471 (Fmapconcat): Don't assume fixnums fit into ptrdiff_t.
2472 (Frequire):
2473 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2474 (larger_vector): New API (vec, incr_min, size_max) replaces old
2475 one (vec, new_size, init). This catches size overflow.
2476 INIT was removed because it was always Qnil.
2477 All callers changed.
2478 (INDEX_SIZE_BOUND): New macro, which calculates more precisely
2479 the upper bound on a hash table index size.
2480 (make_hash_table, maybe_resize_hash_table): Use it.
2481 (secure_hash): Computer start_byte and end_byte only after
2482 they're known to be in ptrdiff_t range.
2483 * font.c (font_intern_prop, font_at, font_range, Ffont_shape_gstring)
2484 (Ffont_get_glyphs, Ffont_at):
2485 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2486 (font_style_to_value, font_prop_validate_style, font_expand_wildcards)
2487 (Flist_fonts, Fopen_font):
2488 Don't assume fixnum can fit in int.
2489 (check_gstring): Don't assume index can fit in int.
2490 (font_match_p): Check that fixnum is a character, not a nonnegative
2491 fixnum, since the later code needs to stuff it into an int.
2492 (font_find_for_lface): Use SAFE_ALLOCA_LISP, not alloca.
2493 (font_fill_lglyph_metrics): Use unsigned, not EMACS_INT, to avoid
2494 conversion overflow issues.
2495 (Fopen_font): Check for integer out of range.
2496 (Ffont_get_glyphs): Don't assume index can fit in int.
2497 * font.h: Adjust decls to match defn changes elsewhere.
2498 * fontset.c (reorder_font_vector): Redo score calculation to avoid
2499 integer overflow.
2500 (num_auto_fontsets, fontset_from_font): Use ptrdiff_t, not
2501 printmax_t, where ptrdiff_t is wide enough.
2502 (Finternal_char_font):
2503 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2504 * frame.c (Fset_mouse_position, Fset_mouse_pixel_position)
2505 (Fset_frame_height, Fset_frame_width, Fset_frame_size)
2506 (Fset_frame_position, x_set_frame_parameters)
2507 (x_set_line_spacing, x_set_border_width)
2508 (x_set_internal_border_width, x_set_alpha, x_figure_window_size):
2509 Check that fixnums are in proper range for system types.
2510 (frame_name_fnn_p, Fframe_parameter, Fmodify_frame_parameters):
2511 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2512 (Fmodify_frame_parameters): Don't assume fixnum fits in int.
2513 Use SAFE_ALLOCA_LISP, not alloca.
2514 * frame.h (struct frame): Use intptr_t, not EMACS_INT, where
2515 intptr_t is wide enough.
2516 * fringe.c (lookup_fringe_bitmap, get_logical_fringe_bitmap)
2517 (Fdefine_fringe_bitmap): Don't assume fixnum fits in int.
2518 (Ffringe_bitmaps_at_pos): Don't assume index fits in int.
2519 Check for fixnum out of range.
2520 * ftfont.c (ftfont_list): Don't assume index fits in int.
2521 Check that fixnums are in proper range for system types.
2522 (ftfont_shape_by_flt):
2523 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
d311d28c
PE
2524 * gnutls.c (emacs_gnutls_write, emacs_gnutls_read):
2525 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2526 (Fgnutls_error_fatalp, Fgnutls_error_string, Fgnutls_boot):
2527 Check that fixnums are in proper range for system types.
2528 * gnutls.h: Adjust decls to match defn changes elsewhere.
2529 * gtkutil.c (xg_dialog_run):
2530 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2531 (update_frame_tool_bar):
2532 Check that fixnums are in proper range for system types.
2533 * image.c (parse_image_spec): Redo count calculation to avoid overflow.
5895d7b9 2534 (lookup_image): Check that fixnums are in range for system types.
d311d28c
PE
2535 * indent.c (last_known_column, last_known_column_point):
2536 (current_column_bol_cache):
2537 (skip_invisible, current_column, check_display_width):
2538 (check_display_width, scan_for_column, current_column_1)
2539 (Findent_to, Fcurrent_indentation, position_indentation)
2540 (indented_beyond_p, Fmove_to_column, compute_motion):
2541 (Fcompute_motion, Fvertical_motion):
2542 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2543 (last_known_column_modified): Use EMACS_INT, not int.
2544 (check_display_width):
2545 (Fcompute_motion):
2546 Check that fixnums and floats are in proper range for system types.
2547 (compute_motion): Don't assume index or fixnum fits in int.
2548 (compute_motion, Fcompute_motion):
2549 Use int, not EMACS_INT, when it is wide enough.
2550 (vmotion): Omit local var start_hpos that is always 0; that way
2551 we don't need to worry about overflow in expressions involving it.
2552 * indent.h: Adjust decls to match defn changes elsewhere.
2553 (struct position):
2554 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2555 Use int, not EMACS_INT, where int is wide enough.
2556 Remove unused members ovstring_chars_done and tab_offset;
2557 all uses removed.
2558 * insdel.c (move_gap, move_gap_both, gap_left, gap_right)
2559 (adjust_markers_for_delete, adjust_markers_for_insert, adjust_point)
2560 (adjust_markers_for_replace, make_gap_larger, make_gap_smaller)
2561 (make_gap, copy_text, insert, insert_and_inherit)
2562 (insert_before_markers, insert_before_markers_and_inherit)
2563 (insert_1, count_combining_before, count_combining_after)
2564 (insert_1_both, insert_from_string)
2565 (insert_from_string_before_markers, insert_from_string_1)
2566 (insert_from_gap, insert_from_buffer, insert_from_buffer_1)
2567 (adjust_after_replace, adjust_after_insert, replace_range)
2568 (replace_range_2, del_range, del_range_1, del_range_byte)
2569 (del_range_both, del_range_2, modify_region)
2570 (prepare_to_modify_buffer, signal_before_change)
2571 (signal_after_change, Fcombine_after_change_execute):
2572 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2573 * intervals.c (traverse_intervals, rotate_right, rotate_left)
2574 (balance_an_interval, split_interval_right, split_interval_left)
2575 (find_interval, next_interval, update_interval)
2576 (adjust_intervals_for_insertion, delete_node, delete_interval)
2577 (interval_deletion_adjustment, adjust_intervals_for_deletion)
2578 (static_offset_intervals, offset_intervals)
2579 (merge_interval_right, merge_interval_left, make_new_interval)
2580 (graft_intervals_into_buffer, temp_set_point_both)
2581 (temp_set_point, set_point, adjust_for_invis_intang)
2582 (set_point_both, move_if_not_intangible, get_property_and_range)
2583 (get_local_map, copy_intervals, copy_intervals_to_string)
2584 (compare_string_intervals, set_intervals_multibyte_1):
2585 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2586 * intervals.h: Adjust decls to match defn changes elsewhere.
2587 (struct interval):
2588 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2589 * keyboard.c (this_command_key_count, this_single_command_key_start)
2590 (before_command_key_count, before_command_echo_length, echo_now)
2591 (echo_length, recursive_edit_1, Frecursive_edit, Ftrack_mouse)
2592 (command_loop_1, safe_run_hooks, read_char, timer_check_2)
2593 (menu_item_eval_property, read_key_sequence, Fread_key_sequence)
2594 (Fread_key_sequence_vector, Fexecute_extended_command, Fsuspend_emacs):
2595 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2596 (last_non_minibuf_size, last_point_position, echo_truncate)
2597 (command_loop_1, adjust_point_for_property, read_char, gen_help_event)
2598 (make_lispy_position, make_lispy_event, parse_modifiers_uncached)
2599 (parse_modifiers, modify_event_symbol, Fexecute_extended_command)
2600 (stuff_buffered_input):
2601 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2602 (last_auto_save, command_loop_1, read_char):
2603 Use EMACS_INT, not int, to avoid integer overflow.
2604 (record_char): Avoid overflow in total_keys computation.
2605 (parse_modifiers_uncached): Redo index calculation to avoid overflow.
2606 * keyboard.h: Adjust decls to match defn changes elsewhere.
2607 * keymap.c (Fdefine_key, Fcurrent_active_maps, accessible_keymaps_1)
2608 (Fkey_description, Fdescribe_vector, Flookup_key):
2609 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2610 (click_position): New function, to check that positions are in range.
2611 (Fcurrent_active_maps):
2612 (describe_command):
2613 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2614 (Faccessible_keymaps, Fkey_description):
2615 (preferred_sequence_p):
2616 Don't assume fixnum can fit into int.
2617 (Fkey_description): Use SAFE_ALLOCA_LISP, not alloca.
2618 Check for integer overflow in size calculations.
2619 (Ftext_char_description): Use CHECK_CHARACTER, not CHECK_NUMBER, to
2620 avoid mishandling large integers.
2621 * lisp.h: Adjust decls to match defn changes elsewhere.
2622 (ARRAY_MARK_FLAG, PSEUDOVECTOR_FLAG, struct Lisp_String)
2623 (struct vectorlike_header, struct Lisp_Subr, struct Lisp_Hash_Table)
2624 (struct Lisp_Marker):
2625 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2626 (clip_to_bounds): Now an inline function, moved here from editfns.c.
d311d28c
PE
2627 (GLYPH_CODE_P): Check for overflow in system types, subsuming the
2628 need for GLYPH_CODE_CHAR_VALID_P and doing proper checking ourselves.
2629 All callers changed.
2630 (GLYPH_CODE_CHAR, GLYPH_CODE_FACE):
2631 Assume the arg has valid form, since it always does.
2632 (TYPE_RANGED_INTEGERP): Avoid bug when checking against a wide
2633 unsigned integer system type.
2634 (CHECK_RANGED_INTEGER, CHECK_TYPE_RANGED_INTEGER): New macros.
2635 (struct catchtag, specpdl_size, SPECPDL_INDEX, USE_SAFE_ALLOCA):
2636 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2637 (struct catchtag): Use EMACS_INT, not int, since it may be a fixnum.
2638 (duration_to_sec_usec): New decl.
2639 * lread.c (read_from_string_index, read_from_string_index_byte)
2640 (read_from_string_limit, readchar, unreadchar, openp)
2641 (read_internal_start, read1, oblookup):
2642 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2643 (Fload, readevalloop, Feval_buffer, Feval_region):
2644 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2645 (openp): Check for out-of-range argument to 'access'.
2646 (read1): Use int, not EMACS_INT, where int is wide enough.
2647 Don't assume fixnum fits into int.
6efdadfd 2648 Fix off-by-one error that can read outside a buffer.
1ab7b8ac
PE
2649 (read_filtered_event): Use duration_to_sec_usec
2650 to do proper overflow checking on durations.
d311d28c
PE
2651 * macros.c (Fstart_kbd_macro): Use xpalloc to check for overflow
2652 in size calculation.
2653 (Fexecute_kbd_macro):
2654 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2655 * marker.c (cached_charpos, cached_bytepos, CONSIDER)
2656 (byte_char_debug_check, buf_charpos_to_bytepos, verify_bytepos)
2657 (buf_bytepos_to_charpos, Fset_marker, set_marker_restricted)
2658 (set_marker_both, set_marker_restricted_both, marker_position)
2659 (marker_byte_position, Fbuffer_has_markers_at):
2660 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2661 (Fset_marker, set_marker_restricted): Don't assume fixnum fits in int.
61b108cc 2662 * menu.c (ensure_menu_items): Rename from grow_menu_items.
d311d28c
PE
2663 It now merely ensures that the menu is large enough, without
2664 necessarily growing it, as this avoids some integer overflow issues.
2665 All callers changed.
2666 (keymap_panes, parse_single_submenu, Fx_popup_menu):
2667 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2668 (parse_single_submenu, Fx_popup_menu): Don't assume fixnum fits in int.
2669 Use SAFE_ALLOCA_LISP, not alloca.
2670 (find_and_return_menu_selection): Avoid unnecessary casts of pointers
2671 to EMACS_INT. Check that fixnums are in proper range for system types.
2672 * minibuf.c (minibuf_prompt_width, string_to_object)
2673 (Fminibuffer_contents, Fminibuffer_contents_no_properties)
2674 (Fminibuffer_completion_contents, Ftry_completion, Fall_completions):
2675 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2676 (get_minibuffer, read_minibuf_unwind):
2677 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2678 (read_minibuf): Omit unnecessary arg BACKUP_N, which is always nil;
2679 this simplifies overflow checking. All callers changed.
2680 (read_minibuf, Fread_buffer, Ftry_completion, Fall_completions)
2681 (Ftest_completion):
2682 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2683 * nsfns.m (check_ns_display_info): Don't assume fixnum fits in long.
2684 (x_set_menu_bar_lines, x_set_tool_bar_lines, Fx_create_frame):
2685 Check that fixnums are in proper range for system types.
2686 (Fx_create_frame, Fx_show_tip):
2687 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2688 * nsfont.m (ns_findfonts, nsfont_list_family):
2689 Don't assume fixnum fits in long.
2690 * nsmenu.m (ns_update_menubar, ns_menu_show, ns_popup_dialog):
2691 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2692 (ns_update_menubar): Use intptr_t, not EMACS_INT, when intptr_t is
2693 wide enough.
17fdb222 2694 * nsselect.m (ns_get_local_selection, clean_local_selection_data):
d311d28c
PE
2695 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2696 * print.c (print_buffer_size, print_buffer_pos, print_buffer_pos_byte)
2697 (PRINTDECLARE, PRINTPREPARE):
2698 (strout, print_string):
2699 (print, print_preprocess, print_check_string_charset_prop)
2700 (print_object):
2701 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2702 (PRINTDECLARE):
2703 (temp_output_buffer_setup, Fprin1_to_string, print_object):
2704 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2705 (PRINTPREPARE): Use int, not ptrdiff_t, where int is wide enough.
d311d28c 2706 (printchar, strout): Use xpalloc to catch size calculation overflow.
0fd11aa5 2707 (Fexternal_debugging_output): Don't overflow EMACS_INT->int conversion.
d311d28c
PE
2708 (print_error_message): Use SAFE_ALLOCA, not alloca.
2709 (print_object): Use int, not EMACS_INT, where int is wide enough.
a8b7caa3
PE
2710 (print_depth, new_backquote_output, print_number_index):
2711 Use ptrdiff_t, not int, where int might not be wide enough.
d311d28c
PE
2712 * process.c (Fdelete_process): Don't assume pid fits into EMACS_INT.
2713 (Fset_process_window_size, Fformat_network_address)
2714 (get_lisp_to_sockaddr_size, set_socket_option, Fmake_network_process)
d44287d4 2715 (sigchld_handler):
d311d28c 2716 Check that fixnums are in proper range for system types.
d44287d4 2717 (Fsignal_process): Simplify by avoiding a goto.
d83cf4cc
PE
2718 Check for process-ids out of pid_t range rather than relying on
2719 undefined behavior.
e4d81efc 2720 (process_tick, update_tick): Use EMACS_INT, not int.
d311d28c
PE
2721 (Fformat_network_address, read_process_output, send_process)
2722 (Fprocess_send_region, status_notify):
2723 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2724 (Fformat_network_address, Fmake_serial_process, Fmake_network_process)
2725 (wait_reading_process_output, read_process_output, exec_sentinel):
2726 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2727 (conv_lisp_to_sockaddr): Don't assume fixnums fit into int.
2728 (Faccept_process_output): Use duration_to_sec_usec to do proper
2729 overflow checking on durations.
dde14581
PE
2730 (emacs_get_tty_pgrp, Fprocess_running_child_p, process_send_signal):
2731 Don't assume pid_t fits in int.
02481186
PE
2732 * process.h (struct Lisp_Process): Members tick and update_tick
2733 are now of type EMACS_INT, not int.
b62b53e8
PE
2734 * puresize.h (PURESIZE_RATIO): Shrink this to 8/6 on 32-bit hosts
2735 configured --with-wide-int.
d311d28c
PE
2736 * scroll.c (calculate_scrolling, calculate_direct_scrolling)
2737 (line_ins_del): Use int, not EMACS_INT, where int is wide enough.
2738 * search.c (looking_at_1, string_match_1):
2739 (fast_string_match, fast_c_string_match_ignore_case)
2740 (fast_string_match_ignore_case, fast_looking_at, scan_buffer)
2741 (scan_newline, find_before_next_newline, search_command)
2742 (trivial_regexp_p, search_buffer, simple_search, boyer_moore)
2743 (set_search_regs, wordify):
2744 (Freplace_match):
2745 (Fmatch_data):
2746 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2747 (string_match_1, search_buffer, set_search_regs):
2748 (Fmatch_data):
2749 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2750 (wordify): Check for overflow in size calculation.
2751 (Freplace_match): Avoid potential buffer overflow in search_regs.start.
2752 (Fset_match_data): Don't assume fixnum fits in ptrdiff_t.
2753 Check that fixnums are in proper range for system types.
2754 * sound.c (struct sound_device)
2755 (wav_play, au_play, vox_write, alsa_period_size, alsa_write):
2756 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2757 (Fplay_sound_internal):
2758 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
eacd378d 2759 * syntax.c (struct lisp_parse_state, find_start_modiff)
d311d28c
PE
2760 (Finternal_describe_syntax_value, scan_lists, scan_sexps_forward):
2761 (Fparse_partial_sexp):
2762 Don't assume fixnums can fit in int.
2763 (struct lisp_parse_state, find_start_pos, find_start_value)
2764 (find_start_value_byte, find_start_begv)
2765 (update_syntax_table, char_quoted, dec_bytepos)
2766 (find_defun_start, prev_char_comend_first, back_comment):
2767 (scan_words, skip_chars, skip_syntaxes, forw_comment, Fforward_comment)
2768 (scan_lists, Fbackward_prefix_chars, scan_sexps_forward):
2769 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2770 (Finternal_describe_syntax_value): Check that match_lisp is a
2771 character, not an integer, since the code stuffs it into int.
2772 (scan_words, scan_sexps_forward):
2773 Check that fixnums are in proper range for system types.
2774 (Fforward_word):
2775 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2776 (scan_sexps_forward):
2777 Use CHARACTERP, not INTEGERP, since the value must fit into int.
2778 (Fparse_partial_sexp): Fix doc; element 8 is not ignored.
2779 * syntax.h: Adjust decls to match defn changes elsewhere.
2780 (struct gl_state_s):
2781 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
e4ecdc9c
PE
2782 (SETUP_SYNTAX_TABLE_FOR_OBJECT): Use PTRDIFF_MAX, not
2783 MOST_POSITIVE_FIXNUM.
d311d28c
PE
2784 * sysdep.c (wait_for_termination_1, wait_for_termination)
2785 (interruptible_wait_for_termination, mkdir):
2786 Don't assume pid_t fits in int; on 64-bit AIX pid_t is 64-bit.
2787 (emacs_read, emacs_write):
2788 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
225a2cff
PE
2789 (system_process_attributes): Don't assume uid_t, gid_t, EMACS_INT,
2790 and double all fit in int.
d311d28c
PE
2791 * term.c (set_tty_color_mode):
2792 Check that fixnums are in proper range for system types.
2793 * termhooks.h (struct input_event):
2794 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2795 * textprop.c (validate_interval_range, interval_of)
2796 (Fadd_text_properties, set_text_properties_1)
2797 (Fremove_text_properties, Fremove_list_of_text_properties)
2798 (Ftext_property_any, Ftext_property_not_all)
2799 (copy_text_properties, text_property_list, extend_property_ranges)
2800 (verify_interval_modification):
2801 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2802 (Fnext_single_char_property_change)
2803 (Fprevious_single_char_property_change):
2804 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
5895d7b9
PE
2805 (copy_text_properties):
2806 Check for integer overflow in index calculation.
d311d28c
PE
2807 * undo.c (last_boundary_position, record_point, record_insert)
2808 (record_delete, record_marker_adjustment, record_change)
2809 (record_property_change):
2810 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2811 (truncate_undo_list, Fprimitive_undo): Don't assume fixnum fits in int.
2812 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2813 * w32fns.c (Fx_create_frame, x_create_tip_frame, Fx_show_tip)
2814 (Fx_hide_tip, Fx_file_dialog):
2815 * w32menu.c (set_frame_menubar):
2816 Use ptrdiff_t, not int, for consistency with rest of code.
2817 * window.c (window_scroll_preserve_hpos, window_scroll_preserve_vpos)
2818 (select_window, Fdelete_other_windows_internal)
2819 (window_scroll_pixel_based, window_scroll_line_based)
2820 (Frecenter, Fset_window_configuration):
2821 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2822 (Fset_window_hscroll, run_window_configuration_change_hook)
2823 (set_window_buffer, temp_output_buffer_show, scroll_command)
5895d7b9 2824 (Fscroll_other_window, Frecenter):
d311d28c
PE
2825 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2826 (Fwindow_line_height, window_scroll, Fscroll_left, Fscroll_right):
2827 Don't assume fixnum fits in int.
2828 (Fset_window_scroll_bars):
2829 Check that fixnums are in proper range for system types.
2830 * xdisp.c (help_echo_pos, pos_visible_p, string_pos_nchars_ahead)
2831 (string_pos, c_string_pos, number_of_chars, init_iterator)
2832 (in_ellipses_for_invisible_text_p, init_from_display_pos)
2833 (compute_stop_pos, next_overlay_change, compute_display_string_pos)
2834 (compute_display_string_end, handle_face_prop)
5895d7b9
PE
2835 (face_before_or_after_it_pos, handle_invisible_prop)
2836 (handle_display_prop, handle_display_spec, handle_single_display_spec)
d311d28c
PE
2837 (display_prop_intangible_p, string_buffer_position_lim)
2838 (string_buffer_position, handle_composition_prop, load_overlay_strings)
2839 (get_overlay_strings_1, get_overlay_strings)
2840 (iterate_out_of_display_property, forward_to_next_line_start)
2841 (back_to_previous_visible_line_start, reseat, reseat_to_string)
2842 (get_next_display_element, set_iterator_to_next)
2843 (get_visually_first_element, compute_stop_pos_backwards)
2844 (handle_stop_backwards, next_element_from_buffer)
2845 (move_it_in_display_line_to, move_it_in_display_line)
2846 (move_it_to, move_it_vertically_backward, move_it_by_lines)
2847 (add_to_log, message_dolog, message_log_check_duplicate)
2848 (message2, message2_nolog, message3, message3_nolog
2849 (with_echo_area_buffer, display_echo_area_1, resize_mini_window_1)
2850 (current_message_1, truncate_echo_area, truncate_message_1)
2851 (set_message, set_message_1, store_mode_line_noprop)
2852 (hscroll_window_tree, debug_delta, debug_delta_bytes, debug_end_vpos)
2853 (text_outside_line_unchanged_p, check_point_in_composition)
2854 (reconsider_clip_changes)
2855 (redisplay_internal, set_cursor_from_row, try_scrolling)
2856 (try_cursor_movement, set_vertical_scroll_bar, redisplay_window)
2857 (redisplay_window, find_last_unchanged_at_beg_row)
2858 (find_first_unchanged_at_end_row, row_containing_pos, try_window_id)
2859 (trailing_whitespace_p, find_row_edges, display_line)
2860 (RECORD_MAX_MIN_POS, Fcurrent_bidi_paragraph_direction)
2861 (display_mode_element, store_mode_line_string)
2862 (pint2str, pint2hrstr, decode_mode_spec)
2863 (display_count_lines, display_string, draw_glyphs)
2864 (x_produce_glyphs, x_insert_glyphs)
2865 (rows_from_pos_range, mouse_face_from_buffer_pos)
2866 (fast_find_string_pos, mouse_face_from_string_pos)
2867 (note_mode_line_or_margin_highlight, note_mouse_highlight):
2868 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2869 (safe_call, init_from_display_pos, handle_fontified_prop)
2870 (handle_single_display_spec, load_overlay_strings)
2871 (with_echo_area_buffer, setup_echo_area_for_printing)
2872 (display_echo_area, echo_area_display)
2873 (x_consider_frame_title, prepare_menu_bars, update_menu_bar)
2874 (update_tool_bar, hscroll_window_tree, redisplay_internal)
5895d7b9
PE
2875 (redisplay_window, dump_glyph_row, display_mode_line)
2876 (Fformat_mode_line, decode_mode_spec, on_hot_spot_p):
43ad2e9a 2877 (handle_display_spec, display_prop_string_p):
d311d28c
PE
2878 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2879 (handle_single_display_spec, build_desired_tool_bar_string)
2880 (redisplay_tool_bar, scroll_window_tree, Fdump_glyph_matrix)
2881 (get_specified_cursor_type):
2882 Check that fixnums are in proper range for system types.
2883 (struct overlay_entry, resize_mini_window, Fdump_glyph_row)
2884 (Flookup_image_map):
2885 Don't assume fixnums fit in int.
2886 (compare_overlay_entries):
2887 Avoid mishandling comparisons due to subtraction overflow.
2888 (load_overlay_strings): Use SAFE_NALLOCA, not alloca.
2889 (last_escape_glyph_face_id, last_glyphless_glyph_face_id):
2890 (handle_tool_bar_click):
2891 Use int, not unsigned, since we prefer signed and the signedness
2892 doesn't matter here.
2893 (get_next_display_element, next_element_from_display_vector):
2894 Use int, not EMACS_INT, when int is wide enough.
2895 (start_hourglass): Use duration_to_sec_usec to do proper
2896 overflow checking on durations.
2897 * xfaces.c (Fbitmap_spec_p):
2898 Check that fixnums are in proper range for system types.
2899 (compare_fonts_by_sort_order):
2900 Avoid mishandling comparisons due to subtraction overflow.
2901 (Fx_family_fonts, realize_basic_faces):
2902 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2903 (Fx_family_fonts):
2904 Don't assume fixnum fits in int.
2905 Use SAFE_ALLOCA_LISP, not alloca.
2906 (merge_face_heights): Remove unnecessary cast to EMACS_INT.
2907 (Finternal_make_lisp_face): Don't allocate more than MAX_FACE_ID.
2908 (face_at_buffer_position, face_for_overlay_string)
2909 (face_at_string_position):
2910 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2911 (merge_faces): Use int, not EMACS_INT, where int is wide enough.
2912 * xfns.c (x_set_menu_bar_lines, x_set_tool_bar_lines, x_icon_verify)
2913 (Fx_show_tip):
2914 Check that fixnums are in proper range for system types.
2915 (Fx_create_frame, x_create_tip_frame, Fx_show_tip)
2916 (Fx_hide_tip, Fx_file_dialog, Fx_select_font):
2917 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2918 (Fx_change_window_property): Don't assume fixnums fit in int.
2919 * xfont.c (xfont_chars_supported):
2920 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2921 * xmenu.c (Fx_popup_dialog, set_frame_menubar)
2922 (create_and_show_popup_menu, create_and_show_dialog, xmenu_show):
2923 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2924 * xml.c (parse_region):
2925 * xrdb.c (magic_file_p):
2926 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2927 * xselect.c (TRACE1): Don't assume pid_t promotes to int.
2928 (x_get_local_selection, x_reply_selection_request)
2929 (x_handle_selection_request, wait_for_property_change):
2930 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2931 (selection_data_to_lisp_data): Use short, not EMACS_INT, where
2932 short is wide enough.
2933 (x_send_client_event): Don't assume fixnum fits in int.
2934 * xterm.c (x_x_to_emacs_modifiers):
2935 Don't assume EMACS_INT overflows nicely into int.
2936 (x_emacs_to_x_modifiers): Use EMACS_INT, not int, because values
2937 may come from Lisp.
2938 (handle_one_xevent): NATNUMP can eval its arg twice.
2939 (x_connection_closed):
2940 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2941 * xterm.h: Adjust decls to match defn changes elsewhere.
2942 (struct scroll_bar): Use struct vectorlike_header
2943 rather than rolling our own approximation.
2944 (SCROLL_BAR_VEC_SIZE): Remove; not used.
2945
c6574eb5
GM
29462012-05-25 Glenn Morris <rgm@gnu.org>
2947
2948 * lisp.mk (lisp): Update for more files being compiled now.
2949
e8d32c7e
SM
29502012-05-25 Stefan Monnier <monnier@iro.umontreal.ca>
2951
48def666
SM
2952 * lread.c: Remove `read_pure' which makes no difference.
2953 (read_pure): Remove var.
2954 (unreadpure): Remove function.
2955 (readevalloop): Don't call read_list with -1 flag.
2956 (read1, read_vector): Don't test read_pure any more.
2957 (read_list): Simplify.
2958
e8d32c7e
SM
2959 * fileio.c, character.h: Minor style tweaks.
2960
4b2addb7
DA
29612012-05-24 Dmitry Antipov <dmantipov@yandex.ru>
2962
2963 * window.h (clip_changed): Remove useless declaration.
2964
584461b2
JB
29652012-05-22 Juanma Barranquero <lekktu@gmail.com>
2966
2967 * makefile.w32-in: Follow-up to 2012-05-22T16:20:27Z!eggert@cs.ucla.edu.
2968 (TAGS, TAGS-gmake, CONFIG_H): Remove further references to m/intel386.h.
2969
34374650
PE
29702012-05-22 Paul Eggert <eggert@cs.ucla.edu>
2971
2972 Remove src/m/*.
2973 This directory predates autoconf and is no longer needed nowadays.
2974 Move its few remaining bits of functionality to where they're needed.
2975 * m/README, m/alpha.h, m/amdx86-64.h, m/ia64.h, m/ibmrs6000.h:
2976 * m/ibms390x.h, m/intel386.h, m/m68k.h, m/macppc.h, m/sparc.h:
2977 * m/template.h: Remove.
2978 * Makefile.in (M_FILE): Remove. All uses removed.
2979 * alloc.c (POINTERS_MIGHT_HIDE_IN_OBJECTS):
2980 * lisp.h (USE_LSB_TAG):
2981 * mem-limits.h (EXCEEDS_LISP_PTR):
2982 Use VAL_MAX, not VALBITS, in #if.
2983 * lisp.h (EMACS_INT_MAX): New macro, useful in #if.
2984 (EMACS_UINT): Define unconditionally now.
2985 (BITS_PER_CHAR, BITS_PER_SHORT, BITS_PER_INT, BITS_PER_LONG)
2986 (BITS_PER_EMACS_INT): New constants, replacing
2987 what used to be in config.h, but not useful in #if.
2988 (GCTYPEBITS, VALBITS): Define unconditionally, since m/* files don't
2989 define them any more.
2990 (VAL_MAX): New macro.
2991 (VALMASK): Use it.
2992 * puresize.h (PURESIZE_RATIO): Use EMACS_INT_MAX, not
2993 BITS_PER_EMACS_INT, in #if.
2994 * s/aix4-2.h (BROKEN_FIONREAD, BROKEN_SIGAIO, BROKEN_SIGPTY)
2995 (BROKEN_SIGPOLL): Move here from m/ibmrs6000.h, which was removed.
2996 * s/gnu-linux.h (ULIMIT_BREAK_VALUE) [__i386__]:
2997 * s/ms-w32.h (DATA_START):
2998 Move here from removed file m/intel386.h.
2999 * s/gnu.h (NLIST_STRUCT): Remove undef; 'configure' does this.
3000 * s/irix6-5.h (_LP64): Remove; lisp.h no longer needs this.
3001
261cb4bb
PE
30022012-05-21 Paul Eggert <eggert@cs.ucla.edu>
3003
3004 Assume C89 or later.
3005 * alloc.c, buffer.c, lisp.h: Replace POINTER_TYPE with void.
3006 * alloc.c (overrun_check_malloc, overrun_check_realloc, xmalloc)
3007 (xrealloc):
3008 * buffer.c (mmap_free_1, mmap_enlarge): Omit needless casts.
3009 * editfns.c, fns.c, gmalloc.c, insdel.c, sysdep.c, termcap.c (NULL):
3010 * textprop.c, tparam.c (NULL): Remove.
3011 * ralloc.c, vm-limit.c (POINTER): Assume void * works.
3012 * regex.c (SIGN_EXTEND_CHAR): Assume signed char works.
3013 * regex.h (_RE_ARGS): Remove. All uses rewritten to use prototypes.
3014 * unexelf.c (ElfBitsW): Assume c89 preprocessor or better.
3015 * xterm.c (input_signal_count): Assume volatile works.
3016
ff23cd9f
KB
30172012-05-21 Ken Brown <kbrown@cornell.edu>
3018
3019 * xgselect.c (xg_select): Fix first argument in call to 'select'
3020 (bug#11508).
3021
1b170bc6
KB
30222012-05-20 Ken Brown <kbrown@cornell.edu>
3023
3024 * gmalloc.c (_free_internal_nolock, _realloc_internal_nolock)
bd7239f5 3025 [CYGWIN]: Cast ptr to (char *) before comparing to _heapbase.
1b170bc6 3026
b2f4d39f
KB
30272012-05-19 Ken Brown <kbrown@cornell.edu>
3028
3029 * xfns.c (x_in_use): Remove `static' qualifier.
3030 * xterm.h (x_in_use): Declare.
3031 * xgselect.c: Include xterm.h.
3032 (xg_select): Test `x_in_use' instead of `inhibit_window_system'
3033 and `display_arg' (bug#9754).
3034
003fdae2
PE
30352012-05-19 Paul Eggert <eggert@cs.ucla.edu>
3036
9232a6d9
PE
3037 * s/ms-w32.h (HAVE_GETDOMAINNAME): Remove; not needed.
3038
003fdae2
PE
3039 * m/vax.h: Remove; no longer needed since HAVE_FTIME is being removed.
3040 * s/ms-w32.h (HAVE_FTIME): Remove; not needed.
3041
784b56e2
EZ
30422012-05-18 Eli Zaretskii <eliz@gnu.org>
3043
3044 Fix compilation with -DGLYPH_DEBUG=1 on MS-Windows.
3045
3046 * w32term.c [GLYPH_DEBUG]: Add prototype for x_check_font.
090bd7cb 3047 (x_check_font) [GLYPH_DEBUG]: New function, copied from xterm.c.
784b56e2
EZ
3048
3049 * w32fns.c (unwind_create_frame) [GLYPH_DEBUG]: Fix broken
3050 reference to image_cache->refcount.
3051 (x_create_tip_frame): Fix broken use of FRAME_IMAGE_CACHE.
3052
a0a79cde
JL
30532012-05-17 Juri Linkov <juri@jurta.org>
3054
3055 * search.c (Fword_search_regexp, Fword_search_backward)
3056 (Fword_search_forward, Fword_search_backward_lax)
3057 (Fword_search_forward_lax): Move functions to isearch.el
3058 (bug#10145, bug#11381).
3059
b0572523
PE
30602012-05-16 Paul Eggert <eggert@cs.ucla.edu>
3061
3062 * xgselect.c (xg_select): Just invoke 'select' if -nw (Bug#9754).
3063
9660f5fc
SM
30642012-05-15 Stefan Monnier <monnier@iro.umontreal.ca>
3065
3066 * lread.c (init_obarray): Declare Qt and Qnil as special.
3067
4374de83
GM
30682012-05-14 Glenn Morris <rgm@gnu.org>
3069
3070 * nsterm.m (ns_init_paths): Fix typo ("libexec" not "lib-exec").
985584ae 3071 Put "libexec" before "bin", for the sake of init_callproc_1.
4374de83 3072
dc44c39a
PE
30732012-05-14 Paul Eggert <eggert@cs.ucla.edu>
3074
078c97cb
PE
3075 * keyboard.c (kbd_buffer_get_event) [!HAVE_DBUS]: Omit unused local.
3076
dc44c39a
PE
3077 * unexaix.c: Port to more-recent AIX compilers.
3078 (report_error, report_error_1, make_hdr, copy_sym)
3079 (mark_x, adjust_lnnoptrs, unrelocate_symbols):
3080 Make arguments const char *, not char *, to avoid violations of C
3081 standard and to fix some AIX warnings reported by Gilles Pion.
3082
e18afed7 30832012-05-14 Eli Zaretskii <eliz@gnu.org>
ac268e67
EZ
3084
3085 * xdisp.c (handle_stop): Don't call get_overlay_strings_1 if we
3086 already have overlays loaded.
3087 (handle_single_display_spec): Before returning without displaying
3088 fringe bitmap, synchronize the bidi iterator with the main display
3089 iterator, by calling iterate_out_of_display_property.
3090 (iterate_out_of_display_property): Detect buffer iteration by
3091 testing that it->string is a Lisp string.
3092 (get_next_display_element): When the current object is exhausted,
3093 and there's something on it->stack, call set_iterator_to_next to
3094 proceed with what's on the stack, instead of returning zero.
3095 (set_iterator_to_next): If called at the end of a Lisp string,
3096 proceed to consider_string_end without incrementing string
3097 position. Don't increment display vector index past the end of
3098 the display vector. (Bug#11417)
c8fb9dc6
EZ
3099 (pos_visible_p): Don't report a position visible when move_it_to
3100 stopped at the last line of window, which happens to be scanned
3101 backwards by the bidi iteration. (Bug#11464)
ac268e67 3102
e18afed7 31032012-05-14 Eli Zaretskii <eliz@gnu.org>
82f9b393
EZ
3104
3105 * xdisp.c (handle_single_display_spec): Return 1 for left-margin
3106 and right-margin display specs even if the spec is invalid or we
61b108cc
SM
3107 are on a TTY, and thus unable to display on the fringes.
3108 That's because the text with the property will not be displayed anyway,
82f9b393
EZ
3109 so we need to signal to the caller that this is a "replacing"
3110 display spec. This fixes display when the spec is invalid or we
3111 are on a TTY.
3112
e18afed7 31132012-05-14 Paul Eggert <eggert@cs.ucla.edu>
297834cd
PE
3114
3115 * unexaix.c (make_hdr): Fix typo in prototype.
3116 This bug broke the build on AIX. Problem reported by Gilles Pion.
3117
9d0a235a
MA
31182012-05-14 Michael Albinus <michael.albinus@gmx.de>
3119
3120 * keyboard.c (kbd_buffer_get_event): Read special events also in
3121 batch mode. (Bug#11415)
3122
9e6b06ed
GM
31232012-05-12 Glenn Morris <rgm@gnu.org>
3124
3125 * ns.mk: Update for ns_appbindir no longer having trailing "/".
3126
c1a1d7a3
EZ
31272012-05-12 Eli Zaretskii <eliz@gnu.org>
3128
3129 * lisp.mk (lisp): Add newcomment.elc.
3130
3fe7cdc8
GM
31312012-05-12 Glenn Morris <rgm@gnu.org>
3132
3133 * Makefile.in (MKDIR_P): New, set by configure.
3134 * ns.mk (${ns_appdir}, ${ns_appbindir}Emacs): Use $MKDIR_P.
3135
53f7d2c0
PE
31362012-05-11 Paul Eggert <eggert@cs.ucla.edu>
3137
3138 Remove unused function hourglass_started.
3139 * dispextern.h (hourglass_started):
3140 * w32fns.c (hourglass_started):
3141 * xdisp.c (hourglass_started): Remove.
3142
75aafb17
JB
31432012-05-10 Juanma Barranquero <lekktu@gmail.com>
3144
3145 * makefile.w32-in ($(BLD)/gmalloc.$(O), $(BLD)/w32menu.$(O)):
3146 Update dependencies.
3147
12959e8e
PE
31482012-05-10 Paul Eggert <eggert@cs.ucla.edu>
3149
97107e2e
PE
3150 * xgselect.c (xg_select): Put maxfds+1 into a var.
3151 This is slightly clearer, and pacifies Ubuntu 12.04 gcc.
3152
12959e8e
PE
3153 * sound.c (DEFAULT_ALSA_SOUND_DEVICE): Define only if HAVE_ALSA.
3154
836d29b3
DA
31552012-05-10 Dave Abrahams <dave@boostpro.com>
3156
3157 * filelock.c (syms_of_filelock): New boolean create-lockfiles.
3158 (lock_file): If create_lockfiles is 0, do nothing. (Bug#11227)
3159
5cb67954
MA
31602012-05-09 Michael Albinus <michael.albinus@gmx.de>
3161
3162 * dbusbind.c (xd_registered_buses): New internal Lisp object.
3163 Rename all occurences of Vdbus_registered_buses to xd_registered_buses.
3164 (syms_of_dbusbind): Remove declaration of Vdbus_registered_buses.
3165 Initialize xd_registered_buses.
3166
3478ec45
PE
31672012-05-09 Paul Eggert <eggert@cs.ucla.edu>
3168
b263a6b0
PE
3169 Untag more efficiently if USE_LSB_TAG.
3170 This is based on a proposal by YAMAMOTO Mitsuharu in
3171 <http://lists.gnu.org/archive/html/emacs-devel/2008-01/msg01876.html>.
3172 For an admittedly artificial (nth 8000 longlist) benchmark on
3173 Fedora 15 x86-64, this yields a 25% CPU speedup. Also, it shrinks
3174 Emacs's overall text size by 1%.
3175 * lisp.h (XUNTAG): New macro.
3176 (XCONS, XVECTOR, XSTRING, XSYMBOL, XFLOAT, XMISC, XPROCESS, XWINDOW)
3177 (XTERMINAL, XSUBR, XBUFFER, XCHAR_TABLE, XSUB_CHAR_TABLE, XBOOL_VECTOR)
3178 (XSETTYPED_PSEUDOVECTOR, XHASH_TABLE, TYPED_PSEUDOVECTORP): Use it.
3179 * eval.c (Fautoload):
3180 * font.h (XFONT_SPEC, XFONT_ENTITY, XFONT_OBJECT):
3181 * frame.h (XFRAME): Use XUNTAG.
3182
3478ec45
PE
3183 Port recent dbusbind.c changes to 32-bit --with-wide-int.
3184 * dbusbind.c (xd_append_arg, xd_retrieve_arg, Fdbus_message_internal):
3185 Remove unportable assumptions about print widths of types like
3186 dbus_uint32_t.
3187 (xd_get_connection_address, Fdbus_init_bus): Cast Emacs integer to
3188 intptr_t when converting between pointer and integer, to avoid GCC
3189 warnings about wrong width.
3190
666b903b 31912012-05-09 Eli Zaretskii <eliz@gnu.org>
0d887c7d
EZ
3192
3193 * w32proc.c (new_child): Force Windows to reserve only 64KB of
3194 stack for each reader_thread, instead of defaulting to 8MB
3195 determined by the linker. This avoids failures in creating
3196 subprocesses on Windows 7, see the discussion in this thread:
3197 http://lists.gnu.org/archive/html/emacs-devel/2012-03/msg00119.html.
3198
b120cc17
JC
31992012-05-07 Jérémy Compostella <jeremy.compostella@gmail.com>
3200
3201 Fix up display of the *Minibuf-0* buffer in the mini window.
3202 * keyboard.c (read_char): Don't clear the echo area if there's no
3203 message to clear.
3204 * xdisp.c (redisplay_internal): Redisplay the mini window (with the
2fed2689 3205 contents of *Minibuf-0*) if there's no message displayed in its stead.
b120cc17 3206
9a4b36f8
MA
32072012-05-07 Michael Albinus <michael.albinus@gmx.de>
3208
3209 * dbusbind.c (XD_DEBUG_MESSAGE): Don't print message twice in
3210 batch mode.
3211
e5f9458f
CY
32122012-05-06 Chong Yidong <cyd@gnu.org>
3213
3214 * lisp.mk (lisp): Update.
3215
eceeb5fc 32162012-05-05 Jim Meyering <meyering@redhat.com>
bf98199c
JM
3217
3218 * w32font.c (fill_in_logfont): NUL-terminate a string (Bug#11372).
3219
71873e2b
SM
32202012-05-04 Stefan Monnier <monnier@iro.umontreal.ca>
3221
3222 * data.c (PUT_ERROR): New macro.
3223 (syms_of_data): Use it. Add new error type `user-error'.
3224 * undo.c (user_error): New function.
3225 (Fprimitive_undo): Use it.
3226 * print.c (print_error_message): Adjust print style for `user-error'.
3227 * keyboard.c (user_error): New function.
3228 (Fexit_recursive_edit, Fabort_recursive_edit): Use it.
3229
ab0fa4e4
PE
32302012-05-03 Paul Eggert <eggert@cs.ucla.edu>
3231
3232 Do not limit current-time-string to years 1000..9999.
3233 * editfns.c (TM_YEAR_IN_ASCTIME_RANGE): Remove.
3234 (Fcurrent_time_string): Support any year that is supported by the
3235 underlying localtime representation. Don't use asctime, as it
3236 has undefined behavior for years outside the range -999..9999.
3237
7ed806a7
PE
32382012-05-02 Paul Eggert <eggert@cs.ucla.edu>
3239
3240 Fix race conditions involving setenv, gmtime, localtime, asctime.
3241 Without this fix, interrupts could mess up code that uses these
3242 nonreentrant functions, since setting TZ invalidates existing
3243 tm_zone or tzname values, and since most of these functions return
3244 pointers to static storage.
3245 * editfns.c (format_time_string, Fdecode_time, Fencode_time)
3246 (Fcurrent_time_string, Fcurrent_time_zone, Fset_time_zone_rule):
3247 Grow the critical sections to include not just invoking
3248 localtime/gmtime, but also accessing these functions' results
3249 including their tm_zone values if any, and any related TZ setting.
3250 (format_time_string): Last arg is now struct tm *, not struct tm **,
71873e2b
SM
3251 so that the struct tm is saved in the critical section.
3252 All callers changed. Simplify allocation of initial buffer, partly
7ed806a7
PE
3253 motivated by the fact that memory allocation needs to be outside
3254 the critical section.
3255
0c16dfed
DA
32562012-05-02 Dmitry Antipov <dmantipov@yandex.ru>
3257
3258 * intervals.c (adjust_intervals_for_insertion): Initialize `newi'
3259 with RESET_INTERVAL.
3260
3261 * buffer.c (Fget_buffer_create, Fmake_indirect_buffer):
3262 Remove duplicated buffer name initialization.
3263
3f83ace8
JM
32642012-05-02 Jim Meyering <jim@meyering.net>
3265
3266 * xterm.c (x_term_init): Use memcpy instead of strncpy (Bug#11373).
3267
c7b8541e
JM
3268 * xfns.c (x_window): Use xstrdup (Bug#11375).
3269
90207a15 32702012-05-02 Eli Zaretskii <eliz@gnu.org>
2fa85638
EZ
3271
3272 * xdisp.c (pos_visible_p): If already at a newline from the
3273 display string before the 'while' loop, don't walk back the glyphs
3274 from it3.glyph_row. Solves assertion violation when the display
3275 string begins with a newline (egg.el). (Bug#11367)
3276
b593d6a9
AH
32772012-05-01 Stefan Monnier <monnier@iro.umontreal.ca>
3278
3279 * keyboard.c (Fexecute_extended_command, Vsuggest_key_bindings):
3280 Move to simple.el.
3281
4737362e
GM
32822012-05-01 Glenn Morris <rgm@gnu.org>
3283
99cf43f9
GM
3284 * syssignal.h: Remove reference to BROKEN_SIGINFO (last used in
3285 s/ptx4.h), BROKEN_SIGTSTP (last used in m/ustation.h, m/dpx2.h),
3286 and BROKEN_SIGURG (was in s/gnu-linux.h prior to 2008-02-10).
3287 All were removed before 23.1.
3288
9311dcff
GM
3289 * dispnew.c: Remove HAVE_LIBNCURSES test;
3290 it is always true on relevant platforms.
3291
4d5c6349
GM
3292 * Makefile.in (LD_SWITCH_X_SITE_RPATH):
3293 Rename from LD_SWITCH_X_SITE_AUX_RPATH.
3294
4737362e
GM
3295 * Makefile.in (LD_SWITCH_X_SITE_AUX): Remove; no longer used.
3296
74dd3a6b
AS
32972012-04-30 Andreas Schwab <schwab@linux-m68k.org>
3298
3299 * .gdbinit (xpr): Remove checks for no longer existing misc types.
3300 (xintfwd, xboolfwd, xobjfwd, xbufobjfwd, xkbobjfwd, xbuflocal):
3301 Remove.
3302
13c379ee
PE
33032012-04-28 Paul Eggert <eggert@cs.ucla.edu>
3304
3305 Do not avoid creating empty evaporating overlays (Bug#9642).
3306 * buffer.c (Fmove_overlay): Revert the change of 2012-04-23.
3307 That is, do not delete an evaporating overlay if it becomes
3308 empty after its bounds are adjusted to fit within its buffer.
3309 This fix caused other problems, and I'm reverting it until we get
3310 to the bottom of them.
3311
a8e7d6d7 33122012-04-27 Chong Yidong <cyd@gnu.org>
9be2fd9b
CY
3313
3314 * xselect.c (x_convert_selection): Initialize a pointer (Bug#11315).
3315
a8e7d6d7 33162012-04-27 Eli Zaretskii <eliz@gnu.org>
f0ee99a0
EZ
3317
3318 * xdisp.c (pos_visible_p): If the window start position is beyond
3319 ZV, start the display from buffer beginning. Prevents assertion
3320 violation in init_iterator when the minibuffer window is scrolled
3321 via the scroll bar.
3322
3323 * window.c (window_scroll_pixel_based): Likewise.
3324
a8e7d6d7 33252012-04-27 Chong Yidong <cyd@gnu.org>
9ec7751f
CY
3326
3327 * keymap.c (where_is_internal): Doc fix (Bug#10872).
3328
a8e7d6d7 33292012-04-27 Glenn Morris <rgm@gnu.org>
24c51a09
GM
3330
3331 * fileio.c (Fcopy_file, Fset_file_selinux_context):
3332 Ignore ENOTSUP failures from setfilecon functions. (Bug#11245)
3333
a8e7d6d7 33342012-04-27 Eli Zaretskii <eliz@gnu.org>
73055685 3335
b593d6a9
AH
3336 * dispnew.c (swap_glyph_pointers, copy_row_except_pointers):
3337 Don't overrun array limits of glyph row's used[] array. (Bug#11288)
73055685 3338
1c6900d9
EZ
33392012-04-26 Eli Zaretskii <eliz@gnu.org>
3340
4c3fa1d9
EZ
3341 * xdisp.c (IT_DISPLAYING_WHITESPACE): In addition to the loaded
3342 display element, check also the underlying string or buffer
3343 character. (Bug#11341)
3344
1c6900d9
EZ
3345 * w32menu.c: Include w32heap.h.
3346 (add_menu_item): If the call to AppendMenuW (via
3347 unicode_append_menu) fails, disable Unicode menus only if we are
3348 running on Windows 9X/Me.
3349
42bf8205
AS
33502012-04-24 Andreas Schwab <schwab@linux-m68k.org>
3351
3352 * .gdbinit (xpr): Handle USE_2_TAGS_FOR_INTS.
3353 (xgetint): Add missing shift for LSB tags.
3354
b1bac16e
MR
33552012-04-24 Martin Rudalics <rudalics@gmx.at>
3356
3357 * keyboard.c (read_char): Don't wipe echo area for select window
3358 events: These might get delayed via `mouse-autoselect-window'
3359 (Bug#11304).
3360
d69621cc
JB
33612012-04-24 Juanma Barranquero <lekktu@gmail.com>
3362
3363 * gnutls.c (init_gnutls_functions): Protect against (unlikely)
3364 manipulation of :loaded-from data.
3365
02fd101b
JB
33662012-04-23 Juanma Barranquero <lekktu@gmail.com>
3367
3368 * gnutls.c (init_gnutls_functions): The value of :loaded-from is
3369 now a cons (bug#11311).
3370
888bec30
PE
33712012-04-23 Paul Eggert <eggert@cs.ucla.edu>
3372
89a438bd
PE
3373 Do not create empty overlays with the evaporate property (Bug#9642).
3374 * buffer.c (Fmove_overlay): Delete an evaporating overlay
3375 if it becomes empty after its bounds are adjusted to fit within
3376 its buffer. Without this fix, in a nonempty buffer (let ((o
3377 (make-overlay 1 2))) (overlay-put o 'evaporate t) (move-overlay o 0 1))
3378 yields an empty overlay that has the evaporate property, which is
3379 not supposed to happen.
3380
1068fe4d
PE
3381 Fix minor GTK3 problems found by static checking.
3382 * emacsgtkfixed.c (EMACS_TYPE_FIXED, EMACS_FIXED, EmacsFixed)
3383 (EmacsFixedPrivate, EmacsFixedClass, struct _EmacsFixed)
3384 (struct _EmacsFixedClass, emacs_fixed_get_type):
3385 Move decls here from emacsgtkfixed.h, since they needn't be public.
3386 (emacs_fixed_get_type): Now static.
3387 (emacs_fixed_class_init): Omit unused local.
3388 (emacs_fixed_child_type): Remove; unused.
3389 * emacsgtkfixed.h (EMACS_TYPE_FIXED, EMACS_FIXED, EmacsFixed)
3390 (EmacsFixedPrivate, EmacsFixedClass, struct _EmacsFixed)
3391 (struct _EmacsFixedClass): Move to emacsgtkfixed.c.
3392 (EMACS_FIXED_CLASS, EMACS_IS_FIXED, EMACS_IS_FIXED_CLASS)
3393 (EMACS_FIXED_GET_CLASS): Remove; unused.
3394 * gtkutil.c (xg_create_frame_widgets) [!HAVE_GTK3]: Omit unused local.
3395
888bec30
PE
3396 * keyboard.c (handle_async_input): Define only if SYNC_INPUT || SIGIO.
3397 Problem reported by Juanma Barranquero for Windows -Wunused-function.
3398
de85e130
PE
33992012-04-22 Paul Eggert <eggert@cs.ucla.edu>
3400
d0baac98 3401 Modernize and clean up gmalloc.c to assume C89 (Bug#9119).
bd7239f5 3402 * gmalloc.c (_MALLOC_INTERNAL, _MALLOC_H, _PP, __ptr_t)
d0baac98
PE
3403 (__malloc_size_t, __malloc_ptrdiff_t):
3404 Remove. All uses removed, replaced by the definiens if needed,
3405 since we can assume C89 or better now.
3406 Include <stdint.h>, for PTRDIFF_MAX, uintptr_t.
3407 (protect_malloc_state, align, get_contiguous_space)
3408 (malloc_atfork_handler_prepare, malloc_atfork_handler_parent)
3409 (malloc_atfork_handler_child, malloc_enable_thread)
3410 (malloc_initialize_1, __malloc_initialize, morecore_nolock)
3411 (_malloc_internal_nolock, _malloc_internal, malloc, _malloc)
3412 (_free, _realloc, _free_internal_nolock, _free_internal, free, cfree)
3413 (special_realloc, _realloc_internal_nolock, _realloc_internal)
3414 (realloc, calloc, __default_morecore, memalign, valloc, checkhdr)
3415 (freehook, mallochook, reallochook, mabort, mcheck, mprobe):
3416 Define using prototypes, not old style.
3417 (align, _malloc_internal_nolock, _free_internal_nolock, memalign):
3418 Don't assume ptrdiff_t and uintptr_t are no wider than unsigned long.
3419 (align): Don't assume that signed integer overflow wraps around.
3420 Omit unused local var.
3421 (malloc_initialize_1, morecore_nolock, _malloc_internal_nolock)
3422 (_free_internal_nolock, memalign, mallochook, reallochook):
3423 Omit no-longer-needed casts.
3424 (valloc): Use getpagesize, not __getpagesize.
3425 (MAGICWORD, MAGICFREE): Now randomish size_t values, not 32-bit.
3426 (struct hdr): The 'magic' member is now size_t, not unsigned long.
3427
de85e130
PE
3428 * dbusbind.c (XD_DBUS_VALIDATE_OBJECT): Define only if needed.
3429
dcbf5805
MA
34302012-04-22 Michael Albinus <michael.albinus@gmx.de>
3431
3432 Move functions from C to Lisp. Make non-blocking method calls
3433 the default. Implement further D-Bus standard interfaces.
3434
3435 * dbusbind.c (DBUS_NUM_MESSAGE_TYPES): Declare.
3436 (QCdbus_request_name_allow_replacement)
3437 (QCdbus_request_name_replace_existing)
3438 (QCdbus_request_name_do_not_queue)
3439 (QCdbus_request_name_reply_primary_owner)
3440 (QCdbus_request_name_reply_in_queue)
3441 (QCdbus_request_name_reply_exists)
3442 (QCdbus_request_name_reply_already_owner): Move to dbus.el.
3443 (QCdbus_registered_serial, QCdbus_registered_method)
3444 (QCdbus_registered_signal): New Lisp objects.
3445 (XD_DEBUG_MESSAGE): Use sizeof.
3446 (XD_MESSAGE_TYPE_TO_STRING, XD_OBJECT_TO_STRING)
3447 (XD_DBUS_VALIDATE_BUS_ADDRESS, XD_DBUS_VALIDATE_OBJECT)
3448 (XD_DBUS_VALIDATE_BUS_NAME, XD_DBUS_VALIDATE_PATH)
3449 (XD_DBUS_VALIDATE_INTERFACE, XD_DBUS_VALIDATE_MEMBER): New macros.
3450 (XD_CHECK_DBUS_SERIAL): Rename from CHECK_DBUS_SERIAL_GET_SERIAL.
3451 (xd_signature, xd_append_arg): Allow float for integer types.
3452 (xd_get_connection_references): New function.
b593d6a9
AH
3453 (xd_get_connection_address): Rename from xd_initialize.
3454 Return cached address.
dcbf5805
MA
3455 (xd_remove_watch): Do not unset $DBUS_SESSION_BUS_ADDRESS.
3456 (xd_close_bus): Rename from Fdbus_close_bus. Not needed on Lisp
3457 level.
3458 (Fdbus_init_bus): New optional arg PRIVATE. Cache address.
9a4b36f8 3459 Return number of refcounts.
dcbf5805
MA
3460 (Fdbus_get_unique_name): Make stronger parameter check.
3461 (Fdbus_message_internal): New defun.
3462 (Fdbus_call_method, Fdbus_call_method_asynchronously)
3463 (Fdbus_method_return_internal, Fdbus_method_error_internal)
3464 (Fdbus_send_signal, Fdbus_register_service)
3465 (Fdbus_register_signal, Fdbus_register_method): Move to dbus.el.
3466 (xd_read_message_1): Obey new structure of Vdbus_registered_objects.
3467 (xd_read_queued_messages): Obey new structure of Vdbus_registered_buses.
3468 (Vdbus_compiled_version, Vdbus_runtime_version)
3469 (Vdbus_message_type_invalid, Vdbus_message_type_method_call)
3470 (Vdbus_message_type_method_return, Vdbus_message_type_error)
3471 (Vdbus_message_type_signal): New defvars.
b593d6a9
AH
3472 (Vdbus_registered_buses, Vdbus_registered_objects_table):
3473 Adapt docstring.
dcbf5805 3474
52828e02
PE
34752012-04-22 Paul Eggert <eggert@cs.ucla.edu>
3476
da05bc4c
PE
3477 Fix GC_MALLOC_CHECK debugging output on 64-bit hosts.
3478 * alloc.c (emacs_blocked_malloc) [GC_MALLOC_CHECK]:
3479 Do not assume ptrdiff_t is the same width as 'int'.
3480
52828e02
PE
3481 * alloc.c: Handle unusual debugging option combinations.
3482 (GC_CHECK_MARKED_OBJECTS): Undef if ! GC_MARK_STACK,
3483 since the two debugging options are incompatible.
3484 (GC_MALLOC_CHECK): Similarly, undef if GC_CHECK_MARKED_OBJECTS
3485 is defined.
3486 (mem_init, mem_insert, mem_insert_fixup):
3487 Define if GC_MARK_STACK || GC_MALLOC_CHECK.
3488 (NEED_MEM_INSERT): Remove; no longer needed.
3489
f01769f9
LL
34902012-04-22 Leo Liu <sdl.web@gmail.com>
3491
3492 * sysdep.c (list_system_processes): Support Darwin (Bug#5725).
3493
5790543d
PE
34942012-04-22 Paul Eggert <eggert@cs.ucla.edu>
3495
3496 * sysdep.c [__FreeBSD__]: Minor cleanups.
3497 (list_system_processes, system_process_attributes) [__FreeBSD__]:
3498 Use Emacs indenting style more consistently. Avoid some casts.
3499 Use 'double' consistently rather than mixing 'float' and 'double'.
3500
b91b7e4d
EW
35012012-04-21 Eduard Wiebe <usenet@pusto.de>
3502
b593d6a9
AH
3503 * sysdep.c (list_system_processes, system_process_attributes):
3504 Add implementation for FreeBSD (Bug#5243).
b91b7e4d 3505
6114eb15
AS
35062012-04-21 Andreas Schwab <schwab@linux-m68k.org>
3507
3508 * lisp.mk (lisp): Update.
3509
2f38dff7
PE
35102012-04-20 Paul Eggert <eggert@cs.ucla.edu>
3511
3512 * keyboard.c (process_pending_signals): Define only if SYNC_INPUT.
3513 It is never used otherwise.
3514
4ae29f89
SM
35152012-04-20 Stefan Monnier <monnier@iro.umontreal.ca>
3516
3517 * print.c (print_preprocess): Only check print_depth if print-circle
3518 is nil.
3519 (print_object): Check for cycles even when print-circle is nil and
3520 print-gensym is t, but only check print_depth if print-circle is nil.
3521
f30d612a
CY
35222012-04-20 Chong Yidong <cyd@gnu.org>
3523
3524 * process.c (wait_reading_process_output): If EIO occurs on a pty,
3525 set the status to "failed" and ensure that sentinel is run.
3526
c07a4c0b 35272012-04-20 Glenn Morris <rgm@gnu.org>
016a35df
GM
3528
3529 * process.c (Fset_process_inherit_coding_system_flag)
3530 (Fset_process_query_on_exit_flag): Doc fix (mention return value).
4373fd43 3531 (Fmake_network_process, Fmake_serial_process): Doc fix.
016a35df 3532
c07a4c0b 35332012-04-20 Eli Zaretskii <eliz@gnu.org>
20a68157
EZ
3534
3535 * xdisp.c (string_buffer_position_lim): Limit starting position to
3536 BEGV.
3537 (set_cursor_from_row): If called for a mode-line or header-line
3538 row, return zero immediately.
3539 (try_cursor_movement): If inside continuation line, don't back up
4ae29f89
SM
3540 farther than the first row after the header line, if any.
3541 Don't consider the header-line row as "partially visible", even if
20a68157
EZ
3542 MATRIX_ROW_PARTIALLY_VISIBLE_P returns non-zero. (Bug#11261)
3543
c07a4c0b 35442012-04-20 Atsuo Ohki <ohki@gssm.otsuka.tsukuba.ac.jp> (tiny change)
ad3a2b41 3545
4ae29f89
SM
3546 * lread.c (lisp_file_lexically_bound_p): Fix hang at ";-*-\n"
3547 (bug#11238).
ad3a2b41 3548
c07a4c0b 35492012-04-20 Teodor Zlatanov <tzz@lifelogs.com>
6c94c34f 35502012-04-18 Paul Eggert <eggert@cs.ucla.edu>
ae6e112d
PE
3551
3552 configure: new option --enable-gcc-warnings (Bug#11207)
3553 * Makefile.in (C_WARNINGS_SWITCH): Remove.
3554 (WARN_CFLAGS, WERROR_CFLAGS): New macros.
3555 (ALL_CFLAGS): Use new macros rather than old.
3556 * process.c: Ignore -Wstrict-overflow to work around GCC bug 52904.
3557 * regex.c: Ignore -Wstrict-overflow. If !emacs, also ignore
3558 -Wunused-but-set-variable, -Wunused-function, -Wunused-macros,
3559 -Wunused-result, -Wunused-variable. This should go away once
3560 the Emacs and Gnulib regex code is merged.
3561 (xmalloc, xrealloc): Now static.
3562
aba027e8
PE
35632012-04-17 Paul Eggert <eggert@cs.ucla.edu>
3564
3565 * dired.c (Fsystem_groups): Remove unused local.
3566
e5a36063
GM
35672012-04-17 Glenn Morris <rgm@gnu.org>
3568
3569 * dired.c (Fsystem_users): Doc fix.
3570
316411f0
DA
35712012-04-17 Dmitry Antipov <dmantipov@yandex.ru>
3572
3573 * dired.c (Fsystem_users, Fsystem_groups): New functions. (Bug#7900)
3574 (syms_of_dired): Add them.
3575
9426aba4
PE
35762012-04-16 Paul Eggert <eggert@cs.ucla.edu>
3577
b62a57be
PE
3578 Fix minor alloc.c problems found by static checking.
3579 * alloc.c (_malloc_internal, _free_internal) [!DOUG_LEA_MALLOC]:
3580 New extern decls, to avoid calling undeclared functions.
3581 (dont_register_blocks): Define if ((!SYSTEM_MALLOC && !SYNC_INPUT)
3582 && GC_MALLOC_CHECK), not if ((GC_MARK_STACK || defined
3583 GC_MALLOC_CHECK) && GC_MALLOC_CHECK), to match when it's used.
3584 (NEED_MEM_INSERT): New macro.
3585 (mem_insert, mem_insert_fixup) [!NEED_MEM_INSERT]: Remove; unused.
4b5afbb0 3586 Remove one incorrect comment and fix another.
b62a57be 3587
3539f31f
PE
3588 Fix minor ralloc.c problems found by static checking.
3589 See http://lists.gnu.org/archive/html/emacs-devel/2011-12/msg00720.html
3590 * ralloc.c (ALIGNED, ROUND_TO_PAGE, HEAP_PTR_SIZE)
3591 (r_alloc_size_in_use, r_alloc_freeze, r_alloc_thaw): Remove; unused.
3592 (r_alloc_sbrk): Now static.
3593
a041960a
PE
3594 Improve ralloc.c interface checking.
3595 See http://lists.gnu.org/archive/html/emacs-devel/2011-12/msg00720.html
3596 * buffer.c (ralloc_reset_variable, r_alloc, r_re_alloc)
3597 (r_alloc_free) [REL_ALLOC]: Move decls from here ...
3598 * lisp.h (r_alloc, r_alloc_free, r_re_alloc, r_alloc_reset_variable)
3599 [REL_ALLOC]: ... to here, to check interface.
3600 * m/ia64.h (r_alloc, r_alloc_free) [REL_ALLOC && !_MALLOC_INTERNAL]:
3601 Remove decls. This fixes an "It stinks!".
3602
9426aba4
PE
3603 * alloc.c (which_symbols): Fix alignment issue / type clash.
3604
d55c12ed
AS
36052012-04-15 Andreas Schwab <schwab@linux-m68k.org>
3606
3607 * lisp.h (struct Lisp_Symbol): Remove explicit padding.
3608 (struct Lisp_Misc_Any): Likewise.
3609 (struct Lisp_Free): Likewise.
3610 * alloc.c (union aligned_Lisp_Symbol): Define.
3611 (SYMBOL_BLOCK_SIZE, struct symbol_block): Use union
3612 aligned_Lisp_Symbol instead of struct Lisp_Symbol.
3613 (union aligned_Lisp_Misc): Define.
3614 (MARKER_BLOCK_SIZE, struct marker_block): Use union
3615 aligned_Lisp_Misc instead of union Lisp_Misc.
4ae29f89 3616 (Fmake_symbol, allocate_misc, gc_sweep): Adjust.
d55c12ed 3617
b948ce8b
PE
36182012-04-14 Paul Eggert <eggert@cs.ucla.edu>
3619
3620 Make GC_MAKE_GCPROS_NOOPS the default (Bug#9926).
3621 * lisp.h (GC_MARK_STACK): Default to GC_MAKE_GCPROS_NOOPS.
3622 * s/cygwin.h, s/darwin.h, s/freebsd.h, s/gnu.h, s/irix6-5.h, s/msdos.h:
3623 * s/netbsd.h, s/sol2-6.h:
3624 Remove definition of GC_MARK_STACK, since the default now works.
3625 * s/aix4-2.h, s/hpux10-20.h, s/unixware.h:
3626 Define GC_MARK_STACK to GC_USE_GCPROS_AS_BEFORE, since that's
3627 no longer the default.
3628 * s/gnu-linux.h (GC_MARK_STACK): Adjust to change in default.
3629
35dc09a1 36302012-04-14 Atsuo Ohki <ohki@gssm.otsuka.tsukuba.ac.jp> (tiny change)
ad3a2b41 3631
35dc09a1
GM
3632 * lread.c (lisp_file_lexically_bound_p):
3633 Fix hang at ";-*-\n" (bug#11238).
ad3a2b41 3634
35dc09a1
GM
36352012-04-14 Eli Zaretskii <eliz@gnu.org>
3636
3637 * xdisp.c (find_last_unchanged_at_beg_row): Don't consider a row
3638 "unchanged" if its end.pos is beyond ZV. (Bug#11199)
3639
36402012-04-14 Jan Djärv <jan.h.d@swipnet.se>
3641
3642 * nsterm.m (constrainFrameRect): Always constrain when there is only
3643 one screen (Bug#10962).
3644
bcd86815
KB
36452012-04-13 Ken Brown <kbrown@cornell.edu>
3646
3647 * s/cygwin.h (PTY_OPEN): Don't try to close a bogus file descriptor.
3648
c25df26e
RT
36492012-04-13 Reuben Thomas <rrt@sc3d.org>
3650
3651 * indent.c (Fmove_to_column): Change interactive spec (Bug#739).
3652
0fc59f1e
DC
36532012-04-11 Daniel Colascione <dancol@dancol.org>
3654
3655 * s/cygwin.h: The vfork the #define in cygwin.h was protecting
3656 against is gone. It's better to use vfork now so that when Cygwin
3657 gains a new, working vfork, we use it automatically (bug#10398).
3658
de8c03dc
SM
36592012-04-11 Stefan Monnier <monnier@iro.umontreal.ca>
3660
3661 * window.c (save_window_save): Obey window-point-insertion-type.
3662
2f097256
GM
36632012-04-11 Glenn Morris <rgm@gnu.org>
3664
3665 * Makefile.in (GNUSTEP_CFLAGS): Rename from C_SWITCH_X_SYSTEM.
3666
453b951e
SM
36672012-04-11 Stefan Monnier <monnier@iro.umontreal.ca>
3668
3669 * alloc.c (lisp_align_malloc): Remove unneeded prototype.
3670
75f1671a 36712012-04-10 Jason S. Cornez <jcornez@ravenpack.com> (tiny change)
6bbef4e5
JC
3672
3673 * keyboard.c: Override inhibit-quit after the third C-g (bug#6585).
3674 (force_quit_count): New var.
3675 (handle_interrupt): Use it.
3676
2a8ce227
JB
36772012-04-10 Juanma Barranquero <lekktu@gmail.com>
3678
3679 * w32.c (w32_delayed_load): Record the full path of the library
3680 being loaded (bug#10424).
3681
935396c0
GM
36822012-04-09 Glenn Morris <rgm@gnu.org>
3683
05920a43
GM
3684 * doc.c (Fsnarf_documentation): Check variables, functions are bound,
3685 not just in the obarray, before snarfing them. (Bug#11036)
3686
935396c0
GM
3687 * Makefile.in ($(leimdir)/leim-list.el):
3688 Pass EMACS rather than BUILT_EMACS.
3689
a18ecafa
TZ
36902012-04-09 Teodor Zlatanov <tzz@lifelogs.com>
3691
3692 * process.c (make_process):
3693 * process.h: Add integer `gnutls_handshakes_tried' member to
3694 process struct.
3695
6bbef4e5
JC
3696 * gnutls.h: Add `GNUTLS_EMACS_HANDSHAKES_LIMIT' upper limit.
3697 Add convenience `GNUTLS_LOG2i' macro.
a18ecafa
TZ
3698
3699 * gnutls.c (gnutls_log_function2i): Convenience log function.
3700 (emacs_gnutls_read): Use new log functions,
3701 `gnutls_handshakes_tried' process member, and
3702 `GNUTLS_EMACS_HANDSHAKES_LIMIT' to limit the number of handshake
3703 attempts per process (connection).
3704
b4d3bc10
CY
37052012-04-09 Chong Yidong <cyd@gnu.org>
3706
3707 * eval.c (Fuser_variable_p, user_variable_p_eh)
3708 (lisp_indirect_variable): Functions deleted.
3709 (Fdefvar): Caller changed.
3710
3711 * callint.c (Finteractive, Fcall_interactively):
3712 * minibuf.c (Fread_variable): Callers changed.
3713
70f4d973
EZ
37142012-04-09 Eli Zaretskii <eliz@gnu.org>
3715
3716 * xdisp.c (set_cursor_from_row): If the display string appears in
3717 the buffer at position that is closer to point than the position
3718 after the display string, display the cursor on the first glyph of
3719 the display string. Fixes cursor display when a 'display' text
3720 property immediately follows invisible text. (Bug#11094)
3721
cb3c2e3e
PE
37222012-04-09 Paul Eggert <eggert@cs.ucla.edu>
3723
3724 composite.c: use 'double' consistently
3725 * composite.c (get_composition_id): Use 'double' consistently
3726 instead of converting 'float' to 'double' and vice versa; this is
3727 easier to understand and avoids a GCC warning.
3728
fd06db5d
GM
37292012-04-09 Glenn Morris <rgm@gnu.org>
3730
50fe702a
GM
3731 * Makefile.in: Generate leim-list with bootstrap-emacs, in
3732 preparation for dumping it with emacs. (Bug#4789)
3733 (leimdir): New variable.
3734 ($(leimdir)/leim-list.el): New rule.
3735 (emacs$(EXEEXT)): Depend on leim-list.el.
3736
fd06db5d
GM
3737 * buffer.c (Qucs_set_table_for_input): Remove. (Bug#9821)
3738 (Fget_buffer_create): Don't call Qucs_set_table_for_input.
3739 (init_buffer_once, syms_of_buffer): Remove Qucs_set_table_for_input.
3740
55c131ee
AS
37412012-04-08 Andreas Schwab <schwab@linux-m68k.org>
3742
3743 * lisp.h (struct Lisp_Symbol): Add explicit padding to ensure
3744 proper alignment.
3745
9209588f
JB
37462012-04-07 Juanma Barranquero <lekktu@gmail.com>
3747
3748 * xml.c (init_libxml2_functions) [WINDOWSNT]:
3749 Remove unused local variable.
3750
e3fb2efb
PE
37512012-04-07 Paul Eggert <eggert@cs.ucla.edu>
3752
3753 Avoid unnecessary pointer scanning in garbage collection (Bug#10780).
3754 * alloc.c (POINTERS_MIGHT_HIDE_IN_OBJECTS): New macro.
3755 (mark_memory): Mark Lisp_Objects only if pointers might hide in
3756 objects, as mark_maybe_pointer will catch them otherwise.
3757 (GC_LISP_OBJECT_ALIGNMENT): Remove; no longer needed.
3758 * s/gnu-linux.h (GC_LISP_OBJECT_ALIGNMENT) [__mc68000__]: Likewise.
3759
b5385551
PE
37602012-04-07 Paul Eggert <eggert@cs.ucla.edu>
3761
3762 Fix typo that broke non-Windows builds.
3763 * xml.c (libxml2_loaded_p) [!!WINDOWSNT]: 'inine' -> 'inline'.
3764
9078ead6
EZ
37652012-04-07 Eli Zaretskii <eliz@gnu.org>
3766
3767 Support building on MS-Windows with libxml2.
3768
3769 * makefile.w32-in (OBJ2): Add xml.$(O).
3770 (GLOBAL_SOURCES): Add xml.c.
3771 ($(BLD)/xml.$(O)): New dependency list.
3772
3773 * xml.c (DEF_XML2_FN, LOAD_XML2_FN) [WINDOWSNT]: New macros.
3774 (fn_htmlReadMemory, fn_xmlReadMemory, fn_xmlDocGetRootElement)
3775 (fn_xmlFreeDoc, fn_xmlCleanupParser, fn_xmlCheckVersion)
3776 [!WINDOWSNT]: New macros.
3777 (init_libxml2_functions, libxml2_loaded_p): New functions.
3778 (parse_region): Call fn_xmlCheckVersion instead of using the macro
3779 LIBXML_TEST_VERSION. Call libxml2 functions via the fn_* macros.
3780 (xml_cleanup_parser): New function, export for fn_xmlCleanupParser.
3781 Calls xmlCleanupParser only if libxml2 was loaded (or statically
3782 linked in).
6bbef4e5
JC
3783 (Flibxml_parse_html_region, Flibxml_parse_xml_region):
3784 Call init_libxml2_functions before calling libxml2 functions.
9078ead6
EZ
3785 (syms_of_xml) <Qlibxml2_dll>: DEFSYM it.
3786
3787 * emacs.c: Don't include libxml/parser.h.
3788 (shut_down_emacs): Call xml_cleanup_parser, instead of calling
3789 xmlCleanupParser directly.
3790
3791 * lisp.h [HAVE_LIBXML2]: Add prototype for xml_cleanup_parser.
3792
3811fdf3
EZ
37932012-04-07 Eli Zaretskii <eliz@gnu.org>
3794
3795 * indent.c (Fvertical_motion): If there is a display string at
3796 point, use it.vpos to compute how many lines to backtrack after
3797 move_it_to point. (Bug#11133)
3798
2f8e16b2
EZ
37992012-04-06 Eli Zaretskii <eliz@gnu.org>
3800
3801 * buffer.h (FETCH_CHAR, FETCH_MULTIBYTE_CHAR):
3802 * character.h (STRING_CHAR, STRING_CHAR_AND_LENGTH): Add comments
3803 about subtle differences between FETCH_CHAR* and STRING_CHAR*
3804 macros related to unification of CJK characters. For the details,
3805 see the discussion following the message here:
3806 http://debbugs.gnu.org/cgi/bugreport.cgi?bug=11073#14.
3807
3d439cd1
CY
38082012-04-04 Chong Yidong <cyd@gnu.org>
3809
3810 * keyboard.c (Vdelayed_warnings_list): Doc fix.
3811
8bc53d00
EZ
38122012-04-01 Eli Zaretskii <eliz@gnu.org>
3813
3814 * w32menu.c (simple_dialog_show, add_menu_item): Use SAFE_ALLOCA
3815 instead of alloca. (Bug#11138)
3816
3b0512a3
AS
38172012-04-01 Andreas Schwab <schwab@linux-m68k.org>
3818
3819 * w32menu.c (is_simple_dialog): Properly check lisp types.
3820 (Bug#11141)
3821
8427ddd2
EZ
38222012-03-31 Eli Zaretskii <eliz@gnu.org>
3823
979022ef
EZ
3824 * xdisp.c (move_it_by_lines): When DVPOS is positive, and the
3825 position we get to after a call to move_it_to fails the
3826 IS_POS_VALID_AFTER_MOVE_P test, move to the next buffer position
3827 only if we wind up in a string from display property. (Bug#11063)
3828
a6b1c7cc
EZ
3829 * window.c (Fdelete_other_windows_internal): Invalidate the row
3830 and column information about mouse highlight, so that redisplay
3831 restores it after reallocating the glyph matrices. (Bug#7464)
3832
8427ddd2
EZ
3833 * xdisp.c (set_cursor_from_row): If `cursor' property on a display
3834 string comes from a `display' text property, use the buffer
3835 position of that property as if we actually saw that position in
3836 the row's glyphs.
697ba24b
EZ
3837 (move_it_by_lines): Remove the assertion that
3838 "it->current_x == 0 && it->hpos == 0" which can be legitimately
3839 violated when there's a before-string at the beginning of a line.
3840 (Bug#11063)
8427ddd2 3841
65a0a738
EZ
38422012-03-30 Eli Zaretskii <eliz@gnu.org>
3843
3844 * xdisp.c (append_space_for_newline): If the default face was
3845 remapped, use the remapped face for the appended newline.
3846 (extend_face_to_end_of_line): Use the remapped default face for
3847 extending the face to the end of the line.
3848 (display_line): Call extend_face_to_end_of_line when the default
3849 face was remapped. (Bug#11068)
3850
581355cc
EZ
38512012-03-29 Eli Zaretskii <eliz@gnu.org>
3852
3853 * s/ms-w32.h: Discourage from defining HAVE_GETCWD.
3854
e8fc049f
SM
38552012-03-28 Stefan Monnier <monnier@iro.umontreal.ca>
3856
3857 * keyboard.c (safe_run_hooks_error): Don't unquote strings.
3858
4fb9a543
GM
38592012-03-27 Glenn Morris <rgm@gnu.org>
3860
3861 * search.c (Fword_search_backward_lax, Fword_search_forward_lax):
3862 Doc fixes.
3863
679910f1
KH
38642012-03-26 Kenichi Handa <handa@m17n.org>
3865
3866 * dispextern.h (struct glyph): Fix previous change. Change the
3867 bit length of glyphless.ch to 25 (Bug#11082).
3868
90d49b7f
CY
38692012-03-26 Chong Yidong <cyd@gnu.org>
3870
3871 * keyboard.c (Vselection_inhibit_update_commands): New variable.
3872 (command_loop_1): Use it; inhibit selection update for
3873 handle-select-window too (Bug#8996).
3874
f514f6f0
FP
38752012-03-25 Fabrice Popineau <fabrice.popineau@supelec.fr>
3876
e8fc049f 3877 * w32heap.c (_heap_init, _heap_term): Remove dead MSVC-specific code.
f514f6f0 3878
bf43fa51
KH
38792012-03-25 Kenichi Handa <handa@m17n.org>
3880
3881 * dispextern.h (struct glyph): Change the bit length of
3882 glyphless.ch to 22 to make the member glyphless fit in 32 bits.
3883
8a0c01dd
EZ
38842012-03-24 Eli Zaretskii <eliz@gnu.org>
3885
3886 * s/ms-w32.h (tzname): Include time.h before redirecting to
3887 _tzname. Fixes the MSVC build. (Bug#9960)
3888
7d1c3a76
AS
38892012-03-24 Andreas Schwab <schwab@linux-m68k.org>
3890
8ed79523
AS
3891 * xdisp.c (produce_glyphless_glyph): Limit length of acronym to 6
3892 characters.
3893
7d1c3a76
AS
3894 * xterm.c (XTread_socket): Only modify handling_signal if
3895 !SYNC_INPUT. (Bug#11080)
3896
e99a9b8b
EZ
38972012-03-23 Eli Zaretskii <eliz@gnu.org>
3898
3899 * bidi.c (bidi_fetch_char): Use STRING_CHAR_AND_LENGTH instead of
3900 FETCH_MULTIBYTE_CHAR followed by CHAR_BYTES. Prevents crashes
3901 when fetching a multibyte character consumes more bytes than
3902 CHAR_BYTES returns, due to unification of CJK characters in
3903 string_char. (Bug#11073)
3904
5063c0e1
TN
39052012-03-23 Troels Nielsen <bn.troels@gmail.com> (tiny change)
3906
3907 * process.c (wait_reading_process_output): Handle pty disconnect
3908 by refraining from sending oneself a SIGCHLD (bug#10933).
3909
9f851fbd
CY
39102012-03-22 Chong Yidong <cyd@gnu.org>
3911
3912 * dispextern.h (struct it): New member string_from_prefix_prop_p.
3913
5063c0e1 3914 * xdisp.c (push_prefix_prop): Rename from push_display_prop.
9f851fbd
CY
3915 Mark string as coming from a prefix property.
3916 (handle_face_prop): Use default face for prefix strings (Bug#4281).
3917 (pop_it, reseat_1): Save and restore string_from_prefix_prop_p.
3918
fb5b8aca
CY
39192012-03-21 Chong Yidong <cyd@gnu.org>
3920
3921 * xfaces.c (Vface_remapping_alist): Doc fix.
3922
62356a1b
EZ
39232012-03-20 Eli Zaretskii <eliz@gnu.org>
3924
3925 * w32proc.c (Fw32_set_console_codepage)
5063c0e1
TN
3926 (Fw32_set_console_output_codepage, Fw32_get_codepage_charset):
3927 Doc fixes.
62356a1b 3928
025de85b
CY
39292012-03-20 Chong Yidong <cyd@gnu.org>
3930
3931 * dispnew.c (Fredisplay, Vredisplay_preemption_period): Update doc
3932 to reflect default non-nil value of redisplay-dont-pause.
3933
4827f94e
KH
39342012-03-19 Kenichi Handa <handa@m17n.org>
3935
3936 * ftfont.c (ftfont_drive_otf): Mask bits of character code to make
3937 it fit in a valid range (Bug#11003).
3938
e50a24a2
EZ
39392012-03-18 Eli Zaretskii <eliz@gnu.org>
3940
3941 * xdisp.c (cursor_row_p): Even if the glyph row ends in a string
3942 that is not from display property, accept the row as a "cursor
3943 row" if one of the string's character has a non-nil `cursor'
3944 property. Fixes cursor positioning when there are newlines in
3945 overlay strings, e.g. in icomplete.el. (Bug#11035)
3946
9af5ed87
PE
39472012-03-12 Paul Eggert <eggert@cs.ucla.edu>
3948
3949 * buffer.c (compare_overlays): Don't assume args differ (Bug#6830).
3950
d1f55f16
CY
39512012-03-12 Chong Yidong <cyd@gnu.org>
3952
3953 * eval.c (inhibit_lisp_code): Rename from
3954 inhibit_window_configuration_change_hook; move from window.c.
3955
3956 * xfns.c (unwind_create_frame_1, Fx_create_frame):
3957 * window.c (run_window_configuration_change_hook)
3958 (syms_of_window): Callers changed.
3959
66c5eebd
CY
39602012-03-11 Chong Yidong <cyd@gnu.org>
3961
413df973
CY
3962 * keymap.c (Fkey_description): Doc fix (Bug#9700).
3963
66c5eebd
CY
3964 * editfns.c (Fconstrain_to_field): Doc fix (Bug#9452).
3965
1de11f56
CY
39662012-03-10 Chong Yidong <cyd@gnu.org>
3967
3968 * frame.c (other_visible_frames): Don't assume the selected frame
3969 is visible (Bug#10955).
3970
cae07000
SM
39712012-03-09 Stefan Monnier <monnier@iro.umontreal.ca>
3972
3973 * buffer.c (compare_overlays): Avoid qsort's instability (bug#6830).
3974
89c94350
JD
39752012-03-08 Jan Djärv <jan.h.d@swipnet.se>
3976
3977 * gtkutil.c (x_wm_set_size_hint): Use one row in call to
3978 FRAME_TEXT_LINES_TO_PIXEL_HEIGHT so base_height is greater than
3979 zero (Bug#10954).
3980
999dd333
GM
39812012-03-03 Glenn Morris <rgm@gnu.org>
3982
01a6dcc8 3983 * alloc.c (Fgarbage_collect, misc-objects-consed): Doc fixes.
999dd333 3984
de0100f2
EZ
39852012-03-02 Eli Zaretskii <eliz@gnu.org>
3986
3987 * xdisp.c (try_window_reusing_current_matrix): Don't move cursor
3988 position past the first glyph_row that ends at ZV. (Bug#10902)
b8456c5c
EZ
3989 (redisplay_window, next_element_from_string): Fix typos in
3990 comments.
3e441275
EZ
3991 (redisplay_window): Pass to move_it_vertically the margin in
3992 pixels, not in screen lines.
de0100f2 3993
96a72ee9
GM
39942012-03-02 Glenn Morris <rgm@gnu.org>
3995
3996 * buffer.c (buffer-list-update-hook): Doc fix.
3997
312508d7
EZ
39982012-02-29 Eli Zaretskii <eliz@gnu.org>
3999
4000 * xdisp.c (get_overlay_strings_1): Under bidi redisplay, call
4001 push_it before setting up the iterator for the first overlay
4002 string, even if we have an empty string loaded.
4003 (next_overlay_string): If there's an empty string on the iterator
4004 stack, pop the stack. (Bug#10903)
4005
27f3c637
PE
40062012-02-25 Paul Eggert <eggert@cs.ucla.edu>
4007
4008 Generalize fix for crash due to non-contiguous EMACS_INT (Bug#10780).
4009 Suggested by Stefan Monnier in
4010 <http://lists.gnu.org/archive/html/emacs-devel/2012-02/msg00692.html>.
4011 * alloc.c (widen_to_Lisp_Object): New static function.
4012 (mark_memory): Also mark Lisp_Objects by fetching pointer words
4013 and widening them to Lisp_Objects. This would work even if
4014 USE_LSB_TAG is defined and wide integers are used, which might
4015 happen in a future version of Emacs.
4016
3c9dfce6
CY
40172012-02-25 Chong Yidong <cyd@gnu.org>
4018
fa74b241
CY
4019 * fileio.c (Ffile_selinux_context, Fset_file_selinux_context):
4020 Doc fix.
4021
3c9dfce6
CY
4022 * xselect.c (Fx_selection_exists_p): Doc fix.
4023 (x_clipboard_manager_save_all): Print an informative message
4024 before saving to clipboard manager.
4025
9486df08
CY
40262012-02-24 Chong Yidong <cyd@gnu.org>
4027
4028 * keyboard.c (process_special_events): Handle all X selection
4029 requests in kbd_buffer, not just the next one (Bug#8869).
4030
f01d3321
CY
40312012-02-23 Chong Yidong <cyd@gnu.org>
4032
4033 * xfns.c (Fx_create_frame): Avoid window-configuration-change-hook
4034 call when setting menu-bar-lines and tool-bar-lines parameters.
4035 (unwind_create_frame_1): New helper function.
4036
4037 * window.c (inhibit_window_configuration_change_hook): New var.
4038 (run_window_configuration_change_hook): Obey it.
b2e4ca7d 4039 (syms_of_window): Initialize it.
f01d3321 4040
86b847b6
CY
40412012-02-22 Chong Yidong <cyd@gnu.org>
4042
4043 * xterm.c (x_draw_image_relief): Add missing type check for
4044 Vtool_bar_button_margin (Bug#10743).
4045
a59225b1
CY
40462012-02-21 Chong Yidong <cyd@gnu.org>
4047
4048 * fileio.c (Vfile_name_handler_alist): Doc fix.
4049
4050 * buffer.c (Fget_file_buffer): Protect against invalid file
4051 handler return value.
4052
310f5bd4
PE
40532012-02-20 Paul Eggert <eggert@cs.ucla.edu>
4054
cb3a28cc
PE
4055 * .gdbinit (xreload): Don't assume EMACS_INT fits in 'long'
4056 when computing $valmask.
4057
310f5bd4
PE
4058 Fix crash due to non-contiguous EMACS_INT (Bug#10780).
4059 * lisp.h (VALBITS): Move definition up, so that USE_LSB_TAG can use it.
4060 (USE_LSB_TAG): Do not define if UINTPTR_MAX >> VALBITS == 0.
4061 It's useless in that case, and it can cause problems on hosts
4062 that allocate halves of EMACS_INT values separately.
4063 Reported by Dan Horák. Diagnosed by Andreas Schwab in
4064 <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=10780#30>.
4065 * mem-limits.h (EXCEEDS_LISP_PTR): Define to 0 on hosts where
4066 UINTPTR_MAX >> VALBITS == 0. This is required by the above change;
4067 it avoids undefined behavior on hosts where shifting right by more
4068 than the word width has undefined behavior.
4069
2375c96a
CY
40702012-02-19 Chong Yidong <cyd@gnu.org>
4071
4072 * fileio.c (Ffile_name_directory, Ffile_name_nondirectory)
4073 (Funhandled_file_name_directory, Ffile_name_as_directory)
4074 (Fdirectory_file_name, Fexpand_file_name)
4075 (Fsubstitute_in_file_name): Protect against invalid file handler
4076 return values (Bug#10845).
4077
3eb49e71
EZ
40782012-02-18 Eli Zaretskii <eliz@gnu.org>
4079
4080 * .gdbinit (pitx): Fix incorrect references to fields of the
4081 iterator stack.
4082
7b926f3f
CY
40832012-02-17 Chong Yidong <cyd@gnu.org>
4084
4085 * syntax.c (Fscan_lists): Doc fix (Bug#10833).
4086
11273115
PE
40872012-02-15 Paul Eggert <eggert@cs.ucla.edu>
4088
4089 * image.c (MAX_IMAGE_SIZE): Increase from 6.0 to 10.0; see
4090 <http://lists.gnu.org/archive/html/emacs-devel/2012-02/msg00540.html>.
4091
c3a70e2b
CY
40922012-02-15 Chong Yidong <cyd@gnu.org>
4093
4094 * eval.c (Fdefvar, Fdefconst): Doc fix; note that the variable is
4095 marked as special. Also, starting docstrings with * is obsolete.
4096
0ca43699
AS
40972012-02-13 Andreas Schwab <schwab@linux-m68k.org>
4098
4099 * gnutls.c (emacs_gnutls_write): Fix last change.
4100
2e8f3c56
LI
41012012-02-13 Lars Ingebrigtsen <larsi@gnus.org>
4102
4103 * gnutls.c (emacs_gnutls_write): Set errno appropriately for
4104 send_process.
4105
af70074f
SM
41062012-02-13 Stefan Monnier <monnier@iro.umontreal.ca>
4107
4108 * keymap.c (Fsingle_key_description): Handle char ranges.
4109
95986d52
CY
41102012-02-12 Chong Yidong <cyd@gnu.org>
4111
afd83bd1
CY
4112 * xdisp.c (handle_stop): Avoid assigning -1 to it->face_id here,
4113 as that creates a dangerous corner case.
4114
95986d52
CY
4115 * window.c (Fdelete_window_internal): Invalidate the mouse
4116 highlight (Bug#9904).
4117
bd7da63e
GM
41182012-02-12 Glenn Morris <rgm@gnu.org>
4119
4120 * xselect.c (Fx_own_selection_internal)
4121 (Fx_get_selection_internal, Fx_disown_selection_internal)
4122 (Fx_selection_owner_p, Fx_selection_exists_p): Doc fixes.
4123 * nsselect.m (Fx_own_selection_internal)
4124 (Fx_disown_selection_internal, Fx_selection_exists_p)
4125 (Fx_selection_owner_p, Fx_get_selection_internal):
4126 Sync docs and argument specs with the xselect.c versions.
4127
77abcbc2
LI
41282012-02-11 Lars Ingebrigtsen <larsi@gnus.org>
4129
4130 * gnutls.c (emacs_gnutls_write): Don't infloop if sendto fails.
4131
90b671e2
EZ
41322012-02-11 Eli Zaretskii <eliz@gnu.org>
4133
1c0ca0b7
EZ
4134 * w32select.c (Fx_selection_exists_p): Sync doc string and
4135 argument list with xselect.c. (Bug#10783)
4136
4137 * w16select.c (Fx_selection_exists_p): Sync doc string and
4138 argument list with xselect.c. (Bug#10783)
90b671e2 4139
49241268
GM
41402012-02-10 Glenn Morris <rgm@gnu.org>
4141
4142 * fns.c (Fsecure_hash): Doc fix.
4143
f998bbe7 41442012-02-09 Kenichi Handa <handa@m17n.org>
5c1ca13d
KH
4145
4146 * coding.c (produce_chars): Fix updating of src_end (Bug#10701).
4147
0992bd9c
CY
41482012-02-07 Chong Yidong <cyd@gnu.org>
4149
4150 * buffer.c (Fbuffer_local_variables)
4151 (buffer_lisp_local_variables): Handle unbound vars correctly;
4152 don't let Qunbound leak into Lisp.
4153
af008560
GM
41542012-02-07 Glenn Morris <rgm@gnu.org>
4155
dd605cc4
GM
4156 * image.c (Fimagemagick_types): Doc fix.
4157
af008560
GM
4158 * image.c (imagemagick-render-type): Change it from a lisp object
4159 to an integer. Move the doc here from the lisp manual.
4160 Treat all values not equal to 0 the same.
4161
1449fa1d
CY
41622012-02-06 Chong Yidong <cyd@gnu.org>
4163
4164 * doc.c (store_function_docstring): Avoid applying docstring of
4165 alias to base function (Bug#2603).
4166
3723ec07
AS
41672012-02-04 Andreas Schwab <schwab@linux-m68k.org>
4168
4169 * .gdbinit (pp1, pv1): Remove redundant defines.
4170 (pr): Use pp.
4171
79c1cc1e
CY
41722012-02-04 Chong Yidong <cyd@gnu.org>
4173
4174 * nsterm.m: Declare a global (Bug#10694).
4175
d7f29f8e
EZ
41762012-02-04 Eli Zaretskii <eliz@gnu.org>
4177
cae07000
SM
4178 * w32.c (get_emacs_configuration_options):
4179 Include --enable-checking, if specified, in the return value.
d7f29f8e 4180
3b95a6f9
MR
41812012-02-04 Martin Rudalics <rudalics@gmx.at>
4182
4183 * dispnew.c (change_frame_size_1): Calculate new_frame_total_cols
4184 after rounding frame sizes. (Bug#9723)
4185
d6fa96a6
EZ
41862012-02-04 Eli Zaretskii <eliz@gnu.org>
4187
4188 * keyboard.c (adjust_point_for_property): Don't position point
4189 before BEGV. (Bug#10696)
4190
df0b2940
PE
41912012-02-03 Paul Eggert <eggert@cs.ucla.edu>
4192
4193 Handle overflow when computing char display width (Bug#9496).
4194 * character.c (char_width): Return EMACS_INT, not int.
4195 (char_width, c_string_width): Check for overflow when
4196 computing the width; this is possible now that individual
4197 characters can have unbounded width. Problem introduced
4198 by merge from Emacs 23 on 2012-01-19.
4199
6bee44d6
MA
42002012-02-02 Michael Albinus <michael.albinus@gmx.de>
4201
4202 * dbusbind.c (Fdbus_register_method): Mention the return value
4203 :ignore in the docstring.
4204
44f92739
GM
42052012-02-02 Glenn Morris <rgm@gnu.org>
4206
1b9f60cc
GM
4207 * callproc.c (Fcall_process, Fcall_process_region): Doc fix.
4208
44f92739
GM
4209 * nsterm.m (syms_of_nsterm) <x-toolkit-scroll-bars>:
4210 Unconditionally set to t. (Bug#10673)
4211 * nsterm.m (syms_of_nsterm) <x-toolkit-scroll-bars>:
4212 * w32term.c (syms_of_w32term) <x-toolkit-scroll-bars>:
4213 * xterm.c (syms_of_xterm) <x-toolkit-scroll-bars>: Doc fix.
4214
c5d3843c
KH
42152012-02-02 Kenichi Handa <handa@m17n.org>
4216
4217 (x_produce_glyphs): Cancel previous change. If cmp->glyph_len is
4218 0, do not call append_composite_glyph.
4219
159462d4 42202012-02-02 Kenichi Handa <handa@m17n.org>
d2a51fd7
KH
4221
4222 * xdisp.c (BUILD_COMPOSITE_GLYPH_STRING): Initialize first_s to
4223 NULL (Bug#6988).
4224 (x_produce_glyphs): If the component of a composition is a null
4225 string, set it->pixel_width to 1 to avoid zero-width glyph.
4226
78cef877
EZ
42272012-02-01 Eli Zaretskii <eliz@gnu.org>
4228
4229 * ralloc.c (resize_bloc, r_alloc_sbrk): Don't call memmove if its
4230 first 2 arguments are identical. This makes inserting large
4231 output from a subprocess an order of magnitude faster on
4232 MS-Windows, where all sbrk'ed memory is always contiguous.
4233
97897668
GM
42342012-01-31 Glenn Morris <rgm@gnu.org>
4235
4236 * nsterm.m (syms_of_nsterm) <x-toolkit-scroll-bars>:
c78c6e0b 4237 * w32term.c (syms_of_w32term) <x-toolkit-scroll-bars>:
97897668
GM
4238 * xterm.c (syms_of_xterm) <x-toolkit-scroll-bars>: Sync docs.
4239
31fd3586
GM
42402012-01-29 Glenn Morris <rgm@gnu.org>
4241
4242 * gnutls.c (syms_of_gnutls): More doc (from etc/NEWS).
4243
0e24a8b2
CY
42442012-01-28 Samuel Thibault <sthibault@debian.org> (tiny change)
4245
4246 * s/gnu.h: Define POSIX_SIGNALS (Bug#10552).
4247
cc0adcb0
CY
42482012-01-28 Chong Yidong <cyd@gnu.org>
4249
4250 * minibuf.c (syms_of_minibuf): Doc fix (Bug#10550).
4251
acc28cb9
CY
42522012-01-26 Chong Yidong <cyd@gnu.org>
4253
9c69cfb7
CY
4254 * keyboard.c (Vecho_keystrokes): Document zero value (Bug#10503).
4255
acc28cb9
CY
4256 * search.c (Fsearch_forward, Fsearch_backward): Document negative
4257 repeat counts (Bug#10507).
4258
48da7392
GM
42592012-01-26 Glenn Morris <rgm@gnu.org>
4260
4261 * lread.c (syms_of_lread): Doc fix.
4262
14af5f7f
CY
42632012-01-25 HIROSHI OOTA <nil@mad.dog.cx> (tiny change)
4264
4265 * coding.c (encode_designation_at_bol): Change return value to
4266 EMACS_INT.
4267
0b21c100
CY
42682012-01-25 Chong Yidong <cyd@gnu.org>
4269
4270 * eval.c (Fuser_variable_p): Doc fix; mention custom-variable-p.
4271
3c2907f7
CY
42722012-01-21 Chong Yidong <cyd@gnu.org>
4273
4274 * floatfns.c (Fcopysign): Make the second argument non-optional,
4275 since nil is not allowed anyway.
4276
959ad23f
AS
42772012-01-21 Andreas Schwab <schwab@linux-m68k.org>
4278
4279 * process.c (read_process_output): Use p instead of XPROCESS (proc).
4280 (send_process): Likewise.
4281
34a02f46
MR
42822012-01-19 Martin Rudalics <rudalics@gmx.at>
4283
4284 * window.c (save_window_save, Fcurrent_window_configuration)
cae07000
SM
4285 (Vwindow_persistent_parameters): Do not use Qstate.
4286 Rewrite doc-strings.
34a02f46 4287
1259009a 42882012-01-19 Kenichi Handa <handa@m17n.org>
25ed9e61
KH
4289
4290 * character.c (char_width): New function.
70d4fdf6
GM
4291 (Fchar_width, c_string_width, lisp_string_width):
4292 Use char_width (Bug#9496).
25ed9e61 4293
6a6ee00d
MR
42942012-01-16 Martin Rudalics <rudalics@gmx.at>
4295
4296 * window.c (Vwindow_persistent_parameters): New variable.
4297 (Fset_window_configuration, save_window_save): Handle persistent
4298 window parameters.
4299
c85efaf7
EZ
43002012-01-14 Eli Zaretskii <eliz@gnu.org>
4301
4302 * w32fns.c (signal_user_input): Don't do a QUIT, to avoid
4303 thrashing the stack of the thread. (Bug#9087)
4304
5944709e
PE
43052012-01-12 Paul Eggert <eggert@cs.ucla.edu>
4306
4307 * xdisp.c (rows_from_pos_range): Add parens as per gcc -Wparentheses.
4308
e71f5d99
EZ
43092012-01-11 Eli Zaretskii <eliz@gnu.org>
4310
4311 * xdisp.c (rows_from_pos_range): Handle the case where the
4312 highlight ends on a newline. (Bug#10464)
4313 (mouse_face_from_buffer_pos): Fix off-by-one error in calculating
4314 he end column for display of highlight that ends on a newline
4315 before a R2L line.
4316
ce316182
GM
43172012-01-11 Glenn Morris <rgm@gnu.org>
4318
4319 * lread.c (init_lread): If no-site-lisp, remove site-lisp dirs
4320 from load-path also when installation-directory is nil. (Bug#10208)
4321
5b43da69
GM
43222012-01-10 Glenn Morris <rgm@gnu.org>
4323
74cc8ff9
GM
4324 * emacs.c (syms_of_emacs) <installation-directory>: Doc fix.
4325
7d8d6e4e
GM
4326 * epaths.in (PATH_LOADSEARCH, PATH_EXEC, PATH_DATA, PATH_DOC):
4327 Update template values to be closer to their typical values these days.
5b43da69 4328
a0db8d43
EZ
43292012-01-09 Eli Zaretskii <eliz@gnu.org>
4330
4331 * xdisp.c (rows_from_pos_range): Accept additional argument
4332 DISP_STRING, and accept any glyph in a row whose object is that
4333 string as eligible for mouse highlight. Fixes mouse highlight of
4334 display strings from overlays. (Bug#10464)
4335
9a0115ab 43362012-01-07 Paul Eggert <eggert@cs.ucla.edu>
09450bae 4337
b9110d6a 4338 emacs: fix an auto-save permissions race condition (Bug#10400)
09450bae
PE
4339 * fileio.c (auto_saving_dir_umask): New static var.
4340 (Fmake_directory_internal): Use it.
4341 (do_auto_save_make_dir): Set it, instead of invoking chmod after
4342 creating the directory. The old code temporarily assigns
4343 too-generous permissions to the directory.
4344 (do_auto_save_eh): Clear it.
b9110d6a 4345 (Fdo_auto_save): Catch all errors, not just file errors, so
09450bae
PE
4346 that the var is always cleared.
4347
6c1bd3f3
EZ
43482012-01-07 Eli Zaretskii <eliz@gnu.org>
4349
4350 * search.c (scan_buffer): Pass character positions to
4351 know_region_cache, not byte positions. (Bug#6540)
4352
069d2b50
L
43532012-01-07 LynX <_LynX@bk.ru> (tiny change)
4354
4355 * w32.c (sys_rename): Report EXDEV when rename of a directory
4356 fails because the target is on another logical disk. (Bug#10284)
4357
75bf0d33
DB
43582012-01-07 David Benjamin <davidben@mit.edu> (tiny change)
4359
4360 * xterm.c (x_embed_request_focus): New function.
4361
4362 * xterm.h: Add prototype.
4363
4364 * xfns.c (Fx_focus_frame): Use it for embedded frames (Bug#9977).
4365
1c6e5a32
GM
43662012-01-05 Glenn Morris <rgm@gnu.org>
4367
4368 * emacs.c (emacs_copyright): Update short copyright year to 2012.
4369
651e947e
EZ
43702012-01-01 Eli Zaretskii <eliz@gnu.org>
4371
4372 * gnutls.c (init_gnutls_functions): Load gnutls_check_version.
4373 Load gnutls_transport_set_lowat only if GnuTLS version is below
4374 2.11.1.
4375 (emacs_gnutls_handshake): Call gnutls_transport_set_lowat only for
4376 GnuTLS versions below 2.11.1.
4377
3778cdd8
AL
43782011-12-31 Antoine Levitt <antoine.levitt@gmail.com>
4379
4380 * xdisp.c (syms_of_xdisp) <window-scroll-functions>: Add warning
4381 to the doc string advising against its use for altering the way
4382 windows are scrolled.
4383
0e5317f7
KH
43842011-12-28 Kenichi Handa <handa@m17n.org>
4385
4386 * coding.c (Fdefine_coding_system_internal): Make an utf-8 base
4387 coding-system ASCII compatible only when it does not produce BOM
4388 on encoding (Bug#10383).
4389
93d5ca1f
JD
43902011-12-26 Jan Djärv <jan.h.d@swipnet.se>
4391
4392 * xmenu.c (x_menu_wait_for_event): Use xg_select for Gtk3 so menus
4393 can scroll.
4394 (create_and_show_popup_menu): Always use menu_position_func for
4395 Gtk3 (Bug#10361).
4396
ca22b785
AS
43972011-12-24 Andreas Schwab <schwab@linux-m68k.org>
4398
4399 * callint.c (Fcall_interactively): Don't truncate prompt string.
4400
d048e1e6
EZ
44012011-12-23 Eli Zaretskii <eliz@gnu.org>
4402
4403 * xdisp.c (handle_invisible_prop): Handle correctly an invisible
4404 property that ends at ZV, so that the bidi iteration could be
3ba1a2ad 4405 resumed from there (after widening). (Bug#10360)
d048e1e6 4406
5ccaba1f
JD
44072011-12-22 Jan Djärv <jan.h.d@swipnet.se>
4408
4409 * nsfont.m (ns_spec_to_descriptor): Do not autorelease fdesc.
4410
204ee57f
JD
44112011-12-21 Jan Djärv <jan.h.d@swipnet.se>
4412
b81d40f0
JB
4413 * nsterm.m (x_free_frame_resources):
4414 Release f->output_data.ns->miniimage.
204ee57f
JD
4415 (ns_index_color): Fix indentation. Do not retain
4416 color_table->colors[i].
4417
4418 * nsmenu.m (ns_update_menubar): Call free_menubar_widget_value_tree
4419 before returning.
4420
4421 * nsfns.m (x_set_background_color): Assign return value from
4422 ns_index_color to face-background instead of NSColor*.
4423 (ns_implicitly_set_icon_type): Fix indentation.
4424 Change assignment in for loop to comparison.
4425
4426 * emacs.c (ns_pool): New variable.
4427 (main): Assign ns_pool.
4428 (Fkill_emacs): Call ns_release_autorelease_pool.
4429
4430 * nsfont.m (ns_spec_to_descriptor): Fix indentation,
4431 autorelease fdesc, release fdAttrs and tdict.
4432 (ns_get_covering_families): Release charset.
4433 (ns_findfonts): Release NSFontDescriptor created with new.
4434 (ns_uni_to_glyphs): Fix indentation.
4435 (setString): Release attrStr before assigning new value.
4436
c803b2b7
JD
44372011-12-18 Jan Djärv <jan.h.d@swipnet.se>
4438
678f4426
JD
4439 * nsmenu.m (NSMenuDidBeginTrackingNotification): Declare if OSX < 10.5
4440 and NS_IMPL_COCOA.
4441 (trackingNotification): Surround with ifdef NS_IMPL_COCOA.
4442 (syms_of_nsmenu): Set trackingMenu to 1 if not NS_IMPL_COCOA.
4443
cd394be1 44442011-12-18 David Reitter <reitter@cmu.edu>
678f4426 4445
5fecd5fc
JD
4446 * nsterm.m (ns_term_init): Subscribe for notifications
4447 NSMenuDidBeginTrackingNotification and NSMenuDidEndTrackingNotification
4448 to method trackingNotification in EmacsMenu.
4449
4450 * nsmenu.m (trackingMenu): New variable.
3771cb17 4451 (trackingNotification): New method (from Aquamacs).
5fecd5fc 4452 (menuNeedsUpdate): Expand comment and return if trackingMenu is 0,
3771cb17 4453 from Aquamacs (Bug#7030).
678f4426
JD
4454
44552011-12-18 Jan Djärv <jan.h.d@swipnet.se>
5fecd5fc 4456
c803b2b7
JD
4457 * nsselect.m (CUT_BUFFER_SUPPORT): Remove define.
4458 (symbol_to_nsstring): Fix indentation.
4459 (ns_symbol_to_pb): New function.
cae07000
SM
4460 (Fns_get_selection_internal): Rename from Fns_get_cut_buffer_internal.
4461 (Fns_rotate_cut_buffers_internal): Remove.
4462 (Fns_store_selection_internal): Rename from
c803b2b7
JD
4463 Fns_store_cut_buffer_internal.
4464 (ns_get_foreign_selection, Fx_own_selection_internal)
4465 (Fx_disown_selection_internal, Fx_selection_exists_p)
b81d40f0
JB
4466 (Fns_get_selection_internal, Fns_store_selection_internal):
4467 Use ns_symbol_to_pb and check if return value is nil.
4468 (syms_of_nsselect): Remove ifdef CUT_BUFFER_SUPPORT. Remove defsubr
4469 Sns_rotate_cut_buffers_internal. Sns_get_cut_buffer_internal
c803b2b7
JD
4470 renamed to Sns_get_selection_internal, Sns_store_cut_buffer_internal
4471 renamed to Sns_store_selection_internal.
4472 (ns_handle_selection_request): Move code to Fx_own_selection_internal
4473 and remove this function.
4474 (ns_handle_selection_clear): Remove, never used.
4475 (Fx_own_selection_internal): Move code from ns_handle_selection_request
4476 here.
4477
e1b01a3a
KB
44782011-12-17 Ken Brown <kbrown@cornell.edu>
4479
4480 * fileio.c (check_writable) [CYGWIN]: Return non-zero if UID or
4481 GID is unknown (Bug#10257).
4482
2adb6e85
PE
44832011-12-17 Paul Eggert <eggert@cs.ucla.edu>
4484
4485 * s/gnu-linux.h: Fix mark_memory typo (Bug#10286).
4486 (GC_MARK_SECONDARY_STACK): Omit removed 3rd arg to mark_memory,
4487 which caused a build failure on GNU/Linux IA-64. This problem was
4488 introduced by my 2011-10-07 patch.
4489
d1d7b339
JL
44902011-12-15 Juri Linkov <juri@jurta.org>
4491
4492 * image.c (imagemagick_error): New function. (Bug#10112)
4493 (imagemagick_load_image): Comment out `MagickSetResolution' call.
4494 Use `imagemagick_error' where ImageMagick functions return
4495 `MagickFalse'.
4496 (Fimagemagick_types): Add `Fnreverse' to return the list in the
4497 proper order.
4498
100d5755
KH
44992011-12-15 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
4500
4501 * xftfont.c (xftfont_draw): Use the font metrics of s->font to
4502 fill background (Bug#8992).
4503
454592a6
MR
45042011-12-13 Martin Rudalics <rudalics@gmx.at>
4505
4506 * window.c (Vwindow_combination_resize)
4507 (Vwindow_combination_limit): Use t instead of non-nil in
4508 doc-strings.
61d4b438
MR
4509 (Vrecenter_redisplay): Add first sentence of doc-string on
4510 separate line.
53524d93 4511 (Frecenter): Fix doc-string typo.
454592a6 4512
3633e3aa
KH
45132011-12-11 Kenichi Handa <handa@m17n.org>
4514
4515 * coding.c (Funencodable_char_position): Pay attention to the
4516 buffer text relocation (Bug#9389).
4517
7b9d523a 45182011-12-10 Jan Djärv <jan.h.d@swipnet.se>
61ccba97 4519
7b9d523a
JD
4520 * xterm.c (x_term_init): Move call to gdk_window_add_filter before
4521 gtk_init (Bug#10100).
4522
b73189c6
EZ
45232011-12-10 Eli Zaretskii <eliz@gnu.org>
4524
4525 * xdisp.c (RECORD_MAX_MIN_POS): Use IT->cmp_it.charpos only if
4526 IT->string is nil. (Bug#10263)
4527
f7dfe5d6
JD
45282011-12-10 Jan Djärv <jan.h.d@swipnet.se>
4529
83faebb4
JD
4530 * nsterm.h (x_free_frame_resources): Declare.
4531
f7dfe5d6
JD
4532 * nsfns.m (ns_get_defaults_value): New function (Bug#10103).
4533 (Fns_get_resource, x_get_string_resource): Call ns_get_defaults_value.
4534
4535 * nsterm.h (ns_get_defaults_value): Declare.
4536
4537 * nsterm.m (ns_default): Call ns_get_defaults_value.
4538
7cd4e72c
EZ
45392011-12-09 Eli Zaretskii <eliz@gnu.org>
4540
4541 * xdisp.c (try_scrolling): Don't set scroll_down_p if dy is zero.
4542 (Bug#10170)
4543
b34d7317
YM
45442011-12-09 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
4545
4546 * unexelf.c (unexec) [NS_IMPL_GNUSTEP]: Take account of the case
4547 that where the value of an _OBJC_* symbol points to is in the .bss
4548 section (Bug#10240).
4549
76470ad1
KH
45502011-12-08 Kazuhiro Ito <kzhr@d1.dion.ne.jp> (tiny change)
4551
4552 * coding.c (encode_coding_ccl): Check (charbuf < charbuf_end)
2fac8180 4553 after the loop to call ccl_driver at least once (Bug#8619).
76470ad1 4554
745fff94
KH
45552011-12-08 Kenichi Handa <handa@m17n.org>
4556
4557 * ftfont.c (get_adstyle_property): Fix previous change
4558 (Bug#10233).
4559
6e44397c
JB
45602011-12-07 Juanma Barranquero <lekktu@gmail.com>
4561
4562 * w32.c (init_environment): If no_site_lisp, remove site-lisp
4563 dirs from the default value of EMACSLOADPATH (bug#10208).
4564
7efa6272
GM
45652011-12-07 Glenn Morris <rgm@gnu.org>
4566
4567 * lread.c (init_lread): If no_site_lisp, exclude site-lisp/ in
4568 installation and source directories as well. (Bug#10208)
4569
f6fc4d87
CY
45702011-12-06 Chong Yidong <cyd@gnu.org>
4571
4572 * minibuf.c (Fread_from_minibuffer): Doc fix (Bug#10228).
4573
2bf26180
GM
45742011-12-06 Glenn Morris <rgm@gnu.org>
4575
4576 * process.c (start_process_unwind): Treat any pid <= 0, except -2,
4577 as an error, not just -1. (Bug#10217)
4578
3a6ad4f0
CY
45792011-12-05 Chong Yidong <cyd@gnu.org>
4580
4581 * keyboard.c (process_special_events): New function.
4582 (swallow_events, Finput_pending_p): Use it (Bug#10195).
4583
75a3b399
PE
45842011-12-05 Paul Eggert <eggert@cs.ucla.edu>
4585
4586 * coding.c (encode_designation_at_bol): Don't use uninitialized
4587 local variable (Bug#9318).
4588
c3c9e25e
KH
45892011-12-05 Kenichi Handa <handa@m17n.org>
4590
4591 * ftfont.c (get_adstyle_property): If the font is not BDF nor PCF,
4592 return Qnil (Bug#8046, Bug#10193).
4593
5eb05ea3
KH
45942011-12-05 Kenichi Handa <handa@m17n.org>
4595
4596 * coding.c (encode_designation_at_bol): New args charbuf_end and
4597 dst. Return the number of produced bytes. Callers changed.
a79703f5
KH
4598 (coding_set_source): Return how many bytes coding->source was
4599 relocated.
4600 (coding_set_destination): Return how many bytes
4601 coding->destination was relocated.
4602 (CODING_DECODE_CHAR, CODING_ENCODE_CHAR, CODING_CHAR_CHARSET)
cae07000 4603 (CODING_CHAR_CHARSET_P): Adjust for the avove changes.
5eb05ea3
KH
4604
46052011-12-05 Kazuhiro Ito <kzhr@d1.dion.ne.jp> (tiny change)
4606
4607 * coding.c (CODING_CHAR_CHARSET_P): New macro.
4608 (encode_coding_emacs_mule, encode_coding_iso_2022): Use the above
4609 macro (Bug#9318).
4610
46112011-12-05 Andreas Schwab <schwab@linux-m68k.org>
4612
4613 The following changes are to fix Bug#9318.
4614
a79703f5 4615 * coding.c (CODING_ENCODE_CHAR, CODING_CHAR_CHARSET): New macros.
5eb05ea3
KH
4616 (encode_coding_emacs_mule, ENCODE_ISO_CHARACTER)
4617 (encode_coding_iso_2022, encode_coding_sjis)
a79703f5 4618 (encode_coding_big5, encode_coding_charset): Use the above macros.
5eb05ea3 4619
7dbda6df
JB
46202011-12-05 Juanma Barranquero <lekktu@gmail.com>
4621
4622 * lisp.h (process_quit_flag): Fix external declaration.
4623
6d5eb5b0
SM
46242011-12-04 Stefan Monnier <monnier@iro.umontreal.ca>
4625
4626 Don't macro-inline non-performance-critical code.
4627 * eval.c (process_quit_flag): New function.
4628 * lisp.h (QUIT): Use it.
4629
a0c3fad0
JD
46302011-12-04 Jan Djärv <jan.h.d@swipnet.se>
4631
4632 * nsfns.m (get_geometry_from_preferences): New function.
4633 (Fx_create_frame): Call get_geometry_from_preferences (Bug#10103).
4634
6c07aac2
AS
46352011-12-04 Andreas Schwab <schwab@linux-m68k.org>
4636
4637 * emacs.c (Qkill_emacs): Define.
4638 (syms_of_emacs): Initialize it.
4639 * keyboard.c (interrupt_signal): Don't call Fkill_emacs here, set
4640 Qquit_flag to `kill-emacs' instead.
6d5eb5b0
SM
4641 (quit_throw_to_read_char): Add parameter `from_signal'.
4642 All callers changed. Call Fkill_emacs if requested and safe.
6c07aac2
AS
4643 * lisp.h (QUIT): Call Fkill_emacs if requested.
4644
c052ead4
JD
46452011-12-03 Jan Djärv <jan.h.d@swipnet.se>
4646
4647 * widget.c (update_wm_hints): Return if wmshell is null.
4648 (widget_update_wm_size_hints): New function.
4649
4650 * widget.h (widget_update_wm_size_hints): Declare.
4651
4652 * xterm.c (x_wm_set_size_hint): If USE_X_TOOLKIT, call
4653 widget_update_wm_size_hints (Bug#10104).
4654
9e49252b
EZ
46552011-12-03 Eli Zaretskii <eliz@gnu.org>
4656
4657 * xdisp.c (handle_invisible_prop): If the invisible text ends just
4658 before a newline, prepare the bidi iterator for consuming the
4659 newline, and keep the current paragraph direction. (Bug#10183)
e9a49426 4660 (redisplay_window): Don't let `margin' become negative. (Bug#10192)
9e49252b 4661
02b16839
JL
46622011-12-02 Juri Linkov <juri@jurta.org>
4663
4664 * search.c (Fword_search_regexp): New Lisp function created from
4665 `wordify'. Change type of arg `lax' from `int' to `Lisp_Object'.
4666 (Fword_search_backward, Fword_search_forward)
4667 (Fword_search_backward_lax, Fword_search_forward_lax):
4668 Use `Fword_search_regexp' instead of `wordify'. Doc fix.
4669 (syms_of_search): Define `Sword_search_regexp'. (Bug#10145)
4670
0068070e
SM
46712011-12-01 Stefan Monnier <monnier@iro.umontreal.ca>
4672
4673 * fileio.c (Finsert_file_contents): Move after-change-function call
4674 to before the "handled:" label, since all "goto handled" appear in
4675 cases where the *-change-functions have already been properly called
4676 (bug#10117).
4677
3360a3fc
AS
46782011-12-01 Andreas Schwab <schwab@linux-m68k.org>
4679
4680 * keyboard.c (interrupt_signal): Don't call kill-emacs when
4681 waiting for input. (Bug#10169)
4682
73d6c093
EZ
46832011-11-30 Eli Zaretskii <eliz@gnu.org>
4684
4685 * dispnew.c (adjust_glyph_matrix): Remove the assertion that
4686 verifies glyph row's hash code--we have just reallocated the
4687 glyphs, so their contents can be complete garbage. (Bug#10164)
4688
febe6bea
JB
46892011-11-30 Juanma Barranquero <lekktu@gmail.com>
4690
4691 * dispnew.c (adjust_glyph_matrix) [XASSERTS]: Add missing check.
4692
801a4313
EZ
46932011-11-30 Eli Zaretskii <eliz@gnu.org>
4694
4695 * dispnew.c (adjust_glyph_matrix) [XASSERTS]: Ensure ROW's
4696 attributes are tested _before_ calling verify_row_hash, to protect
4697 against GCC re-ordering of the tests. (Bug#10164)
4698
2b56b87e
JD
46992011-11-29 Jan Djärv <jan.h.d@swipnet.se>
4700
4701 * xterm.h (struct x_output): net_wm_state_hidden_seen is new.
4702
4703 * xterm.c (handle_one_xevent): Only set async_visible and friends
4704 if net_wm_state_hidden_seen is non-zero (Bug#10002)
7dbda6df 4705 (get_current_wm_state): Set net_wm_state_hidden_seen to 1 if
2b56b87e
JD
4706 _NET_WM_STATE_HIDDEN is in NET_WM_STATE.
4707
dbf31225
PE
47082011-11-28 Paul Eggert <eggert@cs.ucla.edu>
4709
4710 Remove GCPRO-related macros that exist only to avoid shadowing locals.
4711 * lisp.h (GCPRO1_VAR, GCPRO2_VAR, GCPRO3_VAR, GCPRO4_VAR, GCPRO5_VAR)
4712 (GCPRO6_VAR, UNGCPRO_VAR): Remove. See
4713 <http://lists.gnu.org/archive/html/emacs-diffs/2011-11/msg00265.html>.
4714 All uses changed to use GCPRO1 etc.
4715 (GCPRO1, GCPRO2, GCPRO3, GCPRO4, GCPRO5, GCPRO6, UNGCPRO):
4716 Revert to old implementation (i.e., before 2011-03-11).
4717
1305621b
YM
47182011-11-28 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
4719
4720 * dispnew.c (scrolling_window): Truncate overlaps in copy destination
4721 of scroll runs so as to avoid assigning disabled bogus rows and
4722 unnecessary graphics copy operations.
4723
8c9afb46
EZ
47242011-11-27 Eli Zaretskii <eliz@gnu.org>
4725
4726 * s/ms-w32.h (utimbuf) [_MSC_VER]: Don't define.
4727 (snprintf) [_MSC_VER]: Redirect to _snprintf.
4728 (strtoll) [_MSC_VER]: Redirect to _strtoi64.
4729 (malloc, free, realloc, calloc): Redirect to e_* only when
4730 compiling Emacs.
4731
4732 * lisp.h (GCTYPEBITS): Move before first use.
4733 (ALIGN_GCTYPEBITS) [_MSC_VER]: Define.
4734 (DECL_ALIGN) [_MSC_VER]: Use it, as MSVC doesn't like bit ops in
4735 this macro definition.
4736
4737 * s/ms-w32.h (tzname): Redirect to _tzname for all values of
4738 _MSC_VER.
4739
54e9e3bf
JD
47402011-11-27 Jan Djärv <jan.h.d@swipnet.se>
4741
6d5eb5b0
SM
4742 * gtkutil.c (xg_create_frame_widgets):
4743 Call gtk_window_set_has_resize_grip (FALSE) if that function is
54e9e3bf
JD
4744 present with Gtk+ 2.0.
4745
83aca1cb
PE
47462011-11-26 Paul Eggert <eggert@cs.ucla.edu>
4747
4748 * fileio.c (Finsert_file_contents): Undo previous change; see
4749 <http://lists.gnu.org/archive/html/emacs-diffs/2011-11/msg00265.html>.
4750
5b76caa4
PE
47512011-11-26 Paul Eggert <eggert@cs.ucla.edu>
4752
4753 Rename locals to avoid shadowing.
4754 * fileio.c (Finsert_file_contents):
4755 Rename inner 'gcpro1' to 'inner_gcpro1' to avoid shadowing.
4756 * process.c (wait_reading_process_output):
4757 Rename inner 'proc' to 'p' to avoid shadowing.
4758 Indent for consistency with usual Emacs style.
4759
8c535114
EZ
47602011-11-25 Eli Zaretskii <eliz@gnu.org>
4761
4762 * xdisp.c (redisplay_window): If cursor row is not fully visible
4763 after recentering, and scroll-conservatively is set to a large
4764 number, scroll window by a few more lines to make the cursor fully
4765 visible and out of scroll-margin. (Bug#10105)
91b4a718
EZ
4766 (start_display): Don't move to the next line if the display should
4767 start at a newline that is part of a display vector or an overlay
4768 string. (Bug#10119)
8c535114 4769
fa4fdb5c
JL
47702011-11-24 Juri Linkov <juri@jurta.org>
4771
4772 * image.c (imagemagick_load_image): Move `MagickSetResolution' down
4773 after the `MagickPingImage' call. (Bug#10112)
4774
90ec88df
CY
47752011-11-23 Chong Yidong <cyd@gnu.org>
4776
4777 * window.c (Fcoordinates_in_window_p): Accept only live windows.
4778
56e2e794
MR
47792011-11-23 Martin Rudalics <rudalics@gmx.at>
4780
4781 * buffer.c (Fkill_buffer): Run replace_buffer_in_windows before
4782 making another buffer current. (Bug#10114)
4783
b6e64c41
GM
47842011-11-23 Glenn Morris <rgm@gnu.org>
4785
4786 * font.c (font_find_for_lface) [HAVE_NS]: Ignore case. (Bug#2526)
4787
6b21de18
CY
47882011-11-23 Chong Yidong <cyd@gnu.org>
4789
4790 * xdisp.c (compute_stop_pos): Check validity of end_charpos before
4791 using it (Bug#5984).
4792
b12cd789
EZ
47932011-11-22 Eli Zaretskii <eliz@gnu.org>
4794
4795 * dispnew.c (adjust_glyph_matrix): Don't verify hash code of mode-
4796 and header-lines, as they don't have one computed for them.
4797 (Bug#10098)
4798
4799 * .gdbinit (prow): Make displayed values more self-explaining.
4800 Add row's hash code.
4801
261b6fd4
LMI
48022011-11-21 Lars Magne Ingebrigtsen <larsi@gnus.org>
4803
4804 * process.c (wait_reading_process_output): Fix asynchrounous
4805 GnuTLS socket handling on some versions of the GnuTLS library.
16c1ad08 4806 (wait_reading_process_output): Add comment and URL.
261b6fd4 4807
e7cfd277
JD
48082011-11-21 Jan Djärv <jan.h.d@swipnet.se>
4809
4810 * xterm.c (x_clear_frame): Reinstate the XClearWindow call.
4811
a9b9b7f5
CY
48122011-11-21 Chong Yidong <cyd@gnu.org>
4813
4814 * window.c (Fnext_window, Fprevious_window): Doc fix.
4815
b0d15b4f
SM
48162011-11-20 Stefan Monnier <monnier@iro.umontreal.ca>
4817
4818 * window.c (get_phys_cursor_glyph): Fix Lisp_Object/int mixup.
4819
fe7a3057
JB
48202011-11-20 Juanma Barranquero <lekktu@gmail.com>
4821
4822 * nsfont.m (syms_of_nsfont) <ns-reg-to-script>: Fix typo.
4823
d2999b1a
MR
48242011-11-20 Martin Rudalics <rudalics@gmx.at>
4825
4826 * window.c (Fset_window_combination_limit): Rename argument
4827 STATUS to LIMIT.
4828 (Vwindow_combination_limit): Remove "status" from doc-string.
4829
d5ff9cd0
AS
48302011-11-20 Andreas Schwab <schwab@linux-m68k.org>
4831
4832 * m/ibms390.h: Remove.
4833 * m/ibms390x.h: Don't include "ibms390.h".
4834
a5bb9bd3
SM
48352011-11-20 Stefan Monnier <monnier@iro.umontreal.ca>
4836
4837 * fileio.c (Finsert_file_contents): Add missing gcpro1 variable.
4838 Suggested by Dmitry Antipov <dmantipov@yandex.ru>.
4839
cd1181db
JB
48402011-11-20 Juanma Barranquero <lekktu@gmail.com>
4841
4842 * casetab.c (Fset_case_table):
4843 * charset.c (Fcharset_after): Fix typos.
4844
615a3b8d 48452011-11-20 Paul Eggert <eggert@cs.ucla.edu>
6a0bf43d 4846
17e845af
PE
4847 Standardize on VIRT_ADDR_VARIES behavior (Bug#10042).
4848 Otherwise, valgrind does not work on some platforms.
4849 Problem reported by Andreas Schwab in
6a0bf43d
PE
4850 <http://lists.gnu.org/archive/html/emacs-devel/2011-11/msg00081.html>.
4851 * puresize.h (pure, PURE_P): Always behave as if VIRT_ADDR_VARIES
4852 is set, removing the need for VIRT_ADDRESS_VARIES.
4853 (PURE_P): Use a more-efficient implementation that needs just one
4854 comparison, not two: on x86-64 with GCC 4.6.2, this cut down the
4855 number of instructions from 6 (xorl, cmpq, jge, xorl, cmpq, setge)
4856 to 4 (xorl, subq, cmpq, setbe).
4857 * alloc.c (pure): Always extern now, since that's the
4858 VIRT_ADDR_VARIES behavior.
4859 (PURE_POINTER_P): Use a single comparison, not two, for
4860 consistency with the new puresize.h.
4861 * lisp.h (PNTR_COMPARISON_TYPE): Remove; no longer needed.
4862 * m/ibms390.h, m/intel386.h, m/template.h, s/cygwin.h, s/hpux10-20.h:
4863 Remove VIRT_ADDR_VARIES no longer needed.
4864
f8fe6f96
EZ
48652011-11-19 Eli Zaretskii <eliz@gnu.org>
4866
4867 * xdisp.c (x_write_glyphs, draw_phys_cursor_glyph)
4868 (erase_phys_cursor, update_window_cursor, show_mouse_face)
4869 (cursor_in_mouse_face_p): If the cursor position is out of bounds,
4870 behave as if the cursor position were at the window margin.
4871
4872 * window.c (get_phys_cursor_glyph): If the window is hscrolled,
4873 and the cursor position is out of bounds, behave as if the cursor
4874 position were at the window margin. (Bug#10075)
4875
df05a53c
CY
48762011-11-18 Chong Yidong <cyd@gnu.org>
4877
4878 * window.c (Fwindow_combination_limit): Make first argument
4879 non-optional, since it is meaningless for live windows like the
4880 selected window.
61ccba97 4881
2071918e
DA
48822011-11-18 Dmitry Antipov <dmantipov@yandex.ru>
4883
4884 * keymap.c (Fwhere_is_internal): Add missing RETURN_UNGCPROs.
4885
b50a28de
SM
48862011-11-18 Stefan Monnier <monnier@iro.umontreal.ca>
4887
4888 * intervals.c: Fix grafting over the whole buffer (bug#10071).
4889 (graft_intervals_into_buffer): Simplify.
4890
015137db
EZ
48912011-11-18 Eli Zaretskii <eliz@gnu.org>
4892
4893 * dispnew.c (swap_glyph_pointers): Swap the used[] arrays and the
4894 hash values of the two rows.
4895 (copy_row_except_pointers): Preserve the used[] arrays and the
4896 hash values of the two rows. (Bug#10035)
68c95424 4897 (add_row_entry): Add xassert to verify that ROW's hash code is valid.
015137db
EZ
4898
4899 * xdisp.c (row_hash): New function, body extracted from
4900 compute_line_metrics.
4901 (compute_line_metrics): Call row_hash, instead of computing the
4902 hash code inline.
4903
4904 * dispnew.c (verify_row_hash): Call row_hash for computing the
4905 hash code of a row, instead of duplicating code from xdisp.c.
4906
4907 * dispextern.h (row_hash): Add prototype.
4908
a2addb04
TH
49092011-11-18 Tassilo Horn <tassilo@member.fsf.org>
4910
4911 * frame.c (delete_frame): Don't delete the terminal when the last
4912 X frame is closed if emacs is built with GTK toolkit.
4913
df85d315
JB
49142011-11-17 Juanma Barranquero <lekktu@gmail.com>
4915
4916 * window.c (syms_of_window) <window-combination-resize>: Fix typo.
4917
a0c2d0ae
MR
49182011-11-17 Martin Rudalics <rudalics@gmx.at>
4919
4920 * window.c (Vwindow_splits): Rename to
4921 Vwindow_combination_resize. Suggested by Juri Linkov.
4922 (Fsplit_window_internal): Use Vwindow_combination_resize instead
4923 of Vwindow_splits.
4924
58179cce
JB
49252011-11-16 Juanma Barranquero <lekktu@gmail.com>
4926
7877f373
JB
4927 * nsfns.m (Fns_font_name):
4928 * window.c (syms_of_window) <window-combination-limit>: Fix typos.
58179cce 4929
b6f67890
MR
49302011-11-16 Martin Rudalics <rudalics@gmx.at>
4931
4932 * window.h (window): Rename slot "nest" to "combination_limit".
4933 * window.c (Fwindow_nest): Rename to Fwindow_combination_limit.
4934 (Fset_window_nest): Rename to Fset_window_combination_limit.
4935 (Vwindow_nest): Rename to Vwindow_combination_limit.
4936 (recombine_windows, make_parent_window, make_window)
4937 (Fsplit_window_internal, saved_window)
4938 (Fset_window_configuration, save_window_save): Rename all
4939 occurrences of window_nest to window_combination_limit.
4940
c7015153
JB
49412011-11-15 Juanma Barranquero <lekktu@gmail.com>
4942
4943 * image.c (imagemagick_load_image): Fix typo.
4944
322ad6ec
EZ
49452011-11-14 Eli Zaretskii <eliz@gnu.org>
4946
4947 * xdisp.c (display_line): Move the call to
4948 highlight_trailing_whitespace before the call to
4949 compute_line_metrics, since the latter needs to see the final
6d5eb5b0
SM
4950 faces of all the glyphs to compute ROW's hash value.
4951 Fixes assertion violations in row_equal_p. (Bug#10035)
322ad6ec 4952
f067b8ec
JB
49532011-11-14 Juanma Barranquero <lekktu@gmail.com>
4954
4955 * w32proc.c (reader_thread): Don't check pending input if cp->fd < 0,
4956 just return (bug#10044).
4957
1e5b2111
EZ
49582011-11-12 Eli Zaretskii <eliz@gnu.org>
4959
7ef3cbd5
EZ
4960 * makefile.w32-in (HEAPSIZE): New variable, allows to build temacs
4961 with user-defined heap size. Bump the default size of the temacs
4962 heap to 27MB, to avoid memory warning when running temacs.
4963 ($(TEMACS)): Use HEAPSIZE instead of a hardcoded value.
4964
1e5b2111
EZ
4965 * dispnew.c (scrolling_window): Fix incorrect indices in accessing
4966 current_matrix and desired_matrix. (Bug#9990)
7a7270dd
EZ
4967 (verify_row_hash) [XASSERTS]: New function.
4968 (adjust_glyph_matrix, row_equal_p): Use it in xassert to verify
4969 that the hash value of glyph rows is correct.
1e5b2111 4970
89d61221
MR
49712011-11-12 Martin Rudalics <rudalics@gmx.at>
4972
4973 * window.h (window): Remove splits slot.
4974 * window.c (Fwindow_splits, Fset_window_splits): Remove.
4975 (Fdelete_other_windows_internal, make_parent_window)
4976 (make_window, Fsplit_window_internal, Fdelete_window_internal)
4977 (Fset_window_configuration, save_window_save): Don't deal with
4978 split status of windows.
4979 (saved_window): Remove splits slot.
4980 (Vwindow_splits): Rewrite doc-string.
4981
97f18cc8
JD
49822011-11-11 Jan Djärv <jan.h.d@swipnet.se>
4983
4984 * xfns.c (unwind_create_frame):
4985 * nsfns.m (unwind_create_frame):
4986 * w32fns.c (unwind_create_frame): Use Fmemq to check if frame is in
4987 Vframe_list (Bug#9999).
4988
22a648b4
DA
49892011-11-11 Dmitry Antipov <dmantipov@yandex.ru>
4990
0b381c7e 4991 * xdisp.c (syms_of_xdisp): Remove duplicated definition of Qtext.
22a648b4 4992
659afede
KH
49932011-11-11 Kenichi Handa <handa@m17n.org>
4994
4995 * callproc.c (Fcall_process): Set the member dst_multibyte of
4996 process_coding.
4997
9ac0394b
KH
49982011-11-11 Johan Bockgård <bojohan@gnu.org>
4999
5000 * xdisp.c (fill_composite_glyph_string): Always set s->face, to
5001 avoid a crash (bug#9496).
5002
2fbdc249
CY
50032011-11-09 Chong Yidong <cyd@gnu.org>
5004
5005 * window.c (Fwindow_inside_edges, Fwindow_inside_pixel_edges)
5006 (Fwindow_inside_absolute_pixel_edges): Only allow live windows.
5007
ac6b1f81
PE
50082011-11-08 Paul Eggert <eggert@cs.ucla.edu>
5009
5010 * s/gnu.h (GC_MARK_STACK): Define to GC_MAKE_GCPROS_NOOPS (Bug#9926).
5011
09db192c
PE
50122011-11-08 Paul Eggert <eggert@cs.ucla.edu>
5013
5014 Avoid some portability problems by eschewing 'extern inline' functions.
5015 The trivial performance wins aren't worth the portability hassles; see
5016 <http://lists.gnu.org/archive/html/emacs-devel/2011-11/msg00084.html>
5017 et seq.
5018 * dispextern.h (window_box, window_box_height, window_text_bottom_y)
5019 (window_box_width, window_box_left, window_box_left_offset)
5020 (window_box_right, window_box_right_offset): Undo previous change,
5021 by removing the "extern"s.
5022 * intervals.c (adjust_intervals_for_insertion)
5023 (adjust_intervals_for_deletion): Undo previous change,
5024 making these static again.
5025 (offset_intervals, temp_set_point_both, temp_set_point)
5026 (copy_intervals_to_string): No longer inline.
5027 * xdisp.c (window_text_bottom_y, window_box_width)
5028 (window_box_height, window_box_left_offset)
5029 (window_box_right_offset, window_box_left, window_box_right)
5030 (window_box): No longer inline.
5031
105216ed
CY
50322011-11-08 Chong Yidong <cyd@gnu.org>
5033
5034 * window.c (Fwindow_left_column, Fwindow_top_line): Doc fix.
6d5eb5b0
SM
5035 (Fwindow_body_height, Fwindow_body_width): Move from Lisp.
5036 Signal an error if not a live window.
105216ed
CY
5037 (Fwindow_total_width, Fwindow_total_height): Move from Lisp.
5038 (Fwindow_total_size, Fwindow_body_size): Move to Lisp.
5039
ae9e237f
JB
50402011-11-07 Juanma Barranquero <lekktu@gmail.com>
5041
5042 * lisp.h (syms_of_abbrev): Remove declaration.
5043 Reported by CHENG Gao <chenggao@royau.me>.
5044
c7aa8333
EZ
50452011-11-07 Eli Zaretskii <eliz@gnu.org>
5046
5047 * w32.c (check_windows_init_file): Don't look for term/w32-win.el
5048 if Vpurify_flag is non-nil. Fixes a crash when running w32 build
5049 of temacs in GUI mode.
5050
be7f5545
MR
50512011-11-07 Martin Rudalics <rudalics@gmx.at>
5052
5053 * window.h: Declare delete_all_child_windows instead of
5054 delete_all_subwindows.
5055 * window.c (Fwindow_nest, Fset_window_nest)
5056 (Fset_window_new_total, Fset_window_new_normal)
5057 (Fwindow_resize_apply): Don't use term subwindow in doc-strings.
5058 (delete_all_subwindows): Rename to delete_all_child_windows.
5059 (Fdelete_other_windows_internal, Fset_window_configuration):
5060 Call delete_all_child_windows instead of delete_all_subwindows.
5061 * frame.c (delete_frame): Call delete_all_child_windows instead
5062 of delete_all_subwindows.
5063
ca78dc43
PE
50642011-11-07 Paul Eggert <eggert@cs.ucla.edu>
5065
5066 * alloc.c (DEADP): New macro, for porting to GNU/Hurd (Bug#9926).
5067 This is also needed for porting to any host where GC_MARK_STACK is
5068 not GC_MAKE_GCPROS_NOOPS.
5069 (which_symbols): Use it.
5070
a0241d01
KH
50712011-11-07 Kenichi Handa <handa@m17n.org>
5072
5073 * coding.c (coding_set_destination): Check coding->src_pos only
5074 when coding->src_object is a buffer (bug#9910).
5075
5076 * process.c (send_process): Set the member src_multibyte of coding
5077 to 0 (bug#9911) when sending a unibyte text.
5078
5079 * callproc.c (Fcall_process): Set the member src_multibyte of
5080 process_coding to 0 (bug#9912).
5081
a64bfdfa 50822011-11-06 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
ba24cea2
YM
5083
5084 * xmenu.c (cleanup_widget_value_tree): New function.
5085 (xmenu_show, xdialog_show): Use it in record_unwind_protect instead of
5086 calling free_menubar_widget_value_tree directly (Bug#9830).
5087
cb41b32a
PE
50882011-11-06 Paul Eggert <eggert@cs.ucla.edu>
5089
5090 Fix some portability problems with 'inline'.
5091 * dispextern.h (window_box, window_box_height, window_text_bottom_y)
5092 (window_box_width, window_box_left, window_box_left_offset)
5093 (window_box_right, window_box_right_offset): Declare extern.
5094 Otherwise, these inline functions do not conform to C99 and
5095 are miscompiled by Microsoft compilers. Reported by Eli Zaretskii in
5096 <http://lists.gnu.org/archive/html/emacs-devel/2011-11/msg00084.html>.
5097 * intervals.c (adjust_intervals_for_insertion)
5098 (adjust_intervals_for_deletion): Now extern, because otherwise the
5099 extern inline functions 'offset_intervals' couldn't refer to it.
5100 (static_offset_intervals): Remove.
5101 (offset_intervals): Rewrite using the old contents of
5102 static_offset_intervals. The old version didn't conform to C99
5103 because an extern inline function contained a reference to an
5104 identifier with static linkage.
5105
b7041366
AS
51062011-11-06 Andreas Schwab <schwab@linux-m68k.org>
5107
5108 * keyboard.c (interrupt_signal): Don't call kill-emacs while in
5109 GC.
5110
88a37c4d
EZ
51112011-11-06 Eli Zaretskii <eliz@gnu.org>
5112
5113 * xdisp.c (init_iterator, reseat_to_string): Don't set the
5114 iterator's bidi_p flag if Vpurify_flag is non-nil. (Bug#9963)
5115 (Fcurrent_bidi_paragraph_direction): If Vpurify_flag is non-nil,
5116 return Qleft_to_right.
5117
49745b39
CY
51182011-11-06 Chong Yidong <cyd@gnu.org>
5119
5120 * window.c (Fwindow_live_p, Fwindow_frame, Fframe_root_window)
5121 (Fminibuffer_window, Fwindow_buffer, Fwindow_splits)
5122 (Fset_window_splits, Fwindow_nest, Fset_window_nest)
5123 (Fwindow_use_time, Fwindow_total_size, Fwindow_normal_size)
5124 (Fwindow_new_normal, Fwindow_left_column, Fwindow_top_line)
5125 (Fwindow_margins, Fwindow_fringes, Fwindow_scroll_bars)
5126 (Fwindow_vscroll): Doc fix.
5127 (Fwindow_top_child, Fwindow_left_child): Eliminate a nil default
5128 argument, since it makes no sense to pass a live window and for
5129 consistency with window-child.
5130
1f05cd82
CS
51312011-11-05 Christoph Scholtes <cschol2112@googlemail.com>
5132
5133 * makefile.w32-in ($(TEMACS), (gl-stamp)): Use $(THISDIR) to
5134 support MSVC.
5135
22610910
JR
51362011-11-05 Jason Rumney <jasonr@gnu.org>
5137
5138 * w32font.c (font_matches_spec): Filter out non-Japanese kana fonts.
5139 (add_font_entity_to_list): Filter out non-Japanese Shift-JIS
5140 fonts (Bug#6029).
5141 (add_font_entity_to_list): Fix logic errors in mixed boolean and
5142 bitwise arithmetic preventing use of unicode-sip and non-truetype
5143 opentype fonts.
5144
a06776b2
EZ
51452011-11-05 Eli Zaretskii <eliz@gnu.org>
5146
3ad924ba
EZ
5147 * s/ms-w32.h (fstat, stat, utime): Move redirections to
5148 "emacs"-only part.
5149
a06776b2
EZ
5150 * w32fns.c (x_create_tip_frame, Fx_create_frame): Rearrange
5151 initialization code to keep similarity to xfns.c after changes
5152 from 2011-11-05.
5153
c9e7db78
JD
51542011-11-05 Jan Djärv <jan.h.d@swipnet.se>
5155
a97f8f3f
JD
5156 * nsfns.m: Declare image_cache_refcount if GLYPH_DEBUG.
5157 (unwind_create_frame): New function (Bug#9943).
5158 (Fx_create_frame): Restructure code to be more similar to the one in
5159 xfns.c. Call record_unwind_protect with unwind_create_frame (Bug#9943).
5160 Initialize image_cache_refcount if GLYPH_DEBUG (Bug#9943).
5161 Move terminal->reference_count++ just before making the frame official
5162 (Bug#9943).
5163
5164 * nsterm.m (x_free_frame_resources): New function.
5165 (x_destroy_window): Move code to x_free_frame_resources.
5166
c9e7db78 5167 * xfns.c (unwind_create_frame): Fix comment.
6d5eb5b0
SM
5168 (Fx_create_frame, x_create_tip_frame):
5169 Move terminal->reference_count++ just before making the frame
75f1671a 5170 official. Move initialization of image_cache_refcount and
c9e7db78
JD
5171 dpyinfo_refcount before calling init_frame_faces (Bug#9943).
5172
a6fc3b5c
EZ
51732011-11-05 Eli Zaretskii <eliz@gnu.org>
5174
5175 Support MSVC build with newer versions of Visual Studio.
5176 * makefile.w32-in (TAGS-gmake): Don't use $(patsubst ...), as
5177 Nmake barfs on that. Use $(OBJ*_c) variables instead, defined on
5178 nt/gmake.defs.
5179
5180 * lisp.h (ENUM_BF): New macro, for enumerated types in bitfields,
5181 which are not supported by MSVC.
5182 (Lisp_Symbol, Lisp_Misc_Any, Lisp_Marker, Lisp_Misc_Overlay)
5183 (Lisp_Save_Value, Lisp_Free): Use ENUM_BF for enumerated types in
5184 bitfields.
5185 (Lisp_Object) [USE_LISP_UNION_TYPE]: Use ENUM_BF for enumerated
5186 types in bitfields.
5187 (DEFUN) [_MSC_VER]: Define in a different way for MSVC.
5188
5189 * w32fns.c [_MSC_VER]: DECLARE_HANDLE for any MSVC version.
5190
58179cce 51912011-11-05 Fabrice Popineau <fabrice.popineau@supelec.fr> (tiny change)
a6fc3b5c
EZ
5192
5193 Support MSVC build with newer versions of Visual Studio.
5194 * w32.c: Don't include w32api.h for MSVC.
5195 (init_environment) [_MSC_VER]: Call sys_access, not _access.
5196
5197 * s/ms-w32.h <sigset_t, ssize_t> [_MSC_VER]: Typedefs for MSVC.
5198 [_MSC_VER]: Include sys/timeb.h, sys/stat.h, and signal.h.
5199 (fstat, stat, utime) [_MSC_VER]: Redirect to their sys_* cousins.
5200 (malloc, free, realloc, calloc) [_MSC_VER]: Always redirect to the
5201 e_* cousins.
5202 (alloca) [_MSC_VER]: Define to _alloca.
5203
5204 * lisp.h (DECL_ALIGN) [_MSC_VER]: Define for MSVC.
5205
5206 * regex.c <re_char> [_MSC_VER]: A separate definition for MSVC.
5207
a58c13ed
EZ
52082011-11-04 Eli Zaretskii <eliz@gnu.org>
5209
5210 * xdisp.c (note_mouse_highlight): If either of
5211 previous/next-single-property-change returns nil, treat that as
5212 the beginning or the end of the buffer. (Bug#9955)
5213
fe0b6370
JD
52142011-11-04 Jan Djärv <jan.h.d@swipnet.se>
5215
a58c13ed 5216 * gtkutil.c (xg_make_tool_item): Add callbacks if one of wimage or
fe0b6370
JD
5217 label is not null (Bug#9951).
5218 (xg_tool_item_stale_p): Handle the fact that wimage and/or wlbl
5219 may be NULL.
5220
89bd5ee1
EZ
52212011-11-04 Eli Zaretskii <eliz@gnu.org>
5222
5223 * window.c (Fwindow_body_size): Mention in the doc string that the
5224 return value is in frame's canonical units. (Bug#9949)
5225
84c3edb9
EZ
52262011-11-03 Eli Zaretskii <eliz@gnu.org>
5227
4e2fb5c7
EZ
5228 * xdisp.c (note_mouse_highlight): Initialize `area'. (Bug#9947)
5229
84c3edb9 5230 * w32fns.c (unwind_create_frame): If needed, free the glyph
3ab15fd6 5231 matrices of the partially constructed frame. (Bug#9943)
2a58bbc1 5232 * xfns.c (unwind_create_frame): Likewise.
84c3edb9 5233
bc17a887
EZ
52342011-11-01 Eli Zaretskii <eliz@gnu.org>
5235
5236 * xdisp.c (mouse_face_from_buffer_pos): Fix a typo in a comment.
5237 Don't stop backward scan on the continuation glyph, even though
5238 its CHARPOS is positive.
6d5eb5b0
SM
5239 (mouse_face_from_buffer_pos, note_mouse_highlight):
5240 Rename cover_string to disp_string.
bc17a887 5241
4ee88440
MR
52422011-11-01 Martin Rudalics <rudalics@gmx.at>
5243
5244 * window.c (temp_output_buffer_show): Don't use
5245 Vtemp_buffer_show_specifiers.
5246 (Vtemp_buffer_show_specifiers): Remove unused variable.
5247
c2ff3c02
EZ
52482011-10-30 Eli Zaretskii <eliz@gnu.org>
5249
5250 * xdisp.c (try_cursor_movement): Make sure ROW isn't decremented
5251 past the beginning of the current glyph matrix.
5252
58179cce 52532011-10-30 Adam Sjøgren <asjo@koldfront.dk> (tiny change)
6e56383b
JD
5254
5255 * xterm.c: Include X11/Xproto.h if HAVE_GTK3.
5256 (x_error_handler): Ignore BadMatch for X_SetInputFocus for
5257 HAVE_GTK3 (Bug#9869).
b77a6a7f 5258
3b574623
JD
5259 * gtkutil.c (xg_win_to_widget, xg_event_is_for_menubar): Initialize
5260 type to GDK_NOTHING so valgrind does not complain (Bug#9901).
5261
b77a6a7f
JD
5262 * xterm.h (x_display_info): Add Xatom_net_wm_state_hidden (Bug#9893).
5263
5264 * xterm.c: Declare x_handle_net_wm_state to return int.
5265 (handle_one_xevent): Check if we are iconified but don't have
5266 _NET_WM_STATE_HIDDEN. If do, treat as deiconify (Bug#9893).
5267 (get_current_wm_state): Return non-zero if not hidden,
5268 check for _NET_WM_STATE_HIDDEN (Bug#9893).
5269 (do_ewmh_fullscreen): Ignore return value from get_current_wm_state.
5270 (x_handle_net_wm_state): Return what get_current_wm_state returns.
5271 (x_term_init): Initialize dpyinfo->Xatom_net_wm_state_hidden.
5272
196e41e4
PE
52732011-10-29 Paul Eggert <eggert@cs.ucla.edu>
5274
5275 * alloc.c (which_symbols): Declare EXTERNALLY_VISIBLE,
5276 so that this new function doesn't get optimized away by a
5277 whole-program optimizer. Make the 2nd arg EMACS_INT, not int.
5278
021f2e1a
AS
52792011-10-29 Andreas Schwab <schwab@linux-m68k.org>
5280
5281 * frame.h (MOUSE_HL_INFO): Remove excess parens.
5282
8b058d44
EZ
52832011-10-29 Eli Zaretskii <eliz@gnu.org>
5284
5285 Fix the `xbytecode' command.
5286 * .gdbinit (xprintbytestr): New command.
b50a28de 5287 (xwhichsymbols): Rename from `which'; all callers changed.
8b058d44
EZ
5288 (xbytecode): Print the byte-code string as well.
5289
4452fb80
EZ
52902011-10-29 Kim Storm <storm@cua.dk>
5291
8b058d44
EZ
5292 * alloc.c (which_symbols): New function.
5293
21b72067
AS
52942011-10-29 Andreas Schwab <schwab@linux-m68k.org>
5295
5296 * minibuf.c (read_minibuf_noninteractive): Allow reading empty
5297 line. (Bug#9903)
5298
83ed7b5c
GM
52992011-10-29 Glenn Morris <rgm@gnu.org>
5300
5301 * process.c (wait_reading_process_output): Revert 2009-08-30 change.
5302 Not clear what it was for, and it causes various bugs. (Bug#9839)
5303
5a7a728b
EZ
53042011-10-28 Eli Zaretskii <eliz@gnu.org>
5305
5306 * xdisp.c (note_mouse_highlight): Initialize `part', to avoid a
5307 possible random value that matches one of those tested as
5308 condition to clear the mouse face.
5309
d3d0842f
CY
53102011-10-28 Chong Yidong <cyd@gnu.org>
5311
5312 * xdisp.c (note_mouse_highlight): Fix use of uninitialized var.
5313
31b39d13
DN
53142011-10-28 Dan Nicolaescu <dann@ics.uci.edu>
5315
5316 * window.c (make_window): Initialize phys_cursor_on_p.
5317
9aba6043
SM
53182011-10-28 Stefan Monnier <monnier@iro.umontreal.ca>
5319
5320 * lisp.h (struct Lisp_Symbol): Update comments.
5321
c20992f4
JB
53222011-10-28 Juanma Barranquero <lekktu@gmail.com>
5323
5324 * w32font.c (w32_load_unicows_or_gdi32): Add missing return.
5325
db4f02f2
EZ
53262011-10-28 Eli Zaretskii <eliz@gnu.org>
5327
5328 Fix Emacs on Windows 9X (bug#8562). Thanks to oslsachem
5329 <oslsachem@gmail.com> for helping to debug this.
5330
5331 * w32font.c (g_b_init_is_w9x, g_b_init_get_outline_metrics_w)
5332 (g_b_init_get_text_metrics_w, g_b_init_get_glyph_outline_w)
5333 (g_b_init_get_glyph_outline_w): New static variables.
5334 (GetOutlineTextMetricsW_Proc, GetTextMetricsW_Proc)
5335 (GetGlyphOutlineW_Proc): New typedefs.
5336 (w32_load_unicows_or_gdi32, get_outline_metrics_w)
9aba6043
SM
5337 (get_text_metrics_w, get_glyph_outline_w, globals_of_w32font):
5338 New functions.
5339 (w32font_open_internal, compute_metrics):
5340 Call get_outline_metrics_w, get_text_metrics_w, and get_glyph_outline_w
db4f02f2
EZ
5341 instead of calling the "wide" APIs directly.
5342
5343 * emacs.c (main) [HAVE_NTGUI]: Call globals_of_w32font.
5344
5345 * w32.h (syms_of_w32font): Add prototype.
5346
87e68db4
JB
53472011-10-27 Juanma Barranquero <lekktu@gmail.com>
5348
5349 * window.c (Fframe_root_window, Fframe_first_window, Fwindow_end)
5350 (Fframe_selected_window, Ftemp_output_buffer_show, Fnext_window)
5351 (Fdelete_window_internal, Fwindow_parameters): Fix typos in docstrings.
5352 (Fmove_to_window_line): Doc fix.
5353
435c1d67
CY
53542011-10-27 Chong Yidong <cyd@gnu.org>
5355
5356 * process.c (make_process): Set gnutls_state to NULL.
5357
5358 * gnutls.c (emacs_gnutls_deinit): Deinit the gnutls_state if it is
5359 non-NULL, regardless of GNUTLS_INITSTAGE.
5360 (Fgnutls_boot): Cleanups. Call emacs_gnutls_deinit if we signal
5361 an error. Set process slots as soon as we allocate them.
5362
5363 * gnutls.h (GNUTLS_LOG, GNUTLS_LOG2): Fix macros.
5364
9c6c6f49
CY
53652011-10-27 Chong Yidong <cyd@gnu.org>
5366
9aba6043
SM
5367 * gnutls.c (emacs_gnutls_deinit): New function.
5368 Deallocate credentials structures as well as calling gnutls_deinit.
9c6c6f49
CY
5369 (Fgnutls_deinit, Fgnutls_boot): Use it.
5370
5371 * process.c (make_process): Initialize GnuTLS credentials to NULL.
5372 (deactivate_process): Call emacs_gnutls_deinit.
5373
657d08d3
JB
53742011-10-27 Juanma Barranquero <lekktu@gmail.com>
5375
5376 * image.c (x_create_x_image_and_pixmap):
5377 * w32.c (sys_rename, w32_delayed_load):
5378 * w32font.c (fill_in_logfont):
5379 * w32reg.c (x_get_string_resource): Silence compiler warnings.
5380
5430d399
JB
53812011-10-26 Juanma Barranquero <lekktu@gmail.com>
5382
5383 * w32fns.c (w32_default_color_map): New function,
5384 extracted from Fw32_default_color_map.
a7ef684b 5385 (Fw32_default_color_map, Fx_open_connection): Use it. (Bug#9785)
5430d399 5386
fe0055fa
PE
53872011-10-25 Paul Eggert <eggert@cs.ucla.edu>
5388
5389 * dispextern.h (Fcontrolling_tty_p): New decl (Bug#6649 part 2).
5390
e6346438
SM
53912011-10-25 Stefan Monnier <monnier@iro.umontreal.ca>
5392
5393 * keyboard.c (test_undefined): New function (bug#9751).
5394 (read_key_sequence): Use it to detect when a key is bound to `undefined'.
5395
e112cc37
ET
53962011-10-25 Enami Tsugutomo <tsugutomo.enami@jp.sony.com>
5397
5398 * sysdep.c (init_sys_modes): Fix the check for the controlling
5399 terminal (Bug#6649).
5400
7b5d6677
EZ
54012011-10-20 Eli Zaretskii <eliz@gnu.org>
5402
5403 * dispextern.h (struct bidi_it): New member next_en_type.
5404
5405 * bidi.c (bidi_line_init): Initialize the next_en_type member.
5406 (bidi_resolve_explicit_1): When next_en_pos is valid for the
5407 current character, check also for next_en_type being WEAK_EN.
5408 (bidi_resolve_weak): Don't enter the expensive loop if the current
5409 position is before next_en_pos. Record the bidi type of the first
5410 non-ET, non-BN character we find, in addition to its position.
5411 (bidi_level_of_next_char): Invalidate next_en_type when
5412 next_en_pos is over-stepped.
5413
7da0b018
PE
54142011-10-20 Paul Eggert <eggert@cs.ucla.edu>
5415
5416 Time zone name fixes for non-ASCII locales (Bug#641, Bug#9794)
5417 * editfns.c: Rewrite current-time-zone so that it invokes
5418 the equivalent of (format-time-string "%Z") to get the time zone name.
5419 This fixes a bug when the time zone name contains characters that
5420 need converting from the system time locale to Emacs internal format.
5421 This fixes a shortcoming that I introduced in my 1999-10-19 patch:
5422 that patch fixed format-time-string to do the conversion, but
5423 I forgot to fix current-time-zone.
5424 (format_time_string): New function, containing most of
5425 what Fformat_time_string used to contain.
5426 (Fformat_time_string): Rewrite in terms of format_time_string.
5427 This doesn't change this function's behavior.
5428 (current-time-zone): Rewrite to use format_time_string.
5429 This fixes the bug reported by Michael Schierl in
5430 <http://lists.gnu.org/archive/html/emacs-devel/2007-06/msg00334.html>.
5431 Jason Rumney's 2007-06-07 change worked around this bug, but
5432 didn't fix it.
5433 * systime.h (tzname, timezone): Remove no-longer-used declarations.
5434
8547b010
EZ
54352011-10-19 Eli Zaretskii <eliz@gnu.org>
5436
5437 * xdisp.c (start_display): If the character at POS is displayed
5438 via a display vector, reset IT->current.dpvec_index to zero.
12b32963
EZ
5439 (try_window_reusing_current_matrix): If a line ends in a display
5440 vector or the next line starts in a display vector, continue
5441 redrawing the window even though the character position of
5442 start_row was reached.
8547b010
EZ
5443 (Bug#9771, part 2)
5444
4e948d15
CY
54452011-10-18 Chong Yidong <cyd@gnu.org>
5446
5447 * xdisp.c (get_next_display_element): Handle U+2010 and U+2011
5448 with nobreak-char-display too.
5449
4787455f
EZ
54502011-10-18 Eli Zaretskii <eliz@gnu.org>
5451
5452 Fix part 3 of bug#9771.
5453 * bidi.c (bidi_line_init): Initialize next_en_pos to zero, not -1.
5454 (bidi_resolve_neutral): Don't enter the expensive loop looking for
5455 non-neutral characters if the current character is a paragraph
5456 separator (a.k.a. Newline). This avoids running the same
5457 expensive loop twice, once when we consume the preceding newline
5458 and the other time when the line actually needs to be displayed.
5459 Avoid the loop when we see neutrals on the base embedding level
5460 following a character whose directionality is the same as the
5461 paragraph's. This avoids running the expensive loop when a line
5462 ends in a long sequence of neutrals, like control characters.
5463 Add assertion against STRONG_AL type. Slightly rearrange code
5464 that determines the type of a neutral given the first non-neutral
5465 that follows it.
5466 (bidi_level_of_next_char): Set next_en_pos to zero when
5467 invalidating its info.
5468
2c91f553
EZ
54692011-10-17 Eli Zaretskii <eliz@gnu.org>
5470
5471 * xdisp.c (push_display_prop): Determine whether to record string
5472 or buffer position by IT->string, not by IT->method. Allow
5473 GET_FROM_DISPLAY_VECTOR as IT->method on entry. (Bug#9771, part 4)
f2ff9e88
EZ
5474 (move_it_vertically_backward): Don't look for character position
5475 immediately after the newline when in a continuation line.
5476 (Bug#9771, part 1)
2c91f553 5477
c7b08b0d
MR
54782011-10-15 Martin Rudalics <rudalics@gmx.at>
5479
5480 * window.c (coordinates_in_window): Rewrite and delabelize
5481 vertical border check. (Bug#5357) (Bug#9618)
5482
6b02f655
SM
54832011-10-14 Stefan Monnier <monnier@iro.umontreal.ca>
5484
5485 * xterm.c (frame_highlight, frame_unhighlight): Ignore unexplained
5486 errors in XSetWindowBorder (bug#9310).
5487
81d40c92
DA
54882011-10-13 Dmitry Antipov <dmantipov@yandex.ru>
5489
5490 * editfns.c (Fset_time_zone_rule): Replace free with xfree to
5491 avoid crash when xmalloc overrun checking is enabled.
5492
d4172c3b
EZ
54932011-10-13 Eli Zaretskii <eliz@gnu.org>
5494
5495 * xdisp.c (Fcurrent_bidi_paragraph_direction): Initialize
5496 itb.paragraph_dir to NEUTRAL_DIR. Fixes an occasional incorrect
5497 cursor motion with <left> and <right> arrow keys.
5498
5499 * bidi.c (bidi_init_it): Don't initialize paragraph_dir here, as
5500 some callers set that themselves.
5501
b00eea75
EZ
55022011-10-12 Eli Zaretskii <eliz@gnu.org>
5503
5504 * xdisp.c (find_row_edges): Handle the case where ROW comes from a
5505 display string and the previous row comes from the same string and
5506 is empty. (Bug#9739) (Bug#9738)
5507
8fe012c4
SM
55082011-10-12 Stefan Monnier <monnier@iro.umontreal.ca>
5509
5510 * doc.c (get_doc_string): Encode file name (bug#9735).
5511
0074aef2
EZ
55122011-10-12 Eli Zaretskii <eliz@gnu.org>
5513
79beb178
EZ
5514 * bidi.c (bidi_level_of_next_char):
5515 * xdisp.c (get_visually_first_element): Remove old incorrect
5516 comments regarding the Unicode Line Separator character.
5517
0074aef2
EZ
5518 * bidi.c (bidi_init_it): Initialize paragraph_dir to NEUTRAL_DIR.
5519
6e4b3fbe
DA
55202011-10-12 Dmitry Antipov <dmantipov@yandex.ru>
5521
5522 * alloc.c (Fgc_status): Do not access beyond zombies array
5523 boundary if nzombies > MAX_ZOMBIES.
5524 * alloc.c (dump_zombies): Add missing format specifier.
5525
0324f3af
PE
55262011-10-12 Paul Eggert <eggert@cs.ucla.edu>
5527
b5525cac
PE
5528 * xdisp.c (set_cursor_from_row): Simplify conditionals,
5529 to pacify GCC 4.6.1 x86-64 with -O2 -Wstrict-overflow.
5530
0324f3af
PE
5531 * lread.c (read_escape): Allow hex escapes as large as ?\xfffffff.
5532 Some packages use them to denote characters with modifiers.
5533
e9b5f888
AS
55342011-10-11 Andreas Schwab <schwab@linux-m68k.org>
5535
5536 * lisp.h (GCPRO1_VAR, GCPRO2_VAR, GCPRO3_VAR, GCPRO4_VAR)
5537 (GCPRO5_VAR, GCPRO6_VAR, UNGCPRO_VAR): Add whitespace to avoid
5538 matching a pp-number. Rename parameter var to var1.
5539
127827c0
SM
55402011-10-11 Stefan Monnier <monnier@iro.umontreal.ca>
5541
5542 * minibuf.c (Finternal_complete_buffer): Fix last change (bug#9709).
5543
c8fd3bd0
GM
55442011-10-08 Glenn Morris <rgm@gnu.org>
5545
5546 * callint.c (Fcall_interactively): Give a more explicit error for the
5547 'c' case with a non-character input. (Bug#8479)
5548
352ec8ff
EZ
55492011-10-08 Eli Zaretskii <eliz@gnu.org>
5550
03669ccb
EZ
5551 * xdisp.c (hscroll_window_tree): Support hscroll in right-to-left
5552 lines.
7061c986
EZ
5553 (set_cursor_from_row): Fix cursor positioning in mixed L2R+R2L
5554 lines that are hscrolled on the left.
03669ccb 5555
352ec8ff
EZ
5556 * dispnew.c (buffer_posn_from_coords): Account for a possible
5557 presence of header-line. (Bug#4426)
5558
a66cfb1c
SM
55592011-10-07 Stefan Monnier <monnier@iro.umontreal.ca>
5560
6b02f655
SM
5561 * buffer.c (syms_of_buffer) <enable-multibyte-characters>:
5562 Don't advertise functionality which we discourage or doesn't work.
a66cfb1c 5563
7c5ee88e
PE
55642011-10-07 Paul Eggert <eggert@cs.ucla.edu>
5565
5566 * alloc.c (GC_LISP_OBJECT_ALIGNMENT): Use offsetof, not __alignof__
5567 or sizeof. __alignof__ gives the wrong answer on Fedora x86-64
5568 with GCC 4.6.1 when configured with CC='gcc -m32' --with-wide-int;
5569 this makes Emacs dump core during garbage collection on rare
5570 occasions. sizeof is obviously inferior to offsetof here, so
5571 stick with offsetof.
5572 (GC_POINTER_ALIGNMENT): New macro.
5573 (mark_memory): Omit 3rd (offset) arg; caller changed.
5574 Don't assume EMACS_INT alignment is the same as pointer alignment.
5575
df1bbe5b
SM
55762011-10-03 Stefan Monnier <monnier@iro.umontreal.ca>
5577
5578 * keyboard.c (read_key_sequence_remapped): New var.
5579 (read_key_sequence): Compute remapping in the right buffer.
5580 (command_loop_1): Use read_key_sequence's remapping directly.
5581
51553db6
SM
55822011-10-02 Stefan Monnier <monnier@iro.umontreal.ca>
5583
32c1fffd
SM
5584 * dired.c (file_name_completion): Don't expand file name.
5585 (Ffile_name_completion, Ffile_name_all_completions): Expand file name
5586 before checking file name handler.
5587
51553db6
SM
5588 * minibuf.c (Finternal_complete_buffer): Only show internal buffers if
5589 they've been requested explicitly (bug#9591).
5590
b6bd1599 55912011-10-01 Andreas Schwab <schwab@linux-m68k.org>
fa2ec41f
AS
5592
5593 * keymap.c (Fsingle_key_description): Use make_specified_string
5594 instead of build_string to build string from push_key_description.
5595 (Bug#5193)
5596
f701dc2a
PE
55972011-09-30 Paul Eggert <eggert@cs.ucla.edu>
5598
4222c55d
PE
5599 * buffer.h (struct buffer): Use time_t, not int, for a time stamp.
5600 This fixes a Y2038 bug on 64-bit hosts.
5601 * buffer.c (reset_buffer):
5602 * fileio.c (Fdo_auto_save, Fset_buffer_auto_saved)
5603 (Fclear_buffer_auto_save_failure):
5604 Use 0, not -1, to represent an unset failure time, since time_t
5605 might not be signed.
5606
f701dc2a
PE
5607 Remove dependency on glibc malloc internals.
5608 * alloc.c (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
5609 Move back here from lisp.h, but with their new implementations.
5610 (XMALLOC_BASE_ALIGNMENT, COMMON_MULTIPLE, XMALLOC_HEADER_ALIGNMENT)
5611 (XMALLOC_OVERRUN_SIZE_SIZE): Move these new lisp.h macros here.
5612 * charset.c (charset_table_init): New static var.
5613 (syms_of_charset): Use it instead of xmalloc. This removes a
5614 dependency on glibc malloc internals. See Eli Zaretskii's comment in
5615 <http://lists.gnu.org/archive/html/emacs-devel/2011-09/msg00815.html>.
5616 * lisp.h (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
5617 Move back to alloc.c.
5618 (XMALLOC_BASE_ALIGNMENT, COMMON_MULTIPLE, XMALLOC_HEADER_ALIGNMENT)
5619 (XMALLOC_OVERRUN_SIZE_SIZE): Move to alloc.c.
5620
9ceebf39
JD
56212011-09-30 Jan Djärv <jan.h.d@swipnet.se>
5622
5623 * nsterm.m (windowDidResize): Call x_set_window_size only when
5624 ns_in_resize is true. Otherwise set pixelwidth/height and
5625 call change_frame_size (Bug#9628).
5626
cb993c58
PE
56272011-09-30 Paul Eggert <eggert@cs.ucla.edu>
5628
3930c88b
PE
5629 Port --enable-checking=all to Fedora 14 x86-64.
5630 * charset.c (syms_of_charset): Also account for glibc malloc's
5631 internal overhead when calculating the initial malloc maximum.
5632
cb993c58
PE
5633 Port --enable-checking=all to Fedora 14 x86.
5634 * alloc.c (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
5635 Move to lisp.h.
5636 (xmalloc_put_size, xmalloc_get_size, overrun_check_malloc)
5637 (overrun_check_realloc, overrun_check_free):
5638 Use XMALLOC_OVERRUN_SIZE_SIZE, not sizeof (size_t).
5639 That way, xmalloc returns a properly-aligned pointer even if
5640 XMALLOC_OVERRUN_CHECK is defined. The old debugging code happened
5641 to align OK on typical 64-bit hosts, but not on Fedora 14 x86.
5642 * charset.c (syms_of_charset): Take XMALLOC_OVERRUN_CHECK_OVERHEAD
5643 into account when calculating the initial malloc maximum.
5644 * lisp.h (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
5645 Move here from alloc.c, so that charset.c can use it too.
5646 Properly align; the old code wasn't right for common 32-bit hosts
5647 when configured with --enable-checking=all.
5648 (XMALLOC_BASE_ALIGNMENT, COMMON_MULTIPLE, XMALLOC_HEADER_ALIGNMENT)
5649 (XMALLOC_OVERRUN_SIZE_SIZE): New macros.
5650
31bed486
EZ
56512011-09-29 Eli Zaretskii <eliz@gnu.org>
5652
04c70788 5653 * sysdep.c (snprintf) [!EOVERFLOW]: If EOVERFLOW is not defined,
31bed486
EZ
5654 use EDOM.
5655
fbcaa2f3
EZ
56562011-09-28 Eli Zaretskii <eliz@gnu.org>
5657
5658 * xdisp.c (compute_display_string_end): If there's no display
5659 string at CHARPOS, return -1.
5660
5661 * bidi.c (bidi_fetch_char): When compute_display_string_end
5662 returns a negative value, treat the character as a normal
5663 character not covered by a display string. (Bug#9624)
5664
a239d4e9
JB
56652011-09-28 Juanma Barranquero <lekktu@gmail.com>
5666
5667 * lread.c (Fread_from_string): Fix typo in docstring.
5668
88652fd5
EZ
56692011-09-27 Eli Zaretskii <eliz@gnu.org>
5670
5671 * xdisp.c (handle_invisible_prop): If invisible text ends on a
5672 newline, reseat the iterator instead of bidi-iterating there one
5673 character at a time. (Bug#9610)
32c1fffd
SM
5674 (BUFFER_POS_REACHED_P, move_it_in_display_line_to): Bail when past
5675 TO_CHARPOS if the bidi iterator is at base embedding level.
88652fd5 5676
ed497dd4
AS
56772011-09-27 Andreas Schwab <schwab@linux-m68k.org>
5678
5679 * lread.c (readevalloop): Use correct code for NBSP.
5680 (read1): Likewise. (Bug#9608)
5681
b2bf61aa
MA
56822011-09-25 Michael Albinus <michael.albinus@gmx.de>
5683
5684 * dbusbind.c (Fdbus_register_signal): When service is not
5685 registered, use nil in Vdbus_registered_objects_table. (Bug#9581)
5686
32bbb17c
GM
56872011-09-25 Glenn Morris <rgm@gnu.org>
5688
5689 * buffer.c (truncate-lines): Doc fix.
5690
94e0933e
CY
56912011-09-24 Chong Yidong <cyd@stupidchicken.com>
5692
5693 * window.c (Fwindow_prev_buffers, Fset_window_prev_buffers)
5694 (Fset_window_next_buffers): Doc fix.
5695
cddde921
GM
56962011-09-24 Glenn Morris <rgm@gnu.org>
5697
5698 * minibuf.c (read_minibuf): Disable line truncation. (Bug#5715)
5699
1260aef1
PE
57002011-09-24 Paul Eggert <eggert@cs.ucla.edu>
5701
25b4bfa0
PE
5702 Fix minor problems found by static checking.
5703 * xdisp.c (string_from_display_spec): Don't assume vecsize fits in int.
1260aef1
PE
5704 * indent.c (Fvertical_motion): Fix == vs = typo.
5705
e3cbd34b
EZ
57062011-09-24 Eli Zaretskii <eliz@gnu.org>
5707
a66cfb1c
SM
5708 * dispnew.c (syms_of_display) <redisplay-dont-pause>:
5709 Default value is now t. Doc fix.
6bf7006f 5710
e3cbd34b 5711 * indent.c (Fvertical_motion): Compute and apply the overshoot
32c1fffd 5712 logic when moving up, not only when moving down. Fix the
e3cbd34b 5713 confusing name and values of the it_overshoot_expected variable;
32c1fffd 5714 logic changes accordingly. (Bug#9254) (Bug#9549)
e3cbd34b
EZ
5715
5716 * xdisp.c (pos_visible_p): Produce correct pixel coordinates when
5717 CHARPOS is covered by a display string which includes newlines.
5718 (move_it_vertically_backward): Avoid inflooping when START_CHARPOS
5719 is covered by a display string with embedded newlines.
5720
a3de0cbd
MA
57212011-09-24 Michael Albinus <michael.albinus@gmx.de>
5722
5723 * dbusbind.c (Fdbus_register_signal): Add match rule to
5724 Vdbus_registered_objects_table. (Bug#9581)
a66cfb1c
SM
5725 (Fdbus_register_method, Vdbus_registered_objects_table):
5726 Fix docstring.
a3de0cbd 5727
b260039d
JM
57282011-09-24 Jim Meyering <meyering@redhat.com>
5729
32c1fffd 5730 do not ignore write error for any output size
b260039d
JM
5731 The previous change was incomplete.
5732 While it makes emacs --batch detect the vast majority of stdout
5733 write failures, errors were still ignored whenever the output size is
5734 k * (BUFSIZ+1) - 4. E.g., on a system with BUFSIZ of 4096,
5735 $ emacs --batch --eval '(print (format "%4093d" 0))' > /dev/full \
5736 && echo FAIL: ignored write error
5737 FAIL: ignored write error
5738 $ emacs --batch --eval '(print (format "%20481d" 0))' > /dev/full \
5739 && echo FAIL: ignored write error
5740 FAIL: ignored write error
5741 * emacs.c (Fkill_emacs): Also test ferror. (Bug#9574)
5742
8eca8a7c
AS
57432011-09-23 Andreas Schwab <schwab@linux-m68k.org>
5744
5745 * emacs.c (Fkill_emacs): In noninteractive mode exit
5746 non-successfully if a write error occurred on stdout. (Bug#9574)
5747
3341db62
EZ
57482011-09-21 Eli Zaretskii <eliz@gnu.org>
5749
5750 * xdisp.c (pop_it): Allow it->object that is a cons cell to pass
5751 the xassert test.
5752
5753 * dispextern.h (struct it): Update the comment documenting what
5754 can it->OBJECT be.
5755
8c203dbf
EZ
57562011-09-20 Eli Zaretskii <eliz@gnu.org>
5757
5758 * xdisp.c (set_cursor_from_row): If the row ends in a newline from
5759 a display string, extend search for cursor position to end of row.
5760 (find_row_edges): If the row ends in a newline from a display
5761 string, increment its MATRIX_ROW_END_CHARPOS by one. (Bug#9549)
5762 Handle the case of a display string with multiple newlines.
fd317ddf
EZ
5763 (Fcurrent_bidi_paragraph_direction): Fix search for previous
5764 non-empty line. Fixes confusing cursor motion with arrow keys at
5765 the beginning of a line that starts with whitespace.
8c203dbf 5766
a4824228
LMI
57672011-09-19 Lars Magne Ingebrigtsen <larsi@gnus.org>
5768
5769 * lread.c (Fread_from_string): Document what FINAL-STRING-INDEX is
5770 (bug#9493).
5771
33ed493b
CY
57722011-09-18 Chong Yidong <cyd@stupidchicken.com>
5773
5774 * xfns.c (Fx_create_frame): Handle the bitmapIcon resource as
5775 boolean (Bug#9154).
5776
56cd55c8
EZ
57772011-09-18 Eli Zaretskii <eliz@gnu.org>
5778
5779 * xdisp.c (display_line): Record maximum and minimum buffer
5780 positions even if no glyphs were produced (e.g., by a zero-width
5781 stretch). Fixes bug#9530 on a TTY. Under word-wrap, don't record
5782 buffer positions that will be removed from the glyph row because
5783 they don't fit.
c02dcedf
EZ
5784 (produce_stretch_glyph): Fix a bug in :align-to on a TTY when the
5785 column is beyond frame width: don't subtract 1 "pixel" when
5786 computing width of the stretch.
3e62b7e0
EZ
5787 (reseat_at_next_visible_line_start): Undo the change made on
5788 2011-09-17 that saved paragraph information and restored it after
5789 the call to `reseat'. (Bug#9545)
56cd55c8 5790
5ed99d36 57912011-09-18 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
3390454c
YM
5792
5793 * xdisp.c (expose_window): Save original value of phys_cursor_on_p
5794 and turn window cursor on if cleared (Bug#9415).
5795
5ed99d36 57962011-09-18 Andreas Schwab <schwab@linux-m68k.org>
edb7b4dc
AS
5797
5798 * search.c (boyer_moore): Take unibyte characters from pattern
5799 literally. (Bug#9458)
5800
9bade7b2
EZ
58012011-09-18 Eli Zaretskii <eliz@gnu.org>
5802
5803 * xdisp.c (reseat_at_next_visible_line_start): Fix last change.
5804
e5e9d610
PE
58052011-09-18 Paul Eggert <eggert@cs.ucla.edu>
5806
87e4427a
PE
5807 Fix minor problem found by static checking.
5808 * xdisp.c (reseat_at_next_visible_line_start): Mark locals as
5809 initialized, to pacify gcc -Wuninitialized.
5810
e5e9d610
PE
5811 * fileio.c: Report proper errno when syscall falls.
5812 (Finsert_file_contents): Save and restore errno,
5813 so that report_file_error outputs the correct diagnostic.
5814 (Fwrite_region) [CLASH_DETECTION]: Likewise.
5815
a1674f0b
EZ
58162011-09-18 Eli Zaretskii <eliz@gnu.org>
5817
5818 * .gdbinit (pgx): Fix references to fields of `struct glyph'.
5819
fbfb6dd4
EZ
58202011-09-17 Eli Zaretskii <eliz@gnu.org>
5821
5822 * xdisp.c (produce_stretch_glyph): Another fix for changes made on
5823 2011-08-30T17:32:44Z!eliz@gnu.org. (Bug#9530)
5824
bb187662
EZ
58252011-09-17 Eli Zaretskii <eliz@gnu.org>
5826
1137e8b8 5827 * xdisp.c (reseat_at_next_visible_line_start): Keep information
6b02f655 5828 about the current paragraph and restore it after the call to reseat.
1137e8b8
EZ
5829
5830 * bidi.c (MAX_PARAGRAPH_SEARCH): New macro.
5831 (bidi_find_paragraph_start): Search back for paragraph beginning
5832 at most MAX_PARAGRAPH_SEARCH lines; if not found, return BEGV_BYTE.
5833 (bidi_move_to_visually_next): Only trigger paragraph-related
5834 computations when the last character is a newline or at EOB, not
5835 just any NEUTRAL_B. (Bug#9470)
5836
bb187662
EZ
5837 * xdisp.c (set_cursor_from_row): Don't invoke special treatment of
5838 truncated lines if point is covered by a display string. (Bug#9524)
5839
2e621251
PE
58402011-09-16 Paul Eggert <eggert@cs.ucla.edu>
5841
5842 * xselect.c: Relax test for outgoing X longs (Bug#9498).
5843 (cons_to_x_long): New function.
5844 (lisp_data_to_selection_data): Use it. Correct the test for
5845 short-versus-long data; it was negated. Break out of vector
5846 loop, for efficiency, when a long datum is discovered.
5847
91a15bc6
SM
58482011-09-16 Stefan Monnier <monnier@iro.umontreal.ca>
5849
5850 * eval.c (Fquote): Document its non-consing behavior (bug#9482).
5851
b41c3a35
EZ
58522011-09-16 Eli Zaretskii <eliz@gnu.org>
5853
5854 * image.c (tiff_handler): Work around a bug in MinGW GCC 3.x (see
5855 GCC PR/17406) by declaring this function with external scope.
5856
7812ba2d
PE
58572011-09-15 Paul Eggert <eggert@cs.ucla.edu>
5858
5859 * editfns.c (Fformat): Fix bug in text-property fix (Bug#9514).
5860 Don't mishandle (length (format "%%")) and (format "%4000s%%" "").
5861
cf7edc2a
AS
58622011-09-15 Andreas Schwab <schwab@linux-m68k.org>
5863
5864 * editfns.c (Fformat): Correctly handle text properties on "%%".
5865
bd01620e
EZ
58662011-09-15 Eli Zaretskii <eliz@gnu.org>
5867
5868 * xterm.c (x_draw_composite_glyph_string_foreground):
5869 * w32term.c (x_draw_composite_glyph_string_foreground):
5870 * term.c (encode_terminal_code):
5871 * composite.c (composition_update_it, get_composition_id):
5872 * xdisp.c (get_next_display_element)
5873 (fill_composite_glyph_string): Add comments about special meaning
5874 of TAB characters in a composition.
5875
a02719a3
PE
58762011-09-15 Paul Eggert <eggert@cs.ucla.edu>
5877
5878 * editfns.c (Fformat): Fix off-by-1 bug for "%%b" (Bug#9514).
4c122725
PE
5879 This occurs when processing a multibyte format.
5880 Problem reported by Wolfgang Jenker.
a02719a3 5881
72589a3c
JB
58822011-09-15 Johan Bockgård <bojohan@gnu.org>
5883
5884 * xdisp.c (try_cursor_movement): Only check for exact match if
5885 cursor hpos found by set_cursor_from_row is valid. (Bug#9495)
5886
1c14176c
PE
58872011-09-14 Paul Eggert <eggert@cs.ucla.edu>
5888
5889 Remove unused external symbols.
5890 * dispextern.h (calc_pixel_width_or_height): Remove decl.
5891 * xdisp.c (calc_pixel_width_or_height): Now static.
5892 * doprnt.c (exprintf) [! (HAVE_X_WINDOWS && USE_X_TOOLKIT)]: Remove.
5893 * indent.c (check_display_width):
5894 * w32term.c: Fix comment to match code.
5895 * xterm.c, xterm.h (x_catching_errors): Remove.
5896
d2eea5b5
PE
58972011-09-14 Paul Eggert <eggert@cs.ucla.edu>
5898
5899 * xselect.c: Use signed conversions more consistently (Bug#9498).
5900 (selection_data_to_lisp_data): Assume incoming selection data are
5901 signed integers, not unsigned. This is to be consistent with
5902 outgoing selection data, which was modified to use signed integers
5903 in as part of the fix to Bug#9196 in response to Jan D.'s comment
5904 in <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=9196#32> that X11
5905 expects long, not unsigned long.
5906
46888499
EZ
59072011-09-14 Eli Zaretskii <eliz@gnu.org>
5908
5909 * xdisp.c (try_window_reusing_current_matrix): Fix incorrect
5910 computation of loop end. Reported by Johan Bockgård
5911 <bojohan@gnu.org>.
5912
ef8ef9fb
CY
59132011-09-13 Chong Yidong <cyd@stupidchicken.com>
5914
5915 * frame.c (Fother_visible_frames_p): Function deleted.
5916
fa819fed
EZ
59172011-09-12 Eli Zaretskii <eliz@gnu.org>
5918
5919 * indent.c (compute_motion): Process display vector front to back
5920 rather than the other way around. (Bug#2496)
5921
2ba8e008
SM
59222011-09-12 Stefan Monnier <monnier@iro.umontreal.ca>
5923
5924 * fileio.c (Finsert_file_contents): Don't assume beg_offset is 0.
5925
20f53c69
CY
59262011-09-11 Chong Yidong <cyd@stupidchicken.com>
5927
5928 * minibuf.c (Fread_from_minibuffer): Doc fix.
5929
d562d7a4
EZ
59302011-09-11 Eli Zaretskii <eliz@gnu.org>
5931
5932 * xdisp.c (produce_stretch_glyph): Fix a typo made in changes from
5933 2011-08-30T17:32:44Z!eliz@gnu.org. (Bug#9475)
5934
1c4d7f3d
LMI
59352011-09-11 Lars Magne Ingebrigtsen <larsi@gnus.org>
5936
5937 * fileio.c (Fvisited_file_modtime): Document `(-1 65535)' as a
5938 value for non-existent files.
5939
b885bf36
EZ
59402011-09-11 Eli Zaretskii <eliz@gnu.org>
5941
5942 * fileio.c (Finsert_file_contents): If the file cannot be opened,
5943 set its "size" to -1. This will set the modtime_size field of
5944 the corresponding buffer to -1, which is what
5945 verify-visited-file-modtime expects for files that do not exist.
5946 (Bug#9139)
5947
6612f0bf
PE
59482011-09-11 Paul Eggert <eggert@cs.ucla.edu>
5949
5950 * keymap.h (KEY_DESCRIPTION_SIZE, push_key_description): Move decls
5951 here ...
5952 * lisp.h: ... from here. push_key_description is no longer
5953 defined in keyboard.c, so its declaration should not be in
5954 lisp.h's "Defined in keyboard.c" section, and KEY_DESCRIPTION_SIZE
5955 logically belongs with push_key_description.
5956
dfb3f755
PE
59572011-09-10 Paul Eggert <eggert@cs.ucla.edu>
5958
5959 * buffer.h: Include <sys/types.h> instead of <time.h>.
5960 Otherwise, off_t wasn't defined on FreeBSD 9.0-BETA2 i386.
5961 Problem reported by Herbert J. Skuhra.
5962
3134906c
LMI
59632011-09-10 Lars Magne Ingebrigtsen <larsi@gnus.org>
5964
5965 * xml.c (parse_region): Make the parsing work for
5966 non-comment-starting XML files again (bug#9144).
5967
8d903f4e
AS
59682011-09-10 Andreas Schwab <schwab@linux-m68k.org>
5969
5970 * image.c (gif_load): Fix calculation of bottom and right corner.
5971 (Bug#9468)
5972
80ad64f4
EZ
59732011-09-10 Eli Zaretskii <eliz@gnu.org>
5974
5975 * xdisp.c (MAX_DISP_SCAN): Decrease to 250. Prevents sluggish
5976 redisplay in small windows.
5977
208a048d
EZ
59782011-09-09 Eli Zaretskii <eliz@gnu.org>
5979
5980 * frame.c (x_report_frame_params): Cast to avoid compiler warnings.
5981
9b1c252e
MR
59822011-09-08 Martin Rudalics <rudalics@gmx.at>
5983
5984 * window.c (Fset_window_prev_buffers, Fset_window_next_buffers):
5985 Operate on live windows only.
5986
2949f33b
JB
59872011-09-08 Juanma Barranquero <lekktu@gmail.com>
5988
5989 * emacs.c (my_heap_start): #ifdef to avoid warnings when unused.
5990
e08dcafd
EZ
59912011-09-07 Eli Zaretskii <eliz@gnu.org>
5992
5993 * xdisp.c (move_it_in_display_line_to): Call RESTORE_IT on ppos_it
5994 only under bidi iteration.
5995
115b96bd
JD
59962011-09-07 Jan Djärv <jan.h.d@swipnet.se>
5997
5998 * gtkutil.c (xg_make_tool_item): Insert comment about eventbox.
5999
c8199d0f
PE
60002011-09-06 Paul Eggert <eggert@cs.ucla.edu>
6001
6002 isnan: Fix porting problem to Solaris 10 with bundled gcc.
6003 Without this fix, the command to link temacs failed due to an
6004 undefined symbol __builtin_isnan. This is because
6005 /usr/include/iso/math_c99.h #defines isnan(x) to
6006 __builtin_isnan(x), but the bundled gcc, which identifies itself
6007 as gcc 3.4.3 (csl-sol210-3_4-branch+sol_rpath), does not have
6008 a __builtin_isnan.
6009 * floatfns.c (isnan): #undef, and then #define to a clone of
6010 what's in data.c.
6011 (Fisnan): Always define, since it's always available now.
6012 (syms_of_floatfns): Always define isnan at the Lisp level.
6013
e39b275c 60142011-09-06 Paul Eggert <eggert@cs.ucla.edu>
1c262cae
PE
6015
6016 * Makefile.in (gl-stamp): move-if-change now in build-aux (Bug#9169).
6017
b2db44d9 60182011-09-06 Paul Eggert <eggert@cs.ucla.edu>
728f8f0a 6019
f4af5137 6020 * fileio.c: Fix bugs with large file offsets (Bug#9428).
728f8f0a
PE
6021 The previous code assumed that file offsets (off_t values) fit in
6022 EMACS_INT variables, which is not true on typical 32-bit hosts.
6023 The code messed up by falsely reporting buffer overflow in cases
6024 such as (insert-file-contents "big" nil 1 2) into an empty buffer
6025 when "big" contains more than 2**29 bytes, even though this
6026 inserts just one byte and does not overflow the buffer.
6027 (Finsert_file_contents): Store file offsets as off_t
6028 values, not as EMACS_INT values. Check for overflow when
6029 converting between EMACS_INT and off_t. When checking for
6030 buffer overflow or for overlap, take the offsets into account.
6031 Don't use EMACS_INT for small values where int suffices.
6032 When checking for overlap, fix a typo: ZV was used where
6033 ZV_BYTE was intended.
6034 (Fwrite_region): Don't assume off_t fits into 'long'.
6035 * buffer.h (struct buffer.modtime_size): Now off_t, not EMACS_INT.
6036
ecfc0a49
MA
60372011-09-05 Michael Albinus <michael.albinus@gmx.de>
6038
6039 * dbusbind.c (xd_signature_cat): Rename from signature_cat.
6040
6511acf2 60412011-09-04 Paul Eggert <eggert@cs.ucla.edu>
61bfeeb7 6042
0999621a 6043 sprintf-related integer and memory overflow issues (Bug#9412).
62f19c19
PE
6044
6045 * doprnt.c (doprnt): Support printing ptrdiff_t and intmax_t values.
8666506e 6046 (esprintf, exprintf, evxprintf): New functions.
62f19c19 6047 * keyboard.c (command_loop_level): Now EMACS_INT, not int.
6b02f655 6048 (cmd_error): Kbd macro iterations count is now EMACS_INT, not int.
62f19c19
PE
6049 (modify_event_symbol): Do not assume that the length of
6050 name_alist_or_stem is safe to alloca and fits in int.
6051 (Fexecute_extended_command): Likewise for function name and binding.
6052 (Frecursion_depth): Wrap around reliably on integer overflow.
6053 * keymap.c (push_key_description): First arg is now EMACS_INT, not int,
6054 since some callers pass EMACS_INT values.
6055 (Fsingle_key_description): Don't crash if symbol name contains more
6056 than MAX_ALLOCA bytes.
6057 * minibuf.c (minibuf_level): Now EMACS_INT, not int.
6058 (get_minibuffer): Arg is now EMACS_INT, not int.
6059 * lisp.h (get_minibuffer, push_key_description): Reflect API changes.
8666506e 6060 (esprintf, exprintf, evxprintf): New decls.
62f19c19
PE
6061 * window.h (command_loop_level, minibuf_level): Reflect API changes.
6062
2be7d702
PE
6063 * dbusbind.c (signature_cat): New function.
6064 (xd_signature, Fdbus_register_signal):
2ea16b89
PE
6065 Do not overrun buffer; instead, report string overflow.
6066
9d1df220
PE
6067 * dispnew.c (add_window_display_history): Don't overrun buffer.
6068 Truncate instead; this is OK since it's just a log.
6069
33ef5c64
PE
6070 * editfns.c (Fcurrent_time_zone): Don't overrun buffer
6071 even if the time zone offset is outlandishly large.
6072 Don't mishandle offset == INT_MIN.
6073
66c6fdd5
PE
6074 * emacs.c (main) [NS_IMPL_COCOA]: Don't overrun buffer
6075 when creating daemon; the previous buffer-overflow check was incorrect.
6076
d749b01b
PE
6077 * eval.c (verror): Simplify by rewriting in terms of evxprintf,
6078 which has the guts of the old verror function.
6079
b5cd1905
PE
6080 * filelock.c (lock_file_1, lock_file): Don't blindly alloca long name;
6081 use SAFE_ALLOCA instead. Use esprintf to avoid int-overflow issues.
6082
6e1a67fb
PE
6083 * font.c: Include <float.h>, for DBL_MAX_10_EXP.
6084 (font_unparse_xlfd): Don't blindly alloca long strings.
c21721cc 6085 Don't assume XINT result fits in int, or that XFLOAT_DATA * 10
8666506e 6086 fits in int, when using sprintf. Use single snprintf to count
c21721cc
PE
6087 length of string rather than counting it via multiple sprintfs;
6088 that's simpler and more reliable.
c21721cc
PE
6089 (font_unparse_fcname): Use it to avoid sprintf buffer overrun.
6090 (generate_otf_features) [0 && HAVE_LIBOTF]: Use esprintf, not
6091 sprintf, in case result does not fit in int.
6092
c57b67fc
PE
6093 * fontset.c (num_auto_fontsets): Now printmax_t, not int.
6094 (fontset_from_font): Print it.
6095
8a401434
PE
6096 * frame.c (tty_frame_count): Now printmax_t, not int.
6097 (make_terminal_frame, set_term_frame_name): Print it.
6098 (x_report_frame_params): In X, window IDs are unsigned long,
6099 not signed long, so print them as unsigned.
6100 (validate_x_resource_name): Check for implausibly long names,
6101 and don't assume name length fits in 'int'.
6102 (x_get_resource_string): Don't blindly alloca invocation name;
6103 use SAFE_ALLOCA. Use esprintf, not sprintf, in case result does
6104 not fit in int.
6105
6e1a67fb
PE
6106 * gtkutil.c: Include <float.h>, for DBL_MAX_10_EXP.
6107 (xg_check_special_colors, xg_set_geometry):
84722b3d
PE
6108 Make sprintf buffers a bit bigger, to avoid potential buffer overrun.
6109
0df02bf3
PE
6110 * lread.c (dir_warning): Don't blindly alloca buffer; use SAFE_ALLOCA.
6111 Use esprintf, not sprintf, in case result does not fit in int.
6112
48e30793
PE
6113 * macros.c (executing_kbd_macro_iterations): Now EMACS_INT, not int.
6114 (Fend_kbd_macro): Don't mishandle MOST_NEGATIVE_FIXNUM by treating
6115 it as a large positive number.
6116 (Fexecute_kbd_macro): Don't assume repeat count fits in int.
6117 * macros.h (executing_kbd_macro_iterations): Now EMACS_INT, not int.
6118
a66ff6d8
PE
6119 * nsterm.m ((NSSize)windowWillResize): Use esprintf, not sprintf,
6120 in case result does not fit in int.
6121
aca216ff
PE
6122 * print.c (float_to_string): Detect width overflow more reliably.
6123 (print_object): Make sprintf buffer a bit bigger, to avoid potential
6124 buffer overrun. Don't assume list length fits in 'int'. Treat
6125 print length of 0 as 0, not as infinity; to be consistent with other
6126 uses of print length in this function. Don't overflow print length
6127 index. Don't assume hash table size fits in 'long', or that
6128 vectorlike size fits in 'unsigned long'.
6129
31c286f7
PE
6130 * process.c (make_process): Use printmax_t, not int, to format
6131 process-name gensyms.
6132
55e5faa1
PE
6133 * sysdep.c (snprintf) [! HAVE_SNPRINTF]: New function.
6134
80f2e268
PE
6135 * term.c (produce_glyphless_glyph): Make sprintf buffer a bit bigger
6136 to avoid potential buffer overrun.
6137
670741ab
PE
6138 * xfaces.c (x_update_menu_appearance): Don't overrun buffer
6139 if X resource line is longer than 512 bytes.
6140
b7163a50
PE
6141 * xfns.c (x_window): Make sprintf buffer a bit bigger
6142 to avoid potential buffer overrun.
6143
ae58ff1f
PE
6144 * xterm.c (x_io_error_quitter): Don't overrun sprintf buffer.
6145
c43c8a6a
PE
6146 * xterm.h (x_check_errors): Add ATTRIBUTE_FORMAT_PRINTF.
6147
3f8236f4
PE
61482011-09-04 Paul Eggert <eggert@cs.ucla.edu>
6149
53e9fe90 6150 Integer overflow fixes for scrolling, etc.
6511acf2
PE
6151 Without these, Emacs silently mishandles large integers sometimes.
6152 For example, "C-u 4294967297 M-x recenter" was treated as if
53e9fe90
PE
6153 it were "C-u 1 M-x recenter" on a typical 64-bit host.
6154
6511acf2
PE
6155 * xdisp.c (try_window_id): Check Emacs fixnum range before
6156 converting to 'int'.
806add1d 6157
6511acf2 6158 * window.c (window_scroll_line_based, Frecenter):
71f02bc5
PE
6159 Check that an Emacs fixnum is in range before assigning it to 'int'.
6160 (Frecenter, Fmove_to_window_line): Use EMACS_INT, not int, for
6161 values converted from Emacs fixnums.
6162 (Frecenter): Don't wrap around a line count if it is out of 'int'
6163 range; instead, treat it as an extreme value.
6164 (Fset_window_configuration, compare_window_configurations):
6165 Use ptrdiff_t, not int, for index that might exceed 2 GiB.
6166
6511acf2
PE
6167 * search.c (Freplace_match): Use ptrdiff_t, not int, for indexes
6168 that can exceed INT_MAX. Check that EMACS_INT value is in range
6169 before assigning it to the (possibly-narrower) index.
a0efffc8
PE
6170 (match_limit): Don't assume that a fixnum can fit in 'int'.
6171
6511acf2 6172 * print.c (print_object): Use ptrdiff_t, not int, for index that can
29ebea3b
PE
6173 exceed INT_MAX.
6174
6511acf2 6175 * indent.c (position_indentation): Now takes ptrdiff_t, not int.
3f8236f4
PE
6176 (Fvertical_motion): Don't wrap around LINES values that don't fit
6177 in 'int'. Instead, treat them as extreme values. This is good
6178 enough for windows, which can't have more than INT_MAX lines anyway.
6179
fcb901a7
LMI
61802011-09-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
6181
0f2f6b6d
LMI
6182 * Require libxml/parser.h to avoid compilation warning.
6183
fcb901a7
LMI
6184 * emacs.c (shut_down_emacs): Call xmlCleanupParser on shutdown.
6185
6186 * xml.c (parse_region): Don't call xmlCleanupParser after parsing,
6187 since this reportedly can destroy thread storage.
6188
6e20a0d4
CY
61892011-08-30 Chong Yidong <cyd@stupidchicken.com>
6190
6191 * syntax.c (find_defun_start): Update all cache variables if
6192 exiting early (Bug#9401).
6193
148ae00e
EZ
61942011-08-30 Eli Zaretskii <eliz@gnu.org>
6195
f6cfbd8f
EZ
6196 * image.c (x_bitmap_pixmap): Cast to int to avoid compiler warnings.
6197
148ae00e
EZ
6198 * xdisp.c (produce_stretch_glyph): No longer static, compiled also
6199 when HAVE_WINDOW_SYSTEM is not defined. Support both GUI and TTY
6200 frames. Call tty_append_glyph in the TTY case. (Bug#9402)
6201
6202 * term.c (tty_append_glyph): New function.
6203 (produce_stretch_glyph): Static function and its prototype deleted.
6204
a66cfb1c
SM
6205 * dispextern.h (produce_stretch_glyph, tty_append_glyph):
6206 Add prototypes.
148ae00e 6207
c4a07a4c
PE
62082011-08-29 Paul Eggert <eggert@cs.ucla.edu>
6209
6210 * image.c (parse_image_spec): Check for nonnegative, not for positive,
6211 when checking :margin (Bug#9390).
6212 (IMAGE_NON_NEGATIVE_INTEGER_VALUE_OR_PAIR):
a66cfb1c 6213 Rename from IMAGE_POSITIVE_INTEGER_VALUE_OR_PAIR,
c4a07a4c
PE
6214 so that the name doesn't mislead. All uses changed.
6215
6bc8cd65
JB
62162011-08-28 Johan Bockgård <bojohan@gnu.org>
6217
6218 * term.c (init_tty) [HAVE_GPM]: Move mouse settings after
6219 set_tty_hooks.
6220
dca4927e
EZ
62212011-08-27 Eli Zaretskii <eliz@gnu.org>
6222
6223 * xdisp.c (move_it_to): Don't bail out early when reaching
6224 position beyond to_charpos, if we are scanning backwards.
6225 (move_it_vertically_backward): When DY == 0, make sure we get to
6226 the first character in the line after the newline.
6227
f2cad773
PE
62282011-08-27 Paul Eggert <eggert@cs.ucla.edu>
6229
6230 * ccl.c: Improve and simplify overflow checking (Bug#9196).
6231 (ccl_driver): Do not generate an out-of-range pointer.
6232 (Fccl_execute_on_string): Remove unnecessary check for
6233 integer overflow, noted by Stefan Monnier in
6234 <http://lists.gnu.org/archive/html/emacs-devel/2011-08/msg00979.html>.
6235 Remove a FIXME that didn't need fixing.
6236 Simplify the newly-introduced buffer reallocation code.
6237
0cae2cdb
JB
62382011-08-27 Juanma Barranquero <lekktu@gmail.com>
6239
6240 * makefile.w32-in ($(BLD)/alloc.$(O)): Depend on lib/verify.h.
6241
5fc295a4 62422011-08-26 Paul Eggert <eggert@cs.ucla.edu>
ddff3151 6243
70c60eb2 6244 Integer and memory overflow issues (Bug#9196).
726e0ab1 6245
d31850da
PE
6246 * doc.c (get_doc_string): Rework so that
6247 get_doc_string_buffer_size is the actual buffer size, rather than
6248 being 1 less than the actual buffer size; this makes xpalloc more
6249 convenient.
6250
a69fbedb
PE
6251 * image.c (x_allocate_bitmap_record, cache_image):
6252 * xselect.c (Fx_register_dnd_atom):
6253 Simplify previous changes by using xpalloc.
6254
fe5c5d37
PE
6255 * buffer.c (overlay_str_len): Now ptrdiff_t, not EMACS_INT,
6256 since either will do and ptrdiff_t is convenient with xpalloc.
6257
0065d054
PE
6258 * charset.c (charset_table_size)
6259 (struct charset_sort_data.priority): Now ptrdiff_t.
6260 (charset_compare): Don't overflow if priorities differ greatly.
6261 (Fsort_charsets): Don't assume list length fits in int.
6262 Check for size-calculation overflow when allocating sort data.
6263 (syms_of_charset): Allocate an initial charset table that is
6264 just under 64 KiB, to avoid problems with glibc malloc and mmap.
6265
6266 * cmds.c (internal_self_insert): Check for size-calculation overflow.
6267
6268 * composite.h (struct composition.glyph_len): Now int, not unsigned.
6269 The actual value is always <= INT_MAX, and leaving it unsigned made
6270 overflow checking harder.
6271
6272 * dispextern.h (struct glyph_matrix.rows_allocated)
6273 (struct face_cache.size): Now ptrdiff_t, for convenience in use
6274 with xpalloc. The values are still always <= INT_MAX.
6275
6276 * indent.c (compute_motion): Adjust to region_cache_forward sig change.
6277
6278 * lisp.h (xnmalloc, xnrealloc, xpalloc): New decls.
6279 (SAFE_NALLOCA): New macro.
6280
6281 * region-cache.c (struct boundary.pos, find_cache_boundary)
6282 (move_cache_gap, insert_cache_boundary, delete_cache_boundaries)
6283 (set_cache_region, invalidate_region_cache)
6284 (revalidate_region_cache, know_region_cache, region_cache_forward)
6285 (region_cache_backward, pp_cache):
6286 Use ptrdiff_t, not EMACS_INT, since either will do. This is needed
6287 so that ptrdiff_t * can be passed to xpalloc.
6288 (struct region_cache): Similarly, for gap_start, gap_len, cache_len,
6289 beg_unchanged, end_unchanged, buffer_beg, buffer_end members.
6290 (pp_cache): Don't assume cache_len fits in int.
6291 * region-cache.h: Adjust extern decls to match.
6292
6293 * search.c (scan_buffer, Freplace_match): Use ptrdiff_t, not
6294 EMACS_INT, since either will do, for xpalloc.
6295
6296 * alloc.c: Include verify.h, and check that int fits in ptrdiff_t.
6297 (xnmalloc, xnrealloc, xpalloc): New functions.
6298
726e0ab1
PE
6299 * bidi.c (bidi_shelve_header_size): New constant.
6300 (bidi_cache_ensure_space, bidi_shelve_cache): Use it.
6301 (bidi_cache_ensure_space): Avoid integer overflow when allocating.
6302
51f30bc5 6303 * bidi.c (bidi_cache_shrink):
726e0ab1
PE
6304 * buffer.c (overlays_at, overlays_in, record_overlay_string)
6305 (overlay_strings):
6306 Don't update size of array until after memory allocation succeeds,
6307 because xmalloc/xrealloc may not return.
0065d054
PE
6308 (struct sortstrlist.bytes): Now ptrdiff_t, as EMACS_INT doesn't help
6309 now that we have proper integer overflow checking.
6310 (record_overlay_string, overlay_strings): Catch overflows when
6311 calculating size of overlay_str_buf.
726e0ab1 6312
0065d054
PE
6313 * callproc.c (Fcall_process): Check for size overflow when
6314 calculating size of args2.
6315 (child_setup): Avoid overflow by using size_t rather than ptrdiff_t.
6316 Normally we prefer signed values, but sticking with ptrdiff_t would
6317 require adding more-complicated checks.
726e0ab1
PE
6318
6319 * ccl.c (Fccl_execute_on_string): Check for memory overflow.
6320 Use ptrdiff_t rather than EMACS_INT where ptrdiff_t will do.
6321 Redo buffer-overflow calculations to avoid integer overflow.
0065d054 6322 Add a FIXME comment where memory seems to be over-allocated.
726e0ab1
PE
6323
6324 * character.c (Fstring): Check for size-calculation overflow.
6325
6326 * coding.c (produce_chars): Redo buffer-overflow calculations to avoid
6327 unnecessary integer overflow. Check for size overflow.
6328 (encode_coding_object): Don't update size until xmalloc succeeds.
6329
6330 * composite.c (get_composition_id): Check for overflow in glyph
6331 length calculations.
6332
6333 Integer and memory overflow fixes for display code.
6334 * dispextern.h (struct glyph_pool.nglyphs): Now ptrdiff_t, not int.
6335 * dispnew.c (adjust_glyph_matrix, realloc_glyph_pool)
6336 (scrolling_window): Check for overflow in size calculations.
6337 (line_draw_cost, realloc_glyph_pool, add_row_entry):
6338 Don't assume glyph table len fits in int.
6339 (struct row_entry.bucket, row_entry_pool_size, row_entry_idx)
6340 (row_table_size): Now ptrdiff_t, not int.
6341 (scrolling_window): Avoid overflow in size calculations.
6342 Don't update size until allocation succeeds.
6343 * fns.c (concat): Check for overflow in size calculations.
6344 (next_almost_prime): Verify NEXT_ALMOST_PRIME_LIMIT.
6345 * lisp.h (RANGED_INTEGERP, TYPE_RANGED_INTEGERP): New macros.
6346 (NEXT_ALMOST_PRIME_LIMIT): New constant.
6347
6348 * doc.c (get_doc_string_buffer_size): Now ptrdiff_t, not int.
6349 (get_doc_string): Check for size calculation overflow.
6350 Don't update size until allocation succeeds.
6351 (get_doc_string, Fsubstitute_command_keys): Use ptrdiff_t, not
6352 EMACS_INT, where ptrdiff_t will do.
6353 (Fsubstitute_command_keys): Check for string overflow.
6354
6355 * editfns.c (set_time_zone_rule): Don't assume environment length
6356 fits in int.
6357 (message_length): Now ptrdiff_t, not int.
6358 (Fmessage_box): Don't update size until allocation succeeds.
6359 Don't assume message length fits in int.
6360 (Fformat): Use ptrdiff_t, not EMACS_INT, where ptrdiff_t will do.
6361
0065d054
PE
6362 * emacs.c (main): Do not reallocate argv, since there is a null at
6363 the end that can be overwritten, and this way there's no need to
6364 worry about size-calculation overflow.
6365 (sort_args): Check for size-calculation overflow.
726e0ab1
PE
6366
6367 * eval.c (init_eval_once, grow_specpdl): Don't update size until
6368 alloc succeeds.
6369 (call_debugger, grow_specpdl): Redo calculations to avoid overflow.
6370
6371 * frame.c (set_menu_bar_lines, x_set_frame_parameters)
6372 (x_set_scroll_bar_width, x_figure_window_size):
6373 Check for integer overflow.
6374 (x_set_alpha): Do not assume XINT fits in int.
6375
6376 * frame.h (struct frame): Use int, not EMACS_INT, where int works.
6377 This is for the members text_lines, text_cols, total_lines, total_cols,
6378 where the system imposes an 'int' limit.
6379
6380 * fringe.c (Fdefine_fringe_bitmap):
6381 Don't update size until alloc works.
6382
6383 * ftfont.c (ftfont_get_open_type_spec, setup_otf_gstring)
6384 (ftfont_shape_by_flt): Check for integer overflow in size calculations.
6385
6386 * gtkutil.c (get_utf8_string, xg_store_widget_in_map):
6387 Check for size-calculation overflow.
6388 (get_utf8_string): Use ptrdiff_t, not size_t, where either will
6389 do, as we prefer signed integers.
6390 (id_to_widget.max_size, id_to_widget.used)
6391 (xg_store_widget_in_map, xg_remove_widget_from_map)
6392 (xg_get_widget_from_map, xg_get_scroll_id_for_window)
6393 (xg_remove_scroll_bar, xg_update_scrollbar_pos):
6394 Use and return ptrdiff_t, not int.
6395 (xg_gtk_scroll_destroy): Don't assume ptrdiff_t fits in int.
6396 * gtkutil.h: Change prototypes to match the above.
6397
6398 * image.c (RANGED_INTEGERP, TYPE_RANGED_INTEGERP): Remove; these
6399 are duplicate now that they've been promoted to lisp.h.
6400 (x_allocate_bitmap_record, x_alloc_image_color)
6401 (make_image_cache, cache_image, xpm_load):
6402 Don't update size until alloc is done.
6403 (xpm_load, lookup_rgb_color, lookup_pixel_color, x_to_xcolors)
6404 (x_detect_edges):
3256efce 6405 Check for size calculation overflow.
726e0ab1
PE
6406 (ct_colors_allocated_max): New constant.
6407 (x_to_xcolors, x_detect_edges): Reorder multiplicands to avoid
6408 overflow.
3256efce 6409
726e0ab1
PE
6410 * keyboard.c (read_char, menu_bar_items, tool_bar_items)
6411 (read_char_x_menu_prompt, read_char_minibuf_menu_width)
6412 (read_char_minibuf_menu_prompt, follow_key, read_key_sequence):
6413 Use ptrdiff_t, not int, to count maps.
6414 (read_char_minibuf_menu_prompt): Check for overflow in size
a66cfb1c
SM
6415 calculations. Don't update size until allocation succeeds.
6416 Redo calculations to avoid overflow.
726e0ab1
PE
6417 * keyboard.h: Change prototypes to match the above.
6418
6419 * keymap.c (cmm_size, current_minor_maps): Use ptrdiff_t, not int,
6420 to count maps.
6421 (current_minor_maps): Check for size calculation overflow.
6422 * keymap.h: Change prototypes to match the above.
6423
6424 * lread.c (read1, init_obarray): Don't update size until alloc done.
6425
6426 * macros.c (Fstart_kbd_macro): Don't update size until alloc done.
6427 (store_kbd_macro_char): Reorder multiplicands to avoid overflow.
6428
726e0ab1
PE
6429 * nsterm.h (struct ns_color_table.size, struct ns_color_table.avail):
6430 Now ptrdiff_t, not int.
6431 * nsterm.m (ns_index_color): Use ptrdiff_t, not int, for table indexes.
6432 (ns_draw_fringe_bitmap): Rewrite to avoid overflow.
6433
6434 * process.c (Fnetwork_interface_list): Check for overflow
6435 in size calculation.
6436
6437 * region-cache.c (move_cache_gap): Check for size calculation overflow.
6438
6439 * scroll.c (do_line_insertion_deletion_costs): Check for size calc
6440 overflow. Don't bother calling xmalloc when xrealloc will do.
6441
6442 * search.c (Freplace_match): Check for size calculation overflow.
6443 (Fset_match_data): Don't assume list lengths fit in 'int'.
6444
6445 * sysdep.c (system_process_attributes): Use ptrdiff_t, not int,
6446 for command line length. Do not attempt to address one before the
6447 beginning of an array, as that's not portable.
6448
6449 * term.c (max_frame_lines): Remove; unused.
6450 (encode_terminal_src_size, encode_terminal_dst_size): Now ptrdiff_t,
6451 not int.
6452 (encode_terminal_code, calculate_costs): Check for size
6453 calculation overflow.
6454 (encode_terminal_code): Use ptrdiff_t, not int, to record glyph
6455 table lengths and related sizes. Don't update size until alloc
6456 done. Redo calculations to avoid overflow.
6457 (calculate_costs): Don't bother calling xmalloc when xrealloc will do.
6458
6459 * termcap.c (tgetent): Use ptrdiff_t, not int, to record results of
6460 subtracting pointers.
6461 (gobble_line): Check for overflow more carefully. Don't update size
6462 until alloc done.
6463
6464 * tparam.c (tparam1): Use ptrdiff_t, not int, for sizes.
6465 Don't update size until alloc done.
6466 Redo size calculations to avoid overflow.
6467 Check for size calculation overflow.
0065d054 6468 (main) [DEBUG]: Fix typo in invoking tparam1.
726e0ab1
PE
6469
6470 * xdisp.c (store_mode_line_noprop_char, x_consider_frame_title):
6471 Use ptrdiff_t, not int, for sizes.
6472 (store_mode_line_noprop_char): Don't update size until alloc done.
6473
0065d054
PE
6474 * xfaces.c (lface_id_to_name_size, Finternal_make_lisp_face):
6475 Use ptrdiff_t, not int, for sizes.
6476 (Finternal_make_lisp_face, cache_face):
6477 Check for size calculation overflow.
6478 (cache_face): Treat size calculation overflows as if they were
6479 memory exhaustion (the usual treatment), rather than aborting.
726e0ab1
PE
6480
6481 * xfns.c (x_encode_text, x_set_name_internal)
6482 (Fx_change_window_property): Use ptrdiff_t, not int, to count
6483 sizes, since they can exceed INT_MAX in size. Check for size
6484 calculation overflow.
6485
0065d054
PE
6486 * xgselect.c (gfds_size): Now ptrdiff_t, for convenience with xpalloc.
6487 (xg_select): Check for size calculation overflow.
726e0ab1
PE
6488 Don't update size until alloc done.
6489
0065d054 6490 * xrdb.c (get_environ_db): Don't assume path length fits in int,
726e0ab1 6491 as sprintf is limited to int lengths.
1d526e2f 6492
252c5ee1
PE
6493 * xselect.c (X_LONG_SIZE, X_SHRT_MAX, X_SHRT_MIN, X_LONG_MAX)
6494 (X_LONG_MIN): New macros.
864d7ce7
PE
6495 Use them to make the following changes clearer.
6496 (MAX_SELECTION_QUANTUM): Make the other bounds on this value clearer.
6497 This change doesn't affect the value now, but it may help remind
6498 future maintainers not to raise the value too much later.
6499 (SELECTION_QUANTUM): Remove, replacing with ...
6500 (selection_quantum): ... new function, which avoids overflow.
6501 All uses changed.
6502 (struct selection_data.size): Now ptrdiff_t, not int, to avoid
6503 assumption that selection length fits in 'int'.
6504 (x_reply_selection_request, x_handle_selection_request)
6505 (x_get_window_property, receive_incremental_selection)
6506 (x_get_window_property_as_lisp_data, selection_data_to_lisp_data)
6507 (lisp_data_to_selection_data, clean_local_selection_data):
6508 Use ptrdiff_t, not int, to record length of selection.
6509 (x_reply_selection_request, x_get_window_property)
6510 (receive_incremental_selection, x_property_data_to_lisp):
6511 Redo calculations to avoid overflow.
6512 (x_reply_selection_request): When sending hint, ceiling it at
252c5ee1 6513 X_LONG_MAX rather than relying on wraparound overflow to send
864d7ce7
PE
6514 something.
6515 (x_get_window_property, receive_incremental_selection)
6516 (lisp_data_to_selection_data, x_property_data_to_lisp):
6517 Check for size-calculation overflow.
6518 (x_get_window_property, receive_incremental_selection)
6519 (lisp_data_to_selection_data, Fx_register_dnd_atom):
6520 Don't store size until memory allocation succeeds.
6521 (x_get_window_property): Plug memory leak on memory exhaustion.
6522 Don't double-block input; malloc is safe here. Don't assume 2**34
6523 - 4 fits in unsigned long. Add an xassert to check
6524 XGetWindowProperty overflow. Be more careful about overflow
6525 calculations, and distinguish size from memory overflow better.
6526 (receive_incremental_selection): When tracing, don't assume
6527 unsigned int is less than INT_MAX.
6528 (x_selection_data_to_lisp_data): Remove unnecessary (and in theory
6529 harmful) conversions of unsigned short to int.
6530 (lisp_data_to_selection_data): Don't assume that integers
6531 in the range -65535 through -1 fit in an X unsigned short.
6532 Don't assume that ULONG_MAX == X_ULONG_MAX. Don't store into
6533 result parameters unless successful. Rely on cons_to_unsigned
6534 to report problems with elements; the old code wasn't right anyway.
6535 (x_check_property_data): Check for int overflow; we cannot use
6536 a wider type due to X limits.
6537 (x_handle_dnd_message): Use unsigned int, to avoid int overflow.
6538
726e0ab1 6539 * xsmfns.c (smc_save_yourself_CB): Check for size calc overflow.
34db673b 6540
0065d054
PE
6541 * xterm.c (x_color_cells, x_send_scrollbar_event, handle_one_xevent)
6542 (x_term_init): Check for size calculation overflow.
726e0ab1
PE
6543 (x_color_cells): Don't store size until memory allocation succeeds.
6544 (handle_one_xevent): Use ptrdiff_t, not int, for byte counts.
0065d054 6545 Don't assume alloca size is less than MAX_ALLOCA.
726e0ab1
PE
6546 (x_term_init): Don't assume length fits in int (sprintf is limited
6547 to int size).
bc18e09d 6548
ebfa62c0
PE
6549 Use ptrdiff_t for composition IDs.
6550 * character.c (lisp_string_width):
6551 * composite.c (composition_table_size, n_compositions)
6552 (get_composition_id, composition_gstring_from_id):
6553 * dispextern.h (struct glyph_string.cmp_id, struct composition_it.id):
6554 * xdisp.c (BUILD_COMPOSITE_GLYPH_STRING):
6555 * window.c (Frecenter):
6556 Use ptrdiff_t, not int, for composition IDs.
6557 * composite.c (get_composition_id): Check for integer overflow.
6558 * composite.h: Adjust prototypes to match the above changes.
6559
d3411f89
PE
6560 Use ptrdiff_t for hash table indexes.
6561 * category.c (hash_get_category_set):
6562 * ccl.c (ccl_driver):
6563 * charset.h (struct charset.hash_index, CHECK_CHARSET_GET_ID):
6564 * coding.c (coding_system_charset_list, detect_coding_system):
6565 * coding.h (struct coding_system.id):
6566 * composite.c (get_composition_id, gstring_lookup_cache):
6567 * fns.c (hash_lookup, hash_put, Fgethash, Fputhash):
6568 * image.c (xpm_get_color_table_h):
6569 * lisp.h (hash_lookup, hash_put):
6570 * minibuf.c (Ftest_completion):
6571 Use ptrdiff_t for hash table indexes, not int (which is too
6572 narrow, on 64-bit hosts) or EMACS_INT (which is too wide, on
6573 32-bit --with-wide-int hosts).
6574
e097a6fa
PE
6575 * charset.c (Fdefine_charset_internal): Check for integer overflow.
6576 Add a FIXME comment about memory leaks.
6577 (syms_of_charset): Don't assume xmalloc returns.
6578
5637687f
PE
6579 Don't assume that stated character widths fit in int.
6580 * character.c (Fchar_width, c_string_width, lisp_string_width):
6581 * character.h (CHAR_WIDTH):
6582 * indent.c (MULTIBYTE_BYTES_WIDTH):
6583 Use sanitize_char_width to avoid undefined and/or bad behavior
6584 with outlandish widths.
a66cfb1c 6585 * character.h (sanitize_tab_width): Rename from sanitize_width,
5637687f
PE
6586 now that we have two such functions. All uses changed.
6587 (sanitize_char_width): New inline function.
6588
a2271ba2
PE
6589 Don't assume that tab-width fits in int.
6590 * character.h (sanitize_width): New inline function.
6591 (SANE_TAB_WIDTH): New macro.
6592 (ASCII_CHAR_WIDTH): Use it.
6593 * indent.c (sane_tab_width): Remove. All uses replaced by
6594 SANE_TAB_WIDTH (current_buffer).
6595 * xdisp.c (init_iterator): Use SANE_TAB_WIDTH.
6596
18c52557
PE
6597 * fileio.c: Integer overflow issues with file modes.
6598 (Fset_file_modes, auto_save_1): Don't assume EMACS_INT fits in int.
6599
caeeedc1
PE
6600 * charset.c (read_hex): New arg OVERFLOW. All uses changed.
6601 Remove unreachable code.
6602 (read_hex, load_charset_map_from_file): Check for integer overflow.
6603
6df6ae42 6604 * xterm.c: Don't go over XClientMessageEvent limit.
50849c52
PE
6605 (scroll_bar_windows_size): Now ptrdiff_t, as we prefer signed.
6606 (x_send_scroll_bar_event): Likewise. Check that the size does not
6607 exceed limits imposed by XClientMessageEvent, as well as the usual
6608 ptrdiff_t and size_t limits.
6609
b13995db
PE
6610 * keyboard.c: Overflow, signedness and related fixes.
6611 (make_lispy_movement): Use same integer type in forward decl
6612 that is used in the definition.
6613 (read_key_sequence, keyremap_step):
6614 Change bufsize argument back to int, undoing my 2011-03-30 change.
6615 We prefer signed types, and int is wide enough here.
6616 (parse_tool_bar_item): Don't assume tool_bar_max_label_size is less
6617 than TYPE_MAXIMUM (EMACS_INT) / 2. Don't let the label size grow
6618 larger than STRING_BYTES_BOUND. Use ptrdiff_t for Emacs string
6619 length, not size_t. Use ptrdiff_t for index, not int.
6620 (keyremap_step, read_key_sequence): Redo bufsize check to avoid
6621 possibility of integer overflow.
6622
13464394
PE
6623 Overflow, signedness and related fixes for images.
6624
6625 * dispextern.h (struct it.stack[0].u.image.image_id)
6626 (struct_it.image_id, struct image.id, struct image_cache.size)
6627 (struct image_cache.used, struct image_cache.ref_count):
6628 * gtkutil.c (update_frame_tool_bar):
6629 * image.c (x_reference_bitmap, Fimage_size, Fimage_mask_p)
6630 (Fimage_metadata, free_image_cache, clear_image_cache, lookup_image)
6631 (cache_image, mark_image_cache, x_kill_gs_process, Flookup_image):
6632 * nsmenu.m (update_frame_tool_bar):
6633 * xdisp.c (calc_pixel_width_or_height):
6634 * xfns.c (image_cache_refcount):
6635 Image IDs are now ptrdiff_t, not int, to avoid arbitrary limits
6636 on typical 64-bit hosts.
6637
6638 * image.c (RANGED_INTEGERP, TYPE_RANGED_INTEGERP): New macros.
6639 (x_bitmap_pixmap, x_create_x_image_and_pixmap):
6640 Omit unnecessary casts to int.
6641 (parse_image_spec): Check that integers fall into 'int' range
6642 when the callers expect that.
6643 (image_ascent): Redo ascent calculation to avoid int overflow.
6644 (clear_image_cache): Avoid overflow when sqrt (INT_MAX) < nimages.
6645 (lookup_image): Remove unnecessary tests.
6646 (xbm_image_p): Locals are now of int, not EMACS_INT,
6647 since parse_image_check makes sure they fit into int.
6648 (png_load, gif_load, svg_load_image):
6649 Prefer int to unsigned where either will do.
6650 (tiff_handler): New function, combining the cores of the
a66cfb1c
SM
6651 old tiff_error_handler and tiff_warning_handler.
6652 This function is rewritten to use vsnprintf and thereby avoid
13464394
PE
6653 stack buffer overflows. It uses only the features of vsnprintf
6654 that are common to both POSIX and native Microsoft.
6655 (tiff_error_handler, tiff_warning_handler): Use it.
6656 (tiff_load, gif_load, imagemagick_load_image):
6657 Don't assume :index value fits in 'int'.
6658 (gif_load): Omit unnecessary cast to double, and avoid double-rounding.
6659 (imagemagick_load_image): Check that crop parameters fit into
6660 the integer types that MagickCropImage accepts. Don't assume
6661 Vimagemagick_render_type has a nonnegative value. Don't assume
6662 size_t fits in 'long'.
6663 (gs_load): Use printmax_t to print the widest integers possible.
6664 Check for integer overflow when computing image height and width.
6665
c11821d4
EZ
66662011-08-26 Eli Zaretskii <eliz@gnu.org>
6667
6668 * xdisp.c (redisplay_window): Don't force window start if point
6669 will be invisible in the resulting window. (Bug#9324)
6670
0c95fcf7
EZ
66712011-08-25 Eli Zaretskii <eliz@gnu.org>
6672
6673 * xdisp.c (compute_display_string_pos): Return 2 in DISP_PROP when
6674 the display spec is of the form `(space ...)'.
6675 (handle_display_spec): Return the value returned by
6676 handle_single_display_spec, not just 1 or zero.
6677 (handle_single_display_spec): If the display spec is of the form
6678 `(space ...)', and specifies display in the text area, return 2
6679 rather than 1.
fee65a97 6680 (try_cursor_movement): Check for the need to scroll more
a66cfb1c
SM
6681 accurately, and prefer exact match for point under bidi.
6682 Don't advance `row' beyond the last row of the window.
0c95fcf7
EZ
6683
6684 * dispextern.h (struct bidi_it): Rename the disp_prop_p member
6685 into disp_prop; all users changed.
6686
6687 * bidi.c (bidi_fetch_char): If compute_display_string_pos returns
6688 DISP_PROP = 2, substitute the u+2029 PARAGRAPH SEPARATOR character
6689 for the text covered by the display property.
6690
e4ed06f1
CY
66912011-08-25 Chong Yidong <cyd@stupidchicken.com>
6692
6693 * buffer.c (Fbury_buffer_internal): Rename from Funrecord_buffer.
6694 Change return value to nil.
6695 (Frecord_buffer): Delete unused function.
6696
f67cdd7f
EZ
66972011-08-24 Eli Zaretskii <eliz@gnu.org>
6698
5980d4c6
EZ
6699 * xdisp.c (Fcurrent_bidi_paragraph_direction): For unibyte
6700 buffers, return left-to-right.
8610fe8b
EZ
6701 (set_cursor_from_row): Consider candidate row a win if its glyph
6702 represents a newline and point is on that newline. Fixes cursor
6703 positioning on the newline at EOL of R2L text within L2R
6704 paragraph, and vice versa.
6705 (try_cursor_movement): Check continued rows, in addition to
6706 continuation rows. Fixes unwarranted scroll when point enters a
6707 continued line of R2L text within an L2R paragraph, or vice versa.
6708 (cursor_row_p): Consider the case of point being equal to
6709 MATRIX_ROW_END_CHARPOS. Prevents cursor being stuck when moving
6710 from the end of a short line to the beginning of a continued line
6711 of R2L text within L2R paragraph.
6712 (RECORD_MAX_MIN_POS): For max_pos, use IT_CHARPOS even for
6713 composed characters.
5980d4c6 6714
f67cdd7f
EZ
6715 * bidi.c (bidi_check_type): Use xassert.
6716 (bidi_cache_iterator_state): Update the disp_pos and disp_prop_p
6717 members.
6718
bca633fb
EZ
67192011-08-23 Eli Zaretskii <eliz@gnu.org>
6720
6721 * bidi.c (bidi_get_type): Abort if we get zero as the bidi type of
6722 a character.
6723
4a5885a7
CY
67242011-08-23 Chong Yidong <cyd@stupidchicken.com>
6725
6726 * nsfont.m (ns_otf_to_script): Fix typo.
6727
0902a04e
KH
67282011-08-22 Kenichi Handa <handa@m17n.org>
6729
6730 * chartab.c (Fset_char_table_extra_slot): Do not inhibit setting a
6731 extra slot even if the purpose is char-code-property-table.
6732
1a2e6670
EZ
67332011-08-23 Eli Zaretskii <eliz@gnu.org>
6734
8ddde651
EZ
6735 * xdisp.c (redisplay_window): When computing centering_position,
6736 account for the height of the header line. (Bug#8874)
6737
425cc014
EZ
6738 * dispnew.c (buffer_posn_from_coords): Use buf_charpos_to_bytepos
6739 instead of CHAR_TO_BYTE. Fixes a crash when a completion
6740 candidate is selected by the mouse, and that candidate has a
6741 composed character under the mouse.
6742
1a2e6670
EZ
6743 * xdisp.c (x_produce_glyphs): Set it->nglyphs to 1. Fixes pixel
6744 coordinates reported by pos-visible-in-window-p for a composed
6745 character in column zero.
6746
8b76d6f8
SM
67472011-08-23 Stefan Monnier <monnier@iro.umontreal.ca>
6748
6749 * cmds.c (Fself_insert_command): Mention post-self-insert-hook.
6750
dac347dd
EZ
67512011-08-22 Eli Zaretskii <eliz@gnu.org>
6752
6753 * xdisp.c (BUFFER_POS_REACHED_P): If this is a composition,
6754 consider it a hit if to_charpos is anywhere in the range of the
6755 composed buffer positions.
6756
e013fb34
CY
67572011-08-22 Chong Yidong <cyd@stupidchicken.com>
6758
6759 * image.c (gif_load): Don't assume that each subimage has the same
6760 dimensions as the base image. Handle disposal method that is
6761 "undefined" by the gif spec (Bug#9335).
6762
bd1ba3e8
CY
67632011-08-20 Chong Yidong <cyd@stupidchicken.com>
6764
6765 * eval.c (Fsignal): Handle `debug' symbol in error handler (Bug#9329).
024a2d76 6766 (Fcondition_case): Document `debug' symbol in error handler.
bd1ba3e8 6767
54a1215b
EZ
67682011-08-19 Eli Zaretskii <eliz@gnu.org>
6769
823564e5
EZ
6770 * xfaces.c (face_at_buffer_position): Avoid repeated evaluation of
6771 face ID by FACE_FROM_ID, and avoid a crash when mouse is moved
6772 from an Org mode buffer to a Speedbar frame.
6773
54a1215b
EZ
6774 * xdisp.c (RECORD_MAX_MIN_POS): If the display element comes from
6775 a composition, take its buffer position from IT->cmp_it.charpos.
6776 Fixes cursor positioning at the beginning of a line that begins
6777 with a composed character.
6778
9778ebcc
EZ
67792011-08-18 Eli Zaretskii <eliz@gnu.org>
6780
0be6ee06
EZ
6781 * bidi.c (bidi_get_type): If bidi_type_table reports zero as the
6782 character bidirectional type, use STRONG_L instead. Fixes crashes
6783 in a buffer produced by `describe-categories'.
6784
9778ebcc
EZ
6785 * dispextern.h (struct bidi_it): Move disp_pos and disp_prop_p
6786 members before the level stack, so they would be saved and
6787 restored when copying iterator state. Fixes incorrect reordering
6788 around TABs covered by display properties.
6789
156bffbe
AS
67902011-08-18 Andreas Schwab <schwab@linux-m68k.org>
6791
6b02f655 6792 * process.c (Fnetwork_interface_list): Correctly determine buffer size.
156bffbe 6793
72ad093b
CY
67942011-08-17 Chong Yidong <cyd@stupidchicken.com>
6795
6796 * eval.c (internal_condition_case, internal_condition_case_1)
8b76d6f8
SM
6797 (internal_condition_case_2, internal_condition_case_n):
6798 Remove unnecessary aborts (Bug#9081).
72ad093b 6799
35774242
EZ
68002011-08-17 Eli Zaretskii <eliz@gnu.org>
6801
6802 * lread.c (Fload) [DOS_NT]: If `openp' returns -2, but the file
6803 has no `load' handler, try opening the file locally. (Bug#9311)
6804
db76dd85
KB
68052011-08-16 Ken Brown <kbrown@cornell.edu>
6806
6807 * gmalloc.c: Expand comment.
6808
b215eee5
EZ
68092011-08-16 Eli Zaretskii <eliz@gnu.org>
6810
6811 * xdisp.c (set_cursor_from_row): Don't accept a previous candidate
6812 if it fails the cursor_row_p test. Fixes cursor positioning at ZV.
6813
a4579d33
KB
68142011-08-16 Ken Brown <kbrown@cornell.edu>
6815
6816 Fix memory allocation problems in Cygwin build (Bug#9273).
6817
6818 * unexcw.c ( __malloc_initialized): Declare external variable.
6819 (fixup_executable): Force the dumped emacs to reinitialize malloc.
6820
8b76d6f8
SM
6821 * gmalloc.c [CYGWIN] (bss_sbrk_heapbase, bss_sbrk_heapinfo):
6822 New variables.
a4579d33
KB
6823 (malloc_initialize_1) [CYGWIN]: Prepare for reinitializing the
6824 dumped emacs.
6825 (_free_internal_nolock) [CYGWIN]: Ignore requests to free storage
6826 in the static heap.
6827 [CYGWIN] (special_realloc): New function.
6828 (_realloc_internal_nolock) [CYGWIN]: Use the new function on
6829 requests to realloc storage in the static heap.
6830
3ebec551
PE
68312011-08-15 Paul Eggert <eggert@cs.ucla.edu>
6832
6833 * bidi.c (bidi_initialize): Remove unused local.
6834
9fd8be00
EZ
68352011-08-15 Eli Zaretskii <eliz@gnu.org>
6836
6b02f655
SM
6837 * bidimirror.h:
6838 * biditype.h: Remove file.
6839 * makefile.w32-in ($(BLD)/bidi.$(O)):
6840 * deps.mk (bidi.o): Remove biditype.h and bidimirror.h.
474a8465
EZ
6841
6842 * dispextern.h: Fix a typo in the comment to bidi_type_t.
6843
6844 * chartab.c: Improve commentary for the uniprop_table API.
6845
32413314
EZ
6846 * bidi.c (bidi_paragraph_init): Support zero value of
6847 bidi_ignore_explicit_marks_for_paragraph_level.
474a8465
EZ
6848 (bidi_initialize): Use uniprop_table instead of including
6849 biditype.h and bidimirror.h.
32413314 6850
9fd8be00
EZ
6851 * xdisp.c (move_it_in_display_line_to): Don't reset pixel
6852 coordinates of the iterator when restoring from ppos_it.
6853 (Bug#9296)
6854
5cf2b69b
KH
68552011-08-14 Kenichi Handa <handa@m17n.org>
6856
6857 * process.c (create_process): Call setup_process_coding_systems
72ad093b 6858 after the pid of the process is set to -1 (Bug#8162).
5cf2b69b 6859
daf17d00
EZ
68602011-08-14 Eli Zaretskii <eliz@gnu.org>
6861
6862 * xdisp.c (move_it_in_display_line_to): Don't invoke
6863 IT_RESET_X_ASCENT_DESCENT when iterator position was restored from
6864 ppos_it. Fixes vertical cursor motion when line beginning is
6865 covered by an image. (Bug#9296)
6866
08e3161a
JD
68672011-08-14 Jan Djärv <jan.h.d@swipnet.se>
6868
6869 * nsterm.h (ns_run_ascript): Declare.
6870 (NSAPP_DATA2_RUNASSCRIPT): Define.
6871
6872 * nsfns.m (as_script, as_result, as_status): New static variables.
6873 (ns_run_ascript): New function.
5e617bc2 6874 (Fns_do_applescript): Set variables as_*. Make an NSApplicationDefined
08e3161a
JD
6875 event with data2 set to NSAPP_DATA2_RUNASSCRIPT, post it and then start
6876 the event loop. Get status from as_status (Bug#7276).
6877
6878 * nsterm.m (sendEvent): If event is NSApplicationDefined and
6879 data2 is NSAPP_DATA2_RUNASSCRIPT, call ns_run_ascript and then exit
6880 the event loop (Bug#7276).
6881
a3720aa2
AS
68822011-08-14 Andreas Schwab <schwab@linux-m68k.org>
6883
6884 * gnutls.c (QCgnutls_bootprop_priority)
6885 (QCgnutls_bootprop_trustfiles, QCgnutls_bootprop_keylist)
6886 (QCgnutls_bootprop_crlfiles, QCgnutls_bootprop_callbacks)
6887 (QCgnutls_bootprop_loglevel, QCgnutls_bootprop_hostname)
6888 (QCgnutls_bootprop_min_prime_bits, QCgnutls_bootprop_verify_flags)
6889 (QCgnutls_bootprop_verify_hostname_error)
6890 (QCgnutls_bootprop_callbacks_verify): Rename from
6891 Qgnutls_bootprop_..., all uses changed.
6892
6893 * xfaces.c (QCignore_defface): Rename from Qignore_defface, all
6894 uses changed.
6895
0a0d27fb
PE
68962011-08-14 Paul Eggert <eggert@cs.ucla.edu>
6897
19d5c50c
PE
6898 * xfaces.c (Qframe_set_background_mode): Now static.
6899 * dispextern.h (Qframe_set_background_mode): Remove decl.
6900
0a0d27fb
PE
6901 * process.c (Fnetwork_interface_info): Declare local only if needed.
6902
377538cb
JD
69032011-08-13 Jan Djärv <jan.h.d@swipnet.se>
6904
6905 * process.c: Include ifaddrs.h and net/if_dl.h if available (Bug#8477).
6906 (Fnetwork_interface_list): Allocate in increments of bytes instead
6907 of sizeof (struct ifreq). Iterate over ifconf.ifc_req by counting
6908 bytes (Bug#8477). Count bytes correctly when ifr_addr is a struct
6909 sockaddr.
6910 (struct ifflag_def): notrailers is smart on OSX.
6911 (Fnetwork_interface_info): Handle case when ifr_flags is negative.
6912 Get hardware address with getifaddrs if available.
6913
08fff70c
EZ
69142011-08-12 Eli Zaretskii <eliz@gnu.org>
6915
6916 * xdisp.c (iterate_out_of_display_property): xassert that
6917 IT->position is set to within IT->object's boundaries. Break from
6918 the loop as soon as EOB is reached; avoids infloops in redisplay
8b76d6f8
SM
6919 when IT->position is set up wrongly due to some bug.
6920 Set IT->current to match the bidi iterator unconditionally.
08fff70c
EZ
6921 (push_display_prop): Allow GET_FROM_STRING as IT->method on
6922 entry. Force push_it to save on the stack the current
6923 buffer/string position, to be restored by pop_it. Fix flags in
6924 the iterator structure wrt the object coming from a display
6925 property, as `line-prefix' and `wrap-prefix' are not ``replacing''
6926 properties. (Bug#9284)
6927
7be1c708 69282011-08-09 Andreas Schwab <schwab@linux-m68k.org>
aac0c6e3 6929
7be1c708
CY
6930 * fontset.c (fontset_get_font_group): Add proper type checks.
6931 (Bug#9172)
aac0c6e3 6932
7be1c708 69332011-08-09 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
aac0c6e3 6934
7be1c708
CY
6935 * unexmacosx.c (print_load_command_name): Add cases LC_FUNCTION_STARTS
6936 and LC_VERSION_MIN_MACOSX.
6937 (copy_linkedit_data) [LC_FUNCTION_STARTS]: New function.
6938 (dump_it) [LC_FUNCTION_STARTS]: Use it.
aac0c6e3 6939
97bb72a6
EZ
69402011-08-08 Eli Zaretskii <eliz@gnu.org>
6941
6942 * xdisp.c (forward_to_next_line_start): Allow to use the
8b76d6f8
SM
6943 no-display-properties-and-no-overlays under bidi display.
6944 Set disp_pos in the bidi iterator to avoid searches for display
757664a4 6945 properties and overlays.
97bb72a6 6946
d5617611
CY
69472011-08-08 Chong Yidong <cyd@stupidchicken.com>
6948
37e11a63
CY
6949 * editfns.c (Fset_time_zone_rule): Document relationship with the
6950 setenv function.
6951
d5617611
CY
6952 * ftfont.c (ftfont_pattern_entity): Copy the extras argument to
6953 the font entity extracted from the cache (Bug#8109).
6954
58872834
CY
69552011-08-07 Chong Yidong <cyd@stupidchicken.com>
6956
6957 * composite.c (autocmp_chars): Don't reset point. That is done by
6958 restore_point_unwind (Bug#5984).
6959
75bfc667
JL
69602011-08-07 Juri Linkov <juri@jurta.org>
6961
6962 * editfns.c (Fformat_time_string): Doc fix, add tag `usage:'
6963 to show the arg `TIME' instead of `TIMEVAL'.
6964
d1410150
EZ
69652011-08-06 Eli Zaretskii <eliz@gnu.org>
6966
6967 * xdisp.c (set_cursor_from_row): Fix cursor positioning when a
6968 display property strides EOL and includes a newline, as in
6969 longlines-mode. (Bug#9254)
75b771e4
EZ
6970 (move_it_in_display_line_to): Fix vertical-motion in a buffer with
6971 word-wrap under bidirectional display. (Bug#9224)
d1410150
EZ
6972
6973 * bidi.c (bidi_unshelve_cache): Don't reset the cache if JUST_FREE
6974 is non-zero, even if the data buffer is NULL. Fixes a crash in
6975 vertical-motion with longlines-mode. (Bug#9254)
6976
35928349
EZ
69772011-08-05 Eli Zaretskii <eliz@gnu.org>
6978
ec7cc85b
EZ
6979 * bidi.c <bidi_cache_total_alloc>: Now static.
6980 (bidi_initialize): Initialize bidi_cache_total_alloc.
6981
8b76d6f8 6982 * xdisp.c (display_line): Release buffer allocated for shelved bidi
35928349
EZ
6983 cache. (Bug#9221)
6984
6985 * bidi.c (bidi_shelve_cache, bidi_unshelve_cache): Track total
6986 amount allocated this far in `bidi_cache_total_alloc'.
6987 (bidi_unshelve_cache): Accept an additional argument JUST_FREE; if
6988 non-zero, only free the data buffer without restoring the cache
6989 contents. All callers changed.
6990
6991 * dispextern.h (bidi_unshelve_cache): Update prototype.
6992
6993 * xdisp.c (SAVE_IT, pos_visible_p, move_it_in_display_line_to)
6994 (move_it_in_display_line, move_it_to)
6995 (move_it_vertically_backward, move_it_by_lines): Replace the call
6996 to xfree to an equivalent call to bidi_unshelve_cache.
6997 (move_it_in_display_line_to): Fix logic of returning
412b6358 6998 MOVE_POS_MATCH_OR_ZV in the bidi case. (Bug#9224)
35928349 6999
e2e2423b
EZ
70002011-08-05 Eli Zaretskii <eliz@gnu.org>
7001
7002 * xdisp.c (set_cursor_from_row): Prefer the candidate glyph that
7003 came from a string character with a `cursor' property. (Bug#9229)
7004
ae9e757a
JD
70052011-08-04 Jan Djärv <jan.h.d@swipnet.se>
7006
7007 * Makefile.in (LIB_PTHREAD): New variable.
7008 (LIBES): Add LIB_PTHREAD (Bug#9216).
7009
7010 * alloc.c, emacs.c, gmalloc.c, gtkutil.c, keyboard.c, syssignal.h:
7011 Rename HAVE_GTK_AND_PTHREAD to HAVE_PTHREAD (Bug#9216).
7012
213bd7f2
AS
70132011-08-04 Andreas Schwab <schwab@linux-m68k.org>
7014
6b02f655 7015 * regex.c (re_iswctype): Remove some redundant boolean conversions.
213bd7f2 7016
99aaf75f
JD
70172011-08-04 Jan Djärv <jan.h.d@swipnet.se>
7018
7019 * xterm.c (x_find_topmost_parent): New function.
7020 (x_set_frame_alpha): Find topmost parent window with
7021 x_find_topmost_parent and set the property there also (bug#9181).
7022 (handle_one_xevent): Call x_set_frame_alpha on ReparentNotify.
7023
c74e9d86
PE
70242011-08-04 Paul Eggert <eggert@cs.ucla.edu>
7025
7026 * callproc.c (Fcall_process): Avoid vfork clobbering
7027 the local vars buffer, coding_systems, current_dir.
7028
640c8776
SM
70292011-08-03 Stefan Monnier <monnier@iro.umontreal.ca>
7030
7031 * keymap.c (Fmake_composed_keymap): Move to subr.el.
7032
f26d0e4c
PE
70332011-08-03 Paul Eggert <eggert@cs.ucla.edu>
7034
8a10d76c
PE
7035 * fontset.c (dump_fontset) [FONTSET_DEBUG]: Declare EXTERNALLY_VISIBLE
7036 so that it is not optimized away.
7037
f26d0e4c
PE
7038 * xdisp.c (compute_display_string_pos): Remove unused local.
7039
55439c61
EZ
70402011-08-02 Eli Zaretskii <eliz@gnu.org>
7041
7042 Fix slow cursor motion and scrolling in large buffers with
7043 selective display, like Org Mode buffers. (Bug#9218)
7044
7045 * dispextern.h (struct bidi_it): New member disp_prop_p.
7046
7047 * xdisp.c: Remove one-slot cache of display string positions.
7048 (compute_display_string_pos): Accept an additional argument
5e617bc2 7049 DISP_PROP_P; callers changed. Scan at most 5K characters forward
55439c61
EZ
7050 for a display string or property. If found, set DISP_PROP_P
7051 non-zero.
7052
7053 * bidi.c (bidi_fetch_char): Accept an additional argument
640c8776
SM
7054 DISP_PROP_P, and pass it to compute_display_string_pos.
7055 Only handle text covered by a display string if DISP_PROP_P is returned
55439c61
EZ
7056 non-zero. All callers of bidi_fetch_char changed.
7057
fb33fa43
SM
70582011-08-02 Stefan Monnier <monnier@iro.umontreal.ca>
7059
7060 * keymap.c (Fdefine_key): Fix Lisp_Object/int mixup; apply some CSE.
7061
b099e063
DM
70622010-12-03 Don March <don@ohspite.net>
7063
7064 * keymap.c (Fdefine_key): Fix non-prefix key error message when
7065 last character M-[char] is translated to ESC [char] (bug#7541).
7066
5cc7f7af
KH
70672011-08-02 Kenichi Handa <handa@m17n.org>
7068
d0fffa3f 7069 * lisp.h (uniprop_table): Extern it.
5cc7f7af
KH
7070
7071 * chartab.c (uniprop_table): Make it non-static.
7072
525d5e6e
EZ
70732011-08-01 Eli Zaretskii <eliz@gnu.org>
7074
7075 * xdisp.c (forward_to_next_line_start): Accept additional argument
7076 BIDI_IT_PREV, and store into it the state of the bidi iterator had
7077 on the newline.
7078 (reseat_at_next_visible_line_start): Use the bidi iterator state
7079 returned by forward_to_next_line_start to restore the state of
7080 it->bidi_it after backing up to previous newline. (Bug#9212)
7081
31011111
AS
70822011-07-30 Andreas Schwab <schwab@linux-m68k.org>
7083
7084 * regex.c (re_comp): Protoize.
7085 (re_exec): Fix return type.
7086 (regexec): Fix type of `ret'. (Bug#9203)
7087
476371c4
PE
70882011-07-28 Paul Eggert <eggert@cs.ucla.edu>
7089
e5d76069
PE
7090 * image.c (check_image_size): Use 1024x1024 if unknown frame (Bug#9189).
7091 This is needed if max-image-size is a floating-point number.
7092
9a79b20c
AS
70932011-07-28 Andreas Schwab <schwab@linux-m68k.org>
7094
7095 * print.c (print_object): Print empty symbol as ##.
7096
7097 * lread.c (read1): Read ## as empty symbol.
7098
d8c2fa78
AA
70992011-07-28 Alp Aker <alp.tekin.aker@gmail.com>
7100
7101 * nsfns.m (x_set_foreground_color): Set f->foreground_pixel when
7102 setting frame foreground color (Bug#9175).
7103 (x_set_background_color): Likewise.
7104
ffe57a7a
AA
7105 * nsmenu.m (-setText): Size tooltip dimensions precisely to
7106 contents (Bug#9176).
7107 (EmacsTooltip -init): Remove bezels and add shadows to
7108 tooltip windows.
7109
bf3492a5
AA
7110 * nsterm.m (ns_dumpglyphs_stretch): Avoid overwriting left fringe
7111 or scroll bar (Bug#8470).
7112
d55e9c53
AA
7113 * nsfont.m (nsfont_open): Remove assignment to voffset and
7114 unnecessary vars hshink, expand, hd, full_height, min_height.
7115 (nsfont_draw): Use s->ybase as baseline for glyph drawing (Bug#8913).
7116
7117 * nsterm.h (nsfont_info): Remove voffset field.
7118
d8c2fa78 71192011-07-28 Alp Aker <alp.tekin.aker@gmail.com>
4843aac3
AA
7120
7121 Implement strike-through and overline on NextStep (Bug#8863).
7122
7123 * nsfont.m (nsfont_open): Use underline position provided by font,
7124 instead of hard-coded value of 2.
7125 (nsfont_draw): Call ns_draw_text_decoration instead.
7126
7127 * nsterm.h: Add declaration for ns_draw_text_decoration.
7128
7129 * nsterm.m (ns_draw_text_decoration): New function for drawing
7130 underline, overline, and strike-through.
7131 (ns_dumpglyphs_image, ns_dumpglyphs_stretch): Add call to
7132 ns_draw_text_decoration. Change treatment of cursor drawing to
8d5ed899 7133 accommodate underlining, etc.
4843aac3 7134
4cc60b9b
EZ
71352011-07-28 Eli Zaretskii <eliz@gnu.org>
7136
bc7ece87
EZ
7137 * buffer.c (init_buffer_once): Set bidi-display-reordering to t by
7138 default.
4cc60b9b 7139
476371c4
PE
71402011-07-28 Paul Eggert <eggert@cs.ucla.edu>
7141
66606eea
PE
7142 * alloc.c (memory_full) [!SYNC_INPUT]: Fix signal-related race.
7143 Without this fix, if a signal arrives just after memory fills up,
7144 'malloc' might be invoked reentrantly.
7145
476371c4
PE
7146 * image.c (x_check_image_size) [!HAVE_X_WINDOWS]: Return 1.
7147 In other words, assume that every image size is allowed, on non-X
7148 hosts. This assumption is probably wrong, but it lets Emacs compile.
7149
f3fcc40d
AS
71502011-07-28 Andreas Schwab <schwab@linux-m68k.org>
7151
7152 * regex.c (re_iswctype): Convert return values to boolean.
7153
350c992f
EZ
71542011-07-28 Eli Zaretskii <eliz@fencepost.gnu.org>
7155
7156 * xdisp.c (compute_display_string_pos): Don't use cached display
7157 string position if the buffer had its restriction changed.
7158 (Bug#9184)
7159
5266b4bb
PE
71602011-07-28 Paul Eggert <eggert@cs.ucla.edu>
7161
7162 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork clobbering.
7163
2573a837 71642011-07-28 Paul Eggert <eggert@cs.ucla.edu>
ca4aa935 7165
41f55ccd 7166 Integer signedness and overflow and related fixes. (Bug#9079)
cf950e6b 7167
39e378da
PE
7168 * bidi.c: Integer size and overflow fixes.
7169 (bidi_cache_size, bidi_cache_idx, bidi_cache_last_idx)
7170 (bidi_cache_start, bidi_cache_fetch_state, bidi_cache_search)
7171 (bidi_cache_find_level_change, bidi_cache_ensure_space)
7172 (bidi_cache_iterator_state, bidi_cache_find, bidi_cache_start_stack)
7173 (bidi_find_other_level_edge):
7174 Use ptrdiff_t instead of EMACS_INT where either will do.
7175 This works better on 32-bit hosts configured --with-wide-int.
7176 (bidi_cache_ensure_space): Check for size-calculation overflow.
7177 Use % rather than repeated addition, for better worst-case speed.
7178 Don't set bidi_cache_size until after xrealloc returns, because it
7179 might not return.
7180 (bidi_dump_cached_states): Use ptrdiff_t, not int, to avoid overflow.
f0eb61e9
PE
7181 (bidi_cache_ensure_space): Also check that the bidi cache size
7182 does not exceed that of the largest Lisp string or buffer. See Eli
7183 Zaretskii in <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=9079#29>.
39e378da 7184
5e927815
PE
7185 * alloc.c (__malloc_size_t): Remove.
7186 All uses replaced by size_t. See Andreas Schwab's note
7187 <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=9079#8>.
7188
ca4aa935
PE
7189 * image.c: Improve checking for integer overflow.
7190 (check_image_size): Assume that f is nonnull, since
7191 it is always nonnull in practice. This is one less thing to
7192 worry about when checking for integer overflow later.
7193 (x_check_image_size): New function, which checks for integer
7194 overflow issues inside X.
7195 (x_create_x_image_and_pixmap, xbm_read_bitmap_data): Use it.
7196 This removes the need for a memory_full check.
7197 (xbm_image_p): Rewrite to avoid integer multiplication overflow.
7198 (Create_Pixmap_From_Bitmap_Data, xbm_load): Use x_check_image_size.
7199 (xbm_read_bitmap_data): Change locals back to 'int', since
7200 their values must fit in 'int'.
7201 (xpm_load_image, png_load, tiff_load):
7202 Invoke x_create_x_image_and_pixmap earlier,
7203 to avoid much needless work if the image is too large.
7204 (tiff_load): Treat overly large images as if
7205 x_create_x_image_and_pixmap failed, not as malloc failures.
7206 (gs_load): Use x_check_image_size.
7207
5f8f9cc2
PE
7208 * gtkutil.c: Omit integer casts.
7209 (xg_get_pixbuf_from_pixmap): Remove unnecessary cast.
7210 (xg_set_toolkit_scroll_bar_thumb): Rewrite to avoid need for cast.
7211
5adf60bc
PE
7212 * image.c (png_load): Don't assume height * row_bytes fits in 'int'.
7213
c8907a93
PE
7214 * xfaces.c (Fbitmap_spec_p): Fix integer overflow bug.
7215 Without this fix, (bitmap-spec-p '(34359738368 1 "x"))
7216 would wrongly return t on a 64-bit host.
7217
e3c25c68
PE
7218 * dispnew.c (init_display): Use *_RANGE_OVERFLOW macros.
7219 The plain *_OVERFLOW macros run afoul of GCC bug 49705
7220 <http://gcc.gnu.org/bugzilla/show_bug.cgi?id=49705>
7221 and therefore cause GCC to emit a bogus diagnostic in some cases.
7222
3f791afe
PE
7223 * image.c: Integer signedness and overflow and related fixes.
7224 This is not an exhaustive set of fixes, but it's time to
7225 record what I've got.
7226 (lookup_pixel_color, check_image_size): Remove redundant decls.
7227 (check_image_size): Don't assume that arbitrary EMACS_INT values
7228 fit in 'int', or that arbitrary 'double' values fit in 'int'.
7229 (x_alloc_image_color, x_create_x_image_and_pixmap, png_load)
7230 (tiff_load, imagemagick_load_image):
7231 Check for overflow in size calculations.
7232 (x_create_x_image_and_pixmap): Remove unnecessary test for
7233 xmalloc returning NULL; that can't happen.
7234 (xbm_read_bitmap_data): Don't assume sizes fit into 'int'.
7235 (xpm_color_bucket): Use better integer hashing function.
7236 (xpm_cache_color): Don't possibly over-allocate memory.
7237 (struct png_memory_storage, tiff_memory_source, tiff_seek_in_memory)
7238 (gif_memory_source):
7239 Use ptrdiff_t, not int or size_t, to record sizes.
7240 (png_load): Don't assume values greater than 2**31 fit in 'int'.
7241 (our_stdio_fill_input_buffer): Prefer ptrdiff_t to size_t when
7242 either works, as we prefer signed integers.
7243 (tiff_read_from_memory, tiff_write_from_memory):
7244 Return tsize_t, not size_t, since that's what the TIFF API wants.
7245 (tiff_read_from_memory): Don't fail simply because the read would
7246 go past EOF; instead, return a short read.
7247 (tiff_load): Omit no-longer-needed casts.
7248 (Fimagemagick_types): Don't assume size fits into 'int'.
7249
3cc5a532
PE
7250 Improve hashing quality when configured --with-wide-int.
7251 * fns.c (hash_string): New function, taken from sxhash_string.
7252 Do not discard information about ASCII character case; this
7253 discarding is no longer needed.
7254 (sxhash-string): Use it. Change sig to match it. Caller changed.
7255 * lisp.h: Declare it.
7256 * lread.c (hash_string): Remove, since we now use fns.c's version.
7257 The fns.c version returns a wider integer if --with-wide-int is
7258 specified, so this should help the quality of the hashing a bit.
7259
b312a492
PE
7260 * emacs.c: Integer overflow minor fix.
7261 (heap_bss_diff): Now uprintmax_t, not unsigned long. All used changed.
7262 Define only if GNU_LINUX.
7263 (main, Fdump_emacs): Set and use heap_bss_diff only if GNU_LINUX.
7264
dfd153ae
PE
7265 * dispnew.c: Integer signedness and overflow fixes.
7266 Remove unnecessary forward decls, that were a maintenance hassle.
7267 (history_tick): Now uprintmax_t, so it's more likely to avoid overflow.
7268 All uses changed.
7269 (adjust_glyph_matrix, realloc_glyph_pool, adjust_frame_message_buffer)
7270 (scrolling_window): Use ptrdiff_t, not int, for byte count.
7271 (prepare_desired_row, line_draw_cost):
7272 Use int, not unsigned, where either works.
7273 (save_current_matrix, restore_current_matrix):
7274 Use ptrdiff_t, not size_t, where either works.
7275 (init_display): Check for overflow more accurately, and without
7276 relying on undefined behavior.
7277
a81d11a3
PE
7278 * editfns.c (pWIDE, pWIDElen, signed_wide, unsigned_wide):
7279 Remove, replacing with the new symbols in lisp.h. All uses changed.
7280 * fileio.c (make_temp_name):
7281 * filelock.c (lock_file_1, lock_file):
7282 * xdisp.c (message_dolog):
7283 Don't assume PRIdMAX etc. works; this isn't portable to pre-C99 hosts.
7284 Use pMd etc. instead.
7285 * lisp.h (printmax_t, uprintmax_t, pMd, pMu): New types and macros,
7286 replacing the pWIDE etc. symbols removed from editfns.c.
7287
3300e6fd
PE
7288 * keyboard.h (num_input_events): Now uintmax_t.
7289 This is (very slightly) less likely to mess up due to wraparound.
7290 All uses changed.
7291
fd05c7e9
PE
7292 * buffer.c: Integer signedness fixes.
7293 (alloc_buffer_text, enlarge_buffer_text):
7294 Use ptrdiff_t rather than size_t when either will do, as we prefer
7295 signed integers.
7296
903fe15d
PE
7297 * alloc.c: Integer signedness and overflow fixes.
7298 Do not impose an arbitrary 32-bit limit on malloc sizes when debugging.
7299 (__malloc_size_t): Default to size_t, not to int.
7300 (pure_size, pure_bytes_used_before_overflow, stack_copy_size)
7301 (Fgarbage_collect, mark_object_loop_halt, mark_object):
7302 Prefer ptrdiff_t to size_t when either would do, as we prefer
7303 signed integers.
7304 (XMALLOC_OVERRUN_CHECK_OVERHEAD): New macro.
7305 (xmalloc_overrun_check_header, xmalloc_overrun_check_trailer):
7306 Now const. Initialize with values that are in range even if char
7307 is signed.
7308 (XMALLOC_PUT_SIZE, XMALLOC_GET_SIZE): Remove, replacing with ...
7309 (xmalloc_put_size, xmalloc_get_size): New functions. All uses changed.
7310 These functions do the right thing with sizes > 2**32.
7311 (check_depth): Now ptrdiff_t, not int.
7312 (overrun_check_malloc, overrun_check_realloc, overrun_check_free):
7313 Adjust to new way of storing sizes. Check for size overflow bugs
7314 in rest of code.
7315 (STRING_BYTES_MAX): Adjust to new overheads. The old code was
7316 slightly wrong anyway, as it missed one instance of
7317 XMALLOC_OVERRUN_CHECK_OVERHEAD.
7318 (refill_memory_reserve): Omit needless cast to size_t.
7319 (mark_object_loop_halt): Mark as externally visible.
7320
ac82cc6a
PE
7321 * xselect.c: Integer signedness and overflow fixes.
7322 (Fx_register_dnd_atom, x_handle_dnd_message):
7323 Use ptrdiff_t, not size_t, since we prefer signed.
7324 (Fx_register_dnd_atom): Check for ptrdiff_t (and size_t) overflow.
7325 * xterm.h (struct x_display_info): Use ptrdiff_t, not size_t, for
7326 x_dnd_atoms_size and x_dnd_atoms_length.
7327
c2d1e36d
PE
7328 * doprnt.c: Prefer signed to unsigned when either works.
7329 * eval.c (verror):
7330 * doprnt.c (doprnt):
7331 * lisp.h (doprnt):
7332 * xdisp.c (vmessage):
7333 Use ptrdiff_t, not size_t, when using or implementing doprnt,
7334 since the sizes cannot exceed ptrdiff_t bounds anyway, and we
7335 prefer signed arithmetic to avoid comparison confusion.
7336 * doprnt.c (doprnt): Avoid a "+ 1" that can't overflow,
7337 but is a bit tricky.
7338
0e926e56
PE
7339 Assume freestanding C89 headers, string.h, stdlib.h.
7340 * data.c, doprnt.c, floatfns.c, print.c:
7341 Include float.h unconditionally.
7342 * gmalloc.c: Assume C89-at-least behavior for preprocessor,
7343 limits.h, stddef.h, string.h. Use memset instead of 'flood'.
7344 * regex.c: Likewise for stddef.h, string.h.
7345 (ISASCII): Remove; can assume it returns 1 now. All uses removed.
7346 * s/aix4-2.h (HAVE_STRING_H): Remove obsolete undef.
7347 * s/ms-w32.h (HAVE_LIMITS_H, HAVE_STRING_H, HAVE_STDLIB_H)
7348 (STDC_HEADERS): Remove obsolete defines.
7349 * sysdep.c: Include limits.h unconditionally.
7350
9cfdb3ec
PE
7351 Assume support for memcmp, memcpy, memmove, memset.
7352 * lisp.h, sysdep.c (memcmp, memcpy, memmove, memset):
7353 * regex.c (memcmp, memcpy):
7354 Remove; we assume C89 now.
7355
7356 * gmalloc.c (memcpy, memset, memmove): Remove; we assume C89 now.
7357 (__malloc_safe_bcopy): Remove; no longer needed.
7358
cf950e6b 7359 * lisp.h (struct vectorlike_header, struct Lisp_Subr): Signed sizes.
6089c567
PE
7360 Use EMACS_INT, not EMACS_UINT, for sizes. The code works equally
7361 well either way, and we prefer signed to unsigned.
7362
dbf38e02
LMI
73632011-07-27 Lars Magne Ingebrigtsen <larsi@gnus.org>
7364
7365 * gnutls.c (emacs_gnutls_read): Don't message anything if the peer
7366 closes the connection while we're reading (bug#9182).
7367
d6f0886c 73682011-07-25 Jan Djärv <jan.h.d@swipnet.se>
24e0f6b1 7369
d6f0886c
JD
7370 * nsmenu.m (ns_popup_dialog): Add an "ok" button if no buttons
7371 are specified (Bug#9168).
24e0f6b1 7372
2eb1f9e6
PE
73732011-07-25 Paul Eggert <eggert@cs.ucla.edu>
7374
7375 * bidi.c (bidi_dump_cached_states): Fix printf format mismatch.
7376 Found by GCC static checking and --with-wide-int on a 32-bit host.
7377
22381272 73782011-07-25 Eli Zaretskii <eliz@gnu.org>
7daee910
EZ
7379
7380 * xdisp.c (compute_display_string_pos): Fix logic of caching
7381 previous display string position. Initialize cached_prev_pos to
7382 -1. Fixes slow-down at the beginning of a buffer.
7383
f25e39b4
EZ
73842011-07-24 Eli Zaretskii <eliz@gnu.org>
7385
7386 * xfaces.c (check_lface_attrs) [HAVE_WINDOW_SYSTEM]: Allow `nil'
7387 for attrs[LFACE_FONTSET_INDEX].
7388
04c4b52e
PE
73892011-07-23 Paul Eggert <eggert@cs.ucla.edu>
7390
7391 * xml.c (parse_region): Remove unused local
7392 that was recently introduced.
7393
c1734fbd
EZ
73942011-07-23 Eli Zaretskii <eliz@gnu.org>
7395
be18c5a5
EZ
7396 * xfns.c (unwind_create_frame) [GLYPH_DEBUG]: Adapt to changes in
7397 2008-02-22T17:42:09Z!monnier@iro.umontreal.ca.
7398
c1734fbd
EZ
7399 * xdisp.c (move_it_in_display_line_to): Record the best matching
7400 position for TO_CHARPOS while scanning the line, and restore it on
640c8776
SM
7401 exit if none of the characters scanned was an exact match.
7402 Fixes vertical-motion and pos-visible-in-window-p under bidi redisplay
a9269c18
EZ
7403 when exact match is impossible due to invisible text, and the
7404 lines are truncated.
7405
a258d627
JD
74062011-07-23 Jan Djärv <jan.h.d@swipnet.se>
7407
7408 * nsterm.m (initFrameFromEmacs): Set NSTitledWindowMask in styleMask
7409 for OSX >= 10.7.
7410
b6d5a689
EZ
74112011-07-22 Eli Zaretskii <eliz@gnu.org>
7412
0f74f785
EZ
7413 Fix a significant slow-down of cursor motion with C-n, C-p,
7414 C-f/C-b, and C-v/M-v that couldn't keep up with keyboard
7415 auto-repeat under bidi redisplay in fontified buffers.
b6d5a689 7416 * xdisp.c (compute_stop_pos_backwards): New function.
b6d5a689
EZ
7417 (next_element_from_buffer): Call compute_stop_pos_backwards to
7418 find a suitable prev_stop when we find ourselves before
0f74f785
EZ
7419 base_level_stop.
7420 (reseat): Don't look for prev_stop, as that could mean a very long
7421 run.
7422 <cached_disp_pos, cached_disp_buffer, cached_disp_modiff>
7423 <cached_disp_overlay_modiff>: Cache for last found display string
7424 position.
551918c1 7425 (compute_display_string_pos): Return the cached position if asked
0f74f785
EZ
7426 about the same buffer in the same area of character positions, and
7427 the buffer wasn't changed since the time the display string
7428 position was cached.
551918c1 7429
b2d0c91a
EZ
74302011-07-22 Eli Zaretskii <eliz@gnu.org>
7431
7432 * xdisp.c (rows_from_pos_range): Don't ignore glyphs whose object
7433 is an integer, which is important for empty lines. (Bug#9149)
7434
043604ee
CY
74352011-07-22 Chong Yidong <cyd@stupidchicken.com>
7436
7437 * frame.c (Fmodify_frame_parameters): In tty case, update the
7438 default face if necessary (Bug#4238).
7439
da4adb04
CY
74402011-07-21 Chong Yidong <cyd@stupidchicken.com>
7441
7442 * editfns.c (Fstring_to_char): No need to explain what a character
7443 is in the docstring (Bug#6576).
7444
9abd0532
LMI
74452011-07-20 Lars Magne Ingebrigtsen <larsi@gnus.org>
7446
7447 * xml.c (parse_region): Make sure we always return a tree.
7448
36881d16
HK
74492011-07-20 HAMANO Kiyoto <khiker.mail@gmail.com>
7450
7451 * xml.c (parse_region): If a document contains only comments,
7452 return that, too.
7453
1e98674d
LMI
74542011-07-20 Lars Magne Ingebrigtsen <larsi@gnus.org>
7455
7456 * xml.c (make_dom): Return comments, too.
7457
590bd467
PE
74582011-07-19 Paul Eggert <eggert@cs.ucla.edu>
7459
7460 Port to OpenBSD.
7461 See http://lists.gnu.org/archive/html/emacs-devel/2011-07/msg00688.html
7462 and the surrounding thread.
7463 * minibuf.c (read_minibuf_noninteractive): Rewrite to use getchar
7464 rather than fgets, and retry after EINTR. Otherwise, 'emacs
7465 --batch -f byte-compile-file' fails on OpenBSD if an inactivity
7466 timer goes off.
7467 * s/openbsd.h (BROKEN_SIGIO): Define.
7468 * unexelf.c (unexec) [__OpenBSD__]:
7469 Don't update the .mdebug section of the Alpha COFF symbol table.
7470
f41628b2
LMI
74712011-07-19 Lars Magne Ingebrigtsen <larsi@gnus.org>
7472
7473 * lread.c (syms_of_lread): Clarify when `lexical-binding' is used
7474 (bug#8460).
7475
b59b67c5
PE
74762011-07-18 Paul Eggert <eggert@cs.ucla.edu>
7477
15e3a074
PE
7478 * fileio.c (Fcopy_file) [!MSDOS]: Tighten created file's mask.
7479 This fixes some race conditions on the permissions of any newly
7480 created file.
7481
41bed37d
PE
7482 * alloc.c (valid_pointer_p): Use pipe, not open.
7483 This fixes some permissions issues when debugging.
7484
b59b67c5
PE
7485 * fileio.c (Fcopy_file): Adjust mode if fchown fails. (Bug#9002)
7486 If fchown fails to set both uid and gid, try to set just gid,
7487 as that is sometimes allowed. Adjust the file's mode to eliminate
7488 setuid or setgid bits that are inappropriate if fchown fails.
7489
925a6be7
SM
74902011-07-18 Stefan Monnier <monnier@iro.umontreal.ca>
7491
7492 * xdisp.c (next_element_from_string, next_element_from_buffer): Use EQ
7493 to compare Lisp_Objects.
7494 * gnutls.c (syms_of_gnutls): Rename Vgnutls_log_level to
7495 global_gnutls_log_level, don't mistake it for a Lisp_Object.
7496 (init_gnutls_functions, emacs_gnutls_handle_error): Fix up uses.
7497
52968808
AS
74982011-07-17 Andreas Schwab <schwab@linux-m68k.org>
7499
0a6a104b
AS
7500 * lread.c (read_integer): Unread even EOF character.
7501 (read1): Likewise. Properly record start position of symbol.
7502
52968808
AS
7503 * lread.c (read1): Read `#:' as empty uninterned symbol if no
7504 symbol character follows.
7505
9e381cdd
PE
75062011-07-17 Paul Eggert <eggert@cs.ucla.edu>
7507
7508 * fileio.c (Fcopy_file): Pacify gcc re fchown. (Bug#9002)
7509 This works around a problem with the previous change to Fcopy_file.
7510 Recent glibc declares fchown with __attribute__((warn_unused_result)),
7511 and without this change, GCC might complain about discarding
7512 fchown's return value.
7513
b5641435
JB
75142011-07-16 Juanma Barranquero <lekktu@gmail.com>
7515
7516 * makefile.w32-in (GLOBAL_SOURCES): Add gnutls.c (followup to bug#9059).
7517
a8031457
PE
75182011-07-16 Paul Eggert <eggert@cs.ucla.edu>
7519
7520 * fileio.c (Fcopy_file): Don't diagnose fchown failures. (Bug#9002)
7521
dd889327
LMI
75222011-07-16 Lars Magne Ingebrigtsen <larsi@gnus.org>
7523
750c33f7
LMI
7524 * gnutls.c (syms_of_gnutls): Define `gnutls-log-level' here, since
7525 it's used from the C level.
7526
dd889327
LMI
7527 * process.c: Use the same condition for POLL_FOR_INPUT in both
7528 keyboard.c and process.c (bug#1858).
7529
87e86684
LM
75302011-07-09 Lawrence Mitchell <wence@gmx.li>
7531
7532 * gnutls.c (Qgnutls_bootprop_min_prime_bits): New variable.
7533 (Fgnutls_boot): Use it.
7534
64348f40
AS
75352011-07-15 Andreas Schwab <schwab@linux-m68k.org>
7536
7537 * doc.c (Fsubstitute_command_keys): Revert last change.
7538
1d698799
LMI
75392011-07-15 Lars Magne Ingebrigtsen <larsi@gnus.org>
7540
f863868c
LMI
7541 * doc.c (Fsubstitute_command_keys): Clarify that \= really only
7542 quotes the next character, and doesn't affect other longer
7543 sequences (bug#8935).
7544
1d698799
LMI
7545 * lread.c (syms_of_lread): Clarify that is isn't only
7546 `eval-buffer' and `eval-defun' that's affected by
7547 `lexical-binding' (bug#8460).
7548
aa4b6df6
EZ
75492011-07-15 Eli Zaretskii <eliz@gnu.org>
7550
7551 * xdisp.c (move_it_in_display_line_to): Fix vertical motion with
6b02f655 7552 bidi redisplay when a line includes both an image and is truncated.
aa4b6df6 7553
5d856da6
PE
75542011-07-14 Paul Eggert <eggert@cs.ucla.edu>
7555
ad6042bb
PE
7556 Fix minor problems found by static checking.
7557 * bidi.c (bidi_cache_size): Now EMACS_INT, not size_t.
7558 (elsz): Now a signed constant, not a size_t var. We prefer signed
7559 types to unsigned, to avoid integer comparison confusion. Without
7560 this change, GCC 4.6.1 with -Wunsafe-loop-optimizations complains
7561 "cannot optimize loop, the loop counter may overflow", a symptom
7562 of the confusion.
f00bbb22 7563 * indent.c (Fvertical_motion): Mark locals as initialized.
5d856da6
PE
7564 * xdisp.c (reseat_to_string): Fix pointer signedness issue.
7565
6468f31c
LMI
75662011-07-14 Lars Magne Ingebrigtsen <larsi@gnus.org>
7567
49080b10
LMI
7568 * search.c (Fre_search_backward): Mention `case-fold-search' in
7569 all the re_search_* functions (bug#8138).
7570
6468f31c
LMI
7571 * keyboard.c (Fopen_dribble_file): Document when the file is
7572 closed (bug#8056).
7573
c965adc5
EZ
75742011-07-14 Eli Zaretskii <eliz@gnu.org>
7575
df9733bf
EZ
7576 * bidi.c (bidi_dump_cached_states): Fix format of displaying
7577 bidi_cache_idx.
7578
0bb23927
EZ
7579 Support bidi reordering of display and overlay strings.
7580 * xdisp.c (compute_display_string_pos)
7581 (compute_display_string_end): Accept additional argument STRING.
7582 (init_iterator, reseat_1): Initialize bidi_it->string.s to NULL.
7583 (reseat_to_string): Initialize bidi_it->string.s and
7584 bidi_it->string.schars.
7585 (Fcurrent_bidi_paragraph_direction): Initialize itb.string.s to
640c8776
SM
7586 NULL (avoids a crash in bidi_paragraph_init).
7587 Initialize itb.string.lstring.
0bb23927
EZ
7588 (init_iterator): Call bidi_init_it only of a valid
7589 buffer position was specified. Initialize paragraph_embedding to
7590 L2R.
7591 (reseat_to_string): Initialize the bidi iterator.
7592 (display_string): If we need to ignore text properties of
7593 LISP_STRING, set IT->stop_charpos to IT->end_charpos. (The
7594 original value of -1 will not work with bidi.)
7595 (compute_display_string_pos): First arg is now struct
7596 `text_pos *'; all callers changed. Support display properties on
7597 Lisp strings.
7598 (compute_display_string_end): Support display properties on Lisp
7599 strings.
7600 (init_iterator, reseat_1, reseat_to_string): Initialize the
7601 string.bufpos member to 0 (zero, for compatibility with IT_CHARPOS
7602 when iterating on a string not from display properties).
640c8776
SM
7603 (compute_display_string_pos, compute_display_string_end):
7604 Fix calculation of the object to scan. Fixes an error when using
0bb23927
EZ
7605 arrow keys.
7606 (next_element_from_buffer): Don't abort when IT_CHARPOS is before
640c8776
SM
7607 base_level_stop; instead, set base_level_stop to BEGV.
7608 Fixes crashes in vertical-motion.
0bb23927
EZ
7609 (next_element_from_buffer): Improve commentary for when
7610 the iterator is before prev_stop.
7611 (init_iterator): Initialize bidi_p from the default value of
7612 bidi-display-reordering, not from buffer-local value. Use the
7613 buffer-local value only if initializing for buffer iteration.
7614 (handle_invisible_prop): Support invisible properties on strings
7615 that are being bidi-reordered.
7616 (set_iterator_to_next): Support bidi reordering of C strings and
7617 Lisp strings.
7618 (next_element_from_string): Support bidi reordering of Lisp
7619 strings.
7620 (handle_stop_backwards): Support Lisp strings as well.
640c8776
SM
7621 (display_string): Support display of R2L glyph rows.
7622 Use IT_STRING_CHARPOS when displaying from a Lisp string.
0bb23927
EZ
7623 (init_iterator): Don't initialize it->bidi_p for strings
7624 here.
7625 (reseat_to_string): Initialize it->bidi_p for strings here.
7626 (next_element_from_string, next_element_from_c_string)
7627 (next_element_from_buffer): Add xassert's for correspondence
7628 between IT's object being iterated and it->bidi_it.string
7629 structure.
7630 (face_before_or_after_it_pos): Support bidi iteration.
7631 (next_element_from_c_string): Handle the case of the first string
7632 character that is not the first one in the visual order.
7633 (get_visually_first_element): New function, refactored from common
7634 parts of next_element_from_buffer, next_element_from_string, and
7635 next_element_from_c_string.
7636 (tool_bar_lines_needed, redisplay_tool_bar)
7637 (display_menu_bar): Force left-to-right direction. Add a FIXME
7638 comment for making that be controlled by a user option.
7639 (push_it, pop_it): Save and restore the state of the
7640 bidi iterator. Save and restore the bidi_p flag.
7641 (pop_it): Iterate out of display property for string iteration as
7642 well.
7643 (iterate_out_of_display_property): Support iteration over strings.
7644 (handle_single_display_spec): Set up it->bidi_it for iteration
7645 over a display string, and call bidi_init_it.
7646 (handle_single_display_spec, next_overlay_string)
7647 (get_overlay_strings_1, push_display_prop): Set up the bidi
7648 iterator for displaying display or overlay strings.
7649 (forward_to_next_line_start): Don't use the shortcut if
7650 bidi-iterating.
7651 (back_to_previous_visible_line_start): If handle_display_prop
7652 pushed the iterator stack, restore the internal state of the bidi
7653 iterator by calling bidi_pop_it same number of times.
7654 (reseat_at_next_visible_line_start): If ON_NEWLINE_P is non-zero,
7655 and we are bidi-iterating, don't decrement the iterator position;
7656 instead, set the first_elt flag in the bidi iterator, to produce
7657 the same effect.
7658 (reseat_1): Remove redundant setting of string_from_display_prop_p.
7659 (push_display_prop): xassert that we are iterating a buffer.
7660 (push_it, pop_it): Save and restore paragraph_embedding member.
7661 (handle_single_display_spec, next_overlay_string)
7662 (get_overlay_strings_1, reseat_1, reseat_to_string)
7663 (push_display_prop): Set up the `unibyte' member of bidi_it.string
7664 correctly. Don't assume unibyte strings are not bidi-reordered.
7665 (compute_display_string_pos)
7666 (compute_display_string_end): Fix handling the case of C string.
7667 (push_it, pop_it): Save and restore from_disp_prop_p.
7668 (handle_single_display_spec, push_display_prop): Set the
7669 from_disp_prop_p flag.
7670 (get_overlay_strings_1): Reset the from_disp_prop_p flag.
7671 (pop_it): Call iterate_out_of_display_property only if we are
7672 popping after iteration over a string that came from a display
7673 property. Fix a typo in popping stretch info. Add an assertion
7674 for verifying that the iterator position is in sync with the bidi
7675 iterator.
7676 (handle_single_display_spec, get_overlay_strings_1)
7677 (push_display_prop): Fix initialization of paragraph direction for
7678 string when that of the parent object is not yet determined.
7679 (reseat_1): Call bidi_init_it to resync the bidi
7680 iterator with IT's position. (Bug#7616)
7681 (find_row_edges): If ROW->start.pos gives position
7682 smaller than min_pos, use it as ROW->minpos. (Bug#7616)
7683 (handle_stop, back_to_previous_visible_line_start, reseat_1):
7684 Reset the from_disp_prop_p flag.
7685 (SAVE_IT, RESTORE_IT): New macros.
7686 (pos_visible_p, face_before_or_after_it_pos)
7687 (back_to_previous_visible_line_start)
7688 (move_it_in_display_line_to, move_it_in_display_line)
7689 (move_it_to, move_it_vertically_backward, move_it_by_lines)
7690 (try_scrolling, redisplay_window, display_line): Use them when
7691 saving a temporary copy of the iterator and restoring it back.
7692 (back_to_previous_visible_line_start, reseat_1)
7693 (init_iterator): Empty the bidi cache "stack".
7694 (move_it_in_display_line_to): If iterator ended up at
7695 EOL, but we never saw any buffer positions smaller than
7696 to_charpos, return MOVE_POS_MATCH_OR_ZV. Fixes vertical cursor
7697 motion in bidi-reordered lines.
7698 (move_it_in_display_line_to): Record prev_method and prev_pos
7699 immediately before the call to set_iterator_to_next. Fixes cursor
7700 motion in bidi-reordered lines with stretch glyphs and strings
7701 displayed in margins. (Bug#8133) (Bug#8867)
7702 Return MOVE_POS_MATCH_OR_ZV only if iterator position is past
7703 TO_CHARPOS.
640c8776
SM
7704 (pos_visible_p): Support positions in bidi-reordered lines.
7705 Save and restore bidi cache.
0bb23927
EZ
7706
7707 * bidi.c (bidi_level_of_next_char): clen should be EMACS_NT, not int.
7708 (bidi_paragraph_info): Delete unused struct.
7709 (bidi_cache_idx, bidi_cache_last_idx): Declare EMACS_INT.
7710 (bidi_cache_start): New variable.
7711 (bidi_cache_reset): Reset bidi_cache_idx to bidi_cache_start, not
7712 to zero.
7713 (bidi_cache_fetch_state, bidi_cache_search)
7714 (bidi_cache_find_level_change, bidi_cache_iterator_state)
7715 (bidi_cache_find, bidi_peek_at_next_level)
7716 (bidi_level_of_next_char, bidi_find_other_level_edge)
7717 (bidi_move_to_visually_next): Compare cache index with
7718 bidi_cache_start rather than with zero.
7719 (bidi_fetch_char): Accept new argument STRING; all callers
7720 changed. Support iteration over a string. Support strings with
7721 display properties. Support unibyte strings. Fix the type of
7722 `len' according to what STRING_CHAR_AND_LENGTH expects.
7723 (bidi_paragraph_init, bidi_resolve_explicit_1)
7724 (bidi_resolve_explicit, bidi_resolve_weak)
640c8776
SM
7725 (bidi_level_of_next_char, bidi_move_to_visually_next):
7726 Support iteration over a string.
0bb23927
EZ
7727 (bidi_set_sor_type, bidi_resolve_explicit_1)
7728 (bidi_resolve_explicit, bidi_type_of_next_char): ignore_bn_limit
7729 can now be zero (for strings); special values 0 and -1 were
7730 changed to -1 and -2, respectively.
7731 (bidi_char_at_pos): New function.
7732 (bidi_paragraph_init, bidi_resolve_explicit, bidi_resolve_weak):
7733 Call it instead of FETCH_MULTIBYTE_CHAR.
7734 (bidi_move_to_visually_next): Abort if charpos or bytepos were not
7735 initialized to valid values.
7736 (bidi_init_it): Don't initialize charpos and bytepos with invalid
7737 values.
7738 (bidi_level_of_next_char): Allow the sentinel "position" to pass
7739 the test for valid cached positions. Fix the logic for looking up
7740 the sentinel state in the cache. GCPRO the Lisp string we are
7741 iterating.
7742 (bidi_push_it, bidi_pop_it): New functions.
7743 (bidi_initialize): Initialize the bidi cache start stack pointer.
7744 (bidi_cache_ensure_space): New function, refactored from part of
7745 bidi_cache_iterator_state. Don't assume the required size is just
7746 one BIDI_CACHE_CHUNK away.
7747 (bidi_cache_start_stack, bidi_push_it): Use IT_STACK_SIZE.
7748 (bidi_count_bytes, bidi_char_at_pos): New functions.
7749 (bidi_cache_search): Don't assume bidi_cache_last_idx is
7750 always valid if bidi_cache_idx is valid.
7751 (bidi_cache_find_level_change): xassert that bidi_cache_last_idx
7752 is valid if it's going to be used.
7753 (bidi_shelve_cache, bidi_unshelve_cache): New functions.
7754 (bidi_cache_fetch_state, bidi_cache_search)
c965adc5
EZ
7755 (bidi_cache_find_level_change, bidi_cache_ensure_space)
7756 (bidi_cache_iterator_state, bidi_cache_find)
640c8776
SM
7757 (bidi_find_other_level_edge, bidi_cache_start_stack):
7758 All variables related to cache indices are now EMACS_INT.
c965adc5 7759
0bb23927
EZ
7760 * dispextern.h (struct bidi_string_data): New structure.
7761 (struct bidi_it): New member `string'. Make flag members be 1-bit
7762 fields, and put them last in the struct.
640c8776
SM
7763 (compute_display_string_pos, compute_display_string_end):
7764 Update prototypes.
0bb23927
EZ
7765 (bidi_push_it, bidi_pop_it): Add prototypes.
7766 (struct iterator_stack_entry): New members bidi_p,
7767 paragraph_embedding, and from_disp_prop_p.
7768 (struct it): Member bidi_p is now a bit field 1 bit wide.
640c8776
SM
7769 (bidi_shelve_cache, bidi_unshelve_cache):
7770 Declare prototypes.
0bb23927
EZ
7771
7772 * .gdbinit (xvectype, xvector, xcompiled, xchartable, xboolvector)
7773 (xpr, xfont, xbacktrace): Use "header.size" when accessing vectors
7774 and vector-like objects.
7775
7776 * dispnew.c (buffer_posn_from_coords): Save and restore the bidi
7777 cache around display iteration.
7778
7779 * window.c (Fwindow_end, window_scroll_pixel_based)
7780 (displayed_window_lines, Frecenter): Save and restore the bidi
7781 cache around display iteration.
7782
3bbd2265
LMI
77832011-07-14 Lars Magne Ingebrigtsen <larsi@gnus.org>
7784
7785 * editfns.c (Fdelete_region): Clarify the use of the named
7786 parameters (bug#6788).
7787
adc47434
MR
77882011-07-14 Martin Rudalics <rudalics@gmx.at>
7789
7790 * indent.c (Fvertical_motion): Set and restore w->pointm when
7791 saving and restoring the window's buffer (Bug#9006).
7792
837c31f8
LMI
77932011-07-13 Lars Magne Ingebrigtsen <larsi@gnus.org>
7794
7795 * editfns.c (Fstring_to_char): Clarify just what is returned
7796 (bug#6576). Text by Eli Zaretskii.
7797
ac389d0c
JB
77982011-07-13 Juanma Barranquero <lekktu@gmail.com>
7799
7800 * gnutls.c (init_gnutls_functions): Honor gnutls_log_level (bug#9059).
7801
0be0ce47
EZ
78022011-07-13 Eli Zaretskii <eliz@gnu.org>
7803
7804 * buffer.c (mmap_find): Fix a typo.
7805
cd18e7e3
JB
78062011-07-13 Johan Bockgård <bojohan@gnu.org>
7807
7808 Fix execution of x selection hooks.
7809 * xselect.c (Qx_lost_selection_functions)
7810 (Qx_sent_selection_functions): New vars.
7811 (syms_of_xselect): DEFSYM them.
7812 (x_handle_selection_request): Pass Qx_sent_selection_functions
7813 rather than Vx_sent_selection_functions to Frun_hook_with_args.
7814 (x_handle_selection_clear,x_clear_frame_selections):
7815 Pass Qx_lost_selection_functions rather than
7816 Vx_lost_selection_functions to Frun_hook_with_args.
7817
47ea7f44
PE
78182011-07-13 Paul Eggert <eggert@cs.ucla.edu>
7819
ac389d0c 7820 * buffer.c (Fget_buffer_create): Initialize inhibit_shrinking.
2941c447
PE
7821 The old code sometimes used this field without initializing it.
7822
47ea7f44
PE
7823 * alloc.c (gc_sweep): Don't read past end of array.
7824 In theory, the old code could also have corrupted Emacs internals,
7825 though it'd be very unlikely.
7826
bc985c87
AS
78272011-07-12 Andreas Schwab <schwab@linux-m68k.org>
7828
7829 * character.c (Fcharacterp): Don't advertise optional ignored
ac389d0c 7830 argument. (Bug#4026)
bc985c87 7831
0cf34688
LMI
78322011-07-12 Lars Magne Ingebrigtsen <larsi@gnus.org>
7833
b3dadd76
LMI
7834 * keymap.c (syms_of_keymap): Clarify that "modifier" is "modifier
7835 key" (bug#4257).
7836
0cf34688
LMI
7837 * window.c (Fset_window_start): Doc fix (bug#4199).
7838 (Fset_window_hscroll): Ditto.
7839
270768cd
PE
78402011-07-12 Paul Eggert <eggert@cs.ucla.edu>
7841
077e3dda 7842 Fix minor new problems caught by GCC 4.6.1.
270768cd 7843 * term.c (init_tty): Remove unused local.
490011a6 7844 * xsettings.c (store_monospaced_changed): Define this function only
077e3dda 7845 if (defined HAVE_GSETTINGS || defined HAVE_GCONF), as it's
490011a6 7846 not used otherwise.
270768cd 7847
b1f58454
CY
78482011-07-12 Chong Yidong <cyd@stupidchicken.com>
7849
7850 * xdisp.c (Vresize_mini_windows): Minor doc fix (Bug#3300).
7851
22b9578d
LMI
78522011-07-11 Lars Magne Ingebrigtsen <larsi@gnus.org>
7853
6e70ab07
LMI
7854 * xdisp.c (syms_of_xdisp): Make it explicit that the mini-windows
7855 are the mini-buffer and the echo area (bug#3320).
7856
22b9578d
LMI
7857 * term.c (init_tty): Remove support for supdup, c10 and perq
7858 terminals, which are no longer supported (bug#1482).
7859
8974cc9f
JB
78602011-07-10 Johan Bockgård <bojohan@gnu.org>
7861
7862 * xdisp.c (Ftool_bar_lines_needed): Fix WINDOWP check.
7863
a560d974
JD
78642011-07-10 Jan Djärv <jan.h.d@swipnet.se>
7865
7866 * xmenu.c (menu_highlight_callback): Only pass frame to show_help_event
7867 for non-popups (Bug#3642).
7868
1dae0f0a
AS
78692011-07-10 Andreas Schwab <schwab@linux-m68k.org>
7870
268c2c36 7871 * alloc.c (reset_malloc_hooks): Protoize.
1dae0f0a 7872 * buffer.c (mmap_init, mmap_find, mmap_free_1, mmap_enlarge)
268c2c36
AS
7873 (mmap_set_vars, mmap_alloc, mmap_free, mmap_realloc): Likewise.
7874 * cm.c (losecursor): Likewise.
1dae0f0a
AS
7875 * data.c (fmod): Likewise.
7876 * dispnew.c (swap_glyphs_in_rows): Likewise.
7877 * emacs.c (memory_warning_signal): Likewise.
7878 * floatfns.c (float_error): Likewise.
7879 * font.c (check_gstring, check_otf_features, otf_tag_symbol)
7880 (otf_open, font_otf_capability, generate_otf_features)
7881 (font_otf_DeviceTable, font_otf_ValueRecord, font_otf_Anchor):
7882 Likewise.
7883 * image.c (pbm_read_file): Likewise.
7884 * indent.c (string_display_width): Likewise.
7885 * intervals.c (check_for_interval, search_for_interval)
7886 (inc_interval_count, count_intervals, root_interval)
7887 (adjust_intervals_for_insertion, make_new_interval): Likewise.
7888 * lread.c (defalias): Likewise.
268c2c36 7889 * ralloc.c (r_alloc_check): Likewise.
1dae0f0a
AS
7890 * regex.c (set_image_of_range_1, set_image_of_range)
7891 (regex_grow_registers): Likewise.
7892 * sysdep.c (strerror): Likewise.
7893 * termcap.c (valid_filename_p, tprint, main): Likewise.
7894 * tparam.c (main): Likewise.
7895 * unexhp9k800.c (run_time_remap, save_data_space)
7896 (update_file_ptrs, read_header, write_header, calculate_checksum)
7897 (copy_file, copy_rest, display_header): Likewise.
7898 * widget.c (mark_shell_size_user_specified, create_frame_gcs):
7899 Likewise.
7900 * xdisp.c (check_it): Likewise.
7901 * xfaces.c (register_color, unregister_color, unregister_colors):
7902 Likewise.
7903 * xfns.c (print_fontset_result): Likewise.
7904 * xrdb.c (member, fatal, main): Likewise.
7905
99033785
PE
79062011-07-10 Paul Eggert <eggert@cs.ucla.edu>
7907
7908 Fix minor problems found by static checking (Bug#9031).
7909 * chartab.c (char_table_set_range, map_sub_char_table):
7910 Remove unused locals.
7911 (uniprop_table): Now static.
7912 * composite.c (_work_char): Remove unused static var.
7913
9cb2ac56
JB
79142011-07-09 Juanma Barranquero <lekktu@gmail.com>
7915
7916 * chartab.c (uniprop_table_uncompress): Remove unused local variable.
7917
f25661f0
JD
79182011-07-09 Jan Djärv <jan.h.d@swipnet.se>
7919
7920 * gtkutil.c (qttip_cb): Remove code without function.
7921
8278c4fe
EZ
79222011-07-09 Eli Zaretskii <eliz@gnu.org>
7923
7924 * w32.c (pthread_sigmask): New stub.
7925
1692ae2d 79262011-07-08 Paul Eggert <eggert@cs.ucla.edu>
123403e4 7927
8a6ebd58 7928 Use pthread_sigmask, not sigprocmask (Bug#9010).
123403e4
PE
7929 sigprocmask is portable only for single-threaded applications, and
7930 Emacs can be multi-threaded when it uses GTK.
1301ac26
PE
7931 * Makefile.in (LIB_PTHREAD_SIGMASK): New macro.
7932 (LIBES): Use it.
7933 * callproc.c (Fcall_process):
7934 * process.c (create_process):
7935 * sysdep.c (sys_sigblock, sys_sigunblock, sys_sigsetmask):
7936 Use pthread_sigmask, not sigprocmask.
123403e4 7937
1b854618
JD
79382011-07-08 Jan Djärv <jan.h.d@swipnet.se>
7939
7940 * gtkutil.c (qttip_cb): Set line wrap to FALSE for tooltip widget.
7941 (xg_prepare_tooltip): Revert text in x->ttip_lbl, margins was
7942 wrong (Bug#8591).
7943
3fe4b549
JD
79442011-07-08 Jan Djärv <jan.h.d@swipnet.se>
7945
0ce7e563
JD
7946 * gtkutil.c (xg_prepare_tooltip): Fix indentation and comment.
7947 Put text in x->ttip_lbl instead of gtk_tooltip_set_text (Bug#8591).
7948 (xg_hide_tooltip): Fix comment.
7949
3fe4b549
JD
7950 * nsterm.m (initFrameFromEmacs): Don't use ns_return_types
7951 in registerServicesMenuSendTypes.
7952 (validRequestorForSendType): Don't check ns_return_types.
7953
7954 * nsfns.m (Fx_open_connection): Put NSStringPboardType into
7955 ns_return_type.
7956
5df75e47
JR
79572011-07-08 Jason Rumney <jasonr@gnu.org>
7958
22610910
JR
7959 * w32term.c (x_make_frame_visible): Use SH_SHOWNORMAL rather than
7960 SH_SHOW for hidden windows (Bug#5482).
7961
5df75e47
JR
7962 * w32fns.c (w32_wnd_proc) [WM_TIMER, WM_SET_CURSOR]: Avoid using
7963 frame struct members of non-existent frames (Bug#6284).
7964
699c10bd
JD
79652011-07-08 Jan Djärv <jan.h.d@swipnet.se>
7966
4393663b
JD
7967 * nsterm.m (keyDown): Call to wantsToDelayTextChangeNotifications and
7968 variable firstTime not needed on OSX >= 10.6.
7969 (setPosition): setFloatValue:knobProportion: is deprecated on OSX
7970 >= 10.5. Use setKnobProportion, setDoubleValue.
7971
7972 * nsterm.h (MAC_OS_X_VERSION_10_3, MAC_OS_X_VERSION_10_4)
7973 (MAC_OS_X_VERSION_10_5): Define if not defined.
7974 (EmacsView, EmacsTooltip): Implements NSWindowDelegate on OSX >= 10.6.
7975 (EmacsMenu): Implements NSMenuDelegate on OSX >= 10.6.
7976 (EmacsToolbar): Implements NSToolbarDelegate on OSX >= 10.6.
7977
7978 * nsselect.m (ns_string_from_pasteboard): Don't use deprecated methods
090bd7cb 7979 cString and lossyCString on OSX >= 10.4.
4393663b 7980
58179cce 7981 * nsmenu.m (fillWithWidgetValue): Don't use deprecated method
4393663b
JD
7982 sizeToFit on OSX >= 10.2.
7983
7984 * nsimage.m (allocInitFromFile): Don't use deprecated method
7985 bestRepresentationForDevice on OSX >= 10.6.
7986
7987 * nsfns.m (check_ns_display_info): Cast to long and use %ld in error
7988 to avoid warning.
7989
7990 * emacs.c: Declare unexec_init_emacs_zone.
7991
a63e0781
JD
7992 * nsgui.h: Fix compiler warning about gnulib redefining verify.
7993
699c10bd
JD
7994 * nsselect.m (ns_get_local_selection): Change to extern (Bug#8842).
7995
7996 * nsmenu.m (ns_update_menubar): Remove useless setDelegate call
7997 on svcsMenu (Bug#8842).
7998
7999 * nsfns.m (Fx_open_connection): Remove NSStringPboardType from
8000 ns_return_types.
8001 (Fns_list_services): Just return Qnil on 10.6, code not working there.
8002
8003 * nsterm.m (QUTF8_STRING): Declare.
8004 (initFrameFromEmacs): Call registerServicesMenuSendTypes.
8005 (validRequestorForSendType): Return type is (id).
8006 Change indexOfObjectIdenticalTo to indexOfObject.
8007 Check if we have local selection before returning self (Bug#8842).
8008 (writeSelectionToPasteboard): Put local selection into paste board
8009 if we have a local selection (Bug#8842).
8010 (syms_of_nsterm): DEFSYM QUTF8_STRING.
8011
8012 * nsterm.h (MAC_OS_X_VERSION_10_6): Define here instead of nsterm.m.
8013 (ns_get_local_selection): Declare.
8014
54e10184
LMI
80152011-07-07 Lars Magne Ingebrigtsen <larsi@gnus.org>
8016
9888ff71
LMI
8017 * keymap.c (describe_map_tree): Don't insert a double newline at
8018 the end of the buffer (bug#1169) and return whether we inserted
8019 something.
8020
54e10184
LMI
8021 * callint.c (Fcall_interactively): Change "reading args" to
8022 "providing args" to try to clarify what it does (bug#1010).
8023
15fa4783
KH
80242011-07-07 Kenichi Handa <handa@m17n.org>
8025
8026 * composite.c (composition_compute_stop_pos): Ignore a static
8027 composition starting before CHARPOS (Bug#8915).
8028
8029 * xdisp.c (handle_composition_prop): Likewise.
8030
a8815b00
EZ
80312011-07-07 Eli Zaretskii <eliz@gnu.org>
8032
8033 * term.c (produce_glyphs) <xassert>: Allow IT_GLYPHLESS in it->what.
8034 (Bug#9015)
8035
ef7b981d 80362011-07-07 Kenichi Handa <handa@m17n.org>
c805dec0
KH
8037
8038 * character.h (unicode_category_t): New enum type.
8039
8040 * chartab.c (uniprop_decoder_t, uniprop_encoder_t): New types.
8041 (Qchar_code_property_table): New variable.
8042 (UNIPROP_TABLE_P, UNIPROP_GET_DECODER)
8043 (UNIPROP_COMPRESSED_FORM_P): New macros.
8044 (char_table_ascii): Uncompress the compressed values.
8045 (sub_char_table_ref): New arg is_uniprop. Callers changed.
8046 Uncompress the compressed values.
ac389d0c 8047 (sub_char_table_ref_and_range): Likewise.
c805dec0
KH
8048 (char_table_ref_and_range): Uncompress the compressed values.
8049 (sub_char_table_set): New arg is_uniprop. Callers changed.
8050 Uncompress the compressed values.
8051 (sub_char_table_set_range): Args changed. Callers changed.
8052 (char_table_set_range): Adjuted for the above change.
8053 (map_sub_char_table): Delete args default_val and parent. Add arg
8054 top. Give decoded values to a Lisp function.
640c8776 8055 (map_char_table): Adjust for the above change. Give decoded
c805dec0
KH
8056 values to a Lisp function. Gcpro more variables.
8057 (uniprop_table_uncompress)
8058 (uniprop_decode_value_run_length): New functions.
8059 (uniprop_decoder, uniprop_decoder_count): New variables.
8060 (uniprop_get_decoder, uniprop_encode_value_character)
8061 (uniprop_encode_value_run_length, uniprop_encode_value_numeric):
8062 New functions.
8063 (uniprop_encoder, uniprop_encoder_count): New variables.
8064 (uniprop_get_encoder, uniprop_table)
8065 (Funicode_property_table_internal, Fget_unicode_property_internal)
8066 (Fput_unicode_property_internal): New functions.
8067 (syms_of_chartab): DEFSYM Qchar_code_property_table, defsubr
8068 Sunicode_property_table_internal, Sget_unicode_property_internal,
5e617bc2 8069 and Sput_unicode_property_internal. Defvar_lisp
c805dec0
KH
8070 char-code-property-alist.
8071
640c8776 8072 * composite.c (CHAR_COMPOSABLE_P): Adjust for the change of
c805dec0
KH
8073 Vunicode_category_table.
8074
640c8776 8075 * font.c (font_range): Adjust for the change of
c805dec0
KH
8076 Vunicode_category_table.
8077
76b397fb
DN
80782011-07-07 Dan Nicolaescu <dann@ics.uci.edu>
8079
8080 * m/iris4d.h: Remove file, move contents ...
8081 * s/irix6-5.h: ... here.
8082
22b4128e
PE
80832011-07-06 Paul Eggert <eggert@cs.ucla.edu>
8084
8085 Remove unportable assumption about struct layout (Bug#8884).
8a5c77bb
PE
8086 * alloc.c (mark_buffer):
8087 * buffer.c (reset_buffer_local_variables, Fbuffer_local_variables)
8088 (clone_per_buffer_values): Don't assume that
22b4128e
PE
8089 sizeof (struct buffer) is a multiple of sizeof (Lisp_Object).
8090 This isn't true in general, and it's particularly not true
8091 if Emacs is configured with --with-wide-int.
8092 * buffer.h (FIRST_FIELD_PER_BUFFER, LAST_FIELD_PER_BUFFER):
8093 New macros, used in the buffer.c change.
8094
869795d6
JD
80952011-07-05 Jan Djärv <jan.h.d@swipnet.se>
8096
8097 * xsettings.c: Use both GConf and GSettings if both are available.
8098 (store_config_changed_event): Add comment.
8099 (dpyinfo_valid, store_font_name_changed, map_tool_bar_style)
8100 (store_tool_bar_style_changed): New functions.
5e617bc2 8101 (store_monospaced_changed): Add comment. Call dpyinfo_valid.
869795d6
JD
8102 (struct xsettings): Move font inside HAVE_XFT.
8103 (GSETTINGS_TOOL_BAR_STYLE, GSETTINGS_FONT_NAME): New defines.
640c8776 8104 (GSETTINGS_MONO_FONT): Rename from SYSTEM_MONO_FONT.
869795d6 8105 Move inside HAVE_XFT.
640c8776 8106 (something_changed_gsettingsCB): Rename from something_changedCB.
869795d6
JD
8107 Check for changes in GSETTINGS_TOOL_BAR_STYLE and GSETTINGS_FONT_NAME
8108 also.
8109 (GCONF_TOOL_BAR_STYLE, GCONF_FONT_NAME): New defines.
5e617bc2 8110 (GCONF_MONO_FONT): Rename from SYSTEM_MONO_FONT. Move inside HAVE_XFT.
640c8776 8111 (something_changed_gconfCB): Rename from something_changedCB.
869795d6
JD
8112 Check for changes in GCONF_TOOL_BAR_STYLE and GCONF_FONT_NAME also.
8113 (parse_settings): Move check for font inside HAVE_XFT.
8114 (read_settings, apply_xft_settings): Add comment.
8115 (read_and_apply_settings): Add comment. Call map_tool_bar_style and
8116 store_tool_bar_style_changed. Move check for font inside HAVE_XFT and
8117 call store_font_name_changed.
8118 (xft_settings_event): Add comment.
8119 (init_gsettings): Add comment. Get values for GSETTINGS_TOOL_BAR_STYLE
8120 and GSETTINGS_FONT_NAME. Move check for fonts within HAVE_XFT.
8121 (init_gconf): Add comment. Get values for GCONF_TOOL_BAR_STYLE
8122 and GCONF_FONT_NAME. Move check for fonts within HAVE_XFT.
8123 (xsettings_initialize): Call init_gsettings last.
640c8776
SM
8124 (xsettings_get_system_font, xsettings_get_system_normal_font):
8125 Add comment.
869795d6 8126
d8ed26bd
PE
81272011-07-05 Paul Eggert <eggert@cs.ucla.edu>
8128
8129 Random fixes. E.g., (random) never returned negative values.
8130 * fns.c (Frandom): Use GET_EMACS_TIME for random seed, and add the
8131 subseconds part to the entropy, as that's a bit more random.
8132 Prefer signed to unsigned, since the signedness doesn't matter and
8133 in general we prefer signed. When given a limit, use a
8134 denominator equal to INTMASK + 1, not to VALMASK + 1, because the
8135 latter isn't right if USE_2_TAGS_FOR_INTS.
8136 * sysdep.c (get_random): Return a value in the range 0..INTMASK,
8137 not 0..VALMASK. Don't discard "excess" bits that random () returns.
8138
cabf1cac
SM
81392011-07-04 Stefan Monnier <monnier@iro.umontreal.ca>
8140
8141 * textprop.c (text_property_stickiness):
8142 Obey Vtext_property_default_nonsticky.
8143 (syms_of_textprop): Add `display' to Vtext_property_default_nonsticky.
8144 * w32fns.c (syms_of_w32fns):
8145 * xfns.c (syms_of_xfns): Don't Add `display' since it's there by default.
8146
6e9b2be9
PE
81472011-07-04 Paul Eggert <eggert@cs.ucla.edu>
8148
8149 * fileio.c (barf_or_query_if_file_exists): Use S_ISDIR.
8150 This is more efficient than Ffile_directory_p and avoids a minor race.
8151
90186c68
LMI
81522011-07-04 Lars Magne Ingebrigtsen <larsi@gnus.org>
8153
7c301272
LMI
8154 * buffer.c (Foverlay_put): Say what the return value is
8155 (bug#7835).
8156
c4f2d8d4
LMI
8157 * fileio.c (barf_or_query_if_file_exists): Check first if the file
8158 is a directory before asking whether to use the file name
8159 (bug#7564).
ad637907
LMI
8160 (barf_or_query_if_file_exists): Make the "File is a directory"
8161 error be more correct.
c4f2d8d4 8162
90186c68
LMI
8163 * fns.c (Frequire): Remove the mention of the .gz files, since
8164 that's installation-specific, but keep the mention of
8165 `get-load-suffixes'.
8166
da64016e
PE
81672011-07-04 Paul Eggert <eggert@cs.ucla.edu>
8168
8169 * editfns.c (Fformat_time_string): Don't assume strlen fits in int.
8170 Report string overflow if the output is too long.
8171
7d47b580
JB
81722011-07-04 Juanma Barranquero <lekktu@gmail.com>
8173
a555cb87
JB
8174 * gnutls.c (Fgnutls_boot): Don't mention :verify-error.
8175 (syms_of_gnutls): Remove duplicate DEFSYM for
8176 Qgnutls_bootprop_verify_hostname_error, an error for
8177 Qgnutls_bootprop_verify_error (which is no longer used).
8178
7d47b580
JB
8179 * eval.c (find_handler_clause): Remove parameters `sig' and `data',
8180 unused since 2011-01-26T20:02:07Z!monnier@iro.umontreal.ca. All callers changed.
8181 Also (re)move comments that are misplaced or no longer relevant.
8182
1e49bfab
LMI
81832011-07-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
8184
8185 * callint.c (Finteractive): Clarify the meaning of "@" (bug#8813).
8186
1485f4c0
CY
81872011-07-03 Chong Yidong <cyd@stupidchicken.com>
8188
8189 * xfaces.c (Finternal_merge_in_global_face): Modify the foreground
8190 and background color parameters if they have been changed.
8191
a9ab721e
LMI
81922011-07-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
8193
8194 * editfns.c (Fformat): Clarify the - and 0 flags (bug#6659).
8195
cf7cff57
PE
81962011-07-03 Paul Eggert <eggert@cs.ucla.edu>
8197
2e13213d
PE
8198 * xsettings.c (SYSTEM_FONT): Define only when used.
8199 No need to define when HAVE_GSETTINGS || !HAVE_XFT.
8200
cf7cff57
PE
8201 * keymap.c (access_keymap_1): Now static.
8202
7a8e04f7
CY
82032011-07-02 Chong Yidong <cyd@stupidchicken.com>
8204
8205 * keyboard.c (command_loop_1): If a down-mouse event is unbound,
8206 leave any prefix arg for the up event (Bug#1586).
8207
61352f62
LMI
82082011-07-02 Lars Magne Ingebrigtsen <larsi@gnus.org>
8209
69bb1ef7
LMI
8210 * lread.c (syms_of_lread): Mention single symbols defined by
8211 `defvar' or `defconst' (bug#7154).
8212
61352f62 8213 * fns.c (Frequire): Mention .el.gz files (bug#7314).
7b3747f9 8214 (Frequire): Mention get-load-suffixes.
61352f62 8215
28545e04
MR
82162011-07-02 Martin Rudalics <rudalics@gmx.at>
8217
8218 * window.h (window): Remove clone_number slot.
8219 * window.c (Fwindow_clone_number, Fset_window_clone_number):
8220 Remove.
8221 (make_parent_window, make_window, saved_window)
8222 (Fset_window_configuration, save_window_save): Don't deal with
8223 clone numbers.
8224 * buffer.c (Qclone_number): Remove declaration.
8225 (sort_overlays, overlay_strings): Don't deal with clone numbers.
8226
3349e122
SM
82272011-07-02 Stefan Monnier <monnier@iro.umontreal.ca>
8228
8229 Add multiple inheritance to keymaps.
8230 * keymap.c (Fmake_composed_keymap): New function.
8231 (Fset_keymap_parent): Simplify.
8232 (fix_submap_inheritance): Remove.
8233 (access_keymap_1): New function extracted from access_keymap to handle
8234 embedded parents and handle lists of maps.
8235 (access_keymap): Use it.
8236 (Fkeymap_prompt, map_keymap_internal, map_keymap, store_in_keymap)
8237 (Fcopy_keymap): Handle embedded parents.
8238 (Fcommand_remapping, define_as_prefix): Simplify.
8239 (Fkey_binding): Simplify.
8240 (syms_of_keymap): Move minibuffer-local-completion-map,
8241 minibuffer-local-filename-completion-map,
8242 minibuffer-local-must-match-map, and
8243 minibuffer-local-filename-must-match-map to Elisp.
8244 (syms_of_keymap): Defsubr make-composed-keymap.
8245 * keyboard.c (menu_bar_items): Use map_keymap_canonical.
8246 (parse_menu_item): Trivial simplification.
8247
3279eb87
GM
82482011-07-01 Glenn Morris <rgm@gnu.org>
8249
8250 * Makefile.in (SETTINGS_LIBS): Fix typo.
8251
4550efdf
KI
82522011-07-01 Kazuhiro Ito <kzhr@d1.dion.ne.jp> (tiny patch)
8253
8254 * coding.c (Fencode_coding_string): Record the last coding system
8255 used, as the function doc string says (bug#8738).
8256
0949d2b6
JD
82572011-07-01 Jan Djärv <jan.h.d@swipnet.se>
8258
8259 * xsettings.c (store_monospaced_changed): Take new font as arg and
8260 check for change against current_mono_font.
8261 (EMACS_TYPE_SETTINGS): Remove this and related defines.
8262 (emacs_settings_constructor, emacs_settings_get_property)
8263 (emacs_settings_set_property, emacs_settings_class_init)
8264 (emacs_settings_init, gsettings_obj): Remove.
8265 (something_changedCB): New function for HAVE_GSETTINGS.
8266 (something_changedCB): HAVE_GCONF: Call store_monospaced_changed
8267 with value as argument.
8268 (init_gsettings): Check that GSETTINGS_SCHEMA exists before calling
8269 g_settings_new (Bug#8967). Do not create gsettings_obj.
9173deec 8270 Remove calls to g_settings_bind. Connect something_changedCB to
0949d2b6
JD
8271 "changed".
8272
8273 * xgselect.c: Add defined (HAVE_GSETTINGS).
8274 (xgselect_initialize): Ditto.
8275
8276 * process.c: Add defined (HAVE_GSETTINGS) for xgselect.h
8277 (wait_reading_process_output): Add defined (HAVE_GSETTINGS) for
8278 xg_select.
8279
bbc6b304
PE
82802011-07-01 Paul Eggert <eggert@cs.ucla.edu>
8281
8282 * eval.c (struct backtrace): Simplify and port the data structure.
8283 Do not assume that "int nargs : BITS_PER_INT - 2;" produces a
8284 signed bit field, as this assumption is not portable and it makes
8285 Emacs crash when compiled with Sun C 5.8 on sparc. Do not use
8286 "char debug_on_exit : 1" as this is not portable either; instead,
8287 use the portable "unsigned int debug_on_exit : 1". Remove unused
8288 member evalargs. Remove obsolete comments about cc bombing out.
8289
9851bfc5
JD
82902011-06-30 Jan Djärv <jan.h.d@swipnet.se>
8291
51bb811f 8292 * xsettings.c: Include glib-object.h, gio/gio.h if HAVE_GSETTINGS.
9851bfc5
JD
8293 Let HAVE_GSETTINGS override HAVE_GCONF.
8294 (store_monospaced_changed): New function.
8295 (EMACS_SETTINGS): A new type derived from GObject to handle
8296 GSettings notifications.
8297 (emacs_settings_constructor, emacs_settings_get_property)
8298 (emacs_settings_set_property, emacs_settings_class_init):
8299 New functions.
8300 (gsettings_client, gsettings_obj): New variables.
8301 (GSETTINGS_SCHEMA): New define.
8302 (something_changedCB): Call store_monospaced_changed.
8303 (init_gsettings): New function.
8304 (xsettings_initialize): Call init_gsettings.
8305 (syms_of_xsettings): Initialize gsettings_client, gsettings_obj
8306 to NULL.
8307
640c8776 8308 * Makefile.in (SETTINGS_CFLAGS, SETTINGS_LIBS): Rename from
9851bfc5
JD
8309 GCONF_CFLAGS/LIBS.
8310
5386012d
MR
83112011-06-29 Martin Rudalics <rudalics@gmx.at>
8312
8313 * window.c (resize_root_window, grow_mini_window)
8314 (shrink_mini_window): Rename Qresize_root_window to
8315 Qwindow_resize_root_window and Qresize_root_window_vertically to
8316 Qwindow_resize_root_window_vertically.
8317
f13e0b08
PE
83182011-06-28 Paul Eggert <eggert@cs.ucla.edu>
8319
8320 * gnutls.c (Qgnutls_bootprop_verify_error): Remove unused var.
8321
94515237
JB
83222011-06-27 Juanma Barranquero <lekktu@gmail.com>
8323
8324 * makefile.w32-in: Redesign dependencies so they reflect more
8325 clearly which files are directly included by each source file,
8326 and not through other includes.
8327
e43b6e43
MR
83282011-06-27 Martin Rudalics <rudalics@gmx.at>
8329
8330 * buffer.c (Qclone_number): Declare static and DEFSYM it.
8331 (sort_overlays, overlay_strings): When an overlay's clone number
8332 matches the window's clone number process the overlay even if
8333 the overlay's window property doesn't match the current window.
8334
d68443dc
MR
8335 * window.c (Fwindow_vchild): Rename to Fwindow_top_child.
8336 (Fwindow_hchild): Rename to Fwindow_left_child.
8337 (Fwindow_next): Rename to Fwindow_next_sibling.
8338 (Fwindow_prev): Rename to Fwindow_prev_sibling.
d615d6d2
MR
8339 (resize_window_check): Rename to window_resize_check.
8340 (resize_window_apply): Rename to window_resize_apply.
8341 (Fresize_window_apply): Rename to Fwindow_resize_apply.
8342 (Fdelete_other_windows_internal, resize_frame_windows)
8343 (Fsplit_window_internal, Fdelete_window_internal)
8344 (grow_mini_window, shrink_mini_window)
8345 (Fresize_mini_window_internal): Fix callers accordingly.
d68443dc 8346
c7e73be5
JD
83472011-06-26 Jan Djärv <jan.h.d@swipnet.se>
8348
8349 * emacsgtkfixed.h: State that this is only used with Gtk+3.
8350 (emacs_fixed_set_min_size): Remove.
8351 (emacs_fixed_new): Take frame as argument.
8352
8353 * emacsgtkfixed.c: State that this is only used with Gtk+3.
8354 (_EmacsFixedPrivate): Remove minwidth/height.
8355 Add struct frame *f.
8356 (emacs_fixed_init): Initialize priv->f.
8357 (get_parent_class, emacs_fixed_set_min_size): Remove.
8358 (emacs_fixed_new): Set priv->f to argument.
8359 (emacs_fixed_get_preferred_width)
8360 (emacs_fixed_get_preferred_height): Use min_width/height from
8361 frames size_hint to set minimum and natural (Bug#8919).
8362 (XSetWMSizeHints, XSetWMNormalHints): Override these functions
8363 and use min_width/height from frames size_hint to set
8364 min_width/height (Bug#8919).
8365
8366 * gtkutil.c (xg_create_frame_widgets): Pass f to emacs_fixed_new.
9173deec
JB
8367 (x_wm_set_size_hint): Remove call to emacs_fixed_set_min_size.
8368 Fix indentation.
c7e73be5 8369
cf99dcf8
EZ
83702011-06-26 Eli Zaretskii <eliz@gnu.org>
8371
8372 * bidi.c (bidi_paragraph_init): Test for ZV_BYTE before calling
8373 bidi_at_paragraph_end, since fast_looking_at doesn't like to be
8374 called at ZV.
8375
029529ac
CY
83762011-06-26 Chong Yidong <cyd@stupidchicken.com>
8377
8378 * process.c (wait_reading_process_output): Bypass select if
8379 waiting for a cell while ignoring keyboard input, and input is
8380 pending. Suggested by Jan Djärv (Bug#8869).
8381
7a7ef429
PE
83822011-06-25 Paul Eggert <eggert@cs.ucla.edu>
8383
8384 Use gnulib's dup2 module instead of rolling our own.
8385 * sysdep.c (dup2) [!HAVE_DUP2]: Remove; gnulib now does this.
8386
11fdef7d 83872011-06-25 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
989b42d2
YM
8388
8389 * dispnew.c (scrolling_window): Before scrolling, turn off a
8390 mouse-highlight in the window being scrolled.
8391
cd3520a4
JB
83922011-06-24 Juanma Barranquero <lekktu@gmail.com>
8393
8394 Move DEFSYM to lisp.h and use everywhere.
8395
8396 * character.h (DEFSYM): Move declaration...
8397 * lisp.h (DEFSYM): ...here.
8398
8399 * gnutls.c:
8400 * minibuf.c:
8401 * w32menu.c:
8402 * w32proc.c:
8403 * w32select.c: Don't include character.h.
8404
8405 * alloc.c (syms_of_alloc):
8406 * buffer.c (syms_of_buffer):
8407 * bytecode.c (syms_of_bytecode):
8408 * callint.c (syms_of_callint):
8409 * casefiddle.c (syms_of_casefiddle):
8410 * casetab.c (init_casetab_once):
8411 * category.c (init_category_once, syms_of_category):
8412 * ccl.c (syms_of_ccl):
8413 * cmds.c (syms_of_cmds):
8414 * composite.c (syms_of_composite):
8415 * dbusbind.c (syms_of_dbusbind):
8416 * dired.c (syms_of_dired):
8417 * dispnew.c (syms_of_display):
8418 * doc.c (syms_of_doc):
8419 * editfns.c (syms_of_editfns):
8420 * emacs.c (syms_of_emacs):
8421 * eval.c (syms_of_eval):
8422 * fileio.c (syms_of_fileio):
8423 * fns.c (syms_of_fns):
8424 * frame.c (syms_of_frame):
8425 * fringe.c (syms_of_fringe):
8426 * insdel.c (syms_of_insdel):
8427 * keymap.c (syms_of_keymap):
8428 * lread.c (init_obarray, syms_of_lread):
8429 * macros.c (syms_of_macros):
8430 * msdos.c (syms_of_msdos):
8431 * print.c (syms_of_print):
8432 * process.c (syms_of_process):
8433 * search.c (syms_of_search):
8434 * sound.c (syms_of_sound):
8435 * syntax.c (init_syntax_once, syms_of_syntax):
8436 * terminal.c (syms_of_terminal):
8437 * textprop.c (syms_of_textprop):
8438 * undo.c (syms_of_undo):
8439 * w32.c (globals_of_w32):
8440 * window.c (syms_of_window):
8441 * xdisp.c (syms_of_xdisp):
8442 * xfaces.c (syms_of_xfaces):
8443 * xfns.c (syms_of_xfns):
8444 * xmenu.c (syms_of_xmenu):
8445 * xsettings.c (syms_of_xsettings):
8446 * xterm.c (syms_of_xterm): Use DEFSYM.
8447
4228cf16
TZ
84482011-06-24 Teodor Zlatanov <tzz@lifelogs.com>
8449
cd3520a4 8450 * gnutls.c (syms_of_gnutls): Use the DEFSYM macro from character.h.
4228cf16 8451
7fcccf1e
PE
84522011-06-23 Paul Eggert <eggert@cs.ucla.edu>
8453
7efb4e0e
PE
8454 Integer and buffer overflow fixes (Bug#8873).
8455
ff5844ad
PE
8456 * print.c (printchar, strout): Check for string overflow.
8457 (PRINTPREPARE, printchar, strout):
8458 Don't set size unless allocation succeeds.
8459
90532f02
PE
8460 * minibuf.c (read_minibuf_noninteractive): Use ptrdiff_t, not int,
8461 for sizes. Check for string overflow more accurately.
8462 Simplify newline removal at end; this suppresses a GCC 4.6.0 warning.
8463
6d84508d
PE
8464 * macros.c: Integer and buffer overflow fixes.
8465 * keyboard.h (struct keyboard.kbd_macro_bufsize):
8466 * macros.c (Fstart_kbd_macro, store_kbd_macro_char):
8467 Use ptrdiff_t, not int, for sizes.
8468 Don't increment bufsize until after realloc succeeds.
8469 Check for size-calculation overflow.
8470 (Fstart_kbd_macro): Use EMACS_INT, not int, for XINT result.
8471
437b2cb4
PE
8472 * lisp.h (DEFVAR_KBOARD): Use offsetof instead of char * finagling.
8473
8b9ac8b4
PE
8474 * lread.c: Integer overflow fixes.
8475 (read_integer): Radix is now EMACS_INT, not int,
8476 to improve quality of diagnostics for out-of-range radices.
8477 Calculate buffer size correctly for out-of-range radices.
8478 (read1): Check for integer overflow in radices, and in
8479 read-circle numbers.
82cb60d3
PE
8480 (read_escape): Avoid int overflow.
8481 (Fload, openp, read_buffer_size, read1)
8482 (substitute_object_recurse, read_vector, read_list, map_obarray):
8483 Use ptrdiff_t, not int, for sizes.
8484 (read1): Use EMACS_INT, not int, for sizes.
20270765 8485 Check for size overflow.
8b9ac8b4 8486
7fcccf1e
PE
8487 * image.c (cache_image): Check for size arithmetic overflow.
8488
bfbbd7e7
PE
8489 * lread.c: Integer overflow issues.
8490 (saved_doc_string_size, saved_doc_string_length)
8491 (prev_saved_doc_string_size, prev_saved_doc_string_length):
8492 Now ptrdiff_t, not int.
8493 (read1): Don't assume doc string length fits in int. Check for
8494 out-of-range doc string lengths.
8495 (read_list): Don't assume file position fits in int.
39019e54 8496 (read_escape): Check for hex character overflow.
bfbbd7e7 8497
4e323265
LL
84982011-06-22 Leo Liu <sdl.web@gmail.com>
8499
8500 * minibuf.c (Fcompleting_read_default, Vcompleting_read_function):
8501 Move to minibuffer.el.
8502
85fece3e
PE
85032011-06-22 Paul Eggert <eggert@cs.ucla.edu>
8504
20b84ce9 8505 Fixes for GLYPH_DEBUG found by GCC 4.6.0 static checking.
85fece3e
PE
8506 The following patches are for when GLYPH_DEBUG && !XASSERT.
8507 * dispextern.h (trace_redisplay_p, dump_glyph_string):
8508 * dispnew.c (flush_stdout):
8509 * xdisp.c (dump_glyph_row, dump_glyph_matrix, dump_glyph):
8510 Mark as externally visible.
8511 * dispnew.c (check_window_matrix_pointers): Now static.
8512 * dispnew.c (window_to_frame_vpos):
8513 * xfns.c (unwind_create_frame):
8514 * xterm.c (x_check_font): Remove unused local.
8515 * scroll.c (CHECK_BOUNDS):
8516 * xfaces.c (cache_fache): Rename local to avoid shadowing.
8517 * xfns.c, w32fns.c (image_cache_refcount, dpyinfo_refcount): Now static.
8518 * xdisp.c (check_window_end): Now a no-op if !XASSERTS.
8519 (debug_first_unchanged_at_end_vpos, debug_last_unchanged_at_beg_vpos)
8520 (debug_dvpos, debug_dy, debug_delta, debug_delta_bytes, debug_end_vpos):
8521 Now static.
8522 (debug_method_add): Use va_list and vsprintf rather than relying
8523 on undefined behavior with wrong number of arguments.
8524 (dump_glyph, dump_glyph_row, Fdump_glyph_matrix):
8525 Don't assume ptrdiff_t and EMACS_INT are the same width as int.
8526 In this code, it's OK to assume C99 behavior for ptrdiff_t formats
8527 since we're not interested in debugging glyphs with old libraries.
8528 * xfaces.c (cache_face): Move debugging code earlier; this pacifies
8529 GCC 4.6.0's static checking.
8530
0766b489
PE
85312011-06-22 Paul Eggert <eggert@cs.ucla.edu>
8532
31fd4b32
PE
8533 Integer overflow and signedness fixes (Bug#8873).
8534 A few related buffer overrun fixes, too.
8535
b79e8648
PE
8536 * font.c (font_score): Use EMACS_INT, not int, to store XINT value.
8537
0766b489
PE
8538 * dispextern.h (struct face.stipple):
8539 * image.c (x_bitmap_height, x_bitmap_width, x_bitmap_pixmap)
8540 (x_bitmap_mask, x_allocate_bitmap_record)
8541 (x_create_bitmap_from_data, x_create_bitmap_from_file)
8542 (x_destroy_bitmap, x_destroy_all_bitmaps, x_create_bitmap_mask)
8543 (x_create_bitmap_from_xpm_data):
8544 * nsterm.h (struct ns_display_info.bitmaps_size, .bitmaps_last):
8545 * w32term.h (struct w32_display_info.icon_bitmap_id, .bitmaps_size)
8546 (.bitmaps_last):
8547 * xfaces.c (load_pixmap):
8548 * xterm.c (x_bitmap_icon, x_wm_set_icon_pixmap):
8549 * xterm.h (struct x_display_info.icon_bitmap_id, .bitmaps_size)
8550 (.bitmaps_last, struct x_output.icon_bitmap):
8551 Use ptrdiff_t, not int, for bitmap indexes.
8552 (x_allocate_bitmap_record): Check for size overflow.
8553 * dispextern.h, lisp.h: Adjust to API changes elsewhere.
8554
b081724f
PE
8555 Use ptrdiff_t, not int, for overlay counts.
8556 * buffer.h (overlays_at, sort_overlays, GET_OVERLAYS_AT):
8557 * editfns.c (overlays_around, get_pos_property):
8558 * textprop.c (get_char_property_and_overlay):
8559 * xdisp.c (next_overlay_change, note_mouse_highlight):
8560 * xfaces.c (face_at_buffer_position):
21514da7
PE
8561 * buffer.c (OVERLAY_COUNT_MAX): New macro.
8562 (overlays_at, overlays_in, sort_overlays, Foverlays_at)
8563 (Fnext_overlay_change, Fprevious_overlay_change)
8564 (mouse_face_overlay_overlaps, Foverlays_in):
b081724f 8565 Use ptrdiff_t, not int, for sizes.
21514da7 8566 (overlays_at, overlays_in): Check for size-calculation overflow.
b081724f 8567
3de73e5e
PE
8568 * xterm.c (xim_initialize, same_x_server): Strlen may not fit in int.
8569
2606c57b
PE
8570 * xsmfns.c (smc_save_yourself_CB, x_session_initialize): Avoid strlen.
8571 (x_session_initialize): Do not assume string length fits in int.
8572
aaafe47a
PE
8573 * xsettings.c (apply_xft_settings): Fix potential buffer overrun.
8574 This is unlikely, but can occur if DPI is outlandish.
8575
2674ddc8 8576 * xsettings.c (Ffont_get_system_normal_font, Ffont_get_system_font):
3a5077c5
PE
8577 * xselect.c (Fx_get_atom_name): Avoid need for strlen.
8578
28154962
PE
8579 * xrdb.c: Don't assume strlen fits in int; avoid some strlens.
8580 * xrdb.c (magic_file_p, search_magic_path):
8581 Omit last arg SUFFIX; it was always 0. All callers changed.
8582 (magic_file_p): Use ptrdiff_t, not int. Check for size overflow.
8583
7de51af5
PE
8584 * xfont.c (xfont_match): Avoid need for strlen.
8585
25ed6cc3
PE
8586 * xfns.c: Don't assume strlen fits in int.
8587 (xic_create_fontsetname, x_window): Use ptrdiff_t, not int.
8588
4eab31dd
PE
8589 * xdisp.c (message_log_check_duplicate): Return intmax_t,
8590 not unsigned long, as we prefer signed integers. All callers changed.
8591 Detect integer overflow in repeat count.
8592 (message_dolog): Don't assume print length fits in 39 bytes.
df1f27af 8593 (display_mode_element): Don't assume strlen fits in int.
4eab31dd 8594
171e2a58
PE
8595 * termcap.c: Don't assume sizes fit in int and never overflow.
8596 (struct termcap_buffer, tgetent): Use ptrdiff_t, not int, for sizes.
8597 (gobble_line): Check for size-calculation overflow.
8598
ad39faca 8599 * minibuf.c (Fread_buffer):
6e5bb2dc 8600 * lread.c (intern, intern_c_string):
74ca2eb3
PE
8601 * image.c (xpm_scan) [HAVE_NS && !HAVE_XPM]:
8602 Don't assume string length fits in int.
8603
52c61c22 8604 * keyboard.c (parse_tool_bar_item):
9bda3520
PE
8605 * gtkutil.c (style_changed_cb): Avoid need for strlen.
8606
b5b8c9e5
PE
8607 * font.c: Don't assume string length fits in int.
8608 (font_parse_xlfd, font_parse_fcname, font_unparse_fcname):
8609 Use ptrdiff_t, not int.
ccd6111c
PE
8610 (font_intern_prop): Don't assume string length fits in int.
8611 Don't assume integer property fits in fixnum.
8612 * font.h (font_intern_prop): 2nd arg is now ptrdiff_t, not int.
b5b8c9e5 8613
882f0d81 8614 * filelock.c: Fix some buffer overrun and integer overflow issues.
51cab52b 8615 (get_boot_time): Don't assume gzip command string fits in 100 bytes.
882f0d81
PE
8616 Reformulate so as not to need the command string.
8617 Invoke gzip -cd rather than gunzip, as it's more portable.
8618 (lock_info_type, lock_file_1, lock_file):
8619 Don't assume pid_t and time_t fit in unsigned long.
8620 (LOCK_PID_MAX): Remove; we now use more-reliable bounds.
8621 (current_lock_owner): Prefer signed type for sizes.
8622 Use memcpy, not strncpy, where memcpy is what is really wanted.
8623 Don't assume (via atoi) that time_t and pid_t fit in int.
8624 Check for time_t and/or pid_t out of range, e.g., via a network share.
8625 Don't alloca where an auto var works fine.
8626
93f4cf88
PE
8627 * fileio.c: Fix some integer overflow issues.
8628 (file_name_as_directory, Fexpand_file_name, Fsubstitute_in_file_name):
8629 Don't assume string length fits in int.
8630 (directory_file_name): Don't assume string length fits in long.
8631 (make_temp_name): Don't assume pid fits in int, or that its print
8632 length is less than 20.
8633
f3e92b69
PE
8634 * data.c (Fsubr_name): Rewrite to avoid a strlen call.
8635
1bfdaf10
PE
8636 * coding.c (make_subsidiaries): Don't assume string length fits in int.
8637
35016e9a
PE
8638 * callproc.c (child_setup): Rewrite to avoid two strlen calls.
8639
3d1e65a1
PE
8640 * process.c (Fformat_network_address): Use EMACS_INT, not EMACS_UINT.
8641 We prefer signed integers, even for size calculations.
8642
0b963a93
PE
8643 * emacs.c: Don't assume string length fits in 'int'.
8644 (DEFINE_DUMMY_FUNCTION, sort_args): Use ptrdiff_t, not int.
8645 (main): Don't invoke strlen when not needed.
8646
573f4b54
PE
8647 * dbusbind.c (XD_ERROR): Don't arbitrarily truncate string.
8648 (XD_DEBUG_MESSAGE): Don't waste a byte.
8649
989f33ba
PE
8650 * callproc.c (getenv_internal_1, getenv_internal)
8651 (Fgetenv_internal):
965d34eb
PE
8652 * buffer.c (init_buffer): Don't assume string length fits in 'int'.
8653
e4d29b33
PE
8654 * lread.c (invalid_syntax): Omit length argument.
8655 All uses changed. This doesn't fix a bug, but it simplifies the
8656 code away from its former Hollerith-constant appearance, and it's
8657 one less 'int' to worry about when looking at integer-overflow issues.
51cab52b 8658 (string_to_number): Simplify 2011-04-26 change by invoking xsignal1.
e4d29b33 8659
eb49b136
PE
8660 * lisp.h (DEFUN): Remove bogus use of sizeof (struct Lisp_Subr).
8661 This didn't break anything, but it didn't help either.
8662 It's confusing to put a bogus integer in a place where the actual
8663 value does not matter.
9f62aeb1 8664 (LIST_END_P): Remove unused macro and its bogus comment.
cbeff735 8665 (make_fixnum_or_float): Remove unnecessary cast to EMACS_INT.
eb49b136 8666
15375a22
PE
8667 * lisp.h (union Lisp_Object.i): EMACS_INT, not EMACS_UINT.
8668 This is for consistency with the ordinary, non-USE_LISP_UNION_TYPE,
8669 implementation.
b61cc01c
PE
8670 (struct Lisp_Bool_Vector.size): EMACS_INT, not EMACS_UINT.
8671 We prefer signed types, and the value cannot exceed the EMACS_INT
8672 range anyway (because otherwise the length would not be representable).
9a8e8d9b
PE
8673 (XSET) [USE_LISP_UNION_TYPE]: Use uintptr_t and intptr_t,
8674 not EMACS_UINT and EMACS_INT, when converting pointer to integer.
8675 This avoids a GCC warning when WIDE_EMACS_INT.
15375a22 8676
53b2623d
PE
8677 * indent.c (sane_tab_width): New function.
8678 (current_column, scan_for_column, Findent_to, position_indentation)
8679 (compute_motion): Use it. This is just for clarity.
8fcaf9cc 8680 (Fcompute_motion): Don't assume hscroll and tab offset fit in int.
53b2623d 8681
51cab52b 8682 * image.c (xbm_image_p): Don't assume stated width, height fit in int.
45aebb64 8683
f2ed8a70
PE
8684 * lisp.h (lint_assume): New macro.
8685 * composite.c (composition_gstring_put_cache):
8686 * ftfont.c (ftfont_shape_by_flt): Use it to pacify GCC 4.6.0.
8687
abe80cc6
PE
8688 * editfns.c, insdel.c:
8689 Omit unnecessary forward decls, to simplify future changes.
a9e860e1 8690
b02c740e
PE
8691 * ftfont.c (ftfont_shape_by_flt): Use signed integers for lengths.
8692
ebc96716
PE
8693 * font.c (Ffont_shape_gstring): Don't assume glyph len fits in 'int'.
8694
b4e50fa0 8695 * fns.c (Ffillarray): Don't assume bool vector size fits in 'int'.
f03dc6ef 8696 Use much-faster test for byte-length change.
311d5d7c 8697 Don't assume string byte-length fits in 'int'.
a4cf38e4 8698 Check that character arg fits in 'int'.
85461888 8699 (mapcar1): Declare byte as byte, for clarity.
b4e50fa0 8700
c0c1ee9f
PE
8701 * alloc.c (Fmake_bool_vector): Avoid unnecessary multiplication.
8702
a498d7f4
PE
8703 * fns.c (concat): Catch string overflow earlier.
8704 Do not rely on integer wraparound.
8705
51cab52b
PE
8706 * dispextern.h (struct it.overlay_strings_charpos)
8707 (struct it.selective): Now EMACS_INT, not int.
87830974
PE
8708 * xdisp.c (forward_to_next_line_start)
8709 (back_to_previous_visible_line_start)
8710 (reseat_at_next_visible_line_start, next_element_from_buffer):
8711 Don't arbitrarily truncate the value of 'selective' to int.
8712
76031fad
PE
8713 * xdisp.c (init_iterator): Use XINT, not XFASTINT; it might be < 0.
8714
5eb55db9
PE
8715 * composite.c: Don't truncate sizes to 'int'.
8716 (composition_gstring_p, composition_reseat_it)
8717 (composition_adjust_point): Use EMACS_INT, not int.
7d100a81
PE
8718 (get_composition_id, composition_gstring_put_cache): Use EMACS_INT,
8719 not EMACS_UINT, for indexes.
5eb55db9 8720
0703a717
PE
8721 * category.h (CATEGORY_SET_P): Remove unnecessary cast to EMACS_INT.
8722
d6202519
PE
8723 * buffer.c: Include <verify.h>.
8724 (struct sortvec.priority, struct sortstr.priority):
8961a454 8725 Now EMACS_INT, not int.
c20998a7 8726 (compare_overlays, cmp_for_strings): Avoid subtraction overflow.
67c36fce
PE
8727 (struct sortstr.size, record_overlay_string)
8728 (struct sortstrlist.size, struct sortlist.used):
8729 Don't truncate size to int.
8730 (record_overlay_string): Check for size-calculation overflow.
d6202519 8731 (init_buffer_once): Check at compile-time, not run-time.
fadf4e30 8732
d5a19415
JM
87332011-06-22 Jim Meyering <meyering@redhat.com>
8734
029529ac 8735 Don't leak an XBM-image-sized buffer
d5a19415
JM
8736 * image.c (xbm_load): Free the image buffer after using it.
8737
a9041e6c
PE
87382011-06-21 Paul Eggert <eggert@cs.ucla.edu>
8739
8740 Port to Sun C.
8741 * composite.c (find_automatic_composition): Omit needless 'return 0;'
8742 that Sun C diagnosed.
8743 * fns.c (secure_hash): Fix pointer signedness issue.
8744 * intervals.c (static_offset_intervals): New function.
8745 (offset_intervals): Use it.
8746
7f3f739f
LL
87472011-06-21 Leo Liu <sdl.web@gmail.com>
8748
8749 * deps.mk (fns.o):
8750 * makefile.w32-in ($(BLD)/fns.$(O)): Include sha256.h and
8751 sha512.h.
8752
8753 * fns.c (secure_hash): Rename from crypto_hash_function and change
8754 the first arg to accept symbols.
5b66d427 8755 (Fsecure_hash): New primitive.
7f3f739f
LL
8756 (syms_of_fns): New symbols.
8757
76147d94
DD
87582011-06-20 Deniz Dogan <deniz@dogan.se>
8759
8760 * process.c (Fset_process_buffer): Clarify return value in
8761 docstring.
8762
7d7d0045
CY
87632011-06-18 Chong Yidong <cyd@stupidchicken.com>
8764
8765 * dispnew.c (add_window_display_history): Use BVAR.
8766
8767 * xdisp.c (debug_method_add): Use BVAR.
8768 (check_window_end, dump_glyph_matrix, dump_glyph)
8769 (dump_glyph_row, dump_glyph_string): Convert arglist to ANSI C.
8770
8771 * xfaces.c (check_lface_attrs, check_lface, dump_realized_face):
8772 Likewise.
8773
8774 * xfns.c (Fx_create_frame, x_create_tip_frame): Delay image cache
8775 check till after the cache is created in init_frame_faces.
8776
ff2bc410
SM
87772011-06-17 Stefan Monnier <monnier@iro.umontreal.ca>
8778
8779 * fns.c (Fsafe_length): Yet another int/Lisp_Object mixup.
8780
28177add
PE
87812011-06-16 Paul Eggert <eggert@cs.ucla.edu>
8782
dd3482fe
PE
8783 * lisp.h: Include <limits.h>, for INT_MAX, LONG_MAX, LLONG_MAX.
8784 Without this, prin1 mishandles Lisp_Misc_Save_Value printing on
8785 hosts with pre-C99 libraries, because pD is wrongly defined to "t".
8786
393d71f3 8787 Improve buffer-overflow checking (Bug#8873).
1c8e352f
PE
8788 * fileio.c (Finsert_file_contents):
8789 * insdel.c (insert_from_buffer_1, replace_range, replace_range_2):
8790 Remove the old (too-loose) buffer overflow checks.
8791 They weren't needed, since make_gap checks for buffer overflow.
8792 * insdel.c (make_gap_larger): Catch buffer overflows that were missed.
8793 The old code merely checked for Emacs fixnum overflow, and relied
8794 on undefined (wraparound) behavior. The new code avoids undefined
8795 behavior, and also checks for ptrdiff_t and/or size_t overflow.
8796
2e6813b0 8797 * editfns.c (Finsert_char): Don't dump core with very negative counts.
21d890a4
PE
8798 Tune. Don't use wider integers than needed. Don't use alloca.
8799 Use a bigger 'string' buffer. Rewrite to avoid 'n > 0' test.
2e6813b0 8800
599a9e4f
PE
8801 * insdel.c (replace_range): Fix buf overflow when insbytes < outgoing.
8802
99561444
PE
8803 * insdel.c, lisp.h (buffer_overflow): New function.
8804 (insert_from_buffer_1, replace_range, replace_range_2):
8805 * insdel.c (make_gap_larger):
8806 * editfns.c (Finsert_char):
8807 * fileio.c (Finsert_file_contents): Use it, to normalize wording.
8808
28177add
PE
8809 * buffer.h (BUF_BYTES_MAX): Cast to ptrdiff_t so that it's signed.
8810
e69dafad
PE
88112011-06-15 Paul Eggert <eggert@cs.ucla.edu>
8812
4baa020d 8813 Integer overflow and signedness fixes (Bug#8873, Bug#8828).
ff672d2c 8814
b1c46f02
PE
8815 * ccl.c (ASCENDING_ORDER): New macro, to work around GCC bug 43772.
8816 (GET_CCL_RANGE, IN_INT_RANGE): Use it.
8817
e69dafad
PE
8818 * fileio.c: Don't assume EMACS_INT fits in off_t.
8819 (emacs_lseek): New static function.
8820 (Finsert_file_contents, Fwrite_region): Use it.
8821 Use SEEK_SET, SEEK_CUR, SEEK_END as appropriate.
8822
566684ea
PE
8823 * fns.c (Fload_average): Don't assume 100 * load average fits in int.
8824
e6966cd6
PE
8825 * fns.c: Don't overflow int when computing a list length.
8826 * fns.c (QUIT_COUNT_HEURISTIC): New constant.
8827 (Flength, Fsafe_length): Use EMACS_INT, not int, to avoid unwanted
8828 truncation on 64-bit hosts. Check for QUIT every
8829 QUIT_COUNT_HEURISTIC entries rather than every other entry; that's
8830 faster and is responsive enough.
8831 (Flength): Report an error instead of overflowing an integer.
8832 (Fsafe_length): Return a float if the value is not representable
8833 as a fixnum. This shouldn't happen except in contrived situations.
6346d301 8834 (Fnthcdr, Fsort): Don't assume list length fits in int.
de41a810 8835 (Fcopy_sequence): Don't assume vector length fits in int.
00c604f2 8836
dd0b0efb
PE
8837 * alloc.c: Check that resized vectors' lengths fit in fixnums.
8838 (header_size, word_size): New constants.
8839 (allocate_vectorlike): Don't check size overflow here.
8840 (allocate_vector): Check it here instead, since this is the only
8841 caller of allocate_vectorlike that could cause overflow.
8842 Check that the new vector's length is representable as a fixnum.
8843
86fe5cfe
PE
8844 * fns.c (next_almost_prime): Don't return a multiple of 3 or 5.
8845 The previous code was bogus. For example, next_almost_prime (32)
8846 returned 39, which is undesirable as it is a multiple of 3; and
8847 next_almost_prime (24) returned 25, which is a multiple of 5 so
8848 why was the code bothering to check for multiples of 7?
8849
80e88859
PE
8850 * bytecode.c (exec_byte_code): Use ptrdiff_t, not int, for vector length.
8851
4a2f0ad6
PE
8852 * eval.c, doprnt.c (SIZE_MAX): Remove; inttypes.h defines this now.
8853
f66c7cf8
PE
8854 Variadic C functions now count arguments with ptrdiff_t.
8855 This partly undoes my 2011-03-30 change, which replaced int with size_t.
8856 Back then I didn't know that the Emacs coding style prefers signed int.
8857 Also, in the meantime I found a few more instances where arguments
4a2f0ad6
PE
8858 were being counted with int, which may truncate counts on 64-bit
8859 machines, or EMACS_INT, which may be unnecessarily wide.
f66c7cf8
PE
8860 * lisp.h (struct Lisp_Subr.function.aMANY)
8861 (DEFUN_ARGS_MANY, internal_condition_case_n, safe_call):
8862 Arg counts are now ptrdiff_t, not size_t.
8863 All variadic functions and their callers changed accordingly.
8864 (struct gcpro.nvars): Now size_t, not size_t. All uses changed.
8865 * bytecode.c (exec_byte_code): Check maxdepth for overflow,
8866 to avoid potential buffer overrun. Don't assume arg counts fit in 'int'.
8867 * callint.c (Fcall_interactively): Check arg count for overflow,
8868 to avoid potential buffer overrun. Use signed char, not 'int',
8869 for 'varies' array, so that we needn't bother to check its size
8870 calculation for overflow.
8871 * editfns.c (Fformat): Use ptrdiff_t, not EMACS_INT, to count args.
8872 * eval.c (apply_lambda):
8873 * fns.c (Fmapconcat): Use XFASTINT, not XINT, to get args length.
8874 (struct textprop_rec.argnum): Now ptrdiff_t, not int. All uses changed.
8875 (mapconcat): Use ptrdiff_t, not int and EMACS_INT, to count args.
8876
a1759b76
PE
8877 * callint.c (Fcall_interactively): Don't use index var as event count.
8878
d96be9fc
PE
8879 * vm-limit.c (check_memory_limits): Fix incorrect extern function decls.
8880 * mem-limits.h (SIZE): Remove; no longer used.
8881
a690a978 8882 * xterm.c (x_alloc_nearest_color_1): Prefer int to long when int works.
5efd304b 8883
578c21e6
PE
8884 Remove unnecessary casts.
8885 * xterm.c (x_term_init):
8886 * xfns.c (x_set_border_pixel):
8887 * widget.c (create_frame_gcs): Remove casts to unsigned long etc.
8888 These aren't needed now that we assume ANSI C.
8889
96f53c6c
PE
8890 * sound.c (Fplay_sound_internal): Remove cast to unsigned long.
8891 It's more likely to cause problems (due to unsigned overflow)
8892 than to cure them.
8893
83c77d31
PE
8894 * dired.c (Ffile_attributes): Don't use 32-bit hack on 64-bit hosts.
8895
ee2079f1
PE
8896 * unexelf.c (unexec): Don't assume BSS addr fits in unsigned.
8897
6da65536
PE
8898 * xterm.c (handle_one_xevent): Omit unnecessary casts to unsigned.
8899
7147c4a4
PE
8900 * keyboard.c (modify_event_symbol): Don't limit alist len to UINT_MAX.
8901
193e32d9
PE
8902 * lisp.h (CHAR_TABLE_SET): Omit now-redundant test.
8903
e5533da6
PE
8904 * lread.c (Fload): Don't compare a possibly-garbage time_t value.
8905
9910e595
PE
8906 GLYPH_CODE_FACE returns EMACS_INT, not int.
8907 * dispextern.h (merge_faces):
8908 * xfaces.c (merge_faces):
01103c44
PE
8909 * xdisp.c (get_next_display_element, next_element_from_display_vector):
8910 Don't assume EMACS_INT fits in int.
9910e595 8911
2638320e
PE
8912 * character.h (CHAR_VALID_P): Remove unused parameter.
8913 * fontset.c, lisp.h, xdisp.c: All uses changed.
8914
045eb8d9
PE
8915 * editfns.c (Ftranslate_region_internal): Omit redundant test.
8916
c1f134b5
PE
8917 * fns.c (concat): Minor tuning based on overflow analysis.
8918 This doesn't fix any bugs. Use int to hold character, instead
8919 of constantly refetching from Emacs object. Use XFASTINT, not
8920 XINT, for value known to be a character. Don't bother comparing
8921 a single byte to 0400, as it's always less.
8922
395fcb93 8923 * floatfns.c (Fexpt):
327eeec8
PE
8924 * fileio.c (make_temp_name): Omit unnecessary cast to unsigned.
8925
abbd3d23
PE
8926 * editfns.c (Ftranslate_region_internal): Use int, not EMACS_INT
8927 for characters.
8928
684a03ef
PE
8929 * doc.c (get_doc_string): Omit (unsigned)c that mishandled negatives.
8930
0fed43f3
PE
8931 * data.c (Faset): If ARRAY is a string, check that NEWELT is a char.
8932 Without this fix, on a 64-bit host (aset S 0 4294967386) would
8933 incorrectly succeed when S was a string, because 4294967386 was
8934 truncated before it was used.
8935
8fd02eb7
PE
8936 * chartab.c (Fchar_table_range): Use CHARACTERP to check range.
8937 Otherwise, an out-of-range integer could cause undefined behavior
8938 on a 64-bit host.
8939
f8c86b69
PE
8940 * composite.c: Use int, not EMACS_INT, for characters.
8941 (fill_gstring_body, composition_compute_stop_pos): Use int, not
8942 EMACS_INT, for values that are known to be in character range.
8943 This doesn't fix any bugs but is the usual style inside Emacs and
8944 may generate better code on 32-bit machines.
8945
34206dd2
PE
8946 Make sure a 64-bit char is never passed to ENCODE_CHAR.
8947 This is for reasons similar to the recent CHAR_STRING fix.
8948 * charset.c (Fencode_char): Check that character arg is actually
8949 a character. Pass an int to ENCODE_CHAR.
8950 * charset.h (ENCODE_CHAR): Verify that the character argument is no
8951 wider than 'int', as a compile-time check to prevent future regressions
8952 in this area.
8953
c5958d4c 8954 * character.c (char_string): Remove unnecessary casts.
13bdea59
PE
8955
8956 Make sure a 64-bit char is never passed to CHAR_STRING.
8957 Otherwise, CHAR_STRING would do the wrong thing on a 64-bit platform,
8958 by silently ignoring the top 32 bits, allowing some values
8959 that were far too large to be valid characters.
8960 * character.h: Include <verify.h>.
8961 (CHAR_STRING, CHAR_STRING_ADVANCE): Verify that the character
8962 arguments are no wider than unsigned, as a compile-time check
8963 to prevent future regressions in this area.
8964 * data.c (Faset):
01103c44 8965 * editfns.c (Fchar_to_string, general_insert_function, Finsert_char)
13bdea59
PE
8966 (Fsubst_char_in_region):
8967 * fns.c (concat):
8968 * xdisp.c (decode_mode_spec_coding):
8969 Adjust to CHAR_STRING's new requirement.
8970 * editfns.c (Finsert_char, Fsubst_char_in_region):
8971 * fns.c (concat): Check that character args are actually
8972 characters. Without this test, these functions did the wrong
8973 thing with wildly out-of-range values on 64-bit hosts.
8974
d37ca623
PE
8975 Remove incorrect casts to 'unsigned' that lose info on 64-bit hosts.
8976 These casts should not be needed on 32-bit hosts, either.
8977 * keyboard.c (read_char):
8978 * lread.c (Fload): Remove casts to unsigned.
8979
ea204efb
PE
8980 * lisp.h (UNSIGNED_CMP): New macro.
8981 This fixes comparison bugs on 64-bit hosts.
8982 (ASCII_CHAR_P): Use it.
8983 * casefiddle.c (casify_object):
01103c44 8984 * character.h (ASCII_BYTE_P, CHAR_VALID_P)
ea204efb
PE
8985 (SINGLE_BYTE_CHAR_P, CHAR_STRING):
8986 * composite.h (COMPOSITION_ENCODE_RULE_VALID):
8987 * dispextern.h (FACE_FROM_ID):
8988 * keyboard.c (read_char): Use UNSIGNED_CMP.
8989
41cb286c
PE
8990 * xmenu.c (dialog_selection_callback) [!USE_GTK]: Cast to intptr_t,
8991 not to EMACS_INT, to avoid GCC warning.
8992
4a1b9832
PE
8993 * xfns.c (x_set_scroll_bar_default_width): Remove unused 'int' locals.
8994
55daad71
PE
8995 * buffer.h (PTR_BYTE_POS, BUF_PTR_BYTE_POS): Remove harmful cast.
8996 The cast incorrectly truncated 64-bit byte offsets to 32 bits, and
8997 isn't needed on 32-bit machines.
8f95c75c 8998
01103c44
PE
8999 * buffer.c (Fgenerate_new_buffer_name):
9000 Use EMACS_INT for count, not int.
0ceccced 9001 (advance_to_char_boundary): Return EMACS_INT, not int.
e762cafe
PE
9002
9003 * data.c (Qcompiled_function): Now static.
9004
c6f072e7
PE
9005 * window.c (window_body_lines): Now static.
9006
20ce5912
PE
9007 * image.c (gif_load): Rename local to avoid shadowing.
9008
9c4c5f81
PE
9009 * lisp.h (SAFE_ALLOCA_LISP): Check for integer overflow.
9010 (struct Lisp_Save_Value): Use ptrdiff_t, not int, for 'integer' member.
9011 * alloc.c (make_save_value): Integer argument is now of type
9012 ptrdiff_t, not int.
9013 (mark_object): Use ptrdiff_t, not int.
9014 * lisp.h (pD): New macro.
9015 * print.c (print_object): Use it.
9016
c0c5c8ae
PE
9017 * alloc.c: Use EMACS_INT, not int, to count objects.
9018 (total_conses, total_markers, total_symbols, total_vector_size)
9019 (total_free_conses, total_free_markers, total_free_symbols)
01103c44
PE
9020 (total_free_floats, total_floats, total_free_intervals)
9021 (total_intervals, total_strings, total_free_strings):
c0c5c8ae
PE
9022 Now EMACS_INT, not int. All uses changed.
9023 (Fgarbage_collect): Compute overall total using a double, so that
9024 integer overflow is less likely to be a problem. Check for overflow
9025 when converting back to an integer.
5a25e253
PE
9026 (n_interval_blocks, n_string_blocks, n_float_blocks, n_cons_blocks)
9027 (n_vectors, n_symbol_blocks, n_marker_blocks): Remove.
9028 These were 'int' variables that could overflow on 64-bit hosts;
9029 they were never used, so remove them instead of repairing them.
211a0b2a 9030 (nzombies, ngcs, max_live, max_zombies): Now EMACS_INT, not 'int'.
6349ae4d
PE
9031 (inhibit_garbage_collection): Set gc_cons_threshold to max value.
9032 Previously, this ceilinged at INT_MAX, but that doesn't work on
9033 64-bit machines.
e46bb31a 9034 (allocate_pseudovector): Don't use EMACS_INT when int would do.
c0c5c8ae 9035
c78baabf 9036 * alloc.c (Fmake_bool_vector): Don't assume vector size fits in int.
86f61a15 9037 (allocate_vectorlike): Check for ptrdiff_t overflow.
b6439961
PE
9038 (mark_vectorlike, mark_char_table, mark_object): Avoid EMACS_UINT
9039 when a (possibly-narrower) signed value would do just as well.
9040 We prefer using signed arithmetic, to avoid comparison confusion.
c78baabf 9041
c9d624c6
PE
9042 * alloc.c: Catch some string size overflows that we were missing.
9043 (XMALLOC_OVERRUN_CHECK_SIZE) [!XMALLOC_OVERRUN_CHECK]: Define to 0,
9044 for convenience in STRING_BYTES_MAX.
9045 (STRING_BYTES_MAX): New macro, superseding the old one in lisp.h.
9046 The definition here is exact; the one in lisp.h was approximate.
9047 (allocate_string_data): Check for string overflow. This catches
9048 some instances we weren't catching before. Also, it catches
9049 size_t overflow on (unusual) hosts where SIZE_MAX <= min
9050 (PTRDIFF_MAX, MOST_POSITIVE_FIXNUM), e.g., when size_t is 32 bits
9051 and ptrdiff_t and EMACS_INT are both 64 bits.
c78baabf 9052
c9d624c6
PE
9053 * character.c, coding.c, doprnt.c, editfns.c, eval.c:
9054 All uses of STRING_BYTES_MAX replaced by STRING_BYTES_BOUND.
640c8776 9055 * lisp.h (STRING_BYTES_BOUND): Rename from STRING_BYTES_MAX.
c9d624c6 9056
353032ce
PE
9057 * character.c (string_escape_byte8): Fix nbytes/nchars typo.
9058
2bccce07
PE
9059 * alloc.c (Fmake_string): Check for out-of-range init.
9060
0ac30604
SM
90612011-06-15 Stefan Monnier <monnier@iro.umontreal.ca>
9062
9063 * eval.c (Fdefvaralias): Also mark the target as variable-special-p.
9064
c195f2de
JD
90652011-06-14 Jan Djärv <jan.h.d@swipnet.se>
9066
9067 * xfns.c (x_set_scroll_bar_default_width): Remove argument to
9068 xg_get_default_scrollbar_width.
9069
9070 * gtkutil.c: Include emacsgtkfixed.h if HAVE_GTK3.
9071 (int_gtk_range_get_value): Move to the scroll bar part of the file.
9072 (style_changed_cb): Call update_theme_scrollbar_width and call
9073 x_set_scroll_bar_default_width and xg_frame_set_char_size for
9074 all frames (Bug#8505).
9075 (xg_create_frame_widgets): Call emacs_fixed_new if HAVE_GTK3 (Bug#8505).
9076 Call gtk_window_set_resizable if HAVE_GTK3.
9077 (x_wm_set_size_hint): Call emacs_fixed_set_min_size with min width
9078 and height if HAVE_GTK3 (Bug#8505).
9079 (scroll_bar_width_for_theme): New variable.
9080 (update_theme_scrollbar_width): New function.
9081 (xg_get_default_scrollbar_width): Move code to
9082 update_theme_scrollbar_width, just return scroll_bar_width_for_theme.
9083 (xg_initialize): Call update_theme_scrollbar_width.
9084
9085 * gtkutil.h (xg_get_default_scrollbar_width): Remove argument.
9086
9087 * emacsgtkfixed.c, emacsgtkfixed.h: New files.
9088
e10ac9f1
MR
90892011-06-12 Martin Rudalics <rudalics@gmx.at>
9090
9091 * frame.c (make_frame): Call other_buffer_safely instead of
9092 other_buffer.
9093
9094 * window.c (temp_output_buffer_show): Call display_buffer with
9095 second argument Vtemp_buffer_show_specifiers and reset latter
9096 immediately after the call.
9097 (Vtemp_buffer_show_specifiers): New variable.
9098 (auto_window_vscroll_p, next_screen_context_lines)
9099 (Vscroll_preserve_screen_position): Remove leading asterisks from
9100 doc-strings.
9101
2d3c217e 91022011-06-12 Paul Eggert <eggert@cs.ucla.edu>
4475bec4 9103
7b7f97e8 9104 Fix minor problems found by GCC 4.6.0 static checking.
4475bec4
PE
9105 * buffer.c (Qclone_number): Remove for now, as it's unused.
9106 (record_buffer, Funrecord_buffer): Rename local to avoid shadowing.
9107 (record_buffer): Remove unused local.
9108 * frame.c (other_visible_frames, frame_buffer_list): Now static.
9109 (set_frame_buffer_list): Remove; unused.
9110 * frame.h (other_visible_frames): Remove decl.
9111 * keyboard.h (menu_items_inuse): Declare only if USE_GTK || USE_MOTIF.
9112 * lisp.h (frame_buffer_list, set_frame_buffer_list): Remove decls.
9113 (add_gpm_wait_descriptor, delete_gpm_wait_descriptor): Declare only
9114 if HAVE_GPM.
9115 * menu.c (menu_items_inuse): Now static unless USE_GTK || USE_MOTIF.
9116 * process.c (add_gpm_wait_descriptor, delete_gpm_wait_descriptor):
9117 Define only if HAVE_GPM.
9118 * widget.c (EmacsFrameResize, emacsFrameClassRec): Now static.
9119 (update_hints_inhibit): Remove; never set. All uses removed.
9120 * widgetprv.h (emacsFrameClassRec): Remove decl.
9121 * window.c (delete_deletable_window): Now returns void, since it
9122 wasn't returning anything.
9123 (compare_window_configurations): Remove unused locals.
9124 * xfns.c (x_set_scroll_bar_default_width): Remove unused locals.
9125 * xmenu.c (x_menu_set_in_use): Define only if USE_GTK || USE_MOTIF.
4475bec4
PE
9126 (dialog_selection_callback) [!USE_GTK]: Prefer intptr_t for integers
9127 the same widths as pointers. This follows up on the 2011-05-06 patch.
9128 * xterm.c (x_alloc_lighter_color_for_widget): Define only if USE_LUCID.
9129 * xterm.h: Likewise.
9130 (x_menu_set_in_use): Declare only if USE_GTK || USE_MOTIF.
9131
1384b89e
JB
91322011-06-12 Juanma Barranquero <lekktu@gmail.com>
9133
9134 * makefile.w32-in: Update dependencies.
9135 (LISP_H): Add lib/intprops.h.
9136
1100a63c
CY
91372011-06-11 Chong Yidong <cyd@stupidchicken.com>
9138
9139 * image.c (gif_load): Add animation frame delay to the metadata.
9140 (syms_of_image): Use DEFSYM. New symbol `delay'.
9141
6198ccd0
MR
91422011-06-11 Martin Rudalics <rudalics@gmx.at>
9143
9144 * window.c (delete_deletable_window): Re-add.
9145 (Fset_window_configuration): Rewrite to handle dead buffers and
9146 consequently deletable windows.
9147 (window_tree, Fwindow_tree): Remove. Supply functionality in
9148 window.el.
9149 (compare_window_configurations): Simplify code.
9150
b6e3633c
AS
91512011-06-11 Andreas Schwab <schwab@linux-m68k.org>
9152
1ab0dee5
AS
9153 * image.c (imagemagick_load_image): Fix type mismatch.
9154 (Fimagemagick_types): Likewise.
9155
b6e3633c
AS
9156 * window.h (replace_buffer_in_windows): Declare.
9157
9397e56f
MR
91582011-06-11 Martin Rudalics <rudalics@gmx.at>
9159
9160 * buffer.c: New Lisp objects Qbuffer_list_update_hook and
9161 Qclone_number. Remove external declaration of Qdelete_window.
9162 (Fbuffer_list): Rewrite doc-string. Minor restructuring of
9163 code.
640c8776
SM
9164 (Fget_buffer_create, Fmake_indirect_buffer, Frename_buffer):
9165 Run Qbuffer_list_update_hook if allowed.
9397e56f
MR
9166 (Fother_buffer): Rewrite doc-string. Major rewrite for new
9167 buffer list implementation.
9168 (other_buffer_safely): New function.
9169 (Fkill_buffer): Replace call to replace_buffer_in_all_windows by
9170 calls to replace_buffer_in_windows and
9171 replace_buffer_in_windows_safely. Run Qbuffer_list_update_hook
9172 if allowed.
9173 (record_buffer): Inhibit quitting and rewrite using quittable
9174 functions. Run Qbuffer_list_update_hook if allowed.
9175 (Frecord_buffer, Funrecord_buffer): New functions.
640c8776
SM
9176 (switch_to_buffer_1, Fswitch_to_buffer): Remove.
9177 Move switch-to-buffer to window.el.
9397e56f
MR
9178 (bury-buffer): Move to window.el.
9179 (Vbuffer_list_update_hook): New variable.
9180
9181 * lisp.h (other_buffer_safely): Add prototype in buffer.c
9182 section.
9183
9184 * window.h (resize_frame_windows): Move up in code.
9185 (Fwindow_frame): Remove EXFUN.
9186 (replace_buffer_in_all_windows): Remove prototype.
9187 (replace_buffer_in_windows_safely): Add prototype.
9188
9189 * window.c: Declare Qdelete_window static again. Move down
9190 declaration of select_count.
9191 (Fnext_window, Fprevious_window): Rewrite doc-strings.
9192 (Fother_window): Move to window.el.
9193 (window_loop): Remove DELETE_BUFFER_WINDOWS and UNSHOW_BUFFER
9194 cases. Add REPLACE_BUFFER_IN_WINDOWS_SAFELY case.
9195 (Fdelete_windows_on, Freplace_buffer_in_windows): Move to
9196 window.el.
9197 (replace_buffer_in_windows): Implement by calling
9198 Qreplace_buffer_in_windows.
9199 (replace_buffer_in_all_windows): Remove with some functionality
9200 moved into replace_buffer_in_windows_safely.
9201 (replace_buffer_in_windows_safely): New function.
9202 (select_window_norecord, select_frame_norecord): Move in front
9203 of run_window_configuration_change_hook. Remove now obsolete
9204 declarations.
640c8776
SM
9205 (Fset_window_buffer): Rewrite doc-string.
9206 Call Qrecord_window_buffer.
9397e56f
MR
9207 (keys_of_window): Move binding for other-window to window.el.
9208
b50691aa
CY
92092011-06-11 Chong Yidong <cyd@stupidchicken.com>
9210
9211 * dispextern.h (struct image): Replace data member, whose int_val
9212 and ptr_val fields were not used by anything, with a single
9213 lisp_val object.
9214
9215 * image.c (Fimage_metadata, make_image, mark_image, tiff_load)
9216 (gif_clear_image, gif_load, imagemagick_load_image)
9217 (gs_clear_image, gs_load): Callers changed.
9218
3f754b86
PE
92192011-06-10 Paul Eggert <eggert@cs.ucla.edu>
9220
cca69397
PE
9221 * buffer.h: Include <time.h>, for time_t.
9222 Needed to build on FreeBSD 8.2. Problem reported by Herbert J. Skuhra.
9223
109e28d0
PE
9224 Fix minor problems found by static checking.
9225
60737f02
PE
9226 * image.c (PixelGetMagickColor): Declare if ImageMagick headers don't.
9227
4b66faf3
PE
9228 Make identifiers static if they are not used in other modules.
9229 * data.c (Qcompiled_function, Qframe, Qvector):
9230 * image.c (QimageMagick, Qsvg):
9231 * minibuf.c (Qmetadata):
9232 * window.c (resize_window_check, resize_root_window): Now static.
9233 * window.h (resize_window_check, resize_root_window): Remove decls.
9234
109e28d0
PE
9235 * window.c (window_deletion_count, delete_deletable_window):
9236 Remove; unused.
46a4ce9e
PE
9237 (window_body_lines): Now static.
9238 (Fdelete_other_windows_internal): Mark vars as initialized.
9239 Make sure 'resize_failed' is initialized.
9240 (run_window_configuration_change_hook): Rename local to avoid shadowing.
9241 (resize_window_apply): Remove unused local.
9242 * window.h (delete_deletable_window): Remove decl.
9243
109e28d0 9244 * image.c (gif_load, svg_load_image): Rename locals to avoid shadowing.
33290528
PE
9245 (imagemagick_load_image): Fix pointer signedness problem by changing
9246 last arg from unsigned char * to char *. All uses changed.
9247 Also, fix a local for similar reasons.
9248 Remove unused locals. Remove locals to avoid shadowing.
9249 (fn_rsvg_handle_free): Remove; unused.
9250 (svg_load, svg_load_image): Fix pointer signedness problem.
f7e13da3 9251 (imagemagick_load_image): Don't use garbage pointer image_wand.
33290528 9252
3f754b86
PE
9253 * ftfont.c (ftfont_get_metrics, ftfont_drive_otf): Remove unused locals.
9254
2547adb1
CY
92552011-06-10 Chong Yidong <cyd@stupidchicken.com>
9256
9257 * image.c (gif_load): Fix omitted cast error introduced by
9258 2011-06-06 change.
9259
2c8e37d4
MR
92602011-06-10 Martin Rudalics <rudalics@gmx.at>
9261
9262 * window.h (resize_proportionally, orig_total_lines)
9263 (orig_top_line): Remove from window structure.
9264 (set_window_height, set_window_width, change_window_heights)
9265 (Fdelete_window): Remove prototypes.
9266 (resize_frame_windows): Remove duplicate declaration.
9267
440a42e3
EZ
92682011-06-10 Eli Zaretskii <eliz@gnu.org>
9269
9270 * window.h (resize_frame_windows, resize_window_check)
9271 (delete_deletable_window, resize_root_window)
9272 (resize_frame_windows): Declare prototypes.
9273
9274 * window.c (resize_window_apply): Make definition be "static" to
9275 match the prototype.
9276
562dd5e9
MR
92772011-06-10 Martin Rudalics <rudalics@gmx.at>
9278
9279 * window.c: Remove declarations of Qwindow_size_fixed,
9280 window_min_size_1, window_min_size_2, window_min_size,
9281 size_window, window_fixed_size_p, enlarge_window, delete_window.
9282 Remove static from declaration of Qdelete_window, it's
9283 temporarily needed by Fbury_buffer.
9284 (replace_window): Don't assign orig_top_line and
9285 orig_total_lines.
9286 (Fdelete_window, delete_window): Remove. Window deletion is
9287 handled by window.el.
640c8776
SM
9288 (window_loop): Remove DELETE_OTHER_WINDOWS case.
9289 Replace Fdelete_window calls with calls to Qdelete_window.
562dd5e9
MR
9290 (Fdelete_other_windows): Remove. Deleting other windows is
9291 handled by window.el.
9292 (window_fixed_size_p): Remove. Fixed-sizeness of windows is
9293 handled in window.el.
9294 (window_min_size_2, window_min_size_1, window_min_size): Remove.
9295 Window minimum sizes are handled in window.el.
9296 (shrink_windows, size_window, set_window_height)
9297 (set_window_width, change_window_heights, window_height)
9298 (window_width, CURBEG, CURSIZE, enlarge_window)
9299 (adjust_window_trailing_edge, Fadjust_window_trailing_edge)
9300 (Fenlarge_window, Fshrink_window): Remove. Window resizing is
9301 handled in window.el.
9302 (make_dummy_parent): Rename to make_parent_window and give it a
9303 second argument horflag.
9304 (make_window): Don't set resize_proportionally any more.
9305 (Fsplit_window): Remove. Windows are split in window.el.
9306 (save_restore_action, save_restore_orig_size)
9307 (shrink_window_lowest_first, save_restore_orig_size): Remove.
9308 Resize mini windows in window.el.
9309 (grow_mini_window, shrink_mini_window): Implement by calling
9310 Qresize_root_window_vertically, resize_window_check and
9311 resize_window_apply.
640c8776
SM
9312 (saved_window, Fset_window_configuration, save_window_save):
9313 Do not handle orig_top_line, orig_total_lines, and
562dd5e9
MR
9314 resize_proportionally.
9315 (window_min_height, window_min_width): Move to window.el.
9316 (keys_of_window): Move bindings for delete-other-windows,
9317 split-window, delete-window and enlarge-window to window.el.
9318
9319 * buffer.c: Temporarily extern Qdelete_window.
9320 (Fbury_buffer): Temporarily call Qdelete_window instead of
9321 Fdelete_window (Fbury_buffer will move to window.el soon).
9322
9323 * frame.c (set_menu_bar_lines_1): Remove code handling
9324 orig_top_line and orig_total_lines.
9325
9326 * dispnew.c (adjust_frame_glyphs_initially): Don't use
9327 set_window_height but set heights directly.
9328 (change_frame_size_1): Use resize_frame_windows.
9329
9330 * xdisp.c (init_xdisp): Don't use set_window_height but set
9331 heights directly.
9332
640c8776
SM
9333 * xfns.c (x_set_menu_bar_lines, x_set_tool_bar_lines):
9334 Use resize_frame_windows instead of change_window_heights and run
562dd5e9
MR
9335 run_window_configuration_change_hook.
9336
9337 * w32fns.c (x_set_tool_bar_lines): Use resize_frame_windows
9338 instead of change_window_heights and run
9339 run_window_configuration_change_hook.
9340
1a13852e
MR
93412011-06-09 Martin Rudalics <rudalics@gmx.at>
9342
9343 * window.c (replace_window): Rename second argument REPLACEMENT to
9344 NEW. New third argument SETFLAG. Rewrite.
9345 (delete_window, make_dummy_parent): Call replace_window with
9346 third argument 1.
9347 (window_list_1): Move down in code.
9348 (run_window_configuration_change_hook): Move set_buffer part
9349 before select_frame_norecord part in order to unwind correctly.
9350 Rename count1 to count.
9351 (recombine_windows, delete_deletable_window, resize_root_window)
9352 (Fdelete_other_windows_internal)
9353 (Frun_window_configuration_change_hook, make_parent_window)
9354 (resize_window_check, resize_window_apply, Fresize_window_apply)
9355 (resize_frame_windows, Fsplit_window_internal)
640c8776
SM
9356 (Fdelete_window_internal, Fresize_mini_window_internal):
9357 New functions.
1a13852e
MR
9358 (syms_of_window): New variables Vwindow_splits and Vwindow_nest.
9359
f3d1777e
MR
93602011-06-08 Martin Rudalics <rudalics@gmx.at>
9361
496e208e
MR
9362 * window.h (window): Add some new members to window structure -
9363 normal_lines, normal_cols, new_total, new_normal, clone_number,
9364 splits, nest, prev_buffers, next_buffers.
9365 (WINDOW_TOTAL_SIZE): Move here from window.c.
b9e809c2 9366 (MIN_SAFE_WINDOW_WIDTH, MIN_SAFE_WINDOW_HEIGHT): Define here.
496e208e 9367
f3d1777e
MR
9368 * window.c (Fwindow_height, Fwindow_width, Fwindow_full_width_p):
9369 Remove.
496e208e
MR
9370 (make_dummy_parent): Set new members of windows structure.
9371 (make_window): Move down in code. Handle new members of window
9372 structure.
9373 (Fwindow_clone_number, Fwindow_splits, Fset_window_splits)
9374 (Fwindow_nest, Fset_window_nest, Fwindow_new_total)
9375 (Fwindow_normal_size, Fwindow_new_normal, Fwindow_prev_buffers)
9376 (Fset_window_prev_buffers, Fwindow_next_buffers)
640c8776
SM
9377 (Fset_window_next_buffers, Fset_window_clone_number):
9378 New functions.
496e208e
MR
9379 (Fwindow_hscroll, Fwindow_at, Fwindow_point, Fwindow_start)
9380 (Fwindow_end, Fwindow_line_height, Fset_window_dedicated_p):
9381 Doc-string fixes.
9382 (Fwindow_parameters, Fwindow_parameter, Fset_window_parameter):
9383 Argument WINDOW can be now internal window too.
9384 (Fwindow_use_time): Move up in code.
9385 (Fget_buffer_window): Rename argument FRAME to ALL-FRAMES.
9386 Rewrite doc-string.
9387 (Fset_window_configuration, saved_window)
9388 (Fcurrent_window_configuration, save_window_save): Handle new
9389 members of window structure.
b9e809c2
MR
9390 (WINDOW_TOTAL_SIZE, MIN_SAFE_WINDOW_WIDTH)
9391 (MIN_SAFE_WINDOW_HEIGHT): Move to window.h.
9392 (syms_of_window): New Lisp objects Qrecord_window_buffer,
9393 Qwindow_deletable_p, Qdelete_window, Qreplace_buffer_in_windows,
9394 Qget_mru_window, Qresize_root_window,
9395 Qresize_root_window_vertically, Qsafe, Qabove, Qbelow,
9396 Qauto_buffer_name; staticpro them.
f3d1777e 9397
abde8f8c
MR
93982011-06-07 Martin Rudalics <rudalics@gmx.at>
9399
9400 * window.c (Fwindow_total_size, Fwindow_left_column)
9401 (Fwindow_top_line, window_body_lines, Fwindow_body_size)
9402 (Fwindow_list_1): New functions.
9403 (window_box_text_cols): Replace with window_body_cols.
640c8776
SM
9404 (Fwindow_width, Fscroll_left, Fscroll_right):
9405 Use window_body_cols instead of window_box_text_cols.
9406 (delete_window, Fset_window_configuration):
9407 Call delete_all_subwindows with window as argument.
fa8a67e6
MR
9408 (delete_all_subwindows): Take a window as argument and not a
9409 structure. Rewrite.
190b47e6
MR
9410 (window_loop): Remove handling of GET_LRU_WINDOW and
9411 GET_LARGEST_WINDOW.
9412 (Fget_lru_window, Fget_largest_window): Move to window.el.
abde8f8c
MR
9413
9414 * window.h: Extern window_body_cols instead of
fa8a67e6
MR
9415 window_box_text_cols. delete_all_subwindows now takes a
9416 Lisp_Object as argument.
abde8f8c 9417
640c8776
SM
9418 * indent.c (compute_motion, Fcompute_motion):
9419 Use window_body_cols instead of window_box_text_cols.
abde8f8c 9420
fa8a67e6
MR
9421 * frame.c (delete_frame): Call delete_all_subwindows with root
9422 window as argument.
9423
a54e3482
DC
94242011-06-07 Daniel Colascione <dan.colascione@gmail.com>
9425
9426 * fns.c (Fputhash): Document return value.
9427
60002bf5
CY
94282011-06-06 Chong Yidong <cyd@stupidchicken.com>
9429
9430 * image.c (gif_load): Implement gif89a spec "no disposal" method.
9431
0c671da6 94322011-06-06 Paul Eggert <eggert@cs.ucla.edu>
ccd9a01a 9433
b862a52a 9434 Cons<->int and similar integer overflow fixes (Bug#8794).
77984278 9435
be44ca6c
PE
9436 Check for overflow when converting integer to cons and back.
9437 * charset.c (Fdefine_charset_internal, Fdecode_char):
9438 Use cons_to_unsigned to catch overflow.
9439 (Fencode_char): Use INTEGER_TO_CONS.
9440 * composite.h (LGLYPH_CODE): Use cons_to_unsigned.
9441 (LGLYPH_SET_CODE): Use INTEGER_TO_CONS.
9442 * data.c (long_to_cons, cons_to_long): Remove.
9443 (cons_to_unsigned, cons_to_signed): New functions.
9444 These signal an error for invalid or out-of-range values.
9445 * dired.c (Ffile_attributes): Use INTEGER_TO_CONS.
9446 * fileio.c (Fset_visited_file_modtime): Use CONS_TO_INTEGER.
9447 * font.c (Ffont_variation_glyphs):
9448 * fontset.c (Finternal_char_font): Use INTEGER_TO_CONS.
9449 * lisp.h: Include <intprops.h>.
9450 (INTEGER_TO_CONS, CONS_TO_INTEGER): New macros.
9451 (cons_to_signed, cons_to_unsigned): New decls.
9452 (long_to_cons, cons_to_long): Remove decls.
9453 * undo.c (record_first_change): Use INTEGER_TO_CONS.
9454 (Fprimitive_undo): Use CONS_TO_INTEGER.
9455 * xfns.c (Fx_window_property): Likewise.
9456 * xselect.c: Include <limits.h>.
9457 (x_own_selection, selection_data_to_lisp_data):
9458 Use INTEGER_TO_CONS.
9459 (x_handle_selection_request, x_handle_selection_clear)
9460 (x_get_foreign_selection, Fx_disown_selection_internal)
9461 (Fx_get_atom_name, x_send_client_event): Use CONS_TO_INTEGER.
9462 (lisp_data_to_selection_data): Use cons_to_unsigned.
9463 (x_fill_property_data): Use cons_to_signed.
9464 Report values out of range.
9465
d1f3d2af
PE
9466 Check for buffer and string overflow more precisely.
9467 * buffer.h (BUF_BYTES_MAX): New macro.
9468 * lisp.h (STRING_BYTES_MAX): New macro.
9469 * alloc.c (Fmake_string):
9470 * character.c (string_escape_byte8):
9471 * coding.c (coding_alloc_by_realloc):
9472 * doprnt.c (doprnt):
9473 * editfns.c (Fformat):
9474 * eval.c (verror):
9475 Use STRING_BYTES_MAX, not MOST_POSITIVE_FIXNUM,
9476 since they may not be the same number.
9477 * editfns.c (Finsert_char):
9478 * fileio.c (Finsert_file_contents):
9479 Likewise for BUF_BYTES_MAX.
9480
dd52fcea
PE
9481 * image.c: Use ptrdiff_t, not int, for sizes.
9482 (slurp_file): Switch from int to ptrdiff_t.
9483 All uses changed.
9484 (slurp_file): Check that file size fits in both size_t (for
9485 malloc) and ptrdiff_t (for sanity and safety).
9486
7f9bbdbb
PE
9487 * fileio.c (Fverify_visited_file_modtime): Avoid time overflow
9488 if b->modtime has its maximal value.
9489
dfe18f82
PE
9490 * dired.c (Ffile_attributes): Don't assume EMACS_INT has >32 bits.
9491
84acfcf0
PE
9492 Don't assume time_t can fit into int.
9493 * buffer.h (struct buffer.modtime): Now time_t, not int.
9494 * fileio.c (Fvisited_file_modtime): No need for time_t cast now.
9495 * undo.c (Fprimitive_undo): Use time_t, not int, for time_t value.
9496
ccd9a01a
PE
9497 Minor fixes for signed vs unsigned integers.
9498 * character.h (MAYBE_UNIFY_CHAR):
9499 * charset.c (maybe_unify_char):
9500 * keyboard.c (read_char, reorder_modifiers):
9501 XINT -> XFASTINT, since the integer must be nonnegative.
9502 * ftfont.c (ftfont_spec_pattern):
9503 * keymap.c (access_keymap, silly_event_symbol_error):
9504 XUINT -> XFASTINT, since the integer must be nonnegative.
9505 (Fsingle_key_description, preferred_sequence_p): XUINT -> XINT,
9506 since it makes no difference and we prefer signed.
9507 * keyboard.c (record_char): Use XUINT when all the neighbors do.
9508 (access_keymap): NATNUMP -> INTEGERP, since the integer must be
9509 nonnegative.
9510
d6d100dd
SM
95112011-06-06 Stefan Monnier <monnier@iro.umontreal.ca>
9512
9513 * window.h (Fwindow_frame): Declare.
9514
2b6148e4
PE
95152011-06-06 Paul Eggert <eggert@cs.ucla.edu>
9516
9517 * alloc.c: Simplify handling of large-request failures (Bug#8800).
9518 (SPARE_MEMORY): Always define.
9519 (LARGE_REQUEST): Remove.
9520 (memory_full): Use SPARE_MEMORY rather than LARGE_REQUEST.
9521
f230ecc9
MR
95222011-06-06 Martin Rudalics <rudalics@gmx.at>
9523
727e958e
MR
9524 * lisp.h: Move EXFUNS for Fframe_root_window,
9525 Fframe_first_window and Fset_frame_selected_window to window.h.
9526
9527 * window.h: Move EXFUNS for Fframe_root_window,
9528 Fframe_first_window and Fset_frame_selected_window here from
9529 lisp.h.
9530
9531 * frame.c (Fwindow_frame, Fframe_first_window)
9532 (Fframe_root_window, Fframe_selected_window)
9533 (Fset_frame_selected_window): Move to window.c.
9534 (Factive_minibuffer_window): Move to minibuf.c.
9535 (Fother_visible_frames_p): New function.
9536
9537 * minibuf.c (Factive_minibuffer_window): Move here from frame.c.
9538
f230ecc9
MR
9539 * window.c (decode_window, decode_any_window): Move up in code.
9540 (Fwindowp, Fwindow_live_p): Rewrite doc-strings.
9541 (inhibit_frame_unsplittable): Remove unused variable.
bf60a96b
MR
9542 (Fwindow_buffer): Move up and rewrite doc-string.
9543 (Fwindow_parent, Fwindow_vchild, Fwindow_hchild, Fwindow_next)
9544 (Fwindow_prev): New functions.
727e958e
MR
9545 (Fwindow_frame): Move here from frame.c. Accept any window as
9546 argument.
9547 (Fframe_root_window, Fframe_first_window)
9548 (Fframe_selected_window): Move here from frame.c. Accept frame
9549 or arbitrary window as argument. Update doc-strings.
9550 (Fminibuffer_window): Move up in code.
9551 (Fwindow_minibuffer_p): Move up in code and simplify.
d6d100dd
SM
9552 (Fset_frame_selected_window): Move here from frame.c.
9553 Marginal rewrite.
727e958e
MR
9554 (Fselected_window, select_window, Fselect_window): Move up in
9555 code. Minor doc-string fixes.
f230ecc9 9556
4d09bcf6
PE
95572011-06-06 Paul Eggert <eggert@cs.ucla.edu>
9558
9559 * alloc.c (memory_full) [SYSTEM_MALLOC]: Port to MacOS (Bug#8800).
9560 Do not assume that spare memory exists; that assumption is valid
9561 only if SYSTEM_MALLOC.
9562 (LARGE_REQUEST): New macro, so that the issue of large requests
9563 is separated from the issue of spare memory.
9564
810928a2
AS
95652011-06-05 Andreas Schwab <schwab@linux-m68k.org>
9566
172418ad
AS
9567 * editfns.c (Fformat): Correctly handle zero flag with hexadecimal
9568 format. (Bug#8806)
9569
43f862f7
AS
9570 * gtkutil.c (xg_get_default_scrollbar_width): Avoid warning.
9571
810928a2
AS
9572 * xfns.c (x_set_scroll_bar_default_width): Move declarations
9573 before statements.
9574
a059fe24
JD
95752011-06-05 Jan Djärv <jan.h.d@swipnet.se>
9576
9577 * gtkutil.c (xg_get_default_scrollbar_width): New function.
9578
9579 * gtkutil.h: Declare xg_get_default_scrollbar_width.
9580
9581 * xfns.c (x_set_scroll_bar_default_width): If USE_GTK, get
9582 min width by calling x_set_scroll_bar_default_width (Bug#8505).
9583
989bf368
JB
95842011-06-05 Juanma Barranquero <lekktu@gmail.com>
9585
9586 * xdisp.c (single_display_spec_intangible_p): Remove declaration.
9587
4b80f674
CY
95882011-06-04 Chong Yidong <cyd@stupidchicken.com>
9589
9590 * xselect.c (x_clipboard_manager_save): Remove redundant arg.
9591 (x_clipboard_manager_save): Add return value.
d6d100dd
SM
9592 (x_clipboard_manager_error_1, x_clipboard_manager_error_2):
9593 New error handlers.
4b80f674
CY
9594 (x_clipboard_manager_save_frame, x_clipboard_manager_save_all):
9595 Obey Vx_select_enable_clipboard_manager. Catch errors in
9596 x_clipboard_manager_save (Bug#8779).
9597 (Vx_select_enable_clipboard_manager): New variable.
de65b42c 9598 (x_get_foreign_selection): Reduce scope of x_catch_errors (Bug#8790).
4b80f674 9599
99a33b77 96002011-06-04 Dan Nicolaescu <dann@ics.uci.edu>
8b3115e7
DN
9601
9602 * emacs.c (main): Warn when starting a GTK emacs in daemon mode.
9603
99a33b77 96042011-06-04 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
14eca62f
YM
9605
9606 * fringe.c (update_window_fringes): Don't update overlay arrow bitmap
9607 in the current matrix if keep_current_p is non-zero.
9608
8264569d
EZ
96092011-06-04 Eli Zaretskii <eliz@gnu.org>
9610
9611 * bidi.c (bidi_level_of_next_char): Fix last change.
9612
57f97249
EZ
96132011-06-03 Eli Zaretskii <eliz@gnu.org>
9614
fec2107c 9615 Support bidi reordering of text covered by display properties.
57f97249 9616
fec2107c
EZ
9617 * bidi.c (bidi_copy_it): Use offsetof instead of emulating it.
9618 (bidi_fetch_char, bidi_fetch_char_advance): New functions.
9619 (bidi_cache_search, bidi_cache_iterator_state)
9620 (bidi_paragraph_init, bidi_resolve_explicit, bidi_resolve_weak)
d6d100dd
SM
9621 (bidi_level_of_next_char, bidi_move_to_visually_next):
9622 Support character positions inside a run of characters covered by a
fec2107c
EZ
9623 display string.
9624 (bidi_paragraph_init, bidi_resolve_explicit_1)
9625 (bidi_level_of_next_char): Call bidi_fetch_char and
9626 bidi_fetch_char_advance instead of FETCH_CHAR and
9627 FETCH_CHAR_ADVANCE.
9628 (bidi_init_it): Initialize new members.
9629 (LRE_CHAR, RLE_CHAR, PDF_CHAR, LRO_CHAR, RLO_CHAR): Remove macro
9630 definitions.
9631 (bidi_explicit_dir_char): Lookup character type in bidi_type_table,
9632 instead of using explicit *_CHAR codes.
d6d100dd
SM
9633 (bidi_resolve_explicit, bidi_resolve_weak):
9634 Use FETCH_MULTIBYTE_CHAR instead of FETCH_CHAR, as reordering of
fec2107c
EZ
9635 bidirectional text is supported only in multibyte buffers.
9636 (bidi_init_it): Accept additional argument FRAME_WINDOW_P and use
9637 it to initialize the frame_window_p member of struct bidi_it.
9638 (bidi_cache_iterator_state, bidi_resolve_explicit_1)
9639 (bidi_resolve_explicit, bidi_resolve_weak)
9640 (bidi_level_of_next_char, bidi_move_to_visually_next): Abort if
9641 bidi_it->nchars is non-positive.
9642 (bidi_level_of_next_char): Don't try to lookup the cache for the
9643 next/previous character if nothing is cached there yet, or if we
9644 were just reseat()'ed to a new position.
c40e2fb2 9645
0e14fe90
EZ
9646 * xdisp.c (set_cursor_from_row): Set start and stop points
9647 according to the row's direction when priming the loop that looks
9648 for the glyph on which to display cursor.
9649 (single_display_spec_intangible_p): Function deleted.
9650 (display_prop_intangible_p): Reimplement to call
9651 handle_display_spec instead of single_display_spec_intangible_p.
d6d100dd
SM
9652 Accept 3 additional arguments needed by handle_display_spec.
9653 This fixes incorrect cursor motion across display property with complex
0e14fe90
EZ
9654 values: lists, `(when COND...)' forms, etc.
9655 (single_display_spec_string_p): Support property values that are
9656 lists with the argument STRING its top-level element.
9657 (display_prop_string_p): Fix the condition for processing a
9658 property that is a list to be consistent with handle_display_spec.
fec2107c 9659 (handle_display_spec): New function, refactored from the
fc6f18ce
EZ
9660 last portion of handle_display_prop.
9661 (compute_display_string_pos): Accept additional argument
9662 FRAME_WINDOW_P. Call handle_display_spec to determine whether the
9663 value of a `display' property is a "replacing spec".
9664 (handle_single_display_spec): Accept 2 additional arguments BUFPOS
9665 and FRAME_WINDOW_P. If IT is NULL, don't set up the iterator from
9666 the display property, but just return a value indicating whether
9667 the display property will replace the characters it covers.
9668 (Fcurrent_bidi_paragraph_direction): Initialize the nchars and
9669 frame_window_p members of struct bidi_it.
d6d100dd
SM
9670 (compute_display_string_pos, compute_display_string_end):
9671 New functions.
fec2107c
EZ
9672 (push_it): Accept second argument POSITION, where pop_it should
9673 jump to continue iteration.
9674 (reseat_1): Initialize bidi_it.disp_pos.
fc6f18ce 9675
fec2107c
EZ
9676 * keyboard.c (adjust_point_for_property): Adjust the call to
9677 display_prop_intangible_p to its new signature.
fc6f18ce
EZ
9678
9679 * dispextern.h (struct bidi_it): New member frame_window_p.
fec2107c
EZ
9680 (bidi_init_it): Update prototypes.
9681 (display_prop_intangible_p): Update prototype.
d6d100dd
SM
9682 (compute_display_string_pos, compute_display_string_end):
9683 Declare prototypes.
fec2107c
EZ
9684 (struct bidi_it): New members nchars and disp_pos. ch_len is now
9685 EMACS_INT.
fc6f18ce 9686
40087514 96872011-06-02 Paul Eggert <eggert@cs.ucla.edu>
0de4bb68 9688
57f53182
PE
9689 Malloc failure behavior now depends on size of allocation.
9690 * alloc.c (buffer_memory_full, memory_full): New arg NBYTES.
9691 * lisp.h: Change signatures accordingly.
9692 * alloc.c, buffer.c, editfns.c, menu.c, minibuf.c, xterm.c:
9693 All callers changed. (Bug#8762)
9694
9695 * gnutls.c: Use Emacs's memory allocators.
9696 Without this change, the gnutls library would invoke malloc etc.
9697 directly, which causes problems on non-SYNC_INPUT hosts, and which
9698 runs afoul of improving memory_full behavior. (Bug#8761)
9699 (fn_gnutls_global_set_mem_functions): New macro or function pointer.
9700 (emacs_gnutls_global_init): Use it to specify xmalloc, xrealloc,
9701 xfree instead of the default malloc, realloc, free.
9702 (Fgnutls_boot): No need to check for memory allocation failure,
9703 since xmalloc does that for us.
9704
ac32cd99 9705 Remove arbitrary limit of 2**31 entries in hash tables. (Bug#8771)
3870d916
PE
9706 * category.c (hash_get_category_set):
9707 * ccl.c (ccl_driver):
9708 * charset.c (Fdefine_charset_internal):
9709 * charset.h (struct charset.hash_index):
9710 * composite.c (get_composition_id, gstring_lookup_cache)
9711 (composition_gstring_put_cache):
9712 * composite.h (struct composition.hash_index):
9713 * dispextern.h (struct image.hash):
9714 * fns.c (next_almost_prime, larger_vector, cmpfn_eql)
9715 (cmpfn_equal, cmpfn_user_defined, hashfn_eq, hashfn_eql)
9716 (hashfn_equal, hashfn_user_defined, make_hash_table)
9717 (maybe_resize_hash_table, hash_lookup, hash_put)
9718 (hash_remove_from_table, hash_clear, sweep_weak_table, SXHASH_COMBINE)
9719 (sxhash_string, sxhash_list, sxhash_vector, sxhash_bool_vector)
9720 (Fsxhash, Fgethash, Fputhash, Fmaphash):
9721 * image.c (make_image, search_image_cache, lookup_image)
9722 (xpm_put_color_table_h):
9723 * lisp.h (struct Lisp_Hash_Table):
0de4bb68 9724 * minibuf.c (Ftry_completion, Fall_completions, Ftest_completion):
ac389d0c 9725 * print.c (print): Use 'EMACS_UINT' and 'EMACS_INT'
3870d916 9726 for hashes and hash indexes, instead of 'unsigned' and 'int'.
40087514
PE
9727 * alloc.c (allocate_vectorlike):
9728 Check for overflow in vector size calculations.
9729 * ccl.c (ccl_driver):
9730 Check for overflow when converting EMACS_INT to int.
0de4bb68
PE
9731 * fns.c, image.c: Remove unnecessary static decls that would otherwise
9732 need to be updated by these changes.
40087514
PE
9733 * fns.c (make_hash_table, maybe_resize_hash_table):
9734 Check for integer overflow with large hash tables.
0de4bb68
PE
9735 (make_hash_table, maybe_resize_hash_table, Fmake_hash_table):
9736 Prefer the faster XFLOAT_DATA to XFLOATINT where either will do.
9737 (SXHASH_REDUCE): New macro.
9738 (sxhash_string, sxhash_list, sxhash_vector, sxhash_bool_vector):
9739 Use it instead of discarding useful hash info with large hash values.
9740 (sxhash_float): New function.
9741 (sxhash): Use it. No more need for "& INTMASK" due to above changes.
9742 * lisp.h (FIXNUM_BITS): New macro, useful for SXHASH_REDUCE etc.
40087514
PE
9743 (MOST_NEGATIVE_FIXNUM, MOST_POSITIVE_FIXNUM, INTMASK):
9744 Rewrite to use FIXNUM_BITS, as this simplifies things.
0de4bb68
PE
9745 (next_almost_prime, larger_vector, sxhash, hash_lookup, hash_put):
9746 Adjust signatures to match updated version of code.
9747 (consing_since_gc): Now EMACS_INT, since a single hash table can
9748 use more than INT_MAX bytes.
9749
698d32e2
DN
97502011-06-01 Dan Nicolaescu <dann@ics.uci.edu>
9751
9752 Make it possible to build with GCC-4.6+ -O2 -flto.
9753
9754 * emacs.c (__malloc_initialize_hook): Mark as EXTERNALLY_VISIBLE.
9755
fd6fa53f
SM
97562011-06-01 Stefan Monnier <monnier@iro.umontreal.ca>
9757
9758 * minibuf.c (get_minibuffer, read_minibuf_unwind):
9759 Call minibuffer-inactive-mode.
9760
864db017
JB
97612011-05-31 Juanma Barranquero <lekktu@gmail.com>
9762
9763 * makefile.w32-in ($(BLD)/data.$(O), $(BLD)/editfns.$(O)):
9764 Update dependencies.
9765
2ad0baf4
DN
97662011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
9767
9768 * data.c (init_data): Remove code for UTS, this system is not
9769 supported anymore.
9770
4fcc2638
DN
97712011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
9772
9773 Don't force ./temacs to start in terminal mode.
9774
9775 * frame.c (make_initial_frame): Initialize faces in all cases, not
9776 only when CANNOT_DUMP is defined.
9777 * dispnew.c (init_display): Remove CANNOT_DUMP condition.
9778
c56e0fd5
DN
97792011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
9780
9781 * dispnew.c (add_window_display_history): Use const for the string
9782 pointer. Remove declaration, not needed.
9783
333d54da 97842011-05-31 Paul Eggert <eggert@cs.ucla.edu>
9cf9f756 9785
55d4c1b2 9786 Use 'inline', not 'INLINE'.
333d54da 9787 <http://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00914.html>
55d4c1b2
PE
9788 * alloc.c, fontset.c (INLINE): Remove.
9789 * alloc.c, bidi.c, charset.c, coding.c, dispnew.c, fns.c, image.c:
9790 * intervals.c, keyboard.c, process.c, syntax.c, textprop.c, w32term.c:
9791 * xdisp.c, xfaces.c, xterm.c: Replace all uses of INLINE with inline.
9792 * gmalloc.c (register_heapinfo): Use inline unconditionally.
9793 * lisp.h (LISP_MAKE_RVALUE): Use inline, not __inline__.
9794
738db178
DN
97952011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
9796
9797 Make it possible to run ./temacs.
9798
9799 * callproc.c (set_initial_environment): Remove CANNOT_DUMP code,
9800 syms_of_callproc does the same thing. Remove test for
9801 "initialized", do it in the caller.
9802 * emacs.c (main): Avoid calling set_initial_environment when dumping.
9803
620c53a6
SM
98042011-05-31 Stefan Monnier <monnier@iro.umontreal.ca>
9805
9806 * minibuf.c (Finternal_complete_buffer): Return `category' metadata.
9807 (read_minibuf): Use get_minibuffer.
9808 (syms_of_minibuf): Use DEFSYM.
9809 (Qmetadata): New var.
9810 * data.c (Qbuffer): Don't make it static.
9811 (syms_of_data): Use DEFSYM.
9812
e003a292
PE
98132011-05-31 Paul Eggert <eggert@cs.ucla.edu>
9814
9815 * ccl.c (CCL_CODE_RANGE): Allow negative numbers. (Bug#8751)
9816 (CCL_CODE_MIN): New macro.
9817
ed008a6d
PE
98182011-05-30 Paul Eggert <eggert@cs.ucla.edu>
9819
3687c2ef
PE
9820 * alloc.c (lisp_align_malloc): Omit unnecessary val==NULL tests.
9821
ed008a6d
PE
9822 * eval.c (Qdebug): Now static.
9823 * lisp.h (Qdebug): Remove decl. This reverts a part of the
9824 2011-04-26T11:26:05Z!dan.colascione@gmail.com that inadvertently undid part of
9825 2011-04-14T06:48:41Z!eggert@cs.ucla.edu.
9826
d66c4c7c
CY
98272011-05-29 Chong Yidong <cyd@stupidchicken.com>
9828
9829 * image.c: Various fixes to ImageMagick code comments.
9830 (Fimagemagick_types): Doc fix.
9831
5fbc2025
PE
98322011-05-29 Paul Eggert <eggert@cs.ucla.edu>
9833
0196f88a
PE
9834 Minor fixes prompted by GCC 4.6.0 warnings.
9835
9836 * xselect.c (converted_selections, conversion_fail_tag): Now static.
9837
5fbc2025
PE
9838 * emacs.c [HAVE_X_WINDOWS]: Include "xterm.h".
9839 (x_clipboard_manager_save_all): Move extern decl to ...
9840 * xterm.h: ... here, so that it can be checked for consistency.
9841
1dd3c2d9
CY
98422011-05-29 Chong Yidong <cyd@stupidchicken.com>
9843
9844 * xselect.c (x_clipboard_manager_save_frame)
9845 (x_clipboard_manager_save_all): New functions.
9846 (Fx_clipboard_manager_save): Lisp function deleted.
9847
9848 * emacs.c (Fkill_emacs): Call x_clipboard_manager_save_all.
9849 * frame.c (delete_frame): Call x_clipboard_manager_save_frame.
9850
9851 * xterm.h: Update prototype.
9852
5ba6571d
WX
98532011-05-28 William Xu <william.xwl@gmail.com>
9854
9855 * nsterm.m (ns_term_shutdown): Synchronize user defaults before
9856 exiting (Bug#8239).
9857
3eaff834
JM
98582011-05-28 Jim Meyering <meyering@redhat.com>
9859
e1900994 9860 Avoid a sign-extension bug in crypto_hash_function.
3eaff834
JM
9861 * fns.c (to_uchar): Define.
9862 (crypto_hash_function): Use it to convert some newly-signed
9863 variables to unsigned, to avoid sign-extension bugs. For example,
9864 without this change, (md5 "truc") would evaluate to
9865 45723a2aff78ff4fff7fff1114760e62 rather than the expected
9866 45723a2af3788c4ff17f8d1114760e62. Reported by Antoine Levitt in
e1900994 9867 https://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00883.html.
3eaff834 9868
0f6990a7
PE
98692011-05-27 Paul Eggert <eggert@cs.ucla.edu>
9870
9871 Integer overflow fixes.
c8a9ca5a 9872
08686060
PE
9873 * dbusbind.c: Serial number integer overflow fixes.
9874 (CHECK_DBUS_SERIAL_GET_SERIAL): New macro.
08686060
PE
9875 (Fdbus_call_method_asynchronously, xd_read_message_1): Use a float
9876 to hold a serial number that is too large for a fixnum.
9877 (Fdbus_method_return_internal, Fdbus_method_error_internal):
9878 Check for serial numbers out of range. Decode any serial number
59568bf0 9879 that was so large that it became a float. (Bug#8722)
08686060 9880
2d1fc3c7
PE
9881 * dbusbind.c: Use XFASTINT rather than XUINT, and check for nonneg.
9882 (Fdbus_call_method, Fdbus_call_method_asynchronously):
9883 Use XFASTINT rather than XUINT when numbers are nonnegative.
9884 (xd_append_arg, Fdbus_method_return_internal):
9885 (Fdbus_method_error_internal): Likewise. Also, for unsigned
9886 arguments, check that Lisp number is nonnegative, rather than
59568bf0 9887 silently wrapping negative numbers around. (Bug#8722)
30217ff0 9888 (xd_read_message_1): Don't assume dbus_uint32_t can fit in int.
59568bf0 9889 (Bug#8722)
2d1fc3c7 9890
c8a9ca5a
PE
9891 * data.c (arith_driver, Flsh): Avoid unnecessary casts to EMACS_UINT.
9892
519e1d69
PE
9893 * ccl.c (ccl_driver): Redo slightly to avoid the need for 'unsigned'.
9894
6df6ae42 9895 ccl: Add integer overflow checks.
30569699
PE
9896 * ccl.c (CCL_CODE_MAX, GET_CCL_RANGE, GET_CCL_CODE, GET_CCL_INT):
9897 (IN_INT_RANGE): New macros.
9898 (ccl_driver): Use them to check for integer overflow when
9899 decoding a CCL program. Many of the new checks are whether XINT (x)
9900 fits in int; it doesn't always, on 64-bit hosts. The new version
9901 doesn't catch all possible integer overflows, but it's an
847044ea 9902 improvement. (Bug#8719)
30569699 9903
c11285dc
PE
9904 * alloc.c (make_event_array): Use XINT, not XUINT.
9905 There's no need for unsigned here.
9906
fdccd48e
PE
9907 * mem-limits.h (EXCEEDS_LISP_PTR) [!USE_LSB_TAG]: EMACS_UINT -> uintptr_t
9908 This follows up to the 2011-05-06 change that substituted uintptr_t
9909 for EMACS_INT. This case wasn't caught back then.
9910
37910ab2
PE
9911 Rework Fformat to avoid integer overflow issues.
9912 * editfns.c: Include <float.h> unconditionally, as it's everywhere
9913 now (part of C89). Include <verify.h>.
9914 (MAX_10_EXP, CONVERTED_BYTE_SIZE): Remove; no longer needed.
9915 (pWIDE, pWIDElen, signed_wide, unsigned_wide): New defns.
9916 (Fformat): Avoid the prepass trying to compute sizes; it was only
9917 approximate and thus did not catch overflow reliably. Instead, walk
9918 through the format just once, formatting and computing sizes as we go,
9919 checking for integer overflow at every step, and allocating a larger
9920 buffer as needed. Keep track separately whether the format is
9921 multibyte. Keep only the most-recently calculated precision, rather
9922 than them all. Record whether each argument has been converted to
9923 string. Use EMACS_INT, not int, for byte and char and arg counts.
9924 Support field widths and precisions larger than INT_MAX. Avoid
9925 sprintf's undefined behavior with conversion specifications such as %#d
9926 and %.0c. Fix bug with strchr succeeding on '\0' when looking for
9927 flags. Fix bug with (format "%c" 256.0). Avoid integer overflow when
9928 formatting out-of-range floating point numbers with int
9173deec 9929 formats. (Bug#8668)
37910ab2 9930
2e6578fb
PE
9931 * lisp.h (FIXNUM_OVERFLOW_P): Work even if arg is a NaN.
9932
0ae6bdee
PE
9933 * data.c: Avoid integer truncation in expressions involving floats.
9934 * data.c: Include <intprops.h>.
9935 (arith_driver): When there's an integer overflow in an expression
9936 involving floating point, convert the integers to floating point
9937 so that the resulting value does not suffer from catastrophic
9938 integer truncation. For example, on a 64-bit host (* 4
9939 most-negative-fixnum 0.5) should yield about -4.6e+18, not zero.
9940 Do not rely on undefined behavior after integer overflow.
9941
de883a70
PE
9942 merge count_size_as_multibyte, parse_str_to_multibyte
9943 * character.c, character.h (count_size_as_multibyte):
fd6fa53f 9944 Rename from parse_str_to_multibyte; all uses changed.
de883a70
PE
9945 Check for integer overflow.
9946 * insdel.c, lisp.h (count_size_as_multibyte): Remove,
9947 since it's now a duplicate of the other. This is more of
9948 a character than a buffer op, so better that it's in character.c.
9949 * fns.c, print.c: Adjust to above changes.
9950
2ff916cb
PE
99512011-05-27 Stefan Monnier <monnier@iro.umontreal.ca>
9952
9953 * xselect.c (x_convert_selection): Yet another int/Lisp_Object mixup.
9954
f1b54466
PE
99552011-05-27 Paul Eggert <eggert@cs.ucla.edu>
9956
fb1ac845
PE
9957 * xselect.c: Fix minor problems prompted by GCC 4.6.0 warnings.
9958 (x_handle_selection_request, frame_for_x_selection): Remove unused vars.
9959 (x_clipboard_manager_save): Now static.
9960 (Fx_clipboard_manager_save): Rename local to avoid shadowing.
9961
f1b54466
PE
9962 * fns.c: Fix minor problems prompted by GCC 4.6.0 warnings.
9963 (crypto_hash_function): Now static.
9964 Fix pointer signedness problems. Avoid unnecessary initializations.
9965
a9f737ee
CY
99662011-05-27 Chong Yidong <cyd@stupidchicken.com>
9967
9968 * termhooks.h (Vselection_alist): Make it terminal-local.
9969
9970 * terminal.c (create_terminal): Initialize it.
9971
9972 * xselect.c: Support for clipboard managers.
9973 (Vselection_alist): Move to termhooks.h as terminal-local var.
9974 (LOCAL_SELECTION): New macro.
9975 (x_atom_to_symbol): Handle x_display_info_for_display fail case.
9976 (symbol_to_x_atom): Remove gratuitous arg.
9977 (x_handle_selection_request, lisp_data_to_selection_data)
9978 (x_get_foreign_selection, Fx_register_dnd_atom): Callers changed.
620c53a6
SM
9979 (x_own_selection, x_get_local_selection, x_convert_selection):
9980 New arg, specifying work frame. Use terminal-local Vselection_alist.
a9f737ee
CY
9981 (some_frame_on_display): Delete unused function.
9982 (Fx_own_selection_internal, Fx_get_selection_internal)
9983 (Fx_disown_selection_internal, Fx_selection_owner_p)
9984 (Fx_selection_exists_p): New optional frame arg.
9985 (frame_for_x_selection, Fx_clipboard_manager_save): New functions.
9986 (x_handle_selection_clear): Don't treat other terminals with the
9987 same keyboard specially. Use the terminal-local Vselection_alist.
9988 (x_clear_frame_selections): Use Frun_hook_with_args.
9989
9990 * xterm.c (x_term_init): Intern ATOM and CLIPBOARD_MANAGER atoms.
9991
9992 * xterm.h: Add support for those atoms.
9993
e067f0c1
CY
99942011-05-26 Chong Yidong <cyd@stupidchicken.com>
9995
9996 * xselect.c: ICCCM-compliant handling of MULTIPLE targets.
9997 (converted_selections, conversion_fail_tag): New global variables.
9998 (x_selection_request_lisp_error): Free the above.
9999 (x_get_local_selection): Remove unnecessary code.
10000 (x_reply_selection_request): Args changed; handle arbitrary array
620c53a6
SM
10001 of converted selections stored in converted_selections.
10002 Separate the XChangeProperty and SelectionNotify steps.
e067f0c1
CY
10003 (x_handle_selection_request): Rewrite to handle MULTIPLE target.
10004 (x_convert_selection): New function.
10005 (x_handle_selection_event): Simplify.
10006 (x_get_foreign_selection): Don't ignore incoming requests while
10007 waiting for an answer; this will fail when we implement
10008 SAVE_TARGETS, and seems unnecessary anyway.
10009 (selection_data_to_lisp_data): Recognize ATOM_PAIR type.
10010 (Vx_sent_selection_functions): Doc fix.
10011
0f4aebc0
LL
100122011-05-26 Leo Liu <sdl.web@gmail.com>
10013
10014 * editfns.c (Ftranspose_regions): Allow empty regions. (Bug#8699)
10015
e61124cd
YM
100162011-05-25 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
10017
10018 * dispextern.h (struct glyph_row): New member fringe_bitmap_periodic_p.
10019
10020 * dispnew.c (shift_glyph_matrix, scrolling_window): Mark scrolled row
10021 for fringe update if it has periodic bitmap.
ac389d0c 10022 (row_equal_p): Also compare left_fringe_offset, right_fringe_offset,
e61124cd
YM
10023 and fringe_bitmap_periodic_p.
10024
10025 * fringe.c (get_fringe_bitmap_data): New function.
10026 (draw_fringe_bitmap_1, update_window_fringes): Use it.
10027 (update_window_fringes): Record periodicity of fringe bitmap in glyph
10028 row. Mark glyph row for fringe update if periodicity changed.
10029
10030 * xdisp.c (try_window_reusing_current_matrix): Don't mark scrolled row
10031 for fringe update unless it has periodic bitmap.
10032
f16d9837
KH
100332011-05-25 Kenichi Handa <handa@m17n.org>
10034
10035 * xdisp.c (get_next_display_element): Set correct it->face_id for
10036 a static composition.
10037
e1b90ef6
LL
100382011-05-24 Leo Liu <sdl.web@gmail.com>
10039
10040 * deps.mk (fns.o):
10041 * makefile.w32-in ($(BLD)/fns.$(O)): Include sha1.h.
10042
10043 * fns.c (crypto_hash_function, Fsha1): New function.
10044 (Fmd5): Use crypto_hash_function.
10045 (syms_of_fns): Add Ssha1.
10046
7400048f
PE
100472011-05-22 Paul Eggert <eggert@cs.ucla.edu>
10048
10049 * gnutls.c: Remove unused macros.
10050 (fn_gnutls_transport_set_lowat, fn_gnutls_transport_set_pull_function):
10051 (fn_gnutls_transport_set_push_function) [!WINDOWSNT]:
10052 Remove macros that are defined and never used.
10053 Caught by gcc -Wunused-macros (GCC 4.6.0, Fedora 14).
10054
abb71cf4
CY
100552011-05-22 Chong Yidong <cyd@stupidchicken.com>
10056
10057 * xselect.c (syms_of_xselect): Remove unused symbol SAVE_TARGETS.
10058 (Fx_get_selection_internal): Minor cleanup.
10059 (Fx_own_selection_internal): Rename arguments for consistency with
10060 select.el.
10061
6307db39
PE
100622011-05-22 Paul Eggert <eggert@cs.ucla.edu>
10063
10064 * xselect.c (QSAVE_TARGETS): New static var, to fix build failure.
10065
f3d4e0a4
CY
100662011-05-22 Chong Yidong <cyd@stupidchicken.com>
10067
10068 * xselect.c (syms_of_xselect): Include character.h; use DEFSYM.
10069
4d8ade89
YM
100702011-05-21 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
10071
10072 * dispnew.c (scrolling_window): Don't exclude the case that the
10073 last enabled row in the desired matrix touches the bottom boundary.
10074
32078c8d
GM
100752011-05-21 Glenn Morris <rgm@gnu.org>
10076
10077 * Makefile.in ($(etc)/DOC): Make second command line even shorter.
33cf345f
GM
10078 (SOME_MACHINE_OBJECTS): Replace FONT_OBJ by its maximal expansion,
10079 and add some more files.
32078c8d 10080
7285dc67
EZ
100812011-05-20 Eli Zaretskii <eliz@gnu.org>
10082
10083 * callproc.c (Fcall_process) [MSDOS]: Fix arguments to
10084 report_file_error introduced by the change from 2011-05-07.
10085
89d1bd22
PE
100862011-05-20 Paul Eggert <eggert@cs.ucla.edu>
10087
10088 * systime.h (Time): Define only if emacs is defined.
10089 This is to allow ../lib-src/profile.c to be compiled on FreeBSD,
10090 where the include path doesn't have X11/X.h by default. See
10091 <http://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00561.html>.
10092
cd394be1 100932011-05-20 Kenichi Handa <handa@m17n.org>
31bfc35c
KH
10094
10095 * composite.c (find_automatic_composition): Fix previous change.
10096
b9704ad9
GM
100972011-05-20 Glenn Morris <rgm@gnu.org>
10098
10099 * lisp.mk: New file, split from Makefile.in.
10100 * Makefile.in (lisp): Move to separate file, inserted by @lisp_frag@.
10101 (shortlisp): Remove.
10102 ($(etc)/DOC): Edit lisp.mk rather than using $shortlisp.
10103
4a720484
GM
101042011-05-19 Glenn Morris <rgm@gnu.org>
10105
10106 * Makefile.in (MSDOS_SUPPORT_REAL, MSDOS_SUPPORT, NS_SUPPORT)
10107 (REAL_MOUSE_SUPPORT, GPM_MOUSE_SUPPORT, MOUSE_SUPPORT, TOOLTIP_SUPPORT)
10108 (BASE_WINDOW_SUPPORT, X_WINDOW_SUPPORT, WINDOW_SUPPORT): Remove.
10109 (lisp): Set the order to that of loadup.el.
10110 (shortlisp): Make it a copy of $lisp.
10111 (SOME_MACHINE_LISP): Remove.
10112 ($(etc)/DOC): Depend just on $lisp, not $SOME_MACHINE_LISP too.
10113 Use just $shortlisp, not $SOME_MACHINE_LISP too.
10114
a28d4396
KH
101152011-05-18 Kenichi Handa <handa@m17n.org>
10116
10117 * composite.c (CHAR_COMPOSABLE_P): Add more check for efficiency.
10118 (BACKWARD_CHAR): Wrap the arg STOP by parenthesis.
10119 (find_automatic_composition): Mostly rewrite for efficiency.
10120
a2b1fa8e
JB
101212011-05-18 Juanma Barranquero <lekktu@gmail.com>
10122
10123 * makefile.w32-in: Update dependencies.
10124
8e1f5610
CS
101252011-05-18 Christoph Scholtes <cschol2112@googlemail.com>
10126
10127 * menu.c: Include limits.h (fixes the MS-Windows build broken by
7d7d0045 10128 2011-06-18T18:49:19Z!cyd@stupidchicken.com).
8e1f5610 10129
7025ee00 101302011-05-18 Paul Eggert <eggert@cs.ucla.edu>
cb93f9be 10131
cdfa6eab
PE
10132 Fix some integer overflow issues, such as string length overflow.
10133
06d6db33
PE
10134 * insdel.c (count_size_as_multibyte): Check for string overflow.
10135
2b4560a8
PE
10136 * character.c (lisp_string_width): Check for string overflow.
10137 Use EMACS_INT, not int, for string indexes and lengths; in
10138 particular, 2nd arg is now EMACS_INT, not int. Do not crash if
10139 the resulting string length overflows an EMACS_INT; instead,
10140 report a string overflow if no precision given. When checking for
10141 precision exhaustion, use a check that cannot possibly have
10142 integer overflow. (Bug#8675)
10143 * character.h (lisp_string_width): Adjust to new signature.
10144
cb93f9be
PE
10145 * alloc.c (string_overflow): New function.
10146 (Fmake_string): Use it. This doesn't change behavior, but saves
10147 a few bytes and will simplify future changes.
10148 * character.c (string_escape_byte8): Likewise.
10149 * lisp.h (string_overflow): New decl.
10150
1a1f3366
PE
10151 Fixups, following up to the user-interface timestamp change.
10152 * nsterm.m (last_mouse_movement_time, ns_mouse_position): Use Time
10153 for UI timestamps, instead of unsigned long.
9fbd6841
PE
10154 * msdos.c (mouse_get_pos): Likewise.
10155 * w32inevt.c (movement_time, w32_console_mouse_position): Likewise.
1a1f3366
PE
10156 * w32gui.h (Time): Define by including "systime.h" rather than by
10157 declaring it ourselves. (Bug#8664)
10158
d4e3e4d3
PE
10159 * dispextern.h (struct image): Don't assume time_t <= unsigned long.
10160 * image.c (clear_image_cache): Likewise.
10161
f6a24d19
PE
10162 * term.c (term_mouse_position): Don't assume time_t wraparound.
10163
08dc5ae6
PE
10164 Be more systematic about user-interface timestamps.
10165 Before, the code sometimes used 'Time', sometimes 'unsigned long',
620c53a6
SM
10166 and sometimes 'EMACS_UINT', to represent these timestamps.
10167 This change causes it to use 'Time' uniformly, as that's what X uses.
08dc5ae6
PE
10168 This makes the code easier to follow, and makes it easier to catch
10169 integer overflow bugs such as Bug#8664.
10170 * frame.c (Fmouse_position, Fmouse_pixel_position):
10171 Use Time, not unsigned long, for user-interface timestamps.
10172 * keyboard.c (last_event_timestamp, kbd_buffer_get_event): Likewise.
10173 (button_down_time, make_lispy_position, make_lispy_movement): Likewise.
10174 * keyboard.h (last_event_timestamp): Likewise.
10175 * menu.c (Fx_popup_menu) [!HAVE_X_WINDOWS]: Likewise.
10176 * menu.h (xmenu_show): Likewise.
10177 * term.c (term_mouse_position): Likewise.
10178 * termhooks.h (struct input_event.timestamp): Likewise.
10179 (struct terminal.mouse_position_hook): Likewise.
10180 * xmenu.c (create_and_show_popup_menu, xmenu_show): Likewise.
10181 * xterm.c (XTmouse_position, x_scroll_bar_report_motion): Likewise.
10182 * systime.h (Time): New decl. Pull it in from <X11/X.h> if
10183 HAVE_X_WINDOWS, otherwise define it as unsigned long, which is
10184 what it was before.
10185 * menu.h, termhooks.h: Include "systime.h", for Time.
10186
8e55734a
PE
10187 * keyboard.c (make_lispy_event): Fix problem in integer overflow.
10188 Don't assume that the difference between two unsigned long values
10189 can fit into an integer. At this point, we know button_down_time
10190 <= event->timestamp, so the difference must be nonnegative, so
10191 there's no need to cast the result if double-click-time is
10192 nonnegative, as it should be; check that it's nonnegative, just in
10193 case. This bug is triggered when events are more than 2**31 ms
86db42d2 10194 apart (about 25 days). (Bug#8664)
8e55734a 10195
841f1b75 10196 * xselect.c (last_event_timestamp): Remove duplicate decl.
6434756c 10197 (x_own_selection): Remove needless cast to unsigned long.
841f1b75 10198
3e26f69c
PE
10199 * xmenu.c (set_frame_menubar): Use int, not EMACS_UINT, for indexes
10200 that always fit in int. Use a sentinel instead of a counter, to
10201 avoid a temp and to allay GCC's concerns about possible int overflow.
d230cb74
PE
10202 * frame.h (struct frame): Use int for menu_bar_items_used
10203 instead of EMACS_INT, since it always fits in int.
3e26f69c 10204
5cc152c0
PE
10205 * menu.c (grow_menu_items): Check for int overflow.
10206
d89eb65e
PE
10207 * xmenu.c (set_frame_menubar): Don't mishandle vectors with no nils.
10208
5235bd3e
PE
10209 * xterm.c: Use EMACS_INT for Emacs modifiers, and int for X modifiers.
10210 Before, the code was not consistent. These values cannot exceed
10211 2**31 - 1 so there's no need to make them unsigned.
10212 (x_x_to_emacs_modifiers): Accept int and return EMACS_INT.
10213 (x_emacs_to_x_modifiers): Accept EMACS_INT and return int.
10214 (x_x_to_emacs_modifiers, x_emacs_to_x_modifiers): Reject non-integers
10215 as modifiers.
10216 * xterm.h (x_x_to_emacs_modifiers): Adjust to signature change.
10217
bc827e23
PE
10218 * lisp.h (XINT) [USE_LISP_UNION_TYPE]: Cast to EMACS_INT.
10219 (XUINT) [USE_LISP_UNION_TYPE]: Cast to EMACS_UINT.
10220 Otherwise, GCC 4.6.0 warns about printf (pI, XINT (...)),
10221 presumably because the widths might not match.
10222
78eb494e
PE
10223 * window.c (size_window): Avoid needless test at loop start.
10224
04f2d78b
CB
102252011-05-18 Courtney Bane <emacs-bugs-7626@cbane.org> (tiny change)
10226
10227 * term.c (Fresume_tty): Restore hooks before reinitializing (bug#8687).
10228
d2fc7e3d 102292011-05-12 Drew Adams <drew.adams@oracle.com>
e531bdff
DA
10230
10231 * textprop.c (Fprevious_single_char_property_change): Doc fix (bug#8655).
10232
d2fc7e3d 102332011-05-12 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
7db47798
YM
10234
10235 * w32term.c (w32_draw_fringe_bitmap): Rename local vars `left' and
10236 `width' to `bar_area_x' and `bar_area_width', respectively.
10237 (x_scroll_run): Take account of fringe background extension.
10238
04f2d78b
CB
10239 * xterm.c (x_draw_fringe_bitmap) [USE_TOOLKIT_SCROLL_BARS]:
10240 Rename local vars `left' and `width' to `bar_area_x' and
7db47798
YM
10241 `bar_area_width', respectively.
10242 (x_scroll_run) [USE_TOOLKIT_SCROLL_BARS]: Take account of fringe
10243 background extension.
10244
79b70037
GM
102452011-05-10 Jim Meyering <meyering@redhat.com>
10246
10247 * xdisp.c (x_intersect_rectangles): Fix typo "the the -> the".
10248
2f142cc5
JB
102492011-05-10 Juanma Barranquero <lekktu@gmail.com>
10250
10251 * image.c (Finit_image_library): Return t for built-in image types,
10252 like pbm and xbm. (Bug#8640)
10253
57679c86
AS
102542011-05-09 Andreas Schwab <schwab@linux-m68k.org>
10255
10256 * w32menu.c (set_frame_menubar): Fix submenu allocation.
10257
888c9e86
EZ
102582011-05-07 Eli Zaretskii <eliz@gnu.org>
10259
b0512a1d
EZ
10260 * w32console.c (Fset_screen_color): Doc fix.
10261 (Fget_screen_color): New function.
10262 (syms_of_ntterm): Defsubr it.
10263
7285dc67
EZ
10264 * callproc.c (call_process_cleanup) [MSDOS]: Don't close and
10265 unlink the temporary file if Fcall_process didn't create it in the
10266 first place.
10267 (Fcall_process) [MSDOS]: Don't create tempfile if stdout of the
10268 child process will be redirected to a file specified with `:file'.
888c9e86
EZ
10269 Don't try to re-open tempfile in that case, and set fd[0] to -1 as
10270 cue to call_process_cleanup not to close that handle.
10271
4d3fcc8e
BK
102722011-05-07 Ben Key <bkey76@gmail.com>
10273
10274 * makefile.w32-in: The bootstrap-temacs rule now makes use of
10275 one of two shell specific rules, either bootstrap-temacs-CMD or
10276 bootstrap-temacs-SH. The bootstrap-temacs-SH rule is identical
10277 to the previous implementation of the bootstrap-temacs rule.
10278 The bootstrap-temacs-CMD rule is similar to the previous
10279 implementation of the bootstrap-temacs rule except that it
10280 makes use of the ESC_CFLAGS variable instead of the CFLAGS
10281 variable.
10282
10283 These changes, along with some changes to nt/configure.bat,
10284 nt/gmake.defs, and nt/nmake.defs, are required to extend my
10285 earlier fix to add support for --cflags and --ldflags options
10286 that include quotes so that it works whether make uses cmd or
10287 sh as the shell.
10288
b4289b64
MA
102892011-05-06 Michael Albinus <michael.albinus@gmx.de>
10290
10291 * dbusbind.c (QCdbus_type_unix_fd): Declare static.
10292 (xd_remove_watch): Don't check QCdbus_type_unix_fd for SYMBOLP, it
10293 is a constant.
10294 (Fdbus_init_bus, xd_read_queued_messages): Bus can be a symbol or
10295 a string. Handle both cases.
10296 (Fdbus_call_method_asynchronously, Fdbus_register_signal)
10297 (Fdbus_register_method): Use Qinvalid_function.
10298
af4c0e28
JB
102992011-05-06 Juanma Barranquero <lekktu@gmail.com>
10300
10301 * makefile.w32-in: Update dependencies.
10302 (LISP_H): Add inttypes.h and stdin.h.
10303 (PROCESS_H): Add unistd.h.
10304
c51453d9
EZ
103052011-05-06 Eli Zaretskii <eliz@gnu.org>
10306
10307 * lread.c: Include limits.h (fixes the MS-Windows build broken by
10308 2011-05-06T07:13:19Z!eggert@cs.ucla.edu).
10309
8ff0ac3c 103102011-05-06 Paul Eggert <eggert@cs.ucla.edu>
c032b5f8 10311
4c4b566b
PE
10312 * image.c (Finit_image_library) [!HAVE_NTGUI]: Omit unused local.
10313
aab2b9b5
PE
10314 * term.c (vfatal): Remove stray call to va_end.
10315 It's not needed and the C Standard doesn't allow it here anyway.
10316
c378da0b
PE
10317 Use C99's va_copy to avoid undefined behavior on x86-64 GNU/Linux.
10318 * eval.c (verror): doprnt a copy of ap, not the original. (Bug#8545)
10319
288b08c7
PE
10320 * eval.c (verror): OK to create a string of up to MOST_POSITIVE_FIXNUM
10321 bytes.
10322
e3601888
PE
10323 * term.c: Don't include <stdarg.h>, as <lisp.h> does that.
10324
db6c0e74
PE
10325 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork clobbering.
10326
dd5963ea
PE
10327 * process.c (Fformat_network_address): Fix typo: args2 -> *args2.
10328
88c9450f
PE
10329 * xmenu.c (set_frame_menubar): Fix typo: int * -> int (3 times).
10330
2f9442b8
PE
10331 * coding.c (detect_coding_charset): Fix typo: * 2 -> *4 (Bug#8601).
10332
c032b5f8
PE
10333 * charset.h (struct charset.code_space): Now has 15 elements, not 16.
10334 * charset.c (Fdefine_charset_internal): Don't initialize
10335 charset.code_space[15]. The value was garbage, on hosts with
2d38271b 10336 32-bit int (Bug#8600).
a108c10b
PE
10337
10338 * lread.c (read_integer): Be more consistent with string-to-number.
10339 Use string_to_number to do the actual conversion; this avoids
10340 rounding errors and fixes some other screwups. Without this fix,
10341 for example, #x1fffffffffffffff was misread as -2305843009213693952.
10342 (digit_to_number): Move earlier, for benefit of read_integer.
10343 Return -1 if the digit is out of range for the base, -2 if it is
48e400f0 10344 not a digit in any supported base. (Bug#8602)
a108c10b 10345
ad5f9eea
PE
10346 * doprnt.c (doprnt): Support arbitrary pI values, such as "I64".
10347
aec1708a
PE
10348 * dispnew.c (scrolling_window): Return 1 if we scrolled,
10349 to match comment at start of function. This also removes a
10350 GCC warning about overflow in a 32+64-bit port.
10351
47be4ab5
PE
10352 * lisp.h (EMACS_INT, EMACS_UINT, BITS_PER_EMACS_INT, pI): Simplify.
10353
371cac43
PE
10354 * dbusbind.c: Do not use XPNTR on a value that may be an integer.
10355 Reported by Stefan Monnier in
10356 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00919.html>.
04f2d78b
CB
10357 (xd_remove_watch, Fdbus_init_bus, xd_read_queued_messages):
10358 Use SYMBOLP-guarded XSYMBOL, not XPNTR.
371cac43 10359
d01a7826
PE
10360 * lisp.h (EMACS_INTPTR): Remove. All uses changed to intptr_t.
10361 (EMACS_UINTPTR): Likewise, with uintptr_t.
10362
7fd47d5c
PE
10363 * lisp.h: Prefer 64-bit EMACS_INT if available.
10364 (EMACS_INT, EMACS_UINT, BITS_PER_EMACS_INT, pI): Define to 64-bit
10365 on 32-bit hosts that have 64-bit int, so that they can access
10366 large files.
122b0c86
PE
10367 However, temporarily disable this change unless the temporary
10368 symbol WIDE_EMACS_INT is defined.
7fd47d5c 10369
8727937b
PE
10370 * lread.c, process.c: Do not include <inttypes.h>; lisp.h does it now.
10371
8ac068ac
PE
10372 Prefer intptr_t/uintptr_t for integers the same widths as pointers.
10373 This removes an assumption that EMACS_INT and long are the same
10374 width as pointers. The assumption is true for Emacs porting targets
10375 now, but we want to make other targets possible.
10376 * lisp.h: Include <inttypes.h>, for INTPTR_MAX, UINTPTR_MAX.
10377 (EMACS_INTPTR, EMACS_UINTPTR): New macros.
10378 In the rest of the code, change types of integers that hold casted
10379 pointers to EMACS_INTPTR and EMACS_UINTPTR, systematically
10380 replacing EMACS_INT, long, EMACS_UINT, and unsigned long.
10381 (XTYPE): Don't cast arg to EMACS_UINT; normally is not needed.
10382 (XSET): Cast type of XTYPE arg to EMACS_INTPTR; it is needed here.
10383 No need to cast type when ORing.
10384 (XPNTR): Return a value of type EMACS_INTPTR or EMACS_UINTPTR.
10385 * alloc.c (lisp_align_malloc): Remove a no-longer-needed cast.
10386 * doc.c (store_function_docstring): Use EMACS_INTPTR, so as not to
10387 assume EMACS_INT is the same width as char *.
10388 * gtkutil.c (xg_gtk_scroll_destroy, xg_tool_bar_button_cb):
10389 (xg_tool_bar_callback, xg_tool_bar_help_callback, xg_make_tool_item):
10390 Remove no-longer-needed casts.
10391 (xg_create_scroll_bar, xg_tool_bar_button_cb, xg_tool_bar_callback):
10392 (xg_tool_bar_help_callback, xg_make_tool_item):
10393 Use EMACS_INTPTR to hold an integer
10394 that will be cast to void *; this can avoid a GCC warning
10395 if EMACS_INT is not the same width as void *.
10396 * menu.c (find_and_call_menu_selection): Remove no-longer-needed cast.
10397 * xdisp.c (display_echo_area_1, resize_mini_window_1):
10398 (current_message_1, set_message_1):
10399 Use a local to convert to proper width without a cast.
10400 * xmenu.c (dialog_selection_callback): Likewise.
10401
ede49d71
PE
10402 * sysdep.c (get_random): Don't assume EMACS_INT is no wider than long.
10403 Also, don't assume VALBITS / RAND_BITS is less than 5,
10404 and don't rely on undefined behavior when shifting a 1 left into
10405 the sign bit.
10406 * lisp.h (get_random): Change signature to match.
10407
2f30ecd0
PE
10408 * lread.c (hash_string): Use size_t, not int, for hash computation.
10409 Normally we prefer signed values; but hashing is special, because
10410 it's better to use unsigned division on hash table sizes so that
10411 the remainder is nonnegative. Also, size_t is the natural width
10412 for hashing into memory. The previous code used 'int', which doesn't
10413 retain enough info to hash well into very large tables.
10414 (oblookup, oblookup_last_bucket_number, Funintern): Likewise.
10415
2a866e7b
PE
10416 * dbusbind.c: Don't possibly lose pointer info when converting.
10417 (xd_remove_watch, Fdbus_init_bus, xd_read_queued_messages):
10418 Use XPNTR rather than XHASH, so that the high-order bits of
10419 the pointer aren't lost when converting through void *.
10420
51639eac
PE
10421 * eval.c (Fautoload): Don't double-shift a pointer.
10422
92394119
PE
10423 * fns.c (Frandom): Let EMACS_UINT be wider than unsigned long.
10424
dbdb9a7c
JB
104252011-05-06 Juanma Barranquero <lekktu@gmail.com>
10426
10427 * gnutls.c (DEF_GNUTLS_FN):
10428 * image.c (DEF_IMGLIB_FN): Make function pointers static.
10429
db7a0b4f
AS
104302011-05-05 Andreas Schwab <schwab@linux-m68k.org>
10431
10432 * lread.c (lisp_file_lexically_bound_p): Stop scanning at end
10433 marker. (Bug#8610)
10434
cd394be1 104352011-05-05 Eli Zaretskii <eliz@gnu.org>
fab624aa
EZ
10436
10437 * w32heap.c (allocate_heap) [USE_LISP_UNION_TYPE || USE_LSB_TAG]:
10438 New version that can reserve upto 2GB of heap space.
10439
f7ff1b0f 104402011-05-05 Chong Yidong <cyd@stupidchicken.com>
45cb8994
CY
10441
10442 * nsfns.m (Fns_read_file_name): Doc fix (Bug#8534).
10443
639c109b
TZ
104442011-05-05 Teodor Zlatanov <tzz@lifelogs.com>
10445
10446 * gnutls.c (fn_gnutls_certificate_set_x509_key_file): Add alias to
10447 `gnutls_certificate_set_x509_key_file'.
10448
d2127135
JB
104492011-05-05 Juanma Barranquero <lekktu@gmail.com>
10450
10451 * makefile.w32-in ($(BLD)/image.$(O), $(BLD)/process.$(O)):
10452 Update dependencies.
10453
e968f4f3
JB
104542011-05-04 Juanma Barranquero <lekktu@gmail.com>
10455
10456 * gnutls.h (emacs_gnutls_write, emacs_gnutls_read):
10457 * gnutls.c (emacs_gnutls_write, emacs_gnutls_read):
10458 Remove unused parameter `fildes'.
10459 * process.c (read_process_output, send_process): Don't pass it.
10460
84d358f0
JB
104612011-05-04 Juanma Barranquero <lekktu@gmail.com>
10462
10463 Fix previous change: the library cache is defined in w32.c.
10464 * image.c (CACHE_IMAGE_TYPE) [!HAVE_NTGUI]: Define to noop.
10465 (Finit_image_library): Wrap Vlibrary_cache on "#ifdef HAVE_NTGUI".
10466
0898ca10
JB
104672011-05-04 Juanma Barranquero <lekktu@gmail.com>
10468
10469 Implement dynamic loading of GnuTLS on Windows.
10470
10471 * gnutls.h (GNUTLS_EMACS_ERROR_NOT_LOADED): New macro.
10472 (emacs_gnutls_write, emacs_gnutls_read): Mark as extern.
10473 (emacs_gnutls_record_check_pending, emacs_gnutls_transport_set_errno):
10474 Declare.
10475
10476 * gnutls.c (Qgnutls_dll): Define.
10477 (DEF_GNUTLS_FN, LOAD_GNUTLS_FN): New macros.
10478 (gnutls_*): Declare function pointers.
10479 (init_gnutls_functions): New function to initialize function pointers.
10480 (emacs_gnutls_handshake, Fgnutls_error_string, Fgnutls_deinit)
10481 (emacs_gnutls_global_init, Fgnutls_bye): Use function pointers.
10482 (emacs_gnutls_record_check_pending, emacs_gnutls_transport_set_errno):
10483 Wrappers for gnutls_record_check_pending and gnutls_transport_set_errno.
10484 (emacs_gnutls_write, emacs_gnutls_read)
10485 (emacs_gnutls_handle_error, Fgnutls_error_fatalp)
10486 (Fgnutls_available_p): New function.
10487 (Fgnutls_boot): Call Fgnutls_available_p. Use function pointers.
10488 (syms_of_gnutls) <Qgnutls_dll>: Initialize and staticpro it.
10489 (syms_of_gnutls) <Sgnutls_available_p>: defsubr it.
10490
10491 * image.c: Include w32.h.
10492 (Vimage_type_cache): Delete.
10493 (syms_of_image) <Vimage_type_cache>: Don't initialize and staticpro it.
10494 (CACHE_IMAGE_TYPE, Finit_image_library): Use Vlibrary_cache instead.
10495 (w32_delayed_load): Move to w32.c.
10496
10497 * w32.h (VlibraryCache, QCloaded_from, w32_delayed_load): Declare.
10498
10499 * w32.c (QCloaded_from, Vlibrary_cache): Define.
10500 (w32_delayed_load): Move from image.c. When loading a library, record
10501 its filename in the :loaded-from property of the library id.
10502 (globals_of_w32) <QCloaded_from, Vlibrary_cache>:
10503 Initialize and staticpro them.
10504 (emacs_gnutls_pull, emacs_gnutls_push): Call emacs_gnutls_* functions.
10505
10506 * process.c: Include lisp.h before w32.h, not after.
10507 (wait_reading_process_output): Call emacs_gnutls_record_check_pending
10508 instead of gnutls_record_check_pending.
10509
10510 * callproc.c, emacs.c: Include lisp.h before w32.h, not after.
10511
ff4de4aa
TZ
105122011-05-04 Teodor Zlatanov <tzz@lifelogs.com>
10513
10514 * gnutls.c (Fgnutls_boot): Support :keylist and :crlfiles options
10515 instead of :keyfiles. Give GnuTLS the keylist and the CRL lists
10516 as passed in.
10517
abe95abb
JD
105182011-05-03 Jan Djärv <jan.h.d@swipnet.se>
10519
10520 * xterm.c (x_set_frame_alpha): Do not set property on anything
10521 else than FRAME_X_OUTER_WINDOW (Bug#8608).
10522
e16e55d4
JB
105232011-05-02 Juanma Barranquero <lekktu@gmail.com>
10524
10525 * sysdep.c (get_tty_size) [WINDOWSNT]: Implement. (Bug#8596)
10526
bafcf6a5
JB
105272011-05-02 Juanma Barranquero <lekktu@gmail.com>
10528
10529 * gnutls.c (Qgnutls_log_level, Qgnutls_code, Qgnutls_anon)
10530 (Qgnutls_x509pki, Qgnutls_e_interrupted, Qgnutls_e_again)
10531 (Qgnutls_e_invalid_session, Qgnutls_e_not_ready_for_handshake)
10532 (gnutls_global_initialized, Qgnutls_bootprop_priority)
10533 (Qgnutls_bootprop_trustfiles, Qgnutls_bootprop_keyfiles)
10534 (Qgnutls_bootprop_callbacks, Qgnutls_bootprop_loglevel)
10535 (Qgnutls_bootprop_hostname, Qgnutls_bootprop_verify_flags)
10536 (Qgnutls_bootprop_verify_error, Qgnutls_bootprop_verify_hostname_error)
10537 (Qgnutls_bootprop_callbacks_verify): Make static.
10538
e7a6747f
AS
105392011-05-01 Andreas Schwab <schwab@linux-m68k.org>
10540
19ed11ba
AS
10541 * callproc.c: Indentation fixup.
10542
e7a6747f 10543 * sysdep.c (wait_for_termination_1): Make static.
04f2d78b
CB
10544 (wait_for_termination, interruptible_wait_for_termination):
10545 Move after wait_for_termination_1.
e7a6747f 10546
1ef14cb4
LMI
105472011-05-01 Lars Magne Ingebrigtsen <larsi@gnus.org>
10548
10549 * sysdep.c (interruptible_wait_for_termination): New function
10550 which is like wait_for_termination, but allows keyboard
10551 interruptions.
10552
10553 * callproc.c (Fcall_process): Add (:file "file") as an option for
10554 the STDOUT buffer.
10555 (Fcall_process_region): Ditto.
10556
330d880c
EZ
105572011-04-30 Eli Zaretskii <eliz@gnu.org>
10558
8db90b73
EZ
10559 * dosfns.c (Fint86, Fdos_memget, Fdos_memput): Use `ASIZE (FOO)'
10560 rather than `XVECTOR (FOO)->size'.
10561
330d880c
EZ
10562 * process.c: Remove HAVE_INTTYPES_H condition from inclusion of
10563 inttypes.h, as a gnulib replacement is used if it not available in
10564 system headers.
10565
15cbd324
EZ
105662011-04-21 Eli Zaretskii <eliz@gnu.org>
10567
10568 Lift the MOST_POSITIVE_FIXNUM/4 limitation on visited files.
10569 * fileio.c (Finsert_file_contents): Don't limit file size to 1/4
10570 of MOST_POSITIVE_FIXNUM. (Bug#8528)
10571
10572 * coding.c (coding_alloc_by_realloc): Error out if destination
10573 will grow beyond MOST_POSITIVE_FIXNUM.
10574 (decode_coding_emacs_mule): Abort if there isn't enough place in
10575 charbuf for the composition carryover bytes. Reserve an extra
10576 space for up to 2 characters produced in a loop.
10577 (decode_coding_iso_2022): Abort if there isn't enough place in
10578 charbuf for the composition carryover bytes.
10579
105802011-04-21 Eli Zaretskii <eliz@gnu.org>
afda1437 10581
ae940cca
EZ
10582 * doprnt.c (doprnt) [!HAVE_LONG_LONG_INT]: Error out instead of
10583 aborting when %lld or %lll format is passed.
10584 [!HAVE_UNSIGNED_LONG_LONG_INT]: Error out instead of aborting when
10585 %llo or %llx format is passed. (Bug#8545)
10586
03ab8921
EZ
10587 * window.c (window_scroll_line_based): Use a marker instead of
10588 simple variables to record original value of point. (Bug#7952)
10589
afda1437
EZ
10590 * doprnt.c (doprnt): Fix the case where a multibyte sequence
10591 produced by %s or %c overflows available buffer space. (Bug#8545)
10592
f76dee0c
PE
105932011-04-28 Paul Eggert <eggert@cs.ucla.edu>
10594
10595 * doprnt.c (doprnt): Omit useless test; int overflow check (Bug#8545).
283cdbef 10596 (SIZE_MAX): Move defn after all includes, as they might #define it.
f76dee0c 10597
fdc5744d
JB
105982011-04-28 Juanma Barranquero <lekktu@gmail.com>
10599
10600 * w32.c (init_environment): Warn about defaulting HOME to C:\.
10601
638f053a
JB
106022011-04-28 Juanma Barranquero <lekktu@gmail.com>
10603
10604 * keyboard.c (Qdelayed_warnings_hook): Define.
10605 (command_loop_1): Run `delayed-warnings-hook'
10606 if Vdelayed_warnings_list is non-nil.
10607 (syms_of_keyboard) <delayed-warnings-hook>: DEFSYM it.
10608 (syms_of_keyboard) <delayed-warnings-list>: DEFVAR_LISP it.
10609
d178f871
EZ
106102011-04-28 Eli Zaretskii <eliz@gnu.org>
10611
10612 * doprnt.c (doprnt): Don't return value smaller than the buffer
10613 size if the message was truncated. (Bug#8545).
10614
b124fd93
JB
106152011-04-28 Juanma Barranquero <lekktu@gmail.com>
10616
10617 * w32fns.c (Fx_change_window_property, Fx_delete_window_property)
10618 (Fx_window_property): #if-0 the whole functions, not just the bodies.
10619
e810457d
PE
106202011-04-27 Paul Eggert <eggert@cs.ucla.edu>
10621
10622 * doprnt.c (doprnt): Support "ll" length modifier, for long long.
10623
ea51cceb
JB
106242011-04-27 Juanma Barranquero <lekktu@gmail.com>
10625
10626 * makefile.w32-in: Update dependencies.
10627
94dcfacf
EZ
106282011-04-27 Eli Zaretskii <eliz@gnu.org>
10629
10630 Improve `doprnt' and its usage. (Bug#8545)
10631 * doprnt.c (doprnt): Make sure `format' is never accessed beyond
10632 `format_end'. Remove support for %l as a conversion specifier.
10633 Don't use xrealloc. Improve diagnostics when the %l size modifier
10634 is used. Update the commentary.
10635
10636 * eval.c (verror): Simplify calculation of size_t.
10637
10638 * coding.c (Ffind_operation_coding_system): Fix diagnostic error
10639 messages.
10640
f61f41d7
PE
106412011-04-27 Yoshiaki Kasahara <kasahara@nc.kyushu-u.ac.jp> (tiny change)
10642
10643 * buffer.c (init_buffer) [USE_MMAP_FOR_BUFFERS]: Adjust to aliasing
10644 change.
10645
96fb4434
PE
106462011-04-27 Paul Eggert <eggert@cs.ucla.edu>
10647
10648 * nsmenu.m: Replace all uses of XVECTOR with ASIZE and AREF.
10649 This makes this file independent of the recent pseudovector change.
10650
671875da 106512011-04-26 Paul Eggert <eggert@cs.ucla.edu>
eab3844f 10652
69e9b5a3
PE
10653 * keyboard.c (handle_user_signal): Fix pointer signedness problem.
10654
b5f869a7 10655 * gnutls.c (emacs_gnutls_handle_error): Remove unused local.
7754e151 10656 (Fgnutls_boot): gnutls_certificate_verify_peers2 wants unsigned *.
8d4c3955 10657 Remove unused local.
c8926152 10658 (emacs_gnutls_write): Don't use uninitialized rtnval if nbyte <= 0.
080e5a8d 10659
841a1577 10660 * lisp.h: Fix a problem with aliasing and vector headers. (Bug#8546)
04f2d78b
CB
10661 GCC 4.6.0 optimizes based on type-based alias analysis.
10662 For example, if b is of type struct buffer * and v of type struct
eab3844f
PE
10663 Lisp_Vector *, then gcc -O2 was incorrectly assuming that &b->size
10664 != &v->size, and therefore "v->size = 1; b->size = 2; return
10665 v->size;" must therefore return 1. This assumption is incorrect
10666 for Emacs, since it type-puns struct Lisp_Vector * with many other
10667 types. To fix this problem, this patch adds a new type struct
f904488f 10668 vectorlike_header that documents the constraints on layout of vectors
eab3844f
PE
10669 and pseudovectors, and helps optimizing compilers not get fooled
10670 by Emacs's type punning. It also adds the macros XSETTYPED_PVECTYPE
10671 XSETTYPED_PSEUDOVECTOR, TYPED_PSEUDOVECTORP, for similar reasons.
f904488f
PE
10672 * lisp.h (XSETTYPED_PVECTYPE): New macro, specifying the name of
10673 the size member.
eab3844f
PE
10674 (XSETPVECTYPE): Rewrite in terms of new macro.
10675 (XSETPVECTYPESIZE): New macro, specifying both type and size.
10676 This is a bit clearer, and further avoids the possibility of
10677 undesirable aliasing.
10678 (XSETTYPED_PSEUDOVECTOR): New macro, specifying the size.
f904488f 10679 (XSETPSEUDOVECTOR): Rewrite in terms of XSETTYPED_PSEUDOVECTOR.
eab3844f
PE
10680 (XSETSUBR): Rewrite in terms of XSETTYPED_PSEUDOVECTOR and XSIZE,
10681 since Lisp_Subr is a special case (no "next" field).
04f2d78b
CB
10682 (ASIZE): Now uses header.size rather than size.
10683 All previous uses of XVECTOR (foo)->size replaced to use this macro,
f904488f
PE
10684 to avoid the hassle of writing XVECTOR (foo)->header.size.
10685 (struct vectorlike_header): New type.
eab3844f
PE
10686 (TYPED_PSEUDOVECTORP): New macro, also specifying the C type of the
10687 object, to help avoid aliasing.
10688 (PSEUDOVECTORP): Rewrite in terms of TYPED_PSEUDOVECTORP.
10689 (SUBRP): Likewise, since Lisp_Subr is a special case.
10690 * lisp.h (struct Lisp_Vector, struct Lisp_Char_Table):
10691 (struct Lisp_Sub_Char_Table, struct Lisp_Bool_Vector):
10692 (struct Lisp_Hash_Table): Combine first two members into a single
f904488f 10693 struct vectorlike_header member. All uses of "size" and "next" members
eab3844f
PE
10694 changed to be "header.size" and "header.next".
10695 * buffer.h (struct buffer): Likewise.
10696 * font.h (struct font_spec, struct font_entity, struct font): Likewise.
10697 * frame.h (struct frame): Likewise.
10698 * process.h (struct Lisp_Process): Likewise.
10699 * termhooks.h (struct terminal): Likewise.
10700 * window.c (struct save_window_data, struct saved_window): Likewise.
10701 * window.h (struct window): Likewise.
10702 * alloc.c (allocate_buffer, Fmake_bool_vector, allocate_pseudovector):
10703 Use XSETPVECTYPESIZE, not XSETPVECTYPE, to avoid aliasing problems.
10704 * buffer.c (init_buffer_once): Likewise.
10705 * lread.c (defsubr): Use XSETTYPED_PVECTYPE, since Lisp_Subr is a
10706 special case.
10707 * process.c (Fformat_network_address): Use local var for size,
10708 for brevity.
10709
0df1eac5
PE
10710 * bytecode.c (exec_byte_code): Don't use XVECTOR before CHECK_VECTOR.
10711
847ab9d1 10712 Make the Lisp reader and string-to-float more consistent (Bug#8525)
452f4150
PE
10713 * data.c (atof): Remove decl; no longer used or needed.
10714 (digit_to_number): Move to lread.c.
10715 (Fstring_to_number): Use new string_to_number function, to be
10716 consistent with how the Lisp reader treats infinities and NaNs.
10717 Do not assume that floating-point numbers represent EMACS_INT
10718 without losing information; this is not true on most 64-bit hosts.
10719 Avoid double-rounding errors, by insisting on integers when
10720 parsing non-base-10 numbers, as the documentation specifies.
10721 * lisp.h (string_to_number): New decl, replacing ...
10722 (isfloat_string): Remove.
bc0a5c13 10723 * lread.c: Include <inttypes.h>, for uintmax_t and strtoumax.
d78050d6 10724 (read1): Do not accept +. and -. as integers; this
452f4150
PE
10725 appears to have been a coding error. Similarly, do not accept
10726 strings like +-1e0 as floating point numbers. Do not report
10727 overflow for integer overflows unless the base is not 10 which
10728 means we have no simple and reliable way to continue.
10729 Break out the floating-point parsing into a new
10730 function string_to_number, so that Fstring_to_number parses
10731 floating point numbers consistently with the Lisp reader.
04f2d78b 10732 (digit_to_number): Move here from data.c. Make it static inline.
452f4150
PE
10733 (E_CHAR, EXP_INT): Remove, replacing with ...
10734 (E_EXP): New macro, to solve the "1.0e+" problem mentioned below.
10735 (string_to_number): New function, replacing isfloat_string.
10736 This function checks for valid syntax and produces the resulting
10737 Lisp float number too. Rework it so that string-to-number
bc0a5c13 10738 no longer mishandles examples like "1.0e+". Use strtoumax,
d78050d6
PE
10739 so that overflow for non-base-10 numbers is reported only when
10740 there's no portable and simple way to convert to floating point.
452f4150 10741
67769ffc
PE
10742 * textprop.c (set_text_properties_1): Rewrite for clarity,
10743 and to avoid GCC warning about integer overflow.
10744
c20db43f
PE
10745 * intervals.h (struct interval): Use EMACS_INT for members
10746 where EMACS_UINT might cause problems. See
10747 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00514.html>.
10748 (CHECK_TOTAL_LENGTH): Remove cast to EMACS_INT; no longer needed.
10749 * intervals.c (interval_deletion_adjustment): Now returns EMACS_INT.
10750 All uses changed.
37aa2f85
PE
10751 (offset_intervals): Tell GCC not to worry about length overflow
10752 when negating a negative length.
c20db43f 10753
2538aa2f
PE
10754 * alloc.c (overrun_check_malloc, overrun_check_realloc): Now static.
10755 (overrun_check_free): Likewise.
10756
f2d3008d
PE
10757 * alloc.c (SDATA_SIZE) [!GC_CHECK_STRING_BYTES]: Avoid runtime check
10758 in the common case where SDATA_DATA_OFFSET is a multiple of Emacs
10759 word size.
10760
ec8df744
PE
10761 * gnutls.c: Fix problems found by GCC 4.6.0 on Ubuntu 10.10.
10762 (gnutls_make_error): Rename local to avoid shadowing.
10763 (gnutls_emacs_global_deinit): ifdef out; not used.
10764 (Fgnutls_boot): Use const for pointer to readonly storage.
10765 Comment out unused local. Fix pointer signedness problems.
10766
640ee02d
PE
10767 * lread.c (openp): Don't stuff size_t into an 'int'.
10768 Use <= on length, not < on length + 1, to avoid GCC 4.6.0 warning
10769 about possible signed overflow.
10770
6048fb2a
PE
10771 * gtkutil.c: Fix problems found by GCC 4.6.0 on Ubuntu 10.10.
10772 (GDK_KEY_g): Don't define if already defined.
10773 (xg_prepare_tooltip): Avoid pointer signedness problem.
10774 (xg_set_toolkit_scroll_bar_thumb): Redo to avoid two casts.
10775
fa3c87e1
PE
10776 * process.c (Fnetwork_interface_info): Avoid left-shift undefined
10777 behavior with 1 << 31. GCC 4.6.0 warns about this on 32-bit hosts.
10778
2172544b
PE
10779 * xfns.c (Fx_window_property): Simplify a bit,
10780 to make a bit faster and to avoid GCC 4.6.0 warning.
10781 * xselect.c (x_get_window_property, x_handle_dnd_message): Likewise.
10782
9b821a21
PE
10783 * fns.c (internal_equal): Don't assume size_t fits in int.
10784
3c616cfa
PE
10785 * alloc.c (compact_small_strings): Tighten assertion a little.
10786
c2982e87
PE
10787 Replace pEd with more-general pI, and fix some printf arg casts.
10788 * lisp.h (pI): New macro, generalizing old pEd macro to other
10789 conversion specifiers. For example, use "...%"pI"d..." rather
10790 than "...%"pEd"...".
10791 (pEd): Remove. All uses replaced with similar uses of pI.
61bdb816 10792 * m/amdx86-64.h, m/ia64.h, m/ibms390x.h: Likewise.
c2982e87
PE
10793 * alloc.c (check_pure_size): Don't overflow by converting size to int.
10794 * bidi.c (bidi_dump_cached_states): Use pI to avoid cast.
10795 * data.c (Fnumber_to_string): Use pI instead of if-then-else-abort.
10796 * dbusbind.c (xd_append_arg): Use pI to avoid cast.
10797 (Fdbus_method_return_internal, Fdbus_method_error_internal): Likewise.
10798 * font.c (font_unparse_xlfd): Avoid potential buffer overrun on
10799 64-bit hosts.
10800 (font_unparse_xlfd, font_unparse_fcname): Use pI to avoid casts.
10801 * keyboard.c (record_char, modify_event_symbol): Use pI to avoid casts.
10802 * print.c (safe_debug_print, print_object): Likewise.
10803 (print_object): Don't overflow by converting EMACS_INT or EMACS_UINT
10804 to int.
6f04d126
PE
10805 Use pI instead of if-then-else-abort. Use %p to avoid casts,
10806 avoiding the 0 flag, which is not portable.
c2982e87
PE
10807 * process.c (Fmake_network_process): Use pI to avoid cast.
10808 * region-cache.c (pp_cache): Likewise.
10809 * xdisp.c (decode_mode_spec): Likewise.
10810 * xrdb.c (x_load_resources) [USE_MOTIF]: Use pI to avoid undefined
10811 behavior on 64-bit hosts with printf arg.
6f04d126 10812 * xselect.c (x_queue_event): Use %p to avoid casts, avoiding 0 flag.
c2982e87
PE
10813 (x_stop_queuing_selection_requests): Likewise.
10814 (x_get_window_property): Don't truncate byte count to an 'int'
10815 when tracing.
0b432f21 10816
5e073ec7
PE
10817 * frame.c (frame_name_fnn_p): Get rid of strtol, which isn't right
10818 here, since it parses constructs like leading '-' and spaces,
10819 which are not wanted; and it overflows with large numbers.
10820 Instead, simply match F[0-9]+, which is what is wanted anyway.
10821
36372bf9
PE
10822 * alloc.c: Remove unportable assumptions about struct layout.
10823 (SDATA_SELECTOR, SDATA_DATA_OFFSET): New macros.
10824 (SDATA_OF_STRING, SDATA_SIZE, allocate_string_data):
10825 (allocate_vectorlike, make_pure_vector): Use the new macros,
10826 plus offsetof, to remove unportable assumptions about struct layout.
10827 These assumptions hold on all porting targets that I know of, but
10828 they are not guaranteed, they're easy to remove, and removing them
10829 makes further changes easier.
10830
0b432f21
PE
10831 * alloc.c (BLOCK BYTES): Fix typo by changing "ablock" to "ablocks".
10832 This doesn't fix a bug but makes the code clearer.
bfd1c781
PE
10833 (string_overrun_cookie): Now const. Use initializers that
10834 don't formally overflow signed char, to avoid warnings.
000098c1
PE
10835 (allocate_string_data) [GC_CHECK_STRING_OVERRUN]: Fix typo that
10836 can cause Emacs to crash when string overrun checking is enabled.
c7bda33c
PE
10837 (allocate_buffer): Don't assume sizeof (struct buffer) is a
10838 multiple of sizeof (EMACS_INT); it need not be, if
10839 alignof(EMACS_INT) < sizeof (EMACS_INT).
d0f4e1f5 10840 (check_sblock, check_string_bytes, check_string_free_list): Protoize.
0b432f21 10841
895009e1
JB
108422011-04-26 Juanma Barranquero <lekktu@gmail.com>
10843
10844 * keyboard.c (QCrtl): Rename from Qrtl. All uses changed.
10845
6a7a1b0b
TZ
108462011-04-26 Teodor Zlatanov <tzz@lifelogs.com>
10847
10848 * gnutls.c (emacs_gnutls_handshake): Return an error if we're not
b5f869a7 10849 supposed to be handshaking. (Bug#8556)
6a7a1b0b
TZ
10850 Reported by Paul Eggert <eggert@cs.ucla.edu>.
10851
841a1577 108522011-04-26 Daniel Colascione <dan.colascione@gmail.com>
0438ce91
DC
10853
10854 * lisp.h (Qdebug): List symbol.
895009e1 10855 * eval.c (Qdebug): Restore global linkage.
0438ce91
DC
10856 * keyboard.c (debug-on-event): New variable.
10857 (handle_user_signal): Break into debugger when debug-on-event
10858 matches the current signal symbol.
10859
f2d3ba6f
DN
108602011-04-25 Dan Nicolaescu <dann@ics.uci.edu>
10861
10862 * alloc.c (check_sblock, check_string_bytes)
10863 (check_string_free_list): Convert to standard C.
10864
42ce4c63
TZ
108652011-04-25 Teodor Zlatanov <tzz@lifelogs.com>
10866
10867 * w32.c (emacs_gnutls_push): Fix typo.
10868
825cd63c
EZ
108692011-04-25 Eli Zaretskii <eliz@gnu.org>
10870
fb11d64d
EZ
10871 * gnutls.c (emacs_gnutls_handshake): Avoid compiler warnings about
10872 "cast to pointer from integer of different size".
10873
825cd63c
EZ
10874 Improve doprnt and its use in verror. (Bug#8545)
10875 * doprnt.c (doprnt): Document the set of format control sequences
10876 supported by the function. Use SAFE_ALLOCA instead of always
10877 using `alloca'.
10878
10879 * eval.c (verror): Don't limit the buffer size at size_max-1, that
10880 is one byte too soon. Don't use xrealloc; instead xfree and
10881 xmalloc anew.
10882
e061a11b
TZ
108832011-04-24 Teodor Zlatanov <tzz@lifelogs.com>
10884
10885 * gnutls.h: Add GNUTLS_STAGE_CALLBACKS enum to denote we're in the
10886 callbacks stage.
10887
10888 * gnutls.c: Renamed global_initialized to
10889 gnutls_global_initialized. Added internals for the
10890 :verify-hostname-error, :verify-error, and :verify-flags
10891 parameters of `gnutls-boot' and documented those parameters in the
10892 docstring. Start callback support.
9173deec
JB
10893 (emacs_gnutls_handshake): Add Woe32 support. Retry handshake
10894 unless a fatal error occurred. Call gnutls_alert_send_appropriate
10895 on error. Return error code.
e061a11b
TZ
10896 (emacs_gnutls_write): Call emacs_gnutls_handle_error.
10897 (emacs_gnutls_read): Likewise.
10898 (Fgnutls_boot): Return handshake error code.
10899 (emacs_gnutls_handle_error): New function.
10900 (wsaerror_to_errno): Likewise.
10901
10902 * w32.h (emacs_gnutls_pull): Add prototype.
10903 (emacs_gnutls_push): Likewise.
10904
10905 * w32.c (emacs_gnutls_pull): New function for GnuTLS on Woe32.
10906 (emacs_gnutls_push): Likewise.
10907
109082011-04-24 Claudio Bley <claudio.bley@gmail.com> (tiny change)
10909
10910 * process.c (wait_reading_process_output): Check if GnuTLS
10911 buffered some data internally if no FDs are set for TLS
10912 connections.
10913
10914 * makefile.w32-in (OBJ2): Add gnutls.$(O).
10915 (LIBS): Link to USER_LIBS.
10916 ($(BLD)/gnutls.$(0)): New target.
10917
fa6996bc
EZ
109182011-04-24 Eli Zaretskii <eliz@gnu.org>
10919
eb35682e
EZ
10920 * xdisp.c (handle_single_display_spec): Rename the
10921 display_replaced_before_p argument into display_replaced_p, to
10922 make it consistent with the commentary. Fix typos in the
10923 commentary.
10924
e2ad650c
EZ
10925 * textprop.c (syms_of_textprop): Remove dead code.
10926 (copy_text_properties): Delete obsolete commentary about an
10927 interface that was deleted long ago. Fix typos in the description
10928 of arguments.
10929
1b2de274
EZ
10930 * msdos.c (XMenuActivate, XMenuAddSelection): Adjust argument list
10931 to changes in oldXMenu/XMenu.h from 2011-04-16.
10932 <menu_help_message, prev_menu_help_message>: Constify.
10933 (IT_menu_make_room): menu->help_text is now `const char **';
10934 adjust.
10935
10936 * msdos.h (XMenuActivate, XMenuAddSelection): Adjust prototypes
10937 to changes in oldXMenu/XMenu.h from 2011-04-16.
10938 (struct XMenu): Declare `help_text' `const char **'.
10939
10940 * xfaces.c <Qunspecified>: Make extern again.
10941
10942 * syntax.c: Include sys/types.h before including regex.h, as
75f1671a 10943 required by POSIX.
1b2de274 10944
762b15be
EZ
10945 * doc.c (get_doc_string): Improve the format passed to `error'.
10946
10947 * doprnt.c (doprnt): Improve commentary.
10948
10949 * term.c (init_tty) [MSDOS]: Fix 1st argument to maybe_fatal.
10950
10951 * Makefile.in (TAGS): Depend on $(M_FILE) and $(S_FILE), and scan
10952 them with etags.
10953
f1052e5d
EZ
10954 * makefile.w32-in (globals.h): Add a dummy recipe, to make any
10955 changes in globals.h immediately force recompilation.
762b15be
EZ
10956 (TAGS): Depend on $(CURDIR)/m/intel386.h and
10957 $(CURDIR)/s/ms-w32.h.
10958 (TAGS-gmake): Scan $(CURDIR)/m/intel386.h and $(CURDIR)/s/ms-w32.h.
f1052e5d 10959
fa6996bc
EZ
10960 * character.c (Fchar_direction): Function deleted.
10961 (syms_of_character): Don't defsubr it.
10962 <char-direction-table>: Deleted.
10963
e6c3da20
EZ
109642011-04-23 Eli Zaretskii <eliz@gnu.org>
10965
10966 Fix doprnt so it could be used again safely in `verror'. (Bug#8435)
10967 * doprnt.c: Include limits.h.
10968 (SIZE_MAX): New macro.
04f2d78b
CB
10969 (doprnt): Return a size_t value. 2nd arg is now size_t.
10970 Many local variables are now size_t instead of int or unsigned.
e6c3da20
EZ
10971 Improve overflow protection. Support `l' modifier for integer
10972 conversions. Support %l conversion. Don't assume an EMACS_INT
10973 argument for integer conversions and for %c.
10974
10975 * lisp.h (doprnt): Restore prototype.
10976
10977 * makefile.w32-in ($(BLD)/callint.$(O)): Depend on
10978 $(SRC)/character.h.
10979
10980 * Makefile.in (base_obj): Add back doprnt.o.
10981
10982 * deps.mk (doprnt.o): Add back prerequisites.
10983 (callint.o): Depend on character.h.
10984
10985 * eval.c (internal_lisp_condition_case): Include the handler
10986 representation in the error message.
10987 (verror): Call doprnt instead of vsnprintf. Fix an off-by-one bug
10988 when breaking from the loop.
10989
10990 * xdisp.c (vmessage): Call doprnt instead of vsnprintf.
10991
10992 * callint.c (Fcall_interactively): When displaying error message
10993 about invalid control letter, pass the character's codepoint, not
10994 a pointer to its multibyte form. Improve display of the character
10995 in octal and display also its hex code.
10996
10997 * character.c (char_string): Use %x to display the (unsigned)
10998 codepoint of an invalid character, to avoid displaying a bogus
10999 negative value.
11000
11001 * font.c (check_otf_features): Pass SDATA of SYMBOL_NAME to
11002 `error', not SYMBOL_NAME itself.
11003
11004 * coding.c (Fencode_sjis_char, Fencode_big5_char): Use %c for
11005 character arguments to `error'.
11006
11007 * charset.c (check_iso_charset_parameter): Fix incorrect argument
11008 to `error' in error message about FINAL_CHAR argument. Make sure
11009 FINAL_CHAR is a character, and use %c when it is passed as
11010 argument to `error'.
11011
4ffd0d6b 110122011-04-23 Eli Zaretskii <eliz@gnu.org>
97a93095
EZ
11013
11014 * s/ms-w32.h (localtime): Redirect to sys_localtime.
11015
11016 * w32.c: Include <time.h>.
11017 (sys_localtime): New function.
11018
4ffd0d6b 110192011-04-23 Chong Yidong <cyd@stupidchicken.com>
c17819f4
CY
11020
11021 * xdisp.c (init_xdisp): Initialize echo_area_window (Bug#6451).
11022
4ffd0d6b 11023 * buffer.c (syms_of_buffer): Doc fix (Bug#6902).
aac0c6e3 11024
4ffd0d6b 110252011-04-23 Samuel Thibault <sthibault@debian.org> (tiny change)
aac0c6e3 11026
4ffd0d6b
GM
11027 * sysdep.c (wait_for_termination): On GNU Hurd, kill returns -1 on
11028 zombies (Bug#8467).
aac0c6e3 11029
04c56954
EZ
110302011-04-19 Eli Zaretskii <eliz@gnu.org>
11031
11032 * syntax.h (SETUP_SYNTAX_TABLE_FOR_OBJECT): Fix setting of
11033 gl_state.e_property when gl_state.object is Qt.
11034
11035 * insdel.c (make_gap_larger): Remove limitation of buffer size
11036 to <= INT_MAX.
11037
16a43933
CY
110382011-04-18 Chong Yidong <cyd@stupidchicken.com>
11039
11040 * xdisp.c (lookup_glyphless_char_display)
11041 (produce_glyphless_glyph): Handle cons cell entry in
11042 glyphless-char-display.
11043 (Vglyphless_char_display): Document it.
11044
11045 * term.c (produce_glyphless_glyph): Handle cons cell entry in
11046 glyphless-char-display.
11047
4581706e
CY
110482011-04-17 Chong Yidong <cyd@stupidchicken.com>
11049
11050 * xdisp.c (get_next_display_element): Remove unnecessary ifdefs.
11051
11052 * termhooks.h (FRAME_WINDOW_P): Remove duplicated definitions.
11053
11054 * dispextern.h (FACE_SUITABLE_FOR_ASCII_CHAR_P): Add missing
11055 definition for no-X builds.
11056
4887c6e2 110572011-04-16 Paul Eggert <eggert@cs.ucla.edu>
764430a3 11058
fd35b6f9
PE
11059 Static checks with GCC 4.6.0 and non-default toolkits.
11060
5c1ccb01
PE
11061 * s/sol2-6.h, s/unixware.h (PTY_TTY_NAME_SPRINTF): Protoize decl.
11062
006c5daa
PE
11063 * process.c (keyboard_bit_set): Define only if SIGIO.
11064 (send_process_trap): Mark it with NO_RETURN if it doesn't return.
11065 (send_process): Repair possible setjmp clobbering.
11066
efc736d3
PE
11067 * s/usg5-4-common.h (SETUP_SLAVE_PTY): Don't pass extra arg to 'fatal'.
11068
4e2fe2e6
PE
11069 * eval.c: Include <stdio.h>, for vsnprintf on non-GNU/Linux hosts.
11070
f97334a2
PE
11071 * data.c (arith_error): Mark with NO_RETURN if it doesn't return.
11072
4e75f29d
PE
11073 * alloc.c (bytes_used_when_full, SPARE_MEMORY, BYTES_USED):
11074 Define only if needed.
11075
90efadd1
PE
11076 * sysdep.c (_FILE_OFFSET_BITS): Make this hack even uglier
11077 by pacifying GCC about it. Maybe it's time to retire it?
875975e9 11078 * xfaces.c (USG, __TIMEVAL__): Likewise.
90efadd1 11079
3c647824
PE
11080 * dispextern.h (struct redisplay_interface): Rename param
11081 to avoid shadowing.
e264f262 11082 * termhooks.h (struct terminal): Likewise.
761383f4 11083 * xterm.c (xembed_send_message): Likewise.
3c647824 11084
b58c5c4a
PE
11085 * insdel.c (make_gap_smaller): Define only if
11086 USE_MMAP_FOR_BUFFERS || REL_ALLOC || DOUG_LEA_MALLOC.
11087
cad59032
PE
11088 * keyboard.c (read_char): Make a var volatile so longjmp won't clobber
11089 it.
11090
c339dc2e
PE
11091 * emacs.c (MAX_HEAP_BSS_DIFF, my_edata): Move to where they're used,
11092 so that we aren't warned about unused symbols.
11093
91a3e27b
PE
11094 * xfns.c (Fx_file_dialog): Rename local to avoid shadowing.
11095
399c71d3 11096 * xdisp.c (x_produce_glyphs): Mark var as initialized (Bug#8512).
7a3fb125 11097
8ffc96f5
PE
11098 * xfns.c (x_real_positions): Mark locals as initialized.
11099
eef9bc79
PE
11100 * xmenu.c (xmenu_show): Don't use uninitialized vars.
11101
098db9dd
PE
11102 * xterm.c: Fix problems found by static analysis with other toolkits.
11103 (toolkit_scroll_bar_interaction): Define and use only if USE_X_TOOLKIT.
dda3aedd
PE
11104 (x_dispatch_event): Declare static if USE_GTK, and
11105 define if USE_GTK || USE_X_TOOLKIT.
098db9dd 11106 (SET_SAVED_BUTTON_EVENT): Define only if USE_X_TOOLKIT || USE_GTK.
dda3aedd 11107 * xterm.h (x_dispatch_event): Extern only if USE_X_TOOLKIT.
841a1577
JB
11108 * xterm.c, xterm.h (x_mouse_leave): Bring this function back, but only
11109 if defined HAVE_MENUS && !defined USE_X_TOOLKIT && !defined USE_GTK.
098db9dd 11110
eb18f6cc
PE
11111 * xmenu.c (menu_help_callback): Pointer type fixes.
11112 Use const pointers when pointing at readonly data. Avoid pointer
11113 signedness clashes.
11114 (FALSE): Remove unused macro.
11115 (update_frame_menubar): Remove unused decl.
11116
1fe72bf8
PE
11117 * xfns.c (Fx_hide_tip): Move locals to avoid shadowing.
11118
60d9e1db
PE
11119 * menu.c (push_submenu_start, push_submenu_end): Do not define unless
11120 USE_X_TOOLKIT || USE_GTK || HAVE_NS || defined HAVE_NTGUI.
11121 (single_menu_item): Rename local to avoid shadowing.
11122
39261c26
PE
11123 * keyboard.c (make_lispy_event): Remove unused local var.
11124
018c5e19
PE
11125 * frame.c, frame.h (x_get_resource_string): Bring this back, but
11126 only if HAVE_X_WINDOWS && !USE_X_TOOLKIT.
11127
63d2b86e
PE
11128 * bitmaps: Change bitmaps from unsigned char back to the X11
11129 compatible char. Avoid the old compiler warnings about
11130 out-of-range initializers by using, for example, '\xab' rather
11131 than 0xab.
11132
aefd87e1
PE
11133 * xgselect.c (xgselect_initialize): Check vs interface
11134 even if ! (defined (USE_GTK) || defined (HAVE_GCONF)).
11135
bf501fb9
PE
11136 * xmenu.c (xmenu_show): Rename parm to avoid shadowing.
11137
e9829fdf
PE
11138 * xterm.c (x_create_toolkit_scroll_bar): Use const * for pointers
11139 to read-only memory.
11140
1086c095
PE
11141 * fns.c (vector): Remove; this old hack is no longer needed.
11142
2baccd04 11143 * xsmfns.c (create_client_leader_window): Rename shadowing arg.
401f10cb 11144 Remove unused var.
dde42981 11145 (gdk_x11_set_sm_client_id) [!USE_GTK]: Don't define.
2baccd04 11146
72391843 11147 * xrdb.c (x_load_resources): Omit unused local.
3565b346 11148
436c16df 11149 * xfns.c (free_frame_menubar, atof): Remove duplicate decls.
8a94ea33 11150 (x_window): Rename locals to avoid shadowing.
dc5ddd85 11151 (USG): Use the kludged USG macro, to pacify gcc.
436c16df 11152
92bb796d 11153 * xterm.c (x_alloc_nearest_color_for_widget): Remove; unused.
bbbef9e1 11154 (x_term_init): Remove local to avoid shadowing.
92bb796d 11155
764430a3 11156 * xfns.c, xterm.c (_XEditResCheckMessages): Protoize decl.
4887c6e2
PE
11157
11158 * xdisp.c, dispextern.h (set_vertical_scroll_bar): Now extern if
11159 USE_TOOLKIT_SCROLL_BARS && !USE_GTK, as xterm.c needs it then.
11160
d1dfb56c
EZ
111612011-04-16 Eli Zaretskii <eliz@gnu.org>
11162
c4354cb4
EZ
11163 * gnutls.c (Fgnutls_boot): Don't pass Lisp_Object to `error'.
11164
d1dfb56c
EZ
11165 Fix regex.c, syntax.c and friends for buffers > 2GB.
11166 * syntax.h (struct gl_state_s): Declare character position members
11167 EMACS_INT.
11168
11169 * syntax.c (update_syntax_table): Declare 2nd argument EMACS_INT.
11170
04f2d78b
CB
11171 * textprop.c (verify_interval_modification, interval_of):
11172 Declare arguments EMACS_INT.
d1dfb56c
EZ
11173
11174 * intervals.c (adjust_intervals_for_insertion): Declare arguments
11175 EMACS_INT.
11176
11177 * intervals.h (CHECK_TOTAL_LENGTH): Cast to EMACS_INT, not `int'.
11178
11179 * indent.c (Fvertical_motion): Local variable it_start is now
11180 EMACS_INT.
11181
11182 * regex.c (re_match, re_match_2, re_match_2_internal)
11183 (bcmp_translate, regcomp, regexec, print_double_string)
11184 (group_in_compile_stack, re_search, re_search_2, regex_compile)
11185 (re_compile_pattern, re_exec): Declare arguments and local
11186 variables `size_t' and `ssize_t' and return values `regoff_t', as
11187 appropriate.
11188 (POP_FAILURE_REG_OR_COUNT) <pfreg>: Declare `long'.
11189 (CHECK_INFINITE_LOOP) <failure>: Declare `ssize_t'.
11190 <compile_stack_type>: `size' and `avail' are now `size_t'.
11191
11192 * regex.h <regoff_t>: Use ssize_t, not int.
11193 (re_search, re_search_2, re_match, re_match_2): Arguments that
11194 specify buffer/string position and length are now ssize_t and
11195 size_t. Return type is regoff_t.
11196
613052cd
BK
111972011-04-16 Ben Key <bkey76@gmail.com>
11198
11199 * nsfont.m: Fixed bugs in ns_get_family and
11200 ns_descriptor_to_entity that were caused by using free to
11201 deallocate memory blocks that were allocated by xmalloc (via
11202 xstrdup). This caused Emacs to crash when compiled with
11203 XMALLOC_OVERRUN_CHECK defined (when Emacs was configured with
11204 --enable-checking=xmallocoverrun). xfree is now used to
11205 deallocate these memory blocks.
11206
4170f62f 112072011-04-15 Paul Eggert <eggert@cs.ucla.edu>
3e047f51 11208
71b41406
PE
11209 * sysdep.c (emacs_read): Remove unnecessary check vs MAX_RW_COUNT.
11210
9587a89d
PE
11211 emacs_write: Accept and return EMACS_INT for sizes.
11212 See http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00514.html
11213 et seq.
11214 * gnutls.c, gnutls.h (emacs_gnutls_read, emacs_gnutls_write):
11215 Accept and return EMACS_INT.
11216 (emacs_gnutls_write): Return the number of bytes written on
11217 partial writes.
11218 * sysdep.c, lisp.h (emacs_read, emacs_write): Likewise.
273a5f82
PE
11219 (emacs_read, emacs_write): Remove check for negative size, as the
11220 Emacs source code has been audited now.
9587a89d
PE
11221 * sysdep.c (MAX_RW_COUNT): New macro, to work around kernel bugs.
11222 (emacs_read, emacs_write): Use it.
273a5f82
PE
11223 * process.c (send_process): Adjust to the new signatures of
11224 emacs_write and emacs_gnutls_write. Do not attempt to store
11225 a byte offset into an 'int'; it might overflow.
9587a89d 11226 See http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00483.html
273a5f82 11227
3e047f51
PE
11228 * sound.c: Don't assume sizes fit in 'int'.
11229 (struct sound_device.period_size, alsa_period_size):
9c3c56a7 11230 Return EMACS_INT, not int.
3e047f51 11231 (struct sound_device.write, vox_write, alsa_write):
9c3c56a7
PE
11232 Accept EMACS_INT, not int.
11233 (wav_play, au_play): Use EMACS_INT to store sizes and to
3e047f51
PE
11234 record read return values.
11235
cc39a9db
BK
112362011-04-15 Ben Key <bkey76@gmail.com>
11237
c9d0ec6d
JB
11238 * keyboard.c (Qundefined): Don't declare static since it is used
11239 in nsfns.m.
11240 * xfaces.c (Qbold, Qexpanded, Qitalic, Qcondensed): Don't declare
11241 static since they are used in nsfont.m.
cc39a9db 11242
6c60eb9f
SM
112432011-04-15 Stefan Monnier <monnier@iro.umontreal.ca>
11244
11245 * process.c (Qprocessp): Don't declare static.
11246 * lisp.h (Qprocessp): Declare again.
11247
7990b61a
JB
112482011-04-15 Juanma Barranquero <lekktu@gmail.com>
11249
11250 * font.c (Qopentype): Don't make static (used from w32uniscribe.c).
11251
5d4cb038
PE
112522011-04-14 Paul Eggert <eggert@cs.ucla.edu>
11253
8bd7b830 11254 Improve C-level modularity by making more things 'static'.
cd64ea1d 11255
e3b27b31
PE
11256 Don't publish debugger-only interfaces to other modules.
11257 * lisp.h (safe_debug_print, debug_output_compilation_hack):
11258 (verify_bytepos, count_markers): Move decls to the only modules
11259 that need them.
11260 * region-cache.h (pp_cache): Likewise.
11261 * window.h (check_all_windows): Likewise.
11262 * marker.c, print.c, region-cache.c, window.c: Decls moved here.
11263
5d4cb038
PE
11264 * sysdep.c (croak): Now static, if
11265 defined TIOCNOTTY || defined USG5 || defined CYGWIN.
11266 * syssignal.h (croak): Declare only if not static.
69003fd8
PE
11267
11268 * alloc.c (refill_memory_reserve): Now static if
11269 !defined REL_ALLOC || defined SYSTEM_MALLOC.
11270 * lisp.h (refill_memory_reserve): Declare only if not static.
93ea6e8f 11271
e87b6180
PE
11272 * xsettings.c, xsettings.h (xsettings_get_system_normal_font):
11273 Define only if USE_LUCID.
11274
ac64929e
PE
11275 * xrdb.c (x_customization_string, x_rm_string): Now static.
11276
6f37259d
PE
11277 * xmenu.c (x_menu_wait_for_event): Export only if USE_MOTIF.
11278 * xterm.h (x_menu_wait_for_event): Declare only if USE_MOTIF.
11279
1683e3ab
PE
11280 * xdisp.c (draw_row_with_mouse_face): Now static.
11281 * dispextern.h (draw_row_with_mouse_fave): Remove decl.
11282
de9c2632
PE
11283 * window.h (check_all_windows): Mark externally visible.
11284
2b96acb7
PE
11285 * window.c (window_deletion_count): Now static.
11286
11287 * undo.c: Make symbols static if they're not exported.
11288 (last_undo_buffer, last_boundary_position, pending_boundary):
11289 Now static.
11290
50436f33
PE
11291 * textprop.c (interval_insert_behind_hooks): Now static.
11292 (interval_insert_in_front_hooks): Likewise.
11293
64520e5c
PE
11294 * term.c: Make symbols static if they're not exported.
11295 (tty_turn_off_highlight, get_tty_terminal, max_frame_cols):
11296 (max_frame_lines, tty_set_terminal_modes):
11297 (tty_reset_terminal_modes, tty_turn_off_highlight):
11298 (get_tty_terminal): Now static.
11299 (term_mouse_moveto): Do not define if HAVE_WINDOW_SYSTEM.
11300 * termhooks.h (term_mouse_moveto): Do not declare if
8bd7b830 11301 HAVE_WINDOW_SYSTEM.
64520e5c
PE
11302 * dispextern.h (tty_set_terminal_modes, tty_reset_terminal_modes):
11303 (tty_turn_off_highlight, get_tty_terminal): Remove decls.
11304
1fa53021
PE
11305 * sysdep.c: Make symbols static if they're not exported.
11306 (emacs_get_tty, emacs_set_tty, old_fcntl_flags, old_fcntl_owner):
11307 Now static.
11308 (sigprocmask_set, full_mask): Remove; unused.
11309 (wait_debugging): Mark as visible.
11310 * syssignal.h (SIGFULLMASK, full_mask): Remove decls.
11311 * systty.h (emacs_get_tty, emacs_set_tty): Remove decls.
11312
d4b43b22
PE
11313 * syntax.c (syntax_temp): Define only if !__GNUC__.
11314
b7c513d0
PE
11315 * sound.c (current_sound_device, current_sound): Now static.
11316
989b29ad
PE
11317 * search.c (searchbufs, searchbuf_head): Now static.
11318
13a55a78
PE
11319 * scroll.c (scroll_cost): Remove; unused.
11320 * dispextern.h (scroll_cost): Remove decl.
11321
de68a1fc
PE
11322 * region-cache.h (pp_cache): Mark as externally visible.
11323
40ccffa6
PE
11324 * process.c: Make symbols static if they're not exported.
11325 (process_tick, update_tick, create_process, chan_process):
11326 (Vprocess_alist, proc_buffered_char, datagram_access):
11327 (fd_callback_data, send_process_frame, process_sent_to): Now static.
11328 (deactivate_process): Mark defn as static, as well as decl.
11329 * lisp.h (create_process): Remove decl.
11330 * process.h (chan_process, Vprocess_alist): Remove decls.
11331
ad64fc97
PE
11332 * print.c: Make symbols static if they're not exported.
11333 (print_depth, new_backquote_output, being_printed, print_buffer):
11334 (print_buffer_size, print_buffer_pos, print_buffer_pos_byte):
11335 (print_interval, print_number_index, initial_stderr_stream):
11336 Now static.
11337 * lisp.h (Fprinc): Remove decl.
11338 (debug_output_compilation_hack): Mark as externally visible.
11339
adddb265
PE
11340 * sysdep.c (croak): Move decl from here to syssignal.h.
11341 * syssignal.h (croak): Put it here, so the API can be checked when
11342 'croak' is called from dissociate_if_controlling_tty.
11343
1717ede2
PE
11344 * minibuf.c: Make symbols static if they're not exported.
11345 (minibuf_save_list, choose_minibuf_frame): Now static.
11346 * lisp.h (choose_minibuf_frame): Remove decl.
11347
fa5fb2bc
PE
11348 * lisp.h (verify_bytepos, count_markers): Mark as externally visible.
11349
1e3890d1
PE
11350 * lread.c: Make symbols static if they're not exported.
11351 (read_objects, initial_obarray, oblookup_last_bucket_number):
11352 Now static.
11353 (make_symbol): Remove; unused.
11354 * lisp.h (initial_obarray, make_symbol): Remove decls.
11355
8a1414fa
PE
11356 * keyboard.c: Make symbols static if they're not exported.
11357 (single_kboard, recent_keys_index, total_keys, recent_keys):
11358 (this_command_key_count_reset, raw_keybuf, raw_keybuf_count):
11359 (this_single_command_key_start, echoing, last_auto_save):
11360 (read_key_sequence_cmd, dribble, recursive_edit_unwind):
11361 (command_loop, echo_now, keyboard_init_hook, help_char_p):
11362 (quit_throw_to_read_char, command_loop_2, top_level_1, poll_timer):
11363 (Vlispy_mouse_stem, double_click_count):
11364 Now static.
11365 (force_auto_save_soon): Define only if SIGDANGER.
11366 (ignore_mouse_drag_p): Now static if
11367 !defined HAVE_WINDOW_SYSTEM || defined USE_GTK || defined HAVE_NS.
11368 (print_help): Remove; unused.
11369 (stop_character, last_timer_event): Mark as externally visible.
11370 * keyboard.h (ignore_mouse_drag_p): Declare only if
11371 defined HAVE_WINDOW_SYSTEM && !defined USE_GTK && !defined HAVE_NS.
11372 (echo_now, help_char_p, quit_throw_to_read_char): Remove decls.
11373 * lisp.h (echoing): Remove decl.
11374 (force_auto_save_soon): Declare only if SIGDANGER.
11375 * xdisp.c (redisplay_window): Simplify code, to make it more
11376 obvious that ignore_mouse_drag_p is not accessed if !defined
11377 USE_GTK && !defined HAVE_NS.
11378
93ea6e8f
PE
11379 * intervals.c: Make symbols static if they're not exported.
11380 (merge_properties_sticky, merge_interval_right, delete_interval):
11381 Now static.
11382 * intervals.h (merge_interval_right, delete_interval): Remove decls.
11383
77382fcc
PE
11384 * insdel.c: Make symbols static if they're not exported.
11385 However, leave prepare_to_modify_buffer alone. It's never
11386 called from outside this function, but that appears to be a bug.
11387 (combine_after_change_list, combine_after_change_buffer):
4889fc82 11388 (adjust_after_replace, signal_before_change): Now static.
77382fcc
PE
11389 (adjust_after_replace_noundo): Remove; unused.
11390 * lisp.h (adjust_after_replace, adjust_after_replace_noundo):
4889fc82 11391 (signal_before_change): Remove decls.
77382fcc 11392
9306c32e
PE
11393 * indent.c (val_compute_motion, val_vmotion): Now static.
11394
cd44d2eb
PE
11395 * image.c: Make symbols static if they're not exported.
11396 * dispextern.h (x_create_bitmap_from_xpm_data): Do not declare
11397 if USE_GTK.
11398 * image.c (x_create_bitmap_from_xpm_data): Do not define if USE_GTK.
11399 (xpm_color_cache, ct_table, ct_colors_allocated): Now static.
11400
ad9a7a06
PE
11401 * fringe.c (standard_bitmaps): Now static.
11402 (max_used_fringe_bitmap): Now static, unless HAVE_NS.
11403
81626931
PE
11404 * frame.c: Make symbols static if they're not exported.
11405 (x_report_frame_params, make_terminal_frame): Now static.
11406 (get_frame_param): Now static, unless HAVE_NS.
11407 (x_fullscreen_adjust): Define if WINDOWSNT, not if HAVE_WINDOW_SYSTEM.
11408 (x_get_resource_string): Remove; not used.
11409 * frame.h (make_terminal_frame, x_report_frame_params):
11410 (x_get_resource_string); Remove decls.
11411 (x_fullscreen_adjust): Declare only if WINDOWSNT.
11412 * lisp.h (get_frame_param): Declare only if HAVE_NS.
11413
239f9db9
PE
11414 * font.c, fontset.c: Make symbols static if they're not exported.
11415 * dispextern.h (FACE_SUITABLE_FOR_ASCII_CHAR_P): New macro.
11416 (FACE_SUITABLE_FOR_CHAR_P): Use it.
11417 * font.c (font_close_object): Now static.
11418 * font.h (font_close_object): Remove.
11419 * fontset.c (FONTSET_OBJLIST): Remove.
11420 (free_realized_fontset) #if-0 the body, which does nothing.
11421 (face_suitable_for_char_p): #if-0, as it's never called.
11422 * fontset.h (face_suitable_for_char_p): Remove decl.
04f2d78b
CB
11423 * xfaces.c (face_at_string_position):
11424 Use FACE_SUITABLE_FOR_ASCII_CHAR_P, not FACE_SUITABLE_FOR_CHAR_P,
239f9db9
PE
11425 since 0 is always ASCII.
11426
dfcf3579
PE
11427 * fns.c (weak_hash_tables): Now static.
11428
5045092b
PE
11429 * fileio.c: Make symbols static if they're not exported.
11430 (auto_saving, auto_save_mode_bits, auto_save_error_occurred):
11431 (Vwrite_region_annotation_buffers): Now static.
11432
57a96f5c
PE
11433 * eval.c: Make symbols static if they're not exported.
11434 (backtrace_list, lisp_eval_depth, when_entered_debugger): Now static.
11435 * lisp.h (backtrace_list): Remove decl.
11436
35f08c38
PE
11437 * emacs.c: Make symbols static if they're not exported.
11438 (malloc_state_ptr, malloc_using_checking, syms_of_emacs):
11439 (fatal_error_code, fatal_error_signal_hook, standard_args):
11440 Now static.
11441 (fatal_error_signal): Now static, unless FLOAT_CATCH_SIGKILL.
11442 (DEFINE_DUMMY_FUNCTION): Mark function as externally visible.
11443 (__CTOR_LIST__, __DTOR_LIST__): Now externally visible.
11444 * lisp.h (fatal_error_signal_hook): Remove decl.
11445 (fatal_error_signal): Declare only if FLOAT_CATCH_SIGKILL.
11446
f44bd759
PE
11447 * editfns.c: Move a (normally-unused) function to its only use.
11448 * editfns.c, lisp.h (get_operating_system_release): Remove.
11449 * process.c (init_process) [DARWIN_OS]: Do it inline, as it is not
11450 worth the hassle of breaking this out.
11451
b532497d
PE
11452 * xterm.c: Make symbols static if they're not exported.
11453 (x_raise_frame, x_lower_frame, x_wm_set_window_state):
11454 (x_wm_set_icon_pixmap, x_initialize, XTread_socket_fake_io_error):
11455 (x_destroy_window, x_delete_display):
11456 Now static.
11457 (x_dispatch_event): Now static if ! (USE_MOTIF || USE_X_TOOLKIT).
11458 (x_mouse_leave): Remove; unused.
11459 * xterm.h (x_display_info_for_name, x_raise_frame, x_lower_frame):
11460 (x_destroy_window, x_wm_set_window_state, x_wm_set_icon_pixmap):
11461 (x_delete_display, x_initialize, x_set_border_pixel, x_screen_planes):
11462 Remove decls.
11463 (x_mouse_leave): Declare only if WINDOWSNT.
11464 (x_dispatch_event): Declare only if USE_MOTIF or USE_X_TOOLKIT.
11465 (xic_create_fontsetname): Declare only if HAVE_X_WINDOWS &&
11466 USE_X_TOOLKIT.
11467
1675728f
PE
11468 * ftxfont.c: Make symbols static if they're not exported.
11469 (ftxfont_driver): Export only if !defined HAVE_XFT && def8ined
11470 HAVE_FREETYPE.
11471 * font.h (ftxfont_driver): Likewise.
11472
e4cebfca
PE
11473 * xfns.c: Make symbols static if they're not exported.
11474 (x_last_font_name, x_display_info_for_name):
11475 (x_set_foreground_color, x_set_background_color, x_set_mouse_color):
11476 (x_set_cursor_color, x_set_border_pixel, x_set_border_color):
11477 (x_set_cursor_type, x_set_icon_type, x_set_icon_name):
11478 (x_set_scroll_bar_foreground, x_set_scroll_bar_background):
11479 (x_explicitly_set_name, x_set_title, xic_defaut_fontset, tip_timer):
11480 (last_show_tip_args): Now static.
11481 (xic_defaut_fontset, xic_create_fontsetname): Define only if
11482 defined HAVE_X_WINDOWS && defined USE_X_TOOLKIT
11483 (x_screen_planes): Remove; unused.
11484 * dispextern.h (x_screen_planes): Remove decl.
11485
5bf46f05
PE
11486 * dispnew.c: Make symbols static if they're not exported.
11487 * dispextern.h (redraw_garbaged_frames, scrolling):
11488 (increment_row_positions): Remove.
11489 * dispnew.c (new_glyph_matrix, increment_row_positions, scrolling):
11490 (delayed_size_change, glyph_matrix_count, glyph_pool_count):
11491 Now static.
11492 (redraw_garbaged_frames): Remove; unused.
11493
435f4c28
PE
11494 * xfaces.c: Make symbols static if they're not exported.
11495 * dispextern.h (ascii_face_of_lisp_face, free_realized_face):
11496 Remove decls.
11497 * xterm.h (defined_color): Remove decls.
11498 (x_free_dpy_colors): Declare only if USE_X_TOOLKIT.
11499 * xfaces.c (tty_suppress_bold_inverse_default_colors_p):
11500 (menu_face_changed_default, defined_color, free_realized_face):
11501 (x_free_dpy_colors): Define only if USE_X_TOOLKIT.
11502 (ascii_face_of_lisp_face): Remove; unused.
11503
8524aef3
PE
11504 * xdisp.c: Make symbols static if they're not exported.
11505 * dispextern.h (scratch_glyph_row, window_box_edges):
11506 (glyph_to_pixel_coords, set_cursor_from_row):
11507 (get_next_display_element, set_iterator_to_next):
11508 (highlight_trailing_whitespace, frame_to_window_pixel_xy):
11509 (show_mouse_face): Remove decls
11510 * frame.h (message_buf_print): Likewise.
11511 * lisp.h (pop_message, set_message, check_point_in_composition):
11512 Likewise.
11513 * xterm.h (set_vertical_scroll_bar): Likewise.
11514 * xdisp.c (list_of_error, Vmessage_stack, line_number_displayed):
11515 (message_buf_print, scratch_glyph_row, displayed_buffer):
11516 (set_iterator_to_next, pop_message, set_message, set_cursor_from_row):
11517 (get_next_display_element, show_mouse_face, window_box_edges):
11518 (frame_to_window_pixel_xy, check_point_in_composition):
11519 (set_vertical_scroll_bar, highlight_trailing_whitespace): Now static.
11520 (glyph_to_pixel_coords): Remove; unused.
11521
16390cd2
PE
11522 * dired.c (file_name_completion): Now static.
11523
11524 * dbusbind.c (xd_in_read_queued_messages): Now static.
11525
a25f4dfa
PE
11526 * lisp.h (circular_list_error, FOREACH): Remove; unused.
11527 * data.c (circular_list_error): Remove.
11528
14a9c8df
PE
11529 * commands.h (last_point_position, last_point_position_buffer):
11530 (last_point_position_window): Remove decls.
11531 * keyboard.c: Make these variables static.
11532
04f2d78b
CB
11533 * coding.h (coding, code_convert_region, encode_coding_gap):
11534 Remove decls.
74ab6df5
PE
11535 * coding.c (Vsjis_coding_system, Vbig5_coding_system):
11536 (iso_code_class, detect_coding, code_convert_region): Now static.
11537 (encode_coding_gap): Remove; unused.
11538
38dfbee1
PE
11539 * chartab.c (chartab_chars, chartab_bits): Now static.
11540
a2cb4e63
PE
11541 * charset.h (charset_iso_8859_1): Remove decl.
11542 * charset.c (charset_iso_8859_1, charset_emacs, map_charset_for_dump):
11543 Now static.
11544
127198fd
PE
11545 * ccl.h (check_ccl_update, Vccl_program_table): Remove decls.
11546 * ccl.c (Vccl_program_table): Now static.
11547 (check_ccl_update): Remove; unused.
11548
d85b608f
PE
11549 * category.c (SET_CATEGORY_SET, set_category_set): Move here.
11550 * category.h: ... from here.
11551 * category.c (check_category_table, set_category_set): Now static.
11552
31cd66f3
PE
11553 * casetab.c (Vascii_upcase_table, Vascii_eqv_table): Now static.
11554 * lisp.h: Remove these decls.
11555
c358e587
PE
11556 * buffer.c (buffer_count): Remove unused var.
11557
e78aecca
PE
11558 * bidi.c (bidi_dump_cached_states): Mark as externally visible,
11559 so that it's not optimized away.
11560 (bidi_ignore_explicit_marks_for_paragraph_level): Likewise.
11561 * dispextern.h (bidi_dump_cached_states): Remove, since it's
11562 exported only to the debugger.
11563
e192d7d3 11564 * atimer.c (alarm_signal_handler, run_all_atimers): Now static.
04f2d78b 11565 * atimer.h (run_all_atimers): Remove; not exported.
e192d7d3 11566
92470028
PE
11567 font.c: Make copy_font_spec and merge_font_spec ordinary C functions.
11568 * font.c (copy_font_spec): Rename from Fcopy_font_spec, since it
11569 was inaccessible from Lisp.
11570 (merge_font_spec): Likewise, renaming from Fmerge_font_spec.
11571 * font.c, font.h, fontset.c, xfaces.c, xfont.c: Change all uses.
11572
244ed907
PE
11573 alloc.c: Import and export fewer symbols, and remove unused items.
11574 * lisp.h (suppress_checking, die): Declare only if ENABLE_CHECKING
11575 is defined.
11576 (suppress_checking): Add EXTERNALLY_VISIBLE attribute, so that
11577 it's not optimized away by whole-program optimization.
11578 (message_enable_multibyte, free_misc): Remove.
11579 (catchlist, handlerlist, mark_backtrace):
11580 Declare only if BYTE_MARK_STACK.
11581 (mark_byte_stack): Likewise, fixing a ifdef-vs-if typo.
11582 * alloc.c (pure): Export only if VIRT_ADDR_VARIES is defined.
11583 (message_enable_multibyte): Remove decl.
11584 (free_misc, interval_free_list, float_block, float_block_index):
11585 (n_float_blocks, float_free_list, cons_block, cons_block_index):
11586 (cons_free_list, last_marked_index):
11587 Now static.
11588 (suppress_checking, die): Define only if ENABLE_CHECKING is defined.
11589 * eval.c (catchlist, handlerlist): Export only if BYTE_MARK_STACK.
11590 (mark_backtrace): Define only if BYTE_MARK_STACK.
11591 * xdisp.c (message_enable_multibyte): Now static.
11592
61c2b50e 11593 Declare Lisp_Object Q* variables to be 'static' if not exported.
955cbe7b
PE
11594 This makes it easier for human readers (and static analyzers)
11595 to see whether these variables are used from other modules.
11596 * alloc.c, buffer.c, bytecode.c, callint.c, casetab.c, category.c:
11597 * ccl.c, character.c, charset.c, cmds.c, coding.c, composite.c:
11598 * data.c, dbusbind.c, dired.c, editfns.c, eval.c, fileio.c, fns.c:
11599 * font.c, frame.c, fringe.c, ftfont.c, image.c, keyboard.c, keymap.c:
11600 * lread.c, macros.c, minibuf.c, print.c, process.c, search.c:
11601 * sound.c, syntax.c, textprop.c, window.c, xdisp.c, xfaces.c, xfns.c:
11602 * xmenu.c, xselect.c:
11603 Declare Q* vars static if they are not used in other modules.
11604 * ccl.h, character.h, charset.h, coding.h, composite.h, font.h:
11605 * frame.h, intervals.h, keyboard.h, lisp.h, process.h, syntax.h:
11606 Remove decls of unexported vars.
11607 * keyboard.h (EVENT_HEAD_UNMODIFIED): Remove now-unused macro.
11608
95c82688
PE
11609 * lisp.h (DEFINE_FUNC): Make sname 'static'.
11610
16a97296
PE
11611 Make Emacs functions such as Fatom 'static' by default.
11612 This makes it easier for human readers (and static analyzers)
11613 to see whether these functions can be called from other modules.
11614 DEFUN now defines a static function. To make the function external
11615 so that it can be used in other C modules, use the new macro DEFUE.
8bd7b830
PE
11616 * lisp.h (Funibyte_char_to_multibyte, Fsyntax_table_p):
11617 (Finit_image_library):
16a97296
PE
11618 (Feval_region, Fbacktrace, Ffetch_bytecode, Fswitch_to_buffer):
11619 (Ffile_executable_p, Fmake_symbolic_link, Fcommand_execute):
11620 (Fget_process, Fdocumentation_property, Fbyte_code, Ffile_attributes):
11621 Remove decls, since these functions are now static.
11622 (Funintern, Fget_internal_run_time): New decls, since these functions
11623 were already external.
95c82688 11624
16a97296
PE
11625 * alloc.c, buffer.c, callint.c, callproc.c, casefiddle.c, casetab.c:
11626 * ccl.c, character.c, chartab.c, cmds.c, coding.c, data.c, dispnew.c:
11627 * doc.c, editfns.c, emacs.c, eval.c, fileio.c, filelock.c, floatfns.c:
11628 * fns.c, font.c, fontset.c, frame.c, image.c, indent.c:
11629 * keyboard.c, keymap.c, lread.c:
11630 * macros.c, marker.c, menu.c, minibuf.c, print.c, process.c, search.c:
11631 * syntax.c, term.c, terminal.c, textprop.c, undo.c:
11632 * window.c, xdisp.c, xfaces.c, xfns.c, xmenu.c, xsettings.c:
11633 Mark functions with DEFUE instead of DEFUN,
11634 if they are used in other modules.
11635 * buffer.c (Fset_buffer_major_mode, Fdelete_overlay): New forward
11636 decls for now-static functions.
11637 * buffer.h (Fdelete_overlay): Remove decl.
11638 * callproc.c (Fgetenv_internal): Mark as internal.
11639 * composite.c (Fremove_list_of_text_properties): Remove decl.
11640 (Fcomposition_get_gstring): New forward static decl.
11641 * composite.h (Fcomposite_get_gstring): Remove decl.
11642 * dired.c (Ffile_attributes): New forward static decl.
11643 * doc.c (Fdocumntation_property): New forward static decl.
11644 * eval.c (Ffetch_bytecode): New forward static decl.
11645 (Funintern): Remove extern decl; now in .h file where it belongs.
11646 * fileio.c (Fmake_symbolic_link): New forward static decl.
11647 * image.c (Finit_image_library): New forward static decl.
11648 * insdel.c (Fcombine_after_change_execute): Make forward decl static.
11649 * intervals.h (Fprevious_property_change):
11650 (Fremove_list_of_text_properties): Remove decls.
11651 * keyboard.c (Fthis_command_keys): Remove decl.
11652 (Fcommand_execute): New forward static decl.
11653 * keymap.c (Flookup_key): New forward static decl.
11654 (Fcopy_keymap): Now static.
11655 * keymap.h (Flookup_key): Remove decl.
11656 * process.c (Fget_process): New forward static decl.
11657 (Fprocess_datagram_address): Mark as internal.
11658 * syntax.c (Fsyntax_table_p): New forward static decl.
11659 (skip_chars): Remove duplicate decl.
11660 * textprop.c (Fprevious_property_change): New forward static decl.
11661 * window.c (Fset_window_fringes, Fset_window_scroll_bars):
11662 Now internal.
11663 (Fset_window_margins, Fset_window_vscroll): New forward static decls.
11664 * window.h (Fset_window_vscroll, Fset_window_margins): Remove decls.
11665
785bbd42
PE
11666 * editfns.c (Fformat): Remove unreachable code.
11667
8b913b57
AS
116682011-04-14 Andreas Schwab <schwab@linux-m68k.org>
11669
11670 * fileio.c (Finsert_file_contents): Fix typo in 2005-05-13
11671 change. (Bug#8496)
11672
a6744a35
EZ
116732011-04-13 Eli Zaretskii <eliz@gnu.org>
11674
11675 * xdisp.c (handle_invisible_prop): Don't call bidi_paragraph_init
11676 when at ZV. (Bug#8487)
11677
e7974947
AS
116782011-04-12 Andreas Schwab <schwab@linux-m68k.org>
11679
baad03f0
AS
11680 * charset.c (Fclear_charset_maps): Use xfree instead of free.
11681 (Bug#8437)
11682 * keyboard.c (parse_tool_bar_item): Likewise.
11683 * sound.c (sound_cleanup, alsa_close): Likewise.
11684 * termcap.c (tgetent): Likewise.
11685 * xfns.c (x_default_font_parameter): Likewise.
11686 * xsettings.c (read_and_apply_settings): Likewise.
11687
e7974947
AS
11688 * alloc.c (overrun_check_malloc, overrun_check_realloc)
11689 (overrun_check_free): Protoize.
11690
28272684
PE
116912011-04-12 Paul Eggert <eggert@cs.ucla.edu>
11692
11693 * sysdep.c (emacs_read, emacs_write): Check for negative sizes
11694 since callers should never pass a negative size.
11695 Change the signature to match that of plain 'read' and 'write'; see
11696 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00397.html>.
11697 * lisp.h: Update prototypes of emacs_write and emacs_read.
11698
11997c76
EZ
116992011-04-11 Eli Zaretskii <eliz@gnu.org>
11700
11701 * xdisp.c (redisplay_window): Don't try to determine the character
11702 position of the scroll margin if the window start point w->startp
e896f03c 11703 is outside the buffer's accessible region. (Bug#8468)
11997c76 11704
8a2cbd72
EZ
117052011-04-10 Eli Zaretskii <eliz@gnu.org>
11706
11707 Fix write-region and its subroutines for buffers > 2GB.
11708 * fileio.c (a_write, e_write): Modify declaration of arguments and
11709 local variables to support buffers larger than 2GB.
11710 (Fcopy_file): Use EMACS_INT for return value of emacs_read.
11711
11712 * sysdep.c (emacs_write, emacs_read): Use ssize_t for last
11713 argument, local variables, and return value.
11714
11715 * lisp.h: Update prototypes of emacs_write and emacs_read.
11716
11717 * sound.c (vox_write): Use ssize_t for return value of emacs_write.
11718
4073e537 117192011-04-10 Paul Eggert <eggert@cs.ucla.edu>
eb3f1cc8 11720
1ebfdcb6
PE
11721 * xdisp.c (vmessage): Use memchr, not strnlen, which some hosts lack.
11722
b2ded58d
PE
11723 Fix more problems found by GCC 4.6.0's static checks.
11724
7d66342c
PE
11725 * xdisp.c (vmessage): Use a better test for character truncation.
11726
bbf47d44
PE
11727 * charset.c (load_charset_map): <, not <=, for optimization,
11728 and to avoid potential problems with integer overflow.
9248994d 11729 * chartab.c (sub_char_table_set_range, char_table_set_range): Likewise.
f9a68bc5 11730 * casetab.c (set_identity, shuffle): Likewise.
3ab1c7ce 11731 * editfns.c (Fformat): Likewise.
1e69125e 11732 * syntax.c (skip_chars): Likewise.
3befa583 11733
e3019616
PE
11734 * xmenu.c (set_frame_menubar): Allocate smaller local vectors.
11735 This also lets GCC 4.6.0 generate slightly better loop code.
11736
becfa255
PE
11737 * callint.c (Fcall_interactively): <, not <=, for optimization.
11738 (Fcall_interactively): Count the number of arguments produced,
11739 not the number of arguments given. This is simpler and lets GCC
11740 4.6.0 generate slightly better code.
11741
dae0cd48
PE
11742 * ftfont.c: Distingish more carefully between FcChar8 and char.
11743 The previous code passed unsigned char * to a functions like
11744 strlen and xstrcasecmp that expect char *, which does not
11745 conform to the C standard.
11746 (get_adstyle_property, ftfont_pattern_entity): Use FcChar8 for
11747 arguments to FcPatternGetString, and explicitly cast FcChar8 * to
11748 char * when the C standard requires it.
11749
76032d70
PE
11750 * keyboard.c (read_char): Remove unused var.
11751
eb3f1cc8
PE
11752 * eval.c: Port to Windows vsnprintf (Bug#8435).
11753 Include <limits.h>.
11754 (SIZE_MAX): Define if the headers do not.
11755 (verror): Do not give up if vsnprintf returns a negative count.
11756 Instead, grow the buffer. This ports to Windows vsnprintf, which
11757 does not conform to C99. Problem reported by Eli Zaretskii.
11758 Also, simplify the allocation scheme, by avoiding the need for
11759 calling realloc, and removing the ALLOCATED variable.
11760
70476b54
PE
11761 * eval.c (verror): Initial buffer size is 4000 (not 200) bytes.
11762
12020a9e
PE
11763 Remove invocations of doprnt, as Emacs now uses vsnprintf.
11764 But keep the doprint source code for now, as we might revamp it
11765 and use it again (Bug#8435).
ea6c7ae6
PE
11766 * lisp.h (doprnt): Remove.
11767 * Makefile.in (base_obj): Remove doprnt.o.
11768 * deps.mk (doprnt.o): Remove.
11769
5fdb398c
PE
11770 error: Print 32- and 64-bit integers portably (Bug#8435).
11771 Without this change, on typical 64-bit hosts error ("...%d...", N)
11772 was used to print both 32- and 64-bit integers N, which relied on
11773 undefined behavior.
61bdb816 11774 * lisp.h, m/amdx86-64.h, m/ia64.h, m/ibms390x.h (pEd): New macro.
5fdb398c
PE
11775 * lisp.h (error, verror): Mark as printf-like functions.
11776 * eval.c (verror): Use vsnprintf, not doprnt, to do the real work.
11777 Report overflow in size calculations when allocating printf buffer.
11778 Do not truncate output string at its first null byte.
11779 * xdisp.c (vmessage): Use vsnprintf, not doprnt, to do the real work.
11780 Truncate the output at a character boundary, since vsnprintf does not
11781 do that.
11782 * charset.c (check_iso_charset_parameter): Convert internal
11783 character to string before calling 'error', since %c now has the
11784 printf meaning.
11785 * coding.c (Fdecode_sjis_char, Fdecode_big5_char): Avoid int
11786 overflow when computing char to be passed to 'error'. Do not
11787 pass Lisp_Object to 'error'; pass the integer instead.
11788 * nsfns.m (Fns_do_applescript): Use int, not long, since it's
11789 formatted with plain %d.
11790
b189fa66
PE
11791 * eval.c (internal_lisp_condition_case): Don't pass spurious arg.
11792
bff87ef0
PE
11793 * keyboard.c (access_keymap_keyremap): Print func name, not garbage.
11794
7e2cac20
PE
11795 * coding.c (Fdecode_sjis_char): Don't assume CODE fits in int.
11796
ce4d90b5
PE
11797 * xterm.c (x_catch_errors): Remove duplicate declaration.
11798
266c9547
PE
11799 * term.c (maybe_fatal): Mark its 3rd arg as a printf format, too.
11800
79c49ad2
PE
11801 * xdisp.c, lisp.h (message_nolog): Remove; unused.
11802
368f4090
JM
118032011-04-10 Jim Meyering <meyering@redhat.com>
11804
11805 use ssize_t and size_t for read- and write-like emacs_gnutls_* functions
11806 * gnutls.c (emacs_gnutls_read): Adjust signature to be more read-like:
11807 return ssize_t not "int", and use size_t as the buffer length.
11808 (emacs_gnutls_write): Likewise, and make the buffer pointer "const".
11809 * gnutls.h: Update declarations.
11810 * process.c (read_process_output): Use ssize_t, to match.
11811 (send_process): Likewise.
11812
a32d4040
CY
118132011-04-09 Chong Yidong <cyd@stupidchicken.com>
11814
11815 * image.c (Fimagemagick_types): Doc fix, and comment cleanup.
11816
8546720e 118172011-04-09 Chong Yidong <cyd@stupidchicken.com>
aac0c6e3 11818
04f2d78b
CB
11819 * ftfont.c (get_adstyle_property, ftfont_pattern_entity):
11820 Use unsigned char, to match FcChar8 type definition.
aac0c6e3 11821
8546720e
GM
11822 * xterm.c (handle_one_xevent):
11823 * xmenu.c (create_and_show_popup_menu):
11824 * xselect.c (x_decline_selection_request)
11825 (x_reply_selection_request): Avoid type-punned deref of X events.
aac0c6e3 11826
0a2f5c1a 118272011-04-09 Eli Zaretskii <eliz@gnu.org>
a53e2e89
EZ
11828
11829 Fix some uses of `int' instead of EMACS_INT.
11830 * search.c (string_match_1, fast_string_match)
11831 (fast_c_string_match_ignore_case, fast_string_match_ignore_case)
11832 (scan_buffer, find_next_newline_no_quit)
11833 (find_before_next_newline, search_command, Freplace_match)
11834 (Fmatch_data): Make some `int' variables be EMACS_INT.
11835
11836 * xdisp.c (display_count_lines): 3rd argument and return value now
11837 EMACS_INT. All callers changed.
11838 (pint2hrstr): Last argument is now EMACS_INT.
11839
11840 * coding.c (detect_coding_utf_8, detect_coding_emacs_mule)
11841 (detect_coding_iso_2022, detect_coding_sjis, detect_coding_big5)
11842 (detect_coding_ccl, detect_coding_charset, decode_coding_utf_8)
11843 (decode_coding_utf_16, decode_coding_emacs_mule)
11844 (decode_coding_iso_2022, decode_coding_sjis, decode_coding_big5)
11845 (decode_coding_ccl, decode_coding_charset)
11846 <consumed_chars, consumed_chars_base>: Declare EMACS_INT.
11847 (decode_coding_iso_2022, decode_coding_emacs_mule)
11848 (decode_coding_sjis, decode_coding_big5, decode_coding_charset)
11849 <char_offset, last_offset>: Declare EMACS_INT.
11850 (encode_coding_utf_8, encode_coding_utf_16)
11851 (encode_coding_emacs_mule, encode_invocation_designation)
11852 (encode_designation_at_bol, encode_coding_iso_2022)
11853 (encode_coding_sjis, encode_coding_big5, encode_coding_ccl)
11854 (encode_coding_raw_text, encode_coding_charset) <produced_chars>:
11855 Declare EMACS_INT.
11856 (ASSURE_DESTINATION): Declare more_bytes EMACS_INT.
11857 (encode_invocation_designation): Last argument P_NCHARS is now
11858 EMACS_INT.
11859 (decode_eol): Declare pos_byte, pos, and pos_end EMACS_INT.
11860 (produce_chars): from_nchars and to_nchars are now EMACS_INT.
11861
11862 * coding.h (struct coding_system) <head_ascii>: Declare EMACS_INT.
11863 All users changed.
11864
11865 * ccl.c (Fccl_execute_on_string): Declare some variables
11866 EMACS_INT.
11867
8546720e 118682011-04-08 Samuel Thibault <sthibault@debian.org> (tiny change)
0080dc6b
SS
11869
11870 * term.c (init_tty): Fix incorrect ifdef placement (Bug#8450).
11871
4e19a977
CS
118722011-03-19 Christoph Scholtes <cschol2112@googlemail.com>
11873
11874 * process.c (Fformat_network_address): Doc fix.
11875
87302331
R
118762011-04-08 T.V. Raman <tv.raman.tv@gmail.com> (tiny change)
11877
ee7683eb 11878 * xml.c (parse_region): Avoid creating spurious whitespace nodes.
87302331 11879
cbb59342
CY
118802011-04-08 Chong Yidong <cyd@stupidchicken.com>
11881
11882 * keyboard.c (read_char): Call Lisp function help-form-show,
11883 instead of using internal_with_output_to_temp_buffer.
11884 (Qhelp_form_show): New var.
e0d38eeb 11885 (syms_of_keyboard): Use DEFSYM macro.
cbb59342
CY
11886
11887 * print.c (internal_with_output_to_temp_buffer): Function deleted.
11888
11889 * lisp.h (internal_with_output_to_temp_buffer): Remove prototype.
11890
e67a13ab
CY
118912011-04-06 Chong Yidong <cyd@stupidchicken.com>
11892
04f2d78b
CB
11893 * process.c (Flist_processes): Remove to Lisp.
11894 (list_processes_1): Delete.
e67a13ab 11895
973f782d
EZ
118962011-04-06 Eli Zaretskii <eliz@gnu.org>
11897
7c106b1e
EZ
11898 * msdos.c (careadlinkat, careadlinkatcwd): MS-DOS replacements.
11899
973f782d
EZ
11900 * w32.c (careadlinkat, careadlinkatcwd): New always-fail stubs.
11901
41cf7d1a 119022011-04-06 Paul Eggert <eggert@cs.ucla.edu>
27ccc379 11903
ca23cc88
PE
11904 Fix more problems found by GCC 4.6.0's static checks.
11905
f390e2d5
PE
11906 * xmenu.c (Fx_popup_dialog): Don't assume string is free of formats.
11907
42eea0d0
PE
11908 * menu.c (Fx_popup_menu): Don't assume error_name lacks printf formats.
11909
b69769da 11910 * lisp.h (message, message_nolog, fatal): Mark as printf-like.
1e973bc7 11911
f9541e84
PE
11912 * xdisp.c (vmessage): Mark as a printf-like function.
11913
13841b55
PE
11914 * term.c (vfatal, maybe_fatal): Mark as printf-like functions.
11915
c136c10f
PE
11916 * sound.c (sound_warning): Don't crash if arg contains a printf format.
11917
5e2d4a30
PE
11918 * image.c (tiff_error_handler, tiff_warning_handler): Mark as
11919 printf-like functions.
11920 (tiff_load): Add casts to remove these marks before passing them
11921 to system-supplied API.
11922
583f48b9
PE
11923 * eval.c (Fsignal): Remove excess argument to 'fatal'.
11924
b25d760e
PE
11925 * coding.c (EMIT_ONE_BYTE, EMIT_TWO_BYTES): Use unsigned, not int.
11926 This avoids several warnings with gcc -Wstrict-overflow.
d5efd1d1
PE
11927 (DECODE_COMPOSITION_RULE): If the rule is invalid, goto invalid_code
11928 directly, rather than having caller test rule sign. This avoids
11929 some unnecessary tests.
11930 * composite.h (COMPOSITION_ENCODE_RULE_VALID): New macro.
11931 (COMPOSITION_ENCODE_RULE): Arguments now must be valid. This
11932 affects only one use, in DECODE_COMPOSITION_RULE, which is changed.
b25d760e 11933
bc7b6697 11934 * xfont.c (xfont_text_extents): Remove var that was set but not used.
625a3eb1 11935 (xfont_open): Avoid unnecessary tests.
bc7b6697 11936
27ccc379
PE
11937 * composite.c (composition_gstring_put_cache): Use unsigned integer.
11938
dcd5c89a
PE
11939 * composite.h, composite.c (composition_gstring_put_cache):
11940 Use EMACS_INT, not int, for length.
11941
b13a45c6
PE
11942 * composite.h (COMPOSITION_DECODE_REFS): New macro,
11943 breaking out part of COMPOSITION_DECODE_RULE.
11944 (COMPOSITION_DECODE_RULE): Use it.
11945 * composite.c (get_composition_id): Remove unused local vars,
11946 by using the new macro.
11947
1e792e4d
PE
11948 * textprop.c (set_text_properties_1): Change while to do-while,
11949 since the condition is always true at first.
11950
dc6c6455 11951 * intervals.c (graft_intervals_into_buffer): Mark var as used.
aa86731f
PE
11952 (interval_deletion_adjustment): Return unsigned value.
11953 All uses changed.
dc6c6455 11954
aba7731a
PE
11955 * process.c (list_processes_1, create_pty, read_process_output):
11956 (exec_sentinel): Remove vars that were set but not used.
afd4052b 11957 (create_pty): Remove unnecessary "volatile"s.
bc57d757 11958 (Fnetwork_interface_info): Avoid possibility of int overflow.
82eaa333 11959 (read_process_output): Do adaptive read buffering even if carryover.
fe07cdfa 11960 (read_process_output): Simplify nbytes computation if buffered.
aba7731a 11961
fdfc4bf3
PE
11962 * bytecode.c (exec_byte_code): Rename local to avoid shadowing.
11963
fca8fe46 11964 * syntax.c (scan_words): Remove var that was set but not used.
12cbf13f 11965 (update_syntax_table): Use unsigned instead of int.
fca8fe46 11966
06a0259a 11967 * lread.c (lisp_file_lexically_bound_p): Use ints rather than endptrs.
3c346cc3 11968 (lisp_file_lexically_bound_p, read1): Use unsigned instead of int.
e6eb4e9e 11969 (safe_to_load_p): Make the end-of-loop test the inverse of the in-loop.
06a0259a 11970
e7b9e80f
PE
11971 * print.c (print_error_message): Avoid int overflow.
11972
56201685
PE
11973 * font.c (font_list_entities): Redo for clarity,
11974 so that reader need not know FONT_DPI_INDEX + 1 == FONT_SPACING_INDEX.
11975
78834453 11976 * font.c (font_find_for_lface, Ffont_get_glyphs): Remove unused vars.
790771b1 11977 (font_score): Avoid potential overflow in diff calculation.
78834453 11978
0bc0b309 11979 * fns.c (substring_both): Remove var that is set but not used.
8cd55cb4 11980 (sxhash): Redo loop for clarity and to avoid wraparound warning.
0bc0b309 11981
e610eaca
PE
11982 * eval.c (funcall_lambda): Rename local to avoid shadowing.
11983
b895abce
PE
11984 * alloc.c (mark_object_loop_halt, mark_object): Use size_t, not int.
11985 Otherwise, GCC 4.6.0 optimizes the loop check away since the check
11986 can always succeed if overflow has undefined behavior.
11987
1f1d9321 11988 * search.c (boyer_moore, wordify): Remove vars set but not used.
6f076cc7 11989 (wordify): Omit three unnecessary tests.
1f1d9321 11990
c59478bc
PE
11991 * indent.c (MULTIBYTE_BYTES_WIDTH): Don't compute wide_column.
11992 All callers changed. This avoids the need for an unused var.
11993
79b73827
PE
11994 * casefiddle.c (casify_region): Remove var that is set but not used.
11995
a4db5dfe
PE
11996 * dired.c (file_name_completion): Remove var that is set but not used.
11997
43aae36e
PE
11998 * fileio.c (Finsert_file_contents): Make EOF condition clearer.
11999
2a47c44d 12000 * fileio.c (Finsert_file_contents): Avoid signed integer overflow.
163c5f32 12001 (Finsert_file_contents): Remove unnecessary code checking fd.
2a47c44d 12002
a37c69bf
PE
12003 * minibuf.c (read_minibuf_noninteractive): Use size_t for sizes.
12004 Check for integer overflow on size calculations.
12005
328ab8e7
PE
12006 * buffer.c (Fprevious_overlay_change): Remove var that is set
12007 but not used.
12008
e5a2a5cb
PE
12009 * keyboard.c (menu_bar_items, read_char_minibuf_menu_prompt):
12010 Remove vars that are set but not used.
8d84a6eb 12011 (timer_check_2): Don't assume timer-list and idle-timer-list are lists.
6b043475 12012 (timer_check_2): Mark vars as initialized.
e5a2a5cb 12013
a60e5f68
PE
12014 * gtkutil.c (xg_get_file_with_chooser): Mark var as initialized.
12015
f661cb61 12016 * image.c (lookup_image): Remove var that is set but not used.
35fa624f 12017 (xbm_load): Use parse_p, for gcc -Werror=unused-but-set-variable.
f661cb61 12018
f0397f5a
PE
12019 * fontset.c (Finternal_char_font, Ffontset_info): Remove vars
12020 that are set but not used.
12021
8664db06 12022 * xfns.c (make_invisible_cursor): Don't return garbage
03733ee7 12023 if XCreateBitmapFromData fails (Bug#8410).
8664db06 12024
6abdaa4a
PE
12025 * xselect.c (x_get_local_selection, x_handle_property_notify):
12026 Remove vars that are set but not used.
12027
0ce7538d 12028 * xfns.c (x_create_tip_frame): Remove var that is set but not used.
6abdaa4a 12029 (make_invisible_cursor): Initialize a possibly-uninitialized variable.
0ce7538d 12030
9ae848fc
PE
12031 * xterm.c (x_scroll_bar_to_input_event) [!USE_GTK]:
12032 Remove var that is set but not used.
0b918413
PE
12033 (scroll_bar_windows_size): Now size_t, not int.
12034 (x_send_scroll_bar_event): Use size_t, not int, for sizes.
12035 Check for overflow.
9ae848fc 12036
a5a62657
PE
12037 * xfaces.c (realize_named_face): Remove vars that are set but not used.
12038 (map_tty_color) [!defined MSDOS]: Likewise.
12039
5c5cdd39
PE
12040 * term.c (tty_write_glyphs): Use size_t; this avoids overflow warning.
12041
66ebf983
PE
12042 * coding.c: Remove vars that are set but not used.
12043 (DECODE_COMPOSITION_RULE): Remove 2nd arg, which is unused.
12044 All callers changed.
12045 (decode_coding_utf_8, decode_coding_utf_16 decode_coding_emacs_mule):
12046 (decode_coding_iso_2022, encode_coding_sjis, encode_coding_big5):
12047 (decode_coding_charset): Remove vars that are set but not used.
12048
1be4d761
PE
12049 * bytecode.c (Fbyte_code) [!defined BYTE_CODE_SAFE]: Remove var
12050 that is set but not used.
12051
47553fa8
PE
12052 * print.c (print_object): Remove var that is set but not used.
12053
1f7196bf 12054 Replace 2 copies of readlink code with 1 gnulib version (Bug#8401).
d1fdcab7
PE
12055 The gnulib version avoids calling malloc in the usual case,
12056 and on 64-bit hosts doesn't have some arbitrary 32-bit limits.
12057 * fileio.c (Ffile_symlink_p): Use emacs_readlink.
12058 * filelock.c (current_lock_owner): Likewise.
12059 * lisp.h (READLINK_BUFSIZE, emacs_readlink): New function.
12060 * sysdep.c: Include allocator.h, careadlinkat.h.
12061 (emacs_no_realloc_allocator): New static constant.
12062 (emacs_readlink): New function.
fdb61804
PE
12063 * deps.mk (sysdep.o): Depend on ../lib/allocator.h and on
12064 ../lib/careadlinkat.h.
d1fdcab7 12065
f84c17c7
SM
120662011-04-04 Stefan Monnier <monnier@iro.umontreal.ca>
12067
12068 * keyboard.c (safe_run_hook_funcall): Fix last change (don't stop at the
12069 first non-nil return value).
12070
ef3862ad
JD
120712011-04-03 Jan Djärv <jan.h.d@swipnet.se>
12072
12073 * nsterm.m (ns_update_auto_hide_menu_bar): Define MAC_OS_X_VERSION_10_6
12074 if not defined (Bug#8403).
12075
376a7006
JB
120762011-04-02 Juanma Barranquero <lekktu@gmail.com>
12077
12078 * xdisp.c (display_count_lines): Remove parameter `start',
12079 unused since 1998-01-01T02:27:27Z!rms@gnu.org. All callers changed.
12080 (get_char_face_and_encoding): Remove parameter `multibyte_p',
12081 unused since 2008-05-14T01:40:23Z!handa@m17n.org. All callers changed.
12082 (fill_stretch_glyph_string): Remove parameters `row' and `area',
12083 unused at least since Kim's GUI unification at 2003-03-16T20:45:46Z!storm@cua.dk
12084 and thereabouts. All callers changed.
12085 (get_per_char_metric): Remove parameter `f', unused since
12086 2008-05-14T01:40:23Z!handa@m17n.org. All callers changed.
12087
6ca3801d
JM
120882011-04-02 Jim Meyering <meyering@redhat.com>
12089
12090 do not dereference NULL upon failed strdup
12091 * nsfont.m (ns_descriptor_to_entity): Use xstrdup, not strdup.
12092 (ns_get_family): Likewise.
12093
d8e2b5ba
JB
120942011-04-02 Juanma Barranquero <lekktu@gmail.com>
12095
12096 * eval.c (unwind_to_catch) [DEBUG_GCPRO]: Remove redundant assignment.
12097
8c74fcbd
JD
120982011-04-02 Jan Djärv <jan.h.d@swipnet.se>
12099
12100 * nsterm.m (ns_update_auto_hide_menu_bar): Only for OSX 10.6 or
12101 later (Bug#8403).
12102
7200d79c
SM
121032011-04-01 Stefan Monnier <monnier@iro.umontreal.ca>
12104
03408648 12105 Add lexical binding.
7200d79c 12106
03408648
SM
12107 * window.c (Ftemp_output_buffer_show): New fun.
12108 (Fsave_window_excursion):
12109 * print.c (Fwith_output_to_temp_buffer): Move to subr.el.
12110
12111 * lread.c (lisp_file_lexically_bound_p): New function.
12112 (Fload): Bind Qlexical_binding.
12113 (readevalloop): Remove `evalfun' arg.
12114 Bind Qinternal_interpreter_environment.
12115 (Feval_buffer): Bind Qlexical_binding.
12116 (defvar_int, defvar_bool, defvar_lisp_nopro, defvar_kboard):
12117 Mark as dynamic.
12118 (syms_of_lread): Declare `lexical-binding'.
12119
12120 * lisp.h (struct Lisp_Symbol): New field `declared_special'.
12121
12122 * keyboard.c (eval_dyn): New fun.
12123 (menu_item_eval_property): Use it.
ca105506
SM
12124
12125 * image.c (parse_image_spec): Use Ffunctionp.
ca105506 12126
03408648
SM
12127 * fns.c (concat, mapcar1): Accept byte-code-functions.
12128
12129 * eval.c (Fsetq): Handle lexical vars.
12130 (Fdefun, Fdefmacro, Ffunction): Make closures when needed.
12131 (Fdefconst, Fdefvaralias, Fdefvar): Mark as dynamic.
12132 (FletX, Flet): Obey lexical binding.
12133 (Fcommandp): Handle closures.
12134 (Feval): New `lexical' arg.
12135 (eval_sub): New function extracted from Feval. Use it almost
12136 everywhere where Feval was used. Look up vars in lexical env.
12137 Handle closures.
12138 (Ffunctionp): Move from subr.el.
12139 (Ffuncall): Handle closures.
12140 (apply_lambda): Remove `eval_flags'.
12141 (funcall_lambda): Handle closures and new byte-code-functions.
12142 (Fspecial_variable_p): New function.
12143 (syms_of_eval): Initialize the Vinternal_interpreter_environment var,
12144 but without exporting it to Lisp.
23aba0ea 12145
23aba0ea 12146 * doc.c (Fdocumentation, store_function_docstring):
03408648 12147 * data.c (Finteractive_form): Handle closures.
23aba0ea 12148
03408648
SM
12149 * callint.c (Fcall_interactively): Preserve lexical-binding mode for
12150 interactive spec.
ba83908c 12151
04f2d78b
CB
12152 * bytecode.c (Bstack_ref, Bstack_set, Bstack_set2, BdiscardN):
12153 New byte-codes.
03408648
SM
12154 (exec_byte_code): New function extracted from Fbyte_code to handle new
12155 calling convention for byte-code-functions. Add new byte-codes.
ba83908c 12156
03408648 12157 * buffer.c (defvar_per_buffer): Set new `declared_special' field.
e2abe5a1 12158
03408648 12159 * alloc.c (Fmake_symbol): Init new `declared_special' field.
e2abe5a1 12160
e2abce01
JB
121612011-03-31 Juanma Barranquero <lekktu@gmail.com>
12162
12163 * xdisp.c (redisplay_internal): Fix prototype.
12164
63696a73 121652011-03-31 Eli Zaretskii <eliz@gnu.org>
09725d26 12166
63696a73 12167 * xdisp.c (SCROLL_LIMIT): New macro.
04f2d78b
CB
12168 (try_scrolling): Use it when setting scroll_limit.
12169 Limit scrolling to 100 screen lines.
63696a73
EZ
12170 (redisplay_window): Even when falling back on "recentering",
12171 position point in the window according to scroll-conservatively,
12172 scroll-margin, and scroll-*-aggressively variables. (Bug#6671)
12173
12174 (try_scrolling): When point is above the window, allow searching
12175 as far as scroll_max, or one screenful, to compute vertical
12176 distance from PT to the scroll margin position. This prevents
12177 try_scrolling from unnecessarily failing when
12178 scroll-conservatively is set to a value slightly larger than the
12179 window height. Clean up the case of PT below the margin at bottom
12180 of window: scroll_max can no longer be INT_MAX. When aggressive
12181 scrolling is in use, don't let point enter the opposite scroll
12182 margin as result of the scroll.
12183 (syms_of_xdisp) <scroll-conservatively>: Document the
09725d26
EZ
12184 threshold of 100 lines for never-recentering scrolling.
12185
e4cc2dfc
JB
121862011-03-31 Juanma Barranquero <lekktu@gmail.com>
12187
12188 * dispextern.h (move_it_by_lines):
12189 * xdisp.c (move_it_by_lines): Remove parameter `need_y_p', unused
12190 since 2000-12-29T14:24:09Z!gerd@gnu.org. All callers changed.
12191 (message_log_check_duplicate): Remove parameters `prev_bol' and
12192 `this_bol', unused since 1998-01-01T02:27:27Z!rms@gnu.org. All callers changed.
12193 (redisplay_internal): Remove parameter `preserve_echo_area',
12194 unused since 1999-07-21T21:43:52Z!gerd@gnu.org. All callers changed.
12195
12196 * indent.c (Fvertical_motion):
12197 * window.c (window_scroll_pixel_based, Frecenter):
12198 Don't pass `need_y_p' to `move_it_by_lines'.
12199
1c470562
SM
122002011-03-30 Stefan Monnier <monnier@iro.umontreal.ca>
12201
44f230aa
SM
12202 * eval.c (struct backtrace): Don't cheat with negative numbers, but do
12203 steal a few bits to be more compact.
12204 (interactive_p, Fbacktrace, Fbacktrace_frame, mark_backtrace):
12205 Remove unneeded casts.
12206
1c470562
SM
12207 * bytecode.c (Fbyte_code): CAR and CDR can GC.
12208
888adce9
ZK
122092011-03-30 Zachary Kanfer <zkanfer@gmail.com> (tiny change)
12210
12211 * keyboard.c (Fexecute_extended_command): Do log the "suggest key
12212 binding" message (bug#7967).
12213
f838ed7b
PE
122142011-03-30 Paul Eggert <eggert@cs.ucla.edu>
12215
77861b95
PE
12216 Fix more problems found by GCC 4.6.0's static checks.
12217
de6dbc14
PE
12218 * unexelf.c (unexec) [! (defined _SYSTYPE_SYSV || defined __sgi)]:
12219 Remove unused local var.
12220
f838ed7b
PE
12221 * editfns.c (Fmessage_box): Remove unused local var.
12222
792c7b2b
PE
12223 * xdisp.c (try_window_reusing_current_matrix, x_produce_glyphs):
12224 (note_mode_line_or_margin_highlight, note_mouse_highlight):
12225 Omit unused local vars.
c499e557 12226 * window.c (shrink_windows): Omit unused local var.
b01a1c29 12227 * menu.c (digest_single_submenu): Omit unused local var.
0bc32927
PE
12228 * dispnew.c (update_window) [PERIODIC_PREEMPTION_CHECKING]:
12229 Omit unused local var.
12230
ba0165e1
PE
12231 * keyboard.c (parse_modifiers_uncached, parse_modifiers):
12232 Don't assume string length fits in int.
32ad8845 12233 (keyremap_step, read_key_sequence): Use size_t for sizes.
48011560 12234 (read_key_sequence): Don't check last_real_key_start redundantly.
ba0165e1 12235
3c59b4c9
PE
12236 * callproc.c (Fcall_process, Fcall_process_region): Use SAFE_ALLOCA
12237 instead of alloca (Bug#8344).
12238
a3eed478 12239 * eval.c (Fbacktrace): Don't assume nargs fits in int.
5d5d959d 12240 (Fbacktrace_frame): Don't assume nframes fits in int.
a3eed478 12241
eb4d412d
PE
12242 * syntax.c (scan_sexps_forward): Avoid pointer wraparound.
12243
1658b401
PE
12244 * xterm.c (x_make_frame_visible, same_x_server): Redo to avoid overflow
12245 concerns.
12246
12247 * term.c (produce_glyphless_glyph): Remove unnecessary test.
12248
12249 * cm.c (calccost): Turn while-do into do-while, for clarity.
44f730c8 12250
9a2c6e05
PE
12251 * keyboard.c (syms_of_keyboard): Use the same style as later
12252 in this function when indexing through an array. This also
12253 works around GCC bug 48267.
12254
03d0a109
PE
12255 * image.c (tiff_load): Fix off-by-one image count (Bug#8336).
12256
44f730c8
PE
12257 * xselect.c (x_check_property_data): Return correct size (Bug#8335).
12258
fe75f926
PE
12259 * chartab.c (sub_char_table_ref_and_range): Redo for slight
12260 efficiency gain, and to bypass a gcc -Wstrict-overflow warning.
12261
ffa8c828
PE
12262 * keyboard.c, keyboard.h (num_input_events): Now size_t.
12263 This avoids undefined behavior on integer overflow, and is a bit
12264 more convenient anyway since it is compared to a size_t variable.
12265
c5101a77
PE
12266 Variadic C functions now count arguments with size_t, not int.
12267 This avoids an unnecessary limitation on 64-bit machines, which
12268 caused (substring ...) to crash on large vectors (Bug#8344).
12269 * lisp.h (struct Lisp_Subr.function.aMANY): Now takes size_t, not int.
12270 (DEFUN_ARGS_MANY, internal_condition_case_n, safe_call): Likewise.
77861b95 12271 All variadic functions and their callers changed accordingly.
c5101a77
PE
12272 (struct gcpro.nvars): Now size_t, not int. All uses changed.
12273 * data.c (arith_driver, float_arith_driver): Likewise.
12274 * editfns.c (general_insert_function): Likewise.
12275 * eval.c (struct backtrace.nargs, interactive_p)
12276 (internal_condition_case_n, run_hook_with_args, apply_lambda)
12277 (funcall_lambda, mark_backtrace): Likewise.
12278 * fns.c (concat): Likewise.
12279 * frame.c (x_set_frame_parameters): Likewise.
12280 * fns.c (get_key_arg): Now accepts and returns size_t, and returns
12281 0 if not found, not -1. All callers changed.
12282
dd3f25f7
PE
12283 * alloc.c (garbage_collect): Don't assume stack size fits in int.
12284 (stack_copy_size): Now size_t, not int.
12285 (stack_copy, stack_copy_size): Define only if MAX_SAVE_STACK > 0.
12286
461c2ab9
JB
122872011-03-28 Juanma Barranquero <lekktu@gmail.com>
12288
12289 * coding.c (encode_designation_at_bol): Remove parameter `charbuf_end',
12290 unused since 2002-03-01T01:17:24Z!handa@m17n.org and 2008-02-01T16:01:31Z!miles@gnu.org.
12291 All callers changed.
12292
12293 * lisp.h (multibyte_char_to_unibyte):
12294 * character.c (multibyte_char_to_unibyte): Remove parameter `rev_tbl',
12295 unused since 2002-03-01T01:16:34Z!handa@m17n.org and 2008-02-01T16:01:31Z!miles@gnu.org.
12296 * character.h (CHAR_TO_BYTE8):
12297 * cmds.c (internal_self_insert):
12298 * editfns.c (general_insert_function):
12299 * keymap.c (push_key_description):
12300 * search.c (Freplace_match):
12301 * xdisp.c (message_dolog, set_message_1): All callers changed.
12302
f6d62986
SM
123032011-03-28 Stefan Monnier <monnier@iro.umontreal.ca>
12304
12305 * keyboard.c (safe_run_hook_funcall): New function.
12306 (safe_run_hooks_1, safe_run_hooks_error, safe_run_hooks): On error,
12307 don't set the hook to nil, but remove the offending function instead.
12308 (Qcommand_hook_internal): Remove, unused.
12309 (syms_of_keyboard): Don't initialize Qcommand_hook_internal nor define
12310 Vcommand_hook_internal.
12311
12312 * eval.c (enum run_hooks_condition): Remove.
12313 (funcall_nil, funcall_not): New functions.
12314 (run_hook_with_args): Call each function through a `funcall' argument.
12315 Remove `cond' argument, now redundant.
12316 (Frun_hooks, Frun_hook_with_args, Frun_hook_with_args_until_success)
12317 (Frun_hook_with_args_until_failure): Adjust accordingly.
12318 (run_hook_wrapped_funcall, Frun_hook_wrapped): New functions.
12319
1db5b1ad
JB
123202011-03-28 Juanma Barranquero <lekktu@gmail.com>
12321
12322 * dispextern.h (string_buffer_position): Remove declaration.
12323
12324 * print.c (strout): Remove parameter `multibyte', unused since
12325 1999-08-21T19:30:21Z!gerd@gnu.org. All callers changed.
12326
12327 * search.c (boyer_moore): Remove parameters `len', `pos' and `lim',
12328 never used since function introduction in 1998-02-08T21:33:56Z!rms@gnu.org.
12329 All callers changed.
12330
12331 * w32.c (_wsa_errlist): Use braces for struct initializers.
12332
12333 * xdisp.c (string_buffer_position_lim): Remove parameter `w',
12334 never used since function introduction in 2001-03-09T18:41:50Z!gerd@gnu.org.
12335 All callers changed.
12336 (string_buffer_position): Likewise. Also, make static (it's never
12337 used outside xdisp.c).
12338 (cursor_row_p): Remove parameter `w', unused since
12339 2000-10-17T16:08:57Z!gerd@gnu.org. All callers changed.
12340 (decode_mode_spec): Remove parameter `precision', introduced during
12341 Gerd Moellmann's rewrite at 1999-07-21T21:43:52Z!gerd@gnu.org, but never used.
12342 All callers changed.
12343
5ffb62aa
JD
123442011-03-27 Jan Djärv <jan.h.d@swipnet.se>
12345
12346 * nsterm.m (syms_of_nsterm): Use doc: for ns-auto-hide-menu-bar.
12347
461c2ab9 123482011-03-27 Anders Lindgren <andlind@gmail.com>
f0a1382a
JD
12349
12350 * nsterm.m (ns_menu_bar_is_hidden): New variable.
12351 (ns_constrain_all_frames, ns_menu_bar_should_be_hidden)
12352 (ns_update_auto_hide_menu_bar): New functions.
12353 (ns_update_begin): Call ns_update_auto_hide_menu_bar.
12354 (applicationDidBecomeActive): Call ns_update_auto_hide_menu_bar and
12355 ns_constrain_all_frames.
12356 (constrainFrameRect): Return at once if ns_menu_bar_should_be_hidden.
12357 (syms_of_nsterm): DEFVAR ns-auto-hide-menu-bar, init to Qnil.
12358
5c380ffb
JD
123592011-03-27 Jan Djärv <jan.h.d@swipnet.se>
12360
12361 * nsmenu.m (runDialogAt): Remove argument to timer_check.
12362
9af30bdf
GM
123632011-03-27 Glenn Morris <rgm@gnu.org>
12364
12365 * syssignal.h: Replace RETSIGTYPE with void.
12366 * atimer.c, data.c, dispnew.c, emacs.c, floatfns.c, keyboard.c:
12367 * keyboard.h, lisp.h, process.c, sysdep.c, xterm.c:
12368 Replace SIGTYPE with void everywhere.
12369 * s/usg5-4-common.h (SIGTYPE): Remove definition.
12370 * s/template.h (SIGTYPE): Remove commented out definition.
12371
e2abce01
JB
123722011-03-26 Eli Zaretskii <eliz@gnu.org>
12373
12374 * xdisp.c (redisplay_window): Don't check buffer's clip_changed
12375 flag as a prerequisite for invoking try_scrolling. (Bug#6671)
12376
f868cd8a
JB
123772011-03-26 Juanma Barranquero <lekktu@gmail.com>
12378
59eb0929
JB
12379 * w32.c (read_unc_volume): Use parameter `henum', instead of
12380 global variable `wget_enum_handle'.
12381
12382 * keymap.c (describe_vector): Remove parameters `indices' and
12383 `char_table_depth', unused since 2002-03-01T01:43:26Z!handa@m17n.org.
12384 (describe_map, Fdescribe_vector): Adjust calls to `describe_vector'.
12385
f868cd8a
JB
12386 * keyboard.h (timer_check, show_help_echo): Remove unused parameters.
12387
12388 * keyboard.c (timer_check): Remove parameter `do_it_now',
12389 unused since 1996-04-12T06:01:29Z!rms@gnu.org.
12390 (show_help_echo): Remove parameter `ok_to_overwrite_keystroke_echo',
12391 unused since 2008-04-19T19:30:53Z!monnier@iro.umontreal.ca.
12392
12393 * keyboard.c (read_char):
12394 * w32menu.c (w32_menu_display_help):
12395 * xmenu.c (show_help_event, menu_help_callback):
12396 Adjust calls to `show_help_echo'.
12397
12398 * gtkutil.c (xg_maybe_add_timer):
12399 * keyboard.c (readable_events):
12400 * process.c (wait_reading_process_output):
12401 * xmenu.c (x_menu_wait_for_event): Adjust calls to `timer_check'.
12402
12403 * insdel.c (adjust_markers_gap_motion):
12404 Remove; no-op since 1998-01-02T21:29:48Z!rms@gnu.org.
12405 (gap_left, gap_right): Don't call it.
12406
2ecf6fdb
CY
124072011-03-25 Chong Yidong <cyd@stupidchicken.com>
12408
12409 * xdisp.c (handle_fontified_prop): Discard changes to clip_changed
12410 incurred during fontification.
12411
6b1f9ba4
JB
124122011-03-25 Juanma Barranquero <lekktu@gmail.com>
12413
12414 * buffer.c (defvar_per_buffer): Remove unused parameter `doc'.
12415 (DEFVAR_PER_BUFFER): Don't pass it.
12416
12417 * dispnew.c (row_equal_p, add_row_entry): Remove unused parameter `w'.
12418 (scrolling_window): Don't pass it.
12419
0f4a96b5
JB
124202011-03-25 Juanma Barranquero <lekktu@gmail.com>
12421
12422 * dispextern.h (glyph_matric): Use #if GLYPH_DEBUG, not #ifdef.
12423
12424 * fileio.c (check_executable) [DOS_NT]: Remove unused variables `len'
12425 and `suffix'.
12426 (Fset_file_selinux_context) [HAVE_LIBSELINUX]: Move here declaration
12427 of variables specific to SELinux and computation of `encoded_absname'.
12428
12429 * image.c (XPutPixel): Remove unused variable `height'.
12430
12431 * keyboard.c (make_lispy_event): Remove unused variable `hpos'.
12432
12433 * unexw32.c (get_section_info): Remove unused variable `section'.
12434
12435 * w32.c (stat): Remove unused variables `drive_root' and `devtype'.
12436 (system_process_attributes): Remove unused variable `sess'.
12437 (sys_read): Remove unused variable `err'.
12438
12439 * w32fns.c (top): Wrap variables with #if GLYPH_DEBUG, not #ifdef.
12440 (w32_wnd_proc): Remove unused variable `isdead'.
12441 (unwind_create_frame): Use #if GLYPH_DEBUG, not #ifdef.
12442 (Fx_server_max_request_size): Remove unused variable `dpyinfo'.
12443 (x_create_tip_frame): Remove unused variable `tem'.
12444
12445 * w32inevt.c (w32_console_read_socket):
12446 Remove unused variable `no_events'.
12447
12448 * w32term.c (x_draw_composite_glyph_string_foreground):
12449 Remove unused variable `width'.
12450
1149507c
JB
124512011-03-24 Juanma Barranquero <lekktu@gmail.com>
12452
12453 * w32term.c (x_set_glyph_string_clipping):
12454 Don't pass uninitialized region to CombineRgn.
12455
9c88f339
JB
124562011-03-23 Juanma Barranquero <lekktu@gmail.com>
12457
12458 * w32fns.c (x_set_menu_bar_lines): Remove unused variable `olines'.
12459 (w32_wnd_proc): Pass NULL to Windows API, not uninitialized buffer.
12460 (Fx_close_connection): Remove unused variable `i'.
12461
12462 * w32font.c (w32font_draw): Return number of glyphs.
12463 (w32font_open_internal): Remove unused variable `i'.
12464 (w32font_driver): Add missing initializer.
12465
12466 * w32menu.c (utf8to16): Remove unused variable `utf16'.
12467 (fill_in_menu): Remove unused variable `items_added'.
12468
12469 * w32term.c (last_mouse_press_frame): Remove static global variable.
12470 (w32_clip_to_row): Remove unused variable `f'.
12471 (x_delete_terminal): Remove unused variable `i'.
12472
12473 * w32uniscribe.c (uniscribe_shape): Remove unused variable `nclusters'.
12474 (NOTHING): Remove unused static global variable.
12475 (uniscribe_check_otf): Remove unused variable `table'.
12476 (uniscribe_font_driver): Add missing initializers.
12477
dee091a3
JD
124782011-03-23 Julien Danjou <julien@danjou.info>
12479
12480 * term.c (Fsuspend_tty, Fresume_tty):
12481 * minibuf.c (read_minibuf, run_exit_minibuf_hook):
12482 * window.c (temp_output_buffer_show):
12483 * insdel.c (signal_before_change):
12484 * frame.c (Fhandle_switch_frame):
12485 * fileio.c (Fdo_auto_save):
12486 * emacs.c (Fkill_emacs):
12487 * editfns.c (save_excursion_restore):
12488 * cmds.c (internal_self_insert):
12489 * callint.c (Fcall_interactively):
12490 * buffer.c (Fkill_all_local_variables):
12491 * keyboard.c (Fcommand_execute, Fsuspend_emacs, safe_run_hooks_1):
12492 Use Frun_hooks.
0f4a96b5 12493 (command_loop_1): Use Frun_hooks. Call safe_run_hooks
e9fce1ac 12494 unconditionally since it does the check itself.
dee091a3 12495
2c520ab5 124962011-03-23 Paul Eggert <eggert@cs.ucla.edu>
f0641eff 12497
c9c49752
PE
12498 Fix more problems found by GCC 4.5.2's static checks.
12499
8abc3f12
PE
12500 * coding.c (encode_coding_raw_text): Avoid unnecessary test
12501 the first time through the loop, since we know p0 < p1 then.
12502 This also avoids a gcc -Wstrict-overflow warning.
12503
a2d26660
PE
12504 * lisp.h (SAFE_ALLOCA, SAFE_ALLOCA_LISP): Avoid 'int' overflow
12505 leading to a memory leak, possible in functions like
12506 load_charset_map_from_file that can allocate an unbounded number
b12ef411 12507 of objects (Bug#8318).
a2d26660 12508
916c72e9
PE
12509 * xmenu.c (set_frame_menubar): Use EMACS_UINT, not int, for indexes
12510 that could (at least in theory) be that large.
12511
19ab8a18
PE
12512 * xdisp.c (message_log_check_duplicate): Return unsigned long, not int.
12513 This is less likely to overflow, and avoids undefined behavior if
12514 overflow does occur. All callers changed. Use strtoul to scan
12515 for the unsigned long integer.
b7cbbd6f
PE
12516 (pint2hrstr): Simplify and tune code slightly.
12517 This also avoids a (bogus) GCC warning with gcc -Wstrict-overflow.
19ab8a18 12518
f0641eff
PE
12519 * scroll.c (do_scrolling): Work around GCC bug 48228.
12520 See <http://gcc.gnu.org/bugzilla/show_bug.cgi?id=48228>.
12521
7f650bb9
PE
12522 * frame.c (Fmodify_frame_parameters): Simplify loop counter.
12523 This also avoids a warning with gcc -Wstrict-overflow.
39f5e519
PE
12524 (validate_x_resource_name): Simplify count usage.
12525 This also avoids a warning with gcc -Wstrict-overflow.
7f650bb9 12526
37dd57d1
PE
12527 * fileio.c (Fcopy_file): Report error if fchown or fchmod
12528 fail (Bug#8306).
81e56e61 12529
699979fc 12530 * emacs.c (Fdaemon_initialized): Do not ignore I/O errors (Bug#8303).
dc1ca6a8 12531
401bf9b4
PE
12532 * process.c (Fmake_network_process): Use socklen_t, not int,
12533 where POSIX says socklen_t is required in portable programs.
12534 This fixes a porting bug on hosts like 64-bit HP-UX, where
591b2973 12535 socklen_t is wider than int (Bug#8277).
401bf9b4
PE
12536 (Fmake_network_process, server_accept_connection):
12537 (wait_reading_process_output, read_process_output):
12538 Likewise.
12539
b93aacde
PE
12540 * process.c: Rename or move locals to avoid shadowing.
12541 (list_processes_1, Fmake_network_process):
12542 (read_process_output_error_handler, exec_sentinel_error_handler):
12543 Rename or move locals.
4dc343ee 12544 (Fmake_network_process): Define label "retry_connect" only if needed.
0da49335 12545 (Fnetwork_interface_info): Fix pointer signedness.
f990b4e5 12546 (process_send_signal): Add cast to avoid pointer signedness problem.
7b808126 12547 (FIRST_PROC_DESC, IF_NON_BLOCKING_CONNECT): Remove unused macros.
c939f91b 12548 (create_process): Use 'volatile' to avoid vfork clobbering (Bug#8298).
b93aacde 12549
af8a867c 12550 Make tparam.h and terminfo.c consistent.
44f230aa
SM
12551 * cm.c (tputs, tgoto, BC, UP): Remove extern decls.
12552 Include tparam.h instead, since it declares them.
af8a867c
PE
12553 * cm.h (PC): Remove extern decl; tparam.h now does this.
12554 * deps.mk (cm.o, terminfo.o): Depend on tparam.h.
12555 * terminfo.c: Include tparam.h, to check interfaces.
12556 (tparm): Make 1st arg a const pointer in decl. Put it at top level.
12557 (tparam): Adjust signature to match interface in tparam.h;
12558 this removes some undefined behavior. Check that outstring and len
12559 are zero, which they always are with Emacs.
12560 * tparam.h (PC, BC, UP): New extern decls.
12561
0248044d 12562 * xftfont.c (xftfont_shape): Now static, and defined only if needed.
001a7ab4 12563 (xftfont_open): Rename locals to avoid shadowing.
0248044d 12564
8ff096c1 12565 * ftfont.c (ftfont_resolve_generic_family): Fix pointer signedness.
a00924bb
PE
12566 (ftfont_otf_capability, ftfont_shape): Omit decls if not needed.
12567 (OTF_TAG_SYM): Omit macro if not needed.
e932860f 12568 (ftfont_list): Remove unused local.
49eaafba
PE
12569 (get_adstyle_property, ftfont_pattern_entity):
12570 (ftfont_lookup_cache, ftfont_open, ftfont_anchor_point):
12571 Rename locals to avoid shadowing.
8ff096c1 12572
e2be39f6
PE
12573 * xfont.c (xfont_list_family): Mark var as initialized.
12574
c9735e30
PE
12575 * xml.c (make_dom): Now static.
12576
8f5201ae
PE
12577 * composite.c (composition_compute_stop_pos): Rename local to
12578 avoid shadowing.
b246f932
PE
12579 (composition_reseat_it): Remove unused locals.
12580 (find_automatic_composition, composition_adjust_point): Likewise.
80e079b2 12581 (composition_update_it): Mark var as initialized.
11b61122
PE
12582 (find_automatic_composition): Mark vars as initialized,
12583 with a FIXME (Bug#8290).
8f5201ae 12584
760fbc2c
PE
12585 character.h: Rename locals to avoid shadowing.
12586 * character.h (PREV_CHAR_BOUNDARY, FETCH_STRING_CHAR_ADVANCE):
12587 (FETCH_STRING_CHAR_AS_MULTIBYTE_ADVANCE, FETCH_CHAR_ADVANCE):
12588 (FETCH_CHAR_ADVANCE_NO_CHECK, INC_POS, DEC_POS, BUF_INC_POS):
12589 (BUF_DEC_POS): Be more systematic about renaming local temporaries
12590 to avoid shadowing.
12591
ff08eb85
PE
12592 * textprop.c (property_change_between_p): Remove; unused.
12593
fc7bf025
PE
12594 * intervals.c (interval_start_pos): Now static.
12595
235d7abc
PE
12596 * intervals.h (CHECK_TOTAL_LENGTH): Avoid empty "else".
12597
44f230aa
SM
12598 * atimer.c (start_atimer, append_atimer_lists, set_alarm):
12599 Rename locals to avoid shadowing.
3e7d6594 12600
50060332
PE
12601 * sound.c (wav_play, au_play, Fplay_sound_internal):
12602 Fix pointer signedness.
d01f234b 12603 (alsa_choose_format): Remove unused local var.
c83b8872
PE
12604 (wav_play): Initialize a variable to 0, to prevent undefined
12605 behavior (Bug#8278).
50060332 12606
c4fc4e30
PE
12607 * region-cache.c (insert_cache_boundary): Redo var to avoid shadowing.
12608
918436ed
PE
12609 * region-cache.h (pp_cache): New decl, for gcc -Wmissing-prototypes.
12610
c939f91b
PE
12611 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork
12612 clobbering (Bug#8298).
b9c7f648
PE
12613 * sysdep.c (sys_subshell): Likewise.
12614 Previously, the sys_subshell 'volatile' was incorrectly IF_LINTted out.
7e9123a2 12615
6bd8c144
PE
12616 * lisp.h (child_setup): Now NO_RETURN unless DOS_NT.
12617 This should get cleaned up, so that child_setup has the
12618 same signature on all platforms.
12619
7710357c 12620 * callproc.c (call_process_cleanup): Now static.
cb1d0ef7 12621 (relocate_fd): Rename locals to avoid shadowing.
7710357c 12622
c59da222
CY
126232011-03-22 Chong Yidong <cyd@stupidchicken.com>
12624
12625 * xterm.c (x_clear_frame): Remove XClearWindow call. This appears
12626 not to be necessary, and produces flickering.
12627
66b87493
GM
126282011-03-20 Glenn Morris <rgm@gnu.org>
12629
12630 * config.in: Remove file.
12631
45b6f6d5
JB
126322011-03-20 Juanma Barranquero <lekktu@gmail.com>
12633
12634 * minibuf.c (Vcompleting_read_function): Don't declare, global variables
12635 are now in src/globals.h.
12636 (syms_of_minibuf): Remove spurious & from previous change.
12637
cd394be1 126382011-03-20 Leo Liu <sdl.web@gmail.com>
3ec03f7e
LL
12639
12640 * minibuf.c (completing-read-function): New variable.
12641 (completing-read-default): Rename from completing-read.
12642 (completing-read): Call completing-read-function.
12643
b14e3e21
CY
126442011-03-19 Juanma Barranquero <lekktu@gmail.com>
12645
12646 * xfaces.c (Fx_load_color_file):
12647 Read color file from absolute filename (bug#8250).
12648
f2b726e6
JB
126492011-03-19 Juanma Barranquero <lekktu@gmail.com>
12650
12651 * makefile.w32-in: Update dependencies.
12652
09f6ff02
EZ
126532011-03-17 Eli Zaretskii <eliz@gnu.org>
12654
12655 * makefile.w32-in ($(BLD)/unexw32.$(O)): Depend on $(SRC)/unexec.h.
12656
29a6015a
PE
126572011-03-17 Paul Eggert <eggert@cs.ucla.edu>
12658
a3a6c54e
PE
12659 Fix more problems found by GCC 4.5.2's static checks.
12660
b766f867
PE
12661 * process.c (make_serial_process_unwind, send_process_trap):
12662 (sigchld_handler): Now static.
12663
be02381c
PE
12664 * process.c (allocate_pty): Let PTY_ITERATION declare iteration vars.
12665 That way, the code declares only the vars that it needs.
12666 * s/aix4-2.h (PTY_ITERATION): Declare iteration vars.
12667 * s/cygwin.h (PTY_ITERATION): Likewise.
12668 * s/darwin.h (PTY_ITERATION): Likewise.
12669 * s/gnu-linux.h (PTY_ITERATION): Likewise.
12670
57048744
PE
12671 * s/irix6-5.h (PTY_OPEN): Declare stb, to loosen coupling.
12672 * process.c (allocate_pty): Don't declare stb unless it's needed.
12673
7914961c 12674 * bytecode.c (MAYBE_GC): Rewrite so as not to use empty "else".
615f2d59
PE
12675 (CONSTANTLIM): Remove; unused.
12676 (METER_CODE, Bscan_buffer, Bread_char, Bset_mark):
12677 Define only if needed.
7914961c 12678
b3967b18
PE
12679 * unexelf.c (unexec): Name an expression,
12680 to avoid gcc -Wbad-function-cast warning.
9ae71512
PE
12681 Use a different way to cause a compilation error if anyone uses
12682 n rather than nn, a way that does not involve shadowing.
73366a00 12683 (ELF_BSS_SECTION_NAME, OLD_PROGRAM_H): Remove; unused.
b3967b18 12684
29a6015a
PE
12685 * deps.mk (unexalpha.o): Remove; unused.
12686
43cfc33e 12687 New file unexec.h, the (simple) interface for unexec (Bug#8267).
7feda0d2 12688 * unexec.h: New file.
ce701a33
PE
12689 * deps.mk (emacs.o, unexaix.o, unexcw.o, unexcoff.o, unexelf.o):
12690 (unexhp9k800.o, unexmacosx.o, unexsol.o, unexw32.o):
12691 Depend on unexec.h.
12692 * emacs.c [!defined CANNOT_DUMP]: Include unexec.h.
12693 * unexaix.c, unexcoff.c, unexcw.c, unexelf.c, unexhp9k800.c:
12694 * unexmacosx.c, unexsol.c, unexw32.c: Include unexec.h.
381259ef 12695 Change as necessary to match prototype in unexec.h.
ce701a33 12696
01f44d5a
PE
12697 * syntax.c (Fforward_comment, scan_lists): Rename locals to avoid
12698 shadowing.
4f63c6bb 12699 (back_comment, skip_chars): Mark vars as initialized.
01f44d5a 12700
a6670b0b
PE
12701 * character.h (FETCH_STRING_CHAR_ADVANCE_NO_CHECK, BUF_INC_POS):
12702 Rename locals to avoid shadowing.
12703
cef2010d 12704 * lread.c (read1): Rewrite so as not to use empty "else".
0902fe45 12705 (Fload, readevalloop, read1): Rename locals to avoid shadowing.
cef2010d 12706
d4d7173a
PE
12707 * print.c (Fredirect_debugging_output): Fix pointer signedess.
12708
f08b802a
PE
12709 * lisp.h (debug_output_compilation_hack): Add decl here, to avoid
12710 warning when compiling print.c.
12711
3ddb0639
PE
12712 * font.c (font_unparse_fcname): Abort in an "impossible" situation
12713 instead of using an uninitialized var.
5ad03b97 12714 (font_sort_entities): Mark var as initialized.
3ddb0639 12715
170a2692
PE
12716 * character.h (FETCH_CHAR_ADVANCE): Rename locals to avoid shadowing.
12717
e663c700
PE
12718 * font.c (font_unparse_xlfd): Don't mix pointers to variables with
12719 pointers to constants.
89bc529a 12720 (font_parse_fcname): Remove unused vars.
7b81e2d0 12721 (font_delete_unmatched): Now static.
ea838e10 12722 (font_get_spec): Remove; unused.
13a547c6
PE
12723 (font_style_to_value, font_prop_validate_style, font_unparse_fcname):
12724 (font_update_drivers, Ffont_get_glyphs, font_add_log):
12725 Rename or move locals to avoid shadowing.
e663c700 12726
2a80c887 12727 * fns.c (require_nesting_list, require_unwind): Now static.
612f56df 12728 (Ffillarray): Rename locals to avoid shadowing.
2a80c887 12729
1384fa33 12730 * floatfns.c (domain_error2): Define only if needed.
a885e2ed 12731 (Ffrexp, Fldexp): Rename locals to avoid shadowing.
1384fa33 12732
8b2c52e9
PE
12733 * alloc.c (mark_backtrace): Move decl from here ...
12734 * lisp.h: ... to here, so that it can be checked.
12735
475545b5 12736 * eval.c (call_debugger, do_debug_on_call, grow_specpdl): Now static.
d28a2170 12737 (Fdefvar): Rewrite so as not to use empty "else".
cfcbfb1a
PE
12738 (lisp_indirect_variable): Name an expression,
12739 to avoid gcc -Wbad-function-cast warning.
1faed8ae 12740 (Fdefvar): Rename locals to avoid shadowing.
475545b5 12741
b1349114 12742 * callint.c (quotify_arg, quotify_args): Now static.
a3e8cbda 12743 (Fcall_interactively): Rename locals to avoid shadowing.
b0e80955 12744 Use const pointer when appropriate.
b1349114 12745
a2928364
PE
12746 * lisp.h (get_system_name, get_operating_system_release):
12747 Move decls here, to check interfaces.
12748 * process.c (get_operating_system_release): Move decl to lisp.h.
12749 * xrdb.c (get_system_name): Likewise.
63c5d10b
PE
12750 * editfns.c (init_editfns, Fuser_login_name, Fuser_uid):
12751 (Fuser_real_uid, Fuser_full_name): Remove unnecessary casts,
12752 some of which prompt warnings from gcc -Wbad-function-cast.
545b49b4
PE
12753 (Fformat_time_string, Fencode_time, Finsert_char):
12754 (Ftranslate_region_internal, Fformat):
12755 Rename or remove local vars to avoid shadowing.
9710023e 12756 (Ftranslate_region_internal): Mark var as initialized.
63c5d10b 12757
a415e694
PE
12758 * doc.c (Fdocumentation, Fsnarf_documentation): Move locals to
12759 avoid shadowing.
12760
8ef4622d
PE
12761 * lisp.h (eassert): Check that the argument compiles, even if
12762 ENABLE_CHECKING is not defined.
12763
946f9a5b
PE
12764 * data.c (Findirect_variable): Name an expression, to avoid
12765 gcc -Wbad-function-cast warning.
112396d6 12766 (default_value, arithcompare, arith_driver, arith_error): Now static.
b9b84fa9 12767 (store_symval_forwarding): Rename local to avoid shadowing.
44f230aa
SM
12768 (Fmake_variable_buffer_local, Fmake_local_variable):
12769 Mark variables as initialized.
52746918 12770 (do_blv_forwarding, do_symval_forwarding): Remove; unused.
946f9a5b 12771
e5aab7e7 12772 * alloc.c (check_cons_list): Do not define unless GC_CHECK_CONS_LIST.
ae35e756
PE
12773 (Fmake_vector, Fvector, Fmake_byte_code, Fgarbage_collect):
12774 Rename locals to avoid shadowing.
dff45157
PE
12775 (mark_stack): Move local variables into the #ifdef region where
12776 they're used.
7bc26fdb
PE
12777 (BLOCK_INPUT_ALLOC, UNBLOCK_INPUT_ALLOC): Define only if
12778 ! defined SYSTEM_MALLOC && ! defined SYNC_INPUT, as they are not
12779 needed otherwise.
12780 (CHECK_ALLOCATED): Define only if GC_CHECK_MARKED_OBJECTS.
12781 (GC_STRING_CHARS): Remove; not used.
d40d4be1 12782 (Fmemory_limit): Cast sbrk's returned value to char *.
ae35e756 12783
e5aab7e7
PE
12784 * lisp.h (check_cons_list): Declare if GC_CHECK_CONS_LIST; this
12785 avoids undefined behavior in theory.
12786
4da60324
PE
12787 * regex.c (IF_LINT): Add defn, for benefit of ../lib-src.
12788
88043301
PE
12789 Use functions, not macros, for up- and down-casing (Bug#8254).
12790 * buffer.h (DOWNCASE_TABLE, UPCASE_TABLE, DOWNCASE, UPPERCASEP):
12791 (NOCASEP, LOWERCASEP, UPCASE, UPCASE1): Remove. All callers changed
12792 to use the following functions instead of these macros.
12793 (downcase): Adjust to lack of DOWNCASE_TABLE. Return int, not
12794 EMACS_INT, since callers assume the returned value fits in int.
12795 (upcase1): Likewise, for UPCASE_TABLE.
12796 (uppercasep, lowercasep, upcase): New static inline functions.
0da09c43 12797 * editfns.c (Fchar_equal): Remove no-longer-needed workaround for
db69b0cd 12798 the race-condition problem in the old DOWNCASE.
88043301 12799
19ed5445
PE
12800 * regex.c (CHARSET_LOOKUP_RANGE_TABLE_RAW, POP_FAILURE_REG_OR_COUNT):
12801 Rename locals to avoid shadowing.
12802 (regex_compile, re_match_2_internal): Move locals to avoid shadowing.
abbd1bcf
PE
12803 (regex_compile, re_search_2, re_match_2_internal):
12804 Remove unused local vars.
952db0d7
PE
12805 (FREE_VAR): Rewrite so as not to use empty "else",
12806 which gcc can warn about.
da053e48 12807 (regex_compile, re_match_2_internal): Mark locals as initialized.
b313f9d8
PE
12808 (RETALLOC_IF): Define only if needed.
12809 (WORDCHAR_P): Likewise. This one is never needed, but is used
12810 only in a comment talking about a compiler bug, so put inside
12811 the #if 0 of that comment.
12812 (CHARSET_LOOKUP_BITMAP, FAIL_STACK_FULL, RESET_FAIL_STACK):
12813 (PUSH_FAILURE_ELT, BUF_PUSH_3, STOP_ADDR_VSTRING):
12814 Remove; unused.
19ed5445 12815
1f3561e4 12816 * search.c (boyer_moore): Rename locals to avoid shadowing.
76ef09b7
PE
12817 * character.h (FETCH_STRING_CHAR_AS_MULTIBYTE_ADVANCE):
12818 (PREV_CHAR_BOUNDARY): Likewise.
1f3561e4 12819
ded6f8f7
PE
12820 * search.c (simple_search): Remove unused var.
12821
dbd37a95
PE
12822 * dired.c (compile_pattern): Move decl from here ...
12823 * lisp.h: ... to here, so that it can be checked.
12824 (struct re_registers): New forward decl.
12825
7e47afad
PE
12826 * character.h (INC_POS, DEC_POS): Rename locals to avoid shadowing.
12827
85f24f61
PE
12828 * indent.c (MULTIBYTE_BYTES_WIDTH): New args bytes, width.
12829 All uses changed.
12830 (MULTIBYTE_BYTES_WIDTH, scan_for_column, compute_motion):
12831 Rename locals to avoid shadowing.
5671df8f 12832 (Fvertical_motion): Mark locals as initialized.
85f24f61 12833
181aa2be 12834 * casefiddle.c (casify_object, casify_region): Now static.
e45a141a 12835 (casify_region): Mark local as initialized.
181aa2be 12836
930d429c
PE
12837 * cmds.c (internal_self_insert): Rename local to avoid shadowing.
12838
7082eac6
PE
12839 * lisp.h (GCPRO2_VAR, GCPRO3_VAR, GCPRO4_VAR, GCPRO5_VAR, GCPRO6_VAR):
12840 New macros, so that the caller can use some names other than
12841 gcpro1, gcpro2, etc.
12842 (GCPRO2, GCPRO3, GCPRO4, GCPRO5, GCPRO6): Reimplement in terms
12843 of the new macros.
12844 (GCPRO1_VAR, UNGCPRO_VAR): Change the meaning of the second
12845 argument, for consistency with GCPRO2_VAR, etc: it is now the
12846 prefix of the variable, not the variable itself. All uses
12847 changed.
38b2c076
PE
12848 * dired.c (directory_files_internal, file_name_completion):
12849 Rename locals to avoid shadowing.
12850
15206ed9
PE
12851 Fix a race condition diagnosed by gcc -Wsequence-point (Bug#8254).
12852 An expression of the form (DOWNCASE (x) == DOWNCASE (y)), found in
12853 dired.c's scmp function, had undefined behavior.
12854 * lisp.h (DOWNCASE_TABLE, UPCASE_TABLE, DOWNCASE, UPPERCASEP):
12855 (NOCASEP, LOWERCASEP, UPCASE, UPCASE1): Move from here ...
12856 * buffer.h: ... to here, because these macros use current_buffer,
12857 and the new implementation with inline functions needs to have
12858 current_buffer in scope now, rather than later when the macros
12859 are used.
12860 (downcase, upcase1): New static inline functions.
12861 (DOWNCASE, UPCASE1): Reimplement using these functions.
12862 This avoids undefined behavior in expressions like
12863 DOWNCASE (x) == DOWNCASE (y), which previously suffered
12864 from race conditions in accessing the global variables
12865 case_temp1 and case_temp2.
12866 * casetab.c (case_temp1, case_temp2): Remove; no longer needed.
12867 * lisp.h (case_temp1, case_temp2): Remove their decls.
12868 * character.h (ASCII_CHAR_P): Move from here ...
12869 * lisp.h: ... to here, so that the inline functions mentioned
12870 above can use them.
12871
4a6bea26
PE
12872 * dired.c (directory_files_internal_unwind): Now static.
12873
f14b7e14
PE
12874 * fileio.c (file_name_as_directory, directory_file_name):
12875 (barf_or_query_if_file_exists, auto_save_error, auto_save_1):
12876 Now static.
2893f146
PE
12877 (file_name_as_directory): Use const pointers when appropriate.
12878 (Fexpand_file_name): Likewise. In particular, newdir might
12879 point at constant storage, so make it a const pointer.
fd4ead52 12880 (Fmake_directory_internal, Fread_file_name): Remove unused vars.
b14aac08
PE
12881 (Ffile_selinux_context, Fset_file_selinux_context): Fix pointer
12882 signedness issues.
f839df0c
PE
12883 (Fset_file_times, Finsert_file_contents, auto_save_error):
12884 Rename locals to avoid shadowing.
f14b7e14 12885
5716756e 12886 * minibuf.c (choose_minibuf_frame_1): Now static.
62137a95
PE
12887 (Ftry_completion, Fall_completions): Rename or remove locals
12888 to avoid shadowing.
5716756e 12889
b4c3046a
PE
12890 * marker.c (bytepos_to_charpos): Remove; unused.
12891
b45db522
PE
12892 * lisp.h (verify_bytepos, count_markers): New decls,
12893 so that gcc does not warn that these functions aren't declared.
12894
85876d07
PE
12895 * insdel.c (check_markers, make_gap_larger, make_gap_smaller):
12896 (reset_var_on_error, Fcombine_after_change_execute_1): Now static.
f0cb4a60 12897 (CHECK_MARKERS): Redo to avoid gcc -Wempty-body diagnostic.
40ef059e 12898 (copy_text): Remove unused local var.
85876d07 12899
03d78a21 12900 * filelock.c (within_one_second): Now static.
b3dd38ab 12901 (lock_file_1): Rename local to avoid shadowing.
03d78a21 12902
5df8f01b
PE
12903 * buffer.c (fix_overlays_before): Mark locals as initialized.
12904 (fix_start_end_in_overlays): Likewise. This function should be
12905 simplified by using pointers-to-pointers, but that's a different
12906 matter.
b1d876f1 12907 (switch_to_buffer_1): Now static.
8f54f30a
PE
12908 (Fkill_buffer, record_buffer, Fbury_buffer, Fset_buffer_multibyte):
12909 (report_overlay_modification): Rename locals to avoid shadowing.
c3bd59b5 12910
a70072c9 12911 * sysdep.c (system_process_attributes): Rename vars to avoid shadowing.
fbd02d7b 12912 Fix pointer signedness issue.
edced198
PE
12913 (sys_subshell): Mark local as volatile if checking for lint,
12914 to suppress a gcc -Wclobbered warning that does not seem to be right.
15dfd3d9 12915 (MAXPATHLEN): Define only if needed.
a70072c9 12916
a0977c44
PE
12917 * process.c (serial_open, serial_configure): Move decls from here ...
12918 * systty.h: ... to here, so that they can be checked.
12919
a884fdcc
PE
12920 * fns.c (get_random, seed_random): Move extern decls from here ...
12921 * lisp.h: ... to here, so that they can be checked.
12922
604efe86 12923 * sysdep.c (reset_io): Now static.
b8950c94 12924 (wait_for_termination_signal): Remove; unused.
604efe86 12925
38fc62d9
PE
12926 * keymap.c (keymap_parent, keymap_memberp, map_keymap_internal):
12927 (copy_keymap_item, append_key, push_text_char_description):
12928 Now static.
1004a21a 12929 (Fwhere_is_internal): Don't test CONSP (sequences) unnecessarily.
dbbb8427 12930 (DENSE_TABLE_SIZE): Remove; unused.
c1141155
PE
12931 (get_keymap, access_keymap, Fdefine_key, Fwhere_is_internal):
12932 (describe_map_tree):
12933 Rename locals to avoid shadowing.
38fc62d9 12934
2f2650da
PE
12935 * keyboard.c: Declare functions static if they are not used elsewhere.
12936 (echo_char, echo_dash, cmd_error, top_level_2):
12937 (poll_for_input, handle_async_input): Now static.
69a058fa
PE
12938 (read_char, kbd_buffer_get_event, make_lispy_position):
12939 (make_lispy_event, make_lispy_movement, apply_modifiers):
12940 (decode_keyboard_code, tty_read_avail_input, menu_bar_items):
12941 (parse_tool_bar_item, read_key_sequence, Fread_key_sequence):
12942 (Fread_key_sequence_vector): Rename locals to avoid shadowing.
c8a06054 12943 (read_key_sequence, read_char): Mark locals as initialized.
3ac94672 12944 (Fexit_recursive_edit, Fabort_recursive_edit): Mark with NO_RETURN.
2f2650da 12945
a053e86c 12946 * keyboard.h (make_ctrl_char): New decl.
da2f2dd9
PE
12947 (mark_kboards): Move decl here ...
12948 * alloc.c (mark_kboards): ... from here.
a053e86c 12949
4752793e
PE
12950 * lisp.h (force_auto_save_soon): New decl.
12951
74f10ca7 12952 * emacs.c (init_cmdargs): Rename local to avoid shadowing.
244fc23d
PE
12953 (DEFINE_DUMMY_FUNCTION): New macro.
12954 (__do_global_ctors, __do_global_ctors_aux, __do_global_dtors, __main):
12955 Use it.
c03cd23f
PE
12956 (main): Add casts to avoid warnings
12957 if GCC considers string literals to be constants.
74f10ca7 12958
022e70d4
PE
12959 * lisp.h (fatal_error_signal): Add decl, since it's exported.
12960
59d6fe83
PE
12961 * dbusbind.c: Pointer signedness fixes.
12962 (xd_signature, xd_append_arg, xd_initialize):
12963 (Fdbus_call_method, Fdbus_call_method_asynchronously):
12964 (Fdbus_method_return_internal, Fdbus_method_error_internal):
12965 (Fdbus_send_signal, xd_read_message_1, Fdbus_register_service):
12966 (Fdbus_register_signal): Use SSDATA when the context wants char *.
12967
78320123
PE
12968 * dbusbind.c (Fdbus_init_bus): Add cast to avoid warning
12969 if GCC considers string literals to be constants.
49cebcca 12970 (Fdbus_register_service, Fdbus_register_method): Remove unused vars.
78320123 12971
35ac2a97
SM
129722011-03-16 Stefan Monnier <monnier@iro.umontreal.ca>
12973
fb103ca9
SM
12974 * print.c (PRINT_CIRCLE_CANDIDATE_P): New macro.
12975 (print_preprocess, print_object): New macro to fix last change.
12976
35ac2a97
SM
12977 * print.c (print_preprocess): Don't forget font objects.
12978
62973b41
JB
129792011-03-16 Juanma Barranquero <lekktu@gmail.com>
12980
12981 * emacs.c (USAGE3): Doc fixes.
12982
0e48bb22
AS
129832011-03-15 Andreas Schwab <schwab@linux-m68k.org>
12984
12985 * coding.c (detect_coding_iso_2022): Reorganize code to clarify
12986 structure.
12987
7684e57b
JB
129882011-03-14 Juanma Barranquero <lekktu@gmail.com>
12989
12990 * lisp.h (VWindow_system, Qfile_name_history):
12991 * keyboard.h (lispy_function_keys) [WINDOWSNT]:
12992 * w32term.h (w32_system_caret_hwnd, w32_system_caret_height)
12993 (w32_system_caret_x, w32_system_caret_y): Declare extern.
12994
12995 * w32select.c: Don't #include "keyboard.h".
c96bbc66 12996 (run_protected): Add extern declaration for waiting_for_input.
7684e57b
JB
12997
12998 * w32.c (Qlocal, noninteractive1, inhibit_window_system):
12999 * w32console.c (detect_input_pending, read_input_pending)
13000 (encode_terminal_code):
13001 * w32fns.c (quit_char, lispy_function_keys, Qtooltip)
13002 (w32_system_caret_hwnd, w32_system_caret_height, w32_system_caret_x)
13003 (w32_system_caret_y, Qfile_name_history):
13004 * w32font.c (w32font_driver, QCantialias, QCotf, QClang):
13005 * w32inevt.c (reinvoke_input_signal, lispy_function_keys):
13006 * w32menu.c (Qmenu_bar, QCtoggle, QCradio, Qoverriding_local_map)
13007 (Qoverriding_terminal_local_map, Qmenu_bar_update_hook):
13008 * w32proc.c (Qlocal, report_file_error):
13009 * w32term.c (Vwindow_system, updating_frame):
13010 * w32uniscribe.c (initialized, uniscribe_font_driver):
13011 Remove unneeded extern declarations.
13012
2aa46d6c
CY
130132011-03-14 Chong Yidong <cyd@stupidchicken.com>
13014
c96bbc66 13015 * buffer.c (Fmake_indirect_buffer): Fix incorrect assertions.
2aa46d6c 13016
cffc6f3b
CY
130172011-03-13 Chong Yidong <cyd@stupidchicken.com>
13018
13019 * buffer.h (BUF_BEGV, BUF_BEGV_BYTE, BUF_ZV, BUF_ZV_BYTE, BUF_PT)
13020 (BUF_PT_BYTE): Rewrite to handle indirect buffers (Bug#8219).
13021 These macros can no longer be used for assignment.
13022
44f230aa
SM
13023 * buffer.c (Fget_buffer_create, Fmake_indirect_buffer):
13024 Assign struct members directly, instead of using BUF_BEGV etc.
cffc6f3b
CY
13025 (record_buffer_markers, fetch_buffer_markers): New functions for
13026 recording and fetching special buffer markers.
13027 (set_buffer_internal_1, set_buffer_temp): Use them.
13028
13029 * lread.c (unreadchar): Use SET_BUF_PT_BOTH.
13030
13031 * insdel.c (adjust_point): Use SET_BUF_PT_BOTH.
13032
13033 * intervals.c (temp_set_point_both): Use SET_BUF_PT_BOTH.
13034 (get_local_map): Use SET_BUF_BEGV_BOTH and SET_BUF_ZV_BOTH.
13035
13036 * xdisp.c (hscroll_window_tree):
13037 (reconsider_clip_changes): Use PT instead of BUF_PT.
13038
d251f04b
EZ
130392011-03-13 Eli Zaretskii <eliz@gnu.org>
13040
13041 * makefile.w32-in ($(BLD)/editfns.$(O)): Depend on
13042 $(EMACS_ROOT)/lib/intprops.h.
13043
f0c77cd1
PE
130442011-03-13 Paul Eggert <eggert@cs.ucla.edu>
13045
3eca4629
PE
13046 Fix more problems found by GCC 4.5.2's static checks.
13047
7c86ee98
PE
13048 * gtkutil.c (xg_get_pixbuf_from_pixmap): Add cast from char *
13049 to unsigned char * to avoid compiler diagnostic.
b0afc268
PE
13050 (xg_free_frame_widgets): Make it clear that a local variable is
13051 needed only if USE_GTK_TOOLTIP.
01e0b5ad
PE
13052 (gdk_window_get_screen): Make it clear that this macro is needed
13053 only if USE_GTK_TOOLTIP.
1e5524e7
PE
13054 (int_gtk_range_get_value): New function, which avoids a diagnostic
13055 from gcc -Wbad-function-cast.
13056 (xg_set_toolkit_scroll_bar_thumb): Use it.
13057 (xg_tool_bar_callback, xg_tool_item_stale_p): Rewrite to avoid
13058 diagnostic from gcc -Wbad-function-cast.
65dc836c
PE
13059 (get_utf8_string, xg_get_file_with_chooser):
13060 Rename locals to avoid shadowing.
13061 (create_dialog): Move locals to avoid shadowing.
7c86ee98 13062
41729b81
PE
13063 * xgselect.c (xg_select): Remove unused var.
13064
f0c77cd1
PE
13065 * image.c (four_corners_best): Mark locals as initialized.
13066 (gif_load): Initialize transparent_p to zero (Bug#8238).
13067 Mark another local as initialized.
ec6cf4c6 13068 (my_png_error, my_error_exit): Mark with NO_RETURN.
f0c77cd1 13069
ce0ad53d 13070 * image.c (clear_image_cache): Now static.
d5d5a617 13071 (DIM, HAVE_STDLIB_H_1): Remove unused macros.
e22cffbc 13072 (xpm_load): Redo to avoid "discards qualifiers" gcc warning.
77a765fd
PE
13073 (x_edge_detection): Remove unnecessary cast that
13074 gcc -Wbad-function-cast diagnoses.
2037898d 13075 (gif_load): Fix pointer signedness.
6ae141d6
PE
13076 (clear_image_cache, xbm_read_bitmap_data, x_detect_edges):
13077 (jpeg_load, gif_load): Rename locals to avoid shadowing.
ce0ad53d 13078
33383987 130792011-03-12 Paul Eggert <eggert@cs.ucla.edu>
3eca4629 13080
d32df629
PE
13081 Improve quality of tests for time stamp overflow.
13082 For example, without this patch (encode-time 0 0 0 1 1
13083 1152921504606846976) returns the obviously-bogus value (-948597
13084 62170) on my RHEL 5.5 x86-64 host. With the patch, it correctly
13085 reports time overflow. See
13086 <http://lists.gnu.org/archive/html/emacs-devel/2011-03/msg00470.html>.
b8d9bd41
PE
13087 * deps.mk (editfns.o): Depend on ../lib/intprops.h.
13088 * editfns.c: Include limits.h and intprops.h.
13089 (TIME_T_MIN, TIME_T_MAX): New macros.
13090 (time_overflow): Move earlier, to before first use.
13091 (hi_time, lo_time): New functions, for an accurate test for
13092 out-of-range times.
13093 (Fcurrent_time, Fget_internal_run_time, make_time): Use them.
13094 (Fget_internal_run_time): Don't assume time_t fits in int.
13095 (make_time): Use list2 instead of Fcons twice.
13096 (Fdecode_time): More accurate test for out-of-range times.
13097 (check_tm_member): New function.
13098 (Fencode_time): Use it, to test for out-of-range times.
d32df629
PE
13099 (lisp_time_argument): Don't rely on undefined left-shift and
13100 right-shift behavior when checking for time stamp overflow.
8be6f318 13101
fe31d94c
PE
13102 * editfns.c (time_overflow): New function, refactoring common code.
13103 (Fformat_time_string, Fdecode_time, Fencode_time):
13104 (Fcurrent_time_string): Use it.
13105
8be6f318
PE
13106 Move 'make_time' to be next to its inverse 'lisp_time_argument'.
13107 * dired.c (make_time): Move to ...
13108 * editfns.c (make_time): ... here.
13109 * systime.h: Note the move.
13110
09d9db2c 131112011-03-12 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
c47cbdfd 13112
126bc0dc
YM
13113 * fringe.c (update_window_fringes): Remove unused variables.
13114
c47cbdfd
YM
13115 * unexmacosx.c (copy_data_segment): Also copy __got section.
13116 (Bug#8223)
13117
7ac80be9
EZ
131182011-03-12 Eli Zaretskii <eliz@gnu.org>
13119
c96bbc66 13120 * termcap.c [MSDOS]: Include "msdos.h".
058e5dad
EZ
13121 (find_capability, tgetnum, tgetflag, tgetstr, tputs, tgetent):
13122 Constify `char *' arguments and their references according to
13123 prototypes in tparam.h.
13124
ecb0f94d 13125 * deps.mk (termcap.o): Depend on tparam.h and msdos.h.
058e5dad 13126
7ac80be9
EZ
13127 * msdos.c (XMenuAddPane): 3rd argument is `const char *' now.
13128 Adapt all references accordingly.
13129
13130 * msdos.h (XMenuAddPane): 3rd argument is `const char *' now.
13131
ef1fd07e
TT
131322011-03-11 Tom Tromey <tromey@redhat.com>
13133
13134 * buffer.c (syms_of_buffer): Remove obsolete comment.
13135
7ef4b50c
EZ
131362011-03-11 Eli Zaretskii <eliz@gnu.org>
13137
13138 * termhooks.h (encode_terminal_code): Declare prototype.
13139
13140 * msdos.c (encode_terminal_code): Don't declare prototype.
13141
13142 * term.c (encode_terminal_code): Now external again, used by
13143 w32console.c and msdos.c.
13144
44f230aa
SM
13145 * makefile.w32-in ($(BLD)/term.$(O), ($(BLD)/tparam.$(O)):
13146 Depend on $(SRC)/tparam.h, see 2011-03-11T07:24:21Z!eggert@cs.ucla.edu.
7ef4b50c 13147
4b1ec863 131482011-03-11 Paul Eggert <eggert@cs.ucla.edu>
f78faa98 13149
1714f52b 13150 Fix some minor problems found by GCC 4.5.2's static checks.
83316bf4 13151
4b1ec863
PE
13152 * fringe.c (update_window_fringes): Mark locals as initialized
13153 (Bug#8227).
13154 (destroy_fringe_bitmap, init_fringe_bitmap): Now static.
bf60f616 13155
524c7aa6
PE
13156 * alloc.c (mark_fringe_data): Move decl from here ...
13157 * lisp.h (mark_fringe_data) [HAVE_WINDOW_SYSTEM]: ... to here,
13158 to check its interface.
13159 (init_fringe_once): Do not declare unless HAVE_WINDOW_SYSTEM.
13160
a5c0af81 13161 * fontset.c (free_realized_fontset): Now static.
7519b8cd 13162 (Fset_fontset_font): Rename local to avoid shadowing.
cc6e5db1 13163 (fontset_font): Mark local as initialized.
a9a06e0b 13164 (FONTSET_SPEC, FONTSET_REPERTORY, RFONT_DEF_REPERTORY): Remove; unused.
a5c0af81 13165
b4716021
PE
13166 * xrdb.c: Include "xterm.h", to check x_load_resources's interface.
13167
811e9bac 13168 * xselect.c (x_disown_buffer_selections): Remove; not used.
7b83e2f1 13169 (TRACE3) [!defined TRACE_SELECTION]: Remove; not used.
aa0daa9f
PE
13170 (x_own_selection, Fx_disown_selection_internal): Rename locals
13171 to avoid shadowing.
13172 (x_handle_dnd_message): Remove local to avoid shadowing.
811e9bac 13173
7e3ab302
PE
13174 * lisp.h (GCPRO1_VAR, UNGCPRO_VAR): New macros,
13175 so that the caller can use some name other than gcpro1.
13176 (GCPRO1, UNGCPRO): Reimplement in terms of the new macros.
58d2d479
PE
13177 * xfns.c (Fx_create_frame, x_create_tip_frame, Fx_show_tip):
13178 (Fx_backspace_delete_keys_p):
13179 Use them to avoid shadowing, and rename vars to avoid shadowing.
13180 (x_decode_color, x_set_name, x_window): Now static.
6b437900 13181 (Fx_create_frame): Add braces to silence GCC warning.
c0951e53 13182 (Fx_file_dialog, Fx_select_font): Fix pointer signedness.
06b0c8a0
PE
13183 (x_real_positions, xg_set_icon_from_xpm_data, x_create_tip_frame):
13184 Remove unused locals.
7e3ab302
PE
13185 (Fx_create_frame, x_create_tip_frame, Fx_show_tip):
13186 (Fx_backspace_delete_keys_p): Rename locals to avoid shadowing.
13187 Some of these renamings use the new GCPRO1_VAR and UNGCPRO_VAR
13188 macros.
f78faa98 13189
e2b13473
PE
13190 * xterm.h (x_mouse_leave): New decl.
13191
77f23912
PE
13192 * xterm.c (x_copy_dpy_color, x_focus_on_frame, x_unfocus_frame):
13193 Remove unused functions.
cdf4ba58
PE
13194 (x_shift_glyphs_for_insert, XTflash, XTring_bell):
13195 (x_calc_absolute_position): Now static.
7411c686 13196 (XTread_socket): Don't define label "out" unless it's used.
2b07bcff 13197 Don't declare local "event" unless it's used.
ed7bf3a5
PE
13198 (x_iconify_frame, x_free_frame_resources): Don't declare locals
13199 unless they are used.
38d0b34a
PE
13200 (XEMBED_VERSION, xembed_set_info): Don't define unless needed.
13201 (x_fatal_error_signal): Remove; not used.
a6067996
PE
13202 (x_draw_image_foreground, redo_mouse_highlight, XTmouse_position):
13203 (x_scroll_bar_report_motion, handle_one_xevent, x_draw_bar_cursor):
13204 (x_error_catcher, x_connection_closed, x_error_handler):
13205 (x_error_quitter, xembed_send_message, x_iconify_frame):
13206 (my_log_handler): Rename locals to avoid shadowing.
28f1c698 13207 (x_delete_glyphs, x_ins_del_lines): Mark with NO_RETURN.
2a8fade0 13208 (x_connection_closed): Tell GCC not to suggest NO_RETURN.
77f23912 13209
44f230aa
SM
13210 * xfaces.c (clear_face_cache, Fx_list_fonts, Fface_font):
13211 Rename or move locals to avoid shadowing.
6b463e58 13212 (tty_defined_color, merge_face_heights): Now static.
5967d051 13213 (free_realized_faces_for_fontset): Remove; not used.
1e9966ea
PE
13214 (Fx_list_fonts): Mark variable that gcc -Wuninitialized
13215 does not deduce is never used uninitialized.
73719eba
PE
13216 (STRDUPA, LSTRDUPA, FONT_POINT_SIZE_QUANTUM): Remove; not used.
13217 (LFACEP): Define only if XASSERTS, as it's not needed otherwise.
071048a3 13218
426994c3 13219 * terminal.c (store_terminal_param): Now static.
5489860b 13220
032f1620 13221 * xmenu.c (menu_highlight_callback): Now static.
9d66f88e 13222 (set_frame_menubar): Remove unused local.
d4323972 13223 (xmenu_show): Rename parameter to avoid shadowing.
6d1f7fee
PE
13224 (xmenu_show, xdialog_show, xmenu_show): Make local pointers "const"
13225 since they might point to immutable storage.
281585b0
PE
13226 (next_menubar_widget_id): Declare only if USE_X_TOOLKIT,
13227 since it's unused otherwise.
032f1620 13228
367c19e5 13229 * xdisp.c (produce_glyphless_glyph): Initialize lower_xoff.
53df7c11 13230 Add a FIXME, since the code still doesn't look right. (Bug#8215)
9f36b9fd
PE
13231 (Fcurrent_bidi_paragraph_direction): Simplify slightly; this
13232 avoids a gcc -Wuninitialized diagnostic.
0e086e8f 13233 (display_line, BUILD_COMPOSITE_GLYPH_STRING, draw_glyphs):
44a3a108
PE
13234 (note_mouse_highlight): Mark variables that gcc -Wuninitialized
13235 does not deduce are never used uninitialized.
70739cbe 13236
07b48fa9
PE
13237 * lisp.h (IF_LINT): New macro, copied from ../lib-src/emacsclient.c.
13238
8868a238 13239 * xdisp.c (redisplay_window): Rename local to avoid shadowing.
4554d213
PE
13240 * window.c (window_loop, size_window):
13241 (run_window_configuration_change_hook, enlarge_window): Likewise.
8868a238 13242
7e5cf297 13243 * window.c (display_buffer): Now static.
d6550a9f
PE
13244 (size_window): Mark variables that gcc -Wuninitialized
13245 does not deduce are never used uninitialized.
a586633d
PE
13246 * window.h (check_all_windows): New decl, to forestall
13247 gcc -Wmissing-prototypes diagnostic.
5b555da1 13248 * dispextern.h (bidi_dump_cached_states): Likewise.
7e5cf297 13249
f6095868
PE
13250 * charset.h (CHECK_CHARSET_GET_CHARSET): Rename locals to avoid
13251 shadowing.
13252 * charset.c (map_charset_for_dump, Fchar_charset): Likewise.
726929c4
PE
13253 Include <limits.h>.
13254 (Fsort_charsets): Redo min/max calculation to shorten the code a bit
13255 and to avoid gcc -Wuninitialized warning.
89ef49df
PE
13256 (load_charset_map): Mark variables that gcc -Wuninitialized
13257 does not deduce are never used uninitialized.
53df7c11 13258 (load_charset): Abort instead of using uninitialized var (Bug#8229).
f6095868 13259
f38b440c
PE
13260 * coding.c (coding_set_source, coding_set_destination):
13261 Use "else { /* comment */ }" rather than "else /* comment */;"
13262 for clarity, and to avoid gcc -Wempty-body warning.
2735d060
PE
13263 (Fdefine_coding_system_internal): Don't redeclare 'i' inside
13264 a block, when the outer 'i' will do.
13265 (decode_coding_utf_8, decode_coding_utf_16, detect_coding_emacs_mule):
13266 (emacs_mule_char, decode_coding_emacs_mule, detect_coding_iso_2022):
13267 (decode_coding_iso_2022, decode_coding_sjis, decode_coding_big5):
13268 (decode_coding_raw_text, decode_coding_charset, get_translation_table):
13269 (Fdecode_sjis_char, Fdefine_coding_system_internal):
13270 Rename locals to avoid shadowing.
13271 * character.h (FETCH_STRING_CHAR_ADVANCE): Likewise.
e2f1bab9
PE
13272 * coding.c (emacs_mule_char, encode_invocation_designation):
13273 Now static, since they're not used elsewhere.
413bb2db 13274 (decode_coding_iso_2022): Add "default: abort ();" as a safety check.
c4a63b12 13275 (decode_coding_object, encode_coding_object, detect_coding_system):
ee05f961
PE
13276 (decode_coding_emacs_mule): Mark variables that gcc
13277 -Wuninitialized does not deduce are never used uninitialized.
160b01f6
PE
13278 (detect_coding_iso_2022): Initialize a local variable that might
13279 be used uninitialized. Leave a FIXME because it's not clear that
53df7c11 13280 this initialization is needed. (Bug#8211)
5f58e762
PE
13281 (ISO_CODE_LF, ISO_CODE_CR, CODING_ISO_FLAG_EUC_TW_SHIFT):
13282 (ONE_MORE_BYTE_NO_CHECK, UTF_BOM, UTF_16_INVALID_P):
13283 (SHIFT_OUT_OK, ENCODE_CONTROL_SEQUENCE_INTRODUCER):
13284 (ENCODE_DIRECTION_R2L, ENCODE_DIRECTION_L2R):
13285 Remove unused macros.
f38b440c 13286
232b38b9 13287 * category.c (hash_get_category_set): Remove unused local var.
9f3b5e69 13288 (copy_category_table): Now static, since it's not used elsewhere.
d0891610 13289 * character.c (string_count_byte8): Likewise.
232b38b9 13290
fb90da1b
PE
13291 * ccl.c (CCL_WRITE_STRING, CCL_ENCODE_CHAR, Fccl_execute_on_string):
13292 (Fregister_code_conversion_map): Rename locals to avoid shadowing.
13293
fb93dbc2
PE
13294 * chartab.c (copy_sub_char_table): Now static, since it's not used
13295 elsewhere.
5c156ace
PE
13296 (sub_char_table_ref_and_range, char_table_ref_and_range):
13297 Rename locals to avoid shadowing.
bbcd0949 13298 (ASET_RANGE, GET_SUB_CHAR_TABLE): Remove unused macros.
fb93dbc2 13299
7d3b3862 13300 * bidi.c (bidi_check_type): Now static, since it's not used elsewhere.
630d6892 13301 (BIDI_BOB): Remove unused macro.
7d3b3862 13302
6be7d3da
PE
13303 * cm.c (cmgoto): Mark variables that gcc -Wuninitialized does not
13304 deduce are never used uninitialized.
c2ed9c8b 13305 * term.c (encode_terminal_code): Likewise.
6be7d3da 13306
75f8807f 13307 * term.c (encode_terminal_code): Now static. Remove unused local.
72abad34 13308
50938595
PE
13309 * tparam.h: New file.
13310 * term.c, tparam.h: Include it.
13311 * deps.mk (term.o, tparam.o): Depend on tparam.h.
13312 * term.c (tputs, tgetent, tgetflag, tgetnum, tparam, tgetstr):
13313 Move these decls to tparam.h, and make them agree with what
13314 is actually in tparam.c. The previous trick of using incompatible
13315 decls in different modules does not conform to the C standard.
13316 All callers of tparam changed to use tparam's actual API.
13317 * tparam.c (tparam1, tparam, tgoto):
13318 Use const pointers where appropriate.
13319
fbceeba2
PE
13320 * cm.c (calccost, cmgoto): Use const pointers where appropriate.
13321 * cm.h (struct cm): Likewise.
13322 * dispextern.h (do_line_insertion_deletion_costs): Likewise.
13323 * scroll.c (ins_del_costs, do_line_insertion_deletion_costs): Likewise.
13324 * term.c (tty_ins_del_lines, calculate_costs, struct fkey_table):
13325 (term_get_fkeys_1, append_glyphless_glyph, produce_glyphless_glyph):
13326 (turn_on_face, init_tty): Likewise.
13327 * termchar.h (struct tty_display_info): Likewise.
fbceeba2 13328
7f3f1250
PE
13329 * term.c (term_mouse_position): Rename local to avoid shadowing.
13330
e6ca6543
PE
13331 * alloc.c (mark_ttys): Move decl from here ...
13332 * lisp.h (mark_ttys): ... to here, so that it's checked against defn.
13333
c40f8d15
AS
133342011-03-11 Andreas Schwab <schwab@linux-m68k.org>
13335
13336 * .gdbinit (pwinx, xbuffer): Fix access to buffer name.
13337
cfe0661d
JB
133382011-03-09 Juanma Barranquero <lekktu@gmail.com>
13339
13340 * search.c (compile_pattern_1): Remove argument regp, unused since
13341 revid:rms@gnu.org-19941211082627-3x1g1wyqkjmwloig.
13342 (compile_pattern): Don't pass it.
13343
0afb4571
J
133442011-03-08 Jan Djärv <jan.h.d@swipnet.se>
13345
13346 * xterm.h (DEFAULT_GDK_DISPLAY): New define.
13347 (GDK_WINDOW_XID, gtk_widget_get_preferred_size): New defines
13348 for ! HAVE_GTK3.
13349 (GTK_WIDGET_TO_X_WIN): Use GDK_WINDOW_XID.
13350
13351 * xmenu.c (menu_position_func): Call gtk_widget_get_preferred_size.
13352
13353 * gtkutil.c: Include gtkx.h if HAVE_GTK3. If ! HAVE_GTK3, define
13354 gdk_window_get_screen, gdk_window_get_geometry,
13355 gdk_x11_window_lookup_for_display and GDK_KEY_g.
13356 (xg_set_screen): Use DEFAULT_GDK_DISPLAY.
13357 (xg_get_pixbuf_from_pixmap): New function.
13358 (xg_get_pixbuf_from_pix_and_mask): Change parameters from GdkPixmap
13359 to Pixmap, take frame as parameter, remove GdkColormap parameter.
13360 Call xg_get_pixbuf_from_pixmap instead of
13361 gdk_pixbuf_get_from_drawable.
13362 (xg_get_image_for_pixmap): Do not make GdkPixmaps, call
13363 xg_get_pixbuf_from_pix_and_mask with Pixmap parameters instead.
13364 (xg_check_special_colors): Use GtkStyleContext and its functions
13365 for HAVE_GTK3.
13366 (xg_prepare_tooltip, xg_hide_tooltip): Call gdk_window_get_screen.
13367 (xg_prepare_tooltip, create_dialog, menubar_map_cb)
13368 (xg_update_frame_menubar, xg_tool_bar_detach_callback)
44f230aa
SM
13369 (xg_tool_bar_attach_callback, xg_update_tool_bar_sizes):
13370 Call gtk_widget_get_preferred_size.
0afb4571
J
13371 (xg_frame_resized): gdk_window_get_geometry only takes 5
13372 parameters.
44f230aa
SM
13373 (xg_win_to_widget, xg_event_is_for_menubar):
13374 Call gdk_x11_window_lookup_for_display.
0afb4571
J
13375 (xg_set_widget_bg): New function.
13376 (delete_cb): New function.
895009e1 13377 (xg_create_frame_widgets): Connect delete-event to delete_cb.
5c32d3f2 13378 Call xg_set_widget_bg. Only set background pixmap for ! HAVE_GTK3
0afb4571
J
13379 (xg_set_background_color): Call xg_set_widget_bg.
13380 (xg_set_frame_icon): Call xg_get_pixbuf_from_pix_and_mask.
13381 (xg_create_scroll_bar): vadj is a GtkAdjustment for HAVE_GTK3.
13382 Only call gtk_range_set_update_policy if ! HAVE_GTK3.
13383 (xg_make_tool_item): Only connect xg_tool_bar_item_expose_callback
13384 if ! HAVE_GTK3.
13385 (update_frame_tool_bar): Call gtk_widget_hide.
13386 (xg_initialize): Use GDK_KEY_g.
13387
13388 * xsmfns.c (gdk_set_sm_client_id): Define to gdk_set_sm_client_id
13389 if ! HAVE_GTK3
13390 (x_session_initialize): Call gdk_x11_set_sm_client_id.
13391
13392 * xterm.c (XFillRectangle): Use cairo routines for HAVE_GTK3.
13393 (x_term_init): Disable Xinput(2) with GDK_CORE_DEVICE_EVENTS.
13394 Load ~/emacs.d/gtkrc only for ! HAVE_GTK3.
13395
1c2cc4ef
JB
133962011-03-08 Juanma Barranquero <lekktu@gmail.com>
13397
13398 * w32xfns.c (select_palette): Check success of RealizePalette against
13399 GDI_ERROR, not zero.
13400
33383987 13401See ChangeLog.11 for earlier changes.
aac0c6e3
MR
13402
13403;; Local Variables:
13404;; coding: utf-8
aac0c6e3
MR
13405;; End:
13406
2f097256 13407 Copyright (C) 2011-2012 Free Software Foundation, Inc.
aac0c6e3
MR
13408
13409 This file is part of GNU Emacs.
13410
13411 GNU Emacs is free software: you can redistribute it and/or modify
13412 it under the terms of the GNU General Public License as published by
13413 the Free Software Foundation, either version 3 of the License, or
13414 (at your option) any later version.
13415
13416 GNU Emacs is distributed in the hope that it will be useful,
13417 but WITHOUT ANY WARRANTY; without even the implied warranty of
13418 MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
13419 GNU General Public License for more details.
13420
13421 You should have received a copy of the GNU General Public License
13422 along with GNU Emacs. If not, see <http://www.gnu.org/licenses/>.