* lread.c (syms_of_lread): Clarify when `lexical-binding' is used
[bpt/emacs.git] / src / ChangeLog
CommitLineData
f41628b2
LMI
12011-07-19 Lars Magne Ingebrigtsen <larsi@gnus.org>
2
3 * lread.c (syms_of_lread): Clarify when `lexical-binding' is used
4 (bug#8460).
5
b59b67c5
PE
62011-07-18 Paul Eggert <eggert@cs.ucla.edu>
7
15e3a074
PE
8 * fileio.c (Fcopy_file) [!MSDOS]: Tighten created file's mask.
9 This fixes some race conditions on the permissions of any newly
10 created file.
11
41bed37d
PE
12 * alloc.c (valid_pointer_p): Use pipe, not open.
13 This fixes some permissions issues when debugging.
14
b59b67c5
PE
15 * fileio.c (Fcopy_file): Adjust mode if fchown fails. (Bug#9002)
16 If fchown fails to set both uid and gid, try to set just gid,
17 as that is sometimes allowed. Adjust the file's mode to eliminate
18 setuid or setgid bits that are inappropriate if fchown fails.
19
925a6be7
SM
202011-07-18 Stefan Monnier <monnier@iro.umontreal.ca>
21
22 * xdisp.c (next_element_from_string, next_element_from_buffer): Use EQ
23 to compare Lisp_Objects.
24 * gnutls.c (syms_of_gnutls): Rename Vgnutls_log_level to
25 global_gnutls_log_level, don't mistake it for a Lisp_Object.
26 (init_gnutls_functions, emacs_gnutls_handle_error): Fix up uses.
27
52968808
AS
282011-07-17 Andreas Schwab <schwab@linux-m68k.org>
29
0a6a104b
AS
30 * lread.c (read_integer): Unread even EOF character.
31 (read1): Likewise. Properly record start position of symbol.
32
52968808
AS
33 * lread.c (read1): Read `#:' as empty uninterned symbol if no
34 symbol character follows.
35
9e381cdd
PE
362011-07-17 Paul Eggert <eggert@cs.ucla.edu>
37
38 * fileio.c (Fcopy_file): Pacify gcc re fchown. (Bug#9002)
39 This works around a problem with the previous change to Fcopy_file.
40 Recent glibc declares fchown with __attribute__((warn_unused_result)),
41 and without this change, GCC might complain about discarding
42 fchown's return value.
43
b5641435
JB
442011-07-16 Juanma Barranquero <lekktu@gmail.com>
45
46 * makefile.w32-in (GLOBAL_SOURCES): Add gnutls.c (followup to bug#9059).
47
a8031457
PE
482011-07-16 Paul Eggert <eggert@cs.ucla.edu>
49
50 * fileio.c (Fcopy_file): Don't diagnose fchown failures. (Bug#9002)
51
dd889327
LMI
522011-07-16 Lars Magne Ingebrigtsen <larsi@gnus.org>
53
750c33f7
LMI
54 * gnutls.c (syms_of_gnutls): Define `gnutls-log-level' here, since
55 it's used from the C level.
56
dd889327
LMI
57 * process.c: Use the same condition for POLL_FOR_INPUT in both
58 keyboard.c and process.c (bug#1858).
59
87e86684
LM
602011-07-09 Lawrence Mitchell <wence@gmx.li>
61
62 * gnutls.c (Qgnutls_bootprop_min_prime_bits): New variable.
63 (Fgnutls_boot): Use it.
64
64348f40
AS
652011-07-15 Andreas Schwab <schwab@linux-m68k.org>
66
67 * doc.c (Fsubstitute_command_keys): Revert last change.
68
1d698799
LMI
692011-07-15 Lars Magne Ingebrigtsen <larsi@gnus.org>
70
f863868c
LMI
71 * doc.c (Fsubstitute_command_keys): Clarify that \= really only
72 quotes the next character, and doesn't affect other longer
73 sequences (bug#8935).
74
1d698799
LMI
75 * lread.c (syms_of_lread): Clarify that is isn't only
76 `eval-buffer' and `eval-defun' that's affected by
77 `lexical-binding' (bug#8460).
78
aa4b6df6
EZ
792011-07-15 Eli Zaretskii <eliz@gnu.org>
80
81 * xdisp.c (move_it_in_display_line_to): Fix vertical motion with
82 bidi redisplay when a line includes both an image and is
83 truncated.
84
5d856da6
PE
852011-07-14 Paul Eggert <eggert@cs.ucla.edu>
86
ad6042bb
PE
87 Fix minor problems found by static checking.
88 * bidi.c (bidi_cache_size): Now EMACS_INT, not size_t.
89 (elsz): Now a signed constant, not a size_t var. We prefer signed
90 types to unsigned, to avoid integer comparison confusion. Without
91 this change, GCC 4.6.1 with -Wunsafe-loop-optimizations complains
92 "cannot optimize loop, the loop counter may overflow", a symptom
93 of the confusion.
f00bbb22 94 * indent.c (Fvertical_motion): Mark locals as initialized.
5d856da6
PE
95 * xdisp.c (reseat_to_string): Fix pointer signedness issue.
96
6468f31c
LMI
972011-07-14 Lars Magne Ingebrigtsen <larsi@gnus.org>
98
49080b10
LMI
99 * search.c (Fre_search_backward): Mention `case-fold-search' in
100 all the re_search_* functions (bug#8138).
101
6468f31c
LMI
102 * keyboard.c (Fopen_dribble_file): Document when the file is
103 closed (bug#8056).
104
c965adc5
EZ
1052011-07-14 Eli Zaretskii <eliz@gnu.org>
106
df9733bf
EZ
107 * bidi.c (bidi_dump_cached_states): Fix format of displaying
108 bidi_cache_idx.
109
0bb23927
EZ
110 Support bidi reordering of display and overlay strings.
111 * xdisp.c (compute_display_string_pos)
112 (compute_display_string_end): Accept additional argument STRING.
113 (init_iterator, reseat_1): Initialize bidi_it->string.s to NULL.
114 (reseat_to_string): Initialize bidi_it->string.s and
115 bidi_it->string.schars.
116 (Fcurrent_bidi_paragraph_direction): Initialize itb.string.s to
117 NULL (avoids a crash in bidi_paragraph_init). Initialize
118 itb.string.lstring.
119 (init_iterator): Call bidi_init_it only of a valid
120 buffer position was specified. Initialize paragraph_embedding to
121 L2R.
122 (reseat_to_string): Initialize the bidi iterator.
123 (display_string): If we need to ignore text properties of
124 LISP_STRING, set IT->stop_charpos to IT->end_charpos. (The
125 original value of -1 will not work with bidi.)
126 (compute_display_string_pos): First arg is now struct
127 `text_pos *'; all callers changed. Support display properties on
128 Lisp strings.
129 (compute_display_string_end): Support display properties on Lisp
130 strings.
131 (init_iterator, reseat_1, reseat_to_string): Initialize the
132 string.bufpos member to 0 (zero, for compatibility with IT_CHARPOS
133 when iterating on a string not from display properties).
134 (compute_display_string_pos, compute_display_string_end): Fix
135 calculation of the object to scan. Fixes an error when using
136 arrow keys.
137 (next_element_from_buffer): Don't abort when IT_CHARPOS is before
138 base_level_stop; instead, set base_level_stop to BEGV. Fixes
139 crashes in vertical-motion.
140 (next_element_from_buffer): Improve commentary for when
141 the iterator is before prev_stop.
142 (init_iterator): Initialize bidi_p from the default value of
143 bidi-display-reordering, not from buffer-local value. Use the
144 buffer-local value only if initializing for buffer iteration.
145 (handle_invisible_prop): Support invisible properties on strings
146 that are being bidi-reordered.
147 (set_iterator_to_next): Support bidi reordering of C strings and
148 Lisp strings.
149 (next_element_from_string): Support bidi reordering of Lisp
150 strings.
151 (handle_stop_backwards): Support Lisp strings as well.
152 (display_string): Support display of R2L glyph rows. Use
153 IT_STRING_CHARPOS when displaying from a Lisp string.
154 (init_iterator): Don't initialize it->bidi_p for strings
155 here.
156 (reseat_to_string): Initialize it->bidi_p for strings here.
157 (next_element_from_string, next_element_from_c_string)
158 (next_element_from_buffer): Add xassert's for correspondence
159 between IT's object being iterated and it->bidi_it.string
160 structure.
161 (face_before_or_after_it_pos): Support bidi iteration.
162 (next_element_from_c_string): Handle the case of the first string
163 character that is not the first one in the visual order.
164 (get_visually_first_element): New function, refactored from common
165 parts of next_element_from_buffer, next_element_from_string, and
166 next_element_from_c_string.
167 (tool_bar_lines_needed, redisplay_tool_bar)
168 (display_menu_bar): Force left-to-right direction. Add a FIXME
169 comment for making that be controlled by a user option.
170 (push_it, pop_it): Save and restore the state of the
171 bidi iterator. Save and restore the bidi_p flag.
172 (pop_it): Iterate out of display property for string iteration as
173 well.
174 (iterate_out_of_display_property): Support iteration over strings.
175 (handle_single_display_spec): Set up it->bidi_it for iteration
176 over a display string, and call bidi_init_it.
177 (handle_single_display_spec, next_overlay_string)
178 (get_overlay_strings_1, push_display_prop): Set up the bidi
179 iterator for displaying display or overlay strings.
180 (forward_to_next_line_start): Don't use the shortcut if
181 bidi-iterating.
182 (back_to_previous_visible_line_start): If handle_display_prop
183 pushed the iterator stack, restore the internal state of the bidi
184 iterator by calling bidi_pop_it same number of times.
185 (reseat_at_next_visible_line_start): If ON_NEWLINE_P is non-zero,
186 and we are bidi-iterating, don't decrement the iterator position;
187 instead, set the first_elt flag in the bidi iterator, to produce
188 the same effect.
189 (reseat_1): Remove redundant setting of string_from_display_prop_p.
190 (push_display_prop): xassert that we are iterating a buffer.
191 (push_it, pop_it): Save and restore paragraph_embedding member.
192 (handle_single_display_spec, next_overlay_string)
193 (get_overlay_strings_1, reseat_1, reseat_to_string)
194 (push_display_prop): Set up the `unibyte' member of bidi_it.string
195 correctly. Don't assume unibyte strings are not bidi-reordered.
196 (compute_display_string_pos)
197 (compute_display_string_end): Fix handling the case of C string.
198 (push_it, pop_it): Save and restore from_disp_prop_p.
199 (handle_single_display_spec, push_display_prop): Set the
200 from_disp_prop_p flag.
201 (get_overlay_strings_1): Reset the from_disp_prop_p flag.
202 (pop_it): Call iterate_out_of_display_property only if we are
203 popping after iteration over a string that came from a display
204 property. Fix a typo in popping stretch info. Add an assertion
205 for verifying that the iterator position is in sync with the bidi
206 iterator.
207 (handle_single_display_spec, get_overlay_strings_1)
208 (push_display_prop): Fix initialization of paragraph direction for
209 string when that of the parent object is not yet determined.
210 (reseat_1): Call bidi_init_it to resync the bidi
211 iterator with IT's position. (Bug#7616)
212 (find_row_edges): If ROW->start.pos gives position
213 smaller than min_pos, use it as ROW->minpos. (Bug#7616)
214 (handle_stop, back_to_previous_visible_line_start, reseat_1):
215 Reset the from_disp_prop_p flag.
216 (SAVE_IT, RESTORE_IT): New macros.
217 (pos_visible_p, face_before_or_after_it_pos)
218 (back_to_previous_visible_line_start)
219 (move_it_in_display_line_to, move_it_in_display_line)
220 (move_it_to, move_it_vertically_backward, move_it_by_lines)
221 (try_scrolling, redisplay_window, display_line): Use them when
222 saving a temporary copy of the iterator and restoring it back.
223 (back_to_previous_visible_line_start, reseat_1)
224 (init_iterator): Empty the bidi cache "stack".
225 (move_it_in_display_line_to): If iterator ended up at
226 EOL, but we never saw any buffer positions smaller than
227 to_charpos, return MOVE_POS_MATCH_OR_ZV. Fixes vertical cursor
228 motion in bidi-reordered lines.
229 (move_it_in_display_line_to): Record prev_method and prev_pos
230 immediately before the call to set_iterator_to_next. Fixes cursor
231 motion in bidi-reordered lines with stretch glyphs and strings
232 displayed in margins. (Bug#8133) (Bug#8867)
233 Return MOVE_POS_MATCH_OR_ZV only if iterator position is past
234 TO_CHARPOS.
235 (pos_visible_p): Support positions in bidi-reordered lines. Save
236 and restore bidi cache.
237
238 * bidi.c (bidi_level_of_next_char): clen should be EMACS_NT, not int.
239 (bidi_paragraph_info): Delete unused struct.
240 (bidi_cache_idx, bidi_cache_last_idx): Declare EMACS_INT.
241 (bidi_cache_start): New variable.
242 (bidi_cache_reset): Reset bidi_cache_idx to bidi_cache_start, not
243 to zero.
244 (bidi_cache_fetch_state, bidi_cache_search)
245 (bidi_cache_find_level_change, bidi_cache_iterator_state)
246 (bidi_cache_find, bidi_peek_at_next_level)
247 (bidi_level_of_next_char, bidi_find_other_level_edge)
248 (bidi_move_to_visually_next): Compare cache index with
249 bidi_cache_start rather than with zero.
250 (bidi_fetch_char): Accept new argument STRING; all callers
251 changed. Support iteration over a string. Support strings with
252 display properties. Support unibyte strings. Fix the type of
253 `len' according to what STRING_CHAR_AND_LENGTH expects.
254 (bidi_paragraph_init, bidi_resolve_explicit_1)
255 (bidi_resolve_explicit, bidi_resolve_weak)
256 (bidi_level_of_next_char, bidi_move_to_visually_next): Support
257 iteration over a string.
258 (bidi_set_sor_type, bidi_resolve_explicit_1)
259 (bidi_resolve_explicit, bidi_type_of_next_char): ignore_bn_limit
260 can now be zero (for strings); special values 0 and -1 were
261 changed to -1 and -2, respectively.
262 (bidi_char_at_pos): New function.
263 (bidi_paragraph_init, bidi_resolve_explicit, bidi_resolve_weak):
264 Call it instead of FETCH_MULTIBYTE_CHAR.
265 (bidi_move_to_visually_next): Abort if charpos or bytepos were not
266 initialized to valid values.
267 (bidi_init_it): Don't initialize charpos and bytepos with invalid
268 values.
269 (bidi_level_of_next_char): Allow the sentinel "position" to pass
270 the test for valid cached positions. Fix the logic for looking up
271 the sentinel state in the cache. GCPRO the Lisp string we are
272 iterating.
273 (bidi_push_it, bidi_pop_it): New functions.
274 (bidi_initialize): Initialize the bidi cache start stack pointer.
275 (bidi_cache_ensure_space): New function, refactored from part of
276 bidi_cache_iterator_state. Don't assume the required size is just
277 one BIDI_CACHE_CHUNK away.
278 (bidi_cache_start_stack, bidi_push_it): Use IT_STACK_SIZE.
279 (bidi_count_bytes, bidi_char_at_pos): New functions.
280 (bidi_cache_search): Don't assume bidi_cache_last_idx is
281 always valid if bidi_cache_idx is valid.
282 (bidi_cache_find_level_change): xassert that bidi_cache_last_idx
283 is valid if it's going to be used.
284 (bidi_shelve_cache, bidi_unshelve_cache): New functions.
285 (bidi_cache_fetch_state, bidi_cache_search)
c965adc5
EZ
286 (bidi_cache_find_level_change, bidi_cache_ensure_space)
287 (bidi_cache_iterator_state, bidi_cache_find)
288 (bidi_find_other_level_edge, bidi_cache_start_stack): All
289 variables related to cache indices are now EMACS_INT.
290
0bb23927
EZ
291 * dispextern.h (struct bidi_string_data): New structure.
292 (struct bidi_it): New member `string'. Make flag members be 1-bit
293 fields, and put them last in the struct.
294 (compute_display_string_pos, compute_display_string_end): Update
295 prototypes.
296 (bidi_push_it, bidi_pop_it): Add prototypes.
297 (struct iterator_stack_entry): New members bidi_p,
298 paragraph_embedding, and from_disp_prop_p.
299 (struct it): Member bidi_p is now a bit field 1 bit wide.
300 (bidi_shelve_cache, bidi_unshelve_cache): Declare
301 prototypes.
302
303 * .gdbinit (xvectype, xvector, xcompiled, xchartable, xboolvector)
304 (xpr, xfont, xbacktrace): Use "header.size" when accessing vectors
305 and vector-like objects.
306
307 * dispnew.c (buffer_posn_from_coords): Save and restore the bidi
308 cache around display iteration.
309
310 * window.c (Fwindow_end, window_scroll_pixel_based)
311 (displayed_window_lines, Frecenter): Save and restore the bidi
312 cache around display iteration.
313
3bbd2265
LMI
3142011-07-14 Lars Magne Ingebrigtsen <larsi@gnus.org>
315
316 * editfns.c (Fdelete_region): Clarify the use of the named
317 parameters (bug#6788).
318
adc47434
MR
3192011-07-14 Martin Rudalics <rudalics@gmx.at>
320
321 * indent.c (Fvertical_motion): Set and restore w->pointm when
322 saving and restoring the window's buffer (Bug#9006).
323
837c31f8
LMI
3242011-07-13 Lars Magne Ingebrigtsen <larsi@gnus.org>
325
326 * editfns.c (Fstring_to_char): Clarify just what is returned
327 (bug#6576). Text by Eli Zaretskii.
328
ac389d0c
JB
3292011-07-13 Juanma Barranquero <lekktu@gmail.com>
330
331 * gnutls.c (init_gnutls_functions): Honor gnutls_log_level (bug#9059).
332
0be0ce47
EZ
3332011-07-13 Eli Zaretskii <eliz@gnu.org>
334
335 * buffer.c (mmap_find): Fix a typo.
336
cd18e7e3
JB
3372011-07-13 Johan Bockgård <bojohan@gnu.org>
338
339 Fix execution of x selection hooks.
340 * xselect.c (Qx_lost_selection_functions)
341 (Qx_sent_selection_functions): New vars.
342 (syms_of_xselect): DEFSYM them.
343 (x_handle_selection_request): Pass Qx_sent_selection_functions
344 rather than Vx_sent_selection_functions to Frun_hook_with_args.
345 (x_handle_selection_clear,x_clear_frame_selections):
346 Pass Qx_lost_selection_functions rather than
347 Vx_lost_selection_functions to Frun_hook_with_args.
348
47ea7f44
PE
3492011-07-13 Paul Eggert <eggert@cs.ucla.edu>
350
ac389d0c 351 * buffer.c (Fget_buffer_create): Initialize inhibit_shrinking.
2941c447
PE
352 The old code sometimes used this field without initializing it.
353
47ea7f44
PE
354 * alloc.c (gc_sweep): Don't read past end of array.
355 In theory, the old code could also have corrupted Emacs internals,
356 though it'd be very unlikely.
357
bc985c87
AS
3582011-07-12 Andreas Schwab <schwab@linux-m68k.org>
359
360 * character.c (Fcharacterp): Don't advertise optional ignored
ac389d0c 361 argument. (Bug#4026)
bc985c87 362
0cf34688
LMI
3632011-07-12 Lars Magne Ingebrigtsen <larsi@gnus.org>
364
b3dadd76
LMI
365 * keymap.c (syms_of_keymap): Clarify that "modifier" is "modifier
366 key" (bug#4257).
367
0cf34688
LMI
368 * window.c (Fset_window_start): Doc fix (bug#4199).
369 (Fset_window_hscroll): Ditto.
370
270768cd
PE
3712011-07-12 Paul Eggert <eggert@cs.ucla.edu>
372
077e3dda 373 Fix minor new problems caught by GCC 4.6.1.
270768cd 374 * term.c (init_tty): Remove unused local.
490011a6 375 * xsettings.c (store_monospaced_changed): Define this function only
077e3dda 376 if (defined HAVE_GSETTINGS || defined HAVE_GCONF), as it's
490011a6 377 not used otherwise.
270768cd 378
b1f58454
CY
3792011-07-12 Chong Yidong <cyd@stupidchicken.com>
380
381 * xdisp.c (Vresize_mini_windows): Minor doc fix (Bug#3300).
382
22b9578d
LMI
3832011-07-11 Lars Magne Ingebrigtsen <larsi@gnus.org>
384
6e70ab07
LMI
385 * xdisp.c (syms_of_xdisp): Make it explicit that the mini-windows
386 are the mini-buffer and the echo area (bug#3320).
387
22b9578d
LMI
388 * term.c (init_tty): Remove support for supdup, c10 and perq
389 terminals, which are no longer supported (bug#1482).
390
8974cc9f
JB
3912011-07-10 Johan Bockgård <bojohan@gnu.org>
392
393 * xdisp.c (Ftool_bar_lines_needed): Fix WINDOWP check.
394
a560d974
JD
3952011-07-10 Jan Djärv <jan.h.d@swipnet.se>
396
397 * xmenu.c (menu_highlight_callback): Only pass frame to show_help_event
398 for non-popups (Bug#3642).
399
1dae0f0a
AS
4002011-07-10 Andreas Schwab <schwab@linux-m68k.org>
401
268c2c36 402 * alloc.c (reset_malloc_hooks): Protoize.
1dae0f0a 403 * buffer.c (mmap_init, mmap_find, mmap_free_1, mmap_enlarge)
268c2c36
AS
404 (mmap_set_vars, mmap_alloc, mmap_free, mmap_realloc): Likewise.
405 * cm.c (losecursor): Likewise.
1dae0f0a
AS
406 * data.c (fmod): Likewise.
407 * dispnew.c (swap_glyphs_in_rows): Likewise.
408 * emacs.c (memory_warning_signal): Likewise.
409 * floatfns.c (float_error): Likewise.
410 * font.c (check_gstring, check_otf_features, otf_tag_symbol)
411 (otf_open, font_otf_capability, generate_otf_features)
412 (font_otf_DeviceTable, font_otf_ValueRecord, font_otf_Anchor):
413 Likewise.
414 * image.c (pbm_read_file): Likewise.
415 * indent.c (string_display_width): Likewise.
416 * intervals.c (check_for_interval, search_for_interval)
417 (inc_interval_count, count_intervals, root_interval)
418 (adjust_intervals_for_insertion, make_new_interval): Likewise.
419 * lread.c (defalias): Likewise.
268c2c36 420 * ralloc.c (r_alloc_check): Likewise.
1dae0f0a
AS
421 * regex.c (set_image_of_range_1, set_image_of_range)
422 (regex_grow_registers): Likewise.
423 * sysdep.c (strerror): Likewise.
424 * termcap.c (valid_filename_p, tprint, main): Likewise.
425 * tparam.c (main): Likewise.
426 * unexhp9k800.c (run_time_remap, save_data_space)
427 (update_file_ptrs, read_header, write_header, calculate_checksum)
428 (copy_file, copy_rest, display_header): Likewise.
429 * widget.c (mark_shell_size_user_specified, create_frame_gcs):
430 Likewise.
431 * xdisp.c (check_it): Likewise.
432 * xfaces.c (register_color, unregister_color, unregister_colors):
433 Likewise.
434 * xfns.c (print_fontset_result): Likewise.
435 * xrdb.c (member, fatal, main): Likewise.
436
99033785
PE
4372011-07-10 Paul Eggert <eggert@cs.ucla.edu>
438
439 Fix minor problems found by static checking (Bug#9031).
440 * chartab.c (char_table_set_range, map_sub_char_table):
441 Remove unused locals.
442 (uniprop_table): Now static.
443 * composite.c (_work_char): Remove unused static var.
444
9cb2ac56
JB
4452011-07-09 Juanma Barranquero <lekktu@gmail.com>
446
447 * chartab.c (uniprop_table_uncompress): Remove unused local variable.
448
f25661f0
JD
4492011-07-09 Jan Djärv <jan.h.d@swipnet.se>
450
451 * gtkutil.c (qttip_cb): Remove code without function.
452
8278c4fe
EZ
4532011-07-09 Eli Zaretskii <eliz@gnu.org>
454
455 * w32.c (pthread_sigmask): New stub.
456
1692ae2d 4572011-07-08 Paul Eggert <eggert@cs.ucla.edu>
123403e4 458
8a6ebd58 459 Use pthread_sigmask, not sigprocmask (Bug#9010).
123403e4
PE
460 sigprocmask is portable only for single-threaded applications, and
461 Emacs can be multi-threaded when it uses GTK.
1301ac26
PE
462 * Makefile.in (LIB_PTHREAD_SIGMASK): New macro.
463 (LIBES): Use it.
464 * callproc.c (Fcall_process):
465 * process.c (create_process):
466 * sysdep.c (sys_sigblock, sys_sigunblock, sys_sigsetmask):
467 Use pthread_sigmask, not sigprocmask.
123403e4 468
1b854618
JD
4692011-07-08 Jan Djärv <jan.h.d@swipnet.se>
470
471 * gtkutil.c (qttip_cb): Set line wrap to FALSE for tooltip widget.
472 (xg_prepare_tooltip): Revert text in x->ttip_lbl, margins was
473 wrong (Bug#8591).
474
3fe4b549
JD
4752011-07-08 Jan Djärv <jan.h.d@swipnet.se>
476
0ce7e563
JD
477 * gtkutil.c (xg_prepare_tooltip): Fix indentation and comment.
478 Put text in x->ttip_lbl instead of gtk_tooltip_set_text (Bug#8591).
479 (xg_hide_tooltip): Fix comment.
480
3fe4b549
JD
481 * nsterm.m (initFrameFromEmacs): Don't use ns_return_types
482 in registerServicesMenuSendTypes.
483 (validRequestorForSendType): Don't check ns_return_types.
484
485 * nsfns.m (Fx_open_connection): Put NSStringPboardType into
486 ns_return_type.
487
5df75e47
JR
4882011-07-08 Jason Rumney <jasonr@gnu.org>
489
490 * w32fns.c (w32_wnd_proc) [WM_TIMER, WM_SET_CURSOR]: Avoid using
491 frame struct members of non-existent frames (Bug#6284).
492
699c10bd
JD
4932011-07-08 Jan Djärv <jan.h.d@swipnet.se>
494
4393663b
JD
495 * nsterm.m (keyDown): Call to wantsToDelayTextChangeNotifications and
496 variable firstTime not needed on OSX >= 10.6.
497 (setPosition): setFloatValue:knobProportion: is deprecated on OSX
498 >= 10.5. Use setKnobProportion, setDoubleValue.
499
500 * nsterm.h (MAC_OS_X_VERSION_10_3, MAC_OS_X_VERSION_10_4)
501 (MAC_OS_X_VERSION_10_5): Define if not defined.
502 (EmacsView, EmacsTooltip): Implements NSWindowDelegate on OSX >= 10.6.
503 (EmacsMenu): Implements NSMenuDelegate on OSX >= 10.6.
504 (EmacsToolbar): Implements NSToolbarDelegate on OSX >= 10.6.
505
506 * nsselect.m (ns_string_from_pasteboard): Don't use deprecated methods
507 cString and lossyCString on OSX >= 10.4
508
509 * nsmenu.m (fillWithWidgetValue): Don't use depercated method
510 sizeToFit on OSX >= 10.2.
511
512 * nsimage.m (allocInitFromFile): Don't use deprecated method
513 bestRepresentationForDevice on OSX >= 10.6.
514
515 * nsfns.m (check_ns_display_info): Cast to long and use %ld in error
516 to avoid warning.
517
518 * emacs.c: Declare unexec_init_emacs_zone.
519
a63e0781
JD
520 * nsgui.h: Fix compiler warning about gnulib redefining verify.
521
699c10bd
JD
522 * nsselect.m (ns_get_local_selection): Change to extern (Bug#8842).
523
524 * nsmenu.m (ns_update_menubar): Remove useless setDelegate call
525 on svcsMenu (Bug#8842).
526
527 * nsfns.m (Fx_open_connection): Remove NSStringPboardType from
528 ns_return_types.
529 (Fns_list_services): Just return Qnil on 10.6, code not working there.
530
531 * nsterm.m (QUTF8_STRING): Declare.
532 (initFrameFromEmacs): Call registerServicesMenuSendTypes.
533 (validRequestorForSendType): Return type is (id).
534 Change indexOfObjectIdenticalTo to indexOfObject.
535 Check if we have local selection before returning self (Bug#8842).
536 (writeSelectionToPasteboard): Put local selection into paste board
537 if we have a local selection (Bug#8842).
538 (syms_of_nsterm): DEFSYM QUTF8_STRING.
539
540 * nsterm.h (MAC_OS_X_VERSION_10_6): Define here instead of nsterm.m.
541 (ns_get_local_selection): Declare.
542
54e10184
LMI
5432011-07-07 Lars Magne Ingebrigtsen <larsi@gnus.org>
544
9888ff71
LMI
545 * keymap.c (describe_map_tree): Don't insert a double newline at
546 the end of the buffer (bug#1169) and return whether we inserted
547 something.
548
54e10184
LMI
549 * callint.c (Fcall_interactively): Change "reading args" to
550 "providing args" to try to clarify what it does (bug#1010).
551
15fa4783
KH
5522011-07-07 Kenichi Handa <handa@m17n.org>
553
554 * composite.c (composition_compute_stop_pos): Ignore a static
555 composition starting before CHARPOS (Bug#8915).
556
557 * xdisp.c (handle_composition_prop): Likewise.
558
a8815b00
EZ
5592011-07-07 Eli Zaretskii <eliz@gnu.org>
560
561 * term.c (produce_glyphs) <xassert>: Allow IT_GLYPHLESS in it->what.
562 (Bug#9015)
563
ef7b981d 5642011-07-07 Kenichi Handa <handa@m17n.org>
c805dec0
KH
565
566 * character.h (unicode_category_t): New enum type.
567
568 * chartab.c (uniprop_decoder_t, uniprop_encoder_t): New types.
569 (Qchar_code_property_table): New variable.
570 (UNIPROP_TABLE_P, UNIPROP_GET_DECODER)
571 (UNIPROP_COMPRESSED_FORM_P): New macros.
572 (char_table_ascii): Uncompress the compressed values.
573 (sub_char_table_ref): New arg is_uniprop. Callers changed.
574 Uncompress the compressed values.
ac389d0c 575 (sub_char_table_ref_and_range): Likewise.
c805dec0
KH
576 (char_table_ref_and_range): Uncompress the compressed values.
577 (sub_char_table_set): New arg is_uniprop. Callers changed.
578 Uncompress the compressed values.
579 (sub_char_table_set_range): Args changed. Callers changed.
580 (char_table_set_range): Adjuted for the above change.
581 (map_sub_char_table): Delete args default_val and parent. Add arg
582 top. Give decoded values to a Lisp function.
583 (map_char_table): Adjusted for the above change. Give decoded
584 values to a Lisp function. Gcpro more variables.
585 (uniprop_table_uncompress)
586 (uniprop_decode_value_run_length): New functions.
587 (uniprop_decoder, uniprop_decoder_count): New variables.
588 (uniprop_get_decoder, uniprop_encode_value_character)
589 (uniprop_encode_value_run_length, uniprop_encode_value_numeric):
590 New functions.
591 (uniprop_encoder, uniprop_encoder_count): New variables.
592 (uniprop_get_encoder, uniprop_table)
593 (Funicode_property_table_internal, Fget_unicode_property_internal)
594 (Fput_unicode_property_internal): New functions.
595 (syms_of_chartab): DEFSYM Qchar_code_property_table, defsubr
596 Sunicode_property_table_internal, Sget_unicode_property_internal,
597 and Sput_unicode_property_internal. Defvar_lisp
598 char-code-property-alist.
599
600 * composite.c (CHAR_COMPOSABLE_P): Adjusted for the change of
601 Vunicode_category_table.
602
603 * font.c (font_range): Adjusted for the change of
604 Vunicode_category_table.
605
76b397fb
DN
6062011-07-07 Dan Nicolaescu <dann@ics.uci.edu>
607
608 * m/iris4d.h: Remove file, move contents ...
609 * s/irix6-5.h: ... here.
610
22b4128e
PE
6112011-07-06 Paul Eggert <eggert@cs.ucla.edu>
612
613 Remove unportable assumption about struct layout (Bug#8884).
8a5c77bb
PE
614 * alloc.c (mark_buffer):
615 * buffer.c (reset_buffer_local_variables, Fbuffer_local_variables)
616 (clone_per_buffer_values): Don't assume that
22b4128e
PE
617 sizeof (struct buffer) is a multiple of sizeof (Lisp_Object).
618 This isn't true in general, and it's particularly not true
619 if Emacs is configured with --with-wide-int.
620 * buffer.h (FIRST_FIELD_PER_BUFFER, LAST_FIELD_PER_BUFFER):
621 New macros, used in the buffer.c change.
622
869795d6
JD
6232011-07-05 Jan Djärv <jan.h.d@swipnet.se>
624
625 * xsettings.c: Use both GConf and GSettings if both are available.
626 (store_config_changed_event): Add comment.
627 (dpyinfo_valid, store_font_name_changed, map_tool_bar_style)
628 (store_tool_bar_style_changed): New functions.
629 (store_monospaced_changed): Add comment. Call dpyinfo_valid.
630 (struct xsettings): Move font inside HAVE_XFT.
631 (GSETTINGS_TOOL_BAR_STYLE, GSETTINGS_FONT_NAME): New defines.
632 (GSETTINGS_MONO_FONT): Renamed from SYSTEM_MONO_FONT.
633 Move inside HAVE_XFT.
634 (something_changed_gsettingsCB): Renamed from something_changedCB.
635 Check for changes in GSETTINGS_TOOL_BAR_STYLE and GSETTINGS_FONT_NAME
636 also.
637 (GCONF_TOOL_BAR_STYLE, GCONF_FONT_NAME): New defines.
638 (GCONF_MONO_FONT): Renamed from SYSTEM_MONO_FONT. Move inside HAVE_XFT.
639 (something_changed_gconfCB): Renamed from something_changedCB.
640 Check for changes in GCONF_TOOL_BAR_STYLE and GCONF_FONT_NAME also.
641 (parse_settings): Move check for font inside HAVE_XFT.
642 (read_settings, apply_xft_settings): Add comment.
643 (read_and_apply_settings): Add comment. Call map_tool_bar_style and
644 store_tool_bar_style_changed. Move check for font inside HAVE_XFT and
645 call store_font_name_changed.
646 (xft_settings_event): Add comment.
647 (init_gsettings): Add comment. Get values for GSETTINGS_TOOL_BAR_STYLE
648 and GSETTINGS_FONT_NAME. Move check for fonts within HAVE_XFT.
649 (init_gconf): Add comment. Get values for GCONF_TOOL_BAR_STYLE
650 and GCONF_FONT_NAME. Move check for fonts within HAVE_XFT.
651 (xsettings_initialize): Call init_gsettings last.
652 (xsettings_get_system_font, xsettings_get_system_normal_font): Add
653 comment.
654
d8ed26bd
PE
6552011-07-05 Paul Eggert <eggert@cs.ucla.edu>
656
657 Random fixes. E.g., (random) never returned negative values.
658 * fns.c (Frandom): Use GET_EMACS_TIME for random seed, and add the
659 subseconds part to the entropy, as that's a bit more random.
660 Prefer signed to unsigned, since the signedness doesn't matter and
661 in general we prefer signed. When given a limit, use a
662 denominator equal to INTMASK + 1, not to VALMASK + 1, because the
663 latter isn't right if USE_2_TAGS_FOR_INTS.
664 * sysdep.c (get_random): Return a value in the range 0..INTMASK,
665 not 0..VALMASK. Don't discard "excess" bits that random () returns.
666
cabf1cac
SM
6672011-07-04 Stefan Monnier <monnier@iro.umontreal.ca>
668
669 * textprop.c (text_property_stickiness):
670 Obey Vtext_property_default_nonsticky.
671 (syms_of_textprop): Add `display' to Vtext_property_default_nonsticky.
672 * w32fns.c (syms_of_w32fns):
673 * xfns.c (syms_of_xfns): Don't Add `display' since it's there by default.
674
6e9b2be9
PE
6752011-07-04 Paul Eggert <eggert@cs.ucla.edu>
676
677 * fileio.c (barf_or_query_if_file_exists): Use S_ISDIR.
678 This is more efficient than Ffile_directory_p and avoids a minor race.
679
90186c68
LMI
6802011-07-04 Lars Magne Ingebrigtsen <larsi@gnus.org>
681
7c301272
LMI
682 * buffer.c (Foverlay_put): Say what the return value is
683 (bug#7835).
684
c4f2d8d4
LMI
685 * fileio.c (barf_or_query_if_file_exists): Check first if the file
686 is a directory before asking whether to use the file name
687 (bug#7564).
ad637907
LMI
688 (barf_or_query_if_file_exists): Make the "File is a directory"
689 error be more correct.
c4f2d8d4 690
90186c68
LMI
691 * fns.c (Frequire): Remove the mention of the .gz files, since
692 that's installation-specific, but keep the mention of
693 `get-load-suffixes'.
694
da64016e
PE
6952011-07-04 Paul Eggert <eggert@cs.ucla.edu>
696
697 * editfns.c (Fformat_time_string): Don't assume strlen fits in int.
698 Report string overflow if the output is too long.
699
7d47b580
JB
7002011-07-04 Juanma Barranquero <lekktu@gmail.com>
701
a555cb87
JB
702 * gnutls.c (Fgnutls_boot): Don't mention :verify-error.
703 (syms_of_gnutls): Remove duplicate DEFSYM for
704 Qgnutls_bootprop_verify_hostname_error, an error for
705 Qgnutls_bootprop_verify_error (which is no longer used).
706
7d47b580
JB
707 * eval.c (find_handler_clause): Remove parameters `sig' and `data',
708 unused since 2011-01-26T20:02:07Z!monnier@iro.umontreal.ca. All callers changed.
709 Also (re)move comments that are misplaced or no longer relevant.
710
1e49bfab
LMI
7112011-07-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
712
713 * callint.c (Finteractive): Clarify the meaning of "@" (bug#8813).
714
1485f4c0
CY
7152011-07-03 Chong Yidong <cyd@stupidchicken.com>
716
717 * xfaces.c (Finternal_merge_in_global_face): Modify the foreground
718 and background color parameters if they have been changed.
719
a9ab721e
LMI
7202011-07-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
721
722 * editfns.c (Fformat): Clarify the - and 0 flags (bug#6659).
723
cf7cff57
PE
7242011-07-03 Paul Eggert <eggert@cs.ucla.edu>
725
2e13213d
PE
726 * xsettings.c (SYSTEM_FONT): Define only when used.
727 No need to define when HAVE_GSETTINGS || !HAVE_XFT.
728
cf7cff57
PE
729 * keymap.c (access_keymap_1): Now static.
730
7a8e04f7
CY
7312011-07-02 Chong Yidong <cyd@stupidchicken.com>
732
733 * keyboard.c (command_loop_1): If a down-mouse event is unbound,
734 leave any prefix arg for the up event (Bug#1586).
735
61352f62
LMI
7362011-07-02 Lars Magne Ingebrigtsen <larsi@gnus.org>
737
69bb1ef7
LMI
738 * lread.c (syms_of_lread): Mention single symbols defined by
739 `defvar' or `defconst' (bug#7154).
740
61352f62 741 * fns.c (Frequire): Mention .el.gz files (bug#7314).
7b3747f9 742 (Frequire): Mention get-load-suffixes.
61352f62 743
28545e04
MR
7442011-07-02 Martin Rudalics <rudalics@gmx.at>
745
746 * window.h (window): Remove clone_number slot.
747 * window.c (Fwindow_clone_number, Fset_window_clone_number):
748 Remove.
749 (make_parent_window, make_window, saved_window)
750 (Fset_window_configuration, save_window_save): Don't deal with
751 clone numbers.
752 * buffer.c (Qclone_number): Remove declaration.
753 (sort_overlays, overlay_strings): Don't deal with clone numbers.
754
3349e122
SM
7552011-07-02 Stefan Monnier <monnier@iro.umontreal.ca>
756
757 Add multiple inheritance to keymaps.
758 * keymap.c (Fmake_composed_keymap): New function.
759 (Fset_keymap_parent): Simplify.
760 (fix_submap_inheritance): Remove.
761 (access_keymap_1): New function extracted from access_keymap to handle
762 embedded parents and handle lists of maps.
763 (access_keymap): Use it.
764 (Fkeymap_prompt, map_keymap_internal, map_keymap, store_in_keymap)
765 (Fcopy_keymap): Handle embedded parents.
766 (Fcommand_remapping, define_as_prefix): Simplify.
767 (Fkey_binding): Simplify.
768 (syms_of_keymap): Move minibuffer-local-completion-map,
769 minibuffer-local-filename-completion-map,
770 minibuffer-local-must-match-map, and
771 minibuffer-local-filename-must-match-map to Elisp.
772 (syms_of_keymap): Defsubr make-composed-keymap.
773 * keyboard.c (menu_bar_items): Use map_keymap_canonical.
774 (parse_menu_item): Trivial simplification.
775
3279eb87
GM
7762011-07-01 Glenn Morris <rgm@gnu.org>
777
778 * Makefile.in (SETTINGS_LIBS): Fix typo.
779
4550efdf
KI
7802011-07-01 Kazuhiro Ito <kzhr@d1.dion.ne.jp> (tiny patch)
781
782 * coding.c (Fencode_coding_string): Record the last coding system
783 used, as the function doc string says (bug#8738).
784
0949d2b6
JD
7852011-07-01 Jan Djärv <jan.h.d@swipnet.se>
786
787 * xsettings.c (store_monospaced_changed): Take new font as arg and
788 check for change against current_mono_font.
789 (EMACS_TYPE_SETTINGS): Remove this and related defines.
790 (emacs_settings_constructor, emacs_settings_get_property)
791 (emacs_settings_set_property, emacs_settings_class_init)
792 (emacs_settings_init, gsettings_obj): Remove.
793 (something_changedCB): New function for HAVE_GSETTINGS.
794 (something_changedCB): HAVE_GCONF: Call store_monospaced_changed
795 with value as argument.
796 (init_gsettings): Check that GSETTINGS_SCHEMA exists before calling
797 g_settings_new (Bug#8967). Do not create gsettings_obj.
9173deec 798 Remove calls to g_settings_bind. Connect something_changedCB to
0949d2b6
JD
799 "changed".
800
801 * xgselect.c: Add defined (HAVE_GSETTINGS).
802 (xgselect_initialize): Ditto.
803
804 * process.c: Add defined (HAVE_GSETTINGS) for xgselect.h
805 (wait_reading_process_output): Add defined (HAVE_GSETTINGS) for
806 xg_select.
807
bbc6b304
PE
8082011-07-01 Paul Eggert <eggert@cs.ucla.edu>
809
810 * eval.c (struct backtrace): Simplify and port the data structure.
811 Do not assume that "int nargs : BITS_PER_INT - 2;" produces a
812 signed bit field, as this assumption is not portable and it makes
813 Emacs crash when compiled with Sun C 5.8 on sparc. Do not use
814 "char debug_on_exit : 1" as this is not portable either; instead,
815 use the portable "unsigned int debug_on_exit : 1". Remove unused
816 member evalargs. Remove obsolete comments about cc bombing out.
817
9851bfc5
JD
8182011-06-30 Jan Djärv <jan.h.d@swipnet.se>
819
51bb811f 820 * xsettings.c: Include glib-object.h, gio/gio.h if HAVE_GSETTINGS.
9851bfc5
JD
821 Let HAVE_GSETTINGS override HAVE_GCONF.
822 (store_monospaced_changed): New function.
823 (EMACS_SETTINGS): A new type derived from GObject to handle
824 GSettings notifications.
825 (emacs_settings_constructor, emacs_settings_get_property)
826 (emacs_settings_set_property, emacs_settings_class_init):
827 New functions.
828 (gsettings_client, gsettings_obj): New variables.
829 (GSETTINGS_SCHEMA): New define.
830 (something_changedCB): Call store_monospaced_changed.
831 (init_gsettings): New function.
832 (xsettings_initialize): Call init_gsettings.
833 (syms_of_xsettings): Initialize gsettings_client, gsettings_obj
834 to NULL.
835
836 * Makefile.in (SETTINGS_CFLAGS, SETTINGS_LIBS): Renamed from
837 GCONF_CFLAGS/LIBS.
838
5386012d
MR
8392011-06-29 Martin Rudalics <rudalics@gmx.at>
840
841 * window.c (resize_root_window, grow_mini_window)
842 (shrink_mini_window): Rename Qresize_root_window to
843 Qwindow_resize_root_window and Qresize_root_window_vertically to
844 Qwindow_resize_root_window_vertically.
845
f13e0b08
PE
8462011-06-28 Paul Eggert <eggert@cs.ucla.edu>
847
848 * gnutls.c (Qgnutls_bootprop_verify_error): Remove unused var.
849
94515237
JB
8502011-06-27 Juanma Barranquero <lekktu@gmail.com>
851
852 * makefile.w32-in: Redesign dependencies so they reflect more
853 clearly which files are directly included by each source file,
854 and not through other includes.
855
e43b6e43
MR
8562011-06-27 Martin Rudalics <rudalics@gmx.at>
857
858 * buffer.c (Qclone_number): Declare static and DEFSYM it.
859 (sort_overlays, overlay_strings): When an overlay's clone number
860 matches the window's clone number process the overlay even if
861 the overlay's window property doesn't match the current window.
862
d68443dc
MR
863 * window.c (Fwindow_vchild): Rename to Fwindow_top_child.
864 (Fwindow_hchild): Rename to Fwindow_left_child.
865 (Fwindow_next): Rename to Fwindow_next_sibling.
866 (Fwindow_prev): Rename to Fwindow_prev_sibling.
d615d6d2
MR
867 (resize_window_check): Rename to window_resize_check.
868 (resize_window_apply): Rename to window_resize_apply.
869 (Fresize_window_apply): Rename to Fwindow_resize_apply.
870 (Fdelete_other_windows_internal, resize_frame_windows)
871 (Fsplit_window_internal, Fdelete_window_internal)
872 (grow_mini_window, shrink_mini_window)
873 (Fresize_mini_window_internal): Fix callers accordingly.
d68443dc 874
c7e73be5
JD
8752011-06-26 Jan Djärv <jan.h.d@swipnet.se>
876
877 * emacsgtkfixed.h: State that this is only used with Gtk+3.
878 (emacs_fixed_set_min_size): Remove.
879 (emacs_fixed_new): Take frame as argument.
880
881 * emacsgtkfixed.c: State that this is only used with Gtk+3.
882 (_EmacsFixedPrivate): Remove minwidth/height.
883 Add struct frame *f.
884 (emacs_fixed_init): Initialize priv->f.
885 (get_parent_class, emacs_fixed_set_min_size): Remove.
886 (emacs_fixed_new): Set priv->f to argument.
887 (emacs_fixed_get_preferred_width)
888 (emacs_fixed_get_preferred_height): Use min_width/height from
889 frames size_hint to set minimum and natural (Bug#8919).
890 (XSetWMSizeHints, XSetWMNormalHints): Override these functions
891 and use min_width/height from frames size_hint to set
892 min_width/height (Bug#8919).
893
894 * gtkutil.c (xg_create_frame_widgets): Pass f to emacs_fixed_new.
9173deec
JB
895 (x_wm_set_size_hint): Remove call to emacs_fixed_set_min_size.
896 Fix indentation.
c7e73be5 897
cf99dcf8
EZ
8982011-06-26 Eli Zaretskii <eliz@gnu.org>
899
900 * bidi.c (bidi_paragraph_init): Test for ZV_BYTE before calling
901 bidi_at_paragraph_end, since fast_looking_at doesn't like to be
902 called at ZV.
903
029529ac
CY
9042011-06-26 Chong Yidong <cyd@stupidchicken.com>
905
906 * process.c (wait_reading_process_output): Bypass select if
907 waiting for a cell while ignoring keyboard input, and input is
908 pending. Suggested by Jan Djärv (Bug#8869).
909
7a7ef429
PE
9102011-06-25 Paul Eggert <eggert@cs.ucla.edu>
911
912 Use gnulib's dup2 module instead of rolling our own.
913 * sysdep.c (dup2) [!HAVE_DUP2]: Remove; gnulib now does this.
914
11fdef7d 9152011-06-25 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
989b42d2
YM
916
917 * dispnew.c (scrolling_window): Before scrolling, turn off a
918 mouse-highlight in the window being scrolled.
919
cd3520a4
JB
9202011-06-24 Juanma Barranquero <lekktu@gmail.com>
921
922 Move DEFSYM to lisp.h and use everywhere.
923
924 * character.h (DEFSYM): Move declaration...
925 * lisp.h (DEFSYM): ...here.
926
927 * gnutls.c:
928 * minibuf.c:
929 * w32menu.c:
930 * w32proc.c:
931 * w32select.c: Don't include character.h.
932
933 * alloc.c (syms_of_alloc):
934 * buffer.c (syms_of_buffer):
935 * bytecode.c (syms_of_bytecode):
936 * callint.c (syms_of_callint):
937 * casefiddle.c (syms_of_casefiddle):
938 * casetab.c (init_casetab_once):
939 * category.c (init_category_once, syms_of_category):
940 * ccl.c (syms_of_ccl):
941 * cmds.c (syms_of_cmds):
942 * composite.c (syms_of_composite):
943 * dbusbind.c (syms_of_dbusbind):
944 * dired.c (syms_of_dired):
945 * dispnew.c (syms_of_display):
946 * doc.c (syms_of_doc):
947 * editfns.c (syms_of_editfns):
948 * emacs.c (syms_of_emacs):
949 * eval.c (syms_of_eval):
950 * fileio.c (syms_of_fileio):
951 * fns.c (syms_of_fns):
952 * frame.c (syms_of_frame):
953 * fringe.c (syms_of_fringe):
954 * insdel.c (syms_of_insdel):
955 * keymap.c (syms_of_keymap):
956 * lread.c (init_obarray, syms_of_lread):
957 * macros.c (syms_of_macros):
958 * msdos.c (syms_of_msdos):
959 * print.c (syms_of_print):
960 * process.c (syms_of_process):
961 * search.c (syms_of_search):
962 * sound.c (syms_of_sound):
963 * syntax.c (init_syntax_once, syms_of_syntax):
964 * terminal.c (syms_of_terminal):
965 * textprop.c (syms_of_textprop):
966 * undo.c (syms_of_undo):
967 * w32.c (globals_of_w32):
968 * window.c (syms_of_window):
969 * xdisp.c (syms_of_xdisp):
970 * xfaces.c (syms_of_xfaces):
971 * xfns.c (syms_of_xfns):
972 * xmenu.c (syms_of_xmenu):
973 * xsettings.c (syms_of_xsettings):
974 * xterm.c (syms_of_xterm): Use DEFSYM.
975
4228cf16
TZ
9762011-06-24 Teodor Zlatanov <tzz@lifelogs.com>
977
cd3520a4 978 * gnutls.c (syms_of_gnutls): Use the DEFSYM macro from character.h.
4228cf16 979
7fcccf1e
PE
9802011-06-23 Paul Eggert <eggert@cs.ucla.edu>
981
7efb4e0e
PE
982 Integer and buffer overflow fixes (Bug#8873).
983
ff5844ad
PE
984 * print.c (printchar, strout): Check for string overflow.
985 (PRINTPREPARE, printchar, strout):
986 Don't set size unless allocation succeeds.
987
90532f02
PE
988 * minibuf.c (read_minibuf_noninteractive): Use ptrdiff_t, not int,
989 for sizes. Check for string overflow more accurately.
990 Simplify newline removal at end; this suppresses a GCC 4.6.0 warning.
991
6d84508d
PE
992 * macros.c: Integer and buffer overflow fixes.
993 * keyboard.h (struct keyboard.kbd_macro_bufsize):
994 * macros.c (Fstart_kbd_macro, store_kbd_macro_char):
995 Use ptrdiff_t, not int, for sizes.
996 Don't increment bufsize until after realloc succeeds.
997 Check for size-calculation overflow.
998 (Fstart_kbd_macro): Use EMACS_INT, not int, for XINT result.
999
437b2cb4
PE
1000 * lisp.h (DEFVAR_KBOARD): Use offsetof instead of char * finagling.
1001
8b9ac8b4
PE
1002 * lread.c: Integer overflow fixes.
1003 (read_integer): Radix is now EMACS_INT, not int,
1004 to improve quality of diagnostics for out-of-range radices.
1005 Calculate buffer size correctly for out-of-range radices.
1006 (read1): Check for integer overflow in radices, and in
1007 read-circle numbers.
82cb60d3
PE
1008 (read_escape): Avoid int overflow.
1009 (Fload, openp, read_buffer_size, read1)
1010 (substitute_object_recurse, read_vector, read_list, map_obarray):
1011 Use ptrdiff_t, not int, for sizes.
1012 (read1): Use EMACS_INT, not int, for sizes.
20270765 1013 Check for size overflow.
8b9ac8b4 1014
7fcccf1e
PE
1015 * image.c (cache_image): Check for size arithmetic overflow.
1016
bfbbd7e7
PE
1017 * lread.c: Integer overflow issues.
1018 (saved_doc_string_size, saved_doc_string_length)
1019 (prev_saved_doc_string_size, prev_saved_doc_string_length):
1020 Now ptrdiff_t, not int.
1021 (read1): Don't assume doc string length fits in int. Check for
1022 out-of-range doc string lengths.
1023 (read_list): Don't assume file position fits in int.
39019e54 1024 (read_escape): Check for hex character overflow.
bfbbd7e7 1025
4e323265
LL
10262011-06-22 Leo Liu <sdl.web@gmail.com>
1027
1028 * minibuf.c (Fcompleting_read_default, Vcompleting_read_function):
1029 Move to minibuffer.el.
1030
85fece3e
PE
10312011-06-22 Paul Eggert <eggert@cs.ucla.edu>
1032
20b84ce9 1033 Fixes for GLYPH_DEBUG found by GCC 4.6.0 static checking.
85fece3e
PE
1034 The following patches are for when GLYPH_DEBUG && !XASSERT.
1035 * dispextern.h (trace_redisplay_p, dump_glyph_string):
1036 * dispnew.c (flush_stdout):
1037 * xdisp.c (dump_glyph_row, dump_glyph_matrix, dump_glyph):
1038 Mark as externally visible.
1039 * dispnew.c (check_window_matrix_pointers): Now static.
1040 * dispnew.c (window_to_frame_vpos):
1041 * xfns.c (unwind_create_frame):
1042 * xterm.c (x_check_font): Remove unused local.
1043 * scroll.c (CHECK_BOUNDS):
1044 * xfaces.c (cache_fache): Rename local to avoid shadowing.
1045 * xfns.c, w32fns.c (image_cache_refcount, dpyinfo_refcount): Now static.
1046 * xdisp.c (check_window_end): Now a no-op if !XASSERTS.
1047 (debug_first_unchanged_at_end_vpos, debug_last_unchanged_at_beg_vpos)
1048 (debug_dvpos, debug_dy, debug_delta, debug_delta_bytes, debug_end_vpos):
1049 Now static.
1050 (debug_method_add): Use va_list and vsprintf rather than relying
1051 on undefined behavior with wrong number of arguments.
1052 (dump_glyph, dump_glyph_row, Fdump_glyph_matrix):
1053 Don't assume ptrdiff_t and EMACS_INT are the same width as int.
1054 In this code, it's OK to assume C99 behavior for ptrdiff_t formats
1055 since we're not interested in debugging glyphs with old libraries.
1056 * xfaces.c (cache_face): Move debugging code earlier; this pacifies
1057 GCC 4.6.0's static checking.
1058
0766b489
PE
10592011-06-22 Paul Eggert <eggert@cs.ucla.edu>
1060
31fd4b32
PE
1061 Integer overflow and signedness fixes (Bug#8873).
1062 A few related buffer overrun fixes, too.
1063
b79e8648
PE
1064 * font.c (font_score): Use EMACS_INT, not int, to store XINT value.
1065
0766b489
PE
1066 * dispextern.h (struct face.stipple):
1067 * image.c (x_bitmap_height, x_bitmap_width, x_bitmap_pixmap)
1068 (x_bitmap_mask, x_allocate_bitmap_record)
1069 (x_create_bitmap_from_data, x_create_bitmap_from_file)
1070 (x_destroy_bitmap, x_destroy_all_bitmaps, x_create_bitmap_mask)
1071 (x_create_bitmap_from_xpm_data):
1072 * nsterm.h (struct ns_display_info.bitmaps_size, .bitmaps_last):
1073 * w32term.h (struct w32_display_info.icon_bitmap_id, .bitmaps_size)
1074 (.bitmaps_last):
1075 * xfaces.c (load_pixmap):
1076 * xterm.c (x_bitmap_icon, x_wm_set_icon_pixmap):
1077 * xterm.h (struct x_display_info.icon_bitmap_id, .bitmaps_size)
1078 (.bitmaps_last, struct x_output.icon_bitmap):
1079 Use ptrdiff_t, not int, for bitmap indexes.
1080 (x_allocate_bitmap_record): Check for size overflow.
1081 * dispextern.h, lisp.h: Adjust to API changes elsewhere.
1082
b081724f
PE
1083 Use ptrdiff_t, not int, for overlay counts.
1084 * buffer.h (overlays_at, sort_overlays, GET_OVERLAYS_AT):
1085 * editfns.c (overlays_around, get_pos_property):
1086 * textprop.c (get_char_property_and_overlay):
1087 * xdisp.c (next_overlay_change, note_mouse_highlight):
1088 * xfaces.c (face_at_buffer_position):
21514da7
PE
1089 * buffer.c (OVERLAY_COUNT_MAX): New macro.
1090 (overlays_at, overlays_in, sort_overlays, Foverlays_at)
1091 (Fnext_overlay_change, Fprevious_overlay_change)
1092 (mouse_face_overlay_overlaps, Foverlays_in):
b081724f 1093 Use ptrdiff_t, not int, for sizes.
21514da7 1094 (overlays_at, overlays_in): Check for size-calculation overflow.
b081724f 1095
3de73e5e
PE
1096 * xterm.c (xim_initialize, same_x_server): Strlen may not fit in int.
1097
2606c57b
PE
1098 * xsmfns.c (smc_save_yourself_CB, x_session_initialize): Avoid strlen.
1099 (x_session_initialize): Do not assume string length fits in int.
1100
aaafe47a
PE
1101 * xsettings.c (apply_xft_settings): Fix potential buffer overrun.
1102 This is unlikely, but can occur if DPI is outlandish.
1103
2674ddc8 1104 * xsettings.c (Ffont_get_system_normal_font, Ffont_get_system_font):
3a5077c5
PE
1105 * xselect.c (Fx_get_atom_name): Avoid need for strlen.
1106
28154962
PE
1107 * xrdb.c: Don't assume strlen fits in int; avoid some strlens.
1108 * xrdb.c (magic_file_p, search_magic_path):
1109 Omit last arg SUFFIX; it was always 0. All callers changed.
1110 (magic_file_p): Use ptrdiff_t, not int. Check for size overflow.
1111
7de51af5
PE
1112 * xfont.c (xfont_match): Avoid need for strlen.
1113
25ed6cc3
PE
1114 * xfns.c: Don't assume strlen fits in int.
1115 (xic_create_fontsetname, x_window): Use ptrdiff_t, not int.
1116
4eab31dd
PE
1117 * xdisp.c (message_log_check_duplicate): Return intmax_t,
1118 not unsigned long, as we prefer signed integers. All callers changed.
1119 Detect integer overflow in repeat count.
1120 (message_dolog): Don't assume print length fits in 39 bytes.
df1f27af 1121 (display_mode_element): Don't assume strlen fits in int.
4eab31dd 1122
171e2a58
PE
1123 * termcap.c: Don't assume sizes fit in int and never overflow.
1124 (struct termcap_buffer, tgetent): Use ptrdiff_t, not int, for sizes.
1125 (gobble_line): Check for size-calculation overflow.
1126
ad39faca 1127 * minibuf.c (Fread_buffer):
6e5bb2dc 1128 * lread.c (intern, intern_c_string):
74ca2eb3
PE
1129 * image.c (xpm_scan) [HAVE_NS && !HAVE_XPM]:
1130 Don't assume string length fits in int.
1131
52c61c22 1132 * keyboard.c (parse_tool_bar_item):
9bda3520
PE
1133 * gtkutil.c (style_changed_cb): Avoid need for strlen.
1134
b5b8c9e5
PE
1135 * font.c: Don't assume string length fits in int.
1136 (font_parse_xlfd, font_parse_fcname, font_unparse_fcname):
1137 Use ptrdiff_t, not int.
ccd6111c
PE
1138 (font_intern_prop): Don't assume string length fits in int.
1139 Don't assume integer property fits in fixnum.
1140 * font.h (font_intern_prop): 2nd arg is now ptrdiff_t, not int.
b5b8c9e5 1141
882f0d81 1142 * filelock.c: Fix some buffer overrun and integer overflow issues.
51cab52b 1143 (get_boot_time): Don't assume gzip command string fits in 100 bytes.
882f0d81
PE
1144 Reformulate so as not to need the command string.
1145 Invoke gzip -cd rather than gunzip, as it's more portable.
1146 (lock_info_type, lock_file_1, lock_file):
1147 Don't assume pid_t and time_t fit in unsigned long.
1148 (LOCK_PID_MAX): Remove; we now use more-reliable bounds.
1149 (current_lock_owner): Prefer signed type for sizes.
1150 Use memcpy, not strncpy, where memcpy is what is really wanted.
1151 Don't assume (via atoi) that time_t and pid_t fit in int.
1152 Check for time_t and/or pid_t out of range, e.g., via a network share.
1153 Don't alloca where an auto var works fine.
1154
93f4cf88
PE
1155 * fileio.c: Fix some integer overflow issues.
1156 (file_name_as_directory, Fexpand_file_name, Fsubstitute_in_file_name):
1157 Don't assume string length fits in int.
1158 (directory_file_name): Don't assume string length fits in long.
1159 (make_temp_name): Don't assume pid fits in int, or that its print
1160 length is less than 20.
1161
f3e92b69
PE
1162 * data.c (Fsubr_name): Rewrite to avoid a strlen call.
1163
1bfdaf10
PE
1164 * coding.c (make_subsidiaries): Don't assume string length fits in int.
1165
35016e9a
PE
1166 * callproc.c (child_setup): Rewrite to avoid two strlen calls.
1167
3d1e65a1
PE
1168 * process.c (Fformat_network_address): Use EMACS_INT, not EMACS_UINT.
1169 We prefer signed integers, even for size calculations.
1170
0b963a93
PE
1171 * emacs.c: Don't assume string length fits in 'int'.
1172 (DEFINE_DUMMY_FUNCTION, sort_args): Use ptrdiff_t, not int.
1173 (main): Don't invoke strlen when not needed.
1174
573f4b54
PE
1175 * dbusbind.c (XD_ERROR): Don't arbitrarily truncate string.
1176 (XD_DEBUG_MESSAGE): Don't waste a byte.
1177
989f33ba
PE
1178 * callproc.c (getenv_internal_1, getenv_internal)
1179 (Fgetenv_internal):
965d34eb
PE
1180 * buffer.c (init_buffer): Don't assume string length fits in 'int'.
1181
e4d29b33
PE
1182 * lread.c (invalid_syntax): Omit length argument.
1183 All uses changed. This doesn't fix a bug, but it simplifies the
1184 code away from its former Hollerith-constant appearance, and it's
1185 one less 'int' to worry about when looking at integer-overflow issues.
51cab52b 1186 (string_to_number): Simplify 2011-04-26 change by invoking xsignal1.
e4d29b33 1187
eb49b136
PE
1188 * lisp.h (DEFUN): Remove bogus use of sizeof (struct Lisp_Subr).
1189 This didn't break anything, but it didn't help either.
1190 It's confusing to put a bogus integer in a place where the actual
1191 value does not matter.
9f62aeb1 1192 (LIST_END_P): Remove unused macro and its bogus comment.
cbeff735 1193 (make_fixnum_or_float): Remove unnecessary cast to EMACS_INT.
eb49b136 1194
15375a22
PE
1195 * lisp.h (union Lisp_Object.i): EMACS_INT, not EMACS_UINT.
1196 This is for consistency with the ordinary, non-USE_LISP_UNION_TYPE,
1197 implementation.
b61cc01c
PE
1198 (struct Lisp_Bool_Vector.size): EMACS_INT, not EMACS_UINT.
1199 We prefer signed types, and the value cannot exceed the EMACS_INT
1200 range anyway (because otherwise the length would not be representable).
9a8e8d9b
PE
1201 (XSET) [USE_LISP_UNION_TYPE]: Use uintptr_t and intptr_t,
1202 not EMACS_UINT and EMACS_INT, when converting pointer to integer.
1203 This avoids a GCC warning when WIDE_EMACS_INT.
15375a22 1204
53b2623d
PE
1205 * indent.c (sane_tab_width): New function.
1206 (current_column, scan_for_column, Findent_to, position_indentation)
1207 (compute_motion): Use it. This is just for clarity.
8fcaf9cc 1208 (Fcompute_motion): Don't assume hscroll and tab offset fit in int.
53b2623d 1209
51cab52b 1210 * image.c (xbm_image_p): Don't assume stated width, height fit in int.
45aebb64 1211
f2ed8a70
PE
1212 * lisp.h (lint_assume): New macro.
1213 * composite.c (composition_gstring_put_cache):
1214 * ftfont.c (ftfont_shape_by_flt): Use it to pacify GCC 4.6.0.
1215
abe80cc6
PE
1216 * editfns.c, insdel.c:
1217 Omit unnecessary forward decls, to simplify future changes.
a9e860e1 1218
b02c740e
PE
1219 * ftfont.c (ftfont_shape_by_flt): Use signed integers for lengths.
1220
ebc96716
PE
1221 * font.c (Ffont_shape_gstring): Don't assume glyph len fits in 'int'.
1222
b4e50fa0 1223 * fns.c (Ffillarray): Don't assume bool vector size fits in 'int'.
f03dc6ef 1224 Use much-faster test for byte-length change.
311d5d7c 1225 Don't assume string byte-length fits in 'int'.
a4cf38e4 1226 Check that character arg fits in 'int'.
85461888 1227 (mapcar1): Declare byte as byte, for clarity.
b4e50fa0 1228
c0c1ee9f
PE
1229 * alloc.c (Fmake_bool_vector): Avoid unnecessary multiplication.
1230
a498d7f4
PE
1231 * fns.c (concat): Catch string overflow earlier.
1232 Do not rely on integer wraparound.
1233
51cab52b
PE
1234 * dispextern.h (struct it.overlay_strings_charpos)
1235 (struct it.selective): Now EMACS_INT, not int.
87830974
PE
1236 * xdisp.c (forward_to_next_line_start)
1237 (back_to_previous_visible_line_start)
1238 (reseat_at_next_visible_line_start, next_element_from_buffer):
1239 Don't arbitrarily truncate the value of 'selective' to int.
1240
76031fad
PE
1241 * xdisp.c (init_iterator): Use XINT, not XFASTINT; it might be < 0.
1242
5eb55db9
PE
1243 * composite.c: Don't truncate sizes to 'int'.
1244 (composition_gstring_p, composition_reseat_it)
1245 (composition_adjust_point): Use EMACS_INT, not int.
7d100a81
PE
1246 (get_composition_id, composition_gstring_put_cache): Use EMACS_INT,
1247 not EMACS_UINT, for indexes.
5eb55db9 1248
0703a717
PE
1249 * category.h (CATEGORY_SET_P): Remove unnecessary cast to EMACS_INT.
1250
d6202519
PE
1251 * buffer.c: Include <verify.h>.
1252 (struct sortvec.priority, struct sortstr.priority):
8961a454 1253 Now EMACS_INT, not int.
c20998a7 1254 (compare_overlays, cmp_for_strings): Avoid subtraction overflow.
67c36fce
PE
1255 (struct sortstr.size, record_overlay_string)
1256 (struct sortstrlist.size, struct sortlist.used):
1257 Don't truncate size to int.
1258 (record_overlay_string): Check for size-calculation overflow.
d6202519 1259 (init_buffer_once): Check at compile-time, not run-time.
fadf4e30 1260
d5a19415
JM
12612011-06-22 Jim Meyering <meyering@redhat.com>
1262
029529ac 1263 Don't leak an XBM-image-sized buffer
d5a19415
JM
1264 * image.c (xbm_load): Free the image buffer after using it.
1265
a9041e6c
PE
12662011-06-21 Paul Eggert <eggert@cs.ucla.edu>
1267
1268 Port to Sun C.
1269 * composite.c (find_automatic_composition): Omit needless 'return 0;'
1270 that Sun C diagnosed.
1271 * fns.c (secure_hash): Fix pointer signedness issue.
1272 * intervals.c (static_offset_intervals): New function.
1273 (offset_intervals): Use it.
1274
7f3f739f
LL
12752011-06-21 Leo Liu <sdl.web@gmail.com>
1276
1277 * deps.mk (fns.o):
1278 * makefile.w32-in ($(BLD)/fns.$(O)): Include sha256.h and
1279 sha512.h.
1280
1281 * fns.c (secure_hash): Rename from crypto_hash_function and change
1282 the first arg to accept symbols.
5b66d427 1283 (Fsecure_hash): New primitive.
7f3f739f
LL
1284 (syms_of_fns): New symbols.
1285
76147d94
DD
12862011-06-20 Deniz Dogan <deniz@dogan.se>
1287
1288 * process.c (Fset_process_buffer): Clarify return value in
1289 docstring.
1290
7d7d0045
CY
12912011-06-18 Chong Yidong <cyd@stupidchicken.com>
1292
1293 * dispnew.c (add_window_display_history): Use BVAR.
1294
1295 * xdisp.c (debug_method_add): Use BVAR.
1296 (check_window_end, dump_glyph_matrix, dump_glyph)
1297 (dump_glyph_row, dump_glyph_string): Convert arglist to ANSI C.
1298
1299 * xfaces.c (check_lface_attrs, check_lface, dump_realized_face):
1300 Likewise.
1301
1302 * xfns.c (Fx_create_frame, x_create_tip_frame): Delay image cache
1303 check till after the cache is created in init_frame_faces.
1304
ff2bc410
SM
13052011-06-17 Stefan Monnier <monnier@iro.umontreal.ca>
1306
1307 * fns.c (Fsafe_length): Yet another int/Lisp_Object mixup.
1308
28177add
PE
13092011-06-16 Paul Eggert <eggert@cs.ucla.edu>
1310
dd3482fe
PE
1311 * lisp.h: Include <limits.h>, for INT_MAX, LONG_MAX, LLONG_MAX.
1312 Without this, prin1 mishandles Lisp_Misc_Save_Value printing on
1313 hosts with pre-C99 libraries, because pD is wrongly defined to "t".
1314
393d71f3 1315 Improve buffer-overflow checking (Bug#8873).
1c8e352f
PE
1316 * fileio.c (Finsert_file_contents):
1317 * insdel.c (insert_from_buffer_1, replace_range, replace_range_2):
1318 Remove the old (too-loose) buffer overflow checks.
1319 They weren't needed, since make_gap checks for buffer overflow.
1320 * insdel.c (make_gap_larger): Catch buffer overflows that were missed.
1321 The old code merely checked for Emacs fixnum overflow, and relied
1322 on undefined (wraparound) behavior. The new code avoids undefined
1323 behavior, and also checks for ptrdiff_t and/or size_t overflow.
1324
2e6813b0 1325 * editfns.c (Finsert_char): Don't dump core with very negative counts.
21d890a4
PE
1326 Tune. Don't use wider integers than needed. Don't use alloca.
1327 Use a bigger 'string' buffer. Rewrite to avoid 'n > 0' test.
2e6813b0 1328
599a9e4f
PE
1329 * insdel.c (replace_range): Fix buf overflow when insbytes < outgoing.
1330
99561444
PE
1331 * insdel.c, lisp.h (buffer_overflow): New function.
1332 (insert_from_buffer_1, replace_range, replace_range_2):
1333 * insdel.c (make_gap_larger):
1334 * editfns.c (Finsert_char):
1335 * fileio.c (Finsert_file_contents): Use it, to normalize wording.
1336
28177add
PE
1337 * buffer.h (BUF_BYTES_MAX): Cast to ptrdiff_t so that it's signed.
1338
e69dafad
PE
13392011-06-15 Paul Eggert <eggert@cs.ucla.edu>
1340
a7af7fde 1341 Integer overflow and signedness fixes (Bug#8873).
ff672d2c 1342
b1c46f02
PE
1343 * ccl.c (ASCENDING_ORDER): New macro, to work around GCC bug 43772.
1344 (GET_CCL_RANGE, IN_INT_RANGE): Use it.
1345
e69dafad
PE
1346 * fileio.c: Don't assume EMACS_INT fits in off_t.
1347 (emacs_lseek): New static function.
1348 (Finsert_file_contents, Fwrite_region): Use it.
1349 Use SEEK_SET, SEEK_CUR, SEEK_END as appropriate.
1350
566684ea
PE
1351 * fns.c (Fload_average): Don't assume 100 * load average fits in int.
1352
e6966cd6
PE
1353 * fns.c: Don't overflow int when computing a list length.
1354 * fns.c (QUIT_COUNT_HEURISTIC): New constant.
1355 (Flength, Fsafe_length): Use EMACS_INT, not int, to avoid unwanted
1356 truncation on 64-bit hosts. Check for QUIT every
1357 QUIT_COUNT_HEURISTIC entries rather than every other entry; that's
1358 faster and is responsive enough.
1359 (Flength): Report an error instead of overflowing an integer.
1360 (Fsafe_length): Return a float if the value is not representable
1361 as a fixnum. This shouldn't happen except in contrived situations.
6346d301 1362 (Fnthcdr, Fsort): Don't assume list length fits in int.
de41a810 1363 (Fcopy_sequence): Don't assume vector length fits in int.
00c604f2 1364
dd0b0efb
PE
1365 * alloc.c: Check that resized vectors' lengths fit in fixnums.
1366 (header_size, word_size): New constants.
1367 (allocate_vectorlike): Don't check size overflow here.
1368 (allocate_vector): Check it here instead, since this is the only
1369 caller of allocate_vectorlike that could cause overflow.
1370 Check that the new vector's length is representable as a fixnum.
1371
86fe5cfe
PE
1372 * fns.c (next_almost_prime): Don't return a multiple of 3 or 5.
1373 The previous code was bogus. For example, next_almost_prime (32)
1374 returned 39, which is undesirable as it is a multiple of 3; and
1375 next_almost_prime (24) returned 25, which is a multiple of 5 so
1376 why was the code bothering to check for multiples of 7?
1377
80e88859
PE
1378 * bytecode.c (exec_byte_code): Use ptrdiff_t, not int, for vector length.
1379
4a2f0ad6
PE
1380 * eval.c, doprnt.c (SIZE_MAX): Remove; inttypes.h defines this now.
1381
f66c7cf8
PE
1382 Variadic C functions now count arguments with ptrdiff_t.
1383 This partly undoes my 2011-03-30 change, which replaced int with size_t.
1384 Back then I didn't know that the Emacs coding style prefers signed int.
1385 Also, in the meantime I found a few more instances where arguments
4a2f0ad6
PE
1386 were being counted with int, which may truncate counts on 64-bit
1387 machines, or EMACS_INT, which may be unnecessarily wide.
f66c7cf8
PE
1388 * lisp.h (struct Lisp_Subr.function.aMANY)
1389 (DEFUN_ARGS_MANY, internal_condition_case_n, safe_call):
1390 Arg counts are now ptrdiff_t, not size_t.
1391 All variadic functions and their callers changed accordingly.
1392 (struct gcpro.nvars): Now size_t, not size_t. All uses changed.
1393 * bytecode.c (exec_byte_code): Check maxdepth for overflow,
1394 to avoid potential buffer overrun. Don't assume arg counts fit in 'int'.
1395 * callint.c (Fcall_interactively): Check arg count for overflow,
1396 to avoid potential buffer overrun. Use signed char, not 'int',
1397 for 'varies' array, so that we needn't bother to check its size
1398 calculation for overflow.
1399 * editfns.c (Fformat): Use ptrdiff_t, not EMACS_INT, to count args.
1400 * eval.c (apply_lambda):
1401 * fns.c (Fmapconcat): Use XFASTINT, not XINT, to get args length.
1402 (struct textprop_rec.argnum): Now ptrdiff_t, not int. All uses changed.
1403 (mapconcat): Use ptrdiff_t, not int and EMACS_INT, to count args.
1404
a1759b76
PE
1405 * callint.c (Fcall_interactively): Don't use index var as event count.
1406
d96be9fc
PE
1407 * vm-limit.c (check_memory_limits): Fix incorrect extern function decls.
1408 * mem-limits.h (SIZE): Remove; no longer used.
1409
a690a978 1410 * xterm.c (x_alloc_nearest_color_1): Prefer int to long when int works.
5efd304b 1411
578c21e6
PE
1412 Remove unnecessary casts.
1413 * xterm.c (x_term_init):
1414 * xfns.c (x_set_border_pixel):
1415 * widget.c (create_frame_gcs): Remove casts to unsigned long etc.
1416 These aren't needed now that we assume ANSI C.
1417
96f53c6c
PE
1418 * sound.c (Fplay_sound_internal): Remove cast to unsigned long.
1419 It's more likely to cause problems (due to unsigned overflow)
1420 than to cure them.
1421
83c77d31
PE
1422 * dired.c (Ffile_attributes): Don't use 32-bit hack on 64-bit hosts.
1423
ee2079f1
PE
1424 * unexelf.c (unexec): Don't assume BSS addr fits in unsigned.
1425
6da65536
PE
1426 * xterm.c (handle_one_xevent): Omit unnecessary casts to unsigned.
1427
7147c4a4
PE
1428 * keyboard.c (modify_event_symbol): Don't limit alist len to UINT_MAX.
1429
193e32d9
PE
1430 * lisp.h (CHAR_TABLE_SET): Omit now-redundant test.
1431
e5533da6
PE
1432 * lread.c (Fload): Don't compare a possibly-garbage time_t value.
1433
9910e595
PE
1434 GLYPH_CODE_FACE returns EMACS_INT, not int.
1435 * dispextern.h (merge_faces):
1436 * xfaces.c (merge_faces):
01103c44
PE
1437 * xdisp.c (get_next_display_element, next_element_from_display_vector):
1438 Don't assume EMACS_INT fits in int.
9910e595 1439
2638320e
PE
1440 * character.h (CHAR_VALID_P): Remove unused parameter.
1441 * fontset.c, lisp.h, xdisp.c: All uses changed.
1442
045eb8d9
PE
1443 * editfns.c (Ftranslate_region_internal): Omit redundant test.
1444
c1f134b5
PE
1445 * fns.c (concat): Minor tuning based on overflow analysis.
1446 This doesn't fix any bugs. Use int to hold character, instead
1447 of constantly refetching from Emacs object. Use XFASTINT, not
1448 XINT, for value known to be a character. Don't bother comparing
1449 a single byte to 0400, as it's always less.
1450
395fcb93 1451 * floatfns.c (Fexpt):
327eeec8
PE
1452 * fileio.c (make_temp_name): Omit unnecessary cast to unsigned.
1453
abbd3d23
PE
1454 * editfns.c (Ftranslate_region_internal): Use int, not EMACS_INT
1455 for characters.
1456
684a03ef
PE
1457 * doc.c (get_doc_string): Omit (unsigned)c that mishandled negatives.
1458
0fed43f3
PE
1459 * data.c (Faset): If ARRAY is a string, check that NEWELT is a char.
1460 Without this fix, on a 64-bit host (aset S 0 4294967386) would
1461 incorrectly succeed when S was a string, because 4294967386 was
1462 truncated before it was used.
1463
8fd02eb7
PE
1464 * chartab.c (Fchar_table_range): Use CHARACTERP to check range.
1465 Otherwise, an out-of-range integer could cause undefined behavior
1466 on a 64-bit host.
1467
f8c86b69
PE
1468 * composite.c: Use int, not EMACS_INT, for characters.
1469 (fill_gstring_body, composition_compute_stop_pos): Use int, not
1470 EMACS_INT, for values that are known to be in character range.
1471 This doesn't fix any bugs but is the usual style inside Emacs and
1472 may generate better code on 32-bit machines.
1473
34206dd2
PE
1474 Make sure a 64-bit char is never passed to ENCODE_CHAR.
1475 This is for reasons similar to the recent CHAR_STRING fix.
1476 * charset.c (Fencode_char): Check that character arg is actually
1477 a character. Pass an int to ENCODE_CHAR.
1478 * charset.h (ENCODE_CHAR): Verify that the character argument is no
1479 wider than 'int', as a compile-time check to prevent future regressions
1480 in this area.
1481
c5958d4c 1482 * character.c (char_string): Remove unnecessary casts.
13bdea59
PE
1483
1484 Make sure a 64-bit char is never passed to CHAR_STRING.
1485 Otherwise, CHAR_STRING would do the wrong thing on a 64-bit platform,
1486 by silently ignoring the top 32 bits, allowing some values
1487 that were far too large to be valid characters.
1488 * character.h: Include <verify.h>.
1489 (CHAR_STRING, CHAR_STRING_ADVANCE): Verify that the character
1490 arguments are no wider than unsigned, as a compile-time check
1491 to prevent future regressions in this area.
1492 * data.c (Faset):
01103c44 1493 * editfns.c (Fchar_to_string, general_insert_function, Finsert_char)
13bdea59
PE
1494 (Fsubst_char_in_region):
1495 * fns.c (concat):
1496 * xdisp.c (decode_mode_spec_coding):
1497 Adjust to CHAR_STRING's new requirement.
1498 * editfns.c (Finsert_char, Fsubst_char_in_region):
1499 * fns.c (concat): Check that character args are actually
1500 characters. Without this test, these functions did the wrong
1501 thing with wildly out-of-range values on 64-bit hosts.
1502
d37ca623
PE
1503 Remove incorrect casts to 'unsigned' that lose info on 64-bit hosts.
1504 These casts should not be needed on 32-bit hosts, either.
1505 * keyboard.c (read_char):
1506 * lread.c (Fload): Remove casts to unsigned.
1507
ea204efb
PE
1508 * lisp.h (UNSIGNED_CMP): New macro.
1509 This fixes comparison bugs on 64-bit hosts.
1510 (ASCII_CHAR_P): Use it.
1511 * casefiddle.c (casify_object):
01103c44 1512 * character.h (ASCII_BYTE_P, CHAR_VALID_P)
ea204efb
PE
1513 (SINGLE_BYTE_CHAR_P, CHAR_STRING):
1514 * composite.h (COMPOSITION_ENCODE_RULE_VALID):
1515 * dispextern.h (FACE_FROM_ID):
1516 * keyboard.c (read_char): Use UNSIGNED_CMP.
1517
41cb286c
PE
1518 * xmenu.c (dialog_selection_callback) [!USE_GTK]: Cast to intptr_t,
1519 not to EMACS_INT, to avoid GCC warning.
1520
4a1b9832
PE
1521 * xfns.c (x_set_scroll_bar_default_width): Remove unused 'int' locals.
1522
55daad71
PE
1523 * buffer.h (PTR_BYTE_POS, BUF_PTR_BYTE_POS): Remove harmful cast.
1524 The cast incorrectly truncated 64-bit byte offsets to 32 bits, and
1525 isn't needed on 32-bit machines.
8f95c75c 1526
01103c44
PE
1527 * buffer.c (Fgenerate_new_buffer_name):
1528 Use EMACS_INT for count, not int.
0ceccced 1529 (advance_to_char_boundary): Return EMACS_INT, not int.
e762cafe
PE
1530
1531 * data.c (Qcompiled_function): Now static.
1532
c6f072e7
PE
1533 * window.c (window_body_lines): Now static.
1534
20ce5912
PE
1535 * image.c (gif_load): Rename local to avoid shadowing.
1536
9c4c5f81
PE
1537 * lisp.h (SAFE_ALLOCA_LISP): Check for integer overflow.
1538 (struct Lisp_Save_Value): Use ptrdiff_t, not int, for 'integer' member.
1539 * alloc.c (make_save_value): Integer argument is now of type
1540 ptrdiff_t, not int.
1541 (mark_object): Use ptrdiff_t, not int.
1542 * lisp.h (pD): New macro.
1543 * print.c (print_object): Use it.
1544
c0c5c8ae
PE
1545 * alloc.c: Use EMACS_INT, not int, to count objects.
1546 (total_conses, total_markers, total_symbols, total_vector_size)
1547 (total_free_conses, total_free_markers, total_free_symbols)
01103c44
PE
1548 (total_free_floats, total_floats, total_free_intervals)
1549 (total_intervals, total_strings, total_free_strings):
c0c5c8ae
PE
1550 Now EMACS_INT, not int. All uses changed.
1551 (Fgarbage_collect): Compute overall total using a double, so that
1552 integer overflow is less likely to be a problem. Check for overflow
1553 when converting back to an integer.
5a25e253
PE
1554 (n_interval_blocks, n_string_blocks, n_float_blocks, n_cons_blocks)
1555 (n_vectors, n_symbol_blocks, n_marker_blocks): Remove.
1556 These were 'int' variables that could overflow on 64-bit hosts;
1557 they were never used, so remove them instead of repairing them.
211a0b2a 1558 (nzombies, ngcs, max_live, max_zombies): Now EMACS_INT, not 'int'.
6349ae4d
PE
1559 (inhibit_garbage_collection): Set gc_cons_threshold to max value.
1560 Previously, this ceilinged at INT_MAX, but that doesn't work on
1561 64-bit machines.
e46bb31a 1562 (allocate_pseudovector): Don't use EMACS_INT when int would do.
c0c5c8ae 1563
c78baabf 1564 * alloc.c (Fmake_bool_vector): Don't assume vector size fits in int.
86f61a15 1565 (allocate_vectorlike): Check for ptrdiff_t overflow.
b6439961
PE
1566 (mark_vectorlike, mark_char_table, mark_object): Avoid EMACS_UINT
1567 when a (possibly-narrower) signed value would do just as well.
1568 We prefer using signed arithmetic, to avoid comparison confusion.
c78baabf 1569
c9d624c6
PE
1570 * alloc.c: Catch some string size overflows that we were missing.
1571 (XMALLOC_OVERRUN_CHECK_SIZE) [!XMALLOC_OVERRUN_CHECK]: Define to 0,
1572 for convenience in STRING_BYTES_MAX.
1573 (STRING_BYTES_MAX): New macro, superseding the old one in lisp.h.
1574 The definition here is exact; the one in lisp.h was approximate.
1575 (allocate_string_data): Check for string overflow. This catches
1576 some instances we weren't catching before. Also, it catches
1577 size_t overflow on (unusual) hosts where SIZE_MAX <= min
1578 (PTRDIFF_MAX, MOST_POSITIVE_FIXNUM), e.g., when size_t is 32 bits
1579 and ptrdiff_t and EMACS_INT are both 64 bits.
c78baabf 1580
c9d624c6
PE
1581 * character.c, coding.c, doprnt.c, editfns.c, eval.c:
1582 All uses of STRING_BYTES_MAX replaced by STRING_BYTES_BOUND.
1583 * lisp.h (STRING_BYTES_BOUND): Renamed from STRING_BYTES_MAX.
1584
353032ce
PE
1585 * character.c (string_escape_byte8): Fix nbytes/nchars typo.
1586
2bccce07
PE
1587 * alloc.c (Fmake_string): Check for out-of-range init.
1588
0ac30604
SM
15892011-06-15 Stefan Monnier <monnier@iro.umontreal.ca>
1590
1591 * eval.c (Fdefvaralias): Also mark the target as variable-special-p.
1592
c195f2de
JD
15932011-06-14 Jan Djärv <jan.h.d@swipnet.se>
1594
1595 * xfns.c (x_set_scroll_bar_default_width): Remove argument to
1596 xg_get_default_scrollbar_width.
1597
1598 * gtkutil.c: Include emacsgtkfixed.h if HAVE_GTK3.
1599 (int_gtk_range_get_value): Move to the scroll bar part of the file.
1600 (style_changed_cb): Call update_theme_scrollbar_width and call
1601 x_set_scroll_bar_default_width and xg_frame_set_char_size for
1602 all frames (Bug#8505).
1603 (xg_create_frame_widgets): Call emacs_fixed_new if HAVE_GTK3 (Bug#8505).
1604 Call gtk_window_set_resizable if HAVE_GTK3.
1605 (x_wm_set_size_hint): Call emacs_fixed_set_min_size with min width
1606 and height if HAVE_GTK3 (Bug#8505).
1607 (scroll_bar_width_for_theme): New variable.
1608 (update_theme_scrollbar_width): New function.
1609 (xg_get_default_scrollbar_width): Move code to
1610 update_theme_scrollbar_width, just return scroll_bar_width_for_theme.
1611 (xg_initialize): Call update_theme_scrollbar_width.
1612
1613 * gtkutil.h (xg_get_default_scrollbar_width): Remove argument.
1614
1615 * emacsgtkfixed.c, emacsgtkfixed.h: New files.
1616
e10ac9f1
MR
16172011-06-12 Martin Rudalics <rudalics@gmx.at>
1618
1619 * frame.c (make_frame): Call other_buffer_safely instead of
1620 other_buffer.
1621
1622 * window.c (temp_output_buffer_show): Call display_buffer with
1623 second argument Vtemp_buffer_show_specifiers and reset latter
1624 immediately after the call.
1625 (Vtemp_buffer_show_specifiers): New variable.
1626 (auto_window_vscroll_p, next_screen_context_lines)
1627 (Vscroll_preserve_screen_position): Remove leading asterisks from
1628 doc-strings.
1629
2d3c217e 16302011-06-12 Paul Eggert <eggert@cs.ucla.edu>
4475bec4 1631
7b7f97e8 1632 Fix minor problems found by GCC 4.6.0 static checking.
4475bec4
PE
1633 * buffer.c (Qclone_number): Remove for now, as it's unused.
1634 (record_buffer, Funrecord_buffer): Rename local to avoid shadowing.
1635 (record_buffer): Remove unused local.
1636 * frame.c (other_visible_frames, frame_buffer_list): Now static.
1637 (set_frame_buffer_list): Remove; unused.
1638 * frame.h (other_visible_frames): Remove decl.
1639 * keyboard.h (menu_items_inuse): Declare only if USE_GTK || USE_MOTIF.
1640 * lisp.h (frame_buffer_list, set_frame_buffer_list): Remove decls.
1641 (add_gpm_wait_descriptor, delete_gpm_wait_descriptor): Declare only
1642 if HAVE_GPM.
1643 * menu.c (menu_items_inuse): Now static unless USE_GTK || USE_MOTIF.
1644 * process.c (add_gpm_wait_descriptor, delete_gpm_wait_descriptor):
1645 Define only if HAVE_GPM.
1646 * widget.c (EmacsFrameResize, emacsFrameClassRec): Now static.
1647 (update_hints_inhibit): Remove; never set. All uses removed.
1648 * widgetprv.h (emacsFrameClassRec): Remove decl.
1649 * window.c (delete_deletable_window): Now returns void, since it
1650 wasn't returning anything.
1651 (compare_window_configurations): Remove unused locals.
1652 * xfns.c (x_set_scroll_bar_default_width): Remove unused locals.
1653 * xmenu.c (x_menu_set_in_use): Define only if USE_GTK || USE_MOTIF.
4475bec4
PE
1654 (dialog_selection_callback) [!USE_GTK]: Prefer intptr_t for integers
1655 the same widths as pointers. This follows up on the 2011-05-06 patch.
1656 * xterm.c (x_alloc_lighter_color_for_widget): Define only if USE_LUCID.
1657 * xterm.h: Likewise.
1658 (x_menu_set_in_use): Declare only if USE_GTK || USE_MOTIF.
1659
1384b89e
JB
16602011-06-12 Juanma Barranquero <lekktu@gmail.com>
1661
1662 * makefile.w32-in: Update dependencies.
1663 (LISP_H): Add lib/intprops.h.
1664
1100a63c
CY
16652011-06-11 Chong Yidong <cyd@stupidchicken.com>
1666
1667 * image.c (gif_load): Add animation frame delay to the metadata.
1668 (syms_of_image): Use DEFSYM. New symbol `delay'.
1669
6198ccd0
MR
16702011-06-11 Martin Rudalics <rudalics@gmx.at>
1671
1672 * window.c (delete_deletable_window): Re-add.
1673 (Fset_window_configuration): Rewrite to handle dead buffers and
1674 consequently deletable windows.
1675 (window_tree, Fwindow_tree): Remove. Supply functionality in
1676 window.el.
1677 (compare_window_configurations): Simplify code.
1678
b6e3633c
AS
16792011-06-11 Andreas Schwab <schwab@linux-m68k.org>
1680
1ab0dee5
AS
1681 * image.c (imagemagick_load_image): Fix type mismatch.
1682 (Fimagemagick_types): Likewise.
1683
b6e3633c
AS
1684 * window.h (replace_buffer_in_windows): Declare.
1685
9397e56f
MR
16862011-06-11 Martin Rudalics <rudalics@gmx.at>
1687
1688 * buffer.c: New Lisp objects Qbuffer_list_update_hook and
1689 Qclone_number. Remove external declaration of Qdelete_window.
1690 (Fbuffer_list): Rewrite doc-string. Minor restructuring of
1691 code.
1692 (Fget_buffer_create, Fmake_indirect_buffer, Frename_buffer): Run
1693 Qbuffer_list_update_hook if allowed.
1694 (Fother_buffer): Rewrite doc-string. Major rewrite for new
1695 buffer list implementation.
1696 (other_buffer_safely): New function.
1697 (Fkill_buffer): Replace call to replace_buffer_in_all_windows by
1698 calls to replace_buffer_in_windows and
1699 replace_buffer_in_windows_safely. Run Qbuffer_list_update_hook
1700 if allowed.
1701 (record_buffer): Inhibit quitting and rewrite using quittable
1702 functions. Run Qbuffer_list_update_hook if allowed.
1703 (Frecord_buffer, Funrecord_buffer): New functions.
1704 (switch_to_buffer_1, Fswitch_to_buffer): Remove. Move
1705 switch-to-buffer to window.el.
1706 (bury-buffer): Move to window.el.
1707 (Vbuffer_list_update_hook): New variable.
1708
1709 * lisp.h (other_buffer_safely): Add prototype in buffer.c
1710 section.
1711
1712 * window.h (resize_frame_windows): Move up in code.
1713 (Fwindow_frame): Remove EXFUN.
1714 (replace_buffer_in_all_windows): Remove prototype.
1715 (replace_buffer_in_windows_safely): Add prototype.
1716
1717 * window.c: Declare Qdelete_window static again. Move down
1718 declaration of select_count.
1719 (Fnext_window, Fprevious_window): Rewrite doc-strings.
1720 (Fother_window): Move to window.el.
1721 (window_loop): Remove DELETE_BUFFER_WINDOWS and UNSHOW_BUFFER
1722 cases. Add REPLACE_BUFFER_IN_WINDOWS_SAFELY case.
1723 (Fdelete_windows_on, Freplace_buffer_in_windows): Move to
1724 window.el.
1725 (replace_buffer_in_windows): Implement by calling
1726 Qreplace_buffer_in_windows.
1727 (replace_buffer_in_all_windows): Remove with some functionality
1728 moved into replace_buffer_in_windows_safely.
1729 (replace_buffer_in_windows_safely): New function.
1730 (select_window_norecord, select_frame_norecord): Move in front
1731 of run_window_configuration_change_hook. Remove now obsolete
1732 declarations.
1733 (Fset_window_buffer): Rewrite doc-string. Call
1734 Qrecord_window_buffer.
1735 (keys_of_window): Move binding for other-window to window.el.
1736
b50691aa
CY
17372011-06-11 Chong Yidong <cyd@stupidchicken.com>
1738
1739 * dispextern.h (struct image): Replace data member, whose int_val
1740 and ptr_val fields were not used by anything, with a single
1741 lisp_val object.
1742
1743 * image.c (Fimage_metadata, make_image, mark_image, tiff_load)
1744 (gif_clear_image, gif_load, imagemagick_load_image)
1745 (gs_clear_image, gs_load): Callers changed.
1746
3f754b86
PE
17472011-06-10 Paul Eggert <eggert@cs.ucla.edu>
1748
cca69397
PE
1749 * buffer.h: Include <time.h>, for time_t.
1750 Needed to build on FreeBSD 8.2. Problem reported by Herbert J. Skuhra.
1751
109e28d0
PE
1752 Fix minor problems found by static checking.
1753
60737f02
PE
1754 * image.c (PixelGetMagickColor): Declare if ImageMagick headers don't.
1755
4b66faf3
PE
1756 Make identifiers static if they are not used in other modules.
1757 * data.c (Qcompiled_function, Qframe, Qvector):
1758 * image.c (QimageMagick, Qsvg):
1759 * minibuf.c (Qmetadata):
1760 * window.c (resize_window_check, resize_root_window): Now static.
1761 * window.h (resize_window_check, resize_root_window): Remove decls.
1762
109e28d0
PE
1763 * window.c (window_deletion_count, delete_deletable_window):
1764 Remove; unused.
46a4ce9e
PE
1765 (window_body_lines): Now static.
1766 (Fdelete_other_windows_internal): Mark vars as initialized.
1767 Make sure 'resize_failed' is initialized.
1768 (run_window_configuration_change_hook): Rename local to avoid shadowing.
1769 (resize_window_apply): Remove unused local.
1770 * window.h (delete_deletable_window): Remove decl.
1771
109e28d0 1772 * image.c (gif_load, svg_load_image): Rename locals to avoid shadowing.
33290528
PE
1773 (imagemagick_load_image): Fix pointer signedness problem by changing
1774 last arg from unsigned char * to char *. All uses changed.
1775 Also, fix a local for similar reasons.
1776 Remove unused locals. Remove locals to avoid shadowing.
1777 (fn_rsvg_handle_free): Remove; unused.
1778 (svg_load, svg_load_image): Fix pointer signedness problem.
f7e13da3 1779 (imagemagick_load_image): Don't use garbage pointer image_wand.
33290528 1780
3f754b86
PE
1781 * ftfont.c (ftfont_get_metrics, ftfont_drive_otf): Remove unused locals.
1782
2547adb1
CY
17832011-06-10 Chong Yidong <cyd@stupidchicken.com>
1784
1785 * image.c (gif_load): Fix omitted cast error introduced by
1786 2011-06-06 change.
1787
2c8e37d4
MR
17882011-06-10 Martin Rudalics <rudalics@gmx.at>
1789
1790 * window.h (resize_proportionally, orig_total_lines)
1791 (orig_top_line): Remove from window structure.
1792 (set_window_height, set_window_width, change_window_heights)
1793 (Fdelete_window): Remove prototypes.
1794 (resize_frame_windows): Remove duplicate declaration.
1795
440a42e3
EZ
17962011-06-10 Eli Zaretskii <eliz@gnu.org>
1797
1798 * window.h (resize_frame_windows, resize_window_check)
1799 (delete_deletable_window, resize_root_window)
1800 (resize_frame_windows): Declare prototypes.
1801
1802 * window.c (resize_window_apply): Make definition be "static" to
1803 match the prototype.
1804
562dd5e9
MR
18052011-06-10 Martin Rudalics <rudalics@gmx.at>
1806
1807 * window.c: Remove declarations of Qwindow_size_fixed,
1808 window_min_size_1, window_min_size_2, window_min_size,
1809 size_window, window_fixed_size_p, enlarge_window, delete_window.
1810 Remove static from declaration of Qdelete_window, it's
1811 temporarily needed by Fbury_buffer.
1812 (replace_window): Don't assign orig_top_line and
1813 orig_total_lines.
1814 (Fdelete_window, delete_window): Remove. Window deletion is
1815 handled by window.el.
1816 (window_loop): Remove DELETE_OTHER_WINDOWS case. Replace
1817 Fdelete_window calls with calls to Qdelete_window.
1818 (Fdelete_other_windows): Remove. Deleting other windows is
1819 handled by window.el.
1820 (window_fixed_size_p): Remove. Fixed-sizeness of windows is
1821 handled in window.el.
1822 (window_min_size_2, window_min_size_1, window_min_size): Remove.
1823 Window minimum sizes are handled in window.el.
1824 (shrink_windows, size_window, set_window_height)
1825 (set_window_width, change_window_heights, window_height)
1826 (window_width, CURBEG, CURSIZE, enlarge_window)
1827 (adjust_window_trailing_edge, Fadjust_window_trailing_edge)
1828 (Fenlarge_window, Fshrink_window): Remove. Window resizing is
1829 handled in window.el.
1830 (make_dummy_parent): Rename to make_parent_window and give it a
1831 second argument horflag.
1832 (make_window): Don't set resize_proportionally any more.
1833 (Fsplit_window): Remove. Windows are split in window.el.
1834 (save_restore_action, save_restore_orig_size)
1835 (shrink_window_lowest_first, save_restore_orig_size): Remove.
1836 Resize mini windows in window.el.
1837 (grow_mini_window, shrink_mini_window): Implement by calling
1838 Qresize_root_window_vertically, resize_window_check and
1839 resize_window_apply.
1840 (saved_window, Fset_window_configuration, save_window_save): Do
1841 not handle orig_top_line, orig_total_lines, and
1842 resize_proportionally.
1843 (window_min_height, window_min_width): Move to window.el.
1844 (keys_of_window): Move bindings for delete-other-windows,
1845 split-window, delete-window and enlarge-window to window.el.
1846
1847 * buffer.c: Temporarily extern Qdelete_window.
1848 (Fbury_buffer): Temporarily call Qdelete_window instead of
1849 Fdelete_window (Fbury_buffer will move to window.el soon).
1850
1851 * frame.c (set_menu_bar_lines_1): Remove code handling
1852 orig_top_line and orig_total_lines.
1853
1854 * dispnew.c (adjust_frame_glyphs_initially): Don't use
1855 set_window_height but set heights directly.
1856 (change_frame_size_1): Use resize_frame_windows.
1857
1858 * xdisp.c (init_xdisp): Don't use set_window_height but set
1859 heights directly.
1860
1861 * xfns.c (x_set_menu_bar_lines, x_set_tool_bar_lines): Use
1862 resize_frame_windows instead of change_window_heights and run
1863 run_window_configuration_change_hook.
1864
1865 * w32fns.c (x_set_tool_bar_lines): Use resize_frame_windows
1866 instead of change_window_heights and run
1867 run_window_configuration_change_hook.
1868
1a13852e
MR
18692011-06-09 Martin Rudalics <rudalics@gmx.at>
1870
1871 * window.c (replace_window): Rename second argument REPLACEMENT to
1872 NEW. New third argument SETFLAG. Rewrite.
1873 (delete_window, make_dummy_parent): Call replace_window with
1874 third argument 1.
1875 (window_list_1): Move down in code.
1876 (run_window_configuration_change_hook): Move set_buffer part
1877 before select_frame_norecord part in order to unwind correctly.
1878 Rename count1 to count.
1879 (recombine_windows, delete_deletable_window, resize_root_window)
1880 (Fdelete_other_windows_internal)
1881 (Frun_window_configuration_change_hook, make_parent_window)
1882 (resize_window_check, resize_window_apply, Fresize_window_apply)
1883 (resize_frame_windows, Fsplit_window_internal)
1884 (Fdelete_window_internal, Fresize_mini_window_internal): New
1885 functions.
1886 (syms_of_window): New variables Vwindow_splits and Vwindow_nest.
1887
f3d1777e
MR
18882011-06-08 Martin Rudalics <rudalics@gmx.at>
1889
496e208e
MR
1890 * window.h (window): Add some new members to window structure -
1891 normal_lines, normal_cols, new_total, new_normal, clone_number,
1892 splits, nest, prev_buffers, next_buffers.
1893 (WINDOW_TOTAL_SIZE): Move here from window.c.
b9e809c2 1894 (MIN_SAFE_WINDOW_WIDTH, MIN_SAFE_WINDOW_HEIGHT): Define here.
496e208e 1895
f3d1777e
MR
1896 * window.c (Fwindow_height, Fwindow_width, Fwindow_full_width_p):
1897 Remove.
496e208e
MR
1898 (make_dummy_parent): Set new members of windows structure.
1899 (make_window): Move down in code. Handle new members of window
1900 structure.
1901 (Fwindow_clone_number, Fwindow_splits, Fset_window_splits)
1902 (Fwindow_nest, Fset_window_nest, Fwindow_new_total)
1903 (Fwindow_normal_size, Fwindow_new_normal, Fwindow_prev_buffers)
1904 (Fset_window_prev_buffers, Fwindow_next_buffers)
1905 (Fset_window_next_buffers, Fset_window_clone_number): New
1906 functions.
1907 (Fwindow_hscroll, Fwindow_at, Fwindow_point, Fwindow_start)
1908 (Fwindow_end, Fwindow_line_height, Fset_window_dedicated_p):
1909 Doc-string fixes.
1910 (Fwindow_parameters, Fwindow_parameter, Fset_window_parameter):
1911 Argument WINDOW can be now internal window too.
1912 (Fwindow_use_time): Move up in code.
1913 (Fget_buffer_window): Rename argument FRAME to ALL-FRAMES.
1914 Rewrite doc-string.
1915 (Fset_window_configuration, saved_window)
1916 (Fcurrent_window_configuration, save_window_save): Handle new
1917 members of window structure.
b9e809c2
MR
1918 (WINDOW_TOTAL_SIZE, MIN_SAFE_WINDOW_WIDTH)
1919 (MIN_SAFE_WINDOW_HEIGHT): Move to window.h.
1920 (syms_of_window): New Lisp objects Qrecord_window_buffer,
1921 Qwindow_deletable_p, Qdelete_window, Qreplace_buffer_in_windows,
1922 Qget_mru_window, Qresize_root_window,
1923 Qresize_root_window_vertically, Qsafe, Qabove, Qbelow,
1924 Qauto_buffer_name; staticpro them.
f3d1777e 1925
abde8f8c
MR
19262011-06-07 Martin Rudalics <rudalics@gmx.at>
1927
1928 * window.c (Fwindow_total_size, Fwindow_left_column)
1929 (Fwindow_top_line, window_body_lines, Fwindow_body_size)
1930 (Fwindow_list_1): New functions.
1931 (window_box_text_cols): Replace with window_body_cols.
1932 (Fwindow_width, Fscroll_left, Fscroll_right): Use
1933 window_body_cols instead of window_box_text_cols.
fa8a67e6
MR
1934 (delete_window, Fset_window_configuration): Call
1935 delete_all_subwindows with window as argument.
1936 (delete_all_subwindows): Take a window as argument and not a
1937 structure. Rewrite.
190b47e6
MR
1938 (window_loop): Remove handling of GET_LRU_WINDOW and
1939 GET_LARGEST_WINDOW.
1940 (Fget_lru_window, Fget_largest_window): Move to window.el.
abde8f8c
MR
1941
1942 * window.h: Extern window_body_cols instead of
fa8a67e6
MR
1943 window_box_text_cols. delete_all_subwindows now takes a
1944 Lisp_Object as argument.
abde8f8c
MR
1945
1946 * indent.c (compute_motion, Fcompute_motion): Use
1947 window_body_cols instead of window_box_text_cols.
1948
fa8a67e6
MR
1949 * frame.c (delete_frame): Call delete_all_subwindows with root
1950 window as argument.
1951
a54e3482
DC
19522011-06-07 Daniel Colascione <dan.colascione@gmail.com>
1953
1954 * fns.c (Fputhash): Document return value.
1955
60002bf5
CY
19562011-06-06 Chong Yidong <cyd@stupidchicken.com>
1957
1958 * image.c (gif_load): Implement gif89a spec "no disposal" method.
1959
0c671da6 19602011-06-06 Paul Eggert <eggert@cs.ucla.edu>
ccd9a01a 1961
b862a52a 1962 Cons<->int and similar integer overflow fixes (Bug#8794).
77984278 1963
be44ca6c
PE
1964 Check for overflow when converting integer to cons and back.
1965 * charset.c (Fdefine_charset_internal, Fdecode_char):
1966 Use cons_to_unsigned to catch overflow.
1967 (Fencode_char): Use INTEGER_TO_CONS.
1968 * composite.h (LGLYPH_CODE): Use cons_to_unsigned.
1969 (LGLYPH_SET_CODE): Use INTEGER_TO_CONS.
1970 * data.c (long_to_cons, cons_to_long): Remove.
1971 (cons_to_unsigned, cons_to_signed): New functions.
1972 These signal an error for invalid or out-of-range values.
1973 * dired.c (Ffile_attributes): Use INTEGER_TO_CONS.
1974 * fileio.c (Fset_visited_file_modtime): Use CONS_TO_INTEGER.
1975 * font.c (Ffont_variation_glyphs):
1976 * fontset.c (Finternal_char_font): Use INTEGER_TO_CONS.
1977 * lisp.h: Include <intprops.h>.
1978 (INTEGER_TO_CONS, CONS_TO_INTEGER): New macros.
1979 (cons_to_signed, cons_to_unsigned): New decls.
1980 (long_to_cons, cons_to_long): Remove decls.
1981 * undo.c (record_first_change): Use INTEGER_TO_CONS.
1982 (Fprimitive_undo): Use CONS_TO_INTEGER.
1983 * xfns.c (Fx_window_property): Likewise.
1984 * xselect.c: Include <limits.h>.
1985 (x_own_selection, selection_data_to_lisp_data):
1986 Use INTEGER_TO_CONS.
1987 (x_handle_selection_request, x_handle_selection_clear)
1988 (x_get_foreign_selection, Fx_disown_selection_internal)
1989 (Fx_get_atom_name, x_send_client_event): Use CONS_TO_INTEGER.
1990 (lisp_data_to_selection_data): Use cons_to_unsigned.
1991 (x_fill_property_data): Use cons_to_signed.
1992 Report values out of range.
1993
d1f3d2af
PE
1994 Check for buffer and string overflow more precisely.
1995 * buffer.h (BUF_BYTES_MAX): New macro.
1996 * lisp.h (STRING_BYTES_MAX): New macro.
1997 * alloc.c (Fmake_string):
1998 * character.c (string_escape_byte8):
1999 * coding.c (coding_alloc_by_realloc):
2000 * doprnt.c (doprnt):
2001 * editfns.c (Fformat):
2002 * eval.c (verror):
2003 Use STRING_BYTES_MAX, not MOST_POSITIVE_FIXNUM,
2004 since they may not be the same number.
2005 * editfns.c (Finsert_char):
2006 * fileio.c (Finsert_file_contents):
2007 Likewise for BUF_BYTES_MAX.
2008
dd52fcea
PE
2009 * image.c: Use ptrdiff_t, not int, for sizes.
2010 (slurp_file): Switch from int to ptrdiff_t.
2011 All uses changed.
2012 (slurp_file): Check that file size fits in both size_t (for
2013 malloc) and ptrdiff_t (for sanity and safety).
2014
7f9bbdbb
PE
2015 * fileio.c (Fverify_visited_file_modtime): Avoid time overflow
2016 if b->modtime has its maximal value.
2017
dfe18f82
PE
2018 * dired.c (Ffile_attributes): Don't assume EMACS_INT has >32 bits.
2019
84acfcf0
PE
2020 Don't assume time_t can fit into int.
2021 * buffer.h (struct buffer.modtime): Now time_t, not int.
2022 * fileio.c (Fvisited_file_modtime): No need for time_t cast now.
2023 * undo.c (Fprimitive_undo): Use time_t, not int, for time_t value.
2024
ccd9a01a
PE
2025 Minor fixes for signed vs unsigned integers.
2026 * character.h (MAYBE_UNIFY_CHAR):
2027 * charset.c (maybe_unify_char):
2028 * keyboard.c (read_char, reorder_modifiers):
2029 XINT -> XFASTINT, since the integer must be nonnegative.
2030 * ftfont.c (ftfont_spec_pattern):
2031 * keymap.c (access_keymap, silly_event_symbol_error):
2032 XUINT -> XFASTINT, since the integer must be nonnegative.
2033 (Fsingle_key_description, preferred_sequence_p): XUINT -> XINT,
2034 since it makes no difference and we prefer signed.
2035 * keyboard.c (record_char): Use XUINT when all the neighbors do.
2036 (access_keymap): NATNUMP -> INTEGERP, since the integer must be
2037 nonnegative.
2038
d6d100dd
SM
20392011-06-06 Stefan Monnier <monnier@iro.umontreal.ca>
2040
2041 * window.h (Fwindow_frame): Declare.
2042
2b6148e4
PE
20432011-06-06 Paul Eggert <eggert@cs.ucla.edu>
2044
2045 * alloc.c: Simplify handling of large-request failures (Bug#8800).
2046 (SPARE_MEMORY): Always define.
2047 (LARGE_REQUEST): Remove.
2048 (memory_full): Use SPARE_MEMORY rather than LARGE_REQUEST.
2049
f230ecc9
MR
20502011-06-06 Martin Rudalics <rudalics@gmx.at>
2051
727e958e
MR
2052 * lisp.h: Move EXFUNS for Fframe_root_window,
2053 Fframe_first_window and Fset_frame_selected_window to window.h.
2054
2055 * window.h: Move EXFUNS for Fframe_root_window,
2056 Fframe_first_window and Fset_frame_selected_window here from
2057 lisp.h.
2058
2059 * frame.c (Fwindow_frame, Fframe_first_window)
2060 (Fframe_root_window, Fframe_selected_window)
2061 (Fset_frame_selected_window): Move to window.c.
2062 (Factive_minibuffer_window): Move to minibuf.c.
2063 (Fother_visible_frames_p): New function.
2064
2065 * minibuf.c (Factive_minibuffer_window): Move here from frame.c.
2066
f230ecc9
MR
2067 * window.c (decode_window, decode_any_window): Move up in code.
2068 (Fwindowp, Fwindow_live_p): Rewrite doc-strings.
2069 (inhibit_frame_unsplittable): Remove unused variable.
bf60a96b
MR
2070 (Fwindow_buffer): Move up and rewrite doc-string.
2071 (Fwindow_parent, Fwindow_vchild, Fwindow_hchild, Fwindow_next)
2072 (Fwindow_prev): New functions.
727e958e
MR
2073 (Fwindow_frame): Move here from frame.c. Accept any window as
2074 argument.
2075 (Fframe_root_window, Fframe_first_window)
2076 (Fframe_selected_window): Move here from frame.c. Accept frame
2077 or arbitrary window as argument. Update doc-strings.
2078 (Fminibuffer_window): Move up in code.
2079 (Fwindow_minibuffer_p): Move up in code and simplify.
d6d100dd
SM
2080 (Fset_frame_selected_window): Move here from frame.c.
2081 Marginal rewrite.
727e958e
MR
2082 (Fselected_window, select_window, Fselect_window): Move up in
2083 code. Minor doc-string fixes.
f230ecc9 2084
4d09bcf6
PE
20852011-06-06 Paul Eggert <eggert@cs.ucla.edu>
2086
2087 * alloc.c (memory_full) [SYSTEM_MALLOC]: Port to MacOS (Bug#8800).
2088 Do not assume that spare memory exists; that assumption is valid
2089 only if SYSTEM_MALLOC.
2090 (LARGE_REQUEST): New macro, so that the issue of large requests
2091 is separated from the issue of spare memory.
2092
810928a2
AS
20932011-06-05 Andreas Schwab <schwab@linux-m68k.org>
2094
172418ad
AS
2095 * editfns.c (Fformat): Correctly handle zero flag with hexadecimal
2096 format. (Bug#8806)
2097
43f862f7
AS
2098 * gtkutil.c (xg_get_default_scrollbar_width): Avoid warning.
2099
810928a2
AS
2100 * xfns.c (x_set_scroll_bar_default_width): Move declarations
2101 before statements.
2102
a059fe24
JD
21032011-06-05 Jan Djärv <jan.h.d@swipnet.se>
2104
2105 * gtkutil.c (xg_get_default_scrollbar_width): New function.
2106
2107 * gtkutil.h: Declare xg_get_default_scrollbar_width.
2108
2109 * xfns.c (x_set_scroll_bar_default_width): If USE_GTK, get
2110 min width by calling x_set_scroll_bar_default_width (Bug#8505).
2111
989bf368
JB
21122011-06-05 Juanma Barranquero <lekktu@gmail.com>
2113
2114 * xdisp.c (single_display_spec_intangible_p): Remove declaration.
2115
4b80f674
CY
21162011-06-04 Chong Yidong <cyd@stupidchicken.com>
2117
2118 * xselect.c (x_clipboard_manager_save): Remove redundant arg.
2119 (x_clipboard_manager_save): Add return value.
d6d100dd
SM
2120 (x_clipboard_manager_error_1, x_clipboard_manager_error_2):
2121 New error handlers.
4b80f674
CY
2122 (x_clipboard_manager_save_frame, x_clipboard_manager_save_all):
2123 Obey Vx_select_enable_clipboard_manager. Catch errors in
2124 x_clipboard_manager_save (Bug#8779).
2125 (Vx_select_enable_clipboard_manager): New variable.
de65b42c 2126 (x_get_foreign_selection): Reduce scope of x_catch_errors (Bug#8790).
4b80f674 2127
99a33b77 21282011-06-04 Dan Nicolaescu <dann@ics.uci.edu>
8b3115e7
DN
2129
2130 * emacs.c (main): Warn when starting a GTK emacs in daemon mode.
2131
99a33b77 21322011-06-04 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
14eca62f
YM
2133
2134 * fringe.c (update_window_fringes): Don't update overlay arrow bitmap
2135 in the current matrix if keep_current_p is non-zero.
2136
8264569d
EZ
21372011-06-04 Eli Zaretskii <eliz@gnu.org>
2138
2139 * bidi.c (bidi_level_of_next_char): Fix last change.
2140
57f97249
EZ
21412011-06-03 Eli Zaretskii <eliz@gnu.org>
2142
fec2107c 2143 Support bidi reordering of text covered by display properties.
57f97249 2144
fec2107c
EZ
2145 * bidi.c (bidi_copy_it): Use offsetof instead of emulating it.
2146 (bidi_fetch_char, bidi_fetch_char_advance): New functions.
2147 (bidi_cache_search, bidi_cache_iterator_state)
2148 (bidi_paragraph_init, bidi_resolve_explicit, bidi_resolve_weak)
d6d100dd
SM
2149 (bidi_level_of_next_char, bidi_move_to_visually_next):
2150 Support character positions inside a run of characters covered by a
fec2107c
EZ
2151 display string.
2152 (bidi_paragraph_init, bidi_resolve_explicit_1)
2153 (bidi_level_of_next_char): Call bidi_fetch_char and
2154 bidi_fetch_char_advance instead of FETCH_CHAR and
2155 FETCH_CHAR_ADVANCE.
2156 (bidi_init_it): Initialize new members.
2157 (LRE_CHAR, RLE_CHAR, PDF_CHAR, LRO_CHAR, RLO_CHAR): Remove macro
2158 definitions.
2159 (bidi_explicit_dir_char): Lookup character type in bidi_type_table,
2160 instead of using explicit *_CHAR codes.
d6d100dd
SM
2161 (bidi_resolve_explicit, bidi_resolve_weak):
2162 Use FETCH_MULTIBYTE_CHAR instead of FETCH_CHAR, as reordering of
fec2107c
EZ
2163 bidirectional text is supported only in multibyte buffers.
2164 (bidi_init_it): Accept additional argument FRAME_WINDOW_P and use
2165 it to initialize the frame_window_p member of struct bidi_it.
2166 (bidi_cache_iterator_state, bidi_resolve_explicit_1)
2167 (bidi_resolve_explicit, bidi_resolve_weak)
2168 (bidi_level_of_next_char, bidi_move_to_visually_next): Abort if
2169 bidi_it->nchars is non-positive.
2170 (bidi_level_of_next_char): Don't try to lookup the cache for the
2171 next/previous character if nothing is cached there yet, or if we
2172 were just reseat()'ed to a new position.
c40e2fb2 2173
0e14fe90
EZ
2174 * xdisp.c (set_cursor_from_row): Set start and stop points
2175 according to the row's direction when priming the loop that looks
2176 for the glyph on which to display cursor.
2177 (single_display_spec_intangible_p): Function deleted.
2178 (display_prop_intangible_p): Reimplement to call
2179 handle_display_spec instead of single_display_spec_intangible_p.
d6d100dd
SM
2180 Accept 3 additional arguments needed by handle_display_spec.
2181 This fixes incorrect cursor motion across display property with complex
0e14fe90
EZ
2182 values: lists, `(when COND...)' forms, etc.
2183 (single_display_spec_string_p): Support property values that are
2184 lists with the argument STRING its top-level element.
2185 (display_prop_string_p): Fix the condition for processing a
2186 property that is a list to be consistent with handle_display_spec.
fec2107c 2187 (handle_display_spec): New function, refactored from the
fc6f18ce
EZ
2188 last portion of handle_display_prop.
2189 (compute_display_string_pos): Accept additional argument
2190 FRAME_WINDOW_P. Call handle_display_spec to determine whether the
2191 value of a `display' property is a "replacing spec".
2192 (handle_single_display_spec): Accept 2 additional arguments BUFPOS
2193 and FRAME_WINDOW_P. If IT is NULL, don't set up the iterator from
2194 the display property, but just return a value indicating whether
2195 the display property will replace the characters it covers.
2196 (Fcurrent_bidi_paragraph_direction): Initialize the nchars and
2197 frame_window_p members of struct bidi_it.
d6d100dd
SM
2198 (compute_display_string_pos, compute_display_string_end):
2199 New functions.
fec2107c
EZ
2200 (push_it): Accept second argument POSITION, where pop_it should
2201 jump to continue iteration.
2202 (reseat_1): Initialize bidi_it.disp_pos.
fc6f18ce 2203
fec2107c
EZ
2204 * keyboard.c (adjust_point_for_property): Adjust the call to
2205 display_prop_intangible_p to its new signature.
fc6f18ce
EZ
2206
2207 * dispextern.h (struct bidi_it): New member frame_window_p.
fec2107c
EZ
2208 (bidi_init_it): Update prototypes.
2209 (display_prop_intangible_p): Update prototype.
d6d100dd
SM
2210 (compute_display_string_pos, compute_display_string_end):
2211 Declare prototypes.
fec2107c
EZ
2212 (struct bidi_it): New members nchars and disp_pos. ch_len is now
2213 EMACS_INT.
fc6f18ce 2214
40087514 22152011-06-02 Paul Eggert <eggert@cs.ucla.edu>
0de4bb68 2216
57f53182
PE
2217 Malloc failure behavior now depends on size of allocation.
2218 * alloc.c (buffer_memory_full, memory_full): New arg NBYTES.
2219 * lisp.h: Change signatures accordingly.
2220 * alloc.c, buffer.c, editfns.c, menu.c, minibuf.c, xterm.c:
2221 All callers changed. (Bug#8762)
2222
2223 * gnutls.c: Use Emacs's memory allocators.
2224 Without this change, the gnutls library would invoke malloc etc.
2225 directly, which causes problems on non-SYNC_INPUT hosts, and which
2226 runs afoul of improving memory_full behavior. (Bug#8761)
2227 (fn_gnutls_global_set_mem_functions): New macro or function pointer.
2228 (emacs_gnutls_global_init): Use it to specify xmalloc, xrealloc,
2229 xfree instead of the default malloc, realloc, free.
2230 (Fgnutls_boot): No need to check for memory allocation failure,
2231 since xmalloc does that for us.
2232
ac32cd99 2233 Remove arbitrary limit of 2**31 entries in hash tables. (Bug#8771)
3870d916
PE
2234 * category.c (hash_get_category_set):
2235 * ccl.c (ccl_driver):
2236 * charset.c (Fdefine_charset_internal):
2237 * charset.h (struct charset.hash_index):
2238 * composite.c (get_composition_id, gstring_lookup_cache)
2239 (composition_gstring_put_cache):
2240 * composite.h (struct composition.hash_index):
2241 * dispextern.h (struct image.hash):
2242 * fns.c (next_almost_prime, larger_vector, cmpfn_eql)
2243 (cmpfn_equal, cmpfn_user_defined, hashfn_eq, hashfn_eql)
2244 (hashfn_equal, hashfn_user_defined, make_hash_table)
2245 (maybe_resize_hash_table, hash_lookup, hash_put)
2246 (hash_remove_from_table, hash_clear, sweep_weak_table, SXHASH_COMBINE)
2247 (sxhash_string, sxhash_list, sxhash_vector, sxhash_bool_vector)
2248 (Fsxhash, Fgethash, Fputhash, Fmaphash):
2249 * image.c (make_image, search_image_cache, lookup_image)
2250 (xpm_put_color_table_h):
2251 * lisp.h (struct Lisp_Hash_Table):
0de4bb68 2252 * minibuf.c (Ftry_completion, Fall_completions, Ftest_completion):
ac389d0c 2253 * print.c (print): Use 'EMACS_UINT' and 'EMACS_INT'
3870d916 2254 for hashes and hash indexes, instead of 'unsigned' and 'int'.
40087514
PE
2255 * alloc.c (allocate_vectorlike):
2256 Check for overflow in vector size calculations.
2257 * ccl.c (ccl_driver):
2258 Check for overflow when converting EMACS_INT to int.
0de4bb68
PE
2259 * fns.c, image.c: Remove unnecessary static decls that would otherwise
2260 need to be updated by these changes.
40087514
PE
2261 * fns.c (make_hash_table, maybe_resize_hash_table):
2262 Check for integer overflow with large hash tables.
0de4bb68
PE
2263 (make_hash_table, maybe_resize_hash_table, Fmake_hash_table):
2264 Prefer the faster XFLOAT_DATA to XFLOATINT where either will do.
2265 (SXHASH_REDUCE): New macro.
2266 (sxhash_string, sxhash_list, sxhash_vector, sxhash_bool_vector):
2267 Use it instead of discarding useful hash info with large hash values.
2268 (sxhash_float): New function.
2269 (sxhash): Use it. No more need for "& INTMASK" due to above changes.
2270 * lisp.h (FIXNUM_BITS): New macro, useful for SXHASH_REDUCE etc.
40087514
PE
2271 (MOST_NEGATIVE_FIXNUM, MOST_POSITIVE_FIXNUM, INTMASK):
2272 Rewrite to use FIXNUM_BITS, as this simplifies things.
0de4bb68
PE
2273 (next_almost_prime, larger_vector, sxhash, hash_lookup, hash_put):
2274 Adjust signatures to match updated version of code.
2275 (consing_since_gc): Now EMACS_INT, since a single hash table can
2276 use more than INT_MAX bytes.
2277
698d32e2
DN
22782011-06-01 Dan Nicolaescu <dann@ics.uci.edu>
2279
2280 Make it possible to build with GCC-4.6+ -O2 -flto.
2281
2282 * emacs.c (__malloc_initialize_hook): Mark as EXTERNALLY_VISIBLE.
2283
fd6fa53f
SM
22842011-06-01 Stefan Monnier <monnier@iro.umontreal.ca>
2285
2286 * minibuf.c (get_minibuffer, read_minibuf_unwind):
2287 Call minibuffer-inactive-mode.
2288
864db017
JB
22892011-05-31 Juanma Barranquero <lekktu@gmail.com>
2290
2291 * makefile.w32-in ($(BLD)/data.$(O), $(BLD)/editfns.$(O)):
2292 Update dependencies.
2293
2ad0baf4
DN
22942011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
2295
2296 * data.c (init_data): Remove code for UTS, this system is not
2297 supported anymore.
2298
4fcc2638
DN
22992011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
2300
2301 Don't force ./temacs to start in terminal mode.
2302
2303 * frame.c (make_initial_frame): Initialize faces in all cases, not
2304 only when CANNOT_DUMP is defined.
2305 * dispnew.c (init_display): Remove CANNOT_DUMP condition.
2306
c56e0fd5
DN
23072011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
2308
2309 * dispnew.c (add_window_display_history): Use const for the string
2310 pointer. Remove declaration, not needed.
2311
333d54da 23122011-05-31 Paul Eggert <eggert@cs.ucla.edu>
9cf9f756 2313
55d4c1b2 2314 Use 'inline', not 'INLINE'.
333d54da 2315 <http://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00914.html>
55d4c1b2
PE
2316 * alloc.c, fontset.c (INLINE): Remove.
2317 * alloc.c, bidi.c, charset.c, coding.c, dispnew.c, fns.c, image.c:
2318 * intervals.c, keyboard.c, process.c, syntax.c, textprop.c, w32term.c:
2319 * xdisp.c, xfaces.c, xterm.c: Replace all uses of INLINE with inline.
2320 * gmalloc.c (register_heapinfo): Use inline unconditionally.
2321 * lisp.h (LISP_MAKE_RVALUE): Use inline, not __inline__.
2322
738db178
DN
23232011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
2324
2325 Make it possible to run ./temacs.
2326
2327 * callproc.c (set_initial_environment): Remove CANNOT_DUMP code,
2328 syms_of_callproc does the same thing. Remove test for
2329 "initialized", do it in the caller.
2330 * emacs.c (main): Avoid calling set_initial_environment when dumping.
2331
620c53a6
SM
23322011-05-31 Stefan Monnier <monnier@iro.umontreal.ca>
2333
2334 * minibuf.c (Finternal_complete_buffer): Return `category' metadata.
2335 (read_minibuf): Use get_minibuffer.
2336 (syms_of_minibuf): Use DEFSYM.
2337 (Qmetadata): New var.
2338 * data.c (Qbuffer): Don't make it static.
2339 (syms_of_data): Use DEFSYM.
2340
e003a292
PE
23412011-05-31 Paul Eggert <eggert@cs.ucla.edu>
2342
2343 * ccl.c (CCL_CODE_RANGE): Allow negative numbers. (Bug#8751)
2344 (CCL_CODE_MIN): New macro.
2345
ed008a6d
PE
23462011-05-30 Paul Eggert <eggert@cs.ucla.edu>
2347
3687c2ef
PE
2348 * alloc.c (lisp_align_malloc): Omit unnecessary val==NULL tests.
2349
ed008a6d
PE
2350 * eval.c (Qdebug): Now static.
2351 * lisp.h (Qdebug): Remove decl. This reverts a part of the
2352 2011-04-26T11:26:05Z!dan.colascione@gmail.com that inadvertently undid part of
2353 2011-04-14T06:48:41Z!eggert@cs.ucla.edu.
2354
d66c4c7c
CY
23552011-05-29 Chong Yidong <cyd@stupidchicken.com>
2356
2357 * image.c: Various fixes to ImageMagick code comments.
2358 (Fimagemagick_types): Doc fix.
2359
5fbc2025
PE
23602011-05-29 Paul Eggert <eggert@cs.ucla.edu>
2361
0196f88a
PE
2362 Minor fixes prompted by GCC 4.6.0 warnings.
2363
2364 * xselect.c (converted_selections, conversion_fail_tag): Now static.
2365
5fbc2025
PE
2366 * emacs.c [HAVE_X_WINDOWS]: Include "xterm.h".
2367 (x_clipboard_manager_save_all): Move extern decl to ...
2368 * xterm.h: ... here, so that it can be checked for consistency.
2369
1dd3c2d9
CY
23702011-05-29 Chong Yidong <cyd@stupidchicken.com>
2371
2372 * xselect.c (x_clipboard_manager_save_frame)
2373 (x_clipboard_manager_save_all): New functions.
2374 (Fx_clipboard_manager_save): Lisp function deleted.
2375
2376 * emacs.c (Fkill_emacs): Call x_clipboard_manager_save_all.
2377 * frame.c (delete_frame): Call x_clipboard_manager_save_frame.
2378
2379 * xterm.h: Update prototype.
2380
5ba6571d
WX
23812011-05-28 William Xu <william.xwl@gmail.com>
2382
2383 * nsterm.m (ns_term_shutdown): Synchronize user defaults before
2384 exiting (Bug#8239).
2385
3eaff834
JM
23862011-05-28 Jim Meyering <meyering@redhat.com>
2387
e1900994 2388 Avoid a sign-extension bug in crypto_hash_function.
3eaff834
JM
2389 * fns.c (to_uchar): Define.
2390 (crypto_hash_function): Use it to convert some newly-signed
2391 variables to unsigned, to avoid sign-extension bugs. For example,
2392 without this change, (md5 "truc") would evaluate to
2393 45723a2aff78ff4fff7fff1114760e62 rather than the expected
2394 45723a2af3788c4ff17f8d1114760e62. Reported by Antoine Levitt in
e1900994 2395 https://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00883.html.
3eaff834 2396
0f6990a7
PE
23972011-05-27 Paul Eggert <eggert@cs.ucla.edu>
2398
2399 Integer overflow fixes.
c8a9ca5a 2400
08686060
PE
2401 * dbusbind.c: Serial number integer overflow fixes.
2402 (CHECK_DBUS_SERIAL_GET_SERIAL): New macro.
08686060
PE
2403 (Fdbus_call_method_asynchronously, xd_read_message_1): Use a float
2404 to hold a serial number that is too large for a fixnum.
2405 (Fdbus_method_return_internal, Fdbus_method_error_internal):
2406 Check for serial numbers out of range. Decode any serial number
59568bf0 2407 that was so large that it became a float. (Bug#8722)
08686060 2408
2d1fc3c7
PE
2409 * dbusbind.c: Use XFASTINT rather than XUINT, and check for nonneg.
2410 (Fdbus_call_method, Fdbus_call_method_asynchronously):
2411 Use XFASTINT rather than XUINT when numbers are nonnegative.
2412 (xd_append_arg, Fdbus_method_return_internal):
2413 (Fdbus_method_error_internal): Likewise. Also, for unsigned
2414 arguments, check that Lisp number is nonnegative, rather than
59568bf0 2415 silently wrapping negative numbers around. (Bug#8722)
30217ff0 2416 (xd_read_message_1): Don't assume dbus_uint32_t can fit in int.
59568bf0 2417 (Bug#8722)
2d1fc3c7 2418
c8a9ca5a
PE
2419 * data.c (arith_driver, Flsh): Avoid unnecessary casts to EMACS_UINT.
2420
519e1d69
PE
2421 * ccl.c (ccl_driver): Redo slightly to avoid the need for 'unsigned'.
2422
30569699
PE
2423 ccl: add integer overflow checks
2424 * ccl.c (CCL_CODE_MAX, GET_CCL_RANGE, GET_CCL_CODE, GET_CCL_INT):
2425 (IN_INT_RANGE): New macros.
2426 (ccl_driver): Use them to check for integer overflow when
2427 decoding a CCL program. Many of the new checks are whether XINT (x)
2428 fits in int; it doesn't always, on 64-bit hosts. The new version
2429 doesn't catch all possible integer overflows, but it's an
847044ea 2430 improvement. (Bug#8719)
30569699 2431
c11285dc
PE
2432 * alloc.c (make_event_array): Use XINT, not XUINT.
2433 There's no need for unsigned here.
2434
fdccd48e
PE
2435 * mem-limits.h (EXCEEDS_LISP_PTR) [!USE_LSB_TAG]: EMACS_UINT -> uintptr_t
2436 This follows up to the 2011-05-06 change that substituted uintptr_t
2437 for EMACS_INT. This case wasn't caught back then.
2438
37910ab2
PE
2439 Rework Fformat to avoid integer overflow issues.
2440 * editfns.c: Include <float.h> unconditionally, as it's everywhere
2441 now (part of C89). Include <verify.h>.
2442 (MAX_10_EXP, CONVERTED_BYTE_SIZE): Remove; no longer needed.
2443 (pWIDE, pWIDElen, signed_wide, unsigned_wide): New defns.
2444 (Fformat): Avoid the prepass trying to compute sizes; it was only
2445 approximate and thus did not catch overflow reliably. Instead, walk
2446 through the format just once, formatting and computing sizes as we go,
2447 checking for integer overflow at every step, and allocating a larger
2448 buffer as needed. Keep track separately whether the format is
2449 multibyte. Keep only the most-recently calculated precision, rather
2450 than them all. Record whether each argument has been converted to
2451 string. Use EMACS_INT, not int, for byte and char and arg counts.
2452 Support field widths and precisions larger than INT_MAX. Avoid
2453 sprintf's undefined behavior with conversion specifications such as %#d
2454 and %.0c. Fix bug with strchr succeeding on '\0' when looking for
2455 flags. Fix bug with (format "%c" 256.0). Avoid integer overflow when
2456 formatting out-of-range floating point numbers with int
9173deec 2457 formats. (Bug#8668)
37910ab2 2458
2e6578fb
PE
2459 * lisp.h (FIXNUM_OVERFLOW_P): Work even if arg is a NaN.
2460
0ae6bdee
PE
2461 * data.c: Avoid integer truncation in expressions involving floats.
2462 * data.c: Include <intprops.h>.
2463 (arith_driver): When there's an integer overflow in an expression
2464 involving floating point, convert the integers to floating point
2465 so that the resulting value does not suffer from catastrophic
2466 integer truncation. For example, on a 64-bit host (* 4
2467 most-negative-fixnum 0.5) should yield about -4.6e+18, not zero.
2468 Do not rely on undefined behavior after integer overflow.
2469
de883a70
PE
2470 merge count_size_as_multibyte, parse_str_to_multibyte
2471 * character.c, character.h (count_size_as_multibyte):
fd6fa53f 2472 Rename from parse_str_to_multibyte; all uses changed.
de883a70
PE
2473 Check for integer overflow.
2474 * insdel.c, lisp.h (count_size_as_multibyte): Remove,
2475 since it's now a duplicate of the other. This is more of
2476 a character than a buffer op, so better that it's in character.c.
2477 * fns.c, print.c: Adjust to above changes.
2478
2ff916cb
PE
24792011-05-27 Stefan Monnier <monnier@iro.umontreal.ca>
2480
2481 * xselect.c (x_convert_selection): Yet another int/Lisp_Object mixup.
2482
f1b54466
PE
24832011-05-27 Paul Eggert <eggert@cs.ucla.edu>
2484
fb1ac845
PE
2485 * xselect.c: Fix minor problems prompted by GCC 4.6.0 warnings.
2486 (x_handle_selection_request, frame_for_x_selection): Remove unused vars.
2487 (x_clipboard_manager_save): Now static.
2488 (Fx_clipboard_manager_save): Rename local to avoid shadowing.
2489
f1b54466
PE
2490 * fns.c: Fix minor problems prompted by GCC 4.6.0 warnings.
2491 (crypto_hash_function): Now static.
2492 Fix pointer signedness problems. Avoid unnecessary initializations.
2493
a9f737ee
CY
24942011-05-27 Chong Yidong <cyd@stupidchicken.com>
2495
2496 * termhooks.h (Vselection_alist): Make it terminal-local.
2497
2498 * terminal.c (create_terminal): Initialize it.
2499
2500 * xselect.c: Support for clipboard managers.
2501 (Vselection_alist): Move to termhooks.h as terminal-local var.
2502 (LOCAL_SELECTION): New macro.
2503 (x_atom_to_symbol): Handle x_display_info_for_display fail case.
2504 (symbol_to_x_atom): Remove gratuitous arg.
2505 (x_handle_selection_request, lisp_data_to_selection_data)
2506 (x_get_foreign_selection, Fx_register_dnd_atom): Callers changed.
620c53a6
SM
2507 (x_own_selection, x_get_local_selection, x_convert_selection):
2508 New arg, specifying work frame. Use terminal-local Vselection_alist.
a9f737ee
CY
2509 (some_frame_on_display): Delete unused function.
2510 (Fx_own_selection_internal, Fx_get_selection_internal)
2511 (Fx_disown_selection_internal, Fx_selection_owner_p)
2512 (Fx_selection_exists_p): New optional frame arg.
2513 (frame_for_x_selection, Fx_clipboard_manager_save): New functions.
2514 (x_handle_selection_clear): Don't treat other terminals with the
2515 same keyboard specially. Use the terminal-local Vselection_alist.
2516 (x_clear_frame_selections): Use Frun_hook_with_args.
2517
2518 * xterm.c (x_term_init): Intern ATOM and CLIPBOARD_MANAGER atoms.
2519
2520 * xterm.h: Add support for those atoms.
2521
e067f0c1
CY
25222011-05-26 Chong Yidong <cyd@stupidchicken.com>
2523
2524 * xselect.c: ICCCM-compliant handling of MULTIPLE targets.
2525 (converted_selections, conversion_fail_tag): New global variables.
2526 (x_selection_request_lisp_error): Free the above.
2527 (x_get_local_selection): Remove unnecessary code.
2528 (x_reply_selection_request): Args changed; handle arbitrary array
620c53a6
SM
2529 of converted selections stored in converted_selections.
2530 Separate the XChangeProperty and SelectionNotify steps.
e067f0c1
CY
2531 (x_handle_selection_request): Rewrite to handle MULTIPLE target.
2532 (x_convert_selection): New function.
2533 (x_handle_selection_event): Simplify.
2534 (x_get_foreign_selection): Don't ignore incoming requests while
2535 waiting for an answer; this will fail when we implement
2536 SAVE_TARGETS, and seems unnecessary anyway.
2537 (selection_data_to_lisp_data): Recognize ATOM_PAIR type.
2538 (Vx_sent_selection_functions): Doc fix.
2539
0f4aebc0
LL
25402011-05-26 Leo Liu <sdl.web@gmail.com>
2541
2542 * editfns.c (Ftranspose_regions): Allow empty regions. (Bug#8699)
2543
e61124cd
YM
25442011-05-25 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
2545
2546 * dispextern.h (struct glyph_row): New member fringe_bitmap_periodic_p.
2547
2548 * dispnew.c (shift_glyph_matrix, scrolling_window): Mark scrolled row
2549 for fringe update if it has periodic bitmap.
ac389d0c 2550 (row_equal_p): Also compare left_fringe_offset, right_fringe_offset,
e61124cd
YM
2551 and fringe_bitmap_periodic_p.
2552
2553 * fringe.c (get_fringe_bitmap_data): New function.
2554 (draw_fringe_bitmap_1, update_window_fringes): Use it.
2555 (update_window_fringes): Record periodicity of fringe bitmap in glyph
2556 row. Mark glyph row for fringe update if periodicity changed.
2557
2558 * xdisp.c (try_window_reusing_current_matrix): Don't mark scrolled row
2559 for fringe update unless it has periodic bitmap.
2560
f16d9837
KH
25612011-05-25 Kenichi Handa <handa@m17n.org>
2562
2563 * xdisp.c (get_next_display_element): Set correct it->face_id for
2564 a static composition.
2565
e1b90ef6
LL
25662011-05-24 Leo Liu <sdl.web@gmail.com>
2567
2568 * deps.mk (fns.o):
2569 * makefile.w32-in ($(BLD)/fns.$(O)): Include sha1.h.
2570
2571 * fns.c (crypto_hash_function, Fsha1): New function.
2572 (Fmd5): Use crypto_hash_function.
2573 (syms_of_fns): Add Ssha1.
2574
7400048f
PE
25752011-05-22 Paul Eggert <eggert@cs.ucla.edu>
2576
2577 * gnutls.c: Remove unused macros.
2578 (fn_gnutls_transport_set_lowat, fn_gnutls_transport_set_pull_function):
2579 (fn_gnutls_transport_set_push_function) [!WINDOWSNT]:
2580 Remove macros that are defined and never used.
2581 Caught by gcc -Wunused-macros (GCC 4.6.0, Fedora 14).
2582
abb71cf4
CY
25832011-05-22 Chong Yidong <cyd@stupidchicken.com>
2584
2585 * xselect.c (syms_of_xselect): Remove unused symbol SAVE_TARGETS.
2586 (Fx_get_selection_internal): Minor cleanup.
2587 (Fx_own_selection_internal): Rename arguments for consistency with
2588 select.el.
2589
6307db39
PE
25902011-05-22 Paul Eggert <eggert@cs.ucla.edu>
2591
2592 * xselect.c (QSAVE_TARGETS): New static var, to fix build failure.
2593
f3d4e0a4
CY
25942011-05-22 Chong Yidong <cyd@stupidchicken.com>
2595
2596 * xselect.c (syms_of_xselect): Include character.h; use DEFSYM.
2597
4d8ade89
YM
25982011-05-21 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
2599
2600 * dispnew.c (scrolling_window): Don't exclude the case that the
2601 last enabled row in the desired matrix touches the bottom boundary.
2602
32078c8d
GM
26032011-05-21 Glenn Morris <rgm@gnu.org>
2604
2605 * Makefile.in ($(etc)/DOC): Make second command line even shorter.
33cf345f
GM
2606 (SOME_MACHINE_OBJECTS): Replace FONT_OBJ by its maximal expansion,
2607 and add some more files.
32078c8d 2608
7285dc67
EZ
26092011-05-20 Eli Zaretskii <eliz@gnu.org>
2610
2611 * callproc.c (Fcall_process) [MSDOS]: Fix arguments to
2612 report_file_error introduced by the change from 2011-05-07.
2613
89d1bd22
PE
26142011-05-20 Paul Eggert <eggert@cs.ucla.edu>
2615
2616 * systime.h (Time): Define only if emacs is defined.
2617 This is to allow ../lib-src/profile.c to be compiled on FreeBSD,
2618 where the include path doesn't have X11/X.h by default. See
2619 <http://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00561.html>.
2620
e23640bb 26212011-05-20 Kenichi Handa <handa@m17n.org>
31bfc35c
KH
2622
2623 * composite.c (find_automatic_composition): Fix previous change.
2624
b9704ad9
GM
26252011-05-20 Glenn Morris <rgm@gnu.org>
2626
2627 * lisp.mk: New file, split from Makefile.in.
2628 * Makefile.in (lisp): Move to separate file, inserted by @lisp_frag@.
2629 (shortlisp): Remove.
2630 ($(etc)/DOC): Edit lisp.mk rather than using $shortlisp.
2631
4a720484
GM
26322011-05-19 Glenn Morris <rgm@gnu.org>
2633
2634 * Makefile.in (MSDOS_SUPPORT_REAL, MSDOS_SUPPORT, NS_SUPPORT)
2635 (REAL_MOUSE_SUPPORT, GPM_MOUSE_SUPPORT, MOUSE_SUPPORT, TOOLTIP_SUPPORT)
2636 (BASE_WINDOW_SUPPORT, X_WINDOW_SUPPORT, WINDOW_SUPPORT): Remove.
2637 (lisp): Set the order to that of loadup.el.
2638 (shortlisp): Make it a copy of $lisp.
2639 (SOME_MACHINE_LISP): Remove.
2640 ($(etc)/DOC): Depend just on $lisp, not $SOME_MACHINE_LISP too.
2641 Use just $shortlisp, not $SOME_MACHINE_LISP too.
2642
a28d4396
KH
26432011-05-18 Kenichi Handa <handa@m17n.org>
2644
2645 * composite.c (CHAR_COMPOSABLE_P): Add more check for efficiency.
2646 (BACKWARD_CHAR): Wrap the arg STOP by parenthesis.
2647 (find_automatic_composition): Mostly rewrite for efficiency.
2648
a2b1fa8e
JB
26492011-05-18 Juanma Barranquero <lekktu@gmail.com>
2650
2651 * makefile.w32-in: Update dependencies.
2652
8e1f5610
CS
26532011-05-18 Christoph Scholtes <cschol2112@googlemail.com>
2654
2655 * menu.c: Include limits.h (fixes the MS-Windows build broken by
7d7d0045 2656 2011-06-18T18:49:19Z!cyd@stupidchicken.com).
8e1f5610 2657
7025ee00 26582011-05-18 Paul Eggert <eggert@cs.ucla.edu>
cb93f9be 2659
cdfa6eab
PE
2660 Fix some integer overflow issues, such as string length overflow.
2661
06d6db33
PE
2662 * insdel.c (count_size_as_multibyte): Check for string overflow.
2663
2b4560a8
PE
2664 * character.c (lisp_string_width): Check for string overflow.
2665 Use EMACS_INT, not int, for string indexes and lengths; in
2666 particular, 2nd arg is now EMACS_INT, not int. Do not crash if
2667 the resulting string length overflows an EMACS_INT; instead,
2668 report a string overflow if no precision given. When checking for
2669 precision exhaustion, use a check that cannot possibly have
2670 integer overflow. (Bug#8675)
2671 * character.h (lisp_string_width): Adjust to new signature.
2672
cb93f9be
PE
2673 * alloc.c (string_overflow): New function.
2674 (Fmake_string): Use it. This doesn't change behavior, but saves
2675 a few bytes and will simplify future changes.
2676 * character.c (string_escape_byte8): Likewise.
2677 * lisp.h (string_overflow): New decl.
2678
1a1f3366
PE
2679 Fixups, following up to the user-interface timestamp change.
2680 * nsterm.m (last_mouse_movement_time, ns_mouse_position): Use Time
2681 for UI timestamps, instead of unsigned long.
9fbd6841
PE
2682 * msdos.c (mouse_get_pos): Likewise.
2683 * w32inevt.c (movement_time, w32_console_mouse_position): Likewise.
1a1f3366
PE
2684 * w32gui.h (Time): Define by including "systime.h" rather than by
2685 declaring it ourselves. (Bug#8664)
2686
d4e3e4d3
PE
2687 * dispextern.h (struct image): Don't assume time_t <= unsigned long.
2688 * image.c (clear_image_cache): Likewise.
2689
f6a24d19
PE
2690 * term.c (term_mouse_position): Don't assume time_t wraparound.
2691
08dc5ae6
PE
2692 Be more systematic about user-interface timestamps.
2693 Before, the code sometimes used 'Time', sometimes 'unsigned long',
620c53a6
SM
2694 and sometimes 'EMACS_UINT', to represent these timestamps.
2695 This change causes it to use 'Time' uniformly, as that's what X uses.
08dc5ae6
PE
2696 This makes the code easier to follow, and makes it easier to catch
2697 integer overflow bugs such as Bug#8664.
2698 * frame.c (Fmouse_position, Fmouse_pixel_position):
2699 Use Time, not unsigned long, for user-interface timestamps.
2700 * keyboard.c (last_event_timestamp, kbd_buffer_get_event): Likewise.
2701 (button_down_time, make_lispy_position, make_lispy_movement): Likewise.
2702 * keyboard.h (last_event_timestamp): Likewise.
2703 * menu.c (Fx_popup_menu) [!HAVE_X_WINDOWS]: Likewise.
2704 * menu.h (xmenu_show): Likewise.
2705 * term.c (term_mouse_position): Likewise.
2706 * termhooks.h (struct input_event.timestamp): Likewise.
2707 (struct terminal.mouse_position_hook): Likewise.
2708 * xmenu.c (create_and_show_popup_menu, xmenu_show): Likewise.
2709 * xterm.c (XTmouse_position, x_scroll_bar_report_motion): Likewise.
2710 * systime.h (Time): New decl. Pull it in from <X11/X.h> if
2711 HAVE_X_WINDOWS, otherwise define it as unsigned long, which is
2712 what it was before.
2713 * menu.h, termhooks.h: Include "systime.h", for Time.
2714
8e55734a
PE
2715 * keyboard.c (make_lispy_event): Fix problem in integer overflow.
2716 Don't assume that the difference between two unsigned long values
2717 can fit into an integer. At this point, we know button_down_time
2718 <= event->timestamp, so the difference must be nonnegative, so
2719 there's no need to cast the result if double-click-time is
2720 nonnegative, as it should be; check that it's nonnegative, just in
2721 case. This bug is triggered when events are more than 2**31 ms
86db42d2 2722 apart (about 25 days). (Bug#8664)
8e55734a 2723
841f1b75 2724 * xselect.c (last_event_timestamp): Remove duplicate decl.
6434756c 2725 (x_own_selection): Remove needless cast to unsigned long.
841f1b75 2726
3e26f69c
PE
2727 * xmenu.c (set_frame_menubar): Use int, not EMACS_UINT, for indexes
2728 that always fit in int. Use a sentinel instead of a counter, to
2729 avoid a temp and to allay GCC's concerns about possible int overflow.
d230cb74
PE
2730 * frame.h (struct frame): Use int for menu_bar_items_used
2731 instead of EMACS_INT, since it always fits in int.
3e26f69c 2732
5cc152c0
PE
2733 * menu.c (grow_menu_items): Check for int overflow.
2734
d89eb65e
PE
2735 * xmenu.c (set_frame_menubar): Don't mishandle vectors with no nils.
2736
5235bd3e
PE
2737 * xterm.c: Use EMACS_INT for Emacs modifiers, and int for X modifiers.
2738 Before, the code was not consistent. These values cannot exceed
2739 2**31 - 1 so there's no need to make them unsigned.
2740 (x_x_to_emacs_modifiers): Accept int and return EMACS_INT.
2741 (x_emacs_to_x_modifiers): Accept EMACS_INT and return int.
2742 (x_x_to_emacs_modifiers, x_emacs_to_x_modifiers): Reject non-integers
2743 as modifiers.
2744 * xterm.h (x_x_to_emacs_modifiers): Adjust to signature change.
2745
bc827e23
PE
2746 * lisp.h (XINT) [USE_LISP_UNION_TYPE]: Cast to EMACS_INT.
2747 (XUINT) [USE_LISP_UNION_TYPE]: Cast to EMACS_UINT.
2748 Otherwise, GCC 4.6.0 warns about printf (pI, XINT (...)),
2749 presumably because the widths might not match.
2750
78eb494e
PE
2751 * window.c (size_window): Avoid needless test at loop start.
2752
04f2d78b
CB
27532011-05-18 Courtney Bane <emacs-bugs-7626@cbane.org> (tiny change)
2754
2755 * term.c (Fresume_tty): Restore hooks before reinitializing (bug#8687).
2756
d2fc7e3d 27572011-05-12 Drew Adams <drew.adams@oracle.com>
e531bdff
DA
2758
2759 * textprop.c (Fprevious_single_char_property_change): Doc fix (bug#8655).
2760
d2fc7e3d 27612011-05-12 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
7db47798
YM
2762
2763 * w32term.c (w32_draw_fringe_bitmap): Rename local vars `left' and
2764 `width' to `bar_area_x' and `bar_area_width', respectively.
2765 (x_scroll_run): Take account of fringe background extension.
2766
04f2d78b
CB
2767 * xterm.c (x_draw_fringe_bitmap) [USE_TOOLKIT_SCROLL_BARS]:
2768 Rename local vars `left' and `width' to `bar_area_x' and
7db47798
YM
2769 `bar_area_width', respectively.
2770 (x_scroll_run) [USE_TOOLKIT_SCROLL_BARS]: Take account of fringe
2771 background extension.
2772
79b70037
GM
27732011-05-10 Jim Meyering <meyering@redhat.com>
2774
2775 * xdisp.c (x_intersect_rectangles): Fix typo "the the -> the".
2776
2f142cc5
JB
27772011-05-10 Juanma Barranquero <lekktu@gmail.com>
2778
2779 * image.c (Finit_image_library): Return t for built-in image types,
2780 like pbm and xbm. (Bug#8640)
2781
57679c86
AS
27822011-05-09 Andreas Schwab <schwab@linux-m68k.org>
2783
2784 * w32menu.c (set_frame_menubar): Fix submenu allocation.
2785
888c9e86
EZ
27862011-05-07 Eli Zaretskii <eliz@gnu.org>
2787
b0512a1d
EZ
2788 * w32console.c (Fset_screen_color): Doc fix.
2789 (Fget_screen_color): New function.
2790 (syms_of_ntterm): Defsubr it.
2791
7285dc67
EZ
2792 * callproc.c (call_process_cleanup) [MSDOS]: Don't close and
2793 unlink the temporary file if Fcall_process didn't create it in the
2794 first place.
2795 (Fcall_process) [MSDOS]: Don't create tempfile if stdout of the
2796 child process will be redirected to a file specified with `:file'.
888c9e86
EZ
2797 Don't try to re-open tempfile in that case, and set fd[0] to -1 as
2798 cue to call_process_cleanup not to close that handle.
2799
4d3fcc8e
BK
28002011-05-07 Ben Key <bkey76@gmail.com>
2801
2802 * makefile.w32-in: The bootstrap-temacs rule now makes use of
2803 one of two shell specific rules, either bootstrap-temacs-CMD or
2804 bootstrap-temacs-SH. The bootstrap-temacs-SH rule is identical
2805 to the previous implementation of the bootstrap-temacs rule.
2806 The bootstrap-temacs-CMD rule is similar to the previous
2807 implementation of the bootstrap-temacs rule except that it
2808 makes use of the ESC_CFLAGS variable instead of the CFLAGS
2809 variable.
2810
2811 These changes, along with some changes to nt/configure.bat,
2812 nt/gmake.defs, and nt/nmake.defs, are required to extend my
2813 earlier fix to add support for --cflags and --ldflags options
2814 that include quotes so that it works whether make uses cmd or
2815 sh as the shell.
2816
b4289b64
MA
28172011-05-06 Michael Albinus <michael.albinus@gmx.de>
2818
2819 * dbusbind.c (QCdbus_type_unix_fd): Declare static.
2820 (xd_remove_watch): Don't check QCdbus_type_unix_fd for SYMBOLP, it
2821 is a constant.
2822 (Fdbus_init_bus, xd_read_queued_messages): Bus can be a symbol or
2823 a string. Handle both cases.
2824 (Fdbus_call_method_asynchronously, Fdbus_register_signal)
2825 (Fdbus_register_method): Use Qinvalid_function.
2826
af4c0e28
JB
28272011-05-06 Juanma Barranquero <lekktu@gmail.com>
2828
2829 * makefile.w32-in: Update dependencies.
2830 (LISP_H): Add inttypes.h and stdin.h.
2831 (PROCESS_H): Add unistd.h.
2832
c51453d9
EZ
28332011-05-06 Eli Zaretskii <eliz@gnu.org>
2834
2835 * lread.c: Include limits.h (fixes the MS-Windows build broken by
2836 2011-05-06T07:13:19Z!eggert@cs.ucla.edu).
2837
8ff0ac3c 28382011-05-06 Paul Eggert <eggert@cs.ucla.edu>
c032b5f8 2839
4c4b566b
PE
2840 * image.c (Finit_image_library) [!HAVE_NTGUI]: Omit unused local.
2841
aab2b9b5
PE
2842 * term.c (vfatal): Remove stray call to va_end.
2843 It's not needed and the C Standard doesn't allow it here anyway.
2844
c378da0b
PE
2845 Use C99's va_copy to avoid undefined behavior on x86-64 GNU/Linux.
2846 * eval.c (verror): doprnt a copy of ap, not the original. (Bug#8545)
2847
288b08c7
PE
2848 * eval.c (verror): OK to create a string of up to MOST_POSITIVE_FIXNUM
2849 bytes.
2850
e3601888
PE
2851 * term.c: Don't include <stdarg.h>, as <lisp.h> does that.
2852
db6c0e74
PE
2853 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork clobbering.
2854
dd5963ea
PE
2855 * process.c (Fformat_network_address): Fix typo: args2 -> *args2.
2856
88c9450f
PE
2857 * xmenu.c (set_frame_menubar): Fix typo: int * -> int (3 times).
2858
2f9442b8
PE
2859 * coding.c (detect_coding_charset): Fix typo: * 2 -> *4 (Bug#8601).
2860
c032b5f8
PE
2861 * charset.h (struct charset.code_space): Now has 15 elements, not 16.
2862 * charset.c (Fdefine_charset_internal): Don't initialize
2863 charset.code_space[15]. The value was garbage, on hosts with
2d38271b 2864 32-bit int (Bug#8600).
a108c10b
PE
2865
2866 * lread.c (read_integer): Be more consistent with string-to-number.
2867 Use string_to_number to do the actual conversion; this avoids
2868 rounding errors and fixes some other screwups. Without this fix,
2869 for example, #x1fffffffffffffff was misread as -2305843009213693952.
2870 (digit_to_number): Move earlier, for benefit of read_integer.
2871 Return -1 if the digit is out of range for the base, -2 if it is
48e400f0 2872 not a digit in any supported base. (Bug#8602)
a108c10b 2873
ad5f9eea
PE
2874 * doprnt.c (doprnt): Support arbitrary pI values, such as "I64".
2875
aec1708a
PE
2876 * dispnew.c (scrolling_window): Return 1 if we scrolled,
2877 to match comment at start of function. This also removes a
2878 GCC warning about overflow in a 32+64-bit port.
2879
47be4ab5
PE
2880 * lisp.h (EMACS_INT, EMACS_UINT, BITS_PER_EMACS_INT, pI): Simplify.
2881
371cac43
PE
2882 * dbusbind.c: Do not use XPNTR on a value that may be an integer.
2883 Reported by Stefan Monnier in
2884 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00919.html>.
04f2d78b
CB
2885 (xd_remove_watch, Fdbus_init_bus, xd_read_queued_messages):
2886 Use SYMBOLP-guarded XSYMBOL, not XPNTR.
371cac43 2887
d01a7826
PE
2888 * lisp.h (EMACS_INTPTR): Remove. All uses changed to intptr_t.
2889 (EMACS_UINTPTR): Likewise, with uintptr_t.
2890
7fd47d5c
PE
2891 * lisp.h: Prefer 64-bit EMACS_INT if available.
2892 (EMACS_INT, EMACS_UINT, BITS_PER_EMACS_INT, pI): Define to 64-bit
2893 on 32-bit hosts that have 64-bit int, so that they can access
2894 large files.
122b0c86
PE
2895 However, temporarily disable this change unless the temporary
2896 symbol WIDE_EMACS_INT is defined.
7fd47d5c 2897
8727937b
PE
2898 * lread.c, process.c: Do not include <inttypes.h>; lisp.h does it now.
2899
8ac068ac
PE
2900 Prefer intptr_t/uintptr_t for integers the same widths as pointers.
2901 This removes an assumption that EMACS_INT and long are the same
2902 width as pointers. The assumption is true for Emacs porting targets
2903 now, but we want to make other targets possible.
2904 * lisp.h: Include <inttypes.h>, for INTPTR_MAX, UINTPTR_MAX.
2905 (EMACS_INTPTR, EMACS_UINTPTR): New macros.
2906 In the rest of the code, change types of integers that hold casted
2907 pointers to EMACS_INTPTR and EMACS_UINTPTR, systematically
2908 replacing EMACS_INT, long, EMACS_UINT, and unsigned long.
2909 (XTYPE): Don't cast arg to EMACS_UINT; normally is not needed.
2910 (XSET): Cast type of XTYPE arg to EMACS_INTPTR; it is needed here.
2911 No need to cast type when ORing.
2912 (XPNTR): Return a value of type EMACS_INTPTR or EMACS_UINTPTR.
2913 * alloc.c (lisp_align_malloc): Remove a no-longer-needed cast.
2914 * doc.c (store_function_docstring): Use EMACS_INTPTR, so as not to
2915 assume EMACS_INT is the same width as char *.
2916 * gtkutil.c (xg_gtk_scroll_destroy, xg_tool_bar_button_cb):
2917 (xg_tool_bar_callback, xg_tool_bar_help_callback, xg_make_tool_item):
2918 Remove no-longer-needed casts.
2919 (xg_create_scroll_bar, xg_tool_bar_button_cb, xg_tool_bar_callback):
2920 (xg_tool_bar_help_callback, xg_make_tool_item):
2921 Use EMACS_INTPTR to hold an integer
2922 that will be cast to void *; this can avoid a GCC warning
2923 if EMACS_INT is not the same width as void *.
2924 * menu.c (find_and_call_menu_selection): Remove no-longer-needed cast.
2925 * xdisp.c (display_echo_area_1, resize_mini_window_1):
2926 (current_message_1, set_message_1):
2927 Use a local to convert to proper width without a cast.
2928 * xmenu.c (dialog_selection_callback): Likewise.
2929
ede49d71
PE
2930 * sysdep.c (get_random): Don't assume EMACS_INT is no wider than long.
2931 Also, don't assume VALBITS / RAND_BITS is less than 5,
2932 and don't rely on undefined behavior when shifting a 1 left into
2933 the sign bit.
2934 * lisp.h (get_random): Change signature to match.
2935
2f30ecd0
PE
2936 * lread.c (hash_string): Use size_t, not int, for hash computation.
2937 Normally we prefer signed values; but hashing is special, because
2938 it's better to use unsigned division on hash table sizes so that
2939 the remainder is nonnegative. Also, size_t is the natural width
2940 for hashing into memory. The previous code used 'int', which doesn't
2941 retain enough info to hash well into very large tables.
2942 (oblookup, oblookup_last_bucket_number, Funintern): Likewise.
2943
2a866e7b
PE
2944 * dbusbind.c: Don't possibly lose pointer info when converting.
2945 (xd_remove_watch, Fdbus_init_bus, xd_read_queued_messages):
2946 Use XPNTR rather than XHASH, so that the high-order bits of
2947 the pointer aren't lost when converting through void *.
2948
51639eac
PE
2949 * eval.c (Fautoload): Don't double-shift a pointer.
2950
92394119
PE
2951 * fns.c (Frandom): Let EMACS_UINT be wider than unsigned long.
2952
dbdb9a7c
JB
29532011-05-06 Juanma Barranquero <lekktu@gmail.com>
2954
2955 * gnutls.c (DEF_GNUTLS_FN):
2956 * image.c (DEF_IMGLIB_FN): Make function pointers static.
2957
db7a0b4f
AS
29582011-05-05 Andreas Schwab <schwab@linux-m68k.org>
2959
2960 * lread.c (lisp_file_lexically_bound_p): Stop scanning at end
2961 marker. (Bug#8610)
2962
f7ff1b0f 29632011-05-05 Eli Zaretskii <eliz@gnu.org>
fab624aa
EZ
2964
2965 * w32heap.c (allocate_heap) [USE_LISP_UNION_TYPE || USE_LSB_TAG]:
2966 New version that can reserve upto 2GB of heap space.
2967
f7ff1b0f 29682011-05-05 Chong Yidong <cyd@stupidchicken.com>
45cb8994
CY
2969
2970 * nsfns.m (Fns_read_file_name): Doc fix (Bug#8534).
2971
639c109b
TZ
29722011-05-05 Teodor Zlatanov <tzz@lifelogs.com>
2973
2974 * gnutls.c (fn_gnutls_certificate_set_x509_key_file): Add alias to
2975 `gnutls_certificate_set_x509_key_file'.
2976
d2127135
JB
29772011-05-05 Juanma Barranquero <lekktu@gmail.com>
2978
2979 * makefile.w32-in ($(BLD)/image.$(O), $(BLD)/process.$(O)):
2980 Update dependencies.
2981
e968f4f3
JB
29822011-05-04 Juanma Barranquero <lekktu@gmail.com>
2983
2984 * gnutls.h (emacs_gnutls_write, emacs_gnutls_read):
2985 * gnutls.c (emacs_gnutls_write, emacs_gnutls_read):
2986 Remove unused parameter `fildes'.
2987 * process.c (read_process_output, send_process): Don't pass it.
2988
84d358f0
JB
29892011-05-04 Juanma Barranquero <lekktu@gmail.com>
2990
2991 Fix previous change: the library cache is defined in w32.c.
2992 * image.c (CACHE_IMAGE_TYPE) [!HAVE_NTGUI]: Define to noop.
2993 (Finit_image_library): Wrap Vlibrary_cache on "#ifdef HAVE_NTGUI".
2994
0898ca10
JB
29952011-05-04 Juanma Barranquero <lekktu@gmail.com>
2996
2997 Implement dynamic loading of GnuTLS on Windows.
2998
2999 * gnutls.h (GNUTLS_EMACS_ERROR_NOT_LOADED): New macro.
3000 (emacs_gnutls_write, emacs_gnutls_read): Mark as extern.
3001 (emacs_gnutls_record_check_pending, emacs_gnutls_transport_set_errno):
3002 Declare.
3003
3004 * gnutls.c (Qgnutls_dll): Define.
3005 (DEF_GNUTLS_FN, LOAD_GNUTLS_FN): New macros.
3006 (gnutls_*): Declare function pointers.
3007 (init_gnutls_functions): New function to initialize function pointers.
3008 (emacs_gnutls_handshake, Fgnutls_error_string, Fgnutls_deinit)
3009 (emacs_gnutls_global_init, Fgnutls_bye): Use function pointers.
3010 (emacs_gnutls_record_check_pending, emacs_gnutls_transport_set_errno):
3011 Wrappers for gnutls_record_check_pending and gnutls_transport_set_errno.
3012 (emacs_gnutls_write, emacs_gnutls_read)
3013 (emacs_gnutls_handle_error, Fgnutls_error_fatalp)
3014 (Fgnutls_available_p): New function.
3015 (Fgnutls_boot): Call Fgnutls_available_p. Use function pointers.
3016 (syms_of_gnutls) <Qgnutls_dll>: Initialize and staticpro it.
3017 (syms_of_gnutls) <Sgnutls_available_p>: defsubr it.
3018
3019 * image.c: Include w32.h.
3020 (Vimage_type_cache): Delete.
3021 (syms_of_image) <Vimage_type_cache>: Don't initialize and staticpro it.
3022 (CACHE_IMAGE_TYPE, Finit_image_library): Use Vlibrary_cache instead.
3023 (w32_delayed_load): Move to w32.c.
3024
3025 * w32.h (VlibraryCache, QCloaded_from, w32_delayed_load): Declare.
3026
3027 * w32.c (QCloaded_from, Vlibrary_cache): Define.
3028 (w32_delayed_load): Move from image.c. When loading a library, record
3029 its filename in the :loaded-from property of the library id.
3030 (globals_of_w32) <QCloaded_from, Vlibrary_cache>:
3031 Initialize and staticpro them.
3032 (emacs_gnutls_pull, emacs_gnutls_push): Call emacs_gnutls_* functions.
3033
3034 * process.c: Include lisp.h before w32.h, not after.
3035 (wait_reading_process_output): Call emacs_gnutls_record_check_pending
3036 instead of gnutls_record_check_pending.
3037
3038 * callproc.c, emacs.c: Include lisp.h before w32.h, not after.
3039
ff4de4aa
TZ
30402011-05-04 Teodor Zlatanov <tzz@lifelogs.com>
3041
3042 * gnutls.c (Fgnutls_boot): Support :keylist and :crlfiles options
3043 instead of :keyfiles. Give GnuTLS the keylist and the CRL lists
3044 as passed in.
3045
abe95abb
JD
30462011-05-03 Jan Djärv <jan.h.d@swipnet.se>
3047
3048 * xterm.c (x_set_frame_alpha): Do not set property on anything
3049 else than FRAME_X_OUTER_WINDOW (Bug#8608).
3050
e16e55d4
JB
30512011-05-02 Juanma Barranquero <lekktu@gmail.com>
3052
3053 * sysdep.c (get_tty_size) [WINDOWSNT]: Implement. (Bug#8596)
3054
bafcf6a5
JB
30552011-05-02 Juanma Barranquero <lekktu@gmail.com>
3056
3057 * gnutls.c (Qgnutls_log_level, Qgnutls_code, Qgnutls_anon)
3058 (Qgnutls_x509pki, Qgnutls_e_interrupted, Qgnutls_e_again)
3059 (Qgnutls_e_invalid_session, Qgnutls_e_not_ready_for_handshake)
3060 (gnutls_global_initialized, Qgnutls_bootprop_priority)
3061 (Qgnutls_bootprop_trustfiles, Qgnutls_bootprop_keyfiles)
3062 (Qgnutls_bootprop_callbacks, Qgnutls_bootprop_loglevel)
3063 (Qgnutls_bootprop_hostname, Qgnutls_bootprop_verify_flags)
3064 (Qgnutls_bootprop_verify_error, Qgnutls_bootprop_verify_hostname_error)
3065 (Qgnutls_bootprop_callbacks_verify): Make static.
3066
e7a6747f
AS
30672011-05-01 Andreas Schwab <schwab@linux-m68k.org>
3068
19ed11ba
AS
3069 * callproc.c: Indentation fixup.
3070
e7a6747f 3071 * sysdep.c (wait_for_termination_1): Make static.
04f2d78b
CB
3072 (wait_for_termination, interruptible_wait_for_termination):
3073 Move after wait_for_termination_1.
e7a6747f 3074
1ef14cb4
LMI
30752011-05-01 Lars Magne Ingebrigtsen <larsi@gnus.org>
3076
3077 * sysdep.c (interruptible_wait_for_termination): New function
3078 which is like wait_for_termination, but allows keyboard
3079 interruptions.
3080
3081 * callproc.c (Fcall_process): Add (:file "file") as an option for
3082 the STDOUT buffer.
3083 (Fcall_process_region): Ditto.
3084
330d880c
EZ
30852011-04-30 Eli Zaretskii <eliz@gnu.org>
3086
8db90b73
EZ
3087 * dosfns.c (Fint86, Fdos_memget, Fdos_memput): Use `ASIZE (FOO)'
3088 rather than `XVECTOR (FOO)->size'.
3089
330d880c
EZ
3090 * process.c: Remove HAVE_INTTYPES_H condition from inclusion of
3091 inttypes.h, as a gnulib replacement is used if it not available in
3092 system headers.
3093
15cbd324
EZ
30942011-04-21 Eli Zaretskii <eliz@gnu.org>
3095
3096 Lift the MOST_POSITIVE_FIXNUM/4 limitation on visited files.
3097 * fileio.c (Finsert_file_contents): Don't limit file size to 1/4
3098 of MOST_POSITIVE_FIXNUM. (Bug#8528)
3099
3100 * coding.c (coding_alloc_by_realloc): Error out if destination
3101 will grow beyond MOST_POSITIVE_FIXNUM.
3102 (decode_coding_emacs_mule): Abort if there isn't enough place in
3103 charbuf for the composition carryover bytes. Reserve an extra
3104 space for up to 2 characters produced in a loop.
3105 (decode_coding_iso_2022): Abort if there isn't enough place in
3106 charbuf for the composition carryover bytes.
3107
31082011-04-21 Eli Zaretskii <eliz@gnu.org>
afda1437 3109
ae940cca
EZ
3110 * doprnt.c (doprnt) [!HAVE_LONG_LONG_INT]: Error out instead of
3111 aborting when %lld or %lll format is passed.
3112 [!HAVE_UNSIGNED_LONG_LONG_INT]: Error out instead of aborting when
3113 %llo or %llx format is passed. (Bug#8545)
3114
03ab8921
EZ
3115 * window.c (window_scroll_line_based): Use a marker instead of
3116 simple variables to record original value of point. (Bug#7952)
3117
afda1437
EZ
3118 * doprnt.c (doprnt): Fix the case where a multibyte sequence
3119 produced by %s or %c overflows available buffer space. (Bug#8545)
3120
f76dee0c
PE
31212011-04-28 Paul Eggert <eggert@cs.ucla.edu>
3122
3123 * doprnt.c (doprnt): Omit useless test; int overflow check (Bug#8545).
283cdbef 3124 (SIZE_MAX): Move defn after all includes, as they might #define it.
f76dee0c 3125
fdc5744d
JB
31262011-04-28 Juanma Barranquero <lekktu@gmail.com>
3127
3128 * w32.c (init_environment): Warn about defaulting HOME to C:\.
3129
638f053a
JB
31302011-04-28 Juanma Barranquero <lekktu@gmail.com>
3131
3132 * keyboard.c (Qdelayed_warnings_hook): Define.
3133 (command_loop_1): Run `delayed-warnings-hook'
3134 if Vdelayed_warnings_list is non-nil.
3135 (syms_of_keyboard) <delayed-warnings-hook>: DEFSYM it.
3136 (syms_of_keyboard) <delayed-warnings-list>: DEFVAR_LISP it.
3137
d178f871
EZ
31382011-04-28 Eli Zaretskii <eliz@gnu.org>
3139
3140 * doprnt.c (doprnt): Don't return value smaller than the buffer
3141 size if the message was truncated. (Bug#8545).
3142
b124fd93
JB
31432011-04-28 Juanma Barranquero <lekktu@gmail.com>
3144
3145 * w32fns.c (Fx_change_window_property, Fx_delete_window_property)
3146 (Fx_window_property): #if-0 the whole functions, not just the bodies.
3147
e810457d
PE
31482011-04-27 Paul Eggert <eggert@cs.ucla.edu>
3149
3150 * doprnt.c (doprnt): Support "ll" length modifier, for long long.
3151
ea51cceb
JB
31522011-04-27 Juanma Barranquero <lekktu@gmail.com>
3153
3154 * makefile.w32-in: Update dependencies.
3155
94dcfacf
EZ
31562011-04-27 Eli Zaretskii <eliz@gnu.org>
3157
3158 Improve `doprnt' and its usage. (Bug#8545)
3159 * doprnt.c (doprnt): Make sure `format' is never accessed beyond
3160 `format_end'. Remove support for %l as a conversion specifier.
3161 Don't use xrealloc. Improve diagnostics when the %l size modifier
3162 is used. Update the commentary.
3163
3164 * eval.c (verror): Simplify calculation of size_t.
3165
3166 * coding.c (Ffind_operation_coding_system): Fix diagnostic error
3167 messages.
3168
f61f41d7
PE
31692011-04-27 Yoshiaki Kasahara <kasahara@nc.kyushu-u.ac.jp> (tiny change)
3170
3171 * buffer.c (init_buffer) [USE_MMAP_FOR_BUFFERS]: Adjust to aliasing
3172 change.
3173
96fb4434
PE
31742011-04-27 Paul Eggert <eggert@cs.ucla.edu>
3175
3176 * nsmenu.m: Replace all uses of XVECTOR with ASIZE and AREF.
3177 This makes this file independent of the recent pseudovector change.
3178
671875da 31792011-04-26 Paul Eggert <eggert@cs.ucla.edu>
eab3844f 3180
69e9b5a3
PE
3181 * keyboard.c (handle_user_signal): Fix pointer signedness problem.
3182
b5f869a7 3183 * gnutls.c (emacs_gnutls_handle_error): Remove unused local.
7754e151 3184 (Fgnutls_boot): gnutls_certificate_verify_peers2 wants unsigned *.
8d4c3955 3185 Remove unused local.
c8926152 3186 (emacs_gnutls_write): Don't use uninitialized rtnval if nbyte <= 0.
080e5a8d 3187
841a1577 3188 * lisp.h: Fix a problem with aliasing and vector headers. (Bug#8546)
04f2d78b
CB
3189 GCC 4.6.0 optimizes based on type-based alias analysis.
3190 For example, if b is of type struct buffer * and v of type struct
eab3844f
PE
3191 Lisp_Vector *, then gcc -O2 was incorrectly assuming that &b->size
3192 != &v->size, and therefore "v->size = 1; b->size = 2; return
3193 v->size;" must therefore return 1. This assumption is incorrect
3194 for Emacs, since it type-puns struct Lisp_Vector * with many other
3195 types. To fix this problem, this patch adds a new type struct
f904488f 3196 vectorlike_header that documents the constraints on layout of vectors
eab3844f
PE
3197 and pseudovectors, and helps optimizing compilers not get fooled
3198 by Emacs's type punning. It also adds the macros XSETTYPED_PVECTYPE
3199 XSETTYPED_PSEUDOVECTOR, TYPED_PSEUDOVECTORP, for similar reasons.
f904488f
PE
3200 * lisp.h (XSETTYPED_PVECTYPE): New macro, specifying the name of
3201 the size member.
eab3844f
PE
3202 (XSETPVECTYPE): Rewrite in terms of new macro.
3203 (XSETPVECTYPESIZE): New macro, specifying both type and size.
3204 This is a bit clearer, and further avoids the possibility of
3205 undesirable aliasing.
3206 (XSETTYPED_PSEUDOVECTOR): New macro, specifying the size.
f904488f 3207 (XSETPSEUDOVECTOR): Rewrite in terms of XSETTYPED_PSEUDOVECTOR.
eab3844f
PE
3208 (XSETSUBR): Rewrite in terms of XSETTYPED_PSEUDOVECTOR and XSIZE,
3209 since Lisp_Subr is a special case (no "next" field).
04f2d78b
CB
3210 (ASIZE): Now uses header.size rather than size.
3211 All previous uses of XVECTOR (foo)->size replaced to use this macro,
f904488f
PE
3212 to avoid the hassle of writing XVECTOR (foo)->header.size.
3213 (struct vectorlike_header): New type.
eab3844f
PE
3214 (TYPED_PSEUDOVECTORP): New macro, also specifying the C type of the
3215 object, to help avoid aliasing.
3216 (PSEUDOVECTORP): Rewrite in terms of TYPED_PSEUDOVECTORP.
3217 (SUBRP): Likewise, since Lisp_Subr is a special case.
3218 * lisp.h (struct Lisp_Vector, struct Lisp_Char_Table):
3219 (struct Lisp_Sub_Char_Table, struct Lisp_Bool_Vector):
3220 (struct Lisp_Hash_Table): Combine first two members into a single
f904488f 3221 struct vectorlike_header member. All uses of "size" and "next" members
eab3844f
PE
3222 changed to be "header.size" and "header.next".
3223 * buffer.h (struct buffer): Likewise.
3224 * font.h (struct font_spec, struct font_entity, struct font): Likewise.
3225 * frame.h (struct frame): Likewise.
3226 * process.h (struct Lisp_Process): Likewise.
3227 * termhooks.h (struct terminal): Likewise.
3228 * window.c (struct save_window_data, struct saved_window): Likewise.
3229 * window.h (struct window): Likewise.
3230 * alloc.c (allocate_buffer, Fmake_bool_vector, allocate_pseudovector):
3231 Use XSETPVECTYPESIZE, not XSETPVECTYPE, to avoid aliasing problems.
3232 * buffer.c (init_buffer_once): Likewise.
3233 * lread.c (defsubr): Use XSETTYPED_PVECTYPE, since Lisp_Subr is a
3234 special case.
3235 * process.c (Fformat_network_address): Use local var for size,
3236 for brevity.
3237
0df1eac5
PE
3238 * bytecode.c (exec_byte_code): Don't use XVECTOR before CHECK_VECTOR.
3239
847ab9d1 3240 Make the Lisp reader and string-to-float more consistent (Bug#8525)
452f4150
PE
3241 * data.c (atof): Remove decl; no longer used or needed.
3242 (digit_to_number): Move to lread.c.
3243 (Fstring_to_number): Use new string_to_number function, to be
3244 consistent with how the Lisp reader treats infinities and NaNs.
3245 Do not assume that floating-point numbers represent EMACS_INT
3246 without losing information; this is not true on most 64-bit hosts.
3247 Avoid double-rounding errors, by insisting on integers when
3248 parsing non-base-10 numbers, as the documentation specifies.
3249 * lisp.h (string_to_number): New decl, replacing ...
3250 (isfloat_string): Remove.
bc0a5c13 3251 * lread.c: Include <inttypes.h>, for uintmax_t and strtoumax.
d78050d6 3252 (read1): Do not accept +. and -. as integers; this
452f4150
PE
3253 appears to have been a coding error. Similarly, do not accept
3254 strings like +-1e0 as floating point numbers. Do not report
3255 overflow for integer overflows unless the base is not 10 which
3256 means we have no simple and reliable way to continue.
3257 Break out the floating-point parsing into a new
3258 function string_to_number, so that Fstring_to_number parses
3259 floating point numbers consistently with the Lisp reader.
04f2d78b 3260 (digit_to_number): Move here from data.c. Make it static inline.
452f4150
PE
3261 (E_CHAR, EXP_INT): Remove, replacing with ...
3262 (E_EXP): New macro, to solve the "1.0e+" problem mentioned below.
3263 (string_to_number): New function, replacing isfloat_string.
3264 This function checks for valid syntax and produces the resulting
3265 Lisp float number too. Rework it so that string-to-number
bc0a5c13 3266 no longer mishandles examples like "1.0e+". Use strtoumax,
d78050d6
PE
3267 so that overflow for non-base-10 numbers is reported only when
3268 there's no portable and simple way to convert to floating point.
452f4150 3269
67769ffc
PE
3270 * textprop.c (set_text_properties_1): Rewrite for clarity,
3271 and to avoid GCC warning about integer overflow.
3272
c20db43f
PE
3273 * intervals.h (struct interval): Use EMACS_INT for members
3274 where EMACS_UINT might cause problems. See
3275 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00514.html>.
3276 (CHECK_TOTAL_LENGTH): Remove cast to EMACS_INT; no longer needed.
3277 * intervals.c (interval_deletion_adjustment): Now returns EMACS_INT.
3278 All uses changed.
37aa2f85
PE
3279 (offset_intervals): Tell GCC not to worry about length overflow
3280 when negating a negative length.
c20db43f 3281
2538aa2f
PE
3282 * alloc.c (overrun_check_malloc, overrun_check_realloc): Now static.
3283 (overrun_check_free): Likewise.
3284
f2d3008d
PE
3285 * alloc.c (SDATA_SIZE) [!GC_CHECK_STRING_BYTES]: Avoid runtime check
3286 in the common case where SDATA_DATA_OFFSET is a multiple of Emacs
3287 word size.
3288
ec8df744
PE
3289 * gnutls.c: Fix problems found by GCC 4.6.0 on Ubuntu 10.10.
3290 (gnutls_make_error): Rename local to avoid shadowing.
3291 (gnutls_emacs_global_deinit): ifdef out; not used.
3292 (Fgnutls_boot): Use const for pointer to readonly storage.
3293 Comment out unused local. Fix pointer signedness problems.
3294
640ee02d
PE
3295 * lread.c (openp): Don't stuff size_t into an 'int'.
3296 Use <= on length, not < on length + 1, to avoid GCC 4.6.0 warning
3297 about possible signed overflow.
3298
6048fb2a
PE
3299 * gtkutil.c: Fix problems found by GCC 4.6.0 on Ubuntu 10.10.
3300 (GDK_KEY_g): Don't define if already defined.
3301 (xg_prepare_tooltip): Avoid pointer signedness problem.
3302 (xg_set_toolkit_scroll_bar_thumb): Redo to avoid two casts.
3303
fa3c87e1
PE
3304 * process.c (Fnetwork_interface_info): Avoid left-shift undefined
3305 behavior with 1 << 31. GCC 4.6.0 warns about this on 32-bit hosts.
3306
2172544b
PE
3307 * xfns.c (Fx_window_property): Simplify a bit,
3308 to make a bit faster and to avoid GCC 4.6.0 warning.
3309 * xselect.c (x_get_window_property, x_handle_dnd_message): Likewise.
3310
9b821a21
PE
3311 * fns.c (internal_equal): Don't assume size_t fits in int.
3312
3c616cfa
PE
3313 * alloc.c (compact_small_strings): Tighten assertion a little.
3314
c2982e87
PE
3315 Replace pEd with more-general pI, and fix some printf arg casts.
3316 * lisp.h (pI): New macro, generalizing old pEd macro to other
3317 conversion specifiers. For example, use "...%"pI"d..." rather
3318 than "...%"pEd"...".
3319 (pEd): Remove. All uses replaced with similar uses of pI.
3320 * src/m/amdx86-64.h, src/m/ia64.h, src/m/ibms390x.h: Likewise.
3321 * alloc.c (check_pure_size): Don't overflow by converting size to int.
3322 * bidi.c (bidi_dump_cached_states): Use pI to avoid cast.
3323 * data.c (Fnumber_to_string): Use pI instead of if-then-else-abort.
3324 * dbusbind.c (xd_append_arg): Use pI to avoid cast.
3325 (Fdbus_method_return_internal, Fdbus_method_error_internal): Likewise.
3326 * font.c (font_unparse_xlfd): Avoid potential buffer overrun on
3327 64-bit hosts.
3328 (font_unparse_xlfd, font_unparse_fcname): Use pI to avoid casts.
3329 * keyboard.c (record_char, modify_event_symbol): Use pI to avoid casts.
3330 * print.c (safe_debug_print, print_object): Likewise.
3331 (print_object): Don't overflow by converting EMACS_INT or EMACS_UINT
3332 to int.
6f04d126
PE
3333 Use pI instead of if-then-else-abort. Use %p to avoid casts,
3334 avoiding the 0 flag, which is not portable.
c2982e87
PE
3335 * process.c (Fmake_network_process): Use pI to avoid cast.
3336 * region-cache.c (pp_cache): Likewise.
3337 * xdisp.c (decode_mode_spec): Likewise.
3338 * xrdb.c (x_load_resources) [USE_MOTIF]: Use pI to avoid undefined
3339 behavior on 64-bit hosts with printf arg.
6f04d126 3340 * xselect.c (x_queue_event): Use %p to avoid casts, avoiding 0 flag.
c2982e87
PE
3341 (x_stop_queuing_selection_requests): Likewise.
3342 (x_get_window_property): Don't truncate byte count to an 'int'
3343 when tracing.
0b432f21 3344
5e073ec7
PE
3345 * frame.c (frame_name_fnn_p): Get rid of strtol, which isn't right
3346 here, since it parses constructs like leading '-' and spaces,
3347 which are not wanted; and it overflows with large numbers.
3348 Instead, simply match F[0-9]+, which is what is wanted anyway.
3349
36372bf9
PE
3350 * alloc.c: Remove unportable assumptions about struct layout.
3351 (SDATA_SELECTOR, SDATA_DATA_OFFSET): New macros.
3352 (SDATA_OF_STRING, SDATA_SIZE, allocate_string_data):
3353 (allocate_vectorlike, make_pure_vector): Use the new macros,
3354 plus offsetof, to remove unportable assumptions about struct layout.
3355 These assumptions hold on all porting targets that I know of, but
3356 they are not guaranteed, they're easy to remove, and removing them
3357 makes further changes easier.
3358
0b432f21
PE
3359 * alloc.c (BLOCK BYTES): Fix typo by changing "ablock" to "ablocks".
3360 This doesn't fix a bug but makes the code clearer.
bfd1c781
PE
3361 (string_overrun_cookie): Now const. Use initializers that
3362 don't formally overflow signed char, to avoid warnings.
000098c1
PE
3363 (allocate_string_data) [GC_CHECK_STRING_OVERRUN]: Fix typo that
3364 can cause Emacs to crash when string overrun checking is enabled.
c7bda33c
PE
3365 (allocate_buffer): Don't assume sizeof (struct buffer) is a
3366 multiple of sizeof (EMACS_INT); it need not be, if
3367 alignof(EMACS_INT) < sizeof (EMACS_INT).
d0f4e1f5 3368 (check_sblock, check_string_bytes, check_string_free_list): Protoize.
0b432f21 3369
895009e1
JB
33702011-04-26 Juanma Barranquero <lekktu@gmail.com>
3371
3372 * keyboard.c (QCrtl): Rename from Qrtl. All uses changed.
3373
6a7a1b0b
TZ
33742011-04-26 Teodor Zlatanov <tzz@lifelogs.com>
3375
3376 * gnutls.c (emacs_gnutls_handshake): Return an error if we're not
b5f869a7 3377 supposed to be handshaking. (Bug#8556)
6a7a1b0b
TZ
3378 Reported by Paul Eggert <eggert@cs.ucla.edu>.
3379
841a1577 33802011-04-26 Daniel Colascione <dan.colascione@gmail.com>
0438ce91
DC
3381
3382 * lisp.h (Qdebug): List symbol.
895009e1 3383 * eval.c (Qdebug): Restore global linkage.
0438ce91
DC
3384 * keyboard.c (debug-on-event): New variable.
3385 (handle_user_signal): Break into debugger when debug-on-event
3386 matches the current signal symbol.
3387
f2d3ba6f
DN
33882011-04-25 Dan Nicolaescu <dann@ics.uci.edu>
3389
3390 * alloc.c (check_sblock, check_string_bytes)
3391 (check_string_free_list): Convert to standard C.
3392
42ce4c63
TZ
33932011-04-25 Teodor Zlatanov <tzz@lifelogs.com>
3394
3395 * w32.c (emacs_gnutls_push): Fix typo.
3396
825cd63c
EZ
33972011-04-25 Eli Zaretskii <eliz@gnu.org>
3398
fb11d64d
EZ
3399 * gnutls.c (emacs_gnutls_handshake): Avoid compiler warnings about
3400 "cast to pointer from integer of different size".
3401
825cd63c
EZ
3402 Improve doprnt and its use in verror. (Bug#8545)
3403 * doprnt.c (doprnt): Document the set of format control sequences
3404 supported by the function. Use SAFE_ALLOCA instead of always
3405 using `alloca'.
3406
3407 * eval.c (verror): Don't limit the buffer size at size_max-1, that
3408 is one byte too soon. Don't use xrealloc; instead xfree and
3409 xmalloc anew.
3410
e061a11b
TZ
34112011-04-24 Teodor Zlatanov <tzz@lifelogs.com>
3412
3413 * gnutls.h: Add GNUTLS_STAGE_CALLBACKS enum to denote we're in the
3414 callbacks stage.
3415
3416 * gnutls.c: Renamed global_initialized to
3417 gnutls_global_initialized. Added internals for the
3418 :verify-hostname-error, :verify-error, and :verify-flags
3419 parameters of `gnutls-boot' and documented those parameters in the
3420 docstring. Start callback support.
9173deec
JB
3421 (emacs_gnutls_handshake): Add Woe32 support. Retry handshake
3422 unless a fatal error occurred. Call gnutls_alert_send_appropriate
3423 on error. Return error code.
e061a11b
TZ
3424 (emacs_gnutls_write): Call emacs_gnutls_handle_error.
3425 (emacs_gnutls_read): Likewise.
3426 (Fgnutls_boot): Return handshake error code.
3427 (emacs_gnutls_handle_error): New function.
3428 (wsaerror_to_errno): Likewise.
3429
3430 * w32.h (emacs_gnutls_pull): Add prototype.
3431 (emacs_gnutls_push): Likewise.
3432
3433 * w32.c (emacs_gnutls_pull): New function for GnuTLS on Woe32.
3434 (emacs_gnutls_push): Likewise.
3435
34362011-04-24 Claudio Bley <claudio.bley@gmail.com> (tiny change)
3437
3438 * process.c (wait_reading_process_output): Check if GnuTLS
3439 buffered some data internally if no FDs are set for TLS
3440 connections.
3441
3442 * makefile.w32-in (OBJ2): Add gnutls.$(O).
3443 (LIBS): Link to USER_LIBS.
3444 ($(BLD)/gnutls.$(0)): New target.
3445
fa6996bc
EZ
34462011-04-24 Eli Zaretskii <eliz@gnu.org>
3447
eb35682e
EZ
3448 * xdisp.c (handle_single_display_spec): Rename the
3449 display_replaced_before_p argument into display_replaced_p, to
3450 make it consistent with the commentary. Fix typos in the
3451 commentary.
3452
e2ad650c
EZ
3453 * textprop.c (syms_of_textprop): Remove dead code.
3454 (copy_text_properties): Delete obsolete commentary about an
3455 interface that was deleted long ago. Fix typos in the description
3456 of arguments.
3457
1b2de274
EZ
3458 * msdos.c (XMenuActivate, XMenuAddSelection): Adjust argument list
3459 to changes in oldXMenu/XMenu.h from 2011-04-16.
3460 <menu_help_message, prev_menu_help_message>: Constify.
3461 (IT_menu_make_room): menu->help_text is now `const char **';
3462 adjust.
3463
3464 * msdos.h (XMenuActivate, XMenuAddSelection): Adjust prototypes
3465 to changes in oldXMenu/XMenu.h from 2011-04-16.
3466 (struct XMenu): Declare `help_text' `const char **'.
3467
3468 * xfaces.c <Qunspecified>: Make extern again.
3469
3470 * syntax.c: Include sys/types.h before including regex.h, as
3471 required by Posix.
3472
762b15be
EZ
3473 * doc.c (get_doc_string): Improve the format passed to `error'.
3474
3475 * doprnt.c (doprnt): Improve commentary.
3476
3477 * term.c (init_tty) [MSDOS]: Fix 1st argument to maybe_fatal.
3478
3479 * Makefile.in (TAGS): Depend on $(M_FILE) and $(S_FILE), and scan
3480 them with etags.
3481
f1052e5d
EZ
3482 * makefile.w32-in (globals.h): Add a dummy recipe, to make any
3483 changes in globals.h immediately force recompilation.
762b15be
EZ
3484 (TAGS): Depend on $(CURDIR)/m/intel386.h and
3485 $(CURDIR)/s/ms-w32.h.
3486 (TAGS-gmake): Scan $(CURDIR)/m/intel386.h and $(CURDIR)/s/ms-w32.h.
f1052e5d 3487
fa6996bc
EZ
3488 * character.c (Fchar_direction): Function deleted.
3489 (syms_of_character): Don't defsubr it.
3490 <char-direction-table>: Deleted.
3491
e6c3da20
EZ
34922011-04-23 Eli Zaretskii <eliz@gnu.org>
3493
3494 Fix doprnt so it could be used again safely in `verror'. (Bug#8435)
3495 * doprnt.c: Include limits.h.
3496 (SIZE_MAX): New macro.
04f2d78b
CB
3497 (doprnt): Return a size_t value. 2nd arg is now size_t.
3498 Many local variables are now size_t instead of int or unsigned.
e6c3da20
EZ
3499 Improve overflow protection. Support `l' modifier for integer
3500 conversions. Support %l conversion. Don't assume an EMACS_INT
3501 argument for integer conversions and for %c.
3502
3503 * lisp.h (doprnt): Restore prototype.
3504
3505 * makefile.w32-in ($(BLD)/callint.$(O)): Depend on
3506 $(SRC)/character.h.
3507
3508 * Makefile.in (base_obj): Add back doprnt.o.
3509
3510 * deps.mk (doprnt.o): Add back prerequisites.
3511 (callint.o): Depend on character.h.
3512
3513 * eval.c (internal_lisp_condition_case): Include the handler
3514 representation in the error message.
3515 (verror): Call doprnt instead of vsnprintf. Fix an off-by-one bug
3516 when breaking from the loop.
3517
3518 * xdisp.c (vmessage): Call doprnt instead of vsnprintf.
3519
3520 * callint.c (Fcall_interactively): When displaying error message
3521 about invalid control letter, pass the character's codepoint, not
3522 a pointer to its multibyte form. Improve display of the character
3523 in octal and display also its hex code.
3524
3525 * character.c (char_string): Use %x to display the (unsigned)
3526 codepoint of an invalid character, to avoid displaying a bogus
3527 negative value.
3528
3529 * font.c (check_otf_features): Pass SDATA of SYMBOL_NAME to
3530 `error', not SYMBOL_NAME itself.
3531
3532 * coding.c (Fencode_sjis_char, Fencode_big5_char): Use %c for
3533 character arguments to `error'.
3534
3535 * charset.c (check_iso_charset_parameter): Fix incorrect argument
3536 to `error' in error message about FINAL_CHAR argument. Make sure
3537 FINAL_CHAR is a character, and use %c when it is passed as
3538 argument to `error'.
3539
4ffd0d6b 35402011-04-23 Eli Zaretskii <eliz@gnu.org>
97a93095
EZ
3541
3542 * s/ms-w32.h (localtime): Redirect to sys_localtime.
3543
3544 * w32.c: Include <time.h>.
3545 (sys_localtime): New function.
3546
4ffd0d6b 35472011-04-23 Chong Yidong <cyd@stupidchicken.com>
c17819f4
CY
3548
3549 * xdisp.c (init_xdisp): Initialize echo_area_window (Bug#6451).
3550
4ffd0d6b 3551 * buffer.c (syms_of_buffer): Doc fix (Bug#6902).
aac0c6e3 3552
4ffd0d6b 35532011-04-23 Samuel Thibault <sthibault@debian.org> (tiny change)
aac0c6e3 3554
4ffd0d6b
GM
3555 * sysdep.c (wait_for_termination): On GNU Hurd, kill returns -1 on
3556 zombies (Bug#8467).
aac0c6e3 3557
04c56954
EZ
35582011-04-19 Eli Zaretskii <eliz@gnu.org>
3559
3560 * syntax.h (SETUP_SYNTAX_TABLE_FOR_OBJECT): Fix setting of
3561 gl_state.e_property when gl_state.object is Qt.
3562
3563 * insdel.c (make_gap_larger): Remove limitation of buffer size
3564 to <= INT_MAX.
3565
16a43933
CY
35662011-04-18 Chong Yidong <cyd@stupidchicken.com>
3567
3568 * xdisp.c (lookup_glyphless_char_display)
3569 (produce_glyphless_glyph): Handle cons cell entry in
3570 glyphless-char-display.
3571 (Vglyphless_char_display): Document it.
3572
3573 * term.c (produce_glyphless_glyph): Handle cons cell entry in
3574 glyphless-char-display.
3575
4581706e
CY
35762011-04-17 Chong Yidong <cyd@stupidchicken.com>
3577
3578 * xdisp.c (get_next_display_element): Remove unnecessary ifdefs.
3579
3580 * termhooks.h (FRAME_WINDOW_P): Remove duplicated definitions.
3581
3582 * dispextern.h (FACE_SUITABLE_FOR_ASCII_CHAR_P): Add missing
3583 definition for no-X builds.
3584
4887c6e2 35852011-04-16 Paul Eggert <eggert@cs.ucla.edu>
764430a3 3586
fd35b6f9
PE
3587 Static checks with GCC 4.6.0 and non-default toolkits.
3588
5c1ccb01
PE
3589 * s/sol2-6.h, s/unixware.h (PTY_TTY_NAME_SPRINTF): Protoize decl.
3590
006c5daa
PE
3591 * process.c (keyboard_bit_set): Define only if SIGIO.
3592 (send_process_trap): Mark it with NO_RETURN if it doesn't return.
3593 (send_process): Repair possible setjmp clobbering.
3594
efc736d3
PE
3595 * s/usg5-4-common.h (SETUP_SLAVE_PTY): Don't pass extra arg to 'fatal'.
3596
4e2fe2e6
PE
3597 * eval.c: Include <stdio.h>, for vsnprintf on non-GNU/Linux hosts.
3598
f97334a2
PE
3599 * data.c (arith_error): Mark with NO_RETURN if it doesn't return.
3600
4e75f29d
PE
3601 * alloc.c (bytes_used_when_full, SPARE_MEMORY, BYTES_USED):
3602 Define only if needed.
3603
90efadd1
PE
3604 * sysdep.c (_FILE_OFFSET_BITS): Make this hack even uglier
3605 by pacifying GCC about it. Maybe it's time to retire it?
875975e9 3606 * xfaces.c (USG, __TIMEVAL__): Likewise.
90efadd1 3607
3c647824
PE
3608 * dispextern.h (struct redisplay_interface): Rename param
3609 to avoid shadowing.
e264f262 3610 * termhooks.h (struct terminal): Likewise.
761383f4 3611 * xterm.c (xembed_send_message): Likewise.
3c647824 3612
b58c5c4a
PE
3613 * insdel.c (make_gap_smaller): Define only if
3614 USE_MMAP_FOR_BUFFERS || REL_ALLOC || DOUG_LEA_MALLOC.
3615
cad59032
PE
3616 * keyboard.c (read_char): Make a var volatile so longjmp won't clobber
3617 it.
3618
c339dc2e
PE
3619 * emacs.c (MAX_HEAP_BSS_DIFF, my_edata): Move to where they're used,
3620 so that we aren't warned about unused symbols.
3621
91a3e27b
PE
3622 * xfns.c (Fx_file_dialog): Rename local to avoid shadowing.
3623
399c71d3 3624 * xdisp.c (x_produce_glyphs): Mark var as initialized (Bug#8512).
7a3fb125 3625
8ffc96f5
PE
3626 * xfns.c (x_real_positions): Mark locals as initialized.
3627
eef9bc79
PE
3628 * xmenu.c (xmenu_show): Don't use uninitialized vars.
3629
098db9dd
PE
3630 * xterm.c: Fix problems found by static analysis with other toolkits.
3631 (toolkit_scroll_bar_interaction): Define and use only if USE_X_TOOLKIT.
dda3aedd
PE
3632 (x_dispatch_event): Declare static if USE_GTK, and
3633 define if USE_GTK || USE_X_TOOLKIT.
098db9dd 3634 (SET_SAVED_BUTTON_EVENT): Define only if USE_X_TOOLKIT || USE_GTK.
dda3aedd 3635 * xterm.h (x_dispatch_event): Extern only if USE_X_TOOLKIT.
841a1577
JB
3636 * xterm.c, xterm.h (x_mouse_leave): Bring this function back, but only
3637 if defined HAVE_MENUS && !defined USE_X_TOOLKIT && !defined USE_GTK.
098db9dd 3638
eb18f6cc
PE
3639 * xmenu.c (menu_help_callback): Pointer type fixes.
3640 Use const pointers when pointing at readonly data. Avoid pointer
3641 signedness clashes.
3642 (FALSE): Remove unused macro.
3643 (update_frame_menubar): Remove unused decl.
3644
1fe72bf8
PE
3645 * xfns.c (Fx_hide_tip): Move locals to avoid shadowing.
3646
60d9e1db
PE
3647 * menu.c (push_submenu_start, push_submenu_end): Do not define unless
3648 USE_X_TOOLKIT || USE_GTK || HAVE_NS || defined HAVE_NTGUI.
3649 (single_menu_item): Rename local to avoid shadowing.
3650
39261c26
PE
3651 * keyboard.c (make_lispy_event): Remove unused local var.
3652
018c5e19
PE
3653 * frame.c, frame.h (x_get_resource_string): Bring this back, but
3654 only if HAVE_X_WINDOWS && !USE_X_TOOLKIT.
3655
63d2b86e
PE
3656 * bitmaps: Change bitmaps from unsigned char back to the X11
3657 compatible char. Avoid the old compiler warnings about
3658 out-of-range initializers by using, for example, '\xab' rather
3659 than 0xab.
3660
aefd87e1
PE
3661 * xgselect.c (xgselect_initialize): Check vs interface
3662 even if ! (defined (USE_GTK) || defined (HAVE_GCONF)).
3663
bf501fb9
PE
3664 * xmenu.c (xmenu_show): Rename parm to avoid shadowing.
3665
e9829fdf
PE
3666 * xterm.c (x_create_toolkit_scroll_bar): Use const * for pointers
3667 to read-only memory.
3668
1086c095
PE
3669 * fns.c (vector): Remove; this old hack is no longer needed.
3670
2baccd04 3671 * xsmfns.c (create_client_leader_window): Rename shadowing arg.
401f10cb 3672 Remove unused var.
dde42981 3673 (gdk_x11_set_sm_client_id) [!USE_GTK]: Don't define.
2baccd04 3674
72391843 3675 * xrdb.c (x_load_resources): Omit unused local.
3565b346 3676
436c16df 3677 * xfns.c (free_frame_menubar, atof): Remove duplicate decls.
8a94ea33 3678 (x_window): Rename locals to avoid shadowing.
dc5ddd85 3679 (USG): Use the kludged USG macro, to pacify gcc.
436c16df 3680
92bb796d 3681 * xterm.c (x_alloc_nearest_color_for_widget): Remove; unused.
bbbef9e1 3682 (x_term_init): Remove local to avoid shadowing.
92bb796d 3683
764430a3 3684 * xfns.c, xterm.c (_XEditResCheckMessages): Protoize decl.
4887c6e2
PE
3685
3686 * xdisp.c, dispextern.h (set_vertical_scroll_bar): Now extern if
3687 USE_TOOLKIT_SCROLL_BARS && !USE_GTK, as xterm.c needs it then.
3688
d1dfb56c
EZ
36892011-04-16 Eli Zaretskii <eliz@gnu.org>
3690
c4354cb4
EZ
3691 * gnutls.c (Fgnutls_boot): Don't pass Lisp_Object to `error'.
3692
d1dfb56c
EZ
3693 Fix regex.c, syntax.c and friends for buffers > 2GB.
3694 * syntax.h (struct gl_state_s): Declare character position members
3695 EMACS_INT.
3696
3697 * syntax.c (update_syntax_table): Declare 2nd argument EMACS_INT.
3698
04f2d78b
CB
3699 * textprop.c (verify_interval_modification, interval_of):
3700 Declare arguments EMACS_INT.
d1dfb56c
EZ
3701
3702 * intervals.c (adjust_intervals_for_insertion): Declare arguments
3703 EMACS_INT.
3704
3705 * intervals.h (CHECK_TOTAL_LENGTH): Cast to EMACS_INT, not `int'.
3706
3707 * indent.c (Fvertical_motion): Local variable it_start is now
3708 EMACS_INT.
3709
3710 * regex.c (re_match, re_match_2, re_match_2_internal)
3711 (bcmp_translate, regcomp, regexec, print_double_string)
3712 (group_in_compile_stack, re_search, re_search_2, regex_compile)
3713 (re_compile_pattern, re_exec): Declare arguments and local
3714 variables `size_t' and `ssize_t' and return values `regoff_t', as
3715 appropriate.
3716 (POP_FAILURE_REG_OR_COUNT) <pfreg>: Declare `long'.
3717 (CHECK_INFINITE_LOOP) <failure>: Declare `ssize_t'.
3718 <compile_stack_type>: `size' and `avail' are now `size_t'.
3719
3720 * regex.h <regoff_t>: Use ssize_t, not int.
3721 (re_search, re_search_2, re_match, re_match_2): Arguments that
3722 specify buffer/string position and length are now ssize_t and
3723 size_t. Return type is regoff_t.
3724
613052cd
BK
37252011-04-16 Ben Key <bkey76@gmail.com>
3726
3727 * nsfont.m: Fixed bugs in ns_get_family and
3728 ns_descriptor_to_entity that were caused by using free to
3729 deallocate memory blocks that were allocated by xmalloc (via
3730 xstrdup). This caused Emacs to crash when compiled with
3731 XMALLOC_OVERRUN_CHECK defined (when Emacs was configured with
3732 --enable-checking=xmallocoverrun). xfree is now used to
3733 deallocate these memory blocks.
3734
4170f62f 37352011-04-15 Paul Eggert <eggert@cs.ucla.edu>
3e047f51 3736
71b41406
PE
3737 * sysdep.c (emacs_read): Remove unnecessary check vs MAX_RW_COUNT.
3738
9587a89d
PE
3739 emacs_write: Accept and return EMACS_INT for sizes.
3740 See http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00514.html
3741 et seq.
3742 * gnutls.c, gnutls.h (emacs_gnutls_read, emacs_gnutls_write):
3743 Accept and return EMACS_INT.
3744 (emacs_gnutls_write): Return the number of bytes written on
3745 partial writes.
3746 * sysdep.c, lisp.h (emacs_read, emacs_write): Likewise.
273a5f82
PE
3747 (emacs_read, emacs_write): Remove check for negative size, as the
3748 Emacs source code has been audited now.
9587a89d
PE
3749 * sysdep.c (MAX_RW_COUNT): New macro, to work around kernel bugs.
3750 (emacs_read, emacs_write): Use it.
273a5f82
PE
3751 * process.c (send_process): Adjust to the new signatures of
3752 emacs_write and emacs_gnutls_write. Do not attempt to store
3753 a byte offset into an 'int'; it might overflow.
9587a89d 3754 See http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00483.html
273a5f82 3755
3e047f51
PE
3756 * sound.c: Don't assume sizes fit in 'int'.
3757 (struct sound_device.period_size, alsa_period_size):
9c3c56a7 3758 Return EMACS_INT, not int.
3e047f51 3759 (struct sound_device.write, vox_write, alsa_write):
9c3c56a7
PE
3760 Accept EMACS_INT, not int.
3761 (wav_play, au_play): Use EMACS_INT to store sizes and to
3e047f51
PE
3762 record read return values.
3763
cc39a9db
BK
37642011-04-15 Ben Key <bkey76@gmail.com>
3765
c9d0ec6d
JB
3766 * keyboard.c (Qundefined): Don't declare static since it is used
3767 in nsfns.m.
3768 * xfaces.c (Qbold, Qexpanded, Qitalic, Qcondensed): Don't declare
3769 static since they are used in nsfont.m.
cc39a9db 3770
6c60eb9f
SM
37712011-04-15 Stefan Monnier <monnier@iro.umontreal.ca>
3772
3773 * process.c (Qprocessp): Don't declare static.
3774 * lisp.h (Qprocessp): Declare again.
3775
7990b61a
JB
37762011-04-15 Juanma Barranquero <lekktu@gmail.com>
3777
3778 * font.c (Qopentype): Don't make static (used from w32uniscribe.c).
3779
5d4cb038
PE
37802011-04-14 Paul Eggert <eggert@cs.ucla.edu>
3781
8bd7b830 3782 Improve C-level modularity by making more things 'static'.
cd64ea1d 3783
e3b27b31
PE
3784 Don't publish debugger-only interfaces to other modules.
3785 * lisp.h (safe_debug_print, debug_output_compilation_hack):
3786 (verify_bytepos, count_markers): Move decls to the only modules
3787 that need them.
3788 * region-cache.h (pp_cache): Likewise.
3789 * window.h (check_all_windows): Likewise.
3790 * marker.c, print.c, region-cache.c, window.c: Decls moved here.
3791
5d4cb038
PE
3792 * sysdep.c (croak): Now static, if
3793 defined TIOCNOTTY || defined USG5 || defined CYGWIN.
3794 * syssignal.h (croak): Declare only if not static.
69003fd8
PE
3795
3796 * alloc.c (refill_memory_reserve): Now static if
3797 !defined REL_ALLOC || defined SYSTEM_MALLOC.
3798 * lisp.h (refill_memory_reserve): Declare only if not static.
93ea6e8f 3799
e87b6180
PE
3800 * xsettings.c, xsettings.h (xsettings_get_system_normal_font):
3801 Define only if USE_LUCID.
3802
ac64929e
PE
3803 * xrdb.c (x_customization_string, x_rm_string): Now static.
3804
6f37259d
PE
3805 * xmenu.c (x_menu_wait_for_event): Export only if USE_MOTIF.
3806 * xterm.h (x_menu_wait_for_event): Declare only if USE_MOTIF.
3807
1683e3ab
PE
3808 * xdisp.c (draw_row_with_mouse_face): Now static.
3809 * dispextern.h (draw_row_with_mouse_fave): Remove decl.
3810
de9c2632
PE
3811 * window.h (check_all_windows): Mark externally visible.
3812
2b96acb7
PE
3813 * window.c (window_deletion_count): Now static.
3814
3815 * undo.c: Make symbols static if they're not exported.
3816 (last_undo_buffer, last_boundary_position, pending_boundary):
3817 Now static.
3818
50436f33
PE
3819 * textprop.c (interval_insert_behind_hooks): Now static.
3820 (interval_insert_in_front_hooks): Likewise.
3821
64520e5c
PE
3822 * term.c: Make symbols static if they're not exported.
3823 (tty_turn_off_highlight, get_tty_terminal, max_frame_cols):
3824 (max_frame_lines, tty_set_terminal_modes):
3825 (tty_reset_terminal_modes, tty_turn_off_highlight):
3826 (get_tty_terminal): Now static.
3827 (term_mouse_moveto): Do not define if HAVE_WINDOW_SYSTEM.
3828 * termhooks.h (term_mouse_moveto): Do not declare if
8bd7b830 3829 HAVE_WINDOW_SYSTEM.
64520e5c
PE
3830 * dispextern.h (tty_set_terminal_modes, tty_reset_terminal_modes):
3831 (tty_turn_off_highlight, get_tty_terminal): Remove decls.
3832
1fa53021
PE
3833 * sysdep.c: Make symbols static if they're not exported.
3834 (emacs_get_tty, emacs_set_tty, old_fcntl_flags, old_fcntl_owner):
3835 Now static.
3836 (sigprocmask_set, full_mask): Remove; unused.
3837 (wait_debugging): Mark as visible.
3838 * syssignal.h (SIGFULLMASK, full_mask): Remove decls.
3839 * systty.h (emacs_get_tty, emacs_set_tty): Remove decls.
3840
d4b43b22
PE
3841 * syntax.c (syntax_temp): Define only if !__GNUC__.
3842
b7c513d0
PE
3843 * sound.c (current_sound_device, current_sound): Now static.
3844
989b29ad
PE
3845 * search.c (searchbufs, searchbuf_head): Now static.
3846
13a55a78
PE
3847 * scroll.c (scroll_cost): Remove; unused.
3848 * dispextern.h (scroll_cost): Remove decl.
3849
de68a1fc
PE
3850 * region-cache.h (pp_cache): Mark as externally visible.
3851
40ccffa6
PE
3852 * process.c: Make symbols static if they're not exported.
3853 (process_tick, update_tick, create_process, chan_process):
3854 (Vprocess_alist, proc_buffered_char, datagram_access):
3855 (fd_callback_data, send_process_frame, process_sent_to): Now static.
3856 (deactivate_process): Mark defn as static, as well as decl.
3857 * lisp.h (create_process): Remove decl.
3858 * process.h (chan_process, Vprocess_alist): Remove decls.
3859
ad64fc97
PE
3860 * print.c: Make symbols static if they're not exported.
3861 (print_depth, new_backquote_output, being_printed, print_buffer):
3862 (print_buffer_size, print_buffer_pos, print_buffer_pos_byte):
3863 (print_interval, print_number_index, initial_stderr_stream):
3864 Now static.
3865 * lisp.h (Fprinc): Remove decl.
3866 (debug_output_compilation_hack): Mark as externally visible.
3867
adddb265
PE
3868 * sysdep.c (croak): Move decl from here to syssignal.h.
3869 * syssignal.h (croak): Put it here, so the API can be checked when
3870 'croak' is called from dissociate_if_controlling_tty.
3871
1717ede2
PE
3872 * minibuf.c: Make symbols static if they're not exported.
3873 (minibuf_save_list, choose_minibuf_frame): Now static.
3874 * lisp.h (choose_minibuf_frame): Remove decl.
3875
fa5fb2bc
PE
3876 * lisp.h (verify_bytepos, count_markers): Mark as externally visible.
3877
1e3890d1
PE
3878 * lread.c: Make symbols static if they're not exported.
3879 (read_objects, initial_obarray, oblookup_last_bucket_number):
3880 Now static.
3881 (make_symbol): Remove; unused.
3882 * lisp.h (initial_obarray, make_symbol): Remove decls.
3883
8a1414fa
PE
3884 * keyboard.c: Make symbols static if they're not exported.
3885 (single_kboard, recent_keys_index, total_keys, recent_keys):
3886 (this_command_key_count_reset, raw_keybuf, raw_keybuf_count):
3887 (this_single_command_key_start, echoing, last_auto_save):
3888 (read_key_sequence_cmd, dribble, recursive_edit_unwind):
3889 (command_loop, echo_now, keyboard_init_hook, help_char_p):
3890 (quit_throw_to_read_char, command_loop_2, top_level_1, poll_timer):
3891 (Vlispy_mouse_stem, double_click_count):
3892 Now static.
3893 (force_auto_save_soon): Define only if SIGDANGER.
3894 (ignore_mouse_drag_p): Now static if
3895 !defined HAVE_WINDOW_SYSTEM || defined USE_GTK || defined HAVE_NS.
3896 (print_help): Remove; unused.
3897 (stop_character, last_timer_event): Mark as externally visible.
3898 * keyboard.h (ignore_mouse_drag_p): Declare only if
3899 defined HAVE_WINDOW_SYSTEM && !defined USE_GTK && !defined HAVE_NS.
3900 (echo_now, help_char_p, quit_throw_to_read_char): Remove decls.
3901 * lisp.h (echoing): Remove decl.
3902 (force_auto_save_soon): Declare only if SIGDANGER.
3903 * xdisp.c (redisplay_window): Simplify code, to make it more
3904 obvious that ignore_mouse_drag_p is not accessed if !defined
3905 USE_GTK && !defined HAVE_NS.
3906
93ea6e8f
PE
3907 * intervals.c: Make symbols static if they're not exported.
3908 (merge_properties_sticky, merge_interval_right, delete_interval):
3909 Now static.
3910 * intervals.h (merge_interval_right, delete_interval): Remove decls.
3911
77382fcc
PE
3912 * insdel.c: Make symbols static if they're not exported.
3913 However, leave prepare_to_modify_buffer alone. It's never
3914 called from outside this function, but that appears to be a bug.
3915 (combine_after_change_list, combine_after_change_buffer):
4889fc82 3916 (adjust_after_replace, signal_before_change): Now static.
77382fcc
PE
3917 (adjust_after_replace_noundo): Remove; unused.
3918 * lisp.h (adjust_after_replace, adjust_after_replace_noundo):
4889fc82 3919 (signal_before_change): Remove decls.
77382fcc 3920
9306c32e
PE
3921 * indent.c (val_compute_motion, val_vmotion): Now static.
3922
cd44d2eb
PE
3923 * image.c: Make symbols static if they're not exported.
3924 * dispextern.h (x_create_bitmap_from_xpm_data): Do not declare
3925 if USE_GTK.
3926 * image.c (x_create_bitmap_from_xpm_data): Do not define if USE_GTK.
3927 (xpm_color_cache, ct_table, ct_colors_allocated): Now static.
3928
ad9a7a06
PE
3929 * fringe.c (standard_bitmaps): Now static.
3930 (max_used_fringe_bitmap): Now static, unless HAVE_NS.
3931
81626931
PE
3932 * frame.c: Make symbols static if they're not exported.
3933 (x_report_frame_params, make_terminal_frame): Now static.
3934 (get_frame_param): Now static, unless HAVE_NS.
3935 (x_fullscreen_adjust): Define if WINDOWSNT, not if HAVE_WINDOW_SYSTEM.
3936 (x_get_resource_string): Remove; not used.
3937 * frame.h (make_terminal_frame, x_report_frame_params):
3938 (x_get_resource_string); Remove decls.
3939 (x_fullscreen_adjust): Declare only if WINDOWSNT.
3940 * lisp.h (get_frame_param): Declare only if HAVE_NS.
3941
239f9db9
PE
3942 * font.c, fontset.c: Make symbols static if they're not exported.
3943 * dispextern.h (FACE_SUITABLE_FOR_ASCII_CHAR_P): New macro.
3944 (FACE_SUITABLE_FOR_CHAR_P): Use it.
3945 * font.c (font_close_object): Now static.
3946 * font.h (font_close_object): Remove.
3947 * fontset.c (FONTSET_OBJLIST): Remove.
3948 (free_realized_fontset) #if-0 the body, which does nothing.
3949 (face_suitable_for_char_p): #if-0, as it's never called.
3950 * fontset.h (face_suitable_for_char_p): Remove decl.
04f2d78b
CB
3951 * xfaces.c (face_at_string_position):
3952 Use FACE_SUITABLE_FOR_ASCII_CHAR_P, not FACE_SUITABLE_FOR_CHAR_P,
239f9db9
PE
3953 since 0 is always ASCII.
3954
dfcf3579
PE
3955 * fns.c (weak_hash_tables): Now static.
3956
5045092b
PE
3957 * fileio.c: Make symbols static if they're not exported.
3958 (auto_saving, auto_save_mode_bits, auto_save_error_occurred):
3959 (Vwrite_region_annotation_buffers): Now static.
3960
57a96f5c
PE
3961 * eval.c: Make symbols static if they're not exported.
3962 (backtrace_list, lisp_eval_depth, when_entered_debugger): Now static.
3963 * lisp.h (backtrace_list): Remove decl.
3964
35f08c38
PE
3965 * emacs.c: Make symbols static if they're not exported.
3966 (malloc_state_ptr, malloc_using_checking, syms_of_emacs):
3967 (fatal_error_code, fatal_error_signal_hook, standard_args):
3968 Now static.
3969 (fatal_error_signal): Now static, unless FLOAT_CATCH_SIGKILL.
3970 (DEFINE_DUMMY_FUNCTION): Mark function as externally visible.
3971 (__CTOR_LIST__, __DTOR_LIST__): Now externally visible.
3972 * lisp.h (fatal_error_signal_hook): Remove decl.
3973 (fatal_error_signal): Declare only if FLOAT_CATCH_SIGKILL.
3974
f44bd759
PE
3975 * editfns.c: Move a (normally-unused) function to its only use.
3976 * editfns.c, lisp.h (get_operating_system_release): Remove.
3977 * process.c (init_process) [DARWIN_OS]: Do it inline, as it is not
3978 worth the hassle of breaking this out.
3979
b532497d
PE
3980 * xterm.c: Make symbols static if they're not exported.
3981 (x_raise_frame, x_lower_frame, x_wm_set_window_state):
3982 (x_wm_set_icon_pixmap, x_initialize, XTread_socket_fake_io_error):
3983 (x_destroy_window, x_delete_display):
3984 Now static.
3985 (x_dispatch_event): Now static if ! (USE_MOTIF || USE_X_TOOLKIT).
3986 (x_mouse_leave): Remove; unused.
3987 * xterm.h (x_display_info_for_name, x_raise_frame, x_lower_frame):
3988 (x_destroy_window, x_wm_set_window_state, x_wm_set_icon_pixmap):
3989 (x_delete_display, x_initialize, x_set_border_pixel, x_screen_planes):
3990 Remove decls.
3991 (x_mouse_leave): Declare only if WINDOWSNT.
3992 (x_dispatch_event): Declare only if USE_MOTIF or USE_X_TOOLKIT.
3993 (xic_create_fontsetname): Declare only if HAVE_X_WINDOWS &&
3994 USE_X_TOOLKIT.
3995
1675728f
PE
3996 * ftxfont.c: Make symbols static if they're not exported.
3997 (ftxfont_driver): Export only if !defined HAVE_XFT && def8ined
3998 HAVE_FREETYPE.
3999 * font.h (ftxfont_driver): Likewise.
4000
e4cebfca
PE
4001 * xfns.c: Make symbols static if they're not exported.
4002 (x_last_font_name, x_display_info_for_name):
4003 (x_set_foreground_color, x_set_background_color, x_set_mouse_color):
4004 (x_set_cursor_color, x_set_border_pixel, x_set_border_color):
4005 (x_set_cursor_type, x_set_icon_type, x_set_icon_name):
4006 (x_set_scroll_bar_foreground, x_set_scroll_bar_background):
4007 (x_explicitly_set_name, x_set_title, xic_defaut_fontset, tip_timer):
4008 (last_show_tip_args): Now static.
4009 (xic_defaut_fontset, xic_create_fontsetname): Define only if
4010 defined HAVE_X_WINDOWS && defined USE_X_TOOLKIT
4011 (x_screen_planes): Remove; unused.
4012 * dispextern.h (x_screen_planes): Remove decl.
4013
5bf46f05
PE
4014 * dispnew.c: Make symbols static if they're not exported.
4015 * dispextern.h (redraw_garbaged_frames, scrolling):
4016 (increment_row_positions): Remove.
4017 * dispnew.c (new_glyph_matrix, increment_row_positions, scrolling):
4018 (delayed_size_change, glyph_matrix_count, glyph_pool_count):
4019 Now static.
4020 (redraw_garbaged_frames): Remove; unused.
4021
435f4c28
PE
4022 * xfaces.c: Make symbols static if they're not exported.
4023 * dispextern.h (ascii_face_of_lisp_face, free_realized_face):
4024 Remove decls.
4025 * xterm.h (defined_color): Remove decls.
4026 (x_free_dpy_colors): Declare only if USE_X_TOOLKIT.
4027 * xfaces.c (tty_suppress_bold_inverse_default_colors_p):
4028 (menu_face_changed_default, defined_color, free_realized_face):
4029 (x_free_dpy_colors): Define only if USE_X_TOOLKIT.
4030 (ascii_face_of_lisp_face): Remove; unused.
4031
8524aef3
PE
4032 * xdisp.c: Make symbols static if they're not exported.
4033 * dispextern.h (scratch_glyph_row, window_box_edges):
4034 (glyph_to_pixel_coords, set_cursor_from_row):
4035 (get_next_display_element, set_iterator_to_next):
4036 (highlight_trailing_whitespace, frame_to_window_pixel_xy):
4037 (show_mouse_face): Remove decls
4038 * frame.h (message_buf_print): Likewise.
4039 * lisp.h (pop_message, set_message, check_point_in_composition):
4040 Likewise.
4041 * xterm.h (set_vertical_scroll_bar): Likewise.
4042 * xdisp.c (list_of_error, Vmessage_stack, line_number_displayed):
4043 (message_buf_print, scratch_glyph_row, displayed_buffer):
4044 (set_iterator_to_next, pop_message, set_message, set_cursor_from_row):
4045 (get_next_display_element, show_mouse_face, window_box_edges):
4046 (frame_to_window_pixel_xy, check_point_in_composition):
4047 (set_vertical_scroll_bar, highlight_trailing_whitespace): Now static.
4048 (glyph_to_pixel_coords): Remove; unused.
4049
16390cd2
PE
4050 * dired.c (file_name_completion): Now static.
4051
4052 * dbusbind.c (xd_in_read_queued_messages): Now static.
4053
a25f4dfa
PE
4054 * lisp.h (circular_list_error, FOREACH): Remove; unused.
4055 * data.c (circular_list_error): Remove.
4056
14a9c8df
PE
4057 * commands.h (last_point_position, last_point_position_buffer):
4058 (last_point_position_window): Remove decls.
4059 * keyboard.c: Make these variables static.
4060
04f2d78b
CB
4061 * coding.h (coding, code_convert_region, encode_coding_gap):
4062 Remove decls.
74ab6df5
PE
4063 * coding.c (Vsjis_coding_system, Vbig5_coding_system):
4064 (iso_code_class, detect_coding, code_convert_region): Now static.
4065 (encode_coding_gap): Remove; unused.
4066
38dfbee1
PE
4067 * chartab.c (chartab_chars, chartab_bits): Now static.
4068
a2cb4e63
PE
4069 * charset.h (charset_iso_8859_1): Remove decl.
4070 * charset.c (charset_iso_8859_1, charset_emacs, map_charset_for_dump):
4071 Now static.
4072
127198fd
PE
4073 * ccl.h (check_ccl_update, Vccl_program_table): Remove decls.
4074 * ccl.c (Vccl_program_table): Now static.
4075 (check_ccl_update): Remove; unused.
4076
d85b608f
PE
4077 * category.c (SET_CATEGORY_SET, set_category_set): Move here.
4078 * category.h: ... from here.
4079 * category.c (check_category_table, set_category_set): Now static.
4080
31cd66f3
PE
4081 * casetab.c (Vascii_upcase_table, Vascii_eqv_table): Now static.
4082 * lisp.h: Remove these decls.
4083
c358e587
PE
4084 * buffer.c (buffer_count): Remove unused var.
4085
e78aecca
PE
4086 * bidi.c (bidi_dump_cached_states): Mark as externally visible,
4087 so that it's not optimized away.
4088 (bidi_ignore_explicit_marks_for_paragraph_level): Likewise.
4089 * dispextern.h (bidi_dump_cached_states): Remove, since it's
4090 exported only to the debugger.
4091
e192d7d3 4092 * atimer.c (alarm_signal_handler, run_all_atimers): Now static.
04f2d78b 4093 * atimer.h (run_all_atimers): Remove; not exported.
e192d7d3 4094
92470028
PE
4095 font.c: Make copy_font_spec and merge_font_spec ordinary C functions.
4096 * font.c (copy_font_spec): Rename from Fcopy_font_spec, since it
4097 was inaccessible from Lisp.
4098 (merge_font_spec): Likewise, renaming from Fmerge_font_spec.
4099 * font.c, font.h, fontset.c, xfaces.c, xfont.c: Change all uses.
4100
244ed907
PE
4101 alloc.c: Import and export fewer symbols, and remove unused items.
4102 * lisp.h (suppress_checking, die): Declare only if ENABLE_CHECKING
4103 is defined.
4104 (suppress_checking): Add EXTERNALLY_VISIBLE attribute, so that
4105 it's not optimized away by whole-program optimization.
4106 (message_enable_multibyte, free_misc): Remove.
4107 (catchlist, handlerlist, mark_backtrace):
4108 Declare only if BYTE_MARK_STACK.
4109 (mark_byte_stack): Likewise, fixing a ifdef-vs-if typo.
4110 * alloc.c (pure): Export only if VIRT_ADDR_VARIES is defined.
4111 (message_enable_multibyte): Remove decl.
4112 (free_misc, interval_free_list, float_block, float_block_index):
4113 (n_float_blocks, float_free_list, cons_block, cons_block_index):
4114 (cons_free_list, last_marked_index):
4115 Now static.
4116 (suppress_checking, die): Define only if ENABLE_CHECKING is defined.
4117 * eval.c (catchlist, handlerlist): Export only if BYTE_MARK_STACK.
4118 (mark_backtrace): Define only if BYTE_MARK_STACK.
4119 * xdisp.c (message_enable_multibyte): Now static.
4120
61c2b50e 4121 Declare Lisp_Object Q* variables to be 'static' if not exported.
955cbe7b
PE
4122 This makes it easier for human readers (and static analyzers)
4123 to see whether these variables are used from other modules.
4124 * alloc.c, buffer.c, bytecode.c, callint.c, casetab.c, category.c:
4125 * ccl.c, character.c, charset.c, cmds.c, coding.c, composite.c:
4126 * data.c, dbusbind.c, dired.c, editfns.c, eval.c, fileio.c, fns.c:
4127 * font.c, frame.c, fringe.c, ftfont.c, image.c, keyboard.c, keymap.c:
4128 * lread.c, macros.c, minibuf.c, print.c, process.c, search.c:
4129 * sound.c, syntax.c, textprop.c, window.c, xdisp.c, xfaces.c, xfns.c:
4130 * xmenu.c, xselect.c:
4131 Declare Q* vars static if they are not used in other modules.
4132 * ccl.h, character.h, charset.h, coding.h, composite.h, font.h:
4133 * frame.h, intervals.h, keyboard.h, lisp.h, process.h, syntax.h:
4134 Remove decls of unexported vars.
4135 * keyboard.h (EVENT_HEAD_UNMODIFIED): Remove now-unused macro.
4136
95c82688
PE
4137 * lisp.h (DEFINE_FUNC): Make sname 'static'.
4138
16a97296
PE
4139 Make Emacs functions such as Fatom 'static' by default.
4140 This makes it easier for human readers (and static analyzers)
4141 to see whether these functions can be called from other modules.
4142 DEFUN now defines a static function. To make the function external
4143 so that it can be used in other C modules, use the new macro DEFUE.
8bd7b830
PE
4144 * lisp.h (Funibyte_char_to_multibyte, Fsyntax_table_p):
4145 (Finit_image_library):
16a97296
PE
4146 (Feval_region, Fbacktrace, Ffetch_bytecode, Fswitch_to_buffer):
4147 (Ffile_executable_p, Fmake_symbolic_link, Fcommand_execute):
4148 (Fget_process, Fdocumentation_property, Fbyte_code, Ffile_attributes):
4149 Remove decls, since these functions are now static.
4150 (Funintern, Fget_internal_run_time): New decls, since these functions
4151 were already external.
95c82688 4152
16a97296
PE
4153 * alloc.c, buffer.c, callint.c, callproc.c, casefiddle.c, casetab.c:
4154 * ccl.c, character.c, chartab.c, cmds.c, coding.c, data.c, dispnew.c:
4155 * doc.c, editfns.c, emacs.c, eval.c, fileio.c, filelock.c, floatfns.c:
4156 * fns.c, font.c, fontset.c, frame.c, image.c, indent.c:
4157 * keyboard.c, keymap.c, lread.c:
4158 * macros.c, marker.c, menu.c, minibuf.c, print.c, process.c, search.c:
4159 * syntax.c, term.c, terminal.c, textprop.c, undo.c:
4160 * window.c, xdisp.c, xfaces.c, xfns.c, xmenu.c, xsettings.c:
4161 Mark functions with DEFUE instead of DEFUN,
4162 if they are used in other modules.
4163 * buffer.c (Fset_buffer_major_mode, Fdelete_overlay): New forward
4164 decls for now-static functions.
4165 * buffer.h (Fdelete_overlay): Remove decl.
4166 * callproc.c (Fgetenv_internal): Mark as internal.
4167 * composite.c (Fremove_list_of_text_properties): Remove decl.
4168 (Fcomposition_get_gstring): New forward static decl.
4169 * composite.h (Fcomposite_get_gstring): Remove decl.
4170 * dired.c (Ffile_attributes): New forward static decl.
4171 * doc.c (Fdocumntation_property): New forward static decl.
4172 * eval.c (Ffetch_bytecode): New forward static decl.
4173 (Funintern): Remove extern decl; now in .h file where it belongs.
4174 * fileio.c (Fmake_symbolic_link): New forward static decl.
4175 * image.c (Finit_image_library): New forward static decl.
4176 * insdel.c (Fcombine_after_change_execute): Make forward decl static.
4177 * intervals.h (Fprevious_property_change):
4178 (Fremove_list_of_text_properties): Remove decls.
4179 * keyboard.c (Fthis_command_keys): Remove decl.
4180 (Fcommand_execute): New forward static decl.
4181 * keymap.c (Flookup_key): New forward static decl.
4182 (Fcopy_keymap): Now static.
4183 * keymap.h (Flookup_key): Remove decl.
4184 * process.c (Fget_process): New forward static decl.
4185 (Fprocess_datagram_address): Mark as internal.
4186 * syntax.c (Fsyntax_table_p): New forward static decl.
4187 (skip_chars): Remove duplicate decl.
4188 * textprop.c (Fprevious_property_change): New forward static decl.
4189 * window.c (Fset_window_fringes, Fset_window_scroll_bars):
4190 Now internal.
4191 (Fset_window_margins, Fset_window_vscroll): New forward static decls.
4192 * window.h (Fset_window_vscroll, Fset_window_margins): Remove decls.
4193
785bbd42
PE
4194 * editfns.c (Fformat): Remove unreachable code.
4195
8b913b57
AS
41962011-04-14 Andreas Schwab <schwab@linux-m68k.org>
4197
4198 * fileio.c (Finsert_file_contents): Fix typo in 2005-05-13
4199 change. (Bug#8496)
4200
a6744a35
EZ
42012011-04-13 Eli Zaretskii <eliz@gnu.org>
4202
4203 * xdisp.c (handle_invisible_prop): Don't call bidi_paragraph_init
4204 when at ZV. (Bug#8487)
4205
e7974947
AS
42062011-04-12 Andreas Schwab <schwab@linux-m68k.org>
4207
baad03f0
AS
4208 * charset.c (Fclear_charset_maps): Use xfree instead of free.
4209 (Bug#8437)
4210 * keyboard.c (parse_tool_bar_item): Likewise.
4211 * sound.c (sound_cleanup, alsa_close): Likewise.
4212 * termcap.c (tgetent): Likewise.
4213 * xfns.c (x_default_font_parameter): Likewise.
4214 * xsettings.c (read_and_apply_settings): Likewise.
4215
e7974947
AS
4216 * alloc.c (overrun_check_malloc, overrun_check_realloc)
4217 (overrun_check_free): Protoize.
4218
28272684
PE
42192011-04-12 Paul Eggert <eggert@cs.ucla.edu>
4220
4221 * sysdep.c (emacs_read, emacs_write): Check for negative sizes
4222 since callers should never pass a negative size.
4223 Change the signature to match that of plain 'read' and 'write'; see
4224 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00397.html>.
4225 * lisp.h: Update prototypes of emacs_write and emacs_read.
4226
11997c76
EZ
42272011-04-11 Eli Zaretskii <eliz@gnu.org>
4228
4229 * xdisp.c (redisplay_window): Don't try to determine the character
4230 position of the scroll margin if the window start point w->startp
e896f03c 4231 is outside the buffer's accessible region. (Bug#8468)
11997c76 4232
8a2cbd72
EZ
42332011-04-10 Eli Zaretskii <eliz@gnu.org>
4234
4235 Fix write-region and its subroutines for buffers > 2GB.
4236 * fileio.c (a_write, e_write): Modify declaration of arguments and
4237 local variables to support buffers larger than 2GB.
4238 (Fcopy_file): Use EMACS_INT for return value of emacs_read.
4239
4240 * sysdep.c (emacs_write, emacs_read): Use ssize_t for last
4241 argument, local variables, and return value.
4242
4243 * lisp.h: Update prototypes of emacs_write and emacs_read.
4244
4245 * sound.c (vox_write): Use ssize_t for return value of emacs_write.
4246
4073e537 42472011-04-10 Paul Eggert <eggert@cs.ucla.edu>
eb3f1cc8 4248
1ebfdcb6
PE
4249 * xdisp.c (vmessage): Use memchr, not strnlen, which some hosts lack.
4250
b2ded58d
PE
4251 Fix more problems found by GCC 4.6.0's static checks.
4252
7d66342c
PE
4253 * xdisp.c (vmessage): Use a better test for character truncation.
4254
bbf47d44
PE
4255 * charset.c (load_charset_map): <, not <=, for optimization,
4256 and to avoid potential problems with integer overflow.
9248994d 4257 * chartab.c (sub_char_table_set_range, char_table_set_range): Likewise.
f9a68bc5 4258 * casetab.c (set_identity, shuffle): Likewise.
3ab1c7ce 4259 * editfns.c (Fformat): Likewise.
1e69125e 4260 * syntax.c (skip_chars): Likewise.
3befa583 4261
e3019616
PE
4262 * xmenu.c (set_frame_menubar): Allocate smaller local vectors.
4263 This also lets GCC 4.6.0 generate slightly better loop code.
4264
becfa255
PE
4265 * callint.c (Fcall_interactively): <, not <=, for optimization.
4266 (Fcall_interactively): Count the number of arguments produced,
4267 not the number of arguments given. This is simpler and lets GCC
4268 4.6.0 generate slightly better code.
4269
dae0cd48
PE
4270 * ftfont.c: Distingish more carefully between FcChar8 and char.
4271 The previous code passed unsigned char * to a functions like
4272 strlen and xstrcasecmp that expect char *, which does not
4273 conform to the C standard.
4274 (get_adstyle_property, ftfont_pattern_entity): Use FcChar8 for
4275 arguments to FcPatternGetString, and explicitly cast FcChar8 * to
4276 char * when the C standard requires it.
4277
76032d70
PE
4278 * keyboard.c (read_char): Remove unused var.
4279
eb3f1cc8
PE
4280 * eval.c: Port to Windows vsnprintf (Bug#8435).
4281 Include <limits.h>.
4282 (SIZE_MAX): Define if the headers do not.
4283 (verror): Do not give up if vsnprintf returns a negative count.
4284 Instead, grow the buffer. This ports to Windows vsnprintf, which
4285 does not conform to C99. Problem reported by Eli Zaretskii.
4286 Also, simplify the allocation scheme, by avoiding the need for
4287 calling realloc, and removing the ALLOCATED variable.
4288
70476b54
PE
4289 * eval.c (verror): Initial buffer size is 4000 (not 200) bytes.
4290
12020a9e
PE
4291 Remove invocations of doprnt, as Emacs now uses vsnprintf.
4292 But keep the doprint source code for now, as we might revamp it
4293 and use it again (Bug#8435).
ea6c7ae6
PE
4294 * lisp.h (doprnt): Remove.
4295 * Makefile.in (base_obj): Remove doprnt.o.
4296 * deps.mk (doprnt.o): Remove.
4297
5fdb398c
PE
4298 error: Print 32- and 64-bit integers portably (Bug#8435).
4299 Without this change, on typical 64-bit hosts error ("...%d...", N)
4300 was used to print both 32- and 64-bit integers N, which relied on
4301 undefined behavior.
4302 * lisp.h, src/m/amdx86-64.h, src/m/ia64.h, src/m/ibms390x.h (pEd):
4303 New macro.
4304 * lisp.h (error, verror): Mark as printf-like functions.
4305 * eval.c (verror): Use vsnprintf, not doprnt, to do the real work.
4306 Report overflow in size calculations when allocating printf buffer.
4307 Do not truncate output string at its first null byte.
4308 * xdisp.c (vmessage): Use vsnprintf, not doprnt, to do the real work.
4309 Truncate the output at a character boundary, since vsnprintf does not
4310 do that.
4311 * charset.c (check_iso_charset_parameter): Convert internal
4312 character to string before calling 'error', since %c now has the
4313 printf meaning.
4314 * coding.c (Fdecode_sjis_char, Fdecode_big5_char): Avoid int
4315 overflow when computing char to be passed to 'error'. Do not
4316 pass Lisp_Object to 'error'; pass the integer instead.
4317 * nsfns.m (Fns_do_applescript): Use int, not long, since it's
4318 formatted with plain %d.
4319
b189fa66
PE
4320 * eval.c (internal_lisp_condition_case): Don't pass spurious arg.
4321
bff87ef0
PE
4322 * keyboard.c (access_keymap_keyremap): Print func name, not garbage.
4323
7e2cac20
PE
4324 * coding.c (Fdecode_sjis_char): Don't assume CODE fits in int.
4325
ce4d90b5
PE
4326 * xterm.c (x_catch_errors): Remove duplicate declaration.
4327
266c9547
PE
4328 * term.c (maybe_fatal): Mark its 3rd arg as a printf format, too.
4329
79c49ad2
PE
4330 * xdisp.c, lisp.h (message_nolog): Remove; unused.
4331
368f4090
JM
43322011-04-10 Jim Meyering <meyering@redhat.com>
4333
4334 use ssize_t and size_t for read- and write-like emacs_gnutls_* functions
4335 * gnutls.c (emacs_gnutls_read): Adjust signature to be more read-like:
4336 return ssize_t not "int", and use size_t as the buffer length.
4337 (emacs_gnutls_write): Likewise, and make the buffer pointer "const".
4338 * gnutls.h: Update declarations.
4339 * process.c (read_process_output): Use ssize_t, to match.
4340 (send_process): Likewise.
4341
a32d4040
CY
43422011-04-09 Chong Yidong <cyd@stupidchicken.com>
4343
4344 * image.c (Fimagemagick_types): Doc fix, and comment cleanup.
4345
8546720e 43462011-04-09 Chong Yidong <cyd@stupidchicken.com>
aac0c6e3 4347
04f2d78b
CB
4348 * ftfont.c (get_adstyle_property, ftfont_pattern_entity):
4349 Use unsigned char, to match FcChar8 type definition.
aac0c6e3 4350
8546720e
GM
4351 * xterm.c (handle_one_xevent):
4352 * xmenu.c (create_and_show_popup_menu):
4353 * xselect.c (x_decline_selection_request)
4354 (x_reply_selection_request): Avoid type-punned deref of X events.
aac0c6e3 4355
0a2f5c1a 43562011-04-09 Eli Zaretskii <eliz@gnu.org>
a53e2e89
EZ
4357
4358 Fix some uses of `int' instead of EMACS_INT.
4359 * search.c (string_match_1, fast_string_match)
4360 (fast_c_string_match_ignore_case, fast_string_match_ignore_case)
4361 (scan_buffer, find_next_newline_no_quit)
4362 (find_before_next_newline, search_command, Freplace_match)
4363 (Fmatch_data): Make some `int' variables be EMACS_INT.
4364
4365 * xdisp.c (display_count_lines): 3rd argument and return value now
4366 EMACS_INT. All callers changed.
4367 (pint2hrstr): Last argument is now EMACS_INT.
4368
4369 * coding.c (detect_coding_utf_8, detect_coding_emacs_mule)
4370 (detect_coding_iso_2022, detect_coding_sjis, detect_coding_big5)
4371 (detect_coding_ccl, detect_coding_charset, decode_coding_utf_8)
4372 (decode_coding_utf_16, decode_coding_emacs_mule)
4373 (decode_coding_iso_2022, decode_coding_sjis, decode_coding_big5)
4374 (decode_coding_ccl, decode_coding_charset)
4375 <consumed_chars, consumed_chars_base>: Declare EMACS_INT.
4376 (decode_coding_iso_2022, decode_coding_emacs_mule)
4377 (decode_coding_sjis, decode_coding_big5, decode_coding_charset)
4378 <char_offset, last_offset>: Declare EMACS_INT.
4379 (encode_coding_utf_8, encode_coding_utf_16)
4380 (encode_coding_emacs_mule, encode_invocation_designation)
4381 (encode_designation_at_bol, encode_coding_iso_2022)
4382 (encode_coding_sjis, encode_coding_big5, encode_coding_ccl)
4383 (encode_coding_raw_text, encode_coding_charset) <produced_chars>:
4384 Declare EMACS_INT.
4385 (ASSURE_DESTINATION): Declare more_bytes EMACS_INT.
4386 (encode_invocation_designation): Last argument P_NCHARS is now
4387 EMACS_INT.
4388 (decode_eol): Declare pos_byte, pos, and pos_end EMACS_INT.
4389 (produce_chars): from_nchars and to_nchars are now EMACS_INT.
4390
4391 * coding.h (struct coding_system) <head_ascii>: Declare EMACS_INT.
4392 All users changed.
4393
4394 * ccl.c (Fccl_execute_on_string): Declare some variables
4395 EMACS_INT.
4396
8546720e 43972011-04-08 Samuel Thibault <sthibault@debian.org> (tiny change)
0080dc6b
SS
4398
4399 * term.c (init_tty): Fix incorrect ifdef placement (Bug#8450).
4400
4e19a977
CS
44012011-03-19 Christoph Scholtes <cschol2112@googlemail.com>
4402
4403 * process.c (Fformat_network_address): Doc fix.
4404
87302331
R
44052011-04-08 T.V. Raman <tv.raman.tv@gmail.com> (tiny change)
4406
4407 * xml.c (parse_region): Avoid creating spurious whiespace nodes.
4408
cbb59342
CY
44092011-04-08 Chong Yidong <cyd@stupidchicken.com>
4410
4411 * keyboard.c (read_char): Call Lisp function help-form-show,
4412 instead of using internal_with_output_to_temp_buffer.
4413 (Qhelp_form_show): New var.
e0d38eeb 4414 (syms_of_keyboard): Use DEFSYM macro.
cbb59342
CY
4415
4416 * print.c (internal_with_output_to_temp_buffer): Function deleted.
4417
4418 * lisp.h (internal_with_output_to_temp_buffer): Remove prototype.
4419
e67a13ab
CY
44202011-04-06 Chong Yidong <cyd@stupidchicken.com>
4421
04f2d78b
CB
4422 * process.c (Flist_processes): Remove to Lisp.
4423 (list_processes_1): Delete.
e67a13ab 4424
973f782d
EZ
44252011-04-06 Eli Zaretskii <eliz@gnu.org>
4426
7c106b1e
EZ
4427 * msdos.c (careadlinkat, careadlinkatcwd): MS-DOS replacements.
4428
973f782d
EZ
4429 * w32.c (careadlinkat, careadlinkatcwd): New always-fail stubs.
4430
41cf7d1a 44312011-04-06 Paul Eggert <eggert@cs.ucla.edu>
27ccc379 4432
ca23cc88
PE
4433 Fix more problems found by GCC 4.6.0's static checks.
4434
f390e2d5
PE
4435 * xmenu.c (Fx_popup_dialog): Don't assume string is free of formats.
4436
42eea0d0
PE
4437 * menu.c (Fx_popup_menu): Don't assume error_name lacks printf formats.
4438
b69769da 4439 * lisp.h (message, message_nolog, fatal): Mark as printf-like.
1e973bc7 4440
f9541e84
PE
4441 * xdisp.c (vmessage): Mark as a printf-like function.
4442
13841b55
PE
4443 * term.c (vfatal, maybe_fatal): Mark as printf-like functions.
4444
c136c10f
PE
4445 * sound.c (sound_warning): Don't crash if arg contains a printf format.
4446
5e2d4a30
PE
4447 * image.c (tiff_error_handler, tiff_warning_handler): Mark as
4448 printf-like functions.
4449 (tiff_load): Add casts to remove these marks before passing them
4450 to system-supplied API.
4451
583f48b9
PE
4452 * eval.c (Fsignal): Remove excess argument to 'fatal'.
4453
b25d760e
PE
4454 * coding.c (EMIT_ONE_BYTE, EMIT_TWO_BYTES): Use unsigned, not int.
4455 This avoids several warnings with gcc -Wstrict-overflow.
d5efd1d1
PE
4456 (DECODE_COMPOSITION_RULE): If the rule is invalid, goto invalid_code
4457 directly, rather than having caller test rule sign. This avoids
4458 some unnecessary tests.
4459 * composite.h (COMPOSITION_ENCODE_RULE_VALID): New macro.
4460 (COMPOSITION_ENCODE_RULE): Arguments now must be valid. This
4461 affects only one use, in DECODE_COMPOSITION_RULE, which is changed.
b25d760e 4462
bc7b6697 4463 * xfont.c (xfont_text_extents): Remove var that was set but not used.
625a3eb1 4464 (xfont_open): Avoid unnecessary tests.
bc7b6697 4465
27ccc379
PE
4466 * composite.c (composition_gstring_put_cache): Use unsigned integer.
4467
dcd5c89a
PE
4468 * composite.h, composite.c (composition_gstring_put_cache):
4469 Use EMACS_INT, not int, for length.
4470
b13a45c6
PE
4471 * composite.h (COMPOSITION_DECODE_REFS): New macro,
4472 breaking out part of COMPOSITION_DECODE_RULE.
4473 (COMPOSITION_DECODE_RULE): Use it.
4474 * composite.c (get_composition_id): Remove unused local vars,
4475 by using the new macro.
4476
1e792e4d
PE
4477 * textprop.c (set_text_properties_1): Change while to do-while,
4478 since the condition is always true at first.
4479
dc6c6455 4480 * intervals.c (graft_intervals_into_buffer): Mark var as used.
aa86731f
PE
4481 (interval_deletion_adjustment): Return unsigned value.
4482 All uses changed.
dc6c6455 4483
aba7731a
PE
4484 * process.c (list_processes_1, create_pty, read_process_output):
4485 (exec_sentinel): Remove vars that were set but not used.
afd4052b 4486 (create_pty): Remove unnecessary "volatile"s.
bc57d757 4487 (Fnetwork_interface_info): Avoid possibility of int overflow.
82eaa333 4488 (read_process_output): Do adaptive read buffering even if carryover.
fe07cdfa 4489 (read_process_output): Simplify nbytes computation if buffered.
aba7731a 4490
fdfc4bf3
PE
4491 * bytecode.c (exec_byte_code): Rename local to avoid shadowing.
4492
fca8fe46 4493 * syntax.c (scan_words): Remove var that was set but not used.
12cbf13f 4494 (update_syntax_table): Use unsigned instead of int.
fca8fe46 4495
06a0259a 4496 * lread.c (lisp_file_lexically_bound_p): Use ints rather than endptrs.
3c346cc3 4497 (lisp_file_lexically_bound_p, read1): Use unsigned instead of int.
e6eb4e9e 4498 (safe_to_load_p): Make the end-of-loop test the inverse of the in-loop.
06a0259a 4499
e7b9e80f
PE
4500 * print.c (print_error_message): Avoid int overflow.
4501
56201685
PE
4502 * font.c (font_list_entities): Redo for clarity,
4503 so that reader need not know FONT_DPI_INDEX + 1 == FONT_SPACING_INDEX.
4504
78834453 4505 * font.c (font_find_for_lface, Ffont_get_glyphs): Remove unused vars.
790771b1 4506 (font_score): Avoid potential overflow in diff calculation.
78834453 4507
0bc0b309 4508 * fns.c (substring_both): Remove var that is set but not used.
8cd55cb4 4509 (sxhash): Redo loop for clarity and to avoid wraparound warning.
0bc0b309 4510
e610eaca
PE
4511 * eval.c (funcall_lambda): Rename local to avoid shadowing.
4512
b895abce
PE
4513 * alloc.c (mark_object_loop_halt, mark_object): Use size_t, not int.
4514 Otherwise, GCC 4.6.0 optimizes the loop check away since the check
4515 can always succeed if overflow has undefined behavior.
4516
1f1d9321 4517 * search.c (boyer_moore, wordify): Remove vars set but not used.
6f076cc7 4518 (wordify): Omit three unnecessary tests.
1f1d9321 4519
c59478bc
PE
4520 * indent.c (MULTIBYTE_BYTES_WIDTH): Don't compute wide_column.
4521 All callers changed. This avoids the need for an unused var.
4522
79b73827
PE
4523 * casefiddle.c (casify_region): Remove var that is set but not used.
4524
a4db5dfe
PE
4525 * dired.c (file_name_completion): Remove var that is set but not used.
4526
43aae36e
PE
4527 * fileio.c (Finsert_file_contents): Make EOF condition clearer.
4528
2a47c44d 4529 * fileio.c (Finsert_file_contents): Avoid signed integer overflow.
163c5f32 4530 (Finsert_file_contents): Remove unnecessary code checking fd.
2a47c44d 4531
a37c69bf
PE
4532 * minibuf.c (read_minibuf_noninteractive): Use size_t for sizes.
4533 Check for integer overflow on size calculations.
4534
328ab8e7
PE
4535 * buffer.c (Fprevious_overlay_change): Remove var that is set
4536 but not used.
4537
e5a2a5cb
PE
4538 * keyboard.c (menu_bar_items, read_char_minibuf_menu_prompt):
4539 Remove vars that are set but not used.
8d84a6eb 4540 (timer_check_2): Don't assume timer-list and idle-timer-list are lists.
6b043475 4541 (timer_check_2): Mark vars as initialized.
e5a2a5cb 4542
a60e5f68
PE
4543 * gtkutil.c (xg_get_file_with_chooser): Mark var as initialized.
4544
f661cb61 4545 * image.c (lookup_image): Remove var that is set but not used.
35fa624f 4546 (xbm_load): Use parse_p, for gcc -Werror=unused-but-set-variable.
f661cb61 4547
f0397f5a
PE
4548 * fontset.c (Finternal_char_font, Ffontset_info): Remove vars
4549 that are set but not used.
4550
8664db06 4551 * xfns.c (make_invisible_cursor): Don't return garbage
03733ee7 4552 if XCreateBitmapFromData fails (Bug#8410).
8664db06 4553
6abdaa4a
PE
4554 * xselect.c (x_get_local_selection, x_handle_property_notify):
4555 Remove vars that are set but not used.
4556
0ce7538d 4557 * xfns.c (x_create_tip_frame): Remove var that is set but not used.
6abdaa4a 4558 (make_invisible_cursor): Initialize a possibly-uninitialized variable.
0ce7538d 4559
9ae848fc
PE
4560 * xterm.c (x_scroll_bar_to_input_event) [!USE_GTK]:
4561 Remove var that is set but not used.
0b918413
PE
4562 (scroll_bar_windows_size): Now size_t, not int.
4563 (x_send_scroll_bar_event): Use size_t, not int, for sizes.
4564 Check for overflow.
9ae848fc 4565
a5a62657
PE
4566 * xfaces.c (realize_named_face): Remove vars that are set but not used.
4567 (map_tty_color) [!defined MSDOS]: Likewise.
4568
5c5cdd39
PE
4569 * term.c (tty_write_glyphs): Use size_t; this avoids overflow warning.
4570
66ebf983
PE
4571 * coding.c: Remove vars that are set but not used.
4572 (DECODE_COMPOSITION_RULE): Remove 2nd arg, which is unused.
4573 All callers changed.
4574 (decode_coding_utf_8, decode_coding_utf_16 decode_coding_emacs_mule):
4575 (decode_coding_iso_2022, encode_coding_sjis, encode_coding_big5):
4576 (decode_coding_charset): Remove vars that are set but not used.
4577
1be4d761
PE
4578 * bytecode.c (Fbyte_code) [!defined BYTE_CODE_SAFE]: Remove var
4579 that is set but not used.
4580
47553fa8
PE
4581 * print.c (print_object): Remove var that is set but not used.
4582
1f7196bf 4583 Replace 2 copies of readlink code with 1 gnulib version (Bug#8401).
d1fdcab7
PE
4584 The gnulib version avoids calling malloc in the usual case,
4585 and on 64-bit hosts doesn't have some arbitrary 32-bit limits.
4586 * fileio.c (Ffile_symlink_p): Use emacs_readlink.
4587 * filelock.c (current_lock_owner): Likewise.
4588 * lisp.h (READLINK_BUFSIZE, emacs_readlink): New function.
4589 * sysdep.c: Include allocator.h, careadlinkat.h.
4590 (emacs_no_realloc_allocator): New static constant.
4591 (emacs_readlink): New function.
fdb61804
PE
4592 * deps.mk (sysdep.o): Depend on ../lib/allocator.h and on
4593 ../lib/careadlinkat.h.
d1fdcab7 4594
f84c17c7
SM
45952011-04-04 Stefan Monnier <monnier@iro.umontreal.ca>
4596
4597 * keyboard.c (safe_run_hook_funcall): Fix last change (don't stop at the
4598 first non-nil return value).
4599
ef3862ad
JD
46002011-04-03 Jan Djärv <jan.h.d@swipnet.se>
4601
4602 * nsterm.m (ns_update_auto_hide_menu_bar): Define MAC_OS_X_VERSION_10_6
4603 if not defined (Bug#8403).
4604
376a7006
JB
46052011-04-02 Juanma Barranquero <lekktu@gmail.com>
4606
4607 * xdisp.c (display_count_lines): Remove parameter `start',
4608 unused since 1998-01-01T02:27:27Z!rms@gnu.org. All callers changed.
4609 (get_char_face_and_encoding): Remove parameter `multibyte_p',
4610 unused since 2008-05-14T01:40:23Z!handa@m17n.org. All callers changed.
4611 (fill_stretch_glyph_string): Remove parameters `row' and `area',
4612 unused at least since Kim's GUI unification at 2003-03-16T20:45:46Z!storm@cua.dk
4613 and thereabouts. All callers changed.
4614 (get_per_char_metric): Remove parameter `f', unused since
4615 2008-05-14T01:40:23Z!handa@m17n.org. All callers changed.
4616
6ca3801d
JM
46172011-04-02 Jim Meyering <meyering@redhat.com>
4618
4619 do not dereference NULL upon failed strdup
4620 * nsfont.m (ns_descriptor_to_entity): Use xstrdup, not strdup.
4621 (ns_get_family): Likewise.
4622
d8e2b5ba
JB
46232011-04-02 Juanma Barranquero <lekktu@gmail.com>
4624
4625 * eval.c (unwind_to_catch) [DEBUG_GCPRO]: Remove redundant assignment.
4626
8c74fcbd
JD
46272011-04-02 Jan Djärv <jan.h.d@swipnet.se>
4628
4629 * nsterm.m (ns_update_auto_hide_menu_bar): Only for OSX 10.6 or
4630 later (Bug#8403).
4631
7200d79c
SM
46322011-04-01 Stefan Monnier <monnier@iro.umontreal.ca>
4633
03408648 4634 Add lexical binding.
7200d79c 4635
03408648
SM
4636 * window.c (Ftemp_output_buffer_show): New fun.
4637 (Fsave_window_excursion):
4638 * print.c (Fwith_output_to_temp_buffer): Move to subr.el.
4639
4640 * lread.c (lisp_file_lexically_bound_p): New function.
4641 (Fload): Bind Qlexical_binding.
4642 (readevalloop): Remove `evalfun' arg.
4643 Bind Qinternal_interpreter_environment.
4644 (Feval_buffer): Bind Qlexical_binding.
4645 (defvar_int, defvar_bool, defvar_lisp_nopro, defvar_kboard):
4646 Mark as dynamic.
4647 (syms_of_lread): Declare `lexical-binding'.
4648
4649 * lisp.h (struct Lisp_Symbol): New field `declared_special'.
4650
4651 * keyboard.c (eval_dyn): New fun.
4652 (menu_item_eval_property): Use it.
ca105506
SM
4653
4654 * image.c (parse_image_spec): Use Ffunctionp.
ca105506 4655
03408648
SM
4656 * fns.c (concat, mapcar1): Accept byte-code-functions.
4657
4658 * eval.c (Fsetq): Handle lexical vars.
4659 (Fdefun, Fdefmacro, Ffunction): Make closures when needed.
4660 (Fdefconst, Fdefvaralias, Fdefvar): Mark as dynamic.
4661 (FletX, Flet): Obey lexical binding.
4662 (Fcommandp): Handle closures.
4663 (Feval): New `lexical' arg.
4664 (eval_sub): New function extracted from Feval. Use it almost
4665 everywhere where Feval was used. Look up vars in lexical env.
4666 Handle closures.
4667 (Ffunctionp): Move from subr.el.
4668 (Ffuncall): Handle closures.
4669 (apply_lambda): Remove `eval_flags'.
4670 (funcall_lambda): Handle closures and new byte-code-functions.
4671 (Fspecial_variable_p): New function.
4672 (syms_of_eval): Initialize the Vinternal_interpreter_environment var,
4673 but without exporting it to Lisp.
23aba0ea 4674
23aba0ea 4675 * doc.c (Fdocumentation, store_function_docstring):
03408648 4676 * data.c (Finteractive_form): Handle closures.
23aba0ea 4677
03408648
SM
4678 * callint.c (Fcall_interactively): Preserve lexical-binding mode for
4679 interactive spec.
ba83908c 4680
04f2d78b
CB
4681 * bytecode.c (Bstack_ref, Bstack_set, Bstack_set2, BdiscardN):
4682 New byte-codes.
03408648
SM
4683 (exec_byte_code): New function extracted from Fbyte_code to handle new
4684 calling convention for byte-code-functions. Add new byte-codes.
ba83908c 4685
03408648 4686 * buffer.c (defvar_per_buffer): Set new `declared_special' field.
e2abe5a1 4687
03408648 4688 * alloc.c (Fmake_symbol): Init new `declared_special' field.
e2abe5a1 4689
e2abce01
JB
46902011-03-31 Juanma Barranquero <lekktu@gmail.com>
4691
4692 * xdisp.c (redisplay_internal): Fix prototype.
4693
63696a73 46942011-03-31 Eli Zaretskii <eliz@gnu.org>
09725d26 4695
63696a73 4696 * xdisp.c (SCROLL_LIMIT): New macro.
04f2d78b
CB
4697 (try_scrolling): Use it when setting scroll_limit.
4698 Limit scrolling to 100 screen lines.
63696a73
EZ
4699 (redisplay_window): Even when falling back on "recentering",
4700 position point in the window according to scroll-conservatively,
4701 scroll-margin, and scroll-*-aggressively variables. (Bug#6671)
4702
4703 (try_scrolling): When point is above the window, allow searching
4704 as far as scroll_max, or one screenful, to compute vertical
4705 distance from PT to the scroll margin position. This prevents
4706 try_scrolling from unnecessarily failing when
4707 scroll-conservatively is set to a value slightly larger than the
4708 window height. Clean up the case of PT below the margin at bottom
4709 of window: scroll_max can no longer be INT_MAX. When aggressive
4710 scrolling is in use, don't let point enter the opposite scroll
4711 margin as result of the scroll.
4712 (syms_of_xdisp) <scroll-conservatively>: Document the
09725d26
EZ
4713 threshold of 100 lines for never-recentering scrolling.
4714
e4cc2dfc
JB
47152011-03-31 Juanma Barranquero <lekktu@gmail.com>
4716
4717 * dispextern.h (move_it_by_lines):
4718 * xdisp.c (move_it_by_lines): Remove parameter `need_y_p', unused
4719 since 2000-12-29T14:24:09Z!gerd@gnu.org. All callers changed.
4720 (message_log_check_duplicate): Remove parameters `prev_bol' and
4721 `this_bol', unused since 1998-01-01T02:27:27Z!rms@gnu.org. All callers changed.
4722 (redisplay_internal): Remove parameter `preserve_echo_area',
4723 unused since 1999-07-21T21:43:52Z!gerd@gnu.org. All callers changed.
4724
4725 * indent.c (Fvertical_motion):
4726 * window.c (window_scroll_pixel_based, Frecenter):
4727 Don't pass `need_y_p' to `move_it_by_lines'.
4728
1c470562
SM
47292011-03-30 Stefan Monnier <monnier@iro.umontreal.ca>
4730
44f230aa
SM
4731 * eval.c (struct backtrace): Don't cheat with negative numbers, but do
4732 steal a few bits to be more compact.
4733 (interactive_p, Fbacktrace, Fbacktrace_frame, mark_backtrace):
4734 Remove unneeded casts.
4735
1c470562
SM
4736 * bytecode.c (Fbyte_code): CAR and CDR can GC.
4737
888adce9
ZK
47382011-03-30 Zachary Kanfer <zkanfer@gmail.com> (tiny change)
4739
4740 * keyboard.c (Fexecute_extended_command): Do log the "suggest key
4741 binding" message (bug#7967).
4742
f838ed7b
PE
47432011-03-30 Paul Eggert <eggert@cs.ucla.edu>
4744
77861b95
PE
4745 Fix more problems found by GCC 4.6.0's static checks.
4746
de6dbc14
PE
4747 * unexelf.c (unexec) [! (defined _SYSTYPE_SYSV || defined __sgi)]:
4748 Remove unused local var.
4749
f838ed7b
PE
4750 * editfns.c (Fmessage_box): Remove unused local var.
4751
792c7b2b
PE
4752 * xdisp.c (try_window_reusing_current_matrix, x_produce_glyphs):
4753 (note_mode_line_or_margin_highlight, note_mouse_highlight):
4754 Omit unused local vars.
c499e557 4755 * window.c (shrink_windows): Omit unused local var.
b01a1c29 4756 * menu.c (digest_single_submenu): Omit unused local var.
0bc32927
PE
4757 * dispnew.c (update_window) [PERIODIC_PREEMPTION_CHECKING]:
4758 Omit unused local var.
4759
ba0165e1
PE
4760 * keyboard.c (parse_modifiers_uncached, parse_modifiers):
4761 Don't assume string length fits in int.
32ad8845 4762 (keyremap_step, read_key_sequence): Use size_t for sizes.
48011560 4763 (read_key_sequence): Don't check last_real_key_start redundantly.
ba0165e1 4764
3c59b4c9
PE
4765 * callproc.c (Fcall_process, Fcall_process_region): Use SAFE_ALLOCA
4766 instead of alloca (Bug#8344).
4767
a3eed478 4768 * eval.c (Fbacktrace): Don't assume nargs fits in int.
5d5d959d 4769 (Fbacktrace_frame): Don't assume nframes fits in int.
a3eed478 4770
eb4d412d
PE
4771 * syntax.c (scan_sexps_forward): Avoid pointer wraparound.
4772
1658b401
PE
4773 * xterm.c (x_make_frame_visible, same_x_server): Redo to avoid overflow
4774 concerns.
4775
4776 * term.c (produce_glyphless_glyph): Remove unnecessary test.
4777
4778 * cm.c (calccost): Turn while-do into do-while, for clarity.
44f730c8 4779
9a2c6e05
PE
4780 * keyboard.c (syms_of_keyboard): Use the same style as later
4781 in this function when indexing through an array. This also
4782 works around GCC bug 48267.
4783
03d0a109
PE
4784 * image.c (tiff_load): Fix off-by-one image count (Bug#8336).
4785
44f730c8
PE
4786 * xselect.c (x_check_property_data): Return correct size (Bug#8335).
4787
fe75f926
PE
4788 * chartab.c (sub_char_table_ref_and_range): Redo for slight
4789 efficiency gain, and to bypass a gcc -Wstrict-overflow warning.
4790
ffa8c828
PE
4791 * keyboard.c, keyboard.h (num_input_events): Now size_t.
4792 This avoids undefined behavior on integer overflow, and is a bit
4793 more convenient anyway since it is compared to a size_t variable.
4794
c5101a77
PE
4795 Variadic C functions now count arguments with size_t, not int.
4796 This avoids an unnecessary limitation on 64-bit machines, which
4797 caused (substring ...) to crash on large vectors (Bug#8344).
4798 * lisp.h (struct Lisp_Subr.function.aMANY): Now takes size_t, not int.
4799 (DEFUN_ARGS_MANY, internal_condition_case_n, safe_call): Likewise.
77861b95 4800 All variadic functions and their callers changed accordingly.
c5101a77
PE
4801 (struct gcpro.nvars): Now size_t, not int. All uses changed.
4802 * data.c (arith_driver, float_arith_driver): Likewise.
4803 * editfns.c (general_insert_function): Likewise.
4804 * eval.c (struct backtrace.nargs, interactive_p)
4805 (internal_condition_case_n, run_hook_with_args, apply_lambda)
4806 (funcall_lambda, mark_backtrace): Likewise.
4807 * fns.c (concat): Likewise.
4808 * frame.c (x_set_frame_parameters): Likewise.
4809 * fns.c (get_key_arg): Now accepts and returns size_t, and returns
4810 0 if not found, not -1. All callers changed.
4811
dd3f25f7
PE
4812 * alloc.c (garbage_collect): Don't assume stack size fits in int.
4813 (stack_copy_size): Now size_t, not int.
4814 (stack_copy, stack_copy_size): Define only if MAX_SAVE_STACK > 0.
4815
461c2ab9
JB
48162011-03-28 Juanma Barranquero <lekktu@gmail.com>
4817
4818 * coding.c (encode_designation_at_bol): Remove parameter `charbuf_end',
4819 unused since 2002-03-01T01:17:24Z!handa@m17n.org and 2008-02-01T16:01:31Z!miles@gnu.org.
4820 All callers changed.
4821
4822 * lisp.h (multibyte_char_to_unibyte):
4823 * character.c (multibyte_char_to_unibyte): Remove parameter `rev_tbl',
4824 unused since 2002-03-01T01:16:34Z!handa@m17n.org and 2008-02-01T16:01:31Z!miles@gnu.org.
4825 * character.h (CHAR_TO_BYTE8):
4826 * cmds.c (internal_self_insert):
4827 * editfns.c (general_insert_function):
4828 * keymap.c (push_key_description):
4829 * search.c (Freplace_match):
4830 * xdisp.c (message_dolog, set_message_1): All callers changed.
4831
f6d62986
SM
48322011-03-28 Stefan Monnier <monnier@iro.umontreal.ca>
4833
4834 * keyboard.c (safe_run_hook_funcall): New function.
4835 (safe_run_hooks_1, safe_run_hooks_error, safe_run_hooks): On error,
4836 don't set the hook to nil, but remove the offending function instead.
4837 (Qcommand_hook_internal): Remove, unused.
4838 (syms_of_keyboard): Don't initialize Qcommand_hook_internal nor define
4839 Vcommand_hook_internal.
4840
4841 * eval.c (enum run_hooks_condition): Remove.
4842 (funcall_nil, funcall_not): New functions.
4843 (run_hook_with_args): Call each function through a `funcall' argument.
4844 Remove `cond' argument, now redundant.
4845 (Frun_hooks, Frun_hook_with_args, Frun_hook_with_args_until_success)
4846 (Frun_hook_with_args_until_failure): Adjust accordingly.
4847 (run_hook_wrapped_funcall, Frun_hook_wrapped): New functions.
4848
1db5b1ad
JB
48492011-03-28 Juanma Barranquero <lekktu@gmail.com>
4850
4851 * dispextern.h (string_buffer_position): Remove declaration.
4852
4853 * print.c (strout): Remove parameter `multibyte', unused since
4854 1999-08-21T19:30:21Z!gerd@gnu.org. All callers changed.
4855
4856 * search.c (boyer_moore): Remove parameters `len', `pos' and `lim',
4857 never used since function introduction in 1998-02-08T21:33:56Z!rms@gnu.org.
4858 All callers changed.
4859
4860 * w32.c (_wsa_errlist): Use braces for struct initializers.
4861
4862 * xdisp.c (string_buffer_position_lim): Remove parameter `w',
4863 never used since function introduction in 2001-03-09T18:41:50Z!gerd@gnu.org.
4864 All callers changed.
4865 (string_buffer_position): Likewise. Also, make static (it's never
4866 used outside xdisp.c).
4867 (cursor_row_p): Remove parameter `w', unused since
4868 2000-10-17T16:08:57Z!gerd@gnu.org. All callers changed.
4869 (decode_mode_spec): Remove parameter `precision', introduced during
4870 Gerd Moellmann's rewrite at 1999-07-21T21:43:52Z!gerd@gnu.org, but never used.
4871 All callers changed.
4872
5ffb62aa
JD
48732011-03-27 Jan Djärv <jan.h.d@swipnet.se>
4874
4875 * nsterm.m (syms_of_nsterm): Use doc: for ns-auto-hide-menu-bar.
4876
461c2ab9 48772011-03-27 Anders Lindgren <andlind@gmail.com>
f0a1382a
JD
4878
4879 * nsterm.m (ns_menu_bar_is_hidden): New variable.
4880 (ns_constrain_all_frames, ns_menu_bar_should_be_hidden)
4881 (ns_update_auto_hide_menu_bar): New functions.
4882 (ns_update_begin): Call ns_update_auto_hide_menu_bar.
4883 (applicationDidBecomeActive): Call ns_update_auto_hide_menu_bar and
4884 ns_constrain_all_frames.
4885 (constrainFrameRect): Return at once if ns_menu_bar_should_be_hidden.
4886 (syms_of_nsterm): DEFVAR ns-auto-hide-menu-bar, init to Qnil.
4887
5c380ffb
JD
48882011-03-27 Jan Djärv <jan.h.d@swipnet.se>
4889
4890 * nsmenu.m (runDialogAt): Remove argument to timer_check.
4891
9af30bdf
GM
48922011-03-27 Glenn Morris <rgm@gnu.org>
4893
4894 * syssignal.h: Replace RETSIGTYPE with void.
4895 * atimer.c, data.c, dispnew.c, emacs.c, floatfns.c, keyboard.c:
4896 * keyboard.h, lisp.h, process.c, sysdep.c, xterm.c:
4897 Replace SIGTYPE with void everywhere.
4898 * s/usg5-4-common.h (SIGTYPE): Remove definition.
4899 * s/template.h (SIGTYPE): Remove commented out definition.
4900
e2abce01
JB
49012011-03-26 Eli Zaretskii <eliz@gnu.org>
4902
4903 * xdisp.c (redisplay_window): Don't check buffer's clip_changed
4904 flag as a prerequisite for invoking try_scrolling. (Bug#6671)
4905
f868cd8a
JB
49062011-03-26 Juanma Barranquero <lekktu@gmail.com>
4907
59eb0929
JB
4908 * w32.c (read_unc_volume): Use parameter `henum', instead of
4909 global variable `wget_enum_handle'.
4910
4911 * keymap.c (describe_vector): Remove parameters `indices' and
4912 `char_table_depth', unused since 2002-03-01T01:43:26Z!handa@m17n.org.
4913 (describe_map, Fdescribe_vector): Adjust calls to `describe_vector'.
4914
f868cd8a
JB
4915 * keyboard.h (timer_check, show_help_echo): Remove unused parameters.
4916
4917 * keyboard.c (timer_check): Remove parameter `do_it_now',
4918 unused since 1996-04-12T06:01:29Z!rms@gnu.org.
4919 (show_help_echo): Remove parameter `ok_to_overwrite_keystroke_echo',
4920 unused since 2008-04-19T19:30:53Z!monnier@iro.umontreal.ca.
4921
4922 * keyboard.c (read_char):
4923 * w32menu.c (w32_menu_display_help):
4924 * xmenu.c (show_help_event, menu_help_callback):
4925 Adjust calls to `show_help_echo'.
4926
4927 * gtkutil.c (xg_maybe_add_timer):
4928 * keyboard.c (readable_events):
4929 * process.c (wait_reading_process_output):
4930 * xmenu.c (x_menu_wait_for_event): Adjust calls to `timer_check'.
4931
4932 * insdel.c (adjust_markers_gap_motion):
4933 Remove; no-op since 1998-01-02T21:29:48Z!rms@gnu.org.
4934 (gap_left, gap_right): Don't call it.
4935
2ecf6fdb
CY
49362011-03-25 Chong Yidong <cyd@stupidchicken.com>
4937
4938 * xdisp.c (handle_fontified_prop): Discard changes to clip_changed
4939 incurred during fontification.
4940
6b1f9ba4
JB
49412011-03-25 Juanma Barranquero <lekktu@gmail.com>
4942
4943 * buffer.c (defvar_per_buffer): Remove unused parameter `doc'.
4944 (DEFVAR_PER_BUFFER): Don't pass it.
4945
4946 * dispnew.c (row_equal_p, add_row_entry): Remove unused parameter `w'.
4947 (scrolling_window): Don't pass it.
4948
0f4a96b5
JB
49492011-03-25 Juanma Barranquero <lekktu@gmail.com>
4950
4951 * dispextern.h (glyph_matric): Use #if GLYPH_DEBUG, not #ifdef.
4952
4953 * fileio.c (check_executable) [DOS_NT]: Remove unused variables `len'
4954 and `suffix'.
4955 (Fset_file_selinux_context) [HAVE_LIBSELINUX]: Move here declaration
4956 of variables specific to SELinux and computation of `encoded_absname'.
4957
4958 * image.c (XPutPixel): Remove unused variable `height'.
4959
4960 * keyboard.c (make_lispy_event): Remove unused variable `hpos'.
4961
4962 * unexw32.c (get_section_info): Remove unused variable `section'.
4963
4964 * w32.c (stat): Remove unused variables `drive_root' and `devtype'.
4965 (system_process_attributes): Remove unused variable `sess'.
4966 (sys_read): Remove unused variable `err'.
4967
4968 * w32fns.c (top): Wrap variables with #if GLYPH_DEBUG, not #ifdef.
4969 (w32_wnd_proc): Remove unused variable `isdead'.
4970 (unwind_create_frame): Use #if GLYPH_DEBUG, not #ifdef.
4971 (Fx_server_max_request_size): Remove unused variable `dpyinfo'.
4972 (x_create_tip_frame): Remove unused variable `tem'.
4973
4974 * w32inevt.c (w32_console_read_socket):
4975 Remove unused variable `no_events'.
4976
4977 * w32term.c (x_draw_composite_glyph_string_foreground):
4978 Remove unused variable `width'.
4979
1149507c
JB
49802011-03-24 Juanma Barranquero <lekktu@gmail.com>
4981
4982 * w32term.c (x_set_glyph_string_clipping):
4983 Don't pass uninitialized region to CombineRgn.
4984
9c88f339
JB
49852011-03-23 Juanma Barranquero <lekktu@gmail.com>
4986
4987 * w32fns.c (x_set_menu_bar_lines): Remove unused variable `olines'.
4988 (w32_wnd_proc): Pass NULL to Windows API, not uninitialized buffer.
4989 (Fx_close_connection): Remove unused variable `i'.
4990
4991 * w32font.c (w32font_draw): Return number of glyphs.
4992 (w32font_open_internal): Remove unused variable `i'.
4993 (w32font_driver): Add missing initializer.
4994
4995 * w32menu.c (utf8to16): Remove unused variable `utf16'.
4996 (fill_in_menu): Remove unused variable `items_added'.
4997
4998 * w32term.c (last_mouse_press_frame): Remove static global variable.
4999 (w32_clip_to_row): Remove unused variable `f'.
5000 (x_delete_terminal): Remove unused variable `i'.
5001
5002 * w32uniscribe.c (uniscribe_shape): Remove unused variable `nclusters'.
5003 (NOTHING): Remove unused static global variable.
5004 (uniscribe_check_otf): Remove unused variable `table'.
5005 (uniscribe_font_driver): Add missing initializers.
5006
dee091a3
JD
50072011-03-23 Julien Danjou <julien@danjou.info>
5008
5009 * term.c (Fsuspend_tty, Fresume_tty):
5010 * minibuf.c (read_minibuf, run_exit_minibuf_hook):
5011 * window.c (temp_output_buffer_show):
5012 * insdel.c (signal_before_change):
5013 * frame.c (Fhandle_switch_frame):
5014 * fileio.c (Fdo_auto_save):
5015 * emacs.c (Fkill_emacs):
5016 * editfns.c (save_excursion_restore):
5017 * cmds.c (internal_self_insert):
5018 * callint.c (Fcall_interactively):
5019 * buffer.c (Fkill_all_local_variables):
5020 * keyboard.c (Fcommand_execute, Fsuspend_emacs, safe_run_hooks_1):
5021 Use Frun_hooks.
0f4a96b5 5022 (command_loop_1): Use Frun_hooks. Call safe_run_hooks
dee091a3
JD
5023 unconditionnaly since it does the check itself.
5024
2c520ab5 50252011-03-23 Paul Eggert <eggert@cs.ucla.edu>
f0641eff 5026
c9c49752
PE
5027 Fix more problems found by GCC 4.5.2's static checks.
5028
8abc3f12
PE
5029 * coding.c (encode_coding_raw_text): Avoid unnecessary test
5030 the first time through the loop, since we know p0 < p1 then.
5031 This also avoids a gcc -Wstrict-overflow warning.
5032
a2d26660
PE
5033 * lisp.h (SAFE_ALLOCA, SAFE_ALLOCA_LISP): Avoid 'int' overflow
5034 leading to a memory leak, possible in functions like
5035 load_charset_map_from_file that can allocate an unbounded number
b12ef411 5036 of objects (Bug#8318).
a2d26660 5037
916c72e9
PE
5038 * xmenu.c (set_frame_menubar): Use EMACS_UINT, not int, for indexes
5039 that could (at least in theory) be that large.
5040
19ab8a18
PE
5041 * xdisp.c (message_log_check_duplicate): Return unsigned long, not int.
5042 This is less likely to overflow, and avoids undefined behavior if
5043 overflow does occur. All callers changed. Use strtoul to scan
5044 for the unsigned long integer.
b7cbbd6f
PE
5045 (pint2hrstr): Simplify and tune code slightly.
5046 This also avoids a (bogus) GCC warning with gcc -Wstrict-overflow.
19ab8a18 5047
f0641eff
PE
5048 * scroll.c (do_scrolling): Work around GCC bug 48228.
5049 See <http://gcc.gnu.org/bugzilla/show_bug.cgi?id=48228>.
5050
7f650bb9
PE
5051 * frame.c (Fmodify_frame_parameters): Simplify loop counter.
5052 This also avoids a warning with gcc -Wstrict-overflow.
39f5e519
PE
5053 (validate_x_resource_name): Simplify count usage.
5054 This also avoids a warning with gcc -Wstrict-overflow.
7f650bb9 5055
37dd57d1
PE
5056 * fileio.c (Fcopy_file): Report error if fchown or fchmod
5057 fail (Bug#8306).
81e56e61 5058
699979fc 5059 * emacs.c (Fdaemon_initialized): Do not ignore I/O errors (Bug#8303).
dc1ca6a8 5060
401bf9b4
PE
5061 * process.c (Fmake_network_process): Use socklen_t, not int,
5062 where POSIX says socklen_t is required in portable programs.
5063 This fixes a porting bug on hosts like 64-bit HP-UX, where
591b2973 5064 socklen_t is wider than int (Bug#8277).
401bf9b4
PE
5065 (Fmake_network_process, server_accept_connection):
5066 (wait_reading_process_output, read_process_output):
5067 Likewise.
5068
b93aacde
PE
5069 * process.c: Rename or move locals to avoid shadowing.
5070 (list_processes_1, Fmake_network_process):
5071 (read_process_output_error_handler, exec_sentinel_error_handler):
5072 Rename or move locals.
4dc343ee 5073 (Fmake_network_process): Define label "retry_connect" only if needed.
0da49335 5074 (Fnetwork_interface_info): Fix pointer signedness.
f990b4e5 5075 (process_send_signal): Add cast to avoid pointer signedness problem.
7b808126 5076 (FIRST_PROC_DESC, IF_NON_BLOCKING_CONNECT): Remove unused macros.
c939f91b 5077 (create_process): Use 'volatile' to avoid vfork clobbering (Bug#8298).
b93aacde 5078
af8a867c 5079 Make tparam.h and terminfo.c consistent.
44f230aa
SM
5080 * cm.c (tputs, tgoto, BC, UP): Remove extern decls.
5081 Include tparam.h instead, since it declares them.
af8a867c
PE
5082 * cm.h (PC): Remove extern decl; tparam.h now does this.
5083 * deps.mk (cm.o, terminfo.o): Depend on tparam.h.
5084 * terminfo.c: Include tparam.h, to check interfaces.
5085 (tparm): Make 1st arg a const pointer in decl. Put it at top level.
5086 (tparam): Adjust signature to match interface in tparam.h;
5087 this removes some undefined behavior. Check that outstring and len
5088 are zero, which they always are with Emacs.
5089 * tparam.h (PC, BC, UP): New extern decls.
5090
0248044d 5091 * xftfont.c (xftfont_shape): Now static, and defined only if needed.
001a7ab4 5092 (xftfont_open): Rename locals to avoid shadowing.
0248044d 5093
8ff096c1 5094 * ftfont.c (ftfont_resolve_generic_family): Fix pointer signedness.
a00924bb
PE
5095 (ftfont_otf_capability, ftfont_shape): Omit decls if not needed.
5096 (OTF_TAG_SYM): Omit macro if not needed.
e932860f 5097 (ftfont_list): Remove unused local.
49eaafba
PE
5098 (get_adstyle_property, ftfont_pattern_entity):
5099 (ftfont_lookup_cache, ftfont_open, ftfont_anchor_point):
5100 Rename locals to avoid shadowing.
8ff096c1 5101
e2be39f6
PE
5102 * xfont.c (xfont_list_family): Mark var as initialized.
5103
c9735e30
PE
5104 * xml.c (make_dom): Now static.
5105
8f5201ae
PE
5106 * composite.c (composition_compute_stop_pos): Rename local to
5107 avoid shadowing.
b246f932
PE
5108 (composition_reseat_it): Remove unused locals.
5109 (find_automatic_composition, composition_adjust_point): Likewise.
80e079b2 5110 (composition_update_it): Mark var as initialized.
11b61122
PE
5111 (find_automatic_composition): Mark vars as initialized,
5112 with a FIXME (Bug#8290).
8f5201ae 5113
760fbc2c
PE
5114 character.h: Rename locals to avoid shadowing.
5115 * character.h (PREV_CHAR_BOUNDARY, FETCH_STRING_CHAR_ADVANCE):
5116 (FETCH_STRING_CHAR_AS_MULTIBYTE_ADVANCE, FETCH_CHAR_ADVANCE):
5117 (FETCH_CHAR_ADVANCE_NO_CHECK, INC_POS, DEC_POS, BUF_INC_POS):
5118 (BUF_DEC_POS): Be more systematic about renaming local temporaries
5119 to avoid shadowing.
5120
ff08eb85
PE
5121 * textprop.c (property_change_between_p): Remove; unused.
5122
fc7bf025
PE
5123 * intervals.c (interval_start_pos): Now static.
5124
235d7abc
PE
5125 * intervals.h (CHECK_TOTAL_LENGTH): Avoid empty "else".
5126
44f230aa
SM
5127 * atimer.c (start_atimer, append_atimer_lists, set_alarm):
5128 Rename locals to avoid shadowing.
3e7d6594 5129
50060332
PE
5130 * sound.c (wav_play, au_play, Fplay_sound_internal):
5131 Fix pointer signedness.
d01f234b 5132 (alsa_choose_format): Remove unused local var.
c83b8872
PE
5133 (wav_play): Initialize a variable to 0, to prevent undefined
5134 behavior (Bug#8278).
50060332 5135
c4fc4e30
PE
5136 * region-cache.c (insert_cache_boundary): Redo var to avoid shadowing.
5137
918436ed
PE
5138 * region-cache.h (pp_cache): New decl, for gcc -Wmissing-prototypes.
5139
c939f91b
PE
5140 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork
5141 clobbering (Bug#8298).
b9c7f648
PE
5142 * sysdep.c (sys_subshell): Likewise.
5143 Previously, the sys_subshell 'volatile' was incorrectly IF_LINTted out.
7e9123a2 5144
6bd8c144
PE
5145 * lisp.h (child_setup): Now NO_RETURN unless DOS_NT.
5146 This should get cleaned up, so that child_setup has the
5147 same signature on all platforms.
5148
7710357c 5149 * callproc.c (call_process_cleanup): Now static.
cb1d0ef7 5150 (relocate_fd): Rename locals to avoid shadowing.
7710357c 5151
c59da222
CY
51522011-03-22 Chong Yidong <cyd@stupidchicken.com>
5153
5154 * xterm.c (x_clear_frame): Remove XClearWindow call. This appears
5155 not to be necessary, and produces flickering.
5156
66b87493
GM
51572011-03-20 Glenn Morris <rgm@gnu.org>
5158
5159 * config.in: Remove file.
5160
45b6f6d5
JB
51612011-03-20 Juanma Barranquero <lekktu@gmail.com>
5162
5163 * minibuf.c (Vcompleting_read_function): Don't declare, global variables
5164 are now in src/globals.h.
5165 (syms_of_minibuf): Remove spurious & from previous change.
5166
3ec03f7e
LL
51672011-03-20 Leo <sdl.web@gmail.com>
5168
5169 * minibuf.c (completing-read-function): New variable.
5170 (completing-read-default): Rename from completing-read.
5171 (completing-read): Call completing-read-function.
5172
b14e3e21
CY
51732011-03-19 Juanma Barranquero <lekktu@gmail.com>
5174
5175 * xfaces.c (Fx_load_color_file):
5176 Read color file from absolute filename (bug#8250).
5177
f2b726e6
JB
51782011-03-19 Juanma Barranquero <lekktu@gmail.com>
5179
5180 * makefile.w32-in: Update dependencies.
5181
09f6ff02
EZ
51822011-03-17 Eli Zaretskii <eliz@gnu.org>
5183
5184 * makefile.w32-in ($(BLD)/unexw32.$(O)): Depend on $(SRC)/unexec.h.
5185
29a6015a
PE
51862011-03-17 Paul Eggert <eggert@cs.ucla.edu>
5187
a3a6c54e
PE
5188 Fix more problems found by GCC 4.5.2's static checks.
5189
b766f867
PE
5190 * process.c (make_serial_process_unwind, send_process_trap):
5191 (sigchld_handler): Now static.
5192
be02381c
PE
5193 * process.c (allocate_pty): Let PTY_ITERATION declare iteration vars.
5194 That way, the code declares only the vars that it needs.
5195 * s/aix4-2.h (PTY_ITERATION): Declare iteration vars.
5196 * s/cygwin.h (PTY_ITERATION): Likewise.
5197 * s/darwin.h (PTY_ITERATION): Likewise.
5198 * s/gnu-linux.h (PTY_ITERATION): Likewise.
5199
57048744
PE
5200 * s/irix6-5.h (PTY_OPEN): Declare stb, to loosen coupling.
5201 * process.c (allocate_pty): Don't declare stb unless it's needed.
5202
7914961c 5203 * bytecode.c (MAYBE_GC): Rewrite so as not to use empty "else".
615f2d59
PE
5204 (CONSTANTLIM): Remove; unused.
5205 (METER_CODE, Bscan_buffer, Bread_char, Bset_mark):
5206 Define only if needed.
7914961c 5207
b3967b18
PE
5208 * unexelf.c (unexec): Name an expression,
5209 to avoid gcc -Wbad-function-cast warning.
9ae71512
PE
5210 Use a different way to cause a compilation error if anyone uses
5211 n rather than nn, a way that does not involve shadowing.
73366a00 5212 (ELF_BSS_SECTION_NAME, OLD_PROGRAM_H): Remove; unused.
b3967b18 5213
29a6015a
PE
5214 * deps.mk (unexalpha.o): Remove; unused.
5215
43cfc33e 5216 New file unexec.h, the (simple) interface for unexec (Bug#8267).
7feda0d2 5217 * unexec.h: New file.
ce701a33
PE
5218 * deps.mk (emacs.o, unexaix.o, unexcw.o, unexcoff.o, unexelf.o):
5219 (unexhp9k800.o, unexmacosx.o, unexsol.o, unexw32.o):
5220 Depend on unexec.h.
5221 * emacs.c [!defined CANNOT_DUMP]: Include unexec.h.
5222 * unexaix.c, unexcoff.c, unexcw.c, unexelf.c, unexhp9k800.c:
5223 * unexmacosx.c, unexsol.c, unexw32.c: Include unexec.h.
381259ef 5224 Change as necessary to match prototype in unexec.h.
ce701a33 5225
01f44d5a
PE
5226 * syntax.c (Fforward_comment, scan_lists): Rename locals to avoid
5227 shadowing.
4f63c6bb 5228 (back_comment, skip_chars): Mark vars as initialized.
01f44d5a 5229
a6670b0b
PE
5230 * character.h (FETCH_STRING_CHAR_ADVANCE_NO_CHECK, BUF_INC_POS):
5231 Rename locals to avoid shadowing.
5232
cef2010d 5233 * lread.c (read1): Rewrite so as not to use empty "else".
0902fe45 5234 (Fload, readevalloop, read1): Rename locals to avoid shadowing.
cef2010d 5235
d4d7173a
PE
5236 * print.c (Fredirect_debugging_output): Fix pointer signedess.
5237
f08b802a
PE
5238 * lisp.h (debug_output_compilation_hack): Add decl here, to avoid
5239 warning when compiling print.c.
5240
3ddb0639
PE
5241 * font.c (font_unparse_fcname): Abort in an "impossible" situation
5242 instead of using an uninitialized var.
5ad03b97 5243 (font_sort_entities): Mark var as initialized.
3ddb0639 5244
170a2692
PE
5245 * character.h (FETCH_CHAR_ADVANCE): Rename locals to avoid shadowing.
5246
e663c700
PE
5247 * font.c (font_unparse_xlfd): Don't mix pointers to variables with
5248 pointers to constants.
89bc529a 5249 (font_parse_fcname): Remove unused vars.
7b81e2d0 5250 (font_delete_unmatched): Now static.
ea838e10 5251 (font_get_spec): Remove; unused.
13a547c6
PE
5252 (font_style_to_value, font_prop_validate_style, font_unparse_fcname):
5253 (font_update_drivers, Ffont_get_glyphs, font_add_log):
5254 Rename or move locals to avoid shadowing.
e663c700 5255
2a80c887 5256 * fns.c (require_nesting_list, require_unwind): Now static.
612f56df 5257 (Ffillarray): Rename locals to avoid shadowing.
2a80c887 5258
1384fa33 5259 * floatfns.c (domain_error2): Define only if needed.
a885e2ed 5260 (Ffrexp, Fldexp): Rename locals to avoid shadowing.
1384fa33 5261
8b2c52e9
PE
5262 * alloc.c (mark_backtrace): Move decl from here ...
5263 * lisp.h: ... to here, so that it can be checked.
5264
475545b5 5265 * eval.c (call_debugger, do_debug_on_call, grow_specpdl): Now static.
d28a2170 5266 (Fdefvar): Rewrite so as not to use empty "else".
cfcbfb1a
PE
5267 (lisp_indirect_variable): Name an expression,
5268 to avoid gcc -Wbad-function-cast warning.
1faed8ae 5269 (Fdefvar): Rename locals to avoid shadowing.
475545b5 5270
b1349114 5271 * callint.c (quotify_arg, quotify_args): Now static.
a3e8cbda 5272 (Fcall_interactively): Rename locals to avoid shadowing.
b0e80955 5273 Use const pointer when appropriate.
b1349114 5274
a2928364
PE
5275 * lisp.h (get_system_name, get_operating_system_release):
5276 Move decls here, to check interfaces.
5277 * process.c (get_operating_system_release): Move decl to lisp.h.
5278 * xrdb.c (get_system_name): Likewise.
63c5d10b
PE
5279 * editfns.c (init_editfns, Fuser_login_name, Fuser_uid):
5280 (Fuser_real_uid, Fuser_full_name): Remove unnecessary casts,
5281 some of which prompt warnings from gcc -Wbad-function-cast.
545b49b4
PE
5282 (Fformat_time_string, Fencode_time, Finsert_char):
5283 (Ftranslate_region_internal, Fformat):
5284 Rename or remove local vars to avoid shadowing.
9710023e 5285 (Ftranslate_region_internal): Mark var as initialized.
63c5d10b 5286
a415e694
PE
5287 * doc.c (Fdocumentation, Fsnarf_documentation): Move locals to
5288 avoid shadowing.
5289
8ef4622d
PE
5290 * lisp.h (eassert): Check that the argument compiles, even if
5291 ENABLE_CHECKING is not defined.
5292
946f9a5b
PE
5293 * data.c (Findirect_variable): Name an expression, to avoid
5294 gcc -Wbad-function-cast warning.
112396d6 5295 (default_value, arithcompare, arith_driver, arith_error): Now static.
b9b84fa9 5296 (store_symval_forwarding): Rename local to avoid shadowing.
44f230aa
SM
5297 (Fmake_variable_buffer_local, Fmake_local_variable):
5298 Mark variables as initialized.
52746918 5299 (do_blv_forwarding, do_symval_forwarding): Remove; unused.
946f9a5b 5300
e5aab7e7 5301 * alloc.c (check_cons_list): Do not define unless GC_CHECK_CONS_LIST.
ae35e756
PE
5302 (Fmake_vector, Fvector, Fmake_byte_code, Fgarbage_collect):
5303 Rename locals to avoid shadowing.
dff45157
PE
5304 (mark_stack): Move local variables into the #ifdef region where
5305 they're used.
7bc26fdb
PE
5306 (BLOCK_INPUT_ALLOC, UNBLOCK_INPUT_ALLOC): Define only if
5307 ! defined SYSTEM_MALLOC && ! defined SYNC_INPUT, as they are not
5308 needed otherwise.
5309 (CHECK_ALLOCATED): Define only if GC_CHECK_MARKED_OBJECTS.
5310 (GC_STRING_CHARS): Remove; not used.
d40d4be1 5311 (Fmemory_limit): Cast sbrk's returned value to char *.
ae35e756 5312
e5aab7e7
PE
5313 * lisp.h (check_cons_list): Declare if GC_CHECK_CONS_LIST; this
5314 avoids undefined behavior in theory.
5315
4da60324
PE
5316 * regex.c (IF_LINT): Add defn, for benefit of ../lib-src.
5317
88043301
PE
5318 Use functions, not macros, for up- and down-casing (Bug#8254).
5319 * buffer.h (DOWNCASE_TABLE, UPCASE_TABLE, DOWNCASE, UPPERCASEP):
5320 (NOCASEP, LOWERCASEP, UPCASE, UPCASE1): Remove. All callers changed
5321 to use the following functions instead of these macros.
5322 (downcase): Adjust to lack of DOWNCASE_TABLE. Return int, not
5323 EMACS_INT, since callers assume the returned value fits in int.
5324 (upcase1): Likewise, for UPCASE_TABLE.
5325 (uppercasep, lowercasep, upcase): New static inline functions.
0da09c43 5326 * editfns.c (Fchar_equal): Remove no-longer-needed workaround for
db69b0cd 5327 the race-condition problem in the old DOWNCASE.
88043301 5328
19ed5445
PE
5329 * regex.c (CHARSET_LOOKUP_RANGE_TABLE_RAW, POP_FAILURE_REG_OR_COUNT):
5330 Rename locals to avoid shadowing.
5331 (regex_compile, re_match_2_internal): Move locals to avoid shadowing.
abbd1bcf
PE
5332 (regex_compile, re_search_2, re_match_2_internal):
5333 Remove unused local vars.
952db0d7
PE
5334 (FREE_VAR): Rewrite so as not to use empty "else",
5335 which gcc can warn about.
da053e48 5336 (regex_compile, re_match_2_internal): Mark locals as initialized.
b313f9d8
PE
5337 (RETALLOC_IF): Define only if needed.
5338 (WORDCHAR_P): Likewise. This one is never needed, but is used
5339 only in a comment talking about a compiler bug, so put inside
5340 the #if 0 of that comment.
5341 (CHARSET_LOOKUP_BITMAP, FAIL_STACK_FULL, RESET_FAIL_STACK):
5342 (PUSH_FAILURE_ELT, BUF_PUSH_3, STOP_ADDR_VSTRING):
5343 Remove; unused.
19ed5445 5344
1f3561e4 5345 * search.c (boyer_moore): Rename locals to avoid shadowing.
76ef09b7
PE
5346 * character.h (FETCH_STRING_CHAR_AS_MULTIBYTE_ADVANCE):
5347 (PREV_CHAR_BOUNDARY): Likewise.
1f3561e4 5348
ded6f8f7
PE
5349 * search.c (simple_search): Remove unused var.
5350
dbd37a95
PE
5351 * dired.c (compile_pattern): Move decl from here ...
5352 * lisp.h: ... to here, so that it can be checked.
5353 (struct re_registers): New forward decl.
5354
7e47afad
PE
5355 * character.h (INC_POS, DEC_POS): Rename locals to avoid shadowing.
5356
85f24f61
PE
5357 * indent.c (MULTIBYTE_BYTES_WIDTH): New args bytes, width.
5358 All uses changed.
5359 (MULTIBYTE_BYTES_WIDTH, scan_for_column, compute_motion):
5360 Rename locals to avoid shadowing.
5671df8f 5361 (Fvertical_motion): Mark locals as initialized.
85f24f61 5362
181aa2be 5363 * casefiddle.c (casify_object, casify_region): Now static.
e45a141a 5364 (casify_region): Mark local as initialized.
181aa2be 5365
930d429c
PE
5366 * cmds.c (internal_self_insert): Rename local to avoid shadowing.
5367
7082eac6
PE
5368 * lisp.h (GCPRO2_VAR, GCPRO3_VAR, GCPRO4_VAR, GCPRO5_VAR, GCPRO6_VAR):
5369 New macros, so that the caller can use some names other than
5370 gcpro1, gcpro2, etc.
5371 (GCPRO2, GCPRO3, GCPRO4, GCPRO5, GCPRO6): Reimplement in terms
5372 of the new macros.
5373 (GCPRO1_VAR, UNGCPRO_VAR): Change the meaning of the second
5374 argument, for consistency with GCPRO2_VAR, etc: it is now the
5375 prefix of the variable, not the variable itself. All uses
5376 changed.
38b2c076
PE
5377 * dired.c (directory_files_internal, file_name_completion):
5378 Rename locals to avoid shadowing.
5379
15206ed9
PE
5380 Fix a race condition diagnosed by gcc -Wsequence-point (Bug#8254).
5381 An expression of the form (DOWNCASE (x) == DOWNCASE (y)), found in
5382 dired.c's scmp function, had undefined behavior.
5383 * lisp.h (DOWNCASE_TABLE, UPCASE_TABLE, DOWNCASE, UPPERCASEP):
5384 (NOCASEP, LOWERCASEP, UPCASE, UPCASE1): Move from here ...
5385 * buffer.h: ... to here, because these macros use current_buffer,
5386 and the new implementation with inline functions needs to have
5387 current_buffer in scope now, rather than later when the macros
5388 are used.
5389 (downcase, upcase1): New static inline functions.
5390 (DOWNCASE, UPCASE1): Reimplement using these functions.
5391 This avoids undefined behavior in expressions like
5392 DOWNCASE (x) == DOWNCASE (y), which previously suffered
5393 from race conditions in accessing the global variables
5394 case_temp1 and case_temp2.
5395 * casetab.c (case_temp1, case_temp2): Remove; no longer needed.
5396 * lisp.h (case_temp1, case_temp2): Remove their decls.
5397 * character.h (ASCII_CHAR_P): Move from here ...
5398 * lisp.h: ... to here, so that the inline functions mentioned
5399 above can use them.
5400
4a6bea26
PE
5401 * dired.c (directory_files_internal_unwind): Now static.
5402
f14b7e14
PE
5403 * fileio.c (file_name_as_directory, directory_file_name):
5404 (barf_or_query_if_file_exists, auto_save_error, auto_save_1):
5405 Now static.
2893f146
PE
5406 (file_name_as_directory): Use const pointers when appropriate.
5407 (Fexpand_file_name): Likewise. In particular, newdir might
5408 point at constant storage, so make it a const pointer.
fd4ead52 5409 (Fmake_directory_internal, Fread_file_name): Remove unused vars.
b14aac08
PE
5410 (Ffile_selinux_context, Fset_file_selinux_context): Fix pointer
5411 signedness issues.
f839df0c
PE
5412 (Fset_file_times, Finsert_file_contents, auto_save_error):
5413 Rename locals to avoid shadowing.
f14b7e14 5414
5716756e 5415 * minibuf.c (choose_minibuf_frame_1): Now static.
62137a95
PE
5416 (Ftry_completion, Fall_completions): Rename or remove locals
5417 to avoid shadowing.
5716756e 5418
b4c3046a
PE
5419 * marker.c (bytepos_to_charpos): Remove; unused.
5420
b45db522
PE
5421 * lisp.h (verify_bytepos, count_markers): New decls,
5422 so that gcc does not warn that these functions aren't declared.
5423
85876d07
PE
5424 * insdel.c (check_markers, make_gap_larger, make_gap_smaller):
5425 (reset_var_on_error, Fcombine_after_change_execute_1): Now static.
f0cb4a60 5426 (CHECK_MARKERS): Redo to avoid gcc -Wempty-body diagnostic.
40ef059e 5427 (copy_text): Remove unused local var.
85876d07 5428
03d78a21 5429 * filelock.c (within_one_second): Now static.
b3dd38ab 5430 (lock_file_1): Rename local to avoid shadowing.
03d78a21 5431
5df8f01b
PE
5432 * buffer.c (fix_overlays_before): Mark locals as initialized.
5433 (fix_start_end_in_overlays): Likewise. This function should be
5434 simplified by using pointers-to-pointers, but that's a different
5435 matter.
b1d876f1 5436 (switch_to_buffer_1): Now static.
8f54f30a
PE
5437 (Fkill_buffer, record_buffer, Fbury_buffer, Fset_buffer_multibyte):
5438 (report_overlay_modification): Rename locals to avoid shadowing.
c3bd59b5 5439
a70072c9 5440 * sysdep.c (system_process_attributes): Rename vars to avoid shadowing.
fbd02d7b 5441 Fix pointer signedness issue.
edced198
PE
5442 (sys_subshell): Mark local as volatile if checking for lint,
5443 to suppress a gcc -Wclobbered warning that does not seem to be right.
15dfd3d9 5444 (MAXPATHLEN): Define only if needed.
a70072c9 5445
a0977c44
PE
5446 * process.c (serial_open, serial_configure): Move decls from here ...
5447 * systty.h: ... to here, so that they can be checked.
5448
a884fdcc
PE
5449 * fns.c (get_random, seed_random): Move extern decls from here ...
5450 * lisp.h: ... to here, so that they can be checked.
5451
604efe86 5452 * sysdep.c (reset_io): Now static.
b8950c94 5453 (wait_for_termination_signal): Remove; unused.
604efe86 5454
38fc62d9
PE
5455 * keymap.c (keymap_parent, keymap_memberp, map_keymap_internal):
5456 (copy_keymap_item, append_key, push_text_char_description):
5457 Now static.
1004a21a 5458 (Fwhere_is_internal): Don't test CONSP (sequences) unnecessarily.
dbbb8427 5459 (DENSE_TABLE_SIZE): Remove; unused.
c1141155
PE
5460 (get_keymap, access_keymap, Fdefine_key, Fwhere_is_internal):
5461 (describe_map_tree):
5462 Rename locals to avoid shadowing.
38fc62d9 5463
2f2650da
PE
5464 * keyboard.c: Declare functions static if they are not used elsewhere.
5465 (echo_char, echo_dash, cmd_error, top_level_2):
5466 (poll_for_input, handle_async_input): Now static.
69a058fa
PE
5467 (read_char, kbd_buffer_get_event, make_lispy_position):
5468 (make_lispy_event, make_lispy_movement, apply_modifiers):
5469 (decode_keyboard_code, tty_read_avail_input, menu_bar_items):
5470 (parse_tool_bar_item, read_key_sequence, Fread_key_sequence):
5471 (Fread_key_sequence_vector): Rename locals to avoid shadowing.
c8a06054 5472 (read_key_sequence, read_char): Mark locals as initialized.
3ac94672 5473 (Fexit_recursive_edit, Fabort_recursive_edit): Mark with NO_RETURN.
2f2650da 5474
a053e86c 5475 * keyboard.h (make_ctrl_char): New decl.
da2f2dd9
PE
5476 (mark_kboards): Move decl here ...
5477 * alloc.c (mark_kboards): ... from here.
a053e86c 5478
4752793e
PE
5479 * lisp.h (force_auto_save_soon): New decl.
5480
74f10ca7 5481 * emacs.c (init_cmdargs): Rename local to avoid shadowing.
244fc23d
PE
5482 (DEFINE_DUMMY_FUNCTION): New macro.
5483 (__do_global_ctors, __do_global_ctors_aux, __do_global_dtors, __main):
5484 Use it.
c03cd23f
PE
5485 (main): Add casts to avoid warnings
5486 if GCC considers string literals to be constants.
74f10ca7 5487
022e70d4
PE
5488 * lisp.h (fatal_error_signal): Add decl, since it's exported.
5489
59d6fe83
PE
5490 * dbusbind.c: Pointer signedness fixes.
5491 (xd_signature, xd_append_arg, xd_initialize):
5492 (Fdbus_call_method, Fdbus_call_method_asynchronously):
5493 (Fdbus_method_return_internal, Fdbus_method_error_internal):
5494 (Fdbus_send_signal, xd_read_message_1, Fdbus_register_service):
5495 (Fdbus_register_signal): Use SSDATA when the context wants char *.
5496
78320123
PE
5497 * dbusbind.c (Fdbus_init_bus): Add cast to avoid warning
5498 if GCC considers string literals to be constants.
49cebcca 5499 (Fdbus_register_service, Fdbus_register_method): Remove unused vars.
78320123 5500
35ac2a97
SM
55012011-03-16 Stefan Monnier <monnier@iro.umontreal.ca>
5502
fb103ca9
SM
5503 * print.c (PRINT_CIRCLE_CANDIDATE_P): New macro.
5504 (print_preprocess, print_object): New macro to fix last change.
5505
35ac2a97
SM
5506 * print.c (print_preprocess): Don't forget font objects.
5507
62973b41
JB
55082011-03-16 Juanma Barranquero <lekktu@gmail.com>
5509
5510 * emacs.c (USAGE3): Doc fixes.
5511
0e48bb22
AS
55122011-03-15 Andreas Schwab <schwab@linux-m68k.org>
5513
5514 * coding.c (detect_coding_iso_2022): Reorganize code to clarify
5515 structure.
5516
7684e57b
JB
55172011-03-14 Juanma Barranquero <lekktu@gmail.com>
5518
5519 * lisp.h (VWindow_system, Qfile_name_history):
5520 * keyboard.h (lispy_function_keys) [WINDOWSNT]:
5521 * w32term.h (w32_system_caret_hwnd, w32_system_caret_height)
5522 (w32_system_caret_x, w32_system_caret_y): Declare extern.
5523
5524 * w32select.c: Don't #include "keyboard.h".
c96bbc66 5525 (run_protected): Add extern declaration for waiting_for_input.
7684e57b
JB
5526
5527 * w32.c (Qlocal, noninteractive1, inhibit_window_system):
5528 * w32console.c (detect_input_pending, read_input_pending)
5529 (encode_terminal_code):
5530 * w32fns.c (quit_char, lispy_function_keys, Qtooltip)
5531 (w32_system_caret_hwnd, w32_system_caret_height, w32_system_caret_x)
5532 (w32_system_caret_y, Qfile_name_history):
5533 * w32font.c (w32font_driver, QCantialias, QCotf, QClang):
5534 * w32inevt.c (reinvoke_input_signal, lispy_function_keys):
5535 * w32menu.c (Qmenu_bar, QCtoggle, QCradio, Qoverriding_local_map)
5536 (Qoverriding_terminal_local_map, Qmenu_bar_update_hook):
5537 * w32proc.c (Qlocal, report_file_error):
5538 * w32term.c (Vwindow_system, updating_frame):
5539 * w32uniscribe.c (initialized, uniscribe_font_driver):
5540 Remove unneeded extern declarations.
5541
2aa46d6c
CY
55422011-03-14 Chong Yidong <cyd@stupidchicken.com>
5543
c96bbc66 5544 * buffer.c (Fmake_indirect_buffer): Fix incorrect assertions.
2aa46d6c 5545
cffc6f3b
CY
55462011-03-13 Chong Yidong <cyd@stupidchicken.com>
5547
5548 * buffer.h (BUF_BEGV, BUF_BEGV_BYTE, BUF_ZV, BUF_ZV_BYTE, BUF_PT)
5549 (BUF_PT_BYTE): Rewrite to handle indirect buffers (Bug#8219).
5550 These macros can no longer be used for assignment.
5551
44f230aa
SM
5552 * buffer.c (Fget_buffer_create, Fmake_indirect_buffer):
5553 Assign struct members directly, instead of using BUF_BEGV etc.
cffc6f3b
CY
5554 (record_buffer_markers, fetch_buffer_markers): New functions for
5555 recording and fetching special buffer markers.
5556 (set_buffer_internal_1, set_buffer_temp): Use them.
5557
5558 * lread.c (unreadchar): Use SET_BUF_PT_BOTH.
5559
5560 * insdel.c (adjust_point): Use SET_BUF_PT_BOTH.
5561
5562 * intervals.c (temp_set_point_both): Use SET_BUF_PT_BOTH.
5563 (get_local_map): Use SET_BUF_BEGV_BOTH and SET_BUF_ZV_BOTH.
5564
5565 * xdisp.c (hscroll_window_tree):
5566 (reconsider_clip_changes): Use PT instead of BUF_PT.
5567
d251f04b
EZ
55682011-03-13 Eli Zaretskii <eliz@gnu.org>
5569
5570 * makefile.w32-in ($(BLD)/editfns.$(O)): Depend on
5571 $(EMACS_ROOT)/lib/intprops.h.
5572
f0c77cd1
PE
55732011-03-13 Paul Eggert <eggert@cs.ucla.edu>
5574
3eca4629
PE
5575 Fix more problems found by GCC 4.5.2's static checks.
5576
7c86ee98
PE
5577 * gtkutil.c (xg_get_pixbuf_from_pixmap): Add cast from char *
5578 to unsigned char * to avoid compiler diagnostic.
b0afc268
PE
5579 (xg_free_frame_widgets): Make it clear that a local variable is
5580 needed only if USE_GTK_TOOLTIP.
01e0b5ad
PE
5581 (gdk_window_get_screen): Make it clear that this macro is needed
5582 only if USE_GTK_TOOLTIP.
1e5524e7
PE
5583 (int_gtk_range_get_value): New function, which avoids a diagnostic
5584 from gcc -Wbad-function-cast.
5585 (xg_set_toolkit_scroll_bar_thumb): Use it.
5586 (xg_tool_bar_callback, xg_tool_item_stale_p): Rewrite to avoid
5587 diagnostic from gcc -Wbad-function-cast.
65dc836c
PE
5588 (get_utf8_string, xg_get_file_with_chooser):
5589 Rename locals to avoid shadowing.
5590 (create_dialog): Move locals to avoid shadowing.
7c86ee98 5591
41729b81
PE
5592 * xgselect.c (xg_select): Remove unused var.
5593
f0c77cd1
PE
5594 * image.c (four_corners_best): Mark locals as initialized.
5595 (gif_load): Initialize transparent_p to zero (Bug#8238).
5596 Mark another local as initialized.
ec6cf4c6 5597 (my_png_error, my_error_exit): Mark with NO_RETURN.
f0c77cd1 5598
ce0ad53d 5599 * image.c (clear_image_cache): Now static.
d5d5a617 5600 (DIM, HAVE_STDLIB_H_1): Remove unused macros.
e22cffbc 5601 (xpm_load): Redo to avoid "discards qualifiers" gcc warning.
77a765fd
PE
5602 (x_edge_detection): Remove unnecessary cast that
5603 gcc -Wbad-function-cast diagnoses.
2037898d 5604 (gif_load): Fix pointer signedness.
6ae141d6
PE
5605 (clear_image_cache, xbm_read_bitmap_data, x_detect_edges):
5606 (jpeg_load, gif_load): Rename locals to avoid shadowing.
ce0ad53d 5607
33383987 56082011-03-12 Paul Eggert <eggert@cs.ucla.edu>
3eca4629 5609
d32df629
PE
5610 Improve quality of tests for time stamp overflow.
5611 For example, without this patch (encode-time 0 0 0 1 1
5612 1152921504606846976) returns the obviously-bogus value (-948597
5613 62170) on my RHEL 5.5 x86-64 host. With the patch, it correctly
5614 reports time overflow. See
5615 <http://lists.gnu.org/archive/html/emacs-devel/2011-03/msg00470.html>.
b8d9bd41
PE
5616 * deps.mk (editfns.o): Depend on ../lib/intprops.h.
5617 * editfns.c: Include limits.h and intprops.h.
5618 (TIME_T_MIN, TIME_T_MAX): New macros.
5619 (time_overflow): Move earlier, to before first use.
5620 (hi_time, lo_time): New functions, for an accurate test for
5621 out-of-range times.
5622 (Fcurrent_time, Fget_internal_run_time, make_time): Use them.
5623 (Fget_internal_run_time): Don't assume time_t fits in int.
5624 (make_time): Use list2 instead of Fcons twice.
5625 (Fdecode_time): More accurate test for out-of-range times.
5626 (check_tm_member): New function.
5627 (Fencode_time): Use it, to test for out-of-range times.
d32df629
PE
5628 (lisp_time_argument): Don't rely on undefined left-shift and
5629 right-shift behavior when checking for time stamp overflow.
8be6f318 5630
fe31d94c
PE
5631 * editfns.c (time_overflow): New function, refactoring common code.
5632 (Fformat_time_string, Fdecode_time, Fencode_time):
5633 (Fcurrent_time_string): Use it.
5634
8be6f318
PE
5635 Move 'make_time' to be next to its inverse 'lisp_time_argument'.
5636 * dired.c (make_time): Move to ...
5637 * editfns.c (make_time): ... here.
5638 * systime.h: Note the move.
5639
09d9db2c 56402011-03-12 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
c47cbdfd 5641
126bc0dc
YM
5642 * fringe.c (update_window_fringes): Remove unused variables.
5643
c47cbdfd
YM
5644 * unexmacosx.c (copy_data_segment): Also copy __got section.
5645 (Bug#8223)
5646
7ac80be9
EZ
56472011-03-12 Eli Zaretskii <eliz@gnu.org>
5648
c96bbc66 5649 * termcap.c [MSDOS]: Include "msdos.h".
058e5dad
EZ
5650 (find_capability, tgetnum, tgetflag, tgetstr, tputs, tgetent):
5651 Constify `char *' arguments and their references according to
5652 prototypes in tparam.h.
5653
ecb0f94d 5654 * deps.mk (termcap.o): Depend on tparam.h and msdos.h.
058e5dad 5655
7ac80be9
EZ
5656 * msdos.c (XMenuAddPane): 3rd argument is `const char *' now.
5657 Adapt all references accordingly.
5658
5659 * msdos.h (XMenuAddPane): 3rd argument is `const char *' now.
5660
ef1fd07e
TT
56612011-03-11 Tom Tromey <tromey@redhat.com>
5662
5663 * buffer.c (syms_of_buffer): Remove obsolete comment.
5664
7ef4b50c
EZ
56652011-03-11 Eli Zaretskii <eliz@gnu.org>
5666
5667 * termhooks.h (encode_terminal_code): Declare prototype.
5668
5669 * msdos.c (encode_terminal_code): Don't declare prototype.
5670
5671 * term.c (encode_terminal_code): Now external again, used by
5672 w32console.c and msdos.c.
5673
44f230aa
SM
5674 * makefile.w32-in ($(BLD)/term.$(O), ($(BLD)/tparam.$(O)):
5675 Depend on $(SRC)/tparam.h, see 2011-03-11T07:24:21Z!eggert@cs.ucla.edu.
7ef4b50c 5676
4b1ec863 56772011-03-11 Paul Eggert <eggert@cs.ucla.edu>
f78faa98 5678
1714f52b 5679 Fix some minor problems found by GCC 4.5.2's static checks.
83316bf4 5680
4b1ec863
PE
5681 * fringe.c (update_window_fringes): Mark locals as initialized
5682 (Bug#8227).
5683 (destroy_fringe_bitmap, init_fringe_bitmap): Now static.
bf60f616 5684
524c7aa6
PE
5685 * alloc.c (mark_fringe_data): Move decl from here ...
5686 * lisp.h (mark_fringe_data) [HAVE_WINDOW_SYSTEM]: ... to here,
5687 to check its interface.
5688 (init_fringe_once): Do not declare unless HAVE_WINDOW_SYSTEM.
5689
a5c0af81 5690 * fontset.c (free_realized_fontset): Now static.
7519b8cd 5691 (Fset_fontset_font): Rename local to avoid shadowing.
cc6e5db1 5692 (fontset_font): Mark local as initialized.
a9a06e0b 5693 (FONTSET_SPEC, FONTSET_REPERTORY, RFONT_DEF_REPERTORY): Remove; unused.
a5c0af81 5694
b4716021
PE
5695 * xrdb.c: Include "xterm.h", to check x_load_resources's interface.
5696
811e9bac 5697 * xselect.c (x_disown_buffer_selections): Remove; not used.
7b83e2f1 5698 (TRACE3) [!defined TRACE_SELECTION]: Remove; not used.
aa0daa9f
PE
5699 (x_own_selection, Fx_disown_selection_internal): Rename locals
5700 to avoid shadowing.
5701 (x_handle_dnd_message): Remove local to avoid shadowing.
811e9bac 5702
7e3ab302
PE
5703 * lisp.h (GCPRO1_VAR, UNGCPRO_VAR): New macros,
5704 so that the caller can use some name other than gcpro1.
5705 (GCPRO1, UNGCPRO): Reimplement in terms of the new macros.
58d2d479
PE
5706 * xfns.c (Fx_create_frame, x_create_tip_frame, Fx_show_tip):
5707 (Fx_backspace_delete_keys_p):
5708 Use them to avoid shadowing, and rename vars to avoid shadowing.
5709 (x_decode_color, x_set_name, x_window): Now static.
6b437900 5710 (Fx_create_frame): Add braces to silence GCC warning.
c0951e53 5711 (Fx_file_dialog, Fx_select_font): Fix pointer signedness.
06b0c8a0
PE
5712 (x_real_positions, xg_set_icon_from_xpm_data, x_create_tip_frame):
5713 Remove unused locals.
7e3ab302
PE
5714 (Fx_create_frame, x_create_tip_frame, Fx_show_tip):
5715 (Fx_backspace_delete_keys_p): Rename locals to avoid shadowing.
5716 Some of these renamings use the new GCPRO1_VAR and UNGCPRO_VAR
5717 macros.
f78faa98 5718
e2b13473
PE
5719 * xterm.h (x_mouse_leave): New decl.
5720
77f23912
PE
5721 * xterm.c (x_copy_dpy_color, x_focus_on_frame, x_unfocus_frame):
5722 Remove unused functions.
cdf4ba58
PE
5723 (x_shift_glyphs_for_insert, XTflash, XTring_bell):
5724 (x_calc_absolute_position): Now static.
7411c686 5725 (XTread_socket): Don't define label "out" unless it's used.
2b07bcff 5726 Don't declare local "event" unless it's used.
ed7bf3a5
PE
5727 (x_iconify_frame, x_free_frame_resources): Don't declare locals
5728 unless they are used.
38d0b34a
PE
5729 (XEMBED_VERSION, xembed_set_info): Don't define unless needed.
5730 (x_fatal_error_signal): Remove; not used.
a6067996
PE
5731 (x_draw_image_foreground, redo_mouse_highlight, XTmouse_position):
5732 (x_scroll_bar_report_motion, handle_one_xevent, x_draw_bar_cursor):
5733 (x_error_catcher, x_connection_closed, x_error_handler):
5734 (x_error_quitter, xembed_send_message, x_iconify_frame):
5735 (my_log_handler): Rename locals to avoid shadowing.
28f1c698 5736 (x_delete_glyphs, x_ins_del_lines): Mark with NO_RETURN.
2a8fade0 5737 (x_connection_closed): Tell GCC not to suggest NO_RETURN.
77f23912 5738
44f230aa
SM
5739 * xfaces.c (clear_face_cache, Fx_list_fonts, Fface_font):
5740 Rename or move locals to avoid shadowing.
6b463e58 5741 (tty_defined_color, merge_face_heights): Now static.
5967d051 5742 (free_realized_faces_for_fontset): Remove; not used.
1e9966ea
PE
5743 (Fx_list_fonts): Mark variable that gcc -Wuninitialized
5744 does not deduce is never used uninitialized.
73719eba
PE
5745 (STRDUPA, LSTRDUPA, FONT_POINT_SIZE_QUANTUM): Remove; not used.
5746 (LFACEP): Define only if XASSERTS, as it's not needed otherwise.
071048a3 5747
426994c3 5748 * terminal.c (store_terminal_param): Now static.
5489860b 5749
032f1620 5750 * xmenu.c (menu_highlight_callback): Now static.
9d66f88e 5751 (set_frame_menubar): Remove unused local.
d4323972 5752 (xmenu_show): Rename parameter to avoid shadowing.
6d1f7fee
PE
5753 (xmenu_show, xdialog_show, xmenu_show): Make local pointers "const"
5754 since they might point to immutable storage.
281585b0
PE
5755 (next_menubar_widget_id): Declare only if USE_X_TOOLKIT,
5756 since it's unused otherwise.
032f1620 5757
367c19e5 5758 * xdisp.c (produce_glyphless_glyph): Initialize lower_xoff.
53df7c11 5759 Add a FIXME, since the code still doesn't look right. (Bug#8215)
9f36b9fd
PE
5760 (Fcurrent_bidi_paragraph_direction): Simplify slightly; this
5761 avoids a gcc -Wuninitialized diagnostic.
0e086e8f 5762 (display_line, BUILD_COMPOSITE_GLYPH_STRING, draw_glyphs):
44a3a108
PE
5763 (note_mouse_highlight): Mark variables that gcc -Wuninitialized
5764 does not deduce are never used uninitialized.
70739cbe 5765
07b48fa9
PE
5766 * lisp.h (IF_LINT): New macro, copied from ../lib-src/emacsclient.c.
5767
8868a238 5768 * xdisp.c (redisplay_window): Rename local to avoid shadowing.
4554d213
PE
5769 * window.c (window_loop, size_window):
5770 (run_window_configuration_change_hook, enlarge_window): Likewise.
8868a238 5771
7e5cf297 5772 * window.c (display_buffer): Now static.
d6550a9f
PE
5773 (size_window): Mark variables that gcc -Wuninitialized
5774 does not deduce are never used uninitialized.
a586633d
PE
5775 * window.h (check_all_windows): New decl, to forestall
5776 gcc -Wmissing-prototypes diagnostic.
5b555da1 5777 * dispextern.h (bidi_dump_cached_states): Likewise.
7e5cf297 5778
f6095868
PE
5779 * charset.h (CHECK_CHARSET_GET_CHARSET): Rename locals to avoid
5780 shadowing.
5781 * charset.c (map_charset_for_dump, Fchar_charset): Likewise.
726929c4
PE
5782 Include <limits.h>.
5783 (Fsort_charsets): Redo min/max calculation to shorten the code a bit
5784 and to avoid gcc -Wuninitialized warning.
89ef49df
PE
5785 (load_charset_map): Mark variables that gcc -Wuninitialized
5786 does not deduce are never used uninitialized.
53df7c11 5787 (load_charset): Abort instead of using uninitialized var (Bug#8229).
f6095868 5788
f38b440c
PE
5789 * coding.c (coding_set_source, coding_set_destination):
5790 Use "else { /* comment */ }" rather than "else /* comment */;"
5791 for clarity, and to avoid gcc -Wempty-body warning.
2735d060
PE
5792 (Fdefine_coding_system_internal): Don't redeclare 'i' inside
5793 a block, when the outer 'i' will do.
5794 (decode_coding_utf_8, decode_coding_utf_16, detect_coding_emacs_mule):
5795 (emacs_mule_char, decode_coding_emacs_mule, detect_coding_iso_2022):
5796 (decode_coding_iso_2022, decode_coding_sjis, decode_coding_big5):
5797 (decode_coding_raw_text, decode_coding_charset, get_translation_table):
5798 (Fdecode_sjis_char, Fdefine_coding_system_internal):
5799 Rename locals to avoid shadowing.
5800 * character.h (FETCH_STRING_CHAR_ADVANCE): Likewise.
e2f1bab9
PE
5801 * coding.c (emacs_mule_char, encode_invocation_designation):
5802 Now static, since they're not used elsewhere.
413bb2db 5803 (decode_coding_iso_2022): Add "default: abort ();" as a safety check.
c4a63b12 5804 (decode_coding_object, encode_coding_object, detect_coding_system):
ee05f961
PE
5805 (decode_coding_emacs_mule): Mark variables that gcc
5806 -Wuninitialized does not deduce are never used uninitialized.
160b01f6
PE
5807 (detect_coding_iso_2022): Initialize a local variable that might
5808 be used uninitialized. Leave a FIXME because it's not clear that
53df7c11 5809 this initialization is needed. (Bug#8211)
5f58e762
PE
5810 (ISO_CODE_LF, ISO_CODE_CR, CODING_ISO_FLAG_EUC_TW_SHIFT):
5811 (ONE_MORE_BYTE_NO_CHECK, UTF_BOM, UTF_16_INVALID_P):
5812 (SHIFT_OUT_OK, ENCODE_CONTROL_SEQUENCE_INTRODUCER):
5813 (ENCODE_DIRECTION_R2L, ENCODE_DIRECTION_L2R):
5814 Remove unused macros.
f38b440c 5815
232b38b9 5816 * category.c (hash_get_category_set): Remove unused local var.
9f3b5e69 5817 (copy_category_table): Now static, since it's not used elsewhere.
d0891610 5818 * character.c (string_count_byte8): Likewise.
232b38b9 5819
fb90da1b
PE
5820 * ccl.c (CCL_WRITE_STRING, CCL_ENCODE_CHAR, Fccl_execute_on_string):
5821 (Fregister_code_conversion_map): Rename locals to avoid shadowing.
5822
fb93dbc2
PE
5823 * chartab.c (copy_sub_char_table): Now static, since it's not used
5824 elsewhere.
5c156ace
PE
5825 (sub_char_table_ref_and_range, char_table_ref_and_range):
5826 Rename locals to avoid shadowing.
bbcd0949 5827 (ASET_RANGE, GET_SUB_CHAR_TABLE): Remove unused macros.
fb93dbc2 5828
7d3b3862 5829 * bidi.c (bidi_check_type): Now static, since it's not used elsewhere.
630d6892 5830 (BIDI_BOB): Remove unused macro.
7d3b3862 5831
6be7d3da
PE
5832 * cm.c (cmgoto): Mark variables that gcc -Wuninitialized does not
5833 deduce are never used uninitialized.
c2ed9c8b 5834 * term.c (encode_terminal_code): Likewise.
6be7d3da 5835
75f8807f 5836 * term.c (encode_terminal_code): Now static. Remove unused local.
72abad34 5837
50938595
PE
5838 * tparam.h: New file.
5839 * term.c, tparam.h: Include it.
5840 * deps.mk (term.o, tparam.o): Depend on tparam.h.
5841 * term.c (tputs, tgetent, tgetflag, tgetnum, tparam, tgetstr):
5842 Move these decls to tparam.h, and make them agree with what
5843 is actually in tparam.c. The previous trick of using incompatible
5844 decls in different modules does not conform to the C standard.
5845 All callers of tparam changed to use tparam's actual API.
5846 * tparam.c (tparam1, tparam, tgoto):
5847 Use const pointers where appropriate.
5848
fbceeba2
PE
5849 * cm.c (calccost, cmgoto): Use const pointers where appropriate.
5850 * cm.h (struct cm): Likewise.
5851 * dispextern.h (do_line_insertion_deletion_costs): Likewise.
5852 * scroll.c (ins_del_costs, do_line_insertion_deletion_costs): Likewise.
5853 * term.c (tty_ins_del_lines, calculate_costs, struct fkey_table):
5854 (term_get_fkeys_1, append_glyphless_glyph, produce_glyphless_glyph):
5855 (turn_on_face, init_tty): Likewise.
5856 * termchar.h (struct tty_display_info): Likewise.
fbceeba2 5857
7f3f1250
PE
5858 * term.c (term_mouse_position): Rename local to avoid shadowing.
5859
e6ca6543
PE
5860 * alloc.c (mark_ttys): Move decl from here ...
5861 * lisp.h (mark_ttys): ... to here, so that it's checked against defn.
5862
c40f8d15
AS
58632011-03-11 Andreas Schwab <schwab@linux-m68k.org>
5864
5865 * .gdbinit (pwinx, xbuffer): Fix access to buffer name.
5866
cfe0661d
JB
58672011-03-09 Juanma Barranquero <lekktu@gmail.com>
5868
5869 * search.c (compile_pattern_1): Remove argument regp, unused since
5870 revid:rms@gnu.org-19941211082627-3x1g1wyqkjmwloig.
5871 (compile_pattern): Don't pass it.
5872
0afb4571
J
58732011-03-08 Jan Djärv <jan.h.d@swipnet.se>
5874
5875 * xterm.h (DEFAULT_GDK_DISPLAY): New define.
5876 (GDK_WINDOW_XID, gtk_widget_get_preferred_size): New defines
5877 for ! HAVE_GTK3.
5878 (GTK_WIDGET_TO_X_WIN): Use GDK_WINDOW_XID.
5879
5880 * xmenu.c (menu_position_func): Call gtk_widget_get_preferred_size.
5881
5882 * gtkutil.c: Include gtkx.h if HAVE_GTK3. If ! HAVE_GTK3, define
5883 gdk_window_get_screen, gdk_window_get_geometry,
5884 gdk_x11_window_lookup_for_display and GDK_KEY_g.
5885 (xg_set_screen): Use DEFAULT_GDK_DISPLAY.
5886 (xg_get_pixbuf_from_pixmap): New function.
5887 (xg_get_pixbuf_from_pix_and_mask): Change parameters from GdkPixmap
5888 to Pixmap, take frame as parameter, remove GdkColormap parameter.
5889 Call xg_get_pixbuf_from_pixmap instead of
5890 gdk_pixbuf_get_from_drawable.
5891 (xg_get_image_for_pixmap): Do not make GdkPixmaps, call
5892 xg_get_pixbuf_from_pix_and_mask with Pixmap parameters instead.
5893 (xg_check_special_colors): Use GtkStyleContext and its functions
5894 for HAVE_GTK3.
5895 (xg_prepare_tooltip, xg_hide_tooltip): Call gdk_window_get_screen.
5896 (xg_prepare_tooltip, create_dialog, menubar_map_cb)
5897 (xg_update_frame_menubar, xg_tool_bar_detach_callback)
44f230aa
SM
5898 (xg_tool_bar_attach_callback, xg_update_tool_bar_sizes):
5899 Call gtk_widget_get_preferred_size.
0afb4571
J
5900 (xg_frame_resized): gdk_window_get_geometry only takes 5
5901 parameters.
44f230aa
SM
5902 (xg_win_to_widget, xg_event_is_for_menubar):
5903 Call gdk_x11_window_lookup_for_display.
0afb4571
J
5904 (xg_set_widget_bg): New function.
5905 (delete_cb): New function.
895009e1 5906 (xg_create_frame_widgets): Connect delete-event to delete_cb.
0afb4571
J
5907 Call xg_set_widget_bg. Only set backgrund pixmap for ! HAVE_GTK3
5908 (xg_set_background_color): Call xg_set_widget_bg.
5909 (xg_set_frame_icon): Call xg_get_pixbuf_from_pix_and_mask.
5910 (xg_create_scroll_bar): vadj is a GtkAdjustment for HAVE_GTK3.
5911 Only call gtk_range_set_update_policy if ! HAVE_GTK3.
5912 (xg_make_tool_item): Only connect xg_tool_bar_item_expose_callback
5913 if ! HAVE_GTK3.
5914 (update_frame_tool_bar): Call gtk_widget_hide.
5915 (xg_initialize): Use GDK_KEY_g.
5916
5917 * xsmfns.c (gdk_set_sm_client_id): Define to gdk_set_sm_client_id
5918 if ! HAVE_GTK3
5919 (x_session_initialize): Call gdk_x11_set_sm_client_id.
5920
5921 * xterm.c (XFillRectangle): Use cairo routines for HAVE_GTK3.
5922 (x_term_init): Disable Xinput(2) with GDK_CORE_DEVICE_EVENTS.
5923 Load ~/emacs.d/gtkrc only for ! HAVE_GTK3.
5924
1c2cc4ef
JB
59252011-03-08 Juanma Barranquero <lekktu@gmail.com>
5926
5927 * w32xfns.c (select_palette): Check success of RealizePalette against
5928 GDI_ERROR, not zero.
5929
33383987 5930See ChangeLog.11 for earlier changes.
aac0c6e3
MR
5931
5932;; Local Variables:
5933;; coding: utf-8
aac0c6e3
MR
5934;; End:
5935
33383987 5936 Copyright (C) 2011 Free Software Foundation, Inc.
aac0c6e3
MR
5937
5938 This file is part of GNU Emacs.
5939
5940 GNU Emacs is free software: you can redistribute it and/or modify
5941 it under the terms of the GNU General Public License as published by
5942 the Free Software Foundation, either version 3 of the License, or
5943 (at your option) any later version.
5944
5945 GNU Emacs is distributed in the hope that it will be useful,
5946 but WITHOUT ANY WARRANTY; without even the implied warranty of
5947 MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
5948 GNU General Public License for more details.
5949
5950 You should have received a copy of the GNU General Public License
5951 along with GNU Emacs. If not, see <http://www.gnu.org/licenses/>.