Remove the doprnt implementation, as Emacs now uses vsnprintf.
[bpt/emacs.git] / src / ChangeLog
CommitLineData
bff87ef0
PE
12011-04-07 Paul Eggert <eggert@cs.ucla.edu>
2
ea6c7ae6
PE
3 Remove the doprnt implementation, as Emacs now uses vsnprintf.
4 * doprnt.c: Remove.
5 * lisp.h (doprnt): Remove.
6 * Makefile.in (base_obj): Remove doprnt.o.
7 * deps.mk (doprnt.o): Remove.
8
5fdb398c
PE
9 error: Print 32- and 64-bit integers portably (Bug#8435).
10 Without this change, on typical 64-bit hosts error ("...%d...", N)
11 was used to print both 32- and 64-bit integers N, which relied on
12 undefined behavior.
13 * lisp.h, src/m/amdx86-64.h, src/m/ia64.h, src/m/ibms390x.h (pEd):
14 New macro.
15 * lisp.h (error, verror): Mark as printf-like functions.
16 * eval.c (verror): Use vsnprintf, not doprnt, to do the real work.
17 Report overflow in size calculations when allocating printf buffer.
18 Do not truncate output string at its first null byte.
19 * xdisp.c (vmessage): Use vsnprintf, not doprnt, to do the real work.
20 Truncate the output at a character boundary, since vsnprintf does not
21 do that.
22 * charset.c (check_iso_charset_parameter): Convert internal
23 character to string before calling 'error', since %c now has the
24 printf meaning.
25 * coding.c (Fdecode_sjis_char, Fdecode_big5_char): Avoid int
26 overflow when computing char to be passed to 'error'. Do not
27 pass Lisp_Object to 'error'; pass the integer instead.
28 * nsfns.m (Fns_do_applescript): Use int, not long, since it's
29 formatted with plain %d.
30
b189fa66
PE
31 * eval.c (internal_lisp_condition_case): Don't pass spurious arg.
32
bff87ef0
PE
33 * keyboard.c (access_keymap_keyremap): Print func name, not garbage.
34
79c49ad2
PE
352011-04-06 Paul Eggert <eggert@cs.ucla.edu>
36
7e2cac20
PE
37 * coding.c (Fdecode_sjis_char): Don't assume CODE fits in int.
38
ce4d90b5
PE
39 * xterm.c (x_catch_errors): Remove duplicate declaration.
40
266c9547
PE
41 * term.c (maybe_fatal): Mark its 3rd arg as a printf format, too.
42
79c49ad2
PE
43 * xdisp.c, lisp.h (message_nolog): Remove; unused.
44
973f782d
EZ
452011-04-06 Eli Zaretskii <eliz@gnu.org>
46
7c106b1e
EZ
47 * msdos.c (careadlinkat, careadlinkatcwd): MS-DOS replacements.
48
973f782d
EZ
49 * w32.c (careadlinkat, careadlinkatcwd): New always-fail stubs.
50
41cf7d1a 512011-04-06 Paul Eggert <eggert@cs.ucla.edu>
27ccc379 52
ca23cc88
PE
53 Fix more problems found by GCC 4.6.0's static checks.
54
f390e2d5
PE
55 * xmenu.c (Fx_popup_dialog): Don't assume string is free of formats.
56
42eea0d0
PE
57 * menu.c (Fx_popup_menu): Don't assume error_name lacks printf formats.
58
b69769da 59 * lisp.h (message, message_nolog, fatal): Mark as printf-like.
1e973bc7 60
f9541e84
PE
61 * xdisp.c (vmessage): Mark as a printf-like function.
62
13841b55
PE
63 * term.c (vfatal, maybe_fatal): Mark as printf-like functions.
64
c136c10f
PE
65 * sound.c (sound_warning): Don't crash if arg contains a printf format.
66
5e2d4a30
PE
67 * image.c (tiff_error_handler, tiff_warning_handler): Mark as
68 printf-like functions.
69 (tiff_load): Add casts to remove these marks before passing them
70 to system-supplied API.
71
583f48b9
PE
72 * eval.c (Fsignal): Remove excess argument to 'fatal'.
73
b25d760e
PE
74 * coding.c (EMIT_ONE_BYTE, EMIT_TWO_BYTES): Use unsigned, not int.
75 This avoids several warnings with gcc -Wstrict-overflow.
d5efd1d1
PE
76 (DECODE_COMPOSITION_RULE): If the rule is invalid, goto invalid_code
77 directly, rather than having caller test rule sign. This avoids
78 some unnecessary tests.
79 * composite.h (COMPOSITION_ENCODE_RULE_VALID): New macro.
80 (COMPOSITION_ENCODE_RULE): Arguments now must be valid. This
81 affects only one use, in DECODE_COMPOSITION_RULE, which is changed.
b25d760e 82
bc7b6697 83 * xfont.c (xfont_text_extents): Remove var that was set but not used.
625a3eb1 84 (xfont_open): Avoid unnecessary tests.
bc7b6697 85
27ccc379
PE
86 * composite.c (composition_gstring_put_cache): Use unsigned integer.
87
dcd5c89a
PE
88 * composite.h, composite.c (composition_gstring_put_cache):
89 Use EMACS_INT, not int, for length.
90
b13a45c6
PE
91 * composite.h (COMPOSITION_DECODE_REFS): New macro,
92 breaking out part of COMPOSITION_DECODE_RULE.
93 (COMPOSITION_DECODE_RULE): Use it.
94 * composite.c (get_composition_id): Remove unused local vars,
95 by using the new macro.
96
1e792e4d
PE
97 * textprop.c (set_text_properties_1): Change while to do-while,
98 since the condition is always true at first.
99
dc6c6455 100 * intervals.c (graft_intervals_into_buffer): Mark var as used.
aa86731f
PE
101 (interval_deletion_adjustment): Return unsigned value.
102 All uses changed.
dc6c6455 103
aba7731a
PE
104 * process.c (list_processes_1, create_pty, read_process_output):
105 (exec_sentinel): Remove vars that were set but not used.
afd4052b 106 (create_pty): Remove unnecessary "volatile"s.
bc57d757 107 (Fnetwork_interface_info): Avoid possibility of int overflow.
82eaa333 108 (read_process_output): Do adaptive read buffering even if carryover.
fe07cdfa 109 (read_process_output): Simplify nbytes computation if buffered.
aba7731a 110
fdfc4bf3
PE
111 * bytecode.c (exec_byte_code): Rename local to avoid shadowing.
112
fca8fe46 113 * syntax.c (scan_words): Remove var that was set but not used.
12cbf13f 114 (update_syntax_table): Use unsigned instead of int.
fca8fe46 115
06a0259a 116 * lread.c (lisp_file_lexically_bound_p): Use ints rather than endptrs.
3c346cc3 117 (lisp_file_lexically_bound_p, read1): Use unsigned instead of int.
e6eb4e9e 118 (safe_to_load_p): Make the end-of-loop test the inverse of the in-loop.
06a0259a 119
e7b9e80f
PE
120 * print.c (print_error_message): Avoid int overflow.
121
56201685
PE
122 * font.c (font_list_entities): Redo for clarity,
123 so that reader need not know FONT_DPI_INDEX + 1 == FONT_SPACING_INDEX.
124
78834453 125 * font.c (font_find_for_lface, Ffont_get_glyphs): Remove unused vars.
790771b1 126 (font_score): Avoid potential overflow in diff calculation.
78834453 127
0bc0b309 128 * fns.c (substring_both): Remove var that is set but not used.
8cd55cb4 129 (sxhash): Redo loop for clarity and to avoid wraparound warning.
0bc0b309 130
e610eaca
PE
131 * eval.c (funcall_lambda): Rename local to avoid shadowing.
132
b895abce
PE
133 * alloc.c (mark_object_loop_halt, mark_object): Use size_t, not int.
134 Otherwise, GCC 4.6.0 optimizes the loop check away since the check
135 can always succeed if overflow has undefined behavior.
136
1f1d9321 137 * search.c (boyer_moore, wordify): Remove vars set but not used.
6f076cc7 138 (wordify): Omit three unnecessary tests.
1f1d9321 139
c59478bc
PE
140 * indent.c (MULTIBYTE_BYTES_WIDTH): Don't compute wide_column.
141 All callers changed. This avoids the need for an unused var.
142
79b73827
PE
143 * casefiddle.c (casify_region): Remove var that is set but not used.
144
a4db5dfe
PE
145 * dired.c (file_name_completion): Remove var that is set but not used.
146
43aae36e
PE
147 * fileio.c (Finsert_file_contents): Make EOF condition clearer.
148
2a47c44d 149 * fileio.c (Finsert_file_contents): Avoid signed integer overflow.
163c5f32 150 (Finsert_file_contents): Remove unnecessary code checking fd.
2a47c44d 151
a37c69bf
PE
152 * minibuf.c (read_minibuf_noninteractive): Use size_t for sizes.
153 Check for integer overflow on size calculations.
154
328ab8e7
PE
155 * buffer.c (Fprevious_overlay_change): Remove var that is set
156 but not used.
157
e5a2a5cb
PE
158 * keyboard.c (menu_bar_items, read_char_minibuf_menu_prompt):
159 Remove vars that are set but not used.
8d84a6eb 160 (timer_check_2): Don't assume timer-list and idle-timer-list are lists.
6b043475 161 (timer_check_2): Mark vars as initialized.
e5a2a5cb 162
a60e5f68
PE
163 * gtkutil.c (xg_get_file_with_chooser): Mark var as initialized.
164
f661cb61 165 * image.c (lookup_image): Remove var that is set but not used.
35fa624f 166 (xbm_load): Use parse_p, for gcc -Werror=unused-but-set-variable.
f661cb61 167
f0397f5a
PE
168 * fontset.c (Finternal_char_font, Ffontset_info): Remove vars
169 that are set but not used.
170
8664db06 171 * xfns.c (make_invisible_cursor): Don't return garbage
03733ee7 172 if XCreateBitmapFromData fails (Bug#8410).
8664db06 173
6abdaa4a
PE
174 * xselect.c (x_get_local_selection, x_handle_property_notify):
175 Remove vars that are set but not used.
176
0ce7538d 177 * xfns.c (x_create_tip_frame): Remove var that is set but not used.
6abdaa4a 178 (make_invisible_cursor): Initialize a possibly-uninitialized variable.
0ce7538d 179
9ae848fc
PE
180 * xterm.c (x_scroll_bar_to_input_event) [!USE_GTK]:
181 Remove var that is set but not used.
0b918413
PE
182 (scroll_bar_windows_size): Now size_t, not int.
183 (x_send_scroll_bar_event): Use size_t, not int, for sizes.
184 Check for overflow.
9ae848fc 185
a5a62657
PE
186 * xfaces.c (realize_named_face): Remove vars that are set but not used.
187 (map_tty_color) [!defined MSDOS]: Likewise.
188
5c5cdd39
PE
189 * term.c (tty_write_glyphs): Use size_t; this avoids overflow warning.
190
66ebf983
PE
191 * coding.c: Remove vars that are set but not used.
192 (DECODE_COMPOSITION_RULE): Remove 2nd arg, which is unused.
193 All callers changed.
194 (decode_coding_utf_8, decode_coding_utf_16 decode_coding_emacs_mule):
195 (decode_coding_iso_2022, encode_coding_sjis, encode_coding_big5):
196 (decode_coding_charset): Remove vars that are set but not used.
197
1be4d761
PE
198 * bytecode.c (Fbyte_code) [!defined BYTE_CODE_SAFE]: Remove var
199 that is set but not used.
200
47553fa8
PE
201 * print.c (print_object): Remove var that is set but not used.
202
1f7196bf 203 Replace 2 copies of readlink code with 1 gnulib version (Bug#8401).
d1fdcab7
PE
204 The gnulib version avoids calling malloc in the usual case,
205 and on 64-bit hosts doesn't have some arbitrary 32-bit limits.
206 * fileio.c (Ffile_symlink_p): Use emacs_readlink.
207 * filelock.c (current_lock_owner): Likewise.
208 * lisp.h (READLINK_BUFSIZE, emacs_readlink): New function.
209 * sysdep.c: Include allocator.h, careadlinkat.h.
210 (emacs_no_realloc_allocator): New static constant.
211 (emacs_readlink): New function.
fdb61804
PE
212 * deps.mk (sysdep.o): Depend on ../lib/allocator.h and on
213 ../lib/careadlinkat.h.
d1fdcab7 214
f84c17c7
SM
2152011-04-04 Stefan Monnier <monnier@iro.umontreal.ca>
216
217 * keyboard.c (safe_run_hook_funcall): Fix last change (don't stop at the
218 first non-nil return value).
219
ef3862ad
JD
2202011-04-03 Jan Djärv <jan.h.d@swipnet.se>
221
222 * nsterm.m (ns_update_auto_hide_menu_bar): Define MAC_OS_X_VERSION_10_6
223 if not defined (Bug#8403).
224
376a7006
JB
2252011-04-02 Juanma Barranquero <lekktu@gmail.com>
226
227 * xdisp.c (display_count_lines): Remove parameter `start',
228 unused since 1998-01-01T02:27:27Z!rms@gnu.org. All callers changed.
229 (get_char_face_and_encoding): Remove parameter `multibyte_p',
230 unused since 2008-05-14T01:40:23Z!handa@m17n.org. All callers changed.
231 (fill_stretch_glyph_string): Remove parameters `row' and `area',
232 unused at least since Kim's GUI unification at 2003-03-16T20:45:46Z!storm@cua.dk
233 and thereabouts. All callers changed.
234 (get_per_char_metric): Remove parameter `f', unused since
235 2008-05-14T01:40:23Z!handa@m17n.org. All callers changed.
236
6ca3801d
JM
2372011-04-02 Jim Meyering <meyering@redhat.com>
238
239 do not dereference NULL upon failed strdup
240 * nsfont.m (ns_descriptor_to_entity): Use xstrdup, not strdup.
241 (ns_get_family): Likewise.
242
d8e2b5ba
JB
2432011-04-02 Juanma Barranquero <lekktu@gmail.com>
244
245 * eval.c (unwind_to_catch) [DEBUG_GCPRO]: Remove redundant assignment.
246
8c74fcbd
JD
2472011-04-02 Jan Djärv <jan.h.d@swipnet.se>
248
249 * nsterm.m (ns_update_auto_hide_menu_bar): Only for OSX 10.6 or
250 later (Bug#8403).
251
7200d79c
SM
2522011-04-01 Stefan Monnier <monnier@iro.umontreal.ca>
253
03408648 254 Add lexical binding.
7200d79c 255
03408648
SM
256 * window.c (Ftemp_output_buffer_show): New fun.
257 (Fsave_window_excursion):
258 * print.c (Fwith_output_to_temp_buffer): Move to subr.el.
259
260 * lread.c (lisp_file_lexically_bound_p): New function.
261 (Fload): Bind Qlexical_binding.
262 (readevalloop): Remove `evalfun' arg.
263 Bind Qinternal_interpreter_environment.
264 (Feval_buffer): Bind Qlexical_binding.
265 (defvar_int, defvar_bool, defvar_lisp_nopro, defvar_kboard):
266 Mark as dynamic.
267 (syms_of_lread): Declare `lexical-binding'.
268
269 * lisp.h (struct Lisp_Symbol): New field `declared_special'.
270
271 * keyboard.c (eval_dyn): New fun.
272 (menu_item_eval_property): Use it.
ca105506
SM
273
274 * image.c (parse_image_spec): Use Ffunctionp.
ca105506 275
03408648
SM
276 * fns.c (concat, mapcar1): Accept byte-code-functions.
277
278 * eval.c (Fsetq): Handle lexical vars.
279 (Fdefun, Fdefmacro, Ffunction): Make closures when needed.
280 (Fdefconst, Fdefvaralias, Fdefvar): Mark as dynamic.
281 (FletX, Flet): Obey lexical binding.
282 (Fcommandp): Handle closures.
283 (Feval): New `lexical' arg.
284 (eval_sub): New function extracted from Feval. Use it almost
285 everywhere where Feval was used. Look up vars in lexical env.
286 Handle closures.
287 (Ffunctionp): Move from subr.el.
288 (Ffuncall): Handle closures.
289 (apply_lambda): Remove `eval_flags'.
290 (funcall_lambda): Handle closures and new byte-code-functions.
291 (Fspecial_variable_p): New function.
292 (syms_of_eval): Initialize the Vinternal_interpreter_environment var,
293 but without exporting it to Lisp.
23aba0ea 294
23aba0ea 295 * doc.c (Fdocumentation, store_function_docstring):
03408648 296 * data.c (Finteractive_form): Handle closures.
23aba0ea 297
03408648
SM
298 * callint.c (Fcall_interactively): Preserve lexical-binding mode for
299 interactive spec.
ba83908c 300
03408648
SM
301 * bytecode.c (Bstack_ref, Bstack_set, Bstack_set2, BdiscardN): New
302 byte-codes.
303 (exec_byte_code): New function extracted from Fbyte_code to handle new
304 calling convention for byte-code-functions. Add new byte-codes.
ba83908c 305
03408648 306 * buffer.c (defvar_per_buffer): Set new `declared_special' field.
e2abe5a1 307
03408648 308 * alloc.c (Fmake_symbol): Init new `declared_special' field.
e2abe5a1 309
e2abce01
JB
3102011-03-31 Juanma Barranquero <lekktu@gmail.com>
311
312 * xdisp.c (redisplay_internal): Fix prototype.
313
63696a73 3142011-03-31 Eli Zaretskii <eliz@gnu.org>
09725d26 315
63696a73
EZ
316 * xdisp.c (SCROLL_LIMIT): New macro.
317 (try_scrolling): Use it when setting scroll_limit. Limit
318 scrolling to 100 screen lines.
319 (redisplay_window): Even when falling back on "recentering",
320 position point in the window according to scroll-conservatively,
321 scroll-margin, and scroll-*-aggressively variables. (Bug#6671)
322
323 (try_scrolling): When point is above the window, allow searching
324 as far as scroll_max, or one screenful, to compute vertical
325 distance from PT to the scroll margin position. This prevents
326 try_scrolling from unnecessarily failing when
327 scroll-conservatively is set to a value slightly larger than the
328 window height. Clean up the case of PT below the margin at bottom
329 of window: scroll_max can no longer be INT_MAX. When aggressive
330 scrolling is in use, don't let point enter the opposite scroll
331 margin as result of the scroll.
332 (syms_of_xdisp) <scroll-conservatively>: Document the
09725d26
EZ
333 threshold of 100 lines for never-recentering scrolling.
334
e4cc2dfc
JB
3352011-03-31 Juanma Barranquero <lekktu@gmail.com>
336
337 * dispextern.h (move_it_by_lines):
338 * xdisp.c (move_it_by_lines): Remove parameter `need_y_p', unused
339 since 2000-12-29T14:24:09Z!gerd@gnu.org. All callers changed.
340 (message_log_check_duplicate): Remove parameters `prev_bol' and
341 `this_bol', unused since 1998-01-01T02:27:27Z!rms@gnu.org. All callers changed.
342 (redisplay_internal): Remove parameter `preserve_echo_area',
343 unused since 1999-07-21T21:43:52Z!gerd@gnu.org. All callers changed.
344
345 * indent.c (Fvertical_motion):
346 * window.c (window_scroll_pixel_based, Frecenter):
347 Don't pass `need_y_p' to `move_it_by_lines'.
348
1c470562
SM
3492011-03-30 Stefan Monnier <monnier@iro.umontreal.ca>
350
44f230aa
SM
351 * eval.c (struct backtrace): Don't cheat with negative numbers, but do
352 steal a few bits to be more compact.
353 (interactive_p, Fbacktrace, Fbacktrace_frame, mark_backtrace):
354 Remove unneeded casts.
355
1c470562
SM
356 * bytecode.c (Fbyte_code): CAR and CDR can GC.
357
888adce9
ZK
3582011-03-30 Zachary Kanfer <zkanfer@gmail.com> (tiny change)
359
360 * keyboard.c (Fexecute_extended_command): Do log the "suggest key
361 binding" message (bug#7967).
362
f838ed7b
PE
3632011-03-30 Paul Eggert <eggert@cs.ucla.edu>
364
77861b95
PE
365 Fix more problems found by GCC 4.6.0's static checks.
366
de6dbc14
PE
367 * unexelf.c (unexec) [! (defined _SYSTYPE_SYSV || defined __sgi)]:
368 Remove unused local var.
369
f838ed7b
PE
370 * editfns.c (Fmessage_box): Remove unused local var.
371
792c7b2b
PE
372 * xdisp.c (try_window_reusing_current_matrix, x_produce_glyphs):
373 (note_mode_line_or_margin_highlight, note_mouse_highlight):
374 Omit unused local vars.
c499e557 375 * window.c (shrink_windows): Omit unused local var.
b01a1c29 376 * menu.c (digest_single_submenu): Omit unused local var.
0bc32927
PE
377 * dispnew.c (update_window) [PERIODIC_PREEMPTION_CHECKING]:
378 Omit unused local var.
379
ba0165e1
PE
380 * keyboard.c (parse_modifiers_uncached, parse_modifiers):
381 Don't assume string length fits in int.
32ad8845 382 (keyremap_step, read_key_sequence): Use size_t for sizes.
48011560 383 (read_key_sequence): Don't check last_real_key_start redundantly.
ba0165e1 384
3c59b4c9
PE
385 * callproc.c (Fcall_process, Fcall_process_region): Use SAFE_ALLOCA
386 instead of alloca (Bug#8344).
387
a3eed478 388 * eval.c (Fbacktrace): Don't assume nargs fits in int.
5d5d959d 389 (Fbacktrace_frame): Don't assume nframes fits in int.
a3eed478 390
eb4d412d
PE
391 * syntax.c (scan_sexps_forward): Avoid pointer wraparound.
392
1658b401
PE
393 * xterm.c (x_make_frame_visible, same_x_server): Redo to avoid overflow
394 concerns.
395
396 * term.c (produce_glyphless_glyph): Remove unnecessary test.
397
398 * cm.c (calccost): Turn while-do into do-while, for clarity.
44f730c8 399
9a2c6e05
PE
400 * keyboard.c (syms_of_keyboard): Use the same style as later
401 in this function when indexing through an array. This also
402 works around GCC bug 48267.
403
03d0a109
PE
404 * image.c (tiff_load): Fix off-by-one image count (Bug#8336).
405
44f730c8
PE
406 * xselect.c (x_check_property_data): Return correct size (Bug#8335).
407
fe75f926
PE
408 * chartab.c (sub_char_table_ref_and_range): Redo for slight
409 efficiency gain, and to bypass a gcc -Wstrict-overflow warning.
410
ffa8c828
PE
411 * keyboard.c, keyboard.h (num_input_events): Now size_t.
412 This avoids undefined behavior on integer overflow, and is a bit
413 more convenient anyway since it is compared to a size_t variable.
414
c5101a77
PE
415 Variadic C functions now count arguments with size_t, not int.
416 This avoids an unnecessary limitation on 64-bit machines, which
417 caused (substring ...) to crash on large vectors (Bug#8344).
418 * lisp.h (struct Lisp_Subr.function.aMANY): Now takes size_t, not int.
419 (DEFUN_ARGS_MANY, internal_condition_case_n, safe_call): Likewise.
77861b95 420 All variadic functions and their callers changed accordingly.
c5101a77
PE
421 (struct gcpro.nvars): Now size_t, not int. All uses changed.
422 * data.c (arith_driver, float_arith_driver): Likewise.
423 * editfns.c (general_insert_function): Likewise.
424 * eval.c (struct backtrace.nargs, interactive_p)
425 (internal_condition_case_n, run_hook_with_args, apply_lambda)
426 (funcall_lambda, mark_backtrace): Likewise.
427 * fns.c (concat): Likewise.
428 * frame.c (x_set_frame_parameters): Likewise.
429 * fns.c (get_key_arg): Now accepts and returns size_t, and returns
430 0 if not found, not -1. All callers changed.
431
dd3f25f7
PE
432 * alloc.c (garbage_collect): Don't assume stack size fits in int.
433 (stack_copy_size): Now size_t, not int.
434 (stack_copy, stack_copy_size): Define only if MAX_SAVE_STACK > 0.
435
461c2ab9
JB
4362011-03-28 Juanma Barranquero <lekktu@gmail.com>
437
438 * coding.c (encode_designation_at_bol): Remove parameter `charbuf_end',
439 unused since 2002-03-01T01:17:24Z!handa@m17n.org and 2008-02-01T16:01:31Z!miles@gnu.org.
440 All callers changed.
441
442 * lisp.h (multibyte_char_to_unibyte):
443 * character.c (multibyte_char_to_unibyte): Remove parameter `rev_tbl',
444 unused since 2002-03-01T01:16:34Z!handa@m17n.org and 2008-02-01T16:01:31Z!miles@gnu.org.
445 * character.h (CHAR_TO_BYTE8):
446 * cmds.c (internal_self_insert):
447 * editfns.c (general_insert_function):
448 * keymap.c (push_key_description):
449 * search.c (Freplace_match):
450 * xdisp.c (message_dolog, set_message_1): All callers changed.
451
f6d62986
SM
4522011-03-28 Stefan Monnier <monnier@iro.umontreal.ca>
453
454 * keyboard.c (safe_run_hook_funcall): New function.
455 (safe_run_hooks_1, safe_run_hooks_error, safe_run_hooks): On error,
456 don't set the hook to nil, but remove the offending function instead.
457 (Qcommand_hook_internal): Remove, unused.
458 (syms_of_keyboard): Don't initialize Qcommand_hook_internal nor define
459 Vcommand_hook_internal.
460
461 * eval.c (enum run_hooks_condition): Remove.
462 (funcall_nil, funcall_not): New functions.
463 (run_hook_with_args): Call each function through a `funcall' argument.
464 Remove `cond' argument, now redundant.
465 (Frun_hooks, Frun_hook_with_args, Frun_hook_with_args_until_success)
466 (Frun_hook_with_args_until_failure): Adjust accordingly.
467 (run_hook_wrapped_funcall, Frun_hook_wrapped): New functions.
468
1db5b1ad
JB
4692011-03-28 Juanma Barranquero <lekktu@gmail.com>
470
471 * dispextern.h (string_buffer_position): Remove declaration.
472
473 * print.c (strout): Remove parameter `multibyte', unused since
474 1999-08-21T19:30:21Z!gerd@gnu.org. All callers changed.
475
476 * search.c (boyer_moore): Remove parameters `len', `pos' and `lim',
477 never used since function introduction in 1998-02-08T21:33:56Z!rms@gnu.org.
478 All callers changed.
479
480 * w32.c (_wsa_errlist): Use braces for struct initializers.
481
482 * xdisp.c (string_buffer_position_lim): Remove parameter `w',
483 never used since function introduction in 2001-03-09T18:41:50Z!gerd@gnu.org.
484 All callers changed.
485 (string_buffer_position): Likewise. Also, make static (it's never
486 used outside xdisp.c).
487 (cursor_row_p): Remove parameter `w', unused since
488 2000-10-17T16:08:57Z!gerd@gnu.org. All callers changed.
489 (decode_mode_spec): Remove parameter `precision', introduced during
490 Gerd Moellmann's rewrite at 1999-07-21T21:43:52Z!gerd@gnu.org, but never used.
491 All callers changed.
492
5ffb62aa
JD
4932011-03-27 Jan Djärv <jan.h.d@swipnet.se>
494
495 * nsterm.m (syms_of_nsterm): Use doc: for ns-auto-hide-menu-bar.
496
461c2ab9 4972011-03-27 Anders Lindgren <andlind@gmail.com>
f0a1382a
JD
498
499 * nsterm.m (ns_menu_bar_is_hidden): New variable.
500 (ns_constrain_all_frames, ns_menu_bar_should_be_hidden)
501 (ns_update_auto_hide_menu_bar): New functions.
502 (ns_update_begin): Call ns_update_auto_hide_menu_bar.
503 (applicationDidBecomeActive): Call ns_update_auto_hide_menu_bar and
504 ns_constrain_all_frames.
505 (constrainFrameRect): Return at once if ns_menu_bar_should_be_hidden.
506 (syms_of_nsterm): DEFVAR ns-auto-hide-menu-bar, init to Qnil.
507
5c380ffb
JD
5082011-03-27 Jan Djärv <jan.h.d@swipnet.se>
509
510 * nsmenu.m (runDialogAt): Remove argument to timer_check.
511
9af30bdf
GM
5122011-03-27 Glenn Morris <rgm@gnu.org>
513
514 * syssignal.h: Replace RETSIGTYPE with void.
515 * atimer.c, data.c, dispnew.c, emacs.c, floatfns.c, keyboard.c:
516 * keyboard.h, lisp.h, process.c, sysdep.c, xterm.c:
517 Replace SIGTYPE with void everywhere.
518 * s/usg5-4-common.h (SIGTYPE): Remove definition.
519 * s/template.h (SIGTYPE): Remove commented out definition.
520
e2abce01
JB
5212011-03-26 Eli Zaretskii <eliz@gnu.org>
522
523 * xdisp.c (redisplay_window): Don't check buffer's clip_changed
524 flag as a prerequisite for invoking try_scrolling. (Bug#6671)
525
f868cd8a
JB
5262011-03-26 Juanma Barranquero <lekktu@gmail.com>
527
59eb0929
JB
528 * w32.c (read_unc_volume): Use parameter `henum', instead of
529 global variable `wget_enum_handle'.
530
531 * keymap.c (describe_vector): Remove parameters `indices' and
532 `char_table_depth', unused since 2002-03-01T01:43:26Z!handa@m17n.org.
533 (describe_map, Fdescribe_vector): Adjust calls to `describe_vector'.
534
f868cd8a
JB
535 * keyboard.h (timer_check, show_help_echo): Remove unused parameters.
536
537 * keyboard.c (timer_check): Remove parameter `do_it_now',
538 unused since 1996-04-12T06:01:29Z!rms@gnu.org.
539 (show_help_echo): Remove parameter `ok_to_overwrite_keystroke_echo',
540 unused since 2008-04-19T19:30:53Z!monnier@iro.umontreal.ca.
541
542 * keyboard.c (read_char):
543 * w32menu.c (w32_menu_display_help):
544 * xmenu.c (show_help_event, menu_help_callback):
545 Adjust calls to `show_help_echo'.
546
547 * gtkutil.c (xg_maybe_add_timer):
548 * keyboard.c (readable_events):
549 * process.c (wait_reading_process_output):
550 * xmenu.c (x_menu_wait_for_event): Adjust calls to `timer_check'.
551
552 * insdel.c (adjust_markers_gap_motion):
553 Remove; no-op since 1998-01-02T21:29:48Z!rms@gnu.org.
554 (gap_left, gap_right): Don't call it.
555
2ecf6fdb
CY
5562011-03-25 Chong Yidong <cyd@stupidchicken.com>
557
558 * xdisp.c (handle_fontified_prop): Discard changes to clip_changed
559 incurred during fontification.
560
6b1f9ba4
JB
5612011-03-25 Juanma Barranquero <lekktu@gmail.com>
562
563 * buffer.c (defvar_per_buffer): Remove unused parameter `doc'.
564 (DEFVAR_PER_BUFFER): Don't pass it.
565
566 * dispnew.c (row_equal_p, add_row_entry): Remove unused parameter `w'.
567 (scrolling_window): Don't pass it.
568
0f4a96b5
JB
5692011-03-25 Juanma Barranquero <lekktu@gmail.com>
570
571 * dispextern.h (glyph_matric): Use #if GLYPH_DEBUG, not #ifdef.
572
573 * fileio.c (check_executable) [DOS_NT]: Remove unused variables `len'
574 and `suffix'.
575 (Fset_file_selinux_context) [HAVE_LIBSELINUX]: Move here declaration
576 of variables specific to SELinux and computation of `encoded_absname'.
577
578 * image.c (XPutPixel): Remove unused variable `height'.
579
580 * keyboard.c (make_lispy_event): Remove unused variable `hpos'.
581
582 * unexw32.c (get_section_info): Remove unused variable `section'.
583
584 * w32.c (stat): Remove unused variables `drive_root' and `devtype'.
585 (system_process_attributes): Remove unused variable `sess'.
586 (sys_read): Remove unused variable `err'.
587
588 * w32fns.c (top): Wrap variables with #if GLYPH_DEBUG, not #ifdef.
589 (w32_wnd_proc): Remove unused variable `isdead'.
590 (unwind_create_frame): Use #if GLYPH_DEBUG, not #ifdef.
591 (Fx_server_max_request_size): Remove unused variable `dpyinfo'.
592 (x_create_tip_frame): Remove unused variable `tem'.
593
594 * w32inevt.c (w32_console_read_socket):
595 Remove unused variable `no_events'.
596
597 * w32term.c (x_draw_composite_glyph_string_foreground):
598 Remove unused variable `width'.
599
1149507c
JB
6002011-03-24 Juanma Barranquero <lekktu@gmail.com>
601
602 * w32term.c (x_set_glyph_string_clipping):
603 Don't pass uninitialized region to CombineRgn.
604
9c88f339
JB
6052011-03-23 Juanma Barranquero <lekktu@gmail.com>
606
607 * w32fns.c (x_set_menu_bar_lines): Remove unused variable `olines'.
608 (w32_wnd_proc): Pass NULL to Windows API, not uninitialized buffer.
609 (Fx_close_connection): Remove unused variable `i'.
610
611 * w32font.c (w32font_draw): Return number of glyphs.
612 (w32font_open_internal): Remove unused variable `i'.
613 (w32font_driver): Add missing initializer.
614
615 * w32menu.c (utf8to16): Remove unused variable `utf16'.
616 (fill_in_menu): Remove unused variable `items_added'.
617
618 * w32term.c (last_mouse_press_frame): Remove static global variable.
619 (w32_clip_to_row): Remove unused variable `f'.
620 (x_delete_terminal): Remove unused variable `i'.
621
622 * w32uniscribe.c (uniscribe_shape): Remove unused variable `nclusters'.
623 (NOTHING): Remove unused static global variable.
624 (uniscribe_check_otf): Remove unused variable `table'.
625 (uniscribe_font_driver): Add missing initializers.
626
dee091a3
JD
6272011-03-23 Julien Danjou <julien@danjou.info>
628
629 * term.c (Fsuspend_tty, Fresume_tty):
630 * minibuf.c (read_minibuf, run_exit_minibuf_hook):
631 * window.c (temp_output_buffer_show):
632 * insdel.c (signal_before_change):
633 * frame.c (Fhandle_switch_frame):
634 * fileio.c (Fdo_auto_save):
635 * emacs.c (Fkill_emacs):
636 * editfns.c (save_excursion_restore):
637 * cmds.c (internal_self_insert):
638 * callint.c (Fcall_interactively):
639 * buffer.c (Fkill_all_local_variables):
640 * keyboard.c (Fcommand_execute, Fsuspend_emacs, safe_run_hooks_1):
641 Use Frun_hooks.
0f4a96b5 642 (command_loop_1): Use Frun_hooks. Call safe_run_hooks
dee091a3
JD
643 unconditionnaly since it does the check itself.
644
2c520ab5 6452011-03-23 Paul Eggert <eggert@cs.ucla.edu>
f0641eff 646
c9c49752
PE
647 Fix more problems found by GCC 4.5.2's static checks.
648
8abc3f12
PE
649 * coding.c (encode_coding_raw_text): Avoid unnecessary test
650 the first time through the loop, since we know p0 < p1 then.
651 This also avoids a gcc -Wstrict-overflow warning.
652
a2d26660
PE
653 * lisp.h (SAFE_ALLOCA, SAFE_ALLOCA_LISP): Avoid 'int' overflow
654 leading to a memory leak, possible in functions like
655 load_charset_map_from_file that can allocate an unbounded number
b12ef411 656 of objects (Bug#8318).
a2d26660 657
916c72e9
PE
658 * xmenu.c (set_frame_menubar): Use EMACS_UINT, not int, for indexes
659 that could (at least in theory) be that large.
660
19ab8a18
PE
661 * xdisp.c (message_log_check_duplicate): Return unsigned long, not int.
662 This is less likely to overflow, and avoids undefined behavior if
663 overflow does occur. All callers changed. Use strtoul to scan
664 for the unsigned long integer.
b7cbbd6f
PE
665 (pint2hrstr): Simplify and tune code slightly.
666 This also avoids a (bogus) GCC warning with gcc -Wstrict-overflow.
19ab8a18 667
f0641eff
PE
668 * scroll.c (do_scrolling): Work around GCC bug 48228.
669 See <http://gcc.gnu.org/bugzilla/show_bug.cgi?id=48228>.
670
7f650bb9
PE
671 * frame.c (Fmodify_frame_parameters): Simplify loop counter.
672 This also avoids a warning with gcc -Wstrict-overflow.
39f5e519
PE
673 (validate_x_resource_name): Simplify count usage.
674 This also avoids a warning with gcc -Wstrict-overflow.
7f650bb9 675
37dd57d1
PE
676 * fileio.c (Fcopy_file): Report error if fchown or fchmod
677 fail (Bug#8306).
81e56e61 678
699979fc 679 * emacs.c (Fdaemon_initialized): Do not ignore I/O errors (Bug#8303).
dc1ca6a8 680
401bf9b4
PE
681 * process.c (Fmake_network_process): Use socklen_t, not int,
682 where POSIX says socklen_t is required in portable programs.
683 This fixes a porting bug on hosts like 64-bit HP-UX, where
591b2973 684 socklen_t is wider than int (Bug#8277).
401bf9b4
PE
685 (Fmake_network_process, server_accept_connection):
686 (wait_reading_process_output, read_process_output):
687 Likewise.
688
b93aacde
PE
689 * process.c: Rename or move locals to avoid shadowing.
690 (list_processes_1, Fmake_network_process):
691 (read_process_output_error_handler, exec_sentinel_error_handler):
692 Rename or move locals.
4dc343ee 693 (Fmake_network_process): Define label "retry_connect" only if needed.
0da49335 694 (Fnetwork_interface_info): Fix pointer signedness.
f990b4e5 695 (process_send_signal): Add cast to avoid pointer signedness problem.
7b808126 696 (FIRST_PROC_DESC, IF_NON_BLOCKING_CONNECT): Remove unused macros.
c939f91b 697 (create_process): Use 'volatile' to avoid vfork clobbering (Bug#8298).
b93aacde 698
af8a867c 699 Make tparam.h and terminfo.c consistent.
44f230aa
SM
700 * cm.c (tputs, tgoto, BC, UP): Remove extern decls.
701 Include tparam.h instead, since it declares them.
af8a867c
PE
702 * cm.h (PC): Remove extern decl; tparam.h now does this.
703 * deps.mk (cm.o, terminfo.o): Depend on tparam.h.
704 * terminfo.c: Include tparam.h, to check interfaces.
705 (tparm): Make 1st arg a const pointer in decl. Put it at top level.
706 (tparam): Adjust signature to match interface in tparam.h;
707 this removes some undefined behavior. Check that outstring and len
708 are zero, which they always are with Emacs.
709 * tparam.h (PC, BC, UP): New extern decls.
710
0248044d 711 * xftfont.c (xftfont_shape): Now static, and defined only if needed.
001a7ab4 712 (xftfont_open): Rename locals to avoid shadowing.
0248044d 713
8ff096c1 714 * ftfont.c (ftfont_resolve_generic_family): Fix pointer signedness.
a00924bb
PE
715 (ftfont_otf_capability, ftfont_shape): Omit decls if not needed.
716 (OTF_TAG_SYM): Omit macro if not needed.
e932860f 717 (ftfont_list): Remove unused local.
49eaafba
PE
718 (get_adstyle_property, ftfont_pattern_entity):
719 (ftfont_lookup_cache, ftfont_open, ftfont_anchor_point):
720 Rename locals to avoid shadowing.
8ff096c1 721
e2be39f6
PE
722 * xfont.c (xfont_list_family): Mark var as initialized.
723
c9735e30
PE
724 * xml.c (make_dom): Now static.
725
8f5201ae
PE
726 * composite.c (composition_compute_stop_pos): Rename local to
727 avoid shadowing.
b246f932
PE
728 (composition_reseat_it): Remove unused locals.
729 (find_automatic_composition, composition_adjust_point): Likewise.
80e079b2 730 (composition_update_it): Mark var as initialized.
11b61122
PE
731 (find_automatic_composition): Mark vars as initialized,
732 with a FIXME (Bug#8290).
8f5201ae 733
760fbc2c
PE
734 character.h: Rename locals to avoid shadowing.
735 * character.h (PREV_CHAR_BOUNDARY, FETCH_STRING_CHAR_ADVANCE):
736 (FETCH_STRING_CHAR_AS_MULTIBYTE_ADVANCE, FETCH_CHAR_ADVANCE):
737 (FETCH_CHAR_ADVANCE_NO_CHECK, INC_POS, DEC_POS, BUF_INC_POS):
738 (BUF_DEC_POS): Be more systematic about renaming local temporaries
739 to avoid shadowing.
740
ff08eb85
PE
741 * textprop.c (property_change_between_p): Remove; unused.
742
fc7bf025
PE
743 * intervals.c (interval_start_pos): Now static.
744
235d7abc
PE
745 * intervals.h (CHECK_TOTAL_LENGTH): Avoid empty "else".
746
44f230aa
SM
747 * atimer.c (start_atimer, append_atimer_lists, set_alarm):
748 Rename locals to avoid shadowing.
3e7d6594 749
50060332
PE
750 * sound.c (wav_play, au_play, Fplay_sound_internal):
751 Fix pointer signedness.
d01f234b 752 (alsa_choose_format): Remove unused local var.
c83b8872
PE
753 (wav_play): Initialize a variable to 0, to prevent undefined
754 behavior (Bug#8278).
50060332 755
c4fc4e30
PE
756 * region-cache.c (insert_cache_boundary): Redo var to avoid shadowing.
757
918436ed
PE
758 * region-cache.h (pp_cache): New decl, for gcc -Wmissing-prototypes.
759
c939f91b
PE
760 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork
761 clobbering (Bug#8298).
b9c7f648
PE
762 * sysdep.c (sys_subshell): Likewise.
763 Previously, the sys_subshell 'volatile' was incorrectly IF_LINTted out.
7e9123a2 764
6bd8c144
PE
765 * lisp.h (child_setup): Now NO_RETURN unless DOS_NT.
766 This should get cleaned up, so that child_setup has the
767 same signature on all platforms.
768
7710357c 769 * callproc.c (call_process_cleanup): Now static.
cb1d0ef7 770 (relocate_fd): Rename locals to avoid shadowing.
7710357c 771
c59da222
CY
7722011-03-22 Chong Yidong <cyd@stupidchicken.com>
773
774 * xterm.c (x_clear_frame): Remove XClearWindow call. This appears
775 not to be necessary, and produces flickering.
776
66b87493
GM
7772011-03-20 Glenn Morris <rgm@gnu.org>
778
779 * config.in: Remove file.
780
45b6f6d5
JB
7812011-03-20 Juanma Barranquero <lekktu@gmail.com>
782
783 * minibuf.c (Vcompleting_read_function): Don't declare, global variables
784 are now in src/globals.h.
785 (syms_of_minibuf): Remove spurious & from previous change.
786
3ec03f7e
LL
7872011-03-20 Leo <sdl.web@gmail.com>
788
789 * minibuf.c (completing-read-function): New variable.
790 (completing-read-default): Rename from completing-read.
791 (completing-read): Call completing-read-function.
792
b14e3e21
CY
7932011-03-19 Juanma Barranquero <lekktu@gmail.com>
794
795 * xfaces.c (Fx_load_color_file):
796 Read color file from absolute filename (bug#8250).
797
f2b726e6
JB
7982011-03-19 Juanma Barranquero <lekktu@gmail.com>
799
800 * makefile.w32-in: Update dependencies.
801
09f6ff02
EZ
8022011-03-17 Eli Zaretskii <eliz@gnu.org>
803
804 * makefile.w32-in ($(BLD)/unexw32.$(O)): Depend on $(SRC)/unexec.h.
805
29a6015a
PE
8062011-03-17 Paul Eggert <eggert@cs.ucla.edu>
807
a3a6c54e
PE
808 Fix more problems found by GCC 4.5.2's static checks.
809
b766f867
PE
810 * process.c (make_serial_process_unwind, send_process_trap):
811 (sigchld_handler): Now static.
812
be02381c
PE
813 * process.c (allocate_pty): Let PTY_ITERATION declare iteration vars.
814 That way, the code declares only the vars that it needs.
815 * s/aix4-2.h (PTY_ITERATION): Declare iteration vars.
816 * s/cygwin.h (PTY_ITERATION): Likewise.
817 * s/darwin.h (PTY_ITERATION): Likewise.
818 * s/gnu-linux.h (PTY_ITERATION): Likewise.
819
57048744
PE
820 * s/irix6-5.h (PTY_OPEN): Declare stb, to loosen coupling.
821 * process.c (allocate_pty): Don't declare stb unless it's needed.
822
7914961c 823 * bytecode.c (MAYBE_GC): Rewrite so as not to use empty "else".
615f2d59
PE
824 (CONSTANTLIM): Remove; unused.
825 (METER_CODE, Bscan_buffer, Bread_char, Bset_mark):
826 Define only if needed.
7914961c 827
b3967b18
PE
828 * unexelf.c (unexec): Name an expression,
829 to avoid gcc -Wbad-function-cast warning.
9ae71512
PE
830 Use a different way to cause a compilation error if anyone uses
831 n rather than nn, a way that does not involve shadowing.
73366a00 832 (ELF_BSS_SECTION_NAME, OLD_PROGRAM_H): Remove; unused.
b3967b18 833
29a6015a
PE
834 * deps.mk (unexalpha.o): Remove; unused.
835
43cfc33e 836 New file unexec.h, the (simple) interface for unexec (Bug#8267).
7feda0d2 837 * unexec.h: New file.
ce701a33
PE
838 * deps.mk (emacs.o, unexaix.o, unexcw.o, unexcoff.o, unexelf.o):
839 (unexhp9k800.o, unexmacosx.o, unexsol.o, unexw32.o):
840 Depend on unexec.h.
841 * emacs.c [!defined CANNOT_DUMP]: Include unexec.h.
842 * unexaix.c, unexcoff.c, unexcw.c, unexelf.c, unexhp9k800.c:
843 * unexmacosx.c, unexsol.c, unexw32.c: Include unexec.h.
381259ef 844 Change as necessary to match prototype in unexec.h.
ce701a33 845
01f44d5a
PE
846 * syntax.c (Fforward_comment, scan_lists): Rename locals to avoid
847 shadowing.
4f63c6bb 848 (back_comment, skip_chars): Mark vars as initialized.
01f44d5a 849
a6670b0b
PE
850 * character.h (FETCH_STRING_CHAR_ADVANCE_NO_CHECK, BUF_INC_POS):
851 Rename locals to avoid shadowing.
852
cef2010d 853 * lread.c (read1): Rewrite so as not to use empty "else".
0902fe45 854 (Fload, readevalloop, read1): Rename locals to avoid shadowing.
cef2010d 855
d4d7173a
PE
856 * print.c (Fredirect_debugging_output): Fix pointer signedess.
857
f08b802a
PE
858 * lisp.h (debug_output_compilation_hack): Add decl here, to avoid
859 warning when compiling print.c.
860
3ddb0639
PE
861 * font.c (font_unparse_fcname): Abort in an "impossible" situation
862 instead of using an uninitialized var.
5ad03b97 863 (font_sort_entities): Mark var as initialized.
3ddb0639 864
170a2692
PE
865 * character.h (FETCH_CHAR_ADVANCE): Rename locals to avoid shadowing.
866
e663c700
PE
867 * font.c (font_unparse_xlfd): Don't mix pointers to variables with
868 pointers to constants.
89bc529a 869 (font_parse_fcname): Remove unused vars.
7b81e2d0 870 (font_delete_unmatched): Now static.
ea838e10 871 (font_get_spec): Remove; unused.
13a547c6
PE
872 (font_style_to_value, font_prop_validate_style, font_unparse_fcname):
873 (font_update_drivers, Ffont_get_glyphs, font_add_log):
874 Rename or move locals to avoid shadowing.
e663c700 875
2a80c887 876 * fns.c (require_nesting_list, require_unwind): Now static.
612f56df 877 (Ffillarray): Rename locals to avoid shadowing.
2a80c887 878
1384fa33 879 * floatfns.c (domain_error2): Define only if needed.
a885e2ed 880 (Ffrexp, Fldexp): Rename locals to avoid shadowing.
1384fa33 881
8b2c52e9
PE
882 * alloc.c (mark_backtrace): Move decl from here ...
883 * lisp.h: ... to here, so that it can be checked.
884
475545b5 885 * eval.c (call_debugger, do_debug_on_call, grow_specpdl): Now static.
d28a2170 886 (Fdefvar): Rewrite so as not to use empty "else".
cfcbfb1a
PE
887 (lisp_indirect_variable): Name an expression,
888 to avoid gcc -Wbad-function-cast warning.
1faed8ae 889 (Fdefvar): Rename locals to avoid shadowing.
475545b5 890
b1349114 891 * callint.c (quotify_arg, quotify_args): Now static.
a3e8cbda 892 (Fcall_interactively): Rename locals to avoid shadowing.
b0e80955 893 Use const pointer when appropriate.
b1349114 894
a2928364
PE
895 * lisp.h (get_system_name, get_operating_system_release):
896 Move decls here, to check interfaces.
897 * process.c (get_operating_system_release): Move decl to lisp.h.
898 * xrdb.c (get_system_name): Likewise.
63c5d10b
PE
899 * editfns.c (init_editfns, Fuser_login_name, Fuser_uid):
900 (Fuser_real_uid, Fuser_full_name): Remove unnecessary casts,
901 some of which prompt warnings from gcc -Wbad-function-cast.
545b49b4
PE
902 (Fformat_time_string, Fencode_time, Finsert_char):
903 (Ftranslate_region_internal, Fformat):
904 Rename or remove local vars to avoid shadowing.
9710023e 905 (Ftranslate_region_internal): Mark var as initialized.
63c5d10b 906
a415e694
PE
907 * doc.c (Fdocumentation, Fsnarf_documentation): Move locals to
908 avoid shadowing.
909
8ef4622d
PE
910 * lisp.h (eassert): Check that the argument compiles, even if
911 ENABLE_CHECKING is not defined.
912
946f9a5b
PE
913 * data.c (Findirect_variable): Name an expression, to avoid
914 gcc -Wbad-function-cast warning.
112396d6 915 (default_value, arithcompare, arith_driver, arith_error): Now static.
b9b84fa9 916 (store_symval_forwarding): Rename local to avoid shadowing.
44f230aa
SM
917 (Fmake_variable_buffer_local, Fmake_local_variable):
918 Mark variables as initialized.
52746918 919 (do_blv_forwarding, do_symval_forwarding): Remove; unused.
946f9a5b 920
e5aab7e7 921 * alloc.c (check_cons_list): Do not define unless GC_CHECK_CONS_LIST.
ae35e756
PE
922 (Fmake_vector, Fvector, Fmake_byte_code, Fgarbage_collect):
923 Rename locals to avoid shadowing.
dff45157
PE
924 (mark_stack): Move local variables into the #ifdef region where
925 they're used.
7bc26fdb
PE
926 (BLOCK_INPUT_ALLOC, UNBLOCK_INPUT_ALLOC): Define only if
927 ! defined SYSTEM_MALLOC && ! defined SYNC_INPUT, as they are not
928 needed otherwise.
929 (CHECK_ALLOCATED): Define only if GC_CHECK_MARKED_OBJECTS.
930 (GC_STRING_CHARS): Remove; not used.
d40d4be1 931 (Fmemory_limit): Cast sbrk's returned value to char *.
ae35e756 932
e5aab7e7
PE
933 * lisp.h (check_cons_list): Declare if GC_CHECK_CONS_LIST; this
934 avoids undefined behavior in theory.
935
4da60324
PE
936 * regex.c (IF_LINT): Add defn, for benefit of ../lib-src.
937
88043301
PE
938 Use functions, not macros, for up- and down-casing (Bug#8254).
939 * buffer.h (DOWNCASE_TABLE, UPCASE_TABLE, DOWNCASE, UPPERCASEP):
940 (NOCASEP, LOWERCASEP, UPCASE, UPCASE1): Remove. All callers changed
941 to use the following functions instead of these macros.
942 (downcase): Adjust to lack of DOWNCASE_TABLE. Return int, not
943 EMACS_INT, since callers assume the returned value fits in int.
944 (upcase1): Likewise, for UPCASE_TABLE.
945 (uppercasep, lowercasep, upcase): New static inline functions.
0da09c43 946 * editfns.c (Fchar_equal): Remove no-longer-needed workaround for
db69b0cd 947 the race-condition problem in the old DOWNCASE.
88043301 948
19ed5445
PE
949 * regex.c (CHARSET_LOOKUP_RANGE_TABLE_RAW, POP_FAILURE_REG_OR_COUNT):
950 Rename locals to avoid shadowing.
951 (regex_compile, re_match_2_internal): Move locals to avoid shadowing.
abbd1bcf
PE
952 (regex_compile, re_search_2, re_match_2_internal):
953 Remove unused local vars.
952db0d7
PE
954 (FREE_VAR): Rewrite so as not to use empty "else",
955 which gcc can warn about.
da053e48 956 (regex_compile, re_match_2_internal): Mark locals as initialized.
b313f9d8
PE
957 (RETALLOC_IF): Define only if needed.
958 (WORDCHAR_P): Likewise. This one is never needed, but is used
959 only in a comment talking about a compiler bug, so put inside
960 the #if 0 of that comment.
961 (CHARSET_LOOKUP_BITMAP, FAIL_STACK_FULL, RESET_FAIL_STACK):
962 (PUSH_FAILURE_ELT, BUF_PUSH_3, STOP_ADDR_VSTRING):
963 Remove; unused.
19ed5445 964
1f3561e4 965 * search.c (boyer_moore): Rename locals to avoid shadowing.
76ef09b7
PE
966 * character.h (FETCH_STRING_CHAR_AS_MULTIBYTE_ADVANCE):
967 (PREV_CHAR_BOUNDARY): Likewise.
1f3561e4 968
ded6f8f7
PE
969 * search.c (simple_search): Remove unused var.
970
dbd37a95
PE
971 * dired.c (compile_pattern): Move decl from here ...
972 * lisp.h: ... to here, so that it can be checked.
973 (struct re_registers): New forward decl.
974
7e47afad
PE
975 * character.h (INC_POS, DEC_POS): Rename locals to avoid shadowing.
976
85f24f61
PE
977 * indent.c (MULTIBYTE_BYTES_WIDTH): New args bytes, width.
978 All uses changed.
979 (MULTIBYTE_BYTES_WIDTH, scan_for_column, compute_motion):
980 Rename locals to avoid shadowing.
5671df8f 981 (Fvertical_motion): Mark locals as initialized.
85f24f61 982
181aa2be 983 * casefiddle.c (casify_object, casify_region): Now static.
e45a141a 984 (casify_region): Mark local as initialized.
181aa2be 985
930d429c
PE
986 * cmds.c (internal_self_insert): Rename local to avoid shadowing.
987
7082eac6
PE
988 * lisp.h (GCPRO2_VAR, GCPRO3_VAR, GCPRO4_VAR, GCPRO5_VAR, GCPRO6_VAR):
989 New macros, so that the caller can use some names other than
990 gcpro1, gcpro2, etc.
991 (GCPRO2, GCPRO3, GCPRO4, GCPRO5, GCPRO6): Reimplement in terms
992 of the new macros.
993 (GCPRO1_VAR, UNGCPRO_VAR): Change the meaning of the second
994 argument, for consistency with GCPRO2_VAR, etc: it is now the
995 prefix of the variable, not the variable itself. All uses
996 changed.
38b2c076
PE
997 * dired.c (directory_files_internal, file_name_completion):
998 Rename locals to avoid shadowing.
999
15206ed9
PE
1000 Fix a race condition diagnosed by gcc -Wsequence-point (Bug#8254).
1001 An expression of the form (DOWNCASE (x) == DOWNCASE (y)), found in
1002 dired.c's scmp function, had undefined behavior.
1003 * lisp.h (DOWNCASE_TABLE, UPCASE_TABLE, DOWNCASE, UPPERCASEP):
1004 (NOCASEP, LOWERCASEP, UPCASE, UPCASE1): Move from here ...
1005 * buffer.h: ... to here, because these macros use current_buffer,
1006 and the new implementation with inline functions needs to have
1007 current_buffer in scope now, rather than later when the macros
1008 are used.
1009 (downcase, upcase1): New static inline functions.
1010 (DOWNCASE, UPCASE1): Reimplement using these functions.
1011 This avoids undefined behavior in expressions like
1012 DOWNCASE (x) == DOWNCASE (y), which previously suffered
1013 from race conditions in accessing the global variables
1014 case_temp1 and case_temp2.
1015 * casetab.c (case_temp1, case_temp2): Remove; no longer needed.
1016 * lisp.h (case_temp1, case_temp2): Remove their decls.
1017 * character.h (ASCII_CHAR_P): Move from here ...
1018 * lisp.h: ... to here, so that the inline functions mentioned
1019 above can use them.
1020
4a6bea26
PE
1021 * dired.c (directory_files_internal_unwind): Now static.
1022
f14b7e14
PE
1023 * fileio.c (file_name_as_directory, directory_file_name):
1024 (barf_or_query_if_file_exists, auto_save_error, auto_save_1):
1025 Now static.
2893f146
PE
1026 (file_name_as_directory): Use const pointers when appropriate.
1027 (Fexpand_file_name): Likewise. In particular, newdir might
1028 point at constant storage, so make it a const pointer.
fd4ead52 1029 (Fmake_directory_internal, Fread_file_name): Remove unused vars.
b14aac08
PE
1030 (Ffile_selinux_context, Fset_file_selinux_context): Fix pointer
1031 signedness issues.
f839df0c
PE
1032 (Fset_file_times, Finsert_file_contents, auto_save_error):
1033 Rename locals to avoid shadowing.
f14b7e14 1034
5716756e 1035 * minibuf.c (choose_minibuf_frame_1): Now static.
62137a95
PE
1036 (Ftry_completion, Fall_completions): Rename or remove locals
1037 to avoid shadowing.
5716756e 1038
b4c3046a
PE
1039 * marker.c (bytepos_to_charpos): Remove; unused.
1040
b45db522
PE
1041 * lisp.h (verify_bytepos, count_markers): New decls,
1042 so that gcc does not warn that these functions aren't declared.
1043
85876d07
PE
1044 * insdel.c (check_markers, make_gap_larger, make_gap_smaller):
1045 (reset_var_on_error, Fcombine_after_change_execute_1): Now static.
f0cb4a60 1046 (CHECK_MARKERS): Redo to avoid gcc -Wempty-body diagnostic.
40ef059e 1047 (copy_text): Remove unused local var.
85876d07 1048
03d78a21 1049 * filelock.c (within_one_second): Now static.
b3dd38ab 1050 (lock_file_1): Rename local to avoid shadowing.
03d78a21 1051
5df8f01b
PE
1052 * buffer.c (fix_overlays_before): Mark locals as initialized.
1053 (fix_start_end_in_overlays): Likewise. This function should be
1054 simplified by using pointers-to-pointers, but that's a different
1055 matter.
b1d876f1 1056 (switch_to_buffer_1): Now static.
8f54f30a
PE
1057 (Fkill_buffer, record_buffer, Fbury_buffer, Fset_buffer_multibyte):
1058 (report_overlay_modification): Rename locals to avoid shadowing.
c3bd59b5 1059
a70072c9 1060 * sysdep.c (system_process_attributes): Rename vars to avoid shadowing.
fbd02d7b 1061 Fix pointer signedness issue.
edced198
PE
1062 (sys_subshell): Mark local as volatile if checking for lint,
1063 to suppress a gcc -Wclobbered warning that does not seem to be right.
15dfd3d9 1064 (MAXPATHLEN): Define only if needed.
a70072c9 1065
a0977c44
PE
1066 * process.c (serial_open, serial_configure): Move decls from here ...
1067 * systty.h: ... to here, so that they can be checked.
1068
a884fdcc
PE
1069 * fns.c (get_random, seed_random): Move extern decls from here ...
1070 * lisp.h: ... to here, so that they can be checked.
1071
604efe86 1072 * sysdep.c (reset_io): Now static.
b8950c94 1073 (wait_for_termination_signal): Remove; unused.
604efe86 1074
38fc62d9
PE
1075 * keymap.c (keymap_parent, keymap_memberp, map_keymap_internal):
1076 (copy_keymap_item, append_key, push_text_char_description):
1077 Now static.
1004a21a 1078 (Fwhere_is_internal): Don't test CONSP (sequences) unnecessarily.
dbbb8427 1079 (DENSE_TABLE_SIZE): Remove; unused.
c1141155
PE
1080 (get_keymap, access_keymap, Fdefine_key, Fwhere_is_internal):
1081 (describe_map_tree):
1082 Rename locals to avoid shadowing.
38fc62d9 1083
2f2650da
PE
1084 * keyboard.c: Declare functions static if they are not used elsewhere.
1085 (echo_char, echo_dash, cmd_error, top_level_2):
1086 (poll_for_input, handle_async_input): Now static.
69a058fa
PE
1087 (read_char, kbd_buffer_get_event, make_lispy_position):
1088 (make_lispy_event, make_lispy_movement, apply_modifiers):
1089 (decode_keyboard_code, tty_read_avail_input, menu_bar_items):
1090 (parse_tool_bar_item, read_key_sequence, Fread_key_sequence):
1091 (Fread_key_sequence_vector): Rename locals to avoid shadowing.
c8a06054 1092 (read_key_sequence, read_char): Mark locals as initialized.
3ac94672 1093 (Fexit_recursive_edit, Fabort_recursive_edit): Mark with NO_RETURN.
2f2650da 1094
a053e86c 1095 * keyboard.h (make_ctrl_char): New decl.
da2f2dd9
PE
1096 (mark_kboards): Move decl here ...
1097 * alloc.c (mark_kboards): ... from here.
a053e86c 1098
4752793e
PE
1099 * lisp.h (force_auto_save_soon): New decl.
1100
74f10ca7 1101 * emacs.c (init_cmdargs): Rename local to avoid shadowing.
244fc23d
PE
1102 (DEFINE_DUMMY_FUNCTION): New macro.
1103 (__do_global_ctors, __do_global_ctors_aux, __do_global_dtors, __main):
1104 Use it.
c03cd23f
PE
1105 (main): Add casts to avoid warnings
1106 if GCC considers string literals to be constants.
74f10ca7 1107
022e70d4
PE
1108 * lisp.h (fatal_error_signal): Add decl, since it's exported.
1109
59d6fe83
PE
1110 * dbusbind.c: Pointer signedness fixes.
1111 (xd_signature, xd_append_arg, xd_initialize):
1112 (Fdbus_call_method, Fdbus_call_method_asynchronously):
1113 (Fdbus_method_return_internal, Fdbus_method_error_internal):
1114 (Fdbus_send_signal, xd_read_message_1, Fdbus_register_service):
1115 (Fdbus_register_signal): Use SSDATA when the context wants char *.
1116
78320123
PE
1117 * dbusbind.c (Fdbus_init_bus): Add cast to avoid warning
1118 if GCC considers string literals to be constants.
49cebcca 1119 (Fdbus_register_service, Fdbus_register_method): Remove unused vars.
78320123 1120
35ac2a97
SM
11212011-03-16 Stefan Monnier <monnier@iro.umontreal.ca>
1122
fb103ca9
SM
1123 * print.c (PRINT_CIRCLE_CANDIDATE_P): New macro.
1124 (print_preprocess, print_object): New macro to fix last change.
1125
35ac2a97
SM
1126 * print.c (print_preprocess): Don't forget font objects.
1127
62973b41
JB
11282011-03-16 Juanma Barranquero <lekktu@gmail.com>
1129
1130 * emacs.c (USAGE3): Doc fixes.
1131
0e48bb22
AS
11322011-03-15 Andreas Schwab <schwab@linux-m68k.org>
1133
1134 * coding.c (detect_coding_iso_2022): Reorganize code to clarify
1135 structure.
1136
7684e57b
JB
11372011-03-14 Juanma Barranquero <lekktu@gmail.com>
1138
1139 * lisp.h (VWindow_system, Qfile_name_history):
1140 * keyboard.h (lispy_function_keys) [WINDOWSNT]:
1141 * w32term.h (w32_system_caret_hwnd, w32_system_caret_height)
1142 (w32_system_caret_x, w32_system_caret_y): Declare extern.
1143
1144 * w32select.c: Don't #include "keyboard.h".
c96bbc66 1145 (run_protected): Add extern declaration for waiting_for_input.
7684e57b
JB
1146
1147 * w32.c (Qlocal, noninteractive1, inhibit_window_system):
1148 * w32console.c (detect_input_pending, read_input_pending)
1149 (encode_terminal_code):
1150 * w32fns.c (quit_char, lispy_function_keys, Qtooltip)
1151 (w32_system_caret_hwnd, w32_system_caret_height, w32_system_caret_x)
1152 (w32_system_caret_y, Qfile_name_history):
1153 * w32font.c (w32font_driver, QCantialias, QCotf, QClang):
1154 * w32inevt.c (reinvoke_input_signal, lispy_function_keys):
1155 * w32menu.c (Qmenu_bar, QCtoggle, QCradio, Qoverriding_local_map)
1156 (Qoverriding_terminal_local_map, Qmenu_bar_update_hook):
1157 * w32proc.c (Qlocal, report_file_error):
1158 * w32term.c (Vwindow_system, updating_frame):
1159 * w32uniscribe.c (initialized, uniscribe_font_driver):
1160 Remove unneeded extern declarations.
1161
2aa46d6c
CY
11622011-03-14 Chong Yidong <cyd@stupidchicken.com>
1163
c96bbc66 1164 * buffer.c (Fmake_indirect_buffer): Fix incorrect assertions.
2aa46d6c 1165
cffc6f3b
CY
11662011-03-13 Chong Yidong <cyd@stupidchicken.com>
1167
1168 * buffer.h (BUF_BEGV, BUF_BEGV_BYTE, BUF_ZV, BUF_ZV_BYTE, BUF_PT)
1169 (BUF_PT_BYTE): Rewrite to handle indirect buffers (Bug#8219).
1170 These macros can no longer be used for assignment.
1171
44f230aa
SM
1172 * buffer.c (Fget_buffer_create, Fmake_indirect_buffer):
1173 Assign struct members directly, instead of using BUF_BEGV etc.
cffc6f3b
CY
1174 (record_buffer_markers, fetch_buffer_markers): New functions for
1175 recording and fetching special buffer markers.
1176 (set_buffer_internal_1, set_buffer_temp): Use them.
1177
1178 * lread.c (unreadchar): Use SET_BUF_PT_BOTH.
1179
1180 * insdel.c (adjust_point): Use SET_BUF_PT_BOTH.
1181
1182 * intervals.c (temp_set_point_both): Use SET_BUF_PT_BOTH.
1183 (get_local_map): Use SET_BUF_BEGV_BOTH and SET_BUF_ZV_BOTH.
1184
1185 * xdisp.c (hscroll_window_tree):
1186 (reconsider_clip_changes): Use PT instead of BUF_PT.
1187
d251f04b
EZ
11882011-03-13 Eli Zaretskii <eliz@gnu.org>
1189
1190 * makefile.w32-in ($(BLD)/editfns.$(O)): Depend on
1191 $(EMACS_ROOT)/lib/intprops.h.
1192
f0c77cd1
PE
11932011-03-13 Paul Eggert <eggert@cs.ucla.edu>
1194
3eca4629
PE
1195 Fix more problems found by GCC 4.5.2's static checks.
1196
7c86ee98
PE
1197 * gtkutil.c (xg_get_pixbuf_from_pixmap): Add cast from char *
1198 to unsigned char * to avoid compiler diagnostic.
b0afc268
PE
1199 (xg_free_frame_widgets): Make it clear that a local variable is
1200 needed only if USE_GTK_TOOLTIP.
01e0b5ad
PE
1201 (gdk_window_get_screen): Make it clear that this macro is needed
1202 only if USE_GTK_TOOLTIP.
1e5524e7
PE
1203 (int_gtk_range_get_value): New function, which avoids a diagnostic
1204 from gcc -Wbad-function-cast.
1205 (xg_set_toolkit_scroll_bar_thumb): Use it.
1206 (xg_tool_bar_callback, xg_tool_item_stale_p): Rewrite to avoid
1207 diagnostic from gcc -Wbad-function-cast.
65dc836c
PE
1208 (get_utf8_string, xg_get_file_with_chooser):
1209 Rename locals to avoid shadowing.
1210 (create_dialog): Move locals to avoid shadowing.
7c86ee98 1211
41729b81
PE
1212 * xgselect.c (xg_select): Remove unused var.
1213
f0c77cd1
PE
1214 * image.c (four_corners_best): Mark locals as initialized.
1215 (gif_load): Initialize transparent_p to zero (Bug#8238).
1216 Mark another local as initialized.
ec6cf4c6 1217 (my_png_error, my_error_exit): Mark with NO_RETURN.
f0c77cd1 1218
ce0ad53d 1219 * image.c (clear_image_cache): Now static.
d5d5a617 1220 (DIM, HAVE_STDLIB_H_1): Remove unused macros.
e22cffbc 1221 (xpm_load): Redo to avoid "discards qualifiers" gcc warning.
77a765fd
PE
1222 (x_edge_detection): Remove unnecessary cast that
1223 gcc -Wbad-function-cast diagnoses.
2037898d 1224 (gif_load): Fix pointer signedness.
6ae141d6
PE
1225 (clear_image_cache, xbm_read_bitmap_data, x_detect_edges):
1226 (jpeg_load, gif_load): Rename locals to avoid shadowing.
ce0ad53d 1227
33383987 12282011-03-12 Paul Eggert <eggert@cs.ucla.edu>
3eca4629 1229
d32df629
PE
1230 Improve quality of tests for time stamp overflow.
1231 For example, without this patch (encode-time 0 0 0 1 1
1232 1152921504606846976) returns the obviously-bogus value (-948597
1233 62170) on my RHEL 5.5 x86-64 host. With the patch, it correctly
1234 reports time overflow. See
1235 <http://lists.gnu.org/archive/html/emacs-devel/2011-03/msg00470.html>.
b8d9bd41
PE
1236 * deps.mk (editfns.o): Depend on ../lib/intprops.h.
1237 * editfns.c: Include limits.h and intprops.h.
1238 (TIME_T_MIN, TIME_T_MAX): New macros.
1239 (time_overflow): Move earlier, to before first use.
1240 (hi_time, lo_time): New functions, for an accurate test for
1241 out-of-range times.
1242 (Fcurrent_time, Fget_internal_run_time, make_time): Use them.
1243 (Fget_internal_run_time): Don't assume time_t fits in int.
1244 (make_time): Use list2 instead of Fcons twice.
1245 (Fdecode_time): More accurate test for out-of-range times.
1246 (check_tm_member): New function.
1247 (Fencode_time): Use it, to test for out-of-range times.
d32df629
PE
1248 (lisp_time_argument): Don't rely on undefined left-shift and
1249 right-shift behavior when checking for time stamp overflow.
8be6f318 1250
fe31d94c
PE
1251 * editfns.c (time_overflow): New function, refactoring common code.
1252 (Fformat_time_string, Fdecode_time, Fencode_time):
1253 (Fcurrent_time_string): Use it.
1254
8be6f318
PE
1255 Move 'make_time' to be next to its inverse 'lisp_time_argument'.
1256 * dired.c (make_time): Move to ...
1257 * editfns.c (make_time): ... here.
1258 * systime.h: Note the move.
1259
09d9db2c 12602011-03-12 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
c47cbdfd 1261
126bc0dc
YM
1262 * fringe.c (update_window_fringes): Remove unused variables.
1263
c47cbdfd
YM
1264 * unexmacosx.c (copy_data_segment): Also copy __got section.
1265 (Bug#8223)
1266
7ac80be9
EZ
12672011-03-12 Eli Zaretskii <eliz@gnu.org>
1268
c96bbc66 1269 * termcap.c [MSDOS]: Include "msdos.h".
058e5dad
EZ
1270 (find_capability, tgetnum, tgetflag, tgetstr, tputs, tgetent):
1271 Constify `char *' arguments and their references according to
1272 prototypes in tparam.h.
1273
ecb0f94d 1274 * deps.mk (termcap.o): Depend on tparam.h and msdos.h.
058e5dad 1275
7ac80be9
EZ
1276 * msdos.c (XMenuAddPane): 3rd argument is `const char *' now.
1277 Adapt all references accordingly.
1278
1279 * msdos.h (XMenuAddPane): 3rd argument is `const char *' now.
1280
ef1fd07e
TT
12812011-03-11 Tom Tromey <tromey@redhat.com>
1282
1283 * buffer.c (syms_of_buffer): Remove obsolete comment.
1284
7ef4b50c
EZ
12852011-03-11 Eli Zaretskii <eliz@gnu.org>
1286
1287 * termhooks.h (encode_terminal_code): Declare prototype.
1288
1289 * msdos.c (encode_terminal_code): Don't declare prototype.
1290
1291 * term.c (encode_terminal_code): Now external again, used by
1292 w32console.c and msdos.c.
1293
44f230aa
SM
1294 * makefile.w32-in ($(BLD)/term.$(O), ($(BLD)/tparam.$(O)):
1295 Depend on $(SRC)/tparam.h, see 2011-03-11T07:24:21Z!eggert@cs.ucla.edu.
7ef4b50c 1296
4b1ec863 12972011-03-11 Paul Eggert <eggert@cs.ucla.edu>
f78faa98 1298
1714f52b 1299 Fix some minor problems found by GCC 4.5.2's static checks.
83316bf4 1300
4b1ec863
PE
1301 * fringe.c (update_window_fringes): Mark locals as initialized
1302 (Bug#8227).
1303 (destroy_fringe_bitmap, init_fringe_bitmap): Now static.
bf60f616 1304
524c7aa6
PE
1305 * alloc.c (mark_fringe_data): Move decl from here ...
1306 * lisp.h (mark_fringe_data) [HAVE_WINDOW_SYSTEM]: ... to here,
1307 to check its interface.
1308 (init_fringe_once): Do not declare unless HAVE_WINDOW_SYSTEM.
1309
a5c0af81 1310 * fontset.c (free_realized_fontset): Now static.
7519b8cd 1311 (Fset_fontset_font): Rename local to avoid shadowing.
cc6e5db1 1312 (fontset_font): Mark local as initialized.
a9a06e0b 1313 (FONTSET_SPEC, FONTSET_REPERTORY, RFONT_DEF_REPERTORY): Remove; unused.
a5c0af81 1314
b4716021
PE
1315 * xrdb.c: Include "xterm.h", to check x_load_resources's interface.
1316
811e9bac 1317 * xselect.c (x_disown_buffer_selections): Remove; not used.
7b83e2f1 1318 (TRACE3) [!defined TRACE_SELECTION]: Remove; not used.
aa0daa9f
PE
1319 (x_own_selection, Fx_disown_selection_internal): Rename locals
1320 to avoid shadowing.
1321 (x_handle_dnd_message): Remove local to avoid shadowing.
811e9bac 1322
7e3ab302
PE
1323 * lisp.h (GCPRO1_VAR, UNGCPRO_VAR): New macros,
1324 so that the caller can use some name other than gcpro1.
1325 (GCPRO1, UNGCPRO): Reimplement in terms of the new macros.
58d2d479
PE
1326 * xfns.c (Fx_create_frame, x_create_tip_frame, Fx_show_tip):
1327 (Fx_backspace_delete_keys_p):
1328 Use them to avoid shadowing, and rename vars to avoid shadowing.
1329 (x_decode_color, x_set_name, x_window): Now static.
6b437900 1330 (Fx_create_frame): Add braces to silence GCC warning.
c0951e53 1331 (Fx_file_dialog, Fx_select_font): Fix pointer signedness.
06b0c8a0
PE
1332 (x_real_positions, xg_set_icon_from_xpm_data, x_create_tip_frame):
1333 Remove unused locals.
7e3ab302
PE
1334 (Fx_create_frame, x_create_tip_frame, Fx_show_tip):
1335 (Fx_backspace_delete_keys_p): Rename locals to avoid shadowing.
1336 Some of these renamings use the new GCPRO1_VAR and UNGCPRO_VAR
1337 macros.
f78faa98 1338
e2b13473
PE
1339 * xterm.h (x_mouse_leave): New decl.
1340
77f23912
PE
1341 * xterm.c (x_copy_dpy_color, x_focus_on_frame, x_unfocus_frame):
1342 Remove unused functions.
cdf4ba58
PE
1343 (x_shift_glyphs_for_insert, XTflash, XTring_bell):
1344 (x_calc_absolute_position): Now static.
7411c686 1345 (XTread_socket): Don't define label "out" unless it's used.
2b07bcff 1346 Don't declare local "event" unless it's used.
ed7bf3a5
PE
1347 (x_iconify_frame, x_free_frame_resources): Don't declare locals
1348 unless they are used.
38d0b34a
PE
1349 (XEMBED_VERSION, xembed_set_info): Don't define unless needed.
1350 (x_fatal_error_signal): Remove; not used.
a6067996
PE
1351 (x_draw_image_foreground, redo_mouse_highlight, XTmouse_position):
1352 (x_scroll_bar_report_motion, handle_one_xevent, x_draw_bar_cursor):
1353 (x_error_catcher, x_connection_closed, x_error_handler):
1354 (x_error_quitter, xembed_send_message, x_iconify_frame):
1355 (my_log_handler): Rename locals to avoid shadowing.
28f1c698 1356 (x_delete_glyphs, x_ins_del_lines): Mark with NO_RETURN.
2a8fade0 1357 (x_connection_closed): Tell GCC not to suggest NO_RETURN.
77f23912 1358
44f230aa
SM
1359 * xfaces.c (clear_face_cache, Fx_list_fonts, Fface_font):
1360 Rename or move locals to avoid shadowing.
6b463e58 1361 (tty_defined_color, merge_face_heights): Now static.
5967d051 1362 (free_realized_faces_for_fontset): Remove; not used.
1e9966ea
PE
1363 (Fx_list_fonts): Mark variable that gcc -Wuninitialized
1364 does not deduce is never used uninitialized.
73719eba
PE
1365 (STRDUPA, LSTRDUPA, FONT_POINT_SIZE_QUANTUM): Remove; not used.
1366 (LFACEP): Define only if XASSERTS, as it's not needed otherwise.
071048a3 1367
426994c3 1368 * terminal.c (store_terminal_param): Now static.
5489860b 1369
032f1620 1370 * xmenu.c (menu_highlight_callback): Now static.
9d66f88e 1371 (set_frame_menubar): Remove unused local.
d4323972 1372 (xmenu_show): Rename parameter to avoid shadowing.
6d1f7fee
PE
1373 (xmenu_show, xdialog_show, xmenu_show): Make local pointers "const"
1374 since they might point to immutable storage.
281585b0
PE
1375 (next_menubar_widget_id): Declare only if USE_X_TOOLKIT,
1376 since it's unused otherwise.
032f1620 1377
367c19e5 1378 * xdisp.c (produce_glyphless_glyph): Initialize lower_xoff.
53df7c11 1379 Add a FIXME, since the code still doesn't look right. (Bug#8215)
9f36b9fd
PE
1380 (Fcurrent_bidi_paragraph_direction): Simplify slightly; this
1381 avoids a gcc -Wuninitialized diagnostic.
0e086e8f 1382 (display_line, BUILD_COMPOSITE_GLYPH_STRING, draw_glyphs):
44a3a108
PE
1383 (note_mouse_highlight): Mark variables that gcc -Wuninitialized
1384 does not deduce are never used uninitialized.
70739cbe 1385
07b48fa9
PE
1386 * lisp.h (IF_LINT): New macro, copied from ../lib-src/emacsclient.c.
1387
8868a238 1388 * xdisp.c (redisplay_window): Rename local to avoid shadowing.
4554d213
PE
1389 * window.c (window_loop, size_window):
1390 (run_window_configuration_change_hook, enlarge_window): Likewise.
8868a238 1391
7e5cf297 1392 * window.c (display_buffer): Now static.
d6550a9f
PE
1393 (size_window): Mark variables that gcc -Wuninitialized
1394 does not deduce are never used uninitialized.
a586633d
PE
1395 * window.h (check_all_windows): New decl, to forestall
1396 gcc -Wmissing-prototypes diagnostic.
5b555da1 1397 * dispextern.h (bidi_dump_cached_states): Likewise.
7e5cf297 1398
f6095868
PE
1399 * charset.h (CHECK_CHARSET_GET_CHARSET): Rename locals to avoid
1400 shadowing.
1401 * charset.c (map_charset_for_dump, Fchar_charset): Likewise.
726929c4
PE
1402 Include <limits.h>.
1403 (Fsort_charsets): Redo min/max calculation to shorten the code a bit
1404 and to avoid gcc -Wuninitialized warning.
89ef49df
PE
1405 (load_charset_map): Mark variables that gcc -Wuninitialized
1406 does not deduce are never used uninitialized.
53df7c11 1407 (load_charset): Abort instead of using uninitialized var (Bug#8229).
f6095868 1408
f38b440c
PE
1409 * coding.c (coding_set_source, coding_set_destination):
1410 Use "else { /* comment */ }" rather than "else /* comment */;"
1411 for clarity, and to avoid gcc -Wempty-body warning.
2735d060
PE
1412 (Fdefine_coding_system_internal): Don't redeclare 'i' inside
1413 a block, when the outer 'i' will do.
1414 (decode_coding_utf_8, decode_coding_utf_16, detect_coding_emacs_mule):
1415 (emacs_mule_char, decode_coding_emacs_mule, detect_coding_iso_2022):
1416 (decode_coding_iso_2022, decode_coding_sjis, decode_coding_big5):
1417 (decode_coding_raw_text, decode_coding_charset, get_translation_table):
1418 (Fdecode_sjis_char, Fdefine_coding_system_internal):
1419 Rename locals to avoid shadowing.
1420 * character.h (FETCH_STRING_CHAR_ADVANCE): Likewise.
e2f1bab9
PE
1421 * coding.c (emacs_mule_char, encode_invocation_designation):
1422 Now static, since they're not used elsewhere.
413bb2db 1423 (decode_coding_iso_2022): Add "default: abort ();" as a safety check.
c4a63b12 1424 (decode_coding_object, encode_coding_object, detect_coding_system):
ee05f961
PE
1425 (decode_coding_emacs_mule): Mark variables that gcc
1426 -Wuninitialized does not deduce are never used uninitialized.
160b01f6
PE
1427 (detect_coding_iso_2022): Initialize a local variable that might
1428 be used uninitialized. Leave a FIXME because it's not clear that
53df7c11 1429 this initialization is needed. (Bug#8211)
5f58e762
PE
1430 (ISO_CODE_LF, ISO_CODE_CR, CODING_ISO_FLAG_EUC_TW_SHIFT):
1431 (ONE_MORE_BYTE_NO_CHECK, UTF_BOM, UTF_16_INVALID_P):
1432 (SHIFT_OUT_OK, ENCODE_CONTROL_SEQUENCE_INTRODUCER):
1433 (ENCODE_DIRECTION_R2L, ENCODE_DIRECTION_L2R):
1434 Remove unused macros.
f38b440c 1435
232b38b9 1436 * category.c (hash_get_category_set): Remove unused local var.
9f3b5e69 1437 (copy_category_table): Now static, since it's not used elsewhere.
d0891610 1438 * character.c (string_count_byte8): Likewise.
232b38b9 1439
fb90da1b
PE
1440 * ccl.c (CCL_WRITE_STRING, CCL_ENCODE_CHAR, Fccl_execute_on_string):
1441 (Fregister_code_conversion_map): Rename locals to avoid shadowing.
1442
fb93dbc2
PE
1443 * chartab.c (copy_sub_char_table): Now static, since it's not used
1444 elsewhere.
5c156ace
PE
1445 (sub_char_table_ref_and_range, char_table_ref_and_range):
1446 Rename locals to avoid shadowing.
bbcd0949 1447 (ASET_RANGE, GET_SUB_CHAR_TABLE): Remove unused macros.
fb93dbc2 1448
7d3b3862 1449 * bidi.c (bidi_check_type): Now static, since it's not used elsewhere.
630d6892 1450 (BIDI_BOB): Remove unused macro.
7d3b3862 1451
6be7d3da
PE
1452 * cm.c (cmgoto): Mark variables that gcc -Wuninitialized does not
1453 deduce are never used uninitialized.
c2ed9c8b 1454 * term.c (encode_terminal_code): Likewise.
6be7d3da 1455
75f8807f 1456 * term.c (encode_terminal_code): Now static. Remove unused local.
72abad34 1457
50938595
PE
1458 * tparam.h: New file.
1459 * term.c, tparam.h: Include it.
1460 * deps.mk (term.o, tparam.o): Depend on tparam.h.
1461 * term.c (tputs, tgetent, tgetflag, tgetnum, tparam, tgetstr):
1462 Move these decls to tparam.h, and make them agree with what
1463 is actually in tparam.c. The previous trick of using incompatible
1464 decls in different modules does not conform to the C standard.
1465 All callers of tparam changed to use tparam's actual API.
1466 * tparam.c (tparam1, tparam, tgoto):
1467 Use const pointers where appropriate.
1468
fbceeba2
PE
1469 * cm.c (calccost, cmgoto): Use const pointers where appropriate.
1470 * cm.h (struct cm): Likewise.
1471 * dispextern.h (do_line_insertion_deletion_costs): Likewise.
1472 * scroll.c (ins_del_costs, do_line_insertion_deletion_costs): Likewise.
1473 * term.c (tty_ins_del_lines, calculate_costs, struct fkey_table):
1474 (term_get_fkeys_1, append_glyphless_glyph, produce_glyphless_glyph):
1475 (turn_on_face, init_tty): Likewise.
1476 * termchar.h (struct tty_display_info): Likewise.
fbceeba2 1477
7f3f1250
PE
1478 * term.c (term_mouse_position): Rename local to avoid shadowing.
1479
e6ca6543
PE
1480 * alloc.c (mark_ttys): Move decl from here ...
1481 * lisp.h (mark_ttys): ... to here, so that it's checked against defn.
1482
c40f8d15
AS
14832011-03-11 Andreas Schwab <schwab@linux-m68k.org>
1484
1485 * .gdbinit (pwinx, xbuffer): Fix access to buffer name.
1486
cfe0661d
JB
14872011-03-09 Juanma Barranquero <lekktu@gmail.com>
1488
1489 * search.c (compile_pattern_1): Remove argument regp, unused since
1490 revid:rms@gnu.org-19941211082627-3x1g1wyqkjmwloig.
1491 (compile_pattern): Don't pass it.
1492
0afb4571
J
14932011-03-08 Jan Djärv <jan.h.d@swipnet.se>
1494
1495 * xterm.h (DEFAULT_GDK_DISPLAY): New define.
1496 (GDK_WINDOW_XID, gtk_widget_get_preferred_size): New defines
1497 for ! HAVE_GTK3.
1498 (GTK_WIDGET_TO_X_WIN): Use GDK_WINDOW_XID.
1499
1500 * xmenu.c (menu_position_func): Call gtk_widget_get_preferred_size.
1501
1502 * gtkutil.c: Include gtkx.h if HAVE_GTK3. If ! HAVE_GTK3, define
1503 gdk_window_get_screen, gdk_window_get_geometry,
1504 gdk_x11_window_lookup_for_display and GDK_KEY_g.
1505 (xg_set_screen): Use DEFAULT_GDK_DISPLAY.
1506 (xg_get_pixbuf_from_pixmap): New function.
1507 (xg_get_pixbuf_from_pix_and_mask): Change parameters from GdkPixmap
1508 to Pixmap, take frame as parameter, remove GdkColormap parameter.
1509 Call xg_get_pixbuf_from_pixmap instead of
1510 gdk_pixbuf_get_from_drawable.
1511 (xg_get_image_for_pixmap): Do not make GdkPixmaps, call
1512 xg_get_pixbuf_from_pix_and_mask with Pixmap parameters instead.
1513 (xg_check_special_colors): Use GtkStyleContext and its functions
1514 for HAVE_GTK3.
1515 (xg_prepare_tooltip, xg_hide_tooltip): Call gdk_window_get_screen.
1516 (xg_prepare_tooltip, create_dialog, menubar_map_cb)
1517 (xg_update_frame_menubar, xg_tool_bar_detach_callback)
44f230aa
SM
1518 (xg_tool_bar_attach_callback, xg_update_tool_bar_sizes):
1519 Call gtk_widget_get_preferred_size.
0afb4571
J
1520 (xg_frame_resized): gdk_window_get_geometry only takes 5
1521 parameters.
44f230aa
SM
1522 (xg_win_to_widget, xg_event_is_for_menubar):
1523 Call gdk_x11_window_lookup_for_display.
0afb4571
J
1524 (xg_set_widget_bg): New function.
1525 (delete_cb): New function.
1526 (xg_create_frame_widgets): connect delete-event to delete_cb.
1527 Call xg_set_widget_bg. Only set backgrund pixmap for ! HAVE_GTK3
1528 (xg_set_background_color): Call xg_set_widget_bg.
1529 (xg_set_frame_icon): Call xg_get_pixbuf_from_pix_and_mask.
1530 (xg_create_scroll_bar): vadj is a GtkAdjustment for HAVE_GTK3.
1531 Only call gtk_range_set_update_policy if ! HAVE_GTK3.
1532 (xg_make_tool_item): Only connect xg_tool_bar_item_expose_callback
1533 if ! HAVE_GTK3.
1534 (update_frame_tool_bar): Call gtk_widget_hide.
1535 (xg_initialize): Use GDK_KEY_g.
1536
1537 * xsmfns.c (gdk_set_sm_client_id): Define to gdk_set_sm_client_id
1538 if ! HAVE_GTK3
1539 (x_session_initialize): Call gdk_x11_set_sm_client_id.
1540
1541 * xterm.c (XFillRectangle): Use cairo routines for HAVE_GTK3.
1542 (x_term_init): Disable Xinput(2) with GDK_CORE_DEVICE_EVENTS.
1543 Load ~/emacs.d/gtkrc only for ! HAVE_GTK3.
1544
1c2cc4ef
JB
15452011-03-08 Juanma Barranquero <lekktu@gmail.com>
1546
1547 * w32xfns.c (select_palette): Check success of RealizePalette against
1548 GDI_ERROR, not zero.
1549
33383987 1550See ChangeLog.11 for earlier changes.
aac0c6e3
MR
1551
1552;; Local Variables:
1553;; coding: utf-8
aac0c6e3
MR
1554;; End:
1555
33383987 1556 Copyright (C) 2011 Free Software Foundation, Inc.
aac0c6e3
MR
1557
1558 This file is part of GNU Emacs.
1559
1560 GNU Emacs is free software: you can redistribute it and/or modify
1561 it under the terms of the GNU General Public License as published by
1562 the Free Software Foundation, either version 3 of the License, or
1563 (at your option) any later version.
1564
1565 GNU Emacs is distributed in the hope that it will be useful,
1566 but WITHOUT ANY WARRANTY; without even the implied warranty of
1567 MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
1568 GNU General Public License for more details.
1569
1570 You should have received a copy of the GNU General Public License
1571 along with GNU Emacs. If not, see <http://www.gnu.org/licenses/>.