* lisp/vc/vc-bzr.el (vc-bzr-revision-keywords): Update.
[bpt/emacs.git] / src / ChangeLog
CommitLineData
4550efdf
KI
12011-07-01 Kazuhiro Ito <kzhr@d1.dion.ne.jp> (tiny patch)
2
3 * coding.c (Fencode_coding_string): Record the last coding system
4 used, as the function doc string says (bug#8738).
5
0949d2b6
JD
62011-07-01 Jan Djärv <jan.h.d@swipnet.se>
7
8 * xsettings.c (store_monospaced_changed): Take new font as arg and
9 check for change against current_mono_font.
10 (EMACS_TYPE_SETTINGS): Remove this and related defines.
11 (emacs_settings_constructor, emacs_settings_get_property)
12 (emacs_settings_set_property, emacs_settings_class_init)
13 (emacs_settings_init, gsettings_obj): Remove.
14 (something_changedCB): New function for HAVE_GSETTINGS.
15 (something_changedCB): HAVE_GCONF: Call store_monospaced_changed
16 with value as argument.
17 (init_gsettings): Check that GSETTINGS_SCHEMA exists before calling
18 g_settings_new (Bug#8967). Do not create gsettings_obj.
19 Remove calls to g_settings_bind. Connect something_changedCB to
20 "changed".
21
22 * xgselect.c: Add defined (HAVE_GSETTINGS).
23 (xgselect_initialize): Ditto.
24
25 * process.c: Add defined (HAVE_GSETTINGS) for xgselect.h
26 (wait_reading_process_output): Add defined (HAVE_GSETTINGS) for
27 xg_select.
28
bbc6b304
PE
292011-07-01 Paul Eggert <eggert@cs.ucla.edu>
30
31 * eval.c (struct backtrace): Simplify and port the data structure.
32 Do not assume that "int nargs : BITS_PER_INT - 2;" produces a
33 signed bit field, as this assumption is not portable and it makes
34 Emacs crash when compiled with Sun C 5.8 on sparc. Do not use
35 "char debug_on_exit : 1" as this is not portable either; instead,
36 use the portable "unsigned int debug_on_exit : 1". Remove unused
37 member evalargs. Remove obsolete comments about cc bombing out.
38
9851bfc5
JD
392011-06-30 Jan Djärv <jan.h.d@swipnet.se>
40
51bb811f 41 * xsettings.c: Include glib-object.h, gio/gio.h if HAVE_GSETTINGS.
9851bfc5
JD
42 Let HAVE_GSETTINGS override HAVE_GCONF.
43 (store_monospaced_changed): New function.
44 (EMACS_SETTINGS): A new type derived from GObject to handle
45 GSettings notifications.
46 (emacs_settings_constructor, emacs_settings_get_property)
47 (emacs_settings_set_property, emacs_settings_class_init):
48 New functions.
49 (gsettings_client, gsettings_obj): New variables.
50 (GSETTINGS_SCHEMA): New define.
51 (something_changedCB): Call store_monospaced_changed.
52 (init_gsettings): New function.
53 (xsettings_initialize): Call init_gsettings.
54 (syms_of_xsettings): Initialize gsettings_client, gsettings_obj
55 to NULL.
56
57 * Makefile.in (SETTINGS_CFLAGS, SETTINGS_LIBS): Renamed from
58 GCONF_CFLAGS/LIBS.
59
5386012d
MR
602011-06-29 Martin Rudalics <rudalics@gmx.at>
61
62 * window.c (resize_root_window, grow_mini_window)
63 (shrink_mini_window): Rename Qresize_root_window to
64 Qwindow_resize_root_window and Qresize_root_window_vertically to
65 Qwindow_resize_root_window_vertically.
66
f13e0b08
PE
672011-06-28 Paul Eggert <eggert@cs.ucla.edu>
68
69 * gnutls.c (Qgnutls_bootprop_verify_error): Remove unused var.
70
94515237
JB
712011-06-27 Juanma Barranquero <lekktu@gmail.com>
72
73 * makefile.w32-in: Redesign dependencies so they reflect more
74 clearly which files are directly included by each source file,
75 and not through other includes.
76
e43b6e43
MR
772011-06-27 Martin Rudalics <rudalics@gmx.at>
78
79 * buffer.c (Qclone_number): Declare static and DEFSYM it.
80 (sort_overlays, overlay_strings): When an overlay's clone number
81 matches the window's clone number process the overlay even if
82 the overlay's window property doesn't match the current window.
83
d68443dc
MR
84 * window.c (Fwindow_vchild): Rename to Fwindow_top_child.
85 (Fwindow_hchild): Rename to Fwindow_left_child.
86 (Fwindow_next): Rename to Fwindow_next_sibling.
87 (Fwindow_prev): Rename to Fwindow_prev_sibling.
d615d6d2
MR
88 (resize_window_check): Rename to window_resize_check.
89 (resize_window_apply): Rename to window_resize_apply.
90 (Fresize_window_apply): Rename to Fwindow_resize_apply.
91 (Fdelete_other_windows_internal, resize_frame_windows)
92 (Fsplit_window_internal, Fdelete_window_internal)
93 (grow_mini_window, shrink_mini_window)
94 (Fresize_mini_window_internal): Fix callers accordingly.
d68443dc 95
c7e73be5
JD
962011-06-26 Jan Djärv <jan.h.d@swipnet.se>
97
98 * emacsgtkfixed.h: State that this is only used with Gtk+3.
99 (emacs_fixed_set_min_size): Remove.
100 (emacs_fixed_new): Take frame as argument.
101
102 * emacsgtkfixed.c: State that this is only used with Gtk+3.
103 (_EmacsFixedPrivate): Remove minwidth/height.
104 Add struct frame *f.
105 (emacs_fixed_init): Initialize priv->f.
106 (get_parent_class, emacs_fixed_set_min_size): Remove.
107 (emacs_fixed_new): Set priv->f to argument.
108 (emacs_fixed_get_preferred_width)
109 (emacs_fixed_get_preferred_height): Use min_width/height from
110 frames size_hint to set minimum and natural (Bug#8919).
111 (XSetWMSizeHints, XSetWMNormalHints): Override these functions
112 and use min_width/height from frames size_hint to set
113 min_width/height (Bug#8919).
114
115 * gtkutil.c (xg_create_frame_widgets): Pass f to emacs_fixed_new.
116 (x_wm_set_size_hint): Remove call to emacs_fixed_set_min_size. Fix
117 indentation.
118
cf99dcf8
EZ
1192011-06-26 Eli Zaretskii <eliz@gnu.org>
120
121 * bidi.c (bidi_paragraph_init): Test for ZV_BYTE before calling
122 bidi_at_paragraph_end, since fast_looking_at doesn't like to be
123 called at ZV.
124
029529ac
CY
1252011-06-26 Chong Yidong <cyd@stupidchicken.com>
126
127 * process.c (wait_reading_process_output): Bypass select if
128 waiting for a cell while ignoring keyboard input, and input is
129 pending. Suggested by Jan Djärv (Bug#8869).
130
7a7ef429
PE
1312011-06-25 Paul Eggert <eggert@cs.ucla.edu>
132
133 Use gnulib's dup2 module instead of rolling our own.
134 * sysdep.c (dup2) [!HAVE_DUP2]: Remove; gnulib now does this.
135
11fdef7d 1362011-06-25 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
989b42d2
YM
137
138 * dispnew.c (scrolling_window): Before scrolling, turn off a
139 mouse-highlight in the window being scrolled.
140
cd3520a4
JB
1412011-06-24 Juanma Barranquero <lekktu@gmail.com>
142
143 Move DEFSYM to lisp.h and use everywhere.
144
145 * character.h (DEFSYM): Move declaration...
146 * lisp.h (DEFSYM): ...here.
147
148 * gnutls.c:
149 * minibuf.c:
150 * w32menu.c:
151 * w32proc.c:
152 * w32select.c: Don't include character.h.
153
154 * alloc.c (syms_of_alloc):
155 * buffer.c (syms_of_buffer):
156 * bytecode.c (syms_of_bytecode):
157 * callint.c (syms_of_callint):
158 * casefiddle.c (syms_of_casefiddle):
159 * casetab.c (init_casetab_once):
160 * category.c (init_category_once, syms_of_category):
161 * ccl.c (syms_of_ccl):
162 * cmds.c (syms_of_cmds):
163 * composite.c (syms_of_composite):
164 * dbusbind.c (syms_of_dbusbind):
165 * dired.c (syms_of_dired):
166 * dispnew.c (syms_of_display):
167 * doc.c (syms_of_doc):
168 * editfns.c (syms_of_editfns):
169 * emacs.c (syms_of_emacs):
170 * eval.c (syms_of_eval):
171 * fileio.c (syms_of_fileio):
172 * fns.c (syms_of_fns):
173 * frame.c (syms_of_frame):
174 * fringe.c (syms_of_fringe):
175 * insdel.c (syms_of_insdel):
176 * keymap.c (syms_of_keymap):
177 * lread.c (init_obarray, syms_of_lread):
178 * macros.c (syms_of_macros):
179 * msdos.c (syms_of_msdos):
180 * print.c (syms_of_print):
181 * process.c (syms_of_process):
182 * search.c (syms_of_search):
183 * sound.c (syms_of_sound):
184 * syntax.c (init_syntax_once, syms_of_syntax):
185 * terminal.c (syms_of_terminal):
186 * textprop.c (syms_of_textprop):
187 * undo.c (syms_of_undo):
188 * w32.c (globals_of_w32):
189 * window.c (syms_of_window):
190 * xdisp.c (syms_of_xdisp):
191 * xfaces.c (syms_of_xfaces):
192 * xfns.c (syms_of_xfns):
193 * xmenu.c (syms_of_xmenu):
194 * xsettings.c (syms_of_xsettings):
195 * xterm.c (syms_of_xterm): Use DEFSYM.
196
4228cf16
TZ
1972011-06-24 Teodor Zlatanov <tzz@lifelogs.com>
198
cd3520a4 199 * gnutls.c (syms_of_gnutls): Use the DEFSYM macro from character.h.
4228cf16 200
7fcccf1e
PE
2012011-06-23 Paul Eggert <eggert@cs.ucla.edu>
202
7efb4e0e
PE
203 Integer and buffer overflow fixes (Bug#8873).
204
ff5844ad
PE
205 * print.c (printchar, strout): Check for string overflow.
206 (PRINTPREPARE, printchar, strout):
207 Don't set size unless allocation succeeds.
208
90532f02
PE
209 * minibuf.c (read_minibuf_noninteractive): Use ptrdiff_t, not int,
210 for sizes. Check for string overflow more accurately.
211 Simplify newline removal at end; this suppresses a GCC 4.6.0 warning.
212
6d84508d
PE
213 * macros.c: Integer and buffer overflow fixes.
214 * keyboard.h (struct keyboard.kbd_macro_bufsize):
215 * macros.c (Fstart_kbd_macro, store_kbd_macro_char):
216 Use ptrdiff_t, not int, for sizes.
217 Don't increment bufsize until after realloc succeeds.
218 Check for size-calculation overflow.
219 (Fstart_kbd_macro): Use EMACS_INT, not int, for XINT result.
220
437b2cb4
PE
221 * lisp.h (DEFVAR_KBOARD): Use offsetof instead of char * finagling.
222
8b9ac8b4
PE
223 * lread.c: Integer overflow fixes.
224 (read_integer): Radix is now EMACS_INT, not int,
225 to improve quality of diagnostics for out-of-range radices.
226 Calculate buffer size correctly for out-of-range radices.
227 (read1): Check for integer overflow in radices, and in
228 read-circle numbers.
82cb60d3
PE
229 (read_escape): Avoid int overflow.
230 (Fload, openp, read_buffer_size, read1)
231 (substitute_object_recurse, read_vector, read_list, map_obarray):
232 Use ptrdiff_t, not int, for sizes.
233 (read1): Use EMACS_INT, not int, for sizes.
20270765 234 Check for size overflow.
8b9ac8b4 235
7fcccf1e
PE
236 * image.c (cache_image): Check for size arithmetic overflow.
237
bfbbd7e7
PE
238 * lread.c: Integer overflow issues.
239 (saved_doc_string_size, saved_doc_string_length)
240 (prev_saved_doc_string_size, prev_saved_doc_string_length):
241 Now ptrdiff_t, not int.
242 (read1): Don't assume doc string length fits in int. Check for
243 out-of-range doc string lengths.
244 (read_list): Don't assume file position fits in int.
39019e54 245 (read_escape): Check for hex character overflow.
bfbbd7e7 246
4e323265
LL
2472011-06-22 Leo Liu <sdl.web@gmail.com>
248
249 * minibuf.c (Fcompleting_read_default, Vcompleting_read_function):
250 Move to minibuffer.el.
251
85fece3e
PE
2522011-06-22 Paul Eggert <eggert@cs.ucla.edu>
253
20b84ce9 254 Fixes for GLYPH_DEBUG found by GCC 4.6.0 static checking.
85fece3e
PE
255 The following patches are for when GLYPH_DEBUG && !XASSERT.
256 * dispextern.h (trace_redisplay_p, dump_glyph_string):
257 * dispnew.c (flush_stdout):
258 * xdisp.c (dump_glyph_row, dump_glyph_matrix, dump_glyph):
259 Mark as externally visible.
260 * dispnew.c (check_window_matrix_pointers): Now static.
261 * dispnew.c (window_to_frame_vpos):
262 * xfns.c (unwind_create_frame):
263 * xterm.c (x_check_font): Remove unused local.
264 * scroll.c (CHECK_BOUNDS):
265 * xfaces.c (cache_fache): Rename local to avoid shadowing.
266 * xfns.c, w32fns.c (image_cache_refcount, dpyinfo_refcount): Now static.
267 * xdisp.c (check_window_end): Now a no-op if !XASSERTS.
268 (debug_first_unchanged_at_end_vpos, debug_last_unchanged_at_beg_vpos)
269 (debug_dvpos, debug_dy, debug_delta, debug_delta_bytes, debug_end_vpos):
270 Now static.
271 (debug_method_add): Use va_list and vsprintf rather than relying
272 on undefined behavior with wrong number of arguments.
273 (dump_glyph, dump_glyph_row, Fdump_glyph_matrix):
274 Don't assume ptrdiff_t and EMACS_INT are the same width as int.
275 In this code, it's OK to assume C99 behavior for ptrdiff_t formats
276 since we're not interested in debugging glyphs with old libraries.
277 * xfaces.c (cache_face): Move debugging code earlier; this pacifies
278 GCC 4.6.0's static checking.
279
0766b489
PE
2802011-06-22 Paul Eggert <eggert@cs.ucla.edu>
281
31fd4b32
PE
282 Integer overflow and signedness fixes (Bug#8873).
283 A few related buffer overrun fixes, too.
284
b79e8648
PE
285 * font.c (font_score): Use EMACS_INT, not int, to store XINT value.
286
0766b489
PE
287 * dispextern.h (struct face.stipple):
288 * image.c (x_bitmap_height, x_bitmap_width, x_bitmap_pixmap)
289 (x_bitmap_mask, x_allocate_bitmap_record)
290 (x_create_bitmap_from_data, x_create_bitmap_from_file)
291 (x_destroy_bitmap, x_destroy_all_bitmaps, x_create_bitmap_mask)
292 (x_create_bitmap_from_xpm_data):
293 * nsterm.h (struct ns_display_info.bitmaps_size, .bitmaps_last):
294 * w32term.h (struct w32_display_info.icon_bitmap_id, .bitmaps_size)
295 (.bitmaps_last):
296 * xfaces.c (load_pixmap):
297 * xterm.c (x_bitmap_icon, x_wm_set_icon_pixmap):
298 * xterm.h (struct x_display_info.icon_bitmap_id, .bitmaps_size)
299 (.bitmaps_last, struct x_output.icon_bitmap):
300 Use ptrdiff_t, not int, for bitmap indexes.
301 (x_allocate_bitmap_record): Check for size overflow.
302 * dispextern.h, lisp.h: Adjust to API changes elsewhere.
303
b081724f
PE
304 Use ptrdiff_t, not int, for overlay counts.
305 * buffer.h (overlays_at, sort_overlays, GET_OVERLAYS_AT):
306 * editfns.c (overlays_around, get_pos_property):
307 * textprop.c (get_char_property_and_overlay):
308 * xdisp.c (next_overlay_change, note_mouse_highlight):
309 * xfaces.c (face_at_buffer_position):
21514da7
PE
310 * buffer.c (OVERLAY_COUNT_MAX): New macro.
311 (overlays_at, overlays_in, sort_overlays, Foverlays_at)
312 (Fnext_overlay_change, Fprevious_overlay_change)
313 (mouse_face_overlay_overlaps, Foverlays_in):
b081724f 314 Use ptrdiff_t, not int, for sizes.
21514da7 315 (overlays_at, overlays_in): Check for size-calculation overflow.
b081724f 316
3de73e5e
PE
317 * xterm.c (xim_initialize, same_x_server): Strlen may not fit in int.
318
2606c57b
PE
319 * xsmfns.c (smc_save_yourself_CB, x_session_initialize): Avoid strlen.
320 (x_session_initialize): Do not assume string length fits in int.
321
aaafe47a
PE
322 * xsettings.c (apply_xft_settings): Fix potential buffer overrun.
323 This is unlikely, but can occur if DPI is outlandish.
324
2674ddc8 325 * xsettings.c (Ffont_get_system_normal_font, Ffont_get_system_font):
3a5077c5
PE
326 * xselect.c (Fx_get_atom_name): Avoid need for strlen.
327
28154962
PE
328 * xrdb.c: Don't assume strlen fits in int; avoid some strlens.
329 * xrdb.c (magic_file_p, search_magic_path):
330 Omit last arg SUFFIX; it was always 0. All callers changed.
331 (magic_file_p): Use ptrdiff_t, not int. Check for size overflow.
332
7de51af5
PE
333 * xfont.c (xfont_match): Avoid need for strlen.
334
25ed6cc3
PE
335 * xfns.c: Don't assume strlen fits in int.
336 (xic_create_fontsetname, x_window): Use ptrdiff_t, not int.
337
4eab31dd
PE
338 * xdisp.c (message_log_check_duplicate): Return intmax_t,
339 not unsigned long, as we prefer signed integers. All callers changed.
340 Detect integer overflow in repeat count.
341 (message_dolog): Don't assume print length fits in 39 bytes.
df1f27af 342 (display_mode_element): Don't assume strlen fits in int.
4eab31dd 343
171e2a58
PE
344 * termcap.c: Don't assume sizes fit in int and never overflow.
345 (struct termcap_buffer, tgetent): Use ptrdiff_t, not int, for sizes.
346 (gobble_line): Check for size-calculation overflow.
347
ad39faca 348 * minibuf.c (Fread_buffer):
6e5bb2dc 349 * lread.c (intern, intern_c_string):
74ca2eb3
PE
350 * image.c (xpm_scan) [HAVE_NS && !HAVE_XPM]:
351 Don't assume string length fits in int.
352
52c61c22 353 * keyboard.c (parse_tool_bar_item):
9bda3520
PE
354 * gtkutil.c (style_changed_cb): Avoid need for strlen.
355
b5b8c9e5
PE
356 * font.c: Don't assume string length fits in int.
357 (font_parse_xlfd, font_parse_fcname, font_unparse_fcname):
358 Use ptrdiff_t, not int.
ccd6111c
PE
359 (font_intern_prop): Don't assume string length fits in int.
360 Don't assume integer property fits in fixnum.
361 * font.h (font_intern_prop): 2nd arg is now ptrdiff_t, not int.
b5b8c9e5 362
882f0d81 363 * filelock.c: Fix some buffer overrun and integer overflow issues.
51cab52b 364 (get_boot_time): Don't assume gzip command string fits in 100 bytes.
882f0d81
PE
365 Reformulate so as not to need the command string.
366 Invoke gzip -cd rather than gunzip, as it's more portable.
367 (lock_info_type, lock_file_1, lock_file):
368 Don't assume pid_t and time_t fit in unsigned long.
369 (LOCK_PID_MAX): Remove; we now use more-reliable bounds.
370 (current_lock_owner): Prefer signed type for sizes.
371 Use memcpy, not strncpy, where memcpy is what is really wanted.
372 Don't assume (via atoi) that time_t and pid_t fit in int.
373 Check for time_t and/or pid_t out of range, e.g., via a network share.
374 Don't alloca where an auto var works fine.
375
93f4cf88
PE
376 * fileio.c: Fix some integer overflow issues.
377 (file_name_as_directory, Fexpand_file_name, Fsubstitute_in_file_name):
378 Don't assume string length fits in int.
379 (directory_file_name): Don't assume string length fits in long.
380 (make_temp_name): Don't assume pid fits in int, or that its print
381 length is less than 20.
382
f3e92b69
PE
383 * data.c (Fsubr_name): Rewrite to avoid a strlen call.
384
1bfdaf10
PE
385 * coding.c (make_subsidiaries): Don't assume string length fits in int.
386
35016e9a
PE
387 * callproc.c (child_setup): Rewrite to avoid two strlen calls.
388
3d1e65a1
PE
389 * process.c (Fformat_network_address): Use EMACS_INT, not EMACS_UINT.
390 We prefer signed integers, even for size calculations.
391
0b963a93
PE
392 * emacs.c: Don't assume string length fits in 'int'.
393 (DEFINE_DUMMY_FUNCTION, sort_args): Use ptrdiff_t, not int.
394 (main): Don't invoke strlen when not needed.
395
573f4b54
PE
396 * dbusbind.c (XD_ERROR): Don't arbitrarily truncate string.
397 (XD_DEBUG_MESSAGE): Don't waste a byte.
398
989f33ba
PE
399 * callproc.c (getenv_internal_1, getenv_internal)
400 (Fgetenv_internal):
965d34eb
PE
401 * buffer.c (init_buffer): Don't assume string length fits in 'int'.
402
e4d29b33
PE
403 * lread.c (invalid_syntax): Omit length argument.
404 All uses changed. This doesn't fix a bug, but it simplifies the
405 code away from its former Hollerith-constant appearance, and it's
406 one less 'int' to worry about when looking at integer-overflow issues.
51cab52b 407 (string_to_number): Simplify 2011-04-26 change by invoking xsignal1.
e4d29b33 408
eb49b136
PE
409 * lisp.h (DEFUN): Remove bogus use of sizeof (struct Lisp_Subr).
410 This didn't break anything, but it didn't help either.
411 It's confusing to put a bogus integer in a place where the actual
412 value does not matter.
9f62aeb1 413 (LIST_END_P): Remove unused macro and its bogus comment.
cbeff735 414 (make_fixnum_or_float): Remove unnecessary cast to EMACS_INT.
eb49b136 415
15375a22
PE
416 * lisp.h (union Lisp_Object.i): EMACS_INT, not EMACS_UINT.
417 This is for consistency with the ordinary, non-USE_LISP_UNION_TYPE,
418 implementation.
b61cc01c
PE
419 (struct Lisp_Bool_Vector.size): EMACS_INT, not EMACS_UINT.
420 We prefer signed types, and the value cannot exceed the EMACS_INT
421 range anyway (because otherwise the length would not be representable).
9a8e8d9b
PE
422 (XSET) [USE_LISP_UNION_TYPE]: Use uintptr_t and intptr_t,
423 not EMACS_UINT and EMACS_INT, when converting pointer to integer.
424 This avoids a GCC warning when WIDE_EMACS_INT.
15375a22 425
53b2623d
PE
426 * indent.c (sane_tab_width): New function.
427 (current_column, scan_for_column, Findent_to, position_indentation)
428 (compute_motion): Use it. This is just for clarity.
8fcaf9cc 429 (Fcompute_motion): Don't assume hscroll and tab offset fit in int.
53b2623d 430
51cab52b 431 * image.c (xbm_image_p): Don't assume stated width, height fit in int.
45aebb64 432
f2ed8a70
PE
433 * lisp.h (lint_assume): New macro.
434 * composite.c (composition_gstring_put_cache):
435 * ftfont.c (ftfont_shape_by_flt): Use it to pacify GCC 4.6.0.
436
abe80cc6
PE
437 * editfns.c, insdel.c:
438 Omit unnecessary forward decls, to simplify future changes.
a9e860e1 439
b02c740e
PE
440 * ftfont.c (ftfont_shape_by_flt): Use signed integers for lengths.
441
ebc96716
PE
442 * font.c (Ffont_shape_gstring): Don't assume glyph len fits in 'int'.
443
b4e50fa0 444 * fns.c (Ffillarray): Don't assume bool vector size fits in 'int'.
f03dc6ef 445 Use much-faster test for byte-length change.
311d5d7c 446 Don't assume string byte-length fits in 'int'.
a4cf38e4 447 Check that character arg fits in 'int'.
85461888 448 (mapcar1): Declare byte as byte, for clarity.
b4e50fa0 449
c0c1ee9f
PE
450 * alloc.c (Fmake_bool_vector): Avoid unnecessary multiplication.
451
a498d7f4
PE
452 * fns.c (concat): Catch string overflow earlier.
453 Do not rely on integer wraparound.
454
51cab52b
PE
455 * dispextern.h (struct it.overlay_strings_charpos)
456 (struct it.selective): Now EMACS_INT, not int.
87830974
PE
457 * xdisp.c (forward_to_next_line_start)
458 (back_to_previous_visible_line_start)
459 (reseat_at_next_visible_line_start, next_element_from_buffer):
460 Don't arbitrarily truncate the value of 'selective' to int.
461
76031fad
PE
462 * xdisp.c (init_iterator): Use XINT, not XFASTINT; it might be < 0.
463
5eb55db9
PE
464 * composite.c: Don't truncate sizes to 'int'.
465 (composition_gstring_p, composition_reseat_it)
466 (composition_adjust_point): Use EMACS_INT, not int.
7d100a81
PE
467 (get_composition_id, composition_gstring_put_cache): Use EMACS_INT,
468 not EMACS_UINT, for indexes.
5eb55db9 469
0703a717
PE
470 * category.h (CATEGORY_SET_P): Remove unnecessary cast to EMACS_INT.
471
d6202519
PE
472 * buffer.c: Include <verify.h>.
473 (struct sortvec.priority, struct sortstr.priority):
8961a454 474 Now EMACS_INT, not int.
c20998a7 475 (compare_overlays, cmp_for_strings): Avoid subtraction overflow.
67c36fce
PE
476 (struct sortstr.size, record_overlay_string)
477 (struct sortstrlist.size, struct sortlist.used):
478 Don't truncate size to int.
479 (record_overlay_string): Check for size-calculation overflow.
d6202519 480 (init_buffer_once): Check at compile-time, not run-time.
fadf4e30 481
d5a19415
JM
4822011-06-22 Jim Meyering <meyering@redhat.com>
483
029529ac 484 Don't leak an XBM-image-sized buffer
d5a19415
JM
485 * image.c (xbm_load): Free the image buffer after using it.
486
a9041e6c
PE
4872011-06-21 Paul Eggert <eggert@cs.ucla.edu>
488
489 Port to Sun C.
490 * composite.c (find_automatic_composition): Omit needless 'return 0;'
491 that Sun C diagnosed.
492 * fns.c (secure_hash): Fix pointer signedness issue.
493 * intervals.c (static_offset_intervals): New function.
494 (offset_intervals): Use it.
495
7f3f739f
LL
4962011-06-21 Leo Liu <sdl.web@gmail.com>
497
498 * deps.mk (fns.o):
499 * makefile.w32-in ($(BLD)/fns.$(O)): Include sha256.h and
500 sha512.h.
501
502 * fns.c (secure_hash): Rename from crypto_hash_function and change
503 the first arg to accept symbols.
5b66d427 504 (Fsecure_hash): New primitive.
7f3f739f
LL
505 (syms_of_fns): New symbols.
506
76147d94
DD
5072011-06-20 Deniz Dogan <deniz@dogan.se>
508
509 * process.c (Fset_process_buffer): Clarify return value in
510 docstring.
511
7d7d0045
CY
5122011-06-18 Chong Yidong <cyd@stupidchicken.com>
513
514 * dispnew.c (add_window_display_history): Use BVAR.
515
516 * xdisp.c (debug_method_add): Use BVAR.
517 (check_window_end, dump_glyph_matrix, dump_glyph)
518 (dump_glyph_row, dump_glyph_string): Convert arglist to ANSI C.
519
520 * xfaces.c (check_lface_attrs, check_lface, dump_realized_face):
521 Likewise.
522
523 * xfns.c (Fx_create_frame, x_create_tip_frame): Delay image cache
524 check till after the cache is created in init_frame_faces.
525
ff2bc410
SM
5262011-06-17 Stefan Monnier <monnier@iro.umontreal.ca>
527
528 * fns.c (Fsafe_length): Yet another int/Lisp_Object mixup.
529
28177add
PE
5302011-06-16 Paul Eggert <eggert@cs.ucla.edu>
531
dd3482fe
PE
532 * lisp.h: Include <limits.h>, for INT_MAX, LONG_MAX, LLONG_MAX.
533 Without this, prin1 mishandles Lisp_Misc_Save_Value printing on
534 hosts with pre-C99 libraries, because pD is wrongly defined to "t".
535
393d71f3 536 Improve buffer-overflow checking (Bug#8873).
1c8e352f
PE
537 * fileio.c (Finsert_file_contents):
538 * insdel.c (insert_from_buffer_1, replace_range, replace_range_2):
539 Remove the old (too-loose) buffer overflow checks.
540 They weren't needed, since make_gap checks for buffer overflow.
541 * insdel.c (make_gap_larger): Catch buffer overflows that were missed.
542 The old code merely checked for Emacs fixnum overflow, and relied
543 on undefined (wraparound) behavior. The new code avoids undefined
544 behavior, and also checks for ptrdiff_t and/or size_t overflow.
545
2e6813b0 546 * editfns.c (Finsert_char): Don't dump core with very negative counts.
21d890a4
PE
547 Tune. Don't use wider integers than needed. Don't use alloca.
548 Use a bigger 'string' buffer. Rewrite to avoid 'n > 0' test.
2e6813b0 549
599a9e4f
PE
550 * insdel.c (replace_range): Fix buf overflow when insbytes < outgoing.
551
99561444
PE
552 * insdel.c, lisp.h (buffer_overflow): New function.
553 (insert_from_buffer_1, replace_range, replace_range_2):
554 * insdel.c (make_gap_larger):
555 * editfns.c (Finsert_char):
556 * fileio.c (Finsert_file_contents): Use it, to normalize wording.
557
28177add
PE
558 * buffer.h (BUF_BYTES_MAX): Cast to ptrdiff_t so that it's signed.
559
e69dafad
PE
5602011-06-15 Paul Eggert <eggert@cs.ucla.edu>
561
a7af7fde 562 Integer overflow and signedness fixes (Bug#8873).
ff672d2c 563
b1c46f02
PE
564 * ccl.c (ASCENDING_ORDER): New macro, to work around GCC bug 43772.
565 (GET_CCL_RANGE, IN_INT_RANGE): Use it.
566
e69dafad
PE
567 * fileio.c: Don't assume EMACS_INT fits in off_t.
568 (emacs_lseek): New static function.
569 (Finsert_file_contents, Fwrite_region): Use it.
570 Use SEEK_SET, SEEK_CUR, SEEK_END as appropriate.
571
566684ea
PE
572 * fns.c (Fload_average): Don't assume 100 * load average fits in int.
573
e6966cd6
PE
574 * fns.c: Don't overflow int when computing a list length.
575 * fns.c (QUIT_COUNT_HEURISTIC): New constant.
576 (Flength, Fsafe_length): Use EMACS_INT, not int, to avoid unwanted
577 truncation on 64-bit hosts. Check for QUIT every
578 QUIT_COUNT_HEURISTIC entries rather than every other entry; that's
579 faster and is responsive enough.
580 (Flength): Report an error instead of overflowing an integer.
581 (Fsafe_length): Return a float if the value is not representable
582 as a fixnum. This shouldn't happen except in contrived situations.
6346d301 583 (Fnthcdr, Fsort): Don't assume list length fits in int.
de41a810 584 (Fcopy_sequence): Don't assume vector length fits in int.
00c604f2 585
dd0b0efb
PE
586 * alloc.c: Check that resized vectors' lengths fit in fixnums.
587 (header_size, word_size): New constants.
588 (allocate_vectorlike): Don't check size overflow here.
589 (allocate_vector): Check it here instead, since this is the only
590 caller of allocate_vectorlike that could cause overflow.
591 Check that the new vector's length is representable as a fixnum.
592
86fe5cfe
PE
593 * fns.c (next_almost_prime): Don't return a multiple of 3 or 5.
594 The previous code was bogus. For example, next_almost_prime (32)
595 returned 39, which is undesirable as it is a multiple of 3; and
596 next_almost_prime (24) returned 25, which is a multiple of 5 so
597 why was the code bothering to check for multiples of 7?
598
80e88859
PE
599 * bytecode.c (exec_byte_code): Use ptrdiff_t, not int, for vector length.
600
4a2f0ad6
PE
601 * eval.c, doprnt.c (SIZE_MAX): Remove; inttypes.h defines this now.
602
f66c7cf8
PE
603 Variadic C functions now count arguments with ptrdiff_t.
604 This partly undoes my 2011-03-30 change, which replaced int with size_t.
605 Back then I didn't know that the Emacs coding style prefers signed int.
606 Also, in the meantime I found a few more instances where arguments
4a2f0ad6
PE
607 were being counted with int, which may truncate counts on 64-bit
608 machines, or EMACS_INT, which may be unnecessarily wide.
f66c7cf8
PE
609 * lisp.h (struct Lisp_Subr.function.aMANY)
610 (DEFUN_ARGS_MANY, internal_condition_case_n, safe_call):
611 Arg counts are now ptrdiff_t, not size_t.
612 All variadic functions and their callers changed accordingly.
613 (struct gcpro.nvars): Now size_t, not size_t. All uses changed.
614 * bytecode.c (exec_byte_code): Check maxdepth for overflow,
615 to avoid potential buffer overrun. Don't assume arg counts fit in 'int'.
616 * callint.c (Fcall_interactively): Check arg count for overflow,
617 to avoid potential buffer overrun. Use signed char, not 'int',
618 for 'varies' array, so that we needn't bother to check its size
619 calculation for overflow.
620 * editfns.c (Fformat): Use ptrdiff_t, not EMACS_INT, to count args.
621 * eval.c (apply_lambda):
622 * fns.c (Fmapconcat): Use XFASTINT, not XINT, to get args length.
623 (struct textprop_rec.argnum): Now ptrdiff_t, not int. All uses changed.
624 (mapconcat): Use ptrdiff_t, not int and EMACS_INT, to count args.
625
a1759b76
PE
626 * callint.c (Fcall_interactively): Don't use index var as event count.
627
d96be9fc
PE
628 * vm-limit.c (check_memory_limits): Fix incorrect extern function decls.
629 * mem-limits.h (SIZE): Remove; no longer used.
630
a690a978 631 * xterm.c (x_alloc_nearest_color_1): Prefer int to long when int works.
5efd304b 632
578c21e6
PE
633 Remove unnecessary casts.
634 * xterm.c (x_term_init):
635 * xfns.c (x_set_border_pixel):
636 * widget.c (create_frame_gcs): Remove casts to unsigned long etc.
637 These aren't needed now that we assume ANSI C.
638
96f53c6c
PE
639 * sound.c (Fplay_sound_internal): Remove cast to unsigned long.
640 It's more likely to cause problems (due to unsigned overflow)
641 than to cure them.
642
83c77d31
PE
643 * dired.c (Ffile_attributes): Don't use 32-bit hack on 64-bit hosts.
644
ee2079f1
PE
645 * unexelf.c (unexec): Don't assume BSS addr fits in unsigned.
646
6da65536
PE
647 * xterm.c (handle_one_xevent): Omit unnecessary casts to unsigned.
648
7147c4a4
PE
649 * keyboard.c (modify_event_symbol): Don't limit alist len to UINT_MAX.
650
193e32d9
PE
651 * lisp.h (CHAR_TABLE_SET): Omit now-redundant test.
652
e5533da6
PE
653 * lread.c (Fload): Don't compare a possibly-garbage time_t value.
654
9910e595
PE
655 GLYPH_CODE_FACE returns EMACS_INT, not int.
656 * dispextern.h (merge_faces):
657 * xfaces.c (merge_faces):
01103c44
PE
658 * xdisp.c (get_next_display_element, next_element_from_display_vector):
659 Don't assume EMACS_INT fits in int.
9910e595 660
2638320e
PE
661 * character.h (CHAR_VALID_P): Remove unused parameter.
662 * fontset.c, lisp.h, xdisp.c: All uses changed.
663
045eb8d9
PE
664 * editfns.c (Ftranslate_region_internal): Omit redundant test.
665
c1f134b5
PE
666 * fns.c (concat): Minor tuning based on overflow analysis.
667 This doesn't fix any bugs. Use int to hold character, instead
668 of constantly refetching from Emacs object. Use XFASTINT, not
669 XINT, for value known to be a character. Don't bother comparing
670 a single byte to 0400, as it's always less.
671
395fcb93 672 * floatfns.c (Fexpt):
327eeec8
PE
673 * fileio.c (make_temp_name): Omit unnecessary cast to unsigned.
674
abbd3d23
PE
675 * editfns.c (Ftranslate_region_internal): Use int, not EMACS_INT
676 for characters.
677
684a03ef
PE
678 * doc.c (get_doc_string): Omit (unsigned)c that mishandled negatives.
679
0fed43f3
PE
680 * data.c (Faset): If ARRAY is a string, check that NEWELT is a char.
681 Without this fix, on a 64-bit host (aset S 0 4294967386) would
682 incorrectly succeed when S was a string, because 4294967386 was
683 truncated before it was used.
684
8fd02eb7
PE
685 * chartab.c (Fchar_table_range): Use CHARACTERP to check range.
686 Otherwise, an out-of-range integer could cause undefined behavior
687 on a 64-bit host.
688
f8c86b69
PE
689 * composite.c: Use int, not EMACS_INT, for characters.
690 (fill_gstring_body, composition_compute_stop_pos): Use int, not
691 EMACS_INT, for values that are known to be in character range.
692 This doesn't fix any bugs but is the usual style inside Emacs and
693 may generate better code on 32-bit machines.
694
34206dd2
PE
695 Make sure a 64-bit char is never passed to ENCODE_CHAR.
696 This is for reasons similar to the recent CHAR_STRING fix.
697 * charset.c (Fencode_char): Check that character arg is actually
698 a character. Pass an int to ENCODE_CHAR.
699 * charset.h (ENCODE_CHAR): Verify that the character argument is no
700 wider than 'int', as a compile-time check to prevent future regressions
701 in this area.
702
c5958d4c 703 * character.c (char_string): Remove unnecessary casts.
13bdea59
PE
704
705 Make sure a 64-bit char is never passed to CHAR_STRING.
706 Otherwise, CHAR_STRING would do the wrong thing on a 64-bit platform,
707 by silently ignoring the top 32 bits, allowing some values
708 that were far too large to be valid characters.
709 * character.h: Include <verify.h>.
710 (CHAR_STRING, CHAR_STRING_ADVANCE): Verify that the character
711 arguments are no wider than unsigned, as a compile-time check
712 to prevent future regressions in this area.
713 * data.c (Faset):
01103c44 714 * editfns.c (Fchar_to_string, general_insert_function, Finsert_char)
13bdea59
PE
715 (Fsubst_char_in_region):
716 * fns.c (concat):
717 * xdisp.c (decode_mode_spec_coding):
718 Adjust to CHAR_STRING's new requirement.
719 * editfns.c (Finsert_char, Fsubst_char_in_region):
720 * fns.c (concat): Check that character args are actually
721 characters. Without this test, these functions did the wrong
722 thing with wildly out-of-range values on 64-bit hosts.
723
d37ca623
PE
724 Remove incorrect casts to 'unsigned' that lose info on 64-bit hosts.
725 These casts should not be needed on 32-bit hosts, either.
726 * keyboard.c (read_char):
727 * lread.c (Fload): Remove casts to unsigned.
728
ea204efb
PE
729 * lisp.h (UNSIGNED_CMP): New macro.
730 This fixes comparison bugs on 64-bit hosts.
731 (ASCII_CHAR_P): Use it.
732 * casefiddle.c (casify_object):
01103c44 733 * character.h (ASCII_BYTE_P, CHAR_VALID_P)
ea204efb
PE
734 (SINGLE_BYTE_CHAR_P, CHAR_STRING):
735 * composite.h (COMPOSITION_ENCODE_RULE_VALID):
736 * dispextern.h (FACE_FROM_ID):
737 * keyboard.c (read_char): Use UNSIGNED_CMP.
738
41cb286c
PE
739 * xmenu.c (dialog_selection_callback) [!USE_GTK]: Cast to intptr_t,
740 not to EMACS_INT, to avoid GCC warning.
741
4a1b9832
PE
742 * xfns.c (x_set_scroll_bar_default_width): Remove unused 'int' locals.
743
55daad71
PE
744 * buffer.h (PTR_BYTE_POS, BUF_PTR_BYTE_POS): Remove harmful cast.
745 The cast incorrectly truncated 64-bit byte offsets to 32 bits, and
746 isn't needed on 32-bit machines.
8f95c75c 747
01103c44
PE
748 * buffer.c (Fgenerate_new_buffer_name):
749 Use EMACS_INT for count, not int.
0ceccced 750 (advance_to_char_boundary): Return EMACS_INT, not int.
e762cafe
PE
751
752 * data.c (Qcompiled_function): Now static.
753
c6f072e7
PE
754 * window.c (window_body_lines): Now static.
755
20ce5912
PE
756 * image.c (gif_load): Rename local to avoid shadowing.
757
9c4c5f81
PE
758 * lisp.h (SAFE_ALLOCA_LISP): Check for integer overflow.
759 (struct Lisp_Save_Value): Use ptrdiff_t, not int, for 'integer' member.
760 * alloc.c (make_save_value): Integer argument is now of type
761 ptrdiff_t, not int.
762 (mark_object): Use ptrdiff_t, not int.
763 * lisp.h (pD): New macro.
764 * print.c (print_object): Use it.
765
c0c5c8ae
PE
766 * alloc.c: Use EMACS_INT, not int, to count objects.
767 (total_conses, total_markers, total_symbols, total_vector_size)
768 (total_free_conses, total_free_markers, total_free_symbols)
01103c44
PE
769 (total_free_floats, total_floats, total_free_intervals)
770 (total_intervals, total_strings, total_free_strings):
c0c5c8ae
PE
771 Now EMACS_INT, not int. All uses changed.
772 (Fgarbage_collect): Compute overall total using a double, so that
773 integer overflow is less likely to be a problem. Check for overflow
774 when converting back to an integer.
5a25e253
PE
775 (n_interval_blocks, n_string_blocks, n_float_blocks, n_cons_blocks)
776 (n_vectors, n_symbol_blocks, n_marker_blocks): Remove.
777 These were 'int' variables that could overflow on 64-bit hosts;
778 they were never used, so remove them instead of repairing them.
211a0b2a 779 (nzombies, ngcs, max_live, max_zombies): Now EMACS_INT, not 'int'.
6349ae4d
PE
780 (inhibit_garbage_collection): Set gc_cons_threshold to max value.
781 Previously, this ceilinged at INT_MAX, but that doesn't work on
782 64-bit machines.
e46bb31a 783 (allocate_pseudovector): Don't use EMACS_INT when int would do.
c0c5c8ae 784
c78baabf 785 * alloc.c (Fmake_bool_vector): Don't assume vector size fits in int.
86f61a15 786 (allocate_vectorlike): Check for ptrdiff_t overflow.
b6439961
PE
787 (mark_vectorlike, mark_char_table, mark_object): Avoid EMACS_UINT
788 when a (possibly-narrower) signed value would do just as well.
789 We prefer using signed arithmetic, to avoid comparison confusion.
c78baabf 790
c9d624c6
PE
791 * alloc.c: Catch some string size overflows that we were missing.
792 (XMALLOC_OVERRUN_CHECK_SIZE) [!XMALLOC_OVERRUN_CHECK]: Define to 0,
793 for convenience in STRING_BYTES_MAX.
794 (STRING_BYTES_MAX): New macro, superseding the old one in lisp.h.
795 The definition here is exact; the one in lisp.h was approximate.
796 (allocate_string_data): Check for string overflow. This catches
797 some instances we weren't catching before. Also, it catches
798 size_t overflow on (unusual) hosts where SIZE_MAX <= min
799 (PTRDIFF_MAX, MOST_POSITIVE_FIXNUM), e.g., when size_t is 32 bits
800 and ptrdiff_t and EMACS_INT are both 64 bits.
c78baabf 801
c9d624c6
PE
802 * character.c, coding.c, doprnt.c, editfns.c, eval.c:
803 All uses of STRING_BYTES_MAX replaced by STRING_BYTES_BOUND.
804 * lisp.h (STRING_BYTES_BOUND): Renamed from STRING_BYTES_MAX.
805
353032ce
PE
806 * character.c (string_escape_byte8): Fix nbytes/nchars typo.
807
2bccce07
PE
808 * alloc.c (Fmake_string): Check for out-of-range init.
809
0ac30604
SM
8102011-06-15 Stefan Monnier <monnier@iro.umontreal.ca>
811
812 * eval.c (Fdefvaralias): Also mark the target as variable-special-p.
813
c195f2de
JD
8142011-06-14 Jan Djärv <jan.h.d@swipnet.se>
815
816 * xfns.c (x_set_scroll_bar_default_width): Remove argument to
817 xg_get_default_scrollbar_width.
818
819 * gtkutil.c: Include emacsgtkfixed.h if HAVE_GTK3.
820 (int_gtk_range_get_value): Move to the scroll bar part of the file.
821 (style_changed_cb): Call update_theme_scrollbar_width and call
822 x_set_scroll_bar_default_width and xg_frame_set_char_size for
823 all frames (Bug#8505).
824 (xg_create_frame_widgets): Call emacs_fixed_new if HAVE_GTK3 (Bug#8505).
825 Call gtk_window_set_resizable if HAVE_GTK3.
826 (x_wm_set_size_hint): Call emacs_fixed_set_min_size with min width
827 and height if HAVE_GTK3 (Bug#8505).
828 (scroll_bar_width_for_theme): New variable.
829 (update_theme_scrollbar_width): New function.
830 (xg_get_default_scrollbar_width): Move code to
831 update_theme_scrollbar_width, just return scroll_bar_width_for_theme.
832 (xg_initialize): Call update_theme_scrollbar_width.
833
834 * gtkutil.h (xg_get_default_scrollbar_width): Remove argument.
835
836 * emacsgtkfixed.c, emacsgtkfixed.h: New files.
837
e10ac9f1
MR
8382011-06-12 Martin Rudalics <rudalics@gmx.at>
839
840 * frame.c (make_frame): Call other_buffer_safely instead of
841 other_buffer.
842
843 * window.c (temp_output_buffer_show): Call display_buffer with
844 second argument Vtemp_buffer_show_specifiers and reset latter
845 immediately after the call.
846 (Vtemp_buffer_show_specifiers): New variable.
847 (auto_window_vscroll_p, next_screen_context_lines)
848 (Vscroll_preserve_screen_position): Remove leading asterisks from
849 doc-strings.
850
2d3c217e 8512011-06-12 Paul Eggert <eggert@cs.ucla.edu>
4475bec4 852
7b7f97e8 853 Fix minor problems found by GCC 4.6.0 static checking.
4475bec4
PE
854 * buffer.c (Qclone_number): Remove for now, as it's unused.
855 (record_buffer, Funrecord_buffer): Rename local to avoid shadowing.
856 (record_buffer): Remove unused local.
857 * frame.c (other_visible_frames, frame_buffer_list): Now static.
858 (set_frame_buffer_list): Remove; unused.
859 * frame.h (other_visible_frames): Remove decl.
860 * keyboard.h (menu_items_inuse): Declare only if USE_GTK || USE_MOTIF.
861 * lisp.h (frame_buffer_list, set_frame_buffer_list): Remove decls.
862 (add_gpm_wait_descriptor, delete_gpm_wait_descriptor): Declare only
863 if HAVE_GPM.
864 * menu.c (menu_items_inuse): Now static unless USE_GTK || USE_MOTIF.
865 * process.c (add_gpm_wait_descriptor, delete_gpm_wait_descriptor):
866 Define only if HAVE_GPM.
867 * widget.c (EmacsFrameResize, emacsFrameClassRec): Now static.
868 (update_hints_inhibit): Remove; never set. All uses removed.
869 * widgetprv.h (emacsFrameClassRec): Remove decl.
870 * window.c (delete_deletable_window): Now returns void, since it
871 wasn't returning anything.
872 (compare_window_configurations): Remove unused locals.
873 * xfns.c (x_set_scroll_bar_default_width): Remove unused locals.
874 * xmenu.c (x_menu_set_in_use): Define only if USE_GTK || USE_MOTIF.
4475bec4
PE
875 (dialog_selection_callback) [!USE_GTK]: Prefer intptr_t for integers
876 the same widths as pointers. This follows up on the 2011-05-06 patch.
877 * xterm.c (x_alloc_lighter_color_for_widget): Define only if USE_LUCID.
878 * xterm.h: Likewise.
879 (x_menu_set_in_use): Declare only if USE_GTK || USE_MOTIF.
880
1384b89e
JB
8812011-06-12 Juanma Barranquero <lekktu@gmail.com>
882
883 * makefile.w32-in: Update dependencies.
884 (LISP_H): Add lib/intprops.h.
885
1100a63c
CY
8862011-06-11 Chong Yidong <cyd@stupidchicken.com>
887
888 * image.c (gif_load): Add animation frame delay to the metadata.
889 (syms_of_image): Use DEFSYM. New symbol `delay'.
890
6198ccd0
MR
8912011-06-11 Martin Rudalics <rudalics@gmx.at>
892
893 * window.c (delete_deletable_window): Re-add.
894 (Fset_window_configuration): Rewrite to handle dead buffers and
895 consequently deletable windows.
896 (window_tree, Fwindow_tree): Remove. Supply functionality in
897 window.el.
898 (compare_window_configurations): Simplify code.
899
b6e3633c
AS
9002011-06-11 Andreas Schwab <schwab@linux-m68k.org>
901
1ab0dee5
AS
902 * image.c (imagemagick_load_image): Fix type mismatch.
903 (Fimagemagick_types): Likewise.
904
b6e3633c
AS
905 * window.h (replace_buffer_in_windows): Declare.
906
9397e56f
MR
9072011-06-11 Martin Rudalics <rudalics@gmx.at>
908
909 * buffer.c: New Lisp objects Qbuffer_list_update_hook and
910 Qclone_number. Remove external declaration of Qdelete_window.
911 (Fbuffer_list): Rewrite doc-string. Minor restructuring of
912 code.
913 (Fget_buffer_create, Fmake_indirect_buffer, Frename_buffer): Run
914 Qbuffer_list_update_hook if allowed.
915 (Fother_buffer): Rewrite doc-string. Major rewrite for new
916 buffer list implementation.
917 (other_buffer_safely): New function.
918 (Fkill_buffer): Replace call to replace_buffer_in_all_windows by
919 calls to replace_buffer_in_windows and
920 replace_buffer_in_windows_safely. Run Qbuffer_list_update_hook
921 if allowed.
922 (record_buffer): Inhibit quitting and rewrite using quittable
923 functions. Run Qbuffer_list_update_hook if allowed.
924 (Frecord_buffer, Funrecord_buffer): New functions.
925 (switch_to_buffer_1, Fswitch_to_buffer): Remove. Move
926 switch-to-buffer to window.el.
927 (bury-buffer): Move to window.el.
928 (Vbuffer_list_update_hook): New variable.
929
930 * lisp.h (other_buffer_safely): Add prototype in buffer.c
931 section.
932
933 * window.h (resize_frame_windows): Move up in code.
934 (Fwindow_frame): Remove EXFUN.
935 (replace_buffer_in_all_windows): Remove prototype.
936 (replace_buffer_in_windows_safely): Add prototype.
937
938 * window.c: Declare Qdelete_window static again. Move down
939 declaration of select_count.
940 (Fnext_window, Fprevious_window): Rewrite doc-strings.
941 (Fother_window): Move to window.el.
942 (window_loop): Remove DELETE_BUFFER_WINDOWS and UNSHOW_BUFFER
943 cases. Add REPLACE_BUFFER_IN_WINDOWS_SAFELY case.
944 (Fdelete_windows_on, Freplace_buffer_in_windows): Move to
945 window.el.
946 (replace_buffer_in_windows): Implement by calling
947 Qreplace_buffer_in_windows.
948 (replace_buffer_in_all_windows): Remove with some functionality
949 moved into replace_buffer_in_windows_safely.
950 (replace_buffer_in_windows_safely): New function.
951 (select_window_norecord, select_frame_norecord): Move in front
952 of run_window_configuration_change_hook. Remove now obsolete
953 declarations.
954 (Fset_window_buffer): Rewrite doc-string. Call
955 Qrecord_window_buffer.
956 (keys_of_window): Move binding for other-window to window.el.
957
b50691aa
CY
9582011-06-11 Chong Yidong <cyd@stupidchicken.com>
959
960 * dispextern.h (struct image): Replace data member, whose int_val
961 and ptr_val fields were not used by anything, with a single
962 lisp_val object.
963
964 * image.c (Fimage_metadata, make_image, mark_image, tiff_load)
965 (gif_clear_image, gif_load, imagemagick_load_image)
966 (gs_clear_image, gs_load): Callers changed.
967
3f754b86
PE
9682011-06-10 Paul Eggert <eggert@cs.ucla.edu>
969
cca69397
PE
970 * buffer.h: Include <time.h>, for time_t.
971 Needed to build on FreeBSD 8.2. Problem reported by Herbert J. Skuhra.
972
109e28d0
PE
973 Fix minor problems found by static checking.
974
60737f02
PE
975 * image.c (PixelGetMagickColor): Declare if ImageMagick headers don't.
976
4b66faf3
PE
977 Make identifiers static if they are not used in other modules.
978 * data.c (Qcompiled_function, Qframe, Qvector):
979 * image.c (QimageMagick, Qsvg):
980 * minibuf.c (Qmetadata):
981 * window.c (resize_window_check, resize_root_window): Now static.
982 * window.h (resize_window_check, resize_root_window): Remove decls.
983
109e28d0
PE
984 * window.c (window_deletion_count, delete_deletable_window):
985 Remove; unused.
46a4ce9e
PE
986 (window_body_lines): Now static.
987 (Fdelete_other_windows_internal): Mark vars as initialized.
988 Make sure 'resize_failed' is initialized.
989 (run_window_configuration_change_hook): Rename local to avoid shadowing.
990 (resize_window_apply): Remove unused local.
991 * window.h (delete_deletable_window): Remove decl.
992
109e28d0 993 * image.c (gif_load, svg_load_image): Rename locals to avoid shadowing.
33290528
PE
994 (imagemagick_load_image): Fix pointer signedness problem by changing
995 last arg from unsigned char * to char *. All uses changed.
996 Also, fix a local for similar reasons.
997 Remove unused locals. Remove locals to avoid shadowing.
998 (fn_rsvg_handle_free): Remove; unused.
999 (svg_load, svg_load_image): Fix pointer signedness problem.
f7e13da3 1000 (imagemagick_load_image): Don't use garbage pointer image_wand.
33290528 1001
3f754b86
PE
1002 * ftfont.c (ftfont_get_metrics, ftfont_drive_otf): Remove unused locals.
1003
2547adb1
CY
10042011-06-10 Chong Yidong <cyd@stupidchicken.com>
1005
1006 * image.c (gif_load): Fix omitted cast error introduced by
1007 2011-06-06 change.
1008
2c8e37d4
MR
10092011-06-10 Martin Rudalics <rudalics@gmx.at>
1010
1011 * window.h (resize_proportionally, orig_total_lines)
1012 (orig_top_line): Remove from window structure.
1013 (set_window_height, set_window_width, change_window_heights)
1014 (Fdelete_window): Remove prototypes.
1015 (resize_frame_windows): Remove duplicate declaration.
1016
440a42e3
EZ
10172011-06-10 Eli Zaretskii <eliz@gnu.org>
1018
1019 * window.h (resize_frame_windows, resize_window_check)
1020 (delete_deletable_window, resize_root_window)
1021 (resize_frame_windows): Declare prototypes.
1022
1023 * window.c (resize_window_apply): Make definition be "static" to
1024 match the prototype.
1025
562dd5e9
MR
10262011-06-10 Martin Rudalics <rudalics@gmx.at>
1027
1028 * window.c: Remove declarations of Qwindow_size_fixed,
1029 window_min_size_1, window_min_size_2, window_min_size,
1030 size_window, window_fixed_size_p, enlarge_window, delete_window.
1031 Remove static from declaration of Qdelete_window, it's
1032 temporarily needed by Fbury_buffer.
1033 (replace_window): Don't assign orig_top_line and
1034 orig_total_lines.
1035 (Fdelete_window, delete_window): Remove. Window deletion is
1036 handled by window.el.
1037 (window_loop): Remove DELETE_OTHER_WINDOWS case. Replace
1038 Fdelete_window calls with calls to Qdelete_window.
1039 (Fdelete_other_windows): Remove. Deleting other windows is
1040 handled by window.el.
1041 (window_fixed_size_p): Remove. Fixed-sizeness of windows is
1042 handled in window.el.
1043 (window_min_size_2, window_min_size_1, window_min_size): Remove.
1044 Window minimum sizes are handled in window.el.
1045 (shrink_windows, size_window, set_window_height)
1046 (set_window_width, change_window_heights, window_height)
1047 (window_width, CURBEG, CURSIZE, enlarge_window)
1048 (adjust_window_trailing_edge, Fadjust_window_trailing_edge)
1049 (Fenlarge_window, Fshrink_window): Remove. Window resizing is
1050 handled in window.el.
1051 (make_dummy_parent): Rename to make_parent_window and give it a
1052 second argument horflag.
1053 (make_window): Don't set resize_proportionally any more.
1054 (Fsplit_window): Remove. Windows are split in window.el.
1055 (save_restore_action, save_restore_orig_size)
1056 (shrink_window_lowest_first, save_restore_orig_size): Remove.
1057 Resize mini windows in window.el.
1058 (grow_mini_window, shrink_mini_window): Implement by calling
1059 Qresize_root_window_vertically, resize_window_check and
1060 resize_window_apply.
1061 (saved_window, Fset_window_configuration, save_window_save): Do
1062 not handle orig_top_line, orig_total_lines, and
1063 resize_proportionally.
1064 (window_min_height, window_min_width): Move to window.el.
1065 (keys_of_window): Move bindings for delete-other-windows,
1066 split-window, delete-window and enlarge-window to window.el.
1067
1068 * buffer.c: Temporarily extern Qdelete_window.
1069 (Fbury_buffer): Temporarily call Qdelete_window instead of
1070 Fdelete_window (Fbury_buffer will move to window.el soon).
1071
1072 * frame.c (set_menu_bar_lines_1): Remove code handling
1073 orig_top_line and orig_total_lines.
1074
1075 * dispnew.c (adjust_frame_glyphs_initially): Don't use
1076 set_window_height but set heights directly.
1077 (change_frame_size_1): Use resize_frame_windows.
1078
1079 * xdisp.c (init_xdisp): Don't use set_window_height but set
1080 heights directly.
1081
1082 * xfns.c (x_set_menu_bar_lines, x_set_tool_bar_lines): Use
1083 resize_frame_windows instead of change_window_heights and run
1084 run_window_configuration_change_hook.
1085
1086 * w32fns.c (x_set_tool_bar_lines): Use resize_frame_windows
1087 instead of change_window_heights and run
1088 run_window_configuration_change_hook.
1089
1a13852e
MR
10902011-06-09 Martin Rudalics <rudalics@gmx.at>
1091
1092 * window.c (replace_window): Rename second argument REPLACEMENT to
1093 NEW. New third argument SETFLAG. Rewrite.
1094 (delete_window, make_dummy_parent): Call replace_window with
1095 third argument 1.
1096 (window_list_1): Move down in code.
1097 (run_window_configuration_change_hook): Move set_buffer part
1098 before select_frame_norecord part in order to unwind correctly.
1099 Rename count1 to count.
1100 (recombine_windows, delete_deletable_window, resize_root_window)
1101 (Fdelete_other_windows_internal)
1102 (Frun_window_configuration_change_hook, make_parent_window)
1103 (resize_window_check, resize_window_apply, Fresize_window_apply)
1104 (resize_frame_windows, Fsplit_window_internal)
1105 (Fdelete_window_internal, Fresize_mini_window_internal): New
1106 functions.
1107 (syms_of_window): New variables Vwindow_splits and Vwindow_nest.
1108
f3d1777e
MR
11092011-06-08 Martin Rudalics <rudalics@gmx.at>
1110
496e208e
MR
1111 * window.h (window): Add some new members to window structure -
1112 normal_lines, normal_cols, new_total, new_normal, clone_number,
1113 splits, nest, prev_buffers, next_buffers.
1114 (WINDOW_TOTAL_SIZE): Move here from window.c.
b9e809c2 1115 (MIN_SAFE_WINDOW_WIDTH, MIN_SAFE_WINDOW_HEIGHT): Define here.
496e208e 1116
f3d1777e
MR
1117 * window.c (Fwindow_height, Fwindow_width, Fwindow_full_width_p):
1118 Remove.
496e208e
MR
1119 (make_dummy_parent): Set new members of windows structure.
1120 (make_window): Move down in code. Handle new members of window
1121 structure.
1122 (Fwindow_clone_number, Fwindow_splits, Fset_window_splits)
1123 (Fwindow_nest, Fset_window_nest, Fwindow_new_total)
1124 (Fwindow_normal_size, Fwindow_new_normal, Fwindow_prev_buffers)
1125 (Fset_window_prev_buffers, Fwindow_next_buffers)
1126 (Fset_window_next_buffers, Fset_window_clone_number): New
1127 functions.
1128 (Fwindow_hscroll, Fwindow_at, Fwindow_point, Fwindow_start)
1129 (Fwindow_end, Fwindow_line_height, Fset_window_dedicated_p):
1130 Doc-string fixes.
1131 (Fwindow_parameters, Fwindow_parameter, Fset_window_parameter):
1132 Argument WINDOW can be now internal window too.
1133 (Fwindow_use_time): Move up in code.
1134 (Fget_buffer_window): Rename argument FRAME to ALL-FRAMES.
1135 Rewrite doc-string.
1136 (Fset_window_configuration, saved_window)
1137 (Fcurrent_window_configuration, save_window_save): Handle new
1138 members of window structure.
b9e809c2
MR
1139 (WINDOW_TOTAL_SIZE, MIN_SAFE_WINDOW_WIDTH)
1140 (MIN_SAFE_WINDOW_HEIGHT): Move to window.h.
1141 (syms_of_window): New Lisp objects Qrecord_window_buffer,
1142 Qwindow_deletable_p, Qdelete_window, Qreplace_buffer_in_windows,
1143 Qget_mru_window, Qresize_root_window,
1144 Qresize_root_window_vertically, Qsafe, Qabove, Qbelow,
1145 Qauto_buffer_name; staticpro them.
f3d1777e 1146
abde8f8c
MR
11472011-06-07 Martin Rudalics <rudalics@gmx.at>
1148
1149 * window.c (Fwindow_total_size, Fwindow_left_column)
1150 (Fwindow_top_line, window_body_lines, Fwindow_body_size)
1151 (Fwindow_list_1): New functions.
1152 (window_box_text_cols): Replace with window_body_cols.
1153 (Fwindow_width, Fscroll_left, Fscroll_right): Use
1154 window_body_cols instead of window_box_text_cols.
fa8a67e6
MR
1155 (delete_window, Fset_window_configuration): Call
1156 delete_all_subwindows with window as argument.
1157 (delete_all_subwindows): Take a window as argument and not a
1158 structure. Rewrite.
190b47e6
MR
1159 (window_loop): Remove handling of GET_LRU_WINDOW and
1160 GET_LARGEST_WINDOW.
1161 (Fget_lru_window, Fget_largest_window): Move to window.el.
abde8f8c
MR
1162
1163 * window.h: Extern window_body_cols instead of
fa8a67e6
MR
1164 window_box_text_cols. delete_all_subwindows now takes a
1165 Lisp_Object as argument.
abde8f8c
MR
1166
1167 * indent.c (compute_motion, Fcompute_motion): Use
1168 window_body_cols instead of window_box_text_cols.
1169
fa8a67e6
MR
1170 * frame.c (delete_frame): Call delete_all_subwindows with root
1171 window as argument.
1172
a54e3482
DC
11732011-06-07 Daniel Colascione <dan.colascione@gmail.com>
1174
1175 * fns.c (Fputhash): Document return value.
1176
60002bf5
CY
11772011-06-06 Chong Yidong <cyd@stupidchicken.com>
1178
1179 * image.c (gif_load): Implement gif89a spec "no disposal" method.
1180
0c671da6 11812011-06-06 Paul Eggert <eggert@cs.ucla.edu>
ccd9a01a 1182
b862a52a 1183 Cons<->int and similar integer overflow fixes (Bug#8794).
77984278 1184
be44ca6c
PE
1185 Check for overflow when converting integer to cons and back.
1186 * charset.c (Fdefine_charset_internal, Fdecode_char):
1187 Use cons_to_unsigned to catch overflow.
1188 (Fencode_char): Use INTEGER_TO_CONS.
1189 * composite.h (LGLYPH_CODE): Use cons_to_unsigned.
1190 (LGLYPH_SET_CODE): Use INTEGER_TO_CONS.
1191 * data.c (long_to_cons, cons_to_long): Remove.
1192 (cons_to_unsigned, cons_to_signed): New functions.
1193 These signal an error for invalid or out-of-range values.
1194 * dired.c (Ffile_attributes): Use INTEGER_TO_CONS.
1195 * fileio.c (Fset_visited_file_modtime): Use CONS_TO_INTEGER.
1196 * font.c (Ffont_variation_glyphs):
1197 * fontset.c (Finternal_char_font): Use INTEGER_TO_CONS.
1198 * lisp.h: Include <intprops.h>.
1199 (INTEGER_TO_CONS, CONS_TO_INTEGER): New macros.
1200 (cons_to_signed, cons_to_unsigned): New decls.
1201 (long_to_cons, cons_to_long): Remove decls.
1202 * undo.c (record_first_change): Use INTEGER_TO_CONS.
1203 (Fprimitive_undo): Use CONS_TO_INTEGER.
1204 * xfns.c (Fx_window_property): Likewise.
1205 * xselect.c: Include <limits.h>.
1206 (x_own_selection, selection_data_to_lisp_data):
1207 Use INTEGER_TO_CONS.
1208 (x_handle_selection_request, x_handle_selection_clear)
1209 (x_get_foreign_selection, Fx_disown_selection_internal)
1210 (Fx_get_atom_name, x_send_client_event): Use CONS_TO_INTEGER.
1211 (lisp_data_to_selection_data): Use cons_to_unsigned.
1212 (x_fill_property_data): Use cons_to_signed.
1213 Report values out of range.
1214
d1f3d2af
PE
1215 Check for buffer and string overflow more precisely.
1216 * buffer.h (BUF_BYTES_MAX): New macro.
1217 * lisp.h (STRING_BYTES_MAX): New macro.
1218 * alloc.c (Fmake_string):
1219 * character.c (string_escape_byte8):
1220 * coding.c (coding_alloc_by_realloc):
1221 * doprnt.c (doprnt):
1222 * editfns.c (Fformat):
1223 * eval.c (verror):
1224 Use STRING_BYTES_MAX, not MOST_POSITIVE_FIXNUM,
1225 since they may not be the same number.
1226 * editfns.c (Finsert_char):
1227 * fileio.c (Finsert_file_contents):
1228 Likewise for BUF_BYTES_MAX.
1229
dd52fcea
PE
1230 * image.c: Use ptrdiff_t, not int, for sizes.
1231 (slurp_file): Switch from int to ptrdiff_t.
1232 All uses changed.
1233 (slurp_file): Check that file size fits in both size_t (for
1234 malloc) and ptrdiff_t (for sanity and safety).
1235
7f9bbdbb
PE
1236 * fileio.c (Fverify_visited_file_modtime): Avoid time overflow
1237 if b->modtime has its maximal value.
1238
dfe18f82
PE
1239 * dired.c (Ffile_attributes): Don't assume EMACS_INT has >32 bits.
1240
84acfcf0
PE
1241 Don't assume time_t can fit into int.
1242 * buffer.h (struct buffer.modtime): Now time_t, not int.
1243 * fileio.c (Fvisited_file_modtime): No need for time_t cast now.
1244 * undo.c (Fprimitive_undo): Use time_t, not int, for time_t value.
1245
ccd9a01a
PE
1246 Minor fixes for signed vs unsigned integers.
1247 * character.h (MAYBE_UNIFY_CHAR):
1248 * charset.c (maybe_unify_char):
1249 * keyboard.c (read_char, reorder_modifiers):
1250 XINT -> XFASTINT, since the integer must be nonnegative.
1251 * ftfont.c (ftfont_spec_pattern):
1252 * keymap.c (access_keymap, silly_event_symbol_error):
1253 XUINT -> XFASTINT, since the integer must be nonnegative.
1254 (Fsingle_key_description, preferred_sequence_p): XUINT -> XINT,
1255 since it makes no difference and we prefer signed.
1256 * keyboard.c (record_char): Use XUINT when all the neighbors do.
1257 (access_keymap): NATNUMP -> INTEGERP, since the integer must be
1258 nonnegative.
1259
d6d100dd
SM
12602011-06-06 Stefan Monnier <monnier@iro.umontreal.ca>
1261
1262 * window.h (Fwindow_frame): Declare.
1263
2b6148e4
PE
12642011-06-06 Paul Eggert <eggert@cs.ucla.edu>
1265
1266 * alloc.c: Simplify handling of large-request failures (Bug#8800).
1267 (SPARE_MEMORY): Always define.
1268 (LARGE_REQUEST): Remove.
1269 (memory_full): Use SPARE_MEMORY rather than LARGE_REQUEST.
1270
f230ecc9
MR
12712011-06-06 Martin Rudalics <rudalics@gmx.at>
1272
727e958e
MR
1273 * lisp.h: Move EXFUNS for Fframe_root_window,
1274 Fframe_first_window and Fset_frame_selected_window to window.h.
1275
1276 * window.h: Move EXFUNS for Fframe_root_window,
1277 Fframe_first_window and Fset_frame_selected_window here from
1278 lisp.h.
1279
1280 * frame.c (Fwindow_frame, Fframe_first_window)
1281 (Fframe_root_window, Fframe_selected_window)
1282 (Fset_frame_selected_window): Move to window.c.
1283 (Factive_minibuffer_window): Move to minibuf.c.
1284 (Fother_visible_frames_p): New function.
1285
1286 * minibuf.c (Factive_minibuffer_window): Move here from frame.c.
1287
f230ecc9
MR
1288 * window.c (decode_window, decode_any_window): Move up in code.
1289 (Fwindowp, Fwindow_live_p): Rewrite doc-strings.
1290 (inhibit_frame_unsplittable): Remove unused variable.
bf60a96b
MR
1291 (Fwindow_buffer): Move up and rewrite doc-string.
1292 (Fwindow_parent, Fwindow_vchild, Fwindow_hchild, Fwindow_next)
1293 (Fwindow_prev): New functions.
727e958e
MR
1294 (Fwindow_frame): Move here from frame.c. Accept any window as
1295 argument.
1296 (Fframe_root_window, Fframe_first_window)
1297 (Fframe_selected_window): Move here from frame.c. Accept frame
1298 or arbitrary window as argument. Update doc-strings.
1299 (Fminibuffer_window): Move up in code.
1300 (Fwindow_minibuffer_p): Move up in code and simplify.
d6d100dd
SM
1301 (Fset_frame_selected_window): Move here from frame.c.
1302 Marginal rewrite.
727e958e
MR
1303 (Fselected_window, select_window, Fselect_window): Move up in
1304 code. Minor doc-string fixes.
f230ecc9 1305
4d09bcf6
PE
13062011-06-06 Paul Eggert <eggert@cs.ucla.edu>
1307
1308 * alloc.c (memory_full) [SYSTEM_MALLOC]: Port to MacOS (Bug#8800).
1309 Do not assume that spare memory exists; that assumption is valid
1310 only if SYSTEM_MALLOC.
1311 (LARGE_REQUEST): New macro, so that the issue of large requests
1312 is separated from the issue of spare memory.
1313
810928a2
AS
13142011-06-05 Andreas Schwab <schwab@linux-m68k.org>
1315
172418ad
AS
1316 * editfns.c (Fformat): Correctly handle zero flag with hexadecimal
1317 format. (Bug#8806)
1318
43f862f7
AS
1319 * gtkutil.c (xg_get_default_scrollbar_width): Avoid warning.
1320
810928a2
AS
1321 * xfns.c (x_set_scroll_bar_default_width): Move declarations
1322 before statements.
1323
a059fe24
JD
13242011-06-05 Jan Djärv <jan.h.d@swipnet.se>
1325
1326 * gtkutil.c (xg_get_default_scrollbar_width): New function.
1327
1328 * gtkutil.h: Declare xg_get_default_scrollbar_width.
1329
1330 * xfns.c (x_set_scroll_bar_default_width): If USE_GTK, get
1331 min width by calling x_set_scroll_bar_default_width (Bug#8505).
1332
989bf368
JB
13332011-06-05 Juanma Barranquero <lekktu@gmail.com>
1334
1335 * xdisp.c (single_display_spec_intangible_p): Remove declaration.
1336
4b80f674
CY
13372011-06-04 Chong Yidong <cyd@stupidchicken.com>
1338
1339 * xselect.c (x_clipboard_manager_save): Remove redundant arg.
1340 (x_clipboard_manager_save): Add return value.
d6d100dd
SM
1341 (x_clipboard_manager_error_1, x_clipboard_manager_error_2):
1342 New error handlers.
4b80f674
CY
1343 (x_clipboard_manager_save_frame, x_clipboard_manager_save_all):
1344 Obey Vx_select_enable_clipboard_manager. Catch errors in
1345 x_clipboard_manager_save (Bug#8779).
1346 (Vx_select_enable_clipboard_manager): New variable.
de65b42c 1347 (x_get_foreign_selection): Reduce scope of x_catch_errors (Bug#8790).
4b80f674 1348
99a33b77 13492011-06-04 Dan Nicolaescu <dann@ics.uci.edu>
8b3115e7
DN
1350
1351 * emacs.c (main): Warn when starting a GTK emacs in daemon mode.
1352
99a33b77 13532011-06-04 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
14eca62f
YM
1354
1355 * fringe.c (update_window_fringes): Don't update overlay arrow bitmap
1356 in the current matrix if keep_current_p is non-zero.
1357
8264569d
EZ
13582011-06-04 Eli Zaretskii <eliz@gnu.org>
1359
1360 * bidi.c (bidi_level_of_next_char): Fix last change.
1361
57f97249
EZ
13622011-06-03 Eli Zaretskii <eliz@gnu.org>
1363
fec2107c 1364 Support bidi reordering of text covered by display properties.
57f97249 1365
fec2107c
EZ
1366 * bidi.c (bidi_copy_it): Use offsetof instead of emulating it.
1367 (bidi_fetch_char, bidi_fetch_char_advance): New functions.
1368 (bidi_cache_search, bidi_cache_iterator_state)
1369 (bidi_paragraph_init, bidi_resolve_explicit, bidi_resolve_weak)
d6d100dd
SM
1370 (bidi_level_of_next_char, bidi_move_to_visually_next):
1371 Support character positions inside a run of characters covered by a
fec2107c
EZ
1372 display string.
1373 (bidi_paragraph_init, bidi_resolve_explicit_1)
1374 (bidi_level_of_next_char): Call bidi_fetch_char and
1375 bidi_fetch_char_advance instead of FETCH_CHAR and
1376 FETCH_CHAR_ADVANCE.
1377 (bidi_init_it): Initialize new members.
1378 (LRE_CHAR, RLE_CHAR, PDF_CHAR, LRO_CHAR, RLO_CHAR): Remove macro
1379 definitions.
1380 (bidi_explicit_dir_char): Lookup character type in bidi_type_table,
1381 instead of using explicit *_CHAR codes.
d6d100dd
SM
1382 (bidi_resolve_explicit, bidi_resolve_weak):
1383 Use FETCH_MULTIBYTE_CHAR instead of FETCH_CHAR, as reordering of
fec2107c
EZ
1384 bidirectional text is supported only in multibyte buffers.
1385 (bidi_init_it): Accept additional argument FRAME_WINDOW_P and use
1386 it to initialize the frame_window_p member of struct bidi_it.
1387 (bidi_cache_iterator_state, bidi_resolve_explicit_1)
1388 (bidi_resolve_explicit, bidi_resolve_weak)
1389 (bidi_level_of_next_char, bidi_move_to_visually_next): Abort if
1390 bidi_it->nchars is non-positive.
1391 (bidi_level_of_next_char): Don't try to lookup the cache for the
1392 next/previous character if nothing is cached there yet, or if we
1393 were just reseat()'ed to a new position.
c40e2fb2 1394
0e14fe90
EZ
1395 * xdisp.c (set_cursor_from_row): Set start and stop points
1396 according to the row's direction when priming the loop that looks
1397 for the glyph on which to display cursor.
1398 (single_display_spec_intangible_p): Function deleted.
1399 (display_prop_intangible_p): Reimplement to call
1400 handle_display_spec instead of single_display_spec_intangible_p.
d6d100dd
SM
1401 Accept 3 additional arguments needed by handle_display_spec.
1402 This fixes incorrect cursor motion across display property with complex
0e14fe90
EZ
1403 values: lists, `(when COND...)' forms, etc.
1404 (single_display_spec_string_p): Support property values that are
1405 lists with the argument STRING its top-level element.
1406 (display_prop_string_p): Fix the condition for processing a
1407 property that is a list to be consistent with handle_display_spec.
fec2107c 1408 (handle_display_spec): New function, refactored from the
fc6f18ce
EZ
1409 last portion of handle_display_prop.
1410 (compute_display_string_pos): Accept additional argument
1411 FRAME_WINDOW_P. Call handle_display_spec to determine whether the
1412 value of a `display' property is a "replacing spec".
1413 (handle_single_display_spec): Accept 2 additional arguments BUFPOS
1414 and FRAME_WINDOW_P. If IT is NULL, don't set up the iterator from
1415 the display property, but just return a value indicating whether
1416 the display property will replace the characters it covers.
1417 (Fcurrent_bidi_paragraph_direction): Initialize the nchars and
1418 frame_window_p members of struct bidi_it.
d6d100dd
SM
1419 (compute_display_string_pos, compute_display_string_end):
1420 New functions.
fec2107c
EZ
1421 (push_it): Accept second argument POSITION, where pop_it should
1422 jump to continue iteration.
1423 (reseat_1): Initialize bidi_it.disp_pos.
fc6f18ce 1424
fec2107c
EZ
1425 * keyboard.c (adjust_point_for_property): Adjust the call to
1426 display_prop_intangible_p to its new signature.
fc6f18ce
EZ
1427
1428 * dispextern.h (struct bidi_it): New member frame_window_p.
fec2107c
EZ
1429 (bidi_init_it): Update prototypes.
1430 (display_prop_intangible_p): Update prototype.
d6d100dd
SM
1431 (compute_display_string_pos, compute_display_string_end):
1432 Declare prototypes.
fec2107c
EZ
1433 (struct bidi_it): New members nchars and disp_pos. ch_len is now
1434 EMACS_INT.
fc6f18ce 1435
40087514 14362011-06-02 Paul Eggert <eggert@cs.ucla.edu>
0de4bb68 1437
57f53182
PE
1438 Malloc failure behavior now depends on size of allocation.
1439 * alloc.c (buffer_memory_full, memory_full): New arg NBYTES.
1440 * lisp.h: Change signatures accordingly.
1441 * alloc.c, buffer.c, editfns.c, menu.c, minibuf.c, xterm.c:
1442 All callers changed. (Bug#8762)
1443
1444 * gnutls.c: Use Emacs's memory allocators.
1445 Without this change, the gnutls library would invoke malloc etc.
1446 directly, which causes problems on non-SYNC_INPUT hosts, and which
1447 runs afoul of improving memory_full behavior. (Bug#8761)
1448 (fn_gnutls_global_set_mem_functions): New macro or function pointer.
1449 (emacs_gnutls_global_init): Use it to specify xmalloc, xrealloc,
1450 xfree instead of the default malloc, realloc, free.
1451 (Fgnutls_boot): No need to check for memory allocation failure,
1452 since xmalloc does that for us.
1453
ac32cd99 1454 Remove arbitrary limit of 2**31 entries in hash tables. (Bug#8771)
3870d916
PE
1455 * category.c (hash_get_category_set):
1456 * ccl.c (ccl_driver):
1457 * charset.c (Fdefine_charset_internal):
1458 * charset.h (struct charset.hash_index):
1459 * composite.c (get_composition_id, gstring_lookup_cache)
1460 (composition_gstring_put_cache):
1461 * composite.h (struct composition.hash_index):
1462 * dispextern.h (struct image.hash):
1463 * fns.c (next_almost_prime, larger_vector, cmpfn_eql)
1464 (cmpfn_equal, cmpfn_user_defined, hashfn_eq, hashfn_eql)
1465 (hashfn_equal, hashfn_user_defined, make_hash_table)
1466 (maybe_resize_hash_table, hash_lookup, hash_put)
1467 (hash_remove_from_table, hash_clear, sweep_weak_table, SXHASH_COMBINE)
1468 (sxhash_string, sxhash_list, sxhash_vector, sxhash_bool_vector)
1469 (Fsxhash, Fgethash, Fputhash, Fmaphash):
1470 * image.c (make_image, search_image_cache, lookup_image)
1471 (xpm_put_color_table_h):
1472 * lisp.h (struct Lisp_Hash_Table):
0de4bb68 1473 * minibuf.c (Ftry_completion, Fall_completions, Ftest_completion):
3870d916
PE
1474 * print.c (print): Use 'EMACS_UINT' and 'EMACS_INT'
1475 for hashes and hash indexes, instead of 'unsigned' and 'int'.
40087514
PE
1476 * alloc.c (allocate_vectorlike):
1477 Check for overflow in vector size calculations.
1478 * ccl.c (ccl_driver):
1479 Check for overflow when converting EMACS_INT to int.
0de4bb68
PE
1480 * fns.c, image.c: Remove unnecessary static decls that would otherwise
1481 need to be updated by these changes.
40087514
PE
1482 * fns.c (make_hash_table, maybe_resize_hash_table):
1483 Check for integer overflow with large hash tables.
0de4bb68
PE
1484 (make_hash_table, maybe_resize_hash_table, Fmake_hash_table):
1485 Prefer the faster XFLOAT_DATA to XFLOATINT where either will do.
1486 (SXHASH_REDUCE): New macro.
1487 (sxhash_string, sxhash_list, sxhash_vector, sxhash_bool_vector):
1488 Use it instead of discarding useful hash info with large hash values.
1489 (sxhash_float): New function.
1490 (sxhash): Use it. No more need for "& INTMASK" due to above changes.
1491 * lisp.h (FIXNUM_BITS): New macro, useful for SXHASH_REDUCE etc.
40087514
PE
1492 (MOST_NEGATIVE_FIXNUM, MOST_POSITIVE_FIXNUM, INTMASK):
1493 Rewrite to use FIXNUM_BITS, as this simplifies things.
0de4bb68
PE
1494 (next_almost_prime, larger_vector, sxhash, hash_lookup, hash_put):
1495 Adjust signatures to match updated version of code.
1496 (consing_since_gc): Now EMACS_INT, since a single hash table can
1497 use more than INT_MAX bytes.
1498
698d32e2
DN
14992011-06-01 Dan Nicolaescu <dann@ics.uci.edu>
1500
1501 Make it possible to build with GCC-4.6+ -O2 -flto.
1502
1503 * emacs.c (__malloc_initialize_hook): Mark as EXTERNALLY_VISIBLE.
1504
fd6fa53f
SM
15052011-06-01 Stefan Monnier <monnier@iro.umontreal.ca>
1506
1507 * minibuf.c (get_minibuffer, read_minibuf_unwind):
1508 Call minibuffer-inactive-mode.
1509
864db017
JB
15102011-05-31 Juanma Barranquero <lekktu@gmail.com>
1511
1512 * makefile.w32-in ($(BLD)/data.$(O), $(BLD)/editfns.$(O)):
1513 Update dependencies.
1514
2ad0baf4
DN
15152011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
1516
1517 * data.c (init_data): Remove code for UTS, this system is not
1518 supported anymore.
1519
4fcc2638
DN
15202011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
1521
1522 Don't force ./temacs to start in terminal mode.
1523
1524 * frame.c (make_initial_frame): Initialize faces in all cases, not
1525 only when CANNOT_DUMP is defined.
1526 * dispnew.c (init_display): Remove CANNOT_DUMP condition.
1527
c56e0fd5
DN
15282011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
1529
1530 * dispnew.c (add_window_display_history): Use const for the string
1531 pointer. Remove declaration, not needed.
1532
333d54da 15332011-05-31 Paul Eggert <eggert@cs.ucla.edu>
9cf9f756 1534
55d4c1b2 1535 Use 'inline', not 'INLINE'.
333d54da 1536 <http://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00914.html>
55d4c1b2
PE
1537 * alloc.c, fontset.c (INLINE): Remove.
1538 * alloc.c, bidi.c, charset.c, coding.c, dispnew.c, fns.c, image.c:
1539 * intervals.c, keyboard.c, process.c, syntax.c, textprop.c, w32term.c:
1540 * xdisp.c, xfaces.c, xterm.c: Replace all uses of INLINE with inline.
1541 * gmalloc.c (register_heapinfo): Use inline unconditionally.
1542 * lisp.h (LISP_MAKE_RVALUE): Use inline, not __inline__.
1543
738db178
DN
15442011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
1545
1546 Make it possible to run ./temacs.
1547
1548 * callproc.c (set_initial_environment): Remove CANNOT_DUMP code,
1549 syms_of_callproc does the same thing. Remove test for
1550 "initialized", do it in the caller.
1551 * emacs.c (main): Avoid calling set_initial_environment when dumping.
1552
620c53a6
SM
15532011-05-31 Stefan Monnier <monnier@iro.umontreal.ca>
1554
1555 * minibuf.c (Finternal_complete_buffer): Return `category' metadata.
1556 (read_minibuf): Use get_minibuffer.
1557 (syms_of_minibuf): Use DEFSYM.
1558 (Qmetadata): New var.
1559 * data.c (Qbuffer): Don't make it static.
1560 (syms_of_data): Use DEFSYM.
1561
e003a292
PE
15622011-05-31 Paul Eggert <eggert@cs.ucla.edu>
1563
1564 * ccl.c (CCL_CODE_RANGE): Allow negative numbers. (Bug#8751)
1565 (CCL_CODE_MIN): New macro.
1566
ed008a6d
PE
15672011-05-30 Paul Eggert <eggert@cs.ucla.edu>
1568
3687c2ef
PE
1569 * alloc.c (lisp_align_malloc): Omit unnecessary val==NULL tests.
1570
ed008a6d
PE
1571 * eval.c (Qdebug): Now static.
1572 * lisp.h (Qdebug): Remove decl. This reverts a part of the
1573 2011-04-26T11:26:05Z!dan.colascione@gmail.com that inadvertently undid part of
1574 2011-04-14T06:48:41Z!eggert@cs.ucla.edu.
1575
d66c4c7c
CY
15762011-05-29 Chong Yidong <cyd@stupidchicken.com>
1577
1578 * image.c: Various fixes to ImageMagick code comments.
1579 (Fimagemagick_types): Doc fix.
1580
5fbc2025
PE
15812011-05-29 Paul Eggert <eggert@cs.ucla.edu>
1582
0196f88a
PE
1583 Minor fixes prompted by GCC 4.6.0 warnings.
1584
1585 * xselect.c (converted_selections, conversion_fail_tag): Now static.
1586
5fbc2025
PE
1587 * emacs.c [HAVE_X_WINDOWS]: Include "xterm.h".
1588 (x_clipboard_manager_save_all): Move extern decl to ...
1589 * xterm.h: ... here, so that it can be checked for consistency.
1590
1dd3c2d9
CY
15912011-05-29 Chong Yidong <cyd@stupidchicken.com>
1592
1593 * xselect.c (x_clipboard_manager_save_frame)
1594 (x_clipboard_manager_save_all): New functions.
1595 (Fx_clipboard_manager_save): Lisp function deleted.
1596
1597 * emacs.c (Fkill_emacs): Call x_clipboard_manager_save_all.
1598 * frame.c (delete_frame): Call x_clipboard_manager_save_frame.
1599
1600 * xterm.h: Update prototype.
1601
5ba6571d
WX
16022011-05-28 William Xu <william.xwl@gmail.com>
1603
1604 * nsterm.m (ns_term_shutdown): Synchronize user defaults before
1605 exiting (Bug#8239).
1606
3eaff834
JM
16072011-05-28 Jim Meyering <meyering@redhat.com>
1608
e1900994 1609 Avoid a sign-extension bug in crypto_hash_function.
3eaff834
JM
1610 * fns.c (to_uchar): Define.
1611 (crypto_hash_function): Use it to convert some newly-signed
1612 variables to unsigned, to avoid sign-extension bugs. For example,
1613 without this change, (md5 "truc") would evaluate to
1614 45723a2aff78ff4fff7fff1114760e62 rather than the expected
1615 45723a2af3788c4ff17f8d1114760e62. Reported by Antoine Levitt in
e1900994 1616 https://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00883.html.
3eaff834 1617
0f6990a7
PE
16182011-05-27 Paul Eggert <eggert@cs.ucla.edu>
1619
1620 Integer overflow fixes.
c8a9ca5a 1621
08686060
PE
1622 * dbusbind.c: Serial number integer overflow fixes.
1623 (CHECK_DBUS_SERIAL_GET_SERIAL): New macro.
08686060
PE
1624 (Fdbus_call_method_asynchronously, xd_read_message_1): Use a float
1625 to hold a serial number that is too large for a fixnum.
1626 (Fdbus_method_return_internal, Fdbus_method_error_internal):
1627 Check for serial numbers out of range. Decode any serial number
59568bf0 1628 that was so large that it became a float. (Bug#8722)
08686060 1629
2d1fc3c7
PE
1630 * dbusbind.c: Use XFASTINT rather than XUINT, and check for nonneg.
1631 (Fdbus_call_method, Fdbus_call_method_asynchronously):
1632 Use XFASTINT rather than XUINT when numbers are nonnegative.
1633 (xd_append_arg, Fdbus_method_return_internal):
1634 (Fdbus_method_error_internal): Likewise. Also, for unsigned
1635 arguments, check that Lisp number is nonnegative, rather than
59568bf0 1636 silently wrapping negative numbers around. (Bug#8722)
30217ff0 1637 (xd_read_message_1): Don't assume dbus_uint32_t can fit in int.
59568bf0 1638 (Bug#8722)
2d1fc3c7 1639
c8a9ca5a
PE
1640 * data.c (arith_driver, Flsh): Avoid unnecessary casts to EMACS_UINT.
1641
519e1d69
PE
1642 * ccl.c (ccl_driver): Redo slightly to avoid the need for 'unsigned'.
1643
30569699
PE
1644 ccl: add integer overflow checks
1645 * ccl.c (CCL_CODE_MAX, GET_CCL_RANGE, GET_CCL_CODE, GET_CCL_INT):
1646 (IN_INT_RANGE): New macros.
1647 (ccl_driver): Use them to check for integer overflow when
1648 decoding a CCL program. Many of the new checks are whether XINT (x)
1649 fits in int; it doesn't always, on 64-bit hosts. The new version
1650 doesn't catch all possible integer overflows, but it's an
847044ea 1651 improvement. (Bug#8719)
30569699 1652
c11285dc
PE
1653 * alloc.c (make_event_array): Use XINT, not XUINT.
1654 There's no need for unsigned here.
1655
fdccd48e
PE
1656 * mem-limits.h (EXCEEDS_LISP_PTR) [!USE_LSB_TAG]: EMACS_UINT -> uintptr_t
1657 This follows up to the 2011-05-06 change that substituted uintptr_t
1658 for EMACS_INT. This case wasn't caught back then.
1659
37910ab2
PE
1660 Rework Fformat to avoid integer overflow issues.
1661 * editfns.c: Include <float.h> unconditionally, as it's everywhere
1662 now (part of C89). Include <verify.h>.
1663 (MAX_10_EXP, CONVERTED_BYTE_SIZE): Remove; no longer needed.
1664 (pWIDE, pWIDElen, signed_wide, unsigned_wide): New defns.
1665 (Fformat): Avoid the prepass trying to compute sizes; it was only
1666 approximate and thus did not catch overflow reliably. Instead, walk
1667 through the format just once, formatting and computing sizes as we go,
1668 checking for integer overflow at every step, and allocating a larger
1669 buffer as needed. Keep track separately whether the format is
1670 multibyte. Keep only the most-recently calculated precision, rather
1671 than them all. Record whether each argument has been converted to
1672 string. Use EMACS_INT, not int, for byte and char and arg counts.
1673 Support field widths and precisions larger than INT_MAX. Avoid
1674 sprintf's undefined behavior with conversion specifications such as %#d
1675 and %.0c. Fix bug with strchr succeeding on '\0' when looking for
1676 flags. Fix bug with (format "%c" 256.0). Avoid integer overflow when
1677 formatting out-of-range floating point numbers with int
1678 formats. (Bug#8668)
1679
2e6578fb
PE
1680 * lisp.h (FIXNUM_OVERFLOW_P): Work even if arg is a NaN.
1681
0ae6bdee
PE
1682 * data.c: Avoid integer truncation in expressions involving floats.
1683 * data.c: Include <intprops.h>.
1684 (arith_driver): When there's an integer overflow in an expression
1685 involving floating point, convert the integers to floating point
1686 so that the resulting value does not suffer from catastrophic
1687 integer truncation. For example, on a 64-bit host (* 4
1688 most-negative-fixnum 0.5) should yield about -4.6e+18, not zero.
1689 Do not rely on undefined behavior after integer overflow.
1690
de883a70
PE
1691 merge count_size_as_multibyte, parse_str_to_multibyte
1692 * character.c, character.h (count_size_as_multibyte):
fd6fa53f 1693 Rename from parse_str_to_multibyte; all uses changed.
de883a70
PE
1694 Check for integer overflow.
1695 * insdel.c, lisp.h (count_size_as_multibyte): Remove,
1696 since it's now a duplicate of the other. This is more of
1697 a character than a buffer op, so better that it's in character.c.
1698 * fns.c, print.c: Adjust to above changes.
1699
2ff916cb
PE
17002011-05-27 Stefan Monnier <monnier@iro.umontreal.ca>
1701
1702 * xselect.c (x_convert_selection): Yet another int/Lisp_Object mixup.
1703
f1b54466
PE
17042011-05-27 Paul Eggert <eggert@cs.ucla.edu>
1705
fb1ac845
PE
1706 * xselect.c: Fix minor problems prompted by GCC 4.6.0 warnings.
1707 (x_handle_selection_request, frame_for_x_selection): Remove unused vars.
1708 (x_clipboard_manager_save): Now static.
1709 (Fx_clipboard_manager_save): Rename local to avoid shadowing.
1710
f1b54466
PE
1711 * fns.c: Fix minor problems prompted by GCC 4.6.0 warnings.
1712 (crypto_hash_function): Now static.
1713 Fix pointer signedness problems. Avoid unnecessary initializations.
1714
a9f737ee
CY
17152011-05-27 Chong Yidong <cyd@stupidchicken.com>
1716
1717 * termhooks.h (Vselection_alist): Make it terminal-local.
1718
1719 * terminal.c (create_terminal): Initialize it.
1720
1721 * xselect.c: Support for clipboard managers.
1722 (Vselection_alist): Move to termhooks.h as terminal-local var.
1723 (LOCAL_SELECTION): New macro.
1724 (x_atom_to_symbol): Handle x_display_info_for_display fail case.
1725 (symbol_to_x_atom): Remove gratuitous arg.
1726 (x_handle_selection_request, lisp_data_to_selection_data)
1727 (x_get_foreign_selection, Fx_register_dnd_atom): Callers changed.
620c53a6
SM
1728 (x_own_selection, x_get_local_selection, x_convert_selection):
1729 New arg, specifying work frame. Use terminal-local Vselection_alist.
a9f737ee
CY
1730 (some_frame_on_display): Delete unused function.
1731 (Fx_own_selection_internal, Fx_get_selection_internal)
1732 (Fx_disown_selection_internal, Fx_selection_owner_p)
1733 (Fx_selection_exists_p): New optional frame arg.
1734 (frame_for_x_selection, Fx_clipboard_manager_save): New functions.
1735 (x_handle_selection_clear): Don't treat other terminals with the
1736 same keyboard specially. Use the terminal-local Vselection_alist.
1737 (x_clear_frame_selections): Use Frun_hook_with_args.
1738
1739 * xterm.c (x_term_init): Intern ATOM and CLIPBOARD_MANAGER atoms.
1740
1741 * xterm.h: Add support for those atoms.
1742
e067f0c1
CY
17432011-05-26 Chong Yidong <cyd@stupidchicken.com>
1744
1745 * xselect.c: ICCCM-compliant handling of MULTIPLE targets.
1746 (converted_selections, conversion_fail_tag): New global variables.
1747 (x_selection_request_lisp_error): Free the above.
1748 (x_get_local_selection): Remove unnecessary code.
1749 (x_reply_selection_request): Args changed; handle arbitrary array
620c53a6
SM
1750 of converted selections stored in converted_selections.
1751 Separate the XChangeProperty and SelectionNotify steps.
e067f0c1
CY
1752 (x_handle_selection_request): Rewrite to handle MULTIPLE target.
1753 (x_convert_selection): New function.
1754 (x_handle_selection_event): Simplify.
1755 (x_get_foreign_selection): Don't ignore incoming requests while
1756 waiting for an answer; this will fail when we implement
1757 SAVE_TARGETS, and seems unnecessary anyway.
1758 (selection_data_to_lisp_data): Recognize ATOM_PAIR type.
1759 (Vx_sent_selection_functions): Doc fix.
1760
0f4aebc0
LL
17612011-05-26 Leo Liu <sdl.web@gmail.com>
1762
1763 * editfns.c (Ftranspose_regions): Allow empty regions. (Bug#8699)
1764
e61124cd
YM
17652011-05-25 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
1766
1767 * dispextern.h (struct glyph_row): New member fringe_bitmap_periodic_p.
1768
1769 * dispnew.c (shift_glyph_matrix, scrolling_window): Mark scrolled row
1770 for fringe update if it has periodic bitmap.
1771 (row_equal_p): Also compare left_fringe_offset, right_fringe_offset,
1772 and fringe_bitmap_periodic_p.
1773
1774 * fringe.c (get_fringe_bitmap_data): New function.
1775 (draw_fringe_bitmap_1, update_window_fringes): Use it.
1776 (update_window_fringes): Record periodicity of fringe bitmap in glyph
1777 row. Mark glyph row for fringe update if periodicity changed.
1778
1779 * xdisp.c (try_window_reusing_current_matrix): Don't mark scrolled row
1780 for fringe update unless it has periodic bitmap.
1781
f16d9837
KH
17822011-05-25 Kenichi Handa <handa@m17n.org>
1783
1784 * xdisp.c (get_next_display_element): Set correct it->face_id for
1785 a static composition.
1786
e1b90ef6
LL
17872011-05-24 Leo Liu <sdl.web@gmail.com>
1788
1789 * deps.mk (fns.o):
1790 * makefile.w32-in ($(BLD)/fns.$(O)): Include sha1.h.
1791
1792 * fns.c (crypto_hash_function, Fsha1): New function.
1793 (Fmd5): Use crypto_hash_function.
1794 (syms_of_fns): Add Ssha1.
1795
7400048f
PE
17962011-05-22 Paul Eggert <eggert@cs.ucla.edu>
1797
1798 * gnutls.c: Remove unused macros.
1799 (fn_gnutls_transport_set_lowat, fn_gnutls_transport_set_pull_function):
1800 (fn_gnutls_transport_set_push_function) [!WINDOWSNT]:
1801 Remove macros that are defined and never used.
1802 Caught by gcc -Wunused-macros (GCC 4.6.0, Fedora 14).
1803
abb71cf4
CY
18042011-05-22 Chong Yidong <cyd@stupidchicken.com>
1805
1806 * xselect.c (syms_of_xselect): Remove unused symbol SAVE_TARGETS.
1807 (Fx_get_selection_internal): Minor cleanup.
1808 (Fx_own_selection_internal): Rename arguments for consistency with
1809 select.el.
1810
6307db39
PE
18112011-05-22 Paul Eggert <eggert@cs.ucla.edu>
1812
1813 * xselect.c (QSAVE_TARGETS): New static var, to fix build failure.
1814
f3d4e0a4
CY
18152011-05-22 Chong Yidong <cyd@stupidchicken.com>
1816
1817 * xselect.c (syms_of_xselect): Include character.h; use DEFSYM.
1818
4d8ade89
YM
18192011-05-21 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
1820
1821 * dispnew.c (scrolling_window): Don't exclude the case that the
1822 last enabled row in the desired matrix touches the bottom boundary.
1823
32078c8d
GM
18242011-05-21 Glenn Morris <rgm@gnu.org>
1825
1826 * Makefile.in ($(etc)/DOC): Make second command line even shorter.
33cf345f
GM
1827 (SOME_MACHINE_OBJECTS): Replace FONT_OBJ by its maximal expansion,
1828 and add some more files.
32078c8d 1829
7285dc67
EZ
18302011-05-20 Eli Zaretskii <eliz@gnu.org>
1831
1832 * callproc.c (Fcall_process) [MSDOS]: Fix arguments to
1833 report_file_error introduced by the change from 2011-05-07.
1834
89d1bd22
PE
18352011-05-20 Paul Eggert <eggert@cs.ucla.edu>
1836
1837 * systime.h (Time): Define only if emacs is defined.
1838 This is to allow ../lib-src/profile.c to be compiled on FreeBSD,
1839 where the include path doesn't have X11/X.h by default. See
1840 <http://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00561.html>.
1841
e23640bb 18422011-05-20 Kenichi Handa <handa@m17n.org>
31bfc35c
KH
1843
1844 * composite.c (find_automatic_composition): Fix previous change.
1845
b9704ad9
GM
18462011-05-20 Glenn Morris <rgm@gnu.org>
1847
1848 * lisp.mk: New file, split from Makefile.in.
1849 * Makefile.in (lisp): Move to separate file, inserted by @lisp_frag@.
1850 (shortlisp): Remove.
1851 ($(etc)/DOC): Edit lisp.mk rather than using $shortlisp.
1852
4a720484
GM
18532011-05-19 Glenn Morris <rgm@gnu.org>
1854
1855 * Makefile.in (MSDOS_SUPPORT_REAL, MSDOS_SUPPORT, NS_SUPPORT)
1856 (REAL_MOUSE_SUPPORT, GPM_MOUSE_SUPPORT, MOUSE_SUPPORT, TOOLTIP_SUPPORT)
1857 (BASE_WINDOW_SUPPORT, X_WINDOW_SUPPORT, WINDOW_SUPPORT): Remove.
1858 (lisp): Set the order to that of loadup.el.
1859 (shortlisp): Make it a copy of $lisp.
1860 (SOME_MACHINE_LISP): Remove.
1861 ($(etc)/DOC): Depend just on $lisp, not $SOME_MACHINE_LISP too.
1862 Use just $shortlisp, not $SOME_MACHINE_LISP too.
1863
a28d4396
KH
18642011-05-18 Kenichi Handa <handa@m17n.org>
1865
1866 * composite.c (CHAR_COMPOSABLE_P): Add more check for efficiency.
1867 (BACKWARD_CHAR): Wrap the arg STOP by parenthesis.
1868 (find_automatic_composition): Mostly rewrite for efficiency.
1869
a2b1fa8e
JB
18702011-05-18 Juanma Barranquero <lekktu@gmail.com>
1871
1872 * makefile.w32-in: Update dependencies.
1873
8e1f5610
CS
18742011-05-18 Christoph Scholtes <cschol2112@googlemail.com>
1875
1876 * menu.c: Include limits.h (fixes the MS-Windows build broken by
7d7d0045 1877 2011-06-18T18:49:19Z!cyd@stupidchicken.com).
8e1f5610 1878
7025ee00 18792011-05-18 Paul Eggert <eggert@cs.ucla.edu>
cb93f9be 1880
cdfa6eab
PE
1881 Fix some integer overflow issues, such as string length overflow.
1882
06d6db33
PE
1883 * insdel.c (count_size_as_multibyte): Check for string overflow.
1884
2b4560a8
PE
1885 * character.c (lisp_string_width): Check for string overflow.
1886 Use EMACS_INT, not int, for string indexes and lengths; in
1887 particular, 2nd arg is now EMACS_INT, not int. Do not crash if
1888 the resulting string length overflows an EMACS_INT; instead,
1889 report a string overflow if no precision given. When checking for
1890 precision exhaustion, use a check that cannot possibly have
1891 integer overflow. (Bug#8675)
1892 * character.h (lisp_string_width): Adjust to new signature.
1893
cb93f9be
PE
1894 * alloc.c (string_overflow): New function.
1895 (Fmake_string): Use it. This doesn't change behavior, but saves
1896 a few bytes and will simplify future changes.
1897 * character.c (string_escape_byte8): Likewise.
1898 * lisp.h (string_overflow): New decl.
1899
1a1f3366
PE
1900 Fixups, following up to the user-interface timestamp change.
1901 * nsterm.m (last_mouse_movement_time, ns_mouse_position): Use Time
1902 for UI timestamps, instead of unsigned long.
9fbd6841
PE
1903 * msdos.c (mouse_get_pos): Likewise.
1904 * w32inevt.c (movement_time, w32_console_mouse_position): Likewise.
1a1f3366
PE
1905 * w32gui.h (Time): Define by including "systime.h" rather than by
1906 declaring it ourselves. (Bug#8664)
1907
d4e3e4d3
PE
1908 * dispextern.h (struct image): Don't assume time_t <= unsigned long.
1909 * image.c (clear_image_cache): Likewise.
1910
f6a24d19
PE
1911 * term.c (term_mouse_position): Don't assume time_t wraparound.
1912
08dc5ae6
PE
1913 Be more systematic about user-interface timestamps.
1914 Before, the code sometimes used 'Time', sometimes 'unsigned long',
620c53a6
SM
1915 and sometimes 'EMACS_UINT', to represent these timestamps.
1916 This change causes it to use 'Time' uniformly, as that's what X uses.
08dc5ae6
PE
1917 This makes the code easier to follow, and makes it easier to catch
1918 integer overflow bugs such as Bug#8664.
1919 * frame.c (Fmouse_position, Fmouse_pixel_position):
1920 Use Time, not unsigned long, for user-interface timestamps.
1921 * keyboard.c (last_event_timestamp, kbd_buffer_get_event): Likewise.
1922 (button_down_time, make_lispy_position, make_lispy_movement): Likewise.
1923 * keyboard.h (last_event_timestamp): Likewise.
1924 * menu.c (Fx_popup_menu) [!HAVE_X_WINDOWS]: Likewise.
1925 * menu.h (xmenu_show): Likewise.
1926 * term.c (term_mouse_position): Likewise.
1927 * termhooks.h (struct input_event.timestamp): Likewise.
1928 (struct terminal.mouse_position_hook): Likewise.
1929 * xmenu.c (create_and_show_popup_menu, xmenu_show): Likewise.
1930 * xterm.c (XTmouse_position, x_scroll_bar_report_motion): Likewise.
1931 * systime.h (Time): New decl. Pull it in from <X11/X.h> if
1932 HAVE_X_WINDOWS, otherwise define it as unsigned long, which is
1933 what it was before.
1934 * menu.h, termhooks.h: Include "systime.h", for Time.
1935
8e55734a
PE
1936 * keyboard.c (make_lispy_event): Fix problem in integer overflow.
1937 Don't assume that the difference between two unsigned long values
1938 can fit into an integer. At this point, we know button_down_time
1939 <= event->timestamp, so the difference must be nonnegative, so
1940 there's no need to cast the result if double-click-time is
1941 nonnegative, as it should be; check that it's nonnegative, just in
1942 case. This bug is triggered when events are more than 2**31 ms
86db42d2 1943 apart (about 25 days). (Bug#8664)
8e55734a 1944
841f1b75 1945 * xselect.c (last_event_timestamp): Remove duplicate decl.
6434756c 1946 (x_own_selection): Remove needless cast to unsigned long.
841f1b75 1947
3e26f69c
PE
1948 * xmenu.c (set_frame_menubar): Use int, not EMACS_UINT, for indexes
1949 that always fit in int. Use a sentinel instead of a counter, to
1950 avoid a temp and to allay GCC's concerns about possible int overflow.
d230cb74
PE
1951 * frame.h (struct frame): Use int for menu_bar_items_used
1952 instead of EMACS_INT, since it always fits in int.
3e26f69c 1953
5cc152c0
PE
1954 * menu.c (grow_menu_items): Check for int overflow.
1955
d89eb65e
PE
1956 * xmenu.c (set_frame_menubar): Don't mishandle vectors with no nils.
1957
5235bd3e
PE
1958 * xterm.c: Use EMACS_INT for Emacs modifiers, and int for X modifiers.
1959 Before, the code was not consistent. These values cannot exceed
1960 2**31 - 1 so there's no need to make them unsigned.
1961 (x_x_to_emacs_modifiers): Accept int and return EMACS_INT.
1962 (x_emacs_to_x_modifiers): Accept EMACS_INT and return int.
1963 (x_x_to_emacs_modifiers, x_emacs_to_x_modifiers): Reject non-integers
1964 as modifiers.
1965 * xterm.h (x_x_to_emacs_modifiers): Adjust to signature change.
1966
bc827e23
PE
1967 * lisp.h (XINT) [USE_LISP_UNION_TYPE]: Cast to EMACS_INT.
1968 (XUINT) [USE_LISP_UNION_TYPE]: Cast to EMACS_UINT.
1969 Otherwise, GCC 4.6.0 warns about printf (pI, XINT (...)),
1970 presumably because the widths might not match.
1971
78eb494e
PE
1972 * window.c (size_window): Avoid needless test at loop start.
1973
04f2d78b
CB
19742011-05-18 Courtney Bane <emacs-bugs-7626@cbane.org> (tiny change)
1975
1976 * term.c (Fresume_tty): Restore hooks before reinitializing (bug#8687).
1977
d2fc7e3d 19782011-05-12 Drew Adams <drew.adams@oracle.com>
e531bdff
DA
1979
1980 * textprop.c (Fprevious_single_char_property_change): Doc fix (bug#8655).
1981
d2fc7e3d 19822011-05-12 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
7db47798
YM
1983
1984 * w32term.c (w32_draw_fringe_bitmap): Rename local vars `left' and
1985 `width' to `bar_area_x' and `bar_area_width', respectively.
1986 (x_scroll_run): Take account of fringe background extension.
1987
04f2d78b
CB
1988 * xterm.c (x_draw_fringe_bitmap) [USE_TOOLKIT_SCROLL_BARS]:
1989 Rename local vars `left' and `width' to `bar_area_x' and
7db47798
YM
1990 `bar_area_width', respectively.
1991 (x_scroll_run) [USE_TOOLKIT_SCROLL_BARS]: Take account of fringe
1992 background extension.
1993
79b70037
GM
19942011-05-10 Jim Meyering <meyering@redhat.com>
1995
1996 * xdisp.c (x_intersect_rectangles): Fix typo "the the -> the".
1997
2f142cc5
JB
19982011-05-10 Juanma Barranquero <lekktu@gmail.com>
1999
2000 * image.c (Finit_image_library): Return t for built-in image types,
2001 like pbm and xbm. (Bug#8640)
2002
57679c86
AS
20032011-05-09 Andreas Schwab <schwab@linux-m68k.org>
2004
2005 * w32menu.c (set_frame_menubar): Fix submenu allocation.
2006
888c9e86
EZ
20072011-05-07 Eli Zaretskii <eliz@gnu.org>
2008
b0512a1d
EZ
2009 * w32console.c (Fset_screen_color): Doc fix.
2010 (Fget_screen_color): New function.
2011 (syms_of_ntterm): Defsubr it.
2012
7285dc67
EZ
2013 * callproc.c (call_process_cleanup) [MSDOS]: Don't close and
2014 unlink the temporary file if Fcall_process didn't create it in the
2015 first place.
2016 (Fcall_process) [MSDOS]: Don't create tempfile if stdout of the
2017 child process will be redirected to a file specified with `:file'.
888c9e86
EZ
2018 Don't try to re-open tempfile in that case, and set fd[0] to -1 as
2019 cue to call_process_cleanup not to close that handle.
2020
4d3fcc8e
BK
20212011-05-07 Ben Key <bkey76@gmail.com>
2022
2023 * makefile.w32-in: The bootstrap-temacs rule now makes use of
2024 one of two shell specific rules, either bootstrap-temacs-CMD or
2025 bootstrap-temacs-SH. The bootstrap-temacs-SH rule is identical
2026 to the previous implementation of the bootstrap-temacs rule.
2027 The bootstrap-temacs-CMD rule is similar to the previous
2028 implementation of the bootstrap-temacs rule except that it
2029 makes use of the ESC_CFLAGS variable instead of the CFLAGS
2030 variable.
2031
2032 These changes, along with some changes to nt/configure.bat,
2033 nt/gmake.defs, and nt/nmake.defs, are required to extend my
2034 earlier fix to add support for --cflags and --ldflags options
2035 that include quotes so that it works whether make uses cmd or
2036 sh as the shell.
2037
b4289b64
MA
20382011-05-06 Michael Albinus <michael.albinus@gmx.de>
2039
2040 * dbusbind.c (QCdbus_type_unix_fd): Declare static.
2041 (xd_remove_watch): Don't check QCdbus_type_unix_fd for SYMBOLP, it
2042 is a constant.
2043 (Fdbus_init_bus, xd_read_queued_messages): Bus can be a symbol or
2044 a string. Handle both cases.
2045 (Fdbus_call_method_asynchronously, Fdbus_register_signal)
2046 (Fdbus_register_method): Use Qinvalid_function.
2047
af4c0e28
JB
20482011-05-06 Juanma Barranquero <lekktu@gmail.com>
2049
2050 * makefile.w32-in: Update dependencies.
2051 (LISP_H): Add inttypes.h and stdin.h.
2052 (PROCESS_H): Add unistd.h.
2053
c51453d9
EZ
20542011-05-06 Eli Zaretskii <eliz@gnu.org>
2055
2056 * lread.c: Include limits.h (fixes the MS-Windows build broken by
2057 2011-05-06T07:13:19Z!eggert@cs.ucla.edu).
2058
8ff0ac3c 20592011-05-06 Paul Eggert <eggert@cs.ucla.edu>
c032b5f8 2060
4c4b566b
PE
2061 * image.c (Finit_image_library) [!HAVE_NTGUI]: Omit unused local.
2062
aab2b9b5
PE
2063 * term.c (vfatal): Remove stray call to va_end.
2064 It's not needed and the C Standard doesn't allow it here anyway.
2065
c378da0b
PE
2066 Use C99's va_copy to avoid undefined behavior on x86-64 GNU/Linux.
2067 * eval.c (verror): doprnt a copy of ap, not the original. (Bug#8545)
2068
288b08c7
PE
2069 * eval.c (verror): OK to create a string of up to MOST_POSITIVE_FIXNUM
2070 bytes.
2071
e3601888
PE
2072 * term.c: Don't include <stdarg.h>, as <lisp.h> does that.
2073
db6c0e74
PE
2074 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork clobbering.
2075
dd5963ea
PE
2076 * process.c (Fformat_network_address): Fix typo: args2 -> *args2.
2077
88c9450f
PE
2078 * xmenu.c (set_frame_menubar): Fix typo: int * -> int (3 times).
2079
2f9442b8
PE
2080 * coding.c (detect_coding_charset): Fix typo: * 2 -> *4 (Bug#8601).
2081
c032b5f8
PE
2082 * charset.h (struct charset.code_space): Now has 15 elements, not 16.
2083 * charset.c (Fdefine_charset_internal): Don't initialize
2084 charset.code_space[15]. The value was garbage, on hosts with
2d38271b 2085 32-bit int (Bug#8600).
a108c10b
PE
2086
2087 * lread.c (read_integer): Be more consistent with string-to-number.
2088 Use string_to_number to do the actual conversion; this avoids
2089 rounding errors and fixes some other screwups. Without this fix,
2090 for example, #x1fffffffffffffff was misread as -2305843009213693952.
2091 (digit_to_number): Move earlier, for benefit of read_integer.
2092 Return -1 if the digit is out of range for the base, -2 if it is
48e400f0 2093 not a digit in any supported base. (Bug#8602)
a108c10b 2094
ad5f9eea
PE
2095 * doprnt.c (doprnt): Support arbitrary pI values, such as "I64".
2096
aec1708a
PE
2097 * dispnew.c (scrolling_window): Return 1 if we scrolled,
2098 to match comment at start of function. This also removes a
2099 GCC warning about overflow in a 32+64-bit port.
2100
47be4ab5
PE
2101 * lisp.h (EMACS_INT, EMACS_UINT, BITS_PER_EMACS_INT, pI): Simplify.
2102
371cac43
PE
2103 * dbusbind.c: Do not use XPNTR on a value that may be an integer.
2104 Reported by Stefan Monnier in
2105 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00919.html>.
04f2d78b
CB
2106 (xd_remove_watch, Fdbus_init_bus, xd_read_queued_messages):
2107 Use SYMBOLP-guarded XSYMBOL, not XPNTR.
371cac43 2108
d01a7826
PE
2109 * lisp.h (EMACS_INTPTR): Remove. All uses changed to intptr_t.
2110 (EMACS_UINTPTR): Likewise, with uintptr_t.
2111
7fd47d5c
PE
2112 * lisp.h: Prefer 64-bit EMACS_INT if available.
2113 (EMACS_INT, EMACS_UINT, BITS_PER_EMACS_INT, pI): Define to 64-bit
2114 on 32-bit hosts that have 64-bit int, so that they can access
2115 large files.
122b0c86
PE
2116 However, temporarily disable this change unless the temporary
2117 symbol WIDE_EMACS_INT is defined.
7fd47d5c 2118
8727937b
PE
2119 * lread.c, process.c: Do not include <inttypes.h>; lisp.h does it now.
2120
8ac068ac
PE
2121 Prefer intptr_t/uintptr_t for integers the same widths as pointers.
2122 This removes an assumption that EMACS_INT and long are the same
2123 width as pointers. The assumption is true for Emacs porting targets
2124 now, but we want to make other targets possible.
2125 * lisp.h: Include <inttypes.h>, for INTPTR_MAX, UINTPTR_MAX.
2126 (EMACS_INTPTR, EMACS_UINTPTR): New macros.
2127 In the rest of the code, change types of integers that hold casted
2128 pointers to EMACS_INTPTR and EMACS_UINTPTR, systematically
2129 replacing EMACS_INT, long, EMACS_UINT, and unsigned long.
2130 (XTYPE): Don't cast arg to EMACS_UINT; normally is not needed.
2131 (XSET): Cast type of XTYPE arg to EMACS_INTPTR; it is needed here.
2132 No need to cast type when ORing.
2133 (XPNTR): Return a value of type EMACS_INTPTR or EMACS_UINTPTR.
2134 * alloc.c (lisp_align_malloc): Remove a no-longer-needed cast.
2135 * doc.c (store_function_docstring): Use EMACS_INTPTR, so as not to
2136 assume EMACS_INT is the same width as char *.
2137 * gtkutil.c (xg_gtk_scroll_destroy, xg_tool_bar_button_cb):
2138 (xg_tool_bar_callback, xg_tool_bar_help_callback, xg_make_tool_item):
2139 Remove no-longer-needed casts.
2140 (xg_create_scroll_bar, xg_tool_bar_button_cb, xg_tool_bar_callback):
2141 (xg_tool_bar_help_callback, xg_make_tool_item):
2142 Use EMACS_INTPTR to hold an integer
2143 that will be cast to void *; this can avoid a GCC warning
2144 if EMACS_INT is not the same width as void *.
2145 * menu.c (find_and_call_menu_selection): Remove no-longer-needed cast.
2146 * xdisp.c (display_echo_area_1, resize_mini_window_1):
2147 (current_message_1, set_message_1):
2148 Use a local to convert to proper width without a cast.
2149 * xmenu.c (dialog_selection_callback): Likewise.
2150
ede49d71
PE
2151 * sysdep.c (get_random): Don't assume EMACS_INT is no wider than long.
2152 Also, don't assume VALBITS / RAND_BITS is less than 5,
2153 and don't rely on undefined behavior when shifting a 1 left into
2154 the sign bit.
2155 * lisp.h (get_random): Change signature to match.
2156
2f30ecd0
PE
2157 * lread.c (hash_string): Use size_t, not int, for hash computation.
2158 Normally we prefer signed values; but hashing is special, because
2159 it's better to use unsigned division on hash table sizes so that
2160 the remainder is nonnegative. Also, size_t is the natural width
2161 for hashing into memory. The previous code used 'int', which doesn't
2162 retain enough info to hash well into very large tables.
2163 (oblookup, oblookup_last_bucket_number, Funintern): Likewise.
2164
2a866e7b
PE
2165 * dbusbind.c: Don't possibly lose pointer info when converting.
2166 (xd_remove_watch, Fdbus_init_bus, xd_read_queued_messages):
2167 Use XPNTR rather than XHASH, so that the high-order bits of
2168 the pointer aren't lost when converting through void *.
2169
51639eac
PE
2170 * eval.c (Fautoload): Don't double-shift a pointer.
2171
92394119
PE
2172 * fns.c (Frandom): Let EMACS_UINT be wider than unsigned long.
2173
dbdb9a7c
JB
21742011-05-06 Juanma Barranquero <lekktu@gmail.com>
2175
2176 * gnutls.c (DEF_GNUTLS_FN):
2177 * image.c (DEF_IMGLIB_FN): Make function pointers static.
2178
db7a0b4f
AS
21792011-05-05 Andreas Schwab <schwab@linux-m68k.org>
2180
2181 * lread.c (lisp_file_lexically_bound_p): Stop scanning at end
2182 marker. (Bug#8610)
2183
f7ff1b0f 21842011-05-05 Eli Zaretskii <eliz@gnu.org>
fab624aa
EZ
2185
2186 * w32heap.c (allocate_heap) [USE_LISP_UNION_TYPE || USE_LSB_TAG]:
2187 New version that can reserve upto 2GB of heap space.
2188
f7ff1b0f 21892011-05-05 Chong Yidong <cyd@stupidchicken.com>
45cb8994
CY
2190
2191 * nsfns.m (Fns_read_file_name): Doc fix (Bug#8534).
2192
639c109b
TZ
21932011-05-05 Teodor Zlatanov <tzz@lifelogs.com>
2194
2195 * gnutls.c (fn_gnutls_certificate_set_x509_key_file): Add alias to
2196 `gnutls_certificate_set_x509_key_file'.
2197
d2127135
JB
21982011-05-05 Juanma Barranquero <lekktu@gmail.com>
2199
2200 * makefile.w32-in ($(BLD)/image.$(O), $(BLD)/process.$(O)):
2201 Update dependencies.
2202
e968f4f3
JB
22032011-05-04 Juanma Barranquero <lekktu@gmail.com>
2204
2205 * gnutls.h (emacs_gnutls_write, emacs_gnutls_read):
2206 * gnutls.c (emacs_gnutls_write, emacs_gnutls_read):
2207 Remove unused parameter `fildes'.
2208 * process.c (read_process_output, send_process): Don't pass it.
2209
84d358f0
JB
22102011-05-04 Juanma Barranquero <lekktu@gmail.com>
2211
2212 Fix previous change: the library cache is defined in w32.c.
2213 * image.c (CACHE_IMAGE_TYPE) [!HAVE_NTGUI]: Define to noop.
2214 (Finit_image_library): Wrap Vlibrary_cache on "#ifdef HAVE_NTGUI".
2215
0898ca10
JB
22162011-05-04 Juanma Barranquero <lekktu@gmail.com>
2217
2218 Implement dynamic loading of GnuTLS on Windows.
2219
2220 * gnutls.h (GNUTLS_EMACS_ERROR_NOT_LOADED): New macro.
2221 (emacs_gnutls_write, emacs_gnutls_read): Mark as extern.
2222 (emacs_gnutls_record_check_pending, emacs_gnutls_transport_set_errno):
2223 Declare.
2224
2225 * gnutls.c (Qgnutls_dll): Define.
2226 (DEF_GNUTLS_FN, LOAD_GNUTLS_FN): New macros.
2227 (gnutls_*): Declare function pointers.
2228 (init_gnutls_functions): New function to initialize function pointers.
2229 (emacs_gnutls_handshake, Fgnutls_error_string, Fgnutls_deinit)
2230 (emacs_gnutls_global_init, Fgnutls_bye): Use function pointers.
2231 (emacs_gnutls_record_check_pending, emacs_gnutls_transport_set_errno):
2232 Wrappers for gnutls_record_check_pending and gnutls_transport_set_errno.
2233 (emacs_gnutls_write, emacs_gnutls_read)
2234 (emacs_gnutls_handle_error, Fgnutls_error_fatalp)
2235 (Fgnutls_available_p): New function.
2236 (Fgnutls_boot): Call Fgnutls_available_p. Use function pointers.
2237 (syms_of_gnutls) <Qgnutls_dll>: Initialize and staticpro it.
2238 (syms_of_gnutls) <Sgnutls_available_p>: defsubr it.
2239
2240 * image.c: Include w32.h.
2241 (Vimage_type_cache): Delete.
2242 (syms_of_image) <Vimage_type_cache>: Don't initialize and staticpro it.
2243 (CACHE_IMAGE_TYPE, Finit_image_library): Use Vlibrary_cache instead.
2244 (w32_delayed_load): Move to w32.c.
2245
2246 * w32.h (VlibraryCache, QCloaded_from, w32_delayed_load): Declare.
2247
2248 * w32.c (QCloaded_from, Vlibrary_cache): Define.
2249 (w32_delayed_load): Move from image.c. When loading a library, record
2250 its filename in the :loaded-from property of the library id.
2251 (globals_of_w32) <QCloaded_from, Vlibrary_cache>:
2252 Initialize and staticpro them.
2253 (emacs_gnutls_pull, emacs_gnutls_push): Call emacs_gnutls_* functions.
2254
2255 * process.c: Include lisp.h before w32.h, not after.
2256 (wait_reading_process_output): Call emacs_gnutls_record_check_pending
2257 instead of gnutls_record_check_pending.
2258
2259 * callproc.c, emacs.c: Include lisp.h before w32.h, not after.
2260
ff4de4aa
TZ
22612011-05-04 Teodor Zlatanov <tzz@lifelogs.com>
2262
2263 * gnutls.c (Fgnutls_boot): Support :keylist and :crlfiles options
2264 instead of :keyfiles. Give GnuTLS the keylist and the CRL lists
2265 as passed in.
2266
abe95abb
JD
22672011-05-03 Jan Djärv <jan.h.d@swipnet.se>
2268
2269 * xterm.c (x_set_frame_alpha): Do not set property on anything
2270 else than FRAME_X_OUTER_WINDOW (Bug#8608).
2271
e16e55d4
JB
22722011-05-02 Juanma Barranquero <lekktu@gmail.com>
2273
2274 * sysdep.c (get_tty_size) [WINDOWSNT]: Implement. (Bug#8596)
2275
bafcf6a5
JB
22762011-05-02 Juanma Barranquero <lekktu@gmail.com>
2277
2278 * gnutls.c (Qgnutls_log_level, Qgnutls_code, Qgnutls_anon)
2279 (Qgnutls_x509pki, Qgnutls_e_interrupted, Qgnutls_e_again)
2280 (Qgnutls_e_invalid_session, Qgnutls_e_not_ready_for_handshake)
2281 (gnutls_global_initialized, Qgnutls_bootprop_priority)
2282 (Qgnutls_bootprop_trustfiles, Qgnutls_bootprop_keyfiles)
2283 (Qgnutls_bootprop_callbacks, Qgnutls_bootprop_loglevel)
2284 (Qgnutls_bootprop_hostname, Qgnutls_bootprop_verify_flags)
2285 (Qgnutls_bootprop_verify_error, Qgnutls_bootprop_verify_hostname_error)
2286 (Qgnutls_bootprop_callbacks_verify): Make static.
2287
e7a6747f
AS
22882011-05-01 Andreas Schwab <schwab@linux-m68k.org>
2289
19ed11ba
AS
2290 * callproc.c: Indentation fixup.
2291
e7a6747f 2292 * sysdep.c (wait_for_termination_1): Make static.
04f2d78b
CB
2293 (wait_for_termination, interruptible_wait_for_termination):
2294 Move after wait_for_termination_1.
e7a6747f 2295
1ef14cb4
LMI
22962011-05-01 Lars Magne Ingebrigtsen <larsi@gnus.org>
2297
2298 * sysdep.c (interruptible_wait_for_termination): New function
2299 which is like wait_for_termination, but allows keyboard
2300 interruptions.
2301
2302 * callproc.c (Fcall_process): Add (:file "file") as an option for
2303 the STDOUT buffer.
2304 (Fcall_process_region): Ditto.
2305
330d880c
EZ
23062011-04-30 Eli Zaretskii <eliz@gnu.org>
2307
8db90b73
EZ
2308 * dosfns.c (Fint86, Fdos_memget, Fdos_memput): Use `ASIZE (FOO)'
2309 rather than `XVECTOR (FOO)->size'.
2310
330d880c
EZ
2311 * process.c: Remove HAVE_INTTYPES_H condition from inclusion of
2312 inttypes.h, as a gnulib replacement is used if it not available in
2313 system headers.
2314
15cbd324
EZ
23152011-04-21 Eli Zaretskii <eliz@gnu.org>
2316
2317 Lift the MOST_POSITIVE_FIXNUM/4 limitation on visited files.
2318 * fileio.c (Finsert_file_contents): Don't limit file size to 1/4
2319 of MOST_POSITIVE_FIXNUM. (Bug#8528)
2320
2321 * coding.c (coding_alloc_by_realloc): Error out if destination
2322 will grow beyond MOST_POSITIVE_FIXNUM.
2323 (decode_coding_emacs_mule): Abort if there isn't enough place in
2324 charbuf for the composition carryover bytes. Reserve an extra
2325 space for up to 2 characters produced in a loop.
2326 (decode_coding_iso_2022): Abort if there isn't enough place in
2327 charbuf for the composition carryover bytes.
2328
23292011-04-21 Eli Zaretskii <eliz@gnu.org>
afda1437 2330
ae940cca
EZ
2331 * doprnt.c (doprnt) [!HAVE_LONG_LONG_INT]: Error out instead of
2332 aborting when %lld or %lll format is passed.
2333 [!HAVE_UNSIGNED_LONG_LONG_INT]: Error out instead of aborting when
2334 %llo or %llx format is passed. (Bug#8545)
2335
03ab8921
EZ
2336 * window.c (window_scroll_line_based): Use a marker instead of
2337 simple variables to record original value of point. (Bug#7952)
2338
afda1437
EZ
2339 * doprnt.c (doprnt): Fix the case where a multibyte sequence
2340 produced by %s or %c overflows available buffer space. (Bug#8545)
2341
f76dee0c
PE
23422011-04-28 Paul Eggert <eggert@cs.ucla.edu>
2343
2344 * doprnt.c (doprnt): Omit useless test; int overflow check (Bug#8545).
283cdbef 2345 (SIZE_MAX): Move defn after all includes, as they might #define it.
f76dee0c 2346
fdc5744d
JB
23472011-04-28 Juanma Barranquero <lekktu@gmail.com>
2348
2349 * w32.c (init_environment): Warn about defaulting HOME to C:\.
2350
638f053a
JB
23512011-04-28 Juanma Barranquero <lekktu@gmail.com>
2352
2353 * keyboard.c (Qdelayed_warnings_hook): Define.
2354 (command_loop_1): Run `delayed-warnings-hook'
2355 if Vdelayed_warnings_list is non-nil.
2356 (syms_of_keyboard) <delayed-warnings-hook>: DEFSYM it.
2357 (syms_of_keyboard) <delayed-warnings-list>: DEFVAR_LISP it.
2358
d178f871
EZ
23592011-04-28 Eli Zaretskii <eliz@gnu.org>
2360
2361 * doprnt.c (doprnt): Don't return value smaller than the buffer
2362 size if the message was truncated. (Bug#8545).
2363
b124fd93
JB
23642011-04-28 Juanma Barranquero <lekktu@gmail.com>
2365
2366 * w32fns.c (Fx_change_window_property, Fx_delete_window_property)
2367 (Fx_window_property): #if-0 the whole functions, not just the bodies.
2368
e810457d
PE
23692011-04-27 Paul Eggert <eggert@cs.ucla.edu>
2370
2371 * doprnt.c (doprnt): Support "ll" length modifier, for long long.
2372
ea51cceb
JB
23732011-04-27 Juanma Barranquero <lekktu@gmail.com>
2374
2375 * makefile.w32-in: Update dependencies.
2376
94dcfacf
EZ
23772011-04-27 Eli Zaretskii <eliz@gnu.org>
2378
2379 Improve `doprnt' and its usage. (Bug#8545)
2380 * doprnt.c (doprnt): Make sure `format' is never accessed beyond
2381 `format_end'. Remove support for %l as a conversion specifier.
2382 Don't use xrealloc. Improve diagnostics when the %l size modifier
2383 is used. Update the commentary.
2384
2385 * eval.c (verror): Simplify calculation of size_t.
2386
2387 * coding.c (Ffind_operation_coding_system): Fix diagnostic error
2388 messages.
2389
f61f41d7
PE
23902011-04-27 Yoshiaki Kasahara <kasahara@nc.kyushu-u.ac.jp> (tiny change)
2391
2392 * buffer.c (init_buffer) [USE_MMAP_FOR_BUFFERS]: Adjust to aliasing
2393 change.
2394
96fb4434
PE
23952011-04-27 Paul Eggert <eggert@cs.ucla.edu>
2396
2397 * nsmenu.m: Replace all uses of XVECTOR with ASIZE and AREF.
2398 This makes this file independent of the recent pseudovector change.
2399
671875da 24002011-04-26 Paul Eggert <eggert@cs.ucla.edu>
eab3844f 2401
69e9b5a3
PE
2402 * keyboard.c (handle_user_signal): Fix pointer signedness problem.
2403
b5f869a7 2404 * gnutls.c (emacs_gnutls_handle_error): Remove unused local.
7754e151 2405 (Fgnutls_boot): gnutls_certificate_verify_peers2 wants unsigned *.
8d4c3955 2406 Remove unused local.
c8926152 2407 (emacs_gnutls_write): Don't use uninitialized rtnval if nbyte <= 0.
080e5a8d 2408
841a1577 2409 * lisp.h: Fix a problem with aliasing and vector headers. (Bug#8546)
04f2d78b
CB
2410 GCC 4.6.0 optimizes based on type-based alias analysis.
2411 For example, if b is of type struct buffer * and v of type struct
eab3844f
PE
2412 Lisp_Vector *, then gcc -O2 was incorrectly assuming that &b->size
2413 != &v->size, and therefore "v->size = 1; b->size = 2; return
2414 v->size;" must therefore return 1. This assumption is incorrect
2415 for Emacs, since it type-puns struct Lisp_Vector * with many other
2416 types. To fix this problem, this patch adds a new type struct
f904488f 2417 vectorlike_header that documents the constraints on layout of vectors
eab3844f
PE
2418 and pseudovectors, and helps optimizing compilers not get fooled
2419 by Emacs's type punning. It also adds the macros XSETTYPED_PVECTYPE
2420 XSETTYPED_PSEUDOVECTOR, TYPED_PSEUDOVECTORP, for similar reasons.
f904488f
PE
2421 * lisp.h (XSETTYPED_PVECTYPE): New macro, specifying the name of
2422 the size member.
eab3844f
PE
2423 (XSETPVECTYPE): Rewrite in terms of new macro.
2424 (XSETPVECTYPESIZE): New macro, specifying both type and size.
2425 This is a bit clearer, and further avoids the possibility of
2426 undesirable aliasing.
2427 (XSETTYPED_PSEUDOVECTOR): New macro, specifying the size.
f904488f 2428 (XSETPSEUDOVECTOR): Rewrite in terms of XSETTYPED_PSEUDOVECTOR.
eab3844f
PE
2429 (XSETSUBR): Rewrite in terms of XSETTYPED_PSEUDOVECTOR and XSIZE,
2430 since Lisp_Subr is a special case (no "next" field).
04f2d78b
CB
2431 (ASIZE): Now uses header.size rather than size.
2432 All previous uses of XVECTOR (foo)->size replaced to use this macro,
f904488f
PE
2433 to avoid the hassle of writing XVECTOR (foo)->header.size.
2434 (struct vectorlike_header): New type.
eab3844f
PE
2435 (TYPED_PSEUDOVECTORP): New macro, also specifying the C type of the
2436 object, to help avoid aliasing.
2437 (PSEUDOVECTORP): Rewrite in terms of TYPED_PSEUDOVECTORP.
2438 (SUBRP): Likewise, since Lisp_Subr is a special case.
2439 * lisp.h (struct Lisp_Vector, struct Lisp_Char_Table):
2440 (struct Lisp_Sub_Char_Table, struct Lisp_Bool_Vector):
2441 (struct Lisp_Hash_Table): Combine first two members into a single
f904488f 2442 struct vectorlike_header member. All uses of "size" and "next" members
eab3844f
PE
2443 changed to be "header.size" and "header.next".
2444 * buffer.h (struct buffer): Likewise.
2445 * font.h (struct font_spec, struct font_entity, struct font): Likewise.
2446 * frame.h (struct frame): Likewise.
2447 * process.h (struct Lisp_Process): Likewise.
2448 * termhooks.h (struct terminal): Likewise.
2449 * window.c (struct save_window_data, struct saved_window): Likewise.
2450 * window.h (struct window): Likewise.
2451 * alloc.c (allocate_buffer, Fmake_bool_vector, allocate_pseudovector):
2452 Use XSETPVECTYPESIZE, not XSETPVECTYPE, to avoid aliasing problems.
2453 * buffer.c (init_buffer_once): Likewise.
2454 * lread.c (defsubr): Use XSETTYPED_PVECTYPE, since Lisp_Subr is a
2455 special case.
2456 * process.c (Fformat_network_address): Use local var for size,
2457 for brevity.
2458
0df1eac5
PE
2459 * bytecode.c (exec_byte_code): Don't use XVECTOR before CHECK_VECTOR.
2460
847ab9d1 2461 Make the Lisp reader and string-to-float more consistent (Bug#8525)
452f4150
PE
2462 * data.c (atof): Remove decl; no longer used or needed.
2463 (digit_to_number): Move to lread.c.
2464 (Fstring_to_number): Use new string_to_number function, to be
2465 consistent with how the Lisp reader treats infinities and NaNs.
2466 Do not assume that floating-point numbers represent EMACS_INT
2467 without losing information; this is not true on most 64-bit hosts.
2468 Avoid double-rounding errors, by insisting on integers when
2469 parsing non-base-10 numbers, as the documentation specifies.
2470 * lisp.h (string_to_number): New decl, replacing ...
2471 (isfloat_string): Remove.
bc0a5c13 2472 * lread.c: Include <inttypes.h>, for uintmax_t and strtoumax.
d78050d6 2473 (read1): Do not accept +. and -. as integers; this
452f4150
PE
2474 appears to have been a coding error. Similarly, do not accept
2475 strings like +-1e0 as floating point numbers. Do not report
2476 overflow for integer overflows unless the base is not 10 which
2477 means we have no simple and reliable way to continue.
2478 Break out the floating-point parsing into a new
2479 function string_to_number, so that Fstring_to_number parses
2480 floating point numbers consistently with the Lisp reader.
04f2d78b 2481 (digit_to_number): Move here from data.c. Make it static inline.
452f4150
PE
2482 (E_CHAR, EXP_INT): Remove, replacing with ...
2483 (E_EXP): New macro, to solve the "1.0e+" problem mentioned below.
2484 (string_to_number): New function, replacing isfloat_string.
2485 This function checks for valid syntax and produces the resulting
2486 Lisp float number too. Rework it so that string-to-number
bc0a5c13 2487 no longer mishandles examples like "1.0e+". Use strtoumax,
d78050d6
PE
2488 so that overflow for non-base-10 numbers is reported only when
2489 there's no portable and simple way to convert to floating point.
452f4150 2490
67769ffc
PE
2491 * textprop.c (set_text_properties_1): Rewrite for clarity,
2492 and to avoid GCC warning about integer overflow.
2493
c20db43f
PE
2494 * intervals.h (struct interval): Use EMACS_INT for members
2495 where EMACS_UINT might cause problems. See
2496 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00514.html>.
2497 (CHECK_TOTAL_LENGTH): Remove cast to EMACS_INT; no longer needed.
2498 * intervals.c (interval_deletion_adjustment): Now returns EMACS_INT.
2499 All uses changed.
37aa2f85
PE
2500 (offset_intervals): Tell GCC not to worry about length overflow
2501 when negating a negative length.
c20db43f 2502
2538aa2f
PE
2503 * alloc.c (overrun_check_malloc, overrun_check_realloc): Now static.
2504 (overrun_check_free): Likewise.
2505
f2d3008d
PE
2506 * alloc.c (SDATA_SIZE) [!GC_CHECK_STRING_BYTES]: Avoid runtime check
2507 in the common case where SDATA_DATA_OFFSET is a multiple of Emacs
2508 word size.
2509
ec8df744
PE
2510 * gnutls.c: Fix problems found by GCC 4.6.0 on Ubuntu 10.10.
2511 (gnutls_make_error): Rename local to avoid shadowing.
2512 (gnutls_emacs_global_deinit): ifdef out; not used.
2513 (Fgnutls_boot): Use const for pointer to readonly storage.
2514 Comment out unused local. Fix pointer signedness problems.
2515
640ee02d
PE
2516 * lread.c (openp): Don't stuff size_t into an 'int'.
2517 Use <= on length, not < on length + 1, to avoid GCC 4.6.0 warning
2518 about possible signed overflow.
2519
6048fb2a
PE
2520 * gtkutil.c: Fix problems found by GCC 4.6.0 on Ubuntu 10.10.
2521 (GDK_KEY_g): Don't define if already defined.
2522 (xg_prepare_tooltip): Avoid pointer signedness problem.
2523 (xg_set_toolkit_scroll_bar_thumb): Redo to avoid two casts.
2524
fa3c87e1
PE
2525 * process.c (Fnetwork_interface_info): Avoid left-shift undefined
2526 behavior with 1 << 31. GCC 4.6.0 warns about this on 32-bit hosts.
2527
2172544b
PE
2528 * xfns.c (Fx_window_property): Simplify a bit,
2529 to make a bit faster and to avoid GCC 4.6.0 warning.
2530 * xselect.c (x_get_window_property, x_handle_dnd_message): Likewise.
2531
9b821a21
PE
2532 * fns.c (internal_equal): Don't assume size_t fits in int.
2533
3c616cfa
PE
2534 * alloc.c (compact_small_strings): Tighten assertion a little.
2535
c2982e87
PE
2536 Replace pEd with more-general pI, and fix some printf arg casts.
2537 * lisp.h (pI): New macro, generalizing old pEd macro to other
2538 conversion specifiers. For example, use "...%"pI"d..." rather
2539 than "...%"pEd"...".
2540 (pEd): Remove. All uses replaced with similar uses of pI.
2541 * src/m/amdx86-64.h, src/m/ia64.h, src/m/ibms390x.h: Likewise.
2542 * alloc.c (check_pure_size): Don't overflow by converting size to int.
2543 * bidi.c (bidi_dump_cached_states): Use pI to avoid cast.
2544 * data.c (Fnumber_to_string): Use pI instead of if-then-else-abort.
2545 * dbusbind.c (xd_append_arg): Use pI to avoid cast.
2546 (Fdbus_method_return_internal, Fdbus_method_error_internal): Likewise.
2547 * font.c (font_unparse_xlfd): Avoid potential buffer overrun on
2548 64-bit hosts.
2549 (font_unparse_xlfd, font_unparse_fcname): Use pI to avoid casts.
2550 * keyboard.c (record_char, modify_event_symbol): Use pI to avoid casts.
2551 * print.c (safe_debug_print, print_object): Likewise.
2552 (print_object): Don't overflow by converting EMACS_INT or EMACS_UINT
2553 to int.
6f04d126
PE
2554 Use pI instead of if-then-else-abort. Use %p to avoid casts,
2555 avoiding the 0 flag, which is not portable.
c2982e87
PE
2556 * process.c (Fmake_network_process): Use pI to avoid cast.
2557 * region-cache.c (pp_cache): Likewise.
2558 * xdisp.c (decode_mode_spec): Likewise.
2559 * xrdb.c (x_load_resources) [USE_MOTIF]: Use pI to avoid undefined
2560 behavior on 64-bit hosts with printf arg.
6f04d126 2561 * xselect.c (x_queue_event): Use %p to avoid casts, avoiding 0 flag.
c2982e87
PE
2562 (x_stop_queuing_selection_requests): Likewise.
2563 (x_get_window_property): Don't truncate byte count to an 'int'
2564 when tracing.
0b432f21 2565
5e073ec7
PE
2566 * frame.c (frame_name_fnn_p): Get rid of strtol, which isn't right
2567 here, since it parses constructs like leading '-' and spaces,
2568 which are not wanted; and it overflows with large numbers.
2569 Instead, simply match F[0-9]+, which is what is wanted anyway.
2570
36372bf9
PE
2571 * alloc.c: Remove unportable assumptions about struct layout.
2572 (SDATA_SELECTOR, SDATA_DATA_OFFSET): New macros.
2573 (SDATA_OF_STRING, SDATA_SIZE, allocate_string_data):
2574 (allocate_vectorlike, make_pure_vector): Use the new macros,
2575 plus offsetof, to remove unportable assumptions about struct layout.
2576 These assumptions hold on all porting targets that I know of, but
2577 they are not guaranteed, they're easy to remove, and removing them
2578 makes further changes easier.
2579
0b432f21
PE
2580 * alloc.c (BLOCK BYTES): Fix typo by changing "ablock" to "ablocks".
2581 This doesn't fix a bug but makes the code clearer.
bfd1c781
PE
2582 (string_overrun_cookie): Now const. Use initializers that
2583 don't formally overflow signed char, to avoid warnings.
000098c1
PE
2584 (allocate_string_data) [GC_CHECK_STRING_OVERRUN]: Fix typo that
2585 can cause Emacs to crash when string overrun checking is enabled.
c7bda33c
PE
2586 (allocate_buffer): Don't assume sizeof (struct buffer) is a
2587 multiple of sizeof (EMACS_INT); it need not be, if
2588 alignof(EMACS_INT) < sizeof (EMACS_INT).
d0f4e1f5 2589 (check_sblock, check_string_bytes, check_string_free_list): Protoize.
0b432f21 2590
895009e1
JB
25912011-04-26 Juanma Barranquero <lekktu@gmail.com>
2592
2593 * keyboard.c (QCrtl): Rename from Qrtl. All uses changed.
2594
6a7a1b0b
TZ
25952011-04-26 Teodor Zlatanov <tzz@lifelogs.com>
2596
2597 * gnutls.c (emacs_gnutls_handshake): Return an error if we're not
b5f869a7 2598 supposed to be handshaking. (Bug#8556)
6a7a1b0b
TZ
2599 Reported by Paul Eggert <eggert@cs.ucla.edu>.
2600
841a1577 26012011-04-26 Daniel Colascione <dan.colascione@gmail.com>
0438ce91
DC
2602
2603 * lisp.h (Qdebug): List symbol.
895009e1 2604 * eval.c (Qdebug): Restore global linkage.
0438ce91
DC
2605 * keyboard.c (debug-on-event): New variable.
2606 (handle_user_signal): Break into debugger when debug-on-event
2607 matches the current signal symbol.
2608
f2d3ba6f
DN
26092011-04-25 Dan Nicolaescu <dann@ics.uci.edu>
2610
2611 * alloc.c (check_sblock, check_string_bytes)
2612 (check_string_free_list): Convert to standard C.
2613
42ce4c63
TZ
26142011-04-25 Teodor Zlatanov <tzz@lifelogs.com>
2615
2616 * w32.c (emacs_gnutls_push): Fix typo.
2617
825cd63c
EZ
26182011-04-25 Eli Zaretskii <eliz@gnu.org>
2619
fb11d64d
EZ
2620 * gnutls.c (emacs_gnutls_handshake): Avoid compiler warnings about
2621 "cast to pointer from integer of different size".
2622
825cd63c
EZ
2623 Improve doprnt and its use in verror. (Bug#8545)
2624 * doprnt.c (doprnt): Document the set of format control sequences
2625 supported by the function. Use SAFE_ALLOCA instead of always
2626 using `alloca'.
2627
2628 * eval.c (verror): Don't limit the buffer size at size_max-1, that
2629 is one byte too soon. Don't use xrealloc; instead xfree and
2630 xmalloc anew.
2631
e061a11b
TZ
26322011-04-24 Teodor Zlatanov <tzz@lifelogs.com>
2633
2634 * gnutls.h: Add GNUTLS_STAGE_CALLBACKS enum to denote we're in the
2635 callbacks stage.
2636
2637 * gnutls.c: Renamed global_initialized to
2638 gnutls_global_initialized. Added internals for the
2639 :verify-hostname-error, :verify-error, and :verify-flags
2640 parameters of `gnutls-boot' and documented those parameters in the
2641 docstring. Start callback support.
2642 (emacs_gnutls_handshake): Add Woe32 support. Retry handshake
2643 unless a fatal error occured. Call gnutls_alert_send_appropriate
2644 on error. Return error code.
2645 (emacs_gnutls_write): Call emacs_gnutls_handle_error.
2646 (emacs_gnutls_read): Likewise.
2647 (Fgnutls_boot): Return handshake error code.
2648 (emacs_gnutls_handle_error): New function.
2649 (wsaerror_to_errno): Likewise.
2650
2651 * w32.h (emacs_gnutls_pull): Add prototype.
2652 (emacs_gnutls_push): Likewise.
2653
2654 * w32.c (emacs_gnutls_pull): New function for GnuTLS on Woe32.
2655 (emacs_gnutls_push): Likewise.
2656
26572011-04-24 Claudio Bley <claudio.bley@gmail.com> (tiny change)
2658
2659 * process.c (wait_reading_process_output): Check if GnuTLS
2660 buffered some data internally if no FDs are set for TLS
2661 connections.
2662
2663 * makefile.w32-in (OBJ2): Add gnutls.$(O).
2664 (LIBS): Link to USER_LIBS.
2665 ($(BLD)/gnutls.$(0)): New target.
2666
fa6996bc
EZ
26672011-04-24 Eli Zaretskii <eliz@gnu.org>
2668
eb35682e
EZ
2669 * xdisp.c (handle_single_display_spec): Rename the
2670 display_replaced_before_p argument into display_replaced_p, to
2671 make it consistent with the commentary. Fix typos in the
2672 commentary.
2673
e2ad650c
EZ
2674 * textprop.c (syms_of_textprop): Remove dead code.
2675 (copy_text_properties): Delete obsolete commentary about an
2676 interface that was deleted long ago. Fix typos in the description
2677 of arguments.
2678
1b2de274
EZ
2679 * msdos.c (XMenuActivate, XMenuAddSelection): Adjust argument list
2680 to changes in oldXMenu/XMenu.h from 2011-04-16.
2681 <menu_help_message, prev_menu_help_message>: Constify.
2682 (IT_menu_make_room): menu->help_text is now `const char **';
2683 adjust.
2684
2685 * msdos.h (XMenuActivate, XMenuAddSelection): Adjust prototypes
2686 to changes in oldXMenu/XMenu.h from 2011-04-16.
2687 (struct XMenu): Declare `help_text' `const char **'.
2688
2689 * xfaces.c <Qunspecified>: Make extern again.
2690
2691 * syntax.c: Include sys/types.h before including regex.h, as
2692 required by Posix.
2693
762b15be
EZ
2694 * doc.c (get_doc_string): Improve the format passed to `error'.
2695
2696 * doprnt.c (doprnt): Improve commentary.
2697
2698 * term.c (init_tty) [MSDOS]: Fix 1st argument to maybe_fatal.
2699
2700 * Makefile.in (TAGS): Depend on $(M_FILE) and $(S_FILE), and scan
2701 them with etags.
2702
f1052e5d
EZ
2703 * makefile.w32-in (globals.h): Add a dummy recipe, to make any
2704 changes in globals.h immediately force recompilation.
762b15be
EZ
2705 (TAGS): Depend on $(CURDIR)/m/intel386.h and
2706 $(CURDIR)/s/ms-w32.h.
2707 (TAGS-gmake): Scan $(CURDIR)/m/intel386.h and $(CURDIR)/s/ms-w32.h.
f1052e5d 2708
fa6996bc
EZ
2709 * character.c (Fchar_direction): Function deleted.
2710 (syms_of_character): Don't defsubr it.
2711 <char-direction-table>: Deleted.
2712
e6c3da20
EZ
27132011-04-23 Eli Zaretskii <eliz@gnu.org>
2714
2715 Fix doprnt so it could be used again safely in `verror'. (Bug#8435)
2716 * doprnt.c: Include limits.h.
2717 (SIZE_MAX): New macro.
04f2d78b
CB
2718 (doprnt): Return a size_t value. 2nd arg is now size_t.
2719 Many local variables are now size_t instead of int or unsigned.
e6c3da20
EZ
2720 Improve overflow protection. Support `l' modifier for integer
2721 conversions. Support %l conversion. Don't assume an EMACS_INT
2722 argument for integer conversions and for %c.
2723
2724 * lisp.h (doprnt): Restore prototype.
2725
2726 * makefile.w32-in ($(BLD)/callint.$(O)): Depend on
2727 $(SRC)/character.h.
2728
2729 * Makefile.in (base_obj): Add back doprnt.o.
2730
2731 * deps.mk (doprnt.o): Add back prerequisites.
2732 (callint.o): Depend on character.h.
2733
2734 * eval.c (internal_lisp_condition_case): Include the handler
2735 representation in the error message.
2736 (verror): Call doprnt instead of vsnprintf. Fix an off-by-one bug
2737 when breaking from the loop.
2738
2739 * xdisp.c (vmessage): Call doprnt instead of vsnprintf.
2740
2741 * callint.c (Fcall_interactively): When displaying error message
2742 about invalid control letter, pass the character's codepoint, not
2743 a pointer to its multibyte form. Improve display of the character
2744 in octal and display also its hex code.
2745
2746 * character.c (char_string): Use %x to display the (unsigned)
2747 codepoint of an invalid character, to avoid displaying a bogus
2748 negative value.
2749
2750 * font.c (check_otf_features): Pass SDATA of SYMBOL_NAME to
2751 `error', not SYMBOL_NAME itself.
2752
2753 * coding.c (Fencode_sjis_char, Fencode_big5_char): Use %c for
2754 character arguments to `error'.
2755
2756 * charset.c (check_iso_charset_parameter): Fix incorrect argument
2757 to `error' in error message about FINAL_CHAR argument. Make sure
2758 FINAL_CHAR is a character, and use %c when it is passed as
2759 argument to `error'.
2760
4ffd0d6b 27612011-04-23 Eli Zaretskii <eliz@gnu.org>
97a93095
EZ
2762
2763 * s/ms-w32.h (localtime): Redirect to sys_localtime.
2764
2765 * w32.c: Include <time.h>.
2766 (sys_localtime): New function.
2767
4ffd0d6b 27682011-04-23 Chong Yidong <cyd@stupidchicken.com>
c17819f4
CY
2769
2770 * xdisp.c (init_xdisp): Initialize echo_area_window (Bug#6451).
2771
4ffd0d6b 2772 * buffer.c (syms_of_buffer): Doc fix (Bug#6902).
aac0c6e3 2773
4ffd0d6b 27742011-04-23 Samuel Thibault <sthibault@debian.org> (tiny change)
aac0c6e3 2775
4ffd0d6b
GM
2776 * sysdep.c (wait_for_termination): On GNU Hurd, kill returns -1 on
2777 zombies (Bug#8467).
aac0c6e3 2778
04c56954
EZ
27792011-04-19 Eli Zaretskii <eliz@gnu.org>
2780
2781 * syntax.h (SETUP_SYNTAX_TABLE_FOR_OBJECT): Fix setting of
2782 gl_state.e_property when gl_state.object is Qt.
2783
2784 * insdel.c (make_gap_larger): Remove limitation of buffer size
2785 to <= INT_MAX.
2786
16a43933
CY
27872011-04-18 Chong Yidong <cyd@stupidchicken.com>
2788
2789 * xdisp.c (lookup_glyphless_char_display)
2790 (produce_glyphless_glyph): Handle cons cell entry in
2791 glyphless-char-display.
2792 (Vglyphless_char_display): Document it.
2793
2794 * term.c (produce_glyphless_glyph): Handle cons cell entry in
2795 glyphless-char-display.
2796
4581706e
CY
27972011-04-17 Chong Yidong <cyd@stupidchicken.com>
2798
2799 * xdisp.c (get_next_display_element): Remove unnecessary ifdefs.
2800
2801 * termhooks.h (FRAME_WINDOW_P): Remove duplicated definitions.
2802
2803 * dispextern.h (FACE_SUITABLE_FOR_ASCII_CHAR_P): Add missing
2804 definition for no-X builds.
2805
4887c6e2 28062011-04-16 Paul Eggert <eggert@cs.ucla.edu>
764430a3 2807
fd35b6f9
PE
2808 Static checks with GCC 4.6.0 and non-default toolkits.
2809
5c1ccb01
PE
2810 * s/sol2-6.h, s/unixware.h (PTY_TTY_NAME_SPRINTF): Protoize decl.
2811
006c5daa
PE
2812 * process.c (keyboard_bit_set): Define only if SIGIO.
2813 (send_process_trap): Mark it with NO_RETURN if it doesn't return.
2814 (send_process): Repair possible setjmp clobbering.
2815
efc736d3
PE
2816 * s/usg5-4-common.h (SETUP_SLAVE_PTY): Don't pass extra arg to 'fatal'.
2817
4e2fe2e6
PE
2818 * eval.c: Include <stdio.h>, for vsnprintf on non-GNU/Linux hosts.
2819
f97334a2
PE
2820 * data.c (arith_error): Mark with NO_RETURN if it doesn't return.
2821
4e75f29d
PE
2822 * alloc.c (bytes_used_when_full, SPARE_MEMORY, BYTES_USED):
2823 Define only if needed.
2824
90efadd1
PE
2825 * sysdep.c (_FILE_OFFSET_BITS): Make this hack even uglier
2826 by pacifying GCC about it. Maybe it's time to retire it?
875975e9 2827 * xfaces.c (USG, __TIMEVAL__): Likewise.
90efadd1 2828
3c647824
PE
2829 * dispextern.h (struct redisplay_interface): Rename param
2830 to avoid shadowing.
e264f262 2831 * termhooks.h (struct terminal): Likewise.
761383f4 2832 * xterm.c (xembed_send_message): Likewise.
3c647824 2833
b58c5c4a
PE
2834 * insdel.c (make_gap_smaller): Define only if
2835 USE_MMAP_FOR_BUFFERS || REL_ALLOC || DOUG_LEA_MALLOC.
2836
cad59032
PE
2837 * keyboard.c (read_char): Make a var volatile so longjmp won't clobber
2838 it.
2839
c339dc2e
PE
2840 * emacs.c (MAX_HEAP_BSS_DIFF, my_edata): Move to where they're used,
2841 so that we aren't warned about unused symbols.
2842
91a3e27b
PE
2843 * xfns.c (Fx_file_dialog): Rename local to avoid shadowing.
2844
399c71d3 2845 * xdisp.c (x_produce_glyphs): Mark var as initialized (Bug#8512).
7a3fb125 2846
8ffc96f5
PE
2847 * xfns.c (x_real_positions): Mark locals as initialized.
2848
eef9bc79
PE
2849 * xmenu.c (xmenu_show): Don't use uninitialized vars.
2850
098db9dd
PE
2851 * xterm.c: Fix problems found by static analysis with other toolkits.
2852 (toolkit_scroll_bar_interaction): Define and use only if USE_X_TOOLKIT.
dda3aedd
PE
2853 (x_dispatch_event): Declare static if USE_GTK, and
2854 define if USE_GTK || USE_X_TOOLKIT.
098db9dd 2855 (SET_SAVED_BUTTON_EVENT): Define only if USE_X_TOOLKIT || USE_GTK.
dda3aedd 2856 * xterm.h (x_dispatch_event): Extern only if USE_X_TOOLKIT.
841a1577
JB
2857 * xterm.c, xterm.h (x_mouse_leave): Bring this function back, but only
2858 if defined HAVE_MENUS && !defined USE_X_TOOLKIT && !defined USE_GTK.
098db9dd 2859
eb18f6cc
PE
2860 * xmenu.c (menu_help_callback): Pointer type fixes.
2861 Use const pointers when pointing at readonly data. Avoid pointer
2862 signedness clashes.
2863 (FALSE): Remove unused macro.
2864 (update_frame_menubar): Remove unused decl.
2865
1fe72bf8
PE
2866 * xfns.c (Fx_hide_tip): Move locals to avoid shadowing.
2867
60d9e1db
PE
2868 * menu.c (push_submenu_start, push_submenu_end): Do not define unless
2869 USE_X_TOOLKIT || USE_GTK || HAVE_NS || defined HAVE_NTGUI.
2870 (single_menu_item): Rename local to avoid shadowing.
2871
39261c26
PE
2872 * keyboard.c (make_lispy_event): Remove unused local var.
2873
018c5e19
PE
2874 * frame.c, frame.h (x_get_resource_string): Bring this back, but
2875 only if HAVE_X_WINDOWS && !USE_X_TOOLKIT.
2876
63d2b86e
PE
2877 * bitmaps: Change bitmaps from unsigned char back to the X11
2878 compatible char. Avoid the old compiler warnings about
2879 out-of-range initializers by using, for example, '\xab' rather
2880 than 0xab.
2881
aefd87e1
PE
2882 * xgselect.c (xgselect_initialize): Check vs interface
2883 even if ! (defined (USE_GTK) || defined (HAVE_GCONF)).
2884
bf501fb9
PE
2885 * xmenu.c (xmenu_show): Rename parm to avoid shadowing.
2886
e9829fdf
PE
2887 * xterm.c (x_create_toolkit_scroll_bar): Use const * for pointers
2888 to read-only memory.
2889
1086c095
PE
2890 * fns.c (vector): Remove; this old hack is no longer needed.
2891
2baccd04 2892 * xsmfns.c (create_client_leader_window): Rename shadowing arg.
401f10cb 2893 Remove unused var.
dde42981 2894 (gdk_x11_set_sm_client_id) [!USE_GTK]: Don't define.
2baccd04 2895
72391843 2896 * xrdb.c (x_load_resources): Omit unused local.
3565b346 2897
436c16df 2898 * xfns.c (free_frame_menubar, atof): Remove duplicate decls.
8a94ea33 2899 (x_window): Rename locals to avoid shadowing.
dc5ddd85 2900 (USG): Use the kludged USG macro, to pacify gcc.
436c16df 2901
92bb796d 2902 * xterm.c (x_alloc_nearest_color_for_widget): Remove; unused.
bbbef9e1 2903 (x_term_init): Remove local to avoid shadowing.
92bb796d 2904
764430a3 2905 * xfns.c, xterm.c (_XEditResCheckMessages): Protoize decl.
4887c6e2
PE
2906
2907 * xdisp.c, dispextern.h (set_vertical_scroll_bar): Now extern if
2908 USE_TOOLKIT_SCROLL_BARS && !USE_GTK, as xterm.c needs it then.
2909
d1dfb56c
EZ
29102011-04-16 Eli Zaretskii <eliz@gnu.org>
2911
c4354cb4
EZ
2912 * gnutls.c (Fgnutls_boot): Don't pass Lisp_Object to `error'.
2913
d1dfb56c
EZ
2914 Fix regex.c, syntax.c and friends for buffers > 2GB.
2915 * syntax.h (struct gl_state_s): Declare character position members
2916 EMACS_INT.
2917
2918 * syntax.c (update_syntax_table): Declare 2nd argument EMACS_INT.
2919
04f2d78b
CB
2920 * textprop.c (verify_interval_modification, interval_of):
2921 Declare arguments EMACS_INT.
d1dfb56c
EZ
2922
2923 * intervals.c (adjust_intervals_for_insertion): Declare arguments
2924 EMACS_INT.
2925
2926 * intervals.h (CHECK_TOTAL_LENGTH): Cast to EMACS_INT, not `int'.
2927
2928 * indent.c (Fvertical_motion): Local variable it_start is now
2929 EMACS_INT.
2930
2931 * regex.c (re_match, re_match_2, re_match_2_internal)
2932 (bcmp_translate, regcomp, regexec, print_double_string)
2933 (group_in_compile_stack, re_search, re_search_2, regex_compile)
2934 (re_compile_pattern, re_exec): Declare arguments and local
2935 variables `size_t' and `ssize_t' and return values `regoff_t', as
2936 appropriate.
2937 (POP_FAILURE_REG_OR_COUNT) <pfreg>: Declare `long'.
2938 (CHECK_INFINITE_LOOP) <failure>: Declare `ssize_t'.
2939 <compile_stack_type>: `size' and `avail' are now `size_t'.
2940
2941 * regex.h <regoff_t>: Use ssize_t, not int.
2942 (re_search, re_search_2, re_match, re_match_2): Arguments that
2943 specify buffer/string position and length are now ssize_t and
2944 size_t. Return type is regoff_t.
2945
613052cd
BK
29462011-04-16 Ben Key <bkey76@gmail.com>
2947
2948 * nsfont.m: Fixed bugs in ns_get_family and
2949 ns_descriptor_to_entity that were caused by using free to
2950 deallocate memory blocks that were allocated by xmalloc (via
2951 xstrdup). This caused Emacs to crash when compiled with
2952 XMALLOC_OVERRUN_CHECK defined (when Emacs was configured with
2953 --enable-checking=xmallocoverrun). xfree is now used to
2954 deallocate these memory blocks.
2955
4170f62f 29562011-04-15 Paul Eggert <eggert@cs.ucla.edu>
3e047f51 2957
71b41406
PE
2958 * sysdep.c (emacs_read): Remove unnecessary check vs MAX_RW_COUNT.
2959
9587a89d
PE
2960 emacs_write: Accept and return EMACS_INT for sizes.
2961 See http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00514.html
2962 et seq.
2963 * gnutls.c, gnutls.h (emacs_gnutls_read, emacs_gnutls_write):
2964 Accept and return EMACS_INT.
2965 (emacs_gnutls_write): Return the number of bytes written on
2966 partial writes.
2967 * sysdep.c, lisp.h (emacs_read, emacs_write): Likewise.
273a5f82
PE
2968 (emacs_read, emacs_write): Remove check for negative size, as the
2969 Emacs source code has been audited now.
9587a89d
PE
2970 * sysdep.c (MAX_RW_COUNT): New macro, to work around kernel bugs.
2971 (emacs_read, emacs_write): Use it.
273a5f82
PE
2972 * process.c (send_process): Adjust to the new signatures of
2973 emacs_write and emacs_gnutls_write. Do not attempt to store
2974 a byte offset into an 'int'; it might overflow.
9587a89d 2975 See http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00483.html
273a5f82 2976
3e047f51
PE
2977 * sound.c: Don't assume sizes fit in 'int'.
2978 (struct sound_device.period_size, alsa_period_size):
9c3c56a7 2979 Return EMACS_INT, not int.
3e047f51 2980 (struct sound_device.write, vox_write, alsa_write):
9c3c56a7
PE
2981 Accept EMACS_INT, not int.
2982 (wav_play, au_play): Use EMACS_INT to store sizes and to
3e047f51
PE
2983 record read return values.
2984
cc39a9db
BK
29852011-04-15 Ben Key <bkey76@gmail.com>
2986
c9d0ec6d
JB
2987 * keyboard.c (Qundefined): Don't declare static since it is used
2988 in nsfns.m.
2989 * xfaces.c (Qbold, Qexpanded, Qitalic, Qcondensed): Don't declare
2990 static since they are used in nsfont.m.
cc39a9db 2991
6c60eb9f
SM
29922011-04-15 Stefan Monnier <monnier@iro.umontreal.ca>
2993
2994 * process.c (Qprocessp): Don't declare static.
2995 * lisp.h (Qprocessp): Declare again.
2996
7990b61a
JB
29972011-04-15 Juanma Barranquero <lekktu@gmail.com>
2998
2999 * font.c (Qopentype): Don't make static (used from w32uniscribe.c).
3000
5d4cb038
PE
30012011-04-14 Paul Eggert <eggert@cs.ucla.edu>
3002
8bd7b830 3003 Improve C-level modularity by making more things 'static'.
cd64ea1d 3004
e3b27b31
PE
3005 Don't publish debugger-only interfaces to other modules.
3006 * lisp.h (safe_debug_print, debug_output_compilation_hack):
3007 (verify_bytepos, count_markers): Move decls to the only modules
3008 that need them.
3009 * region-cache.h (pp_cache): Likewise.
3010 * window.h (check_all_windows): Likewise.
3011 * marker.c, print.c, region-cache.c, window.c: Decls moved here.
3012
5d4cb038
PE
3013 * sysdep.c (croak): Now static, if
3014 defined TIOCNOTTY || defined USG5 || defined CYGWIN.
3015 * syssignal.h (croak): Declare only if not static.
69003fd8
PE
3016
3017 * alloc.c (refill_memory_reserve): Now static if
3018 !defined REL_ALLOC || defined SYSTEM_MALLOC.
3019 * lisp.h (refill_memory_reserve): Declare only if not static.
93ea6e8f 3020
e87b6180
PE
3021 * xsettings.c, xsettings.h (xsettings_get_system_normal_font):
3022 Define only if USE_LUCID.
3023
ac64929e
PE
3024 * xrdb.c (x_customization_string, x_rm_string): Now static.
3025
6f37259d
PE
3026 * xmenu.c (x_menu_wait_for_event): Export only if USE_MOTIF.
3027 * xterm.h (x_menu_wait_for_event): Declare only if USE_MOTIF.
3028
1683e3ab
PE
3029 * xdisp.c (draw_row_with_mouse_face): Now static.
3030 * dispextern.h (draw_row_with_mouse_fave): Remove decl.
3031
de9c2632
PE
3032 * window.h (check_all_windows): Mark externally visible.
3033
2b96acb7
PE
3034 * window.c (window_deletion_count): Now static.
3035
3036 * undo.c: Make symbols static if they're not exported.
3037 (last_undo_buffer, last_boundary_position, pending_boundary):
3038 Now static.
3039
50436f33
PE
3040 * textprop.c (interval_insert_behind_hooks): Now static.
3041 (interval_insert_in_front_hooks): Likewise.
3042
64520e5c
PE
3043 * term.c: Make symbols static if they're not exported.
3044 (tty_turn_off_highlight, get_tty_terminal, max_frame_cols):
3045 (max_frame_lines, tty_set_terminal_modes):
3046 (tty_reset_terminal_modes, tty_turn_off_highlight):
3047 (get_tty_terminal): Now static.
3048 (term_mouse_moveto): Do not define if HAVE_WINDOW_SYSTEM.
3049 * termhooks.h (term_mouse_moveto): Do not declare if
8bd7b830 3050 HAVE_WINDOW_SYSTEM.
64520e5c
PE
3051 * dispextern.h (tty_set_terminal_modes, tty_reset_terminal_modes):
3052 (tty_turn_off_highlight, get_tty_terminal): Remove decls.
3053
1fa53021
PE
3054 * sysdep.c: Make symbols static if they're not exported.
3055 (emacs_get_tty, emacs_set_tty, old_fcntl_flags, old_fcntl_owner):
3056 Now static.
3057 (sigprocmask_set, full_mask): Remove; unused.
3058 (wait_debugging): Mark as visible.
3059 * syssignal.h (SIGFULLMASK, full_mask): Remove decls.
3060 * systty.h (emacs_get_tty, emacs_set_tty): Remove decls.
3061
d4b43b22
PE
3062 * syntax.c (syntax_temp): Define only if !__GNUC__.
3063
b7c513d0
PE
3064 * sound.c (current_sound_device, current_sound): Now static.
3065
989b29ad
PE
3066 * search.c (searchbufs, searchbuf_head): Now static.
3067
13a55a78
PE
3068 * scroll.c (scroll_cost): Remove; unused.
3069 * dispextern.h (scroll_cost): Remove decl.
3070
de68a1fc
PE
3071 * region-cache.h (pp_cache): Mark as externally visible.
3072
40ccffa6
PE
3073 * process.c: Make symbols static if they're not exported.
3074 (process_tick, update_tick, create_process, chan_process):
3075 (Vprocess_alist, proc_buffered_char, datagram_access):
3076 (fd_callback_data, send_process_frame, process_sent_to): Now static.
3077 (deactivate_process): Mark defn as static, as well as decl.
3078 * lisp.h (create_process): Remove decl.
3079 * process.h (chan_process, Vprocess_alist): Remove decls.
3080
ad64fc97
PE
3081 * print.c: Make symbols static if they're not exported.
3082 (print_depth, new_backquote_output, being_printed, print_buffer):
3083 (print_buffer_size, print_buffer_pos, print_buffer_pos_byte):
3084 (print_interval, print_number_index, initial_stderr_stream):
3085 Now static.
3086 * lisp.h (Fprinc): Remove decl.
3087 (debug_output_compilation_hack): Mark as externally visible.
3088
adddb265
PE
3089 * sysdep.c (croak): Move decl from here to syssignal.h.
3090 * syssignal.h (croak): Put it here, so the API can be checked when
3091 'croak' is called from dissociate_if_controlling_tty.
3092
1717ede2
PE
3093 * minibuf.c: Make symbols static if they're not exported.
3094 (minibuf_save_list, choose_minibuf_frame): Now static.
3095 * lisp.h (choose_minibuf_frame): Remove decl.
3096
fa5fb2bc
PE
3097 * lisp.h (verify_bytepos, count_markers): Mark as externally visible.
3098
1e3890d1
PE
3099 * lread.c: Make symbols static if they're not exported.
3100 (read_objects, initial_obarray, oblookup_last_bucket_number):
3101 Now static.
3102 (make_symbol): Remove; unused.
3103 * lisp.h (initial_obarray, make_symbol): Remove decls.
3104
8a1414fa
PE
3105 * keyboard.c: Make symbols static if they're not exported.
3106 (single_kboard, recent_keys_index, total_keys, recent_keys):
3107 (this_command_key_count_reset, raw_keybuf, raw_keybuf_count):
3108 (this_single_command_key_start, echoing, last_auto_save):
3109 (read_key_sequence_cmd, dribble, recursive_edit_unwind):
3110 (command_loop, echo_now, keyboard_init_hook, help_char_p):
3111 (quit_throw_to_read_char, command_loop_2, top_level_1, poll_timer):
3112 (Vlispy_mouse_stem, double_click_count):
3113 Now static.
3114 (force_auto_save_soon): Define only if SIGDANGER.
3115 (ignore_mouse_drag_p): Now static if
3116 !defined HAVE_WINDOW_SYSTEM || defined USE_GTK || defined HAVE_NS.
3117 (print_help): Remove; unused.
3118 (stop_character, last_timer_event): Mark as externally visible.
3119 * keyboard.h (ignore_mouse_drag_p): Declare only if
3120 defined HAVE_WINDOW_SYSTEM && !defined USE_GTK && !defined HAVE_NS.
3121 (echo_now, help_char_p, quit_throw_to_read_char): Remove decls.
3122 * lisp.h (echoing): Remove decl.
3123 (force_auto_save_soon): Declare only if SIGDANGER.
3124 * xdisp.c (redisplay_window): Simplify code, to make it more
3125 obvious that ignore_mouse_drag_p is not accessed if !defined
3126 USE_GTK && !defined HAVE_NS.
3127
93ea6e8f
PE
3128 * intervals.c: Make symbols static if they're not exported.
3129 (merge_properties_sticky, merge_interval_right, delete_interval):
3130 Now static.
3131 * intervals.h (merge_interval_right, delete_interval): Remove decls.
3132
77382fcc
PE
3133 * insdel.c: Make symbols static if they're not exported.
3134 However, leave prepare_to_modify_buffer alone. It's never
3135 called from outside this function, but that appears to be a bug.
3136 (combine_after_change_list, combine_after_change_buffer):
4889fc82 3137 (adjust_after_replace, signal_before_change): Now static.
77382fcc
PE
3138 (adjust_after_replace_noundo): Remove; unused.
3139 * lisp.h (adjust_after_replace, adjust_after_replace_noundo):
4889fc82 3140 (signal_before_change): Remove decls.
77382fcc 3141
9306c32e
PE
3142 * indent.c (val_compute_motion, val_vmotion): Now static.
3143
cd44d2eb
PE
3144 * image.c: Make symbols static if they're not exported.
3145 * dispextern.h (x_create_bitmap_from_xpm_data): Do not declare
3146 if USE_GTK.
3147 * image.c (x_create_bitmap_from_xpm_data): Do not define if USE_GTK.
3148 (xpm_color_cache, ct_table, ct_colors_allocated): Now static.
3149
ad9a7a06
PE
3150 * fringe.c (standard_bitmaps): Now static.
3151 (max_used_fringe_bitmap): Now static, unless HAVE_NS.
3152
81626931
PE
3153 * frame.c: Make symbols static if they're not exported.
3154 (x_report_frame_params, make_terminal_frame): Now static.
3155 (get_frame_param): Now static, unless HAVE_NS.
3156 (x_fullscreen_adjust): Define if WINDOWSNT, not if HAVE_WINDOW_SYSTEM.
3157 (x_get_resource_string): Remove; not used.
3158 * frame.h (make_terminal_frame, x_report_frame_params):
3159 (x_get_resource_string); Remove decls.
3160 (x_fullscreen_adjust): Declare only if WINDOWSNT.
3161 * lisp.h (get_frame_param): Declare only if HAVE_NS.
3162
239f9db9
PE
3163 * font.c, fontset.c: Make symbols static if they're not exported.
3164 * dispextern.h (FACE_SUITABLE_FOR_ASCII_CHAR_P): New macro.
3165 (FACE_SUITABLE_FOR_CHAR_P): Use it.
3166 * font.c (font_close_object): Now static.
3167 * font.h (font_close_object): Remove.
3168 * fontset.c (FONTSET_OBJLIST): Remove.
3169 (free_realized_fontset) #if-0 the body, which does nothing.
3170 (face_suitable_for_char_p): #if-0, as it's never called.
3171 * fontset.h (face_suitable_for_char_p): Remove decl.
04f2d78b
CB
3172 * xfaces.c (face_at_string_position):
3173 Use FACE_SUITABLE_FOR_ASCII_CHAR_P, not FACE_SUITABLE_FOR_CHAR_P,
239f9db9
PE
3174 since 0 is always ASCII.
3175
dfcf3579
PE
3176 * fns.c (weak_hash_tables): Now static.
3177
5045092b
PE
3178 * fileio.c: Make symbols static if they're not exported.
3179 (auto_saving, auto_save_mode_bits, auto_save_error_occurred):
3180 (Vwrite_region_annotation_buffers): Now static.
3181
57a96f5c
PE
3182 * eval.c: Make symbols static if they're not exported.
3183 (backtrace_list, lisp_eval_depth, when_entered_debugger): Now static.
3184 * lisp.h (backtrace_list): Remove decl.
3185
35f08c38
PE
3186 * emacs.c: Make symbols static if they're not exported.
3187 (malloc_state_ptr, malloc_using_checking, syms_of_emacs):
3188 (fatal_error_code, fatal_error_signal_hook, standard_args):
3189 Now static.
3190 (fatal_error_signal): Now static, unless FLOAT_CATCH_SIGKILL.
3191 (DEFINE_DUMMY_FUNCTION): Mark function as externally visible.
3192 (__CTOR_LIST__, __DTOR_LIST__): Now externally visible.
3193 * lisp.h (fatal_error_signal_hook): Remove decl.
3194 (fatal_error_signal): Declare only if FLOAT_CATCH_SIGKILL.
3195
f44bd759
PE
3196 * editfns.c: Move a (normally-unused) function to its only use.
3197 * editfns.c, lisp.h (get_operating_system_release): Remove.
3198 * process.c (init_process) [DARWIN_OS]: Do it inline, as it is not
3199 worth the hassle of breaking this out.
3200
b532497d
PE
3201 * xterm.c: Make symbols static if they're not exported.
3202 (x_raise_frame, x_lower_frame, x_wm_set_window_state):
3203 (x_wm_set_icon_pixmap, x_initialize, XTread_socket_fake_io_error):
3204 (x_destroy_window, x_delete_display):
3205 Now static.
3206 (x_dispatch_event): Now static if ! (USE_MOTIF || USE_X_TOOLKIT).
3207 (x_mouse_leave): Remove; unused.
3208 * xterm.h (x_display_info_for_name, x_raise_frame, x_lower_frame):
3209 (x_destroy_window, x_wm_set_window_state, x_wm_set_icon_pixmap):
3210 (x_delete_display, x_initialize, x_set_border_pixel, x_screen_planes):
3211 Remove decls.
3212 (x_mouse_leave): Declare only if WINDOWSNT.
3213 (x_dispatch_event): Declare only if USE_MOTIF or USE_X_TOOLKIT.
3214 (xic_create_fontsetname): Declare only if HAVE_X_WINDOWS &&
3215 USE_X_TOOLKIT.
3216
1675728f
PE
3217 * ftxfont.c: Make symbols static if they're not exported.
3218 (ftxfont_driver): Export only if !defined HAVE_XFT && def8ined
3219 HAVE_FREETYPE.
3220 * font.h (ftxfont_driver): Likewise.
3221
e4cebfca
PE
3222 * xfns.c: Make symbols static if they're not exported.
3223 (x_last_font_name, x_display_info_for_name):
3224 (x_set_foreground_color, x_set_background_color, x_set_mouse_color):
3225 (x_set_cursor_color, x_set_border_pixel, x_set_border_color):
3226 (x_set_cursor_type, x_set_icon_type, x_set_icon_name):
3227 (x_set_scroll_bar_foreground, x_set_scroll_bar_background):
3228 (x_explicitly_set_name, x_set_title, xic_defaut_fontset, tip_timer):
3229 (last_show_tip_args): Now static.
3230 (xic_defaut_fontset, xic_create_fontsetname): Define only if
3231 defined HAVE_X_WINDOWS && defined USE_X_TOOLKIT
3232 (x_screen_planes): Remove; unused.
3233 * dispextern.h (x_screen_planes): Remove decl.
3234
5bf46f05
PE
3235 * dispnew.c: Make symbols static if they're not exported.
3236 * dispextern.h (redraw_garbaged_frames, scrolling):
3237 (increment_row_positions): Remove.
3238 * dispnew.c (new_glyph_matrix, increment_row_positions, scrolling):
3239 (delayed_size_change, glyph_matrix_count, glyph_pool_count):
3240 Now static.
3241 (redraw_garbaged_frames): Remove; unused.
3242
435f4c28
PE
3243 * xfaces.c: Make symbols static if they're not exported.
3244 * dispextern.h (ascii_face_of_lisp_face, free_realized_face):
3245 Remove decls.
3246 * xterm.h (defined_color): Remove decls.
3247 (x_free_dpy_colors): Declare only if USE_X_TOOLKIT.
3248 * xfaces.c (tty_suppress_bold_inverse_default_colors_p):
3249 (menu_face_changed_default, defined_color, free_realized_face):
3250 (x_free_dpy_colors): Define only if USE_X_TOOLKIT.
3251 (ascii_face_of_lisp_face): Remove; unused.
3252
8524aef3
PE
3253 * xdisp.c: Make symbols static if they're not exported.
3254 * dispextern.h (scratch_glyph_row, window_box_edges):
3255 (glyph_to_pixel_coords, set_cursor_from_row):
3256 (get_next_display_element, set_iterator_to_next):
3257 (highlight_trailing_whitespace, frame_to_window_pixel_xy):
3258 (show_mouse_face): Remove decls
3259 * frame.h (message_buf_print): Likewise.
3260 * lisp.h (pop_message, set_message, check_point_in_composition):
3261 Likewise.
3262 * xterm.h (set_vertical_scroll_bar): Likewise.
3263 * xdisp.c (list_of_error, Vmessage_stack, line_number_displayed):
3264 (message_buf_print, scratch_glyph_row, displayed_buffer):
3265 (set_iterator_to_next, pop_message, set_message, set_cursor_from_row):
3266 (get_next_display_element, show_mouse_face, window_box_edges):
3267 (frame_to_window_pixel_xy, check_point_in_composition):
3268 (set_vertical_scroll_bar, highlight_trailing_whitespace): Now static.
3269 (glyph_to_pixel_coords): Remove; unused.
3270
16390cd2
PE
3271 * dired.c (file_name_completion): Now static.
3272
3273 * dbusbind.c (xd_in_read_queued_messages): Now static.
3274
a25f4dfa
PE
3275 * lisp.h (circular_list_error, FOREACH): Remove; unused.
3276 * data.c (circular_list_error): Remove.
3277
14a9c8df
PE
3278 * commands.h (last_point_position, last_point_position_buffer):
3279 (last_point_position_window): Remove decls.
3280 * keyboard.c: Make these variables static.
3281
04f2d78b
CB
3282 * coding.h (coding, code_convert_region, encode_coding_gap):
3283 Remove decls.
74ab6df5
PE
3284 * coding.c (Vsjis_coding_system, Vbig5_coding_system):
3285 (iso_code_class, detect_coding, code_convert_region): Now static.
3286 (encode_coding_gap): Remove; unused.
3287
38dfbee1
PE
3288 * chartab.c (chartab_chars, chartab_bits): Now static.
3289
a2cb4e63
PE
3290 * charset.h (charset_iso_8859_1): Remove decl.
3291 * charset.c (charset_iso_8859_1, charset_emacs, map_charset_for_dump):
3292 Now static.
3293
127198fd
PE
3294 * ccl.h (check_ccl_update, Vccl_program_table): Remove decls.
3295 * ccl.c (Vccl_program_table): Now static.
3296 (check_ccl_update): Remove; unused.
3297
d85b608f
PE
3298 * category.c (SET_CATEGORY_SET, set_category_set): Move here.
3299 * category.h: ... from here.
3300 * category.c (check_category_table, set_category_set): Now static.
3301
31cd66f3
PE
3302 * casetab.c (Vascii_upcase_table, Vascii_eqv_table): Now static.
3303 * lisp.h: Remove these decls.
3304
c358e587
PE
3305 * buffer.c (buffer_count): Remove unused var.
3306
e78aecca
PE
3307 * bidi.c (bidi_dump_cached_states): Mark as externally visible,
3308 so that it's not optimized away.
3309 (bidi_ignore_explicit_marks_for_paragraph_level): Likewise.
3310 * dispextern.h (bidi_dump_cached_states): Remove, since it's
3311 exported only to the debugger.
3312
e192d7d3 3313 * atimer.c (alarm_signal_handler, run_all_atimers): Now static.
04f2d78b 3314 * atimer.h (run_all_atimers): Remove; not exported.
e192d7d3 3315
92470028
PE
3316 font.c: Make copy_font_spec and merge_font_spec ordinary C functions.
3317 * font.c (copy_font_spec): Rename from Fcopy_font_spec, since it
3318 was inaccessible from Lisp.
3319 (merge_font_spec): Likewise, renaming from Fmerge_font_spec.
3320 * font.c, font.h, fontset.c, xfaces.c, xfont.c: Change all uses.
3321
244ed907
PE
3322 alloc.c: Import and export fewer symbols, and remove unused items.
3323 * lisp.h (suppress_checking, die): Declare only if ENABLE_CHECKING
3324 is defined.
3325 (suppress_checking): Add EXTERNALLY_VISIBLE attribute, so that
3326 it's not optimized away by whole-program optimization.
3327 (message_enable_multibyte, free_misc): Remove.
3328 (catchlist, handlerlist, mark_backtrace):
3329 Declare only if BYTE_MARK_STACK.
3330 (mark_byte_stack): Likewise, fixing a ifdef-vs-if typo.
3331 * alloc.c (pure): Export only if VIRT_ADDR_VARIES is defined.
3332 (message_enable_multibyte): Remove decl.
3333 (free_misc, interval_free_list, float_block, float_block_index):
3334 (n_float_blocks, float_free_list, cons_block, cons_block_index):
3335 (cons_free_list, last_marked_index):
3336 Now static.
3337 (suppress_checking, die): Define only if ENABLE_CHECKING is defined.
3338 * eval.c (catchlist, handlerlist): Export only if BYTE_MARK_STACK.
3339 (mark_backtrace): Define only if BYTE_MARK_STACK.
3340 * xdisp.c (message_enable_multibyte): Now static.
3341
61c2b50e 3342 Declare Lisp_Object Q* variables to be 'static' if not exported.
955cbe7b
PE
3343 This makes it easier for human readers (and static analyzers)
3344 to see whether these variables are used from other modules.
3345 * alloc.c, buffer.c, bytecode.c, callint.c, casetab.c, category.c:
3346 * ccl.c, character.c, charset.c, cmds.c, coding.c, composite.c:
3347 * data.c, dbusbind.c, dired.c, editfns.c, eval.c, fileio.c, fns.c:
3348 * font.c, frame.c, fringe.c, ftfont.c, image.c, keyboard.c, keymap.c:
3349 * lread.c, macros.c, minibuf.c, print.c, process.c, search.c:
3350 * sound.c, syntax.c, textprop.c, window.c, xdisp.c, xfaces.c, xfns.c:
3351 * xmenu.c, xselect.c:
3352 Declare Q* vars static if they are not used in other modules.
3353 * ccl.h, character.h, charset.h, coding.h, composite.h, font.h:
3354 * frame.h, intervals.h, keyboard.h, lisp.h, process.h, syntax.h:
3355 Remove decls of unexported vars.
3356 * keyboard.h (EVENT_HEAD_UNMODIFIED): Remove now-unused macro.
3357
95c82688
PE
3358 * lisp.h (DEFINE_FUNC): Make sname 'static'.
3359
16a97296
PE
3360 Make Emacs functions such as Fatom 'static' by default.
3361 This makes it easier for human readers (and static analyzers)
3362 to see whether these functions can be called from other modules.
3363 DEFUN now defines a static function. To make the function external
3364 so that it can be used in other C modules, use the new macro DEFUE.
8bd7b830
PE
3365 * lisp.h (Funibyte_char_to_multibyte, Fsyntax_table_p):
3366 (Finit_image_library):
16a97296
PE
3367 (Feval_region, Fbacktrace, Ffetch_bytecode, Fswitch_to_buffer):
3368 (Ffile_executable_p, Fmake_symbolic_link, Fcommand_execute):
3369 (Fget_process, Fdocumentation_property, Fbyte_code, Ffile_attributes):
3370 Remove decls, since these functions are now static.
3371 (Funintern, Fget_internal_run_time): New decls, since these functions
3372 were already external.
95c82688 3373
16a97296
PE
3374 * alloc.c, buffer.c, callint.c, callproc.c, casefiddle.c, casetab.c:
3375 * ccl.c, character.c, chartab.c, cmds.c, coding.c, data.c, dispnew.c:
3376 * doc.c, editfns.c, emacs.c, eval.c, fileio.c, filelock.c, floatfns.c:
3377 * fns.c, font.c, fontset.c, frame.c, image.c, indent.c:
3378 * keyboard.c, keymap.c, lread.c:
3379 * macros.c, marker.c, menu.c, minibuf.c, print.c, process.c, search.c:
3380 * syntax.c, term.c, terminal.c, textprop.c, undo.c:
3381 * window.c, xdisp.c, xfaces.c, xfns.c, xmenu.c, xsettings.c:
3382 Mark functions with DEFUE instead of DEFUN,
3383 if they are used in other modules.
3384 * buffer.c (Fset_buffer_major_mode, Fdelete_overlay): New forward
3385 decls for now-static functions.
3386 * buffer.h (Fdelete_overlay): Remove decl.
3387 * callproc.c (Fgetenv_internal): Mark as internal.
3388 * composite.c (Fremove_list_of_text_properties): Remove decl.
3389 (Fcomposition_get_gstring): New forward static decl.
3390 * composite.h (Fcomposite_get_gstring): Remove decl.
3391 * dired.c (Ffile_attributes): New forward static decl.
3392 * doc.c (Fdocumntation_property): New forward static decl.
3393 * eval.c (Ffetch_bytecode): New forward static decl.
3394 (Funintern): Remove extern decl; now in .h file where it belongs.
3395 * fileio.c (Fmake_symbolic_link): New forward static decl.
3396 * image.c (Finit_image_library): New forward static decl.
3397 * insdel.c (Fcombine_after_change_execute): Make forward decl static.
3398 * intervals.h (Fprevious_property_change):
3399 (Fremove_list_of_text_properties): Remove decls.
3400 * keyboard.c (Fthis_command_keys): Remove decl.
3401 (Fcommand_execute): New forward static decl.
3402 * keymap.c (Flookup_key): New forward static decl.
3403 (Fcopy_keymap): Now static.
3404 * keymap.h (Flookup_key): Remove decl.
3405 * process.c (Fget_process): New forward static decl.
3406 (Fprocess_datagram_address): Mark as internal.
3407 * syntax.c (Fsyntax_table_p): New forward static decl.
3408 (skip_chars): Remove duplicate decl.
3409 * textprop.c (Fprevious_property_change): New forward static decl.
3410 * window.c (Fset_window_fringes, Fset_window_scroll_bars):
3411 Now internal.
3412 (Fset_window_margins, Fset_window_vscroll): New forward static decls.
3413 * window.h (Fset_window_vscroll, Fset_window_margins): Remove decls.
3414
785bbd42
PE
3415 * editfns.c (Fformat): Remove unreachable code.
3416
8b913b57
AS
34172011-04-14 Andreas Schwab <schwab@linux-m68k.org>
3418
3419 * fileio.c (Finsert_file_contents): Fix typo in 2005-05-13
3420 change. (Bug#8496)
3421
a6744a35
EZ
34222011-04-13 Eli Zaretskii <eliz@gnu.org>
3423
3424 * xdisp.c (handle_invisible_prop): Don't call bidi_paragraph_init
3425 when at ZV. (Bug#8487)
3426
e7974947
AS
34272011-04-12 Andreas Schwab <schwab@linux-m68k.org>
3428
baad03f0
AS
3429 * charset.c (Fclear_charset_maps): Use xfree instead of free.
3430 (Bug#8437)
3431 * keyboard.c (parse_tool_bar_item): Likewise.
3432 * sound.c (sound_cleanup, alsa_close): Likewise.
3433 * termcap.c (tgetent): Likewise.
3434 * xfns.c (x_default_font_parameter): Likewise.
3435 * xsettings.c (read_and_apply_settings): Likewise.
3436
e7974947
AS
3437 * alloc.c (overrun_check_malloc, overrun_check_realloc)
3438 (overrun_check_free): Protoize.
3439
28272684
PE
34402011-04-12 Paul Eggert <eggert@cs.ucla.edu>
3441
3442 * sysdep.c (emacs_read, emacs_write): Check for negative sizes
3443 since callers should never pass a negative size.
3444 Change the signature to match that of plain 'read' and 'write'; see
3445 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00397.html>.
3446 * lisp.h: Update prototypes of emacs_write and emacs_read.
3447
11997c76
EZ
34482011-04-11 Eli Zaretskii <eliz@gnu.org>
3449
3450 * xdisp.c (redisplay_window): Don't try to determine the character
3451 position of the scroll margin if the window start point w->startp
e896f03c 3452 is outside the buffer's accessible region. (Bug#8468)
11997c76 3453
8a2cbd72
EZ
34542011-04-10 Eli Zaretskii <eliz@gnu.org>
3455
3456 Fix write-region and its subroutines for buffers > 2GB.
3457 * fileio.c (a_write, e_write): Modify declaration of arguments and
3458 local variables to support buffers larger than 2GB.
3459 (Fcopy_file): Use EMACS_INT for return value of emacs_read.
3460
3461 * sysdep.c (emacs_write, emacs_read): Use ssize_t for last
3462 argument, local variables, and return value.
3463
3464 * lisp.h: Update prototypes of emacs_write and emacs_read.
3465
3466 * sound.c (vox_write): Use ssize_t for return value of emacs_write.
3467
4073e537 34682011-04-10 Paul Eggert <eggert@cs.ucla.edu>
eb3f1cc8 3469
1ebfdcb6
PE
3470 * xdisp.c (vmessage): Use memchr, not strnlen, which some hosts lack.
3471
b2ded58d
PE
3472 Fix more problems found by GCC 4.6.0's static checks.
3473
7d66342c
PE
3474 * xdisp.c (vmessage): Use a better test for character truncation.
3475
bbf47d44
PE
3476 * charset.c (load_charset_map): <, not <=, for optimization,
3477 and to avoid potential problems with integer overflow.
9248994d 3478 * chartab.c (sub_char_table_set_range, char_table_set_range): Likewise.
f9a68bc5 3479 * casetab.c (set_identity, shuffle): Likewise.
3ab1c7ce 3480 * editfns.c (Fformat): Likewise.
1e69125e 3481 * syntax.c (skip_chars): Likewise.
3befa583 3482
e3019616
PE
3483 * xmenu.c (set_frame_menubar): Allocate smaller local vectors.
3484 This also lets GCC 4.6.0 generate slightly better loop code.
3485
becfa255
PE
3486 * callint.c (Fcall_interactively): <, not <=, for optimization.
3487 (Fcall_interactively): Count the number of arguments produced,
3488 not the number of arguments given. This is simpler and lets GCC
3489 4.6.0 generate slightly better code.
3490
dae0cd48
PE
3491 * ftfont.c: Distingish more carefully between FcChar8 and char.
3492 The previous code passed unsigned char * to a functions like
3493 strlen and xstrcasecmp that expect char *, which does not
3494 conform to the C standard.
3495 (get_adstyle_property, ftfont_pattern_entity): Use FcChar8 for
3496 arguments to FcPatternGetString, and explicitly cast FcChar8 * to
3497 char * when the C standard requires it.
3498
76032d70
PE
3499 * keyboard.c (read_char): Remove unused var.
3500
eb3f1cc8
PE
3501 * eval.c: Port to Windows vsnprintf (Bug#8435).
3502 Include <limits.h>.
3503 (SIZE_MAX): Define if the headers do not.
3504 (verror): Do not give up if vsnprintf returns a negative count.
3505 Instead, grow the buffer. This ports to Windows vsnprintf, which
3506 does not conform to C99. Problem reported by Eli Zaretskii.
3507 Also, simplify the allocation scheme, by avoiding the need for
3508 calling realloc, and removing the ALLOCATED variable.
3509
70476b54
PE
3510 * eval.c (verror): Initial buffer size is 4000 (not 200) bytes.
3511
12020a9e
PE
3512 Remove invocations of doprnt, as Emacs now uses vsnprintf.
3513 But keep the doprint source code for now, as we might revamp it
3514 and use it again (Bug#8435).
ea6c7ae6
PE
3515 * lisp.h (doprnt): Remove.
3516 * Makefile.in (base_obj): Remove doprnt.o.
3517 * deps.mk (doprnt.o): Remove.
3518
5fdb398c
PE
3519 error: Print 32- and 64-bit integers portably (Bug#8435).
3520 Without this change, on typical 64-bit hosts error ("...%d...", N)
3521 was used to print both 32- and 64-bit integers N, which relied on
3522 undefined behavior.
3523 * lisp.h, src/m/amdx86-64.h, src/m/ia64.h, src/m/ibms390x.h (pEd):
3524 New macro.
3525 * lisp.h (error, verror): Mark as printf-like functions.
3526 * eval.c (verror): Use vsnprintf, not doprnt, to do the real work.
3527 Report overflow in size calculations when allocating printf buffer.
3528 Do not truncate output string at its first null byte.
3529 * xdisp.c (vmessage): Use vsnprintf, not doprnt, to do the real work.
3530 Truncate the output at a character boundary, since vsnprintf does not
3531 do that.
3532 * charset.c (check_iso_charset_parameter): Convert internal
3533 character to string before calling 'error', since %c now has the
3534 printf meaning.
3535 * coding.c (Fdecode_sjis_char, Fdecode_big5_char): Avoid int
3536 overflow when computing char to be passed to 'error'. Do not
3537 pass Lisp_Object to 'error'; pass the integer instead.
3538 * nsfns.m (Fns_do_applescript): Use int, not long, since it's
3539 formatted with plain %d.
3540
b189fa66
PE
3541 * eval.c (internal_lisp_condition_case): Don't pass spurious arg.
3542
bff87ef0
PE
3543 * keyboard.c (access_keymap_keyremap): Print func name, not garbage.
3544
7e2cac20
PE
3545 * coding.c (Fdecode_sjis_char): Don't assume CODE fits in int.
3546
ce4d90b5
PE
3547 * xterm.c (x_catch_errors): Remove duplicate declaration.
3548
266c9547
PE
3549 * term.c (maybe_fatal): Mark its 3rd arg as a printf format, too.
3550
79c49ad2
PE
3551 * xdisp.c, lisp.h (message_nolog): Remove; unused.
3552
368f4090
JM
35532011-04-10 Jim Meyering <meyering@redhat.com>
3554
3555 use ssize_t and size_t for read- and write-like emacs_gnutls_* functions
3556 * gnutls.c (emacs_gnutls_read): Adjust signature to be more read-like:
3557 return ssize_t not "int", and use size_t as the buffer length.
3558 (emacs_gnutls_write): Likewise, and make the buffer pointer "const".
3559 * gnutls.h: Update declarations.
3560 * process.c (read_process_output): Use ssize_t, to match.
3561 (send_process): Likewise.
3562
a32d4040
CY
35632011-04-09 Chong Yidong <cyd@stupidchicken.com>
3564
3565 * image.c (Fimagemagick_types): Doc fix, and comment cleanup.
3566
8546720e 35672011-04-09 Chong Yidong <cyd@stupidchicken.com>
aac0c6e3 3568
04f2d78b
CB
3569 * ftfont.c (get_adstyle_property, ftfont_pattern_entity):
3570 Use unsigned char, to match FcChar8 type definition.
aac0c6e3 3571
8546720e
GM
3572 * xterm.c (handle_one_xevent):
3573 * xmenu.c (create_and_show_popup_menu):
3574 * xselect.c (x_decline_selection_request)
3575 (x_reply_selection_request): Avoid type-punned deref of X events.
aac0c6e3 3576
0a2f5c1a 35772011-04-09 Eli Zaretskii <eliz@gnu.org>
a53e2e89
EZ
3578
3579 Fix some uses of `int' instead of EMACS_INT.
3580 * search.c (string_match_1, fast_string_match)
3581 (fast_c_string_match_ignore_case, fast_string_match_ignore_case)
3582 (scan_buffer, find_next_newline_no_quit)
3583 (find_before_next_newline, search_command, Freplace_match)
3584 (Fmatch_data): Make some `int' variables be EMACS_INT.
3585
3586 * xdisp.c (display_count_lines): 3rd argument and return value now
3587 EMACS_INT. All callers changed.
3588 (pint2hrstr): Last argument is now EMACS_INT.
3589
3590 * coding.c (detect_coding_utf_8, detect_coding_emacs_mule)
3591 (detect_coding_iso_2022, detect_coding_sjis, detect_coding_big5)
3592 (detect_coding_ccl, detect_coding_charset, decode_coding_utf_8)
3593 (decode_coding_utf_16, decode_coding_emacs_mule)
3594 (decode_coding_iso_2022, decode_coding_sjis, decode_coding_big5)
3595 (decode_coding_ccl, decode_coding_charset)
3596 <consumed_chars, consumed_chars_base>: Declare EMACS_INT.
3597 (decode_coding_iso_2022, decode_coding_emacs_mule)
3598 (decode_coding_sjis, decode_coding_big5, decode_coding_charset)
3599 <char_offset, last_offset>: Declare EMACS_INT.
3600 (encode_coding_utf_8, encode_coding_utf_16)
3601 (encode_coding_emacs_mule, encode_invocation_designation)
3602 (encode_designation_at_bol, encode_coding_iso_2022)
3603 (encode_coding_sjis, encode_coding_big5, encode_coding_ccl)
3604 (encode_coding_raw_text, encode_coding_charset) <produced_chars>:
3605 Declare EMACS_INT.
3606 (ASSURE_DESTINATION): Declare more_bytes EMACS_INT.
3607 (encode_invocation_designation): Last argument P_NCHARS is now
3608 EMACS_INT.
3609 (decode_eol): Declare pos_byte, pos, and pos_end EMACS_INT.
3610 (produce_chars): from_nchars and to_nchars are now EMACS_INT.
3611
3612 * coding.h (struct coding_system) <head_ascii>: Declare EMACS_INT.
3613 All users changed.
3614
3615 * ccl.c (Fccl_execute_on_string): Declare some variables
3616 EMACS_INT.
3617
8546720e 36182011-04-08 Samuel Thibault <sthibault@debian.org> (tiny change)
0080dc6b
SS
3619
3620 * term.c (init_tty): Fix incorrect ifdef placement (Bug#8450).
3621
4e19a977
CS
36222011-03-19 Christoph Scholtes <cschol2112@googlemail.com>
3623
3624 * process.c (Fformat_network_address): Doc fix.
3625
87302331
R
36262011-04-08 T.V. Raman <tv.raman.tv@gmail.com> (tiny change)
3627
3628 * xml.c (parse_region): Avoid creating spurious whiespace nodes.
3629
cbb59342
CY
36302011-04-08 Chong Yidong <cyd@stupidchicken.com>
3631
3632 * keyboard.c (read_char): Call Lisp function help-form-show,
3633 instead of using internal_with_output_to_temp_buffer.
3634 (Qhelp_form_show): New var.
e0d38eeb 3635 (syms_of_keyboard): Use DEFSYM macro.
cbb59342
CY
3636
3637 * print.c (internal_with_output_to_temp_buffer): Function deleted.
3638
3639 * lisp.h (internal_with_output_to_temp_buffer): Remove prototype.
3640
e67a13ab
CY
36412011-04-06 Chong Yidong <cyd@stupidchicken.com>
3642
04f2d78b
CB
3643 * process.c (Flist_processes): Remove to Lisp.
3644 (list_processes_1): Delete.
e67a13ab 3645
973f782d
EZ
36462011-04-06 Eli Zaretskii <eliz@gnu.org>
3647
7c106b1e
EZ
3648 * msdos.c (careadlinkat, careadlinkatcwd): MS-DOS replacements.
3649
973f782d
EZ
3650 * w32.c (careadlinkat, careadlinkatcwd): New always-fail stubs.
3651
41cf7d1a 36522011-04-06 Paul Eggert <eggert@cs.ucla.edu>
27ccc379 3653
ca23cc88
PE
3654 Fix more problems found by GCC 4.6.0's static checks.
3655
f390e2d5
PE
3656 * xmenu.c (Fx_popup_dialog): Don't assume string is free of formats.
3657
42eea0d0
PE
3658 * menu.c (Fx_popup_menu): Don't assume error_name lacks printf formats.
3659
b69769da 3660 * lisp.h (message, message_nolog, fatal): Mark as printf-like.
1e973bc7 3661
f9541e84
PE
3662 * xdisp.c (vmessage): Mark as a printf-like function.
3663
13841b55
PE
3664 * term.c (vfatal, maybe_fatal): Mark as printf-like functions.
3665
c136c10f
PE
3666 * sound.c (sound_warning): Don't crash if arg contains a printf format.
3667
5e2d4a30
PE
3668 * image.c (tiff_error_handler, tiff_warning_handler): Mark as
3669 printf-like functions.
3670 (tiff_load): Add casts to remove these marks before passing them
3671 to system-supplied API.
3672
583f48b9
PE
3673 * eval.c (Fsignal): Remove excess argument to 'fatal'.
3674
b25d760e
PE
3675 * coding.c (EMIT_ONE_BYTE, EMIT_TWO_BYTES): Use unsigned, not int.
3676 This avoids several warnings with gcc -Wstrict-overflow.
d5efd1d1
PE
3677 (DECODE_COMPOSITION_RULE): If the rule is invalid, goto invalid_code
3678 directly, rather than having caller test rule sign. This avoids
3679 some unnecessary tests.
3680 * composite.h (COMPOSITION_ENCODE_RULE_VALID): New macro.
3681 (COMPOSITION_ENCODE_RULE): Arguments now must be valid. This
3682 affects only one use, in DECODE_COMPOSITION_RULE, which is changed.
b25d760e 3683
bc7b6697 3684 * xfont.c (xfont_text_extents): Remove var that was set but not used.
625a3eb1 3685 (xfont_open): Avoid unnecessary tests.
bc7b6697 3686
27ccc379
PE
3687 * composite.c (composition_gstring_put_cache): Use unsigned integer.
3688
dcd5c89a
PE
3689 * composite.h, composite.c (composition_gstring_put_cache):
3690 Use EMACS_INT, not int, for length.
3691
b13a45c6
PE
3692 * composite.h (COMPOSITION_DECODE_REFS): New macro,
3693 breaking out part of COMPOSITION_DECODE_RULE.
3694 (COMPOSITION_DECODE_RULE): Use it.
3695 * composite.c (get_composition_id): Remove unused local vars,
3696 by using the new macro.
3697
1e792e4d
PE
3698 * textprop.c (set_text_properties_1): Change while to do-while,
3699 since the condition is always true at first.
3700
dc6c6455 3701 * intervals.c (graft_intervals_into_buffer): Mark var as used.
aa86731f
PE
3702 (interval_deletion_adjustment): Return unsigned value.
3703 All uses changed.
dc6c6455 3704
aba7731a
PE
3705 * process.c (list_processes_1, create_pty, read_process_output):
3706 (exec_sentinel): Remove vars that were set but not used.
afd4052b 3707 (create_pty): Remove unnecessary "volatile"s.
bc57d757 3708 (Fnetwork_interface_info): Avoid possibility of int overflow.
82eaa333 3709 (read_process_output): Do adaptive read buffering even if carryover.
fe07cdfa 3710 (read_process_output): Simplify nbytes computation if buffered.
aba7731a 3711
fdfc4bf3
PE
3712 * bytecode.c (exec_byte_code): Rename local to avoid shadowing.
3713
fca8fe46 3714 * syntax.c (scan_words): Remove var that was set but not used.
12cbf13f 3715 (update_syntax_table): Use unsigned instead of int.
fca8fe46 3716
06a0259a 3717 * lread.c (lisp_file_lexically_bound_p): Use ints rather than endptrs.
3c346cc3 3718 (lisp_file_lexically_bound_p, read1): Use unsigned instead of int.
e6eb4e9e 3719 (safe_to_load_p): Make the end-of-loop test the inverse of the in-loop.
06a0259a 3720
e7b9e80f
PE
3721 * print.c (print_error_message): Avoid int overflow.
3722
56201685
PE
3723 * font.c (font_list_entities): Redo for clarity,
3724 so that reader need not know FONT_DPI_INDEX + 1 == FONT_SPACING_INDEX.
3725
78834453 3726 * font.c (font_find_for_lface, Ffont_get_glyphs): Remove unused vars.
790771b1 3727 (font_score): Avoid potential overflow in diff calculation.
78834453 3728
0bc0b309 3729 * fns.c (substring_both): Remove var that is set but not used.
8cd55cb4 3730 (sxhash): Redo loop for clarity and to avoid wraparound warning.
0bc0b309 3731
e610eaca
PE
3732 * eval.c (funcall_lambda): Rename local to avoid shadowing.
3733
b895abce
PE
3734 * alloc.c (mark_object_loop_halt, mark_object): Use size_t, not int.
3735 Otherwise, GCC 4.6.0 optimizes the loop check away since the check
3736 can always succeed if overflow has undefined behavior.
3737
1f1d9321 3738 * search.c (boyer_moore, wordify): Remove vars set but not used.
6f076cc7 3739 (wordify): Omit three unnecessary tests.
1f1d9321 3740
c59478bc
PE
3741 * indent.c (MULTIBYTE_BYTES_WIDTH): Don't compute wide_column.
3742 All callers changed. This avoids the need for an unused var.
3743
79b73827
PE
3744 * casefiddle.c (casify_region): Remove var that is set but not used.
3745
a4db5dfe
PE
3746 * dired.c (file_name_completion): Remove var that is set but not used.
3747
43aae36e
PE
3748 * fileio.c (Finsert_file_contents): Make EOF condition clearer.
3749
2a47c44d 3750 * fileio.c (Finsert_file_contents): Avoid signed integer overflow.
163c5f32 3751 (Finsert_file_contents): Remove unnecessary code checking fd.
2a47c44d 3752
a37c69bf
PE
3753 * minibuf.c (read_minibuf_noninteractive): Use size_t for sizes.
3754 Check for integer overflow on size calculations.
3755
328ab8e7
PE
3756 * buffer.c (Fprevious_overlay_change): Remove var that is set
3757 but not used.
3758
e5a2a5cb
PE
3759 * keyboard.c (menu_bar_items, read_char_minibuf_menu_prompt):
3760 Remove vars that are set but not used.
8d84a6eb 3761 (timer_check_2): Don't assume timer-list and idle-timer-list are lists.
6b043475 3762 (timer_check_2): Mark vars as initialized.
e5a2a5cb 3763
a60e5f68
PE
3764 * gtkutil.c (xg_get_file_with_chooser): Mark var as initialized.
3765
f661cb61 3766 * image.c (lookup_image): Remove var that is set but not used.
35fa624f 3767 (xbm_load): Use parse_p, for gcc -Werror=unused-but-set-variable.
f661cb61 3768
f0397f5a
PE
3769 * fontset.c (Finternal_char_font, Ffontset_info): Remove vars
3770 that are set but not used.
3771
8664db06 3772 * xfns.c (make_invisible_cursor): Don't return garbage
03733ee7 3773 if XCreateBitmapFromData fails (Bug#8410).
8664db06 3774
6abdaa4a
PE
3775 * xselect.c (x_get_local_selection, x_handle_property_notify):
3776 Remove vars that are set but not used.
3777
0ce7538d 3778 * xfns.c (x_create_tip_frame): Remove var that is set but not used.
6abdaa4a 3779 (make_invisible_cursor): Initialize a possibly-uninitialized variable.
0ce7538d 3780
9ae848fc
PE
3781 * xterm.c (x_scroll_bar_to_input_event) [!USE_GTK]:
3782 Remove var that is set but not used.
0b918413
PE
3783 (scroll_bar_windows_size): Now size_t, not int.
3784 (x_send_scroll_bar_event): Use size_t, not int, for sizes.
3785 Check for overflow.
9ae848fc 3786
a5a62657
PE
3787 * xfaces.c (realize_named_face): Remove vars that are set but not used.
3788 (map_tty_color) [!defined MSDOS]: Likewise.
3789
5c5cdd39
PE
3790 * term.c (tty_write_glyphs): Use size_t; this avoids overflow warning.
3791
66ebf983
PE
3792 * coding.c: Remove vars that are set but not used.
3793 (DECODE_COMPOSITION_RULE): Remove 2nd arg, which is unused.
3794 All callers changed.
3795 (decode_coding_utf_8, decode_coding_utf_16 decode_coding_emacs_mule):
3796 (decode_coding_iso_2022, encode_coding_sjis, encode_coding_big5):
3797 (decode_coding_charset): Remove vars that are set but not used.
3798
1be4d761
PE
3799 * bytecode.c (Fbyte_code) [!defined BYTE_CODE_SAFE]: Remove var
3800 that is set but not used.
3801
47553fa8
PE
3802 * print.c (print_object): Remove var that is set but not used.
3803
1f7196bf 3804 Replace 2 copies of readlink code with 1 gnulib version (Bug#8401).
d1fdcab7
PE
3805 The gnulib version avoids calling malloc in the usual case,
3806 and on 64-bit hosts doesn't have some arbitrary 32-bit limits.
3807 * fileio.c (Ffile_symlink_p): Use emacs_readlink.
3808 * filelock.c (current_lock_owner): Likewise.
3809 * lisp.h (READLINK_BUFSIZE, emacs_readlink): New function.
3810 * sysdep.c: Include allocator.h, careadlinkat.h.
3811 (emacs_no_realloc_allocator): New static constant.
3812 (emacs_readlink): New function.
fdb61804
PE
3813 * deps.mk (sysdep.o): Depend on ../lib/allocator.h and on
3814 ../lib/careadlinkat.h.
d1fdcab7 3815
f84c17c7
SM
38162011-04-04 Stefan Monnier <monnier@iro.umontreal.ca>
3817
3818 * keyboard.c (safe_run_hook_funcall): Fix last change (don't stop at the
3819 first non-nil return value).
3820
ef3862ad
JD
38212011-04-03 Jan Djärv <jan.h.d@swipnet.se>
3822
3823 * nsterm.m (ns_update_auto_hide_menu_bar): Define MAC_OS_X_VERSION_10_6
3824 if not defined (Bug#8403).
3825
376a7006
JB
38262011-04-02 Juanma Barranquero <lekktu@gmail.com>
3827
3828 * xdisp.c (display_count_lines): Remove parameter `start',
3829 unused since 1998-01-01T02:27:27Z!rms@gnu.org. All callers changed.
3830 (get_char_face_and_encoding): Remove parameter `multibyte_p',
3831 unused since 2008-05-14T01:40:23Z!handa@m17n.org. All callers changed.
3832 (fill_stretch_glyph_string): Remove parameters `row' and `area',
3833 unused at least since Kim's GUI unification at 2003-03-16T20:45:46Z!storm@cua.dk
3834 and thereabouts. All callers changed.
3835 (get_per_char_metric): Remove parameter `f', unused since
3836 2008-05-14T01:40:23Z!handa@m17n.org. All callers changed.
3837
6ca3801d
JM
38382011-04-02 Jim Meyering <meyering@redhat.com>
3839
3840 do not dereference NULL upon failed strdup
3841 * nsfont.m (ns_descriptor_to_entity): Use xstrdup, not strdup.
3842 (ns_get_family): Likewise.
3843
d8e2b5ba
JB
38442011-04-02 Juanma Barranquero <lekktu@gmail.com>
3845
3846 * eval.c (unwind_to_catch) [DEBUG_GCPRO]: Remove redundant assignment.
3847
8c74fcbd
JD
38482011-04-02 Jan Djärv <jan.h.d@swipnet.se>
3849
3850 * nsterm.m (ns_update_auto_hide_menu_bar): Only for OSX 10.6 or
3851 later (Bug#8403).
3852
7200d79c
SM
38532011-04-01 Stefan Monnier <monnier@iro.umontreal.ca>
3854
03408648 3855 Add lexical binding.
7200d79c 3856
03408648
SM
3857 * window.c (Ftemp_output_buffer_show): New fun.
3858 (Fsave_window_excursion):
3859 * print.c (Fwith_output_to_temp_buffer): Move to subr.el.
3860
3861 * lread.c (lisp_file_lexically_bound_p): New function.
3862 (Fload): Bind Qlexical_binding.
3863 (readevalloop): Remove `evalfun' arg.
3864 Bind Qinternal_interpreter_environment.
3865 (Feval_buffer): Bind Qlexical_binding.
3866 (defvar_int, defvar_bool, defvar_lisp_nopro, defvar_kboard):
3867 Mark as dynamic.
3868 (syms_of_lread): Declare `lexical-binding'.
3869
3870 * lisp.h (struct Lisp_Symbol): New field `declared_special'.
3871
3872 * keyboard.c (eval_dyn): New fun.
3873 (menu_item_eval_property): Use it.
ca105506
SM
3874
3875 * image.c (parse_image_spec): Use Ffunctionp.
ca105506 3876
03408648
SM
3877 * fns.c (concat, mapcar1): Accept byte-code-functions.
3878
3879 * eval.c (Fsetq): Handle lexical vars.
3880 (Fdefun, Fdefmacro, Ffunction): Make closures when needed.
3881 (Fdefconst, Fdefvaralias, Fdefvar): Mark as dynamic.
3882 (FletX, Flet): Obey lexical binding.
3883 (Fcommandp): Handle closures.
3884 (Feval): New `lexical' arg.
3885 (eval_sub): New function extracted from Feval. Use it almost
3886 everywhere where Feval was used. Look up vars in lexical env.
3887 Handle closures.
3888 (Ffunctionp): Move from subr.el.
3889 (Ffuncall): Handle closures.
3890 (apply_lambda): Remove `eval_flags'.
3891 (funcall_lambda): Handle closures and new byte-code-functions.
3892 (Fspecial_variable_p): New function.
3893 (syms_of_eval): Initialize the Vinternal_interpreter_environment var,
3894 but without exporting it to Lisp.
23aba0ea 3895
23aba0ea 3896 * doc.c (Fdocumentation, store_function_docstring):
03408648 3897 * data.c (Finteractive_form): Handle closures.
23aba0ea 3898
03408648
SM
3899 * callint.c (Fcall_interactively): Preserve lexical-binding mode for
3900 interactive spec.
ba83908c 3901
04f2d78b
CB
3902 * bytecode.c (Bstack_ref, Bstack_set, Bstack_set2, BdiscardN):
3903 New byte-codes.
03408648
SM
3904 (exec_byte_code): New function extracted from Fbyte_code to handle new
3905 calling convention for byte-code-functions. Add new byte-codes.
ba83908c 3906
03408648 3907 * buffer.c (defvar_per_buffer): Set new `declared_special' field.
e2abe5a1 3908
03408648 3909 * alloc.c (Fmake_symbol): Init new `declared_special' field.
e2abe5a1 3910
e2abce01
JB
39112011-03-31 Juanma Barranquero <lekktu@gmail.com>
3912
3913 * xdisp.c (redisplay_internal): Fix prototype.
3914
63696a73 39152011-03-31 Eli Zaretskii <eliz@gnu.org>
09725d26 3916
63696a73 3917 * xdisp.c (SCROLL_LIMIT): New macro.
04f2d78b
CB
3918 (try_scrolling): Use it when setting scroll_limit.
3919 Limit scrolling to 100 screen lines.
63696a73
EZ
3920 (redisplay_window): Even when falling back on "recentering",
3921 position point in the window according to scroll-conservatively,
3922 scroll-margin, and scroll-*-aggressively variables. (Bug#6671)
3923
3924 (try_scrolling): When point is above the window, allow searching
3925 as far as scroll_max, or one screenful, to compute vertical
3926 distance from PT to the scroll margin position. This prevents
3927 try_scrolling from unnecessarily failing when
3928 scroll-conservatively is set to a value slightly larger than the
3929 window height. Clean up the case of PT below the margin at bottom
3930 of window: scroll_max can no longer be INT_MAX. When aggressive
3931 scrolling is in use, don't let point enter the opposite scroll
3932 margin as result of the scroll.
3933 (syms_of_xdisp) <scroll-conservatively>: Document the
09725d26
EZ
3934 threshold of 100 lines for never-recentering scrolling.
3935
e4cc2dfc
JB
39362011-03-31 Juanma Barranquero <lekktu@gmail.com>
3937
3938 * dispextern.h (move_it_by_lines):
3939 * xdisp.c (move_it_by_lines): Remove parameter `need_y_p', unused
3940 since 2000-12-29T14:24:09Z!gerd@gnu.org. All callers changed.
3941 (message_log_check_duplicate): Remove parameters `prev_bol' and
3942 `this_bol', unused since 1998-01-01T02:27:27Z!rms@gnu.org. All callers changed.
3943 (redisplay_internal): Remove parameter `preserve_echo_area',
3944 unused since 1999-07-21T21:43:52Z!gerd@gnu.org. All callers changed.
3945
3946 * indent.c (Fvertical_motion):
3947 * window.c (window_scroll_pixel_based, Frecenter):
3948 Don't pass `need_y_p' to `move_it_by_lines'.
3949
1c470562
SM
39502011-03-30 Stefan Monnier <monnier@iro.umontreal.ca>
3951
44f230aa
SM
3952 * eval.c (struct backtrace): Don't cheat with negative numbers, but do
3953 steal a few bits to be more compact.
3954 (interactive_p, Fbacktrace, Fbacktrace_frame, mark_backtrace):
3955 Remove unneeded casts.
3956
1c470562
SM
3957 * bytecode.c (Fbyte_code): CAR and CDR can GC.
3958
888adce9
ZK
39592011-03-30 Zachary Kanfer <zkanfer@gmail.com> (tiny change)
3960
3961 * keyboard.c (Fexecute_extended_command): Do log the "suggest key
3962 binding" message (bug#7967).
3963
f838ed7b
PE
39642011-03-30 Paul Eggert <eggert@cs.ucla.edu>
3965
77861b95
PE
3966 Fix more problems found by GCC 4.6.0's static checks.
3967
de6dbc14
PE
3968 * unexelf.c (unexec) [! (defined _SYSTYPE_SYSV || defined __sgi)]:
3969 Remove unused local var.
3970
f838ed7b
PE
3971 * editfns.c (Fmessage_box): Remove unused local var.
3972
792c7b2b
PE
3973 * xdisp.c (try_window_reusing_current_matrix, x_produce_glyphs):
3974 (note_mode_line_or_margin_highlight, note_mouse_highlight):
3975 Omit unused local vars.
c499e557 3976 * window.c (shrink_windows): Omit unused local var.
b01a1c29 3977 * menu.c (digest_single_submenu): Omit unused local var.
0bc32927
PE
3978 * dispnew.c (update_window) [PERIODIC_PREEMPTION_CHECKING]:
3979 Omit unused local var.
3980
ba0165e1
PE
3981 * keyboard.c (parse_modifiers_uncached, parse_modifiers):
3982 Don't assume string length fits in int.
32ad8845 3983 (keyremap_step, read_key_sequence): Use size_t for sizes.
48011560 3984 (read_key_sequence): Don't check last_real_key_start redundantly.
ba0165e1 3985
3c59b4c9
PE
3986 * callproc.c (Fcall_process, Fcall_process_region): Use SAFE_ALLOCA
3987 instead of alloca (Bug#8344).
3988
a3eed478 3989 * eval.c (Fbacktrace): Don't assume nargs fits in int.
5d5d959d 3990 (Fbacktrace_frame): Don't assume nframes fits in int.
a3eed478 3991
eb4d412d
PE
3992 * syntax.c (scan_sexps_forward): Avoid pointer wraparound.
3993
1658b401
PE
3994 * xterm.c (x_make_frame_visible, same_x_server): Redo to avoid overflow
3995 concerns.
3996
3997 * term.c (produce_glyphless_glyph): Remove unnecessary test.
3998
3999 * cm.c (calccost): Turn while-do into do-while, for clarity.
44f730c8 4000
9a2c6e05
PE
4001 * keyboard.c (syms_of_keyboard): Use the same style as later
4002 in this function when indexing through an array. This also
4003 works around GCC bug 48267.
4004
03d0a109
PE
4005 * image.c (tiff_load): Fix off-by-one image count (Bug#8336).
4006
44f730c8
PE
4007 * xselect.c (x_check_property_data): Return correct size (Bug#8335).
4008
fe75f926
PE
4009 * chartab.c (sub_char_table_ref_and_range): Redo for slight
4010 efficiency gain, and to bypass a gcc -Wstrict-overflow warning.
4011
ffa8c828
PE
4012 * keyboard.c, keyboard.h (num_input_events): Now size_t.
4013 This avoids undefined behavior on integer overflow, and is a bit
4014 more convenient anyway since it is compared to a size_t variable.
4015
c5101a77
PE
4016 Variadic C functions now count arguments with size_t, not int.
4017 This avoids an unnecessary limitation on 64-bit machines, which
4018 caused (substring ...) to crash on large vectors (Bug#8344).
4019 * lisp.h (struct Lisp_Subr.function.aMANY): Now takes size_t, not int.
4020 (DEFUN_ARGS_MANY, internal_condition_case_n, safe_call): Likewise.
77861b95 4021 All variadic functions and their callers changed accordingly.
c5101a77
PE
4022 (struct gcpro.nvars): Now size_t, not int. All uses changed.
4023 * data.c (arith_driver, float_arith_driver): Likewise.
4024 * editfns.c (general_insert_function): Likewise.
4025 * eval.c (struct backtrace.nargs, interactive_p)
4026 (internal_condition_case_n, run_hook_with_args, apply_lambda)
4027 (funcall_lambda, mark_backtrace): Likewise.
4028 * fns.c (concat): Likewise.
4029 * frame.c (x_set_frame_parameters): Likewise.
4030 * fns.c (get_key_arg): Now accepts and returns size_t, and returns
4031 0 if not found, not -1. All callers changed.
4032
dd3f25f7
PE
4033 * alloc.c (garbage_collect): Don't assume stack size fits in int.
4034 (stack_copy_size): Now size_t, not int.
4035 (stack_copy, stack_copy_size): Define only if MAX_SAVE_STACK > 0.
4036
461c2ab9
JB
40372011-03-28 Juanma Barranquero <lekktu@gmail.com>
4038
4039 * coding.c (encode_designation_at_bol): Remove parameter `charbuf_end',
4040 unused since 2002-03-01T01:17:24Z!handa@m17n.org and 2008-02-01T16:01:31Z!miles@gnu.org.
4041 All callers changed.
4042
4043 * lisp.h (multibyte_char_to_unibyte):
4044 * character.c (multibyte_char_to_unibyte): Remove parameter `rev_tbl',
4045 unused since 2002-03-01T01:16:34Z!handa@m17n.org and 2008-02-01T16:01:31Z!miles@gnu.org.
4046 * character.h (CHAR_TO_BYTE8):
4047 * cmds.c (internal_self_insert):
4048 * editfns.c (general_insert_function):
4049 * keymap.c (push_key_description):
4050 * search.c (Freplace_match):
4051 * xdisp.c (message_dolog, set_message_1): All callers changed.
4052
f6d62986
SM
40532011-03-28 Stefan Monnier <monnier@iro.umontreal.ca>
4054
4055 * keyboard.c (safe_run_hook_funcall): New function.
4056 (safe_run_hooks_1, safe_run_hooks_error, safe_run_hooks): On error,
4057 don't set the hook to nil, but remove the offending function instead.
4058 (Qcommand_hook_internal): Remove, unused.
4059 (syms_of_keyboard): Don't initialize Qcommand_hook_internal nor define
4060 Vcommand_hook_internal.
4061
4062 * eval.c (enum run_hooks_condition): Remove.
4063 (funcall_nil, funcall_not): New functions.
4064 (run_hook_with_args): Call each function through a `funcall' argument.
4065 Remove `cond' argument, now redundant.
4066 (Frun_hooks, Frun_hook_with_args, Frun_hook_with_args_until_success)
4067 (Frun_hook_with_args_until_failure): Adjust accordingly.
4068 (run_hook_wrapped_funcall, Frun_hook_wrapped): New functions.
4069
1db5b1ad
JB
40702011-03-28 Juanma Barranquero <lekktu@gmail.com>
4071
4072 * dispextern.h (string_buffer_position): Remove declaration.
4073
4074 * print.c (strout): Remove parameter `multibyte', unused since
4075 1999-08-21T19:30:21Z!gerd@gnu.org. All callers changed.
4076
4077 * search.c (boyer_moore): Remove parameters `len', `pos' and `lim',
4078 never used since function introduction in 1998-02-08T21:33:56Z!rms@gnu.org.
4079 All callers changed.
4080
4081 * w32.c (_wsa_errlist): Use braces for struct initializers.
4082
4083 * xdisp.c (string_buffer_position_lim): Remove parameter `w',
4084 never used since function introduction in 2001-03-09T18:41:50Z!gerd@gnu.org.
4085 All callers changed.
4086 (string_buffer_position): Likewise. Also, make static (it's never
4087 used outside xdisp.c).
4088 (cursor_row_p): Remove parameter `w', unused since
4089 2000-10-17T16:08:57Z!gerd@gnu.org. All callers changed.
4090 (decode_mode_spec): Remove parameter `precision', introduced during
4091 Gerd Moellmann's rewrite at 1999-07-21T21:43:52Z!gerd@gnu.org, but never used.
4092 All callers changed.
4093
5ffb62aa
JD
40942011-03-27 Jan Djärv <jan.h.d@swipnet.se>
4095
4096 * nsterm.m (syms_of_nsterm): Use doc: for ns-auto-hide-menu-bar.
4097
461c2ab9 40982011-03-27 Anders Lindgren <andlind@gmail.com>
f0a1382a
JD
4099
4100 * nsterm.m (ns_menu_bar_is_hidden): New variable.
4101 (ns_constrain_all_frames, ns_menu_bar_should_be_hidden)
4102 (ns_update_auto_hide_menu_bar): New functions.
4103 (ns_update_begin): Call ns_update_auto_hide_menu_bar.
4104 (applicationDidBecomeActive): Call ns_update_auto_hide_menu_bar and
4105 ns_constrain_all_frames.
4106 (constrainFrameRect): Return at once if ns_menu_bar_should_be_hidden.
4107 (syms_of_nsterm): DEFVAR ns-auto-hide-menu-bar, init to Qnil.
4108
5c380ffb
JD
41092011-03-27 Jan Djärv <jan.h.d@swipnet.se>
4110
4111 * nsmenu.m (runDialogAt): Remove argument to timer_check.
4112
9af30bdf
GM
41132011-03-27 Glenn Morris <rgm@gnu.org>
4114
4115 * syssignal.h: Replace RETSIGTYPE with void.
4116 * atimer.c, data.c, dispnew.c, emacs.c, floatfns.c, keyboard.c:
4117 * keyboard.h, lisp.h, process.c, sysdep.c, xterm.c:
4118 Replace SIGTYPE with void everywhere.
4119 * s/usg5-4-common.h (SIGTYPE): Remove definition.
4120 * s/template.h (SIGTYPE): Remove commented out definition.
4121
e2abce01
JB
41222011-03-26 Eli Zaretskii <eliz@gnu.org>
4123
4124 * xdisp.c (redisplay_window): Don't check buffer's clip_changed
4125 flag as a prerequisite for invoking try_scrolling. (Bug#6671)
4126
f868cd8a
JB
41272011-03-26 Juanma Barranquero <lekktu@gmail.com>
4128
59eb0929
JB
4129 * w32.c (read_unc_volume): Use parameter `henum', instead of
4130 global variable `wget_enum_handle'.
4131
4132 * keymap.c (describe_vector): Remove parameters `indices' and
4133 `char_table_depth', unused since 2002-03-01T01:43:26Z!handa@m17n.org.
4134 (describe_map, Fdescribe_vector): Adjust calls to `describe_vector'.
4135
f868cd8a
JB
4136 * keyboard.h (timer_check, show_help_echo): Remove unused parameters.
4137
4138 * keyboard.c (timer_check): Remove parameter `do_it_now',
4139 unused since 1996-04-12T06:01:29Z!rms@gnu.org.
4140 (show_help_echo): Remove parameter `ok_to_overwrite_keystroke_echo',
4141 unused since 2008-04-19T19:30:53Z!monnier@iro.umontreal.ca.
4142
4143 * keyboard.c (read_char):
4144 * w32menu.c (w32_menu_display_help):
4145 * xmenu.c (show_help_event, menu_help_callback):
4146 Adjust calls to `show_help_echo'.
4147
4148 * gtkutil.c (xg_maybe_add_timer):
4149 * keyboard.c (readable_events):
4150 * process.c (wait_reading_process_output):
4151 * xmenu.c (x_menu_wait_for_event): Adjust calls to `timer_check'.
4152
4153 * insdel.c (adjust_markers_gap_motion):
4154 Remove; no-op since 1998-01-02T21:29:48Z!rms@gnu.org.
4155 (gap_left, gap_right): Don't call it.
4156
2ecf6fdb
CY
41572011-03-25 Chong Yidong <cyd@stupidchicken.com>
4158
4159 * xdisp.c (handle_fontified_prop): Discard changes to clip_changed
4160 incurred during fontification.
4161
6b1f9ba4
JB
41622011-03-25 Juanma Barranquero <lekktu@gmail.com>
4163
4164 * buffer.c (defvar_per_buffer): Remove unused parameter `doc'.
4165 (DEFVAR_PER_BUFFER): Don't pass it.
4166
4167 * dispnew.c (row_equal_p, add_row_entry): Remove unused parameter `w'.
4168 (scrolling_window): Don't pass it.
4169
0f4a96b5
JB
41702011-03-25 Juanma Barranquero <lekktu@gmail.com>
4171
4172 * dispextern.h (glyph_matric): Use #if GLYPH_DEBUG, not #ifdef.
4173
4174 * fileio.c (check_executable) [DOS_NT]: Remove unused variables `len'
4175 and `suffix'.
4176 (Fset_file_selinux_context) [HAVE_LIBSELINUX]: Move here declaration
4177 of variables specific to SELinux and computation of `encoded_absname'.
4178
4179 * image.c (XPutPixel): Remove unused variable `height'.
4180
4181 * keyboard.c (make_lispy_event): Remove unused variable `hpos'.
4182
4183 * unexw32.c (get_section_info): Remove unused variable `section'.
4184
4185 * w32.c (stat): Remove unused variables `drive_root' and `devtype'.
4186 (system_process_attributes): Remove unused variable `sess'.
4187 (sys_read): Remove unused variable `err'.
4188
4189 * w32fns.c (top): Wrap variables with #if GLYPH_DEBUG, not #ifdef.
4190 (w32_wnd_proc): Remove unused variable `isdead'.
4191 (unwind_create_frame): Use #if GLYPH_DEBUG, not #ifdef.
4192 (Fx_server_max_request_size): Remove unused variable `dpyinfo'.
4193 (x_create_tip_frame): Remove unused variable `tem'.
4194
4195 * w32inevt.c (w32_console_read_socket):
4196 Remove unused variable `no_events'.
4197
4198 * w32term.c (x_draw_composite_glyph_string_foreground):
4199 Remove unused variable `width'.
4200
1149507c
JB
42012011-03-24 Juanma Barranquero <lekktu@gmail.com>
4202
4203 * w32term.c (x_set_glyph_string_clipping):
4204 Don't pass uninitialized region to CombineRgn.
4205
9c88f339
JB
42062011-03-23 Juanma Barranquero <lekktu@gmail.com>
4207
4208 * w32fns.c (x_set_menu_bar_lines): Remove unused variable `olines'.
4209 (w32_wnd_proc): Pass NULL to Windows API, not uninitialized buffer.
4210 (Fx_close_connection): Remove unused variable `i'.
4211
4212 * w32font.c (w32font_draw): Return number of glyphs.
4213 (w32font_open_internal): Remove unused variable `i'.
4214 (w32font_driver): Add missing initializer.
4215
4216 * w32menu.c (utf8to16): Remove unused variable `utf16'.
4217 (fill_in_menu): Remove unused variable `items_added'.
4218
4219 * w32term.c (last_mouse_press_frame): Remove static global variable.
4220 (w32_clip_to_row): Remove unused variable `f'.
4221 (x_delete_terminal): Remove unused variable `i'.
4222
4223 * w32uniscribe.c (uniscribe_shape): Remove unused variable `nclusters'.
4224 (NOTHING): Remove unused static global variable.
4225 (uniscribe_check_otf): Remove unused variable `table'.
4226 (uniscribe_font_driver): Add missing initializers.
4227
dee091a3
JD
42282011-03-23 Julien Danjou <julien@danjou.info>
4229
4230 * term.c (Fsuspend_tty, Fresume_tty):
4231 * minibuf.c (read_minibuf, run_exit_minibuf_hook):
4232 * window.c (temp_output_buffer_show):
4233 * insdel.c (signal_before_change):
4234 * frame.c (Fhandle_switch_frame):
4235 * fileio.c (Fdo_auto_save):
4236 * emacs.c (Fkill_emacs):
4237 * editfns.c (save_excursion_restore):
4238 * cmds.c (internal_self_insert):
4239 * callint.c (Fcall_interactively):
4240 * buffer.c (Fkill_all_local_variables):
4241 * keyboard.c (Fcommand_execute, Fsuspend_emacs, safe_run_hooks_1):
4242 Use Frun_hooks.
0f4a96b5 4243 (command_loop_1): Use Frun_hooks. Call safe_run_hooks
dee091a3
JD
4244 unconditionnaly since it does the check itself.
4245
2c520ab5 42462011-03-23 Paul Eggert <eggert@cs.ucla.edu>
f0641eff 4247
c9c49752
PE
4248 Fix more problems found by GCC 4.5.2's static checks.
4249
8abc3f12
PE
4250 * coding.c (encode_coding_raw_text): Avoid unnecessary test
4251 the first time through the loop, since we know p0 < p1 then.
4252 This also avoids a gcc -Wstrict-overflow warning.
4253
a2d26660
PE
4254 * lisp.h (SAFE_ALLOCA, SAFE_ALLOCA_LISP): Avoid 'int' overflow
4255 leading to a memory leak, possible in functions like
4256 load_charset_map_from_file that can allocate an unbounded number
b12ef411 4257 of objects (Bug#8318).
a2d26660 4258
916c72e9
PE
4259 * xmenu.c (set_frame_menubar): Use EMACS_UINT, not int, for indexes
4260 that could (at least in theory) be that large.
4261
19ab8a18
PE
4262 * xdisp.c (message_log_check_duplicate): Return unsigned long, not int.
4263 This is less likely to overflow, and avoids undefined behavior if
4264 overflow does occur. All callers changed. Use strtoul to scan
4265 for the unsigned long integer.
b7cbbd6f
PE
4266 (pint2hrstr): Simplify and tune code slightly.
4267 This also avoids a (bogus) GCC warning with gcc -Wstrict-overflow.
19ab8a18 4268
f0641eff
PE
4269 * scroll.c (do_scrolling): Work around GCC bug 48228.
4270 See <http://gcc.gnu.org/bugzilla/show_bug.cgi?id=48228>.
4271
7f650bb9
PE
4272 * frame.c (Fmodify_frame_parameters): Simplify loop counter.
4273 This also avoids a warning with gcc -Wstrict-overflow.
39f5e519
PE
4274 (validate_x_resource_name): Simplify count usage.
4275 This also avoids a warning with gcc -Wstrict-overflow.
7f650bb9 4276
37dd57d1
PE
4277 * fileio.c (Fcopy_file): Report error if fchown or fchmod
4278 fail (Bug#8306).
81e56e61 4279
699979fc 4280 * emacs.c (Fdaemon_initialized): Do not ignore I/O errors (Bug#8303).
dc1ca6a8 4281
401bf9b4
PE
4282 * process.c (Fmake_network_process): Use socklen_t, not int,
4283 where POSIX says socklen_t is required in portable programs.
4284 This fixes a porting bug on hosts like 64-bit HP-UX, where
591b2973 4285 socklen_t is wider than int (Bug#8277).
401bf9b4
PE
4286 (Fmake_network_process, server_accept_connection):
4287 (wait_reading_process_output, read_process_output):
4288 Likewise.
4289
b93aacde
PE
4290 * process.c: Rename or move locals to avoid shadowing.
4291 (list_processes_1, Fmake_network_process):
4292 (read_process_output_error_handler, exec_sentinel_error_handler):
4293 Rename or move locals.
4dc343ee 4294 (Fmake_network_process): Define label "retry_connect" only if needed.
0da49335 4295 (Fnetwork_interface_info): Fix pointer signedness.
f990b4e5 4296 (process_send_signal): Add cast to avoid pointer signedness problem.
7b808126 4297 (FIRST_PROC_DESC, IF_NON_BLOCKING_CONNECT): Remove unused macros.
c939f91b 4298 (create_process): Use 'volatile' to avoid vfork clobbering (Bug#8298).
b93aacde 4299
af8a867c 4300 Make tparam.h and terminfo.c consistent.
44f230aa
SM
4301 * cm.c (tputs, tgoto, BC, UP): Remove extern decls.
4302 Include tparam.h instead, since it declares them.
af8a867c
PE
4303 * cm.h (PC): Remove extern decl; tparam.h now does this.
4304 * deps.mk (cm.o, terminfo.o): Depend on tparam.h.
4305 * terminfo.c: Include tparam.h, to check interfaces.
4306 (tparm): Make 1st arg a const pointer in decl. Put it at top level.
4307 (tparam): Adjust signature to match interface in tparam.h;
4308 this removes some undefined behavior. Check that outstring and len
4309 are zero, which they always are with Emacs.
4310 * tparam.h (PC, BC, UP): New extern decls.
4311
0248044d 4312 * xftfont.c (xftfont_shape): Now static, and defined only if needed.
001a7ab4 4313 (xftfont_open): Rename locals to avoid shadowing.
0248044d 4314
8ff096c1 4315 * ftfont.c (ftfont_resolve_generic_family): Fix pointer signedness.
a00924bb
PE
4316 (ftfont_otf_capability, ftfont_shape): Omit decls if not needed.
4317 (OTF_TAG_SYM): Omit macro if not needed.
e932860f 4318 (ftfont_list): Remove unused local.
49eaafba
PE
4319 (get_adstyle_property, ftfont_pattern_entity):
4320 (ftfont_lookup_cache, ftfont_open, ftfont_anchor_point):
4321 Rename locals to avoid shadowing.
8ff096c1 4322
e2be39f6
PE
4323 * xfont.c (xfont_list_family): Mark var as initialized.
4324
c9735e30
PE
4325 * xml.c (make_dom): Now static.
4326
8f5201ae
PE
4327 * composite.c (composition_compute_stop_pos): Rename local to
4328 avoid shadowing.
b246f932
PE
4329 (composition_reseat_it): Remove unused locals.
4330 (find_automatic_composition, composition_adjust_point): Likewise.
80e079b2 4331 (composition_update_it): Mark var as initialized.
11b61122
PE
4332 (find_automatic_composition): Mark vars as initialized,
4333 with a FIXME (Bug#8290).
8f5201ae 4334
760fbc2c
PE
4335 character.h: Rename locals to avoid shadowing.
4336 * character.h (PREV_CHAR_BOUNDARY, FETCH_STRING_CHAR_ADVANCE):
4337 (FETCH_STRING_CHAR_AS_MULTIBYTE_ADVANCE, FETCH_CHAR_ADVANCE):
4338 (FETCH_CHAR_ADVANCE_NO_CHECK, INC_POS, DEC_POS, BUF_INC_POS):
4339 (BUF_DEC_POS): Be more systematic about renaming local temporaries
4340 to avoid shadowing.
4341
ff08eb85
PE
4342 * textprop.c (property_change_between_p): Remove; unused.
4343
fc7bf025
PE
4344 * intervals.c (interval_start_pos): Now static.
4345
235d7abc
PE
4346 * intervals.h (CHECK_TOTAL_LENGTH): Avoid empty "else".
4347
44f230aa
SM
4348 * atimer.c (start_atimer, append_atimer_lists, set_alarm):
4349 Rename locals to avoid shadowing.
3e7d6594 4350
50060332
PE
4351 * sound.c (wav_play, au_play, Fplay_sound_internal):
4352 Fix pointer signedness.
d01f234b 4353 (alsa_choose_format): Remove unused local var.
c83b8872
PE
4354 (wav_play): Initialize a variable to 0, to prevent undefined
4355 behavior (Bug#8278).
50060332 4356
c4fc4e30
PE
4357 * region-cache.c (insert_cache_boundary): Redo var to avoid shadowing.
4358
918436ed
PE
4359 * region-cache.h (pp_cache): New decl, for gcc -Wmissing-prototypes.
4360
c939f91b
PE
4361 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork
4362 clobbering (Bug#8298).
b9c7f648
PE
4363 * sysdep.c (sys_subshell): Likewise.
4364 Previously, the sys_subshell 'volatile' was incorrectly IF_LINTted out.
7e9123a2 4365
6bd8c144
PE
4366 * lisp.h (child_setup): Now NO_RETURN unless DOS_NT.
4367 This should get cleaned up, so that child_setup has the
4368 same signature on all platforms.
4369
7710357c 4370 * callproc.c (call_process_cleanup): Now static.
cb1d0ef7 4371 (relocate_fd): Rename locals to avoid shadowing.
7710357c 4372
c59da222
CY
43732011-03-22 Chong Yidong <cyd@stupidchicken.com>
4374
4375 * xterm.c (x_clear_frame): Remove XClearWindow call. This appears
4376 not to be necessary, and produces flickering.
4377
66b87493
GM
43782011-03-20 Glenn Morris <rgm@gnu.org>
4379
4380 * config.in: Remove file.
4381
45b6f6d5
JB
43822011-03-20 Juanma Barranquero <lekktu@gmail.com>
4383
4384 * minibuf.c (Vcompleting_read_function): Don't declare, global variables
4385 are now in src/globals.h.
4386 (syms_of_minibuf): Remove spurious & from previous change.
4387
3ec03f7e
LL
43882011-03-20 Leo <sdl.web@gmail.com>
4389
4390 * minibuf.c (completing-read-function): New variable.
4391 (completing-read-default): Rename from completing-read.
4392 (completing-read): Call completing-read-function.
4393
b14e3e21
CY
43942011-03-19 Juanma Barranquero <lekktu@gmail.com>
4395
4396 * xfaces.c (Fx_load_color_file):
4397 Read color file from absolute filename (bug#8250).
4398
f2b726e6
JB
43992011-03-19 Juanma Barranquero <lekktu@gmail.com>
4400
4401 * makefile.w32-in: Update dependencies.
4402
09f6ff02
EZ
44032011-03-17 Eli Zaretskii <eliz@gnu.org>
4404
4405 * makefile.w32-in ($(BLD)/unexw32.$(O)): Depend on $(SRC)/unexec.h.
4406
29a6015a
PE
44072011-03-17 Paul Eggert <eggert@cs.ucla.edu>
4408
a3a6c54e
PE
4409 Fix more problems found by GCC 4.5.2's static checks.
4410
b766f867
PE
4411 * process.c (make_serial_process_unwind, send_process_trap):
4412 (sigchld_handler): Now static.
4413
be02381c
PE
4414 * process.c (allocate_pty): Let PTY_ITERATION declare iteration vars.
4415 That way, the code declares only the vars that it needs.
4416 * s/aix4-2.h (PTY_ITERATION): Declare iteration vars.
4417 * s/cygwin.h (PTY_ITERATION): Likewise.
4418 * s/darwin.h (PTY_ITERATION): Likewise.
4419 * s/gnu-linux.h (PTY_ITERATION): Likewise.
4420
57048744
PE
4421 * s/irix6-5.h (PTY_OPEN): Declare stb, to loosen coupling.
4422 * process.c (allocate_pty): Don't declare stb unless it's needed.
4423
7914961c 4424 * bytecode.c (MAYBE_GC): Rewrite so as not to use empty "else".
615f2d59
PE
4425 (CONSTANTLIM): Remove; unused.
4426 (METER_CODE, Bscan_buffer, Bread_char, Bset_mark):
4427 Define only if needed.
7914961c 4428
b3967b18
PE
4429 * unexelf.c (unexec): Name an expression,
4430 to avoid gcc -Wbad-function-cast warning.
9ae71512
PE
4431 Use a different way to cause a compilation error if anyone uses
4432 n rather than nn, a way that does not involve shadowing.
73366a00 4433 (ELF_BSS_SECTION_NAME, OLD_PROGRAM_H): Remove; unused.
b3967b18 4434
29a6015a
PE
4435 * deps.mk (unexalpha.o): Remove; unused.
4436
43cfc33e 4437 New file unexec.h, the (simple) interface for unexec (Bug#8267).
7feda0d2 4438 * unexec.h: New file.
ce701a33
PE
4439 * deps.mk (emacs.o, unexaix.o, unexcw.o, unexcoff.o, unexelf.o):
4440 (unexhp9k800.o, unexmacosx.o, unexsol.o, unexw32.o):
4441 Depend on unexec.h.
4442 * emacs.c [!defined CANNOT_DUMP]: Include unexec.h.
4443 * unexaix.c, unexcoff.c, unexcw.c, unexelf.c, unexhp9k800.c:
4444 * unexmacosx.c, unexsol.c, unexw32.c: Include unexec.h.
381259ef 4445 Change as necessary to match prototype in unexec.h.
ce701a33 4446
01f44d5a
PE
4447 * syntax.c (Fforward_comment, scan_lists): Rename locals to avoid
4448 shadowing.
4f63c6bb 4449 (back_comment, skip_chars): Mark vars as initialized.
01f44d5a 4450
a6670b0b
PE
4451 * character.h (FETCH_STRING_CHAR_ADVANCE_NO_CHECK, BUF_INC_POS):
4452 Rename locals to avoid shadowing.
4453
cef2010d 4454 * lread.c (read1): Rewrite so as not to use empty "else".
0902fe45 4455 (Fload, readevalloop, read1): Rename locals to avoid shadowing.
cef2010d 4456
d4d7173a
PE
4457 * print.c (Fredirect_debugging_output): Fix pointer signedess.
4458
f08b802a
PE
4459 * lisp.h (debug_output_compilation_hack): Add decl here, to avoid
4460 warning when compiling print.c.
4461
3ddb0639
PE
4462 * font.c (font_unparse_fcname): Abort in an "impossible" situation
4463 instead of using an uninitialized var.
5ad03b97 4464 (font_sort_entities): Mark var as initialized.
3ddb0639 4465
170a2692
PE
4466 * character.h (FETCH_CHAR_ADVANCE): Rename locals to avoid shadowing.
4467
e663c700
PE
4468 * font.c (font_unparse_xlfd): Don't mix pointers to variables with
4469 pointers to constants.
89bc529a 4470 (font_parse_fcname): Remove unused vars.
7b81e2d0 4471 (font_delete_unmatched): Now static.
ea838e10 4472 (font_get_spec): Remove; unused.
13a547c6
PE
4473 (font_style_to_value, font_prop_validate_style, font_unparse_fcname):
4474 (font_update_drivers, Ffont_get_glyphs, font_add_log):
4475 Rename or move locals to avoid shadowing.
e663c700 4476
2a80c887 4477 * fns.c (require_nesting_list, require_unwind): Now static.
612f56df 4478 (Ffillarray): Rename locals to avoid shadowing.
2a80c887 4479
1384fa33 4480 * floatfns.c (domain_error2): Define only if needed.
a885e2ed 4481 (Ffrexp, Fldexp): Rename locals to avoid shadowing.
1384fa33 4482
8b2c52e9
PE
4483 * alloc.c (mark_backtrace): Move decl from here ...
4484 * lisp.h: ... to here, so that it can be checked.
4485
475545b5 4486 * eval.c (call_debugger, do_debug_on_call, grow_specpdl): Now static.
d28a2170 4487 (Fdefvar): Rewrite so as not to use empty "else".
cfcbfb1a
PE
4488 (lisp_indirect_variable): Name an expression,
4489 to avoid gcc -Wbad-function-cast warning.
1faed8ae 4490 (Fdefvar): Rename locals to avoid shadowing.
475545b5 4491
b1349114 4492 * callint.c (quotify_arg, quotify_args): Now static.
a3e8cbda 4493 (Fcall_interactively): Rename locals to avoid shadowing.
b0e80955 4494 Use const pointer when appropriate.
b1349114 4495
a2928364
PE
4496 * lisp.h (get_system_name, get_operating_system_release):
4497 Move decls here, to check interfaces.
4498 * process.c (get_operating_system_release): Move decl to lisp.h.
4499 * xrdb.c (get_system_name): Likewise.
63c5d10b
PE
4500 * editfns.c (init_editfns, Fuser_login_name, Fuser_uid):
4501 (Fuser_real_uid, Fuser_full_name): Remove unnecessary casts,
4502 some of which prompt warnings from gcc -Wbad-function-cast.
545b49b4
PE
4503 (Fformat_time_string, Fencode_time, Finsert_char):
4504 (Ftranslate_region_internal, Fformat):
4505 Rename or remove local vars to avoid shadowing.
9710023e 4506 (Ftranslate_region_internal): Mark var as initialized.
63c5d10b 4507
a415e694
PE
4508 * doc.c (Fdocumentation, Fsnarf_documentation): Move locals to
4509 avoid shadowing.
4510
8ef4622d
PE
4511 * lisp.h (eassert): Check that the argument compiles, even if
4512 ENABLE_CHECKING is not defined.
4513
946f9a5b
PE
4514 * data.c (Findirect_variable): Name an expression, to avoid
4515 gcc -Wbad-function-cast warning.
112396d6 4516 (default_value, arithcompare, arith_driver, arith_error): Now static.
b9b84fa9 4517 (store_symval_forwarding): Rename local to avoid shadowing.
44f230aa
SM
4518 (Fmake_variable_buffer_local, Fmake_local_variable):
4519 Mark variables as initialized.
52746918 4520 (do_blv_forwarding, do_symval_forwarding): Remove; unused.
946f9a5b 4521
e5aab7e7 4522 * alloc.c (check_cons_list): Do not define unless GC_CHECK_CONS_LIST.
ae35e756
PE
4523 (Fmake_vector, Fvector, Fmake_byte_code, Fgarbage_collect):
4524 Rename locals to avoid shadowing.
dff45157
PE
4525 (mark_stack): Move local variables into the #ifdef region where
4526 they're used.
7bc26fdb
PE
4527 (BLOCK_INPUT_ALLOC, UNBLOCK_INPUT_ALLOC): Define only if
4528 ! defined SYSTEM_MALLOC && ! defined SYNC_INPUT, as they are not
4529 needed otherwise.
4530 (CHECK_ALLOCATED): Define only if GC_CHECK_MARKED_OBJECTS.
4531 (GC_STRING_CHARS): Remove; not used.
d40d4be1 4532 (Fmemory_limit): Cast sbrk's returned value to char *.
ae35e756 4533
e5aab7e7
PE
4534 * lisp.h (check_cons_list): Declare if GC_CHECK_CONS_LIST; this
4535 avoids undefined behavior in theory.
4536
4da60324
PE
4537 * regex.c (IF_LINT): Add defn, for benefit of ../lib-src.
4538
88043301
PE
4539 Use functions, not macros, for up- and down-casing (Bug#8254).
4540 * buffer.h (DOWNCASE_TABLE, UPCASE_TABLE, DOWNCASE, UPPERCASEP):
4541 (NOCASEP, LOWERCASEP, UPCASE, UPCASE1): Remove. All callers changed
4542 to use the following functions instead of these macros.
4543 (downcase): Adjust to lack of DOWNCASE_TABLE. Return int, not
4544 EMACS_INT, since callers assume the returned value fits in int.
4545 (upcase1): Likewise, for UPCASE_TABLE.
4546 (uppercasep, lowercasep, upcase): New static inline functions.
0da09c43 4547 * editfns.c (Fchar_equal): Remove no-longer-needed workaround for
db69b0cd 4548 the race-condition problem in the old DOWNCASE.
88043301 4549
19ed5445
PE
4550 * regex.c (CHARSET_LOOKUP_RANGE_TABLE_RAW, POP_FAILURE_REG_OR_COUNT):
4551 Rename locals to avoid shadowing.
4552 (regex_compile, re_match_2_internal): Move locals to avoid shadowing.
abbd1bcf
PE
4553 (regex_compile, re_search_2, re_match_2_internal):
4554 Remove unused local vars.
952db0d7
PE
4555 (FREE_VAR): Rewrite so as not to use empty "else",
4556 which gcc can warn about.
da053e48 4557 (regex_compile, re_match_2_internal): Mark locals as initialized.
b313f9d8
PE
4558 (RETALLOC_IF): Define only if needed.
4559 (WORDCHAR_P): Likewise. This one is never needed, but is used
4560 only in a comment talking about a compiler bug, so put inside
4561 the #if 0 of that comment.
4562 (CHARSET_LOOKUP_BITMAP, FAIL_STACK_FULL, RESET_FAIL_STACK):
4563 (PUSH_FAILURE_ELT, BUF_PUSH_3, STOP_ADDR_VSTRING):
4564 Remove; unused.
19ed5445 4565
1f3561e4 4566 * search.c (boyer_moore): Rename locals to avoid shadowing.
76ef09b7
PE
4567 * character.h (FETCH_STRING_CHAR_AS_MULTIBYTE_ADVANCE):
4568 (PREV_CHAR_BOUNDARY): Likewise.
1f3561e4 4569
ded6f8f7
PE
4570 * search.c (simple_search): Remove unused var.
4571
dbd37a95
PE
4572 * dired.c (compile_pattern): Move decl from here ...
4573 * lisp.h: ... to here, so that it can be checked.
4574 (struct re_registers): New forward decl.
4575
7e47afad
PE
4576 * character.h (INC_POS, DEC_POS): Rename locals to avoid shadowing.
4577
85f24f61
PE
4578 * indent.c (MULTIBYTE_BYTES_WIDTH): New args bytes, width.
4579 All uses changed.
4580 (MULTIBYTE_BYTES_WIDTH, scan_for_column, compute_motion):
4581 Rename locals to avoid shadowing.
5671df8f 4582 (Fvertical_motion): Mark locals as initialized.
85f24f61 4583
181aa2be 4584 * casefiddle.c (casify_object, casify_region): Now static.
e45a141a 4585 (casify_region): Mark local as initialized.
181aa2be 4586
930d429c
PE
4587 * cmds.c (internal_self_insert): Rename local to avoid shadowing.
4588
7082eac6
PE
4589 * lisp.h (GCPRO2_VAR, GCPRO3_VAR, GCPRO4_VAR, GCPRO5_VAR, GCPRO6_VAR):
4590 New macros, so that the caller can use some names other than
4591 gcpro1, gcpro2, etc.
4592 (GCPRO2, GCPRO3, GCPRO4, GCPRO5, GCPRO6): Reimplement in terms
4593 of the new macros.
4594 (GCPRO1_VAR, UNGCPRO_VAR): Change the meaning of the second
4595 argument, for consistency with GCPRO2_VAR, etc: it is now the
4596 prefix of the variable, not the variable itself. All uses
4597 changed.
38b2c076
PE
4598 * dired.c (directory_files_internal, file_name_completion):
4599 Rename locals to avoid shadowing.
4600
15206ed9
PE
4601 Fix a race condition diagnosed by gcc -Wsequence-point (Bug#8254).
4602 An expression of the form (DOWNCASE (x) == DOWNCASE (y)), found in
4603 dired.c's scmp function, had undefined behavior.
4604 * lisp.h (DOWNCASE_TABLE, UPCASE_TABLE, DOWNCASE, UPPERCASEP):
4605 (NOCASEP, LOWERCASEP, UPCASE, UPCASE1): Move from here ...
4606 * buffer.h: ... to here, because these macros use current_buffer,
4607 and the new implementation with inline functions needs to have
4608 current_buffer in scope now, rather than later when the macros
4609 are used.
4610 (downcase, upcase1): New static inline functions.
4611 (DOWNCASE, UPCASE1): Reimplement using these functions.
4612 This avoids undefined behavior in expressions like
4613 DOWNCASE (x) == DOWNCASE (y), which previously suffered
4614 from race conditions in accessing the global variables
4615 case_temp1 and case_temp2.
4616 * casetab.c (case_temp1, case_temp2): Remove; no longer needed.
4617 * lisp.h (case_temp1, case_temp2): Remove their decls.
4618 * character.h (ASCII_CHAR_P): Move from here ...
4619 * lisp.h: ... to here, so that the inline functions mentioned
4620 above can use them.
4621
4a6bea26
PE
4622 * dired.c (directory_files_internal_unwind): Now static.
4623
f14b7e14
PE
4624 * fileio.c (file_name_as_directory, directory_file_name):
4625 (barf_or_query_if_file_exists, auto_save_error, auto_save_1):
4626 Now static.
2893f146
PE
4627 (file_name_as_directory): Use const pointers when appropriate.
4628 (Fexpand_file_name): Likewise. In particular, newdir might
4629 point at constant storage, so make it a const pointer.
fd4ead52 4630 (Fmake_directory_internal, Fread_file_name): Remove unused vars.
b14aac08
PE
4631 (Ffile_selinux_context, Fset_file_selinux_context): Fix pointer
4632 signedness issues.
f839df0c
PE
4633 (Fset_file_times, Finsert_file_contents, auto_save_error):
4634 Rename locals to avoid shadowing.
f14b7e14 4635
5716756e 4636 * minibuf.c (choose_minibuf_frame_1): Now static.
62137a95
PE
4637 (Ftry_completion, Fall_completions): Rename or remove locals
4638 to avoid shadowing.
5716756e 4639
b4c3046a
PE
4640 * marker.c (bytepos_to_charpos): Remove; unused.
4641
b45db522
PE
4642 * lisp.h (verify_bytepos, count_markers): New decls,
4643 so that gcc does not warn that these functions aren't declared.
4644
85876d07
PE
4645 * insdel.c (check_markers, make_gap_larger, make_gap_smaller):
4646 (reset_var_on_error, Fcombine_after_change_execute_1): Now static.
f0cb4a60 4647 (CHECK_MARKERS): Redo to avoid gcc -Wempty-body diagnostic.
40ef059e 4648 (copy_text): Remove unused local var.
85876d07 4649
03d78a21 4650 * filelock.c (within_one_second): Now static.
b3dd38ab 4651 (lock_file_1): Rename local to avoid shadowing.
03d78a21 4652
5df8f01b
PE
4653 * buffer.c (fix_overlays_before): Mark locals as initialized.
4654 (fix_start_end_in_overlays): Likewise. This function should be
4655 simplified by using pointers-to-pointers, but that's a different
4656 matter.
b1d876f1 4657 (switch_to_buffer_1): Now static.
8f54f30a
PE
4658 (Fkill_buffer, record_buffer, Fbury_buffer, Fset_buffer_multibyte):
4659 (report_overlay_modification): Rename locals to avoid shadowing.
c3bd59b5 4660
a70072c9 4661 * sysdep.c (system_process_attributes): Rename vars to avoid shadowing.
fbd02d7b 4662 Fix pointer signedness issue.
edced198
PE
4663 (sys_subshell): Mark local as volatile if checking for lint,
4664 to suppress a gcc -Wclobbered warning that does not seem to be right.
15dfd3d9 4665 (MAXPATHLEN): Define only if needed.
a70072c9 4666
a0977c44
PE
4667 * process.c (serial_open, serial_configure): Move decls from here ...
4668 * systty.h: ... to here, so that they can be checked.
4669
a884fdcc
PE
4670 * fns.c (get_random, seed_random): Move extern decls from here ...
4671 * lisp.h: ... to here, so that they can be checked.
4672
604efe86 4673 * sysdep.c (reset_io): Now static.
b8950c94 4674 (wait_for_termination_signal): Remove; unused.
604efe86 4675
38fc62d9
PE
4676 * keymap.c (keymap_parent, keymap_memberp, map_keymap_internal):
4677 (copy_keymap_item, append_key, push_text_char_description):
4678 Now static.
1004a21a 4679 (Fwhere_is_internal): Don't test CONSP (sequences) unnecessarily.
dbbb8427 4680 (DENSE_TABLE_SIZE): Remove; unused.
c1141155
PE
4681 (get_keymap, access_keymap, Fdefine_key, Fwhere_is_internal):
4682 (describe_map_tree):
4683 Rename locals to avoid shadowing.
38fc62d9 4684
2f2650da
PE
4685 * keyboard.c: Declare functions static if they are not used elsewhere.
4686 (echo_char, echo_dash, cmd_error, top_level_2):
4687 (poll_for_input, handle_async_input): Now static.
69a058fa
PE
4688 (read_char, kbd_buffer_get_event, make_lispy_position):
4689 (make_lispy_event, make_lispy_movement, apply_modifiers):
4690 (decode_keyboard_code, tty_read_avail_input, menu_bar_items):
4691 (parse_tool_bar_item, read_key_sequence, Fread_key_sequence):
4692 (Fread_key_sequence_vector): Rename locals to avoid shadowing.
c8a06054 4693 (read_key_sequence, read_char): Mark locals as initialized.
3ac94672 4694 (Fexit_recursive_edit, Fabort_recursive_edit): Mark with NO_RETURN.
2f2650da 4695
a053e86c 4696 * keyboard.h (make_ctrl_char): New decl.
da2f2dd9
PE
4697 (mark_kboards): Move decl here ...
4698 * alloc.c (mark_kboards): ... from here.
a053e86c 4699
4752793e
PE
4700 * lisp.h (force_auto_save_soon): New decl.
4701
74f10ca7 4702 * emacs.c (init_cmdargs): Rename local to avoid shadowing.
244fc23d
PE
4703 (DEFINE_DUMMY_FUNCTION): New macro.
4704 (__do_global_ctors, __do_global_ctors_aux, __do_global_dtors, __main):
4705 Use it.
c03cd23f
PE
4706 (main): Add casts to avoid warnings
4707 if GCC considers string literals to be constants.
74f10ca7 4708
022e70d4
PE
4709 * lisp.h (fatal_error_signal): Add decl, since it's exported.
4710
59d6fe83
PE
4711 * dbusbind.c: Pointer signedness fixes.
4712 (xd_signature, xd_append_arg, xd_initialize):
4713 (Fdbus_call_method, Fdbus_call_method_asynchronously):
4714 (Fdbus_method_return_internal, Fdbus_method_error_internal):
4715 (Fdbus_send_signal, xd_read_message_1, Fdbus_register_service):
4716 (Fdbus_register_signal): Use SSDATA when the context wants char *.
4717
78320123
PE
4718 * dbusbind.c (Fdbus_init_bus): Add cast to avoid warning
4719 if GCC considers string literals to be constants.
49cebcca 4720 (Fdbus_register_service, Fdbus_register_method): Remove unused vars.
78320123 4721
35ac2a97
SM
47222011-03-16 Stefan Monnier <monnier@iro.umontreal.ca>
4723
fb103ca9
SM
4724 * print.c (PRINT_CIRCLE_CANDIDATE_P): New macro.
4725 (print_preprocess, print_object): New macro to fix last change.
4726
35ac2a97
SM
4727 * print.c (print_preprocess): Don't forget font objects.
4728
62973b41
JB
47292011-03-16 Juanma Barranquero <lekktu@gmail.com>
4730
4731 * emacs.c (USAGE3): Doc fixes.
4732
0e48bb22
AS
47332011-03-15 Andreas Schwab <schwab@linux-m68k.org>
4734
4735 * coding.c (detect_coding_iso_2022): Reorganize code to clarify
4736 structure.
4737
7684e57b
JB
47382011-03-14 Juanma Barranquero <lekktu@gmail.com>
4739
4740 * lisp.h (VWindow_system, Qfile_name_history):
4741 * keyboard.h (lispy_function_keys) [WINDOWSNT]:
4742 * w32term.h (w32_system_caret_hwnd, w32_system_caret_height)
4743 (w32_system_caret_x, w32_system_caret_y): Declare extern.
4744
4745 * w32select.c: Don't #include "keyboard.h".
c96bbc66 4746 (run_protected): Add extern declaration for waiting_for_input.
7684e57b
JB
4747
4748 * w32.c (Qlocal, noninteractive1, inhibit_window_system):
4749 * w32console.c (detect_input_pending, read_input_pending)
4750 (encode_terminal_code):
4751 * w32fns.c (quit_char, lispy_function_keys, Qtooltip)
4752 (w32_system_caret_hwnd, w32_system_caret_height, w32_system_caret_x)
4753 (w32_system_caret_y, Qfile_name_history):
4754 * w32font.c (w32font_driver, QCantialias, QCotf, QClang):
4755 * w32inevt.c (reinvoke_input_signal, lispy_function_keys):
4756 * w32menu.c (Qmenu_bar, QCtoggle, QCradio, Qoverriding_local_map)
4757 (Qoverriding_terminal_local_map, Qmenu_bar_update_hook):
4758 * w32proc.c (Qlocal, report_file_error):
4759 * w32term.c (Vwindow_system, updating_frame):
4760 * w32uniscribe.c (initialized, uniscribe_font_driver):
4761 Remove unneeded extern declarations.
4762
2aa46d6c
CY
47632011-03-14 Chong Yidong <cyd@stupidchicken.com>
4764
c96bbc66 4765 * buffer.c (Fmake_indirect_buffer): Fix incorrect assertions.
2aa46d6c 4766
cffc6f3b
CY
47672011-03-13 Chong Yidong <cyd@stupidchicken.com>
4768
4769 * buffer.h (BUF_BEGV, BUF_BEGV_BYTE, BUF_ZV, BUF_ZV_BYTE, BUF_PT)
4770 (BUF_PT_BYTE): Rewrite to handle indirect buffers (Bug#8219).
4771 These macros can no longer be used for assignment.
4772
44f230aa
SM
4773 * buffer.c (Fget_buffer_create, Fmake_indirect_buffer):
4774 Assign struct members directly, instead of using BUF_BEGV etc.
cffc6f3b
CY
4775 (record_buffer_markers, fetch_buffer_markers): New functions for
4776 recording and fetching special buffer markers.
4777 (set_buffer_internal_1, set_buffer_temp): Use them.
4778
4779 * lread.c (unreadchar): Use SET_BUF_PT_BOTH.
4780
4781 * insdel.c (adjust_point): Use SET_BUF_PT_BOTH.
4782
4783 * intervals.c (temp_set_point_both): Use SET_BUF_PT_BOTH.
4784 (get_local_map): Use SET_BUF_BEGV_BOTH and SET_BUF_ZV_BOTH.
4785
4786 * xdisp.c (hscroll_window_tree):
4787 (reconsider_clip_changes): Use PT instead of BUF_PT.
4788
d251f04b
EZ
47892011-03-13 Eli Zaretskii <eliz@gnu.org>
4790
4791 * makefile.w32-in ($(BLD)/editfns.$(O)): Depend on
4792 $(EMACS_ROOT)/lib/intprops.h.
4793
f0c77cd1
PE
47942011-03-13 Paul Eggert <eggert@cs.ucla.edu>
4795
3eca4629
PE
4796 Fix more problems found by GCC 4.5.2's static checks.
4797
7c86ee98
PE
4798 * gtkutil.c (xg_get_pixbuf_from_pixmap): Add cast from char *
4799 to unsigned char * to avoid compiler diagnostic.
b0afc268
PE
4800 (xg_free_frame_widgets): Make it clear that a local variable is
4801 needed only if USE_GTK_TOOLTIP.
01e0b5ad
PE
4802 (gdk_window_get_screen): Make it clear that this macro is needed
4803 only if USE_GTK_TOOLTIP.
1e5524e7
PE
4804 (int_gtk_range_get_value): New function, which avoids a diagnostic
4805 from gcc -Wbad-function-cast.
4806 (xg_set_toolkit_scroll_bar_thumb): Use it.
4807 (xg_tool_bar_callback, xg_tool_item_stale_p): Rewrite to avoid
4808 diagnostic from gcc -Wbad-function-cast.
65dc836c
PE
4809 (get_utf8_string, xg_get_file_with_chooser):
4810 Rename locals to avoid shadowing.
4811 (create_dialog): Move locals to avoid shadowing.
7c86ee98 4812
41729b81
PE
4813 * xgselect.c (xg_select): Remove unused var.
4814
f0c77cd1
PE
4815 * image.c (four_corners_best): Mark locals as initialized.
4816 (gif_load): Initialize transparent_p to zero (Bug#8238).
4817 Mark another local as initialized.
ec6cf4c6 4818 (my_png_error, my_error_exit): Mark with NO_RETURN.
f0c77cd1 4819
ce0ad53d 4820 * image.c (clear_image_cache): Now static.
d5d5a617 4821 (DIM, HAVE_STDLIB_H_1): Remove unused macros.
e22cffbc 4822 (xpm_load): Redo to avoid "discards qualifiers" gcc warning.
77a765fd
PE
4823 (x_edge_detection): Remove unnecessary cast that
4824 gcc -Wbad-function-cast diagnoses.
2037898d 4825 (gif_load): Fix pointer signedness.
6ae141d6
PE
4826 (clear_image_cache, xbm_read_bitmap_data, x_detect_edges):
4827 (jpeg_load, gif_load): Rename locals to avoid shadowing.
ce0ad53d 4828
33383987 48292011-03-12 Paul Eggert <eggert@cs.ucla.edu>
3eca4629 4830
d32df629
PE
4831 Improve quality of tests for time stamp overflow.
4832 For example, without this patch (encode-time 0 0 0 1 1
4833 1152921504606846976) returns the obviously-bogus value (-948597
4834 62170) on my RHEL 5.5 x86-64 host. With the patch, it correctly
4835 reports time overflow. See
4836 <http://lists.gnu.org/archive/html/emacs-devel/2011-03/msg00470.html>.
b8d9bd41
PE
4837 * deps.mk (editfns.o): Depend on ../lib/intprops.h.
4838 * editfns.c: Include limits.h and intprops.h.
4839 (TIME_T_MIN, TIME_T_MAX): New macros.
4840 (time_overflow): Move earlier, to before first use.
4841 (hi_time, lo_time): New functions, for an accurate test for
4842 out-of-range times.
4843 (Fcurrent_time, Fget_internal_run_time, make_time): Use them.
4844 (Fget_internal_run_time): Don't assume time_t fits in int.
4845 (make_time): Use list2 instead of Fcons twice.
4846 (Fdecode_time): More accurate test for out-of-range times.
4847 (check_tm_member): New function.
4848 (Fencode_time): Use it, to test for out-of-range times.
d32df629
PE
4849 (lisp_time_argument): Don't rely on undefined left-shift and
4850 right-shift behavior when checking for time stamp overflow.
8be6f318 4851
fe31d94c
PE
4852 * editfns.c (time_overflow): New function, refactoring common code.
4853 (Fformat_time_string, Fdecode_time, Fencode_time):
4854 (Fcurrent_time_string): Use it.
4855
8be6f318
PE
4856 Move 'make_time' to be next to its inverse 'lisp_time_argument'.
4857 * dired.c (make_time): Move to ...
4858 * editfns.c (make_time): ... here.
4859 * systime.h: Note the move.
4860
09d9db2c 48612011-03-12 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
c47cbdfd 4862
126bc0dc
YM
4863 * fringe.c (update_window_fringes): Remove unused variables.
4864
c47cbdfd
YM
4865 * unexmacosx.c (copy_data_segment): Also copy __got section.
4866 (Bug#8223)
4867
7ac80be9
EZ
48682011-03-12 Eli Zaretskii <eliz@gnu.org>
4869
c96bbc66 4870 * termcap.c [MSDOS]: Include "msdos.h".
058e5dad
EZ
4871 (find_capability, tgetnum, tgetflag, tgetstr, tputs, tgetent):
4872 Constify `char *' arguments and their references according to
4873 prototypes in tparam.h.
4874
ecb0f94d 4875 * deps.mk (termcap.o): Depend on tparam.h and msdos.h.
058e5dad 4876
7ac80be9
EZ
4877 * msdos.c (XMenuAddPane): 3rd argument is `const char *' now.
4878 Adapt all references accordingly.
4879
4880 * msdos.h (XMenuAddPane): 3rd argument is `const char *' now.
4881
ef1fd07e
TT
48822011-03-11 Tom Tromey <tromey@redhat.com>
4883
4884 * buffer.c (syms_of_buffer): Remove obsolete comment.
4885
7ef4b50c
EZ
48862011-03-11 Eli Zaretskii <eliz@gnu.org>
4887
4888 * termhooks.h (encode_terminal_code): Declare prototype.
4889
4890 * msdos.c (encode_terminal_code): Don't declare prototype.
4891
4892 * term.c (encode_terminal_code): Now external again, used by
4893 w32console.c and msdos.c.
4894
44f230aa
SM
4895 * makefile.w32-in ($(BLD)/term.$(O), ($(BLD)/tparam.$(O)):
4896 Depend on $(SRC)/tparam.h, see 2011-03-11T07:24:21Z!eggert@cs.ucla.edu.
7ef4b50c 4897
4b1ec863 48982011-03-11 Paul Eggert <eggert@cs.ucla.edu>
f78faa98 4899
1714f52b 4900 Fix some minor problems found by GCC 4.5.2's static checks.
83316bf4 4901
4b1ec863
PE
4902 * fringe.c (update_window_fringes): Mark locals as initialized
4903 (Bug#8227).
4904 (destroy_fringe_bitmap, init_fringe_bitmap): Now static.
bf60f616 4905
524c7aa6
PE
4906 * alloc.c (mark_fringe_data): Move decl from here ...
4907 * lisp.h (mark_fringe_data) [HAVE_WINDOW_SYSTEM]: ... to here,
4908 to check its interface.
4909 (init_fringe_once): Do not declare unless HAVE_WINDOW_SYSTEM.
4910
a5c0af81 4911 * fontset.c (free_realized_fontset): Now static.
7519b8cd 4912 (Fset_fontset_font): Rename local to avoid shadowing.
cc6e5db1 4913 (fontset_font): Mark local as initialized.
a9a06e0b 4914 (FONTSET_SPEC, FONTSET_REPERTORY, RFONT_DEF_REPERTORY): Remove; unused.
a5c0af81 4915
b4716021
PE
4916 * xrdb.c: Include "xterm.h", to check x_load_resources's interface.
4917
811e9bac 4918 * xselect.c (x_disown_buffer_selections): Remove; not used.
7b83e2f1 4919 (TRACE3) [!defined TRACE_SELECTION]: Remove; not used.
aa0daa9f
PE
4920 (x_own_selection, Fx_disown_selection_internal): Rename locals
4921 to avoid shadowing.
4922 (x_handle_dnd_message): Remove local to avoid shadowing.
811e9bac 4923
7e3ab302
PE
4924 * lisp.h (GCPRO1_VAR, UNGCPRO_VAR): New macros,
4925 so that the caller can use some name other than gcpro1.
4926 (GCPRO1, UNGCPRO): Reimplement in terms of the new macros.
58d2d479
PE
4927 * xfns.c (Fx_create_frame, x_create_tip_frame, Fx_show_tip):
4928 (Fx_backspace_delete_keys_p):
4929 Use them to avoid shadowing, and rename vars to avoid shadowing.
4930 (x_decode_color, x_set_name, x_window): Now static.
6b437900 4931 (Fx_create_frame): Add braces to silence GCC warning.
c0951e53 4932 (Fx_file_dialog, Fx_select_font): Fix pointer signedness.
06b0c8a0
PE
4933 (x_real_positions, xg_set_icon_from_xpm_data, x_create_tip_frame):
4934 Remove unused locals.
7e3ab302
PE
4935 (Fx_create_frame, x_create_tip_frame, Fx_show_tip):
4936 (Fx_backspace_delete_keys_p): Rename locals to avoid shadowing.
4937 Some of these renamings use the new GCPRO1_VAR and UNGCPRO_VAR
4938 macros.
f78faa98 4939
e2b13473
PE
4940 * xterm.h (x_mouse_leave): New decl.
4941
77f23912
PE
4942 * xterm.c (x_copy_dpy_color, x_focus_on_frame, x_unfocus_frame):
4943 Remove unused functions.
cdf4ba58
PE
4944 (x_shift_glyphs_for_insert, XTflash, XTring_bell):
4945 (x_calc_absolute_position): Now static.
7411c686 4946 (XTread_socket): Don't define label "out" unless it's used.
2b07bcff 4947 Don't declare local "event" unless it's used.
ed7bf3a5
PE
4948 (x_iconify_frame, x_free_frame_resources): Don't declare locals
4949 unless they are used.
38d0b34a
PE
4950 (XEMBED_VERSION, xembed_set_info): Don't define unless needed.
4951 (x_fatal_error_signal): Remove; not used.
a6067996
PE
4952 (x_draw_image_foreground, redo_mouse_highlight, XTmouse_position):
4953 (x_scroll_bar_report_motion, handle_one_xevent, x_draw_bar_cursor):
4954 (x_error_catcher, x_connection_closed, x_error_handler):
4955 (x_error_quitter, xembed_send_message, x_iconify_frame):
4956 (my_log_handler): Rename locals to avoid shadowing.
28f1c698 4957 (x_delete_glyphs, x_ins_del_lines): Mark with NO_RETURN.
2a8fade0 4958 (x_connection_closed): Tell GCC not to suggest NO_RETURN.
77f23912 4959
44f230aa
SM
4960 * xfaces.c (clear_face_cache, Fx_list_fonts, Fface_font):
4961 Rename or move locals to avoid shadowing.
6b463e58 4962 (tty_defined_color, merge_face_heights): Now static.
5967d051 4963 (free_realized_faces_for_fontset): Remove; not used.
1e9966ea
PE
4964 (Fx_list_fonts): Mark variable that gcc -Wuninitialized
4965 does not deduce is never used uninitialized.
73719eba
PE
4966 (STRDUPA, LSTRDUPA, FONT_POINT_SIZE_QUANTUM): Remove; not used.
4967 (LFACEP): Define only if XASSERTS, as it's not needed otherwise.
071048a3 4968
426994c3 4969 * terminal.c (store_terminal_param): Now static.
5489860b 4970
032f1620 4971 * xmenu.c (menu_highlight_callback): Now static.
9d66f88e 4972 (set_frame_menubar): Remove unused local.
d4323972 4973 (xmenu_show): Rename parameter to avoid shadowing.
6d1f7fee
PE
4974 (xmenu_show, xdialog_show, xmenu_show): Make local pointers "const"
4975 since they might point to immutable storage.
281585b0
PE
4976 (next_menubar_widget_id): Declare only if USE_X_TOOLKIT,
4977 since it's unused otherwise.
032f1620 4978
367c19e5 4979 * xdisp.c (produce_glyphless_glyph): Initialize lower_xoff.
53df7c11 4980 Add a FIXME, since the code still doesn't look right. (Bug#8215)
9f36b9fd
PE
4981 (Fcurrent_bidi_paragraph_direction): Simplify slightly; this
4982 avoids a gcc -Wuninitialized diagnostic.
0e086e8f 4983 (display_line, BUILD_COMPOSITE_GLYPH_STRING, draw_glyphs):
44a3a108
PE
4984 (note_mouse_highlight): Mark variables that gcc -Wuninitialized
4985 does not deduce are never used uninitialized.
70739cbe 4986
07b48fa9
PE
4987 * lisp.h (IF_LINT): New macro, copied from ../lib-src/emacsclient.c.
4988
8868a238 4989 * xdisp.c (redisplay_window): Rename local to avoid shadowing.
4554d213
PE
4990 * window.c (window_loop, size_window):
4991 (run_window_configuration_change_hook, enlarge_window): Likewise.
8868a238 4992
7e5cf297 4993 * window.c (display_buffer): Now static.
d6550a9f
PE
4994 (size_window): Mark variables that gcc -Wuninitialized
4995 does not deduce are never used uninitialized.
a586633d
PE
4996 * window.h (check_all_windows): New decl, to forestall
4997 gcc -Wmissing-prototypes diagnostic.
5b555da1 4998 * dispextern.h (bidi_dump_cached_states): Likewise.
7e5cf297 4999
f6095868
PE
5000 * charset.h (CHECK_CHARSET_GET_CHARSET): Rename locals to avoid
5001 shadowing.
5002 * charset.c (map_charset_for_dump, Fchar_charset): Likewise.
726929c4
PE
5003 Include <limits.h>.
5004 (Fsort_charsets): Redo min/max calculation to shorten the code a bit
5005 and to avoid gcc -Wuninitialized warning.
89ef49df
PE
5006 (load_charset_map): Mark variables that gcc -Wuninitialized
5007 does not deduce are never used uninitialized.
53df7c11 5008 (load_charset): Abort instead of using uninitialized var (Bug#8229).
f6095868 5009
f38b440c
PE
5010 * coding.c (coding_set_source, coding_set_destination):
5011 Use "else { /* comment */ }" rather than "else /* comment */;"
5012 for clarity, and to avoid gcc -Wempty-body warning.
2735d060
PE
5013 (Fdefine_coding_system_internal): Don't redeclare 'i' inside
5014 a block, when the outer 'i' will do.
5015 (decode_coding_utf_8, decode_coding_utf_16, detect_coding_emacs_mule):
5016 (emacs_mule_char, decode_coding_emacs_mule, detect_coding_iso_2022):
5017 (decode_coding_iso_2022, decode_coding_sjis, decode_coding_big5):
5018 (decode_coding_raw_text, decode_coding_charset, get_translation_table):
5019 (Fdecode_sjis_char, Fdefine_coding_system_internal):
5020 Rename locals to avoid shadowing.
5021 * character.h (FETCH_STRING_CHAR_ADVANCE): Likewise.
e2f1bab9
PE
5022 * coding.c (emacs_mule_char, encode_invocation_designation):
5023 Now static, since they're not used elsewhere.
413bb2db 5024 (decode_coding_iso_2022): Add "default: abort ();" as a safety check.
c4a63b12 5025 (decode_coding_object, encode_coding_object, detect_coding_system):
ee05f961
PE
5026 (decode_coding_emacs_mule): Mark variables that gcc
5027 -Wuninitialized does not deduce are never used uninitialized.
160b01f6
PE
5028 (detect_coding_iso_2022): Initialize a local variable that might
5029 be used uninitialized. Leave a FIXME because it's not clear that
53df7c11 5030 this initialization is needed. (Bug#8211)
5f58e762
PE
5031 (ISO_CODE_LF, ISO_CODE_CR, CODING_ISO_FLAG_EUC_TW_SHIFT):
5032 (ONE_MORE_BYTE_NO_CHECK, UTF_BOM, UTF_16_INVALID_P):
5033 (SHIFT_OUT_OK, ENCODE_CONTROL_SEQUENCE_INTRODUCER):
5034 (ENCODE_DIRECTION_R2L, ENCODE_DIRECTION_L2R):
5035 Remove unused macros.
f38b440c 5036
232b38b9 5037 * category.c (hash_get_category_set): Remove unused local var.
9f3b5e69 5038 (copy_category_table): Now static, since it's not used elsewhere.
d0891610 5039 * character.c (string_count_byte8): Likewise.
232b38b9 5040
fb90da1b
PE
5041 * ccl.c (CCL_WRITE_STRING, CCL_ENCODE_CHAR, Fccl_execute_on_string):
5042 (Fregister_code_conversion_map): Rename locals to avoid shadowing.
5043
fb93dbc2
PE
5044 * chartab.c (copy_sub_char_table): Now static, since it's not used
5045 elsewhere.
5c156ace
PE
5046 (sub_char_table_ref_and_range, char_table_ref_and_range):
5047 Rename locals to avoid shadowing.
bbcd0949 5048 (ASET_RANGE, GET_SUB_CHAR_TABLE): Remove unused macros.
fb93dbc2 5049
7d3b3862 5050 * bidi.c (bidi_check_type): Now static, since it's not used elsewhere.
630d6892 5051 (BIDI_BOB): Remove unused macro.
7d3b3862 5052
6be7d3da
PE
5053 * cm.c (cmgoto): Mark variables that gcc -Wuninitialized does not
5054 deduce are never used uninitialized.
c2ed9c8b 5055 * term.c (encode_terminal_code): Likewise.
6be7d3da 5056
75f8807f 5057 * term.c (encode_terminal_code): Now static. Remove unused local.
72abad34 5058
50938595
PE
5059 * tparam.h: New file.
5060 * term.c, tparam.h: Include it.
5061 * deps.mk (term.o, tparam.o): Depend on tparam.h.
5062 * term.c (tputs, tgetent, tgetflag, tgetnum, tparam, tgetstr):
5063 Move these decls to tparam.h, and make them agree with what
5064 is actually in tparam.c. The previous trick of using incompatible
5065 decls in different modules does not conform to the C standard.
5066 All callers of tparam changed to use tparam's actual API.
5067 * tparam.c (tparam1, tparam, tgoto):
5068 Use const pointers where appropriate.
5069
fbceeba2
PE
5070 * cm.c (calccost, cmgoto): Use const pointers where appropriate.
5071 * cm.h (struct cm): Likewise.
5072 * dispextern.h (do_line_insertion_deletion_costs): Likewise.
5073 * scroll.c (ins_del_costs, do_line_insertion_deletion_costs): Likewise.
5074 * term.c (tty_ins_del_lines, calculate_costs, struct fkey_table):
5075 (term_get_fkeys_1, append_glyphless_glyph, produce_glyphless_glyph):
5076 (turn_on_face, init_tty): Likewise.
5077 * termchar.h (struct tty_display_info): Likewise.
fbceeba2 5078
7f3f1250
PE
5079 * term.c (term_mouse_position): Rename local to avoid shadowing.
5080
e6ca6543
PE
5081 * alloc.c (mark_ttys): Move decl from here ...
5082 * lisp.h (mark_ttys): ... to here, so that it's checked against defn.
5083
c40f8d15
AS
50842011-03-11 Andreas Schwab <schwab@linux-m68k.org>
5085
5086 * .gdbinit (pwinx, xbuffer): Fix access to buffer name.
5087
cfe0661d
JB
50882011-03-09 Juanma Barranquero <lekktu@gmail.com>
5089
5090 * search.c (compile_pattern_1): Remove argument regp, unused since
5091 revid:rms@gnu.org-19941211082627-3x1g1wyqkjmwloig.
5092 (compile_pattern): Don't pass it.
5093
0afb4571
J
50942011-03-08 Jan Djärv <jan.h.d@swipnet.se>
5095
5096 * xterm.h (DEFAULT_GDK_DISPLAY): New define.
5097 (GDK_WINDOW_XID, gtk_widget_get_preferred_size): New defines
5098 for ! HAVE_GTK3.
5099 (GTK_WIDGET_TO_X_WIN): Use GDK_WINDOW_XID.
5100
5101 * xmenu.c (menu_position_func): Call gtk_widget_get_preferred_size.
5102
5103 * gtkutil.c: Include gtkx.h if HAVE_GTK3. If ! HAVE_GTK3, define
5104 gdk_window_get_screen, gdk_window_get_geometry,
5105 gdk_x11_window_lookup_for_display and GDK_KEY_g.
5106 (xg_set_screen): Use DEFAULT_GDK_DISPLAY.
5107 (xg_get_pixbuf_from_pixmap): New function.
5108 (xg_get_pixbuf_from_pix_and_mask): Change parameters from GdkPixmap
5109 to Pixmap, take frame as parameter, remove GdkColormap parameter.
5110 Call xg_get_pixbuf_from_pixmap instead of
5111 gdk_pixbuf_get_from_drawable.
5112 (xg_get_image_for_pixmap): Do not make GdkPixmaps, call
5113 xg_get_pixbuf_from_pix_and_mask with Pixmap parameters instead.
5114 (xg_check_special_colors): Use GtkStyleContext and its functions
5115 for HAVE_GTK3.
5116 (xg_prepare_tooltip, xg_hide_tooltip): Call gdk_window_get_screen.
5117 (xg_prepare_tooltip, create_dialog, menubar_map_cb)
5118 (xg_update_frame_menubar, xg_tool_bar_detach_callback)
44f230aa
SM
5119 (xg_tool_bar_attach_callback, xg_update_tool_bar_sizes):
5120 Call gtk_widget_get_preferred_size.
0afb4571
J
5121 (xg_frame_resized): gdk_window_get_geometry only takes 5
5122 parameters.
44f230aa
SM
5123 (xg_win_to_widget, xg_event_is_for_menubar):
5124 Call gdk_x11_window_lookup_for_display.
0afb4571
J
5125 (xg_set_widget_bg): New function.
5126 (delete_cb): New function.
895009e1 5127 (xg_create_frame_widgets): Connect delete-event to delete_cb.
0afb4571
J
5128 Call xg_set_widget_bg. Only set backgrund pixmap for ! HAVE_GTK3
5129 (xg_set_background_color): Call xg_set_widget_bg.
5130 (xg_set_frame_icon): Call xg_get_pixbuf_from_pix_and_mask.
5131 (xg_create_scroll_bar): vadj is a GtkAdjustment for HAVE_GTK3.
5132 Only call gtk_range_set_update_policy if ! HAVE_GTK3.
5133 (xg_make_tool_item): Only connect xg_tool_bar_item_expose_callback
5134 if ! HAVE_GTK3.
5135 (update_frame_tool_bar): Call gtk_widget_hide.
5136 (xg_initialize): Use GDK_KEY_g.
5137
5138 * xsmfns.c (gdk_set_sm_client_id): Define to gdk_set_sm_client_id
5139 if ! HAVE_GTK3
5140 (x_session_initialize): Call gdk_x11_set_sm_client_id.
5141
5142 * xterm.c (XFillRectangle): Use cairo routines for HAVE_GTK3.
5143 (x_term_init): Disable Xinput(2) with GDK_CORE_DEVICE_EVENTS.
5144 Load ~/emacs.d/gtkrc only for ! HAVE_GTK3.
5145
1c2cc4ef
JB
51462011-03-08 Juanma Barranquero <lekktu@gmail.com>
5147
5148 * w32xfns.c (select_palette): Check success of RealizePalette against
5149 GDI_ERROR, not zero.
5150
33383987 5151See ChangeLog.11 for earlier changes.
aac0c6e3
MR
5152
5153;; Local Variables:
5154;; coding: utf-8
aac0c6e3
MR
5155;; End:
5156
33383987 5157 Copyright (C) 2011 Free Software Foundation, Inc.
aac0c6e3
MR
5158
5159 This file is part of GNU Emacs.
5160
5161 GNU Emacs is free software: you can redistribute it and/or modify
5162 it under the terms of the GNU General Public License as published by
5163 the Free Software Foundation, either version 3 of the License, or
5164 (at your option) any later version.
5165
5166 GNU Emacs is distributed in the hope that it will be useful,
5167 but WITHOUT ANY WARRANTY; without even the implied warranty of
5168 MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
5169 GNU General Public License for more details.
5170
5171 You should have received a copy of the GNU General Public License
5172 along with GNU Emacs. If not, see <http://www.gnu.org/licenses/>.