* xmenu.c (xmenu_show): Rename parm to avoid shadowing.
[bpt/emacs.git] / src / ChangeLog
CommitLineData
4887c6e2 12011-04-16 Paul Eggert <eggert@cs.ucla.edu>
764430a3 2
bf501fb9
PE
3 * xmenu.c (xmenu_show): Rename parm to avoid shadowing.
4
e9829fdf
PE
5 * xterm.c (x_create_toolkit_scroll_bar): Use const * for pointers
6 to read-only memory.
7
1086c095
PE
8 * fns.c (vector): Remove; this old hack is no longer needed.
9
2baccd04 10 * xsmfns.c (create_client_leader_window): Rename shadowing arg.
401f10cb 11 Remove unused var.
dde42981 12 (gdk_x11_set_sm_client_id) [!USE_GTK]: Don't define.
2baccd04 13
72391843 14 * xrdb.c (x_load_resources): Omit unused local.
3565b346 15
436c16df 16 * xfns.c (free_frame_menubar, atof): Remove duplicate decls.
8a94ea33 17 (x_window): Rename locals to avoid shadowing.
dc5ddd85 18 (USG): Use the kludged USG macro, to pacify gcc.
436c16df 19
92bb796d 20 * xterm.c (x_alloc_nearest_color_for_widget): Remove; unused.
bbbef9e1 21 (x_term_init): Remove local to avoid shadowing.
92bb796d 22
764430a3 23 * xfns.c, xterm.c (_XEditResCheckMessages): Protoize decl.
4887c6e2
PE
24
25 * xdisp.c, dispextern.h (set_vertical_scroll_bar): Now extern if
26 USE_TOOLKIT_SCROLL_BARS && !USE_GTK, as xterm.c needs it then.
27
4170f62f 282011-04-15 Paul Eggert <eggert@cs.ucla.edu>
3e047f51 29
71b41406
PE
30 * sysdep.c (emacs_read): Remove unnecessary check vs MAX_RW_COUNT.
31
9587a89d
PE
32 emacs_write: Accept and return EMACS_INT for sizes.
33 See http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00514.html
34 et seq.
35 * gnutls.c, gnutls.h (emacs_gnutls_read, emacs_gnutls_write):
36 Accept and return EMACS_INT.
37 (emacs_gnutls_write): Return the number of bytes written on
38 partial writes.
39 * sysdep.c, lisp.h (emacs_read, emacs_write): Likewise.
273a5f82
PE
40 (emacs_read, emacs_write): Remove check for negative size, as the
41 Emacs source code has been audited now.
9587a89d
PE
42 * sysdep.c (MAX_RW_COUNT): New macro, to work around kernel bugs.
43 (emacs_read, emacs_write): Use it.
273a5f82
PE
44 * process.c (send_process): Adjust to the new signatures of
45 emacs_write and emacs_gnutls_write. Do not attempt to store
46 a byte offset into an 'int'; it might overflow.
9587a89d 47 See http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00483.html
273a5f82 48
3e047f51
PE
49 * sound.c: Don't assume sizes fit in 'int'.
50 (struct sound_device.period_size, alsa_period_size):
9c3c56a7 51 Return EMACS_INT, not int.
3e047f51 52 (struct sound_device.write, vox_write, alsa_write):
9c3c56a7
PE
53 Accept EMACS_INT, not int.
54 (wav_play, au_play): Use EMACS_INT to store sizes and to
3e047f51
PE
55 record read return values.
56
cc39a9db
BK
572011-04-15 Ben Key <bkey76@gmail.com>
58
59 * keyboard.c (Qundefined): Don't declare static since it is
60 used in nsfns.m.
61 * xfaces.c (Qbold, Qexpanded, Qitalic, Qcondensed): Don't
62 declare static since they are used in nsfont.m.
63
6c60eb9f
SM
642011-04-15 Stefan Monnier <monnier@iro.umontreal.ca>
65
66 * process.c (Qprocessp): Don't declare static.
67 * lisp.h (Qprocessp): Declare again.
68
7990b61a
JB
692011-04-15 Juanma Barranquero <lekktu@gmail.com>
70
71 * font.c (Qopentype): Don't make static (used from w32uniscribe.c).
72
5d4cb038
PE
732011-04-14 Paul Eggert <eggert@cs.ucla.edu>
74
8bd7b830 75 Improve C-level modularity by making more things 'static'.
cd64ea1d 76
e3b27b31
PE
77 Don't publish debugger-only interfaces to other modules.
78 * lisp.h (safe_debug_print, debug_output_compilation_hack):
79 (verify_bytepos, count_markers): Move decls to the only modules
80 that need them.
81 * region-cache.h (pp_cache): Likewise.
82 * window.h (check_all_windows): Likewise.
83 * marker.c, print.c, region-cache.c, window.c: Decls moved here.
84
5d4cb038
PE
85 * sysdep.c (croak): Now static, if
86 defined TIOCNOTTY || defined USG5 || defined CYGWIN.
87 * syssignal.h (croak): Declare only if not static.
69003fd8
PE
88
89 * alloc.c (refill_memory_reserve): Now static if
90 !defined REL_ALLOC || defined SYSTEM_MALLOC.
91 * lisp.h (refill_memory_reserve): Declare only if not static.
93ea6e8f 92
e87b6180
PE
93 * xsettings.c, xsettings.h (xsettings_get_system_normal_font):
94 Define only if USE_LUCID.
95
ac64929e
PE
96 * xrdb.c (x_customization_string, x_rm_string): Now static.
97
6f37259d
PE
98 * xmenu.c (x_menu_wait_for_event): Export only if USE_MOTIF.
99 * xterm.h (x_menu_wait_for_event): Declare only if USE_MOTIF.
100
1683e3ab
PE
101 * xdisp.c (draw_row_with_mouse_face): Now static.
102 * dispextern.h (draw_row_with_mouse_fave): Remove decl.
103
de9c2632
PE
104 * window.h (check_all_windows): Mark externally visible.
105
2b96acb7
PE
106 * window.c (window_deletion_count): Now static.
107
108 * undo.c: Make symbols static if they're not exported.
109 (last_undo_buffer, last_boundary_position, pending_boundary):
110 Now static.
111
50436f33
PE
112 * textprop.c (interval_insert_behind_hooks): Now static.
113 (interval_insert_in_front_hooks): Likewise.
114
64520e5c
PE
115 * term.c: Make symbols static if they're not exported.
116 (tty_turn_off_highlight, get_tty_terminal, max_frame_cols):
117 (max_frame_lines, tty_set_terminal_modes):
118 (tty_reset_terminal_modes, tty_turn_off_highlight):
119 (get_tty_terminal): Now static.
120 (term_mouse_moveto): Do not define if HAVE_WINDOW_SYSTEM.
121 * termhooks.h (term_mouse_moveto): Do not declare if
8bd7b830 122 HAVE_WINDOW_SYSTEM.
64520e5c
PE
123 * dispextern.h (tty_set_terminal_modes, tty_reset_terminal_modes):
124 (tty_turn_off_highlight, get_tty_terminal): Remove decls.
125
1fa53021
PE
126 * sysdep.c: Make symbols static if they're not exported.
127 (emacs_get_tty, emacs_set_tty, old_fcntl_flags, old_fcntl_owner):
128 Now static.
129 (sigprocmask_set, full_mask): Remove; unused.
130 (wait_debugging): Mark as visible.
131 * syssignal.h (SIGFULLMASK, full_mask): Remove decls.
132 * systty.h (emacs_get_tty, emacs_set_tty): Remove decls.
133
d4b43b22
PE
134 * syntax.c (syntax_temp): Define only if !__GNUC__.
135
b7c513d0
PE
136 * sound.c (current_sound_device, current_sound): Now static.
137
989b29ad
PE
138 * search.c (searchbufs, searchbuf_head): Now static.
139
13a55a78
PE
140 * scroll.c (scroll_cost): Remove; unused.
141 * dispextern.h (scroll_cost): Remove decl.
142
de68a1fc
PE
143 * region-cache.h (pp_cache): Mark as externally visible.
144
40ccffa6
PE
145 * process.c: Make symbols static if they're not exported.
146 (process_tick, update_tick, create_process, chan_process):
147 (Vprocess_alist, proc_buffered_char, datagram_access):
148 (fd_callback_data, send_process_frame, process_sent_to): Now static.
149 (deactivate_process): Mark defn as static, as well as decl.
150 * lisp.h (create_process): Remove decl.
151 * process.h (chan_process, Vprocess_alist): Remove decls.
152
ad64fc97
PE
153 * print.c: Make symbols static if they're not exported.
154 (print_depth, new_backquote_output, being_printed, print_buffer):
155 (print_buffer_size, print_buffer_pos, print_buffer_pos_byte):
156 (print_interval, print_number_index, initial_stderr_stream):
157 Now static.
158 * lisp.h (Fprinc): Remove decl.
159 (debug_output_compilation_hack): Mark as externally visible.
160
adddb265
PE
161 * sysdep.c (croak): Move decl from here to syssignal.h.
162 * syssignal.h (croak): Put it here, so the API can be checked when
163 'croak' is called from dissociate_if_controlling_tty.
164
1717ede2
PE
165 * minibuf.c: Make symbols static if they're not exported.
166 (minibuf_save_list, choose_minibuf_frame): Now static.
167 * lisp.h (choose_minibuf_frame): Remove decl.
168
fa5fb2bc
PE
169 * lisp.h (verify_bytepos, count_markers): Mark as externally visible.
170
1e3890d1
PE
171 * lread.c: Make symbols static if they're not exported.
172 (read_objects, initial_obarray, oblookup_last_bucket_number):
173 Now static.
174 (make_symbol): Remove; unused.
175 * lisp.h (initial_obarray, make_symbol): Remove decls.
176
8a1414fa
PE
177 * keyboard.c: Make symbols static if they're not exported.
178 (single_kboard, recent_keys_index, total_keys, recent_keys):
179 (this_command_key_count_reset, raw_keybuf, raw_keybuf_count):
180 (this_single_command_key_start, echoing, last_auto_save):
181 (read_key_sequence_cmd, dribble, recursive_edit_unwind):
182 (command_loop, echo_now, keyboard_init_hook, help_char_p):
183 (quit_throw_to_read_char, command_loop_2, top_level_1, poll_timer):
184 (Vlispy_mouse_stem, double_click_count):
185 Now static.
186 (force_auto_save_soon): Define only if SIGDANGER.
187 (ignore_mouse_drag_p): Now static if
188 !defined HAVE_WINDOW_SYSTEM || defined USE_GTK || defined HAVE_NS.
189 (print_help): Remove; unused.
190 (stop_character, last_timer_event): Mark as externally visible.
191 * keyboard.h (ignore_mouse_drag_p): Declare only if
192 defined HAVE_WINDOW_SYSTEM && !defined USE_GTK && !defined HAVE_NS.
193 (echo_now, help_char_p, quit_throw_to_read_char): Remove decls.
194 * lisp.h (echoing): Remove decl.
195 (force_auto_save_soon): Declare only if SIGDANGER.
196 * xdisp.c (redisplay_window): Simplify code, to make it more
197 obvious that ignore_mouse_drag_p is not accessed if !defined
198 USE_GTK && !defined HAVE_NS.
199
93ea6e8f
PE
200 * intervals.c: Make symbols static if they're not exported.
201 (merge_properties_sticky, merge_interval_right, delete_interval):
202 Now static.
203 * intervals.h (merge_interval_right, delete_interval): Remove decls.
204
77382fcc
PE
205 * insdel.c: Make symbols static if they're not exported.
206 However, leave prepare_to_modify_buffer alone. It's never
207 called from outside this function, but that appears to be a bug.
208 (combine_after_change_list, combine_after_change_buffer):
4889fc82 209 (adjust_after_replace, signal_before_change): Now static.
77382fcc
PE
210 (adjust_after_replace_noundo): Remove; unused.
211 * lisp.h (adjust_after_replace, adjust_after_replace_noundo):
4889fc82 212 (signal_before_change): Remove decls.
77382fcc 213
9306c32e
PE
214 * indent.c (val_compute_motion, val_vmotion): Now static.
215
cd44d2eb
PE
216 * image.c: Make symbols static if they're not exported.
217 * dispextern.h (x_create_bitmap_from_xpm_data): Do not declare
218 if USE_GTK.
219 * image.c (x_create_bitmap_from_xpm_data): Do not define if USE_GTK.
220 (xpm_color_cache, ct_table, ct_colors_allocated): Now static.
221
ad9a7a06
PE
222 * fringe.c (standard_bitmaps): Now static.
223 (max_used_fringe_bitmap): Now static, unless HAVE_NS.
224
81626931
PE
225 * frame.c: Make symbols static if they're not exported.
226 (x_report_frame_params, make_terminal_frame): Now static.
227 (get_frame_param): Now static, unless HAVE_NS.
228 (x_fullscreen_adjust): Define if WINDOWSNT, not if HAVE_WINDOW_SYSTEM.
229 (x_get_resource_string): Remove; not used.
230 * frame.h (make_terminal_frame, x_report_frame_params):
231 (x_get_resource_string); Remove decls.
232 (x_fullscreen_adjust): Declare only if WINDOWSNT.
233 * lisp.h (get_frame_param): Declare only if HAVE_NS.
234
239f9db9
PE
235 * font.c, fontset.c: Make symbols static if they're not exported.
236 * dispextern.h (FACE_SUITABLE_FOR_ASCII_CHAR_P): New macro.
237 (FACE_SUITABLE_FOR_CHAR_P): Use it.
238 * font.c (font_close_object): Now static.
239 * font.h (font_close_object): Remove.
240 * fontset.c (FONTSET_OBJLIST): Remove.
241 (free_realized_fontset) #if-0 the body, which does nothing.
242 (face_suitable_for_char_p): #if-0, as it's never called.
243 * fontset.h (face_suitable_for_char_p): Remove decl.
244 * xfaces.c (face_at_string_position): Use
245 FACE_SUITABLE_FOR_ASCII_CHAR_P, not FACE_SUITABLE_FOR_CHAR_P,
246 since 0 is always ASCII.
247
dfcf3579
PE
248 * fns.c (weak_hash_tables): Now static.
249
5045092b
PE
250 * fileio.c: Make symbols static if they're not exported.
251 (auto_saving, auto_save_mode_bits, auto_save_error_occurred):
252 (Vwrite_region_annotation_buffers): Now static.
253
57a96f5c
PE
254 * eval.c: Make symbols static if they're not exported.
255 (backtrace_list, lisp_eval_depth, when_entered_debugger): Now static.
256 * lisp.h (backtrace_list): Remove decl.
257
35f08c38
PE
258 * emacs.c: Make symbols static if they're not exported.
259 (malloc_state_ptr, malloc_using_checking, syms_of_emacs):
260 (fatal_error_code, fatal_error_signal_hook, standard_args):
261 Now static.
262 (fatal_error_signal): Now static, unless FLOAT_CATCH_SIGKILL.
263 (DEFINE_DUMMY_FUNCTION): Mark function as externally visible.
264 (__CTOR_LIST__, __DTOR_LIST__): Now externally visible.
265 * lisp.h (fatal_error_signal_hook): Remove decl.
266 (fatal_error_signal): Declare only if FLOAT_CATCH_SIGKILL.
267
f44bd759
PE
268 * editfns.c: Move a (normally-unused) function to its only use.
269 * editfns.c, lisp.h (get_operating_system_release): Remove.
270 * process.c (init_process) [DARWIN_OS]: Do it inline, as it is not
271 worth the hassle of breaking this out.
272
b532497d
PE
273 * xterm.c: Make symbols static if they're not exported.
274 (x_raise_frame, x_lower_frame, x_wm_set_window_state):
275 (x_wm_set_icon_pixmap, x_initialize, XTread_socket_fake_io_error):
276 (x_destroy_window, x_delete_display):
277 Now static.
278 (x_dispatch_event): Now static if ! (USE_MOTIF || USE_X_TOOLKIT).
279 (x_mouse_leave): Remove; unused.
280 * xterm.h (x_display_info_for_name, x_raise_frame, x_lower_frame):
281 (x_destroy_window, x_wm_set_window_state, x_wm_set_icon_pixmap):
282 (x_delete_display, x_initialize, x_set_border_pixel, x_screen_planes):
283 Remove decls.
284 (x_mouse_leave): Declare only if WINDOWSNT.
285 (x_dispatch_event): Declare only if USE_MOTIF or USE_X_TOOLKIT.
286 (xic_create_fontsetname): Declare only if HAVE_X_WINDOWS &&
287 USE_X_TOOLKIT.
288
1675728f
PE
289 * ftxfont.c: Make symbols static if they're not exported.
290 (ftxfont_driver): Export only if !defined HAVE_XFT && def8ined
291 HAVE_FREETYPE.
292 * font.h (ftxfont_driver): Likewise.
293
e4cebfca
PE
294 * xfns.c: Make symbols static if they're not exported.
295 (x_last_font_name, x_display_info_for_name):
296 (x_set_foreground_color, x_set_background_color, x_set_mouse_color):
297 (x_set_cursor_color, x_set_border_pixel, x_set_border_color):
298 (x_set_cursor_type, x_set_icon_type, x_set_icon_name):
299 (x_set_scroll_bar_foreground, x_set_scroll_bar_background):
300 (x_explicitly_set_name, x_set_title, xic_defaut_fontset, tip_timer):
301 (last_show_tip_args): Now static.
302 (xic_defaut_fontset, xic_create_fontsetname): Define only if
303 defined HAVE_X_WINDOWS && defined USE_X_TOOLKIT
304 (x_screen_planes): Remove; unused.
305 * dispextern.h (x_screen_planes): Remove decl.
306
5bf46f05
PE
307 * dispnew.c: Make symbols static if they're not exported.
308 * dispextern.h (redraw_garbaged_frames, scrolling):
309 (increment_row_positions): Remove.
310 * dispnew.c (new_glyph_matrix, increment_row_positions, scrolling):
311 (delayed_size_change, glyph_matrix_count, glyph_pool_count):
312 Now static.
313 (redraw_garbaged_frames): Remove; unused.
314
435f4c28
PE
315 * xfaces.c: Make symbols static if they're not exported.
316 * dispextern.h (ascii_face_of_lisp_face, free_realized_face):
317 Remove decls.
318 * xterm.h (defined_color): Remove decls.
319 (x_free_dpy_colors): Declare only if USE_X_TOOLKIT.
320 * xfaces.c (tty_suppress_bold_inverse_default_colors_p):
321 (menu_face_changed_default, defined_color, free_realized_face):
322 (x_free_dpy_colors): Define only if USE_X_TOOLKIT.
323 (ascii_face_of_lisp_face): Remove; unused.
324
8524aef3
PE
325 * xdisp.c: Make symbols static if they're not exported.
326 * dispextern.h (scratch_glyph_row, window_box_edges):
327 (glyph_to_pixel_coords, set_cursor_from_row):
328 (get_next_display_element, set_iterator_to_next):
329 (highlight_trailing_whitespace, frame_to_window_pixel_xy):
330 (show_mouse_face): Remove decls
331 * frame.h (message_buf_print): Likewise.
332 * lisp.h (pop_message, set_message, check_point_in_composition):
333 Likewise.
334 * xterm.h (set_vertical_scroll_bar): Likewise.
335 * xdisp.c (list_of_error, Vmessage_stack, line_number_displayed):
336 (message_buf_print, scratch_glyph_row, displayed_buffer):
337 (set_iterator_to_next, pop_message, set_message, set_cursor_from_row):
338 (get_next_display_element, show_mouse_face, window_box_edges):
339 (frame_to_window_pixel_xy, check_point_in_composition):
340 (set_vertical_scroll_bar, highlight_trailing_whitespace): Now static.
341 (glyph_to_pixel_coords): Remove; unused.
342
16390cd2
PE
343 * dired.c (file_name_completion): Now static.
344
345 * dbusbind.c (xd_in_read_queued_messages): Now static.
346
a25f4dfa
PE
347 * lisp.h (circular_list_error, FOREACH): Remove; unused.
348 * data.c (circular_list_error): Remove.
349
14a9c8df
PE
350 * commands.h (last_point_position, last_point_position_buffer):
351 (last_point_position_window): Remove decls.
352 * keyboard.c: Make these variables static.
353
74ab6df5
PE
354 * coding.h (coding, code_convert_region, encode_coding_gap): Remove
355 decls.
356 * coding.c (Vsjis_coding_system, Vbig5_coding_system):
357 (iso_code_class, detect_coding, code_convert_region): Now static.
358 (encode_coding_gap): Remove; unused.
359
38dfbee1
PE
360 * chartab.c (chartab_chars, chartab_bits): Now static.
361
a2cb4e63
PE
362 * charset.h (charset_iso_8859_1): Remove decl.
363 * charset.c (charset_iso_8859_1, charset_emacs, map_charset_for_dump):
364 Now static.
365
127198fd
PE
366 * ccl.h (check_ccl_update, Vccl_program_table): Remove decls.
367 * ccl.c (Vccl_program_table): Now static.
368 (check_ccl_update): Remove; unused.
369
d85b608f
PE
370 * category.c (SET_CATEGORY_SET, set_category_set): Move here.
371 * category.h: ... from here.
372 * category.c (check_category_table, set_category_set): Now static.
373
31cd66f3
PE
374 * casetab.c (Vascii_upcase_table, Vascii_eqv_table): Now static.
375 * lisp.h: Remove these decls.
376
c358e587
PE
377 * buffer.c (buffer_count): Remove unused var.
378
e78aecca
PE
379 * bidi.c (bidi_dump_cached_states): Mark as externally visible,
380 so that it's not optimized away.
381 (bidi_ignore_explicit_marks_for_paragraph_level): Likewise.
382 * dispextern.h (bidi_dump_cached_states): Remove, since it's
383 exported only to the debugger.
384
e192d7d3
PE
385 * atimer.c (alarm_signal_handler, run_all_atimers): Now static.
386 * atimer.h (run_all_atimers): Removed; not exported.
387
92470028
PE
388 font.c: Make copy_font_spec and merge_font_spec ordinary C functions.
389 * font.c (copy_font_spec): Rename from Fcopy_font_spec, since it
390 was inaccessible from Lisp.
391 (merge_font_spec): Likewise, renaming from Fmerge_font_spec.
392 * font.c, font.h, fontset.c, xfaces.c, xfont.c: Change all uses.
393
244ed907
PE
394 alloc.c: Import and export fewer symbols, and remove unused items.
395 * lisp.h (suppress_checking, die): Declare only if ENABLE_CHECKING
396 is defined.
397 (suppress_checking): Add EXTERNALLY_VISIBLE attribute, so that
398 it's not optimized away by whole-program optimization.
399 (message_enable_multibyte, free_misc): Remove.
400 (catchlist, handlerlist, mark_backtrace):
401 Declare only if BYTE_MARK_STACK.
402 (mark_byte_stack): Likewise, fixing a ifdef-vs-if typo.
403 * alloc.c (pure): Export only if VIRT_ADDR_VARIES is defined.
404 (message_enable_multibyte): Remove decl.
405 (free_misc, interval_free_list, float_block, float_block_index):
406 (n_float_blocks, float_free_list, cons_block, cons_block_index):
407 (cons_free_list, last_marked_index):
408 Now static.
409 (suppress_checking, die): Define only if ENABLE_CHECKING is defined.
410 * eval.c (catchlist, handlerlist): Export only if BYTE_MARK_STACK.
411 (mark_backtrace): Define only if BYTE_MARK_STACK.
412 * xdisp.c (message_enable_multibyte): Now static.
413
955cbe7b
PE
414 Declare Lisp_Object Q* variables to be 'static' if not exproted.
415 This makes it easier for human readers (and static analyzers)
416 to see whether these variables are used from other modules.
417 * alloc.c, buffer.c, bytecode.c, callint.c, casetab.c, category.c:
418 * ccl.c, character.c, charset.c, cmds.c, coding.c, composite.c:
419 * data.c, dbusbind.c, dired.c, editfns.c, eval.c, fileio.c, fns.c:
420 * font.c, frame.c, fringe.c, ftfont.c, image.c, keyboard.c, keymap.c:
421 * lread.c, macros.c, minibuf.c, print.c, process.c, search.c:
422 * sound.c, syntax.c, textprop.c, window.c, xdisp.c, xfaces.c, xfns.c:
423 * xmenu.c, xselect.c:
424 Declare Q* vars static if they are not used in other modules.
425 * ccl.h, character.h, charset.h, coding.h, composite.h, font.h:
426 * frame.h, intervals.h, keyboard.h, lisp.h, process.h, syntax.h:
427 Remove decls of unexported vars.
428 * keyboard.h (EVENT_HEAD_UNMODIFIED): Remove now-unused macro.
429
95c82688
PE
430 * lisp.h (DEFINE_FUNC): Make sname 'static'.
431
16a97296
PE
432 Make Emacs functions such as Fatom 'static' by default.
433 This makes it easier for human readers (and static analyzers)
434 to see whether these functions can be called from other modules.
435 DEFUN now defines a static function. To make the function external
436 so that it can be used in other C modules, use the new macro DEFUE.
8bd7b830
PE
437 * lisp.h (Funibyte_char_to_multibyte, Fsyntax_table_p):
438 (Finit_image_library):
16a97296
PE
439 (Feval_region, Fbacktrace, Ffetch_bytecode, Fswitch_to_buffer):
440 (Ffile_executable_p, Fmake_symbolic_link, Fcommand_execute):
441 (Fget_process, Fdocumentation_property, Fbyte_code, Ffile_attributes):
442 Remove decls, since these functions are now static.
443 (Funintern, Fget_internal_run_time): New decls, since these functions
444 were already external.
95c82688 445
16a97296
PE
446 * alloc.c, buffer.c, callint.c, callproc.c, casefiddle.c, casetab.c:
447 * ccl.c, character.c, chartab.c, cmds.c, coding.c, data.c, dispnew.c:
448 * doc.c, editfns.c, emacs.c, eval.c, fileio.c, filelock.c, floatfns.c:
449 * fns.c, font.c, fontset.c, frame.c, image.c, indent.c:
450 * keyboard.c, keymap.c, lread.c:
451 * macros.c, marker.c, menu.c, minibuf.c, print.c, process.c, search.c:
452 * syntax.c, term.c, terminal.c, textprop.c, undo.c:
453 * window.c, xdisp.c, xfaces.c, xfns.c, xmenu.c, xsettings.c:
454 Mark functions with DEFUE instead of DEFUN,
455 if they are used in other modules.
456 * buffer.c (Fset_buffer_major_mode, Fdelete_overlay): New forward
457 decls for now-static functions.
458 * buffer.h (Fdelete_overlay): Remove decl.
459 * callproc.c (Fgetenv_internal): Mark as internal.
460 * composite.c (Fremove_list_of_text_properties): Remove decl.
461 (Fcomposition_get_gstring): New forward static decl.
462 * composite.h (Fcomposite_get_gstring): Remove decl.
463 * dired.c (Ffile_attributes): New forward static decl.
464 * doc.c (Fdocumntation_property): New forward static decl.
465 * eval.c (Ffetch_bytecode): New forward static decl.
466 (Funintern): Remove extern decl; now in .h file where it belongs.
467 * fileio.c (Fmake_symbolic_link): New forward static decl.
468 * image.c (Finit_image_library): New forward static decl.
469 * insdel.c (Fcombine_after_change_execute): Make forward decl static.
470 * intervals.h (Fprevious_property_change):
471 (Fremove_list_of_text_properties): Remove decls.
472 * keyboard.c (Fthis_command_keys): Remove decl.
473 (Fcommand_execute): New forward static decl.
474 * keymap.c (Flookup_key): New forward static decl.
475 (Fcopy_keymap): Now static.
476 * keymap.h (Flookup_key): Remove decl.
477 * process.c (Fget_process): New forward static decl.
478 (Fprocess_datagram_address): Mark as internal.
479 * syntax.c (Fsyntax_table_p): New forward static decl.
480 (skip_chars): Remove duplicate decl.
481 * textprop.c (Fprevious_property_change): New forward static decl.
482 * window.c (Fset_window_fringes, Fset_window_scroll_bars):
483 Now internal.
484 (Fset_window_margins, Fset_window_vscroll): New forward static decls.
485 * window.h (Fset_window_vscroll, Fset_window_margins): Remove decls.
486
785bbd42
PE
487 * editfns.c (Fformat): Remove unreachable code.
488
8b913b57
AS
4892011-04-14 Andreas Schwab <schwab@linux-m68k.org>
490
491 * fileio.c (Finsert_file_contents): Fix typo in 2005-05-13
492 change. (Bug#8496)
493
a6744a35
EZ
4942011-04-13 Eli Zaretskii <eliz@gnu.org>
495
496 * xdisp.c (handle_invisible_prop): Don't call bidi_paragraph_init
497 when at ZV. (Bug#8487)
498
e7974947
AS
4992011-04-12 Andreas Schwab <schwab@linux-m68k.org>
500
baad03f0
AS
501 * charset.c (Fclear_charset_maps): Use xfree instead of free.
502 (Bug#8437)
503 * keyboard.c (parse_tool_bar_item): Likewise.
504 * sound.c (sound_cleanup, alsa_close): Likewise.
505 * termcap.c (tgetent): Likewise.
506 * xfns.c (x_default_font_parameter): Likewise.
507 * xsettings.c (read_and_apply_settings): Likewise.
508
e7974947
AS
509 * alloc.c (overrun_check_malloc, overrun_check_realloc)
510 (overrun_check_free): Protoize.
511
28272684
PE
5122011-04-12 Paul Eggert <eggert@cs.ucla.edu>
513
514 * sysdep.c (emacs_read, emacs_write): Check for negative sizes
515 since callers should never pass a negative size.
516 Change the signature to match that of plain 'read' and 'write'; see
517 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00397.html>.
518 * lisp.h: Update prototypes of emacs_write and emacs_read.
519
11997c76
EZ
5202011-04-11 Eli Zaretskii <eliz@gnu.org>
521
522 * xdisp.c (redisplay_window): Don't try to determine the character
523 position of the scroll margin if the window start point w->startp
e896f03c 524 is outside the buffer's accessible region. (Bug#8468)
11997c76 525
8a2cbd72
EZ
5262011-04-10 Eli Zaretskii <eliz@gnu.org>
527
528 Fix write-region and its subroutines for buffers > 2GB.
529 * fileio.c (a_write, e_write): Modify declaration of arguments and
530 local variables to support buffers larger than 2GB.
531 (Fcopy_file): Use EMACS_INT for return value of emacs_read.
532
533 * sysdep.c (emacs_write, emacs_read): Use ssize_t for last
534 argument, local variables, and return value.
535
536 * lisp.h: Update prototypes of emacs_write and emacs_read.
537
538 * sound.c (vox_write): Use ssize_t for return value of emacs_write.
539
4073e537 5402011-04-10 Paul Eggert <eggert@cs.ucla.edu>
eb3f1cc8 541
1ebfdcb6
PE
542 * xdisp.c (vmessage): Use memchr, not strnlen, which some hosts lack.
543
b2ded58d
PE
544 Fix more problems found by GCC 4.6.0's static checks.
545
7d66342c
PE
546 * xdisp.c (vmessage): Use a better test for character truncation.
547
bbf47d44
PE
548 * charset.c (load_charset_map): <, not <=, for optimization,
549 and to avoid potential problems with integer overflow.
9248994d 550 * chartab.c (sub_char_table_set_range, char_table_set_range): Likewise.
f9a68bc5 551 * casetab.c (set_identity, shuffle): Likewise.
3ab1c7ce 552 * editfns.c (Fformat): Likewise.
1e69125e 553 * syntax.c (skip_chars): Likewise.
3befa583 554
e3019616
PE
555 * xmenu.c (set_frame_menubar): Allocate smaller local vectors.
556 This also lets GCC 4.6.0 generate slightly better loop code.
557
becfa255
PE
558 * callint.c (Fcall_interactively): <, not <=, for optimization.
559 (Fcall_interactively): Count the number of arguments produced,
560 not the number of arguments given. This is simpler and lets GCC
561 4.6.0 generate slightly better code.
562
dae0cd48
PE
563 * ftfont.c: Distingish more carefully between FcChar8 and char.
564 The previous code passed unsigned char * to a functions like
565 strlen and xstrcasecmp that expect char *, which does not
566 conform to the C standard.
567 (get_adstyle_property, ftfont_pattern_entity): Use FcChar8 for
568 arguments to FcPatternGetString, and explicitly cast FcChar8 * to
569 char * when the C standard requires it.
570
76032d70
PE
571 * keyboard.c (read_char): Remove unused var.
572
eb3f1cc8
PE
573 * eval.c: Port to Windows vsnprintf (Bug#8435).
574 Include <limits.h>.
575 (SIZE_MAX): Define if the headers do not.
576 (verror): Do not give up if vsnprintf returns a negative count.
577 Instead, grow the buffer. This ports to Windows vsnprintf, which
578 does not conform to C99. Problem reported by Eli Zaretskii.
579 Also, simplify the allocation scheme, by avoiding the need for
580 calling realloc, and removing the ALLOCATED variable.
581
70476b54
PE
582 * eval.c (verror): Initial buffer size is 4000 (not 200) bytes.
583
12020a9e
PE
584 Remove invocations of doprnt, as Emacs now uses vsnprintf.
585 But keep the doprint source code for now, as we might revamp it
586 and use it again (Bug#8435).
ea6c7ae6
PE
587 * lisp.h (doprnt): Remove.
588 * Makefile.in (base_obj): Remove doprnt.o.
589 * deps.mk (doprnt.o): Remove.
590
5fdb398c
PE
591 error: Print 32- and 64-bit integers portably (Bug#8435).
592 Without this change, on typical 64-bit hosts error ("...%d...", N)
593 was used to print both 32- and 64-bit integers N, which relied on
594 undefined behavior.
595 * lisp.h, src/m/amdx86-64.h, src/m/ia64.h, src/m/ibms390x.h (pEd):
596 New macro.
597 * lisp.h (error, verror): Mark as printf-like functions.
598 * eval.c (verror): Use vsnprintf, not doprnt, to do the real work.
599 Report overflow in size calculations when allocating printf buffer.
600 Do not truncate output string at its first null byte.
601 * xdisp.c (vmessage): Use vsnprintf, not doprnt, to do the real work.
602 Truncate the output at a character boundary, since vsnprintf does not
603 do that.
604 * charset.c (check_iso_charset_parameter): Convert internal
605 character to string before calling 'error', since %c now has the
606 printf meaning.
607 * coding.c (Fdecode_sjis_char, Fdecode_big5_char): Avoid int
608 overflow when computing char to be passed to 'error'. Do not
609 pass Lisp_Object to 'error'; pass the integer instead.
610 * nsfns.m (Fns_do_applescript): Use int, not long, since it's
611 formatted with plain %d.
612
b189fa66
PE
613 * eval.c (internal_lisp_condition_case): Don't pass spurious arg.
614
bff87ef0
PE
615 * keyboard.c (access_keymap_keyremap): Print func name, not garbage.
616
7e2cac20
PE
617 * coding.c (Fdecode_sjis_char): Don't assume CODE fits in int.
618
ce4d90b5
PE
619 * xterm.c (x_catch_errors): Remove duplicate declaration.
620
266c9547
PE
621 * term.c (maybe_fatal): Mark its 3rd arg as a printf format, too.
622
79c49ad2
PE
623 * xdisp.c, lisp.h (message_nolog): Remove; unused.
624
368f4090
JM
6252011-04-10 Jim Meyering <meyering@redhat.com>
626
627 use ssize_t and size_t for read- and write-like emacs_gnutls_* functions
628 * gnutls.c (emacs_gnutls_read): Adjust signature to be more read-like:
629 return ssize_t not "int", and use size_t as the buffer length.
630 (emacs_gnutls_write): Likewise, and make the buffer pointer "const".
631 * gnutls.h: Update declarations.
632 * process.c (read_process_output): Use ssize_t, to match.
633 (send_process): Likewise.
634
a32d4040
CY
6352011-04-09 Chong Yidong <cyd@stupidchicken.com>
636
637 * image.c (Fimagemagick_types): Doc fix, and comment cleanup.
638
8546720e 6392011-04-09 Chong Yidong <cyd@stupidchicken.com>
aac0c6e3 640
8546720e
GM
641 * ftfont.c (get_adstyle_property, ftfont_pattern_entity): Use
642 unsigned char, to match FcChar8 type definition.
aac0c6e3 643
8546720e
GM
644 * xterm.c (handle_one_xevent):
645 * xmenu.c (create_and_show_popup_menu):
646 * xselect.c (x_decline_selection_request)
647 (x_reply_selection_request): Avoid type-punned deref of X events.
aac0c6e3 648
0a2f5c1a 6492011-04-09 Eli Zaretskii <eliz@gnu.org>
a53e2e89
EZ
650
651 Fix some uses of `int' instead of EMACS_INT.
652 * search.c (string_match_1, fast_string_match)
653 (fast_c_string_match_ignore_case, fast_string_match_ignore_case)
654 (scan_buffer, find_next_newline_no_quit)
655 (find_before_next_newline, search_command, Freplace_match)
656 (Fmatch_data): Make some `int' variables be EMACS_INT.
657
658 * xdisp.c (display_count_lines): 3rd argument and return value now
659 EMACS_INT. All callers changed.
660 (pint2hrstr): Last argument is now EMACS_INT.
661
662 * coding.c (detect_coding_utf_8, detect_coding_emacs_mule)
663 (detect_coding_iso_2022, detect_coding_sjis, detect_coding_big5)
664 (detect_coding_ccl, detect_coding_charset, decode_coding_utf_8)
665 (decode_coding_utf_16, decode_coding_emacs_mule)
666 (decode_coding_iso_2022, decode_coding_sjis, decode_coding_big5)
667 (decode_coding_ccl, decode_coding_charset)
668 <consumed_chars, consumed_chars_base>: Declare EMACS_INT.
669 (decode_coding_iso_2022, decode_coding_emacs_mule)
670 (decode_coding_sjis, decode_coding_big5, decode_coding_charset)
671 <char_offset, last_offset>: Declare EMACS_INT.
672 (encode_coding_utf_8, encode_coding_utf_16)
673 (encode_coding_emacs_mule, encode_invocation_designation)
674 (encode_designation_at_bol, encode_coding_iso_2022)
675 (encode_coding_sjis, encode_coding_big5, encode_coding_ccl)
676 (encode_coding_raw_text, encode_coding_charset) <produced_chars>:
677 Declare EMACS_INT.
678 (ASSURE_DESTINATION): Declare more_bytes EMACS_INT.
679 (encode_invocation_designation): Last argument P_NCHARS is now
680 EMACS_INT.
681 (decode_eol): Declare pos_byte, pos, and pos_end EMACS_INT.
682 (produce_chars): from_nchars and to_nchars are now EMACS_INT.
683
684 * coding.h (struct coding_system) <head_ascii>: Declare EMACS_INT.
685 All users changed.
686
687 * ccl.c (Fccl_execute_on_string): Declare some variables
688 EMACS_INT.
689
8546720e 6902011-04-08 Samuel Thibault <sthibault@debian.org> (tiny change)
0080dc6b
SS
691
692 * term.c (init_tty): Fix incorrect ifdef placement (Bug#8450).
693
4e19a977
CS
6942011-03-19 Christoph Scholtes <cschol2112@googlemail.com>
695
696 * process.c (Fformat_network_address): Doc fix.
697
87302331
R
6982011-04-08 T.V. Raman <tv.raman.tv@gmail.com> (tiny change)
699
700 * xml.c (parse_region): Avoid creating spurious whiespace nodes.
701
cbb59342
CY
7022011-04-08 Chong Yidong <cyd@stupidchicken.com>
703
704 * keyboard.c (read_char): Call Lisp function help-form-show,
705 instead of using internal_with_output_to_temp_buffer.
706 (Qhelp_form_show): New var.
e0d38eeb 707 (syms_of_keyboard): Use DEFSYM macro.
cbb59342
CY
708
709 * print.c (internal_with_output_to_temp_buffer): Function deleted.
710
711 * lisp.h (internal_with_output_to_temp_buffer): Remove prototype.
712
e67a13ab
CY
7132011-04-06 Chong Yidong <cyd@stupidchicken.com>
714
715 * process.c (Flist_processes): Removed to Lisp.
716 (list_processes_1): Deleted.
717
973f782d
EZ
7182011-04-06 Eli Zaretskii <eliz@gnu.org>
719
7c106b1e
EZ
720 * msdos.c (careadlinkat, careadlinkatcwd): MS-DOS replacements.
721
973f782d
EZ
722 * w32.c (careadlinkat, careadlinkatcwd): New always-fail stubs.
723
41cf7d1a 7242011-04-06 Paul Eggert <eggert@cs.ucla.edu>
27ccc379 725
ca23cc88
PE
726 Fix more problems found by GCC 4.6.0's static checks.
727
f390e2d5
PE
728 * xmenu.c (Fx_popup_dialog): Don't assume string is free of formats.
729
42eea0d0
PE
730 * menu.c (Fx_popup_menu): Don't assume error_name lacks printf formats.
731
b69769da 732 * lisp.h (message, message_nolog, fatal): Mark as printf-like.
1e973bc7 733
f9541e84
PE
734 * xdisp.c (vmessage): Mark as a printf-like function.
735
13841b55
PE
736 * term.c (vfatal, maybe_fatal): Mark as printf-like functions.
737
c136c10f
PE
738 * sound.c (sound_warning): Don't crash if arg contains a printf format.
739
5e2d4a30
PE
740 * image.c (tiff_error_handler, tiff_warning_handler): Mark as
741 printf-like functions.
742 (tiff_load): Add casts to remove these marks before passing them
743 to system-supplied API.
744
583f48b9
PE
745 * eval.c (Fsignal): Remove excess argument to 'fatal'.
746
b25d760e
PE
747 * coding.c (EMIT_ONE_BYTE, EMIT_TWO_BYTES): Use unsigned, not int.
748 This avoids several warnings with gcc -Wstrict-overflow.
d5efd1d1
PE
749 (DECODE_COMPOSITION_RULE): If the rule is invalid, goto invalid_code
750 directly, rather than having caller test rule sign. This avoids
751 some unnecessary tests.
752 * composite.h (COMPOSITION_ENCODE_RULE_VALID): New macro.
753 (COMPOSITION_ENCODE_RULE): Arguments now must be valid. This
754 affects only one use, in DECODE_COMPOSITION_RULE, which is changed.
b25d760e 755
bc7b6697 756 * xfont.c (xfont_text_extents): Remove var that was set but not used.
625a3eb1 757 (xfont_open): Avoid unnecessary tests.
bc7b6697 758
27ccc379
PE
759 * composite.c (composition_gstring_put_cache): Use unsigned integer.
760
dcd5c89a
PE
761 * composite.h, composite.c (composition_gstring_put_cache):
762 Use EMACS_INT, not int, for length.
763
b13a45c6
PE
764 * composite.h (COMPOSITION_DECODE_REFS): New macro,
765 breaking out part of COMPOSITION_DECODE_RULE.
766 (COMPOSITION_DECODE_RULE): Use it.
767 * composite.c (get_composition_id): Remove unused local vars,
768 by using the new macro.
769
1e792e4d
PE
770 * textprop.c (set_text_properties_1): Change while to do-while,
771 since the condition is always true at first.
772
dc6c6455 773 * intervals.c (graft_intervals_into_buffer): Mark var as used.
aa86731f
PE
774 (interval_deletion_adjustment): Return unsigned value.
775 All uses changed.
dc6c6455 776
aba7731a
PE
777 * process.c (list_processes_1, create_pty, read_process_output):
778 (exec_sentinel): Remove vars that were set but not used.
afd4052b 779 (create_pty): Remove unnecessary "volatile"s.
bc57d757 780 (Fnetwork_interface_info): Avoid possibility of int overflow.
82eaa333 781 (read_process_output): Do adaptive read buffering even if carryover.
fe07cdfa 782 (read_process_output): Simplify nbytes computation if buffered.
aba7731a 783
fdfc4bf3
PE
784 * bytecode.c (exec_byte_code): Rename local to avoid shadowing.
785
fca8fe46 786 * syntax.c (scan_words): Remove var that was set but not used.
12cbf13f 787 (update_syntax_table): Use unsigned instead of int.
fca8fe46 788
06a0259a 789 * lread.c (lisp_file_lexically_bound_p): Use ints rather than endptrs.
3c346cc3 790 (lisp_file_lexically_bound_p, read1): Use unsigned instead of int.
e6eb4e9e 791 (safe_to_load_p): Make the end-of-loop test the inverse of the in-loop.
06a0259a 792
e7b9e80f
PE
793 * print.c (print_error_message): Avoid int overflow.
794
56201685
PE
795 * font.c (font_list_entities): Redo for clarity,
796 so that reader need not know FONT_DPI_INDEX + 1 == FONT_SPACING_INDEX.
797
78834453 798 * font.c (font_find_for_lface, Ffont_get_glyphs): Remove unused vars.
790771b1 799 (font_score): Avoid potential overflow in diff calculation.
78834453 800
0bc0b309 801 * fns.c (substring_both): Remove var that is set but not used.
8cd55cb4 802 (sxhash): Redo loop for clarity and to avoid wraparound warning.
0bc0b309 803
e610eaca
PE
804 * eval.c (funcall_lambda): Rename local to avoid shadowing.
805
b895abce
PE
806 * alloc.c (mark_object_loop_halt, mark_object): Use size_t, not int.
807 Otherwise, GCC 4.6.0 optimizes the loop check away since the check
808 can always succeed if overflow has undefined behavior.
809
1f1d9321 810 * search.c (boyer_moore, wordify): Remove vars set but not used.
6f076cc7 811 (wordify): Omit three unnecessary tests.
1f1d9321 812
c59478bc
PE
813 * indent.c (MULTIBYTE_BYTES_WIDTH): Don't compute wide_column.
814 All callers changed. This avoids the need for an unused var.
815
79b73827
PE
816 * casefiddle.c (casify_region): Remove var that is set but not used.
817
a4db5dfe
PE
818 * dired.c (file_name_completion): Remove var that is set but not used.
819
43aae36e
PE
820 * fileio.c (Finsert_file_contents): Make EOF condition clearer.
821
2a47c44d 822 * fileio.c (Finsert_file_contents): Avoid signed integer overflow.
163c5f32 823 (Finsert_file_contents): Remove unnecessary code checking fd.
2a47c44d 824
a37c69bf
PE
825 * minibuf.c (read_minibuf_noninteractive): Use size_t for sizes.
826 Check for integer overflow on size calculations.
827
328ab8e7
PE
828 * buffer.c (Fprevious_overlay_change): Remove var that is set
829 but not used.
830
e5a2a5cb
PE
831 * keyboard.c (menu_bar_items, read_char_minibuf_menu_prompt):
832 Remove vars that are set but not used.
8d84a6eb 833 (timer_check_2): Don't assume timer-list and idle-timer-list are lists.
6b043475 834 (timer_check_2): Mark vars as initialized.
e5a2a5cb 835
a60e5f68
PE
836 * gtkutil.c (xg_get_file_with_chooser): Mark var as initialized.
837
f661cb61 838 * image.c (lookup_image): Remove var that is set but not used.
35fa624f 839 (xbm_load): Use parse_p, for gcc -Werror=unused-but-set-variable.
f661cb61 840
f0397f5a
PE
841 * fontset.c (Finternal_char_font, Ffontset_info): Remove vars
842 that are set but not used.
843
8664db06 844 * xfns.c (make_invisible_cursor): Don't return garbage
03733ee7 845 if XCreateBitmapFromData fails (Bug#8410).
8664db06 846
6abdaa4a
PE
847 * xselect.c (x_get_local_selection, x_handle_property_notify):
848 Remove vars that are set but not used.
849
0ce7538d 850 * xfns.c (x_create_tip_frame): Remove var that is set but not used.
6abdaa4a 851 (make_invisible_cursor): Initialize a possibly-uninitialized variable.
0ce7538d 852
9ae848fc
PE
853 * xterm.c (x_scroll_bar_to_input_event) [!USE_GTK]:
854 Remove var that is set but not used.
0b918413
PE
855 (scroll_bar_windows_size): Now size_t, not int.
856 (x_send_scroll_bar_event): Use size_t, not int, for sizes.
857 Check for overflow.
9ae848fc 858
a5a62657
PE
859 * xfaces.c (realize_named_face): Remove vars that are set but not used.
860 (map_tty_color) [!defined MSDOS]: Likewise.
861
5c5cdd39
PE
862 * term.c (tty_write_glyphs): Use size_t; this avoids overflow warning.
863
66ebf983
PE
864 * coding.c: Remove vars that are set but not used.
865 (DECODE_COMPOSITION_RULE): Remove 2nd arg, which is unused.
866 All callers changed.
867 (decode_coding_utf_8, decode_coding_utf_16 decode_coding_emacs_mule):
868 (decode_coding_iso_2022, encode_coding_sjis, encode_coding_big5):
869 (decode_coding_charset): Remove vars that are set but not used.
870
1be4d761
PE
871 * bytecode.c (Fbyte_code) [!defined BYTE_CODE_SAFE]: Remove var
872 that is set but not used.
873
47553fa8
PE
874 * print.c (print_object): Remove var that is set but not used.
875
1f7196bf 876 Replace 2 copies of readlink code with 1 gnulib version (Bug#8401).
d1fdcab7
PE
877 The gnulib version avoids calling malloc in the usual case,
878 and on 64-bit hosts doesn't have some arbitrary 32-bit limits.
879 * fileio.c (Ffile_symlink_p): Use emacs_readlink.
880 * filelock.c (current_lock_owner): Likewise.
881 * lisp.h (READLINK_BUFSIZE, emacs_readlink): New function.
882 * sysdep.c: Include allocator.h, careadlinkat.h.
883 (emacs_no_realloc_allocator): New static constant.
884 (emacs_readlink): New function.
fdb61804
PE
885 * deps.mk (sysdep.o): Depend on ../lib/allocator.h and on
886 ../lib/careadlinkat.h.
d1fdcab7 887
f84c17c7
SM
8882011-04-04 Stefan Monnier <monnier@iro.umontreal.ca>
889
890 * keyboard.c (safe_run_hook_funcall): Fix last change (don't stop at the
891 first non-nil return value).
892
ef3862ad
JD
8932011-04-03 Jan Djärv <jan.h.d@swipnet.se>
894
895 * nsterm.m (ns_update_auto_hide_menu_bar): Define MAC_OS_X_VERSION_10_6
896 if not defined (Bug#8403).
897
376a7006
JB
8982011-04-02 Juanma Barranquero <lekktu@gmail.com>
899
900 * xdisp.c (display_count_lines): Remove parameter `start',
901 unused since 1998-01-01T02:27:27Z!rms@gnu.org. All callers changed.
902 (get_char_face_and_encoding): Remove parameter `multibyte_p',
903 unused since 2008-05-14T01:40:23Z!handa@m17n.org. All callers changed.
904 (fill_stretch_glyph_string): Remove parameters `row' and `area',
905 unused at least since Kim's GUI unification at 2003-03-16T20:45:46Z!storm@cua.dk
906 and thereabouts. All callers changed.
907 (get_per_char_metric): Remove parameter `f', unused since
908 2008-05-14T01:40:23Z!handa@m17n.org. All callers changed.
909
6ca3801d
JM
9102011-04-02 Jim Meyering <meyering@redhat.com>
911
912 do not dereference NULL upon failed strdup
913 * nsfont.m (ns_descriptor_to_entity): Use xstrdup, not strdup.
914 (ns_get_family): Likewise.
915
d8e2b5ba
JB
9162011-04-02 Juanma Barranquero <lekktu@gmail.com>
917
918 * eval.c (unwind_to_catch) [DEBUG_GCPRO]: Remove redundant assignment.
919
8c74fcbd
JD
9202011-04-02 Jan Djärv <jan.h.d@swipnet.se>
921
922 * nsterm.m (ns_update_auto_hide_menu_bar): Only for OSX 10.6 or
923 later (Bug#8403).
924
7200d79c
SM
9252011-04-01 Stefan Monnier <monnier@iro.umontreal.ca>
926
03408648 927 Add lexical binding.
7200d79c 928
03408648
SM
929 * window.c (Ftemp_output_buffer_show): New fun.
930 (Fsave_window_excursion):
931 * print.c (Fwith_output_to_temp_buffer): Move to subr.el.
932
933 * lread.c (lisp_file_lexically_bound_p): New function.
934 (Fload): Bind Qlexical_binding.
935 (readevalloop): Remove `evalfun' arg.
936 Bind Qinternal_interpreter_environment.
937 (Feval_buffer): Bind Qlexical_binding.
938 (defvar_int, defvar_bool, defvar_lisp_nopro, defvar_kboard):
939 Mark as dynamic.
940 (syms_of_lread): Declare `lexical-binding'.
941
942 * lisp.h (struct Lisp_Symbol): New field `declared_special'.
943
944 * keyboard.c (eval_dyn): New fun.
945 (menu_item_eval_property): Use it.
ca105506
SM
946
947 * image.c (parse_image_spec): Use Ffunctionp.
ca105506 948
03408648
SM
949 * fns.c (concat, mapcar1): Accept byte-code-functions.
950
951 * eval.c (Fsetq): Handle lexical vars.
952 (Fdefun, Fdefmacro, Ffunction): Make closures when needed.
953 (Fdefconst, Fdefvaralias, Fdefvar): Mark as dynamic.
954 (FletX, Flet): Obey lexical binding.
955 (Fcommandp): Handle closures.
956 (Feval): New `lexical' arg.
957 (eval_sub): New function extracted from Feval. Use it almost
958 everywhere where Feval was used. Look up vars in lexical env.
959 Handle closures.
960 (Ffunctionp): Move from subr.el.
961 (Ffuncall): Handle closures.
962 (apply_lambda): Remove `eval_flags'.
963 (funcall_lambda): Handle closures and new byte-code-functions.
964 (Fspecial_variable_p): New function.
965 (syms_of_eval): Initialize the Vinternal_interpreter_environment var,
966 but without exporting it to Lisp.
23aba0ea 967
23aba0ea 968 * doc.c (Fdocumentation, store_function_docstring):
03408648 969 * data.c (Finteractive_form): Handle closures.
23aba0ea 970
03408648
SM
971 * callint.c (Fcall_interactively): Preserve lexical-binding mode for
972 interactive spec.
ba83908c 973
03408648
SM
974 * bytecode.c (Bstack_ref, Bstack_set, Bstack_set2, BdiscardN): New
975 byte-codes.
976 (exec_byte_code): New function extracted from Fbyte_code to handle new
977 calling convention for byte-code-functions. Add new byte-codes.
ba83908c 978
03408648 979 * buffer.c (defvar_per_buffer): Set new `declared_special' field.
e2abe5a1 980
03408648 981 * alloc.c (Fmake_symbol): Init new `declared_special' field.
e2abe5a1 982
e2abce01
JB
9832011-03-31 Juanma Barranquero <lekktu@gmail.com>
984
985 * xdisp.c (redisplay_internal): Fix prototype.
986
63696a73 9872011-03-31 Eli Zaretskii <eliz@gnu.org>
09725d26 988
63696a73
EZ
989 * xdisp.c (SCROLL_LIMIT): New macro.
990 (try_scrolling): Use it when setting scroll_limit. Limit
991 scrolling to 100 screen lines.
992 (redisplay_window): Even when falling back on "recentering",
993 position point in the window according to scroll-conservatively,
994 scroll-margin, and scroll-*-aggressively variables. (Bug#6671)
995
996 (try_scrolling): When point is above the window, allow searching
997 as far as scroll_max, or one screenful, to compute vertical
998 distance from PT to the scroll margin position. This prevents
999 try_scrolling from unnecessarily failing when
1000 scroll-conservatively is set to a value slightly larger than the
1001 window height. Clean up the case of PT below the margin at bottom
1002 of window: scroll_max can no longer be INT_MAX. When aggressive
1003 scrolling is in use, don't let point enter the opposite scroll
1004 margin as result of the scroll.
1005 (syms_of_xdisp) <scroll-conservatively>: Document the
09725d26
EZ
1006 threshold of 100 lines for never-recentering scrolling.
1007
e4cc2dfc
JB
10082011-03-31 Juanma Barranquero <lekktu@gmail.com>
1009
1010 * dispextern.h (move_it_by_lines):
1011 * xdisp.c (move_it_by_lines): Remove parameter `need_y_p', unused
1012 since 2000-12-29T14:24:09Z!gerd@gnu.org. All callers changed.
1013 (message_log_check_duplicate): Remove parameters `prev_bol' and
1014 `this_bol', unused since 1998-01-01T02:27:27Z!rms@gnu.org. All callers changed.
1015 (redisplay_internal): Remove parameter `preserve_echo_area',
1016 unused since 1999-07-21T21:43:52Z!gerd@gnu.org. All callers changed.
1017
1018 * indent.c (Fvertical_motion):
1019 * window.c (window_scroll_pixel_based, Frecenter):
1020 Don't pass `need_y_p' to `move_it_by_lines'.
1021
1c470562
SM
10222011-03-30 Stefan Monnier <monnier@iro.umontreal.ca>
1023
44f230aa
SM
1024 * eval.c (struct backtrace): Don't cheat with negative numbers, but do
1025 steal a few bits to be more compact.
1026 (interactive_p, Fbacktrace, Fbacktrace_frame, mark_backtrace):
1027 Remove unneeded casts.
1028
1c470562
SM
1029 * bytecode.c (Fbyte_code): CAR and CDR can GC.
1030
888adce9
ZK
10312011-03-30 Zachary Kanfer <zkanfer@gmail.com> (tiny change)
1032
1033 * keyboard.c (Fexecute_extended_command): Do log the "suggest key
1034 binding" message (bug#7967).
1035
f838ed7b
PE
10362011-03-30 Paul Eggert <eggert@cs.ucla.edu>
1037
77861b95
PE
1038 Fix more problems found by GCC 4.6.0's static checks.
1039
de6dbc14
PE
1040 * unexelf.c (unexec) [! (defined _SYSTYPE_SYSV || defined __sgi)]:
1041 Remove unused local var.
1042
f838ed7b
PE
1043 * editfns.c (Fmessage_box): Remove unused local var.
1044
792c7b2b
PE
1045 * xdisp.c (try_window_reusing_current_matrix, x_produce_glyphs):
1046 (note_mode_line_or_margin_highlight, note_mouse_highlight):
1047 Omit unused local vars.
c499e557 1048 * window.c (shrink_windows): Omit unused local var.
b01a1c29 1049 * menu.c (digest_single_submenu): Omit unused local var.
0bc32927
PE
1050 * dispnew.c (update_window) [PERIODIC_PREEMPTION_CHECKING]:
1051 Omit unused local var.
1052
ba0165e1
PE
1053 * keyboard.c (parse_modifiers_uncached, parse_modifiers):
1054 Don't assume string length fits in int.
32ad8845 1055 (keyremap_step, read_key_sequence): Use size_t for sizes.
48011560 1056 (read_key_sequence): Don't check last_real_key_start redundantly.
ba0165e1 1057
3c59b4c9
PE
1058 * callproc.c (Fcall_process, Fcall_process_region): Use SAFE_ALLOCA
1059 instead of alloca (Bug#8344).
1060
a3eed478 1061 * eval.c (Fbacktrace): Don't assume nargs fits in int.
5d5d959d 1062 (Fbacktrace_frame): Don't assume nframes fits in int.
a3eed478 1063
eb4d412d
PE
1064 * syntax.c (scan_sexps_forward): Avoid pointer wraparound.
1065
1658b401
PE
1066 * xterm.c (x_make_frame_visible, same_x_server): Redo to avoid overflow
1067 concerns.
1068
1069 * term.c (produce_glyphless_glyph): Remove unnecessary test.
1070
1071 * cm.c (calccost): Turn while-do into do-while, for clarity.
44f730c8 1072
9a2c6e05
PE
1073 * keyboard.c (syms_of_keyboard): Use the same style as later
1074 in this function when indexing through an array. This also
1075 works around GCC bug 48267.
1076
03d0a109
PE
1077 * image.c (tiff_load): Fix off-by-one image count (Bug#8336).
1078
44f730c8
PE
1079 * xselect.c (x_check_property_data): Return correct size (Bug#8335).
1080
fe75f926
PE
1081 * chartab.c (sub_char_table_ref_and_range): Redo for slight
1082 efficiency gain, and to bypass a gcc -Wstrict-overflow warning.
1083
ffa8c828
PE
1084 * keyboard.c, keyboard.h (num_input_events): Now size_t.
1085 This avoids undefined behavior on integer overflow, and is a bit
1086 more convenient anyway since it is compared to a size_t variable.
1087
c5101a77
PE
1088 Variadic C functions now count arguments with size_t, not int.
1089 This avoids an unnecessary limitation on 64-bit machines, which
1090 caused (substring ...) to crash on large vectors (Bug#8344).
1091 * lisp.h (struct Lisp_Subr.function.aMANY): Now takes size_t, not int.
1092 (DEFUN_ARGS_MANY, internal_condition_case_n, safe_call): Likewise.
77861b95 1093 All variadic functions and their callers changed accordingly.
c5101a77
PE
1094 (struct gcpro.nvars): Now size_t, not int. All uses changed.
1095 * data.c (arith_driver, float_arith_driver): Likewise.
1096 * editfns.c (general_insert_function): Likewise.
1097 * eval.c (struct backtrace.nargs, interactive_p)
1098 (internal_condition_case_n, run_hook_with_args, apply_lambda)
1099 (funcall_lambda, mark_backtrace): Likewise.
1100 * fns.c (concat): Likewise.
1101 * frame.c (x_set_frame_parameters): Likewise.
1102 * fns.c (get_key_arg): Now accepts and returns size_t, and returns
1103 0 if not found, not -1. All callers changed.
1104
dd3f25f7
PE
1105 * alloc.c (garbage_collect): Don't assume stack size fits in int.
1106 (stack_copy_size): Now size_t, not int.
1107 (stack_copy, stack_copy_size): Define only if MAX_SAVE_STACK > 0.
1108
461c2ab9
JB
11092011-03-28 Juanma Barranquero <lekktu@gmail.com>
1110
1111 * coding.c (encode_designation_at_bol): Remove parameter `charbuf_end',
1112 unused since 2002-03-01T01:17:24Z!handa@m17n.org and 2008-02-01T16:01:31Z!miles@gnu.org.
1113 All callers changed.
1114
1115 * lisp.h (multibyte_char_to_unibyte):
1116 * character.c (multibyte_char_to_unibyte): Remove parameter `rev_tbl',
1117 unused since 2002-03-01T01:16:34Z!handa@m17n.org and 2008-02-01T16:01:31Z!miles@gnu.org.
1118 * character.h (CHAR_TO_BYTE8):
1119 * cmds.c (internal_self_insert):
1120 * editfns.c (general_insert_function):
1121 * keymap.c (push_key_description):
1122 * search.c (Freplace_match):
1123 * xdisp.c (message_dolog, set_message_1): All callers changed.
1124
f6d62986
SM
11252011-03-28 Stefan Monnier <monnier@iro.umontreal.ca>
1126
1127 * keyboard.c (safe_run_hook_funcall): New function.
1128 (safe_run_hooks_1, safe_run_hooks_error, safe_run_hooks): On error,
1129 don't set the hook to nil, but remove the offending function instead.
1130 (Qcommand_hook_internal): Remove, unused.
1131 (syms_of_keyboard): Don't initialize Qcommand_hook_internal nor define
1132 Vcommand_hook_internal.
1133
1134 * eval.c (enum run_hooks_condition): Remove.
1135 (funcall_nil, funcall_not): New functions.
1136 (run_hook_with_args): Call each function through a `funcall' argument.
1137 Remove `cond' argument, now redundant.
1138 (Frun_hooks, Frun_hook_with_args, Frun_hook_with_args_until_success)
1139 (Frun_hook_with_args_until_failure): Adjust accordingly.
1140 (run_hook_wrapped_funcall, Frun_hook_wrapped): New functions.
1141
1db5b1ad
JB
11422011-03-28 Juanma Barranquero <lekktu@gmail.com>
1143
1144 * dispextern.h (string_buffer_position): Remove declaration.
1145
1146 * print.c (strout): Remove parameter `multibyte', unused since
1147 1999-08-21T19:30:21Z!gerd@gnu.org. All callers changed.
1148
1149 * search.c (boyer_moore): Remove parameters `len', `pos' and `lim',
1150 never used since function introduction in 1998-02-08T21:33:56Z!rms@gnu.org.
1151 All callers changed.
1152
1153 * w32.c (_wsa_errlist): Use braces for struct initializers.
1154
1155 * xdisp.c (string_buffer_position_lim): Remove parameter `w',
1156 never used since function introduction in 2001-03-09T18:41:50Z!gerd@gnu.org.
1157 All callers changed.
1158 (string_buffer_position): Likewise. Also, make static (it's never
1159 used outside xdisp.c).
1160 (cursor_row_p): Remove parameter `w', unused since
1161 2000-10-17T16:08:57Z!gerd@gnu.org. All callers changed.
1162 (decode_mode_spec): Remove parameter `precision', introduced during
1163 Gerd Moellmann's rewrite at 1999-07-21T21:43:52Z!gerd@gnu.org, but never used.
1164 All callers changed.
1165
5ffb62aa
JD
11662011-03-27 Jan Djärv <jan.h.d@swipnet.se>
1167
1168 * nsterm.m (syms_of_nsterm): Use doc: for ns-auto-hide-menu-bar.
1169
461c2ab9 11702011-03-27 Anders Lindgren <andlind@gmail.com>
f0a1382a
JD
1171
1172 * nsterm.m (ns_menu_bar_is_hidden): New variable.
1173 (ns_constrain_all_frames, ns_menu_bar_should_be_hidden)
1174 (ns_update_auto_hide_menu_bar): New functions.
1175 (ns_update_begin): Call ns_update_auto_hide_menu_bar.
1176 (applicationDidBecomeActive): Call ns_update_auto_hide_menu_bar and
1177 ns_constrain_all_frames.
1178 (constrainFrameRect): Return at once if ns_menu_bar_should_be_hidden.
1179 (syms_of_nsterm): DEFVAR ns-auto-hide-menu-bar, init to Qnil.
1180
5c380ffb
JD
11812011-03-27 Jan Djärv <jan.h.d@swipnet.se>
1182
1183 * nsmenu.m (runDialogAt): Remove argument to timer_check.
1184
9af30bdf
GM
11852011-03-27 Glenn Morris <rgm@gnu.org>
1186
1187 * syssignal.h: Replace RETSIGTYPE with void.
1188 * atimer.c, data.c, dispnew.c, emacs.c, floatfns.c, keyboard.c:
1189 * keyboard.h, lisp.h, process.c, sysdep.c, xterm.c:
1190 Replace SIGTYPE with void everywhere.
1191 * s/usg5-4-common.h (SIGTYPE): Remove definition.
1192 * s/template.h (SIGTYPE): Remove commented out definition.
1193
e2abce01
JB
11942011-03-26 Eli Zaretskii <eliz@gnu.org>
1195
1196 * xdisp.c (redisplay_window): Don't check buffer's clip_changed
1197 flag as a prerequisite for invoking try_scrolling. (Bug#6671)
1198
f868cd8a
JB
11992011-03-26 Juanma Barranquero <lekktu@gmail.com>
1200
59eb0929
JB
1201 * w32.c (read_unc_volume): Use parameter `henum', instead of
1202 global variable `wget_enum_handle'.
1203
1204 * keymap.c (describe_vector): Remove parameters `indices' and
1205 `char_table_depth', unused since 2002-03-01T01:43:26Z!handa@m17n.org.
1206 (describe_map, Fdescribe_vector): Adjust calls to `describe_vector'.
1207
f868cd8a
JB
1208 * keyboard.h (timer_check, show_help_echo): Remove unused parameters.
1209
1210 * keyboard.c (timer_check): Remove parameter `do_it_now',
1211 unused since 1996-04-12T06:01:29Z!rms@gnu.org.
1212 (show_help_echo): Remove parameter `ok_to_overwrite_keystroke_echo',
1213 unused since 2008-04-19T19:30:53Z!monnier@iro.umontreal.ca.
1214
1215 * keyboard.c (read_char):
1216 * w32menu.c (w32_menu_display_help):
1217 * xmenu.c (show_help_event, menu_help_callback):
1218 Adjust calls to `show_help_echo'.
1219
1220 * gtkutil.c (xg_maybe_add_timer):
1221 * keyboard.c (readable_events):
1222 * process.c (wait_reading_process_output):
1223 * xmenu.c (x_menu_wait_for_event): Adjust calls to `timer_check'.
1224
1225 * insdel.c (adjust_markers_gap_motion):
1226 Remove; no-op since 1998-01-02T21:29:48Z!rms@gnu.org.
1227 (gap_left, gap_right): Don't call it.
1228
2ecf6fdb
CY
12292011-03-25 Chong Yidong <cyd@stupidchicken.com>
1230
1231 * xdisp.c (handle_fontified_prop): Discard changes to clip_changed
1232 incurred during fontification.
1233
6b1f9ba4
JB
12342011-03-25 Juanma Barranquero <lekktu@gmail.com>
1235
1236 * buffer.c (defvar_per_buffer): Remove unused parameter `doc'.
1237 (DEFVAR_PER_BUFFER): Don't pass it.
1238
1239 * dispnew.c (row_equal_p, add_row_entry): Remove unused parameter `w'.
1240 (scrolling_window): Don't pass it.
1241
0f4a96b5
JB
12422011-03-25 Juanma Barranquero <lekktu@gmail.com>
1243
1244 * dispextern.h (glyph_matric): Use #if GLYPH_DEBUG, not #ifdef.
1245
1246 * fileio.c (check_executable) [DOS_NT]: Remove unused variables `len'
1247 and `suffix'.
1248 (Fset_file_selinux_context) [HAVE_LIBSELINUX]: Move here declaration
1249 of variables specific to SELinux and computation of `encoded_absname'.
1250
1251 * image.c (XPutPixel): Remove unused variable `height'.
1252
1253 * keyboard.c (make_lispy_event): Remove unused variable `hpos'.
1254
1255 * unexw32.c (get_section_info): Remove unused variable `section'.
1256
1257 * w32.c (stat): Remove unused variables `drive_root' and `devtype'.
1258 (system_process_attributes): Remove unused variable `sess'.
1259 (sys_read): Remove unused variable `err'.
1260
1261 * w32fns.c (top): Wrap variables with #if GLYPH_DEBUG, not #ifdef.
1262 (w32_wnd_proc): Remove unused variable `isdead'.
1263 (unwind_create_frame): Use #if GLYPH_DEBUG, not #ifdef.
1264 (Fx_server_max_request_size): Remove unused variable `dpyinfo'.
1265 (x_create_tip_frame): Remove unused variable `tem'.
1266
1267 * w32inevt.c (w32_console_read_socket):
1268 Remove unused variable `no_events'.
1269
1270 * w32term.c (x_draw_composite_glyph_string_foreground):
1271 Remove unused variable `width'.
1272
1149507c
JB
12732011-03-24 Juanma Barranquero <lekktu@gmail.com>
1274
1275 * w32term.c (x_set_glyph_string_clipping):
1276 Don't pass uninitialized region to CombineRgn.
1277
9c88f339
JB
12782011-03-23 Juanma Barranquero <lekktu@gmail.com>
1279
1280 * w32fns.c (x_set_menu_bar_lines): Remove unused variable `olines'.
1281 (w32_wnd_proc): Pass NULL to Windows API, not uninitialized buffer.
1282 (Fx_close_connection): Remove unused variable `i'.
1283
1284 * w32font.c (w32font_draw): Return number of glyphs.
1285 (w32font_open_internal): Remove unused variable `i'.
1286 (w32font_driver): Add missing initializer.
1287
1288 * w32menu.c (utf8to16): Remove unused variable `utf16'.
1289 (fill_in_menu): Remove unused variable `items_added'.
1290
1291 * w32term.c (last_mouse_press_frame): Remove static global variable.
1292 (w32_clip_to_row): Remove unused variable `f'.
1293 (x_delete_terminal): Remove unused variable `i'.
1294
1295 * w32uniscribe.c (uniscribe_shape): Remove unused variable `nclusters'.
1296 (NOTHING): Remove unused static global variable.
1297 (uniscribe_check_otf): Remove unused variable `table'.
1298 (uniscribe_font_driver): Add missing initializers.
1299
dee091a3
JD
13002011-03-23 Julien Danjou <julien@danjou.info>
1301
1302 * term.c (Fsuspend_tty, Fresume_tty):
1303 * minibuf.c (read_minibuf, run_exit_minibuf_hook):
1304 * window.c (temp_output_buffer_show):
1305 * insdel.c (signal_before_change):
1306 * frame.c (Fhandle_switch_frame):
1307 * fileio.c (Fdo_auto_save):
1308 * emacs.c (Fkill_emacs):
1309 * editfns.c (save_excursion_restore):
1310 * cmds.c (internal_self_insert):
1311 * callint.c (Fcall_interactively):
1312 * buffer.c (Fkill_all_local_variables):
1313 * keyboard.c (Fcommand_execute, Fsuspend_emacs, safe_run_hooks_1):
1314 Use Frun_hooks.
0f4a96b5 1315 (command_loop_1): Use Frun_hooks. Call safe_run_hooks
dee091a3
JD
1316 unconditionnaly since it does the check itself.
1317
2c520ab5 13182011-03-23 Paul Eggert <eggert@cs.ucla.edu>
f0641eff 1319
c9c49752
PE
1320 Fix more problems found by GCC 4.5.2's static checks.
1321
8abc3f12
PE
1322 * coding.c (encode_coding_raw_text): Avoid unnecessary test
1323 the first time through the loop, since we know p0 < p1 then.
1324 This also avoids a gcc -Wstrict-overflow warning.
1325
a2d26660
PE
1326 * lisp.h (SAFE_ALLOCA, SAFE_ALLOCA_LISP): Avoid 'int' overflow
1327 leading to a memory leak, possible in functions like
1328 load_charset_map_from_file that can allocate an unbounded number
b12ef411 1329 of objects (Bug#8318).
a2d26660 1330
916c72e9
PE
1331 * xmenu.c (set_frame_menubar): Use EMACS_UINT, not int, for indexes
1332 that could (at least in theory) be that large.
1333
19ab8a18
PE
1334 * xdisp.c (message_log_check_duplicate): Return unsigned long, not int.
1335 This is less likely to overflow, and avoids undefined behavior if
1336 overflow does occur. All callers changed. Use strtoul to scan
1337 for the unsigned long integer.
b7cbbd6f
PE
1338 (pint2hrstr): Simplify and tune code slightly.
1339 This also avoids a (bogus) GCC warning with gcc -Wstrict-overflow.
19ab8a18 1340
f0641eff
PE
1341 * scroll.c (do_scrolling): Work around GCC bug 48228.
1342 See <http://gcc.gnu.org/bugzilla/show_bug.cgi?id=48228>.
1343
7f650bb9
PE
1344 * frame.c (Fmodify_frame_parameters): Simplify loop counter.
1345 This also avoids a warning with gcc -Wstrict-overflow.
39f5e519
PE
1346 (validate_x_resource_name): Simplify count usage.
1347 This also avoids a warning with gcc -Wstrict-overflow.
7f650bb9 1348
37dd57d1
PE
1349 * fileio.c (Fcopy_file): Report error if fchown or fchmod
1350 fail (Bug#8306).
81e56e61 1351
699979fc 1352 * emacs.c (Fdaemon_initialized): Do not ignore I/O errors (Bug#8303).
dc1ca6a8 1353
401bf9b4
PE
1354 * process.c (Fmake_network_process): Use socklen_t, not int,
1355 where POSIX says socklen_t is required in portable programs.
1356 This fixes a porting bug on hosts like 64-bit HP-UX, where
591b2973 1357 socklen_t is wider than int (Bug#8277).
401bf9b4
PE
1358 (Fmake_network_process, server_accept_connection):
1359 (wait_reading_process_output, read_process_output):
1360 Likewise.
1361
b93aacde
PE
1362 * process.c: Rename or move locals to avoid shadowing.
1363 (list_processes_1, Fmake_network_process):
1364 (read_process_output_error_handler, exec_sentinel_error_handler):
1365 Rename or move locals.
4dc343ee 1366 (Fmake_network_process): Define label "retry_connect" only if needed.
0da49335 1367 (Fnetwork_interface_info): Fix pointer signedness.
f990b4e5 1368 (process_send_signal): Add cast to avoid pointer signedness problem.
7b808126 1369 (FIRST_PROC_DESC, IF_NON_BLOCKING_CONNECT): Remove unused macros.
c939f91b 1370 (create_process): Use 'volatile' to avoid vfork clobbering (Bug#8298).
b93aacde 1371
af8a867c 1372 Make tparam.h and terminfo.c consistent.
44f230aa
SM
1373 * cm.c (tputs, tgoto, BC, UP): Remove extern decls.
1374 Include tparam.h instead, since it declares them.
af8a867c
PE
1375 * cm.h (PC): Remove extern decl; tparam.h now does this.
1376 * deps.mk (cm.o, terminfo.o): Depend on tparam.h.
1377 * terminfo.c: Include tparam.h, to check interfaces.
1378 (tparm): Make 1st arg a const pointer in decl. Put it at top level.
1379 (tparam): Adjust signature to match interface in tparam.h;
1380 this removes some undefined behavior. Check that outstring and len
1381 are zero, which they always are with Emacs.
1382 * tparam.h (PC, BC, UP): New extern decls.
1383
0248044d 1384 * xftfont.c (xftfont_shape): Now static, and defined only if needed.
001a7ab4 1385 (xftfont_open): Rename locals to avoid shadowing.
0248044d 1386
8ff096c1 1387 * ftfont.c (ftfont_resolve_generic_family): Fix pointer signedness.
a00924bb
PE
1388 (ftfont_otf_capability, ftfont_shape): Omit decls if not needed.
1389 (OTF_TAG_SYM): Omit macro if not needed.
e932860f 1390 (ftfont_list): Remove unused local.
49eaafba
PE
1391 (get_adstyle_property, ftfont_pattern_entity):
1392 (ftfont_lookup_cache, ftfont_open, ftfont_anchor_point):
1393 Rename locals to avoid shadowing.
8ff096c1 1394
e2be39f6
PE
1395 * xfont.c (xfont_list_family): Mark var as initialized.
1396
c9735e30
PE
1397 * xml.c (make_dom): Now static.
1398
8f5201ae
PE
1399 * composite.c (composition_compute_stop_pos): Rename local to
1400 avoid shadowing.
b246f932
PE
1401 (composition_reseat_it): Remove unused locals.
1402 (find_automatic_composition, composition_adjust_point): Likewise.
80e079b2 1403 (composition_update_it): Mark var as initialized.
11b61122
PE
1404 (find_automatic_composition): Mark vars as initialized,
1405 with a FIXME (Bug#8290).
8f5201ae 1406
760fbc2c
PE
1407 character.h: Rename locals to avoid shadowing.
1408 * character.h (PREV_CHAR_BOUNDARY, FETCH_STRING_CHAR_ADVANCE):
1409 (FETCH_STRING_CHAR_AS_MULTIBYTE_ADVANCE, FETCH_CHAR_ADVANCE):
1410 (FETCH_CHAR_ADVANCE_NO_CHECK, INC_POS, DEC_POS, BUF_INC_POS):
1411 (BUF_DEC_POS): Be more systematic about renaming local temporaries
1412 to avoid shadowing.
1413
ff08eb85
PE
1414 * textprop.c (property_change_between_p): Remove; unused.
1415
fc7bf025
PE
1416 * intervals.c (interval_start_pos): Now static.
1417
235d7abc
PE
1418 * intervals.h (CHECK_TOTAL_LENGTH): Avoid empty "else".
1419
44f230aa
SM
1420 * atimer.c (start_atimer, append_atimer_lists, set_alarm):
1421 Rename locals to avoid shadowing.
3e7d6594 1422
50060332
PE
1423 * sound.c (wav_play, au_play, Fplay_sound_internal):
1424 Fix pointer signedness.
d01f234b 1425 (alsa_choose_format): Remove unused local var.
c83b8872
PE
1426 (wav_play): Initialize a variable to 0, to prevent undefined
1427 behavior (Bug#8278).
50060332 1428
c4fc4e30
PE
1429 * region-cache.c (insert_cache_boundary): Redo var to avoid shadowing.
1430
918436ed
PE
1431 * region-cache.h (pp_cache): New decl, for gcc -Wmissing-prototypes.
1432
c939f91b
PE
1433 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork
1434 clobbering (Bug#8298).
b9c7f648
PE
1435 * sysdep.c (sys_subshell): Likewise.
1436 Previously, the sys_subshell 'volatile' was incorrectly IF_LINTted out.
7e9123a2 1437
6bd8c144
PE
1438 * lisp.h (child_setup): Now NO_RETURN unless DOS_NT.
1439 This should get cleaned up, so that child_setup has the
1440 same signature on all platforms.
1441
7710357c 1442 * callproc.c (call_process_cleanup): Now static.
cb1d0ef7 1443 (relocate_fd): Rename locals to avoid shadowing.
7710357c 1444
c59da222
CY
14452011-03-22 Chong Yidong <cyd@stupidchicken.com>
1446
1447 * xterm.c (x_clear_frame): Remove XClearWindow call. This appears
1448 not to be necessary, and produces flickering.
1449
66b87493
GM
14502011-03-20 Glenn Morris <rgm@gnu.org>
1451
1452 * config.in: Remove file.
1453
45b6f6d5
JB
14542011-03-20 Juanma Barranquero <lekktu@gmail.com>
1455
1456 * minibuf.c (Vcompleting_read_function): Don't declare, global variables
1457 are now in src/globals.h.
1458 (syms_of_minibuf): Remove spurious & from previous change.
1459
3ec03f7e
LL
14602011-03-20 Leo <sdl.web@gmail.com>
1461
1462 * minibuf.c (completing-read-function): New variable.
1463 (completing-read-default): Rename from completing-read.
1464 (completing-read): Call completing-read-function.
1465
b14e3e21
CY
14662011-03-19 Juanma Barranquero <lekktu@gmail.com>
1467
1468 * xfaces.c (Fx_load_color_file):
1469 Read color file from absolute filename (bug#8250).
1470
f2b726e6
JB
14712011-03-19 Juanma Barranquero <lekktu@gmail.com>
1472
1473 * makefile.w32-in: Update dependencies.
1474
09f6ff02
EZ
14752011-03-17 Eli Zaretskii <eliz@gnu.org>
1476
1477 * makefile.w32-in ($(BLD)/unexw32.$(O)): Depend on $(SRC)/unexec.h.
1478
29a6015a
PE
14792011-03-17 Paul Eggert <eggert@cs.ucla.edu>
1480
a3a6c54e
PE
1481 Fix more problems found by GCC 4.5.2's static checks.
1482
b766f867
PE
1483 * process.c (make_serial_process_unwind, send_process_trap):
1484 (sigchld_handler): Now static.
1485
be02381c
PE
1486 * process.c (allocate_pty): Let PTY_ITERATION declare iteration vars.
1487 That way, the code declares only the vars that it needs.
1488 * s/aix4-2.h (PTY_ITERATION): Declare iteration vars.
1489 * s/cygwin.h (PTY_ITERATION): Likewise.
1490 * s/darwin.h (PTY_ITERATION): Likewise.
1491 * s/gnu-linux.h (PTY_ITERATION): Likewise.
1492
57048744
PE
1493 * s/irix6-5.h (PTY_OPEN): Declare stb, to loosen coupling.
1494 * process.c (allocate_pty): Don't declare stb unless it's needed.
1495
7914961c 1496 * bytecode.c (MAYBE_GC): Rewrite so as not to use empty "else".
615f2d59
PE
1497 (CONSTANTLIM): Remove; unused.
1498 (METER_CODE, Bscan_buffer, Bread_char, Bset_mark):
1499 Define only if needed.
7914961c 1500
b3967b18
PE
1501 * unexelf.c (unexec): Name an expression,
1502 to avoid gcc -Wbad-function-cast warning.
9ae71512
PE
1503 Use a different way to cause a compilation error if anyone uses
1504 n rather than nn, a way that does not involve shadowing.
73366a00 1505 (ELF_BSS_SECTION_NAME, OLD_PROGRAM_H): Remove; unused.
b3967b18 1506
29a6015a
PE
1507 * deps.mk (unexalpha.o): Remove; unused.
1508
43cfc33e 1509 New file unexec.h, the (simple) interface for unexec (Bug#8267).
7feda0d2 1510 * unexec.h: New file.
ce701a33
PE
1511 * deps.mk (emacs.o, unexaix.o, unexcw.o, unexcoff.o, unexelf.o):
1512 (unexhp9k800.o, unexmacosx.o, unexsol.o, unexw32.o):
1513 Depend on unexec.h.
1514 * emacs.c [!defined CANNOT_DUMP]: Include unexec.h.
1515 * unexaix.c, unexcoff.c, unexcw.c, unexelf.c, unexhp9k800.c:
1516 * unexmacosx.c, unexsol.c, unexw32.c: Include unexec.h.
381259ef 1517 Change as necessary to match prototype in unexec.h.
ce701a33 1518
01f44d5a
PE
1519 * syntax.c (Fforward_comment, scan_lists): Rename locals to avoid
1520 shadowing.
4f63c6bb 1521 (back_comment, skip_chars): Mark vars as initialized.
01f44d5a 1522
a6670b0b
PE
1523 * character.h (FETCH_STRING_CHAR_ADVANCE_NO_CHECK, BUF_INC_POS):
1524 Rename locals to avoid shadowing.
1525
cef2010d 1526 * lread.c (read1): Rewrite so as not to use empty "else".
0902fe45 1527 (Fload, readevalloop, read1): Rename locals to avoid shadowing.
cef2010d 1528
d4d7173a
PE
1529 * print.c (Fredirect_debugging_output): Fix pointer signedess.
1530
f08b802a
PE
1531 * lisp.h (debug_output_compilation_hack): Add decl here, to avoid
1532 warning when compiling print.c.
1533
3ddb0639
PE
1534 * font.c (font_unparse_fcname): Abort in an "impossible" situation
1535 instead of using an uninitialized var.
5ad03b97 1536 (font_sort_entities): Mark var as initialized.
3ddb0639 1537
170a2692
PE
1538 * character.h (FETCH_CHAR_ADVANCE): Rename locals to avoid shadowing.
1539
e663c700
PE
1540 * font.c (font_unparse_xlfd): Don't mix pointers to variables with
1541 pointers to constants.
89bc529a 1542 (font_parse_fcname): Remove unused vars.
7b81e2d0 1543 (font_delete_unmatched): Now static.
ea838e10 1544 (font_get_spec): Remove; unused.
13a547c6
PE
1545 (font_style_to_value, font_prop_validate_style, font_unparse_fcname):
1546 (font_update_drivers, Ffont_get_glyphs, font_add_log):
1547 Rename or move locals to avoid shadowing.
e663c700 1548
2a80c887 1549 * fns.c (require_nesting_list, require_unwind): Now static.
612f56df 1550 (Ffillarray): Rename locals to avoid shadowing.
2a80c887 1551
1384fa33 1552 * floatfns.c (domain_error2): Define only if needed.
a885e2ed 1553 (Ffrexp, Fldexp): Rename locals to avoid shadowing.
1384fa33 1554
8b2c52e9
PE
1555 * alloc.c (mark_backtrace): Move decl from here ...
1556 * lisp.h: ... to here, so that it can be checked.
1557
475545b5 1558 * eval.c (call_debugger, do_debug_on_call, grow_specpdl): Now static.
d28a2170 1559 (Fdefvar): Rewrite so as not to use empty "else".
cfcbfb1a
PE
1560 (lisp_indirect_variable): Name an expression,
1561 to avoid gcc -Wbad-function-cast warning.
1faed8ae 1562 (Fdefvar): Rename locals to avoid shadowing.
475545b5 1563
b1349114 1564 * callint.c (quotify_arg, quotify_args): Now static.
a3e8cbda 1565 (Fcall_interactively): Rename locals to avoid shadowing.
b0e80955 1566 Use const pointer when appropriate.
b1349114 1567
a2928364
PE
1568 * lisp.h (get_system_name, get_operating_system_release):
1569 Move decls here, to check interfaces.
1570 * process.c (get_operating_system_release): Move decl to lisp.h.
1571 * xrdb.c (get_system_name): Likewise.
63c5d10b
PE
1572 * editfns.c (init_editfns, Fuser_login_name, Fuser_uid):
1573 (Fuser_real_uid, Fuser_full_name): Remove unnecessary casts,
1574 some of which prompt warnings from gcc -Wbad-function-cast.
545b49b4
PE
1575 (Fformat_time_string, Fencode_time, Finsert_char):
1576 (Ftranslate_region_internal, Fformat):
1577 Rename or remove local vars to avoid shadowing.
9710023e 1578 (Ftranslate_region_internal): Mark var as initialized.
63c5d10b 1579
a415e694
PE
1580 * doc.c (Fdocumentation, Fsnarf_documentation): Move locals to
1581 avoid shadowing.
1582
8ef4622d
PE
1583 * lisp.h (eassert): Check that the argument compiles, even if
1584 ENABLE_CHECKING is not defined.
1585
946f9a5b
PE
1586 * data.c (Findirect_variable): Name an expression, to avoid
1587 gcc -Wbad-function-cast warning.
112396d6 1588 (default_value, arithcompare, arith_driver, arith_error): Now static.
b9b84fa9 1589 (store_symval_forwarding): Rename local to avoid shadowing.
44f230aa
SM
1590 (Fmake_variable_buffer_local, Fmake_local_variable):
1591 Mark variables as initialized.
52746918 1592 (do_blv_forwarding, do_symval_forwarding): Remove; unused.
946f9a5b 1593
e5aab7e7 1594 * alloc.c (check_cons_list): Do not define unless GC_CHECK_CONS_LIST.
ae35e756
PE
1595 (Fmake_vector, Fvector, Fmake_byte_code, Fgarbage_collect):
1596 Rename locals to avoid shadowing.
dff45157
PE
1597 (mark_stack): Move local variables into the #ifdef region where
1598 they're used.
7bc26fdb
PE
1599 (BLOCK_INPUT_ALLOC, UNBLOCK_INPUT_ALLOC): Define only if
1600 ! defined SYSTEM_MALLOC && ! defined SYNC_INPUT, as they are not
1601 needed otherwise.
1602 (CHECK_ALLOCATED): Define only if GC_CHECK_MARKED_OBJECTS.
1603 (GC_STRING_CHARS): Remove; not used.
d40d4be1 1604 (Fmemory_limit): Cast sbrk's returned value to char *.
ae35e756 1605
e5aab7e7
PE
1606 * lisp.h (check_cons_list): Declare if GC_CHECK_CONS_LIST; this
1607 avoids undefined behavior in theory.
1608
4da60324
PE
1609 * regex.c (IF_LINT): Add defn, for benefit of ../lib-src.
1610
88043301
PE
1611 Use functions, not macros, for up- and down-casing (Bug#8254).
1612 * buffer.h (DOWNCASE_TABLE, UPCASE_TABLE, DOWNCASE, UPPERCASEP):
1613 (NOCASEP, LOWERCASEP, UPCASE, UPCASE1): Remove. All callers changed
1614 to use the following functions instead of these macros.
1615 (downcase): Adjust to lack of DOWNCASE_TABLE. Return int, not
1616 EMACS_INT, since callers assume the returned value fits in int.
1617 (upcase1): Likewise, for UPCASE_TABLE.
1618 (uppercasep, lowercasep, upcase): New static inline functions.
0da09c43 1619 * editfns.c (Fchar_equal): Remove no-longer-needed workaround for
db69b0cd 1620 the race-condition problem in the old DOWNCASE.
88043301 1621
19ed5445
PE
1622 * regex.c (CHARSET_LOOKUP_RANGE_TABLE_RAW, POP_FAILURE_REG_OR_COUNT):
1623 Rename locals to avoid shadowing.
1624 (regex_compile, re_match_2_internal): Move locals to avoid shadowing.
abbd1bcf
PE
1625 (regex_compile, re_search_2, re_match_2_internal):
1626 Remove unused local vars.
952db0d7
PE
1627 (FREE_VAR): Rewrite so as not to use empty "else",
1628 which gcc can warn about.
da053e48 1629 (regex_compile, re_match_2_internal): Mark locals as initialized.
b313f9d8
PE
1630 (RETALLOC_IF): Define only if needed.
1631 (WORDCHAR_P): Likewise. This one is never needed, but is used
1632 only in a comment talking about a compiler bug, so put inside
1633 the #if 0 of that comment.
1634 (CHARSET_LOOKUP_BITMAP, FAIL_STACK_FULL, RESET_FAIL_STACK):
1635 (PUSH_FAILURE_ELT, BUF_PUSH_3, STOP_ADDR_VSTRING):
1636 Remove; unused.
19ed5445 1637
1f3561e4 1638 * search.c (boyer_moore): Rename locals to avoid shadowing.
76ef09b7
PE
1639 * character.h (FETCH_STRING_CHAR_AS_MULTIBYTE_ADVANCE):
1640 (PREV_CHAR_BOUNDARY): Likewise.
1f3561e4 1641
ded6f8f7
PE
1642 * search.c (simple_search): Remove unused var.
1643
dbd37a95
PE
1644 * dired.c (compile_pattern): Move decl from here ...
1645 * lisp.h: ... to here, so that it can be checked.
1646 (struct re_registers): New forward decl.
1647
7e47afad
PE
1648 * character.h (INC_POS, DEC_POS): Rename locals to avoid shadowing.
1649
85f24f61
PE
1650 * indent.c (MULTIBYTE_BYTES_WIDTH): New args bytes, width.
1651 All uses changed.
1652 (MULTIBYTE_BYTES_WIDTH, scan_for_column, compute_motion):
1653 Rename locals to avoid shadowing.
5671df8f 1654 (Fvertical_motion): Mark locals as initialized.
85f24f61 1655
181aa2be 1656 * casefiddle.c (casify_object, casify_region): Now static.
e45a141a 1657 (casify_region): Mark local as initialized.
181aa2be 1658
930d429c
PE
1659 * cmds.c (internal_self_insert): Rename local to avoid shadowing.
1660
7082eac6
PE
1661 * lisp.h (GCPRO2_VAR, GCPRO3_VAR, GCPRO4_VAR, GCPRO5_VAR, GCPRO6_VAR):
1662 New macros, so that the caller can use some names other than
1663 gcpro1, gcpro2, etc.
1664 (GCPRO2, GCPRO3, GCPRO4, GCPRO5, GCPRO6): Reimplement in terms
1665 of the new macros.
1666 (GCPRO1_VAR, UNGCPRO_VAR): Change the meaning of the second
1667 argument, for consistency with GCPRO2_VAR, etc: it is now the
1668 prefix of the variable, not the variable itself. All uses
1669 changed.
38b2c076
PE
1670 * dired.c (directory_files_internal, file_name_completion):
1671 Rename locals to avoid shadowing.
1672
15206ed9
PE
1673 Fix a race condition diagnosed by gcc -Wsequence-point (Bug#8254).
1674 An expression of the form (DOWNCASE (x) == DOWNCASE (y)), found in
1675 dired.c's scmp function, had undefined behavior.
1676 * lisp.h (DOWNCASE_TABLE, UPCASE_TABLE, DOWNCASE, UPPERCASEP):
1677 (NOCASEP, LOWERCASEP, UPCASE, UPCASE1): Move from here ...
1678 * buffer.h: ... to here, because these macros use current_buffer,
1679 and the new implementation with inline functions needs to have
1680 current_buffer in scope now, rather than later when the macros
1681 are used.
1682 (downcase, upcase1): New static inline functions.
1683 (DOWNCASE, UPCASE1): Reimplement using these functions.
1684 This avoids undefined behavior in expressions like
1685 DOWNCASE (x) == DOWNCASE (y), which previously suffered
1686 from race conditions in accessing the global variables
1687 case_temp1 and case_temp2.
1688 * casetab.c (case_temp1, case_temp2): Remove; no longer needed.
1689 * lisp.h (case_temp1, case_temp2): Remove their decls.
1690 * character.h (ASCII_CHAR_P): Move from here ...
1691 * lisp.h: ... to here, so that the inline functions mentioned
1692 above can use them.
1693
4a6bea26
PE
1694 * dired.c (directory_files_internal_unwind): Now static.
1695
f14b7e14
PE
1696 * fileio.c (file_name_as_directory, directory_file_name):
1697 (barf_or_query_if_file_exists, auto_save_error, auto_save_1):
1698 Now static.
2893f146
PE
1699 (file_name_as_directory): Use const pointers when appropriate.
1700 (Fexpand_file_name): Likewise. In particular, newdir might
1701 point at constant storage, so make it a const pointer.
fd4ead52 1702 (Fmake_directory_internal, Fread_file_name): Remove unused vars.
b14aac08
PE
1703 (Ffile_selinux_context, Fset_file_selinux_context): Fix pointer
1704 signedness issues.
f839df0c
PE
1705 (Fset_file_times, Finsert_file_contents, auto_save_error):
1706 Rename locals to avoid shadowing.
f14b7e14 1707
5716756e 1708 * minibuf.c (choose_minibuf_frame_1): Now static.
62137a95
PE
1709 (Ftry_completion, Fall_completions): Rename or remove locals
1710 to avoid shadowing.
5716756e 1711
b4c3046a
PE
1712 * marker.c (bytepos_to_charpos): Remove; unused.
1713
b45db522
PE
1714 * lisp.h (verify_bytepos, count_markers): New decls,
1715 so that gcc does not warn that these functions aren't declared.
1716
85876d07
PE
1717 * insdel.c (check_markers, make_gap_larger, make_gap_smaller):
1718 (reset_var_on_error, Fcombine_after_change_execute_1): Now static.
f0cb4a60 1719 (CHECK_MARKERS): Redo to avoid gcc -Wempty-body diagnostic.
40ef059e 1720 (copy_text): Remove unused local var.
85876d07 1721
03d78a21 1722 * filelock.c (within_one_second): Now static.
b3dd38ab 1723 (lock_file_1): Rename local to avoid shadowing.
03d78a21 1724
5df8f01b
PE
1725 * buffer.c (fix_overlays_before): Mark locals as initialized.
1726 (fix_start_end_in_overlays): Likewise. This function should be
1727 simplified by using pointers-to-pointers, but that's a different
1728 matter.
b1d876f1 1729 (switch_to_buffer_1): Now static.
8f54f30a
PE
1730 (Fkill_buffer, record_buffer, Fbury_buffer, Fset_buffer_multibyte):
1731 (report_overlay_modification): Rename locals to avoid shadowing.
c3bd59b5 1732
a70072c9 1733 * sysdep.c (system_process_attributes): Rename vars to avoid shadowing.
fbd02d7b 1734 Fix pointer signedness issue.
edced198
PE
1735 (sys_subshell): Mark local as volatile if checking for lint,
1736 to suppress a gcc -Wclobbered warning that does not seem to be right.
15dfd3d9 1737 (MAXPATHLEN): Define only if needed.
a70072c9 1738
a0977c44
PE
1739 * process.c (serial_open, serial_configure): Move decls from here ...
1740 * systty.h: ... to here, so that they can be checked.
1741
a884fdcc
PE
1742 * fns.c (get_random, seed_random): Move extern decls from here ...
1743 * lisp.h: ... to here, so that they can be checked.
1744
604efe86 1745 * sysdep.c (reset_io): Now static.
b8950c94 1746 (wait_for_termination_signal): Remove; unused.
604efe86 1747
38fc62d9
PE
1748 * keymap.c (keymap_parent, keymap_memberp, map_keymap_internal):
1749 (copy_keymap_item, append_key, push_text_char_description):
1750 Now static.
1004a21a 1751 (Fwhere_is_internal): Don't test CONSP (sequences) unnecessarily.
dbbb8427 1752 (DENSE_TABLE_SIZE): Remove; unused.
c1141155
PE
1753 (get_keymap, access_keymap, Fdefine_key, Fwhere_is_internal):
1754 (describe_map_tree):
1755 Rename locals to avoid shadowing.
38fc62d9 1756
2f2650da
PE
1757 * keyboard.c: Declare functions static if they are not used elsewhere.
1758 (echo_char, echo_dash, cmd_error, top_level_2):
1759 (poll_for_input, handle_async_input): Now static.
69a058fa
PE
1760 (read_char, kbd_buffer_get_event, make_lispy_position):
1761 (make_lispy_event, make_lispy_movement, apply_modifiers):
1762 (decode_keyboard_code, tty_read_avail_input, menu_bar_items):
1763 (parse_tool_bar_item, read_key_sequence, Fread_key_sequence):
1764 (Fread_key_sequence_vector): Rename locals to avoid shadowing.
c8a06054 1765 (read_key_sequence, read_char): Mark locals as initialized.
3ac94672 1766 (Fexit_recursive_edit, Fabort_recursive_edit): Mark with NO_RETURN.
2f2650da 1767
a053e86c 1768 * keyboard.h (make_ctrl_char): New decl.
da2f2dd9
PE
1769 (mark_kboards): Move decl here ...
1770 * alloc.c (mark_kboards): ... from here.
a053e86c 1771
4752793e
PE
1772 * lisp.h (force_auto_save_soon): New decl.
1773
74f10ca7 1774 * emacs.c (init_cmdargs): Rename local to avoid shadowing.
244fc23d
PE
1775 (DEFINE_DUMMY_FUNCTION): New macro.
1776 (__do_global_ctors, __do_global_ctors_aux, __do_global_dtors, __main):
1777 Use it.
c03cd23f
PE
1778 (main): Add casts to avoid warnings
1779 if GCC considers string literals to be constants.
74f10ca7 1780
022e70d4
PE
1781 * lisp.h (fatal_error_signal): Add decl, since it's exported.
1782
59d6fe83
PE
1783 * dbusbind.c: Pointer signedness fixes.
1784 (xd_signature, xd_append_arg, xd_initialize):
1785 (Fdbus_call_method, Fdbus_call_method_asynchronously):
1786 (Fdbus_method_return_internal, Fdbus_method_error_internal):
1787 (Fdbus_send_signal, xd_read_message_1, Fdbus_register_service):
1788 (Fdbus_register_signal): Use SSDATA when the context wants char *.
1789
78320123
PE
1790 * dbusbind.c (Fdbus_init_bus): Add cast to avoid warning
1791 if GCC considers string literals to be constants.
49cebcca 1792 (Fdbus_register_service, Fdbus_register_method): Remove unused vars.
78320123 1793
35ac2a97
SM
17942011-03-16 Stefan Monnier <monnier@iro.umontreal.ca>
1795
fb103ca9
SM
1796 * print.c (PRINT_CIRCLE_CANDIDATE_P): New macro.
1797 (print_preprocess, print_object): New macro to fix last change.
1798
35ac2a97
SM
1799 * print.c (print_preprocess): Don't forget font objects.
1800
62973b41
JB
18012011-03-16 Juanma Barranquero <lekktu@gmail.com>
1802
1803 * emacs.c (USAGE3): Doc fixes.
1804
0e48bb22
AS
18052011-03-15 Andreas Schwab <schwab@linux-m68k.org>
1806
1807 * coding.c (detect_coding_iso_2022): Reorganize code to clarify
1808 structure.
1809
7684e57b
JB
18102011-03-14 Juanma Barranquero <lekktu@gmail.com>
1811
1812 * lisp.h (VWindow_system, Qfile_name_history):
1813 * keyboard.h (lispy_function_keys) [WINDOWSNT]:
1814 * w32term.h (w32_system_caret_hwnd, w32_system_caret_height)
1815 (w32_system_caret_x, w32_system_caret_y): Declare extern.
1816
1817 * w32select.c: Don't #include "keyboard.h".
c96bbc66 1818 (run_protected): Add extern declaration for waiting_for_input.
7684e57b
JB
1819
1820 * w32.c (Qlocal, noninteractive1, inhibit_window_system):
1821 * w32console.c (detect_input_pending, read_input_pending)
1822 (encode_terminal_code):
1823 * w32fns.c (quit_char, lispy_function_keys, Qtooltip)
1824 (w32_system_caret_hwnd, w32_system_caret_height, w32_system_caret_x)
1825 (w32_system_caret_y, Qfile_name_history):
1826 * w32font.c (w32font_driver, QCantialias, QCotf, QClang):
1827 * w32inevt.c (reinvoke_input_signal, lispy_function_keys):
1828 * w32menu.c (Qmenu_bar, QCtoggle, QCradio, Qoverriding_local_map)
1829 (Qoverriding_terminal_local_map, Qmenu_bar_update_hook):
1830 * w32proc.c (Qlocal, report_file_error):
1831 * w32term.c (Vwindow_system, updating_frame):
1832 * w32uniscribe.c (initialized, uniscribe_font_driver):
1833 Remove unneeded extern declarations.
1834
2aa46d6c
CY
18352011-03-14 Chong Yidong <cyd@stupidchicken.com>
1836
c96bbc66 1837 * buffer.c (Fmake_indirect_buffer): Fix incorrect assertions.
2aa46d6c 1838
cffc6f3b
CY
18392011-03-13 Chong Yidong <cyd@stupidchicken.com>
1840
1841 * buffer.h (BUF_BEGV, BUF_BEGV_BYTE, BUF_ZV, BUF_ZV_BYTE, BUF_PT)
1842 (BUF_PT_BYTE): Rewrite to handle indirect buffers (Bug#8219).
1843 These macros can no longer be used for assignment.
1844
44f230aa
SM
1845 * buffer.c (Fget_buffer_create, Fmake_indirect_buffer):
1846 Assign struct members directly, instead of using BUF_BEGV etc.
cffc6f3b
CY
1847 (record_buffer_markers, fetch_buffer_markers): New functions for
1848 recording and fetching special buffer markers.
1849 (set_buffer_internal_1, set_buffer_temp): Use them.
1850
1851 * lread.c (unreadchar): Use SET_BUF_PT_BOTH.
1852
1853 * insdel.c (adjust_point): Use SET_BUF_PT_BOTH.
1854
1855 * intervals.c (temp_set_point_both): Use SET_BUF_PT_BOTH.
1856 (get_local_map): Use SET_BUF_BEGV_BOTH and SET_BUF_ZV_BOTH.
1857
1858 * xdisp.c (hscroll_window_tree):
1859 (reconsider_clip_changes): Use PT instead of BUF_PT.
1860
d251f04b
EZ
18612011-03-13 Eli Zaretskii <eliz@gnu.org>
1862
1863 * makefile.w32-in ($(BLD)/editfns.$(O)): Depend on
1864 $(EMACS_ROOT)/lib/intprops.h.
1865
f0c77cd1
PE
18662011-03-13 Paul Eggert <eggert@cs.ucla.edu>
1867
3eca4629
PE
1868 Fix more problems found by GCC 4.5.2's static checks.
1869
7c86ee98
PE
1870 * gtkutil.c (xg_get_pixbuf_from_pixmap): Add cast from char *
1871 to unsigned char * to avoid compiler diagnostic.
b0afc268
PE
1872 (xg_free_frame_widgets): Make it clear that a local variable is
1873 needed only if USE_GTK_TOOLTIP.
01e0b5ad
PE
1874 (gdk_window_get_screen): Make it clear that this macro is needed
1875 only if USE_GTK_TOOLTIP.
1e5524e7
PE
1876 (int_gtk_range_get_value): New function, which avoids a diagnostic
1877 from gcc -Wbad-function-cast.
1878 (xg_set_toolkit_scroll_bar_thumb): Use it.
1879 (xg_tool_bar_callback, xg_tool_item_stale_p): Rewrite to avoid
1880 diagnostic from gcc -Wbad-function-cast.
65dc836c
PE
1881 (get_utf8_string, xg_get_file_with_chooser):
1882 Rename locals to avoid shadowing.
1883 (create_dialog): Move locals to avoid shadowing.
7c86ee98 1884
41729b81
PE
1885 * xgselect.c (xg_select): Remove unused var.
1886
f0c77cd1
PE
1887 * image.c (four_corners_best): Mark locals as initialized.
1888 (gif_load): Initialize transparent_p to zero (Bug#8238).
1889 Mark another local as initialized.
ec6cf4c6 1890 (my_png_error, my_error_exit): Mark with NO_RETURN.
f0c77cd1 1891
ce0ad53d 1892 * image.c (clear_image_cache): Now static.
d5d5a617 1893 (DIM, HAVE_STDLIB_H_1): Remove unused macros.
e22cffbc 1894 (xpm_load): Redo to avoid "discards qualifiers" gcc warning.
77a765fd
PE
1895 (x_edge_detection): Remove unnecessary cast that
1896 gcc -Wbad-function-cast diagnoses.
2037898d 1897 (gif_load): Fix pointer signedness.
6ae141d6
PE
1898 (clear_image_cache, xbm_read_bitmap_data, x_detect_edges):
1899 (jpeg_load, gif_load): Rename locals to avoid shadowing.
ce0ad53d 1900
33383987 19012011-03-12 Paul Eggert <eggert@cs.ucla.edu>
3eca4629 1902
d32df629
PE
1903 Improve quality of tests for time stamp overflow.
1904 For example, without this patch (encode-time 0 0 0 1 1
1905 1152921504606846976) returns the obviously-bogus value (-948597
1906 62170) on my RHEL 5.5 x86-64 host. With the patch, it correctly
1907 reports time overflow. See
1908 <http://lists.gnu.org/archive/html/emacs-devel/2011-03/msg00470.html>.
b8d9bd41
PE
1909 * deps.mk (editfns.o): Depend on ../lib/intprops.h.
1910 * editfns.c: Include limits.h and intprops.h.
1911 (TIME_T_MIN, TIME_T_MAX): New macros.
1912 (time_overflow): Move earlier, to before first use.
1913 (hi_time, lo_time): New functions, for an accurate test for
1914 out-of-range times.
1915 (Fcurrent_time, Fget_internal_run_time, make_time): Use them.
1916 (Fget_internal_run_time): Don't assume time_t fits in int.
1917 (make_time): Use list2 instead of Fcons twice.
1918 (Fdecode_time): More accurate test for out-of-range times.
1919 (check_tm_member): New function.
1920 (Fencode_time): Use it, to test for out-of-range times.
d32df629
PE
1921 (lisp_time_argument): Don't rely on undefined left-shift and
1922 right-shift behavior when checking for time stamp overflow.
8be6f318 1923
fe31d94c
PE
1924 * editfns.c (time_overflow): New function, refactoring common code.
1925 (Fformat_time_string, Fdecode_time, Fencode_time):
1926 (Fcurrent_time_string): Use it.
1927
8be6f318
PE
1928 Move 'make_time' to be next to its inverse 'lisp_time_argument'.
1929 * dired.c (make_time): Move to ...
1930 * editfns.c (make_time): ... here.
1931 * systime.h: Note the move.
1932
09d9db2c 19332011-03-12 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
c47cbdfd 1934
126bc0dc
YM
1935 * fringe.c (update_window_fringes): Remove unused variables.
1936
c47cbdfd
YM
1937 * unexmacosx.c (copy_data_segment): Also copy __got section.
1938 (Bug#8223)
1939
7ac80be9
EZ
19402011-03-12 Eli Zaretskii <eliz@gnu.org>
1941
c96bbc66 1942 * termcap.c [MSDOS]: Include "msdos.h".
058e5dad
EZ
1943 (find_capability, tgetnum, tgetflag, tgetstr, tputs, tgetent):
1944 Constify `char *' arguments and their references according to
1945 prototypes in tparam.h.
1946
ecb0f94d 1947 * deps.mk (termcap.o): Depend on tparam.h and msdos.h.
058e5dad 1948
7ac80be9
EZ
1949 * msdos.c (XMenuAddPane): 3rd argument is `const char *' now.
1950 Adapt all references accordingly.
1951
1952 * msdos.h (XMenuAddPane): 3rd argument is `const char *' now.
1953
ef1fd07e
TT
19542011-03-11 Tom Tromey <tromey@redhat.com>
1955
1956 * buffer.c (syms_of_buffer): Remove obsolete comment.
1957
7ef4b50c
EZ
19582011-03-11 Eli Zaretskii <eliz@gnu.org>
1959
1960 * termhooks.h (encode_terminal_code): Declare prototype.
1961
1962 * msdos.c (encode_terminal_code): Don't declare prototype.
1963
1964 * term.c (encode_terminal_code): Now external again, used by
1965 w32console.c and msdos.c.
1966
44f230aa
SM
1967 * makefile.w32-in ($(BLD)/term.$(O), ($(BLD)/tparam.$(O)):
1968 Depend on $(SRC)/tparam.h, see 2011-03-11T07:24:21Z!eggert@cs.ucla.edu.
7ef4b50c 1969
4b1ec863 19702011-03-11 Paul Eggert <eggert@cs.ucla.edu>
f78faa98 1971
1714f52b 1972 Fix some minor problems found by GCC 4.5.2's static checks.
83316bf4 1973
4b1ec863
PE
1974 * fringe.c (update_window_fringes): Mark locals as initialized
1975 (Bug#8227).
1976 (destroy_fringe_bitmap, init_fringe_bitmap): Now static.
bf60f616 1977
524c7aa6
PE
1978 * alloc.c (mark_fringe_data): Move decl from here ...
1979 * lisp.h (mark_fringe_data) [HAVE_WINDOW_SYSTEM]: ... to here,
1980 to check its interface.
1981 (init_fringe_once): Do not declare unless HAVE_WINDOW_SYSTEM.
1982
a5c0af81 1983 * fontset.c (free_realized_fontset): Now static.
7519b8cd 1984 (Fset_fontset_font): Rename local to avoid shadowing.
cc6e5db1 1985 (fontset_font): Mark local as initialized.
a9a06e0b 1986 (FONTSET_SPEC, FONTSET_REPERTORY, RFONT_DEF_REPERTORY): Remove; unused.
a5c0af81 1987
b4716021
PE
1988 * xrdb.c: Include "xterm.h", to check x_load_resources's interface.
1989
811e9bac 1990 * xselect.c (x_disown_buffer_selections): Remove; not used.
7b83e2f1 1991 (TRACE3) [!defined TRACE_SELECTION]: Remove; not used.
aa0daa9f
PE
1992 (x_own_selection, Fx_disown_selection_internal): Rename locals
1993 to avoid shadowing.
1994 (x_handle_dnd_message): Remove local to avoid shadowing.
811e9bac 1995
7e3ab302
PE
1996 * lisp.h (GCPRO1_VAR, UNGCPRO_VAR): New macros,
1997 so that the caller can use some name other than gcpro1.
1998 (GCPRO1, UNGCPRO): Reimplement in terms of the new macros.
58d2d479
PE
1999 * xfns.c (Fx_create_frame, x_create_tip_frame, Fx_show_tip):
2000 (Fx_backspace_delete_keys_p):
2001 Use them to avoid shadowing, and rename vars to avoid shadowing.
2002 (x_decode_color, x_set_name, x_window): Now static.
6b437900 2003 (Fx_create_frame): Add braces to silence GCC warning.
c0951e53 2004 (Fx_file_dialog, Fx_select_font): Fix pointer signedness.
06b0c8a0
PE
2005 (x_real_positions, xg_set_icon_from_xpm_data, x_create_tip_frame):
2006 Remove unused locals.
7e3ab302
PE
2007 (Fx_create_frame, x_create_tip_frame, Fx_show_tip):
2008 (Fx_backspace_delete_keys_p): Rename locals to avoid shadowing.
2009 Some of these renamings use the new GCPRO1_VAR and UNGCPRO_VAR
2010 macros.
f78faa98 2011
e2b13473
PE
2012 * xterm.h (x_mouse_leave): New decl.
2013
77f23912
PE
2014 * xterm.c (x_copy_dpy_color, x_focus_on_frame, x_unfocus_frame):
2015 Remove unused functions.
cdf4ba58
PE
2016 (x_shift_glyphs_for_insert, XTflash, XTring_bell):
2017 (x_calc_absolute_position): Now static.
7411c686 2018 (XTread_socket): Don't define label "out" unless it's used.
2b07bcff 2019 Don't declare local "event" unless it's used.
ed7bf3a5
PE
2020 (x_iconify_frame, x_free_frame_resources): Don't declare locals
2021 unless they are used.
38d0b34a
PE
2022 (XEMBED_VERSION, xembed_set_info): Don't define unless needed.
2023 (x_fatal_error_signal): Remove; not used.
a6067996
PE
2024 (x_draw_image_foreground, redo_mouse_highlight, XTmouse_position):
2025 (x_scroll_bar_report_motion, handle_one_xevent, x_draw_bar_cursor):
2026 (x_error_catcher, x_connection_closed, x_error_handler):
2027 (x_error_quitter, xembed_send_message, x_iconify_frame):
2028 (my_log_handler): Rename locals to avoid shadowing.
28f1c698 2029 (x_delete_glyphs, x_ins_del_lines): Mark with NO_RETURN.
2a8fade0 2030 (x_connection_closed): Tell GCC not to suggest NO_RETURN.
77f23912 2031
44f230aa
SM
2032 * xfaces.c (clear_face_cache, Fx_list_fonts, Fface_font):
2033 Rename or move locals to avoid shadowing.
6b463e58 2034 (tty_defined_color, merge_face_heights): Now static.
5967d051 2035 (free_realized_faces_for_fontset): Remove; not used.
1e9966ea
PE
2036 (Fx_list_fonts): Mark variable that gcc -Wuninitialized
2037 does not deduce is never used uninitialized.
73719eba
PE
2038 (STRDUPA, LSTRDUPA, FONT_POINT_SIZE_QUANTUM): Remove; not used.
2039 (LFACEP): Define only if XASSERTS, as it's not needed otherwise.
071048a3 2040
426994c3 2041 * terminal.c (store_terminal_param): Now static.
5489860b 2042
032f1620 2043 * xmenu.c (menu_highlight_callback): Now static.
9d66f88e 2044 (set_frame_menubar): Remove unused local.
d4323972 2045 (xmenu_show): Rename parameter to avoid shadowing.
6d1f7fee
PE
2046 (xmenu_show, xdialog_show, xmenu_show): Make local pointers "const"
2047 since they might point to immutable storage.
281585b0
PE
2048 (next_menubar_widget_id): Declare only if USE_X_TOOLKIT,
2049 since it's unused otherwise.
032f1620 2050
367c19e5 2051 * xdisp.c (produce_glyphless_glyph): Initialize lower_xoff.
53df7c11 2052 Add a FIXME, since the code still doesn't look right. (Bug#8215)
9f36b9fd
PE
2053 (Fcurrent_bidi_paragraph_direction): Simplify slightly; this
2054 avoids a gcc -Wuninitialized diagnostic.
0e086e8f 2055 (display_line, BUILD_COMPOSITE_GLYPH_STRING, draw_glyphs):
44a3a108
PE
2056 (note_mouse_highlight): Mark variables that gcc -Wuninitialized
2057 does not deduce are never used uninitialized.
70739cbe 2058
07b48fa9
PE
2059 * lisp.h (IF_LINT): New macro, copied from ../lib-src/emacsclient.c.
2060
8868a238 2061 * xdisp.c (redisplay_window): Rename local to avoid shadowing.
4554d213
PE
2062 * window.c (window_loop, size_window):
2063 (run_window_configuration_change_hook, enlarge_window): Likewise.
8868a238 2064
7e5cf297 2065 * window.c (display_buffer): Now static.
d6550a9f
PE
2066 (size_window): Mark variables that gcc -Wuninitialized
2067 does not deduce are never used uninitialized.
a586633d
PE
2068 * window.h (check_all_windows): New decl, to forestall
2069 gcc -Wmissing-prototypes diagnostic.
5b555da1 2070 * dispextern.h (bidi_dump_cached_states): Likewise.
7e5cf297 2071
f6095868
PE
2072 * charset.h (CHECK_CHARSET_GET_CHARSET): Rename locals to avoid
2073 shadowing.
2074 * charset.c (map_charset_for_dump, Fchar_charset): Likewise.
726929c4
PE
2075 Include <limits.h>.
2076 (Fsort_charsets): Redo min/max calculation to shorten the code a bit
2077 and to avoid gcc -Wuninitialized warning.
89ef49df
PE
2078 (load_charset_map): Mark variables that gcc -Wuninitialized
2079 does not deduce are never used uninitialized.
53df7c11 2080 (load_charset): Abort instead of using uninitialized var (Bug#8229).
f6095868 2081
f38b440c
PE
2082 * coding.c (coding_set_source, coding_set_destination):
2083 Use "else { /* comment */ }" rather than "else /* comment */;"
2084 for clarity, and to avoid gcc -Wempty-body warning.
2735d060
PE
2085 (Fdefine_coding_system_internal): Don't redeclare 'i' inside
2086 a block, when the outer 'i' will do.
2087 (decode_coding_utf_8, decode_coding_utf_16, detect_coding_emacs_mule):
2088 (emacs_mule_char, decode_coding_emacs_mule, detect_coding_iso_2022):
2089 (decode_coding_iso_2022, decode_coding_sjis, decode_coding_big5):
2090 (decode_coding_raw_text, decode_coding_charset, get_translation_table):
2091 (Fdecode_sjis_char, Fdefine_coding_system_internal):
2092 Rename locals to avoid shadowing.
2093 * character.h (FETCH_STRING_CHAR_ADVANCE): Likewise.
e2f1bab9
PE
2094 * coding.c (emacs_mule_char, encode_invocation_designation):
2095 Now static, since they're not used elsewhere.
413bb2db 2096 (decode_coding_iso_2022): Add "default: abort ();" as a safety check.
c4a63b12 2097 (decode_coding_object, encode_coding_object, detect_coding_system):
ee05f961
PE
2098 (decode_coding_emacs_mule): Mark variables that gcc
2099 -Wuninitialized does not deduce are never used uninitialized.
160b01f6
PE
2100 (detect_coding_iso_2022): Initialize a local variable that might
2101 be used uninitialized. Leave a FIXME because it's not clear that
53df7c11 2102 this initialization is needed. (Bug#8211)
5f58e762
PE
2103 (ISO_CODE_LF, ISO_CODE_CR, CODING_ISO_FLAG_EUC_TW_SHIFT):
2104 (ONE_MORE_BYTE_NO_CHECK, UTF_BOM, UTF_16_INVALID_P):
2105 (SHIFT_OUT_OK, ENCODE_CONTROL_SEQUENCE_INTRODUCER):
2106 (ENCODE_DIRECTION_R2L, ENCODE_DIRECTION_L2R):
2107 Remove unused macros.
f38b440c 2108
232b38b9 2109 * category.c (hash_get_category_set): Remove unused local var.
9f3b5e69 2110 (copy_category_table): Now static, since it's not used elsewhere.
d0891610 2111 * character.c (string_count_byte8): Likewise.
232b38b9 2112
fb90da1b
PE
2113 * ccl.c (CCL_WRITE_STRING, CCL_ENCODE_CHAR, Fccl_execute_on_string):
2114 (Fregister_code_conversion_map): Rename locals to avoid shadowing.
2115
fb93dbc2
PE
2116 * chartab.c (copy_sub_char_table): Now static, since it's not used
2117 elsewhere.
5c156ace
PE
2118 (sub_char_table_ref_and_range, char_table_ref_and_range):
2119 Rename locals to avoid shadowing.
bbcd0949 2120 (ASET_RANGE, GET_SUB_CHAR_TABLE): Remove unused macros.
fb93dbc2 2121
7d3b3862 2122 * bidi.c (bidi_check_type): Now static, since it's not used elsewhere.
630d6892 2123 (BIDI_BOB): Remove unused macro.
7d3b3862 2124
6be7d3da
PE
2125 * cm.c (cmgoto): Mark variables that gcc -Wuninitialized does not
2126 deduce are never used uninitialized.
c2ed9c8b 2127 * term.c (encode_terminal_code): Likewise.
6be7d3da 2128
75f8807f 2129 * term.c (encode_terminal_code): Now static. Remove unused local.
72abad34 2130
50938595
PE
2131 * tparam.h: New file.
2132 * term.c, tparam.h: Include it.
2133 * deps.mk (term.o, tparam.o): Depend on tparam.h.
2134 * term.c (tputs, tgetent, tgetflag, tgetnum, tparam, tgetstr):
2135 Move these decls to tparam.h, and make them agree with what
2136 is actually in tparam.c. The previous trick of using incompatible
2137 decls in different modules does not conform to the C standard.
2138 All callers of tparam changed to use tparam's actual API.
2139 * tparam.c (tparam1, tparam, tgoto):
2140 Use const pointers where appropriate.
2141
fbceeba2
PE
2142 * cm.c (calccost, cmgoto): Use const pointers where appropriate.
2143 * cm.h (struct cm): Likewise.
2144 * dispextern.h (do_line_insertion_deletion_costs): Likewise.
2145 * scroll.c (ins_del_costs, do_line_insertion_deletion_costs): Likewise.
2146 * term.c (tty_ins_del_lines, calculate_costs, struct fkey_table):
2147 (term_get_fkeys_1, append_glyphless_glyph, produce_glyphless_glyph):
2148 (turn_on_face, init_tty): Likewise.
2149 * termchar.h (struct tty_display_info): Likewise.
fbceeba2 2150
7f3f1250
PE
2151 * term.c (term_mouse_position): Rename local to avoid shadowing.
2152
e6ca6543
PE
2153 * alloc.c (mark_ttys): Move decl from here ...
2154 * lisp.h (mark_ttys): ... to here, so that it's checked against defn.
2155
c40f8d15
AS
21562011-03-11 Andreas Schwab <schwab@linux-m68k.org>
2157
2158 * .gdbinit (pwinx, xbuffer): Fix access to buffer name.
2159
cfe0661d
JB
21602011-03-09 Juanma Barranquero <lekktu@gmail.com>
2161
2162 * search.c (compile_pattern_1): Remove argument regp, unused since
2163 revid:rms@gnu.org-19941211082627-3x1g1wyqkjmwloig.
2164 (compile_pattern): Don't pass it.
2165
0afb4571
J
21662011-03-08 Jan Djärv <jan.h.d@swipnet.se>
2167
2168 * xterm.h (DEFAULT_GDK_DISPLAY): New define.
2169 (GDK_WINDOW_XID, gtk_widget_get_preferred_size): New defines
2170 for ! HAVE_GTK3.
2171 (GTK_WIDGET_TO_X_WIN): Use GDK_WINDOW_XID.
2172
2173 * xmenu.c (menu_position_func): Call gtk_widget_get_preferred_size.
2174
2175 * gtkutil.c: Include gtkx.h if HAVE_GTK3. If ! HAVE_GTK3, define
2176 gdk_window_get_screen, gdk_window_get_geometry,
2177 gdk_x11_window_lookup_for_display and GDK_KEY_g.
2178 (xg_set_screen): Use DEFAULT_GDK_DISPLAY.
2179 (xg_get_pixbuf_from_pixmap): New function.
2180 (xg_get_pixbuf_from_pix_and_mask): Change parameters from GdkPixmap
2181 to Pixmap, take frame as parameter, remove GdkColormap parameter.
2182 Call xg_get_pixbuf_from_pixmap instead of
2183 gdk_pixbuf_get_from_drawable.
2184 (xg_get_image_for_pixmap): Do not make GdkPixmaps, call
2185 xg_get_pixbuf_from_pix_and_mask with Pixmap parameters instead.
2186 (xg_check_special_colors): Use GtkStyleContext and its functions
2187 for HAVE_GTK3.
2188 (xg_prepare_tooltip, xg_hide_tooltip): Call gdk_window_get_screen.
2189 (xg_prepare_tooltip, create_dialog, menubar_map_cb)
2190 (xg_update_frame_menubar, xg_tool_bar_detach_callback)
44f230aa
SM
2191 (xg_tool_bar_attach_callback, xg_update_tool_bar_sizes):
2192 Call gtk_widget_get_preferred_size.
0afb4571
J
2193 (xg_frame_resized): gdk_window_get_geometry only takes 5
2194 parameters.
44f230aa
SM
2195 (xg_win_to_widget, xg_event_is_for_menubar):
2196 Call gdk_x11_window_lookup_for_display.
0afb4571
J
2197 (xg_set_widget_bg): New function.
2198 (delete_cb): New function.
2199 (xg_create_frame_widgets): connect delete-event to delete_cb.
2200 Call xg_set_widget_bg. Only set backgrund pixmap for ! HAVE_GTK3
2201 (xg_set_background_color): Call xg_set_widget_bg.
2202 (xg_set_frame_icon): Call xg_get_pixbuf_from_pix_and_mask.
2203 (xg_create_scroll_bar): vadj is a GtkAdjustment for HAVE_GTK3.
2204 Only call gtk_range_set_update_policy if ! HAVE_GTK3.
2205 (xg_make_tool_item): Only connect xg_tool_bar_item_expose_callback
2206 if ! HAVE_GTK3.
2207 (update_frame_tool_bar): Call gtk_widget_hide.
2208 (xg_initialize): Use GDK_KEY_g.
2209
2210 * xsmfns.c (gdk_set_sm_client_id): Define to gdk_set_sm_client_id
2211 if ! HAVE_GTK3
2212 (x_session_initialize): Call gdk_x11_set_sm_client_id.
2213
2214 * xterm.c (XFillRectangle): Use cairo routines for HAVE_GTK3.
2215 (x_term_init): Disable Xinput(2) with GDK_CORE_DEVICE_EVENTS.
2216 Load ~/emacs.d/gtkrc only for ! HAVE_GTK3.
2217
1c2cc4ef
JB
22182011-03-08 Juanma Barranquero <lekktu@gmail.com>
2219
2220 * w32xfns.c (select_palette): Check success of RealizePalette against
2221 GDI_ERROR, not zero.
2222
33383987 2223See ChangeLog.11 for earlier changes.
aac0c6e3
MR
2224
2225;; Local Variables:
2226;; coding: utf-8
aac0c6e3
MR
2227;; End:
2228
33383987 2229 Copyright (C) 2011 Free Software Foundation, Inc.
aac0c6e3
MR
2230
2231 This file is part of GNU Emacs.
2232
2233 GNU Emacs is free software: you can redistribute it and/or modify
2234 it under the terms of the GNU General Public License as published by
2235 the Free Software Foundation, either version 3 of the License, or
2236 (at your option) any later version.
2237
2238 GNU Emacs is distributed in the hope that it will be useful,
2239 but WITHOUT ANY WARRANTY; without even the implied warranty of
2240 MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
2241 GNU General Public License for more details.
2242
2243 You should have received a copy of the GNU General Public License
2244 along with GNU Emacs. If not, see <http://www.gnu.org/licenses/>.