Document toolkit differences for menus
[bpt/emacs.git] / src / ChangeLog
CommitLineData
87e86684
LM
12011-07-09 Lawrence Mitchell <wence@gmx.li>
2
3 * gnutls.c (Qgnutls_bootprop_min_prime_bits): New variable.
4 (Fgnutls_boot): Use it.
5
64348f40
AS
62011-07-15 Andreas Schwab <schwab@linux-m68k.org>
7
8 * doc.c (Fsubstitute_command_keys): Revert last change.
9
1d698799
LMI
102011-07-15 Lars Magne Ingebrigtsen <larsi@gnus.org>
11
f863868c
LMI
12 * doc.c (Fsubstitute_command_keys): Clarify that \= really only
13 quotes the next character, and doesn't affect other longer
14 sequences (bug#8935).
15
1d698799
LMI
16 * lread.c (syms_of_lread): Clarify that is isn't only
17 `eval-buffer' and `eval-defun' that's affected by
18 `lexical-binding' (bug#8460).
19
aa4b6df6
EZ
202011-07-15 Eli Zaretskii <eliz@gnu.org>
21
22 * xdisp.c (move_it_in_display_line_to): Fix vertical motion with
23 bidi redisplay when a line includes both an image and is
24 truncated.
25
5d856da6
PE
262011-07-14 Paul Eggert <eggert@cs.ucla.edu>
27
ad6042bb
PE
28 Fix minor problems found by static checking.
29 * bidi.c (bidi_cache_size): Now EMACS_INT, not size_t.
30 (elsz): Now a signed constant, not a size_t var. We prefer signed
31 types to unsigned, to avoid integer comparison confusion. Without
32 this change, GCC 4.6.1 with -Wunsafe-loop-optimizations complains
33 "cannot optimize loop, the loop counter may overflow", a symptom
34 of the confusion.
f00bbb22 35 * indent.c (Fvertical_motion): Mark locals as initialized.
5d856da6
PE
36 * xdisp.c (reseat_to_string): Fix pointer signedness issue.
37
6468f31c
LMI
382011-07-14 Lars Magne Ingebrigtsen <larsi@gnus.org>
39
49080b10
LMI
40 * search.c (Fre_search_backward): Mention `case-fold-search' in
41 all the re_search_* functions (bug#8138).
42
6468f31c
LMI
43 * keyboard.c (Fopen_dribble_file): Document when the file is
44 closed (bug#8056).
45
c965adc5
EZ
462011-07-14 Eli Zaretskii <eliz@gnu.org>
47
df9733bf
EZ
48 * bidi.c (bidi_dump_cached_states): Fix format of displaying
49 bidi_cache_idx.
50
0bb23927
EZ
51 Support bidi reordering of display and overlay strings.
52 * xdisp.c (compute_display_string_pos)
53 (compute_display_string_end): Accept additional argument STRING.
54 (init_iterator, reseat_1): Initialize bidi_it->string.s to NULL.
55 (reseat_to_string): Initialize bidi_it->string.s and
56 bidi_it->string.schars.
57 (Fcurrent_bidi_paragraph_direction): Initialize itb.string.s to
58 NULL (avoids a crash in bidi_paragraph_init). Initialize
59 itb.string.lstring.
60 (init_iterator): Call bidi_init_it only of a valid
61 buffer position was specified. Initialize paragraph_embedding to
62 L2R.
63 (reseat_to_string): Initialize the bidi iterator.
64 (display_string): If we need to ignore text properties of
65 LISP_STRING, set IT->stop_charpos to IT->end_charpos. (The
66 original value of -1 will not work with bidi.)
67 (compute_display_string_pos): First arg is now struct
68 `text_pos *'; all callers changed. Support display properties on
69 Lisp strings.
70 (compute_display_string_end): Support display properties on Lisp
71 strings.
72 (init_iterator, reseat_1, reseat_to_string): Initialize the
73 string.bufpos member to 0 (zero, for compatibility with IT_CHARPOS
74 when iterating on a string not from display properties).
75 (compute_display_string_pos, compute_display_string_end): Fix
76 calculation of the object to scan. Fixes an error when using
77 arrow keys.
78 (next_element_from_buffer): Don't abort when IT_CHARPOS is before
79 base_level_stop; instead, set base_level_stop to BEGV. Fixes
80 crashes in vertical-motion.
81 (next_element_from_buffer): Improve commentary for when
82 the iterator is before prev_stop.
83 (init_iterator): Initialize bidi_p from the default value of
84 bidi-display-reordering, not from buffer-local value. Use the
85 buffer-local value only if initializing for buffer iteration.
86 (handle_invisible_prop): Support invisible properties on strings
87 that are being bidi-reordered.
88 (set_iterator_to_next): Support bidi reordering of C strings and
89 Lisp strings.
90 (next_element_from_string): Support bidi reordering of Lisp
91 strings.
92 (handle_stop_backwards): Support Lisp strings as well.
93 (display_string): Support display of R2L glyph rows. Use
94 IT_STRING_CHARPOS when displaying from a Lisp string.
95 (init_iterator): Don't initialize it->bidi_p for strings
96 here.
97 (reseat_to_string): Initialize it->bidi_p for strings here.
98 (next_element_from_string, next_element_from_c_string)
99 (next_element_from_buffer): Add xassert's for correspondence
100 between IT's object being iterated and it->bidi_it.string
101 structure.
102 (face_before_or_after_it_pos): Support bidi iteration.
103 (next_element_from_c_string): Handle the case of the first string
104 character that is not the first one in the visual order.
105 (get_visually_first_element): New function, refactored from common
106 parts of next_element_from_buffer, next_element_from_string, and
107 next_element_from_c_string.
108 (tool_bar_lines_needed, redisplay_tool_bar)
109 (display_menu_bar): Force left-to-right direction. Add a FIXME
110 comment for making that be controlled by a user option.
111 (push_it, pop_it): Save and restore the state of the
112 bidi iterator. Save and restore the bidi_p flag.
113 (pop_it): Iterate out of display property for string iteration as
114 well.
115 (iterate_out_of_display_property): Support iteration over strings.
116 (handle_single_display_spec): Set up it->bidi_it for iteration
117 over a display string, and call bidi_init_it.
118 (handle_single_display_spec, next_overlay_string)
119 (get_overlay_strings_1, push_display_prop): Set up the bidi
120 iterator for displaying display or overlay strings.
121 (forward_to_next_line_start): Don't use the shortcut if
122 bidi-iterating.
123 (back_to_previous_visible_line_start): If handle_display_prop
124 pushed the iterator stack, restore the internal state of the bidi
125 iterator by calling bidi_pop_it same number of times.
126 (reseat_at_next_visible_line_start): If ON_NEWLINE_P is non-zero,
127 and we are bidi-iterating, don't decrement the iterator position;
128 instead, set the first_elt flag in the bidi iterator, to produce
129 the same effect.
130 (reseat_1): Remove redundant setting of string_from_display_prop_p.
131 (push_display_prop): xassert that we are iterating a buffer.
132 (push_it, pop_it): Save and restore paragraph_embedding member.
133 (handle_single_display_spec, next_overlay_string)
134 (get_overlay_strings_1, reseat_1, reseat_to_string)
135 (push_display_prop): Set up the `unibyte' member of bidi_it.string
136 correctly. Don't assume unibyte strings are not bidi-reordered.
137 (compute_display_string_pos)
138 (compute_display_string_end): Fix handling the case of C string.
139 (push_it, pop_it): Save and restore from_disp_prop_p.
140 (handle_single_display_spec, push_display_prop): Set the
141 from_disp_prop_p flag.
142 (get_overlay_strings_1): Reset the from_disp_prop_p flag.
143 (pop_it): Call iterate_out_of_display_property only if we are
144 popping after iteration over a string that came from a display
145 property. Fix a typo in popping stretch info. Add an assertion
146 for verifying that the iterator position is in sync with the bidi
147 iterator.
148 (handle_single_display_spec, get_overlay_strings_1)
149 (push_display_prop): Fix initialization of paragraph direction for
150 string when that of the parent object is not yet determined.
151 (reseat_1): Call bidi_init_it to resync the bidi
152 iterator with IT's position. (Bug#7616)
153 (find_row_edges): If ROW->start.pos gives position
154 smaller than min_pos, use it as ROW->minpos. (Bug#7616)
155 (handle_stop, back_to_previous_visible_line_start, reseat_1):
156 Reset the from_disp_prop_p flag.
157 (SAVE_IT, RESTORE_IT): New macros.
158 (pos_visible_p, face_before_or_after_it_pos)
159 (back_to_previous_visible_line_start)
160 (move_it_in_display_line_to, move_it_in_display_line)
161 (move_it_to, move_it_vertically_backward, move_it_by_lines)
162 (try_scrolling, redisplay_window, display_line): Use them when
163 saving a temporary copy of the iterator and restoring it back.
164 (back_to_previous_visible_line_start, reseat_1)
165 (init_iterator): Empty the bidi cache "stack".
166 (move_it_in_display_line_to): If iterator ended up at
167 EOL, but we never saw any buffer positions smaller than
168 to_charpos, return MOVE_POS_MATCH_OR_ZV. Fixes vertical cursor
169 motion in bidi-reordered lines.
170 (move_it_in_display_line_to): Record prev_method and prev_pos
171 immediately before the call to set_iterator_to_next. Fixes cursor
172 motion in bidi-reordered lines with stretch glyphs and strings
173 displayed in margins. (Bug#8133) (Bug#8867)
174 Return MOVE_POS_MATCH_OR_ZV only if iterator position is past
175 TO_CHARPOS.
176 (pos_visible_p): Support positions in bidi-reordered lines. Save
177 and restore bidi cache.
178
179 * bidi.c (bidi_level_of_next_char): clen should be EMACS_NT, not int.
180 (bidi_paragraph_info): Delete unused struct.
181 (bidi_cache_idx, bidi_cache_last_idx): Declare EMACS_INT.
182 (bidi_cache_start): New variable.
183 (bidi_cache_reset): Reset bidi_cache_idx to bidi_cache_start, not
184 to zero.
185 (bidi_cache_fetch_state, bidi_cache_search)
186 (bidi_cache_find_level_change, bidi_cache_iterator_state)
187 (bidi_cache_find, bidi_peek_at_next_level)
188 (bidi_level_of_next_char, bidi_find_other_level_edge)
189 (bidi_move_to_visually_next): Compare cache index with
190 bidi_cache_start rather than with zero.
191 (bidi_fetch_char): Accept new argument STRING; all callers
192 changed. Support iteration over a string. Support strings with
193 display properties. Support unibyte strings. Fix the type of
194 `len' according to what STRING_CHAR_AND_LENGTH expects.
195 (bidi_paragraph_init, bidi_resolve_explicit_1)
196 (bidi_resolve_explicit, bidi_resolve_weak)
197 (bidi_level_of_next_char, bidi_move_to_visually_next): Support
198 iteration over a string.
199 (bidi_set_sor_type, bidi_resolve_explicit_1)
200 (bidi_resolve_explicit, bidi_type_of_next_char): ignore_bn_limit
201 can now be zero (for strings); special values 0 and -1 were
202 changed to -1 and -2, respectively.
203 (bidi_char_at_pos): New function.
204 (bidi_paragraph_init, bidi_resolve_explicit, bidi_resolve_weak):
205 Call it instead of FETCH_MULTIBYTE_CHAR.
206 (bidi_move_to_visually_next): Abort if charpos or bytepos were not
207 initialized to valid values.
208 (bidi_init_it): Don't initialize charpos and bytepos with invalid
209 values.
210 (bidi_level_of_next_char): Allow the sentinel "position" to pass
211 the test for valid cached positions. Fix the logic for looking up
212 the sentinel state in the cache. GCPRO the Lisp string we are
213 iterating.
214 (bidi_push_it, bidi_pop_it): New functions.
215 (bidi_initialize): Initialize the bidi cache start stack pointer.
216 (bidi_cache_ensure_space): New function, refactored from part of
217 bidi_cache_iterator_state. Don't assume the required size is just
218 one BIDI_CACHE_CHUNK away.
219 (bidi_cache_start_stack, bidi_push_it): Use IT_STACK_SIZE.
220 (bidi_count_bytes, bidi_char_at_pos): New functions.
221 (bidi_cache_search): Don't assume bidi_cache_last_idx is
222 always valid if bidi_cache_idx is valid.
223 (bidi_cache_find_level_change): xassert that bidi_cache_last_idx
224 is valid if it's going to be used.
225 (bidi_shelve_cache, bidi_unshelve_cache): New functions.
226 (bidi_cache_fetch_state, bidi_cache_search)
c965adc5
EZ
227 (bidi_cache_find_level_change, bidi_cache_ensure_space)
228 (bidi_cache_iterator_state, bidi_cache_find)
229 (bidi_find_other_level_edge, bidi_cache_start_stack): All
230 variables related to cache indices are now EMACS_INT.
231
0bb23927
EZ
232 * dispextern.h (struct bidi_string_data): New structure.
233 (struct bidi_it): New member `string'. Make flag members be 1-bit
234 fields, and put them last in the struct.
235 (compute_display_string_pos, compute_display_string_end): Update
236 prototypes.
237 (bidi_push_it, bidi_pop_it): Add prototypes.
238 (struct iterator_stack_entry): New members bidi_p,
239 paragraph_embedding, and from_disp_prop_p.
240 (struct it): Member bidi_p is now a bit field 1 bit wide.
241 (bidi_shelve_cache, bidi_unshelve_cache): Declare
242 prototypes.
243
244 * .gdbinit (xvectype, xvector, xcompiled, xchartable, xboolvector)
245 (xpr, xfont, xbacktrace): Use "header.size" when accessing vectors
246 and vector-like objects.
247
248 * dispnew.c (buffer_posn_from_coords): Save and restore the bidi
249 cache around display iteration.
250
251 * window.c (Fwindow_end, window_scroll_pixel_based)
252 (displayed_window_lines, Frecenter): Save and restore the bidi
253 cache around display iteration.
254
3bbd2265
LMI
2552011-07-14 Lars Magne Ingebrigtsen <larsi@gnus.org>
256
257 * editfns.c (Fdelete_region): Clarify the use of the named
258 parameters (bug#6788).
259
adc47434
MR
2602011-07-14 Martin Rudalics <rudalics@gmx.at>
261
262 * indent.c (Fvertical_motion): Set and restore w->pointm when
263 saving and restoring the window's buffer (Bug#9006).
264
837c31f8
LMI
2652011-07-13 Lars Magne Ingebrigtsen <larsi@gnus.org>
266
267 * editfns.c (Fstring_to_char): Clarify just what is returned
268 (bug#6576). Text by Eli Zaretskii.
269
ac389d0c
JB
2702011-07-13 Juanma Barranquero <lekktu@gmail.com>
271
272 * gnutls.c (init_gnutls_functions): Honor gnutls_log_level (bug#9059).
273
0be0ce47
EZ
2742011-07-13 Eli Zaretskii <eliz@gnu.org>
275
276 * buffer.c (mmap_find): Fix a typo.
277
cd18e7e3
JB
2782011-07-13 Johan Bockgård <bojohan@gnu.org>
279
280 Fix execution of x selection hooks.
281 * xselect.c (Qx_lost_selection_functions)
282 (Qx_sent_selection_functions): New vars.
283 (syms_of_xselect): DEFSYM them.
284 (x_handle_selection_request): Pass Qx_sent_selection_functions
285 rather than Vx_sent_selection_functions to Frun_hook_with_args.
286 (x_handle_selection_clear,x_clear_frame_selections):
287 Pass Qx_lost_selection_functions rather than
288 Vx_lost_selection_functions to Frun_hook_with_args.
289
47ea7f44
PE
2902011-07-13 Paul Eggert <eggert@cs.ucla.edu>
291
ac389d0c 292 * buffer.c (Fget_buffer_create): Initialize inhibit_shrinking.
2941c447
PE
293 The old code sometimes used this field without initializing it.
294
47ea7f44
PE
295 * alloc.c (gc_sweep): Don't read past end of array.
296 In theory, the old code could also have corrupted Emacs internals,
297 though it'd be very unlikely.
298
bc985c87
AS
2992011-07-12 Andreas Schwab <schwab@linux-m68k.org>
300
301 * character.c (Fcharacterp): Don't advertise optional ignored
ac389d0c 302 argument. (Bug#4026)
bc985c87 303
0cf34688
LMI
3042011-07-12 Lars Magne Ingebrigtsen <larsi@gnus.org>
305
b3dadd76
LMI
306 * keymap.c (syms_of_keymap): Clarify that "modifier" is "modifier
307 key" (bug#4257).
308
0cf34688
LMI
309 * window.c (Fset_window_start): Doc fix (bug#4199).
310 (Fset_window_hscroll): Ditto.
311
270768cd
PE
3122011-07-12 Paul Eggert <eggert@cs.ucla.edu>
313
077e3dda 314 Fix minor new problems caught by GCC 4.6.1.
270768cd 315 * term.c (init_tty): Remove unused local.
490011a6 316 * xsettings.c (store_monospaced_changed): Define this function only
077e3dda 317 if (defined HAVE_GSETTINGS || defined HAVE_GCONF), as it's
490011a6 318 not used otherwise.
270768cd 319
b1f58454
CY
3202011-07-12 Chong Yidong <cyd@stupidchicken.com>
321
322 * xdisp.c (Vresize_mini_windows): Minor doc fix (Bug#3300).
323
22b9578d
LMI
3242011-07-11 Lars Magne Ingebrigtsen <larsi@gnus.org>
325
6e70ab07
LMI
326 * xdisp.c (syms_of_xdisp): Make it explicit that the mini-windows
327 are the mini-buffer and the echo area (bug#3320).
328
22b9578d
LMI
329 * term.c (init_tty): Remove support for supdup, c10 and perq
330 terminals, which are no longer supported (bug#1482).
331
8974cc9f
JB
3322011-07-10 Johan Bockgård <bojohan@gnu.org>
333
334 * xdisp.c (Ftool_bar_lines_needed): Fix WINDOWP check.
335
a560d974
JD
3362011-07-10 Jan Djärv <jan.h.d@swipnet.se>
337
338 * xmenu.c (menu_highlight_callback): Only pass frame to show_help_event
339 for non-popups (Bug#3642).
340
1dae0f0a
AS
3412011-07-10 Andreas Schwab <schwab@linux-m68k.org>
342
268c2c36 343 * alloc.c (reset_malloc_hooks): Protoize.
1dae0f0a 344 * buffer.c (mmap_init, mmap_find, mmap_free_1, mmap_enlarge)
268c2c36
AS
345 (mmap_set_vars, mmap_alloc, mmap_free, mmap_realloc): Likewise.
346 * cm.c (losecursor): Likewise.
1dae0f0a
AS
347 * data.c (fmod): Likewise.
348 * dispnew.c (swap_glyphs_in_rows): Likewise.
349 * emacs.c (memory_warning_signal): Likewise.
350 * floatfns.c (float_error): Likewise.
351 * font.c (check_gstring, check_otf_features, otf_tag_symbol)
352 (otf_open, font_otf_capability, generate_otf_features)
353 (font_otf_DeviceTable, font_otf_ValueRecord, font_otf_Anchor):
354 Likewise.
355 * image.c (pbm_read_file): Likewise.
356 * indent.c (string_display_width): Likewise.
357 * intervals.c (check_for_interval, search_for_interval)
358 (inc_interval_count, count_intervals, root_interval)
359 (adjust_intervals_for_insertion, make_new_interval): Likewise.
360 * lread.c (defalias): Likewise.
268c2c36 361 * ralloc.c (r_alloc_check): Likewise.
1dae0f0a
AS
362 * regex.c (set_image_of_range_1, set_image_of_range)
363 (regex_grow_registers): Likewise.
364 * sysdep.c (strerror): Likewise.
365 * termcap.c (valid_filename_p, tprint, main): Likewise.
366 * tparam.c (main): Likewise.
367 * unexhp9k800.c (run_time_remap, save_data_space)
368 (update_file_ptrs, read_header, write_header, calculate_checksum)
369 (copy_file, copy_rest, display_header): Likewise.
370 * widget.c (mark_shell_size_user_specified, create_frame_gcs):
371 Likewise.
372 * xdisp.c (check_it): Likewise.
373 * xfaces.c (register_color, unregister_color, unregister_colors):
374 Likewise.
375 * xfns.c (print_fontset_result): Likewise.
376 * xrdb.c (member, fatal, main): Likewise.
377
99033785
PE
3782011-07-10 Paul Eggert <eggert@cs.ucla.edu>
379
380 Fix minor problems found by static checking (Bug#9031).
381 * chartab.c (char_table_set_range, map_sub_char_table):
382 Remove unused locals.
383 (uniprop_table): Now static.
384 * composite.c (_work_char): Remove unused static var.
385
9cb2ac56
JB
3862011-07-09 Juanma Barranquero <lekktu@gmail.com>
387
388 * chartab.c (uniprop_table_uncompress): Remove unused local variable.
389
f25661f0
JD
3902011-07-09 Jan Djärv <jan.h.d@swipnet.se>
391
392 * gtkutil.c (qttip_cb): Remove code without function.
393
8278c4fe
EZ
3942011-07-09 Eli Zaretskii <eliz@gnu.org>
395
396 * w32.c (pthread_sigmask): New stub.
397
1692ae2d 3982011-07-08 Paul Eggert <eggert@cs.ucla.edu>
123403e4 399
8a6ebd58 400 Use pthread_sigmask, not sigprocmask (Bug#9010).
123403e4
PE
401 sigprocmask is portable only for single-threaded applications, and
402 Emacs can be multi-threaded when it uses GTK.
1301ac26
PE
403 * Makefile.in (LIB_PTHREAD_SIGMASK): New macro.
404 (LIBES): Use it.
405 * callproc.c (Fcall_process):
406 * process.c (create_process):
407 * sysdep.c (sys_sigblock, sys_sigunblock, sys_sigsetmask):
408 Use pthread_sigmask, not sigprocmask.
123403e4 409
1b854618
JD
4102011-07-08 Jan Djärv <jan.h.d@swipnet.se>
411
412 * gtkutil.c (qttip_cb): Set line wrap to FALSE for tooltip widget.
413 (xg_prepare_tooltip): Revert text in x->ttip_lbl, margins was
414 wrong (Bug#8591).
415
3fe4b549
JD
4162011-07-08 Jan Djärv <jan.h.d@swipnet.se>
417
0ce7e563
JD
418 * gtkutil.c (xg_prepare_tooltip): Fix indentation and comment.
419 Put text in x->ttip_lbl instead of gtk_tooltip_set_text (Bug#8591).
420 (xg_hide_tooltip): Fix comment.
421
3fe4b549
JD
422 * nsterm.m (initFrameFromEmacs): Don't use ns_return_types
423 in registerServicesMenuSendTypes.
424 (validRequestorForSendType): Don't check ns_return_types.
425
426 * nsfns.m (Fx_open_connection): Put NSStringPboardType into
427 ns_return_type.
428
5df75e47
JR
4292011-07-08 Jason Rumney <jasonr@gnu.org>
430
431 * w32fns.c (w32_wnd_proc) [WM_TIMER, WM_SET_CURSOR]: Avoid using
432 frame struct members of non-existent frames (Bug#6284).
433
699c10bd
JD
4342011-07-08 Jan Djärv <jan.h.d@swipnet.se>
435
4393663b
JD
436 * nsterm.m (keyDown): Call to wantsToDelayTextChangeNotifications and
437 variable firstTime not needed on OSX >= 10.6.
438 (setPosition): setFloatValue:knobProportion: is deprecated on OSX
439 >= 10.5. Use setKnobProportion, setDoubleValue.
440
441 * nsterm.h (MAC_OS_X_VERSION_10_3, MAC_OS_X_VERSION_10_4)
442 (MAC_OS_X_VERSION_10_5): Define if not defined.
443 (EmacsView, EmacsTooltip): Implements NSWindowDelegate on OSX >= 10.6.
444 (EmacsMenu): Implements NSMenuDelegate on OSX >= 10.6.
445 (EmacsToolbar): Implements NSToolbarDelegate on OSX >= 10.6.
446
447 * nsselect.m (ns_string_from_pasteboard): Don't use deprecated methods
448 cString and lossyCString on OSX >= 10.4
449
450 * nsmenu.m (fillWithWidgetValue): Don't use depercated method
451 sizeToFit on OSX >= 10.2.
452
453 * nsimage.m (allocInitFromFile): Don't use deprecated method
454 bestRepresentationForDevice on OSX >= 10.6.
455
456 * nsfns.m (check_ns_display_info): Cast to long and use %ld in error
457 to avoid warning.
458
459 * emacs.c: Declare unexec_init_emacs_zone.
460
a63e0781
JD
461 * nsgui.h: Fix compiler warning about gnulib redefining verify.
462
699c10bd
JD
463 * nsselect.m (ns_get_local_selection): Change to extern (Bug#8842).
464
465 * nsmenu.m (ns_update_menubar): Remove useless setDelegate call
466 on svcsMenu (Bug#8842).
467
468 * nsfns.m (Fx_open_connection): Remove NSStringPboardType from
469 ns_return_types.
470 (Fns_list_services): Just return Qnil on 10.6, code not working there.
471
472 * nsterm.m (QUTF8_STRING): Declare.
473 (initFrameFromEmacs): Call registerServicesMenuSendTypes.
474 (validRequestorForSendType): Return type is (id).
475 Change indexOfObjectIdenticalTo to indexOfObject.
476 Check if we have local selection before returning self (Bug#8842).
477 (writeSelectionToPasteboard): Put local selection into paste board
478 if we have a local selection (Bug#8842).
479 (syms_of_nsterm): DEFSYM QUTF8_STRING.
480
481 * nsterm.h (MAC_OS_X_VERSION_10_6): Define here instead of nsterm.m.
482 (ns_get_local_selection): Declare.
483
54e10184
LMI
4842011-07-07 Lars Magne Ingebrigtsen <larsi@gnus.org>
485
9888ff71
LMI
486 * keymap.c (describe_map_tree): Don't insert a double newline at
487 the end of the buffer (bug#1169) and return whether we inserted
488 something.
489
54e10184
LMI
490 * callint.c (Fcall_interactively): Change "reading args" to
491 "providing args" to try to clarify what it does (bug#1010).
492
15fa4783
KH
4932011-07-07 Kenichi Handa <handa@m17n.org>
494
495 * composite.c (composition_compute_stop_pos): Ignore a static
496 composition starting before CHARPOS (Bug#8915).
497
498 * xdisp.c (handle_composition_prop): Likewise.
499
a8815b00
EZ
5002011-07-07 Eli Zaretskii <eliz@gnu.org>
501
502 * term.c (produce_glyphs) <xassert>: Allow IT_GLYPHLESS in it->what.
503 (Bug#9015)
504
ef7b981d 5052011-07-07 Kenichi Handa <handa@m17n.org>
c805dec0
KH
506
507 * character.h (unicode_category_t): New enum type.
508
509 * chartab.c (uniprop_decoder_t, uniprop_encoder_t): New types.
510 (Qchar_code_property_table): New variable.
511 (UNIPROP_TABLE_P, UNIPROP_GET_DECODER)
512 (UNIPROP_COMPRESSED_FORM_P): New macros.
513 (char_table_ascii): Uncompress the compressed values.
514 (sub_char_table_ref): New arg is_uniprop. Callers changed.
515 Uncompress the compressed values.
ac389d0c 516 (sub_char_table_ref_and_range): Likewise.
c805dec0
KH
517 (char_table_ref_and_range): Uncompress the compressed values.
518 (sub_char_table_set): New arg is_uniprop. Callers changed.
519 Uncompress the compressed values.
520 (sub_char_table_set_range): Args changed. Callers changed.
521 (char_table_set_range): Adjuted for the above change.
522 (map_sub_char_table): Delete args default_val and parent. Add arg
523 top. Give decoded values to a Lisp function.
524 (map_char_table): Adjusted for the above change. Give decoded
525 values to a Lisp function. Gcpro more variables.
526 (uniprop_table_uncompress)
527 (uniprop_decode_value_run_length): New functions.
528 (uniprop_decoder, uniprop_decoder_count): New variables.
529 (uniprop_get_decoder, uniprop_encode_value_character)
530 (uniprop_encode_value_run_length, uniprop_encode_value_numeric):
531 New functions.
532 (uniprop_encoder, uniprop_encoder_count): New variables.
533 (uniprop_get_encoder, uniprop_table)
534 (Funicode_property_table_internal, Fget_unicode_property_internal)
535 (Fput_unicode_property_internal): New functions.
536 (syms_of_chartab): DEFSYM Qchar_code_property_table, defsubr
537 Sunicode_property_table_internal, Sget_unicode_property_internal,
538 and Sput_unicode_property_internal. Defvar_lisp
539 char-code-property-alist.
540
541 * composite.c (CHAR_COMPOSABLE_P): Adjusted for the change of
542 Vunicode_category_table.
543
544 * font.c (font_range): Adjusted for the change of
545 Vunicode_category_table.
546
76b397fb
DN
5472011-07-07 Dan Nicolaescu <dann@ics.uci.edu>
548
549 * m/iris4d.h: Remove file, move contents ...
550 * s/irix6-5.h: ... here.
551
22b4128e
PE
5522011-07-06 Paul Eggert <eggert@cs.ucla.edu>
553
554 Remove unportable assumption about struct layout (Bug#8884).
8a5c77bb
PE
555 * alloc.c (mark_buffer):
556 * buffer.c (reset_buffer_local_variables, Fbuffer_local_variables)
557 (clone_per_buffer_values): Don't assume that
22b4128e
PE
558 sizeof (struct buffer) is a multiple of sizeof (Lisp_Object).
559 This isn't true in general, and it's particularly not true
560 if Emacs is configured with --with-wide-int.
561 * buffer.h (FIRST_FIELD_PER_BUFFER, LAST_FIELD_PER_BUFFER):
562 New macros, used in the buffer.c change.
563
869795d6
JD
5642011-07-05 Jan Djärv <jan.h.d@swipnet.se>
565
566 * xsettings.c: Use both GConf and GSettings if both are available.
567 (store_config_changed_event): Add comment.
568 (dpyinfo_valid, store_font_name_changed, map_tool_bar_style)
569 (store_tool_bar_style_changed): New functions.
570 (store_monospaced_changed): Add comment. Call dpyinfo_valid.
571 (struct xsettings): Move font inside HAVE_XFT.
572 (GSETTINGS_TOOL_BAR_STYLE, GSETTINGS_FONT_NAME): New defines.
573 (GSETTINGS_MONO_FONT): Renamed from SYSTEM_MONO_FONT.
574 Move inside HAVE_XFT.
575 (something_changed_gsettingsCB): Renamed from something_changedCB.
576 Check for changes in GSETTINGS_TOOL_BAR_STYLE and GSETTINGS_FONT_NAME
577 also.
578 (GCONF_TOOL_BAR_STYLE, GCONF_FONT_NAME): New defines.
579 (GCONF_MONO_FONT): Renamed from SYSTEM_MONO_FONT. Move inside HAVE_XFT.
580 (something_changed_gconfCB): Renamed from something_changedCB.
581 Check for changes in GCONF_TOOL_BAR_STYLE and GCONF_FONT_NAME also.
582 (parse_settings): Move check for font inside HAVE_XFT.
583 (read_settings, apply_xft_settings): Add comment.
584 (read_and_apply_settings): Add comment. Call map_tool_bar_style and
585 store_tool_bar_style_changed. Move check for font inside HAVE_XFT and
586 call store_font_name_changed.
587 (xft_settings_event): Add comment.
588 (init_gsettings): Add comment. Get values for GSETTINGS_TOOL_BAR_STYLE
589 and GSETTINGS_FONT_NAME. Move check for fonts within HAVE_XFT.
590 (init_gconf): Add comment. Get values for GCONF_TOOL_BAR_STYLE
591 and GCONF_FONT_NAME. Move check for fonts within HAVE_XFT.
592 (xsettings_initialize): Call init_gsettings last.
593 (xsettings_get_system_font, xsettings_get_system_normal_font): Add
594 comment.
595
d8ed26bd
PE
5962011-07-05 Paul Eggert <eggert@cs.ucla.edu>
597
598 Random fixes. E.g., (random) never returned negative values.
599 * fns.c (Frandom): Use GET_EMACS_TIME for random seed, and add the
600 subseconds part to the entropy, as that's a bit more random.
601 Prefer signed to unsigned, since the signedness doesn't matter and
602 in general we prefer signed. When given a limit, use a
603 denominator equal to INTMASK + 1, not to VALMASK + 1, because the
604 latter isn't right if USE_2_TAGS_FOR_INTS.
605 * sysdep.c (get_random): Return a value in the range 0..INTMASK,
606 not 0..VALMASK. Don't discard "excess" bits that random () returns.
607
cabf1cac
SM
6082011-07-04 Stefan Monnier <monnier@iro.umontreal.ca>
609
610 * textprop.c (text_property_stickiness):
611 Obey Vtext_property_default_nonsticky.
612 (syms_of_textprop): Add `display' to Vtext_property_default_nonsticky.
613 * w32fns.c (syms_of_w32fns):
614 * xfns.c (syms_of_xfns): Don't Add `display' since it's there by default.
615
6e9b2be9
PE
6162011-07-04 Paul Eggert <eggert@cs.ucla.edu>
617
618 * fileio.c (barf_or_query_if_file_exists): Use S_ISDIR.
619 This is more efficient than Ffile_directory_p and avoids a minor race.
620
90186c68
LMI
6212011-07-04 Lars Magne Ingebrigtsen <larsi@gnus.org>
622
7c301272
LMI
623 * buffer.c (Foverlay_put): Say what the return value is
624 (bug#7835).
625
c4f2d8d4
LMI
626 * fileio.c (barf_or_query_if_file_exists): Check first if the file
627 is a directory before asking whether to use the file name
628 (bug#7564).
ad637907
LMI
629 (barf_or_query_if_file_exists): Make the "File is a directory"
630 error be more correct.
c4f2d8d4 631
90186c68
LMI
632 * fns.c (Frequire): Remove the mention of the .gz files, since
633 that's installation-specific, but keep the mention of
634 `get-load-suffixes'.
635
da64016e
PE
6362011-07-04 Paul Eggert <eggert@cs.ucla.edu>
637
638 * editfns.c (Fformat_time_string): Don't assume strlen fits in int.
639 Report string overflow if the output is too long.
640
7d47b580
JB
6412011-07-04 Juanma Barranquero <lekktu@gmail.com>
642
a555cb87
JB
643 * gnutls.c (Fgnutls_boot): Don't mention :verify-error.
644 (syms_of_gnutls): Remove duplicate DEFSYM for
645 Qgnutls_bootprop_verify_hostname_error, an error for
646 Qgnutls_bootprop_verify_error (which is no longer used).
647
7d47b580
JB
648 * eval.c (find_handler_clause): Remove parameters `sig' and `data',
649 unused since 2011-01-26T20:02:07Z!monnier@iro.umontreal.ca. All callers changed.
650 Also (re)move comments that are misplaced or no longer relevant.
651
1e49bfab
LMI
6522011-07-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
653
654 * callint.c (Finteractive): Clarify the meaning of "@" (bug#8813).
655
1485f4c0
CY
6562011-07-03 Chong Yidong <cyd@stupidchicken.com>
657
658 * xfaces.c (Finternal_merge_in_global_face): Modify the foreground
659 and background color parameters if they have been changed.
660
a9ab721e
LMI
6612011-07-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
662
663 * editfns.c (Fformat): Clarify the - and 0 flags (bug#6659).
664
cf7cff57
PE
6652011-07-03 Paul Eggert <eggert@cs.ucla.edu>
666
2e13213d
PE
667 * xsettings.c (SYSTEM_FONT): Define only when used.
668 No need to define when HAVE_GSETTINGS || !HAVE_XFT.
669
cf7cff57
PE
670 * keymap.c (access_keymap_1): Now static.
671
7a8e04f7
CY
6722011-07-02 Chong Yidong <cyd@stupidchicken.com>
673
674 * keyboard.c (command_loop_1): If a down-mouse event is unbound,
675 leave any prefix arg for the up event (Bug#1586).
676
61352f62
LMI
6772011-07-02 Lars Magne Ingebrigtsen <larsi@gnus.org>
678
69bb1ef7
LMI
679 * lread.c (syms_of_lread): Mention single symbols defined by
680 `defvar' or `defconst' (bug#7154).
681
61352f62 682 * fns.c (Frequire): Mention .el.gz files (bug#7314).
7b3747f9 683 (Frequire): Mention get-load-suffixes.
61352f62 684
28545e04
MR
6852011-07-02 Martin Rudalics <rudalics@gmx.at>
686
687 * window.h (window): Remove clone_number slot.
688 * window.c (Fwindow_clone_number, Fset_window_clone_number):
689 Remove.
690 (make_parent_window, make_window, saved_window)
691 (Fset_window_configuration, save_window_save): Don't deal with
692 clone numbers.
693 * buffer.c (Qclone_number): Remove declaration.
694 (sort_overlays, overlay_strings): Don't deal with clone numbers.
695
3349e122
SM
6962011-07-02 Stefan Monnier <monnier@iro.umontreal.ca>
697
698 Add multiple inheritance to keymaps.
699 * keymap.c (Fmake_composed_keymap): New function.
700 (Fset_keymap_parent): Simplify.
701 (fix_submap_inheritance): Remove.
702 (access_keymap_1): New function extracted from access_keymap to handle
703 embedded parents and handle lists of maps.
704 (access_keymap): Use it.
705 (Fkeymap_prompt, map_keymap_internal, map_keymap, store_in_keymap)
706 (Fcopy_keymap): Handle embedded parents.
707 (Fcommand_remapping, define_as_prefix): Simplify.
708 (Fkey_binding): Simplify.
709 (syms_of_keymap): Move minibuffer-local-completion-map,
710 minibuffer-local-filename-completion-map,
711 minibuffer-local-must-match-map, and
712 minibuffer-local-filename-must-match-map to Elisp.
713 (syms_of_keymap): Defsubr make-composed-keymap.
714 * keyboard.c (menu_bar_items): Use map_keymap_canonical.
715 (parse_menu_item): Trivial simplification.
716
3279eb87
GM
7172011-07-01 Glenn Morris <rgm@gnu.org>
718
719 * Makefile.in (SETTINGS_LIBS): Fix typo.
720
4550efdf
KI
7212011-07-01 Kazuhiro Ito <kzhr@d1.dion.ne.jp> (tiny patch)
722
723 * coding.c (Fencode_coding_string): Record the last coding system
724 used, as the function doc string says (bug#8738).
725
0949d2b6
JD
7262011-07-01 Jan Djärv <jan.h.d@swipnet.se>
727
728 * xsettings.c (store_monospaced_changed): Take new font as arg and
729 check for change against current_mono_font.
730 (EMACS_TYPE_SETTINGS): Remove this and related defines.
731 (emacs_settings_constructor, emacs_settings_get_property)
732 (emacs_settings_set_property, emacs_settings_class_init)
733 (emacs_settings_init, gsettings_obj): Remove.
734 (something_changedCB): New function for HAVE_GSETTINGS.
735 (something_changedCB): HAVE_GCONF: Call store_monospaced_changed
736 with value as argument.
737 (init_gsettings): Check that GSETTINGS_SCHEMA exists before calling
738 g_settings_new (Bug#8967). Do not create gsettings_obj.
9173deec 739 Remove calls to g_settings_bind. Connect something_changedCB to
0949d2b6
JD
740 "changed".
741
742 * xgselect.c: Add defined (HAVE_GSETTINGS).
743 (xgselect_initialize): Ditto.
744
745 * process.c: Add defined (HAVE_GSETTINGS) for xgselect.h
746 (wait_reading_process_output): Add defined (HAVE_GSETTINGS) for
747 xg_select.
748
bbc6b304
PE
7492011-07-01 Paul Eggert <eggert@cs.ucla.edu>
750
751 * eval.c (struct backtrace): Simplify and port the data structure.
752 Do not assume that "int nargs : BITS_PER_INT - 2;" produces a
753 signed bit field, as this assumption is not portable and it makes
754 Emacs crash when compiled with Sun C 5.8 on sparc. Do not use
755 "char debug_on_exit : 1" as this is not portable either; instead,
756 use the portable "unsigned int debug_on_exit : 1". Remove unused
757 member evalargs. Remove obsolete comments about cc bombing out.
758
9851bfc5
JD
7592011-06-30 Jan Djärv <jan.h.d@swipnet.se>
760
51bb811f 761 * xsettings.c: Include glib-object.h, gio/gio.h if HAVE_GSETTINGS.
9851bfc5
JD
762 Let HAVE_GSETTINGS override HAVE_GCONF.
763 (store_monospaced_changed): New function.
764 (EMACS_SETTINGS): A new type derived from GObject to handle
765 GSettings notifications.
766 (emacs_settings_constructor, emacs_settings_get_property)
767 (emacs_settings_set_property, emacs_settings_class_init):
768 New functions.
769 (gsettings_client, gsettings_obj): New variables.
770 (GSETTINGS_SCHEMA): New define.
771 (something_changedCB): Call store_monospaced_changed.
772 (init_gsettings): New function.
773 (xsettings_initialize): Call init_gsettings.
774 (syms_of_xsettings): Initialize gsettings_client, gsettings_obj
775 to NULL.
776
777 * Makefile.in (SETTINGS_CFLAGS, SETTINGS_LIBS): Renamed from
778 GCONF_CFLAGS/LIBS.
779
5386012d
MR
7802011-06-29 Martin Rudalics <rudalics@gmx.at>
781
782 * window.c (resize_root_window, grow_mini_window)
783 (shrink_mini_window): Rename Qresize_root_window to
784 Qwindow_resize_root_window and Qresize_root_window_vertically to
785 Qwindow_resize_root_window_vertically.
786
f13e0b08
PE
7872011-06-28 Paul Eggert <eggert@cs.ucla.edu>
788
789 * gnutls.c (Qgnutls_bootprop_verify_error): Remove unused var.
790
94515237
JB
7912011-06-27 Juanma Barranquero <lekktu@gmail.com>
792
793 * makefile.w32-in: Redesign dependencies so they reflect more
794 clearly which files are directly included by each source file,
795 and not through other includes.
796
e43b6e43
MR
7972011-06-27 Martin Rudalics <rudalics@gmx.at>
798
799 * buffer.c (Qclone_number): Declare static and DEFSYM it.
800 (sort_overlays, overlay_strings): When an overlay's clone number
801 matches the window's clone number process the overlay even if
802 the overlay's window property doesn't match the current window.
803
d68443dc
MR
804 * window.c (Fwindow_vchild): Rename to Fwindow_top_child.
805 (Fwindow_hchild): Rename to Fwindow_left_child.
806 (Fwindow_next): Rename to Fwindow_next_sibling.
807 (Fwindow_prev): Rename to Fwindow_prev_sibling.
d615d6d2
MR
808 (resize_window_check): Rename to window_resize_check.
809 (resize_window_apply): Rename to window_resize_apply.
810 (Fresize_window_apply): Rename to Fwindow_resize_apply.
811 (Fdelete_other_windows_internal, resize_frame_windows)
812 (Fsplit_window_internal, Fdelete_window_internal)
813 (grow_mini_window, shrink_mini_window)
814 (Fresize_mini_window_internal): Fix callers accordingly.
d68443dc 815
c7e73be5
JD
8162011-06-26 Jan Djärv <jan.h.d@swipnet.se>
817
818 * emacsgtkfixed.h: State that this is only used with Gtk+3.
819 (emacs_fixed_set_min_size): Remove.
820 (emacs_fixed_new): Take frame as argument.
821
822 * emacsgtkfixed.c: State that this is only used with Gtk+3.
823 (_EmacsFixedPrivate): Remove minwidth/height.
824 Add struct frame *f.
825 (emacs_fixed_init): Initialize priv->f.
826 (get_parent_class, emacs_fixed_set_min_size): Remove.
827 (emacs_fixed_new): Set priv->f to argument.
828 (emacs_fixed_get_preferred_width)
829 (emacs_fixed_get_preferred_height): Use min_width/height from
830 frames size_hint to set minimum and natural (Bug#8919).
831 (XSetWMSizeHints, XSetWMNormalHints): Override these functions
832 and use min_width/height from frames size_hint to set
833 min_width/height (Bug#8919).
834
835 * gtkutil.c (xg_create_frame_widgets): Pass f to emacs_fixed_new.
9173deec
JB
836 (x_wm_set_size_hint): Remove call to emacs_fixed_set_min_size.
837 Fix indentation.
c7e73be5 838
cf99dcf8
EZ
8392011-06-26 Eli Zaretskii <eliz@gnu.org>
840
841 * bidi.c (bidi_paragraph_init): Test for ZV_BYTE before calling
842 bidi_at_paragraph_end, since fast_looking_at doesn't like to be
843 called at ZV.
844
029529ac
CY
8452011-06-26 Chong Yidong <cyd@stupidchicken.com>
846
847 * process.c (wait_reading_process_output): Bypass select if
848 waiting for a cell while ignoring keyboard input, and input is
849 pending. Suggested by Jan Djärv (Bug#8869).
850
7a7ef429
PE
8512011-06-25 Paul Eggert <eggert@cs.ucla.edu>
852
853 Use gnulib's dup2 module instead of rolling our own.
854 * sysdep.c (dup2) [!HAVE_DUP2]: Remove; gnulib now does this.
855
11fdef7d 8562011-06-25 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
989b42d2
YM
857
858 * dispnew.c (scrolling_window): Before scrolling, turn off a
859 mouse-highlight in the window being scrolled.
860
cd3520a4
JB
8612011-06-24 Juanma Barranquero <lekktu@gmail.com>
862
863 Move DEFSYM to lisp.h and use everywhere.
864
865 * character.h (DEFSYM): Move declaration...
866 * lisp.h (DEFSYM): ...here.
867
868 * gnutls.c:
869 * minibuf.c:
870 * w32menu.c:
871 * w32proc.c:
872 * w32select.c: Don't include character.h.
873
874 * alloc.c (syms_of_alloc):
875 * buffer.c (syms_of_buffer):
876 * bytecode.c (syms_of_bytecode):
877 * callint.c (syms_of_callint):
878 * casefiddle.c (syms_of_casefiddle):
879 * casetab.c (init_casetab_once):
880 * category.c (init_category_once, syms_of_category):
881 * ccl.c (syms_of_ccl):
882 * cmds.c (syms_of_cmds):
883 * composite.c (syms_of_composite):
884 * dbusbind.c (syms_of_dbusbind):
885 * dired.c (syms_of_dired):
886 * dispnew.c (syms_of_display):
887 * doc.c (syms_of_doc):
888 * editfns.c (syms_of_editfns):
889 * emacs.c (syms_of_emacs):
890 * eval.c (syms_of_eval):
891 * fileio.c (syms_of_fileio):
892 * fns.c (syms_of_fns):
893 * frame.c (syms_of_frame):
894 * fringe.c (syms_of_fringe):
895 * insdel.c (syms_of_insdel):
896 * keymap.c (syms_of_keymap):
897 * lread.c (init_obarray, syms_of_lread):
898 * macros.c (syms_of_macros):
899 * msdos.c (syms_of_msdos):
900 * print.c (syms_of_print):
901 * process.c (syms_of_process):
902 * search.c (syms_of_search):
903 * sound.c (syms_of_sound):
904 * syntax.c (init_syntax_once, syms_of_syntax):
905 * terminal.c (syms_of_terminal):
906 * textprop.c (syms_of_textprop):
907 * undo.c (syms_of_undo):
908 * w32.c (globals_of_w32):
909 * window.c (syms_of_window):
910 * xdisp.c (syms_of_xdisp):
911 * xfaces.c (syms_of_xfaces):
912 * xfns.c (syms_of_xfns):
913 * xmenu.c (syms_of_xmenu):
914 * xsettings.c (syms_of_xsettings):
915 * xterm.c (syms_of_xterm): Use DEFSYM.
916
4228cf16
TZ
9172011-06-24 Teodor Zlatanov <tzz@lifelogs.com>
918
cd3520a4 919 * gnutls.c (syms_of_gnutls): Use the DEFSYM macro from character.h.
4228cf16 920
7fcccf1e
PE
9212011-06-23 Paul Eggert <eggert@cs.ucla.edu>
922
7efb4e0e
PE
923 Integer and buffer overflow fixes (Bug#8873).
924
ff5844ad
PE
925 * print.c (printchar, strout): Check for string overflow.
926 (PRINTPREPARE, printchar, strout):
927 Don't set size unless allocation succeeds.
928
90532f02
PE
929 * minibuf.c (read_minibuf_noninteractive): Use ptrdiff_t, not int,
930 for sizes. Check for string overflow more accurately.
931 Simplify newline removal at end; this suppresses a GCC 4.6.0 warning.
932
6d84508d
PE
933 * macros.c: Integer and buffer overflow fixes.
934 * keyboard.h (struct keyboard.kbd_macro_bufsize):
935 * macros.c (Fstart_kbd_macro, store_kbd_macro_char):
936 Use ptrdiff_t, not int, for sizes.
937 Don't increment bufsize until after realloc succeeds.
938 Check for size-calculation overflow.
939 (Fstart_kbd_macro): Use EMACS_INT, not int, for XINT result.
940
437b2cb4
PE
941 * lisp.h (DEFVAR_KBOARD): Use offsetof instead of char * finagling.
942
8b9ac8b4
PE
943 * lread.c: Integer overflow fixes.
944 (read_integer): Radix is now EMACS_INT, not int,
945 to improve quality of diagnostics for out-of-range radices.
946 Calculate buffer size correctly for out-of-range radices.
947 (read1): Check for integer overflow in radices, and in
948 read-circle numbers.
82cb60d3
PE
949 (read_escape): Avoid int overflow.
950 (Fload, openp, read_buffer_size, read1)
951 (substitute_object_recurse, read_vector, read_list, map_obarray):
952 Use ptrdiff_t, not int, for sizes.
953 (read1): Use EMACS_INT, not int, for sizes.
20270765 954 Check for size overflow.
8b9ac8b4 955
7fcccf1e
PE
956 * image.c (cache_image): Check for size arithmetic overflow.
957
bfbbd7e7
PE
958 * lread.c: Integer overflow issues.
959 (saved_doc_string_size, saved_doc_string_length)
960 (prev_saved_doc_string_size, prev_saved_doc_string_length):
961 Now ptrdiff_t, not int.
962 (read1): Don't assume doc string length fits in int. Check for
963 out-of-range doc string lengths.
964 (read_list): Don't assume file position fits in int.
39019e54 965 (read_escape): Check for hex character overflow.
bfbbd7e7 966
4e323265
LL
9672011-06-22 Leo Liu <sdl.web@gmail.com>
968
969 * minibuf.c (Fcompleting_read_default, Vcompleting_read_function):
970 Move to minibuffer.el.
971
85fece3e
PE
9722011-06-22 Paul Eggert <eggert@cs.ucla.edu>
973
20b84ce9 974 Fixes for GLYPH_DEBUG found by GCC 4.6.0 static checking.
85fece3e
PE
975 The following patches are for when GLYPH_DEBUG && !XASSERT.
976 * dispextern.h (trace_redisplay_p, dump_glyph_string):
977 * dispnew.c (flush_stdout):
978 * xdisp.c (dump_glyph_row, dump_glyph_matrix, dump_glyph):
979 Mark as externally visible.
980 * dispnew.c (check_window_matrix_pointers): Now static.
981 * dispnew.c (window_to_frame_vpos):
982 * xfns.c (unwind_create_frame):
983 * xterm.c (x_check_font): Remove unused local.
984 * scroll.c (CHECK_BOUNDS):
985 * xfaces.c (cache_fache): Rename local to avoid shadowing.
986 * xfns.c, w32fns.c (image_cache_refcount, dpyinfo_refcount): Now static.
987 * xdisp.c (check_window_end): Now a no-op if !XASSERTS.
988 (debug_first_unchanged_at_end_vpos, debug_last_unchanged_at_beg_vpos)
989 (debug_dvpos, debug_dy, debug_delta, debug_delta_bytes, debug_end_vpos):
990 Now static.
991 (debug_method_add): Use va_list and vsprintf rather than relying
992 on undefined behavior with wrong number of arguments.
993 (dump_glyph, dump_glyph_row, Fdump_glyph_matrix):
994 Don't assume ptrdiff_t and EMACS_INT are the same width as int.
995 In this code, it's OK to assume C99 behavior for ptrdiff_t formats
996 since we're not interested in debugging glyphs with old libraries.
997 * xfaces.c (cache_face): Move debugging code earlier; this pacifies
998 GCC 4.6.0's static checking.
999
0766b489
PE
10002011-06-22 Paul Eggert <eggert@cs.ucla.edu>
1001
31fd4b32
PE
1002 Integer overflow and signedness fixes (Bug#8873).
1003 A few related buffer overrun fixes, too.
1004
b79e8648
PE
1005 * font.c (font_score): Use EMACS_INT, not int, to store XINT value.
1006
0766b489
PE
1007 * dispextern.h (struct face.stipple):
1008 * image.c (x_bitmap_height, x_bitmap_width, x_bitmap_pixmap)
1009 (x_bitmap_mask, x_allocate_bitmap_record)
1010 (x_create_bitmap_from_data, x_create_bitmap_from_file)
1011 (x_destroy_bitmap, x_destroy_all_bitmaps, x_create_bitmap_mask)
1012 (x_create_bitmap_from_xpm_data):
1013 * nsterm.h (struct ns_display_info.bitmaps_size, .bitmaps_last):
1014 * w32term.h (struct w32_display_info.icon_bitmap_id, .bitmaps_size)
1015 (.bitmaps_last):
1016 * xfaces.c (load_pixmap):
1017 * xterm.c (x_bitmap_icon, x_wm_set_icon_pixmap):
1018 * xterm.h (struct x_display_info.icon_bitmap_id, .bitmaps_size)
1019 (.bitmaps_last, struct x_output.icon_bitmap):
1020 Use ptrdiff_t, not int, for bitmap indexes.
1021 (x_allocate_bitmap_record): Check for size overflow.
1022 * dispextern.h, lisp.h: Adjust to API changes elsewhere.
1023
b081724f
PE
1024 Use ptrdiff_t, not int, for overlay counts.
1025 * buffer.h (overlays_at, sort_overlays, GET_OVERLAYS_AT):
1026 * editfns.c (overlays_around, get_pos_property):
1027 * textprop.c (get_char_property_and_overlay):
1028 * xdisp.c (next_overlay_change, note_mouse_highlight):
1029 * xfaces.c (face_at_buffer_position):
21514da7
PE
1030 * buffer.c (OVERLAY_COUNT_MAX): New macro.
1031 (overlays_at, overlays_in, sort_overlays, Foverlays_at)
1032 (Fnext_overlay_change, Fprevious_overlay_change)
1033 (mouse_face_overlay_overlaps, Foverlays_in):
b081724f 1034 Use ptrdiff_t, not int, for sizes.
21514da7 1035 (overlays_at, overlays_in): Check for size-calculation overflow.
b081724f 1036
3de73e5e
PE
1037 * xterm.c (xim_initialize, same_x_server): Strlen may not fit in int.
1038
2606c57b
PE
1039 * xsmfns.c (smc_save_yourself_CB, x_session_initialize): Avoid strlen.
1040 (x_session_initialize): Do not assume string length fits in int.
1041
aaafe47a
PE
1042 * xsettings.c (apply_xft_settings): Fix potential buffer overrun.
1043 This is unlikely, but can occur if DPI is outlandish.
1044
2674ddc8 1045 * xsettings.c (Ffont_get_system_normal_font, Ffont_get_system_font):
3a5077c5
PE
1046 * xselect.c (Fx_get_atom_name): Avoid need for strlen.
1047
28154962
PE
1048 * xrdb.c: Don't assume strlen fits in int; avoid some strlens.
1049 * xrdb.c (magic_file_p, search_magic_path):
1050 Omit last arg SUFFIX; it was always 0. All callers changed.
1051 (magic_file_p): Use ptrdiff_t, not int. Check for size overflow.
1052
7de51af5
PE
1053 * xfont.c (xfont_match): Avoid need for strlen.
1054
25ed6cc3
PE
1055 * xfns.c: Don't assume strlen fits in int.
1056 (xic_create_fontsetname, x_window): Use ptrdiff_t, not int.
1057
4eab31dd
PE
1058 * xdisp.c (message_log_check_duplicate): Return intmax_t,
1059 not unsigned long, as we prefer signed integers. All callers changed.
1060 Detect integer overflow in repeat count.
1061 (message_dolog): Don't assume print length fits in 39 bytes.
df1f27af 1062 (display_mode_element): Don't assume strlen fits in int.
4eab31dd 1063
171e2a58
PE
1064 * termcap.c: Don't assume sizes fit in int and never overflow.
1065 (struct termcap_buffer, tgetent): Use ptrdiff_t, not int, for sizes.
1066 (gobble_line): Check for size-calculation overflow.
1067
ad39faca 1068 * minibuf.c (Fread_buffer):
6e5bb2dc 1069 * lread.c (intern, intern_c_string):
74ca2eb3
PE
1070 * image.c (xpm_scan) [HAVE_NS && !HAVE_XPM]:
1071 Don't assume string length fits in int.
1072
52c61c22 1073 * keyboard.c (parse_tool_bar_item):
9bda3520
PE
1074 * gtkutil.c (style_changed_cb): Avoid need for strlen.
1075
b5b8c9e5
PE
1076 * font.c: Don't assume string length fits in int.
1077 (font_parse_xlfd, font_parse_fcname, font_unparse_fcname):
1078 Use ptrdiff_t, not int.
ccd6111c
PE
1079 (font_intern_prop): Don't assume string length fits in int.
1080 Don't assume integer property fits in fixnum.
1081 * font.h (font_intern_prop): 2nd arg is now ptrdiff_t, not int.
b5b8c9e5 1082
882f0d81 1083 * filelock.c: Fix some buffer overrun and integer overflow issues.
51cab52b 1084 (get_boot_time): Don't assume gzip command string fits in 100 bytes.
882f0d81
PE
1085 Reformulate so as not to need the command string.
1086 Invoke gzip -cd rather than gunzip, as it's more portable.
1087 (lock_info_type, lock_file_1, lock_file):
1088 Don't assume pid_t and time_t fit in unsigned long.
1089 (LOCK_PID_MAX): Remove; we now use more-reliable bounds.
1090 (current_lock_owner): Prefer signed type for sizes.
1091 Use memcpy, not strncpy, where memcpy is what is really wanted.
1092 Don't assume (via atoi) that time_t and pid_t fit in int.
1093 Check for time_t and/or pid_t out of range, e.g., via a network share.
1094 Don't alloca where an auto var works fine.
1095
93f4cf88
PE
1096 * fileio.c: Fix some integer overflow issues.
1097 (file_name_as_directory, Fexpand_file_name, Fsubstitute_in_file_name):
1098 Don't assume string length fits in int.
1099 (directory_file_name): Don't assume string length fits in long.
1100 (make_temp_name): Don't assume pid fits in int, or that its print
1101 length is less than 20.
1102
f3e92b69
PE
1103 * data.c (Fsubr_name): Rewrite to avoid a strlen call.
1104
1bfdaf10
PE
1105 * coding.c (make_subsidiaries): Don't assume string length fits in int.
1106
35016e9a
PE
1107 * callproc.c (child_setup): Rewrite to avoid two strlen calls.
1108
3d1e65a1
PE
1109 * process.c (Fformat_network_address): Use EMACS_INT, not EMACS_UINT.
1110 We prefer signed integers, even for size calculations.
1111
0b963a93
PE
1112 * emacs.c: Don't assume string length fits in 'int'.
1113 (DEFINE_DUMMY_FUNCTION, sort_args): Use ptrdiff_t, not int.
1114 (main): Don't invoke strlen when not needed.
1115
573f4b54
PE
1116 * dbusbind.c (XD_ERROR): Don't arbitrarily truncate string.
1117 (XD_DEBUG_MESSAGE): Don't waste a byte.
1118
989f33ba
PE
1119 * callproc.c (getenv_internal_1, getenv_internal)
1120 (Fgetenv_internal):
965d34eb
PE
1121 * buffer.c (init_buffer): Don't assume string length fits in 'int'.
1122
e4d29b33
PE
1123 * lread.c (invalid_syntax): Omit length argument.
1124 All uses changed. This doesn't fix a bug, but it simplifies the
1125 code away from its former Hollerith-constant appearance, and it's
1126 one less 'int' to worry about when looking at integer-overflow issues.
51cab52b 1127 (string_to_number): Simplify 2011-04-26 change by invoking xsignal1.
e4d29b33 1128
eb49b136
PE
1129 * lisp.h (DEFUN): Remove bogus use of sizeof (struct Lisp_Subr).
1130 This didn't break anything, but it didn't help either.
1131 It's confusing to put a bogus integer in a place where the actual
1132 value does not matter.
9f62aeb1 1133 (LIST_END_P): Remove unused macro and its bogus comment.
cbeff735 1134 (make_fixnum_or_float): Remove unnecessary cast to EMACS_INT.
eb49b136 1135
15375a22
PE
1136 * lisp.h (union Lisp_Object.i): EMACS_INT, not EMACS_UINT.
1137 This is for consistency with the ordinary, non-USE_LISP_UNION_TYPE,
1138 implementation.
b61cc01c
PE
1139 (struct Lisp_Bool_Vector.size): EMACS_INT, not EMACS_UINT.
1140 We prefer signed types, and the value cannot exceed the EMACS_INT
1141 range anyway (because otherwise the length would not be representable).
9a8e8d9b
PE
1142 (XSET) [USE_LISP_UNION_TYPE]: Use uintptr_t and intptr_t,
1143 not EMACS_UINT and EMACS_INT, when converting pointer to integer.
1144 This avoids a GCC warning when WIDE_EMACS_INT.
15375a22 1145
53b2623d
PE
1146 * indent.c (sane_tab_width): New function.
1147 (current_column, scan_for_column, Findent_to, position_indentation)
1148 (compute_motion): Use it. This is just for clarity.
8fcaf9cc 1149 (Fcompute_motion): Don't assume hscroll and tab offset fit in int.
53b2623d 1150
51cab52b 1151 * image.c (xbm_image_p): Don't assume stated width, height fit in int.
45aebb64 1152
f2ed8a70
PE
1153 * lisp.h (lint_assume): New macro.
1154 * composite.c (composition_gstring_put_cache):
1155 * ftfont.c (ftfont_shape_by_flt): Use it to pacify GCC 4.6.0.
1156
abe80cc6
PE
1157 * editfns.c, insdel.c:
1158 Omit unnecessary forward decls, to simplify future changes.
a9e860e1 1159
b02c740e
PE
1160 * ftfont.c (ftfont_shape_by_flt): Use signed integers for lengths.
1161
ebc96716
PE
1162 * font.c (Ffont_shape_gstring): Don't assume glyph len fits in 'int'.
1163
b4e50fa0 1164 * fns.c (Ffillarray): Don't assume bool vector size fits in 'int'.
f03dc6ef 1165 Use much-faster test for byte-length change.
311d5d7c 1166 Don't assume string byte-length fits in 'int'.
a4cf38e4 1167 Check that character arg fits in 'int'.
85461888 1168 (mapcar1): Declare byte as byte, for clarity.
b4e50fa0 1169
c0c1ee9f
PE
1170 * alloc.c (Fmake_bool_vector): Avoid unnecessary multiplication.
1171
a498d7f4
PE
1172 * fns.c (concat): Catch string overflow earlier.
1173 Do not rely on integer wraparound.
1174
51cab52b
PE
1175 * dispextern.h (struct it.overlay_strings_charpos)
1176 (struct it.selective): Now EMACS_INT, not int.
87830974
PE
1177 * xdisp.c (forward_to_next_line_start)
1178 (back_to_previous_visible_line_start)
1179 (reseat_at_next_visible_line_start, next_element_from_buffer):
1180 Don't arbitrarily truncate the value of 'selective' to int.
1181
76031fad
PE
1182 * xdisp.c (init_iterator): Use XINT, not XFASTINT; it might be < 0.
1183
5eb55db9
PE
1184 * composite.c: Don't truncate sizes to 'int'.
1185 (composition_gstring_p, composition_reseat_it)
1186 (composition_adjust_point): Use EMACS_INT, not int.
7d100a81
PE
1187 (get_composition_id, composition_gstring_put_cache): Use EMACS_INT,
1188 not EMACS_UINT, for indexes.
5eb55db9 1189
0703a717
PE
1190 * category.h (CATEGORY_SET_P): Remove unnecessary cast to EMACS_INT.
1191
d6202519
PE
1192 * buffer.c: Include <verify.h>.
1193 (struct sortvec.priority, struct sortstr.priority):
8961a454 1194 Now EMACS_INT, not int.
c20998a7 1195 (compare_overlays, cmp_for_strings): Avoid subtraction overflow.
67c36fce
PE
1196 (struct sortstr.size, record_overlay_string)
1197 (struct sortstrlist.size, struct sortlist.used):
1198 Don't truncate size to int.
1199 (record_overlay_string): Check for size-calculation overflow.
d6202519 1200 (init_buffer_once): Check at compile-time, not run-time.
fadf4e30 1201
d5a19415
JM
12022011-06-22 Jim Meyering <meyering@redhat.com>
1203
029529ac 1204 Don't leak an XBM-image-sized buffer
d5a19415
JM
1205 * image.c (xbm_load): Free the image buffer after using it.
1206
a9041e6c
PE
12072011-06-21 Paul Eggert <eggert@cs.ucla.edu>
1208
1209 Port to Sun C.
1210 * composite.c (find_automatic_composition): Omit needless 'return 0;'
1211 that Sun C diagnosed.
1212 * fns.c (secure_hash): Fix pointer signedness issue.
1213 * intervals.c (static_offset_intervals): New function.
1214 (offset_intervals): Use it.
1215
7f3f739f
LL
12162011-06-21 Leo Liu <sdl.web@gmail.com>
1217
1218 * deps.mk (fns.o):
1219 * makefile.w32-in ($(BLD)/fns.$(O)): Include sha256.h and
1220 sha512.h.
1221
1222 * fns.c (secure_hash): Rename from crypto_hash_function and change
1223 the first arg to accept symbols.
5b66d427 1224 (Fsecure_hash): New primitive.
7f3f739f
LL
1225 (syms_of_fns): New symbols.
1226
76147d94
DD
12272011-06-20 Deniz Dogan <deniz@dogan.se>
1228
1229 * process.c (Fset_process_buffer): Clarify return value in
1230 docstring.
1231
7d7d0045
CY
12322011-06-18 Chong Yidong <cyd@stupidchicken.com>
1233
1234 * dispnew.c (add_window_display_history): Use BVAR.
1235
1236 * xdisp.c (debug_method_add): Use BVAR.
1237 (check_window_end, dump_glyph_matrix, dump_glyph)
1238 (dump_glyph_row, dump_glyph_string): Convert arglist to ANSI C.
1239
1240 * xfaces.c (check_lface_attrs, check_lface, dump_realized_face):
1241 Likewise.
1242
1243 * xfns.c (Fx_create_frame, x_create_tip_frame): Delay image cache
1244 check till after the cache is created in init_frame_faces.
1245
ff2bc410
SM
12462011-06-17 Stefan Monnier <monnier@iro.umontreal.ca>
1247
1248 * fns.c (Fsafe_length): Yet another int/Lisp_Object mixup.
1249
28177add
PE
12502011-06-16 Paul Eggert <eggert@cs.ucla.edu>
1251
dd3482fe
PE
1252 * lisp.h: Include <limits.h>, for INT_MAX, LONG_MAX, LLONG_MAX.
1253 Without this, prin1 mishandles Lisp_Misc_Save_Value printing on
1254 hosts with pre-C99 libraries, because pD is wrongly defined to "t".
1255
393d71f3 1256 Improve buffer-overflow checking (Bug#8873).
1c8e352f
PE
1257 * fileio.c (Finsert_file_contents):
1258 * insdel.c (insert_from_buffer_1, replace_range, replace_range_2):
1259 Remove the old (too-loose) buffer overflow checks.
1260 They weren't needed, since make_gap checks for buffer overflow.
1261 * insdel.c (make_gap_larger): Catch buffer overflows that were missed.
1262 The old code merely checked for Emacs fixnum overflow, and relied
1263 on undefined (wraparound) behavior. The new code avoids undefined
1264 behavior, and also checks for ptrdiff_t and/or size_t overflow.
1265
2e6813b0 1266 * editfns.c (Finsert_char): Don't dump core with very negative counts.
21d890a4
PE
1267 Tune. Don't use wider integers than needed. Don't use alloca.
1268 Use a bigger 'string' buffer. Rewrite to avoid 'n > 0' test.
2e6813b0 1269
599a9e4f
PE
1270 * insdel.c (replace_range): Fix buf overflow when insbytes < outgoing.
1271
99561444
PE
1272 * insdel.c, lisp.h (buffer_overflow): New function.
1273 (insert_from_buffer_1, replace_range, replace_range_2):
1274 * insdel.c (make_gap_larger):
1275 * editfns.c (Finsert_char):
1276 * fileio.c (Finsert_file_contents): Use it, to normalize wording.
1277
28177add
PE
1278 * buffer.h (BUF_BYTES_MAX): Cast to ptrdiff_t so that it's signed.
1279
e69dafad
PE
12802011-06-15 Paul Eggert <eggert@cs.ucla.edu>
1281
a7af7fde 1282 Integer overflow and signedness fixes (Bug#8873).
ff672d2c 1283
b1c46f02
PE
1284 * ccl.c (ASCENDING_ORDER): New macro, to work around GCC bug 43772.
1285 (GET_CCL_RANGE, IN_INT_RANGE): Use it.
1286
e69dafad
PE
1287 * fileio.c: Don't assume EMACS_INT fits in off_t.
1288 (emacs_lseek): New static function.
1289 (Finsert_file_contents, Fwrite_region): Use it.
1290 Use SEEK_SET, SEEK_CUR, SEEK_END as appropriate.
1291
566684ea
PE
1292 * fns.c (Fload_average): Don't assume 100 * load average fits in int.
1293
e6966cd6
PE
1294 * fns.c: Don't overflow int when computing a list length.
1295 * fns.c (QUIT_COUNT_HEURISTIC): New constant.
1296 (Flength, Fsafe_length): Use EMACS_INT, not int, to avoid unwanted
1297 truncation on 64-bit hosts. Check for QUIT every
1298 QUIT_COUNT_HEURISTIC entries rather than every other entry; that's
1299 faster and is responsive enough.
1300 (Flength): Report an error instead of overflowing an integer.
1301 (Fsafe_length): Return a float if the value is not representable
1302 as a fixnum. This shouldn't happen except in contrived situations.
6346d301 1303 (Fnthcdr, Fsort): Don't assume list length fits in int.
de41a810 1304 (Fcopy_sequence): Don't assume vector length fits in int.
00c604f2 1305
dd0b0efb
PE
1306 * alloc.c: Check that resized vectors' lengths fit in fixnums.
1307 (header_size, word_size): New constants.
1308 (allocate_vectorlike): Don't check size overflow here.
1309 (allocate_vector): Check it here instead, since this is the only
1310 caller of allocate_vectorlike that could cause overflow.
1311 Check that the new vector's length is representable as a fixnum.
1312
86fe5cfe
PE
1313 * fns.c (next_almost_prime): Don't return a multiple of 3 or 5.
1314 The previous code was bogus. For example, next_almost_prime (32)
1315 returned 39, which is undesirable as it is a multiple of 3; and
1316 next_almost_prime (24) returned 25, which is a multiple of 5 so
1317 why was the code bothering to check for multiples of 7?
1318
80e88859
PE
1319 * bytecode.c (exec_byte_code): Use ptrdiff_t, not int, for vector length.
1320
4a2f0ad6
PE
1321 * eval.c, doprnt.c (SIZE_MAX): Remove; inttypes.h defines this now.
1322
f66c7cf8
PE
1323 Variadic C functions now count arguments with ptrdiff_t.
1324 This partly undoes my 2011-03-30 change, which replaced int with size_t.
1325 Back then I didn't know that the Emacs coding style prefers signed int.
1326 Also, in the meantime I found a few more instances where arguments
4a2f0ad6
PE
1327 were being counted with int, which may truncate counts on 64-bit
1328 machines, or EMACS_INT, which may be unnecessarily wide.
f66c7cf8
PE
1329 * lisp.h (struct Lisp_Subr.function.aMANY)
1330 (DEFUN_ARGS_MANY, internal_condition_case_n, safe_call):
1331 Arg counts are now ptrdiff_t, not size_t.
1332 All variadic functions and their callers changed accordingly.
1333 (struct gcpro.nvars): Now size_t, not size_t. All uses changed.
1334 * bytecode.c (exec_byte_code): Check maxdepth for overflow,
1335 to avoid potential buffer overrun. Don't assume arg counts fit in 'int'.
1336 * callint.c (Fcall_interactively): Check arg count for overflow,
1337 to avoid potential buffer overrun. Use signed char, not 'int',
1338 for 'varies' array, so that we needn't bother to check its size
1339 calculation for overflow.
1340 * editfns.c (Fformat): Use ptrdiff_t, not EMACS_INT, to count args.
1341 * eval.c (apply_lambda):
1342 * fns.c (Fmapconcat): Use XFASTINT, not XINT, to get args length.
1343 (struct textprop_rec.argnum): Now ptrdiff_t, not int. All uses changed.
1344 (mapconcat): Use ptrdiff_t, not int and EMACS_INT, to count args.
1345
a1759b76
PE
1346 * callint.c (Fcall_interactively): Don't use index var as event count.
1347
d96be9fc
PE
1348 * vm-limit.c (check_memory_limits): Fix incorrect extern function decls.
1349 * mem-limits.h (SIZE): Remove; no longer used.
1350
a690a978 1351 * xterm.c (x_alloc_nearest_color_1): Prefer int to long when int works.
5efd304b 1352
578c21e6
PE
1353 Remove unnecessary casts.
1354 * xterm.c (x_term_init):
1355 * xfns.c (x_set_border_pixel):
1356 * widget.c (create_frame_gcs): Remove casts to unsigned long etc.
1357 These aren't needed now that we assume ANSI C.
1358
96f53c6c
PE
1359 * sound.c (Fplay_sound_internal): Remove cast to unsigned long.
1360 It's more likely to cause problems (due to unsigned overflow)
1361 than to cure them.
1362
83c77d31
PE
1363 * dired.c (Ffile_attributes): Don't use 32-bit hack on 64-bit hosts.
1364
ee2079f1
PE
1365 * unexelf.c (unexec): Don't assume BSS addr fits in unsigned.
1366
6da65536
PE
1367 * xterm.c (handle_one_xevent): Omit unnecessary casts to unsigned.
1368
7147c4a4
PE
1369 * keyboard.c (modify_event_symbol): Don't limit alist len to UINT_MAX.
1370
193e32d9
PE
1371 * lisp.h (CHAR_TABLE_SET): Omit now-redundant test.
1372
e5533da6
PE
1373 * lread.c (Fload): Don't compare a possibly-garbage time_t value.
1374
9910e595
PE
1375 GLYPH_CODE_FACE returns EMACS_INT, not int.
1376 * dispextern.h (merge_faces):
1377 * xfaces.c (merge_faces):
01103c44
PE
1378 * xdisp.c (get_next_display_element, next_element_from_display_vector):
1379 Don't assume EMACS_INT fits in int.
9910e595 1380
2638320e
PE
1381 * character.h (CHAR_VALID_P): Remove unused parameter.
1382 * fontset.c, lisp.h, xdisp.c: All uses changed.
1383
045eb8d9
PE
1384 * editfns.c (Ftranslate_region_internal): Omit redundant test.
1385
c1f134b5
PE
1386 * fns.c (concat): Minor tuning based on overflow analysis.
1387 This doesn't fix any bugs. Use int to hold character, instead
1388 of constantly refetching from Emacs object. Use XFASTINT, not
1389 XINT, for value known to be a character. Don't bother comparing
1390 a single byte to 0400, as it's always less.
1391
395fcb93 1392 * floatfns.c (Fexpt):
327eeec8
PE
1393 * fileio.c (make_temp_name): Omit unnecessary cast to unsigned.
1394
abbd3d23
PE
1395 * editfns.c (Ftranslate_region_internal): Use int, not EMACS_INT
1396 for characters.
1397
684a03ef
PE
1398 * doc.c (get_doc_string): Omit (unsigned)c that mishandled negatives.
1399
0fed43f3
PE
1400 * data.c (Faset): If ARRAY is a string, check that NEWELT is a char.
1401 Without this fix, on a 64-bit host (aset S 0 4294967386) would
1402 incorrectly succeed when S was a string, because 4294967386 was
1403 truncated before it was used.
1404
8fd02eb7
PE
1405 * chartab.c (Fchar_table_range): Use CHARACTERP to check range.
1406 Otherwise, an out-of-range integer could cause undefined behavior
1407 on a 64-bit host.
1408
f8c86b69
PE
1409 * composite.c: Use int, not EMACS_INT, for characters.
1410 (fill_gstring_body, composition_compute_stop_pos): Use int, not
1411 EMACS_INT, for values that are known to be in character range.
1412 This doesn't fix any bugs but is the usual style inside Emacs and
1413 may generate better code on 32-bit machines.
1414
34206dd2
PE
1415 Make sure a 64-bit char is never passed to ENCODE_CHAR.
1416 This is for reasons similar to the recent CHAR_STRING fix.
1417 * charset.c (Fencode_char): Check that character arg is actually
1418 a character. Pass an int to ENCODE_CHAR.
1419 * charset.h (ENCODE_CHAR): Verify that the character argument is no
1420 wider than 'int', as a compile-time check to prevent future regressions
1421 in this area.
1422
c5958d4c 1423 * character.c (char_string): Remove unnecessary casts.
13bdea59
PE
1424
1425 Make sure a 64-bit char is never passed to CHAR_STRING.
1426 Otherwise, CHAR_STRING would do the wrong thing on a 64-bit platform,
1427 by silently ignoring the top 32 bits, allowing some values
1428 that were far too large to be valid characters.
1429 * character.h: Include <verify.h>.
1430 (CHAR_STRING, CHAR_STRING_ADVANCE): Verify that the character
1431 arguments are no wider than unsigned, as a compile-time check
1432 to prevent future regressions in this area.
1433 * data.c (Faset):
01103c44 1434 * editfns.c (Fchar_to_string, general_insert_function, Finsert_char)
13bdea59
PE
1435 (Fsubst_char_in_region):
1436 * fns.c (concat):
1437 * xdisp.c (decode_mode_spec_coding):
1438 Adjust to CHAR_STRING's new requirement.
1439 * editfns.c (Finsert_char, Fsubst_char_in_region):
1440 * fns.c (concat): Check that character args are actually
1441 characters. Without this test, these functions did the wrong
1442 thing with wildly out-of-range values on 64-bit hosts.
1443
d37ca623
PE
1444 Remove incorrect casts to 'unsigned' that lose info on 64-bit hosts.
1445 These casts should not be needed on 32-bit hosts, either.
1446 * keyboard.c (read_char):
1447 * lread.c (Fload): Remove casts to unsigned.
1448
ea204efb
PE
1449 * lisp.h (UNSIGNED_CMP): New macro.
1450 This fixes comparison bugs on 64-bit hosts.
1451 (ASCII_CHAR_P): Use it.
1452 * casefiddle.c (casify_object):
01103c44 1453 * character.h (ASCII_BYTE_P, CHAR_VALID_P)
ea204efb
PE
1454 (SINGLE_BYTE_CHAR_P, CHAR_STRING):
1455 * composite.h (COMPOSITION_ENCODE_RULE_VALID):
1456 * dispextern.h (FACE_FROM_ID):
1457 * keyboard.c (read_char): Use UNSIGNED_CMP.
1458
41cb286c
PE
1459 * xmenu.c (dialog_selection_callback) [!USE_GTK]: Cast to intptr_t,
1460 not to EMACS_INT, to avoid GCC warning.
1461
4a1b9832
PE
1462 * xfns.c (x_set_scroll_bar_default_width): Remove unused 'int' locals.
1463
55daad71
PE
1464 * buffer.h (PTR_BYTE_POS, BUF_PTR_BYTE_POS): Remove harmful cast.
1465 The cast incorrectly truncated 64-bit byte offsets to 32 bits, and
1466 isn't needed on 32-bit machines.
8f95c75c 1467
01103c44
PE
1468 * buffer.c (Fgenerate_new_buffer_name):
1469 Use EMACS_INT for count, not int.
0ceccced 1470 (advance_to_char_boundary): Return EMACS_INT, not int.
e762cafe
PE
1471
1472 * data.c (Qcompiled_function): Now static.
1473
c6f072e7
PE
1474 * window.c (window_body_lines): Now static.
1475
20ce5912
PE
1476 * image.c (gif_load): Rename local to avoid shadowing.
1477
9c4c5f81
PE
1478 * lisp.h (SAFE_ALLOCA_LISP): Check for integer overflow.
1479 (struct Lisp_Save_Value): Use ptrdiff_t, not int, for 'integer' member.
1480 * alloc.c (make_save_value): Integer argument is now of type
1481 ptrdiff_t, not int.
1482 (mark_object): Use ptrdiff_t, not int.
1483 * lisp.h (pD): New macro.
1484 * print.c (print_object): Use it.
1485
c0c5c8ae
PE
1486 * alloc.c: Use EMACS_INT, not int, to count objects.
1487 (total_conses, total_markers, total_symbols, total_vector_size)
1488 (total_free_conses, total_free_markers, total_free_symbols)
01103c44
PE
1489 (total_free_floats, total_floats, total_free_intervals)
1490 (total_intervals, total_strings, total_free_strings):
c0c5c8ae
PE
1491 Now EMACS_INT, not int. All uses changed.
1492 (Fgarbage_collect): Compute overall total using a double, so that
1493 integer overflow is less likely to be a problem. Check for overflow
1494 when converting back to an integer.
5a25e253
PE
1495 (n_interval_blocks, n_string_blocks, n_float_blocks, n_cons_blocks)
1496 (n_vectors, n_symbol_blocks, n_marker_blocks): Remove.
1497 These were 'int' variables that could overflow on 64-bit hosts;
1498 they were never used, so remove them instead of repairing them.
211a0b2a 1499 (nzombies, ngcs, max_live, max_zombies): Now EMACS_INT, not 'int'.
6349ae4d
PE
1500 (inhibit_garbage_collection): Set gc_cons_threshold to max value.
1501 Previously, this ceilinged at INT_MAX, but that doesn't work on
1502 64-bit machines.
e46bb31a 1503 (allocate_pseudovector): Don't use EMACS_INT when int would do.
c0c5c8ae 1504
c78baabf 1505 * alloc.c (Fmake_bool_vector): Don't assume vector size fits in int.
86f61a15 1506 (allocate_vectorlike): Check for ptrdiff_t overflow.
b6439961
PE
1507 (mark_vectorlike, mark_char_table, mark_object): Avoid EMACS_UINT
1508 when a (possibly-narrower) signed value would do just as well.
1509 We prefer using signed arithmetic, to avoid comparison confusion.
c78baabf 1510
c9d624c6
PE
1511 * alloc.c: Catch some string size overflows that we were missing.
1512 (XMALLOC_OVERRUN_CHECK_SIZE) [!XMALLOC_OVERRUN_CHECK]: Define to 0,
1513 for convenience in STRING_BYTES_MAX.
1514 (STRING_BYTES_MAX): New macro, superseding the old one in lisp.h.
1515 The definition here is exact; the one in lisp.h was approximate.
1516 (allocate_string_data): Check for string overflow. This catches
1517 some instances we weren't catching before. Also, it catches
1518 size_t overflow on (unusual) hosts where SIZE_MAX <= min
1519 (PTRDIFF_MAX, MOST_POSITIVE_FIXNUM), e.g., when size_t is 32 bits
1520 and ptrdiff_t and EMACS_INT are both 64 bits.
c78baabf 1521
c9d624c6
PE
1522 * character.c, coding.c, doprnt.c, editfns.c, eval.c:
1523 All uses of STRING_BYTES_MAX replaced by STRING_BYTES_BOUND.
1524 * lisp.h (STRING_BYTES_BOUND): Renamed from STRING_BYTES_MAX.
1525
353032ce
PE
1526 * character.c (string_escape_byte8): Fix nbytes/nchars typo.
1527
2bccce07
PE
1528 * alloc.c (Fmake_string): Check for out-of-range init.
1529
0ac30604
SM
15302011-06-15 Stefan Monnier <monnier@iro.umontreal.ca>
1531
1532 * eval.c (Fdefvaralias): Also mark the target as variable-special-p.
1533
c195f2de
JD
15342011-06-14 Jan Djärv <jan.h.d@swipnet.se>
1535
1536 * xfns.c (x_set_scroll_bar_default_width): Remove argument to
1537 xg_get_default_scrollbar_width.
1538
1539 * gtkutil.c: Include emacsgtkfixed.h if HAVE_GTK3.
1540 (int_gtk_range_get_value): Move to the scroll bar part of the file.
1541 (style_changed_cb): Call update_theme_scrollbar_width and call
1542 x_set_scroll_bar_default_width and xg_frame_set_char_size for
1543 all frames (Bug#8505).
1544 (xg_create_frame_widgets): Call emacs_fixed_new if HAVE_GTK3 (Bug#8505).
1545 Call gtk_window_set_resizable if HAVE_GTK3.
1546 (x_wm_set_size_hint): Call emacs_fixed_set_min_size with min width
1547 and height if HAVE_GTK3 (Bug#8505).
1548 (scroll_bar_width_for_theme): New variable.
1549 (update_theme_scrollbar_width): New function.
1550 (xg_get_default_scrollbar_width): Move code to
1551 update_theme_scrollbar_width, just return scroll_bar_width_for_theme.
1552 (xg_initialize): Call update_theme_scrollbar_width.
1553
1554 * gtkutil.h (xg_get_default_scrollbar_width): Remove argument.
1555
1556 * emacsgtkfixed.c, emacsgtkfixed.h: New files.
1557
e10ac9f1
MR
15582011-06-12 Martin Rudalics <rudalics@gmx.at>
1559
1560 * frame.c (make_frame): Call other_buffer_safely instead of
1561 other_buffer.
1562
1563 * window.c (temp_output_buffer_show): Call display_buffer with
1564 second argument Vtemp_buffer_show_specifiers and reset latter
1565 immediately after the call.
1566 (Vtemp_buffer_show_specifiers): New variable.
1567 (auto_window_vscroll_p, next_screen_context_lines)
1568 (Vscroll_preserve_screen_position): Remove leading asterisks from
1569 doc-strings.
1570
2d3c217e 15712011-06-12 Paul Eggert <eggert@cs.ucla.edu>
4475bec4 1572
7b7f97e8 1573 Fix minor problems found by GCC 4.6.0 static checking.
4475bec4
PE
1574 * buffer.c (Qclone_number): Remove for now, as it's unused.
1575 (record_buffer, Funrecord_buffer): Rename local to avoid shadowing.
1576 (record_buffer): Remove unused local.
1577 * frame.c (other_visible_frames, frame_buffer_list): Now static.
1578 (set_frame_buffer_list): Remove; unused.
1579 * frame.h (other_visible_frames): Remove decl.
1580 * keyboard.h (menu_items_inuse): Declare only if USE_GTK || USE_MOTIF.
1581 * lisp.h (frame_buffer_list, set_frame_buffer_list): Remove decls.
1582 (add_gpm_wait_descriptor, delete_gpm_wait_descriptor): Declare only
1583 if HAVE_GPM.
1584 * menu.c (menu_items_inuse): Now static unless USE_GTK || USE_MOTIF.
1585 * process.c (add_gpm_wait_descriptor, delete_gpm_wait_descriptor):
1586 Define only if HAVE_GPM.
1587 * widget.c (EmacsFrameResize, emacsFrameClassRec): Now static.
1588 (update_hints_inhibit): Remove; never set. All uses removed.
1589 * widgetprv.h (emacsFrameClassRec): Remove decl.
1590 * window.c (delete_deletable_window): Now returns void, since it
1591 wasn't returning anything.
1592 (compare_window_configurations): Remove unused locals.
1593 * xfns.c (x_set_scroll_bar_default_width): Remove unused locals.
1594 * xmenu.c (x_menu_set_in_use): Define only if USE_GTK || USE_MOTIF.
4475bec4
PE
1595 (dialog_selection_callback) [!USE_GTK]: Prefer intptr_t for integers
1596 the same widths as pointers. This follows up on the 2011-05-06 patch.
1597 * xterm.c (x_alloc_lighter_color_for_widget): Define only if USE_LUCID.
1598 * xterm.h: Likewise.
1599 (x_menu_set_in_use): Declare only if USE_GTK || USE_MOTIF.
1600
1384b89e
JB
16012011-06-12 Juanma Barranquero <lekktu@gmail.com>
1602
1603 * makefile.w32-in: Update dependencies.
1604 (LISP_H): Add lib/intprops.h.
1605
1100a63c
CY
16062011-06-11 Chong Yidong <cyd@stupidchicken.com>
1607
1608 * image.c (gif_load): Add animation frame delay to the metadata.
1609 (syms_of_image): Use DEFSYM. New symbol `delay'.
1610
6198ccd0
MR
16112011-06-11 Martin Rudalics <rudalics@gmx.at>
1612
1613 * window.c (delete_deletable_window): Re-add.
1614 (Fset_window_configuration): Rewrite to handle dead buffers and
1615 consequently deletable windows.
1616 (window_tree, Fwindow_tree): Remove. Supply functionality in
1617 window.el.
1618 (compare_window_configurations): Simplify code.
1619
b6e3633c
AS
16202011-06-11 Andreas Schwab <schwab@linux-m68k.org>
1621
1ab0dee5
AS
1622 * image.c (imagemagick_load_image): Fix type mismatch.
1623 (Fimagemagick_types): Likewise.
1624
b6e3633c
AS
1625 * window.h (replace_buffer_in_windows): Declare.
1626
9397e56f
MR
16272011-06-11 Martin Rudalics <rudalics@gmx.at>
1628
1629 * buffer.c: New Lisp objects Qbuffer_list_update_hook and
1630 Qclone_number. Remove external declaration of Qdelete_window.
1631 (Fbuffer_list): Rewrite doc-string. Minor restructuring of
1632 code.
1633 (Fget_buffer_create, Fmake_indirect_buffer, Frename_buffer): Run
1634 Qbuffer_list_update_hook if allowed.
1635 (Fother_buffer): Rewrite doc-string. Major rewrite for new
1636 buffer list implementation.
1637 (other_buffer_safely): New function.
1638 (Fkill_buffer): Replace call to replace_buffer_in_all_windows by
1639 calls to replace_buffer_in_windows and
1640 replace_buffer_in_windows_safely. Run Qbuffer_list_update_hook
1641 if allowed.
1642 (record_buffer): Inhibit quitting and rewrite using quittable
1643 functions. Run Qbuffer_list_update_hook if allowed.
1644 (Frecord_buffer, Funrecord_buffer): New functions.
1645 (switch_to_buffer_1, Fswitch_to_buffer): Remove. Move
1646 switch-to-buffer to window.el.
1647 (bury-buffer): Move to window.el.
1648 (Vbuffer_list_update_hook): New variable.
1649
1650 * lisp.h (other_buffer_safely): Add prototype in buffer.c
1651 section.
1652
1653 * window.h (resize_frame_windows): Move up in code.
1654 (Fwindow_frame): Remove EXFUN.
1655 (replace_buffer_in_all_windows): Remove prototype.
1656 (replace_buffer_in_windows_safely): Add prototype.
1657
1658 * window.c: Declare Qdelete_window static again. Move down
1659 declaration of select_count.
1660 (Fnext_window, Fprevious_window): Rewrite doc-strings.
1661 (Fother_window): Move to window.el.
1662 (window_loop): Remove DELETE_BUFFER_WINDOWS and UNSHOW_BUFFER
1663 cases. Add REPLACE_BUFFER_IN_WINDOWS_SAFELY case.
1664 (Fdelete_windows_on, Freplace_buffer_in_windows): Move to
1665 window.el.
1666 (replace_buffer_in_windows): Implement by calling
1667 Qreplace_buffer_in_windows.
1668 (replace_buffer_in_all_windows): Remove with some functionality
1669 moved into replace_buffer_in_windows_safely.
1670 (replace_buffer_in_windows_safely): New function.
1671 (select_window_norecord, select_frame_norecord): Move in front
1672 of run_window_configuration_change_hook. Remove now obsolete
1673 declarations.
1674 (Fset_window_buffer): Rewrite doc-string. Call
1675 Qrecord_window_buffer.
1676 (keys_of_window): Move binding for other-window to window.el.
1677
b50691aa
CY
16782011-06-11 Chong Yidong <cyd@stupidchicken.com>
1679
1680 * dispextern.h (struct image): Replace data member, whose int_val
1681 and ptr_val fields were not used by anything, with a single
1682 lisp_val object.
1683
1684 * image.c (Fimage_metadata, make_image, mark_image, tiff_load)
1685 (gif_clear_image, gif_load, imagemagick_load_image)
1686 (gs_clear_image, gs_load): Callers changed.
1687
3f754b86
PE
16882011-06-10 Paul Eggert <eggert@cs.ucla.edu>
1689
cca69397
PE
1690 * buffer.h: Include <time.h>, for time_t.
1691 Needed to build on FreeBSD 8.2. Problem reported by Herbert J. Skuhra.
1692
109e28d0
PE
1693 Fix minor problems found by static checking.
1694
60737f02
PE
1695 * image.c (PixelGetMagickColor): Declare if ImageMagick headers don't.
1696
4b66faf3
PE
1697 Make identifiers static if they are not used in other modules.
1698 * data.c (Qcompiled_function, Qframe, Qvector):
1699 * image.c (QimageMagick, Qsvg):
1700 * minibuf.c (Qmetadata):
1701 * window.c (resize_window_check, resize_root_window): Now static.
1702 * window.h (resize_window_check, resize_root_window): Remove decls.
1703
109e28d0
PE
1704 * window.c (window_deletion_count, delete_deletable_window):
1705 Remove; unused.
46a4ce9e
PE
1706 (window_body_lines): Now static.
1707 (Fdelete_other_windows_internal): Mark vars as initialized.
1708 Make sure 'resize_failed' is initialized.
1709 (run_window_configuration_change_hook): Rename local to avoid shadowing.
1710 (resize_window_apply): Remove unused local.
1711 * window.h (delete_deletable_window): Remove decl.
1712
109e28d0 1713 * image.c (gif_load, svg_load_image): Rename locals to avoid shadowing.
33290528
PE
1714 (imagemagick_load_image): Fix pointer signedness problem by changing
1715 last arg from unsigned char * to char *. All uses changed.
1716 Also, fix a local for similar reasons.
1717 Remove unused locals. Remove locals to avoid shadowing.
1718 (fn_rsvg_handle_free): Remove; unused.
1719 (svg_load, svg_load_image): Fix pointer signedness problem.
f7e13da3 1720 (imagemagick_load_image): Don't use garbage pointer image_wand.
33290528 1721
3f754b86
PE
1722 * ftfont.c (ftfont_get_metrics, ftfont_drive_otf): Remove unused locals.
1723
2547adb1
CY
17242011-06-10 Chong Yidong <cyd@stupidchicken.com>
1725
1726 * image.c (gif_load): Fix omitted cast error introduced by
1727 2011-06-06 change.
1728
2c8e37d4
MR
17292011-06-10 Martin Rudalics <rudalics@gmx.at>
1730
1731 * window.h (resize_proportionally, orig_total_lines)
1732 (orig_top_line): Remove from window structure.
1733 (set_window_height, set_window_width, change_window_heights)
1734 (Fdelete_window): Remove prototypes.
1735 (resize_frame_windows): Remove duplicate declaration.
1736
440a42e3
EZ
17372011-06-10 Eli Zaretskii <eliz@gnu.org>
1738
1739 * window.h (resize_frame_windows, resize_window_check)
1740 (delete_deletable_window, resize_root_window)
1741 (resize_frame_windows): Declare prototypes.
1742
1743 * window.c (resize_window_apply): Make definition be "static" to
1744 match the prototype.
1745
562dd5e9
MR
17462011-06-10 Martin Rudalics <rudalics@gmx.at>
1747
1748 * window.c: Remove declarations of Qwindow_size_fixed,
1749 window_min_size_1, window_min_size_2, window_min_size,
1750 size_window, window_fixed_size_p, enlarge_window, delete_window.
1751 Remove static from declaration of Qdelete_window, it's
1752 temporarily needed by Fbury_buffer.
1753 (replace_window): Don't assign orig_top_line and
1754 orig_total_lines.
1755 (Fdelete_window, delete_window): Remove. Window deletion is
1756 handled by window.el.
1757 (window_loop): Remove DELETE_OTHER_WINDOWS case. Replace
1758 Fdelete_window calls with calls to Qdelete_window.
1759 (Fdelete_other_windows): Remove. Deleting other windows is
1760 handled by window.el.
1761 (window_fixed_size_p): Remove. Fixed-sizeness of windows is
1762 handled in window.el.
1763 (window_min_size_2, window_min_size_1, window_min_size): Remove.
1764 Window minimum sizes are handled in window.el.
1765 (shrink_windows, size_window, set_window_height)
1766 (set_window_width, change_window_heights, window_height)
1767 (window_width, CURBEG, CURSIZE, enlarge_window)
1768 (adjust_window_trailing_edge, Fadjust_window_trailing_edge)
1769 (Fenlarge_window, Fshrink_window): Remove. Window resizing is
1770 handled in window.el.
1771 (make_dummy_parent): Rename to make_parent_window and give it a
1772 second argument horflag.
1773 (make_window): Don't set resize_proportionally any more.
1774 (Fsplit_window): Remove. Windows are split in window.el.
1775 (save_restore_action, save_restore_orig_size)
1776 (shrink_window_lowest_first, save_restore_orig_size): Remove.
1777 Resize mini windows in window.el.
1778 (grow_mini_window, shrink_mini_window): Implement by calling
1779 Qresize_root_window_vertically, resize_window_check and
1780 resize_window_apply.
1781 (saved_window, Fset_window_configuration, save_window_save): Do
1782 not handle orig_top_line, orig_total_lines, and
1783 resize_proportionally.
1784 (window_min_height, window_min_width): Move to window.el.
1785 (keys_of_window): Move bindings for delete-other-windows,
1786 split-window, delete-window and enlarge-window to window.el.
1787
1788 * buffer.c: Temporarily extern Qdelete_window.
1789 (Fbury_buffer): Temporarily call Qdelete_window instead of
1790 Fdelete_window (Fbury_buffer will move to window.el soon).
1791
1792 * frame.c (set_menu_bar_lines_1): Remove code handling
1793 orig_top_line and orig_total_lines.
1794
1795 * dispnew.c (adjust_frame_glyphs_initially): Don't use
1796 set_window_height but set heights directly.
1797 (change_frame_size_1): Use resize_frame_windows.
1798
1799 * xdisp.c (init_xdisp): Don't use set_window_height but set
1800 heights directly.
1801
1802 * xfns.c (x_set_menu_bar_lines, x_set_tool_bar_lines): Use
1803 resize_frame_windows instead of change_window_heights and run
1804 run_window_configuration_change_hook.
1805
1806 * w32fns.c (x_set_tool_bar_lines): Use resize_frame_windows
1807 instead of change_window_heights and run
1808 run_window_configuration_change_hook.
1809
1a13852e
MR
18102011-06-09 Martin Rudalics <rudalics@gmx.at>
1811
1812 * window.c (replace_window): Rename second argument REPLACEMENT to
1813 NEW. New third argument SETFLAG. Rewrite.
1814 (delete_window, make_dummy_parent): Call replace_window with
1815 third argument 1.
1816 (window_list_1): Move down in code.
1817 (run_window_configuration_change_hook): Move set_buffer part
1818 before select_frame_norecord part in order to unwind correctly.
1819 Rename count1 to count.
1820 (recombine_windows, delete_deletable_window, resize_root_window)
1821 (Fdelete_other_windows_internal)
1822 (Frun_window_configuration_change_hook, make_parent_window)
1823 (resize_window_check, resize_window_apply, Fresize_window_apply)
1824 (resize_frame_windows, Fsplit_window_internal)
1825 (Fdelete_window_internal, Fresize_mini_window_internal): New
1826 functions.
1827 (syms_of_window): New variables Vwindow_splits and Vwindow_nest.
1828
f3d1777e
MR
18292011-06-08 Martin Rudalics <rudalics@gmx.at>
1830
496e208e
MR
1831 * window.h (window): Add some new members to window structure -
1832 normal_lines, normal_cols, new_total, new_normal, clone_number,
1833 splits, nest, prev_buffers, next_buffers.
1834 (WINDOW_TOTAL_SIZE): Move here from window.c.
b9e809c2 1835 (MIN_SAFE_WINDOW_WIDTH, MIN_SAFE_WINDOW_HEIGHT): Define here.
496e208e 1836
f3d1777e
MR
1837 * window.c (Fwindow_height, Fwindow_width, Fwindow_full_width_p):
1838 Remove.
496e208e
MR
1839 (make_dummy_parent): Set new members of windows structure.
1840 (make_window): Move down in code. Handle new members of window
1841 structure.
1842 (Fwindow_clone_number, Fwindow_splits, Fset_window_splits)
1843 (Fwindow_nest, Fset_window_nest, Fwindow_new_total)
1844 (Fwindow_normal_size, Fwindow_new_normal, Fwindow_prev_buffers)
1845 (Fset_window_prev_buffers, Fwindow_next_buffers)
1846 (Fset_window_next_buffers, Fset_window_clone_number): New
1847 functions.
1848 (Fwindow_hscroll, Fwindow_at, Fwindow_point, Fwindow_start)
1849 (Fwindow_end, Fwindow_line_height, Fset_window_dedicated_p):
1850 Doc-string fixes.
1851 (Fwindow_parameters, Fwindow_parameter, Fset_window_parameter):
1852 Argument WINDOW can be now internal window too.
1853 (Fwindow_use_time): Move up in code.
1854 (Fget_buffer_window): Rename argument FRAME to ALL-FRAMES.
1855 Rewrite doc-string.
1856 (Fset_window_configuration, saved_window)
1857 (Fcurrent_window_configuration, save_window_save): Handle new
1858 members of window structure.
b9e809c2
MR
1859 (WINDOW_TOTAL_SIZE, MIN_SAFE_WINDOW_WIDTH)
1860 (MIN_SAFE_WINDOW_HEIGHT): Move to window.h.
1861 (syms_of_window): New Lisp objects Qrecord_window_buffer,
1862 Qwindow_deletable_p, Qdelete_window, Qreplace_buffer_in_windows,
1863 Qget_mru_window, Qresize_root_window,
1864 Qresize_root_window_vertically, Qsafe, Qabove, Qbelow,
1865 Qauto_buffer_name; staticpro them.
f3d1777e 1866
abde8f8c
MR
18672011-06-07 Martin Rudalics <rudalics@gmx.at>
1868
1869 * window.c (Fwindow_total_size, Fwindow_left_column)
1870 (Fwindow_top_line, window_body_lines, Fwindow_body_size)
1871 (Fwindow_list_1): New functions.
1872 (window_box_text_cols): Replace with window_body_cols.
1873 (Fwindow_width, Fscroll_left, Fscroll_right): Use
1874 window_body_cols instead of window_box_text_cols.
fa8a67e6
MR
1875 (delete_window, Fset_window_configuration): Call
1876 delete_all_subwindows with window as argument.
1877 (delete_all_subwindows): Take a window as argument and not a
1878 structure. Rewrite.
190b47e6
MR
1879 (window_loop): Remove handling of GET_LRU_WINDOW and
1880 GET_LARGEST_WINDOW.
1881 (Fget_lru_window, Fget_largest_window): Move to window.el.
abde8f8c
MR
1882
1883 * window.h: Extern window_body_cols instead of
fa8a67e6
MR
1884 window_box_text_cols. delete_all_subwindows now takes a
1885 Lisp_Object as argument.
abde8f8c
MR
1886
1887 * indent.c (compute_motion, Fcompute_motion): Use
1888 window_body_cols instead of window_box_text_cols.
1889
fa8a67e6
MR
1890 * frame.c (delete_frame): Call delete_all_subwindows with root
1891 window as argument.
1892
a54e3482
DC
18932011-06-07 Daniel Colascione <dan.colascione@gmail.com>
1894
1895 * fns.c (Fputhash): Document return value.
1896
60002bf5
CY
18972011-06-06 Chong Yidong <cyd@stupidchicken.com>
1898
1899 * image.c (gif_load): Implement gif89a spec "no disposal" method.
1900
0c671da6 19012011-06-06 Paul Eggert <eggert@cs.ucla.edu>
ccd9a01a 1902
b862a52a 1903 Cons<->int and similar integer overflow fixes (Bug#8794).
77984278 1904
be44ca6c
PE
1905 Check for overflow when converting integer to cons and back.
1906 * charset.c (Fdefine_charset_internal, Fdecode_char):
1907 Use cons_to_unsigned to catch overflow.
1908 (Fencode_char): Use INTEGER_TO_CONS.
1909 * composite.h (LGLYPH_CODE): Use cons_to_unsigned.
1910 (LGLYPH_SET_CODE): Use INTEGER_TO_CONS.
1911 * data.c (long_to_cons, cons_to_long): Remove.
1912 (cons_to_unsigned, cons_to_signed): New functions.
1913 These signal an error for invalid or out-of-range values.
1914 * dired.c (Ffile_attributes): Use INTEGER_TO_CONS.
1915 * fileio.c (Fset_visited_file_modtime): Use CONS_TO_INTEGER.
1916 * font.c (Ffont_variation_glyphs):
1917 * fontset.c (Finternal_char_font): Use INTEGER_TO_CONS.
1918 * lisp.h: Include <intprops.h>.
1919 (INTEGER_TO_CONS, CONS_TO_INTEGER): New macros.
1920 (cons_to_signed, cons_to_unsigned): New decls.
1921 (long_to_cons, cons_to_long): Remove decls.
1922 * undo.c (record_first_change): Use INTEGER_TO_CONS.
1923 (Fprimitive_undo): Use CONS_TO_INTEGER.
1924 * xfns.c (Fx_window_property): Likewise.
1925 * xselect.c: Include <limits.h>.
1926 (x_own_selection, selection_data_to_lisp_data):
1927 Use INTEGER_TO_CONS.
1928 (x_handle_selection_request, x_handle_selection_clear)
1929 (x_get_foreign_selection, Fx_disown_selection_internal)
1930 (Fx_get_atom_name, x_send_client_event): Use CONS_TO_INTEGER.
1931 (lisp_data_to_selection_data): Use cons_to_unsigned.
1932 (x_fill_property_data): Use cons_to_signed.
1933 Report values out of range.
1934
d1f3d2af
PE
1935 Check for buffer and string overflow more precisely.
1936 * buffer.h (BUF_BYTES_MAX): New macro.
1937 * lisp.h (STRING_BYTES_MAX): New macro.
1938 * alloc.c (Fmake_string):
1939 * character.c (string_escape_byte8):
1940 * coding.c (coding_alloc_by_realloc):
1941 * doprnt.c (doprnt):
1942 * editfns.c (Fformat):
1943 * eval.c (verror):
1944 Use STRING_BYTES_MAX, not MOST_POSITIVE_FIXNUM,
1945 since they may not be the same number.
1946 * editfns.c (Finsert_char):
1947 * fileio.c (Finsert_file_contents):
1948 Likewise for BUF_BYTES_MAX.
1949
dd52fcea
PE
1950 * image.c: Use ptrdiff_t, not int, for sizes.
1951 (slurp_file): Switch from int to ptrdiff_t.
1952 All uses changed.
1953 (slurp_file): Check that file size fits in both size_t (for
1954 malloc) and ptrdiff_t (for sanity and safety).
1955
7f9bbdbb
PE
1956 * fileio.c (Fverify_visited_file_modtime): Avoid time overflow
1957 if b->modtime has its maximal value.
1958
dfe18f82
PE
1959 * dired.c (Ffile_attributes): Don't assume EMACS_INT has >32 bits.
1960
84acfcf0
PE
1961 Don't assume time_t can fit into int.
1962 * buffer.h (struct buffer.modtime): Now time_t, not int.
1963 * fileio.c (Fvisited_file_modtime): No need for time_t cast now.
1964 * undo.c (Fprimitive_undo): Use time_t, not int, for time_t value.
1965
ccd9a01a
PE
1966 Minor fixes for signed vs unsigned integers.
1967 * character.h (MAYBE_UNIFY_CHAR):
1968 * charset.c (maybe_unify_char):
1969 * keyboard.c (read_char, reorder_modifiers):
1970 XINT -> XFASTINT, since the integer must be nonnegative.
1971 * ftfont.c (ftfont_spec_pattern):
1972 * keymap.c (access_keymap, silly_event_symbol_error):
1973 XUINT -> XFASTINT, since the integer must be nonnegative.
1974 (Fsingle_key_description, preferred_sequence_p): XUINT -> XINT,
1975 since it makes no difference and we prefer signed.
1976 * keyboard.c (record_char): Use XUINT when all the neighbors do.
1977 (access_keymap): NATNUMP -> INTEGERP, since the integer must be
1978 nonnegative.
1979
d6d100dd
SM
19802011-06-06 Stefan Monnier <monnier@iro.umontreal.ca>
1981
1982 * window.h (Fwindow_frame): Declare.
1983
2b6148e4
PE
19842011-06-06 Paul Eggert <eggert@cs.ucla.edu>
1985
1986 * alloc.c: Simplify handling of large-request failures (Bug#8800).
1987 (SPARE_MEMORY): Always define.
1988 (LARGE_REQUEST): Remove.
1989 (memory_full): Use SPARE_MEMORY rather than LARGE_REQUEST.
1990
f230ecc9
MR
19912011-06-06 Martin Rudalics <rudalics@gmx.at>
1992
727e958e
MR
1993 * lisp.h: Move EXFUNS for Fframe_root_window,
1994 Fframe_first_window and Fset_frame_selected_window to window.h.
1995
1996 * window.h: Move EXFUNS for Fframe_root_window,
1997 Fframe_first_window and Fset_frame_selected_window here from
1998 lisp.h.
1999
2000 * frame.c (Fwindow_frame, Fframe_first_window)
2001 (Fframe_root_window, Fframe_selected_window)
2002 (Fset_frame_selected_window): Move to window.c.
2003 (Factive_minibuffer_window): Move to minibuf.c.
2004 (Fother_visible_frames_p): New function.
2005
2006 * minibuf.c (Factive_minibuffer_window): Move here from frame.c.
2007
f230ecc9
MR
2008 * window.c (decode_window, decode_any_window): Move up in code.
2009 (Fwindowp, Fwindow_live_p): Rewrite doc-strings.
2010 (inhibit_frame_unsplittable): Remove unused variable.
bf60a96b
MR
2011 (Fwindow_buffer): Move up and rewrite doc-string.
2012 (Fwindow_parent, Fwindow_vchild, Fwindow_hchild, Fwindow_next)
2013 (Fwindow_prev): New functions.
727e958e
MR
2014 (Fwindow_frame): Move here from frame.c. Accept any window as
2015 argument.
2016 (Fframe_root_window, Fframe_first_window)
2017 (Fframe_selected_window): Move here from frame.c. Accept frame
2018 or arbitrary window as argument. Update doc-strings.
2019 (Fminibuffer_window): Move up in code.
2020 (Fwindow_minibuffer_p): Move up in code and simplify.
d6d100dd
SM
2021 (Fset_frame_selected_window): Move here from frame.c.
2022 Marginal rewrite.
727e958e
MR
2023 (Fselected_window, select_window, Fselect_window): Move up in
2024 code. Minor doc-string fixes.
f230ecc9 2025
4d09bcf6
PE
20262011-06-06 Paul Eggert <eggert@cs.ucla.edu>
2027
2028 * alloc.c (memory_full) [SYSTEM_MALLOC]: Port to MacOS (Bug#8800).
2029 Do not assume that spare memory exists; that assumption is valid
2030 only if SYSTEM_MALLOC.
2031 (LARGE_REQUEST): New macro, so that the issue of large requests
2032 is separated from the issue of spare memory.
2033
810928a2
AS
20342011-06-05 Andreas Schwab <schwab@linux-m68k.org>
2035
172418ad
AS
2036 * editfns.c (Fformat): Correctly handle zero flag with hexadecimal
2037 format. (Bug#8806)
2038
43f862f7
AS
2039 * gtkutil.c (xg_get_default_scrollbar_width): Avoid warning.
2040
810928a2
AS
2041 * xfns.c (x_set_scroll_bar_default_width): Move declarations
2042 before statements.
2043
a059fe24
JD
20442011-06-05 Jan Djärv <jan.h.d@swipnet.se>
2045
2046 * gtkutil.c (xg_get_default_scrollbar_width): New function.
2047
2048 * gtkutil.h: Declare xg_get_default_scrollbar_width.
2049
2050 * xfns.c (x_set_scroll_bar_default_width): If USE_GTK, get
2051 min width by calling x_set_scroll_bar_default_width (Bug#8505).
2052
989bf368
JB
20532011-06-05 Juanma Barranquero <lekktu@gmail.com>
2054
2055 * xdisp.c (single_display_spec_intangible_p): Remove declaration.
2056
4b80f674
CY
20572011-06-04 Chong Yidong <cyd@stupidchicken.com>
2058
2059 * xselect.c (x_clipboard_manager_save): Remove redundant arg.
2060 (x_clipboard_manager_save): Add return value.
d6d100dd
SM
2061 (x_clipboard_manager_error_1, x_clipboard_manager_error_2):
2062 New error handlers.
4b80f674
CY
2063 (x_clipboard_manager_save_frame, x_clipboard_manager_save_all):
2064 Obey Vx_select_enable_clipboard_manager. Catch errors in
2065 x_clipboard_manager_save (Bug#8779).
2066 (Vx_select_enable_clipboard_manager): New variable.
de65b42c 2067 (x_get_foreign_selection): Reduce scope of x_catch_errors (Bug#8790).
4b80f674 2068
99a33b77 20692011-06-04 Dan Nicolaescu <dann@ics.uci.edu>
8b3115e7
DN
2070
2071 * emacs.c (main): Warn when starting a GTK emacs in daemon mode.
2072
99a33b77 20732011-06-04 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
14eca62f
YM
2074
2075 * fringe.c (update_window_fringes): Don't update overlay arrow bitmap
2076 in the current matrix if keep_current_p is non-zero.
2077
8264569d
EZ
20782011-06-04 Eli Zaretskii <eliz@gnu.org>
2079
2080 * bidi.c (bidi_level_of_next_char): Fix last change.
2081
57f97249
EZ
20822011-06-03 Eli Zaretskii <eliz@gnu.org>
2083
fec2107c 2084 Support bidi reordering of text covered by display properties.
57f97249 2085
fec2107c
EZ
2086 * bidi.c (bidi_copy_it): Use offsetof instead of emulating it.
2087 (bidi_fetch_char, bidi_fetch_char_advance): New functions.
2088 (bidi_cache_search, bidi_cache_iterator_state)
2089 (bidi_paragraph_init, bidi_resolve_explicit, bidi_resolve_weak)
d6d100dd
SM
2090 (bidi_level_of_next_char, bidi_move_to_visually_next):
2091 Support character positions inside a run of characters covered by a
fec2107c
EZ
2092 display string.
2093 (bidi_paragraph_init, bidi_resolve_explicit_1)
2094 (bidi_level_of_next_char): Call bidi_fetch_char and
2095 bidi_fetch_char_advance instead of FETCH_CHAR and
2096 FETCH_CHAR_ADVANCE.
2097 (bidi_init_it): Initialize new members.
2098 (LRE_CHAR, RLE_CHAR, PDF_CHAR, LRO_CHAR, RLO_CHAR): Remove macro
2099 definitions.
2100 (bidi_explicit_dir_char): Lookup character type in bidi_type_table,
2101 instead of using explicit *_CHAR codes.
d6d100dd
SM
2102 (bidi_resolve_explicit, bidi_resolve_weak):
2103 Use FETCH_MULTIBYTE_CHAR instead of FETCH_CHAR, as reordering of
fec2107c
EZ
2104 bidirectional text is supported only in multibyte buffers.
2105 (bidi_init_it): Accept additional argument FRAME_WINDOW_P and use
2106 it to initialize the frame_window_p member of struct bidi_it.
2107 (bidi_cache_iterator_state, bidi_resolve_explicit_1)
2108 (bidi_resolve_explicit, bidi_resolve_weak)
2109 (bidi_level_of_next_char, bidi_move_to_visually_next): Abort if
2110 bidi_it->nchars is non-positive.
2111 (bidi_level_of_next_char): Don't try to lookup the cache for the
2112 next/previous character if nothing is cached there yet, or if we
2113 were just reseat()'ed to a new position.
c40e2fb2 2114
0e14fe90
EZ
2115 * xdisp.c (set_cursor_from_row): Set start and stop points
2116 according to the row's direction when priming the loop that looks
2117 for the glyph on which to display cursor.
2118 (single_display_spec_intangible_p): Function deleted.
2119 (display_prop_intangible_p): Reimplement to call
2120 handle_display_spec instead of single_display_spec_intangible_p.
d6d100dd
SM
2121 Accept 3 additional arguments needed by handle_display_spec.
2122 This fixes incorrect cursor motion across display property with complex
0e14fe90
EZ
2123 values: lists, `(when COND...)' forms, etc.
2124 (single_display_spec_string_p): Support property values that are
2125 lists with the argument STRING its top-level element.
2126 (display_prop_string_p): Fix the condition for processing a
2127 property that is a list to be consistent with handle_display_spec.
fec2107c 2128 (handle_display_spec): New function, refactored from the
fc6f18ce
EZ
2129 last portion of handle_display_prop.
2130 (compute_display_string_pos): Accept additional argument
2131 FRAME_WINDOW_P. Call handle_display_spec to determine whether the
2132 value of a `display' property is a "replacing spec".
2133 (handle_single_display_spec): Accept 2 additional arguments BUFPOS
2134 and FRAME_WINDOW_P. If IT is NULL, don't set up the iterator from
2135 the display property, but just return a value indicating whether
2136 the display property will replace the characters it covers.
2137 (Fcurrent_bidi_paragraph_direction): Initialize the nchars and
2138 frame_window_p members of struct bidi_it.
d6d100dd
SM
2139 (compute_display_string_pos, compute_display_string_end):
2140 New functions.
fec2107c
EZ
2141 (push_it): Accept second argument POSITION, where pop_it should
2142 jump to continue iteration.
2143 (reseat_1): Initialize bidi_it.disp_pos.
fc6f18ce 2144
fec2107c
EZ
2145 * keyboard.c (adjust_point_for_property): Adjust the call to
2146 display_prop_intangible_p to its new signature.
fc6f18ce
EZ
2147
2148 * dispextern.h (struct bidi_it): New member frame_window_p.
fec2107c
EZ
2149 (bidi_init_it): Update prototypes.
2150 (display_prop_intangible_p): Update prototype.
d6d100dd
SM
2151 (compute_display_string_pos, compute_display_string_end):
2152 Declare prototypes.
fec2107c
EZ
2153 (struct bidi_it): New members nchars and disp_pos. ch_len is now
2154 EMACS_INT.
fc6f18ce 2155
40087514 21562011-06-02 Paul Eggert <eggert@cs.ucla.edu>
0de4bb68 2157
57f53182
PE
2158 Malloc failure behavior now depends on size of allocation.
2159 * alloc.c (buffer_memory_full, memory_full): New arg NBYTES.
2160 * lisp.h: Change signatures accordingly.
2161 * alloc.c, buffer.c, editfns.c, menu.c, minibuf.c, xterm.c:
2162 All callers changed. (Bug#8762)
2163
2164 * gnutls.c: Use Emacs's memory allocators.
2165 Without this change, the gnutls library would invoke malloc etc.
2166 directly, which causes problems on non-SYNC_INPUT hosts, and which
2167 runs afoul of improving memory_full behavior. (Bug#8761)
2168 (fn_gnutls_global_set_mem_functions): New macro or function pointer.
2169 (emacs_gnutls_global_init): Use it to specify xmalloc, xrealloc,
2170 xfree instead of the default malloc, realloc, free.
2171 (Fgnutls_boot): No need to check for memory allocation failure,
2172 since xmalloc does that for us.
2173
ac32cd99 2174 Remove arbitrary limit of 2**31 entries in hash tables. (Bug#8771)
3870d916
PE
2175 * category.c (hash_get_category_set):
2176 * ccl.c (ccl_driver):
2177 * charset.c (Fdefine_charset_internal):
2178 * charset.h (struct charset.hash_index):
2179 * composite.c (get_composition_id, gstring_lookup_cache)
2180 (composition_gstring_put_cache):
2181 * composite.h (struct composition.hash_index):
2182 * dispextern.h (struct image.hash):
2183 * fns.c (next_almost_prime, larger_vector, cmpfn_eql)
2184 (cmpfn_equal, cmpfn_user_defined, hashfn_eq, hashfn_eql)
2185 (hashfn_equal, hashfn_user_defined, make_hash_table)
2186 (maybe_resize_hash_table, hash_lookup, hash_put)
2187 (hash_remove_from_table, hash_clear, sweep_weak_table, SXHASH_COMBINE)
2188 (sxhash_string, sxhash_list, sxhash_vector, sxhash_bool_vector)
2189 (Fsxhash, Fgethash, Fputhash, Fmaphash):
2190 * image.c (make_image, search_image_cache, lookup_image)
2191 (xpm_put_color_table_h):
2192 * lisp.h (struct Lisp_Hash_Table):
0de4bb68 2193 * minibuf.c (Ftry_completion, Fall_completions, Ftest_completion):
ac389d0c 2194 * print.c (print): Use 'EMACS_UINT' and 'EMACS_INT'
3870d916 2195 for hashes and hash indexes, instead of 'unsigned' and 'int'.
40087514
PE
2196 * alloc.c (allocate_vectorlike):
2197 Check for overflow in vector size calculations.
2198 * ccl.c (ccl_driver):
2199 Check for overflow when converting EMACS_INT to int.
0de4bb68
PE
2200 * fns.c, image.c: Remove unnecessary static decls that would otherwise
2201 need to be updated by these changes.
40087514
PE
2202 * fns.c (make_hash_table, maybe_resize_hash_table):
2203 Check for integer overflow with large hash tables.
0de4bb68
PE
2204 (make_hash_table, maybe_resize_hash_table, Fmake_hash_table):
2205 Prefer the faster XFLOAT_DATA to XFLOATINT where either will do.
2206 (SXHASH_REDUCE): New macro.
2207 (sxhash_string, sxhash_list, sxhash_vector, sxhash_bool_vector):
2208 Use it instead of discarding useful hash info with large hash values.
2209 (sxhash_float): New function.
2210 (sxhash): Use it. No more need for "& INTMASK" due to above changes.
2211 * lisp.h (FIXNUM_BITS): New macro, useful for SXHASH_REDUCE etc.
40087514
PE
2212 (MOST_NEGATIVE_FIXNUM, MOST_POSITIVE_FIXNUM, INTMASK):
2213 Rewrite to use FIXNUM_BITS, as this simplifies things.
0de4bb68
PE
2214 (next_almost_prime, larger_vector, sxhash, hash_lookup, hash_put):
2215 Adjust signatures to match updated version of code.
2216 (consing_since_gc): Now EMACS_INT, since a single hash table can
2217 use more than INT_MAX bytes.
2218
698d32e2
DN
22192011-06-01 Dan Nicolaescu <dann@ics.uci.edu>
2220
2221 Make it possible to build with GCC-4.6+ -O2 -flto.
2222
2223 * emacs.c (__malloc_initialize_hook): Mark as EXTERNALLY_VISIBLE.
2224
fd6fa53f
SM
22252011-06-01 Stefan Monnier <monnier@iro.umontreal.ca>
2226
2227 * minibuf.c (get_minibuffer, read_minibuf_unwind):
2228 Call minibuffer-inactive-mode.
2229
864db017
JB
22302011-05-31 Juanma Barranquero <lekktu@gmail.com>
2231
2232 * makefile.w32-in ($(BLD)/data.$(O), $(BLD)/editfns.$(O)):
2233 Update dependencies.
2234
2ad0baf4
DN
22352011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
2236
2237 * data.c (init_data): Remove code for UTS, this system is not
2238 supported anymore.
2239
4fcc2638
DN
22402011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
2241
2242 Don't force ./temacs to start in terminal mode.
2243
2244 * frame.c (make_initial_frame): Initialize faces in all cases, not
2245 only when CANNOT_DUMP is defined.
2246 * dispnew.c (init_display): Remove CANNOT_DUMP condition.
2247
c56e0fd5
DN
22482011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
2249
2250 * dispnew.c (add_window_display_history): Use const for the string
2251 pointer. Remove declaration, not needed.
2252
333d54da 22532011-05-31 Paul Eggert <eggert@cs.ucla.edu>
9cf9f756 2254
55d4c1b2 2255 Use 'inline', not 'INLINE'.
333d54da 2256 <http://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00914.html>
55d4c1b2
PE
2257 * alloc.c, fontset.c (INLINE): Remove.
2258 * alloc.c, bidi.c, charset.c, coding.c, dispnew.c, fns.c, image.c:
2259 * intervals.c, keyboard.c, process.c, syntax.c, textprop.c, w32term.c:
2260 * xdisp.c, xfaces.c, xterm.c: Replace all uses of INLINE with inline.
2261 * gmalloc.c (register_heapinfo): Use inline unconditionally.
2262 * lisp.h (LISP_MAKE_RVALUE): Use inline, not __inline__.
2263
738db178
DN
22642011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
2265
2266 Make it possible to run ./temacs.
2267
2268 * callproc.c (set_initial_environment): Remove CANNOT_DUMP code,
2269 syms_of_callproc does the same thing. Remove test for
2270 "initialized", do it in the caller.
2271 * emacs.c (main): Avoid calling set_initial_environment when dumping.
2272
620c53a6
SM
22732011-05-31 Stefan Monnier <monnier@iro.umontreal.ca>
2274
2275 * minibuf.c (Finternal_complete_buffer): Return `category' metadata.
2276 (read_minibuf): Use get_minibuffer.
2277 (syms_of_minibuf): Use DEFSYM.
2278 (Qmetadata): New var.
2279 * data.c (Qbuffer): Don't make it static.
2280 (syms_of_data): Use DEFSYM.
2281
e003a292
PE
22822011-05-31 Paul Eggert <eggert@cs.ucla.edu>
2283
2284 * ccl.c (CCL_CODE_RANGE): Allow negative numbers. (Bug#8751)
2285 (CCL_CODE_MIN): New macro.
2286
ed008a6d
PE
22872011-05-30 Paul Eggert <eggert@cs.ucla.edu>
2288
3687c2ef
PE
2289 * alloc.c (lisp_align_malloc): Omit unnecessary val==NULL tests.
2290
ed008a6d
PE
2291 * eval.c (Qdebug): Now static.
2292 * lisp.h (Qdebug): Remove decl. This reverts a part of the
2293 2011-04-26T11:26:05Z!dan.colascione@gmail.com that inadvertently undid part of
2294 2011-04-14T06:48:41Z!eggert@cs.ucla.edu.
2295
d66c4c7c
CY
22962011-05-29 Chong Yidong <cyd@stupidchicken.com>
2297
2298 * image.c: Various fixes to ImageMagick code comments.
2299 (Fimagemagick_types): Doc fix.
2300
5fbc2025
PE
23012011-05-29 Paul Eggert <eggert@cs.ucla.edu>
2302
0196f88a
PE
2303 Minor fixes prompted by GCC 4.6.0 warnings.
2304
2305 * xselect.c (converted_selections, conversion_fail_tag): Now static.
2306
5fbc2025
PE
2307 * emacs.c [HAVE_X_WINDOWS]: Include "xterm.h".
2308 (x_clipboard_manager_save_all): Move extern decl to ...
2309 * xterm.h: ... here, so that it can be checked for consistency.
2310
1dd3c2d9
CY
23112011-05-29 Chong Yidong <cyd@stupidchicken.com>
2312
2313 * xselect.c (x_clipboard_manager_save_frame)
2314 (x_clipboard_manager_save_all): New functions.
2315 (Fx_clipboard_manager_save): Lisp function deleted.
2316
2317 * emacs.c (Fkill_emacs): Call x_clipboard_manager_save_all.
2318 * frame.c (delete_frame): Call x_clipboard_manager_save_frame.
2319
2320 * xterm.h: Update prototype.
2321
5ba6571d
WX
23222011-05-28 William Xu <william.xwl@gmail.com>
2323
2324 * nsterm.m (ns_term_shutdown): Synchronize user defaults before
2325 exiting (Bug#8239).
2326
3eaff834
JM
23272011-05-28 Jim Meyering <meyering@redhat.com>
2328
e1900994 2329 Avoid a sign-extension bug in crypto_hash_function.
3eaff834
JM
2330 * fns.c (to_uchar): Define.
2331 (crypto_hash_function): Use it to convert some newly-signed
2332 variables to unsigned, to avoid sign-extension bugs. For example,
2333 without this change, (md5 "truc") would evaluate to
2334 45723a2aff78ff4fff7fff1114760e62 rather than the expected
2335 45723a2af3788c4ff17f8d1114760e62. Reported by Antoine Levitt in
e1900994 2336 https://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00883.html.
3eaff834 2337
0f6990a7
PE
23382011-05-27 Paul Eggert <eggert@cs.ucla.edu>
2339
2340 Integer overflow fixes.
c8a9ca5a 2341
08686060
PE
2342 * dbusbind.c: Serial number integer overflow fixes.
2343 (CHECK_DBUS_SERIAL_GET_SERIAL): New macro.
08686060
PE
2344 (Fdbus_call_method_asynchronously, xd_read_message_1): Use a float
2345 to hold a serial number that is too large for a fixnum.
2346 (Fdbus_method_return_internal, Fdbus_method_error_internal):
2347 Check for serial numbers out of range. Decode any serial number
59568bf0 2348 that was so large that it became a float. (Bug#8722)
08686060 2349
2d1fc3c7
PE
2350 * dbusbind.c: Use XFASTINT rather than XUINT, and check for nonneg.
2351 (Fdbus_call_method, Fdbus_call_method_asynchronously):
2352 Use XFASTINT rather than XUINT when numbers are nonnegative.
2353 (xd_append_arg, Fdbus_method_return_internal):
2354 (Fdbus_method_error_internal): Likewise. Also, for unsigned
2355 arguments, check that Lisp number is nonnegative, rather than
59568bf0 2356 silently wrapping negative numbers around. (Bug#8722)
30217ff0 2357 (xd_read_message_1): Don't assume dbus_uint32_t can fit in int.
59568bf0 2358 (Bug#8722)
2d1fc3c7 2359
c8a9ca5a
PE
2360 * data.c (arith_driver, Flsh): Avoid unnecessary casts to EMACS_UINT.
2361
519e1d69
PE
2362 * ccl.c (ccl_driver): Redo slightly to avoid the need for 'unsigned'.
2363
30569699
PE
2364 ccl: add integer overflow checks
2365 * ccl.c (CCL_CODE_MAX, GET_CCL_RANGE, GET_CCL_CODE, GET_CCL_INT):
2366 (IN_INT_RANGE): New macros.
2367 (ccl_driver): Use them to check for integer overflow when
2368 decoding a CCL program. Many of the new checks are whether XINT (x)
2369 fits in int; it doesn't always, on 64-bit hosts. The new version
2370 doesn't catch all possible integer overflows, but it's an
847044ea 2371 improvement. (Bug#8719)
30569699 2372
c11285dc
PE
2373 * alloc.c (make_event_array): Use XINT, not XUINT.
2374 There's no need for unsigned here.
2375
fdccd48e
PE
2376 * mem-limits.h (EXCEEDS_LISP_PTR) [!USE_LSB_TAG]: EMACS_UINT -> uintptr_t
2377 This follows up to the 2011-05-06 change that substituted uintptr_t
2378 for EMACS_INT. This case wasn't caught back then.
2379
37910ab2
PE
2380 Rework Fformat to avoid integer overflow issues.
2381 * editfns.c: Include <float.h> unconditionally, as it's everywhere
2382 now (part of C89). Include <verify.h>.
2383 (MAX_10_EXP, CONVERTED_BYTE_SIZE): Remove; no longer needed.
2384 (pWIDE, pWIDElen, signed_wide, unsigned_wide): New defns.
2385 (Fformat): Avoid the prepass trying to compute sizes; it was only
2386 approximate and thus did not catch overflow reliably. Instead, walk
2387 through the format just once, formatting and computing sizes as we go,
2388 checking for integer overflow at every step, and allocating a larger
2389 buffer as needed. Keep track separately whether the format is
2390 multibyte. Keep only the most-recently calculated precision, rather
2391 than them all. Record whether each argument has been converted to
2392 string. Use EMACS_INT, not int, for byte and char and arg counts.
2393 Support field widths and precisions larger than INT_MAX. Avoid
2394 sprintf's undefined behavior with conversion specifications such as %#d
2395 and %.0c. Fix bug with strchr succeeding on '\0' when looking for
2396 flags. Fix bug with (format "%c" 256.0). Avoid integer overflow when
2397 formatting out-of-range floating point numbers with int
9173deec 2398 formats. (Bug#8668)
37910ab2 2399
2e6578fb
PE
2400 * lisp.h (FIXNUM_OVERFLOW_P): Work even if arg is a NaN.
2401
0ae6bdee
PE
2402 * data.c: Avoid integer truncation in expressions involving floats.
2403 * data.c: Include <intprops.h>.
2404 (arith_driver): When there's an integer overflow in an expression
2405 involving floating point, convert the integers to floating point
2406 so that the resulting value does not suffer from catastrophic
2407 integer truncation. For example, on a 64-bit host (* 4
2408 most-negative-fixnum 0.5) should yield about -4.6e+18, not zero.
2409 Do not rely on undefined behavior after integer overflow.
2410
de883a70
PE
2411 merge count_size_as_multibyte, parse_str_to_multibyte
2412 * character.c, character.h (count_size_as_multibyte):
fd6fa53f 2413 Rename from parse_str_to_multibyte; all uses changed.
de883a70
PE
2414 Check for integer overflow.
2415 * insdel.c, lisp.h (count_size_as_multibyte): Remove,
2416 since it's now a duplicate of the other. This is more of
2417 a character than a buffer op, so better that it's in character.c.
2418 * fns.c, print.c: Adjust to above changes.
2419
2ff916cb
PE
24202011-05-27 Stefan Monnier <monnier@iro.umontreal.ca>
2421
2422 * xselect.c (x_convert_selection): Yet another int/Lisp_Object mixup.
2423
f1b54466
PE
24242011-05-27 Paul Eggert <eggert@cs.ucla.edu>
2425
fb1ac845
PE
2426 * xselect.c: Fix minor problems prompted by GCC 4.6.0 warnings.
2427 (x_handle_selection_request, frame_for_x_selection): Remove unused vars.
2428 (x_clipboard_manager_save): Now static.
2429 (Fx_clipboard_manager_save): Rename local to avoid shadowing.
2430
f1b54466
PE
2431 * fns.c: Fix minor problems prompted by GCC 4.6.0 warnings.
2432 (crypto_hash_function): Now static.
2433 Fix pointer signedness problems. Avoid unnecessary initializations.
2434
a9f737ee
CY
24352011-05-27 Chong Yidong <cyd@stupidchicken.com>
2436
2437 * termhooks.h (Vselection_alist): Make it terminal-local.
2438
2439 * terminal.c (create_terminal): Initialize it.
2440
2441 * xselect.c: Support for clipboard managers.
2442 (Vselection_alist): Move to termhooks.h as terminal-local var.
2443 (LOCAL_SELECTION): New macro.
2444 (x_atom_to_symbol): Handle x_display_info_for_display fail case.
2445 (symbol_to_x_atom): Remove gratuitous arg.
2446 (x_handle_selection_request, lisp_data_to_selection_data)
2447 (x_get_foreign_selection, Fx_register_dnd_atom): Callers changed.
620c53a6
SM
2448 (x_own_selection, x_get_local_selection, x_convert_selection):
2449 New arg, specifying work frame. Use terminal-local Vselection_alist.
a9f737ee
CY
2450 (some_frame_on_display): Delete unused function.
2451 (Fx_own_selection_internal, Fx_get_selection_internal)
2452 (Fx_disown_selection_internal, Fx_selection_owner_p)
2453 (Fx_selection_exists_p): New optional frame arg.
2454 (frame_for_x_selection, Fx_clipboard_manager_save): New functions.
2455 (x_handle_selection_clear): Don't treat other terminals with the
2456 same keyboard specially. Use the terminal-local Vselection_alist.
2457 (x_clear_frame_selections): Use Frun_hook_with_args.
2458
2459 * xterm.c (x_term_init): Intern ATOM and CLIPBOARD_MANAGER atoms.
2460
2461 * xterm.h: Add support for those atoms.
2462
e067f0c1
CY
24632011-05-26 Chong Yidong <cyd@stupidchicken.com>
2464
2465 * xselect.c: ICCCM-compliant handling of MULTIPLE targets.
2466 (converted_selections, conversion_fail_tag): New global variables.
2467 (x_selection_request_lisp_error): Free the above.
2468 (x_get_local_selection): Remove unnecessary code.
2469 (x_reply_selection_request): Args changed; handle arbitrary array
620c53a6
SM
2470 of converted selections stored in converted_selections.
2471 Separate the XChangeProperty and SelectionNotify steps.
e067f0c1
CY
2472 (x_handle_selection_request): Rewrite to handle MULTIPLE target.
2473 (x_convert_selection): New function.
2474 (x_handle_selection_event): Simplify.
2475 (x_get_foreign_selection): Don't ignore incoming requests while
2476 waiting for an answer; this will fail when we implement
2477 SAVE_TARGETS, and seems unnecessary anyway.
2478 (selection_data_to_lisp_data): Recognize ATOM_PAIR type.
2479 (Vx_sent_selection_functions): Doc fix.
2480
0f4aebc0
LL
24812011-05-26 Leo Liu <sdl.web@gmail.com>
2482
2483 * editfns.c (Ftranspose_regions): Allow empty regions. (Bug#8699)
2484
e61124cd
YM
24852011-05-25 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
2486
2487 * dispextern.h (struct glyph_row): New member fringe_bitmap_periodic_p.
2488
2489 * dispnew.c (shift_glyph_matrix, scrolling_window): Mark scrolled row
2490 for fringe update if it has periodic bitmap.
ac389d0c 2491 (row_equal_p): Also compare left_fringe_offset, right_fringe_offset,
e61124cd
YM
2492 and fringe_bitmap_periodic_p.
2493
2494 * fringe.c (get_fringe_bitmap_data): New function.
2495 (draw_fringe_bitmap_1, update_window_fringes): Use it.
2496 (update_window_fringes): Record periodicity of fringe bitmap in glyph
2497 row. Mark glyph row for fringe update if periodicity changed.
2498
2499 * xdisp.c (try_window_reusing_current_matrix): Don't mark scrolled row
2500 for fringe update unless it has periodic bitmap.
2501
f16d9837
KH
25022011-05-25 Kenichi Handa <handa@m17n.org>
2503
2504 * xdisp.c (get_next_display_element): Set correct it->face_id for
2505 a static composition.
2506
e1b90ef6
LL
25072011-05-24 Leo Liu <sdl.web@gmail.com>
2508
2509 * deps.mk (fns.o):
2510 * makefile.w32-in ($(BLD)/fns.$(O)): Include sha1.h.
2511
2512 * fns.c (crypto_hash_function, Fsha1): New function.
2513 (Fmd5): Use crypto_hash_function.
2514 (syms_of_fns): Add Ssha1.
2515
7400048f
PE
25162011-05-22 Paul Eggert <eggert@cs.ucla.edu>
2517
2518 * gnutls.c: Remove unused macros.
2519 (fn_gnutls_transport_set_lowat, fn_gnutls_transport_set_pull_function):
2520 (fn_gnutls_transport_set_push_function) [!WINDOWSNT]:
2521 Remove macros that are defined and never used.
2522 Caught by gcc -Wunused-macros (GCC 4.6.0, Fedora 14).
2523
abb71cf4
CY
25242011-05-22 Chong Yidong <cyd@stupidchicken.com>
2525
2526 * xselect.c (syms_of_xselect): Remove unused symbol SAVE_TARGETS.
2527 (Fx_get_selection_internal): Minor cleanup.
2528 (Fx_own_selection_internal): Rename arguments for consistency with
2529 select.el.
2530
6307db39
PE
25312011-05-22 Paul Eggert <eggert@cs.ucla.edu>
2532
2533 * xselect.c (QSAVE_TARGETS): New static var, to fix build failure.
2534
f3d4e0a4
CY
25352011-05-22 Chong Yidong <cyd@stupidchicken.com>
2536
2537 * xselect.c (syms_of_xselect): Include character.h; use DEFSYM.
2538
4d8ade89
YM
25392011-05-21 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
2540
2541 * dispnew.c (scrolling_window): Don't exclude the case that the
2542 last enabled row in the desired matrix touches the bottom boundary.
2543
32078c8d
GM
25442011-05-21 Glenn Morris <rgm@gnu.org>
2545
2546 * Makefile.in ($(etc)/DOC): Make second command line even shorter.
33cf345f
GM
2547 (SOME_MACHINE_OBJECTS): Replace FONT_OBJ by its maximal expansion,
2548 and add some more files.
32078c8d 2549
7285dc67
EZ
25502011-05-20 Eli Zaretskii <eliz@gnu.org>
2551
2552 * callproc.c (Fcall_process) [MSDOS]: Fix arguments to
2553 report_file_error introduced by the change from 2011-05-07.
2554
89d1bd22
PE
25552011-05-20 Paul Eggert <eggert@cs.ucla.edu>
2556
2557 * systime.h (Time): Define only if emacs is defined.
2558 This is to allow ../lib-src/profile.c to be compiled on FreeBSD,
2559 where the include path doesn't have X11/X.h by default. See
2560 <http://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00561.html>.
2561
e23640bb 25622011-05-20 Kenichi Handa <handa@m17n.org>
31bfc35c
KH
2563
2564 * composite.c (find_automatic_composition): Fix previous change.
2565
b9704ad9
GM
25662011-05-20 Glenn Morris <rgm@gnu.org>
2567
2568 * lisp.mk: New file, split from Makefile.in.
2569 * Makefile.in (lisp): Move to separate file, inserted by @lisp_frag@.
2570 (shortlisp): Remove.
2571 ($(etc)/DOC): Edit lisp.mk rather than using $shortlisp.
2572
4a720484
GM
25732011-05-19 Glenn Morris <rgm@gnu.org>
2574
2575 * Makefile.in (MSDOS_SUPPORT_REAL, MSDOS_SUPPORT, NS_SUPPORT)
2576 (REAL_MOUSE_SUPPORT, GPM_MOUSE_SUPPORT, MOUSE_SUPPORT, TOOLTIP_SUPPORT)
2577 (BASE_WINDOW_SUPPORT, X_WINDOW_SUPPORT, WINDOW_SUPPORT): Remove.
2578 (lisp): Set the order to that of loadup.el.
2579 (shortlisp): Make it a copy of $lisp.
2580 (SOME_MACHINE_LISP): Remove.
2581 ($(etc)/DOC): Depend just on $lisp, not $SOME_MACHINE_LISP too.
2582 Use just $shortlisp, not $SOME_MACHINE_LISP too.
2583
a28d4396
KH
25842011-05-18 Kenichi Handa <handa@m17n.org>
2585
2586 * composite.c (CHAR_COMPOSABLE_P): Add more check for efficiency.
2587 (BACKWARD_CHAR): Wrap the arg STOP by parenthesis.
2588 (find_automatic_composition): Mostly rewrite for efficiency.
2589
a2b1fa8e
JB
25902011-05-18 Juanma Barranquero <lekktu@gmail.com>
2591
2592 * makefile.w32-in: Update dependencies.
2593
8e1f5610
CS
25942011-05-18 Christoph Scholtes <cschol2112@googlemail.com>
2595
2596 * menu.c: Include limits.h (fixes the MS-Windows build broken by
7d7d0045 2597 2011-06-18T18:49:19Z!cyd@stupidchicken.com).
8e1f5610 2598
7025ee00 25992011-05-18 Paul Eggert <eggert@cs.ucla.edu>
cb93f9be 2600
cdfa6eab
PE
2601 Fix some integer overflow issues, such as string length overflow.
2602
06d6db33
PE
2603 * insdel.c (count_size_as_multibyte): Check for string overflow.
2604
2b4560a8
PE
2605 * character.c (lisp_string_width): Check for string overflow.
2606 Use EMACS_INT, not int, for string indexes and lengths; in
2607 particular, 2nd arg is now EMACS_INT, not int. Do not crash if
2608 the resulting string length overflows an EMACS_INT; instead,
2609 report a string overflow if no precision given. When checking for
2610 precision exhaustion, use a check that cannot possibly have
2611 integer overflow. (Bug#8675)
2612 * character.h (lisp_string_width): Adjust to new signature.
2613
cb93f9be
PE
2614 * alloc.c (string_overflow): New function.
2615 (Fmake_string): Use it. This doesn't change behavior, but saves
2616 a few bytes and will simplify future changes.
2617 * character.c (string_escape_byte8): Likewise.
2618 * lisp.h (string_overflow): New decl.
2619
1a1f3366
PE
2620 Fixups, following up to the user-interface timestamp change.
2621 * nsterm.m (last_mouse_movement_time, ns_mouse_position): Use Time
2622 for UI timestamps, instead of unsigned long.
9fbd6841
PE
2623 * msdos.c (mouse_get_pos): Likewise.
2624 * w32inevt.c (movement_time, w32_console_mouse_position): Likewise.
1a1f3366
PE
2625 * w32gui.h (Time): Define by including "systime.h" rather than by
2626 declaring it ourselves. (Bug#8664)
2627
d4e3e4d3
PE
2628 * dispextern.h (struct image): Don't assume time_t <= unsigned long.
2629 * image.c (clear_image_cache): Likewise.
2630
f6a24d19
PE
2631 * term.c (term_mouse_position): Don't assume time_t wraparound.
2632
08dc5ae6
PE
2633 Be more systematic about user-interface timestamps.
2634 Before, the code sometimes used 'Time', sometimes 'unsigned long',
620c53a6
SM
2635 and sometimes 'EMACS_UINT', to represent these timestamps.
2636 This change causes it to use 'Time' uniformly, as that's what X uses.
08dc5ae6
PE
2637 This makes the code easier to follow, and makes it easier to catch
2638 integer overflow bugs such as Bug#8664.
2639 * frame.c (Fmouse_position, Fmouse_pixel_position):
2640 Use Time, not unsigned long, for user-interface timestamps.
2641 * keyboard.c (last_event_timestamp, kbd_buffer_get_event): Likewise.
2642 (button_down_time, make_lispy_position, make_lispy_movement): Likewise.
2643 * keyboard.h (last_event_timestamp): Likewise.
2644 * menu.c (Fx_popup_menu) [!HAVE_X_WINDOWS]: Likewise.
2645 * menu.h (xmenu_show): Likewise.
2646 * term.c (term_mouse_position): Likewise.
2647 * termhooks.h (struct input_event.timestamp): Likewise.
2648 (struct terminal.mouse_position_hook): Likewise.
2649 * xmenu.c (create_and_show_popup_menu, xmenu_show): Likewise.
2650 * xterm.c (XTmouse_position, x_scroll_bar_report_motion): Likewise.
2651 * systime.h (Time): New decl. Pull it in from <X11/X.h> if
2652 HAVE_X_WINDOWS, otherwise define it as unsigned long, which is
2653 what it was before.
2654 * menu.h, termhooks.h: Include "systime.h", for Time.
2655
8e55734a
PE
2656 * keyboard.c (make_lispy_event): Fix problem in integer overflow.
2657 Don't assume that the difference between two unsigned long values
2658 can fit into an integer. At this point, we know button_down_time
2659 <= event->timestamp, so the difference must be nonnegative, so
2660 there's no need to cast the result if double-click-time is
2661 nonnegative, as it should be; check that it's nonnegative, just in
2662 case. This bug is triggered when events are more than 2**31 ms
86db42d2 2663 apart (about 25 days). (Bug#8664)
8e55734a 2664
841f1b75 2665 * xselect.c (last_event_timestamp): Remove duplicate decl.
6434756c 2666 (x_own_selection): Remove needless cast to unsigned long.
841f1b75 2667
3e26f69c
PE
2668 * xmenu.c (set_frame_menubar): Use int, not EMACS_UINT, for indexes
2669 that always fit in int. Use a sentinel instead of a counter, to
2670 avoid a temp and to allay GCC's concerns about possible int overflow.
d230cb74
PE
2671 * frame.h (struct frame): Use int for menu_bar_items_used
2672 instead of EMACS_INT, since it always fits in int.
3e26f69c 2673
5cc152c0
PE
2674 * menu.c (grow_menu_items): Check for int overflow.
2675
d89eb65e
PE
2676 * xmenu.c (set_frame_menubar): Don't mishandle vectors with no nils.
2677
5235bd3e
PE
2678 * xterm.c: Use EMACS_INT for Emacs modifiers, and int for X modifiers.
2679 Before, the code was not consistent. These values cannot exceed
2680 2**31 - 1 so there's no need to make them unsigned.
2681 (x_x_to_emacs_modifiers): Accept int and return EMACS_INT.
2682 (x_emacs_to_x_modifiers): Accept EMACS_INT and return int.
2683 (x_x_to_emacs_modifiers, x_emacs_to_x_modifiers): Reject non-integers
2684 as modifiers.
2685 * xterm.h (x_x_to_emacs_modifiers): Adjust to signature change.
2686
bc827e23
PE
2687 * lisp.h (XINT) [USE_LISP_UNION_TYPE]: Cast to EMACS_INT.
2688 (XUINT) [USE_LISP_UNION_TYPE]: Cast to EMACS_UINT.
2689 Otherwise, GCC 4.6.0 warns about printf (pI, XINT (...)),
2690 presumably because the widths might not match.
2691
78eb494e
PE
2692 * window.c (size_window): Avoid needless test at loop start.
2693
04f2d78b
CB
26942011-05-18 Courtney Bane <emacs-bugs-7626@cbane.org> (tiny change)
2695
2696 * term.c (Fresume_tty): Restore hooks before reinitializing (bug#8687).
2697
d2fc7e3d 26982011-05-12 Drew Adams <drew.adams@oracle.com>
e531bdff
DA
2699
2700 * textprop.c (Fprevious_single_char_property_change): Doc fix (bug#8655).
2701
d2fc7e3d 27022011-05-12 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
7db47798
YM
2703
2704 * w32term.c (w32_draw_fringe_bitmap): Rename local vars `left' and
2705 `width' to `bar_area_x' and `bar_area_width', respectively.
2706 (x_scroll_run): Take account of fringe background extension.
2707
04f2d78b
CB
2708 * xterm.c (x_draw_fringe_bitmap) [USE_TOOLKIT_SCROLL_BARS]:
2709 Rename local vars `left' and `width' to `bar_area_x' and
7db47798
YM
2710 `bar_area_width', respectively.
2711 (x_scroll_run) [USE_TOOLKIT_SCROLL_BARS]: Take account of fringe
2712 background extension.
2713
79b70037
GM
27142011-05-10 Jim Meyering <meyering@redhat.com>
2715
2716 * xdisp.c (x_intersect_rectangles): Fix typo "the the -> the".
2717
2f142cc5
JB
27182011-05-10 Juanma Barranquero <lekktu@gmail.com>
2719
2720 * image.c (Finit_image_library): Return t for built-in image types,
2721 like pbm and xbm. (Bug#8640)
2722
57679c86
AS
27232011-05-09 Andreas Schwab <schwab@linux-m68k.org>
2724
2725 * w32menu.c (set_frame_menubar): Fix submenu allocation.
2726
888c9e86
EZ
27272011-05-07 Eli Zaretskii <eliz@gnu.org>
2728
b0512a1d
EZ
2729 * w32console.c (Fset_screen_color): Doc fix.
2730 (Fget_screen_color): New function.
2731 (syms_of_ntterm): Defsubr it.
2732
7285dc67
EZ
2733 * callproc.c (call_process_cleanup) [MSDOS]: Don't close and
2734 unlink the temporary file if Fcall_process didn't create it in the
2735 first place.
2736 (Fcall_process) [MSDOS]: Don't create tempfile if stdout of the
2737 child process will be redirected to a file specified with `:file'.
888c9e86
EZ
2738 Don't try to re-open tempfile in that case, and set fd[0] to -1 as
2739 cue to call_process_cleanup not to close that handle.
2740
4d3fcc8e
BK
27412011-05-07 Ben Key <bkey76@gmail.com>
2742
2743 * makefile.w32-in: The bootstrap-temacs rule now makes use of
2744 one of two shell specific rules, either bootstrap-temacs-CMD or
2745 bootstrap-temacs-SH. The bootstrap-temacs-SH rule is identical
2746 to the previous implementation of the bootstrap-temacs rule.
2747 The bootstrap-temacs-CMD rule is similar to the previous
2748 implementation of the bootstrap-temacs rule except that it
2749 makes use of the ESC_CFLAGS variable instead of the CFLAGS
2750 variable.
2751
2752 These changes, along with some changes to nt/configure.bat,
2753 nt/gmake.defs, and nt/nmake.defs, are required to extend my
2754 earlier fix to add support for --cflags and --ldflags options
2755 that include quotes so that it works whether make uses cmd or
2756 sh as the shell.
2757
b4289b64
MA
27582011-05-06 Michael Albinus <michael.albinus@gmx.de>
2759
2760 * dbusbind.c (QCdbus_type_unix_fd): Declare static.
2761 (xd_remove_watch): Don't check QCdbus_type_unix_fd for SYMBOLP, it
2762 is a constant.
2763 (Fdbus_init_bus, xd_read_queued_messages): Bus can be a symbol or
2764 a string. Handle both cases.
2765 (Fdbus_call_method_asynchronously, Fdbus_register_signal)
2766 (Fdbus_register_method): Use Qinvalid_function.
2767
af4c0e28
JB
27682011-05-06 Juanma Barranquero <lekktu@gmail.com>
2769
2770 * makefile.w32-in: Update dependencies.
2771 (LISP_H): Add inttypes.h and stdin.h.
2772 (PROCESS_H): Add unistd.h.
2773
c51453d9
EZ
27742011-05-06 Eli Zaretskii <eliz@gnu.org>
2775
2776 * lread.c: Include limits.h (fixes the MS-Windows build broken by
2777 2011-05-06T07:13:19Z!eggert@cs.ucla.edu).
2778
8ff0ac3c 27792011-05-06 Paul Eggert <eggert@cs.ucla.edu>
c032b5f8 2780
4c4b566b
PE
2781 * image.c (Finit_image_library) [!HAVE_NTGUI]: Omit unused local.
2782
aab2b9b5
PE
2783 * term.c (vfatal): Remove stray call to va_end.
2784 It's not needed and the C Standard doesn't allow it here anyway.
2785
c378da0b
PE
2786 Use C99's va_copy to avoid undefined behavior on x86-64 GNU/Linux.
2787 * eval.c (verror): doprnt a copy of ap, not the original. (Bug#8545)
2788
288b08c7
PE
2789 * eval.c (verror): OK to create a string of up to MOST_POSITIVE_FIXNUM
2790 bytes.
2791
e3601888
PE
2792 * term.c: Don't include <stdarg.h>, as <lisp.h> does that.
2793
db6c0e74
PE
2794 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork clobbering.
2795
dd5963ea
PE
2796 * process.c (Fformat_network_address): Fix typo: args2 -> *args2.
2797
88c9450f
PE
2798 * xmenu.c (set_frame_menubar): Fix typo: int * -> int (3 times).
2799
2f9442b8
PE
2800 * coding.c (detect_coding_charset): Fix typo: * 2 -> *4 (Bug#8601).
2801
c032b5f8
PE
2802 * charset.h (struct charset.code_space): Now has 15 elements, not 16.
2803 * charset.c (Fdefine_charset_internal): Don't initialize
2804 charset.code_space[15]. The value was garbage, on hosts with
2d38271b 2805 32-bit int (Bug#8600).
a108c10b
PE
2806
2807 * lread.c (read_integer): Be more consistent with string-to-number.
2808 Use string_to_number to do the actual conversion; this avoids
2809 rounding errors and fixes some other screwups. Without this fix,
2810 for example, #x1fffffffffffffff was misread as -2305843009213693952.
2811 (digit_to_number): Move earlier, for benefit of read_integer.
2812 Return -1 if the digit is out of range for the base, -2 if it is
48e400f0 2813 not a digit in any supported base. (Bug#8602)
a108c10b 2814
ad5f9eea
PE
2815 * doprnt.c (doprnt): Support arbitrary pI values, such as "I64".
2816
aec1708a
PE
2817 * dispnew.c (scrolling_window): Return 1 if we scrolled,
2818 to match comment at start of function. This also removes a
2819 GCC warning about overflow in a 32+64-bit port.
2820
47be4ab5
PE
2821 * lisp.h (EMACS_INT, EMACS_UINT, BITS_PER_EMACS_INT, pI): Simplify.
2822
371cac43
PE
2823 * dbusbind.c: Do not use XPNTR on a value that may be an integer.
2824 Reported by Stefan Monnier in
2825 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00919.html>.
04f2d78b
CB
2826 (xd_remove_watch, Fdbus_init_bus, xd_read_queued_messages):
2827 Use SYMBOLP-guarded XSYMBOL, not XPNTR.
371cac43 2828
d01a7826
PE
2829 * lisp.h (EMACS_INTPTR): Remove. All uses changed to intptr_t.
2830 (EMACS_UINTPTR): Likewise, with uintptr_t.
2831
7fd47d5c
PE
2832 * lisp.h: Prefer 64-bit EMACS_INT if available.
2833 (EMACS_INT, EMACS_UINT, BITS_PER_EMACS_INT, pI): Define to 64-bit
2834 on 32-bit hosts that have 64-bit int, so that they can access
2835 large files.
122b0c86
PE
2836 However, temporarily disable this change unless the temporary
2837 symbol WIDE_EMACS_INT is defined.
7fd47d5c 2838
8727937b
PE
2839 * lread.c, process.c: Do not include <inttypes.h>; lisp.h does it now.
2840
8ac068ac
PE
2841 Prefer intptr_t/uintptr_t for integers the same widths as pointers.
2842 This removes an assumption that EMACS_INT and long are the same
2843 width as pointers. The assumption is true for Emacs porting targets
2844 now, but we want to make other targets possible.
2845 * lisp.h: Include <inttypes.h>, for INTPTR_MAX, UINTPTR_MAX.
2846 (EMACS_INTPTR, EMACS_UINTPTR): New macros.
2847 In the rest of the code, change types of integers that hold casted
2848 pointers to EMACS_INTPTR and EMACS_UINTPTR, systematically
2849 replacing EMACS_INT, long, EMACS_UINT, and unsigned long.
2850 (XTYPE): Don't cast arg to EMACS_UINT; normally is not needed.
2851 (XSET): Cast type of XTYPE arg to EMACS_INTPTR; it is needed here.
2852 No need to cast type when ORing.
2853 (XPNTR): Return a value of type EMACS_INTPTR or EMACS_UINTPTR.
2854 * alloc.c (lisp_align_malloc): Remove a no-longer-needed cast.
2855 * doc.c (store_function_docstring): Use EMACS_INTPTR, so as not to
2856 assume EMACS_INT is the same width as char *.
2857 * gtkutil.c (xg_gtk_scroll_destroy, xg_tool_bar_button_cb):
2858 (xg_tool_bar_callback, xg_tool_bar_help_callback, xg_make_tool_item):
2859 Remove no-longer-needed casts.
2860 (xg_create_scroll_bar, xg_tool_bar_button_cb, xg_tool_bar_callback):
2861 (xg_tool_bar_help_callback, xg_make_tool_item):
2862 Use EMACS_INTPTR to hold an integer
2863 that will be cast to void *; this can avoid a GCC warning
2864 if EMACS_INT is not the same width as void *.
2865 * menu.c (find_and_call_menu_selection): Remove no-longer-needed cast.
2866 * xdisp.c (display_echo_area_1, resize_mini_window_1):
2867 (current_message_1, set_message_1):
2868 Use a local to convert to proper width without a cast.
2869 * xmenu.c (dialog_selection_callback): Likewise.
2870
ede49d71
PE
2871 * sysdep.c (get_random): Don't assume EMACS_INT is no wider than long.
2872 Also, don't assume VALBITS / RAND_BITS is less than 5,
2873 and don't rely on undefined behavior when shifting a 1 left into
2874 the sign bit.
2875 * lisp.h (get_random): Change signature to match.
2876
2f30ecd0
PE
2877 * lread.c (hash_string): Use size_t, not int, for hash computation.
2878 Normally we prefer signed values; but hashing is special, because
2879 it's better to use unsigned division on hash table sizes so that
2880 the remainder is nonnegative. Also, size_t is the natural width
2881 for hashing into memory. The previous code used 'int', which doesn't
2882 retain enough info to hash well into very large tables.
2883 (oblookup, oblookup_last_bucket_number, Funintern): Likewise.
2884
2a866e7b
PE
2885 * dbusbind.c: Don't possibly lose pointer info when converting.
2886 (xd_remove_watch, Fdbus_init_bus, xd_read_queued_messages):
2887 Use XPNTR rather than XHASH, so that the high-order bits of
2888 the pointer aren't lost when converting through void *.
2889
51639eac
PE
2890 * eval.c (Fautoload): Don't double-shift a pointer.
2891
92394119
PE
2892 * fns.c (Frandom): Let EMACS_UINT be wider than unsigned long.
2893
dbdb9a7c
JB
28942011-05-06 Juanma Barranquero <lekktu@gmail.com>
2895
2896 * gnutls.c (DEF_GNUTLS_FN):
2897 * image.c (DEF_IMGLIB_FN): Make function pointers static.
2898
db7a0b4f
AS
28992011-05-05 Andreas Schwab <schwab@linux-m68k.org>
2900
2901 * lread.c (lisp_file_lexically_bound_p): Stop scanning at end
2902 marker. (Bug#8610)
2903
f7ff1b0f 29042011-05-05 Eli Zaretskii <eliz@gnu.org>
fab624aa
EZ
2905
2906 * w32heap.c (allocate_heap) [USE_LISP_UNION_TYPE || USE_LSB_TAG]:
2907 New version that can reserve upto 2GB of heap space.
2908
f7ff1b0f 29092011-05-05 Chong Yidong <cyd@stupidchicken.com>
45cb8994
CY
2910
2911 * nsfns.m (Fns_read_file_name): Doc fix (Bug#8534).
2912
639c109b
TZ
29132011-05-05 Teodor Zlatanov <tzz@lifelogs.com>
2914
2915 * gnutls.c (fn_gnutls_certificate_set_x509_key_file): Add alias to
2916 `gnutls_certificate_set_x509_key_file'.
2917
d2127135
JB
29182011-05-05 Juanma Barranquero <lekktu@gmail.com>
2919
2920 * makefile.w32-in ($(BLD)/image.$(O), $(BLD)/process.$(O)):
2921 Update dependencies.
2922
e968f4f3
JB
29232011-05-04 Juanma Barranquero <lekktu@gmail.com>
2924
2925 * gnutls.h (emacs_gnutls_write, emacs_gnutls_read):
2926 * gnutls.c (emacs_gnutls_write, emacs_gnutls_read):
2927 Remove unused parameter `fildes'.
2928 * process.c (read_process_output, send_process): Don't pass it.
2929
84d358f0
JB
29302011-05-04 Juanma Barranquero <lekktu@gmail.com>
2931
2932 Fix previous change: the library cache is defined in w32.c.
2933 * image.c (CACHE_IMAGE_TYPE) [!HAVE_NTGUI]: Define to noop.
2934 (Finit_image_library): Wrap Vlibrary_cache on "#ifdef HAVE_NTGUI".
2935
0898ca10
JB
29362011-05-04 Juanma Barranquero <lekktu@gmail.com>
2937
2938 Implement dynamic loading of GnuTLS on Windows.
2939
2940 * gnutls.h (GNUTLS_EMACS_ERROR_NOT_LOADED): New macro.
2941 (emacs_gnutls_write, emacs_gnutls_read): Mark as extern.
2942 (emacs_gnutls_record_check_pending, emacs_gnutls_transport_set_errno):
2943 Declare.
2944
2945 * gnutls.c (Qgnutls_dll): Define.
2946 (DEF_GNUTLS_FN, LOAD_GNUTLS_FN): New macros.
2947 (gnutls_*): Declare function pointers.
2948 (init_gnutls_functions): New function to initialize function pointers.
2949 (emacs_gnutls_handshake, Fgnutls_error_string, Fgnutls_deinit)
2950 (emacs_gnutls_global_init, Fgnutls_bye): Use function pointers.
2951 (emacs_gnutls_record_check_pending, emacs_gnutls_transport_set_errno):
2952 Wrappers for gnutls_record_check_pending and gnutls_transport_set_errno.
2953 (emacs_gnutls_write, emacs_gnutls_read)
2954 (emacs_gnutls_handle_error, Fgnutls_error_fatalp)
2955 (Fgnutls_available_p): New function.
2956 (Fgnutls_boot): Call Fgnutls_available_p. Use function pointers.
2957 (syms_of_gnutls) <Qgnutls_dll>: Initialize and staticpro it.
2958 (syms_of_gnutls) <Sgnutls_available_p>: defsubr it.
2959
2960 * image.c: Include w32.h.
2961 (Vimage_type_cache): Delete.
2962 (syms_of_image) <Vimage_type_cache>: Don't initialize and staticpro it.
2963 (CACHE_IMAGE_TYPE, Finit_image_library): Use Vlibrary_cache instead.
2964 (w32_delayed_load): Move to w32.c.
2965
2966 * w32.h (VlibraryCache, QCloaded_from, w32_delayed_load): Declare.
2967
2968 * w32.c (QCloaded_from, Vlibrary_cache): Define.
2969 (w32_delayed_load): Move from image.c. When loading a library, record
2970 its filename in the :loaded-from property of the library id.
2971 (globals_of_w32) <QCloaded_from, Vlibrary_cache>:
2972 Initialize and staticpro them.
2973 (emacs_gnutls_pull, emacs_gnutls_push): Call emacs_gnutls_* functions.
2974
2975 * process.c: Include lisp.h before w32.h, not after.
2976 (wait_reading_process_output): Call emacs_gnutls_record_check_pending
2977 instead of gnutls_record_check_pending.
2978
2979 * callproc.c, emacs.c: Include lisp.h before w32.h, not after.
2980
ff4de4aa
TZ
29812011-05-04 Teodor Zlatanov <tzz@lifelogs.com>
2982
2983 * gnutls.c (Fgnutls_boot): Support :keylist and :crlfiles options
2984 instead of :keyfiles. Give GnuTLS the keylist and the CRL lists
2985 as passed in.
2986
abe95abb
JD
29872011-05-03 Jan Djärv <jan.h.d@swipnet.se>
2988
2989 * xterm.c (x_set_frame_alpha): Do not set property on anything
2990 else than FRAME_X_OUTER_WINDOW (Bug#8608).
2991
e16e55d4
JB
29922011-05-02 Juanma Barranquero <lekktu@gmail.com>
2993
2994 * sysdep.c (get_tty_size) [WINDOWSNT]: Implement. (Bug#8596)
2995
bafcf6a5
JB
29962011-05-02 Juanma Barranquero <lekktu@gmail.com>
2997
2998 * gnutls.c (Qgnutls_log_level, Qgnutls_code, Qgnutls_anon)
2999 (Qgnutls_x509pki, Qgnutls_e_interrupted, Qgnutls_e_again)
3000 (Qgnutls_e_invalid_session, Qgnutls_e_not_ready_for_handshake)
3001 (gnutls_global_initialized, Qgnutls_bootprop_priority)
3002 (Qgnutls_bootprop_trustfiles, Qgnutls_bootprop_keyfiles)
3003 (Qgnutls_bootprop_callbacks, Qgnutls_bootprop_loglevel)
3004 (Qgnutls_bootprop_hostname, Qgnutls_bootprop_verify_flags)
3005 (Qgnutls_bootprop_verify_error, Qgnutls_bootprop_verify_hostname_error)
3006 (Qgnutls_bootprop_callbacks_verify): Make static.
3007
e7a6747f
AS
30082011-05-01 Andreas Schwab <schwab@linux-m68k.org>
3009
19ed11ba
AS
3010 * callproc.c: Indentation fixup.
3011
e7a6747f 3012 * sysdep.c (wait_for_termination_1): Make static.
04f2d78b
CB
3013 (wait_for_termination, interruptible_wait_for_termination):
3014 Move after wait_for_termination_1.
e7a6747f 3015
1ef14cb4
LMI
30162011-05-01 Lars Magne Ingebrigtsen <larsi@gnus.org>
3017
3018 * sysdep.c (interruptible_wait_for_termination): New function
3019 which is like wait_for_termination, but allows keyboard
3020 interruptions.
3021
3022 * callproc.c (Fcall_process): Add (:file "file") as an option for
3023 the STDOUT buffer.
3024 (Fcall_process_region): Ditto.
3025
330d880c
EZ
30262011-04-30 Eli Zaretskii <eliz@gnu.org>
3027
8db90b73
EZ
3028 * dosfns.c (Fint86, Fdos_memget, Fdos_memput): Use `ASIZE (FOO)'
3029 rather than `XVECTOR (FOO)->size'.
3030
330d880c
EZ
3031 * process.c: Remove HAVE_INTTYPES_H condition from inclusion of
3032 inttypes.h, as a gnulib replacement is used if it not available in
3033 system headers.
3034
15cbd324
EZ
30352011-04-21 Eli Zaretskii <eliz@gnu.org>
3036
3037 Lift the MOST_POSITIVE_FIXNUM/4 limitation on visited files.
3038 * fileio.c (Finsert_file_contents): Don't limit file size to 1/4
3039 of MOST_POSITIVE_FIXNUM. (Bug#8528)
3040
3041 * coding.c (coding_alloc_by_realloc): Error out if destination
3042 will grow beyond MOST_POSITIVE_FIXNUM.
3043 (decode_coding_emacs_mule): Abort if there isn't enough place in
3044 charbuf for the composition carryover bytes. Reserve an extra
3045 space for up to 2 characters produced in a loop.
3046 (decode_coding_iso_2022): Abort if there isn't enough place in
3047 charbuf for the composition carryover bytes.
3048
30492011-04-21 Eli Zaretskii <eliz@gnu.org>
afda1437 3050
ae940cca
EZ
3051 * doprnt.c (doprnt) [!HAVE_LONG_LONG_INT]: Error out instead of
3052 aborting when %lld or %lll format is passed.
3053 [!HAVE_UNSIGNED_LONG_LONG_INT]: Error out instead of aborting when
3054 %llo or %llx format is passed. (Bug#8545)
3055
03ab8921
EZ
3056 * window.c (window_scroll_line_based): Use a marker instead of
3057 simple variables to record original value of point. (Bug#7952)
3058
afda1437
EZ
3059 * doprnt.c (doprnt): Fix the case where a multibyte sequence
3060 produced by %s or %c overflows available buffer space. (Bug#8545)
3061
f76dee0c
PE
30622011-04-28 Paul Eggert <eggert@cs.ucla.edu>
3063
3064 * doprnt.c (doprnt): Omit useless test; int overflow check (Bug#8545).
283cdbef 3065 (SIZE_MAX): Move defn after all includes, as they might #define it.
f76dee0c 3066
fdc5744d
JB
30672011-04-28 Juanma Barranquero <lekktu@gmail.com>
3068
3069 * w32.c (init_environment): Warn about defaulting HOME to C:\.
3070
638f053a
JB
30712011-04-28 Juanma Barranquero <lekktu@gmail.com>
3072
3073 * keyboard.c (Qdelayed_warnings_hook): Define.
3074 (command_loop_1): Run `delayed-warnings-hook'
3075 if Vdelayed_warnings_list is non-nil.
3076 (syms_of_keyboard) <delayed-warnings-hook>: DEFSYM it.
3077 (syms_of_keyboard) <delayed-warnings-list>: DEFVAR_LISP it.
3078
d178f871
EZ
30792011-04-28 Eli Zaretskii <eliz@gnu.org>
3080
3081 * doprnt.c (doprnt): Don't return value smaller than the buffer
3082 size if the message was truncated. (Bug#8545).
3083
b124fd93
JB
30842011-04-28 Juanma Barranquero <lekktu@gmail.com>
3085
3086 * w32fns.c (Fx_change_window_property, Fx_delete_window_property)
3087 (Fx_window_property): #if-0 the whole functions, not just the bodies.
3088
e810457d
PE
30892011-04-27 Paul Eggert <eggert@cs.ucla.edu>
3090
3091 * doprnt.c (doprnt): Support "ll" length modifier, for long long.
3092
ea51cceb
JB
30932011-04-27 Juanma Barranquero <lekktu@gmail.com>
3094
3095 * makefile.w32-in: Update dependencies.
3096
94dcfacf
EZ
30972011-04-27 Eli Zaretskii <eliz@gnu.org>
3098
3099 Improve `doprnt' and its usage. (Bug#8545)
3100 * doprnt.c (doprnt): Make sure `format' is never accessed beyond
3101 `format_end'. Remove support for %l as a conversion specifier.
3102 Don't use xrealloc. Improve diagnostics when the %l size modifier
3103 is used. Update the commentary.
3104
3105 * eval.c (verror): Simplify calculation of size_t.
3106
3107 * coding.c (Ffind_operation_coding_system): Fix diagnostic error
3108 messages.
3109
f61f41d7
PE
31102011-04-27 Yoshiaki Kasahara <kasahara@nc.kyushu-u.ac.jp> (tiny change)
3111
3112 * buffer.c (init_buffer) [USE_MMAP_FOR_BUFFERS]: Adjust to aliasing
3113 change.
3114
96fb4434
PE
31152011-04-27 Paul Eggert <eggert@cs.ucla.edu>
3116
3117 * nsmenu.m: Replace all uses of XVECTOR with ASIZE and AREF.
3118 This makes this file independent of the recent pseudovector change.
3119
671875da 31202011-04-26 Paul Eggert <eggert@cs.ucla.edu>
eab3844f 3121
69e9b5a3
PE
3122 * keyboard.c (handle_user_signal): Fix pointer signedness problem.
3123
b5f869a7 3124 * gnutls.c (emacs_gnutls_handle_error): Remove unused local.
7754e151 3125 (Fgnutls_boot): gnutls_certificate_verify_peers2 wants unsigned *.
8d4c3955 3126 Remove unused local.
c8926152 3127 (emacs_gnutls_write): Don't use uninitialized rtnval if nbyte <= 0.
080e5a8d 3128
841a1577 3129 * lisp.h: Fix a problem with aliasing and vector headers. (Bug#8546)
04f2d78b
CB
3130 GCC 4.6.0 optimizes based on type-based alias analysis.
3131 For example, if b is of type struct buffer * and v of type struct
eab3844f
PE
3132 Lisp_Vector *, then gcc -O2 was incorrectly assuming that &b->size
3133 != &v->size, and therefore "v->size = 1; b->size = 2; return
3134 v->size;" must therefore return 1. This assumption is incorrect
3135 for Emacs, since it type-puns struct Lisp_Vector * with many other
3136 types. To fix this problem, this patch adds a new type struct
f904488f 3137 vectorlike_header that documents the constraints on layout of vectors
eab3844f
PE
3138 and pseudovectors, and helps optimizing compilers not get fooled
3139 by Emacs's type punning. It also adds the macros XSETTYPED_PVECTYPE
3140 XSETTYPED_PSEUDOVECTOR, TYPED_PSEUDOVECTORP, for similar reasons.
f904488f
PE
3141 * lisp.h (XSETTYPED_PVECTYPE): New macro, specifying the name of
3142 the size member.
eab3844f
PE
3143 (XSETPVECTYPE): Rewrite in terms of new macro.
3144 (XSETPVECTYPESIZE): New macro, specifying both type and size.
3145 This is a bit clearer, and further avoids the possibility of
3146 undesirable aliasing.
3147 (XSETTYPED_PSEUDOVECTOR): New macro, specifying the size.
f904488f 3148 (XSETPSEUDOVECTOR): Rewrite in terms of XSETTYPED_PSEUDOVECTOR.
eab3844f
PE
3149 (XSETSUBR): Rewrite in terms of XSETTYPED_PSEUDOVECTOR and XSIZE,
3150 since Lisp_Subr is a special case (no "next" field).
04f2d78b
CB
3151 (ASIZE): Now uses header.size rather than size.
3152 All previous uses of XVECTOR (foo)->size replaced to use this macro,
f904488f
PE
3153 to avoid the hassle of writing XVECTOR (foo)->header.size.
3154 (struct vectorlike_header): New type.
eab3844f
PE
3155 (TYPED_PSEUDOVECTORP): New macro, also specifying the C type of the
3156 object, to help avoid aliasing.
3157 (PSEUDOVECTORP): Rewrite in terms of TYPED_PSEUDOVECTORP.
3158 (SUBRP): Likewise, since Lisp_Subr is a special case.
3159 * lisp.h (struct Lisp_Vector, struct Lisp_Char_Table):
3160 (struct Lisp_Sub_Char_Table, struct Lisp_Bool_Vector):
3161 (struct Lisp_Hash_Table): Combine first two members into a single
f904488f 3162 struct vectorlike_header member. All uses of "size" and "next" members
eab3844f
PE
3163 changed to be "header.size" and "header.next".
3164 * buffer.h (struct buffer): Likewise.
3165 * font.h (struct font_spec, struct font_entity, struct font): Likewise.
3166 * frame.h (struct frame): Likewise.
3167 * process.h (struct Lisp_Process): Likewise.
3168 * termhooks.h (struct terminal): Likewise.
3169 * window.c (struct save_window_data, struct saved_window): Likewise.
3170 * window.h (struct window): Likewise.
3171 * alloc.c (allocate_buffer, Fmake_bool_vector, allocate_pseudovector):
3172 Use XSETPVECTYPESIZE, not XSETPVECTYPE, to avoid aliasing problems.
3173 * buffer.c (init_buffer_once): Likewise.
3174 * lread.c (defsubr): Use XSETTYPED_PVECTYPE, since Lisp_Subr is a
3175 special case.
3176 * process.c (Fformat_network_address): Use local var for size,
3177 for brevity.
3178
0df1eac5
PE
3179 * bytecode.c (exec_byte_code): Don't use XVECTOR before CHECK_VECTOR.
3180
847ab9d1 3181 Make the Lisp reader and string-to-float more consistent (Bug#8525)
452f4150
PE
3182 * data.c (atof): Remove decl; no longer used or needed.
3183 (digit_to_number): Move to lread.c.
3184 (Fstring_to_number): Use new string_to_number function, to be
3185 consistent with how the Lisp reader treats infinities and NaNs.
3186 Do not assume that floating-point numbers represent EMACS_INT
3187 without losing information; this is not true on most 64-bit hosts.
3188 Avoid double-rounding errors, by insisting on integers when
3189 parsing non-base-10 numbers, as the documentation specifies.
3190 * lisp.h (string_to_number): New decl, replacing ...
3191 (isfloat_string): Remove.
bc0a5c13 3192 * lread.c: Include <inttypes.h>, for uintmax_t and strtoumax.
d78050d6 3193 (read1): Do not accept +. and -. as integers; this
452f4150
PE
3194 appears to have been a coding error. Similarly, do not accept
3195 strings like +-1e0 as floating point numbers. Do not report
3196 overflow for integer overflows unless the base is not 10 which
3197 means we have no simple and reliable way to continue.
3198 Break out the floating-point parsing into a new
3199 function string_to_number, so that Fstring_to_number parses
3200 floating point numbers consistently with the Lisp reader.
04f2d78b 3201 (digit_to_number): Move here from data.c. Make it static inline.
452f4150
PE
3202 (E_CHAR, EXP_INT): Remove, replacing with ...
3203 (E_EXP): New macro, to solve the "1.0e+" problem mentioned below.
3204 (string_to_number): New function, replacing isfloat_string.
3205 This function checks for valid syntax and produces the resulting
3206 Lisp float number too. Rework it so that string-to-number
bc0a5c13 3207 no longer mishandles examples like "1.0e+". Use strtoumax,
d78050d6
PE
3208 so that overflow for non-base-10 numbers is reported only when
3209 there's no portable and simple way to convert to floating point.
452f4150 3210
67769ffc
PE
3211 * textprop.c (set_text_properties_1): Rewrite for clarity,
3212 and to avoid GCC warning about integer overflow.
3213
c20db43f
PE
3214 * intervals.h (struct interval): Use EMACS_INT for members
3215 where EMACS_UINT might cause problems. See
3216 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00514.html>.
3217 (CHECK_TOTAL_LENGTH): Remove cast to EMACS_INT; no longer needed.
3218 * intervals.c (interval_deletion_adjustment): Now returns EMACS_INT.
3219 All uses changed.
37aa2f85
PE
3220 (offset_intervals): Tell GCC not to worry about length overflow
3221 when negating a negative length.
c20db43f 3222
2538aa2f
PE
3223 * alloc.c (overrun_check_malloc, overrun_check_realloc): Now static.
3224 (overrun_check_free): Likewise.
3225
f2d3008d
PE
3226 * alloc.c (SDATA_SIZE) [!GC_CHECK_STRING_BYTES]: Avoid runtime check
3227 in the common case where SDATA_DATA_OFFSET is a multiple of Emacs
3228 word size.
3229
ec8df744
PE
3230 * gnutls.c: Fix problems found by GCC 4.6.0 on Ubuntu 10.10.
3231 (gnutls_make_error): Rename local to avoid shadowing.
3232 (gnutls_emacs_global_deinit): ifdef out; not used.
3233 (Fgnutls_boot): Use const for pointer to readonly storage.
3234 Comment out unused local. Fix pointer signedness problems.
3235
640ee02d
PE
3236 * lread.c (openp): Don't stuff size_t into an 'int'.
3237 Use <= on length, not < on length + 1, to avoid GCC 4.6.0 warning
3238 about possible signed overflow.
3239
6048fb2a
PE
3240 * gtkutil.c: Fix problems found by GCC 4.6.0 on Ubuntu 10.10.
3241 (GDK_KEY_g): Don't define if already defined.
3242 (xg_prepare_tooltip): Avoid pointer signedness problem.
3243 (xg_set_toolkit_scroll_bar_thumb): Redo to avoid two casts.
3244
fa3c87e1
PE
3245 * process.c (Fnetwork_interface_info): Avoid left-shift undefined
3246 behavior with 1 << 31. GCC 4.6.0 warns about this on 32-bit hosts.
3247
2172544b
PE
3248 * xfns.c (Fx_window_property): Simplify a bit,
3249 to make a bit faster and to avoid GCC 4.6.0 warning.
3250 * xselect.c (x_get_window_property, x_handle_dnd_message): Likewise.
3251
9b821a21
PE
3252 * fns.c (internal_equal): Don't assume size_t fits in int.
3253
3c616cfa
PE
3254 * alloc.c (compact_small_strings): Tighten assertion a little.
3255
c2982e87
PE
3256 Replace pEd with more-general pI, and fix some printf arg casts.
3257 * lisp.h (pI): New macro, generalizing old pEd macro to other
3258 conversion specifiers. For example, use "...%"pI"d..." rather
3259 than "...%"pEd"...".
3260 (pEd): Remove. All uses replaced with similar uses of pI.
3261 * src/m/amdx86-64.h, src/m/ia64.h, src/m/ibms390x.h: Likewise.
3262 * alloc.c (check_pure_size): Don't overflow by converting size to int.
3263 * bidi.c (bidi_dump_cached_states): Use pI to avoid cast.
3264 * data.c (Fnumber_to_string): Use pI instead of if-then-else-abort.
3265 * dbusbind.c (xd_append_arg): Use pI to avoid cast.
3266 (Fdbus_method_return_internal, Fdbus_method_error_internal): Likewise.
3267 * font.c (font_unparse_xlfd): Avoid potential buffer overrun on
3268 64-bit hosts.
3269 (font_unparse_xlfd, font_unparse_fcname): Use pI to avoid casts.
3270 * keyboard.c (record_char, modify_event_symbol): Use pI to avoid casts.
3271 * print.c (safe_debug_print, print_object): Likewise.
3272 (print_object): Don't overflow by converting EMACS_INT or EMACS_UINT
3273 to int.
6f04d126
PE
3274 Use pI instead of if-then-else-abort. Use %p to avoid casts,
3275 avoiding the 0 flag, which is not portable.
c2982e87
PE
3276 * process.c (Fmake_network_process): Use pI to avoid cast.
3277 * region-cache.c (pp_cache): Likewise.
3278 * xdisp.c (decode_mode_spec): Likewise.
3279 * xrdb.c (x_load_resources) [USE_MOTIF]: Use pI to avoid undefined
3280 behavior on 64-bit hosts with printf arg.
6f04d126 3281 * xselect.c (x_queue_event): Use %p to avoid casts, avoiding 0 flag.
c2982e87
PE
3282 (x_stop_queuing_selection_requests): Likewise.
3283 (x_get_window_property): Don't truncate byte count to an 'int'
3284 when tracing.
0b432f21 3285
5e073ec7
PE
3286 * frame.c (frame_name_fnn_p): Get rid of strtol, which isn't right
3287 here, since it parses constructs like leading '-' and spaces,
3288 which are not wanted; and it overflows with large numbers.
3289 Instead, simply match F[0-9]+, which is what is wanted anyway.
3290
36372bf9
PE
3291 * alloc.c: Remove unportable assumptions about struct layout.
3292 (SDATA_SELECTOR, SDATA_DATA_OFFSET): New macros.
3293 (SDATA_OF_STRING, SDATA_SIZE, allocate_string_data):
3294 (allocate_vectorlike, make_pure_vector): Use the new macros,
3295 plus offsetof, to remove unportable assumptions about struct layout.
3296 These assumptions hold on all porting targets that I know of, but
3297 they are not guaranteed, they're easy to remove, and removing them
3298 makes further changes easier.
3299
0b432f21
PE
3300 * alloc.c (BLOCK BYTES): Fix typo by changing "ablock" to "ablocks".
3301 This doesn't fix a bug but makes the code clearer.
bfd1c781
PE
3302 (string_overrun_cookie): Now const. Use initializers that
3303 don't formally overflow signed char, to avoid warnings.
000098c1
PE
3304 (allocate_string_data) [GC_CHECK_STRING_OVERRUN]: Fix typo that
3305 can cause Emacs to crash when string overrun checking is enabled.
c7bda33c
PE
3306 (allocate_buffer): Don't assume sizeof (struct buffer) is a
3307 multiple of sizeof (EMACS_INT); it need not be, if
3308 alignof(EMACS_INT) < sizeof (EMACS_INT).
d0f4e1f5 3309 (check_sblock, check_string_bytes, check_string_free_list): Protoize.
0b432f21 3310
895009e1
JB
33112011-04-26 Juanma Barranquero <lekktu@gmail.com>
3312
3313 * keyboard.c (QCrtl): Rename from Qrtl. All uses changed.
3314
6a7a1b0b
TZ
33152011-04-26 Teodor Zlatanov <tzz@lifelogs.com>
3316
3317 * gnutls.c (emacs_gnutls_handshake): Return an error if we're not
b5f869a7 3318 supposed to be handshaking. (Bug#8556)
6a7a1b0b
TZ
3319 Reported by Paul Eggert <eggert@cs.ucla.edu>.
3320
841a1577 33212011-04-26 Daniel Colascione <dan.colascione@gmail.com>
0438ce91
DC
3322
3323 * lisp.h (Qdebug): List symbol.
895009e1 3324 * eval.c (Qdebug): Restore global linkage.
0438ce91
DC
3325 * keyboard.c (debug-on-event): New variable.
3326 (handle_user_signal): Break into debugger when debug-on-event
3327 matches the current signal symbol.
3328
f2d3ba6f
DN
33292011-04-25 Dan Nicolaescu <dann@ics.uci.edu>
3330
3331 * alloc.c (check_sblock, check_string_bytes)
3332 (check_string_free_list): Convert to standard C.
3333
42ce4c63
TZ
33342011-04-25 Teodor Zlatanov <tzz@lifelogs.com>
3335
3336 * w32.c (emacs_gnutls_push): Fix typo.
3337
825cd63c
EZ
33382011-04-25 Eli Zaretskii <eliz@gnu.org>
3339
fb11d64d
EZ
3340 * gnutls.c (emacs_gnutls_handshake): Avoid compiler warnings about
3341 "cast to pointer from integer of different size".
3342
825cd63c
EZ
3343 Improve doprnt and its use in verror. (Bug#8545)
3344 * doprnt.c (doprnt): Document the set of format control sequences
3345 supported by the function. Use SAFE_ALLOCA instead of always
3346 using `alloca'.
3347
3348 * eval.c (verror): Don't limit the buffer size at size_max-1, that
3349 is one byte too soon. Don't use xrealloc; instead xfree and
3350 xmalloc anew.
3351
e061a11b
TZ
33522011-04-24 Teodor Zlatanov <tzz@lifelogs.com>
3353
3354 * gnutls.h: Add GNUTLS_STAGE_CALLBACKS enum to denote we're in the
3355 callbacks stage.
3356
3357 * gnutls.c: Renamed global_initialized to
3358 gnutls_global_initialized. Added internals for the
3359 :verify-hostname-error, :verify-error, and :verify-flags
3360 parameters of `gnutls-boot' and documented those parameters in the
3361 docstring. Start callback support.
9173deec
JB
3362 (emacs_gnutls_handshake): Add Woe32 support. Retry handshake
3363 unless a fatal error occurred. Call gnutls_alert_send_appropriate
3364 on error. Return error code.
e061a11b
TZ
3365 (emacs_gnutls_write): Call emacs_gnutls_handle_error.
3366 (emacs_gnutls_read): Likewise.
3367 (Fgnutls_boot): Return handshake error code.
3368 (emacs_gnutls_handle_error): New function.
3369 (wsaerror_to_errno): Likewise.
3370
3371 * w32.h (emacs_gnutls_pull): Add prototype.
3372 (emacs_gnutls_push): Likewise.
3373
3374 * w32.c (emacs_gnutls_pull): New function for GnuTLS on Woe32.
3375 (emacs_gnutls_push): Likewise.
3376
33772011-04-24 Claudio Bley <claudio.bley@gmail.com> (tiny change)
3378
3379 * process.c (wait_reading_process_output): Check if GnuTLS
3380 buffered some data internally if no FDs are set for TLS
3381 connections.
3382
3383 * makefile.w32-in (OBJ2): Add gnutls.$(O).
3384 (LIBS): Link to USER_LIBS.
3385 ($(BLD)/gnutls.$(0)): New target.
3386
fa6996bc
EZ
33872011-04-24 Eli Zaretskii <eliz@gnu.org>
3388
eb35682e
EZ
3389 * xdisp.c (handle_single_display_spec): Rename the
3390 display_replaced_before_p argument into display_replaced_p, to
3391 make it consistent with the commentary. Fix typos in the
3392 commentary.
3393
e2ad650c
EZ
3394 * textprop.c (syms_of_textprop): Remove dead code.
3395 (copy_text_properties): Delete obsolete commentary about an
3396 interface that was deleted long ago. Fix typos in the description
3397 of arguments.
3398
1b2de274
EZ
3399 * msdos.c (XMenuActivate, XMenuAddSelection): Adjust argument list
3400 to changes in oldXMenu/XMenu.h from 2011-04-16.
3401 <menu_help_message, prev_menu_help_message>: Constify.
3402 (IT_menu_make_room): menu->help_text is now `const char **';
3403 adjust.
3404
3405 * msdos.h (XMenuActivate, XMenuAddSelection): Adjust prototypes
3406 to changes in oldXMenu/XMenu.h from 2011-04-16.
3407 (struct XMenu): Declare `help_text' `const char **'.
3408
3409 * xfaces.c <Qunspecified>: Make extern again.
3410
3411 * syntax.c: Include sys/types.h before including regex.h, as
3412 required by Posix.
3413
762b15be
EZ
3414 * doc.c (get_doc_string): Improve the format passed to `error'.
3415
3416 * doprnt.c (doprnt): Improve commentary.
3417
3418 * term.c (init_tty) [MSDOS]: Fix 1st argument to maybe_fatal.
3419
3420 * Makefile.in (TAGS): Depend on $(M_FILE) and $(S_FILE), and scan
3421 them with etags.
3422
f1052e5d
EZ
3423 * makefile.w32-in (globals.h): Add a dummy recipe, to make any
3424 changes in globals.h immediately force recompilation.
762b15be
EZ
3425 (TAGS): Depend on $(CURDIR)/m/intel386.h and
3426 $(CURDIR)/s/ms-w32.h.
3427 (TAGS-gmake): Scan $(CURDIR)/m/intel386.h and $(CURDIR)/s/ms-w32.h.
f1052e5d 3428
fa6996bc
EZ
3429 * character.c (Fchar_direction): Function deleted.
3430 (syms_of_character): Don't defsubr it.
3431 <char-direction-table>: Deleted.
3432
e6c3da20
EZ
34332011-04-23 Eli Zaretskii <eliz@gnu.org>
3434
3435 Fix doprnt so it could be used again safely in `verror'. (Bug#8435)
3436 * doprnt.c: Include limits.h.
3437 (SIZE_MAX): New macro.
04f2d78b
CB
3438 (doprnt): Return a size_t value. 2nd arg is now size_t.
3439 Many local variables are now size_t instead of int or unsigned.
e6c3da20
EZ
3440 Improve overflow protection. Support `l' modifier for integer
3441 conversions. Support %l conversion. Don't assume an EMACS_INT
3442 argument for integer conversions and for %c.
3443
3444 * lisp.h (doprnt): Restore prototype.
3445
3446 * makefile.w32-in ($(BLD)/callint.$(O)): Depend on
3447 $(SRC)/character.h.
3448
3449 * Makefile.in (base_obj): Add back doprnt.o.
3450
3451 * deps.mk (doprnt.o): Add back prerequisites.
3452 (callint.o): Depend on character.h.
3453
3454 * eval.c (internal_lisp_condition_case): Include the handler
3455 representation in the error message.
3456 (verror): Call doprnt instead of vsnprintf. Fix an off-by-one bug
3457 when breaking from the loop.
3458
3459 * xdisp.c (vmessage): Call doprnt instead of vsnprintf.
3460
3461 * callint.c (Fcall_interactively): When displaying error message
3462 about invalid control letter, pass the character's codepoint, not
3463 a pointer to its multibyte form. Improve display of the character
3464 in octal and display also its hex code.
3465
3466 * character.c (char_string): Use %x to display the (unsigned)
3467 codepoint of an invalid character, to avoid displaying a bogus
3468 negative value.
3469
3470 * font.c (check_otf_features): Pass SDATA of SYMBOL_NAME to
3471 `error', not SYMBOL_NAME itself.
3472
3473 * coding.c (Fencode_sjis_char, Fencode_big5_char): Use %c for
3474 character arguments to `error'.
3475
3476 * charset.c (check_iso_charset_parameter): Fix incorrect argument
3477 to `error' in error message about FINAL_CHAR argument. Make sure
3478 FINAL_CHAR is a character, and use %c when it is passed as
3479 argument to `error'.
3480
4ffd0d6b 34812011-04-23 Eli Zaretskii <eliz@gnu.org>
97a93095
EZ
3482
3483 * s/ms-w32.h (localtime): Redirect to sys_localtime.
3484
3485 * w32.c: Include <time.h>.
3486 (sys_localtime): New function.
3487
4ffd0d6b 34882011-04-23 Chong Yidong <cyd@stupidchicken.com>
c17819f4
CY
3489
3490 * xdisp.c (init_xdisp): Initialize echo_area_window (Bug#6451).
3491
4ffd0d6b 3492 * buffer.c (syms_of_buffer): Doc fix (Bug#6902).
aac0c6e3 3493
4ffd0d6b 34942011-04-23 Samuel Thibault <sthibault@debian.org> (tiny change)
aac0c6e3 3495
4ffd0d6b
GM
3496 * sysdep.c (wait_for_termination): On GNU Hurd, kill returns -1 on
3497 zombies (Bug#8467).
aac0c6e3 3498
04c56954
EZ
34992011-04-19 Eli Zaretskii <eliz@gnu.org>
3500
3501 * syntax.h (SETUP_SYNTAX_TABLE_FOR_OBJECT): Fix setting of
3502 gl_state.e_property when gl_state.object is Qt.
3503
3504 * insdel.c (make_gap_larger): Remove limitation of buffer size
3505 to <= INT_MAX.
3506
16a43933
CY
35072011-04-18 Chong Yidong <cyd@stupidchicken.com>
3508
3509 * xdisp.c (lookup_glyphless_char_display)
3510 (produce_glyphless_glyph): Handle cons cell entry in
3511 glyphless-char-display.
3512 (Vglyphless_char_display): Document it.
3513
3514 * term.c (produce_glyphless_glyph): Handle cons cell entry in
3515 glyphless-char-display.
3516
4581706e
CY
35172011-04-17 Chong Yidong <cyd@stupidchicken.com>
3518
3519 * xdisp.c (get_next_display_element): Remove unnecessary ifdefs.
3520
3521 * termhooks.h (FRAME_WINDOW_P): Remove duplicated definitions.
3522
3523 * dispextern.h (FACE_SUITABLE_FOR_ASCII_CHAR_P): Add missing
3524 definition for no-X builds.
3525
4887c6e2 35262011-04-16 Paul Eggert <eggert@cs.ucla.edu>
764430a3 3527
fd35b6f9
PE
3528 Static checks with GCC 4.6.0 and non-default toolkits.
3529
5c1ccb01
PE
3530 * s/sol2-6.h, s/unixware.h (PTY_TTY_NAME_SPRINTF): Protoize decl.
3531
006c5daa
PE
3532 * process.c (keyboard_bit_set): Define only if SIGIO.
3533 (send_process_trap): Mark it with NO_RETURN if it doesn't return.
3534 (send_process): Repair possible setjmp clobbering.
3535
efc736d3
PE
3536 * s/usg5-4-common.h (SETUP_SLAVE_PTY): Don't pass extra arg to 'fatal'.
3537
4e2fe2e6
PE
3538 * eval.c: Include <stdio.h>, for vsnprintf on non-GNU/Linux hosts.
3539
f97334a2
PE
3540 * data.c (arith_error): Mark with NO_RETURN if it doesn't return.
3541
4e75f29d
PE
3542 * alloc.c (bytes_used_when_full, SPARE_MEMORY, BYTES_USED):
3543 Define only if needed.
3544
90efadd1
PE
3545 * sysdep.c (_FILE_OFFSET_BITS): Make this hack even uglier
3546 by pacifying GCC about it. Maybe it's time to retire it?
875975e9 3547 * xfaces.c (USG, __TIMEVAL__): Likewise.
90efadd1 3548
3c647824
PE
3549 * dispextern.h (struct redisplay_interface): Rename param
3550 to avoid shadowing.
e264f262 3551 * termhooks.h (struct terminal): Likewise.
761383f4 3552 * xterm.c (xembed_send_message): Likewise.
3c647824 3553
b58c5c4a
PE
3554 * insdel.c (make_gap_smaller): Define only if
3555 USE_MMAP_FOR_BUFFERS || REL_ALLOC || DOUG_LEA_MALLOC.
3556
cad59032
PE
3557 * keyboard.c (read_char): Make a var volatile so longjmp won't clobber
3558 it.
3559
c339dc2e
PE
3560 * emacs.c (MAX_HEAP_BSS_DIFF, my_edata): Move to where they're used,
3561 so that we aren't warned about unused symbols.
3562
91a3e27b
PE
3563 * xfns.c (Fx_file_dialog): Rename local to avoid shadowing.
3564
399c71d3 3565 * xdisp.c (x_produce_glyphs): Mark var as initialized (Bug#8512).
7a3fb125 3566
8ffc96f5
PE
3567 * xfns.c (x_real_positions): Mark locals as initialized.
3568
eef9bc79
PE
3569 * xmenu.c (xmenu_show): Don't use uninitialized vars.
3570
098db9dd
PE
3571 * xterm.c: Fix problems found by static analysis with other toolkits.
3572 (toolkit_scroll_bar_interaction): Define and use only if USE_X_TOOLKIT.
dda3aedd
PE
3573 (x_dispatch_event): Declare static if USE_GTK, and
3574 define if USE_GTK || USE_X_TOOLKIT.
098db9dd 3575 (SET_SAVED_BUTTON_EVENT): Define only if USE_X_TOOLKIT || USE_GTK.
dda3aedd 3576 * xterm.h (x_dispatch_event): Extern only if USE_X_TOOLKIT.
841a1577
JB
3577 * xterm.c, xterm.h (x_mouse_leave): Bring this function back, but only
3578 if defined HAVE_MENUS && !defined USE_X_TOOLKIT && !defined USE_GTK.
098db9dd 3579
eb18f6cc
PE
3580 * xmenu.c (menu_help_callback): Pointer type fixes.
3581 Use const pointers when pointing at readonly data. Avoid pointer
3582 signedness clashes.
3583 (FALSE): Remove unused macro.
3584 (update_frame_menubar): Remove unused decl.
3585
1fe72bf8
PE
3586 * xfns.c (Fx_hide_tip): Move locals to avoid shadowing.
3587
60d9e1db
PE
3588 * menu.c (push_submenu_start, push_submenu_end): Do not define unless
3589 USE_X_TOOLKIT || USE_GTK || HAVE_NS || defined HAVE_NTGUI.
3590 (single_menu_item): Rename local to avoid shadowing.
3591
39261c26
PE
3592 * keyboard.c (make_lispy_event): Remove unused local var.
3593
018c5e19
PE
3594 * frame.c, frame.h (x_get_resource_string): Bring this back, but
3595 only if HAVE_X_WINDOWS && !USE_X_TOOLKIT.
3596
63d2b86e
PE
3597 * bitmaps: Change bitmaps from unsigned char back to the X11
3598 compatible char. Avoid the old compiler warnings about
3599 out-of-range initializers by using, for example, '\xab' rather
3600 than 0xab.
3601
aefd87e1
PE
3602 * xgselect.c (xgselect_initialize): Check vs interface
3603 even if ! (defined (USE_GTK) || defined (HAVE_GCONF)).
3604
bf501fb9
PE
3605 * xmenu.c (xmenu_show): Rename parm to avoid shadowing.
3606
e9829fdf
PE
3607 * xterm.c (x_create_toolkit_scroll_bar): Use const * for pointers
3608 to read-only memory.
3609
1086c095
PE
3610 * fns.c (vector): Remove; this old hack is no longer needed.
3611
2baccd04 3612 * xsmfns.c (create_client_leader_window): Rename shadowing arg.
401f10cb 3613 Remove unused var.
dde42981 3614 (gdk_x11_set_sm_client_id) [!USE_GTK]: Don't define.
2baccd04 3615
72391843 3616 * xrdb.c (x_load_resources): Omit unused local.
3565b346 3617
436c16df 3618 * xfns.c (free_frame_menubar, atof): Remove duplicate decls.
8a94ea33 3619 (x_window): Rename locals to avoid shadowing.
dc5ddd85 3620 (USG): Use the kludged USG macro, to pacify gcc.
436c16df 3621
92bb796d 3622 * xterm.c (x_alloc_nearest_color_for_widget): Remove; unused.
bbbef9e1 3623 (x_term_init): Remove local to avoid shadowing.
92bb796d 3624
764430a3 3625 * xfns.c, xterm.c (_XEditResCheckMessages): Protoize decl.
4887c6e2
PE
3626
3627 * xdisp.c, dispextern.h (set_vertical_scroll_bar): Now extern if
3628 USE_TOOLKIT_SCROLL_BARS && !USE_GTK, as xterm.c needs it then.
3629
d1dfb56c
EZ
36302011-04-16 Eli Zaretskii <eliz@gnu.org>
3631
c4354cb4
EZ
3632 * gnutls.c (Fgnutls_boot): Don't pass Lisp_Object to `error'.
3633
d1dfb56c
EZ
3634 Fix regex.c, syntax.c and friends for buffers > 2GB.
3635 * syntax.h (struct gl_state_s): Declare character position members
3636 EMACS_INT.
3637
3638 * syntax.c (update_syntax_table): Declare 2nd argument EMACS_INT.
3639
04f2d78b
CB
3640 * textprop.c (verify_interval_modification, interval_of):
3641 Declare arguments EMACS_INT.
d1dfb56c
EZ
3642
3643 * intervals.c (adjust_intervals_for_insertion): Declare arguments
3644 EMACS_INT.
3645
3646 * intervals.h (CHECK_TOTAL_LENGTH): Cast to EMACS_INT, not `int'.
3647
3648 * indent.c (Fvertical_motion): Local variable it_start is now
3649 EMACS_INT.
3650
3651 * regex.c (re_match, re_match_2, re_match_2_internal)
3652 (bcmp_translate, regcomp, regexec, print_double_string)
3653 (group_in_compile_stack, re_search, re_search_2, regex_compile)
3654 (re_compile_pattern, re_exec): Declare arguments and local
3655 variables `size_t' and `ssize_t' and return values `regoff_t', as
3656 appropriate.
3657 (POP_FAILURE_REG_OR_COUNT) <pfreg>: Declare `long'.
3658 (CHECK_INFINITE_LOOP) <failure>: Declare `ssize_t'.
3659 <compile_stack_type>: `size' and `avail' are now `size_t'.
3660
3661 * regex.h <regoff_t>: Use ssize_t, not int.
3662 (re_search, re_search_2, re_match, re_match_2): Arguments that
3663 specify buffer/string position and length are now ssize_t and
3664 size_t. Return type is regoff_t.
3665
613052cd
BK
36662011-04-16 Ben Key <bkey76@gmail.com>
3667
3668 * nsfont.m: Fixed bugs in ns_get_family and
3669 ns_descriptor_to_entity that were caused by using free to
3670 deallocate memory blocks that were allocated by xmalloc (via
3671 xstrdup). This caused Emacs to crash when compiled with
3672 XMALLOC_OVERRUN_CHECK defined (when Emacs was configured with
3673 --enable-checking=xmallocoverrun). xfree is now used to
3674 deallocate these memory blocks.
3675
4170f62f 36762011-04-15 Paul Eggert <eggert@cs.ucla.edu>
3e047f51 3677
71b41406
PE
3678 * sysdep.c (emacs_read): Remove unnecessary check vs MAX_RW_COUNT.
3679
9587a89d
PE
3680 emacs_write: Accept and return EMACS_INT for sizes.
3681 See http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00514.html
3682 et seq.
3683 * gnutls.c, gnutls.h (emacs_gnutls_read, emacs_gnutls_write):
3684 Accept and return EMACS_INT.
3685 (emacs_gnutls_write): Return the number of bytes written on
3686 partial writes.
3687 * sysdep.c, lisp.h (emacs_read, emacs_write): Likewise.
273a5f82
PE
3688 (emacs_read, emacs_write): Remove check for negative size, as the
3689 Emacs source code has been audited now.
9587a89d
PE
3690 * sysdep.c (MAX_RW_COUNT): New macro, to work around kernel bugs.
3691 (emacs_read, emacs_write): Use it.
273a5f82
PE
3692 * process.c (send_process): Adjust to the new signatures of
3693 emacs_write and emacs_gnutls_write. Do not attempt to store
3694 a byte offset into an 'int'; it might overflow.
9587a89d 3695 See http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00483.html
273a5f82 3696
3e047f51
PE
3697 * sound.c: Don't assume sizes fit in 'int'.
3698 (struct sound_device.period_size, alsa_period_size):
9c3c56a7 3699 Return EMACS_INT, not int.
3e047f51 3700 (struct sound_device.write, vox_write, alsa_write):
9c3c56a7
PE
3701 Accept EMACS_INT, not int.
3702 (wav_play, au_play): Use EMACS_INT to store sizes and to
3e047f51
PE
3703 record read return values.
3704
cc39a9db
BK
37052011-04-15 Ben Key <bkey76@gmail.com>
3706
c9d0ec6d
JB
3707 * keyboard.c (Qundefined): Don't declare static since it is used
3708 in nsfns.m.
3709 * xfaces.c (Qbold, Qexpanded, Qitalic, Qcondensed): Don't declare
3710 static since they are used in nsfont.m.
cc39a9db 3711
6c60eb9f
SM
37122011-04-15 Stefan Monnier <monnier@iro.umontreal.ca>
3713
3714 * process.c (Qprocessp): Don't declare static.
3715 * lisp.h (Qprocessp): Declare again.
3716
7990b61a
JB
37172011-04-15 Juanma Barranquero <lekktu@gmail.com>
3718
3719 * font.c (Qopentype): Don't make static (used from w32uniscribe.c).
3720
5d4cb038
PE
37212011-04-14 Paul Eggert <eggert@cs.ucla.edu>
3722
8bd7b830 3723 Improve C-level modularity by making more things 'static'.
cd64ea1d 3724
e3b27b31
PE
3725 Don't publish debugger-only interfaces to other modules.
3726 * lisp.h (safe_debug_print, debug_output_compilation_hack):
3727 (verify_bytepos, count_markers): Move decls to the only modules
3728 that need them.
3729 * region-cache.h (pp_cache): Likewise.
3730 * window.h (check_all_windows): Likewise.
3731 * marker.c, print.c, region-cache.c, window.c: Decls moved here.
3732
5d4cb038
PE
3733 * sysdep.c (croak): Now static, if
3734 defined TIOCNOTTY || defined USG5 || defined CYGWIN.
3735 * syssignal.h (croak): Declare only if not static.
69003fd8
PE
3736
3737 * alloc.c (refill_memory_reserve): Now static if
3738 !defined REL_ALLOC || defined SYSTEM_MALLOC.
3739 * lisp.h (refill_memory_reserve): Declare only if not static.
93ea6e8f 3740
e87b6180
PE
3741 * xsettings.c, xsettings.h (xsettings_get_system_normal_font):
3742 Define only if USE_LUCID.
3743
ac64929e
PE
3744 * xrdb.c (x_customization_string, x_rm_string): Now static.
3745
6f37259d
PE
3746 * xmenu.c (x_menu_wait_for_event): Export only if USE_MOTIF.
3747 * xterm.h (x_menu_wait_for_event): Declare only if USE_MOTIF.
3748
1683e3ab
PE
3749 * xdisp.c (draw_row_with_mouse_face): Now static.
3750 * dispextern.h (draw_row_with_mouse_fave): Remove decl.
3751
de9c2632
PE
3752 * window.h (check_all_windows): Mark externally visible.
3753
2b96acb7
PE
3754 * window.c (window_deletion_count): Now static.
3755
3756 * undo.c: Make symbols static if they're not exported.
3757 (last_undo_buffer, last_boundary_position, pending_boundary):
3758 Now static.
3759
50436f33
PE
3760 * textprop.c (interval_insert_behind_hooks): Now static.
3761 (interval_insert_in_front_hooks): Likewise.
3762
64520e5c
PE
3763 * term.c: Make symbols static if they're not exported.
3764 (tty_turn_off_highlight, get_tty_terminal, max_frame_cols):
3765 (max_frame_lines, tty_set_terminal_modes):
3766 (tty_reset_terminal_modes, tty_turn_off_highlight):
3767 (get_tty_terminal): Now static.
3768 (term_mouse_moveto): Do not define if HAVE_WINDOW_SYSTEM.
3769 * termhooks.h (term_mouse_moveto): Do not declare if
8bd7b830 3770 HAVE_WINDOW_SYSTEM.
64520e5c
PE
3771 * dispextern.h (tty_set_terminal_modes, tty_reset_terminal_modes):
3772 (tty_turn_off_highlight, get_tty_terminal): Remove decls.
3773
1fa53021
PE
3774 * sysdep.c: Make symbols static if they're not exported.
3775 (emacs_get_tty, emacs_set_tty, old_fcntl_flags, old_fcntl_owner):
3776 Now static.
3777 (sigprocmask_set, full_mask): Remove; unused.
3778 (wait_debugging): Mark as visible.
3779 * syssignal.h (SIGFULLMASK, full_mask): Remove decls.
3780 * systty.h (emacs_get_tty, emacs_set_tty): Remove decls.
3781
d4b43b22
PE
3782 * syntax.c (syntax_temp): Define only if !__GNUC__.
3783
b7c513d0
PE
3784 * sound.c (current_sound_device, current_sound): Now static.
3785
989b29ad
PE
3786 * search.c (searchbufs, searchbuf_head): Now static.
3787
13a55a78
PE
3788 * scroll.c (scroll_cost): Remove; unused.
3789 * dispextern.h (scroll_cost): Remove decl.
3790
de68a1fc
PE
3791 * region-cache.h (pp_cache): Mark as externally visible.
3792
40ccffa6
PE
3793 * process.c: Make symbols static if they're not exported.
3794 (process_tick, update_tick, create_process, chan_process):
3795 (Vprocess_alist, proc_buffered_char, datagram_access):
3796 (fd_callback_data, send_process_frame, process_sent_to): Now static.
3797 (deactivate_process): Mark defn as static, as well as decl.
3798 * lisp.h (create_process): Remove decl.
3799 * process.h (chan_process, Vprocess_alist): Remove decls.
3800
ad64fc97
PE
3801 * print.c: Make symbols static if they're not exported.
3802 (print_depth, new_backquote_output, being_printed, print_buffer):
3803 (print_buffer_size, print_buffer_pos, print_buffer_pos_byte):
3804 (print_interval, print_number_index, initial_stderr_stream):
3805 Now static.
3806 * lisp.h (Fprinc): Remove decl.
3807 (debug_output_compilation_hack): Mark as externally visible.
3808
adddb265
PE
3809 * sysdep.c (croak): Move decl from here to syssignal.h.
3810 * syssignal.h (croak): Put it here, so the API can be checked when
3811 'croak' is called from dissociate_if_controlling_tty.
3812
1717ede2
PE
3813 * minibuf.c: Make symbols static if they're not exported.
3814 (minibuf_save_list, choose_minibuf_frame): Now static.
3815 * lisp.h (choose_minibuf_frame): Remove decl.
3816
fa5fb2bc
PE
3817 * lisp.h (verify_bytepos, count_markers): Mark as externally visible.
3818
1e3890d1
PE
3819 * lread.c: Make symbols static if they're not exported.
3820 (read_objects, initial_obarray, oblookup_last_bucket_number):
3821 Now static.
3822 (make_symbol): Remove; unused.
3823 * lisp.h (initial_obarray, make_symbol): Remove decls.
3824
8a1414fa
PE
3825 * keyboard.c: Make symbols static if they're not exported.
3826 (single_kboard, recent_keys_index, total_keys, recent_keys):
3827 (this_command_key_count_reset, raw_keybuf, raw_keybuf_count):
3828 (this_single_command_key_start, echoing, last_auto_save):
3829 (read_key_sequence_cmd, dribble, recursive_edit_unwind):
3830 (command_loop, echo_now, keyboard_init_hook, help_char_p):
3831 (quit_throw_to_read_char, command_loop_2, top_level_1, poll_timer):
3832 (Vlispy_mouse_stem, double_click_count):
3833 Now static.
3834 (force_auto_save_soon): Define only if SIGDANGER.
3835 (ignore_mouse_drag_p): Now static if
3836 !defined HAVE_WINDOW_SYSTEM || defined USE_GTK || defined HAVE_NS.
3837 (print_help): Remove; unused.
3838 (stop_character, last_timer_event): Mark as externally visible.
3839 * keyboard.h (ignore_mouse_drag_p): Declare only if
3840 defined HAVE_WINDOW_SYSTEM && !defined USE_GTK && !defined HAVE_NS.
3841 (echo_now, help_char_p, quit_throw_to_read_char): Remove decls.
3842 * lisp.h (echoing): Remove decl.
3843 (force_auto_save_soon): Declare only if SIGDANGER.
3844 * xdisp.c (redisplay_window): Simplify code, to make it more
3845 obvious that ignore_mouse_drag_p is not accessed if !defined
3846 USE_GTK && !defined HAVE_NS.
3847
93ea6e8f
PE
3848 * intervals.c: Make symbols static if they're not exported.
3849 (merge_properties_sticky, merge_interval_right, delete_interval):
3850 Now static.
3851 * intervals.h (merge_interval_right, delete_interval): Remove decls.
3852
77382fcc
PE
3853 * insdel.c: Make symbols static if they're not exported.
3854 However, leave prepare_to_modify_buffer alone. It's never
3855 called from outside this function, but that appears to be a bug.
3856 (combine_after_change_list, combine_after_change_buffer):
4889fc82 3857 (adjust_after_replace, signal_before_change): Now static.
77382fcc
PE
3858 (adjust_after_replace_noundo): Remove; unused.
3859 * lisp.h (adjust_after_replace, adjust_after_replace_noundo):
4889fc82 3860 (signal_before_change): Remove decls.
77382fcc 3861
9306c32e
PE
3862 * indent.c (val_compute_motion, val_vmotion): Now static.
3863
cd44d2eb
PE
3864 * image.c: Make symbols static if they're not exported.
3865 * dispextern.h (x_create_bitmap_from_xpm_data): Do not declare
3866 if USE_GTK.
3867 * image.c (x_create_bitmap_from_xpm_data): Do not define if USE_GTK.
3868 (xpm_color_cache, ct_table, ct_colors_allocated): Now static.
3869
ad9a7a06
PE
3870 * fringe.c (standard_bitmaps): Now static.
3871 (max_used_fringe_bitmap): Now static, unless HAVE_NS.
3872
81626931
PE
3873 * frame.c: Make symbols static if they're not exported.
3874 (x_report_frame_params, make_terminal_frame): Now static.
3875 (get_frame_param): Now static, unless HAVE_NS.
3876 (x_fullscreen_adjust): Define if WINDOWSNT, not if HAVE_WINDOW_SYSTEM.
3877 (x_get_resource_string): Remove; not used.
3878 * frame.h (make_terminal_frame, x_report_frame_params):
3879 (x_get_resource_string); Remove decls.
3880 (x_fullscreen_adjust): Declare only if WINDOWSNT.
3881 * lisp.h (get_frame_param): Declare only if HAVE_NS.
3882
239f9db9
PE
3883 * font.c, fontset.c: Make symbols static if they're not exported.
3884 * dispextern.h (FACE_SUITABLE_FOR_ASCII_CHAR_P): New macro.
3885 (FACE_SUITABLE_FOR_CHAR_P): Use it.
3886 * font.c (font_close_object): Now static.
3887 * font.h (font_close_object): Remove.
3888 * fontset.c (FONTSET_OBJLIST): Remove.
3889 (free_realized_fontset) #if-0 the body, which does nothing.
3890 (face_suitable_for_char_p): #if-0, as it's never called.
3891 * fontset.h (face_suitable_for_char_p): Remove decl.
04f2d78b
CB
3892 * xfaces.c (face_at_string_position):
3893 Use FACE_SUITABLE_FOR_ASCII_CHAR_P, not FACE_SUITABLE_FOR_CHAR_P,
239f9db9
PE
3894 since 0 is always ASCII.
3895
dfcf3579
PE
3896 * fns.c (weak_hash_tables): Now static.
3897
5045092b
PE
3898 * fileio.c: Make symbols static if they're not exported.
3899 (auto_saving, auto_save_mode_bits, auto_save_error_occurred):
3900 (Vwrite_region_annotation_buffers): Now static.
3901
57a96f5c
PE
3902 * eval.c: Make symbols static if they're not exported.
3903 (backtrace_list, lisp_eval_depth, when_entered_debugger): Now static.
3904 * lisp.h (backtrace_list): Remove decl.
3905
35f08c38
PE
3906 * emacs.c: Make symbols static if they're not exported.
3907 (malloc_state_ptr, malloc_using_checking, syms_of_emacs):
3908 (fatal_error_code, fatal_error_signal_hook, standard_args):
3909 Now static.
3910 (fatal_error_signal): Now static, unless FLOAT_CATCH_SIGKILL.
3911 (DEFINE_DUMMY_FUNCTION): Mark function as externally visible.
3912 (__CTOR_LIST__, __DTOR_LIST__): Now externally visible.
3913 * lisp.h (fatal_error_signal_hook): Remove decl.
3914 (fatal_error_signal): Declare only if FLOAT_CATCH_SIGKILL.
3915
f44bd759
PE
3916 * editfns.c: Move a (normally-unused) function to its only use.
3917 * editfns.c, lisp.h (get_operating_system_release): Remove.
3918 * process.c (init_process) [DARWIN_OS]: Do it inline, as it is not
3919 worth the hassle of breaking this out.
3920
b532497d
PE
3921 * xterm.c: Make symbols static if they're not exported.
3922 (x_raise_frame, x_lower_frame, x_wm_set_window_state):
3923 (x_wm_set_icon_pixmap, x_initialize, XTread_socket_fake_io_error):
3924 (x_destroy_window, x_delete_display):
3925 Now static.
3926 (x_dispatch_event): Now static if ! (USE_MOTIF || USE_X_TOOLKIT).
3927 (x_mouse_leave): Remove; unused.
3928 * xterm.h (x_display_info_for_name, x_raise_frame, x_lower_frame):
3929 (x_destroy_window, x_wm_set_window_state, x_wm_set_icon_pixmap):
3930 (x_delete_display, x_initialize, x_set_border_pixel, x_screen_planes):
3931 Remove decls.
3932 (x_mouse_leave): Declare only if WINDOWSNT.
3933 (x_dispatch_event): Declare only if USE_MOTIF or USE_X_TOOLKIT.
3934 (xic_create_fontsetname): Declare only if HAVE_X_WINDOWS &&
3935 USE_X_TOOLKIT.
3936
1675728f
PE
3937 * ftxfont.c: Make symbols static if they're not exported.
3938 (ftxfont_driver): Export only if !defined HAVE_XFT && def8ined
3939 HAVE_FREETYPE.
3940 * font.h (ftxfont_driver): Likewise.
3941
e4cebfca
PE
3942 * xfns.c: Make symbols static if they're not exported.
3943 (x_last_font_name, x_display_info_for_name):
3944 (x_set_foreground_color, x_set_background_color, x_set_mouse_color):
3945 (x_set_cursor_color, x_set_border_pixel, x_set_border_color):
3946 (x_set_cursor_type, x_set_icon_type, x_set_icon_name):
3947 (x_set_scroll_bar_foreground, x_set_scroll_bar_background):
3948 (x_explicitly_set_name, x_set_title, xic_defaut_fontset, tip_timer):
3949 (last_show_tip_args): Now static.
3950 (xic_defaut_fontset, xic_create_fontsetname): Define only if
3951 defined HAVE_X_WINDOWS && defined USE_X_TOOLKIT
3952 (x_screen_planes): Remove; unused.
3953 * dispextern.h (x_screen_planes): Remove decl.
3954
5bf46f05
PE
3955 * dispnew.c: Make symbols static if they're not exported.
3956 * dispextern.h (redraw_garbaged_frames, scrolling):
3957 (increment_row_positions): Remove.
3958 * dispnew.c (new_glyph_matrix, increment_row_positions, scrolling):
3959 (delayed_size_change, glyph_matrix_count, glyph_pool_count):
3960 Now static.
3961 (redraw_garbaged_frames): Remove; unused.
3962
435f4c28
PE
3963 * xfaces.c: Make symbols static if they're not exported.
3964 * dispextern.h (ascii_face_of_lisp_face, free_realized_face):
3965 Remove decls.
3966 * xterm.h (defined_color): Remove decls.
3967 (x_free_dpy_colors): Declare only if USE_X_TOOLKIT.
3968 * xfaces.c (tty_suppress_bold_inverse_default_colors_p):
3969 (menu_face_changed_default, defined_color, free_realized_face):
3970 (x_free_dpy_colors): Define only if USE_X_TOOLKIT.
3971 (ascii_face_of_lisp_face): Remove; unused.
3972
8524aef3
PE
3973 * xdisp.c: Make symbols static if they're not exported.
3974 * dispextern.h (scratch_glyph_row, window_box_edges):
3975 (glyph_to_pixel_coords, set_cursor_from_row):
3976 (get_next_display_element, set_iterator_to_next):
3977 (highlight_trailing_whitespace, frame_to_window_pixel_xy):
3978 (show_mouse_face): Remove decls
3979 * frame.h (message_buf_print): Likewise.
3980 * lisp.h (pop_message, set_message, check_point_in_composition):
3981 Likewise.
3982 * xterm.h (set_vertical_scroll_bar): Likewise.
3983 * xdisp.c (list_of_error, Vmessage_stack, line_number_displayed):
3984 (message_buf_print, scratch_glyph_row, displayed_buffer):
3985 (set_iterator_to_next, pop_message, set_message, set_cursor_from_row):
3986 (get_next_display_element, show_mouse_face, window_box_edges):
3987 (frame_to_window_pixel_xy, check_point_in_composition):
3988 (set_vertical_scroll_bar, highlight_trailing_whitespace): Now static.
3989 (glyph_to_pixel_coords): Remove; unused.
3990
16390cd2
PE
3991 * dired.c (file_name_completion): Now static.
3992
3993 * dbusbind.c (xd_in_read_queued_messages): Now static.
3994
a25f4dfa
PE
3995 * lisp.h (circular_list_error, FOREACH): Remove; unused.
3996 * data.c (circular_list_error): Remove.
3997
14a9c8df
PE
3998 * commands.h (last_point_position, last_point_position_buffer):
3999 (last_point_position_window): Remove decls.
4000 * keyboard.c: Make these variables static.
4001
04f2d78b
CB
4002 * coding.h (coding, code_convert_region, encode_coding_gap):
4003 Remove decls.
74ab6df5
PE
4004 * coding.c (Vsjis_coding_system, Vbig5_coding_system):
4005 (iso_code_class, detect_coding, code_convert_region): Now static.
4006 (encode_coding_gap): Remove; unused.
4007
38dfbee1
PE
4008 * chartab.c (chartab_chars, chartab_bits): Now static.
4009
a2cb4e63
PE
4010 * charset.h (charset_iso_8859_1): Remove decl.
4011 * charset.c (charset_iso_8859_1, charset_emacs, map_charset_for_dump):
4012 Now static.
4013
127198fd
PE
4014 * ccl.h (check_ccl_update, Vccl_program_table): Remove decls.
4015 * ccl.c (Vccl_program_table): Now static.
4016 (check_ccl_update): Remove; unused.
4017
d85b608f
PE
4018 * category.c (SET_CATEGORY_SET, set_category_set): Move here.
4019 * category.h: ... from here.
4020 * category.c (check_category_table, set_category_set): Now static.
4021
31cd66f3
PE
4022 * casetab.c (Vascii_upcase_table, Vascii_eqv_table): Now static.
4023 * lisp.h: Remove these decls.
4024
c358e587
PE
4025 * buffer.c (buffer_count): Remove unused var.
4026
e78aecca
PE
4027 * bidi.c (bidi_dump_cached_states): Mark as externally visible,
4028 so that it's not optimized away.
4029 (bidi_ignore_explicit_marks_for_paragraph_level): Likewise.
4030 * dispextern.h (bidi_dump_cached_states): Remove, since it's
4031 exported only to the debugger.
4032
e192d7d3 4033 * atimer.c (alarm_signal_handler, run_all_atimers): Now static.
04f2d78b 4034 * atimer.h (run_all_atimers): Remove; not exported.
e192d7d3 4035
92470028
PE
4036 font.c: Make copy_font_spec and merge_font_spec ordinary C functions.
4037 * font.c (copy_font_spec): Rename from Fcopy_font_spec, since it
4038 was inaccessible from Lisp.
4039 (merge_font_spec): Likewise, renaming from Fmerge_font_spec.
4040 * font.c, font.h, fontset.c, xfaces.c, xfont.c: Change all uses.
4041
244ed907
PE
4042 alloc.c: Import and export fewer symbols, and remove unused items.
4043 * lisp.h (suppress_checking, die): Declare only if ENABLE_CHECKING
4044 is defined.
4045 (suppress_checking): Add EXTERNALLY_VISIBLE attribute, so that
4046 it's not optimized away by whole-program optimization.
4047 (message_enable_multibyte, free_misc): Remove.
4048 (catchlist, handlerlist, mark_backtrace):
4049 Declare only if BYTE_MARK_STACK.
4050 (mark_byte_stack): Likewise, fixing a ifdef-vs-if typo.
4051 * alloc.c (pure): Export only if VIRT_ADDR_VARIES is defined.
4052 (message_enable_multibyte): Remove decl.
4053 (free_misc, interval_free_list, float_block, float_block_index):
4054 (n_float_blocks, float_free_list, cons_block, cons_block_index):
4055 (cons_free_list, last_marked_index):
4056 Now static.
4057 (suppress_checking, die): Define only if ENABLE_CHECKING is defined.
4058 * eval.c (catchlist, handlerlist): Export only if BYTE_MARK_STACK.
4059 (mark_backtrace): Define only if BYTE_MARK_STACK.
4060 * xdisp.c (message_enable_multibyte): Now static.
4061
61c2b50e 4062 Declare Lisp_Object Q* variables to be 'static' if not exported.
955cbe7b
PE
4063 This makes it easier for human readers (and static analyzers)
4064 to see whether these variables are used from other modules.
4065 * alloc.c, buffer.c, bytecode.c, callint.c, casetab.c, category.c:
4066 * ccl.c, character.c, charset.c, cmds.c, coding.c, composite.c:
4067 * data.c, dbusbind.c, dired.c, editfns.c, eval.c, fileio.c, fns.c:
4068 * font.c, frame.c, fringe.c, ftfont.c, image.c, keyboard.c, keymap.c:
4069 * lread.c, macros.c, minibuf.c, print.c, process.c, search.c:
4070 * sound.c, syntax.c, textprop.c, window.c, xdisp.c, xfaces.c, xfns.c:
4071 * xmenu.c, xselect.c:
4072 Declare Q* vars static if they are not used in other modules.
4073 * ccl.h, character.h, charset.h, coding.h, composite.h, font.h:
4074 * frame.h, intervals.h, keyboard.h, lisp.h, process.h, syntax.h:
4075 Remove decls of unexported vars.
4076 * keyboard.h (EVENT_HEAD_UNMODIFIED): Remove now-unused macro.
4077
95c82688
PE
4078 * lisp.h (DEFINE_FUNC): Make sname 'static'.
4079
16a97296
PE
4080 Make Emacs functions such as Fatom 'static' by default.
4081 This makes it easier for human readers (and static analyzers)
4082 to see whether these functions can be called from other modules.
4083 DEFUN now defines a static function. To make the function external
4084 so that it can be used in other C modules, use the new macro DEFUE.
8bd7b830
PE
4085 * lisp.h (Funibyte_char_to_multibyte, Fsyntax_table_p):
4086 (Finit_image_library):
16a97296
PE
4087 (Feval_region, Fbacktrace, Ffetch_bytecode, Fswitch_to_buffer):
4088 (Ffile_executable_p, Fmake_symbolic_link, Fcommand_execute):
4089 (Fget_process, Fdocumentation_property, Fbyte_code, Ffile_attributes):
4090 Remove decls, since these functions are now static.
4091 (Funintern, Fget_internal_run_time): New decls, since these functions
4092 were already external.
95c82688 4093
16a97296
PE
4094 * alloc.c, buffer.c, callint.c, callproc.c, casefiddle.c, casetab.c:
4095 * ccl.c, character.c, chartab.c, cmds.c, coding.c, data.c, dispnew.c:
4096 * doc.c, editfns.c, emacs.c, eval.c, fileio.c, filelock.c, floatfns.c:
4097 * fns.c, font.c, fontset.c, frame.c, image.c, indent.c:
4098 * keyboard.c, keymap.c, lread.c:
4099 * macros.c, marker.c, menu.c, minibuf.c, print.c, process.c, search.c:
4100 * syntax.c, term.c, terminal.c, textprop.c, undo.c:
4101 * window.c, xdisp.c, xfaces.c, xfns.c, xmenu.c, xsettings.c:
4102 Mark functions with DEFUE instead of DEFUN,
4103 if they are used in other modules.
4104 * buffer.c (Fset_buffer_major_mode, Fdelete_overlay): New forward
4105 decls for now-static functions.
4106 * buffer.h (Fdelete_overlay): Remove decl.
4107 * callproc.c (Fgetenv_internal): Mark as internal.
4108 * composite.c (Fremove_list_of_text_properties): Remove decl.
4109 (Fcomposition_get_gstring): New forward static decl.
4110 * composite.h (Fcomposite_get_gstring): Remove decl.
4111 * dired.c (Ffile_attributes): New forward static decl.
4112 * doc.c (Fdocumntation_property): New forward static decl.
4113 * eval.c (Ffetch_bytecode): New forward static decl.
4114 (Funintern): Remove extern decl; now in .h file where it belongs.
4115 * fileio.c (Fmake_symbolic_link): New forward static decl.
4116 * image.c (Finit_image_library): New forward static decl.
4117 * insdel.c (Fcombine_after_change_execute): Make forward decl static.
4118 * intervals.h (Fprevious_property_change):
4119 (Fremove_list_of_text_properties): Remove decls.
4120 * keyboard.c (Fthis_command_keys): Remove decl.
4121 (Fcommand_execute): New forward static decl.
4122 * keymap.c (Flookup_key): New forward static decl.
4123 (Fcopy_keymap): Now static.
4124 * keymap.h (Flookup_key): Remove decl.
4125 * process.c (Fget_process): New forward static decl.
4126 (Fprocess_datagram_address): Mark as internal.
4127 * syntax.c (Fsyntax_table_p): New forward static decl.
4128 (skip_chars): Remove duplicate decl.
4129 * textprop.c (Fprevious_property_change): New forward static decl.
4130 * window.c (Fset_window_fringes, Fset_window_scroll_bars):
4131 Now internal.
4132 (Fset_window_margins, Fset_window_vscroll): New forward static decls.
4133 * window.h (Fset_window_vscroll, Fset_window_margins): Remove decls.
4134
785bbd42
PE
4135 * editfns.c (Fformat): Remove unreachable code.
4136
8b913b57
AS
41372011-04-14 Andreas Schwab <schwab@linux-m68k.org>
4138
4139 * fileio.c (Finsert_file_contents): Fix typo in 2005-05-13
4140 change. (Bug#8496)
4141
a6744a35
EZ
41422011-04-13 Eli Zaretskii <eliz@gnu.org>
4143
4144 * xdisp.c (handle_invisible_prop): Don't call bidi_paragraph_init
4145 when at ZV. (Bug#8487)
4146
e7974947
AS
41472011-04-12 Andreas Schwab <schwab@linux-m68k.org>
4148
baad03f0
AS
4149 * charset.c (Fclear_charset_maps): Use xfree instead of free.
4150 (Bug#8437)
4151 * keyboard.c (parse_tool_bar_item): Likewise.
4152 * sound.c (sound_cleanup, alsa_close): Likewise.
4153 * termcap.c (tgetent): Likewise.
4154 * xfns.c (x_default_font_parameter): Likewise.
4155 * xsettings.c (read_and_apply_settings): Likewise.
4156
e7974947
AS
4157 * alloc.c (overrun_check_malloc, overrun_check_realloc)
4158 (overrun_check_free): Protoize.
4159
28272684
PE
41602011-04-12 Paul Eggert <eggert@cs.ucla.edu>
4161
4162 * sysdep.c (emacs_read, emacs_write): Check for negative sizes
4163 since callers should never pass a negative size.
4164 Change the signature to match that of plain 'read' and 'write'; see
4165 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00397.html>.
4166 * lisp.h: Update prototypes of emacs_write and emacs_read.
4167
11997c76
EZ
41682011-04-11 Eli Zaretskii <eliz@gnu.org>
4169
4170 * xdisp.c (redisplay_window): Don't try to determine the character
4171 position of the scroll margin if the window start point w->startp
e896f03c 4172 is outside the buffer's accessible region. (Bug#8468)
11997c76 4173
8a2cbd72
EZ
41742011-04-10 Eli Zaretskii <eliz@gnu.org>
4175
4176 Fix write-region and its subroutines for buffers > 2GB.
4177 * fileio.c (a_write, e_write): Modify declaration of arguments and
4178 local variables to support buffers larger than 2GB.
4179 (Fcopy_file): Use EMACS_INT for return value of emacs_read.
4180
4181 * sysdep.c (emacs_write, emacs_read): Use ssize_t for last
4182 argument, local variables, and return value.
4183
4184 * lisp.h: Update prototypes of emacs_write and emacs_read.
4185
4186 * sound.c (vox_write): Use ssize_t for return value of emacs_write.
4187
4073e537 41882011-04-10 Paul Eggert <eggert@cs.ucla.edu>
eb3f1cc8 4189
1ebfdcb6
PE
4190 * xdisp.c (vmessage): Use memchr, not strnlen, which some hosts lack.
4191
b2ded58d
PE
4192 Fix more problems found by GCC 4.6.0's static checks.
4193
7d66342c
PE
4194 * xdisp.c (vmessage): Use a better test for character truncation.
4195
bbf47d44
PE
4196 * charset.c (load_charset_map): <, not <=, for optimization,
4197 and to avoid potential problems with integer overflow.
9248994d 4198 * chartab.c (sub_char_table_set_range, char_table_set_range): Likewise.
f9a68bc5 4199 * casetab.c (set_identity, shuffle): Likewise.
3ab1c7ce 4200 * editfns.c (Fformat): Likewise.
1e69125e 4201 * syntax.c (skip_chars): Likewise.
3befa583 4202
e3019616
PE
4203 * xmenu.c (set_frame_menubar): Allocate smaller local vectors.
4204 This also lets GCC 4.6.0 generate slightly better loop code.
4205
becfa255
PE
4206 * callint.c (Fcall_interactively): <, not <=, for optimization.
4207 (Fcall_interactively): Count the number of arguments produced,
4208 not the number of arguments given. This is simpler and lets GCC
4209 4.6.0 generate slightly better code.
4210
dae0cd48
PE
4211 * ftfont.c: Distingish more carefully between FcChar8 and char.
4212 The previous code passed unsigned char * to a functions like
4213 strlen and xstrcasecmp that expect char *, which does not
4214 conform to the C standard.
4215 (get_adstyle_property, ftfont_pattern_entity): Use FcChar8 for
4216 arguments to FcPatternGetString, and explicitly cast FcChar8 * to
4217 char * when the C standard requires it.
4218
76032d70
PE
4219 * keyboard.c (read_char): Remove unused var.
4220
eb3f1cc8
PE
4221 * eval.c: Port to Windows vsnprintf (Bug#8435).
4222 Include <limits.h>.
4223 (SIZE_MAX): Define if the headers do not.
4224 (verror): Do not give up if vsnprintf returns a negative count.
4225 Instead, grow the buffer. This ports to Windows vsnprintf, which
4226 does not conform to C99. Problem reported by Eli Zaretskii.
4227 Also, simplify the allocation scheme, by avoiding the need for
4228 calling realloc, and removing the ALLOCATED variable.
4229
70476b54
PE
4230 * eval.c (verror): Initial buffer size is 4000 (not 200) bytes.
4231
12020a9e
PE
4232 Remove invocations of doprnt, as Emacs now uses vsnprintf.
4233 But keep the doprint source code for now, as we might revamp it
4234 and use it again (Bug#8435).
ea6c7ae6
PE
4235 * lisp.h (doprnt): Remove.
4236 * Makefile.in (base_obj): Remove doprnt.o.
4237 * deps.mk (doprnt.o): Remove.
4238
5fdb398c
PE
4239 error: Print 32- and 64-bit integers portably (Bug#8435).
4240 Without this change, on typical 64-bit hosts error ("...%d...", N)
4241 was used to print both 32- and 64-bit integers N, which relied on
4242 undefined behavior.
4243 * lisp.h, src/m/amdx86-64.h, src/m/ia64.h, src/m/ibms390x.h (pEd):
4244 New macro.
4245 * lisp.h (error, verror): Mark as printf-like functions.
4246 * eval.c (verror): Use vsnprintf, not doprnt, to do the real work.
4247 Report overflow in size calculations when allocating printf buffer.
4248 Do not truncate output string at its first null byte.
4249 * xdisp.c (vmessage): Use vsnprintf, not doprnt, to do the real work.
4250 Truncate the output at a character boundary, since vsnprintf does not
4251 do that.
4252 * charset.c (check_iso_charset_parameter): Convert internal
4253 character to string before calling 'error', since %c now has the
4254 printf meaning.
4255 * coding.c (Fdecode_sjis_char, Fdecode_big5_char): Avoid int
4256 overflow when computing char to be passed to 'error'. Do not
4257 pass Lisp_Object to 'error'; pass the integer instead.
4258 * nsfns.m (Fns_do_applescript): Use int, not long, since it's
4259 formatted with plain %d.
4260
b189fa66
PE
4261 * eval.c (internal_lisp_condition_case): Don't pass spurious arg.
4262
bff87ef0
PE
4263 * keyboard.c (access_keymap_keyremap): Print func name, not garbage.
4264
7e2cac20
PE
4265 * coding.c (Fdecode_sjis_char): Don't assume CODE fits in int.
4266
ce4d90b5
PE
4267 * xterm.c (x_catch_errors): Remove duplicate declaration.
4268
266c9547
PE
4269 * term.c (maybe_fatal): Mark its 3rd arg as a printf format, too.
4270
79c49ad2
PE
4271 * xdisp.c, lisp.h (message_nolog): Remove; unused.
4272
368f4090
JM
42732011-04-10 Jim Meyering <meyering@redhat.com>
4274
4275 use ssize_t and size_t for read- and write-like emacs_gnutls_* functions
4276 * gnutls.c (emacs_gnutls_read): Adjust signature to be more read-like:
4277 return ssize_t not "int", and use size_t as the buffer length.
4278 (emacs_gnutls_write): Likewise, and make the buffer pointer "const".
4279 * gnutls.h: Update declarations.
4280 * process.c (read_process_output): Use ssize_t, to match.
4281 (send_process): Likewise.
4282
a32d4040
CY
42832011-04-09 Chong Yidong <cyd@stupidchicken.com>
4284
4285 * image.c (Fimagemagick_types): Doc fix, and comment cleanup.
4286
8546720e 42872011-04-09 Chong Yidong <cyd@stupidchicken.com>
aac0c6e3 4288
04f2d78b
CB
4289 * ftfont.c (get_adstyle_property, ftfont_pattern_entity):
4290 Use unsigned char, to match FcChar8 type definition.
aac0c6e3 4291
8546720e
GM
4292 * xterm.c (handle_one_xevent):
4293 * xmenu.c (create_and_show_popup_menu):
4294 * xselect.c (x_decline_selection_request)
4295 (x_reply_selection_request): Avoid type-punned deref of X events.
aac0c6e3 4296
0a2f5c1a 42972011-04-09 Eli Zaretskii <eliz@gnu.org>
a53e2e89
EZ
4298
4299 Fix some uses of `int' instead of EMACS_INT.
4300 * search.c (string_match_1, fast_string_match)
4301 (fast_c_string_match_ignore_case, fast_string_match_ignore_case)
4302 (scan_buffer, find_next_newline_no_quit)
4303 (find_before_next_newline, search_command, Freplace_match)
4304 (Fmatch_data): Make some `int' variables be EMACS_INT.
4305
4306 * xdisp.c (display_count_lines): 3rd argument and return value now
4307 EMACS_INT. All callers changed.
4308 (pint2hrstr): Last argument is now EMACS_INT.
4309
4310 * coding.c (detect_coding_utf_8, detect_coding_emacs_mule)
4311 (detect_coding_iso_2022, detect_coding_sjis, detect_coding_big5)
4312 (detect_coding_ccl, detect_coding_charset, decode_coding_utf_8)
4313 (decode_coding_utf_16, decode_coding_emacs_mule)
4314 (decode_coding_iso_2022, decode_coding_sjis, decode_coding_big5)
4315 (decode_coding_ccl, decode_coding_charset)
4316 <consumed_chars, consumed_chars_base>: Declare EMACS_INT.
4317 (decode_coding_iso_2022, decode_coding_emacs_mule)
4318 (decode_coding_sjis, decode_coding_big5, decode_coding_charset)
4319 <char_offset, last_offset>: Declare EMACS_INT.
4320 (encode_coding_utf_8, encode_coding_utf_16)
4321 (encode_coding_emacs_mule, encode_invocation_designation)
4322 (encode_designation_at_bol, encode_coding_iso_2022)
4323 (encode_coding_sjis, encode_coding_big5, encode_coding_ccl)
4324 (encode_coding_raw_text, encode_coding_charset) <produced_chars>:
4325 Declare EMACS_INT.
4326 (ASSURE_DESTINATION): Declare more_bytes EMACS_INT.
4327 (encode_invocation_designation): Last argument P_NCHARS is now
4328 EMACS_INT.
4329 (decode_eol): Declare pos_byte, pos, and pos_end EMACS_INT.
4330 (produce_chars): from_nchars and to_nchars are now EMACS_INT.
4331
4332 * coding.h (struct coding_system) <head_ascii>: Declare EMACS_INT.
4333 All users changed.
4334
4335 * ccl.c (Fccl_execute_on_string): Declare some variables
4336 EMACS_INT.
4337
8546720e 43382011-04-08 Samuel Thibault <sthibault@debian.org> (tiny change)
0080dc6b
SS
4339
4340 * term.c (init_tty): Fix incorrect ifdef placement (Bug#8450).
4341
4e19a977
CS
43422011-03-19 Christoph Scholtes <cschol2112@googlemail.com>
4343
4344 * process.c (Fformat_network_address): Doc fix.
4345
87302331
R
43462011-04-08 T.V. Raman <tv.raman.tv@gmail.com> (tiny change)
4347
4348 * xml.c (parse_region): Avoid creating spurious whiespace nodes.
4349
cbb59342
CY
43502011-04-08 Chong Yidong <cyd@stupidchicken.com>
4351
4352 * keyboard.c (read_char): Call Lisp function help-form-show,
4353 instead of using internal_with_output_to_temp_buffer.
4354 (Qhelp_form_show): New var.
e0d38eeb 4355 (syms_of_keyboard): Use DEFSYM macro.
cbb59342
CY
4356
4357 * print.c (internal_with_output_to_temp_buffer): Function deleted.
4358
4359 * lisp.h (internal_with_output_to_temp_buffer): Remove prototype.
4360
e67a13ab
CY
43612011-04-06 Chong Yidong <cyd@stupidchicken.com>
4362
04f2d78b
CB
4363 * process.c (Flist_processes): Remove to Lisp.
4364 (list_processes_1): Delete.
e67a13ab 4365
973f782d
EZ
43662011-04-06 Eli Zaretskii <eliz@gnu.org>
4367
7c106b1e
EZ
4368 * msdos.c (careadlinkat, careadlinkatcwd): MS-DOS replacements.
4369
973f782d
EZ
4370 * w32.c (careadlinkat, careadlinkatcwd): New always-fail stubs.
4371
41cf7d1a 43722011-04-06 Paul Eggert <eggert@cs.ucla.edu>
27ccc379 4373
ca23cc88
PE
4374 Fix more problems found by GCC 4.6.0's static checks.
4375
f390e2d5
PE
4376 * xmenu.c (Fx_popup_dialog): Don't assume string is free of formats.
4377
42eea0d0
PE
4378 * menu.c (Fx_popup_menu): Don't assume error_name lacks printf formats.
4379
b69769da 4380 * lisp.h (message, message_nolog, fatal): Mark as printf-like.
1e973bc7 4381
f9541e84
PE
4382 * xdisp.c (vmessage): Mark as a printf-like function.
4383
13841b55
PE
4384 * term.c (vfatal, maybe_fatal): Mark as printf-like functions.
4385
c136c10f
PE
4386 * sound.c (sound_warning): Don't crash if arg contains a printf format.
4387
5e2d4a30
PE
4388 * image.c (tiff_error_handler, tiff_warning_handler): Mark as
4389 printf-like functions.
4390 (tiff_load): Add casts to remove these marks before passing them
4391 to system-supplied API.
4392
583f48b9
PE
4393 * eval.c (Fsignal): Remove excess argument to 'fatal'.
4394
b25d760e
PE
4395 * coding.c (EMIT_ONE_BYTE, EMIT_TWO_BYTES): Use unsigned, not int.
4396 This avoids several warnings with gcc -Wstrict-overflow.
d5efd1d1
PE
4397 (DECODE_COMPOSITION_RULE): If the rule is invalid, goto invalid_code
4398 directly, rather than having caller test rule sign. This avoids
4399 some unnecessary tests.
4400 * composite.h (COMPOSITION_ENCODE_RULE_VALID): New macro.
4401 (COMPOSITION_ENCODE_RULE): Arguments now must be valid. This
4402 affects only one use, in DECODE_COMPOSITION_RULE, which is changed.
b25d760e 4403
bc7b6697 4404 * xfont.c (xfont_text_extents): Remove var that was set but not used.
625a3eb1 4405 (xfont_open): Avoid unnecessary tests.
bc7b6697 4406
27ccc379
PE
4407 * composite.c (composition_gstring_put_cache): Use unsigned integer.
4408
dcd5c89a
PE
4409 * composite.h, composite.c (composition_gstring_put_cache):
4410 Use EMACS_INT, not int, for length.
4411
b13a45c6
PE
4412 * composite.h (COMPOSITION_DECODE_REFS): New macro,
4413 breaking out part of COMPOSITION_DECODE_RULE.
4414 (COMPOSITION_DECODE_RULE): Use it.
4415 * composite.c (get_composition_id): Remove unused local vars,
4416 by using the new macro.
4417
1e792e4d
PE
4418 * textprop.c (set_text_properties_1): Change while to do-while,
4419 since the condition is always true at first.
4420
dc6c6455 4421 * intervals.c (graft_intervals_into_buffer): Mark var as used.
aa86731f
PE
4422 (interval_deletion_adjustment): Return unsigned value.
4423 All uses changed.
dc6c6455 4424
aba7731a
PE
4425 * process.c (list_processes_1, create_pty, read_process_output):
4426 (exec_sentinel): Remove vars that were set but not used.
afd4052b 4427 (create_pty): Remove unnecessary "volatile"s.
bc57d757 4428 (Fnetwork_interface_info): Avoid possibility of int overflow.
82eaa333 4429 (read_process_output): Do adaptive read buffering even if carryover.
fe07cdfa 4430 (read_process_output): Simplify nbytes computation if buffered.
aba7731a 4431
fdfc4bf3
PE
4432 * bytecode.c (exec_byte_code): Rename local to avoid shadowing.
4433
fca8fe46 4434 * syntax.c (scan_words): Remove var that was set but not used.
12cbf13f 4435 (update_syntax_table): Use unsigned instead of int.
fca8fe46 4436
06a0259a 4437 * lread.c (lisp_file_lexically_bound_p): Use ints rather than endptrs.
3c346cc3 4438 (lisp_file_lexically_bound_p, read1): Use unsigned instead of int.
e6eb4e9e 4439 (safe_to_load_p): Make the end-of-loop test the inverse of the in-loop.
06a0259a 4440
e7b9e80f
PE
4441 * print.c (print_error_message): Avoid int overflow.
4442
56201685
PE
4443 * font.c (font_list_entities): Redo for clarity,
4444 so that reader need not know FONT_DPI_INDEX + 1 == FONT_SPACING_INDEX.
4445
78834453 4446 * font.c (font_find_for_lface, Ffont_get_glyphs): Remove unused vars.
790771b1 4447 (font_score): Avoid potential overflow in diff calculation.
78834453 4448
0bc0b309 4449 * fns.c (substring_both): Remove var that is set but not used.
8cd55cb4 4450 (sxhash): Redo loop for clarity and to avoid wraparound warning.
0bc0b309 4451
e610eaca
PE
4452 * eval.c (funcall_lambda): Rename local to avoid shadowing.
4453
b895abce
PE
4454 * alloc.c (mark_object_loop_halt, mark_object): Use size_t, not int.
4455 Otherwise, GCC 4.6.0 optimizes the loop check away since the check
4456 can always succeed if overflow has undefined behavior.
4457
1f1d9321 4458 * search.c (boyer_moore, wordify): Remove vars set but not used.
6f076cc7 4459 (wordify): Omit three unnecessary tests.
1f1d9321 4460
c59478bc
PE
4461 * indent.c (MULTIBYTE_BYTES_WIDTH): Don't compute wide_column.
4462 All callers changed. This avoids the need for an unused var.
4463
79b73827
PE
4464 * casefiddle.c (casify_region): Remove var that is set but not used.
4465
a4db5dfe
PE
4466 * dired.c (file_name_completion): Remove var that is set but not used.
4467
43aae36e
PE
4468 * fileio.c (Finsert_file_contents): Make EOF condition clearer.
4469
2a47c44d 4470 * fileio.c (Finsert_file_contents): Avoid signed integer overflow.
163c5f32 4471 (Finsert_file_contents): Remove unnecessary code checking fd.
2a47c44d 4472
a37c69bf
PE
4473 * minibuf.c (read_minibuf_noninteractive): Use size_t for sizes.
4474 Check for integer overflow on size calculations.
4475
328ab8e7
PE
4476 * buffer.c (Fprevious_overlay_change): Remove var that is set
4477 but not used.
4478
e5a2a5cb
PE
4479 * keyboard.c (menu_bar_items, read_char_minibuf_menu_prompt):
4480 Remove vars that are set but not used.
8d84a6eb 4481 (timer_check_2): Don't assume timer-list and idle-timer-list are lists.
6b043475 4482 (timer_check_2): Mark vars as initialized.
e5a2a5cb 4483
a60e5f68
PE
4484 * gtkutil.c (xg_get_file_with_chooser): Mark var as initialized.
4485
f661cb61 4486 * image.c (lookup_image): Remove var that is set but not used.
35fa624f 4487 (xbm_load): Use parse_p, for gcc -Werror=unused-but-set-variable.
f661cb61 4488
f0397f5a
PE
4489 * fontset.c (Finternal_char_font, Ffontset_info): Remove vars
4490 that are set but not used.
4491
8664db06 4492 * xfns.c (make_invisible_cursor): Don't return garbage
03733ee7 4493 if XCreateBitmapFromData fails (Bug#8410).
8664db06 4494
6abdaa4a
PE
4495 * xselect.c (x_get_local_selection, x_handle_property_notify):
4496 Remove vars that are set but not used.
4497
0ce7538d 4498 * xfns.c (x_create_tip_frame): Remove var that is set but not used.
6abdaa4a 4499 (make_invisible_cursor): Initialize a possibly-uninitialized variable.
0ce7538d 4500
9ae848fc
PE
4501 * xterm.c (x_scroll_bar_to_input_event) [!USE_GTK]:
4502 Remove var that is set but not used.
0b918413
PE
4503 (scroll_bar_windows_size): Now size_t, not int.
4504 (x_send_scroll_bar_event): Use size_t, not int, for sizes.
4505 Check for overflow.
9ae848fc 4506
a5a62657
PE
4507 * xfaces.c (realize_named_face): Remove vars that are set but not used.
4508 (map_tty_color) [!defined MSDOS]: Likewise.
4509
5c5cdd39
PE
4510 * term.c (tty_write_glyphs): Use size_t; this avoids overflow warning.
4511
66ebf983
PE
4512 * coding.c: Remove vars that are set but not used.
4513 (DECODE_COMPOSITION_RULE): Remove 2nd arg, which is unused.
4514 All callers changed.
4515 (decode_coding_utf_8, decode_coding_utf_16 decode_coding_emacs_mule):
4516 (decode_coding_iso_2022, encode_coding_sjis, encode_coding_big5):
4517 (decode_coding_charset): Remove vars that are set but not used.
4518
1be4d761
PE
4519 * bytecode.c (Fbyte_code) [!defined BYTE_CODE_SAFE]: Remove var
4520 that is set but not used.
4521
47553fa8
PE
4522 * print.c (print_object): Remove var that is set but not used.
4523
1f7196bf 4524 Replace 2 copies of readlink code with 1 gnulib version (Bug#8401).
d1fdcab7
PE
4525 The gnulib version avoids calling malloc in the usual case,
4526 and on 64-bit hosts doesn't have some arbitrary 32-bit limits.
4527 * fileio.c (Ffile_symlink_p): Use emacs_readlink.
4528 * filelock.c (current_lock_owner): Likewise.
4529 * lisp.h (READLINK_BUFSIZE, emacs_readlink): New function.
4530 * sysdep.c: Include allocator.h, careadlinkat.h.
4531 (emacs_no_realloc_allocator): New static constant.
4532 (emacs_readlink): New function.
fdb61804
PE
4533 * deps.mk (sysdep.o): Depend on ../lib/allocator.h and on
4534 ../lib/careadlinkat.h.
d1fdcab7 4535
f84c17c7
SM
45362011-04-04 Stefan Monnier <monnier@iro.umontreal.ca>
4537
4538 * keyboard.c (safe_run_hook_funcall): Fix last change (don't stop at the
4539 first non-nil return value).
4540
ef3862ad
JD
45412011-04-03 Jan Djärv <jan.h.d@swipnet.se>
4542
4543 * nsterm.m (ns_update_auto_hide_menu_bar): Define MAC_OS_X_VERSION_10_6
4544 if not defined (Bug#8403).
4545
376a7006
JB
45462011-04-02 Juanma Barranquero <lekktu@gmail.com>
4547
4548 * xdisp.c (display_count_lines): Remove parameter `start',
4549 unused since 1998-01-01T02:27:27Z!rms@gnu.org. All callers changed.
4550 (get_char_face_and_encoding): Remove parameter `multibyte_p',
4551 unused since 2008-05-14T01:40:23Z!handa@m17n.org. All callers changed.
4552 (fill_stretch_glyph_string): Remove parameters `row' and `area',
4553 unused at least since Kim's GUI unification at 2003-03-16T20:45:46Z!storm@cua.dk
4554 and thereabouts. All callers changed.
4555 (get_per_char_metric): Remove parameter `f', unused since
4556 2008-05-14T01:40:23Z!handa@m17n.org. All callers changed.
4557
6ca3801d
JM
45582011-04-02 Jim Meyering <meyering@redhat.com>
4559
4560 do not dereference NULL upon failed strdup
4561 * nsfont.m (ns_descriptor_to_entity): Use xstrdup, not strdup.
4562 (ns_get_family): Likewise.
4563
d8e2b5ba
JB
45642011-04-02 Juanma Barranquero <lekktu@gmail.com>
4565
4566 * eval.c (unwind_to_catch) [DEBUG_GCPRO]: Remove redundant assignment.
4567
8c74fcbd
JD
45682011-04-02 Jan Djärv <jan.h.d@swipnet.se>
4569
4570 * nsterm.m (ns_update_auto_hide_menu_bar): Only for OSX 10.6 or
4571 later (Bug#8403).
4572
7200d79c
SM
45732011-04-01 Stefan Monnier <monnier@iro.umontreal.ca>
4574
03408648 4575 Add lexical binding.
7200d79c 4576
03408648
SM
4577 * window.c (Ftemp_output_buffer_show): New fun.
4578 (Fsave_window_excursion):
4579 * print.c (Fwith_output_to_temp_buffer): Move to subr.el.
4580
4581 * lread.c (lisp_file_lexically_bound_p): New function.
4582 (Fload): Bind Qlexical_binding.
4583 (readevalloop): Remove `evalfun' arg.
4584 Bind Qinternal_interpreter_environment.
4585 (Feval_buffer): Bind Qlexical_binding.
4586 (defvar_int, defvar_bool, defvar_lisp_nopro, defvar_kboard):
4587 Mark as dynamic.
4588 (syms_of_lread): Declare `lexical-binding'.
4589
4590 * lisp.h (struct Lisp_Symbol): New field `declared_special'.
4591
4592 * keyboard.c (eval_dyn): New fun.
4593 (menu_item_eval_property): Use it.
ca105506
SM
4594
4595 * image.c (parse_image_spec): Use Ffunctionp.
ca105506 4596
03408648
SM
4597 * fns.c (concat, mapcar1): Accept byte-code-functions.
4598
4599 * eval.c (Fsetq): Handle lexical vars.
4600 (Fdefun, Fdefmacro, Ffunction): Make closures when needed.
4601 (Fdefconst, Fdefvaralias, Fdefvar): Mark as dynamic.
4602 (FletX, Flet): Obey lexical binding.
4603 (Fcommandp): Handle closures.
4604 (Feval): New `lexical' arg.
4605 (eval_sub): New function extracted from Feval. Use it almost
4606 everywhere where Feval was used. Look up vars in lexical env.
4607 Handle closures.
4608 (Ffunctionp): Move from subr.el.
4609 (Ffuncall): Handle closures.
4610 (apply_lambda): Remove `eval_flags'.
4611 (funcall_lambda): Handle closures and new byte-code-functions.
4612 (Fspecial_variable_p): New function.
4613 (syms_of_eval): Initialize the Vinternal_interpreter_environment var,
4614 but without exporting it to Lisp.
23aba0ea 4615
23aba0ea 4616 * doc.c (Fdocumentation, store_function_docstring):
03408648 4617 * data.c (Finteractive_form): Handle closures.
23aba0ea 4618
03408648
SM
4619 * callint.c (Fcall_interactively): Preserve lexical-binding mode for
4620 interactive spec.
ba83908c 4621
04f2d78b
CB
4622 * bytecode.c (Bstack_ref, Bstack_set, Bstack_set2, BdiscardN):
4623 New byte-codes.
03408648
SM
4624 (exec_byte_code): New function extracted from Fbyte_code to handle new
4625 calling convention for byte-code-functions. Add new byte-codes.
ba83908c 4626
03408648 4627 * buffer.c (defvar_per_buffer): Set new `declared_special' field.
e2abe5a1 4628
03408648 4629 * alloc.c (Fmake_symbol): Init new `declared_special' field.
e2abe5a1 4630
e2abce01
JB
46312011-03-31 Juanma Barranquero <lekktu@gmail.com>
4632
4633 * xdisp.c (redisplay_internal): Fix prototype.
4634
63696a73 46352011-03-31 Eli Zaretskii <eliz@gnu.org>
09725d26 4636
63696a73 4637 * xdisp.c (SCROLL_LIMIT): New macro.
04f2d78b
CB
4638 (try_scrolling): Use it when setting scroll_limit.
4639 Limit scrolling to 100 screen lines.
63696a73
EZ
4640 (redisplay_window): Even when falling back on "recentering",
4641 position point in the window according to scroll-conservatively,
4642 scroll-margin, and scroll-*-aggressively variables. (Bug#6671)
4643
4644 (try_scrolling): When point is above the window, allow searching
4645 as far as scroll_max, or one screenful, to compute vertical
4646 distance from PT to the scroll margin position. This prevents
4647 try_scrolling from unnecessarily failing when
4648 scroll-conservatively is set to a value slightly larger than the
4649 window height. Clean up the case of PT below the margin at bottom
4650 of window: scroll_max can no longer be INT_MAX. When aggressive
4651 scrolling is in use, don't let point enter the opposite scroll
4652 margin as result of the scroll.
4653 (syms_of_xdisp) <scroll-conservatively>: Document the
09725d26
EZ
4654 threshold of 100 lines for never-recentering scrolling.
4655
e4cc2dfc
JB
46562011-03-31 Juanma Barranquero <lekktu@gmail.com>
4657
4658 * dispextern.h (move_it_by_lines):
4659 * xdisp.c (move_it_by_lines): Remove parameter `need_y_p', unused
4660 since 2000-12-29T14:24:09Z!gerd@gnu.org. All callers changed.
4661 (message_log_check_duplicate): Remove parameters `prev_bol' and
4662 `this_bol', unused since 1998-01-01T02:27:27Z!rms@gnu.org. All callers changed.
4663 (redisplay_internal): Remove parameter `preserve_echo_area',
4664 unused since 1999-07-21T21:43:52Z!gerd@gnu.org. All callers changed.
4665
4666 * indent.c (Fvertical_motion):
4667 * window.c (window_scroll_pixel_based, Frecenter):
4668 Don't pass `need_y_p' to `move_it_by_lines'.
4669
1c470562
SM
46702011-03-30 Stefan Monnier <monnier@iro.umontreal.ca>
4671
44f230aa
SM
4672 * eval.c (struct backtrace): Don't cheat with negative numbers, but do
4673 steal a few bits to be more compact.
4674 (interactive_p, Fbacktrace, Fbacktrace_frame, mark_backtrace):
4675 Remove unneeded casts.
4676
1c470562
SM
4677 * bytecode.c (Fbyte_code): CAR and CDR can GC.
4678
888adce9
ZK
46792011-03-30 Zachary Kanfer <zkanfer@gmail.com> (tiny change)
4680
4681 * keyboard.c (Fexecute_extended_command): Do log the "suggest key
4682 binding" message (bug#7967).
4683
f838ed7b
PE
46842011-03-30 Paul Eggert <eggert@cs.ucla.edu>
4685
77861b95
PE
4686 Fix more problems found by GCC 4.6.0's static checks.
4687
de6dbc14
PE
4688 * unexelf.c (unexec) [! (defined _SYSTYPE_SYSV || defined __sgi)]:
4689 Remove unused local var.
4690
f838ed7b
PE
4691 * editfns.c (Fmessage_box): Remove unused local var.
4692
792c7b2b
PE
4693 * xdisp.c (try_window_reusing_current_matrix, x_produce_glyphs):
4694 (note_mode_line_or_margin_highlight, note_mouse_highlight):
4695 Omit unused local vars.
c499e557 4696 * window.c (shrink_windows): Omit unused local var.
b01a1c29 4697 * menu.c (digest_single_submenu): Omit unused local var.
0bc32927
PE
4698 * dispnew.c (update_window) [PERIODIC_PREEMPTION_CHECKING]:
4699 Omit unused local var.
4700
ba0165e1
PE
4701 * keyboard.c (parse_modifiers_uncached, parse_modifiers):
4702 Don't assume string length fits in int.
32ad8845 4703 (keyremap_step, read_key_sequence): Use size_t for sizes.
48011560 4704 (read_key_sequence): Don't check last_real_key_start redundantly.
ba0165e1 4705
3c59b4c9
PE
4706 * callproc.c (Fcall_process, Fcall_process_region): Use SAFE_ALLOCA
4707 instead of alloca (Bug#8344).
4708
a3eed478 4709 * eval.c (Fbacktrace): Don't assume nargs fits in int.
5d5d959d 4710 (Fbacktrace_frame): Don't assume nframes fits in int.
a3eed478 4711
eb4d412d
PE
4712 * syntax.c (scan_sexps_forward): Avoid pointer wraparound.
4713
1658b401
PE
4714 * xterm.c (x_make_frame_visible, same_x_server): Redo to avoid overflow
4715 concerns.
4716
4717 * term.c (produce_glyphless_glyph): Remove unnecessary test.
4718
4719 * cm.c (calccost): Turn while-do into do-while, for clarity.
44f730c8 4720
9a2c6e05
PE
4721 * keyboard.c (syms_of_keyboard): Use the same style as later
4722 in this function when indexing through an array. This also
4723 works around GCC bug 48267.
4724
03d0a109
PE
4725 * image.c (tiff_load): Fix off-by-one image count (Bug#8336).
4726
44f730c8
PE
4727 * xselect.c (x_check_property_data): Return correct size (Bug#8335).
4728
fe75f926
PE
4729 * chartab.c (sub_char_table_ref_and_range): Redo for slight
4730 efficiency gain, and to bypass a gcc -Wstrict-overflow warning.
4731
ffa8c828
PE
4732 * keyboard.c, keyboard.h (num_input_events): Now size_t.
4733 This avoids undefined behavior on integer overflow, and is a bit
4734 more convenient anyway since it is compared to a size_t variable.
4735
c5101a77
PE
4736 Variadic C functions now count arguments with size_t, not int.
4737 This avoids an unnecessary limitation on 64-bit machines, which
4738 caused (substring ...) to crash on large vectors (Bug#8344).
4739 * lisp.h (struct Lisp_Subr.function.aMANY): Now takes size_t, not int.
4740 (DEFUN_ARGS_MANY, internal_condition_case_n, safe_call): Likewise.
77861b95 4741 All variadic functions and their callers changed accordingly.
c5101a77
PE
4742 (struct gcpro.nvars): Now size_t, not int. All uses changed.
4743 * data.c (arith_driver, float_arith_driver): Likewise.
4744 * editfns.c (general_insert_function): Likewise.
4745 * eval.c (struct backtrace.nargs, interactive_p)
4746 (internal_condition_case_n, run_hook_with_args, apply_lambda)
4747 (funcall_lambda, mark_backtrace): Likewise.
4748 * fns.c (concat): Likewise.
4749 * frame.c (x_set_frame_parameters): Likewise.
4750 * fns.c (get_key_arg): Now accepts and returns size_t, and returns
4751 0 if not found, not -1. All callers changed.
4752
dd3f25f7
PE
4753 * alloc.c (garbage_collect): Don't assume stack size fits in int.
4754 (stack_copy_size): Now size_t, not int.
4755 (stack_copy, stack_copy_size): Define only if MAX_SAVE_STACK > 0.
4756
461c2ab9
JB
47572011-03-28 Juanma Barranquero <lekktu@gmail.com>
4758
4759 * coding.c (encode_designation_at_bol): Remove parameter `charbuf_end',
4760 unused since 2002-03-01T01:17:24Z!handa@m17n.org and 2008-02-01T16:01:31Z!miles@gnu.org.
4761 All callers changed.
4762
4763 * lisp.h (multibyte_char_to_unibyte):
4764 * character.c (multibyte_char_to_unibyte): Remove parameter `rev_tbl',
4765 unused since 2002-03-01T01:16:34Z!handa@m17n.org and 2008-02-01T16:01:31Z!miles@gnu.org.
4766 * character.h (CHAR_TO_BYTE8):
4767 * cmds.c (internal_self_insert):
4768 * editfns.c (general_insert_function):
4769 * keymap.c (push_key_description):
4770 * search.c (Freplace_match):
4771 * xdisp.c (message_dolog, set_message_1): All callers changed.
4772
f6d62986
SM
47732011-03-28 Stefan Monnier <monnier@iro.umontreal.ca>
4774
4775 * keyboard.c (safe_run_hook_funcall): New function.
4776 (safe_run_hooks_1, safe_run_hooks_error, safe_run_hooks): On error,
4777 don't set the hook to nil, but remove the offending function instead.
4778 (Qcommand_hook_internal): Remove, unused.
4779 (syms_of_keyboard): Don't initialize Qcommand_hook_internal nor define
4780 Vcommand_hook_internal.
4781
4782 * eval.c (enum run_hooks_condition): Remove.
4783 (funcall_nil, funcall_not): New functions.
4784 (run_hook_with_args): Call each function through a `funcall' argument.
4785 Remove `cond' argument, now redundant.
4786 (Frun_hooks, Frun_hook_with_args, Frun_hook_with_args_until_success)
4787 (Frun_hook_with_args_until_failure): Adjust accordingly.
4788 (run_hook_wrapped_funcall, Frun_hook_wrapped): New functions.
4789
1db5b1ad
JB
47902011-03-28 Juanma Barranquero <lekktu@gmail.com>
4791
4792 * dispextern.h (string_buffer_position): Remove declaration.
4793
4794 * print.c (strout): Remove parameter `multibyte', unused since
4795 1999-08-21T19:30:21Z!gerd@gnu.org. All callers changed.
4796
4797 * search.c (boyer_moore): Remove parameters `len', `pos' and `lim',
4798 never used since function introduction in 1998-02-08T21:33:56Z!rms@gnu.org.
4799 All callers changed.
4800
4801 * w32.c (_wsa_errlist): Use braces for struct initializers.
4802
4803 * xdisp.c (string_buffer_position_lim): Remove parameter `w',
4804 never used since function introduction in 2001-03-09T18:41:50Z!gerd@gnu.org.
4805 All callers changed.
4806 (string_buffer_position): Likewise. Also, make static (it's never
4807 used outside xdisp.c).
4808 (cursor_row_p): Remove parameter `w', unused since
4809 2000-10-17T16:08:57Z!gerd@gnu.org. All callers changed.
4810 (decode_mode_spec): Remove parameter `precision', introduced during
4811 Gerd Moellmann's rewrite at 1999-07-21T21:43:52Z!gerd@gnu.org, but never used.
4812 All callers changed.
4813
5ffb62aa
JD
48142011-03-27 Jan Djärv <jan.h.d@swipnet.se>
4815
4816 * nsterm.m (syms_of_nsterm): Use doc: for ns-auto-hide-menu-bar.
4817
461c2ab9 48182011-03-27 Anders Lindgren <andlind@gmail.com>
f0a1382a
JD
4819
4820 * nsterm.m (ns_menu_bar_is_hidden): New variable.
4821 (ns_constrain_all_frames, ns_menu_bar_should_be_hidden)
4822 (ns_update_auto_hide_menu_bar): New functions.
4823 (ns_update_begin): Call ns_update_auto_hide_menu_bar.
4824 (applicationDidBecomeActive): Call ns_update_auto_hide_menu_bar and
4825 ns_constrain_all_frames.
4826 (constrainFrameRect): Return at once if ns_menu_bar_should_be_hidden.
4827 (syms_of_nsterm): DEFVAR ns-auto-hide-menu-bar, init to Qnil.
4828
5c380ffb
JD
48292011-03-27 Jan Djärv <jan.h.d@swipnet.se>
4830
4831 * nsmenu.m (runDialogAt): Remove argument to timer_check.
4832
9af30bdf
GM
48332011-03-27 Glenn Morris <rgm@gnu.org>
4834
4835 * syssignal.h: Replace RETSIGTYPE with void.
4836 * atimer.c, data.c, dispnew.c, emacs.c, floatfns.c, keyboard.c:
4837 * keyboard.h, lisp.h, process.c, sysdep.c, xterm.c:
4838 Replace SIGTYPE with void everywhere.
4839 * s/usg5-4-common.h (SIGTYPE): Remove definition.
4840 * s/template.h (SIGTYPE): Remove commented out definition.
4841
e2abce01
JB
48422011-03-26 Eli Zaretskii <eliz@gnu.org>
4843
4844 * xdisp.c (redisplay_window): Don't check buffer's clip_changed
4845 flag as a prerequisite for invoking try_scrolling. (Bug#6671)
4846
f868cd8a
JB
48472011-03-26 Juanma Barranquero <lekktu@gmail.com>
4848
59eb0929
JB
4849 * w32.c (read_unc_volume): Use parameter `henum', instead of
4850 global variable `wget_enum_handle'.
4851
4852 * keymap.c (describe_vector): Remove parameters `indices' and
4853 `char_table_depth', unused since 2002-03-01T01:43:26Z!handa@m17n.org.
4854 (describe_map, Fdescribe_vector): Adjust calls to `describe_vector'.
4855
f868cd8a
JB
4856 * keyboard.h (timer_check, show_help_echo): Remove unused parameters.
4857
4858 * keyboard.c (timer_check): Remove parameter `do_it_now',
4859 unused since 1996-04-12T06:01:29Z!rms@gnu.org.
4860 (show_help_echo): Remove parameter `ok_to_overwrite_keystroke_echo',
4861 unused since 2008-04-19T19:30:53Z!monnier@iro.umontreal.ca.
4862
4863 * keyboard.c (read_char):
4864 * w32menu.c (w32_menu_display_help):
4865 * xmenu.c (show_help_event, menu_help_callback):
4866 Adjust calls to `show_help_echo'.
4867
4868 * gtkutil.c (xg_maybe_add_timer):
4869 * keyboard.c (readable_events):
4870 * process.c (wait_reading_process_output):
4871 * xmenu.c (x_menu_wait_for_event): Adjust calls to `timer_check'.
4872
4873 * insdel.c (adjust_markers_gap_motion):
4874 Remove; no-op since 1998-01-02T21:29:48Z!rms@gnu.org.
4875 (gap_left, gap_right): Don't call it.
4876
2ecf6fdb
CY
48772011-03-25 Chong Yidong <cyd@stupidchicken.com>
4878
4879 * xdisp.c (handle_fontified_prop): Discard changes to clip_changed
4880 incurred during fontification.
4881
6b1f9ba4
JB
48822011-03-25 Juanma Barranquero <lekktu@gmail.com>
4883
4884 * buffer.c (defvar_per_buffer): Remove unused parameter `doc'.
4885 (DEFVAR_PER_BUFFER): Don't pass it.
4886
4887 * dispnew.c (row_equal_p, add_row_entry): Remove unused parameter `w'.
4888 (scrolling_window): Don't pass it.
4889
0f4a96b5
JB
48902011-03-25 Juanma Barranquero <lekktu@gmail.com>
4891
4892 * dispextern.h (glyph_matric): Use #if GLYPH_DEBUG, not #ifdef.
4893
4894 * fileio.c (check_executable) [DOS_NT]: Remove unused variables `len'
4895 and `suffix'.
4896 (Fset_file_selinux_context) [HAVE_LIBSELINUX]: Move here declaration
4897 of variables specific to SELinux and computation of `encoded_absname'.
4898
4899 * image.c (XPutPixel): Remove unused variable `height'.
4900
4901 * keyboard.c (make_lispy_event): Remove unused variable `hpos'.
4902
4903 * unexw32.c (get_section_info): Remove unused variable `section'.
4904
4905 * w32.c (stat): Remove unused variables `drive_root' and `devtype'.
4906 (system_process_attributes): Remove unused variable `sess'.
4907 (sys_read): Remove unused variable `err'.
4908
4909 * w32fns.c (top): Wrap variables with #if GLYPH_DEBUG, not #ifdef.
4910 (w32_wnd_proc): Remove unused variable `isdead'.
4911 (unwind_create_frame): Use #if GLYPH_DEBUG, not #ifdef.
4912 (Fx_server_max_request_size): Remove unused variable `dpyinfo'.
4913 (x_create_tip_frame): Remove unused variable `tem'.
4914
4915 * w32inevt.c (w32_console_read_socket):
4916 Remove unused variable `no_events'.
4917
4918 * w32term.c (x_draw_composite_glyph_string_foreground):
4919 Remove unused variable `width'.
4920
1149507c
JB
49212011-03-24 Juanma Barranquero <lekktu@gmail.com>
4922
4923 * w32term.c (x_set_glyph_string_clipping):
4924 Don't pass uninitialized region to CombineRgn.
4925
9c88f339
JB
49262011-03-23 Juanma Barranquero <lekktu@gmail.com>
4927
4928 * w32fns.c (x_set_menu_bar_lines): Remove unused variable `olines'.
4929 (w32_wnd_proc): Pass NULL to Windows API, not uninitialized buffer.
4930 (Fx_close_connection): Remove unused variable `i'.
4931
4932 * w32font.c (w32font_draw): Return number of glyphs.
4933 (w32font_open_internal): Remove unused variable `i'.
4934 (w32font_driver): Add missing initializer.
4935
4936 * w32menu.c (utf8to16): Remove unused variable `utf16'.
4937 (fill_in_menu): Remove unused variable `items_added'.
4938
4939 * w32term.c (last_mouse_press_frame): Remove static global variable.
4940 (w32_clip_to_row): Remove unused variable `f'.
4941 (x_delete_terminal): Remove unused variable `i'.
4942
4943 * w32uniscribe.c (uniscribe_shape): Remove unused variable `nclusters'.
4944 (NOTHING): Remove unused static global variable.
4945 (uniscribe_check_otf): Remove unused variable `table'.
4946 (uniscribe_font_driver): Add missing initializers.
4947
dee091a3
JD
49482011-03-23 Julien Danjou <julien@danjou.info>
4949
4950 * term.c (Fsuspend_tty, Fresume_tty):
4951 * minibuf.c (read_minibuf, run_exit_minibuf_hook):
4952 * window.c (temp_output_buffer_show):
4953 * insdel.c (signal_before_change):
4954 * frame.c (Fhandle_switch_frame):
4955 * fileio.c (Fdo_auto_save):
4956 * emacs.c (Fkill_emacs):
4957 * editfns.c (save_excursion_restore):
4958 * cmds.c (internal_self_insert):
4959 * callint.c (Fcall_interactively):
4960 * buffer.c (Fkill_all_local_variables):
4961 * keyboard.c (Fcommand_execute, Fsuspend_emacs, safe_run_hooks_1):
4962 Use Frun_hooks.
0f4a96b5 4963 (command_loop_1): Use Frun_hooks. Call safe_run_hooks
dee091a3
JD
4964 unconditionnaly since it does the check itself.
4965
2c520ab5 49662011-03-23 Paul Eggert <eggert@cs.ucla.edu>
f0641eff 4967
c9c49752
PE
4968 Fix more problems found by GCC 4.5.2's static checks.
4969
8abc3f12
PE
4970 * coding.c (encode_coding_raw_text): Avoid unnecessary test
4971 the first time through the loop, since we know p0 < p1 then.
4972 This also avoids a gcc -Wstrict-overflow warning.
4973
a2d26660
PE
4974 * lisp.h (SAFE_ALLOCA, SAFE_ALLOCA_LISP): Avoid 'int' overflow
4975 leading to a memory leak, possible in functions like
4976 load_charset_map_from_file that can allocate an unbounded number
b12ef411 4977 of objects (Bug#8318).
a2d26660 4978
916c72e9
PE
4979 * xmenu.c (set_frame_menubar): Use EMACS_UINT, not int, for indexes
4980 that could (at least in theory) be that large.
4981
19ab8a18
PE
4982 * xdisp.c (message_log_check_duplicate): Return unsigned long, not int.
4983 This is less likely to overflow, and avoids undefined behavior if
4984 overflow does occur. All callers changed. Use strtoul to scan
4985 for the unsigned long integer.
b7cbbd6f
PE
4986 (pint2hrstr): Simplify and tune code slightly.
4987 This also avoids a (bogus) GCC warning with gcc -Wstrict-overflow.
19ab8a18 4988
f0641eff
PE
4989 * scroll.c (do_scrolling): Work around GCC bug 48228.
4990 See <http://gcc.gnu.org/bugzilla/show_bug.cgi?id=48228>.
4991
7f650bb9
PE
4992 * frame.c (Fmodify_frame_parameters): Simplify loop counter.
4993 This also avoids a warning with gcc -Wstrict-overflow.
39f5e519
PE
4994 (validate_x_resource_name): Simplify count usage.
4995 This also avoids a warning with gcc -Wstrict-overflow.
7f650bb9 4996
37dd57d1
PE
4997 * fileio.c (Fcopy_file): Report error if fchown or fchmod
4998 fail (Bug#8306).
81e56e61 4999
699979fc 5000 * emacs.c (Fdaemon_initialized): Do not ignore I/O errors (Bug#8303).
dc1ca6a8 5001
401bf9b4
PE
5002 * process.c (Fmake_network_process): Use socklen_t, not int,
5003 where POSIX says socklen_t is required in portable programs.
5004 This fixes a porting bug on hosts like 64-bit HP-UX, where
591b2973 5005 socklen_t is wider than int (Bug#8277).
401bf9b4
PE
5006 (Fmake_network_process, server_accept_connection):
5007 (wait_reading_process_output, read_process_output):
5008 Likewise.
5009
b93aacde
PE
5010 * process.c: Rename or move locals to avoid shadowing.
5011 (list_processes_1, Fmake_network_process):
5012 (read_process_output_error_handler, exec_sentinel_error_handler):
5013 Rename or move locals.
4dc343ee 5014 (Fmake_network_process): Define label "retry_connect" only if needed.
0da49335 5015 (Fnetwork_interface_info): Fix pointer signedness.
f990b4e5 5016 (process_send_signal): Add cast to avoid pointer signedness problem.
7b808126 5017 (FIRST_PROC_DESC, IF_NON_BLOCKING_CONNECT): Remove unused macros.
c939f91b 5018 (create_process): Use 'volatile' to avoid vfork clobbering (Bug#8298).
b93aacde 5019
af8a867c 5020 Make tparam.h and terminfo.c consistent.
44f230aa
SM
5021 * cm.c (tputs, tgoto, BC, UP): Remove extern decls.
5022 Include tparam.h instead, since it declares them.
af8a867c
PE
5023 * cm.h (PC): Remove extern decl; tparam.h now does this.
5024 * deps.mk (cm.o, terminfo.o): Depend on tparam.h.
5025 * terminfo.c: Include tparam.h, to check interfaces.
5026 (tparm): Make 1st arg a const pointer in decl. Put it at top level.
5027 (tparam): Adjust signature to match interface in tparam.h;
5028 this removes some undefined behavior. Check that outstring and len
5029 are zero, which they always are with Emacs.
5030 * tparam.h (PC, BC, UP): New extern decls.
5031
0248044d 5032 * xftfont.c (xftfont_shape): Now static, and defined only if needed.
001a7ab4 5033 (xftfont_open): Rename locals to avoid shadowing.
0248044d 5034
8ff096c1 5035 * ftfont.c (ftfont_resolve_generic_family): Fix pointer signedness.
a00924bb
PE
5036 (ftfont_otf_capability, ftfont_shape): Omit decls if not needed.
5037 (OTF_TAG_SYM): Omit macro if not needed.
e932860f 5038 (ftfont_list): Remove unused local.
49eaafba
PE
5039 (get_adstyle_property, ftfont_pattern_entity):
5040 (ftfont_lookup_cache, ftfont_open, ftfont_anchor_point):
5041 Rename locals to avoid shadowing.
8ff096c1 5042
e2be39f6
PE
5043 * xfont.c (xfont_list_family): Mark var as initialized.
5044
c9735e30
PE
5045 * xml.c (make_dom): Now static.
5046
8f5201ae
PE
5047 * composite.c (composition_compute_stop_pos): Rename local to
5048 avoid shadowing.
b246f932
PE
5049 (composition_reseat_it): Remove unused locals.
5050 (find_automatic_composition, composition_adjust_point): Likewise.
80e079b2 5051 (composition_update_it): Mark var as initialized.
11b61122
PE
5052 (find_automatic_composition): Mark vars as initialized,
5053 with a FIXME (Bug#8290).
8f5201ae 5054
760fbc2c
PE
5055 character.h: Rename locals to avoid shadowing.
5056 * character.h (PREV_CHAR_BOUNDARY, FETCH_STRING_CHAR_ADVANCE):
5057 (FETCH_STRING_CHAR_AS_MULTIBYTE_ADVANCE, FETCH_CHAR_ADVANCE):
5058 (FETCH_CHAR_ADVANCE_NO_CHECK, INC_POS, DEC_POS, BUF_INC_POS):
5059 (BUF_DEC_POS): Be more systematic about renaming local temporaries
5060 to avoid shadowing.
5061
ff08eb85
PE
5062 * textprop.c (property_change_between_p): Remove; unused.
5063
fc7bf025
PE
5064 * intervals.c (interval_start_pos): Now static.
5065
235d7abc
PE
5066 * intervals.h (CHECK_TOTAL_LENGTH): Avoid empty "else".
5067
44f230aa
SM
5068 * atimer.c (start_atimer, append_atimer_lists, set_alarm):
5069 Rename locals to avoid shadowing.
3e7d6594 5070
50060332
PE
5071 * sound.c (wav_play, au_play, Fplay_sound_internal):
5072 Fix pointer signedness.
d01f234b 5073 (alsa_choose_format): Remove unused local var.
c83b8872
PE
5074 (wav_play): Initialize a variable to 0, to prevent undefined
5075 behavior (Bug#8278).
50060332 5076
c4fc4e30
PE
5077 * region-cache.c (insert_cache_boundary): Redo var to avoid shadowing.
5078
918436ed
PE
5079 * region-cache.h (pp_cache): New decl, for gcc -Wmissing-prototypes.
5080
c939f91b
PE
5081 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork
5082 clobbering (Bug#8298).
b9c7f648
PE
5083 * sysdep.c (sys_subshell): Likewise.
5084 Previously, the sys_subshell 'volatile' was incorrectly IF_LINTted out.
7e9123a2 5085
6bd8c144
PE
5086 * lisp.h (child_setup): Now NO_RETURN unless DOS_NT.
5087 This should get cleaned up, so that child_setup has the
5088 same signature on all platforms.
5089
7710357c 5090 * callproc.c (call_process_cleanup): Now static.
cb1d0ef7 5091 (relocate_fd): Rename locals to avoid shadowing.
7710357c 5092
c59da222
CY
50932011-03-22 Chong Yidong <cyd@stupidchicken.com>
5094
5095 * xterm.c (x_clear_frame): Remove XClearWindow call. This appears
5096 not to be necessary, and produces flickering.
5097
66b87493
GM
50982011-03-20 Glenn Morris <rgm@gnu.org>
5099
5100 * config.in: Remove file.
5101
45b6f6d5
JB
51022011-03-20 Juanma Barranquero <lekktu@gmail.com>
5103
5104 * minibuf.c (Vcompleting_read_function): Don't declare, global variables
5105 are now in src/globals.h.
5106 (syms_of_minibuf): Remove spurious & from previous change.
5107
3ec03f7e
LL
51082011-03-20 Leo <sdl.web@gmail.com>
5109
5110 * minibuf.c (completing-read-function): New variable.
5111 (completing-read-default): Rename from completing-read.
5112 (completing-read): Call completing-read-function.
5113
b14e3e21
CY
51142011-03-19 Juanma Barranquero <lekktu@gmail.com>
5115
5116 * xfaces.c (Fx_load_color_file):
5117 Read color file from absolute filename (bug#8250).
5118
f2b726e6
JB
51192011-03-19 Juanma Barranquero <lekktu@gmail.com>
5120
5121 * makefile.w32-in: Update dependencies.
5122
09f6ff02
EZ
51232011-03-17 Eli Zaretskii <eliz@gnu.org>
5124
5125 * makefile.w32-in ($(BLD)/unexw32.$(O)): Depend on $(SRC)/unexec.h.
5126
29a6015a
PE
51272011-03-17 Paul Eggert <eggert@cs.ucla.edu>
5128
a3a6c54e
PE
5129 Fix more problems found by GCC 4.5.2's static checks.
5130
b766f867
PE
5131 * process.c (make_serial_process_unwind, send_process_trap):
5132 (sigchld_handler): Now static.
5133
be02381c
PE
5134 * process.c (allocate_pty): Let PTY_ITERATION declare iteration vars.
5135 That way, the code declares only the vars that it needs.
5136 * s/aix4-2.h (PTY_ITERATION): Declare iteration vars.
5137 * s/cygwin.h (PTY_ITERATION): Likewise.
5138 * s/darwin.h (PTY_ITERATION): Likewise.
5139 * s/gnu-linux.h (PTY_ITERATION): Likewise.
5140
57048744
PE
5141 * s/irix6-5.h (PTY_OPEN): Declare stb, to loosen coupling.
5142 * process.c (allocate_pty): Don't declare stb unless it's needed.
5143
7914961c 5144 * bytecode.c (MAYBE_GC): Rewrite so as not to use empty "else".
615f2d59
PE
5145 (CONSTANTLIM): Remove; unused.
5146 (METER_CODE, Bscan_buffer, Bread_char, Bset_mark):
5147 Define only if needed.
7914961c 5148
b3967b18
PE
5149 * unexelf.c (unexec): Name an expression,
5150 to avoid gcc -Wbad-function-cast warning.
9ae71512
PE
5151 Use a different way to cause a compilation error if anyone uses
5152 n rather than nn, a way that does not involve shadowing.
73366a00 5153 (ELF_BSS_SECTION_NAME, OLD_PROGRAM_H): Remove; unused.
b3967b18 5154
29a6015a
PE
5155 * deps.mk (unexalpha.o): Remove; unused.
5156
43cfc33e 5157 New file unexec.h, the (simple) interface for unexec (Bug#8267).
7feda0d2 5158 * unexec.h: New file.
ce701a33
PE
5159 * deps.mk (emacs.o, unexaix.o, unexcw.o, unexcoff.o, unexelf.o):
5160 (unexhp9k800.o, unexmacosx.o, unexsol.o, unexw32.o):
5161 Depend on unexec.h.
5162 * emacs.c [!defined CANNOT_DUMP]: Include unexec.h.
5163 * unexaix.c, unexcoff.c, unexcw.c, unexelf.c, unexhp9k800.c:
5164 * unexmacosx.c, unexsol.c, unexw32.c: Include unexec.h.
381259ef 5165 Change as necessary to match prototype in unexec.h.
ce701a33 5166
01f44d5a
PE
5167 * syntax.c (Fforward_comment, scan_lists): Rename locals to avoid
5168 shadowing.
4f63c6bb 5169 (back_comment, skip_chars): Mark vars as initialized.
01f44d5a 5170
a6670b0b
PE
5171 * character.h (FETCH_STRING_CHAR_ADVANCE_NO_CHECK, BUF_INC_POS):
5172 Rename locals to avoid shadowing.
5173
cef2010d 5174 * lread.c (read1): Rewrite so as not to use empty "else".
0902fe45 5175 (Fload, readevalloop, read1): Rename locals to avoid shadowing.
cef2010d 5176
d4d7173a
PE
5177 * print.c (Fredirect_debugging_output): Fix pointer signedess.
5178
f08b802a
PE
5179 * lisp.h (debug_output_compilation_hack): Add decl here, to avoid
5180 warning when compiling print.c.
5181
3ddb0639
PE
5182 * font.c (font_unparse_fcname): Abort in an "impossible" situation
5183 instead of using an uninitialized var.
5ad03b97 5184 (font_sort_entities): Mark var as initialized.
3ddb0639 5185
170a2692
PE
5186 * character.h (FETCH_CHAR_ADVANCE): Rename locals to avoid shadowing.
5187
e663c700
PE
5188 * font.c (font_unparse_xlfd): Don't mix pointers to variables with
5189 pointers to constants.
89bc529a 5190 (font_parse_fcname): Remove unused vars.
7b81e2d0 5191 (font_delete_unmatched): Now static.
ea838e10 5192 (font_get_spec): Remove; unused.
13a547c6
PE
5193 (font_style_to_value, font_prop_validate_style, font_unparse_fcname):
5194 (font_update_drivers, Ffont_get_glyphs, font_add_log):
5195 Rename or move locals to avoid shadowing.
e663c700 5196
2a80c887 5197 * fns.c (require_nesting_list, require_unwind): Now static.
612f56df 5198 (Ffillarray): Rename locals to avoid shadowing.
2a80c887 5199
1384fa33 5200 * floatfns.c (domain_error2): Define only if needed.
a885e2ed 5201 (Ffrexp, Fldexp): Rename locals to avoid shadowing.
1384fa33 5202
8b2c52e9
PE
5203 * alloc.c (mark_backtrace): Move decl from here ...
5204 * lisp.h: ... to here, so that it can be checked.
5205
475545b5 5206 * eval.c (call_debugger, do_debug_on_call, grow_specpdl): Now static.
d28a2170 5207 (Fdefvar): Rewrite so as not to use empty "else".
cfcbfb1a
PE
5208 (lisp_indirect_variable): Name an expression,
5209 to avoid gcc -Wbad-function-cast warning.
1faed8ae 5210 (Fdefvar): Rename locals to avoid shadowing.
475545b5 5211
b1349114 5212 * callint.c (quotify_arg, quotify_args): Now static.
a3e8cbda 5213 (Fcall_interactively): Rename locals to avoid shadowing.
b0e80955 5214 Use const pointer when appropriate.
b1349114 5215
a2928364
PE
5216 * lisp.h (get_system_name, get_operating_system_release):
5217 Move decls here, to check interfaces.
5218 * process.c (get_operating_system_release): Move decl to lisp.h.
5219 * xrdb.c (get_system_name): Likewise.
63c5d10b
PE
5220 * editfns.c (init_editfns, Fuser_login_name, Fuser_uid):
5221 (Fuser_real_uid, Fuser_full_name): Remove unnecessary casts,
5222 some of which prompt warnings from gcc -Wbad-function-cast.
545b49b4
PE
5223 (Fformat_time_string, Fencode_time, Finsert_char):
5224 (Ftranslate_region_internal, Fformat):
5225 Rename or remove local vars to avoid shadowing.
9710023e 5226 (Ftranslate_region_internal): Mark var as initialized.
63c5d10b 5227
a415e694
PE
5228 * doc.c (Fdocumentation, Fsnarf_documentation): Move locals to
5229 avoid shadowing.
5230
8ef4622d
PE
5231 * lisp.h (eassert): Check that the argument compiles, even if
5232 ENABLE_CHECKING is not defined.
5233
946f9a5b
PE
5234 * data.c (Findirect_variable): Name an expression, to avoid
5235 gcc -Wbad-function-cast warning.
112396d6 5236 (default_value, arithcompare, arith_driver, arith_error): Now static.
b9b84fa9 5237 (store_symval_forwarding): Rename local to avoid shadowing.
44f230aa
SM
5238 (Fmake_variable_buffer_local, Fmake_local_variable):
5239 Mark variables as initialized.
52746918 5240 (do_blv_forwarding, do_symval_forwarding): Remove; unused.
946f9a5b 5241
e5aab7e7 5242 * alloc.c (check_cons_list): Do not define unless GC_CHECK_CONS_LIST.
ae35e756
PE
5243 (Fmake_vector, Fvector, Fmake_byte_code, Fgarbage_collect):
5244 Rename locals to avoid shadowing.
dff45157
PE
5245 (mark_stack): Move local variables into the #ifdef region where
5246 they're used.
7bc26fdb
PE
5247 (BLOCK_INPUT_ALLOC, UNBLOCK_INPUT_ALLOC): Define only if
5248 ! defined SYSTEM_MALLOC && ! defined SYNC_INPUT, as they are not
5249 needed otherwise.
5250 (CHECK_ALLOCATED): Define only if GC_CHECK_MARKED_OBJECTS.
5251 (GC_STRING_CHARS): Remove; not used.
d40d4be1 5252 (Fmemory_limit): Cast sbrk's returned value to char *.
ae35e756 5253
e5aab7e7
PE
5254 * lisp.h (check_cons_list): Declare if GC_CHECK_CONS_LIST; this
5255 avoids undefined behavior in theory.
5256
4da60324
PE
5257 * regex.c (IF_LINT): Add defn, for benefit of ../lib-src.
5258
88043301
PE
5259 Use functions, not macros, for up- and down-casing (Bug#8254).
5260 * buffer.h (DOWNCASE_TABLE, UPCASE_TABLE, DOWNCASE, UPPERCASEP):
5261 (NOCASEP, LOWERCASEP, UPCASE, UPCASE1): Remove. All callers changed
5262 to use the following functions instead of these macros.
5263 (downcase): Adjust to lack of DOWNCASE_TABLE. Return int, not
5264 EMACS_INT, since callers assume the returned value fits in int.
5265 (upcase1): Likewise, for UPCASE_TABLE.
5266 (uppercasep, lowercasep, upcase): New static inline functions.
0da09c43 5267 * editfns.c (Fchar_equal): Remove no-longer-needed workaround for
db69b0cd 5268 the race-condition problem in the old DOWNCASE.
88043301 5269
19ed5445
PE
5270 * regex.c (CHARSET_LOOKUP_RANGE_TABLE_RAW, POP_FAILURE_REG_OR_COUNT):
5271 Rename locals to avoid shadowing.
5272 (regex_compile, re_match_2_internal): Move locals to avoid shadowing.
abbd1bcf
PE
5273 (regex_compile, re_search_2, re_match_2_internal):
5274 Remove unused local vars.
952db0d7
PE
5275 (FREE_VAR): Rewrite so as not to use empty "else",
5276 which gcc can warn about.
da053e48 5277 (regex_compile, re_match_2_internal): Mark locals as initialized.
b313f9d8
PE
5278 (RETALLOC_IF): Define only if needed.
5279 (WORDCHAR_P): Likewise. This one is never needed, but is used
5280 only in a comment talking about a compiler bug, so put inside
5281 the #if 0 of that comment.
5282 (CHARSET_LOOKUP_BITMAP, FAIL_STACK_FULL, RESET_FAIL_STACK):
5283 (PUSH_FAILURE_ELT, BUF_PUSH_3, STOP_ADDR_VSTRING):
5284 Remove; unused.
19ed5445 5285
1f3561e4 5286 * search.c (boyer_moore): Rename locals to avoid shadowing.
76ef09b7
PE
5287 * character.h (FETCH_STRING_CHAR_AS_MULTIBYTE_ADVANCE):
5288 (PREV_CHAR_BOUNDARY): Likewise.
1f3561e4 5289
ded6f8f7
PE
5290 * search.c (simple_search): Remove unused var.
5291
dbd37a95
PE
5292 * dired.c (compile_pattern): Move decl from here ...
5293 * lisp.h: ... to here, so that it can be checked.
5294 (struct re_registers): New forward decl.
5295
7e47afad
PE
5296 * character.h (INC_POS, DEC_POS): Rename locals to avoid shadowing.
5297
85f24f61
PE
5298 * indent.c (MULTIBYTE_BYTES_WIDTH): New args bytes, width.
5299 All uses changed.
5300 (MULTIBYTE_BYTES_WIDTH, scan_for_column, compute_motion):
5301 Rename locals to avoid shadowing.
5671df8f 5302 (Fvertical_motion): Mark locals as initialized.
85f24f61 5303
181aa2be 5304 * casefiddle.c (casify_object, casify_region): Now static.
e45a141a 5305 (casify_region): Mark local as initialized.
181aa2be 5306
930d429c
PE
5307 * cmds.c (internal_self_insert): Rename local to avoid shadowing.
5308
7082eac6
PE
5309 * lisp.h (GCPRO2_VAR, GCPRO3_VAR, GCPRO4_VAR, GCPRO5_VAR, GCPRO6_VAR):
5310 New macros, so that the caller can use some names other than
5311 gcpro1, gcpro2, etc.
5312 (GCPRO2, GCPRO3, GCPRO4, GCPRO5, GCPRO6): Reimplement in terms
5313 of the new macros.
5314 (GCPRO1_VAR, UNGCPRO_VAR): Change the meaning of the second
5315 argument, for consistency with GCPRO2_VAR, etc: it is now the
5316 prefix of the variable, not the variable itself. All uses
5317 changed.
38b2c076
PE
5318 * dired.c (directory_files_internal, file_name_completion):
5319 Rename locals to avoid shadowing.
5320
15206ed9
PE
5321 Fix a race condition diagnosed by gcc -Wsequence-point (Bug#8254).
5322 An expression of the form (DOWNCASE (x) == DOWNCASE (y)), found in
5323 dired.c's scmp function, had undefined behavior.
5324 * lisp.h (DOWNCASE_TABLE, UPCASE_TABLE, DOWNCASE, UPPERCASEP):
5325 (NOCASEP, LOWERCASEP, UPCASE, UPCASE1): Move from here ...
5326 * buffer.h: ... to here, because these macros use current_buffer,
5327 and the new implementation with inline functions needs to have
5328 current_buffer in scope now, rather than later when the macros
5329 are used.
5330 (downcase, upcase1): New static inline functions.
5331 (DOWNCASE, UPCASE1): Reimplement using these functions.
5332 This avoids undefined behavior in expressions like
5333 DOWNCASE (x) == DOWNCASE (y), which previously suffered
5334 from race conditions in accessing the global variables
5335 case_temp1 and case_temp2.
5336 * casetab.c (case_temp1, case_temp2): Remove; no longer needed.
5337 * lisp.h (case_temp1, case_temp2): Remove their decls.
5338 * character.h (ASCII_CHAR_P): Move from here ...
5339 * lisp.h: ... to here, so that the inline functions mentioned
5340 above can use them.
5341
4a6bea26
PE
5342 * dired.c (directory_files_internal_unwind): Now static.
5343
f14b7e14
PE
5344 * fileio.c (file_name_as_directory, directory_file_name):
5345 (barf_or_query_if_file_exists, auto_save_error, auto_save_1):
5346 Now static.
2893f146
PE
5347 (file_name_as_directory): Use const pointers when appropriate.
5348 (Fexpand_file_name): Likewise. In particular, newdir might
5349 point at constant storage, so make it a const pointer.
fd4ead52 5350 (Fmake_directory_internal, Fread_file_name): Remove unused vars.
b14aac08
PE
5351 (Ffile_selinux_context, Fset_file_selinux_context): Fix pointer
5352 signedness issues.
f839df0c
PE
5353 (Fset_file_times, Finsert_file_contents, auto_save_error):
5354 Rename locals to avoid shadowing.
f14b7e14 5355
5716756e 5356 * minibuf.c (choose_minibuf_frame_1): Now static.
62137a95
PE
5357 (Ftry_completion, Fall_completions): Rename or remove locals
5358 to avoid shadowing.
5716756e 5359
b4c3046a
PE
5360 * marker.c (bytepos_to_charpos): Remove; unused.
5361
b45db522
PE
5362 * lisp.h (verify_bytepos, count_markers): New decls,
5363 so that gcc does not warn that these functions aren't declared.
5364
85876d07
PE
5365 * insdel.c (check_markers, make_gap_larger, make_gap_smaller):
5366 (reset_var_on_error, Fcombine_after_change_execute_1): Now static.
f0cb4a60 5367 (CHECK_MARKERS): Redo to avoid gcc -Wempty-body diagnostic.
40ef059e 5368 (copy_text): Remove unused local var.
85876d07 5369
03d78a21 5370 * filelock.c (within_one_second): Now static.
b3dd38ab 5371 (lock_file_1): Rename local to avoid shadowing.
03d78a21 5372
5df8f01b
PE
5373 * buffer.c (fix_overlays_before): Mark locals as initialized.
5374 (fix_start_end_in_overlays): Likewise. This function should be
5375 simplified by using pointers-to-pointers, but that's a different
5376 matter.
b1d876f1 5377 (switch_to_buffer_1): Now static.
8f54f30a
PE
5378 (Fkill_buffer, record_buffer, Fbury_buffer, Fset_buffer_multibyte):
5379 (report_overlay_modification): Rename locals to avoid shadowing.
c3bd59b5 5380
a70072c9 5381 * sysdep.c (system_process_attributes): Rename vars to avoid shadowing.
fbd02d7b 5382 Fix pointer signedness issue.
edced198
PE
5383 (sys_subshell): Mark local as volatile if checking for lint,
5384 to suppress a gcc -Wclobbered warning that does not seem to be right.
15dfd3d9 5385 (MAXPATHLEN): Define only if needed.
a70072c9 5386
a0977c44
PE
5387 * process.c (serial_open, serial_configure): Move decls from here ...
5388 * systty.h: ... to here, so that they can be checked.
5389
a884fdcc
PE
5390 * fns.c (get_random, seed_random): Move extern decls from here ...
5391 * lisp.h: ... to here, so that they can be checked.
5392
604efe86 5393 * sysdep.c (reset_io): Now static.
b8950c94 5394 (wait_for_termination_signal): Remove; unused.
604efe86 5395
38fc62d9
PE
5396 * keymap.c (keymap_parent, keymap_memberp, map_keymap_internal):
5397 (copy_keymap_item, append_key, push_text_char_description):
5398 Now static.
1004a21a 5399 (Fwhere_is_internal): Don't test CONSP (sequences) unnecessarily.
dbbb8427 5400 (DENSE_TABLE_SIZE): Remove; unused.
c1141155
PE
5401 (get_keymap, access_keymap, Fdefine_key, Fwhere_is_internal):
5402 (describe_map_tree):
5403 Rename locals to avoid shadowing.
38fc62d9 5404
2f2650da
PE
5405 * keyboard.c: Declare functions static if they are not used elsewhere.
5406 (echo_char, echo_dash, cmd_error, top_level_2):
5407 (poll_for_input, handle_async_input): Now static.
69a058fa
PE
5408 (read_char, kbd_buffer_get_event, make_lispy_position):
5409 (make_lispy_event, make_lispy_movement, apply_modifiers):
5410 (decode_keyboard_code, tty_read_avail_input, menu_bar_items):
5411 (parse_tool_bar_item, read_key_sequence, Fread_key_sequence):
5412 (Fread_key_sequence_vector): Rename locals to avoid shadowing.
c8a06054 5413 (read_key_sequence, read_char): Mark locals as initialized.
3ac94672 5414 (Fexit_recursive_edit, Fabort_recursive_edit): Mark with NO_RETURN.
2f2650da 5415
a053e86c 5416 * keyboard.h (make_ctrl_char): New decl.
da2f2dd9
PE
5417 (mark_kboards): Move decl here ...
5418 * alloc.c (mark_kboards): ... from here.
a053e86c 5419
4752793e
PE
5420 * lisp.h (force_auto_save_soon): New decl.
5421
74f10ca7 5422 * emacs.c (init_cmdargs): Rename local to avoid shadowing.
244fc23d
PE
5423 (DEFINE_DUMMY_FUNCTION): New macro.
5424 (__do_global_ctors, __do_global_ctors_aux, __do_global_dtors, __main):
5425 Use it.
c03cd23f
PE
5426 (main): Add casts to avoid warnings
5427 if GCC considers string literals to be constants.
74f10ca7 5428
022e70d4
PE
5429 * lisp.h (fatal_error_signal): Add decl, since it's exported.
5430
59d6fe83
PE
5431 * dbusbind.c: Pointer signedness fixes.
5432 (xd_signature, xd_append_arg, xd_initialize):
5433 (Fdbus_call_method, Fdbus_call_method_asynchronously):
5434 (Fdbus_method_return_internal, Fdbus_method_error_internal):
5435 (Fdbus_send_signal, xd_read_message_1, Fdbus_register_service):
5436 (Fdbus_register_signal): Use SSDATA when the context wants char *.
5437
78320123
PE
5438 * dbusbind.c (Fdbus_init_bus): Add cast to avoid warning
5439 if GCC considers string literals to be constants.
49cebcca 5440 (Fdbus_register_service, Fdbus_register_method): Remove unused vars.
78320123 5441
35ac2a97
SM
54422011-03-16 Stefan Monnier <monnier@iro.umontreal.ca>
5443
fb103ca9
SM
5444 * print.c (PRINT_CIRCLE_CANDIDATE_P): New macro.
5445 (print_preprocess, print_object): New macro to fix last change.
5446
35ac2a97
SM
5447 * print.c (print_preprocess): Don't forget font objects.
5448
62973b41
JB
54492011-03-16 Juanma Barranquero <lekktu@gmail.com>
5450
5451 * emacs.c (USAGE3): Doc fixes.
5452
0e48bb22
AS
54532011-03-15 Andreas Schwab <schwab@linux-m68k.org>
5454
5455 * coding.c (detect_coding_iso_2022): Reorganize code to clarify
5456 structure.
5457
7684e57b
JB
54582011-03-14 Juanma Barranquero <lekktu@gmail.com>
5459
5460 * lisp.h (VWindow_system, Qfile_name_history):
5461 * keyboard.h (lispy_function_keys) [WINDOWSNT]:
5462 * w32term.h (w32_system_caret_hwnd, w32_system_caret_height)
5463 (w32_system_caret_x, w32_system_caret_y): Declare extern.
5464
5465 * w32select.c: Don't #include "keyboard.h".
c96bbc66 5466 (run_protected): Add extern declaration for waiting_for_input.
7684e57b
JB
5467
5468 * w32.c (Qlocal, noninteractive1, inhibit_window_system):
5469 * w32console.c (detect_input_pending, read_input_pending)
5470 (encode_terminal_code):
5471 * w32fns.c (quit_char, lispy_function_keys, Qtooltip)
5472 (w32_system_caret_hwnd, w32_system_caret_height, w32_system_caret_x)
5473 (w32_system_caret_y, Qfile_name_history):
5474 * w32font.c (w32font_driver, QCantialias, QCotf, QClang):
5475 * w32inevt.c (reinvoke_input_signal, lispy_function_keys):
5476 * w32menu.c (Qmenu_bar, QCtoggle, QCradio, Qoverriding_local_map)
5477 (Qoverriding_terminal_local_map, Qmenu_bar_update_hook):
5478 * w32proc.c (Qlocal, report_file_error):
5479 * w32term.c (Vwindow_system, updating_frame):
5480 * w32uniscribe.c (initialized, uniscribe_font_driver):
5481 Remove unneeded extern declarations.
5482
2aa46d6c
CY
54832011-03-14 Chong Yidong <cyd@stupidchicken.com>
5484
c96bbc66 5485 * buffer.c (Fmake_indirect_buffer): Fix incorrect assertions.
2aa46d6c 5486
cffc6f3b
CY
54872011-03-13 Chong Yidong <cyd@stupidchicken.com>
5488
5489 * buffer.h (BUF_BEGV, BUF_BEGV_BYTE, BUF_ZV, BUF_ZV_BYTE, BUF_PT)
5490 (BUF_PT_BYTE): Rewrite to handle indirect buffers (Bug#8219).
5491 These macros can no longer be used for assignment.
5492
44f230aa
SM
5493 * buffer.c (Fget_buffer_create, Fmake_indirect_buffer):
5494 Assign struct members directly, instead of using BUF_BEGV etc.
cffc6f3b
CY
5495 (record_buffer_markers, fetch_buffer_markers): New functions for
5496 recording and fetching special buffer markers.
5497 (set_buffer_internal_1, set_buffer_temp): Use them.
5498
5499 * lread.c (unreadchar): Use SET_BUF_PT_BOTH.
5500
5501 * insdel.c (adjust_point): Use SET_BUF_PT_BOTH.
5502
5503 * intervals.c (temp_set_point_both): Use SET_BUF_PT_BOTH.
5504 (get_local_map): Use SET_BUF_BEGV_BOTH and SET_BUF_ZV_BOTH.
5505
5506 * xdisp.c (hscroll_window_tree):
5507 (reconsider_clip_changes): Use PT instead of BUF_PT.
5508
d251f04b
EZ
55092011-03-13 Eli Zaretskii <eliz@gnu.org>
5510
5511 * makefile.w32-in ($(BLD)/editfns.$(O)): Depend on
5512 $(EMACS_ROOT)/lib/intprops.h.
5513
f0c77cd1
PE
55142011-03-13 Paul Eggert <eggert@cs.ucla.edu>
5515
3eca4629
PE
5516 Fix more problems found by GCC 4.5.2's static checks.
5517
7c86ee98
PE
5518 * gtkutil.c (xg_get_pixbuf_from_pixmap): Add cast from char *
5519 to unsigned char * to avoid compiler diagnostic.
b0afc268
PE
5520 (xg_free_frame_widgets): Make it clear that a local variable is
5521 needed only if USE_GTK_TOOLTIP.
01e0b5ad
PE
5522 (gdk_window_get_screen): Make it clear that this macro is needed
5523 only if USE_GTK_TOOLTIP.
1e5524e7
PE
5524 (int_gtk_range_get_value): New function, which avoids a diagnostic
5525 from gcc -Wbad-function-cast.
5526 (xg_set_toolkit_scroll_bar_thumb): Use it.
5527 (xg_tool_bar_callback, xg_tool_item_stale_p): Rewrite to avoid
5528 diagnostic from gcc -Wbad-function-cast.
65dc836c
PE
5529 (get_utf8_string, xg_get_file_with_chooser):
5530 Rename locals to avoid shadowing.
5531 (create_dialog): Move locals to avoid shadowing.
7c86ee98 5532
41729b81
PE
5533 * xgselect.c (xg_select): Remove unused var.
5534
f0c77cd1
PE
5535 * image.c (four_corners_best): Mark locals as initialized.
5536 (gif_load): Initialize transparent_p to zero (Bug#8238).
5537 Mark another local as initialized.
ec6cf4c6 5538 (my_png_error, my_error_exit): Mark with NO_RETURN.
f0c77cd1 5539
ce0ad53d 5540 * image.c (clear_image_cache): Now static.
d5d5a617 5541 (DIM, HAVE_STDLIB_H_1): Remove unused macros.
e22cffbc 5542 (xpm_load): Redo to avoid "discards qualifiers" gcc warning.
77a765fd
PE
5543 (x_edge_detection): Remove unnecessary cast that
5544 gcc -Wbad-function-cast diagnoses.
2037898d 5545 (gif_load): Fix pointer signedness.
6ae141d6
PE
5546 (clear_image_cache, xbm_read_bitmap_data, x_detect_edges):
5547 (jpeg_load, gif_load): Rename locals to avoid shadowing.
ce0ad53d 5548
33383987 55492011-03-12 Paul Eggert <eggert@cs.ucla.edu>
3eca4629 5550
d32df629
PE
5551 Improve quality of tests for time stamp overflow.
5552 For example, without this patch (encode-time 0 0 0 1 1
5553 1152921504606846976) returns the obviously-bogus value (-948597
5554 62170) on my RHEL 5.5 x86-64 host. With the patch, it correctly
5555 reports time overflow. See
5556 <http://lists.gnu.org/archive/html/emacs-devel/2011-03/msg00470.html>.
b8d9bd41
PE
5557 * deps.mk (editfns.o): Depend on ../lib/intprops.h.
5558 * editfns.c: Include limits.h and intprops.h.
5559 (TIME_T_MIN, TIME_T_MAX): New macros.
5560 (time_overflow): Move earlier, to before first use.
5561 (hi_time, lo_time): New functions, for an accurate test for
5562 out-of-range times.
5563 (Fcurrent_time, Fget_internal_run_time, make_time): Use them.
5564 (Fget_internal_run_time): Don't assume time_t fits in int.
5565 (make_time): Use list2 instead of Fcons twice.
5566 (Fdecode_time): More accurate test for out-of-range times.
5567 (check_tm_member): New function.
5568 (Fencode_time): Use it, to test for out-of-range times.
d32df629
PE
5569 (lisp_time_argument): Don't rely on undefined left-shift and
5570 right-shift behavior when checking for time stamp overflow.
8be6f318 5571
fe31d94c
PE
5572 * editfns.c (time_overflow): New function, refactoring common code.
5573 (Fformat_time_string, Fdecode_time, Fencode_time):
5574 (Fcurrent_time_string): Use it.
5575
8be6f318
PE
5576 Move 'make_time' to be next to its inverse 'lisp_time_argument'.
5577 * dired.c (make_time): Move to ...
5578 * editfns.c (make_time): ... here.
5579 * systime.h: Note the move.
5580
09d9db2c 55812011-03-12 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
c47cbdfd 5582
126bc0dc
YM
5583 * fringe.c (update_window_fringes): Remove unused variables.
5584
c47cbdfd
YM
5585 * unexmacosx.c (copy_data_segment): Also copy __got section.
5586 (Bug#8223)
5587
7ac80be9
EZ
55882011-03-12 Eli Zaretskii <eliz@gnu.org>
5589
c96bbc66 5590 * termcap.c [MSDOS]: Include "msdos.h".
058e5dad
EZ
5591 (find_capability, tgetnum, tgetflag, tgetstr, tputs, tgetent):
5592 Constify `char *' arguments and their references according to
5593 prototypes in tparam.h.
5594
ecb0f94d 5595 * deps.mk (termcap.o): Depend on tparam.h and msdos.h.
058e5dad 5596
7ac80be9
EZ
5597 * msdos.c (XMenuAddPane): 3rd argument is `const char *' now.
5598 Adapt all references accordingly.
5599
5600 * msdos.h (XMenuAddPane): 3rd argument is `const char *' now.
5601
ef1fd07e
TT
56022011-03-11 Tom Tromey <tromey@redhat.com>
5603
5604 * buffer.c (syms_of_buffer): Remove obsolete comment.
5605
7ef4b50c
EZ
56062011-03-11 Eli Zaretskii <eliz@gnu.org>
5607
5608 * termhooks.h (encode_terminal_code): Declare prototype.
5609
5610 * msdos.c (encode_terminal_code): Don't declare prototype.
5611
5612 * term.c (encode_terminal_code): Now external again, used by
5613 w32console.c and msdos.c.
5614
44f230aa
SM
5615 * makefile.w32-in ($(BLD)/term.$(O), ($(BLD)/tparam.$(O)):
5616 Depend on $(SRC)/tparam.h, see 2011-03-11T07:24:21Z!eggert@cs.ucla.edu.
7ef4b50c 5617
4b1ec863 56182011-03-11 Paul Eggert <eggert@cs.ucla.edu>
f78faa98 5619
1714f52b 5620 Fix some minor problems found by GCC 4.5.2's static checks.
83316bf4 5621
4b1ec863
PE
5622 * fringe.c (update_window_fringes): Mark locals as initialized
5623 (Bug#8227).
5624 (destroy_fringe_bitmap, init_fringe_bitmap): Now static.
bf60f616 5625
524c7aa6
PE
5626 * alloc.c (mark_fringe_data): Move decl from here ...
5627 * lisp.h (mark_fringe_data) [HAVE_WINDOW_SYSTEM]: ... to here,
5628 to check its interface.
5629 (init_fringe_once): Do not declare unless HAVE_WINDOW_SYSTEM.
5630
a5c0af81 5631 * fontset.c (free_realized_fontset): Now static.
7519b8cd 5632 (Fset_fontset_font): Rename local to avoid shadowing.
cc6e5db1 5633 (fontset_font): Mark local as initialized.
a9a06e0b 5634 (FONTSET_SPEC, FONTSET_REPERTORY, RFONT_DEF_REPERTORY): Remove; unused.
a5c0af81 5635
b4716021
PE
5636 * xrdb.c: Include "xterm.h", to check x_load_resources's interface.
5637
811e9bac 5638 * xselect.c (x_disown_buffer_selections): Remove; not used.
7b83e2f1 5639 (TRACE3) [!defined TRACE_SELECTION]: Remove; not used.
aa0daa9f
PE
5640 (x_own_selection, Fx_disown_selection_internal): Rename locals
5641 to avoid shadowing.
5642 (x_handle_dnd_message): Remove local to avoid shadowing.
811e9bac 5643
7e3ab302
PE
5644 * lisp.h (GCPRO1_VAR, UNGCPRO_VAR): New macros,
5645 so that the caller can use some name other than gcpro1.
5646 (GCPRO1, UNGCPRO): Reimplement in terms of the new macros.
58d2d479
PE
5647 * xfns.c (Fx_create_frame, x_create_tip_frame, Fx_show_tip):
5648 (Fx_backspace_delete_keys_p):
5649 Use them to avoid shadowing, and rename vars to avoid shadowing.
5650 (x_decode_color, x_set_name, x_window): Now static.
6b437900 5651 (Fx_create_frame): Add braces to silence GCC warning.
c0951e53 5652 (Fx_file_dialog, Fx_select_font): Fix pointer signedness.
06b0c8a0
PE
5653 (x_real_positions, xg_set_icon_from_xpm_data, x_create_tip_frame):
5654 Remove unused locals.
7e3ab302
PE
5655 (Fx_create_frame, x_create_tip_frame, Fx_show_tip):
5656 (Fx_backspace_delete_keys_p): Rename locals to avoid shadowing.
5657 Some of these renamings use the new GCPRO1_VAR and UNGCPRO_VAR
5658 macros.
f78faa98 5659
e2b13473
PE
5660 * xterm.h (x_mouse_leave): New decl.
5661
77f23912
PE
5662 * xterm.c (x_copy_dpy_color, x_focus_on_frame, x_unfocus_frame):
5663 Remove unused functions.
cdf4ba58
PE
5664 (x_shift_glyphs_for_insert, XTflash, XTring_bell):
5665 (x_calc_absolute_position): Now static.
7411c686 5666 (XTread_socket): Don't define label "out" unless it's used.
2b07bcff 5667 Don't declare local "event" unless it's used.
ed7bf3a5
PE
5668 (x_iconify_frame, x_free_frame_resources): Don't declare locals
5669 unless they are used.
38d0b34a
PE
5670 (XEMBED_VERSION, xembed_set_info): Don't define unless needed.
5671 (x_fatal_error_signal): Remove; not used.
a6067996
PE
5672 (x_draw_image_foreground, redo_mouse_highlight, XTmouse_position):
5673 (x_scroll_bar_report_motion, handle_one_xevent, x_draw_bar_cursor):
5674 (x_error_catcher, x_connection_closed, x_error_handler):
5675 (x_error_quitter, xembed_send_message, x_iconify_frame):
5676 (my_log_handler): Rename locals to avoid shadowing.
28f1c698 5677 (x_delete_glyphs, x_ins_del_lines): Mark with NO_RETURN.
2a8fade0 5678 (x_connection_closed): Tell GCC not to suggest NO_RETURN.
77f23912 5679
44f230aa
SM
5680 * xfaces.c (clear_face_cache, Fx_list_fonts, Fface_font):
5681 Rename or move locals to avoid shadowing.
6b463e58 5682 (tty_defined_color, merge_face_heights): Now static.
5967d051 5683 (free_realized_faces_for_fontset): Remove; not used.
1e9966ea
PE
5684 (Fx_list_fonts): Mark variable that gcc -Wuninitialized
5685 does not deduce is never used uninitialized.
73719eba
PE
5686 (STRDUPA, LSTRDUPA, FONT_POINT_SIZE_QUANTUM): Remove; not used.
5687 (LFACEP): Define only if XASSERTS, as it's not needed otherwise.
071048a3 5688
426994c3 5689 * terminal.c (store_terminal_param): Now static.
5489860b 5690
032f1620 5691 * xmenu.c (menu_highlight_callback): Now static.
9d66f88e 5692 (set_frame_menubar): Remove unused local.
d4323972 5693 (xmenu_show): Rename parameter to avoid shadowing.
6d1f7fee
PE
5694 (xmenu_show, xdialog_show, xmenu_show): Make local pointers "const"
5695 since they might point to immutable storage.
281585b0
PE
5696 (next_menubar_widget_id): Declare only if USE_X_TOOLKIT,
5697 since it's unused otherwise.
032f1620 5698
367c19e5 5699 * xdisp.c (produce_glyphless_glyph): Initialize lower_xoff.
53df7c11 5700 Add a FIXME, since the code still doesn't look right. (Bug#8215)
9f36b9fd
PE
5701 (Fcurrent_bidi_paragraph_direction): Simplify slightly; this
5702 avoids a gcc -Wuninitialized diagnostic.
0e086e8f 5703 (display_line, BUILD_COMPOSITE_GLYPH_STRING, draw_glyphs):
44a3a108
PE
5704 (note_mouse_highlight): Mark variables that gcc -Wuninitialized
5705 does not deduce are never used uninitialized.
70739cbe 5706
07b48fa9
PE
5707 * lisp.h (IF_LINT): New macro, copied from ../lib-src/emacsclient.c.
5708
8868a238 5709 * xdisp.c (redisplay_window): Rename local to avoid shadowing.
4554d213
PE
5710 * window.c (window_loop, size_window):
5711 (run_window_configuration_change_hook, enlarge_window): Likewise.
8868a238 5712
7e5cf297 5713 * window.c (display_buffer): Now static.
d6550a9f
PE
5714 (size_window): Mark variables that gcc -Wuninitialized
5715 does not deduce are never used uninitialized.
a586633d
PE
5716 * window.h (check_all_windows): New decl, to forestall
5717 gcc -Wmissing-prototypes diagnostic.
5b555da1 5718 * dispextern.h (bidi_dump_cached_states): Likewise.
7e5cf297 5719
f6095868
PE
5720 * charset.h (CHECK_CHARSET_GET_CHARSET): Rename locals to avoid
5721 shadowing.
5722 * charset.c (map_charset_for_dump, Fchar_charset): Likewise.
726929c4
PE
5723 Include <limits.h>.
5724 (Fsort_charsets): Redo min/max calculation to shorten the code a bit
5725 and to avoid gcc -Wuninitialized warning.
89ef49df
PE
5726 (load_charset_map): Mark variables that gcc -Wuninitialized
5727 does not deduce are never used uninitialized.
53df7c11 5728 (load_charset): Abort instead of using uninitialized var (Bug#8229).
f6095868 5729
f38b440c
PE
5730 * coding.c (coding_set_source, coding_set_destination):
5731 Use "else { /* comment */ }" rather than "else /* comment */;"
5732 for clarity, and to avoid gcc -Wempty-body warning.
2735d060
PE
5733 (Fdefine_coding_system_internal): Don't redeclare 'i' inside
5734 a block, when the outer 'i' will do.
5735 (decode_coding_utf_8, decode_coding_utf_16, detect_coding_emacs_mule):
5736 (emacs_mule_char, decode_coding_emacs_mule, detect_coding_iso_2022):
5737 (decode_coding_iso_2022, decode_coding_sjis, decode_coding_big5):
5738 (decode_coding_raw_text, decode_coding_charset, get_translation_table):
5739 (Fdecode_sjis_char, Fdefine_coding_system_internal):
5740 Rename locals to avoid shadowing.
5741 * character.h (FETCH_STRING_CHAR_ADVANCE): Likewise.
e2f1bab9
PE
5742 * coding.c (emacs_mule_char, encode_invocation_designation):
5743 Now static, since they're not used elsewhere.
413bb2db 5744 (decode_coding_iso_2022): Add "default: abort ();" as a safety check.
c4a63b12 5745 (decode_coding_object, encode_coding_object, detect_coding_system):
ee05f961
PE
5746 (decode_coding_emacs_mule): Mark variables that gcc
5747 -Wuninitialized does not deduce are never used uninitialized.
160b01f6
PE
5748 (detect_coding_iso_2022): Initialize a local variable that might
5749 be used uninitialized. Leave a FIXME because it's not clear that
53df7c11 5750 this initialization is needed. (Bug#8211)
5f58e762
PE
5751 (ISO_CODE_LF, ISO_CODE_CR, CODING_ISO_FLAG_EUC_TW_SHIFT):
5752 (ONE_MORE_BYTE_NO_CHECK, UTF_BOM, UTF_16_INVALID_P):
5753 (SHIFT_OUT_OK, ENCODE_CONTROL_SEQUENCE_INTRODUCER):
5754 (ENCODE_DIRECTION_R2L, ENCODE_DIRECTION_L2R):
5755 Remove unused macros.
f38b440c 5756
232b38b9 5757 * category.c (hash_get_category_set): Remove unused local var.
9f3b5e69 5758 (copy_category_table): Now static, since it's not used elsewhere.
d0891610 5759 * character.c (string_count_byte8): Likewise.
232b38b9 5760
fb90da1b
PE
5761 * ccl.c (CCL_WRITE_STRING, CCL_ENCODE_CHAR, Fccl_execute_on_string):
5762 (Fregister_code_conversion_map): Rename locals to avoid shadowing.
5763
fb93dbc2
PE
5764 * chartab.c (copy_sub_char_table): Now static, since it's not used
5765 elsewhere.
5c156ace
PE
5766 (sub_char_table_ref_and_range, char_table_ref_and_range):
5767 Rename locals to avoid shadowing.
bbcd0949 5768 (ASET_RANGE, GET_SUB_CHAR_TABLE): Remove unused macros.
fb93dbc2 5769
7d3b3862 5770 * bidi.c (bidi_check_type): Now static, since it's not used elsewhere.
630d6892 5771 (BIDI_BOB): Remove unused macro.
7d3b3862 5772
6be7d3da
PE
5773 * cm.c (cmgoto): Mark variables that gcc -Wuninitialized does not
5774 deduce are never used uninitialized.
c2ed9c8b 5775 * term.c (encode_terminal_code): Likewise.
6be7d3da 5776
75f8807f 5777 * term.c (encode_terminal_code): Now static. Remove unused local.
72abad34 5778
50938595
PE
5779 * tparam.h: New file.
5780 * term.c, tparam.h: Include it.
5781 * deps.mk (term.o, tparam.o): Depend on tparam.h.
5782 * term.c (tputs, tgetent, tgetflag, tgetnum, tparam, tgetstr):
5783 Move these decls to tparam.h, and make them agree with what
5784 is actually in tparam.c. The previous trick of using incompatible
5785 decls in different modules does not conform to the C standard.
5786 All callers of tparam changed to use tparam's actual API.
5787 * tparam.c (tparam1, tparam, tgoto):
5788 Use const pointers where appropriate.
5789
fbceeba2
PE
5790 * cm.c (calccost, cmgoto): Use const pointers where appropriate.
5791 * cm.h (struct cm): Likewise.
5792 * dispextern.h (do_line_insertion_deletion_costs): Likewise.
5793 * scroll.c (ins_del_costs, do_line_insertion_deletion_costs): Likewise.
5794 * term.c (tty_ins_del_lines, calculate_costs, struct fkey_table):
5795 (term_get_fkeys_1, append_glyphless_glyph, produce_glyphless_glyph):
5796 (turn_on_face, init_tty): Likewise.
5797 * termchar.h (struct tty_display_info): Likewise.
fbceeba2 5798
7f3f1250
PE
5799 * term.c (term_mouse_position): Rename local to avoid shadowing.
5800
e6ca6543
PE
5801 * alloc.c (mark_ttys): Move decl from here ...
5802 * lisp.h (mark_ttys): ... to here, so that it's checked against defn.
5803
c40f8d15
AS
58042011-03-11 Andreas Schwab <schwab@linux-m68k.org>
5805
5806 * .gdbinit (pwinx, xbuffer): Fix access to buffer name.
5807
cfe0661d
JB
58082011-03-09 Juanma Barranquero <lekktu@gmail.com>
5809
5810 * search.c (compile_pattern_1): Remove argument regp, unused since
5811 revid:rms@gnu.org-19941211082627-3x1g1wyqkjmwloig.
5812 (compile_pattern): Don't pass it.
5813
0afb4571
J
58142011-03-08 Jan Djärv <jan.h.d@swipnet.se>
5815
5816 * xterm.h (DEFAULT_GDK_DISPLAY): New define.
5817 (GDK_WINDOW_XID, gtk_widget_get_preferred_size): New defines
5818 for ! HAVE_GTK3.
5819 (GTK_WIDGET_TO_X_WIN): Use GDK_WINDOW_XID.
5820
5821 * xmenu.c (menu_position_func): Call gtk_widget_get_preferred_size.
5822
5823 * gtkutil.c: Include gtkx.h if HAVE_GTK3. If ! HAVE_GTK3, define
5824 gdk_window_get_screen, gdk_window_get_geometry,
5825 gdk_x11_window_lookup_for_display and GDK_KEY_g.
5826 (xg_set_screen): Use DEFAULT_GDK_DISPLAY.
5827 (xg_get_pixbuf_from_pixmap): New function.
5828 (xg_get_pixbuf_from_pix_and_mask): Change parameters from GdkPixmap
5829 to Pixmap, take frame as parameter, remove GdkColormap parameter.
5830 Call xg_get_pixbuf_from_pixmap instead of
5831 gdk_pixbuf_get_from_drawable.
5832 (xg_get_image_for_pixmap): Do not make GdkPixmaps, call
5833 xg_get_pixbuf_from_pix_and_mask with Pixmap parameters instead.
5834 (xg_check_special_colors): Use GtkStyleContext and its functions
5835 for HAVE_GTK3.
5836 (xg_prepare_tooltip, xg_hide_tooltip): Call gdk_window_get_screen.
5837 (xg_prepare_tooltip, create_dialog, menubar_map_cb)
5838 (xg_update_frame_menubar, xg_tool_bar_detach_callback)
44f230aa
SM
5839 (xg_tool_bar_attach_callback, xg_update_tool_bar_sizes):
5840 Call gtk_widget_get_preferred_size.
0afb4571
J
5841 (xg_frame_resized): gdk_window_get_geometry only takes 5
5842 parameters.
44f230aa
SM
5843 (xg_win_to_widget, xg_event_is_for_menubar):
5844 Call gdk_x11_window_lookup_for_display.
0afb4571
J
5845 (xg_set_widget_bg): New function.
5846 (delete_cb): New function.
895009e1 5847 (xg_create_frame_widgets): Connect delete-event to delete_cb.
0afb4571
J
5848 Call xg_set_widget_bg. Only set backgrund pixmap for ! HAVE_GTK3
5849 (xg_set_background_color): Call xg_set_widget_bg.
5850 (xg_set_frame_icon): Call xg_get_pixbuf_from_pix_and_mask.
5851 (xg_create_scroll_bar): vadj is a GtkAdjustment for HAVE_GTK3.
5852 Only call gtk_range_set_update_policy if ! HAVE_GTK3.
5853 (xg_make_tool_item): Only connect xg_tool_bar_item_expose_callback
5854 if ! HAVE_GTK3.
5855 (update_frame_tool_bar): Call gtk_widget_hide.
5856 (xg_initialize): Use GDK_KEY_g.
5857
5858 * xsmfns.c (gdk_set_sm_client_id): Define to gdk_set_sm_client_id
5859 if ! HAVE_GTK3
5860 (x_session_initialize): Call gdk_x11_set_sm_client_id.
5861
5862 * xterm.c (XFillRectangle): Use cairo routines for HAVE_GTK3.
5863 (x_term_init): Disable Xinput(2) with GDK_CORE_DEVICE_EVENTS.
5864 Load ~/emacs.d/gtkrc only for ! HAVE_GTK3.
5865
1c2cc4ef
JB
58662011-03-08 Juanma Barranquero <lekktu@gmail.com>
5867
5868 * w32xfns.c (select_palette): Check success of RealizePalette against
5869 GDI_ERROR, not zero.
5870
33383987 5871See ChangeLog.11 for earlier changes.
aac0c6e3
MR
5872
5873;; Local Variables:
5874;; coding: utf-8
aac0c6e3
MR
5875;; End:
5876
33383987 5877 Copyright (C) 2011 Free Software Foundation, Inc.
aac0c6e3
MR
5878
5879 This file is part of GNU Emacs.
5880
5881 GNU Emacs is free software: you can redistribute it and/or modify
5882 it under the terms of the GNU General Public License as published by
5883 the Free Software Foundation, either version 3 of the License, or
5884 (at your option) any later version.
5885
5886 GNU Emacs is distributed in the hope that it will be useful,
5887 but WITHOUT ANY WARRANTY; without even the implied warranty of
5888 MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
5889 GNU General Public License for more details.
5890
5891 You should have received a copy of the GNU General Public License
5892 along with GNU Emacs. If not, see <http://www.gnu.org/licenses/>.