* doc/lispref/internals.texi (Building Emacs): Typo fix, I think.
[bpt/emacs.git] / src / ChangeLog
CommitLineData
de0100f2
EZ
12012-03-02 Eli Zaretskii <eliz@gnu.org>
2
3 * xdisp.c (try_window_reusing_current_matrix): Don't move cursor
4 position past the first glyph_row that ends at ZV. (Bug#10902)
b8456c5c
EZ
5 (redisplay_window, next_element_from_string): Fix typos in
6 comments.
3e441275
EZ
7 (redisplay_window): Pass to move_it_vertically the margin in
8 pixels, not in screen lines.
de0100f2 9
96a72ee9
GM
102012-03-02 Glenn Morris <rgm@gnu.org>
11
12 * buffer.c (buffer-list-update-hook): Doc fix.
13
312508d7
EZ
142012-02-29 Eli Zaretskii <eliz@gnu.org>
15
16 * xdisp.c (get_overlay_strings_1): Under bidi redisplay, call
17 push_it before setting up the iterator for the first overlay
18 string, even if we have an empty string loaded.
19 (next_overlay_string): If there's an empty string on the iterator
20 stack, pop the stack. (Bug#10903)
21
27f3c637
PE
222012-02-25 Paul Eggert <eggert@cs.ucla.edu>
23
24 Generalize fix for crash due to non-contiguous EMACS_INT (Bug#10780).
25 Suggested by Stefan Monnier in
26 <http://lists.gnu.org/archive/html/emacs-devel/2012-02/msg00692.html>.
27 * alloc.c (widen_to_Lisp_Object): New static function.
28 (mark_memory): Also mark Lisp_Objects by fetching pointer words
29 and widening them to Lisp_Objects. This would work even if
30 USE_LSB_TAG is defined and wide integers are used, which might
31 happen in a future version of Emacs.
32
3c9dfce6
CY
332012-02-25 Chong Yidong <cyd@gnu.org>
34
fa74b241
CY
35 * fileio.c (Ffile_selinux_context, Fset_file_selinux_context):
36 Doc fix.
37
3c9dfce6
CY
38 * xselect.c (Fx_selection_exists_p): Doc fix.
39 (x_clipboard_manager_save_all): Print an informative message
40 before saving to clipboard manager.
41
9486df08
CY
422012-02-24 Chong Yidong <cyd@gnu.org>
43
44 * keyboard.c (process_special_events): Handle all X selection
45 requests in kbd_buffer, not just the next one (Bug#8869).
46
f01d3321
CY
472012-02-23 Chong Yidong <cyd@gnu.org>
48
49 * xfns.c (Fx_create_frame): Avoid window-configuration-change-hook
50 call when setting menu-bar-lines and tool-bar-lines parameters.
51 (unwind_create_frame_1): New helper function.
52
53 * window.c (inhibit_window_configuration_change_hook): New var.
54 (run_window_configuration_change_hook): Obey it.
b2e4ca7d 55 (syms_of_window): Initialize it.
f01d3321 56
86b847b6
CY
572012-02-22 Chong Yidong <cyd@gnu.org>
58
59 * xterm.c (x_draw_image_relief): Add missing type check for
60 Vtool_bar_button_margin (Bug#10743).
61
a59225b1
CY
622012-02-21 Chong Yidong <cyd@gnu.org>
63
64 * fileio.c (Vfile_name_handler_alist): Doc fix.
65
66 * buffer.c (Fget_file_buffer): Protect against invalid file
67 handler return value.
68
310f5bd4
PE
692012-02-20 Paul Eggert <eggert@cs.ucla.edu>
70
cb3a28cc
PE
71 * .gdbinit (xreload): Don't assume EMACS_INT fits in 'long'
72 when computing $valmask.
73
310f5bd4
PE
74 Fix crash due to non-contiguous EMACS_INT (Bug#10780).
75 * lisp.h (VALBITS): Move definition up, so that USE_LSB_TAG can use it.
76 (USE_LSB_TAG): Do not define if UINTPTR_MAX >> VALBITS == 0.
77 It's useless in that case, and it can cause problems on hosts
78 that allocate halves of EMACS_INT values separately.
79 Reported by Dan Horák. Diagnosed by Andreas Schwab in
80 <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=10780#30>.
81 * mem-limits.h (EXCEEDS_LISP_PTR): Define to 0 on hosts where
82 UINTPTR_MAX >> VALBITS == 0. This is required by the above change;
83 it avoids undefined behavior on hosts where shifting right by more
84 than the word width has undefined behavior.
85
2375c96a
CY
862012-02-19 Chong Yidong <cyd@gnu.org>
87
88 * fileio.c (Ffile_name_directory, Ffile_name_nondirectory)
89 (Funhandled_file_name_directory, Ffile_name_as_directory)
90 (Fdirectory_file_name, Fexpand_file_name)
91 (Fsubstitute_in_file_name): Protect against invalid file handler
92 return values (Bug#10845).
93
3eb49e71
EZ
942012-02-18 Eli Zaretskii <eliz@gnu.org>
95
96 * .gdbinit (pitx): Fix incorrect references to fields of the
97 iterator stack.
98
7b926f3f
CY
992012-02-17 Chong Yidong <cyd@gnu.org>
100
101 * syntax.c (Fscan_lists): Doc fix (Bug#10833).
102
11273115
PE
1032012-02-15 Paul Eggert <eggert@cs.ucla.edu>
104
105 * image.c (MAX_IMAGE_SIZE): Increase from 6.0 to 10.0; see
106 <http://lists.gnu.org/archive/html/emacs-devel/2012-02/msg00540.html>.
107
c3a70e2b
CY
1082012-02-15 Chong Yidong <cyd@gnu.org>
109
110 * eval.c (Fdefvar, Fdefconst): Doc fix; note that the variable is
111 marked as special. Also, starting docstrings with * is obsolete.
112
0ca43699
AS
1132012-02-13 Andreas Schwab <schwab@linux-m68k.org>
114
115 * gnutls.c (emacs_gnutls_write): Fix last change.
116
2e8f3c56
LI
1172012-02-13 Lars Ingebrigtsen <larsi@gnus.org>
118
119 * gnutls.c (emacs_gnutls_write): Set errno appropriately for
120 send_process.
121
af70074f
SM
1222012-02-13 Stefan Monnier <monnier@iro.umontreal.ca>
123
124 * keymap.c (Fsingle_key_description): Handle char ranges.
125
95986d52
CY
1262012-02-12 Chong Yidong <cyd@gnu.org>
127
afd83bd1
CY
128 * xdisp.c (handle_stop): Avoid assigning -1 to it->face_id here,
129 as that creates a dangerous corner case.
130
95986d52
CY
131 * window.c (Fdelete_window_internal): Invalidate the mouse
132 highlight (Bug#9904).
133
bd7da63e
GM
1342012-02-12 Glenn Morris <rgm@gnu.org>
135
136 * xselect.c (Fx_own_selection_internal)
137 (Fx_get_selection_internal, Fx_disown_selection_internal)
138 (Fx_selection_owner_p, Fx_selection_exists_p): Doc fixes.
139 * nsselect.m (Fx_own_selection_internal)
140 (Fx_disown_selection_internal, Fx_selection_exists_p)
141 (Fx_selection_owner_p, Fx_get_selection_internal):
142 Sync docs and argument specs with the xselect.c versions.
143
77abcbc2
LI
1442012-02-11 Lars Ingebrigtsen <larsi@gnus.org>
145
146 * gnutls.c (emacs_gnutls_write): Don't infloop if sendto fails.
147
90b671e2
EZ
1482012-02-11 Eli Zaretskii <eliz@gnu.org>
149
1c0ca0b7
EZ
150 * w32select.c (Fx_selection_exists_p): Sync doc string and
151 argument list with xselect.c. (Bug#10783)
152
153 * w16select.c (Fx_selection_exists_p): Sync doc string and
154 argument list with xselect.c. (Bug#10783)
90b671e2 155
49241268
GM
1562012-02-10 Glenn Morris <rgm@gnu.org>
157
158 * fns.c (Fsecure_hash): Doc fix.
159
f998bbe7 1602012-02-09 Kenichi Handa <handa@m17n.org>
5c1ca13d
KH
161
162 * coding.c (produce_chars): Fix updating of src_end (Bug#10701).
163
0992bd9c
CY
1642012-02-07 Chong Yidong <cyd@gnu.org>
165
166 * buffer.c (Fbuffer_local_variables)
167 (buffer_lisp_local_variables): Handle unbound vars correctly;
168 don't let Qunbound leak into Lisp.
169
af008560
GM
1702012-02-07 Glenn Morris <rgm@gnu.org>
171
dd605cc4
GM
172 * image.c (Fimagemagick_types): Doc fix.
173
af008560
GM
174 * image.c (imagemagick-render-type): Change it from a lisp object
175 to an integer. Move the doc here from the lisp manual.
176 Treat all values not equal to 0 the same.
177
1449fa1d
CY
1782012-02-06 Chong Yidong <cyd@gnu.org>
179
180 * doc.c (store_function_docstring): Avoid applying docstring of
181 alias to base function (Bug#2603).
182
3723ec07
AS
1832012-02-04 Andreas Schwab <schwab@linux-m68k.org>
184
185 * .gdbinit (pp1, pv1): Remove redundant defines.
186 (pr): Use pp.
187
79c1cc1e
CY
1882012-02-04 Chong Yidong <cyd@gnu.org>
189
190 * nsterm.m: Declare a global (Bug#10694).
191
d7f29f8e
EZ
1922012-02-04 Eli Zaretskii <eliz@gnu.org>
193
194 * w32.c (get_emacs_configuration_options): Include
195 --enable-checking, if specified, in the return value.
196
3b95a6f9
MR
1972012-02-04 Martin Rudalics <rudalics@gmx.at>
198
199 * dispnew.c (change_frame_size_1): Calculate new_frame_total_cols
200 after rounding frame sizes. (Bug#9723)
201
d6fa96a6
EZ
2022012-02-04 Eli Zaretskii <eliz@gnu.org>
203
204 * keyboard.c (adjust_point_for_property): Don't position point
205 before BEGV. (Bug#10696)
206
df0b2940
PE
2072012-02-03 Paul Eggert <eggert@cs.ucla.edu>
208
209 Handle overflow when computing char display width (Bug#9496).
210 * character.c (char_width): Return EMACS_INT, not int.
211 (char_width, c_string_width): Check for overflow when
212 computing the width; this is possible now that individual
213 characters can have unbounded width. Problem introduced
214 by merge from Emacs 23 on 2012-01-19.
215
6bee44d6
MA
2162012-02-02 Michael Albinus <michael.albinus@gmx.de>
217
218 * dbusbind.c (Fdbus_register_method): Mention the return value
219 :ignore in the docstring.
220
44f92739
GM
2212012-02-02 Glenn Morris <rgm@gnu.org>
222
1b9f60cc
GM
223 * callproc.c (Fcall_process, Fcall_process_region): Doc fix.
224
44f92739
GM
225 * nsterm.m (syms_of_nsterm) <x-toolkit-scroll-bars>:
226 Unconditionally set to t. (Bug#10673)
227 * nsterm.m (syms_of_nsterm) <x-toolkit-scroll-bars>:
228 * w32term.c (syms_of_w32term) <x-toolkit-scroll-bars>:
229 * xterm.c (syms_of_xterm) <x-toolkit-scroll-bars>: Doc fix.
230
c5d3843c
KH
2312012-02-02 Kenichi Handa <handa@m17n.org>
232
233 (x_produce_glyphs): Cancel previous change. If cmp->glyph_len is
234 0, do not call append_composite_glyph.
235
159462d4 2362012-02-02 Kenichi Handa <handa@m17n.org>
d2a51fd7
KH
237
238 * xdisp.c (BUILD_COMPOSITE_GLYPH_STRING): Initialize first_s to
239 NULL (Bug#6988).
240 (x_produce_glyphs): If the component of a composition is a null
241 string, set it->pixel_width to 1 to avoid zero-width glyph.
242
78cef877
EZ
2432012-02-01 Eli Zaretskii <eliz@gnu.org>
244
245 * ralloc.c (resize_bloc, r_alloc_sbrk): Don't call memmove if its
246 first 2 arguments are identical. This makes inserting large
247 output from a subprocess an order of magnitude faster on
248 MS-Windows, where all sbrk'ed memory is always contiguous.
249
97897668
GM
2502012-01-31 Glenn Morris <rgm@gnu.org>
251
252 * nsterm.m (syms_of_nsterm) <x-toolkit-scroll-bars>:
c78c6e0b 253 * w32term.c (syms_of_w32term) <x-toolkit-scroll-bars>:
97897668
GM
254 * xterm.c (syms_of_xterm) <x-toolkit-scroll-bars>: Sync docs.
255
31fd3586
GM
2562012-01-29 Glenn Morris <rgm@gnu.org>
257
258 * gnutls.c (syms_of_gnutls): More doc (from etc/NEWS).
259
0e24a8b2
CY
2602012-01-28 Samuel Thibault <sthibault@debian.org> (tiny change)
261
262 * s/gnu.h: Define POSIX_SIGNALS (Bug#10552).
263
cc0adcb0
CY
2642012-01-28 Chong Yidong <cyd@gnu.org>
265
266 * minibuf.c (syms_of_minibuf): Doc fix (Bug#10550).
267
acc28cb9
CY
2682012-01-26 Chong Yidong <cyd@gnu.org>
269
9c69cfb7
CY
270 * keyboard.c (Vecho_keystrokes): Document zero value (Bug#10503).
271
acc28cb9
CY
272 * search.c (Fsearch_forward, Fsearch_backward): Document negative
273 repeat counts (Bug#10507).
274
48da7392
GM
2752012-01-26 Glenn Morris <rgm@gnu.org>
276
277 * lread.c (syms_of_lread): Doc fix.
278
14af5f7f
CY
2792012-01-25 HIROSHI OOTA <nil@mad.dog.cx> (tiny change)
280
281 * coding.c (encode_designation_at_bol): Change return value to
282 EMACS_INT.
283
0b21c100
CY
2842012-01-25 Chong Yidong <cyd@gnu.org>
285
286 * eval.c (Fuser_variable_p): Doc fix; mention custom-variable-p.
287
3c2907f7
CY
2882012-01-21 Chong Yidong <cyd@gnu.org>
289
290 * floatfns.c (Fcopysign): Make the second argument non-optional,
291 since nil is not allowed anyway.
292
959ad23f
AS
2932012-01-21 Andreas Schwab <schwab@linux-m68k.org>
294
295 * process.c (read_process_output): Use p instead of XPROCESS (proc).
296 (send_process): Likewise.
297
34a02f46
MR
2982012-01-19 Martin Rudalics <rudalics@gmx.at>
299
300 * window.c (save_window_save, Fcurrent_window_configuration)
301 (Vwindow_persistent_parameters): Do not use Qstate. Rewrite
302 doc-strings.
303
1259009a 3042012-01-19 Kenichi Handa <handa@m17n.org>
25ed9e61
KH
305
306 * character.c (char_width): New function.
70d4fdf6
GM
307 (Fchar_width, c_string_width, lisp_string_width):
308 Use char_width (Bug#9496).
25ed9e61 309
6a6ee00d
MR
3102012-01-16 Martin Rudalics <rudalics@gmx.at>
311
312 * window.c (Vwindow_persistent_parameters): New variable.
313 (Fset_window_configuration, save_window_save): Handle persistent
314 window parameters.
315
c85efaf7
EZ
3162012-01-14 Eli Zaretskii <eliz@gnu.org>
317
318 * w32fns.c (signal_user_input): Don't do a QUIT, to avoid
319 thrashing the stack of the thread. (Bug#9087)
320
5944709e
PE
3212012-01-12 Paul Eggert <eggert@cs.ucla.edu>
322
323 * xdisp.c (rows_from_pos_range): Add parens as per gcc -Wparentheses.
324
e71f5d99
EZ
3252012-01-11 Eli Zaretskii <eliz@gnu.org>
326
327 * xdisp.c (rows_from_pos_range): Handle the case where the
328 highlight ends on a newline. (Bug#10464)
329 (mouse_face_from_buffer_pos): Fix off-by-one error in calculating
330 he end column for display of highlight that ends on a newline
331 before a R2L line.
332
ce316182
GM
3332012-01-11 Glenn Morris <rgm@gnu.org>
334
335 * lread.c (init_lread): If no-site-lisp, remove site-lisp dirs
336 from load-path also when installation-directory is nil. (Bug#10208)
337
5b43da69
GM
3382012-01-10 Glenn Morris <rgm@gnu.org>
339
74cc8ff9
GM
340 * emacs.c (syms_of_emacs) <installation-directory>: Doc fix.
341
7d8d6e4e
GM
342 * epaths.in (PATH_LOADSEARCH, PATH_EXEC, PATH_DATA, PATH_DOC):
343 Update template values to be closer to their typical values these days.
5b43da69 344
a0db8d43
EZ
3452012-01-09 Eli Zaretskii <eliz@gnu.org>
346
347 * xdisp.c (rows_from_pos_range): Accept additional argument
348 DISP_STRING, and accept any glyph in a row whose object is that
349 string as eligible for mouse highlight. Fixes mouse highlight of
350 display strings from overlays. (Bug#10464)
351
9a0115ab 3522012-01-07 Paul Eggert <eggert@cs.ucla.edu>
09450bae 353
b9110d6a 354 emacs: fix an auto-save permissions race condition (Bug#10400)
09450bae
PE
355 * fileio.c (auto_saving_dir_umask): New static var.
356 (Fmake_directory_internal): Use it.
357 (do_auto_save_make_dir): Set it, instead of invoking chmod after
358 creating the directory. The old code temporarily assigns
359 too-generous permissions to the directory.
360 (do_auto_save_eh): Clear it.
b9110d6a 361 (Fdo_auto_save): Catch all errors, not just file errors, so
09450bae
PE
362 that the var is always cleared.
363
6c1bd3f3
EZ
3642012-01-07 Eli Zaretskii <eliz@gnu.org>
365
366 * search.c (scan_buffer): Pass character positions to
367 know_region_cache, not byte positions. (Bug#6540)
368
069d2b50
L
3692012-01-07 LynX <_LynX@bk.ru> (tiny change)
370
371 * w32.c (sys_rename): Report EXDEV when rename of a directory
372 fails because the target is on another logical disk. (Bug#10284)
373
75bf0d33
DB
3742012-01-07 David Benjamin <davidben@mit.edu> (tiny change)
375
376 * xterm.c (x_embed_request_focus): New function.
377
378 * xterm.h: Add prototype.
379
380 * xfns.c (Fx_focus_frame): Use it for embedded frames (Bug#9977).
381
1c6e5a32
GM
3822012-01-05 Glenn Morris <rgm@gnu.org>
383
384 * emacs.c (emacs_copyright): Update short copyright year to 2012.
385
651e947e
EZ
3862012-01-01 Eli Zaretskii <eliz@gnu.org>
387
388 * gnutls.c (init_gnutls_functions): Load gnutls_check_version.
389 Load gnutls_transport_set_lowat only if GnuTLS version is below
390 2.11.1.
391 (emacs_gnutls_handshake): Call gnutls_transport_set_lowat only for
392 GnuTLS versions below 2.11.1.
393
3778cdd8
AL
3942011-12-31 Antoine Levitt <antoine.levitt@gmail.com>
395
396 * xdisp.c (syms_of_xdisp) <window-scroll-functions>: Add warning
397 to the doc string advising against its use for altering the way
398 windows are scrolled.
399
0e5317f7
KH
4002011-12-28 Kenichi Handa <handa@m17n.org>
401
402 * coding.c (Fdefine_coding_system_internal): Make an utf-8 base
403 coding-system ASCII compatible only when it does not produce BOM
404 on encoding (Bug#10383).
405
93d5ca1f
JD
4062011-12-26 Jan Djärv <jan.h.d@swipnet.se>
407
408 * xmenu.c (x_menu_wait_for_event): Use xg_select for Gtk3 so menus
409 can scroll.
410 (create_and_show_popup_menu): Always use menu_position_func for
411 Gtk3 (Bug#10361).
412
ca22b785
AS
4132011-12-24 Andreas Schwab <schwab@linux-m68k.org>
414
415 * callint.c (Fcall_interactively): Don't truncate prompt string.
416
d048e1e6
EZ
4172011-12-23 Eli Zaretskii <eliz@gnu.org>
418
419 * xdisp.c (handle_invisible_prop): Handle correctly an invisible
420 property that ends at ZV, so that the bidi iteration could be
3ba1a2ad 421 resumed from there (after widening). (Bug#10360)
d048e1e6 422
5ccaba1f
JD
4232011-12-22 Jan Djärv <jan.h.d@swipnet.se>
424
425 * nsfont.m (ns_spec_to_descriptor): Do not autorelease fdesc.
426
204ee57f
JD
4272011-12-21 Jan Djärv <jan.h.d@swipnet.se>
428
b81d40f0
JB
429 * nsterm.m (x_free_frame_resources):
430 Release f->output_data.ns->miniimage.
204ee57f
JD
431 (ns_index_color): Fix indentation. Do not retain
432 color_table->colors[i].
433
434 * nsmenu.m (ns_update_menubar): Call free_menubar_widget_value_tree
435 before returning.
436
437 * nsfns.m (x_set_background_color): Assign return value from
438 ns_index_color to face-background instead of NSColor*.
439 (ns_implicitly_set_icon_type): Fix indentation.
440 Change assignment in for loop to comparison.
441
442 * emacs.c (ns_pool): New variable.
443 (main): Assign ns_pool.
444 (Fkill_emacs): Call ns_release_autorelease_pool.
445
446 * nsfont.m (ns_spec_to_descriptor): Fix indentation,
447 autorelease fdesc, release fdAttrs and tdict.
448 (ns_get_covering_families): Release charset.
449 (ns_findfonts): Release NSFontDescriptor created with new.
450 (ns_uni_to_glyphs): Fix indentation.
451 (setString): Release attrStr before assigning new value.
452
c803b2b7
JD
4532011-12-18 Jan Djärv <jan.h.d@swipnet.se>
454
678f4426
JD
455 * nsmenu.m (NSMenuDidBeginTrackingNotification): Declare if OSX < 10.5
456 and NS_IMPL_COCOA.
457 (trackingNotification): Surround with ifdef NS_IMPL_COCOA.
458 (syms_of_nsmenu): Set trackingMenu to 1 if not NS_IMPL_COCOA.
459
cd394be1 4602011-12-18 David Reitter <reitter@cmu.edu>
678f4426 461
5fecd5fc
JD
462 * nsterm.m (ns_term_init): Subscribe for notifications
463 NSMenuDidBeginTrackingNotification and NSMenuDidEndTrackingNotification
464 to method trackingNotification in EmacsMenu.
465
466 * nsmenu.m (trackingMenu): New variable.
3771cb17 467 (trackingNotification): New method (from Aquamacs).
5fecd5fc 468 (menuNeedsUpdate): Expand comment and return if trackingMenu is 0,
3771cb17 469 from Aquamacs (Bug#7030).
678f4426
JD
470
4712011-12-18 Jan Djärv <jan.h.d@swipnet.se>
5fecd5fc 472
c803b2b7
JD
473 * nsselect.m (CUT_BUFFER_SUPPORT): Remove define.
474 (symbol_to_nsstring): Fix indentation.
475 (ns_symbol_to_pb): New function.
476 (Fns_get_selection_internal): Renamed from Fns_get_cut_buffer_internal.
477 (Fns_rotate_cut_buffers_internal): Removed.
478 (Fns_store_selection_internal): Renamed from
479 Fns_store_cut_buffer_internal.
480 (ns_get_foreign_selection, Fx_own_selection_internal)
481 (Fx_disown_selection_internal, Fx_selection_exists_p)
b81d40f0
JB
482 (Fns_get_selection_internal, Fns_store_selection_internal):
483 Use ns_symbol_to_pb and check if return value is nil.
484 (syms_of_nsselect): Remove ifdef CUT_BUFFER_SUPPORT. Remove defsubr
485 Sns_rotate_cut_buffers_internal. Sns_get_cut_buffer_internal
c803b2b7
JD
486 renamed to Sns_get_selection_internal, Sns_store_cut_buffer_internal
487 renamed to Sns_store_selection_internal.
488 (ns_handle_selection_request): Move code to Fx_own_selection_internal
489 and remove this function.
490 (ns_handle_selection_clear): Remove, never used.
491 (Fx_own_selection_internal): Move code from ns_handle_selection_request
492 here.
493
e1b01a3a
KB
4942011-12-17 Ken Brown <kbrown@cornell.edu>
495
496 * fileio.c (check_writable) [CYGWIN]: Return non-zero if UID or
497 GID is unknown (Bug#10257).
498
2adb6e85
PE
4992011-12-17 Paul Eggert <eggert@cs.ucla.edu>
500
501 * s/gnu-linux.h: Fix mark_memory typo (Bug#10286).
502 (GC_MARK_SECONDARY_STACK): Omit removed 3rd arg to mark_memory,
503 which caused a build failure on GNU/Linux IA-64. This problem was
504 introduced by my 2011-10-07 patch.
505
d1d7b339
JL
5062011-12-15 Juri Linkov <juri@jurta.org>
507
508 * image.c (imagemagick_error): New function. (Bug#10112)
509 (imagemagick_load_image): Comment out `MagickSetResolution' call.
510 Use `imagemagick_error' where ImageMagick functions return
511 `MagickFalse'.
512 (Fimagemagick_types): Add `Fnreverse' to return the list in the
513 proper order.
514
100d5755
KH
5152011-12-15 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
516
517 * xftfont.c (xftfont_draw): Use the font metrics of s->font to
518 fill background (Bug#8992).
519
454592a6
MR
5202011-12-13 Martin Rudalics <rudalics@gmx.at>
521
522 * window.c (Vwindow_combination_resize)
523 (Vwindow_combination_limit): Use t instead of non-nil in
524 doc-strings.
61d4b438
MR
525 (Vrecenter_redisplay): Add first sentence of doc-string on
526 separate line.
53524d93 527 (Frecenter): Fix doc-string typo.
454592a6 528
3633e3aa
KH
5292011-12-11 Kenichi Handa <handa@m17n.org>
530
531 * coding.c (Funencodable_char_position): Pay attention to the
532 buffer text relocation (Bug#9389).
533
7b9d523a
JD
5342011-12-10 Jan Djärv <jan.h.d@swipnet.se>
535
536 * xterm.c (x_term_init): Move call to gdk_window_add_filter before
537 gtk_init (Bug#10100).
538
b73189c6
EZ
5392011-12-10 Eli Zaretskii <eliz@gnu.org>
540
541 * xdisp.c (RECORD_MAX_MIN_POS): Use IT->cmp_it.charpos only if
542 IT->string is nil. (Bug#10263)
543
f7dfe5d6
JD
5442011-12-10 Jan Djärv <jan.h.d@swipnet.se>
545
83faebb4
JD
546 * nsterm.h (x_free_frame_resources): Declare.
547
f7dfe5d6
JD
548 * nsfns.m (ns_get_defaults_value): New function (Bug#10103).
549 (Fns_get_resource, x_get_string_resource): Call ns_get_defaults_value.
550
551 * nsterm.h (ns_get_defaults_value): Declare.
552
553 * nsterm.m (ns_default): Call ns_get_defaults_value.
554
7cd4e72c
EZ
5552011-12-09 Eli Zaretskii <eliz@gnu.org>
556
557 * xdisp.c (try_scrolling): Don't set scroll_down_p if dy is zero.
558 (Bug#10170)
559
b34d7317
YM
5602011-12-09 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
561
562 * unexelf.c (unexec) [NS_IMPL_GNUSTEP]: Take account of the case
563 that where the value of an _OBJC_* symbol points to is in the .bss
564 section (Bug#10240).
565
76470ad1
KH
5662011-12-08 Kazuhiro Ito <kzhr@d1.dion.ne.jp> (tiny change)
567
568 * coding.c (encode_coding_ccl): Check (charbuf < charbuf_end)
2fac8180 569 after the loop to call ccl_driver at least once (Bug#8619).
76470ad1 570
745fff94
KH
5712011-12-08 Kenichi Handa <handa@m17n.org>
572
573 * ftfont.c (get_adstyle_property): Fix previous change
574 (Bug#10233).
575
6e44397c
JB
5762011-12-07 Juanma Barranquero <lekktu@gmail.com>
577
578 * w32.c (init_environment): If no_site_lisp, remove site-lisp
579 dirs from the default value of EMACSLOADPATH (bug#10208).
580
7efa6272
GM
5812011-12-07 Glenn Morris <rgm@gnu.org>
582
583 * lread.c (init_lread): If no_site_lisp, exclude site-lisp/ in
584 installation and source directories as well. (Bug#10208)
585
f6fc4d87
CY
5862011-12-06 Chong Yidong <cyd@gnu.org>
587
588 * minibuf.c (Fread_from_minibuffer): Doc fix (Bug#10228).
589
2bf26180
GM
5902011-12-06 Glenn Morris <rgm@gnu.org>
591
592 * process.c (start_process_unwind): Treat any pid <= 0, except -2,
593 as an error, not just -1. (Bug#10217)
594
3a6ad4f0
CY
5952011-12-05 Chong Yidong <cyd@gnu.org>
596
597 * keyboard.c (process_special_events): New function.
598 (swallow_events, Finput_pending_p): Use it (Bug#10195).
599
75a3b399
PE
6002011-12-05 Paul Eggert <eggert@cs.ucla.edu>
601
602 * coding.c (encode_designation_at_bol): Don't use uninitialized
603 local variable (Bug#9318).
604
c3c9e25e
KH
6052011-12-05 Kenichi Handa <handa@m17n.org>
606
607 * ftfont.c (get_adstyle_property): If the font is not BDF nor PCF,
608 return Qnil (Bug#8046, Bug#10193).
609
5eb05ea3
KH
6102011-12-05 Kenichi Handa <handa@m17n.org>
611
612 * coding.c (encode_designation_at_bol): New args charbuf_end and
613 dst. Return the number of produced bytes. Callers changed.
a79703f5
KH
614 (coding_set_source): Return how many bytes coding->source was
615 relocated.
616 (coding_set_destination): Return how many bytes
617 coding->destination was relocated.
618 (CODING_DECODE_CHAR, CODING_ENCODE_CHAR, CODING_CHAR_CHARSET)
619 (CODING_CHAR_CHARSET_P): Adjusted for the avove changes.
5eb05ea3
KH
620
6212011-12-05 Kazuhiro Ito <kzhr@d1.dion.ne.jp> (tiny change)
622
623 * coding.c (CODING_CHAR_CHARSET_P): New macro.
624 (encode_coding_emacs_mule, encode_coding_iso_2022): Use the above
625 macro (Bug#9318).
626
6272011-12-05 Andreas Schwab <schwab@linux-m68k.org>
628
629 The following changes are to fix Bug#9318.
630
a79703f5 631 * coding.c (CODING_ENCODE_CHAR, CODING_CHAR_CHARSET): New macros.
5eb05ea3
KH
632 (encode_coding_emacs_mule, ENCODE_ISO_CHARACTER)
633 (encode_coding_iso_2022, encode_coding_sjis)
a79703f5 634 (encode_coding_big5, encode_coding_charset): Use the above macros.
5eb05ea3 635
7dbda6df
JB
6362011-12-05 Juanma Barranquero <lekktu@gmail.com>
637
638 * lisp.h (process_quit_flag): Fix external declaration.
639
6d5eb5b0
SM
6402011-12-04 Stefan Monnier <monnier@iro.umontreal.ca>
641
642 Don't macro-inline non-performance-critical code.
643 * eval.c (process_quit_flag): New function.
644 * lisp.h (QUIT): Use it.
645
a0c3fad0
JD
6462011-12-04 Jan Djärv <jan.h.d@swipnet.se>
647
648 * nsfns.m (get_geometry_from_preferences): New function.
649 (Fx_create_frame): Call get_geometry_from_preferences (Bug#10103).
650
6c07aac2
AS
6512011-12-04 Andreas Schwab <schwab@linux-m68k.org>
652
653 * emacs.c (Qkill_emacs): Define.
654 (syms_of_emacs): Initialize it.
655 * keyboard.c (interrupt_signal): Don't call Fkill_emacs here, set
656 Qquit_flag to `kill-emacs' instead.
6d5eb5b0
SM
657 (quit_throw_to_read_char): Add parameter `from_signal'.
658 All callers changed. Call Fkill_emacs if requested and safe.
6c07aac2
AS
659 * lisp.h (QUIT): Call Fkill_emacs if requested.
660
c052ead4
JD
6612011-12-03 Jan Djärv <jan.h.d@swipnet.se>
662
663 * widget.c (update_wm_hints): Return if wmshell is null.
664 (widget_update_wm_size_hints): New function.
665
666 * widget.h (widget_update_wm_size_hints): Declare.
667
668 * xterm.c (x_wm_set_size_hint): If USE_X_TOOLKIT, call
669 widget_update_wm_size_hints (Bug#10104).
670
9e49252b
EZ
6712011-12-03 Eli Zaretskii <eliz@gnu.org>
672
673 * xdisp.c (handle_invisible_prop): If the invisible text ends just
674 before a newline, prepare the bidi iterator for consuming the
675 newline, and keep the current paragraph direction. (Bug#10183)
e9a49426 676 (redisplay_window): Don't let `margin' become negative. (Bug#10192)
9e49252b 677
02b16839
JL
6782011-12-02 Juri Linkov <juri@jurta.org>
679
680 * search.c (Fword_search_regexp): New Lisp function created from
681 `wordify'. Change type of arg `lax' from `int' to `Lisp_Object'.
682 (Fword_search_backward, Fword_search_forward)
683 (Fword_search_backward_lax, Fword_search_forward_lax):
684 Use `Fword_search_regexp' instead of `wordify'. Doc fix.
685 (syms_of_search): Define `Sword_search_regexp'. (Bug#10145)
686
0068070e
SM
6872011-12-01 Stefan Monnier <monnier@iro.umontreal.ca>
688
689 * fileio.c (Finsert_file_contents): Move after-change-function call
690 to before the "handled:" label, since all "goto handled" appear in
691 cases where the *-change-functions have already been properly called
692 (bug#10117).
693
3360a3fc
AS
6942011-12-01 Andreas Schwab <schwab@linux-m68k.org>
695
696 * keyboard.c (interrupt_signal): Don't call kill-emacs when
697 waiting for input. (Bug#10169)
698
73d6c093
EZ
6992011-11-30 Eli Zaretskii <eliz@gnu.org>
700
701 * dispnew.c (adjust_glyph_matrix): Remove the assertion that
702 verifies glyph row's hash code--we have just reallocated the
703 glyphs, so their contents can be complete garbage. (Bug#10164)
704
febe6bea
JB
7052011-11-30 Juanma Barranquero <lekktu@gmail.com>
706
707 * dispnew.c (adjust_glyph_matrix) [XASSERTS]: Add missing check.
708
801a4313
EZ
7092011-11-30 Eli Zaretskii <eliz@gnu.org>
710
711 * dispnew.c (adjust_glyph_matrix) [XASSERTS]: Ensure ROW's
712 attributes are tested _before_ calling verify_row_hash, to protect
713 against GCC re-ordering of the tests. (Bug#10164)
714
2b56b87e
JD
7152011-11-29 Jan Djärv <jan.h.d@swipnet.se>
716
717 * xterm.h (struct x_output): net_wm_state_hidden_seen is new.
718
719 * xterm.c (handle_one_xevent): Only set async_visible and friends
720 if net_wm_state_hidden_seen is non-zero (Bug#10002)
7dbda6df 721 (get_current_wm_state): Set net_wm_state_hidden_seen to 1 if
2b56b87e
JD
722 _NET_WM_STATE_HIDDEN is in NET_WM_STATE.
723
dbf31225
PE
7242011-11-28 Paul Eggert <eggert@cs.ucla.edu>
725
726 Remove GCPRO-related macros that exist only to avoid shadowing locals.
727 * lisp.h (GCPRO1_VAR, GCPRO2_VAR, GCPRO3_VAR, GCPRO4_VAR, GCPRO5_VAR)
728 (GCPRO6_VAR, UNGCPRO_VAR): Remove. See
729 <http://lists.gnu.org/archive/html/emacs-diffs/2011-11/msg00265.html>.
730 All uses changed to use GCPRO1 etc.
731 (GCPRO1, GCPRO2, GCPRO3, GCPRO4, GCPRO5, GCPRO6, UNGCPRO):
732 Revert to old implementation (i.e., before 2011-03-11).
733
1305621b
YM
7342011-11-28 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
735
736 * dispnew.c (scrolling_window): Truncate overlaps in copy destination
737 of scroll runs so as to avoid assigning disabled bogus rows and
738 unnecessary graphics copy operations.
739
8c9afb46
EZ
7402011-11-27 Eli Zaretskii <eliz@gnu.org>
741
742 * s/ms-w32.h (utimbuf) [_MSC_VER]: Don't define.
743 (snprintf) [_MSC_VER]: Redirect to _snprintf.
744 (strtoll) [_MSC_VER]: Redirect to _strtoi64.
745 (malloc, free, realloc, calloc): Redirect to e_* only when
746 compiling Emacs.
747
748 * lisp.h (GCTYPEBITS): Move before first use.
749 (ALIGN_GCTYPEBITS) [_MSC_VER]: Define.
750 (DECL_ALIGN) [_MSC_VER]: Use it, as MSVC doesn't like bit ops in
751 this macro definition.
752
753 * s/ms-w32.h (tzname): Redirect to _tzname for all values of
754 _MSC_VER.
755
54e9e3bf
JD
7562011-11-27 Jan Djärv <jan.h.d@swipnet.se>
757
6d5eb5b0
SM
758 * gtkutil.c (xg_create_frame_widgets):
759 Call gtk_window_set_has_resize_grip (FALSE) if that function is
54e9e3bf
JD
760 present with Gtk+ 2.0.
761
83aca1cb
PE
7622011-11-26 Paul Eggert <eggert@cs.ucla.edu>
763
764 * fileio.c (Finsert_file_contents): Undo previous change; see
765 <http://lists.gnu.org/archive/html/emacs-diffs/2011-11/msg00265.html>.
766
5b76caa4
PE
7672011-11-26 Paul Eggert <eggert@cs.ucla.edu>
768
769 Rename locals to avoid shadowing.
770 * fileio.c (Finsert_file_contents):
771 Rename inner 'gcpro1' to 'inner_gcpro1' to avoid shadowing.
772 * process.c (wait_reading_process_output):
773 Rename inner 'proc' to 'p' to avoid shadowing.
774 Indent for consistency with usual Emacs style.
775
8c535114
EZ
7762011-11-25 Eli Zaretskii <eliz@gnu.org>
777
778 * xdisp.c (redisplay_window): If cursor row is not fully visible
779 after recentering, and scroll-conservatively is set to a large
780 number, scroll window by a few more lines to make the cursor fully
781 visible and out of scroll-margin. (Bug#10105)
91b4a718
EZ
782 (start_display): Don't move to the next line if the display should
783 start at a newline that is part of a display vector or an overlay
784 string. (Bug#10119)
8c535114 785
fa4fdb5c
JL
7862011-11-24 Juri Linkov <juri@jurta.org>
787
788 * image.c (imagemagick_load_image): Move `MagickSetResolution' down
789 after the `MagickPingImage' call. (Bug#10112)
790
90ec88df
CY
7912011-11-23 Chong Yidong <cyd@gnu.org>
792
793 * window.c (Fcoordinates_in_window_p): Accept only live windows.
794
56e2e794
MR
7952011-11-23 Martin Rudalics <rudalics@gmx.at>
796
797 * buffer.c (Fkill_buffer): Run replace_buffer_in_windows before
798 making another buffer current. (Bug#10114)
799
b6e64c41
GM
8002011-11-23 Glenn Morris <rgm@gnu.org>
801
802 * font.c (font_find_for_lface) [HAVE_NS]: Ignore case. (Bug#2526)
803
6b21de18
CY
8042011-11-23 Chong Yidong <cyd@gnu.org>
805
806 * xdisp.c (compute_stop_pos): Check validity of end_charpos before
807 using it (Bug#5984).
808
b12cd789
EZ
8092011-11-22 Eli Zaretskii <eliz@gnu.org>
810
811 * dispnew.c (adjust_glyph_matrix): Don't verify hash code of mode-
812 and header-lines, as they don't have one computed for them.
813 (Bug#10098)
814
815 * .gdbinit (prow): Make displayed values more self-explaining.
816 Add row's hash code.
817
261b6fd4
LMI
8182011-11-21 Lars Magne Ingebrigtsen <larsi@gnus.org>
819
820 * process.c (wait_reading_process_output): Fix asynchrounous
821 GnuTLS socket handling on some versions of the GnuTLS library.
16c1ad08 822 (wait_reading_process_output): Add comment and URL.
261b6fd4 823
e7cfd277
JD
8242011-11-21 Jan Djärv <jan.h.d@swipnet.se>
825
826 * xterm.c (x_clear_frame): Reinstate the XClearWindow call.
827
a9b9b7f5
CY
8282011-11-21 Chong Yidong <cyd@gnu.org>
829
830 * window.c (Fnext_window, Fprevious_window): Doc fix.
831
b0d15b4f
SM
8322011-11-20 Stefan Monnier <monnier@iro.umontreal.ca>
833
834 * window.c (get_phys_cursor_glyph): Fix Lisp_Object/int mixup.
835
fe7a3057
JB
8362011-11-20 Juanma Barranquero <lekktu@gmail.com>
837
838 * nsfont.m (syms_of_nsfont) <ns-reg-to-script>: Fix typo.
839
d2999b1a
MR
8402011-11-20 Martin Rudalics <rudalics@gmx.at>
841
842 * window.c (Fset_window_combination_limit): Rename argument
843 STATUS to LIMIT.
844 (Vwindow_combination_limit): Remove "status" from doc-string.
845
d5ff9cd0
AS
8462011-11-20 Andreas Schwab <schwab@linux-m68k.org>
847
848 * m/ibms390.h: Remove.
849 * m/ibms390x.h: Don't include "ibms390.h".
850
a5bb9bd3
SM
8512011-11-20 Stefan Monnier <monnier@iro.umontreal.ca>
852
853 * fileio.c (Finsert_file_contents): Add missing gcpro1 variable.
854 Suggested by Dmitry Antipov <dmantipov@yandex.ru>.
855
cd1181db
JB
8562011-11-20 Juanma Barranquero <lekktu@gmail.com>
857
858 * casetab.c (Fset_case_table):
859 * charset.c (Fcharset_after): Fix typos.
860
615a3b8d 8612011-11-20 Paul Eggert <eggert@cs.ucla.edu>
6a0bf43d 862
17e845af
PE
863 Standardize on VIRT_ADDR_VARIES behavior (Bug#10042).
864 Otherwise, valgrind does not work on some platforms.
865 Problem reported by Andreas Schwab in
6a0bf43d
PE
866 <http://lists.gnu.org/archive/html/emacs-devel/2011-11/msg00081.html>.
867 * puresize.h (pure, PURE_P): Always behave as if VIRT_ADDR_VARIES
868 is set, removing the need for VIRT_ADDRESS_VARIES.
869 (PURE_P): Use a more-efficient implementation that needs just one
870 comparison, not two: on x86-64 with GCC 4.6.2, this cut down the
871 number of instructions from 6 (xorl, cmpq, jge, xorl, cmpq, setge)
872 to 4 (xorl, subq, cmpq, setbe).
873 * alloc.c (pure): Always extern now, since that's the
874 VIRT_ADDR_VARIES behavior.
875 (PURE_POINTER_P): Use a single comparison, not two, for
876 consistency with the new puresize.h.
877 * lisp.h (PNTR_COMPARISON_TYPE): Remove; no longer needed.
878 * m/ibms390.h, m/intel386.h, m/template.h, s/cygwin.h, s/hpux10-20.h:
879 Remove VIRT_ADDR_VARIES no longer needed.
880
f8fe6f96
EZ
8812011-11-19 Eli Zaretskii <eliz@gnu.org>
882
883 * xdisp.c (x_write_glyphs, draw_phys_cursor_glyph)
884 (erase_phys_cursor, update_window_cursor, show_mouse_face)
885 (cursor_in_mouse_face_p): If the cursor position is out of bounds,
886 behave as if the cursor position were at the window margin.
887
888 * window.c (get_phys_cursor_glyph): If the window is hscrolled,
889 and the cursor position is out of bounds, behave as if the cursor
890 position were at the window margin. (Bug#10075)
891
df05a53c
CY
8922011-11-18 Chong Yidong <cyd@gnu.org>
893
894 * window.c (Fwindow_combination_limit): Make first argument
895 non-optional, since it is meaningless for live windows like the
896 selected window.
897
2071918e
DA
8982011-11-18 Dmitry Antipov <dmantipov@yandex.ru>
899
900 * keymap.c (Fwhere_is_internal): Add missing RETURN_UNGCPROs.
901
b50a28de
SM
9022011-11-18 Stefan Monnier <monnier@iro.umontreal.ca>
903
904 * intervals.c: Fix grafting over the whole buffer (bug#10071).
905 (graft_intervals_into_buffer): Simplify.
906
015137db
EZ
9072011-11-18 Eli Zaretskii <eliz@gnu.org>
908
909 * dispnew.c (swap_glyph_pointers): Swap the used[] arrays and the
910 hash values of the two rows.
911 (copy_row_except_pointers): Preserve the used[] arrays and the
912 hash values of the two rows. (Bug#10035)
68c95424 913 (add_row_entry): Add xassert to verify that ROW's hash code is valid.
015137db
EZ
914
915 * xdisp.c (row_hash): New function, body extracted from
916 compute_line_metrics.
917 (compute_line_metrics): Call row_hash, instead of computing the
918 hash code inline.
919
920 * dispnew.c (verify_row_hash): Call row_hash for computing the
921 hash code of a row, instead of duplicating code from xdisp.c.
922
923 * dispextern.h (row_hash): Add prototype.
924
a2addb04
TH
9252011-11-18 Tassilo Horn <tassilo@member.fsf.org>
926
927 * frame.c (delete_frame): Don't delete the terminal when the last
928 X frame is closed if emacs is built with GTK toolkit.
929
df85d315
JB
9302011-11-17 Juanma Barranquero <lekktu@gmail.com>
931
932 * window.c (syms_of_window) <window-combination-resize>: Fix typo.
933
a0c2d0ae
MR
9342011-11-17 Martin Rudalics <rudalics@gmx.at>
935
936 * window.c (Vwindow_splits): Rename to
937 Vwindow_combination_resize. Suggested by Juri Linkov.
938 (Fsplit_window_internal): Use Vwindow_combination_resize instead
939 of Vwindow_splits.
940
58179cce
JB
9412011-11-16 Juanma Barranquero <lekktu@gmail.com>
942
7877f373
JB
943 * nsfns.m (Fns_font_name):
944 * window.c (syms_of_window) <window-combination-limit>: Fix typos.
58179cce 945
b6f67890
MR
9462011-11-16 Martin Rudalics <rudalics@gmx.at>
947
948 * window.h (window): Rename slot "nest" to "combination_limit".
949 * window.c (Fwindow_nest): Rename to Fwindow_combination_limit.
950 (Fset_window_nest): Rename to Fset_window_combination_limit.
951 (Vwindow_nest): Rename to Vwindow_combination_limit.
952 (recombine_windows, make_parent_window, make_window)
953 (Fsplit_window_internal, saved_window)
954 (Fset_window_configuration, save_window_save): Rename all
955 occurrences of window_nest to window_combination_limit.
956
c7015153
JB
9572011-11-15 Juanma Barranquero <lekktu@gmail.com>
958
959 * image.c (imagemagick_load_image): Fix typo.
960
322ad6ec
EZ
9612011-11-14 Eli Zaretskii <eliz@gnu.org>
962
963 * xdisp.c (display_line): Move the call to
964 highlight_trailing_whitespace before the call to
965 compute_line_metrics, since the latter needs to see the final
6d5eb5b0
SM
966 faces of all the glyphs to compute ROW's hash value.
967 Fixes assertion violations in row_equal_p. (Bug#10035)
322ad6ec 968
f067b8ec
JB
9692011-11-14 Juanma Barranquero <lekktu@gmail.com>
970
971 * w32proc.c (reader_thread): Don't check pending input if cp->fd < 0,
972 just return (bug#10044).
973
1e5b2111
EZ
9742011-11-12 Eli Zaretskii <eliz@gnu.org>
975
7ef3cbd5
EZ
976 * makefile.w32-in (HEAPSIZE): New variable, allows to build temacs
977 with user-defined heap size. Bump the default size of the temacs
978 heap to 27MB, to avoid memory warning when running temacs.
979 ($(TEMACS)): Use HEAPSIZE instead of a hardcoded value.
980
1e5b2111
EZ
981 * dispnew.c (scrolling_window): Fix incorrect indices in accessing
982 current_matrix and desired_matrix. (Bug#9990)
7a7270dd
EZ
983 (verify_row_hash) [XASSERTS]: New function.
984 (adjust_glyph_matrix, row_equal_p): Use it in xassert to verify
985 that the hash value of glyph rows is correct.
1e5b2111 986
89d61221
MR
9872011-11-12 Martin Rudalics <rudalics@gmx.at>
988
989 * window.h (window): Remove splits slot.
990 * window.c (Fwindow_splits, Fset_window_splits): Remove.
991 (Fdelete_other_windows_internal, make_parent_window)
992 (make_window, Fsplit_window_internal, Fdelete_window_internal)
993 (Fset_window_configuration, save_window_save): Don't deal with
994 split status of windows.
995 (saved_window): Remove splits slot.
996 (Vwindow_splits): Rewrite doc-string.
997
97f18cc8
JD
9982011-11-11 Jan Djärv <jan.h.d@swipnet.se>
999
1000 * xfns.c (unwind_create_frame):
1001 * nsfns.m (unwind_create_frame):
1002 * w32fns.c (unwind_create_frame): Use Fmemq to check if frame is in
1003 Vframe_list (Bug#9999).
1004
22a648b4
DA
10052011-11-11 Dmitry Antipov <dmantipov@yandex.ru>
1006
0b381c7e 1007 * xdisp.c (syms_of_xdisp): Remove duplicated definition of Qtext.
22a648b4 1008
659afede
KH
10092011-11-11 Kenichi Handa <handa@m17n.org>
1010
1011 * callproc.c (Fcall_process): Set the member dst_multibyte of
1012 process_coding.
1013
9ac0394b
KH
10142011-11-11 Johan Bockgård <bojohan@gnu.org>
1015
1016 * xdisp.c (fill_composite_glyph_string): Always set s->face, to
1017 avoid a crash (bug#9496).
1018
2fbdc249
CY
10192011-11-09 Chong Yidong <cyd@gnu.org>
1020
1021 * window.c (Fwindow_inside_edges, Fwindow_inside_pixel_edges)
1022 (Fwindow_inside_absolute_pixel_edges): Only allow live windows.
1023
ac6b1f81
PE
10242011-11-08 Paul Eggert <eggert@cs.ucla.edu>
1025
1026 * s/gnu.h (GC_MARK_STACK): Define to GC_MAKE_GCPROS_NOOPS (Bug#9926).
1027
09db192c
PE
10282011-11-08 Paul Eggert <eggert@cs.ucla.edu>
1029
1030 Avoid some portability problems by eschewing 'extern inline' functions.
1031 The trivial performance wins aren't worth the portability hassles; see
1032 <http://lists.gnu.org/archive/html/emacs-devel/2011-11/msg00084.html>
1033 et seq.
1034 * dispextern.h (window_box, window_box_height, window_text_bottom_y)
1035 (window_box_width, window_box_left, window_box_left_offset)
1036 (window_box_right, window_box_right_offset): Undo previous change,
1037 by removing the "extern"s.
1038 * intervals.c (adjust_intervals_for_insertion)
1039 (adjust_intervals_for_deletion): Undo previous change,
1040 making these static again.
1041 (offset_intervals, temp_set_point_both, temp_set_point)
1042 (copy_intervals_to_string): No longer inline.
1043 * xdisp.c (window_text_bottom_y, window_box_width)
1044 (window_box_height, window_box_left_offset)
1045 (window_box_right_offset, window_box_left, window_box_right)
1046 (window_box): No longer inline.
1047
105216ed
CY
10482011-11-08 Chong Yidong <cyd@gnu.org>
1049
1050 * window.c (Fwindow_left_column, Fwindow_top_line): Doc fix.
6d5eb5b0
SM
1051 (Fwindow_body_height, Fwindow_body_width): Move from Lisp.
1052 Signal an error if not a live window.
105216ed
CY
1053 (Fwindow_total_width, Fwindow_total_height): Move from Lisp.
1054 (Fwindow_total_size, Fwindow_body_size): Move to Lisp.
1055
ae9e237f
JB
10562011-11-07 Juanma Barranquero <lekktu@gmail.com>
1057
1058 * lisp.h (syms_of_abbrev): Remove declaration.
1059 Reported by CHENG Gao <chenggao@royau.me>.
1060
c7aa8333
EZ
10612011-11-07 Eli Zaretskii <eliz@gnu.org>
1062
1063 * w32.c (check_windows_init_file): Don't look for term/w32-win.el
1064 if Vpurify_flag is non-nil. Fixes a crash when running w32 build
1065 of temacs in GUI mode.
1066
be7f5545
MR
10672011-11-07 Martin Rudalics <rudalics@gmx.at>
1068
1069 * window.h: Declare delete_all_child_windows instead of
1070 delete_all_subwindows.
1071 * window.c (Fwindow_nest, Fset_window_nest)
1072 (Fset_window_new_total, Fset_window_new_normal)
1073 (Fwindow_resize_apply): Don't use term subwindow in doc-strings.
1074 (delete_all_subwindows): Rename to delete_all_child_windows.
1075 (Fdelete_other_windows_internal, Fset_window_configuration):
1076 Call delete_all_child_windows instead of delete_all_subwindows.
1077 * frame.c (delete_frame): Call delete_all_child_windows instead
1078 of delete_all_subwindows.
1079
ca78dc43
PE
10802011-11-07 Paul Eggert <eggert@cs.ucla.edu>
1081
1082 * alloc.c (DEADP): New macro, for porting to GNU/Hurd (Bug#9926).
1083 This is also needed for porting to any host where GC_MARK_STACK is
1084 not GC_MAKE_GCPROS_NOOPS.
1085 (which_symbols): Use it.
1086
a0241d01
KH
10872011-11-07 Kenichi Handa <handa@m17n.org>
1088
1089 * coding.c (coding_set_destination): Check coding->src_pos only
1090 when coding->src_object is a buffer (bug#9910).
1091
1092 * process.c (send_process): Set the member src_multibyte of coding
1093 to 0 (bug#9911) when sending a unibyte text.
1094
1095 * callproc.c (Fcall_process): Set the member src_multibyte of
1096 process_coding to 0 (bug#9912).
1097
a64bfdfa 10982011-11-06 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
ba24cea2
YM
1099
1100 * xmenu.c (cleanup_widget_value_tree): New function.
1101 (xmenu_show, xdialog_show): Use it in record_unwind_protect instead of
1102 calling free_menubar_widget_value_tree directly (Bug#9830).
1103
cb41b32a
PE
11042011-11-06 Paul Eggert <eggert@cs.ucla.edu>
1105
1106 Fix some portability problems with 'inline'.
1107 * dispextern.h (window_box, window_box_height, window_text_bottom_y)
1108 (window_box_width, window_box_left, window_box_left_offset)
1109 (window_box_right, window_box_right_offset): Declare extern.
1110 Otherwise, these inline functions do not conform to C99 and
1111 are miscompiled by Microsoft compilers. Reported by Eli Zaretskii in
1112 <http://lists.gnu.org/archive/html/emacs-devel/2011-11/msg00084.html>.
1113 * intervals.c (adjust_intervals_for_insertion)
1114 (adjust_intervals_for_deletion): Now extern, because otherwise the
1115 extern inline functions 'offset_intervals' couldn't refer to it.
1116 (static_offset_intervals): Remove.
1117 (offset_intervals): Rewrite using the old contents of
1118 static_offset_intervals. The old version didn't conform to C99
1119 because an extern inline function contained a reference to an
1120 identifier with static linkage.
1121
b7041366
AS
11222011-11-06 Andreas Schwab <schwab@linux-m68k.org>
1123
1124 * keyboard.c (interrupt_signal): Don't call kill-emacs while in
1125 GC.
1126
88a37c4d
EZ
11272011-11-06 Eli Zaretskii <eliz@gnu.org>
1128
1129 * xdisp.c (init_iterator, reseat_to_string): Don't set the
1130 iterator's bidi_p flag if Vpurify_flag is non-nil. (Bug#9963)
1131 (Fcurrent_bidi_paragraph_direction): If Vpurify_flag is non-nil,
1132 return Qleft_to_right.
1133
49745b39
CY
11342011-11-06 Chong Yidong <cyd@gnu.org>
1135
1136 * window.c (Fwindow_live_p, Fwindow_frame, Fframe_root_window)
1137 (Fminibuffer_window, Fwindow_buffer, Fwindow_splits)
1138 (Fset_window_splits, Fwindow_nest, Fset_window_nest)
1139 (Fwindow_use_time, Fwindow_total_size, Fwindow_normal_size)
1140 (Fwindow_new_normal, Fwindow_left_column, Fwindow_top_line)
1141 (Fwindow_margins, Fwindow_fringes, Fwindow_scroll_bars)
1142 (Fwindow_vscroll): Doc fix.
1143 (Fwindow_top_child, Fwindow_left_child): Eliminate a nil default
1144 argument, since it makes no sense to pass a live window and for
1145 consistency with window-child.
1146
1f05cd82
CS
11472011-11-05 Christoph Scholtes <cschol2112@googlemail.com>
1148
1149 * makefile.w32-in ($(TEMACS), (gl-stamp)): Use $(THISDIR) to
1150 support MSVC.
1151
22610910
JR
11522011-11-05 Jason Rumney <jasonr@gnu.org>
1153
1154 * w32font.c (font_matches_spec): Filter out non-Japanese kana fonts.
1155 (add_font_entity_to_list): Filter out non-Japanese Shift-JIS
1156 fonts (Bug#6029).
1157 (add_font_entity_to_list): Fix logic errors in mixed boolean and
1158 bitwise arithmetic preventing use of unicode-sip and non-truetype
1159 opentype fonts.
1160
a06776b2
EZ
11612011-11-05 Eli Zaretskii <eliz@gnu.org>
1162
3ad924ba
EZ
1163 * s/ms-w32.h (fstat, stat, utime): Move redirections to
1164 "emacs"-only part.
1165
a06776b2
EZ
1166 * w32fns.c (x_create_tip_frame, Fx_create_frame): Rearrange
1167 initialization code to keep similarity to xfns.c after changes
1168 from 2011-11-05.
1169
c9e7db78
JD
11702011-11-05 Jan Djärv <jan.h.d@swipnet.se>
1171
a97f8f3f
JD
1172 * nsfns.m: Declare image_cache_refcount if GLYPH_DEBUG.
1173 (unwind_create_frame): New function (Bug#9943).
1174 (Fx_create_frame): Restructure code to be more similar to the one in
1175 xfns.c. Call record_unwind_protect with unwind_create_frame (Bug#9943).
1176 Initialize image_cache_refcount if GLYPH_DEBUG (Bug#9943).
1177 Move terminal->reference_count++ just before making the frame official
1178 (Bug#9943).
1179
1180 * nsterm.m (x_free_frame_resources): New function.
1181 (x_destroy_window): Move code to x_free_frame_resources.
1182
c9e7db78 1183 * xfns.c (unwind_create_frame): Fix comment.
6d5eb5b0
SM
1184 (Fx_create_frame, x_create_tip_frame):
1185 Move terminal->reference_count++ just before making the frame
c9e7db78
JD
1186 official. Move initialization of image_cache_refcount and
1187 dpyinfo_refcount before calling init_frame_faces (Bug#9943).
1188
a6fc3b5c
EZ
11892011-11-05 Eli Zaretskii <eliz@gnu.org>
1190
1191 Support MSVC build with newer versions of Visual Studio.
1192 * makefile.w32-in (TAGS-gmake): Don't use $(patsubst ...), as
1193 Nmake barfs on that. Use $(OBJ*_c) variables instead, defined on
1194 nt/gmake.defs.
1195
1196 * lisp.h (ENUM_BF): New macro, for enumerated types in bitfields,
1197 which are not supported by MSVC.
1198 (Lisp_Symbol, Lisp_Misc_Any, Lisp_Marker, Lisp_Misc_Overlay)
1199 (Lisp_Save_Value, Lisp_Free): Use ENUM_BF for enumerated types in
1200 bitfields.
1201 (Lisp_Object) [USE_LISP_UNION_TYPE]: Use ENUM_BF for enumerated
1202 types in bitfields.
1203 (DEFUN) [_MSC_VER]: Define in a different way for MSVC.
1204
1205 * w32fns.c [_MSC_VER]: DECLARE_HANDLE for any MSVC version.
1206
58179cce 12072011-11-05 Fabrice Popineau <fabrice.popineau@supelec.fr> (tiny change)
a6fc3b5c
EZ
1208
1209 Support MSVC build with newer versions of Visual Studio.
1210 * w32.c: Don't include w32api.h for MSVC.
1211 (init_environment) [_MSC_VER]: Call sys_access, not _access.
1212
1213 * s/ms-w32.h <sigset_t, ssize_t> [_MSC_VER]: Typedefs for MSVC.
1214 [_MSC_VER]: Include sys/timeb.h, sys/stat.h, and signal.h.
1215 (fstat, stat, utime) [_MSC_VER]: Redirect to their sys_* cousins.
1216 (malloc, free, realloc, calloc) [_MSC_VER]: Always redirect to the
1217 e_* cousins.
1218 (alloca) [_MSC_VER]: Define to _alloca.
1219
1220 * lisp.h (DECL_ALIGN) [_MSC_VER]: Define for MSVC.
1221
1222 * regex.c <re_char> [_MSC_VER]: A separate definition for MSVC.
1223
a58c13ed
EZ
12242011-11-04 Eli Zaretskii <eliz@gnu.org>
1225
1226 * xdisp.c (note_mouse_highlight): If either of
1227 previous/next-single-property-change returns nil, treat that as
1228 the beginning or the end of the buffer. (Bug#9955)
1229
fe0b6370
JD
12302011-11-04 Jan Djärv <jan.h.d@swipnet.se>
1231
a58c13ed 1232 * gtkutil.c (xg_make_tool_item): Add callbacks if one of wimage or
fe0b6370
JD
1233 label is not null (Bug#9951).
1234 (xg_tool_item_stale_p): Handle the fact that wimage and/or wlbl
1235 may be NULL.
1236
89bd5ee1
EZ
12372011-11-04 Eli Zaretskii <eliz@gnu.org>
1238
1239 * window.c (Fwindow_body_size): Mention in the doc string that the
1240 return value is in frame's canonical units. (Bug#9949)
1241
84c3edb9
EZ
12422011-11-03 Eli Zaretskii <eliz@gnu.org>
1243
4e2fb5c7
EZ
1244 * xdisp.c (note_mouse_highlight): Initialize `area'. (Bug#9947)
1245
84c3edb9 1246 * w32fns.c (unwind_create_frame): If needed, free the glyph
3ab15fd6 1247 matrices of the partially constructed frame. (Bug#9943)
2a58bbc1 1248 * xfns.c (unwind_create_frame): Likewise.
84c3edb9 1249
bc17a887
EZ
12502011-11-01 Eli Zaretskii <eliz@gnu.org>
1251
1252 * xdisp.c (mouse_face_from_buffer_pos): Fix a typo in a comment.
1253 Don't stop backward scan on the continuation glyph, even though
1254 its CHARPOS is positive.
6d5eb5b0
SM
1255 (mouse_face_from_buffer_pos, note_mouse_highlight):
1256 Rename cover_string to disp_string.
bc17a887 1257
4ee88440
MR
12582011-11-01 Martin Rudalics <rudalics@gmx.at>
1259
1260 * window.c (temp_output_buffer_show): Don't use
1261 Vtemp_buffer_show_specifiers.
1262 (Vtemp_buffer_show_specifiers): Remove unused variable.
1263
c2ff3c02
EZ
12642011-10-30 Eli Zaretskii <eliz@gnu.org>
1265
1266 * xdisp.c (try_cursor_movement): Make sure ROW isn't decremented
1267 past the beginning of the current glyph matrix.
1268
58179cce 12692011-10-30 Adam Sjøgren <asjo@koldfront.dk> (tiny change)
6e56383b
JD
1270
1271 * xterm.c: Include X11/Xproto.h if HAVE_GTK3.
1272 (x_error_handler): Ignore BadMatch for X_SetInputFocus for
1273 HAVE_GTK3 (Bug#9869).
b77a6a7f 1274
3b574623
JD
1275 * gtkutil.c (xg_win_to_widget, xg_event_is_for_menubar): Initialize
1276 type to GDK_NOTHING so valgrind does not complain (Bug#9901).
1277
b77a6a7f
JD
1278 * xterm.h (x_display_info): Add Xatom_net_wm_state_hidden (Bug#9893).
1279
1280 * xterm.c: Declare x_handle_net_wm_state to return int.
1281 (handle_one_xevent): Check if we are iconified but don't have
1282 _NET_WM_STATE_HIDDEN. If do, treat as deiconify (Bug#9893).
1283 (get_current_wm_state): Return non-zero if not hidden,
1284 check for _NET_WM_STATE_HIDDEN (Bug#9893).
1285 (do_ewmh_fullscreen): Ignore return value from get_current_wm_state.
1286 (x_handle_net_wm_state): Return what get_current_wm_state returns.
1287 (x_term_init): Initialize dpyinfo->Xatom_net_wm_state_hidden.
1288
196e41e4
PE
12892011-10-29 Paul Eggert <eggert@cs.ucla.edu>
1290
1291 * alloc.c (which_symbols): Declare EXTERNALLY_VISIBLE,
1292 so that this new function doesn't get optimized away by a
1293 whole-program optimizer. Make the 2nd arg EMACS_INT, not int.
1294
021f2e1a
AS
12952011-10-29 Andreas Schwab <schwab@linux-m68k.org>
1296
1297 * frame.h (MOUSE_HL_INFO): Remove excess parens.
1298
8b058d44
EZ
12992011-10-29 Eli Zaretskii <eliz@gnu.org>
1300
1301 Fix the `xbytecode' command.
1302 * .gdbinit (xprintbytestr): New command.
b50a28de 1303 (xwhichsymbols): Rename from `which'; all callers changed.
8b058d44
EZ
1304 (xbytecode): Print the byte-code string as well.
1305
4452fb80
EZ
13062011-10-29 Kim Storm <storm@cua.dk>
1307
8b058d44
EZ
1308 * alloc.c (which_symbols): New function.
1309
21b72067
AS
13102011-10-29 Andreas Schwab <schwab@linux-m68k.org>
1311
1312 * minibuf.c (read_minibuf_noninteractive): Allow reading empty
1313 line. (Bug#9903)
1314
83ed7b5c
GM
13152011-10-29 Glenn Morris <rgm@gnu.org>
1316
1317 * process.c (wait_reading_process_output): Revert 2009-08-30 change.
1318 Not clear what it was for, and it causes various bugs. (Bug#9839)
1319
5a7a728b
EZ
13202011-10-28 Eli Zaretskii <eliz@gnu.org>
1321
1322 * xdisp.c (note_mouse_highlight): Initialize `part', to avoid a
1323 possible random value that matches one of those tested as
1324 condition to clear the mouse face.
1325
d3d0842f
CY
13262011-10-28 Chong Yidong <cyd@gnu.org>
1327
1328 * xdisp.c (note_mouse_highlight): Fix use of uninitialized var.
1329
31b39d13
DN
13302011-10-28 Dan Nicolaescu <dann@ics.uci.edu>
1331
1332 * window.c (make_window): Initialize phys_cursor_on_p.
1333
9aba6043
SM
13342011-10-28 Stefan Monnier <monnier@iro.umontreal.ca>
1335
1336 * lisp.h (struct Lisp_Symbol): Update comments.
1337
c20992f4
JB
13382011-10-28 Juanma Barranquero <lekktu@gmail.com>
1339
1340 * w32font.c (w32_load_unicows_or_gdi32): Add missing return.
1341
db4f02f2
EZ
13422011-10-28 Eli Zaretskii <eliz@gnu.org>
1343
1344 Fix Emacs on Windows 9X (bug#8562). Thanks to oslsachem
1345 <oslsachem@gmail.com> for helping to debug this.
1346
1347 * w32font.c (g_b_init_is_w9x, g_b_init_get_outline_metrics_w)
1348 (g_b_init_get_text_metrics_w, g_b_init_get_glyph_outline_w)
1349 (g_b_init_get_glyph_outline_w): New static variables.
1350 (GetOutlineTextMetricsW_Proc, GetTextMetricsW_Proc)
1351 (GetGlyphOutlineW_Proc): New typedefs.
1352 (w32_load_unicows_or_gdi32, get_outline_metrics_w)
9aba6043
SM
1353 (get_text_metrics_w, get_glyph_outline_w, globals_of_w32font):
1354 New functions.
1355 (w32font_open_internal, compute_metrics):
1356 Call get_outline_metrics_w, get_text_metrics_w, and get_glyph_outline_w
db4f02f2
EZ
1357 instead of calling the "wide" APIs directly.
1358
1359 * emacs.c (main) [HAVE_NTGUI]: Call globals_of_w32font.
1360
1361 * w32.h (syms_of_w32font): Add prototype.
1362
87e68db4
JB
13632011-10-27 Juanma Barranquero <lekktu@gmail.com>
1364
1365 * window.c (Fframe_root_window, Fframe_first_window, Fwindow_end)
1366 (Fframe_selected_window, Ftemp_output_buffer_show, Fnext_window)
1367 (Fdelete_window_internal, Fwindow_parameters): Fix typos in docstrings.
1368 (Fmove_to_window_line): Doc fix.
1369
435c1d67
CY
13702011-10-27 Chong Yidong <cyd@gnu.org>
1371
1372 * process.c (make_process): Set gnutls_state to NULL.
1373
1374 * gnutls.c (emacs_gnutls_deinit): Deinit the gnutls_state if it is
1375 non-NULL, regardless of GNUTLS_INITSTAGE.
1376 (Fgnutls_boot): Cleanups. Call emacs_gnutls_deinit if we signal
1377 an error. Set process slots as soon as we allocate them.
1378
1379 * gnutls.h (GNUTLS_LOG, GNUTLS_LOG2): Fix macros.
1380
9c6c6f49
CY
13812011-10-27 Chong Yidong <cyd@gnu.org>
1382
9aba6043
SM
1383 * gnutls.c (emacs_gnutls_deinit): New function.
1384 Deallocate credentials structures as well as calling gnutls_deinit.
9c6c6f49
CY
1385 (Fgnutls_deinit, Fgnutls_boot): Use it.
1386
1387 * process.c (make_process): Initialize GnuTLS credentials to NULL.
1388 (deactivate_process): Call emacs_gnutls_deinit.
1389
657d08d3
JB
13902011-10-27 Juanma Barranquero <lekktu@gmail.com>
1391
1392 * image.c (x_create_x_image_and_pixmap):
1393 * w32.c (sys_rename, w32_delayed_load):
1394 * w32font.c (fill_in_logfont):
1395 * w32reg.c (x_get_string_resource): Silence compiler warnings.
1396
5430d399
JB
13972011-10-26 Juanma Barranquero <lekktu@gmail.com>
1398
1399 * w32fns.c (w32_default_color_map): New function,
1400 extracted from Fw32_default_color_map.
a7ef684b 1401 (Fw32_default_color_map, Fx_open_connection): Use it. (Bug#9785)
5430d399 1402
fe0055fa
PE
14032011-10-25 Paul Eggert <eggert@cs.ucla.edu>
1404
1405 * dispextern.h (Fcontrolling_tty_p): New decl (Bug#6649 part 2).
1406
e6346438
SM
14072011-10-25 Stefan Monnier <monnier@iro.umontreal.ca>
1408
1409 * keyboard.c (test_undefined): New function (bug#9751).
1410 (read_key_sequence): Use it to detect when a key is bound to `undefined'.
1411
e112cc37
ET
14122011-10-25 Enami Tsugutomo <tsugutomo.enami@jp.sony.com>
1413
1414 * sysdep.c (init_sys_modes): Fix the check for the controlling
1415 terminal (Bug#6649).
1416
7b5d6677
EZ
14172011-10-20 Eli Zaretskii <eliz@gnu.org>
1418
1419 * dispextern.h (struct bidi_it): New member next_en_type.
1420
1421 * bidi.c (bidi_line_init): Initialize the next_en_type member.
1422 (bidi_resolve_explicit_1): When next_en_pos is valid for the
1423 current character, check also for next_en_type being WEAK_EN.
1424 (bidi_resolve_weak): Don't enter the expensive loop if the current
1425 position is before next_en_pos. Record the bidi type of the first
1426 non-ET, non-BN character we find, in addition to its position.
1427 (bidi_level_of_next_char): Invalidate next_en_type when
1428 next_en_pos is over-stepped.
1429
7da0b018
PE
14302011-10-20 Paul Eggert <eggert@cs.ucla.edu>
1431
1432 Time zone name fixes for non-ASCII locales (Bug#641, Bug#9794)
1433 * editfns.c: Rewrite current-time-zone so that it invokes
1434 the equivalent of (format-time-string "%Z") to get the time zone name.
1435 This fixes a bug when the time zone name contains characters that
1436 need converting from the system time locale to Emacs internal format.
1437 This fixes a shortcoming that I introduced in my 1999-10-19 patch:
1438 that patch fixed format-time-string to do the conversion, but
1439 I forgot to fix current-time-zone.
1440 (format_time_string): New function, containing most of
1441 what Fformat_time_string used to contain.
1442 (Fformat_time_string): Rewrite in terms of format_time_string.
1443 This doesn't change this function's behavior.
1444 (current-time-zone): Rewrite to use format_time_string.
1445 This fixes the bug reported by Michael Schierl in
1446 <http://lists.gnu.org/archive/html/emacs-devel/2007-06/msg00334.html>.
1447 Jason Rumney's 2007-06-07 change worked around this bug, but
1448 didn't fix it.
1449 * systime.h (tzname, timezone): Remove no-longer-used declarations.
1450
8547b010
EZ
14512011-10-19 Eli Zaretskii <eliz@gnu.org>
1452
1453 * xdisp.c (start_display): If the character at POS is displayed
1454 via a display vector, reset IT->current.dpvec_index to zero.
12b32963
EZ
1455 (try_window_reusing_current_matrix): If a line ends in a display
1456 vector or the next line starts in a display vector, continue
1457 redrawing the window even though the character position of
1458 start_row was reached.
8547b010
EZ
1459 (Bug#9771, part 2)
1460
4e948d15
CY
14612011-10-18 Chong Yidong <cyd@gnu.org>
1462
1463 * xdisp.c (get_next_display_element): Handle U+2010 and U+2011
1464 with nobreak-char-display too.
1465
4787455f
EZ
14662011-10-18 Eli Zaretskii <eliz@gnu.org>
1467
1468 Fix part 3 of bug#9771.
1469 * bidi.c (bidi_line_init): Initialize next_en_pos to zero, not -1.
1470 (bidi_resolve_neutral): Don't enter the expensive loop looking for
1471 non-neutral characters if the current character is a paragraph
1472 separator (a.k.a. Newline). This avoids running the same
1473 expensive loop twice, once when we consume the preceding newline
1474 and the other time when the line actually needs to be displayed.
1475 Avoid the loop when we see neutrals on the base embedding level
1476 following a character whose directionality is the same as the
1477 paragraph's. This avoids running the expensive loop when a line
1478 ends in a long sequence of neutrals, like control characters.
1479 Add assertion against STRONG_AL type. Slightly rearrange code
1480 that determines the type of a neutral given the first non-neutral
1481 that follows it.
1482 (bidi_level_of_next_char): Set next_en_pos to zero when
1483 invalidating its info.
1484
2c91f553
EZ
14852011-10-17 Eli Zaretskii <eliz@gnu.org>
1486
1487 * xdisp.c (push_display_prop): Determine whether to record string
1488 or buffer position by IT->string, not by IT->method. Allow
1489 GET_FROM_DISPLAY_VECTOR as IT->method on entry. (Bug#9771, part 4)
f2ff9e88
EZ
1490 (move_it_vertically_backward): Don't look for character position
1491 immediately after the newline when in a continuation line.
1492 (Bug#9771, part 1)
2c91f553 1493
c7b08b0d
MR
14942011-10-15 Martin Rudalics <rudalics@gmx.at>
1495
1496 * window.c (coordinates_in_window): Rewrite and delabelize
1497 vertical border check. (Bug#5357) (Bug#9618)
1498
6b02f655
SM
14992011-10-14 Stefan Monnier <monnier@iro.umontreal.ca>
1500
1501 * xterm.c (frame_highlight, frame_unhighlight): Ignore unexplained
1502 errors in XSetWindowBorder (bug#9310).
1503
81d40c92
DA
15042011-10-13 Dmitry Antipov <dmantipov@yandex.ru>
1505
1506 * editfns.c (Fset_time_zone_rule): Replace free with xfree to
1507 avoid crash when xmalloc overrun checking is enabled.
1508
d4172c3b
EZ
15092011-10-13 Eli Zaretskii <eliz@gnu.org>
1510
1511 * xdisp.c (Fcurrent_bidi_paragraph_direction): Initialize
1512 itb.paragraph_dir to NEUTRAL_DIR. Fixes an occasional incorrect
1513 cursor motion with <left> and <right> arrow keys.
1514
1515 * bidi.c (bidi_init_it): Don't initialize paragraph_dir here, as
1516 some callers set that themselves.
1517
b00eea75
EZ
15182011-10-12 Eli Zaretskii <eliz@gnu.org>
1519
1520 * xdisp.c (find_row_edges): Handle the case where ROW comes from a
1521 display string and the previous row comes from the same string and
1522 is empty. (Bug#9739) (Bug#9738)
1523
8fe012c4
SM
15242011-10-12 Stefan Monnier <monnier@iro.umontreal.ca>
1525
1526 * doc.c (get_doc_string): Encode file name (bug#9735).
1527
0074aef2
EZ
15282011-10-12 Eli Zaretskii <eliz@gnu.org>
1529
79beb178
EZ
1530 * bidi.c (bidi_level_of_next_char):
1531 * xdisp.c (get_visually_first_element): Remove old incorrect
1532 comments regarding the Unicode Line Separator character.
1533
0074aef2
EZ
1534 * bidi.c (bidi_init_it): Initialize paragraph_dir to NEUTRAL_DIR.
1535
6e4b3fbe
DA
15362011-10-12 Dmitry Antipov <dmantipov@yandex.ru>
1537
1538 * alloc.c (Fgc_status): Do not access beyond zombies array
1539 boundary if nzombies > MAX_ZOMBIES.
1540 * alloc.c (dump_zombies): Add missing format specifier.
1541
0324f3af
PE
15422011-10-12 Paul Eggert <eggert@cs.ucla.edu>
1543
b5525cac
PE
1544 * xdisp.c (set_cursor_from_row): Simplify conditionals,
1545 to pacify GCC 4.6.1 x86-64 with -O2 -Wstrict-overflow.
1546
0324f3af
PE
1547 * lread.c (read_escape): Allow hex escapes as large as ?\xfffffff.
1548 Some packages use them to denote characters with modifiers.
1549
e9b5f888
AS
15502011-10-11 Andreas Schwab <schwab@linux-m68k.org>
1551
1552 * lisp.h (GCPRO1_VAR, GCPRO2_VAR, GCPRO3_VAR, GCPRO4_VAR)
1553 (GCPRO5_VAR, GCPRO6_VAR, UNGCPRO_VAR): Add whitespace to avoid
1554 matching a pp-number. Rename parameter var to var1.
1555
127827c0
SM
15562011-10-11 Stefan Monnier <monnier@iro.umontreal.ca>
1557
1558 * minibuf.c (Finternal_complete_buffer): Fix last change (bug#9709).
1559
c8fd3bd0
GM
15602011-10-08 Glenn Morris <rgm@gnu.org>
1561
1562 * callint.c (Fcall_interactively): Give a more explicit error for the
1563 'c' case with a non-character input. (Bug#8479)
1564
352ec8ff
EZ
15652011-10-08 Eli Zaretskii <eliz@gnu.org>
1566
03669ccb
EZ
1567 * xdisp.c (hscroll_window_tree): Support hscroll in right-to-left
1568 lines.
7061c986
EZ
1569 (set_cursor_from_row): Fix cursor positioning in mixed L2R+R2L
1570 lines that are hscrolled on the left.
03669ccb 1571
352ec8ff
EZ
1572 * dispnew.c (buffer_posn_from_coords): Account for a possible
1573 presence of header-line. (Bug#4426)
1574
a66cfb1c
SM
15752011-10-07 Stefan Monnier <monnier@iro.umontreal.ca>
1576
6b02f655
SM
1577 * buffer.c (syms_of_buffer) <enable-multibyte-characters>:
1578 Don't advertise functionality which we discourage or doesn't work.
a66cfb1c 1579
7c5ee88e
PE
15802011-10-07 Paul Eggert <eggert@cs.ucla.edu>
1581
1582 * alloc.c (GC_LISP_OBJECT_ALIGNMENT): Use offsetof, not __alignof__
1583 or sizeof. __alignof__ gives the wrong answer on Fedora x86-64
1584 with GCC 4.6.1 when configured with CC='gcc -m32' --with-wide-int;
1585 this makes Emacs dump core during garbage collection on rare
1586 occasions. sizeof is obviously inferior to offsetof here, so
1587 stick with offsetof.
1588 (GC_POINTER_ALIGNMENT): New macro.
1589 (mark_memory): Omit 3rd (offset) arg; caller changed.
1590 Don't assume EMACS_INT alignment is the same as pointer alignment.
1591
df1bbe5b
SM
15922011-10-03 Stefan Monnier <monnier@iro.umontreal.ca>
1593
1594 * keyboard.c (read_key_sequence_remapped): New var.
1595 (read_key_sequence): Compute remapping in the right buffer.
1596 (command_loop_1): Use read_key_sequence's remapping directly.
1597
51553db6
SM
15982011-10-02 Stefan Monnier <monnier@iro.umontreal.ca>
1599
32c1fffd
SM
1600 * dired.c (file_name_completion): Don't expand file name.
1601 (Ffile_name_completion, Ffile_name_all_completions): Expand file name
1602 before checking file name handler.
1603
51553db6
SM
1604 * minibuf.c (Finternal_complete_buffer): Only show internal buffers if
1605 they've been requested explicitly (bug#9591).
1606
b6bd1599 16072011-10-01 Andreas Schwab <schwab@linux-m68k.org>
fa2ec41f
AS
1608
1609 * keymap.c (Fsingle_key_description): Use make_specified_string
1610 instead of build_string to build string from push_key_description.
1611 (Bug#5193)
1612
f701dc2a
PE
16132011-09-30 Paul Eggert <eggert@cs.ucla.edu>
1614
4222c55d
PE
1615 * buffer.h (struct buffer): Use time_t, not int, for a time stamp.
1616 This fixes a Y2038 bug on 64-bit hosts.
1617 * buffer.c (reset_buffer):
1618 * fileio.c (Fdo_auto_save, Fset_buffer_auto_saved)
1619 (Fclear_buffer_auto_save_failure):
1620 Use 0, not -1, to represent an unset failure time, since time_t
1621 might not be signed.
1622
f701dc2a
PE
1623 Remove dependency on glibc malloc internals.
1624 * alloc.c (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
1625 Move back here from lisp.h, but with their new implementations.
1626 (XMALLOC_BASE_ALIGNMENT, COMMON_MULTIPLE, XMALLOC_HEADER_ALIGNMENT)
1627 (XMALLOC_OVERRUN_SIZE_SIZE): Move these new lisp.h macros here.
1628 * charset.c (charset_table_init): New static var.
1629 (syms_of_charset): Use it instead of xmalloc. This removes a
1630 dependency on glibc malloc internals. See Eli Zaretskii's comment in
1631 <http://lists.gnu.org/archive/html/emacs-devel/2011-09/msg00815.html>.
1632 * lisp.h (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
1633 Move back to alloc.c.
1634 (XMALLOC_BASE_ALIGNMENT, COMMON_MULTIPLE, XMALLOC_HEADER_ALIGNMENT)
1635 (XMALLOC_OVERRUN_SIZE_SIZE): Move to alloc.c.
1636
9ceebf39
JD
16372011-09-30 Jan Djärv <jan.h.d@swipnet.se>
1638
1639 * nsterm.m (windowDidResize): Call x_set_window_size only when
1640 ns_in_resize is true. Otherwise set pixelwidth/height and
1641 call change_frame_size (Bug#9628).
1642
cb993c58
PE
16432011-09-30 Paul Eggert <eggert@cs.ucla.edu>
1644
3930c88b
PE
1645 Port --enable-checking=all to Fedora 14 x86-64.
1646 * charset.c (syms_of_charset): Also account for glibc malloc's
1647 internal overhead when calculating the initial malloc maximum.
1648
cb993c58
PE
1649 Port --enable-checking=all to Fedora 14 x86.
1650 * alloc.c (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
1651 Move to lisp.h.
1652 (xmalloc_put_size, xmalloc_get_size, overrun_check_malloc)
1653 (overrun_check_realloc, overrun_check_free):
1654 Use XMALLOC_OVERRUN_SIZE_SIZE, not sizeof (size_t).
1655 That way, xmalloc returns a properly-aligned pointer even if
1656 XMALLOC_OVERRUN_CHECK is defined. The old debugging code happened
1657 to align OK on typical 64-bit hosts, but not on Fedora 14 x86.
1658 * charset.c (syms_of_charset): Take XMALLOC_OVERRUN_CHECK_OVERHEAD
1659 into account when calculating the initial malloc maximum.
1660 * lisp.h (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
1661 Move here from alloc.c, so that charset.c can use it too.
1662 Properly align; the old code wasn't right for common 32-bit hosts
1663 when configured with --enable-checking=all.
1664 (XMALLOC_BASE_ALIGNMENT, COMMON_MULTIPLE, XMALLOC_HEADER_ALIGNMENT)
1665 (XMALLOC_OVERRUN_SIZE_SIZE): New macros.
1666
31bed486
EZ
16672011-09-29 Eli Zaretskii <eliz@gnu.org>
1668
04c70788 1669 * sysdep.c (snprintf) [!EOVERFLOW]: If EOVERFLOW is not defined,
31bed486
EZ
1670 use EDOM.
1671
fbcaa2f3
EZ
16722011-09-28 Eli Zaretskii <eliz@gnu.org>
1673
1674 * xdisp.c (compute_display_string_end): If there's no display
1675 string at CHARPOS, return -1.
1676
1677 * bidi.c (bidi_fetch_char): When compute_display_string_end
1678 returns a negative value, treat the character as a normal
1679 character not covered by a display string. (Bug#9624)
1680
a239d4e9
JB
16812011-09-28 Juanma Barranquero <lekktu@gmail.com>
1682
1683 * lread.c (Fread_from_string): Fix typo in docstring.
1684
88652fd5
EZ
16852011-09-27 Eli Zaretskii <eliz@gnu.org>
1686
1687 * xdisp.c (handle_invisible_prop): If invisible text ends on a
1688 newline, reseat the iterator instead of bidi-iterating there one
1689 character at a time. (Bug#9610)
32c1fffd
SM
1690 (BUFFER_POS_REACHED_P, move_it_in_display_line_to): Bail when past
1691 TO_CHARPOS if the bidi iterator is at base embedding level.
88652fd5 1692
ed497dd4
AS
16932011-09-27 Andreas Schwab <schwab@linux-m68k.org>
1694
1695 * lread.c (readevalloop): Use correct code for NBSP.
1696 (read1): Likewise. (Bug#9608)
1697
b2bf61aa
MA
16982011-09-25 Michael Albinus <michael.albinus@gmx.de>
1699
1700 * dbusbind.c (Fdbus_register_signal): When service is not
1701 registered, use nil in Vdbus_registered_objects_table. (Bug#9581)
1702
32bbb17c
GM
17032011-09-25 Glenn Morris <rgm@gnu.org>
1704
1705 * buffer.c (truncate-lines): Doc fix.
1706
94e0933e
CY
17072011-09-24 Chong Yidong <cyd@stupidchicken.com>
1708
1709 * window.c (Fwindow_prev_buffers, Fset_window_prev_buffers)
1710 (Fset_window_next_buffers): Doc fix.
1711
cddde921
GM
17122011-09-24 Glenn Morris <rgm@gnu.org>
1713
1714 * minibuf.c (read_minibuf): Disable line truncation. (Bug#5715)
1715
1260aef1
PE
17162011-09-24 Paul Eggert <eggert@cs.ucla.edu>
1717
25b4bfa0
PE
1718 Fix minor problems found by static checking.
1719 * xdisp.c (string_from_display_spec): Don't assume vecsize fits in int.
1260aef1
PE
1720 * indent.c (Fvertical_motion): Fix == vs = typo.
1721
e3cbd34b
EZ
17222011-09-24 Eli Zaretskii <eliz@gnu.org>
1723
a66cfb1c
SM
1724 * dispnew.c (syms_of_display) <redisplay-dont-pause>:
1725 Default value is now t. Doc fix.
6bf7006f 1726
e3cbd34b 1727 * indent.c (Fvertical_motion): Compute and apply the overshoot
32c1fffd 1728 logic when moving up, not only when moving down. Fix the
e3cbd34b 1729 confusing name and values of the it_overshoot_expected variable;
32c1fffd 1730 logic changes accordingly. (Bug#9254) (Bug#9549)
e3cbd34b
EZ
1731
1732 * xdisp.c (pos_visible_p): Produce correct pixel coordinates when
1733 CHARPOS is covered by a display string which includes newlines.
1734 (move_it_vertically_backward): Avoid inflooping when START_CHARPOS
1735 is covered by a display string with embedded newlines.
1736
a3de0cbd
MA
17372011-09-24 Michael Albinus <michael.albinus@gmx.de>
1738
1739 * dbusbind.c (Fdbus_register_signal): Add match rule to
1740 Vdbus_registered_objects_table. (Bug#9581)
a66cfb1c
SM
1741 (Fdbus_register_method, Vdbus_registered_objects_table):
1742 Fix docstring.
a3de0cbd 1743
b260039d
JM
17442011-09-24 Jim Meyering <meyering@redhat.com>
1745
32c1fffd 1746 do not ignore write error for any output size
b260039d
JM
1747 The previous change was incomplete.
1748 While it makes emacs --batch detect the vast majority of stdout
1749 write failures, errors were still ignored whenever the output size is
1750 k * (BUFSIZ+1) - 4. E.g., on a system with BUFSIZ of 4096,
1751 $ emacs --batch --eval '(print (format "%4093d" 0))' > /dev/full \
1752 && echo FAIL: ignored write error
1753 FAIL: ignored write error
1754 $ emacs --batch --eval '(print (format "%20481d" 0))' > /dev/full \
1755 && echo FAIL: ignored write error
1756 FAIL: ignored write error
1757 * emacs.c (Fkill_emacs): Also test ferror. (Bug#9574)
1758
8eca8a7c
AS
17592011-09-23 Andreas Schwab <schwab@linux-m68k.org>
1760
1761 * emacs.c (Fkill_emacs): In noninteractive mode exit
1762 non-successfully if a write error occurred on stdout. (Bug#9574)
1763
3341db62
EZ
17642011-09-21 Eli Zaretskii <eliz@gnu.org>
1765
1766 * xdisp.c (pop_it): Allow it->object that is a cons cell to pass
1767 the xassert test.
1768
1769 * dispextern.h (struct it): Update the comment documenting what
1770 can it->OBJECT be.
1771
8c203dbf
EZ
17722011-09-20 Eli Zaretskii <eliz@gnu.org>
1773
1774 * xdisp.c (set_cursor_from_row): If the row ends in a newline from
1775 a display string, extend search for cursor position to end of row.
1776 (find_row_edges): If the row ends in a newline from a display
1777 string, increment its MATRIX_ROW_END_CHARPOS by one. (Bug#9549)
1778 Handle the case of a display string with multiple newlines.
fd317ddf
EZ
1779 (Fcurrent_bidi_paragraph_direction): Fix search for previous
1780 non-empty line. Fixes confusing cursor motion with arrow keys at
1781 the beginning of a line that starts with whitespace.
8c203dbf 1782
a4824228
LMI
17832011-09-19 Lars Magne Ingebrigtsen <larsi@gnus.org>
1784
1785 * lread.c (Fread_from_string): Document what FINAL-STRING-INDEX is
1786 (bug#9493).
1787
33ed493b
CY
17882011-09-18 Chong Yidong <cyd@stupidchicken.com>
1789
1790 * xfns.c (Fx_create_frame): Handle the bitmapIcon resource as
1791 boolean (Bug#9154).
1792
56cd55c8
EZ
17932011-09-18 Eli Zaretskii <eliz@gnu.org>
1794
1795 * xdisp.c (display_line): Record maximum and minimum buffer
1796 positions even if no glyphs were produced (e.g., by a zero-width
1797 stretch). Fixes bug#9530 on a TTY. Under word-wrap, don't record
1798 buffer positions that will be removed from the glyph row because
1799 they don't fit.
c02dcedf
EZ
1800 (produce_stretch_glyph): Fix a bug in :align-to on a TTY when the
1801 column is beyond frame width: don't subtract 1 "pixel" when
1802 computing width of the stretch.
3e62b7e0
EZ
1803 (reseat_at_next_visible_line_start): Undo the change made on
1804 2011-09-17 that saved paragraph information and restored it after
1805 the call to `reseat'. (Bug#9545)
56cd55c8 1806
5ed99d36 18072011-09-18 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
3390454c
YM
1808
1809 * xdisp.c (expose_window): Save original value of phys_cursor_on_p
1810 and turn window cursor on if cleared (Bug#9415).
1811
5ed99d36 18122011-09-18 Andreas Schwab <schwab@linux-m68k.org>
edb7b4dc
AS
1813
1814 * search.c (boyer_moore): Take unibyte characters from pattern
1815 literally. (Bug#9458)
1816
9bade7b2
EZ
18172011-09-18 Eli Zaretskii <eliz@gnu.org>
1818
1819 * xdisp.c (reseat_at_next_visible_line_start): Fix last change.
1820
e5e9d610
PE
18212011-09-18 Paul Eggert <eggert@cs.ucla.edu>
1822
87e4427a
PE
1823 Fix minor problem found by static checking.
1824 * xdisp.c (reseat_at_next_visible_line_start): Mark locals as
1825 initialized, to pacify gcc -Wuninitialized.
1826
e5e9d610
PE
1827 * fileio.c: Report proper errno when syscall falls.
1828 (Finsert_file_contents): Save and restore errno,
1829 so that report_file_error outputs the correct diagnostic.
1830 (Fwrite_region) [CLASH_DETECTION]: Likewise.
1831
a1674f0b
EZ
18322011-09-18 Eli Zaretskii <eliz@gnu.org>
1833
1834 * .gdbinit (pgx): Fix references to fields of `struct glyph'.
1835
fbfb6dd4
EZ
18362011-09-17 Eli Zaretskii <eliz@gnu.org>
1837
1838 * xdisp.c (produce_stretch_glyph): Another fix for changes made on
1839 2011-08-30T17:32:44Z!eliz@gnu.org. (Bug#9530)
1840
bb187662
EZ
18412011-09-17 Eli Zaretskii <eliz@gnu.org>
1842
1137e8b8 1843 * xdisp.c (reseat_at_next_visible_line_start): Keep information
6b02f655 1844 about the current paragraph and restore it after the call to reseat.
1137e8b8
EZ
1845
1846 * bidi.c (MAX_PARAGRAPH_SEARCH): New macro.
1847 (bidi_find_paragraph_start): Search back for paragraph beginning
1848 at most MAX_PARAGRAPH_SEARCH lines; if not found, return BEGV_BYTE.
1849 (bidi_move_to_visually_next): Only trigger paragraph-related
1850 computations when the last character is a newline or at EOB, not
1851 just any NEUTRAL_B. (Bug#9470)
1852
bb187662
EZ
1853 * xdisp.c (set_cursor_from_row): Don't invoke special treatment of
1854 truncated lines if point is covered by a display string. (Bug#9524)
1855
2e621251
PE
18562011-09-16 Paul Eggert <eggert@cs.ucla.edu>
1857
1858 * xselect.c: Relax test for outgoing X longs (Bug#9498).
1859 (cons_to_x_long): New function.
1860 (lisp_data_to_selection_data): Use it. Correct the test for
1861 short-versus-long data; it was negated. Break out of vector
1862 loop, for efficiency, when a long datum is discovered.
1863
91a15bc6
SM
18642011-09-16 Stefan Monnier <monnier@iro.umontreal.ca>
1865
1866 * eval.c (Fquote): Document its non-consing behavior (bug#9482).
1867
b41c3a35
EZ
18682011-09-16 Eli Zaretskii <eliz@gnu.org>
1869
1870 * image.c (tiff_handler): Work around a bug in MinGW GCC 3.x (see
1871 GCC PR/17406) by declaring this function with external scope.
1872
7812ba2d
PE
18732011-09-15 Paul Eggert <eggert@cs.ucla.edu>
1874
1875 * editfns.c (Fformat): Fix bug in text-property fix (Bug#9514).
1876 Don't mishandle (length (format "%%")) and (format "%4000s%%" "").
1877
cf7edc2a
AS
18782011-09-15 Andreas Schwab <schwab@linux-m68k.org>
1879
1880 * editfns.c (Fformat): Correctly handle text properties on "%%".
1881
bd01620e
EZ
18822011-09-15 Eli Zaretskii <eliz@gnu.org>
1883
1884 * xterm.c (x_draw_composite_glyph_string_foreground):
1885 * w32term.c (x_draw_composite_glyph_string_foreground):
1886 * term.c (encode_terminal_code):
1887 * composite.c (composition_update_it, get_composition_id):
1888 * xdisp.c (get_next_display_element)
1889 (fill_composite_glyph_string): Add comments about special meaning
1890 of TAB characters in a composition.
1891
a02719a3
PE
18922011-09-15 Paul Eggert <eggert@cs.ucla.edu>
1893
1894 * editfns.c (Fformat): Fix off-by-1 bug for "%%b" (Bug#9514).
4c122725
PE
1895 This occurs when processing a multibyte format.
1896 Problem reported by Wolfgang Jenker.
a02719a3 1897
72589a3c
JB
18982011-09-15 Johan Bockgård <bojohan@gnu.org>
1899
1900 * xdisp.c (try_cursor_movement): Only check for exact match if
1901 cursor hpos found by set_cursor_from_row is valid. (Bug#9495)
1902
1c14176c
PE
19032011-09-14 Paul Eggert <eggert@cs.ucla.edu>
1904
1905 Remove unused external symbols.
1906 * dispextern.h (calc_pixel_width_or_height): Remove decl.
1907 * xdisp.c (calc_pixel_width_or_height): Now static.
1908 * doprnt.c (exprintf) [! (HAVE_X_WINDOWS && USE_X_TOOLKIT)]: Remove.
1909 * indent.c (check_display_width):
1910 * w32term.c: Fix comment to match code.
1911 * xterm.c, xterm.h (x_catching_errors): Remove.
1912
d2eea5b5
PE
19132011-09-14 Paul Eggert <eggert@cs.ucla.edu>
1914
1915 * xselect.c: Use signed conversions more consistently (Bug#9498).
1916 (selection_data_to_lisp_data): Assume incoming selection data are
1917 signed integers, not unsigned. This is to be consistent with
1918 outgoing selection data, which was modified to use signed integers
1919 in as part of the fix to Bug#9196 in response to Jan D.'s comment
1920 in <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=9196#32> that X11
1921 expects long, not unsigned long.
1922
46888499
EZ
19232011-09-14 Eli Zaretskii <eliz@gnu.org>
1924
1925 * xdisp.c (try_window_reusing_current_matrix): Fix incorrect
1926 computation of loop end. Reported by Johan Bockgård
1927 <bojohan@gnu.org>.
1928
ef8ef9fb
CY
19292011-09-13 Chong Yidong <cyd@stupidchicken.com>
1930
1931 * frame.c (Fother_visible_frames_p): Function deleted.
1932
fa819fed
EZ
19332011-09-12 Eli Zaretskii <eliz@gnu.org>
1934
1935 * indent.c (compute_motion): Process display vector front to back
1936 rather than the other way around. (Bug#2496)
1937
2ba8e008
SM
19382011-09-12 Stefan Monnier <monnier@iro.umontreal.ca>
1939
1940 * fileio.c (Finsert_file_contents): Don't assume beg_offset is 0.
1941
20f53c69
CY
19422011-09-11 Chong Yidong <cyd@stupidchicken.com>
1943
1944 * minibuf.c (Fread_from_minibuffer): Doc fix.
1945
d562d7a4
EZ
19462011-09-11 Eli Zaretskii <eliz@gnu.org>
1947
1948 * xdisp.c (produce_stretch_glyph): Fix a typo made in changes from
1949 2011-08-30T17:32:44Z!eliz@gnu.org. (Bug#9475)
1950
1c4d7f3d
LMI
19512011-09-11 Lars Magne Ingebrigtsen <larsi@gnus.org>
1952
1953 * fileio.c (Fvisited_file_modtime): Document `(-1 65535)' as a
1954 value for non-existent files.
1955
b885bf36
EZ
19562011-09-11 Eli Zaretskii <eliz@gnu.org>
1957
1958 * fileio.c (Finsert_file_contents): If the file cannot be opened,
1959 set its "size" to -1. This will set the modtime_size field of
1960 the corresponding buffer to -1, which is what
1961 verify-visited-file-modtime expects for files that do not exist.
1962 (Bug#9139)
1963
6612f0bf
PE
19642011-09-11 Paul Eggert <eggert@cs.ucla.edu>
1965
1966 * keymap.h (KEY_DESCRIPTION_SIZE, push_key_description): Move decls
1967 here ...
1968 * lisp.h: ... from here. push_key_description is no longer
1969 defined in keyboard.c, so its declaration should not be in
1970 lisp.h's "Defined in keyboard.c" section, and KEY_DESCRIPTION_SIZE
1971 logically belongs with push_key_description.
1972
dfb3f755
PE
19732011-09-10 Paul Eggert <eggert@cs.ucla.edu>
1974
1975 * buffer.h: Include <sys/types.h> instead of <time.h>.
1976 Otherwise, off_t wasn't defined on FreeBSD 9.0-BETA2 i386.
1977 Problem reported by Herbert J. Skuhra.
1978
3134906c
LMI
19792011-09-10 Lars Magne Ingebrigtsen <larsi@gnus.org>
1980
1981 * xml.c (parse_region): Make the parsing work for
1982 non-comment-starting XML files again (bug#9144).
1983
8d903f4e
AS
19842011-09-10 Andreas Schwab <schwab@linux-m68k.org>
1985
1986 * image.c (gif_load): Fix calculation of bottom and right corner.
1987 (Bug#9468)
1988
80ad64f4
EZ
19892011-09-10 Eli Zaretskii <eliz@gnu.org>
1990
1991 * xdisp.c (MAX_DISP_SCAN): Decrease to 250. Prevents sluggish
1992 redisplay in small windows.
1993
208a048d
EZ
19942011-09-09 Eli Zaretskii <eliz@gnu.org>
1995
1996 * frame.c (x_report_frame_params): Cast to avoid compiler warnings.
1997
9b1c252e
MR
19982011-09-08 Martin Rudalics <rudalics@gmx.at>
1999
2000 * window.c (Fset_window_prev_buffers, Fset_window_next_buffers):
2001 Operate on live windows only.
2002
2949f33b
JB
20032011-09-08 Juanma Barranquero <lekktu@gmail.com>
2004
2005 * emacs.c (my_heap_start): #ifdef to avoid warnings when unused.
2006
e08dcafd
EZ
20072011-09-07 Eli Zaretskii <eliz@gnu.org>
2008
2009 * xdisp.c (move_it_in_display_line_to): Call RESTORE_IT on ppos_it
2010 only under bidi iteration.
2011
115b96bd
JD
20122011-09-07 Jan Djärv <jan.h.d@swipnet.se>
2013
2014 * gtkutil.c (xg_make_tool_item): Insert comment about eventbox.
2015
c8199d0f
PE
20162011-09-06 Paul Eggert <eggert@cs.ucla.edu>
2017
2018 isnan: Fix porting problem to Solaris 10 with bundled gcc.
2019 Without this fix, the command to link temacs failed due to an
2020 undefined symbol __builtin_isnan. This is because
2021 /usr/include/iso/math_c99.h #defines isnan(x) to
2022 __builtin_isnan(x), but the bundled gcc, which identifies itself
2023 as gcc 3.4.3 (csl-sol210-3_4-branch+sol_rpath), does not have
2024 a __builtin_isnan.
2025 * floatfns.c (isnan): #undef, and then #define to a clone of
2026 what's in data.c.
2027 (Fisnan): Always define, since it's always available now.
2028 (syms_of_floatfns): Always define isnan at the Lisp level.
2029
e39b275c 20302011-09-06 Paul Eggert <eggert@cs.ucla.edu>
1c262cae
PE
2031
2032 * Makefile.in (gl-stamp): move-if-change now in build-aux (Bug#9169).
2033
b2db44d9 20342011-09-06 Paul Eggert <eggert@cs.ucla.edu>
728f8f0a 2035
f4af5137 2036 * fileio.c: Fix bugs with large file offsets (Bug#9428).
728f8f0a
PE
2037 The previous code assumed that file offsets (off_t values) fit in
2038 EMACS_INT variables, which is not true on typical 32-bit hosts.
2039 The code messed up by falsely reporting buffer overflow in cases
2040 such as (insert-file-contents "big" nil 1 2) into an empty buffer
2041 when "big" contains more than 2**29 bytes, even though this
2042 inserts just one byte and does not overflow the buffer.
2043 (Finsert_file_contents): Store file offsets as off_t
2044 values, not as EMACS_INT values. Check for overflow when
2045 converting between EMACS_INT and off_t. When checking for
2046 buffer overflow or for overlap, take the offsets into account.
2047 Don't use EMACS_INT for small values where int suffices.
2048 When checking for overlap, fix a typo: ZV was used where
2049 ZV_BYTE was intended.
2050 (Fwrite_region): Don't assume off_t fits into 'long'.
2051 * buffer.h (struct buffer.modtime_size): Now off_t, not EMACS_INT.
2052
ecfc0a49
MA
20532011-09-05 Michael Albinus <michael.albinus@gmx.de>
2054
2055 * dbusbind.c (xd_signature_cat): Rename from signature_cat.
2056
6511acf2 20572011-09-04 Paul Eggert <eggert@cs.ucla.edu>
61bfeeb7 2058
0999621a 2059 sprintf-related integer and memory overflow issues (Bug#9412).
62f19c19
PE
2060
2061 * doprnt.c (doprnt): Support printing ptrdiff_t and intmax_t values.
8666506e 2062 (esprintf, exprintf, evxprintf): New functions.
62f19c19 2063 * keyboard.c (command_loop_level): Now EMACS_INT, not int.
6b02f655 2064 (cmd_error): Kbd macro iterations count is now EMACS_INT, not int.
62f19c19
PE
2065 (modify_event_symbol): Do not assume that the length of
2066 name_alist_or_stem is safe to alloca and fits in int.
2067 (Fexecute_extended_command): Likewise for function name and binding.
2068 (Frecursion_depth): Wrap around reliably on integer overflow.
2069 * keymap.c (push_key_description): First arg is now EMACS_INT, not int,
2070 since some callers pass EMACS_INT values.
2071 (Fsingle_key_description): Don't crash if symbol name contains more
2072 than MAX_ALLOCA bytes.
2073 * minibuf.c (minibuf_level): Now EMACS_INT, not int.
2074 (get_minibuffer): Arg is now EMACS_INT, not int.
2075 * lisp.h (get_minibuffer, push_key_description): Reflect API changes.
8666506e 2076 (esprintf, exprintf, evxprintf): New decls.
62f19c19
PE
2077 * window.h (command_loop_level, minibuf_level): Reflect API changes.
2078
2be7d702
PE
2079 * dbusbind.c (signature_cat): New function.
2080 (xd_signature, Fdbus_register_signal):
2ea16b89
PE
2081 Do not overrun buffer; instead, report string overflow.
2082
9d1df220
PE
2083 * dispnew.c (add_window_display_history): Don't overrun buffer.
2084 Truncate instead; this is OK since it's just a log.
2085
33ef5c64
PE
2086 * editfns.c (Fcurrent_time_zone): Don't overrun buffer
2087 even if the time zone offset is outlandishly large.
2088 Don't mishandle offset == INT_MIN.
2089
66c6fdd5
PE
2090 * emacs.c (main) [NS_IMPL_COCOA]: Don't overrun buffer
2091 when creating daemon; the previous buffer-overflow check was incorrect.
2092
d749b01b
PE
2093 * eval.c (verror): Simplify by rewriting in terms of evxprintf,
2094 which has the guts of the old verror function.
2095
b5cd1905
PE
2096 * filelock.c (lock_file_1, lock_file): Don't blindly alloca long name;
2097 use SAFE_ALLOCA instead. Use esprintf to avoid int-overflow issues.
2098
6e1a67fb
PE
2099 * font.c: Include <float.h>, for DBL_MAX_10_EXP.
2100 (font_unparse_xlfd): Don't blindly alloca long strings.
c21721cc 2101 Don't assume XINT result fits in int, or that XFLOAT_DATA * 10
8666506e 2102 fits in int, when using sprintf. Use single snprintf to count
c21721cc
PE
2103 length of string rather than counting it via multiple sprintfs;
2104 that's simpler and more reliable.
c21721cc
PE
2105 (font_unparse_fcname): Use it to avoid sprintf buffer overrun.
2106 (generate_otf_features) [0 && HAVE_LIBOTF]: Use esprintf, not
2107 sprintf, in case result does not fit in int.
2108
c57b67fc
PE
2109 * fontset.c (num_auto_fontsets): Now printmax_t, not int.
2110 (fontset_from_font): Print it.
2111
8a401434
PE
2112 * frame.c (tty_frame_count): Now printmax_t, not int.
2113 (make_terminal_frame, set_term_frame_name): Print it.
2114 (x_report_frame_params): In X, window IDs are unsigned long,
2115 not signed long, so print them as unsigned.
2116 (validate_x_resource_name): Check for implausibly long names,
2117 and don't assume name length fits in 'int'.
2118 (x_get_resource_string): Don't blindly alloca invocation name;
2119 use SAFE_ALLOCA. Use esprintf, not sprintf, in case result does
2120 not fit in int.
2121
6e1a67fb
PE
2122 * gtkutil.c: Include <float.h>, for DBL_MAX_10_EXP.
2123 (xg_check_special_colors, xg_set_geometry):
84722b3d
PE
2124 Make sprintf buffers a bit bigger, to avoid potential buffer overrun.
2125
0df02bf3
PE
2126 * lread.c (dir_warning): Don't blindly alloca buffer; use SAFE_ALLOCA.
2127 Use esprintf, not sprintf, in case result does not fit in int.
2128
48e30793
PE
2129 * macros.c (executing_kbd_macro_iterations): Now EMACS_INT, not int.
2130 (Fend_kbd_macro): Don't mishandle MOST_NEGATIVE_FIXNUM by treating
2131 it as a large positive number.
2132 (Fexecute_kbd_macro): Don't assume repeat count fits in int.
2133 * macros.h (executing_kbd_macro_iterations): Now EMACS_INT, not int.
2134
a66ff6d8
PE
2135 * nsterm.m ((NSSize)windowWillResize): Use esprintf, not sprintf,
2136 in case result does not fit in int.
2137
aca216ff
PE
2138 * print.c (float_to_string): Detect width overflow more reliably.
2139 (print_object): Make sprintf buffer a bit bigger, to avoid potential
2140 buffer overrun. Don't assume list length fits in 'int'. Treat
2141 print length of 0 as 0, not as infinity; to be consistent with other
2142 uses of print length in this function. Don't overflow print length
2143 index. Don't assume hash table size fits in 'long', or that
2144 vectorlike size fits in 'unsigned long'.
2145
31c286f7
PE
2146 * process.c (make_process): Use printmax_t, not int, to format
2147 process-name gensyms.
2148
55e5faa1
PE
2149 * sysdep.c (snprintf) [! HAVE_SNPRINTF]: New function.
2150
80f2e268
PE
2151 * term.c (produce_glyphless_glyph): Make sprintf buffer a bit bigger
2152 to avoid potential buffer overrun.
2153
670741ab
PE
2154 * xfaces.c (x_update_menu_appearance): Don't overrun buffer
2155 if X resource line is longer than 512 bytes.
2156
b7163a50
PE
2157 * xfns.c (x_window): Make sprintf buffer a bit bigger
2158 to avoid potential buffer overrun.
2159
ae58ff1f
PE
2160 * xterm.c (x_io_error_quitter): Don't overrun sprintf buffer.
2161
c43c8a6a
PE
2162 * xterm.h (x_check_errors): Add ATTRIBUTE_FORMAT_PRINTF.
2163
3f8236f4
PE
21642011-09-04 Paul Eggert <eggert@cs.ucla.edu>
2165
53e9fe90 2166 Integer overflow fixes for scrolling, etc.
6511acf2
PE
2167 Without these, Emacs silently mishandles large integers sometimes.
2168 For example, "C-u 4294967297 M-x recenter" was treated as if
53e9fe90
PE
2169 it were "C-u 1 M-x recenter" on a typical 64-bit host.
2170
6511acf2
PE
2171 * xdisp.c (try_window_id): Check Emacs fixnum range before
2172 converting to 'int'.
806add1d 2173
6511acf2 2174 * window.c (window_scroll_line_based, Frecenter):
71f02bc5
PE
2175 Check that an Emacs fixnum is in range before assigning it to 'int'.
2176 (Frecenter, Fmove_to_window_line): Use EMACS_INT, not int, for
2177 values converted from Emacs fixnums.
2178 (Frecenter): Don't wrap around a line count if it is out of 'int'
2179 range; instead, treat it as an extreme value.
2180 (Fset_window_configuration, compare_window_configurations):
2181 Use ptrdiff_t, not int, for index that might exceed 2 GiB.
2182
6511acf2
PE
2183 * search.c (Freplace_match): Use ptrdiff_t, not int, for indexes
2184 that can exceed INT_MAX. Check that EMACS_INT value is in range
2185 before assigning it to the (possibly-narrower) index.
a0efffc8
PE
2186 (match_limit): Don't assume that a fixnum can fit in 'int'.
2187
6511acf2 2188 * print.c (print_object): Use ptrdiff_t, not int, for index that can
29ebea3b
PE
2189 exceed INT_MAX.
2190
6511acf2 2191 * indent.c (position_indentation): Now takes ptrdiff_t, not int.
3f8236f4
PE
2192 (Fvertical_motion): Don't wrap around LINES values that don't fit
2193 in 'int'. Instead, treat them as extreme values. This is good
2194 enough for windows, which can't have more than INT_MAX lines anyway.
2195
fcb901a7
LMI
21962011-09-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
2197
0f2f6b6d
LMI
2198 * Require libxml/parser.h to avoid compilation warning.
2199
fcb901a7
LMI
2200 * emacs.c (shut_down_emacs): Call xmlCleanupParser on shutdown.
2201
2202 * xml.c (parse_region): Don't call xmlCleanupParser after parsing,
2203 since this reportedly can destroy thread storage.
2204
6e20a0d4
CY
22052011-08-30 Chong Yidong <cyd@stupidchicken.com>
2206
2207 * syntax.c (find_defun_start): Update all cache variables if
2208 exiting early (Bug#9401).
2209
148ae00e
EZ
22102011-08-30 Eli Zaretskii <eliz@gnu.org>
2211
f6cfbd8f
EZ
2212 * image.c (x_bitmap_pixmap): Cast to int to avoid compiler warnings.
2213
148ae00e
EZ
2214 * xdisp.c (produce_stretch_glyph): No longer static, compiled also
2215 when HAVE_WINDOW_SYSTEM is not defined. Support both GUI and TTY
2216 frames. Call tty_append_glyph in the TTY case. (Bug#9402)
2217
2218 * term.c (tty_append_glyph): New function.
2219 (produce_stretch_glyph): Static function and its prototype deleted.
2220
a66cfb1c
SM
2221 * dispextern.h (produce_stretch_glyph, tty_append_glyph):
2222 Add prototypes.
148ae00e 2223
c4a07a4c
PE
22242011-08-29 Paul Eggert <eggert@cs.ucla.edu>
2225
2226 * image.c (parse_image_spec): Check for nonnegative, not for positive,
2227 when checking :margin (Bug#9390).
2228 (IMAGE_NON_NEGATIVE_INTEGER_VALUE_OR_PAIR):
a66cfb1c 2229 Rename from IMAGE_POSITIVE_INTEGER_VALUE_OR_PAIR,
c4a07a4c
PE
2230 so that the name doesn't mislead. All uses changed.
2231
6bc8cd65
JB
22322011-08-28 Johan Bockgård <bojohan@gnu.org>
2233
2234 * term.c (init_tty) [HAVE_GPM]: Move mouse settings after
2235 set_tty_hooks.
2236
dca4927e
EZ
22372011-08-27 Eli Zaretskii <eliz@gnu.org>
2238
2239 * xdisp.c (move_it_to): Don't bail out early when reaching
2240 position beyond to_charpos, if we are scanning backwards.
2241 (move_it_vertically_backward): When DY == 0, make sure we get to
2242 the first character in the line after the newline.
2243
f2cad773
PE
22442011-08-27 Paul Eggert <eggert@cs.ucla.edu>
2245
2246 * ccl.c: Improve and simplify overflow checking (Bug#9196).
2247 (ccl_driver): Do not generate an out-of-range pointer.
2248 (Fccl_execute_on_string): Remove unnecessary check for
2249 integer overflow, noted by Stefan Monnier in
2250 <http://lists.gnu.org/archive/html/emacs-devel/2011-08/msg00979.html>.
2251 Remove a FIXME that didn't need fixing.
2252 Simplify the newly-introduced buffer reallocation code.
2253
0cae2cdb
JB
22542011-08-27 Juanma Barranquero <lekktu@gmail.com>
2255
2256 * makefile.w32-in ($(BLD)/alloc.$(O)): Depend on lib/verify.h.
2257
5fc295a4 22582011-08-26 Paul Eggert <eggert@cs.ucla.edu>
ddff3151 2259
70c60eb2 2260 Integer and memory overflow issues (Bug#9196).
726e0ab1 2261
d31850da
PE
2262 * doc.c (get_doc_string): Rework so that
2263 get_doc_string_buffer_size is the actual buffer size, rather than
2264 being 1 less than the actual buffer size; this makes xpalloc more
2265 convenient.
2266
a69fbedb
PE
2267 * image.c (x_allocate_bitmap_record, cache_image):
2268 * xselect.c (Fx_register_dnd_atom):
2269 Simplify previous changes by using xpalloc.
2270
fe5c5d37
PE
2271 * buffer.c (overlay_str_len): Now ptrdiff_t, not EMACS_INT,
2272 since either will do and ptrdiff_t is convenient with xpalloc.
2273
0065d054
PE
2274 * charset.c (charset_table_size)
2275 (struct charset_sort_data.priority): Now ptrdiff_t.
2276 (charset_compare): Don't overflow if priorities differ greatly.
2277 (Fsort_charsets): Don't assume list length fits in int.
2278 Check for size-calculation overflow when allocating sort data.
2279 (syms_of_charset): Allocate an initial charset table that is
2280 just under 64 KiB, to avoid problems with glibc malloc and mmap.
2281
2282 * cmds.c (internal_self_insert): Check for size-calculation overflow.
2283
2284 * composite.h (struct composition.glyph_len): Now int, not unsigned.
2285 The actual value is always <= INT_MAX, and leaving it unsigned made
2286 overflow checking harder.
2287
2288 * dispextern.h (struct glyph_matrix.rows_allocated)
2289 (struct face_cache.size): Now ptrdiff_t, for convenience in use
2290 with xpalloc. The values are still always <= INT_MAX.
2291
2292 * indent.c (compute_motion): Adjust to region_cache_forward sig change.
2293
2294 * lisp.h (xnmalloc, xnrealloc, xpalloc): New decls.
2295 (SAFE_NALLOCA): New macro.
2296
2297 * region-cache.c (struct boundary.pos, find_cache_boundary)
2298 (move_cache_gap, insert_cache_boundary, delete_cache_boundaries)
2299 (set_cache_region, invalidate_region_cache)
2300 (revalidate_region_cache, know_region_cache, region_cache_forward)
2301 (region_cache_backward, pp_cache):
2302 Use ptrdiff_t, not EMACS_INT, since either will do. This is needed
2303 so that ptrdiff_t * can be passed to xpalloc.
2304 (struct region_cache): Similarly, for gap_start, gap_len, cache_len,
2305 beg_unchanged, end_unchanged, buffer_beg, buffer_end members.
2306 (pp_cache): Don't assume cache_len fits in int.
2307 * region-cache.h: Adjust extern decls to match.
2308
2309 * search.c (scan_buffer, Freplace_match): Use ptrdiff_t, not
2310 EMACS_INT, since either will do, for xpalloc.
2311
2312 * alloc.c: Include verify.h, and check that int fits in ptrdiff_t.
2313 (xnmalloc, xnrealloc, xpalloc): New functions.
2314
726e0ab1
PE
2315 * bidi.c (bidi_shelve_header_size): New constant.
2316 (bidi_cache_ensure_space, bidi_shelve_cache): Use it.
2317 (bidi_cache_ensure_space): Avoid integer overflow when allocating.
2318
51f30bc5 2319 * bidi.c (bidi_cache_shrink):
726e0ab1
PE
2320 * buffer.c (overlays_at, overlays_in, record_overlay_string)
2321 (overlay_strings):
2322 Don't update size of array until after memory allocation succeeds,
2323 because xmalloc/xrealloc may not return.
0065d054
PE
2324 (struct sortstrlist.bytes): Now ptrdiff_t, as EMACS_INT doesn't help
2325 now that we have proper integer overflow checking.
2326 (record_overlay_string, overlay_strings): Catch overflows when
2327 calculating size of overlay_str_buf.
726e0ab1 2328
0065d054
PE
2329 * callproc.c (Fcall_process): Check for size overflow when
2330 calculating size of args2.
2331 (child_setup): Avoid overflow by using size_t rather than ptrdiff_t.
2332 Normally we prefer signed values, but sticking with ptrdiff_t would
2333 require adding more-complicated checks.
726e0ab1
PE
2334
2335 * ccl.c (Fccl_execute_on_string): Check for memory overflow.
2336 Use ptrdiff_t rather than EMACS_INT where ptrdiff_t will do.
2337 Redo buffer-overflow calculations to avoid integer overflow.
0065d054 2338 Add a FIXME comment where memory seems to be over-allocated.
726e0ab1
PE
2339
2340 * character.c (Fstring): Check for size-calculation overflow.
2341
2342 * coding.c (produce_chars): Redo buffer-overflow calculations to avoid
2343 unnecessary integer overflow. Check for size overflow.
2344 (encode_coding_object): Don't update size until xmalloc succeeds.
2345
2346 * composite.c (get_composition_id): Check for overflow in glyph
2347 length calculations.
2348
2349 Integer and memory overflow fixes for display code.
2350 * dispextern.h (struct glyph_pool.nglyphs): Now ptrdiff_t, not int.
2351 * dispnew.c (adjust_glyph_matrix, realloc_glyph_pool)
2352 (scrolling_window): Check for overflow in size calculations.
2353 (line_draw_cost, realloc_glyph_pool, add_row_entry):
2354 Don't assume glyph table len fits in int.
2355 (struct row_entry.bucket, row_entry_pool_size, row_entry_idx)
2356 (row_table_size): Now ptrdiff_t, not int.
2357 (scrolling_window): Avoid overflow in size calculations.
2358 Don't update size until allocation succeeds.
2359 * fns.c (concat): Check for overflow in size calculations.
2360 (next_almost_prime): Verify NEXT_ALMOST_PRIME_LIMIT.
2361 * lisp.h (RANGED_INTEGERP, TYPE_RANGED_INTEGERP): New macros.
2362 (NEXT_ALMOST_PRIME_LIMIT): New constant.
2363
2364 * doc.c (get_doc_string_buffer_size): Now ptrdiff_t, not int.
2365 (get_doc_string): Check for size calculation overflow.
2366 Don't update size until allocation succeeds.
2367 (get_doc_string, Fsubstitute_command_keys): Use ptrdiff_t, not
2368 EMACS_INT, where ptrdiff_t will do.
2369 (Fsubstitute_command_keys): Check for string overflow.
2370
2371 * editfns.c (set_time_zone_rule): Don't assume environment length
2372 fits in int.
2373 (message_length): Now ptrdiff_t, not int.
2374 (Fmessage_box): Don't update size until allocation succeeds.
2375 Don't assume message length fits in int.
2376 (Fformat): Use ptrdiff_t, not EMACS_INT, where ptrdiff_t will do.
2377
0065d054
PE
2378 * emacs.c (main): Do not reallocate argv, since there is a null at
2379 the end that can be overwritten, and this way there's no need to
2380 worry about size-calculation overflow.
2381 (sort_args): Check for size-calculation overflow.
726e0ab1
PE
2382
2383 * eval.c (init_eval_once, grow_specpdl): Don't update size until
2384 alloc succeeds.
2385 (call_debugger, grow_specpdl): Redo calculations to avoid overflow.
2386
2387 * frame.c (set_menu_bar_lines, x_set_frame_parameters)
2388 (x_set_scroll_bar_width, x_figure_window_size):
2389 Check for integer overflow.
2390 (x_set_alpha): Do not assume XINT fits in int.
2391
2392 * frame.h (struct frame): Use int, not EMACS_INT, where int works.
2393 This is for the members text_lines, text_cols, total_lines, total_cols,
2394 where the system imposes an 'int' limit.
2395
2396 * fringe.c (Fdefine_fringe_bitmap):
2397 Don't update size until alloc works.
2398
2399 * ftfont.c (ftfont_get_open_type_spec, setup_otf_gstring)
2400 (ftfont_shape_by_flt): Check for integer overflow in size calculations.
2401
2402 * gtkutil.c (get_utf8_string, xg_store_widget_in_map):
2403 Check for size-calculation overflow.
2404 (get_utf8_string): Use ptrdiff_t, not size_t, where either will
2405 do, as we prefer signed integers.
2406 (id_to_widget.max_size, id_to_widget.used)
2407 (xg_store_widget_in_map, xg_remove_widget_from_map)
2408 (xg_get_widget_from_map, xg_get_scroll_id_for_window)
2409 (xg_remove_scroll_bar, xg_update_scrollbar_pos):
2410 Use and return ptrdiff_t, not int.
2411 (xg_gtk_scroll_destroy): Don't assume ptrdiff_t fits in int.
2412 * gtkutil.h: Change prototypes to match the above.
2413
2414 * image.c (RANGED_INTEGERP, TYPE_RANGED_INTEGERP): Remove; these
2415 are duplicate now that they've been promoted to lisp.h.
2416 (x_allocate_bitmap_record, x_alloc_image_color)
2417 (make_image_cache, cache_image, xpm_load):
2418 Don't update size until alloc is done.
2419 (xpm_load, lookup_rgb_color, lookup_pixel_color, x_to_xcolors)
2420 (x_detect_edges):
3256efce 2421 Check for size calculation overflow.
726e0ab1
PE
2422 (ct_colors_allocated_max): New constant.
2423 (x_to_xcolors, x_detect_edges): Reorder multiplicands to avoid
2424 overflow.
3256efce 2425
726e0ab1
PE
2426 * keyboard.c (read_char, menu_bar_items, tool_bar_items)
2427 (read_char_x_menu_prompt, read_char_minibuf_menu_width)
2428 (read_char_minibuf_menu_prompt, follow_key, read_key_sequence):
2429 Use ptrdiff_t, not int, to count maps.
2430 (read_char_minibuf_menu_prompt): Check for overflow in size
a66cfb1c
SM
2431 calculations. Don't update size until allocation succeeds.
2432 Redo calculations to avoid overflow.
726e0ab1
PE
2433 * keyboard.h: Change prototypes to match the above.
2434
2435 * keymap.c (cmm_size, current_minor_maps): Use ptrdiff_t, not int,
2436 to count maps.
2437 (current_minor_maps): Check for size calculation overflow.
2438 * keymap.h: Change prototypes to match the above.
2439
2440 * lread.c (read1, init_obarray): Don't update size until alloc done.
2441
2442 * macros.c (Fstart_kbd_macro): Don't update size until alloc done.
2443 (store_kbd_macro_char): Reorder multiplicands to avoid overflow.
2444
726e0ab1
PE
2445 * nsterm.h (struct ns_color_table.size, struct ns_color_table.avail):
2446 Now ptrdiff_t, not int.
2447 * nsterm.m (ns_index_color): Use ptrdiff_t, not int, for table indexes.
2448 (ns_draw_fringe_bitmap): Rewrite to avoid overflow.
2449
2450 * process.c (Fnetwork_interface_list): Check for overflow
2451 in size calculation.
2452
2453 * region-cache.c (move_cache_gap): Check for size calculation overflow.
2454
2455 * scroll.c (do_line_insertion_deletion_costs): Check for size calc
2456 overflow. Don't bother calling xmalloc when xrealloc will do.
2457
2458 * search.c (Freplace_match): Check for size calculation overflow.
2459 (Fset_match_data): Don't assume list lengths fit in 'int'.
2460
2461 * sysdep.c (system_process_attributes): Use ptrdiff_t, not int,
2462 for command line length. Do not attempt to address one before the
2463 beginning of an array, as that's not portable.
2464
2465 * term.c (max_frame_lines): Remove; unused.
2466 (encode_terminal_src_size, encode_terminal_dst_size): Now ptrdiff_t,
2467 not int.
2468 (encode_terminal_code, calculate_costs): Check for size
2469 calculation overflow.
2470 (encode_terminal_code): Use ptrdiff_t, not int, to record glyph
2471 table lengths and related sizes. Don't update size until alloc
2472 done. Redo calculations to avoid overflow.
2473 (calculate_costs): Don't bother calling xmalloc when xrealloc will do.
2474
2475 * termcap.c (tgetent): Use ptrdiff_t, not int, to record results of
2476 subtracting pointers.
2477 (gobble_line): Check for overflow more carefully. Don't update size
2478 until alloc done.
2479
2480 * tparam.c (tparam1): Use ptrdiff_t, not int, for sizes.
2481 Don't update size until alloc done.
2482 Redo size calculations to avoid overflow.
2483 Check for size calculation overflow.
0065d054 2484 (main) [DEBUG]: Fix typo in invoking tparam1.
726e0ab1
PE
2485
2486 * xdisp.c (store_mode_line_noprop_char, x_consider_frame_title):
2487 Use ptrdiff_t, not int, for sizes.
2488 (store_mode_line_noprop_char): Don't update size until alloc done.
2489
0065d054
PE
2490 * xfaces.c (lface_id_to_name_size, Finternal_make_lisp_face):
2491 Use ptrdiff_t, not int, for sizes.
2492 (Finternal_make_lisp_face, cache_face):
2493 Check for size calculation overflow.
2494 (cache_face): Treat size calculation overflows as if they were
2495 memory exhaustion (the usual treatment), rather than aborting.
726e0ab1
PE
2496
2497 * xfns.c (x_encode_text, x_set_name_internal)
2498 (Fx_change_window_property): Use ptrdiff_t, not int, to count
2499 sizes, since they can exceed INT_MAX in size. Check for size
2500 calculation overflow.
2501
0065d054
PE
2502 * xgselect.c (gfds_size): Now ptrdiff_t, for convenience with xpalloc.
2503 (xg_select): Check for size calculation overflow.
726e0ab1
PE
2504 Don't update size until alloc done.
2505
0065d054 2506 * xrdb.c (get_environ_db): Don't assume path length fits in int,
726e0ab1 2507 as sprintf is limited to int lengths.
1d526e2f 2508
252c5ee1
PE
2509 * xselect.c (X_LONG_SIZE, X_SHRT_MAX, X_SHRT_MIN, X_LONG_MAX)
2510 (X_LONG_MIN): New macros.
864d7ce7
PE
2511 Use them to make the following changes clearer.
2512 (MAX_SELECTION_QUANTUM): Make the other bounds on this value clearer.
2513 This change doesn't affect the value now, but it may help remind
2514 future maintainers not to raise the value too much later.
2515 (SELECTION_QUANTUM): Remove, replacing with ...
2516 (selection_quantum): ... new function, which avoids overflow.
2517 All uses changed.
2518 (struct selection_data.size): Now ptrdiff_t, not int, to avoid
2519 assumption that selection length fits in 'int'.
2520 (x_reply_selection_request, x_handle_selection_request)
2521 (x_get_window_property, receive_incremental_selection)
2522 (x_get_window_property_as_lisp_data, selection_data_to_lisp_data)
2523 (lisp_data_to_selection_data, clean_local_selection_data):
2524 Use ptrdiff_t, not int, to record length of selection.
2525 (x_reply_selection_request, x_get_window_property)
2526 (receive_incremental_selection, x_property_data_to_lisp):
2527 Redo calculations to avoid overflow.
2528 (x_reply_selection_request): When sending hint, ceiling it at
252c5ee1 2529 X_LONG_MAX rather than relying on wraparound overflow to send
864d7ce7
PE
2530 something.
2531 (x_get_window_property, receive_incremental_selection)
2532 (lisp_data_to_selection_data, x_property_data_to_lisp):
2533 Check for size-calculation overflow.
2534 (x_get_window_property, receive_incremental_selection)
2535 (lisp_data_to_selection_data, Fx_register_dnd_atom):
2536 Don't store size until memory allocation succeeds.
2537 (x_get_window_property): Plug memory leak on memory exhaustion.
2538 Don't double-block input; malloc is safe here. Don't assume 2**34
2539 - 4 fits in unsigned long. Add an xassert to check
2540 XGetWindowProperty overflow. Be more careful about overflow
2541 calculations, and distinguish size from memory overflow better.
2542 (receive_incremental_selection): When tracing, don't assume
2543 unsigned int is less than INT_MAX.
2544 (x_selection_data_to_lisp_data): Remove unnecessary (and in theory
2545 harmful) conversions of unsigned short to int.
2546 (lisp_data_to_selection_data): Don't assume that integers
2547 in the range -65535 through -1 fit in an X unsigned short.
2548 Don't assume that ULONG_MAX == X_ULONG_MAX. Don't store into
2549 result parameters unless successful. Rely on cons_to_unsigned
2550 to report problems with elements; the old code wasn't right anyway.
2551 (x_check_property_data): Check for int overflow; we cannot use
2552 a wider type due to X limits.
2553 (x_handle_dnd_message): Use unsigned int, to avoid int overflow.
2554
726e0ab1 2555 * xsmfns.c (smc_save_yourself_CB): Check for size calc overflow.
34db673b 2556
0065d054
PE
2557 * xterm.c (x_color_cells, x_send_scrollbar_event, handle_one_xevent)
2558 (x_term_init): Check for size calculation overflow.
726e0ab1
PE
2559 (x_color_cells): Don't store size until memory allocation succeeds.
2560 (handle_one_xevent): Use ptrdiff_t, not int, for byte counts.
0065d054 2561 Don't assume alloca size is less than MAX_ALLOCA.
726e0ab1
PE
2562 (x_term_init): Don't assume length fits in int (sprintf is limited
2563 to int size).
bc18e09d 2564
ebfa62c0
PE
2565 Use ptrdiff_t for composition IDs.
2566 * character.c (lisp_string_width):
2567 * composite.c (composition_table_size, n_compositions)
2568 (get_composition_id, composition_gstring_from_id):
2569 * dispextern.h (struct glyph_string.cmp_id, struct composition_it.id):
2570 * xdisp.c (BUILD_COMPOSITE_GLYPH_STRING):
2571 * window.c (Frecenter):
2572 Use ptrdiff_t, not int, for composition IDs.
2573 * composite.c (get_composition_id): Check for integer overflow.
2574 * composite.h: Adjust prototypes to match the above changes.
2575
d3411f89
PE
2576 Use ptrdiff_t for hash table indexes.
2577 * category.c (hash_get_category_set):
2578 * ccl.c (ccl_driver):
2579 * charset.h (struct charset.hash_index, CHECK_CHARSET_GET_ID):
2580 * coding.c (coding_system_charset_list, detect_coding_system):
2581 * coding.h (struct coding_system.id):
2582 * composite.c (get_composition_id, gstring_lookup_cache):
2583 * fns.c (hash_lookup, hash_put, Fgethash, Fputhash):
2584 * image.c (xpm_get_color_table_h):
2585 * lisp.h (hash_lookup, hash_put):
2586 * minibuf.c (Ftest_completion):
2587 Use ptrdiff_t for hash table indexes, not int (which is too
2588 narrow, on 64-bit hosts) or EMACS_INT (which is too wide, on
2589 32-bit --with-wide-int hosts).
2590
e097a6fa
PE
2591 * charset.c (Fdefine_charset_internal): Check for integer overflow.
2592 Add a FIXME comment about memory leaks.
2593 (syms_of_charset): Don't assume xmalloc returns.
2594
5637687f
PE
2595 Don't assume that stated character widths fit in int.
2596 * character.c (Fchar_width, c_string_width, lisp_string_width):
2597 * character.h (CHAR_WIDTH):
2598 * indent.c (MULTIBYTE_BYTES_WIDTH):
2599 Use sanitize_char_width to avoid undefined and/or bad behavior
2600 with outlandish widths.
a66cfb1c 2601 * character.h (sanitize_tab_width): Rename from sanitize_width,
5637687f
PE
2602 now that we have two such functions. All uses changed.
2603 (sanitize_char_width): New inline function.
2604
a2271ba2
PE
2605 Don't assume that tab-width fits in int.
2606 * character.h (sanitize_width): New inline function.
2607 (SANE_TAB_WIDTH): New macro.
2608 (ASCII_CHAR_WIDTH): Use it.
2609 * indent.c (sane_tab_width): Remove. All uses replaced by
2610 SANE_TAB_WIDTH (current_buffer).
2611 * xdisp.c (init_iterator): Use SANE_TAB_WIDTH.
2612
18c52557
PE
2613 * fileio.c: Integer overflow issues with file modes.
2614 (Fset_file_modes, auto_save_1): Don't assume EMACS_INT fits in int.
2615
caeeedc1
PE
2616 * charset.c (read_hex): New arg OVERFLOW. All uses changed.
2617 Remove unreachable code.
2618 (read_hex, load_charset_map_from_file): Check for integer overflow.
2619
6df6ae42 2620 * xterm.c: Don't go over XClientMessageEvent limit.
50849c52
PE
2621 (scroll_bar_windows_size): Now ptrdiff_t, as we prefer signed.
2622 (x_send_scroll_bar_event): Likewise. Check that the size does not
2623 exceed limits imposed by XClientMessageEvent, as well as the usual
2624 ptrdiff_t and size_t limits.
2625
b13995db
PE
2626 * keyboard.c: Overflow, signedness and related fixes.
2627 (make_lispy_movement): Use same integer type in forward decl
2628 that is used in the definition.
2629 (read_key_sequence, keyremap_step):
2630 Change bufsize argument back to int, undoing my 2011-03-30 change.
2631 We prefer signed types, and int is wide enough here.
2632 (parse_tool_bar_item): Don't assume tool_bar_max_label_size is less
2633 than TYPE_MAXIMUM (EMACS_INT) / 2. Don't let the label size grow
2634 larger than STRING_BYTES_BOUND. Use ptrdiff_t for Emacs string
2635 length, not size_t. Use ptrdiff_t for index, not int.
2636 (keyremap_step, read_key_sequence): Redo bufsize check to avoid
2637 possibility of integer overflow.
2638
13464394
PE
2639 Overflow, signedness and related fixes for images.
2640
2641 * dispextern.h (struct it.stack[0].u.image.image_id)
2642 (struct_it.image_id, struct image.id, struct image_cache.size)
2643 (struct image_cache.used, struct image_cache.ref_count):
2644 * gtkutil.c (update_frame_tool_bar):
2645 * image.c (x_reference_bitmap, Fimage_size, Fimage_mask_p)
2646 (Fimage_metadata, free_image_cache, clear_image_cache, lookup_image)
2647 (cache_image, mark_image_cache, x_kill_gs_process, Flookup_image):
2648 * nsmenu.m (update_frame_tool_bar):
2649 * xdisp.c (calc_pixel_width_or_height):
2650 * xfns.c (image_cache_refcount):
2651 Image IDs are now ptrdiff_t, not int, to avoid arbitrary limits
2652 on typical 64-bit hosts.
2653
2654 * image.c (RANGED_INTEGERP, TYPE_RANGED_INTEGERP): New macros.
2655 (x_bitmap_pixmap, x_create_x_image_and_pixmap):
2656 Omit unnecessary casts to int.
2657 (parse_image_spec): Check that integers fall into 'int' range
2658 when the callers expect that.
2659 (image_ascent): Redo ascent calculation to avoid int overflow.
2660 (clear_image_cache): Avoid overflow when sqrt (INT_MAX) < nimages.
2661 (lookup_image): Remove unnecessary tests.
2662 (xbm_image_p): Locals are now of int, not EMACS_INT,
2663 since parse_image_check makes sure they fit into int.
2664 (png_load, gif_load, svg_load_image):
2665 Prefer int to unsigned where either will do.
2666 (tiff_handler): New function, combining the cores of the
a66cfb1c
SM
2667 old tiff_error_handler and tiff_warning_handler.
2668 This function is rewritten to use vsnprintf and thereby avoid
13464394
PE
2669 stack buffer overflows. It uses only the features of vsnprintf
2670 that are common to both POSIX and native Microsoft.
2671 (tiff_error_handler, tiff_warning_handler): Use it.
2672 (tiff_load, gif_load, imagemagick_load_image):
2673 Don't assume :index value fits in 'int'.
2674 (gif_load): Omit unnecessary cast to double, and avoid double-rounding.
2675 (imagemagick_load_image): Check that crop parameters fit into
2676 the integer types that MagickCropImage accepts. Don't assume
2677 Vimagemagick_render_type has a nonnegative value. Don't assume
2678 size_t fits in 'long'.
2679 (gs_load): Use printmax_t to print the widest integers possible.
2680 Check for integer overflow when computing image height and width.
2681
c11821d4
EZ
26822011-08-26 Eli Zaretskii <eliz@gnu.org>
2683
2684 * xdisp.c (redisplay_window): Don't force window start if point
2685 will be invisible in the resulting window. (Bug#9324)
2686
0c95fcf7
EZ
26872011-08-25 Eli Zaretskii <eliz@gnu.org>
2688
2689 * xdisp.c (compute_display_string_pos): Return 2 in DISP_PROP when
2690 the display spec is of the form `(space ...)'.
2691 (handle_display_spec): Return the value returned by
2692 handle_single_display_spec, not just 1 or zero.
2693 (handle_single_display_spec): If the display spec is of the form
2694 `(space ...)', and specifies display in the text area, return 2
2695 rather than 1.
fee65a97 2696 (try_cursor_movement): Check for the need to scroll more
a66cfb1c
SM
2697 accurately, and prefer exact match for point under bidi.
2698 Don't advance `row' beyond the last row of the window.
0c95fcf7
EZ
2699
2700 * dispextern.h (struct bidi_it): Rename the disp_prop_p member
2701 into disp_prop; all users changed.
2702
2703 * bidi.c (bidi_fetch_char): If compute_display_string_pos returns
2704 DISP_PROP = 2, substitute the u+2029 PARAGRAPH SEPARATOR character
2705 for the text covered by the display property.
2706
e4ed06f1
CY
27072011-08-25 Chong Yidong <cyd@stupidchicken.com>
2708
2709 * buffer.c (Fbury_buffer_internal): Rename from Funrecord_buffer.
2710 Change return value to nil.
2711 (Frecord_buffer): Delete unused function.
2712
f67cdd7f
EZ
27132011-08-24 Eli Zaretskii <eliz@gnu.org>
2714
5980d4c6
EZ
2715 * xdisp.c (Fcurrent_bidi_paragraph_direction): For unibyte
2716 buffers, return left-to-right.
8610fe8b
EZ
2717 (set_cursor_from_row): Consider candidate row a win if its glyph
2718 represents a newline and point is on that newline. Fixes cursor
2719 positioning on the newline at EOL of R2L text within L2R
2720 paragraph, and vice versa.
2721 (try_cursor_movement): Check continued rows, in addition to
2722 continuation rows. Fixes unwarranted scroll when point enters a
2723 continued line of R2L text within an L2R paragraph, or vice versa.
2724 (cursor_row_p): Consider the case of point being equal to
2725 MATRIX_ROW_END_CHARPOS. Prevents cursor being stuck when moving
2726 from the end of a short line to the beginning of a continued line
2727 of R2L text within L2R paragraph.
2728 (RECORD_MAX_MIN_POS): For max_pos, use IT_CHARPOS even for
2729 composed characters.
5980d4c6 2730
f67cdd7f
EZ
2731 * bidi.c (bidi_check_type): Use xassert.
2732 (bidi_cache_iterator_state): Update the disp_pos and disp_prop_p
2733 members.
2734
bca633fb
EZ
27352011-08-23 Eli Zaretskii <eliz@gnu.org>
2736
2737 * bidi.c (bidi_get_type): Abort if we get zero as the bidi type of
2738 a character.
2739
4a5885a7
CY
27402011-08-23 Chong Yidong <cyd@stupidchicken.com>
2741
2742 * nsfont.m (ns_otf_to_script): Fix typo.
2743
0902a04e
KH
27442011-08-22 Kenichi Handa <handa@m17n.org>
2745
2746 * chartab.c (Fset_char_table_extra_slot): Do not inhibit setting a
2747 extra slot even if the purpose is char-code-property-table.
2748
1a2e6670
EZ
27492011-08-23 Eli Zaretskii <eliz@gnu.org>
2750
8ddde651
EZ
2751 * xdisp.c (redisplay_window): When computing centering_position,
2752 account for the height of the header line. (Bug#8874)
2753
425cc014
EZ
2754 * dispnew.c (buffer_posn_from_coords): Use buf_charpos_to_bytepos
2755 instead of CHAR_TO_BYTE. Fixes a crash when a completion
2756 candidate is selected by the mouse, and that candidate has a
2757 composed character under the mouse.
2758
1a2e6670
EZ
2759 * xdisp.c (x_produce_glyphs): Set it->nglyphs to 1. Fixes pixel
2760 coordinates reported by pos-visible-in-window-p for a composed
2761 character in column zero.
2762
8b76d6f8
SM
27632011-08-23 Stefan Monnier <monnier@iro.umontreal.ca>
2764
2765 * cmds.c (Fself_insert_command): Mention post-self-insert-hook.
2766
dac347dd
EZ
27672011-08-22 Eli Zaretskii <eliz@gnu.org>
2768
2769 * xdisp.c (BUFFER_POS_REACHED_P): If this is a composition,
2770 consider it a hit if to_charpos is anywhere in the range of the
2771 composed buffer positions.
2772
e013fb34
CY
27732011-08-22 Chong Yidong <cyd@stupidchicken.com>
2774
2775 * image.c (gif_load): Don't assume that each subimage has the same
2776 dimensions as the base image. Handle disposal method that is
2777 "undefined" by the gif spec (Bug#9335).
2778
bd1ba3e8
CY
27792011-08-20 Chong Yidong <cyd@stupidchicken.com>
2780
2781 * eval.c (Fsignal): Handle `debug' symbol in error handler (Bug#9329).
024a2d76 2782 (Fcondition_case): Document `debug' symbol in error handler.
bd1ba3e8 2783
54a1215b
EZ
27842011-08-19 Eli Zaretskii <eliz@gnu.org>
2785
823564e5
EZ
2786 * xfaces.c (face_at_buffer_position): Avoid repeated evaluation of
2787 face ID by FACE_FROM_ID, and avoid a crash when mouse is moved
2788 from an Org mode buffer to a Speedbar frame.
2789
54a1215b
EZ
2790 * xdisp.c (RECORD_MAX_MIN_POS): If the display element comes from
2791 a composition, take its buffer position from IT->cmp_it.charpos.
2792 Fixes cursor positioning at the beginning of a line that begins
2793 with a composed character.
2794
9778ebcc
EZ
27952011-08-18 Eli Zaretskii <eliz@gnu.org>
2796
0be6ee06
EZ
2797 * bidi.c (bidi_get_type): If bidi_type_table reports zero as the
2798 character bidirectional type, use STRONG_L instead. Fixes crashes
2799 in a buffer produced by `describe-categories'.
2800
9778ebcc
EZ
2801 * dispextern.h (struct bidi_it): Move disp_pos and disp_prop_p
2802 members before the level stack, so they would be saved and
2803 restored when copying iterator state. Fixes incorrect reordering
2804 around TABs covered by display properties.
2805
156bffbe
AS
28062011-08-18 Andreas Schwab <schwab@linux-m68k.org>
2807
6b02f655 2808 * process.c (Fnetwork_interface_list): Correctly determine buffer size.
156bffbe 2809
72ad093b
CY
28102011-08-17 Chong Yidong <cyd@stupidchicken.com>
2811
2812 * eval.c (internal_condition_case, internal_condition_case_1)
8b76d6f8
SM
2813 (internal_condition_case_2, internal_condition_case_n):
2814 Remove unnecessary aborts (Bug#9081).
72ad093b 2815
35774242
EZ
28162011-08-17 Eli Zaretskii <eliz@gnu.org>
2817
2818 * lread.c (Fload) [DOS_NT]: If `openp' returns -2, but the file
2819 has no `load' handler, try opening the file locally. (Bug#9311)
2820
db76dd85
KB
28212011-08-16 Ken Brown <kbrown@cornell.edu>
2822
2823 * gmalloc.c: Expand comment.
2824
b215eee5
EZ
28252011-08-16 Eli Zaretskii <eliz@gnu.org>
2826
2827 * xdisp.c (set_cursor_from_row): Don't accept a previous candidate
2828 if it fails the cursor_row_p test. Fixes cursor positioning at ZV.
2829
a4579d33
KB
28302011-08-16 Ken Brown <kbrown@cornell.edu>
2831
2832 Fix memory allocation problems in Cygwin build (Bug#9273).
2833
2834 * unexcw.c ( __malloc_initialized): Declare external variable.
2835 (fixup_executable): Force the dumped emacs to reinitialize malloc.
2836
8b76d6f8
SM
2837 * gmalloc.c [CYGWIN] (bss_sbrk_heapbase, bss_sbrk_heapinfo):
2838 New variables.
a4579d33
KB
2839 (malloc_initialize_1) [CYGWIN]: Prepare for reinitializing the
2840 dumped emacs.
2841 (_free_internal_nolock) [CYGWIN]: Ignore requests to free storage
2842 in the static heap.
2843 [CYGWIN] (special_realloc): New function.
2844 (_realloc_internal_nolock) [CYGWIN]: Use the new function on
2845 requests to realloc storage in the static heap.
2846
3ebec551
PE
28472011-08-15 Paul Eggert <eggert@cs.ucla.edu>
2848
2849 * bidi.c (bidi_initialize): Remove unused local.
2850
9fd8be00
EZ
28512011-08-15 Eli Zaretskii <eliz@gnu.org>
2852
6b02f655
SM
2853 * bidimirror.h:
2854 * biditype.h: Remove file.
2855 * makefile.w32-in ($(BLD)/bidi.$(O)):
2856 * deps.mk (bidi.o): Remove biditype.h and bidimirror.h.
474a8465
EZ
2857
2858 * dispextern.h: Fix a typo in the comment to bidi_type_t.
2859
2860 * chartab.c: Improve commentary for the uniprop_table API.
2861
32413314
EZ
2862 * bidi.c (bidi_paragraph_init): Support zero value of
2863 bidi_ignore_explicit_marks_for_paragraph_level.
474a8465
EZ
2864 (bidi_initialize): Use uniprop_table instead of including
2865 biditype.h and bidimirror.h.
32413314 2866
9fd8be00
EZ
2867 * xdisp.c (move_it_in_display_line_to): Don't reset pixel
2868 coordinates of the iterator when restoring from ppos_it.
2869 (Bug#9296)
2870
5cf2b69b
KH
28712011-08-14 Kenichi Handa <handa@m17n.org>
2872
2873 * process.c (create_process): Call setup_process_coding_systems
72ad093b 2874 after the pid of the process is set to -1 (Bug#8162).
5cf2b69b 2875
daf17d00
EZ
28762011-08-14 Eli Zaretskii <eliz@gnu.org>
2877
2878 * xdisp.c (move_it_in_display_line_to): Don't invoke
2879 IT_RESET_X_ASCENT_DESCENT when iterator position was restored from
2880 ppos_it. Fixes vertical cursor motion when line beginning is
2881 covered by an image. (Bug#9296)
2882
08e3161a
JD
28832011-08-14 Jan Djärv <jan.h.d@swipnet.se>
2884
2885 * nsterm.h (ns_run_ascript): Declare.
2886 (NSAPP_DATA2_RUNASSCRIPT): Define.
2887
2888 * nsfns.m (as_script, as_result, as_status): New static variables.
2889 (ns_run_ascript): New function.
5e617bc2 2890 (Fns_do_applescript): Set variables as_*. Make an NSApplicationDefined
08e3161a
JD
2891 event with data2 set to NSAPP_DATA2_RUNASSCRIPT, post it and then start
2892 the event loop. Get status from as_status (Bug#7276).
2893
2894 * nsterm.m (sendEvent): If event is NSApplicationDefined and
2895 data2 is NSAPP_DATA2_RUNASSCRIPT, call ns_run_ascript and then exit
2896 the event loop (Bug#7276).
2897
a3720aa2
AS
28982011-08-14 Andreas Schwab <schwab@linux-m68k.org>
2899
2900 * gnutls.c (QCgnutls_bootprop_priority)
2901 (QCgnutls_bootprop_trustfiles, QCgnutls_bootprop_keylist)
2902 (QCgnutls_bootprop_crlfiles, QCgnutls_bootprop_callbacks)
2903 (QCgnutls_bootprop_loglevel, QCgnutls_bootprop_hostname)
2904 (QCgnutls_bootprop_min_prime_bits, QCgnutls_bootprop_verify_flags)
2905 (QCgnutls_bootprop_verify_hostname_error)
2906 (QCgnutls_bootprop_callbacks_verify): Rename from
2907 Qgnutls_bootprop_..., all uses changed.
2908
2909 * xfaces.c (QCignore_defface): Rename from Qignore_defface, all
2910 uses changed.
2911
0a0d27fb
PE
29122011-08-14 Paul Eggert <eggert@cs.ucla.edu>
2913
19d5c50c
PE
2914 * xfaces.c (Qframe_set_background_mode): Now static.
2915 * dispextern.h (Qframe_set_background_mode): Remove decl.
2916
0a0d27fb
PE
2917 * process.c (Fnetwork_interface_info): Declare local only if needed.
2918
377538cb
JD
29192011-08-13 Jan Djärv <jan.h.d@swipnet.se>
2920
2921 * process.c: Include ifaddrs.h and net/if_dl.h if available (Bug#8477).
2922 (Fnetwork_interface_list): Allocate in increments of bytes instead
2923 of sizeof (struct ifreq). Iterate over ifconf.ifc_req by counting
2924 bytes (Bug#8477). Count bytes correctly when ifr_addr is a struct
2925 sockaddr.
2926 (struct ifflag_def): notrailers is smart on OSX.
2927 (Fnetwork_interface_info): Handle case when ifr_flags is negative.
2928 Get hardware address with getifaddrs if available.
2929
08fff70c
EZ
29302011-08-12 Eli Zaretskii <eliz@gnu.org>
2931
2932 * xdisp.c (iterate_out_of_display_property): xassert that
2933 IT->position is set to within IT->object's boundaries. Break from
2934 the loop as soon as EOB is reached; avoids infloops in redisplay
8b76d6f8
SM
2935 when IT->position is set up wrongly due to some bug.
2936 Set IT->current to match the bidi iterator unconditionally.
08fff70c
EZ
2937 (push_display_prop): Allow GET_FROM_STRING as IT->method on
2938 entry. Force push_it to save on the stack the current
2939 buffer/string position, to be restored by pop_it. Fix flags in
2940 the iterator structure wrt the object coming from a display
2941 property, as `line-prefix' and `wrap-prefix' are not ``replacing''
2942 properties. (Bug#9284)
2943
7be1c708 29442011-08-09 Andreas Schwab <schwab@linux-m68k.org>
aac0c6e3 2945
7be1c708
CY
2946 * fontset.c (fontset_get_font_group): Add proper type checks.
2947 (Bug#9172)
aac0c6e3 2948
7be1c708 29492011-08-09 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
aac0c6e3 2950
7be1c708
CY
2951 * unexmacosx.c (print_load_command_name): Add cases LC_FUNCTION_STARTS
2952 and LC_VERSION_MIN_MACOSX.
2953 (copy_linkedit_data) [LC_FUNCTION_STARTS]: New function.
2954 (dump_it) [LC_FUNCTION_STARTS]: Use it.
aac0c6e3 2955
97bb72a6
EZ
29562011-08-08 Eli Zaretskii <eliz@gnu.org>
2957
2958 * xdisp.c (forward_to_next_line_start): Allow to use the
8b76d6f8
SM
2959 no-display-properties-and-no-overlays under bidi display.
2960 Set disp_pos in the bidi iterator to avoid searches for display
757664a4 2961 properties and overlays.
97bb72a6 2962
d5617611
CY
29632011-08-08 Chong Yidong <cyd@stupidchicken.com>
2964
37e11a63
CY
2965 * editfns.c (Fset_time_zone_rule): Document relationship with the
2966 setenv function.
2967
d5617611
CY
2968 * ftfont.c (ftfont_pattern_entity): Copy the extras argument to
2969 the font entity extracted from the cache (Bug#8109).
2970
58872834
CY
29712011-08-07 Chong Yidong <cyd@stupidchicken.com>
2972
2973 * composite.c (autocmp_chars): Don't reset point. That is done by
2974 restore_point_unwind (Bug#5984).
2975
75bfc667
JL
29762011-08-07 Juri Linkov <juri@jurta.org>
2977
2978 * editfns.c (Fformat_time_string): Doc fix, add tag `usage:'
2979 to show the arg `TIME' instead of `TIMEVAL'.
2980
d1410150
EZ
29812011-08-06 Eli Zaretskii <eliz@gnu.org>
2982
2983 * xdisp.c (set_cursor_from_row): Fix cursor positioning when a
2984 display property strides EOL and includes a newline, as in
2985 longlines-mode. (Bug#9254)
75b771e4
EZ
2986 (move_it_in_display_line_to): Fix vertical-motion in a buffer with
2987 word-wrap under bidirectional display. (Bug#9224)
d1410150
EZ
2988
2989 * bidi.c (bidi_unshelve_cache): Don't reset the cache if JUST_FREE
2990 is non-zero, even if the data buffer is NULL. Fixes a crash in
2991 vertical-motion with longlines-mode. (Bug#9254)
2992
35928349
EZ
29932011-08-05 Eli Zaretskii <eliz@gnu.org>
2994
ec7cc85b
EZ
2995 * bidi.c <bidi_cache_total_alloc>: Now static.
2996 (bidi_initialize): Initialize bidi_cache_total_alloc.
2997
8b76d6f8 2998 * xdisp.c (display_line): Release buffer allocated for shelved bidi
35928349
EZ
2999 cache. (Bug#9221)
3000
3001 * bidi.c (bidi_shelve_cache, bidi_unshelve_cache): Track total
3002 amount allocated this far in `bidi_cache_total_alloc'.
3003 (bidi_unshelve_cache): Accept an additional argument JUST_FREE; if
3004 non-zero, only free the data buffer without restoring the cache
3005 contents. All callers changed.
3006
3007 * dispextern.h (bidi_unshelve_cache): Update prototype.
3008
3009 * xdisp.c (SAVE_IT, pos_visible_p, move_it_in_display_line_to)
3010 (move_it_in_display_line, move_it_to)
3011 (move_it_vertically_backward, move_it_by_lines): Replace the call
3012 to xfree to an equivalent call to bidi_unshelve_cache.
3013 (move_it_in_display_line_to): Fix logic of returning
412b6358 3014 MOVE_POS_MATCH_OR_ZV in the bidi case. (Bug#9224)
35928349 3015
e2e2423b
EZ
30162011-08-05 Eli Zaretskii <eliz@gnu.org>
3017
3018 * xdisp.c (set_cursor_from_row): Prefer the candidate glyph that
3019 came from a string character with a `cursor' property. (Bug#9229)
3020
ae9e757a
JD
30212011-08-04 Jan Djärv <jan.h.d@swipnet.se>
3022
3023 * Makefile.in (LIB_PTHREAD): New variable.
3024 (LIBES): Add LIB_PTHREAD (Bug#9216).
3025
3026 * alloc.c, emacs.c, gmalloc.c, gtkutil.c, keyboard.c, syssignal.h:
3027 Rename HAVE_GTK_AND_PTHREAD to HAVE_PTHREAD (Bug#9216).
3028
213bd7f2
AS
30292011-08-04 Andreas Schwab <schwab@linux-m68k.org>
3030
6b02f655 3031 * regex.c (re_iswctype): Remove some redundant boolean conversions.
213bd7f2 3032
99aaf75f
JD
30332011-08-04 Jan Djärv <jan.h.d@swipnet.se>
3034
3035 * xterm.c (x_find_topmost_parent): New function.
3036 (x_set_frame_alpha): Find topmost parent window with
3037 x_find_topmost_parent and set the property there also (bug#9181).
3038 (handle_one_xevent): Call x_set_frame_alpha on ReparentNotify.
3039
c74e9d86
PE
30402011-08-04 Paul Eggert <eggert@cs.ucla.edu>
3041
3042 * callproc.c (Fcall_process): Avoid vfork clobbering
3043 the local vars buffer, coding_systems, current_dir.
3044
640c8776
SM
30452011-08-03 Stefan Monnier <monnier@iro.umontreal.ca>
3046
3047 * keymap.c (Fmake_composed_keymap): Move to subr.el.
3048
f26d0e4c
PE
30492011-08-03 Paul Eggert <eggert@cs.ucla.edu>
3050
8a10d76c
PE
3051 * fontset.c (dump_fontset) [FONTSET_DEBUG]: Declare EXTERNALLY_VISIBLE
3052 so that it is not optimized away.
3053
f26d0e4c
PE
3054 * xdisp.c (compute_display_string_pos): Remove unused local.
3055
55439c61
EZ
30562011-08-02 Eli Zaretskii <eliz@gnu.org>
3057
3058 Fix slow cursor motion and scrolling in large buffers with
3059 selective display, like Org Mode buffers. (Bug#9218)
3060
3061 * dispextern.h (struct bidi_it): New member disp_prop_p.
3062
3063 * xdisp.c: Remove one-slot cache of display string positions.
3064 (compute_display_string_pos): Accept an additional argument
5e617bc2 3065 DISP_PROP_P; callers changed. Scan at most 5K characters forward
55439c61
EZ
3066 for a display string or property. If found, set DISP_PROP_P
3067 non-zero.
3068
3069 * bidi.c (bidi_fetch_char): Accept an additional argument
640c8776
SM
3070 DISP_PROP_P, and pass it to compute_display_string_pos.
3071 Only handle text covered by a display string if DISP_PROP_P is returned
55439c61
EZ
3072 non-zero. All callers of bidi_fetch_char changed.
3073
fb33fa43
SM
30742011-08-02 Stefan Monnier <monnier@iro.umontreal.ca>
3075
3076 * keymap.c (Fdefine_key): Fix Lisp_Object/int mixup; apply some CSE.
3077
b099e063
DM
30782010-12-03 Don March <don@ohspite.net>
3079
3080 * keymap.c (Fdefine_key): Fix non-prefix key error message when
3081 last character M-[char] is translated to ESC [char] (bug#7541).
3082
5cc7f7af
KH
30832011-08-02 Kenichi Handa <handa@m17n.org>
3084
d0fffa3f 3085 * lisp.h (uniprop_table): Extern it.
5cc7f7af
KH
3086
3087 * chartab.c (uniprop_table): Make it non-static.
3088
525d5e6e
EZ
30892011-08-01 Eli Zaretskii <eliz@gnu.org>
3090
3091 * xdisp.c (forward_to_next_line_start): Accept additional argument
3092 BIDI_IT_PREV, and store into it the state of the bidi iterator had
3093 on the newline.
3094 (reseat_at_next_visible_line_start): Use the bidi iterator state
3095 returned by forward_to_next_line_start to restore the state of
3096 it->bidi_it after backing up to previous newline. (Bug#9212)
3097
31011111
AS
30982011-07-30 Andreas Schwab <schwab@linux-m68k.org>
3099
3100 * regex.c (re_comp): Protoize.
3101 (re_exec): Fix return type.
3102 (regexec): Fix type of `ret'. (Bug#9203)
3103
476371c4
PE
31042011-07-28 Paul Eggert <eggert@cs.ucla.edu>
3105
e5d76069
PE
3106 * image.c (check_image_size): Use 1024x1024 if unknown frame (Bug#9189).
3107 This is needed if max-image-size is a floating-point number.
3108
9a79b20c
AS
31092011-07-28 Andreas Schwab <schwab@linux-m68k.org>
3110
3111 * print.c (print_object): Print empty symbol as ##.
3112
3113 * lread.c (read1): Read ## as empty symbol.
3114
d8c2fa78
AA
31152011-07-28 Alp Aker <alp.tekin.aker@gmail.com>
3116
3117 * nsfns.m (x_set_foreground_color): Set f->foreground_pixel when
3118 setting frame foreground color (Bug#9175).
3119 (x_set_background_color): Likewise.
3120
ffe57a7a
AA
3121 * nsmenu.m (-setText): Size tooltip dimensions precisely to
3122 contents (Bug#9176).
3123 (EmacsTooltip -init): Remove bezels and add shadows to
3124 tooltip windows.
3125
bf3492a5
AA
3126 * nsterm.m (ns_dumpglyphs_stretch): Avoid overwriting left fringe
3127 or scroll bar (Bug#8470).
3128
d55e9c53
AA
3129 * nsfont.m (nsfont_open): Remove assignment to voffset and
3130 unnecessary vars hshink, expand, hd, full_height, min_height.
3131 (nsfont_draw): Use s->ybase as baseline for glyph drawing (Bug#8913).
3132
3133 * nsterm.h (nsfont_info): Remove voffset field.
3134
d8c2fa78 31352011-07-28 Alp Aker <alp.tekin.aker@gmail.com>
4843aac3
AA
3136
3137 Implement strike-through and overline on NextStep (Bug#8863).
3138
3139 * nsfont.m (nsfont_open): Use underline position provided by font,
3140 instead of hard-coded value of 2.
3141 (nsfont_draw): Call ns_draw_text_decoration instead.
3142
3143 * nsterm.h: Add declaration for ns_draw_text_decoration.
3144
3145 * nsterm.m (ns_draw_text_decoration): New function for drawing
3146 underline, overline, and strike-through.
3147 (ns_dumpglyphs_image, ns_dumpglyphs_stretch): Add call to
3148 ns_draw_text_decoration. Change treatment of cursor drawing to
8d5ed899 3149 accommodate underlining, etc.
4843aac3 3150
4cc60b9b
EZ
31512011-07-28 Eli Zaretskii <eliz@gnu.org>
3152
bc7ece87
EZ
3153 * buffer.c (init_buffer_once): Set bidi-display-reordering to t by
3154 default.
4cc60b9b 3155
476371c4
PE
31562011-07-28 Paul Eggert <eggert@cs.ucla.edu>
3157
66606eea
PE
3158 * alloc.c (memory_full) [!SYNC_INPUT]: Fix signal-related race.
3159 Without this fix, if a signal arrives just after memory fills up,
3160 'malloc' might be invoked reentrantly.
3161
476371c4
PE
3162 * image.c (x_check_image_size) [!HAVE_X_WINDOWS]: Return 1.
3163 In other words, assume that every image size is allowed, on non-X
3164 hosts. This assumption is probably wrong, but it lets Emacs compile.
3165
f3fcc40d
AS
31662011-07-28 Andreas Schwab <schwab@linux-m68k.org>
3167
3168 * regex.c (re_iswctype): Convert return values to boolean.
3169
350c992f
EZ
31702011-07-28 Eli Zaretskii <eliz@fencepost.gnu.org>
3171
3172 * xdisp.c (compute_display_string_pos): Don't use cached display
3173 string position if the buffer had its restriction changed.
3174 (Bug#9184)
3175
5266b4bb
PE
31762011-07-28 Paul Eggert <eggert@cs.ucla.edu>
3177
3178 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork clobbering.
3179
2573a837 31802011-07-28 Paul Eggert <eggert@cs.ucla.edu>
ca4aa935 3181
41f55ccd 3182 Integer signedness and overflow and related fixes. (Bug#9079)
cf950e6b 3183
39e378da
PE
3184 * bidi.c: Integer size and overflow fixes.
3185 (bidi_cache_size, bidi_cache_idx, bidi_cache_last_idx)
3186 (bidi_cache_start, bidi_cache_fetch_state, bidi_cache_search)
3187 (bidi_cache_find_level_change, bidi_cache_ensure_space)
3188 (bidi_cache_iterator_state, bidi_cache_find, bidi_cache_start_stack)
3189 (bidi_find_other_level_edge):
3190 Use ptrdiff_t instead of EMACS_INT where either will do.
3191 This works better on 32-bit hosts configured --with-wide-int.
3192 (bidi_cache_ensure_space): Check for size-calculation overflow.
3193 Use % rather than repeated addition, for better worst-case speed.
3194 Don't set bidi_cache_size until after xrealloc returns, because it
3195 might not return.
3196 (bidi_dump_cached_states): Use ptrdiff_t, not int, to avoid overflow.
f0eb61e9
PE
3197 (bidi_cache_ensure_space): Also check that the bidi cache size
3198 does not exceed that of the largest Lisp string or buffer. See Eli
3199 Zaretskii in <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=9079#29>.
39e378da 3200
5e927815
PE
3201 * alloc.c (__malloc_size_t): Remove.
3202 All uses replaced by size_t. See Andreas Schwab's note
3203 <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=9079#8>.
3204
ca4aa935
PE
3205 * image.c: Improve checking for integer overflow.
3206 (check_image_size): Assume that f is nonnull, since
3207 it is always nonnull in practice. This is one less thing to
3208 worry about when checking for integer overflow later.
3209 (x_check_image_size): New function, which checks for integer
3210 overflow issues inside X.
3211 (x_create_x_image_and_pixmap, xbm_read_bitmap_data): Use it.
3212 This removes the need for a memory_full check.
3213 (xbm_image_p): Rewrite to avoid integer multiplication overflow.
3214 (Create_Pixmap_From_Bitmap_Data, xbm_load): Use x_check_image_size.
3215 (xbm_read_bitmap_data): Change locals back to 'int', since
3216 their values must fit in 'int'.
3217 (xpm_load_image, png_load, tiff_load):
3218 Invoke x_create_x_image_and_pixmap earlier,
3219 to avoid much needless work if the image is too large.
3220 (tiff_load): Treat overly large images as if
3221 x_create_x_image_and_pixmap failed, not as malloc failures.
3222 (gs_load): Use x_check_image_size.
3223
5f8f9cc2
PE
3224 * gtkutil.c: Omit integer casts.
3225 (xg_get_pixbuf_from_pixmap): Remove unnecessary cast.
3226 (xg_set_toolkit_scroll_bar_thumb): Rewrite to avoid need for cast.
3227
5adf60bc
PE
3228 * image.c (png_load): Don't assume height * row_bytes fits in 'int'.
3229
c8907a93
PE
3230 * xfaces.c (Fbitmap_spec_p): Fix integer overflow bug.
3231 Without this fix, (bitmap-spec-p '(34359738368 1 "x"))
3232 would wrongly return t on a 64-bit host.
3233
e3c25c68
PE
3234 * dispnew.c (init_display): Use *_RANGE_OVERFLOW macros.
3235 The plain *_OVERFLOW macros run afoul of GCC bug 49705
3236 <http://gcc.gnu.org/bugzilla/show_bug.cgi?id=49705>
3237 and therefore cause GCC to emit a bogus diagnostic in some cases.
3238
3f791afe
PE
3239 * image.c: Integer signedness and overflow and related fixes.
3240 This is not an exhaustive set of fixes, but it's time to
3241 record what I've got.
3242 (lookup_pixel_color, check_image_size): Remove redundant decls.
3243 (check_image_size): Don't assume that arbitrary EMACS_INT values
3244 fit in 'int', or that arbitrary 'double' values fit in 'int'.
3245 (x_alloc_image_color, x_create_x_image_and_pixmap, png_load)
3246 (tiff_load, imagemagick_load_image):
3247 Check for overflow in size calculations.
3248 (x_create_x_image_and_pixmap): Remove unnecessary test for
3249 xmalloc returning NULL; that can't happen.
3250 (xbm_read_bitmap_data): Don't assume sizes fit into 'int'.
3251 (xpm_color_bucket): Use better integer hashing function.
3252 (xpm_cache_color): Don't possibly over-allocate memory.
3253 (struct png_memory_storage, tiff_memory_source, tiff_seek_in_memory)
3254 (gif_memory_source):
3255 Use ptrdiff_t, not int or size_t, to record sizes.
3256 (png_load): Don't assume values greater than 2**31 fit in 'int'.
3257 (our_stdio_fill_input_buffer): Prefer ptrdiff_t to size_t when
3258 either works, as we prefer signed integers.
3259 (tiff_read_from_memory, tiff_write_from_memory):
3260 Return tsize_t, not size_t, since that's what the TIFF API wants.
3261 (tiff_read_from_memory): Don't fail simply because the read would
3262 go past EOF; instead, return a short read.
3263 (tiff_load): Omit no-longer-needed casts.
3264 (Fimagemagick_types): Don't assume size fits into 'int'.
3265
3cc5a532
PE
3266 Improve hashing quality when configured --with-wide-int.
3267 * fns.c (hash_string): New function, taken from sxhash_string.
3268 Do not discard information about ASCII character case; this
3269 discarding is no longer needed.
3270 (sxhash-string): Use it. Change sig to match it. Caller changed.
3271 * lisp.h: Declare it.
3272 * lread.c (hash_string): Remove, since we now use fns.c's version.
3273 The fns.c version returns a wider integer if --with-wide-int is
3274 specified, so this should help the quality of the hashing a bit.
3275
b312a492
PE
3276 * emacs.c: Integer overflow minor fix.
3277 (heap_bss_diff): Now uprintmax_t, not unsigned long. All used changed.
3278 Define only if GNU_LINUX.
3279 (main, Fdump_emacs): Set and use heap_bss_diff only if GNU_LINUX.
3280
dfd153ae
PE
3281 * dispnew.c: Integer signedness and overflow fixes.
3282 Remove unnecessary forward decls, that were a maintenance hassle.
3283 (history_tick): Now uprintmax_t, so it's more likely to avoid overflow.
3284 All uses changed.
3285 (adjust_glyph_matrix, realloc_glyph_pool, adjust_frame_message_buffer)
3286 (scrolling_window): Use ptrdiff_t, not int, for byte count.
3287 (prepare_desired_row, line_draw_cost):
3288 Use int, not unsigned, where either works.
3289 (save_current_matrix, restore_current_matrix):
3290 Use ptrdiff_t, not size_t, where either works.
3291 (init_display): Check for overflow more accurately, and without
3292 relying on undefined behavior.
3293
a81d11a3
PE
3294 * editfns.c (pWIDE, pWIDElen, signed_wide, unsigned_wide):
3295 Remove, replacing with the new symbols in lisp.h. All uses changed.
3296 * fileio.c (make_temp_name):
3297 * filelock.c (lock_file_1, lock_file):
3298 * xdisp.c (message_dolog):
3299 Don't assume PRIdMAX etc. works; this isn't portable to pre-C99 hosts.
3300 Use pMd etc. instead.
3301 * lisp.h (printmax_t, uprintmax_t, pMd, pMu): New types and macros,
3302 replacing the pWIDE etc. symbols removed from editfns.c.
3303
3300e6fd
PE
3304 * keyboard.h (num_input_events): Now uintmax_t.
3305 This is (very slightly) less likely to mess up due to wraparound.
3306 All uses changed.
3307
fd05c7e9
PE
3308 * buffer.c: Integer signedness fixes.
3309 (alloc_buffer_text, enlarge_buffer_text):
3310 Use ptrdiff_t rather than size_t when either will do, as we prefer
3311 signed integers.
3312
903fe15d
PE
3313 * alloc.c: Integer signedness and overflow fixes.
3314 Do not impose an arbitrary 32-bit limit on malloc sizes when debugging.
3315 (__malloc_size_t): Default to size_t, not to int.
3316 (pure_size, pure_bytes_used_before_overflow, stack_copy_size)
3317 (Fgarbage_collect, mark_object_loop_halt, mark_object):
3318 Prefer ptrdiff_t to size_t when either would do, as we prefer
3319 signed integers.
3320 (XMALLOC_OVERRUN_CHECK_OVERHEAD): New macro.
3321 (xmalloc_overrun_check_header, xmalloc_overrun_check_trailer):
3322 Now const. Initialize with values that are in range even if char
3323 is signed.
3324 (XMALLOC_PUT_SIZE, XMALLOC_GET_SIZE): Remove, replacing with ...
3325 (xmalloc_put_size, xmalloc_get_size): New functions. All uses changed.
3326 These functions do the right thing with sizes > 2**32.
3327 (check_depth): Now ptrdiff_t, not int.
3328 (overrun_check_malloc, overrun_check_realloc, overrun_check_free):
3329 Adjust to new way of storing sizes. Check for size overflow bugs
3330 in rest of code.
3331 (STRING_BYTES_MAX): Adjust to new overheads. The old code was
3332 slightly wrong anyway, as it missed one instance of
3333 XMALLOC_OVERRUN_CHECK_OVERHEAD.
3334 (refill_memory_reserve): Omit needless cast to size_t.
3335 (mark_object_loop_halt): Mark as externally visible.
3336
ac82cc6a
PE
3337 * xselect.c: Integer signedness and overflow fixes.
3338 (Fx_register_dnd_atom, x_handle_dnd_message):
3339 Use ptrdiff_t, not size_t, since we prefer signed.
3340 (Fx_register_dnd_atom): Check for ptrdiff_t (and size_t) overflow.
3341 * xterm.h (struct x_display_info): Use ptrdiff_t, not size_t, for
3342 x_dnd_atoms_size and x_dnd_atoms_length.
3343
c2d1e36d
PE
3344 * doprnt.c: Prefer signed to unsigned when either works.
3345 * eval.c (verror):
3346 * doprnt.c (doprnt):
3347 * lisp.h (doprnt):
3348 * xdisp.c (vmessage):
3349 Use ptrdiff_t, not size_t, when using or implementing doprnt,
3350 since the sizes cannot exceed ptrdiff_t bounds anyway, and we
3351 prefer signed arithmetic to avoid comparison confusion.
3352 * doprnt.c (doprnt): Avoid a "+ 1" that can't overflow,
3353 but is a bit tricky.
3354
0e926e56
PE
3355 Assume freestanding C89 headers, string.h, stdlib.h.
3356 * data.c, doprnt.c, floatfns.c, print.c:
3357 Include float.h unconditionally.
3358 * gmalloc.c: Assume C89-at-least behavior for preprocessor,
3359 limits.h, stddef.h, string.h. Use memset instead of 'flood'.
3360 * regex.c: Likewise for stddef.h, string.h.
3361 (ISASCII): Remove; can assume it returns 1 now. All uses removed.
3362 * s/aix4-2.h (HAVE_STRING_H): Remove obsolete undef.
3363 * s/ms-w32.h (HAVE_LIMITS_H, HAVE_STRING_H, HAVE_STDLIB_H)
3364 (STDC_HEADERS): Remove obsolete defines.
3365 * sysdep.c: Include limits.h unconditionally.
3366
9cfdb3ec
PE
3367 Assume support for memcmp, memcpy, memmove, memset.
3368 * lisp.h, sysdep.c (memcmp, memcpy, memmove, memset):
3369 * regex.c (memcmp, memcpy):
3370 Remove; we assume C89 now.
3371
3372 * gmalloc.c (memcpy, memset, memmove): Remove; we assume C89 now.
3373 (__malloc_safe_bcopy): Remove; no longer needed.
3374
cf950e6b 3375 * lisp.h (struct vectorlike_header, struct Lisp_Subr): Signed sizes.
6089c567
PE
3376 Use EMACS_INT, not EMACS_UINT, for sizes. The code works equally
3377 well either way, and we prefer signed to unsigned.
3378
dbf38e02
LMI
33792011-07-27 Lars Magne Ingebrigtsen <larsi@gnus.org>
3380
3381 * gnutls.c (emacs_gnutls_read): Don't message anything if the peer
3382 closes the connection while we're reading (bug#9182).
3383
d6f0886c 33842011-07-25 Jan Djärv <jan.h.d@swipnet.se>
24e0f6b1 3385
d6f0886c
JD
3386 * nsmenu.m (ns_popup_dialog): Add an "ok" button if no buttons
3387 are specified (Bug#9168).
24e0f6b1 3388
2eb1f9e6
PE
33892011-07-25 Paul Eggert <eggert@cs.ucla.edu>
3390
3391 * bidi.c (bidi_dump_cached_states): Fix printf format mismatch.
3392 Found by GCC static checking and --with-wide-int on a 32-bit host.
3393
22381272 33942011-07-25 Eli Zaretskii <eliz@gnu.org>
7daee910
EZ
3395
3396 * xdisp.c (compute_display_string_pos): Fix logic of caching
3397 previous display string position. Initialize cached_prev_pos to
3398 -1. Fixes slow-down at the beginning of a buffer.
3399
f25e39b4
EZ
34002011-07-24 Eli Zaretskii <eliz@gnu.org>
3401
3402 * xfaces.c (check_lface_attrs) [HAVE_WINDOW_SYSTEM]: Allow `nil'
3403 for attrs[LFACE_FONTSET_INDEX].
3404
04c4b52e
PE
34052011-07-23 Paul Eggert <eggert@cs.ucla.edu>
3406
3407 * xml.c (parse_region): Remove unused local
3408 that was recently introduced.
3409
c1734fbd
EZ
34102011-07-23 Eli Zaretskii <eliz@gnu.org>
3411
be18c5a5
EZ
3412 * xfns.c (unwind_create_frame) [GLYPH_DEBUG]: Adapt to changes in
3413 2008-02-22T17:42:09Z!monnier@iro.umontreal.ca.
3414
c1734fbd
EZ
3415 * xdisp.c (move_it_in_display_line_to): Record the best matching
3416 position for TO_CHARPOS while scanning the line, and restore it on
640c8776
SM
3417 exit if none of the characters scanned was an exact match.
3418 Fixes vertical-motion and pos-visible-in-window-p under bidi redisplay
a9269c18
EZ
3419 when exact match is impossible due to invisible text, and the
3420 lines are truncated.
3421
a258d627
JD
34222011-07-23 Jan Djärv <jan.h.d@swipnet.se>
3423
3424 * nsterm.m (initFrameFromEmacs): Set NSTitledWindowMask in styleMask
3425 for OSX >= 10.7.
3426
b6d5a689
EZ
34272011-07-22 Eli Zaretskii <eliz@gnu.org>
3428
0f74f785
EZ
3429 Fix a significant slow-down of cursor motion with C-n, C-p,
3430 C-f/C-b, and C-v/M-v that couldn't keep up with keyboard
3431 auto-repeat under bidi redisplay in fontified buffers.
b6d5a689 3432 * xdisp.c (compute_stop_pos_backwards): New function.
b6d5a689
EZ
3433 (next_element_from_buffer): Call compute_stop_pos_backwards to
3434 find a suitable prev_stop when we find ourselves before
0f74f785
EZ
3435 base_level_stop.
3436 (reseat): Don't look for prev_stop, as that could mean a very long
3437 run.
3438 <cached_disp_pos, cached_disp_buffer, cached_disp_modiff>
3439 <cached_disp_overlay_modiff>: Cache for last found display string
3440 position.
551918c1 3441 (compute_display_string_pos): Return the cached position if asked
0f74f785
EZ
3442 about the same buffer in the same area of character positions, and
3443 the buffer wasn't changed since the time the display string
3444 position was cached.
551918c1 3445
b2d0c91a
EZ
34462011-07-22 Eli Zaretskii <eliz@gnu.org>
3447
3448 * xdisp.c (rows_from_pos_range): Don't ignore glyphs whose object
3449 is an integer, which is important for empty lines. (Bug#9149)
3450
043604ee
CY
34512011-07-22 Chong Yidong <cyd@stupidchicken.com>
3452
3453 * frame.c (Fmodify_frame_parameters): In tty case, update the
3454 default face if necessary (Bug#4238).
3455
da4adb04
CY
34562011-07-21 Chong Yidong <cyd@stupidchicken.com>
3457
3458 * editfns.c (Fstring_to_char): No need to explain what a character
3459 is in the docstring (Bug#6576).
3460
9abd0532
LMI
34612011-07-20 Lars Magne Ingebrigtsen <larsi@gnus.org>
3462
3463 * xml.c (parse_region): Make sure we always return a tree.
3464
36881d16
HK
34652011-07-20 HAMANO Kiyoto <khiker.mail@gmail.com>
3466
3467 * xml.c (parse_region): If a document contains only comments,
3468 return that, too.
3469
1e98674d
LMI
34702011-07-20 Lars Magne Ingebrigtsen <larsi@gnus.org>
3471
3472 * xml.c (make_dom): Return comments, too.
3473
590bd467
PE
34742011-07-19 Paul Eggert <eggert@cs.ucla.edu>
3475
3476 Port to OpenBSD.
3477 See http://lists.gnu.org/archive/html/emacs-devel/2011-07/msg00688.html
3478 and the surrounding thread.
3479 * minibuf.c (read_minibuf_noninteractive): Rewrite to use getchar
3480 rather than fgets, and retry after EINTR. Otherwise, 'emacs
3481 --batch -f byte-compile-file' fails on OpenBSD if an inactivity
3482 timer goes off.
3483 * s/openbsd.h (BROKEN_SIGIO): Define.
3484 * unexelf.c (unexec) [__OpenBSD__]:
3485 Don't update the .mdebug section of the Alpha COFF symbol table.
3486
f41628b2
LMI
34872011-07-19 Lars Magne Ingebrigtsen <larsi@gnus.org>
3488
3489 * lread.c (syms_of_lread): Clarify when `lexical-binding' is used
3490 (bug#8460).
3491
b59b67c5
PE
34922011-07-18 Paul Eggert <eggert@cs.ucla.edu>
3493
15e3a074
PE
3494 * fileio.c (Fcopy_file) [!MSDOS]: Tighten created file's mask.
3495 This fixes some race conditions on the permissions of any newly
3496 created file.
3497
41bed37d
PE
3498 * alloc.c (valid_pointer_p): Use pipe, not open.
3499 This fixes some permissions issues when debugging.
3500
b59b67c5
PE
3501 * fileio.c (Fcopy_file): Adjust mode if fchown fails. (Bug#9002)
3502 If fchown fails to set both uid and gid, try to set just gid,
3503 as that is sometimes allowed. Adjust the file's mode to eliminate
3504 setuid or setgid bits that are inappropriate if fchown fails.
3505
925a6be7
SM
35062011-07-18 Stefan Monnier <monnier@iro.umontreal.ca>
3507
3508 * xdisp.c (next_element_from_string, next_element_from_buffer): Use EQ
3509 to compare Lisp_Objects.
3510 * gnutls.c (syms_of_gnutls): Rename Vgnutls_log_level to
3511 global_gnutls_log_level, don't mistake it for a Lisp_Object.
3512 (init_gnutls_functions, emacs_gnutls_handle_error): Fix up uses.
3513
52968808
AS
35142011-07-17 Andreas Schwab <schwab@linux-m68k.org>
3515
0a6a104b
AS
3516 * lread.c (read_integer): Unread even EOF character.
3517 (read1): Likewise. Properly record start position of symbol.
3518
52968808
AS
3519 * lread.c (read1): Read `#:' as empty uninterned symbol if no
3520 symbol character follows.
3521
9e381cdd
PE
35222011-07-17 Paul Eggert <eggert@cs.ucla.edu>
3523
3524 * fileio.c (Fcopy_file): Pacify gcc re fchown. (Bug#9002)
3525 This works around a problem with the previous change to Fcopy_file.
3526 Recent glibc declares fchown with __attribute__((warn_unused_result)),
3527 and without this change, GCC might complain about discarding
3528 fchown's return value.
3529
b5641435
JB
35302011-07-16 Juanma Barranquero <lekktu@gmail.com>
3531
3532 * makefile.w32-in (GLOBAL_SOURCES): Add gnutls.c (followup to bug#9059).
3533
a8031457
PE
35342011-07-16 Paul Eggert <eggert@cs.ucla.edu>
3535
3536 * fileio.c (Fcopy_file): Don't diagnose fchown failures. (Bug#9002)
3537
dd889327
LMI
35382011-07-16 Lars Magne Ingebrigtsen <larsi@gnus.org>
3539
750c33f7
LMI
3540 * gnutls.c (syms_of_gnutls): Define `gnutls-log-level' here, since
3541 it's used from the C level.
3542
dd889327
LMI
3543 * process.c: Use the same condition for POLL_FOR_INPUT in both
3544 keyboard.c and process.c (bug#1858).
3545
87e86684
LM
35462011-07-09 Lawrence Mitchell <wence@gmx.li>
3547
3548 * gnutls.c (Qgnutls_bootprop_min_prime_bits): New variable.
3549 (Fgnutls_boot): Use it.
3550
64348f40
AS
35512011-07-15 Andreas Schwab <schwab@linux-m68k.org>
3552
3553 * doc.c (Fsubstitute_command_keys): Revert last change.
3554
1d698799
LMI
35552011-07-15 Lars Magne Ingebrigtsen <larsi@gnus.org>
3556
f863868c
LMI
3557 * doc.c (Fsubstitute_command_keys): Clarify that \= really only
3558 quotes the next character, and doesn't affect other longer
3559 sequences (bug#8935).
3560
1d698799
LMI
3561 * lread.c (syms_of_lread): Clarify that is isn't only
3562 `eval-buffer' and `eval-defun' that's affected by
3563 `lexical-binding' (bug#8460).
3564
aa4b6df6
EZ
35652011-07-15 Eli Zaretskii <eliz@gnu.org>
3566
3567 * xdisp.c (move_it_in_display_line_to): Fix vertical motion with
6b02f655 3568 bidi redisplay when a line includes both an image and is truncated.
aa4b6df6 3569
5d856da6
PE
35702011-07-14 Paul Eggert <eggert@cs.ucla.edu>
3571
ad6042bb
PE
3572 Fix minor problems found by static checking.
3573 * bidi.c (bidi_cache_size): Now EMACS_INT, not size_t.
3574 (elsz): Now a signed constant, not a size_t var. We prefer signed
3575 types to unsigned, to avoid integer comparison confusion. Without
3576 this change, GCC 4.6.1 with -Wunsafe-loop-optimizations complains
3577 "cannot optimize loop, the loop counter may overflow", a symptom
3578 of the confusion.
f00bbb22 3579 * indent.c (Fvertical_motion): Mark locals as initialized.
5d856da6
PE
3580 * xdisp.c (reseat_to_string): Fix pointer signedness issue.
3581
6468f31c
LMI
35822011-07-14 Lars Magne Ingebrigtsen <larsi@gnus.org>
3583
49080b10
LMI
3584 * search.c (Fre_search_backward): Mention `case-fold-search' in
3585 all the re_search_* functions (bug#8138).
3586
6468f31c
LMI
3587 * keyboard.c (Fopen_dribble_file): Document when the file is
3588 closed (bug#8056).
3589
c965adc5
EZ
35902011-07-14 Eli Zaretskii <eliz@gnu.org>
3591
df9733bf
EZ
3592 * bidi.c (bidi_dump_cached_states): Fix format of displaying
3593 bidi_cache_idx.
3594
0bb23927
EZ
3595 Support bidi reordering of display and overlay strings.
3596 * xdisp.c (compute_display_string_pos)
3597 (compute_display_string_end): Accept additional argument STRING.
3598 (init_iterator, reseat_1): Initialize bidi_it->string.s to NULL.
3599 (reseat_to_string): Initialize bidi_it->string.s and
3600 bidi_it->string.schars.
3601 (Fcurrent_bidi_paragraph_direction): Initialize itb.string.s to
640c8776
SM
3602 NULL (avoids a crash in bidi_paragraph_init).
3603 Initialize itb.string.lstring.
0bb23927
EZ
3604 (init_iterator): Call bidi_init_it only of a valid
3605 buffer position was specified. Initialize paragraph_embedding to
3606 L2R.
3607 (reseat_to_string): Initialize the bidi iterator.
3608 (display_string): If we need to ignore text properties of
3609 LISP_STRING, set IT->stop_charpos to IT->end_charpos. (The
3610 original value of -1 will not work with bidi.)
3611 (compute_display_string_pos): First arg is now struct
3612 `text_pos *'; all callers changed. Support display properties on
3613 Lisp strings.
3614 (compute_display_string_end): Support display properties on Lisp
3615 strings.
3616 (init_iterator, reseat_1, reseat_to_string): Initialize the
3617 string.bufpos member to 0 (zero, for compatibility with IT_CHARPOS
3618 when iterating on a string not from display properties).
640c8776
SM
3619 (compute_display_string_pos, compute_display_string_end):
3620 Fix calculation of the object to scan. Fixes an error when using
0bb23927
EZ
3621 arrow keys.
3622 (next_element_from_buffer): Don't abort when IT_CHARPOS is before
640c8776
SM
3623 base_level_stop; instead, set base_level_stop to BEGV.
3624 Fixes crashes in vertical-motion.
0bb23927
EZ
3625 (next_element_from_buffer): Improve commentary for when
3626 the iterator is before prev_stop.
3627 (init_iterator): Initialize bidi_p from the default value of
3628 bidi-display-reordering, not from buffer-local value. Use the
3629 buffer-local value only if initializing for buffer iteration.
3630 (handle_invisible_prop): Support invisible properties on strings
3631 that are being bidi-reordered.
3632 (set_iterator_to_next): Support bidi reordering of C strings and
3633 Lisp strings.
3634 (next_element_from_string): Support bidi reordering of Lisp
3635 strings.
3636 (handle_stop_backwards): Support Lisp strings as well.
640c8776
SM
3637 (display_string): Support display of R2L glyph rows.
3638 Use IT_STRING_CHARPOS when displaying from a Lisp string.
0bb23927
EZ
3639 (init_iterator): Don't initialize it->bidi_p for strings
3640 here.
3641 (reseat_to_string): Initialize it->bidi_p for strings here.
3642 (next_element_from_string, next_element_from_c_string)
3643 (next_element_from_buffer): Add xassert's for correspondence
3644 between IT's object being iterated and it->bidi_it.string
3645 structure.
3646 (face_before_or_after_it_pos): Support bidi iteration.
3647 (next_element_from_c_string): Handle the case of the first string
3648 character that is not the first one in the visual order.
3649 (get_visually_first_element): New function, refactored from common
3650 parts of next_element_from_buffer, next_element_from_string, and
3651 next_element_from_c_string.
3652 (tool_bar_lines_needed, redisplay_tool_bar)
3653 (display_menu_bar): Force left-to-right direction. Add a FIXME
3654 comment for making that be controlled by a user option.
3655 (push_it, pop_it): Save and restore the state of the
3656 bidi iterator. Save and restore the bidi_p flag.
3657 (pop_it): Iterate out of display property for string iteration as
3658 well.
3659 (iterate_out_of_display_property): Support iteration over strings.
3660 (handle_single_display_spec): Set up it->bidi_it for iteration
3661 over a display string, and call bidi_init_it.
3662 (handle_single_display_spec, next_overlay_string)
3663 (get_overlay_strings_1, push_display_prop): Set up the bidi
3664 iterator for displaying display or overlay strings.
3665 (forward_to_next_line_start): Don't use the shortcut if
3666 bidi-iterating.
3667 (back_to_previous_visible_line_start): If handle_display_prop
3668 pushed the iterator stack, restore the internal state of the bidi
3669 iterator by calling bidi_pop_it same number of times.
3670 (reseat_at_next_visible_line_start): If ON_NEWLINE_P is non-zero,
3671 and we are bidi-iterating, don't decrement the iterator position;
3672 instead, set the first_elt flag in the bidi iterator, to produce
3673 the same effect.
3674 (reseat_1): Remove redundant setting of string_from_display_prop_p.
3675 (push_display_prop): xassert that we are iterating a buffer.
3676 (push_it, pop_it): Save and restore paragraph_embedding member.
3677 (handle_single_display_spec, next_overlay_string)
3678 (get_overlay_strings_1, reseat_1, reseat_to_string)
3679 (push_display_prop): Set up the `unibyte' member of bidi_it.string
3680 correctly. Don't assume unibyte strings are not bidi-reordered.
3681 (compute_display_string_pos)
3682 (compute_display_string_end): Fix handling the case of C string.
3683 (push_it, pop_it): Save and restore from_disp_prop_p.
3684 (handle_single_display_spec, push_display_prop): Set the
3685 from_disp_prop_p flag.
3686 (get_overlay_strings_1): Reset the from_disp_prop_p flag.
3687 (pop_it): Call iterate_out_of_display_property only if we are
3688 popping after iteration over a string that came from a display
3689 property. Fix a typo in popping stretch info. Add an assertion
3690 for verifying that the iterator position is in sync with the bidi
3691 iterator.
3692 (handle_single_display_spec, get_overlay_strings_1)
3693 (push_display_prop): Fix initialization of paragraph direction for
3694 string when that of the parent object is not yet determined.
3695 (reseat_1): Call bidi_init_it to resync the bidi
3696 iterator with IT's position. (Bug#7616)
3697 (find_row_edges): If ROW->start.pos gives position
3698 smaller than min_pos, use it as ROW->minpos. (Bug#7616)
3699 (handle_stop, back_to_previous_visible_line_start, reseat_1):
3700 Reset the from_disp_prop_p flag.
3701 (SAVE_IT, RESTORE_IT): New macros.
3702 (pos_visible_p, face_before_or_after_it_pos)
3703 (back_to_previous_visible_line_start)
3704 (move_it_in_display_line_to, move_it_in_display_line)
3705 (move_it_to, move_it_vertically_backward, move_it_by_lines)
3706 (try_scrolling, redisplay_window, display_line): Use them when
3707 saving a temporary copy of the iterator and restoring it back.
3708 (back_to_previous_visible_line_start, reseat_1)
3709 (init_iterator): Empty the bidi cache "stack".
3710 (move_it_in_display_line_to): If iterator ended up at
3711 EOL, but we never saw any buffer positions smaller than
3712 to_charpos, return MOVE_POS_MATCH_OR_ZV. Fixes vertical cursor
3713 motion in bidi-reordered lines.
3714 (move_it_in_display_line_to): Record prev_method and prev_pos
3715 immediately before the call to set_iterator_to_next. Fixes cursor
3716 motion in bidi-reordered lines with stretch glyphs and strings
3717 displayed in margins. (Bug#8133) (Bug#8867)
3718 Return MOVE_POS_MATCH_OR_ZV only if iterator position is past
3719 TO_CHARPOS.
640c8776
SM
3720 (pos_visible_p): Support positions in bidi-reordered lines.
3721 Save and restore bidi cache.
0bb23927
EZ
3722
3723 * bidi.c (bidi_level_of_next_char): clen should be EMACS_NT, not int.
3724 (bidi_paragraph_info): Delete unused struct.
3725 (bidi_cache_idx, bidi_cache_last_idx): Declare EMACS_INT.
3726 (bidi_cache_start): New variable.
3727 (bidi_cache_reset): Reset bidi_cache_idx to bidi_cache_start, not
3728 to zero.
3729 (bidi_cache_fetch_state, bidi_cache_search)
3730 (bidi_cache_find_level_change, bidi_cache_iterator_state)
3731 (bidi_cache_find, bidi_peek_at_next_level)
3732 (bidi_level_of_next_char, bidi_find_other_level_edge)
3733 (bidi_move_to_visually_next): Compare cache index with
3734 bidi_cache_start rather than with zero.
3735 (bidi_fetch_char): Accept new argument STRING; all callers
3736 changed. Support iteration over a string. Support strings with
3737 display properties. Support unibyte strings. Fix the type of
3738 `len' according to what STRING_CHAR_AND_LENGTH expects.
3739 (bidi_paragraph_init, bidi_resolve_explicit_1)
3740 (bidi_resolve_explicit, bidi_resolve_weak)
640c8776
SM
3741 (bidi_level_of_next_char, bidi_move_to_visually_next):
3742 Support iteration over a string.
0bb23927
EZ
3743 (bidi_set_sor_type, bidi_resolve_explicit_1)
3744 (bidi_resolve_explicit, bidi_type_of_next_char): ignore_bn_limit
3745 can now be zero (for strings); special values 0 and -1 were
3746 changed to -1 and -2, respectively.
3747 (bidi_char_at_pos): New function.
3748 (bidi_paragraph_init, bidi_resolve_explicit, bidi_resolve_weak):
3749 Call it instead of FETCH_MULTIBYTE_CHAR.
3750 (bidi_move_to_visually_next): Abort if charpos or bytepos were not
3751 initialized to valid values.
3752 (bidi_init_it): Don't initialize charpos and bytepos with invalid
3753 values.
3754 (bidi_level_of_next_char): Allow the sentinel "position" to pass
3755 the test for valid cached positions. Fix the logic for looking up
3756 the sentinel state in the cache. GCPRO the Lisp string we are
3757 iterating.
3758 (bidi_push_it, bidi_pop_it): New functions.
3759 (bidi_initialize): Initialize the bidi cache start stack pointer.
3760 (bidi_cache_ensure_space): New function, refactored from part of
3761 bidi_cache_iterator_state. Don't assume the required size is just
3762 one BIDI_CACHE_CHUNK away.
3763 (bidi_cache_start_stack, bidi_push_it): Use IT_STACK_SIZE.
3764 (bidi_count_bytes, bidi_char_at_pos): New functions.
3765 (bidi_cache_search): Don't assume bidi_cache_last_idx is
3766 always valid if bidi_cache_idx is valid.
3767 (bidi_cache_find_level_change): xassert that bidi_cache_last_idx
3768 is valid if it's going to be used.
3769 (bidi_shelve_cache, bidi_unshelve_cache): New functions.
3770 (bidi_cache_fetch_state, bidi_cache_search)
c965adc5
EZ
3771 (bidi_cache_find_level_change, bidi_cache_ensure_space)
3772 (bidi_cache_iterator_state, bidi_cache_find)
640c8776
SM
3773 (bidi_find_other_level_edge, bidi_cache_start_stack):
3774 All variables related to cache indices are now EMACS_INT.
c965adc5 3775
0bb23927
EZ
3776 * dispextern.h (struct bidi_string_data): New structure.
3777 (struct bidi_it): New member `string'. Make flag members be 1-bit
3778 fields, and put them last in the struct.
640c8776
SM
3779 (compute_display_string_pos, compute_display_string_end):
3780 Update prototypes.
0bb23927
EZ
3781 (bidi_push_it, bidi_pop_it): Add prototypes.
3782 (struct iterator_stack_entry): New members bidi_p,
3783 paragraph_embedding, and from_disp_prop_p.
3784 (struct it): Member bidi_p is now a bit field 1 bit wide.
640c8776
SM
3785 (bidi_shelve_cache, bidi_unshelve_cache):
3786 Declare prototypes.
0bb23927
EZ
3787
3788 * .gdbinit (xvectype, xvector, xcompiled, xchartable, xboolvector)
3789 (xpr, xfont, xbacktrace): Use "header.size" when accessing vectors
3790 and vector-like objects.
3791
3792 * dispnew.c (buffer_posn_from_coords): Save and restore the bidi
3793 cache around display iteration.
3794
3795 * window.c (Fwindow_end, window_scroll_pixel_based)
3796 (displayed_window_lines, Frecenter): Save and restore the bidi
3797 cache around display iteration.
3798
3bbd2265
LMI
37992011-07-14 Lars Magne Ingebrigtsen <larsi@gnus.org>
3800
3801 * editfns.c (Fdelete_region): Clarify the use of the named
3802 parameters (bug#6788).
3803
adc47434
MR
38042011-07-14 Martin Rudalics <rudalics@gmx.at>
3805
3806 * indent.c (Fvertical_motion): Set and restore w->pointm when
3807 saving and restoring the window's buffer (Bug#9006).
3808
837c31f8
LMI
38092011-07-13 Lars Magne Ingebrigtsen <larsi@gnus.org>
3810
3811 * editfns.c (Fstring_to_char): Clarify just what is returned
3812 (bug#6576). Text by Eli Zaretskii.
3813
ac389d0c
JB
38142011-07-13 Juanma Barranquero <lekktu@gmail.com>
3815
3816 * gnutls.c (init_gnutls_functions): Honor gnutls_log_level (bug#9059).
3817
0be0ce47
EZ
38182011-07-13 Eli Zaretskii <eliz@gnu.org>
3819
3820 * buffer.c (mmap_find): Fix a typo.
3821
cd18e7e3
JB
38222011-07-13 Johan Bockgård <bojohan@gnu.org>
3823
3824 Fix execution of x selection hooks.
3825 * xselect.c (Qx_lost_selection_functions)
3826 (Qx_sent_selection_functions): New vars.
3827 (syms_of_xselect): DEFSYM them.
3828 (x_handle_selection_request): Pass Qx_sent_selection_functions
3829 rather than Vx_sent_selection_functions to Frun_hook_with_args.
3830 (x_handle_selection_clear,x_clear_frame_selections):
3831 Pass Qx_lost_selection_functions rather than
3832 Vx_lost_selection_functions to Frun_hook_with_args.
3833
47ea7f44
PE
38342011-07-13 Paul Eggert <eggert@cs.ucla.edu>
3835
ac389d0c 3836 * buffer.c (Fget_buffer_create): Initialize inhibit_shrinking.
2941c447
PE
3837 The old code sometimes used this field without initializing it.
3838
47ea7f44
PE
3839 * alloc.c (gc_sweep): Don't read past end of array.
3840 In theory, the old code could also have corrupted Emacs internals,
3841 though it'd be very unlikely.
3842
bc985c87
AS
38432011-07-12 Andreas Schwab <schwab@linux-m68k.org>
3844
3845 * character.c (Fcharacterp): Don't advertise optional ignored
ac389d0c 3846 argument. (Bug#4026)
bc985c87 3847
0cf34688
LMI
38482011-07-12 Lars Magne Ingebrigtsen <larsi@gnus.org>
3849
b3dadd76
LMI
3850 * keymap.c (syms_of_keymap): Clarify that "modifier" is "modifier
3851 key" (bug#4257).
3852
0cf34688
LMI
3853 * window.c (Fset_window_start): Doc fix (bug#4199).
3854 (Fset_window_hscroll): Ditto.
3855
270768cd
PE
38562011-07-12 Paul Eggert <eggert@cs.ucla.edu>
3857
077e3dda 3858 Fix minor new problems caught by GCC 4.6.1.
270768cd 3859 * term.c (init_tty): Remove unused local.
490011a6 3860 * xsettings.c (store_monospaced_changed): Define this function only
077e3dda 3861 if (defined HAVE_GSETTINGS || defined HAVE_GCONF), as it's
490011a6 3862 not used otherwise.
270768cd 3863
b1f58454
CY
38642011-07-12 Chong Yidong <cyd@stupidchicken.com>
3865
3866 * xdisp.c (Vresize_mini_windows): Minor doc fix (Bug#3300).
3867
22b9578d
LMI
38682011-07-11 Lars Magne Ingebrigtsen <larsi@gnus.org>
3869
6e70ab07
LMI
3870 * xdisp.c (syms_of_xdisp): Make it explicit that the mini-windows
3871 are the mini-buffer and the echo area (bug#3320).
3872
22b9578d
LMI
3873 * term.c (init_tty): Remove support for supdup, c10 and perq
3874 terminals, which are no longer supported (bug#1482).
3875
8974cc9f
JB
38762011-07-10 Johan Bockgård <bojohan@gnu.org>
3877
3878 * xdisp.c (Ftool_bar_lines_needed): Fix WINDOWP check.
3879
a560d974
JD
38802011-07-10 Jan Djärv <jan.h.d@swipnet.se>
3881
3882 * xmenu.c (menu_highlight_callback): Only pass frame to show_help_event
3883 for non-popups (Bug#3642).
3884
1dae0f0a
AS
38852011-07-10 Andreas Schwab <schwab@linux-m68k.org>
3886
268c2c36 3887 * alloc.c (reset_malloc_hooks): Protoize.
1dae0f0a 3888 * buffer.c (mmap_init, mmap_find, mmap_free_1, mmap_enlarge)
268c2c36
AS
3889 (mmap_set_vars, mmap_alloc, mmap_free, mmap_realloc): Likewise.
3890 * cm.c (losecursor): Likewise.
1dae0f0a
AS
3891 * data.c (fmod): Likewise.
3892 * dispnew.c (swap_glyphs_in_rows): Likewise.
3893 * emacs.c (memory_warning_signal): Likewise.
3894 * floatfns.c (float_error): Likewise.
3895 * font.c (check_gstring, check_otf_features, otf_tag_symbol)
3896 (otf_open, font_otf_capability, generate_otf_features)
3897 (font_otf_DeviceTable, font_otf_ValueRecord, font_otf_Anchor):
3898 Likewise.
3899 * image.c (pbm_read_file): Likewise.
3900 * indent.c (string_display_width): Likewise.
3901 * intervals.c (check_for_interval, search_for_interval)
3902 (inc_interval_count, count_intervals, root_interval)
3903 (adjust_intervals_for_insertion, make_new_interval): Likewise.
3904 * lread.c (defalias): Likewise.
268c2c36 3905 * ralloc.c (r_alloc_check): Likewise.
1dae0f0a
AS
3906 * regex.c (set_image_of_range_1, set_image_of_range)
3907 (regex_grow_registers): Likewise.
3908 * sysdep.c (strerror): Likewise.
3909 * termcap.c (valid_filename_p, tprint, main): Likewise.
3910 * tparam.c (main): Likewise.
3911 * unexhp9k800.c (run_time_remap, save_data_space)
3912 (update_file_ptrs, read_header, write_header, calculate_checksum)
3913 (copy_file, copy_rest, display_header): Likewise.
3914 * widget.c (mark_shell_size_user_specified, create_frame_gcs):
3915 Likewise.
3916 * xdisp.c (check_it): Likewise.
3917 * xfaces.c (register_color, unregister_color, unregister_colors):
3918 Likewise.
3919 * xfns.c (print_fontset_result): Likewise.
3920 * xrdb.c (member, fatal, main): Likewise.
3921
99033785
PE
39222011-07-10 Paul Eggert <eggert@cs.ucla.edu>
3923
3924 Fix minor problems found by static checking (Bug#9031).
3925 * chartab.c (char_table_set_range, map_sub_char_table):
3926 Remove unused locals.
3927 (uniprop_table): Now static.
3928 * composite.c (_work_char): Remove unused static var.
3929
9cb2ac56
JB
39302011-07-09 Juanma Barranquero <lekktu@gmail.com>
3931
3932 * chartab.c (uniprop_table_uncompress): Remove unused local variable.
3933
f25661f0
JD
39342011-07-09 Jan Djärv <jan.h.d@swipnet.se>
3935
3936 * gtkutil.c (qttip_cb): Remove code without function.
3937
8278c4fe
EZ
39382011-07-09 Eli Zaretskii <eliz@gnu.org>
3939
3940 * w32.c (pthread_sigmask): New stub.
3941
1692ae2d 39422011-07-08 Paul Eggert <eggert@cs.ucla.edu>
123403e4 3943
8a6ebd58 3944 Use pthread_sigmask, not sigprocmask (Bug#9010).
123403e4
PE
3945 sigprocmask is portable only for single-threaded applications, and
3946 Emacs can be multi-threaded when it uses GTK.
1301ac26
PE
3947 * Makefile.in (LIB_PTHREAD_SIGMASK): New macro.
3948 (LIBES): Use it.
3949 * callproc.c (Fcall_process):
3950 * process.c (create_process):
3951 * sysdep.c (sys_sigblock, sys_sigunblock, sys_sigsetmask):
3952 Use pthread_sigmask, not sigprocmask.
123403e4 3953
1b854618
JD
39542011-07-08 Jan Djärv <jan.h.d@swipnet.se>
3955
3956 * gtkutil.c (qttip_cb): Set line wrap to FALSE for tooltip widget.
3957 (xg_prepare_tooltip): Revert text in x->ttip_lbl, margins was
3958 wrong (Bug#8591).
3959
3fe4b549
JD
39602011-07-08 Jan Djärv <jan.h.d@swipnet.se>
3961
0ce7e563
JD
3962 * gtkutil.c (xg_prepare_tooltip): Fix indentation and comment.
3963 Put text in x->ttip_lbl instead of gtk_tooltip_set_text (Bug#8591).
3964 (xg_hide_tooltip): Fix comment.
3965
3fe4b549
JD
3966 * nsterm.m (initFrameFromEmacs): Don't use ns_return_types
3967 in registerServicesMenuSendTypes.
3968 (validRequestorForSendType): Don't check ns_return_types.
3969
3970 * nsfns.m (Fx_open_connection): Put NSStringPboardType into
3971 ns_return_type.
3972
5df75e47
JR
39732011-07-08 Jason Rumney <jasonr@gnu.org>
3974
22610910
JR
3975 * w32term.c (x_make_frame_visible): Use SH_SHOWNORMAL rather than
3976 SH_SHOW for hidden windows (Bug#5482).
3977
5df75e47
JR
3978 * w32fns.c (w32_wnd_proc) [WM_TIMER, WM_SET_CURSOR]: Avoid using
3979 frame struct members of non-existent frames (Bug#6284).
3980
699c10bd
JD
39812011-07-08 Jan Djärv <jan.h.d@swipnet.se>
3982
4393663b
JD
3983 * nsterm.m (keyDown): Call to wantsToDelayTextChangeNotifications and
3984 variable firstTime not needed on OSX >= 10.6.
3985 (setPosition): setFloatValue:knobProportion: is deprecated on OSX
3986 >= 10.5. Use setKnobProportion, setDoubleValue.
3987
3988 * nsterm.h (MAC_OS_X_VERSION_10_3, MAC_OS_X_VERSION_10_4)
3989 (MAC_OS_X_VERSION_10_5): Define if not defined.
3990 (EmacsView, EmacsTooltip): Implements NSWindowDelegate on OSX >= 10.6.
3991 (EmacsMenu): Implements NSMenuDelegate on OSX >= 10.6.
3992 (EmacsToolbar): Implements NSToolbarDelegate on OSX >= 10.6.
3993
3994 * nsselect.m (ns_string_from_pasteboard): Don't use deprecated methods
3995 cString and lossyCString on OSX >= 10.4
3996
58179cce 3997 * nsmenu.m (fillWithWidgetValue): Don't use deprecated method
4393663b
JD
3998 sizeToFit on OSX >= 10.2.
3999
4000 * nsimage.m (allocInitFromFile): Don't use deprecated method
4001 bestRepresentationForDevice on OSX >= 10.6.
4002
4003 * nsfns.m (check_ns_display_info): Cast to long and use %ld in error
4004 to avoid warning.
4005
4006 * emacs.c: Declare unexec_init_emacs_zone.
4007
a63e0781
JD
4008 * nsgui.h: Fix compiler warning about gnulib redefining verify.
4009
699c10bd
JD
4010 * nsselect.m (ns_get_local_selection): Change to extern (Bug#8842).
4011
4012 * nsmenu.m (ns_update_menubar): Remove useless setDelegate call
4013 on svcsMenu (Bug#8842).
4014
4015 * nsfns.m (Fx_open_connection): Remove NSStringPboardType from
4016 ns_return_types.
4017 (Fns_list_services): Just return Qnil on 10.6, code not working there.
4018
4019 * nsterm.m (QUTF8_STRING): Declare.
4020 (initFrameFromEmacs): Call registerServicesMenuSendTypes.
4021 (validRequestorForSendType): Return type is (id).
4022 Change indexOfObjectIdenticalTo to indexOfObject.
4023 Check if we have local selection before returning self (Bug#8842).
4024 (writeSelectionToPasteboard): Put local selection into paste board
4025 if we have a local selection (Bug#8842).
4026 (syms_of_nsterm): DEFSYM QUTF8_STRING.
4027
4028 * nsterm.h (MAC_OS_X_VERSION_10_6): Define here instead of nsterm.m.
4029 (ns_get_local_selection): Declare.
4030
54e10184
LMI
40312011-07-07 Lars Magne Ingebrigtsen <larsi@gnus.org>
4032
9888ff71
LMI
4033 * keymap.c (describe_map_tree): Don't insert a double newline at
4034 the end of the buffer (bug#1169) and return whether we inserted
4035 something.
4036
54e10184
LMI
4037 * callint.c (Fcall_interactively): Change "reading args" to
4038 "providing args" to try to clarify what it does (bug#1010).
4039
15fa4783
KH
40402011-07-07 Kenichi Handa <handa@m17n.org>
4041
4042 * composite.c (composition_compute_stop_pos): Ignore a static
4043 composition starting before CHARPOS (Bug#8915).
4044
4045 * xdisp.c (handle_composition_prop): Likewise.
4046
a8815b00
EZ
40472011-07-07 Eli Zaretskii <eliz@gnu.org>
4048
4049 * term.c (produce_glyphs) <xassert>: Allow IT_GLYPHLESS in it->what.
4050 (Bug#9015)
4051
ef7b981d 40522011-07-07 Kenichi Handa <handa@m17n.org>
c805dec0
KH
4053
4054 * character.h (unicode_category_t): New enum type.
4055
4056 * chartab.c (uniprop_decoder_t, uniprop_encoder_t): New types.
4057 (Qchar_code_property_table): New variable.
4058 (UNIPROP_TABLE_P, UNIPROP_GET_DECODER)
4059 (UNIPROP_COMPRESSED_FORM_P): New macros.
4060 (char_table_ascii): Uncompress the compressed values.
4061 (sub_char_table_ref): New arg is_uniprop. Callers changed.
4062 Uncompress the compressed values.
ac389d0c 4063 (sub_char_table_ref_and_range): Likewise.
c805dec0
KH
4064 (char_table_ref_and_range): Uncompress the compressed values.
4065 (sub_char_table_set): New arg is_uniprop. Callers changed.
4066 Uncompress the compressed values.
4067 (sub_char_table_set_range): Args changed. Callers changed.
4068 (char_table_set_range): Adjuted for the above change.
4069 (map_sub_char_table): Delete args default_val and parent. Add arg
4070 top. Give decoded values to a Lisp function.
640c8776 4071 (map_char_table): Adjust for the above change. Give decoded
c805dec0
KH
4072 values to a Lisp function. Gcpro more variables.
4073 (uniprop_table_uncompress)
4074 (uniprop_decode_value_run_length): New functions.
4075 (uniprop_decoder, uniprop_decoder_count): New variables.
4076 (uniprop_get_decoder, uniprop_encode_value_character)
4077 (uniprop_encode_value_run_length, uniprop_encode_value_numeric):
4078 New functions.
4079 (uniprop_encoder, uniprop_encoder_count): New variables.
4080 (uniprop_get_encoder, uniprop_table)
4081 (Funicode_property_table_internal, Fget_unicode_property_internal)
4082 (Fput_unicode_property_internal): New functions.
4083 (syms_of_chartab): DEFSYM Qchar_code_property_table, defsubr
4084 Sunicode_property_table_internal, Sget_unicode_property_internal,
5e617bc2 4085 and Sput_unicode_property_internal. Defvar_lisp
c805dec0
KH
4086 char-code-property-alist.
4087
640c8776 4088 * composite.c (CHAR_COMPOSABLE_P): Adjust for the change of
c805dec0
KH
4089 Vunicode_category_table.
4090
640c8776 4091 * font.c (font_range): Adjust for the change of
c805dec0
KH
4092 Vunicode_category_table.
4093
76b397fb
DN
40942011-07-07 Dan Nicolaescu <dann@ics.uci.edu>
4095
4096 * m/iris4d.h: Remove file, move contents ...
4097 * s/irix6-5.h: ... here.
4098
22b4128e
PE
40992011-07-06 Paul Eggert <eggert@cs.ucla.edu>
4100
4101 Remove unportable assumption about struct layout (Bug#8884).
8a5c77bb
PE
4102 * alloc.c (mark_buffer):
4103 * buffer.c (reset_buffer_local_variables, Fbuffer_local_variables)
4104 (clone_per_buffer_values): Don't assume that
22b4128e
PE
4105 sizeof (struct buffer) is a multiple of sizeof (Lisp_Object).
4106 This isn't true in general, and it's particularly not true
4107 if Emacs is configured with --with-wide-int.
4108 * buffer.h (FIRST_FIELD_PER_BUFFER, LAST_FIELD_PER_BUFFER):
4109 New macros, used in the buffer.c change.
4110
869795d6
JD
41112011-07-05 Jan Djärv <jan.h.d@swipnet.se>
4112
4113 * xsettings.c: Use both GConf and GSettings if both are available.
4114 (store_config_changed_event): Add comment.
4115 (dpyinfo_valid, store_font_name_changed, map_tool_bar_style)
4116 (store_tool_bar_style_changed): New functions.
5e617bc2 4117 (store_monospaced_changed): Add comment. Call dpyinfo_valid.
869795d6
JD
4118 (struct xsettings): Move font inside HAVE_XFT.
4119 (GSETTINGS_TOOL_BAR_STYLE, GSETTINGS_FONT_NAME): New defines.
640c8776 4120 (GSETTINGS_MONO_FONT): Rename from SYSTEM_MONO_FONT.
869795d6 4121 Move inside HAVE_XFT.
640c8776 4122 (something_changed_gsettingsCB): Rename from something_changedCB.
869795d6
JD
4123 Check for changes in GSETTINGS_TOOL_BAR_STYLE and GSETTINGS_FONT_NAME
4124 also.
4125 (GCONF_TOOL_BAR_STYLE, GCONF_FONT_NAME): New defines.
5e617bc2 4126 (GCONF_MONO_FONT): Rename from SYSTEM_MONO_FONT. Move inside HAVE_XFT.
640c8776 4127 (something_changed_gconfCB): Rename from something_changedCB.
869795d6
JD
4128 Check for changes in GCONF_TOOL_BAR_STYLE and GCONF_FONT_NAME also.
4129 (parse_settings): Move check for font inside HAVE_XFT.
4130 (read_settings, apply_xft_settings): Add comment.
4131 (read_and_apply_settings): Add comment. Call map_tool_bar_style and
4132 store_tool_bar_style_changed. Move check for font inside HAVE_XFT and
4133 call store_font_name_changed.
4134 (xft_settings_event): Add comment.
4135 (init_gsettings): Add comment. Get values for GSETTINGS_TOOL_BAR_STYLE
4136 and GSETTINGS_FONT_NAME. Move check for fonts within HAVE_XFT.
4137 (init_gconf): Add comment. Get values for GCONF_TOOL_BAR_STYLE
4138 and GCONF_FONT_NAME. Move check for fonts within HAVE_XFT.
4139 (xsettings_initialize): Call init_gsettings last.
640c8776
SM
4140 (xsettings_get_system_font, xsettings_get_system_normal_font):
4141 Add comment.
869795d6 4142
d8ed26bd
PE
41432011-07-05 Paul Eggert <eggert@cs.ucla.edu>
4144
4145 Random fixes. E.g., (random) never returned negative values.
4146 * fns.c (Frandom): Use GET_EMACS_TIME for random seed, and add the
4147 subseconds part to the entropy, as that's a bit more random.
4148 Prefer signed to unsigned, since the signedness doesn't matter and
4149 in general we prefer signed. When given a limit, use a
4150 denominator equal to INTMASK + 1, not to VALMASK + 1, because the
4151 latter isn't right if USE_2_TAGS_FOR_INTS.
4152 * sysdep.c (get_random): Return a value in the range 0..INTMASK,
4153 not 0..VALMASK. Don't discard "excess" bits that random () returns.
4154
cabf1cac
SM
41552011-07-04 Stefan Monnier <monnier@iro.umontreal.ca>
4156
4157 * textprop.c (text_property_stickiness):
4158 Obey Vtext_property_default_nonsticky.
4159 (syms_of_textprop): Add `display' to Vtext_property_default_nonsticky.
4160 * w32fns.c (syms_of_w32fns):
4161 * xfns.c (syms_of_xfns): Don't Add `display' since it's there by default.
4162
6e9b2be9
PE
41632011-07-04 Paul Eggert <eggert@cs.ucla.edu>
4164
4165 * fileio.c (barf_or_query_if_file_exists): Use S_ISDIR.
4166 This is more efficient than Ffile_directory_p and avoids a minor race.
4167
90186c68
LMI
41682011-07-04 Lars Magne Ingebrigtsen <larsi@gnus.org>
4169
7c301272
LMI
4170 * buffer.c (Foverlay_put): Say what the return value is
4171 (bug#7835).
4172
c4f2d8d4
LMI
4173 * fileio.c (barf_or_query_if_file_exists): Check first if the file
4174 is a directory before asking whether to use the file name
4175 (bug#7564).
ad637907
LMI
4176 (barf_or_query_if_file_exists): Make the "File is a directory"
4177 error be more correct.
c4f2d8d4 4178
90186c68
LMI
4179 * fns.c (Frequire): Remove the mention of the .gz files, since
4180 that's installation-specific, but keep the mention of
4181 `get-load-suffixes'.
4182
da64016e
PE
41832011-07-04 Paul Eggert <eggert@cs.ucla.edu>
4184
4185 * editfns.c (Fformat_time_string): Don't assume strlen fits in int.
4186 Report string overflow if the output is too long.
4187
7d47b580
JB
41882011-07-04 Juanma Barranquero <lekktu@gmail.com>
4189
a555cb87
JB
4190 * gnutls.c (Fgnutls_boot): Don't mention :verify-error.
4191 (syms_of_gnutls): Remove duplicate DEFSYM for
4192 Qgnutls_bootprop_verify_hostname_error, an error for
4193 Qgnutls_bootprop_verify_error (which is no longer used).
4194
7d47b580
JB
4195 * eval.c (find_handler_clause): Remove parameters `sig' and `data',
4196 unused since 2011-01-26T20:02:07Z!monnier@iro.umontreal.ca. All callers changed.
4197 Also (re)move comments that are misplaced or no longer relevant.
4198
1e49bfab
LMI
41992011-07-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
4200
4201 * callint.c (Finteractive): Clarify the meaning of "@" (bug#8813).
4202
1485f4c0
CY
42032011-07-03 Chong Yidong <cyd@stupidchicken.com>
4204
4205 * xfaces.c (Finternal_merge_in_global_face): Modify the foreground
4206 and background color parameters if they have been changed.
4207
a9ab721e
LMI
42082011-07-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
4209
4210 * editfns.c (Fformat): Clarify the - and 0 flags (bug#6659).
4211
cf7cff57
PE
42122011-07-03 Paul Eggert <eggert@cs.ucla.edu>
4213
2e13213d
PE
4214 * xsettings.c (SYSTEM_FONT): Define only when used.
4215 No need to define when HAVE_GSETTINGS || !HAVE_XFT.
4216
cf7cff57
PE
4217 * keymap.c (access_keymap_1): Now static.
4218
7a8e04f7
CY
42192011-07-02 Chong Yidong <cyd@stupidchicken.com>
4220
4221 * keyboard.c (command_loop_1): If a down-mouse event is unbound,
4222 leave any prefix arg for the up event (Bug#1586).
4223
61352f62
LMI
42242011-07-02 Lars Magne Ingebrigtsen <larsi@gnus.org>
4225
69bb1ef7
LMI
4226 * lread.c (syms_of_lread): Mention single symbols defined by
4227 `defvar' or `defconst' (bug#7154).
4228
61352f62 4229 * fns.c (Frequire): Mention .el.gz files (bug#7314).
7b3747f9 4230 (Frequire): Mention get-load-suffixes.
61352f62 4231
28545e04
MR
42322011-07-02 Martin Rudalics <rudalics@gmx.at>
4233
4234 * window.h (window): Remove clone_number slot.
4235 * window.c (Fwindow_clone_number, Fset_window_clone_number):
4236 Remove.
4237 (make_parent_window, make_window, saved_window)
4238 (Fset_window_configuration, save_window_save): Don't deal with
4239 clone numbers.
4240 * buffer.c (Qclone_number): Remove declaration.
4241 (sort_overlays, overlay_strings): Don't deal with clone numbers.
4242
3349e122
SM
42432011-07-02 Stefan Monnier <monnier@iro.umontreal.ca>
4244
4245 Add multiple inheritance to keymaps.
4246 * keymap.c (Fmake_composed_keymap): New function.
4247 (Fset_keymap_parent): Simplify.
4248 (fix_submap_inheritance): Remove.
4249 (access_keymap_1): New function extracted from access_keymap to handle
4250 embedded parents and handle lists of maps.
4251 (access_keymap): Use it.
4252 (Fkeymap_prompt, map_keymap_internal, map_keymap, store_in_keymap)
4253 (Fcopy_keymap): Handle embedded parents.
4254 (Fcommand_remapping, define_as_prefix): Simplify.
4255 (Fkey_binding): Simplify.
4256 (syms_of_keymap): Move minibuffer-local-completion-map,
4257 minibuffer-local-filename-completion-map,
4258 minibuffer-local-must-match-map, and
4259 minibuffer-local-filename-must-match-map to Elisp.
4260 (syms_of_keymap): Defsubr make-composed-keymap.
4261 * keyboard.c (menu_bar_items): Use map_keymap_canonical.
4262 (parse_menu_item): Trivial simplification.
4263
3279eb87
GM
42642011-07-01 Glenn Morris <rgm@gnu.org>
4265
4266 * Makefile.in (SETTINGS_LIBS): Fix typo.
4267
4550efdf
KI
42682011-07-01 Kazuhiro Ito <kzhr@d1.dion.ne.jp> (tiny patch)
4269
4270 * coding.c (Fencode_coding_string): Record the last coding system
4271 used, as the function doc string says (bug#8738).
4272
0949d2b6
JD
42732011-07-01 Jan Djärv <jan.h.d@swipnet.se>
4274
4275 * xsettings.c (store_monospaced_changed): Take new font as arg and
4276 check for change against current_mono_font.
4277 (EMACS_TYPE_SETTINGS): Remove this and related defines.
4278 (emacs_settings_constructor, emacs_settings_get_property)
4279 (emacs_settings_set_property, emacs_settings_class_init)
4280 (emacs_settings_init, gsettings_obj): Remove.
4281 (something_changedCB): New function for HAVE_GSETTINGS.
4282 (something_changedCB): HAVE_GCONF: Call store_monospaced_changed
4283 with value as argument.
4284 (init_gsettings): Check that GSETTINGS_SCHEMA exists before calling
4285 g_settings_new (Bug#8967). Do not create gsettings_obj.
9173deec 4286 Remove calls to g_settings_bind. Connect something_changedCB to
0949d2b6
JD
4287 "changed".
4288
4289 * xgselect.c: Add defined (HAVE_GSETTINGS).
4290 (xgselect_initialize): Ditto.
4291
4292 * process.c: Add defined (HAVE_GSETTINGS) for xgselect.h
4293 (wait_reading_process_output): Add defined (HAVE_GSETTINGS) for
4294 xg_select.
4295
bbc6b304
PE
42962011-07-01 Paul Eggert <eggert@cs.ucla.edu>
4297
4298 * eval.c (struct backtrace): Simplify and port the data structure.
4299 Do not assume that "int nargs : BITS_PER_INT - 2;" produces a
4300 signed bit field, as this assumption is not portable and it makes
4301 Emacs crash when compiled with Sun C 5.8 on sparc. Do not use
4302 "char debug_on_exit : 1" as this is not portable either; instead,
4303 use the portable "unsigned int debug_on_exit : 1". Remove unused
4304 member evalargs. Remove obsolete comments about cc bombing out.
4305
9851bfc5
JD
43062011-06-30 Jan Djärv <jan.h.d@swipnet.se>
4307
51bb811f 4308 * xsettings.c: Include glib-object.h, gio/gio.h if HAVE_GSETTINGS.
9851bfc5
JD
4309 Let HAVE_GSETTINGS override HAVE_GCONF.
4310 (store_monospaced_changed): New function.
4311 (EMACS_SETTINGS): A new type derived from GObject to handle
4312 GSettings notifications.
4313 (emacs_settings_constructor, emacs_settings_get_property)
4314 (emacs_settings_set_property, emacs_settings_class_init):
4315 New functions.
4316 (gsettings_client, gsettings_obj): New variables.
4317 (GSETTINGS_SCHEMA): New define.
4318 (something_changedCB): Call store_monospaced_changed.
4319 (init_gsettings): New function.
4320 (xsettings_initialize): Call init_gsettings.
4321 (syms_of_xsettings): Initialize gsettings_client, gsettings_obj
4322 to NULL.
4323
640c8776 4324 * Makefile.in (SETTINGS_CFLAGS, SETTINGS_LIBS): Rename from
9851bfc5
JD
4325 GCONF_CFLAGS/LIBS.
4326
5386012d
MR
43272011-06-29 Martin Rudalics <rudalics@gmx.at>
4328
4329 * window.c (resize_root_window, grow_mini_window)
4330 (shrink_mini_window): Rename Qresize_root_window to
4331 Qwindow_resize_root_window and Qresize_root_window_vertically to
4332 Qwindow_resize_root_window_vertically.
4333
f13e0b08
PE
43342011-06-28 Paul Eggert <eggert@cs.ucla.edu>
4335
4336 * gnutls.c (Qgnutls_bootprop_verify_error): Remove unused var.
4337
94515237
JB
43382011-06-27 Juanma Barranquero <lekktu@gmail.com>
4339
4340 * makefile.w32-in: Redesign dependencies so they reflect more
4341 clearly which files are directly included by each source file,
4342 and not through other includes.
4343
e43b6e43
MR
43442011-06-27 Martin Rudalics <rudalics@gmx.at>
4345
4346 * buffer.c (Qclone_number): Declare static and DEFSYM it.
4347 (sort_overlays, overlay_strings): When an overlay's clone number
4348 matches the window's clone number process the overlay even if
4349 the overlay's window property doesn't match the current window.
4350
d68443dc
MR
4351 * window.c (Fwindow_vchild): Rename to Fwindow_top_child.
4352 (Fwindow_hchild): Rename to Fwindow_left_child.
4353 (Fwindow_next): Rename to Fwindow_next_sibling.
4354 (Fwindow_prev): Rename to Fwindow_prev_sibling.
d615d6d2
MR
4355 (resize_window_check): Rename to window_resize_check.
4356 (resize_window_apply): Rename to window_resize_apply.
4357 (Fresize_window_apply): Rename to Fwindow_resize_apply.
4358 (Fdelete_other_windows_internal, resize_frame_windows)
4359 (Fsplit_window_internal, Fdelete_window_internal)
4360 (grow_mini_window, shrink_mini_window)
4361 (Fresize_mini_window_internal): Fix callers accordingly.
d68443dc 4362
c7e73be5
JD
43632011-06-26 Jan Djärv <jan.h.d@swipnet.se>
4364
4365 * emacsgtkfixed.h: State that this is only used with Gtk+3.
4366 (emacs_fixed_set_min_size): Remove.
4367 (emacs_fixed_new): Take frame as argument.
4368
4369 * emacsgtkfixed.c: State that this is only used with Gtk+3.
4370 (_EmacsFixedPrivate): Remove minwidth/height.
4371 Add struct frame *f.
4372 (emacs_fixed_init): Initialize priv->f.
4373 (get_parent_class, emacs_fixed_set_min_size): Remove.
4374 (emacs_fixed_new): Set priv->f to argument.
4375 (emacs_fixed_get_preferred_width)
4376 (emacs_fixed_get_preferred_height): Use min_width/height from
4377 frames size_hint to set minimum and natural (Bug#8919).
4378 (XSetWMSizeHints, XSetWMNormalHints): Override these functions
4379 and use min_width/height from frames size_hint to set
4380 min_width/height (Bug#8919).
4381
4382 * gtkutil.c (xg_create_frame_widgets): Pass f to emacs_fixed_new.
9173deec
JB
4383 (x_wm_set_size_hint): Remove call to emacs_fixed_set_min_size.
4384 Fix indentation.
c7e73be5 4385
cf99dcf8
EZ
43862011-06-26 Eli Zaretskii <eliz@gnu.org>
4387
4388 * bidi.c (bidi_paragraph_init): Test for ZV_BYTE before calling
4389 bidi_at_paragraph_end, since fast_looking_at doesn't like to be
4390 called at ZV.
4391
029529ac
CY
43922011-06-26 Chong Yidong <cyd@stupidchicken.com>
4393
4394 * process.c (wait_reading_process_output): Bypass select if
4395 waiting for a cell while ignoring keyboard input, and input is
4396 pending. Suggested by Jan Djärv (Bug#8869).
4397
7a7ef429
PE
43982011-06-25 Paul Eggert <eggert@cs.ucla.edu>
4399
4400 Use gnulib's dup2 module instead of rolling our own.
4401 * sysdep.c (dup2) [!HAVE_DUP2]: Remove; gnulib now does this.
4402
11fdef7d 44032011-06-25 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
989b42d2
YM
4404
4405 * dispnew.c (scrolling_window): Before scrolling, turn off a
4406 mouse-highlight in the window being scrolled.
4407
cd3520a4
JB
44082011-06-24 Juanma Barranquero <lekktu@gmail.com>
4409
4410 Move DEFSYM to lisp.h and use everywhere.
4411
4412 * character.h (DEFSYM): Move declaration...
4413 * lisp.h (DEFSYM): ...here.
4414
4415 * gnutls.c:
4416 * minibuf.c:
4417 * w32menu.c:
4418 * w32proc.c:
4419 * w32select.c: Don't include character.h.
4420
4421 * alloc.c (syms_of_alloc):
4422 * buffer.c (syms_of_buffer):
4423 * bytecode.c (syms_of_bytecode):
4424 * callint.c (syms_of_callint):
4425 * casefiddle.c (syms_of_casefiddle):
4426 * casetab.c (init_casetab_once):
4427 * category.c (init_category_once, syms_of_category):
4428 * ccl.c (syms_of_ccl):
4429 * cmds.c (syms_of_cmds):
4430 * composite.c (syms_of_composite):
4431 * dbusbind.c (syms_of_dbusbind):
4432 * dired.c (syms_of_dired):
4433 * dispnew.c (syms_of_display):
4434 * doc.c (syms_of_doc):
4435 * editfns.c (syms_of_editfns):
4436 * emacs.c (syms_of_emacs):
4437 * eval.c (syms_of_eval):
4438 * fileio.c (syms_of_fileio):
4439 * fns.c (syms_of_fns):
4440 * frame.c (syms_of_frame):
4441 * fringe.c (syms_of_fringe):
4442 * insdel.c (syms_of_insdel):
4443 * keymap.c (syms_of_keymap):
4444 * lread.c (init_obarray, syms_of_lread):
4445 * macros.c (syms_of_macros):
4446 * msdos.c (syms_of_msdos):
4447 * print.c (syms_of_print):
4448 * process.c (syms_of_process):
4449 * search.c (syms_of_search):
4450 * sound.c (syms_of_sound):
4451 * syntax.c (init_syntax_once, syms_of_syntax):
4452 * terminal.c (syms_of_terminal):
4453 * textprop.c (syms_of_textprop):
4454 * undo.c (syms_of_undo):
4455 * w32.c (globals_of_w32):
4456 * window.c (syms_of_window):
4457 * xdisp.c (syms_of_xdisp):
4458 * xfaces.c (syms_of_xfaces):
4459 * xfns.c (syms_of_xfns):
4460 * xmenu.c (syms_of_xmenu):
4461 * xsettings.c (syms_of_xsettings):
4462 * xterm.c (syms_of_xterm): Use DEFSYM.
4463
4228cf16
TZ
44642011-06-24 Teodor Zlatanov <tzz@lifelogs.com>
4465
cd3520a4 4466 * gnutls.c (syms_of_gnutls): Use the DEFSYM macro from character.h.
4228cf16 4467
7fcccf1e
PE
44682011-06-23 Paul Eggert <eggert@cs.ucla.edu>
4469
7efb4e0e
PE
4470 Integer and buffer overflow fixes (Bug#8873).
4471
ff5844ad
PE
4472 * print.c (printchar, strout): Check for string overflow.
4473 (PRINTPREPARE, printchar, strout):
4474 Don't set size unless allocation succeeds.
4475
90532f02
PE
4476 * minibuf.c (read_minibuf_noninteractive): Use ptrdiff_t, not int,
4477 for sizes. Check for string overflow more accurately.
4478 Simplify newline removal at end; this suppresses a GCC 4.6.0 warning.
4479
6d84508d
PE
4480 * macros.c: Integer and buffer overflow fixes.
4481 * keyboard.h (struct keyboard.kbd_macro_bufsize):
4482 * macros.c (Fstart_kbd_macro, store_kbd_macro_char):
4483 Use ptrdiff_t, not int, for sizes.
4484 Don't increment bufsize until after realloc succeeds.
4485 Check for size-calculation overflow.
4486 (Fstart_kbd_macro): Use EMACS_INT, not int, for XINT result.
4487
437b2cb4
PE
4488 * lisp.h (DEFVAR_KBOARD): Use offsetof instead of char * finagling.
4489
8b9ac8b4
PE
4490 * lread.c: Integer overflow fixes.
4491 (read_integer): Radix is now EMACS_INT, not int,
4492 to improve quality of diagnostics for out-of-range radices.
4493 Calculate buffer size correctly for out-of-range radices.
4494 (read1): Check for integer overflow in radices, and in
4495 read-circle numbers.
82cb60d3
PE
4496 (read_escape): Avoid int overflow.
4497 (Fload, openp, read_buffer_size, read1)
4498 (substitute_object_recurse, read_vector, read_list, map_obarray):
4499 Use ptrdiff_t, not int, for sizes.
4500 (read1): Use EMACS_INT, not int, for sizes.
20270765 4501 Check for size overflow.
8b9ac8b4 4502
7fcccf1e
PE
4503 * image.c (cache_image): Check for size arithmetic overflow.
4504
bfbbd7e7
PE
4505 * lread.c: Integer overflow issues.
4506 (saved_doc_string_size, saved_doc_string_length)
4507 (prev_saved_doc_string_size, prev_saved_doc_string_length):
4508 Now ptrdiff_t, not int.
4509 (read1): Don't assume doc string length fits in int. Check for
4510 out-of-range doc string lengths.
4511 (read_list): Don't assume file position fits in int.
39019e54 4512 (read_escape): Check for hex character overflow.
bfbbd7e7 4513
4e323265
LL
45142011-06-22 Leo Liu <sdl.web@gmail.com>
4515
4516 * minibuf.c (Fcompleting_read_default, Vcompleting_read_function):
4517 Move to minibuffer.el.
4518
85fece3e
PE
45192011-06-22 Paul Eggert <eggert@cs.ucla.edu>
4520
20b84ce9 4521 Fixes for GLYPH_DEBUG found by GCC 4.6.0 static checking.
85fece3e
PE
4522 The following patches are for when GLYPH_DEBUG && !XASSERT.
4523 * dispextern.h (trace_redisplay_p, dump_glyph_string):
4524 * dispnew.c (flush_stdout):
4525 * xdisp.c (dump_glyph_row, dump_glyph_matrix, dump_glyph):
4526 Mark as externally visible.
4527 * dispnew.c (check_window_matrix_pointers): Now static.
4528 * dispnew.c (window_to_frame_vpos):
4529 * xfns.c (unwind_create_frame):
4530 * xterm.c (x_check_font): Remove unused local.
4531 * scroll.c (CHECK_BOUNDS):
4532 * xfaces.c (cache_fache): Rename local to avoid shadowing.
4533 * xfns.c, w32fns.c (image_cache_refcount, dpyinfo_refcount): Now static.
4534 * xdisp.c (check_window_end): Now a no-op if !XASSERTS.
4535 (debug_first_unchanged_at_end_vpos, debug_last_unchanged_at_beg_vpos)
4536 (debug_dvpos, debug_dy, debug_delta, debug_delta_bytes, debug_end_vpos):
4537 Now static.
4538 (debug_method_add): Use va_list and vsprintf rather than relying
4539 on undefined behavior with wrong number of arguments.
4540 (dump_glyph, dump_glyph_row, Fdump_glyph_matrix):
4541 Don't assume ptrdiff_t and EMACS_INT are the same width as int.
4542 In this code, it's OK to assume C99 behavior for ptrdiff_t formats
4543 since we're not interested in debugging glyphs with old libraries.
4544 * xfaces.c (cache_face): Move debugging code earlier; this pacifies
4545 GCC 4.6.0's static checking.
4546
0766b489
PE
45472011-06-22 Paul Eggert <eggert@cs.ucla.edu>
4548
31fd4b32
PE
4549 Integer overflow and signedness fixes (Bug#8873).
4550 A few related buffer overrun fixes, too.
4551
b79e8648
PE
4552 * font.c (font_score): Use EMACS_INT, not int, to store XINT value.
4553
0766b489
PE
4554 * dispextern.h (struct face.stipple):
4555 * image.c (x_bitmap_height, x_bitmap_width, x_bitmap_pixmap)
4556 (x_bitmap_mask, x_allocate_bitmap_record)
4557 (x_create_bitmap_from_data, x_create_bitmap_from_file)
4558 (x_destroy_bitmap, x_destroy_all_bitmaps, x_create_bitmap_mask)
4559 (x_create_bitmap_from_xpm_data):
4560 * nsterm.h (struct ns_display_info.bitmaps_size, .bitmaps_last):
4561 * w32term.h (struct w32_display_info.icon_bitmap_id, .bitmaps_size)
4562 (.bitmaps_last):
4563 * xfaces.c (load_pixmap):
4564 * xterm.c (x_bitmap_icon, x_wm_set_icon_pixmap):
4565 * xterm.h (struct x_display_info.icon_bitmap_id, .bitmaps_size)
4566 (.bitmaps_last, struct x_output.icon_bitmap):
4567 Use ptrdiff_t, not int, for bitmap indexes.
4568 (x_allocate_bitmap_record): Check for size overflow.
4569 * dispextern.h, lisp.h: Adjust to API changes elsewhere.
4570
b081724f
PE
4571 Use ptrdiff_t, not int, for overlay counts.
4572 * buffer.h (overlays_at, sort_overlays, GET_OVERLAYS_AT):
4573 * editfns.c (overlays_around, get_pos_property):
4574 * textprop.c (get_char_property_and_overlay):
4575 * xdisp.c (next_overlay_change, note_mouse_highlight):
4576 * xfaces.c (face_at_buffer_position):
21514da7
PE
4577 * buffer.c (OVERLAY_COUNT_MAX): New macro.
4578 (overlays_at, overlays_in, sort_overlays, Foverlays_at)
4579 (Fnext_overlay_change, Fprevious_overlay_change)
4580 (mouse_face_overlay_overlaps, Foverlays_in):
b081724f 4581 Use ptrdiff_t, not int, for sizes.
21514da7 4582 (overlays_at, overlays_in): Check for size-calculation overflow.
b081724f 4583
3de73e5e
PE
4584 * xterm.c (xim_initialize, same_x_server): Strlen may not fit in int.
4585
2606c57b
PE
4586 * xsmfns.c (smc_save_yourself_CB, x_session_initialize): Avoid strlen.
4587 (x_session_initialize): Do not assume string length fits in int.
4588
aaafe47a
PE
4589 * xsettings.c (apply_xft_settings): Fix potential buffer overrun.
4590 This is unlikely, but can occur if DPI is outlandish.
4591
2674ddc8 4592 * xsettings.c (Ffont_get_system_normal_font, Ffont_get_system_font):
3a5077c5
PE
4593 * xselect.c (Fx_get_atom_name): Avoid need for strlen.
4594
28154962
PE
4595 * xrdb.c: Don't assume strlen fits in int; avoid some strlens.
4596 * xrdb.c (magic_file_p, search_magic_path):
4597 Omit last arg SUFFIX; it was always 0. All callers changed.
4598 (magic_file_p): Use ptrdiff_t, not int. Check for size overflow.
4599
7de51af5
PE
4600 * xfont.c (xfont_match): Avoid need for strlen.
4601
25ed6cc3
PE
4602 * xfns.c: Don't assume strlen fits in int.
4603 (xic_create_fontsetname, x_window): Use ptrdiff_t, not int.
4604
4eab31dd
PE
4605 * xdisp.c (message_log_check_duplicate): Return intmax_t,
4606 not unsigned long, as we prefer signed integers. All callers changed.
4607 Detect integer overflow in repeat count.
4608 (message_dolog): Don't assume print length fits in 39 bytes.
df1f27af 4609 (display_mode_element): Don't assume strlen fits in int.
4eab31dd 4610
171e2a58
PE
4611 * termcap.c: Don't assume sizes fit in int and never overflow.
4612 (struct termcap_buffer, tgetent): Use ptrdiff_t, not int, for sizes.
4613 (gobble_line): Check for size-calculation overflow.
4614
ad39faca 4615 * minibuf.c (Fread_buffer):
6e5bb2dc 4616 * lread.c (intern, intern_c_string):
74ca2eb3
PE
4617 * image.c (xpm_scan) [HAVE_NS && !HAVE_XPM]:
4618 Don't assume string length fits in int.
4619
52c61c22 4620 * keyboard.c (parse_tool_bar_item):
9bda3520
PE
4621 * gtkutil.c (style_changed_cb): Avoid need for strlen.
4622
b5b8c9e5
PE
4623 * font.c: Don't assume string length fits in int.
4624 (font_parse_xlfd, font_parse_fcname, font_unparse_fcname):
4625 Use ptrdiff_t, not int.
ccd6111c
PE
4626 (font_intern_prop): Don't assume string length fits in int.
4627 Don't assume integer property fits in fixnum.
4628 * font.h (font_intern_prop): 2nd arg is now ptrdiff_t, not int.
b5b8c9e5 4629
882f0d81 4630 * filelock.c: Fix some buffer overrun and integer overflow issues.
51cab52b 4631 (get_boot_time): Don't assume gzip command string fits in 100 bytes.
882f0d81
PE
4632 Reformulate so as not to need the command string.
4633 Invoke gzip -cd rather than gunzip, as it's more portable.
4634 (lock_info_type, lock_file_1, lock_file):
4635 Don't assume pid_t and time_t fit in unsigned long.
4636 (LOCK_PID_MAX): Remove; we now use more-reliable bounds.
4637 (current_lock_owner): Prefer signed type for sizes.
4638 Use memcpy, not strncpy, where memcpy is what is really wanted.
4639 Don't assume (via atoi) that time_t and pid_t fit in int.
4640 Check for time_t and/or pid_t out of range, e.g., via a network share.
4641 Don't alloca where an auto var works fine.
4642
93f4cf88
PE
4643 * fileio.c: Fix some integer overflow issues.
4644 (file_name_as_directory, Fexpand_file_name, Fsubstitute_in_file_name):
4645 Don't assume string length fits in int.
4646 (directory_file_name): Don't assume string length fits in long.
4647 (make_temp_name): Don't assume pid fits in int, or that its print
4648 length is less than 20.
4649
f3e92b69
PE
4650 * data.c (Fsubr_name): Rewrite to avoid a strlen call.
4651
1bfdaf10
PE
4652 * coding.c (make_subsidiaries): Don't assume string length fits in int.
4653
35016e9a
PE
4654 * callproc.c (child_setup): Rewrite to avoid two strlen calls.
4655
3d1e65a1
PE
4656 * process.c (Fformat_network_address): Use EMACS_INT, not EMACS_UINT.
4657 We prefer signed integers, even for size calculations.
4658
0b963a93
PE
4659 * emacs.c: Don't assume string length fits in 'int'.
4660 (DEFINE_DUMMY_FUNCTION, sort_args): Use ptrdiff_t, not int.
4661 (main): Don't invoke strlen when not needed.
4662
573f4b54
PE
4663 * dbusbind.c (XD_ERROR): Don't arbitrarily truncate string.
4664 (XD_DEBUG_MESSAGE): Don't waste a byte.
4665
989f33ba
PE
4666 * callproc.c (getenv_internal_1, getenv_internal)
4667 (Fgetenv_internal):
965d34eb
PE
4668 * buffer.c (init_buffer): Don't assume string length fits in 'int'.
4669
e4d29b33
PE
4670 * lread.c (invalid_syntax): Omit length argument.
4671 All uses changed. This doesn't fix a bug, but it simplifies the
4672 code away from its former Hollerith-constant appearance, and it's
4673 one less 'int' to worry about when looking at integer-overflow issues.
51cab52b 4674 (string_to_number): Simplify 2011-04-26 change by invoking xsignal1.
e4d29b33 4675
eb49b136
PE
4676 * lisp.h (DEFUN): Remove bogus use of sizeof (struct Lisp_Subr).
4677 This didn't break anything, but it didn't help either.
4678 It's confusing to put a bogus integer in a place where the actual
4679 value does not matter.
9f62aeb1 4680 (LIST_END_P): Remove unused macro and its bogus comment.
cbeff735 4681 (make_fixnum_or_float): Remove unnecessary cast to EMACS_INT.
eb49b136 4682
15375a22
PE
4683 * lisp.h (union Lisp_Object.i): EMACS_INT, not EMACS_UINT.
4684 This is for consistency with the ordinary, non-USE_LISP_UNION_TYPE,
4685 implementation.
b61cc01c
PE
4686 (struct Lisp_Bool_Vector.size): EMACS_INT, not EMACS_UINT.
4687 We prefer signed types, and the value cannot exceed the EMACS_INT
4688 range anyway (because otherwise the length would not be representable).
9a8e8d9b
PE
4689 (XSET) [USE_LISP_UNION_TYPE]: Use uintptr_t and intptr_t,
4690 not EMACS_UINT and EMACS_INT, when converting pointer to integer.
4691 This avoids a GCC warning when WIDE_EMACS_INT.
15375a22 4692
53b2623d
PE
4693 * indent.c (sane_tab_width): New function.
4694 (current_column, scan_for_column, Findent_to, position_indentation)
4695 (compute_motion): Use it. This is just for clarity.
8fcaf9cc 4696 (Fcompute_motion): Don't assume hscroll and tab offset fit in int.
53b2623d 4697
51cab52b 4698 * image.c (xbm_image_p): Don't assume stated width, height fit in int.
45aebb64 4699
f2ed8a70
PE
4700 * lisp.h (lint_assume): New macro.
4701 * composite.c (composition_gstring_put_cache):
4702 * ftfont.c (ftfont_shape_by_flt): Use it to pacify GCC 4.6.0.
4703
abe80cc6
PE
4704 * editfns.c, insdel.c:
4705 Omit unnecessary forward decls, to simplify future changes.
a9e860e1 4706
b02c740e
PE
4707 * ftfont.c (ftfont_shape_by_flt): Use signed integers for lengths.
4708
ebc96716
PE
4709 * font.c (Ffont_shape_gstring): Don't assume glyph len fits in 'int'.
4710
b4e50fa0 4711 * fns.c (Ffillarray): Don't assume bool vector size fits in 'int'.
f03dc6ef 4712 Use much-faster test for byte-length change.
311d5d7c 4713 Don't assume string byte-length fits in 'int'.
a4cf38e4 4714 Check that character arg fits in 'int'.
85461888 4715 (mapcar1): Declare byte as byte, for clarity.
b4e50fa0 4716
c0c1ee9f
PE
4717 * alloc.c (Fmake_bool_vector): Avoid unnecessary multiplication.
4718
a498d7f4
PE
4719 * fns.c (concat): Catch string overflow earlier.
4720 Do not rely on integer wraparound.
4721
51cab52b
PE
4722 * dispextern.h (struct it.overlay_strings_charpos)
4723 (struct it.selective): Now EMACS_INT, not int.
87830974
PE
4724 * xdisp.c (forward_to_next_line_start)
4725 (back_to_previous_visible_line_start)
4726 (reseat_at_next_visible_line_start, next_element_from_buffer):
4727 Don't arbitrarily truncate the value of 'selective' to int.
4728
76031fad
PE
4729 * xdisp.c (init_iterator): Use XINT, not XFASTINT; it might be < 0.
4730
5eb55db9
PE
4731 * composite.c: Don't truncate sizes to 'int'.
4732 (composition_gstring_p, composition_reseat_it)
4733 (composition_adjust_point): Use EMACS_INT, not int.
7d100a81
PE
4734 (get_composition_id, composition_gstring_put_cache): Use EMACS_INT,
4735 not EMACS_UINT, for indexes.
5eb55db9 4736
0703a717
PE
4737 * category.h (CATEGORY_SET_P): Remove unnecessary cast to EMACS_INT.
4738
d6202519
PE
4739 * buffer.c: Include <verify.h>.
4740 (struct sortvec.priority, struct sortstr.priority):
8961a454 4741 Now EMACS_INT, not int.
c20998a7 4742 (compare_overlays, cmp_for_strings): Avoid subtraction overflow.
67c36fce
PE
4743 (struct sortstr.size, record_overlay_string)
4744 (struct sortstrlist.size, struct sortlist.used):
4745 Don't truncate size to int.
4746 (record_overlay_string): Check for size-calculation overflow.
d6202519 4747 (init_buffer_once): Check at compile-time, not run-time.
fadf4e30 4748
d5a19415
JM
47492011-06-22 Jim Meyering <meyering@redhat.com>
4750
029529ac 4751 Don't leak an XBM-image-sized buffer
d5a19415
JM
4752 * image.c (xbm_load): Free the image buffer after using it.
4753
a9041e6c
PE
47542011-06-21 Paul Eggert <eggert@cs.ucla.edu>
4755
4756 Port to Sun C.
4757 * composite.c (find_automatic_composition): Omit needless 'return 0;'
4758 that Sun C diagnosed.
4759 * fns.c (secure_hash): Fix pointer signedness issue.
4760 * intervals.c (static_offset_intervals): New function.
4761 (offset_intervals): Use it.
4762
7f3f739f
LL
47632011-06-21 Leo Liu <sdl.web@gmail.com>
4764
4765 * deps.mk (fns.o):
4766 * makefile.w32-in ($(BLD)/fns.$(O)): Include sha256.h and
4767 sha512.h.
4768
4769 * fns.c (secure_hash): Rename from crypto_hash_function and change
4770 the first arg to accept symbols.
5b66d427 4771 (Fsecure_hash): New primitive.
7f3f739f
LL
4772 (syms_of_fns): New symbols.
4773
76147d94
DD
47742011-06-20 Deniz Dogan <deniz@dogan.se>
4775
4776 * process.c (Fset_process_buffer): Clarify return value in
4777 docstring.
4778
7d7d0045
CY
47792011-06-18 Chong Yidong <cyd@stupidchicken.com>
4780
4781 * dispnew.c (add_window_display_history): Use BVAR.
4782
4783 * xdisp.c (debug_method_add): Use BVAR.
4784 (check_window_end, dump_glyph_matrix, dump_glyph)
4785 (dump_glyph_row, dump_glyph_string): Convert arglist to ANSI C.
4786
4787 * xfaces.c (check_lface_attrs, check_lface, dump_realized_face):
4788 Likewise.
4789
4790 * xfns.c (Fx_create_frame, x_create_tip_frame): Delay image cache
4791 check till after the cache is created in init_frame_faces.
4792
ff2bc410
SM
47932011-06-17 Stefan Monnier <monnier@iro.umontreal.ca>
4794
4795 * fns.c (Fsafe_length): Yet another int/Lisp_Object mixup.
4796
28177add
PE
47972011-06-16 Paul Eggert <eggert@cs.ucla.edu>
4798
dd3482fe
PE
4799 * lisp.h: Include <limits.h>, for INT_MAX, LONG_MAX, LLONG_MAX.
4800 Without this, prin1 mishandles Lisp_Misc_Save_Value printing on
4801 hosts with pre-C99 libraries, because pD is wrongly defined to "t".
4802
393d71f3 4803 Improve buffer-overflow checking (Bug#8873).
1c8e352f
PE
4804 * fileio.c (Finsert_file_contents):
4805 * insdel.c (insert_from_buffer_1, replace_range, replace_range_2):
4806 Remove the old (too-loose) buffer overflow checks.
4807 They weren't needed, since make_gap checks for buffer overflow.
4808 * insdel.c (make_gap_larger): Catch buffer overflows that were missed.
4809 The old code merely checked for Emacs fixnum overflow, and relied
4810 on undefined (wraparound) behavior. The new code avoids undefined
4811 behavior, and also checks for ptrdiff_t and/or size_t overflow.
4812
2e6813b0 4813 * editfns.c (Finsert_char): Don't dump core with very negative counts.
21d890a4
PE
4814 Tune. Don't use wider integers than needed. Don't use alloca.
4815 Use a bigger 'string' buffer. Rewrite to avoid 'n > 0' test.
2e6813b0 4816
599a9e4f
PE
4817 * insdel.c (replace_range): Fix buf overflow when insbytes < outgoing.
4818
99561444
PE
4819 * insdel.c, lisp.h (buffer_overflow): New function.
4820 (insert_from_buffer_1, replace_range, replace_range_2):
4821 * insdel.c (make_gap_larger):
4822 * editfns.c (Finsert_char):
4823 * fileio.c (Finsert_file_contents): Use it, to normalize wording.
4824
28177add
PE
4825 * buffer.h (BUF_BYTES_MAX): Cast to ptrdiff_t so that it's signed.
4826
e69dafad
PE
48272011-06-15 Paul Eggert <eggert@cs.ucla.edu>
4828
4baa020d 4829 Integer overflow and signedness fixes (Bug#8873, Bug#8828).
ff672d2c 4830
b1c46f02
PE
4831 * ccl.c (ASCENDING_ORDER): New macro, to work around GCC bug 43772.
4832 (GET_CCL_RANGE, IN_INT_RANGE): Use it.
4833
e69dafad
PE
4834 * fileio.c: Don't assume EMACS_INT fits in off_t.
4835 (emacs_lseek): New static function.
4836 (Finsert_file_contents, Fwrite_region): Use it.
4837 Use SEEK_SET, SEEK_CUR, SEEK_END as appropriate.
4838
566684ea
PE
4839 * fns.c (Fload_average): Don't assume 100 * load average fits in int.
4840
e6966cd6
PE
4841 * fns.c: Don't overflow int when computing a list length.
4842 * fns.c (QUIT_COUNT_HEURISTIC): New constant.
4843 (Flength, Fsafe_length): Use EMACS_INT, not int, to avoid unwanted
4844 truncation on 64-bit hosts. Check for QUIT every
4845 QUIT_COUNT_HEURISTIC entries rather than every other entry; that's
4846 faster and is responsive enough.
4847 (Flength): Report an error instead of overflowing an integer.
4848 (Fsafe_length): Return a float if the value is not representable
4849 as a fixnum. This shouldn't happen except in contrived situations.
6346d301 4850 (Fnthcdr, Fsort): Don't assume list length fits in int.
de41a810 4851 (Fcopy_sequence): Don't assume vector length fits in int.
00c604f2 4852
dd0b0efb
PE
4853 * alloc.c: Check that resized vectors' lengths fit in fixnums.
4854 (header_size, word_size): New constants.
4855 (allocate_vectorlike): Don't check size overflow here.
4856 (allocate_vector): Check it here instead, since this is the only
4857 caller of allocate_vectorlike that could cause overflow.
4858 Check that the new vector's length is representable as a fixnum.
4859
86fe5cfe
PE
4860 * fns.c (next_almost_prime): Don't return a multiple of 3 or 5.
4861 The previous code was bogus. For example, next_almost_prime (32)
4862 returned 39, which is undesirable as it is a multiple of 3; and
4863 next_almost_prime (24) returned 25, which is a multiple of 5 so
4864 why was the code bothering to check for multiples of 7?
4865
80e88859
PE
4866 * bytecode.c (exec_byte_code): Use ptrdiff_t, not int, for vector length.
4867
4a2f0ad6
PE
4868 * eval.c, doprnt.c (SIZE_MAX): Remove; inttypes.h defines this now.
4869
f66c7cf8
PE
4870 Variadic C functions now count arguments with ptrdiff_t.
4871 This partly undoes my 2011-03-30 change, which replaced int with size_t.
4872 Back then I didn't know that the Emacs coding style prefers signed int.
4873 Also, in the meantime I found a few more instances where arguments
4a2f0ad6
PE
4874 were being counted with int, which may truncate counts on 64-bit
4875 machines, or EMACS_INT, which may be unnecessarily wide.
f66c7cf8
PE
4876 * lisp.h (struct Lisp_Subr.function.aMANY)
4877 (DEFUN_ARGS_MANY, internal_condition_case_n, safe_call):
4878 Arg counts are now ptrdiff_t, not size_t.
4879 All variadic functions and their callers changed accordingly.
4880 (struct gcpro.nvars): Now size_t, not size_t. All uses changed.
4881 * bytecode.c (exec_byte_code): Check maxdepth for overflow,
4882 to avoid potential buffer overrun. Don't assume arg counts fit in 'int'.
4883 * callint.c (Fcall_interactively): Check arg count for overflow,
4884 to avoid potential buffer overrun. Use signed char, not 'int',
4885 for 'varies' array, so that we needn't bother to check its size
4886 calculation for overflow.
4887 * editfns.c (Fformat): Use ptrdiff_t, not EMACS_INT, to count args.
4888 * eval.c (apply_lambda):
4889 * fns.c (Fmapconcat): Use XFASTINT, not XINT, to get args length.
4890 (struct textprop_rec.argnum): Now ptrdiff_t, not int. All uses changed.
4891 (mapconcat): Use ptrdiff_t, not int and EMACS_INT, to count args.
4892
a1759b76
PE
4893 * callint.c (Fcall_interactively): Don't use index var as event count.
4894
d96be9fc
PE
4895 * vm-limit.c (check_memory_limits): Fix incorrect extern function decls.
4896 * mem-limits.h (SIZE): Remove; no longer used.
4897
a690a978 4898 * xterm.c (x_alloc_nearest_color_1): Prefer int to long when int works.
5efd304b 4899
578c21e6
PE
4900 Remove unnecessary casts.
4901 * xterm.c (x_term_init):
4902 * xfns.c (x_set_border_pixel):
4903 * widget.c (create_frame_gcs): Remove casts to unsigned long etc.
4904 These aren't needed now that we assume ANSI C.
4905
96f53c6c
PE
4906 * sound.c (Fplay_sound_internal): Remove cast to unsigned long.
4907 It's more likely to cause problems (due to unsigned overflow)
4908 than to cure them.
4909
83c77d31
PE
4910 * dired.c (Ffile_attributes): Don't use 32-bit hack on 64-bit hosts.
4911
ee2079f1
PE
4912 * unexelf.c (unexec): Don't assume BSS addr fits in unsigned.
4913
6da65536
PE
4914 * xterm.c (handle_one_xevent): Omit unnecessary casts to unsigned.
4915
7147c4a4
PE
4916 * keyboard.c (modify_event_symbol): Don't limit alist len to UINT_MAX.
4917
193e32d9
PE
4918 * lisp.h (CHAR_TABLE_SET): Omit now-redundant test.
4919
e5533da6
PE
4920 * lread.c (Fload): Don't compare a possibly-garbage time_t value.
4921
9910e595
PE
4922 GLYPH_CODE_FACE returns EMACS_INT, not int.
4923 * dispextern.h (merge_faces):
4924 * xfaces.c (merge_faces):
01103c44
PE
4925 * xdisp.c (get_next_display_element, next_element_from_display_vector):
4926 Don't assume EMACS_INT fits in int.
9910e595 4927
2638320e
PE
4928 * character.h (CHAR_VALID_P): Remove unused parameter.
4929 * fontset.c, lisp.h, xdisp.c: All uses changed.
4930
045eb8d9
PE
4931 * editfns.c (Ftranslate_region_internal): Omit redundant test.
4932
c1f134b5
PE
4933 * fns.c (concat): Minor tuning based on overflow analysis.
4934 This doesn't fix any bugs. Use int to hold character, instead
4935 of constantly refetching from Emacs object. Use XFASTINT, not
4936 XINT, for value known to be a character. Don't bother comparing
4937 a single byte to 0400, as it's always less.
4938
395fcb93 4939 * floatfns.c (Fexpt):
327eeec8
PE
4940 * fileio.c (make_temp_name): Omit unnecessary cast to unsigned.
4941
abbd3d23
PE
4942 * editfns.c (Ftranslate_region_internal): Use int, not EMACS_INT
4943 for characters.
4944
684a03ef
PE
4945 * doc.c (get_doc_string): Omit (unsigned)c that mishandled negatives.
4946
0fed43f3
PE
4947 * data.c (Faset): If ARRAY is a string, check that NEWELT is a char.
4948 Without this fix, on a 64-bit host (aset S 0 4294967386) would
4949 incorrectly succeed when S was a string, because 4294967386 was
4950 truncated before it was used.
4951
8fd02eb7
PE
4952 * chartab.c (Fchar_table_range): Use CHARACTERP to check range.
4953 Otherwise, an out-of-range integer could cause undefined behavior
4954 on a 64-bit host.
4955
f8c86b69
PE
4956 * composite.c: Use int, not EMACS_INT, for characters.
4957 (fill_gstring_body, composition_compute_stop_pos): Use int, not
4958 EMACS_INT, for values that are known to be in character range.
4959 This doesn't fix any bugs but is the usual style inside Emacs and
4960 may generate better code on 32-bit machines.
4961
34206dd2
PE
4962 Make sure a 64-bit char is never passed to ENCODE_CHAR.
4963 This is for reasons similar to the recent CHAR_STRING fix.
4964 * charset.c (Fencode_char): Check that character arg is actually
4965 a character. Pass an int to ENCODE_CHAR.
4966 * charset.h (ENCODE_CHAR): Verify that the character argument is no
4967 wider than 'int', as a compile-time check to prevent future regressions
4968 in this area.
4969
c5958d4c 4970 * character.c (char_string): Remove unnecessary casts.
13bdea59
PE
4971
4972 Make sure a 64-bit char is never passed to CHAR_STRING.
4973 Otherwise, CHAR_STRING would do the wrong thing on a 64-bit platform,
4974 by silently ignoring the top 32 bits, allowing some values
4975 that were far too large to be valid characters.
4976 * character.h: Include <verify.h>.
4977 (CHAR_STRING, CHAR_STRING_ADVANCE): Verify that the character
4978 arguments are no wider than unsigned, as a compile-time check
4979 to prevent future regressions in this area.
4980 * data.c (Faset):
01103c44 4981 * editfns.c (Fchar_to_string, general_insert_function, Finsert_char)
13bdea59
PE
4982 (Fsubst_char_in_region):
4983 * fns.c (concat):
4984 * xdisp.c (decode_mode_spec_coding):
4985 Adjust to CHAR_STRING's new requirement.
4986 * editfns.c (Finsert_char, Fsubst_char_in_region):
4987 * fns.c (concat): Check that character args are actually
4988 characters. Without this test, these functions did the wrong
4989 thing with wildly out-of-range values on 64-bit hosts.
4990
d37ca623
PE
4991 Remove incorrect casts to 'unsigned' that lose info on 64-bit hosts.
4992 These casts should not be needed on 32-bit hosts, either.
4993 * keyboard.c (read_char):
4994 * lread.c (Fload): Remove casts to unsigned.
4995
ea204efb
PE
4996 * lisp.h (UNSIGNED_CMP): New macro.
4997 This fixes comparison bugs on 64-bit hosts.
4998 (ASCII_CHAR_P): Use it.
4999 * casefiddle.c (casify_object):
01103c44 5000 * character.h (ASCII_BYTE_P, CHAR_VALID_P)
ea204efb
PE
5001 (SINGLE_BYTE_CHAR_P, CHAR_STRING):
5002 * composite.h (COMPOSITION_ENCODE_RULE_VALID):
5003 * dispextern.h (FACE_FROM_ID):
5004 * keyboard.c (read_char): Use UNSIGNED_CMP.
5005
41cb286c
PE
5006 * xmenu.c (dialog_selection_callback) [!USE_GTK]: Cast to intptr_t,
5007 not to EMACS_INT, to avoid GCC warning.
5008
4a1b9832
PE
5009 * xfns.c (x_set_scroll_bar_default_width): Remove unused 'int' locals.
5010
55daad71
PE
5011 * buffer.h (PTR_BYTE_POS, BUF_PTR_BYTE_POS): Remove harmful cast.
5012 The cast incorrectly truncated 64-bit byte offsets to 32 bits, and
5013 isn't needed on 32-bit machines.
8f95c75c 5014
01103c44
PE
5015 * buffer.c (Fgenerate_new_buffer_name):
5016 Use EMACS_INT for count, not int.
0ceccced 5017 (advance_to_char_boundary): Return EMACS_INT, not int.
e762cafe
PE
5018
5019 * data.c (Qcompiled_function): Now static.
5020
c6f072e7
PE
5021 * window.c (window_body_lines): Now static.
5022
20ce5912
PE
5023 * image.c (gif_load): Rename local to avoid shadowing.
5024
9c4c5f81
PE
5025 * lisp.h (SAFE_ALLOCA_LISP): Check for integer overflow.
5026 (struct Lisp_Save_Value): Use ptrdiff_t, not int, for 'integer' member.
5027 * alloc.c (make_save_value): Integer argument is now of type
5028 ptrdiff_t, not int.
5029 (mark_object): Use ptrdiff_t, not int.
5030 * lisp.h (pD): New macro.
5031 * print.c (print_object): Use it.
5032
c0c5c8ae
PE
5033 * alloc.c: Use EMACS_INT, not int, to count objects.
5034 (total_conses, total_markers, total_symbols, total_vector_size)
5035 (total_free_conses, total_free_markers, total_free_symbols)
01103c44
PE
5036 (total_free_floats, total_floats, total_free_intervals)
5037 (total_intervals, total_strings, total_free_strings):
c0c5c8ae
PE
5038 Now EMACS_INT, not int. All uses changed.
5039 (Fgarbage_collect): Compute overall total using a double, so that
5040 integer overflow is less likely to be a problem. Check for overflow
5041 when converting back to an integer.
5a25e253
PE
5042 (n_interval_blocks, n_string_blocks, n_float_blocks, n_cons_blocks)
5043 (n_vectors, n_symbol_blocks, n_marker_blocks): Remove.
5044 These were 'int' variables that could overflow on 64-bit hosts;
5045 they were never used, so remove them instead of repairing them.
211a0b2a 5046 (nzombies, ngcs, max_live, max_zombies): Now EMACS_INT, not 'int'.
6349ae4d
PE
5047 (inhibit_garbage_collection): Set gc_cons_threshold to max value.
5048 Previously, this ceilinged at INT_MAX, but that doesn't work on
5049 64-bit machines.
e46bb31a 5050 (allocate_pseudovector): Don't use EMACS_INT when int would do.
c0c5c8ae 5051
c78baabf 5052 * alloc.c (Fmake_bool_vector): Don't assume vector size fits in int.
86f61a15 5053 (allocate_vectorlike): Check for ptrdiff_t overflow.
b6439961
PE
5054 (mark_vectorlike, mark_char_table, mark_object): Avoid EMACS_UINT
5055 when a (possibly-narrower) signed value would do just as well.
5056 We prefer using signed arithmetic, to avoid comparison confusion.
c78baabf 5057
c9d624c6
PE
5058 * alloc.c: Catch some string size overflows that we were missing.
5059 (XMALLOC_OVERRUN_CHECK_SIZE) [!XMALLOC_OVERRUN_CHECK]: Define to 0,
5060 for convenience in STRING_BYTES_MAX.
5061 (STRING_BYTES_MAX): New macro, superseding the old one in lisp.h.
5062 The definition here is exact; the one in lisp.h was approximate.
5063 (allocate_string_data): Check for string overflow. This catches
5064 some instances we weren't catching before. Also, it catches
5065 size_t overflow on (unusual) hosts where SIZE_MAX <= min
5066 (PTRDIFF_MAX, MOST_POSITIVE_FIXNUM), e.g., when size_t is 32 bits
5067 and ptrdiff_t and EMACS_INT are both 64 bits.
c78baabf 5068
c9d624c6
PE
5069 * character.c, coding.c, doprnt.c, editfns.c, eval.c:
5070 All uses of STRING_BYTES_MAX replaced by STRING_BYTES_BOUND.
640c8776 5071 * lisp.h (STRING_BYTES_BOUND): Rename from STRING_BYTES_MAX.
c9d624c6 5072
353032ce
PE
5073 * character.c (string_escape_byte8): Fix nbytes/nchars typo.
5074
2bccce07
PE
5075 * alloc.c (Fmake_string): Check for out-of-range init.
5076
0ac30604
SM
50772011-06-15 Stefan Monnier <monnier@iro.umontreal.ca>
5078
5079 * eval.c (Fdefvaralias): Also mark the target as variable-special-p.
5080
c195f2de
JD
50812011-06-14 Jan Djärv <jan.h.d@swipnet.se>
5082
5083 * xfns.c (x_set_scroll_bar_default_width): Remove argument to
5084 xg_get_default_scrollbar_width.
5085
5086 * gtkutil.c: Include emacsgtkfixed.h if HAVE_GTK3.
5087 (int_gtk_range_get_value): Move to the scroll bar part of the file.
5088 (style_changed_cb): Call update_theme_scrollbar_width and call
5089 x_set_scroll_bar_default_width and xg_frame_set_char_size for
5090 all frames (Bug#8505).
5091 (xg_create_frame_widgets): Call emacs_fixed_new if HAVE_GTK3 (Bug#8505).
5092 Call gtk_window_set_resizable if HAVE_GTK3.
5093 (x_wm_set_size_hint): Call emacs_fixed_set_min_size with min width
5094 and height if HAVE_GTK3 (Bug#8505).
5095 (scroll_bar_width_for_theme): New variable.
5096 (update_theme_scrollbar_width): New function.
5097 (xg_get_default_scrollbar_width): Move code to
5098 update_theme_scrollbar_width, just return scroll_bar_width_for_theme.
5099 (xg_initialize): Call update_theme_scrollbar_width.
5100
5101 * gtkutil.h (xg_get_default_scrollbar_width): Remove argument.
5102
5103 * emacsgtkfixed.c, emacsgtkfixed.h: New files.
5104
e10ac9f1
MR
51052011-06-12 Martin Rudalics <rudalics@gmx.at>
5106
5107 * frame.c (make_frame): Call other_buffer_safely instead of
5108 other_buffer.
5109
5110 * window.c (temp_output_buffer_show): Call display_buffer with
5111 second argument Vtemp_buffer_show_specifiers and reset latter
5112 immediately after the call.
5113 (Vtemp_buffer_show_specifiers): New variable.
5114 (auto_window_vscroll_p, next_screen_context_lines)
5115 (Vscroll_preserve_screen_position): Remove leading asterisks from
5116 doc-strings.
5117
2d3c217e 51182011-06-12 Paul Eggert <eggert@cs.ucla.edu>
4475bec4 5119
7b7f97e8 5120 Fix minor problems found by GCC 4.6.0 static checking.
4475bec4
PE
5121 * buffer.c (Qclone_number): Remove for now, as it's unused.
5122 (record_buffer, Funrecord_buffer): Rename local to avoid shadowing.
5123 (record_buffer): Remove unused local.
5124 * frame.c (other_visible_frames, frame_buffer_list): Now static.
5125 (set_frame_buffer_list): Remove; unused.
5126 * frame.h (other_visible_frames): Remove decl.
5127 * keyboard.h (menu_items_inuse): Declare only if USE_GTK || USE_MOTIF.
5128 * lisp.h (frame_buffer_list, set_frame_buffer_list): Remove decls.
5129 (add_gpm_wait_descriptor, delete_gpm_wait_descriptor): Declare only
5130 if HAVE_GPM.
5131 * menu.c (menu_items_inuse): Now static unless USE_GTK || USE_MOTIF.
5132 * process.c (add_gpm_wait_descriptor, delete_gpm_wait_descriptor):
5133 Define only if HAVE_GPM.
5134 * widget.c (EmacsFrameResize, emacsFrameClassRec): Now static.
5135 (update_hints_inhibit): Remove; never set. All uses removed.
5136 * widgetprv.h (emacsFrameClassRec): Remove decl.
5137 * window.c (delete_deletable_window): Now returns void, since it
5138 wasn't returning anything.
5139 (compare_window_configurations): Remove unused locals.
5140 * xfns.c (x_set_scroll_bar_default_width): Remove unused locals.
5141 * xmenu.c (x_menu_set_in_use): Define only if USE_GTK || USE_MOTIF.
4475bec4
PE
5142 (dialog_selection_callback) [!USE_GTK]: Prefer intptr_t for integers
5143 the same widths as pointers. This follows up on the 2011-05-06 patch.
5144 * xterm.c (x_alloc_lighter_color_for_widget): Define only if USE_LUCID.
5145 * xterm.h: Likewise.
5146 (x_menu_set_in_use): Declare only if USE_GTK || USE_MOTIF.
5147
1384b89e
JB
51482011-06-12 Juanma Barranquero <lekktu@gmail.com>
5149
5150 * makefile.w32-in: Update dependencies.
5151 (LISP_H): Add lib/intprops.h.
5152
1100a63c
CY
51532011-06-11 Chong Yidong <cyd@stupidchicken.com>
5154
5155 * image.c (gif_load): Add animation frame delay to the metadata.
5156 (syms_of_image): Use DEFSYM. New symbol `delay'.
5157
6198ccd0
MR
51582011-06-11 Martin Rudalics <rudalics@gmx.at>
5159
5160 * window.c (delete_deletable_window): Re-add.
5161 (Fset_window_configuration): Rewrite to handle dead buffers and
5162 consequently deletable windows.
5163 (window_tree, Fwindow_tree): Remove. Supply functionality in
5164 window.el.
5165 (compare_window_configurations): Simplify code.
5166
b6e3633c
AS
51672011-06-11 Andreas Schwab <schwab@linux-m68k.org>
5168
1ab0dee5
AS
5169 * image.c (imagemagick_load_image): Fix type mismatch.
5170 (Fimagemagick_types): Likewise.
5171
b6e3633c
AS
5172 * window.h (replace_buffer_in_windows): Declare.
5173
9397e56f
MR
51742011-06-11 Martin Rudalics <rudalics@gmx.at>
5175
5176 * buffer.c: New Lisp objects Qbuffer_list_update_hook and
5177 Qclone_number. Remove external declaration of Qdelete_window.
5178 (Fbuffer_list): Rewrite doc-string. Minor restructuring of
5179 code.
640c8776
SM
5180 (Fget_buffer_create, Fmake_indirect_buffer, Frename_buffer):
5181 Run Qbuffer_list_update_hook if allowed.
9397e56f
MR
5182 (Fother_buffer): Rewrite doc-string. Major rewrite for new
5183 buffer list implementation.
5184 (other_buffer_safely): New function.
5185 (Fkill_buffer): Replace call to replace_buffer_in_all_windows by
5186 calls to replace_buffer_in_windows and
5187 replace_buffer_in_windows_safely. Run Qbuffer_list_update_hook
5188 if allowed.
5189 (record_buffer): Inhibit quitting and rewrite using quittable
5190 functions. Run Qbuffer_list_update_hook if allowed.
5191 (Frecord_buffer, Funrecord_buffer): New functions.
640c8776
SM
5192 (switch_to_buffer_1, Fswitch_to_buffer): Remove.
5193 Move switch-to-buffer to window.el.
9397e56f
MR
5194 (bury-buffer): Move to window.el.
5195 (Vbuffer_list_update_hook): New variable.
5196
5197 * lisp.h (other_buffer_safely): Add prototype in buffer.c
5198 section.
5199
5200 * window.h (resize_frame_windows): Move up in code.
5201 (Fwindow_frame): Remove EXFUN.
5202 (replace_buffer_in_all_windows): Remove prototype.
5203 (replace_buffer_in_windows_safely): Add prototype.
5204
5205 * window.c: Declare Qdelete_window static again. Move down
5206 declaration of select_count.
5207 (Fnext_window, Fprevious_window): Rewrite doc-strings.
5208 (Fother_window): Move to window.el.
5209 (window_loop): Remove DELETE_BUFFER_WINDOWS and UNSHOW_BUFFER
5210 cases. Add REPLACE_BUFFER_IN_WINDOWS_SAFELY case.
5211 (Fdelete_windows_on, Freplace_buffer_in_windows): Move to
5212 window.el.
5213 (replace_buffer_in_windows): Implement by calling
5214 Qreplace_buffer_in_windows.
5215 (replace_buffer_in_all_windows): Remove with some functionality
5216 moved into replace_buffer_in_windows_safely.
5217 (replace_buffer_in_windows_safely): New function.
5218 (select_window_norecord, select_frame_norecord): Move in front
5219 of run_window_configuration_change_hook. Remove now obsolete
5220 declarations.
640c8776
SM
5221 (Fset_window_buffer): Rewrite doc-string.
5222 Call Qrecord_window_buffer.
9397e56f
MR
5223 (keys_of_window): Move binding for other-window to window.el.
5224
b50691aa
CY
52252011-06-11 Chong Yidong <cyd@stupidchicken.com>
5226
5227 * dispextern.h (struct image): Replace data member, whose int_val
5228 and ptr_val fields were not used by anything, with a single
5229 lisp_val object.
5230
5231 * image.c (Fimage_metadata, make_image, mark_image, tiff_load)
5232 (gif_clear_image, gif_load, imagemagick_load_image)
5233 (gs_clear_image, gs_load): Callers changed.
5234
3f754b86
PE
52352011-06-10 Paul Eggert <eggert@cs.ucla.edu>
5236
cca69397
PE
5237 * buffer.h: Include <time.h>, for time_t.
5238 Needed to build on FreeBSD 8.2. Problem reported by Herbert J. Skuhra.
5239
109e28d0
PE
5240 Fix minor problems found by static checking.
5241
60737f02
PE
5242 * image.c (PixelGetMagickColor): Declare if ImageMagick headers don't.
5243
4b66faf3
PE
5244 Make identifiers static if they are not used in other modules.
5245 * data.c (Qcompiled_function, Qframe, Qvector):
5246 * image.c (QimageMagick, Qsvg):
5247 * minibuf.c (Qmetadata):
5248 * window.c (resize_window_check, resize_root_window): Now static.
5249 * window.h (resize_window_check, resize_root_window): Remove decls.
5250
109e28d0
PE
5251 * window.c (window_deletion_count, delete_deletable_window):
5252 Remove; unused.
46a4ce9e
PE
5253 (window_body_lines): Now static.
5254 (Fdelete_other_windows_internal): Mark vars as initialized.
5255 Make sure 'resize_failed' is initialized.
5256 (run_window_configuration_change_hook): Rename local to avoid shadowing.
5257 (resize_window_apply): Remove unused local.
5258 * window.h (delete_deletable_window): Remove decl.
5259
109e28d0 5260 * image.c (gif_load, svg_load_image): Rename locals to avoid shadowing.
33290528
PE
5261 (imagemagick_load_image): Fix pointer signedness problem by changing
5262 last arg from unsigned char * to char *. All uses changed.
5263 Also, fix a local for similar reasons.
5264 Remove unused locals. Remove locals to avoid shadowing.
5265 (fn_rsvg_handle_free): Remove; unused.
5266 (svg_load, svg_load_image): Fix pointer signedness problem.
f7e13da3 5267 (imagemagick_load_image): Don't use garbage pointer image_wand.
33290528 5268
3f754b86
PE
5269 * ftfont.c (ftfont_get_metrics, ftfont_drive_otf): Remove unused locals.
5270
2547adb1
CY
52712011-06-10 Chong Yidong <cyd@stupidchicken.com>
5272
5273 * image.c (gif_load): Fix omitted cast error introduced by
5274 2011-06-06 change.
5275
2c8e37d4
MR
52762011-06-10 Martin Rudalics <rudalics@gmx.at>
5277
5278 * window.h (resize_proportionally, orig_total_lines)
5279 (orig_top_line): Remove from window structure.
5280 (set_window_height, set_window_width, change_window_heights)
5281 (Fdelete_window): Remove prototypes.
5282 (resize_frame_windows): Remove duplicate declaration.
5283
440a42e3
EZ
52842011-06-10 Eli Zaretskii <eliz@gnu.org>
5285
5286 * window.h (resize_frame_windows, resize_window_check)
5287 (delete_deletable_window, resize_root_window)
5288 (resize_frame_windows): Declare prototypes.
5289
5290 * window.c (resize_window_apply): Make definition be "static" to
5291 match the prototype.
5292
562dd5e9
MR
52932011-06-10 Martin Rudalics <rudalics@gmx.at>
5294
5295 * window.c: Remove declarations of Qwindow_size_fixed,
5296 window_min_size_1, window_min_size_2, window_min_size,
5297 size_window, window_fixed_size_p, enlarge_window, delete_window.
5298 Remove static from declaration of Qdelete_window, it's
5299 temporarily needed by Fbury_buffer.
5300 (replace_window): Don't assign orig_top_line and
5301 orig_total_lines.
5302 (Fdelete_window, delete_window): Remove. Window deletion is
5303 handled by window.el.
640c8776
SM
5304 (window_loop): Remove DELETE_OTHER_WINDOWS case.
5305 Replace Fdelete_window calls with calls to Qdelete_window.
562dd5e9
MR
5306 (Fdelete_other_windows): Remove. Deleting other windows is
5307 handled by window.el.
5308 (window_fixed_size_p): Remove. Fixed-sizeness of windows is
5309 handled in window.el.
5310 (window_min_size_2, window_min_size_1, window_min_size): Remove.
5311 Window minimum sizes are handled in window.el.
5312 (shrink_windows, size_window, set_window_height)
5313 (set_window_width, change_window_heights, window_height)
5314 (window_width, CURBEG, CURSIZE, enlarge_window)
5315 (adjust_window_trailing_edge, Fadjust_window_trailing_edge)
5316 (Fenlarge_window, Fshrink_window): Remove. Window resizing is
5317 handled in window.el.
5318 (make_dummy_parent): Rename to make_parent_window and give it a
5319 second argument horflag.
5320 (make_window): Don't set resize_proportionally any more.
5321 (Fsplit_window): Remove. Windows are split in window.el.
5322 (save_restore_action, save_restore_orig_size)
5323 (shrink_window_lowest_first, save_restore_orig_size): Remove.
5324 Resize mini windows in window.el.
5325 (grow_mini_window, shrink_mini_window): Implement by calling
5326 Qresize_root_window_vertically, resize_window_check and
5327 resize_window_apply.
640c8776
SM
5328 (saved_window, Fset_window_configuration, save_window_save):
5329 Do not handle orig_top_line, orig_total_lines, and
562dd5e9
MR
5330 resize_proportionally.
5331 (window_min_height, window_min_width): Move to window.el.
5332 (keys_of_window): Move bindings for delete-other-windows,
5333 split-window, delete-window and enlarge-window to window.el.
5334
5335 * buffer.c: Temporarily extern Qdelete_window.
5336 (Fbury_buffer): Temporarily call Qdelete_window instead of
5337 Fdelete_window (Fbury_buffer will move to window.el soon).
5338
5339 * frame.c (set_menu_bar_lines_1): Remove code handling
5340 orig_top_line and orig_total_lines.
5341
5342 * dispnew.c (adjust_frame_glyphs_initially): Don't use
5343 set_window_height but set heights directly.
5344 (change_frame_size_1): Use resize_frame_windows.
5345
5346 * xdisp.c (init_xdisp): Don't use set_window_height but set
5347 heights directly.
5348
640c8776
SM
5349 * xfns.c (x_set_menu_bar_lines, x_set_tool_bar_lines):
5350 Use resize_frame_windows instead of change_window_heights and run
562dd5e9
MR
5351 run_window_configuration_change_hook.
5352
5353 * w32fns.c (x_set_tool_bar_lines): Use resize_frame_windows
5354 instead of change_window_heights and run
5355 run_window_configuration_change_hook.
5356
1a13852e
MR
53572011-06-09 Martin Rudalics <rudalics@gmx.at>
5358
5359 * window.c (replace_window): Rename second argument REPLACEMENT to
5360 NEW. New third argument SETFLAG. Rewrite.
5361 (delete_window, make_dummy_parent): Call replace_window with
5362 third argument 1.
5363 (window_list_1): Move down in code.
5364 (run_window_configuration_change_hook): Move set_buffer part
5365 before select_frame_norecord part in order to unwind correctly.
5366 Rename count1 to count.
5367 (recombine_windows, delete_deletable_window, resize_root_window)
5368 (Fdelete_other_windows_internal)
5369 (Frun_window_configuration_change_hook, make_parent_window)
5370 (resize_window_check, resize_window_apply, Fresize_window_apply)
5371 (resize_frame_windows, Fsplit_window_internal)
640c8776
SM
5372 (Fdelete_window_internal, Fresize_mini_window_internal):
5373 New functions.
1a13852e
MR
5374 (syms_of_window): New variables Vwindow_splits and Vwindow_nest.
5375
f3d1777e
MR
53762011-06-08 Martin Rudalics <rudalics@gmx.at>
5377
496e208e
MR
5378 * window.h (window): Add some new members to window structure -
5379 normal_lines, normal_cols, new_total, new_normal, clone_number,
5380 splits, nest, prev_buffers, next_buffers.
5381 (WINDOW_TOTAL_SIZE): Move here from window.c.
b9e809c2 5382 (MIN_SAFE_WINDOW_WIDTH, MIN_SAFE_WINDOW_HEIGHT): Define here.
496e208e 5383
f3d1777e
MR
5384 * window.c (Fwindow_height, Fwindow_width, Fwindow_full_width_p):
5385 Remove.
496e208e
MR
5386 (make_dummy_parent): Set new members of windows structure.
5387 (make_window): Move down in code. Handle new members of window
5388 structure.
5389 (Fwindow_clone_number, Fwindow_splits, Fset_window_splits)
5390 (Fwindow_nest, Fset_window_nest, Fwindow_new_total)
5391 (Fwindow_normal_size, Fwindow_new_normal, Fwindow_prev_buffers)
5392 (Fset_window_prev_buffers, Fwindow_next_buffers)
640c8776
SM
5393 (Fset_window_next_buffers, Fset_window_clone_number):
5394 New functions.
496e208e
MR
5395 (Fwindow_hscroll, Fwindow_at, Fwindow_point, Fwindow_start)
5396 (Fwindow_end, Fwindow_line_height, Fset_window_dedicated_p):
5397 Doc-string fixes.
5398 (Fwindow_parameters, Fwindow_parameter, Fset_window_parameter):
5399 Argument WINDOW can be now internal window too.
5400 (Fwindow_use_time): Move up in code.
5401 (Fget_buffer_window): Rename argument FRAME to ALL-FRAMES.
5402 Rewrite doc-string.
5403 (Fset_window_configuration, saved_window)
5404 (Fcurrent_window_configuration, save_window_save): Handle new
5405 members of window structure.
b9e809c2
MR
5406 (WINDOW_TOTAL_SIZE, MIN_SAFE_WINDOW_WIDTH)
5407 (MIN_SAFE_WINDOW_HEIGHT): Move to window.h.
5408 (syms_of_window): New Lisp objects Qrecord_window_buffer,
5409 Qwindow_deletable_p, Qdelete_window, Qreplace_buffer_in_windows,
5410 Qget_mru_window, Qresize_root_window,
5411 Qresize_root_window_vertically, Qsafe, Qabove, Qbelow,
5412 Qauto_buffer_name; staticpro them.
f3d1777e 5413
abde8f8c
MR
54142011-06-07 Martin Rudalics <rudalics@gmx.at>
5415
5416 * window.c (Fwindow_total_size, Fwindow_left_column)
5417 (Fwindow_top_line, window_body_lines, Fwindow_body_size)
5418 (Fwindow_list_1): New functions.
5419 (window_box_text_cols): Replace with window_body_cols.
640c8776
SM
5420 (Fwindow_width, Fscroll_left, Fscroll_right):
5421 Use window_body_cols instead of window_box_text_cols.
5422 (delete_window, Fset_window_configuration):
5423 Call delete_all_subwindows with window as argument.
fa8a67e6
MR
5424 (delete_all_subwindows): Take a window as argument and not a
5425 structure. Rewrite.
190b47e6
MR
5426 (window_loop): Remove handling of GET_LRU_WINDOW and
5427 GET_LARGEST_WINDOW.
5428 (Fget_lru_window, Fget_largest_window): Move to window.el.
abde8f8c
MR
5429
5430 * window.h: Extern window_body_cols instead of
fa8a67e6
MR
5431 window_box_text_cols. delete_all_subwindows now takes a
5432 Lisp_Object as argument.
abde8f8c 5433
640c8776
SM
5434 * indent.c (compute_motion, Fcompute_motion):
5435 Use window_body_cols instead of window_box_text_cols.
abde8f8c 5436
fa8a67e6
MR
5437 * frame.c (delete_frame): Call delete_all_subwindows with root
5438 window as argument.
5439
a54e3482
DC
54402011-06-07 Daniel Colascione <dan.colascione@gmail.com>
5441
5442 * fns.c (Fputhash): Document return value.
5443
60002bf5
CY
54442011-06-06 Chong Yidong <cyd@stupidchicken.com>
5445
5446 * image.c (gif_load): Implement gif89a spec "no disposal" method.
5447
0c671da6 54482011-06-06 Paul Eggert <eggert@cs.ucla.edu>
ccd9a01a 5449
b862a52a 5450 Cons<->int and similar integer overflow fixes (Bug#8794).
77984278 5451
be44ca6c
PE
5452 Check for overflow when converting integer to cons and back.
5453 * charset.c (Fdefine_charset_internal, Fdecode_char):
5454 Use cons_to_unsigned to catch overflow.
5455 (Fencode_char): Use INTEGER_TO_CONS.
5456 * composite.h (LGLYPH_CODE): Use cons_to_unsigned.
5457 (LGLYPH_SET_CODE): Use INTEGER_TO_CONS.
5458 * data.c (long_to_cons, cons_to_long): Remove.
5459 (cons_to_unsigned, cons_to_signed): New functions.
5460 These signal an error for invalid or out-of-range values.
5461 * dired.c (Ffile_attributes): Use INTEGER_TO_CONS.
5462 * fileio.c (Fset_visited_file_modtime): Use CONS_TO_INTEGER.
5463 * font.c (Ffont_variation_glyphs):
5464 * fontset.c (Finternal_char_font): Use INTEGER_TO_CONS.
5465 * lisp.h: Include <intprops.h>.
5466 (INTEGER_TO_CONS, CONS_TO_INTEGER): New macros.
5467 (cons_to_signed, cons_to_unsigned): New decls.
5468 (long_to_cons, cons_to_long): Remove decls.
5469 * undo.c (record_first_change): Use INTEGER_TO_CONS.
5470 (Fprimitive_undo): Use CONS_TO_INTEGER.
5471 * xfns.c (Fx_window_property): Likewise.
5472 * xselect.c: Include <limits.h>.
5473 (x_own_selection, selection_data_to_lisp_data):
5474 Use INTEGER_TO_CONS.
5475 (x_handle_selection_request, x_handle_selection_clear)
5476 (x_get_foreign_selection, Fx_disown_selection_internal)
5477 (Fx_get_atom_name, x_send_client_event): Use CONS_TO_INTEGER.
5478 (lisp_data_to_selection_data): Use cons_to_unsigned.
5479 (x_fill_property_data): Use cons_to_signed.
5480 Report values out of range.
5481
d1f3d2af
PE
5482 Check for buffer and string overflow more precisely.
5483 * buffer.h (BUF_BYTES_MAX): New macro.
5484 * lisp.h (STRING_BYTES_MAX): New macro.
5485 * alloc.c (Fmake_string):
5486 * character.c (string_escape_byte8):
5487 * coding.c (coding_alloc_by_realloc):
5488 * doprnt.c (doprnt):
5489 * editfns.c (Fformat):
5490 * eval.c (verror):
5491 Use STRING_BYTES_MAX, not MOST_POSITIVE_FIXNUM,
5492 since they may not be the same number.
5493 * editfns.c (Finsert_char):
5494 * fileio.c (Finsert_file_contents):
5495 Likewise for BUF_BYTES_MAX.
5496
dd52fcea
PE
5497 * image.c: Use ptrdiff_t, not int, for sizes.
5498 (slurp_file): Switch from int to ptrdiff_t.
5499 All uses changed.
5500 (slurp_file): Check that file size fits in both size_t (for
5501 malloc) and ptrdiff_t (for sanity and safety).
5502
7f9bbdbb
PE
5503 * fileio.c (Fverify_visited_file_modtime): Avoid time overflow
5504 if b->modtime has its maximal value.
5505
dfe18f82
PE
5506 * dired.c (Ffile_attributes): Don't assume EMACS_INT has >32 bits.
5507
84acfcf0
PE
5508 Don't assume time_t can fit into int.
5509 * buffer.h (struct buffer.modtime): Now time_t, not int.
5510 * fileio.c (Fvisited_file_modtime): No need for time_t cast now.
5511 * undo.c (Fprimitive_undo): Use time_t, not int, for time_t value.
5512
ccd9a01a
PE
5513 Minor fixes for signed vs unsigned integers.
5514 * character.h (MAYBE_UNIFY_CHAR):
5515 * charset.c (maybe_unify_char):
5516 * keyboard.c (read_char, reorder_modifiers):
5517 XINT -> XFASTINT, since the integer must be nonnegative.
5518 * ftfont.c (ftfont_spec_pattern):
5519 * keymap.c (access_keymap, silly_event_symbol_error):
5520 XUINT -> XFASTINT, since the integer must be nonnegative.
5521 (Fsingle_key_description, preferred_sequence_p): XUINT -> XINT,
5522 since it makes no difference and we prefer signed.
5523 * keyboard.c (record_char): Use XUINT when all the neighbors do.
5524 (access_keymap): NATNUMP -> INTEGERP, since the integer must be
5525 nonnegative.
5526
d6d100dd
SM
55272011-06-06 Stefan Monnier <monnier@iro.umontreal.ca>
5528
5529 * window.h (Fwindow_frame): Declare.
5530
2b6148e4
PE
55312011-06-06 Paul Eggert <eggert@cs.ucla.edu>
5532
5533 * alloc.c: Simplify handling of large-request failures (Bug#8800).
5534 (SPARE_MEMORY): Always define.
5535 (LARGE_REQUEST): Remove.
5536 (memory_full): Use SPARE_MEMORY rather than LARGE_REQUEST.
5537
f230ecc9
MR
55382011-06-06 Martin Rudalics <rudalics@gmx.at>
5539
727e958e
MR
5540 * lisp.h: Move EXFUNS for Fframe_root_window,
5541 Fframe_first_window and Fset_frame_selected_window to window.h.
5542
5543 * window.h: Move EXFUNS for Fframe_root_window,
5544 Fframe_first_window and Fset_frame_selected_window here from
5545 lisp.h.
5546
5547 * frame.c (Fwindow_frame, Fframe_first_window)
5548 (Fframe_root_window, Fframe_selected_window)
5549 (Fset_frame_selected_window): Move to window.c.
5550 (Factive_minibuffer_window): Move to minibuf.c.
5551 (Fother_visible_frames_p): New function.
5552
5553 * minibuf.c (Factive_minibuffer_window): Move here from frame.c.
5554
f230ecc9
MR
5555 * window.c (decode_window, decode_any_window): Move up in code.
5556 (Fwindowp, Fwindow_live_p): Rewrite doc-strings.
5557 (inhibit_frame_unsplittable): Remove unused variable.
bf60a96b
MR
5558 (Fwindow_buffer): Move up and rewrite doc-string.
5559 (Fwindow_parent, Fwindow_vchild, Fwindow_hchild, Fwindow_next)
5560 (Fwindow_prev): New functions.
727e958e
MR
5561 (Fwindow_frame): Move here from frame.c. Accept any window as
5562 argument.
5563 (Fframe_root_window, Fframe_first_window)
5564 (Fframe_selected_window): Move here from frame.c. Accept frame
5565 or arbitrary window as argument. Update doc-strings.
5566 (Fminibuffer_window): Move up in code.
5567 (Fwindow_minibuffer_p): Move up in code and simplify.
d6d100dd
SM
5568 (Fset_frame_selected_window): Move here from frame.c.
5569 Marginal rewrite.
727e958e
MR
5570 (Fselected_window, select_window, Fselect_window): Move up in
5571 code. Minor doc-string fixes.
f230ecc9 5572
4d09bcf6
PE
55732011-06-06 Paul Eggert <eggert@cs.ucla.edu>
5574
5575 * alloc.c (memory_full) [SYSTEM_MALLOC]: Port to MacOS (Bug#8800).
5576 Do not assume that spare memory exists; that assumption is valid
5577 only if SYSTEM_MALLOC.
5578 (LARGE_REQUEST): New macro, so that the issue of large requests
5579 is separated from the issue of spare memory.
5580
810928a2
AS
55812011-06-05 Andreas Schwab <schwab@linux-m68k.org>
5582
172418ad
AS
5583 * editfns.c (Fformat): Correctly handle zero flag with hexadecimal
5584 format. (Bug#8806)
5585
43f862f7
AS
5586 * gtkutil.c (xg_get_default_scrollbar_width): Avoid warning.
5587
810928a2
AS
5588 * xfns.c (x_set_scroll_bar_default_width): Move declarations
5589 before statements.
5590
a059fe24
JD
55912011-06-05 Jan Djärv <jan.h.d@swipnet.se>
5592
5593 * gtkutil.c (xg_get_default_scrollbar_width): New function.
5594
5595 * gtkutil.h: Declare xg_get_default_scrollbar_width.
5596
5597 * xfns.c (x_set_scroll_bar_default_width): If USE_GTK, get
5598 min width by calling x_set_scroll_bar_default_width (Bug#8505).
5599
989bf368
JB
56002011-06-05 Juanma Barranquero <lekktu@gmail.com>
5601
5602 * xdisp.c (single_display_spec_intangible_p): Remove declaration.
5603
4b80f674
CY
56042011-06-04 Chong Yidong <cyd@stupidchicken.com>
5605
5606 * xselect.c (x_clipboard_manager_save): Remove redundant arg.
5607 (x_clipboard_manager_save): Add return value.
d6d100dd
SM
5608 (x_clipboard_manager_error_1, x_clipboard_manager_error_2):
5609 New error handlers.
4b80f674
CY
5610 (x_clipboard_manager_save_frame, x_clipboard_manager_save_all):
5611 Obey Vx_select_enable_clipboard_manager. Catch errors in
5612 x_clipboard_manager_save (Bug#8779).
5613 (Vx_select_enable_clipboard_manager): New variable.
de65b42c 5614 (x_get_foreign_selection): Reduce scope of x_catch_errors (Bug#8790).
4b80f674 5615
99a33b77 56162011-06-04 Dan Nicolaescu <dann@ics.uci.edu>
8b3115e7
DN
5617
5618 * emacs.c (main): Warn when starting a GTK emacs in daemon mode.
5619
99a33b77 56202011-06-04 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
14eca62f
YM
5621
5622 * fringe.c (update_window_fringes): Don't update overlay arrow bitmap
5623 in the current matrix if keep_current_p is non-zero.
5624
8264569d
EZ
56252011-06-04 Eli Zaretskii <eliz@gnu.org>
5626
5627 * bidi.c (bidi_level_of_next_char): Fix last change.
5628
57f97249
EZ
56292011-06-03 Eli Zaretskii <eliz@gnu.org>
5630
fec2107c 5631 Support bidi reordering of text covered by display properties.
57f97249 5632
fec2107c
EZ
5633 * bidi.c (bidi_copy_it): Use offsetof instead of emulating it.
5634 (bidi_fetch_char, bidi_fetch_char_advance): New functions.
5635 (bidi_cache_search, bidi_cache_iterator_state)
5636 (bidi_paragraph_init, bidi_resolve_explicit, bidi_resolve_weak)
d6d100dd
SM
5637 (bidi_level_of_next_char, bidi_move_to_visually_next):
5638 Support character positions inside a run of characters covered by a
fec2107c
EZ
5639 display string.
5640 (bidi_paragraph_init, bidi_resolve_explicit_1)
5641 (bidi_level_of_next_char): Call bidi_fetch_char and
5642 bidi_fetch_char_advance instead of FETCH_CHAR and
5643 FETCH_CHAR_ADVANCE.
5644 (bidi_init_it): Initialize new members.
5645 (LRE_CHAR, RLE_CHAR, PDF_CHAR, LRO_CHAR, RLO_CHAR): Remove macro
5646 definitions.
5647 (bidi_explicit_dir_char): Lookup character type in bidi_type_table,
5648 instead of using explicit *_CHAR codes.
d6d100dd
SM
5649 (bidi_resolve_explicit, bidi_resolve_weak):
5650 Use FETCH_MULTIBYTE_CHAR instead of FETCH_CHAR, as reordering of
fec2107c
EZ
5651 bidirectional text is supported only in multibyte buffers.
5652 (bidi_init_it): Accept additional argument FRAME_WINDOW_P and use
5653 it to initialize the frame_window_p member of struct bidi_it.
5654 (bidi_cache_iterator_state, bidi_resolve_explicit_1)
5655 (bidi_resolve_explicit, bidi_resolve_weak)
5656 (bidi_level_of_next_char, bidi_move_to_visually_next): Abort if
5657 bidi_it->nchars is non-positive.
5658 (bidi_level_of_next_char): Don't try to lookup the cache for the
5659 next/previous character if nothing is cached there yet, or if we
5660 were just reseat()'ed to a new position.
c40e2fb2 5661
0e14fe90
EZ
5662 * xdisp.c (set_cursor_from_row): Set start and stop points
5663 according to the row's direction when priming the loop that looks
5664 for the glyph on which to display cursor.
5665 (single_display_spec_intangible_p): Function deleted.
5666 (display_prop_intangible_p): Reimplement to call
5667 handle_display_spec instead of single_display_spec_intangible_p.
d6d100dd
SM
5668 Accept 3 additional arguments needed by handle_display_spec.
5669 This fixes incorrect cursor motion across display property with complex
0e14fe90
EZ
5670 values: lists, `(when COND...)' forms, etc.
5671 (single_display_spec_string_p): Support property values that are
5672 lists with the argument STRING its top-level element.
5673 (display_prop_string_p): Fix the condition for processing a
5674 property that is a list to be consistent with handle_display_spec.
fec2107c 5675 (handle_display_spec): New function, refactored from the
fc6f18ce
EZ
5676 last portion of handle_display_prop.
5677 (compute_display_string_pos): Accept additional argument
5678 FRAME_WINDOW_P. Call handle_display_spec to determine whether the
5679 value of a `display' property is a "replacing spec".
5680 (handle_single_display_spec): Accept 2 additional arguments BUFPOS
5681 and FRAME_WINDOW_P. If IT is NULL, don't set up the iterator from
5682 the display property, but just return a value indicating whether
5683 the display property will replace the characters it covers.
5684 (Fcurrent_bidi_paragraph_direction): Initialize the nchars and
5685 frame_window_p members of struct bidi_it.
d6d100dd
SM
5686 (compute_display_string_pos, compute_display_string_end):
5687 New functions.
fec2107c
EZ
5688 (push_it): Accept second argument POSITION, where pop_it should
5689 jump to continue iteration.
5690 (reseat_1): Initialize bidi_it.disp_pos.
fc6f18ce 5691
fec2107c
EZ
5692 * keyboard.c (adjust_point_for_property): Adjust the call to
5693 display_prop_intangible_p to its new signature.
fc6f18ce
EZ
5694
5695 * dispextern.h (struct bidi_it): New member frame_window_p.
fec2107c
EZ
5696 (bidi_init_it): Update prototypes.
5697 (display_prop_intangible_p): Update prototype.
d6d100dd
SM
5698 (compute_display_string_pos, compute_display_string_end):
5699 Declare prototypes.
fec2107c
EZ
5700 (struct bidi_it): New members nchars and disp_pos. ch_len is now
5701 EMACS_INT.
fc6f18ce 5702
40087514 57032011-06-02 Paul Eggert <eggert@cs.ucla.edu>
0de4bb68 5704
57f53182
PE
5705 Malloc failure behavior now depends on size of allocation.
5706 * alloc.c (buffer_memory_full, memory_full): New arg NBYTES.
5707 * lisp.h: Change signatures accordingly.
5708 * alloc.c, buffer.c, editfns.c, menu.c, minibuf.c, xterm.c:
5709 All callers changed. (Bug#8762)
5710
5711 * gnutls.c: Use Emacs's memory allocators.
5712 Without this change, the gnutls library would invoke malloc etc.
5713 directly, which causes problems on non-SYNC_INPUT hosts, and which
5714 runs afoul of improving memory_full behavior. (Bug#8761)
5715 (fn_gnutls_global_set_mem_functions): New macro or function pointer.
5716 (emacs_gnutls_global_init): Use it to specify xmalloc, xrealloc,
5717 xfree instead of the default malloc, realloc, free.
5718 (Fgnutls_boot): No need to check for memory allocation failure,
5719 since xmalloc does that for us.
5720
ac32cd99 5721 Remove arbitrary limit of 2**31 entries in hash tables. (Bug#8771)
3870d916
PE
5722 * category.c (hash_get_category_set):
5723 * ccl.c (ccl_driver):
5724 * charset.c (Fdefine_charset_internal):
5725 * charset.h (struct charset.hash_index):
5726 * composite.c (get_composition_id, gstring_lookup_cache)
5727 (composition_gstring_put_cache):
5728 * composite.h (struct composition.hash_index):
5729 * dispextern.h (struct image.hash):
5730 * fns.c (next_almost_prime, larger_vector, cmpfn_eql)
5731 (cmpfn_equal, cmpfn_user_defined, hashfn_eq, hashfn_eql)
5732 (hashfn_equal, hashfn_user_defined, make_hash_table)
5733 (maybe_resize_hash_table, hash_lookup, hash_put)
5734 (hash_remove_from_table, hash_clear, sweep_weak_table, SXHASH_COMBINE)
5735 (sxhash_string, sxhash_list, sxhash_vector, sxhash_bool_vector)
5736 (Fsxhash, Fgethash, Fputhash, Fmaphash):
5737 * image.c (make_image, search_image_cache, lookup_image)
5738 (xpm_put_color_table_h):
5739 * lisp.h (struct Lisp_Hash_Table):
0de4bb68 5740 * minibuf.c (Ftry_completion, Fall_completions, Ftest_completion):
ac389d0c 5741 * print.c (print): Use 'EMACS_UINT' and 'EMACS_INT'
3870d916 5742 for hashes and hash indexes, instead of 'unsigned' and 'int'.
40087514
PE
5743 * alloc.c (allocate_vectorlike):
5744 Check for overflow in vector size calculations.
5745 * ccl.c (ccl_driver):
5746 Check for overflow when converting EMACS_INT to int.
0de4bb68
PE
5747 * fns.c, image.c: Remove unnecessary static decls that would otherwise
5748 need to be updated by these changes.
40087514
PE
5749 * fns.c (make_hash_table, maybe_resize_hash_table):
5750 Check for integer overflow with large hash tables.
0de4bb68
PE
5751 (make_hash_table, maybe_resize_hash_table, Fmake_hash_table):
5752 Prefer the faster XFLOAT_DATA to XFLOATINT where either will do.
5753 (SXHASH_REDUCE): New macro.
5754 (sxhash_string, sxhash_list, sxhash_vector, sxhash_bool_vector):
5755 Use it instead of discarding useful hash info with large hash values.
5756 (sxhash_float): New function.
5757 (sxhash): Use it. No more need for "& INTMASK" due to above changes.
5758 * lisp.h (FIXNUM_BITS): New macro, useful for SXHASH_REDUCE etc.
40087514
PE
5759 (MOST_NEGATIVE_FIXNUM, MOST_POSITIVE_FIXNUM, INTMASK):
5760 Rewrite to use FIXNUM_BITS, as this simplifies things.
0de4bb68
PE
5761 (next_almost_prime, larger_vector, sxhash, hash_lookup, hash_put):
5762 Adjust signatures to match updated version of code.
5763 (consing_since_gc): Now EMACS_INT, since a single hash table can
5764 use more than INT_MAX bytes.
5765
698d32e2
DN
57662011-06-01 Dan Nicolaescu <dann@ics.uci.edu>
5767
5768 Make it possible to build with GCC-4.6+ -O2 -flto.
5769
5770 * emacs.c (__malloc_initialize_hook): Mark as EXTERNALLY_VISIBLE.
5771
fd6fa53f
SM
57722011-06-01 Stefan Monnier <monnier@iro.umontreal.ca>
5773
5774 * minibuf.c (get_minibuffer, read_minibuf_unwind):
5775 Call minibuffer-inactive-mode.
5776
864db017
JB
57772011-05-31 Juanma Barranquero <lekktu@gmail.com>
5778
5779 * makefile.w32-in ($(BLD)/data.$(O), $(BLD)/editfns.$(O)):
5780 Update dependencies.
5781
2ad0baf4
DN
57822011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
5783
5784 * data.c (init_data): Remove code for UTS, this system is not
5785 supported anymore.
5786
4fcc2638
DN
57872011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
5788
5789 Don't force ./temacs to start in terminal mode.
5790
5791 * frame.c (make_initial_frame): Initialize faces in all cases, not
5792 only when CANNOT_DUMP is defined.
5793 * dispnew.c (init_display): Remove CANNOT_DUMP condition.
5794
c56e0fd5
DN
57952011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
5796
5797 * dispnew.c (add_window_display_history): Use const for the string
5798 pointer. Remove declaration, not needed.
5799
333d54da 58002011-05-31 Paul Eggert <eggert@cs.ucla.edu>
9cf9f756 5801
55d4c1b2 5802 Use 'inline', not 'INLINE'.
333d54da 5803 <http://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00914.html>
55d4c1b2
PE
5804 * alloc.c, fontset.c (INLINE): Remove.
5805 * alloc.c, bidi.c, charset.c, coding.c, dispnew.c, fns.c, image.c:
5806 * intervals.c, keyboard.c, process.c, syntax.c, textprop.c, w32term.c:
5807 * xdisp.c, xfaces.c, xterm.c: Replace all uses of INLINE with inline.
5808 * gmalloc.c (register_heapinfo): Use inline unconditionally.
5809 * lisp.h (LISP_MAKE_RVALUE): Use inline, not __inline__.
5810
738db178
DN
58112011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
5812
5813 Make it possible to run ./temacs.
5814
5815 * callproc.c (set_initial_environment): Remove CANNOT_DUMP code,
5816 syms_of_callproc does the same thing. Remove test for
5817 "initialized", do it in the caller.
5818 * emacs.c (main): Avoid calling set_initial_environment when dumping.
5819
620c53a6
SM
58202011-05-31 Stefan Monnier <monnier@iro.umontreal.ca>
5821
5822 * minibuf.c (Finternal_complete_buffer): Return `category' metadata.
5823 (read_minibuf): Use get_minibuffer.
5824 (syms_of_minibuf): Use DEFSYM.
5825 (Qmetadata): New var.
5826 * data.c (Qbuffer): Don't make it static.
5827 (syms_of_data): Use DEFSYM.
5828
e003a292
PE
58292011-05-31 Paul Eggert <eggert@cs.ucla.edu>
5830
5831 * ccl.c (CCL_CODE_RANGE): Allow negative numbers. (Bug#8751)
5832 (CCL_CODE_MIN): New macro.
5833
ed008a6d
PE
58342011-05-30 Paul Eggert <eggert@cs.ucla.edu>
5835
3687c2ef
PE
5836 * alloc.c (lisp_align_malloc): Omit unnecessary val==NULL tests.
5837
ed008a6d
PE
5838 * eval.c (Qdebug): Now static.
5839 * lisp.h (Qdebug): Remove decl. This reverts a part of the
5840 2011-04-26T11:26:05Z!dan.colascione@gmail.com that inadvertently undid part of
5841 2011-04-14T06:48:41Z!eggert@cs.ucla.edu.
5842
d66c4c7c
CY
58432011-05-29 Chong Yidong <cyd@stupidchicken.com>
5844
5845 * image.c: Various fixes to ImageMagick code comments.
5846 (Fimagemagick_types): Doc fix.
5847
5fbc2025
PE
58482011-05-29 Paul Eggert <eggert@cs.ucla.edu>
5849
0196f88a
PE
5850 Minor fixes prompted by GCC 4.6.0 warnings.
5851
5852 * xselect.c (converted_selections, conversion_fail_tag): Now static.
5853
5fbc2025
PE
5854 * emacs.c [HAVE_X_WINDOWS]: Include "xterm.h".
5855 (x_clipboard_manager_save_all): Move extern decl to ...
5856 * xterm.h: ... here, so that it can be checked for consistency.
5857
1dd3c2d9
CY
58582011-05-29 Chong Yidong <cyd@stupidchicken.com>
5859
5860 * xselect.c (x_clipboard_manager_save_frame)
5861 (x_clipboard_manager_save_all): New functions.
5862 (Fx_clipboard_manager_save): Lisp function deleted.
5863
5864 * emacs.c (Fkill_emacs): Call x_clipboard_manager_save_all.
5865 * frame.c (delete_frame): Call x_clipboard_manager_save_frame.
5866
5867 * xterm.h: Update prototype.
5868
5ba6571d
WX
58692011-05-28 William Xu <william.xwl@gmail.com>
5870
5871 * nsterm.m (ns_term_shutdown): Synchronize user defaults before
5872 exiting (Bug#8239).
5873
3eaff834
JM
58742011-05-28 Jim Meyering <meyering@redhat.com>
5875
e1900994 5876 Avoid a sign-extension bug in crypto_hash_function.
3eaff834
JM
5877 * fns.c (to_uchar): Define.
5878 (crypto_hash_function): Use it to convert some newly-signed
5879 variables to unsigned, to avoid sign-extension bugs. For example,
5880 without this change, (md5 "truc") would evaluate to
5881 45723a2aff78ff4fff7fff1114760e62 rather than the expected
5882 45723a2af3788c4ff17f8d1114760e62. Reported by Antoine Levitt in
e1900994 5883 https://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00883.html.
3eaff834 5884
0f6990a7
PE
58852011-05-27 Paul Eggert <eggert@cs.ucla.edu>
5886
5887 Integer overflow fixes.
c8a9ca5a 5888
08686060
PE
5889 * dbusbind.c: Serial number integer overflow fixes.
5890 (CHECK_DBUS_SERIAL_GET_SERIAL): New macro.
08686060
PE
5891 (Fdbus_call_method_asynchronously, xd_read_message_1): Use a float
5892 to hold a serial number that is too large for a fixnum.
5893 (Fdbus_method_return_internal, Fdbus_method_error_internal):
5894 Check for serial numbers out of range. Decode any serial number
59568bf0 5895 that was so large that it became a float. (Bug#8722)
08686060 5896
2d1fc3c7
PE
5897 * dbusbind.c: Use XFASTINT rather than XUINT, and check for nonneg.
5898 (Fdbus_call_method, Fdbus_call_method_asynchronously):
5899 Use XFASTINT rather than XUINT when numbers are nonnegative.
5900 (xd_append_arg, Fdbus_method_return_internal):
5901 (Fdbus_method_error_internal): Likewise. Also, for unsigned
5902 arguments, check that Lisp number is nonnegative, rather than
59568bf0 5903 silently wrapping negative numbers around. (Bug#8722)
30217ff0 5904 (xd_read_message_1): Don't assume dbus_uint32_t can fit in int.
59568bf0 5905 (Bug#8722)
2d1fc3c7 5906
c8a9ca5a
PE
5907 * data.c (arith_driver, Flsh): Avoid unnecessary casts to EMACS_UINT.
5908
519e1d69
PE
5909 * ccl.c (ccl_driver): Redo slightly to avoid the need for 'unsigned'.
5910
6df6ae42 5911 ccl: Add integer overflow checks.
30569699
PE
5912 * ccl.c (CCL_CODE_MAX, GET_CCL_RANGE, GET_CCL_CODE, GET_CCL_INT):
5913 (IN_INT_RANGE): New macros.
5914 (ccl_driver): Use them to check for integer overflow when
5915 decoding a CCL program. Many of the new checks are whether XINT (x)
5916 fits in int; it doesn't always, on 64-bit hosts. The new version
5917 doesn't catch all possible integer overflows, but it's an
847044ea 5918 improvement. (Bug#8719)
30569699 5919
c11285dc
PE
5920 * alloc.c (make_event_array): Use XINT, not XUINT.
5921 There's no need for unsigned here.
5922
fdccd48e
PE
5923 * mem-limits.h (EXCEEDS_LISP_PTR) [!USE_LSB_TAG]: EMACS_UINT -> uintptr_t
5924 This follows up to the 2011-05-06 change that substituted uintptr_t
5925 for EMACS_INT. This case wasn't caught back then.
5926
37910ab2
PE
5927 Rework Fformat to avoid integer overflow issues.
5928 * editfns.c: Include <float.h> unconditionally, as it's everywhere
5929 now (part of C89). Include <verify.h>.
5930 (MAX_10_EXP, CONVERTED_BYTE_SIZE): Remove; no longer needed.
5931 (pWIDE, pWIDElen, signed_wide, unsigned_wide): New defns.
5932 (Fformat): Avoid the prepass trying to compute sizes; it was only
5933 approximate and thus did not catch overflow reliably. Instead, walk
5934 through the format just once, formatting and computing sizes as we go,
5935 checking for integer overflow at every step, and allocating a larger
5936 buffer as needed. Keep track separately whether the format is
5937 multibyte. Keep only the most-recently calculated precision, rather
5938 than them all. Record whether each argument has been converted to
5939 string. Use EMACS_INT, not int, for byte and char and arg counts.
5940 Support field widths and precisions larger than INT_MAX. Avoid
5941 sprintf's undefined behavior with conversion specifications such as %#d
5942 and %.0c. Fix bug with strchr succeeding on '\0' when looking for
5943 flags. Fix bug with (format "%c" 256.0). Avoid integer overflow when
5944 formatting out-of-range floating point numbers with int
9173deec 5945 formats. (Bug#8668)
37910ab2 5946
2e6578fb
PE
5947 * lisp.h (FIXNUM_OVERFLOW_P): Work even if arg is a NaN.
5948
0ae6bdee
PE
5949 * data.c: Avoid integer truncation in expressions involving floats.
5950 * data.c: Include <intprops.h>.
5951 (arith_driver): When there's an integer overflow in an expression
5952 involving floating point, convert the integers to floating point
5953 so that the resulting value does not suffer from catastrophic
5954 integer truncation. For example, on a 64-bit host (* 4
5955 most-negative-fixnum 0.5) should yield about -4.6e+18, not zero.
5956 Do not rely on undefined behavior after integer overflow.
5957
de883a70
PE
5958 merge count_size_as_multibyte, parse_str_to_multibyte
5959 * character.c, character.h (count_size_as_multibyte):
fd6fa53f 5960 Rename from parse_str_to_multibyte; all uses changed.
de883a70
PE
5961 Check for integer overflow.
5962 * insdel.c, lisp.h (count_size_as_multibyte): Remove,
5963 since it's now a duplicate of the other. This is more of
5964 a character than a buffer op, so better that it's in character.c.
5965 * fns.c, print.c: Adjust to above changes.
5966
2ff916cb
PE
59672011-05-27 Stefan Monnier <monnier@iro.umontreal.ca>
5968
5969 * xselect.c (x_convert_selection): Yet another int/Lisp_Object mixup.
5970
f1b54466
PE
59712011-05-27 Paul Eggert <eggert@cs.ucla.edu>
5972
fb1ac845
PE
5973 * xselect.c: Fix minor problems prompted by GCC 4.6.0 warnings.
5974 (x_handle_selection_request, frame_for_x_selection): Remove unused vars.
5975 (x_clipboard_manager_save): Now static.
5976 (Fx_clipboard_manager_save): Rename local to avoid shadowing.
5977
f1b54466
PE
5978 * fns.c: Fix minor problems prompted by GCC 4.6.0 warnings.
5979 (crypto_hash_function): Now static.
5980 Fix pointer signedness problems. Avoid unnecessary initializations.
5981
a9f737ee
CY
59822011-05-27 Chong Yidong <cyd@stupidchicken.com>
5983
5984 * termhooks.h (Vselection_alist): Make it terminal-local.
5985
5986 * terminal.c (create_terminal): Initialize it.
5987
5988 * xselect.c: Support for clipboard managers.
5989 (Vselection_alist): Move to termhooks.h as terminal-local var.
5990 (LOCAL_SELECTION): New macro.
5991 (x_atom_to_symbol): Handle x_display_info_for_display fail case.
5992 (symbol_to_x_atom): Remove gratuitous arg.
5993 (x_handle_selection_request, lisp_data_to_selection_data)
5994 (x_get_foreign_selection, Fx_register_dnd_atom): Callers changed.
620c53a6
SM
5995 (x_own_selection, x_get_local_selection, x_convert_selection):
5996 New arg, specifying work frame. Use terminal-local Vselection_alist.
a9f737ee
CY
5997 (some_frame_on_display): Delete unused function.
5998 (Fx_own_selection_internal, Fx_get_selection_internal)
5999 (Fx_disown_selection_internal, Fx_selection_owner_p)
6000 (Fx_selection_exists_p): New optional frame arg.
6001 (frame_for_x_selection, Fx_clipboard_manager_save): New functions.
6002 (x_handle_selection_clear): Don't treat other terminals with the
6003 same keyboard specially. Use the terminal-local Vselection_alist.
6004 (x_clear_frame_selections): Use Frun_hook_with_args.
6005
6006 * xterm.c (x_term_init): Intern ATOM and CLIPBOARD_MANAGER atoms.
6007
6008 * xterm.h: Add support for those atoms.
6009
e067f0c1
CY
60102011-05-26 Chong Yidong <cyd@stupidchicken.com>
6011
6012 * xselect.c: ICCCM-compliant handling of MULTIPLE targets.
6013 (converted_selections, conversion_fail_tag): New global variables.
6014 (x_selection_request_lisp_error): Free the above.
6015 (x_get_local_selection): Remove unnecessary code.
6016 (x_reply_selection_request): Args changed; handle arbitrary array
620c53a6
SM
6017 of converted selections stored in converted_selections.
6018 Separate the XChangeProperty and SelectionNotify steps.
e067f0c1
CY
6019 (x_handle_selection_request): Rewrite to handle MULTIPLE target.
6020 (x_convert_selection): New function.
6021 (x_handle_selection_event): Simplify.
6022 (x_get_foreign_selection): Don't ignore incoming requests while
6023 waiting for an answer; this will fail when we implement
6024 SAVE_TARGETS, and seems unnecessary anyway.
6025 (selection_data_to_lisp_data): Recognize ATOM_PAIR type.
6026 (Vx_sent_selection_functions): Doc fix.
6027
0f4aebc0
LL
60282011-05-26 Leo Liu <sdl.web@gmail.com>
6029
6030 * editfns.c (Ftranspose_regions): Allow empty regions. (Bug#8699)
6031
e61124cd
YM
60322011-05-25 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
6033
6034 * dispextern.h (struct glyph_row): New member fringe_bitmap_periodic_p.
6035
6036 * dispnew.c (shift_glyph_matrix, scrolling_window): Mark scrolled row
6037 for fringe update if it has periodic bitmap.
ac389d0c 6038 (row_equal_p): Also compare left_fringe_offset, right_fringe_offset,
e61124cd
YM
6039 and fringe_bitmap_periodic_p.
6040
6041 * fringe.c (get_fringe_bitmap_data): New function.
6042 (draw_fringe_bitmap_1, update_window_fringes): Use it.
6043 (update_window_fringes): Record periodicity of fringe bitmap in glyph
6044 row. Mark glyph row for fringe update if periodicity changed.
6045
6046 * xdisp.c (try_window_reusing_current_matrix): Don't mark scrolled row
6047 for fringe update unless it has periodic bitmap.
6048
f16d9837
KH
60492011-05-25 Kenichi Handa <handa@m17n.org>
6050
6051 * xdisp.c (get_next_display_element): Set correct it->face_id for
6052 a static composition.
6053
e1b90ef6
LL
60542011-05-24 Leo Liu <sdl.web@gmail.com>
6055
6056 * deps.mk (fns.o):
6057 * makefile.w32-in ($(BLD)/fns.$(O)): Include sha1.h.
6058
6059 * fns.c (crypto_hash_function, Fsha1): New function.
6060 (Fmd5): Use crypto_hash_function.
6061 (syms_of_fns): Add Ssha1.
6062
7400048f
PE
60632011-05-22 Paul Eggert <eggert@cs.ucla.edu>
6064
6065 * gnutls.c: Remove unused macros.
6066 (fn_gnutls_transport_set_lowat, fn_gnutls_transport_set_pull_function):
6067 (fn_gnutls_transport_set_push_function) [!WINDOWSNT]:
6068 Remove macros that are defined and never used.
6069 Caught by gcc -Wunused-macros (GCC 4.6.0, Fedora 14).
6070
abb71cf4
CY
60712011-05-22 Chong Yidong <cyd@stupidchicken.com>
6072
6073 * xselect.c (syms_of_xselect): Remove unused symbol SAVE_TARGETS.
6074 (Fx_get_selection_internal): Minor cleanup.
6075 (Fx_own_selection_internal): Rename arguments for consistency with
6076 select.el.
6077
6307db39
PE
60782011-05-22 Paul Eggert <eggert@cs.ucla.edu>
6079
6080 * xselect.c (QSAVE_TARGETS): New static var, to fix build failure.
6081
f3d4e0a4
CY
60822011-05-22 Chong Yidong <cyd@stupidchicken.com>
6083
6084 * xselect.c (syms_of_xselect): Include character.h; use DEFSYM.
6085
4d8ade89
YM
60862011-05-21 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
6087
6088 * dispnew.c (scrolling_window): Don't exclude the case that the
6089 last enabled row in the desired matrix touches the bottom boundary.
6090
32078c8d
GM
60912011-05-21 Glenn Morris <rgm@gnu.org>
6092
6093 * Makefile.in ($(etc)/DOC): Make second command line even shorter.
33cf345f
GM
6094 (SOME_MACHINE_OBJECTS): Replace FONT_OBJ by its maximal expansion,
6095 and add some more files.
32078c8d 6096
7285dc67
EZ
60972011-05-20 Eli Zaretskii <eliz@gnu.org>
6098
6099 * callproc.c (Fcall_process) [MSDOS]: Fix arguments to
6100 report_file_error introduced by the change from 2011-05-07.
6101
89d1bd22
PE
61022011-05-20 Paul Eggert <eggert@cs.ucla.edu>
6103
6104 * systime.h (Time): Define only if emacs is defined.
6105 This is to allow ../lib-src/profile.c to be compiled on FreeBSD,
6106 where the include path doesn't have X11/X.h by default. See
6107 <http://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00561.html>.
6108
cd394be1 61092011-05-20 Kenichi Handa <handa@m17n.org>
31bfc35c
KH
6110
6111 * composite.c (find_automatic_composition): Fix previous change.
6112
b9704ad9
GM
61132011-05-20 Glenn Morris <rgm@gnu.org>
6114
6115 * lisp.mk: New file, split from Makefile.in.
6116 * Makefile.in (lisp): Move to separate file, inserted by @lisp_frag@.
6117 (shortlisp): Remove.
6118 ($(etc)/DOC): Edit lisp.mk rather than using $shortlisp.
6119
4a720484
GM
61202011-05-19 Glenn Morris <rgm@gnu.org>
6121
6122 * Makefile.in (MSDOS_SUPPORT_REAL, MSDOS_SUPPORT, NS_SUPPORT)
6123 (REAL_MOUSE_SUPPORT, GPM_MOUSE_SUPPORT, MOUSE_SUPPORT, TOOLTIP_SUPPORT)
6124 (BASE_WINDOW_SUPPORT, X_WINDOW_SUPPORT, WINDOW_SUPPORT): Remove.
6125 (lisp): Set the order to that of loadup.el.
6126 (shortlisp): Make it a copy of $lisp.
6127 (SOME_MACHINE_LISP): Remove.
6128 ($(etc)/DOC): Depend just on $lisp, not $SOME_MACHINE_LISP too.
6129 Use just $shortlisp, not $SOME_MACHINE_LISP too.
6130
a28d4396
KH
61312011-05-18 Kenichi Handa <handa@m17n.org>
6132
6133 * composite.c (CHAR_COMPOSABLE_P): Add more check for efficiency.
6134 (BACKWARD_CHAR): Wrap the arg STOP by parenthesis.
6135 (find_automatic_composition): Mostly rewrite for efficiency.
6136
a2b1fa8e
JB
61372011-05-18 Juanma Barranquero <lekktu@gmail.com>
6138
6139 * makefile.w32-in: Update dependencies.
6140
8e1f5610
CS
61412011-05-18 Christoph Scholtes <cschol2112@googlemail.com>
6142
6143 * menu.c: Include limits.h (fixes the MS-Windows build broken by
7d7d0045 6144 2011-06-18T18:49:19Z!cyd@stupidchicken.com).
8e1f5610 6145
7025ee00 61462011-05-18 Paul Eggert <eggert@cs.ucla.edu>
cb93f9be 6147
cdfa6eab
PE
6148 Fix some integer overflow issues, such as string length overflow.
6149
06d6db33
PE
6150 * insdel.c (count_size_as_multibyte): Check for string overflow.
6151
2b4560a8
PE
6152 * character.c (lisp_string_width): Check for string overflow.
6153 Use EMACS_INT, not int, for string indexes and lengths; in
6154 particular, 2nd arg is now EMACS_INT, not int. Do not crash if
6155 the resulting string length overflows an EMACS_INT; instead,
6156 report a string overflow if no precision given. When checking for
6157 precision exhaustion, use a check that cannot possibly have
6158 integer overflow. (Bug#8675)
6159 * character.h (lisp_string_width): Adjust to new signature.
6160
cb93f9be
PE
6161 * alloc.c (string_overflow): New function.
6162 (Fmake_string): Use it. This doesn't change behavior, but saves
6163 a few bytes and will simplify future changes.
6164 * character.c (string_escape_byte8): Likewise.
6165 * lisp.h (string_overflow): New decl.
6166
1a1f3366
PE
6167 Fixups, following up to the user-interface timestamp change.
6168 * nsterm.m (last_mouse_movement_time, ns_mouse_position): Use Time
6169 for UI timestamps, instead of unsigned long.
9fbd6841
PE
6170 * msdos.c (mouse_get_pos): Likewise.
6171 * w32inevt.c (movement_time, w32_console_mouse_position): Likewise.
1a1f3366
PE
6172 * w32gui.h (Time): Define by including "systime.h" rather than by
6173 declaring it ourselves. (Bug#8664)
6174
d4e3e4d3
PE
6175 * dispextern.h (struct image): Don't assume time_t <= unsigned long.
6176 * image.c (clear_image_cache): Likewise.
6177
f6a24d19
PE
6178 * term.c (term_mouse_position): Don't assume time_t wraparound.
6179
08dc5ae6
PE
6180 Be more systematic about user-interface timestamps.
6181 Before, the code sometimes used 'Time', sometimes 'unsigned long',
620c53a6
SM
6182 and sometimes 'EMACS_UINT', to represent these timestamps.
6183 This change causes it to use 'Time' uniformly, as that's what X uses.
08dc5ae6
PE
6184 This makes the code easier to follow, and makes it easier to catch
6185 integer overflow bugs such as Bug#8664.
6186 * frame.c (Fmouse_position, Fmouse_pixel_position):
6187 Use Time, not unsigned long, for user-interface timestamps.
6188 * keyboard.c (last_event_timestamp, kbd_buffer_get_event): Likewise.
6189 (button_down_time, make_lispy_position, make_lispy_movement): Likewise.
6190 * keyboard.h (last_event_timestamp): Likewise.
6191 * menu.c (Fx_popup_menu) [!HAVE_X_WINDOWS]: Likewise.
6192 * menu.h (xmenu_show): Likewise.
6193 * term.c (term_mouse_position): Likewise.
6194 * termhooks.h (struct input_event.timestamp): Likewise.
6195 (struct terminal.mouse_position_hook): Likewise.
6196 * xmenu.c (create_and_show_popup_menu, xmenu_show): Likewise.
6197 * xterm.c (XTmouse_position, x_scroll_bar_report_motion): Likewise.
6198 * systime.h (Time): New decl. Pull it in from <X11/X.h> if
6199 HAVE_X_WINDOWS, otherwise define it as unsigned long, which is
6200 what it was before.
6201 * menu.h, termhooks.h: Include "systime.h", for Time.
6202
8e55734a
PE
6203 * keyboard.c (make_lispy_event): Fix problem in integer overflow.
6204 Don't assume that the difference between two unsigned long values
6205 can fit into an integer. At this point, we know button_down_time
6206 <= event->timestamp, so the difference must be nonnegative, so
6207 there's no need to cast the result if double-click-time is
6208 nonnegative, as it should be; check that it's nonnegative, just in
6209 case. This bug is triggered when events are more than 2**31 ms
86db42d2 6210 apart (about 25 days). (Bug#8664)
8e55734a 6211
841f1b75 6212 * xselect.c (last_event_timestamp): Remove duplicate decl.
6434756c 6213 (x_own_selection): Remove needless cast to unsigned long.
841f1b75 6214
3e26f69c
PE
6215 * xmenu.c (set_frame_menubar): Use int, not EMACS_UINT, for indexes
6216 that always fit in int. Use a sentinel instead of a counter, to
6217 avoid a temp and to allay GCC's concerns about possible int overflow.
d230cb74
PE
6218 * frame.h (struct frame): Use int for menu_bar_items_used
6219 instead of EMACS_INT, since it always fits in int.
3e26f69c 6220
5cc152c0
PE
6221 * menu.c (grow_menu_items): Check for int overflow.
6222
d89eb65e
PE
6223 * xmenu.c (set_frame_menubar): Don't mishandle vectors with no nils.
6224
5235bd3e
PE
6225 * xterm.c: Use EMACS_INT for Emacs modifiers, and int for X modifiers.
6226 Before, the code was not consistent. These values cannot exceed
6227 2**31 - 1 so there's no need to make them unsigned.
6228 (x_x_to_emacs_modifiers): Accept int and return EMACS_INT.
6229 (x_emacs_to_x_modifiers): Accept EMACS_INT and return int.
6230 (x_x_to_emacs_modifiers, x_emacs_to_x_modifiers): Reject non-integers
6231 as modifiers.
6232 * xterm.h (x_x_to_emacs_modifiers): Adjust to signature change.
6233
bc827e23
PE
6234 * lisp.h (XINT) [USE_LISP_UNION_TYPE]: Cast to EMACS_INT.
6235 (XUINT) [USE_LISP_UNION_TYPE]: Cast to EMACS_UINT.
6236 Otherwise, GCC 4.6.0 warns about printf (pI, XINT (...)),
6237 presumably because the widths might not match.
6238
78eb494e
PE
6239 * window.c (size_window): Avoid needless test at loop start.
6240
04f2d78b
CB
62412011-05-18 Courtney Bane <emacs-bugs-7626@cbane.org> (tiny change)
6242
6243 * term.c (Fresume_tty): Restore hooks before reinitializing (bug#8687).
6244
d2fc7e3d 62452011-05-12 Drew Adams <drew.adams@oracle.com>
e531bdff
DA
6246
6247 * textprop.c (Fprevious_single_char_property_change): Doc fix (bug#8655).
6248
d2fc7e3d 62492011-05-12 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
7db47798
YM
6250
6251 * w32term.c (w32_draw_fringe_bitmap): Rename local vars `left' and
6252 `width' to `bar_area_x' and `bar_area_width', respectively.
6253 (x_scroll_run): Take account of fringe background extension.
6254
04f2d78b
CB
6255 * xterm.c (x_draw_fringe_bitmap) [USE_TOOLKIT_SCROLL_BARS]:
6256 Rename local vars `left' and `width' to `bar_area_x' and
7db47798
YM
6257 `bar_area_width', respectively.
6258 (x_scroll_run) [USE_TOOLKIT_SCROLL_BARS]: Take account of fringe
6259 background extension.
6260
79b70037
GM
62612011-05-10 Jim Meyering <meyering@redhat.com>
6262
6263 * xdisp.c (x_intersect_rectangles): Fix typo "the the -> the".
6264
2f142cc5
JB
62652011-05-10 Juanma Barranquero <lekktu@gmail.com>
6266
6267 * image.c (Finit_image_library): Return t for built-in image types,
6268 like pbm and xbm. (Bug#8640)
6269
57679c86
AS
62702011-05-09 Andreas Schwab <schwab@linux-m68k.org>
6271
6272 * w32menu.c (set_frame_menubar): Fix submenu allocation.
6273
888c9e86
EZ
62742011-05-07 Eli Zaretskii <eliz@gnu.org>
6275
b0512a1d
EZ
6276 * w32console.c (Fset_screen_color): Doc fix.
6277 (Fget_screen_color): New function.
6278 (syms_of_ntterm): Defsubr it.
6279
7285dc67
EZ
6280 * callproc.c (call_process_cleanup) [MSDOS]: Don't close and
6281 unlink the temporary file if Fcall_process didn't create it in the
6282 first place.
6283 (Fcall_process) [MSDOS]: Don't create tempfile if stdout of the
6284 child process will be redirected to a file specified with `:file'.
888c9e86
EZ
6285 Don't try to re-open tempfile in that case, and set fd[0] to -1 as
6286 cue to call_process_cleanup not to close that handle.
6287
4d3fcc8e
BK
62882011-05-07 Ben Key <bkey76@gmail.com>
6289
6290 * makefile.w32-in: The bootstrap-temacs rule now makes use of
6291 one of two shell specific rules, either bootstrap-temacs-CMD or
6292 bootstrap-temacs-SH. The bootstrap-temacs-SH rule is identical
6293 to the previous implementation of the bootstrap-temacs rule.
6294 The bootstrap-temacs-CMD rule is similar to the previous
6295 implementation of the bootstrap-temacs rule except that it
6296 makes use of the ESC_CFLAGS variable instead of the CFLAGS
6297 variable.
6298
6299 These changes, along with some changes to nt/configure.bat,
6300 nt/gmake.defs, and nt/nmake.defs, are required to extend my
6301 earlier fix to add support for --cflags and --ldflags options
6302 that include quotes so that it works whether make uses cmd or
6303 sh as the shell.
6304
b4289b64
MA
63052011-05-06 Michael Albinus <michael.albinus@gmx.de>
6306
6307 * dbusbind.c (QCdbus_type_unix_fd): Declare static.
6308 (xd_remove_watch): Don't check QCdbus_type_unix_fd for SYMBOLP, it
6309 is a constant.
6310 (Fdbus_init_bus, xd_read_queued_messages): Bus can be a symbol or
6311 a string. Handle both cases.
6312 (Fdbus_call_method_asynchronously, Fdbus_register_signal)
6313 (Fdbus_register_method): Use Qinvalid_function.
6314
af4c0e28
JB
63152011-05-06 Juanma Barranquero <lekktu@gmail.com>
6316
6317 * makefile.w32-in: Update dependencies.
6318 (LISP_H): Add inttypes.h and stdin.h.
6319 (PROCESS_H): Add unistd.h.
6320
c51453d9
EZ
63212011-05-06 Eli Zaretskii <eliz@gnu.org>
6322
6323 * lread.c: Include limits.h (fixes the MS-Windows build broken by
6324 2011-05-06T07:13:19Z!eggert@cs.ucla.edu).
6325
8ff0ac3c 63262011-05-06 Paul Eggert <eggert@cs.ucla.edu>
c032b5f8 6327
4c4b566b
PE
6328 * image.c (Finit_image_library) [!HAVE_NTGUI]: Omit unused local.
6329
aab2b9b5
PE
6330 * term.c (vfatal): Remove stray call to va_end.
6331 It's not needed and the C Standard doesn't allow it here anyway.
6332
c378da0b
PE
6333 Use C99's va_copy to avoid undefined behavior on x86-64 GNU/Linux.
6334 * eval.c (verror): doprnt a copy of ap, not the original. (Bug#8545)
6335
288b08c7
PE
6336 * eval.c (verror): OK to create a string of up to MOST_POSITIVE_FIXNUM
6337 bytes.
6338
e3601888
PE
6339 * term.c: Don't include <stdarg.h>, as <lisp.h> does that.
6340
db6c0e74
PE
6341 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork clobbering.
6342
dd5963ea
PE
6343 * process.c (Fformat_network_address): Fix typo: args2 -> *args2.
6344
88c9450f
PE
6345 * xmenu.c (set_frame_menubar): Fix typo: int * -> int (3 times).
6346
2f9442b8
PE
6347 * coding.c (detect_coding_charset): Fix typo: * 2 -> *4 (Bug#8601).
6348
c032b5f8
PE
6349 * charset.h (struct charset.code_space): Now has 15 elements, not 16.
6350 * charset.c (Fdefine_charset_internal): Don't initialize
6351 charset.code_space[15]. The value was garbage, on hosts with
2d38271b 6352 32-bit int (Bug#8600).
a108c10b
PE
6353
6354 * lread.c (read_integer): Be more consistent with string-to-number.
6355 Use string_to_number to do the actual conversion; this avoids
6356 rounding errors and fixes some other screwups. Without this fix,
6357 for example, #x1fffffffffffffff was misread as -2305843009213693952.
6358 (digit_to_number): Move earlier, for benefit of read_integer.
6359 Return -1 if the digit is out of range for the base, -2 if it is
48e400f0 6360 not a digit in any supported base. (Bug#8602)
a108c10b 6361
ad5f9eea
PE
6362 * doprnt.c (doprnt): Support arbitrary pI values, such as "I64".
6363
aec1708a
PE
6364 * dispnew.c (scrolling_window): Return 1 if we scrolled,
6365 to match comment at start of function. This also removes a
6366 GCC warning about overflow in a 32+64-bit port.
6367
47be4ab5
PE
6368 * lisp.h (EMACS_INT, EMACS_UINT, BITS_PER_EMACS_INT, pI): Simplify.
6369
371cac43
PE
6370 * dbusbind.c: Do not use XPNTR on a value that may be an integer.
6371 Reported by Stefan Monnier in
6372 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00919.html>.
04f2d78b
CB
6373 (xd_remove_watch, Fdbus_init_bus, xd_read_queued_messages):
6374 Use SYMBOLP-guarded XSYMBOL, not XPNTR.
371cac43 6375
d01a7826
PE
6376 * lisp.h (EMACS_INTPTR): Remove. All uses changed to intptr_t.
6377 (EMACS_UINTPTR): Likewise, with uintptr_t.
6378
7fd47d5c
PE
6379 * lisp.h: Prefer 64-bit EMACS_INT if available.
6380 (EMACS_INT, EMACS_UINT, BITS_PER_EMACS_INT, pI): Define to 64-bit
6381 on 32-bit hosts that have 64-bit int, so that they can access
6382 large files.
122b0c86
PE
6383 However, temporarily disable this change unless the temporary
6384 symbol WIDE_EMACS_INT is defined.
7fd47d5c 6385
8727937b
PE
6386 * lread.c, process.c: Do not include <inttypes.h>; lisp.h does it now.
6387
8ac068ac
PE
6388 Prefer intptr_t/uintptr_t for integers the same widths as pointers.
6389 This removes an assumption that EMACS_INT and long are the same
6390 width as pointers. The assumption is true for Emacs porting targets
6391 now, but we want to make other targets possible.
6392 * lisp.h: Include <inttypes.h>, for INTPTR_MAX, UINTPTR_MAX.
6393 (EMACS_INTPTR, EMACS_UINTPTR): New macros.
6394 In the rest of the code, change types of integers that hold casted
6395 pointers to EMACS_INTPTR and EMACS_UINTPTR, systematically
6396 replacing EMACS_INT, long, EMACS_UINT, and unsigned long.
6397 (XTYPE): Don't cast arg to EMACS_UINT; normally is not needed.
6398 (XSET): Cast type of XTYPE arg to EMACS_INTPTR; it is needed here.
6399 No need to cast type when ORing.
6400 (XPNTR): Return a value of type EMACS_INTPTR or EMACS_UINTPTR.
6401 * alloc.c (lisp_align_malloc): Remove a no-longer-needed cast.
6402 * doc.c (store_function_docstring): Use EMACS_INTPTR, so as not to
6403 assume EMACS_INT is the same width as char *.
6404 * gtkutil.c (xg_gtk_scroll_destroy, xg_tool_bar_button_cb):
6405 (xg_tool_bar_callback, xg_tool_bar_help_callback, xg_make_tool_item):
6406 Remove no-longer-needed casts.
6407 (xg_create_scroll_bar, xg_tool_bar_button_cb, xg_tool_bar_callback):
6408 (xg_tool_bar_help_callback, xg_make_tool_item):
6409 Use EMACS_INTPTR to hold an integer
6410 that will be cast to void *; this can avoid a GCC warning
6411 if EMACS_INT is not the same width as void *.
6412 * menu.c (find_and_call_menu_selection): Remove no-longer-needed cast.
6413 * xdisp.c (display_echo_area_1, resize_mini_window_1):
6414 (current_message_1, set_message_1):
6415 Use a local to convert to proper width without a cast.
6416 * xmenu.c (dialog_selection_callback): Likewise.
6417
ede49d71
PE
6418 * sysdep.c (get_random): Don't assume EMACS_INT is no wider than long.
6419 Also, don't assume VALBITS / RAND_BITS is less than 5,
6420 and don't rely on undefined behavior when shifting a 1 left into
6421 the sign bit.
6422 * lisp.h (get_random): Change signature to match.
6423
2f30ecd0
PE
6424 * lread.c (hash_string): Use size_t, not int, for hash computation.
6425 Normally we prefer signed values; but hashing is special, because
6426 it's better to use unsigned division on hash table sizes so that
6427 the remainder is nonnegative. Also, size_t is the natural width
6428 for hashing into memory. The previous code used 'int', which doesn't
6429 retain enough info to hash well into very large tables.
6430 (oblookup, oblookup_last_bucket_number, Funintern): Likewise.
6431
2a866e7b
PE
6432 * dbusbind.c: Don't possibly lose pointer info when converting.
6433 (xd_remove_watch, Fdbus_init_bus, xd_read_queued_messages):
6434 Use XPNTR rather than XHASH, so that the high-order bits of
6435 the pointer aren't lost when converting through void *.
6436
51639eac
PE
6437 * eval.c (Fautoload): Don't double-shift a pointer.
6438
92394119
PE
6439 * fns.c (Frandom): Let EMACS_UINT be wider than unsigned long.
6440
dbdb9a7c
JB
64412011-05-06 Juanma Barranquero <lekktu@gmail.com>
6442
6443 * gnutls.c (DEF_GNUTLS_FN):
6444 * image.c (DEF_IMGLIB_FN): Make function pointers static.
6445
db7a0b4f
AS
64462011-05-05 Andreas Schwab <schwab@linux-m68k.org>
6447
6448 * lread.c (lisp_file_lexically_bound_p): Stop scanning at end
6449 marker. (Bug#8610)
6450
cd394be1 64512011-05-05 Eli Zaretskii <eliz@gnu.org>
fab624aa
EZ
6452
6453 * w32heap.c (allocate_heap) [USE_LISP_UNION_TYPE || USE_LSB_TAG]:
6454 New version that can reserve upto 2GB of heap space.
6455
f7ff1b0f 64562011-05-05 Chong Yidong <cyd@stupidchicken.com>
45cb8994
CY
6457
6458 * nsfns.m (Fns_read_file_name): Doc fix (Bug#8534).
6459
639c109b
TZ
64602011-05-05 Teodor Zlatanov <tzz@lifelogs.com>
6461
6462 * gnutls.c (fn_gnutls_certificate_set_x509_key_file): Add alias to
6463 `gnutls_certificate_set_x509_key_file'.
6464
d2127135
JB
64652011-05-05 Juanma Barranquero <lekktu@gmail.com>
6466
6467 * makefile.w32-in ($(BLD)/image.$(O), $(BLD)/process.$(O)):
6468 Update dependencies.
6469
e968f4f3
JB
64702011-05-04 Juanma Barranquero <lekktu@gmail.com>
6471
6472 * gnutls.h (emacs_gnutls_write, emacs_gnutls_read):
6473 * gnutls.c (emacs_gnutls_write, emacs_gnutls_read):
6474 Remove unused parameter `fildes'.
6475 * process.c (read_process_output, send_process): Don't pass it.
6476
84d358f0
JB
64772011-05-04 Juanma Barranquero <lekktu@gmail.com>
6478
6479 Fix previous change: the library cache is defined in w32.c.
6480 * image.c (CACHE_IMAGE_TYPE) [!HAVE_NTGUI]: Define to noop.
6481 (Finit_image_library): Wrap Vlibrary_cache on "#ifdef HAVE_NTGUI".
6482
0898ca10
JB
64832011-05-04 Juanma Barranquero <lekktu@gmail.com>
6484
6485 Implement dynamic loading of GnuTLS on Windows.
6486
6487 * gnutls.h (GNUTLS_EMACS_ERROR_NOT_LOADED): New macro.
6488 (emacs_gnutls_write, emacs_gnutls_read): Mark as extern.
6489 (emacs_gnutls_record_check_pending, emacs_gnutls_transport_set_errno):
6490 Declare.
6491
6492 * gnutls.c (Qgnutls_dll): Define.
6493 (DEF_GNUTLS_FN, LOAD_GNUTLS_FN): New macros.
6494 (gnutls_*): Declare function pointers.
6495 (init_gnutls_functions): New function to initialize function pointers.
6496 (emacs_gnutls_handshake, Fgnutls_error_string, Fgnutls_deinit)
6497 (emacs_gnutls_global_init, Fgnutls_bye): Use function pointers.
6498 (emacs_gnutls_record_check_pending, emacs_gnutls_transport_set_errno):
6499 Wrappers for gnutls_record_check_pending and gnutls_transport_set_errno.
6500 (emacs_gnutls_write, emacs_gnutls_read)
6501 (emacs_gnutls_handle_error, Fgnutls_error_fatalp)
6502 (Fgnutls_available_p): New function.
6503 (Fgnutls_boot): Call Fgnutls_available_p. Use function pointers.
6504 (syms_of_gnutls) <Qgnutls_dll>: Initialize and staticpro it.
6505 (syms_of_gnutls) <Sgnutls_available_p>: defsubr it.
6506
6507 * image.c: Include w32.h.
6508 (Vimage_type_cache): Delete.
6509 (syms_of_image) <Vimage_type_cache>: Don't initialize and staticpro it.
6510 (CACHE_IMAGE_TYPE, Finit_image_library): Use Vlibrary_cache instead.
6511 (w32_delayed_load): Move to w32.c.
6512
6513 * w32.h (VlibraryCache, QCloaded_from, w32_delayed_load): Declare.
6514
6515 * w32.c (QCloaded_from, Vlibrary_cache): Define.
6516 (w32_delayed_load): Move from image.c. When loading a library, record
6517 its filename in the :loaded-from property of the library id.
6518 (globals_of_w32) <QCloaded_from, Vlibrary_cache>:
6519 Initialize and staticpro them.
6520 (emacs_gnutls_pull, emacs_gnutls_push): Call emacs_gnutls_* functions.
6521
6522 * process.c: Include lisp.h before w32.h, not after.
6523 (wait_reading_process_output): Call emacs_gnutls_record_check_pending
6524 instead of gnutls_record_check_pending.
6525
6526 * callproc.c, emacs.c: Include lisp.h before w32.h, not after.
6527
ff4de4aa
TZ
65282011-05-04 Teodor Zlatanov <tzz@lifelogs.com>
6529
6530 * gnutls.c (Fgnutls_boot): Support :keylist and :crlfiles options
6531 instead of :keyfiles. Give GnuTLS the keylist and the CRL lists
6532 as passed in.
6533
abe95abb
JD
65342011-05-03 Jan Djärv <jan.h.d@swipnet.se>
6535
6536 * xterm.c (x_set_frame_alpha): Do not set property on anything
6537 else than FRAME_X_OUTER_WINDOW (Bug#8608).
6538
e16e55d4
JB
65392011-05-02 Juanma Barranquero <lekktu@gmail.com>
6540
6541 * sysdep.c (get_tty_size) [WINDOWSNT]: Implement. (Bug#8596)
6542
bafcf6a5
JB
65432011-05-02 Juanma Barranquero <lekktu@gmail.com>
6544
6545 * gnutls.c (Qgnutls_log_level, Qgnutls_code, Qgnutls_anon)
6546 (Qgnutls_x509pki, Qgnutls_e_interrupted, Qgnutls_e_again)
6547 (Qgnutls_e_invalid_session, Qgnutls_e_not_ready_for_handshake)
6548 (gnutls_global_initialized, Qgnutls_bootprop_priority)
6549 (Qgnutls_bootprop_trustfiles, Qgnutls_bootprop_keyfiles)
6550 (Qgnutls_bootprop_callbacks, Qgnutls_bootprop_loglevel)
6551 (Qgnutls_bootprop_hostname, Qgnutls_bootprop_verify_flags)
6552 (Qgnutls_bootprop_verify_error, Qgnutls_bootprop_verify_hostname_error)
6553 (Qgnutls_bootprop_callbacks_verify): Make static.
6554
e7a6747f
AS
65552011-05-01 Andreas Schwab <schwab@linux-m68k.org>
6556
19ed11ba
AS
6557 * callproc.c: Indentation fixup.
6558
e7a6747f 6559 * sysdep.c (wait_for_termination_1): Make static.
04f2d78b
CB
6560 (wait_for_termination, interruptible_wait_for_termination):
6561 Move after wait_for_termination_1.
e7a6747f 6562
1ef14cb4
LMI
65632011-05-01 Lars Magne Ingebrigtsen <larsi@gnus.org>
6564
6565 * sysdep.c (interruptible_wait_for_termination): New function
6566 which is like wait_for_termination, but allows keyboard
6567 interruptions.
6568
6569 * callproc.c (Fcall_process): Add (:file "file") as an option for
6570 the STDOUT buffer.
6571 (Fcall_process_region): Ditto.
6572
330d880c
EZ
65732011-04-30 Eli Zaretskii <eliz@gnu.org>
6574
8db90b73
EZ
6575 * dosfns.c (Fint86, Fdos_memget, Fdos_memput): Use `ASIZE (FOO)'
6576 rather than `XVECTOR (FOO)->size'.
6577
330d880c
EZ
6578 * process.c: Remove HAVE_INTTYPES_H condition from inclusion of
6579 inttypes.h, as a gnulib replacement is used if it not available in
6580 system headers.
6581
15cbd324
EZ
65822011-04-21 Eli Zaretskii <eliz@gnu.org>
6583
6584 Lift the MOST_POSITIVE_FIXNUM/4 limitation on visited files.
6585 * fileio.c (Finsert_file_contents): Don't limit file size to 1/4
6586 of MOST_POSITIVE_FIXNUM. (Bug#8528)
6587
6588 * coding.c (coding_alloc_by_realloc): Error out if destination
6589 will grow beyond MOST_POSITIVE_FIXNUM.
6590 (decode_coding_emacs_mule): Abort if there isn't enough place in
6591 charbuf for the composition carryover bytes. Reserve an extra
6592 space for up to 2 characters produced in a loop.
6593 (decode_coding_iso_2022): Abort if there isn't enough place in
6594 charbuf for the composition carryover bytes.
6595
65962011-04-21 Eli Zaretskii <eliz@gnu.org>
afda1437 6597
ae940cca
EZ
6598 * doprnt.c (doprnt) [!HAVE_LONG_LONG_INT]: Error out instead of
6599 aborting when %lld or %lll format is passed.
6600 [!HAVE_UNSIGNED_LONG_LONG_INT]: Error out instead of aborting when
6601 %llo or %llx format is passed. (Bug#8545)
6602
03ab8921
EZ
6603 * window.c (window_scroll_line_based): Use a marker instead of
6604 simple variables to record original value of point. (Bug#7952)
6605
afda1437
EZ
6606 * doprnt.c (doprnt): Fix the case where a multibyte sequence
6607 produced by %s or %c overflows available buffer space. (Bug#8545)
6608
f76dee0c
PE
66092011-04-28 Paul Eggert <eggert@cs.ucla.edu>
6610
6611 * doprnt.c (doprnt): Omit useless test; int overflow check (Bug#8545).
283cdbef 6612 (SIZE_MAX): Move defn after all includes, as they might #define it.
f76dee0c 6613
fdc5744d
JB
66142011-04-28 Juanma Barranquero <lekktu@gmail.com>
6615
6616 * w32.c (init_environment): Warn about defaulting HOME to C:\.
6617
638f053a
JB
66182011-04-28 Juanma Barranquero <lekktu@gmail.com>
6619
6620 * keyboard.c (Qdelayed_warnings_hook): Define.
6621 (command_loop_1): Run `delayed-warnings-hook'
6622 if Vdelayed_warnings_list is non-nil.
6623 (syms_of_keyboard) <delayed-warnings-hook>: DEFSYM it.
6624 (syms_of_keyboard) <delayed-warnings-list>: DEFVAR_LISP it.
6625
d178f871
EZ
66262011-04-28 Eli Zaretskii <eliz@gnu.org>
6627
6628 * doprnt.c (doprnt): Don't return value smaller than the buffer
6629 size if the message was truncated. (Bug#8545).
6630
b124fd93
JB
66312011-04-28 Juanma Barranquero <lekktu@gmail.com>
6632
6633 * w32fns.c (Fx_change_window_property, Fx_delete_window_property)
6634 (Fx_window_property): #if-0 the whole functions, not just the bodies.
6635
e810457d
PE
66362011-04-27 Paul Eggert <eggert@cs.ucla.edu>
6637
6638 * doprnt.c (doprnt): Support "ll" length modifier, for long long.
6639
ea51cceb
JB
66402011-04-27 Juanma Barranquero <lekktu@gmail.com>
6641
6642 * makefile.w32-in: Update dependencies.
6643
94dcfacf
EZ
66442011-04-27 Eli Zaretskii <eliz@gnu.org>
6645
6646 Improve `doprnt' and its usage. (Bug#8545)
6647 * doprnt.c (doprnt): Make sure `format' is never accessed beyond
6648 `format_end'. Remove support for %l as a conversion specifier.
6649 Don't use xrealloc. Improve diagnostics when the %l size modifier
6650 is used. Update the commentary.
6651
6652 * eval.c (verror): Simplify calculation of size_t.
6653
6654 * coding.c (Ffind_operation_coding_system): Fix diagnostic error
6655 messages.
6656
f61f41d7
PE
66572011-04-27 Yoshiaki Kasahara <kasahara@nc.kyushu-u.ac.jp> (tiny change)
6658
6659 * buffer.c (init_buffer) [USE_MMAP_FOR_BUFFERS]: Adjust to aliasing
6660 change.
6661
96fb4434
PE
66622011-04-27 Paul Eggert <eggert@cs.ucla.edu>
6663
6664 * nsmenu.m: Replace all uses of XVECTOR with ASIZE and AREF.
6665 This makes this file independent of the recent pseudovector change.
6666
671875da 66672011-04-26 Paul Eggert <eggert@cs.ucla.edu>
eab3844f 6668
69e9b5a3
PE
6669 * keyboard.c (handle_user_signal): Fix pointer signedness problem.
6670
b5f869a7 6671 * gnutls.c (emacs_gnutls_handle_error): Remove unused local.
7754e151 6672 (Fgnutls_boot): gnutls_certificate_verify_peers2 wants unsigned *.
8d4c3955 6673 Remove unused local.
c8926152 6674 (emacs_gnutls_write): Don't use uninitialized rtnval if nbyte <= 0.
080e5a8d 6675
841a1577 6676 * lisp.h: Fix a problem with aliasing and vector headers. (Bug#8546)
04f2d78b
CB
6677 GCC 4.6.0 optimizes based on type-based alias analysis.
6678 For example, if b is of type struct buffer * and v of type struct
eab3844f
PE
6679 Lisp_Vector *, then gcc -O2 was incorrectly assuming that &b->size
6680 != &v->size, and therefore "v->size = 1; b->size = 2; return
6681 v->size;" must therefore return 1. This assumption is incorrect
6682 for Emacs, since it type-puns struct Lisp_Vector * with many other
6683 types. To fix this problem, this patch adds a new type struct
f904488f 6684 vectorlike_header that documents the constraints on layout of vectors
eab3844f
PE
6685 and pseudovectors, and helps optimizing compilers not get fooled
6686 by Emacs's type punning. It also adds the macros XSETTYPED_PVECTYPE
6687 XSETTYPED_PSEUDOVECTOR, TYPED_PSEUDOVECTORP, for similar reasons.
f904488f
PE
6688 * lisp.h (XSETTYPED_PVECTYPE): New macro, specifying the name of
6689 the size member.
eab3844f
PE
6690 (XSETPVECTYPE): Rewrite in terms of new macro.
6691 (XSETPVECTYPESIZE): New macro, specifying both type and size.
6692 This is a bit clearer, and further avoids the possibility of
6693 undesirable aliasing.
6694 (XSETTYPED_PSEUDOVECTOR): New macro, specifying the size.
f904488f 6695 (XSETPSEUDOVECTOR): Rewrite in terms of XSETTYPED_PSEUDOVECTOR.
eab3844f
PE
6696 (XSETSUBR): Rewrite in terms of XSETTYPED_PSEUDOVECTOR and XSIZE,
6697 since Lisp_Subr is a special case (no "next" field).
04f2d78b
CB
6698 (ASIZE): Now uses header.size rather than size.
6699 All previous uses of XVECTOR (foo)->size replaced to use this macro,
f904488f
PE
6700 to avoid the hassle of writing XVECTOR (foo)->header.size.
6701 (struct vectorlike_header): New type.
eab3844f
PE
6702 (TYPED_PSEUDOVECTORP): New macro, also specifying the C type of the
6703 object, to help avoid aliasing.
6704 (PSEUDOVECTORP): Rewrite in terms of TYPED_PSEUDOVECTORP.
6705 (SUBRP): Likewise, since Lisp_Subr is a special case.
6706 * lisp.h (struct Lisp_Vector, struct Lisp_Char_Table):
6707 (struct Lisp_Sub_Char_Table, struct Lisp_Bool_Vector):
6708 (struct Lisp_Hash_Table): Combine first two members into a single
f904488f 6709 struct vectorlike_header member. All uses of "size" and "next" members
eab3844f
PE
6710 changed to be "header.size" and "header.next".
6711 * buffer.h (struct buffer): Likewise.
6712 * font.h (struct font_spec, struct font_entity, struct font): Likewise.
6713 * frame.h (struct frame): Likewise.
6714 * process.h (struct Lisp_Process): Likewise.
6715 * termhooks.h (struct terminal): Likewise.
6716 * window.c (struct save_window_data, struct saved_window): Likewise.
6717 * window.h (struct window): Likewise.
6718 * alloc.c (allocate_buffer, Fmake_bool_vector, allocate_pseudovector):
6719 Use XSETPVECTYPESIZE, not XSETPVECTYPE, to avoid aliasing problems.
6720 * buffer.c (init_buffer_once): Likewise.
6721 * lread.c (defsubr): Use XSETTYPED_PVECTYPE, since Lisp_Subr is a
6722 special case.
6723 * process.c (Fformat_network_address): Use local var for size,
6724 for brevity.
6725
0df1eac5
PE
6726 * bytecode.c (exec_byte_code): Don't use XVECTOR before CHECK_VECTOR.
6727
847ab9d1 6728 Make the Lisp reader and string-to-float more consistent (Bug#8525)
452f4150
PE
6729 * data.c (atof): Remove decl; no longer used or needed.
6730 (digit_to_number): Move to lread.c.
6731 (Fstring_to_number): Use new string_to_number function, to be
6732 consistent with how the Lisp reader treats infinities and NaNs.
6733 Do not assume that floating-point numbers represent EMACS_INT
6734 without losing information; this is not true on most 64-bit hosts.
6735 Avoid double-rounding errors, by insisting on integers when
6736 parsing non-base-10 numbers, as the documentation specifies.
6737 * lisp.h (string_to_number): New decl, replacing ...
6738 (isfloat_string): Remove.
bc0a5c13 6739 * lread.c: Include <inttypes.h>, for uintmax_t and strtoumax.
d78050d6 6740 (read1): Do not accept +. and -. as integers; this
452f4150
PE
6741 appears to have been a coding error. Similarly, do not accept
6742 strings like +-1e0 as floating point numbers. Do not report
6743 overflow for integer overflows unless the base is not 10 which
6744 means we have no simple and reliable way to continue.
6745 Break out the floating-point parsing into a new
6746 function string_to_number, so that Fstring_to_number parses
6747 floating point numbers consistently with the Lisp reader.
04f2d78b 6748 (digit_to_number): Move here from data.c. Make it static inline.
452f4150
PE
6749 (E_CHAR, EXP_INT): Remove, replacing with ...
6750 (E_EXP): New macro, to solve the "1.0e+" problem mentioned below.
6751 (string_to_number): New function, replacing isfloat_string.
6752 This function checks for valid syntax and produces the resulting
6753 Lisp float number too. Rework it so that string-to-number
bc0a5c13 6754 no longer mishandles examples like "1.0e+". Use strtoumax,
d78050d6
PE
6755 so that overflow for non-base-10 numbers is reported only when
6756 there's no portable and simple way to convert to floating point.
452f4150 6757
67769ffc
PE
6758 * textprop.c (set_text_properties_1): Rewrite for clarity,
6759 and to avoid GCC warning about integer overflow.
6760
c20db43f
PE
6761 * intervals.h (struct interval): Use EMACS_INT for members
6762 where EMACS_UINT might cause problems. See
6763 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00514.html>.
6764 (CHECK_TOTAL_LENGTH): Remove cast to EMACS_INT; no longer needed.
6765 * intervals.c (interval_deletion_adjustment): Now returns EMACS_INT.
6766 All uses changed.
37aa2f85
PE
6767 (offset_intervals): Tell GCC not to worry about length overflow
6768 when negating a negative length.
c20db43f 6769
2538aa2f
PE
6770 * alloc.c (overrun_check_malloc, overrun_check_realloc): Now static.
6771 (overrun_check_free): Likewise.
6772
f2d3008d
PE
6773 * alloc.c (SDATA_SIZE) [!GC_CHECK_STRING_BYTES]: Avoid runtime check
6774 in the common case where SDATA_DATA_OFFSET is a multiple of Emacs
6775 word size.
6776
ec8df744
PE
6777 * gnutls.c: Fix problems found by GCC 4.6.0 on Ubuntu 10.10.
6778 (gnutls_make_error): Rename local to avoid shadowing.
6779 (gnutls_emacs_global_deinit): ifdef out; not used.
6780 (Fgnutls_boot): Use const for pointer to readonly storage.
6781 Comment out unused local. Fix pointer signedness problems.
6782
640ee02d
PE
6783 * lread.c (openp): Don't stuff size_t into an 'int'.
6784 Use <= on length, not < on length + 1, to avoid GCC 4.6.0 warning
6785 about possible signed overflow.
6786
6048fb2a
PE
6787 * gtkutil.c: Fix problems found by GCC 4.6.0 on Ubuntu 10.10.
6788 (GDK_KEY_g): Don't define if already defined.
6789 (xg_prepare_tooltip): Avoid pointer signedness problem.
6790 (xg_set_toolkit_scroll_bar_thumb): Redo to avoid two casts.
6791
fa3c87e1
PE
6792 * process.c (Fnetwork_interface_info): Avoid left-shift undefined
6793 behavior with 1 << 31. GCC 4.6.0 warns about this on 32-bit hosts.
6794
2172544b
PE
6795 * xfns.c (Fx_window_property): Simplify a bit,
6796 to make a bit faster and to avoid GCC 4.6.0 warning.
6797 * xselect.c (x_get_window_property, x_handle_dnd_message): Likewise.
6798
9b821a21
PE
6799 * fns.c (internal_equal): Don't assume size_t fits in int.
6800
3c616cfa
PE
6801 * alloc.c (compact_small_strings): Tighten assertion a little.
6802
c2982e87
PE
6803 Replace pEd with more-general pI, and fix some printf arg casts.
6804 * lisp.h (pI): New macro, generalizing old pEd macro to other
6805 conversion specifiers. For example, use "...%"pI"d..." rather
6806 than "...%"pEd"...".
6807 (pEd): Remove. All uses replaced with similar uses of pI.
61bdb816 6808 * m/amdx86-64.h, m/ia64.h, m/ibms390x.h: Likewise.
c2982e87
PE
6809 * alloc.c (check_pure_size): Don't overflow by converting size to int.
6810 * bidi.c (bidi_dump_cached_states): Use pI to avoid cast.
6811 * data.c (Fnumber_to_string): Use pI instead of if-then-else-abort.
6812 * dbusbind.c (xd_append_arg): Use pI to avoid cast.
6813 (Fdbus_method_return_internal, Fdbus_method_error_internal): Likewise.
6814 * font.c (font_unparse_xlfd): Avoid potential buffer overrun on
6815 64-bit hosts.
6816 (font_unparse_xlfd, font_unparse_fcname): Use pI to avoid casts.
6817 * keyboard.c (record_char, modify_event_symbol): Use pI to avoid casts.
6818 * print.c (safe_debug_print, print_object): Likewise.
6819 (print_object): Don't overflow by converting EMACS_INT or EMACS_UINT
6820 to int.
6f04d126
PE
6821 Use pI instead of if-then-else-abort. Use %p to avoid casts,
6822 avoiding the 0 flag, which is not portable.
c2982e87
PE
6823 * process.c (Fmake_network_process): Use pI to avoid cast.
6824 * region-cache.c (pp_cache): Likewise.
6825 * xdisp.c (decode_mode_spec): Likewise.
6826 * xrdb.c (x_load_resources) [USE_MOTIF]: Use pI to avoid undefined
6827 behavior on 64-bit hosts with printf arg.
6f04d126 6828 * xselect.c (x_queue_event): Use %p to avoid casts, avoiding 0 flag.
c2982e87
PE
6829 (x_stop_queuing_selection_requests): Likewise.
6830 (x_get_window_property): Don't truncate byte count to an 'int'
6831 when tracing.
0b432f21 6832
5e073ec7
PE
6833 * frame.c (frame_name_fnn_p): Get rid of strtol, which isn't right
6834 here, since it parses constructs like leading '-' and spaces,
6835 which are not wanted; and it overflows with large numbers.
6836 Instead, simply match F[0-9]+, which is what is wanted anyway.
6837
36372bf9
PE
6838 * alloc.c: Remove unportable assumptions about struct layout.
6839 (SDATA_SELECTOR, SDATA_DATA_OFFSET): New macros.
6840 (SDATA_OF_STRING, SDATA_SIZE, allocate_string_data):
6841 (allocate_vectorlike, make_pure_vector): Use the new macros,
6842 plus offsetof, to remove unportable assumptions about struct layout.
6843 These assumptions hold on all porting targets that I know of, but
6844 they are not guaranteed, they're easy to remove, and removing them
6845 makes further changes easier.
6846
0b432f21
PE
6847 * alloc.c (BLOCK BYTES): Fix typo by changing "ablock" to "ablocks".
6848 This doesn't fix a bug but makes the code clearer.
bfd1c781
PE
6849 (string_overrun_cookie): Now const. Use initializers that
6850 don't formally overflow signed char, to avoid warnings.
000098c1
PE
6851 (allocate_string_data) [GC_CHECK_STRING_OVERRUN]: Fix typo that
6852 can cause Emacs to crash when string overrun checking is enabled.
c7bda33c
PE
6853 (allocate_buffer): Don't assume sizeof (struct buffer) is a
6854 multiple of sizeof (EMACS_INT); it need not be, if
6855 alignof(EMACS_INT) < sizeof (EMACS_INT).
d0f4e1f5 6856 (check_sblock, check_string_bytes, check_string_free_list): Protoize.
0b432f21 6857
895009e1
JB
68582011-04-26 Juanma Barranquero <lekktu@gmail.com>
6859
6860 * keyboard.c (QCrtl): Rename from Qrtl. All uses changed.
6861
6a7a1b0b
TZ
68622011-04-26 Teodor Zlatanov <tzz@lifelogs.com>
6863
6864 * gnutls.c (emacs_gnutls_handshake): Return an error if we're not
b5f869a7 6865 supposed to be handshaking. (Bug#8556)
6a7a1b0b
TZ
6866 Reported by Paul Eggert <eggert@cs.ucla.edu>.
6867
841a1577 68682011-04-26 Daniel Colascione <dan.colascione@gmail.com>
0438ce91
DC
6869
6870 * lisp.h (Qdebug): List symbol.
895009e1 6871 * eval.c (Qdebug): Restore global linkage.
0438ce91
DC
6872 * keyboard.c (debug-on-event): New variable.
6873 (handle_user_signal): Break into debugger when debug-on-event
6874 matches the current signal symbol.
6875
f2d3ba6f
DN
68762011-04-25 Dan Nicolaescu <dann@ics.uci.edu>
6877
6878 * alloc.c (check_sblock, check_string_bytes)
6879 (check_string_free_list): Convert to standard C.
6880
42ce4c63
TZ
68812011-04-25 Teodor Zlatanov <tzz@lifelogs.com>
6882
6883 * w32.c (emacs_gnutls_push): Fix typo.
6884
825cd63c
EZ
68852011-04-25 Eli Zaretskii <eliz@gnu.org>
6886
fb11d64d
EZ
6887 * gnutls.c (emacs_gnutls_handshake): Avoid compiler warnings about
6888 "cast to pointer from integer of different size".
6889
825cd63c
EZ
6890 Improve doprnt and its use in verror. (Bug#8545)
6891 * doprnt.c (doprnt): Document the set of format control sequences
6892 supported by the function. Use SAFE_ALLOCA instead of always
6893 using `alloca'.
6894
6895 * eval.c (verror): Don't limit the buffer size at size_max-1, that
6896 is one byte too soon. Don't use xrealloc; instead xfree and
6897 xmalloc anew.
6898
e061a11b
TZ
68992011-04-24 Teodor Zlatanov <tzz@lifelogs.com>
6900
6901 * gnutls.h: Add GNUTLS_STAGE_CALLBACKS enum to denote we're in the
6902 callbacks stage.
6903
6904 * gnutls.c: Renamed global_initialized to
6905 gnutls_global_initialized. Added internals for the
6906 :verify-hostname-error, :verify-error, and :verify-flags
6907 parameters of `gnutls-boot' and documented those parameters in the
6908 docstring. Start callback support.
9173deec
JB
6909 (emacs_gnutls_handshake): Add Woe32 support. Retry handshake
6910 unless a fatal error occurred. Call gnutls_alert_send_appropriate
6911 on error. Return error code.
e061a11b
TZ
6912 (emacs_gnutls_write): Call emacs_gnutls_handle_error.
6913 (emacs_gnutls_read): Likewise.
6914 (Fgnutls_boot): Return handshake error code.
6915 (emacs_gnutls_handle_error): New function.
6916 (wsaerror_to_errno): Likewise.
6917
6918 * w32.h (emacs_gnutls_pull): Add prototype.
6919 (emacs_gnutls_push): Likewise.
6920
6921 * w32.c (emacs_gnutls_pull): New function for GnuTLS on Woe32.
6922 (emacs_gnutls_push): Likewise.
6923
69242011-04-24 Claudio Bley <claudio.bley@gmail.com> (tiny change)
6925
6926 * process.c (wait_reading_process_output): Check if GnuTLS
6927 buffered some data internally if no FDs are set for TLS
6928 connections.
6929
6930 * makefile.w32-in (OBJ2): Add gnutls.$(O).
6931 (LIBS): Link to USER_LIBS.
6932 ($(BLD)/gnutls.$(0)): New target.
6933
fa6996bc
EZ
69342011-04-24 Eli Zaretskii <eliz@gnu.org>
6935
eb35682e
EZ
6936 * xdisp.c (handle_single_display_spec): Rename the
6937 display_replaced_before_p argument into display_replaced_p, to
6938 make it consistent with the commentary. Fix typos in the
6939 commentary.
6940
e2ad650c
EZ
6941 * textprop.c (syms_of_textprop): Remove dead code.
6942 (copy_text_properties): Delete obsolete commentary about an
6943 interface that was deleted long ago. Fix typos in the description
6944 of arguments.
6945
1b2de274
EZ
6946 * msdos.c (XMenuActivate, XMenuAddSelection): Adjust argument list
6947 to changes in oldXMenu/XMenu.h from 2011-04-16.
6948 <menu_help_message, prev_menu_help_message>: Constify.
6949 (IT_menu_make_room): menu->help_text is now `const char **';
6950 adjust.
6951
6952 * msdos.h (XMenuActivate, XMenuAddSelection): Adjust prototypes
6953 to changes in oldXMenu/XMenu.h from 2011-04-16.
6954 (struct XMenu): Declare `help_text' `const char **'.
6955
6956 * xfaces.c <Qunspecified>: Make extern again.
6957
6958 * syntax.c: Include sys/types.h before including regex.h, as
6959 required by Posix.
6960
762b15be
EZ
6961 * doc.c (get_doc_string): Improve the format passed to `error'.
6962
6963 * doprnt.c (doprnt): Improve commentary.
6964
6965 * term.c (init_tty) [MSDOS]: Fix 1st argument to maybe_fatal.
6966
6967 * Makefile.in (TAGS): Depend on $(M_FILE) and $(S_FILE), and scan
6968 them with etags.
6969
f1052e5d
EZ
6970 * makefile.w32-in (globals.h): Add a dummy recipe, to make any
6971 changes in globals.h immediately force recompilation.
762b15be
EZ
6972 (TAGS): Depend on $(CURDIR)/m/intel386.h and
6973 $(CURDIR)/s/ms-w32.h.
6974 (TAGS-gmake): Scan $(CURDIR)/m/intel386.h and $(CURDIR)/s/ms-w32.h.
f1052e5d 6975
fa6996bc
EZ
6976 * character.c (Fchar_direction): Function deleted.
6977 (syms_of_character): Don't defsubr it.
6978 <char-direction-table>: Deleted.
6979
e6c3da20
EZ
69802011-04-23 Eli Zaretskii <eliz@gnu.org>
6981
6982 Fix doprnt so it could be used again safely in `verror'. (Bug#8435)
6983 * doprnt.c: Include limits.h.
6984 (SIZE_MAX): New macro.
04f2d78b
CB
6985 (doprnt): Return a size_t value. 2nd arg is now size_t.
6986 Many local variables are now size_t instead of int or unsigned.
e6c3da20
EZ
6987 Improve overflow protection. Support `l' modifier for integer
6988 conversions. Support %l conversion. Don't assume an EMACS_INT
6989 argument for integer conversions and for %c.
6990
6991 * lisp.h (doprnt): Restore prototype.
6992
6993 * makefile.w32-in ($(BLD)/callint.$(O)): Depend on
6994 $(SRC)/character.h.
6995
6996 * Makefile.in (base_obj): Add back doprnt.o.
6997
6998 * deps.mk (doprnt.o): Add back prerequisites.
6999 (callint.o): Depend on character.h.
7000
7001 * eval.c (internal_lisp_condition_case): Include the handler
7002 representation in the error message.
7003 (verror): Call doprnt instead of vsnprintf. Fix an off-by-one bug
7004 when breaking from the loop.
7005
7006 * xdisp.c (vmessage): Call doprnt instead of vsnprintf.
7007
7008 * callint.c (Fcall_interactively): When displaying error message
7009 about invalid control letter, pass the character's codepoint, not
7010 a pointer to its multibyte form. Improve display of the character
7011 in octal and display also its hex code.
7012
7013 * character.c (char_string): Use %x to display the (unsigned)
7014 codepoint of an invalid character, to avoid displaying a bogus
7015 negative value.
7016
7017 * font.c (check_otf_features): Pass SDATA of SYMBOL_NAME to
7018 `error', not SYMBOL_NAME itself.
7019
7020 * coding.c (Fencode_sjis_char, Fencode_big5_char): Use %c for
7021 character arguments to `error'.
7022
7023 * charset.c (check_iso_charset_parameter): Fix incorrect argument
7024 to `error' in error message about FINAL_CHAR argument. Make sure
7025 FINAL_CHAR is a character, and use %c when it is passed as
7026 argument to `error'.
7027
4ffd0d6b 70282011-04-23 Eli Zaretskii <eliz@gnu.org>
97a93095
EZ
7029
7030 * s/ms-w32.h (localtime): Redirect to sys_localtime.
7031
7032 * w32.c: Include <time.h>.
7033 (sys_localtime): New function.
7034
4ffd0d6b 70352011-04-23 Chong Yidong <cyd@stupidchicken.com>
c17819f4
CY
7036
7037 * xdisp.c (init_xdisp): Initialize echo_area_window (Bug#6451).
7038
4ffd0d6b 7039 * buffer.c (syms_of_buffer): Doc fix (Bug#6902).
aac0c6e3 7040
4ffd0d6b 70412011-04-23 Samuel Thibault <sthibault@debian.org> (tiny change)
aac0c6e3 7042
4ffd0d6b
GM
7043 * sysdep.c (wait_for_termination): On GNU Hurd, kill returns -1 on
7044 zombies (Bug#8467).
aac0c6e3 7045
04c56954
EZ
70462011-04-19 Eli Zaretskii <eliz@gnu.org>
7047
7048 * syntax.h (SETUP_SYNTAX_TABLE_FOR_OBJECT): Fix setting of
7049 gl_state.e_property when gl_state.object is Qt.
7050
7051 * insdel.c (make_gap_larger): Remove limitation of buffer size
7052 to <= INT_MAX.
7053
16a43933
CY
70542011-04-18 Chong Yidong <cyd@stupidchicken.com>
7055
7056 * xdisp.c (lookup_glyphless_char_display)
7057 (produce_glyphless_glyph): Handle cons cell entry in
7058 glyphless-char-display.
7059 (Vglyphless_char_display): Document it.
7060
7061 * term.c (produce_glyphless_glyph): Handle cons cell entry in
7062 glyphless-char-display.
7063
4581706e
CY
70642011-04-17 Chong Yidong <cyd@stupidchicken.com>
7065
7066 * xdisp.c (get_next_display_element): Remove unnecessary ifdefs.
7067
7068 * termhooks.h (FRAME_WINDOW_P): Remove duplicated definitions.
7069
7070 * dispextern.h (FACE_SUITABLE_FOR_ASCII_CHAR_P): Add missing
7071 definition for no-X builds.
7072
4887c6e2 70732011-04-16 Paul Eggert <eggert@cs.ucla.edu>
764430a3 7074
fd35b6f9
PE
7075 Static checks with GCC 4.6.0 and non-default toolkits.
7076
5c1ccb01
PE
7077 * s/sol2-6.h, s/unixware.h (PTY_TTY_NAME_SPRINTF): Protoize decl.
7078
006c5daa
PE
7079 * process.c (keyboard_bit_set): Define only if SIGIO.
7080 (send_process_trap): Mark it with NO_RETURN if it doesn't return.
7081 (send_process): Repair possible setjmp clobbering.
7082
efc736d3
PE
7083 * s/usg5-4-common.h (SETUP_SLAVE_PTY): Don't pass extra arg to 'fatal'.
7084
4e2fe2e6
PE
7085 * eval.c: Include <stdio.h>, for vsnprintf on non-GNU/Linux hosts.
7086
f97334a2
PE
7087 * data.c (arith_error): Mark with NO_RETURN if it doesn't return.
7088
4e75f29d
PE
7089 * alloc.c (bytes_used_when_full, SPARE_MEMORY, BYTES_USED):
7090 Define only if needed.
7091
90efadd1
PE
7092 * sysdep.c (_FILE_OFFSET_BITS): Make this hack even uglier
7093 by pacifying GCC about it. Maybe it's time to retire it?
875975e9 7094 * xfaces.c (USG, __TIMEVAL__): Likewise.
90efadd1 7095
3c647824
PE
7096 * dispextern.h (struct redisplay_interface): Rename param
7097 to avoid shadowing.
e264f262 7098 * termhooks.h (struct terminal): Likewise.
761383f4 7099 * xterm.c (xembed_send_message): Likewise.
3c647824 7100
b58c5c4a
PE
7101 * insdel.c (make_gap_smaller): Define only if
7102 USE_MMAP_FOR_BUFFERS || REL_ALLOC || DOUG_LEA_MALLOC.
7103
cad59032
PE
7104 * keyboard.c (read_char): Make a var volatile so longjmp won't clobber
7105 it.
7106
c339dc2e
PE
7107 * emacs.c (MAX_HEAP_BSS_DIFF, my_edata): Move to where they're used,
7108 so that we aren't warned about unused symbols.
7109
91a3e27b
PE
7110 * xfns.c (Fx_file_dialog): Rename local to avoid shadowing.
7111
399c71d3 7112 * xdisp.c (x_produce_glyphs): Mark var as initialized (Bug#8512).
7a3fb125 7113
8ffc96f5
PE
7114 * xfns.c (x_real_positions): Mark locals as initialized.
7115
eef9bc79
PE
7116 * xmenu.c (xmenu_show): Don't use uninitialized vars.
7117
098db9dd
PE
7118 * xterm.c: Fix problems found by static analysis with other toolkits.
7119 (toolkit_scroll_bar_interaction): Define and use only if USE_X_TOOLKIT.
dda3aedd
PE
7120 (x_dispatch_event): Declare static if USE_GTK, and
7121 define if USE_GTK || USE_X_TOOLKIT.
098db9dd 7122 (SET_SAVED_BUTTON_EVENT): Define only if USE_X_TOOLKIT || USE_GTK.
dda3aedd 7123 * xterm.h (x_dispatch_event): Extern only if USE_X_TOOLKIT.
841a1577
JB
7124 * xterm.c, xterm.h (x_mouse_leave): Bring this function back, but only
7125 if defined HAVE_MENUS && !defined USE_X_TOOLKIT && !defined USE_GTK.
098db9dd 7126
eb18f6cc
PE
7127 * xmenu.c (menu_help_callback): Pointer type fixes.
7128 Use const pointers when pointing at readonly data. Avoid pointer
7129 signedness clashes.
7130 (FALSE): Remove unused macro.
7131 (update_frame_menubar): Remove unused decl.
7132
1fe72bf8
PE
7133 * xfns.c (Fx_hide_tip): Move locals to avoid shadowing.
7134
60d9e1db
PE
7135 * menu.c (push_submenu_start, push_submenu_end): Do not define unless
7136 USE_X_TOOLKIT || USE_GTK || HAVE_NS || defined HAVE_NTGUI.
7137 (single_menu_item): Rename local to avoid shadowing.
7138
39261c26
PE
7139 * keyboard.c (make_lispy_event): Remove unused local var.
7140
018c5e19
PE
7141 * frame.c, frame.h (x_get_resource_string): Bring this back, but
7142 only if HAVE_X_WINDOWS && !USE_X_TOOLKIT.
7143
63d2b86e
PE
7144 * bitmaps: Change bitmaps from unsigned char back to the X11
7145 compatible char. Avoid the old compiler warnings about
7146 out-of-range initializers by using, for example, '\xab' rather
7147 than 0xab.
7148
aefd87e1
PE
7149 * xgselect.c (xgselect_initialize): Check vs interface
7150 even if ! (defined (USE_GTK) || defined (HAVE_GCONF)).
7151
bf501fb9
PE
7152 * xmenu.c (xmenu_show): Rename parm to avoid shadowing.
7153
e9829fdf
PE
7154 * xterm.c (x_create_toolkit_scroll_bar): Use const * for pointers
7155 to read-only memory.
7156
1086c095
PE
7157 * fns.c (vector): Remove; this old hack is no longer needed.
7158
2baccd04 7159 * xsmfns.c (create_client_leader_window): Rename shadowing arg.
401f10cb 7160 Remove unused var.
dde42981 7161 (gdk_x11_set_sm_client_id) [!USE_GTK]: Don't define.
2baccd04 7162
72391843 7163 * xrdb.c (x_load_resources): Omit unused local.
3565b346 7164
436c16df 7165 * xfns.c (free_frame_menubar, atof): Remove duplicate decls.
8a94ea33 7166 (x_window): Rename locals to avoid shadowing.
dc5ddd85 7167 (USG): Use the kludged USG macro, to pacify gcc.
436c16df 7168
92bb796d 7169 * xterm.c (x_alloc_nearest_color_for_widget): Remove; unused.
bbbef9e1 7170 (x_term_init): Remove local to avoid shadowing.
92bb796d 7171
764430a3 7172 * xfns.c, xterm.c (_XEditResCheckMessages): Protoize decl.
4887c6e2
PE
7173
7174 * xdisp.c, dispextern.h (set_vertical_scroll_bar): Now extern if
7175 USE_TOOLKIT_SCROLL_BARS && !USE_GTK, as xterm.c needs it then.
7176
d1dfb56c
EZ
71772011-04-16 Eli Zaretskii <eliz@gnu.org>
7178
c4354cb4
EZ
7179 * gnutls.c (Fgnutls_boot): Don't pass Lisp_Object to `error'.
7180
d1dfb56c
EZ
7181 Fix regex.c, syntax.c and friends for buffers > 2GB.
7182 * syntax.h (struct gl_state_s): Declare character position members
7183 EMACS_INT.
7184
7185 * syntax.c (update_syntax_table): Declare 2nd argument EMACS_INT.
7186
04f2d78b
CB
7187 * textprop.c (verify_interval_modification, interval_of):
7188 Declare arguments EMACS_INT.
d1dfb56c
EZ
7189
7190 * intervals.c (adjust_intervals_for_insertion): Declare arguments
7191 EMACS_INT.
7192
7193 * intervals.h (CHECK_TOTAL_LENGTH): Cast to EMACS_INT, not `int'.
7194
7195 * indent.c (Fvertical_motion): Local variable it_start is now
7196 EMACS_INT.
7197
7198 * regex.c (re_match, re_match_2, re_match_2_internal)
7199 (bcmp_translate, regcomp, regexec, print_double_string)
7200 (group_in_compile_stack, re_search, re_search_2, regex_compile)
7201 (re_compile_pattern, re_exec): Declare arguments and local
7202 variables `size_t' and `ssize_t' and return values `regoff_t', as
7203 appropriate.
7204 (POP_FAILURE_REG_OR_COUNT) <pfreg>: Declare `long'.
7205 (CHECK_INFINITE_LOOP) <failure>: Declare `ssize_t'.
7206 <compile_stack_type>: `size' and `avail' are now `size_t'.
7207
7208 * regex.h <regoff_t>: Use ssize_t, not int.
7209 (re_search, re_search_2, re_match, re_match_2): Arguments that
7210 specify buffer/string position and length are now ssize_t and
7211 size_t. Return type is regoff_t.
7212
613052cd
BK
72132011-04-16 Ben Key <bkey76@gmail.com>
7214
7215 * nsfont.m: Fixed bugs in ns_get_family and
7216 ns_descriptor_to_entity that were caused by using free to
7217 deallocate memory blocks that were allocated by xmalloc (via
7218 xstrdup). This caused Emacs to crash when compiled with
7219 XMALLOC_OVERRUN_CHECK defined (when Emacs was configured with
7220 --enable-checking=xmallocoverrun). xfree is now used to
7221 deallocate these memory blocks.
7222
4170f62f 72232011-04-15 Paul Eggert <eggert@cs.ucla.edu>
3e047f51 7224
71b41406
PE
7225 * sysdep.c (emacs_read): Remove unnecessary check vs MAX_RW_COUNT.
7226
9587a89d
PE
7227 emacs_write: Accept and return EMACS_INT for sizes.
7228 See http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00514.html
7229 et seq.
7230 * gnutls.c, gnutls.h (emacs_gnutls_read, emacs_gnutls_write):
7231 Accept and return EMACS_INT.
7232 (emacs_gnutls_write): Return the number of bytes written on
7233 partial writes.
7234 * sysdep.c, lisp.h (emacs_read, emacs_write): Likewise.
273a5f82
PE
7235 (emacs_read, emacs_write): Remove check for negative size, as the
7236 Emacs source code has been audited now.
9587a89d
PE
7237 * sysdep.c (MAX_RW_COUNT): New macro, to work around kernel bugs.
7238 (emacs_read, emacs_write): Use it.
273a5f82
PE
7239 * process.c (send_process): Adjust to the new signatures of
7240 emacs_write and emacs_gnutls_write. Do not attempt to store
7241 a byte offset into an 'int'; it might overflow.
9587a89d 7242 See http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00483.html
273a5f82 7243
3e047f51
PE
7244 * sound.c: Don't assume sizes fit in 'int'.
7245 (struct sound_device.period_size, alsa_period_size):
9c3c56a7 7246 Return EMACS_INT, not int.
3e047f51 7247 (struct sound_device.write, vox_write, alsa_write):
9c3c56a7
PE
7248 Accept EMACS_INT, not int.
7249 (wav_play, au_play): Use EMACS_INT to store sizes and to
3e047f51
PE
7250 record read return values.
7251
cc39a9db
BK
72522011-04-15 Ben Key <bkey76@gmail.com>
7253
c9d0ec6d
JB
7254 * keyboard.c (Qundefined): Don't declare static since it is used
7255 in nsfns.m.
7256 * xfaces.c (Qbold, Qexpanded, Qitalic, Qcondensed): Don't declare
7257 static since they are used in nsfont.m.
cc39a9db 7258
6c60eb9f
SM
72592011-04-15 Stefan Monnier <monnier@iro.umontreal.ca>
7260
7261 * process.c (Qprocessp): Don't declare static.
7262 * lisp.h (Qprocessp): Declare again.
7263
7990b61a
JB
72642011-04-15 Juanma Barranquero <lekktu@gmail.com>
7265
7266 * font.c (Qopentype): Don't make static (used from w32uniscribe.c).
7267
5d4cb038
PE
72682011-04-14 Paul Eggert <eggert@cs.ucla.edu>
7269
8bd7b830 7270 Improve C-level modularity by making more things 'static'.
cd64ea1d 7271
e3b27b31
PE
7272 Don't publish debugger-only interfaces to other modules.
7273 * lisp.h (safe_debug_print, debug_output_compilation_hack):
7274 (verify_bytepos, count_markers): Move decls to the only modules
7275 that need them.
7276 * region-cache.h (pp_cache): Likewise.
7277 * window.h (check_all_windows): Likewise.
7278 * marker.c, print.c, region-cache.c, window.c: Decls moved here.
7279
5d4cb038
PE
7280 * sysdep.c (croak): Now static, if
7281 defined TIOCNOTTY || defined USG5 || defined CYGWIN.
7282 * syssignal.h (croak): Declare only if not static.
69003fd8
PE
7283
7284 * alloc.c (refill_memory_reserve): Now static if
7285 !defined REL_ALLOC || defined SYSTEM_MALLOC.
7286 * lisp.h (refill_memory_reserve): Declare only if not static.
93ea6e8f 7287
e87b6180
PE
7288 * xsettings.c, xsettings.h (xsettings_get_system_normal_font):
7289 Define only if USE_LUCID.
7290
ac64929e
PE
7291 * xrdb.c (x_customization_string, x_rm_string): Now static.
7292
6f37259d
PE
7293 * xmenu.c (x_menu_wait_for_event): Export only if USE_MOTIF.
7294 * xterm.h (x_menu_wait_for_event): Declare only if USE_MOTIF.
7295
1683e3ab
PE
7296 * xdisp.c (draw_row_with_mouse_face): Now static.
7297 * dispextern.h (draw_row_with_mouse_fave): Remove decl.
7298
de9c2632
PE
7299 * window.h (check_all_windows): Mark externally visible.
7300
2b96acb7
PE
7301 * window.c (window_deletion_count): Now static.
7302
7303 * undo.c: Make symbols static if they're not exported.
7304 (last_undo_buffer, last_boundary_position, pending_boundary):
7305 Now static.
7306
50436f33
PE
7307 * textprop.c (interval_insert_behind_hooks): Now static.
7308 (interval_insert_in_front_hooks): Likewise.
7309
64520e5c
PE
7310 * term.c: Make symbols static if they're not exported.
7311 (tty_turn_off_highlight, get_tty_terminal, max_frame_cols):
7312 (max_frame_lines, tty_set_terminal_modes):
7313 (tty_reset_terminal_modes, tty_turn_off_highlight):
7314 (get_tty_terminal): Now static.
7315 (term_mouse_moveto): Do not define if HAVE_WINDOW_SYSTEM.
7316 * termhooks.h (term_mouse_moveto): Do not declare if
8bd7b830 7317 HAVE_WINDOW_SYSTEM.
64520e5c
PE
7318 * dispextern.h (tty_set_terminal_modes, tty_reset_terminal_modes):
7319 (tty_turn_off_highlight, get_tty_terminal): Remove decls.
7320
1fa53021
PE
7321 * sysdep.c: Make symbols static if they're not exported.
7322 (emacs_get_tty, emacs_set_tty, old_fcntl_flags, old_fcntl_owner):
7323 Now static.
7324 (sigprocmask_set, full_mask): Remove; unused.
7325 (wait_debugging): Mark as visible.
7326 * syssignal.h (SIGFULLMASK, full_mask): Remove decls.
7327 * systty.h (emacs_get_tty, emacs_set_tty): Remove decls.
7328
d4b43b22
PE
7329 * syntax.c (syntax_temp): Define only if !__GNUC__.
7330
b7c513d0
PE
7331 * sound.c (current_sound_device, current_sound): Now static.
7332
989b29ad
PE
7333 * search.c (searchbufs, searchbuf_head): Now static.
7334
13a55a78
PE
7335 * scroll.c (scroll_cost): Remove; unused.
7336 * dispextern.h (scroll_cost): Remove decl.
7337
de68a1fc
PE
7338 * region-cache.h (pp_cache): Mark as externally visible.
7339
40ccffa6
PE
7340 * process.c: Make symbols static if they're not exported.
7341 (process_tick, update_tick, create_process, chan_process):
7342 (Vprocess_alist, proc_buffered_char, datagram_access):
7343 (fd_callback_data, send_process_frame, process_sent_to): Now static.
7344 (deactivate_process): Mark defn as static, as well as decl.
7345 * lisp.h (create_process): Remove decl.
7346 * process.h (chan_process, Vprocess_alist): Remove decls.
7347
ad64fc97
PE
7348 * print.c: Make symbols static if they're not exported.
7349 (print_depth, new_backquote_output, being_printed, print_buffer):
7350 (print_buffer_size, print_buffer_pos, print_buffer_pos_byte):
7351 (print_interval, print_number_index, initial_stderr_stream):
7352 Now static.
7353 * lisp.h (Fprinc): Remove decl.
7354 (debug_output_compilation_hack): Mark as externally visible.
7355
adddb265
PE
7356 * sysdep.c (croak): Move decl from here to syssignal.h.
7357 * syssignal.h (croak): Put it here, so the API can be checked when
7358 'croak' is called from dissociate_if_controlling_tty.
7359
1717ede2
PE
7360 * minibuf.c: Make symbols static if they're not exported.
7361 (minibuf_save_list, choose_minibuf_frame): Now static.
7362 * lisp.h (choose_minibuf_frame): Remove decl.
7363
fa5fb2bc
PE
7364 * lisp.h (verify_bytepos, count_markers): Mark as externally visible.
7365
1e3890d1
PE
7366 * lread.c: Make symbols static if they're not exported.
7367 (read_objects, initial_obarray, oblookup_last_bucket_number):
7368 Now static.
7369 (make_symbol): Remove; unused.
7370 * lisp.h (initial_obarray, make_symbol): Remove decls.
7371
8a1414fa
PE
7372 * keyboard.c: Make symbols static if they're not exported.
7373 (single_kboard, recent_keys_index, total_keys, recent_keys):
7374 (this_command_key_count_reset, raw_keybuf, raw_keybuf_count):
7375 (this_single_command_key_start, echoing, last_auto_save):
7376 (read_key_sequence_cmd, dribble, recursive_edit_unwind):
7377 (command_loop, echo_now, keyboard_init_hook, help_char_p):
7378 (quit_throw_to_read_char, command_loop_2, top_level_1, poll_timer):
7379 (Vlispy_mouse_stem, double_click_count):
7380 Now static.
7381 (force_auto_save_soon): Define only if SIGDANGER.
7382 (ignore_mouse_drag_p): Now static if
7383 !defined HAVE_WINDOW_SYSTEM || defined USE_GTK || defined HAVE_NS.
7384 (print_help): Remove; unused.
7385 (stop_character, last_timer_event): Mark as externally visible.
7386 * keyboard.h (ignore_mouse_drag_p): Declare only if
7387 defined HAVE_WINDOW_SYSTEM && !defined USE_GTK && !defined HAVE_NS.
7388 (echo_now, help_char_p, quit_throw_to_read_char): Remove decls.
7389 * lisp.h (echoing): Remove decl.
7390 (force_auto_save_soon): Declare only if SIGDANGER.
7391 * xdisp.c (redisplay_window): Simplify code, to make it more
7392 obvious that ignore_mouse_drag_p is not accessed if !defined
7393 USE_GTK && !defined HAVE_NS.
7394
93ea6e8f
PE
7395 * intervals.c: Make symbols static if they're not exported.
7396 (merge_properties_sticky, merge_interval_right, delete_interval):
7397 Now static.
7398 * intervals.h (merge_interval_right, delete_interval): Remove decls.
7399
77382fcc
PE
7400 * insdel.c: Make symbols static if they're not exported.
7401 However, leave prepare_to_modify_buffer alone. It's never
7402 called from outside this function, but that appears to be a bug.
7403 (combine_after_change_list, combine_after_change_buffer):
4889fc82 7404 (adjust_after_replace, signal_before_change): Now static.
77382fcc
PE
7405 (adjust_after_replace_noundo): Remove; unused.
7406 * lisp.h (adjust_after_replace, adjust_after_replace_noundo):
4889fc82 7407 (signal_before_change): Remove decls.
77382fcc 7408
9306c32e
PE
7409 * indent.c (val_compute_motion, val_vmotion): Now static.
7410
cd44d2eb
PE
7411 * image.c: Make symbols static if they're not exported.
7412 * dispextern.h (x_create_bitmap_from_xpm_data): Do not declare
7413 if USE_GTK.
7414 * image.c (x_create_bitmap_from_xpm_data): Do not define if USE_GTK.
7415 (xpm_color_cache, ct_table, ct_colors_allocated): Now static.
7416
ad9a7a06
PE
7417 * fringe.c (standard_bitmaps): Now static.
7418 (max_used_fringe_bitmap): Now static, unless HAVE_NS.
7419
81626931
PE
7420 * frame.c: Make symbols static if they're not exported.
7421 (x_report_frame_params, make_terminal_frame): Now static.
7422 (get_frame_param): Now static, unless HAVE_NS.
7423 (x_fullscreen_adjust): Define if WINDOWSNT, not if HAVE_WINDOW_SYSTEM.
7424 (x_get_resource_string): Remove; not used.
7425 * frame.h (make_terminal_frame, x_report_frame_params):
7426 (x_get_resource_string); Remove decls.
7427 (x_fullscreen_adjust): Declare only if WINDOWSNT.
7428 * lisp.h (get_frame_param): Declare only if HAVE_NS.
7429
239f9db9
PE
7430 * font.c, fontset.c: Make symbols static if they're not exported.
7431 * dispextern.h (FACE_SUITABLE_FOR_ASCII_CHAR_P): New macro.
7432 (FACE_SUITABLE_FOR_CHAR_P): Use it.
7433 * font.c (font_close_object): Now static.
7434 * font.h (font_close_object): Remove.
7435 * fontset.c (FONTSET_OBJLIST): Remove.
7436 (free_realized_fontset) #if-0 the body, which does nothing.
7437 (face_suitable_for_char_p): #if-0, as it's never called.
7438 * fontset.h (face_suitable_for_char_p): Remove decl.
04f2d78b
CB
7439 * xfaces.c (face_at_string_position):
7440 Use FACE_SUITABLE_FOR_ASCII_CHAR_P, not FACE_SUITABLE_FOR_CHAR_P,
239f9db9
PE
7441 since 0 is always ASCII.
7442
dfcf3579
PE
7443 * fns.c (weak_hash_tables): Now static.
7444
5045092b
PE
7445 * fileio.c: Make symbols static if they're not exported.
7446 (auto_saving, auto_save_mode_bits, auto_save_error_occurred):
7447 (Vwrite_region_annotation_buffers): Now static.
7448
57a96f5c
PE
7449 * eval.c: Make symbols static if they're not exported.
7450 (backtrace_list, lisp_eval_depth, when_entered_debugger): Now static.
7451 * lisp.h (backtrace_list): Remove decl.
7452
35f08c38
PE
7453 * emacs.c: Make symbols static if they're not exported.
7454 (malloc_state_ptr, malloc_using_checking, syms_of_emacs):
7455 (fatal_error_code, fatal_error_signal_hook, standard_args):
7456 Now static.
7457 (fatal_error_signal): Now static, unless FLOAT_CATCH_SIGKILL.
7458 (DEFINE_DUMMY_FUNCTION): Mark function as externally visible.
7459 (__CTOR_LIST__, __DTOR_LIST__): Now externally visible.
7460 * lisp.h (fatal_error_signal_hook): Remove decl.
7461 (fatal_error_signal): Declare only if FLOAT_CATCH_SIGKILL.
7462
f44bd759
PE
7463 * editfns.c: Move a (normally-unused) function to its only use.
7464 * editfns.c, lisp.h (get_operating_system_release): Remove.
7465 * process.c (init_process) [DARWIN_OS]: Do it inline, as it is not
7466 worth the hassle of breaking this out.
7467
b532497d
PE
7468 * xterm.c: Make symbols static if they're not exported.
7469 (x_raise_frame, x_lower_frame, x_wm_set_window_state):
7470 (x_wm_set_icon_pixmap, x_initialize, XTread_socket_fake_io_error):
7471 (x_destroy_window, x_delete_display):
7472 Now static.
7473 (x_dispatch_event): Now static if ! (USE_MOTIF || USE_X_TOOLKIT).
7474 (x_mouse_leave): Remove; unused.
7475 * xterm.h (x_display_info_for_name, x_raise_frame, x_lower_frame):
7476 (x_destroy_window, x_wm_set_window_state, x_wm_set_icon_pixmap):
7477 (x_delete_display, x_initialize, x_set_border_pixel, x_screen_planes):
7478 Remove decls.
7479 (x_mouse_leave): Declare only if WINDOWSNT.
7480 (x_dispatch_event): Declare only if USE_MOTIF or USE_X_TOOLKIT.
7481 (xic_create_fontsetname): Declare only if HAVE_X_WINDOWS &&
7482 USE_X_TOOLKIT.
7483
1675728f
PE
7484 * ftxfont.c: Make symbols static if they're not exported.
7485 (ftxfont_driver): Export only if !defined HAVE_XFT && def8ined
7486 HAVE_FREETYPE.
7487 * font.h (ftxfont_driver): Likewise.
7488
e4cebfca
PE
7489 * xfns.c: Make symbols static if they're not exported.
7490 (x_last_font_name, x_display_info_for_name):
7491 (x_set_foreground_color, x_set_background_color, x_set_mouse_color):
7492 (x_set_cursor_color, x_set_border_pixel, x_set_border_color):
7493 (x_set_cursor_type, x_set_icon_type, x_set_icon_name):
7494 (x_set_scroll_bar_foreground, x_set_scroll_bar_background):
7495 (x_explicitly_set_name, x_set_title, xic_defaut_fontset, tip_timer):
7496 (last_show_tip_args): Now static.
7497 (xic_defaut_fontset, xic_create_fontsetname): Define only if
7498 defined HAVE_X_WINDOWS && defined USE_X_TOOLKIT
7499 (x_screen_planes): Remove; unused.
7500 * dispextern.h (x_screen_planes): Remove decl.
7501
5bf46f05
PE
7502 * dispnew.c: Make symbols static if they're not exported.
7503 * dispextern.h (redraw_garbaged_frames, scrolling):
7504 (increment_row_positions): Remove.
7505 * dispnew.c (new_glyph_matrix, increment_row_positions, scrolling):
7506 (delayed_size_change, glyph_matrix_count, glyph_pool_count):
7507 Now static.
7508 (redraw_garbaged_frames): Remove; unused.
7509
435f4c28
PE
7510 * xfaces.c: Make symbols static if they're not exported.
7511 * dispextern.h (ascii_face_of_lisp_face, free_realized_face):
7512 Remove decls.
7513 * xterm.h (defined_color): Remove decls.
7514 (x_free_dpy_colors): Declare only if USE_X_TOOLKIT.
7515 * xfaces.c (tty_suppress_bold_inverse_default_colors_p):
7516 (menu_face_changed_default, defined_color, free_realized_face):
7517 (x_free_dpy_colors): Define only if USE_X_TOOLKIT.
7518 (ascii_face_of_lisp_face): Remove; unused.
7519
8524aef3
PE
7520 * xdisp.c: Make symbols static if they're not exported.
7521 * dispextern.h (scratch_glyph_row, window_box_edges):
7522 (glyph_to_pixel_coords, set_cursor_from_row):
7523 (get_next_display_element, set_iterator_to_next):
7524 (highlight_trailing_whitespace, frame_to_window_pixel_xy):
7525 (show_mouse_face): Remove decls
7526 * frame.h (message_buf_print): Likewise.
7527 * lisp.h (pop_message, set_message, check_point_in_composition):
7528 Likewise.
7529 * xterm.h (set_vertical_scroll_bar): Likewise.
7530 * xdisp.c (list_of_error, Vmessage_stack, line_number_displayed):
7531 (message_buf_print, scratch_glyph_row, displayed_buffer):
7532 (set_iterator_to_next, pop_message, set_message, set_cursor_from_row):
7533 (get_next_display_element, show_mouse_face, window_box_edges):
7534 (frame_to_window_pixel_xy, check_point_in_composition):
7535 (set_vertical_scroll_bar, highlight_trailing_whitespace): Now static.
7536 (glyph_to_pixel_coords): Remove; unused.
7537
16390cd2
PE
7538 * dired.c (file_name_completion): Now static.
7539
7540 * dbusbind.c (xd_in_read_queued_messages): Now static.
7541
a25f4dfa
PE
7542 * lisp.h (circular_list_error, FOREACH): Remove; unused.
7543 * data.c (circular_list_error): Remove.
7544
14a9c8df
PE
7545 * commands.h (last_point_position, last_point_position_buffer):
7546 (last_point_position_window): Remove decls.
7547 * keyboard.c: Make these variables static.
7548
04f2d78b
CB
7549 * coding.h (coding, code_convert_region, encode_coding_gap):
7550 Remove decls.
74ab6df5
PE
7551 * coding.c (Vsjis_coding_system, Vbig5_coding_system):
7552 (iso_code_class, detect_coding, code_convert_region): Now static.
7553 (encode_coding_gap): Remove; unused.
7554
38dfbee1
PE
7555 * chartab.c (chartab_chars, chartab_bits): Now static.
7556
a2cb4e63
PE
7557 * charset.h (charset_iso_8859_1): Remove decl.
7558 * charset.c (charset_iso_8859_1, charset_emacs, map_charset_for_dump):
7559 Now static.
7560
127198fd
PE
7561 * ccl.h (check_ccl_update, Vccl_program_table): Remove decls.
7562 * ccl.c (Vccl_program_table): Now static.
7563 (check_ccl_update): Remove; unused.
7564
d85b608f
PE
7565 * category.c (SET_CATEGORY_SET, set_category_set): Move here.
7566 * category.h: ... from here.
7567 * category.c (check_category_table, set_category_set): Now static.
7568
31cd66f3
PE
7569 * casetab.c (Vascii_upcase_table, Vascii_eqv_table): Now static.
7570 * lisp.h: Remove these decls.
7571
c358e587
PE
7572 * buffer.c (buffer_count): Remove unused var.
7573
e78aecca
PE
7574 * bidi.c (bidi_dump_cached_states): Mark as externally visible,
7575 so that it's not optimized away.
7576 (bidi_ignore_explicit_marks_for_paragraph_level): Likewise.
7577 * dispextern.h (bidi_dump_cached_states): Remove, since it's
7578 exported only to the debugger.
7579
e192d7d3 7580 * atimer.c (alarm_signal_handler, run_all_atimers): Now static.
04f2d78b 7581 * atimer.h (run_all_atimers): Remove; not exported.
e192d7d3 7582
92470028
PE
7583 font.c: Make copy_font_spec and merge_font_spec ordinary C functions.
7584 * font.c (copy_font_spec): Rename from Fcopy_font_spec, since it
7585 was inaccessible from Lisp.
7586 (merge_font_spec): Likewise, renaming from Fmerge_font_spec.
7587 * font.c, font.h, fontset.c, xfaces.c, xfont.c: Change all uses.
7588
244ed907
PE
7589 alloc.c: Import and export fewer symbols, and remove unused items.
7590 * lisp.h (suppress_checking, die): Declare only if ENABLE_CHECKING
7591 is defined.
7592 (suppress_checking): Add EXTERNALLY_VISIBLE attribute, so that
7593 it's not optimized away by whole-program optimization.
7594 (message_enable_multibyte, free_misc): Remove.
7595 (catchlist, handlerlist, mark_backtrace):
7596 Declare only if BYTE_MARK_STACK.
7597 (mark_byte_stack): Likewise, fixing a ifdef-vs-if typo.
7598 * alloc.c (pure): Export only if VIRT_ADDR_VARIES is defined.
7599 (message_enable_multibyte): Remove decl.
7600 (free_misc, interval_free_list, float_block, float_block_index):
7601 (n_float_blocks, float_free_list, cons_block, cons_block_index):
7602 (cons_free_list, last_marked_index):
7603 Now static.
7604 (suppress_checking, die): Define only if ENABLE_CHECKING is defined.
7605 * eval.c (catchlist, handlerlist): Export only if BYTE_MARK_STACK.
7606 (mark_backtrace): Define only if BYTE_MARK_STACK.
7607 * xdisp.c (message_enable_multibyte): Now static.
7608
61c2b50e 7609 Declare Lisp_Object Q* variables to be 'static' if not exported.
955cbe7b
PE
7610 This makes it easier for human readers (and static analyzers)
7611 to see whether these variables are used from other modules.
7612 * alloc.c, buffer.c, bytecode.c, callint.c, casetab.c, category.c:
7613 * ccl.c, character.c, charset.c, cmds.c, coding.c, composite.c:
7614 * data.c, dbusbind.c, dired.c, editfns.c, eval.c, fileio.c, fns.c:
7615 * font.c, frame.c, fringe.c, ftfont.c, image.c, keyboard.c, keymap.c:
7616 * lread.c, macros.c, minibuf.c, print.c, process.c, search.c:
7617 * sound.c, syntax.c, textprop.c, window.c, xdisp.c, xfaces.c, xfns.c:
7618 * xmenu.c, xselect.c:
7619 Declare Q* vars static if they are not used in other modules.
7620 * ccl.h, character.h, charset.h, coding.h, composite.h, font.h:
7621 * frame.h, intervals.h, keyboard.h, lisp.h, process.h, syntax.h:
7622 Remove decls of unexported vars.
7623 * keyboard.h (EVENT_HEAD_UNMODIFIED): Remove now-unused macro.
7624
95c82688
PE
7625 * lisp.h (DEFINE_FUNC): Make sname 'static'.
7626
16a97296
PE
7627 Make Emacs functions such as Fatom 'static' by default.
7628 This makes it easier for human readers (and static analyzers)
7629 to see whether these functions can be called from other modules.
7630 DEFUN now defines a static function. To make the function external
7631 so that it can be used in other C modules, use the new macro DEFUE.
8bd7b830
PE
7632 * lisp.h (Funibyte_char_to_multibyte, Fsyntax_table_p):
7633 (Finit_image_library):
16a97296
PE
7634 (Feval_region, Fbacktrace, Ffetch_bytecode, Fswitch_to_buffer):
7635 (Ffile_executable_p, Fmake_symbolic_link, Fcommand_execute):
7636 (Fget_process, Fdocumentation_property, Fbyte_code, Ffile_attributes):
7637 Remove decls, since these functions are now static.
7638 (Funintern, Fget_internal_run_time): New decls, since these functions
7639 were already external.
95c82688 7640
16a97296
PE
7641 * alloc.c, buffer.c, callint.c, callproc.c, casefiddle.c, casetab.c:
7642 * ccl.c, character.c, chartab.c, cmds.c, coding.c, data.c, dispnew.c:
7643 * doc.c, editfns.c, emacs.c, eval.c, fileio.c, filelock.c, floatfns.c:
7644 * fns.c, font.c, fontset.c, frame.c, image.c, indent.c:
7645 * keyboard.c, keymap.c, lread.c:
7646 * macros.c, marker.c, menu.c, minibuf.c, print.c, process.c, search.c:
7647 * syntax.c, term.c, terminal.c, textprop.c, undo.c:
7648 * window.c, xdisp.c, xfaces.c, xfns.c, xmenu.c, xsettings.c:
7649 Mark functions with DEFUE instead of DEFUN,
7650 if they are used in other modules.
7651 * buffer.c (Fset_buffer_major_mode, Fdelete_overlay): New forward
7652 decls for now-static functions.
7653 * buffer.h (Fdelete_overlay): Remove decl.
7654 * callproc.c (Fgetenv_internal): Mark as internal.
7655 * composite.c (Fremove_list_of_text_properties): Remove decl.
7656 (Fcomposition_get_gstring): New forward static decl.
7657 * composite.h (Fcomposite_get_gstring): Remove decl.
7658 * dired.c (Ffile_attributes): New forward static decl.
7659 * doc.c (Fdocumntation_property): New forward static decl.
7660 * eval.c (Ffetch_bytecode): New forward static decl.
7661 (Funintern): Remove extern decl; now in .h file where it belongs.
7662 * fileio.c (Fmake_symbolic_link): New forward static decl.
7663 * image.c (Finit_image_library): New forward static decl.
7664 * insdel.c (Fcombine_after_change_execute): Make forward decl static.
7665 * intervals.h (Fprevious_property_change):
7666 (Fremove_list_of_text_properties): Remove decls.
7667 * keyboard.c (Fthis_command_keys): Remove decl.
7668 (Fcommand_execute): New forward static decl.
7669 * keymap.c (Flookup_key): New forward static decl.
7670 (Fcopy_keymap): Now static.
7671 * keymap.h (Flookup_key): Remove decl.
7672 * process.c (Fget_process): New forward static decl.
7673 (Fprocess_datagram_address): Mark as internal.
7674 * syntax.c (Fsyntax_table_p): New forward static decl.
7675 (skip_chars): Remove duplicate decl.
7676 * textprop.c (Fprevious_property_change): New forward static decl.
7677 * window.c (Fset_window_fringes, Fset_window_scroll_bars):
7678 Now internal.
7679 (Fset_window_margins, Fset_window_vscroll): New forward static decls.
7680 * window.h (Fset_window_vscroll, Fset_window_margins): Remove decls.
7681
785bbd42
PE
7682 * editfns.c (Fformat): Remove unreachable code.
7683
8b913b57
AS
76842011-04-14 Andreas Schwab <schwab@linux-m68k.org>
7685
7686 * fileio.c (Finsert_file_contents): Fix typo in 2005-05-13
7687 change. (Bug#8496)
7688
a6744a35
EZ
76892011-04-13 Eli Zaretskii <eliz@gnu.org>
7690
7691 * xdisp.c (handle_invisible_prop): Don't call bidi_paragraph_init
7692 when at ZV. (Bug#8487)
7693
e7974947
AS
76942011-04-12 Andreas Schwab <schwab@linux-m68k.org>
7695
baad03f0
AS
7696 * charset.c (Fclear_charset_maps): Use xfree instead of free.
7697 (Bug#8437)
7698 * keyboard.c (parse_tool_bar_item): Likewise.
7699 * sound.c (sound_cleanup, alsa_close): Likewise.
7700 * termcap.c (tgetent): Likewise.
7701 * xfns.c (x_default_font_parameter): Likewise.
7702 * xsettings.c (read_and_apply_settings): Likewise.
7703
e7974947
AS
7704 * alloc.c (overrun_check_malloc, overrun_check_realloc)
7705 (overrun_check_free): Protoize.
7706
28272684
PE
77072011-04-12 Paul Eggert <eggert@cs.ucla.edu>
7708
7709 * sysdep.c (emacs_read, emacs_write): Check for negative sizes
7710 since callers should never pass a negative size.
7711 Change the signature to match that of plain 'read' and 'write'; see
7712 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00397.html>.
7713 * lisp.h: Update prototypes of emacs_write and emacs_read.
7714
11997c76
EZ
77152011-04-11 Eli Zaretskii <eliz@gnu.org>
7716
7717 * xdisp.c (redisplay_window): Don't try to determine the character
7718 position of the scroll margin if the window start point w->startp
e896f03c 7719 is outside the buffer's accessible region. (Bug#8468)
11997c76 7720
8a2cbd72
EZ
77212011-04-10 Eli Zaretskii <eliz@gnu.org>
7722
7723 Fix write-region and its subroutines for buffers > 2GB.
7724 * fileio.c (a_write, e_write): Modify declaration of arguments and
7725 local variables to support buffers larger than 2GB.
7726 (Fcopy_file): Use EMACS_INT for return value of emacs_read.
7727
7728 * sysdep.c (emacs_write, emacs_read): Use ssize_t for last
7729 argument, local variables, and return value.
7730
7731 * lisp.h: Update prototypes of emacs_write and emacs_read.
7732
7733 * sound.c (vox_write): Use ssize_t for return value of emacs_write.
7734
4073e537 77352011-04-10 Paul Eggert <eggert@cs.ucla.edu>
eb3f1cc8 7736
1ebfdcb6
PE
7737 * xdisp.c (vmessage): Use memchr, not strnlen, which some hosts lack.
7738
b2ded58d
PE
7739 Fix more problems found by GCC 4.6.0's static checks.
7740
7d66342c
PE
7741 * xdisp.c (vmessage): Use a better test for character truncation.
7742
bbf47d44
PE
7743 * charset.c (load_charset_map): <, not <=, for optimization,
7744 and to avoid potential problems with integer overflow.
9248994d 7745 * chartab.c (sub_char_table_set_range, char_table_set_range): Likewise.
f9a68bc5 7746 * casetab.c (set_identity, shuffle): Likewise.
3ab1c7ce 7747 * editfns.c (Fformat): Likewise.
1e69125e 7748 * syntax.c (skip_chars): Likewise.
3befa583 7749
e3019616
PE
7750 * xmenu.c (set_frame_menubar): Allocate smaller local vectors.
7751 This also lets GCC 4.6.0 generate slightly better loop code.
7752
becfa255
PE
7753 * callint.c (Fcall_interactively): <, not <=, for optimization.
7754 (Fcall_interactively): Count the number of arguments produced,
7755 not the number of arguments given. This is simpler and lets GCC
7756 4.6.0 generate slightly better code.
7757
dae0cd48
PE
7758 * ftfont.c: Distingish more carefully between FcChar8 and char.
7759 The previous code passed unsigned char * to a functions like
7760 strlen and xstrcasecmp that expect char *, which does not
7761 conform to the C standard.
7762 (get_adstyle_property, ftfont_pattern_entity): Use FcChar8 for
7763 arguments to FcPatternGetString, and explicitly cast FcChar8 * to
7764 char * when the C standard requires it.
7765
76032d70
PE
7766 * keyboard.c (read_char): Remove unused var.
7767
eb3f1cc8
PE
7768 * eval.c: Port to Windows vsnprintf (Bug#8435).
7769 Include <limits.h>.
7770 (SIZE_MAX): Define if the headers do not.
7771 (verror): Do not give up if vsnprintf returns a negative count.
7772 Instead, grow the buffer. This ports to Windows vsnprintf, which
7773 does not conform to C99. Problem reported by Eli Zaretskii.
7774 Also, simplify the allocation scheme, by avoiding the need for
7775 calling realloc, and removing the ALLOCATED variable.
7776
70476b54
PE
7777 * eval.c (verror): Initial buffer size is 4000 (not 200) bytes.
7778
12020a9e
PE
7779 Remove invocations of doprnt, as Emacs now uses vsnprintf.
7780 But keep the doprint source code for now, as we might revamp it
7781 and use it again (Bug#8435).
ea6c7ae6
PE
7782 * lisp.h (doprnt): Remove.
7783 * Makefile.in (base_obj): Remove doprnt.o.
7784 * deps.mk (doprnt.o): Remove.
7785
5fdb398c
PE
7786 error: Print 32- and 64-bit integers portably (Bug#8435).
7787 Without this change, on typical 64-bit hosts error ("...%d...", N)
7788 was used to print both 32- and 64-bit integers N, which relied on
7789 undefined behavior.
61bdb816 7790 * lisp.h, m/amdx86-64.h, m/ia64.h, m/ibms390x.h (pEd): New macro.
5fdb398c
PE
7791 * lisp.h (error, verror): Mark as printf-like functions.
7792 * eval.c (verror): Use vsnprintf, not doprnt, to do the real work.
7793 Report overflow in size calculations when allocating printf buffer.
7794 Do not truncate output string at its first null byte.
7795 * xdisp.c (vmessage): Use vsnprintf, not doprnt, to do the real work.
7796 Truncate the output at a character boundary, since vsnprintf does not
7797 do that.
7798 * charset.c (check_iso_charset_parameter): Convert internal
7799 character to string before calling 'error', since %c now has the
7800 printf meaning.
7801 * coding.c (Fdecode_sjis_char, Fdecode_big5_char): Avoid int
7802 overflow when computing char to be passed to 'error'. Do not
7803 pass Lisp_Object to 'error'; pass the integer instead.
7804 * nsfns.m (Fns_do_applescript): Use int, not long, since it's
7805 formatted with plain %d.
7806
b189fa66
PE
7807 * eval.c (internal_lisp_condition_case): Don't pass spurious arg.
7808
bff87ef0
PE
7809 * keyboard.c (access_keymap_keyremap): Print func name, not garbage.
7810
7e2cac20
PE
7811 * coding.c (Fdecode_sjis_char): Don't assume CODE fits in int.
7812
ce4d90b5
PE
7813 * xterm.c (x_catch_errors): Remove duplicate declaration.
7814
266c9547
PE
7815 * term.c (maybe_fatal): Mark its 3rd arg as a printf format, too.
7816
79c49ad2
PE
7817 * xdisp.c, lisp.h (message_nolog): Remove; unused.
7818
368f4090
JM
78192011-04-10 Jim Meyering <meyering@redhat.com>
7820
7821 use ssize_t and size_t for read- and write-like emacs_gnutls_* functions
7822 * gnutls.c (emacs_gnutls_read): Adjust signature to be more read-like:
7823 return ssize_t not "int", and use size_t as the buffer length.
7824 (emacs_gnutls_write): Likewise, and make the buffer pointer "const".
7825 * gnutls.h: Update declarations.
7826 * process.c (read_process_output): Use ssize_t, to match.
7827 (send_process): Likewise.
7828
a32d4040
CY
78292011-04-09 Chong Yidong <cyd@stupidchicken.com>
7830
7831 * image.c (Fimagemagick_types): Doc fix, and comment cleanup.
7832
8546720e 78332011-04-09 Chong Yidong <cyd@stupidchicken.com>
aac0c6e3 7834
04f2d78b
CB
7835 * ftfont.c (get_adstyle_property, ftfont_pattern_entity):
7836 Use unsigned char, to match FcChar8 type definition.
aac0c6e3 7837
8546720e
GM
7838 * xterm.c (handle_one_xevent):
7839 * xmenu.c (create_and_show_popup_menu):
7840 * xselect.c (x_decline_selection_request)
7841 (x_reply_selection_request): Avoid type-punned deref of X events.
aac0c6e3 7842
0a2f5c1a 78432011-04-09 Eli Zaretskii <eliz@gnu.org>
a53e2e89
EZ
7844
7845 Fix some uses of `int' instead of EMACS_INT.
7846 * search.c (string_match_1, fast_string_match)
7847 (fast_c_string_match_ignore_case, fast_string_match_ignore_case)
7848 (scan_buffer, find_next_newline_no_quit)
7849 (find_before_next_newline, search_command, Freplace_match)
7850 (Fmatch_data): Make some `int' variables be EMACS_INT.
7851
7852 * xdisp.c (display_count_lines): 3rd argument and return value now
7853 EMACS_INT. All callers changed.
7854 (pint2hrstr): Last argument is now EMACS_INT.
7855
7856 * coding.c (detect_coding_utf_8, detect_coding_emacs_mule)
7857 (detect_coding_iso_2022, detect_coding_sjis, detect_coding_big5)
7858 (detect_coding_ccl, detect_coding_charset, decode_coding_utf_8)
7859 (decode_coding_utf_16, decode_coding_emacs_mule)
7860 (decode_coding_iso_2022, decode_coding_sjis, decode_coding_big5)
7861 (decode_coding_ccl, decode_coding_charset)
7862 <consumed_chars, consumed_chars_base>: Declare EMACS_INT.
7863 (decode_coding_iso_2022, decode_coding_emacs_mule)
7864 (decode_coding_sjis, decode_coding_big5, decode_coding_charset)
7865 <char_offset, last_offset>: Declare EMACS_INT.
7866 (encode_coding_utf_8, encode_coding_utf_16)
7867 (encode_coding_emacs_mule, encode_invocation_designation)
7868 (encode_designation_at_bol, encode_coding_iso_2022)
7869 (encode_coding_sjis, encode_coding_big5, encode_coding_ccl)
7870 (encode_coding_raw_text, encode_coding_charset) <produced_chars>:
7871 Declare EMACS_INT.
7872 (ASSURE_DESTINATION): Declare more_bytes EMACS_INT.
7873 (encode_invocation_designation): Last argument P_NCHARS is now
7874 EMACS_INT.
7875 (decode_eol): Declare pos_byte, pos, and pos_end EMACS_INT.
7876 (produce_chars): from_nchars and to_nchars are now EMACS_INT.
7877
7878 * coding.h (struct coding_system) <head_ascii>: Declare EMACS_INT.
7879 All users changed.
7880
7881 * ccl.c (Fccl_execute_on_string): Declare some variables
7882 EMACS_INT.
7883
8546720e 78842011-04-08 Samuel Thibault <sthibault@debian.org> (tiny change)
0080dc6b
SS
7885
7886 * term.c (init_tty): Fix incorrect ifdef placement (Bug#8450).
7887
4e19a977
CS
78882011-03-19 Christoph Scholtes <cschol2112@googlemail.com>
7889
7890 * process.c (Fformat_network_address): Doc fix.
7891
87302331
R
78922011-04-08 T.V. Raman <tv.raman.tv@gmail.com> (tiny change)
7893
ee7683eb 7894 * xml.c (parse_region): Avoid creating spurious whitespace nodes.
87302331 7895
cbb59342
CY
78962011-04-08 Chong Yidong <cyd@stupidchicken.com>
7897
7898 * keyboard.c (read_char): Call Lisp function help-form-show,
7899 instead of using internal_with_output_to_temp_buffer.
7900 (Qhelp_form_show): New var.
e0d38eeb 7901 (syms_of_keyboard): Use DEFSYM macro.
cbb59342
CY
7902
7903 * print.c (internal_with_output_to_temp_buffer): Function deleted.
7904
7905 * lisp.h (internal_with_output_to_temp_buffer): Remove prototype.
7906
e67a13ab
CY
79072011-04-06 Chong Yidong <cyd@stupidchicken.com>
7908
04f2d78b
CB
7909 * process.c (Flist_processes): Remove to Lisp.
7910 (list_processes_1): Delete.
e67a13ab 7911
973f782d
EZ
79122011-04-06 Eli Zaretskii <eliz@gnu.org>
7913
7c106b1e
EZ
7914 * msdos.c (careadlinkat, careadlinkatcwd): MS-DOS replacements.
7915
973f782d
EZ
7916 * w32.c (careadlinkat, careadlinkatcwd): New always-fail stubs.
7917
41cf7d1a 79182011-04-06 Paul Eggert <eggert@cs.ucla.edu>
27ccc379 7919
ca23cc88
PE
7920 Fix more problems found by GCC 4.6.0's static checks.
7921
f390e2d5
PE
7922 * xmenu.c (Fx_popup_dialog): Don't assume string is free of formats.
7923
42eea0d0
PE
7924 * menu.c (Fx_popup_menu): Don't assume error_name lacks printf formats.
7925
b69769da 7926 * lisp.h (message, message_nolog, fatal): Mark as printf-like.
1e973bc7 7927
f9541e84
PE
7928 * xdisp.c (vmessage): Mark as a printf-like function.
7929
13841b55
PE
7930 * term.c (vfatal, maybe_fatal): Mark as printf-like functions.
7931
c136c10f
PE
7932 * sound.c (sound_warning): Don't crash if arg contains a printf format.
7933
5e2d4a30
PE
7934 * image.c (tiff_error_handler, tiff_warning_handler): Mark as
7935 printf-like functions.
7936 (tiff_load): Add casts to remove these marks before passing them
7937 to system-supplied API.
7938
583f48b9
PE
7939 * eval.c (Fsignal): Remove excess argument to 'fatal'.
7940
b25d760e
PE
7941 * coding.c (EMIT_ONE_BYTE, EMIT_TWO_BYTES): Use unsigned, not int.
7942 This avoids several warnings with gcc -Wstrict-overflow.
d5efd1d1
PE
7943 (DECODE_COMPOSITION_RULE): If the rule is invalid, goto invalid_code
7944 directly, rather than having caller test rule sign. This avoids
7945 some unnecessary tests.
7946 * composite.h (COMPOSITION_ENCODE_RULE_VALID): New macro.
7947 (COMPOSITION_ENCODE_RULE): Arguments now must be valid. This
7948 affects only one use, in DECODE_COMPOSITION_RULE, which is changed.
b25d760e 7949
bc7b6697 7950 * xfont.c (xfont_text_extents): Remove var that was set but not used.
625a3eb1 7951 (xfont_open): Avoid unnecessary tests.
bc7b6697 7952
27ccc379
PE
7953 * composite.c (composition_gstring_put_cache): Use unsigned integer.
7954
dcd5c89a
PE
7955 * composite.h, composite.c (composition_gstring_put_cache):
7956 Use EMACS_INT, not int, for length.
7957
b13a45c6
PE
7958 * composite.h (COMPOSITION_DECODE_REFS): New macro,
7959 breaking out part of COMPOSITION_DECODE_RULE.
7960 (COMPOSITION_DECODE_RULE): Use it.
7961 * composite.c (get_composition_id): Remove unused local vars,
7962 by using the new macro.
7963
1e792e4d
PE
7964 * textprop.c (set_text_properties_1): Change while to do-while,
7965 since the condition is always true at first.
7966
dc6c6455 7967 * intervals.c (graft_intervals_into_buffer): Mark var as used.
aa86731f
PE
7968 (interval_deletion_adjustment): Return unsigned value.
7969 All uses changed.
dc6c6455 7970
aba7731a
PE
7971 * process.c (list_processes_1, create_pty, read_process_output):
7972 (exec_sentinel): Remove vars that were set but not used.
afd4052b 7973 (create_pty): Remove unnecessary "volatile"s.
bc57d757 7974 (Fnetwork_interface_info): Avoid possibility of int overflow.
82eaa333 7975 (read_process_output): Do adaptive read buffering even if carryover.
fe07cdfa 7976 (read_process_output): Simplify nbytes computation if buffered.
aba7731a 7977
fdfc4bf3
PE
7978 * bytecode.c (exec_byte_code): Rename local to avoid shadowing.
7979
fca8fe46 7980 * syntax.c (scan_words): Remove var that was set but not used.
12cbf13f 7981 (update_syntax_table): Use unsigned instead of int.
fca8fe46 7982
06a0259a 7983 * lread.c (lisp_file_lexically_bound_p): Use ints rather than endptrs.
3c346cc3 7984 (lisp_file_lexically_bound_p, read1): Use unsigned instead of int.
e6eb4e9e 7985 (safe_to_load_p): Make the end-of-loop test the inverse of the in-loop.
06a0259a 7986
e7b9e80f
PE
7987 * print.c (print_error_message): Avoid int overflow.
7988
56201685
PE
7989 * font.c (font_list_entities): Redo for clarity,
7990 so that reader need not know FONT_DPI_INDEX + 1 == FONT_SPACING_INDEX.
7991
78834453 7992 * font.c (font_find_for_lface, Ffont_get_glyphs): Remove unused vars.
790771b1 7993 (font_score): Avoid potential overflow in diff calculation.
78834453 7994
0bc0b309 7995 * fns.c (substring_both): Remove var that is set but not used.
8cd55cb4 7996 (sxhash): Redo loop for clarity and to avoid wraparound warning.
0bc0b309 7997
e610eaca
PE
7998 * eval.c (funcall_lambda): Rename local to avoid shadowing.
7999
b895abce
PE
8000 * alloc.c (mark_object_loop_halt, mark_object): Use size_t, not int.
8001 Otherwise, GCC 4.6.0 optimizes the loop check away since the check
8002 can always succeed if overflow has undefined behavior.
8003
1f1d9321 8004 * search.c (boyer_moore, wordify): Remove vars set but not used.
6f076cc7 8005 (wordify): Omit three unnecessary tests.
1f1d9321 8006
c59478bc
PE
8007 * indent.c (MULTIBYTE_BYTES_WIDTH): Don't compute wide_column.
8008 All callers changed. This avoids the need for an unused var.
8009
79b73827
PE
8010 * casefiddle.c (casify_region): Remove var that is set but not used.
8011
a4db5dfe
PE
8012 * dired.c (file_name_completion): Remove var that is set but not used.
8013
43aae36e
PE
8014 * fileio.c (Finsert_file_contents): Make EOF condition clearer.
8015
2a47c44d 8016 * fileio.c (Finsert_file_contents): Avoid signed integer overflow.
163c5f32 8017 (Finsert_file_contents): Remove unnecessary code checking fd.
2a47c44d 8018
a37c69bf
PE
8019 * minibuf.c (read_minibuf_noninteractive): Use size_t for sizes.
8020 Check for integer overflow on size calculations.
8021
328ab8e7
PE
8022 * buffer.c (Fprevious_overlay_change): Remove var that is set
8023 but not used.
8024
e5a2a5cb
PE
8025 * keyboard.c (menu_bar_items, read_char_minibuf_menu_prompt):
8026 Remove vars that are set but not used.
8d84a6eb 8027 (timer_check_2): Don't assume timer-list and idle-timer-list are lists.
6b043475 8028 (timer_check_2): Mark vars as initialized.
e5a2a5cb 8029
a60e5f68
PE
8030 * gtkutil.c (xg_get_file_with_chooser): Mark var as initialized.
8031
f661cb61 8032 * image.c (lookup_image): Remove var that is set but not used.
35fa624f 8033 (xbm_load): Use parse_p, for gcc -Werror=unused-but-set-variable.
f661cb61 8034
f0397f5a
PE
8035 * fontset.c (Finternal_char_font, Ffontset_info): Remove vars
8036 that are set but not used.
8037
8664db06 8038 * xfns.c (make_invisible_cursor): Don't return garbage
03733ee7 8039 if XCreateBitmapFromData fails (Bug#8410).
8664db06 8040
6abdaa4a
PE
8041 * xselect.c (x_get_local_selection, x_handle_property_notify):
8042 Remove vars that are set but not used.
8043
0ce7538d 8044 * xfns.c (x_create_tip_frame): Remove var that is set but not used.
6abdaa4a 8045 (make_invisible_cursor): Initialize a possibly-uninitialized variable.
0ce7538d 8046
9ae848fc
PE
8047 * xterm.c (x_scroll_bar_to_input_event) [!USE_GTK]:
8048 Remove var that is set but not used.
0b918413
PE
8049 (scroll_bar_windows_size): Now size_t, not int.
8050 (x_send_scroll_bar_event): Use size_t, not int, for sizes.
8051 Check for overflow.
9ae848fc 8052
a5a62657
PE
8053 * xfaces.c (realize_named_face): Remove vars that are set but not used.
8054 (map_tty_color) [!defined MSDOS]: Likewise.
8055
5c5cdd39
PE
8056 * term.c (tty_write_glyphs): Use size_t; this avoids overflow warning.
8057
66ebf983
PE
8058 * coding.c: Remove vars that are set but not used.
8059 (DECODE_COMPOSITION_RULE): Remove 2nd arg, which is unused.
8060 All callers changed.
8061 (decode_coding_utf_8, decode_coding_utf_16 decode_coding_emacs_mule):
8062 (decode_coding_iso_2022, encode_coding_sjis, encode_coding_big5):
8063 (decode_coding_charset): Remove vars that are set but not used.
8064
1be4d761
PE
8065 * bytecode.c (Fbyte_code) [!defined BYTE_CODE_SAFE]: Remove var
8066 that is set but not used.
8067
47553fa8
PE
8068 * print.c (print_object): Remove var that is set but not used.
8069
1f7196bf 8070 Replace 2 copies of readlink code with 1 gnulib version (Bug#8401).
d1fdcab7
PE
8071 The gnulib version avoids calling malloc in the usual case,
8072 and on 64-bit hosts doesn't have some arbitrary 32-bit limits.
8073 * fileio.c (Ffile_symlink_p): Use emacs_readlink.
8074 * filelock.c (current_lock_owner): Likewise.
8075 * lisp.h (READLINK_BUFSIZE, emacs_readlink): New function.
8076 * sysdep.c: Include allocator.h, careadlinkat.h.
8077 (emacs_no_realloc_allocator): New static constant.
8078 (emacs_readlink): New function.
fdb61804
PE
8079 * deps.mk (sysdep.o): Depend on ../lib/allocator.h and on
8080 ../lib/careadlinkat.h.
d1fdcab7 8081
f84c17c7
SM
80822011-04-04 Stefan Monnier <monnier@iro.umontreal.ca>
8083
8084 * keyboard.c (safe_run_hook_funcall): Fix last change (don't stop at the
8085 first non-nil return value).
8086
ef3862ad
JD
80872011-04-03 Jan Djärv <jan.h.d@swipnet.se>
8088
8089 * nsterm.m (ns_update_auto_hide_menu_bar): Define MAC_OS_X_VERSION_10_6
8090 if not defined (Bug#8403).
8091
376a7006
JB
80922011-04-02 Juanma Barranquero <lekktu@gmail.com>
8093
8094 * xdisp.c (display_count_lines): Remove parameter `start',
8095 unused since 1998-01-01T02:27:27Z!rms@gnu.org. All callers changed.
8096 (get_char_face_and_encoding): Remove parameter `multibyte_p',
8097 unused since 2008-05-14T01:40:23Z!handa@m17n.org. All callers changed.
8098 (fill_stretch_glyph_string): Remove parameters `row' and `area',
8099 unused at least since Kim's GUI unification at 2003-03-16T20:45:46Z!storm@cua.dk
8100 and thereabouts. All callers changed.
8101 (get_per_char_metric): Remove parameter `f', unused since
8102 2008-05-14T01:40:23Z!handa@m17n.org. All callers changed.
8103
6ca3801d
JM
81042011-04-02 Jim Meyering <meyering@redhat.com>
8105
8106 do not dereference NULL upon failed strdup
8107 * nsfont.m (ns_descriptor_to_entity): Use xstrdup, not strdup.
8108 (ns_get_family): Likewise.
8109
d8e2b5ba
JB
81102011-04-02 Juanma Barranquero <lekktu@gmail.com>
8111
8112 * eval.c (unwind_to_catch) [DEBUG_GCPRO]: Remove redundant assignment.
8113
8c74fcbd
JD
81142011-04-02 Jan Djärv <jan.h.d@swipnet.se>
8115
8116 * nsterm.m (ns_update_auto_hide_menu_bar): Only for OSX 10.6 or
8117 later (Bug#8403).
8118
7200d79c
SM
81192011-04-01 Stefan Monnier <monnier@iro.umontreal.ca>
8120
03408648 8121 Add lexical binding.
7200d79c 8122
03408648
SM
8123 * window.c (Ftemp_output_buffer_show): New fun.
8124 (Fsave_window_excursion):
8125 * print.c (Fwith_output_to_temp_buffer): Move to subr.el.
8126
8127 * lread.c (lisp_file_lexically_bound_p): New function.
8128 (Fload): Bind Qlexical_binding.
8129 (readevalloop): Remove `evalfun' arg.
8130 Bind Qinternal_interpreter_environment.
8131 (Feval_buffer): Bind Qlexical_binding.
8132 (defvar_int, defvar_bool, defvar_lisp_nopro, defvar_kboard):
8133 Mark as dynamic.
8134 (syms_of_lread): Declare `lexical-binding'.
8135
8136 * lisp.h (struct Lisp_Symbol): New field `declared_special'.
8137
8138 * keyboard.c (eval_dyn): New fun.
8139 (menu_item_eval_property): Use it.
ca105506
SM
8140
8141 * image.c (parse_image_spec): Use Ffunctionp.
ca105506 8142
03408648
SM
8143 * fns.c (concat, mapcar1): Accept byte-code-functions.
8144
8145 * eval.c (Fsetq): Handle lexical vars.
8146 (Fdefun, Fdefmacro, Ffunction): Make closures when needed.
8147 (Fdefconst, Fdefvaralias, Fdefvar): Mark as dynamic.
8148 (FletX, Flet): Obey lexical binding.
8149 (Fcommandp): Handle closures.
8150 (Feval): New `lexical' arg.
8151 (eval_sub): New function extracted from Feval. Use it almost
8152 everywhere where Feval was used. Look up vars in lexical env.
8153 Handle closures.
8154 (Ffunctionp): Move from subr.el.
8155 (Ffuncall): Handle closures.
8156 (apply_lambda): Remove `eval_flags'.
8157 (funcall_lambda): Handle closures and new byte-code-functions.
8158 (Fspecial_variable_p): New function.
8159 (syms_of_eval): Initialize the Vinternal_interpreter_environment var,
8160 but without exporting it to Lisp.
23aba0ea 8161
23aba0ea 8162 * doc.c (Fdocumentation, store_function_docstring):
03408648 8163 * data.c (Finteractive_form): Handle closures.
23aba0ea 8164
03408648
SM
8165 * callint.c (Fcall_interactively): Preserve lexical-binding mode for
8166 interactive spec.
ba83908c 8167
04f2d78b
CB
8168 * bytecode.c (Bstack_ref, Bstack_set, Bstack_set2, BdiscardN):
8169 New byte-codes.
03408648
SM
8170 (exec_byte_code): New function extracted from Fbyte_code to handle new
8171 calling convention for byte-code-functions. Add new byte-codes.
ba83908c 8172
03408648 8173 * buffer.c (defvar_per_buffer): Set new `declared_special' field.
e2abe5a1 8174
03408648 8175 * alloc.c (Fmake_symbol): Init new `declared_special' field.
e2abe5a1 8176
e2abce01
JB
81772011-03-31 Juanma Barranquero <lekktu@gmail.com>
8178
8179 * xdisp.c (redisplay_internal): Fix prototype.
8180
63696a73 81812011-03-31 Eli Zaretskii <eliz@gnu.org>
09725d26 8182
63696a73 8183 * xdisp.c (SCROLL_LIMIT): New macro.
04f2d78b
CB
8184 (try_scrolling): Use it when setting scroll_limit.
8185 Limit scrolling to 100 screen lines.
63696a73
EZ
8186 (redisplay_window): Even when falling back on "recentering",
8187 position point in the window according to scroll-conservatively,
8188 scroll-margin, and scroll-*-aggressively variables. (Bug#6671)
8189
8190 (try_scrolling): When point is above the window, allow searching
8191 as far as scroll_max, or one screenful, to compute vertical
8192 distance from PT to the scroll margin position. This prevents
8193 try_scrolling from unnecessarily failing when
8194 scroll-conservatively is set to a value slightly larger than the
8195 window height. Clean up the case of PT below the margin at bottom
8196 of window: scroll_max can no longer be INT_MAX. When aggressive
8197 scrolling is in use, don't let point enter the opposite scroll
8198 margin as result of the scroll.
8199 (syms_of_xdisp) <scroll-conservatively>: Document the
09725d26
EZ
8200 threshold of 100 lines for never-recentering scrolling.
8201
e4cc2dfc
JB
82022011-03-31 Juanma Barranquero <lekktu@gmail.com>
8203
8204 * dispextern.h (move_it_by_lines):
8205 * xdisp.c (move_it_by_lines): Remove parameter `need_y_p', unused
8206 since 2000-12-29T14:24:09Z!gerd@gnu.org. All callers changed.
8207 (message_log_check_duplicate): Remove parameters `prev_bol' and
8208 `this_bol', unused since 1998-01-01T02:27:27Z!rms@gnu.org. All callers changed.
8209 (redisplay_internal): Remove parameter `preserve_echo_area',
8210 unused since 1999-07-21T21:43:52Z!gerd@gnu.org. All callers changed.
8211
8212 * indent.c (Fvertical_motion):
8213 * window.c (window_scroll_pixel_based, Frecenter):
8214 Don't pass `need_y_p' to `move_it_by_lines'.
8215
1c470562
SM
82162011-03-30 Stefan Monnier <monnier@iro.umontreal.ca>
8217
44f230aa
SM
8218 * eval.c (struct backtrace): Don't cheat with negative numbers, but do
8219 steal a few bits to be more compact.
8220 (interactive_p, Fbacktrace, Fbacktrace_frame, mark_backtrace):
8221 Remove unneeded casts.
8222
1c470562
SM
8223 * bytecode.c (Fbyte_code): CAR and CDR can GC.
8224
888adce9
ZK
82252011-03-30 Zachary Kanfer <zkanfer@gmail.com> (tiny change)
8226
8227 * keyboard.c (Fexecute_extended_command): Do log the "suggest key
8228 binding" message (bug#7967).
8229
f838ed7b
PE
82302011-03-30 Paul Eggert <eggert@cs.ucla.edu>
8231
77861b95
PE
8232 Fix more problems found by GCC 4.6.0's static checks.
8233
de6dbc14
PE
8234 * unexelf.c (unexec) [! (defined _SYSTYPE_SYSV || defined __sgi)]:
8235 Remove unused local var.
8236
f838ed7b
PE
8237 * editfns.c (Fmessage_box): Remove unused local var.
8238
792c7b2b
PE
8239 * xdisp.c (try_window_reusing_current_matrix, x_produce_glyphs):
8240 (note_mode_line_or_margin_highlight, note_mouse_highlight):
8241 Omit unused local vars.
c499e557 8242 * window.c (shrink_windows): Omit unused local var.
b01a1c29 8243 * menu.c (digest_single_submenu): Omit unused local var.
0bc32927
PE
8244 * dispnew.c (update_window) [PERIODIC_PREEMPTION_CHECKING]:
8245 Omit unused local var.
8246
ba0165e1
PE
8247 * keyboard.c (parse_modifiers_uncached, parse_modifiers):
8248 Don't assume string length fits in int.
32ad8845 8249 (keyremap_step, read_key_sequence): Use size_t for sizes.
48011560 8250 (read_key_sequence): Don't check last_real_key_start redundantly.
ba0165e1 8251
3c59b4c9
PE
8252 * callproc.c (Fcall_process, Fcall_process_region): Use SAFE_ALLOCA
8253 instead of alloca (Bug#8344).
8254
a3eed478 8255 * eval.c (Fbacktrace): Don't assume nargs fits in int.
5d5d959d 8256 (Fbacktrace_frame): Don't assume nframes fits in int.
a3eed478 8257
eb4d412d
PE
8258 * syntax.c (scan_sexps_forward): Avoid pointer wraparound.
8259
1658b401
PE
8260 * xterm.c (x_make_frame_visible, same_x_server): Redo to avoid overflow
8261 concerns.
8262
8263 * term.c (produce_glyphless_glyph): Remove unnecessary test.
8264
8265 * cm.c (calccost): Turn while-do into do-while, for clarity.
44f730c8 8266
9a2c6e05
PE
8267 * keyboard.c (syms_of_keyboard): Use the same style as later
8268 in this function when indexing through an array. This also
8269 works around GCC bug 48267.
8270
03d0a109
PE
8271 * image.c (tiff_load): Fix off-by-one image count (Bug#8336).
8272
44f730c8
PE
8273 * xselect.c (x_check_property_data): Return correct size (Bug#8335).
8274
fe75f926
PE
8275 * chartab.c (sub_char_table_ref_and_range): Redo for slight
8276 efficiency gain, and to bypass a gcc -Wstrict-overflow warning.
8277
ffa8c828
PE
8278 * keyboard.c, keyboard.h (num_input_events): Now size_t.
8279 This avoids undefined behavior on integer overflow, and is a bit
8280 more convenient anyway since it is compared to a size_t variable.
8281
c5101a77
PE
8282 Variadic C functions now count arguments with size_t, not int.
8283 This avoids an unnecessary limitation on 64-bit machines, which
8284 caused (substring ...) to crash on large vectors (Bug#8344).
8285 * lisp.h (struct Lisp_Subr.function.aMANY): Now takes size_t, not int.
8286 (DEFUN_ARGS_MANY, internal_condition_case_n, safe_call): Likewise.
77861b95 8287 All variadic functions and their callers changed accordingly.
c5101a77
PE
8288 (struct gcpro.nvars): Now size_t, not int. All uses changed.
8289 * data.c (arith_driver, float_arith_driver): Likewise.
8290 * editfns.c (general_insert_function): Likewise.
8291 * eval.c (struct backtrace.nargs, interactive_p)
8292 (internal_condition_case_n, run_hook_with_args, apply_lambda)
8293 (funcall_lambda, mark_backtrace): Likewise.
8294 * fns.c (concat): Likewise.
8295 * frame.c (x_set_frame_parameters): Likewise.
8296 * fns.c (get_key_arg): Now accepts and returns size_t, and returns
8297 0 if not found, not -1. All callers changed.
8298
dd3f25f7
PE
8299 * alloc.c (garbage_collect): Don't assume stack size fits in int.
8300 (stack_copy_size): Now size_t, not int.
8301 (stack_copy, stack_copy_size): Define only if MAX_SAVE_STACK > 0.
8302
461c2ab9
JB
83032011-03-28 Juanma Barranquero <lekktu@gmail.com>
8304
8305 * coding.c (encode_designation_at_bol): Remove parameter `charbuf_end',
8306 unused since 2002-03-01T01:17:24Z!handa@m17n.org and 2008-02-01T16:01:31Z!miles@gnu.org.
8307 All callers changed.
8308
8309 * lisp.h (multibyte_char_to_unibyte):
8310 * character.c (multibyte_char_to_unibyte): Remove parameter `rev_tbl',
8311 unused since 2002-03-01T01:16:34Z!handa@m17n.org and 2008-02-01T16:01:31Z!miles@gnu.org.
8312 * character.h (CHAR_TO_BYTE8):
8313 * cmds.c (internal_self_insert):
8314 * editfns.c (general_insert_function):
8315 * keymap.c (push_key_description):
8316 * search.c (Freplace_match):
8317 * xdisp.c (message_dolog, set_message_1): All callers changed.
8318
f6d62986
SM
83192011-03-28 Stefan Monnier <monnier@iro.umontreal.ca>
8320
8321 * keyboard.c (safe_run_hook_funcall): New function.
8322 (safe_run_hooks_1, safe_run_hooks_error, safe_run_hooks): On error,
8323 don't set the hook to nil, but remove the offending function instead.
8324 (Qcommand_hook_internal): Remove, unused.
8325 (syms_of_keyboard): Don't initialize Qcommand_hook_internal nor define
8326 Vcommand_hook_internal.
8327
8328 * eval.c (enum run_hooks_condition): Remove.
8329 (funcall_nil, funcall_not): New functions.
8330 (run_hook_with_args): Call each function through a `funcall' argument.
8331 Remove `cond' argument, now redundant.
8332 (Frun_hooks, Frun_hook_with_args, Frun_hook_with_args_until_success)
8333 (Frun_hook_with_args_until_failure): Adjust accordingly.
8334 (run_hook_wrapped_funcall, Frun_hook_wrapped): New functions.
8335
1db5b1ad
JB
83362011-03-28 Juanma Barranquero <lekktu@gmail.com>
8337
8338 * dispextern.h (string_buffer_position): Remove declaration.
8339
8340 * print.c (strout): Remove parameter `multibyte', unused since
8341 1999-08-21T19:30:21Z!gerd@gnu.org. All callers changed.
8342
8343 * search.c (boyer_moore): Remove parameters `len', `pos' and `lim',
8344 never used since function introduction in 1998-02-08T21:33:56Z!rms@gnu.org.
8345 All callers changed.
8346
8347 * w32.c (_wsa_errlist): Use braces for struct initializers.
8348
8349 * xdisp.c (string_buffer_position_lim): Remove parameter `w',
8350 never used since function introduction in 2001-03-09T18:41:50Z!gerd@gnu.org.
8351 All callers changed.
8352 (string_buffer_position): Likewise. Also, make static (it's never
8353 used outside xdisp.c).
8354 (cursor_row_p): Remove parameter `w', unused since
8355 2000-10-17T16:08:57Z!gerd@gnu.org. All callers changed.
8356 (decode_mode_spec): Remove parameter `precision', introduced during
8357 Gerd Moellmann's rewrite at 1999-07-21T21:43:52Z!gerd@gnu.org, but never used.
8358 All callers changed.
8359
5ffb62aa
JD
83602011-03-27 Jan Djärv <jan.h.d@swipnet.se>
8361
8362 * nsterm.m (syms_of_nsterm): Use doc: for ns-auto-hide-menu-bar.
8363
461c2ab9 83642011-03-27 Anders Lindgren <andlind@gmail.com>
f0a1382a
JD
8365
8366 * nsterm.m (ns_menu_bar_is_hidden): New variable.
8367 (ns_constrain_all_frames, ns_menu_bar_should_be_hidden)
8368 (ns_update_auto_hide_menu_bar): New functions.
8369 (ns_update_begin): Call ns_update_auto_hide_menu_bar.
8370 (applicationDidBecomeActive): Call ns_update_auto_hide_menu_bar and
8371 ns_constrain_all_frames.
8372 (constrainFrameRect): Return at once if ns_menu_bar_should_be_hidden.
8373 (syms_of_nsterm): DEFVAR ns-auto-hide-menu-bar, init to Qnil.
8374
5c380ffb
JD
83752011-03-27 Jan Djärv <jan.h.d@swipnet.se>
8376
8377 * nsmenu.m (runDialogAt): Remove argument to timer_check.
8378
9af30bdf
GM
83792011-03-27 Glenn Morris <rgm@gnu.org>
8380
8381 * syssignal.h: Replace RETSIGTYPE with void.
8382 * atimer.c, data.c, dispnew.c, emacs.c, floatfns.c, keyboard.c:
8383 * keyboard.h, lisp.h, process.c, sysdep.c, xterm.c:
8384 Replace SIGTYPE with void everywhere.
8385 * s/usg5-4-common.h (SIGTYPE): Remove definition.
8386 * s/template.h (SIGTYPE): Remove commented out definition.
8387
e2abce01
JB
83882011-03-26 Eli Zaretskii <eliz@gnu.org>
8389
8390 * xdisp.c (redisplay_window): Don't check buffer's clip_changed
8391 flag as a prerequisite for invoking try_scrolling. (Bug#6671)
8392
f868cd8a
JB
83932011-03-26 Juanma Barranquero <lekktu@gmail.com>
8394
59eb0929
JB
8395 * w32.c (read_unc_volume): Use parameter `henum', instead of
8396 global variable `wget_enum_handle'.
8397
8398 * keymap.c (describe_vector): Remove parameters `indices' and
8399 `char_table_depth', unused since 2002-03-01T01:43:26Z!handa@m17n.org.
8400 (describe_map, Fdescribe_vector): Adjust calls to `describe_vector'.
8401
f868cd8a
JB
8402 * keyboard.h (timer_check, show_help_echo): Remove unused parameters.
8403
8404 * keyboard.c (timer_check): Remove parameter `do_it_now',
8405 unused since 1996-04-12T06:01:29Z!rms@gnu.org.
8406 (show_help_echo): Remove parameter `ok_to_overwrite_keystroke_echo',
8407 unused since 2008-04-19T19:30:53Z!monnier@iro.umontreal.ca.
8408
8409 * keyboard.c (read_char):
8410 * w32menu.c (w32_menu_display_help):
8411 * xmenu.c (show_help_event, menu_help_callback):
8412 Adjust calls to `show_help_echo'.
8413
8414 * gtkutil.c (xg_maybe_add_timer):
8415 * keyboard.c (readable_events):
8416 * process.c (wait_reading_process_output):
8417 * xmenu.c (x_menu_wait_for_event): Adjust calls to `timer_check'.
8418
8419 * insdel.c (adjust_markers_gap_motion):
8420 Remove; no-op since 1998-01-02T21:29:48Z!rms@gnu.org.
8421 (gap_left, gap_right): Don't call it.
8422
2ecf6fdb
CY
84232011-03-25 Chong Yidong <cyd@stupidchicken.com>
8424
8425 * xdisp.c (handle_fontified_prop): Discard changes to clip_changed
8426 incurred during fontification.
8427
6b1f9ba4
JB
84282011-03-25 Juanma Barranquero <lekktu@gmail.com>
8429
8430 * buffer.c (defvar_per_buffer): Remove unused parameter `doc'.
8431 (DEFVAR_PER_BUFFER): Don't pass it.
8432
8433 * dispnew.c (row_equal_p, add_row_entry): Remove unused parameter `w'.
8434 (scrolling_window): Don't pass it.
8435
0f4a96b5
JB
84362011-03-25 Juanma Barranquero <lekktu@gmail.com>
8437
8438 * dispextern.h (glyph_matric): Use #if GLYPH_DEBUG, not #ifdef.
8439
8440 * fileio.c (check_executable) [DOS_NT]: Remove unused variables `len'
8441 and `suffix'.
8442 (Fset_file_selinux_context) [HAVE_LIBSELINUX]: Move here declaration
8443 of variables specific to SELinux and computation of `encoded_absname'.
8444
8445 * image.c (XPutPixel): Remove unused variable `height'.
8446
8447 * keyboard.c (make_lispy_event): Remove unused variable `hpos'.
8448
8449 * unexw32.c (get_section_info): Remove unused variable `section'.
8450
8451 * w32.c (stat): Remove unused variables `drive_root' and `devtype'.
8452 (system_process_attributes): Remove unused variable `sess'.
8453 (sys_read): Remove unused variable `err'.
8454
8455 * w32fns.c (top): Wrap variables with #if GLYPH_DEBUG, not #ifdef.
8456 (w32_wnd_proc): Remove unused variable `isdead'.
8457 (unwind_create_frame): Use #if GLYPH_DEBUG, not #ifdef.
8458 (Fx_server_max_request_size): Remove unused variable `dpyinfo'.
8459 (x_create_tip_frame): Remove unused variable `tem'.
8460
8461 * w32inevt.c (w32_console_read_socket):
8462 Remove unused variable `no_events'.
8463
8464 * w32term.c (x_draw_composite_glyph_string_foreground):
8465 Remove unused variable `width'.
8466
1149507c
JB
84672011-03-24 Juanma Barranquero <lekktu@gmail.com>
8468
8469 * w32term.c (x_set_glyph_string_clipping):
8470 Don't pass uninitialized region to CombineRgn.
8471
9c88f339
JB
84722011-03-23 Juanma Barranquero <lekktu@gmail.com>
8473
8474 * w32fns.c (x_set_menu_bar_lines): Remove unused variable `olines'.
8475 (w32_wnd_proc): Pass NULL to Windows API, not uninitialized buffer.
8476 (Fx_close_connection): Remove unused variable `i'.
8477
8478 * w32font.c (w32font_draw): Return number of glyphs.
8479 (w32font_open_internal): Remove unused variable `i'.
8480 (w32font_driver): Add missing initializer.
8481
8482 * w32menu.c (utf8to16): Remove unused variable `utf16'.
8483 (fill_in_menu): Remove unused variable `items_added'.
8484
8485 * w32term.c (last_mouse_press_frame): Remove static global variable.
8486 (w32_clip_to_row): Remove unused variable `f'.
8487 (x_delete_terminal): Remove unused variable `i'.
8488
8489 * w32uniscribe.c (uniscribe_shape): Remove unused variable `nclusters'.
8490 (NOTHING): Remove unused static global variable.
8491 (uniscribe_check_otf): Remove unused variable `table'.
8492 (uniscribe_font_driver): Add missing initializers.
8493
dee091a3
JD
84942011-03-23 Julien Danjou <julien@danjou.info>
8495
8496 * term.c (Fsuspend_tty, Fresume_tty):
8497 * minibuf.c (read_minibuf, run_exit_minibuf_hook):
8498 * window.c (temp_output_buffer_show):
8499 * insdel.c (signal_before_change):
8500 * frame.c (Fhandle_switch_frame):
8501 * fileio.c (Fdo_auto_save):
8502 * emacs.c (Fkill_emacs):
8503 * editfns.c (save_excursion_restore):
8504 * cmds.c (internal_self_insert):
8505 * callint.c (Fcall_interactively):
8506 * buffer.c (Fkill_all_local_variables):
8507 * keyboard.c (Fcommand_execute, Fsuspend_emacs, safe_run_hooks_1):
8508 Use Frun_hooks.
0f4a96b5 8509 (command_loop_1): Use Frun_hooks. Call safe_run_hooks
e9fce1ac 8510 unconditionally since it does the check itself.
dee091a3 8511
2c520ab5 85122011-03-23 Paul Eggert <eggert@cs.ucla.edu>
f0641eff 8513
c9c49752
PE
8514 Fix more problems found by GCC 4.5.2's static checks.
8515
8abc3f12
PE
8516 * coding.c (encode_coding_raw_text): Avoid unnecessary test
8517 the first time through the loop, since we know p0 < p1 then.
8518 This also avoids a gcc -Wstrict-overflow warning.
8519
a2d26660
PE
8520 * lisp.h (SAFE_ALLOCA, SAFE_ALLOCA_LISP): Avoid 'int' overflow
8521 leading to a memory leak, possible in functions like
8522 load_charset_map_from_file that can allocate an unbounded number
b12ef411 8523 of objects (Bug#8318).
a2d26660 8524
916c72e9
PE
8525 * xmenu.c (set_frame_menubar): Use EMACS_UINT, not int, for indexes
8526 that could (at least in theory) be that large.
8527
19ab8a18
PE
8528 * xdisp.c (message_log_check_duplicate): Return unsigned long, not int.
8529 This is less likely to overflow, and avoids undefined behavior if
8530 overflow does occur. All callers changed. Use strtoul to scan
8531 for the unsigned long integer.
b7cbbd6f
PE
8532 (pint2hrstr): Simplify and tune code slightly.
8533 This also avoids a (bogus) GCC warning with gcc -Wstrict-overflow.
19ab8a18 8534
f0641eff
PE
8535 * scroll.c (do_scrolling): Work around GCC bug 48228.
8536 See <http://gcc.gnu.org/bugzilla/show_bug.cgi?id=48228>.
8537
7f650bb9
PE
8538 * frame.c (Fmodify_frame_parameters): Simplify loop counter.
8539 This also avoids a warning with gcc -Wstrict-overflow.
39f5e519
PE
8540 (validate_x_resource_name): Simplify count usage.
8541 This also avoids a warning with gcc -Wstrict-overflow.
7f650bb9 8542
37dd57d1
PE
8543 * fileio.c (Fcopy_file): Report error if fchown or fchmod
8544 fail (Bug#8306).
81e56e61 8545
699979fc 8546 * emacs.c (Fdaemon_initialized): Do not ignore I/O errors (Bug#8303).
dc1ca6a8 8547
401bf9b4
PE
8548 * process.c (Fmake_network_process): Use socklen_t, not int,
8549 where POSIX says socklen_t is required in portable programs.
8550 This fixes a porting bug on hosts like 64-bit HP-UX, where
591b2973 8551 socklen_t is wider than int (Bug#8277).
401bf9b4
PE
8552 (Fmake_network_process, server_accept_connection):
8553 (wait_reading_process_output, read_process_output):
8554 Likewise.
8555
b93aacde
PE
8556 * process.c: Rename or move locals to avoid shadowing.
8557 (list_processes_1, Fmake_network_process):
8558 (read_process_output_error_handler, exec_sentinel_error_handler):
8559 Rename or move locals.
4dc343ee 8560 (Fmake_network_process): Define label "retry_connect" only if needed.
0da49335 8561 (Fnetwork_interface_info): Fix pointer signedness.
f990b4e5 8562 (process_send_signal): Add cast to avoid pointer signedness problem.
7b808126 8563 (FIRST_PROC_DESC, IF_NON_BLOCKING_CONNECT): Remove unused macros.
c939f91b 8564 (create_process): Use 'volatile' to avoid vfork clobbering (Bug#8298).
b93aacde 8565
af8a867c 8566 Make tparam.h and terminfo.c consistent.
44f230aa
SM
8567 * cm.c (tputs, tgoto, BC, UP): Remove extern decls.
8568 Include tparam.h instead, since it declares them.
af8a867c
PE
8569 * cm.h (PC): Remove extern decl; tparam.h now does this.
8570 * deps.mk (cm.o, terminfo.o): Depend on tparam.h.
8571 * terminfo.c: Include tparam.h, to check interfaces.
8572 (tparm): Make 1st arg a const pointer in decl. Put it at top level.
8573 (tparam): Adjust signature to match interface in tparam.h;
8574 this removes some undefined behavior. Check that outstring and len
8575 are zero, which they always are with Emacs.
8576 * tparam.h (PC, BC, UP): New extern decls.
8577
0248044d 8578 * xftfont.c (xftfont_shape): Now static, and defined only if needed.
001a7ab4 8579 (xftfont_open): Rename locals to avoid shadowing.
0248044d 8580
8ff096c1 8581 * ftfont.c (ftfont_resolve_generic_family): Fix pointer signedness.
a00924bb
PE
8582 (ftfont_otf_capability, ftfont_shape): Omit decls if not needed.
8583 (OTF_TAG_SYM): Omit macro if not needed.
e932860f 8584 (ftfont_list): Remove unused local.
49eaafba
PE
8585 (get_adstyle_property, ftfont_pattern_entity):
8586 (ftfont_lookup_cache, ftfont_open, ftfont_anchor_point):
8587 Rename locals to avoid shadowing.
8ff096c1 8588
e2be39f6
PE
8589 * xfont.c (xfont_list_family): Mark var as initialized.
8590
c9735e30
PE
8591 * xml.c (make_dom): Now static.
8592
8f5201ae
PE
8593 * composite.c (composition_compute_stop_pos): Rename local to
8594 avoid shadowing.
b246f932
PE
8595 (composition_reseat_it): Remove unused locals.
8596 (find_automatic_composition, composition_adjust_point): Likewise.
80e079b2 8597 (composition_update_it): Mark var as initialized.
11b61122
PE
8598 (find_automatic_composition): Mark vars as initialized,
8599 with a FIXME (Bug#8290).
8f5201ae 8600
760fbc2c
PE
8601 character.h: Rename locals to avoid shadowing.
8602 * character.h (PREV_CHAR_BOUNDARY, FETCH_STRING_CHAR_ADVANCE):
8603 (FETCH_STRING_CHAR_AS_MULTIBYTE_ADVANCE, FETCH_CHAR_ADVANCE):
8604 (FETCH_CHAR_ADVANCE_NO_CHECK, INC_POS, DEC_POS, BUF_INC_POS):
8605 (BUF_DEC_POS): Be more systematic about renaming local temporaries
8606 to avoid shadowing.
8607
ff08eb85
PE
8608 * textprop.c (property_change_between_p): Remove; unused.
8609
fc7bf025
PE
8610 * intervals.c (interval_start_pos): Now static.
8611
235d7abc
PE
8612 * intervals.h (CHECK_TOTAL_LENGTH): Avoid empty "else".
8613
44f230aa
SM
8614 * atimer.c (start_atimer, append_atimer_lists, set_alarm):
8615 Rename locals to avoid shadowing.
3e7d6594 8616
50060332
PE
8617 * sound.c (wav_play, au_play, Fplay_sound_internal):
8618 Fix pointer signedness.
d01f234b 8619 (alsa_choose_format): Remove unused local var.
c83b8872
PE
8620 (wav_play): Initialize a variable to 0, to prevent undefined
8621 behavior (Bug#8278).
50060332 8622
c4fc4e30
PE
8623 * region-cache.c (insert_cache_boundary): Redo var to avoid shadowing.
8624
918436ed
PE
8625 * region-cache.h (pp_cache): New decl, for gcc -Wmissing-prototypes.
8626
c939f91b
PE
8627 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork
8628 clobbering (Bug#8298).
b9c7f648
PE
8629 * sysdep.c (sys_subshell): Likewise.
8630 Previously, the sys_subshell 'volatile' was incorrectly IF_LINTted out.
7e9123a2 8631
6bd8c144
PE
8632 * lisp.h (child_setup): Now NO_RETURN unless DOS_NT.
8633 This should get cleaned up, so that child_setup has the
8634 same signature on all platforms.
8635
7710357c 8636 * callproc.c (call_process_cleanup): Now static.
cb1d0ef7 8637 (relocate_fd): Rename locals to avoid shadowing.
7710357c 8638
c59da222
CY
86392011-03-22 Chong Yidong <cyd@stupidchicken.com>
8640
8641 * xterm.c (x_clear_frame): Remove XClearWindow call. This appears
8642 not to be necessary, and produces flickering.
8643
66b87493
GM
86442011-03-20 Glenn Morris <rgm@gnu.org>
8645
8646 * config.in: Remove file.
8647
45b6f6d5
JB
86482011-03-20 Juanma Barranquero <lekktu@gmail.com>
8649
8650 * minibuf.c (Vcompleting_read_function): Don't declare, global variables
8651 are now in src/globals.h.
8652 (syms_of_minibuf): Remove spurious & from previous change.
8653
cd394be1 86542011-03-20 Leo Liu <sdl.web@gmail.com>
3ec03f7e
LL
8655
8656 * minibuf.c (completing-read-function): New variable.
8657 (completing-read-default): Rename from completing-read.
8658 (completing-read): Call completing-read-function.
8659
b14e3e21
CY
86602011-03-19 Juanma Barranquero <lekktu@gmail.com>
8661
8662 * xfaces.c (Fx_load_color_file):
8663 Read color file from absolute filename (bug#8250).
8664
f2b726e6
JB
86652011-03-19 Juanma Barranquero <lekktu@gmail.com>
8666
8667 * makefile.w32-in: Update dependencies.
8668
09f6ff02
EZ
86692011-03-17 Eli Zaretskii <eliz@gnu.org>
8670
8671 * makefile.w32-in ($(BLD)/unexw32.$(O)): Depend on $(SRC)/unexec.h.
8672
29a6015a
PE
86732011-03-17 Paul Eggert <eggert@cs.ucla.edu>
8674
a3a6c54e
PE
8675 Fix more problems found by GCC 4.5.2's static checks.
8676
b766f867
PE
8677 * process.c (make_serial_process_unwind, send_process_trap):
8678 (sigchld_handler): Now static.
8679
be02381c
PE
8680 * process.c (allocate_pty): Let PTY_ITERATION declare iteration vars.
8681 That way, the code declares only the vars that it needs.
8682 * s/aix4-2.h (PTY_ITERATION): Declare iteration vars.
8683 * s/cygwin.h (PTY_ITERATION): Likewise.
8684 * s/darwin.h (PTY_ITERATION): Likewise.
8685 * s/gnu-linux.h (PTY_ITERATION): Likewise.
8686
57048744
PE
8687 * s/irix6-5.h (PTY_OPEN): Declare stb, to loosen coupling.
8688 * process.c (allocate_pty): Don't declare stb unless it's needed.
8689
7914961c 8690 * bytecode.c (MAYBE_GC): Rewrite so as not to use empty "else".
615f2d59
PE
8691 (CONSTANTLIM): Remove; unused.
8692 (METER_CODE, Bscan_buffer, Bread_char, Bset_mark):
8693 Define only if needed.
7914961c 8694
b3967b18
PE
8695 * unexelf.c (unexec): Name an expression,
8696 to avoid gcc -Wbad-function-cast warning.
9ae71512
PE
8697 Use a different way to cause a compilation error if anyone uses
8698 n rather than nn, a way that does not involve shadowing.
73366a00 8699 (ELF_BSS_SECTION_NAME, OLD_PROGRAM_H): Remove; unused.
b3967b18 8700
29a6015a
PE
8701 * deps.mk (unexalpha.o): Remove; unused.
8702
43cfc33e 8703 New file unexec.h, the (simple) interface for unexec (Bug#8267).
7feda0d2 8704 * unexec.h: New file.
ce701a33
PE
8705 * deps.mk (emacs.o, unexaix.o, unexcw.o, unexcoff.o, unexelf.o):
8706 (unexhp9k800.o, unexmacosx.o, unexsol.o, unexw32.o):
8707 Depend on unexec.h.
8708 * emacs.c [!defined CANNOT_DUMP]: Include unexec.h.
8709 * unexaix.c, unexcoff.c, unexcw.c, unexelf.c, unexhp9k800.c:
8710 * unexmacosx.c, unexsol.c, unexw32.c: Include unexec.h.
381259ef 8711 Change as necessary to match prototype in unexec.h.
ce701a33 8712
01f44d5a
PE
8713 * syntax.c (Fforward_comment, scan_lists): Rename locals to avoid
8714 shadowing.
4f63c6bb 8715 (back_comment, skip_chars): Mark vars as initialized.
01f44d5a 8716
a6670b0b
PE
8717 * character.h (FETCH_STRING_CHAR_ADVANCE_NO_CHECK, BUF_INC_POS):
8718 Rename locals to avoid shadowing.
8719
cef2010d 8720 * lread.c (read1): Rewrite so as not to use empty "else".
0902fe45 8721 (Fload, readevalloop, read1): Rename locals to avoid shadowing.
cef2010d 8722
d4d7173a
PE
8723 * print.c (Fredirect_debugging_output): Fix pointer signedess.
8724
f08b802a
PE
8725 * lisp.h (debug_output_compilation_hack): Add decl here, to avoid
8726 warning when compiling print.c.
8727
3ddb0639
PE
8728 * font.c (font_unparse_fcname): Abort in an "impossible" situation
8729 instead of using an uninitialized var.
5ad03b97 8730 (font_sort_entities): Mark var as initialized.
3ddb0639 8731
170a2692
PE
8732 * character.h (FETCH_CHAR_ADVANCE): Rename locals to avoid shadowing.
8733
e663c700
PE
8734 * font.c (font_unparse_xlfd): Don't mix pointers to variables with
8735 pointers to constants.
89bc529a 8736 (font_parse_fcname): Remove unused vars.
7b81e2d0 8737 (font_delete_unmatched): Now static.
ea838e10 8738 (font_get_spec): Remove; unused.
13a547c6
PE
8739 (font_style_to_value, font_prop_validate_style, font_unparse_fcname):
8740 (font_update_drivers, Ffont_get_glyphs, font_add_log):
8741 Rename or move locals to avoid shadowing.
e663c700 8742
2a80c887 8743 * fns.c (require_nesting_list, require_unwind): Now static.
612f56df 8744 (Ffillarray): Rename locals to avoid shadowing.
2a80c887 8745
1384fa33 8746 * floatfns.c (domain_error2): Define only if needed.
a885e2ed 8747 (Ffrexp, Fldexp): Rename locals to avoid shadowing.
1384fa33 8748
8b2c52e9
PE
8749 * alloc.c (mark_backtrace): Move decl from here ...
8750 * lisp.h: ... to here, so that it can be checked.
8751
475545b5 8752 * eval.c (call_debugger, do_debug_on_call, grow_specpdl): Now static.
d28a2170 8753 (Fdefvar): Rewrite so as not to use empty "else".
cfcbfb1a
PE
8754 (lisp_indirect_variable): Name an expression,
8755 to avoid gcc -Wbad-function-cast warning.
1faed8ae 8756 (Fdefvar): Rename locals to avoid shadowing.
475545b5 8757
b1349114 8758 * callint.c (quotify_arg, quotify_args): Now static.
a3e8cbda 8759 (Fcall_interactively): Rename locals to avoid shadowing.
b0e80955 8760 Use const pointer when appropriate.
b1349114 8761
a2928364
PE
8762 * lisp.h (get_system_name, get_operating_system_release):
8763 Move decls here, to check interfaces.
8764 * process.c (get_operating_system_release): Move decl to lisp.h.
8765 * xrdb.c (get_system_name): Likewise.
63c5d10b
PE
8766 * editfns.c (init_editfns, Fuser_login_name, Fuser_uid):
8767 (Fuser_real_uid, Fuser_full_name): Remove unnecessary casts,
8768 some of which prompt warnings from gcc -Wbad-function-cast.
545b49b4
PE
8769 (Fformat_time_string, Fencode_time, Finsert_char):
8770 (Ftranslate_region_internal, Fformat):
8771 Rename or remove local vars to avoid shadowing.
9710023e 8772 (Ftranslate_region_internal): Mark var as initialized.
63c5d10b 8773
a415e694
PE
8774 * doc.c (Fdocumentation, Fsnarf_documentation): Move locals to
8775 avoid shadowing.
8776
8ef4622d
PE
8777 * lisp.h (eassert): Check that the argument compiles, even if
8778 ENABLE_CHECKING is not defined.
8779
946f9a5b
PE
8780 * data.c (Findirect_variable): Name an expression, to avoid
8781 gcc -Wbad-function-cast warning.
112396d6 8782 (default_value, arithcompare, arith_driver, arith_error): Now static.
b9b84fa9 8783 (store_symval_forwarding): Rename local to avoid shadowing.
44f230aa
SM
8784 (Fmake_variable_buffer_local, Fmake_local_variable):
8785 Mark variables as initialized.
52746918 8786 (do_blv_forwarding, do_symval_forwarding): Remove; unused.
946f9a5b 8787
e5aab7e7 8788 * alloc.c (check_cons_list): Do not define unless GC_CHECK_CONS_LIST.
ae35e756
PE
8789 (Fmake_vector, Fvector, Fmake_byte_code, Fgarbage_collect):
8790 Rename locals to avoid shadowing.
dff45157
PE
8791 (mark_stack): Move local variables into the #ifdef region where
8792 they're used.
7bc26fdb
PE
8793 (BLOCK_INPUT_ALLOC, UNBLOCK_INPUT_ALLOC): Define only if
8794 ! defined SYSTEM_MALLOC && ! defined SYNC_INPUT, as they are not
8795 needed otherwise.
8796 (CHECK_ALLOCATED): Define only if GC_CHECK_MARKED_OBJECTS.
8797 (GC_STRING_CHARS): Remove; not used.
d40d4be1 8798 (Fmemory_limit): Cast sbrk's returned value to char *.
ae35e756 8799
e5aab7e7
PE
8800 * lisp.h (check_cons_list): Declare if GC_CHECK_CONS_LIST; this
8801 avoids undefined behavior in theory.
8802
4da60324
PE
8803 * regex.c (IF_LINT): Add defn, for benefit of ../lib-src.
8804
88043301
PE
8805 Use functions, not macros, for up- and down-casing (Bug#8254).
8806 * buffer.h (DOWNCASE_TABLE, UPCASE_TABLE, DOWNCASE, UPPERCASEP):
8807 (NOCASEP, LOWERCASEP, UPCASE, UPCASE1): Remove. All callers changed
8808 to use the following functions instead of these macros.
8809 (downcase): Adjust to lack of DOWNCASE_TABLE. Return int, not
8810 EMACS_INT, since callers assume the returned value fits in int.
8811 (upcase1): Likewise, for UPCASE_TABLE.
8812 (uppercasep, lowercasep, upcase): New static inline functions.
0da09c43 8813 * editfns.c (Fchar_equal): Remove no-longer-needed workaround for
db69b0cd 8814 the race-condition problem in the old DOWNCASE.
88043301 8815
19ed5445
PE
8816 * regex.c (CHARSET_LOOKUP_RANGE_TABLE_RAW, POP_FAILURE_REG_OR_COUNT):
8817 Rename locals to avoid shadowing.
8818 (regex_compile, re_match_2_internal): Move locals to avoid shadowing.
abbd1bcf
PE
8819 (regex_compile, re_search_2, re_match_2_internal):
8820 Remove unused local vars.
952db0d7
PE
8821 (FREE_VAR): Rewrite so as not to use empty "else",
8822 which gcc can warn about.
da053e48 8823 (regex_compile, re_match_2_internal): Mark locals as initialized.
b313f9d8
PE
8824 (RETALLOC_IF): Define only if needed.
8825 (WORDCHAR_P): Likewise. This one is never needed, but is used
8826 only in a comment talking about a compiler bug, so put inside
8827 the #if 0 of that comment.
8828 (CHARSET_LOOKUP_BITMAP, FAIL_STACK_FULL, RESET_FAIL_STACK):
8829 (PUSH_FAILURE_ELT, BUF_PUSH_3, STOP_ADDR_VSTRING):
8830 Remove; unused.
19ed5445 8831
1f3561e4 8832 * search.c (boyer_moore): Rename locals to avoid shadowing.
76ef09b7
PE
8833 * character.h (FETCH_STRING_CHAR_AS_MULTIBYTE_ADVANCE):
8834 (PREV_CHAR_BOUNDARY): Likewise.
1f3561e4 8835
ded6f8f7
PE
8836 * search.c (simple_search): Remove unused var.
8837
dbd37a95
PE
8838 * dired.c (compile_pattern): Move decl from here ...
8839 * lisp.h: ... to here, so that it can be checked.
8840 (struct re_registers): New forward decl.
8841
7e47afad
PE
8842 * character.h (INC_POS, DEC_POS): Rename locals to avoid shadowing.
8843
85f24f61
PE
8844 * indent.c (MULTIBYTE_BYTES_WIDTH): New args bytes, width.
8845 All uses changed.
8846 (MULTIBYTE_BYTES_WIDTH, scan_for_column, compute_motion):
8847 Rename locals to avoid shadowing.
5671df8f 8848 (Fvertical_motion): Mark locals as initialized.
85f24f61 8849
181aa2be 8850 * casefiddle.c (casify_object, casify_region): Now static.
e45a141a 8851 (casify_region): Mark local as initialized.
181aa2be 8852
930d429c
PE
8853 * cmds.c (internal_self_insert): Rename local to avoid shadowing.
8854
7082eac6
PE
8855 * lisp.h (GCPRO2_VAR, GCPRO3_VAR, GCPRO4_VAR, GCPRO5_VAR, GCPRO6_VAR):
8856 New macros, so that the caller can use some names other than
8857 gcpro1, gcpro2, etc.
8858 (GCPRO2, GCPRO3, GCPRO4, GCPRO5, GCPRO6): Reimplement in terms
8859 of the new macros.
8860 (GCPRO1_VAR, UNGCPRO_VAR): Change the meaning of the second
8861 argument, for consistency with GCPRO2_VAR, etc: it is now the
8862 prefix of the variable, not the variable itself. All uses
8863 changed.
38b2c076
PE
8864 * dired.c (directory_files_internal, file_name_completion):
8865 Rename locals to avoid shadowing.
8866
15206ed9
PE
8867 Fix a race condition diagnosed by gcc -Wsequence-point (Bug#8254).
8868 An expression of the form (DOWNCASE (x) == DOWNCASE (y)), found in
8869 dired.c's scmp function, had undefined behavior.
8870 * lisp.h (DOWNCASE_TABLE, UPCASE_TABLE, DOWNCASE, UPPERCASEP):
8871 (NOCASEP, LOWERCASEP, UPCASE, UPCASE1): Move from here ...
8872 * buffer.h: ... to here, because these macros use current_buffer,
8873 and the new implementation with inline functions needs to have
8874 current_buffer in scope now, rather than later when the macros
8875 are used.
8876 (downcase, upcase1): New static inline functions.
8877 (DOWNCASE, UPCASE1): Reimplement using these functions.
8878 This avoids undefined behavior in expressions like
8879 DOWNCASE (x) == DOWNCASE (y), which previously suffered
8880 from race conditions in accessing the global variables
8881 case_temp1 and case_temp2.
8882 * casetab.c (case_temp1, case_temp2): Remove; no longer needed.
8883 * lisp.h (case_temp1, case_temp2): Remove their decls.
8884 * character.h (ASCII_CHAR_P): Move from here ...
8885 * lisp.h: ... to here, so that the inline functions mentioned
8886 above can use them.
8887
4a6bea26
PE
8888 * dired.c (directory_files_internal_unwind): Now static.
8889
f14b7e14
PE
8890 * fileio.c (file_name_as_directory, directory_file_name):
8891 (barf_or_query_if_file_exists, auto_save_error, auto_save_1):
8892 Now static.
2893f146
PE
8893 (file_name_as_directory): Use const pointers when appropriate.
8894 (Fexpand_file_name): Likewise. In particular, newdir might
8895 point at constant storage, so make it a const pointer.
fd4ead52 8896 (Fmake_directory_internal, Fread_file_name): Remove unused vars.
b14aac08
PE
8897 (Ffile_selinux_context, Fset_file_selinux_context): Fix pointer
8898 signedness issues.
f839df0c
PE
8899 (Fset_file_times, Finsert_file_contents, auto_save_error):
8900 Rename locals to avoid shadowing.
f14b7e14 8901
5716756e 8902 * minibuf.c (choose_minibuf_frame_1): Now static.
62137a95
PE
8903 (Ftry_completion, Fall_completions): Rename or remove locals
8904 to avoid shadowing.
5716756e 8905
b4c3046a
PE
8906 * marker.c (bytepos_to_charpos): Remove; unused.
8907
b45db522
PE
8908 * lisp.h (verify_bytepos, count_markers): New decls,
8909 so that gcc does not warn that these functions aren't declared.
8910
85876d07
PE
8911 * insdel.c (check_markers, make_gap_larger, make_gap_smaller):
8912 (reset_var_on_error, Fcombine_after_change_execute_1): Now static.
f0cb4a60 8913 (CHECK_MARKERS): Redo to avoid gcc -Wempty-body diagnostic.
40ef059e 8914 (copy_text): Remove unused local var.
85876d07 8915
03d78a21 8916 * filelock.c (within_one_second): Now static.
b3dd38ab 8917 (lock_file_1): Rename local to avoid shadowing.
03d78a21 8918
5df8f01b
PE
8919 * buffer.c (fix_overlays_before): Mark locals as initialized.
8920 (fix_start_end_in_overlays): Likewise. This function should be
8921 simplified by using pointers-to-pointers, but that's a different
8922 matter.
b1d876f1 8923 (switch_to_buffer_1): Now static.
8f54f30a
PE
8924 (Fkill_buffer, record_buffer, Fbury_buffer, Fset_buffer_multibyte):
8925 (report_overlay_modification): Rename locals to avoid shadowing.
c3bd59b5 8926
a70072c9 8927 * sysdep.c (system_process_attributes): Rename vars to avoid shadowing.
fbd02d7b 8928 Fix pointer signedness issue.
edced198
PE
8929 (sys_subshell): Mark local as volatile if checking for lint,
8930 to suppress a gcc -Wclobbered warning that does not seem to be right.
15dfd3d9 8931 (MAXPATHLEN): Define only if needed.
a70072c9 8932
a0977c44
PE
8933 * process.c (serial_open, serial_configure): Move decls from here ...
8934 * systty.h: ... to here, so that they can be checked.
8935
a884fdcc
PE
8936 * fns.c (get_random, seed_random): Move extern decls from here ...
8937 * lisp.h: ... to here, so that they can be checked.
8938
604efe86 8939 * sysdep.c (reset_io): Now static.
b8950c94 8940 (wait_for_termination_signal): Remove; unused.
604efe86 8941
38fc62d9
PE
8942 * keymap.c (keymap_parent, keymap_memberp, map_keymap_internal):
8943 (copy_keymap_item, append_key, push_text_char_description):
8944 Now static.
1004a21a 8945 (Fwhere_is_internal): Don't test CONSP (sequences) unnecessarily.
dbbb8427 8946 (DENSE_TABLE_SIZE): Remove; unused.
c1141155
PE
8947 (get_keymap, access_keymap, Fdefine_key, Fwhere_is_internal):
8948 (describe_map_tree):
8949 Rename locals to avoid shadowing.
38fc62d9 8950
2f2650da
PE
8951 * keyboard.c: Declare functions static if they are not used elsewhere.
8952 (echo_char, echo_dash, cmd_error, top_level_2):
8953 (poll_for_input, handle_async_input): Now static.
69a058fa
PE
8954 (read_char, kbd_buffer_get_event, make_lispy_position):
8955 (make_lispy_event, make_lispy_movement, apply_modifiers):
8956 (decode_keyboard_code, tty_read_avail_input, menu_bar_items):
8957 (parse_tool_bar_item, read_key_sequence, Fread_key_sequence):
8958 (Fread_key_sequence_vector): Rename locals to avoid shadowing.
c8a06054 8959 (read_key_sequence, read_char): Mark locals as initialized.
3ac94672 8960 (Fexit_recursive_edit, Fabort_recursive_edit): Mark with NO_RETURN.
2f2650da 8961
a053e86c 8962 * keyboard.h (make_ctrl_char): New decl.
da2f2dd9
PE
8963 (mark_kboards): Move decl here ...
8964 * alloc.c (mark_kboards): ... from here.
a053e86c 8965
4752793e
PE
8966 * lisp.h (force_auto_save_soon): New decl.
8967
74f10ca7 8968 * emacs.c (init_cmdargs): Rename local to avoid shadowing.
244fc23d
PE
8969 (DEFINE_DUMMY_FUNCTION): New macro.
8970 (__do_global_ctors, __do_global_ctors_aux, __do_global_dtors, __main):
8971 Use it.
c03cd23f
PE
8972 (main): Add casts to avoid warnings
8973 if GCC considers string literals to be constants.
74f10ca7 8974
022e70d4
PE
8975 * lisp.h (fatal_error_signal): Add decl, since it's exported.
8976
59d6fe83
PE
8977 * dbusbind.c: Pointer signedness fixes.
8978 (xd_signature, xd_append_arg, xd_initialize):
8979 (Fdbus_call_method, Fdbus_call_method_asynchronously):
8980 (Fdbus_method_return_internal, Fdbus_method_error_internal):
8981 (Fdbus_send_signal, xd_read_message_1, Fdbus_register_service):
8982 (Fdbus_register_signal): Use SSDATA when the context wants char *.
8983
78320123
PE
8984 * dbusbind.c (Fdbus_init_bus): Add cast to avoid warning
8985 if GCC considers string literals to be constants.
49cebcca 8986 (Fdbus_register_service, Fdbus_register_method): Remove unused vars.
78320123 8987
35ac2a97
SM
89882011-03-16 Stefan Monnier <monnier@iro.umontreal.ca>
8989
fb103ca9
SM
8990 * print.c (PRINT_CIRCLE_CANDIDATE_P): New macro.
8991 (print_preprocess, print_object): New macro to fix last change.
8992
35ac2a97
SM
8993 * print.c (print_preprocess): Don't forget font objects.
8994
62973b41
JB
89952011-03-16 Juanma Barranquero <lekktu@gmail.com>
8996
8997 * emacs.c (USAGE3): Doc fixes.
8998
0e48bb22
AS
89992011-03-15 Andreas Schwab <schwab@linux-m68k.org>
9000
9001 * coding.c (detect_coding_iso_2022): Reorganize code to clarify
9002 structure.
9003
7684e57b
JB
90042011-03-14 Juanma Barranquero <lekktu@gmail.com>
9005
9006 * lisp.h (VWindow_system, Qfile_name_history):
9007 * keyboard.h (lispy_function_keys) [WINDOWSNT]:
9008 * w32term.h (w32_system_caret_hwnd, w32_system_caret_height)
9009 (w32_system_caret_x, w32_system_caret_y): Declare extern.
9010
9011 * w32select.c: Don't #include "keyboard.h".
c96bbc66 9012 (run_protected): Add extern declaration for waiting_for_input.
7684e57b
JB
9013
9014 * w32.c (Qlocal, noninteractive1, inhibit_window_system):
9015 * w32console.c (detect_input_pending, read_input_pending)
9016 (encode_terminal_code):
9017 * w32fns.c (quit_char, lispy_function_keys, Qtooltip)
9018 (w32_system_caret_hwnd, w32_system_caret_height, w32_system_caret_x)
9019 (w32_system_caret_y, Qfile_name_history):
9020 * w32font.c (w32font_driver, QCantialias, QCotf, QClang):
9021 * w32inevt.c (reinvoke_input_signal, lispy_function_keys):
9022 * w32menu.c (Qmenu_bar, QCtoggle, QCradio, Qoverriding_local_map)
9023 (Qoverriding_terminal_local_map, Qmenu_bar_update_hook):
9024 * w32proc.c (Qlocal, report_file_error):
9025 * w32term.c (Vwindow_system, updating_frame):
9026 * w32uniscribe.c (initialized, uniscribe_font_driver):
9027 Remove unneeded extern declarations.
9028
2aa46d6c
CY
90292011-03-14 Chong Yidong <cyd@stupidchicken.com>
9030
c96bbc66 9031 * buffer.c (Fmake_indirect_buffer): Fix incorrect assertions.
2aa46d6c 9032
cffc6f3b
CY
90332011-03-13 Chong Yidong <cyd@stupidchicken.com>
9034
9035 * buffer.h (BUF_BEGV, BUF_BEGV_BYTE, BUF_ZV, BUF_ZV_BYTE, BUF_PT)
9036 (BUF_PT_BYTE): Rewrite to handle indirect buffers (Bug#8219).
9037 These macros can no longer be used for assignment.
9038
44f230aa
SM
9039 * buffer.c (Fget_buffer_create, Fmake_indirect_buffer):
9040 Assign struct members directly, instead of using BUF_BEGV etc.
cffc6f3b
CY
9041 (record_buffer_markers, fetch_buffer_markers): New functions for
9042 recording and fetching special buffer markers.
9043 (set_buffer_internal_1, set_buffer_temp): Use them.
9044
9045 * lread.c (unreadchar): Use SET_BUF_PT_BOTH.
9046
9047 * insdel.c (adjust_point): Use SET_BUF_PT_BOTH.
9048
9049 * intervals.c (temp_set_point_both): Use SET_BUF_PT_BOTH.
9050 (get_local_map): Use SET_BUF_BEGV_BOTH and SET_BUF_ZV_BOTH.
9051
9052 * xdisp.c (hscroll_window_tree):
9053 (reconsider_clip_changes): Use PT instead of BUF_PT.
9054
d251f04b
EZ
90552011-03-13 Eli Zaretskii <eliz@gnu.org>
9056
9057 * makefile.w32-in ($(BLD)/editfns.$(O)): Depend on
9058 $(EMACS_ROOT)/lib/intprops.h.
9059
f0c77cd1
PE
90602011-03-13 Paul Eggert <eggert@cs.ucla.edu>
9061
3eca4629
PE
9062 Fix more problems found by GCC 4.5.2's static checks.
9063
7c86ee98
PE
9064 * gtkutil.c (xg_get_pixbuf_from_pixmap): Add cast from char *
9065 to unsigned char * to avoid compiler diagnostic.
b0afc268
PE
9066 (xg_free_frame_widgets): Make it clear that a local variable is
9067 needed only if USE_GTK_TOOLTIP.
01e0b5ad
PE
9068 (gdk_window_get_screen): Make it clear that this macro is needed
9069 only if USE_GTK_TOOLTIP.
1e5524e7
PE
9070 (int_gtk_range_get_value): New function, which avoids a diagnostic
9071 from gcc -Wbad-function-cast.
9072 (xg_set_toolkit_scroll_bar_thumb): Use it.
9073 (xg_tool_bar_callback, xg_tool_item_stale_p): Rewrite to avoid
9074 diagnostic from gcc -Wbad-function-cast.
65dc836c
PE
9075 (get_utf8_string, xg_get_file_with_chooser):
9076 Rename locals to avoid shadowing.
9077 (create_dialog): Move locals to avoid shadowing.
7c86ee98 9078
41729b81
PE
9079 * xgselect.c (xg_select): Remove unused var.
9080
f0c77cd1
PE
9081 * image.c (four_corners_best): Mark locals as initialized.
9082 (gif_load): Initialize transparent_p to zero (Bug#8238).
9083 Mark another local as initialized.
ec6cf4c6 9084 (my_png_error, my_error_exit): Mark with NO_RETURN.
f0c77cd1 9085
ce0ad53d 9086 * image.c (clear_image_cache): Now static.
d5d5a617 9087 (DIM, HAVE_STDLIB_H_1): Remove unused macros.
e22cffbc 9088 (xpm_load): Redo to avoid "discards qualifiers" gcc warning.
77a765fd
PE
9089 (x_edge_detection): Remove unnecessary cast that
9090 gcc -Wbad-function-cast diagnoses.
2037898d 9091 (gif_load): Fix pointer signedness.
6ae141d6
PE
9092 (clear_image_cache, xbm_read_bitmap_data, x_detect_edges):
9093 (jpeg_load, gif_load): Rename locals to avoid shadowing.
ce0ad53d 9094
33383987 90952011-03-12 Paul Eggert <eggert@cs.ucla.edu>
3eca4629 9096
d32df629
PE
9097 Improve quality of tests for time stamp overflow.
9098 For example, without this patch (encode-time 0 0 0 1 1
9099 1152921504606846976) returns the obviously-bogus value (-948597
9100 62170) on my RHEL 5.5 x86-64 host. With the patch, it correctly
9101 reports time overflow. See
9102 <http://lists.gnu.org/archive/html/emacs-devel/2011-03/msg00470.html>.
b8d9bd41
PE
9103 * deps.mk (editfns.o): Depend on ../lib/intprops.h.
9104 * editfns.c: Include limits.h and intprops.h.
9105 (TIME_T_MIN, TIME_T_MAX): New macros.
9106 (time_overflow): Move earlier, to before first use.
9107 (hi_time, lo_time): New functions, for an accurate test for
9108 out-of-range times.
9109 (Fcurrent_time, Fget_internal_run_time, make_time): Use them.
9110 (Fget_internal_run_time): Don't assume time_t fits in int.
9111 (make_time): Use list2 instead of Fcons twice.
9112 (Fdecode_time): More accurate test for out-of-range times.
9113 (check_tm_member): New function.
9114 (Fencode_time): Use it, to test for out-of-range times.
d32df629
PE
9115 (lisp_time_argument): Don't rely on undefined left-shift and
9116 right-shift behavior when checking for time stamp overflow.
8be6f318 9117
fe31d94c
PE
9118 * editfns.c (time_overflow): New function, refactoring common code.
9119 (Fformat_time_string, Fdecode_time, Fencode_time):
9120 (Fcurrent_time_string): Use it.
9121
8be6f318
PE
9122 Move 'make_time' to be next to its inverse 'lisp_time_argument'.
9123 * dired.c (make_time): Move to ...
9124 * editfns.c (make_time): ... here.
9125 * systime.h: Note the move.
9126
09d9db2c 91272011-03-12 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
c47cbdfd 9128
126bc0dc
YM
9129 * fringe.c (update_window_fringes): Remove unused variables.
9130
c47cbdfd
YM
9131 * unexmacosx.c (copy_data_segment): Also copy __got section.
9132 (Bug#8223)
9133
7ac80be9
EZ
91342011-03-12 Eli Zaretskii <eliz@gnu.org>
9135
c96bbc66 9136 * termcap.c [MSDOS]: Include "msdos.h".
058e5dad
EZ
9137 (find_capability, tgetnum, tgetflag, tgetstr, tputs, tgetent):
9138 Constify `char *' arguments and their references according to
9139 prototypes in tparam.h.
9140
ecb0f94d 9141 * deps.mk (termcap.o): Depend on tparam.h and msdos.h.
058e5dad 9142
7ac80be9
EZ
9143 * msdos.c (XMenuAddPane): 3rd argument is `const char *' now.
9144 Adapt all references accordingly.
9145
9146 * msdos.h (XMenuAddPane): 3rd argument is `const char *' now.
9147
ef1fd07e
TT
91482011-03-11 Tom Tromey <tromey@redhat.com>
9149
9150 * buffer.c (syms_of_buffer): Remove obsolete comment.
9151
7ef4b50c
EZ
91522011-03-11 Eli Zaretskii <eliz@gnu.org>
9153
9154 * termhooks.h (encode_terminal_code): Declare prototype.
9155
9156 * msdos.c (encode_terminal_code): Don't declare prototype.
9157
9158 * term.c (encode_terminal_code): Now external again, used by
9159 w32console.c and msdos.c.
9160
44f230aa
SM
9161 * makefile.w32-in ($(BLD)/term.$(O), ($(BLD)/tparam.$(O)):
9162 Depend on $(SRC)/tparam.h, see 2011-03-11T07:24:21Z!eggert@cs.ucla.edu.
7ef4b50c 9163
4b1ec863 91642011-03-11 Paul Eggert <eggert@cs.ucla.edu>
f78faa98 9165
1714f52b 9166 Fix some minor problems found by GCC 4.5.2's static checks.
83316bf4 9167
4b1ec863
PE
9168 * fringe.c (update_window_fringes): Mark locals as initialized
9169 (Bug#8227).
9170 (destroy_fringe_bitmap, init_fringe_bitmap): Now static.
bf60f616 9171
524c7aa6
PE
9172 * alloc.c (mark_fringe_data): Move decl from here ...
9173 * lisp.h (mark_fringe_data) [HAVE_WINDOW_SYSTEM]: ... to here,
9174 to check its interface.
9175 (init_fringe_once): Do not declare unless HAVE_WINDOW_SYSTEM.
9176
a5c0af81 9177 * fontset.c (free_realized_fontset): Now static.
7519b8cd 9178 (Fset_fontset_font): Rename local to avoid shadowing.
cc6e5db1 9179 (fontset_font): Mark local as initialized.
a9a06e0b 9180 (FONTSET_SPEC, FONTSET_REPERTORY, RFONT_DEF_REPERTORY): Remove; unused.
a5c0af81 9181
b4716021
PE
9182 * xrdb.c: Include "xterm.h", to check x_load_resources's interface.
9183
811e9bac 9184 * xselect.c (x_disown_buffer_selections): Remove; not used.
7b83e2f1 9185 (TRACE3) [!defined TRACE_SELECTION]: Remove; not used.
aa0daa9f
PE
9186 (x_own_selection, Fx_disown_selection_internal): Rename locals
9187 to avoid shadowing.
9188 (x_handle_dnd_message): Remove local to avoid shadowing.
811e9bac 9189
7e3ab302
PE
9190 * lisp.h (GCPRO1_VAR, UNGCPRO_VAR): New macros,
9191 so that the caller can use some name other than gcpro1.
9192 (GCPRO1, UNGCPRO): Reimplement in terms of the new macros.
58d2d479
PE
9193 * xfns.c (Fx_create_frame, x_create_tip_frame, Fx_show_tip):
9194 (Fx_backspace_delete_keys_p):
9195 Use them to avoid shadowing, and rename vars to avoid shadowing.
9196 (x_decode_color, x_set_name, x_window): Now static.
6b437900 9197 (Fx_create_frame): Add braces to silence GCC warning.
c0951e53 9198 (Fx_file_dialog, Fx_select_font): Fix pointer signedness.
06b0c8a0
PE
9199 (x_real_positions, xg_set_icon_from_xpm_data, x_create_tip_frame):
9200 Remove unused locals.
7e3ab302
PE
9201 (Fx_create_frame, x_create_tip_frame, Fx_show_tip):
9202 (Fx_backspace_delete_keys_p): Rename locals to avoid shadowing.
9203 Some of these renamings use the new GCPRO1_VAR and UNGCPRO_VAR
9204 macros.
f78faa98 9205
e2b13473
PE
9206 * xterm.h (x_mouse_leave): New decl.
9207
77f23912
PE
9208 * xterm.c (x_copy_dpy_color, x_focus_on_frame, x_unfocus_frame):
9209 Remove unused functions.
cdf4ba58
PE
9210 (x_shift_glyphs_for_insert, XTflash, XTring_bell):
9211 (x_calc_absolute_position): Now static.
7411c686 9212 (XTread_socket): Don't define label "out" unless it's used.
2b07bcff 9213 Don't declare local "event" unless it's used.
ed7bf3a5
PE
9214 (x_iconify_frame, x_free_frame_resources): Don't declare locals
9215 unless they are used.
38d0b34a
PE
9216 (XEMBED_VERSION, xembed_set_info): Don't define unless needed.
9217 (x_fatal_error_signal): Remove; not used.
a6067996
PE
9218 (x_draw_image_foreground, redo_mouse_highlight, XTmouse_position):
9219 (x_scroll_bar_report_motion, handle_one_xevent, x_draw_bar_cursor):
9220 (x_error_catcher, x_connection_closed, x_error_handler):
9221 (x_error_quitter, xembed_send_message, x_iconify_frame):
9222 (my_log_handler): Rename locals to avoid shadowing.
28f1c698 9223 (x_delete_glyphs, x_ins_del_lines): Mark with NO_RETURN.
2a8fade0 9224 (x_connection_closed): Tell GCC not to suggest NO_RETURN.
77f23912 9225
44f230aa
SM
9226 * xfaces.c (clear_face_cache, Fx_list_fonts, Fface_font):
9227 Rename or move locals to avoid shadowing.
6b463e58 9228 (tty_defined_color, merge_face_heights): Now static.
5967d051 9229 (free_realized_faces_for_fontset): Remove; not used.
1e9966ea
PE
9230 (Fx_list_fonts): Mark variable that gcc -Wuninitialized
9231 does not deduce is never used uninitialized.
73719eba
PE
9232 (STRDUPA, LSTRDUPA, FONT_POINT_SIZE_QUANTUM): Remove; not used.
9233 (LFACEP): Define only if XASSERTS, as it's not needed otherwise.
071048a3 9234
426994c3 9235 * terminal.c (store_terminal_param): Now static.
5489860b 9236
032f1620 9237 * xmenu.c (menu_highlight_callback): Now static.
9d66f88e 9238 (set_frame_menubar): Remove unused local.
d4323972 9239 (xmenu_show): Rename parameter to avoid shadowing.
6d1f7fee
PE
9240 (xmenu_show, xdialog_show, xmenu_show): Make local pointers "const"
9241 since they might point to immutable storage.
281585b0
PE
9242 (next_menubar_widget_id): Declare only if USE_X_TOOLKIT,
9243 since it's unused otherwise.
032f1620 9244
367c19e5 9245 * xdisp.c (produce_glyphless_glyph): Initialize lower_xoff.
53df7c11 9246 Add a FIXME, since the code still doesn't look right. (Bug#8215)
9f36b9fd
PE
9247 (Fcurrent_bidi_paragraph_direction): Simplify slightly; this
9248 avoids a gcc -Wuninitialized diagnostic.
0e086e8f 9249 (display_line, BUILD_COMPOSITE_GLYPH_STRING, draw_glyphs):
44a3a108
PE
9250 (note_mouse_highlight): Mark variables that gcc -Wuninitialized
9251 does not deduce are never used uninitialized.
70739cbe 9252
07b48fa9
PE
9253 * lisp.h (IF_LINT): New macro, copied from ../lib-src/emacsclient.c.
9254
8868a238 9255 * xdisp.c (redisplay_window): Rename local to avoid shadowing.
4554d213
PE
9256 * window.c (window_loop, size_window):
9257 (run_window_configuration_change_hook, enlarge_window): Likewise.
8868a238 9258
7e5cf297 9259 * window.c (display_buffer): Now static.
d6550a9f
PE
9260 (size_window): Mark variables that gcc -Wuninitialized
9261 does not deduce are never used uninitialized.
a586633d
PE
9262 * window.h (check_all_windows): New decl, to forestall
9263 gcc -Wmissing-prototypes diagnostic.
5b555da1 9264 * dispextern.h (bidi_dump_cached_states): Likewise.
7e5cf297 9265
f6095868
PE
9266 * charset.h (CHECK_CHARSET_GET_CHARSET): Rename locals to avoid
9267 shadowing.
9268 * charset.c (map_charset_for_dump, Fchar_charset): Likewise.
726929c4
PE
9269 Include <limits.h>.
9270 (Fsort_charsets): Redo min/max calculation to shorten the code a bit
9271 and to avoid gcc -Wuninitialized warning.
89ef49df
PE
9272 (load_charset_map): Mark variables that gcc -Wuninitialized
9273 does not deduce are never used uninitialized.
53df7c11 9274 (load_charset): Abort instead of using uninitialized var (Bug#8229).
f6095868 9275
f38b440c
PE
9276 * coding.c (coding_set_source, coding_set_destination):
9277 Use "else { /* comment */ }" rather than "else /* comment */;"
9278 for clarity, and to avoid gcc -Wempty-body warning.
2735d060
PE
9279 (Fdefine_coding_system_internal): Don't redeclare 'i' inside
9280 a block, when the outer 'i' will do.
9281 (decode_coding_utf_8, decode_coding_utf_16, detect_coding_emacs_mule):
9282 (emacs_mule_char, decode_coding_emacs_mule, detect_coding_iso_2022):
9283 (decode_coding_iso_2022, decode_coding_sjis, decode_coding_big5):
9284 (decode_coding_raw_text, decode_coding_charset, get_translation_table):
9285 (Fdecode_sjis_char, Fdefine_coding_system_internal):
9286 Rename locals to avoid shadowing.
9287 * character.h (FETCH_STRING_CHAR_ADVANCE): Likewise.
e2f1bab9
PE
9288 * coding.c (emacs_mule_char, encode_invocation_designation):
9289 Now static, since they're not used elsewhere.
413bb2db 9290 (decode_coding_iso_2022): Add "default: abort ();" as a safety check.
c4a63b12 9291 (decode_coding_object, encode_coding_object, detect_coding_system):
ee05f961
PE
9292 (decode_coding_emacs_mule): Mark variables that gcc
9293 -Wuninitialized does not deduce are never used uninitialized.
160b01f6
PE
9294 (detect_coding_iso_2022): Initialize a local variable that might
9295 be used uninitialized. Leave a FIXME because it's not clear that
53df7c11 9296 this initialization is needed. (Bug#8211)
5f58e762
PE
9297 (ISO_CODE_LF, ISO_CODE_CR, CODING_ISO_FLAG_EUC_TW_SHIFT):
9298 (ONE_MORE_BYTE_NO_CHECK, UTF_BOM, UTF_16_INVALID_P):
9299 (SHIFT_OUT_OK, ENCODE_CONTROL_SEQUENCE_INTRODUCER):
9300 (ENCODE_DIRECTION_R2L, ENCODE_DIRECTION_L2R):
9301 Remove unused macros.
f38b440c 9302
232b38b9 9303 * category.c (hash_get_category_set): Remove unused local var.
9f3b5e69 9304 (copy_category_table): Now static, since it's not used elsewhere.
d0891610 9305 * character.c (string_count_byte8): Likewise.
232b38b9 9306
fb90da1b
PE
9307 * ccl.c (CCL_WRITE_STRING, CCL_ENCODE_CHAR, Fccl_execute_on_string):
9308 (Fregister_code_conversion_map): Rename locals to avoid shadowing.
9309
fb93dbc2
PE
9310 * chartab.c (copy_sub_char_table): Now static, since it's not used
9311 elsewhere.
5c156ace
PE
9312 (sub_char_table_ref_and_range, char_table_ref_and_range):
9313 Rename locals to avoid shadowing.
bbcd0949 9314 (ASET_RANGE, GET_SUB_CHAR_TABLE): Remove unused macros.
fb93dbc2 9315
7d3b3862 9316 * bidi.c (bidi_check_type): Now static, since it's not used elsewhere.
630d6892 9317 (BIDI_BOB): Remove unused macro.
7d3b3862 9318
6be7d3da
PE
9319 * cm.c (cmgoto): Mark variables that gcc -Wuninitialized does not
9320 deduce are never used uninitialized.
c2ed9c8b 9321 * term.c (encode_terminal_code): Likewise.
6be7d3da 9322
75f8807f 9323 * term.c (encode_terminal_code): Now static. Remove unused local.
72abad34 9324
50938595
PE
9325 * tparam.h: New file.
9326 * term.c, tparam.h: Include it.
9327 * deps.mk (term.o, tparam.o): Depend on tparam.h.
9328 * term.c (tputs, tgetent, tgetflag, tgetnum, tparam, tgetstr):
9329 Move these decls to tparam.h, and make them agree with what
9330 is actually in tparam.c. The previous trick of using incompatible
9331 decls in different modules does not conform to the C standard.
9332 All callers of tparam changed to use tparam's actual API.
9333 * tparam.c (tparam1, tparam, tgoto):
9334 Use const pointers where appropriate.
9335
fbceeba2
PE
9336 * cm.c (calccost, cmgoto): Use const pointers where appropriate.
9337 * cm.h (struct cm): Likewise.
9338 * dispextern.h (do_line_insertion_deletion_costs): Likewise.
9339 * scroll.c (ins_del_costs, do_line_insertion_deletion_costs): Likewise.
9340 * term.c (tty_ins_del_lines, calculate_costs, struct fkey_table):
9341 (term_get_fkeys_1, append_glyphless_glyph, produce_glyphless_glyph):
9342 (turn_on_face, init_tty): Likewise.
9343 * termchar.h (struct tty_display_info): Likewise.
fbceeba2 9344
7f3f1250
PE
9345 * term.c (term_mouse_position): Rename local to avoid shadowing.
9346
e6ca6543
PE
9347 * alloc.c (mark_ttys): Move decl from here ...
9348 * lisp.h (mark_ttys): ... to here, so that it's checked against defn.
9349
c40f8d15
AS
93502011-03-11 Andreas Schwab <schwab@linux-m68k.org>
9351
9352 * .gdbinit (pwinx, xbuffer): Fix access to buffer name.
9353
cfe0661d
JB
93542011-03-09 Juanma Barranquero <lekktu@gmail.com>
9355
9356 * search.c (compile_pattern_1): Remove argument regp, unused since
9357 revid:rms@gnu.org-19941211082627-3x1g1wyqkjmwloig.
9358 (compile_pattern): Don't pass it.
9359
0afb4571
J
93602011-03-08 Jan Djärv <jan.h.d@swipnet.se>
9361
9362 * xterm.h (DEFAULT_GDK_DISPLAY): New define.
9363 (GDK_WINDOW_XID, gtk_widget_get_preferred_size): New defines
9364 for ! HAVE_GTK3.
9365 (GTK_WIDGET_TO_X_WIN): Use GDK_WINDOW_XID.
9366
9367 * xmenu.c (menu_position_func): Call gtk_widget_get_preferred_size.
9368
9369 * gtkutil.c: Include gtkx.h if HAVE_GTK3. If ! HAVE_GTK3, define
9370 gdk_window_get_screen, gdk_window_get_geometry,
9371 gdk_x11_window_lookup_for_display and GDK_KEY_g.
9372 (xg_set_screen): Use DEFAULT_GDK_DISPLAY.
9373 (xg_get_pixbuf_from_pixmap): New function.
9374 (xg_get_pixbuf_from_pix_and_mask): Change parameters from GdkPixmap
9375 to Pixmap, take frame as parameter, remove GdkColormap parameter.
9376 Call xg_get_pixbuf_from_pixmap instead of
9377 gdk_pixbuf_get_from_drawable.
9378 (xg_get_image_for_pixmap): Do not make GdkPixmaps, call
9379 xg_get_pixbuf_from_pix_and_mask with Pixmap parameters instead.
9380 (xg_check_special_colors): Use GtkStyleContext and its functions
9381 for HAVE_GTK3.
9382 (xg_prepare_tooltip, xg_hide_tooltip): Call gdk_window_get_screen.
9383 (xg_prepare_tooltip, create_dialog, menubar_map_cb)
9384 (xg_update_frame_menubar, xg_tool_bar_detach_callback)
44f230aa
SM
9385 (xg_tool_bar_attach_callback, xg_update_tool_bar_sizes):
9386 Call gtk_widget_get_preferred_size.
0afb4571
J
9387 (xg_frame_resized): gdk_window_get_geometry only takes 5
9388 parameters.
44f230aa
SM
9389 (xg_win_to_widget, xg_event_is_for_menubar):
9390 Call gdk_x11_window_lookup_for_display.
0afb4571
J
9391 (xg_set_widget_bg): New function.
9392 (delete_cb): New function.
895009e1 9393 (xg_create_frame_widgets): Connect delete-event to delete_cb.
5c32d3f2 9394 Call xg_set_widget_bg. Only set background pixmap for ! HAVE_GTK3
0afb4571
J
9395 (xg_set_background_color): Call xg_set_widget_bg.
9396 (xg_set_frame_icon): Call xg_get_pixbuf_from_pix_and_mask.
9397 (xg_create_scroll_bar): vadj is a GtkAdjustment for HAVE_GTK3.
9398 Only call gtk_range_set_update_policy if ! HAVE_GTK3.
9399 (xg_make_tool_item): Only connect xg_tool_bar_item_expose_callback
9400 if ! HAVE_GTK3.
9401 (update_frame_tool_bar): Call gtk_widget_hide.
9402 (xg_initialize): Use GDK_KEY_g.
9403
9404 * xsmfns.c (gdk_set_sm_client_id): Define to gdk_set_sm_client_id
9405 if ! HAVE_GTK3
9406 (x_session_initialize): Call gdk_x11_set_sm_client_id.
9407
9408 * xterm.c (XFillRectangle): Use cairo routines for HAVE_GTK3.
9409 (x_term_init): Disable Xinput(2) with GDK_CORE_DEVICE_EVENTS.
9410 Load ~/emacs.d/gtkrc only for ! HAVE_GTK3.
9411
1c2cc4ef
JB
94122011-03-08 Juanma Barranquero <lekktu@gmail.com>
9413
9414 * w32xfns.c (select_palette): Check success of RealizePalette against
9415 GDI_ERROR, not zero.
9416
33383987 9417See ChangeLog.11 for earlier changes.
aac0c6e3
MR
9418
9419;; Local Variables:
9420;; coding: utf-8
aac0c6e3
MR
9421;; End:
9422
acaf905b 9423 Copyright (C) 2011-2012 Free Software Foundation, Inc.
aac0c6e3
MR
9424
9425 This file is part of GNU Emacs.
9426
9427 GNU Emacs is free software: you can redistribute it and/or modify
9428 it under the terms of the GNU General Public License as published by
9429 the Free Software Foundation, either version 3 of the License, or
9430 (at your option) any later version.
9431
9432 GNU Emacs is distributed in the hope that it will be useful,
9433 but WITHOUT ANY WARRANTY; without even the implied warranty of
9434 MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
9435 GNU General Public License for more details.
9436
9437 You should have received a copy of the GNU General Public License
9438 along with GNU Emacs. If not, see <http://www.gnu.org/licenses/>.