Don't set dedicated status for reused normal windows (Bug#9215).
[bpt/emacs.git] / src / ChangeLog
CommitLineData
525d5e6e
EZ
12011-08-01 Eli Zaretskii <eliz@gnu.org>
2
3 * xdisp.c (forward_to_next_line_start): Accept additional argument
4 BIDI_IT_PREV, and store into it the state of the bidi iterator had
5 on the newline.
6 (reseat_at_next_visible_line_start): Use the bidi iterator state
7 returned by forward_to_next_line_start to restore the state of
8 it->bidi_it after backing up to previous newline. (Bug#9212)
9
31011111
AS
102011-07-30 Andreas Schwab <schwab@linux-m68k.org>
11
12 * regex.c (re_comp): Protoize.
13 (re_exec): Fix return type.
14 (regexec): Fix type of `ret'. (Bug#9203)
15
e5d76069
PE
162011-07-29 Paul Eggert <eggert@cs.ucla.edu>
17
18 * image.c (check_image_size): Use 1024x1024 if unknown frame (Bug#9189).
19 This is needed if max-image-size is a floating-point number.
20
9a79b20c
AS
212011-07-28 Andreas Schwab <schwab@linux-m68k.org>
22
23 * print.c (print_object): Print empty symbol as ##.
24
25 * lread.c (read1): Read ## as empty symbol.
26
d8c2fa78
AA
272011-07-28 Alp Aker <alp.tekin.aker@gmail.com>
28
29 * nsfns.m (x_set_foreground_color): Set f->foreground_pixel when
30 setting frame foreground color (Bug#9175).
31 (x_set_background_color): Likewise.
32
ffe57a7a
AA
33 * nsmenu.m (-setText): Size tooltip dimensions precisely to
34 contents (Bug#9176).
35 (EmacsTooltip -init): Remove bezels and add shadows to
36 tooltip windows.
37
bf3492a5
AA
38 * nsterm.m (ns_dumpglyphs_stretch): Avoid overwriting left fringe
39 or scroll bar (Bug#8470).
40
d55e9c53
AA
41 * nsfont.m (nsfont_open): Remove assignment to voffset and
42 unnecessary vars hshink, expand, hd, full_height, min_height.
43 (nsfont_draw): Use s->ybase as baseline for glyph drawing (Bug#8913).
44
45 * nsterm.h (nsfont_info): Remove voffset field.
46
d8c2fa78 472011-07-28 Alp Aker <alp.tekin.aker@gmail.com>
4843aac3
AA
48
49 Implement strike-through and overline on NextStep (Bug#8863).
50
51 * nsfont.m (nsfont_open): Use underline position provided by font,
52 instead of hard-coded value of 2.
53 (nsfont_draw): Call ns_draw_text_decoration instead.
54
55 * nsterm.h: Add declaration for ns_draw_text_decoration.
56
57 * nsterm.m (ns_draw_text_decoration): New function for drawing
58 underline, overline, and strike-through.
59 (ns_dumpglyphs_image, ns_dumpglyphs_stretch): Add call to
60 ns_draw_text_decoration. Change treatment of cursor drawing to
61 accomodate underlining, etc.
62
4cc60b9b
EZ
632011-07-28 Eli Zaretskii <eliz@gnu.org>
64
bc7ece87
EZ
65 * buffer.c (init_buffer_once): Set bidi-display-reordering to t by
66 default.
4cc60b9b 67
476371c4
PE
682011-07-28 Paul Eggert <eggert@cs.ucla.edu>
69
66606eea
PE
70 * alloc.c (memory_full) [!SYNC_INPUT]: Fix signal-related race.
71 Without this fix, if a signal arrives just after memory fills up,
72 'malloc' might be invoked reentrantly.
73
476371c4
PE
74 * image.c (x_check_image_size) [!HAVE_X_WINDOWS]: Return 1.
75 In other words, assume that every image size is allowed, on non-X
76 hosts. This assumption is probably wrong, but it lets Emacs compile.
77
f3fcc40d
AS
782011-07-28 Andreas Schwab <schwab@linux-m68k.org>
79
80 * regex.c (re_iswctype): Convert return values to boolean.
81
350c992f
EZ
822011-07-28 Eli Zaretskii <eliz@fencepost.gnu.org>
83
84 * xdisp.c (compute_display_string_pos): Don't use cached display
85 string position if the buffer had its restriction changed.
86 (Bug#9184)
87
5266b4bb
PE
882011-07-28 Paul Eggert <eggert@cs.ucla.edu>
89
90 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork clobbering.
91
2573a837 922011-07-28 Paul Eggert <eggert@cs.ucla.edu>
ca4aa935 93
41f55ccd 94 Integer signedness and overflow and related fixes. (Bug#9079)
cf950e6b 95
39e378da
PE
96 * bidi.c: Integer size and overflow fixes.
97 (bidi_cache_size, bidi_cache_idx, bidi_cache_last_idx)
98 (bidi_cache_start, bidi_cache_fetch_state, bidi_cache_search)
99 (bidi_cache_find_level_change, bidi_cache_ensure_space)
100 (bidi_cache_iterator_state, bidi_cache_find, bidi_cache_start_stack)
101 (bidi_find_other_level_edge):
102 Use ptrdiff_t instead of EMACS_INT where either will do.
103 This works better on 32-bit hosts configured --with-wide-int.
104 (bidi_cache_ensure_space): Check for size-calculation overflow.
105 Use % rather than repeated addition, for better worst-case speed.
106 Don't set bidi_cache_size until after xrealloc returns, because it
107 might not return.
108 (bidi_dump_cached_states): Use ptrdiff_t, not int, to avoid overflow.
f0eb61e9
PE
109 (bidi_cache_ensure_space): Also check that the bidi cache size
110 does not exceed that of the largest Lisp string or buffer. See Eli
111 Zaretskii in <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=9079#29>.
39e378da 112
5e927815
PE
113 * alloc.c (__malloc_size_t): Remove.
114 All uses replaced by size_t. See Andreas Schwab's note
115 <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=9079#8>.
116
ca4aa935
PE
117 * image.c: Improve checking for integer overflow.
118 (check_image_size): Assume that f is nonnull, since
119 it is always nonnull in practice. This is one less thing to
120 worry about when checking for integer overflow later.
121 (x_check_image_size): New function, which checks for integer
122 overflow issues inside X.
123 (x_create_x_image_and_pixmap, xbm_read_bitmap_data): Use it.
124 This removes the need for a memory_full check.
125 (xbm_image_p): Rewrite to avoid integer multiplication overflow.
126 (Create_Pixmap_From_Bitmap_Data, xbm_load): Use x_check_image_size.
127 (xbm_read_bitmap_data): Change locals back to 'int', since
128 their values must fit in 'int'.
129 (xpm_load_image, png_load, tiff_load):
130 Invoke x_create_x_image_and_pixmap earlier,
131 to avoid much needless work if the image is too large.
132 (tiff_load): Treat overly large images as if
133 x_create_x_image_and_pixmap failed, not as malloc failures.
134 (gs_load): Use x_check_image_size.
135
5f8f9cc2
PE
136 * gtkutil.c: Omit integer casts.
137 (xg_get_pixbuf_from_pixmap): Remove unnecessary cast.
138 (xg_set_toolkit_scroll_bar_thumb): Rewrite to avoid need for cast.
139
5adf60bc
PE
140 * image.c (png_load): Don't assume height * row_bytes fits in 'int'.
141
c8907a93
PE
142 * xfaces.c (Fbitmap_spec_p): Fix integer overflow bug.
143 Without this fix, (bitmap-spec-p '(34359738368 1 "x"))
144 would wrongly return t on a 64-bit host.
145
e3c25c68
PE
146 * dispnew.c (init_display): Use *_RANGE_OVERFLOW macros.
147 The plain *_OVERFLOW macros run afoul of GCC bug 49705
148 <http://gcc.gnu.org/bugzilla/show_bug.cgi?id=49705>
149 and therefore cause GCC to emit a bogus diagnostic in some cases.
150
3f791afe
PE
151 * image.c: Integer signedness and overflow and related fixes.
152 This is not an exhaustive set of fixes, but it's time to
153 record what I've got.
154 (lookup_pixel_color, check_image_size): Remove redundant decls.
155 (check_image_size): Don't assume that arbitrary EMACS_INT values
156 fit in 'int', or that arbitrary 'double' values fit in 'int'.
157 (x_alloc_image_color, x_create_x_image_and_pixmap, png_load)
158 (tiff_load, imagemagick_load_image):
159 Check for overflow in size calculations.
160 (x_create_x_image_and_pixmap): Remove unnecessary test for
161 xmalloc returning NULL; that can't happen.
162 (xbm_read_bitmap_data): Don't assume sizes fit into 'int'.
163 (xpm_color_bucket): Use better integer hashing function.
164 (xpm_cache_color): Don't possibly over-allocate memory.
165 (struct png_memory_storage, tiff_memory_source, tiff_seek_in_memory)
166 (gif_memory_source):
167 Use ptrdiff_t, not int or size_t, to record sizes.
168 (png_load): Don't assume values greater than 2**31 fit in 'int'.
169 (our_stdio_fill_input_buffer): Prefer ptrdiff_t to size_t when
170 either works, as we prefer signed integers.
171 (tiff_read_from_memory, tiff_write_from_memory):
172 Return tsize_t, not size_t, since that's what the TIFF API wants.
173 (tiff_read_from_memory): Don't fail simply because the read would
174 go past EOF; instead, return a short read.
175 (tiff_load): Omit no-longer-needed casts.
176 (Fimagemagick_types): Don't assume size fits into 'int'.
177
3cc5a532
PE
178 Improve hashing quality when configured --with-wide-int.
179 * fns.c (hash_string): New function, taken from sxhash_string.
180 Do not discard information about ASCII character case; this
181 discarding is no longer needed.
182 (sxhash-string): Use it. Change sig to match it. Caller changed.
183 * lisp.h: Declare it.
184 * lread.c (hash_string): Remove, since we now use fns.c's version.
185 The fns.c version returns a wider integer if --with-wide-int is
186 specified, so this should help the quality of the hashing a bit.
187
b312a492
PE
188 * emacs.c: Integer overflow minor fix.
189 (heap_bss_diff): Now uprintmax_t, not unsigned long. All used changed.
190 Define only if GNU_LINUX.
191 (main, Fdump_emacs): Set and use heap_bss_diff only if GNU_LINUX.
192
dfd153ae
PE
193 * dispnew.c: Integer signedness and overflow fixes.
194 Remove unnecessary forward decls, that were a maintenance hassle.
195 (history_tick): Now uprintmax_t, so it's more likely to avoid overflow.
196 All uses changed.
197 (adjust_glyph_matrix, realloc_glyph_pool, adjust_frame_message_buffer)
198 (scrolling_window): Use ptrdiff_t, not int, for byte count.
199 (prepare_desired_row, line_draw_cost):
200 Use int, not unsigned, where either works.
201 (save_current_matrix, restore_current_matrix):
202 Use ptrdiff_t, not size_t, where either works.
203 (init_display): Check for overflow more accurately, and without
204 relying on undefined behavior.
205
a81d11a3
PE
206 * editfns.c (pWIDE, pWIDElen, signed_wide, unsigned_wide):
207 Remove, replacing with the new symbols in lisp.h. All uses changed.
208 * fileio.c (make_temp_name):
209 * filelock.c (lock_file_1, lock_file):
210 * xdisp.c (message_dolog):
211 Don't assume PRIdMAX etc. works; this isn't portable to pre-C99 hosts.
212 Use pMd etc. instead.
213 * lisp.h (printmax_t, uprintmax_t, pMd, pMu): New types and macros,
214 replacing the pWIDE etc. symbols removed from editfns.c.
215
3300e6fd
PE
216 * keyboard.h (num_input_events): Now uintmax_t.
217 This is (very slightly) less likely to mess up due to wraparound.
218 All uses changed.
219
fd05c7e9
PE
220 * buffer.c: Integer signedness fixes.
221 (alloc_buffer_text, enlarge_buffer_text):
222 Use ptrdiff_t rather than size_t when either will do, as we prefer
223 signed integers.
224
903fe15d
PE
225 * alloc.c: Integer signedness and overflow fixes.
226 Do not impose an arbitrary 32-bit limit on malloc sizes when debugging.
227 (__malloc_size_t): Default to size_t, not to int.
228 (pure_size, pure_bytes_used_before_overflow, stack_copy_size)
229 (Fgarbage_collect, mark_object_loop_halt, mark_object):
230 Prefer ptrdiff_t to size_t when either would do, as we prefer
231 signed integers.
232 (XMALLOC_OVERRUN_CHECK_OVERHEAD): New macro.
233 (xmalloc_overrun_check_header, xmalloc_overrun_check_trailer):
234 Now const. Initialize with values that are in range even if char
235 is signed.
236 (XMALLOC_PUT_SIZE, XMALLOC_GET_SIZE): Remove, replacing with ...
237 (xmalloc_put_size, xmalloc_get_size): New functions. All uses changed.
238 These functions do the right thing with sizes > 2**32.
239 (check_depth): Now ptrdiff_t, not int.
240 (overrun_check_malloc, overrun_check_realloc, overrun_check_free):
241 Adjust to new way of storing sizes. Check for size overflow bugs
242 in rest of code.
243 (STRING_BYTES_MAX): Adjust to new overheads. The old code was
244 slightly wrong anyway, as it missed one instance of
245 XMALLOC_OVERRUN_CHECK_OVERHEAD.
246 (refill_memory_reserve): Omit needless cast to size_t.
247 (mark_object_loop_halt): Mark as externally visible.
248
ac82cc6a
PE
249 * xselect.c: Integer signedness and overflow fixes.
250 (Fx_register_dnd_atom, x_handle_dnd_message):
251 Use ptrdiff_t, not size_t, since we prefer signed.
252 (Fx_register_dnd_atom): Check for ptrdiff_t (and size_t) overflow.
253 * xterm.h (struct x_display_info): Use ptrdiff_t, not size_t, for
254 x_dnd_atoms_size and x_dnd_atoms_length.
255
c2d1e36d
PE
256 * doprnt.c: Prefer signed to unsigned when either works.
257 * eval.c (verror):
258 * doprnt.c (doprnt):
259 * lisp.h (doprnt):
260 * xdisp.c (vmessage):
261 Use ptrdiff_t, not size_t, when using or implementing doprnt,
262 since the sizes cannot exceed ptrdiff_t bounds anyway, and we
263 prefer signed arithmetic to avoid comparison confusion.
264 * doprnt.c (doprnt): Avoid a "+ 1" that can't overflow,
265 but is a bit tricky.
266
0e926e56
PE
267 Assume freestanding C89 headers, string.h, stdlib.h.
268 * data.c, doprnt.c, floatfns.c, print.c:
269 Include float.h unconditionally.
270 * gmalloc.c: Assume C89-at-least behavior for preprocessor,
271 limits.h, stddef.h, string.h. Use memset instead of 'flood'.
272 * regex.c: Likewise for stddef.h, string.h.
273 (ISASCII): Remove; can assume it returns 1 now. All uses removed.
274 * s/aix4-2.h (HAVE_STRING_H): Remove obsolete undef.
275 * s/ms-w32.h (HAVE_LIMITS_H, HAVE_STRING_H, HAVE_STDLIB_H)
276 (STDC_HEADERS): Remove obsolete defines.
277 * sysdep.c: Include limits.h unconditionally.
278
9cfdb3ec
PE
279 Assume support for memcmp, memcpy, memmove, memset.
280 * lisp.h, sysdep.c (memcmp, memcpy, memmove, memset):
281 * regex.c (memcmp, memcpy):
282 Remove; we assume C89 now.
283
284 * gmalloc.c (memcpy, memset, memmove): Remove; we assume C89 now.
285 (__malloc_safe_bcopy): Remove; no longer needed.
286
cf950e6b 287 * lisp.h (struct vectorlike_header, struct Lisp_Subr): Signed sizes.
6089c567
PE
288 Use EMACS_INT, not EMACS_UINT, for sizes. The code works equally
289 well either way, and we prefer signed to unsigned.
290
dbf38e02
LMI
2912011-07-27 Lars Magne Ingebrigtsen <larsi@gnus.org>
292
293 * gnutls.c (emacs_gnutls_read): Don't message anything if the peer
294 closes the connection while we're reading (bug#9182).
295
d6f0886c
JD
2962011-07-25 Jan Djärv <jan.h.d@swipnet.se>
297
298 * nsmenu.m (ns_popup_dialog): Add an "ok" button if no buttons
299 are specified (Bug#9168).
300
2eb1f9e6
PE
3012011-07-25 Paul Eggert <eggert@cs.ucla.edu>
302
303 * bidi.c (bidi_dump_cached_states): Fix printf format mismatch.
304 Found by GCC static checking and --with-wide-int on a 32-bit host.
305
22381272 3062011-07-25 Eli Zaretskii <eliz@gnu.org>
7daee910
EZ
307
308 * xdisp.c (compute_display_string_pos): Fix logic of caching
309 previous display string position. Initialize cached_prev_pos to
310 -1. Fixes slow-down at the beginning of a buffer.
311
f25e39b4
EZ
3122011-07-24 Eli Zaretskii <eliz@gnu.org>
313
314 * xfaces.c (check_lface_attrs) [HAVE_WINDOW_SYSTEM]: Allow `nil'
315 for attrs[LFACE_FONTSET_INDEX].
316
04c4b52e
PE
3172011-07-23 Paul Eggert <eggert@cs.ucla.edu>
318
319 * xml.c (parse_region): Remove unused local
320 that was recently introduced.
321
c1734fbd
EZ
3222011-07-23 Eli Zaretskii <eliz@gnu.org>
323
be18c5a5
EZ
324 * xfns.c (unwind_create_frame) [GLYPH_DEBUG]: Adapt to changes in
325 2008-02-22T17:42:09Z!monnier@iro.umontreal.ca.
326
c1734fbd
EZ
327 * xdisp.c (move_it_in_display_line_to): Record the best matching
328 position for TO_CHARPOS while scanning the line, and restore it on
329 exit if none of the characters scanned was an exact match. Fixes
a9269c18
EZ
330 vertical-motion and pos-visible-in-window-p under bidi redisplay
331 when exact match is impossible due to invisible text, and the
332 lines are truncated.
333
a258d627
JD
3342011-07-23 Jan Djärv <jan.h.d@swipnet.se>
335
336 * nsterm.m (initFrameFromEmacs): Set NSTitledWindowMask in styleMask
337 for OSX >= 10.7.
338
b6d5a689
EZ
3392011-07-22 Eli Zaretskii <eliz@gnu.org>
340
0f74f785
EZ
341 Fix a significant slow-down of cursor motion with C-n, C-p,
342 C-f/C-b, and C-v/M-v that couldn't keep up with keyboard
343 auto-repeat under bidi redisplay in fontified buffers.
b6d5a689 344 * xdisp.c (compute_stop_pos_backwards): New function.
b6d5a689
EZ
345 (next_element_from_buffer): Call compute_stop_pos_backwards to
346 find a suitable prev_stop when we find ourselves before
0f74f785
EZ
347 base_level_stop.
348 (reseat): Don't look for prev_stop, as that could mean a very long
349 run.
350 <cached_disp_pos, cached_disp_buffer, cached_disp_modiff>
351 <cached_disp_overlay_modiff>: Cache for last found display string
352 position.
551918c1 353 (compute_display_string_pos): Return the cached position if asked
0f74f785
EZ
354 about the same buffer in the same area of character positions, and
355 the buffer wasn't changed since the time the display string
356 position was cached.
551918c1 357
b2d0c91a
EZ
3582011-07-22 Eli Zaretskii <eliz@gnu.org>
359
360 * xdisp.c (rows_from_pos_range): Don't ignore glyphs whose object
361 is an integer, which is important for empty lines. (Bug#9149)
362
043604ee
CY
3632011-07-22 Chong Yidong <cyd@stupidchicken.com>
364
365 * frame.c (Fmodify_frame_parameters): In tty case, update the
366 default face if necessary (Bug#4238).
367
da4adb04
CY
3682011-07-21 Chong Yidong <cyd@stupidchicken.com>
369
370 * editfns.c (Fstring_to_char): No need to explain what a character
371 is in the docstring (Bug#6576).
372
9abd0532
LMI
3732011-07-20 Lars Magne Ingebrigtsen <larsi@gnus.org>
374
375 * xml.c (parse_region): Make sure we always return a tree.
376
36881d16
HK
3772011-07-20 HAMANO Kiyoto <khiker.mail@gmail.com>
378
379 * xml.c (parse_region): If a document contains only comments,
380 return that, too.
381
1e98674d
LMI
3822011-07-20 Lars Magne Ingebrigtsen <larsi@gnus.org>
383
384 * xml.c (make_dom): Return comments, too.
385
590bd467
PE
3862011-07-19 Paul Eggert <eggert@cs.ucla.edu>
387
388 Port to OpenBSD.
389 See http://lists.gnu.org/archive/html/emacs-devel/2011-07/msg00688.html
390 and the surrounding thread.
391 * minibuf.c (read_minibuf_noninteractive): Rewrite to use getchar
392 rather than fgets, and retry after EINTR. Otherwise, 'emacs
393 --batch -f byte-compile-file' fails on OpenBSD if an inactivity
394 timer goes off.
395 * s/openbsd.h (BROKEN_SIGIO): Define.
396 * unexelf.c (unexec) [__OpenBSD__]:
397 Don't update the .mdebug section of the Alpha COFF symbol table.
398
f41628b2
LMI
3992011-07-19 Lars Magne Ingebrigtsen <larsi@gnus.org>
400
401 * lread.c (syms_of_lread): Clarify when `lexical-binding' is used
402 (bug#8460).
403
b59b67c5
PE
4042011-07-18 Paul Eggert <eggert@cs.ucla.edu>
405
15e3a074
PE
406 * fileio.c (Fcopy_file) [!MSDOS]: Tighten created file's mask.
407 This fixes some race conditions on the permissions of any newly
408 created file.
409
41bed37d
PE
410 * alloc.c (valid_pointer_p): Use pipe, not open.
411 This fixes some permissions issues when debugging.
412
b59b67c5
PE
413 * fileio.c (Fcopy_file): Adjust mode if fchown fails. (Bug#9002)
414 If fchown fails to set both uid and gid, try to set just gid,
415 as that is sometimes allowed. Adjust the file's mode to eliminate
416 setuid or setgid bits that are inappropriate if fchown fails.
417
925a6be7
SM
4182011-07-18 Stefan Monnier <monnier@iro.umontreal.ca>
419
420 * xdisp.c (next_element_from_string, next_element_from_buffer): Use EQ
421 to compare Lisp_Objects.
422 * gnutls.c (syms_of_gnutls): Rename Vgnutls_log_level to
423 global_gnutls_log_level, don't mistake it for a Lisp_Object.
424 (init_gnutls_functions, emacs_gnutls_handle_error): Fix up uses.
425
52968808
AS
4262011-07-17 Andreas Schwab <schwab@linux-m68k.org>
427
0a6a104b
AS
428 * lread.c (read_integer): Unread even EOF character.
429 (read1): Likewise. Properly record start position of symbol.
430
52968808
AS
431 * lread.c (read1): Read `#:' as empty uninterned symbol if no
432 symbol character follows.
433
9e381cdd
PE
4342011-07-17 Paul Eggert <eggert@cs.ucla.edu>
435
436 * fileio.c (Fcopy_file): Pacify gcc re fchown. (Bug#9002)
437 This works around a problem with the previous change to Fcopy_file.
438 Recent glibc declares fchown with __attribute__((warn_unused_result)),
439 and without this change, GCC might complain about discarding
440 fchown's return value.
441
b5641435
JB
4422011-07-16 Juanma Barranquero <lekktu@gmail.com>
443
444 * makefile.w32-in (GLOBAL_SOURCES): Add gnutls.c (followup to bug#9059).
445
a8031457
PE
4462011-07-16 Paul Eggert <eggert@cs.ucla.edu>
447
448 * fileio.c (Fcopy_file): Don't diagnose fchown failures. (Bug#9002)
449
dd889327
LMI
4502011-07-16 Lars Magne Ingebrigtsen <larsi@gnus.org>
451
750c33f7
LMI
452 * gnutls.c (syms_of_gnutls): Define `gnutls-log-level' here, since
453 it's used from the C level.
454
dd889327
LMI
455 * process.c: Use the same condition for POLL_FOR_INPUT in both
456 keyboard.c and process.c (bug#1858).
457
87e86684
LM
4582011-07-09 Lawrence Mitchell <wence@gmx.li>
459
460 * gnutls.c (Qgnutls_bootprop_min_prime_bits): New variable.
461 (Fgnutls_boot): Use it.
462
64348f40
AS
4632011-07-15 Andreas Schwab <schwab@linux-m68k.org>
464
465 * doc.c (Fsubstitute_command_keys): Revert last change.
466
1d698799
LMI
4672011-07-15 Lars Magne Ingebrigtsen <larsi@gnus.org>
468
f863868c
LMI
469 * doc.c (Fsubstitute_command_keys): Clarify that \= really only
470 quotes the next character, and doesn't affect other longer
471 sequences (bug#8935).
472
1d698799
LMI
473 * lread.c (syms_of_lread): Clarify that is isn't only
474 `eval-buffer' and `eval-defun' that's affected by
475 `lexical-binding' (bug#8460).
476
aa4b6df6
EZ
4772011-07-15 Eli Zaretskii <eliz@gnu.org>
478
479 * xdisp.c (move_it_in_display_line_to): Fix vertical motion with
480 bidi redisplay when a line includes both an image and is
481 truncated.
482
5d856da6
PE
4832011-07-14 Paul Eggert <eggert@cs.ucla.edu>
484
ad6042bb
PE
485 Fix minor problems found by static checking.
486 * bidi.c (bidi_cache_size): Now EMACS_INT, not size_t.
487 (elsz): Now a signed constant, not a size_t var. We prefer signed
488 types to unsigned, to avoid integer comparison confusion. Without
489 this change, GCC 4.6.1 with -Wunsafe-loop-optimizations complains
490 "cannot optimize loop, the loop counter may overflow", a symptom
491 of the confusion.
f00bbb22 492 * indent.c (Fvertical_motion): Mark locals as initialized.
5d856da6
PE
493 * xdisp.c (reseat_to_string): Fix pointer signedness issue.
494
6468f31c
LMI
4952011-07-14 Lars Magne Ingebrigtsen <larsi@gnus.org>
496
49080b10
LMI
497 * search.c (Fre_search_backward): Mention `case-fold-search' in
498 all the re_search_* functions (bug#8138).
499
6468f31c
LMI
500 * keyboard.c (Fopen_dribble_file): Document when the file is
501 closed (bug#8056).
502
c965adc5
EZ
5032011-07-14 Eli Zaretskii <eliz@gnu.org>
504
df9733bf
EZ
505 * bidi.c (bidi_dump_cached_states): Fix format of displaying
506 bidi_cache_idx.
507
0bb23927
EZ
508 Support bidi reordering of display and overlay strings.
509 * xdisp.c (compute_display_string_pos)
510 (compute_display_string_end): Accept additional argument STRING.
511 (init_iterator, reseat_1): Initialize bidi_it->string.s to NULL.
512 (reseat_to_string): Initialize bidi_it->string.s and
513 bidi_it->string.schars.
514 (Fcurrent_bidi_paragraph_direction): Initialize itb.string.s to
515 NULL (avoids a crash in bidi_paragraph_init). Initialize
516 itb.string.lstring.
517 (init_iterator): Call bidi_init_it only of a valid
518 buffer position was specified. Initialize paragraph_embedding to
519 L2R.
520 (reseat_to_string): Initialize the bidi iterator.
521 (display_string): If we need to ignore text properties of
522 LISP_STRING, set IT->stop_charpos to IT->end_charpos. (The
523 original value of -1 will not work with bidi.)
524 (compute_display_string_pos): First arg is now struct
525 `text_pos *'; all callers changed. Support display properties on
526 Lisp strings.
527 (compute_display_string_end): Support display properties on Lisp
528 strings.
529 (init_iterator, reseat_1, reseat_to_string): Initialize the
530 string.bufpos member to 0 (zero, for compatibility with IT_CHARPOS
531 when iterating on a string not from display properties).
532 (compute_display_string_pos, compute_display_string_end): Fix
533 calculation of the object to scan. Fixes an error when using
534 arrow keys.
535 (next_element_from_buffer): Don't abort when IT_CHARPOS is before
536 base_level_stop; instead, set base_level_stop to BEGV. Fixes
537 crashes in vertical-motion.
538 (next_element_from_buffer): Improve commentary for when
539 the iterator is before prev_stop.
540 (init_iterator): Initialize bidi_p from the default value of
541 bidi-display-reordering, not from buffer-local value. Use the
542 buffer-local value only if initializing for buffer iteration.
543 (handle_invisible_prop): Support invisible properties on strings
544 that are being bidi-reordered.
545 (set_iterator_to_next): Support bidi reordering of C strings and
546 Lisp strings.
547 (next_element_from_string): Support bidi reordering of Lisp
548 strings.
549 (handle_stop_backwards): Support Lisp strings as well.
550 (display_string): Support display of R2L glyph rows. Use
551 IT_STRING_CHARPOS when displaying from a Lisp string.
552 (init_iterator): Don't initialize it->bidi_p for strings
553 here.
554 (reseat_to_string): Initialize it->bidi_p for strings here.
555 (next_element_from_string, next_element_from_c_string)
556 (next_element_from_buffer): Add xassert's for correspondence
557 between IT's object being iterated and it->bidi_it.string
558 structure.
559 (face_before_or_after_it_pos): Support bidi iteration.
560 (next_element_from_c_string): Handle the case of the first string
561 character that is not the first one in the visual order.
562 (get_visually_first_element): New function, refactored from common
563 parts of next_element_from_buffer, next_element_from_string, and
564 next_element_from_c_string.
565 (tool_bar_lines_needed, redisplay_tool_bar)
566 (display_menu_bar): Force left-to-right direction. Add a FIXME
567 comment for making that be controlled by a user option.
568 (push_it, pop_it): Save and restore the state of the
569 bidi iterator. Save and restore the bidi_p flag.
570 (pop_it): Iterate out of display property for string iteration as
571 well.
572 (iterate_out_of_display_property): Support iteration over strings.
573 (handle_single_display_spec): Set up it->bidi_it for iteration
574 over a display string, and call bidi_init_it.
575 (handle_single_display_spec, next_overlay_string)
576 (get_overlay_strings_1, push_display_prop): Set up the bidi
577 iterator for displaying display or overlay strings.
578 (forward_to_next_line_start): Don't use the shortcut if
579 bidi-iterating.
580 (back_to_previous_visible_line_start): If handle_display_prop
581 pushed the iterator stack, restore the internal state of the bidi
582 iterator by calling bidi_pop_it same number of times.
583 (reseat_at_next_visible_line_start): If ON_NEWLINE_P is non-zero,
584 and we are bidi-iterating, don't decrement the iterator position;
585 instead, set the first_elt flag in the bidi iterator, to produce
586 the same effect.
587 (reseat_1): Remove redundant setting of string_from_display_prop_p.
588 (push_display_prop): xassert that we are iterating a buffer.
589 (push_it, pop_it): Save and restore paragraph_embedding member.
590 (handle_single_display_spec, next_overlay_string)
591 (get_overlay_strings_1, reseat_1, reseat_to_string)
592 (push_display_prop): Set up the `unibyte' member of bidi_it.string
593 correctly. Don't assume unibyte strings are not bidi-reordered.
594 (compute_display_string_pos)
595 (compute_display_string_end): Fix handling the case of C string.
596 (push_it, pop_it): Save and restore from_disp_prop_p.
597 (handle_single_display_spec, push_display_prop): Set the
598 from_disp_prop_p flag.
599 (get_overlay_strings_1): Reset the from_disp_prop_p flag.
600 (pop_it): Call iterate_out_of_display_property only if we are
601 popping after iteration over a string that came from a display
602 property. Fix a typo in popping stretch info. Add an assertion
603 for verifying that the iterator position is in sync with the bidi
604 iterator.
605 (handle_single_display_spec, get_overlay_strings_1)
606 (push_display_prop): Fix initialization of paragraph direction for
607 string when that of the parent object is not yet determined.
608 (reseat_1): Call bidi_init_it to resync the bidi
609 iterator with IT's position. (Bug#7616)
610 (find_row_edges): If ROW->start.pos gives position
611 smaller than min_pos, use it as ROW->minpos. (Bug#7616)
612 (handle_stop, back_to_previous_visible_line_start, reseat_1):
613 Reset the from_disp_prop_p flag.
614 (SAVE_IT, RESTORE_IT): New macros.
615 (pos_visible_p, face_before_or_after_it_pos)
616 (back_to_previous_visible_line_start)
617 (move_it_in_display_line_to, move_it_in_display_line)
618 (move_it_to, move_it_vertically_backward, move_it_by_lines)
619 (try_scrolling, redisplay_window, display_line): Use them when
620 saving a temporary copy of the iterator and restoring it back.
621 (back_to_previous_visible_line_start, reseat_1)
622 (init_iterator): Empty the bidi cache "stack".
623 (move_it_in_display_line_to): If iterator ended up at
624 EOL, but we never saw any buffer positions smaller than
625 to_charpos, return MOVE_POS_MATCH_OR_ZV. Fixes vertical cursor
626 motion in bidi-reordered lines.
627 (move_it_in_display_line_to): Record prev_method and prev_pos
628 immediately before the call to set_iterator_to_next. Fixes cursor
629 motion in bidi-reordered lines with stretch glyphs and strings
630 displayed in margins. (Bug#8133) (Bug#8867)
631 Return MOVE_POS_MATCH_OR_ZV only if iterator position is past
632 TO_CHARPOS.
633 (pos_visible_p): Support positions in bidi-reordered lines. Save
634 and restore bidi cache.
635
636 * bidi.c (bidi_level_of_next_char): clen should be EMACS_NT, not int.
637 (bidi_paragraph_info): Delete unused struct.
638 (bidi_cache_idx, bidi_cache_last_idx): Declare EMACS_INT.
639 (bidi_cache_start): New variable.
640 (bidi_cache_reset): Reset bidi_cache_idx to bidi_cache_start, not
641 to zero.
642 (bidi_cache_fetch_state, bidi_cache_search)
643 (bidi_cache_find_level_change, bidi_cache_iterator_state)
644 (bidi_cache_find, bidi_peek_at_next_level)
645 (bidi_level_of_next_char, bidi_find_other_level_edge)
646 (bidi_move_to_visually_next): Compare cache index with
647 bidi_cache_start rather than with zero.
648 (bidi_fetch_char): Accept new argument STRING; all callers
649 changed. Support iteration over a string. Support strings with
650 display properties. Support unibyte strings. Fix the type of
651 `len' according to what STRING_CHAR_AND_LENGTH expects.
652 (bidi_paragraph_init, bidi_resolve_explicit_1)
653 (bidi_resolve_explicit, bidi_resolve_weak)
654 (bidi_level_of_next_char, bidi_move_to_visually_next): Support
655 iteration over a string.
656 (bidi_set_sor_type, bidi_resolve_explicit_1)
657 (bidi_resolve_explicit, bidi_type_of_next_char): ignore_bn_limit
658 can now be zero (for strings); special values 0 and -1 were
659 changed to -1 and -2, respectively.
660 (bidi_char_at_pos): New function.
661 (bidi_paragraph_init, bidi_resolve_explicit, bidi_resolve_weak):
662 Call it instead of FETCH_MULTIBYTE_CHAR.
663 (bidi_move_to_visually_next): Abort if charpos or bytepos were not
664 initialized to valid values.
665 (bidi_init_it): Don't initialize charpos and bytepos with invalid
666 values.
667 (bidi_level_of_next_char): Allow the sentinel "position" to pass
668 the test for valid cached positions. Fix the logic for looking up
669 the sentinel state in the cache. GCPRO the Lisp string we are
670 iterating.
671 (bidi_push_it, bidi_pop_it): New functions.
672 (bidi_initialize): Initialize the bidi cache start stack pointer.
673 (bidi_cache_ensure_space): New function, refactored from part of
674 bidi_cache_iterator_state. Don't assume the required size is just
675 one BIDI_CACHE_CHUNK away.
676 (bidi_cache_start_stack, bidi_push_it): Use IT_STACK_SIZE.
677 (bidi_count_bytes, bidi_char_at_pos): New functions.
678 (bidi_cache_search): Don't assume bidi_cache_last_idx is
679 always valid if bidi_cache_idx is valid.
680 (bidi_cache_find_level_change): xassert that bidi_cache_last_idx
681 is valid if it's going to be used.
682 (bidi_shelve_cache, bidi_unshelve_cache): New functions.
683 (bidi_cache_fetch_state, bidi_cache_search)
c965adc5
EZ
684 (bidi_cache_find_level_change, bidi_cache_ensure_space)
685 (bidi_cache_iterator_state, bidi_cache_find)
686 (bidi_find_other_level_edge, bidi_cache_start_stack): All
687 variables related to cache indices are now EMACS_INT.
688
0bb23927
EZ
689 * dispextern.h (struct bidi_string_data): New structure.
690 (struct bidi_it): New member `string'. Make flag members be 1-bit
691 fields, and put them last in the struct.
692 (compute_display_string_pos, compute_display_string_end): Update
693 prototypes.
694 (bidi_push_it, bidi_pop_it): Add prototypes.
695 (struct iterator_stack_entry): New members bidi_p,
696 paragraph_embedding, and from_disp_prop_p.
697 (struct it): Member bidi_p is now a bit field 1 bit wide.
698 (bidi_shelve_cache, bidi_unshelve_cache): Declare
699 prototypes.
700
701 * .gdbinit (xvectype, xvector, xcompiled, xchartable, xboolvector)
702 (xpr, xfont, xbacktrace): Use "header.size" when accessing vectors
703 and vector-like objects.
704
705 * dispnew.c (buffer_posn_from_coords): Save and restore the bidi
706 cache around display iteration.
707
708 * window.c (Fwindow_end, window_scroll_pixel_based)
709 (displayed_window_lines, Frecenter): Save and restore the bidi
710 cache around display iteration.
711
3bbd2265
LMI
7122011-07-14 Lars Magne Ingebrigtsen <larsi@gnus.org>
713
714 * editfns.c (Fdelete_region): Clarify the use of the named
715 parameters (bug#6788).
716
adc47434
MR
7172011-07-14 Martin Rudalics <rudalics@gmx.at>
718
719 * indent.c (Fvertical_motion): Set and restore w->pointm when
720 saving and restoring the window's buffer (Bug#9006).
721
837c31f8
LMI
7222011-07-13 Lars Magne Ingebrigtsen <larsi@gnus.org>
723
724 * editfns.c (Fstring_to_char): Clarify just what is returned
725 (bug#6576). Text by Eli Zaretskii.
726
ac389d0c
JB
7272011-07-13 Juanma Barranquero <lekktu@gmail.com>
728
729 * gnutls.c (init_gnutls_functions): Honor gnutls_log_level (bug#9059).
730
0be0ce47
EZ
7312011-07-13 Eli Zaretskii <eliz@gnu.org>
732
733 * buffer.c (mmap_find): Fix a typo.
734
cd18e7e3
JB
7352011-07-13 Johan Bockgård <bojohan@gnu.org>
736
737 Fix execution of x selection hooks.
738 * xselect.c (Qx_lost_selection_functions)
739 (Qx_sent_selection_functions): New vars.
740 (syms_of_xselect): DEFSYM them.
741 (x_handle_selection_request): Pass Qx_sent_selection_functions
742 rather than Vx_sent_selection_functions to Frun_hook_with_args.
743 (x_handle_selection_clear,x_clear_frame_selections):
744 Pass Qx_lost_selection_functions rather than
745 Vx_lost_selection_functions to Frun_hook_with_args.
746
47ea7f44
PE
7472011-07-13 Paul Eggert <eggert@cs.ucla.edu>
748
ac389d0c 749 * buffer.c (Fget_buffer_create): Initialize inhibit_shrinking.
2941c447
PE
750 The old code sometimes used this field without initializing it.
751
47ea7f44
PE
752 * alloc.c (gc_sweep): Don't read past end of array.
753 In theory, the old code could also have corrupted Emacs internals,
754 though it'd be very unlikely.
755
bc985c87
AS
7562011-07-12 Andreas Schwab <schwab@linux-m68k.org>
757
758 * character.c (Fcharacterp): Don't advertise optional ignored
ac389d0c 759 argument. (Bug#4026)
bc985c87 760
0cf34688
LMI
7612011-07-12 Lars Magne Ingebrigtsen <larsi@gnus.org>
762
b3dadd76
LMI
763 * keymap.c (syms_of_keymap): Clarify that "modifier" is "modifier
764 key" (bug#4257).
765
0cf34688
LMI
766 * window.c (Fset_window_start): Doc fix (bug#4199).
767 (Fset_window_hscroll): Ditto.
768
270768cd
PE
7692011-07-12 Paul Eggert <eggert@cs.ucla.edu>
770
077e3dda 771 Fix minor new problems caught by GCC 4.6.1.
270768cd 772 * term.c (init_tty): Remove unused local.
490011a6 773 * xsettings.c (store_monospaced_changed): Define this function only
077e3dda 774 if (defined HAVE_GSETTINGS || defined HAVE_GCONF), as it's
490011a6 775 not used otherwise.
270768cd 776
b1f58454
CY
7772011-07-12 Chong Yidong <cyd@stupidchicken.com>
778
779 * xdisp.c (Vresize_mini_windows): Minor doc fix (Bug#3300).
780
22b9578d
LMI
7812011-07-11 Lars Magne Ingebrigtsen <larsi@gnus.org>
782
6e70ab07
LMI
783 * xdisp.c (syms_of_xdisp): Make it explicit that the mini-windows
784 are the mini-buffer and the echo area (bug#3320).
785
22b9578d
LMI
786 * term.c (init_tty): Remove support for supdup, c10 and perq
787 terminals, which are no longer supported (bug#1482).
788
8974cc9f
JB
7892011-07-10 Johan Bockgård <bojohan@gnu.org>
790
791 * xdisp.c (Ftool_bar_lines_needed): Fix WINDOWP check.
792
a560d974
JD
7932011-07-10 Jan Djärv <jan.h.d@swipnet.se>
794
795 * xmenu.c (menu_highlight_callback): Only pass frame to show_help_event
796 for non-popups (Bug#3642).
797
1dae0f0a
AS
7982011-07-10 Andreas Schwab <schwab@linux-m68k.org>
799
268c2c36 800 * alloc.c (reset_malloc_hooks): Protoize.
1dae0f0a 801 * buffer.c (mmap_init, mmap_find, mmap_free_1, mmap_enlarge)
268c2c36
AS
802 (mmap_set_vars, mmap_alloc, mmap_free, mmap_realloc): Likewise.
803 * cm.c (losecursor): Likewise.
1dae0f0a
AS
804 * data.c (fmod): Likewise.
805 * dispnew.c (swap_glyphs_in_rows): Likewise.
806 * emacs.c (memory_warning_signal): Likewise.
807 * floatfns.c (float_error): Likewise.
808 * font.c (check_gstring, check_otf_features, otf_tag_symbol)
809 (otf_open, font_otf_capability, generate_otf_features)
810 (font_otf_DeviceTable, font_otf_ValueRecord, font_otf_Anchor):
811 Likewise.
812 * image.c (pbm_read_file): Likewise.
813 * indent.c (string_display_width): Likewise.
814 * intervals.c (check_for_interval, search_for_interval)
815 (inc_interval_count, count_intervals, root_interval)
816 (adjust_intervals_for_insertion, make_new_interval): Likewise.
817 * lread.c (defalias): Likewise.
268c2c36 818 * ralloc.c (r_alloc_check): Likewise.
1dae0f0a
AS
819 * regex.c (set_image_of_range_1, set_image_of_range)
820 (regex_grow_registers): Likewise.
821 * sysdep.c (strerror): Likewise.
822 * termcap.c (valid_filename_p, tprint, main): Likewise.
823 * tparam.c (main): Likewise.
824 * unexhp9k800.c (run_time_remap, save_data_space)
825 (update_file_ptrs, read_header, write_header, calculate_checksum)
826 (copy_file, copy_rest, display_header): Likewise.
827 * widget.c (mark_shell_size_user_specified, create_frame_gcs):
828 Likewise.
829 * xdisp.c (check_it): Likewise.
830 * xfaces.c (register_color, unregister_color, unregister_colors):
831 Likewise.
832 * xfns.c (print_fontset_result): Likewise.
833 * xrdb.c (member, fatal, main): Likewise.
834
99033785
PE
8352011-07-10 Paul Eggert <eggert@cs.ucla.edu>
836
837 Fix minor problems found by static checking (Bug#9031).
838 * chartab.c (char_table_set_range, map_sub_char_table):
839 Remove unused locals.
840 (uniprop_table): Now static.
841 * composite.c (_work_char): Remove unused static var.
842
9cb2ac56
JB
8432011-07-09 Juanma Barranquero <lekktu@gmail.com>
844
845 * chartab.c (uniprop_table_uncompress): Remove unused local variable.
846
f25661f0
JD
8472011-07-09 Jan Djärv <jan.h.d@swipnet.se>
848
849 * gtkutil.c (qttip_cb): Remove code without function.
850
8278c4fe
EZ
8512011-07-09 Eli Zaretskii <eliz@gnu.org>
852
853 * w32.c (pthread_sigmask): New stub.
854
1692ae2d 8552011-07-08 Paul Eggert <eggert@cs.ucla.edu>
123403e4 856
8a6ebd58 857 Use pthread_sigmask, not sigprocmask (Bug#9010).
123403e4
PE
858 sigprocmask is portable only for single-threaded applications, and
859 Emacs can be multi-threaded when it uses GTK.
1301ac26
PE
860 * Makefile.in (LIB_PTHREAD_SIGMASK): New macro.
861 (LIBES): Use it.
862 * callproc.c (Fcall_process):
863 * process.c (create_process):
864 * sysdep.c (sys_sigblock, sys_sigunblock, sys_sigsetmask):
865 Use pthread_sigmask, not sigprocmask.
123403e4 866
1b854618
JD
8672011-07-08 Jan Djärv <jan.h.d@swipnet.se>
868
869 * gtkutil.c (qttip_cb): Set line wrap to FALSE for tooltip widget.
870 (xg_prepare_tooltip): Revert text in x->ttip_lbl, margins was
871 wrong (Bug#8591).
872
3fe4b549
JD
8732011-07-08 Jan Djärv <jan.h.d@swipnet.se>
874
0ce7e563
JD
875 * gtkutil.c (xg_prepare_tooltip): Fix indentation and comment.
876 Put text in x->ttip_lbl instead of gtk_tooltip_set_text (Bug#8591).
877 (xg_hide_tooltip): Fix comment.
878
3fe4b549
JD
879 * nsterm.m (initFrameFromEmacs): Don't use ns_return_types
880 in registerServicesMenuSendTypes.
881 (validRequestorForSendType): Don't check ns_return_types.
882
883 * nsfns.m (Fx_open_connection): Put NSStringPboardType into
884 ns_return_type.
885
5df75e47
JR
8862011-07-08 Jason Rumney <jasonr@gnu.org>
887
888 * w32fns.c (w32_wnd_proc) [WM_TIMER, WM_SET_CURSOR]: Avoid using
889 frame struct members of non-existent frames (Bug#6284).
890
699c10bd
JD
8912011-07-08 Jan Djärv <jan.h.d@swipnet.se>
892
4393663b
JD
893 * nsterm.m (keyDown): Call to wantsToDelayTextChangeNotifications and
894 variable firstTime not needed on OSX >= 10.6.
895 (setPosition): setFloatValue:knobProportion: is deprecated on OSX
896 >= 10.5. Use setKnobProportion, setDoubleValue.
897
898 * nsterm.h (MAC_OS_X_VERSION_10_3, MAC_OS_X_VERSION_10_4)
899 (MAC_OS_X_VERSION_10_5): Define if not defined.
900 (EmacsView, EmacsTooltip): Implements NSWindowDelegate on OSX >= 10.6.
901 (EmacsMenu): Implements NSMenuDelegate on OSX >= 10.6.
902 (EmacsToolbar): Implements NSToolbarDelegate on OSX >= 10.6.
903
904 * nsselect.m (ns_string_from_pasteboard): Don't use deprecated methods
905 cString and lossyCString on OSX >= 10.4
906
907 * nsmenu.m (fillWithWidgetValue): Don't use depercated method
908 sizeToFit on OSX >= 10.2.
909
910 * nsimage.m (allocInitFromFile): Don't use deprecated method
911 bestRepresentationForDevice on OSX >= 10.6.
912
913 * nsfns.m (check_ns_display_info): Cast to long and use %ld in error
914 to avoid warning.
915
916 * emacs.c: Declare unexec_init_emacs_zone.
917
a63e0781
JD
918 * nsgui.h: Fix compiler warning about gnulib redefining verify.
919
699c10bd
JD
920 * nsselect.m (ns_get_local_selection): Change to extern (Bug#8842).
921
922 * nsmenu.m (ns_update_menubar): Remove useless setDelegate call
923 on svcsMenu (Bug#8842).
924
925 * nsfns.m (Fx_open_connection): Remove NSStringPboardType from
926 ns_return_types.
927 (Fns_list_services): Just return Qnil on 10.6, code not working there.
928
929 * nsterm.m (QUTF8_STRING): Declare.
930 (initFrameFromEmacs): Call registerServicesMenuSendTypes.
931 (validRequestorForSendType): Return type is (id).
932 Change indexOfObjectIdenticalTo to indexOfObject.
933 Check if we have local selection before returning self (Bug#8842).
934 (writeSelectionToPasteboard): Put local selection into paste board
935 if we have a local selection (Bug#8842).
936 (syms_of_nsterm): DEFSYM QUTF8_STRING.
937
938 * nsterm.h (MAC_OS_X_VERSION_10_6): Define here instead of nsterm.m.
939 (ns_get_local_selection): Declare.
940
54e10184
LMI
9412011-07-07 Lars Magne Ingebrigtsen <larsi@gnus.org>
942
9888ff71
LMI
943 * keymap.c (describe_map_tree): Don't insert a double newline at
944 the end of the buffer (bug#1169) and return whether we inserted
945 something.
946
54e10184
LMI
947 * callint.c (Fcall_interactively): Change "reading args" to
948 "providing args" to try to clarify what it does (bug#1010).
949
15fa4783
KH
9502011-07-07 Kenichi Handa <handa@m17n.org>
951
952 * composite.c (composition_compute_stop_pos): Ignore a static
953 composition starting before CHARPOS (Bug#8915).
954
955 * xdisp.c (handle_composition_prop): Likewise.
956
a8815b00
EZ
9572011-07-07 Eli Zaretskii <eliz@gnu.org>
958
959 * term.c (produce_glyphs) <xassert>: Allow IT_GLYPHLESS in it->what.
960 (Bug#9015)
961
ef7b981d 9622011-07-07 Kenichi Handa <handa@m17n.org>
c805dec0
KH
963
964 * character.h (unicode_category_t): New enum type.
965
966 * chartab.c (uniprop_decoder_t, uniprop_encoder_t): New types.
967 (Qchar_code_property_table): New variable.
968 (UNIPROP_TABLE_P, UNIPROP_GET_DECODER)
969 (UNIPROP_COMPRESSED_FORM_P): New macros.
970 (char_table_ascii): Uncompress the compressed values.
971 (sub_char_table_ref): New arg is_uniprop. Callers changed.
972 Uncompress the compressed values.
ac389d0c 973 (sub_char_table_ref_and_range): Likewise.
c805dec0
KH
974 (char_table_ref_and_range): Uncompress the compressed values.
975 (sub_char_table_set): New arg is_uniprop. Callers changed.
976 Uncompress the compressed values.
977 (sub_char_table_set_range): Args changed. Callers changed.
978 (char_table_set_range): Adjuted for the above change.
979 (map_sub_char_table): Delete args default_val and parent. Add arg
980 top. Give decoded values to a Lisp function.
981 (map_char_table): Adjusted for the above change. Give decoded
982 values to a Lisp function. Gcpro more variables.
983 (uniprop_table_uncompress)
984 (uniprop_decode_value_run_length): New functions.
985 (uniprop_decoder, uniprop_decoder_count): New variables.
986 (uniprop_get_decoder, uniprop_encode_value_character)
987 (uniprop_encode_value_run_length, uniprop_encode_value_numeric):
988 New functions.
989 (uniprop_encoder, uniprop_encoder_count): New variables.
990 (uniprop_get_encoder, uniprop_table)
991 (Funicode_property_table_internal, Fget_unicode_property_internal)
992 (Fput_unicode_property_internal): New functions.
993 (syms_of_chartab): DEFSYM Qchar_code_property_table, defsubr
994 Sunicode_property_table_internal, Sget_unicode_property_internal,
995 and Sput_unicode_property_internal. Defvar_lisp
996 char-code-property-alist.
997
998 * composite.c (CHAR_COMPOSABLE_P): Adjusted for the change of
999 Vunicode_category_table.
1000
1001 * font.c (font_range): Adjusted for the change of
1002 Vunicode_category_table.
1003
76b397fb
DN
10042011-07-07 Dan Nicolaescu <dann@ics.uci.edu>
1005
1006 * m/iris4d.h: Remove file, move contents ...
1007 * s/irix6-5.h: ... here.
1008
22b4128e
PE
10092011-07-06 Paul Eggert <eggert@cs.ucla.edu>
1010
1011 Remove unportable assumption about struct layout (Bug#8884).
8a5c77bb
PE
1012 * alloc.c (mark_buffer):
1013 * buffer.c (reset_buffer_local_variables, Fbuffer_local_variables)
1014 (clone_per_buffer_values): Don't assume that
22b4128e
PE
1015 sizeof (struct buffer) is a multiple of sizeof (Lisp_Object).
1016 This isn't true in general, and it's particularly not true
1017 if Emacs is configured with --with-wide-int.
1018 * buffer.h (FIRST_FIELD_PER_BUFFER, LAST_FIELD_PER_BUFFER):
1019 New macros, used in the buffer.c change.
1020
869795d6
JD
10212011-07-05 Jan Djärv <jan.h.d@swipnet.se>
1022
1023 * xsettings.c: Use both GConf and GSettings if both are available.
1024 (store_config_changed_event): Add comment.
1025 (dpyinfo_valid, store_font_name_changed, map_tool_bar_style)
1026 (store_tool_bar_style_changed): New functions.
1027 (store_monospaced_changed): Add comment. Call dpyinfo_valid.
1028 (struct xsettings): Move font inside HAVE_XFT.
1029 (GSETTINGS_TOOL_BAR_STYLE, GSETTINGS_FONT_NAME): New defines.
1030 (GSETTINGS_MONO_FONT): Renamed from SYSTEM_MONO_FONT.
1031 Move inside HAVE_XFT.
1032 (something_changed_gsettingsCB): Renamed from something_changedCB.
1033 Check for changes in GSETTINGS_TOOL_BAR_STYLE and GSETTINGS_FONT_NAME
1034 also.
1035 (GCONF_TOOL_BAR_STYLE, GCONF_FONT_NAME): New defines.
1036 (GCONF_MONO_FONT): Renamed from SYSTEM_MONO_FONT. Move inside HAVE_XFT.
1037 (something_changed_gconfCB): Renamed from something_changedCB.
1038 Check for changes in GCONF_TOOL_BAR_STYLE and GCONF_FONT_NAME also.
1039 (parse_settings): Move check for font inside HAVE_XFT.
1040 (read_settings, apply_xft_settings): Add comment.
1041 (read_and_apply_settings): Add comment. Call map_tool_bar_style and
1042 store_tool_bar_style_changed. Move check for font inside HAVE_XFT and
1043 call store_font_name_changed.
1044 (xft_settings_event): Add comment.
1045 (init_gsettings): Add comment. Get values for GSETTINGS_TOOL_BAR_STYLE
1046 and GSETTINGS_FONT_NAME. Move check for fonts within HAVE_XFT.
1047 (init_gconf): Add comment. Get values for GCONF_TOOL_BAR_STYLE
1048 and GCONF_FONT_NAME. Move check for fonts within HAVE_XFT.
1049 (xsettings_initialize): Call init_gsettings last.
1050 (xsettings_get_system_font, xsettings_get_system_normal_font): Add
1051 comment.
1052
d8ed26bd
PE
10532011-07-05 Paul Eggert <eggert@cs.ucla.edu>
1054
1055 Random fixes. E.g., (random) never returned negative values.
1056 * fns.c (Frandom): Use GET_EMACS_TIME for random seed, and add the
1057 subseconds part to the entropy, as that's a bit more random.
1058 Prefer signed to unsigned, since the signedness doesn't matter and
1059 in general we prefer signed. When given a limit, use a
1060 denominator equal to INTMASK + 1, not to VALMASK + 1, because the
1061 latter isn't right if USE_2_TAGS_FOR_INTS.
1062 * sysdep.c (get_random): Return a value in the range 0..INTMASK,
1063 not 0..VALMASK. Don't discard "excess" bits that random () returns.
1064
cabf1cac
SM
10652011-07-04 Stefan Monnier <monnier@iro.umontreal.ca>
1066
1067 * textprop.c (text_property_stickiness):
1068 Obey Vtext_property_default_nonsticky.
1069 (syms_of_textprop): Add `display' to Vtext_property_default_nonsticky.
1070 * w32fns.c (syms_of_w32fns):
1071 * xfns.c (syms_of_xfns): Don't Add `display' since it's there by default.
1072
6e9b2be9
PE
10732011-07-04 Paul Eggert <eggert@cs.ucla.edu>
1074
1075 * fileio.c (barf_or_query_if_file_exists): Use S_ISDIR.
1076 This is more efficient than Ffile_directory_p and avoids a minor race.
1077
90186c68
LMI
10782011-07-04 Lars Magne Ingebrigtsen <larsi@gnus.org>
1079
7c301272
LMI
1080 * buffer.c (Foverlay_put): Say what the return value is
1081 (bug#7835).
1082
c4f2d8d4
LMI
1083 * fileio.c (barf_or_query_if_file_exists): Check first if the file
1084 is a directory before asking whether to use the file name
1085 (bug#7564).
ad637907
LMI
1086 (barf_or_query_if_file_exists): Make the "File is a directory"
1087 error be more correct.
c4f2d8d4 1088
90186c68
LMI
1089 * fns.c (Frequire): Remove the mention of the .gz files, since
1090 that's installation-specific, but keep the mention of
1091 `get-load-suffixes'.
1092
da64016e
PE
10932011-07-04 Paul Eggert <eggert@cs.ucla.edu>
1094
1095 * editfns.c (Fformat_time_string): Don't assume strlen fits in int.
1096 Report string overflow if the output is too long.
1097
7d47b580
JB
10982011-07-04 Juanma Barranquero <lekktu@gmail.com>
1099
a555cb87
JB
1100 * gnutls.c (Fgnutls_boot): Don't mention :verify-error.
1101 (syms_of_gnutls): Remove duplicate DEFSYM for
1102 Qgnutls_bootprop_verify_hostname_error, an error for
1103 Qgnutls_bootprop_verify_error (which is no longer used).
1104
7d47b580
JB
1105 * eval.c (find_handler_clause): Remove parameters `sig' and `data',
1106 unused since 2011-01-26T20:02:07Z!monnier@iro.umontreal.ca. All callers changed.
1107 Also (re)move comments that are misplaced or no longer relevant.
1108
1e49bfab
LMI
11092011-07-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
1110
1111 * callint.c (Finteractive): Clarify the meaning of "@" (bug#8813).
1112
1485f4c0
CY
11132011-07-03 Chong Yidong <cyd@stupidchicken.com>
1114
1115 * xfaces.c (Finternal_merge_in_global_face): Modify the foreground
1116 and background color parameters if they have been changed.
1117
a9ab721e
LMI
11182011-07-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
1119
1120 * editfns.c (Fformat): Clarify the - and 0 flags (bug#6659).
1121
cf7cff57
PE
11222011-07-03 Paul Eggert <eggert@cs.ucla.edu>
1123
2e13213d
PE
1124 * xsettings.c (SYSTEM_FONT): Define only when used.
1125 No need to define when HAVE_GSETTINGS || !HAVE_XFT.
1126
cf7cff57
PE
1127 * keymap.c (access_keymap_1): Now static.
1128
7a8e04f7
CY
11292011-07-02 Chong Yidong <cyd@stupidchicken.com>
1130
1131 * keyboard.c (command_loop_1): If a down-mouse event is unbound,
1132 leave any prefix arg for the up event (Bug#1586).
1133
61352f62
LMI
11342011-07-02 Lars Magne Ingebrigtsen <larsi@gnus.org>
1135
69bb1ef7
LMI
1136 * lread.c (syms_of_lread): Mention single symbols defined by
1137 `defvar' or `defconst' (bug#7154).
1138
61352f62 1139 * fns.c (Frequire): Mention .el.gz files (bug#7314).
7b3747f9 1140 (Frequire): Mention get-load-suffixes.
61352f62 1141
28545e04
MR
11422011-07-02 Martin Rudalics <rudalics@gmx.at>
1143
1144 * window.h (window): Remove clone_number slot.
1145 * window.c (Fwindow_clone_number, Fset_window_clone_number):
1146 Remove.
1147 (make_parent_window, make_window, saved_window)
1148 (Fset_window_configuration, save_window_save): Don't deal with
1149 clone numbers.
1150 * buffer.c (Qclone_number): Remove declaration.
1151 (sort_overlays, overlay_strings): Don't deal with clone numbers.
1152
3349e122
SM
11532011-07-02 Stefan Monnier <monnier@iro.umontreal.ca>
1154
1155 Add multiple inheritance to keymaps.
1156 * keymap.c (Fmake_composed_keymap): New function.
1157 (Fset_keymap_parent): Simplify.
1158 (fix_submap_inheritance): Remove.
1159 (access_keymap_1): New function extracted from access_keymap to handle
1160 embedded parents and handle lists of maps.
1161 (access_keymap): Use it.
1162 (Fkeymap_prompt, map_keymap_internal, map_keymap, store_in_keymap)
1163 (Fcopy_keymap): Handle embedded parents.
1164 (Fcommand_remapping, define_as_prefix): Simplify.
1165 (Fkey_binding): Simplify.
1166 (syms_of_keymap): Move minibuffer-local-completion-map,
1167 minibuffer-local-filename-completion-map,
1168 minibuffer-local-must-match-map, and
1169 minibuffer-local-filename-must-match-map to Elisp.
1170 (syms_of_keymap): Defsubr make-composed-keymap.
1171 * keyboard.c (menu_bar_items): Use map_keymap_canonical.
1172 (parse_menu_item): Trivial simplification.
1173
3279eb87
GM
11742011-07-01 Glenn Morris <rgm@gnu.org>
1175
1176 * Makefile.in (SETTINGS_LIBS): Fix typo.
1177
4550efdf
KI
11782011-07-01 Kazuhiro Ito <kzhr@d1.dion.ne.jp> (tiny patch)
1179
1180 * coding.c (Fencode_coding_string): Record the last coding system
1181 used, as the function doc string says (bug#8738).
1182
0949d2b6
JD
11832011-07-01 Jan Djärv <jan.h.d@swipnet.se>
1184
1185 * xsettings.c (store_monospaced_changed): Take new font as arg and
1186 check for change against current_mono_font.
1187 (EMACS_TYPE_SETTINGS): Remove this and related defines.
1188 (emacs_settings_constructor, emacs_settings_get_property)
1189 (emacs_settings_set_property, emacs_settings_class_init)
1190 (emacs_settings_init, gsettings_obj): Remove.
1191 (something_changedCB): New function for HAVE_GSETTINGS.
1192 (something_changedCB): HAVE_GCONF: Call store_monospaced_changed
1193 with value as argument.
1194 (init_gsettings): Check that GSETTINGS_SCHEMA exists before calling
1195 g_settings_new (Bug#8967). Do not create gsettings_obj.
9173deec 1196 Remove calls to g_settings_bind. Connect something_changedCB to
0949d2b6
JD
1197 "changed".
1198
1199 * xgselect.c: Add defined (HAVE_GSETTINGS).
1200 (xgselect_initialize): Ditto.
1201
1202 * process.c: Add defined (HAVE_GSETTINGS) for xgselect.h
1203 (wait_reading_process_output): Add defined (HAVE_GSETTINGS) for
1204 xg_select.
1205
bbc6b304
PE
12062011-07-01 Paul Eggert <eggert@cs.ucla.edu>
1207
1208 * eval.c (struct backtrace): Simplify and port the data structure.
1209 Do not assume that "int nargs : BITS_PER_INT - 2;" produces a
1210 signed bit field, as this assumption is not portable and it makes
1211 Emacs crash when compiled with Sun C 5.8 on sparc. Do not use
1212 "char debug_on_exit : 1" as this is not portable either; instead,
1213 use the portable "unsigned int debug_on_exit : 1". Remove unused
1214 member evalargs. Remove obsolete comments about cc bombing out.
1215
9851bfc5
JD
12162011-06-30 Jan Djärv <jan.h.d@swipnet.se>
1217
51bb811f 1218 * xsettings.c: Include glib-object.h, gio/gio.h if HAVE_GSETTINGS.
9851bfc5
JD
1219 Let HAVE_GSETTINGS override HAVE_GCONF.
1220 (store_monospaced_changed): New function.
1221 (EMACS_SETTINGS): A new type derived from GObject to handle
1222 GSettings notifications.
1223 (emacs_settings_constructor, emacs_settings_get_property)
1224 (emacs_settings_set_property, emacs_settings_class_init):
1225 New functions.
1226 (gsettings_client, gsettings_obj): New variables.
1227 (GSETTINGS_SCHEMA): New define.
1228 (something_changedCB): Call store_monospaced_changed.
1229 (init_gsettings): New function.
1230 (xsettings_initialize): Call init_gsettings.
1231 (syms_of_xsettings): Initialize gsettings_client, gsettings_obj
1232 to NULL.
1233
1234 * Makefile.in (SETTINGS_CFLAGS, SETTINGS_LIBS): Renamed from
1235 GCONF_CFLAGS/LIBS.
1236
5386012d
MR
12372011-06-29 Martin Rudalics <rudalics@gmx.at>
1238
1239 * window.c (resize_root_window, grow_mini_window)
1240 (shrink_mini_window): Rename Qresize_root_window to
1241 Qwindow_resize_root_window and Qresize_root_window_vertically to
1242 Qwindow_resize_root_window_vertically.
1243
f13e0b08
PE
12442011-06-28 Paul Eggert <eggert@cs.ucla.edu>
1245
1246 * gnutls.c (Qgnutls_bootprop_verify_error): Remove unused var.
1247
94515237
JB
12482011-06-27 Juanma Barranquero <lekktu@gmail.com>
1249
1250 * makefile.w32-in: Redesign dependencies so they reflect more
1251 clearly which files are directly included by each source file,
1252 and not through other includes.
1253
e43b6e43
MR
12542011-06-27 Martin Rudalics <rudalics@gmx.at>
1255
1256 * buffer.c (Qclone_number): Declare static and DEFSYM it.
1257 (sort_overlays, overlay_strings): When an overlay's clone number
1258 matches the window's clone number process the overlay even if
1259 the overlay's window property doesn't match the current window.
1260
d68443dc
MR
1261 * window.c (Fwindow_vchild): Rename to Fwindow_top_child.
1262 (Fwindow_hchild): Rename to Fwindow_left_child.
1263 (Fwindow_next): Rename to Fwindow_next_sibling.
1264 (Fwindow_prev): Rename to Fwindow_prev_sibling.
d615d6d2
MR
1265 (resize_window_check): Rename to window_resize_check.
1266 (resize_window_apply): Rename to window_resize_apply.
1267 (Fresize_window_apply): Rename to Fwindow_resize_apply.
1268 (Fdelete_other_windows_internal, resize_frame_windows)
1269 (Fsplit_window_internal, Fdelete_window_internal)
1270 (grow_mini_window, shrink_mini_window)
1271 (Fresize_mini_window_internal): Fix callers accordingly.
d68443dc 1272
c7e73be5
JD
12732011-06-26 Jan Djärv <jan.h.d@swipnet.se>
1274
1275 * emacsgtkfixed.h: State that this is only used with Gtk+3.
1276 (emacs_fixed_set_min_size): Remove.
1277 (emacs_fixed_new): Take frame as argument.
1278
1279 * emacsgtkfixed.c: State that this is only used with Gtk+3.
1280 (_EmacsFixedPrivate): Remove minwidth/height.
1281 Add struct frame *f.
1282 (emacs_fixed_init): Initialize priv->f.
1283 (get_parent_class, emacs_fixed_set_min_size): Remove.
1284 (emacs_fixed_new): Set priv->f to argument.
1285 (emacs_fixed_get_preferred_width)
1286 (emacs_fixed_get_preferred_height): Use min_width/height from
1287 frames size_hint to set minimum and natural (Bug#8919).
1288 (XSetWMSizeHints, XSetWMNormalHints): Override these functions
1289 and use min_width/height from frames size_hint to set
1290 min_width/height (Bug#8919).
1291
1292 * gtkutil.c (xg_create_frame_widgets): Pass f to emacs_fixed_new.
9173deec
JB
1293 (x_wm_set_size_hint): Remove call to emacs_fixed_set_min_size.
1294 Fix indentation.
c7e73be5 1295
cf99dcf8
EZ
12962011-06-26 Eli Zaretskii <eliz@gnu.org>
1297
1298 * bidi.c (bidi_paragraph_init): Test for ZV_BYTE before calling
1299 bidi_at_paragraph_end, since fast_looking_at doesn't like to be
1300 called at ZV.
1301
029529ac
CY
13022011-06-26 Chong Yidong <cyd@stupidchicken.com>
1303
1304 * process.c (wait_reading_process_output): Bypass select if
1305 waiting for a cell while ignoring keyboard input, and input is
1306 pending. Suggested by Jan Djärv (Bug#8869).
1307
7a7ef429
PE
13082011-06-25 Paul Eggert <eggert@cs.ucla.edu>
1309
1310 Use gnulib's dup2 module instead of rolling our own.
1311 * sysdep.c (dup2) [!HAVE_DUP2]: Remove; gnulib now does this.
1312
11fdef7d 13132011-06-25 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
989b42d2
YM
1314
1315 * dispnew.c (scrolling_window): Before scrolling, turn off a
1316 mouse-highlight in the window being scrolled.
1317
cd3520a4
JB
13182011-06-24 Juanma Barranquero <lekktu@gmail.com>
1319
1320 Move DEFSYM to lisp.h and use everywhere.
1321
1322 * character.h (DEFSYM): Move declaration...
1323 * lisp.h (DEFSYM): ...here.
1324
1325 * gnutls.c:
1326 * minibuf.c:
1327 * w32menu.c:
1328 * w32proc.c:
1329 * w32select.c: Don't include character.h.
1330
1331 * alloc.c (syms_of_alloc):
1332 * buffer.c (syms_of_buffer):
1333 * bytecode.c (syms_of_bytecode):
1334 * callint.c (syms_of_callint):
1335 * casefiddle.c (syms_of_casefiddle):
1336 * casetab.c (init_casetab_once):
1337 * category.c (init_category_once, syms_of_category):
1338 * ccl.c (syms_of_ccl):
1339 * cmds.c (syms_of_cmds):
1340 * composite.c (syms_of_composite):
1341 * dbusbind.c (syms_of_dbusbind):
1342 * dired.c (syms_of_dired):
1343 * dispnew.c (syms_of_display):
1344 * doc.c (syms_of_doc):
1345 * editfns.c (syms_of_editfns):
1346 * emacs.c (syms_of_emacs):
1347 * eval.c (syms_of_eval):
1348 * fileio.c (syms_of_fileio):
1349 * fns.c (syms_of_fns):
1350 * frame.c (syms_of_frame):
1351 * fringe.c (syms_of_fringe):
1352 * insdel.c (syms_of_insdel):
1353 * keymap.c (syms_of_keymap):
1354 * lread.c (init_obarray, syms_of_lread):
1355 * macros.c (syms_of_macros):
1356 * msdos.c (syms_of_msdos):
1357 * print.c (syms_of_print):
1358 * process.c (syms_of_process):
1359 * search.c (syms_of_search):
1360 * sound.c (syms_of_sound):
1361 * syntax.c (init_syntax_once, syms_of_syntax):
1362 * terminal.c (syms_of_terminal):
1363 * textprop.c (syms_of_textprop):
1364 * undo.c (syms_of_undo):
1365 * w32.c (globals_of_w32):
1366 * window.c (syms_of_window):
1367 * xdisp.c (syms_of_xdisp):
1368 * xfaces.c (syms_of_xfaces):
1369 * xfns.c (syms_of_xfns):
1370 * xmenu.c (syms_of_xmenu):
1371 * xsettings.c (syms_of_xsettings):
1372 * xterm.c (syms_of_xterm): Use DEFSYM.
1373
4228cf16
TZ
13742011-06-24 Teodor Zlatanov <tzz@lifelogs.com>
1375
cd3520a4 1376 * gnutls.c (syms_of_gnutls): Use the DEFSYM macro from character.h.
4228cf16 1377
7fcccf1e
PE
13782011-06-23 Paul Eggert <eggert@cs.ucla.edu>
1379
7efb4e0e
PE
1380 Integer and buffer overflow fixes (Bug#8873).
1381
ff5844ad
PE
1382 * print.c (printchar, strout): Check for string overflow.
1383 (PRINTPREPARE, printchar, strout):
1384 Don't set size unless allocation succeeds.
1385
90532f02
PE
1386 * minibuf.c (read_minibuf_noninteractive): Use ptrdiff_t, not int,
1387 for sizes. Check for string overflow more accurately.
1388 Simplify newline removal at end; this suppresses a GCC 4.6.0 warning.
1389
6d84508d
PE
1390 * macros.c: Integer and buffer overflow fixes.
1391 * keyboard.h (struct keyboard.kbd_macro_bufsize):
1392 * macros.c (Fstart_kbd_macro, store_kbd_macro_char):
1393 Use ptrdiff_t, not int, for sizes.
1394 Don't increment bufsize until after realloc succeeds.
1395 Check for size-calculation overflow.
1396 (Fstart_kbd_macro): Use EMACS_INT, not int, for XINT result.
1397
437b2cb4
PE
1398 * lisp.h (DEFVAR_KBOARD): Use offsetof instead of char * finagling.
1399
8b9ac8b4
PE
1400 * lread.c: Integer overflow fixes.
1401 (read_integer): Radix is now EMACS_INT, not int,
1402 to improve quality of diagnostics for out-of-range radices.
1403 Calculate buffer size correctly for out-of-range radices.
1404 (read1): Check for integer overflow in radices, and in
1405 read-circle numbers.
82cb60d3
PE
1406 (read_escape): Avoid int overflow.
1407 (Fload, openp, read_buffer_size, read1)
1408 (substitute_object_recurse, read_vector, read_list, map_obarray):
1409 Use ptrdiff_t, not int, for sizes.
1410 (read1): Use EMACS_INT, not int, for sizes.
20270765 1411 Check for size overflow.
8b9ac8b4 1412
7fcccf1e
PE
1413 * image.c (cache_image): Check for size arithmetic overflow.
1414
bfbbd7e7
PE
1415 * lread.c: Integer overflow issues.
1416 (saved_doc_string_size, saved_doc_string_length)
1417 (prev_saved_doc_string_size, prev_saved_doc_string_length):
1418 Now ptrdiff_t, not int.
1419 (read1): Don't assume doc string length fits in int. Check for
1420 out-of-range doc string lengths.
1421 (read_list): Don't assume file position fits in int.
39019e54 1422 (read_escape): Check for hex character overflow.
bfbbd7e7 1423
4e323265
LL
14242011-06-22 Leo Liu <sdl.web@gmail.com>
1425
1426 * minibuf.c (Fcompleting_read_default, Vcompleting_read_function):
1427 Move to minibuffer.el.
1428
85fece3e
PE
14292011-06-22 Paul Eggert <eggert@cs.ucla.edu>
1430
20b84ce9 1431 Fixes for GLYPH_DEBUG found by GCC 4.6.0 static checking.
85fece3e
PE
1432 The following patches are for when GLYPH_DEBUG && !XASSERT.
1433 * dispextern.h (trace_redisplay_p, dump_glyph_string):
1434 * dispnew.c (flush_stdout):
1435 * xdisp.c (dump_glyph_row, dump_glyph_matrix, dump_glyph):
1436 Mark as externally visible.
1437 * dispnew.c (check_window_matrix_pointers): Now static.
1438 * dispnew.c (window_to_frame_vpos):
1439 * xfns.c (unwind_create_frame):
1440 * xterm.c (x_check_font): Remove unused local.
1441 * scroll.c (CHECK_BOUNDS):
1442 * xfaces.c (cache_fache): Rename local to avoid shadowing.
1443 * xfns.c, w32fns.c (image_cache_refcount, dpyinfo_refcount): Now static.
1444 * xdisp.c (check_window_end): Now a no-op if !XASSERTS.
1445 (debug_first_unchanged_at_end_vpos, debug_last_unchanged_at_beg_vpos)
1446 (debug_dvpos, debug_dy, debug_delta, debug_delta_bytes, debug_end_vpos):
1447 Now static.
1448 (debug_method_add): Use va_list and vsprintf rather than relying
1449 on undefined behavior with wrong number of arguments.
1450 (dump_glyph, dump_glyph_row, Fdump_glyph_matrix):
1451 Don't assume ptrdiff_t and EMACS_INT are the same width as int.
1452 In this code, it's OK to assume C99 behavior for ptrdiff_t formats
1453 since we're not interested in debugging glyphs with old libraries.
1454 * xfaces.c (cache_face): Move debugging code earlier; this pacifies
1455 GCC 4.6.0's static checking.
1456
0766b489
PE
14572011-06-22 Paul Eggert <eggert@cs.ucla.edu>
1458
31fd4b32
PE
1459 Integer overflow and signedness fixes (Bug#8873).
1460 A few related buffer overrun fixes, too.
1461
b79e8648
PE
1462 * font.c (font_score): Use EMACS_INT, not int, to store XINT value.
1463
0766b489
PE
1464 * dispextern.h (struct face.stipple):
1465 * image.c (x_bitmap_height, x_bitmap_width, x_bitmap_pixmap)
1466 (x_bitmap_mask, x_allocate_bitmap_record)
1467 (x_create_bitmap_from_data, x_create_bitmap_from_file)
1468 (x_destroy_bitmap, x_destroy_all_bitmaps, x_create_bitmap_mask)
1469 (x_create_bitmap_from_xpm_data):
1470 * nsterm.h (struct ns_display_info.bitmaps_size, .bitmaps_last):
1471 * w32term.h (struct w32_display_info.icon_bitmap_id, .bitmaps_size)
1472 (.bitmaps_last):
1473 * xfaces.c (load_pixmap):
1474 * xterm.c (x_bitmap_icon, x_wm_set_icon_pixmap):
1475 * xterm.h (struct x_display_info.icon_bitmap_id, .bitmaps_size)
1476 (.bitmaps_last, struct x_output.icon_bitmap):
1477 Use ptrdiff_t, not int, for bitmap indexes.
1478 (x_allocate_bitmap_record): Check for size overflow.
1479 * dispextern.h, lisp.h: Adjust to API changes elsewhere.
1480
b081724f
PE
1481 Use ptrdiff_t, not int, for overlay counts.
1482 * buffer.h (overlays_at, sort_overlays, GET_OVERLAYS_AT):
1483 * editfns.c (overlays_around, get_pos_property):
1484 * textprop.c (get_char_property_and_overlay):
1485 * xdisp.c (next_overlay_change, note_mouse_highlight):
1486 * xfaces.c (face_at_buffer_position):
21514da7
PE
1487 * buffer.c (OVERLAY_COUNT_MAX): New macro.
1488 (overlays_at, overlays_in, sort_overlays, Foverlays_at)
1489 (Fnext_overlay_change, Fprevious_overlay_change)
1490 (mouse_face_overlay_overlaps, Foverlays_in):
b081724f 1491 Use ptrdiff_t, not int, for sizes.
21514da7 1492 (overlays_at, overlays_in): Check for size-calculation overflow.
b081724f 1493
3de73e5e
PE
1494 * xterm.c (xim_initialize, same_x_server): Strlen may not fit in int.
1495
2606c57b
PE
1496 * xsmfns.c (smc_save_yourself_CB, x_session_initialize): Avoid strlen.
1497 (x_session_initialize): Do not assume string length fits in int.
1498
aaafe47a
PE
1499 * xsettings.c (apply_xft_settings): Fix potential buffer overrun.
1500 This is unlikely, but can occur if DPI is outlandish.
1501
2674ddc8 1502 * xsettings.c (Ffont_get_system_normal_font, Ffont_get_system_font):
3a5077c5
PE
1503 * xselect.c (Fx_get_atom_name): Avoid need for strlen.
1504
28154962
PE
1505 * xrdb.c: Don't assume strlen fits in int; avoid some strlens.
1506 * xrdb.c (magic_file_p, search_magic_path):
1507 Omit last arg SUFFIX; it was always 0. All callers changed.
1508 (magic_file_p): Use ptrdiff_t, not int. Check for size overflow.
1509
7de51af5
PE
1510 * xfont.c (xfont_match): Avoid need for strlen.
1511
25ed6cc3
PE
1512 * xfns.c: Don't assume strlen fits in int.
1513 (xic_create_fontsetname, x_window): Use ptrdiff_t, not int.
1514
4eab31dd
PE
1515 * xdisp.c (message_log_check_duplicate): Return intmax_t,
1516 not unsigned long, as we prefer signed integers. All callers changed.
1517 Detect integer overflow in repeat count.
1518 (message_dolog): Don't assume print length fits in 39 bytes.
df1f27af 1519 (display_mode_element): Don't assume strlen fits in int.
4eab31dd 1520
171e2a58
PE
1521 * termcap.c: Don't assume sizes fit in int and never overflow.
1522 (struct termcap_buffer, tgetent): Use ptrdiff_t, not int, for sizes.
1523 (gobble_line): Check for size-calculation overflow.
1524
ad39faca 1525 * minibuf.c (Fread_buffer):
6e5bb2dc 1526 * lread.c (intern, intern_c_string):
74ca2eb3
PE
1527 * image.c (xpm_scan) [HAVE_NS && !HAVE_XPM]:
1528 Don't assume string length fits in int.
1529
52c61c22 1530 * keyboard.c (parse_tool_bar_item):
9bda3520
PE
1531 * gtkutil.c (style_changed_cb): Avoid need for strlen.
1532
b5b8c9e5
PE
1533 * font.c: Don't assume string length fits in int.
1534 (font_parse_xlfd, font_parse_fcname, font_unparse_fcname):
1535 Use ptrdiff_t, not int.
ccd6111c
PE
1536 (font_intern_prop): Don't assume string length fits in int.
1537 Don't assume integer property fits in fixnum.
1538 * font.h (font_intern_prop): 2nd arg is now ptrdiff_t, not int.
b5b8c9e5 1539
882f0d81 1540 * filelock.c: Fix some buffer overrun and integer overflow issues.
51cab52b 1541 (get_boot_time): Don't assume gzip command string fits in 100 bytes.
882f0d81
PE
1542 Reformulate so as not to need the command string.
1543 Invoke gzip -cd rather than gunzip, as it's more portable.
1544 (lock_info_type, lock_file_1, lock_file):
1545 Don't assume pid_t and time_t fit in unsigned long.
1546 (LOCK_PID_MAX): Remove; we now use more-reliable bounds.
1547 (current_lock_owner): Prefer signed type for sizes.
1548 Use memcpy, not strncpy, where memcpy is what is really wanted.
1549 Don't assume (via atoi) that time_t and pid_t fit in int.
1550 Check for time_t and/or pid_t out of range, e.g., via a network share.
1551 Don't alloca where an auto var works fine.
1552
93f4cf88
PE
1553 * fileio.c: Fix some integer overflow issues.
1554 (file_name_as_directory, Fexpand_file_name, Fsubstitute_in_file_name):
1555 Don't assume string length fits in int.
1556 (directory_file_name): Don't assume string length fits in long.
1557 (make_temp_name): Don't assume pid fits in int, or that its print
1558 length is less than 20.
1559
f3e92b69
PE
1560 * data.c (Fsubr_name): Rewrite to avoid a strlen call.
1561
1bfdaf10
PE
1562 * coding.c (make_subsidiaries): Don't assume string length fits in int.
1563
35016e9a
PE
1564 * callproc.c (child_setup): Rewrite to avoid two strlen calls.
1565
3d1e65a1
PE
1566 * process.c (Fformat_network_address): Use EMACS_INT, not EMACS_UINT.
1567 We prefer signed integers, even for size calculations.
1568
0b963a93
PE
1569 * emacs.c: Don't assume string length fits in 'int'.
1570 (DEFINE_DUMMY_FUNCTION, sort_args): Use ptrdiff_t, not int.
1571 (main): Don't invoke strlen when not needed.
1572
573f4b54
PE
1573 * dbusbind.c (XD_ERROR): Don't arbitrarily truncate string.
1574 (XD_DEBUG_MESSAGE): Don't waste a byte.
1575
989f33ba
PE
1576 * callproc.c (getenv_internal_1, getenv_internal)
1577 (Fgetenv_internal):
965d34eb
PE
1578 * buffer.c (init_buffer): Don't assume string length fits in 'int'.
1579
e4d29b33
PE
1580 * lread.c (invalid_syntax): Omit length argument.
1581 All uses changed. This doesn't fix a bug, but it simplifies the
1582 code away from its former Hollerith-constant appearance, and it's
1583 one less 'int' to worry about when looking at integer-overflow issues.
51cab52b 1584 (string_to_number): Simplify 2011-04-26 change by invoking xsignal1.
e4d29b33 1585
eb49b136
PE
1586 * lisp.h (DEFUN): Remove bogus use of sizeof (struct Lisp_Subr).
1587 This didn't break anything, but it didn't help either.
1588 It's confusing to put a bogus integer in a place where the actual
1589 value does not matter.
9f62aeb1 1590 (LIST_END_P): Remove unused macro and its bogus comment.
cbeff735 1591 (make_fixnum_or_float): Remove unnecessary cast to EMACS_INT.
eb49b136 1592
15375a22
PE
1593 * lisp.h (union Lisp_Object.i): EMACS_INT, not EMACS_UINT.
1594 This is for consistency with the ordinary, non-USE_LISP_UNION_TYPE,
1595 implementation.
b61cc01c
PE
1596 (struct Lisp_Bool_Vector.size): EMACS_INT, not EMACS_UINT.
1597 We prefer signed types, and the value cannot exceed the EMACS_INT
1598 range anyway (because otherwise the length would not be representable).
9a8e8d9b
PE
1599 (XSET) [USE_LISP_UNION_TYPE]: Use uintptr_t and intptr_t,
1600 not EMACS_UINT and EMACS_INT, when converting pointer to integer.
1601 This avoids a GCC warning when WIDE_EMACS_INT.
15375a22 1602
53b2623d
PE
1603 * indent.c (sane_tab_width): New function.
1604 (current_column, scan_for_column, Findent_to, position_indentation)
1605 (compute_motion): Use it. This is just for clarity.
8fcaf9cc 1606 (Fcompute_motion): Don't assume hscroll and tab offset fit in int.
53b2623d 1607
51cab52b 1608 * image.c (xbm_image_p): Don't assume stated width, height fit in int.
45aebb64 1609
f2ed8a70
PE
1610 * lisp.h (lint_assume): New macro.
1611 * composite.c (composition_gstring_put_cache):
1612 * ftfont.c (ftfont_shape_by_flt): Use it to pacify GCC 4.6.0.
1613
abe80cc6
PE
1614 * editfns.c, insdel.c:
1615 Omit unnecessary forward decls, to simplify future changes.
a9e860e1 1616
b02c740e
PE
1617 * ftfont.c (ftfont_shape_by_flt): Use signed integers for lengths.
1618
ebc96716
PE
1619 * font.c (Ffont_shape_gstring): Don't assume glyph len fits in 'int'.
1620
b4e50fa0 1621 * fns.c (Ffillarray): Don't assume bool vector size fits in 'int'.
f03dc6ef 1622 Use much-faster test for byte-length change.
311d5d7c 1623 Don't assume string byte-length fits in 'int'.
a4cf38e4 1624 Check that character arg fits in 'int'.
85461888 1625 (mapcar1): Declare byte as byte, for clarity.
b4e50fa0 1626
c0c1ee9f
PE
1627 * alloc.c (Fmake_bool_vector): Avoid unnecessary multiplication.
1628
a498d7f4
PE
1629 * fns.c (concat): Catch string overflow earlier.
1630 Do not rely on integer wraparound.
1631
51cab52b
PE
1632 * dispextern.h (struct it.overlay_strings_charpos)
1633 (struct it.selective): Now EMACS_INT, not int.
87830974
PE
1634 * xdisp.c (forward_to_next_line_start)
1635 (back_to_previous_visible_line_start)
1636 (reseat_at_next_visible_line_start, next_element_from_buffer):
1637 Don't arbitrarily truncate the value of 'selective' to int.
1638
76031fad
PE
1639 * xdisp.c (init_iterator): Use XINT, not XFASTINT; it might be < 0.
1640
5eb55db9
PE
1641 * composite.c: Don't truncate sizes to 'int'.
1642 (composition_gstring_p, composition_reseat_it)
1643 (composition_adjust_point): Use EMACS_INT, not int.
7d100a81
PE
1644 (get_composition_id, composition_gstring_put_cache): Use EMACS_INT,
1645 not EMACS_UINT, for indexes.
5eb55db9 1646
0703a717
PE
1647 * category.h (CATEGORY_SET_P): Remove unnecessary cast to EMACS_INT.
1648
d6202519
PE
1649 * buffer.c: Include <verify.h>.
1650 (struct sortvec.priority, struct sortstr.priority):
8961a454 1651 Now EMACS_INT, not int.
c20998a7 1652 (compare_overlays, cmp_for_strings): Avoid subtraction overflow.
67c36fce
PE
1653 (struct sortstr.size, record_overlay_string)
1654 (struct sortstrlist.size, struct sortlist.used):
1655 Don't truncate size to int.
1656 (record_overlay_string): Check for size-calculation overflow.
d6202519 1657 (init_buffer_once): Check at compile-time, not run-time.
fadf4e30 1658
d5a19415
JM
16592011-06-22 Jim Meyering <meyering@redhat.com>
1660
029529ac 1661 Don't leak an XBM-image-sized buffer
d5a19415
JM
1662 * image.c (xbm_load): Free the image buffer after using it.
1663
a9041e6c
PE
16642011-06-21 Paul Eggert <eggert@cs.ucla.edu>
1665
1666 Port to Sun C.
1667 * composite.c (find_automatic_composition): Omit needless 'return 0;'
1668 that Sun C diagnosed.
1669 * fns.c (secure_hash): Fix pointer signedness issue.
1670 * intervals.c (static_offset_intervals): New function.
1671 (offset_intervals): Use it.
1672
7f3f739f
LL
16732011-06-21 Leo Liu <sdl.web@gmail.com>
1674
1675 * deps.mk (fns.o):
1676 * makefile.w32-in ($(BLD)/fns.$(O)): Include sha256.h and
1677 sha512.h.
1678
1679 * fns.c (secure_hash): Rename from crypto_hash_function and change
1680 the first arg to accept symbols.
5b66d427 1681 (Fsecure_hash): New primitive.
7f3f739f
LL
1682 (syms_of_fns): New symbols.
1683
76147d94
DD
16842011-06-20 Deniz Dogan <deniz@dogan.se>
1685
1686 * process.c (Fset_process_buffer): Clarify return value in
1687 docstring.
1688
7d7d0045
CY
16892011-06-18 Chong Yidong <cyd@stupidchicken.com>
1690
1691 * dispnew.c (add_window_display_history): Use BVAR.
1692
1693 * xdisp.c (debug_method_add): Use BVAR.
1694 (check_window_end, dump_glyph_matrix, dump_glyph)
1695 (dump_glyph_row, dump_glyph_string): Convert arglist to ANSI C.
1696
1697 * xfaces.c (check_lface_attrs, check_lface, dump_realized_face):
1698 Likewise.
1699
1700 * xfns.c (Fx_create_frame, x_create_tip_frame): Delay image cache
1701 check till after the cache is created in init_frame_faces.
1702
ff2bc410
SM
17032011-06-17 Stefan Monnier <monnier@iro.umontreal.ca>
1704
1705 * fns.c (Fsafe_length): Yet another int/Lisp_Object mixup.
1706
28177add
PE
17072011-06-16 Paul Eggert <eggert@cs.ucla.edu>
1708
dd3482fe
PE
1709 * lisp.h: Include <limits.h>, for INT_MAX, LONG_MAX, LLONG_MAX.
1710 Without this, prin1 mishandles Lisp_Misc_Save_Value printing on
1711 hosts with pre-C99 libraries, because pD is wrongly defined to "t".
1712
393d71f3 1713 Improve buffer-overflow checking (Bug#8873).
1c8e352f
PE
1714 * fileio.c (Finsert_file_contents):
1715 * insdel.c (insert_from_buffer_1, replace_range, replace_range_2):
1716 Remove the old (too-loose) buffer overflow checks.
1717 They weren't needed, since make_gap checks for buffer overflow.
1718 * insdel.c (make_gap_larger): Catch buffer overflows that were missed.
1719 The old code merely checked for Emacs fixnum overflow, and relied
1720 on undefined (wraparound) behavior. The new code avoids undefined
1721 behavior, and also checks for ptrdiff_t and/or size_t overflow.
1722
2e6813b0 1723 * editfns.c (Finsert_char): Don't dump core with very negative counts.
21d890a4
PE
1724 Tune. Don't use wider integers than needed. Don't use alloca.
1725 Use a bigger 'string' buffer. Rewrite to avoid 'n > 0' test.
2e6813b0 1726
599a9e4f
PE
1727 * insdel.c (replace_range): Fix buf overflow when insbytes < outgoing.
1728
99561444
PE
1729 * insdel.c, lisp.h (buffer_overflow): New function.
1730 (insert_from_buffer_1, replace_range, replace_range_2):
1731 * insdel.c (make_gap_larger):
1732 * editfns.c (Finsert_char):
1733 * fileio.c (Finsert_file_contents): Use it, to normalize wording.
1734
28177add
PE
1735 * buffer.h (BUF_BYTES_MAX): Cast to ptrdiff_t so that it's signed.
1736
e69dafad
PE
17372011-06-15 Paul Eggert <eggert@cs.ucla.edu>
1738
a7af7fde 1739 Integer overflow and signedness fixes (Bug#8873).
ff672d2c 1740
b1c46f02
PE
1741 * ccl.c (ASCENDING_ORDER): New macro, to work around GCC bug 43772.
1742 (GET_CCL_RANGE, IN_INT_RANGE): Use it.
1743
e69dafad
PE
1744 * fileio.c: Don't assume EMACS_INT fits in off_t.
1745 (emacs_lseek): New static function.
1746 (Finsert_file_contents, Fwrite_region): Use it.
1747 Use SEEK_SET, SEEK_CUR, SEEK_END as appropriate.
1748
566684ea
PE
1749 * fns.c (Fload_average): Don't assume 100 * load average fits in int.
1750
e6966cd6
PE
1751 * fns.c: Don't overflow int when computing a list length.
1752 * fns.c (QUIT_COUNT_HEURISTIC): New constant.
1753 (Flength, Fsafe_length): Use EMACS_INT, not int, to avoid unwanted
1754 truncation on 64-bit hosts. Check for QUIT every
1755 QUIT_COUNT_HEURISTIC entries rather than every other entry; that's
1756 faster and is responsive enough.
1757 (Flength): Report an error instead of overflowing an integer.
1758 (Fsafe_length): Return a float if the value is not representable
1759 as a fixnum. This shouldn't happen except in contrived situations.
6346d301 1760 (Fnthcdr, Fsort): Don't assume list length fits in int.
de41a810 1761 (Fcopy_sequence): Don't assume vector length fits in int.
00c604f2 1762
dd0b0efb
PE
1763 * alloc.c: Check that resized vectors' lengths fit in fixnums.
1764 (header_size, word_size): New constants.
1765 (allocate_vectorlike): Don't check size overflow here.
1766 (allocate_vector): Check it here instead, since this is the only
1767 caller of allocate_vectorlike that could cause overflow.
1768 Check that the new vector's length is representable as a fixnum.
1769
86fe5cfe
PE
1770 * fns.c (next_almost_prime): Don't return a multiple of 3 or 5.
1771 The previous code was bogus. For example, next_almost_prime (32)
1772 returned 39, which is undesirable as it is a multiple of 3; and
1773 next_almost_prime (24) returned 25, which is a multiple of 5 so
1774 why was the code bothering to check for multiples of 7?
1775
80e88859
PE
1776 * bytecode.c (exec_byte_code): Use ptrdiff_t, not int, for vector length.
1777
4a2f0ad6
PE
1778 * eval.c, doprnt.c (SIZE_MAX): Remove; inttypes.h defines this now.
1779
f66c7cf8
PE
1780 Variadic C functions now count arguments with ptrdiff_t.
1781 This partly undoes my 2011-03-30 change, which replaced int with size_t.
1782 Back then I didn't know that the Emacs coding style prefers signed int.
1783 Also, in the meantime I found a few more instances where arguments
4a2f0ad6
PE
1784 were being counted with int, which may truncate counts on 64-bit
1785 machines, or EMACS_INT, which may be unnecessarily wide.
f66c7cf8
PE
1786 * lisp.h (struct Lisp_Subr.function.aMANY)
1787 (DEFUN_ARGS_MANY, internal_condition_case_n, safe_call):
1788 Arg counts are now ptrdiff_t, not size_t.
1789 All variadic functions and their callers changed accordingly.
1790 (struct gcpro.nvars): Now size_t, not size_t. All uses changed.
1791 * bytecode.c (exec_byte_code): Check maxdepth for overflow,
1792 to avoid potential buffer overrun. Don't assume arg counts fit in 'int'.
1793 * callint.c (Fcall_interactively): Check arg count for overflow,
1794 to avoid potential buffer overrun. Use signed char, not 'int',
1795 for 'varies' array, so that we needn't bother to check its size
1796 calculation for overflow.
1797 * editfns.c (Fformat): Use ptrdiff_t, not EMACS_INT, to count args.
1798 * eval.c (apply_lambda):
1799 * fns.c (Fmapconcat): Use XFASTINT, not XINT, to get args length.
1800 (struct textprop_rec.argnum): Now ptrdiff_t, not int. All uses changed.
1801 (mapconcat): Use ptrdiff_t, not int and EMACS_INT, to count args.
1802
a1759b76
PE
1803 * callint.c (Fcall_interactively): Don't use index var as event count.
1804
d96be9fc
PE
1805 * vm-limit.c (check_memory_limits): Fix incorrect extern function decls.
1806 * mem-limits.h (SIZE): Remove; no longer used.
1807
a690a978 1808 * xterm.c (x_alloc_nearest_color_1): Prefer int to long when int works.
5efd304b 1809
578c21e6
PE
1810 Remove unnecessary casts.
1811 * xterm.c (x_term_init):
1812 * xfns.c (x_set_border_pixel):
1813 * widget.c (create_frame_gcs): Remove casts to unsigned long etc.
1814 These aren't needed now that we assume ANSI C.
1815
96f53c6c
PE
1816 * sound.c (Fplay_sound_internal): Remove cast to unsigned long.
1817 It's more likely to cause problems (due to unsigned overflow)
1818 than to cure them.
1819
83c77d31
PE
1820 * dired.c (Ffile_attributes): Don't use 32-bit hack on 64-bit hosts.
1821
ee2079f1
PE
1822 * unexelf.c (unexec): Don't assume BSS addr fits in unsigned.
1823
6da65536
PE
1824 * xterm.c (handle_one_xevent): Omit unnecessary casts to unsigned.
1825
7147c4a4
PE
1826 * keyboard.c (modify_event_symbol): Don't limit alist len to UINT_MAX.
1827
193e32d9
PE
1828 * lisp.h (CHAR_TABLE_SET): Omit now-redundant test.
1829
e5533da6
PE
1830 * lread.c (Fload): Don't compare a possibly-garbage time_t value.
1831
9910e595
PE
1832 GLYPH_CODE_FACE returns EMACS_INT, not int.
1833 * dispextern.h (merge_faces):
1834 * xfaces.c (merge_faces):
01103c44
PE
1835 * xdisp.c (get_next_display_element, next_element_from_display_vector):
1836 Don't assume EMACS_INT fits in int.
9910e595 1837
2638320e
PE
1838 * character.h (CHAR_VALID_P): Remove unused parameter.
1839 * fontset.c, lisp.h, xdisp.c: All uses changed.
1840
045eb8d9
PE
1841 * editfns.c (Ftranslate_region_internal): Omit redundant test.
1842
c1f134b5
PE
1843 * fns.c (concat): Minor tuning based on overflow analysis.
1844 This doesn't fix any bugs. Use int to hold character, instead
1845 of constantly refetching from Emacs object. Use XFASTINT, not
1846 XINT, for value known to be a character. Don't bother comparing
1847 a single byte to 0400, as it's always less.
1848
395fcb93 1849 * floatfns.c (Fexpt):
327eeec8
PE
1850 * fileio.c (make_temp_name): Omit unnecessary cast to unsigned.
1851
abbd3d23
PE
1852 * editfns.c (Ftranslate_region_internal): Use int, not EMACS_INT
1853 for characters.
1854
684a03ef
PE
1855 * doc.c (get_doc_string): Omit (unsigned)c that mishandled negatives.
1856
0fed43f3
PE
1857 * data.c (Faset): If ARRAY is a string, check that NEWELT is a char.
1858 Without this fix, on a 64-bit host (aset S 0 4294967386) would
1859 incorrectly succeed when S was a string, because 4294967386 was
1860 truncated before it was used.
1861
8fd02eb7
PE
1862 * chartab.c (Fchar_table_range): Use CHARACTERP to check range.
1863 Otherwise, an out-of-range integer could cause undefined behavior
1864 on a 64-bit host.
1865
f8c86b69
PE
1866 * composite.c: Use int, not EMACS_INT, for characters.
1867 (fill_gstring_body, composition_compute_stop_pos): Use int, not
1868 EMACS_INT, for values that are known to be in character range.
1869 This doesn't fix any bugs but is the usual style inside Emacs and
1870 may generate better code on 32-bit machines.
1871
34206dd2
PE
1872 Make sure a 64-bit char is never passed to ENCODE_CHAR.
1873 This is for reasons similar to the recent CHAR_STRING fix.
1874 * charset.c (Fencode_char): Check that character arg is actually
1875 a character. Pass an int to ENCODE_CHAR.
1876 * charset.h (ENCODE_CHAR): Verify that the character argument is no
1877 wider than 'int', as a compile-time check to prevent future regressions
1878 in this area.
1879
c5958d4c 1880 * character.c (char_string): Remove unnecessary casts.
13bdea59
PE
1881
1882 Make sure a 64-bit char is never passed to CHAR_STRING.
1883 Otherwise, CHAR_STRING would do the wrong thing on a 64-bit platform,
1884 by silently ignoring the top 32 bits, allowing some values
1885 that were far too large to be valid characters.
1886 * character.h: Include <verify.h>.
1887 (CHAR_STRING, CHAR_STRING_ADVANCE): Verify that the character
1888 arguments are no wider than unsigned, as a compile-time check
1889 to prevent future regressions in this area.
1890 * data.c (Faset):
01103c44 1891 * editfns.c (Fchar_to_string, general_insert_function, Finsert_char)
13bdea59
PE
1892 (Fsubst_char_in_region):
1893 * fns.c (concat):
1894 * xdisp.c (decode_mode_spec_coding):
1895 Adjust to CHAR_STRING's new requirement.
1896 * editfns.c (Finsert_char, Fsubst_char_in_region):
1897 * fns.c (concat): Check that character args are actually
1898 characters. Without this test, these functions did the wrong
1899 thing with wildly out-of-range values on 64-bit hosts.
1900
d37ca623
PE
1901 Remove incorrect casts to 'unsigned' that lose info on 64-bit hosts.
1902 These casts should not be needed on 32-bit hosts, either.
1903 * keyboard.c (read_char):
1904 * lread.c (Fload): Remove casts to unsigned.
1905
ea204efb
PE
1906 * lisp.h (UNSIGNED_CMP): New macro.
1907 This fixes comparison bugs on 64-bit hosts.
1908 (ASCII_CHAR_P): Use it.
1909 * casefiddle.c (casify_object):
01103c44 1910 * character.h (ASCII_BYTE_P, CHAR_VALID_P)
ea204efb
PE
1911 (SINGLE_BYTE_CHAR_P, CHAR_STRING):
1912 * composite.h (COMPOSITION_ENCODE_RULE_VALID):
1913 * dispextern.h (FACE_FROM_ID):
1914 * keyboard.c (read_char): Use UNSIGNED_CMP.
1915
41cb286c
PE
1916 * xmenu.c (dialog_selection_callback) [!USE_GTK]: Cast to intptr_t,
1917 not to EMACS_INT, to avoid GCC warning.
1918
4a1b9832
PE
1919 * xfns.c (x_set_scroll_bar_default_width): Remove unused 'int' locals.
1920
55daad71
PE
1921 * buffer.h (PTR_BYTE_POS, BUF_PTR_BYTE_POS): Remove harmful cast.
1922 The cast incorrectly truncated 64-bit byte offsets to 32 bits, and
1923 isn't needed on 32-bit machines.
8f95c75c 1924
01103c44
PE
1925 * buffer.c (Fgenerate_new_buffer_name):
1926 Use EMACS_INT for count, not int.
0ceccced 1927 (advance_to_char_boundary): Return EMACS_INT, not int.
e762cafe
PE
1928
1929 * data.c (Qcompiled_function): Now static.
1930
c6f072e7
PE
1931 * window.c (window_body_lines): Now static.
1932
20ce5912
PE
1933 * image.c (gif_load): Rename local to avoid shadowing.
1934
9c4c5f81
PE
1935 * lisp.h (SAFE_ALLOCA_LISP): Check for integer overflow.
1936 (struct Lisp_Save_Value): Use ptrdiff_t, not int, for 'integer' member.
1937 * alloc.c (make_save_value): Integer argument is now of type
1938 ptrdiff_t, not int.
1939 (mark_object): Use ptrdiff_t, not int.
1940 * lisp.h (pD): New macro.
1941 * print.c (print_object): Use it.
1942
c0c5c8ae
PE
1943 * alloc.c: Use EMACS_INT, not int, to count objects.
1944 (total_conses, total_markers, total_symbols, total_vector_size)
1945 (total_free_conses, total_free_markers, total_free_symbols)
01103c44
PE
1946 (total_free_floats, total_floats, total_free_intervals)
1947 (total_intervals, total_strings, total_free_strings):
c0c5c8ae
PE
1948 Now EMACS_INT, not int. All uses changed.
1949 (Fgarbage_collect): Compute overall total using a double, so that
1950 integer overflow is less likely to be a problem. Check for overflow
1951 when converting back to an integer.
5a25e253
PE
1952 (n_interval_blocks, n_string_blocks, n_float_blocks, n_cons_blocks)
1953 (n_vectors, n_symbol_blocks, n_marker_blocks): Remove.
1954 These were 'int' variables that could overflow on 64-bit hosts;
1955 they were never used, so remove them instead of repairing them.
211a0b2a 1956 (nzombies, ngcs, max_live, max_zombies): Now EMACS_INT, not 'int'.
6349ae4d
PE
1957 (inhibit_garbage_collection): Set gc_cons_threshold to max value.
1958 Previously, this ceilinged at INT_MAX, but that doesn't work on
1959 64-bit machines.
e46bb31a 1960 (allocate_pseudovector): Don't use EMACS_INT when int would do.
c0c5c8ae 1961
c78baabf 1962 * alloc.c (Fmake_bool_vector): Don't assume vector size fits in int.
86f61a15 1963 (allocate_vectorlike): Check for ptrdiff_t overflow.
b6439961
PE
1964 (mark_vectorlike, mark_char_table, mark_object): Avoid EMACS_UINT
1965 when a (possibly-narrower) signed value would do just as well.
1966 We prefer using signed arithmetic, to avoid comparison confusion.
c78baabf 1967
c9d624c6
PE
1968 * alloc.c: Catch some string size overflows that we were missing.
1969 (XMALLOC_OVERRUN_CHECK_SIZE) [!XMALLOC_OVERRUN_CHECK]: Define to 0,
1970 for convenience in STRING_BYTES_MAX.
1971 (STRING_BYTES_MAX): New macro, superseding the old one in lisp.h.
1972 The definition here is exact; the one in lisp.h was approximate.
1973 (allocate_string_data): Check for string overflow. This catches
1974 some instances we weren't catching before. Also, it catches
1975 size_t overflow on (unusual) hosts where SIZE_MAX <= min
1976 (PTRDIFF_MAX, MOST_POSITIVE_FIXNUM), e.g., when size_t is 32 bits
1977 and ptrdiff_t and EMACS_INT are both 64 bits.
c78baabf 1978
c9d624c6
PE
1979 * character.c, coding.c, doprnt.c, editfns.c, eval.c:
1980 All uses of STRING_BYTES_MAX replaced by STRING_BYTES_BOUND.
1981 * lisp.h (STRING_BYTES_BOUND): Renamed from STRING_BYTES_MAX.
1982
353032ce
PE
1983 * character.c (string_escape_byte8): Fix nbytes/nchars typo.
1984
2bccce07
PE
1985 * alloc.c (Fmake_string): Check for out-of-range init.
1986
0ac30604
SM
19872011-06-15 Stefan Monnier <monnier@iro.umontreal.ca>
1988
1989 * eval.c (Fdefvaralias): Also mark the target as variable-special-p.
1990
c195f2de
JD
19912011-06-14 Jan Djärv <jan.h.d@swipnet.se>
1992
1993 * xfns.c (x_set_scroll_bar_default_width): Remove argument to
1994 xg_get_default_scrollbar_width.
1995
1996 * gtkutil.c: Include emacsgtkfixed.h if HAVE_GTK3.
1997 (int_gtk_range_get_value): Move to the scroll bar part of the file.
1998 (style_changed_cb): Call update_theme_scrollbar_width and call
1999 x_set_scroll_bar_default_width and xg_frame_set_char_size for
2000 all frames (Bug#8505).
2001 (xg_create_frame_widgets): Call emacs_fixed_new if HAVE_GTK3 (Bug#8505).
2002 Call gtk_window_set_resizable if HAVE_GTK3.
2003 (x_wm_set_size_hint): Call emacs_fixed_set_min_size with min width
2004 and height if HAVE_GTK3 (Bug#8505).
2005 (scroll_bar_width_for_theme): New variable.
2006 (update_theme_scrollbar_width): New function.
2007 (xg_get_default_scrollbar_width): Move code to
2008 update_theme_scrollbar_width, just return scroll_bar_width_for_theme.
2009 (xg_initialize): Call update_theme_scrollbar_width.
2010
2011 * gtkutil.h (xg_get_default_scrollbar_width): Remove argument.
2012
2013 * emacsgtkfixed.c, emacsgtkfixed.h: New files.
2014
e10ac9f1
MR
20152011-06-12 Martin Rudalics <rudalics@gmx.at>
2016
2017 * frame.c (make_frame): Call other_buffer_safely instead of
2018 other_buffer.
2019
2020 * window.c (temp_output_buffer_show): Call display_buffer with
2021 second argument Vtemp_buffer_show_specifiers and reset latter
2022 immediately after the call.
2023 (Vtemp_buffer_show_specifiers): New variable.
2024 (auto_window_vscroll_p, next_screen_context_lines)
2025 (Vscroll_preserve_screen_position): Remove leading asterisks from
2026 doc-strings.
2027
2d3c217e 20282011-06-12 Paul Eggert <eggert@cs.ucla.edu>
4475bec4 2029
7b7f97e8 2030 Fix minor problems found by GCC 4.6.0 static checking.
4475bec4
PE
2031 * buffer.c (Qclone_number): Remove for now, as it's unused.
2032 (record_buffer, Funrecord_buffer): Rename local to avoid shadowing.
2033 (record_buffer): Remove unused local.
2034 * frame.c (other_visible_frames, frame_buffer_list): Now static.
2035 (set_frame_buffer_list): Remove; unused.
2036 * frame.h (other_visible_frames): Remove decl.
2037 * keyboard.h (menu_items_inuse): Declare only if USE_GTK || USE_MOTIF.
2038 * lisp.h (frame_buffer_list, set_frame_buffer_list): Remove decls.
2039 (add_gpm_wait_descriptor, delete_gpm_wait_descriptor): Declare only
2040 if HAVE_GPM.
2041 * menu.c (menu_items_inuse): Now static unless USE_GTK || USE_MOTIF.
2042 * process.c (add_gpm_wait_descriptor, delete_gpm_wait_descriptor):
2043 Define only if HAVE_GPM.
2044 * widget.c (EmacsFrameResize, emacsFrameClassRec): Now static.
2045 (update_hints_inhibit): Remove; never set. All uses removed.
2046 * widgetprv.h (emacsFrameClassRec): Remove decl.
2047 * window.c (delete_deletable_window): Now returns void, since it
2048 wasn't returning anything.
2049 (compare_window_configurations): Remove unused locals.
2050 * xfns.c (x_set_scroll_bar_default_width): Remove unused locals.
2051 * xmenu.c (x_menu_set_in_use): Define only if USE_GTK || USE_MOTIF.
4475bec4
PE
2052 (dialog_selection_callback) [!USE_GTK]: Prefer intptr_t for integers
2053 the same widths as pointers. This follows up on the 2011-05-06 patch.
2054 * xterm.c (x_alloc_lighter_color_for_widget): Define only if USE_LUCID.
2055 * xterm.h: Likewise.
2056 (x_menu_set_in_use): Declare only if USE_GTK || USE_MOTIF.
2057
1384b89e
JB
20582011-06-12 Juanma Barranquero <lekktu@gmail.com>
2059
2060 * makefile.w32-in: Update dependencies.
2061 (LISP_H): Add lib/intprops.h.
2062
1100a63c
CY
20632011-06-11 Chong Yidong <cyd@stupidchicken.com>
2064
2065 * image.c (gif_load): Add animation frame delay to the metadata.
2066 (syms_of_image): Use DEFSYM. New symbol `delay'.
2067
6198ccd0
MR
20682011-06-11 Martin Rudalics <rudalics@gmx.at>
2069
2070 * window.c (delete_deletable_window): Re-add.
2071 (Fset_window_configuration): Rewrite to handle dead buffers and
2072 consequently deletable windows.
2073 (window_tree, Fwindow_tree): Remove. Supply functionality in
2074 window.el.
2075 (compare_window_configurations): Simplify code.
2076
b6e3633c
AS
20772011-06-11 Andreas Schwab <schwab@linux-m68k.org>
2078
1ab0dee5
AS
2079 * image.c (imagemagick_load_image): Fix type mismatch.
2080 (Fimagemagick_types): Likewise.
2081
b6e3633c
AS
2082 * window.h (replace_buffer_in_windows): Declare.
2083
9397e56f
MR
20842011-06-11 Martin Rudalics <rudalics@gmx.at>
2085
2086 * buffer.c: New Lisp objects Qbuffer_list_update_hook and
2087 Qclone_number. Remove external declaration of Qdelete_window.
2088 (Fbuffer_list): Rewrite doc-string. Minor restructuring of
2089 code.
2090 (Fget_buffer_create, Fmake_indirect_buffer, Frename_buffer): Run
2091 Qbuffer_list_update_hook if allowed.
2092 (Fother_buffer): Rewrite doc-string. Major rewrite for new
2093 buffer list implementation.
2094 (other_buffer_safely): New function.
2095 (Fkill_buffer): Replace call to replace_buffer_in_all_windows by
2096 calls to replace_buffer_in_windows and
2097 replace_buffer_in_windows_safely. Run Qbuffer_list_update_hook
2098 if allowed.
2099 (record_buffer): Inhibit quitting and rewrite using quittable
2100 functions. Run Qbuffer_list_update_hook if allowed.
2101 (Frecord_buffer, Funrecord_buffer): New functions.
2102 (switch_to_buffer_1, Fswitch_to_buffer): Remove. Move
2103 switch-to-buffer to window.el.
2104 (bury-buffer): Move to window.el.
2105 (Vbuffer_list_update_hook): New variable.
2106
2107 * lisp.h (other_buffer_safely): Add prototype in buffer.c
2108 section.
2109
2110 * window.h (resize_frame_windows): Move up in code.
2111 (Fwindow_frame): Remove EXFUN.
2112 (replace_buffer_in_all_windows): Remove prototype.
2113 (replace_buffer_in_windows_safely): Add prototype.
2114
2115 * window.c: Declare Qdelete_window static again. Move down
2116 declaration of select_count.
2117 (Fnext_window, Fprevious_window): Rewrite doc-strings.
2118 (Fother_window): Move to window.el.
2119 (window_loop): Remove DELETE_BUFFER_WINDOWS and UNSHOW_BUFFER
2120 cases. Add REPLACE_BUFFER_IN_WINDOWS_SAFELY case.
2121 (Fdelete_windows_on, Freplace_buffer_in_windows): Move to
2122 window.el.
2123 (replace_buffer_in_windows): Implement by calling
2124 Qreplace_buffer_in_windows.
2125 (replace_buffer_in_all_windows): Remove with some functionality
2126 moved into replace_buffer_in_windows_safely.
2127 (replace_buffer_in_windows_safely): New function.
2128 (select_window_norecord, select_frame_norecord): Move in front
2129 of run_window_configuration_change_hook. Remove now obsolete
2130 declarations.
2131 (Fset_window_buffer): Rewrite doc-string. Call
2132 Qrecord_window_buffer.
2133 (keys_of_window): Move binding for other-window to window.el.
2134
b50691aa
CY
21352011-06-11 Chong Yidong <cyd@stupidchicken.com>
2136
2137 * dispextern.h (struct image): Replace data member, whose int_val
2138 and ptr_val fields were not used by anything, with a single
2139 lisp_val object.
2140
2141 * image.c (Fimage_metadata, make_image, mark_image, tiff_load)
2142 (gif_clear_image, gif_load, imagemagick_load_image)
2143 (gs_clear_image, gs_load): Callers changed.
2144
3f754b86
PE
21452011-06-10 Paul Eggert <eggert@cs.ucla.edu>
2146
cca69397
PE
2147 * buffer.h: Include <time.h>, for time_t.
2148 Needed to build on FreeBSD 8.2. Problem reported by Herbert J. Skuhra.
2149
109e28d0
PE
2150 Fix minor problems found by static checking.
2151
60737f02
PE
2152 * image.c (PixelGetMagickColor): Declare if ImageMagick headers don't.
2153
4b66faf3
PE
2154 Make identifiers static if they are not used in other modules.
2155 * data.c (Qcompiled_function, Qframe, Qvector):
2156 * image.c (QimageMagick, Qsvg):
2157 * minibuf.c (Qmetadata):
2158 * window.c (resize_window_check, resize_root_window): Now static.
2159 * window.h (resize_window_check, resize_root_window): Remove decls.
2160
109e28d0
PE
2161 * window.c (window_deletion_count, delete_deletable_window):
2162 Remove; unused.
46a4ce9e
PE
2163 (window_body_lines): Now static.
2164 (Fdelete_other_windows_internal): Mark vars as initialized.
2165 Make sure 'resize_failed' is initialized.
2166 (run_window_configuration_change_hook): Rename local to avoid shadowing.
2167 (resize_window_apply): Remove unused local.
2168 * window.h (delete_deletable_window): Remove decl.
2169
109e28d0 2170 * image.c (gif_load, svg_load_image): Rename locals to avoid shadowing.
33290528
PE
2171 (imagemagick_load_image): Fix pointer signedness problem by changing
2172 last arg from unsigned char * to char *. All uses changed.
2173 Also, fix a local for similar reasons.
2174 Remove unused locals. Remove locals to avoid shadowing.
2175 (fn_rsvg_handle_free): Remove; unused.
2176 (svg_load, svg_load_image): Fix pointer signedness problem.
f7e13da3 2177 (imagemagick_load_image): Don't use garbage pointer image_wand.
33290528 2178
3f754b86
PE
2179 * ftfont.c (ftfont_get_metrics, ftfont_drive_otf): Remove unused locals.
2180
2547adb1
CY
21812011-06-10 Chong Yidong <cyd@stupidchicken.com>
2182
2183 * image.c (gif_load): Fix omitted cast error introduced by
2184 2011-06-06 change.
2185
2c8e37d4
MR
21862011-06-10 Martin Rudalics <rudalics@gmx.at>
2187
2188 * window.h (resize_proportionally, orig_total_lines)
2189 (orig_top_line): Remove from window structure.
2190 (set_window_height, set_window_width, change_window_heights)
2191 (Fdelete_window): Remove prototypes.
2192 (resize_frame_windows): Remove duplicate declaration.
2193
440a42e3
EZ
21942011-06-10 Eli Zaretskii <eliz@gnu.org>
2195
2196 * window.h (resize_frame_windows, resize_window_check)
2197 (delete_deletable_window, resize_root_window)
2198 (resize_frame_windows): Declare prototypes.
2199
2200 * window.c (resize_window_apply): Make definition be "static" to
2201 match the prototype.
2202
562dd5e9
MR
22032011-06-10 Martin Rudalics <rudalics@gmx.at>
2204
2205 * window.c: Remove declarations of Qwindow_size_fixed,
2206 window_min_size_1, window_min_size_2, window_min_size,
2207 size_window, window_fixed_size_p, enlarge_window, delete_window.
2208 Remove static from declaration of Qdelete_window, it's
2209 temporarily needed by Fbury_buffer.
2210 (replace_window): Don't assign orig_top_line and
2211 orig_total_lines.
2212 (Fdelete_window, delete_window): Remove. Window deletion is
2213 handled by window.el.
2214 (window_loop): Remove DELETE_OTHER_WINDOWS case. Replace
2215 Fdelete_window calls with calls to Qdelete_window.
2216 (Fdelete_other_windows): Remove. Deleting other windows is
2217 handled by window.el.
2218 (window_fixed_size_p): Remove. Fixed-sizeness of windows is
2219 handled in window.el.
2220 (window_min_size_2, window_min_size_1, window_min_size): Remove.
2221 Window minimum sizes are handled in window.el.
2222 (shrink_windows, size_window, set_window_height)
2223 (set_window_width, change_window_heights, window_height)
2224 (window_width, CURBEG, CURSIZE, enlarge_window)
2225 (adjust_window_trailing_edge, Fadjust_window_trailing_edge)
2226 (Fenlarge_window, Fshrink_window): Remove. Window resizing is
2227 handled in window.el.
2228 (make_dummy_parent): Rename to make_parent_window and give it a
2229 second argument horflag.
2230 (make_window): Don't set resize_proportionally any more.
2231 (Fsplit_window): Remove. Windows are split in window.el.
2232 (save_restore_action, save_restore_orig_size)
2233 (shrink_window_lowest_first, save_restore_orig_size): Remove.
2234 Resize mini windows in window.el.
2235 (grow_mini_window, shrink_mini_window): Implement by calling
2236 Qresize_root_window_vertically, resize_window_check and
2237 resize_window_apply.
2238 (saved_window, Fset_window_configuration, save_window_save): Do
2239 not handle orig_top_line, orig_total_lines, and
2240 resize_proportionally.
2241 (window_min_height, window_min_width): Move to window.el.
2242 (keys_of_window): Move bindings for delete-other-windows,
2243 split-window, delete-window and enlarge-window to window.el.
2244
2245 * buffer.c: Temporarily extern Qdelete_window.
2246 (Fbury_buffer): Temporarily call Qdelete_window instead of
2247 Fdelete_window (Fbury_buffer will move to window.el soon).
2248
2249 * frame.c (set_menu_bar_lines_1): Remove code handling
2250 orig_top_line and orig_total_lines.
2251
2252 * dispnew.c (adjust_frame_glyphs_initially): Don't use
2253 set_window_height but set heights directly.
2254 (change_frame_size_1): Use resize_frame_windows.
2255
2256 * xdisp.c (init_xdisp): Don't use set_window_height but set
2257 heights directly.
2258
2259 * xfns.c (x_set_menu_bar_lines, x_set_tool_bar_lines): Use
2260 resize_frame_windows instead of change_window_heights and run
2261 run_window_configuration_change_hook.
2262
2263 * w32fns.c (x_set_tool_bar_lines): Use resize_frame_windows
2264 instead of change_window_heights and run
2265 run_window_configuration_change_hook.
2266
1a13852e
MR
22672011-06-09 Martin Rudalics <rudalics@gmx.at>
2268
2269 * window.c (replace_window): Rename second argument REPLACEMENT to
2270 NEW. New third argument SETFLAG. Rewrite.
2271 (delete_window, make_dummy_parent): Call replace_window with
2272 third argument 1.
2273 (window_list_1): Move down in code.
2274 (run_window_configuration_change_hook): Move set_buffer part
2275 before select_frame_norecord part in order to unwind correctly.
2276 Rename count1 to count.
2277 (recombine_windows, delete_deletable_window, resize_root_window)
2278 (Fdelete_other_windows_internal)
2279 (Frun_window_configuration_change_hook, make_parent_window)
2280 (resize_window_check, resize_window_apply, Fresize_window_apply)
2281 (resize_frame_windows, Fsplit_window_internal)
2282 (Fdelete_window_internal, Fresize_mini_window_internal): New
2283 functions.
2284 (syms_of_window): New variables Vwindow_splits and Vwindow_nest.
2285
f3d1777e
MR
22862011-06-08 Martin Rudalics <rudalics@gmx.at>
2287
496e208e
MR
2288 * window.h (window): Add some new members to window structure -
2289 normal_lines, normal_cols, new_total, new_normal, clone_number,
2290 splits, nest, prev_buffers, next_buffers.
2291 (WINDOW_TOTAL_SIZE): Move here from window.c.
b9e809c2 2292 (MIN_SAFE_WINDOW_WIDTH, MIN_SAFE_WINDOW_HEIGHT): Define here.
496e208e 2293
f3d1777e
MR
2294 * window.c (Fwindow_height, Fwindow_width, Fwindow_full_width_p):
2295 Remove.
496e208e
MR
2296 (make_dummy_parent): Set new members of windows structure.
2297 (make_window): Move down in code. Handle new members of window
2298 structure.
2299 (Fwindow_clone_number, Fwindow_splits, Fset_window_splits)
2300 (Fwindow_nest, Fset_window_nest, Fwindow_new_total)
2301 (Fwindow_normal_size, Fwindow_new_normal, Fwindow_prev_buffers)
2302 (Fset_window_prev_buffers, Fwindow_next_buffers)
2303 (Fset_window_next_buffers, Fset_window_clone_number): New
2304 functions.
2305 (Fwindow_hscroll, Fwindow_at, Fwindow_point, Fwindow_start)
2306 (Fwindow_end, Fwindow_line_height, Fset_window_dedicated_p):
2307 Doc-string fixes.
2308 (Fwindow_parameters, Fwindow_parameter, Fset_window_parameter):
2309 Argument WINDOW can be now internal window too.
2310 (Fwindow_use_time): Move up in code.
2311 (Fget_buffer_window): Rename argument FRAME to ALL-FRAMES.
2312 Rewrite doc-string.
2313 (Fset_window_configuration, saved_window)
2314 (Fcurrent_window_configuration, save_window_save): Handle new
2315 members of window structure.
b9e809c2
MR
2316 (WINDOW_TOTAL_SIZE, MIN_SAFE_WINDOW_WIDTH)
2317 (MIN_SAFE_WINDOW_HEIGHT): Move to window.h.
2318 (syms_of_window): New Lisp objects Qrecord_window_buffer,
2319 Qwindow_deletable_p, Qdelete_window, Qreplace_buffer_in_windows,
2320 Qget_mru_window, Qresize_root_window,
2321 Qresize_root_window_vertically, Qsafe, Qabove, Qbelow,
2322 Qauto_buffer_name; staticpro them.
f3d1777e 2323
abde8f8c
MR
23242011-06-07 Martin Rudalics <rudalics@gmx.at>
2325
2326 * window.c (Fwindow_total_size, Fwindow_left_column)
2327 (Fwindow_top_line, window_body_lines, Fwindow_body_size)
2328 (Fwindow_list_1): New functions.
2329 (window_box_text_cols): Replace with window_body_cols.
2330 (Fwindow_width, Fscroll_left, Fscroll_right): Use
2331 window_body_cols instead of window_box_text_cols.
fa8a67e6
MR
2332 (delete_window, Fset_window_configuration): Call
2333 delete_all_subwindows with window as argument.
2334 (delete_all_subwindows): Take a window as argument and not a
2335 structure. Rewrite.
190b47e6
MR
2336 (window_loop): Remove handling of GET_LRU_WINDOW and
2337 GET_LARGEST_WINDOW.
2338 (Fget_lru_window, Fget_largest_window): Move to window.el.
abde8f8c
MR
2339
2340 * window.h: Extern window_body_cols instead of
fa8a67e6
MR
2341 window_box_text_cols. delete_all_subwindows now takes a
2342 Lisp_Object as argument.
abde8f8c
MR
2343
2344 * indent.c (compute_motion, Fcompute_motion): Use
2345 window_body_cols instead of window_box_text_cols.
2346
fa8a67e6
MR
2347 * frame.c (delete_frame): Call delete_all_subwindows with root
2348 window as argument.
2349
a54e3482
DC
23502011-06-07 Daniel Colascione <dan.colascione@gmail.com>
2351
2352 * fns.c (Fputhash): Document return value.
2353
60002bf5
CY
23542011-06-06 Chong Yidong <cyd@stupidchicken.com>
2355
2356 * image.c (gif_load): Implement gif89a spec "no disposal" method.
2357
0c671da6 23582011-06-06 Paul Eggert <eggert@cs.ucla.edu>
ccd9a01a 2359
b862a52a 2360 Cons<->int and similar integer overflow fixes (Bug#8794).
77984278 2361
be44ca6c
PE
2362 Check for overflow when converting integer to cons and back.
2363 * charset.c (Fdefine_charset_internal, Fdecode_char):
2364 Use cons_to_unsigned to catch overflow.
2365 (Fencode_char): Use INTEGER_TO_CONS.
2366 * composite.h (LGLYPH_CODE): Use cons_to_unsigned.
2367 (LGLYPH_SET_CODE): Use INTEGER_TO_CONS.
2368 * data.c (long_to_cons, cons_to_long): Remove.
2369 (cons_to_unsigned, cons_to_signed): New functions.
2370 These signal an error for invalid or out-of-range values.
2371 * dired.c (Ffile_attributes): Use INTEGER_TO_CONS.
2372 * fileio.c (Fset_visited_file_modtime): Use CONS_TO_INTEGER.
2373 * font.c (Ffont_variation_glyphs):
2374 * fontset.c (Finternal_char_font): Use INTEGER_TO_CONS.
2375 * lisp.h: Include <intprops.h>.
2376 (INTEGER_TO_CONS, CONS_TO_INTEGER): New macros.
2377 (cons_to_signed, cons_to_unsigned): New decls.
2378 (long_to_cons, cons_to_long): Remove decls.
2379 * undo.c (record_first_change): Use INTEGER_TO_CONS.
2380 (Fprimitive_undo): Use CONS_TO_INTEGER.
2381 * xfns.c (Fx_window_property): Likewise.
2382 * xselect.c: Include <limits.h>.
2383 (x_own_selection, selection_data_to_lisp_data):
2384 Use INTEGER_TO_CONS.
2385 (x_handle_selection_request, x_handle_selection_clear)
2386 (x_get_foreign_selection, Fx_disown_selection_internal)
2387 (Fx_get_atom_name, x_send_client_event): Use CONS_TO_INTEGER.
2388 (lisp_data_to_selection_data): Use cons_to_unsigned.
2389 (x_fill_property_data): Use cons_to_signed.
2390 Report values out of range.
2391
d1f3d2af
PE
2392 Check for buffer and string overflow more precisely.
2393 * buffer.h (BUF_BYTES_MAX): New macro.
2394 * lisp.h (STRING_BYTES_MAX): New macro.
2395 * alloc.c (Fmake_string):
2396 * character.c (string_escape_byte8):
2397 * coding.c (coding_alloc_by_realloc):
2398 * doprnt.c (doprnt):
2399 * editfns.c (Fformat):
2400 * eval.c (verror):
2401 Use STRING_BYTES_MAX, not MOST_POSITIVE_FIXNUM,
2402 since they may not be the same number.
2403 * editfns.c (Finsert_char):
2404 * fileio.c (Finsert_file_contents):
2405 Likewise for BUF_BYTES_MAX.
2406
dd52fcea
PE
2407 * image.c: Use ptrdiff_t, not int, for sizes.
2408 (slurp_file): Switch from int to ptrdiff_t.
2409 All uses changed.
2410 (slurp_file): Check that file size fits in both size_t (for
2411 malloc) and ptrdiff_t (for sanity and safety).
2412
7f9bbdbb
PE
2413 * fileio.c (Fverify_visited_file_modtime): Avoid time overflow
2414 if b->modtime has its maximal value.
2415
dfe18f82
PE
2416 * dired.c (Ffile_attributes): Don't assume EMACS_INT has >32 bits.
2417
84acfcf0
PE
2418 Don't assume time_t can fit into int.
2419 * buffer.h (struct buffer.modtime): Now time_t, not int.
2420 * fileio.c (Fvisited_file_modtime): No need for time_t cast now.
2421 * undo.c (Fprimitive_undo): Use time_t, not int, for time_t value.
2422
ccd9a01a
PE
2423 Minor fixes for signed vs unsigned integers.
2424 * character.h (MAYBE_UNIFY_CHAR):
2425 * charset.c (maybe_unify_char):
2426 * keyboard.c (read_char, reorder_modifiers):
2427 XINT -> XFASTINT, since the integer must be nonnegative.
2428 * ftfont.c (ftfont_spec_pattern):
2429 * keymap.c (access_keymap, silly_event_symbol_error):
2430 XUINT -> XFASTINT, since the integer must be nonnegative.
2431 (Fsingle_key_description, preferred_sequence_p): XUINT -> XINT,
2432 since it makes no difference and we prefer signed.
2433 * keyboard.c (record_char): Use XUINT when all the neighbors do.
2434 (access_keymap): NATNUMP -> INTEGERP, since the integer must be
2435 nonnegative.
2436
d6d100dd
SM
24372011-06-06 Stefan Monnier <monnier@iro.umontreal.ca>
2438
2439 * window.h (Fwindow_frame): Declare.
2440
2b6148e4
PE
24412011-06-06 Paul Eggert <eggert@cs.ucla.edu>
2442
2443 * alloc.c: Simplify handling of large-request failures (Bug#8800).
2444 (SPARE_MEMORY): Always define.
2445 (LARGE_REQUEST): Remove.
2446 (memory_full): Use SPARE_MEMORY rather than LARGE_REQUEST.
2447
f230ecc9
MR
24482011-06-06 Martin Rudalics <rudalics@gmx.at>
2449
727e958e
MR
2450 * lisp.h: Move EXFUNS for Fframe_root_window,
2451 Fframe_first_window and Fset_frame_selected_window to window.h.
2452
2453 * window.h: Move EXFUNS for Fframe_root_window,
2454 Fframe_first_window and Fset_frame_selected_window here from
2455 lisp.h.
2456
2457 * frame.c (Fwindow_frame, Fframe_first_window)
2458 (Fframe_root_window, Fframe_selected_window)
2459 (Fset_frame_selected_window): Move to window.c.
2460 (Factive_minibuffer_window): Move to minibuf.c.
2461 (Fother_visible_frames_p): New function.
2462
2463 * minibuf.c (Factive_minibuffer_window): Move here from frame.c.
2464
f230ecc9
MR
2465 * window.c (decode_window, decode_any_window): Move up in code.
2466 (Fwindowp, Fwindow_live_p): Rewrite doc-strings.
2467 (inhibit_frame_unsplittable): Remove unused variable.
bf60a96b
MR
2468 (Fwindow_buffer): Move up and rewrite doc-string.
2469 (Fwindow_parent, Fwindow_vchild, Fwindow_hchild, Fwindow_next)
2470 (Fwindow_prev): New functions.
727e958e
MR
2471 (Fwindow_frame): Move here from frame.c. Accept any window as
2472 argument.
2473 (Fframe_root_window, Fframe_first_window)
2474 (Fframe_selected_window): Move here from frame.c. Accept frame
2475 or arbitrary window as argument. Update doc-strings.
2476 (Fminibuffer_window): Move up in code.
2477 (Fwindow_minibuffer_p): Move up in code and simplify.
d6d100dd
SM
2478 (Fset_frame_selected_window): Move here from frame.c.
2479 Marginal rewrite.
727e958e
MR
2480 (Fselected_window, select_window, Fselect_window): Move up in
2481 code. Minor doc-string fixes.
f230ecc9 2482
4d09bcf6
PE
24832011-06-06 Paul Eggert <eggert@cs.ucla.edu>
2484
2485 * alloc.c (memory_full) [SYSTEM_MALLOC]: Port to MacOS (Bug#8800).
2486 Do not assume that spare memory exists; that assumption is valid
2487 only if SYSTEM_MALLOC.
2488 (LARGE_REQUEST): New macro, so that the issue of large requests
2489 is separated from the issue of spare memory.
2490
810928a2
AS
24912011-06-05 Andreas Schwab <schwab@linux-m68k.org>
2492
172418ad
AS
2493 * editfns.c (Fformat): Correctly handle zero flag with hexadecimal
2494 format. (Bug#8806)
2495
43f862f7
AS
2496 * gtkutil.c (xg_get_default_scrollbar_width): Avoid warning.
2497
810928a2
AS
2498 * xfns.c (x_set_scroll_bar_default_width): Move declarations
2499 before statements.
2500
a059fe24
JD
25012011-06-05 Jan Djärv <jan.h.d@swipnet.se>
2502
2503 * gtkutil.c (xg_get_default_scrollbar_width): New function.
2504
2505 * gtkutil.h: Declare xg_get_default_scrollbar_width.
2506
2507 * xfns.c (x_set_scroll_bar_default_width): If USE_GTK, get
2508 min width by calling x_set_scroll_bar_default_width (Bug#8505).
2509
989bf368
JB
25102011-06-05 Juanma Barranquero <lekktu@gmail.com>
2511
2512 * xdisp.c (single_display_spec_intangible_p): Remove declaration.
2513
4b80f674
CY
25142011-06-04 Chong Yidong <cyd@stupidchicken.com>
2515
2516 * xselect.c (x_clipboard_manager_save): Remove redundant arg.
2517 (x_clipboard_manager_save): Add return value.
d6d100dd
SM
2518 (x_clipboard_manager_error_1, x_clipboard_manager_error_2):
2519 New error handlers.
4b80f674
CY
2520 (x_clipboard_manager_save_frame, x_clipboard_manager_save_all):
2521 Obey Vx_select_enable_clipboard_manager. Catch errors in
2522 x_clipboard_manager_save (Bug#8779).
2523 (Vx_select_enable_clipboard_manager): New variable.
de65b42c 2524 (x_get_foreign_selection): Reduce scope of x_catch_errors (Bug#8790).
4b80f674 2525
99a33b77 25262011-06-04 Dan Nicolaescu <dann@ics.uci.edu>
8b3115e7
DN
2527
2528 * emacs.c (main): Warn when starting a GTK emacs in daemon mode.
2529
99a33b77 25302011-06-04 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
14eca62f
YM
2531
2532 * fringe.c (update_window_fringes): Don't update overlay arrow bitmap
2533 in the current matrix if keep_current_p is non-zero.
2534
8264569d
EZ
25352011-06-04 Eli Zaretskii <eliz@gnu.org>
2536
2537 * bidi.c (bidi_level_of_next_char): Fix last change.
2538
57f97249
EZ
25392011-06-03 Eli Zaretskii <eliz@gnu.org>
2540
fec2107c 2541 Support bidi reordering of text covered by display properties.
57f97249 2542
fec2107c
EZ
2543 * bidi.c (bidi_copy_it): Use offsetof instead of emulating it.
2544 (bidi_fetch_char, bidi_fetch_char_advance): New functions.
2545 (bidi_cache_search, bidi_cache_iterator_state)
2546 (bidi_paragraph_init, bidi_resolve_explicit, bidi_resolve_weak)
d6d100dd
SM
2547 (bidi_level_of_next_char, bidi_move_to_visually_next):
2548 Support character positions inside a run of characters covered by a
fec2107c
EZ
2549 display string.
2550 (bidi_paragraph_init, bidi_resolve_explicit_1)
2551 (bidi_level_of_next_char): Call bidi_fetch_char and
2552 bidi_fetch_char_advance instead of FETCH_CHAR and
2553 FETCH_CHAR_ADVANCE.
2554 (bidi_init_it): Initialize new members.
2555 (LRE_CHAR, RLE_CHAR, PDF_CHAR, LRO_CHAR, RLO_CHAR): Remove macro
2556 definitions.
2557 (bidi_explicit_dir_char): Lookup character type in bidi_type_table,
2558 instead of using explicit *_CHAR codes.
d6d100dd
SM
2559 (bidi_resolve_explicit, bidi_resolve_weak):
2560 Use FETCH_MULTIBYTE_CHAR instead of FETCH_CHAR, as reordering of
fec2107c
EZ
2561 bidirectional text is supported only in multibyte buffers.
2562 (bidi_init_it): Accept additional argument FRAME_WINDOW_P and use
2563 it to initialize the frame_window_p member of struct bidi_it.
2564 (bidi_cache_iterator_state, bidi_resolve_explicit_1)
2565 (bidi_resolve_explicit, bidi_resolve_weak)
2566 (bidi_level_of_next_char, bidi_move_to_visually_next): Abort if
2567 bidi_it->nchars is non-positive.
2568 (bidi_level_of_next_char): Don't try to lookup the cache for the
2569 next/previous character if nothing is cached there yet, or if we
2570 were just reseat()'ed to a new position.
c40e2fb2 2571
0e14fe90
EZ
2572 * xdisp.c (set_cursor_from_row): Set start and stop points
2573 according to the row's direction when priming the loop that looks
2574 for the glyph on which to display cursor.
2575 (single_display_spec_intangible_p): Function deleted.
2576 (display_prop_intangible_p): Reimplement to call
2577 handle_display_spec instead of single_display_spec_intangible_p.
d6d100dd
SM
2578 Accept 3 additional arguments needed by handle_display_spec.
2579 This fixes incorrect cursor motion across display property with complex
0e14fe90
EZ
2580 values: lists, `(when COND...)' forms, etc.
2581 (single_display_spec_string_p): Support property values that are
2582 lists with the argument STRING its top-level element.
2583 (display_prop_string_p): Fix the condition for processing a
2584 property that is a list to be consistent with handle_display_spec.
fec2107c 2585 (handle_display_spec): New function, refactored from the
fc6f18ce
EZ
2586 last portion of handle_display_prop.
2587 (compute_display_string_pos): Accept additional argument
2588 FRAME_WINDOW_P. Call handle_display_spec to determine whether the
2589 value of a `display' property is a "replacing spec".
2590 (handle_single_display_spec): Accept 2 additional arguments BUFPOS
2591 and FRAME_WINDOW_P. If IT is NULL, don't set up the iterator from
2592 the display property, but just return a value indicating whether
2593 the display property will replace the characters it covers.
2594 (Fcurrent_bidi_paragraph_direction): Initialize the nchars and
2595 frame_window_p members of struct bidi_it.
d6d100dd
SM
2596 (compute_display_string_pos, compute_display_string_end):
2597 New functions.
fec2107c
EZ
2598 (push_it): Accept second argument POSITION, where pop_it should
2599 jump to continue iteration.
2600 (reseat_1): Initialize bidi_it.disp_pos.
fc6f18ce 2601
fec2107c
EZ
2602 * keyboard.c (adjust_point_for_property): Adjust the call to
2603 display_prop_intangible_p to its new signature.
fc6f18ce
EZ
2604
2605 * dispextern.h (struct bidi_it): New member frame_window_p.
fec2107c
EZ
2606 (bidi_init_it): Update prototypes.
2607 (display_prop_intangible_p): Update prototype.
d6d100dd
SM
2608 (compute_display_string_pos, compute_display_string_end):
2609 Declare prototypes.
fec2107c
EZ
2610 (struct bidi_it): New members nchars and disp_pos. ch_len is now
2611 EMACS_INT.
fc6f18ce 2612
40087514 26132011-06-02 Paul Eggert <eggert@cs.ucla.edu>
0de4bb68 2614
57f53182
PE
2615 Malloc failure behavior now depends on size of allocation.
2616 * alloc.c (buffer_memory_full, memory_full): New arg NBYTES.
2617 * lisp.h: Change signatures accordingly.
2618 * alloc.c, buffer.c, editfns.c, menu.c, minibuf.c, xterm.c:
2619 All callers changed. (Bug#8762)
2620
2621 * gnutls.c: Use Emacs's memory allocators.
2622 Without this change, the gnutls library would invoke malloc etc.
2623 directly, which causes problems on non-SYNC_INPUT hosts, and which
2624 runs afoul of improving memory_full behavior. (Bug#8761)
2625 (fn_gnutls_global_set_mem_functions): New macro or function pointer.
2626 (emacs_gnutls_global_init): Use it to specify xmalloc, xrealloc,
2627 xfree instead of the default malloc, realloc, free.
2628 (Fgnutls_boot): No need to check for memory allocation failure,
2629 since xmalloc does that for us.
2630
ac32cd99 2631 Remove arbitrary limit of 2**31 entries in hash tables. (Bug#8771)
3870d916
PE
2632 * category.c (hash_get_category_set):
2633 * ccl.c (ccl_driver):
2634 * charset.c (Fdefine_charset_internal):
2635 * charset.h (struct charset.hash_index):
2636 * composite.c (get_composition_id, gstring_lookup_cache)
2637 (composition_gstring_put_cache):
2638 * composite.h (struct composition.hash_index):
2639 * dispextern.h (struct image.hash):
2640 * fns.c (next_almost_prime, larger_vector, cmpfn_eql)
2641 (cmpfn_equal, cmpfn_user_defined, hashfn_eq, hashfn_eql)
2642 (hashfn_equal, hashfn_user_defined, make_hash_table)
2643 (maybe_resize_hash_table, hash_lookup, hash_put)
2644 (hash_remove_from_table, hash_clear, sweep_weak_table, SXHASH_COMBINE)
2645 (sxhash_string, sxhash_list, sxhash_vector, sxhash_bool_vector)
2646 (Fsxhash, Fgethash, Fputhash, Fmaphash):
2647 * image.c (make_image, search_image_cache, lookup_image)
2648 (xpm_put_color_table_h):
2649 * lisp.h (struct Lisp_Hash_Table):
0de4bb68 2650 * minibuf.c (Ftry_completion, Fall_completions, Ftest_completion):
ac389d0c 2651 * print.c (print): Use 'EMACS_UINT' and 'EMACS_INT'
3870d916 2652 for hashes and hash indexes, instead of 'unsigned' and 'int'.
40087514
PE
2653 * alloc.c (allocate_vectorlike):
2654 Check for overflow in vector size calculations.
2655 * ccl.c (ccl_driver):
2656 Check for overflow when converting EMACS_INT to int.
0de4bb68
PE
2657 * fns.c, image.c: Remove unnecessary static decls that would otherwise
2658 need to be updated by these changes.
40087514
PE
2659 * fns.c (make_hash_table, maybe_resize_hash_table):
2660 Check for integer overflow with large hash tables.
0de4bb68
PE
2661 (make_hash_table, maybe_resize_hash_table, Fmake_hash_table):
2662 Prefer the faster XFLOAT_DATA to XFLOATINT where either will do.
2663 (SXHASH_REDUCE): New macro.
2664 (sxhash_string, sxhash_list, sxhash_vector, sxhash_bool_vector):
2665 Use it instead of discarding useful hash info with large hash values.
2666 (sxhash_float): New function.
2667 (sxhash): Use it. No more need for "& INTMASK" due to above changes.
2668 * lisp.h (FIXNUM_BITS): New macro, useful for SXHASH_REDUCE etc.
40087514
PE
2669 (MOST_NEGATIVE_FIXNUM, MOST_POSITIVE_FIXNUM, INTMASK):
2670 Rewrite to use FIXNUM_BITS, as this simplifies things.
0de4bb68
PE
2671 (next_almost_prime, larger_vector, sxhash, hash_lookup, hash_put):
2672 Adjust signatures to match updated version of code.
2673 (consing_since_gc): Now EMACS_INT, since a single hash table can
2674 use more than INT_MAX bytes.
2675
698d32e2
DN
26762011-06-01 Dan Nicolaescu <dann@ics.uci.edu>
2677
2678 Make it possible to build with GCC-4.6+ -O2 -flto.
2679
2680 * emacs.c (__malloc_initialize_hook): Mark as EXTERNALLY_VISIBLE.
2681
fd6fa53f
SM
26822011-06-01 Stefan Monnier <monnier@iro.umontreal.ca>
2683
2684 * minibuf.c (get_minibuffer, read_minibuf_unwind):
2685 Call minibuffer-inactive-mode.
2686
864db017
JB
26872011-05-31 Juanma Barranquero <lekktu@gmail.com>
2688
2689 * makefile.w32-in ($(BLD)/data.$(O), $(BLD)/editfns.$(O)):
2690 Update dependencies.
2691
2ad0baf4
DN
26922011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
2693
2694 * data.c (init_data): Remove code for UTS, this system is not
2695 supported anymore.
2696
4fcc2638
DN
26972011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
2698
2699 Don't force ./temacs to start in terminal mode.
2700
2701 * frame.c (make_initial_frame): Initialize faces in all cases, not
2702 only when CANNOT_DUMP is defined.
2703 * dispnew.c (init_display): Remove CANNOT_DUMP condition.
2704
c56e0fd5
DN
27052011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
2706
2707 * dispnew.c (add_window_display_history): Use const for the string
2708 pointer. Remove declaration, not needed.
2709
333d54da 27102011-05-31 Paul Eggert <eggert@cs.ucla.edu>
9cf9f756 2711
55d4c1b2 2712 Use 'inline', not 'INLINE'.
333d54da 2713 <http://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00914.html>
55d4c1b2
PE
2714 * alloc.c, fontset.c (INLINE): Remove.
2715 * alloc.c, bidi.c, charset.c, coding.c, dispnew.c, fns.c, image.c:
2716 * intervals.c, keyboard.c, process.c, syntax.c, textprop.c, w32term.c:
2717 * xdisp.c, xfaces.c, xterm.c: Replace all uses of INLINE with inline.
2718 * gmalloc.c (register_heapinfo): Use inline unconditionally.
2719 * lisp.h (LISP_MAKE_RVALUE): Use inline, not __inline__.
2720
738db178
DN
27212011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
2722
2723 Make it possible to run ./temacs.
2724
2725 * callproc.c (set_initial_environment): Remove CANNOT_DUMP code,
2726 syms_of_callproc does the same thing. Remove test for
2727 "initialized", do it in the caller.
2728 * emacs.c (main): Avoid calling set_initial_environment when dumping.
2729
620c53a6
SM
27302011-05-31 Stefan Monnier <monnier@iro.umontreal.ca>
2731
2732 * minibuf.c (Finternal_complete_buffer): Return `category' metadata.
2733 (read_minibuf): Use get_minibuffer.
2734 (syms_of_minibuf): Use DEFSYM.
2735 (Qmetadata): New var.
2736 * data.c (Qbuffer): Don't make it static.
2737 (syms_of_data): Use DEFSYM.
2738
e003a292
PE
27392011-05-31 Paul Eggert <eggert@cs.ucla.edu>
2740
2741 * ccl.c (CCL_CODE_RANGE): Allow negative numbers. (Bug#8751)
2742 (CCL_CODE_MIN): New macro.
2743
ed008a6d
PE
27442011-05-30 Paul Eggert <eggert@cs.ucla.edu>
2745
3687c2ef
PE
2746 * alloc.c (lisp_align_malloc): Omit unnecessary val==NULL tests.
2747
ed008a6d
PE
2748 * eval.c (Qdebug): Now static.
2749 * lisp.h (Qdebug): Remove decl. This reverts a part of the
2750 2011-04-26T11:26:05Z!dan.colascione@gmail.com that inadvertently undid part of
2751 2011-04-14T06:48:41Z!eggert@cs.ucla.edu.
2752
d66c4c7c
CY
27532011-05-29 Chong Yidong <cyd@stupidchicken.com>
2754
2755 * image.c: Various fixes to ImageMagick code comments.
2756 (Fimagemagick_types): Doc fix.
2757
5fbc2025
PE
27582011-05-29 Paul Eggert <eggert@cs.ucla.edu>
2759
0196f88a
PE
2760 Minor fixes prompted by GCC 4.6.0 warnings.
2761
2762 * xselect.c (converted_selections, conversion_fail_tag): Now static.
2763
5fbc2025
PE
2764 * emacs.c [HAVE_X_WINDOWS]: Include "xterm.h".
2765 (x_clipboard_manager_save_all): Move extern decl to ...
2766 * xterm.h: ... here, so that it can be checked for consistency.
2767
1dd3c2d9
CY
27682011-05-29 Chong Yidong <cyd@stupidchicken.com>
2769
2770 * xselect.c (x_clipboard_manager_save_frame)
2771 (x_clipboard_manager_save_all): New functions.
2772 (Fx_clipboard_manager_save): Lisp function deleted.
2773
2774 * emacs.c (Fkill_emacs): Call x_clipboard_manager_save_all.
2775 * frame.c (delete_frame): Call x_clipboard_manager_save_frame.
2776
2777 * xterm.h: Update prototype.
2778
5ba6571d
WX
27792011-05-28 William Xu <william.xwl@gmail.com>
2780
2781 * nsterm.m (ns_term_shutdown): Synchronize user defaults before
2782 exiting (Bug#8239).
2783
3eaff834
JM
27842011-05-28 Jim Meyering <meyering@redhat.com>
2785
e1900994 2786 Avoid a sign-extension bug in crypto_hash_function.
3eaff834
JM
2787 * fns.c (to_uchar): Define.
2788 (crypto_hash_function): Use it to convert some newly-signed
2789 variables to unsigned, to avoid sign-extension bugs. For example,
2790 without this change, (md5 "truc") would evaluate to
2791 45723a2aff78ff4fff7fff1114760e62 rather than the expected
2792 45723a2af3788c4ff17f8d1114760e62. Reported by Antoine Levitt in
e1900994 2793 https://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00883.html.
3eaff834 2794
0f6990a7
PE
27952011-05-27 Paul Eggert <eggert@cs.ucla.edu>
2796
2797 Integer overflow fixes.
c8a9ca5a 2798
08686060
PE
2799 * dbusbind.c: Serial number integer overflow fixes.
2800 (CHECK_DBUS_SERIAL_GET_SERIAL): New macro.
08686060
PE
2801 (Fdbus_call_method_asynchronously, xd_read_message_1): Use a float
2802 to hold a serial number that is too large for a fixnum.
2803 (Fdbus_method_return_internal, Fdbus_method_error_internal):
2804 Check for serial numbers out of range. Decode any serial number
59568bf0 2805 that was so large that it became a float. (Bug#8722)
08686060 2806
2d1fc3c7
PE
2807 * dbusbind.c: Use XFASTINT rather than XUINT, and check for nonneg.
2808 (Fdbus_call_method, Fdbus_call_method_asynchronously):
2809 Use XFASTINT rather than XUINT when numbers are nonnegative.
2810 (xd_append_arg, Fdbus_method_return_internal):
2811 (Fdbus_method_error_internal): Likewise. Also, for unsigned
2812 arguments, check that Lisp number is nonnegative, rather than
59568bf0 2813 silently wrapping negative numbers around. (Bug#8722)
30217ff0 2814 (xd_read_message_1): Don't assume dbus_uint32_t can fit in int.
59568bf0 2815 (Bug#8722)
2d1fc3c7 2816
c8a9ca5a
PE
2817 * data.c (arith_driver, Flsh): Avoid unnecessary casts to EMACS_UINT.
2818
519e1d69
PE
2819 * ccl.c (ccl_driver): Redo slightly to avoid the need for 'unsigned'.
2820
30569699
PE
2821 ccl: add integer overflow checks
2822 * ccl.c (CCL_CODE_MAX, GET_CCL_RANGE, GET_CCL_CODE, GET_CCL_INT):
2823 (IN_INT_RANGE): New macros.
2824 (ccl_driver): Use them to check for integer overflow when
2825 decoding a CCL program. Many of the new checks are whether XINT (x)
2826 fits in int; it doesn't always, on 64-bit hosts. The new version
2827 doesn't catch all possible integer overflows, but it's an
847044ea 2828 improvement. (Bug#8719)
30569699 2829
c11285dc
PE
2830 * alloc.c (make_event_array): Use XINT, not XUINT.
2831 There's no need for unsigned here.
2832
fdccd48e
PE
2833 * mem-limits.h (EXCEEDS_LISP_PTR) [!USE_LSB_TAG]: EMACS_UINT -> uintptr_t
2834 This follows up to the 2011-05-06 change that substituted uintptr_t
2835 for EMACS_INT. This case wasn't caught back then.
2836
37910ab2
PE
2837 Rework Fformat to avoid integer overflow issues.
2838 * editfns.c: Include <float.h> unconditionally, as it's everywhere
2839 now (part of C89). Include <verify.h>.
2840 (MAX_10_EXP, CONVERTED_BYTE_SIZE): Remove; no longer needed.
2841 (pWIDE, pWIDElen, signed_wide, unsigned_wide): New defns.
2842 (Fformat): Avoid the prepass trying to compute sizes; it was only
2843 approximate and thus did not catch overflow reliably. Instead, walk
2844 through the format just once, formatting and computing sizes as we go,
2845 checking for integer overflow at every step, and allocating a larger
2846 buffer as needed. Keep track separately whether the format is
2847 multibyte. Keep only the most-recently calculated precision, rather
2848 than them all. Record whether each argument has been converted to
2849 string. Use EMACS_INT, not int, for byte and char and arg counts.
2850 Support field widths and precisions larger than INT_MAX. Avoid
2851 sprintf's undefined behavior with conversion specifications such as %#d
2852 and %.0c. Fix bug with strchr succeeding on '\0' when looking for
2853 flags. Fix bug with (format "%c" 256.0). Avoid integer overflow when
2854 formatting out-of-range floating point numbers with int
9173deec 2855 formats. (Bug#8668)
37910ab2 2856
2e6578fb
PE
2857 * lisp.h (FIXNUM_OVERFLOW_P): Work even if arg is a NaN.
2858
0ae6bdee
PE
2859 * data.c: Avoid integer truncation in expressions involving floats.
2860 * data.c: Include <intprops.h>.
2861 (arith_driver): When there's an integer overflow in an expression
2862 involving floating point, convert the integers to floating point
2863 so that the resulting value does not suffer from catastrophic
2864 integer truncation. For example, on a 64-bit host (* 4
2865 most-negative-fixnum 0.5) should yield about -4.6e+18, not zero.
2866 Do not rely on undefined behavior after integer overflow.
2867
de883a70
PE
2868 merge count_size_as_multibyte, parse_str_to_multibyte
2869 * character.c, character.h (count_size_as_multibyte):
fd6fa53f 2870 Rename from parse_str_to_multibyte; all uses changed.
de883a70
PE
2871 Check for integer overflow.
2872 * insdel.c, lisp.h (count_size_as_multibyte): Remove,
2873 since it's now a duplicate of the other. This is more of
2874 a character than a buffer op, so better that it's in character.c.
2875 * fns.c, print.c: Adjust to above changes.
2876
2ff916cb
PE
28772011-05-27 Stefan Monnier <monnier@iro.umontreal.ca>
2878
2879 * xselect.c (x_convert_selection): Yet another int/Lisp_Object mixup.
2880
f1b54466
PE
28812011-05-27 Paul Eggert <eggert@cs.ucla.edu>
2882
fb1ac845
PE
2883 * xselect.c: Fix minor problems prompted by GCC 4.6.0 warnings.
2884 (x_handle_selection_request, frame_for_x_selection): Remove unused vars.
2885 (x_clipboard_manager_save): Now static.
2886 (Fx_clipboard_manager_save): Rename local to avoid shadowing.
2887
f1b54466
PE
2888 * fns.c: Fix minor problems prompted by GCC 4.6.0 warnings.
2889 (crypto_hash_function): Now static.
2890 Fix pointer signedness problems. Avoid unnecessary initializations.
2891
a9f737ee
CY
28922011-05-27 Chong Yidong <cyd@stupidchicken.com>
2893
2894 * termhooks.h (Vselection_alist): Make it terminal-local.
2895
2896 * terminal.c (create_terminal): Initialize it.
2897
2898 * xselect.c: Support for clipboard managers.
2899 (Vselection_alist): Move to termhooks.h as terminal-local var.
2900 (LOCAL_SELECTION): New macro.
2901 (x_atom_to_symbol): Handle x_display_info_for_display fail case.
2902 (symbol_to_x_atom): Remove gratuitous arg.
2903 (x_handle_selection_request, lisp_data_to_selection_data)
2904 (x_get_foreign_selection, Fx_register_dnd_atom): Callers changed.
620c53a6
SM
2905 (x_own_selection, x_get_local_selection, x_convert_selection):
2906 New arg, specifying work frame. Use terminal-local Vselection_alist.
a9f737ee
CY
2907 (some_frame_on_display): Delete unused function.
2908 (Fx_own_selection_internal, Fx_get_selection_internal)
2909 (Fx_disown_selection_internal, Fx_selection_owner_p)
2910 (Fx_selection_exists_p): New optional frame arg.
2911 (frame_for_x_selection, Fx_clipboard_manager_save): New functions.
2912 (x_handle_selection_clear): Don't treat other terminals with the
2913 same keyboard specially. Use the terminal-local Vselection_alist.
2914 (x_clear_frame_selections): Use Frun_hook_with_args.
2915
2916 * xterm.c (x_term_init): Intern ATOM and CLIPBOARD_MANAGER atoms.
2917
2918 * xterm.h: Add support for those atoms.
2919
e067f0c1
CY
29202011-05-26 Chong Yidong <cyd@stupidchicken.com>
2921
2922 * xselect.c: ICCCM-compliant handling of MULTIPLE targets.
2923 (converted_selections, conversion_fail_tag): New global variables.
2924 (x_selection_request_lisp_error): Free the above.
2925 (x_get_local_selection): Remove unnecessary code.
2926 (x_reply_selection_request): Args changed; handle arbitrary array
620c53a6
SM
2927 of converted selections stored in converted_selections.
2928 Separate the XChangeProperty and SelectionNotify steps.
e067f0c1
CY
2929 (x_handle_selection_request): Rewrite to handle MULTIPLE target.
2930 (x_convert_selection): New function.
2931 (x_handle_selection_event): Simplify.
2932 (x_get_foreign_selection): Don't ignore incoming requests while
2933 waiting for an answer; this will fail when we implement
2934 SAVE_TARGETS, and seems unnecessary anyway.
2935 (selection_data_to_lisp_data): Recognize ATOM_PAIR type.
2936 (Vx_sent_selection_functions): Doc fix.
2937
0f4aebc0
LL
29382011-05-26 Leo Liu <sdl.web@gmail.com>
2939
2940 * editfns.c (Ftranspose_regions): Allow empty regions. (Bug#8699)
2941
e61124cd
YM
29422011-05-25 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
2943
2944 * dispextern.h (struct glyph_row): New member fringe_bitmap_periodic_p.
2945
2946 * dispnew.c (shift_glyph_matrix, scrolling_window): Mark scrolled row
2947 for fringe update if it has periodic bitmap.
ac389d0c 2948 (row_equal_p): Also compare left_fringe_offset, right_fringe_offset,
e61124cd
YM
2949 and fringe_bitmap_periodic_p.
2950
2951 * fringe.c (get_fringe_bitmap_data): New function.
2952 (draw_fringe_bitmap_1, update_window_fringes): Use it.
2953 (update_window_fringes): Record periodicity of fringe bitmap in glyph
2954 row. Mark glyph row for fringe update if periodicity changed.
2955
2956 * xdisp.c (try_window_reusing_current_matrix): Don't mark scrolled row
2957 for fringe update unless it has periodic bitmap.
2958
f16d9837
KH
29592011-05-25 Kenichi Handa <handa@m17n.org>
2960
2961 * xdisp.c (get_next_display_element): Set correct it->face_id for
2962 a static composition.
2963
e1b90ef6
LL
29642011-05-24 Leo Liu <sdl.web@gmail.com>
2965
2966 * deps.mk (fns.o):
2967 * makefile.w32-in ($(BLD)/fns.$(O)): Include sha1.h.
2968
2969 * fns.c (crypto_hash_function, Fsha1): New function.
2970 (Fmd5): Use crypto_hash_function.
2971 (syms_of_fns): Add Ssha1.
2972
7400048f
PE
29732011-05-22 Paul Eggert <eggert@cs.ucla.edu>
2974
2975 * gnutls.c: Remove unused macros.
2976 (fn_gnutls_transport_set_lowat, fn_gnutls_transport_set_pull_function):
2977 (fn_gnutls_transport_set_push_function) [!WINDOWSNT]:
2978 Remove macros that are defined and never used.
2979 Caught by gcc -Wunused-macros (GCC 4.6.0, Fedora 14).
2980
abb71cf4
CY
29812011-05-22 Chong Yidong <cyd@stupidchicken.com>
2982
2983 * xselect.c (syms_of_xselect): Remove unused symbol SAVE_TARGETS.
2984 (Fx_get_selection_internal): Minor cleanup.
2985 (Fx_own_selection_internal): Rename arguments for consistency with
2986 select.el.
2987
6307db39
PE
29882011-05-22 Paul Eggert <eggert@cs.ucla.edu>
2989
2990 * xselect.c (QSAVE_TARGETS): New static var, to fix build failure.
2991
f3d4e0a4
CY
29922011-05-22 Chong Yidong <cyd@stupidchicken.com>
2993
2994 * xselect.c (syms_of_xselect): Include character.h; use DEFSYM.
2995
4d8ade89
YM
29962011-05-21 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
2997
2998 * dispnew.c (scrolling_window): Don't exclude the case that the
2999 last enabled row in the desired matrix touches the bottom boundary.
3000
32078c8d
GM
30012011-05-21 Glenn Morris <rgm@gnu.org>
3002
3003 * Makefile.in ($(etc)/DOC): Make second command line even shorter.
33cf345f
GM
3004 (SOME_MACHINE_OBJECTS): Replace FONT_OBJ by its maximal expansion,
3005 and add some more files.
32078c8d 3006
7285dc67
EZ
30072011-05-20 Eli Zaretskii <eliz@gnu.org>
3008
3009 * callproc.c (Fcall_process) [MSDOS]: Fix arguments to
3010 report_file_error introduced by the change from 2011-05-07.
3011
89d1bd22
PE
30122011-05-20 Paul Eggert <eggert@cs.ucla.edu>
3013
3014 * systime.h (Time): Define only if emacs is defined.
3015 This is to allow ../lib-src/profile.c to be compiled on FreeBSD,
3016 where the include path doesn't have X11/X.h by default. See
3017 <http://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00561.html>.
3018
e23640bb 30192011-05-20 Kenichi Handa <handa@m17n.org>
31bfc35c
KH
3020
3021 * composite.c (find_automatic_composition): Fix previous change.
3022
b9704ad9
GM
30232011-05-20 Glenn Morris <rgm@gnu.org>
3024
3025 * lisp.mk: New file, split from Makefile.in.
3026 * Makefile.in (lisp): Move to separate file, inserted by @lisp_frag@.
3027 (shortlisp): Remove.
3028 ($(etc)/DOC): Edit lisp.mk rather than using $shortlisp.
3029
4a720484
GM
30302011-05-19 Glenn Morris <rgm@gnu.org>
3031
3032 * Makefile.in (MSDOS_SUPPORT_REAL, MSDOS_SUPPORT, NS_SUPPORT)
3033 (REAL_MOUSE_SUPPORT, GPM_MOUSE_SUPPORT, MOUSE_SUPPORT, TOOLTIP_SUPPORT)
3034 (BASE_WINDOW_SUPPORT, X_WINDOW_SUPPORT, WINDOW_SUPPORT): Remove.
3035 (lisp): Set the order to that of loadup.el.
3036 (shortlisp): Make it a copy of $lisp.
3037 (SOME_MACHINE_LISP): Remove.
3038 ($(etc)/DOC): Depend just on $lisp, not $SOME_MACHINE_LISP too.
3039 Use just $shortlisp, not $SOME_MACHINE_LISP too.
3040
a28d4396
KH
30412011-05-18 Kenichi Handa <handa@m17n.org>
3042
3043 * composite.c (CHAR_COMPOSABLE_P): Add more check for efficiency.
3044 (BACKWARD_CHAR): Wrap the arg STOP by parenthesis.
3045 (find_automatic_composition): Mostly rewrite for efficiency.
3046
a2b1fa8e
JB
30472011-05-18 Juanma Barranquero <lekktu@gmail.com>
3048
3049 * makefile.w32-in: Update dependencies.
3050
8e1f5610
CS
30512011-05-18 Christoph Scholtes <cschol2112@googlemail.com>
3052
3053 * menu.c: Include limits.h (fixes the MS-Windows build broken by
7d7d0045 3054 2011-06-18T18:49:19Z!cyd@stupidchicken.com).
8e1f5610 3055
7025ee00 30562011-05-18 Paul Eggert <eggert@cs.ucla.edu>
cb93f9be 3057
cdfa6eab
PE
3058 Fix some integer overflow issues, such as string length overflow.
3059
06d6db33
PE
3060 * insdel.c (count_size_as_multibyte): Check for string overflow.
3061
2b4560a8
PE
3062 * character.c (lisp_string_width): Check for string overflow.
3063 Use EMACS_INT, not int, for string indexes and lengths; in
3064 particular, 2nd arg is now EMACS_INT, not int. Do not crash if
3065 the resulting string length overflows an EMACS_INT; instead,
3066 report a string overflow if no precision given. When checking for
3067 precision exhaustion, use a check that cannot possibly have
3068 integer overflow. (Bug#8675)
3069 * character.h (lisp_string_width): Adjust to new signature.
3070
cb93f9be
PE
3071 * alloc.c (string_overflow): New function.
3072 (Fmake_string): Use it. This doesn't change behavior, but saves
3073 a few bytes and will simplify future changes.
3074 * character.c (string_escape_byte8): Likewise.
3075 * lisp.h (string_overflow): New decl.
3076
1a1f3366
PE
3077 Fixups, following up to the user-interface timestamp change.
3078 * nsterm.m (last_mouse_movement_time, ns_mouse_position): Use Time
3079 for UI timestamps, instead of unsigned long.
9fbd6841
PE
3080 * msdos.c (mouse_get_pos): Likewise.
3081 * w32inevt.c (movement_time, w32_console_mouse_position): Likewise.
1a1f3366
PE
3082 * w32gui.h (Time): Define by including "systime.h" rather than by
3083 declaring it ourselves. (Bug#8664)
3084
d4e3e4d3
PE
3085 * dispextern.h (struct image): Don't assume time_t <= unsigned long.
3086 * image.c (clear_image_cache): Likewise.
3087
f6a24d19
PE
3088 * term.c (term_mouse_position): Don't assume time_t wraparound.
3089
08dc5ae6
PE
3090 Be more systematic about user-interface timestamps.
3091 Before, the code sometimes used 'Time', sometimes 'unsigned long',
620c53a6
SM
3092 and sometimes 'EMACS_UINT', to represent these timestamps.
3093 This change causes it to use 'Time' uniformly, as that's what X uses.
08dc5ae6
PE
3094 This makes the code easier to follow, and makes it easier to catch
3095 integer overflow bugs such as Bug#8664.
3096 * frame.c (Fmouse_position, Fmouse_pixel_position):
3097 Use Time, not unsigned long, for user-interface timestamps.
3098 * keyboard.c (last_event_timestamp, kbd_buffer_get_event): Likewise.
3099 (button_down_time, make_lispy_position, make_lispy_movement): Likewise.
3100 * keyboard.h (last_event_timestamp): Likewise.
3101 * menu.c (Fx_popup_menu) [!HAVE_X_WINDOWS]: Likewise.
3102 * menu.h (xmenu_show): Likewise.
3103 * term.c (term_mouse_position): Likewise.
3104 * termhooks.h (struct input_event.timestamp): Likewise.
3105 (struct terminal.mouse_position_hook): Likewise.
3106 * xmenu.c (create_and_show_popup_menu, xmenu_show): Likewise.
3107 * xterm.c (XTmouse_position, x_scroll_bar_report_motion): Likewise.
3108 * systime.h (Time): New decl. Pull it in from <X11/X.h> if
3109 HAVE_X_WINDOWS, otherwise define it as unsigned long, which is
3110 what it was before.
3111 * menu.h, termhooks.h: Include "systime.h", for Time.
3112
8e55734a
PE
3113 * keyboard.c (make_lispy_event): Fix problem in integer overflow.
3114 Don't assume that the difference between two unsigned long values
3115 can fit into an integer. At this point, we know button_down_time
3116 <= event->timestamp, so the difference must be nonnegative, so
3117 there's no need to cast the result if double-click-time is
3118 nonnegative, as it should be; check that it's nonnegative, just in
3119 case. This bug is triggered when events are more than 2**31 ms
86db42d2 3120 apart (about 25 days). (Bug#8664)
8e55734a 3121
841f1b75 3122 * xselect.c (last_event_timestamp): Remove duplicate decl.
6434756c 3123 (x_own_selection): Remove needless cast to unsigned long.
841f1b75 3124
3e26f69c
PE
3125 * xmenu.c (set_frame_menubar): Use int, not EMACS_UINT, for indexes
3126 that always fit in int. Use a sentinel instead of a counter, to
3127 avoid a temp and to allay GCC's concerns about possible int overflow.
d230cb74
PE
3128 * frame.h (struct frame): Use int for menu_bar_items_used
3129 instead of EMACS_INT, since it always fits in int.
3e26f69c 3130
5cc152c0
PE
3131 * menu.c (grow_menu_items): Check for int overflow.
3132
d89eb65e
PE
3133 * xmenu.c (set_frame_menubar): Don't mishandle vectors with no nils.
3134
5235bd3e
PE
3135 * xterm.c: Use EMACS_INT for Emacs modifiers, and int for X modifiers.
3136 Before, the code was not consistent. These values cannot exceed
3137 2**31 - 1 so there's no need to make them unsigned.
3138 (x_x_to_emacs_modifiers): Accept int and return EMACS_INT.
3139 (x_emacs_to_x_modifiers): Accept EMACS_INT and return int.
3140 (x_x_to_emacs_modifiers, x_emacs_to_x_modifiers): Reject non-integers
3141 as modifiers.
3142 * xterm.h (x_x_to_emacs_modifiers): Adjust to signature change.
3143
bc827e23
PE
3144 * lisp.h (XINT) [USE_LISP_UNION_TYPE]: Cast to EMACS_INT.
3145 (XUINT) [USE_LISP_UNION_TYPE]: Cast to EMACS_UINT.
3146 Otherwise, GCC 4.6.0 warns about printf (pI, XINT (...)),
3147 presumably because the widths might not match.
3148
78eb494e
PE
3149 * window.c (size_window): Avoid needless test at loop start.
3150
04f2d78b
CB
31512011-05-18 Courtney Bane <emacs-bugs-7626@cbane.org> (tiny change)
3152
3153 * term.c (Fresume_tty): Restore hooks before reinitializing (bug#8687).
3154
d2fc7e3d 31552011-05-12 Drew Adams <drew.adams@oracle.com>
e531bdff
DA
3156
3157 * textprop.c (Fprevious_single_char_property_change): Doc fix (bug#8655).
3158
d2fc7e3d 31592011-05-12 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
7db47798
YM
3160
3161 * w32term.c (w32_draw_fringe_bitmap): Rename local vars `left' and
3162 `width' to `bar_area_x' and `bar_area_width', respectively.
3163 (x_scroll_run): Take account of fringe background extension.
3164
04f2d78b
CB
3165 * xterm.c (x_draw_fringe_bitmap) [USE_TOOLKIT_SCROLL_BARS]:
3166 Rename local vars `left' and `width' to `bar_area_x' and
7db47798
YM
3167 `bar_area_width', respectively.
3168 (x_scroll_run) [USE_TOOLKIT_SCROLL_BARS]: Take account of fringe
3169 background extension.
3170
79b70037
GM
31712011-05-10 Jim Meyering <meyering@redhat.com>
3172
3173 * xdisp.c (x_intersect_rectangles): Fix typo "the the -> the".
3174
2f142cc5
JB
31752011-05-10 Juanma Barranquero <lekktu@gmail.com>
3176
3177 * image.c (Finit_image_library): Return t for built-in image types,
3178 like pbm and xbm. (Bug#8640)
3179
57679c86
AS
31802011-05-09 Andreas Schwab <schwab@linux-m68k.org>
3181
3182 * w32menu.c (set_frame_menubar): Fix submenu allocation.
3183
888c9e86
EZ
31842011-05-07 Eli Zaretskii <eliz@gnu.org>
3185
b0512a1d
EZ
3186 * w32console.c (Fset_screen_color): Doc fix.
3187 (Fget_screen_color): New function.
3188 (syms_of_ntterm): Defsubr it.
3189
7285dc67
EZ
3190 * callproc.c (call_process_cleanup) [MSDOS]: Don't close and
3191 unlink the temporary file if Fcall_process didn't create it in the
3192 first place.
3193 (Fcall_process) [MSDOS]: Don't create tempfile if stdout of the
3194 child process will be redirected to a file specified with `:file'.
888c9e86
EZ
3195 Don't try to re-open tempfile in that case, and set fd[0] to -1 as
3196 cue to call_process_cleanup not to close that handle.
3197
4d3fcc8e
BK
31982011-05-07 Ben Key <bkey76@gmail.com>
3199
3200 * makefile.w32-in: The bootstrap-temacs rule now makes use of
3201 one of two shell specific rules, either bootstrap-temacs-CMD or
3202 bootstrap-temacs-SH. The bootstrap-temacs-SH rule is identical
3203 to the previous implementation of the bootstrap-temacs rule.
3204 The bootstrap-temacs-CMD rule is similar to the previous
3205 implementation of the bootstrap-temacs rule except that it
3206 makes use of the ESC_CFLAGS variable instead of the CFLAGS
3207 variable.
3208
3209 These changes, along with some changes to nt/configure.bat,
3210 nt/gmake.defs, and nt/nmake.defs, are required to extend my
3211 earlier fix to add support for --cflags and --ldflags options
3212 that include quotes so that it works whether make uses cmd or
3213 sh as the shell.
3214
b4289b64
MA
32152011-05-06 Michael Albinus <michael.albinus@gmx.de>
3216
3217 * dbusbind.c (QCdbus_type_unix_fd): Declare static.
3218 (xd_remove_watch): Don't check QCdbus_type_unix_fd for SYMBOLP, it
3219 is a constant.
3220 (Fdbus_init_bus, xd_read_queued_messages): Bus can be a symbol or
3221 a string. Handle both cases.
3222 (Fdbus_call_method_asynchronously, Fdbus_register_signal)
3223 (Fdbus_register_method): Use Qinvalid_function.
3224
af4c0e28
JB
32252011-05-06 Juanma Barranquero <lekktu@gmail.com>
3226
3227 * makefile.w32-in: Update dependencies.
3228 (LISP_H): Add inttypes.h and stdin.h.
3229 (PROCESS_H): Add unistd.h.
3230
c51453d9
EZ
32312011-05-06 Eli Zaretskii <eliz@gnu.org>
3232
3233 * lread.c: Include limits.h (fixes the MS-Windows build broken by
3234 2011-05-06T07:13:19Z!eggert@cs.ucla.edu).
3235
8ff0ac3c 32362011-05-06 Paul Eggert <eggert@cs.ucla.edu>
c032b5f8 3237
4c4b566b
PE
3238 * image.c (Finit_image_library) [!HAVE_NTGUI]: Omit unused local.
3239
aab2b9b5
PE
3240 * term.c (vfatal): Remove stray call to va_end.
3241 It's not needed and the C Standard doesn't allow it here anyway.
3242
c378da0b
PE
3243 Use C99's va_copy to avoid undefined behavior on x86-64 GNU/Linux.
3244 * eval.c (verror): doprnt a copy of ap, not the original. (Bug#8545)
3245
288b08c7
PE
3246 * eval.c (verror): OK to create a string of up to MOST_POSITIVE_FIXNUM
3247 bytes.
3248
e3601888
PE
3249 * term.c: Don't include <stdarg.h>, as <lisp.h> does that.
3250
db6c0e74
PE
3251 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork clobbering.
3252
dd5963ea
PE
3253 * process.c (Fformat_network_address): Fix typo: args2 -> *args2.
3254
88c9450f
PE
3255 * xmenu.c (set_frame_menubar): Fix typo: int * -> int (3 times).
3256
2f9442b8
PE
3257 * coding.c (detect_coding_charset): Fix typo: * 2 -> *4 (Bug#8601).
3258
c032b5f8
PE
3259 * charset.h (struct charset.code_space): Now has 15 elements, not 16.
3260 * charset.c (Fdefine_charset_internal): Don't initialize
3261 charset.code_space[15]. The value was garbage, on hosts with
2d38271b 3262 32-bit int (Bug#8600).
a108c10b
PE
3263
3264 * lread.c (read_integer): Be more consistent with string-to-number.
3265 Use string_to_number to do the actual conversion; this avoids
3266 rounding errors and fixes some other screwups. Without this fix,
3267 for example, #x1fffffffffffffff was misread as -2305843009213693952.
3268 (digit_to_number): Move earlier, for benefit of read_integer.
3269 Return -1 if the digit is out of range for the base, -2 if it is
48e400f0 3270 not a digit in any supported base. (Bug#8602)
a108c10b 3271
ad5f9eea
PE
3272 * doprnt.c (doprnt): Support arbitrary pI values, such as "I64".
3273
aec1708a
PE
3274 * dispnew.c (scrolling_window): Return 1 if we scrolled,
3275 to match comment at start of function. This also removes a
3276 GCC warning about overflow in a 32+64-bit port.
3277
47be4ab5
PE
3278 * lisp.h (EMACS_INT, EMACS_UINT, BITS_PER_EMACS_INT, pI): Simplify.
3279
371cac43
PE
3280 * dbusbind.c: Do not use XPNTR on a value that may be an integer.
3281 Reported by Stefan Monnier in
3282 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00919.html>.
04f2d78b
CB
3283 (xd_remove_watch, Fdbus_init_bus, xd_read_queued_messages):
3284 Use SYMBOLP-guarded XSYMBOL, not XPNTR.
371cac43 3285
d01a7826
PE
3286 * lisp.h (EMACS_INTPTR): Remove. All uses changed to intptr_t.
3287 (EMACS_UINTPTR): Likewise, with uintptr_t.
3288
7fd47d5c
PE
3289 * lisp.h: Prefer 64-bit EMACS_INT if available.
3290 (EMACS_INT, EMACS_UINT, BITS_PER_EMACS_INT, pI): Define to 64-bit
3291 on 32-bit hosts that have 64-bit int, so that they can access
3292 large files.
122b0c86
PE
3293 However, temporarily disable this change unless the temporary
3294 symbol WIDE_EMACS_INT is defined.
7fd47d5c 3295
8727937b
PE
3296 * lread.c, process.c: Do not include <inttypes.h>; lisp.h does it now.
3297
8ac068ac
PE
3298 Prefer intptr_t/uintptr_t for integers the same widths as pointers.
3299 This removes an assumption that EMACS_INT and long are the same
3300 width as pointers. The assumption is true for Emacs porting targets
3301 now, but we want to make other targets possible.
3302 * lisp.h: Include <inttypes.h>, for INTPTR_MAX, UINTPTR_MAX.
3303 (EMACS_INTPTR, EMACS_UINTPTR): New macros.
3304 In the rest of the code, change types of integers that hold casted
3305 pointers to EMACS_INTPTR and EMACS_UINTPTR, systematically
3306 replacing EMACS_INT, long, EMACS_UINT, and unsigned long.
3307 (XTYPE): Don't cast arg to EMACS_UINT; normally is not needed.
3308 (XSET): Cast type of XTYPE arg to EMACS_INTPTR; it is needed here.
3309 No need to cast type when ORing.
3310 (XPNTR): Return a value of type EMACS_INTPTR or EMACS_UINTPTR.
3311 * alloc.c (lisp_align_malloc): Remove a no-longer-needed cast.
3312 * doc.c (store_function_docstring): Use EMACS_INTPTR, so as not to
3313 assume EMACS_INT is the same width as char *.
3314 * gtkutil.c (xg_gtk_scroll_destroy, xg_tool_bar_button_cb):
3315 (xg_tool_bar_callback, xg_tool_bar_help_callback, xg_make_tool_item):
3316 Remove no-longer-needed casts.
3317 (xg_create_scroll_bar, xg_tool_bar_button_cb, xg_tool_bar_callback):
3318 (xg_tool_bar_help_callback, xg_make_tool_item):
3319 Use EMACS_INTPTR to hold an integer
3320 that will be cast to void *; this can avoid a GCC warning
3321 if EMACS_INT is not the same width as void *.
3322 * menu.c (find_and_call_menu_selection): Remove no-longer-needed cast.
3323 * xdisp.c (display_echo_area_1, resize_mini_window_1):
3324 (current_message_1, set_message_1):
3325 Use a local to convert to proper width without a cast.
3326 * xmenu.c (dialog_selection_callback): Likewise.
3327
ede49d71
PE
3328 * sysdep.c (get_random): Don't assume EMACS_INT is no wider than long.
3329 Also, don't assume VALBITS / RAND_BITS is less than 5,
3330 and don't rely on undefined behavior when shifting a 1 left into
3331 the sign bit.
3332 * lisp.h (get_random): Change signature to match.
3333
2f30ecd0
PE
3334 * lread.c (hash_string): Use size_t, not int, for hash computation.
3335 Normally we prefer signed values; but hashing is special, because
3336 it's better to use unsigned division on hash table sizes so that
3337 the remainder is nonnegative. Also, size_t is the natural width
3338 for hashing into memory. The previous code used 'int', which doesn't
3339 retain enough info to hash well into very large tables.
3340 (oblookup, oblookup_last_bucket_number, Funintern): Likewise.
3341
2a866e7b
PE
3342 * dbusbind.c: Don't possibly lose pointer info when converting.
3343 (xd_remove_watch, Fdbus_init_bus, xd_read_queued_messages):
3344 Use XPNTR rather than XHASH, so that the high-order bits of
3345 the pointer aren't lost when converting through void *.
3346
51639eac
PE
3347 * eval.c (Fautoload): Don't double-shift a pointer.
3348
92394119
PE
3349 * fns.c (Frandom): Let EMACS_UINT be wider than unsigned long.
3350
dbdb9a7c
JB
33512011-05-06 Juanma Barranquero <lekktu@gmail.com>
3352
3353 * gnutls.c (DEF_GNUTLS_FN):
3354 * image.c (DEF_IMGLIB_FN): Make function pointers static.
3355
db7a0b4f
AS
33562011-05-05 Andreas Schwab <schwab@linux-m68k.org>
3357
3358 * lread.c (lisp_file_lexically_bound_p): Stop scanning at end
3359 marker. (Bug#8610)
3360
f7ff1b0f 33612011-05-05 Eli Zaretskii <eliz@gnu.org>
fab624aa
EZ
3362
3363 * w32heap.c (allocate_heap) [USE_LISP_UNION_TYPE || USE_LSB_TAG]:
3364 New version that can reserve upto 2GB of heap space.
3365
f7ff1b0f 33662011-05-05 Chong Yidong <cyd@stupidchicken.com>
45cb8994
CY
3367
3368 * nsfns.m (Fns_read_file_name): Doc fix (Bug#8534).
3369
639c109b
TZ
33702011-05-05 Teodor Zlatanov <tzz@lifelogs.com>
3371
3372 * gnutls.c (fn_gnutls_certificate_set_x509_key_file): Add alias to
3373 `gnutls_certificate_set_x509_key_file'.
3374
d2127135
JB
33752011-05-05 Juanma Barranquero <lekktu@gmail.com>
3376
3377 * makefile.w32-in ($(BLD)/image.$(O), $(BLD)/process.$(O)):
3378 Update dependencies.
3379
e968f4f3
JB
33802011-05-04 Juanma Barranquero <lekktu@gmail.com>
3381
3382 * gnutls.h (emacs_gnutls_write, emacs_gnutls_read):
3383 * gnutls.c (emacs_gnutls_write, emacs_gnutls_read):
3384 Remove unused parameter `fildes'.
3385 * process.c (read_process_output, send_process): Don't pass it.
3386
84d358f0
JB
33872011-05-04 Juanma Barranquero <lekktu@gmail.com>
3388
3389 Fix previous change: the library cache is defined in w32.c.
3390 * image.c (CACHE_IMAGE_TYPE) [!HAVE_NTGUI]: Define to noop.
3391 (Finit_image_library): Wrap Vlibrary_cache on "#ifdef HAVE_NTGUI".
3392
0898ca10
JB
33932011-05-04 Juanma Barranquero <lekktu@gmail.com>
3394
3395 Implement dynamic loading of GnuTLS on Windows.
3396
3397 * gnutls.h (GNUTLS_EMACS_ERROR_NOT_LOADED): New macro.
3398 (emacs_gnutls_write, emacs_gnutls_read): Mark as extern.
3399 (emacs_gnutls_record_check_pending, emacs_gnutls_transport_set_errno):
3400 Declare.
3401
3402 * gnutls.c (Qgnutls_dll): Define.
3403 (DEF_GNUTLS_FN, LOAD_GNUTLS_FN): New macros.
3404 (gnutls_*): Declare function pointers.
3405 (init_gnutls_functions): New function to initialize function pointers.
3406 (emacs_gnutls_handshake, Fgnutls_error_string, Fgnutls_deinit)
3407 (emacs_gnutls_global_init, Fgnutls_bye): Use function pointers.
3408 (emacs_gnutls_record_check_pending, emacs_gnutls_transport_set_errno):
3409 Wrappers for gnutls_record_check_pending and gnutls_transport_set_errno.
3410 (emacs_gnutls_write, emacs_gnutls_read)
3411 (emacs_gnutls_handle_error, Fgnutls_error_fatalp)
3412 (Fgnutls_available_p): New function.
3413 (Fgnutls_boot): Call Fgnutls_available_p. Use function pointers.
3414 (syms_of_gnutls) <Qgnutls_dll>: Initialize and staticpro it.
3415 (syms_of_gnutls) <Sgnutls_available_p>: defsubr it.
3416
3417 * image.c: Include w32.h.
3418 (Vimage_type_cache): Delete.
3419 (syms_of_image) <Vimage_type_cache>: Don't initialize and staticpro it.
3420 (CACHE_IMAGE_TYPE, Finit_image_library): Use Vlibrary_cache instead.
3421 (w32_delayed_load): Move to w32.c.
3422
3423 * w32.h (VlibraryCache, QCloaded_from, w32_delayed_load): Declare.
3424
3425 * w32.c (QCloaded_from, Vlibrary_cache): Define.
3426 (w32_delayed_load): Move from image.c. When loading a library, record
3427 its filename in the :loaded-from property of the library id.
3428 (globals_of_w32) <QCloaded_from, Vlibrary_cache>:
3429 Initialize and staticpro them.
3430 (emacs_gnutls_pull, emacs_gnutls_push): Call emacs_gnutls_* functions.
3431
3432 * process.c: Include lisp.h before w32.h, not after.
3433 (wait_reading_process_output): Call emacs_gnutls_record_check_pending
3434 instead of gnutls_record_check_pending.
3435
3436 * callproc.c, emacs.c: Include lisp.h before w32.h, not after.
3437
ff4de4aa
TZ
34382011-05-04 Teodor Zlatanov <tzz@lifelogs.com>
3439
3440 * gnutls.c (Fgnutls_boot): Support :keylist and :crlfiles options
3441 instead of :keyfiles. Give GnuTLS the keylist and the CRL lists
3442 as passed in.
3443
abe95abb
JD
34442011-05-03 Jan Djärv <jan.h.d@swipnet.se>
3445
3446 * xterm.c (x_set_frame_alpha): Do not set property on anything
3447 else than FRAME_X_OUTER_WINDOW (Bug#8608).
3448
e16e55d4
JB
34492011-05-02 Juanma Barranquero <lekktu@gmail.com>
3450
3451 * sysdep.c (get_tty_size) [WINDOWSNT]: Implement. (Bug#8596)
3452
bafcf6a5
JB
34532011-05-02 Juanma Barranquero <lekktu@gmail.com>
3454
3455 * gnutls.c (Qgnutls_log_level, Qgnutls_code, Qgnutls_anon)
3456 (Qgnutls_x509pki, Qgnutls_e_interrupted, Qgnutls_e_again)
3457 (Qgnutls_e_invalid_session, Qgnutls_e_not_ready_for_handshake)
3458 (gnutls_global_initialized, Qgnutls_bootprop_priority)
3459 (Qgnutls_bootprop_trustfiles, Qgnutls_bootprop_keyfiles)
3460 (Qgnutls_bootprop_callbacks, Qgnutls_bootprop_loglevel)
3461 (Qgnutls_bootprop_hostname, Qgnutls_bootprop_verify_flags)
3462 (Qgnutls_bootprop_verify_error, Qgnutls_bootprop_verify_hostname_error)
3463 (Qgnutls_bootprop_callbacks_verify): Make static.
3464
e7a6747f
AS
34652011-05-01 Andreas Schwab <schwab@linux-m68k.org>
3466
19ed11ba
AS
3467 * callproc.c: Indentation fixup.
3468
e7a6747f 3469 * sysdep.c (wait_for_termination_1): Make static.
04f2d78b
CB
3470 (wait_for_termination, interruptible_wait_for_termination):
3471 Move after wait_for_termination_1.
e7a6747f 3472
1ef14cb4
LMI
34732011-05-01 Lars Magne Ingebrigtsen <larsi@gnus.org>
3474
3475 * sysdep.c (interruptible_wait_for_termination): New function
3476 which is like wait_for_termination, but allows keyboard
3477 interruptions.
3478
3479 * callproc.c (Fcall_process): Add (:file "file") as an option for
3480 the STDOUT buffer.
3481 (Fcall_process_region): Ditto.
3482
330d880c
EZ
34832011-04-30 Eli Zaretskii <eliz@gnu.org>
3484
8db90b73
EZ
3485 * dosfns.c (Fint86, Fdos_memget, Fdos_memput): Use `ASIZE (FOO)'
3486 rather than `XVECTOR (FOO)->size'.
3487
330d880c
EZ
3488 * process.c: Remove HAVE_INTTYPES_H condition from inclusion of
3489 inttypes.h, as a gnulib replacement is used if it not available in
3490 system headers.
3491
15cbd324
EZ
34922011-04-21 Eli Zaretskii <eliz@gnu.org>
3493
3494 Lift the MOST_POSITIVE_FIXNUM/4 limitation on visited files.
3495 * fileio.c (Finsert_file_contents): Don't limit file size to 1/4
3496 of MOST_POSITIVE_FIXNUM. (Bug#8528)
3497
3498 * coding.c (coding_alloc_by_realloc): Error out if destination
3499 will grow beyond MOST_POSITIVE_FIXNUM.
3500 (decode_coding_emacs_mule): Abort if there isn't enough place in
3501 charbuf for the composition carryover bytes. Reserve an extra
3502 space for up to 2 characters produced in a loop.
3503 (decode_coding_iso_2022): Abort if there isn't enough place in
3504 charbuf for the composition carryover bytes.
3505
35062011-04-21 Eli Zaretskii <eliz@gnu.org>
afda1437 3507
ae940cca
EZ
3508 * doprnt.c (doprnt) [!HAVE_LONG_LONG_INT]: Error out instead of
3509 aborting when %lld or %lll format is passed.
3510 [!HAVE_UNSIGNED_LONG_LONG_INT]: Error out instead of aborting when
3511 %llo or %llx format is passed. (Bug#8545)
3512
03ab8921
EZ
3513 * window.c (window_scroll_line_based): Use a marker instead of
3514 simple variables to record original value of point. (Bug#7952)
3515
afda1437
EZ
3516 * doprnt.c (doprnt): Fix the case where a multibyte sequence
3517 produced by %s or %c overflows available buffer space. (Bug#8545)
3518
f76dee0c
PE
35192011-04-28 Paul Eggert <eggert@cs.ucla.edu>
3520
3521 * doprnt.c (doprnt): Omit useless test; int overflow check (Bug#8545).
283cdbef 3522 (SIZE_MAX): Move defn after all includes, as they might #define it.
f76dee0c 3523
fdc5744d
JB
35242011-04-28 Juanma Barranquero <lekktu@gmail.com>
3525
3526 * w32.c (init_environment): Warn about defaulting HOME to C:\.
3527
638f053a
JB
35282011-04-28 Juanma Barranquero <lekktu@gmail.com>
3529
3530 * keyboard.c (Qdelayed_warnings_hook): Define.
3531 (command_loop_1): Run `delayed-warnings-hook'
3532 if Vdelayed_warnings_list is non-nil.
3533 (syms_of_keyboard) <delayed-warnings-hook>: DEFSYM it.
3534 (syms_of_keyboard) <delayed-warnings-list>: DEFVAR_LISP it.
3535
d178f871
EZ
35362011-04-28 Eli Zaretskii <eliz@gnu.org>
3537
3538 * doprnt.c (doprnt): Don't return value smaller than the buffer
3539 size if the message was truncated. (Bug#8545).
3540
b124fd93
JB
35412011-04-28 Juanma Barranquero <lekktu@gmail.com>
3542
3543 * w32fns.c (Fx_change_window_property, Fx_delete_window_property)
3544 (Fx_window_property): #if-0 the whole functions, not just the bodies.
3545
e810457d
PE
35462011-04-27 Paul Eggert <eggert@cs.ucla.edu>
3547
3548 * doprnt.c (doprnt): Support "ll" length modifier, for long long.
3549
ea51cceb
JB
35502011-04-27 Juanma Barranquero <lekktu@gmail.com>
3551
3552 * makefile.w32-in: Update dependencies.
3553
94dcfacf
EZ
35542011-04-27 Eli Zaretskii <eliz@gnu.org>
3555
3556 Improve `doprnt' and its usage. (Bug#8545)
3557 * doprnt.c (doprnt): Make sure `format' is never accessed beyond
3558 `format_end'. Remove support for %l as a conversion specifier.
3559 Don't use xrealloc. Improve diagnostics when the %l size modifier
3560 is used. Update the commentary.
3561
3562 * eval.c (verror): Simplify calculation of size_t.
3563
3564 * coding.c (Ffind_operation_coding_system): Fix diagnostic error
3565 messages.
3566
f61f41d7
PE
35672011-04-27 Yoshiaki Kasahara <kasahara@nc.kyushu-u.ac.jp> (tiny change)
3568
3569 * buffer.c (init_buffer) [USE_MMAP_FOR_BUFFERS]: Adjust to aliasing
3570 change.
3571
96fb4434
PE
35722011-04-27 Paul Eggert <eggert@cs.ucla.edu>
3573
3574 * nsmenu.m: Replace all uses of XVECTOR with ASIZE and AREF.
3575 This makes this file independent of the recent pseudovector change.
3576
671875da 35772011-04-26 Paul Eggert <eggert@cs.ucla.edu>
eab3844f 3578
69e9b5a3
PE
3579 * keyboard.c (handle_user_signal): Fix pointer signedness problem.
3580
b5f869a7 3581 * gnutls.c (emacs_gnutls_handle_error): Remove unused local.
7754e151 3582 (Fgnutls_boot): gnutls_certificate_verify_peers2 wants unsigned *.
8d4c3955 3583 Remove unused local.
c8926152 3584 (emacs_gnutls_write): Don't use uninitialized rtnval if nbyte <= 0.
080e5a8d 3585
841a1577 3586 * lisp.h: Fix a problem with aliasing and vector headers. (Bug#8546)
04f2d78b
CB
3587 GCC 4.6.0 optimizes based on type-based alias analysis.
3588 For example, if b is of type struct buffer * and v of type struct
eab3844f
PE
3589 Lisp_Vector *, then gcc -O2 was incorrectly assuming that &b->size
3590 != &v->size, and therefore "v->size = 1; b->size = 2; return
3591 v->size;" must therefore return 1. This assumption is incorrect
3592 for Emacs, since it type-puns struct Lisp_Vector * with many other
3593 types. To fix this problem, this patch adds a new type struct
f904488f 3594 vectorlike_header that documents the constraints on layout of vectors
eab3844f
PE
3595 and pseudovectors, and helps optimizing compilers not get fooled
3596 by Emacs's type punning. It also adds the macros XSETTYPED_PVECTYPE
3597 XSETTYPED_PSEUDOVECTOR, TYPED_PSEUDOVECTORP, for similar reasons.
f904488f
PE
3598 * lisp.h (XSETTYPED_PVECTYPE): New macro, specifying the name of
3599 the size member.
eab3844f
PE
3600 (XSETPVECTYPE): Rewrite in terms of new macro.
3601 (XSETPVECTYPESIZE): New macro, specifying both type and size.
3602 This is a bit clearer, and further avoids the possibility of
3603 undesirable aliasing.
3604 (XSETTYPED_PSEUDOVECTOR): New macro, specifying the size.
f904488f 3605 (XSETPSEUDOVECTOR): Rewrite in terms of XSETTYPED_PSEUDOVECTOR.
eab3844f
PE
3606 (XSETSUBR): Rewrite in terms of XSETTYPED_PSEUDOVECTOR and XSIZE,
3607 since Lisp_Subr is a special case (no "next" field).
04f2d78b
CB
3608 (ASIZE): Now uses header.size rather than size.
3609 All previous uses of XVECTOR (foo)->size replaced to use this macro,
f904488f
PE
3610 to avoid the hassle of writing XVECTOR (foo)->header.size.
3611 (struct vectorlike_header): New type.
eab3844f
PE
3612 (TYPED_PSEUDOVECTORP): New macro, also specifying the C type of the
3613 object, to help avoid aliasing.
3614 (PSEUDOVECTORP): Rewrite in terms of TYPED_PSEUDOVECTORP.
3615 (SUBRP): Likewise, since Lisp_Subr is a special case.
3616 * lisp.h (struct Lisp_Vector, struct Lisp_Char_Table):
3617 (struct Lisp_Sub_Char_Table, struct Lisp_Bool_Vector):
3618 (struct Lisp_Hash_Table): Combine first two members into a single
f904488f 3619 struct vectorlike_header member. All uses of "size" and "next" members
eab3844f
PE
3620 changed to be "header.size" and "header.next".
3621 * buffer.h (struct buffer): Likewise.
3622 * font.h (struct font_spec, struct font_entity, struct font): Likewise.
3623 * frame.h (struct frame): Likewise.
3624 * process.h (struct Lisp_Process): Likewise.
3625 * termhooks.h (struct terminal): Likewise.
3626 * window.c (struct save_window_data, struct saved_window): Likewise.
3627 * window.h (struct window): Likewise.
3628 * alloc.c (allocate_buffer, Fmake_bool_vector, allocate_pseudovector):
3629 Use XSETPVECTYPESIZE, not XSETPVECTYPE, to avoid aliasing problems.
3630 * buffer.c (init_buffer_once): Likewise.
3631 * lread.c (defsubr): Use XSETTYPED_PVECTYPE, since Lisp_Subr is a
3632 special case.
3633 * process.c (Fformat_network_address): Use local var for size,
3634 for brevity.
3635
0df1eac5
PE
3636 * bytecode.c (exec_byte_code): Don't use XVECTOR before CHECK_VECTOR.
3637
847ab9d1 3638 Make the Lisp reader and string-to-float more consistent (Bug#8525)
452f4150
PE
3639 * data.c (atof): Remove decl; no longer used or needed.
3640 (digit_to_number): Move to lread.c.
3641 (Fstring_to_number): Use new string_to_number function, to be
3642 consistent with how the Lisp reader treats infinities and NaNs.
3643 Do not assume that floating-point numbers represent EMACS_INT
3644 without losing information; this is not true on most 64-bit hosts.
3645 Avoid double-rounding errors, by insisting on integers when
3646 parsing non-base-10 numbers, as the documentation specifies.
3647 * lisp.h (string_to_number): New decl, replacing ...
3648 (isfloat_string): Remove.
bc0a5c13 3649 * lread.c: Include <inttypes.h>, for uintmax_t and strtoumax.
d78050d6 3650 (read1): Do not accept +. and -. as integers; this
452f4150
PE
3651 appears to have been a coding error. Similarly, do not accept
3652 strings like +-1e0 as floating point numbers. Do not report
3653 overflow for integer overflows unless the base is not 10 which
3654 means we have no simple and reliable way to continue.
3655 Break out the floating-point parsing into a new
3656 function string_to_number, so that Fstring_to_number parses
3657 floating point numbers consistently with the Lisp reader.
04f2d78b 3658 (digit_to_number): Move here from data.c. Make it static inline.
452f4150
PE
3659 (E_CHAR, EXP_INT): Remove, replacing with ...
3660 (E_EXP): New macro, to solve the "1.0e+" problem mentioned below.
3661 (string_to_number): New function, replacing isfloat_string.
3662 This function checks for valid syntax and produces the resulting
3663 Lisp float number too. Rework it so that string-to-number
bc0a5c13 3664 no longer mishandles examples like "1.0e+". Use strtoumax,
d78050d6
PE
3665 so that overflow for non-base-10 numbers is reported only when
3666 there's no portable and simple way to convert to floating point.
452f4150 3667
67769ffc
PE
3668 * textprop.c (set_text_properties_1): Rewrite for clarity,
3669 and to avoid GCC warning about integer overflow.
3670
c20db43f
PE
3671 * intervals.h (struct interval): Use EMACS_INT for members
3672 where EMACS_UINT might cause problems. See
3673 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00514.html>.
3674 (CHECK_TOTAL_LENGTH): Remove cast to EMACS_INT; no longer needed.
3675 * intervals.c (interval_deletion_adjustment): Now returns EMACS_INT.
3676 All uses changed.
37aa2f85
PE
3677 (offset_intervals): Tell GCC not to worry about length overflow
3678 when negating a negative length.
c20db43f 3679
2538aa2f
PE
3680 * alloc.c (overrun_check_malloc, overrun_check_realloc): Now static.
3681 (overrun_check_free): Likewise.
3682
f2d3008d
PE
3683 * alloc.c (SDATA_SIZE) [!GC_CHECK_STRING_BYTES]: Avoid runtime check
3684 in the common case where SDATA_DATA_OFFSET is a multiple of Emacs
3685 word size.
3686
ec8df744
PE
3687 * gnutls.c: Fix problems found by GCC 4.6.0 on Ubuntu 10.10.
3688 (gnutls_make_error): Rename local to avoid shadowing.
3689 (gnutls_emacs_global_deinit): ifdef out; not used.
3690 (Fgnutls_boot): Use const for pointer to readonly storage.
3691 Comment out unused local. Fix pointer signedness problems.
3692
640ee02d
PE
3693 * lread.c (openp): Don't stuff size_t into an 'int'.
3694 Use <= on length, not < on length + 1, to avoid GCC 4.6.0 warning
3695 about possible signed overflow.
3696
6048fb2a
PE
3697 * gtkutil.c: Fix problems found by GCC 4.6.0 on Ubuntu 10.10.
3698 (GDK_KEY_g): Don't define if already defined.
3699 (xg_prepare_tooltip): Avoid pointer signedness problem.
3700 (xg_set_toolkit_scroll_bar_thumb): Redo to avoid two casts.
3701
fa3c87e1
PE
3702 * process.c (Fnetwork_interface_info): Avoid left-shift undefined
3703 behavior with 1 << 31. GCC 4.6.0 warns about this on 32-bit hosts.
3704
2172544b
PE
3705 * xfns.c (Fx_window_property): Simplify a bit,
3706 to make a bit faster and to avoid GCC 4.6.0 warning.
3707 * xselect.c (x_get_window_property, x_handle_dnd_message): Likewise.
3708
9b821a21
PE
3709 * fns.c (internal_equal): Don't assume size_t fits in int.
3710
3c616cfa
PE
3711 * alloc.c (compact_small_strings): Tighten assertion a little.
3712
c2982e87
PE
3713 Replace pEd with more-general pI, and fix some printf arg casts.
3714 * lisp.h (pI): New macro, generalizing old pEd macro to other
3715 conversion specifiers. For example, use "...%"pI"d..." rather
3716 than "...%"pEd"...".
3717 (pEd): Remove. All uses replaced with similar uses of pI.
3718 * src/m/amdx86-64.h, src/m/ia64.h, src/m/ibms390x.h: Likewise.
3719 * alloc.c (check_pure_size): Don't overflow by converting size to int.
3720 * bidi.c (bidi_dump_cached_states): Use pI to avoid cast.
3721 * data.c (Fnumber_to_string): Use pI instead of if-then-else-abort.
3722 * dbusbind.c (xd_append_arg): Use pI to avoid cast.
3723 (Fdbus_method_return_internal, Fdbus_method_error_internal): Likewise.
3724 * font.c (font_unparse_xlfd): Avoid potential buffer overrun on
3725 64-bit hosts.
3726 (font_unparse_xlfd, font_unparse_fcname): Use pI to avoid casts.
3727 * keyboard.c (record_char, modify_event_symbol): Use pI to avoid casts.
3728 * print.c (safe_debug_print, print_object): Likewise.
3729 (print_object): Don't overflow by converting EMACS_INT or EMACS_UINT
3730 to int.
6f04d126
PE
3731 Use pI instead of if-then-else-abort. Use %p to avoid casts,
3732 avoiding the 0 flag, which is not portable.
c2982e87
PE
3733 * process.c (Fmake_network_process): Use pI to avoid cast.
3734 * region-cache.c (pp_cache): Likewise.
3735 * xdisp.c (decode_mode_spec): Likewise.
3736 * xrdb.c (x_load_resources) [USE_MOTIF]: Use pI to avoid undefined
3737 behavior on 64-bit hosts with printf arg.
6f04d126 3738 * xselect.c (x_queue_event): Use %p to avoid casts, avoiding 0 flag.
c2982e87
PE
3739 (x_stop_queuing_selection_requests): Likewise.
3740 (x_get_window_property): Don't truncate byte count to an 'int'
3741 when tracing.
0b432f21 3742
5e073ec7
PE
3743 * frame.c (frame_name_fnn_p): Get rid of strtol, which isn't right
3744 here, since it parses constructs like leading '-' and spaces,
3745 which are not wanted; and it overflows with large numbers.
3746 Instead, simply match F[0-9]+, which is what is wanted anyway.
3747
36372bf9
PE
3748 * alloc.c: Remove unportable assumptions about struct layout.
3749 (SDATA_SELECTOR, SDATA_DATA_OFFSET): New macros.
3750 (SDATA_OF_STRING, SDATA_SIZE, allocate_string_data):
3751 (allocate_vectorlike, make_pure_vector): Use the new macros,
3752 plus offsetof, to remove unportable assumptions about struct layout.
3753 These assumptions hold on all porting targets that I know of, but
3754 they are not guaranteed, they're easy to remove, and removing them
3755 makes further changes easier.
3756
0b432f21
PE
3757 * alloc.c (BLOCK BYTES): Fix typo by changing "ablock" to "ablocks".
3758 This doesn't fix a bug but makes the code clearer.
bfd1c781
PE
3759 (string_overrun_cookie): Now const. Use initializers that
3760 don't formally overflow signed char, to avoid warnings.
000098c1
PE
3761 (allocate_string_data) [GC_CHECK_STRING_OVERRUN]: Fix typo that
3762 can cause Emacs to crash when string overrun checking is enabled.
c7bda33c
PE
3763 (allocate_buffer): Don't assume sizeof (struct buffer) is a
3764 multiple of sizeof (EMACS_INT); it need not be, if
3765 alignof(EMACS_INT) < sizeof (EMACS_INT).
d0f4e1f5 3766 (check_sblock, check_string_bytes, check_string_free_list): Protoize.
0b432f21 3767
895009e1
JB
37682011-04-26 Juanma Barranquero <lekktu@gmail.com>
3769
3770 * keyboard.c (QCrtl): Rename from Qrtl. All uses changed.
3771
6a7a1b0b
TZ
37722011-04-26 Teodor Zlatanov <tzz@lifelogs.com>
3773
3774 * gnutls.c (emacs_gnutls_handshake): Return an error if we're not
b5f869a7 3775 supposed to be handshaking. (Bug#8556)
6a7a1b0b
TZ
3776 Reported by Paul Eggert <eggert@cs.ucla.edu>.
3777
841a1577 37782011-04-26 Daniel Colascione <dan.colascione@gmail.com>
0438ce91
DC
3779
3780 * lisp.h (Qdebug): List symbol.
895009e1 3781 * eval.c (Qdebug): Restore global linkage.
0438ce91
DC
3782 * keyboard.c (debug-on-event): New variable.
3783 (handle_user_signal): Break into debugger when debug-on-event
3784 matches the current signal symbol.
3785
f2d3ba6f
DN
37862011-04-25 Dan Nicolaescu <dann@ics.uci.edu>
3787
3788 * alloc.c (check_sblock, check_string_bytes)
3789 (check_string_free_list): Convert to standard C.
3790
42ce4c63
TZ
37912011-04-25 Teodor Zlatanov <tzz@lifelogs.com>
3792
3793 * w32.c (emacs_gnutls_push): Fix typo.
3794
825cd63c
EZ
37952011-04-25 Eli Zaretskii <eliz@gnu.org>
3796
fb11d64d
EZ
3797 * gnutls.c (emacs_gnutls_handshake): Avoid compiler warnings about
3798 "cast to pointer from integer of different size".
3799
825cd63c
EZ
3800 Improve doprnt and its use in verror. (Bug#8545)
3801 * doprnt.c (doprnt): Document the set of format control sequences
3802 supported by the function. Use SAFE_ALLOCA instead of always
3803 using `alloca'.
3804
3805 * eval.c (verror): Don't limit the buffer size at size_max-1, that
3806 is one byte too soon. Don't use xrealloc; instead xfree and
3807 xmalloc anew.
3808
e061a11b
TZ
38092011-04-24 Teodor Zlatanov <tzz@lifelogs.com>
3810
3811 * gnutls.h: Add GNUTLS_STAGE_CALLBACKS enum to denote we're in the
3812 callbacks stage.
3813
3814 * gnutls.c: Renamed global_initialized to
3815 gnutls_global_initialized. Added internals for the
3816 :verify-hostname-error, :verify-error, and :verify-flags
3817 parameters of `gnutls-boot' and documented those parameters in the
3818 docstring. Start callback support.
9173deec
JB
3819 (emacs_gnutls_handshake): Add Woe32 support. Retry handshake
3820 unless a fatal error occurred. Call gnutls_alert_send_appropriate
3821 on error. Return error code.
e061a11b
TZ
3822 (emacs_gnutls_write): Call emacs_gnutls_handle_error.
3823 (emacs_gnutls_read): Likewise.
3824 (Fgnutls_boot): Return handshake error code.
3825 (emacs_gnutls_handle_error): New function.
3826 (wsaerror_to_errno): Likewise.
3827
3828 * w32.h (emacs_gnutls_pull): Add prototype.
3829 (emacs_gnutls_push): Likewise.
3830
3831 * w32.c (emacs_gnutls_pull): New function for GnuTLS on Woe32.
3832 (emacs_gnutls_push): Likewise.
3833
38342011-04-24 Claudio Bley <claudio.bley@gmail.com> (tiny change)
3835
3836 * process.c (wait_reading_process_output): Check if GnuTLS
3837 buffered some data internally if no FDs are set for TLS
3838 connections.
3839
3840 * makefile.w32-in (OBJ2): Add gnutls.$(O).
3841 (LIBS): Link to USER_LIBS.
3842 ($(BLD)/gnutls.$(0)): New target.
3843
fa6996bc
EZ
38442011-04-24 Eli Zaretskii <eliz@gnu.org>
3845
eb35682e
EZ
3846 * xdisp.c (handle_single_display_spec): Rename the
3847 display_replaced_before_p argument into display_replaced_p, to
3848 make it consistent with the commentary. Fix typos in the
3849 commentary.
3850
e2ad650c
EZ
3851 * textprop.c (syms_of_textprop): Remove dead code.
3852 (copy_text_properties): Delete obsolete commentary about an
3853 interface that was deleted long ago. Fix typos in the description
3854 of arguments.
3855
1b2de274
EZ
3856 * msdos.c (XMenuActivate, XMenuAddSelection): Adjust argument list
3857 to changes in oldXMenu/XMenu.h from 2011-04-16.
3858 <menu_help_message, prev_menu_help_message>: Constify.
3859 (IT_menu_make_room): menu->help_text is now `const char **';
3860 adjust.
3861
3862 * msdos.h (XMenuActivate, XMenuAddSelection): Adjust prototypes
3863 to changes in oldXMenu/XMenu.h from 2011-04-16.
3864 (struct XMenu): Declare `help_text' `const char **'.
3865
3866 * xfaces.c <Qunspecified>: Make extern again.
3867
3868 * syntax.c: Include sys/types.h before including regex.h, as
3869 required by Posix.
3870
762b15be
EZ
3871 * doc.c (get_doc_string): Improve the format passed to `error'.
3872
3873 * doprnt.c (doprnt): Improve commentary.
3874
3875 * term.c (init_tty) [MSDOS]: Fix 1st argument to maybe_fatal.
3876
3877 * Makefile.in (TAGS): Depend on $(M_FILE) and $(S_FILE), and scan
3878 them with etags.
3879
f1052e5d
EZ
3880 * makefile.w32-in (globals.h): Add a dummy recipe, to make any
3881 changes in globals.h immediately force recompilation.
762b15be
EZ
3882 (TAGS): Depend on $(CURDIR)/m/intel386.h and
3883 $(CURDIR)/s/ms-w32.h.
3884 (TAGS-gmake): Scan $(CURDIR)/m/intel386.h and $(CURDIR)/s/ms-w32.h.
f1052e5d 3885
fa6996bc
EZ
3886 * character.c (Fchar_direction): Function deleted.
3887 (syms_of_character): Don't defsubr it.
3888 <char-direction-table>: Deleted.
3889
e6c3da20
EZ
38902011-04-23 Eli Zaretskii <eliz@gnu.org>
3891
3892 Fix doprnt so it could be used again safely in `verror'. (Bug#8435)
3893 * doprnt.c: Include limits.h.
3894 (SIZE_MAX): New macro.
04f2d78b
CB
3895 (doprnt): Return a size_t value. 2nd arg is now size_t.
3896 Many local variables are now size_t instead of int or unsigned.
e6c3da20
EZ
3897 Improve overflow protection. Support `l' modifier for integer
3898 conversions. Support %l conversion. Don't assume an EMACS_INT
3899 argument for integer conversions and for %c.
3900
3901 * lisp.h (doprnt): Restore prototype.
3902
3903 * makefile.w32-in ($(BLD)/callint.$(O)): Depend on
3904 $(SRC)/character.h.
3905
3906 * Makefile.in (base_obj): Add back doprnt.o.
3907
3908 * deps.mk (doprnt.o): Add back prerequisites.
3909 (callint.o): Depend on character.h.
3910
3911 * eval.c (internal_lisp_condition_case): Include the handler
3912 representation in the error message.
3913 (verror): Call doprnt instead of vsnprintf. Fix an off-by-one bug
3914 when breaking from the loop.
3915
3916 * xdisp.c (vmessage): Call doprnt instead of vsnprintf.
3917
3918 * callint.c (Fcall_interactively): When displaying error message
3919 about invalid control letter, pass the character's codepoint, not
3920 a pointer to its multibyte form. Improve display of the character
3921 in octal and display also its hex code.
3922
3923 * character.c (char_string): Use %x to display the (unsigned)
3924 codepoint of an invalid character, to avoid displaying a bogus
3925 negative value.
3926
3927 * font.c (check_otf_features): Pass SDATA of SYMBOL_NAME to
3928 `error', not SYMBOL_NAME itself.
3929
3930 * coding.c (Fencode_sjis_char, Fencode_big5_char): Use %c for
3931 character arguments to `error'.
3932
3933 * charset.c (check_iso_charset_parameter): Fix incorrect argument
3934 to `error' in error message about FINAL_CHAR argument. Make sure
3935 FINAL_CHAR is a character, and use %c when it is passed as
3936 argument to `error'.
3937
4ffd0d6b 39382011-04-23 Eli Zaretskii <eliz@gnu.org>
97a93095
EZ
3939
3940 * s/ms-w32.h (localtime): Redirect to sys_localtime.
3941
3942 * w32.c: Include <time.h>.
3943 (sys_localtime): New function.
3944
4ffd0d6b 39452011-04-23 Chong Yidong <cyd@stupidchicken.com>
c17819f4
CY
3946
3947 * xdisp.c (init_xdisp): Initialize echo_area_window (Bug#6451).
3948
4ffd0d6b 3949 * buffer.c (syms_of_buffer): Doc fix (Bug#6902).
aac0c6e3 3950
4ffd0d6b 39512011-04-23 Samuel Thibault <sthibault@debian.org> (tiny change)
aac0c6e3 3952
4ffd0d6b
GM
3953 * sysdep.c (wait_for_termination): On GNU Hurd, kill returns -1 on
3954 zombies (Bug#8467).
aac0c6e3 3955
04c56954
EZ
39562011-04-19 Eli Zaretskii <eliz@gnu.org>
3957
3958 * syntax.h (SETUP_SYNTAX_TABLE_FOR_OBJECT): Fix setting of
3959 gl_state.e_property when gl_state.object is Qt.
3960
3961 * insdel.c (make_gap_larger): Remove limitation of buffer size
3962 to <= INT_MAX.
3963
16a43933
CY
39642011-04-18 Chong Yidong <cyd@stupidchicken.com>
3965
3966 * xdisp.c (lookup_glyphless_char_display)
3967 (produce_glyphless_glyph): Handle cons cell entry in
3968 glyphless-char-display.
3969 (Vglyphless_char_display): Document it.
3970
3971 * term.c (produce_glyphless_glyph): Handle cons cell entry in
3972 glyphless-char-display.
3973
4581706e
CY
39742011-04-17 Chong Yidong <cyd@stupidchicken.com>
3975
3976 * xdisp.c (get_next_display_element): Remove unnecessary ifdefs.
3977
3978 * termhooks.h (FRAME_WINDOW_P): Remove duplicated definitions.
3979
3980 * dispextern.h (FACE_SUITABLE_FOR_ASCII_CHAR_P): Add missing
3981 definition for no-X builds.
3982
4887c6e2 39832011-04-16 Paul Eggert <eggert@cs.ucla.edu>
764430a3 3984
fd35b6f9
PE
3985 Static checks with GCC 4.6.0 and non-default toolkits.
3986
5c1ccb01
PE
3987 * s/sol2-6.h, s/unixware.h (PTY_TTY_NAME_SPRINTF): Protoize decl.
3988
006c5daa
PE
3989 * process.c (keyboard_bit_set): Define only if SIGIO.
3990 (send_process_trap): Mark it with NO_RETURN if it doesn't return.
3991 (send_process): Repair possible setjmp clobbering.
3992
efc736d3
PE
3993 * s/usg5-4-common.h (SETUP_SLAVE_PTY): Don't pass extra arg to 'fatal'.
3994
4e2fe2e6
PE
3995 * eval.c: Include <stdio.h>, for vsnprintf on non-GNU/Linux hosts.
3996
f97334a2
PE
3997 * data.c (arith_error): Mark with NO_RETURN if it doesn't return.
3998
4e75f29d
PE
3999 * alloc.c (bytes_used_when_full, SPARE_MEMORY, BYTES_USED):
4000 Define only if needed.
4001
90efadd1
PE
4002 * sysdep.c (_FILE_OFFSET_BITS): Make this hack even uglier
4003 by pacifying GCC about it. Maybe it's time to retire it?
875975e9 4004 * xfaces.c (USG, __TIMEVAL__): Likewise.
90efadd1 4005
3c647824
PE
4006 * dispextern.h (struct redisplay_interface): Rename param
4007 to avoid shadowing.
e264f262 4008 * termhooks.h (struct terminal): Likewise.
761383f4 4009 * xterm.c (xembed_send_message): Likewise.
3c647824 4010
b58c5c4a
PE
4011 * insdel.c (make_gap_smaller): Define only if
4012 USE_MMAP_FOR_BUFFERS || REL_ALLOC || DOUG_LEA_MALLOC.
4013
cad59032
PE
4014 * keyboard.c (read_char): Make a var volatile so longjmp won't clobber
4015 it.
4016
c339dc2e
PE
4017 * emacs.c (MAX_HEAP_BSS_DIFF, my_edata): Move to where they're used,
4018 so that we aren't warned about unused symbols.
4019
91a3e27b
PE
4020 * xfns.c (Fx_file_dialog): Rename local to avoid shadowing.
4021
399c71d3 4022 * xdisp.c (x_produce_glyphs): Mark var as initialized (Bug#8512).
7a3fb125 4023
8ffc96f5
PE
4024 * xfns.c (x_real_positions): Mark locals as initialized.
4025
eef9bc79
PE
4026 * xmenu.c (xmenu_show): Don't use uninitialized vars.
4027
098db9dd
PE
4028 * xterm.c: Fix problems found by static analysis with other toolkits.
4029 (toolkit_scroll_bar_interaction): Define and use only if USE_X_TOOLKIT.
dda3aedd
PE
4030 (x_dispatch_event): Declare static if USE_GTK, and
4031 define if USE_GTK || USE_X_TOOLKIT.
098db9dd 4032 (SET_SAVED_BUTTON_EVENT): Define only if USE_X_TOOLKIT || USE_GTK.
dda3aedd 4033 * xterm.h (x_dispatch_event): Extern only if USE_X_TOOLKIT.
841a1577
JB
4034 * xterm.c, xterm.h (x_mouse_leave): Bring this function back, but only
4035 if defined HAVE_MENUS && !defined USE_X_TOOLKIT && !defined USE_GTK.
098db9dd 4036
eb18f6cc
PE
4037 * xmenu.c (menu_help_callback): Pointer type fixes.
4038 Use const pointers when pointing at readonly data. Avoid pointer
4039 signedness clashes.
4040 (FALSE): Remove unused macro.
4041 (update_frame_menubar): Remove unused decl.
4042
1fe72bf8
PE
4043 * xfns.c (Fx_hide_tip): Move locals to avoid shadowing.
4044
60d9e1db
PE
4045 * menu.c (push_submenu_start, push_submenu_end): Do not define unless
4046 USE_X_TOOLKIT || USE_GTK || HAVE_NS || defined HAVE_NTGUI.
4047 (single_menu_item): Rename local to avoid shadowing.
4048
39261c26
PE
4049 * keyboard.c (make_lispy_event): Remove unused local var.
4050
018c5e19
PE
4051 * frame.c, frame.h (x_get_resource_string): Bring this back, but
4052 only if HAVE_X_WINDOWS && !USE_X_TOOLKIT.
4053
63d2b86e
PE
4054 * bitmaps: Change bitmaps from unsigned char back to the X11
4055 compatible char. Avoid the old compiler warnings about
4056 out-of-range initializers by using, for example, '\xab' rather
4057 than 0xab.
4058
aefd87e1
PE
4059 * xgselect.c (xgselect_initialize): Check vs interface
4060 even if ! (defined (USE_GTK) || defined (HAVE_GCONF)).
4061
bf501fb9
PE
4062 * xmenu.c (xmenu_show): Rename parm to avoid shadowing.
4063
e9829fdf
PE
4064 * xterm.c (x_create_toolkit_scroll_bar): Use const * for pointers
4065 to read-only memory.
4066
1086c095
PE
4067 * fns.c (vector): Remove; this old hack is no longer needed.
4068
2baccd04 4069 * xsmfns.c (create_client_leader_window): Rename shadowing arg.
401f10cb 4070 Remove unused var.
dde42981 4071 (gdk_x11_set_sm_client_id) [!USE_GTK]: Don't define.
2baccd04 4072
72391843 4073 * xrdb.c (x_load_resources): Omit unused local.
3565b346 4074
436c16df 4075 * xfns.c (free_frame_menubar, atof): Remove duplicate decls.
8a94ea33 4076 (x_window): Rename locals to avoid shadowing.
dc5ddd85 4077 (USG): Use the kludged USG macro, to pacify gcc.
436c16df 4078
92bb796d 4079 * xterm.c (x_alloc_nearest_color_for_widget): Remove; unused.
bbbef9e1 4080 (x_term_init): Remove local to avoid shadowing.
92bb796d 4081
764430a3 4082 * xfns.c, xterm.c (_XEditResCheckMessages): Protoize decl.
4887c6e2
PE
4083
4084 * xdisp.c, dispextern.h (set_vertical_scroll_bar): Now extern if
4085 USE_TOOLKIT_SCROLL_BARS && !USE_GTK, as xterm.c needs it then.
4086
d1dfb56c
EZ
40872011-04-16 Eli Zaretskii <eliz@gnu.org>
4088
c4354cb4
EZ
4089 * gnutls.c (Fgnutls_boot): Don't pass Lisp_Object to `error'.
4090
d1dfb56c
EZ
4091 Fix regex.c, syntax.c and friends for buffers > 2GB.
4092 * syntax.h (struct gl_state_s): Declare character position members
4093 EMACS_INT.
4094
4095 * syntax.c (update_syntax_table): Declare 2nd argument EMACS_INT.
4096
04f2d78b
CB
4097 * textprop.c (verify_interval_modification, interval_of):
4098 Declare arguments EMACS_INT.
d1dfb56c
EZ
4099
4100 * intervals.c (adjust_intervals_for_insertion): Declare arguments
4101 EMACS_INT.
4102
4103 * intervals.h (CHECK_TOTAL_LENGTH): Cast to EMACS_INT, not `int'.
4104
4105 * indent.c (Fvertical_motion): Local variable it_start is now
4106 EMACS_INT.
4107
4108 * regex.c (re_match, re_match_2, re_match_2_internal)
4109 (bcmp_translate, regcomp, regexec, print_double_string)
4110 (group_in_compile_stack, re_search, re_search_2, regex_compile)
4111 (re_compile_pattern, re_exec): Declare arguments and local
4112 variables `size_t' and `ssize_t' and return values `regoff_t', as
4113 appropriate.
4114 (POP_FAILURE_REG_OR_COUNT) <pfreg>: Declare `long'.
4115 (CHECK_INFINITE_LOOP) <failure>: Declare `ssize_t'.
4116 <compile_stack_type>: `size' and `avail' are now `size_t'.
4117
4118 * regex.h <regoff_t>: Use ssize_t, not int.
4119 (re_search, re_search_2, re_match, re_match_2): Arguments that
4120 specify buffer/string position and length are now ssize_t and
4121 size_t. Return type is regoff_t.
4122
613052cd
BK
41232011-04-16 Ben Key <bkey76@gmail.com>
4124
4125 * nsfont.m: Fixed bugs in ns_get_family and
4126 ns_descriptor_to_entity that were caused by using free to
4127 deallocate memory blocks that were allocated by xmalloc (via
4128 xstrdup). This caused Emacs to crash when compiled with
4129 XMALLOC_OVERRUN_CHECK defined (when Emacs was configured with
4130 --enable-checking=xmallocoverrun). xfree is now used to
4131 deallocate these memory blocks.
4132
4170f62f 41332011-04-15 Paul Eggert <eggert@cs.ucla.edu>
3e047f51 4134
71b41406
PE
4135 * sysdep.c (emacs_read): Remove unnecessary check vs MAX_RW_COUNT.
4136
9587a89d
PE
4137 emacs_write: Accept and return EMACS_INT for sizes.
4138 See http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00514.html
4139 et seq.
4140 * gnutls.c, gnutls.h (emacs_gnutls_read, emacs_gnutls_write):
4141 Accept and return EMACS_INT.
4142 (emacs_gnutls_write): Return the number of bytes written on
4143 partial writes.
4144 * sysdep.c, lisp.h (emacs_read, emacs_write): Likewise.
273a5f82
PE
4145 (emacs_read, emacs_write): Remove check for negative size, as the
4146 Emacs source code has been audited now.
9587a89d
PE
4147 * sysdep.c (MAX_RW_COUNT): New macro, to work around kernel bugs.
4148 (emacs_read, emacs_write): Use it.
273a5f82
PE
4149 * process.c (send_process): Adjust to the new signatures of
4150 emacs_write and emacs_gnutls_write. Do not attempt to store
4151 a byte offset into an 'int'; it might overflow.
9587a89d 4152 See http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00483.html
273a5f82 4153
3e047f51
PE
4154 * sound.c: Don't assume sizes fit in 'int'.
4155 (struct sound_device.period_size, alsa_period_size):
9c3c56a7 4156 Return EMACS_INT, not int.
3e047f51 4157 (struct sound_device.write, vox_write, alsa_write):
9c3c56a7
PE
4158 Accept EMACS_INT, not int.
4159 (wav_play, au_play): Use EMACS_INT to store sizes and to
3e047f51
PE
4160 record read return values.
4161
cc39a9db
BK
41622011-04-15 Ben Key <bkey76@gmail.com>
4163
c9d0ec6d
JB
4164 * keyboard.c (Qundefined): Don't declare static since it is used
4165 in nsfns.m.
4166 * xfaces.c (Qbold, Qexpanded, Qitalic, Qcondensed): Don't declare
4167 static since they are used in nsfont.m.
cc39a9db 4168
6c60eb9f
SM
41692011-04-15 Stefan Monnier <monnier@iro.umontreal.ca>
4170
4171 * process.c (Qprocessp): Don't declare static.
4172 * lisp.h (Qprocessp): Declare again.
4173
7990b61a
JB
41742011-04-15 Juanma Barranquero <lekktu@gmail.com>
4175
4176 * font.c (Qopentype): Don't make static (used from w32uniscribe.c).
4177
5d4cb038
PE
41782011-04-14 Paul Eggert <eggert@cs.ucla.edu>
4179
8bd7b830 4180 Improve C-level modularity by making more things 'static'.
cd64ea1d 4181
e3b27b31
PE
4182 Don't publish debugger-only interfaces to other modules.
4183 * lisp.h (safe_debug_print, debug_output_compilation_hack):
4184 (verify_bytepos, count_markers): Move decls to the only modules
4185 that need them.
4186 * region-cache.h (pp_cache): Likewise.
4187 * window.h (check_all_windows): Likewise.
4188 * marker.c, print.c, region-cache.c, window.c: Decls moved here.
4189
5d4cb038
PE
4190 * sysdep.c (croak): Now static, if
4191 defined TIOCNOTTY || defined USG5 || defined CYGWIN.
4192 * syssignal.h (croak): Declare only if not static.
69003fd8
PE
4193
4194 * alloc.c (refill_memory_reserve): Now static if
4195 !defined REL_ALLOC || defined SYSTEM_MALLOC.
4196 * lisp.h (refill_memory_reserve): Declare only if not static.
93ea6e8f 4197
e87b6180
PE
4198 * xsettings.c, xsettings.h (xsettings_get_system_normal_font):
4199 Define only if USE_LUCID.
4200
ac64929e
PE
4201 * xrdb.c (x_customization_string, x_rm_string): Now static.
4202
6f37259d
PE
4203 * xmenu.c (x_menu_wait_for_event): Export only if USE_MOTIF.
4204 * xterm.h (x_menu_wait_for_event): Declare only if USE_MOTIF.
4205
1683e3ab
PE
4206 * xdisp.c (draw_row_with_mouse_face): Now static.
4207 * dispextern.h (draw_row_with_mouse_fave): Remove decl.
4208
de9c2632
PE
4209 * window.h (check_all_windows): Mark externally visible.
4210
2b96acb7
PE
4211 * window.c (window_deletion_count): Now static.
4212
4213 * undo.c: Make symbols static if they're not exported.
4214 (last_undo_buffer, last_boundary_position, pending_boundary):
4215 Now static.
4216
50436f33
PE
4217 * textprop.c (interval_insert_behind_hooks): Now static.
4218 (interval_insert_in_front_hooks): Likewise.
4219
64520e5c
PE
4220 * term.c: Make symbols static if they're not exported.
4221 (tty_turn_off_highlight, get_tty_terminal, max_frame_cols):
4222 (max_frame_lines, tty_set_terminal_modes):
4223 (tty_reset_terminal_modes, tty_turn_off_highlight):
4224 (get_tty_terminal): Now static.
4225 (term_mouse_moveto): Do not define if HAVE_WINDOW_SYSTEM.
4226 * termhooks.h (term_mouse_moveto): Do not declare if
8bd7b830 4227 HAVE_WINDOW_SYSTEM.
64520e5c
PE
4228 * dispextern.h (tty_set_terminal_modes, tty_reset_terminal_modes):
4229 (tty_turn_off_highlight, get_tty_terminal): Remove decls.
4230
1fa53021
PE
4231 * sysdep.c: Make symbols static if they're not exported.
4232 (emacs_get_tty, emacs_set_tty, old_fcntl_flags, old_fcntl_owner):
4233 Now static.
4234 (sigprocmask_set, full_mask): Remove; unused.
4235 (wait_debugging): Mark as visible.
4236 * syssignal.h (SIGFULLMASK, full_mask): Remove decls.
4237 * systty.h (emacs_get_tty, emacs_set_tty): Remove decls.
4238
d4b43b22
PE
4239 * syntax.c (syntax_temp): Define only if !__GNUC__.
4240
b7c513d0
PE
4241 * sound.c (current_sound_device, current_sound): Now static.
4242
989b29ad
PE
4243 * search.c (searchbufs, searchbuf_head): Now static.
4244
13a55a78
PE
4245 * scroll.c (scroll_cost): Remove; unused.
4246 * dispextern.h (scroll_cost): Remove decl.
4247
de68a1fc
PE
4248 * region-cache.h (pp_cache): Mark as externally visible.
4249
40ccffa6
PE
4250 * process.c: Make symbols static if they're not exported.
4251 (process_tick, update_tick, create_process, chan_process):
4252 (Vprocess_alist, proc_buffered_char, datagram_access):
4253 (fd_callback_data, send_process_frame, process_sent_to): Now static.
4254 (deactivate_process): Mark defn as static, as well as decl.
4255 * lisp.h (create_process): Remove decl.
4256 * process.h (chan_process, Vprocess_alist): Remove decls.
4257
ad64fc97
PE
4258 * print.c: Make symbols static if they're not exported.
4259 (print_depth, new_backquote_output, being_printed, print_buffer):
4260 (print_buffer_size, print_buffer_pos, print_buffer_pos_byte):
4261 (print_interval, print_number_index, initial_stderr_stream):
4262 Now static.
4263 * lisp.h (Fprinc): Remove decl.
4264 (debug_output_compilation_hack): Mark as externally visible.
4265
adddb265
PE
4266 * sysdep.c (croak): Move decl from here to syssignal.h.
4267 * syssignal.h (croak): Put it here, so the API can be checked when
4268 'croak' is called from dissociate_if_controlling_tty.
4269
1717ede2
PE
4270 * minibuf.c: Make symbols static if they're not exported.
4271 (minibuf_save_list, choose_minibuf_frame): Now static.
4272 * lisp.h (choose_minibuf_frame): Remove decl.
4273
fa5fb2bc
PE
4274 * lisp.h (verify_bytepos, count_markers): Mark as externally visible.
4275
1e3890d1
PE
4276 * lread.c: Make symbols static if they're not exported.
4277 (read_objects, initial_obarray, oblookup_last_bucket_number):
4278 Now static.
4279 (make_symbol): Remove; unused.
4280 * lisp.h (initial_obarray, make_symbol): Remove decls.
4281
8a1414fa
PE
4282 * keyboard.c: Make symbols static if they're not exported.
4283 (single_kboard, recent_keys_index, total_keys, recent_keys):
4284 (this_command_key_count_reset, raw_keybuf, raw_keybuf_count):
4285 (this_single_command_key_start, echoing, last_auto_save):
4286 (read_key_sequence_cmd, dribble, recursive_edit_unwind):
4287 (command_loop, echo_now, keyboard_init_hook, help_char_p):
4288 (quit_throw_to_read_char, command_loop_2, top_level_1, poll_timer):
4289 (Vlispy_mouse_stem, double_click_count):
4290 Now static.
4291 (force_auto_save_soon): Define only if SIGDANGER.
4292 (ignore_mouse_drag_p): Now static if
4293 !defined HAVE_WINDOW_SYSTEM || defined USE_GTK || defined HAVE_NS.
4294 (print_help): Remove; unused.
4295 (stop_character, last_timer_event): Mark as externally visible.
4296 * keyboard.h (ignore_mouse_drag_p): Declare only if
4297 defined HAVE_WINDOW_SYSTEM && !defined USE_GTK && !defined HAVE_NS.
4298 (echo_now, help_char_p, quit_throw_to_read_char): Remove decls.
4299 * lisp.h (echoing): Remove decl.
4300 (force_auto_save_soon): Declare only if SIGDANGER.
4301 * xdisp.c (redisplay_window): Simplify code, to make it more
4302 obvious that ignore_mouse_drag_p is not accessed if !defined
4303 USE_GTK && !defined HAVE_NS.
4304
93ea6e8f
PE
4305 * intervals.c: Make symbols static if they're not exported.
4306 (merge_properties_sticky, merge_interval_right, delete_interval):
4307 Now static.
4308 * intervals.h (merge_interval_right, delete_interval): Remove decls.
4309
77382fcc
PE
4310 * insdel.c: Make symbols static if they're not exported.
4311 However, leave prepare_to_modify_buffer alone. It's never
4312 called from outside this function, but that appears to be a bug.
4313 (combine_after_change_list, combine_after_change_buffer):
4889fc82 4314 (adjust_after_replace, signal_before_change): Now static.
77382fcc
PE
4315 (adjust_after_replace_noundo): Remove; unused.
4316 * lisp.h (adjust_after_replace, adjust_after_replace_noundo):
4889fc82 4317 (signal_before_change): Remove decls.
77382fcc 4318
9306c32e
PE
4319 * indent.c (val_compute_motion, val_vmotion): Now static.
4320
cd44d2eb
PE
4321 * image.c: Make symbols static if they're not exported.
4322 * dispextern.h (x_create_bitmap_from_xpm_data): Do not declare
4323 if USE_GTK.
4324 * image.c (x_create_bitmap_from_xpm_data): Do not define if USE_GTK.
4325 (xpm_color_cache, ct_table, ct_colors_allocated): Now static.
4326
ad9a7a06
PE
4327 * fringe.c (standard_bitmaps): Now static.
4328 (max_used_fringe_bitmap): Now static, unless HAVE_NS.
4329
81626931
PE
4330 * frame.c: Make symbols static if they're not exported.
4331 (x_report_frame_params, make_terminal_frame): Now static.
4332 (get_frame_param): Now static, unless HAVE_NS.
4333 (x_fullscreen_adjust): Define if WINDOWSNT, not if HAVE_WINDOW_SYSTEM.
4334 (x_get_resource_string): Remove; not used.
4335 * frame.h (make_terminal_frame, x_report_frame_params):
4336 (x_get_resource_string); Remove decls.
4337 (x_fullscreen_adjust): Declare only if WINDOWSNT.
4338 * lisp.h (get_frame_param): Declare only if HAVE_NS.
4339
239f9db9
PE
4340 * font.c, fontset.c: Make symbols static if they're not exported.
4341 * dispextern.h (FACE_SUITABLE_FOR_ASCII_CHAR_P): New macro.
4342 (FACE_SUITABLE_FOR_CHAR_P): Use it.
4343 * font.c (font_close_object): Now static.
4344 * font.h (font_close_object): Remove.
4345 * fontset.c (FONTSET_OBJLIST): Remove.
4346 (free_realized_fontset) #if-0 the body, which does nothing.
4347 (face_suitable_for_char_p): #if-0, as it's never called.
4348 * fontset.h (face_suitable_for_char_p): Remove decl.
04f2d78b
CB
4349 * xfaces.c (face_at_string_position):
4350 Use FACE_SUITABLE_FOR_ASCII_CHAR_P, not FACE_SUITABLE_FOR_CHAR_P,
239f9db9
PE
4351 since 0 is always ASCII.
4352
dfcf3579
PE
4353 * fns.c (weak_hash_tables): Now static.
4354
5045092b
PE
4355 * fileio.c: Make symbols static if they're not exported.
4356 (auto_saving, auto_save_mode_bits, auto_save_error_occurred):
4357 (Vwrite_region_annotation_buffers): Now static.
4358
57a96f5c
PE
4359 * eval.c: Make symbols static if they're not exported.
4360 (backtrace_list, lisp_eval_depth, when_entered_debugger): Now static.
4361 * lisp.h (backtrace_list): Remove decl.
4362
35f08c38
PE
4363 * emacs.c: Make symbols static if they're not exported.
4364 (malloc_state_ptr, malloc_using_checking, syms_of_emacs):
4365 (fatal_error_code, fatal_error_signal_hook, standard_args):
4366 Now static.
4367 (fatal_error_signal): Now static, unless FLOAT_CATCH_SIGKILL.
4368 (DEFINE_DUMMY_FUNCTION): Mark function as externally visible.
4369 (__CTOR_LIST__, __DTOR_LIST__): Now externally visible.
4370 * lisp.h (fatal_error_signal_hook): Remove decl.
4371 (fatal_error_signal): Declare only if FLOAT_CATCH_SIGKILL.
4372
f44bd759
PE
4373 * editfns.c: Move a (normally-unused) function to its only use.
4374 * editfns.c, lisp.h (get_operating_system_release): Remove.
4375 * process.c (init_process) [DARWIN_OS]: Do it inline, as it is not
4376 worth the hassle of breaking this out.
4377
b532497d
PE
4378 * xterm.c: Make symbols static if they're not exported.
4379 (x_raise_frame, x_lower_frame, x_wm_set_window_state):
4380 (x_wm_set_icon_pixmap, x_initialize, XTread_socket_fake_io_error):
4381 (x_destroy_window, x_delete_display):
4382 Now static.
4383 (x_dispatch_event): Now static if ! (USE_MOTIF || USE_X_TOOLKIT).
4384 (x_mouse_leave): Remove; unused.
4385 * xterm.h (x_display_info_for_name, x_raise_frame, x_lower_frame):
4386 (x_destroy_window, x_wm_set_window_state, x_wm_set_icon_pixmap):
4387 (x_delete_display, x_initialize, x_set_border_pixel, x_screen_planes):
4388 Remove decls.
4389 (x_mouse_leave): Declare only if WINDOWSNT.
4390 (x_dispatch_event): Declare only if USE_MOTIF or USE_X_TOOLKIT.
4391 (xic_create_fontsetname): Declare only if HAVE_X_WINDOWS &&
4392 USE_X_TOOLKIT.
4393
1675728f
PE
4394 * ftxfont.c: Make symbols static if they're not exported.
4395 (ftxfont_driver): Export only if !defined HAVE_XFT && def8ined
4396 HAVE_FREETYPE.
4397 * font.h (ftxfont_driver): Likewise.
4398
e4cebfca
PE
4399 * xfns.c: Make symbols static if they're not exported.
4400 (x_last_font_name, x_display_info_for_name):
4401 (x_set_foreground_color, x_set_background_color, x_set_mouse_color):
4402 (x_set_cursor_color, x_set_border_pixel, x_set_border_color):
4403 (x_set_cursor_type, x_set_icon_type, x_set_icon_name):
4404 (x_set_scroll_bar_foreground, x_set_scroll_bar_background):
4405 (x_explicitly_set_name, x_set_title, xic_defaut_fontset, tip_timer):
4406 (last_show_tip_args): Now static.
4407 (xic_defaut_fontset, xic_create_fontsetname): Define only if
4408 defined HAVE_X_WINDOWS && defined USE_X_TOOLKIT
4409 (x_screen_planes): Remove; unused.
4410 * dispextern.h (x_screen_planes): Remove decl.
4411
5bf46f05
PE
4412 * dispnew.c: Make symbols static if they're not exported.
4413 * dispextern.h (redraw_garbaged_frames, scrolling):
4414 (increment_row_positions): Remove.
4415 * dispnew.c (new_glyph_matrix, increment_row_positions, scrolling):
4416 (delayed_size_change, glyph_matrix_count, glyph_pool_count):
4417 Now static.
4418 (redraw_garbaged_frames): Remove; unused.
4419
435f4c28
PE
4420 * xfaces.c: Make symbols static if they're not exported.
4421 * dispextern.h (ascii_face_of_lisp_face, free_realized_face):
4422 Remove decls.
4423 * xterm.h (defined_color): Remove decls.
4424 (x_free_dpy_colors): Declare only if USE_X_TOOLKIT.
4425 * xfaces.c (tty_suppress_bold_inverse_default_colors_p):
4426 (menu_face_changed_default, defined_color, free_realized_face):
4427 (x_free_dpy_colors): Define only if USE_X_TOOLKIT.
4428 (ascii_face_of_lisp_face): Remove; unused.
4429
8524aef3
PE
4430 * xdisp.c: Make symbols static if they're not exported.
4431 * dispextern.h (scratch_glyph_row, window_box_edges):
4432 (glyph_to_pixel_coords, set_cursor_from_row):
4433 (get_next_display_element, set_iterator_to_next):
4434 (highlight_trailing_whitespace, frame_to_window_pixel_xy):
4435 (show_mouse_face): Remove decls
4436 * frame.h (message_buf_print): Likewise.
4437 * lisp.h (pop_message, set_message, check_point_in_composition):
4438 Likewise.
4439 * xterm.h (set_vertical_scroll_bar): Likewise.
4440 * xdisp.c (list_of_error, Vmessage_stack, line_number_displayed):
4441 (message_buf_print, scratch_glyph_row, displayed_buffer):
4442 (set_iterator_to_next, pop_message, set_message, set_cursor_from_row):
4443 (get_next_display_element, show_mouse_face, window_box_edges):
4444 (frame_to_window_pixel_xy, check_point_in_composition):
4445 (set_vertical_scroll_bar, highlight_trailing_whitespace): Now static.
4446 (glyph_to_pixel_coords): Remove; unused.
4447
16390cd2
PE
4448 * dired.c (file_name_completion): Now static.
4449
4450 * dbusbind.c (xd_in_read_queued_messages): Now static.
4451
a25f4dfa
PE
4452 * lisp.h (circular_list_error, FOREACH): Remove; unused.
4453 * data.c (circular_list_error): Remove.
4454
14a9c8df
PE
4455 * commands.h (last_point_position, last_point_position_buffer):
4456 (last_point_position_window): Remove decls.
4457 * keyboard.c: Make these variables static.
4458
04f2d78b
CB
4459 * coding.h (coding, code_convert_region, encode_coding_gap):
4460 Remove decls.
74ab6df5
PE
4461 * coding.c (Vsjis_coding_system, Vbig5_coding_system):
4462 (iso_code_class, detect_coding, code_convert_region): Now static.
4463 (encode_coding_gap): Remove; unused.
4464
38dfbee1
PE
4465 * chartab.c (chartab_chars, chartab_bits): Now static.
4466
a2cb4e63
PE
4467 * charset.h (charset_iso_8859_1): Remove decl.
4468 * charset.c (charset_iso_8859_1, charset_emacs, map_charset_for_dump):
4469 Now static.
4470
127198fd
PE
4471 * ccl.h (check_ccl_update, Vccl_program_table): Remove decls.
4472 * ccl.c (Vccl_program_table): Now static.
4473 (check_ccl_update): Remove; unused.
4474
d85b608f
PE
4475 * category.c (SET_CATEGORY_SET, set_category_set): Move here.
4476 * category.h: ... from here.
4477 * category.c (check_category_table, set_category_set): Now static.
4478
31cd66f3
PE
4479 * casetab.c (Vascii_upcase_table, Vascii_eqv_table): Now static.
4480 * lisp.h: Remove these decls.
4481
c358e587
PE
4482 * buffer.c (buffer_count): Remove unused var.
4483
e78aecca
PE
4484 * bidi.c (bidi_dump_cached_states): Mark as externally visible,
4485 so that it's not optimized away.
4486 (bidi_ignore_explicit_marks_for_paragraph_level): Likewise.
4487 * dispextern.h (bidi_dump_cached_states): Remove, since it's
4488 exported only to the debugger.
4489
e192d7d3 4490 * atimer.c (alarm_signal_handler, run_all_atimers): Now static.
04f2d78b 4491 * atimer.h (run_all_atimers): Remove; not exported.
e192d7d3 4492
92470028
PE
4493 font.c: Make copy_font_spec and merge_font_spec ordinary C functions.
4494 * font.c (copy_font_spec): Rename from Fcopy_font_spec, since it
4495 was inaccessible from Lisp.
4496 (merge_font_spec): Likewise, renaming from Fmerge_font_spec.
4497 * font.c, font.h, fontset.c, xfaces.c, xfont.c: Change all uses.
4498
244ed907
PE
4499 alloc.c: Import and export fewer symbols, and remove unused items.
4500 * lisp.h (suppress_checking, die): Declare only if ENABLE_CHECKING
4501 is defined.
4502 (suppress_checking): Add EXTERNALLY_VISIBLE attribute, so that
4503 it's not optimized away by whole-program optimization.
4504 (message_enable_multibyte, free_misc): Remove.
4505 (catchlist, handlerlist, mark_backtrace):
4506 Declare only if BYTE_MARK_STACK.
4507 (mark_byte_stack): Likewise, fixing a ifdef-vs-if typo.
4508 * alloc.c (pure): Export only if VIRT_ADDR_VARIES is defined.
4509 (message_enable_multibyte): Remove decl.
4510 (free_misc, interval_free_list, float_block, float_block_index):
4511 (n_float_blocks, float_free_list, cons_block, cons_block_index):
4512 (cons_free_list, last_marked_index):
4513 Now static.
4514 (suppress_checking, die): Define only if ENABLE_CHECKING is defined.
4515 * eval.c (catchlist, handlerlist): Export only if BYTE_MARK_STACK.
4516 (mark_backtrace): Define only if BYTE_MARK_STACK.
4517 * xdisp.c (message_enable_multibyte): Now static.
4518
61c2b50e 4519 Declare Lisp_Object Q* variables to be 'static' if not exported.
955cbe7b
PE
4520 This makes it easier for human readers (and static analyzers)
4521 to see whether these variables are used from other modules.
4522 * alloc.c, buffer.c, bytecode.c, callint.c, casetab.c, category.c:
4523 * ccl.c, character.c, charset.c, cmds.c, coding.c, composite.c:
4524 * data.c, dbusbind.c, dired.c, editfns.c, eval.c, fileio.c, fns.c:
4525 * font.c, frame.c, fringe.c, ftfont.c, image.c, keyboard.c, keymap.c:
4526 * lread.c, macros.c, minibuf.c, print.c, process.c, search.c:
4527 * sound.c, syntax.c, textprop.c, window.c, xdisp.c, xfaces.c, xfns.c:
4528 * xmenu.c, xselect.c:
4529 Declare Q* vars static if they are not used in other modules.
4530 * ccl.h, character.h, charset.h, coding.h, composite.h, font.h:
4531 * frame.h, intervals.h, keyboard.h, lisp.h, process.h, syntax.h:
4532 Remove decls of unexported vars.
4533 * keyboard.h (EVENT_HEAD_UNMODIFIED): Remove now-unused macro.
4534
95c82688
PE
4535 * lisp.h (DEFINE_FUNC): Make sname 'static'.
4536
16a97296
PE
4537 Make Emacs functions such as Fatom 'static' by default.
4538 This makes it easier for human readers (and static analyzers)
4539 to see whether these functions can be called from other modules.
4540 DEFUN now defines a static function. To make the function external
4541 so that it can be used in other C modules, use the new macro DEFUE.
8bd7b830
PE
4542 * lisp.h (Funibyte_char_to_multibyte, Fsyntax_table_p):
4543 (Finit_image_library):
16a97296
PE
4544 (Feval_region, Fbacktrace, Ffetch_bytecode, Fswitch_to_buffer):
4545 (Ffile_executable_p, Fmake_symbolic_link, Fcommand_execute):
4546 (Fget_process, Fdocumentation_property, Fbyte_code, Ffile_attributes):
4547 Remove decls, since these functions are now static.
4548 (Funintern, Fget_internal_run_time): New decls, since these functions
4549 were already external.
95c82688 4550
16a97296
PE
4551 * alloc.c, buffer.c, callint.c, callproc.c, casefiddle.c, casetab.c:
4552 * ccl.c, character.c, chartab.c, cmds.c, coding.c, data.c, dispnew.c:
4553 * doc.c, editfns.c, emacs.c, eval.c, fileio.c, filelock.c, floatfns.c:
4554 * fns.c, font.c, fontset.c, frame.c, image.c, indent.c:
4555 * keyboard.c, keymap.c, lread.c:
4556 * macros.c, marker.c, menu.c, minibuf.c, print.c, process.c, search.c:
4557 * syntax.c, term.c, terminal.c, textprop.c, undo.c:
4558 * window.c, xdisp.c, xfaces.c, xfns.c, xmenu.c, xsettings.c:
4559 Mark functions with DEFUE instead of DEFUN,
4560 if they are used in other modules.
4561 * buffer.c (Fset_buffer_major_mode, Fdelete_overlay): New forward
4562 decls for now-static functions.
4563 * buffer.h (Fdelete_overlay): Remove decl.
4564 * callproc.c (Fgetenv_internal): Mark as internal.
4565 * composite.c (Fremove_list_of_text_properties): Remove decl.
4566 (Fcomposition_get_gstring): New forward static decl.
4567 * composite.h (Fcomposite_get_gstring): Remove decl.
4568 * dired.c (Ffile_attributes): New forward static decl.
4569 * doc.c (Fdocumntation_property): New forward static decl.
4570 * eval.c (Ffetch_bytecode): New forward static decl.
4571 (Funintern): Remove extern decl; now in .h file where it belongs.
4572 * fileio.c (Fmake_symbolic_link): New forward static decl.
4573 * image.c (Finit_image_library): New forward static decl.
4574 * insdel.c (Fcombine_after_change_execute): Make forward decl static.
4575 * intervals.h (Fprevious_property_change):
4576 (Fremove_list_of_text_properties): Remove decls.
4577 * keyboard.c (Fthis_command_keys): Remove decl.
4578 (Fcommand_execute): New forward static decl.
4579 * keymap.c (Flookup_key): New forward static decl.
4580 (Fcopy_keymap): Now static.
4581 * keymap.h (Flookup_key): Remove decl.
4582 * process.c (Fget_process): New forward static decl.
4583 (Fprocess_datagram_address): Mark as internal.
4584 * syntax.c (Fsyntax_table_p): New forward static decl.
4585 (skip_chars): Remove duplicate decl.
4586 * textprop.c (Fprevious_property_change): New forward static decl.
4587 * window.c (Fset_window_fringes, Fset_window_scroll_bars):
4588 Now internal.
4589 (Fset_window_margins, Fset_window_vscroll): New forward static decls.
4590 * window.h (Fset_window_vscroll, Fset_window_margins): Remove decls.
4591
785bbd42
PE
4592 * editfns.c (Fformat): Remove unreachable code.
4593
8b913b57
AS
45942011-04-14 Andreas Schwab <schwab@linux-m68k.org>
4595
4596 * fileio.c (Finsert_file_contents): Fix typo in 2005-05-13
4597 change. (Bug#8496)
4598
a6744a35
EZ
45992011-04-13 Eli Zaretskii <eliz@gnu.org>
4600
4601 * xdisp.c (handle_invisible_prop): Don't call bidi_paragraph_init
4602 when at ZV. (Bug#8487)
4603
e7974947
AS
46042011-04-12 Andreas Schwab <schwab@linux-m68k.org>
4605
baad03f0
AS
4606 * charset.c (Fclear_charset_maps): Use xfree instead of free.
4607 (Bug#8437)
4608 * keyboard.c (parse_tool_bar_item): Likewise.
4609 * sound.c (sound_cleanup, alsa_close): Likewise.
4610 * termcap.c (tgetent): Likewise.
4611 * xfns.c (x_default_font_parameter): Likewise.
4612 * xsettings.c (read_and_apply_settings): Likewise.
4613
e7974947
AS
4614 * alloc.c (overrun_check_malloc, overrun_check_realloc)
4615 (overrun_check_free): Protoize.
4616
28272684
PE
46172011-04-12 Paul Eggert <eggert@cs.ucla.edu>
4618
4619 * sysdep.c (emacs_read, emacs_write): Check for negative sizes
4620 since callers should never pass a negative size.
4621 Change the signature to match that of plain 'read' and 'write'; see
4622 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00397.html>.
4623 * lisp.h: Update prototypes of emacs_write and emacs_read.
4624
11997c76
EZ
46252011-04-11 Eli Zaretskii <eliz@gnu.org>
4626
4627 * xdisp.c (redisplay_window): Don't try to determine the character
4628 position of the scroll margin if the window start point w->startp
e896f03c 4629 is outside the buffer's accessible region. (Bug#8468)
11997c76 4630
8a2cbd72
EZ
46312011-04-10 Eli Zaretskii <eliz@gnu.org>
4632
4633 Fix write-region and its subroutines for buffers > 2GB.
4634 * fileio.c (a_write, e_write): Modify declaration of arguments and
4635 local variables to support buffers larger than 2GB.
4636 (Fcopy_file): Use EMACS_INT for return value of emacs_read.
4637
4638 * sysdep.c (emacs_write, emacs_read): Use ssize_t for last
4639 argument, local variables, and return value.
4640
4641 * lisp.h: Update prototypes of emacs_write and emacs_read.
4642
4643 * sound.c (vox_write): Use ssize_t for return value of emacs_write.
4644
4073e537 46452011-04-10 Paul Eggert <eggert@cs.ucla.edu>
eb3f1cc8 4646
1ebfdcb6
PE
4647 * xdisp.c (vmessage): Use memchr, not strnlen, which some hosts lack.
4648
b2ded58d
PE
4649 Fix more problems found by GCC 4.6.0's static checks.
4650
7d66342c
PE
4651 * xdisp.c (vmessage): Use a better test for character truncation.
4652
bbf47d44
PE
4653 * charset.c (load_charset_map): <, not <=, for optimization,
4654 and to avoid potential problems with integer overflow.
9248994d 4655 * chartab.c (sub_char_table_set_range, char_table_set_range): Likewise.
f9a68bc5 4656 * casetab.c (set_identity, shuffle): Likewise.
3ab1c7ce 4657 * editfns.c (Fformat): Likewise.
1e69125e 4658 * syntax.c (skip_chars): Likewise.
3befa583 4659
e3019616
PE
4660 * xmenu.c (set_frame_menubar): Allocate smaller local vectors.
4661 This also lets GCC 4.6.0 generate slightly better loop code.
4662
becfa255
PE
4663 * callint.c (Fcall_interactively): <, not <=, for optimization.
4664 (Fcall_interactively): Count the number of arguments produced,
4665 not the number of arguments given. This is simpler and lets GCC
4666 4.6.0 generate slightly better code.
4667
dae0cd48
PE
4668 * ftfont.c: Distingish more carefully between FcChar8 and char.
4669 The previous code passed unsigned char * to a functions like
4670 strlen and xstrcasecmp that expect char *, which does not
4671 conform to the C standard.
4672 (get_adstyle_property, ftfont_pattern_entity): Use FcChar8 for
4673 arguments to FcPatternGetString, and explicitly cast FcChar8 * to
4674 char * when the C standard requires it.
4675
76032d70
PE
4676 * keyboard.c (read_char): Remove unused var.
4677
eb3f1cc8
PE
4678 * eval.c: Port to Windows vsnprintf (Bug#8435).
4679 Include <limits.h>.
4680 (SIZE_MAX): Define if the headers do not.
4681 (verror): Do not give up if vsnprintf returns a negative count.
4682 Instead, grow the buffer. This ports to Windows vsnprintf, which
4683 does not conform to C99. Problem reported by Eli Zaretskii.
4684 Also, simplify the allocation scheme, by avoiding the need for
4685 calling realloc, and removing the ALLOCATED variable.
4686
70476b54
PE
4687 * eval.c (verror): Initial buffer size is 4000 (not 200) bytes.
4688
12020a9e
PE
4689 Remove invocations of doprnt, as Emacs now uses vsnprintf.
4690 But keep the doprint source code for now, as we might revamp it
4691 and use it again (Bug#8435).
ea6c7ae6
PE
4692 * lisp.h (doprnt): Remove.
4693 * Makefile.in (base_obj): Remove doprnt.o.
4694 * deps.mk (doprnt.o): Remove.
4695
5fdb398c
PE
4696 error: Print 32- and 64-bit integers portably (Bug#8435).
4697 Without this change, on typical 64-bit hosts error ("...%d...", N)
4698 was used to print both 32- and 64-bit integers N, which relied on
4699 undefined behavior.
4700 * lisp.h, src/m/amdx86-64.h, src/m/ia64.h, src/m/ibms390x.h (pEd):
4701 New macro.
4702 * lisp.h (error, verror): Mark as printf-like functions.
4703 * eval.c (verror): Use vsnprintf, not doprnt, to do the real work.
4704 Report overflow in size calculations when allocating printf buffer.
4705 Do not truncate output string at its first null byte.
4706 * xdisp.c (vmessage): Use vsnprintf, not doprnt, to do the real work.
4707 Truncate the output at a character boundary, since vsnprintf does not
4708 do that.
4709 * charset.c (check_iso_charset_parameter): Convert internal
4710 character to string before calling 'error', since %c now has the
4711 printf meaning.
4712 * coding.c (Fdecode_sjis_char, Fdecode_big5_char): Avoid int
4713 overflow when computing char to be passed to 'error'. Do not
4714 pass Lisp_Object to 'error'; pass the integer instead.
4715 * nsfns.m (Fns_do_applescript): Use int, not long, since it's
4716 formatted with plain %d.
4717
b189fa66
PE
4718 * eval.c (internal_lisp_condition_case): Don't pass spurious arg.
4719
bff87ef0
PE
4720 * keyboard.c (access_keymap_keyremap): Print func name, not garbage.
4721
7e2cac20
PE
4722 * coding.c (Fdecode_sjis_char): Don't assume CODE fits in int.
4723
ce4d90b5
PE
4724 * xterm.c (x_catch_errors): Remove duplicate declaration.
4725
266c9547
PE
4726 * term.c (maybe_fatal): Mark its 3rd arg as a printf format, too.
4727
79c49ad2
PE
4728 * xdisp.c, lisp.h (message_nolog): Remove; unused.
4729
368f4090
JM
47302011-04-10 Jim Meyering <meyering@redhat.com>
4731
4732 use ssize_t and size_t for read- and write-like emacs_gnutls_* functions
4733 * gnutls.c (emacs_gnutls_read): Adjust signature to be more read-like:
4734 return ssize_t not "int", and use size_t as the buffer length.
4735 (emacs_gnutls_write): Likewise, and make the buffer pointer "const".
4736 * gnutls.h: Update declarations.
4737 * process.c (read_process_output): Use ssize_t, to match.
4738 (send_process): Likewise.
4739
a32d4040
CY
47402011-04-09 Chong Yidong <cyd@stupidchicken.com>
4741
4742 * image.c (Fimagemagick_types): Doc fix, and comment cleanup.
4743
8546720e 47442011-04-09 Chong Yidong <cyd@stupidchicken.com>
aac0c6e3 4745
04f2d78b
CB
4746 * ftfont.c (get_adstyle_property, ftfont_pattern_entity):
4747 Use unsigned char, to match FcChar8 type definition.
aac0c6e3 4748
8546720e
GM
4749 * xterm.c (handle_one_xevent):
4750 * xmenu.c (create_and_show_popup_menu):
4751 * xselect.c (x_decline_selection_request)
4752 (x_reply_selection_request): Avoid type-punned deref of X events.
aac0c6e3 4753
0a2f5c1a 47542011-04-09 Eli Zaretskii <eliz@gnu.org>
a53e2e89
EZ
4755
4756 Fix some uses of `int' instead of EMACS_INT.
4757 * search.c (string_match_1, fast_string_match)
4758 (fast_c_string_match_ignore_case, fast_string_match_ignore_case)
4759 (scan_buffer, find_next_newline_no_quit)
4760 (find_before_next_newline, search_command, Freplace_match)
4761 (Fmatch_data): Make some `int' variables be EMACS_INT.
4762
4763 * xdisp.c (display_count_lines): 3rd argument and return value now
4764 EMACS_INT. All callers changed.
4765 (pint2hrstr): Last argument is now EMACS_INT.
4766
4767 * coding.c (detect_coding_utf_8, detect_coding_emacs_mule)
4768 (detect_coding_iso_2022, detect_coding_sjis, detect_coding_big5)
4769 (detect_coding_ccl, detect_coding_charset, decode_coding_utf_8)
4770 (decode_coding_utf_16, decode_coding_emacs_mule)
4771 (decode_coding_iso_2022, decode_coding_sjis, decode_coding_big5)
4772 (decode_coding_ccl, decode_coding_charset)
4773 <consumed_chars, consumed_chars_base>: Declare EMACS_INT.
4774 (decode_coding_iso_2022, decode_coding_emacs_mule)
4775 (decode_coding_sjis, decode_coding_big5, decode_coding_charset)
4776 <char_offset, last_offset>: Declare EMACS_INT.
4777 (encode_coding_utf_8, encode_coding_utf_16)
4778 (encode_coding_emacs_mule, encode_invocation_designation)
4779 (encode_designation_at_bol, encode_coding_iso_2022)
4780 (encode_coding_sjis, encode_coding_big5, encode_coding_ccl)
4781 (encode_coding_raw_text, encode_coding_charset) <produced_chars>:
4782 Declare EMACS_INT.
4783 (ASSURE_DESTINATION): Declare more_bytes EMACS_INT.
4784 (encode_invocation_designation): Last argument P_NCHARS is now
4785 EMACS_INT.
4786 (decode_eol): Declare pos_byte, pos, and pos_end EMACS_INT.
4787 (produce_chars): from_nchars and to_nchars are now EMACS_INT.
4788
4789 * coding.h (struct coding_system) <head_ascii>: Declare EMACS_INT.
4790 All users changed.
4791
4792 * ccl.c (Fccl_execute_on_string): Declare some variables
4793 EMACS_INT.
4794
8546720e 47952011-04-08 Samuel Thibault <sthibault@debian.org> (tiny change)
0080dc6b
SS
4796
4797 * term.c (init_tty): Fix incorrect ifdef placement (Bug#8450).
4798
4e19a977
CS
47992011-03-19 Christoph Scholtes <cschol2112@googlemail.com>
4800
4801 * process.c (Fformat_network_address): Doc fix.
4802
87302331
R
48032011-04-08 T.V. Raman <tv.raman.tv@gmail.com> (tiny change)
4804
4805 * xml.c (parse_region): Avoid creating spurious whiespace nodes.
4806
cbb59342
CY
48072011-04-08 Chong Yidong <cyd@stupidchicken.com>
4808
4809 * keyboard.c (read_char): Call Lisp function help-form-show,
4810 instead of using internal_with_output_to_temp_buffer.
4811 (Qhelp_form_show): New var.
e0d38eeb 4812 (syms_of_keyboard): Use DEFSYM macro.
cbb59342
CY
4813
4814 * print.c (internal_with_output_to_temp_buffer): Function deleted.
4815
4816 * lisp.h (internal_with_output_to_temp_buffer): Remove prototype.
4817
e67a13ab
CY
48182011-04-06 Chong Yidong <cyd@stupidchicken.com>
4819
04f2d78b
CB
4820 * process.c (Flist_processes): Remove to Lisp.
4821 (list_processes_1): Delete.
e67a13ab 4822
973f782d
EZ
48232011-04-06 Eli Zaretskii <eliz@gnu.org>
4824
7c106b1e
EZ
4825 * msdos.c (careadlinkat, careadlinkatcwd): MS-DOS replacements.
4826
973f782d
EZ
4827 * w32.c (careadlinkat, careadlinkatcwd): New always-fail stubs.
4828
41cf7d1a 48292011-04-06 Paul Eggert <eggert@cs.ucla.edu>
27ccc379 4830
ca23cc88
PE
4831 Fix more problems found by GCC 4.6.0's static checks.
4832
f390e2d5
PE
4833 * xmenu.c (Fx_popup_dialog): Don't assume string is free of formats.
4834
42eea0d0
PE
4835 * menu.c (Fx_popup_menu): Don't assume error_name lacks printf formats.
4836
b69769da 4837 * lisp.h (message, message_nolog, fatal): Mark as printf-like.
1e973bc7 4838
f9541e84
PE
4839 * xdisp.c (vmessage): Mark as a printf-like function.
4840
13841b55
PE
4841 * term.c (vfatal, maybe_fatal): Mark as printf-like functions.
4842
c136c10f
PE
4843 * sound.c (sound_warning): Don't crash if arg contains a printf format.
4844
5e2d4a30
PE
4845 * image.c (tiff_error_handler, tiff_warning_handler): Mark as
4846 printf-like functions.
4847 (tiff_load): Add casts to remove these marks before passing them
4848 to system-supplied API.
4849
583f48b9
PE
4850 * eval.c (Fsignal): Remove excess argument to 'fatal'.
4851
b25d760e
PE
4852 * coding.c (EMIT_ONE_BYTE, EMIT_TWO_BYTES): Use unsigned, not int.
4853 This avoids several warnings with gcc -Wstrict-overflow.
d5efd1d1
PE
4854 (DECODE_COMPOSITION_RULE): If the rule is invalid, goto invalid_code
4855 directly, rather than having caller test rule sign. This avoids
4856 some unnecessary tests.
4857 * composite.h (COMPOSITION_ENCODE_RULE_VALID): New macro.
4858 (COMPOSITION_ENCODE_RULE): Arguments now must be valid. This
4859 affects only one use, in DECODE_COMPOSITION_RULE, which is changed.
b25d760e 4860
bc7b6697 4861 * xfont.c (xfont_text_extents): Remove var that was set but not used.
625a3eb1 4862 (xfont_open): Avoid unnecessary tests.
bc7b6697 4863
27ccc379
PE
4864 * composite.c (composition_gstring_put_cache): Use unsigned integer.
4865
dcd5c89a
PE
4866 * composite.h, composite.c (composition_gstring_put_cache):
4867 Use EMACS_INT, not int, for length.
4868
b13a45c6
PE
4869 * composite.h (COMPOSITION_DECODE_REFS): New macro,
4870 breaking out part of COMPOSITION_DECODE_RULE.
4871 (COMPOSITION_DECODE_RULE): Use it.
4872 * composite.c (get_composition_id): Remove unused local vars,
4873 by using the new macro.
4874
1e792e4d
PE
4875 * textprop.c (set_text_properties_1): Change while to do-while,
4876 since the condition is always true at first.
4877
dc6c6455 4878 * intervals.c (graft_intervals_into_buffer): Mark var as used.
aa86731f
PE
4879 (interval_deletion_adjustment): Return unsigned value.
4880 All uses changed.
dc6c6455 4881
aba7731a
PE
4882 * process.c (list_processes_1, create_pty, read_process_output):
4883 (exec_sentinel): Remove vars that were set but not used.
afd4052b 4884 (create_pty): Remove unnecessary "volatile"s.
bc57d757 4885 (Fnetwork_interface_info): Avoid possibility of int overflow.
82eaa333 4886 (read_process_output): Do adaptive read buffering even if carryover.
fe07cdfa 4887 (read_process_output): Simplify nbytes computation if buffered.
aba7731a 4888
fdfc4bf3
PE
4889 * bytecode.c (exec_byte_code): Rename local to avoid shadowing.
4890
fca8fe46 4891 * syntax.c (scan_words): Remove var that was set but not used.
12cbf13f 4892 (update_syntax_table): Use unsigned instead of int.
fca8fe46 4893
06a0259a 4894 * lread.c (lisp_file_lexically_bound_p): Use ints rather than endptrs.
3c346cc3 4895 (lisp_file_lexically_bound_p, read1): Use unsigned instead of int.
e6eb4e9e 4896 (safe_to_load_p): Make the end-of-loop test the inverse of the in-loop.
06a0259a 4897
e7b9e80f
PE
4898 * print.c (print_error_message): Avoid int overflow.
4899
56201685
PE
4900 * font.c (font_list_entities): Redo for clarity,
4901 so that reader need not know FONT_DPI_INDEX + 1 == FONT_SPACING_INDEX.
4902
78834453 4903 * font.c (font_find_for_lface, Ffont_get_glyphs): Remove unused vars.
790771b1 4904 (font_score): Avoid potential overflow in diff calculation.
78834453 4905
0bc0b309 4906 * fns.c (substring_both): Remove var that is set but not used.
8cd55cb4 4907 (sxhash): Redo loop for clarity and to avoid wraparound warning.
0bc0b309 4908
e610eaca
PE
4909 * eval.c (funcall_lambda): Rename local to avoid shadowing.
4910
b895abce
PE
4911 * alloc.c (mark_object_loop_halt, mark_object): Use size_t, not int.
4912 Otherwise, GCC 4.6.0 optimizes the loop check away since the check
4913 can always succeed if overflow has undefined behavior.
4914
1f1d9321 4915 * search.c (boyer_moore, wordify): Remove vars set but not used.
6f076cc7 4916 (wordify): Omit three unnecessary tests.
1f1d9321 4917
c59478bc
PE
4918 * indent.c (MULTIBYTE_BYTES_WIDTH): Don't compute wide_column.
4919 All callers changed. This avoids the need for an unused var.
4920
79b73827
PE
4921 * casefiddle.c (casify_region): Remove var that is set but not used.
4922
a4db5dfe
PE
4923 * dired.c (file_name_completion): Remove var that is set but not used.
4924
43aae36e
PE
4925 * fileio.c (Finsert_file_contents): Make EOF condition clearer.
4926
2a47c44d 4927 * fileio.c (Finsert_file_contents): Avoid signed integer overflow.
163c5f32 4928 (Finsert_file_contents): Remove unnecessary code checking fd.
2a47c44d 4929
a37c69bf
PE
4930 * minibuf.c (read_minibuf_noninteractive): Use size_t for sizes.
4931 Check for integer overflow on size calculations.
4932
328ab8e7
PE
4933 * buffer.c (Fprevious_overlay_change): Remove var that is set
4934 but not used.
4935
e5a2a5cb
PE
4936 * keyboard.c (menu_bar_items, read_char_minibuf_menu_prompt):
4937 Remove vars that are set but not used.
8d84a6eb 4938 (timer_check_2): Don't assume timer-list and idle-timer-list are lists.
6b043475 4939 (timer_check_2): Mark vars as initialized.
e5a2a5cb 4940
a60e5f68
PE
4941 * gtkutil.c (xg_get_file_with_chooser): Mark var as initialized.
4942
f661cb61 4943 * image.c (lookup_image): Remove var that is set but not used.
35fa624f 4944 (xbm_load): Use parse_p, for gcc -Werror=unused-but-set-variable.
f661cb61 4945
f0397f5a
PE
4946 * fontset.c (Finternal_char_font, Ffontset_info): Remove vars
4947 that are set but not used.
4948
8664db06 4949 * xfns.c (make_invisible_cursor): Don't return garbage
03733ee7 4950 if XCreateBitmapFromData fails (Bug#8410).
8664db06 4951
6abdaa4a
PE
4952 * xselect.c (x_get_local_selection, x_handle_property_notify):
4953 Remove vars that are set but not used.
4954
0ce7538d 4955 * xfns.c (x_create_tip_frame): Remove var that is set but not used.
6abdaa4a 4956 (make_invisible_cursor): Initialize a possibly-uninitialized variable.
0ce7538d 4957
9ae848fc
PE
4958 * xterm.c (x_scroll_bar_to_input_event) [!USE_GTK]:
4959 Remove var that is set but not used.
0b918413
PE
4960 (scroll_bar_windows_size): Now size_t, not int.
4961 (x_send_scroll_bar_event): Use size_t, not int, for sizes.
4962 Check for overflow.
9ae848fc 4963
a5a62657
PE
4964 * xfaces.c (realize_named_face): Remove vars that are set but not used.
4965 (map_tty_color) [!defined MSDOS]: Likewise.
4966
5c5cdd39
PE
4967 * term.c (tty_write_glyphs): Use size_t; this avoids overflow warning.
4968
66ebf983
PE
4969 * coding.c: Remove vars that are set but not used.
4970 (DECODE_COMPOSITION_RULE): Remove 2nd arg, which is unused.
4971 All callers changed.
4972 (decode_coding_utf_8, decode_coding_utf_16 decode_coding_emacs_mule):
4973 (decode_coding_iso_2022, encode_coding_sjis, encode_coding_big5):
4974 (decode_coding_charset): Remove vars that are set but not used.
4975
1be4d761
PE
4976 * bytecode.c (Fbyte_code) [!defined BYTE_CODE_SAFE]: Remove var
4977 that is set but not used.
4978
47553fa8
PE
4979 * print.c (print_object): Remove var that is set but not used.
4980
1f7196bf 4981 Replace 2 copies of readlink code with 1 gnulib version (Bug#8401).
d1fdcab7
PE
4982 The gnulib version avoids calling malloc in the usual case,
4983 and on 64-bit hosts doesn't have some arbitrary 32-bit limits.
4984 * fileio.c (Ffile_symlink_p): Use emacs_readlink.
4985 * filelock.c (current_lock_owner): Likewise.
4986 * lisp.h (READLINK_BUFSIZE, emacs_readlink): New function.
4987 * sysdep.c: Include allocator.h, careadlinkat.h.
4988 (emacs_no_realloc_allocator): New static constant.
4989 (emacs_readlink): New function.
fdb61804
PE
4990 * deps.mk (sysdep.o): Depend on ../lib/allocator.h and on
4991 ../lib/careadlinkat.h.
d1fdcab7 4992
f84c17c7
SM
49932011-04-04 Stefan Monnier <monnier@iro.umontreal.ca>
4994
4995 * keyboard.c (safe_run_hook_funcall): Fix last change (don't stop at the
4996 first non-nil return value).
4997
ef3862ad
JD
49982011-04-03 Jan Djärv <jan.h.d@swipnet.se>
4999
5000 * nsterm.m (ns_update_auto_hide_menu_bar): Define MAC_OS_X_VERSION_10_6
5001 if not defined (Bug#8403).
5002
376a7006
JB
50032011-04-02 Juanma Barranquero <lekktu@gmail.com>
5004
5005 * xdisp.c (display_count_lines): Remove parameter `start',
5006 unused since 1998-01-01T02:27:27Z!rms@gnu.org. All callers changed.
5007 (get_char_face_and_encoding): Remove parameter `multibyte_p',
5008 unused since 2008-05-14T01:40:23Z!handa@m17n.org. All callers changed.
5009 (fill_stretch_glyph_string): Remove parameters `row' and `area',
5010 unused at least since Kim's GUI unification at 2003-03-16T20:45:46Z!storm@cua.dk
5011 and thereabouts. All callers changed.
5012 (get_per_char_metric): Remove parameter `f', unused since
5013 2008-05-14T01:40:23Z!handa@m17n.org. All callers changed.
5014
6ca3801d
JM
50152011-04-02 Jim Meyering <meyering@redhat.com>
5016
5017 do not dereference NULL upon failed strdup
5018 * nsfont.m (ns_descriptor_to_entity): Use xstrdup, not strdup.
5019 (ns_get_family): Likewise.
5020
d8e2b5ba
JB
50212011-04-02 Juanma Barranquero <lekktu@gmail.com>
5022
5023 * eval.c (unwind_to_catch) [DEBUG_GCPRO]: Remove redundant assignment.
5024
8c74fcbd
JD
50252011-04-02 Jan Djärv <jan.h.d@swipnet.se>
5026
5027 * nsterm.m (ns_update_auto_hide_menu_bar): Only for OSX 10.6 or
5028 later (Bug#8403).
5029
7200d79c
SM
50302011-04-01 Stefan Monnier <monnier@iro.umontreal.ca>
5031
03408648 5032 Add lexical binding.
7200d79c 5033
03408648
SM
5034 * window.c (Ftemp_output_buffer_show): New fun.
5035 (Fsave_window_excursion):
5036 * print.c (Fwith_output_to_temp_buffer): Move to subr.el.
5037
5038 * lread.c (lisp_file_lexically_bound_p): New function.
5039 (Fload): Bind Qlexical_binding.
5040 (readevalloop): Remove `evalfun' arg.
5041 Bind Qinternal_interpreter_environment.
5042 (Feval_buffer): Bind Qlexical_binding.
5043 (defvar_int, defvar_bool, defvar_lisp_nopro, defvar_kboard):
5044 Mark as dynamic.
5045 (syms_of_lread): Declare `lexical-binding'.
5046
5047 * lisp.h (struct Lisp_Symbol): New field `declared_special'.
5048
5049 * keyboard.c (eval_dyn): New fun.
5050 (menu_item_eval_property): Use it.
ca105506
SM
5051
5052 * image.c (parse_image_spec): Use Ffunctionp.
ca105506 5053
03408648
SM
5054 * fns.c (concat, mapcar1): Accept byte-code-functions.
5055
5056 * eval.c (Fsetq): Handle lexical vars.
5057 (Fdefun, Fdefmacro, Ffunction): Make closures when needed.
5058 (Fdefconst, Fdefvaralias, Fdefvar): Mark as dynamic.
5059 (FletX, Flet): Obey lexical binding.
5060 (Fcommandp): Handle closures.
5061 (Feval): New `lexical' arg.
5062 (eval_sub): New function extracted from Feval. Use it almost
5063 everywhere where Feval was used. Look up vars in lexical env.
5064 Handle closures.
5065 (Ffunctionp): Move from subr.el.
5066 (Ffuncall): Handle closures.
5067 (apply_lambda): Remove `eval_flags'.
5068 (funcall_lambda): Handle closures and new byte-code-functions.
5069 (Fspecial_variable_p): New function.
5070 (syms_of_eval): Initialize the Vinternal_interpreter_environment var,
5071 but without exporting it to Lisp.
23aba0ea 5072
23aba0ea 5073 * doc.c (Fdocumentation, store_function_docstring):
03408648 5074 * data.c (Finteractive_form): Handle closures.
23aba0ea 5075
03408648
SM
5076 * callint.c (Fcall_interactively): Preserve lexical-binding mode for
5077 interactive spec.
ba83908c 5078
04f2d78b
CB
5079 * bytecode.c (Bstack_ref, Bstack_set, Bstack_set2, BdiscardN):
5080 New byte-codes.
03408648
SM
5081 (exec_byte_code): New function extracted from Fbyte_code to handle new
5082 calling convention for byte-code-functions. Add new byte-codes.
ba83908c 5083
03408648 5084 * buffer.c (defvar_per_buffer): Set new `declared_special' field.
e2abe5a1 5085
03408648 5086 * alloc.c (Fmake_symbol): Init new `declared_special' field.
e2abe5a1 5087
e2abce01
JB
50882011-03-31 Juanma Barranquero <lekktu@gmail.com>
5089
5090 * xdisp.c (redisplay_internal): Fix prototype.
5091
63696a73 50922011-03-31 Eli Zaretskii <eliz@gnu.org>
09725d26 5093
63696a73 5094 * xdisp.c (SCROLL_LIMIT): New macro.
04f2d78b
CB
5095 (try_scrolling): Use it when setting scroll_limit.
5096 Limit scrolling to 100 screen lines.
63696a73
EZ
5097 (redisplay_window): Even when falling back on "recentering",
5098 position point in the window according to scroll-conservatively,
5099 scroll-margin, and scroll-*-aggressively variables. (Bug#6671)
5100
5101 (try_scrolling): When point is above the window, allow searching
5102 as far as scroll_max, or one screenful, to compute vertical
5103 distance from PT to the scroll margin position. This prevents
5104 try_scrolling from unnecessarily failing when
5105 scroll-conservatively is set to a value slightly larger than the
5106 window height. Clean up the case of PT below the margin at bottom
5107 of window: scroll_max can no longer be INT_MAX. When aggressive
5108 scrolling is in use, don't let point enter the opposite scroll
5109 margin as result of the scroll.
5110 (syms_of_xdisp) <scroll-conservatively>: Document the
09725d26
EZ
5111 threshold of 100 lines for never-recentering scrolling.
5112
e4cc2dfc
JB
51132011-03-31 Juanma Barranquero <lekktu@gmail.com>
5114
5115 * dispextern.h (move_it_by_lines):
5116 * xdisp.c (move_it_by_lines): Remove parameter `need_y_p', unused
5117 since 2000-12-29T14:24:09Z!gerd@gnu.org. All callers changed.
5118 (message_log_check_duplicate): Remove parameters `prev_bol' and
5119 `this_bol', unused since 1998-01-01T02:27:27Z!rms@gnu.org. All callers changed.
5120 (redisplay_internal): Remove parameter `preserve_echo_area',
5121 unused since 1999-07-21T21:43:52Z!gerd@gnu.org. All callers changed.
5122
5123 * indent.c (Fvertical_motion):
5124 * window.c (window_scroll_pixel_based, Frecenter):
5125 Don't pass `need_y_p' to `move_it_by_lines'.
5126
1c470562
SM
51272011-03-30 Stefan Monnier <monnier@iro.umontreal.ca>
5128
44f230aa
SM
5129 * eval.c (struct backtrace): Don't cheat with negative numbers, but do
5130 steal a few bits to be more compact.
5131 (interactive_p, Fbacktrace, Fbacktrace_frame, mark_backtrace):
5132 Remove unneeded casts.
5133
1c470562
SM
5134 * bytecode.c (Fbyte_code): CAR and CDR can GC.
5135
888adce9
ZK
51362011-03-30 Zachary Kanfer <zkanfer@gmail.com> (tiny change)
5137
5138 * keyboard.c (Fexecute_extended_command): Do log the "suggest key
5139 binding" message (bug#7967).
5140
f838ed7b
PE
51412011-03-30 Paul Eggert <eggert@cs.ucla.edu>
5142
77861b95
PE
5143 Fix more problems found by GCC 4.6.0's static checks.
5144
de6dbc14
PE
5145 * unexelf.c (unexec) [! (defined _SYSTYPE_SYSV || defined __sgi)]:
5146 Remove unused local var.
5147
f838ed7b
PE
5148 * editfns.c (Fmessage_box): Remove unused local var.
5149
792c7b2b
PE
5150 * xdisp.c (try_window_reusing_current_matrix, x_produce_glyphs):
5151 (note_mode_line_or_margin_highlight, note_mouse_highlight):
5152 Omit unused local vars.
c499e557 5153 * window.c (shrink_windows): Omit unused local var.
b01a1c29 5154 * menu.c (digest_single_submenu): Omit unused local var.
0bc32927
PE
5155 * dispnew.c (update_window) [PERIODIC_PREEMPTION_CHECKING]:
5156 Omit unused local var.
5157
ba0165e1
PE
5158 * keyboard.c (parse_modifiers_uncached, parse_modifiers):
5159 Don't assume string length fits in int.
32ad8845 5160 (keyremap_step, read_key_sequence): Use size_t for sizes.
48011560 5161 (read_key_sequence): Don't check last_real_key_start redundantly.
ba0165e1 5162
3c59b4c9
PE
5163 * callproc.c (Fcall_process, Fcall_process_region): Use SAFE_ALLOCA
5164 instead of alloca (Bug#8344).
5165
a3eed478 5166 * eval.c (Fbacktrace): Don't assume nargs fits in int.
5d5d959d 5167 (Fbacktrace_frame): Don't assume nframes fits in int.
a3eed478 5168
eb4d412d
PE
5169 * syntax.c (scan_sexps_forward): Avoid pointer wraparound.
5170
1658b401
PE
5171 * xterm.c (x_make_frame_visible, same_x_server): Redo to avoid overflow
5172 concerns.
5173
5174 * term.c (produce_glyphless_glyph): Remove unnecessary test.
5175
5176 * cm.c (calccost): Turn while-do into do-while, for clarity.
44f730c8 5177
9a2c6e05
PE
5178 * keyboard.c (syms_of_keyboard): Use the same style as later
5179 in this function when indexing through an array. This also
5180 works around GCC bug 48267.
5181
03d0a109
PE
5182 * image.c (tiff_load): Fix off-by-one image count (Bug#8336).
5183
44f730c8
PE
5184 * xselect.c (x_check_property_data): Return correct size (Bug#8335).
5185
fe75f926
PE
5186 * chartab.c (sub_char_table_ref_and_range): Redo for slight
5187 efficiency gain, and to bypass a gcc -Wstrict-overflow warning.
5188
ffa8c828
PE
5189 * keyboard.c, keyboard.h (num_input_events): Now size_t.
5190 This avoids undefined behavior on integer overflow, and is a bit
5191 more convenient anyway since it is compared to a size_t variable.
5192
c5101a77
PE
5193 Variadic C functions now count arguments with size_t, not int.
5194 This avoids an unnecessary limitation on 64-bit machines, which
5195 caused (substring ...) to crash on large vectors (Bug#8344).
5196 * lisp.h (struct Lisp_Subr.function.aMANY): Now takes size_t, not int.
5197 (DEFUN_ARGS_MANY, internal_condition_case_n, safe_call): Likewise.
77861b95 5198 All variadic functions and their callers changed accordingly.
c5101a77
PE
5199 (struct gcpro.nvars): Now size_t, not int. All uses changed.
5200 * data.c (arith_driver, float_arith_driver): Likewise.
5201 * editfns.c (general_insert_function): Likewise.
5202 * eval.c (struct backtrace.nargs, interactive_p)
5203 (internal_condition_case_n, run_hook_with_args, apply_lambda)
5204 (funcall_lambda, mark_backtrace): Likewise.
5205 * fns.c (concat): Likewise.
5206 * frame.c (x_set_frame_parameters): Likewise.
5207 * fns.c (get_key_arg): Now accepts and returns size_t, and returns
5208 0 if not found, not -1. All callers changed.
5209
dd3f25f7
PE
5210 * alloc.c (garbage_collect): Don't assume stack size fits in int.
5211 (stack_copy_size): Now size_t, not int.
5212 (stack_copy, stack_copy_size): Define only if MAX_SAVE_STACK > 0.
5213
461c2ab9
JB
52142011-03-28 Juanma Barranquero <lekktu@gmail.com>
5215
5216 * coding.c (encode_designation_at_bol): Remove parameter `charbuf_end',
5217 unused since 2002-03-01T01:17:24Z!handa@m17n.org and 2008-02-01T16:01:31Z!miles@gnu.org.
5218 All callers changed.
5219
5220 * lisp.h (multibyte_char_to_unibyte):
5221 * character.c (multibyte_char_to_unibyte): Remove parameter `rev_tbl',
5222 unused since 2002-03-01T01:16:34Z!handa@m17n.org and 2008-02-01T16:01:31Z!miles@gnu.org.
5223 * character.h (CHAR_TO_BYTE8):
5224 * cmds.c (internal_self_insert):
5225 * editfns.c (general_insert_function):
5226 * keymap.c (push_key_description):
5227 * search.c (Freplace_match):
5228 * xdisp.c (message_dolog, set_message_1): All callers changed.
5229
f6d62986
SM
52302011-03-28 Stefan Monnier <monnier@iro.umontreal.ca>
5231
5232 * keyboard.c (safe_run_hook_funcall): New function.
5233 (safe_run_hooks_1, safe_run_hooks_error, safe_run_hooks): On error,
5234 don't set the hook to nil, but remove the offending function instead.
5235 (Qcommand_hook_internal): Remove, unused.
5236 (syms_of_keyboard): Don't initialize Qcommand_hook_internal nor define
5237 Vcommand_hook_internal.
5238
5239 * eval.c (enum run_hooks_condition): Remove.
5240 (funcall_nil, funcall_not): New functions.
5241 (run_hook_with_args): Call each function through a `funcall' argument.
5242 Remove `cond' argument, now redundant.
5243 (Frun_hooks, Frun_hook_with_args, Frun_hook_with_args_until_success)
5244 (Frun_hook_with_args_until_failure): Adjust accordingly.
5245 (run_hook_wrapped_funcall, Frun_hook_wrapped): New functions.
5246
1db5b1ad
JB
52472011-03-28 Juanma Barranquero <lekktu@gmail.com>
5248
5249 * dispextern.h (string_buffer_position): Remove declaration.
5250
5251 * print.c (strout): Remove parameter `multibyte', unused since
5252 1999-08-21T19:30:21Z!gerd@gnu.org. All callers changed.
5253
5254 * search.c (boyer_moore): Remove parameters `len', `pos' and `lim',
5255 never used since function introduction in 1998-02-08T21:33:56Z!rms@gnu.org.
5256 All callers changed.
5257
5258 * w32.c (_wsa_errlist): Use braces for struct initializers.
5259
5260 * xdisp.c (string_buffer_position_lim): Remove parameter `w',
5261 never used since function introduction in 2001-03-09T18:41:50Z!gerd@gnu.org.
5262 All callers changed.
5263 (string_buffer_position): Likewise. Also, make static (it's never
5264 used outside xdisp.c).
5265 (cursor_row_p): Remove parameter `w', unused since
5266 2000-10-17T16:08:57Z!gerd@gnu.org. All callers changed.
5267 (decode_mode_spec): Remove parameter `precision', introduced during
5268 Gerd Moellmann's rewrite at 1999-07-21T21:43:52Z!gerd@gnu.org, but never used.
5269 All callers changed.
5270
5ffb62aa
JD
52712011-03-27 Jan Djärv <jan.h.d@swipnet.se>
5272
5273 * nsterm.m (syms_of_nsterm): Use doc: for ns-auto-hide-menu-bar.
5274
461c2ab9 52752011-03-27 Anders Lindgren <andlind@gmail.com>
f0a1382a
JD
5276
5277 * nsterm.m (ns_menu_bar_is_hidden): New variable.
5278 (ns_constrain_all_frames, ns_menu_bar_should_be_hidden)
5279 (ns_update_auto_hide_menu_bar): New functions.
5280 (ns_update_begin): Call ns_update_auto_hide_menu_bar.
5281 (applicationDidBecomeActive): Call ns_update_auto_hide_menu_bar and
5282 ns_constrain_all_frames.
5283 (constrainFrameRect): Return at once if ns_menu_bar_should_be_hidden.
5284 (syms_of_nsterm): DEFVAR ns-auto-hide-menu-bar, init to Qnil.
5285
5c380ffb
JD
52862011-03-27 Jan Djärv <jan.h.d@swipnet.se>
5287
5288 * nsmenu.m (runDialogAt): Remove argument to timer_check.
5289
9af30bdf
GM
52902011-03-27 Glenn Morris <rgm@gnu.org>
5291
5292 * syssignal.h: Replace RETSIGTYPE with void.
5293 * atimer.c, data.c, dispnew.c, emacs.c, floatfns.c, keyboard.c:
5294 * keyboard.h, lisp.h, process.c, sysdep.c, xterm.c:
5295 Replace SIGTYPE with void everywhere.
5296 * s/usg5-4-common.h (SIGTYPE): Remove definition.
5297 * s/template.h (SIGTYPE): Remove commented out definition.
5298
e2abce01
JB
52992011-03-26 Eli Zaretskii <eliz@gnu.org>
5300
5301 * xdisp.c (redisplay_window): Don't check buffer's clip_changed
5302 flag as a prerequisite for invoking try_scrolling. (Bug#6671)
5303
f868cd8a
JB
53042011-03-26 Juanma Barranquero <lekktu@gmail.com>
5305
59eb0929
JB
5306 * w32.c (read_unc_volume): Use parameter `henum', instead of
5307 global variable `wget_enum_handle'.
5308
5309 * keymap.c (describe_vector): Remove parameters `indices' and
5310 `char_table_depth', unused since 2002-03-01T01:43:26Z!handa@m17n.org.
5311 (describe_map, Fdescribe_vector): Adjust calls to `describe_vector'.
5312
f868cd8a
JB
5313 * keyboard.h (timer_check, show_help_echo): Remove unused parameters.
5314
5315 * keyboard.c (timer_check): Remove parameter `do_it_now',
5316 unused since 1996-04-12T06:01:29Z!rms@gnu.org.
5317 (show_help_echo): Remove parameter `ok_to_overwrite_keystroke_echo',
5318 unused since 2008-04-19T19:30:53Z!monnier@iro.umontreal.ca.
5319
5320 * keyboard.c (read_char):
5321 * w32menu.c (w32_menu_display_help):
5322 * xmenu.c (show_help_event, menu_help_callback):
5323 Adjust calls to `show_help_echo'.
5324
5325 * gtkutil.c (xg_maybe_add_timer):
5326 * keyboard.c (readable_events):
5327 * process.c (wait_reading_process_output):
5328 * xmenu.c (x_menu_wait_for_event): Adjust calls to `timer_check'.
5329
5330 * insdel.c (adjust_markers_gap_motion):
5331 Remove; no-op since 1998-01-02T21:29:48Z!rms@gnu.org.
5332 (gap_left, gap_right): Don't call it.
5333
2ecf6fdb
CY
53342011-03-25 Chong Yidong <cyd@stupidchicken.com>
5335
5336 * xdisp.c (handle_fontified_prop): Discard changes to clip_changed
5337 incurred during fontification.
5338
6b1f9ba4
JB
53392011-03-25 Juanma Barranquero <lekktu@gmail.com>
5340
5341 * buffer.c (defvar_per_buffer): Remove unused parameter `doc'.
5342 (DEFVAR_PER_BUFFER): Don't pass it.
5343
5344 * dispnew.c (row_equal_p, add_row_entry): Remove unused parameter `w'.
5345 (scrolling_window): Don't pass it.
5346
0f4a96b5
JB
53472011-03-25 Juanma Barranquero <lekktu@gmail.com>
5348
5349 * dispextern.h (glyph_matric): Use #if GLYPH_DEBUG, not #ifdef.
5350
5351 * fileio.c (check_executable) [DOS_NT]: Remove unused variables `len'
5352 and `suffix'.
5353 (Fset_file_selinux_context) [HAVE_LIBSELINUX]: Move here declaration
5354 of variables specific to SELinux and computation of `encoded_absname'.
5355
5356 * image.c (XPutPixel): Remove unused variable `height'.
5357
5358 * keyboard.c (make_lispy_event): Remove unused variable `hpos'.
5359
5360 * unexw32.c (get_section_info): Remove unused variable `section'.
5361
5362 * w32.c (stat): Remove unused variables `drive_root' and `devtype'.
5363 (system_process_attributes): Remove unused variable `sess'.
5364 (sys_read): Remove unused variable `err'.
5365
5366 * w32fns.c (top): Wrap variables with #if GLYPH_DEBUG, not #ifdef.
5367 (w32_wnd_proc): Remove unused variable `isdead'.
5368 (unwind_create_frame): Use #if GLYPH_DEBUG, not #ifdef.
5369 (Fx_server_max_request_size): Remove unused variable `dpyinfo'.
5370 (x_create_tip_frame): Remove unused variable `tem'.
5371
5372 * w32inevt.c (w32_console_read_socket):
5373 Remove unused variable `no_events'.
5374
5375 * w32term.c (x_draw_composite_glyph_string_foreground):
5376 Remove unused variable `width'.
5377
1149507c
JB
53782011-03-24 Juanma Barranquero <lekktu@gmail.com>
5379
5380 * w32term.c (x_set_glyph_string_clipping):
5381 Don't pass uninitialized region to CombineRgn.
5382
9c88f339
JB
53832011-03-23 Juanma Barranquero <lekktu@gmail.com>
5384
5385 * w32fns.c (x_set_menu_bar_lines): Remove unused variable `olines'.
5386 (w32_wnd_proc): Pass NULL to Windows API, not uninitialized buffer.
5387 (Fx_close_connection): Remove unused variable `i'.
5388
5389 * w32font.c (w32font_draw): Return number of glyphs.
5390 (w32font_open_internal): Remove unused variable `i'.
5391 (w32font_driver): Add missing initializer.
5392
5393 * w32menu.c (utf8to16): Remove unused variable `utf16'.
5394 (fill_in_menu): Remove unused variable `items_added'.
5395
5396 * w32term.c (last_mouse_press_frame): Remove static global variable.
5397 (w32_clip_to_row): Remove unused variable `f'.
5398 (x_delete_terminal): Remove unused variable `i'.
5399
5400 * w32uniscribe.c (uniscribe_shape): Remove unused variable `nclusters'.
5401 (NOTHING): Remove unused static global variable.
5402 (uniscribe_check_otf): Remove unused variable `table'.
5403 (uniscribe_font_driver): Add missing initializers.
5404
dee091a3
JD
54052011-03-23 Julien Danjou <julien@danjou.info>
5406
5407 * term.c (Fsuspend_tty, Fresume_tty):
5408 * minibuf.c (read_minibuf, run_exit_minibuf_hook):
5409 * window.c (temp_output_buffer_show):
5410 * insdel.c (signal_before_change):
5411 * frame.c (Fhandle_switch_frame):
5412 * fileio.c (Fdo_auto_save):
5413 * emacs.c (Fkill_emacs):
5414 * editfns.c (save_excursion_restore):
5415 * cmds.c (internal_self_insert):
5416 * callint.c (Fcall_interactively):
5417 * buffer.c (Fkill_all_local_variables):
5418 * keyboard.c (Fcommand_execute, Fsuspend_emacs, safe_run_hooks_1):
5419 Use Frun_hooks.
0f4a96b5 5420 (command_loop_1): Use Frun_hooks. Call safe_run_hooks
dee091a3
JD
5421 unconditionnaly since it does the check itself.
5422
2c520ab5 54232011-03-23 Paul Eggert <eggert@cs.ucla.edu>
f0641eff 5424
c9c49752
PE
5425 Fix more problems found by GCC 4.5.2's static checks.
5426
8abc3f12
PE
5427 * coding.c (encode_coding_raw_text): Avoid unnecessary test
5428 the first time through the loop, since we know p0 < p1 then.
5429 This also avoids a gcc -Wstrict-overflow warning.
5430
a2d26660
PE
5431 * lisp.h (SAFE_ALLOCA, SAFE_ALLOCA_LISP): Avoid 'int' overflow
5432 leading to a memory leak, possible in functions like
5433 load_charset_map_from_file that can allocate an unbounded number
b12ef411 5434 of objects (Bug#8318).
a2d26660 5435
916c72e9
PE
5436 * xmenu.c (set_frame_menubar): Use EMACS_UINT, not int, for indexes
5437 that could (at least in theory) be that large.
5438
19ab8a18
PE
5439 * xdisp.c (message_log_check_duplicate): Return unsigned long, not int.
5440 This is less likely to overflow, and avoids undefined behavior if
5441 overflow does occur. All callers changed. Use strtoul to scan
5442 for the unsigned long integer.
b7cbbd6f
PE
5443 (pint2hrstr): Simplify and tune code slightly.
5444 This also avoids a (bogus) GCC warning with gcc -Wstrict-overflow.
19ab8a18 5445
f0641eff
PE
5446 * scroll.c (do_scrolling): Work around GCC bug 48228.
5447 See <http://gcc.gnu.org/bugzilla/show_bug.cgi?id=48228>.
5448
7f650bb9
PE
5449 * frame.c (Fmodify_frame_parameters): Simplify loop counter.
5450 This also avoids a warning with gcc -Wstrict-overflow.
39f5e519
PE
5451 (validate_x_resource_name): Simplify count usage.
5452 This also avoids a warning with gcc -Wstrict-overflow.
7f650bb9 5453
37dd57d1
PE
5454 * fileio.c (Fcopy_file): Report error if fchown or fchmod
5455 fail (Bug#8306).
81e56e61 5456
699979fc 5457 * emacs.c (Fdaemon_initialized): Do not ignore I/O errors (Bug#8303).
dc1ca6a8 5458
401bf9b4
PE
5459 * process.c (Fmake_network_process): Use socklen_t, not int,
5460 where POSIX says socklen_t is required in portable programs.
5461 This fixes a porting bug on hosts like 64-bit HP-UX, where
591b2973 5462 socklen_t is wider than int (Bug#8277).
401bf9b4
PE
5463 (Fmake_network_process, server_accept_connection):
5464 (wait_reading_process_output, read_process_output):
5465 Likewise.
5466
b93aacde
PE
5467 * process.c: Rename or move locals to avoid shadowing.
5468 (list_processes_1, Fmake_network_process):
5469 (read_process_output_error_handler, exec_sentinel_error_handler):
5470 Rename or move locals.
4dc343ee 5471 (Fmake_network_process): Define label "retry_connect" only if needed.
0da49335 5472 (Fnetwork_interface_info): Fix pointer signedness.
f990b4e5 5473 (process_send_signal): Add cast to avoid pointer signedness problem.
7b808126 5474 (FIRST_PROC_DESC, IF_NON_BLOCKING_CONNECT): Remove unused macros.
c939f91b 5475 (create_process): Use 'volatile' to avoid vfork clobbering (Bug#8298).
b93aacde 5476
af8a867c 5477 Make tparam.h and terminfo.c consistent.
44f230aa
SM
5478 * cm.c (tputs, tgoto, BC, UP): Remove extern decls.
5479 Include tparam.h instead, since it declares them.
af8a867c
PE
5480 * cm.h (PC): Remove extern decl; tparam.h now does this.
5481 * deps.mk (cm.o, terminfo.o): Depend on tparam.h.
5482 * terminfo.c: Include tparam.h, to check interfaces.
5483 (tparm): Make 1st arg a const pointer in decl. Put it at top level.
5484 (tparam): Adjust signature to match interface in tparam.h;
5485 this removes some undefined behavior. Check that outstring and len
5486 are zero, which they always are with Emacs.
5487 * tparam.h (PC, BC, UP): New extern decls.
5488
0248044d 5489 * xftfont.c (xftfont_shape): Now static, and defined only if needed.
001a7ab4 5490 (xftfont_open): Rename locals to avoid shadowing.
0248044d 5491
8ff096c1 5492 * ftfont.c (ftfont_resolve_generic_family): Fix pointer signedness.
a00924bb
PE
5493 (ftfont_otf_capability, ftfont_shape): Omit decls if not needed.
5494 (OTF_TAG_SYM): Omit macro if not needed.
e932860f 5495 (ftfont_list): Remove unused local.
49eaafba
PE
5496 (get_adstyle_property, ftfont_pattern_entity):
5497 (ftfont_lookup_cache, ftfont_open, ftfont_anchor_point):
5498 Rename locals to avoid shadowing.
8ff096c1 5499
e2be39f6
PE
5500 * xfont.c (xfont_list_family): Mark var as initialized.
5501
c9735e30
PE
5502 * xml.c (make_dom): Now static.
5503
8f5201ae
PE
5504 * composite.c (composition_compute_stop_pos): Rename local to
5505 avoid shadowing.
b246f932
PE
5506 (composition_reseat_it): Remove unused locals.
5507 (find_automatic_composition, composition_adjust_point): Likewise.
80e079b2 5508 (composition_update_it): Mark var as initialized.
11b61122
PE
5509 (find_automatic_composition): Mark vars as initialized,
5510 with a FIXME (Bug#8290).
8f5201ae 5511
760fbc2c
PE
5512 character.h: Rename locals to avoid shadowing.
5513 * character.h (PREV_CHAR_BOUNDARY, FETCH_STRING_CHAR_ADVANCE):
5514 (FETCH_STRING_CHAR_AS_MULTIBYTE_ADVANCE, FETCH_CHAR_ADVANCE):
5515 (FETCH_CHAR_ADVANCE_NO_CHECK, INC_POS, DEC_POS, BUF_INC_POS):
5516 (BUF_DEC_POS): Be more systematic about renaming local temporaries
5517 to avoid shadowing.
5518
ff08eb85
PE
5519 * textprop.c (property_change_between_p): Remove; unused.
5520
fc7bf025
PE
5521 * intervals.c (interval_start_pos): Now static.
5522
235d7abc
PE
5523 * intervals.h (CHECK_TOTAL_LENGTH): Avoid empty "else".
5524
44f230aa
SM
5525 * atimer.c (start_atimer, append_atimer_lists, set_alarm):
5526 Rename locals to avoid shadowing.
3e7d6594 5527
50060332
PE
5528 * sound.c (wav_play, au_play, Fplay_sound_internal):
5529 Fix pointer signedness.
d01f234b 5530 (alsa_choose_format): Remove unused local var.
c83b8872
PE
5531 (wav_play): Initialize a variable to 0, to prevent undefined
5532 behavior (Bug#8278).
50060332 5533
c4fc4e30
PE
5534 * region-cache.c (insert_cache_boundary): Redo var to avoid shadowing.
5535
918436ed
PE
5536 * region-cache.h (pp_cache): New decl, for gcc -Wmissing-prototypes.
5537
c939f91b
PE
5538 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork
5539 clobbering (Bug#8298).
b9c7f648
PE
5540 * sysdep.c (sys_subshell): Likewise.
5541 Previously, the sys_subshell 'volatile' was incorrectly IF_LINTted out.
7e9123a2 5542
6bd8c144
PE
5543 * lisp.h (child_setup): Now NO_RETURN unless DOS_NT.
5544 This should get cleaned up, so that child_setup has the
5545 same signature on all platforms.
5546
7710357c 5547 * callproc.c (call_process_cleanup): Now static.
cb1d0ef7 5548 (relocate_fd): Rename locals to avoid shadowing.
7710357c 5549
c59da222
CY
55502011-03-22 Chong Yidong <cyd@stupidchicken.com>
5551
5552 * xterm.c (x_clear_frame): Remove XClearWindow call. This appears
5553 not to be necessary, and produces flickering.
5554
66b87493
GM
55552011-03-20 Glenn Morris <rgm@gnu.org>
5556
5557 * config.in: Remove file.
5558
45b6f6d5
JB
55592011-03-20 Juanma Barranquero <lekktu@gmail.com>
5560
5561 * minibuf.c (Vcompleting_read_function): Don't declare, global variables
5562 are now in src/globals.h.
5563 (syms_of_minibuf): Remove spurious & from previous change.
5564
3ec03f7e
LL
55652011-03-20 Leo <sdl.web@gmail.com>
5566
5567 * minibuf.c (completing-read-function): New variable.
5568 (completing-read-default): Rename from completing-read.
5569 (completing-read): Call completing-read-function.
5570
b14e3e21
CY
55712011-03-19 Juanma Barranquero <lekktu@gmail.com>
5572
5573 * xfaces.c (Fx_load_color_file):
5574 Read color file from absolute filename (bug#8250).
5575
f2b726e6
JB
55762011-03-19 Juanma Barranquero <lekktu@gmail.com>
5577
5578 * makefile.w32-in: Update dependencies.
5579
09f6ff02
EZ
55802011-03-17 Eli Zaretskii <eliz@gnu.org>
5581
5582 * makefile.w32-in ($(BLD)/unexw32.$(O)): Depend on $(SRC)/unexec.h.
5583
29a6015a
PE
55842011-03-17 Paul Eggert <eggert@cs.ucla.edu>
5585
a3a6c54e
PE
5586 Fix more problems found by GCC 4.5.2's static checks.
5587
b766f867
PE
5588 * process.c (make_serial_process_unwind, send_process_trap):
5589 (sigchld_handler): Now static.
5590
be02381c
PE
5591 * process.c (allocate_pty): Let PTY_ITERATION declare iteration vars.
5592 That way, the code declares only the vars that it needs.
5593 * s/aix4-2.h (PTY_ITERATION): Declare iteration vars.
5594 * s/cygwin.h (PTY_ITERATION): Likewise.
5595 * s/darwin.h (PTY_ITERATION): Likewise.
5596 * s/gnu-linux.h (PTY_ITERATION): Likewise.
5597
57048744
PE
5598 * s/irix6-5.h (PTY_OPEN): Declare stb, to loosen coupling.
5599 * process.c (allocate_pty): Don't declare stb unless it's needed.
5600
7914961c 5601 * bytecode.c (MAYBE_GC): Rewrite so as not to use empty "else".
615f2d59
PE
5602 (CONSTANTLIM): Remove; unused.
5603 (METER_CODE, Bscan_buffer, Bread_char, Bset_mark):
5604 Define only if needed.
7914961c 5605
b3967b18
PE
5606 * unexelf.c (unexec): Name an expression,
5607 to avoid gcc -Wbad-function-cast warning.
9ae71512
PE
5608 Use a different way to cause a compilation error if anyone uses
5609 n rather than nn, a way that does not involve shadowing.
73366a00 5610 (ELF_BSS_SECTION_NAME, OLD_PROGRAM_H): Remove; unused.
b3967b18 5611
29a6015a
PE
5612 * deps.mk (unexalpha.o): Remove; unused.
5613
43cfc33e 5614 New file unexec.h, the (simple) interface for unexec (Bug#8267).
7feda0d2 5615 * unexec.h: New file.
ce701a33
PE
5616 * deps.mk (emacs.o, unexaix.o, unexcw.o, unexcoff.o, unexelf.o):
5617 (unexhp9k800.o, unexmacosx.o, unexsol.o, unexw32.o):
5618 Depend on unexec.h.
5619 * emacs.c [!defined CANNOT_DUMP]: Include unexec.h.
5620 * unexaix.c, unexcoff.c, unexcw.c, unexelf.c, unexhp9k800.c:
5621 * unexmacosx.c, unexsol.c, unexw32.c: Include unexec.h.
381259ef 5622 Change as necessary to match prototype in unexec.h.
ce701a33 5623
01f44d5a
PE
5624 * syntax.c (Fforward_comment, scan_lists): Rename locals to avoid
5625 shadowing.
4f63c6bb 5626 (back_comment, skip_chars): Mark vars as initialized.
01f44d5a 5627
a6670b0b
PE
5628 * character.h (FETCH_STRING_CHAR_ADVANCE_NO_CHECK, BUF_INC_POS):
5629 Rename locals to avoid shadowing.
5630
cef2010d 5631 * lread.c (read1): Rewrite so as not to use empty "else".
0902fe45 5632 (Fload, readevalloop, read1): Rename locals to avoid shadowing.
cef2010d 5633
d4d7173a
PE
5634 * print.c (Fredirect_debugging_output): Fix pointer signedess.
5635
f08b802a
PE
5636 * lisp.h (debug_output_compilation_hack): Add decl here, to avoid
5637 warning when compiling print.c.
5638
3ddb0639
PE
5639 * font.c (font_unparse_fcname): Abort in an "impossible" situation
5640 instead of using an uninitialized var.
5ad03b97 5641 (font_sort_entities): Mark var as initialized.
3ddb0639 5642
170a2692
PE
5643 * character.h (FETCH_CHAR_ADVANCE): Rename locals to avoid shadowing.
5644
e663c700
PE
5645 * font.c (font_unparse_xlfd): Don't mix pointers to variables with
5646 pointers to constants.
89bc529a 5647 (font_parse_fcname): Remove unused vars.
7b81e2d0 5648 (font_delete_unmatched): Now static.
ea838e10 5649 (font_get_spec): Remove; unused.
13a547c6
PE
5650 (font_style_to_value, font_prop_validate_style, font_unparse_fcname):
5651 (font_update_drivers, Ffont_get_glyphs, font_add_log):
5652 Rename or move locals to avoid shadowing.
e663c700 5653
2a80c887 5654 * fns.c (require_nesting_list, require_unwind): Now static.
612f56df 5655 (Ffillarray): Rename locals to avoid shadowing.
2a80c887 5656
1384fa33 5657 * floatfns.c (domain_error2): Define only if needed.
a885e2ed 5658 (Ffrexp, Fldexp): Rename locals to avoid shadowing.
1384fa33 5659
8b2c52e9
PE
5660 * alloc.c (mark_backtrace): Move decl from here ...
5661 * lisp.h: ... to here, so that it can be checked.
5662
475545b5 5663 * eval.c (call_debugger, do_debug_on_call, grow_specpdl): Now static.
d28a2170 5664 (Fdefvar): Rewrite so as not to use empty "else".
cfcbfb1a
PE
5665 (lisp_indirect_variable): Name an expression,
5666 to avoid gcc -Wbad-function-cast warning.
1faed8ae 5667 (Fdefvar): Rename locals to avoid shadowing.
475545b5 5668
b1349114 5669 * callint.c (quotify_arg, quotify_args): Now static.
a3e8cbda 5670 (Fcall_interactively): Rename locals to avoid shadowing.
b0e80955 5671 Use const pointer when appropriate.
b1349114 5672
a2928364
PE
5673 * lisp.h (get_system_name, get_operating_system_release):
5674 Move decls here, to check interfaces.
5675 * process.c (get_operating_system_release): Move decl to lisp.h.
5676 * xrdb.c (get_system_name): Likewise.
63c5d10b
PE
5677 * editfns.c (init_editfns, Fuser_login_name, Fuser_uid):
5678 (Fuser_real_uid, Fuser_full_name): Remove unnecessary casts,
5679 some of which prompt warnings from gcc -Wbad-function-cast.
545b49b4
PE
5680 (Fformat_time_string, Fencode_time, Finsert_char):
5681 (Ftranslate_region_internal, Fformat):
5682 Rename or remove local vars to avoid shadowing.
9710023e 5683 (Ftranslate_region_internal): Mark var as initialized.
63c5d10b 5684
a415e694
PE
5685 * doc.c (Fdocumentation, Fsnarf_documentation): Move locals to
5686 avoid shadowing.
5687
8ef4622d
PE
5688 * lisp.h (eassert): Check that the argument compiles, even if
5689 ENABLE_CHECKING is not defined.
5690
946f9a5b
PE
5691 * data.c (Findirect_variable): Name an expression, to avoid
5692 gcc -Wbad-function-cast warning.
112396d6 5693 (default_value, arithcompare, arith_driver, arith_error): Now static.
b9b84fa9 5694 (store_symval_forwarding): Rename local to avoid shadowing.
44f230aa
SM
5695 (Fmake_variable_buffer_local, Fmake_local_variable):
5696 Mark variables as initialized.
52746918 5697 (do_blv_forwarding, do_symval_forwarding): Remove; unused.
946f9a5b 5698
e5aab7e7 5699 * alloc.c (check_cons_list): Do not define unless GC_CHECK_CONS_LIST.
ae35e756
PE
5700 (Fmake_vector, Fvector, Fmake_byte_code, Fgarbage_collect):
5701 Rename locals to avoid shadowing.
dff45157
PE
5702 (mark_stack): Move local variables into the #ifdef region where
5703 they're used.
7bc26fdb
PE
5704 (BLOCK_INPUT_ALLOC, UNBLOCK_INPUT_ALLOC): Define only if
5705 ! defined SYSTEM_MALLOC && ! defined SYNC_INPUT, as they are not
5706 needed otherwise.
5707 (CHECK_ALLOCATED): Define only if GC_CHECK_MARKED_OBJECTS.
5708 (GC_STRING_CHARS): Remove; not used.
d40d4be1 5709 (Fmemory_limit): Cast sbrk's returned value to char *.
ae35e756 5710
e5aab7e7
PE
5711 * lisp.h (check_cons_list): Declare if GC_CHECK_CONS_LIST; this
5712 avoids undefined behavior in theory.
5713
4da60324
PE
5714 * regex.c (IF_LINT): Add defn, for benefit of ../lib-src.
5715
88043301
PE
5716 Use functions, not macros, for up- and down-casing (Bug#8254).
5717 * buffer.h (DOWNCASE_TABLE, UPCASE_TABLE, DOWNCASE, UPPERCASEP):
5718 (NOCASEP, LOWERCASEP, UPCASE, UPCASE1): Remove. All callers changed
5719 to use the following functions instead of these macros.
5720 (downcase): Adjust to lack of DOWNCASE_TABLE. Return int, not
5721 EMACS_INT, since callers assume the returned value fits in int.
5722 (upcase1): Likewise, for UPCASE_TABLE.
5723 (uppercasep, lowercasep, upcase): New static inline functions.
0da09c43 5724 * editfns.c (Fchar_equal): Remove no-longer-needed workaround for
db69b0cd 5725 the race-condition problem in the old DOWNCASE.
88043301 5726
19ed5445
PE
5727 * regex.c (CHARSET_LOOKUP_RANGE_TABLE_RAW, POP_FAILURE_REG_OR_COUNT):
5728 Rename locals to avoid shadowing.
5729 (regex_compile, re_match_2_internal): Move locals to avoid shadowing.
abbd1bcf
PE
5730 (regex_compile, re_search_2, re_match_2_internal):
5731 Remove unused local vars.
952db0d7
PE
5732 (FREE_VAR): Rewrite so as not to use empty "else",
5733 which gcc can warn about.
da053e48 5734 (regex_compile, re_match_2_internal): Mark locals as initialized.
b313f9d8
PE
5735 (RETALLOC_IF): Define only if needed.
5736 (WORDCHAR_P): Likewise. This one is never needed, but is used
5737 only in a comment talking about a compiler bug, so put inside
5738 the #if 0 of that comment.
5739 (CHARSET_LOOKUP_BITMAP, FAIL_STACK_FULL, RESET_FAIL_STACK):
5740 (PUSH_FAILURE_ELT, BUF_PUSH_3, STOP_ADDR_VSTRING):
5741 Remove; unused.
19ed5445 5742
1f3561e4 5743 * search.c (boyer_moore): Rename locals to avoid shadowing.
76ef09b7
PE
5744 * character.h (FETCH_STRING_CHAR_AS_MULTIBYTE_ADVANCE):
5745 (PREV_CHAR_BOUNDARY): Likewise.
1f3561e4 5746
ded6f8f7
PE
5747 * search.c (simple_search): Remove unused var.
5748
dbd37a95
PE
5749 * dired.c (compile_pattern): Move decl from here ...
5750 * lisp.h: ... to here, so that it can be checked.
5751 (struct re_registers): New forward decl.
5752
7e47afad
PE
5753 * character.h (INC_POS, DEC_POS): Rename locals to avoid shadowing.
5754
85f24f61
PE
5755 * indent.c (MULTIBYTE_BYTES_WIDTH): New args bytes, width.
5756 All uses changed.
5757 (MULTIBYTE_BYTES_WIDTH, scan_for_column, compute_motion):
5758 Rename locals to avoid shadowing.
5671df8f 5759 (Fvertical_motion): Mark locals as initialized.
85f24f61 5760
181aa2be 5761 * casefiddle.c (casify_object, casify_region): Now static.
e45a141a 5762 (casify_region): Mark local as initialized.
181aa2be 5763
930d429c
PE
5764 * cmds.c (internal_self_insert): Rename local to avoid shadowing.
5765
7082eac6
PE
5766 * lisp.h (GCPRO2_VAR, GCPRO3_VAR, GCPRO4_VAR, GCPRO5_VAR, GCPRO6_VAR):
5767 New macros, so that the caller can use some names other than
5768 gcpro1, gcpro2, etc.
5769 (GCPRO2, GCPRO3, GCPRO4, GCPRO5, GCPRO6): Reimplement in terms
5770 of the new macros.
5771 (GCPRO1_VAR, UNGCPRO_VAR): Change the meaning of the second
5772 argument, for consistency with GCPRO2_VAR, etc: it is now the
5773 prefix of the variable, not the variable itself. All uses
5774 changed.
38b2c076
PE
5775 * dired.c (directory_files_internal, file_name_completion):
5776 Rename locals to avoid shadowing.
5777
15206ed9
PE
5778 Fix a race condition diagnosed by gcc -Wsequence-point (Bug#8254).
5779 An expression of the form (DOWNCASE (x) == DOWNCASE (y)), found in
5780 dired.c's scmp function, had undefined behavior.
5781 * lisp.h (DOWNCASE_TABLE, UPCASE_TABLE, DOWNCASE, UPPERCASEP):
5782 (NOCASEP, LOWERCASEP, UPCASE, UPCASE1): Move from here ...
5783 * buffer.h: ... to here, because these macros use current_buffer,
5784 and the new implementation with inline functions needs to have
5785 current_buffer in scope now, rather than later when the macros
5786 are used.
5787 (downcase, upcase1): New static inline functions.
5788 (DOWNCASE, UPCASE1): Reimplement using these functions.
5789 This avoids undefined behavior in expressions like
5790 DOWNCASE (x) == DOWNCASE (y), which previously suffered
5791 from race conditions in accessing the global variables
5792 case_temp1 and case_temp2.
5793 * casetab.c (case_temp1, case_temp2): Remove; no longer needed.
5794 * lisp.h (case_temp1, case_temp2): Remove their decls.
5795 * character.h (ASCII_CHAR_P): Move from here ...
5796 * lisp.h: ... to here, so that the inline functions mentioned
5797 above can use them.
5798
4a6bea26
PE
5799 * dired.c (directory_files_internal_unwind): Now static.
5800
f14b7e14
PE
5801 * fileio.c (file_name_as_directory, directory_file_name):
5802 (barf_or_query_if_file_exists, auto_save_error, auto_save_1):
5803 Now static.
2893f146
PE
5804 (file_name_as_directory): Use const pointers when appropriate.
5805 (Fexpand_file_name): Likewise. In particular, newdir might
5806 point at constant storage, so make it a const pointer.
fd4ead52 5807 (Fmake_directory_internal, Fread_file_name): Remove unused vars.
b14aac08
PE
5808 (Ffile_selinux_context, Fset_file_selinux_context): Fix pointer
5809 signedness issues.
f839df0c
PE
5810 (Fset_file_times, Finsert_file_contents, auto_save_error):
5811 Rename locals to avoid shadowing.
f14b7e14 5812
5716756e 5813 * minibuf.c (choose_minibuf_frame_1): Now static.
62137a95
PE
5814 (Ftry_completion, Fall_completions): Rename or remove locals
5815 to avoid shadowing.
5716756e 5816
b4c3046a
PE
5817 * marker.c (bytepos_to_charpos): Remove; unused.
5818
b45db522
PE
5819 * lisp.h (verify_bytepos, count_markers): New decls,
5820 so that gcc does not warn that these functions aren't declared.
5821
85876d07
PE
5822 * insdel.c (check_markers, make_gap_larger, make_gap_smaller):
5823 (reset_var_on_error, Fcombine_after_change_execute_1): Now static.
f0cb4a60 5824 (CHECK_MARKERS): Redo to avoid gcc -Wempty-body diagnostic.
40ef059e 5825 (copy_text): Remove unused local var.
85876d07 5826
03d78a21 5827 * filelock.c (within_one_second): Now static.
b3dd38ab 5828 (lock_file_1): Rename local to avoid shadowing.
03d78a21 5829
5df8f01b
PE
5830 * buffer.c (fix_overlays_before): Mark locals as initialized.
5831 (fix_start_end_in_overlays): Likewise. This function should be
5832 simplified by using pointers-to-pointers, but that's a different
5833 matter.
b1d876f1 5834 (switch_to_buffer_1): Now static.
8f54f30a
PE
5835 (Fkill_buffer, record_buffer, Fbury_buffer, Fset_buffer_multibyte):
5836 (report_overlay_modification): Rename locals to avoid shadowing.
c3bd59b5 5837
a70072c9 5838 * sysdep.c (system_process_attributes): Rename vars to avoid shadowing.
fbd02d7b 5839 Fix pointer signedness issue.
edced198
PE
5840 (sys_subshell): Mark local as volatile if checking for lint,
5841 to suppress a gcc -Wclobbered warning that does not seem to be right.
15dfd3d9 5842 (MAXPATHLEN): Define only if needed.
a70072c9 5843
a0977c44
PE
5844 * process.c (serial_open, serial_configure): Move decls from here ...
5845 * systty.h: ... to here, so that they can be checked.
5846
a884fdcc
PE
5847 * fns.c (get_random, seed_random): Move extern decls from here ...
5848 * lisp.h: ... to here, so that they can be checked.
5849
604efe86 5850 * sysdep.c (reset_io): Now static.
b8950c94 5851 (wait_for_termination_signal): Remove; unused.
604efe86 5852
38fc62d9
PE
5853 * keymap.c (keymap_parent, keymap_memberp, map_keymap_internal):
5854 (copy_keymap_item, append_key, push_text_char_description):
5855 Now static.
1004a21a 5856 (Fwhere_is_internal): Don't test CONSP (sequences) unnecessarily.
dbbb8427 5857 (DENSE_TABLE_SIZE): Remove; unused.
c1141155
PE
5858 (get_keymap, access_keymap, Fdefine_key, Fwhere_is_internal):
5859 (describe_map_tree):
5860 Rename locals to avoid shadowing.
38fc62d9 5861
2f2650da
PE
5862 * keyboard.c: Declare functions static if they are not used elsewhere.
5863 (echo_char, echo_dash, cmd_error, top_level_2):
5864 (poll_for_input, handle_async_input): Now static.
69a058fa
PE
5865 (read_char, kbd_buffer_get_event, make_lispy_position):
5866 (make_lispy_event, make_lispy_movement, apply_modifiers):
5867 (decode_keyboard_code, tty_read_avail_input, menu_bar_items):
5868 (parse_tool_bar_item, read_key_sequence, Fread_key_sequence):
5869 (Fread_key_sequence_vector): Rename locals to avoid shadowing.
c8a06054 5870 (read_key_sequence, read_char): Mark locals as initialized.
3ac94672 5871 (Fexit_recursive_edit, Fabort_recursive_edit): Mark with NO_RETURN.
2f2650da 5872
a053e86c 5873 * keyboard.h (make_ctrl_char): New decl.
da2f2dd9
PE
5874 (mark_kboards): Move decl here ...
5875 * alloc.c (mark_kboards): ... from here.
a053e86c 5876
4752793e
PE
5877 * lisp.h (force_auto_save_soon): New decl.
5878
74f10ca7 5879 * emacs.c (init_cmdargs): Rename local to avoid shadowing.
244fc23d
PE
5880 (DEFINE_DUMMY_FUNCTION): New macro.
5881 (__do_global_ctors, __do_global_ctors_aux, __do_global_dtors, __main):
5882 Use it.
c03cd23f
PE
5883 (main): Add casts to avoid warnings
5884 if GCC considers string literals to be constants.
74f10ca7 5885
022e70d4
PE
5886 * lisp.h (fatal_error_signal): Add decl, since it's exported.
5887
59d6fe83
PE
5888 * dbusbind.c: Pointer signedness fixes.
5889 (xd_signature, xd_append_arg, xd_initialize):
5890 (Fdbus_call_method, Fdbus_call_method_asynchronously):
5891 (Fdbus_method_return_internal, Fdbus_method_error_internal):
5892 (Fdbus_send_signal, xd_read_message_1, Fdbus_register_service):
5893 (Fdbus_register_signal): Use SSDATA when the context wants char *.
5894
78320123
PE
5895 * dbusbind.c (Fdbus_init_bus): Add cast to avoid warning
5896 if GCC considers string literals to be constants.
49cebcca 5897 (Fdbus_register_service, Fdbus_register_method): Remove unused vars.
78320123 5898
35ac2a97
SM
58992011-03-16 Stefan Monnier <monnier@iro.umontreal.ca>
5900
fb103ca9
SM
5901 * print.c (PRINT_CIRCLE_CANDIDATE_P): New macro.
5902 (print_preprocess, print_object): New macro to fix last change.
5903
35ac2a97
SM
5904 * print.c (print_preprocess): Don't forget font objects.
5905
62973b41
JB
59062011-03-16 Juanma Barranquero <lekktu@gmail.com>
5907
5908 * emacs.c (USAGE3): Doc fixes.
5909
0e48bb22
AS
59102011-03-15 Andreas Schwab <schwab@linux-m68k.org>
5911
5912 * coding.c (detect_coding_iso_2022): Reorganize code to clarify
5913 structure.
5914
7684e57b
JB
59152011-03-14 Juanma Barranquero <lekktu@gmail.com>
5916
5917 * lisp.h (VWindow_system, Qfile_name_history):
5918 * keyboard.h (lispy_function_keys) [WINDOWSNT]:
5919 * w32term.h (w32_system_caret_hwnd, w32_system_caret_height)
5920 (w32_system_caret_x, w32_system_caret_y): Declare extern.
5921
5922 * w32select.c: Don't #include "keyboard.h".
c96bbc66 5923 (run_protected): Add extern declaration for waiting_for_input.
7684e57b
JB
5924
5925 * w32.c (Qlocal, noninteractive1, inhibit_window_system):
5926 * w32console.c (detect_input_pending, read_input_pending)
5927 (encode_terminal_code):
5928 * w32fns.c (quit_char, lispy_function_keys, Qtooltip)
5929 (w32_system_caret_hwnd, w32_system_caret_height, w32_system_caret_x)
5930 (w32_system_caret_y, Qfile_name_history):
5931 * w32font.c (w32font_driver, QCantialias, QCotf, QClang):
5932 * w32inevt.c (reinvoke_input_signal, lispy_function_keys):
5933 * w32menu.c (Qmenu_bar, QCtoggle, QCradio, Qoverriding_local_map)
5934 (Qoverriding_terminal_local_map, Qmenu_bar_update_hook):
5935 * w32proc.c (Qlocal, report_file_error):
5936 * w32term.c (Vwindow_system, updating_frame):
5937 * w32uniscribe.c (initialized, uniscribe_font_driver):
5938 Remove unneeded extern declarations.
5939
2aa46d6c
CY
59402011-03-14 Chong Yidong <cyd@stupidchicken.com>
5941
c96bbc66 5942 * buffer.c (Fmake_indirect_buffer): Fix incorrect assertions.
2aa46d6c 5943
cffc6f3b
CY
59442011-03-13 Chong Yidong <cyd@stupidchicken.com>
5945
5946 * buffer.h (BUF_BEGV, BUF_BEGV_BYTE, BUF_ZV, BUF_ZV_BYTE, BUF_PT)
5947 (BUF_PT_BYTE): Rewrite to handle indirect buffers (Bug#8219).
5948 These macros can no longer be used for assignment.
5949
44f230aa
SM
5950 * buffer.c (Fget_buffer_create, Fmake_indirect_buffer):
5951 Assign struct members directly, instead of using BUF_BEGV etc.
cffc6f3b
CY
5952 (record_buffer_markers, fetch_buffer_markers): New functions for
5953 recording and fetching special buffer markers.
5954 (set_buffer_internal_1, set_buffer_temp): Use them.
5955
5956 * lread.c (unreadchar): Use SET_BUF_PT_BOTH.
5957
5958 * insdel.c (adjust_point): Use SET_BUF_PT_BOTH.
5959
5960 * intervals.c (temp_set_point_both): Use SET_BUF_PT_BOTH.
5961 (get_local_map): Use SET_BUF_BEGV_BOTH and SET_BUF_ZV_BOTH.
5962
5963 * xdisp.c (hscroll_window_tree):
5964 (reconsider_clip_changes): Use PT instead of BUF_PT.
5965
d251f04b
EZ
59662011-03-13 Eli Zaretskii <eliz@gnu.org>
5967
5968 * makefile.w32-in ($(BLD)/editfns.$(O)): Depend on
5969 $(EMACS_ROOT)/lib/intprops.h.
5970
f0c77cd1
PE
59712011-03-13 Paul Eggert <eggert@cs.ucla.edu>
5972
3eca4629
PE
5973 Fix more problems found by GCC 4.5.2's static checks.
5974
7c86ee98
PE
5975 * gtkutil.c (xg_get_pixbuf_from_pixmap): Add cast from char *
5976 to unsigned char * to avoid compiler diagnostic.
b0afc268
PE
5977 (xg_free_frame_widgets): Make it clear that a local variable is
5978 needed only if USE_GTK_TOOLTIP.
01e0b5ad
PE
5979 (gdk_window_get_screen): Make it clear that this macro is needed
5980 only if USE_GTK_TOOLTIP.
1e5524e7
PE
5981 (int_gtk_range_get_value): New function, which avoids a diagnostic
5982 from gcc -Wbad-function-cast.
5983 (xg_set_toolkit_scroll_bar_thumb): Use it.
5984 (xg_tool_bar_callback, xg_tool_item_stale_p): Rewrite to avoid
5985 diagnostic from gcc -Wbad-function-cast.
65dc836c
PE
5986 (get_utf8_string, xg_get_file_with_chooser):
5987 Rename locals to avoid shadowing.
5988 (create_dialog): Move locals to avoid shadowing.
7c86ee98 5989
41729b81
PE
5990 * xgselect.c (xg_select): Remove unused var.
5991
f0c77cd1
PE
5992 * image.c (four_corners_best): Mark locals as initialized.
5993 (gif_load): Initialize transparent_p to zero (Bug#8238).
5994 Mark another local as initialized.
ec6cf4c6 5995 (my_png_error, my_error_exit): Mark with NO_RETURN.
f0c77cd1 5996
ce0ad53d 5997 * image.c (clear_image_cache): Now static.
d5d5a617 5998 (DIM, HAVE_STDLIB_H_1): Remove unused macros.
e22cffbc 5999 (xpm_load): Redo to avoid "discards qualifiers" gcc warning.
77a765fd
PE
6000 (x_edge_detection): Remove unnecessary cast that
6001 gcc -Wbad-function-cast diagnoses.
2037898d 6002 (gif_load): Fix pointer signedness.
6ae141d6
PE
6003 (clear_image_cache, xbm_read_bitmap_data, x_detect_edges):
6004 (jpeg_load, gif_load): Rename locals to avoid shadowing.
ce0ad53d 6005
33383987 60062011-03-12 Paul Eggert <eggert@cs.ucla.edu>
3eca4629 6007
d32df629
PE
6008 Improve quality of tests for time stamp overflow.
6009 For example, without this patch (encode-time 0 0 0 1 1
6010 1152921504606846976) returns the obviously-bogus value (-948597
6011 62170) on my RHEL 5.5 x86-64 host. With the patch, it correctly
6012 reports time overflow. See
6013 <http://lists.gnu.org/archive/html/emacs-devel/2011-03/msg00470.html>.
b8d9bd41
PE
6014 * deps.mk (editfns.o): Depend on ../lib/intprops.h.
6015 * editfns.c: Include limits.h and intprops.h.
6016 (TIME_T_MIN, TIME_T_MAX): New macros.
6017 (time_overflow): Move earlier, to before first use.
6018 (hi_time, lo_time): New functions, for an accurate test for
6019 out-of-range times.
6020 (Fcurrent_time, Fget_internal_run_time, make_time): Use them.
6021 (Fget_internal_run_time): Don't assume time_t fits in int.
6022 (make_time): Use list2 instead of Fcons twice.
6023 (Fdecode_time): More accurate test for out-of-range times.
6024 (check_tm_member): New function.
6025 (Fencode_time): Use it, to test for out-of-range times.
d32df629
PE
6026 (lisp_time_argument): Don't rely on undefined left-shift and
6027 right-shift behavior when checking for time stamp overflow.
8be6f318 6028
fe31d94c
PE
6029 * editfns.c (time_overflow): New function, refactoring common code.
6030 (Fformat_time_string, Fdecode_time, Fencode_time):
6031 (Fcurrent_time_string): Use it.
6032
8be6f318
PE
6033 Move 'make_time' to be next to its inverse 'lisp_time_argument'.
6034 * dired.c (make_time): Move to ...
6035 * editfns.c (make_time): ... here.
6036 * systime.h: Note the move.
6037
09d9db2c 60382011-03-12 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
c47cbdfd 6039
126bc0dc
YM
6040 * fringe.c (update_window_fringes): Remove unused variables.
6041
c47cbdfd
YM
6042 * unexmacosx.c (copy_data_segment): Also copy __got section.
6043 (Bug#8223)
6044
7ac80be9
EZ
60452011-03-12 Eli Zaretskii <eliz@gnu.org>
6046
c96bbc66 6047 * termcap.c [MSDOS]: Include "msdos.h".
058e5dad
EZ
6048 (find_capability, tgetnum, tgetflag, tgetstr, tputs, tgetent):
6049 Constify `char *' arguments and their references according to
6050 prototypes in tparam.h.
6051
ecb0f94d 6052 * deps.mk (termcap.o): Depend on tparam.h and msdos.h.
058e5dad 6053
7ac80be9
EZ
6054 * msdos.c (XMenuAddPane): 3rd argument is `const char *' now.
6055 Adapt all references accordingly.
6056
6057 * msdos.h (XMenuAddPane): 3rd argument is `const char *' now.
6058
ef1fd07e
TT
60592011-03-11 Tom Tromey <tromey@redhat.com>
6060
6061 * buffer.c (syms_of_buffer): Remove obsolete comment.
6062
7ef4b50c
EZ
60632011-03-11 Eli Zaretskii <eliz@gnu.org>
6064
6065 * termhooks.h (encode_terminal_code): Declare prototype.
6066
6067 * msdos.c (encode_terminal_code): Don't declare prototype.
6068
6069 * term.c (encode_terminal_code): Now external again, used by
6070 w32console.c and msdos.c.
6071
44f230aa
SM
6072 * makefile.w32-in ($(BLD)/term.$(O), ($(BLD)/tparam.$(O)):
6073 Depend on $(SRC)/tparam.h, see 2011-03-11T07:24:21Z!eggert@cs.ucla.edu.
7ef4b50c 6074
4b1ec863 60752011-03-11 Paul Eggert <eggert@cs.ucla.edu>
f78faa98 6076
1714f52b 6077 Fix some minor problems found by GCC 4.5.2's static checks.
83316bf4 6078
4b1ec863
PE
6079 * fringe.c (update_window_fringes): Mark locals as initialized
6080 (Bug#8227).
6081 (destroy_fringe_bitmap, init_fringe_bitmap): Now static.
bf60f616 6082
524c7aa6
PE
6083 * alloc.c (mark_fringe_data): Move decl from here ...
6084 * lisp.h (mark_fringe_data) [HAVE_WINDOW_SYSTEM]: ... to here,
6085 to check its interface.
6086 (init_fringe_once): Do not declare unless HAVE_WINDOW_SYSTEM.
6087
a5c0af81 6088 * fontset.c (free_realized_fontset): Now static.
7519b8cd 6089 (Fset_fontset_font): Rename local to avoid shadowing.
cc6e5db1 6090 (fontset_font): Mark local as initialized.
a9a06e0b 6091 (FONTSET_SPEC, FONTSET_REPERTORY, RFONT_DEF_REPERTORY): Remove; unused.
a5c0af81 6092
b4716021
PE
6093 * xrdb.c: Include "xterm.h", to check x_load_resources's interface.
6094
811e9bac 6095 * xselect.c (x_disown_buffer_selections): Remove; not used.
7b83e2f1 6096 (TRACE3) [!defined TRACE_SELECTION]: Remove; not used.
aa0daa9f
PE
6097 (x_own_selection, Fx_disown_selection_internal): Rename locals
6098 to avoid shadowing.
6099 (x_handle_dnd_message): Remove local to avoid shadowing.
811e9bac 6100
7e3ab302
PE
6101 * lisp.h (GCPRO1_VAR, UNGCPRO_VAR): New macros,
6102 so that the caller can use some name other than gcpro1.
6103 (GCPRO1, UNGCPRO): Reimplement in terms of the new macros.
58d2d479
PE
6104 * xfns.c (Fx_create_frame, x_create_tip_frame, Fx_show_tip):
6105 (Fx_backspace_delete_keys_p):
6106 Use them to avoid shadowing, and rename vars to avoid shadowing.
6107 (x_decode_color, x_set_name, x_window): Now static.
6b437900 6108 (Fx_create_frame): Add braces to silence GCC warning.
c0951e53 6109 (Fx_file_dialog, Fx_select_font): Fix pointer signedness.
06b0c8a0
PE
6110 (x_real_positions, xg_set_icon_from_xpm_data, x_create_tip_frame):
6111 Remove unused locals.
7e3ab302
PE
6112 (Fx_create_frame, x_create_tip_frame, Fx_show_tip):
6113 (Fx_backspace_delete_keys_p): Rename locals to avoid shadowing.
6114 Some of these renamings use the new GCPRO1_VAR and UNGCPRO_VAR
6115 macros.
f78faa98 6116
e2b13473
PE
6117 * xterm.h (x_mouse_leave): New decl.
6118
77f23912
PE
6119 * xterm.c (x_copy_dpy_color, x_focus_on_frame, x_unfocus_frame):
6120 Remove unused functions.
cdf4ba58
PE
6121 (x_shift_glyphs_for_insert, XTflash, XTring_bell):
6122 (x_calc_absolute_position): Now static.
7411c686 6123 (XTread_socket): Don't define label "out" unless it's used.
2b07bcff 6124 Don't declare local "event" unless it's used.
ed7bf3a5
PE
6125 (x_iconify_frame, x_free_frame_resources): Don't declare locals
6126 unless they are used.
38d0b34a
PE
6127 (XEMBED_VERSION, xembed_set_info): Don't define unless needed.
6128 (x_fatal_error_signal): Remove; not used.
a6067996
PE
6129 (x_draw_image_foreground, redo_mouse_highlight, XTmouse_position):
6130 (x_scroll_bar_report_motion, handle_one_xevent, x_draw_bar_cursor):
6131 (x_error_catcher, x_connection_closed, x_error_handler):
6132 (x_error_quitter, xembed_send_message, x_iconify_frame):
6133 (my_log_handler): Rename locals to avoid shadowing.
28f1c698 6134 (x_delete_glyphs, x_ins_del_lines): Mark with NO_RETURN.
2a8fade0 6135 (x_connection_closed): Tell GCC not to suggest NO_RETURN.
77f23912 6136
44f230aa
SM
6137 * xfaces.c (clear_face_cache, Fx_list_fonts, Fface_font):
6138 Rename or move locals to avoid shadowing.
6b463e58 6139 (tty_defined_color, merge_face_heights): Now static.
5967d051 6140 (free_realized_faces_for_fontset): Remove; not used.
1e9966ea
PE
6141 (Fx_list_fonts): Mark variable that gcc -Wuninitialized
6142 does not deduce is never used uninitialized.
73719eba
PE
6143 (STRDUPA, LSTRDUPA, FONT_POINT_SIZE_QUANTUM): Remove; not used.
6144 (LFACEP): Define only if XASSERTS, as it's not needed otherwise.
071048a3 6145
426994c3 6146 * terminal.c (store_terminal_param): Now static.
5489860b 6147
032f1620 6148 * xmenu.c (menu_highlight_callback): Now static.
9d66f88e 6149 (set_frame_menubar): Remove unused local.
d4323972 6150 (xmenu_show): Rename parameter to avoid shadowing.
6d1f7fee
PE
6151 (xmenu_show, xdialog_show, xmenu_show): Make local pointers "const"
6152 since they might point to immutable storage.
281585b0
PE
6153 (next_menubar_widget_id): Declare only if USE_X_TOOLKIT,
6154 since it's unused otherwise.
032f1620 6155
367c19e5 6156 * xdisp.c (produce_glyphless_glyph): Initialize lower_xoff.
53df7c11 6157 Add a FIXME, since the code still doesn't look right. (Bug#8215)
9f36b9fd
PE
6158 (Fcurrent_bidi_paragraph_direction): Simplify slightly; this
6159 avoids a gcc -Wuninitialized diagnostic.
0e086e8f 6160 (display_line, BUILD_COMPOSITE_GLYPH_STRING, draw_glyphs):
44a3a108
PE
6161 (note_mouse_highlight): Mark variables that gcc -Wuninitialized
6162 does not deduce are never used uninitialized.
70739cbe 6163
07b48fa9
PE
6164 * lisp.h (IF_LINT): New macro, copied from ../lib-src/emacsclient.c.
6165
8868a238 6166 * xdisp.c (redisplay_window): Rename local to avoid shadowing.
4554d213
PE
6167 * window.c (window_loop, size_window):
6168 (run_window_configuration_change_hook, enlarge_window): Likewise.
8868a238 6169
7e5cf297 6170 * window.c (display_buffer): Now static.
d6550a9f
PE
6171 (size_window): Mark variables that gcc -Wuninitialized
6172 does not deduce are never used uninitialized.
a586633d
PE
6173 * window.h (check_all_windows): New decl, to forestall
6174 gcc -Wmissing-prototypes diagnostic.
5b555da1 6175 * dispextern.h (bidi_dump_cached_states): Likewise.
7e5cf297 6176
f6095868
PE
6177 * charset.h (CHECK_CHARSET_GET_CHARSET): Rename locals to avoid
6178 shadowing.
6179 * charset.c (map_charset_for_dump, Fchar_charset): Likewise.
726929c4
PE
6180 Include <limits.h>.
6181 (Fsort_charsets): Redo min/max calculation to shorten the code a bit
6182 and to avoid gcc -Wuninitialized warning.
89ef49df
PE
6183 (load_charset_map): Mark variables that gcc -Wuninitialized
6184 does not deduce are never used uninitialized.
53df7c11 6185 (load_charset): Abort instead of using uninitialized var (Bug#8229).
f6095868 6186
f38b440c
PE
6187 * coding.c (coding_set_source, coding_set_destination):
6188 Use "else { /* comment */ }" rather than "else /* comment */;"
6189 for clarity, and to avoid gcc -Wempty-body warning.
2735d060
PE
6190 (Fdefine_coding_system_internal): Don't redeclare 'i' inside
6191 a block, when the outer 'i' will do.
6192 (decode_coding_utf_8, decode_coding_utf_16, detect_coding_emacs_mule):
6193 (emacs_mule_char, decode_coding_emacs_mule, detect_coding_iso_2022):
6194 (decode_coding_iso_2022, decode_coding_sjis, decode_coding_big5):
6195 (decode_coding_raw_text, decode_coding_charset, get_translation_table):
6196 (Fdecode_sjis_char, Fdefine_coding_system_internal):
6197 Rename locals to avoid shadowing.
6198 * character.h (FETCH_STRING_CHAR_ADVANCE): Likewise.
e2f1bab9
PE
6199 * coding.c (emacs_mule_char, encode_invocation_designation):
6200 Now static, since they're not used elsewhere.
413bb2db 6201 (decode_coding_iso_2022): Add "default: abort ();" as a safety check.
c4a63b12 6202 (decode_coding_object, encode_coding_object, detect_coding_system):
ee05f961
PE
6203 (decode_coding_emacs_mule): Mark variables that gcc
6204 -Wuninitialized does not deduce are never used uninitialized.
160b01f6
PE
6205 (detect_coding_iso_2022): Initialize a local variable that might
6206 be used uninitialized. Leave a FIXME because it's not clear that
53df7c11 6207 this initialization is needed. (Bug#8211)
5f58e762
PE
6208 (ISO_CODE_LF, ISO_CODE_CR, CODING_ISO_FLAG_EUC_TW_SHIFT):
6209 (ONE_MORE_BYTE_NO_CHECK, UTF_BOM, UTF_16_INVALID_P):
6210 (SHIFT_OUT_OK, ENCODE_CONTROL_SEQUENCE_INTRODUCER):
6211 (ENCODE_DIRECTION_R2L, ENCODE_DIRECTION_L2R):
6212 Remove unused macros.
f38b440c 6213
232b38b9 6214 * category.c (hash_get_category_set): Remove unused local var.
9f3b5e69 6215 (copy_category_table): Now static, since it's not used elsewhere.
d0891610 6216 * character.c (string_count_byte8): Likewise.
232b38b9 6217
fb90da1b
PE
6218 * ccl.c (CCL_WRITE_STRING, CCL_ENCODE_CHAR, Fccl_execute_on_string):
6219 (Fregister_code_conversion_map): Rename locals to avoid shadowing.
6220
fb93dbc2
PE
6221 * chartab.c (copy_sub_char_table): Now static, since it's not used
6222 elsewhere.
5c156ace
PE
6223 (sub_char_table_ref_and_range, char_table_ref_and_range):
6224 Rename locals to avoid shadowing.
bbcd0949 6225 (ASET_RANGE, GET_SUB_CHAR_TABLE): Remove unused macros.
fb93dbc2 6226
7d3b3862 6227 * bidi.c (bidi_check_type): Now static, since it's not used elsewhere.
630d6892 6228 (BIDI_BOB): Remove unused macro.
7d3b3862 6229
6be7d3da
PE
6230 * cm.c (cmgoto): Mark variables that gcc -Wuninitialized does not
6231 deduce are never used uninitialized.
c2ed9c8b 6232 * term.c (encode_terminal_code): Likewise.
6be7d3da 6233
75f8807f 6234 * term.c (encode_terminal_code): Now static. Remove unused local.
72abad34 6235
50938595
PE
6236 * tparam.h: New file.
6237 * term.c, tparam.h: Include it.
6238 * deps.mk (term.o, tparam.o): Depend on tparam.h.
6239 * term.c (tputs, tgetent, tgetflag, tgetnum, tparam, tgetstr):
6240 Move these decls to tparam.h, and make them agree with what
6241 is actually in tparam.c. The previous trick of using incompatible
6242 decls in different modules does not conform to the C standard.
6243 All callers of tparam changed to use tparam's actual API.
6244 * tparam.c (tparam1, tparam, tgoto):
6245 Use const pointers where appropriate.
6246
fbceeba2
PE
6247 * cm.c (calccost, cmgoto): Use const pointers where appropriate.
6248 * cm.h (struct cm): Likewise.
6249 * dispextern.h (do_line_insertion_deletion_costs): Likewise.
6250 * scroll.c (ins_del_costs, do_line_insertion_deletion_costs): Likewise.
6251 * term.c (tty_ins_del_lines, calculate_costs, struct fkey_table):
6252 (term_get_fkeys_1, append_glyphless_glyph, produce_glyphless_glyph):
6253 (turn_on_face, init_tty): Likewise.
6254 * termchar.h (struct tty_display_info): Likewise.
fbceeba2 6255
7f3f1250
PE
6256 * term.c (term_mouse_position): Rename local to avoid shadowing.
6257
e6ca6543
PE
6258 * alloc.c (mark_ttys): Move decl from here ...
6259 * lisp.h (mark_ttys): ... to here, so that it's checked against defn.
6260
c40f8d15
AS
62612011-03-11 Andreas Schwab <schwab@linux-m68k.org>
6262
6263 * .gdbinit (pwinx, xbuffer): Fix access to buffer name.
6264
cfe0661d
JB
62652011-03-09 Juanma Barranquero <lekktu@gmail.com>
6266
6267 * search.c (compile_pattern_1): Remove argument regp, unused since
6268 revid:rms@gnu.org-19941211082627-3x1g1wyqkjmwloig.
6269 (compile_pattern): Don't pass it.
6270
0afb4571
J
62712011-03-08 Jan Djärv <jan.h.d@swipnet.se>
6272
6273 * xterm.h (DEFAULT_GDK_DISPLAY): New define.
6274 (GDK_WINDOW_XID, gtk_widget_get_preferred_size): New defines
6275 for ! HAVE_GTK3.
6276 (GTK_WIDGET_TO_X_WIN): Use GDK_WINDOW_XID.
6277
6278 * xmenu.c (menu_position_func): Call gtk_widget_get_preferred_size.
6279
6280 * gtkutil.c: Include gtkx.h if HAVE_GTK3. If ! HAVE_GTK3, define
6281 gdk_window_get_screen, gdk_window_get_geometry,
6282 gdk_x11_window_lookup_for_display and GDK_KEY_g.
6283 (xg_set_screen): Use DEFAULT_GDK_DISPLAY.
6284 (xg_get_pixbuf_from_pixmap): New function.
6285 (xg_get_pixbuf_from_pix_and_mask): Change parameters from GdkPixmap
6286 to Pixmap, take frame as parameter, remove GdkColormap parameter.
6287 Call xg_get_pixbuf_from_pixmap instead of
6288 gdk_pixbuf_get_from_drawable.
6289 (xg_get_image_for_pixmap): Do not make GdkPixmaps, call
6290 xg_get_pixbuf_from_pix_and_mask with Pixmap parameters instead.
6291 (xg_check_special_colors): Use GtkStyleContext and its functions
6292 for HAVE_GTK3.
6293 (xg_prepare_tooltip, xg_hide_tooltip): Call gdk_window_get_screen.
6294 (xg_prepare_tooltip, create_dialog, menubar_map_cb)
6295 (xg_update_frame_menubar, xg_tool_bar_detach_callback)
44f230aa
SM
6296 (xg_tool_bar_attach_callback, xg_update_tool_bar_sizes):
6297 Call gtk_widget_get_preferred_size.
0afb4571
J
6298 (xg_frame_resized): gdk_window_get_geometry only takes 5
6299 parameters.
44f230aa
SM
6300 (xg_win_to_widget, xg_event_is_for_menubar):
6301 Call gdk_x11_window_lookup_for_display.
0afb4571
J
6302 (xg_set_widget_bg): New function.
6303 (delete_cb): New function.
895009e1 6304 (xg_create_frame_widgets): Connect delete-event to delete_cb.
0afb4571
J
6305 Call xg_set_widget_bg. Only set backgrund pixmap for ! HAVE_GTK3
6306 (xg_set_background_color): Call xg_set_widget_bg.
6307 (xg_set_frame_icon): Call xg_get_pixbuf_from_pix_and_mask.
6308 (xg_create_scroll_bar): vadj is a GtkAdjustment for HAVE_GTK3.
6309 Only call gtk_range_set_update_policy if ! HAVE_GTK3.
6310 (xg_make_tool_item): Only connect xg_tool_bar_item_expose_callback
6311 if ! HAVE_GTK3.
6312 (update_frame_tool_bar): Call gtk_widget_hide.
6313 (xg_initialize): Use GDK_KEY_g.
6314
6315 * xsmfns.c (gdk_set_sm_client_id): Define to gdk_set_sm_client_id
6316 if ! HAVE_GTK3
6317 (x_session_initialize): Call gdk_x11_set_sm_client_id.
6318
6319 * xterm.c (XFillRectangle): Use cairo routines for HAVE_GTK3.
6320 (x_term_init): Disable Xinput(2) with GDK_CORE_DEVICE_EVENTS.
6321 Load ~/emacs.d/gtkrc only for ! HAVE_GTK3.
6322
1c2cc4ef
JB
63232011-03-08 Juanma Barranquero <lekktu@gmail.com>
6324
6325 * w32xfns.c (select_palette): Check success of RealizePalette against
6326 GDI_ERROR, not zero.
6327
33383987 6328See ChangeLog.11 for earlier changes.
aac0c6e3
MR
6329
6330;; Local Variables:
6331;; coding: utf-8
aac0c6e3
MR
6332;; End:
6333
33383987 6334 Copyright (C) 2011 Free Software Foundation, Inc.
aac0c6e3
MR
6335
6336 This file is part of GNU Emacs.
6337
6338 GNU Emacs is free software: you can redistribute it and/or modify
6339 it under the terms of the GNU General Public License as published by
6340 the Free Software Foundation, either version 3 of the License, or
6341 (at your option) any later version.
6342
6343 GNU Emacs is distributed in the hope that it will be useful,
6344 but WITHOUT ANY WARRANTY; without even the implied warranty of
6345 MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
6346 GNU General Public License for more details.
6347
6348 You should have received a copy of the GNU General Public License
6349 along with GNU Emacs. If not, see <http://www.gnu.org/licenses/>.